Use the message generation framework

This updates transport to use the message generation framework from https://github.com/gazebosim/gz-msgs/pull/339

This works for me. I guess we'll need to merge gz-msgs first and release it, that's why I won't approve yet.

we don't need to release this; we just need nightly builds

@osrf-jenkins run tests please

I found some other issues in https://github.com/gazebosim/gz-msgs/pull/339#discussion_r1247319505, and I believe they are addressed by the following PRs:

https://github.com/gazebosim/gz-cmake/pull/362
https://github.com/gazebosim/gz-msgs/pull/359

Testing with specially-named branches:

https://github.com/gazebosim/gz-transport/pull/416
 https://build.osrfoundation.org/job/ignition_transport-ci-pr_any-homebrew-amd64/1566/
 https://build.osrfoundation.org/job/ign_transport-pr-win/535/

Running protoc on C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//share/protos/gz/msgs/actor.proto

  --ignmsgs_out: protoc-gen-ignmsgs: The system cannot find the file specified.

  Failed to execute protoc compiler: Command
 '['C:/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe',
 '--proto_path=C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//share/protos',
 '--plugin=protoc-gen-ignmsgs=C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//bin/gz-msgs10_protoc_plugin',
 '--cpp_out=C:/J/workspace/ign_transport-pr-win/ws/build/gz-transport13/gz_msgs_gen',
 '--ignmsgs_out=C:/J/workspace/ign_transport-pr-win/ws/build/gz-transport13/gz_msgs_gen',
 'C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10/share/protos/gz/msgs/actor.proto']'
 returned non-zero exit status 1.

I built a jammy nightly of gz-msgs10 (see https://github.com/gazebo-release/gz-msgs10-release/pull/3#issuecomment-1624490508) and ran the jammy jenkins build for this branch, and it also has some test failures:

https://build.osrfoundation.org/job/gz_transport-ci-pr_any-jammy-amd64/32/


Use a variable to enable aws:ec2:vpc:AssociatePublicIpAddress

what

This pull request just adds a variable to enable the automatic creation of Elastic IP attached to instances.

why

If there is not NAT gateway in private_subnets (but an Internet gateway) there is a need to attach Elastic IP to instances in order to communicate with Elastic BeanStalk publics endpoints.
I agree with the default value set before, false; a correct setup has a NAT gateway in a private subnet :)

sources

https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/vpc.html
https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/vpc-no-nat.html

s/association_public_ipaddress/association_public_ip_address/ done!

s/association_public_ip_address/associate_public_ip_address/ done!


Sidebar expandable menus are not opening

Steps to reproduce:

Go to https://reactjs.org/docs/getting-started.html
Click on any expandable section on the sidebar, for example API Reference.

Result:

Expandables are not expanded, cannot navigate to any of the sidebar sections.

https://github.com/reactjs/reactjs.org/issues/3437#issuecomment-740622093

Should be resolved: https://twitter.com/reactjs/status/1336729989161635842


#28617 - implemented according to comments in PR

Why should that be a command and not proper API?

@bpasero gave an example on how this should be done on the previous pull request. I have deleted that one since my fork got messed up and had to clean/pull from upstream.
The example given was for _workbench.open

As for the name of the command, not sure if @jrieken has objections with vscode.quickOpen. For a user I think the difference between the picker (e.g. showQuickPick) and our quick open thing is not so obvious. For a user it will always be the picker.

Unsure, about overloading showQuickPick because today it allows you to pick an item from a list of items. We won't be able to do that with the prefix. I do have a bunch of requests to make the quick-pick API and richer and prefixed-picks are part of that but these feature requests sit behind a pile a debt that needs to be removed first.
What I don't understand is why another command (vscode.quickOpen) is introduced at all. There is already workbench.action.quickOpen which is no more or less API then such a command would be. Introducing another command seems confusing and like boiler plate code. IMO the right thing to do here is making the workbench.action.quickOpen-command accept an argument

@jrieken yes I like that. is every command we register on the workbench side automatically available from extensions?
@cristianhosu can we introduce a command with the same ID as the action and use that from the action?

is every command we register on the workbench side automatically available from extensions?

Yes, every command is everywhere. By convention commands starting with an underscore are internal and should be used.

can we introduce a command with the same ID as the action and use that from the action?

I don't think so. i believe that the shortcut will look into both actions and commands and search for one with the given name, thus it might be error prone to have the same name. We could however remove the action altogether and leave only the action so to reduce the ambiguity.

What I don't understand is why another command (vscode.quickOpen) is introduced at all. There is already workbench.action.quickOpen which is no more or less API then such a command would be. Introducing another command seems confusing and like boiler plate code. IMO the right thing to do here is making the workbench.action.quickOpen-command accept an argument

Initially that's how it was made, but maybe a command is easier to migrate to an actual API if needed in the future (I'm just guessing).
But we could as I mentioned remove the action.
Either way... Whatever you guys decide, I'll do it :)

Yes, replacing the action with a command sounds good to me. As long as the action still shows up in the command palette.

Now, the command executes the show method from the service. The same one
that gets executed from the action.
I should remove the _ from the command name to mark it as public instead of
using the internal naming. So right now both the command and the action
cand be linked to the key binding but only the command supports prefix.
How should I remove the action without removing it also from the command
pallette?
On Jun 19, 2017 7:33 PM, "Benjamin Pasero"<EMAIL_ADDRESS>wrote:
Yes, replacing the action with a command sounds good to me. As long as the
action still shows up in the command palette.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/pull/28952#issuecomment-309494600,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ3E7j8CBGzEQA8ZExJyDwP7yZA9F13Eks5sFqLFgaJpZM4N9bUu
.

Thanks, I will have a look.

@jrieken I've pushed another commit.
Now that I've also seen the code it kinda makes more sense. Hopefully I understood correctly :)
Wouldn't it be a good idea to modify most, if not all, of the commands from commands.ts to isolate them into their own namespace?

@jrieken : So much win! Thank you
On Mon, Jun 26, 2017 at 9:18 AM, Johannes Rieken<EMAIL_ADDRESS>wrote:

@jrieken approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/pull/28952#pullrequestreview-46179888,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ3E7vCu-CRICTcxpGtp7NZ7CI838yRDks5sH01RgaJpZM4N9bUu
.

--
Cristian Hosu
+40740.058.711

@cristianhosu what is the motivation of the change in watermark.ts?

Of course. Are there any other changes that should be made? For the
watermark file for example? Maybe somehow using the command instead of the
action?
On Jun 28, 2017 5:59 PM, "Benjamin Pasero"<EMAIL_ADDRESS>wrote:

@bpasero commented on this pull request.
In src/vs/workbench/electron-browser/commands.ts
https://github.com/Microsoft/vscode/pull/28952#discussion_r124565088:

@@ -423,3 +424,24 @@ export function registerCommands(): void {
});
});
}

+namespace GlobalQuickOpenCommand {
@cristianhosu https://github.com/cristianhosu looks like currently we
are not using this explicitly but this test shows how to add a command to
the F1 list: https://github.com/Microsoft/vscode/blob/master/src/vs/
platform/actions/test/common/menuService.test.ts#L192
Can you add this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/pull/28952#discussion_r124565088,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ3E7t7FpvcbK8V50WgS3gcGYthx-jaGks5sImpIgaJpZM4N9bUu
.

@cristianhosu yes, instead of removing the references to the now deleted action, you should export the ID of your new command and use that instead.

I don't know why the build is failing... can you guys help me out?

@cristianhosu looks like an unrelated test failure that also happens on our master. let me know when you are ready for another review.

Since the build failure is unrelated to my commit, then I think I am ready
:)
On Jul 7, 2017 07:51, "Benjamin Pasero"<EMAIL_ADDRESS>wrote:

@cristianhosu https://github.com/cristianhosu looks like an unrelated
test failure that also happens on our master. let me know when you are
ready for another review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/pull/28952#issuecomment-313586277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ3E7hM1YR30cT070n1HqleQzDYygeUnks5sLblOgaJpZM4N9bUu
.

@cristianhosu thanks, I was not able to use your PR directly because of some changes still needed. I went ahead and pushed https://github.com/Microsoft/vscode/commit/00956174ca39042b3c86e4a58c6f67aa21368bcd on top of your work. Will make sure to mention you and this PR in our July release notes.


(fix-bug) Killing the parent process when child process exit with status 1

Killing the parent process when the child process exited with status 1
Signed-off-by: mittachaitu<EMAIL_ADDRESS>

Since it is executing as a child process it is exiting with exit code 0


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_a622681c-b678-43e5-a981-b19dc59918fc/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_a622681c-b678-43e5-a981-b19dc59918fc.git

Docs Build status updates of commit 31224f3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-source-1' (branch: Release_Archive_main_2022-02-21-02-20-10) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Publisher for multiple sources

Rewrite the publisher to allow gathering contents from multiple sources to the destination repository. For example, kubernetes/client-go/1.5 gets its content from the staging/.../1.5 in the master branch of the main repository, and kubernetes/client-go/1.4 gets its content from the staging/.../1.4 in the release-1.4 branch of the main repository
Example: https://github.com/caesarxuchao/client-go/commit/a0c3ac3da0ab929aba25d0cdb6cf42885309b06b

This change is

I am worried that having logic that crosses the go/shell boundary makes it harder to reason about.  (This is more about clone.sh and construct.sh, notpublish.sh )
WDYT of moving the logic of those two into go code?

Reviewed 2 of 9 files at r1.
Review status: 2 of 8 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

I don't like the mix either, but some operations are hard in Golang, e.g., removing an entire directory, or copy a file, so I got stuck with those two bash files.

We can still use exec.Command("rm -rf ..."), but move them into a go function.  Like
func cloneOrDie(destDir, destUrl string) {
...
}

Review status: 2 of 8 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Oh, ok. Do you have other comments? I'll revise when you have done a pass.

Just a few suggestions.

Review status: 2 of 8 files reviewed at latest revision, 4 unresolved discussions.

mungegithub/mungers/publish.sh, line 55 [r2] (raw file):

    exit 0
fi
git commit -m "published by bot

It is really awesome to add a link back to the source code here, for some future person trying to figure out "where do these commits come from?"
published by bot (https://github.com/kubernetes/contrib/tree/master/mungegithub/mungers)

mungegithub/mungers/publisher.go, line 32 [r2] (raw file):

)

type info struct {

Should this type be named source?

mungegithub/mungers/publisher.go, line 42 [r2] (raw file):

	dstRepo string
	// multiple sources mapping to different directories in the dstRepo
	srcToDst map[info]string

Instead of srcToDst how about srcToSubdir?

Comments from Reviewable

@mml I've addressed the comments. PTAL. Thank you.
You can see a sample commit here: https://github.com/caesarxuchao/client-go/commit/ebc2f76fc702a0559ed59eedec7168978c8d4a3f

Reviewed 3 of 9 files at r1, 1 of 3 files at r2, 2 of 4 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Comments from Reviewable

Squashed the commits. I'll deploy the publish after https://github.com/kubernetes/kubernetes/pull/32906 gets merged.

Inherit the old lgtm.

/lgtm


Flex Volume failed to attach volume on Google Container Engine

Torus version: torus_v0.1.2_darwin_amd64
I want to try torus on Google Container Engine, so I followed the instruction here to set up everything. I was able to create torus volume, but I got stuck at step 6.
I thought that was because torus's deriver wasn't installed on my kubernetes nodes. So I ssh into each node and ran these commands:
mkdir -p /usr/libexec/kubernetes/kubelet-plugins/volume/exec/coreos.com~torus/
wget https://github.com/coreos/torus/releases/download/v0.1.2/torus_v0.1.2_darwin_amd64.zip
unzip torus_v0.1.2_darwin_amd64.zip
cp torus_v0.1.2_darwin_amd64/torusblk /usr/libexec/kubernetes/kubelet-plugins/volume/exec/coreos.com~torus/torus
sudo /etc/init.d/kubelet restart
modprobe nbd nbds_max=32

Then I was told that dbus was missing, so I ran:
sudo apt-get update
sudo apt-get install dbus
sudo /etc/init.d/dbus restart

Then I re-tried step 6 but it failed again with the following reason:
I1213 22:26:12.879596   19183 kubelet.go:2534] SyncLoop (ADD, "api"): "postgres-torus-1327974524-gchf1_default(277bb2b1-c183-11e6-af49-42010a800003)"
I1213 22:26:12.947717   19183 reconciler.go:253] MountVolume operation started for volume "kubernetes.io/secret/default-token-w62uh" (spec.Name: "default-token-w62uh") to pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
I1213 22:26:12.947777   19183 reconciler.go:179] VerifyControllerAttachedVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003")
I1213 22:26:12.953321   19183 operation_executor.go:720] MountVolume.SetUp succeeded for volume "kubernetes.io/secret/default-token-w62uh" (spec.Name: "default-token-w62uh") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
I1213 22:26:13.047988   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:13.066458   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:13.566453387 +0000 UTC (durationBeforeRetry 500ms). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:13.649516   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:13.664908   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:14.664901883 +0000 UTC (durationBeforeRetry 1s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:14.756027   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:14.771306   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:16.771300335 +0000 UTC (dur
ationBeforeRetry 2s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-
c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:16.774367   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:16.790067   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:20.790061044 +0000 UTC (dur
ationBeforeRetry 4s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-
c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:20.889834   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:20.905328   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:28.905321172 +0000 UTC (dur
ationBeforeRetry 8s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-
c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:28.911182   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:28.926574   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:26:44.926567371 +0000 UTC (dur
ationBeforeRetry 16s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1
-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:26:44.956309   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:26:44.971656   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:27:16.971650496 +0000 UTC (dur
ationBeforeRetry 32s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1
-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:27:17.044740   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:27:17.061294   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:28:21.06128704 +0000 UTC (dura
tionBeforeRetry 1m4s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1
-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
E1213 22:28:12.880494   19183 kubelet.go:1930] Unable to mount volumes for pod "postgres-torus-1327974524-gchf1_default(277bb2b1-c183-11e6-af49-42010a800003)": timeout expired wait
ing for volumes to attach/mount for pod "postgres-torus-1327974524-gchf1"/"default". list of unattached/unmounted volumes=[data]; skipping pod
E1213 22:28:12.880566   19183 pod_workers.go:183] Error syncing pod 277bb2b1-c183-11e6-af49-42010a800003, skipping: timeout expired waiting for volumes to attach/mount for pod "pos
tgres-torus-1327974524-gchf1"/"default". list of unattached/unmounted volumes=[data]
I1213 22:28:21.129527   19183 reconciler.go:253] MountVolume operation started for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") to pod "277bb2b1-c183-11e6-af49-42
010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").
E1213 22:28:21.144134   19183 goroutinemap.go:155] Operation for "coreos.com/torus/coreos.com/torus" failed. No retries permitted until 2016-12-13 22:30:21.144128534 +0000 UTC (dur
ationBeforeRetry 2m0s). error: MountVolume.SetUp failed for volume "coreos.com/torus/coreos.com/torus" (spec.Name: "data") pod "277bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b
1-c183-11e6-af49-42010a800003") with: attach command failed, status: Failure, reason: The name org.freedesktop.systemd1 was not provided by any .service files
I1213 22:28:25.543083   19183 reconciler.go:253] MountVolume operation started for volume "kubernetes.io/secret/default-token-w62uh" (spec.Name: "default-token-w62uh") to pod "277b
b2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003"). Volume is already mounted to pod, but remount was requested.
I1213 22:28:25.546560   19183 operation_executor.go:720] MountVolume.SetUp succeeded for volume "kubernetes.io/secret/default-token-w62uh" (spec.Name: "default-token-w62uh") pod "2
77bb2b1-c183-11e6-af49-42010a800003" (UID: "277bb2b1-c183-11e6-af49-42010a800003").

This host is running on systemd? FlexVolume doesn't support non-systemd system as below:
https://github.com/coreos/torus/tree/master/contrib/kubernetes#1-install-torustorusblk-in-kubelet-volume-plugin-directory

NOTICE: The FlexVolume functionality currently uses systemd to manage its lifecycle. Running as a FlexVolume on non-systemd systems is TBD

is torus going to work on google container engine any time soon???


Fix UnassignedDurationError of update_from_instruction_schedule_map

Summary
Update_from_instruction_schedule_map failed when the duration of schedules is treated as a parameter.
I added try.. except statement and set duration None when the duration is the parameter.
Details and comments

Thanks @to24toro could you please add a test to https://github.com/Qiskit/qiskit-terra/blob/a804df58c8e59c101fc3c13ef6a1a4cb172b9a5b/test/python/transpiler/test_target.py#L1144 and write a release note with bugfix?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
44 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.02%) to 86.071%

Files with Coverage Reduction
New Missed Lines
%

qiskit/transpiler/passes/layout/dense_layout.py
1
95.1%

crates/qasm2/src/lex.rs
2
91.14%

qiskit/extensions/quantum_initializer/squ.py
2
80.0%

qiskit/transpiler/preset_passmanagers/level1.py
3
96.67%

qiskit/transpiler/preset_passmanagers/common.py
10
91.58%

qiskit/dagcircuit/dagcircuit.py
26
90.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
72688

Relevant Lines:
84451

💛  - Coveralls


MUMUP-2366 : Details page back to x

Main Change

If one searches for something, then reads about details, then clicks back, it goes back to there search result

If one browses for something, then reads about details, then clicks back, it goes back to there browse session

Minor cleanup on the marketplace-entry page

Changed from custom style for categories to use the outline button with some different coloring.
Changed details link to be an outline button
Changed that bottom area to be a grid

Before

After

Minor change to search result page

Now if you hit a search result from where ever it'll have the search term in the search box (this was done in https://github.com/UW-Madison-DoIT/uw-frame/pull/157)

Before

After

I didn't even notice that there were two back to search buttons on the details page.  I always use the bottom one.

great stuff :+1:

:+1:

:+1:

Waiting on review of https://github.com/UW-Madison-DoIT/uw-frame/pull/158 and then I'll merge this change.

:+1:. Love the attention to detail on this.