Expand Inline Suggest settings

Problem statement
We get a lot of reports from different user groups that would like to have a better control over what suggestions are shown and where. While some like comment completions, some don't. Some do feel impacted when completions are shown immediately, and some don't like completions shown on specific operations in the editor.
Most of these are not solvable in the extension (where we listen to the inline suggest providers), as we do not get enough signals to handle these behaviors.
Proposal
Settings:

Disable on removal - Stops retrieval of new Inline Suggest completions while user is deleting. In many cases we observed that this would just produce the same line over again to the user, which is not always what users want.
Disable on location (comment/string) - Same as we have for standard code completion (intellisense) - which would allow for a better control over where should completions render
Show after n ms of idle - Would allow users to configure when suggestions are shown, to not break their workflows while coding, but e.g. show  suggestion only after they have stopped typing for 5 seconds and are stuck.

Nice to have:
It would be great to also add a signal to the Extension that a request has been blocked, delayed, dropped, so FE metrics could reason about why e.g. amount of provided suggestions was reduced.
Alternative:
Add additional signals to the context of the provideInlineCompletion, to allow extensions to make the call whether to add or not to add the filtering.
This would remove the need to add additional signals when the calls are dropped on the core end, and would allow extensions to stay in control of the inline completions as well as the logging/metrics.
Happy to help implement if there is no bandwidth and we agree on a way forward :)

I think the feature request is reasonable. Thanks for the detailed write up!

It would be great to also add a signal to the Extension that a request has been blocked, delayed, dropped, so FE metrics could reason about why e.g. amount of provided suggestions was reduced.

How would that signaling look like?

Sorry for the late answer (vacation time in full swing)

How would that signaling look like?

I imagine that we can attach some kind of supplementary additionalInfo on the show/rejection signals (I know that we don't have yet rejection signals, but having those would be very helpful :) Currently we just rely on shown signals with some local patching). based on the specific listeners (model change/ keybinding trigered/ command invoked) we could attach the specified "Event".

I tend to think though that this could be entirely implemented on the extension side. Most implementors already have some kind of syntax tree, so I'm not sure if VS Code should add the requested signals.

I agree that deletion can be detected via the syntax tree or model change, but rejection via esc keys, or invocation via Suggest dropdown invocation is not something that the extension can listen to if I'm not mistaken. So having these signals available would be very helpful.
The model/suggestion provider can potentially use some signals such as force rejecting (via esc) to add a time based snooze, or content based back off to not provide the same completion while users are typing/deleting.

I'm not against the suggestion, but I'm not sure the suggestion is a good fix for problem (that the AI just suggests what the user just deleted and that this is unhelpful).
The AI could actually use a deletion as a signal on what not to suggest, or even better pick up the deleted text to predict user intention.

That is a fair point. Would it then possibly make sense to actually fire the request, just allow user to select whether the completion should be shown or not?
The check might be fairly straight forward, e.g. if the replacement in the file + current file === last file state before deletion then filter the suggestion. Ofc this might still provide the same response if user goes to a different line adds something and then comes to the same line and starts deleting.


The very last few bits for 1.0.7

Adding a new hook and "backporting" @Frenzie's code for embedding.

Wrong branch...


ch3 - epub - broken URL "official documentation of the User module"

chapter 3
.epub version
link text in book:  "official documentation of the User module"
linked URL: https://docs.ansible.com/ansible/latest/user_module.html
error on site: Oops! The version of the Ansible documentation you were looking at doesn’t contain that page.
suggested correct URL: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/user_module.html

Just ran into this too.

Sorry about that, I have fixed this separately as there were a few other issue reports for it. Oops!


Feature Request: Externalize stripStyle

Can we externalize stripStyle? I would like to use it in my code which simplifies TransitionMotion but it seems like its only an internal component. I don't see any harm in letting people use this useful tool.

Since this is so simple, I've gone ahead and created a pull request for it


Explicit type cast UUID : text

I have a table user_setting with the column name user_id of the type UUID which is the foreign key of the table user. When I query user_setting like this.
final data = await Supabase.instance.client.from('user_setting')
        .select()
        .match({"user_id": "<UUID>"});

I get this type error
PostgrestException(message: operator does not exist: uuid = text, code: 42883, details: , hint: No operator matches the given name and argument types. You might need to add explicit type casts.)

Is there any way I can cast user_id as UUID?

@stha-ums
You don't need to type cast it actually. This error occurs when the string that you are passing is not actually a UUID. Make sure the variable you are passing actually is not null or is a proper uuid format.
assert(userId != null);
final data = await Supabase.instance.client.from('user_setting')
        .select()
        .match({"user_id": userId});

I will close this issue for now as the cause should be passing a none-uuid format string or null value to the API, but if this issue persists, feel free to reopen it and let us know!


[Improvement-13437][UT] Add UT for S3StorageOperator

Purpose of the pull request

close: #13437

Brief change log
Add UT for S3StorageOperator, just like OssStorageOperatorTest

Verify this pull request
UT

Hi, @EricGao888 , could you please help review this?

Codecov Report

Merging #13530 (eb8cd25) into dev (2bd65fb) will decrease coverage by 0.16%.
The diff coverage is 41.86%.

@@             Coverage Diff              @@
##                dev   #13530      +/-   ##
============================================
- Coverage     39.47%   39.32%   -0.16%
+ Complexity     4381     4379       -2
============================================
  Files          1102     1104       +2
  Lines         41437    41674     +237
  Branches       4733     4730       -3
============================================
+ Hits          16358    16388      +30
- Misses        23262    23460     +198
- Partials       1817     1826       +9

Impacted Files
Coverage Δ

...er/plugin/storage/s3/S3StorageOperatorFactory.java
0.00% <0.00%> (ø)

...scheduler/plugin/storage/s3/S3StorageOperator.java
33.20% <45.00%> (ø)

...r/plugin/task/sqoop/parameter/SqoopParameters.java
1.19% <0.00%> (-36.91%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-7.26%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-1.39%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

... and 22 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi, @EricGao888 , I've resolved the conflicts and could you please help review this again

Will merge this PR if no more comments.


Update Fiona to v1.9

Fiona v1.9 has API changes that necessitate changes on our end. This will render us more in line with Fiona v2.0 when it is soon released. The primary change is that Fiona features are now their own class fiona.Feature containing fiona.Geometry classes. These are compatible with dict() outputs, so no changes should be needed in Raven-WPS.
For more information, see: https://github.com/Toblerity/Fiona/pull/787
Changes

Set minimum GDAL version at 3.1
pip was comparing compatible versions of sphinx_rtd_theme, so this has now been set a >=1.0.
The new Fiona API is now used for vector reprojection. Fiona.write is now used for writing output file JSONs.

Additonal Notes
~The conda package is not yet released due to a few small changes needed in their testing suite. This should be addressed soon. See: https://github.com/conda-forge/fiona-feedstock/pull/208~ - This has been released on conda-forge.

@huard
The present failures are due to service issues with our THREDDS server. Should I make these tests XFAILable?

The error I'm seeing has to do with cf-xarray:
No such file or directory: '/home/runner/work/RavenPy/RavenPy/.tox/py38/lib/python3.8/site-packages/cf_xarray/data/cf-standard-name-table.xml'

The THREDDS issues have been resolved, cf-xarray fixes are on the way: https://github.com/xarray-contrib/cf-xarray/issues/415
I'm wondering though if we should allow the THREDDS-related tests to fail since they're service-dependent. What do you think?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.388%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
3746

Relevant Lines:
4439

💛  - Coveralls

Is there a way to fail only if the service is not on ? If the service is available, but the test fails, I'd like to catch that.

I can definitely look into that. If it's simple enough that I can add it here this morning, I'll add it. Otherwise, no more changes. As it stands, though, am I good to merge?

Failing because of a new black. Opening another PR to fix this...


Chaining db.collection()

I just tried to build a query component for a simple list. I'd like to filter/orderBy/limit the list given certain parameters:
let list = firestore.collection(collection)
if (order) {
  list.orderBy(order)
}

This didn't work. In the list object, the _fieldOrders are not set:   _fieldOrders: {}
When I write firestore.collection(collection).orderBy(order), _fieldOrders looks like this:
  _fieldOrders: [ FieldOrder { field: [Object], direction: 'ASCENDING' } ],

This is the same for limit (_queryOptions: {} vs.   _queryOptions: { limit: 1 }).
Environment details

OS: macOS
Node.js version: v8.12.0
npm version: v6.4.1
@google-cloud/firestore version: v0.19.0

Steps to reproduce
let list = firestore.collection(collection)
if (order) {
  list.orderBy(order)
}

// _fieldOrders is {}, but should be [ FieldOrder { field: [Object], direction: 'ASCENDING' } ]

Thanks!

The query class is immutable and all query methods return a modified instance. Please rewrite your code as such:
let list = firestore.collection(collection)
if (order) {
  list = list.orderBy(order)
}

Thanks. Would be great to fix that though, since chaining is a common pattern.


Fix pooled react event property access

This resolves #733 -- thanks for reporting it, @schemen!

This looks fine. Good catch.


Detection of scrollParent incorrect when overflow-x and overflow-y are set

Browser tested: Chrome 59
When making use of overflow scrolling, if the scroll parent is using overflow-y: scroll to set overflow scrolling, react-lazyload will incorrectly find the scroll parent when in overflow={true} mode. This is due to this line, which is expecting overflow, overflow-y and overflow-x to all have values containing either scroll or auto.
However, when overflow-y is set in chrome, the getComputedStyle value of overflow becomes "" (empty string) as specified in the CSS spec.
The algorithm for detecting scrollParent needs to be re-evaluated to fix this bug. I was able to get around it by using overflow: scroll rather than overflow-y: scroll, but some others might not be so lucky.
Happy to put in a PR after some discussion.

#98 Looks like its trying to fix a problem related to this, although it wants both overflow-x and overflow-y to be set, which i'm not sure is correct.

Can you test this PR against Firefox and let me know how it goes?

@jasonslyvia what do you want to test?

If it works properly in Firefox

all overflow and scrollParent issue have been moved to #129 , let's discuss there


SQL connection settings missing

I think you need the following settings in the template to set the SQL Server connection settings and to open the Windows firewall:
          "ServerConfigurationsManagementSettings": {
              "SQLConnectivityUpdateSettings": {
                  "ConnectivityType" :"Public",
                  "Port": 1433,
                  "SQLAuthUpdateUserName": "[parameters('adminUserName')]",
                  "SQLAuthUpdatePassword": "[parameters('adminPassword')]"
              }
          },

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 62f1c694-5b6b-2b9c-4461-634c01f54f78
Version Independent ID: 1a9ee951-7541-cdc3-7338-f33b5cdc22d3
Content: Create SQL Server VM using an ARM template - SQL Server on Azure VMs
Content Source: azure-sql/virtual-machines/windows/create-sql-vm-resource-manager-template.md
Service: virtual-machines-sql
Sub-service: deployment
GitHub Login: @bluefooted
Microsoft Alias: pamela

@erjosito
Thanks for your feedback! We will investigate and update as appropriate.

@adbadram can you look into this?

Hi @erjosito , Thank you for your submission! My sincere apologies for the delay it's taken to address your concern, we've been working through a very large backlog.
During this time, Git Issues have been deprecated as we've transitioned to a new feedback system. I've added your suggestion to our internal backlog (#250004) that we will continue addressing as priorities and resources allow.
We use your feedback to improve our documentation, so we are grateful for your input, and your time. I apologize for any inconvenience, and thank you for your patience and understanding.
Masha from the SQL Docs team
#please-close


vfs: return EBADF if handle is not opened for read or write

If fd isn't opened for read or write, EBADF should be returned according to read(2) and write(2).
Signed-off-by: Eryu Guan<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Currently fuse kernel will return EBADF directly to applications, no READ or WRITE request will be sent to juicefs client, so we still see EBADF errno, but it's better to follow the behavior described in manpage in code.

fallocate should be modified as well.

fallocate should be modified as well.

Indeed, fixed.

    vfs_test.go:251: write off too big: bad file descriptor
--- FAIL: TestVFSIO (0.01s)

@guaneryu Could you please fix the related unit tests as well?

    vfs_test.go:251: write off too big: bad file descriptor
--- FAIL: TestVFSIO (0.01s)

@guaneryu Could you please fix the related unit tests as well?

Fixed.


Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.

Hello!
I'm trying to update extension-admob to work with the latest version of admob sdk 20+ and get the following error:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
play-services-ads-lite-20.3.0\AndroidManifest.xml:27:5-43:15: AAPT: error: unexpected element <queries> found in <manifest>.

According to this article, the problem is with older version of Gradle plugin:
https://android-developers.googleblog.com/2020/07/preparing-your-build-for-package-visibility-in-android-11.html
As I can see, since Lime 7.7.0, we are using Gradle 5.6.3 and Android Gradle Plugin 3.5.1, but I need a newer version.
Anyway to fix that?
Thank you!

You can set in project.xml file the following params ( or any other version , check here -> https://developer.android.com/studio/releases/gradle-plugin) :
	<config:android gradle-version="6.7.1" />
	<config:android gradle-plugin="4.2.0" />

Thanks a lot @flashultra!
It seems to work fine now, but I had to fix some AndroidX error by adding the following to gradle.properties:

android.useAndroidX=true
android.enableJetifier=true

And there are those warnings now:

WARNING:: NDK was located by using ndk.dir property. This method is deprecated and will be removed in a future release. Please use android.ndkVersion or android.ndkPath in build.gradle to specify the NDK to use. https://developer.android.com/r/studio-ui/ndk-dir
NDK was located by using ndk.dir property. This method is deprecated and will be removed in a future release. Please use android.ndkVersion or android.ndkPath in build.gradle to specify the NDK to use. https://developer.android.com/r/studio-ui/ndk-dir

So, hope there will be official release with updated Gradle after all.  :smile:

android.useAndroidX=true
android.enableJetifier=true

Yep, these are a good idea nowadays. We'll just want to check ::if (ANDROID_TARGET_SDK_VERSION>=28)::.

NDK was located by using ndk.dir property. This method is deprecated and will be removed in a future release. Please use android.ndkVersion or android.ndkPath in build.gradle to specify the NDK to use.

Hmm. If we omit this property, the Android Gradle plugin will pick an NDK version based on when the AGP was compiled. Meanwhile, HXCPP will try to pick the latest version of the NDK, causing a version mismatch.
So... we should specify ndkVersion if the AGP is new enough, and ndk.dir otherwise. Looks like version 3.6 is the cutoff?

The minSdk version should not be declared in the android manifest file.

We can get rid of that, no problem.

Lint infrastructure error
Caused by: java.lang.reflect.InvocationTargetException

But this is a problem. Disabling linting won't work in the long term, so we'll have to hunt down the real source. Any chance you can try again with --stacktrace?

So... we should specify ndkVersion if the AGP is new enough, and ndk.dir otherwise. Looks like version 3.6 is the cutoff?
I'm not sure here, does it matter? Can we just move to the newest AGP?

But this is a problem. Disabling linting won't work in the long term, so we'll have to hunt down the real source. Any chance you can try again with --stacktrace?
So, I was trying to get this error again, but can't, project builds fine even without disabling linting. Maybe it cached this somehow.

I'm not sure here, does it matter? Can we just move to the newest AGP?

We can set that as the default, but we can't be certain everyone will use it.

So, I was trying to get this error again, but can't, project builds fine even without disabling linting. Maybe it cached this somehow.

Ah, one of those errors.
Well, hopefully it was just a one-time hiccup. If it happens again, try --stacktrace (and maybe gradle clean), but until then we'll leave it be.

We can set that as the default, but we can't be certain everyone will use it.
Who is everyone and why they don't want to use it? :)

I was able to reproduce "Lint infrastructure error", it happens when I set minSdkVersion in AndroidManifest.xml:
Caused by: com.android.builder.errors.EvalIssueException: Failed to parse XML in ...\bin\android\bin\deps\extension-api\src\main\AndroidManifest.xml
  The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.

 Check them out and see if they work for you.

Everything seems good except "Remove uses-sdk tag."
I've only removed android:minSdkVersion="::ANDROID_MINIMUM_SDK_VERSION::", but left android:targetSdkVersion="::ANDROID_TARGET_SDK_VERSION::" untouched.
Will I still be able to use this in my project.xml?
<config:android minimum-sdk-version="XX" target-sdk-version="YY" />
Thank you!

Oh yeah, definitely keep both in project.xml. Those values still get passed to build.gradle. We're only removing them from the manifest because they're redundant there.

I wonder why minSdk is still 16?
I've switched to 19 long time ago, can't remember the reason, but it has fixed something for me. :)
SDK 16 is Android Jelly Bean released July 9, 2012, there aren't many devices left with this Android version.
https://en.wikipedia.org/wiki/Android_version_history

Didn't see a reason to mess with it, I guess. Other than at really low numbers, I've never run into a case where minSdkVersion made a noticeable difference.

Ok, everything seems good then, thank you!


Dynamic Forms Component

Possibly based off https://github.com/formly-js/ng2-formly

Ignoring implementations for a second, I'd be curious as to your stance toward JSON Schema as a potential base to generate forms from (or probably extended, as form libraries building off of it have generally done so far).
Pros would be existing adoption as a way to express valid (input) values, plus being fairly expressive.
(I'm not suggesting angular-schema-form, last time I checked they weren't there yet.)

We haven't put together a comprehensive plan for forms yet, so this is interesting input. We know that Formly is interesting, but it does focus on some different things (like being able to template with various types of UI libraries instead of just material).
One example for our applications will be to have a JSON object define the form so it can dynamically generate all of the fields (I'm not familiar with the term OIM but this seems to be very similar). We have an existing API that defines these fields and generates a form, that we'll want to upgrade to work with Covalent. There is some discovery here for us to understand the constraints and challenges.
So yes, in general we're looking at a solution that marries together material form components and a JSON schema. If you have some design concepts or want to collaborate with this, we'd be happy to do some prototyping to see what we can figure out. This is likely one of those types of features that we'll build a simple solution that will need many iterations to polish for a more broad consumption.

Yeah, I don't think anyone had heard of OIM, I also just found it on Formly's page linking to the above-mentioned podcast, which might have coined it. Since the podcast mentions multiple, them taking it from there probably also explains Formly's stance in not picking sides.
In reality it's a much smaller space though -- the Jsonary mentioned in the podcast seems to be a UI library (afaict on the level of angular-schema-form) for lack of a better term using JSON Schema itself, while that Metawidget appears to have a JS port, but appears very simple afaict (apparently focusing solely on generating some inputs with default values, they don't seem concerned with validation). JSON Schema on the other hand has been used for validation purposes by some API specifications like OpenAPI (née Swagger) and JSON API. The former was my use-case, to give context to my own bias. If you're coming from your own API as a use-case, you may consider checking them out too. :)
That isn't to say Formly doesn't have its own strengths compared to JSON Schema -- they were based on JS vs. JSON respectively, and the former obviously makes it easier to pass custom validation functions. That being said, existing form generation libraries have usually been inclined to add UI customization options on top, and I suppose at that point allowing JS objects (rather than just JSON serializations) so as to support custom validation functions should work just as well. I'll have to admit I'm not terribly familiar with Formly though, so there may be other relevant considerations. Any fields used in their example (className, label, placeholder, validation, that type to pick the template) look pretty relevant though, so you shouldn't have to give up on functionality like that in a forms implementations.
API endpoints' request GET parameters essentially just form one object (i.e. some keyed values), which without nesting (-> no arrays/objects) is relatively straight-forward. I already needed more if just to allow specifying request headers though (-> object). This shows where it can get harder -- taking into account parts of JSON Schema like:

such arrays/objects (should use their own custom ng2 form controls),
schema recursion (requires a lazy approach, can't just pre-generate form controls),
wildcard schemas ({} / type: 'any').

react-jsonschema-form and angular-schema-form both did 1, forgot about 2, neither did 3.
My own implementation so far consists of ng2 components + related form controls (for e.g. arrays, checkbox sets, objects either allowing schema swap on key change or structured to separate JSON Schema's properties/patternProperties/additionalProperties), lazily generated to solve 2.
Right now I'd just about tackled 3, which should allow generating UIs to edit the schema itself as well -- forms to generate forms to generate the input data you want, a bit like Kinto's formbuilder in React land based on that react-jsonschema-form.
As you're saying, you'd probably manage with something simpler as well. I'll try to see if I can migrate to Covalent and split my UI generation off for you to try, but failing that, you can check my components and controls for reference. I also just found this angular2-schema-form that may interest you as well.

I've had it in the back of my head that we'll essentially model an object that follows the properties set forth by HTML form elements. I think that will be most useful going forward, and allow us to keep it thin. You're raising a number of things that I suspect will have to be iterative releases to figure out.
This all really has to come in line with a REST API. Without clearing up the way the frontend and backend (regardless of platform) will both handle validation rules, I fear we're a few steps ahead on this discussion from our perspective.

Fair enough, no rush on my part either.
Is there perhaps a place I could find documentation on your API(s)? I'd be interested in checking it out a bit further as well.
You mentioned doing a thin wrap of HTML form element properties -- which I guess might extend to wrapping Material components for their abstractions/additions. So this page contains a form example:
<form>
  <md-input style="margin-right: 20px;" placeholder="Company (disabled)" disabled value="Google"></md-input>
  ...
</form>

From your description I'm imagining a JSON-like equivalent like this, probably missing your intention...:
<covalent-form elements="[
  { elem: 'md-input', props: { style: 'margin-right: 20px;', placeholder: 'Company (disabled)' disabled: null, value: 'Google', transcluded_text_and_elements: [] } },
  ...
]"></covalent-form>

We don't have any documentation publicly about the API yet. That is a similar JSON example, though I don't have the specifics in mind yet.

Alright. Curious how things will develop. :)

Based on your thin wrapper comment, you may be also interested in this thread for examples of a few similar projects.

Proposed first iteration on schema (used as our internal projects):
{
  name: string, // unique name used to get value and name control in form
  type: string, // 'text' , 'number', 'date', 'boolean'
  max: number | ISODateStr, (only applicable when number or date)
  min: number | ISODateStr, (only applicable when number or date)
  minLength: number, (only applicable when text)
  maxLength: number, (only applicable when text)
  required: boolean, // require value to validate form
  default: any // initial value of component
}

Guess that pretty much matches the html input attributes, so for internal implementation that should make things easy.
So for required/maxlength/minlength (note html uses lowercase on them) ng2 has validator directives that'll stick on to the html attributes; for min/max I guess the number inputs may help restricting input values as well.
In the event you'd be willing to put up with the native Date input, material2's md-input might be close to meeting your stated initial requirements.
That said, they wouldn't do boolean either (delegated to checkbox/toggle), so you might just wrap them and swap input based on type.
I guess that also forms the core principle of my own project (particularly my InputField component, if not yet using Material2/Covalent), though I'd extended it to include array/object structures.

Closing this since initial release will be in 0.10.
Please open a new issue for enhancements.


Snapshot picks up wrong React Native info

This is very similar to #175 , but specifically affecting solidarity snapshot now.
The snapshot is generated with something like the following:
    "React Native": [
      {
        "rule": "cli",
        "binary": "react-native",
        "semver": "21"
      },
      {
        "rule": "cli",
        "binary": "react-native",
        "semver": "17",
        "line": 2
      }
    ],

There are two different entries for react-native, both versions are wrong, and they change every time solidarity snapshot is run (suggesting that it is again picking up the number from the "scanning folders" execution time).
When then running solidarity, I get:
✖ react-native: you have '0.52.2', but the project requires '22'
✖ react-native: you have '2.0.1', but the project requires '18'

So in that case it is picking up the correct react-native version, but it is also picking up the react-native-cli version and reporting that as an additional react-native version.

This is hopefully solved by v2.0.1 which I just released.  Please let me know!

@GantMan The snapshot has correct versions now but still includes both the react-native and react-native-cli versions under the label react-native:
    "React Native": [
      {
        "rule": "cli",
        "binary": "react-native",
        "semver": "2.0.1"
      },
      {
        "rule": "cli",
        "binary": "react-native",
        "semver": "0.52.2",
        "line": 2
      }
    ],

Is that by design?
Also, solidarity (without snapshot) is no longer working for me with this version. I just get:
TypeError: Cannot read property '1' of null

✔ Solidarity checks valid
⠧ Verifying Android

And it spins forever on verifying Android. Previous version does not exhibit this problem.

Part 1:
Yes I made the decision to put both checks for line 1 and line 2 of react-native's output.  I figured the more info verified the better.  If you think this is overkill, let me know, but I think that knowing the cli is key because rnpm versions are very important, and that's tied to what version of the CLI.  I'd want to know if we had different CLIs
Part 2:
So bummer... I do not get that spin error.  Strange that it would complain about the type.  Make sure you're on 2.0.1 with yarn solidarity -v.  My guess is that you're getting something wonky from your environment that is making the code throw up a lil, but now I'm second guessing that if this is a new bug.
Can you wipe node_modules and reinstall?
If none of that works, I'll screenshare with you and we can debug if you'd like.

I can confirm that i have the same problem with v2.0.1
TypeError: Cannot read property '1' of null

✔ Solidarity checks valid
⠧ Verifying Android

@patrickkempff @GantMan I split off the TypeError/Verifying issue into #183 and am closing this specific issue w/ the React Native snapshot, which does appear to be fixed in 2.0.1.


I object to the publication of this specification as a stable version

Per the contributing guidelines defined
https://github.com/decentralized-identity/presentation-exchange/blob/master/contributing.md#assigning-section-content-in-the-stable-state

When the WG has consensus that the above conditions have been reached, the section enters a final 2-week comment period if no substantive objections are raised against the LAST-COMMENTS status. The start of this period, intended for "last comments," should be announced on the Working Group mailing list. If substantial discussion or change happens, this LAST-COMMENTS phase can be extended 1 additional week at the discretion of the chairs.

I object to the use of spec-up as the specification tool used to produce this specification.
spec up is not maintained by DIF and has 1 contributor.
spec up has not been approved for the delivery of specifications that meet the guidelines of a standards organization.
DIF has not approved spec up for delivery of stable specifications.
DIF has no formal requirements for specifications documented anywhere. The DIF charter notes this is up to the working group to decide.
For those looking for "versions" of this spec, please use the internet archive, as there is no formal versioning / release process defined for this specification today:
https://web.archive.org/web/20200924173605/https://identity.foundation/presentation-exchange/

The spec is functional and understood by all who view it. To me, this point is nit-picky and impedes progress.
Perhaps we should get "official DIF approval" for the use of spec-up. It has already been presented at DIF-wide meetings, which I presumed was sufficient.

To me, this point is nit-picky and impedes progress.

I have proposed DIF approve spec-up and/or other tools for official use, to resolve this issue.
I am following the contributing guide for this repo, and acting in what I believe is the best interest of contributors to the spec, and DIF as a whole.

Exactly why this isn't an issue.

I am a member of the working group and contributor to this spec, and I never "decided" to use spec-up.
That being said, if there is a vote, and I am in the minority I am happy to "let each working group at DIF decide how they want to publish specs".
I think for DIF and Members, Having clear guidelines and encouraging working groups to work on specs with tools where the skill is transferable (skill using IETF / W3C tooling is more valuable than skill using a custom tool), is preferred. Hence my objection.

I'm in favor of having DIF pick up spec-up and additionally having a group discussion/vote on which tool to use. We can discuss at the next meeting.

I'm going to raise a PR that modifies the contributing.md document to more closely reflect the process we've been following as a group, and to propose a way of continuing. roughly:

we triage issues according to the next version or some future version
Once all issues for a particular version have been addressed, we vote as a group whether to release that version.
If the group agrees to publish a particular version, they may also add a status descriptor for the spec as a whole.
If the group does not agree to publish, they will identify what additional issues must be addressed in order to reach agreement.

@brentzundel thanks, thats exactly the kind of process I am hoping for.... for DIF as a whole.... if each WG gets a different version, I guess thats better than what we have now, and I will take whatever I can get :)

Created PR #131 to try and address this.
comments welcome

#131 was merged. @OR13 please re-open if you feel closing was premature.


Fix README.rst mal formatted lines

What is the problem?
Some code blocks are not formatted as expected:

How can this be addressed?
Checking reStructuredText syntax.
Who could help with this issue?
Anyone interested I guess ; )

Hi there!
First-timer here, I cloned the repo, created branch for this issue, fixed those two block and I commited the changes. How do I push it to your repo? Sorry for noobie question but it's my first commit to a project which isn't mine :)

Hi @Zubru22, welcome to our project!
There is totally no problem in asking, we are here to help!
You can read more about opening a PR (the way to push it to the repo) here: https://github.com/datasciencebr/serenata-de-amor/blob/master/CONTRIBUTING.md#the-basics
To open a PR to our project you must change it to a new branch:
$ git checkout -b new-stuff

And push the content to the branch of your fork:
$ git push origin new-stuff

And then you can open a Pull Request to our repo :)

@anaschwendler, I'm glad I could help even with something as trivial as fixing readme. Commiting to a project always seemed scary to me. I figured it out that I need to fork your project, push it to my fork and then create pull request. Already done it. Thanks :)

Closed by #164


New Platforms generated from Manifoldjs

There have been requests to expand the number of platforms that are generated with Manifoldjs.  This issue will be used to collect info on the requested platforms and research on viability.

I'm currently missing support for major desktop OS - mainly OSX and Linux. So maybe Electron (http://electron.atom.io/) and the Electron Packager (https://github.com/maxogden/electron-packager) can be integrated or extended to understand the same manifests.


Unable to use the PAZ subnet (from sandbox sub) because of a SAL dependency (undeletable)

was contacted by Microsoft, on going conversation going to fix the issue.

One remaining dependency not show is the one from the SSC Plus Azure Function we connected in order to be able to pull from the SSC+ API.


Finished new puzzle command

Finished new puzzle command
Updated GameManager class to store current puzzle

close #33

Nice work


Can't edit existing plans

Related issue for DMPOnline test #385 - I can create a new plan and answer questions but not edit anything for existing plans. Creating a separate issue for now because it's unclear to me whether DMPonline test and Roadmap are in sync.
On My plans page, clicking the plan title or Edit produces this error

Can't re-create this on DMPonline test but will leave to check on staging

This is working on roadmap stage now. Closing issue.


Asymmetric templateNamespace of directives

Hi,
when handling directives having NS set to SVG in HTML context, all is going fine.
But if we have a directive with NS set to HTML and handling it inside SVG context we still get SVGElement.
Please check http://codepen.io/djFD/pen/NRWQxR
Angular: 1.5.7
browsers: FF 48.0, Chromium 51.0.2704.79

Interesting. Currently we only use templateNamespace to handle svg and math in a special way, but we don't do anything for html. There would be a performance hit involved in fixing this, unless there is an easy, cheap and reliable way to detect the document type of the elements container.
A possible work-around is to embed the SVG-contained HTML inside a <div>. Is it even valid to have HTML content inside an SVG container?

well, lets start from a performance hit. Check starting from this
Currently if i have defined a directive for a say <text /> tag, then any such tag encountered will be recompiled (to be exact will be wrapped, then new jqLite subtree will be created), regardless of where it was found, in SVG context (and thus has already type of SVGElement) or in HTML context (in this case it is actually need to be re-made).
So yes, reviewing the logic will increase performance for a such cases.
It seems, that it have to be something like to
if (currentCtx !== directiveCtx) {
  wrap();
  redo();
}

for those directives where template name spaces are defined explicitely and leaving it as is if it have it unset.
As for foreign content inside SVG, there is a special tag for that. BUT there are a cases (eg see https://github.com/angular/material/issues/9478) where it is just convenient to have such ability to directly insert tags to be fully transcluded, without wrapping them into <foreignObject /> at first

BTW, this check does not work in IE11 (EMU IE10, IE9), as toString.call(node) returns [object Object] or something like this.
I do use next for a such testing
var contextSvg = !! (node.namespaceURI || node.toSting()).match(/svg/i));

Wrt performace, (like I already said) if there is an easy, cheap and reliable way to detect the document type of the context, then it shouldn't be a problem (as we would only wrap html when the current context is not in HTML). If someone would like to investigate that, be my guest :smile:
--

BUT there are a cases where it is just convenient to have such ability to directly insert tags to be fully transcluded, without wrapping them into <foreignObject /> at first

This particular usecase sounds like hacking around the spec (and looking for trouble). There might be other legitimate usecases, but I am not very motivated by this one :smile:
--

this check does not work in IE11 (EMU IE10, IE9), as toString.call(node) returns [object Element] or something like this.

I tried it it worked for me. It returned [object SVGSVGElement]. Can you provide a demo?

well, not exactly demo, just a screen shot. it is under Win7, IE11. Need to say that last OS updates there were ~2016-03. But it seems under real hardware Win8 (up to date) the situation is the same, I will check after reboot.

Wrt to detecting current context of a node, browser already did it for us

Checking node.namespaceURI would give desired result (but need to have RegEx involved) would help

node.constructor.name

Also we can simply scan up until opening <svg> or <body> is found
Neither of them is both fast and reliable simultaneously?

Well, I am feeling that my part of the job is completed here. BUT one question is still unanswered, or am I failed to see it?
Namely, compare this and this
Need not this last one look as
var namespace = directive.templateNamespace;

?
Just because this check does not work, as !namespace always evaluates to true and we perform [costly enough] testing for every node to be compiled?

@djfd, no it doesn't, because the returned function may be run multiple times (but namespace only needs to be detected once).

@gkalpak, oh I got the point, thanks
but it wont work if we will supply different future parents (thru options) upon every call of publicLinkFn though. it can happens that parents have different NSes, one is html, next one is MathML, and we are linking a few subtrees copies in interleaving mode. just thought

You might be right (but I don't think anyone would ever do something like this :smiley:)
Let's wait and see if someone complains about it :wink:


Update InstallFailed_proxy_unreachable.json

The summary/subject line of this SL seemed misleading to me, so I adjusted it. I also fixed a grammar issue, reworded the documentation link, and added tags

/lgtm

/approve

/label tide/merge-method-squash

/lgtm

/retest

/retest

/retest

/retest-required


⚠ Shadow Does Streams has degraded performance

In 113f0ae, Shadow Does Streams (https://stream.everythingbagel.me) experienced degraded performance:

HTTP code: 200
Response time: 6364 ms

Resolved: Shadow Does Streams performance has improved in 18d2f41 after 4 minutes.


Natural language queries (Q&A)

According to this article Natural language queries (Q&A) capability is available both in dashborard and reports. If so, then it should not be in the table because it is not a difference. If not, then it should be fixed.
According to this earlier article https://docs.microsoft.com/en-us/power-bi/consumer/end-user-reports it is not available in reports.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91935bb2-c486-cb9f-be71-ae18ad28cf96
Version Independent ID: 761de430-9bc7-4d7d-4c56-d14e6354194c
Content: Intro to dashboards for Power BI designers - Power BI
Content Source: powerbi-docs/service-dashboards.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiemsft
Microsoft Alias: maggies

Thanks for your comment, @dlopez831 . We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

Hi, @dlopez831 -- so true! Article is fixed.


Having problem installing master branch

Since you made the official PyPI package, I've been struggling to install the latest branch when I try to install it says install done but none of the dependencies, etc.. get installed🤔
It's worth mentioning I use poetry, but it did work before the official PyPI
Is there something I'm missing, because on the other hand, it does work when I clone the repo and install it from the repo😂 maybe it's just poetry

I'm not familiar with poetry and I don't know why the PyPI release would make a difference.
How do you declare the dependency in poetry? Does it look like one of the following?

https://python-poetry.org/docs/dependency-specification/#git-dependencies
https://python-poetry.org/docs/dependency-specification/#url-dependencies?


Dynamic batch sizes

Some things we should decide:
I'm not sure if "partitioner" is really the right parlance anymore.  Maybe... RequestManager?
Should we deprecate the existing max batch size config and create a new config for the partitioner?

Current coverage is 74.65% (diff: 72.00%)

Merging #42 into master will decrease coverage by 0.64%

@@             master        #42   diff @@
==========================================
  Files            24         25     +1
  Lines           834        943   +109
  Methods           0          0
  Messages          0          0
  Branches        117        133    +16
==========================================
+ Hits            628        704    +76
- Misses          169        192    +23
- Partials         37         47    +10

Diff Coverage
File Path

•••••      50%
...fka/connect/bigquery/partition/EqualPartitioner.java

••••••     62%
...ka/connect/bigquery/partition/SinglePartitioner.java

••••••     66%
...pay/kafka/connect/bigquery/write/BigQueryWriter.java

••••••     66%
...m/wepay/kafka/connect/bigquery/BigQuerySinkTask.java

•••••••    76%
new ...a/connect/bigquery/partition/DynamicPartitioner.java

•••••••••• 100%
...afka/connect/bigquery/config/BigQuerySinkConfig.java

Powered by Codecov. Last update e5219d4...e019571

Agree we should rename partitioner. My vote is for BatchWriter.

Also, before merging, could you run this against a real workload that has large messages/triggers increase and decrease in batch size locally and just confirms that it behaves as expected.

As discussed, I ran this against apilogger.log.api_log,apilogger.log.api_log_ro and everything seemed to work as expcted.  I'll also rerun after changes.


Support twitter links in feeds

So, this is a very specific issue I am having…
I am subscribed to a HackerNews RSS feed (for reference: https://hnrss.org/frontpage?points=300). It’s default content is formatted like this
Article URL: https://twitter.com/RealSexyCyborg/status/1486526916433641472

Comments URL: https://news.ycombinator.com/item?id=30095733

Points: 330

# Comments: 308

Linking to both the HackerNews discussion as well as the article they are discussing. The URL however goes to the article, not the discussion. I use reader mode here because then I get the article’s content — the thing I actually care about. Frequently however the referenced “articles” are tweets. The reader-mode online tool then fails due to Twitter blocking things (see attached screenshot). It would be cool if in this particular use case (twitter link + reader mode) it could just use the Twitter extension to show the tweet’s content.

Since Twitter integration will stop working soon — as soon as Twitter ends free Twitter API access — I’m closing this.


Simple Websocket & HTTP client API support

This PR provides a simple Websocket client API to send Websocket messages to Websocket server. Because the Websocket is established using HTTP, there is small and simple HTTP client API implemented. This HTTP client API can be used to connect to HTTP(S) servers so it is not tied to Websocket client implementation. As this HTTP API is very much needed by Websocket API, I decided not to send it separately to review.
The Websocket API provides functions that can be used by BSD socket API or if more fine grained Websocket support is needed, a Websocket specific API functions are provided.
The main function is this one
int websocket_connect(int http_sock, const char *host, const char *url,
		      const char **optional_headers,
		      websocket_connect_cb_t cb,
		      const struct http_parser_settings *http_cb,
		      u8_t *tmp_buf, size_t tmp_buf_len,
		      s32_t timeout, void *user_data);

It will be given a socket descriptor to the Websocket server. This means that all the non-websocket related things are done outside of this API. The websocket_connect() will connect to the server, do needed HTTP handshakes and return a new websocket socket descriptor that, when used, will add Websocket header to the sent data. User can then either use normal send() or websocket_send_msg() functions to send the data.
One usecase for this API is run MQTT data on top of it. This MQTT support is not part of this PR but to be done separately.

Verified that http-client sample works with TLS. Added README files to both samples.

Updated according to comments.

some suggested edits...

Thanks David. New updated version uploaded.

Updated documentation in websocket sample. Fixed case when we received two websocket packets in same TCP segment, in that case we need to remember the second websocket msg for next socket read.

ping @dbkinder can you re-check the modifications

Fixed the handling of Sec-Websocket-Accept field in HTTP header.

Sorry, I was on vacation, then at the conference, so late to the party. Commenting first just based on the textual description and comments here.

The main function is this one

int websocket_connect(WALL OF PARAMETERS);

Didn't we discussed once that having gigantic parameter list is worse than a dedicated structure to capture those params instead? Some params are strange to, e.g.:

        websocket_connect_cb_t cb,

"sockets" and "callbacks" are generally don't mix together. How events are reported for sockets are via pull-style poll() call (instead of push-style callback). If you (for some reason) try to represent high-level websocket communication channel as a system socket, so callbacks, again, look strange.

        const struct http_parser_settings *http_cb,

Why structure of type "http_parser_settings" is named as if it was callback?

const char **optional_headers,

What if I don't have all the headers preallocated as single static array (e.g., don't have enough memory for that)?

all the non-websocket related things are done outside of this API. The websocket_connect() will connect to the server, do needed HTTP handshakes

The first part seems to contradict the second. So, does it issue connect() call? It shouldn't. And if doesn't, then I'd skip mentioning that it "will connect to the server". Mentioning "do needed HTTP handshakes" should be enough, perhaps elaborating it to "will do needed HTTP/Websocket handshake on already established connection".

and return a new websocket socket descriptor that,

If it returns file descriptor, that's our old good friend layering violation. Why conjugate high-level websocket connection to pretend it's a system-level socket. No other (sane) system does that. There're immediate portability implications, e.g. you can't test this websocket code on Linux with comfort it gives, so it's likely has bugs. And if it doesn't try to represent itself as a system-level socket, why return an int, instead of structure pointer?

when used, will add Websocket header to the sent data. User can then either use normal send() or websocket_send_msg() functions to send the data.

Hey, that's cool! But what about received data? ;-)

Fixed case when we received two websocket packets in same TCP segment, in that case we need to remember the second websocket msg for next socket read.

Websocket is SOCK_STREAM protocol, and SOCK_STREAM sockets don't work in terms of "TCP segments", they work in terms of "streams of bytes". So, if BSD Socket API was properly used to implement websocket code, this error couldn't happen in first place... I'm now a bit afraid to look into the actual code...

Websocket is SOCK_STREAM protocol, and SOCK_STREAM sockets don't work in terms of "TCP segments", they work in terms of "streams of bytes". So, if BSD Socket API was properly used to implement websocket code, this error couldn't happen in first place... I'm now a bit afraid to look into the actual code...

The Websocket is a message protocol on top of stream protocol (TCP). IMHO it is not very well designed in the first place but we need to cope with this.

Didn't we discussed once that having gigantic parameter list is worse than a dedicated structure to capture those params instead? Some params are strange to, e.g.:

Do you have a proposal how to pass the params?

Why structure of type "http_parser_settings" is named as if it was callback?

The struct contains HTTP callback pointers.

What if I don't have all the headers preallocated as single static array (e.g., don't have enough memory for that)?

That is not possible with this API. We would probably need to have a callback to feed extra headers to the stream.

all the non-websocket related things are done outside of this API. The websocket_connect() will connect to the server, do needed HTTP handshakes

The first part seems to contradict the second. So, does it issue connect() call? It shouldn't. And if doesn't, then I'd skip mentioning that it "will connect to the server". Mentioning "do needed HTTP handshakes" should be enough, perhaps elaborating it to "will do needed HTTP/Websocket handshake on already established connection".

There is no contradiction here, user is responsible to call connect(), the websocket API will then connect i.e., establish, like doing handshakes etc., a valid connection to websocket server.

and return a new websocket socket descriptor that,

If it returns file descriptor, that's our old good friend layering violation. Why conjugate high-level websocket connection to pretend it's a system-level socket. No other (sane) system does that. There're immediate portability implications, e.g. you can't test this websocket code on Linux with comfort it gives, so it's likely has bugs. And if it doesn't try to represent itself as a system-level socket, why return an int, instead of structure pointer?

We want to use socket descriptor that is tied to websocket connection. This helps to run things on top of websocket connection and use recv()/send() API. We are not making Linux applications here, and if you want to run valgrind etc you can use native_posix for that.

when used, will add Websocket header to the sent data. User can then either use normal send() or websocket_send_msg() functions to send the data.

Hey, that's cool! But what about received data? ;-)

recv() works just fine too

Changing slightly the API proposal:

moved most of the function parameters to user given request struct
typos fixed

Do you have a proposal how to pass the params?

Not something specific, beyond moving all (most) params to a struct, and passing a pointer to it to the function. I see that you already pushed something along those lines, let me have a look.

Noticed some fd leaks when closing the connection, those are now fixed.

Seems to work ok now. I have been running mqtt_publisher over Websocket without any issues.


Multiple Javalin instances or ports

Describe the feature
Opening multiple ports, as suggested #227
The service we write have /health and /metrics endpoints. We can secure them, but it is better not having these publicly available at all, as it might contain sensistive data.
I tried starting 2 new instances of Javalin, but get java.lang.IllegalStateException: STARTED.
Additional context
It would be great if context also will have their own configuration. For example our "normal" application needs specific session handler and should have MicrometerPlugin enabled. Where the other instance should not.

I'm not sure what you mean @adhesivee. You can create two separate instances with separate configs.


Could not find the package with 'platformio/toolchain-esp32ulp @ ~1.22851.0' requirements for your system 'linux_aarch64'

Hi, I tried to flash the esp32 with esphome, unfortunately i got this message
Could not find the package with 'platformio/toolchain-esp32ulp @ ~1.22851.0' requirements for your system 'linux_aarch64'
I connected the esp to the windows and tried also via raspberry which is running homeassistant with esphome.
any ideas, have seen comments 4 days ago with other problems. Seems they got it to work...
With arduino I got only one reading and then it stucked.

You have to use ESPHome 2022.11.2
You have to stick to ESP-IDF if you want to use BLE
ESP-IDF doesn't build on aarch64 processors (Raspberry Pi). Please use a x86 (windows or linux) system as build host

Thank you for fast reply. I am new in esphome flashing.
I have the current version: 2022.10.2 . 2022.11.2 ?
I will set up a linux usb stick to run my windows computer with any linux and try again... and again... and again...
thank you for your help. Hope I have it understood and can get it running.

Sorry, my fault. ESPHome 2022.10.2 is required. ;-)

You have to compile on a x86 pc.
Install ESPHome on windows. Compile and run it from there.

Thank you. Will try more things. I keep you updated in every case. :-)
I seek for a old pc with 32bit or try a vmware or something like this.

The toolchain is 64bit compatible. Only the processor architecture of the Raspberry Pi isn't supported. So any other processor architecture should work.


Flutter 2.6.0-5.2.pre

Hey @srawlins, it looks like master is broken on Flutter 2.6 beta. Any ideas on what we need to do to fix this greatly appreciated.

Ok that's weird. It fails locally on macOS but succeeds in CI?!


Add a dark mode toggle

Use the mantine dark mode: https://mantine.dev/guides/dark-theme/
and probably replace the background with a proper dark one

Initialized in: https://github.com/Vincenius/workout-lol/compare/dark-mode?expand=1
needs some more detail work on various styles

done! only login screen needs to be changed. I'll open another issue for that


Coder slideshow is broken

Due to changes in Coder, we get exceptions when looking up items in the Coder tree.


Skip forward

Hi I am trying to find a way to skip back to the previous spot when i log back out and in, is this possible? I have tried just skipping forward by pressing the right arrow but it seems quite slow (it rubber bands and jumps back all the time) and editing the url path doesn't seem to make a difference.
Thanks
Z

@armanrahman22 and @fnocera are working on a UI to skip forward/backwards an entire page of documents which will speed up the navigation process, as well as on some improvements to the "UI jumping while scrolling through documents" issue. The pull request should be ready soon.

Great! This will be extremely useful. Will this include the ability to have users resume their previous spot in the data stack when they log back in to save navigating through again?

https://github.com/chakki-works/doccano/pull/328 introduced two ways to improve the situation described in this issue: (1) an option to increase the pagination size via an environment variable and (2) a button to skip a page forward instead of only one document.

Awesome, thanks - any chance of also getting bookmarks? Basically send a given user to the place they last left off (assuming the underlying data is unchanged/not reordered or anything)

Please raise a new issue if you want the new feature (bookmark).


Add support for user roles and permissions season

Rabbit season

Failed Test
Failure Summary
Logs

[chromium] should navigate to the dashboard after login correctly.
The test timed out waiting for the dashboard to be displayed after login.
Logs ↗

[chromium] should show the privacy policy correctly.
The test timed out waiting for the privacy policy to be displayed correctly.
Logs ↗

Flaky Test
Failure Summary
Logs

---
---
---

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

Test_ConflictError
failure_message: Failedfailure_text: === RUN   Test_ConflictError    api_test.go:60: Conflict error occurred--- FAIL: Test_ConflictError (0.00s)
Logs ↗

View Full Report ↗ ⋅ Docs


[ENH] Add poetry publish step to GHA release workflow

Describe the feature you'd like to see
Add a last step that runs poetry publish to publish package to PyPI

This has been implemented in under the khanlab/actions repo and just needs to be called in the workflow here.


How to use it with Polish?

I would like it to speak Polish, how I can configure it to do it?
Thanks

Add a Polish text processor (g2p, text normalization ......) likedata_gen/tts/txt_processors/polish.py
Add a config file in datasets/audio/XXX_Dataset/ps_flow.yaml, with the following content:

base_config:
  - egs/egs_bases/tts/ps_flow.yaml
raw_data_dir: data/raw/XXXX
processed_data_dir: data/processed/XXX
binary_data_dir: data/binary/XXX
preprocess_args:
  txt_processor: polish # here is the text processor name registered in your text processor file.

Add the dataset metadata loader in egs/datasets/audio/XXX_Dataset/preprocess.py. You can refer to the metadata loader of LJSpeech (egs/datasets/audio/lj/preprocess.py).
Train the model with python run.py --config YOUR_CONFIG .... as the document docs/portaspeech.md says.


eveyrtime I go on the app it asks for an update

eveyrtime I go on the app it asks for an update and it just keeps doing it and nothing works

Maybe manually get the latest version? Download

Have the same problem here, manually replacing the old version with the newest release doesn't work.

I have the same issue, also it doesn't seem to have any change in my UX because I think it's missing some components, hence the installation banner on start.

I get this issue still


Resource IDs are not checked

This module does not check that the IDs of resources are integers. That can lead to SQL injection attempts being sent to the Mangopay API.

For example Document(id='foo', user=User(id='bad'), status='VALIDATION_ASKED').save() sends a POST request to /users/bad/KYC/documents/foo.
In fact the variables injected into the URL path are not even escaped: User.get('bad%xxx') results in a GET request with the invalid path /users/bad%xxx, and the server returns a 500 error code instead of a 400.

Thanks for pointing this up !
Our resourceIDs are string typed, even if in fact our IDs are integers at the moment.
So we can't add any check for only integer typed resourceIDs, as some of it could become strings (GUID for example) in the future.
We have to analyze the best way to avoid any SQL injections through our SDK in another way.
Mickaël


[300 SigmaUSD] Vote for update(pool) command

Should be done after #45 is merged.
To vote for the pool box update as per https://github.com/ergoplatform/eips/blob/bd7a6098db78d67ac2ca9ada4c09bfe709d5ac03/eip-0023.md#vote-for-update (with updates introduced in v2.0a, e.g reward tokens were moved from the refresh box to the pool box) add a new command line option --vote-update-pool with the following parameters:

new pool box hash (blake2b256);
height of the update box;

If the ballot token is locked in the existing ballot box (i.e. output of the previous update tx) it should be spent to create the new ballot box.

I will work on this.

Hi @greenhat I have a question about this issue:
Should the owner of the ballot token have their group element stored in the oracle config? Seems like it since we will need to implement transfer ballot token.

An idea: we could do away with storing it in the config by scanning for local ballot box as follows:

Get all wallet addresses from node /wallet/addresses endpoint. For each address a, perform a scan for the box with the ballot_token_id and the group element of a.

What do you reckon? Thanks.

Hi @greenhat I have a question about this issue:
Should the owner of the ballot token have their group element stored in the oracle config? Seems like it since we will need to implement transfer ballot token.
* An idea: we could do away with storing it in the config by scanning for local ballot box as follows:

  * Get all wallet addresses from node `/wallet/addresses` endpoint. For each address `a`, perform a scan for the box with the `ballot_token_id` and the group element of `a` in `R4`.

What do you reckon? Thanks.

I think it's ok to store it in the config. Scanning for it seems way more complex. Let's try a simple solution first. :)

I'm almost done with this issue but I ran into a problem with the case where we're spending an existing ballot box. I got the following error:
TxSigningError(ProverError(EvalError(Misc("ByIndex: index Int(0) out of bounds for collection size 0")), 0))
I tracked it down and the problem originates in this line of the contract. Now I believe we need to amend the contract because for the vote for update command there's only one fixed input (the existing ballot box) as specified in the EIP, and so INPUTS(1) has no guarantee to contain any token.
So I amended the contract by removing the line with val otherTokenId = INPUTS(1).tokens(0)._1 and replacing update with:
val update = INPUTS.size > 1                           &&
             INPUTS(1).tokens.size > 0                 &&
             INPUTS(1).tokens(0)._1 == updateNFT       && // can only update when update box is the 2nd input
             output.R4[GroupElement].get == selfPubKey && // public key is preserved
             output.value >= SELF.value                && // value preserved or increased
             ! (output.R5[Any].isDefined)                 // no more registers; prevents box from being reused as a valid vote

Then the test passes. Am I doing this correctly?

@kettlebell Good call! I agree.
@scalahub Please check and approve the proposed update to the ballot contract above. The reason for the update is that val otherTokenId = INPUTS(1).tokens(0)._1 throws on voting, i.e. spending the ballot box without the update box.

The bounty is sent. Thank you!


Profile VC needs to redirect to native auctions

Hero units with profile IDs like /rago are currently showing the generic Profile view controller. We have an existing solution for fairs, something similar would work here and, given time constraints, feels like the right approach. See slack for discussion: https://artsy.slack.com/archives/auctions-dev/p1458417933000172
However, I don't want the Profile VC to have its own miniature router, so we may want to think of a longer-term solution.

What about just removing the use of vanity URLs from Hero units?
Disclaimer: I’m from the ‘:fire: the vanity URL’ camp.

To be honest, as long as we _do_ have vanity URLs (and even if we decide to stop introducing them, we can’t just break them, as the URLs are out there), we should have a better solution. I think we need to do a HEAD on all /root routes to see if they respond with 3xx before actually routing the view :disappointed:

Yeah, agreed.
Also, my proposed solution won't work, as the profile lookup for sales comes back as a 404.

cc @ashfurrow please remind us to do this for upcoming auctions

@devangt we should do this for the upcoming auctions.

@ashfurrow @orta should this be in QA now or? let me know if there's anything more actionable.

@katarinabatina It is not in the current version. There is preliminary work done by @orta here https://github.com/artsy/eigen/pull/1691.

@katarinabatina important to note that the stop-gap workaround for this is not linking to the vanity URLs on the eigen home screen, but their full URLs instead.

@orta this was fixed by our work Live, right?

I've not noticed any problems on this for a while, going to close.

Yep - fixed by https://github.com/artsy/eigen/blob/master/Artsy/View_Controllers/ARMutableLinkViewController.m


Display bounds (min and max) in tooltip of spinbox

This would make it easier to figure out the information of numeric fields.

Need to do.


unknown rigid body exception

I am using this software having vicon in tracking mode. Although everything works fine (I get the position of the object I have selected to track in vicon)  after losing track of it  for a moment I get the error "Unknown rigid body!".
It makes sense, since from what I understand it constantly tries to track the object.
Is there a way to remove this exception  though, since in my use case I am losing track of the object quite a lot? (I am trying to track a ball which is usually falling on the ground).
Thank you in advance!

This is already fixed in https://github.com/IMRCLab/libmotioncapture/pull/10, but so far nobody was able to confirm that it works (I don't have access to a VICON system.)

Oh seems that I have missed this pull request, I am going to test it soon then and I will let you know of the outcome.
Thank you!

I merged the PR and also updated the submodule here. Thanks for your help!


[RFP] Balancer pools on the Darwinia

As Uniswap V4 and CowAMM protocols involved, we are updating our requirements, currently looking into Balancer support on Darwinia.
We are looking some friendly forking of Balancer to support our chain instead.
Refer:
https://forum.balancer.fi/t/balancer-on-other-chains-friendly-forks-aka-franchise-model/2279
Already shared this idea with some external teams including Helixbox.

Helixbox is working on this. @hujw77


Withdraw Custom Dialog on Close Explainer

This explainer has been withdrawn. The customer need has been met by other means, and this design conflicted with the philosophy of keeping tab close as fast as possible. In order to accomplish actions on tab close, developers should try writing to IndexedDB on the  visibilitychange event, and then trigger a Service Worker to read from the DB and do any other necessary work.

Love the changes to the doc. Thanks for doing that. Rather than have this simply disappear from the Readme.md index, I would like you to move it down to a new section at the bottom under a header "##Withdrawn".

Good suggestion, added.


charts/karavi-observability: upgrade certmanager

Upgrade cert-manager to 1.10.0
Is this a new chart?
No
What this PR does / why we need it:
Which issue(s) is this PR associated with:

#https://github.com/dell/csm/issues/491

Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the chart README.md
[x] Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

Chart version was bumped up. All checks passed.


Content Policy Level 2 is now a W3C Recommendation

https://www.w3.org/TR/CSP2/
Let's see if Travis fails on this one too 🙃

Thanks!


Error from python.py Gst.Pipeline

I tried running python player.py in python 2.7.9 with GStreamer Core Library version 1.4.4
I got the error:
    self.pipeline = Gst.Pipeline("mypipeline")
TypeError: GObject.__init__() takes exactly 0 arguments (1 given)```
I fixed it by changing line 14 to:
```self.pipeline = Gst.Pipeline.new("mypipeline")```

Alright, i'll change it, thanks!

this project still alive ?

@jamesaxl well this isn't really a "project", more of a repo for me to put some code examples for something that took me some time to find.

that is nice, if you do not mind I would like to add volume

Yeah go ahead, maybe create another example containing a simple play/pause player with a volume slider?

ok no problem, Done. I will PR later
On Wed, Oct 5, 2016 at 8:50 PM, hadware<EMAIL_ADDRESS>wrote:

Yeah go ahead, maybe create another example containing a simple play/pause
player with a volume slider?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hadware/gstreamer-python-player/issues/1#issuecomment-251748194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOg9H9Hj-3ErkDD5_ypPzfeIY9aCxkfks5qw-NigaJpZM4Hcs7V
.


Implement ECDH

This is almost a clean port from the Boring bindings made by Google (src).
I've changed a few bits to account for the API differences between OpenSSL and Boring, but the logic is the same.
I plan to improve this ECDH implementation by making use of the EVP interface in a follow up PR. Haven't done it as part of this PR because this is good enough to be used in go1.20 and using the EVP interface poses some difficulties to keep compatibility with OpenSSL 1.0.2.

the Boring bindings made by Google (src).

Seems like the wrong link, or I'm missing the intent. 😄
That's the public crypto/ecdh package, and the internal Boring bindings are at https://github.com/golang/go/blob/master/src/crypto/internal/boring/ecdh.go.


Support for asynchronous NSGA-II

(This is different than "Allow for option of using Dask for NSGA-II," but these might be consolidated into a single task.)
Given problems that have long evaluation times for which the initial population may have a large number of non-viable individuals (such as through randomly generated DL architectures), the by-generation approach of NSGA-II is not efficient.  That is, an asynchronous steady-state EA will be able to grind through a large number of candidates until all workers are busy evaluating viable candidates, however NSGA-II will get stuck slowly finding viable candidates.  Worse yet, work cannot proceed to the next generation until all individuals are evaluated, so if there is just one viable individual and all the rest are non-viable, then the computation resources associated with the non-viable individuals will be idle until the next generation.

This paper may be a good starting point for an asynchronous NSGA-II variant.
https://arxiv.org/abs/1804.05208

Moving this from backlog to "to do" since there is at least one project at ORNL that needs this capability.

I've opened a pull request #264 with a candidate for this. It performs pretty well, but I want some eyes on it to be certain everything is working right.

Leaving open until we have an example script; that way the test harness covers this.

There is an example jupyter notebook that I created at the same time. If that is sufficient, then we can close this issue.

I'm making a quick modification to my implementation to move the Inserter out of the algorithm function so users can apply them elsewhere. This is for compatibility with gremlin, since we'll need to build it from the steady state base.

Cloasable?


Small Typo in Assign Role

@chriscattermole : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mumian
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@chriscattermole - thank you for your contribution.
#sign-off


README: Use shiny SVG badges for readability

This PR changes the build badges to SVG for sharper readability ✨

Why not! Thanks


Logo restyle

I think the current logo could really benefit from a redesign: if anyone wants to give it a try please do so! It's not necessary to open a PR for every proposal, just link the image in an answer to this issue.
Problems which should be solved:

currently it's nothing more than a patchwork of icons with conflicting styles and colors
it uses Google Contact and Google Calendar icons: I am not sure what copyright laws apply to icons and service logos or if this falls under "fair use". Maybe someone knwoledgeable in this area could shed light on this; in the meantime not using them is probably the best way to go
it's a raster image: as pointed out in #129 it would be great to have it as a vector image

Guidelines:

if you do not know what this script does you can give a quick read to the homepage.
Alternatively this is a TL;DR: GoogleContactsEventsNotifier is a script built on the Google Script platform which lets you receive notifications for your contacts' events (birthdays, anniversaries and custom events). It collects data from your event Calendar, from your Contacts and from Google+ profiles to build a customized email notification which sums up upcoming birthdays and events.
feel free to completely change the structure, dimensions, format and style of the logo: when I put it together I wanted to convey the idea of a service that uses Calendar, Contacts and Gmail to get you those notifications, however I'd love to see any alternative ideas
a little note regarding Google+: I did not include it in the logo because at the time it was not integrated in the script nor did I plan to integrate it. However, as explained in #131, Google+ is going to close in the next 10 months, so I'd say including it in the new logo is not worth it anyway even if you want to keep the "service aggregation" theme

Thank you in advance to anyone who wants to give a shot at this!

I would like to present these three proposals of logo for your project all oriented to represent the sending of electronic mail related to calendar events, I hope you like it and if you want some change with pleasure I can do it

The balloon is supposed to represent events, such as birthday parties for example.
PNG version :

This is my attempt at the vector version :


Sign in data should be shared across profiles

#161785
Whenever I change "Settings Profiles " I have to re-sign into everything, making syncing, github and everything very hard.
I believe that Settings profiles are not about being in "incognito" mode, it is a convenient way for users to customise settings and extensions. So sign-in data should be shared across profiles for a smoother experience.
fyi @TylerLeonhardt

Another bug on top of this

Have profile A signed into settings sync
Switch to profile B that is not signed in
Switch back to A. You are no longer signed into settings sync 🐛

I believe the sign in information is shared across profiles. I think the issue you have is when you open insiders with two different user data directories then you get signed out in another instance. Can you please check testing (switching profiles) without having another instance of VS Code pointing to different user data dir?

You are right. Thanks!
Closing this as all was caused by me using VS Code insiders with different user data dirs. Sorry about the noise.


Validate the model

Hello, would you like to ask how do you perform a verification test on the trained model and what kind of file is the test, is it .off or .points, or an octree file?
I want to use your model for pre-train, but I have the following problem：
Cannot copy param 0 weights from layer 'ip2'; shape mismatch. Source param shape is 40 128 (5120); target param shape is 5 128 (640). To learn this layer's parameters from scratch rather than copying from a saved net, rename the layer.
你好，想请问您如何对训练好的模型进行验证测试，测试的档案类别为何，是.off还是.points，或是octree档

Run the following command to test:
python run_cls.py configs/cls_octree_test.yaml

For the problem Cannot copy param 0 weights from layer 'ip2'; shape mismatch. Source param shape is 40 128 ... ,  the reason is that when training on ModelNet40, the dimension of the last  FC is 40x128 for the 40-category classification, but the FC of your network is  5x128 for the 4-category classification.  So you have to rename the layer's parameters to train it from scratch.

测试的时候数据处理跟训练一样，需要将.off转换为.points或者.octree

Suppose I have a model file of an aircraft to use
ocnn_M40_5.caffemodel to test his accuracy, how can I use the command
line, thank you
抱歉打扰您，由于我是初学者，想问您如何加载自己的.points档去让已训练好的模型分辨，command
line如何下，因为在网上查询的多是图片辨识，都要有个均值档跟deploy.prototxt才能进行分辨，谢谢您我可能说的不够明确，我举个例子，假设我有一个飞机的模型档要用ocnn_M40_5.caffemodel，来测试他的准确性，那我要如何下command
line,谢谢
Peng-Shuai Wang<EMAIL_ADDRESS>2020年3月25日 週三，下午7:48寫道：

Run the following command to test:
python run_cls.py configs/cls_octree_test.yaml

For the problem Cannot copy param 0 weights from layer 'ip2'; shape
mismatch. Source param shape is 40 128 ... , the reason is that when
training on ModelNet40, the dimension of the last FC is 40x128 for the
40-category classification, but the FC of your network is 5x128 for the
4-category classification. So you have to rename the layer's parameters to
train it from scratch.
3.
测试的时候数据处理跟训练一样，需要将.off转换为.points或者.octree
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/O-CNN/issues/83#issuecomment-603796121, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4TAUCME6VA2HXJN35JJ4DRJHVRFANCNFSM4LTH76JA
.

您好
不好意思又打扰您
在阅读您的文献时有些问题，不知道您方不方便为我解惑，在o-cnn中，不同的模型以八叉树做切割，那假设今天有两个同样是飞机模型，有可能切
下去的相同位置在这两个模型上是不同位置，想请问这样要如何辨识他是飞机模型，假设一个飞机头的座标与另一个正好相反之类的情况。
谢谢您
Peng-Shuai Wang<EMAIL_ADDRESS>2020年3月26日 週四，下午9:33寫道：

Closed #83 https://github.com/microsoft/O-CNN/issues/83.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/O-CNN/issues/83#event-3168266372, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4TAUBBB4QAENKE7VTPON3RJNKRXANCNFSM4LTH76JA
.

您好
当运行以下命令进行测试时：python run_cls.py configs/cls_octree_test.yaml
得到如下反馈
Traceback (most recent call last):
File "run_cls.py", line 41, in
FLAGS = parse_args()
File "O-CNN-master/tensorflow/script/config.py", line 139, in parse_args
_update_config(FLAGS, args)
File "O-CNN-master/tensorflow/script/config.py", line 108, in _update_config
FLAGS.merge_from_list(args.opts)
File "anaconda3/envs/tensorflow/lib/python3.7/site-packages/yacs/config.py", line 226, in merge_from_list
cfg_list
File "anaconda3/envs/tensorflow/lib/python3.7/site-packages/yacs/config.py", line 521, in _assert_with_logging
assert cond, msg
AssertionError: Override list has odd length: ['configs/cls_octree_test.yaml']; it must be a list of pairs
请问该如何解决 谢谢！

@chenteng1998  你运行的命令缺少关键字--config, 运行如下命令试一试：python run_cls.py --config configs/cls_octree_test.yaml

@ chenteng1998 你运行的命令关键字--config，运行如下命令试一试：
python run_cls.py --config configs/cls_octree_test.yaml

谢谢！！我的问题已经解决


#9 implemented: new optional prop "target" which is the id of the scrollable container

Falls back to document.documentElement / document.body if omitted.

It looks very good. 👍
Will be great is we can add a little demo component to current example repo too.
@xehpuk, Would you like to be added as a maintainer to this project?

@xehpuk can you provide me some example repo with new target feature ?
I will like to test some use case before update npm

Sure! Today, while testing, I observed that I've broken cross-browser compatibility. A new PR incoming soon …


[FX] Implement FX_UpdateInstanceWaterSplit

https://decomp.me/scratch/sHZVJ FX_UpdateInstanceWaterSplit 99.66%

Why closed? I've not forgotten about this, if you intend to reopen it though can you ensure it builds? Thanks.


Handle potential race condition in which Trac is notified but git fetch doesn't get the changeset

Discussed near the end of #8, I continue to see cases in which a changeset does not sync from GitHub and therefore the post-commit hook is not triggered. Running a git fetch and trac-admin $env changeset added for the changeset always triggers the update of the relevant ticket.
The following is always seen in the logs when the issue occurs:
2016-07-12 13:07:06,356 Trac[github] ERROR: Payload contains unknown commit 55cd9488ccd897bb9b75450852c100d13cf0df02

I've considered that it might work to implement a simple retry of git remote update --prune.

I think I tried that before without success, but perhaps you'll be more persistent and figure it out :-)

I see now that the behavior is documented in known issues.

https://github.com/trac-hacks/trac-github/commit/6f84cdcd5b1a8883763ca2acb8ceb6dff3c0b193 has some changes that I'll be testing.

The best practice for doing this is exponential backoff.
Start with a given delay (order of magnitude: 0,5 - 1s) and at each retry, multiple the delay by a constant factor (order of magnitude: 1,5 - 2). This is easy to implement and nicer on the remote end if they're struggling.

I'm not sure the re-try is a very good idea; GitHub seems to have pretty strict timeout policy on webhooks (they regularly mark some of ours as "timeout", even though in quite a few of the cases, Trac seems to have processed them).
Maybe we should add a database table, store the webhook and trigger some asynchronous, delayed processing that can then be re-tried until it succeeds?

Thanks for the tips. I haven't seen the issue reoccur since this last report. Running my branch with proposed changes, I also never saw log message indicating that the update had to be retried. I'll revisit the issue if it occurs again.

I'm seeing this approximately every 2 weeks or so with trac 1.2.2.
Just resending the webhook from github doesn't resolve the issue as I still get the "unknown commit"
message in the logs. To resolve I have to manually run git remote update --prune before running a trac-admin <env> repository sync <repo>, after this I can then resend the webhook from github and
trac will get updated.
I will keep trying to understand why we get into this situation.
As per previous comments, I also regularly get timeouts from the github webhooks. Github thinks
they have timed out, but trac does normally get updated. I'm wondering if this is a contributing factor?
I believe we should be accepting the payload from github for async processing (and returning http 202 accepted), then process what github have sent us.


Migrate away from Azure Pipelines to GitHub Actions

A large part of GitGitGadget's operation runs inside Azure Pipelines, either in a scheduled run, or triggered directly via a push event or indirectly via the GitHub App (which is backed by an Azure Function that performs rudimentary validation and then triggers the Pipeline via a PAT, passing along some parameters).
Azure Pipelines seems to be developed less actively than GitHub Actions, therefore it is desirable to migrate from the former to the latter.
One challenge are the secrets used by the Azure Pipeline: we need to ensure that they stay, well, secret. It is much easier to accidentally leak them by carelessly accepting a seemingly innocuous PR that updates some random CI run (but really is designed to leak an unprotected secret). We might want to use this shiny new tool in the toolbox called "environment secrets", where we can restrict in the GitHub UI which workflows are allowed to access them.
One of the very neat things GitGitGadget does is that it is shown in the "checks" of a PR, i.e. if GitGitGadget is currently preparing a patch series to send or to preview, the PR status is set to "in progress".
The way this is done is by registering the corresponding Azure Pipeline with the repository targeted by the PR. Currently, there are three such Pipelines:

The GitGitGadget PR Handler Pipeline is associated with gitgitgadget/git
The GitGitGadget PR Handler (git) Pipeline is associated with git/git
(For testing only) The GitGitGadget PR Handler (dscho) Pipeline is associated with dscho/git.

Whenever GitGitGadget's GitHub App installed in the respective repository receives an event about an added PR comment (in the form of triggering the Azure Function), it manually triggers the respective Azure Pipeline.
Since the introduction of the workflow_dispatch event, it should be possible to port this strategy to GitHub workflows.
Except.
Except the fact that the triggered workflow would need to be tracked in the repository targeted by the PR (e.g. in git/git, which would most likely be a really hard sell to the Git project, especially when we would need to be super agile to address externally-triggered breakages such as when the ::set-env: method to set environment variables stopped working without much in the way of a warning; The fix would have to be applied super quickly to git/git's master branch, which is contrary to Git's current custom).
The most natural way, however, would be for the workflows to live in gitgitgadget/gitgitgadget. Currently, there is no way GitHub workflows support this idea of the workflow living in a different repository than where it runs.
So let's keep this ticket open, marked as [BLOCKED], until such a time when we can have GitHub workflow definitions that live outside the repository where they are expected to run.

Except the fact that the triggered workflow would need to be tracked in the repository targeted by the PR

There is actually a better way, and it is implemented in Git for Windows' new automation: the build-and-deploy workflow runs in one repository, but creates a check run in a different repository, updating it when the task in question was done, and finally setting it to completed at the end (even marking it as canceled when the actual workflow run was canceled). The associated GitHub App even mirrors the check run when it is queued for an even better user experience.
We can do the same here in GitGitGadget (on whose Azure Function-based GitHub App the GitForWindowsHelper GitHub App was based, anyway).

@webstech I finally realized how we can have multiple GitHub Actions that are backed by the very same repository, without wasting space! I got the idea from actions/cache (which actually wastes space...): you can have Actions in subdirectories of the repository! And by bundling the CIHelper class in a single, dependency-free dist/index.js (via ncc), we can keep the Actions' Javascript code minimal!
I've opened a draft PR to demonstrate the basic idea: https://github.com/gitgitgadget/gitgitgadget/pull/1392


[containers] Add containerd collector (linux and windows)

What does this PR do?
Adds a containerd collector (Linux and Windows) for the generic metrics provider introduced in #9403
Describe how to test your changes
Run the generic container check on a Windows host with containerd.
For Linux is a bit more complicated because the system collector always takes precedence. To disable it, run the Agent without mounting /proc to /host/proc, the system provider will be automatically disabled.
Checklist

[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] The need-change/operator and need-change/helm labels has been applied if applicable.
[x] The appropriate team/.. label has been applied, if known.
[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The config template has been updated if applicable.

Note: Adding GitHub labels is only possible for contributors with write access.

@ahmed-mez I've addressed all your comments. I also refactored a bit the tests to increase coverage.


Dependeny warning yaml

I get a dependency warning when importing gopkg.in/yaml.v2 v2.2.1 and v2.2.2 (lines 220 - 222) via the go.sum file.
It throws this warning:
“The Kubernetes API Server component in versions 1.1-1.14, and versions prior to 1.15.10, 1.16.7 and 1.17.3 allows an authorized user who sends malicious YAML payloads to cause the kube-apiserver to consume excessive CPU cycles while parsing YAML.”
I fixed it by setting the versions to v2.2.8. Should be something to look at, perhaps.

fixed in https://github.com/icon-project/goloop/commit/3e470dcb99f6b468e4843d52043d78a1b334b6f8


Fix compile error

engine.ShowSQL is a method, not variable anymore

Codecov Report

Merging #1042 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1042   +/-   ##
=======================================
  Coverage   54.28%   54.28%
=======================================
  Files          41       41
  Lines        7551     7551
=======================================
  Hits         4099     4099
  Misses       2936     2936
  Partials      516      516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad69f7d...7c9e483. Read the comment docs.


Associate and then dissociate an entity to a virtual device causes it to disappear permanently

Hey there, first of all great integration! Very useful for my specific needs.
I was doing some testing with some non-critical data, and I discovered one of the ways that this integration can be destructive (you did generally warn us).
Specifically, I created a new virtual device, and then I associated an entity to it which belonged to a different device. It worked. However when I removed the entity from the virtual device, the entity seems to have disappeared. It did not reassign to the previous device, nor can I seem to find it anywhere in the Entities page/list. I do still see a reference to it in the core.entity_registry file, but (as expected) much of its metadata has been stripped out.
This poses a problem, that I cannot even reassign the removed entity to the virtual device even. I think this integration needs some method (or instructions) to recover removed entities. At the very least, to reinclude whatever metadata is necessary so that they show in the list again, but ideally to reassign them back to their original device.

Side related important note: You mentioned in the Caution callout on the Readme.md that it could potentially break stuff. Can I suggest that you add a note to this, specifically calling out a warning the above; If an entity is associated to a virtual device and then removed from it, that you may be unable to associate it again to anything. At least until this is resolved or worked-around.
Thanks for your time.

I think this is a bug, as generally it should be possible to revert any changes made by this integration.

I added a section about known issues to the readme and included this bug.


New feature suggested for Dropdown: able to disable Popper's preventOverflow

Get an issue when using Menu forms with a large form which is supposed to fix itself below the button.
The PreventOverflow feature is good, but we'd disable it in a lot of cases which is impossible when using Dropdown.
Thanks and Best Wishes.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and OS details.

https://codepen.io/anon/pen/QQjKEJ
Click the button several times or scroll up and down, you will see the form reset its position by the preventOverflow feature.

A quick fix would be to add this line on your application :
Popper.Defaults.modifiers.preventOverflow = { enabled: false };

See the result here (with our first stable v4) : https://codepen.io/Johann-S/pen/vdNymv?editors=1010

As there an option "data-boundary" to manage the behavior of the preventOverflow, would you like to disable one Dropdown's preventOverflow feature by given false or null?
For example:
<button type="button" data-boundary="false" ...>
  button
</button>

They are a PR to disable Popper.js for dropdown : https://github.com/twbs/bootstrap/pull/24092

Closing as stale for v4. We'll be moving onto focus entirely on v5 and v4 will only see critical updates.


Remove graphics from the default definition

Version Reports:
Distro  version of host:
openSUSE 42.2/ Centos7/ Ubuntu..
Debian 9.5
Terraform Version Report
(Provided by running terraform -v.)
Libvirt version
virsh --version
virsh 3.0.0
terraform-provider-libvirt plugin version (git-hash)
 git log
commit 58cc06611667bbbdddafacb411cd6bc8da1c2b00
Author: Duncan Mac-Vicar P<EMAIL_ADDRESS>Date:   Tue Aug 14 14:35:35 2018 +0200
Update changelog

Description of Issue/Question
I ran into the same issue as:
https://github.com/dmacvicar/terraform-provider-libvirt/issues/65
Now I didn't need graphics anyway (the Ubuntu Cloud image I was using has tty/console set up and I can just use virsh console for that).
So I removed graphs from my .tf file, but looking at the debug it would still try to create the graphics.
So I disabled it in domain_def and it wasn't created anymore.
My suggestion would be to also do that in your repository/code. So when I don't request graphics to be created it will not add it to the XML for libvirt:
diff --git a/libvirt/domain_def.go b/libvirt/domain_def.go
index 09a41717..898ee07a 100644
--- a/libvirt/domain_def.go
+++ b/libvirt/domain_def.go
@@ -35,13 +35,13 @@ func newDomainDef() libvirtxml.Domain {
                },
                CPU: &libvirtxml.DomainCPU{},
                Devices: &libvirtxml.DomainDeviceList{
-                       Graphics: []libvirtxml.DomainGraphic{
+/*                     Graphics: []libvirtxml.DomainGraphic{
                                {
                                        Spice: &libvirtxml.DomainGraphicSpice{
                                                AutoPort: "yes",
                                        },
                                },
-                       },
+                       },*/
                        Channels: []libvirtxml.DomainChannel{
                                {
                                        Target: &libvirtxml.DomainChannelTarget{

Additional Infos:
Thank you for your effort and time !

@Lennie thank you for the issue.
the spice is always created because a default value is set there.
https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/resource_libvirt_domain.go#L238
I will look at this soon thx for reporting!

@Lennie i am closing in favor of https://github.com/dmacvicar/terraform-provider-libvirt/issues/84
which is the same issue thx!


Fix license information so GitHub detects it correctly

Fixes #7 .
See the following screenshots;

Thanks for your fix. I was also wondering why the LICENSE file was not recognized correctly, but did not notice that there was an unnecessary blank line.
The THIRD-PARTY-LICENSES file is now empty, but we will update it in the near future as we add some benchmarks (ex. Core Mark) to the repository. So, could you recover it?

@shioyadan I think the detection is /actually/ getting confused by you having multiple files with LICENSE in the name. The recommended approach for including third party stuff into your project is to create a third_party directory and include the information under that. You can see how Google recommends their engineers organize repositories at https://opensource.google/docs/releasing/preparing/#third-party-components