Infinite loops in Veins generation

https://github.com/lawremi/CustomOreGen/blob/master/src/main/java/CustomOreGen/Server/MapGenVeins.java#L568
This function goes into an infinite loop on server as you can see in below profiler screenshot.

Any idea which parameters we need to adjust?

It is going to be related to some other mod or configuration, so we will have to narrow things down on your side.

This is reproduced with my modpack version 8.0.8, available here: http://www.technicpack.net/modpack/tdks-world-war-minecraft.173124
I'm using custom configuration for ores, exclusives with layered veins.
Specifically for Coal, we've this option where MotherlodeSize can be lower than 0:
				<Veins name='CoalVeins' inherits='PresetSparseVeins' seed='0xC047'>
					<Description>
						Coal spawns just near the surface, and up into hills and mountains.  The veins are
						long and thick, but sparsely filled with ore and often broken up by caves or depressions
						in the terrain.
					</Description>
					<DrawWireframe>:=vnlaDrawWireframes</DrawWireframe>
					<WireframeColor>0x60101010</WireframeColor>
					<OreBlock block='minecraft:coal_ore' weight='0.65'/>
					<Setting name='MotherlodeFrequency' avg=':= 15.0 * coalFreq * _default_'/>
					<Setting name='MotherlodeSize' avg=':= 2.5 * coalSize * _default_' range=':= 4.5 * coalSize * _default_'/>
					<Setting name='MotherlodeHeight' avg=':= 70/64 * dimension.groundLevel' range=':= 30/64 * dimension.groundLevel' type='normal'/>
					<Setting name='BranchLength' avg=':= 0.20 * _default_' range=':= 0.15 * _default_'/>
					<Setting name='BranchInclination' avg='0' range='0.25'/>
					<Setting name='BranchHeightLimit' avg='30'/>
					<Setting name='SegmentForkLengthMult' avg='0.25' range='0.15' />
					<Setting name='SegmentRadius' avg=':= 0.25 * coalSize * _default_' range=':= 0.20 * coalSize * _default_'/>
					<Setting name='OreDensity' avg='1' range='0'/>
				</Veins>

Could this generate an infinite loop?


'ng' is not recognized as an internal or external command, operable program or batch file.

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

node v7.10.0
npm v4.2.0
Windows 10 Version 1703 build 15063.332

Repro steps.

I installed and uninstalled the cli and node several times and even manually cleaned node caches after uninstalling and it refuses to recognize 'ng'.  The installer never fails with no error message.  when you call 'ng' it will recognize
The log given by the failure.

C:\Users\awsau>ng help
'ng' is not recognized as an internal or external command,
operable program or batch file.
Desired functionality.

Mention any other details that might be useful.

I had done a fresh install of windows using the included program "Fresh Start" that is included with windows before installing the cli.
I had previously had this problem a few months ago but fixed it by updating node and cleaning the cache manually.

@awsaunier Can you provide the stack trace of CLI install? Also, check the global node_modules if it's installed or not?

I included a txt file of the stack.  I didn't want to include it in here due to its long length.
Stack.txt
I don't know how to check Install for the node_modules is installed or not but I did do a search on my c: and I did find a node_modules folder was in  C:\Program Files\nodejs\node_modules.

I have the same issue.
You can not install ng from the command line with a non administrator account
And there is no sudo. Only runas which runs as the administrator with the administrator profile.
The UAC does not kick in and ask you to provide admin permissions as when you run an installer.
So the ng binary will be located in the Administrator npm folder after installing using the runas feature.
Take a look at the folder "C:\Users\Administrator\AppData\Roaming\npm" and see if you can spot ng.
If you can then add "C:\Users\Administrator\AppData\Roaming\npm" to your path.
There is something called sudo for windows ( https://sourceforge.net/projects/sudowin/ )
It runs with elevated permissions, while preserving your profiling settings.
I haven't tried it. Use at own risk.

I looked at my Admin account and you were right, it was installed there.  Is there a way to redirect that to a standard user account?  In the past I was able to do all my development on a standard user account.  Also I don't quite understand what you mean by.

If you can then add "C:\Users\Administrator\AppData\Roaming\npm" to your path.

Thank you for providing a solution to the problem though.

I some further investigation and I upgraded my user account to admin and reinstalled angular cli and it now works.  I was able to downgrade my account to a standard user and it still works.  I don't know if this is still an windows issue related to what @MrRhino said and if this can be solved by an update to the cli.  The thing that is puzzling me is that I was able to use the cli and everything fine a month ago and now having this issue.  I am glad I can continue to code and I thank everyone that has help.

Is there a way to redirect that to a standard user account?
No.

If you can then add "C:\Users\Administrator\AppData\Roaming\npm" to your path.
I mean if you have ng in the above mentioned path, then add it to your current user path.

I some further investigation and I upgraded my user account to admin and reinstalled angular cli and it now works. I was able to downgrade my account to a standard user and it still works.
That is also a solution. But it requires that you have administrator permissions.

The thing that is puzzling me is that I was able to use the cli and everything fine a month ago and now having this issue
Maybe Microsoft tightened their User Account Control

Personally i would add the administrator path "C:\Users\Administrator\AppData\Roaming\npm" to my current user path along with your current user path "C:\Users<currentUser>\AppData\Roaming\npm".
That way all global modules will be available to you, even when you are required to install via. the administrator account.

Personally i would add the administrator path

What do you mean by add and where should I add the path?

Hit the Windows button ( cmd on Mac ) and write "Environment"
Select the option that says "Environment variables for your account" ( or similar in your own language )
Select Path
Select New and add "C:\Users\Administrator\AppData\Roaming\npm"
Press Ok and finish

Thanks to @MrRhino for the advice and solution steps.
I'd just like to add that it is possible to install (to the best of my knowledge) to install Angular CLI on non-admin accounts. The missing bit seems to have been that the npm path was not part of the environment path, and thus global npm binaries could not be found.

At last find the solution for ng command is not working issue ,Find the solution below http://itechiesol.blogspot.com/2017/07/angular-cli-ng-command-is-not-working.html


Added meeting inbox page that currently gets owned meetings and displ…

…ays them
Co-authored-by: thudsonbu<EMAIL_ADDRESS>Context

Implementation

Merge Checklist

[ ] Correct Target Branch
[ ] Pre-Review Diff Check
[ ] PR Description
[ ] Add Reviewers and Assignees
[ ] Review Complete
[ ] Rebase
[ ] Rebase Approved

Wait for these checks to complete.

You can merge this now!

Thank you for merging the pull request.


Project and editor crash caused by signal with argument in C#

Godot version: 3.0.2 stable, Mono <IP_ADDRESS>, Win 8.1
Issue description:
Adding this line:
[Signal] delegate void CustomSignal(string message);
Compiles but the project crash as soon as the project starts and the editor crashes too if the scene is loaded.
If the scene is the main scene, the project can no longer be loaded
This is the second (at least) issue where a project can be made un-editable
A signal without argument does not cause a crash:
[Signal] delegate void CustomSignal();
Minimal reproduction project:
CrashOnSignal.zip

CC @neikeq

Can't reproduce on Linux (master build from ebce36c) with the project linked above :thinking:

Can't reproduce on Linux (master build from ebce36c) with the project linked above thinking

Note that the report is against 3.0.2, where some Mono commits have been cherry-picked but not all, so it might behave differently from master.

You're right, I can reproduce with the 3.0.2 binary.

A signal with argument causes me a crash as well and a signal without argument throws me this error:

0:00:01:0526 - Condition ' p_ptr == 0 ' is true.
----------
Type:Error
Description:
Time: 0:00:01:0526
C Error: Condition ' p_ptr == 0 ' is true.
C Source: core\os\memory.cpp:159
C Function: Memory::free_static

Does this still happen in 3.0.4?


Can not send several files

Plugin can send just one file by formData.

Now it can. Example is placed in ajax.php.


ARK Server Crash When Using -automanagedmods In Command Line

ARK servers need to have a copy of SteamCMD in the following folder, otherwise they will crash when using the -automanagedmods argument.
../Engine/Binaries/ThirdParty/SteamCMD/Linux

See this.

This is the script that is supposed to be executed before running an ARK server on Linux (you'll find it in the root of the server's data directory):
#!/bin/bash
# SteamCMD installer

sudo apt-get install lib32gcc1
cd Engine
cd Binaries
mkdir ThirdParty
cd ThirdParty
mkdir SteamCMD
cd SteamCMD
mkdir Linux
cd Linux
wget https://steamcdn-a.akamaihd.net/client/installer/steamcmd_linux.tar.gz
tar -xf steamcmd_linux.tar.gz

Obviously that won't entirely work on a CentOS/RedHat system, but you can replace the sudo apt-get line with something like the following, as long as it is executed with root privileges:
yum -y install glibc.i686 libstdc++.i686

If you can execute it in an interactive fashion, where the user can enter their root password when prompted in the terminal, then the following should work:
su - -c 'yum -y install glibc.i686 libstdc++.i686'

Which package manager to use doesn't depend on the host OS but the OS used in the container. It's probably alpine linux in this case as we try to keep images very small.
Have you tried creating the folders and downloading steamcmd to the mentioned folder manually?

Yes, creating the files manually does resolve the problem, so long as the dependencies (glibc.i686 and libstdc++.i686) are installed.
I wasn't aware that your container had a virtual operating system in it. That explains the rediculous memory and CPU usage displayed in the panel, even though the system monitors all showed shootergame only using 2.9GB of RAM and no CPU time.
BTW: Did you make these changes in your virtual OS that you run in your container? If not, then that might explain why the ARK server doesn't work.

As far as i'm aware there is no higher ulimit enabled in our container. Also i think that needs to be done using this docker flag.

Unfortunately I don't have any experience with Docker.

I thought we had this already as a problem with the java thing we ran into once long ago. I also thought Fish updated that already in a previous fix as well.

@GT500org All containers are not so much a virtual OS but a chroot system where it uses the host kernel to boot inside the container. It makes all the stuff smaller.
I will also look more into the ARK container as I am interested in having it as well.

I saw the issue with steamcmd not being in the ThirdParty/SteamCMD/Linux/ path and took a shot at adding something to the start.sh based on the SteamCMDInstall.sh here: https://github.com/sirmaxim/Docker-SRCDS/tree/ark
I made a poor man's attempt to test it by dropping it strait into the ...aufs/mnt/<hash>/start.sh. Works as intended and populates the Linux/ directory with the correct files.
I was going to make a pull request, but it still doesn't fix the CLI option -automanagedmods in my tests. It seems there is something else that needs to be done as well.
Normally, ARK forks a ton of steamcmd processes to update mods when this works correctly, but it appears not to fork any processes and goes strait to starting the server.

When it executed the Steam installer, it ran without errors? If it did, then the game should have no trouble executing it, and the server shouldn't crash on start.
Note that regardless of whether my ARK server crashes, it never binds its ports, and thus nothing is able to communicate with it. I am assuming that this is due to the server not being able to finish starting the game for some reason, but the ARK server gives pretty much no debug information aside from a vague Steam related error that may or may not be a problem. My best guess, from what I've found around the Internet, is that the open files limit in the container needs to be increased.

I dont think that vague steam error is the issue since it happens with other game. Can you confirm that the startup commands between a game managed by the panel and via your own nonpanel system are the same, or if nit what the difference might be?

BTW: @sirmaxim is correct that the server doesn't start any SteamCMD processes when launched via the panel (I didn't see that part of his message earlier). In fact, aside from loading about 3GB of data into RAM, it doesn't seem to do anything.

@DaneEveritt I am trying to figure the differences, but there really isn't anything that should be different about the startup command. I'll keep investigating, though. something is different. FWIW, I used https://gameservermanagers.com/lgsm/arkserver/ with great success to setup a server in a Debian 8 KVM. It also required one minor tweak to get the ThirdParty/SteamCMD/Linux/ path populated, but worked perfectly otherwise. It just doesn't have a nice control panel like this.
@GT500org You have something odd going on if it's not binding to ports. You need 2 ports in your startup like this in your launch in the panel:
{{ARK_MAP}}?listen?ServerAdminPassword={{ARK_ADMIN_PASSWORD}}?QueryPort={{SERVER_PORT}}?Port={{UDP_PORT}}?MaxPlayers={{SERVER_MAX_PLAYERS}} -automanagedmods
and you need to attach the other port (UDP_PORT) in the Build Configuration tab at https://name.tld/admin/servers/view/<server_id>?tab=tab_build
If that doesn't work for you, you did something wrong somewhere. If it is taking up ~3.5 GB of RAM, the server is running.

@sirmaxim I don't think it's going to bind the game client port or the raw UDP socket port until it has been able to download workshop mods (it is binding the query port and the RCON port now, although I'm not sure if I verified those ports before). Since I can't debug changing the open files limit in the container, at the moment I can only assume that is the issue.

@GT500org The open files limit would prevent the server from loading 3.5 GB of RAM. I don't think that's what it is. If it were, it would stop at < 2GB and not run at all. ARK is fat and reads a lot of files. I think it more likely there's a docker restriction of some kind preventing it from forking the steamcmd, but I don't really know docker since I avoided it for a long time having been wary of the 1.0 release not being production ready like the sales pitch said.

Can you use the same port for the query port as well, or do they need to be different?

The ports must be different. One is for steam (defaults to 27015) and the other is for game clients over UDP (defaults to 7777 or 7778). Steam is required for the clients to find/connect as far as I can tell.

The ports used by the server are detailed here.

I only just came across this issue.
Perhaps using https://github.com/FezVrasta/ark-server-tools#ark-survival-evolved-linux-server-tools within the "ARK" docker image instead would make it better and easier.
I've tried to use LGSM before and in fact it doesn't work with -automanagedmods as I outlined here ( https://github.com/GameServerManagers/LinuxGSM/issues/1336#issuecomment-284598650 )

I believe this has been fixed with the new service option scripts included in v0.6.0-beta.3.


Warn on positional parameter mismatches for abstract def implementations

Resolves #11113. This isn't a hard error yet (it can nonetheless be enforced with --error-on-warnings). Not addressing IO::Hexdump, for example, produces:
In src/io/hexdump.cr:29:12

 29 | def read(buf : Bytes) : Int32
               ^
Warning: positional parameter 'buf' corresponds to parameter 'slice' of the overridden method IO#read(slice : Bytes), which has a different name and may affect named argument passing

In src/io/hexdump.cr:35:13

 35 | def write(buf : Bytes) : Nil
                ^
Warning: positional parameter 'buf' corresponds to parameter 'slice' of the overridden method IO#write(slice : Bytes), which has a different name and may affect named argument passing

A total of 2 warnings were found.

What happens when an implementing type has multiple overloads, one of them matches the parameter names and the other doesn't? Can I get a spec for that, please?

You mean this?
abstract class Foo
  abstract def foo(x : Int32)
end

class Bar < Foo
  def foo(x : Int32 | String); end
  def foo(y : Int32 | Char); end
end

foo(x : Int32 | String) overrides foo(x : Int32), and calling foo(x: 1) will always work, so it is technically fine if other overloads of foo so not have the same parameter names, and that is what happens right now. (Most often they should have the same name anyway, but that is not due to the abstract def.) However, if we swap the two names:
class Bar < Foo
  def foo(y : Int32 | String); end
  def foo(x : Int32 | Char); end
end

then a warning is reported for y, because the compiler stops checking overloads after the first signature match. Similarly, if neither overload uses x:
class Bar < Foo
  def foo(y : Int32 | String); end
  def foo(z : Int32 | Char); end
end

then only one warning is emitted instead of two. Abstract def checking is very fast so it wouldn't hurt to look beyond the first signature match.

Sounds good.
We should be careful with the first case, though. When there is an implementation with matching parameter names, I'm not sure the other one should be a warning, or even an error eventually. It's probably not a big deal, but I guess we'll see what effect the warning has.
For that reason I'd prefer to warn about all overloads with mismatching parameter names.

Bar.new.foo(1) in the first example would call the overload that has y instead of x, which is indeed a problem, so all overloads are checked now.
The return type check, which happens right before the parameter name check, will continue to stop at the first matching overload:
abstract class Foo
  abstract def foo(x : Int32) : Int
end

class Bar < Foo
  def foo(x : Int32 | Char) : Int32
    1
  end

  def foo(x : Int32 | String) : String # okay
    ""
  end
end


Handle external shipping methods in translations resolver

Fixes default translations resolvers not working with shipping methods that were retrieved via a webhook.
This is achieved by testing received shipping data for is_external in custom resolver logic wrapping default logic.
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[x] Database migration files are up to date
[x] The changes are tested
[x] GraphQL schema and type definitions are up to date
[x] Changes are mentioned in the changelog

Task: https://app.clickup.com/t/2549495/SALEOR-5623


CTD during ending cutscene of Paleto Heist mission

Version
3.0.4
Description
Came across a glitch where the game crashes during the ending cutscene of the Paleto Heist mission. Was running a test without a mods or scripts folder. Event Viewer showed this .net runtime error log.
Application: GTA5.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: exception code c0000005, exception address 00000014A56FEC29
Stack:
SHVDN log didn't update at the time of the crash.
[02:12:28] [DEBUG] Loading API from .\ScriptHookVDotNet2.dll ...
[02:12:28] [DEBUG] Loading API from .\ScriptHookVDotNet3.dll ...
[02:12:28] [DEBUG] Loading scripts from C:\Steam\steamapps\common\Grand Theft Auto V\scripts ...
[02:12:28] [WARNING] Failed to reload scripts because the C:\Steam\steamapps\common\Grand Theft Auto V\scripts directory is missing.

Don't see how SHVDN would be involved here when there are no scripts active. Sounds like a game bug.


SimBricks PCI adapter for Simics

At the moment, the adapter implements only the PCI protocol. @FreakyPenguin Should we therefore change every mention of PCIe to PCI, including the commit history and the file names?
The adapter currently has no support for MSI or MSI-X. Therefore, the i40e_bm simulator cannot be used with Simics yet. The e1000 NIC, however, is fully working and produces similar throughput numbers in the iperf_client_server_pair experiment compared to using  Qemu as the host simulator. I plan to add MSI and MSI-X support in the coming weeks.

Oh, thank you for the fixes and your changes look good to me :)


Support torus set KEY=value syntax

Hey, my first instinct while use torus set is to use the export variable syntax KEY=value instead of KEY value. This PR allows that when only one argument is passed.
Some scenarios are described in the test cases. Let me know if there is something else that needs to be covered.
Closes https://github.com/manifoldco/torus-cli/issues/219

This is awesome, thanks so much :)


Added callback when loading screen has finished fading out

New to github, just trying to figure this out.

Hey, thanks for the PR!
Couple things to point out here:

don't worry about committing changes to package.json or incrementing version numbers; we'll need to handle bumping the version and republishing to bower, npm, etc.
since the existing onLoaded callback is called immediately after you call finish(), I think onFinished is a slightly confusing option name - more accurately, maybe onRemove or something would be more helpful to other users
since onLoaded does fire once the "disappear" animation starts, why do you need to wait for the animation to finish? In general, I'd recommend starting your app code before the fade out completes, otherwise it's a bit irritating for users
finally, we have pretty good spec coverage for this library, so it'd be good to write a unit test to confirm your feature works as expected and doesn't break any existing tests (I have a feeling this one does :wink: )

ps. welcome to GitHub! :smile:


#2029 Barrister - Pupilage Exemption Manage Upload

What's included?
Currently, when a candidate states "No" to completing pupillage in their application they will need to upload an exemption and/or practicing certificate. These documents should also be made available on admin, so admins can see and manage this information.
Added the ability to view and replace the files uploaded in association with no pupilage.
This PR is linked to the associated admin changes in the following PR: https://github.com/jac-uk/apply/pull/1022
Closes #2029
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Apply for a vacancy and when you get to the Relevant Qualifications do the following:

Set the qualification to 'Barrister'
Set "No" to completing pupillage
FIll in the other inputs
When you get to the bottom of the form only upload a single file for 'Exemption Certificate'
Press Save And Continue button
Submit the application

Then go to the admin section and view the application.
See the attached video for how to test:
https://github.com/jac-uk/admin/assets/115651787/30c144d4-bbe1-42e0-9358-75cb0dd03e78
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Please check that uploaded certificates can be seen & managed for draft applications

I can confirm that uploaded certificates can be seen & managed for draft applications.
See attached video:
https://github.com/jac-uk/admin/assets/115651787/19e62095-6b3e-480a-8c14-bee584499bd6


Ignore

@czuares HI!

@czuares HI!

@sstarcher Hey Shane 👋  Did not realize we already had a public fork. hub cli did more than I was anticipating 😁

@sstarcher Hey Shane 👋  Did not realize we already had a public fork. hub cli did more than I was anticipating 😁


[TEST] automatic fetching of test data; fixes seqan/product_backlog#43

This PR fixes seqan/product_backlog#43
Acceptance Criteria

[x] specifying a remote resource with a file to download the file will be downloaded during the build of the test.
[x] if the test data is already present nothing will be downloaded.
[x] if the data is not reachable from the remote location a build error occurs with a diagnostic message

This happens if unreachable:
-- verifying file...
       file='/home/marehr/develope/app-template/build/data//foo.gz'
-- SHA256 hash of
    /home/marehr/develope/app-template/build/data//foo.gz
  does not match expected value
    expected: '6e30fc35f908a36fe0c68a7a35c47f51f9570da16622fb0c072a20e6a9ba5b3e'
      actual: 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
-- File already exists but hash mismatch. Removing...
-- Downloading...
   dst='/home/marehr/develope/app-template/build/data//foo.gz'
   timeout='none'
-- Using src='https://example.unreachable/foo.gz'
-- Retrying...
-- Using src='https://example.unreachable/foo.gz'
-- Retry after 5 seconds (attempt #2) ...
-- Using src='https://example.unreachable/foo.gz'
-- Retry after 5 seconds (attempt #3) ...
-- Using src='https://example.unreachable/foo.gz'
-- Retry after 15 seconds (attempt #4) ...
-- Using src='https://example.unreachable/foo.gz'
-- Retry after 60 seconds (attempt #5) ...
-- Using src='https://example.unreachable/foo.gz'
CMake Error at _datasources/src/datasource_in.fastq-stamp/download-datasource_in.fastq.cmake:159 (message):
  Each download failed!

    error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---
         error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---
         error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---
         error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---
         error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---
         error: downloading 'https://example.unreachable/foo.gz' failed
         status_code: 6
         status_string: "Couldn't resolve host name"
         log:
         --- LOG BEGIN ---
         Could not resolve host: example.unreachable

  Closing connection 0

         --- LOG END ---

Tasks

[x] add cmake function to download a remote file.

What works right now:

Specify any number of alternative URLs for a single file:declare_datasource(FILE human_chr1.fastq
                   URL https://example.com/human_chr1.fastq
                       https://example2.com/human_chr1.fastq
                       https://example3.com/human_chr1.fastq)

if one host fails cmake will try the next one.
Rename a filedeclare_datasource(FILE chr1.fastq URL https://example.com/human_chr1.fastq)

human_chr1.fastq will be renamed to chr1.fastq

What doesn't works right now:

[ ] Deleting downloaded file with make clean and make them reappear after executing make again.
[ ] Nested folder structures in data; I can't declaredeclare_datasource(FILE human/chr1.fastq URL https://example.com/human_chr1.fastq)
declare_datasource(FILE ape/chr1.fastq URL https://example.com/ape_chr1.fastq)

Kind reminder @marehr: This PR is waiting for your response. You just need to accept the suggested change actually...

And you need to rebase on master, please.

@joergi-w  sorry for the delay;


docs(sample): storage object get kms key

Hi @athakor,
This isn't a sample we need / scoped. I'm closing it as it's already supported in the viewing metadata sample here: https://cloud.google.com/storage/docs/viewing-editing-metadata
Apologies for having you go down this path. Could you tell me how you pick this work up to be careful in the future?


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

editing username validation function that returns false if it begins with nonalphabetic value.


Ensuring the market doesn't crash when asset has no services

Fixes #1768
Changes proposed in this PR:

Ensuring the market doesn't crash when asset has no services

To test: view this asset

Now the page is not crashing, but maybe we can do something for this two things:

show a message to the user instead of pricing calculation:
This:

Instead of:

let the user know the asset is missing its services (this might not be necessary, let's ask @mihaisc ) with a message somewhere in the UI

Yeah, good idea. I've updated the messaging so it shows the warning alert rather than infinite loading


SSH access? It's unclear.

It's not clear if private nodes can also have SSH access via gcloud. Guidance to how this would be enabled using this module?

hi @dionjwa, you can SSH into a private instance using a Bastion host if you've deployed one with our module. Our instructions could be clearer, so I'll leave this issue open. For more information, you can also refer to Google's documentation.

@dionjwa I am unsure about this as well. I have created a GKE cluster with private ips for the nodes with access only behind a VPN. I am trying to run gcloud compute ssh --internal-ip but running into a timeout error.
@robmorgan I have not tried but bastion host yet, but do you know if we should be able to ssh into the node using its private ip from vpn based on the current module?


Update README.md

Updates the versions that this can be used for.

Thanks for the PR! I'm not updating this anymore though - FabricMC/fabric#1115 has replaced this.


Unify InvalidMountConfiguration with MultipleErrors

The error response we get from Quasar outlined in https://github.com/slamdata/purescript-quasar/issues/36 is somewhat unfortunate. The error.status field is misleading, and one needs to get at error.detail.reasons which seems to be somewhat arbitrary to parse.
Could we either provide a proper human-readable error message at error.detail.message or use the MultipleErrors format (https://github.com/slamdata/purescript-quasar/issues/37) if we need to keep the array around?
/cc @garyb

{
  "summary": "Cannot read from file: `/foo/bar` because it does not exist",
  "tag": "FileNotFound",
  "details": {
    "file": "/foo/bar"
  }
}

summary: User readable summary of error


Using ExpressJs for the backend microservices

I recommend we wait until it is needed. Retrofitting is not problematic and why add complexity until we need it.

actually, only the register may need express as it acts as the reverse proxy.

I am actually using RestAngular to abstract the rest interaction with the backend and RestAngular requires rest vocab on the backend, which would be easier to build with Express,


Question: Subdir installation on Ubuntu 16.04 + nginx fails?

Expected behaviour
Following https://kanboard.net/documentation/ubuntu-installation (Ubuntu 16.04), which assumes no further configuration changes, should lead to a working installation - even when deployed in a subdirectory.
Actual behaviour
PHP_SELF is empty, thus when opening Kanboard in a browser, it references all resources to / and redirects the user to /?controller=... instead of /my-subdir/?controller=....
Workaround:
Delete
# Bypass the fact that try_files resets $fastcgi_path_info
# see: http://trac.nginx.org/nginx/ticket/321
set $path_info $fastcgi_path_info;
fastcgi_param PATH_INFO $path_info;

in /etc/nginx/snippets/fastcgi-php.conf. (PATH_INFO is empty then, however, PHP_SELF is not)
Alternatively, replace PHP_SELF with SCRIPT_NAME in https://github.com/fguillot/kanboard/blob/master/app/Helper/UrlHelper.php#L127.
Steps to reproduce

(optional: sudo add-apt-repository ppa:nginx/development (shouldn't make a difference, hopefully))

sudo apt-get install nginx php-fpm php-xyz-dependency...

Default PHP-FastCGI config in a server block:

server {
...
location ~ .php$ {
include snippets/fastcgi-php.conf;
fastcgi_pass unix:/var/run/php/php7.0-fpm.sock;
}
}
4. Install Kanboard as described here: https://kanboard.net/documentation/ubuntu-installation
5. Open `http(s)://host/subdir/kanboard/` - this will fail
6. Placing a file in `/subdir/kanboard/test.php` (`<?php var_export($_SERVER)?>`) reveals that `PHP_INFO` and `PATH_INFO` are both empty.

### Configuration

- Kanboard version: all affected
- Database type and version: default SQlite
- nginx version: 1.11.1
- PHP version: PHP 7.0.4-7ubuntu2.1
- OS: Ubuntu 16.04
- Browser: *

Thanks, @0ip, removing fastcgi_param PATH_INFO $fastcgi_path_info; from my config helped.

i'm using windows 7 and IIS where can i remove the fastcgi_param ? thanks in advance

@sensei412001, sorry, I'm not an expert in IIS, I thought that you're on nginx. Anyway, I still think that your issue is related to PATH_INFO, so you can refer to the Install and Congifure PHP section of this document. Basically they recommend to set cgi.fix_pathinfo=1 in php.ini.

thanks volodymyr-kushnir. appreciate it. hope someone could lend a hand

You could use this example for a working example: https://github.com/kanboard/kanboard/issues/2080


Remove incorrect man:clobber task

What was the end-user problem that led to this PR?
The problem was that man:clobber was listed under bin/rake -T but it wasn't working because it was trying to remove a non existent folder.
What was your diagnosis of the problem?
My diagnosis was that the correct task is actually bin/rake man:clean.
What is your fix for the problem, implemented in this PR?
My fix is to remove man:clobber and move its description on top of man:clean, so that it's correctly listed under bin/rake -T.

@bundlerbot r+

@bundlerbot retry


Consider the Fdroid store

This project is no longer in development, please see: https://github.com/jitsi/jitsi-android#unmaintained

Ah, thanks :)
Related to: https://github.com/jitsi/jitsi-meet/issues/1290


feat: Add SCD Type 2 Column Support

Prior to this PR you could only create an SCD Type 2 table if you had an "Updated At" timestamp in the source table. This PR makes it so that you can create an SCD Type 2 from any source by checking if specific columns have changed. Since you no longer have "Updated At" to tell you when that change was made it uses execution_time instead. As a result you can think of it as a less precise approach to SCD Type 2.
This PR includes support both for native SQLMesh and dbt adapter.
One challenge when testing the dbt runtime is that dbt doesn't allow freezing "now()" (their execution time). Before I had a simple way of patching their "now()" with the frozen now but it had a bug and I fixed it in this PR. This bug is actually what created the perceived behavior difference between dbt and SQLMesh so now they actually appear to behave the same.
I decided to leave the SCD_TYPE_2 model kind in place and alias it to be SCD_TYPE_2_BY_TIME and this is what this PR is not a breaking change. To me this seems fair since by time is the recommended and default approach so having the unqualified version f the name point to what we recommend seems fine. If others disagree then I can remove and make this a breaking change.

@eakmanrq we have a slightly similar use-case, but where the "updated at" timestamp could still be inferred from the source.
The source table is a daily snapshot of the raw data that changes over time. It has a "snapshot_date" timestamp, this column doesn't tell you if the record changed (so it doesn't fulfill the updated_at semantics), but it could be used as the resulting valid_from / valid_to column values. For example:
name,price,snapshot_date
foo,20,2024-01-01
foo,20,2024-01-02
foo,21,2024-01-03
foo,21,2024-01-04
food,21,2024-01-05

We can build an SCD type 2 from this and use snapshot_date instead of execution_time (if I understand correctly), the expected result would be
name,price,valid_from,valid_to
foo,20,2024-01-01,2024-01-02
foo,21,2024-01-03,2024-01-04
food,21,2024-01-05,NULL

Would it make sense to add support for this case out of the box? Perhaps this is already supported by the new kind?

@eakmanrq we have a slightly similar use-case, but where the "updated at" timestamp could still be inferred from the source.
The source table is a daily snapshot of the raw data that changes over time. It has a "snapshot_date" timestamp, this column doesn't tell you if the record changed (so it doesn't fulfill the updated_at semantics), but it could be used as the resulting valid_from / valid_to column values. For example:
name,price,snapshot_date
foo,20,2024-01-01
foo,20,2024-01-02
foo,21,2024-01-03
foo,21,2024-01-04
food,21,2024-01-05

We can build an SCD type 2 from this and use snapshot_date instead of execution_time (if I understand correctly), the expected result would be
name,price,valid_from,valid_to
foo,20,2024-01-01,2024-01-02
foo,21,2024-01-03,2024-01-04
food,21,2024-01-05,NULL

Would it make sense to add support for this case out of the box? Perhaps this is already supported by the new kind?

Thanks @plaflamme for sharing this use case. Basically you are wanting to create a SCD Type 2 table out of a snapshot table and that use case makes sense. There is already a bool which is updated_at_as_valid_from but that is exclusive to SCD_TYPE_2_BY_TIME. Conceptually this makes sense since if you have an updated_at then you would just use BY_TIME but you have a good example here where you want it BY_COLUMN but still use an updated_at value.
I like the idea of adding support for this but leaning towards adding support in another PR. The reason is that this one is already complex enough. It is a cool use case though and I would like to see support added.

@eakmanrq great! glad to hear this might be a useful addition.
Another PR sounds like a good idea. I'll open a separate issue so it this can be tracked separately, feel free to close it if it's not useful.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


dependencies: unpin wtforms

closes https://github.com/inveniosoftware/cookiecutter-invenio-rdm/issues/67
@fenekku invenio-accounts v1.2.1 and v1.1.4 have been released. Both include the email-validator dependency. According to our invenio dependency we should be in v1.1.4.

Coverage remained the same at 0.0% when pulling 2a363e6061c343fb83e9a81dede7d27af68010af on ppanero:email_val into 268de615eae0fcf93be7d914009bfcdc318972ea on inveniosoftware:master.


MAKE SURE the builds cannot be pushed

when you run Latest.bat,  git tries to push the bin (the compiled game) to GitHub, which will help avoid this.

duplicate of https://github.com/YoshiCrafter29/CodenameEngine/pull/22

it didn't provide a name so I didn't know


Fixing a Path Traversal Vulnerability

Hello,
It's possible that you don't use this code in production or the project is not maintained anymore, but we wanted to also increase security awareness and make the public codes more secure when they are being learnt by LLMs. also if it's only for development, securing the server increases security of the developer. Sorry if it bothers you.
We are a group of researchers from Leiden University, and found a vulnerability in your project.
Due to unsafe usage of path.join, this project is vulnerable to Local File Inclusion vulnerability.
You can read more about this vulnerability and its side effects here: https://cwe.mitre.org/data/definitions/22.html
The vulnerable code is at ./Rizzle/myPlayer/server.js file, which you can access online via: https://raw.githubusercontent.com/wuancake-backup/wuancake_web/HEAD/Rizzle/myPlayer/server.js
If any of path.join arguments is a relative path to the parent directory (../), the returned path can be outside the intended directory and this might lead to leakage of sensitive files.
Running the project:
We used node command to run the file directly: node ./Rizzle/myPlayer/server.js
Verified proof-of-concept(poc) to read passwd file(Path traversal vulnerability):
curl --path-as-is server_address:port/../../../../../../../../../../../../../../../../../../../etc/hostname

Denial of service vulnerability:
We also verified that this vulnerability can also lead to a Denial of Service attack, as it first loads the whole file content into memory, then tries to send the response.
Loading a large file (for example reading /dev/urandom/) can use all the memory within a few seconds and crash the server.
By default, running the vulnerable file opens a port in the network scope. Thus the Attack Vector (AV) of CVSS is: (N)etwork
Impact:
We've calculated the base score of the vulnerability as 9.1, with a severity of "Critical" using following the following vector_string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:H
You can view the CVSS score online via: https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:H
This patch is generated with the help of LLMs, we verified it's working and doesn't break application functionality but still we recommend you verify that it correctly mitigates the bug and doesn't hurt the functionality of your software.
Credits: Hamidreza Hamidi and Jafar Akhoundali
resolve #4
Feedback:
We would like to know your opinion about the quality of this report by filling a really brief survey with 4 questions:
https://leidenuniv.eu.qualtrics.com/jfe/form/SV_4JkS2loxBXVDlum

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Add support for Webhooks via WebhookPayload class

Fixes #8.
Adds WebhookPayload class, for use with Plaid webhooks.

did this get accidentally assigned too me?

did this get accidentally assigned too me?

Just wanted you to review if you don't mind.

@viceroypenguin
Hey vicero! I noticed that the WebhookPayload class has been deleted in newer versions of the library, was that intended?
Great work with this library btw, its super easy to use!

@Nach0Git Definitely not intended - I'll take a look and see what happened!

@Nach0Git Sorry it took me so long to get back to you. These classes were added when I was manually maintaining the entities and endpoints for this library. Now, I use the upstream openapi spec provided by Plaid to generate all of the entities and endpoints. I never added the webhook payloads as part of the generation. Adding a new issue (#158) to track. Hopefully have something today or by Monday. Feel free to subscribe to that issue for notifications.

@viceroypenguin Thanks for the update. I ended up creating my own Payload class for now. I'll definitely update the library once #158 is ready 👍

@Nach0Git v6.0.0 is released (minor breaking change via updated STJ dependency for lower tfms, but alas). Please give it a try. In theory, you should be able to use WebhookBase as the base class you receive in a webhook API, and it will type-cast to whatever payload is actually given by the server (AssetsProductReadyWebhook, for example).
If there are any issues or comments, please open a new issue and we'll see what I can do to address. I have not tested against the Plaid api directly, only against theoretical JSON values.


Shell Sort

Add comment to get assigned to your desired language.
Submission Title
Shell Sort
Submission Type
Algorithm
Submission Description
Write Shell Sort Algorithm
Submission Directory
Algorithm => Sorting => Shell _Sort => Shell_Sort.extension
Language

[x]  C++
[x]  C
[x]  Python
[x] Java
[x] JavaScript
[ ] C#

Hey! can I work on this in C.

Please assign me this in C++ and Python please, thank you

Hi @krishrahul98, could I work on this in Java..?

Hi @krishrahul98, could I work on this in Java..?

Assigned for Java

Hi, @krishrahul98, Can I work on this for js?

Hi, @krishrahul98, Can I work on this for js?

@afflato Assigned for JavaScript

Can you assign this for C?

Can you assign this for C?

@Neha2827 Assigned for C

Can you assign this for C++?


not going forward after submit button..I'm getting credentials if i console instead of this.get('session') line..I extended jwt authenticators and mentioned servertokenendpoint..I'm very new in ember,please help me out

`routes/login.js

import Route from '@ember/routing/route';
import Ember from 'ember';
export default Route.extend({
session: Ember.inject.service('session'),
model:function(){
return Ember.Object.create({identification: '', password : ''});
},
setupController: function(controller, model){
	controller.set('credentials', model);
},

actions: {
	authenticate: function(credentials) {
	this.get('session').authenticate('authenticator:jwt',credentials).catch((reason)=> {
		this.set('errorMessage',reason.error||reason);
	});
	}
}

});`

Please provide a proper description of the problem - you'll want to write that in complete sentences in the issue description rather than random keywords in the title. Also please make sure markdown formatting isn't broken (see https://guides.github.com/features/mastering-markdown/ for help).
I'm closing this as in its current form it's not actionable. Please feel free to fix and reopen afterwards.

ENV['ember-simple-auth-jwt']={       identificationField:'identification',       passwordField: 'password',       serverTokenEndpoint:'/tokens'     };``
`import JWTAuthenticator from 'ember-simple-auth-jwt/authenticators/jwt';
export default JWTAuthenticator.extend({
serverTokenEndpoint: "/tokens"
});`
I'm trying to do login authentication using jwt..I followed https://github.com/myartsev/ember-simple-auth-jwt for installing ember simple auth jwt..I'm getting credentials from my component..The thing is I still haven't assigned the token..If I press submit I need to get 404 because I haven't written any response for servertokenendpoint url /tokens..but submit isn't going anywhere.please help

sorry I really don't know how to use this platform..sorry again

The problem is with the this.get('session') line..I don't know what dependencies to be added..I'm so much new to ember

This sounds like it might be an issue with ember-simple-auth-jwt which actually is a separate project. You might want to have a look at https://github.com/myartsev/ember-simple-auth-jwt.

I'm not sure what error you're actually seeing.

I'm not seeing any error..the browser almost crashing after I click submit..I don't know why..If I remove that line and console crdentials credentials are getting printed

Hi,I'm getting new debugging error that authenticator is not defined..here's my code..can u help ?
`import Route from '@ember/routing/route';
/import ApplicationRouteMixin from 'ember-simple-auth/mixins/application-route-mixin';/
import Ember from 'ember';
export default Route.extend({
model:function(){
	return Ember.Object.create({identification: '', password : ''});
},

setupController: function(controller, model){
	controller.set('credentials', model);
},

actions: {
	authenticate: function(credentials) {
		 session: Ember.inject.service('session'),
		 authenticator = 'simple-auth-authenticator:jwt';
	this.get('session').authenticate(authenticator,credentials).catch((reason)=> {
		this.set('errorMessage',reason.error||reason);
	});
	}
}

});
`

Do we definitely need custom authenticators for login service ?


Allow injecting port without host/protocol (e.g., for gRPC)

I appreciate how easy this project makes it to configure WireMock for Spring Boot tests, but there's one thing that unfortunately prevented me from adopting it: We have some gRPC services that I would like to mock, with WireMocks gRPC support, but they can't be configured to use an HTTP url. Instead, I'd like to be able to do something like this:
@EnableWireMock({
        @ConfigureWireMock(name = "user-service", portProperty = "user-grpc-client.port", extensions = { new GrpcExtensionFactory() })
})

And then in application-test.yaml, do something like this:
user-grpc-client:
  target: "localhost:${user-grpc-client.port}"

Sounds good! Would you like to contribute a PR?

Hum. "Like to"? Yes. Willing to deal with the bureaucracy likely required for open-source contributions at $DAYJOB? Not so sure. If I have time, I will have a look at what would be involved, but can't guarantee anything. In turn, of course, I certainly don't expect you to drop everything to add this!

I think what you are looking for is merged (not yet released) you can now do:
  @Value("${wiremock.server.port}")
  private String wiremockPort;


Concurent connections problems

I am having problems with opening multiple connections at the same time. I get the DuckDB open failed error.
Works fine when I take care to open connections one by one.
I think the design whereby a database object is created for the life of the process, and each connection open call takes this database object as a parameter is a simpler design to get right.
It is more in line with the way DuckDb thinks under the hood, and is not contrary to anything in the ado.net spec.

Can you share your code that results in the error?

I can put together a repro in F#. Would that be OK?

Yes

You can find the repro here.
I have put together 3 test cases.
If you run the project as is (setting VS to allow the exceptions) you will get a report of the test results.
in test1, everything is done sequentially. If you comment out test2 and test3, it runs fine.
in test2, queries are run concurrently.
in test3, connections are opened concurrently, then queries are run concurrently.
The test library I am using is called Expecto. Unless you tell it not to, it runs all tests concurrently.
If you leave all 3 tests, it fails. If you leave only test1, it succeeds.

Hmm, I just amended my test project with an implementation of the database dependency that makes sure connections are always opened sequentially by a single thread. The problem persists. So it is not about opening connections concurrently. It is actually about running queries concurrently.

@travis-leith Can you check if the ThreadSafe-Connection-Open branch solves the problem for you?

I am getting the error: System.AccessViolationException: 'Attempted to read or write protected memory. This is often an indication that other memory is corrupt.'

Fixed in #18


[Bug]: what's the meaning of response.timing().requestTime?

Minimal, reproducible example
import puppeteer from 'puppeteer'

(async () => {
  const browser = await puppeteer.launch()
  const page = await browser.newPage()
  page.goto('whatever url')
  page.on('response', (response) => {
    console.log(response.timing())
    // console.log output
    // so, what does the requestTime mean?
    // the document says that: Timing's requestTime is a baseline in seconds
    // but how to convert this baseline to the real world timestamp?
    // {
    //   requestTime:<PHONE_NUMBER>89,
    //   proxyStart: -1,
    //   proxyEnd: -1,
    //   dnsStart: -1,
    //   dnsEnd: -1,
    //   connectStart: -1,
    //   connectEnd: -1,
    //   sslStart: -1,
    //   sslEnd: -1,
    //   workerStart: -1,
    //   workerReady: -1,
    //   workerFetchStart: -1,
    //   workerRespondWithSettled: -1,
    //   sendStart: 0.019,
    //   sendEnd: 0.019,
    //   pushStart: 0,
    //   pushEnd: 0,
    //   receiveHeadersStart: 0.588,
    //   receiveHeadersEnd: 0.705
    // }
  })
})

Error string
no error
Bug behavior

[ ] Flaky
[ ] PDF

Background
No response
Expectation
I expected the requestTime maybe is a timestamp like Date.now()
Reality
I got a number like<PHONE_NUMBER>89 in seconds，how to convert it to the real world timestamp?
Puppeteer configuration file (if used)
No response
Puppeteer version
21.1.0
Node version
16.20.1
Package manager
npm
Package manager version
8.19.4
Operating system
macOS

Probably this is the explanation https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/loader/fetch/resource_load_timing.h;l=103;drc=f4a00cc248dd2dc8ec8759fb51620d47b5114090 so I think you need to add that to the wallTime on the document navigation request.

Probably this is the explanation https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/loader/fetch/resource_load_timing.h;l=103;drc=f4a00cc248dd2dc8ec8759fb51620d47b5114090 so I think you need to add that to the wallTime on the document navigation request.

thanks！


ci: force build to release new version after branch migration

Current dependencies on/for this PR:

main

PR #2   👈

This comment was auto-generated by Graphite.

Merge Activity

Sep 13, 11:01 AM: @pjanuario merged this pull request with Graphite.


Validation

Validation does not complete when running comma-chameleon-darwin-x64.tar.gz in OSX 10.12.4.
Is it necessary to install CSVLint independently or use some other dependency?

Hm, no, the validator is all packaged up with traveling-ruby, so it should be OK. Are there any error messages, or does it just not show any validation messages in the window?

I think I've seen this behaviour a couple of times on my dev copy. It brings up the "Loading validation results..." dialog but fails to complete the validation, failing with a unexpected end of input error. I've been able to fix it by deleting the bin directory (where CSVLint lives) and re-running npm start.
I have no idea why this happens or how to reproduce it, but I will try investigate if I see it again.
It is interesting that it looks like it can also occur in the binary distribution.
@musebrarian - do you know what version (of comma chameleon, rather than your OS) you had this issue with and do you see the same behaviour with the most recent release?


document quiet/verbose options

For now, -quiet and -verbose work, but are not documented.
[n,t,summary] = doctest('foo') is now quiet-by-default, a change in behavior from the last version.
Probably they should be documented, unless we want to wait a bit and see what upstream/testify/etc do about this.
By default, I'm going to tag this 0.8.0...  but maybe  @catch22 feels strongly that it should be 0.7.0?

No strong feelings either way. 😄


Bump PocoCpp to 1.7.8

Add PocoCpp versions, 1.7.5 through 1.7.8
Bump PocoCpp default to 1.7.8

Poco use OpenSSL and should be hunterized, see https://github.com/hunter-packages/poco/commit/6ae25e2b94c641ba65291ce4b2eb0d21a1566c34
You should send updates to https://github.com/hunter-packages/poco/ first.

Could you please explain, Poco use OpenSSL and should be hunterized?
IMHO, projects using Poco should resolve OpenSSL (and other) dependencies themselves instead of being forced to download and build those dependencies using Hunter.
Since Poco uses OpenSSL, here's an example of how Poco can be built on OSX,
Hunter's config.cmake:
# OpenSSL must be downloaded manually beforehand using, "brew install openssl"
execute_process(COMMAND brew --prefix openssl OUTPUT_VARIABLE BREW_OPENSSL_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)

# Pass OpenSSL find paths to Hunter
set(HUNTER_CMAKE_OPENSSL_ARGS
        "OPENSSL_ROOT_DIR=${BREW_OPENSSL_DIR}"
        "OPENSSL_INCLUDE_DIR=${BREW_OPENSSL_DIR}/include"
)

# customize Poco
hunter_config(
        PocoCpp
        VERSION
        ${POCO_VERSION}
        CMAKE_ARGS
        ${HUNTER_CMAKE_OPENSSL_ARGS}
        POCO_STATIC=ON
        POCO_UNBUNDLED=OFF
        ENABLE_XML=ON
        ENABLE_JSON=ON
        ENABLE_UTIL=ON
        ENABLE_NET=ON
        ENABLE_NETSSL=ON
        ENABLE_CRYPTO=ON
        ENABLE_DATA=ON
        ENABLE_DATA_SQLITE=ON
        ENABLE_ZIP=ON
        ENABLE_TESTS=OFF
)

This way, projects building Poco with Hunter can decide for themselves how they want to get OpenSSL . For example, in my case I used homebrew to install OpenSSL on mac.
Poco uses a lot of other libraries besides OpenSSL like, APR, Apache2, EXPAT, SQLite3 to name a few (depending upon how its build), will you propose in that case, to have them all built using Hunter as well?

IMHO, projects using Poco should resolve OpenSSL (and other) dependencies themselves instead of being forced to download and build those dependencies using Hunter.

Hunter is designed around the concept of building redistributable SW from source from a consistent toolchain for predictable results.  FWIW, this has come up before, and I recall seeing some notes about mixing packages managers (i.e., homebrew + hunter) here:
https://docs.hunter.sh/en/latest/faq/interaction-with-other-package-managers.html
Which mentions an open issue/request for including system packages here:
https://github.com/ruslo/hunter/issues/501
Using system packages does seem to introduce a lot of complexity and uncertainty wrt ABI compatibility, etc.
You can always disable hunter HUNTER_ENABLED=OFF to default to system packages (if available) in your current find_package() calls, although that doesn't seem to be what you want here.

This way, projects building Poco with Hunter can decide for themselves how they want to get OpenSSL . For example, in my case I used homebrew to install OpenSSL on mac.

And if I want to use POCO and OpenSSL from Hunter in your project you will have a conflict:

https://docs.hunter.sh/en/latest/creating-new/cmake-dependencies.html#conflict

Poco uses a lot of other libraries besides OpenSSL like, APR, Apache2, EXPAT, SQLite3 to name a few (depending upon how its built), will you propose in that case, to have them all built using Hunter as well?

Some of them is not present in Hunter yet, so as a workaround the version from system can be used. But in general yes, they all should be managed by Hunter.

Thank you both for the explanation. I understand your concern regarding using system packages especially in case of a conflict.

Some of them is not present in Hunter yet, so as a workaround the version from system can be used. But in general yes, they all should be managed by Hunter.

In that case, ideally I would like to refactor hunterized Poco so that all the dependencies are managed by Hunter itself but that seems like a lot of work at the moment and out of scope of this PR.
I might summit another PR for that when I get time.
For now, I will just update the hunterized Poco to latest develop and submit a separate PR.

so that all the dependencies are managed by Hunter itself but that seems like a lot of work at the moment

@shekharhimanshu you don't have to add everything now, the OpenSSL was added because somebody needed it. So the issue with current pull request is that we will break this stuff hence it's not acceptable.

For now, I will just update the hunterized Poco to latest develop and submit a separate PR

Tell me what version you need, I will create branch hunter-X.Y.Z in https://github.com/hunter-packages/poco based on X.Y.Z upstream tag. Then you can send there hunterization patches from previous https://github.com/hunter-packages/poco/releases/tag/v1.7.6-p0 version.

Yeah sure. I need 1.7.8

https://github.com/hunter-packages/poco/tree/hunter-1.7.8

Cherry-pick top 3 commit from hunter should do the trick:

https://github.com/hunter-packages/poco/commits/hunter

Hi, sorry for the delay.
Seems like I don't have write permission to hunter-packages/poco?

Seems like I don't have write permission to hunter-packages/poco?

Check your email.

Updated.

Please squash everything into one commit.

Squashed.

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2120
https://travis-ci.org/ingenue/hunter/builds/262242092?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2123
https://travis-ci.org/ingenue/hunter/builds/262292384?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.62


Add equivalence subclasses for vehicles

Description of the issue
From issue #1277: using equivalence classes, the two most interesting aspects of vehicles (environment, propulsion) can be captured in one combined concept.
Ideas of solution
The general structure would look like that, with X being diesel, gasoline, liquefied petroleum gas, compressed gas, liquefied natural gas, battery electric, fuel cell electric, and grid supplied electric.

Axiom: EuqivalentTo 'X vehicle' and 'land vehicle'

X road vehicle: A X road vehicle is a X land vehicle that is also a road vehicle.

Axiom: EquivalentTo 'X vehicle' and 'watercraft'
X aircraft: A X aircraft is a X vehicle that is also an aircraft.
Axiom: EquivalentTo 'X vehicle' and 'aircraft'

For some combinations it is questionable, if they are used at all or widely enough to be included. Regarding battery electric and fuel cell electric, a lot of research is going on. That is why I would include all subclasses for them. The following ones are questionable:

gasoline train
gasoline watercraft
liquefied petroleum aircraft
compressed gas watercraft
compressed gas aircraft
liquefied natural gas aircraft
liquefied natural gas train
grid supplied watercraft
grid supplied aircraft

Workflow checklist

[x] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

To me it would me more logically (and easier to understand the concepts) to turn the definitions around and also include the propulsion in the definition. Just two examples:

An electric train is a train that has an electric traction motor and thus is also an electric vehicle.
A gasoline car is a car that has a diesel motor and thus is also a diesel vehicle.

The existing classes like electric vehicle, internal combustion vehicle, diesel vehicle would then have to converted in equivalent classes.

The existing classes like electric vehicle, internal combustion vehicle, diesel vehicle would then have to converted in equivalent classes.

I created issue #1311 for this.

I don't mind switching the definitions.
I also agree with converting the existing classes to equivalence classes.
If my logic works, that would make the equivalence axioms from above obsolete, right?

If my logic works, that would make the equivalence axioms from above obsolete, right?

Yes, we would have the equivalence axioms then at the vehicles-by-propulsion-type classes which makes more sense to me.

This is the current (inferred) structure of vehicles:

Which further vehicles to we want to add? I think we should only add those vehicles that are actually relevant and not every combination that is thinkable.

Okay.
Some proposals:

diesel truck: A diesel truck is a truck that has only a diesel engine as motor for propulsion and thus is also a diesel vehicle.
diesel car: A diesel car is a car that has only a diesel engine as motor for propulsion and thus is also a diesel vehicle.
gasoline car: A diesel car is a car that has only a diesel engine as motor for propulsion and thus is also a gasoline vehicle.
battery electric car: A battery electric car is a car that as an electric traction motor and a traction buttery and thus is also a battery electric vehicle.

Then I will start implementing.


stdenv: correctly make stdenv.system refer to the host platform

Motivation for this change
#46148 was supposed to make this change, but it did not due to an accidental use of buildPlatform instead of hostPlatform. This change should only affect cross-compilation, causing no rebuilds in the native case.
See https://github.com/NixOS/nixpkgs/pull/46148#discussion_r378012465 for more discussion.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @Ericson2314

Thanks!


Upgrade our issue templates to use GitHub issue forms ✍

Introduction
GitHub has recently rolled out a public beta for their issue forms feature. This would allow you to create interactive issue templates and validate them 🤯.
Appwrite currently uses the older issue template format. Your task is to create GitHub issue forms for this repository. Please use Appwrite's issue templates as a reference for this PR.
Tasks summary:

[ ] Fork & clone this repository
[ ] Prepare bug report issue form in .github/ISSUE_TEMPLATE/bug.yaml
[ ] Prepare documentation issue form in .github/ISSUE_TEMPLATE/documentation.yaml
[ ] Prepare feature request issue form in .github/ISSUE_TEMPLATE/feature.yaml
[ ] Push changes to master and test issue forms on your fork
[ ] Submit pull request

If you need any help, reach out to us on our Discord server.
Are you ready to work on this issue? 🤔 Let us know, and we will assign it to you 😊
Happy Appwriting!

@TorstenDittmann @Meldiron I want to work on this
Can you assign me ?

@MidouWebDev  All the best :rocket:

Hi @christyjacob4! Can you assign this issue to me.

@christyjacob4 Can I raise some issues to start contributing to this project?

@RiyaGupta89  Sure, you can raise the issues and the core team can help you decide whether they are relevant for the project. :+1:

Issue closed? 🤔 I would love to help incase there is any help needed!

@siddhiiguptaa Looks like this issue has already been taken. We would love you to check out some of our other open issues and join us on Discord if you need help finding some.

@Amnx404 @akashgp09 Whoops looks like there was a small confusion. In this case, we will accept the first of your PR from @akashgp09.
@Amnx404 We would love you to check out some of our other open issues and join us on Discord if you need help finding some.


Is the stc.plot hemi parameter broken?

Describe the bug
For my own code plotting source estimates only the right hemisphere is no showing, even if I set hemi="both
Steps to reproduce
I think this may also be evident in the examples like
https://mne.tools/dev/auto_tutorials/inverse/40_mne_fixed_free.html#fixed-orientation
which had code
snr = 3.0
lambda2 = 1.0 / snr ** 2
kwargs = dict(initial_time=0.08, hemi='both', subjects_dir=subjects_dir,
              size=(600, 600))

stc = abs(apply_inverse(evoked, inv, lambda2, 'MNE', verbose=True))
brain = stc.plot(figure=1, **kwargs)
brain.add_text(0.1, 0.9, 'MNE', 'title', font_size=14)

Expected results (docs from 0.23)

Actual results (docs from 0.24-dev)

Additional information

it seems so...

I can look into this today hopefully

Thanks, that was quick!


Support to FreeNoise

Is it worth to add support to FreeNoise from "FreeNoise: Tuning-Free Longer Video Diffusion via Noise Rescheduling" (http://haonanqiu.com/projects/FreeNoise.html)?
It looks like it improves the time consistency for longer videos on VideoCrafter, and I imagine it might be useful for animatediff too.

this just dropped - https://github.com/arthur-qiu/FreeNoise-AnimateDiff

Thanks for the heads up, having an implementation already existing will be super helpful in porting it over. I'll look into it this week.

Eagerly looking for this, thank you Kosinkadink for your efforts.
I’ve seen some commits related to this in the dev branch, should we expect a release soon or just use the dev branch ?

FreeNoise has been in dev for a couple weeks while I worked on some other features, but as of 20 minutes ago or so, all of those features are now in main branch.
Here is how to use FreeNoise through the Sample Settings:

Thanks for your efforts. I have seen a cool demo on Twitter: https://x.com/toyxyz3/status/1751256029961335218?s=20.


prefetch-npm-deps: bail upon seeing git dependencies with install scripts

Description of changes
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This is basically done, I just don't feel like writing a proper description right now, so a draft it is.

Maybe I should have ran the tests on the last commit before pushing... oops.
So, as far as I know, there are some dependencies (like node-sqlite3 here) where their install script runs fine. So, we have two options here:

Warn instead of bailing
Bail, but allow the user to say "I want to try to see if this dependency works," via an environment variable or something

Would appreciate any thoughts on this.

So, as far as I know, there are some dependencies (like node-sqlite3 here) where their install script runs fine. So, we have two options here:

Warn instead of bailing
Bail, but allow the user to say "I want to try to see if this dependency works," via an environment variable or something

Would appreciate any thoughts on this.

I'm slightly inclined towards warning if it's non-fatal enough of the time and the warning would be somewhat prominent/not buried in the middle of logs
What is an example of a dependency that it breaks for?
(Also I'll do some actual testing on this PR in a bit, hopefully today or tomorrow)

What is an example of a dependency that it breaks for?

https://github.com/mongodb-js/electron-notarize, depended on by https://github.com/mongodb-js/mongosh.

Superseded by #206476.


Go to implementation (and implementation code lens) are missing

VSCode Version: Code - Insiders 1.13.0-insider (770206ab9c6357943a2145bd3ea49b667f3ff539, 2017-05-26T05:14:23.944Z)
OS Version: Windows_NT ia32 10.0.16199

Steps to Reproduce:

Open the vscode codebase
Open an interface with known implementations
:bug: Go to implementation menu item, and implementation code lens are missing

FYI, this all still works fine on 1.12
Here is the output from the TypeScript channel:
[Info  - 12:22:10 PM] Using tsserver from: c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\node_modules\typescript\lib\tsserver.js
[Info  - 12:22:10 PM] Forking TSServer
PATH: undefined

We removed go to implementation from the context menu: #25913 You still should be able to run the go to implementation command or use the Go menu to run go to implementation
For the code lens, can you check that you have "typescript.implementationsCodeLens.enabled": true and "editor.codeLens": true set

@mjbvz that's too bad I quite liked it on the context menu -- very discoverable, where as having both peek definition and go to definition, feels quite redundant ;)
I definitely did have both of those settings on, but I can no longer reproduce this in the latest nightly.

ok, glad to hear the codelenses are working again. Perhaps just a bad insiders build
Yes, there was some discussion about the context menu change but the main reason we removed it is that compared to go to definition, go to implementation usually only applies to a handful of locations in a file. We may revisit the context menu items in the future though and also are tracking allowing the context menu to be configured with #9285

VSCode version: 1.16.0-insider
go to implementation cmd does not work. Is the cmd is removed?


[Microsoft.AspNet.Loader.IIS] StackOverflowException bug

I'm not sure if this is the right place for this report since, but seems to be the closest match.
There is a bug in Microsoft.AspNet.Loader.IIS with the IHttpContext/IHttpRequestLifetimeFeature implementation, which causes a StackOverflowException when httpContext.CancelationToken is accessed from a DI injected instance.
This bug only occurs when the DI lifetime of the instance which accesses the CancelationToken is singleton, when the lifetime is set to scoped, then it works without any exception.
My guess is that the bug is somewhere in Microsoft.AspNet.Loader.IIS.Infrastructure.ClientDisconnectedTokenUtil or it's Interops, rather then DependencyInjection itself.
More details and a sample project to reproduce the bug:
https://github.com/hiiru/AspNet5-IISLoader-StackOverflow
Also on other implementations like WebListener it works without the exception.

@moozzyk @Tratcher can one of you take a look?

@moozzyk  and I took a quick look. There appear to be three related issues:

The initial scenario isn't supported. HttpContext is a per-request data structure. When OverflowManager is used as a Singleton it captures the HttpContext instance on the first request and then re-uses it during subsequent request.
When HttpContext.RequestAborted is called for a completed request it fails to notify the user that they've performed an invalid operation. It proceeds to call IIS with invalid/disposed arguments.
The invalid arguments passed to IIS appear to cause an internal stack overflow.

@Tratcher can you log appropriate specific bugs in each repo for the items that are actual bugs? Then we can close this bug.

This issue was moved to aspnet/Helios#192


Update release instructions.

Update the instructions as done in googleapis/google-cloud-cpp-common#80

This is effectively done, the builds fail if any generated markdown is out of date.


Verify binary statistics for non-ASCII Parquet columns

String and binary predicates for Parquet are disabled in Spark, we should include those observations when we build index, and need to modify statistics to show correct values for non-ascii strings.

See SPARK-17213

Fixed in #31.


Update Clang.jl generator scripts

Upgrade generator scripts because the old one will become end-of-support soon.
Tests are passed and most changes seem harmless. The changes are extracted at https://gist.github.com/melonedo/eefdbd1f4573c3a17ff2cddbeb1dce7f/revisions.
cc @gnimuc

Let me see if close&reopen triggers our CI

Seems the tests failure are due to #22, that patch has been applied.


update docs README for instructions to build locally

What kind of change does this pull request introduce?
update docs README file for instructions to build the docs website locally
Checklist

[x] Documentation
[x] Ready to be merged

Hey @betomoedano, thanks for writing this down!
What do you think if we put into the Contribuition Guide? I think it would make more sense because the readme file you changed is about docusaurus and not about the Sandpack application.

Hey @danilowoz, thanks for answering!
You are right! what do you think if under the Contribution Guide we add another sub-section called "Running Locally"?
Do you think that title makes sense?

Makes totally sense! Feel free to propose any changes that you think are relevant.

I added the "Running Locally" section, please let me know what you think. 👍


command 'extension.updateSettings' not found

Visual Studio Code Version : [ 1.12.2 ]
Code Settings Sync Version : [ 2.7.0 ]
Operating System : [ Windows 10 x64 bit ]
Whenever I try running the Sync : Update / Upload Settings command from the command palette, and I get the following message on the top:

command 'extension.updateSettings' not found

Have tried various things from https://github.com/shanalikhan/code-settings-sync/issues/78 but to no avail. this is the only error that seems to produce at all in the dev console http://i.imgur.com/1GvFcc8.png
Edit: seems the whole extension is broken or something, as running any other command just throws out a

Command 'extension.%whatever the command was%' not found

error.

or after about half an hour of fiddling with things I seem to have fixed it O_o dunno what I did, but it seems to be working now again..

This is affecting me on Linux

Same problem for me on Fedora 25.

This is effecting me on macOS.

What is the exception in console

Copied from my update in a closed ticket:

Version 1.12.2
Commit 19222cdc84ce72202478ba1cec5cb557b71163de
Date 2017-05-16T08:14:27.220Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
The root path may be $HOME/.config/Code - OSS as $HOME/.config/Code/ doesn't exist.

The root path may be $HOME/.config/Code - OSS

This extension doesnt support OSS version at the moment.

After some reading, I see that 1.12.x is the OSS version. I think package.json allows any version 1.x.x to install this extension.
"engines": {
  "vscode": "^1.11.0"
}

Restricting the engine version may reduce the number of bugs that are reported by 1.12.x users.
"engines": {
  "vscode": "< 1.12.0"
}

I would put a PR in, but I am not sure the minimum engine version you are targeting. If you provide that, I can put a PR in with this change.

I have the same Code version with the same commit and the details you have mentioned.
and Its not Code - OSS
If we try to vscode": "< 1.12.0" it will effect all code versions like insiders and standard Code and wont install on above versions.
What can be done is that extension need to identify which version of code is running - standard / insiders / OSS and make OSS paths, like its doing for Insiders and standard code version.
I will be more happy to accept the PR, if you are willing to do that.

I will take a look into what is involved with setting up a dev env for vscode. In the time being, I looked at how this could be solved. Now I haven't worked with vscode extensions at all, ever, so please feel free to stop me at any time.
https://github.com/shanalikhan/code-settings-sync/blob/master/src/environmentPath.ts#L85-L86
 var codePath = this.isInsiders ? '/Code - Insiders' : '/Code';
 this.PATH = this.PATH + codePath;

could be changed to
this.PATH = getDefaultUserDataPath(process.platform)

Function definition -> https://github.com/Microsoft/vscode/blob/master/src/paths.js#L19
Few more sections may be able to be refactored but without a dev env currently setup, I can't confirm it would work properly.

@fkumro All paths defined in the function is present in the extension file already.
But i am not acknowledge of code providing a API to get the paths ( i'm not sure now, but it was not present when i wrote). But you can try
Its in my roadmap for OSS but i will first solve and implement a chunk of features that are opened in the issue portal.
Open new issue, Lets discuss this there.

same for me in Windows 10


Problem into showShareSheet() share with facebook

hi again,
i use your last commit (2.4.7) but i  have a problem now with share to facebook.
When i call my function showShareSheet() , i have the window with share possibility .
And when i click on Facebook ( not Save to Facebook ) , the  "Save to Facebook" called . Before this update, works great
I just test on android phone, i can try to test on IOS if u want
before that , I forget delete my app and  all works fine , deeplink and button share to facebook.
Best regards

Hello @fx69005,
Can you please provide me with some screenshots? I've just tested the latest version of the Branch SDK (2.4.7) and the showShareSheet() function is working for both iOS and Android for Facebook.
I'm not too sure what you mean by "save to facebook".
Best,

Hello @ethanneff ,
so  when i click on this button

I have this message

this message in english is : register in Facebook , only you can see the things you save.

Hello @ethanneff , do u seen my screenshot ?
best,

Hello @fx69005,
Sorry about the delay. I am looking into this. I will reach out as soon as I have more information.
Best,

Hello @fx69005,
Did you make any changes to your Facebook settings, Facebook account settings, or the Facebook user on your device? The error you are getting is a Facebook error for unauthorized access. This typically happens whenever you are trying to generate a Facebook post to a place on Facebook which you do not belong to.
Best,

Hello @ethanneff ,
No, i didn't change my Facebook settings. When i use "showDialog()" function by "Cordova facebookv4 plugin", le window 'Share' works great. so my facebook setting is good
But when i use showShareSheet() in your plugin. 'Save to facebook' is triggered ( green box in the picture )

@fx69005 , can you try to disable the Cordova facebookv4 plugin your using? This might be having a conflict with the share sheet functionality.

@ethanneff , i tried but not works when i delete cordova Facebookv4 plugin on my project

@ethanneff
i try on an other an device and works great ! it works on Nexus 5 android 6.0.1

but on my Samasung GS7 android 6.0.1  same problem.
if u look share sheet modal u can see only ' Facebook' button on Nexus 5 but on Samsung GS7 we have 2 buttons 'Facebook' and 'Save to Facebook' .

Hello @fx69005,
Sorry about the delay. It took us awhile to get a Samsung GS7 Android 6.0.1 test device. Unfortunately, we are still unable to replicate this issue. We cannot get Save to Facebook to show in our ShareSheet.

How are you getting Save to Facebook to show in your sharesheet?
Is it related to the Cordova facebookv4 plugin you had installed?
Have you tried deleting and re-installing the app after removing the Cordova facebookv4 plugin?

The reason why I ask is because no one on our team has seen Save to Facebook, so we are having trouble debugging your issue. Any information you can provide would be appreciated and helpful.
Best,

hello @ethanneff ,
Thanks for your reply,
Cordova Facebookv4 is uninstalled and i have 'save to facebook' button. i think is an another app or something like that who create this button. Probably only on my smartphone.
so we can close this thread.
But have do you have a date for merge  this pull request ? : #261
I need this  because  i use "ionic package" for create my app on IOS
Merry christmas !

Hello @fx69005,
I have finally figured out your issue! When you have your device showing the Facebook and Save to Facebook options and you select the Facebook option, the first time, you will be presented with this screen:

If you select the Share with Save to Facebook and click always. Every subsequent Facebook share you make, instead of posting to your Facebook feed, will directly use the Save to Facebook option and save it under the Saved Tabs. Unfortunately, this is how the Facebook app is structured and there is nothing Branch can do about this.
To reset these app links, please follow the following steps:

Go to Settings
Select Apps
Tap on the Gear at the top right corner
Select App links
Scroll down to Facebook
Tap on clear Defaults

Doing this should show you the Above Menu again. This will allow you to make sure clicking on Facebook will share to Facebook.
Best,

hello @ethanneff ,
thanks for your answer , works now!
Do you have an idea of date to merge #261 ? i really need it ! thanks

Hello again @fx69005!
Unfortunately, that pull request may take a month or two before it is merged.

#261 is low priority since the current Cordova Branch SDK is stable
#261 is large update with many breaking changes
#261 needs extensive regression tests to make sure the major release is robust

I apologize for the bad news. Branch wants to make our products the best they can be, and in doing so, we need to make sure we do not negatively impact any of our users with major releases.
Regards,


Can't connect to the Websphere administrative console

Sorry for my terrible english!
On a fresh session on https://labs.play-with-docker.com/ I want to create a WebSphere container (version 9.x) with following command:
   git clone https://github.com/mzambrini/tutorial-websphere.git \
   && cd tutorial-websphere \
   && git checkout tags/v1.0.0 \
   && docker build -t my-was9-app -f Dockerfile9 . \
   && docker run --name was9 -p9060:9060 -p9080:9080 -d my-was9-app

After the server has started, I can't connect to the administrative console on port 9060 (security is disabled) with context root  /ibm/console via external IP like
http://ip172-18-0-34-bg78ad43uhdg008486ag-9060.direct.labs.play-with-docker.com/ibm/console

If, however, I execute the following command
wget -O index.html http://localhost:9060/ibm/console

I get a consistent result.
I can connect to the deployed application at IP like
http://ip172-18-0-92-bg78fv8v0j3g00fv3p3g-9080.direct.labs.play-with-docker.com/SampleAjax/simpleTextDisplay.faces

Strangely, if I run the build of Webssphere container version 8.5.5.x, instead, with command
   docker build -t my-was8-app -f Dockerfile8 .

after creating the container, everything works!
Thanks for your attention!

try adding 9060 in the end of the admin console url. i.e:
http://ip172-18-0-34-bg78ad43uhdg008486ag-9060.direct.labs.play-with-docker.com:9060/ibm/console
That should make it work


Match development with Appstore Connect API KEY fails due unexpected token error if there are more 18 bundle ids in matchfile

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
We started getting the unexpected token error when running match(force_for_new_devices: true,readonly: false). It worked well with the same api key but stopped working for us 2 weeks ago or so. We also tried it with new api key with "App Manager" role but it didn't help. The rest fastlane commands work well with api key (haven't tried match appstore yet)
Command executed
match(
        force_for_new_devices: true,
        readonly: false
      )

Complete output when running fastlane, including the stack trace and command used
Successfully decrypted certificates repo
[18:22:09]: Verifying that the certificate and profile are still valid on the Dev Portal...
[18:22:09]: Creating authorization token for App Store Connect API
+----------------------------------------+
|              Lane Context              |
+---------------+------------------------+
| ENVIRONMENT   | development            |
| PLATFORM_NAME | ios                    |
| LANE_NAME     | ios install_provisions |
+---------------+------------------------+
[18:22:10]: unexpected token at '
403 Forbidden

403 Forbidden
Apple

'

Thanks for this information.

It looks like you’re encountering a 403 Forbidden error with Fastlane’s match command. Here’s what you can do:

Check API Key: Ensure your API key has the correct permissions and is not expired.
Update Fastlane: Make sure Fastlane is updated to the latest version as this might be a known issue that has been resolved.


SpotifyAPI.Web.Http.IResponse response ProcessError

Everything is working fine on my samsung phone, but my friend has issues on his xiaomi, I'm working inside of xamarin forms for android, if it means anything
Here's the exception:
Message: Exception of type 'SpotifyAPI.Web.APIException' was thrown.
StackTrace:   at SpotifyAPI.Web.Http.APIConnector.ProcessErrors (SpotifyAPI.Web.Http.IResponse response) [0x00058] in :0
at SpotifyAPI.Web.Http.APIConnector.DoRequest (SpotifyAPI.Web.Http.IRequest request) [0x00247] in :0
at SpotifyAPI.Web.Http.APIConnector.DoSerializedRequest[T] (SpotifyAPI.Web.Http.IRequest request) [0x00086] in :0
at SpotifyAPI.Web.Http.APIConnector.SendAPIRequest[T] (System.Uri uri, System.Net.Http.HttpMethod method, System.Collections.Generic.IDictionary2[TKey,TValue] parameters, System.Object body, System.Collections.Generic.IDictionary2[TKey,TValue] headers) [0x00095] in :0
at MyProgram.Main.Playlists_Clicked (System.Object sender, System.EventArgs e) [0x00093] in <608f8fcc9d814efbb22da1b695ab6a9d>:0
Source: mscorlib
TargetSite: Void Throw()

This issue seems similar to mine, not sure if I can help out somehow

Moved to .net maui, here's what the exception looks there:
Message: Exception_WasThrown, SpotifyAPI.Web.APIException
StackTrace:    at SpotifyAPI.Web.Http.APIConnector.ProcessErrors(IResponse response)
at SpotifyAPI.Web.Http.APIConnector.DoRequest(IRequest request)
at SpotifyAPI.Web.Http.APIConnector.d__301[[SpotifyAPI.Web.SearchResponse, SpotifyAPI.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]].MoveNext()    at SpotifyAPI.Web.Http.APIConnector.<SendAPIRequest>d__341[[SpotifyAPI.Web.SearchResponse, SpotifyAPI.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]].MoveNext()
at MyProgram.MainPage.ButtonFind_Clicked(Object sender, EventArgs e)
Source: SpotifyAPI.Web
TargetSite: Void ProcessErrors(SpotifyAPI.Web.Http.IResponse)

Found the issues with the http logger, I didn't give access individually in the spotify dashboard


fix(throttleTime): fix trailing

Description:
Emitting a trailing value should be counted as emitting a value.
Commit that introduced bug
Related issue (if exists):
#2859

This PR can be closed since the issue has been addressed in PR #4564.


Fix typos regarding the ssl-passthrough annotation documentation

Sorry for opening this in the wrong repository, clicked too fast :)

This change is

/lgtm

@ankon thanks!

Merging. Just docs.

Coverage increased (+0.03%) to 43.894% when pulling 9dcac88b3dd1f5b8aeef0bc5050cd4477b0f7858 on ankon:patch-1 into e2c7a536e9bb10e107b7a2d7affbe7d18e85d8a8 on kubernetes:master.


Can etcd-cpp-apiv3 support C++20?

I'm tring to use etcd-cpp-apiv3 as submodule in my project, which compiles through C++20. Firstly, my project will compile etcd-cpp-apiv3 without installing, and then it compiles my code which use etcd-cpp-apiv as a library, but it appers that etcd-cpp-apiv3 generate compile error. I found the reason below:
in etcd-cpp-apiv3/CMakeLists.txt
   macro(use_cxx11)
  if(CMAKE_VERSION VERSION_LESS "3.1")
    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")
    endif()
  else()
    set(CMAKE_CXX_STANDARD 11)
  endif()
endmacro(use_cxx11)

# ensure C++11
use_cxx11()

this will force etcd-cpp-apiv3  to use C++11.
So, can we plan to support  C++20?

You could set CMAKE_CXX_STANDARD to 17 in your own project.
We currently have no plan to switch the minimal requirements of the etcd-cpp-apiv3 itself to C++17.


Update fwlinks

A few new fwlinks have been created for string resources in 2.0. They currently point to existing topics:

Some of them are ok
Some of the topics need to be expanded
For some of the fwlinks we should create new topics:

[ ] ASP.NET startup requirements for EF Core tooling to resolve a DbContext using DI https://go.microsoft.com/fwlink/?linkid=851728 For

Moving this from the backlog into 3.0 and fixing labels. We have new fwlinks in exception messages in 3.0, and specifically in query we want to make sure they point to clear guidance, re client-evaluation (e.g. https://go.microsoft.com/fwlink/?linkid=2101038), unsupported expression (e.g. https://go.microsoft.com/fwlink/?linkid=2103067), etc.
We should go back to review fwlinks added in recent releases and identify if existing content is appropriate or if new contents need to be created and where they should live, then update the fwlinks.


Nuxt 3 / "vue3-tour" is imported but could not be resolved – treating it as an external dependency.

Hi,
When implementing vue3-tour v1.0.2 in a Nuxt 3 starter setup, I have build issues.
vue3-tour is implemented using Nuxt plugins.
When running npm run dev I have no issue but when I run npm run build I get the following warnings : "vue3-tour" is imported by ..., but could not be resolved – treating it as an external dependency.. Then, running node .output/server/index.mjs to preview the result returns an error 500.
Reproduction link : https://stackblitz.com/edit/nuxt-vue3tour-skwbja?file=plugins%2Fvue3-tour.ts

Hi, Add vue3-tour to the build.transpile option in your nuxt.config.ts file
build: {
transpile: ["vue3-tour"],
},


Implemented SESSION_COOKIE_SAMESITE

Would like to see this merged

would be great to see this merged please

        httponly = self.get_cookie_httponly(app)
        secure = self.get_cookie_secure(app)
        expires = self.get_expiration_time(app, session)
        val = self.serializer.dumps(dict(session))
        samesite = self.get_cookie_samesite(app)
        self.redis.setex(name=self.key_prefix + session.sid, value=val,
                         time=total_seconds(app.permanent_session_lifetime))
        if self.use_signer:
            session_id = self._get_signer(app).sign(want_bytes(session.sid))
        else:
            session_id = session.sid
        response.set_cookie(app.session_cookie_name, session_id,
                            expires=expires, httponly=httponly,
                            domain=domain, path=path, secure=secure,
                            samesite=samesite)

Versions of Flask older than 1.0 would break.

@fengsp Would you be willing to merge if we created some kind of capabilities switch based on flask version?

Using some try-except blocks could be a rather quick solution to avoid breaking older Flask versions: try calling the set_cookie method with the samesite parameter and fallback to the current call in case of exceptions

Ok sorry have not been looking at this, I updated my fork and commited and update that will conditionally resolve and pass the samesite cookie kwarg to the set_cookie method on the SessionInterface base. Should be compatible with older versions of flask that do not have get_cookie_samsite and/or do not have the samesite kwarg on set_cookie

I think it's pretty critical to get this fix in. Without it, the Flask SESSION_COOKIE_SAMESITE setting essentially goes into a void and does so silently. As others have mentioned, browsers have implemented default controls around the SameSite attribute. Unless developers are checking their session cookie manually, they may not even notice their security settings aren't being propagated. This is on-top of potentially breaking applications due to browser enforcement of cookie attributes.
This fix looks good, and I'm hoping it can be merged in soon.

This would be super helpful.  This issue is breaking an app I am developing for my school.

+1 This should be merged, especially with Chrome's recent removal of 3rd party cookie support with SameSite=None.


rafthttp: mark unreachable on unexpected response

In rafthttp, when making request to some endpoint, it may receive
response with unexpected status code and header. This indicates the endpoint
doesn't function correctly. It should mark the endpoint unreachable.
Also make minimal changes to make code much readable.
fixes #3652

Addressed all comments.

Addressed all the comments. ready for the review.

Remove the refactoring code. I will clean up code together in separate clean-up PRs.

LGTM


[Bug]: recovery_min_apply_delay rejected by admissions webhook

Is there an existing issue already for your request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new documentation enhancement to be evaluated.

What problem in the existing documentation this issue aims to solve?
Found the following issue: https://github.com/cloudnative-pg/cloudnative-pg/issues/4021
This implies that recovery_min_apply_delay is accepted as postgresql parameter, however, when attempting to apply this parameter via clusters yaml, we get an admissions webhook rejection "Invalid value: "1h" Can't set fixed configuration parameter."
The docs also state the following:
Some PostgreSQL configuration parameters should be managed exclusively by the operator. The operator prevents the user from setting them using a webhook.

Users are not allowed to set the following configuration parameters in the postgresql section:

<snip>
recovery_min_apply_delay

So it seems we're at an impasse, where to implement a delayed replica we need to set a postgresql parameter, but the operator does not allow the postgresql parameter to be set by the user even though the documentation suggests this should be possible.
Is it possible to set recovery_min_apply_delay via another means that I've overlooked?
Describe what additions need to be done to the documentation
No response
Describe what pages need to change in the documentation, if any
No response
Describe what pages need to be removed from the documentation, if any
No response
Additional context
No response
Backport?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This should only be allowed in the case of a replica cluster.

This is a bug IMHO

We should:

add the provided value in the custom.conf file
enforce recovery_min_apply_delay to 0 in override.conf unless you are a primary or a designated primary.

Since the idea is to allow delays only on the dedicated primary of a replica cluster, we could have a specific parameter in the replica section. I believe it would make clearer to the users where the parameter applies, without a configuration parameter that behaves differently according to the instance underneath. We could also easily add a CEL rule to prevent a using a promotionToken together with a delay, as it would make little sense to try a controlled switchover on something artificially lagging behind.

I like @fcanovai proposal. Putting the parameter in the replica section makes its scope self-evident.

I like this. Yesterday I was chatting with Armando and one possible solution would have been a webhook that prevented a designated primary to be promoted if recovery_min_apply_delay was set. But ... I agree, this is more elegant.