param dropdown and images?

Supposing someone wanted to get a param.ObjectSelectorList or something similar with all the colorbars in colorcet http://colorcet.pyviz.org, would it be possible to do that with each of them being rendered as images of the colorbars? So I guess the general question is: Can I get a parameterized dropdown list that is populated with hv.Images?

Ooh, that's a fun question!  I have no idea.

@jbednar I think I've seen a demo of the colorbars rendered as an object selector, but I can't remember where. Can you point me to it?

I still think that's a great idea, with a selector being able to use text, images, or text + images (for icons, colorbars, avatars, etc.).  But I don't think I've seen that for Bokeh selectors. @jsignell, have you?

So the selector would display an image rather than text? I haven't seen that. The closest I've seen is the color picker which isn't really a selector in the same sense. I think we'd need to write a new dropdown menu to accommodate displaying images in it.

Yeah, that would definitely require a new bokeh model.

The color picker is the thing I was thinking about. I don't think building a new bokeh model is within scope at this point.

That's a shame; seems like a fun task to work on. :-)


[$1000] Add Phone Number validation to New Chat field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the floating action menu
Select "New Chat"
Type in an invalid phone number IE +444
Create the chat
You will get an error

Expected Result:
We should validate that the entered phone number is in a valid format. We want to make sure that entered phone numbers follow the correct pattern for a given country code, regardless of formatting i.e. (+1-123-123-1234, +11231231234, +<IP_ADDRESS>4) should all work. Preferably this would be done with Regex, but other proposals are welcome. Additionally we need to ensure that this is done for all search types (new chat, group chat, split bill, etc).
Actual Result:
You can create the chat with an obviously broken phone number
Workaround:
Just don't enter those numbers
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): All
Logs: https://stackoverflow.com/c/expensify/questions/4856 n/a
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @stitesExpensify
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1681418937228539?thread_ts=1680815598.330879&cid=C03U7DCU4
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01319c46dbb72458cd
Upwork Job ID:<PHONE_NUMBER>403300352
Last Price Increase: 2023-04-14

Job added to Upwork: https://www.upwork.com/jobs/~01319c46dbb72458cd

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

@Prince-Mendiratta Thanks for the proposal. I think we want to use awesome-phonenumber because it's something already being added here https://github.com/Expensify/App/pull/16804. Can you please update your proposal based on that?
Also please make sure to cover the following cases:

Validation of international phone numbers (phone numbers with country code)
Validation of local phone numbers

Proposal**
Please re-state the problem that we are trying to solve in this issue.**
Add Phone Number validation to New Chat field
What is the root cause of that problem?
This is a feature request, not a bug.
What changes do you think we should make in order to solve the problem?
Using regular expressions (regex) to validate phone numbers can help solve the error in Expensify where an invalid phone number can be entered in the "New Chat" feature.
The regex pattern (^+(?:[0-9]●?){6,14}[0-9]$) checks whether a string starts with a plus sign (+) and is followed by between 6 and 14 digits (inclusive). If the input matches this pattern, the phone number is considered valid.
By using this regex pattern to validate phone numbers before creating a chat, we can prevent invalid phone numbers from being submitted and causing errors. This ensures that the phone number entered by the user is in a valid format, which will help prevent any issues with sending messages to that phone number later on.
What alternative solutions did you explore? (Optional)
Using the awesome-phonenumber library to validate phone numbers can also help solve the error in Expensify's "New Chat" feature.

📣 @apt-get-sahil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

 Thank you for contributing to Expensify!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Add Phone Number validation to New Chat field
What is the root cause of that problem?
Currently we are not validating phone numbers
What changes do you think we should make in order to solve the problem?
As mentioned above, we should use awesome-phonenumber package to validate phone numbers.
We can make use of parsePhoneNumber method and check if this phone number is possible or not. If yes we can get pure numbers from e164 field

Regarding your second point validation local phone numbers is not supported in this package, and this is good as omitting country code might result in overlapping phone numbers. Accounts also required to register phone number with country code too.
What alternative solutions did you explore? (Optional)

@apt-get-sahil Thanks for the proposal. Your solution is only good to check if the input looks like a number or not but it does not validate it e.g. +11111111 should not pass.

@alitoshmatov Thanks for the proposal. I think your suggested solution is not complete for not taking into consideration local numbers.

@Prince-Mendiratta Thanks for the update. I think your solution is too complex and contains repeated and redundant logic. For instance adding country code to phone numbers can be done using appendCountryCode. Also I don't see why you are making changes to the header message, if the number is not valid it should not be shown as an option to be selected in the first place.

Using awesome-phonenumber I think we can achieve the wanted results with a single line of code.

@Prince-Mendiratta Thanks for the update. Now it's much simpler, but lets only show valid numbers.
-        && ((Str.isValidEmail(login) && !Str.isDomainEmail(login)) || Str.isValidPhone(login))
+        && ((Str.isValidEmail(login) && !Str.isDomainEmail(login)) || parsePhoneNumber(login).valid)

This should be enough but let's discuss further in the PR.
:ribbon: :eyes: :ribbon: C+ reviewed
cc @stitesExpensify

@Prince-Mendiratta We may update the validation on header message too (switch from  Str.isValidPhone to parsePhoneNumber)
I have raised a Slack thread here https://expensify.slack.com/archives/C01GTK53T8Q/p1681596380231529
cc @stitesExpensify

@rushatgabhane It's hard to say yes XD Can you please provide more context why this should be put on hold?

If we are still going to use awesome-phonenumber then there is no reason to hold as the lib does not care about formatting.

I think actually the PRs can go in either order. https://github.com/Expensify/App/pull/16804 uses awesome-phonenumber for displaying phone numbers. Whereas this issue will use awesome-phonenumber for validating them. So I think we can go forward in parallel.

@rushatgabhane For consistency I think that would make sense.

making sure @s77rt and @rushatgabhane addressed this comment here - https://github.com/Expensify/App/issues/17461#issuecomment-1513206227
i think so! but wanted to make sure https://github.com/Expensify/App/pull/17578#issuecomment-1515909865

Not sure why two BZ got assigned to this issue. @maddylewis you've been involved more actively to date, so I'll drop off. 👍

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.8-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17578

If no regressions arise, payment will be issued on 2023-05-09. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@s77rt] Determine if we should create a regression test for this bug.
[ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: Not really a bug, this is a feature request.
The offending PR has been commented on: n/a
A discussion in #expensify-bugs has been started: I don't think this applies here
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Open App
Click on the Search icon
Type an invalid phone number e.g. +444
Verify the Please enter a valid phone number... message is shown below the input
Verify no results are returned
Type a valid phone number e.g. +1<PHONE_NUMBER>
Verify no message is shown below the input
Verify the phone number / user is found

⚠ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Checklist provided already https://github.com/Expensify/App/issues/17461#issuecomment-1532197564

what is going on with this issue!? let me hide duplicate comments and ill get the BZ checklist completed today.

@maddylewis We had two PRs. So (I can't believe I'm saying this) but this is actually not Melvin's fault.

@Prince-Mendiratta - this is amazing!

Payouts

Reporting bonus: N/A (internal)
Contributor: $1000 for 1st PR + $1000 for 2nd PR = $2000 total
C+: $1000 for 1st PR + $1000 for 2nd PR = $2000 total

Offers sent!

@maddylewis Payment is only due for one PR (both are basically the same)

paid!


Create a command to show versions in registry

Like typings search <query>, but to list known versions.

Well, I would like to help on this, but I need your guidance.
My current status is https://github.com/goenning/typings/commit/87b184fe25fa070c6a51271e0816dba006c60105
It implements a working command info with following syntax

typings info npm debug
typings info dt node

Only exact source+package name matches will work.
Other possible syntax could be:

typings info npm:debug
typings info dt:debug

typings info debug
typings info debug --ambient
(this one is the most similar to the other commands)

Is this somewhere near what you are thinking about?

There's a CLI flag called --source used in places like install. What about two commands, one for the info and another for versions? Or a flag?
So, in long:
typings info debug --source npm
typings info debug --source npm --versions
typings info node --ambient --versions

Thoughts?
Another thought on this. Using this scheme, typings info debug could give info on the currently installed version (once that's persisted, that's another task).

Well, I don't think versions command would be used that much to get it's own command, so yeah, a flag would do it just fine.
But what would info command do at all?
typings info debug

Shows if debug is installed and what is the version

typings info debug --versions
The same as previous, plus:

Shows all available debug versions

typings info

Shows all installed typings and it's version

It would also be good to have a way of locally comparing installed typings version with npm/bower package version and showing if it is consistent or not. It could also suggest an update when there is a typing version that matches the package's.

@goenning Thanks for the thoughts. The main issue here is that Typings technically types different sources. However, if we land the idea of a default source (https://github.com/typings/typings/issues/126#issuecomment-176500160) then this command makes much more sense and is more consistent. My only concern before was that debug could technically exist in a bunch of different places, so I'm likely a default and explicit sources more. Thoughts? So...
typings info debug # Hits API, shows project info and versions (maybe versions - could still be a flag)
typings info debug --source bower # Overrides search of NPM sources for bower's debug

# There's no more local version of this command. That may be a different command later down the road.


does polyG get trimmed only if it's at the 3' end of read?

First thanks for writing such a wonderful tool!
Quick question, if there is a stretch of polyG in the middle of reads, does it get trimmed? Or only polyG at the 3' (meaning all bases after the polyG are Gs) of reads get trimmed?
Thanks!
Dan

Forgot to search among closed issues. Here's the answer #138


Dual Boot?

Is it possible to use this with Arch/Windows Dual Boot?

Yes, when you choose booting with Arch.


[Feature Request]: Listing Section Design

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Hi @Soujanya2004
Issue: Listing Section Design Improvements
Description:
The current design of the listing section could be optimized for better usability, aesthetics, and consistency with the rest of the application. This improvement aims to enhance the visual appeal and user experience of the section.
Problems Identified:

Inconsistent Spacing: The spacing between list items is inconsistent, making the section look cluttered and hard to read.
Typography Issues: The font size and weight could be adjusted for better readability and hierarchy. Currently, all text appears too similar, reducing the visual flow.
Alignment Problems: Some elements within list items are not aligned correctly, creating a disorganized appearance.
Lack of Visual Feedback: There's minimal interactive feedback (such as hover effects) on list items, which reduces the interactive experience.
Color Scheme and Contrast: The color scheme could be improved to ensure better contrast and accessibility, particularly for text and background colors.

Proposed Enhancements:

Consistent Spacing: Apply uniform padding and margins to create a balanced layout across the list items.
Typography Adjustments: Adjust font size, weight, and color to establish a clearer visual hierarchy (e.g., larger, bolder headings for list item titles).
Alignment: Ensure all elements in each list item are properly aligned for a clean, organized look.
Interactive Feedback: Add hover effects to list items to indicate interactivity and improve user experience.
Color and Contrast: Refine the color scheme to enhance readability and accessibility, following WCAG contrast guidelines.

Additional Notes:
Please reference the design guidelines or existing styles within the project for consistency. A prototype or mockup demonstrating the intended design changes would be helpful.
Use Case
Use Case: Improved Listing Section Design
The listing section is a crucial part of user interfaces that displays information or content in a structured way. By refining the design, this section can serve a wide range of use cases, such as displaying items in a catalog, showing a list of articles, or presenting user profiles in a social feed.
Key Use Cases Include:

Product Listings: In an e-commerce site, clear and attractive product listings help users quickly scan and choose items.
Content Feeds: Blogs, news sites, or social platforms use listing sections to display articles or posts, making it easy for users to find content of interest.
User Directories: Applications like social networks or employee management platforms benefit from well-designed listings that let users browse profiles effortlessly.
Task Management: In productivity apps, a well-organized listing design helps users keep track of tasks, deadlines, and priorities.

Benefits
Benefits of a Refined Listing Section Design
Improving the listing section’s design provides both user experience and business benefits:

Enhanced Usability: Clearer spacing, consistent alignment, and visual hierarchy make information easier to scan and understand, improving user engagement.

Increased Accessibility: By following color contrast guidelines and improving text readability, the design becomes more accessible to users with visual impairments, broadening the audience.

Stronger User Engagement: Adding hover effects and other visual cues can make the interface feel more interactive, keeping users engaged as they browse through content.

Higher Conversion Rates: In scenarios like e-commerce or subscription-based sites, well-designed listings make products or options more appealing, which can lead to higher click-through and conversion rates.

Consistent Brand Perception: A well-designed listing section reflects professionalism and attention to detail, reinforcing a consistent and appealing brand image.

By focusing on these improvements, the listing section will better meet user needs, contribute to overall product usability, and support business objectives.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Hi @Soujanya2004 , please check this
Dark mode:

Light Mode:

This is the mobile view :

@dev129 in dark mode it's supposed to be dark, here cards are displayed with white bg
other contributor has already raised pr so i will close this

Wait a minute @Soujanya2004 , you could have tell me about that, i mean if you wanted edits atleast I must vetold about that , you dont ha e the right to change kike that

@dev129 see its all about who does job faster
one of the contributor had finished the job already , what will be the use if i merge another pr which does the same task

@dev129 its up to the project admin to choose the feature that has to be added to their website

Thanks alot @Soujanya2004 here is a much more improvised view
Light View:

Dark View:

@dev129 please pull code before raising pr because there is like feature added and many other improvements

rest all is ok for me

I have updated it and the only chang i see is in the landing page

rest i have not much changes , but a serious concern is that your gitignore file is not working

@dev129 about the gitignore i cant do anything ryt?

I have updated it and the only chang i see is in the landing page  rest i have not much changes , but a serious concern is that your gitignore file is not working

And that is what I am thinking , why ? and what will we do if someone directly perform commit operation ?

@dev129 not many are facing that issue actually

Yeah but problems don't inform when coming.

did u check the updated listing??

in the app.js file because that i updated by me already.

fine then raise pr


CI for Node

Title change for Node

diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
new file mode 100644
index 0000000..7fc1370
--- /dev/null
+++ b/.github/workflows/npm-publish.yml
@@ -0,0 +1,47 @@
+# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
+# For more information see: https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages

+name: CI for Node
+
+on:

release:
types: [created]

+jobs:

build:
runs-on: ubuntu-latest
steps:

 - uses: actions/checkout@v2

 - uses: actions/setup-node@v1

   with:

     node-version: 12

 - run: npm ci

 - run: npm test

publish-npm:
needs: build
runs-on: ubuntu-latest
steps:

 - uses: actions/checkout@v2

 - uses: actions/setup-node@v1

   with:

     node-version: 12

     registry-url: https://registry.npmjs.org/

 - run: npm ci

 - run: npm publish

   env:

     NODE_AUTH_TOKEN: ${{secrets.npm_token}}

publish-gpr:
needs: build
runs-on: ubuntu-latest
steps:

 - uses: actions/checkout@v2

 - uses: actions/setup-node@v1

   with:

     node-version: 12

     registry-url: https://npm.pkg.github.com/

 - run: npm ci

 - run: npm publish

   env:

     NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}


Got fake certificate on Azure

I am following https://blogs.technet.microsoft.com/livedevopsinjapan/2017/02/28/configure-nginx-ingress-controller-for-tls-termination-on-kubernetes-on-azure-2/ to make TLS termination works on Azure. After everything is setup, I can access the server successfully. However, I always got the fake certificate instead of my own certificate.
It seems the certificate was loaded properly
$ kubectl -n kube-system logs nginx-ingress-controller-2781903634-hf1xv
[dumb-init] Unable to detach from controlling tty (errno=25 Inappropriate ioctl for device).
[dumb-init] Child spawned with PID 6.
[dumb-init] Unable to attach to controlling tty (errno=25 Inappropriate ioctl for device).
[dumb-init] setsid complete.
I0730 20:15:38.652971       6 launch.go:105] &{NGINX 0.9.0-beta.11 git-a3131c5 https://github.com/kubernetes/ingress}
I0730 20:15:38.653062       6 launch.go:108] Watching for ingress class: nginx
I0730 20:15:38.653322       6 launch.go:262] Creating API server client for https://<IP_ADDRESS>:443
I0730 20:15:38.654313       6 nginx.go:182] starting NGINX process...
I0730 20:15:38.705427       6 launch.go:124] validated kube-system/default-http-backend as the default backend
I0730 20:15:38.753788       6 controller.go:1190] starting Ingress controller
I0730 20:15:38.756999       6 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"nginx-test", UID:"b04eaf16-7558-11e7-8ff6-000d3ad09dba", APIVersion:"extensions", ResourceVersion:"20007", FieldPath:""}): type: 'Normal' reason: 'CREATE' Ingress default/nginx-test
I0730 20:15:38.854114       6 leaderelection.go:203] attempting to acquire leader lease...
I0730 20:15:38.855431       6 backend_ssl.go:64] adding secret default/tls-secret to the local store
I0730 20:15:39.190589       6 controller.go:428] backend reload required
I0730 20:15:39.190690       6 metrics.go:34] changing prometheus collector from  to default
I0730 20:15:39.238664       6 controller.go:438] ingress backend successfully reloaded...
I0730 20:16:14.095774       6 leaderelection.go:213] successfully acquired lease kube-system/ingress-controller-leader-nginx
I0730 20:16:38.886648       6 status.go:310] updating Ingress default/nginx-test status to [{<IP_ADDRESS> }]
I0730 20:16:38.915168       6 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"nginx-test", UID:"b04eaf16-7558-11e7-8ff6-000d3ad09dba", APIVersion:"extensions", ResourceVersion:"20334", FieldPath:""}): type: 'Normal' reason: 'UPDATE' Ingress default/nginx-test
<IP_ADDRESS> - [<IP_ADDRESS>] - - [30/Jul/2017:20:21:58 +0000] "GET / HTTP/2.0" 200 1001 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36" 270 0.004 [default-http-svc-80] <IP_ADDRESS>:8080 1252 0.004 200
<IP_ADDRESS> - [<IP_ADDRESS>] - - [30/Jul/2017:20:22:01 +0000] "GET /favicon.ico HTTP/2.0" 200 971 "https://<IP_ADDRESS>/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36" 67 0.000 [default-http-svc-80] <IP_ADDRESS>:8080 1244 0.000 200

I tried the two steps below but the issue still persists and got similar logs.

Restarted the nginx-ingress-controller pod
Used quay.io/aledbf/nginx-ingress-controller:0.171 to replace gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.11

Any suggestion is appreciated. Thank you in advance.

I'm encountering the same problem, but it's universal regardless of what certificate I attempt to install through the secret.  I was attempting to get a certificate from a CA functioning and it was not verifying.  I eventually found that the controller was serving up the Kubernetes Ingress Controller Fake Certificate.
openssl s_client -showcerts -connect <redacted>:443 </dev/null
CONNECTED(00000003)
depth=0 O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
verify error:num=21:unable to verify the first certificate
verify return:1
---
Certificate chain
 0 s:/O=Acme Co/CN=Kubernetes Ingress Controller Fake Certificate
   i:/O=Acme Co/CN=Kubernetes Ingress Controller Fake Certificate
-----BEGIN CERTIFICATE-----
MIIDcDCCAligAwIBAgIRAIDt5DuCRLfHy35tpVYxpywwDQYJKoZIhvcNAQELBQAw
SzEQMA4GA1UEChMHQWNtZSBDbzE3MDUGA1UEAxMuS3ViZXJuZXRlcyBJbmdyZXNz
IENvbnRyb2xsZXIgRmFrZSBDZXJ0aWZpY2F0ZTAeFw0xNzA4MTYxMzIzMThaFw0x
ODA4MTYxMzIzMThaMEsxEDAOBgNVBAoTB0FjbWUgQ28xNzA1BgNVBAMTLkt1YmVy
bmV0ZXMgSW5ncmVzcyBDb250cm9sbGVyIEZha2UgQ2VydGlmaWNhdGUwggEiMA0G
CSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDFQROFitnJSePmaJ2POrehCWn6nzaA
gi12RXHVKtWGxqlf6vueHelLV7iozJ2nN0qeZXUUZHQJs5NknHw0CDYgDHTA4TvQ
mdjypuRsBSPIAPZPWUxqF5ZGLzVrABatcjfBBS1mWiccZ+N4DgpWEgaghKXNUlEe
awu8kePNgN8KtZDWsKtr7SlVXFZwb3SuPrYiU3oSf5PeKbW3hCDNyssE+2lUrqB2
KPN5fhsbwukh7dM3mjHh3XBotzEcXFsSmg94veQyfBH5phVF1WGFXyiOeoxXn2/M
zWqyOxqEffb2WxX0Fr5riz6smafAgggJHhV3uipLie7YqBOMzhY9EDT5AgMBAAGj
TzBNMA4GA1UdDwEB/wQEAwIFoDATBgNVHSUEDDAKBggrBgEFBQcDATAMBgNVHRMB
Af8EAjAAMBgGA1UdEQQRMA+CDWluZ3Jlc3MubG9jYWwwDQYJKoZIhvcNAQELBQAD
ggEBAIX+LNWO8X18sOX9Hc6Lyw/q3rJO5ydxRP8fMuFvm5PC5BToevdH0ZN5BxOT
q75zcJ0Xv3JIvv9BsAIXCNhhO0sqlN/6SLqx+MMtC5IdfwyxmZNloyaL5dMgT4Mv
sMxoSpAHgmc8oeoN/V3C/SGCn8vh7GJeSnjnnBr+gXV7PCHfZnnBAsqvI5wv8YUU
gbzXiA3mu5n9xk5k1xPLc2xC6gkLUflqt8hLGlRjCc5UtEiGgn8dMvrp3OEpiVyB
ww9GJOAlQZb1ra8p/vWOF4adzCnLYRGz5WEWAd5Y9JOkta/61yv179zC3ojJ2MRw
Tktp3Nbvg7HlaFj93xEE9dcxzCA=
-----END CERTIFICATE-----
---
Server certificate
subject=/O=Acme Co/CN=Kubernetes Ingress Controller Fake Certificate
issuer=/O=Acme Co/CN=Kubernetes Ingress Controller Fake Certificate
---
No client certificate CA names sent
Peer signing digest: SHA512
Server Temp Key: ECDH, P-384, 384 bits
---
SSL handshake has read 1591 bytes and written 463 bytes
---
New, TLSv1/SSLv3, Cipher is ECDHE-RSA-AES128-GCM-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-AES128-GCM-SHA256
    Session-ID: 32BCD0057D5D2AA4F8E265DDE546E50CCBE8E1DBFA33BBB07568E1117A394026
    Session-ID-ctx:
    Master-Key: 415B9F329663C3E04001CF020A399572100D1BF6A40D3B7C630592F72C5478F8D8B8BE7AE49303CD3FD1E95094ADA2AC
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    TLS session ticket lifetime hint: 600 (seconds)
    TLS session ticket:
    0000 - dc de ea 16 e1 c3 22 9a-48 3a 0e 46 dc 9f 20 10   ......".H:.F.. .
    0010 - c8 c7 51 af 5c 2e f9 f6-16 2e 00 c7 17 ef a0 f3   ..Q.\...........
    0020 - 34 e2 44 fb 18 36 2d 2d-45 3c 9b b0 df 56 9a 85   4.D..6--E<...V..
    0030 - 8e 6d ec 53 8a 92 11 59-23 93 96 dd a4 c4 e2 5a   .m.S...Y#......Z
    0040 - d2 de 93 af ba 4d af 57-21 18 27 08 aa a8 96 8f   .....M.W!.'.....
    0050 - e8 18 23 f8 3d 77 84 a8-aa 72 5c 7b e8 86 15 d9   ..#.=w...r\{....
    0060 - 90 1d 88 95 5e 9f 40 45-9f db ea a9 85 8f e3 17<EMAIL_ADDRESS>    0070 - 1f 39 a5 6f 60 e0 b1 c4-f1 1f b3 74 6b e6 ee 65   .9.o`......tk..e
    0080 - b6 8e 16 df 0c 79 86 ab-65 52 3e 3f a2 02 d0 16   .....y..eR>?....
    0090 - 09 14 93 41 6c f8 33 0b-7c 61 d2 83 43 06 38 5d   ...Al.3.|a..C.8]
    00a0 - ab 3b ed 2f e7 d8 c1 2e-42 c5 71 dc 8c 21 8f 0c   .;./....B.q..!..

    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 21 (unable to verify the first certificate)
---
DONE

At the time, I had assumed there was something wrong with my procedure installing the certificate, so I resorted to following the tutorial mentioned by @xuehung to see if I could get that working.  I ended up encountering the same fake certificate problem there as well.  I subsequently tried using the controller from quay.io/aledbf/nginx-ingress-controller:0.180 but the same error persisted.
I don't think this is an Azure specific issue since the certificate is being served up from the Ingress controller, but I guess I wouldn't rule it out.  Either way, as far as I can see, it's either not currently possible to TLS terminate with the current versions of the nginx ingress controller or there is something lacking in the instructions I am utilizing.

@shawnmcknight please update the image to quay.io/aledbf/nginx-ingress-controller:0.180

@shawnmcknight how are you running the controller?

@shawnmcknight let me start a cluster in azure and follow your steps.
What k8s version are you using? How did you installed the cluster? Is RBAC enabled?

@aledbf I'm deploying in Azure using the latest acs-engine and following the steps laid out at https://github.com/Azure/acs-engine/blob/master/docs/kubernetes/deploy.md.
The engine appears to deploy with k8s 1.6.6 using this method.
I'm not sure if RBAC is enabled and I didn't see how to check on cursory Google search.  I did not personally do anything to enable or disable is, so whatever the defaults or whatever acs-engine does on deployment would be how it currently is.
Thanks!

I'm admittedly tinkering with things that I'm a real novice at, but from what I can see, the nginx.conf in the running pod doesn't appear to be referencing the secret that I created.
I entered bash in my running controller pod by doing kubectl exec nginx-ingress-controller-170554507-6hrd0 -n kube-system -it bash and inspected /etc/nginx/nginx.conf which appears to have been configured to route traffic to the http-svc pod which leads me to believe this is the underpinnings of how this controller works.  However, the ssl_certificate and ssl_certificate_key directives are pointing to the default-fake-certificate and not the secret that the ingress indicates it should:
    upstream default-http-svc-80 {
        # Load balance algorithm; empty for round robin, which is the default
        least_conn;
        server <IP_ADDRESS>:8080 max_fails=0 fail_timeout=0;
    }
    server {
        server_name _;
        listen 80 default_server reuseport backlog=511;
        listen [::]:80 default_server reuseport backlog=511;
        set $proxy_upstream_name "-";

        listen 442 proxy_protocol default_server reuseport backlog=511 ssl http2;
        listen [::]:442 proxy_protocol  default_server reuseport backlog=511 ssl http2;
        # PEM sha: 0c75b519f233303693b25c580bddde76465e505f
        ssl_certificate                         /ingress-controller/ssl/default-fake-certificate.pem;
        ssl_certificate_key                     /ingress-controller/ssl/default-fake-certificate.pem;

        more_set_headers                        "Strict-Transport-Security: max-age=15724800; includeSubDomains;";
        location / {
            set $proxy_upstream_name "default-http-svc-80";
...

In /ingress-controller/ssl I can see the default-tls-secret.pem file and upon inspection I see that both my certificate and private key from the secret are present inside the file.  Therefore the controller seems to be loading the certificate and key properly, but it just doesn't seem to be directing nginx.conf to use it.
Finally, running kubectl describe ing nginx-test to make sure the ingress is configured to use the appropriate secret elicits:
NAME         HOSTS     ADDRESS      PORTS     AGE
nginx-test   *         <IP_ADDRESS>   80, 443   19h

C:\Users\srm\Ops Stuff>kubectl describe ing nginx-test
Name:                   nginx-test
Namespace:              default
Address:                <IP_ADDRESS>
Default backend:        default-http-backend:80 (<IP_ADDRESS>:8080)
TLS:
  tls-secret terminates
Rules:
  Host  Path    Backends
  ----  ----    --------
  *
                http-svc:80 (<none>)
Annotations:
Events: <none>

So to the best of my knowledge the ingress is configured to use the appropriate secret and the secret is getting loaded as a .pem file, but the nginx.conf isn't getting updated to utilize that .pem file.
As I mentioned earlier, I'm a novice at this stuff, but hopefully that provides some meaningful insight.  Thanks again!

@shawnmcknight please post the output of  kubectl logs nginx-ingress-controller-170554507-6hrd0 -n kube-system and the ingress nginx-test

please post the output of kubectl logs nginx-ingress-controller-170554507-6hrd0 -n kube-system

kubectl logs nginx-ingress-controller-170554507-6hrd0 -n kube-system
I0816 13:23:18.023146       6 launch.go:108] &{NGINX 0.9.0-beta.11 git-a2217ab1 https://github.com/aledbf/ingress}
I0816 13:23:18.023172       6 launch.go:111] Watching for ingress class: nginx
I0816 13:23:18.023337       6 launch.go:270] Creating API server client for https://<IP_ADDRESS>:443
I0816 13:23:18.024511       6 nginx.go:205] starting NGINX process...
I0816 13:23:18.094356       6 launch.go:127] validated kube-system/default-http-backend as the default backend
I0816 13:23:18.112276       6 controller.go:1256] starting Ingress controller
I0816 13:23:18.114451       6 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"nginx-test", UID:"2a7fcb47-8204-11e7-88e9-000d3a1a2569", APIVersion:"extensions", ResourceVersion:"81234", FieldPath:""}): type: 'Normal' reason: 'CREATE' Ingress default/nginx-test
I0816 13:23:18.213235       6 backend_ssl.go:58] adding secret default/tls-secret to the local store
I0816 13:23:18.213398       6 leaderelection.go:174] attempting to acquire leader lease...
I0816 13:23:18.351402       6 controller.go:423] backend reload required
I0816 13:23:18.351920       6 metrics.go:34] changing prometheus collector from  to default
I0816 13:23:18.405449       6 controller.go:432] ingress backend successfully reloaded...
I0816 13:23:53.342324       6 leaderelection.go:184] successfully acquired lease kube-system/ingress-controller-leader-nginx
I0816 13:24:18.237719       6 status.go:347] updating Ingress default/nginx-test status to [{<IP_ADDRESS> }]
I0816 13:24:18.261281       6 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"nginx-test", UID:"2a7fcb47-8204-11e7-88e9-000d3a1a2569", APIVersion:"extensions", ResourceVersion:"81688", FieldPath:""}): type: 'Normal' reason: 'UPDATE' Ingress default/nginx-test
<IP_ADDRESS> - [<IP_ADDRESS>] - - [16/Aug/2017:13:34:31 +0000] "GET / HTTP/1.1" 200 655 "-" "curl/7.47.0" 76 0.001 [default-http-svc-80] <IP_ADDRESS>:8080 655 0.001 200
<IP_ADDRESS> - [<IP_ADDRESS>] - - [16/Aug/2017:13:35:49 +0000] "GET / HTTP/1.1" 200 655 "-" "curl/7.47.0" 76 0.000 [default-http-svc-80] <IP_ADDRESS>:8080 655 0.000 200
<IP_ADDRESS> - [<IP_ADDRESS>] - - [16/Aug/2017:17:28:55 +0000] "GET / HTTP/1.1" 301 185 "-" "curl/7.47.0" 74 0.000 [default-http-svc-80] - - - -
<IP_ADDRESS> - [<IP_ADDRESS>] - - [16/Aug/2017:17:29:03 +0000] "GET / HTTP/1.1" 200 649 "-" "curl/7.47.0" 74 0.000 [default-http-svc-80] <IP_ADDRESS>:8080 649 0.000 200

and the ingress nginx-test

I'm not sure what you're asking for here as I'm unable to get kubectl to present logs for the ingress itself.  The ingress' yaml definition is:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: nginx-test
  annotations:
    kubernetes.io/ingress.class: "nginx"
spec:
  tls:
  # This assumes tls-secret exists.
  - secretName: tls-secret
  rules:
  - http:
      paths:
      - backend:
          # This assumes http-svc exists and routes to healthy endpoints.
          serviceName: http-svc
          servicePort: 80

Let me know if you're looking for something other than that.  Thank you again.

@shawnmcknight ok, I see the isue. You need to specify the host in the tls section. Without that the controller does not know which host you are configuring.

I tried two different ingress configurations with ultimately similar results.  The first I tried specified a host in the tls configuration without any corresponding rules:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: nginx-test
  annotations:
    kubernetes.io/ingress.class: "nginx"
spec:
  tls:
  # This assumes tls-secret exists.
  - hosts:
    - foo.bar.com
    secretName: tls-secret
  rules:
  - http:
      paths:
      - backend:
          # This assumes http-svc exists and routes to healthy endpoints.
          serviceName: http-svc
          servicePort: 80

When I looked at nginx.conf it was not referencing the passed in cert but I inspected the cert being returned from foo.bar.com at the specified IP to be certain:
$ echo | openssl s_client -showcerts -servername foo.bar.com -connect <ip redacted>:443 2>/dev/null | openssl x509 -inform pem -noout -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            80:ed:e4:3b:82:44:b7:c7:cb:7e:6d:a5:56:31:a7:2c
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: O=Acme Co, CN=Kubernetes Ingress Controller Fake Certificate
...

It still indicated the fake certificate.  I then tried another ingress with a rule being applied to foo.bar.com:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: nginx-test
  annotations:
    kubernetes.io/ingress.class: "nginx"
spec:
  tls:
  # This assumes tls-secret exists.
  - hosts:
    - foo.bar.com
    secretName: tls-secret
  rules:
  - host: foo.bar.com
    http:
      paths:
      - backend:
          # This assumes http-svc exists and routes to healthy endpoints.
          serviceName: http-svc
          servicePort: 80

Using this ingress configuration keeps the original problem, but creates a new one - that is, foo.bar.com is only listening on port 80 and the ssl certificate still isn't being specified:
...
    server {
        server_name foo.bar.com;
        listen 80;
        listen [::]:80;
        set $proxy_upstream_name "-";
        location / {
            set $proxy_upstream_name "default-http-svc-80";

            port_in_redirect off;

            client_max_body_size                    "1m";

            proxy_set_header Host                   $best_http_host;

            # Pass the extracted client certificate to the backend

            # Allow websocket connections
            proxy_set_header                        Upgrade           $http_upgrade;
            proxy_set_header                        Connection        $connection_upgrade;

            proxy_set_header X-Real-IP              $the_real_ip;
            proxy_set_header X-Forwarded-For        $the_real_ip;
            proxy_set_header X-Forwarded-Host       $best_http_host;
            proxy_set_header X-Forwarded-Port       $pass_port;
            proxy_set_header X-Forwarded-Proto      $pass_access_scheme;
            proxy_set_header X-Original-URI         $request_uri;
            proxy_set_header X-Scheme               $pass_access_scheme;

            # mitigate HTTPoxy Vulnerability
            # https://www.nginx.com/blog/mitigating-the-httpoxy-vulnerability-with-nginx/
            proxy_set_header Proxy                  "";

            # Custom headers to proxied server

            proxy_connect_timeout                   5s;
            proxy_send_timeout                      60s;
            proxy_read_timeout                      60s;

            proxy_redirect                          off;
            proxy_buffering                         off;
            proxy_buffer_size                       "4k";
            proxy_buffers                           4 "4k";

            proxy_http_version                      1.1;

            proxy_cookie_domain                     off;
            proxy_cookie_path                       off;

            # In case of errors try the next upstream server before returning an error
            proxy_next_upstream                     error timeout invalid_header http_502 http_503 http_504;

            proxy_pass http://default-http-svc-80;
        }

    }
...

As a result, any https requests spoofing foo.bar.com ended up going to the default backend rather than the configured service.
So neither ingress configuration assigned the nginx.conf to use the specified tls-secret and the second configuration had the secondary side effect of disallowing https traffic to my backend service.  Is there something else I should be doing in the ingress configuration?

@aledbf OK, so after your last comment, I tried a variety of things and it would appear from what I can see that the example at examples/tls-termination/nginx/nginx-tls-ingress.yaml may be out-of-date or just wrong as it does not indicate the need for a host specification in the tls configuration.
I was able to get the configuration to work by using a certificate that had the specified host, putting the host in the tls configuration, and having that same host be present in the rules array.  When all three of these were done then the nginx.conf ended up with a server designation that properly routed.
If my understanding is correct and that all of those are necessary in order to get the proper certificate then I think the answer to the OP's (@xuehung) issue is that the tutorial he is using models tls but will not use the generated certificate.  Additionally, the example in this repository might need to be corrected and/or updated.  That may possibly close this issue.
As far as my issue is concerned, I've got everything working now and thank you for your assistance!

This are the required steps:
This assumes the command acs-engine deploy returns without issues.
Check k8s version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.0", GitCommit:"fff5156092b56e6bd60fff75aad4dc9de6b6ef37", GitTreeState:"clean", BuildDate:"2017-03-28T16:36:33Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.6", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"clean", BuildDate:"2017-06-16T18:21:54Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}

Create the nginx ingress controller:
$ kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/examples/deployment/nginx/nginx-ingress-controller.yaml
deployment "nginx-ingress-controller" created
$ kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/examples/deployment/nginx/default-backend.yaml
deployment "default-http-backend" created
service "default-http-backend" created
$ kubectl get deployment -n kube-system
NAME                       DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
default-http-backend       1         1         1            1           4m
heapster                   1         1         1            1           7m
kubernetes-dashboard       1         1         1            1           7m
nginx-ingress-controller   1         1         1            1           4m
tiller-deploy              1         1         1            1           7m

Create service:
$ echo "
apiVersion: v1
kind: Service
metadata:
  name: nginx-ingress-controller
  namespace: kube-system
spec:
  type: LoadBalancer
  ports:
  - name: http
    port: 80
    targetPort: 80
    protocol: TCP
  - name: https
    port: 443
    targetPort: 443
    protocol: TCP
  selector:
    k8s-app: nginx-ingress-controller
" | kubectl create -f -
service "nginx-ingress-controller" created

Create SSL certificate for host foo.bar.com:
$ openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout tls.key -out tls.crt -subj "/CN=foo.bar.com/O=nginxsvc"
Generating a 2048 bit RSA private key
.......+++
...+++
writing new private key to 'tls.key'
-----
$  kubectl create secret tls tls-secret --key tls.key --cert tls.crt
secret "tls-secret" created

Create echo headers service:
$ kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/examples/http-svc.yaml
service "http-svc" created
replicationcontroller "http-svc" created

Get the public IP:
$ kubectl get svc -n kube-system
NAME                           CLUSTER-IP     EXTERNAL-IP      PORT(S)                      AGE
default-http-backend       <IP_ADDRESS>     <none>           80/TCP                       8m
heapster                   <IP_ADDRESS>      <none>           80/TCP                       11m
kube-dns                   <IP_ADDRESS>      <none>           53/UDP,53/TCP                11m
kubernetes-dashboard       <IP_ADDRESS>    <nodes>          80:30463/TCP                 11m
nginx-ingress-controller   <IP_ADDRESS>   <IP_ADDRESS>   80:30694/TCP,443:30898/TCP   3m
tiller-deploy              <IP_ADDRESS>    <none>           44134/TCP                    11m
```to get
**Create the ingress rule:**
```console
echo "
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: nginx-test
  annotations:
    kubernetes.io/ingress.class: nginx
spec:
  tls:
  - hosts:
    - foo.bar.com
    secretName: tls-secret
  rules:
  - http:
      paths:
      - backend:
          serviceName: http-svc
          servicePort: 80
" | kubectl create -f -

Test the ingress:
$ curl -v http://<IP_ADDRESS>
$ curl -v http://<IP_ADDRESS>
* Rebuilt URL to: http://<IP_ADDRESS>/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> GET / HTTP/1.1
> Host: <IP_ADDRESS>
> User-Agent: curl/7.52.1
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Server: nginx/1.13.3
< Date: Wed, 16 Aug 2017 20:06:45 GMT
< Content-Type: text/plain; charset=utf-8
< Content-Length: 21
< Connection: keep-alive
< Strict-Transport-Security: max-age=15724800; includeSubDomains;
<
* Curl_http_done: called premature == 0
* Connection #0 to host <IP_ADDRESS> left intact

Test if a HTTPS request returns the certificate:
$ curl -v -k --resolve foo.bar.com:443:<IP_ADDRESS> https://foo.bar.com
* Added foo.bar.com:443:<IP_ADDRESS> to DNS cache
* Rebuilt URL to: https://foo.bar.com/
* Hostname foo.bar.com was found in DNS cache
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to foo.bar.com (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: CN=foo.bar.com; O=nginxsvc
*  start date: Aug 16 20:00:07 2017 GMT
*  expire date: Aug 16 20:00:07 2018 GMT
*  issuer: CN=foo.bar.com; O=nginxsvc
*  SSL certificate verify result: self signed certificate (18), continuing anyway.
> GET / HTTP/1.1
> Host: foo.bar.com
> User-Agent: curl/7.52.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Server: nginx/1.13.3
< Date: Wed, 16 Aug 2017 20:10:46 GMT
< Content-Type: text/plain
< Transfer-Encoding: chunked
< Connection: keep-alive
< Strict-Transport-Security: max-age=15724800; includeSubDomains;
<

Hostname: http-svc-qsfgt

Pod Information:
	node name:	k8s-agentpool1-16034652-1
	pod name:	http-svc-qsfgt
	pod namespace:	default
	pod IP:	<IP_ADDRESS>

Server values:
	server_version=nginx: 1.13.3 - lua: 10008

Request Information:
	client_address=<IP_ADDRESS>
	method=GET
	real path=/
	query=
	request_version=1.1
	request_uri=http://foo.bar.com:8080/

Request Headers:
	accept=*/*
	connection=close
	host=foo.bar.com
	user-agent=curl/7.52.1
	x-forwarded-for=<IP_ADDRESS>
	x-forwarded-host=foo.bar.com
	x-forwarded-port=443
	x-forwarded-proto=https
	x-original-uri=/
	x-real-ip=<IP_ADDRESS>
	x-scheme=https

Request Body:
	-no body in request-

* Curl_http_done: called premature == 0
* Connection #0 to host foo.bar.com left intact

Closing. This is working as expected.

@xuehung please check the steps

@xuehung please reopen if you still have issues after following the steps

If my understanding is correct and that all of those are necessary in order to get the proper certificate then I think the answer to the OP's (@xuehung) issue is that the tutorial he is using models tls but will not use the generated certificate.

I think the tutorial never checked the output of the https request

Hi @aledbf, I've repeatedly run your above instructions, substituting my CN cert for the self-signed foo.bar.com and still end up with the O=Acme Co; CN=Kubernetes Ingress Controller Fake Certificate on the nginx ingress controller.  Is there by chance a bug in reading the cert from a secret?

@jskulavik please post the ingress rule you are using

@aledbf - Here's my rule.  The svc, secret, and CN are working under proper TLS outside of k8s ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: my-tls-ing
annotations:
kubernetes.io/ingress.class: nginx
spec:
rules:

http:
paths:

backend:
serviceName: my-https-svc
servicePort: 80
path: /
tls:

hosts:

my.cn.domain

secretName: my-cn-secret

@jskulavik you're not using the correct syntax. Include the host option in the rules section and use correct syntax in the tls section, like so:
spec:
  rules:
  - host: my.cn.domain
    http:
      paths:
      - backend:
          serviceName: my-https-svc
          servicePort: 80
        path: /
  tls:
    - hosts:
      - my.cn.domain
      secretName: my-cn-secret

There's a fine manual as well

Thank you @pieterlange!  I'm in love with that fine manual indeed, but apparently I glossed over hosts: in the tls node.

I'm still missing something.  I've corrected my ingress syntax and restarted my pod, but still getting our beloved Acme cert.  Editing the ingress alone should have worked, no?

Okay, all set now.  Thank you very much @aledbf and @pieterlange.  I'll put together some docs of what I did and either fork or submit a PR.  Cheers 🦄

I've one more nagging issue.  Does the ing controller not return a valid path to the issuer cert?  I'm getting
SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
via a working TLS controller.  Should this be raised as an issue to address here in beta @aledbf?

You have to put the full certificate chain in the TLS secret.

Gotcha.  I'll add that to a fork/PR too as I'm sure most looking to leverage ingress TLS will forget that as a prereq outside of the controller

@aledbf Sorry for the late response. I just followed your steps and configuration. It works perfectly. Thank you very much!

Full usage of TLS section doesn't appear to be defined anywhere official.
I got it working as follows:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: terminate-ssl
  annotations:
    ingress.kubernetes.io/ssl-redirect: "true"
spec:
  tls:
  - secretName: svc-ssl
    hosts:
    - svc.example.com
  rules:
  - host: svc.example.com
    http:
      paths:
      - path: /
        backend:
          serviceName: svc
          servicePort: 80


cannot merge Alpha (from colormap) and Mask with different type

reported in https://github.com/stac-utils/titiler-pgstac/issues/79
import numpy

mask = numpy.zeros((256,256), dtype="uint8")
alpha = numpy.zeros((256,256), dtype="float32")

numpy.bitwise_and(alpha, mask)
>> TypeError: ufunc 'bitwise_and' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

https://github.com/cogeotiff/rio-tiler/blob/0c9d4e5b798631490ac629c65f94b59ac5cbf379/rio_tiler/models.py#L488
https://github.com/cogeotiff/rio-tiler/blob/0c9d4e5b798631490ac629c65f94b59ac5cbf379/rio_tiler/utils.py#L430

after more 👀
It appears that the bug is in the mosaic methods
https://github.com/cogeotiff/rio-tiler/blob/0c9d4e5b798631490ac629c65f94b59ac5cbf379/rio_tiler/mosaic/methods/base.py#L36
We shouldn't cast the mask to the data dtype


Prepare for v0.8.0 release

@ssbarnea is it possible to tell Jenkins to release from this branch and only then merge the PR here?

delaying this release for next week as is already late friday.

Fair enough. #no_friday_releases

delaying this release for next week as is already late friday.

Fair enough. #no_friday_releases

I hope we can also fix https://github.com/ansible/vscode-ansible/issues/373 which is the bug that hindered @priyamsahoo e2e pull-request. We worked around it but the root cause is still very valid.

Can we also include the recent commit in this release?

Can you please be more explicit? I do not see anything else listed on https://github.com/ansible/vscode-ansible/releases other than the already included 3 items.
Also, I am inclined to delay this release until we fix #373 which counts as a serious bug.


ui: List Identity providers as domain admin

Description
This PR fixes: https://github.com/apache/cloudstack/issues/5477 wherein domain admins aren't allowed to list available IDPs.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

Closing this as it can be handled as part of https://github.com/apache/cloudstack/pull/5481

The listIdps API doesn't actually have any authorization restriction based on user roles. However, it isn't part of the API list for roles other than root admin. Legacy UI, didn't enforce this check either.


Build stacks by including other ruby files

I've created a naive implementation in #151 which would allow the following
You have a master file env_stack.rb
CloudFormation {
  Description "Test"
  include 'parameters_one'
  include 'parameters_two'
}

you can then create _parameters_one.rb and _parameters_two.rb
Parameter("One") {
  String
}

Parameter("Two") {
  String
}

This will generate the same output as
CloudFormation {
  Description "Test"
  Parameter("One") {
    String
  }
  Parameter("Two") {
    String
  }
}

Does this make sense?

@johnf really like this idea, interesting how you're able to define a method called include - I thought it was a reserved keyword.
I'll take a look at the PR, I'd done something similar in a previous project but by including the different templates into one big eval, this makes a lot more sense. Nice work!

include probably is technically reserved but probably only inside a module so that might be why it works here. Actually according to http://docs.ruby-lang.org/en/2.2.0/keywords_rdoc.html maybe it isn't reserved?
I was going to go with Include originally but didn't want to risk AWS using it for something.
Maybe _Include ?

I'll continue the conversation in: https://github.com/stevenjack/cfndsl/pull/151

Closing based on discussion in #151


Changed link for edit button

I really need more context on this PR

@SerDorosh the link being changed in this PR is already correct - the intention is to take the user to the list of validators to stake/unstake from. I'm going to close this PR for now.
In the future please add a detailed description for the change and/or create an issue that clearly specifies the issue being addressed. Without context we don't know the motivation or intention behind the change and will be unable to effectively incorporate contributions into the codebase.


pyspark kernel created using sparkmagic is not showing in the kernel list of jupyter extension in vs code

Environment data

VS Code version: 1.62.2
Jupyter Extension version (available under the Extensions sidebar): v 2021.10.110
Python Extension version (available under the Extensions sidebar): v. 2021.10.11422169775
OS (Windows | Mac | Linux distro) and version: Windows 10 Enterprise 20H2 build 19042.1288
Python and/or Anaconda version: python 3.8.8, Anaconda 3 (64 bits)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): NA
Jupyter server running: Local | Remote | local

Expected behaviour
All kernel visible/working in Conda Jupyter Notebook should be the same in VS code jupyter extension
Actual behaviour
pyspark kernel installed using sparkmagic did not show in vs code jupyter extension kernel list, even it worked well with Conda Jupyter Notebook and it showed with command of jupyter kernelspec list.
Steps to reproduce:

Install sparkmagic extension (instruction: https://github.com/jupyter-incubator/sparkmagic)
test in Jupyter Notebook, and it should be available in the kernel list
Open vs code, choose kernel, it is not showing in the list.

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

XXX

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

Thanks for the bug. This isn't working because the 'python' specified by the kernelspec can't be found so we don't know how to launch it.
This code here is the culprit:
https://github.com/microsoft/vscode-jupyter/blob/3f523db78421846af11c408b0398862216dee7d8/src/client/datascience/kernel-launcher/localPythonAndRelatedNonPythonKernelSpecFinder.ts#L168
Kernel spec looks like this:
{
  "argv": [
    "python", <-- This is ambiguous so we cannot tell how to start this kernel
    "-m",
    "sparkmagic.kernels.pysparkkernel.pysparkkernel",
    "-f",
    "{connection_file}"
  ],
  "display_name": "PySpark",
  "language": "python"
}

We might be able to change this to look for an interpreter that has that module installed (and then we can be sure that launching it will work).
Or you can change the kernelspec created such that it points to the correct virtual environment that has spark magic installed.
For me it works if I change it to this:
{
  "argv": [
    "D:\\Source\\Testing_SparkMagic\\.venv\\Scripts\\python.exe", <-- Full path to python from venv that has sparkmagic installed
    "-m",
    "sparkmagic.kernels.pysparkkernel.pysparkkernel",
    "-f",
    "{connection_file}"
  ],
  "display_name": "PySpark",
  "language": "python"
}

You might also log a request on sparkmagic to have their kernelspec have the full path to python in it.

It worked for me.
Thank you very much for your help!

One idea. List all the kernels found, but if it's ambiguous as to which interpreter to use, then ask the user to provide the path to it.

I'm closing this issue as we've resolved the issues around displaying custom kernels (in the latest dev branch, soon to be released).
If the issue persists, please feel free to re-open this issue or create a new one and we'll be happy to look into them.

I'm closing this issue as we've resolved the issues around displaying custom kernels (in the latest dev branch, soon to be released). If the issue persists, please feel free to re-open this issue or create a new one and we'll be happy to look into them.

@DonJayamanne, I still faced this issue in this version:
VSCode 1.71.2
Jupyter Extension v2022.8.1002431955
Python Extension v2022.14.0
This was missing until I updated "python" to the full path
{
  "argv": [
    "python",
    "-m",
    "aws_glue_interactive_sessions_kernel.glue_pyspark.GlueKernel",
    "-f",
    "{connection_file}"
  ],
  "display_name": "Glue PySpark",
  "language": "python"
}

Interestingly, this works fine without it:
{
  "argv": [
    "python",
    "-m",
    "aws_glue_interactive_sessions_kernel.glue_spark.GlueKernel",
    "-f",
    "{connection_file}"
  ],
  "display_name": "Glue Spark",
  "language": "scala"
}

Where is the kernelspec?


hackage2nix: Restore arion-compose

Motivation for this change
#83040 rebased
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

As of right now, the haskell-updates branch hasn't actually gotten the latest arion-compose package (version <IP_ADDRESS>), which appears to be necessary to get arion building with ghc-8.8.
This should hopefully happen within the next couple hours.

@cdepillabout Rebased


Unable to change default role via UI after configuring ADFS authentication

Internal reference: SURE-4020
Reported in 2.6.2 and 2.6.3
Issue description:
Unable to change default role via UI after configuring ADFS authentication
Business impact:
Unable to assign default roles to users
Repro steps:

Install Rancher v2.6.2
Configure ADFS authentication
Go to Roles -> Global Role -> Standard User -> Edit Config -> Select "No" for "New User Default"

Workaround:
Is a workaround available and implemented? Yes
What is the workaround: Use Old UI via "https://<rancher_fqdn>/g"
Actual behavior:
New UI is not allowing default roles change
Expected behavior:
UI should allow default role change

Same issue as https://github.com/rancher/dashboard/issues/4992

Zube keeps adjusting the milestone for some reason. @sowmyav27 just a heads-up that this is in 2.6.4.

Validated in https://github.com/rancher/dashboard/issues/4992. ADFS not needed for checks.


[Blocker] Cannot update a user store via admin services

Type: Bug
Priority: Highest
Severity: Blocker
Release: wso2is-5.4.0-update1
Steps

Create a user store via admin services
Update the same user store via admin services

Issue
Exception occurred while trying to invoke service method editUserStore error message is returned to the user. No error in the IS side, but shows that the user was authenticated through logs. So cannot update user stores
[2017-12-20 14:24:05,262]  INFO {org.wso2.carbon.core.services.util.CarbonAuthenticationUtil} -<EMAIL_ADDRESS>[-1234]' logged in at [2017-12-20 14:24:05,261+0530]
Note: User store creation request successfully works

First, you need to get the UniqueId property of the secondary user-store using getSecondaryRealmConfigurations method
Then you can call the editUserStore method with that property.

This is not mentioned in the docs. Therefore please document the flow. So, reopening the issue.

@thanujalk do we need to use the UniqueID property when using the deleteUserStore() and changeUserStoreState() as well?

Fixed in versions 5.5.0 - 5.8.0 [1]
[1] https://docs.wso2.com/display/IS580/Managing+User+Stores+with+APIs#ManagingUserStoreswithAPIs-editUserStore()


Remove ivy from release artifacts

[observed]
ivy.jar is contained in binaries
[expected]
ivy.jar is not needed in binaries

The apache-ant-contrib directory contains ivy jar and some other apache common jars which are already in other directories. All of them are removed from packaging.

[Build] 17.3+
[Date] 2017/08/30
verified install pack and aws open stack controller packages


Remove a dependecy on Pioasm to fix building with ninja

This fixes the "'pioasm/pioasm', needed by '...', missing and no known rule to make it" error with ninja. I think the add_custom_command below adds the necessary dependency on the pioasm build.
I've successfully done a ninja and make -j24 build on the examples with this (and a similar change to a couple of the examples).
(Clean build each time, 24-thread CPU)

does that work with a clean build?

does that work with a clean build?

Yes, even doing something like:
cmake -GNinja -B build-ninja
ninja -C build-ninja pio_addition

to directly build an example using pioasm from nothing works fine.

Yes, even doing something like:
cmake -GNinja -B build-ninja
ninja -C build-ninja pio_addition

to directly build an example using pioasm from nothing works fine.


BSD68 Ligthning API fails on prediction [BUG]

Describe the bug
In the lightning API notebook, the prediction fails for some images in the test set. If the prediction are done one at a time, there is no issue.
To Reproduce
Please refer to the notebook for the full code. The prediction step fails if done as follow:
# Create lightning data module
means, stds = train_data_module.get_data_statistics()
pred_data_module = PredictDataWrapper(
    pred_data=test_path,
    data_type="tiff",
    axes="YX",
    batch_size=1,
    tta_transforms=True,
    image_means=means,
    image_stds=stds,
    tile_size=(128, 128),
    tile_overlap=(32, 32),
)

# Predict
prediction = trainer.predict(model, datamodule=pred_data_module)

# Convert the outputs to the original format, mostly useful if tiling is used
prediction = convert_outputs(prediction, tiled=True)

with the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[9], [line 5](vscode-notebook-cell:?execution_count=9&line=5)
      [2](vscode-notebook-cell:?execution_count=9&line=2) prediction = trainer.predict(model, datamodule=pred_data_module)
      [4](vscode-notebook-cell:?execution_count=9&line=4) # Convert the outputs to the original format, mostly useful if tiling is used
----> [5](vscode-notebook-cell:?execution_count=9&line=5) prediction = convert_outputs(prediction, tiled=True)

File ~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:42, in convert_outputs(predictions, tiled)
     [40](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:40)     tiles = [pred[0] for pred in predictions_comb[0]]
     [41](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:41)     tile_infos = predictions_comb[1]
---> [42](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:42)     predictions_output = stitch_prediction(tiles, tile_infos)
     [43](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:43) else:
     [44](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/prediction_outputs.py:44)     predictions_output = combine_batches(predictions, tiled)

File ~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:47, in stitch_prediction(tiles, tile_infos)
     [44](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:44) # slice the lists and apply stitch_prediction_single to each in turn.
     [45](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:45) for image_slice in image_slices:
     [46](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:46)     image_predictions.append(
---> [47](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:47)         stitch_prediction_single(tiles[image_slice], tile_infos[image_slice])
     [48](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:48)     )
     [49](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:49) return image_predictions

File ~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:91, in stitch_prediction_single(tiles, tile_infos)
     [88](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:88)     cropped_tile = tile[slices]
     [90](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:90)     # Insert cropped tile into predicted image using stitch coordinates
---> [91](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:91)     predicted_image[
     [92](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:92)         (
     [93](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:93)             ...,
     [94](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:94)             *[slice(c[0], c[1]) for c in tile_info.stitch_coords],
     [95](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:95)         )
     [96](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:96)     ] = cropped_tile.astype(np.float32)
     [98](https://file+.vscode-resource.vscode-cdn.net/Users/joran.deschamps/git/careamics/careamics/examples/2D/n2v/~/git/careamics/careamics/src/careamics/prediction_utils/stitch_prediction.py:98) return predicted_image

ValueError: could not broadcast input array from shape (96,112) into shape (17,112)

But succeeds if done file by file:
means, stds = train_data_module.get_data_statistics()
files = list(test_path.rglob("*.tiff"))
files.sort()

predictions = []

for file in files:
    pred_data_module = PredictDataWrapper(
        pred_data=file,
        data_type="tiff",
        axes="YX",
        batch_size=1,
        tta_transforms=True,
        image_means=means,
        image_stds=stds,
        tile_size=(128, 128),
        tile_overlap=(32, 32),
    )

    ### Predict
    prediction = trainer.predict(model, datamodule=pred_data_module)

    # Convert the outputs to the original format, mostly useful if tiling is used
    prediction = convert_outputs(prediction, tiled=True)
    predictions.append(prediction)

Expected behavior
No error.

Hmm, this looks like axes are getting dropped somewhere which results in the wrong axes being indexed. I'll get on it ASAP.


Add Boost as submodule, add CMake dependency

Startding from CMake 3.30 FindBoost is no longer supported:
https://cmake.org/cmake/help/latest/release/3.30.html#deprecated-and-removed-features
Boost libraries have started supporting CMake recently:
https://github.com/boostorg/cmake
It is possible to use Boost as a submodule and compile it if necessary as CMake targets.

I decided not to use submodules. In this case, it takes so much time to clone.


jinja filters for URLs, arXiv IDs, DOIs and line feeds

Builds on Martin's work with jinja filters.
https://culibrary.atlassian.net/browse/ARXIVNG-988

Pull Request Test Coverage Report for Build 154

163 of 164 (99.39%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 92.542%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

browse/controllers/abs_page/init.py
1
2
50.0%

Totals

Change from base Build 137:
0.5%

Covered Lines:
2246

Relevant Lines:
2427

💛  - Coveralls


🐛 Resolve error 'hyrax_parent_active_fedora_base_path'

Story
In the SDAPI tenant, there are some works that were split prior to valkyrization. When trying to view them, they throw an error.
Need to identify the reason for the failure and make appropriate corrections.
dashboard query: https://sdapi.s2.adventistdigitallibrary.org/dashboard/works?locale=en&page=192&per_page=100
one of works with error: https://sdapi.s2.adventistdigitallibrary.org/concern/journal_articles/pur_2010_feb_pacific_union_recorder_february_2010?locale=en
Acceptance Criteria

[ ] Works can be viewed without error

Screenshots / Video

Testing Instructions and Sample Files

Notes

This may be related to ticket: https://github.com/scientist-softserv/adventist_knapsack/issues/839

blocked by #851

We have identified this as an indexing issue with ordered members. We were able to fix the issue by finding the work and then running 3 reindex commands over it:
w = JournalArticle.find('pur_2010_feb_pacific_union_recorder_february_2010')
w.members.each{|m| m.update_index}
w.list_source.update_index
w.update_index

Closing with the above documentation in case we identify further problem works.

The above item appears to have some bad data... Fedora has an access control relationship to an object that doesn't exist, but I'm unsure what object is actually missing. I am going to try to remove all of the members and re-attach the pdf and hope it works this time.

Migrating the above item got it working again. The PDF fileset migration failed with an empty file error, and I can not find the fileset now. But the viewer on the parent work still shows all the children.


feature request: dark theme

It would be perfect if this plugin can support dark theme!

You can push a PR.


Improvements to management logic

This PR introduces the following updates:

The deploy_management_resources input variable is now decoupled from the logic used to control policy configuration in the management child module, allowing the management resources to be implemented independently from core resources without impacting the expected configuration specified by the configure_management_resources input variable.
Test scenarios added for a custom configure_management_resources input variable to allow unit tests to be written to validate this functionality.
The connectivity_id_management input variable now places the provided Subscription (by ID) into the Connectivity Management Group.
The identity_id_management input variable now places the provided Subscription (by ID) into the Identity Management Group.
The subscription_id_management input variable now places the provided Subscription (by ID) into the Management Management Group.

/azp run unit


Added new Abstract Commands

Hi,
this PR first of all fixes #25. Several tests might crash due to the following error
[PDOException] SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'password' at row 1
that can be easily solved just raising the length of the varchar user password field in test migrations.
Then adds several new commands to the Abstract Command Class.
My inspiration was of course Laravel Artisan and, using Synfony Console I implemented the methods confirm, ask, askPassword, choose, anticipate and choice.
All methods find proper documentation in the readme.

@zachleigh I fixed the problem with Travis with PHP 7.0, by replacing the .sh file which used to install Phalcon with a few lines directly in .travis.yml file.
I also added PHP 7.1 and 7.2, but unfortunately the last one had failing tests, due to a modification in the count() function that now fails if the argument is something not countable. I provided then to fix the problem.
I am sorry if it took a few more commits that it would have needed, but now everything should work as expected!

@micheleangioni Cool! Thank you! I managed to fix the Travis tests on dev branch as well. I'll review all your commits and merge this weekend.

@zachleigh great! Thanks! :+1:


Causes game crash on Linux when opening the controls screen

Playing on Manjaro Linux 5.15.38-1-MANJARO using X11 and KDE Plasma 5.24.5
Error [25May2022 23:58:46.309] [Render thread/ERROR] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: Exception caught during firing event: Cannot read field "uploadMode" because "net.creeperhost.blockshot.Config.INSTANCE" is null is thrown and client immediately crashes.
Log below:
latest.log
EDIT: ran a quick cat latest.log | grep "ERROR" > errors.txt for you, so you don't have to comb through thousands of lines of log output:
errors.txt

In case someone needs a temporary fix. Deleting the file blockshot.json in the instance folder (aka. where you can find instance.json and options.txt) or alternatively, ensure that it looks something like this
{
  "uploadMode": 1,
  "anonymous": true
}

fixes the problem. For some reason it seems that I've ended up with a blank file, causing the issues mentioned above.

This should be fixed in later builds of the mod


Choosing the right DataSpace in EntityFrameworkMaterializer

This issue is related with the question I posted on StackOverflow.
I have no idea what a DataSpace does in EF. However, it seems that changing the DataSpace from a System.Data.Entity.Core.Metadata.Edm.DataSpace.CSpace to a System.Data.Entity.Core.Metadata.Edm.DataSpace.OSpace in method GetKeyNames solves my issue.
I suspect that changing it in GetEntitySetName as well might solve another issue I have: IncludeInPayload(true). I would like to do a quick test, but I can not override that method.
Thanks in advance for you inputs and comments.

This is tricky. The best explanation I've found so far is this one, and really it doesn't explain much. At a minimum I'll have to load up a few of my apps--all of which work with the CSpace code, and see if they also work if I switch to OSpace...but really is rather have a better understanding of the difference...we may need to try and ask some EF devs to help us explain the difference. On top of all that, this may change entirely for EF7, which gets rid of the ObjectContext API entirely...presumably exposing some other API for introspecting its mapping.
A fallback for us might also be to revert to the GetIdProperty code in ModelManager if the EF-specific code fails to determine a key. You'd lose support for compound primary keys at that point, but I'm doubtful those work at present anyway--it's not tested.


Security vulnerability in golang.org/x/text. Please bump to version 0.3.7

Hey,
golang.org/x/tex version 0.3.3 has a known vulnerability that is fixed in version 0.3.7 (CVE-2021-38561). Please bump this dependency. Thank you!

Hey @Mexx77, thanks for reporting this. We're looking into bumping the package version

Release v2.4.7 now uses the latest version of golang.org/x/text 0.3.7


tag closed too soon

Ran into some unexpected behavior after parsing this page using Jsoup: http://www.reuters.com/article/us-health-pacemakers-appliances-idUSKBN1662EX
The  tag seems to be closed too soon, causing the <meta> tags to appear inside of the  instead of the .
Jsoup.connect("http://www.reuters.com/article/us-health-pacemakers-appliances-idUSKBN1662EX").get();

That's because  contains

. Chrome and Firefox also end the head element there.
When parsing

  <meta name='one'>

  <meta name='two'>

you'll end up with:

  <meta name="one">

  <meta name="two">

That's to be expected. See https://www.w3.org/TR/html5/syntax.html#parsing-main-inhead

Thanks - working as current browsers / HTML5 == not a bug


Pull upstream

This pulls a number of upstream changes to add support for later Rails versions and to include a fix that should help with fetching model attributes on the RegisterEntry class.

Just making a note that upstream doesn't seem to have the tests passing either https://github.com/pboling/seed_migration/commit/85100250c9f241779cb600f1df4030ca19a6b65c


Documentation in the readme extended

Add compile steps for static libraries (iOS) and execution hints to the README file

@Bear-03 thanks for your pr review. Last unresolved comment is regarding the subsubsubsection "troubleshooting". Dispite this - the pr is ready to review again

@Flocksserver I've added some more comments. Please note that one of those comments continues the conversation about the iOS static libraries, so I've marked it as unresolved.


Dark Themed Dashboard

Theme dashboard to use a dark theme. Includes some minor changes to the masthead and page background. Using emotion to overwrite css variables. react-core will be switching to this soon.
Part 1 of #70.

Codecov Report

Merging #78 into master will increase coverage by 0.45%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   85.72%   86.18%   +0.45%
==========================================
  Files          98      101       +3
  Lines         918      941      +23
  Branches       92       95       +3
==========================================
+ Hits          787      811      +24
+ Misses        122      121       -1
  Partials        9        9

Impacted Files
Coverage Δ

...nents/reportSummary/reportSummaryDetails.styles.ts
100% <ø> (ø)
:arrow_up:

src/components/page/page.styles.ts
100% <ø> (ø)
:arrow_up:

src/components/trendChart/trendChart.styles.ts
100% <ø> (ø)
:arrow_up:

...c/components/reportSummary/reportSummary.styles.ts
100% <ø> (ø)
:arrow_up:

...mponents/trendChart/trendChartLegendItem.styles.ts
100% <ø> (ø)
:arrow_up:

src/pages/login/login.styles.ts
100% <ø> (ø)
:arrow_up:

src/styles/theme.ts
100% <ø> (ø)
:arrow_up:

...c/components/verticalNav/verticalNavItem.styles.ts
100% <ø> (ø)
:arrow_up:

src/components/masthead/masthead.styles.ts
100% <ø> (ø)
:arrow_up:

src/components/verticalNav/verticalNavItem.tsx
44.44% <0%> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4400c51...b0835d9. Read the comment docs.


Negative values predicted by interp_nd_binning problematic for error analysis

Opening after a discussion started by Enrico Mattea:
The linear extrapolation of interp_nd_binning can result in negative values (and, more generally, yield curious values) for points outside of the binning maximum bounds, especially as the "edge bins" tend to have less points to sample from, and thus more variability:
https://github.com/GlacioHack/xdem/blob/d91bf1cc9b3f36d77f3729649bc8e9edc6b42f9f/xdem/spatialstats.py#L342
It does happen that slope/curvature have very high values because of outliers, and those can be ignored during error prediction (min_vals argument of interp_nd_binning).
If those outliers remain unfiltered in the dDEM, some of the predicted errors could then be negative? (untested)
So: should we rather default to nearest neighbour outside of the bin bounds, and leave the linear extrapolation option to the user?

So interp_nd_bininng does linear extrapolation outside the bounds? I thought that it was doing nearest neighbor from looking at the docstring.
"Fills the no-data present on the regular N-D binning grid with nearest neighbour from scipy.griddata, then provides an interpolant function that linearly interpolates/extrapolates using scipy.RegularGridInterpolator."
So in which case does it use the nearest neighbor and which case the RegularGridInterpolator?
I would indeed put NN as the default and linear extrapolation as an option. Alternatively, one could also include an option to set the bounds of the extrapolated values.

The nearest neighbour was just to fill nodata values for points of the ND binning (not supported by interpolators). All other interpolation (between bins and outside bins) was linear.
I've fixed all and hopefully clarified the descriptions in #389


Split Up/Down menu items not working

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.2
OS Version: 11.7.10 (Big Sur)

Steps to Reproduce:

open vscode
open an editor window
select View-> Editor Layout-> Split Down

Nothing happens.
However there is a work around: hold down the alt key and click on the Split Editor XX on the top right of the editor window (the last icon in the list before the elipses). XX is dynamic depending on wether you are hlding the alt key. When you activate window splitting using this method it works. So just the menu item is broken. I've only checked Split up and Split Down.
Version info:
Version: 1.90.2
Commit: 5437499feb04f7a586f677b155b039bc2b3669eb
Date: 2024-06-18T22:37:41.291Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin x64 20.6.0
PS: I am not using the latest version of vs code because the latest version is broken for macOS Big Sur as I found out just a few days ago and the work-around was to downgrade to this version until a fix is released.

FYI the 1.91.1 release (which works on your macOS) came out yesterday.

This should be fixed in the newest update


truncated glyphs

Is this an issue with 0.8.4 version of st ? this issue doesnt exist in 0.8.2
I am using this fork https://github.com/siduck/st based on 0.8.2
I did try other nerd fonts as well

Hi TripleK2004, my apologies for such a huge delay
didn't use v0.8.2 so idk for real, but so far as I know there's not sufficient space for the glyphs and one work around could be to add a space after each icons in your nvimtree configuration(I suppose you use it), didn't try just thinking of a possibility. Also this might arise due to the fact that we can't set different fontsize for simple text and glyphs.
Now I'm just talking shit, don't mind :)
to be honest I'm already tired, nearly all the features I added to kdwm, kst, and kdmenu are kinda useless to me and they add more bloats to these beauty suckless softwares, so I decided to repatch(while keeping in mind the suckless philosophy), you know, it's kinda pointless to transform dwm into gnome or an st into a gnome-terminal. kdwm, kst, and kdmenu still have a future for full feature software users.


ERROR:  EVP_CipherFinal_ex failed. OpenSSL error: error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt

If you're dealing with a TEXT field, encryption and decryption issues may pop up.

Thank you for the bug report @cobolbaby
Could you give us a more detailed description, do you have example SQL statements that cause this error?


Primary key violations with persisted aggregation.

Description:
Running APIM-Analytics-3.2.0 with persisted aggregation the primary key violations can be observed relevant to the DAYS granularity levels.
Steps to reproduce:
Generate a set of aggregation events that contain different timestamp values for AGG_TIMESTAMP and the AGG_EVENT_TIMESTAMP at HOURS level and try to trigger the aggregation based on the persisted aggregation to the DAYS level.
Affected Product Version:
APIM-3.2.0
Environment details (with versions):

Not relevant

Fixed with https://github.com/siddhi-io/siddhi/pull/1749


Update optimum-habana version to 1.11.1 (#138)

What does this PR do?
Merge tgi-gaudi v2.0.0 into habana-main

@regisss please review

@kdamaszk I merged #141, is this one still needed?

Yes, it bumps optimum-habana to 1.11.1, like in the release tgi-gaudi v2.0.0
Let me resolve the merge conflict


[Bug]:An error occurred when creating the test report on Windows.

Description
Gives NoSuchFileException exception when generating the test report.

Steps to Reproduce
No response
Affected Version(s)
Ballerina 2201.8.2 (Swan Lake Update 8)
OS, DB, other environment details and versions
OS- Windows 11
Related area
-> Test Framework
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

I was able to reproduce the issue on Windows. The problem seems to be arriving due to not being able to extract the zip containing the test report template. This template is located within the ballerina home. I will update on the findings here.


WIP: read (some) v4 format files

This is based on the spec I found here: https://www.eiscat.se/wp-content/uploads/2016/03/Version-4-MAT-File-Format.pdf  It doesn't handle everything but maybe it's better than nothing!
Unfortunately I lack a sufficiently diverse collection of .mat files to test this against but it works for the one type of file I do have a lot of (a single Int16 matrix per .mat file).

@kleinschmidt Apologies for a ping after such a long time, but is it ok to merge this as is?

Don't see why not, but to be perfectly honest I haven't touched a MAT file in many years

Ah hold up, there's #186