feat:password-complexity(adding special characters)

Description
This PR is made regarding

issue: https://github.com/apache/cloudstack/issues/6861#issue-1431841155
added configkey and updated  generateRandomPassword()

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

unable to build
os:windows (wsl ubuntu)

hello,
I am not sure if this is the appropriate way to ask this, if not  Can you please direct me to the correct channel for assistance?
I have changed code... but when i am trying to build here are the issues i faced

and then when i tried to check dependency tree it showed i have Apache CloudStack Utils jar

and i reffered for documentation here
I wasn't able to access an y links provided there
thankyou!

@Pavan-Nambi for specific question it is all right to ask in an issue or PR related to the question. For generic questions the maillist is best.
As to your question;

what platform are you on?
what version of maven do you use?
what version of javac do you use?
what is the cmd line you issued?
and what ever info you think might be relevant...

The cloudstack-util jar should be in your .m2/repository tree.
Also can you please paste text rather than images?
btw, this question would be an exelent example to put on the dev list ;)

platform : windows 10 wsl ubuntu
maven version : inside wsl : Apache Maven 3.6.3 ,,, inside windows : Apache Maven 3.8.7
javac version : inside wsl : javac 11.0.17  ,,,, inside windows : javac 19.0.2
all commands r done in wsl
Command : mvn -P developer -pl developer -Ddeploydb
Error :
[ERROR] Failed to execute goal on project cloud-developer: Could not resolve dependencies for project org.apache.cloudstack:cloud-developer:pom:<IP_ADDRESS>-SNAPSHOT: Failure to find org.apache.cloudstack:cloud-server:jar:<IP_ADDRESS>-SNAPSHOT in https://repo.jenkins-ci.org/public/ was cached in the local repository, resolution will not be reattempted until the update interval of repo.jenkins-ci.org.public has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

in .m2/repo i have cloudserver i am not sure why i got that error i have tried downloading it again and reinstalling
version i installed is <IP_ADDRESS> from here
error :
pavan-nambi@Pavan-nambi:~/.m2/repository/org/apache/cloudstack$ ls
checkstyle                            cloud-plugin-hypervisor-ucs
cloud-agent                           cloud-plugin-hypervisor-xenserver
cloud-api                             cloud-plugin-integrations-cloudian-connector
cloud-apidoc                          cloud-plugin-integrations-kubernetes-service
cloud-client-ui                       cloud-plugin-integrations-prometheus-exporter
cloud-console-proxy                   cloud-plugin-metrics
cloud-controller-secondary-storage    cloud-plugin-network-bigswitch
cloud-core                            cloud-plugin-network-contrail
cloud-devcloud-kvm                    cloud-plugin-network-elb
cloud-devcloud4                       cloud-plugin-network-globodns
cloud-developer                       cloud-plugin-network-internallb
cloud-engine                          cloud-plugin-network-netscaler
cloud-engine-api                      cloud-plugin-network-nvp
cloud-engine-components-api           cloud-plugin-network-opendaylight
cloud-engine-network                  cloud-plugin-network-ovs
cloud-engine-orchestration            cloud-plugin-network-palo-alto
cloud-engine-schema                   cloud-plugin-network-ssp
cloud-engine-service                  cloud-plugin-network-vcs
cloud-engine-storage                  cloud-plugin-network-vxlan
cloud-engine-storage-cache            cloud-plugin-non-strict-host-affinity
cloud-engine-storage-configdrive      cloud-plugin-non-strict-host-anti-affinity
cloud-engine-storage-datamotion       cloud-plugin-outofbandmanagement-driver-ipmitool
cloud-engine-storage-image            cloud-plugin-outofbandmanagement-driver-nested-cloudstack
cloud-engine-storage-snapshot         cloud-plugin-outofbandmanagement-driver-redfish
cloud-engine-storage-volume           cloud-plugin-planner-implicit-dedication
cloud-framework-agent-lb              cloud-plugin-planner-skip-heurestics
cloud-framework-ca                    cloud-plugin-planner-user-concentrated-pod
cloud-framework-cluster               cloud-plugin-planner-user-dispersing
cloud-framework-config                cloud-plugin-snmp-alerts
cloud-framework-db                    cloud-plugin-storage-allocator-random
cloud-framework-direct-download       cloud-plugin-storage-image-default
cloud-framework-events                cloud-plugin-storage-image-s3
cloud-framework-ipc                   cloud-plugin-storage-image-sample
cloud-framework-jobs                  cloud-plugin-storage-image-swift
cloud-framework-managed-context       cloud-plugin-storage-volume-cloudbyte
cloud-framework-quota                 cloud-plugin-storage-volume-datera
cloud-framework-rest                  cloud-plugin-storage-volume-default
cloud-framework-security              cloud-plugin-storage-volume-linstor
cloud-framework-spring-lifecycle      cloud-plugin-storage-volume-nexenta
cloud-framework-spring-module         cloud-plugin-storage-volume-sample
cloud-marvin                          cloud-plugin-storage-volume-scaleio
cloud-mom-inmemory                    cloud-plugin-storage-volume-solidfire
cloud-mom-kafka                       cloud-plugin-storage-volume-storpool
cloud-mom-rabbitmq                    cloud-plugin-syslog-alerts
cloud-plugin-acl-dynamic-role-based   cloud-plugin-user-authenticator-ldap
cloud-plugin-acl-project-role-based   cloud-plugin-user-authenticator-md5
cloud-plugin-acl-static-role-based    cloud-plugin-user-authenticator-pbkdf2
cloud-plugin-api-discovery            cloud-plugin-user-authenticator-plaintext
cloud-plugin-api-limit-account-based  cloud-plugin-user-authenticator-saml2
cloud-plugin-api-solidfire-intg-test  cloud-plugin-user-authenticator-sha256salted
cloud-plugin-backup-dummy             cloud-quickcloud
cloud-plugin-backup-networker         cloud-secondary-storage
cloud-plugin-ca-rootca                cloud-server
cloud-plugin-database-quota           cloud-systemvm
cloud-plugin-dedicated-resources      cloud-testclient
cloud-plugin-example-dns-notifier     cloud-tools
cloud-plugin-explicit-dedication      cloud-usage
cloud-plugin-host-affinity            cloud-utils
cloud-plugin-host-allocator-random    cloudstack
cloud-plugin-host-anti-affinity       cloudstack-framework
cloud-plugin-hypervisor-baremetal     cloudstack-plugins
cloud-plugin-hypervisor-hyperv        cloudstack-service-console-proxy
cloud-plugin-hypervisor-kvm           cloudstack-service-secondary-storage
cloud-plugin-hypervisor-ovm           cloudstack-services
cloud-plugin-hypervisor-ovm3

btw, this question would be an exelent example to put on the dev list ;)
what is dev list...?😅

and these are the two ways i followed from development 101
one for linux setting up env
for build cloudstack in this the links pointing out in dependencies are not leading me anywhere
and there was no step saying i have to manually download dependencies like cloudutils and cloudserver  i am not sure if this is how it was intended to be or diff saying here for reference... or if  it should be changed i am willing to if i can..

before running
mvn -P developer -pl developer -Ddeploydb

did you run
mvn clean install -D simulator -Pdeveloper

Also you say you installed from a packages dir, but you should clone the repository and do the build command above first.

btw, this question would be an exelent example to put on the dev list ;)

what is dev list...?sweat_smile

this one:

For generic questions the maillist is best.

<EMAIL_ADDRESS>
and these are the two ways i followed from development 101 in docs one for linux setting up env and another for build cloudstack in this the links pointing out in dependencies are not leading me anywhere

You can forget about the dependencies for now. later if you want to support these you can include them. For this feature they are not needed.

and there was no step saying i have to manually download dependencies like cloudutils and cloudserver i am not sure if this is how it was intended to be or diff saying here for reference... if its not how it should be i am willing to help/try to change it a bit ig

this is not true, I wonder where you read that. These packages are part of the project and should be build with the command above. i.e. mvn clean install -D simulator -Pdeveloper

this is the series of commands i have followed as per docs
 mvn clean
 mvn clean install -P developer,systemvm
 mvn -P developer -pl developer -Ddeploydb

this is not true, I wonder where you read that. These packages are part of the project and should be build with the command above. i.e. mvn clean install -D simulator -Pdeveloper

ohh for cloud-utils when i got error i manually downloaded them .. then i didn't got error.. so that is the reason i asked idk if i did something wrong but i manually downloaded both cloud-utils and cloud-server  when i got the error in my first message...(the one i sent images ...)
eitherway i am retrying with the command you provided :)
thankyou!

@Pavan-Nambi can you please address outstanding review comments?

@Pavan-Nambi there are build errors in the github actions. Can you have a look?

@GutoVeronezi @JoaoJandre , the last time @Pavan-Nambi returned to this was in January. Will this be harmful or can it be improved by some small changes and merged? cc @shwstppr

@DaanHoogland I think the approach used here could cause some problems, especially the possible infinite loop that can be caused by the following block:
    while (!pswd.matches(passwordComplexity)) {
         pswd= PasswordGenerator.generateRandomPassword(passwordLength);
    }

I agree with @JoaoJandre on his comment https://github.com/apache/cloudstack/issues/6861#issuecomment-1419337976. However, if we go with the feature, we should guide @Pavan-Nambi (if they are willing to do it) on a better approach for addressing the use case.

I agree with @JoaoJandre on his comment #6861 (comment). However, if we go with the feature, we should guide @Pavan-Nambi (if they are willing to do it) on a better approach for addressing the use case.

ok, removing it from the 4.19 milestone for now.

hey, sorry for the delay, i will look into this in few days or this weekend. i got into gsoc work and forgot about this. sorry.

@Pavan-Nambi thanks for looking into it would be great , if vm password can be also customized based on these user password global settings

@GutoVeronezi @JoaoJandre , the last time @Pavan-Nambi returned to this was in January. Will this be harmful or can it be improved by some small changes and merged? cc @shwstppr

@DaanHoogland I think the approach used here could cause some problems, especially the possible infinite loop that can be caused by the following block:
    while (!pswd.matches(passwordComplexity)) {
         pswd= PasswordGenerator.generateRandomPassword(passwordLength);
    }

I agree with @JoaoJandre on his comment #6861 (comment). However, if we go with the feature, we should guide @Pavan-Nambi (if they are willing to do it) on a better approach for addressing the use case.

hey can someone tell me if i am thinking this correctly?
as this gonna result in infinite loop , we have to dynamically generate password based on regex given by user through parsing it or something
which i tired but it ends up failing whenever regex gets bit complex and as regex can get really complex i am not sure how to proceed here
on same note i found some already existing java libraries RgXGen and generex
which does same but i guess this does for bit more complex passwords too. but again i am not sure if its worth it to add a new library here for this.
or if there is a better way to do this , please let me know
thankyou

@Pavan-Nambi , both the examples of libraries you mention are distributed under the apache2 license, so you can safely incorporate them. If you isolate the calls to the library in a single module (i.e. proxy the library) there should be no problem. You are shifting a maintenance burden away from us and guaranteeing a higher adherence to industry standards.
As you have taken the lead on this, your choince is best unless, ... rather then have everybody's way ;)
As these are apache licensed you may also decide to copy design or even parts of the code as long as you leave good references to the origin. I can imagin you want just part of the functionality or a simplified version of it.

hey, I am sorry but things got busy for me and i don't think I can dedicate time in making a new library for regex(as of now) and i don't want to keep this open without updating for long , it's already been way too long.
sorry some personal and work stuff got in.


Not documented: Additional filters "&" and "!&" - What on earth do these mean?

[Enter feedback here]
In the list of possible scoping filters there is "&" and "!&"
its not clear what these do or how these can be used.
This page does not describe these filters and their usage.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a77e752-0785-c3bd-9b33-f37bb7af6acd
Version Independent ID: d865098d-299a-ddeb-6eed-9a1db3175de3
Content: Provision apps with scoping filters
Content Source: articles/active-directory/app-provisioning/define-conditional-rules-for-provisioning-user-accounts.md
Service: active-directory
Sub-service: app-provisioning
GitHub Login: @kenwith
Microsoft Alias: kenwith

@mighty-dev Thank you for your feedback! We will review and update as appropriate.


Add ctr_id_short to Audit log

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>Audit logging was not showing the containers id. Unlike docker-1.12.6, the audit middleware is being initialized appropriately in this version and dockerd/daemon.go did not need to be fixed. This change only adds the short container id to the audit log.
This addresses https://bugzilla.redhat.com/show_bug.cgi?id=1496176
What I did
I've added a 'ctr_id_short' field to the audit logging and a couple of debug messages.

How I did it
Changed the code and lots of testing.

How to verify it

The old audit log entries looked like:
type=VIRT_CONTROL msg=audit(1512770060.628:254): pid=1768 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:container_runtime_t:s0 msg='op=attach vm-pid=? auid=0 hostname=? reason=api vm=? user=root exe=? exe="/usr/bin/dockerd-current" hostname=? addr=? terminal=? res=success'
The new ones look like:
type=VIRT_CONTROL msg=audit(1515610710.130:485): pid=19793 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:container_runtime_t:s0 msg='reason=api auid=0 exe=sleep hostname=8386cb7735f4 ctr_id_short=8386cb7735f4 op=attach vm=centos vm-pid=0 user=root exe="/usr/bin/dockerd-current" hostname=? addr=? terminal=? res=success'
Note the addition of the ctr_id_short field and the appropriate values in the vm, vm-pid, exed and other fields.
Description for the changelog
Correct audit logging for container operations.

@rhatdan @runcom Can this be merged?  If not, please let me know what (if anything) I can do.  This will address https://bugzilla.redhat.com/show_bug.cgi?id=1496176 which is on the 7.5 blocker list.

I will merge.

Ask @lsm5 and franticek to rebuild.


Display graph as images on the workflow node

Duplicate of https://github.com/DARPA-ASKEM/terarium/issues/5452


Where to run tests

Can you please update or suggest where to run integration tests?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2817660c-2b71-3278-dcde-497b9bc6ad55
Version Independent ID: edaa4f01-f6ae-10a4-e2a9-46bc092e4efe
Content: Quickstart: Create a CI/CD pipeline for .NET with Azure DevOps Projects
Content Source: articles/devops-project/azure-devops-project-aspnet-core.md
Product: devops
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the question! We are investigating and will update you shortly.

@akfkmupiwu I have assigned the issue to the content author to investigate further and update the document as appropriate.

@akfkmupiwu  you will want to run those tests (in this context for CI/CD) as part of the pipeline itself in Azure DevOps (formerly VSTS) .. there are various approaches for testing during CI/CD , check here  https://docs.microsoft.com/en-us/azure/devops/pipelines/test/set-up-continuous-test-environments-builds?view=vsts

Could please tell me what is expected to find in the environments? Can we expect git? 7-zip? wget? Does it have a packet manager like Chocolatey or VCPKG for C++? Which environment variables are available to point us to tools?


FAIL: TestShutoffMultiDomainsRunning (17.51s)

this test is failing on testacc.
i will have a look

ok this was my internall issue fixed ( domain was not cleanup)


iOS : FPRNetworkTrace.m line 144 : __48-[FPRNetworkTrace updateTraceWithCurrentSession]_block_invoke

Step 0: Are you in the right place?

For issues or feature requests related to the code in this repository
file a GitHub issue.

If this is a feature request please use the Feature Request template.

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general (non-iOS) Firebase discussion, use the firebase-talk
google group.
For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support.
Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

Xcode version: 13.2.1_
Firebase SDK version: 8.4.0_
Installation method: `CocoaPods
Firebase Component: _____ (DynamicLinks, Installations, Analytics, RemoteConfig, Messaging, Crashlytics)
Target platform(s): iOS

[REQUIRED] Step 2: Describe the problem
The app is getting crash at user's end
Steps to reproduce:
Since the app is getting crash at user's end, we don't have a way to reproduce it
Relevant Code:
Crash Item	:	  Ios: FPRNetworkTrace.m line 144 : __48-[FPRNetworkTrace updateTraceWithCurrentSession]_block_invoke
Issue Details	:	Crashed: com.google.perf.sessionIds.networkTrace
0  libobjc.A.dylib                0x1f40 objc_msgSend + 32
1  FirebasePerformance            0x14544 __48-[FPRNetworkTrace updateTraceWithCurrentSession]_block_invoke + 144 (FPRNetworkTrace.m:144)
2  libdispatch.dylib              0x1e6c _dispatch_call_block_and_release + 32
3  libdispatch.dylib              0x3a30 _dispatch_client_callout + 20
4  libdispatch.dylib              0xb124 _dispatch_lane_serial_drain + 668
5  libdispatch.dylib              0xbc80 _dispatch_lane_invoke + 392
6  libdispatch.dylib              0x16500 _dispatch_workloop_worker_thread + 648
7  libsystem_pthread.dylib        0x10bc _pthread_wqthread + 288
8  libsystem_pthread.dylib        0xe5c start_wqthread + 8Crash Events
// TODO(you): code here to reproduce the problem

Thanks for reporting, @siddew201. The issue looks related to #8495 and already fixed on v8.6.0. Could you try updating your SDK version?


allow_cors option

The new option allow_cors::Bool=false will allow cross origin (CORS) requests to access the server via the "Access-Control-Allow-Origin" header.
I also changed the argument list to follow the documentation convection here: https://docs.julialang.org/en/v1/manual/documentation/

I can add a test if you like? https://github.com/tlienart/LiveServer.jl/pull/122 already tests that the headers appear in the response

Thanks Fons!


OpenVPN - route-gateway CSO option

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
In an OpenVPN Topology (subnet) configuration I set the Tunnel network to be a class B.
Within the CSO section I subsequently created individual directives for each common name that connects by assigning them smaller subnets and dedicated IP so as to divide the different users into groups and consequently creating special firewall rules.
Within the same CSO I set the directive "route-gateway " in the Advanced section to assign an IP from that subnet as gateway.
Everything works correctly with OPNSense version 23.1.x but in the new version 23.7 I can't find how to speficate this directive in the CSO section.
Describe the solution you like
Being that the lack of the Advanced section where the route-gateway directive can be set also impacts a Legacy OpenVPN instance, we request the possibility to have a dedicated section in the CSO page to reconfigure this option.
Describe alternatives you considered
no alternative identified

ok. since this is my first time reporting/requesting, should I put a comment on 6703 and close this one?

Yes, sounds like a plan.

ok thanks


Add noopener noreferrer to blank targets

This avoids tabnapping exploits.
See CWE-1022
@DavidResende0 Please review.

@DavidResende0 Let me double check that, but I think that's intentional as it allows for overriding the link in productized versions.


Perset account login failed!

Device is found and after logging into the smart home app, the found device appears again. After clicking next, an error message appears: Perset account login failed! The app shows that there has been a new login. Login data and login are correct.
Log:
Logger: midealocal.cloud
Quelle: custom_components/midea_ac_lan/config_flow.py:461
Integration: Midea AC LAN (Dokumentation, Probleme)
Erstmals aufgetreten: 11:03:57 (7 Vorkommnisse)
Zuletzt protokolliert: 12:42:19
SmartHome Cloud login failed for device 2625dxxxxxxxxx

Please enable debug for Midea AC LAN integration, wait for this error, disable debug and attach the log.
Note: it is better to drag the log into the comment (which will add it as an attachment) and not copy paste as it is hard to read logs in GitHub.
Thanks

Add the debug lines to your configuration.yaml ;-)


'yarn start serve' does not start the server

Hi,
When I ran the command - yarn start serve , the following shows up on the console, but the webserver is not running at all.
_$ nps serve
nps is executing serve : nps banner.serve && nodemon --watch src --watch .env
nps is executing banner.serve : ts-node --transpile-only ./commands/banner.ts serve

/ |/ _ \ '\ \ / / _
__ \  / |   \ V /  /
|/_|_|    _/ __|
[nodemon] 1.18.9
[nodemon] to restart at any time, enter rs
[nodemon] watching: E:\Work\TymePe\samples_server\express-typescript-boilerplate\src/**/* .env_
I tried telnetting using- telnet localhost 3000, telnet <IP_ADDRESS> 3000 and telnet <IP_ADDRESS> 3000 etc... but it says that the port is not open.
Connecting To <IP_ADDRESS>...Could not open connection to the host, on port 3000: Connect failed
Am I missing something?

I have also put the following statement in src/loaders/expressLoader.ts, but nothing is printed to the console.
export const expressLoader: MicroframeworkLoader = (settings: MicroframeworkSettings | undefined) => {
console.log('Server listening on port::', env.app.port);
Am I missing any configuration or set up steps? Please help.


Fix \n characters in the ErrorHandler stack trace.

The stack trace generated by the LineFormatter contains \n characters instead of newlines with ErrorHandler errors. This should fix it.

On some further checking, this might also be related to #366

AFAIK monolog never generates literal \n.. So unless you can figure out exactly where they come from in monolog, I would say that they must come from somewhere in your code. I don't really think replacing stuff in the output is a good idea. We do it for real new lines because those are special but I'm rather againts replacing other characters so I'll close this. If you find more details as to where they come from please do tell and we can always reopen.


"initializing the JS / TS language resources"

VSCode Version: 1.30
OS Version: Osx 10.14

Steps to Reproduce:
Every time I open a .js file is giving it. It keeps loading and eating processing.

Might be related, I also get this initializing the JS / TS language resources for very long time when openning project. Performance report which might be related https://github.com/Microsoft/vscode/issues/65857
VS Code is nearly useless now, slowest like never before :o

Hello guys! I was resolve this uninstalling vscode and all installed packages. After that I discovered that the error was in a package called color-exchange, when it uninstalls everything returns to normal.

Thanks. Please file an issue against that extension so that they can fix this


Where to pass ld flags when using drogon_ctl?

Hi, my first time with Drogon. Seems great.
I created a sample project with drogon_ctl and it works well but now I  need a function from curl lib and I dont know where to put or pass -lcurl. Usually makefiles have symbol LDFLAGS to do that...
Thank you
Alex

The project created by drogon_ctl uses cmake as the build configuration tool, please refer to here for using libcurl with cmake.
BTW, if you want to use http client utilities of curl lib, you could try the HttpClient of Drogon.

Thank you very much for these tips
(I am relying in libcurl to send email)

You can do that, but it's not recommended. you will lost the change to Makefiles after reconfigure your project with cmake.
All dependencies needed by drogon are managered by cmake, so basically you can't use c++ command to directly compile drogon project.
As for the email function, here is a simple SMTP plugin of drogon, you could try it out (the PR of it is create by me, fixed some issues).

Yes, I trried it already but when compiling it says that :
error: reference to ‘utils’ is ambiguous
70 |             m_uuid(utils::getUuid())
|                    ^~~~~

m_uuid(drogon::utils::getUuid())

m_uuid(drogon::utils::getUuid())

Now it compiles :-)
But can not send email:
(fake data here)
auto *smtpmailPtr = app().getPlugin();
auto id = smtpmailPtr->sendEmail(
"smtp://smtp.gmail.com",                  //The server IP/DNS
587,                          //The port
<EMAIL_ADDRESS>      //Who send the email
<EMAIL_ADDRESS>   //Send to whom
"Testing SMTPMail Function",  //Email Subject/Title
"Hello from drogon plugin",   //Content
<EMAIL_ADDRESS>      //Login user
"iiiiiiiiiii"                      //User password
);
  std::cout << "Email sent" << std::endl;

Message Email sent never appears on screen.

you should use it after app().run();
try to use the PR of it.

I am calling it in a rest endpoint:
void postMail(const HttpRequestPtr& req,std::function<void(const HttpResponsePtr&)>&& callback)
{
Sorry, what is a PR?

https://github.com/ihmc3jn09hk/SMTPMail-drogon/pull/1

? Do you mean that I have not the last source code? I am not understanding

this is a patch for the plugin.

Ok I am going to update it. Thank you. But can this 'plugin be used in a rest endpoint directly or should I use a extra thread?

an-tao, thank you very much for your help.
It is working now and no need for libcurl anymore.


merge release into master

Codecov Report

Merging #60 (ddc6a6e) into master (b20230e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     57.15%   57.15%
  Complexity       97       97
=========================================
  Files             5        5
  Lines          1090     1090
  Branches         62       62
=========================================
  Hits            623      623
  Misses          466      466
  Partials          1        1

Flag
Coverage Δ

IntegrationTests
57.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20230e...ddc6a6e. Read the comment docs.


I can't scroll childs when dropdown is opened

I'm using your dependency, i have a list of numbers to child, 1...12, but, shows just the 1 until 4, and i can't scroll, if my page have a bigger size, i can choose others numbers
I need scroll the list of items..

Device: iPhone 8
OS: iOS 13

I created a new pull request to fixed this problem, look and if is possible, accept, when you merge my changes (or if you prefer change by yourself), i close this issue

Thanks a lot ! I'll be looking at the MR in the next few days.

Thanks!! If you can see the faster possible i will appreciate a lot, because i'm using to job in this week i need upload the final version

@lucas-sesti v0.2.0 is available !

Thanks!!!

Created new pull request because i found an issue, if i create a few items and active the scroll, i can't scroll because the overlay doesn't have height. If you can update in the same urgency last issue, i appreciate a lot.


spatial indexing

The current implementation is very slow: around 1 to 2 fps with just 2 simple meshes (teapot and bunny). Time to experiment with spatial indexing!
static-kdtree is the frontrunner so far unless a solid range tree package pops up on npm.
Another optimization that would help is bounding boxes and bounding spheres, but that optimization can live in a layer above this module.

As suggested by mikolalysenko, this looks like it will work great: https://github.com/mikolalysenko/box-intersect


Can't re-log-in account

Hi! I would like to know the way of re-log-ining.
I log-ined my account a week ago. Then I can get about 100 pictures. Todoy I try to log-in the same account by this code, but I can't.
This account doesn't get banned, and is asked to register new password.
L = instaloader.Instaloader() L.login(my_user_name, password)

any (error) message or something while executing your script?
Anyway it is better to login once and save it in a session file. Next time use that session file.

Thanks for your comment!
Error message is

Login: Checkpoint required. Point your browser to https://www.instagram.com/challenge/action/~/ - follow the instructions, then retry

After displaying the message, "There is a possibility of unauthorized login from a third party." is desplayed in my instagram app.
And, I was asked to change its password.
After changing the password, I can't log-in this account whose password I changed then.


Rounding free function failure

static constexpr auto a = cnl::elastic_number<8, -4>{0.3125};
static constexpr auto b = cnl::convert<cnl::nearest_rounding_tag, cnl::elastic_number<4, -1>>{}(a);
static_assert(identical(cnl::elastic_number<4, -1>{0.5}, b),"Free rounding test1"); //Works

static constexpr auto c = cnl::convert<cnl::nearest_rounding_tag, cnl::elastic_number<4, -2>>{}(a);
static_assert(identical(cnl::elastic_number<4, -2>{0.25}, c),"Free rounding test2"); //Fails gives 0.75 as result.

@hbe72 could you try it now? Thanks

Tried, and seems to work.
However, I'm a bit puzzled why I can write
    static constexpr auto a = cnl::elastic_number<8, -4>{0.3125};
    static constexpr auto b = cnl::_impl::convert<cnl::nearest_rounding_tag, cnl::elastic_number<4, -1>>(a); // Computes
    static constexpr auto c = cnl::convert<cnl::nearest_rounding_tag, cnl::elastic_number<4, -1>, cnl::elastic_number<8, -4>>{}(a); //Compiles
    static constexpr auto d = cnl::convert<cnl::nearest_rounding_tag, cnl::elastic_number<4, -1>>{}(a); //Missing template parameter

The template specification for cnl::_impl::convert is a function, cnl::convert is a "functor". Can we get rid of the third template parameter or lift the _impl namespace from the function?

Would you consider adding following to cnl/_imp/rounding/convert.h ?
    template<typename Result, typename Input>
    struct convert<
             _impl::nearest_rounding_tag, Result, Input,
             _impl::enable_if_t<
                    std::is_floating_point<Result>::value && std::is_floating_point<Input>::value>> {
        constexpr Result operator()(Input const& from) const
        {
            return static_cast<Result>(from);
        }

Thus nearest rounding for a floating point - floating point conversion does just static cast from type to another. I can foresee that type agnostic code could have type conversions with rounding  with fixed_point types and no rounding with floating point types.
Of course it is true that we could round (or truncate) coming from double to float, but do we want to do things differently compared to current C++ with native datatypes?

In answer to your previous question about cnl::convert vs cnl::_impl::convert, convert is primarily a customization point. The _impl function is an internal helper which you're welcome to reimplement until I figure out customization. It's an open area right now. I'd like to ape what range-v3 does as @ericniebler has put a lot of thought into this topic. (There is also some interest from the embedded world in being able to customize much of CNL for exotic numeric types.) But I haven't gotten around to this task as multiword_integer is a more pressing issue. (People are always running out of bits as I'm sure you're aware!)

Also on the TODO list: convert<whatever_rounding_tag> with rounding_integer<> input and result.

I started testing what you proposed earlier
    static constexpr auto a = cnl::fixed_point<int, -4>{0.3125};
    using native_rounding_type = typename cnl::_impl::set_rounding<cnl::fixed_point<int, -1>, cnl::_impl::native_rounding_tag>::type;
    static constexpr auto b = static_cast<native_rounding_type>(a);
    static_assert(identical(static_cast<native_rounding_type>(0.5f), b),
              "cnl::convert<nearest_rounding_tag, fixed_point, fixed_point>");

Should this work, or did I find a bug?
The value of b is 0 after the static_cast and the static_assert fails.


Handle legal basis dimension for purposes

Is your feature request related to a specific problem?
https://github.com/ethyca/fidesplus/issues/1128 adds a legal basis dimension for purposes. There's already been some work to handle this for vendors, but we need to do the same work for purposes.
Describe the solution you'd like
After the backend is updated, we need to update all the fides-js code to split purposes up by legal basis. This will require:

updates to the cookie saving logic
updates to the UI to render multiple toggles for purposes

Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
https://github.com/ethyca/fides/issues/4209
Do we still want the legal basis filter to work in the same way for this? It has always felt like a filter dropdown to me, but it seems like it's really meant to totally switch the view.

Closed by https://github.com/ethyca/fides/pull/4234

moving to done


Failed to resolve import "ant-design-vue/dist/antd.css"

"@ant-design-vue/nuxt": "^1.4.5",
"ant-design-vue": "^4.2.5",
nuxt.config.ts
// https://nuxt.com/docs/api/configuration/nuxt-config export default defineNuxtConfig({   compatibilityDate: '2024-04-03',   devtools: { enabled: true },   modules: [     '@ant-design-vue/nuxt',   ],   ssr: false,   css: [     'ant-design-vue/dist/antd.css',     '~/app.scss',   ],   antd: {},   vite: {     css: {       preprocessorOptions: {         scss: {           // This will hide the warning message from console.           // https://sass-lang.com/documentation/breaking-changes/legacy-js-api/           silenceDeprecations: ['legacy-js-api'],         },       },     },   }, })

version
1.4.5 -> 1.4.4
sorrry

@xuanhen2013 Are there any plans to fix this issue or are there any workarounds?

@xuanhen2013 Are there any plans to fix this issue or are there any workarounds?

It has been merged but not yet released.

@xuanhen2013 ok, thanks.

1.4.6


Suggest we don't break tables over two pages when not necessary

E.g. Tables 26 and 27 are short but get broken, and doesn't save a page by doing so.
Chris - I see \clearpage is still used elsewhere, so is that what can be done?
I won't do anything, just wanted to note it.

Yes that’s what I figured we’d end up doing but I didn’t put any in because I knew we would have to redo it again anyway after adding things

Just mentioned it in case it ends up being a bigger issue than I thought. Extra \clearpages may actually help with #1109. Perhaps.

Also I just clicked on a Table 24 link and it went to the page before Table 24. No big deal but may be related also (Table 23 goes over two pages).

Going to close this, as we will figure it out as we finish up the cosmetics


Handle islocked() builtin from a method.

Setup lval_root from f_islocked().
Add function fill_exec_lval_root() to get info about executing method.
sync_root added in get_lval() to handle method member access.

The islocked() PR is similar and different than the lockvar PR.
The lockvar PR, in compile_lock_unlock() examined a string and determined
if the first token was something, scriptVar, member, argument that the
compiler could generate code to load into a register and get_lval() would
start with that.
The islocked() PR is a builtin function that takes a string. The string is
is the name of a variable, for example "l[0].o0[2]", which is handled at
runtime. To let get_lval() to do most of the work, when islocked() is used
in in a class/object method, and it looks like the first token is a member, it
sets the info in lval_root, including a new flag sync_root, that tells
get_lval() to process the first token "l" in the example without looking
if there is another token following.

damn, i wanted to include your comment into the commit message to make it more clear.
Thanks, anyhow.

To clarify the above comment (which is a loose interpretation of reality)
about the difference between lockvar and islocked().
(and so that I have something to remind me...)
Firstly :lockvar is an ex command, islocked() is a builtin function.
This example is used for the descriptions and generated the trace that follows.
vim9script

class C
  this.o0: list<list<number>> = [[0], [1], [2]]
  def LockIt()
      lockvar this.o0[0]
  enddef
  def CheckIslocked(): number
      return islocked("this.o0[0]")
  enddef
endclass

var obj = C.new()
obj.LockIt()
echo obj.CheckIslocked()

In the lockvar this.o0[0] case

compile_lock_unlock

examine string expr, decide to load "this" on stack for ISN_LOCKUNLOCK

compiler generates

load "this" onto stack, ISN_LOCKUNLOCK "this.o0[0]"

later execution of ISN_LOCKUNLOCK does

lval_root.lr_tv = "this" from top of stack
get_lval("this.o0[0]")

In the islocked("this.o0[0]") case

builtin func islocked("this.o1[0]")
runtime calls f_islocked

if executing in a class/object method, then
examine string, detect "this", and then
lval_root.lr_tv = executing object, set lval_root.lr_sync_root
get_lval("o1[0]")
sync_root signals that o1.[0] has implicit class/object in lr_tv

727.712450432 : LKVAR: compile_lock_unlock(): cookie 0x7fff49b771f0, name this.o0[0]
727.712454581 : LKVAR:    ... lookup_local: name this.o0[0]
727.712458189 : LKVAR:    ... INS_LOCKUNLOCK this.o0[0]
727.712464137 : LKVAR:    ... buf lockvar 2 this.o0[0]
727.712470674 : LKVAR: execute INS_LOCKUNLOCK isn_arg lockvar 2 this.o0[0]
727.712477227 : LKVAR: get_lval(): name: this.o0[0], lr_tv 0x560da92dd270 lr_is_arg 0
727.712481948 : LKVAR:    ...: GLV flags: NO_DECL
727.712487006 : LKVAR: get_lval() loop: p: .o0[0], type: object
727.712493032 : LKVAR:    ... loop: p: [0], '.' key: o0[0]
727.712500175 : LKVAR: get_lval_check_access(), cl_exec 0x560da9652930, cl 0x560da9652930, [
727.712507015 : LKVAR: get_lval() loop: p: [0], type: list
727.712516068 : LKVAR:    ... loop: p: , '[' key: 0
727.712523262 : LKVAR: do_lock_var(): name this.o0[0], is_root 0
727.712529905 : LKVAR: item_lock(): type list
727.712533672 : LKVAR: item_lock(): type number

727.712562994 : LKVAR: f_islocked(): name: this.o0[0]
727.712586557 : LKVAR: get_lval(): name: o0[0], lr_tv 0x560da93925f0 lr_is_arg 0
727.712593873 : LKVAR:    ...: GLV flags: NO_AUTOLOAD READ_ONLY NO_DECL
727.712598101 : LKVAR: get_lval() loop: p: [0], type: object
727.712601591 : LKVAR:    ... loop: name: o0[0], sync_root
727.712604977 : LKVAR:    ... loop: p: [0], sync_root key: o0[0]
727.712608615 : LKVAR: get_lval_check_access(), cl_exec 0x560da9652930, cl 0x560da9652930, [
727.712612299 : LKVAR: get_lval() loop: p: [0], type: list
727.712617799 : LKVAR:    ... loop: p: , '[' key: 0


Update config_file.cfg

Changes proposed in this PR:

Updating homepage!

Related Issues

#2

Review lab deployment
You are able to create quick deployments of the source branch for validation/testing.
Create issue comment:

/k8s-review -namespace <lowercase-value>

/k8s-review -namespace sandbox-demo


feat: spy.mockRevert

Description

Adds a new method mockRevert to spies. It's in the same vein as mockClear, mockReset, mockRestore - it is most similar to mockRestore, with the key difference being that it does not 'un-spy' mocks created with vi.spyOn().
See #6308 for discussion.

PR Checklist

[x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[x] Ideally, include a test that fails without this PR but passes with it.
[x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci. (I am waiting for playwright to install)

Documentation

[x] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Hey, I'd appreciate some input on the CI failing - node-20, macos-14 was passing before my rebase onto main 🤔

It's just flaky, don't worry

The team thinks it's better to restore the implementation in mockRevert instead of resetting it to a () => {} without adding a new method.

mockRevert is the function this PR adds - do you mean mockReset ?

Alright - I think I will close this for now, then, and open a new PR for that


Upgrade Apache DataSketches to latest version

Background
We're currently on DataSketches version 3.3.0, but the latest version is 6.0.0:
https://github.com/apache/datasketches-java/releases
Dependabot tried to upgrade this but it did not compile:

https://github.com/gchq/sleeper/pull/2397
https://github.com/gchq/sleeper/pull/1996
https://github.com/gchq/sleeper/pull/2010

Description
We'd like to upgrade to the latest version of Apache DataSketches.
We told Dependabot to ignore the dependency in its PR, so we should make sure we undo that as part of this issue.
Analysis
The compilation failures seem to be in our SketchSerialiser class.
Some of the failures are classes which were moved to another package in DataSketches.
Some of them are changes to the method signatures being more type-safe. Some are in our ArrayOfByteArraysSerSe which needs to implement more methods than it does right now.

The upgrade broke bulk import, because Spark Catalyst depends on version 3.3.0. We need to wait until Spark upgrades.


[FeatureRequest] Implement FileSystemProvider file channels

For example SMBFileSystemProvider currently does not override FileSystemProvider.newFileChannel() and generates a UnsupportedOperationException.
I think this could be implemented using SmbConstants.FILE_NO_SHARE "somehow".

The main-motivation of the request is to be able to perform multiple read/write operations on a file while holding the file's lock to ensure they are 'atomic'.
For a local file one would create a FileChannel and obtain a FileLock from it. For example like:
Path file = ... // obtain the Path of the file to operate on
Set<StandardOpenOption> rwc = Set.of(StandardOpenOption.READ, StandardOpenOption.WRITE, StandardOpenOption.CREATE);
try (FileChannel channel = FileChannel.open(file, rwc); FileLock lock = channel.lock()) {
	readAndWriteFromSeekableByteChannel(channel);
}

This does not work for a Path that uses the SMBFileSystem because the SMBFileSystemProvider does not implement FileSystemProvider.newFileChannel() as mentioned initially.
It would be of course nice, if you would implement the corresponding methods but I assume this will require a medium/large amount of work.
A much simpler solution for this use-case would be to add support for the ExtendedOpenOption from the package com.sun.nio.file to SMBFileSystemProvider.newByteChannel(). Those options would only have to be mapped to corresponding combinations of SmbConstants and then passed to the SeekableSMBByteChannel and further to SmbRandomAccessFile.
Instead of using enum constants from com.sun.nio.file (where I'm not sure if this might become strongly hidden in future Java-versions) that have opposite meaning, it could be simpler to create own implementations of OpenOption that map 1:1 to the corresponding SmbConstants.
So in the end one could call the following (or similar) to obtain a SeekableByteChannel that is locked while being open:
SeekableByteChannel channel = Files.newByteChannel(lockFile, SmbOpenOption.FILE_NO_SHARE);

@ppanopticon would you appreciate a PR that implements what I have described?


read defaults from environment too?

hi,
I think some defaults for carbonate could be read from the environment too, e.g. the storage paths or the config file location. This would make it easier to e.g. switch to another config for all carbonate tools from the command line or more complex wrappers. If there's interest I'll be happy to submit a PR, what do you think?
thanks,
filippo

Seems reasonable to me. What situations are you hitting where it would be easier to set an envvar rather than pass the value through as a command line arg? The only things in carbonate.conf are cluster specific, so I assume you mean to use envvars to define defaults for things like CONFIG_FILE and CLUSTER.
If the envvars override the CLI defaults, that seems quite logical and would DRY up any wrappers. A PR would be great.

precisely, config file would be the most useful one, basically util.common_parser. I like how concise your README.md examples are and would like to replicate that but with arbitrary config paths. re: overriding yes environment would override CLI default only when used. Minimal PR is #49


Add partner telemetry flag

Adds a query parameter that lets you add a custom "partner" property to all of the telemetry items that are logged to app insights. The purpose of this feature is to let us differentiate between traffic generated by partners that link to or embed us; think of it as a manual referrer property that can be embedded in a URL. This parameter is added to all tick events.
url should look like this:
arcade.makecode.com/?partner=partnerName

Right now I am not removing the query parameter from the URL. I can do that, though, if we want.
Here is a test upload:
https://arcade.makecode.com/app/088c007a20a09fcee83221eeda1df6c9dd2a1f5b-590b47925d

Lets hotfix to microbit.


[OpenAI] Introduce a new option class for the streaming methods, getCompletionsStream and getChatCompletionsStream

Rethink and redesign the CompletionsOption and ChatCompletionsOption classes.
Since we have separate method for both of streaming and non-streaming completions and chat completions methods, we should separate the optional classes into ChatCompletionsOption and a new ChatCompletiondsStreamOption, as well as CompletionsOption and a new CompletionsStreamOption.
For example,

ChatCompletionsStreamOption should have stream=true by default and include all parameters related only to streaming.
ChatCompletionsOption should not include parameters related only to streaming.

This proposal is not favored. Instead, add the class property accessor helper.


Incompatibility issue with SQLAlchemy >= 1.4.0 and association model

Using latest flask-admin version 1.5.8 and upgrading SQLAlchemy python package from version 1.3.x to >= 1.4.0 causes the following SAWarning warnings. If I downgrade to latest SQLAlchemy 1.3.x version, the warnings disappear again, so there seems to be some kind of incompatibility related with return model._sa_class_manager.mapper.iterate_properties.
publisher-dev-app | /usr/local/lib/python3.9/site-packages/flask_admin/contrib/sqla/view.py:354: SAWarning: relationship 'User.chapter_reactions' will copy column user.id to column chapter_reaction.user_id, which conflicts with relationship(s): 'Chapter.reacted_by' (copies user.id to chapter_reaction.user_id), 'User.reacted_chapters' (copies user.id to chapter_reaction.user_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards.   To silence this warning, add the parameter 'overlaps="reacted_by,reacted_chapters"' to the 'User.chapter_reactions' relationship.
publisher-dev-app |   return model._sa_class_manager.mapper.iterate_properties
publisher-dev-app | /usr/local/lib/python3.9/site-packages/flask_admin/contrib/sqla/view.py:354: SAWarning: relationship 'ChapterReaction.user' will copy column user.id to column chapter_reaction.user_id, which conflicts with relationship(s): 'Chapter.reacted_by' (copies user.id to chapter_reaction.user_id), 'User.reacted_chapters' (copies user.id to chapter_reaction.user_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards.   To silence this warning, add the parameter 'overlaps="reacted_by,reacted_chapters"' to the 'ChapterReaction.user' relationship.
publisher-dev-app |   return model._sa_class_manager.mapper.iterate_properties
publisher-dev-app | /usr/local/lib/python3.9/site-packages/flask_admin/contrib/sqla/view.py:354: SAWarning: relationship 'Chapter.reactions' will copy column chapter.id to column chapter_reaction.chapter_id, which conflicts with relationship(s): 'Chapter.reacted_by' (copies chapter.id to chapter_reaction.chapter_id), 'User.reacted_chapters' (copies chapter.id to chapter_reaction.chapter_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards.   To silence this warning, add the parameter 'overlaps="reacted_by,reacted_chapters"' to the 'Chapter.reactions' relationship.
publisher-dev-app |   return model._sa_class_manager.mapper.iterate_properties
publisher-dev-app | /usr/local/lib/python3.9/site-packages/flask_admin/contrib/sqla/view.py:354: SAWarning: relationship 'ChapterReaction.chapter' will copy column chapter.id to column chapter_reaction.chapter_id, which conflicts with relationship(s): 'Chapter.reacted_by' (copies chapter.id to chapter_reaction.chapter_id), 'User.reacted_chapters' (copies chapter.id to chapter_reaction.chapter_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards.   To silence this warning, add the parameter 'overlaps="reacted_by,reacted_chapters"' to the 'ChapterReaction.chapter' relationship.
publisher-dev-app |   return model._sa_class_manager.mapper.iterate_properties

The models are defined as follows:
class BaseModel(db.Model):
    __abstract__ = True

    id = db.Column(db.Integer, primary_key=True)
    created = db.Column(db.DateTime, nullable=False, server_default=UTCNow(), index=True)
    updated = db.Column(db.DateTime, onupdate=datetime.utcnow, index=True)

class User(BaseModel):
    username = db.Column(db.String(25), nullable=False, unique=True, index=True)
    password = db.Column(db.String(128), nullable=False)

    # other fields omitted for brevity

    reacted_chapters = db.relationship(
        'Chapter', secondary='chapter_reaction', backref=db.backref('reacted_by', lazy='dynamic'), lazy='dynamic')

class Chapter(BaseModel):
    title = db.Column(db.String(120), nullable=False)
    slug = db.Column(db.String(123), nullable=False, unique=True, index=True)
    text = db.Column(db.Text, nullable=False)

    # other fields omitted for brevity

class ChapterReaction(BaseModel):
    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'), nullable=False, index=True)
    user = db.relationship(
        'User', backref=db.backref('chapter_reactions', lazy='dynamic', cascade='all, delete-orphan'))

    chapter_id = db.Column(db.Integer, db.ForeignKey('chapter.id', ondelete='CASCADE'), nullable=False, index=True)
    chapter = db.relationship('Chapter', backref=db.backref('reactions', lazy='dynamic', cascade='all, delete-orphan'))

    # other fields omitted for brevity

    __table_args__ = (db.UniqueConstraint('user_id', 'chapter_id', name='unique_user_chapter_reaction'),)

The admin model is defined as follows:
class ChapterReactionModelView(ModelView):
    column_default_sort = ('created', True)
    column_filters = ['created', 'updated', 'reaction', 'created', 'updated', 'id']
    column_list = ['user', 'chapter', 'reaction', 'created', 'updated', 'id']
    column_searchable_list = [
        'id',
        'user.name', 'user.surnames', 'user.email', 'user.username',
        'chapter.title',
    ]

These issues also make flask-admin completely incompatible with sqlalchemy 2.0, which was released today

member_database/__init__.py:22: in <module>
    from .admin_views import create_admin_views
member_database/admin_views.py:6: in <module>
    from flask_admin.contrib.sqla import ModelView
../../../.cache/pypoetry/virtualenvs/member-database-caolbd7Z-py3.10/lib/python3.10/site-packages/flask_admin/contrib/sqla/__init__.py:2: in <module>
    from .view import ModelView
../../../.cache/pypoetry/virtualenvs/member-database-caolbd7Z-py3.10/lib/python3.10/site-packages/flask_admin/contrib/sqla/view.py:18: in <module>
    from flask_admin.contrib.sqla.tools import is_relationship
../../../.cache/pypoetry/virtualenvs/member-database-caolbd7Z-py3.10/lib/python3.10/site-packages/flask_admin/contrib/sqla/tools.py:11: in <module>
    from sqlalchemy.ext.associationproxy import ASSOCIATION_PROXY
E   ImportError: cannot import name 'ASSOCIATION_PROXY' from 'sqlalchemy.ext.associationproxy' (/home/maxnoe/.cache/pypoetry/virtualenvs/member-database-caolbd7Z-py3.10/lib/python3.10/site-packages/sqlalchemy/ext/associationproxy.py)


Create role openldap

Refs:

https://groups.google.com/g/mozilla.dev.tech.ldap/c/Ast6WzQbgsQ
https://www.gnupg.org/blog/20201018-gnupg-and-ldap.html
https://www.zytrax.com/books/ldap/
http://www.sampierson.com/articles/ldap-setting-up-an-address-book-that-evolution-likes
https://github.com/roundcube/roundcubemail/wiki/Configuration:-LDAP-Address-Books
https://keytalk.com/applications/hardened-open-ldap-s-mime-address-book-key-server
https://docs.iredmail.org/use.openldap.as.address.book.in.outlook.html
https://fastmail.blog/2008/08/07/ldap-access-to-address-book/
https://annvix.com/using_openldap_as_an_address_book
https://www.openldap.org/faq/data/cache/62.html
https://www.centlinux.com/2018/06/create-global-addressbook-with-openldap.html?m=1
https://srscctek.com/myfaq/content/2/79/en/openldap-and-phpldapadmin-address-book.html#:~:text=Adding address book entries&text=The LDIF file you just,entry in the address book.&text=In the next screen - Select,select Generic%3A Address Book Entry.
https://www.brennan.id.au/20-Shared_Address_Book_LDAP.html
https://wiki.gnupg.org/LDAPKeyserver
https://lists.gnupg.org/pipermail/gnupg-users/2006-February/028058.html
https://serverfault.com/questions/539742/how-do-you-enable-the-storing-of-gpg-pgp-keys-in-openldap
https://github.com/sp4ke/ldap-openpgp-keyserver/blob/master/schema/pgp-keyserver.schema

Closing, duplicate of #70

Closing, duplicate of #70


Transition videos not working

If use the transition video functionality, the source just disappears offscreen after playing the first file

This i most likely related to the other issue that broke with newer OBS. It's currently breaking when trying to play multiple videos. I don't have an ETA for a fix as I'm very busy and still trying to figure out something that works. My only advice right now is to install an older version of OBS that works

Appreciate the work. Just downgraded to 27.1.3 for now, everything runs fine.

I post status updates in my Guilded. but keep an eye on the project. Next version I release will be aimed at fixing this


Clean up Clap usage

What should be done?
There are a couple of things related to clap that we could clean up.

Right now we receive all parameters as strings but we should be able to set parsers for custom types (like AccountId), making the code a bit cleaner and the API clearer as well.
It seems we are maintaining 3 enums for AccountStorageMode (one for Clap, one for the Client and the miden-objects one. This can be a bit confusing. I believe the Client one could be removed and we could just use miden-objects's enum (re-exporting if necessary), unless there is a reason I'm missing.

How should it be done?
Writing parsers for basic structs that we use on clap (as strings right now)
When is this task done?
When we can define our custom types on Clap commands.
Additional context
No response

Right now we receive all parameters as strings but we should be able to set parsers for custom types (like AccountId), making the code a bit cleaner and the API clearer as well.

How would this interact with #274  and #196?

Closed by #348


[Support Job Resource] Add job controller

Support job resource object reconcile.

/assign @k82cn

/lgtm
/approve


Potential cni e2e-simple breakage due to app http probe rewrite

https://github.com/istio/istio/pull/10344
@tiswanso

This PR is causing e2e-simple to fail when run with auto-sidecar injection. Seems like the new helm chart param sidecarInjectorWebhook.rewriteAppHTTPProbe should default to true (maybe only when auth is enabled?).
The istio-cni release-1.1 nightly is failing due to it.

To add info on what I've seen with this change... I think this has introduced a delta (at least for e2e-simple) for the e2e test framework run with sidecar injection enabled v. the default with istioctl kube-inject. I don't see how the e2e-simple would pass without the rewriteAppHTTPProbe=true so, I'm suspecting that the e2e test is running with it set for the istioctl kube-inject case. IMO, that delta in behavior is really bad and should be fixed by either changing the default for the flag or by having the makefile set it all the time for the e2e tests.

I think pilot/pkg/kube/inject/app_probe.go L51-53 is what changed the default behavior--at least compared to master. I'm not familiar with what was happening for the liveness probes prior to the existence of app_probe.go.

RewriteAppHTTPProbe should be default to false right? We only change probe when it's true.
How to reproduce the failure you mentioned?

@tiswanso mentioned the delta is about release-1.1 vs master. Not the delta before and after this feature.
Also it's e2e failed when the feature is turned off, which is really weird since we shouldn't depend on this feature to be on to have existing test pass. We need to understand that part.

The issue with e2e-simple is seen when run with sidecar-injector e.g:
E2E_ARGS="--kube_inject_configmap=istio-sidecar-injector" make test/local/auth/e2e_simple

I see the issue on baremetal and on CircleCI with kubeadm-dind-clusters, even without Istio CNI enabled.  The e2e-simple passes if run like this:
EXTRA_HELM_SETTINGS="--set sidecarInjectorWebhook.rewriteAppHTTPProbe=true" E2E_ARGS="--kube_inject_configmap=istio-sidecar-injector" make test/local/auth/e2e_simple

The failures seen is due to a service crashlooping due to the liveness probe failure.

nginx-default-http-backend service is created by the e2e-simple test but the deployment goes into crashloop due to liveness probe failures

istio-system   pod/nginx-default-http-backend-7ff6d875f5-zxpmh                  1/2       CrashLoopBackOff   6          9m        <IP_ADDRESS>   kube-node-2

Name:           nginx-default-http-backend-7ff6d875f5-zxpmh
Namespace:      istio-system
Node:           kube-node-2/<IP_ADDRESS>
Start Time:     Sun, 16 Dec 2018 09:58:53 +0000
Labels:         app=nginx-default-http-backend
                pod-template-hash=3992843191
Annotations:    sidecar.istio.io/status={"version":"17db20f8cc7828c840cf703a266a113165a26f3fc4ddda7fc9ddd1083d2ade30","initContainers":null,"containers":["istio-proxy"],"volumes":["istio-envoy","istio-certs"],"imageP...
 Container will be killed and recreated.

Okay, now I understand. Let me try to summarize a bit.

I implemented the http probe rewrite to support mtls case, only for istioctl kube-inject.
Some auth tests start to depend on that. nginx container probing can work for auth enabled test.
I add a helm flag to not turn on this behavior by default.
The test depending on this feature starts to fail.

If so, given we don't want to turn on this feature by default for now, then we should figure out where we add test to depend on this feature, and revert that change. @tiswanso do you know where is the change on the test config side?

The option is to enable this feature on for auth related test. However, I prefer to simplify things and turn it off everywhere before we have e2e test for this feature.

I think I figured it out.

probe rewrite was checked in as #9266
istio/cni repo run e2e_simple with auth enabled, https://github.com/istio/cni/pull/62

Should cni run with authn_enabled = false instead? Can we change that?

istio/cni could run with  rewriteAppHTTPProbe = true.  But my point is everyone running the e2e-simple with auth enabled needs that setting, regardless of CNI.  Is that the case as well for any mTLS enabled service with liveness probes?
I need to re-review the mTLS config in the system but is the proper fix one of the following:

enable it in the Makefile generate_yaml istio-auth.yaml target?
default the values.yaml of rewriteAppHTTPProbe to the value of global mTLS flag
have the sidecar injector code check a flag for mTLS enabled on the service.

I'm thinking anyone else would hit this with auto-sidecar inject + mTLS services + liveness probes.

I prefer smallest needed change to get things unblocked. I'll send a PR to change https://github.com/istio/cni/blob/master/.circleci/run_e2e.sh with helm --set sidecarInjectorWebhook.rewriteAppHTTPProbe=true.
Once we have an e2e test we turn it on for istio-auth.yaml.

/cc @costinm
Hold on. We found that e2e-simple tests did run with auth-enabled on prow, and they passed. For example, https://circleci.com/gh/istio/istio/272588?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
So we need to figure out why cni tests have to depend on this while the rest don't have to. Don't they also have the same nginx probe as well? There must be something different on the test runs.

@tiswanso I ran the test myself without specifying kube-inject's sidecar injector map, basically to simulate the e2e-simple with istio/istio run.
$ git checkout release-1.1 && E2E_ARGS=' -skip_cleanup=true' make test/local/auth/e2e_simple
NAME                                          READY     STATUS             RESTARTS   AGE
a-f4fb9d68f-cs7fs                             2/2       Running            0          8m
echosrv-deployment-1-59d9c8c8bb-7h9vt         2/2       Running            0          14m
echosrv-deployment-2-d6f5fd5c-whxxg           2/2       Running            0          14m
istio-citadel-7f4df674c-zpdmm                 1/1       Running            0          16m
istio-cleanup-secrets-1215a-rtc5d             0/1       Completed          0          16m
istio-egressgateway-654c9c65fb-gvmfp          1/1       Running            0          16m
istio-galley-858c7c58dd-76l8m                 1/1       Running            0          16m
istio-ingressgateway-785c996c47-nw69t         1/1       Running            0          16m
istio-pilot-769bcb6d9-lrghw                   2/2       Running            0          16m
istio-policy-569955585f-h4xpp                 2/2       Running            2          16m
istio-security-post-install-1215a-4wtq6       0/1       Completed          0          16m
istio-sidecar-injector-788d79d5f5-kbggc       1/1       Running            0          16m
istio-telemetry-655f7894fb-jqtnm              2/2       Running            2          16m
nginx-default-http-backend-56889fc4f6-hwz5h   1/2       CrashLoopBackOff   6          8m
nginx-ingress-controller-6d9c95f9f6-q9gnd     2/2       Running            0          8m
prometheus-7fcd5846db-nlwtc                   1/1       Running            0          16m
raw-cli-deployement-6f4459df-p8xpg            1/1       Running            0          14m
t-6769fd7bc6-wpm2c                            1/1       Running            0          8m

$ kc get deployment nginx-default-http-backend  -n istio-system -oyaml
https://gist.github.com/incfly/984196d9b155b6351ff249891d1ca2c5

You can see that the app container's probe is not modified, but the containers are still ready.

@tiswanso I ran the test myself without specifying kube-inject's sidecar injector map, basically to simulate the e2e-simple with istio/istio run.
What I found:

The nginx application itself http probe is not rewritten, still at port 8080, original path. rewriteAppProbe is not taking effect.
However, I did see the pod crash looping after a while and then came up.
The test passed.

I think it's simply the race condition contribute to the flakiness that if TestNginx can run before kubelet think it's unhealthy, then it passed.
I think we should still flag guard feature but rewrite the testdata/nginx.yaml.tmp using curl or something else.
WDTY?

https://gist.github.com/incfly/984196d9b155b6351ff249891d1ca2c5


Line Breaks

Line Breaks are not detected

What do you mean? Escaping a line break with \n is not working?

Will close until further information is provided.


CLI option to validate jobfiles

Today, we ran into an issue where a developer of our team entered an invalid time pattern, preventing our jobber container to start. Thinking about how to prevent this kind of errors in the future, I thought about validating the jobfile during CI without running the jobfile. Is such an option available? If not, please consider this a feature request.

You can do this with jobber test [JOB NAME] when inside a container's runtime terminal /bin/sh

Thanks for the suggesting. I've tried it today, with this result:
$ jobber test CronCleanupSessions
Running job "CronCleanupSessions"...
Jobber doesn't seem to be running for user $ME.
(No socket at /var/jobber/$UID/cmd.sock.): stat /var/jobber/$UID/cmd.sock: no such file or directory

Jobber is not running yet, as we want it to be during the CI build. jobber test would only be usable when the container has been deployed, but I want to prevent deploying an invalid Yaml file. An option to validate a Yaml file syntactically and semantically without an active daemon would still be desirable.


💡 RFC: Allow importing CSS/HTML/JSON in JS resulting in the import becoming part of the JS module

Motivation
Until we get CSS Module Scripts, when developing webcomponents with snowpack, authors face the problem how to integrate CSS into their components' shadow trees. Neither of the two options of using CSS in snowpack is any helpful here because both (CSS and CSS Modules) result in being added to a bundle that is meant to be used for document and obviously unavailable in any shadow root.
With webpack, using either raw-loader or style-loader authors have the option to use constructed stylesheets like this:
// import styles into a Javascript variable, when building becomes part of the JS
// I could also author the styles right here, but I want syntax support so the CSS
// should be authored in an external file
import styles from './foo-bar.css';

// create a constructed stylesheet using the imported CSS
const styleSheet = new CSSStyleSheet();
styleSheet.replaceSync(styles);

class FooBar extends HTMLElement {
  static get styleSheet() {
    return styleSheet;
  }

  constructor() {
    super();
    this.attachShadow({ mode: 'open' });
    this.shadowRoot.adoptedStyleSheets = [...FooBar.styleSheet];
  }
}

customElements.define('foo-bar', FooBar);

Since the main selling point of snowpack over webpack is the much faster module based HMR for development, using webpack's way with raw-loader or style-loader would just mean going back to webpack, also for the development server.
I hope I'm just missing that this is already supported; if not and there are no plans to incorporate this, snowpack sadly will not be applicable for vanilla webcomponents development.
Proposed solution
Implement importing CSS in JS in a way that results in the CSS becoming part of the JS module/bundle.
Detailed design
I am not a snowpack implementer, so I have no clue as of what the detailed design would have to look like.
Open questions

The same need exists for HTML imports as well. Currently authors are forced to inline HTML in their Javascript, which is a poor developer experience.

The same need exists for JSON imports as well. Currently authors are forced to inline JSON in their Javascript, which seems less than ideal with regard to maintenance and authoring.

Help make it happen!

[ ] I am willing to submit a PR to implement this change.
[ ] I am willing to submit a PR to implement this change, but would need some guidance.
[X] I am not willing to submit a PR to implement this change.

I've broadened the issue because all three (CSS, HTML, JSON) have the same issues with regard to maintenance and developer experience. The CSS part to me though is by far the most important one.


Script editor text clipping through UI

Operating system or device, Godot version, GPU Model and driver (if graphics related):
2.1.4 (This didn't happen in 2.1.3)
Ubuntu 16.04
Issue description:
Text clips through the bottom of the script editor
Steps to reproduce:
Write some code and open the Output beneath the script editor and try to resize it to see how the text clips through.
In the second picture i just grabbed the border and started resizing till the text started clipping through.

Duplicate of #10738, fixed in 2.1 branch already.


Prevent Multiple form submissions

Should add loading for form's buttons to prevent multiple click.
You can see problem by double clicking Setup page's button.

for Interactive pages we can easily disable multiple form submit. but for ssr pages we need to disable form by integrating with beforeenhanceload and afterenhanceload...


change title

:star: PR built and available in a preview environment icf-jx-demo-node-quickstart-pr-1 here


[Feature] Force a rebuild of the flink job's image for including the latest base image change

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Flink Base Docker Image Config on StreamPark remains as the same, but I rebuild the base image and StreamPark couldn't know.  If I start the application and the application docker image won't include the new base image. It will use the old application docker image.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can try adding this parameter when starting the job:  -Dkubernetes.container.image.pull-policy=Always


Swedish translation for Netflix plugin addon

Swedish translation for Netflix plugin addon

Thank you very much. I´ll merge this once I finished the refactoring I´m currently in the middle of.


How can I use the use the compiled js files instead of the src files?

Hey @jvandemo , this is a great and probably the best generator for Angular 2 libraries out there. You have done a great job. So thanks.
Second, I created a package and installed in my Angular 2 web application. Now when I import it, it seems like it is loading the .ts files instead of the .js generated bundle. I guess we actually want to used the compiled files instead? Or did you meant to export the .ts files to allow the user to create one unique bundle at the end?
PS: I didn't know if I should publish the question here or in StackOverflow, if needed I can delete this issue and migrate the question there.

@jdjuan,
TL;DR
It's actually using the transpiled .js files because of the main property in package.json. That's where Webpack is resolving the actual import.
For the curious...
Try this to check it yourself:

Create app with generator: yo angular2-library. Let's say you go with name ngx-library.
Eventhough the dist folder is generated, go ahead and transpile files again: npm run tsc
Create a new Angular app. Let's assume you use angular-cli. ng new hello-world
Run npm link inside /ngx-library, and npm link ngx-library inside /hello-world to have your library available inside your Angular app node_modules folder.
Import your new SampleModule module into app.module (add to decorator imports as well). If you have problems when running ng serve, try adding the library to decorator as SampleModule.forRoot().
Create <sample-component></sample-component> in app.component.html. Run ng serve. It should show an h1 with text "Sample Component". Our library is working.
Now go back to /ngx-library and change sample.component.ts to have a different selector, say selector: 'sample1-component'. No need to npm link again, it's automatically update. Don't transpile yet.
Refresh browser. Angular shouldn't be complaining about sample-component not being declared, because its references are the compiled files. This is where you realize you're actually using the transpiled .js files because sample.component.ts no longer declares 'sample-component' as its selector.
Transpile library again npm run tsc.
Refresh browser. Angular should now complain about sample-component not being declared.
Change <sample-component></sample-component> to <sample1-component></sample1-component>.
App should work now and 'Sample Component' showing up.

For the more curious...
Try removing "main": "./dist/index.js" from package.json and change the same component selector. The SampleModule import now resolves to the source .ts files.

Awesomeeeeeee!, you should get a reward for this explanation. Thank you very much @caroso1222 this solves my initial concern.
Hopefully next time opens a related issues it can be referenced here. (y)

@caroso1222 — Thank you so much for writing that down. This will help clear up a lot of confusion 👍
@jdjuan — The files that are used depend indeed on the environment that you are in. Some environments use other keys from your package.json file than others (e.g. node, webpack, TypeScript, Closure, etc).
The Angular team is currently working on figuring this out and as soon as there are official recommendations, we will also update this generator to reflect them.
Thanks again for your feedback, much appreciated!


Support Windows

We want to support Windows by sold 3.0.

Will windows version be a drop-in replacement for msvc link.exe? Will it support an incremental linking?

Yes and no. It'll be a drop-in replacement, but it won't support incremental linking. We'll instead make the regular linking extremely fast so that users don't even think about incremental linking.

Definitely will be buying a licence when Windows is supported. Fantastic tool.

Hi, I'm really interested in adding Windows x86_64 support and would be eager to contribute if needed. Could you share the current status of Windows support and what steps would be required to implement it?
As a Rust developer, I've noticed that incremental compile times can take up to 10 seconds for some projects, which impacts the development experience. I'm particularly interested in enabling a seamless "hot reload" workflow for Rust development, and I believe this linker could play a key role in achieving that.


ES6 export option for package @azure/msal-common

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
Not Applicable
Public or Confidential Client?
Public
Description
Related to #5274 https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/5274
Currently, @azure/msal-common does not ship an ESM build of the library. That means that tree-shaking is not possible for consumers of @azure/msal-common. With tree-shaking, we could significantly reduce the bundle size of consumer projects, including the OneNote Meeting Notes application. msal-common is currently one of the largest contributors to our bundle at around 121 KB parsed.

Given that the current recommendation for the size of an entry point bundle is 244KB according to webpack, this represents half of size of a typical app entry point. With both msal-browser and msal-common together, we've already taken up 249KB, more than the recommended entry point bundle size, even without any app code whatsoever.

This is a bulky library and adding ES6 exports make a very big difference to many apps that use it.
Source
Internal (Microsoft)

Closing as duplicate of #5724

Is this planned for the react bindings? Currently trying to reduce our bundle size and MSAL accounts for 60% of the entire bundle.

Yes, we have plans to, no decided deadline yet though. Will reopen this to track. cc @EmLauber

A beta of the v3 version of msal-browser and beta of msal-react v2 are released which should be exporting ES2020 modules. Can you try that out and let us know if that resolves this issue? Thanks!


ENH: trial implementation of DecidableSets

Nobody commented on #223, so I went ahead and implemented it.

Thanks, merging!


Feature request: Delete test sessions in the web-based interface

I did some experiments with a custom keyword I wrote in Java and had to update my JAR several times. For each iteration I used the Replay action to rerun the tests, which were executed in a new test session. Now that the keyword works as desired I want to delete those test sessions, but that action is not available.

If you want to delete all session information, you can delete the entire db directory in the server's working directory and restart the server. The server will create a fresh DB next time it starts.

depending on your file locations iam using this "delete.bat" which i can run it or schedule it.
echo deleting file
del "C:\projects\opentest\server\logs*." /s /f /q
echo Logs deleted!
del "C:\projects\opentest\server\uploads\screenshots*." /s /f /q
echo Server screenshots deleted!
del "C:\projects\opentest\server\db\sessions" /s /f /q
echo Server sessions deleted!
del "C:\projects\opentest\actor-web\out\screenshots*.*" /s /f /q
echo Actor screenshots deleted!
echo Done!

@wisam2013 I believe you also need to restart the server after deleting the files, for this to work.
Please not that there are some recently introduced undocumented parameters you can use in your server.yaml to clean-up old test session information from the database: sessionHistoryMaxCount, sessionHistoryMinCount and sessionHistoryAgeDays.
# Maximum number of test sessions that will be stored in the server's DB
sessionHistoryMaxCount: 500

# Minimum number of test sessions that will be stored in the server's DB
sessionHistoryMinCount: 50

# Maximum age of test sessions that will be stored in the server's DB. Older
# sessions will be removed when they exceed the specified age.
sessionHistoryAgeDays: 60

@wisam2013 I believe you also need to restart the server after deleting the files, for this to work.
Please not that there are some recently introduced undocumented parameters you can use in your server.yaml to clean-up old test session information from the database: sessionHistoryMaxCount, sessionHistoryMinCount and sessionHistoryAgeDays.
# Maximum number of test sessions that will be stored in the server's DB
sessionHistoryMaxCount: 500

# Minimum number of test sessions that will be stored in the server's DB
sessionHistoryMinCount: 50

# Maximum age of test sessions that will be stored in the server's DB. Older
# sessions will be removed when they exceed the specified age.
sessionHistoryAgeDays: 60

Of course I can easily delete all sessions. I believe that it is useful to be able to delete individual sessions though.

I will go ahead and add a menu to delete one single session. This feature doesn't exist yet because it is not very useful for the vast majority of people and scenarios.

Thank you very much Adrian!


the wordpress redirect causes jetpack to fail (fix proposed)

the wordpress example has:
to {path} {path}/ /index.php?_url={uri}
this redirect pattern will cause jetpack features (such as related posts) to fail because jetpack uses a flat query and not the url= pattern.  It should be fixed to this:
to {path} {path}/ /index.php?{query}
the corrected redirect pattern allows jetpack to run features (related posts, for one) and tends to allow nonstandard API requests work again.   I didn't want to fork the entire examples project just to propose this one change

Thanks for the note, John! I haven't verified this but I'll take your word for it that this still works for WordPress users without jetpack.

It does.   All the other rewrites work fine with this.


#1 Added more fields to lucene index

Added Fields "feature class", "feature code", "population","country code", "admin1 code", "admin2 code" c
https://github.com/chrismattmann/lucene-geo-gazetteer/issues/1

Thanks @smadha ! great work


Regression: re_bytes_find / re_bytes_find_static fail to compile with nightly and 3.0.0

error: no method named `end` found for type `(usize, usize)` in the current scope
   --> src/parser/pgn.rs:127:1
    |
127 | named!(pub symbol_token, re_bytes_find_static!(r"[[:alnum:]]{1}[0-9A-Za-z#=:+_-]*"));
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro outside of the current crate

error: no method named `start` found for type `(usize, usize)` in the current scope
   --> src/parser/pgn.rs:127:1
    |
127 | named!(pub symbol_token, re_bytes_find_static!(r"[[:alnum:]]{1}[0-9A-Za-z#=:+_-]*"));
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro outside of the current crate

error: no method named `end` found for type `(usize, usize)` in the current scope
   --> src/parser/pgn.rs:127:1
    |
127 | named!(pub symbol_token, re_bytes_find_static!(r"[[:alnum:]]{1}[0-9A-Za-z#=:+_-]*"));
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro outside of the current crate

error: aborting due to 3 previous errors

error: Could not compile `samson`.

To learn more, run the command again with --verbose.

it compiles fine when I try to build this function inside nom's source, and https://github.com/lakinwecker/samson compiles fine for me.
But I saw something that might cause the issue: nom requires regex 0.2 while samson uses regex 0.1. I guess what happened is that since the regex combinators in nom try to access the regex crate via ::regex::, it takes the regex crate exposed at top level in your code, not the one imported as nom dependency.
Requiring regex 0.2 in your code should fix the issue, but I guess I could also reexport the regex crate functions and structs inside nom, to access them from macros at the right version.

Thanks, upping regex to 0.2 works fine, thanks again


[WIP] nixos-module: taiga (TaigaIO project management platform)

Motivation for this change
I want to run TaigaIO (https://taiga.io/) on my nixos-machine.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@FRidh
I guess the taiga-maintainers are updating the dependencies with every minor-update.
As long as I am running taiga-io instances i can maintain this (for every minor taiga-update)

@FRidh i just pushed changes to address your notes on doCheck. I hope things are a little more clear now.

added [WIP] cos i just figured out I am pulling in the wrong django-version, and local database setup doesnt quite work

@betaboon is there any interesting in continuing with this PR?

@aanderse I'm not currently using taiga in any of my projects so i have not real need for it right now.
considering the age of this PR, the fact that is has been the very first nixos-module that i implemented and the bit-rot i would guess it needs (quite) some work.
I would be happy if anyone would pick it up tho :)

@betaboon thanks for the update. I'll close this PR off and as you mentioned if anyone is interested they can pick it up at some point in the future.


MediaController can lose asset background image

After opening the media controller, then tapping on the Cast icon to open the casting session view (not sure what this is called in the SDK), then hitting Cancel, the background asset is gone. Screenshots attached

Is this an SDK issue or app issue?

We have released the Cast SDK 3.1 and updated the sample app. Please try again and see if you still have the issue.


moved string.Format job into the formatter for WriteWarning extension method

I believe that string.Format shouldn't be called directly as WriteWarning method receives the message and args parameters. The warning logging could be disabled and WriteWarning would end up calling string.Format for no good.
I'm also not sure about my implementation here :smile: I used Tuple and it felt dirty :smile:

@tugberkugurlu Thanks for the PR. Could you rebase this one and send an update?

@muratg rebased but as you can guess from my commit message :smile: I am not sure if these changes make sense any more as the intention of this PR was already handled by other changes.
However, the changes still made the code consistent if you as me :smile:

@tugberkugurlu, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@kichalla

Thanks @tugberkugurlu The logger extensions class has gone through several code changes since this PR was submitted and i think your concern mentioned here has been addressed. Please take a look at the following again and submit  a new PR if required: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging.Abstractions/LoggerExtensions.cs

:+1:


Pop up disable is not working

Hi all,
I am experiencing this issue: on android, when disabling the popup box (the one with the mic image) nothing happens. The plugin fails silently, not returning any errors.
With the popup enabled, it works fine.
Does anyone know how to fix this? How  to remove the pop up?
Thanks!

I am having the same problem. It throws a client side error. Did you find a solution for this?


fix(Fixes #35):

Extracted the filename with the URL and appended it to the filename saved.


Cannot instantiate interface for ComponentInterface

Hi,
I found an issue with the standalone library:
because of the lack of di.xml Magento cannot create a ComponentInterfaceFactory object.
The dirty fix is adding <preference for="Pragmatic\JsLayoutParser\Api\ComponentInterface" type="Pragmatic\JsLayoutParser\Model\Component"/> to random di.xml in project.
Maybe there is another way to implement this inside library?

Pragmatic\JsLayoutParser\Model\ComponentFactory will do a job here. I updated a readme with the correct factory class.

Thanks, this will do the job!


sdk - add interface method to get planned UDC withdrawals

Description
Related to #2308 we need more access to the data of the UDC contract. I.e. entries of the planned withdrawals mapping with the users address(s). This is hard to do in the dApp itself. But the SDK has everything needed already there. The idea is to offer a simple method like we have already to get token balances. There is no need to extend the whole state machine in any kind. It is only about reading some information from a contract via the connected Ethereum node
Acceptance criteria

SKD has method to get a list of planned withdrawals for the account the SDK got instantiated with

Tasks

[ ]

There may only be one planned withdraw at a time. A new one while there's a pending will replace the previous. It's exposed mostly as an amount and a blockNumber. If blockNumber is in the future, it's pending; if it's in the past, it's available and ready to be performed; I think it resets to 0 after the withdraw is performed.

Thanks Andre! :pray:

I should have consulted you earlier. My plan was just do add 2 lines of code to the Raiden class. I'll look into your hints. Sounds very good and we should re-use that.

I think this issue has no point. I did a bad research. Everything is already there.

The action has a payload.block property which can inform you on when is the current/next planning expiration block. It's also emitted on startup (for past plannings). You can rely on it, if you can keep track of latest emit. If you don't want to keep track of it, and ask SDK explicitly, then yes, you'd need a new method on the Raiden class.

Can I safely remove planned withdrawls after the withdrawn event?

Yes. Just bear in mind the workflow here:
plan ->100 blocks -> +confirmation blocks -> withdraw -> +confirmation blocks -> withdrawn (confirmed)

Yes. So after plan, I see a successful withdraw action with the block when the final withdraw is possible. Special feature is now that the SDK is doing this then automatically. If this transactions succeeds, we get a withdrawn action.
We should consider to rename at least the first action. withdraw and withdrawn are not really well distinguishable.

Yes, maybe.. the issue here is that withdraw is an async action, so it has udc/withdraw/request, udc/withdraw/success and udc/withdraw/failure; the confusion is between udc/withdraw/success (which represents when a withdraw was successfully planned/queued) and udc/withdrawn, which represents when it got completed (i.e. made effective by 2nd tx). Since async actions can only have one respective success, we had to rename the success success action to withdrawn; maybe a better name would be udc/withdraw/complete. Feel free to rename it ;)

Haha, but humans are those who read and maintain the code. :stuck_out_tongue_winking_eye:
I'll see if I'm motivated enough to rename it. But actually I had more in mind to actually bring the word plan into the game.  Because having successful and completed together is also not really helpful.
But this is definitely not part of this issue (or its parent).


hotfix to make vhive work on new package repository

WARN: will break all features except stock-only; opened issue to k8s
Summary
Before migrating to pkgs.k8s.io, 10-kubeadm.conf was located in /etc/systemd/system/kubelet.service.d
After Migrating, 10-kubeadm.conf is located in /usr/lib/systemd/system/kubelet.service.d/
https://github.com/kubernetes/release/issues/3392
Currently opened an issue.
It seems that /usr/lib is default option for centOS and /etc is default on Ubuntu/Debian, and after migration, it seems that they removed this per-OS option (take a look at the conversation above)

@JooyoungPark73 is the PR ready or it draft? you may want to ask Leonid for a review

@ustiugov I left this a draft because k8s apt repo maintainers are currently investigating this issue, and their future direction is uncertain.

I think, if this PR fixes at least partially the problem with the k8s repos, we should merge it. Because right now, it doesn't work at all.


fix: Fix regex considering terraform-docs v0.10.0 old

Got this error using v1.42.0 on terraform_docs hook:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x13fdbe6]

Looks like the new v0.10.0 terraform-docs is going the awk script route instead of "Using terraform-docs 0.8+ (preferred)" route because the regex matches when it shouldn't.

Thanks for such a timely fix!
v1.43.0 has been just released.

Although this is a complete valid fix but the error was not completely related to the regex, it was a regression which was fixed in v0.10.1. I'd suggest to double check on your side for the new version too.

@khos2ow thanks for an update!


Update README.md

Add deprecating note.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

how do i merge it?

how do i merge it?

@iknowajosh - Our Agent Integrations team has to review and merge it.

ah ok thanks!

@iknowajosh Thanks for this PR 😄


MRG: Always force GUI updates

@nfoti can you see if this fixes your problem?
This forces a GUI process loop update when calling _force_render, which is useful e.g. to deal with the toolbar removal at the beginning. @nfoti found that getting the model-view matrix in a script was different before/after allowing the interpreter to idle, which is a sign that the idle-GUI-loop code was doing something to the display, which shouldn't happen if no interaction has taken place and we are properly forcing rendering changes.
Tests pass locally, let's see if the CIs are happy.

Examples still look okay:
https://16-1551431-gh.circle-artifacts.com/0/tmp/circle-artifacts.dQ84wpM/html/auto_examples/index.html

@larsoner This fixed my problem.
Thanks.

Great, ready for review/merge from my end, then

thx @larsoner


Proposal for _unlockNextOperation parameter

This is a proposal to implement a new ForceNewOperation parameter in order to allow to recover from an endless pending cluster state:

if there is not enough ressource to shedule the requested pods
if there are some selector labels which are not good

@allamand what about the parameter name ? I don't really like that name. What about starting it with an _ to make it a special parameter we should almost never use ?

@cscetbon it's not possible to preffix with _ because the var won't be accessible anymore. But we can find a better name ?

@allamand let's use the new name we both prefer and fix the current conflicts 👆

@cscetbon Can we merge now ?


TdlibPlugin Client closement

Is client closement still broken? i.e., if you restart your app, you'll get a zombie log file lock, which means the client wasn't closed. That applies to example as well

fixed in 1.3.0