fix(perf): When writing blocks to disk, don't block other async tasks

Motivation
We want to improve Zebra's sync speed to avoid #4155.
One way to speed up the sync is move blocking tasks to dedicated threads, so they don't stop other async tasks on the same thread from running. This PR moves disk writes and some CPU-intensive verification to a blocking thread.
Specifications
https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html
Solution

Move CommitBlock and CommitFinalizedBlock requests to a block-in-place thread

Add blocking tokio threads to tests that now need them

Remove tokio::time::pause() from tests that don't need it (it doesn't work with blocking threads)

In tests that need tokio::time::pause(), stop writing blocks to the state

Stop requiring a populated state in the mempool downloader

Review
I need to do a full sync test to see if this PR performs better.
But due to bug #3991, we're up to capacity with full sync tests right now.
(The quota allows around 3 at once.)
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

Follow Up Work

Move expensive read operations to blocking threads

Running full sync test at https://github.com/ZcashFoundation/zebra/actions/runs/2227577101

Failed due to https://github.com/ZcashFoundation/zebra/issues/3991, cherry-picked fix https://github.com/ZcashFoundation/zebra/pull/4198, and restarted at:
https://github.com/ZcashFoundation/zebra/actions/runs/2228129142

@mergifyio update

Merged in CI fix #4206 from the main branch, and started a full sync:
https://github.com/ZcashFoundation/zebra/actions/runs/2229899691
The time to beat is about 5h47.

The time to beat is about 5h47m.

It's about 5h43m, which is better.

This didn't happen in my local tests:

---- components::inbound::tests::fake_peer_set::mempool_advertise_transaction_ids stdout ----
The application panicked (crashed).
Message:  internal error: entered unreachable code: MempoolTransactionIds requests should always respond Ok(Vec<UnminedTxId>)
Location: zebrad/src/components/inbound/tests/fake_peer_set.rs:280

https://github.com/ZcashFoundation/zebra/runs/6217533371?check_suite_focus=true#step:3:994

@mergifyio update

I'm going to try to quickly fix this on Monday, but I might just have to close the PR for now, and add this branch to ticket #2188 so we can fix it later.

I don't have time to fix the fragile tests right now, so I'm going to leave these changes for later.

The mempool_push_transaction and mempool_advertise_transaction_ids tests are unstable in a multi-threaded environment. They fail occasionally with the wrong inbound service response.
I've pushed a fix to try and make sure they work, and I'm testing them locally.

The mempool_push_transaction and mempool_advertise_transaction_ids tests are unstable in a multi-threaded tokio runtime. They fail occasionally with the wrong inbound service response.
I've pushed a fix to try and wait for the mempool, I'm also testing the fix locally in a loop.

These tests are stable now, they passed over 3000 repeated test runs.
(They used to fail around 1/50 times.)

I admin-merged this PR because it is an urgent sync fix, and it has already been reviewed.
(Except for some minor test fixes.)


Chore/39 change content of artifact for GitHub release

Checklist

[ ] Changed e2e tests
[ ] Changed unit tests

Closes #39
@PlanBGmbH/flinkey-web-components

@aaronczichon For this PR we should ignore PR validation check. It won't succeed as I upgraded the version without changing any other content in components directory. I upgraded version because otherwise we won't see if the pipeline changes work as expected.

Ok.
But we should also create a git tag on new release.

@aaronczichon A tag is also created in GitHub when GitHub release creation is running. That action creates both.


feat: thorchain dynamic native Tx fee

Description
Instead of previously hardcoded fee.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

Screenshots (if applicable)

Closing as this will be tackled in unchained instead


[SR-964] Warn if the implicit setter argument 'newValue' is unused

This PR generates a warning if a setters implicit newValue variable is not used. If the variable is used, or if it is explicitly added to the setter (e.g. set(newValue)), no warning is generated.  This does not change willSet or didSet, since ignoring the implicit argument in observers is pretty common.
This turns out to create a lot of test churn! Before I run through all of the changes, I wanted to make sure that this is a desired warning, and that the behavior is correct. I think there are relatively few reasons to not use newValue, and disabling the warning is very trivial by adding (newValue), or (ignored) to the setter.

Resolves SR-964.

@swift-ci smoke test

The test suite probably has a bunch of stub setters there only because we need the declaration to test something; that's probably not representative of real-world code. Still, I wonder if we should tune this heuristic a bit more. For example, we could warn only about setters that mention the property declaration itself but do not mention the newValue parameter (however it's spelled). That seems like it catches the intent of the warning better, because the user has likely typed the property name where she meant to type newValue.

I updated the warning to complain only when the setter parameter is not used, and the getter is used. This behavior is much better and the change only generated 1 new warning in the test suite which I disabled with _ = newValue.
I removed some code that  added method parameters to the checker. It was only used to warn about var parameters that were not mutated. Since var parameter support was dropped in 3.0, this is just busy work.

Hey @DougGregor -- just a ping on this, I updated the heuristic to match your recommendation.

Hey @DougGregor -- Thought I'd try another ping on this.

@swift-ci please smoke test

@slavapestov can you steward this PR?

@swift-ci please smoke test

@swift-ci please smoke test

@shahmishal swift-ci doesn't seem to be responsive. Is there an issue with the builders, the reporting mechanism, or this PR?

This happened on a PR that I created and the suggestion was to close it and open a new one (it worked).

@DougGregor please review ;-)

@swift-ci please smoke test

Going to remake the PR to see if that appeases the build overlords.


#37605 Do not show "member not found" when loading member list

Details

This PR fixes the issue with showing the header message of the Selection List before the list is loaded.
Fixed Issues

$ https://github.com/Expensify/App/issues/37605
PROPOSAL: n/a
Tests

Log in to the app
Open any workspace
Open members list
Observe that the "Member not found" message doesn't shows up while the list shows the loader

[x] Verify that no errors appear in the JS console

Offline tests

Same as above.
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/7771498/5d4a458c-ea77-48ff-aca5-9701b84f0697

Android: mWeb Chrome
https://github.com/Expensify/App/assets/7771498/3a36d658-4913-4412-af4a-bfa945a4aa67

iOS: Native
https://github.com/Expensify/App/assets/7771498/0a07e586-f036-4771-837b-14d23e28ac5a

iOS: mWeb Safari
https://github.com/Expensify/App/assets/7771498/4df3fb41-c8cc-4f2c-993f-3ddab15ba1d1

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/7771498/9059d459-d5ce-49a0-9c1b-4f44e71960a1

MacOS: Desktop
https://github.com/Expensify/App/assets/7771498/69a36759-75a1-4c94-afb0-2af08b028ac0

@aimane-chnaif all yours

@aimane-chnaif no worries - this issue is kind of tricky... I've checked what you proposed in this comment and the Not found message was glitching while the loader was visible, so this is not our solution...

@aimane-chnaif I think the best would be to just introduce some isLoading variable inside the policyMembers ONYX key, that would be set to true at the beginning and set to false once loading the data is finished and rely on this value in WorkspaceMemberPage - simple Old School way of doing this ;)

Actually, I found interesting thing. When should we show Member not found message on this page? I don't find any case as myself is always a member of workspace. It makes sense to show this message when there are no other members except me, but this is not current logic. cc: @luacmartins

Yeah, the owner can't be also removed, as I understand. Are you saying we should never show this message here?

When policyMembers is empty, it means members are not fetched yet.
As myself (admin) is always in members list, there's no case of empty members list after fetched.

So !isOffline && isEmptyObject(policyMembers) is equivalent to isLoading what you suggested.

Well, from the logic perspective it of course makes perfect sense, but I've tried this condition and the message glitched, so there must be some additional re-renders happening or smth...

@aimane-chnaif I think I've fixed it - you are right with this condition but I've used it incorrectly (silly mistake). The condition is an equivalent of isLoading but I had to check for !isLoading && isEmptyObject(policyMembers)... Please re-test. Thanks

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add option to ignore process.env when on CI

My team found during an upgrade to react native, along with many other packages, that a change occurred that caused our .env.test to be ignored in favour of the environment variables injected via the CI. This appeared to only be the case when running yarn test --coverage.
Interestingly, when changing the coverageProvider to "v8", the environment variables were correct. But that didn't solve all our issues and raised other significantly complex issues.
Part of the solution took inspiration from this PR: https://github.com/ember-cli/babel-plugin-ember-modules-api-polyfill/pull/156/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
Link to issue
fixes #410 This is a solution we felt that the community might benefit from.
Description of changes being made

An extra option of ci has been added, which will allow the process.env variables to be ignored. The reason we got into this scenario was due to the environment variables in Circle CI being included in the initial temporary object and then subsequent values appeared to be ignored.
The update to ImportDeclaration() was a fix (link up above) for "container is falsey" that was found when running yarn jest --coverage.
Both changes were required to solve the overall issue.

Hi @lmcjt37 sorry for not seeing this sooner. Thank you for opening this! Excellent code quality. I'd normally be happy to dive in and help fix any issue so this passes.
However, I I'm a bit concerned because I don't quite understand what the need is for this. I've opened ticket #410 to discuss


Support multiple datasets

Ticket
n/a
Purpose
We would like to display data from more than one dataset in FIVEx, and allow users to directly stack and compare the studies from each.
This branch will represent a combination of work from @abought and @amkwong when completed. This PR exists to facilitate review and discussion.
TODO
Worklist provided by Alan:
Features that would be nice to have for displaying multiple studies/data sets in FIVEx (feature/multi_dataset branch):
Single variant view

[x] "If it's not too crowded, the view that will probably be most useful would be be PIPs for all studies in a smaller window (200k may be good enough; if it's still too crowded, maybe 100k?)" - requires Alan pipadder rework (for Txrevise data)

[x] Grouping by Study on the X-Axis
 - Note: studies do not share a lot of tissues, so grouping by different tissues will end up with tons of groups, and will almost look like grouping by (Tissue x Study). Other options include "system X study" etc.

[x] A way to toggle on/off points belonging to specific studies

[x] Tooltip window will need to show different fields, reflecting the new data
   - We don't need to show all the fields, but we need to add "study" at the very least

Remove obsolete parts of the "Variant Information from Sequence Genotype" information box:

[x] UI: allele count (AC), total (AN), and frequency (AF)
[x] API
[x] Backend ingest pipeline: including the dependencies on the data base file that powers looking up these values, and the data base file itself; keep the "nearest gene" function

[x] Update the supporting data bases that provide data for the tables on the bottom of the page

[x] gene expression (uses data from credible_sets)
[x] Txrevise (requires dynamically adding data columns to show transcript information) (future feature)

[x] Update logic to display shapes corresponding to the PIP cluster: use cs_index (from SuSiE) to indicate the cluster membership (this can only take one of two possible values: L1 or L2), and fix the legend to reflect this change

[x] Add a filter to dynamically remove points based on P-value or PIP (keeping only the most significant points; ideally a slider, but a text box would work also)

Side note:

[x] Currently the default selected options for some of the buttons are not the same as what's displayed on the plot:
   - Labels by default shows "No labels" even though the plot itself shows Top 5
    - X-Axis Group shows "Tissue" even though the plot itself is grouped by Gene

Region view

We need to change how we add new plots:

[x] "Anchor Tissue" will need to become "Anchor Study x Tissue" to accommodate the new data

[x] Every study will have different tissues, so we may want to provide the user new ways to find and display the desired data set
   - Choose a study, then choose a tissue within that study (adding a plot for that Study and Tissue for the anchor gene)
   - Or, choose from a list of Study x Tissue? (this may get too long / messy)
   - Choosing a different gene should add a plot of that gene in the current Study x Tissue anchor

The bottom table will need to be updated to reflect this additional data

[x] Need a new column for Study

[x] This table is populated using a different database, and is not what's shown in the plots above

[x] A new table database will need to be generated anew from the new data

[x] Merged credible_sets data fills out the current table
[x] Ideally we can add p-values from ebi_ge to the table
[ ] Add p-values to ebi_txrev data

[x] Update logic to display shapes corresponding to the PIP cluster: use cs_index (from SuSiE) to indicate the cluster membership (this can only take one of two possible values: L1 or L2), and fix the legend to reflect this change

[x] When entering region view via either 1) a gene query (gene_id or symbol) in the search box or 2) clicking on a Study x Tissue x Gene on the tooltips link in the single-variant page, the table at the bottom of the region view page should only show data corresponding to that gene by default.

One idea is that, if it's possible, in the listed use-cases, pre-fill the filter field in the table with the gene_id of the queried gene.
If not, then we can try adding a toggle button that lets you swap between "Show data for {gene_id} within {region}" and "Show data for all genes within {region}" (the credible sets API has an option to request only data points corresponding to a given gene_id)
If the user searches for a region (chrom:start-end), then the table should show data for all genes

Features which would be nice to have

[ ] In the bottom table, clicking on a "Study x Tissue" lets you add a plot for that Study x Tissue x Anchor Gene if the plot is not already shown

[ ] rs number annotation for data points in region view (EBI data already contains rsid information)

[x] Show the study name in tooltips and scatter plot point labels

[x] Harmonize all the code and URL query params to specify fields in the same order: (study, tissue, gene) (we don't want to break code once in production)

[x] PheWAS plot: type a gene name to find all points matching that gene name

[x] Revise "help" page to reflect new PIP datasource

Bug fixes:

[x] When viewing a new page or creating a new plot, options in the url are not applied (for example, y-axis=PIP)
[ ] When removing a plot in region view, the URL does not update to reflect this change

UI refresh and general improvements

[ ] Separate error messages and pages for "not found" vs server errors (400, 404, 500)
[ ] Fix HMR related "must refresh to see page changes" behavior in vue-router
[ ] Review existing routes: are there any behavior inconsistencies to iron out before deploy?
[ ] Avoid 500 errors when asking for unrecognized tissues- better errors and messages throughout
[x] Security review and audit

Hyun requests

[x] On the PheWAS plot, for point labels,  It would be great if the labels contain "all the other" information not shown in the group. For example,

Selecting gene as x-axis should show "[study]-[tissue]" as label, and it currently does it well (no change needed).
Select system should show "[gene]-[study]-[tissue]" as label (needs correction)
Selecting "study&tissue" should show "[gene]" as label (no change needed).
Selecting "study" should show "[gene]-[tissue]" as label (needs correction).

[ ] Assess possible new LZ feature to italicize gene names in panel titles

How to test this
tbd
CI will be broken until test data updated in repo- run tests locally
Deployment / configuration notes
New datasets must be generated and processed; existing lookups must be remade.

Changes are deployed. This should cover all reported bugs as of tonight, except "removing panel doesn't update URL". Letting the "remove panel" code talk to the page will require redoing some of the rules for how we name things / manage internal state: since a lot of stuff is being wedged in all at once, those rules (and the corresponding code) are a bit too fragile to refactor until the dust settles.
Tomorrow I'll look at consolidating the error handling and other behaviors.

I have done some testing on this branch and everything behaves as I expect. Merging this so we can continue adding features from a stable base for multi-study visualizations.


Add Subscriber EventName and ElementName

Hi Marton, I added the Subscriber EventName and ElementName to the eventList.
The EventName was already partially added as TargetEventName. I added it more consistently and the ElementName was added in the other cases as well. Furthermore I added something that you can say that the cache should be reloaded if it's older than version x (in this case the new version 0.2.4) because I want that the new properties are filled.
Furthermore I deleted the .lock files and I added comments to the any-Items which become CollectorItems, so that it will become more easy to go away of the "all types are type any" if that's a goal of you. But I didn't dare to add the properties directly with their default value as I don't know if you use these with other extensions and check if they are undefined?!
Best regards
David

Hi David,
It seems good at first review. Let me give a bit of time to verify with my local projects and check the webui parts as well.
If all ok, I'll merge it and make a new 0.2.4 release.

It seems to be working after some testing. :)


Vue-Syntax-Highlight not appearing in Package Control

Using Sublime 3.0 Build 3143

Searching "vue", "vue syntax highlight", or "vue-syntax-highlight" doesn't show vue syntax highlight.

I have other vue packages but they don't work with scss.
Has this been removed from Package Control?

It appears for me... Do you already have it installed? Search your remove list.

I'm not sure why this might be the case. Can you test with an updated version of sublime?

I checked multiple versions of sublime text and it seems to be working fine. I am closing the issue for now, please re-open if there's additional information you have. Thank you.


Readme about Release Status needs update

Latest version is v0.8.0. But it is displayed as v0.7.2 in readme

/kind bug

/assign

fixed！


gcloud beta emulators pubsub : "Unknown request URI "

From @SteelzZ on February 8, 2016 18:36
I have gcloud in docker container and running pubsub emulator inside.
Trying to create topic:
ctx := context.Background()
client := oauth2.NewClient(ctx, nil)
service, _ := pubsub.New(client)
service.BasePath = "http://<IP_ADDRESS>:8082/"
topic, _ := service.Projects.Topics.Create(fullTopicName("xxxx", "some-topic"), &pubsub.Topic{}).Do()

As response i get 404:
googleapi: got HTTP response code 404 with body: Not Found

And in pubsub logs i see:
pubsub] Feb 08, 2016 6:02:16 PM com.google.cloud.pubsub.testing.v1.GrpcServer$3 operationComplete
[pubsub] INFO: Adding handler(s) to newly registered Channel.
[pubsub] Feb 08, 2016 6:02:16 PM com.google.cloud.pubsub.testing.v1.HttpVersionRoutingHandler channelRead
[pubsub] INFO: Detected non-HTTP/2 connection.
[pubsub] Feb 08, 2016 6:02:16 PM com.google.cloud.pubsub.testing.v1.NotFoundHandler handleRequest
[pubsub] INFO: Unknown request URI: http://<IP_ADDRESS>:8082/v1/projects/xxxx/topics/some-topic?alt=json

But if do a pure curl request, it works:
curl -X PUT http://<IP_ADDRESS>:8082/v1/projects/xxxx/topics/some-topic?alt=json
{
  "name": "projects/xxxx/topics/some-topic"
}

Was trying to dig in and figured out that disabling this solves issue, but not sure if that is a problem.
Perhaps it relates somehow to this golang issue ? And this check here ?
Ideas?
Copied from original issue: GoogleCloudPlatform/gcloud-common#87

@stephenplusplus it's strange that commenting out the SetOpaque line changes anything; after all the URL that the pubsub emulator is logging looks valid to me. The 4860 issue should be unrelated: the issue was closed 3 years ago (and we should just delete the workaround code now).
As far as I can tell from your URLs there are no hex-encoded characters in your URL (your topic and project identifiers are alphanum words). Is that right?

Ok so when SetOpaque is disabled in wireshark i can see this:
Frame 6: 274 bytes on wire (2192 bits), 274 bytes captured (2192 bits) on interface 0
Ethernet II, Src: 0a:00:27:00:00:00 (0a:00:27:00:00:00), Dst: CadmusCo_be:6c:a6 (08:00:27:be:6c:a6)
Internet Protocol Version 4, Src: <IP_ADDRESS>, Dst: <IP_ADDRESS>
Transmission Control Protocol, Src Port: 62078 (62078), Dst Port: 8082 (8082), Seq: 1, Ack: 1, Len: 208
Hypertext Transfer Protocol
    PUT /v1/projects/xxx/topics/ggggggg-topic?alt=json HTTP/1.1\r\n
        [Expert Info (Chat/Sequence): PUT /v1/projects/xxx/topics/ggggggg-topic?alt=json HTTP/1.1\r\n]
            [PUT /v1/projects/xxx/topics/ggggggg-topic?alt=json HTTP/1.1\r\n]
            [Severity level: Chat]
            [Group: Sequence]
        Request Method: PUT
        Request URI: /v1/projects/xxx/topics/ggggggg-topic?alt=json
        Request Version: HTTP/1.1
    Host: <IP_ADDRESS>:8082\r\n
    User-Agent: google-api-go-client/0.5\r\n
    Content-Length: 3\r\n
    Content-Type: application/json\r\n
    Accept-Encoding: gzip\r\n
    \r\n
    [Full request URI: http://<IP_ADDRESS>:8082/v1/projects/xxx/topics/ggggggg-topic?alt=json]
    [HTTP request 1/1]
    [Response in frame: 8]
JavaScript Object Notation: application/json

And when SetOpaque is enabled:
Frame 29: 300 bytes on wire (2400 bits), 300 bytes captured (2400 bits) on interface 0
Ethernet II, Src: 0a:00:27:00:00:00 (0a:00:27:00:00:00), Dst: CadmusCo_be:6c:a6 (08:00:27:be:6c:a6)
Internet Protocol Version 4, Src: <IP_ADDRESS>, Dst: <IP_ADDRESS>
Transmission Control Protocol, Src Port: 62098 (62098), Dst Port: 8082 (8082), Seq: 1, Ack: 1, Len: 234
Hypertext Transfer Protocol
    PUT http://<IP_ADDRESS>:8082/v1/projects/nildev/xxx/ggggggg-topic?alt=json HTTP/1.1\r\n
        [Expert Info (Chat/Sequence): PUT http://<IP_ADDRESS>:8082/v1/projects/xxx/topics/ggggggg-topic?alt=json HTTP/1.1\r\n]
            [PUT http://<IP_ADDRESS>:8082/v1/projects/xxx/topics/ggggggg-topic?alt=json HTTP/1.1\r\n]
            [Severity level: Chat]
            [Group: Sequence]
        Request Method: PUT
        Request URI: http://<IP_ADDRESS>:8082/v1/projects/nildev/xxx/ggggggg-topic?alt=json
        Request Version: HTTP/1.1
    Host: <IP_ADDRESS>:8082\r\n
    User-Agent: google-api-go-client/0.5\r\n
    Content-Length: 3\r\n
    Content-Type: application/json\r\n
    Accept-Encoding: gzip\r\n
    \r\n
    [Full request URI: http://<IP_ADDRESS>:8082http://<IP_ADDRESS>:8082/v1/projects/xxx/topics/ggggggg-topic?alt=json]
    [HTTP request 1/1]
    [Response in frame: 31]
JavaScript Object Notation: application/json

As you see request URI has whole schema://host:port prepended.

That difference is what I'd expect from setting opaque. I'm surprised the
dev server chokes on it since it's a valid way of specifying the resource (
https://tools.ietf.org/html/rfc2616#section-5.1.2).
I'll have to chase up to see if we can fix the dev server or if there's a
simpler workaround.

This is definitely a bug in the emulator. A fix is in the works.

This should be fixed as of SDK 98, released about 3 weeks ago.

Verified working now.


fix: correct typing of FetchError

FetchError is being exported with the property code typed as a number when it is actually a string. This can break existing TypeScript projects that rely on type enforcement.
Fixes #386
Please ensure your pull request adheres to the following guidelines:

[ X] make sure to link the related issues in this description
[ X] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

@hjdhjd Thanks for reporting this issue and providing a PR! Could you please sign the Adobe CLA? Otherwise I won't be able to merge this PR.

Thanks @stefan-guggisberg - I won't be signing the CLA, but you're more than welcome to make the fixes yourself. They're tiny one-liners. 😄
Feel free to close these PRs if you prefer, and really looking forward to an updated release!

resolved via #392


Migrate org.jetbrains.annotations to android.support.annotation

This fixes a build error when using R8

Hi mate, cheers for this great library.
Sadly, I can't use it in projects using R8 - builds fail with the message:
Program type already present: org.intellij.lang.annotations.JdkConstants$ListSelectionMode
Would appreciate if you could merge this fix so my fellow R8ers can enjoy maskable layouts too :-)

Thanks a lot for looking into this!
It's hard to find the time to update the library to the latest tools and Kotlin.
I'm gonna make some effort and finish it, thank you for submitting this in the meantime :)

No worries mate, I know exactly how you feel. Thanks for the extremely speedy merge

Would you mind also making a release for Jitpack?

Sure, the artifact should be available on jitpack.
Everything working ?

Not yet, I'll take another look tomorrow


fix(wrangler): Support switching between static and dynamic Workers

What this PR solves / how to test
This commit fixes the current behaviour of watch mode for Workers with assets, and adds support for switching between static and dynamic Workers within a single wrangler dev session.
Fixes WC-2721
Author has addressed the following

Tests

[ ] TODO (before merge)
[x] Tests included
[ ] Tests not necessary because:

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[x] Required
[ ] Not required because:

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[x] Changeset included
[ ] Changeset not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[x] Documentation not necessary because: not documented

I assume this bug does not exist with --x-dev-env because config+args are re-resolved correctly each time config is updated?

indeed. I didn't have to fix anything for -x-dev-env. Can't wait for that to become the default

In my testing, I see the following behaviors work:

[x] Static to both

[x] Both to Worker

[ ] Worker to both

[ ] Worker to static

[x] Static to Worker

[x] default entrypoint RPC with just a Worker

[x] default entrypoint RPC fetch with just a Worker

[x] named entrypoint RPC with just a Worker

[x] named entrypoint RPC fetch with just a Worker

[x] default entrypoint RPC with both

[ ] default entrypoint RPC fetch asset with both

[x] default entrypoint RPC fetch Worker with both

[x] named entrypoint RPC with both

[ ] named entrypoint RPC fetch asset with both

[x] named entrypoint RPC fetch Worker with both

oh boy...this is def more complex than what I thought the expectation was here. My understanding was that this should support switching between assets only and W + A. I'm surprised tbh it works for anything other than. If. we want to support such wide range of scenarios, I'll need to dbl check with the team to get a feel of whether this is smth we do want to support.

We don't need RPC for launch, (other than just ensuring we don't break "RPC to a regular Worker"). But getting Worker to both and Worker to static would be nice if possible.

I also think this PR improves the current state. It fixes going from "Static to both" and "Static to Worker", so feel free to merge this as-is and we can address "Worker to both" and "Worker to static" in a follow-up ticket.

kk. I'll keep that in mind, but will bring this to the team anyway just so we have a clear picture of the general opinion here

technically yes, and I think that --x-dev-env gives us the behaviour we're looking for, tho I'd need to do more proper testing to confirm. However, the default wrangler dev, which uses the Dev React component, needs to re-render that component on every wrangler.toml change, which in turn will trigger the dev server to restart. The main entrypoint is passed in a s a prop to <Dev>, so unless we re-compute it on a config file change, any main changes won't be reflected even with a dev server restart. So, unless I'm completely misunderstanding the code, we'd need to call getEntry() on every toml change to ensure main entry point changes are reflected in what dev server serves

after discussing with the team, and doing some more testing, I'm going to go head and capture your suggestions @GregBrimble in this PR.
I've addressed your feedback in https://github.com/cloudflare/workers-sdk/pull/6775/commits/f6b33b7244ba29c47045ea7a06feab402cbe3533.
Please have a look and let me know how that test list is looking.
With these changes, we are bringing the wrangler dev and wrangler dev --x-dev-env experience on par, AFAICT at least 🚀


Can this be used for things other than keyvault?

I'm trying to use AZWI to provide az login credentials to an Azure CLI pod inside kubernetes (using the Azure CLI docker image) and not sure if this is possible and if so how to actually do it. The documentation only talks about how to use AZWI to pull secrets from keyvault and it's unclear if other use cases are possible or how do to them.

If you need to use it with azure cli, you can run the following command in the pod
az login --federated-token "$(cat  $AZURE_FEDERATED_TOKEN_FILE)" --service-principal -u $AZURE_CLIENT_ID -t $AZURE_TENANT_ID

It works with all azure resources. We only have examples here with the key vault SDK reference. It would be similar with other azure resources.

@aramase doesn't work.. when I try to add that line it just hangs forever with no output


Added walk()

Fixes #35

If you can also pass in an option cache instance, the tests could be purely functional.

Btw, it might be a good idea to move python version up. 3.6 is already end of life.


MIH Wrapper

The wrapper for multi-index hashing. https://github.com/ale-f/ann-benchmarks/commit/036f25027470623b578f1e243163f857318d9f79 introduces the necessary changes, everything else is an update to the current master of ann-benchmarks + hamming distance.

Closing in favour of #5.


Error compiling

Hi,
on my Kubuntu 14.04 desktop while building X11rdp I have an error:
"failed to download libXfont-1.4.3.tar.bz - aborting build"
Any suggestions here?

This is more likely to be a problem with the x11rdp script called "buildx.sh) which o-Matic makes use of (as o-Matic doesn't do the actual downloading and compiling of x11rdp itself - it merely downloads the x11rdp source and runs the buildx.sh script).
It might just be a temporary glitch in how buildx.sh downloads the source files it needs.
I say wait for a while then try running o-Matic again. If it still doesn't work, then try filing an Issue at https://github.com/neutrinolabs/xrdp

Hm, I try downloading this file with wget - no problem. But the buildx.sh script is stopping at the same file (libXfont-1.4.3.tar.bz). Any ideas?

It's out of scope now.


does not report on server status

I have this php script on a shared host with the minecraft servers port open through the firewall. Normal clients connect readily as expected. (server is minecraft 1.4.7)
when the php script runs, I can see an info log at the server console, something like
[INFO] <IP_ADDRESS>:57964 lost connection
where the ip address is the known ip of the host that the php script is running on.
However, the script always reports as being offline. $errno is zero, and I've tried upping and downing the timeout but that doesn't help. Unsure how to debug this any further.


Add ChannelTests for Ballerina WebSocket service to AsyncAPI generator cmd tool

Description:
Here, channel variable parameters for various ballerina types are being tested.

https://github.com/thushalya/asyncapi-tools/commit/93b53eadfdaf638c44b945ad29c5e8fa805eddc3
https://github.com/thushalya/asyncapi-tools/commit/4ec27191bf3b1eb5d1dbe4b01a2ca649a657e19d


Non-expiring secrets not supported any more

In the line 123 of the readme it suggests creating a secret that might not expire - this is not possible as non-expiring secrets were deprecated some time ago...
https://github.com/Azure-Samples/ms-identity-aspnet-daemon-webapp/blob/2515242f22bdeffd76bbd37b0601fa62676e74cf/README.md?plain=1#L123

Updated README.md to match latest portal UI. We will update generator once get to this sample


Flutter web not working in hosted site .

I have published my site with codemagic hosting . This site works completely fine in my console but keeps loading in hosted site .
#URL - https://newsrecital.codemagic.app
#Github Repo - https://github.com/SAMYAK99/NewsRecital

@SAMYAK99 I have a workaround for you :)

@iapicca yeah ! I saw you have same issue .
Did you find any solution for this ?

@iapicca yeah ! I saw you have same issue .
Did you find any solution for this ?

I did in my initial post at the bottom there is a workaround
that was suggested to me on stackoverflow
(it works)

@iapicca my asssets are loading but the data which i am fetching from the api in the json format is not loading 😐

@SAMYAK99
Usually when we host a web app on to external domains, we need to give access to JSON files. Have you looked into this aspect ? If not, can you try by giving the required access and see if it works ?
Thanks.

I have used an open source API ! still the contents of API is not loading in hosted site . It works perfectly fine in my local host .

@SAMYAK99
Have you reached out to codemagic on this issue ? It could be issue at their end.

@darshankawar Its not about codemagic . I have tried hosting the flutter site on Netlify and Github Pages still this error exists .
Here is the repo link  , you can try hosting it any server . I guess Flutter web is still in beta version , that can be issue  😐
Repo - https://github.com/SAMYAK99/NewsRecital

@SAMYAK99 the link you provided looks like production code
with several 3rd party plugins
flutter_inappwebview
google_fonts ( this doesn't support web! )
dynamic_theme
flutter_tts
I recommend to provide a minimal reproducible code sample
that doesn't rely on 3rd party plugin
and making sure that the packages in use support web

@iapicca here is another project . I have used only http package to fetch the data from the api . I am using an open source api which does not required any credentials
Repo link for code - https://github.com/SAMYAK99/flutterwebtest
Repo link for web - https://github.com/SAMYAK99/fwebtest
hosted site - https://samyak99.github.io/fwebtest/
Expected output in the hosted site

Recived Output
Blank screen

@SAMYAK99
I tested your sample with dhttpd and seems to work just fine
I suspect @darshankawar is right, it might depend from the host

logs
francesco@francesco-yoga720  ~/projects/other  cd flutterwebtest                                                                                 ✔  4324  13:01:38
 francesco@francesco-yoga720  ~/projects/other/flutterwebtest  master  flutter_master build web --release                                                                           ✔  4325  13:01:47
Downloading Web SDK...                                             15.4s
Running "flutter pub get" in flutterwebtest...                      1.4s
Compiling lib/main.dart for the Web...                             31.3s
 francesco@francesco-yoga720  ~/projects/other/flutterwebtest  master ●  cd build/web                                                                                 ✔  4326  13:02:54
 francesco@francesco-yoga720  ~/projects/other/flutterwebtest/build/web  master ●  dhttpd --port 8888                                                                               ✔  4327  13:03:02
Server started on port 8888
2020-10-13T13:03:28.686031  0:00:00.017155 GET     [200] /
2020-10-13T13:03:28.768809  0:00:00.000730 GET     [200] /main.dart.js
2020-10-13T13:03:28.991073  0:00:00.000622 GET     [200] /assets/FontManifest.json
2020-10-13T13:03:29.026789  0:00:00.001740 GET     [200] /assets/fonts/MaterialIcons-Regular.otf
2020-10-13T13:03:29.030651  0:00:00.000414 GET     [200] /assets/fonts/CircularStd-Medium.ttf
2020-10-13T13:03:29.031947  0:00:00.000328 GET     [200] /favicon.png
2020-10-13T13:03:29.033543  0:00:00.000376 GET     [200] /assets/fonts/CircularAir-Light.ttf
2020-10-13T13:03:29.034786  0:00:00.000456 GET     [200] /assets/fonts/CircularStd-Bold.ttf
2020-10-13T13:03:29.036568  0:00:00.000414 GET     [200] /assets/packages/cupertino_icons/assets/CupertinoIcons.ttf
2020-10-13T13:03:29.252904  0:00:00.000723 GET     [200] /flutter_service_worker.js?v=1936611791
2020-10-13T13:03:29.273203  0:00:00.000671 GET     [200] /?revision=7a50a6ee7ae47282153b636e6fe699bb
2020-10-13T13:03:29.274834  0:00:00.000411 GET     [200] /main.dart.js?revision=cf4be343706c96103b223da275b0e45f
2020-10-13T13:03:29.276820  0:00:00.000825 GET     [200] /index.html?revision=7a50a6ee7ae47282153b636e6fe699bb
2020-10-13T13:03:29.279239  0:00:00.000668 GET     [200] /assets/NOTICES?revision=0f4f8e2395b7a8a5ef55ca7bea8f4850
2020-10-13T13:03:29.282474  0:00:00.000766 GET     [200] /assets/AssetManifest.json?revision=601ae85404135d5e521edc950ce826bf
2020-10-13T13:03:29.284798  0:00:00.000702 GET     [200] /assets/FontManifest.json?revision=9401f0dc37eed668d80deced33c61e72
^C

screenshot

@iapicca like I said it is working completely fine on my local host . Can you please host it on any server like github pages , netlify etc... and give me the link ?

@iapicca like I said it is working completely fine on my local host . Can you please host it on any server like github pages , netlify etc... and give me the link ?

dhttpd is a sever-like hosting

@ianloic  can you generate any url with dhttpd ?

@iapicca thanks for digging in.
@SAMYAK99 since there seem to be different issues while trying to host web app, like assets, fonts aren't loading properly, irrespective on which host you try to deploy, your issue could also be related to it. Would you be okay to track this in 67655 to have all these issues at one place ?
Thanks.

@darshankawar my issue is different .  Assets, fonts are loading properly but no data is received from the api in the hosted web version .
URL - https://newsrecital.codemagic.app

Keeping this issue open for further analysis.

@SAMYAK99 When loading your web page I get an error log in the browser's console Failed to load resource: the server responded with a status of 426 ()
This article indicates that the free API key from newsapi.org does not work in production, only on localhost.

@azbuky  here is another project . I have used only http package to fetch the data from the api . I am using an open source api which does not required any credentials . You can try to host this project in any server and share the url 😀 . Likewise you can use any project , I just want to see is it possible with flutter web to parse the json data from the api in the hosted server .

Repo link for code - https://github.com/SAMYAK99/flutterwebtest
Repo link for web - https://github.com/SAMYAK99/fwebtest
hosted site - https://samyak99.github.io/fwebtest/
Expected output in the hosted site

Recived Output
Blank screen

@SAMYAK99 you are not correctly deploying your sample project at https://samyak99.github.io/fwebtest . Check the console in Chrome for errors, main.dart.js is not found (404) so there is nothing to load.

@SAMYAK99
I tested your sample with dhttpd and seems to work just fine
I suspect @darshankawar is right, it might depend from the host

@SAMYAK99 you are not correctly deploying your sample project at https://samyak99.github.io/fwebtest . Check the console in Chrome for errors, main.dart.js is not found (404) so there is nothing to load.

I concur with @azbuky
the issue is very likely related to a problem with the host or the deployment itself
rather than a bug caused by flutter

So the conclusion is  as of now Flutter web does not  support JSON parsing in any hosted server 🤨

@azbuky yes you are right 😀 . I have hosted in different server and it works .
URL - https://fweb.codemagic.app/#/
But I still have a doubt , is it possible to host flutter project which require credentials like News api .
If Yes can you please guide me how to host my first project 😅.

@SAMYAK99 since the problem isn't with flutter I recommend you to close this issue
for

[...] can you please guide me how to host my first project .

this type of question should be asked on Stackoverflow and not discussed on Flutter github repo

sure

@azbuky yes you are right 😀 . I have hosted in different server and it works .
URL - https://fweb.codemagic.app/#/
But I still have a doubt , is it possible to host flutter project which require credentials like News api .
If Yes can you please guide me how to host my first project 😅.

Hi @SAMYAK99, I encountered the same issue now using code magic. How did you manage to make it work? Thank you!

@azbuky yes you are right 😀 . I have hosted in different server and it works .
URL - https://fweb.codemagic.app/#/
But I still have a doubt , is it possible to host flutter project which require credentials like News api .
If Yes can you please guide me how to host my first project 😅.

Hi @SAMYAK99, I encountered the same issue now using code magic. How did you manage to make it work? Thank you!

Guys, I don't know if this could help anyone else.
For us, the spread(...) operator was not supported in release mode (No idea why). So, we replaced the operator in the API calls and we started getting responses in release mode.
This probably can happen with other libraries as well


[$250] Workspace - App crashes when clicking on room header of #admin room that has system message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com
Create a new workspace.

Click on the room header.
Note that the app does not crash.
Go to workspace settings > Categories.
Delete a category to trigger system message in #admin.

Click on the room header.

Expected Result:
App will not crash.
Actual Result:
App crashes when clicking on room header of #admin room that has system message.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/33dbde80-e7a0-4102-99f5-3b8077f28762
Bug6535810_1720442352877!staging.new.expensify.com-1720436555090.txt

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0f53207293d92db
Upwork Job ID:<PHONE_NUMBER>500831709
Last Price Increase: 2024-07-17

Issue OwnerCurrent Issue Owner: @fedirjh

We think this issue might be related to the #vip-vsb

Issue not reproducible during KI retests. (First week)

Thanks everyone - closing 👍


Paying to certain lightning addresses does not allow inputing a note on the send bitcoin flow

If you try and send some sats to<EMAIL_ADDRESS>using BBW it's impossible to enter any text in the note field.  Not sure if this is a general issue when paying to any lightning address or if it's being caused by the lnurl response from coincorner but worth looking into.

just did a test and this sounds to be working now


io: MultiReader's documentation is less precise than the changelog

What version of Go are you using (go version)?

$ go version
G01.19-beta1

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
N/A

What did you do?
Open the 1.19 beta 1 changelog and go to the io section, then read:

MultiReader's result now implements WriterTo unconditionally. If any underlying reader does not implement WriterTo, it is simulated appropriately.

However the https://pkg.go.dev/io#MultiReader documentation does not include that:

// MultiReader returns a Reader that's the logical concatenation of
// the provided input readers. They're read sequentially. Once all
// inputs have returned EOF, Read will return EOF.  If any of the readers
// return a non-nil, non-EOF error, Read will return that error.

What did you expect to see?
A sentence including the WriterTo behaviour.
What did you see instead?
Nothing
Backstory
I didn't included a note of that while implementing WriterTo on MultiReader since I thought this was implementation details (I see WriterTo like an implicit optional extension of all Reader interfaces) and this is the behaviour you expect (you can find a youtube video where a member of the go team do a live codding session and talks about zero copying on multireaders which was not a thing back then).
If it is changelog worthy then it should be also documented in the code, so future developers can learn about it.

/cc @ianlancetaylor


Benchmark

New project on frankenphp
create entities
map it to doctrine AND redisOM
benchmark (with https://github.com/phpbench/phpbench ?) the performance on persist retrieve single or multi objects

done, should add it in doc


Write documentation for GitHub workflow

There should be some documentation for how members of MG-Web should make use of GitHub. Examples of this are

remembering to correctly configure an issue (setting project, optionally a milestone, optionally assigning another member, et cetera)
assigning oneself if one is starting on an issue
If a PR is closing, write it in the description so it can be automatically closed
when creating a new issue there should be some template with important information to be included, like description of the issue, optionally how to reproduce if bug, et cetera

Closed by #516


chore: Update EDC-Connector Version (0.2.0) and fix Tests

What this PR changes/adds
Update EDC-Connector to 0.2.0 and fix broken Tests.
Why it does that
The version of the EDC-Connector should be up to date.
Further notes
Linked Issue(s)
Closes #170
Checklist

[ ] added appropriate tests?
[x] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly?

I think only the UI Test is failing. In my opinion this need to be fixed in a different repository.
What do you guys think?

Updated now also all versions in the gradle.properties. But the test (RUN MVD Docker incl. MVD UI) is failing while trying to download a docker image like also in other PRs then before.
Is this failing correlated to the Versions in the MVD or do you know some other reasons why the test is failing?

Updated now also all versions in the gradle.properties. But the test (RUN MVD Docker incl. MVD UI) is failing while trying to download a docker image like also in other PRs then before.
Is this failing correlated to the Versions in the MVD or do you know some other reasons why the test is failing?

looking at this quickly, it could be that the paths are wrong: the dashboard gets checked out at MinimumViableDataspace/DataDashboard, but the docker compose file seems to expect it at MinimumViableDataspace/system-tests/DataDashboard
check .github/actions/gradle-setup/action.yml#L10

I hope the creation of the HTTP-Body is ok for you. If you have any suggestions for improving, feel free to share.


Automatically update to LTS on a timely manner

See:

https://github.com/jenkinsci/docker/pull/460
https://github.com/jenkinsci/docker/pull/458
https://github.com/jenkinsci/docker/pull/454

The docker image always lags behind a new LTS release. Any chance to get some automation done to update to latest LTS as soon as it is released?
The whole process can be done in continuous integration. It seems to me as simple a creating a new job on https://ci.jenkins.io/ (but I could be wrong).

Automated builds are in jenkinsci/jenkins:lts already
Docker-Official jenkins image needs manual steps

For reference, what are these manual steps that can't be automated?
My own image does FROM jenkins:2.46.1 and I still can't update it after 3 days since Jenkins 2.46.1 has been released.

The "official" Docker Jenkins images require pull requests like this one.
Frankly, there's no benefit to using the Docker "official" images. Instead I suggest you rely on jenkinsci/jenkins:2.46.1 which is the official (from the Jenkins project) image for that LTS release.

@rtyler thanks, the difference between docker-official and jenkinsci isn't obvious. Switching to jenkinsci/jenkins:lts seems indeed the right thing to do ... once you're informed about it.


add support for North Macedonia (names + ID numbers)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.83%. Comparing base (b37c566) to head (db9812f).
Report is 118 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1218      +/-   ##
============================================
- Coverage     92.35%   91.83%   -0.52%
- Complexity     2821     2990     +169
============================================
  Files           292      306      +14
  Lines          5609     5902     +293
  Branches        599      627      +28
============================================
+ Hits           5180     5420     +240
- Misses          275      316      +41
- Partials        154      166      +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can I set range for date selection

Is it possible to set a range for date to be select, like user can only select a date from today to next 15 day.

@sandeee1928 You can set a startDate for the calendar where the user cannot select the dates before  this date. But don't have the endDate now, will provide this sometime in future :)

Hi,
Thanks for reply,
The startDate is only working when multipleDateSelection is enable(true),
but for single date selection I can select the date before the startDate.
Thanks,
Sandeep
On Thu, Apr 21, 2016 at 12:15 AM, Praba<EMAIL_ADDRESS>wrote:

@sandeee1928 https://github.com/sandeee1928 You can set a startDate for
the calendar where the user cannot select the dates before this date. But
don't have the endDate now, will provide this sometime in future :)
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ipraba/EPCalendarPicker/issues/16#issuecomment-212780095

This problem has been solved.

@YMonnier Is this selection done within this source code or you have a separate one for it.

@mohsinka Hey! Normally yes --> https://github.com/ipraba/EPCalendarPicker/pull/17

Hey @ipraba,
Any updates on having an end Date to the library?
Would be really grateful to see that.
faiztech

I'm interested in the endDate feature as well.

@raid5
I actually implemented a Weekly Calendar Picker, You can achieve start date and end date by modifying the Week() class in the project.
Here is a link to it: https://github.com/faiztech/WeekCalendarPicker


oasis-node doesn't parse signer related flags

SUMMARY
Passing --signer flag to oasis-node will throw:
unknown flag: --signer
ISSUE TYPE

Bug Report

OASIS NODE VERSION

Runtime protocol version: 0.13.0
Consensus protocol version: 0.25.0
Committee protocol version: 0.9.0
Tendermint core version: 0.33.4
ABCI library version: 0.16.2
Go toolchain version: 1.14.3

OS / ENVIRONMENT
Ubuntu 18.04
STEPS TO REPRODUCE
oasis-node --config ./etc/config.yml --signer file
ACTUAL RESULTS

unknown flag: --signer

EXPECTED RESULTS
All signer related configs should be correctly parsed.

Thanks for reporting this, it should be fixed by #2951.


TNT-41216 Add missing export

Description
exportTelemetries was missing as an export to index.browser.js in PR for TNT-41216.
Related Issue

Fixes bug in TNT-41216 PR.
Jira Ticket

Coverage remained the same at 92.655% when pulling 8f468011f7c556a74c24a8181ecaeb27ebc7abc3 on andyruwruw:TNT-41216-3 into 6f926de28bf6195aa0d471ac2d946e2ee564c4c0 on adobe:main.


get a list of all retweeters?

Hello,
Is there a way to get the username list of all retweeters of a given tweet by providing the tweet id?
thanks,

Nope, you need the API for this


Support traefik labels for URL configuration

Fixes #102

Merged with feature. Will merge with master with next version.


Patch 1 / Scaling doc

Updated Scaling to include Sample Server Scaling guide.

Thanks @JustinReynolds-MM for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.


Question: Best way to export large csv file

Our application need to export csvs that are about 10MB. What will be the best way to export this?
If I understand it right, the byte[] or MemoryStream way will allocate the memory on the LOH.
In the old days (Mvc 4.5), I inherit the FileResult and override its WriteFile method.
For now, I have to implement my own FileDelegateResult which inherits ActionResult and duplicates the code for setting SetHttpFileName and ContentType.
Is there a better built-in way of handling this?
Thank you.

There are file result types that do this for you:

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/VirtualFileResult.cs
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/PhysicalFileResult.cs

They will both set the content disposition header, etc., so long as they have the data passed into them.


Remove "dry_run" option

Description of the problems or issues
Is your pull request related to a problem? Please describe.
I can't see the reason why this option is required.
If you don't want to overwrite an output file created previously, just print the result to the console.
If you don't want to mess the console with a lengthy result, redirect the output to /dev/null like this: pdftotree tests/input/md.pdf > /dev/null
Does your pull request fix any issue.
N/A
Description of the proposed changes
Remove "dry_run" option from pdftotree command
Test plan
N/A
Checklist

[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have updated the CHANGELOG.md accordingly.

Codecov Report

Merging #89 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   66.02%   65.92%   -0.10%
==========================================
  Files          22       22
  Lines        2540     2530      -10
==========================================
- Hits         1677     1668       -9
+ Misses        863      862       -1

Flag
Coverage Δ

#unittests
65.92% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pdftotree/utils/pdf/pdf_parsers.py
92.30% <0.00%> (-0.08%)
:arrow_down:

pdftotree/TreeExtract.py
88.81% <0.00%> (-0.04%)
:arrow_down:

pdftotree/ml/TableExtractML.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff4a7c...c61eb4f. Read the comment docs.


Allow to tune resolution in top-down env

What changes do you make in this PR?

Please describe why you create this PR

Checklist

[ ] I have merged the latest main branch into current branch.
[ ] I have run bash scripts/format.sh before merging.
Please use "squash and merge" mode.

merge when tests passed!


mxc_v4l_open: Mxc Camera no sensor ipu0/csi0

Hello,
I am trying to setup my DMK 22BUC03 Usb Camera on Ubuntu 14.04 (armhf) on my i.mx6 Freescale SabreLite Board. The kernel is 3.10.17. I followed all the steps in the wiki but the camera is only recognized correctly as USB device ( lsusb shows Imaging Source device is detected. ) I updated camera Firmware successfully, and /dev/video* shows up. But when trying with each /dev/video* to start any program (v42l-utils, fswebcam, gstreamer ...) which tries to access camera, the program aborts with things like "can't read / write from /dev/video0" or "resource temporarily unavailable" and i get always the following in my syslog.
mxc_v4l_open: Mxc Camera no sensor ipu0/csi0
mxc_v4l_open: Mxc Camera no sensor ipu0/csi1
mxc_v4l_open: Mxc Camera no sensor ipu1/csi1
What am I missing? Hopefully we can resolve this.
Regards
Reinhard

Hello Reinhard
I searched in the internet for "mxc_v4l_open: Mxc Camera no sensor ipu0/csi0" and found some hints to the USB controller. Thus, I would like you to try an active, poweredUSB hub between camera and your computer.
It might be a good idea to check the camera on another Linux computer to make sure, it is working fine.

Hello,
This issue is resolved now. It turned out that uvcvideo was not activated in my kernel. Newbie mistake I guess

I must admit, I never would have found that on my own...
Stefan


Automated Security Testing

Description:
Find free automated security testing tools that will be usable to test the prod branch live site.
Source:

https://snyk.io/website-scanner/ - provides documentation for each vulnerability for greater clarification
https://hostedscan.com/scans

https://docs.google.com/document/d/1cf_QfJZIrdBq2T4Y-UxH91ZkhkSnf0fwBcpDGcUiu8A/edit


\cAc\GcsWrapper\GoogleCloudStorage Class missing

PHP Fatal error:  Uncaught Error: Class 'cAc\GcsWrapper\GoogleCloudStorage' not found
I'm facing above error that GoogleCloudStorage Class not found. Please help me with this issue.

have fixed this issue

Fatal error: Uncaught Error: Class 'cAc\GcsWrapper\GoogleCloudStorage' not found
Please help me.

@kishoreacharya how you fix it?


Support for multiple request/response types (oneof, allof, anyof, ...)

It is possible to define multiple request/response types as defined here: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/ ?
For example, the swagger spec should look like this:
paths:
  /pets:
    patch:
      requestBody:
        content:
          application/json:
            schema:
              oneOf:
                - $ref: '#/components/schemas/Cat'
                - $ref: '#/components/schemas/Dog'
      responses:
        '200':
          description: Updated
components:
  schemas:
    Dog:
      type: object
      properties:
        bark:
          type: boolean
        breed:
          type: string
          enum: [Dingo, Husky, Retriever, Shepherd]
    Cat:
      type: object
      properties:
        hunts:
          type: boolean
        age:
          type: integer

Hi @AccsoSG
It is supported at the moment
You can use
UseAllOfForInheritance
UseOneOfForPolymorphism
to achieve the behaviour.
            opts.ConfigureSwaggerGen = x =>
            {
                x.UseAllOfForInheritance();
              //
             //
            //
            }


feat: Replace multiple SNMP walks with one SNMP Bulk

I have read the Code of Conduct and I hereby accept the Terms

Codecov Report

Merging #100 (fc5506b) into develop (7699591) will increase coverage by 4.86%.
The diff coverage is 60.36%.

@@             Coverage Diff             @@
##           develop     #100      +/-   ##
===========================================
+ Coverage    40.33%   45.19%   +4.86%
===========================================
  Files           22       23       +1
  Lines          838      916      +78
===========================================
+ Hits           338      414      +76
- Misses         500      502       +2

Impacted Files
Coverage Δ

splunk_connect_for_snmp_poller/manager/poller.py
0.00% <ø> (ø)

..._connect_for_snmp_poller/manager/task_utilities.py
20.00% <21.95%> (+1.39%)
:arrow_up:

splunk_connect_for_snmp_poller/manager/tasks.py
39.68% <53.84%> (+39.68%)
:arrow_up:

tests/test_tasks.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7699591...fc5506b. Read the comment docs.

I have read the CLA Document and I hereby sign the CLA

:tada: This PR is included in version 1.5.0-develop.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore(package): ncu update React 16

chore(travis): setup auto release
docs(LICENSE): add LICENSE file
style: update prettier

Deploy preview ready!
Built with commit 9b4f55bcbc6bebc610d37dd9887fdb4d124f8440
https://deploy-preview-51--react-progressive-bg-image.netlify.com


Provide Better Documentation on TabView Animation Requirements

NOTE The issue described here may be resolved via https://github.com/react-native-community/react-native-tab-view/commit/f5756e95bd1beeee02ecfbc26f98ee2acae8b83e which as of me writing this is the most recent commit in master which hasn't been released yet.
Perhaps an action item after that's been released is to update the documentation to describe the behavior (e.g. "When navigationState.routes changes size, we cannot reliably animate the Pager so we change slides without animating.")
Current behaviour
If you create a <TabView /> and you inadvertently pass it a new routes object as part of the navigationState prop - you will not see any animations when interacting with the TabBar. This is not documented and not terribly expected either.
Expected behaviour
I did not disable animation (e.g. via animationEnabled={false}), therefore I expect to see animations when changing tabs.
Code sample
I don't have time at this moment to put together a complete example, but the scenario is fairly simple:
// In some component, render method
render() {
  let key = .. get the current route key ..
  let index = .. get the current route index ..

  let navigationState = {
    index,
    routes: { ...ROUTES } // CONTRIVED, I've demonstrated the notion that this field is a new object on every `render`. Imagine this is a function call that returns the routes, but will return a new object every time. This is obviously bad, but fairly easy to accidentally do.
  }

  return (
    <TabView
      navigationState={navigationState}
      renderScene={this._renderScene} // not important for the example
      initialLayout={INITIAL_LAYOUT} // not important for the example, correctly configured
    />
  )
}

Screenshots (if applicable)

What have you tried
Several different things, but to no avail. Finally I recognized that I was passing in a new object on each render after I inspected this library's source code and found the equality check on navigationState.routes.
Your Environment

software
version

ios or android
both

react-native
0.55.4

react-native-tab-view
^1.0.2

node
8.11.3

npm or yarn
yarn 1.7.0

Hey, I just released a new alpha 2.0.0-alpha.0 of the library. It's rewritten using react-native-gesture-handler and react-native-reanimated addresses a many platform specific bugs and performance problems. The documentation is updated as well.
Please try the new version and see if it addresses your issue. If not, please open a new issue following the issue template.


[pos_restaurant_base] Try to merge upstream

@GabbasovDinar It would be greate could you try to include this module (it's changeset) in upstream Odoo. In my experience, generally they are open to such changes.

@GabbasovDinar try to start with upstream. They are very cautious about PR to stable versions


Initial Camera & Target Point

remove initial camera
fix target point initialization

tagging @mounirlamouri for visibility

Looks great! The target bug is fixed too?

Yep, target bug is fixed as well

Looks great! The target bug is fixed too?

Yep, target bug is fixed as well

I'm going to just merge this, and handle these comments in a new PR because you're off today :)


Enhancement: when adding a tower server, automatically run a first sync of job template

Done and merged in dev


feat: Update Today's Forecast container

Added bootstrap grid layout to the data layout and refined the styling of the overall container and it's contents.

Approved and merged PR due to time constraint. Code was also worked on by Mateo


Error: You should not call create on a model

Finally had an opportunity to try this out.  I'm trying to push a response object to simpleStore but I'm running into the following error:

Error: You should not call create on a model. Instead, call store.createRecord with the attributes you would like to set.

This is my set up
return PromiseMixin.xhr(`${ENV.APP.URL_PREFIX}/person/${encodedIdentification}`, "GET").then((response) => {
          simpleStore.push("person", response);
});

Am i just not able to retrieve a single record without using the findById method?

This is an ember-data assertion.
https://github.com/emberjs/data/blob/master/addon/-private/system/model/model.js#L975-L978

@jasonmit is this an issue supporting both ember-data and simple-store together?
@jwright04 any chance you could provide a full stack trace to help us better identify when the error occurs?

@toranb hard to tell with the information given.  But simpleStore in the above snippet may be the ember data store.

Thanks for the response guys.  Here is the full error:
ember.debug.js:32161
Error: You should not call `create` on a model.   Once I successfully receive an authentication token (within my authenticateSuccess function), i then attempt to make this call within that callback:
return PromiseMixin.xhr(`${ENV.APP.URL_PREFIX}/person/${encodedIdentification}`, "GET").then((response) => {
          simpleStore.push("person", response);
});

That's when I get the error.

Can you post the entire class that function is within.  I am fairly certain that simpleStore is actually the ember data store service that is injected instead of simple store.  Also, which version of ember simple store are you using?

import Ember from 'ember';
import ENV from 'app/config/environment';
import PromiseMixin from 'ember-promise/mixins/promise';

export default Ember.Service.extend({
    store       : Ember.inject.service(),
    simpleStore : Ember.inject.service(),
    authenticateSuccess(identification){
        var encodedIdentification = encodeURIComponent(identification);
        var simpleStore           = this.get("simpleStore");

        return PromiseMixin.xhr(`${ENV.APP.URL_PREFIX}/person/${encodedIdentification}`, "GET")
                           .then((response) => {
                               return simpleStore.push("person", response);
                           });
    }
});

Can you verify that simpleStore is actually the simple store and not the ember-data store?
The stack trace indicates it's happening within the ember-data store and not the ember-cli-simple-store.  I would pause on buildRecord (http://localhost:4200/assets/vendor.js:91537:30) to see how that is being invoked after you push records into the simple store.  Perhaps you have a computed property, observer, or the caller of authenticateSuccess which is touching ember-data.

@jwright04 if you need help debugging this just reach out - I'd be glad to pair up over screen hero or something this week if you need a hand :)
if you got this, a full screenshot of the pause'd buildRecord would be great as @jasonmit suggested

Closing for inactivity - if you get back into this and need help just let me know


feat(streaming): add s3 streaming utility

Issue number: #1692
Summary
This PR adds a new utility to stream data from S3.
Changes

Please provide a summary of what's being changed

New utility called streaming and a new S3Object class. Includes common data transformations and a way
to implement custom data transformations and add them to the data pipeline.
User experience

Please share what the user experience looks like before and after this change

from typing import Dict

from aws_lambda_powertools.utilities.streaming.s3 import S3Object
from aws_lambda_powertools.utilities.typing import LambdaContext

def lambda_handler(event: Dict[str, str], context: LambdaContext):
    s3 = S3Object(bucket=event["bucket"], key=event["key"], is_gzip=True)
    for line in s3:
        print(line)

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[ ] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

View rendered docs/utilities/streaming.md

Codecov Report
Base: 99.27% // Head: 96.08% // Decreases project coverage by -3.18% :warning:

Coverage data is based on head (cbe2355) compared to base (f9752df).
Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head cbe2355 differs from pull request most recent head a0e4f6f.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Pushed the final docs changes, including docs index and project readme to highlight as a new feature too.


Cauldron.Interception reference not getting added to project.

After installing cauldron via nuget package management in VS2017 there do not seem to be any references added to the solution which in turn means that using Cauldron.Interception does not resolve.
You can reproduce this by downloading the example project linked to on the wiki (this  one)
Update all 3 nuget packages in it to their latest versions and you'll see that the Cauldron namespace can no longer be found.
Have I missed a setup step somewhere or is this a bug?

I have same issue.

this may be why I'm experiencing #84

I also faced with this problem and did not find a solution.
VS 2017, .NET Framework 4.5


Add support for Swift 4.2

Ran the project through the Xcode Swift converter, inspected the changes and ran the project.

Thank you johnyorke!
Apply to the project this evening.
I will update to CocoaPods.


"Recreate Slots on Ready" missing

Hi, I'm trying to follow the tutorial to setup a system for my 2d game but noticed the "Recreate Slots on Ready" tickbox shown in the tutorial doesn't exist when I try to make an inventory. I'm not sure if it's because of this or some other issue, but the created inventory always starts with 0 slots, even if I have "Slot Amount" set to 16 etc. Slots are created when I add items to the inventory, but this isn't the desired effect.
Everything in the FPS demo seems to work perfectly, so I tried just modifying that scene to adapt it to a 2d game, but the object tree is rather complex and I haven't yet fully wrapped my head around how everything works. Any help would be appreciated!

Try adding the slots manually?


I fixed all the imports and i fixed the btn

So in the code, I have done here I have fixed all the imports since none of them generally worked and I made the logo image a div with a background image, we can change the height and width if you would like just contact me, I also centered the logo, it looks currently more appealing but it can change as well.
I had to import sass into this project in order to change the color of the text and to change the text decoration.
For any more help please let me know. i would like to help more on this project.

i added !important in main.sass otherwise it wont work

with my three pushes, you can see the push that says fixed the footer to stay at the bottom you will have a code that in a nutshell will have the entire homepage looking very good.
The logo is fine, the footer is fine, and the button has the color as requested.
I hope i can help again the future.

I have upgraded the look quite a lot in my last pull request, now there is no need to scroll in the page if there is a single page, and I fixed the logo to have the same margin on top and bottom in the navbar.

Hi,
The issue with the cards was there in the beginning, I tried to solve the issues at hand.
I will see if I find the time to work on the other issue. I made many pushes for I made different looks and different solutions, you can choose which one you want to use and leave that one in the branch.


min num shards

Description
Added logic for the number of shards: greater of user specified min_num_shards and a calculated value based on (variants*samples)/2147483519 translated to int((mt.count_rows() * mt.count_cols())/2147483519).
NOTE: I don't know where<PHONE_NUMBER> comes from, it was just given to me, it's slightly less than 2^31. Should I use (2^31 - 2^10) =<PHONE_NUMBER>  just to make sure we have a larger num shards?
Testing
I tested this locally on the 1kg30 dataset (which as expected calculated the shards to be 0 since the data is so small), but have not run that formula on actual data like RGP. @mike-w-wilson we should do that to make sure that formula gives us what we expect.
Add on
Piggybacked on this PR to add the hail version to the global annotations --> ES metadata.
TODO
Optional, but make the min_num_shards configurable in Airflow (I seriously doubt it will be used much though if the formula is accurate).

2147483519 is the ES limit on docs per index. We get that number from ES error messages. I found this online.

This is due to the shard exceeding the Lucene limitation on max # of documents per Lucene index. Lucene has a max # of documents per Lucene index limitation. As of LUCENE-5843 94, the limit is 2,147,483,519 (= Integer.MAX_VALUE - 128).

Changed 2 Billion to 1.4 Billion to be safe.


build in modern mode

The original vue cli 3 supports amazing modern mode which is not currently supported by yarn ssr:build.

I just tried to implement this in #199. You can use it, but modern mode is currently not configurable but baked in, and it's not thoroughly tested.
Since it all stronlgy relies on the internal workings of vue cli (ModernModePlugin), all this is not very pretty and it feels like the best solution would be to wait for (or participate in) a rewrite of vue's template renderer and/or modern mode :/

@Akryum @vue/cli got an update up to next version. Any chance to get support of modern build in vue-cli-plugin-ssr? :pray:


Add origin header to ajax requests in BaseWicketTester

In commits assigned to this issue:
https://issues.apache.org/jira/browse/WICKET-6245
There are following changes in CsrfPreventionRequestCycleListener:

If origin header doesn't exist referer header can be used.
Default no origin behavior was changed to abort.

But the wicket tester doesn't send Origin or Referer header.
Additionally the CsrfPreventionRequestCycleListenerTest.withoutOriginAllowed() method checks Abort action instead Allow.

+1!

I think this should be merged before 7.5.1/7.6.0.
@papegaaij , @dashorst WDYT ?

I think this is nice to have, but not crucial. I'd go for 7.6

7.6 is fine.

https://issues.apache.org/jira/browse/WICKET-6274

Merged!
Thank you, @amichalowski !

Please close this issue!

@amichalowski Ping!

closed;
thank you


Documented toTime

Hey @danilobuerger,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

Thanks!


Link sends you to a 404

On this page: https://pub.dev/packages/firebase_analytics
This link send you to a 404 page:
https://codelabs.developers.google.com/codelabs/flutter-firebase/#6

@Salakar This one should be removed as well.

Closing as this has been fixed


specs: versioned namespace IDs

Context
ADR 14 reached Accepted status.
Problem
The specs-staging branch does not describe the version byte for namespace IDs
Proposal
We may want to hold off on this until the implementation is complete and merged.

Update the specs-staging branch to describe the version byte for namespace IDs.
Update all relevant diagrams

Closed by https://github.com/celestiaorg/celestia-app/pull/1550


format credit card number after Autofill

Hi,
is there a way to format the credit card number after Autofill by the browser.
e.g. the user has their card details saved in chrome / Edge etc and is prompted to use it when they enter the credit card field. the Autofil enters the card number without spaces e.g.<PHONE_NUMBER>221111 and it is not automatically formatted to 4444 3333 2222 1111.
if you paste<PHONE_NUMBER>221111 into the credit card box it does format it 4444 3333 2222 1111.
thanks for your help.
very useful library
jack

Hmmmm i would assume autofill would fire the change event.  If you do some research on what event is fired on autofill we might be able to fix it.

the following fires:
$("[id*='CCInputFieldName']").on('blur input', function () {
alert();
});
but i do not think i have access to a function to format the input box
thanks for replying

Weird these are the DOM events mapped to the field...  Looks like formatCardNumber is called on "input" but not on "blur" but i thought "input" should cover it?
  @formatCardNumber: (el, maxLength) ->
    Payment.restrictNumeric el
    QJ.on el, 'keypress', restrictCardNumber(maxLength)
    QJ.on el, 'keypress', formatCardNumber(maxLength)
    QJ.on el, 'keydown', formatBackCardNumber
    QJ.on el, 'keyup blur', setCardType
    QJ.on el, 'paste', reFormatCardNumber
    QJ.on el, 'input', formatCardNumber(maxLength)

that is a bit beyond my technical knowledge.
at the moment autofill is unformatted like this

when i manually key them in, its formatted correctly.
the same is true if i paste<PHONE_NUMBER>221111

perfect! that worked
genius

Thanks for testing fixed for 2.4.4

rockstar

I have to revert this change as it broke mobile browsers see #161

I still have this issue on 2.4.6

Yes see my comment above that is had to be reverted because it broke mobile browsers


Default window.navigator.userAgent value is undefined

Using<EMAIL_ADDRESS>I get the following error from modules using navigator.userAgent:
Cannot read property 'indexOf' of undefined

According to the README, there is a default UA used in requests and set in jsdom.js#L314-L325.

config.userAgent: the user agent string used in requests; defaults to Node.js (#process.platform#; U; rv:#process.version#)

However, there is no default value for window.navigator.userAgent in browser/Window.js#L309-L311, and browser module authors assume userAgent will always be a string. I can confirm that the errors go away by defaulting to a string:
get userAgent() {
  return options.userAgent || '';
}

If a PR from me would save rather than waste your time, I'd be happy to give it go. Where would you want tests to go?

Hmm yeah, both requests and navigator.userAgent should be using that default value. A PR would be lovely. Tests could go in the old https://github.com/tmpvar/jsdom/blob/master/test/jsdom/index.js blob I guess :)

I wrote a test – https://github.com/necolas/jsdom/commit/c27e1466b1ae13f7c45ce37bdfa88796f6543c06 – but it passes. Applying it to 7.2.2 also results in a pass. That seems to make sense, since the Window is created with the config from jsdom that sets the default UA. So I'm now confused as to why we're getting that error :)

Maybe it is a difference when using jsdom.jsdom() in the tests vs. jsdom.env() or something else in your original code?

ah, yes it is. i'll close since the issue isn't in jsdom; would you like the test put up as a PR anyway?

Are you sure it's not a bug in jsdom? jsdom.env() and jsdom.jsdom() should both have a default user agent...

If I change the test as follows, it still passes:
var document = jsdom.env('', function (err, window) {
  test.strictEqual(typeof window.navigator.userAgent, 'string', 'window.navigator.userAgent should be a string');
  test.strictEqual(window.navigator.userAgent, defaultUserAgent, 'window.navigator.userAgent should have the correct default value');
  test.done();
})

I can provide a bit more context based on the digging around I did earlier today. We have a Karma plugin to launch jsdom, it's fairly simple and sets up jsdom but the userAgent is undefined in the test/app files.
// some-browser-component.js

console.error(window.navigator)
// =>
// Object{userAgent: undefined, appName: 'Node.js jsDom', platform: 'darwin', appVersion: 'v5.4.0', noUI: true, cookieEnabled: true}

Logging the UA from within the jsdom created callback confirms that the default UA string is correctly set at that point.
// jsdom-launcher.js
const jsdomBrowser = function (baseBrowserDecorator) {
  baseBrowserDecorator(this);

  this._start = function (url) {
    jsdom.env({
      url: url,
      features : {
        FetchExternalResources: ["script", "iframe"],
        ProcessExternalResources: ["script"]
      },
      created: function (error, window) {
        console.error(window.navigator.userAgent) // => "Node.js ..."
      }
    });
  };
}

I'm assuming that doing work outside of the callbacks may be a problem, and thought the fix lies there rather than jsdom :)

I have the same problem with Karma + jsdom@7, window.navigator.userAgent is undefined even if I'm trying to modify it in created callback. any solutions? rolling back to jsdom@6 helps.

I would really appreciate a repro that does not involve Karma.

Despite my best efforts, I could not reproduce this outside of Karma. However, for what it's worth, I bisected the problem to commit 2c8933905e9b81436843fe8d429918876a277e54.

It appears to only affect iframes which explains the problems with the karma runner. I've replicated with this:
const jsdom = require('jsdom'),
  http = require('http');

http.createServer((req, res) => {
  res.writeHead(200, {'Content-Type': 'text/html'});
  res.end('');
}).listen(8000);

jsdom.env({
  html: '',
  features: {
    FetchExternalResources : ['script', 'iframe'],
    ProcessExternalResources : ['script']
  },
  onload: (window) => {
    console.log(
      window.document.querySelector('iframe').contentWindow.navigator.userAgent
    ); // => undefined
  }
});

Ah! I was just about to post about the iframe thing. Long story short, karma loads its stuff in an iframe, and I am also able to create a reliable test case where navigator.userAgent is undefined in the iframe


Anaconda 2.2 update causes Spyder to crash on Linux

After installing the latest version of Anaconda 2.2 on a Linux machine, I could not launch Spyder or other python applications that used Qt for the gui.  I received the following error:

In the /usr/bin/qtconfig I had to change the GUI Style to anything other than Oxygen to make Spyder launch and use other qt applications.
After making the above changes, everything in Spyder works fine except clicking on the File explorer tab causes the entire application to crash.

The error from the crash is another symbol lookup error:

The Object inspector and Variable explorer tabs work fine.

I suppose it's linked to this comment: https://github.com/spyder-ide/spyder/pull/2281#issuecomment-88255168

This problem is directly related to the Qt version shipped by Anaconda, and it doesn't have anything to do with Spyder per se.
@wigging, it seems that the changing styles option is not enough. So I'm going to compile and provide a new Qt version for Anaconda, tailored specifically to work with KDE based distros.  i'll create a special Binstar channel to upload it, and I'll let you know when it's ready here (hopefully tomorrow :-)

@wigging, we (i.e. Continuum) updated our Qt and PyQt packages yesterday to solve this problem (without changing styles or using a special Binstar channel).
Just run
conda update pyqt

and let us know if now things work for you :-)

@ccordoba12 The pyqt update fixed the problems I was having with Spyder on Linux.  Everything is working now.

Glad it works for you know. It took like three or four days to find the error ;-)


Dockerfile: Create custom bundle - pmem-csi

Using 'mixin' utility one can build custom bundle and can ask swupd to migrate
to custom mix.  Now we create a custom bundle named pmem-csi that holds all
packages we depend on - lvm2, e2fsprogs, xfsprogs, and file. This way we need
not to install huge 'storage-util' bundle and reduce the image size.
Now pmem-csi-driver image size came down to : 470MB. We can still reduce the
size once this issue got resolved:
https://github.com/clearlinux/swupd-client/issues/937
That allows us to remove below unneeded bundles from our image:

findutils
libglib
libstdcpp
os-core
os-core-update
os-core-webproxy
p11-kit

ATM, fails here:
Starting download of remaining update content. This may take a while...
Error: Could not download all files, aborting update
Update took 5.1 seconds, 0 MB transferred
Update failed.
The command '/bin/sh -c swupd update && swupd bundle-add mixer &&     mixin package add file --bundle pmem-csi &&     mixin package add xfsprogs --bundle pmem-csi &&     mixin package add e2fsprogs-extras --bundle pmem-csi &&     mixin package add LVM2-bin --bundle pmem-csi &&     mixin build &&     swupd bundle-remove mixer sysadmin-basic os-installer linux-firmware-extras acpica-unix2 containers-basic git curl diffutils dnf glibc-locale gzip htop iperf iproute2 kbd kernel-install less man-pages minicom openssl parallel patch perl-basic powertop procps-ng pygobject  python3-basic strace sudo tmux tzdata unzip wpa_supplicant linux-firmware-wifi xz zstd libX11client lib-opengl lib-openssl which &&     swupd update --migrate &&     swupd bundle-add pmem-csi &&     swupd clean &&     rm -rf /var/lib/swupd &&     mkdir -p /etc/lvm && echo "global { use_lvmetad = 0 }" >> /etc/lvm/lvm.conf' returned a non-zero code: 17

Amarnath Valluri<EMAIL_ADDRESS>writes:

Would it be possible to run mixin build in one container, then start from scratch again in another where one copies over the output of that command and does the swupd update --migrate && swupd bundle-add pmem-csi? Then we avoid this whole fragile cleanup procedure.

No, it's not possible to split "mixin build" and "swupd update
--migrate" to different containers, swupd loses the context to do the
needed custom update.

That context is just a set of files. We just need to know what those are
and copy them.

@avalluri do you have a list of RPMs you need for your minimal docker image?

@avalluri do you have a list of RPMs you need for your minimal docker image?

Here is the list: lvm2, e2fsprogs, xfsprogs, and file.
And to make image compact, the os-core-update bundle and its dependencies (findutils, libglib, libstdcpp, os-core-webproxy, p11-kit) could be removed from the final image.


Refactor Visualizer to use Deque for stack instead of Map

Performance related comment - In the 'getDotSuffix()' method, it is obtaining the pos of value.lastIndexOf('.') and not saving it.  That is an expensive call - linearly accessing the String.  Save the value in a local, and then re-use it the return statement on the next line.