Fix loop spinning forever when signal delivery races with uv_close()

If we are closing a signal handler that has pending events, we have
two options: we can ignore the pending signal or we could invoke the
handler immediately now. We can't insert it back into the closing queue
to process it later since that could result in use-after-free (e.g. if
the handler uses handle->data and that is free()'d after calling
uv_signal_stop()). To avoid indefinitely retaining a handle in the
handle_queue, we simply ignore all further signals on this handle, since
otherwise we would end up with an event loop that is permanently spinning.
This fixes the behaviour of the newly added test signal_delivered_in_handler.

The macos test failure looks unrelated to me - I see it failed in the same way in https://github.com/libuv/libuv/commit/d59b2905f9e0e8cddd7033e3a0b87cdec415c908

Sorry for the delay. I'd been wanting to get to this earlier but you know how life is.

We can't insert it back into the closing queue to process it later since that could result in use-after-free (e.g. if the handler uses handle->data and that is free()'d after calling uv_signal_stop()).

That doesn't sound right. uv_signal_stop() stops the handle synchronously. If your callback is invoked afterwards, that's a bug, but your test doesn't call uv_signal_stop() so I assume that's not what you mean.
uv_close() is not a concern. Its contract explicitly stipulates the handle should be kept alive until the close callback.
If you want to change the uv_close() behavior of a uv_signal_t to discard pending signals, that's something I could get behind - the user likely isn't interested in them anymore anyway - but the code comments should reflect that.

the test seems to pass fine for me, with some quick fixes to the test to avoid relying on undefined behaviors in event loop ordering
diff --git a/test/test-signal-pending-on-close.c b/test/test-signal-pending-on-close.c
index b0d580a4f..6bd3a5df9 100644
--- a/test/test-signal-pending-on-close.c
+++ b/test/test-signal-pending-on-close.c
@@ -128,6 +128,8 @@ void worker_signal_handler(uv_signal_t* handle, int signum) {
   uv_close((uv_handle_t*)handle, close_cb);
   /* after this signal handler caught_signals==1,dispatched_signals==2, which
    * can cause the loop to end up in an infinite looping state */
+  ASSERT_EQ(2, handle->caught_signals);
+  ASSERT_EQ(0, handle->dispatched_signals);
   free(context);
   /* Should still have a libuv handler */
   ASSERT(!signal_handler_is_default(SIGUSR1));
@@ -152,6 +154,7 @@ void worker_threadfunc(void* user_arg) {
   uv_sem_post(&wait_for_worker_thread); /* Thread initialization done. */
   uv_sem_wait(&wait_for_main_thread); /* Wait for raise(SIGUSR). */
   ASSERT_EQ(0, close_cb_called);
+  ASSERT_EQ(1, uv_run(&worker_loop, UV_RUN_ONCE));
   ASSERT_EQ(0, uv_run(&worker_loop, UV_RUN_ONCE));
   uv_sem_post(&wait_for_worker_thread); /* Completed uv_run(). */

@@ -160,7 +163,7 @@ void worker_threadfunc(void* user_arg) {
   ASSERT_EQ(1, close_cb_called);
   ASSERT_EQ(0, uv_loop_alive(&worker_loop));
   ASSERT_EQ(2, worker_sig.caught_signals);
-  ASSERT_EQ(1, worker_sig.dispatched_signals);
+  ASSERT_EQ(2, worker_sig.dispatched_signals);

   ASSERT_EQ(0, uv_loop_alive(&worker_loop));
   ASSERT_EQ(0, uv_loop_close(&worker_loop));
@@ -214,7 +217,6 @@ TEST_IMPL(signal_delivered_in_handler) {
   ASSERT_EQ(0, uv_loop_close(&loop));
   ASSERT_EQ(2, close_cb_called);

-  MAKE_VALGRIND_HAPPY();
   return 0;
 }

Thanks for looking into this again - I will need to rerun my experiments to see if I accidentally reduced the test case too far to remove the hang that I was seeing.


Jitter buffer improvements

The very simple jitter buffer implemented in #54 is functional but very simple. There are many improvements that could still be made. Suggestions so far include:

Detecting network traffic delay and dynamically adjusting the buffer length
Replacing the time-based delay with sample-based delay

This would also allow for tests to be written against it without attempting to simulate time

Improving jitter buffer configurability. Right now, the desired delay is available as a property on each buffer object. A separate value is actually used privately. The private value is only updated when the jitter buffer "starts" delaying. A more elegant solution with more options should be on the table, especially if dynamic adjustment is made available.

Detecting network traffic delay and dynamically adjusting the buffer length
The best approach to this would be to measure the standard deviation of elapsed time between packets arriving and set the buffer to some multiple of that.
Replacing the time-based delay with sample-based delay
This would be really nice for both testing and more exact timing (we're configuring everything with wall clock time, but really we don't care about that, just how many samples of time have elapsed in the audio system).
Dynamic Adjustment
This is surprisingly tricky to do. To expand or shrink the buffer you basically have two options:

Chain a resampler and resample the audio to the "wrong" rate but then play back at the normal rate. This drains the buffer faster/slower but also changes the pitch so you have to keep the rate change very low (5% or less is pretty much inaudible).
Modify the signal to stretch it (by repeating very small clips of it) or squash it (by cutting out very small clips).


[Bug]: Tablet V2 Doesn't Select Row When Clicking on Menu Button

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I add a Table V2 widget with a Menu Button column, the row is no longer automatically selected after the user clicks on a menu button option. I expect the row to be selected in order to complete an action against the row (e.g update field in row, delete row).
Steps To Reproduce

Create a new application
Drag and drop a "Table" widget
Add a new column
Set the column type to "Menu Button"
Add a "Menu Item"
Publish the app, and observe the row not being selected after clicking on a menu item.

Public Sample App
https://app.appsmith.com/app/table-issue-example/page1-62e3f7944003a7259a2f8081
Version
Self Hosted - 1.7.9

@lukearran you can use {{Table1.triggeredRow}} as a property in the meanwhile

@lukearran you can use {{Table1.triggeredRow}} as a property in the meanwhile

Thanks @Nikhil-Nandagopal

I don't see this as a bug. If the onRowSelected event handler would trigger when the button was clicked, then there's no way to distinguish between a click on the button and on the table row itself. Selecting the row and clicking the button are two entirely separate events. If you want the row to be selected you should be able to set Default Selected Row in the button event handler.

@lukearran in tables, clicking on a button will not select a row. Hence we suggest using the triggered row binding instead.


Week4  problem 5 and 6 missing

The implementation for the two problems from week is missing :
organizing a lottery
Closest Points
Please update the readme accordingly!

Thanks Tasawar. I will upload them right now.
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
05/29/20,
03:25:35 PM
On Fri, May 29, 2020 at 9:20 AM Tasawar Hussain<EMAIL_ADDRESS>wrote:

The implementation for the two problems from week is missing :
organizing a lottery
https://github.com/AbdallahHemdan/Algorithmic-Toolbox-San-Diego/blob/master/week4_programming_challenges/5_organizing_a_lottery
Closest Points
https://github.com/AbdallahHemdan/Algorithmic-Toolbox-San-Diego/blob/master/week4_programming_challenges/6_closest_points
Please update the readme accordingly!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AbdallahHemdan/Algorithmic-Toolbox-San-Diego/issues/4,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSUGNH6VP47KNSKBHHEASDRT5O3PANCNFSM4NNZIIIQ
.

Thanks, Tasawar I have just added the solution of the 2 problems and Sync them with the readme file.

organizing a lottery
Closest Points


[WIP: debugging]Add repairnator-pipeline dockerimage for k8s deployment (#813)

Hi, This is a PR breakdown in reference to this issue (#813) and original PR (#814) for deploying repairnator on Kubernetes. This PR only contains the pipeline image and some documentation :) .

Since you are not adding any new java tests we should be comfortable ignoring the failing CI (and spare me the trouble of copying your fork to check the CI).

Good progress! It's good that we start with a pull-request with this new folder kubernetes, and later in a subsequent PR, we'll change the way repair attempts are made (today calling docker is hardcoded in RtScanner which calls DockerPool).

Yes :) , I'll put the rest of the contents in our original fork after this PR is merged .

I propose to rename folder kubernetes into repairnator/kubernetes-support

Hi @monperrus @btellstrom , are the tests for repairnator still flaky ? :) . I have done 6 attempts with different locations of my "kubernetes" folder. the different between the first "debug attempt" resulted to success is no different than the "debug attempt nr 6" and the last one failed despite being the same. It seems like the faulty is not due to my folder. :)

it should be solved, please rebase against master.

Hi the problem has to do with this issue (#744) explained by @btellstrom in this PR. So it has nothing to do with flaky test or my own commits :) . Also, I'll make a new PR for this since this PR has become a bit dirty.


Refactoring/status code

What is this pull request?
This pull request

updates cpp_redis and tacopie library up to 4.3.0 version with fixes
changes transaction status name from ON_PROCESS to IN_PROGRESS
fixes failing tests in Torii module
adds removal of CLion debug folder in clean.sh

Why do you implement it? Why do we need this pull request?
Initially I was planning only to change transaction status name. However, I had updated version of cpp_redis library, so I decided to update the project.

@Warchant please update cpp_redis lib in CI

Reason why builds are failing — Circle CI is using image which is not updated. Consider reviewing it on a local machine and after approval we will update image together with rebase

Don't forget to rebase.

ci doesn't like it :(


Application Error, The connection to the server was unsuccessful. (http://<IP_ADDRESS>:8100)

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Launching the app in android device with liveload and console output ionic run android -lc shows after a while this error:

Our app is very very big with a lot of components and a lot of external angular and javascript libs. It takes also a long time in production (--prod) or on run android or emulate android mode to load the app, more then 10 seonds.
Expected behavior:
The error should not appear, and setting up the cordova timeout is not a solution (which btw also didn't work for me).
What can I do to resolve this and what can I do to speedup the loading of the app?
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.5.0
Ionic Framework Version: 2.1.0-201702281739
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.8
Node Version: v6.10.0
Xcode version: Not installed

You should open this ticket at  driftyco/ionic-app-scripts instead of this repo.

Closing this since it was opened on app-scripts, thanks!


Error message should make it clear --topic-prefix or --topic can be used

--topic OR --topic-prefix can be passed, but error messages do not make this known - they say "--topic" is required.
The error message must reflect the allowed values.
$ rhoas kafka acl grant-access --producer --user ephelan_kafka_devexp
❌ "--topic" flag is required for consumer and producer operations. Run the command in verbose mode using the -v flag to see more information

Hello @craicoverflow , I'm interested in solving this issue, can you assign it to me.


Add camera triggering in omnibus

I am working on how to correctly enable and define pins for camera triggering for omnibus F4 SD.
Default it is not enabled and if enabled from cmake pin not defined error occurs. Please guide me the exact pin definition of 5 and 6 for omnibus F4 SD.

error occurs.

Can you paste the actual error?
And can you give some more background on what you're trying to achieve and what exactly you have tried, and what docs you have looked at, etc.?

The camera trigger parameters doesn't appears by default as the camera trigger driver is disabled to save flash since omnibus has 1MB memory. So what i have done is uncommented the camera_trigger in driver section in default.cmake in board/omnibus folder.
And then i ran  make omnibus_f4sd_default
The error i get is this

After some digging into code and tracing the error I went into ~/Desktop/Firmware/boards/omnibus/f4sd/src/board_config.h
I uncommented
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
`/* User GPIOs
*

GPIO0-5 are the PWM servo outputs.
GPIO_TIM3_CH3OUT        GPIO_TIM3_CH3OUT_1 //PB0 S1_OUT D1_ST7
GPIO_TIM3_CH4OUT        GPIO_TIM3_CH4OUT_1 //PB1 S2_OUT D1_ST2
GPIO_TIM2_CH4OUT        GPIO_TIM2_CH4OUT_1 //PA3 S3_OUT D1_ST6
GPIO_TIM2_CH3OUT        GPIO_TIM2_CH3OUT_1 //PA2 S4_OUT D1_ST1
GPIO_TIM5_CH2OUT        GPIO_TIM5_CH2OUT_1 //PA1 S5_OUT
GPIO_TIM1_CH1OUT        GPIO_TIM1_CH1OUT_1 //PA8 S6_OUT
*/

#define _MK_GPIO_INPUT(def) (((def) & (GPIO_PORT_MASK | GPIO_PIN_MASK)) | (GPIO_INPUT|GPIO_PULLUP))
#define GPIO_GPIO0_INPUT             _MK_GPIO_INPUT(GPIO_TIM3_CH3IN)
#define GPIO_GPIO1_INPUT             _MK_GPIO_INPUT(GPIO_TIM3_CH4IN)
#define GPIO_GPIO2_INPUT             _MK_GPIO_INPUT(GPIO_TIM2_CH4IN)
#define GPIO_GPIO3_INPUT             _MK_GPIO_INPUT(GPIO_TIM2_CH3IN)
#define GPIO_GPIO4_INPUT             _MK_GPIO_INPUT(GPIO_TIM5_CH2IN) //Uncommented here
#define GPIO_GPIO5_INPUT             _MK_GPIO_INPUT(GPIO_TIM1_CH1IN) //Uncommented here
#define _MK_GPIO_OUTPUT(def) (((def) & (GPIO_PORT_MASK | GPIO_PIN_MASK)) | (GPIO_OUTPUT|GPIO_PUSHPULL|GPIO_SPEED_2MHz|GPIO_OUTPUT_CLEAR))
#define GPIO_GPIO0_OUTPUT            _MK_GPIO_OUTPUT(GPIO_TIM3_CH3OUT)
#define GPIO_GPIO1_OUTPUT            _MK_GPIO_OUTPUT(GPIO_TIM3_CH4OUT)
#define GPIO_GPIO2_OUTPUT            _MK_GPIO_OUTPUT(GPIO_TIM2_CH4OUT)
#define GPIO_GPIO3_OUTPUT            _MK_GPIO_OUTPUT(GPIO_TIM2_CH3OUT)
#define GPIO_GPIO4_OUTPUT            _MK_GPIO_OUTPUT(GPIO_TIM5_CH2OUT) //Uncommented here
#define GPIO_GPIO5_OUTPUT           _MK_GPIO_OUTPUT(GPIO_TIM1_CH1OUT) //Uncommented here
`
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
and further down
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
`#define GPIO_TIM3_CH3OUT        GPIO_TIM3_CH3OUT_1 //PB0 S1_OUT D1_ST7
#define GPIO_TIM3_CH4OUT        GPIO_TIM3_CH4OUT_1 //PB1 S2_OUT D1_ST2
#define GPIO_TIM2_CH4OUT        GPIO_TIM2_CH4OUT_1 //PA3 S3_OUT D1_ST6
#define GPIO_TIM2_CH3OUT        GPIO_TIM2_CH3OUT_1 //PA2 S4_OUT D1_ST1
#define GPIO_TIM5_CH2OUT        GPIO_TIM5_CH2OUT_1 //added this
#define GPIO_TIM1_CH1OUT        GPIO_TIM1_CH1OUT_1 //added this
#define DIRECT_PWM_OUTPUT_CHANNELS      4
#define GPIO_TIM3_CH3IN         GPIO_TIM3_CH3IN_1
#define GPIO_TIM3_CH4IN         GPIO_TIM3_CH4IN_1
#define GPIO_TIM2_CH4IN         GPIO_TIM2_CH4IN_1
#define GPIO_TIM2_CH3IN         GPIO_TIM2_CH3IN_1
#define GPIO_TIM5_CH2IN         GPIO_TIM5_CH2IN_1 //added this
#define GPIO_TIM1_CH1IN         GPIO_TIM1_CH1IN_1 //added this
#define DIRECT_INPUT_TIMER_CHANNELS  4
`
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Here is the complete file
board_config.h.txt
Also in ~/Desktop/Firmware/boards/omnibus/f4sd/src/timer_config.c
I modified the file like this
added PA1 S5_OUT entry and PA8 S6_OUT entry for the Trigger pins
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
`/*

OUTPUTS:
M3 : PA3 : TIM2_CH3
M4 : PA2 : TIM2_CH4
M1 : PB0 : TIM3_CH3
M2 : PB1 : TIM3_CH4
*/

__EXPORT const timer_io_channels_t timer_io_channels[MAX_TIMER_IO_CHANNELS] = {
//PB0 S1_OUT D1_ST7
{
.gpio_out = GPIO_TIM3_CH3OUT,
.gpio_in = GPIO_TIM3_CH3IN,
.timer_index = 1,
.timer_channel = 3,
.ccr_offset = STM32_GTIM_CCR3_OFFSET,
.masks  = GTIM_SR_CC3IF | GTIM_SR_CC3OF
},
//PB1 S2_OUT D1_ST2
{
.gpio_out = GPIO_TIM3_CH4OUT,
.gpio_in = GPIO_TIM3_CH4IN,
.timer_index = 1,
.timer_channel = 4,
.ccr_offset = STM32_GTIM_CCR4_OFFSET,
.masks  = GTIM_SR_CC4IF | GTIM_SR_CC4OF
},
//PA3 S3_OUT D1_ST6
{
.gpio_out = GPIO_TIM2_CH4OUT,
.gpio_in = GPIO_TIM2_CH4IN,
.timer_index = 0,
.timer_channel = 4,
.ccr_offset = STM32_GTIM_CCR4_OFFSET,
.masks  = GTIM_SR_CC4IF | GTIM_SR_CC4OF
},
//PA2 S4_OUT D1_ST1
{
.gpio_out = GPIO_TIM2_CH3OUT,
.gpio_in = GPIO_TIM2_CH3IN,
.timer_index = 0,
.timer_channel = 3,
.ccr_offset = STM32_GTIM_CCR3_OFFSET,
.masks  = GTIM_SR_CC3IF | GTIM_SR_CC3OF
},
//PA1 S5_OUT
{
.gpio_out = GPIO_TIM5_CH2OUT,
.gpio_in = GPIO_TIM5_CH2IN,
.timer_index = 0,
.timer_channel = 2,
.ccr_offset = STM32_GTIM_CCR2_OFFSET,
.masks  = GTIM_SR_CC2IF | GTIM_SR_CC2OF
},
//PA8 S6_OUT
{
.gpio_out = GPIO_TIM1_CH1OUT,
.gpio_in = GPIO_TIM1_CH1IN,
.timer_index = 0,
.timer_channel = 1,
.ccr_offset = STM32_GTIM_CCR1_OFFSET,
.masks  = GTIM_SR_CC1IF | GTIM_SR_CC1OF
}
};`
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Here is the complete file Note that I have postfix .txt extension for uploading here
timer_config.c.txt
All these entries are just pattern matching from other four entries. I dont know anything at micro controller level so strongly suspect these things will make things wrong.
But what i noticed now the error was fixed and successfully built. I uploaded the code and tried camera triggering and the trigger works on camera but what i found is changing interval or trig_modes parameters doesn't change anything. The camera is always triggered at 31 Hz no matter what params i change. I think i did things in wrong way there are more things to modify and that needs in depth knowledge of timers and pins at micro controller level. Omnibus actually uses STM32 F405 RGT6 MCU.

Thanks for the info. FYI @bkueng @davids5

Thanks for the info. FYI @bkueng @davids5

I hope someone comes out and solve this issue. Though its not a bug just a feature needs to be added in omnibus F4 board. I will be glad if i contribute something.

@Razbotics - without digging in on this what I can tell you is the PWM rate is set per TIMER. The Timer has channels and all timers channels run at the same rate.
The above channel allocation looks incorrect.
There are 2 timers. TIM2 and TIM3 with 2 channels each.
This is notes here correctly.
 *  M3 : PA3 : TIM2_CH3
 *  M4 : PA2 : TIM2_CH4
 *  M1 : PB0 : TIM3_CH3
 *  M2 : PB1 : TIM3_CH4

This is incorrect:
timer_index = 0 -> means that TIM2 is indexed.
      //PA1 S5_OUT
	{
		.gpio_out = GPIO_TIM5_CH2OUT,
		.gpio_in = GPIO_TIM5_CH2IN,
		.timer_index = 0,
		.timer_channel = 2,
		.ccr_offset = STM32_GTIM_CCR2_OFFSET,
		.masks  = GTIM_SR_CC2IF | GTIM_SR_CC2OF
	},
      //PA8 S6_OUT
	{
		.gpio_out = GPIO_TIM1_CH1OUT,
		.gpio_in = GPIO_TIM1_CH1IN,
		.timer_index = 0,
		.timer_channel = 1,
		.ccr_offset = STM32_GTIM_CCR1_OFFSET,
		.masks  = GTIM_SR_CC1IF | GTIM_SR_CC1OF
	}

@davids5 Well i get that my timer configuration for pin 5 and 6 on omnibus is incorrect. The 4 PWM motor pins are correctly defined and i don't have to make any changes to them. I want the pin5 or pin6 to have triggering capabilities for camera, So for that i seek help for correcting pin configuration on omnibus board target.

@Razbotics you will need a copy of the schematic to verify the wiering as to what pins are used. Then you will need to add the timer definitions (see px4\fmu-v5 for an example)  There will need to be 4 timers. Then the index of the channels need to point to timer index 2 and index 3. The Timers need to have the first and last index of the channels. First = last = 4 and First = last = 5 for the timers respectively. Then in board_config.h you will need to change DIRECT_PWM_OUTPUT_CHANNELS and DIRECT_INPUT_TIMER_CHANNELS  to 6

@davids5 thanks for the info, and sorry for the late reply. I got what you want to say is that i have to dig into schematics for pinouts. But what is the line "First = last = 4 and First = last = 5 for the timers respectively" means. Can you please elaborate on that? It would be helpful.

I have configured and activated all 6 PWM pins on Omnibus according to there TIMERS and CHANNELS mentioned in schematics. But still the camera trigger is not working properly. No matter what trigger params I change the camera triggers at 25Hz at all 6 pwm pins. Even if I disable the trigger in params, the camera continues to get triggered at 25HZ, Strange.
I am expecting some help here @davids5 @bkueng @mhkabir


Link to video on Wiki results in 404

The following link which is on the Wiki page and should be a video of add ORSSerialPort to an Xcode project is a dead link that results in a 404:

https://www.dropbox.com/s/0p8henumbjq9xgw/AddORSSerialPort.mov?dl=0

Thanks for reporting this. I'll see if I can find it and fix the link.


Create goldbergjeffrey.md

Hi @goldbergjeffrey, thx. eMail received.

@goldbergjeffrey Could you please resubmit this PR against the master branch? We didn't see it was put against the cla-1.1 branch and accidentally merged. (Sry for the inconvenience).

please see #6

Perfect, thanks!


efl: 1.19.1 -> 1.20.1

Motivation for this change
Upate to version 1.20.1
News
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Check the Travis log, this seems to break ephoto

Check the Travis log, this seems to break ephoto

I have asked on #e and have got the answer:

yeah there was a wrong include in ephoto, it should work for ephoto-git

Ephoto: Remove unneccessary header.

Check the Travis log, this seems to break ephoto

I have asked on #e and have got the answer:

yeah there was a wrong include in ephoto, it should work for ephoto-git

Ephoto: Remove unnecessary header.
But apparently it does not work.

hmm, so we can't just include that patch in ephoto?

With the patch ephot compiles, but does not run.
Marking this PR as work in progress for now.

I think the PR is ready for committing.
I am keeping two versions of efl: the current one (1.19.1) for ephoto, and the new one (1.20.2). When a new release of ephoto which works with 1.20.x is available, we can drop version 1.19.1.


How to combine named breakpoint with type of orientation?

Hi, I need to combine named breakpoint with orientation. Somthing like this: @media breakpoint(medium portrait) {} To obtain @media screen and (min-width: 640px) and (orientation: portrait) {}. How I can do this?
Thanks for help.

The Foundation forum would be a great place to seek some help with troubleshooting what might be going on here. If it turns out to be a defect, you'll have some more info to provide here which will help prioritize and get it fixed.
We're trying to keep the issue list focused on confirmed defects in Foundation, so any help everyone can provide to differentiate between usage / troubleshooting and actual defects is appreciated!

We were working on a feature to combine media queries, but differences between Libsass and Ruby Sass made it too difficult to implement before 6.0.0 shipped. The syntax would look like this (note the comma separation):
@include breakpoint(medium, landscape) {
}

In the mean time, you can get the behavior you want by using breakpoint() as a function:
@media screen and #{breakpoint(medium)} and #{breakpoint(landscape)} {
}

Question: when will the implementation of cobined breakpoints like width and modus are done?
@include breakpoint(medium, landscape) {}
Thanks a lot.

@havutcuoglu it seems it was never implemented.
Not sure if there is / was a specific branch for this or some PR.
See https://github.com/foundation/foundation-sites/blob/v6.6.3/scss/util/_breakpoint.scss#L52

@havutcuoglu it seems it was never implemented.
Not sure if there is / was a specific branch for this or some PR.
See https://github.com/foundation/foundation-sites/blob/v6.6.3/scss/util/_breakpoint.scss#L52

Yes I checkend it before. Also it is not possible to get 'Portrait' or 'Landscape' modus in javascript.
That's not nice. I think the orientation is an important breakpoint.

PRs which add this are very wlcome.

@gakimball is this possibility combined breakpoints like width and orientation in your example are implemented now?
@media screen and #{breakpoint(medium)} and #{breakpoint(landscape)} {
}

If yes, in which version of foundation?
Thank you very much and best regards


One UWP runtime Installation  error

A Visual Studio UWP Runtime often cannot be installed because it was already installed through the Windows Store - No fix
known (recognizable by a short, visible, red PowerShell code)

Fixed in v7.1


add kind property to deserializer logic

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

/azp run python - azure-communication-email - tests


chown: changing ownership of '/var/lib/postgresql/data': Input/output error When running the image in Kubernetes

I'm using OSS filesystem in Alibaba, similar to S3 in AWS.
Can someone assist why this is happening?

Same issue https://github.com/docker-library/postgres/issues/361
As Yosifkit said: this seems like a general debugging question and not really a problem with the image, it'd be better to post questions like this in the Docker Community Forums, the Docker Community Slack, or Stack Overflow.
Closing since this issue is environmental, not something we can really fix in the image.

this seems like a general debugging question and not really a problem with the image

Its a clear BUG to me, I say reopen and address it rather than closing it because you found "other related issue" which is also closed btw. That is why it was not resolved because you keep closing the issue. Let other people see and solve it rather than burying it into the deep.

It sounds to me like the filesystem you're using (or the driver you're using to access it) do not support chown -- you'll need to either resolve that or run the image directly as a user with access to the filesystem so that it skips the chown code (with --user on docker run; there should be a similar option for Kubernetes).
As far as I can see, there's nothing we can change about the image to fix this environment-specific issue?

Sounds good enough, the filesystem permission can be changed via the UI so I guess that solves it. Maybe address a proper error if something fails specifically to this error? That could be a big help to anyone.

you'll need to either resolve that or run the image directly as a user with access to the filesystem so that it skips the chown code (with --user on docker run; there should be a similar option for Kubernetes).

Use securityContext in k8s to specify the user, but the pod can not start:
# kubectl logs -f test-5fc6b7bbf4-v7425
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

initdb: directory "/var/lib/postgresql/data/pgdata" exists but is not empty
If you want to create a new database system, either remove or empty
the directory "/var/lib/postgresql/data/pgdata" or run initdb
with an argument other than "/var/lib/postgresql/data/pgdata".

This usually happens when postgresql attempts chown on the /var/lib/postgres/data directory, and if this is mapped to the host file system, it will end up changing the permissions on host too.
This is especially problematic if the host is a Windows device using NTFS filesystems, where unix-style permission changes are not allowed. I can think of two solutions:

Either prevent postgresql from changing ownership and work normally otherwise by some containerization policies.
Or enable docker-compose methods to simulate file system permissions when bindings to host data are used.

If you run the container directly as a non-root user, it will completely avoid the chown logic (because it can't ever work in that case).  For docker run, that's the --user flag, for docker-compose that's the user: key, and for Kubernetes that's runAsUser:+runAsGroup:.


Json Schema: Add tests for JSON Schemas

Currently, there are no explicit tests for JSON schemas. There are a few places in the code path that test for some invalid values, but it doesn't cover all schemas.
Potential solution: https://github.com/json-schema-org/JSON-Schema-Test-Suite

Testing facility added in https://github.com/lyft/envoy/pull/715. Thanks @danielhochman !


Redis Pool links go up but not down

this is my setting
redisHandle = redis.NewClient(&redis.Options{
Addr:         addr,
Password:     pwd,
DB:           db,
MinIdleConns: 28,
IdleTimeout:  30,
PoolSize:     512,
MaxConnAge:   30 * time.Second,
})
_, err := redisHandle.Ping().Result()
if err != nil {
panic(err)
}

You can consider reducing the value of poolsize.

In addition, the IdleTimeout option is time.Duration, you set 30 (nanoseconds), a connection is only idle for 30 nanoseconds, the correct setting example: 2 * time.Second

If you have a new discovery, you can reopen the issue.

ok,thinks


Wr/timeout message

What does this PR do?
refactors similar util files into one
refactors similar types files into one
catches a timeout error so that the timeout event listener can properly handle, and print instructions
What issues does this PR fix or reference?
@W-16010988@

QA: Willie and decided offline that the NUTs are sufficient QA for this PR.


Export transformer from react-plugin

Description
When building a custom plugin, e.g. one that transforms svg content into a React component, you also want to have it be HMR-ready.
Thing is, it's tricky to do it as it is now.
On Webpack you can "chain" loader and do what you want, but on Vite there's no visible way to do it.
SInce vite react plugin contains all the code needed to achieve this, how about exporting the methods needed (e.g the transform method) so that developers can just wrap their code with it and have HMR out of the box.
Suggested solution
import { apply}  from '@vitejs/plugin-react'

Perhaps something like this.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

The way to do this with Rollup's plugin API is that as long as the import id is captured by @vitejs/plugin-react too, e.g. if your plugin uses the resolveId hook to resolve *.svg -> *.svg.jsx and have a load hook that handles loading that path (because that path won't exist in the filesystem), plugin-react would then run it's transform hook for that file or import id.


Partial DFA.html revert

The change broke the roll buttons, but fixed the Fate Point calculations.
Rolling back the changes to the approaches.
Changed Mantle approach to fixed text because it never saved what was inside the text box. Also changed it to roll specifically for the mantle instead of Intellect as a fix from the first version.
I'm have no idea how to create flexible, saving text boxes for the approaches and still have them work, so this might be the next best option. Hopefully you (Ikidaore) or someone else can figure out a fix.

If you want a Git user to be notified about a message you have to put an @ before their name. Like: @Ikidaore


Sync manifests with kubeadm

Found more options that is not sync'ed between our manifests and the kubeadm deployments

ci check this

/lgtm

/lgtm cancel

@mirwan Good catch. Fixed

closed in favor of #3383


[AutocompleteField] Added shouldRenderSuggestions, stop event propagation and flag for deciding if suggestions are shown if field is empty

Coverage increased (+0.1%) to 99.716% when pulling c21de3ffea8e91709648e394c33a69d49fc2247f on mplacekCS:master into 690a724592abb5889d9d77e0fbee4a783809b13b on mprzodala:master.

Coverage increased (+0.1%) to 99.859% when pulling d05e2fd2883afd61b3652f8ac7131cd1a55ab55b on mplacekCS:master into eb3a92e2e050d1f908dd8127976531693d6007ad on mprzodala:master.

I've also added onSuggestionSelected callback handler to provide user possibility to listen to specific option selection.

Coverage increased (+0.1%) to 99.859% when pulling ee8708915c1491a9939aa10988a21074562676bc on mplacekCS:master into eb3a92e2e050d1f908dd8127976531693d6007ad on mprzodala:master.


Terminal. SendText did not wait for the execution of the prev command to complete

When the command has elapsed time, the following command does not wait.
I need to queue up to execute it. What should I do?

This is as designed, follow https://github.com/microsoft/vscode/issues/145234 for possible improvements in this area


deps: Move from winapi to windows-sys

winapi is in maintenance mode and the new blessed way to access Windows APIs are the windows
and windows-sys crates. I don't think any types of winapi were exposed in the public API so
I used windows-sys since it has much faster compile times.

Can you please also fix the bitness function?

Thanks!


Reset moz-focus-inner

Without these properties, it’s impossible to completely reset the extra padding Firefox sets on <button> elements.

:+1:

:+1:

:+1:


Exclude Root from Cloud Formation

Please describe which feature you have a question about?
I'm trying to write the correct CF YAML to use only a subdomain of a root domain that will not be part of my project. I would like to do it from CF if possible, but I don't see how to set 'exclude root' as is possible in the Add Domain UI. Won't the following set up both example.com and mySub.example.com (and possibly www.example.com as well)? I just want to grab mySub.example.com.
Provide additional details
  AmplifyDomain:
    Type: AWS::Amplify::Domain
    Properties:
      AppId: !GetAtt AmplifyApp.AppId
      DomainName: example.com
      SubDomainSettings:
        - Prefix: mySub
          BranchName: master

Hi, your template is the right template that excludes root domain. If you want to include root domain,
your template should be like :
AmplifyDomain:
    Type: AWS::Amplify::Domain
    Properties:
      AppId: !GetAtt AmplifyApp.AppId
      DomainName: example.com
      SubDomainSettings:
        - Prefix: ''
          BranchName: master
        - Prefix: mySub
           BranchName: master

Thank you very much. One more quick question - is there a way in the CF template to specify the production branch?

@oakstreetrec No. We don't support that for now


Add a Copy object button

I got an idea. When viewing the details of an object, there should be a Copy button:

The Copy button copies the object (so a check of the signature should be done before adding the Copy button), and it should be possible to Paste that copied object as argument of a method.
Maybe it should be possible to copy more objects, so we can paste all them in a method that has more than 1 argument.

Long press on the description cell ;)

@NSExceptional I totally forgot that! 🤦♂ Good to know. However it would be nice to copy more than one object at once, to keep track of copied addresses directly in the app so we can easily paste multiple addresses :)

I agree! I'm going to add a "bookmark" feature at some point so you can save objects for later use in method calls


Extend the char array to allow multi digit  values

Got the temperature setting to work with minimal changes. The catch is that the commands I used (0x2306 for room temp and 0x6300 for hot water temp) operate on temperature differently than the other datapoints handled by the TEMP datapoint type:

TEMP is a 2 byte floating point value multiplied by 10 (so 0x1400 == 2,0)
0x2306 is a 1 byte int storing the temp directly (so 0x14 == 20) - I'm reusing the MODE datapoint type (#define TEMP_1B  MODE) - this is why I needed to extend the char array
0x6300 is a 2 byte int storring the temp directly (so 0x1400 == 20) - I'm reusing the COUNTS datapoint type (#define TEMP_INT COUNTS).

It might be prettier to actually extend the enum in the future - adding the 2 new DataPoint types and just reusing ModeDP and CountSDP internally - but that is a decision I don't feel comfortable making on my own, and the code is enough to get me through the winter ;)

Extending the enum and adding DPs is indeed my preferred way of work.
But I'm a bit occupied with merging the KW en 300 protocol into 1 branch. Will take a look at this when it's ready.
But I'm happy your "shortcut" is working.


Update Orion-LD 0.6.1

Proposed changes
This PR updates Orion-LD versin to 0.6.1.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 97d9a3ff581a8b972b62d43f5fb665095c17e588 on fisuda:update/dokcer-compose.yml into 8ebddd08ebda5fc68b8bb467977f06977e4caecd on lets-fiware:main.


Should XDG_CONFIG_HOME default to ~/AppData/Local on Windows?

Nevermind that I'm using a POSIX-style path as shorthand in the issue title, should be evident how much I like thinking about Windows :)
~/.config isn't a widely used file path on Windows, and it seems to be what this module will default XDG_CONFIG_HOME to. I haven't tested on macOS yet, but I'd expect to get something like ~/Library/Application Support/ there by default. Would it be out of scope or a violation of this module's design to use those paths by default?

FYI, these environment variables seem to be set by default under Windows:
LOCALAPPDATA=C:\Users\axfel\AppData\Local
APPDATA=C:\Users\axfel\AppData\Roaming

It looks like this is fulfilled by https://github.com/ActiveState/appdirs

There is some discussion related to this in #3: so far I've considered conventions such as %APPDATA% on Windows and ~/Library on macOS as out of scope, as xdg follows the specification strictly. As you found, appdirs is a solution if you want to follow platform-specific conventions.


Rename FILA

 Rename the tab FILA to ARV in pharmacy module

Coverage remained the same at 63.21% when pulling 8c2e67390d683a63af8bd527feefb5d484e91204 on ynurmahomed:rename-fila into b6662a4522715c92942b5ae51dda432379e8b35e on esaude:master.


Add request timeout to POST call

Similar to https://github.com/agardnerIT/logpusher/issues/5
Add request timeout to POST call: https://requests.readthedocs.io/en/latest/user/advanced/#timeouts

Closing as done in #44


Scales off across climate entities

The set point is the same but the scale on the image is different:

70 should be at the same location for each entity

@kylerw it really depends on what your climate component reports as min/max. Probably can be added a config option to override that but at the moment it's using what the backend component is reporting.
You can use dev tools to check what min_temp/max_temp is currently reported on each of your thermostats.

@kylerw can you let me know if min/max is identical between thermostats? You can check this in dev-info panel.

Hallway: 50/90
Theo's Room: 64/86
Bonus Bedroom: 64/86

Is that done in the climate entity setup?

Yes
Sent with GitHawk

I will close this as it's not related to the card. Please reopen if you find it's still a problem after you set min/max in the backend climate entity setup.


Delete token from cache after use

Today the application doesn't delete the created token after it was used from a "Double Check" request. This could lead to a security problem and use of the same token for more than one request.
When a application verifies a token and it is correct, it should be removed from the cache to prevent its use for the same verification request again.

I would like to work on this, pls assign it to me

Hey @rexdivakar how are you?
Is everything OK with the implementation?


TN-2989 correctly manage 'next' in 2FA

2FA was being thwarted by unauthenticated request to restricted resources.  Difficult to wire in with flask-user, but found a way by patching the make_safe_url() function of flask-user.
Replaced the token term with code as suggested in parent story TN-2974

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/views/auth.py:

Line 611:80: E501 line too long (80 > 79 characters)


Fix font option of CFG

Originally, the font option is only applied to spec CFG.
Because we add font option at override toString function at DotPrinter object.
But when dumping analyzer CFG, we use Graph case class.
Thus, I added a font option to the toDot function in the Graph case class.
Also, I fixed the font option Helvetica to Consolas

Thanks, @duncan020313! It successfully resolved the font issue in DOT files produced in ESMeta.


PUP-7685: puppet resource user may show double groups

This patch resolves PUP-7685

CLA signed by all contributors.

Would it be possible to update with some logic that will issue a debug message when it actually needs to do some deduplication? That might help users who know they should be seeing multiple groups to track down what Puppet is doing.

I've added a debug notice

@jcpunk I think @Magisus meant something along the lines of:
dedup_groups = groups.uniq
if groups != dedup_groups
  debug("Duplicate groups have been removed")
end
dedup_groups.join(",")

This way the debug message only happens if there were duplicate groups.

I've updated the code based on the suggestion above

Yes, that is the kind of thing I meant 👍

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jcpunk I tweaked the commit message a little to better fit with the convention we use (22312fd8d4e6d086d82e28ffcfcccf5993fc7cd1). The commit still credits you as the author, it just seemed a little silly to kick this out even further when the code itself looks fine. Thanks for doing this!
Merged via 21fda7d39d2cae5f83ca63071b1aa851274ed942.

Actually merged via 7f0c88fa0d8c35f6207498af9574f2a2ecb5742c (turns out that I pushed to the wrong repo for 21fda7d39d2cae5f83ca63071b1aa851274ed942 ☹  ).


Script length issue applying against Azure SQL databases

What version of Flyway are you using?
4.2.0
Which client are you using?
Command-Line
What database are you using (type & version)?
Microsoft SQL Azure (RTM) - 12.0.2000.8   Sep 19 2017 11:48:47
What operating system are you using?
Windows 10
What did you do?
We constructed a rerunable script to maintain data in a template system. Our script was structured as follows, it did not include any GO statements:
DECLARE all table variables (4 in total) ~4 lines
INSERT INTO all the table variables the data to maintain. ~70 lines
MERGE statements for all the tables in question using the table variables as sources. ~125 lines

The command is
flyway migrate -url=jdbc:jtds:sqlserver://xxxx.database.windows.net/xxxx -locations=filesystem:.\db -user=xxxx -password=xxxx
What did you expect to see?
I expected the migration to complete flawlessly as tested against local database servers, and manually against Azure using SQL Server Management Studio.
What did you see instead?
Migration R__ComponentTemplates.sql failed
------------------------------------------
SQL State  : 08S01
Error Code : 0
Message    : I/O Error: Connection reset
Location   : ./db/R__ComponentTemplates.sql (D:\Projects\xxx\db\R__ComponentTemplates.sql)
Line       : 1
Statement  : DECLARE @Template TABLE (Id INT, Name NVARCHAR(500), Description NVARCHAR(MAX), IsActive BIT)

Our workaround to resolve the issue
We altered the structure of the script to the following to reduce the line count between GO statements:
DECLARE table variable
INSERT INTO all table variable
MERGE statements for the table in question using the table variable as sources
GO

DECLARE table variable
INSERT INTO table variable
MERGE statements for the table in question using the table variable as sources
GO

DECLARE table variable
INSERT INTO table variable
MERGE statements for the table in question using the table variable as sources
GO

DECLARE table variable
INSERT INTO table variable
MERGE statements for the table in question using the table variable as sources
GO

This solved the issue, and proves that FlyWay has a buffer problem streaming long sections of code to a remote server over lower than LAN latency connections. Reducing the sections between GO statements to < 50 lines works. This is not the first script that we have had to do this for. All our scripts worked 100% using SSMS.

Flyway only passes these statements to the JDBC driver, which is where the issue must lie. Flyway 5.0 will ship with the official Microsoft SQL Server driver instead of jTDS, so hopefully this should sort itself out automatically, as unfortunately there is not much else we can do on our end.

What is the projected release date of 5.0?

End of the month

So I just downloaded 5.0.2, but this issue persists. The documentation (https://flywaydb.org/documentation/database/sqlserver) does not show another URL format other than through JDBC. It is just not up to date yet? What is the native MS SQL Driver format for command line? Thanks.


Numa gxm

can you please resubmit for numa_gxm branch?

I will merge it into numa_gxm, so no problem this time.

Merged.


Running SICER2 with biological replicate

Hi
I'm trying to use SICER2 to ChIP peak calling
I have 2 biological replicates for TF-Myc   and 2 biological replicates for WT
TF-Myc-ChIP-rep1,         TF-Myc-ChIP-rep2,
TF-Input_rep1,                TF-Input_rep2
WT-Myc-ChIP-rep1,        WT-Myc-ChIP-rep2,
WT-Input_rep1,               WT-Input_rep2
My question is

is SICER2 possible to handle biological replicates or do I need to merge replicates and run SICER2?

to detect TF binding peak,  do I need to compare
TF-Myc-ChIP  vs WT-Myc-ChIP  or
TF-Myc-ChIP  vs TF-Input ?

SICER2 does not handle replicates automatically. You can either merge replicates and run SICER2 on the merged data files, or run SICER2 on each biological replicate separately. The latter is usually a better way, unless there is other evidence supporting that the replicates are similar enough.

What exactly do TF-Myc and WT-Myc mean? It depends on what biological question you are asking, or what analysis goal you want to achieve?

thank you for your reply
for question 2
TF-Myc is Transcriprtion Factor genes tagged with Myc  and immunoprecipitated with anti-Myc
WT-Myc is  immunoprecipitated with anti-Myc in Wild Type
Because there is no Myc in WT, theoritically, WT-Myc-ChIP does not have peaks
Input is total DNA used for input control
Because input is total DNA, TF-Input does not have any specific peak but basal level of read will be detected.
so I wonder which comparison would give a better peak calling
TF-Myc-ChIP vs WT-Myc-ChIP or
TF-Myc-ChIP vs TF-Input ?
I hope my post would help for your better understanding

You can use sicer_df that takes into account for both WT and input.
Calling SICER with control libraries for differential peak calling.
sicer_df -t TF-Myc-ChIP.bed WT-Myc-ChIP.bed -c TF-Input.bed ET-Input.bed

great. thank you for your kind explanation.
ps. I hope that SCICER2 would support biological replicates in the near future

Thanks for the feedback!


rustup; adjust for rustc_driver changes

@bors r+

:pushpin: Commit c4ed745ea76bd44e04881fc55654a8f6b117cbad has been approved by RalfJung

:hourglass: Testing commit c4ed745ea76bd44e04881fc55654a8f6b117cbad with merge ef1937f0fc83ab188ba5a70a0fcce94a4de68ee3...

:broken_heart: Test failed - status-appveyor

@bors r+

:pushpin: Commit eaf56c57e55503a3aa47333aac73162de6049a51 has been approved by RalfJung

:hourglass: Testing commit eaf56c57e55503a3aa47333aac73162de6049a51 with merge e046963ed62736e17c6e7a75cd6fecf0d7a50045...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing e046963ed62736e17c6e7a75cd6fecf0d7a50045 to master...


Update branding to 3.1.10

Will update the SDK version tomorrow

Why send this out w/o the SDK update❔

The 3.1.109 SDK won't be available at the stable location until tomorrow


use travis instead of gitlab-ci

The .gitlab-ci.yml file should be rewritten to a .travis.yml file

Perhaps https://github.com/ypconfig/ypconfig/issues/18 should supersede this issue.

It will.


[Feature]: Add preset mode attribute to thermostat card

Is your feature request related to a problem?
Frustrating not knowing what preset mode my thermostats are currently in. Would be nice to have this presented in a similar way to "status".
Describe the solution you'd like
Several thermostats has preset mode attribute available and that would be beatuiful to add to the termostat card.
See available preset modes, "preset_modes:"
hvac_modes: off, heat
min_temp: 7
max_temp: 35
target_temp_step: 0.1
preset_modes: away, eco, sleep, comfort, none
current_temperature: null
temperature: null
hvac_action: off
preset_mode: comfort
icon: mdi:fire
friendly_name: Bad 1. etg Gulvvarme
supported_features: 17
Describe alternatives you've considered
No response
Additional context
No response

That would be awesome!

Duplicate of #615.


Logger Login Creds

Hi team,
I am running into an issue where the logger machine asks me for creds to log in. Does anyone know what those creds are? It is asking me password and user name.

Please read https://detectionlab.network

On Mar 14, 2022, at 7:28 PM, Dhore @.***> wrote:

Hi team,
I am running into an issue where the logger machine asks me for creds to log in. Does anyone know what those creds are? It is asking me password and user name.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

Thanks for the help, Chris. Now I have another issue with windows machines. This is specific to only windows machines. Any help will be appreciated. Thanks,
Timed out while waiting for the machine to boot. This means that
Vagrant was unable to communicate with the guest machine within
the configured ("config.vm.boot_timeout" value) time period.

Hi @BSH77, if you are still having issues, please open up a new issue


Access logging

Hi,
I'm trying to understand how the logging works and what's currently available.
I was trying to search in examples but didn't find a solution to get these in the log:

entries for 404s (atm incorrect requests are not showing up in the log, which might be a feature or a bug 😅 )
remote IP address
HTTP status code of the response

Are these supported or something that needs changes?
Thanks 🙇

Hey, to support these we need to make some adjustions. Currently, the logging is quite dummy and 404s for unhandled paths are not covered at all, see the access logging extension and error logging extension.
I'm in front of a rewrite of the internals to Http from @effect/platform and the logging we'll be probably imlpemented using middlewares. So I'll probably enable the listed items along with the rewrite.

Got it, thanks for the update. Looking forward to using these additions :-)

Hey, the rewrite was released. With the newest version, you can compose the App built by effect-http/RouterBuilder with the @effect/platform Middleware. In the middleware, you can access both ServerRequest and ServerResponse and use it however you like.
I'll probably prepare a section about middlewares, routers and the stuff from @effect/platform in the readme later.


Weird bug

Expected behaviour
Tell us what should happen.
I want to pick a date, but it goes wrong. (https://gyazo.com/a2c55486e35088525393edd691390068)
I'm using the latest version of datepicker
Code:
      $('.datepicker').datepicker({
          format: 'yyyy-mm-dd',
      });

Recently same bug hit me . In my case I changed the input type date  to  text .


ES: Corrupt Test Data JSON Files

Affected Country: ES
Issue Description
Corrupt Test Data JSON Files. Most likely due to CERTIFICATE field spread across multiple lines.
@Santivicen , @daniel-eder
Looks like due to recent pull request https://github.com/eu-digital-green-certificates/dgc-testdata/pull/156
Reference:
https://github.com/eu-digital-green-certificates/dgc-testdata/blob/main/ES/2DCode/raw/2001.json
https://github.com/eu-digital-green-certificates/dgc-testdata/blob/main/ES/2DCode/raw/2002.json
Proposed Solution
Remove new line characters from CERTIFICATE field might fix this.

Hi, we have remove that wrong test. There was a problem with pull request and old files where added on it. So sorry.

Thank you, @Santivicen !
Closed in #200


code for teleoperation using Quest?

Hi, impressive work!
It is mentioned in your paper that besides spacemouse, you also used Oculus Quest to perform teleoperation, could you share the relative code for that? Thanks!

@johnnevins As I know, this work also uses Quest as teleop, FYI.

i wander the same ...


Not an issue. A compliment

This is just awesome. Exactly what I needed and have been planning to build since so long. Thanks a lot for making such a simple and effective tool. Here is how I use it:
In my bash profile:
alias pst="java -jar ~/Downloads/worldtime.jar America/Tijuana"

So everytime i type in pst in my terminal I have the time!

Hello.  That's nice of you to say.  Thank you for the kind words.  I work with people overseas and being able to quickly understand their time is helpful to me.  I also have the same alias but I've called it wt  😊


resume ignoring the duration

I was trying to make the slideshow to pause when a mouse enters backstretch area, and resume when mouse leaves. And found out that resume triggers next() which ignores the slideshow duration completely and forces to show next slide right away. This is causing slideshow trigger to show next slide every time mouse goes on and off the backstretch area.
Shouldn't resume function in jquery.backstretch.js trigger cycle() instead of next()?
from line 296 in Backstretch - v2.0.4 file
, resume: function () {
// Resume the slideshow
this.next();
return this;
}
Below is my code utilizing backstretch with pause/resume function
var $carouselElem = $('#myCarousel')
//Initialize backstretch
$carouselElem.backstretch(
backstretchImages
, {duration: 10000, fade: 750}
);
//Backstretch slide controller
$carouselElem.find('.next').click(function(e) {
e.preventDefault();
$carouselElem.backstretch("next");
});
$carouselElem.find('.prev').click(function(e) {
e.preventDefault();
$carouselElem.backstretch("prev");
});
//pause when mouse is over the slide
$carouselElem.mouseenter(function() {
$carouselElem.backstretch("pause");
});
$carouselElem.mouseleave(function() {
$carouselElem.backstretch("resume");
});

I, too, am trying to fix this issue.  I tried making it call the cycle method instead of the next method and it seems to make little difference.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/marvingrieger/ioBroker.pallazza

[x] [E019] Invalid repository URL: https://github.com/ioBroker/ioBroker.pallazza. Expected: git+https://github.com/marvingrieger/ioBroker.pallazza.git
[x] [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.pallazza"
[x] [E605] No actual year found in copyright. Please add "Copyright (c) 2020 Marvin Grieger<EMAIL_ADDRESS>at the end of README.md

I have also found warnings that may be fixed if possible.

[x] [W113] Adapter should support compact mode
[x] [W400] Cannot find "pallazza" in latest repository

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Do you need help fixing the bugs?

Fixed, compact mode is addressed in #5.

Fixed, compact mode is addressed in #5.


Bump version to 0.12.0

Description of Changes
We have merged https://github.com/clockworklabs/spacetimedb-csharp-sdk/pull/116 which relies on version 0.12.0 of packages in the SpacetimeDB repo.
API
No; it's more that this tracks an already-merged breaking change.
Requires SpacetimeDB PRs
https://github.com/clockworklabs/SpacetimeDB/pull/1578

This is being done in https://github.com/clockworklabs/spacetimedb-csharp-sdk/pull/120


[release-1.18] gateway: fix and test unmanaged skipping

This is an automated cherry-pick of #44401

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio_release-1.18
8b56a3428ec466603f6dc505011f6f310b58ac2a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-mc

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio_release-1.18
8b56a3428ec466603f6dc505011f6f310b58ac2a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-mc

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio_release-1.18
8b56a3428ec466603f6dc505011f6f310b58ac2a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-mc

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio_release-1.18
8b56a3428ec466603f6dc505011f6f310b58ac2a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio_release-1.18
8b56a3428ec466603f6dc505011f6f310b58ac2a
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn Trying to figure out why the new test in the PR is failing. I suspect there is some other cherrypick needed. Maybe https://github.com/istio/istio/pull/44528.

@ericvn thanks, I did it manually since I don't know how else to do it unless we merge a flaky test


No matches found with pictures of same area but with slight perspective shift.

Matcher Works where the images just have an affine shift in my opinion like if image was translated,rotated or resized but when there is a perspective transformation it fails giving 0 matches.

Either good features were not extracted.
Maybe Ransac Failed.
OpenCv SiftCpu version easily finds the matches and computes a homography matrix even OpenCV SurfGPU find the matches in these images.
Need Someone to explain to me why matcher is not working

and how can i resolve it?

Do you mind uploading the images and the parameters you used for the matching code? It seems weird, but maybe there is some logical explanation.

Link To the images.
https://jmp.sh/8IvnR76
Parameters for SiftFeaturesDetection
int numOctaves = 5;    /* Number of octaves in Gaussian pyramid / // 5
float initBlur = 1.0f; / Amount of initial Gaussian blurring in standard deviations /
float thresh = 3.5f;   / Threshold on difference of Gaussians for feature pruning /// 3.5 default
float minScale = 0.0f; / Minimum acceptable scale to remove fine-scale features /// default 0.0
bool upScale = false;  / Whether to upscale image before extraction */
Parameters for finding Homography
FindHomography(siftData1, homography, &numMatches, 10000, 0.0f, 0.80f, 5.0);// max amb 0.80
int numFit = ImproveHomography(siftData1, homography, 5, 0.00f, 0.80f, 3.0);

I would recommend you to change the maxAmbiguity parameter from 0.80f to 0.90f or even up to 1.00f to completely disregard it. The parameter sets the threshold for how similar two possible matches are allowed to be for a match to be accepted. For man-made structures where you have many corners that look similar (such as houses) and when you have a lot of features, you have lots of similar structures and it's too harsh to set the parameter to 0.80f. I believe that In OpenCV you don't have such a test at all unless you implement it yourself. I get about 800 matches or so, which seems a bit few. I might look at it a bit deep later. My hunch is that there are loads of false positive matches due to the similarities between structures.

Changing the max ambiguity parameter improved the results considerably.
800 matches is much better than none.Increasing max ambiguity to more than or equal to 1 starts getting lesser matches 0.9 seems optimal at this stage
Would now try comparing the homography computed from the SiftCPU Version and upload the results
for comparison.
Thank you for the effort btw.

No problem. I'm looking forward to hearing about your comparison.


Fc hiveplot

Convert Hiveplot dir to functional component

😍 - Is this ready for review?

😍 - Is this ready for review?

@amcdnl yep it is ready.

@amcdnl yep it is ready.

@amcdnl fixed, one comment is open for your decision.

@amcdnl fixed, one comment is open for your decision.

@ynahmany - Want to take a stab at animating this w/ framer-motion?

@ynahmany - Want to take a stab at animating this w/ framer-motion?

@ynahmany - Want to take a stab at animating this w/ framer-motion?

That sounds interesting, will take a look!

@ynahmany - Want to take a stab at animating this w/ framer-motion?

That sounds interesting, will take a look!


Need a better error message when kestrel cannot get the requested port

#This is what I see when Kestrel cannot get the port I asked for. This is on .NET Core 2.1 RC1 (with a 2.0 app).
pi@raspberrypi:~/dotnet-docker/samples/aspnetapp/aspnetapp $ export ASPNETCORE_URLS=http://+:80
pi@raspberrypi:~/dotnet-docker/samples/aspnetapp/aspnetapp $ dotnet run
crit: Microsoft.AspNetCore.Server.Kestrel[0]
      Unable to start Kestrel.
Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvException: Error -13 EACCES permission denied
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.ThrowError(Int32 statusCode)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.ThrowIfErrored(Int32 statusCode)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.tcp_bind(UvTcpHandle handle, SockAddr

@halter73
Have you tried a 2.1 app?

Same error message in 2.1.201
System.AggregateException: One or more errors occurred. (Error -4092 EACCES permission denied) ---> Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvException: Error -4092 EACCES permission denied
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.ThrowError(Int32 statusCode)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvTcpHandle.Bind(IPEndPoint endPoint)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Listener.ListenTcp(Boolean useFileHandle)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Listener.<>c.<StartAsync>b__8_0(Listener listener)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.DoPostWork()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.ListenerPrimary.<StartAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.LibuvTransport.<BindAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.LibuvTransport.<BindAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass23_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindEndpointAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindAddressAsync>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.<BindAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindAsync>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<StartAsync>d__23`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.<StartAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.Start()
   at Microsoft.ServiceFabric.Services.Communication.AspNetCore.AspNetCoreCommunicationListener.OpenAsync(CancellationToken cancellationToken)
   at Microsoft.ServiceFabric.Services.Runtime.StatelessServiceInstanceAdapter.<OpenCommunicationListenersAsync>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.ServiceFabric.Services.Runtime.StatelessServiceInstanceAdapter.<System-Fabric-IStatelessServiceInstance-OpenAsync>d__13.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
---> (Inner Exception #0) Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvException: Error -4092 EACCES permission denied
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.ThrowError(Int32 statusCode)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvTcpHandle.Bind(IPEndPoint endPoint)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Listener.ListenTcp(Boolean useFileHandle)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Listener.<>c.<StartAsync>b__8_0(Listener listener)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.DoPostWork()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.ListenerPrimary.<StartAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.LibuvTransport.<BindAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.LibuvTransport.<BindAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass23_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindEndpointAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindAddressAsync>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.<BindAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.<BindAsync>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<StartAsync>d__23`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.<StartAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.Start()
   at Microsoft.ServiceFabric.Services.Communication.AspNetCore.AspNetCoreCommunicationListener.OpenAsync(CancellationToken cancellationToken)
   at Microsoft.ServiceFabric.Services.Runtime.StatelessServiceInstanceAdapter.<OpenCommunicationListenersAsync>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.ServiceFabric.Services.Runtime.StatelessServiceInstanceAdapter.<System-Fabric-IStatelessServiceInstance-OpenAsync>d__13.MoveNext()<---

2.1.201

@abatishchev the error is different in 2.1, it doesn't look like you're using it. Type dotnet --info, it'll tell you what version of the runtime and SDK you are using. 2.1.201 is the SDK version not the runtime version.

@davidfowl indeed.
.NET Command Line Tools (2.1.201)

Product Information:
 Version:            2.1.201
 Commit SHA-1 hash:  7932dc6179

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.201\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.7
  Build    : 2d61d0b043915bc948ebf98836fefe9ba942be11


v-transition doesn't work at first time when tirgger F5

My file structure is:
- router.js
- app.js

The content in router.js is:
router.map({
    '/home': {
        component: require('./views/home/index')
    },
    '/login': {
        component: require('./views/login/index')
    }
});

router.alias({
    '/': '/home'
});

The content in app.js is:
var router = require('./router')
module.exports = window.app = new Vue();
router.start(app, '#app');

When the page first come, the v-transtion doesn't work, but after that, it works.

看文档。http://router.vuejs.org/options.html#transitiononload


CVE-2007-4559 Patch

Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

This looks legit, but I think a better way to address this issue is to bump node-gyp to v9.2.0 or above rather than patch the vendored code directly.


Updated markup and placeholder CSS file

Oops, meant to leave a description.
This PR basically replaces the markup from the existing claim submitted page and replaces it with the code from the prototype and the relevant CSS to make it work. May need some clean up at a later date when the new frontend is integrated.


Move from md to mdx

To be able to use next/image component and more dynamic content.

Not doing. Unnecessarily overcomplicate with little gains.


Data Preservation

Milestone: Write data to file
The following changes are being introduced:

Method to write or save inputted data to the desired file in .json format.
Method to read or load data from .json file.
Updated other methods to load data from the file on application start up
Created database following the class diagram provided for the genre and music album

This PR resolves the following issues:
#23 #24

👍🏿


docs: update all package readmes with latest changes

Things like the newest CLI options, the new utility package docs, and the AQS docs were not included or linked to from the relevant readme files. This commit catches them up to date.

:tada: This PR is included in version 1.6.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.26.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.30.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


[HOLD for payment 2024-07-10] [$250]  A newly created workspace's room crashes on the details page.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719335250993669
Action Performed:

Create a new workspace and navigate to LHN.
Press FAB -> Start chat -> # Room.
Add a room name and select the newly created workspace.
Press the "Create room" button.
On the workspace room, press the header to navigate to the details page.

Expected Result:
Room Details page should be loaded
Actual Result:
Room Details page crashed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/abfe7f15-f403-4f50-8426-2b978fc0c611

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c68edfdc6e18287a
Upwork Job ID:<PHONE_NUMBER>672282404
Last Price Increase: 2024-06-27

Issue OwnerCurrent Issue Owner: @johncschuster

Proposal
Please re-state the problem that we are trying to solve in this issue.
Create a new room and open the details page will crash the app.
What is the root cause of that problem?
As shown in the error log, the issue is the onyx key is changed from a collection key (report_) to a collection member key (report_-1).
https://github.com/Expensify/App/blob/8f3e925d8044526f60669f06c2010842242c9511/src/pages/ReportDetailsPage.tsx#L82
Creating a new room will optimistically set the parentReportID to an empty string (the param before description).
https://github.com/Expensify/App/blob/8f3e925d8044526f60669f06c2010842242c9511/src/pages/workspace/WorkspaceNewRoomPage.tsx#L109-L123
https://github.com/Expensify/App/blob/8f3e925d8044526f60669f06c2010842242c9511/src/libs/ReportUtils.ts#L4580-L4581
Because it's an empty string, the onyx key becomes report_. The add workspace room API will later return the parentReportID as null which is to clear it from the onyx, so now, the onyx key becomes report_-1.
What changes do you think we should make in order to solve the problem?

We can optimistically set the parentReportID to null,
OR
Use || instead of ??.
https://github.com/Expensify/App/blob/8f3e925d8044526f60669f06c2010842242c9511/src/pages/ReportDetailsPage.tsx#L82

@johncschuster This issue is happening on staging and not on production; it is a deploy blocker

We need to pay $50 to @bernhardoj for identifying the fix

Payment Summary:
Contributor: @jayeshmangwani  - $250 - paid via Manual request (to be paid on/after July 10)
Bug Bounty: @bernhardoj - $50 - paid via Upwork (see comment for decision to pay Bug Bounty)

Contributor: @jayeshmangwani - $250 - paid via Manual request (to be paid on/after July 10)

@johncschuster No payment for me here, as I haven't reviewed the PR

Correct, only @bernhardoj

Desktop is crashing when I click the header. I'm assuming it's a different bug but wanted to check here first.
https://github.com/Expensify/App/assets/22508304/8dcc9c9a-d198-4fdb-a154-4630cd4033fe
Logs
logs-2024-07-09 00_46_30.733.txt

Thanks, @jayeshmangwani! I've updated the payment summary comment and will issue payment now since a bug bounty shouldn't be held on a deploy.

Requested in ND.

Great! I've updated the comment above to reflect you will be paid via ND instead of Upwork. Thank you!

$50 approved for @bernhardoj

It's hard to say; the logs are not that helpful in case of a crash like this.
@mallenexpensify remember that anytime you get this crash, open the console and the reason for the crash will be written there, the logs shared are not the same.
I think we can proceed and the crash should be reported in bug channel showing the console too

I think Melvin is wrong about @bernhardoj's contributions (They identified a fix. I don't think they reviewed any PRs - checking on that.)

Yes, I don't review any PR. The payment is also already approved.

remember that anytime you get this crash, open the console and the reason for the crash will be written there, the logs shared are not the same.

Thanks @mountiny , I was uncertain about this, kinda assumed we'd share errors in the logs we'd be sharing. I'll update the BZ team tomorrow too when I do an EOW post.

Thanks @bernhardoj and @mallenexpensify! Ok, it sounds like we can close this then. Please let me know if I'm wrong!


Add Docker-in-Docker support for Ecosystem pipelines

KubeRay needs Docker in Docker to run their test suites.
This PR updates the ecosystem pipelines to start a dind daemon and connect to it.
Here is an example on how to use it: https://github.com/krfricke/ray-ecosystem-dev/commit/511782b9e7df15dd7ca4b59152826dfd10f56678
The pipeline needs to run on an image that either has docker installed or can install docker later.
Any docker builds must happen in the /shared directory, which is shared between the host VM and the docker container running on CI.
For example, here we just start a ubuntu container and call a install_docker.sh script that installs docker. The build.sh image will then later build a docker image.
- label: Second pipeline
  commands:
    - echo Second command
    - bash install_docker.sh
    - docker ps
    - bash build.sh custom_image
    - docker run -t --rm custom_image cat /tmp/yeah
  instance_size: small
  image: ubuntu:focal

Example for installing docker (install_docker.sh):
#!/bin/bash

export DEBIAN_FRONTEND=noninteractive
export TZ=America/Los_Angeles

export locale -a
export LC_ALL=en_US.utf8
export LANG=en_US.utf8

apt-get update -qq && apt-get upgrade -qq
apt-get install -y -qq \
    curl python-is-python3 git build-essential \
    sudo unzip unrar apt-utils dialog tzdata wget rsync \
    language-pack-en tmux

curl -o- https://get.docker.com | sh

Example for building a Docker image (build.sh):
#!/bin/bash

SHARED_DIR=/shared

rm -rf $SHARED_DIR/*
cp -rf ./docker $SHARED_DIR
pushd $SHARED_DIR/docker
docker build -t "$1" .
popd

IMPORTANT: The /shared directory is shared between the Host system (running on the VM) and the Docker container running in CI! This is where you have to put all the data required for building the image (such as the Dockerfile).

The /shared directory is shared between the host VM and the outermost docker container. The host VM must be able to access the Dockerfile and any other files - thus the docker container must move them to /shared first! Does that make sense?


Fix additional disks being auto-deleted unless a disk type is specified.

It looks like a simple typo causes additional disks to always be auto-deleted unless a disk type is set, which lead to great confusion until I took a look at the code :laughing:.
Thanks for providing this awesome plugin by the way. It's very useful.

Oh wow, this is embarassing 😅

Glad you like the plugin, thank you so much! :)


Upgrade to provide event-based interfaces

Upgraded to open event-based interfaces, while maintaining backward compatibility for contextualize, beforeWalk and afterWalk.

CLA is valid!

@yukinying / @neraliu , please help review and merge. thanks.

can you provide a benchmark result before and after the patch so we know it would not affect the processing speed? thanks!

Code updated.

added event-based interfaces
apply toLowerCase() to tagName and attrName only when needed (to offset the performance of adding new feature).

Stats: (Avg. over 5 times using bin/benchmark)

Before this PR: 24.88MB/sec
After this PR: 26.00MB/sec

These few lines of code changes might break dependent packages/projects who directly access the internal variables:
https://github.com/yahoo/context-parser/pull/16/files#diff-453c94db9d68bf214cb0505c0e0791b5L21

Is there a particular reason you would like those internal variable get renamed?

it's unlike the original implementation which calls toLowerCase() for every single char, but now toLowerCase() is called only when people access it using public getters like getAttributeName() and getStartTagName(). this has improved the benchmark quite significantly (a few MB/sec).
renaming those internal variables is to get dependent projects break if they've replied on them, versus keeping the variable names intact and break others' assumption that they're always in lower case.


Fix division range estimation error in simplifier

Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b.
Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value].

Thanks @kparzysz-quic !