Reconciled release notes 2.11.1 with reversal commit

Signed-off-by: Peter Fitzgibbons<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Assuming https://github.com/opensearch-project/dashboards-observability/pull/1137 was the only change that went onto the 2.11 branch (everything else was reverted) this seems correct to me.


Fix 317

Overview
This PR fixes #317
Changes:

Refactored the core raster extraction function of wps_generic_raster_subset.py to gis.py as a generic function (zonalstats_raster_file()) accepting the stats dictionaries from rasterstats.zonalstats().
Added wps_nalcms_zonal_stats_raster.py. This process is nalcms-zonal-stats with raster output from the core functionality of gis.zonalstats_raster_file().
Performed some quality of life changes (black/isort/f-strings).

Related Issue / Discussion
Additional Information
Links to other issues or sources.

@huard  I'm tempted to run black on wpsio.py, but I want to give you a chance to look it over before the changes are too enormous. All tests are passing on my end.
If everything is looking good from your perspective, I'll add a notebook (or modify an existing one) to make use of the new process, and we'll go from there.
What's the plan on porting updates to RavenPy by the way? I can see there being a lot of use in refactoring utils.py, gis.py, and wpsio.py. I'm wondering how we plan on doing this (all at once? Gradually?).

I suggest we run black over the entire code base in another PR after the switch to RavenPy in a dedicated PR.
Please go ahead with the notebook.
I think we'll port changes from the recent PRs to RavenPy, then modify Raven to depend on RavenPy.
I suggest we do any refactoring in small bits, easier to review and debug.

@huard
Running into a snag here: I realized that some processes returning zip files is really clunky (also, Jupyter notebooks is very careful about saving bytes/potentially executable code), so I'm looking into the METALINKv4 methods, but I can't find any means of reading the data it links to.

It may be the case that the GIS processes that can (potentially) return more than one GeoTIFF (there are at least 2-3 I can think of) may need to be rewritten using the PyWPS-supported transport methods (and not a zip file). Do you have any experience with creating/working with these outputs?

Is pymetalink installed ?
The birdy client has an importer for MetaLink document that fetches its content. However, there is no importer for TIFF files. Adding one would require adding a class similar to this: https://github.com/bird-house/birdy/blob/ed4998154fd723a079c1b5bb773c860cd5affcdb/birdy/client/converters.py#L227

Is pymetalink installed ?
The birdy client has an importer for MetaLink document that fetches its content. However, there is no importer for TIFF files. Adding one would require adding a class similar to this: https://github.com/bird-house/birdy/blob/ed4998154fd723a079c1b5bb773c860cd5affcdb/birdy/client/converters.py#L227

Note that not having a geotiff importer means that the client will return the URL to the geotiff. If there is a well maintained option to read geotiff, we could add an importer to birdy.

Note that not having a geotiff importer means that the client will return the URL to the geotiff. If there is a well maintained option to read geotiff, we could add an importer to birdy.

@huard I'm coming back to this PR today. Changes in https://github.com/CSHS-CWRA/RavenPy/pull/39 should not break anything wrt utils.py and gis.py, but once that PR is ready, I'd like to start re-arranging things in RavenPy which will require refactoring on RAVEN.

@huard I'm coming back to this PR today. Changes in https://github.com/CSHS-CWRA/RavenPy/pull/39 should not break anything wrt utils.py and gis.py, but once that PR is ready, I'd like to start re-arranging things in RavenPy which will require refactoring on RAVEN.

@richardarsenault @huard
This PR is nearly done. It currently requires the new mimetype definitions coming in the new PyWPS (geoTIFF and GeoJSON). It also makes use of newer Proj binaries, so CRS transformations now raise fewer warnings and should be much less prone to buggy behaviour. For backwards compatibility, there is now a NALCMSZonalStatisticsRasterProcess() that does the exact same thing as NALCMSZonalStatisticsProcss() except it also returns raster files (one for each feature, accesible via resp["raster"]) in a PyMetalink XML reference.
From my understanding, this type of object uses some neat magic with converters in Jupyter Notebooks to access the linked files(s). Outside this, the method of accessing them in python scripts is as follows:
from metalink import download as md
from common import get_output
out = get_output(resp.xml)
d = md.get(out['output'], path='/tmp')

PyMetalink is not installed by default in raven (but I've started a conda recipe for it with @cehbrecht https://github.com/conda-forge/staged-recipes/pull/13897).
Once the new PyWPS is integrated, ensuring the notebooks are passing will be a next step. @huard for review, If you could please try the NALCMSZonalStatisticsRasterProcess() yourself, that would be helpful. Thanks again!

@Zeitsperre Does it work on your end ? I got failures here that I tracked to a missing trailing / in ravenpy GEO_URL.

All tests (except for TestNALCMSZonalStatsWithRasterProcess, due to a metalink file-access error) appear to be passing for me. Perhaps we can discuss this soon.

This PR is now dependent on changes in RavenPy (https://github.com/CSHS-CWRA/RavenPy/pull/68), Any refactoring there will demand changes here.

@huard I've updated the PyWPS to 4.4.0, yest I still keep running into the same issue for metalink file access:
...
  File "/home/tjs/miniconda3/envs/raven/lib/python3.8/urllib/request.py", line 1425, in unknown_open
    raise URLError('unknown url type: %s' % type)
urllib.error.URLError: <urlopen error unknown url type: ?xml version="1.0" encoding="utf-8"?>
<metalink xmlns="urn>

The XML is structured fine and urllib3 should not have issues downloading data from file:/// addresses. Here's whole XML string:
<ns0:metalink xmlns:ns0="urn:ietf:params:xml:ns:metalink">
    <ns0:published>2021-03-11T15:50:54Z</ns0:published>
    <ns0:generator>PyWPS/4.4.0</ns0:generator>
    <ns0:file name="subset_1.tiff">
        <ns0:identity>subset_1.tiff</ns0:identity>
        <ns0:size>895973</ns0:size>
        <ns0:metaurl mediatype="image/tiff; subtype=geotiff">file:///tmp/78ac79c8-82ab-11eb-92b7-28d24417f566/subset_1.tiff</ns0:metaurl>
        <ns0:publisher name="None" url="http://localhost/wps" />
    </ns0:file>
</ns0:metalink>

This looks perfectly fine to me. Any ideas?

All tests in test_wps_nalcms_zonal_stats.py pass on my end.

Wait, updated pymetalink and now I get the same error.

I've found 2 possibilities, if that can help any:
A few solutions people have found:
https://stackoverflow.com/questions/28376506/urllib-https-request-urlopen-error-unknown-url-type-https
Another related to the way the string is written:
https://stackoverflow.com/questions/27115803/urllib-error-urlerror-urlopen-error-unknown-url-type-https
Hope that may help, maybe.

Solved. md.get  is made to first retrieve the metalink file, then download its content. You were calling get on the metalink file content directly.

@huard Thanks for the help! With this change and all the PRs for support behaviour, I can finally finish the work I started in... December 2020. very exciting!

Also worth noting: This PR should now close #364 with https://github.com/Ouranosinc/raven/pull/335/commits/326cd3437c9c34f75d6796d7d900a471ef1f5541.

@huard This PR is in working order. If you'd like to give it a final look-over, feel free. Additional changes will be more on par with tweaks.
One thing worth returning to eventually is the desired converter for GeoTIFF files (Birdy). As it stands, asking for an object will return the grid as a numpy.array. Masking the array requires much more information about the data contents, so this should be performed manually.
What I think would be a neat is to convert the data with rioxarray (xarray.open_rasterio + rio module). This would give a lot of control in notebooks. To be discussed eventually.

Ok. Please go ahead and merge, writing a commit message that synthesizes the PR.

The PRs in emu and birdy are all green and ready to be merged.

The last thing I want to fix are the two XFAILED tests that calculate area (test_wps_generic_shape_properties::TestGenericShapePropertiesProcess::test_multifeature_*). I've verified with QGIS that the area values should be what is expected but yet they seem off by a fairly large amount (~100 sq. m.).
Once I get to the bottom of this, I'll merge. Thanks again!

I think I've finally figured out the reason behind the value inconsistencies for the affected tests (test_wps_generic_shape_properties::TestGenericShapePropertiesProcess::test_multifeature_*). Summarizing my findings here.
The transformation from EPSG:4326 to EPSG:6622 involves a geoid transformation (WGS84 -> GRS80), and there are multiple methods for performing it with different levels of accuracies. I've determined that the transformation used is this one:
+proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad +step +proj=push +v_3 +step +proj=cart +ellps=WGS84 +step +inv +proj=helmert +x=-0.991 +y=1.9072 +z=0.5129 +rx=-0.0257899075194932 +ry=-0.0096500989602704 +rz=-0.0116599432323421 +s=0 +convention=coordinate_frame +step +inv +proj=cart +ellps=GRS80 +step +proj=pop +v_3 +step +proj=lcc +lat_0=44 +lon_0=-68.5 +lat_1=60 +lat_2=46 +x_0=0 +y_0=0 +ellps=GRS80

I've adjusted to expected values to reflect this and re-run the disabled tests, updating the values for their new geometries. If we were to return to this, changing the choice of transformation might be worthwhile, but all is working now.

@richardarsenault I believe this finally addresses #317.
We now have wps.nalcms_zonal_stats_raster as a function that replicates wps.nalcms_zonal_stats and also returns the raster file. Eventually this would replace that function, but I'm leaving it for the sake of backwards compatibility.
The notebook Extract_geographical_watershed_properties.ipynb shows how to make use of the new process for extracting the data from it. The last thing left to do is fix a bug with the converters that makes it only return the geotiff as a numpy array (which is nice, but an xarray-like converter would be better. This work for you?

@Zeitsperre This makes total sense, thanks a lot! Looks good! Didn't think this would require so many changes!

@huard For versioning, this raises the version of RavenPy needed to 0.3.0 and refactors out quite a bit of the utility code. Should we be bumping raven-wps to a new minor?

I have a demo on monday where I will want to use JupyterLab notebooks, so please don't break it yet :)

RavenPy is no longer compatible with raven-wps, so this PR is needed for any new builds. Should I wait past Monday for this PR?

I mean, maybe we can merge this without a hitch, I just have no idea if doing so will make the notebooks on JupyterLab obsolete or whatnot. Maybe there is an extra step to update those notebooks on the server that we could just... not do until post-monday?

If everything is working for you right now. I don't want to risk breaking anything in production. I know that tagged releases will trigger rebuilds, so merging this is probably fine so long as we don't tag a version.
Am I right about this @tlvu ? If so, merging this to master should be OK.

If everything is working for you right now. I don't want to risk breaking anything in production. I know that tagged releases will trigger rebuilds, so merging this is probably fine so long as we don't tag a version.
Am I right about this @tlvu ? If so, merging this to master should be OK.

In prod, we use 2 things from this repo:

Raven tutorial notebooks from master branch so merging this PR will deploy new version of notebooks automatically.
Raven docker image from git tag only so merging this PR without making a release won't deploy anything.

I have a feeling @richardarsenault want to keep the notebooks unchanged until after Monday so this PR should not be merged until after Monday.
But if Richard just do not want to deploy a new Raven-WPS version then merging this PR won't automatically deploy.

OK then I suggest we wait until monday night/tuesday AM to merge, just in case. I will be using the notebooks on the server so if they update and there are bugs of any kind, it will be problematic. Might as well wait if you are all OK with this.

Thanks @tlvu for the info!
I'll keep this open for now and move on to the birdy/rioxarray converter. It would be a huge gain to have that (and it's probably easy to get it working).


[MM-28323] Don't show old tutorial or what's new modal for cloud instances

Summary
On first login, users should be brought directly to the next steps view, skipping the what's new modal, and the old style tutorial.
Test steps:
Invite yourself to the spinwick server
login
you should be directed right to the next steps view
(requires cloud license)
Ticket Link
https://mattermost.atlassian.net/browse/MM-28323
Related Pull Requests
n/a
Screenshots
n/a

Forgot that Cloud is string 'true' not boolean true @devinbinnie changed the PR if you want to take another look!


[BUG] NTP check fails with default config

Agent Environment
Agent 7.48.1 - Commit: e3fa058 - Serialization version: v5.0.93 - Go version: go1.20.8
Describe what happened:
The ntp check stopped working, using default config.
Describe what you expected:
That it works…
Steps to reproduce the issue:

Install agent on any Hetzner Cloud instance

Additional environment details (Operating System, Cloud provider, etc):
Running journalctl -u datadog-agent -g 'ntp\.go|cloudproviders\.go' -o cat shows that the Agent incorrectly detects an AWS environment, and chooses to default to their NTP server IP:
2023-10-24 10:06:51 CEST | CORE | INFO | (pkg/util/cloudproviders/cloudproviders.go:54 in DetectCloudProvider) | Cloud provider AWS detected
2023-10-24 10:06:51 CEST | CORE | INFO | (pkg/util/cloudproviders/cloudproviders.go:91 in GetCloudProviderNTPHosts) | Using NTP servers from AWS cloud provider: ["<IP_ADDRESS>"]
2023-10-24 10:06:57 CEST | CORE | ERROR | (pkg/collector/corechecks/net/ntp.go:175 in Run) | Failed to get clock offset from any ntp host
2023-10-24 10:21:57 CEST | CORE | ERROR | (pkg/collector/corechecks/net/ntp.go:175 in Run) | Failed to get clock offset from any ntp host
2023-10-24 10:36:57 CEST | CORE | ERROR | (pkg/collector/corechecks/net/ntp.go:175 in Run) | Failed to get clock offset from any ntp host

This will eventually also report:
2023-10-24 08:48:03 CEST | CORE | WARN | (pkg/collector/corechecks/net/ntp.go:210 in queryOffset) | Couldn't query the ntp host <IP_ADDRESS> for 10 times in a row: read udp <redacted-ip>:60474-><IP_ADDRESS>:123: i/o timeout

This issue is caused by a combination of:

Hetzner Cloud exposing an AWS compatible metadata endpoint at http://<IP_ADDRESS>/latest/meta-data/instance-id
DD agent assuming that this means, that it is a full AWS environment in its check here.

FYI, as a local workaround, this can be fixed using a custom ntp.d/conf.yaml file:
init_config:

instances:
  - hosts:
      - 0.datadog.pool.ntp.org
      - 1.datadog.pool.ntp.org
      - 2.datadog.pool.ntp.org
      - 3.datadog.pool.ntp.org

Unless you're using hetzner provider, I just override values in /etc/systemd/timesyncd.conf
from:
NTP=ntp.hetzner.com

to:
NTP=0.datadog.pool.ntp.org 1.datadog.pool.ntp.org 2.datadog.pool.ntp.org 3.datadog.pool.ntp.org ntp.hetzner.com


portico: Prevent Firefox from bfcaching the page.

Firefox stores the last state of the page in its back/forward cache
in memory and uses that for quickly rendering the page. Since our page's
last state was 'faded-out', the content wasn't visible when the browser
rendered the page from it's bfcache.
Fixes #7907.
Deployed a version with some console.logs at https://nightly.zulipdev.org/hello/

Nice, merged, thanks @aero31aero!


Generator produces incorrect reference to serviceconfig when measurement name includes a space

Bug Report
I created a new Measurement Plugin using the generator that included a space like "First Measurement" and was unable to run the resulting measurement successfully without modification.
Repro or Code Sample

Generate a measurement using a space
Attempt to run the resulting measurement.py without modification
You will get an error complaining about a service configuration that doesn't exist

Expected Behavior
Generated measurements should run out-of-the-box without modification and without error.
Current Behavior
The generator in almost every instance kept the display name of the measurement plugin "First Measurement" and removed whitespaces for all instances of files and folders "FirstMeasurement". This was as expected. However the measurement.py file included a bad link to a service config that doesn't exist. This causes a run-time error early when launching the measurement.
See screenshot for the problem:

Possible Solution
Fix the mako code such that the service config path uses the white-space-free version of the measurement name provided to the ni-measurementlink-generator.
Context

I was trying to record a demo with a nice display name inclusive of a space and I wasn't able to run it without modification which ran contrary to the ease-of-getting-started message I was trying to deliver.
Your Environment

OS & Device: Windows on VM
ni-measurementlink-service version 1.0.0
ni-measurementlink-generator version 1.0.0
MeasurementLink version 2023 Q1 final release
Python version 3.8

AB#2330904

When fixing this, let's:

Change test_measurement_generator.py to use whitespace in the service name.
Rename the example render files to match the generated filenames.


Search Facility in Dictionary

Add a search bar in the dictionary window to search for words present in the dictionary.

Please refer to the commit number 97096333bd59c4a03d999ddd9cb5cf5a303aff06, dd8a3d9ae240c3212811380f3f09253a40f8a79d and<PHONE_NUMBER>cff7422e6e2421b3e5227bde121a8c.


An Issue on updating modified time of a drive item

Category

[ ] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
I used this API to update lastModifiedDateTime of a drive item. I expect both lastModifiedDateTime in DriveItem resource and FileSystemInfo facet will be updated.
Observed Behavior
The API works well for accounts in a tenant (Ex: tom@cosmos.onmicrosofot.com).
However, when it comes to individual account (Ex: tom@outlook.com),  lastModifiedDateTime in DriveItem resource is not updated.
Steps to Reproduce
curl -v -X PATCH 'https://graph.microsoft.com/v1.0/me/drive/items/5A62BAAC76843344!148' --header 'Content-Type: application/json' --header 'Authorization: Bearer <access_token>' --data-raw '{
"fileSystemInfo": {
"lastModifiedDateTime": "2010-06-23T02:57:20Z"
}
}'

< HTTP/1.1 200 OK
< Cache-Control: private
< Transfer-Encoding: chunked
< Content-Type: application/json;odata.metadata=minimal;odata.streaming=true;IEEE754Compatible=false;charset=utf-8
< Strict-Transport-Security: max-age=31536000
< request-id: 1bf47c05-220e-4852-90f8-bd9cc0d0967b
< client-request-id: 1bf47c05-220e-4852-90f8-bd9cc0d0967b
< x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"Korea Central","Slice":"E","Ring":"3","ScaleUnit":"002","RoleInstance":"SE1PEPF00002FDD"}}
< OData-Version: 4.0
< Date: Fri, 24 Jun 2022 06:55:21 GMT
<
{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v1.0/$metadata#users('cat1pioneer%40outlook.com')/drive/items/$entity",
<EMAIL_ADDRESS>"https://xar2ig.sn.files.1drv.com/y4prjfGoXiZlta1zMgF5C4E2_Pn6APm14uHy9y9f2kcGWcqNgVvwykk04VxkC6dUGjNd3-S_llaVIGMv_Jcl_rQAdSOAMiLEJhYmvL_uuZObswxVe5z6mwhJaynxbVkZjic36ucdqI28RcCqXt4JtZee-gwEjc_WhzkHkjckwcjcc3-stF3PKlk-XaHgvSLbKlvWUaK-3DTb1BojOpa1FcCT8wTC0VWRCbJ-O74XPuPPhHQcwkQ2eEyiW7u1i5ZqHw_OLrVmNrvG9lw8Lzhy--_o6gKcueaWZnvPAURRdF-X9ogbJL-0qndvQfLcbmRfXOX",
  "createdDateTime": "2022-06-23T03:12:22.393Z",
  "cTag": "aYzo1QTYyQkFBQzc2ODQzMzQ0ITE0OC4yNTg",
  "eTag": "aNUE2MkJBQUM3Njg0MzM0NCExNDguMTA",
  "id": "5A62BAAC76843344!148",
  "lastModifiedDateTime": "2022-06-24T06:55:21.477Z",
  "name": "v1.txt",
  "size": 6,
  "webUrl": "https://1drv.ms/t/s!AEQzhHasumJagRQ",
  "reactions": {
    "commentCount": 0
  },
  "createdBy": {
    "application": {
      "displayName": "OneDrive",
      "id": "481710a4"
    },
    "user": {
      "displayName": "cat 1",
      "id": "5a62baac76843344"
    }
  },
  "lastModifiedBy": {
    "application": {
      "displayName": "Graph Explorer",
      "id": "4c1ad1* Connection #0 to host graph.microsoft.com left intact 00"
    },
    "user": {
      "displayName": "cat 1",
      "id": "5a62baac76843344"
    }
  },
  "parentReference": {
    "driveId": "5a62baac76843344",
    "driveType": "personal",
    "id": "5A62BAAC76843344!101",
    "path": "/drive/root:"
  },
  "file": {
    "mimeType": "text/plain",
    "hashes": {
      "quickXorHash": "MZDBDGhQAxsAAAAABgAAAAAAAAA=",
      "sha1Hash": "7C4A8D09CA3762AF61E59520943DC26494F8941B",
      "sha256Hash": "8D969EEF6ECAD3C29A3A629280E686CF0C3F5D5A86AFF3CA12020C923ADC6C92"
    }
  },
  "fileSystemInfo": {
    "createdDateTime": "2022-06-23T03:12:22.393Z",
    "lastModifiedDateTime": "2010-06-23T02:57:20Z"
  }
}

Thank you.
[ ]: http://aka.ms/onedrive-api-issues
[x]: http://aka.ms/onedrive-api-issues

We're tracking this item internally

I think this is by design - in the consumer endpoint lastModifiedDateTime is the system modified timestamp while file.lastModifiedDateTime is the value provided by the client. In SharePoint they are the same value because of a system limitation, but in the consumer service there is no limitation and the values are as documented.

I think this is by design - in the consumer endpoint lastModifiedDateTime is the system modified timestamp while file.lastModifiedDateTime is the value provided by the client. In SharePoint they are the same value because of a system limitation, but in the consumer service there is no limitation and the values are as documented.

OK. Thanks for your reply.

Closing this issue as answered. If you have additional questions or we did not answer your question, please open a new issue, ref this issue, and provide any additional details available. Thank you!


luci-mod-admin-full: new hostapd functionality for 80211w/r detection

@jow-
Could you please check this one out:
Use the new hostapd functionality (in LEDE) to detect 802.11r and 802.11w more properly. Leave the old logic in place for Openwrt.

I wonder if it would be more efficient performance-wise to use just one variable and just "or" the two os.execute statements (to avoid two os.executes in case the first one already provides a positive answer)

This goes outside the core scope of the PR but is related:
Regarding 80211w:
There have been a few forum discussions from persons who have got ieee80211w=0 option in their hostapd config, and it prevents radio from getting up if there is no 80211w support.

Hostapd startup uci script places also the unnecessary ieee80211w=0 value to the final hostapd config file, although that value value means that ieee80211w is disabled. That should be changed in the main LEDE source:
https://github.com/lede-project/source/blob/cb801b052cc38db807ecc6e10b9c06cb0d45491f/package/network/services/hostapd/files/hostapd.sh#L406
https://github.com/lede-project/source/blob/cb801b052cc38db807ecc6e10b9c06cb0d45491f/package/network/services/hostapd/files/hostapd.sh#L693
(note that 80211r is handled properly: 0 is ignored by using "gt": https://github.com/lede-project/source/blob/cb801b052cc38db807ecc6e10b9c06cb0d45491f/package/network/services/hostapd/files/hostapd.sh#L364)

Scenario how they got the uci config option might be: try a private/community build with full wpad, edit wireless options, get the 80211w=0 option to wireless config, sysupgrade to release build or private build with wpad-mini, and the option stays there causing trouble.

Regarding 80211w values, is there a good way to delete '0' values from a ListValue option type? Currently the "option ieee80211w 0" line appears to the /etc/config/wireless if any encryption options are edited when 80211w support is present, although there is no need for that line. As far as I have been able to determine, it is because the allowed values are 0,1,2 and default is 0 but not "", so .rmempty does not work.
I have thought that I might try changing the line ieee80211w:value("0", translate("Disabled (default)")) to have value("" , so that the default would be empty, but would that work?
Any other solutions?

value("", ...) should work as expected.

Thanks for input, @jow-
Your proposals work ok, as usual ;-)

@jow-
I will backport this also to 17.01 branch, mainly to fix the 80211w=0 handling, but also to wait for your backport of the hostapd detection fix ( https://github.com/lede-project/source/commit/aff2d5c856f34f46442f83974d4969c33ab1c563 ).   Please backport that.


bug(MatCheckbox): disableRipple not working

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14
Description
Currently the disableRipple directive does nothing.
Reproduction
Steps to reproduce:

use Angular Material 15
use disableRipple on mat-checkbox

Here is an Stackblitz example
https://stackblitz.com/edit/angular-xvd8ju?file=src/app/checkbox-configurable-example.html
or repo
https://github.com/EMokro/angular-material-15-checkbox-no-ripple
Expected Behavior
It should disable the mat ripple effect.
Actual Behavior
It does nothing
Environment

Angular: 15.0.0
CDK/Material: 15.0.3
Browser(s): Brave v1.46.144 / Chromium 108.0.5359.128
Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu

This is working as expected. disableRipple only removes the ripples on clicks, not the ripple that is used for focus indication. We generally don't provide APIs to disable accessibility features like focus indication. You can hide it at your own risk with .mdc-checkbox__ripple { display: none; }.


exported video is not imessage ready

hello, after recording like 20 seconds of animoji fun, tap the share screen and pick message. the resulting video won't be working on ios or macos (play button crossed on mac or just unknown file icon on ios).

The videos produced are HEVC encoded, are you trying to watch them on iOS 10 or macOS Sierra?

i shared the video in a group with multiple people and i only got this issue once. maybe its a race condition?


feat(actuator):Adding Support for Spring Boot Actuator

What is the purpose of the change
Adding Support for Spring Boot Actuator and equivalent to the QoS functions
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ PTAL

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.59%. Comparing base (32336db) to head (4efd175).
Report is 141 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14596      +/-   ##
==========================================
- Coverage   38.22%   37.59%   -0.63%
==========================================
  Files        1799     1813      +14
  Lines       79761    80691     +930
  Branches    11887    11995     +108
==========================================
- Hits        30486    30334     -152
- Misses      44900    45970    +1070
- Partials     4375     4387      +12

Flag
Coverage Δ

37.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Broken links on landing page

The links to Tomcat.java, DeploymentEventSource.java, and QuarkusOperator.java on https://javaoperatorsdk.io yield 404s. I'll be happy to send a PR if you tell me where's the source of that page and where those links should point to. Thx!
// CC @metacosm

Hi @gunnarmorling, thanks for pointing this out and the offer to help.
I think this is related to moving the samples to different repos.
DeploymentEventSource is now here:
https://github.com/java-operator-sdk/samples/blob/main/tomcat/src/main/java/io/javaoperatorsdk/operator/sample/DeploymentEventSource.java
Haven't seen the other files, the quarkus operator might be in the quarkiverse project, @metacosm might know more about that.
Tomcat.java must have been renamed.
On this note, can we have a discussion on the repo names under the project? If we want a merge-from-private-fork workflow, the repo "samples" for example is not too informative. I have a teszes/samples fork, and I imagine others might just have a different samples repo in their profile. Can we rename it to java-operator-sdk-samples for example?
Another thing, I've seen that there is an archived tomcat operator project that I presume has been merged to the samples repo, but since we haven't so many repos as of now, it might make sense to have samples in their own repos like tomcat was. It could ease the workflow where if I want a new operator developed, I could just clone a sample repo and have the project structure set up instead of copying files around.

This has been addressed. If you still find an issue please re-open.


python packages fixes

@domenkozar  Fix a couple of packages.
I am wondering, did we accidentally have pytest and nose somewhere as propagatedBuildInputs before?

Yeah, propagated build inputs were too aggresive.


Thread safety issue in compiler init

Fairly sure there's a threading issue in the compiler initialisation, purely guessing, I'm tempted to say it's a synchronisation problem between typing and impl dictionaries.
This mutation of the thread safety test demonstrates:
import threading
import random
import numpy as np
from numba import jit, vectorize, guvectorize

threads=4

def run_jit( **options):
    def runner():
        @jit(**options)
        def foo(n, v): # this needs to be long and needlessly involved
            a = np.ones(n)
            b = a[:1]
            c = b[0]
            d = np.zeros(n+1)
            e = np.ones(d.shape)
            f = d + e
            g = 0
            for h in range(n):
                g = g + c + f[0]
                i = np.zeros((np.int(g), np.int(g)))
                j = np.kron(i, i)
                k = j[0]
                g += k[0]
            return g
        return foo(4, 10)
    return runner

def run_compile(fnlist):
    def chooser():
        for _ in range(10):
            fn = random.choice(fnlist)
            try:
                print("thread: %s has %s" % (threading.current_thread().name, fn))
                fn()
            except Exception as ex:
                print("thread: %s: TEST HAS FAILED" % threading.current_thread().name)
                print("thread: %s, exception %s" % (threading.current_thread().name, ex))
                raise
    ths = [threading.Thread(target=chooser, name='thread_%s' % i)
            for i in range(threads)]
    for th in ths:
        th.start()
    for th in ths:
        th.join()

def run_vectorize(**options):
    def runner():
        @vectorize(['(f8, f8)'], **options)
        def foo(a, b):
            q = a + b + np.cos(a) - np.cos(a) + np.sin(b) - np.cos(b) + np.sinh(a+b) - np.cosh(a-b)
            return q

        a = b = np.random.random(10).astype(np.float64)
        return foo(a, b)
    return runner

def run_guvectorize(**options):
    def runner():
        @guvectorize(['(f8, f8, f8[:])'], '(),()->()', **options)
        def foo(a, b, out):
            q = a + b + np.sin(a) - np.cos(a) + np.sin(b) - np.cos(b) + np.sinh(a+b) - np.cosh(a-b)
            out[0] = q.real

        a = b = np.random.random(10).astype(np.float64)
        return foo(a, b)
    return runner

def test_concurrent_mix_use():
    print("Threads = %s" % threads)
    run_compile([run_jit(nopython=True),
                 run_vectorize(nopython=True),
                 run_guvectorize(nopython=True)])

if __name__ == '__main__':
   test_concurrent_mix_use()

gives about 1/3 of the time:
$ python foo.py
Threads = 4
thread: thread_0 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_1 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_2 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_3 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_3: TEST HAS FAILED
thread: thread_3, exception Failed at nopython (nopython mode backend)
No definition for lowering <built-in method kron_impl of _dynfunc._Closure object at 0x7fec26a05e18>(array(float64, 2d, C), arra
y(float64, 2d, C)) -> array(float64, 2d, C)
File "foo.py", line 22
[1] During: lowering "$80.25 = call $80.22(i, i, func=$80.22, args=[Var(i, foo.py (21)), Var(i, foo.py (21))], kws=(), vararg=No
ne)" at foo.py (22)
Exception in thread thread_3:
Traceback (most recent call last):
  File "<path>/numba/errors.py", line 243, in new_error_cont
ext
    yield
  File "<path>/numba/lowering.py", line 216, in lower_block
    self.lower_inst(inst)
  File "<path>/numba/lowering.py", line 262, in lower_inst
    val = self.lower_assign(ty, inst)
  File "<path>/numba/lowering.py", line 407, in lower_assign
    return self.lower_expr(ty, value)
  File "<path>/numba/lowering.py", line 729, in lower_expr
    res = self.lower_call(resty, expr)
  File "<path>/numba/lowering.py", line 687, in lower_call
    impl = self.context.get_function(fnty, signature)
  File "<path>/numba/targets/base.py", line 507, in get_func
tion
    return self.get_function(fn, sig, _firstcall=False)
  File "<path>/numba/targets/base.py", line 509, in get_func
tion
    raise NotImplementedError("No definition for lowering %s%s" % (key, sig))
NotImplementedError: No definition for lowering <built-in method kron_impl of _dynfunc._Closure object at 0x7fec26a05e18>(array(
float64, 2d, C), array(float64, 2d, C)) -> array(float64, 2d, C)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<path>lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "<path>lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "foo.py", line 35, in chooser
    fn()
  File "foo.py", line 26, in runner
    return foo(4, 10)
  File "<path>/numba/dispatcher.py", line 307, in _compile_f
or_args
    return self.compile(tuple(argtypes))
  File "<path>/numba/dispatcher.py", line 579, in compile
    cres = self._compiler.compile(args, return_type)
  File "<path>/numba/dispatcher.py", line 80, in compile
    flags=flags, locals=self.locals)
  File "<path>/numba/compiler.py", line 740, in compile_extr
a
    return pipeline.compile_extra(func)
  File "<path>/numba/compiler.py", line 360, in compile_extr
a
    return self._compile_bytecode()
  File "<path>/numba/compiler.py", line 699, in _compile_byt
ecode
    return self._compile_core()
  File "<path>/numba/compiler.py", line 686, in _compile_cor
e
    res = pm.run(self.status)
  File "<path>/numba/compiler.py", line 246, in run
    raise patched_exception
  File "<path>/numba/compiler.py", line 238, in run
    stage()
  File "<path>/numba/compiler.py", line 621, in stage_nopyth
on_backend
    self._backend(lowerfn, objectmode=False)
  File "<path>/numba/compiler.py", line 576, in _backend
    lowered = lowerfn()
  File "<path>/numba/compiler.py", line 563, in backend_nopy
thon_mode
    self.flags)
  File "<path>/numba/compiler.py", line 858, in native_lower
ing_stage
    lower.lower()
  File "<path>/numba/lowering.py", line 135, in lower
    self.lower_normal_function(self.fndesc)
  File "<path>/numba/lowering.py", line 176, in lower_normal
_function
    entry_block_tail = self.lower_function_body()
  File "<path>/numba/lowering.py", line 201, in lower_functi
on_body
    self.lower_block(block)
  File "<path>/numba/lowering.py", line 216, in lower_block
    self.lower_inst(inst)
  File "<path>lib/python3.6/contextlib.py", line 99, in __exit__
    self.gen.throw(type, value, traceback)
  File "<path>/numba/errors.py", line 249, in new_error_cont
ext
    six.reraise(type(newerr), newerr, sys.exc_info()[2])
  File "<path>/numba/six.py", line 658, in reraise
    raise value.with_traceback(tb)
  File "<path>/numba/errors.py", line 243, in new_error_cont
ext
    yield
  File "<path>/numba/lowering.py", line 216, in lower_block
    self.lower_inst(inst)
  File "<path>/numba/lowering.py", line 262, in lower_inst
    val = self.lower_assign(ty, inst)
  File "<path>/numba/lowering.py", line 407, in lower_assign
    return self.lower_expr(ty, value)
  File "<path>/numba/lowering.py", line 729, in lower_expr
    res = self.lower_call(resty, expr)
  File "<path>/numba/lowering.py", line 687, in lower_call
    impl = self.context.get_function(fnty, signature)
  File "<path>/numba/targets/base.py", line 507, in get_func
tion
    return self.get_function(fn, sig, _firstcall=False)
  File "<path>/numba/targets/base.py", line 509, in get_func
tion
    raise NotImplementedError("No definition for lowering %s%s" % (key, sig))
numba.errors.LoweringError: Failed at nopython (nopython mode backend)
No definition for lowering <built-in method kron_impl of _dynfunc._Closure object at 0x7fec26a05e18>(array(float64, 2d, C), arra
y(float64, 2d, C)) -> array(float64, 2d, C)
File "foo.py", line 22
[1] During: lowering "$80.25 = call $80.22(i, i, func=$80.22, args=[Var(i, foo.py (21)), Var(i, foo.py (21))], kws=(), vararg=No
ne)" at foo.py (22)

thread: thread_2 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_0 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_1 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_2 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_2 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_0 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_1 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_2 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_0 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_2 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_0 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_1 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_1 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_2 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_0 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_1 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_2 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_2 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_0 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_1 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_0 has <function run_guvectorize.<locals>.runner at 0x7fec35db5488>
thread: thread_1 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_2 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_1 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_0 has <function run_vectorize.<locals>.runner at 0x7fec35db5400>
thread: thread_1 has <function run_jit.<locals>.runner at 0x7fec35db5378>
thread: thread_0 has <function run_jit.<locals>.runner at 0x7fec35db5378>

After all the locking changes since this was opened, I can no longer reproduce this using Numba master + Python 3.6.  Should we close, @sklam?

Never mind.  Literally 1 second after the last post, Stuart's reproducer failed twice in a row.  Still a problem.  :(

Guessing... This issue is likely down to initialisation sequences not being threadsafe with various dictionaries/registries that should be in updated atomically currently being written to at different times, this allowing one thread to incorrectly determine that a function is ready for use before another thread has actually installed it. The LLVM threadsafety work would not impact this but may make its occurrence less frequent.

Cannot reproduce this any more. I think it would have been fixed by https://github.com/numba/numba/pull/6948 which pushes the registry initialisation out of the Numba __init__ sequence!


[DO NOT MERGE] un-exclude subman from edge

This is a WIP PR to test an ostree build w/ subman
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

is there any way I can grab an artifact rpm to test it on a live rhel box?

If you check the schitzbot logs you'll find a repo with the rpm built from your pr.

If you check the schitzbot logs you'll find a repo with the rpm built from your pr.

thanks Tom! I'm afraid the bot just failed w/o producing any artifact (unless I'm completely blind)

I think we broke Schutzbot by the last merged PR. #1232 should fix it. When it's merged, this PR needs a rebase.

OK, #1232 is merged, please rebase your PR on top of main.

alrighty, this should be good to go now /cc @nullr0ute

Yep, LGTM, we can revisit this in the 8.5 cycle as part of engaging with the rhc team.

May I ask for a rebase? Schuzbot is somehow confused and I have no clue why.

May I ask for a rebase? Schuzbot is somehow confused and I have no clue why.

rebased

I think that this change pulled in dnf (at least the failed test shows it). Is this expected?
The test specifically tests that dnf shouldn't be in the image.

I think that this change pulled in dnf (at least the failed test shows it). Is this expected?

I need to drop that then as we're aware dnf is going to be pulled in for now

@ondrejbudai I've skipped that test on rhel 8.4 but running elsewhere - we'll revisit that going forward - now there are other jobs failing but they look unrelated afaict.

Affected by #1202 and #1237, otherwise green.


FS-2111: Update application overview table to display Country in locations column

https://digital.dclg.gov.uk/jira/browse/FS-2111
As part of FS-2111 we require the Country to be displayed on the Assessment FE

Being a bit nit-picky here but can you remove as json from the PR name, as we're not displaying them as json if I understand correctly.

Being a bit nit-picky here but can you remove as json from the PR name, as we're not displaying them as json if I understand correctly.

Totally agree - Done

Please can we add a test for the view for both the data being populated and not populated?


Cleanup of raw nullptr checks with Ref

With optional second commit fully forbidding these comparisons, used to identify these cases, I'd say this should be integrated as we don't really permit checking against nullptr and it'd be good to simply enforce it, though the error messages can be a bit cryptic at times so leaving it open

If there's no issues with deleting the operators for future proofing I'll go ahead and squash (I'll keep the operators in godot-cpp for backwards compatibility, as we don't have any DISABLE_DEPRECATED there, and I'll leave a note to not copy it over)

I'd agree with deleting the nullptr operators in principle, but this will break compatibility with C++ modules or forks and not just godot-cpp, and in a way that might irritate users, as they might not strive for the same consistency in their codebases.
So I think we need to keep them for compatibility. We can maybe keep them with #ifndef DISABLE_DEPRECATED, so we still have a way to remove them for updating the engine (and this should also be checked by CI, at least on the "Minimal template" build, so not covering the whole codebase).

I'll go ahead and split them off into a separate PR and look at perhaps adding a new define for stricter null-checks or something, as I think DISABLE_DEPRECATED might be too inappropriate for this, and we can work on a good general solution

Thanks!

Thank you!


More settings

Description
I added a new tab under settings that contains a lot more settings people can mess with. This may be kinda useless so I understand if this wont get merged.
Motivation and Context
Wanted to add more settings 😄
How has this been tested?
Works on my machine 👍
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I like the idea behind your PR and I appreciate the quality of it despite being your first one.
However, I think your solution would complicate things a lot. I think a better way to integrate something similar to what you propose, would be the most important options, the ones that really make a difference, move them to the advanced settings section of the training, where the rest of the settings are, and make that instead of being modified from the config.json, they are sent as a parameter like the number of total epochs, batch size....
Only those parameters that really make a difference.


[2009-03-09] Avoid ?url= GET parameter redirection if not on sapphire.php script

created by: @chillu (ischommer)
assigned to: @kmayo-ss (kmayo)
created at: 2009-03-09
original ticket: http://open.silverstripe.org/ticket/3684

This is an interesting one, raised by one of our partners: you can redirect to different internal URLs by using the "url" GET parameter.
Example (works on standard installation): /about-us/?url=contact-us will show the "contact-us" page, not "about-us". This has several implications:

On a sufficiently long URL, this might be used to obfuscate the target page
It might be used to create attacks on the page-rank of a target page - Google will index these links and rate them as duplicate content, which decreases pagerank

I would suggest to limit parsing of the ?url parameter to scenarios where REQUEST_URI starts with /sapphire/main.php
@Sam: Thoughts? How does this get influenced by your work on URLs without mod-rewrite (index.php/about-us)?

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/3748

Fix is at 3.1 so moving milestone.


Go to function definition (Ctrl+Click) does not work in Javascript code (version 1.14)

VSCode Version: 1.14
OS Version: Windows 7

Steps to Reproduce:
In version 1.13 go to function definition (Ctrl+Click) worked.
In new version - it does not. F12 does not work too. I've checked on simple file (named test.js):
function testFunction(params) {
    alert("test");
}

testFunction();

To be sure I've removed old version and installed the new one - result was the same.

Reproduces without extensions: Yes

How did you open the file? Is it part of the workspace? If so, what does the rest of the workspace look like?
Can you also please open the output panel and check the TypeScript section for error messages.

I've opened single js file and see no errors - screenshot

I have the same problem, tested with .js and .jsx files.

I believe this is a duplicate of #30716
Please run the Toggle Developer tools command and look in the developer console to confirm this. This bug should already be fixed in insiders and we are preparing a 1.14.2 update that fixes this as well

Yes, I see the same error. Thank you!


Building Core fails in xcode: 'React/RCTBridge.h' file not found

When I try to build the Core project in xcode, I am getting the error "'React/RCTBridge.h' file not found".  I have tried adjusting the "Header Search Paths" and "User Header Search Paths" to point to various folders inside react-native/React, but nothing seems to work.  I suspect the problem may be related to the fact that the react native headers are referenced as system headers ("#import <React/RCTBridge.h>"), but I'm lost as to how I can fix this.  Any help or more detailed directions would be appreciated.

I'm running into the same issue here. Any place where to look for an answer?

@daniel-bytes which version of react native are you running on?

@Eptis : 0.39.2 .   I more or less just gave up and started writing Objective-C against the AWS iOS SDK and binding to that directly.  Not ideal.

@daniel-bytes I'm on 0.40.0 where they moved the headers into a namespace.  I'm currently trying to compile the Core project and added the React project as a dependency:

This does help with finding all the headers, but I now run into a problem with the Core library not compiling properly:

Do you have any suggestions to resolve this?

@Eptis I will try updating soon and see if I can figure it out.  As of now I don't really have any recommendations, sorry.

Ok I got it to compile, commented out the "exception" lines which are most likely for an older version of the iOS sdk or something.


A problem with CDN

Just started using CloudFlare CDN on isso and found a problem that the IP of the user sent to my email is the one of CloudFlare's. @posativ

Working as intended?

@posativ Yep still working it seems that the solution can vary depending on which CDN u r using, the solution of CloudFlare: https://support.cloudflare.com/hc/en-us/articles/200170706-How-do-I-restore-original-visitor-IP-with-Nginx-
Then to solve the problem the file about the mail should insert those codes and replace the original variable about IP with that variable. Will gonna try when I'm free.
By The Way should I stop isso before editing? Last time after some edit to some files, isso ceased working.

Last time after some edit to some files, isso ceased working.

Yeah, whatever.

Seems those module should be in the configuration file of the isso domain and then the variable of the ip should be replaced with that. Is that correct? @posativ

Done!


Update links to specifications to main branch

In a recent change to the events conventions, discussions were had to update a link from pointing to a specific version/branch of the semantic conventions repository to point to the main branch instead. In discussion on the client-side SIG, we agreed that the link should point to the main branch. While that PR was updated, this repository has many other links that follow suite and need to be updated to point to main instead of a specific version.
Relavent Discussions:
https://github.com/open-telemetry/semantic-conventions/pull/473#discussion_r1399462589
https://github.com/open-telemetry/semantic-conventions/pull/473#discussion_r1400831343

Links are in fact supposed to point to a specific version of the semantic conventions repository. There are a handful of links in the repo that do not meet that requirement.

Thanks, I sent a PR to fix the wrong links.


Update GitHub hints to support API based requests

This is required for GitHub enterprise editions that require authentication. I was unable to make this work using the direct github.com/username.json format, so this uses the github.com/api/v3/users/username format. The associated list is created using a slightly different JSON format as well. This should work happily alongside existing implementations with no impact (in theory).

Thanks!


[Proposal] Make MaterialColor consistent with Material 3

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
I'm new to Flutter and I'm trying to configure a custom color scheme while respecting Material 3 color conventions. According to the Material 3 documentation, a tonal palette consists of thirteen tones, including white and black. A tone value of 100 represents maximum lightness and results in white. Each tone value between 0 and 100 expresses the amount of light present in the color.
I'm attempting to use the MaterialColor class to implement my custom colors, but it seems to be following the Material 2 convention instead.
I have referred to the Material 3 documentation (https://m3.material.io/styles/color/the-color-system/key-colors-tones#6bdb9471-b70d-42c9-8ace-76743c1fff13) and noticed that the color system and conventions described there differ from what I'm experiencing with the MaterialColor class.
Here are some screenshots illustrating the differences:
Material 3 Color Conventions:

MaterialColor class:

Material 2 Color Conventions:
https://m2.material.io/design/color/the-color-system.html#color-usage-and-palettes

Proposal
Maybe an update to that class to support new Material 3 colors conventions?

Hi there! Thanks for filing this. Actually we have a new class specific to Material3 colors called ColorScheme - https://api.flutter.dev/flutter/material/ColorScheme-class.html. I'm adding an example to the MaterialColor API docs to make it clear that for Material 3 design you should use the ColorScheme class.


Feature/check api key

Requires more work with higher level API settings. Not to be finished in the sprint, but will be continued in connection of improving API Umbrella integration / decoupling. Closing the PR, but leaving the branch.


(1.18.2) Showing missing textures

Texture Pack Used: Xail's Enchanted Books
Log (includes mods list): https://mclo.gs/p5g0VJU

Thanks for the report. Was able to reproduce the issue - will look into fixing this in the next week or two.


MudToolTip wouldn't disappear after clicked in android browsers or app

Bug type
Component
Component name
MudToolTip
What happened?
When you clicking the element inside MudToolTip and try to open an element over (for example : MudOverlay), The tooltip doesn't disappear in android browsers.
Expected behavior
Tooltip should disappear after clicked.
Reproduction link
https://try.mudblazor.com/snippet/mumGEWFbUljkIpdl
Reproduction steps

Create a MudToolTip
Put a button in it and open a MudOverlay
The tooptip still visible

Relevant log output
No response
Version (bug)
6.0.14
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Android
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Bugged a while ago 4564

Bugged a while ago 4564

This bug only exists in touch environment.


Add metalmatze as release shepard for v0.11

I'm happy  to shepard the v0.11.x release this month.
For the next v0.12 release I simply added 6 weeks to the current date - which is April 1st.
/cc @thanos-io/thanos-maintainers

DCO please (:


Current build isn't working on chrome

On chrome the vis seems to be build correctly in the html but there is no display, does not affect firefox.

This also affect safari.


Only generate images that will be used

Would it be possible to determine which sized images will be used for a given image and only generate those?
Love using this btw, its a huge advantage to  my workflow thank you!

Hi @Lastofthefirst
Unfortunately currently not. The front end image component and the image optimisation at export time are quite independent. To make it work you would have to keep a list of the used sizes somewhere or dynamically go through the whole project and extract the used sizes for each image.

Alright. Thanks.


Making max-width responsive

Due to the sm:w-full in the modal's body from tailwind ui, you need a way to control the max-width or it will flicker out at smaller breakpoints if your size is too large.
Size is being set here as only one class, but since it's css there is an easy win that doesn't require a huge programmatic change.
https://github.com/livewire-ui/modal/blob/112b521bbd9eef4c188b9eaa0b274dbe424b6578/resources/js/modal.js#L37
This can be modified to instead of just pushing in that one value, I'd use a look up table and pull it from there: here is a working one I tested.
public static array $sizes = [
        'sm' => 'sm:max-w-sm',
        'md' => 'sm:max-w-md',
        'lg' => 'sm:max-w-md md:max-w-lg',
        'xl' => 'sm:max-w-md md:max-w-xl',
        '2xl' => 'sm:max-w-md md:max-w-xl lg:max-w-2xl',
        '3xl' => 'sm:max-w-md md:max-w-xl lg:max-w-3xl',
        '4xl' => 'sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-4xl',
        '5xl' => 'sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-5xl',
        '6xl' => 'sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-5xl 2xl:max-w-6xl',
        '7xl' => 'sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-5xl 2xl:max-w-7xl',
    ];

I used it in my own modal system, I was thinking of pulling in this one to solve my child model issue but there are two outstanding tickets that i need solved first. Luckily they both have simple fixes :)
Hope this helps! I'm excited to start using this!

This and the current implementation really ties it to Tailwind. I love Tailwind and use it in majority of my projects, but it seems like this shouldn't be so tightly integrated when it doesn't have to be. It is one thing for the default to be Tailwind specific, but it should be able to be used with other CSS frameworks.
The solution seems to be that instead of setting just a size 'sm', 'md', 'lg', etc., that a CSS class just be set. So you could just pass in 'sm:max-w-sm' or 'sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-5xl 2xl:max-w-7xl' and have that class variable merged just like it is now into the template. This would allow this package to be used with other CSS frameworks as the developer would just need to publish the template and change the classes, but then set the size via a style related to that framework.

Grant, you bring up a valid point, but this issue is narrowly focused on responsive widths. This entire package is packed with tailwind and will completely implode without it. Unless there was an alternative.
What you are suggesting a complete rebuild. To some arbitrary css maybe bootstrap but perhaps with publishable assets. And perhaps a command to choose between some presets. Which sounds great. But it seems like that should be a different issue.

Most of the Tailwind code could be more generalized without any rebuild. The most difficult solution would be changing these lines:
https://github.com/livewire-ui/modal/blob/main/resources/js/modal.js#L69
https://github.com/livewire-ui/modal/blob/main/resources/js/modal.js#L71
The rest of Tailwind code is in the blade file that is publishable, so easily changable by anybody and then these
https://github.com/livewire-ui/modal/blob/main/resources/js/modal.js#L30
https://github.com/livewire-ui/modal/blob/main/resources/js/modal.js#L37
Both of those could be switched to a general "maxWidthClass" or something. Why I added it to this thread, is since it was related to changing the max width anyways. But all of this would be up to @PhiloNL anyways. Just an idea to make it easier to use without having to fork the entire project to use it with another CSS framework.

Ahh I see your point, yes that CSS is simply the fix for the visual issue with the CSS in its current state, but if everything is publishable and configurable, it makes sense that this should be as well. Thats a valid point. It really doesn't matter where it's stored as long as there is a way to set a key and wha is put there as a result of the key.
The reason the it's even needed is when the internal items in the modal naturally push the drawing outside of the width of the screen and not the max-width of the modal.
I only exposed the bug because I had a design that required a table in a specific modal and was surprised when people with specific devices mentioned no modal showed up. but the screen overlay, the bg-gray-500 bg-opacity-75 did.
So this solution proposed is simply to deal with that specific issue that has cropped up for a few people using the tailwind modal as is when we are parameterizing the size.

Thanks @roni-estein I will take a look at this, somewhere this week 😄  It's taking a bit more time than usual.
@gcw07 @roni-estein I will take a look at generating a scoped Tailwind CSS file that can be used when working with other CSS frameworks. Thanks for the feedback.

Just had a few seconds between tasks, and I really to delegate my modals to this package, here is a quick illustration of the breakpoint issue. With the default install of livewire and tailwind 2.1+.
Component
<?php

namespace App\Http\Livewire\Modals;

use App\Models\Review;
use LivewireUI\Modal\ModalComponent;

class DeleteReview extends ModalComponent
{
    public ?Review $review;

    public function mount(Review $review)
    {
        $this->review = $review;
    }

    public function delete()
    {
        $this->review->delete();

        $this->forceClose()->closeModal();
    }

    public function cancel()
    {
        $this->closeModal();
    }

    public function render()
    {
        return view('livewire.modals.delete-review');
    }
}

Blade View (literally cut and pasted from tailwindu, I didn't set up events on the buttons yet but just to show the maxwidth issue)

        <svg class="h-6 w-6 text-red-600" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24"
             stroke="currentColor" aria-hidden="true">
          <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
                d="M12 9v2m0 4h.01m-6.938 4h13.856c1.54 0 2.502-1.667 1.732-3L13.732 4c-.77-1.333-2.694-1.333-3.464 0L3.34 16c-.77 1.333.192 3 1.732 3z"/>
        </svg>

          Deactivate account

            Are you sure you want to deactivate your account? All of your data will be permanently removed. This action
            cannot be undone.

    <button type="button"
            class="w-full inline-flex justify-center rounded-md border border-transparent shadow-sm px-4 py-2 bg-red-600 text-base font-medium text-white hover:bg-red-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-red-500 sm:ml-3 sm:w-auto sm:text-sm">
      Deactivate
    </button>
    <button type="button"
            class="mt-3 w-full inline-flex justify-center rounded-md border border-gray-300 shadow-sm px-4 py-2 bg-white text-base font-medium text-gray-700 hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm">
      Cancel
    </button>

This is it in action.
https://user-images.githubusercontent.com/8517475/117342752-30e44f00-ae69-11eb-8e61-cf5234a1e381.mov


Maintain data in deps.edn

We could consider maintaining some data in e.g. the deps.edn:
{:org.babashka/neil {:lib foo.bar}} or {:aliases {:org.babashka/neil {:lib foo.bar}}}.
And you could add this with neil set :lib foo.bar or so. And then neil add test would generate the first test for you based on the :lib name.
We could do this (add the lib name to deps.edn) while you're doing neil new even.

Data is maintained under :aliases {:neil {:project ...}}}


[EM] Refactor GPU histogram builder.

Expose the maximum number of cached nodes to be consistent with the CPU implementation. Also easier for testing.
Extract the subtraction trick for easier testing.
Split up the GradientQuantiser to avoid circular dependency.

todos:

[x] perf check
[x] document

cc @rongou .


Cut down test times

Refactor so that leak detection is happening in TestMain; Use t.Parallel() everywhere;
Reduce series/samples count in some tests that reuse the same functions we use for benchmarking i.e. leave higher loads for benchmarks

@GiedriusS I see that you migrated unit tests to github. Can we make the CircleCI status not required for PRs?

Yeah, will do that. I got fed up with CircleCI and that's why I moved our tests to there.


Added more information to use this library

To use this library one had to think around.
The new section on the README.md now describes
the setup process to use this library.
To improve the creation speed even more I
created the templates folder. All files
within this folder should be copied into a
new project.

I noticed that after renaming the crate name (#23) you missed to update the README. Also I added a section to describe how to setup the library within a new project (because not everybody wants to add example files into the repository itself ;) )

Two questions:

What is the status of this PR? There have been proposals by @jrvanwhy but no reaction to them.
What is the benefit of using the templates? In contrast to the example files, the template files are untested and risk running out of sync quickly. In my opinion, it is harder to make a broken template running than figuring what files you need by looking at the examples. A trade-off could be to place all example glue files to a dedicated location where they act as a template at the same time. Or you provide a mechanism to generate the example files out of the templates.

Does anyone want to pick this up? I think it needs to be updated, and there have been no responses to review comments.
If no-one is interested in working on this then lets close it.


[Drawer] The MenuIcon component has a selected background if the drawer component is opened and closed

I am using the Drawer component in the nav bar with the MenuIcon. In earlier releases, this worked as expected. When the MenuIcon was clicked, the Drawer would open, and clicking on any of the Drawer items, or outside the Drawer would close the Drawer. However, with the latest release, I notice that once the Drawer opens, if I click anywhere to close the drawer, the MenuIcon component gets highlighted. I have to click once again on the page to get it back to normal.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce (for bugs)

Live preview of my code is at here
Even though it is not appearing on the live demo, I see it on my machine.
Screenshots are present here
Your Environment

Tech
Version

Material-UI
1.0.0-beta.10

React
15.6.1

browser
Tested both on Chrome and Firefox

OS
Windows 2008 Server R2

Even though it is not appearing on the live demo, I see it on my machine.

This sentence contains an ambiguity. I will assume that you mean "project" instead of "machine". For accessibility considerations, the IconMenu is focused back when the drawer close. You most likely have some global CSS overrides messing with Material-UI styles.

Let us know if you find what's going on :).

You were right, it was another CSS that was overriding. Sorry for bothering.


Implement the ProjectRoleTemplate controller

What this PR does / why we need it:
This PR implements the ProjectRoleTempalte controller to manage role/rolebindings for project-specific permissions.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #21
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

/lgtm


[Device Support Request] loratap Zigbee Curtain/Light Switch TS0601 by _TZE204_pxbjch8m

Problem description
Hey Guys
is someone able to help with this device?
https://vi.aliexpress.com/item/1005005590013359.html?spm=a2g0o.order_list.order_list_main.39.24391802oXGwsJ&gatewayAdapt=glo2vnm
Added into ZHA no issues but with no entities, reports the device as TS0601
by _TZE204_pxbjch8m.
Must be a new tuya chip im guessing that doesn't follow the usual standards.
Solution description
added support for even just the light and or shutter cover.
Screenshots/Video
Screenshots/Video
[Paste/upload your media here]

Device signature
Device signature
[Paste the device signature here]

Diagnostic information
Diagnostic information
[Paste the diagnostic information here]

Logs
Logs
[Paste the logs here]

Custom quirk
Custom quirk
[Paste your custom quirk here]

Additional information
No response

The issue template is there for a reason.
Attach as much information as possible to help maintainers to help you.

Sorry I'm new to this, will try and fill it out as much as I can

Same here.
any thing new ?


Include MNE-ICALabel (and PyTorch) in the Windows installers

If we merge this, please don't squash the history – I separated the commits so it'll be easier to compile the changelog.

Dependency resolution seems to work; however, installer creation on Windows fails for unknown reasons :(

@larsoner Have we seen such an issue before? I'm not sure

No, I'm guessing it's unrelated to this PR (and probably due to conda installer updates) but it's worth checking

Okay on mamba 1.1.0 / 87f96bf the failure is:
fetching: mne-nirs-0.5.0-pyhd8ed1ab_0.conda
fetching: pyprep-0.4.2-pyhd8ed1ab_0.tar.bz2
Checking for duplicate files ...
Warning: File 'Library/bin/libiomp5md.dll' found in multiple packages: intel-openmp-2023.0.0-h57928b3_25922.conda, openmp-5.0.0-vc14_1.tar.bz2
Warning: File 'Library/README.txt' found in multiple packages: libhwloc-2.8.0-h039e092_1.tar.bz2, gl2ps-1.4.2-h0597ee9_0.tar.bz2
Warning: File 'site-packages/tests/__init__.py' found in multiple packages: pycircstat-0.0.2-pyh8a188c0_0.tar.bz2, neurokit2-0.2.3-pyha21a80b_0.conda
Checking for 'C:\Users\runneradmin\micromamba-root\envs\constructor-env\NSIS\makensis.exe'
NSIS version: v3.01
Reading: C:\Users\runneradmin\micromamba-root\envs\constructor-env\lib\site-packages\constructor\nsis\main.nsi.tmpl
Created C:\Users\RUNNER~1\AppData\Local\Temp\tmpt3ds4579\main.nsi file
Calling: ['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpt3ds4579\\main.nsi']
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpt3ds4579\\main.nsi']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

Going to try reverting our NSIS hotfix to see if that helps...

@larsoner Failing :(
Checking for 'C:\Users\runneradmin\micromamba-root\envs\constructor-env\NSIS\makensis.exe'
[588](https://github.com/mne-tools/mne-installers/actions/runs/4167033792/jobs/7212114930#step:9:589)
NSIS version: v3.08
[589](https://github.com/mne-tools/mne-installers/actions/runs/4167033792/jobs/7212114930#step:9:590)
Reading: C:\Users\runneradmin\micromamba-root\envs\constructor-env\lib\site-packages\constructor\nsis\main.nsi.tmpl
[590](https://github.com/mne-tools/mne-installers/actions/runs/4167033792/jobs/7212114930#step:9:591)
Created C:\Users\RUNNER~1\AppData\Local\Temp\tmpwq_ql9_b\main.nsi file
[591](https://github.com/mne-tools/mne-installers/actions/runs/4167033792/jobs/7212114930#step:9:592)
Calling: ['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpwq_ql9_b\\main.nsi']
[592](https://github.com/mne-tools/mne-installers/actions/runs/4167033792/jobs/7212114930#step:9:593)
Error: Process completed with exit code 1.

@jaimergp our nsis=3.01 hotfix you kindly suggested worked for a while but stopped working on Windows in the last ~2 months:
https://github.com/mne-tools/mne-installers/actions/runs/4166630449/jobs/7211209939
...
fetching: pyprep-0.4.2-pyhd8ed1ab_0.tar.bz2
Checking for duplicate files ...
Warning: File 'Library/bin/libiomp5md.dll' found in multiple packages: intel-openmp-2023.0.0-h57928b3_25922.conda, openmp-5.0.0-vc14_1.tar.bz2
Warning: File 'Library/README.txt' found in multiple packages: libhwloc-2.8.0-h039e092_1.tar.bz2, gl2ps-1.4.2-h0597ee9_0.tar.bz2
Warning: File 'site-packages/tests/__init__.py' found in multiple packages: pycircstat-0.0.2-pyh8a188c0_0.tar.bz2, neurokit2-0.2.3-pyha21a80b_0.conda
Checking for 'C:\Users\runneradmin\micromamba-root\envs\constructor-env\NSIS\makensis.exe'
NSIS version: v3.01
Reading: C:\Users\runneradmin\micromamba-root\envs\constructor-env\lib\site-packages\constructor\nsis\main.nsi.tmpl
Created C:\Users\RUNNER~1\AppData\Local\Temp\tmpt3ds4579\main.nsi file
Calling: ['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpt3ds4579\\main.nsi']
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpt3ds4579\\main.nsi']' returned non-zero exit status 1.

And switching to napari/bundle_tools_2 and removing the pins does not help:
https://github.com/mne-tools/mne-installers/actions/runs/4169356013/jobs/7217229034
...
fetching: pyprep-0.4.2-pyhd8ed1ab_0.tar.bz2
Checking for duplicate files ...
Warning: File 'Library/bin/libiomp5md.dll' found in multiple packages: openmp-5.0.0-vc14_1.tar.bz2, intel-openmp-2023.0.0-h[579](https://github.com/mne-tools/mne-installers/actions/runs/4169356013/jobs/7217229034#step:8:580)28b3_25922.conda
Warning: File 'Library/README.txt' found in multiple packages: gl2ps-1.4.2-h0597ee9_0.tar.bz2, libhwloc-2.8.0-h039e092_1.tar.bz2
Warning: File 'site-packages/tests/__init__.py' found in multiple packages: neurokit2-0.2.3-pyha21a80b_0.conda, pycircstat-0.0.2-pyh8a188c0_0.tar.bz2
Checking for 'C:\Users\runneradmin\micromamba-root\envs\constructor-env\NSIS\makensis.exe'
NSIS version: v3.08
Reading: C:\Users\runneradmin\micromamba-root\envs\constructor-env\lib\site-packages\constructor\nsis\main.nsi.tmpl
Created C:\Users\RUNNER~1\AppData\Local\Temp\tmpqzoz9q5k\main.nsi file
Calling: ['C:\\Users\\runneradmin\\micromamba-root\\envs\\constructor-env\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpqzoz9q5k\\main.nsi']
Error: Process completed with exit code 1.

Any ideas here?

Maybe try running constructor -v for higher verbosity. I updated the builds on bundle_tools_2 yesterday and it is now up to date with 3.4.3.

TL;DR: Thanks to your help @jaimergp, it looks like the problem is that something new we add here (PyTorch) makes the installers too big (>2GB I guess?) which is problematic.
Verbose mode was informative in e07c9d3 / CI:
File: "pytorch-1.12.1-py3.10_cuda11.6_cudnn8_0.tar.bz2"

Note: you may have one or two (large) stale temporary file(s) left in your temporary directory (Generally this only happens on Windows 9x).
makensis stderr:
Internal compiler error #12345: error mmapping file<PHONE_NUMBER>, 33554432) is out of range.
Successfully created 'D:\a\mne-installers\mne-installers\MNE-Python-1.3.0_1-Windows.exe'.

Although it says it successfully created the file (?), it appears not to have done so as our simple filename glob fails:
Finding matches
Extracting fname
Found name:
Want name:  MNE-Python-1.3.0_1-Windows.exe
Error: Process completed with exit code 1.

After a bit of googling it sounded like we might be hitting a 2GB limitation of NSIS. I suspected PyTorch adds a lot of code, so I removed mne_iclabel / pytorch (which was the point of this PR!) in c9836b0 / CI, and this build successfully created the .exe -- seemingly confirming the NSIS 2GB limitation issue :(

OUCH
@larsoner Let's try without Spyder, WDYT?

My idea was that maybe we could create two separate installers, one with more basic functionality and including Spyder, and one for more advanced users

I think I'd rather just give the advanced users the instructions for how to get PyTorch installed on Windows

There is a project that removes the 2 GB limitation, but I have no clue how we could make use if it in constructor
https://sourceforge.net/projects/nsisbi/
@jaimergp WDYT?

Great find! I'll open an issue on conda/constructor.


[WIP] Add package hyperv-daemons for vhd appliance

This is to resolve BZ 1322611
@simaishi can you please review.

LGTM


Could envoy support  specific  work pthread  auto bind cpu, if  i start --concurrency 1

be similar to NGINX  worker_processes 1;  worker_cpu_affinity auto;

Can you please elaborate on this by explaining what Nginx does or linking to the exact part of the documentation? Thanks.

I mean that each work thread  can bind each cpu core, in case of multi work thread  compete  for the same cpu core

I think you are asking for CPU pinning via thread affinity. There was some discussion of this in https://github.com/envoyproxy/envoy/issues/4602. Do you have reason to suspect that there is a real issue here?
I think this might also come up in a performance measurement context, CC @oschaaf.

I think you are asking for CPU pinning via thread affinity. There was some discussion of this in #4602. Do you have reason to suspect that there is a real issue here?
I think this might also come up in a performance measurement context, CC @oschaaf.

#4602 should be kernel tcp reuseport, solve thundering herd and request load-balance
But my focus is that two or more thread maybe send interrupt signal in a moment, cause that cpu utilization rate reduce; If suport CPU pinning via thread affinity such configure, maybe avoid this case.
Thank you!

@htuch https://github.com/envoyproxy/envoy/issues/13602   help me  solve this question , thank you!

@htuch "Configurable ciphers: Each TLS listener and client can specify the ciphers that it supports."   how to configure ciphers, and  here isn't   configure demo in https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/ssl


Images don't appear for http URL

An image that appears in a browser based mattermost client doesn't appear in the client (reproductible on Mac, Linux & Window)

How did you show the image in browser? Screenshot is better.

You're perfectly right. It seems that the problem is not systematic. Here is an example :

But it is true that the feature works perfectly for many images. I have not understood the difference between images that are correctly shown and images that doesn't appear.

(I forgot to tell you that in the previous example, the image is correctly displayed in the browser)

I could get the image v1.0.5 with Mattermost 1.4.

Could you show the correct case in the app? In my guess, it depends on its url.

This URL works fine : https://images.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png

Is your Mattermost served by https? If so, only https url image will be shown.
Electron has following options to control its security:

webSecurity Boolean - When setting false, it will disable the same-origin policy (Usually using testing websites by people), and set allowDisplayingInsecureContent and allowRunningInsecureContent to true if these two options are not set by user. Default is true.
allowDisplayingInsecureContent Boolean - Allow an https page to display content like images from http URLs. Default is false.
allowRunningInsecureContent Boolean - Allow a https page to run JavaScript, CSS or plugins from http URLs. Default is false.

However, webview has just only disablewebsecurity option. I did not add it because allowRunningInsecureContent should be false.

Yes it is served by HTTPS. Is there a way to change these parameters ? If I understand, these parameters come from electron that you use. Once the app is built, can these parameters still be changed ?

I think the package contains browser/index.js. Please try adding "disablewebsecurity" attribute to webview. However I think it's a little difficult because index.js is compiled from index.jsx and many modules.

i see the same when posting xkcd images (works in the browser)

Yeah this is an issue with HTTP/HTTPS. Confirmed here.

Because of security, I won't add disablewebsecurity attr. If you want, please add it and rebuild the app.

So what's the solution? It seems telling people to not use https because images won't display is a security issue as well. How does the browser handle the origin policy to make it work?

Isn't it possible to add a configuration parameter so that the end user can choose whether he prefers security or usability ?

Reopen this issue for reference.

Well, this is still unsolved ... any plans for addressing this?


Add a reduced test-case for issue 6113

As promised in PR #6125, here's a reduced test-case that should (hopefully) avoid the intermittent failure of the previous one.

/botio test

/botio makeref

/botio-windows makeref

/botio-windows makeref

/botio-windows makeref

@yurydelendik @brendandahl Any idea what's wrong with the Windows bot? I have never seen this error before. It seems like it could not download a resource tarball before and is now locking the other modules.

While we wait for the Windows bot to be fixed; let's check that this test-case doesn't cause any intermittent failures on Linux, as the previous one did.
/botio-linux test

/botio-windows makeref

/botio makeref

Nice work!


Expose NIA

Description
Expose the NIA, same as the other schemas.

I have deliberately removed it since now we have a much better higher-level API with Nia.
What is your reason to bring it back?


Cannot Delete Folders

No ability to delete directories from the file manager

It is probably because by putting the chown command to www-data you cannot put in your host user

OK?


Use same request method when following 308 status

Pretty much the same as Issue https://github.com/olalonde/follow-redirects/issues/27, HTTP 308 redirects should also use the same request method rather than changing the method to GET.
Per RFC 7238:

308 Permanent Redirect
The 308 (Permanent Redirect) status code indicates that the target resource has been assigned a new permanent URI and any future references to this resource ought to use one of the enclosed URIs.
Clients with link editing capabilities ought to automatically re-link references to the effective request URI (Section 5.5 of [RFC7230]) to one or more of the new references sent by the server, where possible.
The server SHOULD generate a Location header field ([RFC7231], Section 7.1.2) in the response containing a preferred URI reference for the new permanent URI.  The user agent MAY use the Location field value for automatic redirection.  The server's response payload usually contains a short hypertext note with a hyperlink to the new URI(s).
A 308 response is cacheable by default; i.e., unless otherwise indicated by the method definition or explicit cache controls (see [RFC7234], Section 4.2.2).
Note: This status code is similar to 301 (Moved Permanently) ([RFC7231], Section 6.4.2), except that it does not allow changing the request method from POST to GET.

That's right; tracking the status of this in #12.

Ok, cool. 👍   Good to know that you're already on it.  Thanks for the great library!


ListView draw outside the bottom bound after upgrade to Flutter 2.5.0

After upgrade to Flutter 2.5.0,The default behavior of ListView has changed. If shrinkwrap is set to true, the boundary will be exceeded when dragging down, and I can't find a solution.
Source code (base on Flutter demo application):
class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text(widget.title),
        ),
        body: Container(
          color: Colors.red,
          child: ListView.separated(
              shrinkWrap: true,
              itemBuilder: (BuildContext cxt, int index) {
                return Text(index.toString());
              },
              separatorBuilder: (BuildContext cxt, int index) {
                return const Divider();
              },
              itemCount: 10),
        ));
  }
}

When draging down:

flutter doctor -v:
[✓] Flutter (Channel stable, 2.5.0, on macOS 11.5 20G71 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.5.0 at /Users/hanshow/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cc385b4b8 (24 hours ago), 2021-09-07 23:01:49 -0700
    • Engine revision f0826da7ef
    • Dart version 2.14.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/hanshow/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (3 available)
    • Eric的iPhone (mobile)   • 848a623cc8b97cb9f228d7bcdab7cfb3e927f6a1 • ios            • iOS 14.6
      18F72
    • iPhone 11 Pro (mobile) • A644453F-7AF6-4F01-8BDA-3BD4BDADADA5     • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • Chrome (web)           • chrome                                   • web-javascript • Google
      Chrome 93.0.4577.63

• No issues found!

Hi @git2321231, Thanks for filing the issue, I am able to replicate the issue on the latest stable 2.5.0 and it seems to working fine on 2.2.3  so this seems to be a regression. This issue is reproducible on the latest master 2.6.0-1.0.pre as well.

2.2.3
2.5.0

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter_dev
    • Framework revision f4abaa0735 (2 months ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.59.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • B622CBB7-F906-4FA7-8F49-FACEAAC905AB • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 11.5.2 20G95 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 93.0.4577.63

• No issues found!

[✓] Flutter (Channel stable, 2.5.0, on macOS 11.5.2 20G95 darwin-arm, locale en-GB)
    • Flutter version 2.5.0 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cc385b4b8 (28 hours ago), 2021-09-07 23:01:49 -0700
    • Engine revision f0826da7ef
    • Dart version 2.14.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.59.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • B622CBB7-F906-4FA7-8F49-FACEAAC905AB • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 11.5.2 20G95 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 93.0.4577.63

• No issues found!

This issue seems related to https://github.com/flutter/flutter/issues/86584

Hey @git2321231 thanks for reporting! I suspect this may be from https://github.com/flutter/flutter/pull/87143, investigating now. :)

Can you share the expected behavior @git2321231?
Do you think that the list should not overscroll?
Or should it overscroll with the red background extending to fill the space?
I have confirmed this was caused by #87143, which resolved this issue https://github.com/flutter/flutter/issues/10949

Also a potential expectation: That the red box stays the same size and the overscroll sees the end content disappear within the bonds of the box.

@Piinks Thank you for your reply. I think listview should scroll within its parent widget(red container). And whether dragging up or down, it should have the same performance. In the current version 2.5.0, scrolling up will not exceed the top boundary, but scrolling down will exceed the bottom boundary, which is strange. Hope to see fixes in future releases. thank you.

In most app designs, the red container in the example may be designed as a background with rounded corners and outer margins to wrap the list content.  we use shrinkwrap to make the outer container close to the content.Therefore, it is not expected to exceed the boundary when dragging.:(

Thank you for the additional context!

The fix is in #90419 :)

@Piinks @maheshmnj
Today, I switched to the master branch and updated it to the latest version 2.6.0-12.0.pre.281, but this problem still hasn't been solved. I checked the branch submission record and confirmed that the #90419 solution to this problem has been merged into the master branch, but the list content will still exceed the boundary. You can try again using the code above.
At present, the project of our company cannot be released because of this bug. We sincerely hope to solve this problem as soon as possible. Thank you very much:)
flutter doctor -v
[✓] Flutter (Channel master, 2.6.0-12.0.pre.281, on macOS 11.5 20G71 darwin-x64,
    locale zh-Hans-CN)
    • Flutter version 2.6.0-12.0.pre.281 at /Users/hanshow/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 45ffcc646d (6 hours ago), 2021-10-08 17:18:02 -0400
    • Engine revision 597516c2fe
    • Dart version 2.15.0 (build 2.15.0-178.0.dev)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/hanshow/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.61.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (3 available)
    • TC601 GWL (mobile)     • A521201901769                        • android-arm64  • Android 9 (API 28)
    • iPhone 11 Pro (mobile) • EB193F60-B00D-4778-802E-C89AC2C63952 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-1 (simulator)
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 94.0.4606.81

• No issues found!

@Piinks After looking at your test example, I found the difference. In your example, the reason why you passed the test is that you have specified the height of the container as 150. If you do so, specifying shrinkwrap is meaningless. You should verify without specifying the height of the parent container.
Your test example:
Directionality(
          textDirection: TextDirection.ltr,
          child: MediaQuery(
            data: const MediaQueryData(),
            child: Column(
              children: <Widget>[
                Container(height: 100, color: const Color(0x00000000)),
                Container(
                  height: 150,
                  color: const Color(0xFFF44336),
                  child: ListView.builder(
                    shrinkWrap: true,
                    physics: const BouncingScrollPhysics(
                        parent: AlwaysScrollableScrollPhysics()),
                    itemBuilder: (BuildContext context, int index) =>
                        Text('Item $index'),
                    itemCount: 10,
                  ),
                ),
                Container(height: 100, color: const Color(0x00000000)),
              ],
            ),
          ),
        )


QOL - FancyZones Layout Editor - Add editable number box in addition to slider for spacing adjustment

Description of the new feature / enhancement
In the layout editor of FancyZones, the sliders to select "space around zones" and "highlight distance" have an excessive maximum, and this makes it too difficult to slide to specific numbers. Even using precision mode on my mouse, it jumps around too much, and is frustrating to get it to land on or around the number I want.
I suggest adding an editable box next to each slider, where it shows what it's currently set to, with the ability to type in a specific number to change it, rather than relying solely on a slider for adjustments.
Scenario when this would be used?
This would be useful for adjusting layouts much easier and quick than the current setup.
Supporting information
No response

/dup #463


supportingText slot missing in TextField MaterialApi3

I was porting a form to jetbrains compose and noticed the slot
supportingText: (@Composable () -> Unit)?,
is missing from the mpp implementation of material3

What version of jetbrains compose do you use?
supportingText was added to compose 1.3 that is not released by JetBrains yet.

Ah. I am using jbcompose 1.2.2 and porting from jetpack compose 1.6. Just a toy thing to try things out.
I checked the version numbers before posting and saw Material3 v1.0.0 is the version that got the slots added. I thought it was in jbcompose 1.2.2.
Is there a doc that has the jetbrains -> jetpack compose version support? E.g. jbcompose v1.2.2 has; XYZ v1.2, ABC v1.0, etc...

Is there a doc that has the jetbrains -> jetpack compose version support? E.g. jbcompose v1.2.2 has; XYZ v1.2, ABC v1.0, etc...

The CHANGELOG has those:

This version of Compose Multiplatform is based on the next Jetpack Compose libraries:

Compiler 1.3.2
Runtime 1.2.1
UI 1.2.1
Foundation 1.2.1
Material 1.2.1
Material3 1.0.0-alpha14

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Samples does not have README.md

The main README.md file says "The samples' README.md has instructions for running the samples." But there is no such README.md file. We should make sure the instructions for running the samples are somewhere.

@anguillanneuf, do we have instructions somewhere for running java pubsub samples, or do we need to create new instructions in a README?

Good catch! I will add.