Re-design mockup for zero-knowledge assets

Description
Zero-knowledge assets are a way to transfer ownership of a private asset (the amount transferred is secret) on a public blockchain (in this case Ethereum is the blockchain, and AZTEC is the zero-knowledge technology built on top of it). There are two kinds of assets on Ethereum (public tokens, sometimes called ERC20, and a newer, private kind, called ERC1724). Don't think of these assets as just money or shares of stock; for this demo it could be shares of a building or a co-op, a commodity like sheep or bales marijuana, trees in a rainforest, hours of someone's time.
This mockup will eventually be launched as a web demo to let people interact first-hand with zero-knowledge assets in their browser, on Rinkeby/Goerli testnets first, to gain some intuition and experience. It is meant to convey these values

modern / minimalist
stylish
trustworthy & predictable, but not stuffy
private (in the sense that the values viewable in your browser are not viewable by anyone else, not even the server)

Although dynamic user effects are described below, your mockups will just be static 2D visual layouts in Figma, with start/end views and a description for the engineer on how any elements will transition.
This particular bounty is meant to ideate and produce at least three different mockups, from as original or independent views as possible, that can then be narrowed down and implemented in separate (code / implementation) bounties in React and launched on Netlify or some other static site.
User interaction and Features Targets
The first draft mockup is here:
https://www.figma.com/file/mDwfpNj5OC4pw68tujfOma/Confidential-Transfer-Demo
Read it with the comments (speech bubble icon) turned on to get an idea of the scope, but don't be tied to anything else (typeface, size, placement, ordering).
The different elements of the UX are:

When the page loads, the user gets wallet auto-created for them and a randomly chosen avatar icon. There is a link to the Etherscan page for their account.
Their balances of a few fixed tokens (ERC20 and ERC1724) are shown. They are minted new ERC1724 tokens, and their balances shown going up the correct amount. (there should be sound effect, which is muted by default, but a button somewhere to unmute for future refreshes)
Other online users at the same time (including a fixed "robot" user) can be selected as recipients. The user selects an amount of one token and clicks to start a "send" action.
Some kind of spinner icon begins, with a link to the corresponding tx on Etherscan.
When tx succeeds, another sound effect plays, their balance decreases, and the Etherscan link / spinner disappears.
If tx fails, a button / link is shown for them to try again, and the Etherscan link / spinner disappears.
Any incoming transactions from other users also increases the balance, and a notice appears describing which user sent the transfer, how long ago, and a link to Etherscan tx page.

How to work on this bounty:
Apply to work for this bounty on Gitcoin (for now) and send a short message mentioning any relevant bounties or online portfolios you've worked on, including links, your general design approach, and how you plan to handle some of the specific interactions above.
Fork this Figma, and implement your work in it
https://www.figma.com/file/mDwfpNj5OC4pw68tujfOma/Confidential-Transfer-Demo
I'll pay out $75 of equivalent ETH (or DAI as preferred) to each submission from anyone who reads through the above and sends in an original, worked through design (can be multiple winners). Please post your Figma links into the Github issue at least once as you work to receive feedback. I'll give you the go-ahead if your approach is significantly different enough from previous submissions, and if so, you can submit and be awarded multiple times before the deadline is up.
Creative Guidelines
Full bleed artwork or photography in a restrained way (sidebar, banner) can be used, but no parallax effects or gigantic hero images. The user interaction / token minting and transfers should be the focus. Don't worry about responsive / mobile layouts.
Display / header typefaces should be on the angular / geometric / slab serif side, neither too futuristic nor too traditional, but paired with any body face that complements well. Display header text can be images if you'd like to use fonts on your computer that are not available online for free. No specific guidelines on color scheme.
You may enjoy this browser extension that lets you explore Google Fonts / color schemes in your New Tabs: https://palettab.com/
Despite the first draft above, all three cooperating projects (AZTEC, RealBlocks, Democracy) should be treated as equal importance and appear at the bottom in a smaller form.
You can make use of the AZTEC and RealBlocks logos from their respective websites:
https://aztecprotocol.com
https://realblocks.com
and also any part of this image as a logo for Democracy.js.

Have fun 🎉  and even the guidelines above can be wiggled if you have a good reason or a strong 💪  concept. Ask questions or not, thanks for reading this far, and look forward to seeing some new creations appear.

hi @seichris thanks for applying and linking to your previous work. You're good to start. In answer to your question, I'd prefer the workflow be so simple as to show all the information at once (no hiding, not modal). For example, the Step 1 (choosing an amount to send) should remain active to show an updated balance after Step 2 (choosing a recipient)

@cryptogoth i made a first draft for the page:
Here is the editable figma: https://www.figma.com/file/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=0%3A1
And this is the click-through demo: https://www.figma.com/proto/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=1%3A141&viewport=-44%2C252%2C0.39714527130126953&scaling=min-zoom
Let me know what you think // what you would change :)

@seichris this looks wonderful, thank you!
I especially like the clean design of the main interaction and the emoji avatars.
How do you feel about making your main token interaction take up the whole screen?

We can add a title into the header-bar like "Zero-knowledge Assets"
I also like adding text / space at the bottom to describe technical details of how the system works.
For simplicity, how do you feel about not having an initial "generate wallet" screen, but auto-generating a random name (like whimsical docker container names https://frightanic.com/goodies_content/docker-names.php), and enabling the user to click on either the name or avatar to change, up in the header?
(keep that screen in the Figma mockup, however, for future reference)
The user can only choose to send one token at a time, but needs to know their balances for all tokens. The current amounts looks like an editable text input. How about showing non-editable balances for all of them, and an editable blank (in a separate column) appearing just for one currently selected token at a time?

I feel like the airplane/send icon can appear just next to the recipients in Step 2 as well, and they are not needed in Step 1.
I like the "Sound on/off" switch. I don't think the "Reload tokens" is necessary, as I plan to have the token balances auto-updating in the background (either with websockets or a polling function that re-retrieves from a blockchain node every 5 seconds)
I'm not in love with my initial choice of Lobster, so feel free to get rid of the whole current header. The Realblocks/AZTEC and Democracy.js credits can be moved to the bottom. We'll need better images than the screen-grabbed Realblocks / AZTEC logos, I used, and I'd like to include the three Ethereum logos (Gold/Blue/Magenta) above as the Democracy.js logo as well.
Whew, okay thank you again. This is a great re-design and i'd be proud to see the demo look like this.

@cryptogoth Thanks for the nice feedback!

About the full-screen I am not sure, since the whole UI does not really need the full space of the screen. Maybe you want to use the background for something else?

Had the same idea about the random name generator. Did you see my comment?

Not sure if I understand the logic about sending tokens. Do you want users to send only one token, or edit the text field and send a certain number of tokens?

Hi Chris,

the full header bar across the top and steps 1 and 2 being narrower works for me. Interesting idea about using background, will keep thinking. Maybe showing the march of recent block numbers across the screen. the darker solid color for now focuses user attention well.

Figma comment? I'll take another look.

For simplicity I'm imagining the user can only send one token at a time, so Im thinking that a currently selected token is highlighted, has an editable amount field, and a button to proceed to step 2 (maybe a right arrow instead of the paper airplane icon). Pressing enter would also advance to step 2. but all the Tokens have a non editable balance. Thoughts?

For step 2, also imagining that a highlight or outline follows the user's cursor around the recipients, and shows the paper airplane icon just for the one under hover. Clicking would initiate the TX, and perhaps airplane would fly off :)
 again, great work, this is shaping up well.
On Dec 10, 2019, 9:19 AM, at 9:19 AM, Chris Seifert<EMAIL_ADDRESS>wrote:

@cryptogoth Thanks for the nice feedback!

About the full-screen I am not sure, since the whole UI does not
really need the full space of the screen. Maybe you want to use the
background for something else?

Had the same idea about the random name generator. Did you see my
comment?

Not sure if I understand the logic about sending tokens. Do you want
users to send only one token, or edit the text field and send a certain
number of tokens?

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/invisible-college/democracy/issues/36#issuecomment-564053377

Ok great. I'll also think about the background a bit.

It's just funny, we came up with the same solution. Seems to be the intuitive one :)

To show the icon only on hover makes sense. Also we could do a small hover animation to focus the current item and make the others a bit opaque. Like in the navigation bar here https://sagescaling.com/

Like so:

I still didn't get which tokens have editable fields though...

just read it, yes. Lol Satoshi Buterin and Mr. Robot, I will definitely have to add them into the mix.

Love it. For Step 1, the editable field can just disappear for all the tokens that are not beneath the cursor hover. The balances for all the tokens (non-editable, but not grayed out) would still appear in a separate column, like in the original mockup.

It's not a perfect design, but I think it's good enough for now. I'll keep thinking if there's something more clever / elegant.
After that's done, I'm happy to accept your submission and pay the bounty. This has surfaced some interesting questions, but it's ready for a dev to implement it in React (in a separate bounty)

Great progress is happening, and I didn't mean to cut short any more work or ideation. I'll keep the bounty open until the deadline and would love to see and reward additional submissions, or collaborations among all of us to solve the remaining design puzzles above.

Ok, just fixed the design again and included the hover animations in the click-through demo: https://www.figma.com/proto/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=50%3A51&viewport=374%2C301%2C0.1188763678073883&scaling=min-zoom

@cryptogoth  Hi, I made a draft and I'd like to know what do you think about it.

Beautiful banner image and icons, thank you for another original design @biuxmaster
Can you send a link to the original Figma?
My main feedback, open to ideas or suggestions: can you try another main color besides purple?
Also, I'm feeling the need for more space between the tops of the circle icons for each step and the "Democracy.js" and "You are connected" bar.
For the avatar icons, can you choose a set which can either be automatically generated randomly (perhaps the three you've shown, but in random permutations of colors, including other skin tones besides white), or a public image set, like Emoji.
The idea of offline users is cool, it would solve the need for a robot user, but also be potentially huge after the demo has been online for awhile. Hmm..
I like the 4th pane showing status messages.
In a separate screen (keep the version above), can you show in the 4th pane what a failed tx would look like, in a scrolling view showing all the tx history since the last refresh:

You have received 22 RBT (privately) from Peppy Jones (See on Etherscan).
You have successfully sent 1 BMT (privately) to Anastasia. (See on Etherscan)
Your transaction to send 2 DAI to Matt (publicly) has failed. Try again.

The button "show your address" can be removed and the Ethereum address below can be a text link, not inside a text field.
Likewise the button "Etherscan" can be removed.
Thank you again for the new visual / interaction ideas.

Thank you @seichris your last mockup's interaction is smooth, and all the elements work together to create a self-contained experience. Making a clickable demo with Figma is now my favorite feature.
@writeprovidence @biuxmaster I'm glad to pay additional bounty amounts for any submissions of yours as well in next three days.

@cryptogoth  Hi, I already fixed the design with the ideas you gave, also, please don't forget to check the comments
https://www.figma.com/file/KEV19jwlvgd3m9lexQx9KL/Confidential-Transfer-Demo?node-id=0%3A1

Thanks @biuxmaster the design updates looks great. Is it okay if I pay out the ETH for the bounty directly to the same address as last time?

I'm glad you liked it  and yes sure no problem for me

Payment sent @biuxmaster thank you again. I will wait for all submissions on gitcoin before paying out the bounty next time, just to get this counted in your Gitcoin stats.
Looking forward to working with you all in the next bounty.

@cryptogoth  almost done with the design. was still working on it

will be done before dateline

@cryptogoth sorry for sending my design a bit late, here is a link to what i could come up with https://www.figma.com/file/Q5FU7i93rFB8cBK1R5trkf/zero-knowledge-assets?node-id=0%3A1

thanks, waiting for your feedback

Hi @writeprovidence thanks for the effort. I think the design is too similar to previous submissions to qualify for the bounty, and it is past the deadline. For future bounties, please check in here on the github issue thread earlier and more often, and hopefully we can get your ideas and work integrated into a collaboration.

@cryptogoth Thanks for your feedback


Add support for copy/add with multiple src files (part 1)

Part one of solution for issue #6820
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

Is there an example of this anywhere?

@kkirsche
ADD test_file3 test_file4 test_file5 /destination/


[BUG] Potential Issue With SideStore/SparseBox/LiveContainer installations

Describe the bug
Related Issue on SideStore: https://github.com/SideStore/SideStore/issues/749
I'll try to keep the details short and concise, and if you want to read more, I've described it in the linked issue above. I noticed after using SparseBox's bypass for SideStore that after some time, I have an issue with SideStore re-installing existing apps, installing new apps, or refreshing only SideStore. Here is the following issue that I receive from SideStore:

Install <app_name> Failed
minimuxer.MinimuxerError 0
The operation couldn’t be completed. Unable to install the app: Couldn't get com.apple.installd.validatedByFreeProfile EA from "/private/var/containers/Bundle/Application/29CBBEA8-E8AA-4017-8A5B-3B5492E46A11/App.app": No such file or directory

To mitigate and not resolve the issue

Uninstall all sideloaded apps including SideStore
Re-sign SideStore via AltServer (or I guess SideServer can work?)
You won't get the issue anymore... for some time as the issue will only be mitigated and not resolved fully

Further findings
Today, I updated SparseBox and used the view AppList feature to see if the app bundle ID that is causing issues is shown as installed. It was. The app bundle ID associated with SideStore's error is the bundle ID for LiveContainer. However, the odd thing is that I can use LiveContainer just fine, so I'm not sure why it's saying that "No such file or directory". Unless, by refreshing LiveContainer, or any other app within SideStore, it changes the bundle ID?
Is this an issue with LiveContainer?
Instructions to reproduce
I'm not entirely sure how to re-produce it because the issue I'm having happens at a random time. Typically after a week or two when attempting to re-sign my apps. I can tell you my environment in hopes that it clears some things up.

Installed SideStore via AltServer
Installed SparseBox and LiveContainer onto that SideStore app instance

Later, I did the bypass app limit function within SparseBox
After wards, I installed more instances of SideStore again via AltServer after having bypasses the app limit, and after each install, I re-ran SparseBox's bypass.
What version of LiveContainer are you using?
Version 3.0.0-release (main/8b6e503)
Other info
For potentially more details on this issue, please take a look at https://github.com/SideStore/SideStore/issues/749 if you have the time. Thank you for your help and time.

LiveContainer never touches your mobilegestalt and it's just an ordinary app when installing, so I highly doubt this is not an issue with LiveContainer but a SparseBox/iOS issue since it just abuses mobilegestalt in a way it is not intended to work.

I highly doubt this is not an issue with LiveContainer but a SparseBox/iOS issue since it just abuses mobilegestalt in a way it is not intended to work.

That was my thoughts originally, but it is odd how when trying to install apps, it lists LiveContainer as the culprit for an error currently. I suppose that explains why it supposedly lets me refresh any app except for SideStore since SideStore depends on SparseBox?

All I have to do is do the “Bypass 3-App Limit” option again then it’s fixed

All I have to do is do the “Bypass 3-App Limit” option again then it’s fixed

I tried that several times and even rebooted before attempts too in hopes of it fixing something. Didn't work. Well actually it worked once I think, but this time nothing I did worked and it kept giving me the same error with LiveContainer's bundle id.


Brush tests are failing.

I started a Kotlin Brush module, and noticed that all of the default brush modules are failing tests with something like:
> babel-node --only='syntaxhighlighter-*,brush-*' node_modules/.bin/_mocha --opts mocha.opts test.js

/home/travis/build/ethauvin/brush-kotlin/node_modules/mocha/node_modules/glob/glob.js:78
undefined._processingEmitQueue = false;
                               ^

TypeError: Cannot set property '_processingEmitQueue' of undefined
    at Object.<anonymous> (node_modules/mocha/node_modules/glob/glob.js:79:1)
    at Module._compile (module.js:413:34)
    at loader (/home/travis/build/ethauvin/brush-kotlin/node_modules/babel-register/lib/node.js:151:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/travis/build/ethauvin/brush-kotlin/node_modules/babel-register/lib/node.js:161:7)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (node_modules/mocha/lib/utils.js:10:12)
    at Module._compile (module.js:413:34)

npm is not really my cup of tea, but I was able to get a little further by changing the babel-node command to:
babel-node --only='syntaxhighlighter-*,brush-*' node_modules/.bin/mocha --opts mocha.opts test.js

Still fails though.
Any help would be greatly appreciated.

I have the same problem and I'm new to node.js:( Any syggestions?

I would love a solution to this as well as it is blocking me develop a brush for Gherkin


Relax version requirements for dependencies

The version requirements for dependencies with a vesion < 1 have been relaxed to allow any recent pre-release version.

Codecov Report

Merging #39 (b3126f7) into main (3f879f7) will decrease coverage by 48.48%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #39       +/-   ##
===========================================
- Coverage   59.15%   10.66%   -48.49%
===========================================
  Files           4        4
  Lines          71      956      +885
===========================================
+ Hits           42      102       +60
- Misses         29      854      +825

Impacted Files
Coverage Δ

src/lib.rs
6.76% <0.00%> (+6.76%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Swagger UI Part 1 - rawtransactions

This PR encompasses the discussions in Issues #151 and #148. This 'part 1' PR was created to break up the changes so that the PR doesn't become too large and unwieldy. The highlights of this PR:

Several fixes were made to the swagger UI for endpoints other than rawtransactions.
Gabriel's changes to the swagger json file, in order to break it up into smaller files, are incorporated in this PR.
Several rawtransaction endpoints were converted from either GET or POST to PUT.
Several rawtransactions endpoints were removed from the swagger UI. The reasoning is captured in Issue #148.
Additional integration tests were added to replace the missing swagger UI endpoints.

Pull Request Test Coverage Report for Build 843

0 of 0   changed or added relevant lines in 0 files are covered.
93 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.04%) to 80.423%

Files with Coverage Reduction
New Missed Lines
%

dist/routes/v2/mining.js
5
77.09%

dist/routes/v2/blockchain.js
38
81.38%

dist/routes/v2/rawtransactions.js
50
82.09%

Totals

Change from base Build 832:
-0.04%

Covered Lines:
2493

Relevant Lines:
2916

💛  - Coveralls

:tada: This PR is included in version 1.14.0 :tada:
Your semantic-release bot :package::rocket:


Incorrect position marker for Angus Stern

Angus Stern seems to be erroneously listed as being located at around 41 89 in SW, instead of his actual location of 51.8 93.6. Perhaps this was his location in SW before the Harbor?
NPC: Angus Stern - 1141

[1141] = {
["coords"] = {
[1] = { 41.5, 89.4, 1519, 30 },
},
["fac"] = "A",
["lvl"] = "60",
},


Persist class information and added properties (and methods) in browser for next-time editing

Currently when user refreshes the page, or closes the browser then visits the website next time, previous class information will be lost. We can backup the current session's data in the user browser's localStorage, and in each page load, check whether there is such a backup, and if there is, restore it.

Solved by #5b71c27


manage.py show_urls not working with Django 1.7

I run into a problem using show_urls command on my mac with Django 1.7. For both these commands python manage.py show_urls and  python manage.py show_urls --format=dense, I got this error:

(env) wael.benzid$ python manage.py show_urls
CommandError: Format style 'None' does not exist. Options: ['dense', 'verbose', 'pretty-json', 'json', 'table', 'aligned']

Environment:

OS: macOS Sierra
Python: cPython 2.7.9
django-extensions==1.7.9
Django==1.7.10

Regretfully Django 1.7.10 is not supported anymore.
If there is a simple fix for this that does not hinder maintenance then please submit a PR.


Xamarin.Forms iOS - 2.2.1 version does not show images from Asset Catalogs

Xamarin.Forms.Image & CachedImage v2.1.8 - show these images correctly.

It's fixed here: https://github.com/luberda-molinet/FFImageLoading/commit/f475d628f1a8bd65467dee8d7720bc7ecbfb942b
I'll release it today.

v2.2.2 - the problem not fixed.

Could you give more details?

Could you try 2.2.3 prerelease?

2.2.3 release - the problem not fixed.
Asset Catalog Image Sets [Preferred] - Added in iOS 7, Asset Catalogs Image Sets contain all the versions or representations of an image that are necessary to support various devices and scale factors for your application. Instead of relying on the image assets filename (see the Resolution Independent Images and Image Nomenclature), Image Sets use a Json file to specify which image belongs to which device and/or resolution. This is the preferred way to manage and support images in iOS 9 (or greater).
https://developer.xamarin.com/guides/ios/application_fundamentals/working_with_images/displaying-an-image/#adding-assets
Xamarin.Forms.Image and FFImageLoading.Forms.CachedImage v2.1.8 shows images from the Asset Catalog. v2.2.1 and later - does not show (shows empty or ErrorPlaceholder image).

Could you test 2.2.4 prerelease and see if it's working? Thanks.

Yes, it's working - v.2.2.4-pre-201.
Thank you!

I confirm this is working on latest pre-release 2.2.10-pre-408. The latest stable 2.2.9  was not working when I tried to load from Assets.


feat: debug segment

:tada: This PR is included in version 1.46.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Documentation] Examples should include WebGPU

The wasm-bindgen documentation has a helpful example of using wasm-bindgen to call WebGL. However, WebGL is slated to be replaced with a new tech called WebGPU. WebGPU is now very close to "shipping" (Chrome Beta 113 was released last week with WebGPU on by default on desktop). Therefore, it would be a good idea for the WebGL example to be accompanied by a WebGPU example by the time Chrome 113 is released.
Motivation
I am trying to make an application that uses the "wgpu" library on desktop and the webgpu bindings on web. This is an intended-supported use of the wgpu library and this is supposed to be "easy" with tools like wasm-pack. However I don't know how to do it and if you don't already know how it works then it is not easy. The closest-to-relevant example code/example project I've yet found is the wasm-bindgen webgl sample, so I will be using that as a model. If I am able to adapt the webgl project into a webgpu project, I will create a PR (unless a documentation effort for this is already in progress somewhere I've missed).

unless a documentation effort for this is already in progress somewhere I've missed

Not as far as I'm aware.
If you need any help feel free to post here. Happy to review the final PR.

OK. I have a working example but I'm not sure I did it correctly so I need to think about that before attempting a PR.


URC parser does not allow colon

The Modem I use (Quectel EC25) after connecting or trying to connect to the Network sends something like
+QMTOPEN: 0,3
I know that / how I can implement my own parser for responses to client.send(), but this response is delayed after the command to the Modem, and hence I seem to need to add the  #[at_urc("+QMTOPEN")] to the Urc enum.
Unfortunately I get
ERROR atat::ingress               > Parsing URC FAILED: "+QMTOPEN: 0,3"
and hence no return from subscriber.next_message().await;
We already did test, that the standard parser does not like colons.
Is this intentionnally ?
Is there a way to handle such Modem responses ? (This modem sends colons in a lot of Urcs. )
-Michael

I am not quite sure what is wrong in your case, but all the URC's i am using this for are using colon, and it works fine?
https://github.com/BlackbirdHQ/ublox-cellular-rs/blob/master/ublox-cellular/src/command/mod.rs
It's a bit hard without seeing your enum

I have:
pub enum Urc {
    #[at_urc("+QMTRECV")]
    QmtrecvReceived(mqtt::on_receive::OnReceived),
    #[at_urc("+QMTOPEN")]
    QmtopenReceived(mqtt::on_receive::OnReceived),
    #[at_urc("+QISTAT")]
    QistateReceived(mqtt::on_receive::OnReceived),
}

I can reproduce the problem with just one.

(Not in the office right now)
AH, the OnReceived struct is used to configure the Parser. That does make sense.
As I did not find information on that, I just put some random elements in that struct <actually meant for MQTT responses, but right now I am testing other stuff>.
So I need to construct a decent OnReceive struct for responses such as +QMTOPEN: 0,3
I'll try to find more information on that ... (
Thanks

Yep !
with constructing an appropriate OnReceived struct such as

#[derive(Clone, AtatResp)]
pub struct OnReceivedQmtOpen {
    pub p1: u32,
    pub p2: u32,
}

it works.
Thanks for your help !


Created experimental collection upsert fn

Codecov Report
Base: 16.56% // Head: 18.11% // Increases project coverage by +1.55% :tada:

Coverage data is based on head (1ffec36) compared to base (19a30f1).
Patch coverage: 53.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #31      +/-   ##
============================================
+ Coverage     16.56%   18.11%   +1.55%
- Complexity      186      205      +19
============================================
  Files            36       39       +3
  Lines           670      723      +53
============================================
+ Hits            111      131      +20
- Misses          559      592      +33

Impacted Files
Coverage Δ

app/Kata/KataRunner.php
0.00% <0.00%> (ø)

app/Models/Blog.php
0.00% <ø> (ø)

app/Models/ExchangeRate.php
0.00% <ø> (ø)

app/Models/User.php
100.00% <ø> (ø)

app/Services/ExchangeRateService.php
0.00% <0.00%> (ø)

app/Collections/BaseCollection.php
86.66% <86.66%> (ø)

app/Kata/Challenges/KataChallengeMySQL.php
77.77% <100.00%> (-22.23%)
:arrow_down:

app/Kata/Challenges/KataChallengeMySQLRecord.php
100.00% <100.00%> (ø)

app/Console/Kernel.php
60.00% <0.00%> (-40.00%)
:arrow_down:

app/Kata/Challenges/KataChallengeSample.php
81.81% <0.00%> (-18.19%)
:arrow_down:

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use Mambaforge and cache dependencies

Codecov Report

Merging #23 (150f68e) into master (52b1a1c) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   80.35%   80.35%
=======================================
  Files          12       12
  Lines         667      667
=======================================
  Hits          536      536
  Misses        131      131

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Ahh, I guess the work in this PR was already accomplished by e64477a5a1e8f47ce0beb88c580d1c67676a1dfe.


server/shadow: Fix regression with rdp8.0

Shadow server crash with rdp8.0 with gfx enabled.
Root Cause: rdp8.0 is not support in shadow gfx and rdpgfx_caps_advertise returns an error. However setChannelError crashs because context->errorDescription is NULL

Fix shadow gfx to handle rdp8.0
Initialize context->errorDescription for server side new-context

LGTM


InkWell.overlayColor is now resolved against MaterialState.pressed

InkWell's overlayColor property is now resolved against MaterialState.pressedState along with MaterialState.hovered and MaterialState.focused (as before).
This PR was factored out of https://github.com/flutter/flutter/pull/96252 because the InkWell.overlayColor MaterialStateProperty resolution changes affected a few internal golden image tests - https://github.com/flutter/flutter/pull/96252#issuecomment-1009170546.
Internal Google updates for these changes: cl/420793326

I was about to open an issue for this, as i had some issues while theming the state overlay. In my solution i also removed the overlayColor usage for theming the splash, here and here, along with the relevant section on the documentation. I think this should be done because otherwise the overlayColor would be incorrectly used to theme the unrelated splashColor, violating the user's expectations and leading to confusion. What do you think about this?

@KalilDev - I agree with you that just using the splashColor to render ink splashes would be more intuitive. Undoing the existing code/doc as you've suggested would likely cause some breaks in (Google internal) golden image tests. If you'll open an issue, I'll try and address the problem in a separate PR.

Must be rolled with (internal Google link) cl/420793326


Assassins getting stuck in weird state

Btw have you ever failed an assassin rush against the Rat or other opponents due to the assassins getting stuck in a weird state in a 1 tile wide gap between keep and some wall, after sliding down that wall?
After climbing and sliding down the high wall (for low walls, the issue does not occur), they are standing on the ground, occasionally flickering a bit (animation / visuals), but are fighting units that stand atop the keep (which should not be possible).
They also cannot be moved away from their location as they ignore any "move here" commands, exactly as they would do while they are climbing or sliding down a wall, despite (visually) standing on the ground and not hanging from a wall.
Moreover, they only deal like less than 3% or so of their regular melee damage and also take (seemingly?) less damage than usual themselves - they still seem to take more damage than they deal, relative to the normal values.
This lasts until either the assassins die, or any hostile units in attack range die - that is, "any hostile units that would be in attack range if height differences were ignored".

Here a more reduced scenario...

...with a sped-up second half of the "encounter":

And in comparison, what if the assassin does not climb and slide but instead just stands atop the wall:

The assassin can not attack enemies on the keep, unless the 1 tile gap of low ground is "bridged" with a wall tile, then he can thrust across that 1 tile distance (and vice versa).

Yeah I've noticed this too, its rather annoying and while Assassins are my favorite unit in the game I tend to rarely use them because they're so bugged.
If you order an assassin to climb a wall/tower/gatehouse/keep and they're interrupted along the way (ie they run into an enemy unit and attack) they forget their previous orders afterwords and just stand there. Meaning you have to keep ordering them to scale castle buildings because they keep forgetting.

A fix for the one tile gap bug AND the assassin "forgetfullness" bug is in testing phase.

Amazing! :)


final check before we submit to zenodo

@marctang, this is almost ready now, I added a file .zenodo.json which will organize how this will be rendered on zenodo, but one can later also modify it. I suggest, if you tell me you're ready, we'll make the release and this will then be automatically uploaded to zenodo, so you have your DOI for the code, and can also link that e.g, on your website, etc.

BTW: you had duplicate sources in your bibtex, I had to remove them.

Checking this with Python is easy (now you have all the software installed):
>>> from pycldf.sources import Sources
>>> Sources.from_file(yourbibtex)


First steps towards nix static build

Initial work to create a static nix build.  Should be followed up by (rebased) #2231
cc @alfreb

Awesome, thanks!


Restrict access by OAuth2 domain

My goal is to be able to limit access to some backend applications using Google OAuth2. I'm a Google Apps user and would like to start by limiting access by domain. Using loginsrv with caddy-jwt there doesn't seem to be a way to limit access based on the email address domain. It seems it would require support for regex in the caddy-jwt plugin for field values or perhaps I'm missing a simpler solution.
I'm wondering if parsing out the domain and including it in the JWT is something that would be in-scope for this plugin. Or if you would be willing to optionally support pulling information from any of the additional scopes that could also be helpful in limiting access, such as user groups: https://developers.google.com/admin-sdk/directory/v1/guides/authorizing
I'd like to tackle this in the most reusable way in case I can contribute some code.
Thanks!

Hi @freb,
it is definitely in scope for loginsrv to extend it in this way.
Currently I have no good idea, about a common structure of the UserInfo Object.
There needs to be a structure, which is suitable for a broader set of OauthProvider (z.g. google, github, facebook, Keycloak and others)
Also see #8 and #37 for that.

I read the other two issues, and either of them would solve my use case. I'm always a fan of being able to inject custom functionality, weather through calling an external script, callback function, plugin, etc. It allows you to do more than just manipulate the UserInfo.
I'm really only familiar authenticating against the Google API and haven't looked much into what other information would be nice to have in the UserInfo object. If I get some time, I'll see if I can come up with some ideas.

Hi I've made a change to include domain for google oauth.
https://github.com/tarent/loginsrv/pull/48

Thanks for this @lhopki01. I ended up just listing the full email addresses individually so kind of dropped the ball on this. Since its now fixed I'm closing the issue.


Update tried to install unsigned Dokan driver on Windows 10

When Keybase notified me of an update yesterday on Windows 10 and I accepted it tried to install an unsigned Dokan driver. I know there is a signed driver so this looks like an error.

Same thing here.
Translating the important bits from the dialog that popped up in Swedish:
"A digitally signed driver is required
Dokan Driver
Dokan Project"

Same issue while installing the update today : Keybase install asks for reboot twice, and finally the same Windows dialog as @magebarf popped up on my screen; now, I can't use KBFS anymore, running kbfsdokan fails with errors :
- ERROR Failed to mount dokan filesystem (i=8): Dokan failed: code=-3 "Driver install error"
- INFO Created new folder-branch for 483649d6412cc104aba48f30d345e017
- ERROR Failed to mount dokan filesystem (i=16): Dokan failed: code=-3 "Driver install error"
- ERROR Failed to mount dokan filesystem (i=32): Dokan failed: code=-3 "Driver install error"
- ERROR Failed to mount dokan filesystem (i=64): Dokan failed: code=-3 "Driver install error"
- ERROR Failed to mount dokan filesystem (i=128): Dokan failed: code=-3 "Driver install error"
- ERROR Mounting the filesystem failed: %!(EXTRA *errors.errorString=Dokan failed: code=-3 "Driver install error")
- INFO Mounting the filesystem was a success!
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0xdb50e6]

Cc @zanderz

Cc @taruti also

Sorry for the aggrivation, but the updated drivers had not gone through the special Microsoft attestation signing step required by certain versions of Windows 10. We'll shortly have a new build with correctly signed drivers.


Fix log correlation for log4j2

What does this PR do?
Fixes #1719
Checklist

[ ] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

[x] This is a bugfix

[x] I have updated CHANGELOG.asciidoc
[ ] I have added tests that would fail without this fix

[ ] This is a new plugin

[ ] I have updated CHANGELOG.asciidoc
[ ] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.

[ ] This is something else

[ ] I have updated CHANGELOG.asciidoc

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1720 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-03-29T17:53:39.430+0000

Duration: 3 min 2 sec

Commit: 370e508f11cf75d01583205254011b42ae422ae6

Trends :test_tube:

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here
Description: approval-list/elastic/apm-agent-java.yml

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output
Expand to view the last 100 lines of log output

[2021-03-29T17:56:11.083Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-03-29T17:56:11.085Z]  > git fetch --no-tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=100
[2021-03-29T17:56:11.903Z] Pruning obsolete local branches
[2021-03-29T17:56:12.357Z] Merging remotes/origin/master commit 256667dd53f34ed7ee5866f6ea9aa848f991650e into PR head commit 370e508f11cf75d01583205254011b42ae422ae6
[2021-03-29T17:56:12.627Z] Merge succeeded, producing 370e508f11cf75d01583205254011b42ae422ae6
[2021-03-29T17:56:12.627Z] Checking out Revision 370e508f11cf75d01583205254011b42ae422ae6 (PR-1720)
[2021-03-29T17:56:11.863Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-03-29T17:56:11.871Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-03-29T17:56:11.895Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-03-29T17:56:11.908Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-03-29T17:56:11.908Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-03-29T17:56:11.910Z]  > git fetch --no-tags --progress --prune -- https://github.com/elastic/apm-agent-java.git +refs/pull/1720/head:refs/remotes/origin/PR-1720 +refs/heads/master:refs/remotes/origin/master # timeout=100
[2021-03-29T17:56:12.365Z]  > git config core.sparsecheckout # timeout=10
[2021-03-29T17:56:12.370Z]  > git checkout -f 370e508f11cf75d01583205254011b42ae422ae6 # timeout=100
[2021-03-29T17:56:12.583Z]  > git remote # timeout=10
[2021-03-29T17:56:12.592Z]  > git config --get remote.origin.url # timeout=10
[2021-03-29T17:56:12.602Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-03-29T17:56:12.603Z]  > git merge 256667dd53f34ed7ee5866f6ea9aa848f991650e # timeout=10
[2021-03-29T17:56:12.617Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-03-29T17:56:12.628Z]  > git config core.sparsecheckout # timeout=10
[2021-03-29T17:56:12.633Z]  > git checkout -f 370e508f11cf75d01583205254011b42ae422ae6 # timeout=100
[2021-03-29T17:56:16.670Z] Commit message: "Relocating org.apache.logging in MdcActivationListener breaks log correlation for log4j2 (#1719)"
[2021-03-29T17:56:16.671Z] First time build. Skipping changelog.
[2021-03-29T17:56:16.694Z]  > git --version # timeout=10
[2021-03-29T17:56:16.702Z]  > git --version # 'git version 2.17.1'
[2021-03-29T17:56:16.712Z] fatal: bad object de5f52a9091c857929a1b04bd53726cce85ab70b
[2021-03-29T17:56:17.854Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-03-29T17:56:17.955Z] Timeout set to expire in 1 hr 0 min
[2021-03-29T17:56:17.995Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-03-29T17:56:18.455Z] [INFO] Number of builds to be searched 10
[2021-03-29T17:56:18.747Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-03-29T17:56:18.782Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1720/src/github.com/elastic/apm-agent-java
[2021-03-29T17:56:18.833Z] [INFO] gitCheckout: Checkout SCM PR-1720 with some customisation.
[2021-03-29T17:56:18.879Z] [INFO] Override default checkout
[2021-03-29T17:56:18.963Z] Sleeping for 10 sec
[2021-03-29T17:56:28.996Z] The recommended git tool is: git
[2021-03-29T17:56:29.159Z] using credential 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
[2021-03-29T17:56:29.236Z] Cloning the remote Git repository
[2021-03-29T17:56:29.252Z] Cloning repository https://github.com/elastic/apm-agent-java.git
[2021-03-29T17:56:29.287Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1720/src/github.com/elastic/apm-agent-java # timeout=10
[2021-03-29T17:56:29.301Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2021-03-29T17:56:29.301Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-03-29T17:56:29.302Z]  > git --version # timeout=10
[2021-03-29T17:56:29.319Z]  > git --version # 'git version 2.17.1'
[2021-03-29T17:56:29.319Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-03-29T17:56:29.321Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-03-29T17:56:29.851Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-03-29T17:56:29.854Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-03-29T17:56:29.862Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-03-29T17:56:29.871Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-03-29T17:56:29.871Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-03-29T17:56:29.872Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/pull/1720/head:refs/remotes/origin/PR-1720 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2021-03-29T17:56:30.345Z] Checking out Revision 0e61918b06b87dfe78cf8a4ae2961d9d0f62357b (origin/PR-1720)
[2021-03-29T17:56:30.546Z] Commit message: "Added #1720 to changelog"
[2021-03-29T17:56:30.546Z] First time build. Skipping changelog.
[2021-03-29T17:56:30.563Z]  > git --version # timeout=10
[2021-03-29T17:56:30.572Z]  > git --version # 'git version 2.17.1'
[2021-03-29T17:56:30.592Z] fatal: bad object de5f52a9091c857929a1b04bd53726cce85ab70b
[2021-03-29T17:56:30.338Z]  > git rev-parse origin/PR-1720^{commit} # timeout=10
[2021-03-29T17:56:30.346Z]  > git config core.sparsecheckout # timeout=10
[2021-03-29T17:56:30.353Z]  > git checkout -f 0e61918b06b87dfe78cf8a4ae2961d9d0f62357b # timeout=10
[2021-03-29T17:56:31.832Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-03-29T17:56:32.496Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-03-29T17:56:33.553Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1720/src/github.com/elastic/apm-agent-java/.git
[2021-03-29T17:56:33.698Z] Archiving artifacts
[2021-03-29T17:56:34.644Z] + git rev-parse HEAD
[2021-03-29T17:56:35.016Z] + git rev-parse HEAD
[2021-03-29T17:56:35.351Z] + git rev-parse origin/pr/1720
[2021-03-29T17:56:35.422Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-03-29T17:56:35.746Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-03-29T17:56:36.875Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1720/reviews return 0 elements
[2021-03-29T17:56:36.960Z] [INFO] githubPrCheckApproved: Title: Fix log correlation for log4j2 - User: tobiasstadler - Author Association: FIRST_TIME_CONTRIBUTOR
[2021-03-29T17:56:37.363Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-03-29T17:56:37.363Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-03-29T17:56:37.472Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-03-29T17:56:37.506Z] Sleeping for 5 sec
[2021-03-29T17:56:38.508Z] Stage "Build" skipped due to earlier failure(s)
[2021-03-29T17:56:38.740Z] Stage "Tests" skipped due to earlier failure(s)
[2021-03-29T17:56:38.990Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2021-03-29T17:56:39.009Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2021-03-29T17:56:39.027Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2021-03-29T17:56:39.045Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-03-29T17:56:39.063Z] Stage "Javadoc" skipped due to earlier failure(s)
[2021-03-29T17:56:39.272Z] Failed in branch Unit Tests
[2021-03-29T17:56:39.288Z] Failed in branch Smoke Tests 01
[2021-03-29T17:56:39.302Z] Failed in branch Smoke Tests 02
[2021-03-29T17:56:39.316Z] Failed in branch Benchmarks
[2021-03-29T17:56:39.332Z] Failed in branch Javadoc
[2021-03-29T17:56:39.629Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-03-29T17:56:39.739Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-03-29T17:56:39.791Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-03-29T17:56:40.251Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1720
[2021-03-29T17:56:40.587Z] [INFO] getVaultSecret: Getting secrets
[2021-03-29T17:56:40.824Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-29T17:56:41.849Z] + chmod 755 generate-build-data.sh
[2021-03-29T17:56:41.849Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1720/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1720/runs/1 ABORTED 182116
[2021-03-29T17:56:42.400Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1720/runs/1/steps/?limit=10000 -o steps-info.json
[2021-03-29T17:56:42.951Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1720/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-03-29T17:56:43.201Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-03-29T17:56:44.112Z] Retry 2/3 exited 22, retrying in 2 seconds...


fix: correctly process ct.s array in getCellValue

If a cell's content is composed of parts with different styles, Cell.ct.s can be an array with multiple elements. However, current getCellValue API only extracts the first content part from s array. In order to retrieve full content, values in s array should be concatenated.

thanks for catching this @ErnestThePoet !


go 1.8.7 test

kicking off ci to see if this project runs in go 1.8

It does not!

Hey @lynncyrin I think I found a possible work around / fix:
https://github.com/crewjam/go-xmlsec/issues/16


Save-SMBSecurity errors no matter what passed

Repro:
Save-SMBSecurity
InvalidOperation: You cannot call a method on a null-valued expression.
Save-SMBSecurity: Failed to backup: Backup-SMBSecurity - Failed to backup the SrvsvcConfigInfo SecurityDescriptor: The filename, directory name, or volume label syntax is incorrect. : 'C:\Users\nedpyle\AppData\Local\SMBSecurity\Backup-SrvsvcConfigInfo_SrvsvcConnection_SrvsvcFile_SrvsvcServerDiskEnum_SrvsvcSessionInfo_SrvsvcShareAdminConnect_SrvsvcShareAdminInfo_SrvsvcShareChange_SrvsvcShareConnect_SrvsvcShareFileInfo_SrvsvcSharePrintInfo_SrvsvcStatisticsInfo_SrvsvcTransportEnum_SrvsvcDefaultShareInfo-SMBSec-22082022-1119384208.xml'
====
Save-SMBSecurity -SecurityDescriptor SrvsvcShareFileInfo
Save-SMBSecurity: Failed to backup: Backup-SMBSecurity - Failed to backup the SrvsvcConfigInfo SecurityDescriptor: The filename, directory name, or volume label syntax is incorrect. : 'C:\Users\nedpyle\AppData\Local\SMBSecurity\Backup-SrvsvcConfigInfo_SrvsvcConnection_SrvsvcFile_SrvsvcServerDiskEnum_SrvsvcSessionInfo_SrvsvcShareAdminConnect_SrvsvcShareAdminInfo_SrvsvcShareChange_SrvsvcShareConnect_SrvsvcShareFileInfo_SrvsvcSharePrintInfo_SrvsvcStatisticsInfo_SrvsvcTransportEnum_SrvsvcDefaultShareInfo-SMBSec-22082022-1122476715.xml'
====
I've not found a way to make this cmdlet work.

Save-SMBSecurity writes/saves an SMB Security Descriptor object to the registry. The cmdlet requires a SMBSec.Descriptor object, which is the output from Get-SMBSecurity.
The basic workflow:

$SD = Get-SMBSecurity
Modify SD
Save-SMBSecurity $SD

I'll add some validation and error output to handle incorrect inputs.

The Save cmdlet commits changes to the SMBSecurityDescriptor object to the registry. The backup is automatic and is performed by Backup-SMBSecurity.
This will be addressed by documentation in the SMBSecurity Wiki. Specifically in the Save-SMBSecurity command reference and the How-to guides.


How to integrate this module with the doctrine?

I saw the ScnSocialAuthORM repository but did not understand anything :(
If someone can help me.
Thank u.

You'll have to try harder and post a more specific question. Good luck!


type error

System give a error: the parameter of data_expanded is float type, but it should be int type. So I switch the type to int, system also give a error: the parameter of data_expanded is int type, but it should float type. And I'm fuzzed!

Which version of python are you trying to run this on?


Missing fields added to payment webhooks event payload.

I want to merge this change because it adds missing fields in the payment webhooks events payload.
New fields:

order_channel_slug - channel slug from order
transactions - list of dictionaries with transaction data:

token
is_success
kind
gateway_response
amount

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-7023 Add missing information to the synchronous payment webhook


fix: compile translation on install and update

Problem

translations aren't compiled so they can't work

Solution

compile the translation on install and upgrade

PR Status
I've tested it on prod on a friend server.

[X] Code finished and ready to be reviewed/tested
[X] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme


Add Entities to Mermaid Graph

Possibly with #287 I will be able to move the init outside of thing and then have it connect to it through that
Maybe also have it be a different color like grey to distinguish


Detect Internet connectivity

Every time I restore FastVM in Sydney, I forget two things: the default storage size of the LPAR, and the "nested proxy" configuration.  An automated way to test Internet connectivity from our FastVM Portal Node would help here (at least as a flag to indicate that an attempt to do a cluster build will fail).

Already present in #35 (ironic that it was 53-reversed).  Closing this one.


Refactor current codebase

Currently there are lots of code duplicates and deep indentations (e.g. here and here), that make code significantly harder to read and reuse in the future. We need to create and sort new components accordingly.

:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Show information about a topic

This shows some Information about a Topic, when a User visits it. It uses the same Data as GitHub.
As you can see, this PR adds a lot of data files. They are all taken from github/explore.
I don't know, if the Maintainers really wants this, as it adds a lot of files for such a small feature. Therefore I decided to just code a first version and create a draft PR. This PR is more like a Proof of Concept than finished Code. It was programmed Quick and Dirty. I don't like putting too much effort into something that won't be merged, so I decided to create this and see, if it will be accepted. If yes, I will continue working on it. If no, not much work is lost.
Why I put this into the Database instead of reading the files from disk?
The Data contains aliases. Take for example this from the 3D:
aliases: 3d-printing, 3d-graphics, 3d-modeling, 3d-animation, 3d-cad, 3d-rendering, 3d-models

This means the Data for this Topic is also for all those topics. Instead of creating a lookup table, i decided to put all the Data in the Database to make it easier. That will probably change in the Future.
How to test this?
Go to the Admin Dashboard and run "Update topics". After that, you should see the Information when visiting a Topic.
Screenshot
This is the result of 5 minutes frontend work:

Here is the same on GitHub as comparison
This Code is currently not in a state, where it's ready for Code reviews, so at the Moment please discuss only if you want this or not. You can also discuss about some implementation concepts. If the Maintainers want this feature, I will actually working on this.

It's so big.

It's so big.

Is this a yes or no?

It's so big.

Is this a yes or no?

Whether we have a better solution which will have no so much embedded files?

Personally I would say "no" for embedding these data into Gitea.

Hmm…
I mean, adding it would help a bit.
On the other hand, it is quite some overhead for many instances that don't want it.
The best course of action would probably be offering it as a plugin once we have a plugin system.


How to upload images with direct url?

Image upload simply fails with direct url as input. It doesn't show any error.
This is what I am trying to do:

$image = "http://i.imgur.com/f5v6ath.png"

$url = 'https://api.twitter.com/1.1/statuses/update_with_media.json';
$requestMethod = 'POST';

/** POST fields required by the URL above. See relevant docs as above **/
$postfields = array(
    'status' => "Testing mentions with images",
    'media[]' => "@{$image}"
);

$twitter = new TwitterAPIExchange($settings);
$response = $twitter->buildOauth($url, $requestMethod)
             				  ->setPostfields($postfields)
             				  ->performRequest();
print_r($response);

But it does not work. And It does not show any error.
However it works for local images ($image = "image-file.png").
What am I doing wrong?

update_with_media is Deprecated

Update with media is indeed deprecated. You can use media_upload which was fixed in 1.0.1.

@J7mbo
It doesn't work even with https://upload.twitter.com/1.1/media/upload.json url.
It gives me following error when i try to use direct url:
{"errors":[{"code":38,"message":"media parameter is missing."}]}

From api it needs to be either raw binary or base64 encode which should be taken care by this library. Do this library support this? Otherwise I will file a new bug.

https://twittercommunity.com/t/upload-media-from-a-url-third-party-web-storage/94293
I don't think twitter supports that


issue-3493 - Removing the "batch" section from audit event messages for batch bundle entries

Will create a new pull request since this pull request on top of https://github.com/LinuxForHealth/FHIR/pull/4072, since this pull request has changes similar to https://github.com/LinuxForHealth/FHIR/pull/4072. Closing this pull request.


Fix quotations on RELATED_IMAGE_devworkspace_webhook_server

What does this PR do?
This fixes an issue where when running make deploy RELATED_IMAGE_devworkspace_webhook_server's value would always
stay as quay.io/devfile/devworkspace-controller:next because the sed in https://github.com/devfile/devworkspace-operator/blob/master/Makefile#L98 would fail
What issues does this PR fix or reference?
Is it tested? How?

Set IMG env variable
make deploy
see that the image of the webhook server is the image set in $IMG
Signed-off-by: Josh Pinkney<EMAIL_ADDRESS>

/test v5-images

/test v5-devworkspaces-operator-e2e

/retest


Document benchmark results

Show image of benchmark results (compared to old rtma) in readme.

As @tjmadonna suggested it would be great to do this with github actions so that we always have up-to-date benchmark results.


Add tooltips to resource circles

Changes proposed in this pull request:

Add tooltips over Pods, Deployments, and memory circles
Use either requests.cpu or cpu (the same with memory) - according to k8s wiki, it's the same.
AND ALSO change the port of core from 4200 to 8080.
AND ALSO show label title on hover only if the original one was shortened.

/retest

/retest

/test all

/retest

/test all

/test all


composer update --lock Your requirements could not be resolved to an installable set of packages

Hi there! I have this error running composer update --lock

Any help ? Thanks !

I've the same issue, any solution yet?

duplicate of #470


draft: Swap add_related for add_required in api v1 plugins

This PR swaps the call of .add_related(), which was recently removed, to its replacement function .add_required() .  The variables related_plugin variables used were changed to be required_plugins to match the function swap.
Closes #6301

@pandemicsyn and @edgarrmondragon Sorry I did something really wrong when I committed the requested change.  I tired to add the most recent changes to the branch and I obviously did that wrong. 😞   I believe I have the issue resolved.  Please take a look.  I apologize for the mess.  🙏

@pandemicsyn and @edgarrmondragon Sorry I did something really wrong when I committed the requested change. I tired to add the most recent changes to the branch and I obviously did that wrong. 😞 I believe I have the issue resolved. Please take a look. I apologize for the mess. 🙏

@BuzzCutNorman No worries! Looks like you got it all sorted and looking great.


UC | Support overcast based deployments

This patch is to support overcast based deployments along with current one
(jiocloud.apply_resources). This patch introduce number of environment
variables by which deploy.sh will decide which way to deploy the system.
Here are the environment variables:
provisioner: if this is set to "overcast", overcast will be used for the
provisioning. Default is current way of provisioning (jiocloud.apply resources)
overcast_yaml: this is the patch to overcast.yaml file where it configure
different stacks and each steps in each stacks. Default one is the
.overcast.yaml in current directory.
stack: Name of the stack to be deployed. Default is overcloud
overcast_source_repo: source repo for overcast
overcast_source_branch: source branch for overcast.

please test this


Training 2D VQGAN on UCF 101

Hello, I am attempting to train 2D VQGAN with UCF 101 and do inflation. I call the following function:
python main.py --workdir=../out --config=configs/vqgan2d_ucf101_config.py

I get the following error:
KeyError: 'Unknown dataset (ucf101). Did you import the dataset module explicitly?'

After investigating scenic, I see there is no option for ufc101 in _IMPORT_TABLE. Is there a way to work around this?

have you solved this?


Keyboard refactor

My goal here was to try to read from the port in as few places as possible (as well as trying to handle weird edge cases) in preparation for sending commands / receiving responses. In the process, though, I may have made KeyEvent::read_key_event an even more messy function than before...

It's not exactly something that I directly had in mind, but I'm glad it'll be helpful for that too.

Regarding moving key reading to a separate process, I'm not sure what you meant, but I guess a producer-consumer pattern would fit.
One task (producer) waits for interrupts, fills a ring buffer with every byte it can read, and then goes to sleep again. It does not attempt to interpret read bytes in anyway, just bufferize them.
Another task (consumer) waits for IPC calls, and tries to interpret the content of the buffer as scancodes, and goes to sleep if it's empty.
This would require locks to synchronize the two tasks, which we don't have yet (or I missed them).
Anyway this is irrelevant to the current PR, which is fine ! Thank you, your contribution is really appreciated ! 😊

Needs a rebase on master to fix the build failure.

I wonder if the pattern matching could be simplified with slice patterns nowadays...


更新到0.58.0失败

Microsoft PowerToys version
v.0.56.2
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
升级版本时失败。提示尝试更新此更新时出错

✔ Expected Behavior
正常升级成功
❌ Actual Behavior
升级失败，一直不能更新成功
Other Software
No response

Update failed here.
/bugreport

PowerToysReport_2022-05-09-11-33-54.zip

No error in the report.
Could you please check if you can upgrade it manually?
https://github.com/microsoft/PowerToys/releases/tag/v0.58.0

PowerToysReport_2022-05-12-17-19-47.zip
from version 0.57.2 upgrade 0.58.0 fail

Looks like /dup #18110 Could you check if something there helps?


add error codes 45-60

Thanks, this looks :+1: once CI is fixed up.

Can you please rebase this and your other PR on master now that CI is fixed?

Done and done :) These errors seem related to cluster not starting up properly?

Ya, the process of standing up a cluster on CI to test against is unfortunately a bit flaky. Most of the time I can give it a kick and it will pass the second time.

Thanks!


Please add a readme

It would be helpful if this project had a readme so people know what it is and how to run the code.

I agree. I've been contributing and still have no idea what this is for.

:) it's coming! In the meantime: https://www.gov.uk/government/publications/govwifi/govwifi

Makes sense. Interesting project!

Is there any update to this?
If this really is the cross government solution to wifi, it would be really nice if such a high profile project had a readme describing what it is.
How does this project relate to #alphagov/user.wifi ?

This is on the task list for the current sprint,
Yes.:)
user.wifi was the prototype / alpha version of the project. Created this repo when I took it over and we decided on the name change.

Thanks for the update :)
If user.wifi is no longer in active development, can I suggest it be archived to https://github.com/gds-attic ? With a clear message at the top saying the status.
It's not clear to people viewing these two repos who or why they differ, or which one to look at.

@philandstuff has archived the other project. So now we just need a readme on this one. :)

#85 Fixes this.


Treeview migration | Implemeting the page skeleton

In the existing React-jQuery hybrid treeview component I just copied the HTML template that we used to have in the jQuery app.
In this task we want to implement the page in React. The focus of this step is just the HTML structure, and we will use static values. Later, these values will be fetched based on the database. So,

Under the src/components/treeview/ folder, I've created a new treeview-container.tsx, which is where you'll focus. You should add all your SCSS styles to src/assets/scss/_treeview-app.scss.

All our apps follow the same top-panel, bottom-panel, etc. structure I've added in this component. For example take a look at our recordset app. You aim to implement the parts I've added TODO.

You should start by changing the "content" to show a tree structure similar to what you see on the actual treeview app.

Just use some static data for it.
For some nodes, add the icons that you see in this mode to demonstrate that you can achieve this.
The "camera" icon opens up a modal. You should have at least one node with this feature. We're using react-bootstrap in our apps, and you can see how modals work here.

The next step is "header":

For the dropdown selector, use the src/components/plot/dropdown-select.tsx. You can see how it works on this violin plot.
For the search input use the chaise's SearchInput (import SearchInput from '@isrd-isi-edu/chaise/src/components/search-input'). You can see how it's used in the recordset component. Search functionality should work similarly to the jQuery version.
For buttons, make sure to use chaise-btn chaise-btn-secondary class so they look similar to chaise buttons. The buttons in the current Treeview app are not aligned with the rest of the chaise and we should fix that.

For the side panel, instead of just implementing the content, you should replace it with SplitView like you see on the recordset component.

Eventual goal -> Implement a similar search functionality for the 2d matrix ( every deep tree should have the following search capabilities )

Highlight all matching strings
Scroll to the first occurrence of the match
Expand and show all the matches


Carthage macOS

Adds a macOS framework target and fixes a few build issues when checking out the project with carthage.

Thanks for the PR @DivineDominion. I think the scope of this is a bit too narrow. I am all for adding macOS support, but it doesn't make sense to only be installable via carthage. I would ask that you do the following:

Get the Travis build passing
Add a step to the Travis build to build the macOS target
Update the .podspec to add macOS support

If you can do those things, I'd love to look at getting this merged.

Unrelatedly, @DivineDominion, I would love it if someone who is using Dwifft on macOS would take a look at https://github.com/jflinter/Dwifft/issues/14, maybe it could be you!

Closing due to lack of activity; feel free to reopen if you ever get around to this @DivineDominion


LEAN-4147 LW-FY25-Q3-S1: Viewer Can Edit Figure/Table Captions and Ti…

…tles in Reading Mode

The issue seems to be with the toDOM method in these nodes schema definitions. Both caption and captionTitle nodes have contenteditable: 'true' set in their attributes, which overrides the editable state of the editor. see https://github.com/Atypon-OpenSource/manuscripts-transform/blob/master/src/schema/nodes/caption.ts#L65
Remove the contenteditable: 'true' to allow ProseMirror to manage the editable state based on the editor's configuration (https://github.com/Atypon-OpenSource/manuscripts-body-editor/blob/master/src/configs/ManuscriptsEditor.ts#L85).
I don't see a need for adding custom views here.

@IslamJMomani, done.


BETA: Introduce VM.require

Introduce VM.require
Note, this should be consider a beta feature and the API and the functionality might change.
Fixes: #17
VM.require(src) takes a src for the source code of the module to retrieve from the Social DB and then executes the source code and returns the results.
The src may contain the source version by including the blockHeight. E.g. VM.require("mob.near/widget/Module.Abc@91698491")
Module example:
function Magic(props) {
  return
Magic: {props.children}
;
}

return { Magic };

Widget example:
const { Magic } = VM.require("mob.near/widget/Module.Magic");

return <Magic>Hello World</Magic>;

This is really cool! I like the idea. It's a ways off, but this might make TS support a bit tricky.


local snapshot-controller image should be used for PR jobs

Currently we just apply the raw yaml depending on the snapshotter version.
https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L743
Instead, we should use the locally built image for PR jobs.

/assign @ggriffiths


Split integration tests and make them run on GitHub

Solves #87
Each workflow from IntegrationTest is defined in its own file.
Each expected YAML is defined in resources/integration/expected/$NAME.yaml
If the test fails, the actual YAML is written to resources/integration/actual/$NAME.yaml
Add a new workflow who copy the YAML worklows to a separate repository;
There is a shell script that copy the YAML files to https://github.com/jmfayard/github-actions-integration
TODO @krzema12 : fork my repo https://github.com/jmfayard/github-actions-integration/commits/main and update the shell script ./integration.sh

Note: initially I wanted to copy the YAML files via a GitHub workflow.  Unfortunately it is forbidden by GitHub to push YAML files inside .github/workflows, probably to avoid infinite loops. See https://github.com/EndBug/add-and-commit/issues/342

I simplified my solution which now works with a shell script + a separate repository currently  https://github.com/jmfayard/github-actions-integration

Replaced with something simpler, see the commits in #87.


multi: Remove error string comparison where possible.

There are several places in the code where the type of error is discerned based on the error string. This has the potential to break because an error string is not guaranteed to stay constant (afaik). It would be best to use errors.Is/As in the case of golang and an integer for other languages. Sometimes this is impossible, but for Decred controlled repositories, it should not be a problem. The places that I can see this occurring are as follows:
Maybe impossible to fix:
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/webapi/recovery.go#L28-L35
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/webapi/middleware.go#L28-L35
Probably fixable:
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/webapi/payfee.go#L226-L235
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/background/background.go#L217-L221
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/background/background.go#L535-L539
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/rpc/dcrd.go#L127-L155

I would love to see all of these fixed, please feel free to take it on. To give you some background as to why each of these exist:

The code in recovery.go was inherited from here, added in #255. I have never tried to remove these string comparisons, so it could be possible. Perhaps the strings exist as constants somewhere in std go libs and we can re-use them.
The secure cookie error comes from gorilla/sessions. The same kind of error handling exists in dcrpool (and I think other places, although I can't find any right now). I vaguely remember trying to fix this a very long time ago in dcrstakepool (before you implemented the custom cookie store). Can't recall why I exactly failed, but it's because the lib just returns a plain error with a hard-coded, inline string, which cannot be reused.
I couldn't find a way to use errors.Is/As on the dcrwallet responses.
-1 is a generic error code from dcrd, used for multiple errors, so when we receive it from sendrawtransaction we still need to do the string comparison. Note that in the same block we are able to use errors.As for the -40 error.

One instance of this addressed in #295

I looked into the error check here:
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/background/background.go#L217-L221
and here
https://github.com/decred/vspd/blob/e42b1cad330596c243baf4c391dc40c981f4de90/background/background.go#L217-L221
the error returned comes from:
https://github.com/decred/dcrwallet/blob/9a8688e60b08b68b5952bb717122669cbb3e0989/wallet/wallet.go#L496-L510
there are two possible Invalid error code return, when there is no matching agenda and no matching choice. Both error return an Invalid code 2 and when translated returns a grpc error code 3 (InvalidArgument).
vspd currently use strings.Contain() to check for only one type of error "no agenda with ID" and logs a formatted error specifically for "no agenda with ID".

@jholdstock if my read is right the securecookie: the value is not valid was exported in 2014 in response to a similar issue. However I'm not sure if it's safe to use because the code now says it is deprecated and may be removed in favor of other errors.

Good find, thats some deep digging for somebody who doesn't write code. That deprecation note is pretty much the reason I chose to write the test instead of just import the string.


[Idea] Summarize and synthesize all answers

I love how easy this makes it to use one superprompt and fetches answers from many LLm's
i have this idea of having a pane in godmode where it synthesizes the answers for you to save you time. it could display or highlight what all answers have in common or where there differ
i entered some diagnosis to better understand results from my lower back mri, and so i read all of the answers to see exactly that, what they all had in common to get more assurance
would love to see something like this to quickly review and save me time for answers 🤞🏽
lmk what ya'll think or have any additional suggestions

Cool idea, especially if you could pick which LLM you wanted to have do the analysis and the output was in a table. But I bet the way the UIs work that is going to be next to impossible.

Oh man- i second this idea.
we could pipe outputs to one another.
main llm summarize/analyze the other llms.
We could use a tab or something.


Contact request

Hey, sorry about making an issue but wanted to let you know i have you an email regarding UpdateMe.
An acknowledgement would be appreciated.

I have also contacted him last week. I think he's dead or something

He has made contributions in private repositorys though

HELLO

Closing this issue.
Please note that my personal email and contacts are not the appropriate channels for reporting bugs or suggesting features for UpdateMe. All UpdateMe-related discussions should happen here through GitHub issues to maintain transparency and keep all project-related communications in one place.
I won't be responding to UpdateMe-related emails. Please use GitHub issues for any app-related communications.


isReply helper function

I am still pretty new at this...
Is this what you were looking for?

https://github.com/spences10/twitter-bot-bootstrap/blob/fc307eea5faac36c00a4e96617bd64df37332b0f/src/api/retweet.js#L31
Would that be an if statement inside of your try block then?

I think if we get rid of the try and use the isReply function in an if  it should do the trick, you think?

Closes #120

Ok, looks great, you tested this on your own bot I presume @nikkilr88? 🙏 👍

@spences10 Yes, my bot uses the isReply function, and so far everything is running smoothly. It filters out retweets and quoted tweets.

Brilliant, thank you ❤

@spences10 Thank you! This was my first PR that actually involved code. It was a great learning experience.

Thank you for the contribution 👍
I'll get the contributor's file updated now, please feel free to make any suggestions + improvements you think may help other people trying this out.
I have found that this is a nice entry level project for people to try
Many thanks 👌


Fix #721, https://github.com/mozilla/thimble.mozilla.org/issues/2005: bramble.less

This fixes our load ordering for LESS/CSS, such that our overrides get added in the proper order (i.e., last).  It also continues to have us use a single file for fewer requests.
NOTE: all Brackets CSS/LESS should still go in bramble_overrides.less

@flukeout can you review please?

Hey @humphd pulled this branch then ran npm run build and tested both /src and /dist looks like /dist is not getting the overrides correctly, you can tell by the width of the resize handle. It should be wider as in the /src version.

Did I test it correctly, any steps I missed?

Disregard comment, didnt have my dev tools open so it was cached. Works as expected.


Image category

Hello
I just want to know if I can select the type of image, like: animals, movies...

Hi,
This is not currently possible to do, or planned functionality. Duplicate of #81


Ensure the cursorchanged event is also triggered on mouseover

Fix #64

Coverage decreased (-0.02%) to 74.965% when pulling 656be5287b81320eaa10246dc030fd909ab49141 on cursorchanged-fired-on-hover into d409a1697344f90763fb94723a069f7a9906fe3d on develop.


UI settings - gateways umlaut issues

if a management contains a German umlaut, this is not shown in gateway overview table but when editing it suddenly re-appears.

ignore this


Remove float::utils module

Moves all of the previous functionality onto the F32 newtype.

Codecov Report

Merging #77 (1b30096) into main (13e1d31) will increase coverage by 0.54%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   59.97%   60.51%   +0.54%
==========================================
  Files          39       38       -1
  Lines         822      813       -9
==========================================
- Hits          493      492       -1
+ Misses        329      321       -8

Impacted Files
Coverage Δ

src/f32ext.rs
0.00% <0.00%> (ø)

src/float/copysign.rs
100.00% <ø> (ø)

src/float.rs
55.81% <76.19%> (+5.81%)
:arrow_up:

src/float/exp.rs
93.93% <100.00%> (ø)

src/float/fract.rs
87.50% <100.00%> (ø)

src/float/powf.rs
100.00% <100.00%> (ø)

src/float/powi.rs
100.00% <100.00%> (ø)

src/float/trunc.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e1d31...1b30096. Read the comment docs.


Fbx Support

Could add the feature to extract 3D models in fbx?
In which everything included in it comes (eg vertex color, uv)

If you're going to be exporting models, I'd just suggest using assetstudio. uabe had mesh support to obj but that's it, anything more than that (even mesh to fbx) is quite a bit of work and isn't really necessary right now given there is a good alternative.

asset studio works very bad for what i want, uabe works well (only is missing vertex color that i need).

I'm not sure why assetstudio would work very bad since it has all the features you suggested already. Uabe afaik only supports mesh export and no materials. If all you want is stuff like uvs and vertex color, it wouldn't be that hard. It'll be on the list of things to do but don't expect it anytime soon (there's still lots of base uabe things that need to be finished)

The asset studio when exporting causes models to be in the wrong places (maybe 90%), and in some models it duplicates them.
UABE was the best so far,only  just really needs the vertex color (and the uv of course).
I will wait then, thanks ;)

@Minileandro you can try utinyripper u might have to edit the type of material later but it should work for what u want.

I know, and I have it in utiny version, but it made most of the models combined, etc...


[Design++] Implement consistent error story for directives.

Basics of what's in this PR

Enforce whitespace inbetween directive tokens
Re-write malformed directives into MalformedDirectiveIRNodes via a MalformedDirectiveIRPass
Raise directive errors to the IR layer.

Goals for extensible directive error handling
Tried to encompass 3 primary goals when coming up with a design for our directive error story.
Consistency
When we  encounter a malformed token when parsing an extensible directive we don't consume the token; instead, we bail out and log an appropriate error that's raised to the DirectiveIRNode. Therefore, a user will never have to deal with a malformed directive token state unless they're purposefully consuming MalformedDirectiveIRNodes.
Default simple approach for malformed directives
If a user writes a malformed directive an extensible directive author will not see it represented as a DirectiveIRNode as long as their pass operates after the MalformedDirectiveIRPass. This means for malformed directives Razor will provide IntelliSense until they have fully satisfied all tokens of a directive, at which point the directive will be valid and will make its way over to extensible directive IR pass code.
Since a user never sees malformed directives, in the case of a block directive we flow the body of the malformed block directive to the execute method so that all contents continue to get IntelliSense/coloring.
Basically, I made it so extensible directive code is not called until its structure is 100% while maintaining the current editing experience; this should help us avoid VS explosions and make extensible directive IR consumption code simple.
Opt-in customizable approach for malformed directive
If a user does not like how we handle malformed directives they can write an IR pass that consumes MalformedDirectiveIRNodes. They can have it log additional errors, modify code gen... basically whatever they want. A great example of when you'd want to do this is if you wish your malformed directive to still impact code gen to provide more verbose/specific errors (think @model where TModel was restricted with a where clause).

#1173
@ajaybhargavb @rynowak

I like the approach here, this is very thoughtful and has clear goals and principles in mind.

@rynowak this good?


Support OAuth login to console

created two new auth endpoints. one endpoint to initiate the sso login, and one endpoint as the oauth callback

when logging in to a cnsi endpoint with the same uaa server as the console, use the current user's console uaa token. (no need to get two tokens for same credentials)

new SSO_REDIRECT_URL env var to use for outh redirect

Additionally, I fixed an issue with the user-info page to conform with UAA /Users API (https://github.com/cloudfoundry/uaa/blob/master/docs/UAA-APIs.rst#query-for-information-get-users)

Description

I added to main.go 2 endpoints to initiate the sso login against the configured UAA server and to handle the callback with the authorization code. The callback point is handled by the same function that handles the original Basic login. EXCEPT this endpoint is a GET when we receive the oauth authorization code, and a POST otherwise (Basic login). The flow to get a UAA token is essentially the same, except we use grant_type=authorization_code instead of grant_type=password.

In my use case, I want the console to auto register and auto connect to the CF endpoint it's pushed to. Previously, the auto connect code in the login hook triggered a second call to get a UAA token using the same username and password provided to login to the console. This doesn't work with OAuth flow because the authorization code we receive is one valid for one call to get a token. To solve this, I just save the token used to login to the console as cnsi token for the auto-registered cnsi.

Need this for the redirect

I noticed the user-info was broken because the /Users/user-guid endpoint on the UAA server returns all the users instead of one user. I fixed this.

Limitations
These changes only support SSO login to the console and auto-connect to a CF endpoint when doing auto registering of CF endpoint. There's no support to SSO login to a specific endpoint from the endpoints dashboard, but this can be implemented easily now.
Motivation and Context

Support OAuth login

How Has This Been Tested?

Tested the oauth login flow locally and by pushing the console to a CF environment and checking that it auto-registers and auto-connects properly

See number 4.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Docs update
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

Thanks for submitting this PR! Before we kick the tires though we need to appease cfdreddbot. I noticed your company is set as IBM, who should have a corporate CLA with CF. Could you make public any IBM organisation that you're a member of (see here)? We can then close + reopen to try again.
Additionally, we normally request that commits are signed as per (as per here). I think in this case though we can let that slide.
Thanks again, and if you need any pointers on above please just ping me here or in chat.

@richard-cox ok looks like i'm good now

One thing I need to add is a way to redirect the console to the sso login page if not logged in and an environment variable is set (SSO=true or something). Not sure where the best place to put that check is.

@andrewghobrial Hey - I started to take a look at this - I can see you had a question about wiring this into the UI - I can help you with this.
Before I go much further, what is the state of the PR? I don't see that it will work as is.

@andrewghobrial I've created a branch oauth-login, see:
https://github.com/cloudfoundry-incubator/stratos/tree/oauth-login
I've done the minimal work (no error handling) to wire this into the front-end.
I've fixed a few issues in the back-end to the point where I can login to the UAA via the oauth flow.

It does work completely with my UAA server that can handle oauth sso. I just have to initiate the login by going to that first endpoint directly. Why do you think it might not work?

On May 14, 2018, at 8:44 AM, Neil MacDougall<EMAIL_ADDRESS>wrote:
@andrewghobrial I've created a branch oauth-login, see:
https://github.com/cloudfoundry-incubator/stratos/tree/oauth-login
I've done the minimal work (no error handling) to wire this into the front-end.
I've fixed a few issues in the back-end to the point where I can login to the UAA via the oauth flow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@nwmac can you push what you have when you get a chance?

temporarily closing this because realized I need legal permission from IBM to release back

@andrewghobrial Okay - Hope you can re-open soon.
Changes are now on the oauth branch for you to look at.
Quite a few changes to get the flow working from the UI and redirecting appropriately. One of the query params was redirect_url instead of redirect_uri - if you were testing manually without front end integration then this may not have surfaced.

Hi @andrewghobrial - I spent some time today taking a look over the backend components related to OAuth, and made some minor tidy-ups as I went along (work in progress here: https://github.com/andrewghobrial/stratos/compare/master...govau:oauth).
Before I go any further I have some questions:

Is this based on v1 or v2? It seems the last common ancestor with v2-master is from January this year. Is a rebase on current v2-master planned? (I could be reading it wrong, as I'm not super familiar with this project). Would you like help doing such a rebase if needed?

This set of code looks very similar to what the 18F console did (on which we spent quite some time making some improvements to the OAuth parts). One of the first things we did there was implement support for storing the OAuth tokens (which was pretty much the only thing in our sessions) in signed and encrypted session cookies (using the Gorilla libraries). By doing so we were able to remove the need for a separate storage layer for sessions (ie the code that currently switches between Postgres, MySQL or SQLite). Would there be interest in doing the same here?

@richard-cox I'm not sure what's up with Dreddbot, but Andrew has signed a CLA, and can be treated as such.  Looking into the problem now.

@nwmac I removed some unnecessary changes from this PR and made it use a bool SSOLogin to enable/disable sso. All the tests pass except this one Expected false to be true. components/app-core/frontend/test/unit/view/util/upgrade.service.spec.js:110:46.
It's related to the UI changes you made to add the button.
I think other than that everything looks good.

We believe that DreddBot should acknowledge that everyone has signed the CLA in this PR. It would be great if someone could close and re-open this PR so that we can validate our fix.

Closing/Opening for DreddBot

@nwmac updated with changes suggested

Can we close this - addressed in V2.


package name

The document uses ClusSim with two s, but the repo name is with only one s.

So we're using CluSim right? @ajgates42


monorepo: rename 'controller' dir to 'internal/runtime'

We want to use the top-level dir 'controller' for new controller code
and go module. The existing 'controller' code is a shared set of
listeners for watching COSI resources. Since this code is shared by the
controller and sidecar, it needs to be available to both. It doesn't
need to be made available to other projects, so the Golang 'internal'
dir can be used.
Merge after #89

/lgtm
/approve


Register extension with did core

Like so:

https://w3c.github.io/did-core-registries/#GpgVerificationKey2020

It is here: https://www.w3.org/TR/did-spec-registries/#ecdsasecp256k1recoverymethod2020
but still could be added to https://w3c-ccg.github.io/security-vocab/

@clehner would you mind doing a PR to security vocab for this?

@OR13 Sure

Opened: https://github.com/w3c-ccg/security-vocab/pull/95

Could list in https://w3c-ccg.github.io/vc-extension-registry/#proof-methods


ADMIN - Reference rejection

In gitlab by @A-Lawrence on Aug 20, 2016, 19:30
Allow references to be rejected for 2 stock reasons:

Reference incomplete
Referee unsuitable

This should trigger an email to the applicant.

In gitlab by @A-Lawrence on Aug 20, 2016, 19:35
Removed ~98471 label

In gitlab by @A-Lawrence on Aug 21, 2016, 14:51
Removed ~98471 label

In gitlab by @A-Lawrence on Aug 21, 2016, 16:09
mentioned in commit 6338c999efb50ef64810e4c571b73ca3173651a8


Tests: Fix flaky testJobLogWithEnabledAndDisabledStats

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@506c867). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6951   +/-   ##
=========================================
  Coverage          ?   77.76%
  Complexity        ?    12315
=========================================
  Files             ?     1536
  Lines             ?    49752
  Branches          ?     5982
=========================================
  Hits              ?    38692
  Misses            ?     8071
  Partials          ?     2989

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506c867...63fe701. Read the comment docs.