Who is using Codeowners Validator？

Who is using Codeowners Validator？
I want to sincerely thank everyone who constantly keeps on using and supporting Codeowners Validator! 🚀
This project is developed 100% in my spare time, but I try to keep Codeowners Validator actively developed and maintained.
Reasoning behind this issue

Find out how many people out there are using this tool to ensure that the time spent on this project is valuable.
Learn more about the practical usage and be able to prioritize the next step of development. This will impact the v1.0 release. Also, I will be able to note which checks are mostly used and which not.
Be able to ping users whenever a new version of Codeowners Validator will be released.

Call for action
Add a comment to this issue including the following information:

GitHub organization
Link to the repositories where codeowners-validator is used. It doesn't necessarily need to be CI.

GitHub organization: Microsoft: https://github.com/microsoft
Repositories:

FluidFramework

GitHub organization: Node.js https://github.com/nodejs
Repositories:

node
node-auto-test

GitHub organization: .NET Platform https://github.com/dotnet
Repositories:

Silk.NET

GitHub organization: iTwin Platform https://github.com/iTwin
Repositories:

itwinjs-core
viewer-components-react

GitHub organization: Magma https://github.com/magma
Repositories:

magma

GitHub organization:  GloTarAn https://github.com/glotaran
Repositories:

pyglotaran

GitHub organization: Square https://github.com/square
Repositories:
-workflow-kotlin

GitHub organization: gofunky https://github.com/gofunky
Repositories:

update-codeowners - used as example.

GitHub organization:  Open Ag Technology and Systems Group https://github.com/oats-center
Repositories:

isoblue-avena

GitHub organization: island.is https://github.com/island-is
Repositories:

island.is

GitHub organization:  Code42 Software https://github.com/code42
Repositories:

dir2consul
[axiomatic](https://github.com/code42/axiomatic/blob/534af2b632bdbd139fad88b97dd4aadac6407fd7/.github/workflows/validate-codeowners.yml#L1-L270

Repositories:

GitHub organization: Oppia https://github.com/oppia
Repositories:

oppia-android

GitHub organization: Open Ag Data Alliance https://github.com/OADA
Repositories:

server

GitHub profile:  Vadim https://github.com/rfprod
Repositories:

flutter_starter
nx-ng-starter
mono

GitHub profile:  omrisk https://github.com/omrisk
Repositories:

clickhouse-playground

We use your great tool in Moveworks on git-push as a pre-commit hook.
It's in a private repo. But feel free to ping me.
On a practical note, it would be great to have proper integration with the above pre-commit hook project. That would allow us to manage the version and pass arguments in a consistent fashion with other checks.

We're also looking into using this in a private repo. The main use case we're going after is making sure all files in a test directory have an owner. To do this we may need an additional variable added to only search certain directory for CODEOWNERS, for which I can try putting up a PR.
Also re: pre-commit hook integration that's something that would be beneficial as well!

We use it at Grafana Labs for our private IaC repository. Lots of our CODEOWNERS file is generated so this tool is great to make sure we didn't generate junk!

I'm looking into this tool for use in a pre-commit hook, CI and manual use.


Selective SSG

[closes #373 ]

Simplified the approach a bit to only render markets that have an end date greater that one month ago

fast builds again!


Garage door opener.

Can you add it? with ability to choose number of pins to control gate - one or two. with open\close sensor and garage door eye sensor?

Is the WindowCovering type do the job ? If no, you must provide me more information about you door opener and how you plan to plugged it

In most cases Garage Door opener has one dry contact for control. Start moving -> Stop -> Moving back. For one garage door typically using two GPIO pins - one for sensor, other for operate.
Here - https://github.com/benlamonica/homebridge-rasppi-gpio-garagedoor is very good example. But your plugin is really amazing and more useful, more universal and if you able to add garage door opener - it will cover any device to control with dry contacts. Why i ask about garage opener instead of window covering? In home app better see exact type of device isn't? For garage door better control i think following:
configurable pin parameters:
DoorSwitchPin - for openers which is control by one contact
DoorOpenPin and DoorClosePin - if opener controlled by two contact
inverted - sometime it really need on all type devices.
Also garage openers has an ir-eye sensor for enable auto close function. It also works as sensor with  dry contact NO/NC

I've made a first version in the last release. Not fully featured but could be a good start to test.

Thanks a lot! Window Covering and sensors works fine!

@dubocr can you tell accessory type so I can test it? I check code it is not added yet?

Oups, my SD card is corrupted and I lost my changes before commit 👎 but the NPM release 0.1.5 is OK.
You can try with this doc : https://www.npmjs.com/package/homebridge-gpio-device#garagedooropener

It always sad when data lost :( Try following:
{
"accessory": "GPIODevice",
"name": "Garage",
"type": "GarageDoorOpener",
"pins": [
21,
22
],
"inverted": true,
"sensorPin": 29
}
Maybe need to add something like "shiftDuration". Or maybe it's occurs that "sensorPin" is not working? Find that! i check catalog sys/class/gpio and find that plugin init wrong sensorpin number i choose 29 but there two pins in catalog 21 and 25 ? but must be 21,22 and 29. Testing shows - open/close pins works greate, sensor pin not. After restart chek gpio catalog - only 21 pin init. Sensor still not working.
Here example from repo i told(bold for parameters which is very useful):
{
"accessory": "RaspPiGPIOGarageDoor",
"name": "Garage Door",
"doorSwitchPin": 23,
"doorSwitchPressTimeInMs": 1000,
"doorSwitchValue": 1,
"closedDoorSensorPin": 24,
"closedDoorSensorValue": 1,
"openDoorSensorPin": 25,
"openDoorSensorValue": 1,
"doorPollInMs": 4000,
"doorOpensInSeconds": 14
}

Thanks for update documentation! Is my comments useful?

It works! Don't know why - for tests i use pin 29 (GPIO 29) and it didn't work. But now - very well! Only what is need - time to close/open. Thanks a lot!

Would be great to use this for my Gate, at the moment I have 2 "Switches", open gate and close gate, when I use the GarageDoor setting it just gets stuck on Closing.
What options do I have to drive GPIO wPi Pin 2= Open Gate and wPi Pin 3 = Close Gate? Without sensors to verify closure.

@coshy81 I use this for garage and gate
https://github.com/benlamonica/homebridge-rasppi-gpio-garagedoor

@coshy81 I use this for garage and gate
https://github.com/benlamonica/homebridge-rasppi-gpio-garagedoor

this plugin is work with single button controllers. that plugin is more universal
@coshy81 why you dont use sensor? is very good to know door state.

@Partizan7676 the benlamonica Homebridge can do as many button you want.
Example:
“
"accessories": [
{
"accessory": "RaspPiGPIOGarageDoor",
"name": “Gate",
"doorSwitchPin": 21,
"doorSwitchPressTimeInMs": 1000,
"doorSwitchValue": 1,
"closedDoorSensorPin": 18,
"closedDoorSensorValue": 1,
"openDoorSensorPin": 17,
"openDoorSensorValue": 1,
"doorPollInMs": 4000,
"doorOpensInSeconds": 14
}, {
"accessory": "RaspPiGPIOGarageDoor",
"name": "Garage Door",
"doorSwitchPin": 23,
"doorSwitchPressTimeInMs": 1000,
"doorSwitchValue": 1,
"closedDoorSensorPin": 24,
"closedDoorSensorValue": 1,
"openDoorSensorPin": 25,
"openDoorSensorValue": 1,
"doorPollInMs": 4000,
"doorOpensInSeconds": 14
}
],
“

@toshibochan buttons or sensors? example you told - is for one doorswitch pin and two sensor(one for opened state and second for closed state). we talk about separate buttons for open and close command

@Partizan7676 in my case I have one Gate and one Garage door. The gate use one pin for switch and one pin for sensor. Same for the garage, one pin for the switch and one for sensor.

@toshibochan bingo! one switch pin. ONE! but we talk here about devices with TWO buttons for operate. NOT SENSORS, BUTTONS.

close sensor pin added ("closeSensorPin") and closing time can be set with "shiftDuration" in seconds.
sensorPin must be replaced by "openSensorPin".


Merge upstream into master

This updates bcc to the latest changes from upstream.
Testing
ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4217/

@sebroy Do you happen to know what's the name of the test suite that includes analytics?

Yeah, @pzakha it's analytics_positive, which is part of os_tests.

Queued analytics_positive test: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/62589/consoleFull

@prakashsurya I've disabled the publish.yml workflow by moving it to a different directory.
@sebroy Could you take another look at this?


Tools for extracting message store stats

We specifically want to get at the unique address counts, but breakdowns of various other stats by time period would also be useful and can probably be implemented together more efficiently than separately.

:+1: from me but what's the reasoning behind total & unique? Does total reflect total number of messages received?
Is there value in being able to retrieve the uniques rather than just the len() ?

what's the reasoning behind total & unique? Does total reflect total number of messages received?

Yes. We need to walk the whole index anyway to get the uniques, so we may as well count the messages while we're at it. It costs us nothing and will avoid looking up the total separately for things that needs both.

Is there value in being able to retrieve the uniques rather than just the len() ?

Not that I can think of. If you need to do something with that, you're probably better off exporting the messages and processing them yourself.

Left some small comments. Looks good to me.
Regarding building up big sets in RAM: If this becomes a problem in practice, perhaps we can swap out the set for something like https://github.com/svpcom/hyperloglog (or even our own implementation if we don't like any of the existing ones) so I don't think we necessarily let that comment hold up this PR.
For publishing this metrics in Vumi Go, I'm thinking of something like a simple Celery task that goes through active conversations once a day and calculates metrics for that day.

For publishing this metrics in Vumi Go, I'm thinking of something like a simple Celery task that goes through active conversations once a day and calculates metrics for that day.

I'd be much happier doing this on-demand, both because it's more flexible (in that one can select specific time ranges) and because we avoid doing a bunch of unnecessary work.
A daily job that walks indexes for every active conversation doesn't scale very with either the number of conversations or the number of messages in the conversations. (We can look at finding a way of doing this if the majority of account owners really need low-latency access to this information on a daily basis, but I'd be surprised if that were the case.)

Regarding building up big sets in RAM: If this becomes a problem in practice, perhaps we can swap out the set for something like https://github.com/svpcom/hyperloglog (or even our own implementation if we don't like any of the existing ones) so I don't think we necessarily let that comment hold up this PR.

Agreed, but there isn't an easy way to do this both accurately and cheaply as far as I'm aware. (That's another reason I'd prefer to do it on-demand rather than daily.)

:+1:


exiflooter: init at 1.0.0

Description of changes
Added exifLooter Tool finds geolocation on all image urls and directories also integrates with OpenStreetMap
https://github.com/aydinnyunus/exiflooter
Related to #81418

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Successor of https://github.com/NixOS/nixpkgs/pull/279360

Result of nixpkgs-review pr 279366 run on x86_64-linux 1

1 package built:

exiflooter

Result of nixpkgs-review pr 279366 run on x86_64-linux 1

1 package built:

exiflooter


Decide whether this is the name we want

https://www.namecheap.com/domains/registration/results.aspx?domain=discoverwhat.rocks

It is.


move has_metric

refactoring

@sed-i
I believe that it is unrelated itest failure. test looks to be unstable
how can we update the test to make it working ?

@sed-i I believe that it is unrelated itest failure. test looks to be unstable
how can we update the test to make it working ?

unit-1 of prom has an outdated url: fqdn instead of ingress:
"[http://prometheus-1.prometheus-endpoints.test-external-url-imkm.svc.cluster.local:80/metrics](http://prometheus-1.prometheus-endpoints.test-external-url-imkm.svc.cluster.local/metrics)"

(unit-0 is had the correct ingress url).
This might be due to https://github.com/canonical/traefik-k8s-operator/pull/107

This might be due to canonical/traefik-k8s-operator#107

@sed-i
if I got it right, nothing we can do in this repo for now, right?


Refactor network.PodCacheInterface marshalling

What this PR does / why we need it:
The interaction between virt-handler and virt-launcher with regards to the Pod interface configuration and state is quite confusing. virt-handler uses a json-marshaled filed placed in  /var/run/kubevirt-private/network-info-cache/<uid>/nic-0 to communicate network configuration of the primary interface to virt-launcher. This PR does not change that. It only moves the code handling this closer together, under kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/network.
While at it, the PR removes what I believe is an unnecessarily in-memory cache and the global locks related to it.
Special notes for your reviewer:
@vatsalparekh, @AlonaKaplan, please consider if the suggested code is more readable as I believe it to be.
Release note:
NONE

suggested code would reintroduce https://bugzilla.redhat.com/show_bug.cgi?id=1686208

I won't reintroduce the bug. It will just always read from the file which is not efficient.

suggested code would reintroduce https://bugzilla.redhat.com/show_bug.cgi?id=1686208

I won't reintroduce the bug. It will just always read from the file which is not efficient.

/hold
suggested code would reintroduce https://bugzilla.redhat.com/show_bug.cgi?id=1686208

Don't think this reintroduces the bug, but the cache seems more optimal way go with
We've tests verifying the after migration IP change
And it seems passing for this PR
https://github.com/kubevirt/kubevirt/blob/master/tests/migration_test.go#L465

/hold
suggested code would reintroduce https://bugzilla.redhat.com/show_bug.cgi?id=1686208

Don't think this reintroduces the bug, but the cache seems more optimal way go with
We've tests verifying the after migration IP change
And it seems passing for this PR
https://github.com/kubevirt/kubevirt/blob/master/tests/migration_test.go#L465

/retest
/lgtm

/lgtm
/approve

/retest

/hold cancel


Bug 1926984: Avoid requeueing an expired Report

Update the Report handler and avoid requeueing a Report that is
reporting an expired status. Before, this would result in the
reporting-operator hot looping as this Report custom resource would
continue to get queued up.
Instead, if we're encountering a Report that
has reached its expiration date, then we should avoid processing it in
the Report handler function and let the call site determine how to
process that Report further in the next cycle.

Note: I still need to create a BZ for this and link that BZ in the PR title but I'm going to tackle that next week.

Note: I still need to create a BZ for this and link that BZ in the PR title but I'm going to tackle that next week.

Accidently added that lgtm label. Need to play around with this more.
/hold

/bugzilla refresh

/cherrypick release-4.7

Need to land this before landing the InstallPlan fixes (known OLM bug) required to reduce the # of e2e flakes.
/override ci/prow/metering-e2e-aws

/hold cancel

    metering_upgrade_test.go:102:
        	Error Trace:	assert.go:112
        	            				metering_upgrade_test.go:102
        	            				main_test.go:445
        	Error:      	Received unexpected error:
        	            	failed to wait for the reporting-operator deployment to report a successful upgrade: failed to wait for the reporting-operator Deployment to finish updating in the metering-hdfs-olm-upgrade namespace: timed out waiting for the condition
        	Test:       	TestMeteringUpgrades/HDFS-OLM-Upgrade
        	Messages:   	expected there would be no error
...
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2021-02-09T21:48:06Z"
    message: '0/7 nodes are available: 3 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn''t tolerate, 4 Insufficient cpu.'
    reason: Unschedulable
    status: "False"
    type: PodScheduled
  phase: Pending
  qosClass: Burstable

/retest

/retest

The upgrade test has passed a couple of times now but the flakes still persist. Going to try and tackle those flakes outside of this PR.
/override ci/prow/metering-upgrade-aws

/retest

/test all

/retest

/test all


issue with ebi submission

We have a blind failure in qiita where submissions to EBI will not be successful cause we only accept https://github.com/biocore/qiita/blob/master/qiita_ware/ebi.py#L374 so if the template has Ilumina or IlluMina it will not work. What will be the best solution? Note that to have the studies that we want got to EBI without a problem we could update the DB (so it is ILLUMINA) or the code (so it accepts any casing).

A simple str.upper() would do it, but having the database be consistent would be better.

Update to make compatible with EBI terminology?
On Feb 24, 2015, at 6:20 PM, Antonio Gonzalez <notifications<EMAIL_ADDRESS>wrote:
We have a blind failure in qiita where submissions to EBI will not be successful cause we only accept https://github.com/biocore/qiita/blob/master/qiita_ware/ebi.py#L374 so if the template has Ilumina or IlluMina it will not work. What will be the best solution? Note that to have the studies that we want got to EBI without a problem we could update the DB (so it is ILLUMINA) or the code (so it accepts any casing).
—
Reply to this email directly or view it on GitHubhttps://github.com/biocore/qiita/issues/883.

Had to really look into this issue so we can solve and it turns out
that the code is case insensitive, which is fine, but the real issue
is that Illumina is really 'Illumina ': it has a space. We need to
remove white spaces from values.

IMHO, this should be checked on template upload. So, strip all values upon upload. Agree/disagree?

Agree.


"input/output error" on copying data to /private/[myusername] with cp

After snooping around the issues here, I suspect this may be related to #1961, but I'm not positive, so I'll include it here.
Just for fun, I decided to copy a mixtape from a friend to my /keybase/private/schalliol/ instead of to my Dropbox.
The operation takes forever, as in about 10 minutes. Yeah, I know performance isn't prio in the alpha, but I also got a bunch of errors. Here's my stderr:
➜  $  cp -r Music /keybase/private/schalliol
cp: /keybase/private/schalliol/Music/02 Super Mom.mp3: Input/output error
cp: /keybase/private/schalliol/Music/03 Hey Boy.mp3: Input/output error
cp: /keybase/private/schalliol/Music/04 (I Believe in) Travellin' Light.mp3: Input/output error
cp: /keybase/private/schalliol/Music/05 Down In The Arkansas.mp3: Input/output error
cp: /keybase/private/schalliol/Music/06 Zorbing.mp3: fchmod failed: Input/output error
cp: /keybase/private/schalliol/Music/06 Zorbing.mp3: Input/output error
cp: /keybase/private/schalliol/Music/06 Zorbing.mp3: Input/output error
cp: /keybase/private/schalliol/Music/07 Time Away.mp3: Input/output error
cp: /keybase/private/schalliol/Music/1-09 Turning My Heartbeat Up.mp3: Input/output error
cp: /keybase/private/schalliol/Music/1-13 Seven Days Too Long.mp3: fchmod failed: Input/output error
cp: /keybase/private/schalliol/Music/10 Wildest Moments.mp3: Input/output error
cp: /keybase/private/schalliol/Music/11 - Hermanos Calatrava - Space Oddity.mp3: Input/output error
cp: /keybase/private/schalliol/Music/12 The Magic Position.mp3: Input/output error
cp: /keybase/private/schalliol/Music/15 I Wanna Be Where You Are.mp3: Input/output error

The files appear to have copied partially, not fully. Here's an ls -l on the origin directory:
total 179464
-rwxr-xr-x@ 1 Gavin  staff   2012060 Aug 19  2013 001 Gavin's Recorded Message to you, Anna.mp3
-rwxr-xr-x@ 1 Gavin  staff   8396897 Jul 10  2013 02 Super Mom.mp3
-rwxr-xr-x@ 1 Gavin  staff   5076569 Jul 10  2013 03 Hey Boy.mp3
-rwxr-xr-x@ 1 Gavin  staff   3907927 Jul 10  2013 04 (I Believe in) Travellin' Light.mp3
-rwxr-xr-x@ 1 Gavin  staff   5268591 Jul 10  2013 05 Down In The Arkansas.mp3
-rwxr-xr-x@ 1 Gavin  staff   6279700 Jul 10  2013 06 Zorbing.mp3
-rwxr-xr-x@ 1 Gavin  staff   5414204 Jul 10  2013 07 Time Away.mp3
-rwxr-xr-x@ 1 Gavin  staff   3626588 Jul 10  2013 08 Come Wind Come Rain.mp3
-rwxr-xr-x@ 1 Gavin  staff   3867047 Jul 10  2013 1-09 Turning My Heartbeat Up.mp3
-rwxr-xr-x@ 1 Gavin  staff   3975233 Jul 10  2013 1-13 Seven Days Too Long.mp3
-rwxr-xr-x@ 1 Gavin  staff   7848023 Jul 10  2013 10 Wildest Moments.mp3
-rwxr-xr-x@ 1 Gavin  staff  10464997 Jul 10  2013 11 - Hermanos Calatrava - Space Oddity.mp3
-rwxr-xr-x@ 1 Gavin  staff   7507896 Jul 10  2013 12 The Magic Position.mp3
-rwxr-xr-x@ 1 Gavin  staff   7756208 Jul 10  2013 14 Watch The Sunrise.mp3
-rwxr-xr-x@ 1 Gavin  staff   5788478 Jul 10  2013 15 I Wanna Be Where You Are.mp3
-rwxr-xr-x@ 1 Gavin  staff   4655214 Jul 10  2013 16 My Old Friend.mp3

And here's the same ls -l done on the target directory /keybase/private/schalliol/Music:
total 106208
-rwxr-xr-x  1 root  wheel  2012060 Feb 21 18:10 001 Gavin's Recorded Message to you, Anna.mp3
-rwxr-xr-x  1 root  wheel  5242880 Feb 21 18:10 02 Super Mom.mp3
-rwxr-xr-x  1 root  wheel  5076569 Feb 21 18:13 03 Hey Boy.mp3
-rwxr-xr-x  1 root  wheel  1048576 Feb 21 18:14 06 Zorbing.mp3
-rwxr-xr-x  1 root  wheel  2097152 Feb 21 18:14 07 Time Away.mp3
-rwxr-xr-x  1 root  wheel  3626588 Feb 21 18:15 08 Come Wind Come Rain.mp3
-rwxr-xr-x  1 root  wheel  3145728 Feb 21 18:16 1-09 Turning My Heartbeat Up.mp3
-rwxr-xr-x  1 root  wheel  3975233 Feb 21 18:17 1-13 Seven Days Too Long.mp3
-rwxr-xr-x  1 root  wheel  6291456 Feb 21 18:18 10 Wildest Moments.mp3
-rwxr-xr-x  1 root  wheel  6291456 Feb 21 18:19 11 - Hermanos Calatrava - Space Oddity.mp3
-rwxr-xr-x  1 root  wheel  1048576 Feb 21 18:20 12 The Magic Position.mp3
-rwxr-xr-x  1 root  wheel  7756208 Feb 21 18:21 14 Watch The Sunrise.mp3
-rwxr-xr-x  1 root  wheel  2097152 Feb 21 18:22 15 I Wanna Be Where You Are.mp3
-rwxr-xr-x  1 root  wheel  4655214 Feb 21 18:23 16 My Old Friend.mp3

Difference in overall file size:
➜ /keybase/private/schalliol/Music $ du -hs
 52M	.

➜ /Dropbox/Music $ du -hs
 88M	.

Let me know if I can provide any more info. Cheers!
my log id: 51be44ff918f68acc8b7c81c

Thanks for the thorough snooping!  I think you're right, looks like another instance of #1961.  Basically, the network was slow, and Keybase does a poor job of buffering the writes, causing some of the writes to fail while writing to the network.  Once a write call fails, the whole copy operation gives up part way through the file.  If you really want those file in keybase, using rsync might work, to only copy the bits that haven't yet been saved?
Sorry for the crappy experience!  We definitely need to make this better.  We have some ideas, and I hope we have some bandwidth to work on them soon.

No worries! Just an experiment (as is pretty much everything I'm doing on kbfs). Thanks for your work :)
As you mentioned that it's a duplicate, I'll go ahead and close this.


Rethink async/isgenerator and alike.

right now, we store a kind to tell us wether something is builtins, generator...
https://github.com/jupyter/papyri/blob/45c158d0e8011fe0bb23e6a5eb4a4b6e4e521245/papyri/signature.py#L90-L99C13
I'm not sure this is the best way as a builtin can be a coroutine function ... etc. It might be a good idea to rethink what we should store and how.

Expanding a bit on this, to both try to get things out of my head, and take the habit of making longer description.
Some of this information is likely necessary for rendering (like do you show def vs async def), but can be used for other things, like there is a search field, we could have a is:generator filter for example, or warn that there is no Yield section in the docs.
In general we should try to keep information when we can, so that the frontend can decide what an how to render it.

Do we have any cases of this? I could only find examples of "functions" throughout all the toml examples and the tests.

In papyri itself, I don't think there are any in the tests. We should add those.


something error with /mbplanner_node/FreeFrustParams load

Hi, first thanks for you open source code. And  I am testing the proposed launch file mbplanner_m100_sim.launch with melodic branch, and countered the following problem.Could you tell me how to deal with this situation? Thanks a lot
Loading: /mbplanner_node/FreeFrustumParams
namespace_name:/mbplanner_node/FreeFrustumParams
[ERROR][File: /home/tina1994/CM_PHD_CODE/src/mbplanner_ws/src/exploration/mbplanner_ros/planner_common/src/params.cpp] [Line: 235]
Param is not set: /mbplanner_node/FreeFrustumParams/sensor_list
Loading: /mbplanner_node/BoundedSpaceParams/Local
[WARN][File: /home/tina1994/CM_PHD_CODE/src/mbplanner_ws/src/exploration/mbplanner_ros/planner_common/src/params.cpp] [Line: 431]
Param is not set: /global_planner_node/BoundedSpaceParams/Global/min_extension. Setting to default value: {0,0,0}
[WARN][File: /home/tina1994/CM_PHD_CODE/src/mbplanner_ws/src/exploration/mbplanner_ros/planner_common/src/params.cpp] [Line: 442]
Param is not set: /global_planner_node/BoundedSpaceParams/Global/max_extension. Setting to default value: {0,0,0}

Hello @Tina1994 ,
Thank you for pointing this out. The error message shown is because the FreeFrustumParams not set in the config file. These params are not used at the moment so not having them in the config file won't cause any problem. They are not included in the default config file provided for the same reason. However, as this can cause confusion, I have changed the message displayed from error to warning when the params are not set. The PR #7 solves this problem.
Please let me know if you have any further questions.
Thank you,
Mihir


Please add refresh button and add zone button

ISSUE TYPE

Improvement Request

COMPONENT NAME

Image (Template)

As for your second point @xuanyuanaosheng , there should be a copy button if you have the rights for that. It would copy the template to another zone.
The first point seems a good addition.

@DaanHoogland  OK，Thanks

np @xuanyuanaosheng Let's change the title to add refresh button to zone tab in template details view, ok?
As a workaround, I can only think of leave the template view and re-select the template-zone-tab. (life is ugly and beautiful at the same time;)

@xuanyuanaosheng
do you expect to have a button to redownload the template for specific zone(s) ?

Could be a good improvement.


CMake: CMP0077 is implied by cmake_minimum_required(VERSION 3.16)

Can you please provide more description as to why this is necessary?

I realize that I overlooked the actual nature of this line: It does have an effect on the project commands in the subdirs, in particular for ls-qpack. Without that line, CMP0077 would might be unset after subdir project, regardless of the top-level choice.
(I tested this in a separate project now. CMake documentation didn't seem entirely clear.)
Nevertheless it might become obsolete in the future when the subprojects raise their minimum required version. And with modern versions of CMake, version lower than 3.10 are causing deprecation warnings.


Will enhance the home page

Home page is quite monochromatic. Text is hiding by the background color.I would like to work on this for you.
Please assign this issue to me under gssoc and hacktoberfest.

I would like to work on this issue pls assign me this @vishanurag


Illegal instruction (core dumped)

I just compile the example and run it with my bot token and got this
<EMAIL_ADDRESS>./dscord-examples xxxxxxxxxxxx
2016-11-28T21:17:22.446:client.d:requestJSON:91 [GET] [200] https://discordapp.com/api/gateway:
2016-11-28T21:17:22.447:client.d:start:113 Starting connection to Gateway WebSocket (wss://gateway.discord.gg/?v=6&encoding=json)
2016-11-28T21:17:23.146:client.d:run:348 Sending Identify Payload
2016-11-28T21:17:23.147:client.d:run:355 Connected to Gateway
Illegal instruction (core dumped)

I'm using DUB version 1.0.0, built on Jun 20 2016

Hey @moechofe sorry for the delayed response. Can you attempt to grab a backtrace using GDB, or perhaps even a core dump?

oups, sorry @b1naryth1ef I didn't think about it and deleted my test and switch to an other language.

Don't know if it's the same issue but it's the same behavior:
write(1, "2017-01-12T08:51:29.907:client.d"..., 622017-01-12T08:51:29.907:client.d:run:355 Connected to Gateway
) = 62
futex(0x39eb215680, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
--- SIGILL {si_signo=SIGILL, si_code=ILL_ILLOPN, si_addr=0x7ca92b} ---
+++ killed by SIGILL (core dumped) +++
Illegal instruction

Included core dump:
core.tar.gz

Fast got removed fully in #17 which should more or less resolve the IE you where seeing above. Feel free to reopen if you hit something else.


Typo

@gtworek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Possible regex capture issue with special characters

Some additional discussion/context on #138.  The following line caused unit test failures when used with capturing regex due to the presence of the (escaped) \r:
'262|2023-04-21T23:24:06.0630000-04:00|en|00000051|_rsv_35827_-1_1_0_0_S13095D61_E13095D61|Further testing is required.�����,\\r���)������ ��, assist me with this evaluation.|38151741aad7fe51',

This issue was worked around for unit testing in #139, but we should confirm that this is not a persistent issue in regex capturing that will cause errors/fail to capture during actual execution.  Assigning this to myself since I hope to have time to take a look at it next week, but completely fine if someone else wants to look at it in the meantime.

This issue is caused by bad base data. The data in the actual raw log line is unicode characters (specific to FFXIV unicode space) and should have been added with '\uXXXX' instead of raw copy/pasted. I unfortunately don't have the original raw log lines to properly add them in here.
The parse logic should be handling unicode properly to begin with since it handles JP/CN/KR characters fine.

Hmm, looks like the raw unicode data is actually there.
$ xxd resources/example_log_lines.ts| less
...
000057b0: 317c 4675 7274 6865 7220 7465 7374 696e  1|Further testin
000057c0: 6720 6973 2072 6571 7569 7265 642e efbf  g is required...
000057d0: bdef bfbd efbf bdef bfbd efbf bd2c 5c5c  .............,\\
000057e0: 72ef bfbd efbf bdef bfbd 29ef bfbd efbf  r.........).....
000057f0: bdef bfbd efbf bdef bfbd efbf bd20 efbf  ............. ..
00005800: bdef bfbd 2c20 6173 7369 7374 206d 6520  ...., assist me

Just need to properly encode the data I guess? If there's still an issue with parsing after that, then it's an actual bug.


For oracle raw query sql for next sequence value return Boolean

When you execute
data.raw("select SEQ_ID.nextval from dual").first().get(0);
You get boolean.
Can we specify return type?

Thanks for reporting this fix is available in 1.1.1


Godot consumes an absurd amount of CPU and memory when assigning a big texture to a model

Godot 3.0.2
Windows 10 64 bits
nVidia 940M
The story:
When working on a terrain engine, I get to work with big textures. I tried with 4097x4097 maps, which was working great, with 500Mo of RAM occupied by the images which I keep in memory for edition (but ingame could easily discard them).
But then, I saved my terrain. That means, four PNGs of 4097x4097 pixels got written in the project, which Godot immediately reimported.
That import almost went fine... but then my mouse stopped responding and audio buffers went to starve. My PC froze for a few minutes and stayed quite slow for a few more, until Godot finally stops freezing.
I noticed memory consumptions had hit the ceiling, with the editor occupying more than 5 gigabytes during that load step...
The repro:

Open an empty Godot project, and keep your system's memory monitor in view
Drop this texture in the project: http://zylannprods.fr/dl/godot/big_textures/normal.png
Notice the editor takes some time to import, but memory stays relatively stable
Now create a MeshInstance, with a CubeMesh in it
Create a new SpatialMaterial within that instance
Assign the big texture to the albedo property: notice Godot goes through a second loading step. Watch out the memory monitor:

It will go down only once that step completes.

Expected:
Is there any way to optimize memory usage here?
In my use case, this may happen everytime I save my terrain data, since those images get modified on disk...
On a side note, I believe the fact textures get auto-reimported from their usage is going to be really dreadful for my use case, since I also plan to experiment computing/editing those maps using 2D rendertarget viewports... whose output are used in 3D :O

This still happens in Godot 3.1 beta8. I am importing 4K textures and they take very long to import.
But when I start using then in materials, more loading happens and my computer is brough to a crawl, even sound is forced to stop for a moment, while the CPU is a typical desktop Ryzen and RAM is whopping 16 Gb.

Still happens in 3.2 alpha1. I opened a project that was using a 2048x2048 color texture, it took 2 minutes to import it while starving all cores on a Ryzen 5, music I was listening stopped etc.

Can anyone still reproduce this bug in Godot 3.2.4 beta or any later release?
I tried the steps, but I didn't notice the usage to be extremely high.

Did you disable ETC2 importing in the Project Settings?

Last comments didn't get any reply so closing for inactivity. Comment if you can still reproduce in 4.0.


dockerTools.buildImageWithNixDb does not produce reproducible images

Describe the bug
When using dockerTools.buildImageWithNixDb with different stores, the produced image is not reproducible, because the generated /nix/var/nix/db/db.sqlite contains timestamps.
Steps To Reproduce
Given the following flake.nix
{
  outputs =
    { nixpkgs, ... }:
    let
      dockerTools = nixpkgs.legacyPackages.x86_64-linux.dockerTools;
    in
    {
      image = dockerTools.buildImageWithNixDb {
        name = "foo";
        copyToRoot = [ dockerTools.binSh ];
      };
    };
}

run the following steps
$ nix build ".#image" --store /tmp/first
$ sha256sum /tmp/first/"$(readlink -f result)"
b64fedfaada9436648468328bebf0e0df921922844e3969292f0c545a7947005  /tmp/first//nix/store/3ngf7kjqhf332ky5isys423rq8a6ykd6-docker-image-foo.tar.gz
$ nix build ".#image" --store /tmp/second
$ sha256sum /tmp/second/"$(readlink -f result)"
9e1c1cc28b4df658ea1487d939680803c8b2b8d218c3d21c5f0549bd1876d733  /tmp/second//nix/store/3ngf7kjqhf332ky5isys423rq8a6ykd6-docker-image-foo.tar.gz

Expected behavior
The produced image should be bit-by-bit identical.
Additional context
The issue is that https://github.com/NixOS/nixpkgs/blob/9511a7b219df1f8d8f5c2a58c4870fde169fe397/pkgs/build-support/docker/default.nix#L64 will load different timestamps for different nix stores (the situtation of having different nix stores is relevant when building within ephemeral docker containers for example). I think the code responsible for the differing timestamps is https://github.com/NixOS/nix/blob/60936f28e51bad1cf0a038ebfa24ce9bb97845a9/src/libstore/local-store.cc#L678
I don't know if the proper fix is to adjust nix to allow reading from SOURCE_DATE_EPOCH or something similar in this case, or to change dockerTools.buildImageWithNixDb to reset the timestamps instead.
The following workaround makes the image reproducible for me (which could be upstreamed into dockerTools.buildImageWithNixDb)
{
  outputs =
    { nixpkgs, ... }:
    let
      dockerTools = nixpkgs.legacyPackages.x86_64-linux.dockerTools;
      buildPackages = nixpkgs.legacyPackages.x86_64-linux.buildPackages;
    in
    {
      reproducibleImage = dockerTools.buildImageWithNixDb {
        name = "foo";
        copyToRoot = [ dockerTools.binSh ];
        extraCommands = ''
          ${buildPackages.sqlite}/bin/sqlite3 nix/var/nix/db/db.sqlite "UPDATE ValidPaths SET registrationTime = ''${SOURCE_DATE_EPOCH}"
        '';
      };
    };
}

gives
$ nix build ".#reproducibleImage" --store /tmp/first
$ sha256sum /tmp/first/"$(readlink -f result)"
dd7b3db5ae2a3d68abbac0636f0ba30fb07ae030537c4093a8358632fdf848c0  /tmp/first//nix/store/idf3gbvzpblws9dgpza3rmpjmrz17hrw-docker-image-foo.tar.gz
$ nix build ".#reproducibleImage" --store /tmp/second
$ sha256sum /tmp/second/"$(readlink -f result)"
dd7b3db5ae2a3d68abbac0636f0ba30fb07ae030537c4093a8358632fdf848c0  /tmp/second//nix/store/idf3gbvzpblws9dgpza3rmpjmrz17hrw-docker-image-foo.tar.gz

Notify maintainers

@roberth

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.77, NixOS, 24.05 (Uakari), 24.05.20240214.f7e8132`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `""`
 - nixpkgs: `/etc/nixpkgs/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

Nix itself does not pass registration times to the closure-info derivation, so that part of Nix is in the clear.
It's the Nix provided by Nixpkgs that runs inside the sandbox that's at fault here.
(nix-repl> :b runCommand "outs" { __structuredAttrs = true; exportReferencesGraph = {"closure" = ["/nix/store/63l345l7dgcfz789w1y93j1540czafqh-hello-2.12.1" ]; }; rootPaths = [ hello ]; } ''cp $NIX_ATTRS_JSON_FILE $out'')

I don't know if the proper fix is to adjust nix to allow reading from SOURCE_DATE_EPOCH or something similar in this case, or to change dockerTools.buildImageWithNixDb to reset the timestamps instead.

This seems like a good idea, as long as this behavior is not applied to untrusted users (in a daemon setup), but untrusted users probably can't run an import anyway. Need to make sure though.
The workaround with the sqlite command can be added to dockerTools, as it will be relevant for quite some time. Could you open a PR?


Does it support .Net 4.6.2?

I tried to install the package but got an error saying .net framework 4.6.2 is not supported.

Sorry @JesseXia  the library targets netstandard1.6 and at the moment from this link, only .net framework 4.6.1 seems to implement netstandard1.6. So no, .Net Framework 4.6.2 is not supported. Blame Microsoft. Moreover this is a ASP.NET Core specific library as it depends on the new view components, therefore making it incompatible with ASP.NET MVC 5 or less.

Thanks Nabin for your reply.
This does make sense. I'm working on web project based on .Net Core but
targeting the .Net Framework 4.6.2.
It's confusing me haha. But anyway, thanks so much! I like this package!
On Thu, 15 Jun 2017 at 13:08 Nabin Karki Thapa<EMAIL_ADDRESS>wrote:

Sorry @JesseXia https://github.com/jessexia the library targets
netstandard1.6 and at the moment from this link
https://github.com/dotnet/standard/blob/master/docs/versions.md, only
.net framework 4.6.1 seems to implement netstandard1.6. So no, .Net
Framework 4.6.2 is not supported. Blame Microsoft. Moreover this is a
ASP.NET Core specific library as it depends on the new view components,
therefore making it incompatible with ASP.NET MVC 5 or less.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nabinked/NToastNotify/issues/10#issuecomment-308600139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJh8wEWsu0X7CfTNID171UmYPWhZ-uKNks5sEIQIgaJpZM4N6mZ5
.

--
Best regard,
Jesse

No worries. I know the versions with .net core are very confusing.


Game over screen.

Need to show the list of found words on the game over screen

can I have this assigned to me?

You certainly can

#20
Just made a PR
Please Check it out whenever free :D

Fantastic, I've merged that in. Thanks 👍


Is it still maintained at all?

Maintainers, What can we do to help?

sorry guys, I have totally dropped the ball on this repo and haven't been looking at issues for the last 6 months.  I'm just now getting around to merging in some of the rails 5 stuff.  I have handed it off to a few other maintainers over the years, but none of them are actively maintaining it either.  I'm willing to give admin access to this and access to the rubygems account for anyone that is interested in maintaining.

@johnmcaliley,  you should probably update readme, to let people know

@johnmcaliley I can certainly be a gem "gardener", wouldn't be able to add much of raw dev resources but can certain help out.

@johnmcaliley bump.

@rposborne what does bump mean ?

@AndreiMotinga it's English slang, commonly used to trigger a new notification on a topic that still requires attention.   In this case, attempting to get @johnmcaliley attention, showing that I am here and willing to help out.
(also thanks for asking)

@rposborne, thanks for the clarification. good to know ;)

I've taken over the role as maintainer but I'd love a sidekick. Please let me know if you're interested :)


gravitybridge chain upgrade

proposal: https://www.mintscan.io/gravity-bridge/proposals/200
eta: UTC: Nov 15th 2023, 17:05:15

Please add "next_version_name": to "antares", naming the next version "apollo". I'd also suggest adding a dummy blank "next_version_name": at the end of "apollo"


Fully move to .net core 3.0 exclusive support

.Net core 3.0 now has support for Winforms and WPF so the UI projects can be ported. A single project platform will be easier to maintain.

For clarification: UI apps will only run on windows at this point but the server build can be consolidated into a single solution file.

The UI only works on Windows, so it's not worth it, you would also loose the configuration ability for your monster machine .NET currently offers.
Maintainence shouldn't be an issue as long as you don't accidentally change the dotnetcore project files again (they don't need to be touched). Additionally I need to stay with dotnetcore 2.2 for now if you want me to be involved, v3 still has serious portability issues.

Best practice would not be to move to new version for new versions sake. Instead it should be configured to compile with >=2.2 so that it will build with 2.2 and 3.0 both. For GUI: Microsoft won't build cross platform GUI, if you want a GUI that works on dotnetcore in general and also runs on .NET consider using Avalonia.

There is no rush for this. The goal was to move to a single solution file to avoid issues with messed up project files. Updating to the latest version of paket may have resolved the issues with the project file corruption but not certain at this stage. If you need .net core v2.2 then we can stay on this for now.

I see, makes sense. Should also work with a >=2.2 config though hm. To avoid corruption of config file you can also update .gitignore to exclude the dotnetcore files, this way they won't change in the repo.

Can't use .gitignore in this case as the project files need to be updated when files are added


Fixes #38 - Windows installer sets PATH "type"

When updating the PATH environment variable, the installer needs to
write REG_EXPAND_SZ type registry keys when persisting an updated
PATH variable so that variables inside the PATH value get
transparently expanded when applications access the PATH variable.
This supports the use case where various directories are stored
in independent *_HOME variables (e.g. JAVA_HOME), and then those
variables are used to build the PATH variable (e.g.
PATH=%JAVA_HOME%\bin;)

Great, thank you for this! This should be out with the next platform release :)


Fix warnings in public headers

Somewhere along the way, we started identifying our public header files to CMake as SYSTEM. This is the right-ish thing to do for libraries that consume cesium-native via submodule / add_directory, so that a project stricter warnings won't flag a bunch of warnings in cesium-native headers. But it means that legitimate warnings in the header files, even when building cesium-native, are ignored. I noticed this because apparently some old versions of CMake don't treat SYSTEM headers specially, and the build had a whole bunch of warnings.
So we should:

Tweak our CMake config so that the headers are SYSTEM outside cesium-native, but non-system within it.
Fix the warnings

This also needs to be fixed so that clang-tidy can report errors for cesium-native's header files.

@lilleyse have you already done some work on this? I've run into a couple of problems lately where cesium-native was building fine, but when we tried to use it Unreal there were new (legitimate) warnings that required us to go back and fix cesium-native. So I'd like to address this one, but don't want to duplicate work that you might have already done.

I've introduced a solution for this in the clang-tidy PR #1004 using the PROJECT_IS_TOP_LEVEL CMake variable to decide whether headers should be marked SYSTEM or not. The PR fixes the resulting warnings for most headers, but the CesiumGltf headers still need to be addressed.


Redshift ODBC DirectQuery error

I've built a custom connector based on the Redshift ODBC sample to. It works fine when I load data through import mode. It connects to Redshift through the ODBC driver, sees the database and loads the schema and specific tables with their data - everything works.
But as soon as I try to load the exact same data (and others) through DirectQuery I get an error. When selecting DirectQuery it still views the database hierarchy and all it's tables, I can select a table to load, but as soon it tries to load it shows the error "We cannot convert the value null to type Table.". This happens with all tables, while they all work in import mode.
I did not change anything in the sample ODBC connector except for switching to the 64bit driver, since the x86 one does not work in combination with my version of Power BI.

There was a regression in Power BI Desktop that causes Direct Query enabled connectors that will cause that error if the HideNativeQuery option is set to false. I just checked the Redshift sample, and it appears this is set to true. Until this issue is fixed (which might not be for awhile), it is recommended to keep this option set to true.


chore: adding assertion of channel capabilities migration

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #2140 (0bd27e9) into main (9019adf) will decrease coverage by 0.01%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
- Coverage   79.48%   79.47%   -0.02%
==========================================
  Files         173      174       +1
  Lines       12011    12029      +18
==========================================
+ Hits         9547     9560      +13
- Misses       2042     2045       +3
- Partials      422      424       +2

Impacted Files
Coverage Δ

modules/apps/27-interchain-accounts/module.go
51.57% <60.00%> (-0.07%)
:arrow_down:

...nterchain-accounts/controller/keeper/migrations.go
78.57% <78.57%> (ø)

I believe we also need to call SetMiddlewareEnabled() for all active channels we iterate over in this migration handler.
Any existing channels will need this set to continue to operate with the underlying app callbacks.

I believe we also need to call SetMiddlewareEnabled() for all active channels we iterate over in this migration handler. Any existing channels will need this set to continue to operate with the underlying app callbacks.

Makes sense to me. And if the chain removes the underlying app entirely, those middleware enabled checks won't be reached since the underlyingApp != nil check comes first


Pass delimiter through when using cli

Prior to this request whenever an edgelist without tab spaces between the node ids was used the cli would return
IndexError: list index out of range
All I did was add the delimiter argument and pass it through the various functions.
I also rewrote the logic for calling the read_npz function so that unused args (such as directed and delimiter) are not passed through.
I added a line in the README.md to note the added functionality.

Hi @justinlboyer, thanks for the PR! This is a known issue, but I didn't bother adding this flexibility due to my own use cases, which always have the edge list files as tsvs. But this is great! I've merged your changes to master.

Hi @justinlboyer, thanks for the PR! This is a known issue, but I didn't bother adding this flexibility due to my own use cases, which always have the edge list files as tsvs. But this is great! I've merged your changes to master.

Hey @RemyLau you're welcome.  I totally get it, glad I could help :)


Git diffs are displayed offset when PR review are displayed inline

Extension version: v0.27.1
VSCode Version: v1.57.1
OS: Win 20H1

Steps to Reproduce:

Create a PR

Add a comment somewhere to file A

Change the file locally in VS Code

Open the git diff of the file:

As you can see, everything after the first comment is vertically shifted because of the comment. Instead, left to the comment there should be a gap. See also how GitHub & GitLab are solving this in their online views.
Expected behavior: The selected lines in the left and the right pane should be displayed next to each other.

@rebornix I think this is an issue with how the comments widget and the diff view interact. Is that correct, or is there some way for me to control this as a consumer of the comments API?

I wonder if it's related to word wrap, @LinqLover can you try turn off word wrap and see if you see the same issue?

Unfortunately, I cannot reproduce this issue at the moment, but I always have turned on word-wrap in my git diffs. I will report back if I am able to reproduce the issue again ...

Closing this until I or someone else is able to reproduce. I use this extension pretty seldom, though ...


Body is not forwarded

What version of Hono are you using?
4.5.6
What runtime/platform is your app running on?
Bun
What steps can reproduce the bug?
I'm listening to a specific POST route and want to forward the request to another service. However, the body doesn't get forwarded. I found this issue in which forwarding should be possible using fetch. The request itself gets forwarded, but the body in the receiving handler is empty.
Forwarding
import type { Context } from 'hono';

export async function newUserHandler(context: Context) {
    return fetch('http://auth-service/users', context.req.raw);
}

Auth service handler
import type { Context } from 'hono';
import type { ErrorDto } from '../dtos/error-dto';
import { StatusCodes } from 'http-status-codes';
import type { AnyObject, InferType, Maybe, ObjectSchema, ValidationError } from 'yup';
import { createError } from '../helpers/error-helper';

export function httpHandler<T extends ObjectSchema<Maybe<AnyObject>>>(schema: T, handler: (object: InferType<T>, context: Context) => any) {
    return async (context: Context) => {
        let validatedObject: InferType<T>;
        let error: ErrorDto | undefined;

        if (!schema) {
            error = createError('No schema has been provided');
        } else if (!handler) {
            error = createError('No handler has been provided');
        } else {
            /* Make sure a valid JSON has been received. */
            try {
                const object = await context.req.json();

                try {
                    validatedObject = await schema.validate(object);
                } catch (validationError) {
                    error = {
                        messages: (validationError as ValidationError).errors,
                    } as ErrorDto;
                };
            } catch (e) {
                error = createError(e!.toString());
            }
        }
        return error ? context.json(error, StatusCodes.INTERNAL_SERVER_ERROR) : handler(validatedObject!, context);
    }
}

Output
auth-service         | ---------->

What is the expected behavior?
Maybe I misunderstood the mentioned approach but from what I understand the whole request should be forwarded, including the body.
What do you see instead?
No response
Additional information
I also checked if the forwarding services receives the body and there I can see it.
No response

Hi @monstermichl
It's too complicated to reproduce the behavior on my machine. Can you simplify it, describe the instructions, and create a GitHub repository that includes this?

Hey @yusukebe
thanks for your response. Yeah, understandable. Actually, in the complicated part only the await context.req.json() part is relevant, everything else can be ignored. So all you'd need to do is create a handler that forwards the request (probably to another service/URL) and a handler there that parses the body. Maybe something like this:
import type { Context } from 'hono';

export async function forwardHandler(context: Context) {
    return fetch('http://another-service', context.req.raw);
}

import type { Context } from 'hono';

export async function receivingHandler(context: Context) {
    return await context.req.json();
}

However, honestly I think this is a Bun, not a Hono problem as I commented here. Unfortunately, I haven't received an answer yet.

Understood. This is not a Hono-side matter. We can reproduce the bug without Hono:
forward.ts:
export default {
  fetch: async (req: Request) => {
    return await fetch('http://localhost:3000', req)
  }
}

receive.ts:
export default {
  fetch: async (req: Request) => {
    return Response.json(await req.json())
  }
}

bun run receive.ts
bun run --port 3001 forward.ts

curl 'http://localhost:3001/' --data '{ "foo":"bar"}'

Perfect, thanks for your time. I thought so too after opening the issue.


Update best-practices-cdn.md

for @tysonn to accept

Hi @deneha, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

CLA not require, MSFT vendor


Does this work with marketplace?

Well we want to build a website in which we are the a third party marketplace provider. Buyers buy goods from other sellers, and we collect about 2-3% transaction fee each time an invoice is paid. I wonder, does this amazon login-and-pay SDK handles this marketplace scenario? I do notice that there are both a merchant ID and a seller ID, so I guess these two can be different?

Yes, the SDK incorporates Marketplace scenario. The merchant ID and Seller ID are the same.
Account requirements for Marketplace scenario

Your Login and Pay With Amazon account in seller central should be marked as Marketplace. For this please provide me your Merchant ID. I will get it marked as Marketplace accordingly

In API calls such as Authorize and Capture there is a field called 'provider_credit_details'	 => array()
Authorize API call -> https://github.com/amzn/login-and-pay-with-amazon-sdk-php/blob/master/PayWithAmazon/Client.php#L672
Capture API call -> https://github.com/amzn/login-and-pay-with-amazon-sdk-php/blob/master/PayWithAmazon/Client.php#L735
You can send this input in either of these API calls.
Case 1: If the 'provider_credit_details' is sent in Authorize API call
Authorize API call has a parameter called as capture_now which is a boolean value that takes true or false. This has to be set to true if 'provider_credit_details' is passed
Case 2: If the 'provider_credit_details' is sent in Capture API call
Here you can simply pass the 'provider_credit_details'  array
How to pass the Provider credit details
Following is an example Capture API call (assuming the Client class object is instantiated according to the read-me -> https://github.com/amzn/login-and-pay-with-amazon-sdk-php/blob/master/README.md)
$requestParameters = array();
// Amazon Authorization ID will be provided in the response of the Authorize API call
$requestParameters['amazon_authorization_id'] = 'Amazon Authorization ID';
// Here merchant_id value will be your marketplace on-boarded merchant's Merchant ID
$requestParameters['merchant_id'] = 'ONBOARDED_MERCHANTID';
$requestParameters['capture_amount'] = 'capture amount'; // example '100'
$providerCredit  =  array();
$providerDetailsarray = array('provider_id' => 'YOUR_MERCHANT_ID',
'credit_amount' => 'CREDIT_AMOUNT', // transaction fee example '10'
'currency_code' => 'USD');
array_push($providerCredit,$providerDetailsarray);
$requestParameters['currency_code'] = 'USD';
$requestParameters['capture_reference_id'] = "some unique string";
$requestParameters['seller_capture_note'] = 'sample capture note';
$requestParameters['provider_credit_details'] = $providerCredit;
$requestParameters['mws_auth_token'] = 'MWS Auth Token of your on-boarded merchant';
$response = $client->Capture($requestParameters);
print_r($response->toXml());
print_r($response->toJson());
print_r($response->toArray());
Other inputs needed

MWS auth token of the onboarded merchant
Merchant ID of the onboarded merchant.

Once your account is marked as a Marketplace you will get a view in Seller Central where in you can generate a exclusive link that you can provide to your merchants who want to be onboarded to your marketplace. While generating this link you should provide a return URL to your domain where they would be redirected to once they complete the process.
At the final step of the process  they will be redirected to the return URL . In this return URL there will be MWS auth token and Merchant ID as query/url parameters. you will have a script in this page that will grab these parameters and save it in your DB.


Fix #758: Handle empty body with gzipped encoding

Fix for #758

+1
I had the same issue workaround. But those changes were not accepted ):

@kxepal what do you mean by not accepted?
@fafhrd91 rejected your PR to aiohttp about the change?
I cannot remember any issue for the problem, sorry.

Got it

See also #154

Reread the backlog. "not accepted" was a bad wording, sorry, didn't remember all the details. Asked for a bit more work in addition to addressing current issue - yes, but for those cases were not in my list. Ironically, now we're almost in sync (I didn't took 304 response into account) (;
Anyway, it's good that this problem finally get fixed (: \o/

@fafhrd91 do you agree with my patch?

+1

Done


[B16] Bringing the game to 0 FPS using spellbats

I'm not entirely sure whether the Blank Greater Focus is implemented or not as i have yet to find a way to unlock it, however this is possible on smaller scales with multiple casts.
Alright, so i have managed to bring the game to less than 1 fps using this spell:

Basically what it does is attempt to lag out my game to the highest degree possible and does so in a less than spectacular fashion with just one cast, according to the spell and my math (I may have gotten the math wrong), It should only be spawning 729 bats but when the game lags out i get upwards of around 3450 entities that are solely spellbats. This only really happens to this degree i think because spellbats can trigger their own mines, however it can still happen fairly easily if cast in a closed off space. Here are some pictures of the f3 menu before and after the bat apocalypse hopefully they are helpful somewhat

Perhaps adding a cap on the number of bats in an area or from a spell could stop this?

i did something similar with only projectiles and scatter, but my game just straight up crashed and i had to uninstall and re-install thaumcraft to be able to play again ._.
so, i agree that something should probably be done...
also, nice graph, seeing it makes me happy

9 forks that create 9 forks that create nine forks... etc.
guess you have to expect that the game cant handle that.
maybe a forced despawn when at, dunno, 5 fps for spellbats would be the solution...

Bravo sir, bravo.  :)

What I'm going to do is limit it so that scatter can only be used once in a focus. It might be a big nerf, but it will prevent situations like this.


(mini.ai) Allow to match whitespaces for argument textobject

Can be enabled via:
custom_textobjects = {
a = require('mini.ai').gen_spec.argument({ match_whitespaces = true }),
}

[ ] I have read CONTRIBUTING.md
[ ] I have read CODE_OF_CONDUCT.md

Thanks for this PR! This looks very promising.
I'll look through it for possibly unexpected pitfalls and get back here.

Hi, @tobiwild!
I have finally found time and motivation to work on this.
The exact changes in your PR couldn't be merged because they break some important features (like allow matching while cursor is on the first and last whitespaces but don't include them in textobject). But your approach of refactoring to handle separator spans instead of points gave me a push to implement support of full Lua patterns as separator instead of single characters.
Changes are in ai-separator-span branch. It has soft deprecation of separators (plural) option in favor of separator (singluar) one. You use case of matching whitespace should be covered with this setup:
local ai = require('mini.ai')
ai.setup({
  custom_textobjects = {
    a = ai.gen_spec.argument({ separator = '%s*,%s*' }),
  },
})

Could you, please, test it on your end? I plan to merge it latest by the end of the week. Thanks!

@echasnovski I was now able to test it and I like it. This is even more flexible and doesn't require some special match_whitespaces option. Thanks for the change, I guess this PR can now be closed :)

@echasnovski I was now able to test it and I like it. This is even more flexible and doesn't require some special match_whitespaces option. Thanks for the change, I guess this PR can now be closed :)

Thanks for the feedback!
I'll wait till tomorrow in case an unexpected issues arise. They probably won't, but just in case :)

This is now in main.
Thanks for the implementation idea and push to do it!


Localhost refused to connect

After setting the port to a specific integer and making sure the port was open on my router the would be terminal window shows a broken page icon that says Localhost refused to connect.

I'm having the same issue. Are you using it within a docker container?

You can modify the source code simply running ttyd server. it will work or you dont need use this library if you're running ttyd server as a process on linux server you can directly render the iframe on the streamlit.
directly render without this module:- (you must run ttyd server)
ttyd_url = "http://localhost:7681"  # Replace with the actual URL of your TTYD page
iframe_html = f''
st.write(iframe_html, unsafe_allow_html=True)
another method to call the ttyd iframe without this module:-  (you must run ttyd server)
import streamlit as st
iframe_url = "http://localhost:7681"
st.components.v1.iframe(iframe_url, width=800, height=400)
Using this library update the source code in actual python site-packages where your source code is installed.
ttydproc = subprocess.Popen(
# f"ttyd {flags} {cmd}",
f"ttyd bash",
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
shell=True,
)


Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)

Have PairAndPrime ViewModel do an automatic retry on error
Have InsertCannula ViewModel do an automatic retry on error
Add resumingPodSetup func to attempt a getStatus and sleep on errors
Added some improved and updated pumpManager comments
Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
Include additional isConnected handling to OmniBLE resumingPodSetup()

I did a code review and tested this PR.
It is successful.
Background:
With the previous PR, there were several times when a retry was required to get the setup process to continue.
See: https://github.com/LoopKit/OmniBLE/pull/113#issuecomment-1947555014
Since the testing for PR 113, the rPi code was updated (when using PR 11 for that code), so the rPi simulator waits for priming and insertion to complete before progressing to the new pod state.
Therefore, this PR can be tested using just the rPI DASH simulator.
Test:
This code behaved nominally when resuming following

Quit and restart once priming had begun

Repeated the process during the priming and after priming completed

Quit and restart once the insert cannula bolus had begun

Repeated the process during the insertion bolus and after bolus completed

I repeated the pairing and inserting several times, since I can use the rPi DASH. Every time I returned to the pod menu, the process continued without needing to retry.


pass polyfillModuleNames into packager

Motivation
After examining how React Native sets up process.env.NODE_ENV using global.__DEV__ from prelude_dev.js or prelude.js by treating them like polyfills I decided to use the same approach for environment variables. I setup my own rn-project.config.js file like so:
const blacklist = require('react-native/packager/blacklist');
const pathJoin = require('path').join;

module.exports = {
  getBlacklistRE: function() {
    return blacklist([/build\/.*/, /app\/assets\/webpack.*/]);
  },
  polyfillModuleNames: [pathJoin(__dirname, 'globals.js')]
};

I ran the packaging server using:
react-native start --config=config/react-native/rn-project.config.js --reset-cache
I expected my polyfillModuleNames to be passed into the Packager properly and be handled the same way the built-in polyfills worked. Unfortunately I noticed the Packager wasn't actually getting opt.polyfillModuleNames. Digging into the code a bit, it seems the local-cli wasn't passing the polyfillModuleNames from the config.
Test Plan (required)
There are no specs for runServer.js but this change can be tested by using a config that contains polyfillModuleNames. Sample config and run command provided above simple global.js provided below:
global.process = global.process ? global.process : {};
global.process.env = global.process.env ? global.process.env : {};
global.process.env['PROJECT_ENV'] = 'staging';

Could I get some feedback on this? It seems like it was just an oversight not to pass opts.polyfillModuleNames into the packager since the packager is already looking for the option itself

I'll look tomorrow

@jeanlauliac did you get a chance to look over this? I could write up a simple test app if you want to see an example

That makes sense to allow more flexibility for people writing their own configs. Here's what my updated config would look like:
const blacklist = require('react-native/packager/blacklist');
const pathJoin = require('path').join;

module.exports = {
  getBlacklistRE: function() {
    return blacklist([/build\/.*/, /app\/assets\/webpack.*/]);
  },
  polyfillModuleNames: funtion() {
    return [pathJoin(__dirname, 'globals.js')]
  }
};

Making and testing out the changes now.

To confirm: it's only a tiny change ^_^  Lots of the code in the rev I pointed out at is not relevant as it deals with the CLI args and the "default", but we don't want to add these, just the config with an empty function by default.

Yeah, sorry github e-mail confused me so I saw that before these comments and assumed you were talking about something else. I think these changes are what you were asking for, I didn't get a chance to test them out quite yet but let me know if it looks good.


Harden the MatmulTensorCore strategy

This revision improves the behavior of the matmul tensor core strategy for aligned and unaligned cases as follows:

provide better behavior around using the maximum threads for copies by avoiding rank-reducing patterns on vectors that trip up late vector-to-mma conversions.
plug the barrier removal pass added in #13886 : this removes an unnecessary barrier between copies to shared memory and allows a form that the mma.sync pipeline accepts without choking.
force the synchronization of the sequential loop before hoisting redundant transfers to workaround issue #13964. This addresses synchronization issues reported in #13451 and #13811.
various NFC cleanups and error message improvements.
addition of failsafe configuration alterations to avoid hitting corner cases where we would fail to tile and generate sequential code.
turning on mma.sync by default in the unaligned and partially aligned cases.

The changes have been tested against other implementations for numerical accuracy and against races in a variety of unaligned/partially aligned and aligned cases with various compiler configurations.

Interestingly, the UI does not surface the gains, so I am pasting manually:
Before this PR @ #14052 (link):

Benchmark Name
Average Latency (ms)
Median Latency (ms)
Latency Standard Deviation (ms)

matmul_123x2561x2561_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
293.722
293.654
0.231

matmul_2562x2561x2561_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.443
1.440
0.010

matmul_2562x2564x2562_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.581
1.581
0.002

matmul_2564x2564x2564_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.187
1.187
0.000

With this PR (link):

Benchmark Name
Average Latency (ms)
Median Latency (ms)
Latency Standard Deviation (ms)

matmul_123x2561x2561_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
0.197
0.197
0.000

matmul_2562x2561x2561_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.350
1.350
0.000

matmul_2562x2564x2562_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.371
1.371
0.000

matmul_2564x2564x2564_f32t_f32t_f32t_tile_config_default(linalg) [cuda-sm_80-linux_gnu-cuda][ukernel,matmul] cuda(none)[full-inference,default-flags] with zeros @ a2-highgpu-1g[gpu]
1.081
1.077
0.012


Interactive Tutorial - Scaling Your App

RS if you go over the tutorial like<PHONE_NUMBER> it will crash the tutorial page

Hi @menokian
Can you explain what's not right? I have not followed your meaning.
/triage needs-information

@menokian please feel free to explain a bit more what you meant
For now, I'll close this.
/close


add proper typings for functions

Currently because of export default curry(fnName) all typings are lost. Either curry has to be typed somehow or a .d.ts file provided.

I don't think curry is necessary at all. I don't use curry most of the time and I don't want to pay what I don't use.

With the work done in #45, I'm going to close this. If more typings are needed separate issues should be created now.


[Beta] Better imports for icon components

Creating an index.ts file in components/Icon that would just import all the icon components and export them.
// components/Icon/index.ts
import {IconCopy} from './IconCopy';

export {IconCopy};

Why do this?
The old import
import {IconCopy} from '../Icon/IconCopy';

would then be replaced with
import {IconCopy} from '../Icon';

thus creating a better readable code.

if approved I would like to work on this


limiting correctly publishing deb attempts

Correctly limiting debian  packages checks. Failing build if not found

!ci-build-me

!ci-build-me

!ci-build-me

!ci-nightly-me

!approved-for-mainnet

!ci-build-me

!ci-build-me

!ci-build-me


Travis: deploy docs after success.

Coverage decreased (-0.2%) to 83.978% when pulling 726ee0b8946e17f2be4c8da3d407ba917a976aa4 on deploy-docs into 0501ded34dfd9e104b889fe6a969d9444a026a93 on master.

Coverage decreased (-0.2%) to 83.978% when pulling e2c1e26622f0d9525171c8d4d4350431018dca65 on deploy-docs into 0501ded34dfd9e104b889fe6a969d9444a026a93 on master.


how to reduce gpu memory in vllm

when i run it with:
python -m vllm.entrypoints.openai.api_server --model /home/wanghaikuan/code/LLaMA-Factory/qw7bint4 --trust-remote-code --max-model-len 2046 --host <IP_ADDRESS> --port 8087  --gpu-memory-utilization 0.15

i think 7G is enough, in fact, it need 10G almost.
Is there any parameters to reduce gpu memory.
Thanks!

when gpu-memory-utilization is 0.2 (10G),  it looks ok.  set  gpu-memory-utilization=0.15, will fail to run

You can decrease --max-model-len to make the KV cache smaller and use --enforce-eager to stop CUDA graphs from consuming memory (at the cost of performance).

Hi @hmellor I would like to ask more info about how can we avoid CUDA graphs from consuming memory, I have use --enforce-eager in command such as python main.py --enforce-eager but it still running CUDA graph. I can't find any more relevant information in the documentation. In addition, I also found the answer generated is not a complete sentence. What are the parameters I should change?
I am using pip install vllm to install VLLM as provided.
Following is my test code:
from vllm import LLM, SamplingParams

prompts = [
    "Briefly list down the steps to perform Cook Bacon.",
    "What is the definition of gravity?",
    "The capital of France is",
    "The future of AI is",
]
sampling_params = SamplingParams(temperature=0.8, top_p=0.95)

llm = LLM(model="lmsys/vicuna-13b-v1.3", seed=1024)

outputs = llm.generate(prompts, sampling_params)
# print(outputs)
# Print the outputs.
for output in outputs:
    prompt = output.prompt
    generated_text = output.outputs[0].text
    print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")


  M M M . . . . # 21
= Oh, how the Mighty have Fallen...
: Once upon a time, a T tetramino spawned at the
: top of the well, and used the 'v' command to
: move down by one cell 24 times. Sadly, it was
: unable to burrow into the earth and spent the
: remainder of its life standing on its head at
: the bottom of a well.
#+end_src

It moves down past the end of the screen.
In Tetris, as soon as it hits the bottom of the screen it should be considered a hard drop like V and change to a new tetromino.
Learntris assumes the T is still active even as it goes beyond the scren and is dropped... which makes no sense at all. The tetris implementation should select a new tetromino.
It should also not use P because that implies it's still active.
So it should be something like cT vvvv vvvv vvvv vvvv vvvv pq (move 20 rows down, then print normally.)
cc @tangentstorm

I get what you're saying here. To be clear, it's only when you push past the bottom that it's a hard drop: you absolutely can rest on the bottom of the well and spin the piece (at least in modern tetris).
One small problem is that at this point in the narrative, we haven't implemented "stamping" the active tetramino into the well. (IIRC, that test follows shortly after...)
The bigger problem is I mostly just wanted to break things into tiny tiny pieces, so that you could pass each test with a fairly small amount of code.
So... If it's confusing, I'm inclined to make this a change to the text, so it explains to people not to worry about taking on too much here. (The current text is fairly silly...)
What do you think about that?

It was really confusing me so explaining what a hard drop is and that it goes one past the bottom would be helpful.
you absolutely can rest on the bottom of the well and spin the piece
My point was that this goes 24 down, well past the bottom of the well. It should "stamp" then. Then P should not show it as still the active tetromino because it shouldn't be active anymore after it stamps. (Otherwise you get weird stuff like being able to move it around to make more copies of it.)
Think of the implementation after this test. Once you implement stamping on the bottom this test no longer makes any sense.
I'd also add a test to test manual hard drops / "stamps" after it.


Issue while running  eval.py

Excuse me . Can you help me  solve this problem? when l run  python eval.py  --trained_model=weights/yolact_resnet50_54_800000.pth
it appears this following problem.
Traceback (most recent call last):   File "eval.py", line 1020, in <module>     evaluate(net, dataset)   File "eval.py", line 800, in evaluate     inp, out = args.images.split(':') ValueError: not enough values to unpack (expected 2, got 1)

Is that your full command? That error looks like the command line argument --images was set to something. To use images you need to go --images=input_folder/:output_folder/ (hence the complaint about split(':'))

thanks.

python eval.py --trained_model=weights/yolact_base_1428_10000.pth --score_threshold=0.15 --top_k=15 --images=data/coco/images/test:results/ --config=yolact_base_config --display
like this


Update protobuf-java to 4.28.0

About this PR
📦 Updates com.google.protobuf:protobuf-java from 3.25.4 to 4.28.0 ⚠
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf", artifactId = "protobuf-java" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.45%. Comparing base (18aa9af) to head (3c99785).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   79.45%   79.45%
=======================================
  Files         144      144
  Lines        5009     5009
  Branches      674      674
=======================================
  Hits         3980     3980
  Misses       1029     1029

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Superseded by #1752.


Types are nowhere to be found in the library after installation despite the promise they are included

Feature description

And nothing found in dependencies https://github.com/uuidjs/uuid/blob/v11.0.0-0/package.json
Additional information
No response

You have an older version of uuid installed.  Types are only available as of version 11 (currently in prerelease).
npm install uuid@beta should get you sorted.

Ah, you are right


[WIP] Add iterator peel

This iterator replaces a common idiom with an iterator that is a bit more elegant and performant.
It returns the first item in an iterable and an iterator over the remaining
items. Something like the following occurs many times in qiskit
first = items[0]
for x in items[1:]:
    compare(x, first)

This would be replaced by
from qiskit.utils import peel

first, rest = peel(items)
for x in rest:
     compare(x, first)
    ...

Here is an example in a new PR https://github.com/Qiskit/qiskit-terra/pull/7202
        for other in ops[1:]:
            ops[0]._op_shape._validate_add(other._op_shape)

I searched for a while for this iterator in external libraries, but didn't find anything.
I have not begun to replace instances of this idiom in qiskit with calls to peel.

This signals intent by putting the peeling procedure in one place. Often the two uses are separated. You might ask "why items[1:]", and then find several lines further that items[0] is treated specially.
It may be more efficient especially for large lists because items[1:] creates a new list, at least of references.

I don't remember the supported versions, but I think this is achievable with general Python unpacking syntax: first, *rest = iterable.

This was on my list of solutions to check, but it slipped off.  In any case, the semantics are not lazy.
In [1]: x = [1,2,3,4]

In [2]: a, *b = x

In [3]: b
Out[3]: [2, 3, 4]

In [4]: type(b)
Out[4]: list

This solution does have the advantage of being widely understood.

I did a few tests and was not able to find any efficiency advantage in using peel rather than constructing a list with via
first, rest = x[0], x[1:] or first, *rest = x. It looks like peel is not so useful in python.  I'll leave this open for just a bit in case someone sees something we are overlooking.
I'd advocate using first, *rest = x , or even first, rest = x[0], x[1:] over what I find now because it gives a clue about what comes next.

I thought that itertools or pytoolz/cytoolz would already have this but it seems not. In the process of searching I came across this discussion that is maybe interesting https://groups.google.com/g/python-ideas/c/4hRfLpryFuQ basically it comes down to subtleties of iterator vs iterable. Something lazy like peel might be useful for situations like infinite iterators eg itertools.countI(), where unpacking would hang.

Yes, one way to really see the difference in efficiency is if the number of items is infinite. What I intended is that the input be an iterable, including an iterator as a special case. And return the first item and an iterator over the rest. I think peel does this, except that it mutates the input, which is not the behavior I was looking for.
In [1]: from peel import peel

In [2]: from itertools import count

In [3]: it = count(); it
Out[3]: count(0)

In [4]: next(it)
Out[4]: 0

In [5]: next(it)
Out[5]: 1

In [6]: it           # that's how count works
Out[6]: count(2)

In [7]: it2 = count(); it2
Out[7]: count(0)

In [8]: first, rest = peel(it2); (first, rest)  # does what we want
Out[8]: (0, count(1))

In [9]: it2    # oops, it mutates the input
Out[9]: count(1)

Compare to islice. itertools.islice takes an iterable, including an iterator, and returns an iterator. It also mutates an input iterator. So peel is consistent with islice, which I take as a proxy for correct behavior in python. Neither islice nor peel mutate an input list. That islice mutates some iterables, but not others is unfortunate.
The following is a bit artificial but does show a significant efficiency gain from using peel.
def sum1():
    n = 100_000
    s = 0
    first, rest = peel(range(n))
    for x in rest:
        s += x
    return x

def sum2():
    n = 100_000
    s = 0
    first, *rest = range(n)
    for x in rest:
        s += x
    return x

sum2 is about 25% slower than sum1.
As far as the evidence above goes,  first, *rest = iterable has economy of verbs and syntax in its favor. Otherwise, peel is better.

This seems to be not super interesting at the moment. I'll close it.


fix: repair comment error.

When using the MySQL prepared by DevLake, you can specify a root password to manage the MySQL.
@klesh @matrixji Please take a look. cc @JorgeGar @hezyin

I would like to make sure that the devlake pod in the helm is NOT using the rootPassword for  anything, right?
if that so, we should also declare that it is for user to manage the mysql instance deployed by our helm and it is NOT required when using external db, like rds...

For external MySQL we do not need MySQL root password, we only need the user/pass for the lake database. But for MySQL server with our helm chart, follow the description by https://hub.docker.com/_/mysql, the MYSQL_ROOT_PASSWORD is mandatory for starting a MySQL instance, so that's why we initially use the parameter rootPassword  for user input

Nice, just the way I thought it should be.
The only problem left is how we can convey the idea to our users clearly.
From the current comment, users can not tell what is it for. We should add more context to explain why he needs to fill in the rootPassword in the first place, or, he might still fill in an existing rootPassword from some database server by mistake, we don't want that.

@klesh @matrixji How about leave this pr link in the option comment?

A good idea before we have more conclusions about it. Maybe we later could learn more from bitnami/mysql's implement or even provide an option for using bitnami/mysql as a subchart directly.

@daniel-hutao @matrixji I think we could add the following comment above the rootPassword:
rootPassword is used to initialize the Optional MySQL database that ships with our helm, please leave it blank if you are using an external database like RDS.


[Event Request] Codeunit 99000813 "Carry Out Action" - procedure CarryOutProdOrder - OnCarryOutProdOrderOnAfterCalcPrintOrder

Please add an Event OnCarryOutProdOrderOnAfterCalcPrintOrder in procedure CarryOutProdOrder in Codeunit 99000813 "Carry Out Action"
[Event Request] Codeunit 99000813 - Carry Out Action - procedure CarryOutProdOrder
    begin
        PrintOrder := ProdOrderChoice = ProdOrderChoice::"Firm Planned & Print";

        OnCarryOutProdOrderOnAfterCalcPrintOrder(PrintOrder, ProdOrderChoice); // <-- NEW EVENT

        case ReqLine."Action Message" of
            ReqLine."Action Message"::New:
                if ProdOrderChoice = ProdOrderChoice::"Copy to Req. Wksh" then
                    CarryOutToReqWksh(ReqLine, ProdWkshTempl, ProdWkshName)
                else
                    InsertProdOrder(ReqLine, ProdOrderChoice);
            ReqLine."Action Message"::"Change Qty.",
          ReqLine."Action Message"::Reschedule,
          ReqLine."Action Message"::"Resched. & Chg. Qty.":
                exit(ProdOrderChgAndReshedule(ReqLine));
            ReqLine."Action Message"::Cancel:
                DeleteOrderLines(ReqLine);
        end;
        exit(true);
    end;

[IntegrationEvent(false, false)]
local procedure OnCarryOutProdOrderOnAfterCalcPrintOrder(var PrintOrder: Boolean; ProdOrderChoice: Option)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 44362.


GHCJS failing to build on x86_64-linux

Describe the bug
Unable to build GHCJS on my x86_64-linux machine when building against the package set from NixOS/nixpkgs-channels 1d8018068278a717771e9ec4054dff1ebd3252b0. The GHCJS Nix definition is the same as HEAD on master.
To Reproduce
Steps to reproduce the behaviour:
# On an x86_64-linux machine:
nix-build -A haskell.compiler.ghcjs <path_to_nixpkgs>

Expected behaviour
Successfully builds GHCJS and creates result.
Actual behaviour
The build fails, and the following error is emitted to the terminal:
error: Package ‘ghcjs-<IP_ADDRESS>’ in /nix/store/a6wqbwdpls8b04ylz98b9cd8x9nww9h5-source/pkgs/development/compilers/ghcjs-ng/default.nix:66 is not supported on ‘x86_64-linux’, refusing to evaluate.

Notify maintainers
@ElvishJerricco
Metadata
Note that I am building GHCJS against NixOS/nixpkgs-channels commit: 1d8018068278a717771e9ec4054dff1ebd3252b0.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.6.18, NixOS, 20.03.2611.bb8f0cc2279 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.6`
 - channels(root): `"nixos-20.03.2611.bb8f0cc2279"`
 - channels(dd): `"nixos-17.09-17.09.3269.14f9ee66e63"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Thanks, @cdepillabout and @maralorn. I'm not as experienced with GHCJS, but will try looking into it.

Also wanted to share, when I try building haskell.compiler.ghcjs.overrideAttrs (old: { meta = {}; }), nix-build simply outputs nothing and hangs. Not sure how to debug this; any help would be appreciated.

So, I've figured out the problem, and managed to get ghcjs building locally. Going to submit a PR shortly.

PR is up: https://github.com/NixOS/nixpkgs/pull/96141

Closed by  #96193.


Decal material - blend factors not carried over in migration

Current Behavior
The blend factors are set to zero, while they should reflect the current blend factors in the panel data. and custom values panel.
Expected Behavior
reflect the values found in custom panel for blend factors.
Steps To Reproduce
use legacy exporte with decal material, set blend factors to 1.0 open this model in ASOBO 1.1.5 exporter and migrate decal msfs material.  See that blend factors are set to zero.
Environment
- OS:10
- Blender:3.1.2
- glTF-Blender-IO-MSFS:1.1.5

Anything else?

I have the same problem. All decals are invisible in MSFS.

Same problem here. Decal texture is invisible.

#128 fixes migration, and #126 fixes new decals

Agree fixed


chore(ci): run on appveyor

@diasdavid Don't know why circleci is failing; expect its old code.  This PR only added appveyor.yml

I believe that is because it is a old circle.yml file, mind updating it to https://github.com/ipfs/js-ipfs-api/blob/master/circle.yml ? Thanks!

@diasdavid circleCI is still failing when trying to start chrome
05 11 2017 18:45:25.574:ERROR [launcher]: Cannot start Chrome
	Xlib:  extension "RANDR" missing on display ":99".
[29790:29829:1105/184525.450736:FATAL:nss_util.cc(632)] NSS_VersionCheck("3.26") failed. NSS >= 3.26 is required. Please upgrade to the latest NSS, and if you still get this error, contact your distribution maintainer.

05 11 2017 18:45:25.575:ERROR [launcher]: Chrome stdout:
05 11 2017 18:45:25.575:ERROR [launcher]: Chrome stderr: Xlib:  extension "RANDR" missing on display ":99".
[29790:29829:1105/184525.450736:FATAL:nss_util.cc(632)] NSS_VersionCheck("3.26") failed. NSS >= 3.26 is required. Please upgrade to the latest NSS, and if you still get this error, contact your distribution maintainer.


Fix oom tests on non Linux

OOM procfs is linux specific, so should not be running on mac os, freebsd, etc.
Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

Needs rebase.

Rebased


Preserve speed when moving diagonally

The original algorithm squares both X and Y separately, which cause the movement speed to drop by up to half when not moving perfectly along the axes (assuming a full stick push). The new algorithm converts the XY speed vector into a speed and a moving angle vector and only square the speed instead. This prevents the slowdown issue present in the original algorithm.

Thank you very much, I didn't manage to replicate the issue, so I wasn't able to fix it myself.


Handling restart of app after switching permissions

Hi,
I'm facing a problem but this issue could be like a question.
When user access to device settings to switch permissions and back to the app, the app restarted without keeping it's state.
So if user was in a deep state of the app he has to go back to this deep state to continue the process i tried to do before app ask him to allow some permissions.
Is there a code for permissionscope to let app restart from the previous state where show() function was called?
I think that we won't have to store app state in something like user preferences and test it on start!
I'm fan of this library and I think this function (if it's not already present) could be great for futures integrations.
Thanks

Hi tux,
Why not just call show() again ? PScope will just need to re-check the configured permissions' current status

My problem is that show is called from a deep screen of the app ( like third or fourth screen) so I can't call show() again from a restart of the app due to haven't the previous behavior.
I hope  this is understandable !

Permissionscope doesn't manage the state of your app so we can't restore it to the state where you left off when changing something like contacts permission. Luckily this only occurs if a user denies contacts permissions and then has to re-enter settings to turn it on, not on the initial ask.


marked dependency is insecure version

https://nvd.nist.gov/vuln/detail/CVE-2017-17461
https://nvd.nist.gov/vuln/detail/CVE-2017-1000427
Suggested update marked ~> 0.3.9.

@75lb this isn't about command line tools. It would be enough for someone to contribute seemingly proper code to a Github project but include a hidden base64 URI somewhere. If that stays unnoticed and the PR is merged in, the next time JSDoc is used to generate the docs, it will include the malicious code. Et voilà, there you have it: Public documentation of a possibly big open source project, compromising all visitors.

@Radiergummi So hackers are now successfully submitting malicious code as PR requests? Knowing the maintainer of the project is an experienced guy, I can't say I'm too worried about that risk, personally.
Anyway, this project has a dependency on<EMAIL_ADDRESS>meaning that when you install jsdoc,  marked v0.3.17 (the latest version compatible with ~0.3.6) is installed - which has no security issues. I still can't find a security issue here.

Any update on this? The issue seems to be still present.


add to cart error?

anyone able to successfully add a product to cart? i get a cors or server blocked error

@theewl I am also having the same issue. On the network it shows a 403 error. Were you able to find a work around?

@zer0awes0me nah.. they upgraded their security system so it’s preventing bots (Puppeteer) from accessing their site.

Hey guys, some workaround?

Hey guys, some workaround?

I was able to get it working on Indian website by using chrome normal and not chromium.

I was able to get it working on Indian website by using chrome normal and not chromium.


Add variables property

Otherwise LogManager.Configuration cannot be used to read variables
defined in XML
closes #518

I find the return null a bit unexpected.
I'm also curious if we could change the variables programmatically.  The return null Will make that difficult?

The variables property is only available when NLog is configured using XML.
Configuring programmatically has never supported variables, therefore I
think it is important to show variables won't work when configured
programmatically.

What do you think about a notsupportedException?
Otherwise it looks like a bug.

That would be a good idea, I'll update the pull request

bump @Xharze

We need this also in 4.0 :)


Use gnome extension for mesa to enable graphics acceleration with

adreno and asahi.
Same change as in https://github.com/diddlesnaps/supertuxkart/pull/24.

ping

thank you @lucyllewy !
Running --beta (release-20231010) on Ubuntu Asahi runs great:
$ openra.ra
Platform is Linux (Arm64)
Engine version is release-20231010
Runtime: .NET CLR 6.0.23
Using SDL 2 with OpenGL (Embedded) renderer
Desktop resolution: 1280x800
No custom resolution provided, using desktop resolution
Using resolution: 1280x800
Using window scale 1.00
OpenGL renderer: Apple M2 (G14G B0)
OpenGL version: OpenGL ES 3.1 Mesa 23.3.0~pre20230821-1asahi1.22.04
Using default sound device
Internal mods:
	cnc: Tiberian Dawn (release-20231010)
	d2k: Dune 2000 (release-20231010)
	modcontent: Mod Content Manager (release-20231010)
	ra: Red Alert (release-20231010)
	ts: Tiberian Sun (release-20231010)
External mods:
	ra-release-20231010: Red Alert (release-20231010)
Loading mod: ra
Loading mod: modcontent
Loading mod: ra


Support for Typescript

Hi!
This is a great library and I foresee it will help a lot when writing component with Vue Composition API.
Is there a plan to add the typing interface as well in the script?
Thank you!

Hi! Thanks for checking it out!
No plans yet, but would be willing to accept pull requests to add typings.
In the meantime, I'd encourage you to check similar options that were designed for TypeScript, such as vuex-typed.