Race condition for temp dir creation

Hi there,
we are running S3Mock embedded using the S3MockExtension. I know that this scenario is deprecated. ;-)
After adding a second unit test class using S3MockExtension we are regularly seeing root folder creation failures in CI where two threads generate the same tmp file name and only one of them succeeds with mkdir in StoreConfiguration#rootFolder.
I have prepared a PR that hopefully fixes this issue by using Files#createTempDirectory, which is thread-safe.
Regards,
Thilo
01:44:23.689 [ForkJoinPool-1-worker-1] INFO  com.adobe.testing.s3mock.store.StoreConfiguration - Successfully created "/tmp/s3mockFileStore1664243063689" as root folder. Will retain files on exit: false
01:44:23.692 [ForkJoinPool-1-worker-8] WARN  org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'bucketStore' defined in class path resource [com/adobe/testing/s3mock/store/StoreConfiguration.class]: Unsatisfied dependency expressed through method 'bucketStore' parameter 1; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'bucketRootFolder' defined in class path resource [com/adobe/testing/s3mock/store/StoreConfiguration.class]: Unsatisfied dependency expressed through method 'bucketRootFolder' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rootFolder' defined in class path resource [com/adobe/testing/s3mock/store/StoreConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [java.io.File]: Factory method 'rootFolder' threw exception; nested exception is java.lang.IllegalStateException: Root folder could not be created. Path: /tmp/s3mockFileStore1664243063689

@ginkel thanks again for the PR, I just released 2.7.1 containing your fix. :)

@afranken Thanks for the speedy release! :-)


Add an "Is this incorrect?" button for quick & easy feedback

Also, for details we don't know, like address or email, show "Unknown" with a "Do you know it?" button next to it.


Support dynamic corruption loadouts

New features:

Add new Corruption loadout row
Remove corruption loadout row
Corruption loadout is scrollable. (kinda ugly but maybe it's fine.)

Thank you for your wonderful ideas and efforts. But discussion is needed.
Please confirm that the Remove operation does not cause any mistakes.
I don't think it's a good implementation to include the HTML in loadoutTemplate() directly in your code.
The hotkey Shift + Number is a loadout change. It corresponds from 0 to 9.
There is a conflict in # 219. Be careful.

@httpsnet I don't like the fact that the html is embedded in the js either. But manually keeping track of the DOM for new/save/load/remove/rename is kinda tricky and error prone.


Fix ignored blacklist during component extension

Changes Made

system function now merges blacklist props from base and child components during an extension.
Addition of test to cover new functionality.

Related Issues
Will close #5

@jxnblk any input here?

@jxnblk Hi, do you plan to merge this PR anytime soon? That would be great!


Unable to graph data

Hello-
While attempting to graph sample data from https://raw.githubusercontent.com/CSSEGISandData/COVID-19/master/csse_covid_19_data/csse_covid_19_time_series/time_series_covid19_deaths_global.csv I observe my Grafana dashboard message: Unable to graph data
When I switch to table view, yes the data is visible, but isn't the whole point to graph data with Grafana's amazing UI?
Surely this is available now, is it not?
See screen capture...

Let's close this issue. I was able to graph data with a more simple schema.


[FEATURE]

Detailed description
This issue doesn't have a more in-depth spec, it just suggests a feature.

By declaring HTML as follows, the button which is the default slot element is displayed. Clicking that button will bring up a modal dialog with tier slots as child elements and start the staking flow.
<dev-stake-on distnation="0x...">

This is the 1st tier

This is the 2nd tier

This is the 3rd tier

    <button>Please stake on me</button>
</dev-stake-on>

Context
You can easily build such paywalls by using this combined with <dev-when-staked> #118 .

Possible implementation
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I feel like we can use the currently in the works hashi dialog, but the design would change a bit. As for the styling, I don't think we can use the hashi lib directly since shadow DOM works in a different way than regular DOM and virtual DOM. So styling is going to be a special implementation for a start.
Also for the buttons, we can use the hashi-lit button, but that's still in development so I don't really know about that.

The design does not have to be as per this attached image, we are free to think as we please. By the way, wouldn't it be cool if we could build it with just lit (i.e. just lit-html) instead of LitElement?

I'm thinking about what kind of implementation can be done to use Hashi in Shadow DOM. In essence, the child elements of top-level Custom Elements don't have to be Shadow DOM. Therefore, if the top-level Custom Elements have Hashi and Tailwind class declarations in the Shadow DOM, we can use them in child elements.
Also, with ullr, we can use Shadow DOM inline without class definition, and there is also an API for declaring Custom Elements. using LitElement just for Shadow DOM and Custom Elements may be a bit of an exaggeration.
https://github.com/dev-protocol/dev-elements/blob/2fa74c8021c5d7e4d15fa23334715b251b8263ca/src/stake-on-me-button/index.ts#L5-L12
https://github.com/dev-protocol/dev-elements/blob/2fa74c8021c5d7e4d15fa23334715b251b8263ca/src/stake-on-me-button/element.ts#L4-L10

@MatteuSan I've changed to using the Tailwind classes in Shadow DOM in #129, so I ping you!

@MatteuSan I've changed to using the Tailwind classes in Shadow DOM in #129, so I ping you!
aight gotcha


Add coding style tools, and a link to the LLVM Coding Standards.

I think those are useful. Please review.

"Coding Style" should not be under the "Software" category. Also there is already a coding style category after right after the books!

I know that there is a coding style category after the books (in fact, the commit contains an addition to that), however that's part of the "Resources" chapter and otherwise contains links to further reading. The section I added under "Software" contains tools to help with these tasks, I thought it would be misplaced if those went into "Resources" because they're sort of not resources but software.
Also, added another commit with Boost.Multiprecision and LibTomMath. The former I've used myself and found quite neat because of its lack of dependencies, the latter I've seen used here and there so it's probably worth a mention too.


Dotnet 4.8 4.7 and core support

Bug
Dotnet 4.8, 4.7.x, Core is currently not supported. The Library Continental.eCAL.Core.dll fails to work with any of the stated frameworks. A nuget package may be created for easy use.
Error
System.BadImageFormatException: 'Could not load file or assembly 'Continental.eCAL.Core, Version=1.0.8406.16257, Culture=neutral, PublicKeyToken=null' or one of its dependencies. This assembly is built by a runtime newer than the currently loaded runtime and cannot be loaded.'
Desktop (please complete the following information):

OS: Windows 10
VS 22

Hey uxmanz,
I am a C++ and not a C# developer, so please help to to get a kickstart into this topic.
Am I assuming correct, that

.net is downwards compatible for binaries
You usually want to build a lib like eCAL.Core.dll against the oldest .net Version possible
Visual Studio contains some random version of .net that is used by default, but you can somehow also use another (e.g. older) SDK

Currently our build doesn't care about a specific .net version, it just compiles against something that is preinstalled on the GH Action runners:
https://github.com/eclipse-ecal/ecal/blob/master/.github/workflows/build-windows.yml
Maybe you have a suggestion on how we can improve that?


do sdl_init in main thread

wrote this last week, I hoped it would make a window appear on MacOS (for @rvdm - I don't have a Mac ready, although there should be one somewhere here!). I believe this change did remove a few warnings/errors we got earlier, but it's not enough.

superseded by #44


Use pyextremes package for detailed grid-point analysis

The pyextremes package allows for detailed analysis of extreme value analysis at a single point. It could be used to interrogate points in a grid of results produced by the xclim frequency analysis functionality.

I need to turn this into a script (or a papermill template).


Implementation of Normalizations

First draft of a file for Normalizations implementing #6 .
I have Implemented GroupNorm, InstanceNorm and LayerNorm and a first testcase for GroupNorm( I will add a few more and will also implement some for Layer/Instance norm).
Could you give me a quick feedback on the implementation or if something is missing?
Thx in advance

@karmel  as discussed in our monthly meeting... LayerNorm was added to keras experimental which kind of stomps on the implementation we were going to add. Could you please update us on the keras experimental roadmap?
Additionally, addons was going to add GroupNorm as a generalized normalization case (See below image). Any thoughts on how we should proceed?

https://arxiv.org/pdf/1803.08494.pdf

Notes from discussions with the Keras team--
In general, this makes more sense in Addons than in experimental. It was added to experimental as a stopgap for some migration work, but we all agree this is a better fit for Addons than experimental, as the scope of use-cases is fairly narrow.
In the future, we will make sure to de-dupe with Addons before adding to experimental, and to prefer Addons unless we are actually adding a Layer/etc. that will end up in core, but has some API kinks to work out.
So, for this PR, if you could go ahead and dedupe with the experimental implementation and push here, we will remove the experimental implementation and use this one instead.
Thanks, all, for working on this.

@Smokrow Would you be able to modify the test coverage to be as extensive as the reference in tf.keras  experimental.  Then we can merge and request the removal of LayerNormalization from core

On it. Thx for clearifying :+1:

Hi, could you resolve conflicts?

This is still not finished.

@seanpmorgan I am having some trouble with running the tests.
I am getting the following while running the test_groupnorm_flat and test_groupnorm_conv
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/absl/third_party/unittest3_backport/case.py", line 37, in testPartExecutor
    yield
  File "/usr/local/lib/python2.7/dist-packages/absl/third_party/unittest3_backport/case.py", line 162, in run
    testMethod()
  File "normalizations_test.py", line 82, in test_groupnorm_conv
    model.fit(np.random.random((10,20, 20, 3)))
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/keras/engine/training.py", line 989, in fit
    steps_name='steps_per_epoch')
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/keras/engine/training_arrays.py", line 330, in model_iteration
    batch_outs = f(ins_batch)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/keras/backend.py", line 3123, in __call__
    outputs = self._graph_fn(*converted_inputs)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/eager/function.py", line 452, in __call__
    return self._call_flat(args)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/eager/function.py", line 521, in _call_flat
    outputs = self._inference_function.call(ctx, args)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/eager/function.py", line 291, in call
    (len(args), len(list(self.signature.input_arg))))
ValueError: Arguments and signature arguments do not match: 15 17

Looks like it is deep down in the Eager execution but I am quite confused whats going on down there 😄
Greets

I check out the feature branch, and fail to run bazel tests.

@Smokrow Hi, Moritz. Could you fix bazel configuration and make sure we can reproduce your problem?

@seanpmorgan ready for review

@seanpmorgan @facaiy ready for review :+1:

@Smokrow Thanks for your work,  Moritz!
@ppwwyyxx Yuxin, would you mind taking a look again? Thank you very much for your review :-)

I don't have other comments. The description for the "axis" argument is still not very accurate but it seems there are other plans to address it.

Thanks so much for the contribution Moritz. Made some minor formatting changes & integrations with the project if you want to check them out. Looking forward to the example/demo notebook. Thanks for the review @ppwwyyxx we'll be sure to address the axis ambiguity with the demos and if that is not sufficient we can iterate on the parameters as we're still early in release cycles.


Override actions in child controller

Here is a code from framework (https://github.com/yiisoft/yii2/blob/<IP_ADDRESS>/framework/base/Controller.php#L219)
public function createAction($id)
{
    if ($id === '') {
        $id = $this->defaultAction;
    }
    $actionMap = $this->actions();
    if (isset($actionMap[$id])) {
        return Yii::createObject($actionMap[$id], [$id, $this]);
    } elseif (preg_match('/^[a-z0-9\\-_]+$/', $id) && strpos($id, '--') === false && trim($id, '-') === $id) {
        $methodName = 'action' . str_replace(' ', '', ucwords(implode(' ', explode('-', $id))));
        if (method_exists($this, $methodName)) {
            $method = new \ReflectionMethod($this, $methodName);
            if ($method->isPublic() && $method->getName() === $methodName) {
                return new InlineAction($id, $this, $methodName);
            }
        }
    }
    return null;
}

What's the justification for checking actions first and not vice versa. Now if I have BaseController with some logic for all other controllers (such as default actions, behaviours...) and I have following defined in there:
public function actions()
{
    return [
        'error' => [
            'class' => 'yii\web\ErrorAction',
        ],
    ];
}

I can't override just the error action with inline action in one of the child controller, and I need copy paste all the common logic. (The same applies for any action defined in parent)

Q
A

Yii version
2.0.13

PHP version
NA

Operating system
NA

public function actions()
{
    $actions = parent::actions();
    unset($actions['error']);
    return $actions;
}

?

lol, sorry. I didn't think to do that the easy way)). I was trying to override the action and define action with the same name and using InlineAction...


can we get intellisense for our tw components

is there an extension for tw tailwind intellisense, and if there already is pls can i be directed to it.

Never mind i just saw your method in the docs after re reading it.


add manifest host from Rails.configuration

:+1:

I was just looking at doing this myself! This is the exact change I was going to make.
This comes in handy when we're running the dev server in a docker container, and need to pass the host name in. For linux, it may well be localhost. However, for Docker for Mac (beta), this needs to be docker.local. For docker-machine users, unless they are running their own local dns, this would be an IP address.

Closed as resolved by the DevHosts branch


Catch YAML specification errors

[ ] Raise exception if user tries to create a clarify action (through slot_fill or otherwise) for a context variable with a flag type known
[ ] Raise exception if the user uses names that would be invalid in PDDL (spaces, etc.)
[ ] Any actions with generated names (e.g. action names or intents from slot_fill) need to be checked against existing names in the YAML. Raise an exception if a duplicate occurs.
[ ] For slot_fill actions, enforce you can’t have single-slot specifications if you only have one entity

There already a dedicated place for confirming the yaml? These seem like a great start for what should be a common practice of scanning the yaml on ingestion.

Right now it's just the parsing file that converts it to the hovor JSON. It would be ideal to have a "scan" before parsing anything, but for the "custom" actions that wouldn't work. So those exceptions would have to be handled within the parsing module


iFrame postMessage data should include the value of the vote id

I use several cocorico iframe on one page. Each of these iframe emit messages with postMessage but I am unable to trace back which iFrame emitted which message if the message does not include the id of the vote (1 vote <-> 1 iframe). Unless I am mistaken, I did not see the id of the vote in the voteComplete nor voteSuccess MessageEvents.

My first idea would be to pass voteComplete_[voteId] as data but I am definitely not a JS expert :)

You can use the URL in e.currentTarget.window.document.location to get the vote id:
window.addEventListener('message', function(e) {
  var voteId = e.currentTarget.window.document.location.pathname.split('/')[3];

  // ...
});


Fix relative links

fixes #25
But I probably edited the output of a generator, so it will break again.
Someone should probably tell me about that.

Thanks, I've made the fixes at the doc source, and now the site was rebuilt.
Awesome catch!

Not sure who caught who.
I followed a link from medium that lead me to experience the problem :smiley:


added some image

@hendrahend Thank you very much for your contribution! 🏆

@all-contributors please add @hendrahend  for content


Analytic test for scientific accuracy of optical fibre

Add a sphere to the scene of radiance = 1.
Add an optical fibre of known circular area and acceptance cone that encompasses the sphere.
Calculate the solid angle the fibre subtends relative to the sphere and hence we can evaluate analytically the total power that should be collected.

Closed in e9f3a3cdd094550ee101d3a60091ad5398b58b87


g-watch-wear crashes every minute on Android 14

The g-watch-wear app crashes on my Android 14 Pixel 7 Pro.
libre 3 via juggluco to g-watch-wear app.
open packet console, crash when receiving the packet from juggluco. You do not have to open the packet console, it's just to visually see the crash. Without you see no update on the watch and a android system message that g-watch-app crashes.
The tizen g-watch app works fine with getting data from juggluco.

Maybe the crash is not related to juggluco, just changed my sensor to a Dexcom G7, the app closes as well.
So I removed all data sources, but the app still crashes.
Seems that g-watch-wear is simply unusable on Android 14

Can confirm on Pixel 7a, all data sources removed, but the app still crashes.

After some debugging I think i found a workaround.
In my case when I disable this option in AAPS 👇 G-Watch-Wear is working ok with Diabox data source.

The current version of the app was adopted to Android 13, in that time there was no Android 14 available. The next version will handle this issue

This is a duplicate of #19

AAPS is not an option to disable as I'm just using a sensor (libre3/juggluco) to send the values to the watch. There is no AAPS on my mobile, or I still use a pen instead of an pump..

@hansj10 That's too bad, in my case it helped :( Perhaps in juggluco there is a similar option that synchronizes data with watches and can be turn off?


Correct version requirement?

I was just reading the requirements for the solution, and this caught my eye:
"All editions of SQL Server 2016 and above are supported."
Is this really correct, 2016 and above?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f1a3830-2d51-f861-a150-5cb20ed26a85
Version Independent ID: aab107d9-b859-8f05-9bf3-b1cb28f3bf73
Content: Migrate using Azure Data Studio
Content Source: articles/dms/migration-using-azure-data-studio.md
Service: dms
GitHub Login: @mokabiru
Microsoft Alias: mokabiru

@SQLFinn Yes, if you are using ADS to migrate, SQL Server 2016 is the minimum version supported currently and we are working to support prior versions in the near future.

@SQLFinn - I should add that this is a limitation only if you are migrating to SQL Server on Azure VM. This is not a limitation for SQL MI. The article will be updated to clarify this - thanks for the feedback.

Hi,
Thank you for the quick reply and clarification!

Mika

From: Mohamed Kabiruddin @.>
Sent: Friday, February 25, 2022 7:20:06 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Mika Sutinen @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Correct version requirement? (Issue #88775)
@SQLFinnhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSQLFinn&data=04|01||9d44b601ebc74c210a8408d9f883117d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637814064081729898|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=gKpqRuHLyhvh67tIz%2BTdJWt6dcYlPWlxRYMchid3JNI%3D&reserved=0 - I should add that this is a limitation only if you are migrating to SQL Server on Azure VM. This is not a limitation for SQL MI. The article will be updated to clarify this - thanks for the feedback.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F88775%23issuecomment-1051042708&data=04|01||9d44b601ebc74c210a8408d9f883117d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637814064081729898|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=fIqFlrTUCm2PpYF98XmCFwG3DVHtgYs9cMhoCMKqJ2o%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEUVEASASJONTI6OBSTTDXLU4624NANCNFSM5PKXXSRA&data=04|01||9d44b601ebc74c210a8408d9f883117d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637814064081729898|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=VxWF9RlkYT9FeAwwNzzh5mewV4r1L7WyjTDJi8B8TkM%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||9d44b601ebc74c210a8408d9f883117d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637814064081729898|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=gX43OKcG8UPdAtpPEOh2fYW9TwMVJ5%2FWBAJ%2BA1V8N8k%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||9d44b601ebc74c210a8408d9f883117d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637814064081729898|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=E7eUs6TPrbjl4bt94e0KAuT%2FOHoEvRXE34nFIrRxy0w%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Implement Setting Validation

User Story

As a RS developer updating organization, sender, and receiver settings,
I want validation of the YML,
so that I can avoid mistakes and prevent config issues
Description/Use Case

Idea: Look into using https://pkl-lang.org/index.html (Section III.I in Routing SRD)
See PKL use cases to get a sense of what the library can do. ReportStream should make use of:

Generating Static Configuration - helps validate the settings as they are being written in the YML file by a ReportStream engineer
Application Runtime Configuration - validates the settings during runtime. This can be triggered when setting the settings via CLI or ReportStream website UI.

Risks/Impacts/Considerations

Dev Notes

Acceptance Criteria

[ ] Validation of YML configuration happens in real-time during configuration

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean

@jalbinson to break up/groom ticket further. The ticket right now may be more work than can be done in a single sprint

Hey team! Please add your planning poker estimate with Zenhub @adegolier @jack-h-wang @thetaurean

Please add your planning poker estimate with Zenhub @david-navapbc


.goreleaser.yml: Build for arm and arm64 as well

This should add release binaries for arm v6/v7 and arm64 as well to github so users can install gopass on  arm (e.g. raspberry pi) as well from published releases.

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   66.48%   66.48%
=======================================
  Files         190      190
  Lines       10993    10993
=======================================
  Hits         7308     7308
  Misses       2887     2887
  Partials      798      798

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c62d8...c06e825. Read the comment docs.

Please add a release note to your commit, like: RELEASE_NOTES=[ENHANCEMENT] Add arm and arm64 binaries

Done, thanks I forgot about that!


Sound quality dropped compared to Huggingface

The old version (without Avocodo, without full IPA support) somehow produces better results than the current one.
Hard to say where exactly the quality dropped.
Did anyone notice that? Any hints at finetuning the inference?

For the current version, we are trying out lots of things with the embedding function, that's a pretty major change. New models with an improved embedding function will come soon. Also, I'm not sure if the Avocodo model is actually better than the HiFiGAN model. In theory Avocodo adresses exactly the problems that HiFiGAN had, but the results are mixed.


Update theory.md

Proposed answer to a question related to distributions in price prediction datasets

Could you please add yourself to contributors.md?

I'll add you myself, thank you for your contribution!

 Looking forward to answer more interesting questions.


"FilePicker" crashed when select special folder

When using "FilePicker" to select a folder with a large number of files or a large volume of files, the flet framework suddenly crashes without any output logs or prints

What error do you get?

I also encountered the same issue https://github.com/flet-dev/flet/issues/1562. It does not throw any error at all. It just terminates the program.

What error do you get?

nothing, just crash... I also think it's very strange. It's rare for me to just flash back without throwing any errors.


It is better to remove the background color for the comparison operators box on the view options panel

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240126.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: Exploratory testing
Regression From: Previous release (1.32.1)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Open one blob container -> Open the view options panel.
Select 'Tag Query' -> Observe the comparison operators box.
Check whether the box has no background color.

Expected Experience
The box has no background color.

Actual Experience
The box has a background color.

Additional Context
This issue only reproduces on Light theme.

Verified this issue on the main build 20240130.3. Reproduce. So, we are going to reopen it.

I somehow forgot to publish and integrate the changes.

Verified this issue on the main build 20240130.14. Fixed. So, we are going to close it.


Updating pixi version breaks pixi install

I have the following workflow:
env:
    PIXI_VERSION: 0.5.0
    ....

jobs:
    Test:
        # Use our own self-hosted runner for this
        runs-on: [self-hosted, Linux, X64, ubuntu-22.04]
        steps:
            ...
            - name: Setup pixi
              uses<EMAIL_ADDRESS>              with:
                  pixi-version: v${{ env.PIXI_VERSION }}
                  # Don't use $HOME/.pixi to work around self-runner env issues
                  # https://github.com/prefix-dev/setup-pixi/issues/25
                  pixi-bin-path: ${{ runner.temp }}/bin/pixi
                  cache: true
                  post-cleanup: true

I updated it to use the new release of pixi (0.7.0) and it breaks as follows:
Restoring pixi cache
  Cache Size: ~108 MB (112936695 B)
  /usr/bin/tar -xf /home/github/work/_temp/1c6d344c-c994-48ee-aa1b-cc8e0f6be174/cache.tzst -P -C /home/github/work/Project/Project --use-compress-program unzstd
  Received 112936695 of 112936695 (100.0%), 107.7 MBs/sec
  Cache restored successfully
  Restored cache with key `pixi-linux-64-374cf0d4d1aa8b897059fc7d641107d070f1dafa01ec8a5d5ceeefe4f4f9adb1`
/home/github/work/_temp/bin/pixi install --locked --manifest-path pixi.toml
  × the project location seems to be change from `/home/runner/work/
  │ Project/Project/.pixi` to `/mnt/github/work/Project/
  │ Project/.pixi`, this is not allowed.
  │ Please remove the `.pixi` folder and run again

Hmm, are you sure this has something to do with the version upgrade?
It seems to me that the same cache was used by setup-pixi on both ubuntu-22.04 and self-hosted... These should have different cache keys because they are on different paths and changing the path of an environment breaks this environment.

This is due to a reinstallation after moving the folder. But I have yet to understand why this error occurs in ci. Let me take a look at the workflow.

Ah okay, when this error is a new feature, this error just got uncovered and was there before too :)

Some conda envs don't break when relocated when no shared library paths are replaced in the env but this is not a guarantee so we need to assume that you cannot relocate them.

Should be fixed with<EMAIL_ADDRESS>

Fantastic, thank you!

Awesome Pavel!


alter task is running and won't finished

Describe the bug
alter task is running but won't finished, while execute:
alter table bb_255_demo_focus_in modify column create_date date;

be log like this:
W1008 16:20:09.316119 36809 schema_change.cpp:361] the column type which was altered from was unsupported. from_type=15
root course
the type convert from DATETIME to DATE is not supported becourse of precision loss， and fe forget to add some check


[storage] Rename NVMe -> Nvme

Naming NVMe caused proto to force "nv_me" syntax which is weird
Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

LGTM!


Python (PYNQ-Z1-Board) driver support for custom network

Hi,
Beside this repository there is another FINN repository (BNN-PYNQ) with an overlay driver for the example networks. According to some issues here, it is possible to use the bitstream with the built-in weights in combination with the Python driver by commenting the loading of the parameters in the bnn.py module. So far so good.
Currently I have trained my own network (own topology) with HWGQ-Caffe and processed it with FINN. Currently I have the bitstream and tcl file belonging to the network. With the standard PYNQ classes I can also load these files onto the Zynq of the Z1 board, but without any driver support. In bnn.py dynamic libraries are loaded. I guess I can't use my network with these libraries. Any attempt to use the existing so-files with my own net where unsuccessful.
Can this repo or the BNN-PYNQ repo be used to generate the required dynamic library using the "make-sw.sh" scripts? Is there a way to automatically generate the necessary PYNQ drivers for any network topologies?
If you have any further questions, please do not hesitate to contact me and I look forward to your response.

Hi Chribecht,
The short answer is "yes", but we don't have a lot of documentation at the moment and this will involve lots of manual effort and digging. We're working on a cleaner FINN release with proper documentation and tutorials in the coming months.
If you have modified the topology in terms of how many inputs (e.g. pixels)/outputs (e.g. labels) it has, the prebuilt drivers and host code won't work correctly as you observed. The low-level drivers we use for both this repo and BNN-PYNQ are quite similar, so you should be able to use either. The BNN-PYNQ repo is a bit better organized so that would be my suggestion. You can find the low-level driver here, this gives a lightweight wrapper that lets you do register reads/writes and buffer copies:
https://github.com/Xilinx/BNN-PYNQ/tree/master/bnn/src/library/driver
What we call the "host code" calls the low-level driver and exposes higher level C++ function calls:
https://github.com/Xilinx/BNN-PYNQ/tree/master/bnn/src/library/host
Finally, there's a top-level wrapper that exposes the function calls to Python, which internally calls the host code. All three levels are used by the make-sw.sh to generate the shared libraries.
https://github.com/Xilinx/BNN-PYNQ/blob/master/bnn/src/network/cnvW1A1/sw/main_python.cpp

I'm closing all issues relating to the v.01 version in preparation for the new release. Please note that v0.1 is now deprecated and unsupported.


Fixing access_token test scripts

data.ACCESS_TOKEN in the response is not available, it should be data.access_token in order to set the environment variable correctly.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@macdonst Yes for the rest of the Requests it should be referring to the environment variable and should refer to ACCESS_TOKEN. But here we are setting the ACCESS_TOKEN for the first time.
The API response returns a JSON and there is no ACCESS_TOKEN key. Hence the data.ACCESS_TOKEN returns null value and the environment variable is never set correctly. I have tested this in my local environment and identified as an issue.

Confirmed.  Lower case access_token is used throughout.


Makefile and README updates for sdk 1.0

Fixes #169

make deploy is broken currently, it will only try to deploy into the container-jfr-operator-system namespace and not the current namespace (oc project -q). I'm trying to figure out how to get that to work. The README says it does work in the meantime, anyway.


Add chart legend

Adds chart legend, which is displayed by default, and can be hidden by passing hideLegend. Also adds the ability to pass custom matrix cell colors, using matrixColors

Closes #17

It's fantastic to have the legend. A couple of questions:
Currently, the Clustergrammer will map the value into opacity instead of doing a color gradient map between the positive value and negative value.
This also results in a second problem in the legend. Notice in our case, the min value(0) should not be blue but white.

Good point! I'll work on this and let you know once it's done.

Good point! I'll work on this and let you know once it's done.
@WenheLI done.

The legend should be good to merge now.
I will work on the color gradient tmr.


Improve push

The current push command is great for a POC, but should be pulled apart long term to reduce duplication across other pieces of the system that do similar things (upload source, run pipeline) and comply with the most recent Knative serving spec which has deprecated including build specs as part of the template. Instead, builds should be done first then a K8s reference should be injected into the Serving. See this slide deck for more info.
This will also allow better source-to-container tracing for us for specific revisions which in turn will allow various other commands.
A successful refactor will see:

[x] Pushing sources is independent of push
[x] Creating an instance of a BuildTemplate is independent of push
[ ] A controlled lifecycle on Services allowing us to implement cf commands like run-task, restart and restage

@josephlewis42 In our case, what is the difference of restart and restage?

@poy If I understand what cf is doing, restart should use the same images and restage should build new images.
Restart would basically be a touch on the kservice and restage would be more involved.

So would a rebuild be useful for something like when you have a new version of a buildpack?

Yeah, restage is mostly about re-running the staging job with the most recent variables. Right now for us that's only buildpacks, but operators can also have environment variables they inject into the staging process to configure it more directly.

Do you see a way for a build step to deploy a service? Or are we going to have to provide a container that knows how to do that?

I think we'll need a container to do that. @mattysweeps and I were discussing this last week and think we've come up with a solution.
Right now push takes a bunch of flags and massages them into a service that it builds and deploys. Instead, we're going to use the concept of a singleton app manifest as the parameter.
We start by combining together all the flags and the actual manifest listed in the push command into a single fully populated manifest.
If the manifest is pointing at source code, then the build step executes and we get back a docker image. kf will re-write the manifest to be one that looks like the user entered a docker image instead referencing the newly built one. The deployer will take that fully resolved manifest and create a ksvc from it, in the future it will also bind services, set up routes, etc.
Now we'll have two independent pieces and can turn the deployer into a docker image that can be run independently of push, opening us up to other things like restart.

I think we'll need a container to do that.
This implies we are going to have to start thinking about distribution.

If the manifest is pointing at source code, then the build step executes and we get back a docker image.
When you say docker image, I'm assuming you mean an image that has been built via buildpacks (and not a docker file or something).

Overall I like this approach. It will require us to think about how to distribute the "deployer" container. I think it will also lead the way for us to implement a restage command.

When you say docker image, I'm assuming you mean an image that has been built via buildpacks (and not a docker file or something).

That's correct, I was thinking something that's been built with buildpacks and pushed to a repository.

Overall I like this approach. It will require us to think about how to distribute the "deployer" container. I think it will also lead the way for us to implement a restage command.

The nice thing about ko is that we have the distribution mechanism built-in. We can build the container as an app in our cmd/ directory and reference it in a template in config/ and (theoretically) publish it out that easy and get back a fully qualified YAML config that we can kubectl apply.

The nice thing about ko is that we have the distribution mechanism built-in. We can build the container as an app in our cmd/ directory and reference it in a template in config/ and (theoretically) publish it out that easy and get back a fully qualified YAML config that we can kubectl apply.

That sounds good!

Related PR in Tekton: https://github.com/tektoncd/catalog/pull/34

duplicate #286, #287


Azure functions deployment failed

Does this occur consistently? No
Repro steps:

From "Azure" Extension > Functions window, perform "Deploy to Function App..." command.
In my case, the first attempt (when dpeloying for the first time) succeeded. Second attempt (to update) failed.

Action: azureFunctions.deploy
Error type: 500
Error Message: An error has occurred.
Version: 0.22.1
OS: win32
OS Release: 10.0.18363
Product: Visual Studio Code
Product Version: 1.46.1
Language: en

Call Stack
extension.bundle.js:309:399345extension.bundle.js:309:399345
retryCallback extension.bundle.js:225:114550
retryCallback extension.bundle.js:157:31063
extension.bundle.js:157:32676extension.bundle.js:157:32676
handleRedirect extension.bundle.js:171:7752
extension.bundle.js:157:29848extension.bundle.js:157:29848
Request._callback extension.bundle.js:1:670871
Request.n._callback.n.callback.n.callback extension.bundle.js:201:4483
Request.emit events.js:203:13
Request.<anonymous> extension.bundle.js:201:17592
Request.emit events.js:208:15
IncomingMessage.<anonymous> extension.bundle.js:201:16382
Object.onceWrapper events.js:291:20
IncomingMessage.emit events.js:208:15
endReadableNT _stream_readable.js:1168:12
processTicksAndRejections task_queues.js:77:11

Please add more information about your local project, how you created the function app in Azure, and any logs you see when deploying


Make it runnable in linux

What
Make it less work to run in Linux (and MacOS?). Ie  instead of having to type
python toc.py

to make it work. You can instead type
./toc.py

and if you rename it and put it in your path, you can do
toc

On Linux, you can achieve this with a symlink like this
ln -s $(pwd)/toc.py ~/bin/toc

Notes
I've created 3 separate commits to better show what I've changed, and why. But I'd be happy for this to be squash merged into a single commit if preferred. Or I could rebase it into a single commit, if you prefer.
Nothing in here should be at the detriment to Windows. I'd love for someone who is more up-to-date with Windows to do a similar update for Windows. Maybe a wrapper would be the way to go?

Hi, thanks for your interest, and sorry for the delay
Seems good to me, merging right now.
I will not do any kind of installation process to automatize the symlink in path, I let it up to the users

Awesome. Thanks for including it.


Test quick start

closes #65
It will also make parts of the macro tutorial more readable. Sometimes I want to show the full output, but sometimes it distracts from the point and I only want to show the Lissp definition and I still want it tested.
The solution is the new reST Lissp directive. It's written like a REPL code block, so the normal Sybil doctests work, but when Sphinx renders the output, it only shows the Lissp parts. As a bonus, I've linked to the quickstart source, for anyone who'd prefer to see the output.
Testing uncovered a few issues with the docs, and also a bug in the repl, which have been fixed.
Not all of the quickstart could be tested. A few examples were interactive, and some read and wrote files, but didn't interact well with my test runner. I also skipped the linked-list emulation macros, since I'm probably removing them. Manual testing did uncover an issue with some of that, which has been fixed.

Looks like a new major release of Hypothesis broke my tests. I've pinned my dev requirements.

Looks like a new major release of Hypothesis broke my tests. I've pinned my dev requirements.

I seriously can't import math in my doctests!? What is wrong with this pipeline? It was working locally.

I seriously can't import math in my doctests!? What is wrong with this pipeline? It was working locally.

Codecov Report

Merging #82 (33bb3ba) into master (73848f5) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   89.41%   89.59%   +0.17%
==========================================
  Files           5        5
  Lines         614      615       +1
  Branches       98       98
==========================================
+ Hits          549      551       +2
  Misses         48       48
+ Partials       17       16       -1

Impacted Files
Coverage Δ

src/hissp/repl.py
80.55% <100.00%> (+0.55%)
:arrow_up:

src/hissp/munger.py
97.91% <0.00%> (-2.09%)
:arrow_down:

src/hissp/reader.py
88.88% <0.00%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73848f5...33bb3ba. Read the comment docs.

Codecov Report

Merging #82 (33bb3ba) into master (73848f5) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   89.41%   89.59%   +0.17%
==========================================
  Files           5        5
  Lines         614      615       +1
  Branches       98       98
==========================================
+ Hits          549      551       +2
  Misses         48       48
+ Partials       17       16       -1

Impacted Files
Coverage Δ

src/hissp/repl.py
80.55% <100.00%> (+0.55%)
:arrow_up:

src/hissp/munger.py
97.91% <0.00%> (-2.09%)
:arrow_down:

src/hissp/reader.py
88.88% <0.00%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73848f5...33bb3ba. Read the comment docs.

Hopefully it's just the name as an implementation detail due to the Linux platform and I can still get a tau. I'll try eliding it.

Hopefully it's just the name as an implementation detail due to the Linux platform and I can still get a tau. I'll try eliding it.

That worked. I'll review the changes again tomorrow before merging.

That worked. I'll review the changes again tomorrow before merging.


editorial workflow's "view preview" fails in monorepo

Describe the bug
Clicking on View Preview opens a page that says "Deploy canceled".
Netlify can be configured to create several sites from different folders of the same github repository.  Whenever something is committed to the repo, a build is triggered for each site. If there is no change in one site's folder, the build is canceled.
NetlifyCMS can be used in each of these folders. When the editorial workflow is enabled, saving a change creates a commit on a new branch in the repo. NetlifyCMS then displays a link called Check for Preview link. Clicking on that link asks netlify about the state of the builds triggered by the commit by sending a request like this:
https://website-name.netlify.app/.netlify/git/github/commits/commit-hash/status
The commit triggers a build for each website of the monorepo. When the builds are done, the above request returns a json like this:
{ "state": "success",
  "statuses": [
    { ...
     "description": "Deploy preview canceled.",
      "target_url": [wrong link]
    },
    { ...
      "state": "success",
      "description": "Deploy preview ready!",
      "target_url": [correct link],
    }
  ],
...

NetlifyCMS then displays a link View Preview that points to the target_url of the canceled build, which happens to be on the site that was not modified, instead of the target_url of the modified site which points to a working preview.
To Reproduce
Create a monorepo on github
I'm using the starter kit for eleventy that's mentioned in the NetlifyCMS documentation
You can create the first site from the deploy to netlify button in the readme, but the second site needs to be created with the "new site from git" button on your netlify team's page. (If you create the second one from the button, you can actually change its deploy settings to point to the first repository, but for some reason netlify will continue sending the commits to the second repo.  This is probably good enough to reproduce this bug on the cms of the first site. )
Copy the files at the root into a subfolder for example site1 , and copy site1 to another subfolder site2.
Edit both NetlifyCMS configurations src/admin/config.yml (see my config.yml further down):

add subfolder in front of the paths
enable editorial workflow

Make sure you configure both sites correctly on netlify:

Site settings > Build settings > Base directory
Identity > Enable Identity
Site settings > Identity > Services > Git Gateway > Enable Git Gateway

Once you have both sites running. Log into the admin of one of them, add a blog post, save. Click Check for Preview until it becomes View Preview, which takes you to the wrong place.
Expected behavior
View Preview should link to the correct preview.
Applicable Versions:

Netlify CMS version 2.0.0
Git provider: GitHub
OS: Windows 10
Browser version: Firefox

CMS configuration
This is the configuration for one of the folders, that happens to be called hestia-labs
backend:
  # Use netlify identity as backend
  name: git-gateway
  branch: master
  ### enable below lines for github integration ###
  # name: github
  # repo: surjithctly/neat-starter
media_folder: "hestia-labs/src/static/img"
public_folder: "/static/img"

# Please run "npx netlify-cms-proxy-server" for local backend
local_backend: true
publish_mode: editorial_workflow
collections:
  - label: "Blog"
    name: "blog"
    folder: "hestia-labs/src/posts"
    create: true
    editor:
      preview: false
    fields:
      - { label: "Title", name: "title", widget: "string" }
      - { label: "Description", name: "description", widget: "string" }
      - { label: "Author", name: "author", widget: "string" }
      - { label: "Publish Date", name: "date", widget: "datetime" }
      - { label: "Body", name: "body", widget: "markdown" }
      - widget: select
        label: "tags"
        name: "tags"
        multiple: true
        create: true
        options: ["Tags", "created", "from", "config.yml"]
  - label: "Settings"
    name: "settings"
    editor:
      preview: false
    files:
      - label: "Navigation"
        name: "items"
        file: "hestia-labs/src/_data/navigation.yaml"
        fields:
          - label: Nav Items
            name: items
            widget: list
            allow_add: false
            collapsed: false
            fields:
              - { label: Title, name: text, widget: string }
              - { label: URL, name: url, widget: string }
      - label: "Quick Links"
        name: "links"
        file: "hestia-labs/src/_data/quicklinks.yaml"
        fields:
          - label: Nav Items
            name: links
            widget: list
            collapsed: false
            fields:
              - { label: Title, name: title, widget: string }
              - { label: URL, name: url, widget: string }
              - { label: Description, name: desc, widget: string }
      - label: "Meta Settings"
        name: "settings"
        file: "hestia-labs/src/_data/settings.yaml"
        fields:
          - { label: Name, name: name, widget: string }
          - { label: Author, name: author, widget: string }
          - { label: URL, name: url, widget: string }

The problem probably happens here:
/**
 * Retrieve a deploy preview URL from an array of statuses. By default, a
 * matching status is inferred via `isPreviewContext`.
 */
export function getPreviewStatus(
  statuses: {
    context: string;
    target_url: string;
    state: PreviewState;
  }[],
  previewContext: string,
) {
  return statuses.find(({ context }) => {
    return isPreviewContext(context, previewContext);
  });
}

Any status that has a context that includes the word deploy is considered a preview context.
export function isPreviewContext(context: string, previewContext: string) {
  if (previewContext) {
    return context === previewContext;
  }
  return PREVIEW_CONTEXT_KEYWORDS.some(keyword => context.includes(keyword));
}

Ah maybe I can fix that by configuring the preview_context
https://www.netlifycms.org/docs/github-backend/#specifying-a-status-for-deploy-previews

Ok so now I noticed that drafts created on one site appear on the other and can even be published from there.
I guess NetlifyCMS is not meant for a monorepo.

Hi @andreaskundig configuring the preview context so the CMS knows which URL to use sound like a solid solution to me.
Does you use case involves running 2 different sites with 2 different CMS instances from the same repo?
Have you tried using a different cms_label_prefix per CMS? That might work to get those drafts separated.
See https://www.netlifycms.org/docs/backends-overview/#backend-configuration

Your suggestion actually prevents one site from seeing drafts in the second, but while the second has an unpublished post, the first shows this alert on the workflow page.
Netlify CMS is adding labels to 1 of your Editorial Workflow entries. The "Workflow" tab will be unavailable during this migration. You may use other areas of the CMS during this time. Note that closing the CMS will pause the migration.

This is getting a bit off-topic, but at this point I think it's fair to conclude NetlifyCMS isn't ready yet for running 2 different sites with 2 different CMS instances from the same repo.


Error in facebook bot - message: "...is not a developer type option"

I developed a bot that is integrating with Skype and Facebook Messenger (using C#)
But on Facebook when typing any words, the bot responds "is not a developer type option"
Skype works perfectly.
Why?

It looks like your bot's source code is generating that text "is not a developer type option".  Can you search for it?

@khaueviana, were you able to figure this out? Can this issue be closed?
thanks!

@khaueviana, closing this issue due to inactivity, please feel free to reopen it if you're still having issues. Thanks!


Better solution for COORS and paths

Allow passing through multiple gateways / know how to set reasonable COORS for flask_socketio
Allow hosting at e.g. example.com/wr

coors works and paths isn't that relevant to me anymore.... reopen when there's a need.


New version: QMPlay2.QMPlay2 version 24.06.16

Pull request has been created with komac v2.2.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:
(Automated response - build 886.)


sync with master

[Current coverage][cc-pull] is 100%

Merging [#574][cc-pull] into [v22.1.8][cc-base-branch] will not change coverage

@@           v22.1.8   #574   diff @@
=====================================
  Files           28     28
  Lines          439    439
  Methods        111    111
  Messages         0      0
  Branches         0      0
=====================================
  Hits           439    439
  Misses           0      0
  Partials         0      0

Powered by Codecov. Last updated by [20cbaba...aa19fcd][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/v22.1.8?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/20cbaba0055005cbe2ccf5ab2f66ce77715eb641...aa19fcdb45ba62f0f1b1fea19edce15c2e40b578?src=pr
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/574?src=pr


Signals for Author/CachedAuthor

Signals to prevent update anomalies between Author/CachedAuthor
Minor changes in admin panel to prevent deletion of CachedAuthor
Removal of unused code/imports

Neater solution!
I suspect that you will also be creating CachedAuthor instances on external requests?

Yep. CachedAuthors will be created when a foreign author is added to an Author's following list. Next PR.

Makes sense. How about invalidation or deletion of foreign authors? Or do we just keep them forever and update them on external requests if they exist?

Currently they are being kept forever. I'm not sure how we would go about handling that.

👍


Migrate Deposit and DepositProperties to it's own lib

Since this library centers around operations on Bags, and since this library is likely to be provided to external users, we should move the Deposit and DepositProperties classes to their own library called dans-deposit-lib. This new library will have a dependency on dans-bag-lib for access to the Bag classes.

Part 1: https://github.com/DANS-KNAW/dans-bag-lib/pull/19


Readd secondary nav bar

In the original bokeh and HoloViews theme, there was a secondary nav bar:

This seems to have been removed in this repository, which leads to a rather sterile look:

In my opinion this secondary nav bar adds quite a lot aesthetically and gives each website a distinct feel as long as you add some custom CSS to color it. IMO the top-level nav bar can be reserved for external links, e.g. to GitHub, twitter etc., while the secondary nav bar would be for internal links. What I would be in favor of is dropping the links in the footer.

I think we should have the top bar as external links, the second bar as internal links, and the footer as purely redundant. I have implemented this at datashader.org and am fairly pleased with it. I am going to start working on a new theme that contains these changes.

Looks good, but I think the footer should be minimal in height and just like the top bars, not having a different organization.


HW 14 10 2016 Backend

https://github.com/Garasjuk/EPAMtraning2016/tree/master/BackendApplication

please provide link where i can see all changes in one page

https://github.com/Garasjuk/EPAMtraning2016/commit/80ee042a891fb6f66ca8b96ea88a2417c8ff5d5b


Refactoring: follow happy path: removed else blocks that are not needed

Description
Follow happy path: removed else blocks that are not needed
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.82%. Comparing base (d3076b3) to head (c076cac).
Report is 52 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
+ Coverage   94.75%   94.82%   +0.07%
==========================================
  Files          59       60       +1
  Lines        2631     2669      +38
==========================================
+ Hits         2493     2531      +38
  Misses        138      138

Files with missing lines
Coverage Δ

ols/app/endpoints/health.py
100.00% <100.00%> (ø)

/retest

/retest

/approve

/override "Red Hat Konflux / lightspeed-service-on-pull-request"

/lgtm


M

Hello folks, how are you doing?

@cbalbino-infobip seems that my transfer and your closure happened at the same time. Feel free to reopen if you want to have feedback from the SimSwap sub project.

I´d like to remove this thread from here, is it possible? I don´t see any option

@cbalbino-infobip ok, I will delete it.


The Vaira data link stopped working

Describe the bug
Our Vaira test site in experiments stopped working because the data_link is no longer valid.
We just need to fix the link and add back to buildkite pipeline.yml, but it's not clear exactly what file in box that link pointed to.

It might be a good time to move to using artifacts.
In the meantime, I think we can disable the test, as in bb2a3312238ed39caad4c045180f034c9e206ced


Updated pictures and title to reflect Spronzi's mobile nature

for: https://github.com/spronzi/spronzi.github.io/issues/3

Added place holder Portland post that includes nice skyline picture
Added truck cab picture to Road Rants page

Thanks.  Merged and now live on the site.


Added dashboard controller

Added the dashboard controller to start adding in widgets for testing - put in some placeholder divs and css necessary to build.
After this is merged I will rebase and integrate the Search widget which uses the question and response set widgets, this is just the baseline, not all of the css from eny's WIP branch was added.
Make sure you have checked off the following before you issue your Pull Request:

[x] Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
[n/a] Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
[n/a] If any database changes were made, run rake generate_erd to update the README.md

Looks good, even found something I need to fix in my own branch.


How to use results (e.g. minio or aws s3)

As described here Results,I don't really understand, is there a sample yaml file for reference
`Tekton Results aims to help users logically group CI/CD workload history and separate out long term result storage away from the Pipeline controller. This allows you to:
Provide custom Result metadata about your CI/CD workflows not available in the Tekton TaskRun/PipelineRun CRDs (for example: post-run actions)
Group related workloads together (e.g. bundle related TaskRuns and PipelineRuns into a single unit)
Make long-term result history independent of the Pipeline CRD controller, letting you free up etcd resources for Run execution.
Store logs produced by the TaskRuns/PipelineRuns so that completed Runs can be cleaned to save resources.`

@ForcemCS The documentation currently does not include examples for using minio/S3, but you can have a look here https://github.com/openshift-pipelines/pipeline-service/tree/main/operator/gitops/argocd/pipeline-service/tekton-results , specifically https://github.com/openshift-pipelines/pipeline-service/blob/main/operator/gitops/argocd/pipeline-service/tekton-results/api-s3-config.yaml where the S3 configuration is set using env variables (you can also use the api config  https://github.com/openshift-pipelines/pipeline-service/blob/main/operator/gitops/argocd/pipeline-service/tekton-results/config.env to set those). Here is how we create the minio (S3) bucket https://github.com/openshift-pipelines/pipeline-service/tree/main/developer/openshift/gitops/argocd/pipeline-service/tekton-results.
HTH


Do not set MTU size on vNIC of VM

Hi,
is it somehow possible to not set the MTU size on a vNIC?
Netbox-sync grabs the MTU size from the vSwitch, when I'm not completely wrong.
We have a different MTU setting in the VM (1500), which often is not the same as on the vSwitch (9000).

Hi,
currently it I not possible to switch this setting on and off.
Would it help to add a config setting to disable this functionality?
This setting would apply for the whole configured vCenter.

Hi,
yes, a setting in the config would be good. Already searched where I can put it, but didn't find the part.

Hi,
just pushed a commit to the development branch. Can you check it out and test if this solves your issue?

Hi,
this seems to work.
Thank you.

Great, thank you for testing it. Hope to release the new version soon.


frictionless native browser scrolling, can you show example please?

If you're referring to the word 'frictionless', it is just a term used to describe the scrolling effect that is without easing or friction.
Examples can her found here -
http://malte-wessel.github.io/react-custom-scrollbars/


Fixed IPv6 SocketFamily with wrong value on MacOS and Windows

This is a fix for https://github.com/gtk-rs/sys/issues/178 .

Added a "manual" override for Gio.SocketFamily in conf/gir-gio.toml
Added the appropriate values (using libc) in gio-sys/src/manual.rs. The values for AF_INVALID and AF_UNIX are specified as integers as the corresponding values are not exported as constants in libc; that said, I've checked and their values are 0 and 1 in Windows, MacOS and Linux and, I presume, pretty much every other OS being the two earliest values
Regenerated gio-sys/src/lib.rs accordingly (also included in the PR)

Converted to draft after CI failed.

I think I fixed the build of this (I hoped I could get away without setting up a windows machine with gvsbuild but... no I couldn't :) ).
Now the CI failing in code which is outside of the scope of this PR (apparently glib::timeout_add_local changed from taking an integer to std::time::Duration); is this something known or a weird side effect of the PR changes?

Now the CI failing in code which is outside of the scope of this PR (apparently glib::timeout_add_local changed from taking an integer to std::time::Duration); is this something known or a weird side effect of the PR changes?

That's fixed by https://github.com/gtk-rs/examples/pull/325 . Sorry for that!

Cool thank you. Tomorrow I'll rebase, add the other two enums and undraft it.

Great, thanks for your work on this :)

I checked the sources of gioenums.h and I'm not so convinced anymore that moving (all) the other enums is a good idea (or, at the very least, every single case seems to have it's own nuances :( ).
Below is a summary of socket related enums, but TL;DR:

GSocketFamily needs to be fixed because AF_INET6 is different from OS to OS. This PR now has a manual override for this.
GSocketMsgFlags can be ported to use platform dependent constants, even though all the OSs use the same values for those 4 ints. This PR now has a manual override for this.
GSocketProtocol and GSocketType are probably best left untouched; details below.

If the CI says its "ok", I'll undraft this.

GSocketFamily
GSocketFamily is clearly defined to use system values, so I think what we've done so far is good:
typedef enum {
  G_SOCKET_FAMILY_INVALID,
  G_SOCKET_FAMILY_UNIX = GLIB_SYSDEF_AF_UNIX,
  G_SOCKET_FAMILY_IPV4 = GLIB_SYSDEF_AF_INET,
  G_SOCKET_FAMILY_IPV6 = GLIB_SYSDEF_AF_INET6
} GSocketFamily;

GSocketMsgFlags
GSocketMsgFlags is another case where there are platform specific values:
typedef enum /*< flags >*/
{
  G_SOCKET_MSG_NONE,
  G_SOCKET_MSG_OOB = GLIB_SYSDEF_MSG_OOB,
  G_SOCKET_MSG_PEEK = GLIB_SYSDEF_MSG_PEEK,
  G_SOCKET_MSG_DONTROUTE = GLIB_SYSDEF_MSG_DONTROUTE
} GSocketMsgFlags;

So I added GSocketMsgFlags to the PR.
GSocketType
GSocketType is defined, on the other hand, to use consecutive values, and there are a few switch statements in gsocket.c on the specific values so it's better left as is:
typedef enum
{
  G_SOCKET_TYPE_INVALID,
  G_SOCKET_TYPE_STREAM,
  G_SOCKET_TYPE_DATAGRAM,
  G_SOCKET_TYPE_SEQPACKET
} GSocketType;

GSocketProtocol
Finally, GSocketProtocol is a mixed bag; it uses hardwired values in gioenums.h which are afaict technically platform specific values; apparently, though, all the platforms I have checked (Linux, Windows, MacOS and FreeBSD) have the same values, so glib gets away with it. There are no switch statements, but the hardwired values are used when dispatching G_SOCKET_PROTOCOL_DEFAULT.  I'd rather leave them with the numeric values they got from parsing gioenums.h.
typedef enum {
  G_SOCKET_PROTOCOL_UNKNOWN = -1,
  G_SOCKET_PROTOCOL_DEFAULT = 0,
  G_SOCKET_PROTOCOL_TCP     = 6,
  G_SOCKET_PROTOCOL_UDP     = 17,
  G_SOCKET_PROTOCOL_SCTP    = 132
} GSocketProtocol;

On the two CI failures:
One is due to make making automated modifications to Cargo.toml files. Most of them are added/removed newlines, but one is odd:
diff --git a/gdkx11-sys/Cargo.toml b/gdkx11-sys/Cargo.toml
index 427c997..ff5c931 100644
--- a/gdkx11-sys/Cargo.toml
+++ b/gdkx11-sys/Cargo.toml
@@ -62,4 +62,4 @@ tempfile = "3"
 v3_16 = []
 v3_24 = ["v3_16"]
 v3_24_2 = ["v3_24", "cairo"]
-dox = ["v3_24_2", "cairo"]
+dox = []

I can definitely commit the autogenerated Cargo.toml files, but I am bit worried by the above change (I lack the context to evaluate it properly).
The other CI failure might have been an http transfer error in curl? The file size is wildly different when I try the same commands locally:
$ curl -LO https://github.com/EPashkin/gtk-bootstrap/releases/download/gtk-3.24.0-1/deps.txz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   634  100   634    0     0    762      0 --:--:-- --:--:-- --:--:--   762
100 33.9M  100 33.9M    0     0   355k      0  0:01:37  0:01:37 --:--:--  361k

Below is a summary of socket related enums, but TL;DR:

I agree with that, thanks for investigating :tada:

On the two CI failures:

These also fail in master apparently, so unrelated to what you did here and need to be investigated independently :)

On the two CI failures:

These also fail in master apparently, so unrelated to what you did here and need to be investigated independently :)

I think a fix on the toml-rs crate was released, which now adds the previously missing empty lines. If so, that'd be so cool!

Merging then. Thanks!

Thanks to you both!

I'll do a bugfix release for this later/tomorrow


modules not found or imported?

Pete, this is a noobie breakdown. I followed the instructions in the Readme.md and the first time I ran mwb.py it failed on "No module name 'yaml'" error. So I installed pyyaml using pip3 and then got a "No module named 'jinja2'" error.
So there is some prerequisites that I need to take care of before running mwb.py. Or my python setup isn't correct. Or both. Or even more ....
One other thing, I am running in a venv and the version of python running there is 3.9.4.
Any suggestions?

Thanks, Bill.
Assuming you've activated your venv, then you need to do this before running MWB:
pip install -r requirements.txt

(Sometimes that would be pip3, but if the venv is set up correctly, pip should work.)
Sort of a side note:
Usually, I like the venv to be in the same directory as the app, and that would totally work with MWB, putting a venv in .massivewikibuilder.
However, I actually have the main MWB repo somewhere else on my computer, and I activate the venv there, and then run mwb.py in .massivewikibuilder.
Either way works.

Thanks for the response and further suggestions about how to use venv in a sensible way.
installing requirements.txt seemed to work.

i've added a small to-do note in README.md, "(remember to pip install -r requirements.txt)"
with that, i'll close this issue.


Allow useGitCommitId in mavenLike mode

One classic problem of maven is the inability to understand which version is currently deployed in a system when a SNAPSHOT is used.
One potential solution would be to use useGitCommitId but it is ignored when mavenLike mode is true.
The alternative approach, to not to use the mavenLike mode, is not ideal as the -SNAPSHOT suffix has special connotations in maven and cannot be replaced by the non-configurable word dirty.

@vromero sorry but I do not understand what you want to achieve. If you want jgitver to add the commitId (which is unique) in the version as a qualifier then why should you append SNAPSHOT to that?
If you want uniqueness just do not use mavenLike. Did I miss something?

Hi @McFoggy thanks for the quick reply,
You are right I could just not use mavenLike but -SNAPSHOT has special semantics in Maven (specially repository wise, to maintain them small and tidy; also for instance to make sure that proxies and mirrors are not overly caching the -SNAPSHOTS as anything without that clasifier will be considered a release that wont change).
I tried with mavenLike as false but the best I can get is a -dirty that doesn't enable the special semantics repository side. That is why I propose to enable useGitCommitId in mavenLine mode.
Although I might be wrong? Perhaps maven repositories won't detect two classifiers -asdf2134-SNAPSHOT?

feel free to reopen on purpose.
Although see #33 that could be of some benefits for your use case.

33# indeed superseeds this issue


Validators clean up todo list

[x] in place of penalty ranking, add stake status "Staked, Cool Down, Unstaked"
[x] in the kebab menu of Hotspots and Validators, add "Copy Owner Address"
[x] on tap of the little pills above the validator name, using the "needs attention" component, show what each pill means.

"Validator Version"
"Blocks since the last heartbeat transaction"
"Penalty Score"

[x] add icons next to search results to indicate if it's a validator or hotspot
[x] add introductory text in CG view. make sure to use the consensus group chain var

nice stuff


Get-ChildItem fails on Junction/Symlink when it points to an UNC directory

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Create Symlink or Junction using an UNC (i.e. \my-pc\volume1) as the target. Using any tool: (junction.exe, mklink.exe, New-Item) .
Example:
C:\> Junction -s TestLink  \\my-pc\volume1\users\me\TestFolder
C:\> cd TestLink
C:\TestLink> dir                                   <-fails - Incorrect Parameter Error
_Get-ChildItem: The parameter is incorrect. : 'C:\Users\ThatM\Offline'                     <--Error_
C:\TestLink> Get-ChildItem *.*                          <-fails

Any Get-ChildItem call to the Junction/SymLink will fail with same error, example:
Get-Children C:\TestLink\                    <-fails
Even though Get-ChildItem cannot list the Items in the Junction/SymLink, it can set location to any child folder. Example:
C:\> cd TestLink
C:\TestLink> cd TestSub
C:\TestLink\TestSub> Get-ChildItem *.*                     -works in child folder of Link, but not in C:\TestLink

I tried a bunch of other Powershell commands to see if they would fail, and it is only Get-ChildItem that is broken.
i.e. Get-Item works inside the C:\TestLink folder.
Additional Info:
Get-ChildItem with targets that use drive letters (C:\LocalLink -> C:\Users) work as expected. It is only a UNC target that causes Get-ChildItem to fail and it doesn't matter if it points to the local system or another PC.  (C:\TestLink -> \\my-pc\volume1\TestFolder) [fail]    (C:\TestLink -> \\server-pc\volume1\TestFolder) [fail]
This is a fairly new bug, as this used to work just fine a month or more ago.  Get-ChildItem in Windows Powershell works just fine with Junction/SymLinks to an UNC directory.
To be complete and clear, it is only 7.x of Powershell, and it is only Get-ChildItem.
(Could be any 7.x point release - I wish I had noticed earlier.)
Everything else works with these Junction/Symlinks, i.e.: CMD, Explorer, C# Code, C++ NTFS Calls.
This is kind of a big break/issue, as Symbolic Links that point to an UNC are used a lot in Enterprise and IT realms - things that go back to 1999, like Profile locations, Shell Folders, etc.
Expected behavior
PS C:\>  ni -type SymbolicLink MyLinkFolder \\my-pc\volume2\MyStuff
PS C:\> cd MyLinkFolder
PS C:\MyLinkFolder> dir *.*

    Directory: C:\MyLinkFolder

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----            3/7/2023  3:10 AM                My Sub Folder
d----           3/18/2023 10:04 PM                coding101.txt
d----           3/18/2023  9:31 PM                CoolApp.exe

PS C:\MyLinkFolder>

Actual behavior
PS C:\> ni -type SymbolicLink MyLinkFolder \\my-pc\volume2\MyStuff
PS C:\> cd MyLinkFolder
PS C:\MyLinkFolder> dir *.*
Get-ChildItem: The parameter is incorrect. : 'C:\MyLinkFolder'
PS C:\MyLinkFolder>

Error details
Get-ChildItem: The parameter is incorrect. : 'C:\MyLinkFolder'

Environment data
PS C:\Users\Me> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.3
PSEdition                      Core
GitCommitId                    7.3.3
OS                             Microsoft Windows 10.0.22624
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

This seems to be working in the daily build.  Looking at the error details:
Exception             :
    Type       : System.IO.IOException
    TargetSite :
        Name          : CreateDirectoryHandle
        DeclaringType : System.IO.Enumeration.FileSystemEnumerator`1[TResult]
        MemberType    : Method
        Module        : System.Private.CoreLib.dll
    Message    : The parameter is incorrect. : 'C:\Users\slee\test\testlink'
    Source     : System.Private.CoreLib
    HResult    : -2147024809
    StackTrace :
   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)
   at System.IO.Enumeration.FileSystemEnumerableFactory.DirectoryInfos(String directory, String expression, EnumerationOptions options, Boolean isNormalized)
   at System.IO.DirectoryInfo.InternalEnumerateInfos(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at System.IO.DirectoryInfo.EnumerateDirectories()
   at Microsoft.PowerShell.Commands.FileSystemProvider.Dir(DirectoryInfo directory, Boolean recurse, UInt32 depth, Boolean nameOnly, ReturnContainers returnContainers, InodeTracker tracker)
TargetObject          : C:\Users\slee\test\testlink
CategoryInfo          : ReadError: (C:\Users\slee\test\testlink:String) [Get-ChildItem], IOException
FullyQualifiedErrorId : DirIOError,Microsoft.PowerShell.Commands.GetChildItemCommand
InvocationInfo        :
    MyCommand        : Get-ChildItem
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 4
    Line             : dir testlink
    Statement        : dir testlink
    PositionMessage  : At line:1 char:1
                       + dir testlink
                       + ~~~~~~~~~~~~
    InvocationName   : dir
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :

The problem was in an underlying .NET API, and it appears to have been fixed and would show up in next 7.4 preview.

Confirming that it is fixed.
I am such a goof; when I didn't find a reference to the bug, I never thought to check the current builds.
-Thank you for taking time to check it out.


Linptech ES1 support missing

Alex,
please add support for Linptech ES1 occupancy sensor
https://home.miot-spec.com/spec/linp.sensor_occupy.hb01
some logs atached
es1.log

Hello! I had the same issue. You need to update the MiHome app to the latest version. There is support for this presence sensor in the xiaomi gateway 3.

And need China region

it's not about his sensor support in mihome (which is ok). its sbout Alex component to suport the sensor already added to mihome.

closing this on as device appeared in HA after number of HA restarts


Error when installing package on MacOS

Not sure if this is a known issue but wanted to raise it just in case:
⚡•100% ➜ python3 -m pip install certstream
Defaulting to user installation because normal site-packages is not writeable
Collecting certstream
  Using cached certstream-1.11.tar.gz (9.5 kB)
    ERROR: Command errored out with exit status 1:
     command: /Applications/Xcode.app/Contents/Developer/usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/pip-install-d8u3jrh3/certstream/setup.py'"'"'; __file__='"'"'/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/pip-install-d8u3jrh3/certstream/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/pip-pip-egg-info-pabbyqkp
         cwd: /private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/pip-install-d8u3jrh3/certstream/
    Complete output (157 lines):
    Traceback (most recent call last):
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 172, in run
        cmd = self.call_command('install_lib', warn_dir=0)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 158, in call_command
        self.run_command(cmdname)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/install_lib.py", line 15, in run
        self.byte_compile(outfiles)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/command/install_lib.py", line 132, in byte_compile
        byte_compile(files, optimize=0,
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/util.py", line 466, in byte_compile
        compile(file, cfile, dfile)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/py_compile.py", line 157, in compile
        os.makedirs(dirname)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/os.py", line 213, in makedirs
        makedirs(head, exist_ok=exist_ok)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/os.py", line 213, in makedirs
        makedirs(head, exist_ok=exist_ok)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/os.py", line 213, in makedirs
        makedirs(head, exist_ok=exist_ok)
      [Previous line repeated 1 more time]
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/os.py", line 223, in makedirs
        mkdir(name, mode)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 310, in wrap
        path = self._remap_input(name, path, *args, **kw)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 452, in _remap_input
        self._violation(operation, os.path.realpath(path), *args, **kw)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 407, in _violation
        raise SandboxViolation(operation, args, kw)
    setuptools.sandbox.SandboxViolation: SandboxViolation: mkdir('/Users/nexxai/Library/Caches/com.apple.python/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu', 511) {}

    The package setup script has attempted to modify files on your system
    that are not within the EasyInstall build area, and has been aborted.

    This package cannot be safely installed by EasyInstall, and may not
    support alternate installation locations even if you run its setup
    script by hand.  Please inform the package's author and the EasyInstall
    maintainers to find out if a fix or workaround is available.

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 154, in save_modules
        yield saved
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 195, in setup_context
        yield
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 250, in run_setup
        _execfile(setup_script, ns)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 45, in _execfile
        exec(code, globals, locals)
      File "/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu/termcolor-1.1.0/setup.py", line 37, in <module>
        "Topic :: Security :: Cryptography",
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/core.py", line 163, in setup
        raise SystemExit("error: " + str(msg))
    SystemExit: error: SandboxViolation: mkdir('/Users/nexxai/Library/Caches/com.apple.python/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu', 511) {}

    The package setup script has attempted to modify files on your system
    that are not within the EasyInstall build area, and has been aborted.

    This package cannot be safely installed by EasyInstall, and may not
    support alternate installation locations even if you run its setup
    script by hand.  Please inform the package's author and the EasyInstall
    maintainers to find out if a fix or workaround is available.

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1144, in run_setup
        run_setup(setup_script, args)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 253, in run_setup
        raise
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/contextlib.py", line 131, in __exit__
        self.gen.throw(type, value, traceback)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 195, in setup_context
        yield
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/contextlib.py", line 131, in __exit__
        self.gen.throw(type, value, traceback)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 166, in save_modules
        saved_exc.resume()
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 141, in resume
        six.reraise(type, exc, self._tb)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/_vendor/six.py", line 685, in reraise
        raise value.with_traceback(tb)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 154, in save_modules
        yield saved
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 195, in setup_context
        yield
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 250, in run_setup
        _execfile(setup_script, ns)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/sandbox.py", line 45, in _execfile
        exec(code, globals, locals)
      File "/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu/termcolor-1.1.0/setup.py", line 37, in <module>
        "Topic :: Security :: Cryptography",
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/core.py", line 163, in setup
        raise SystemExit("error: " + str(msg))
    SystemExit: error: SandboxViolation: mkdir('/Users/nexxai/Library/Caches/com.apple.python/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu', 511) {}

    The package setup script has attempted to modify files on your system
    that are not within the EasyInstall build area, and has been aborted.

    This package cannot be safely installed by EasyInstall, and may not
    support alternate installation locations even if you run its setup
    script by hand.  Please inform the package's author and the EasyInstall
    maintainers to find out if a fix or workaround is available.

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/pip-install-d8u3jrh3/certstream/setup.py", line 15, in <module>
        setup(
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/__init__.py", line 144, in setup
        _install_setup_requires(attrs)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/__init__.py", line 139, in _install_setup_requires
        dist.fetch_build_eggs(dist.setup_requires)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/dist.py", line 716, in fetch_build_eggs
        resolved_dists = pkg_resources.working_set.resolve(
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/pkg_resources/__init__.py", line 780, in resolve
        dist = best[req.key] = env.best_match(
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1065, in best_match
        return self.obtain(req, installer)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1077, in obtain
        return installer(requirement)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/dist.py", line 786, in fetch_build_egg
        return cmd.easy_install(req)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 679, in easy_install
        return self.install_item(spec, dist.location, tmpdir, deps)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 705, in install_item
        dists = self.install_eggs(spec, download, tmpdir)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 890, in install_eggs
        return self.build_and_install(setup_script, setup_base)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1158, in build_and_install
        self.run_setup(setup_script, setup_base, args)
      File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1146, in run_setup
        raise DistutilsError("Setup script exited with %s" % (v.args[0],))
    distutils.errors.DistutilsError: Setup script exited with error: SandboxViolation: mkdir('/Users/nexxai/Library/Caches/com.apple.python/private/var/folders/dv/pj9mc1x10sdbffw03jh28bsr0000gn/T/easy_install-4ec8qpyu', 511) {}

    The package setup script has attempted to modify files on your system
    that are not within the EasyInstall build area, and has been aborted.

    This package cannot be safely installed by EasyInstall, and may not
    support alternate installation locations even if you run its setup
    script by hand.  Please inform the package's author and the EasyInstall
    maintainers to find out if a fix or workaround is available.

    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

~/Library/Caches took 2s
⚡•100% ➜

For the record, I was able to clone the repo and install it manually.  It just seems like an issue with the package at pip maybe?

the 1.11 package installed fine inside a virtual environment: cd venv && source ./bin/activate && pip install certstream

Closing since this seems like a transient issue with your environment specifically.


Some documentation for _onMetadata

Writing documentation to understand webtorrent ^^

All suggestions open

Thanks for sending this in. This PR has a few problems:

The tests don't pass. Run npm test to make sure your changes don't break any of the tests.
I prefer succinct inline comments. If you wanted to move some of what you wrote into those, that would be fine.
You also changed some code, so the PR name is misleading. I think this probably introduces a bug.

Thanks for responding :)
Sorry about the tests, pushed it at like 2 am and forgot about them since i had copy pasted from github , appareantly it put some github gibberish into it ^^ last test only required newlines at the end.
About the comments, yeah whatever you like, I wrote it to understand webtorrent better, so perhaps I can contribute in some larger things rather than minor bugfixes :)
And about the code change, the PR is name is misleading indeed sorry about that, but the code change itself is valid, you don't need to check if the object exists if you are checking a property on it.
The following values are always falsy:
false
0 (zero)
"" (empty string)
null
undefined
NaN (a special Number value meaning Not-a-Number!)