Synthesis failed for nodejs-vision

Hello! Autosynth couldn't regenerate nodejs-vision. :broken_heart:
Here's the output from running synth.py:
b'> Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\nDEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\n2020-06-05 04:43:51,203 synthtool [DEBUG] > Pulling Docker image: gapic-generator-typescript:latest\nDEBUG:synthtool:Pulling Docker image: gapic-generator-typescript:latest\nlatest: Pulling from gapic-images/gapic-generator-typescript\nDigest: sha256:c9bc12024eddcfb94501627ff5b3ea302370995e9a2c9cde6b3317375d7e7b66\nStatus: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest\n2020-06-05 04:43:52,099 synthtool [DEBUG] > Generating code for: google/cloud/vision/v1.\nDEBUG:synthtool:Generating code for: google/cloud/vision/v1.\n2020-06-05 04:43:52,998 synthtool [DEBUG] > Wrote metadata to synth.metadata.\nDEBUG:synthtool:Wrote metadata to synth.metadata.\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__\n    return self.main(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main\n    rv = self.invoke(ctx)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke\n    return ctx.invoke(self.callback, **ctx.params)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke\n    return callback(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main\n    spec.loader.exec_module(synth_module)  # type: ignore\n  File "<frozen importlib._bootstrap_external>", line 678, in exec_module\n  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n  File "/home/kbuilder/.cache/synthtool/nodejs-vision/synth.py", line 39, in <module>\n    extra_proto_files=[\'google/cloud/common_resources.proto\'],\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 66, in typescript_library\n    return self._generate_code(service, version, "typescript", **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 195, in _generate_code\n    f"Code generation seemed to succeed, but {output_dir} is empty."\nRuntimeError: Code generation seemed to succeed, but /tmpfs/tmp/tmpaqizry3z is empty.\n2020-06-05 04:43:53,040 autosynth [ERROR] > Synthesis failed\n2020-06-05 04:43:53,040 autosynth [DEBUG] > Running: git reset --hard HEAD\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 04:43:53,046 autosynth [DEBUG] > Running: git checkout autosynth-self\nSwitched to branch \'autosynth-self\'\n2020-06-05 04:43:53,052 autosynth [ERROR] > Command \'[\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\' returned non-zero exit status 1.\n2020-06-05 04:43:53,189 autosynth [DEBUG] > Running: git checkout d6b10b8e386461cdd6427b69679c89921c125435\nNote: checking out \'d6b10b8e386461cdd6427b69679c89921c125435\'.\n\nYou are in \'detached HEAD\' state. You can look around, make experimental\nchanges and commit them, and you can discard any commits you make in this\nstate without impacting any branches by performing another checkout.\n\nIf you want to create a new branch to retain commits you create, you may\ndo so (now or later) by using -b with the checkout command again. Example:\n\n  git checkout -b <new-branch-name>\n\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 04:43:53,194 autosynth [DEBUG] > Running: git checkout d53a5b45c46920932dbe7d0a95e10d8b58933dae\nPrevious HEAD position was be74d3e build: do not fail builds on codecov errors (#528)\nHEAD is now at d53a5b4 docs: improve README (#600)\n2020-06-05 04:43:53,210 autosynth [DEBUG] > Running: git checkout cd804bab06e46dd1a4f16c32155fd3cddb931b52\nPrevious HEAD position was 7683d068 Add sandbox_tmpfs_path parameter by defaul in .bazelrc file. This is to avoid sporadic SIGBUS JVM crashes on highly parallel builds (like our CI). More details at https://github.com/bazelbuild/bazel/issues/3236\nHEAD is now at cd804bab docs: cleaned docs for the Agents service and resource.\n2020-06-05 04:43:53,277 autosynth [DEBUG] > Running: git branch -f autosynth-102\n2020-06-05 04:43:53,281 autosynth [DEBUG] > Running: git checkout autosynth-102\nSwitched to branch \'autosynth-102\'\n2020-06-05 04:43:53,286 autosynth [INFO] > Running synthtool\n2020-06-05 04:43:53,286 autosynth [INFO] > [\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\n2020-06-05 04:43:53,288 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata synth.metadata synth.py --\n2020-06-05 04:43:53,495 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/nodejs-vision/synth.py.\nOn branch autosynth-102\nnothing to commit, working tree clean\n2020-06-05 04:43:53,627 synthtool [DEBUG] > Ensuring dependencies.\nDEBUG:synthtool:Ensuring dependencies.\n2020-06-05 04:43:53,632 synthtool [DEBUG] > Cloning googleapis.\nDEBUG:synthtool:Cloning googleapis.\n2020-06-05 04:43:53,633 synthtool [DEBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\nDEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\n2020-06-05 04:43:53,637 synthtool [DEBUG] > Pulling Docker image: gapic-generator-typescript:latest\nDEBUG:synthtool:Pulling Docker image: gapic-generator-typescript:latest\nlatest: Pulling from gapic-images/gapic-generator-typescript\nDigest: sha256:c9bc12024eddcfb94501627ff5b3ea302370995e9a2c9cde6b3317375d7e7b66\nStatus: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest\n2020-06-05 04:43:54,507 synthtool [DEBUG] > Generating code for: google/cloud/vision/v1.\nDEBUG:synthtool:Generating code for: google/cloud/vision/v1.\n2020-06-05 04:43:55,303 synthtool [DEBUG] > Wrote metadata to synth.metadata.\nDEBUG:synthtool:Wrote metadata to synth.metadata.\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__\n    return self.main(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main\n    rv = self.invoke(ctx)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke\n    return ctx.invoke(self.callback, **ctx.params)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke\n    return callback(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main\n    spec.loader.exec_module(synth_module)  # type: ignore\n  File "<frozen importlib._bootstrap_external>", line 678, in exec_module\n  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n  File "/home/kbuilder/.cache/synthtool/nodejs-vision/synth.py", line 39, in <module>\n    extra_proto_files=[\'google/cloud/common_resources.proto\'],\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 66, in typescript_library\n    return self._generate_code(service, version, "typescript", **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 195, in _generate_code\n    f"Code generation seemed to succeed, but {output_dir} is empty."\nRuntimeError: Code generation seemed to succeed, but /tmpfs/tmp/tmp4bfyzsk5 is empty.\n2020-06-05 04:43:55,343 autosynth [ERROR] > Synthesis failed\n2020-06-05 04:43:55,344 autosynth [DEBUG] > Running: git reset --hard HEAD\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 04:43:55,349 autosynth [DEBUG] > Running: git checkout autosynth\nSwitched to branch \'autosynth\'\n2020-06-05 04:43:55,355 autosynth [DEBUG] > Running: git clean -fdx\nRemoving __pycache__/\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 615, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 476, in main\n    return _inner_main(temp_dir)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 595, in _inner_main\n    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 371, in synthesize_loop\n    synthesize_inner_loop(toolbox, synthesizer)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 381, in synthesize_inner_loop\n    synthesizer, len(toolbox.versions) - 1\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 266, in synthesize_version_in_new_branch\n    synthesizer.synthesize(synth_log_path, self.environ)\n  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 119, in synthesize\n    synth_proc.check_returncode()  # Raise an exception.\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode\n    self.stderr)\nsubprocess.CalledProcessError: Command \'[\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\' returned non-zero exit status 1.\n'

Google internal developers can see the full log here.

Autosynth is still having trouble generating nodejs-vision. :sob:
Here's the output from running synth.py:
b'EBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\nDEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\n2020-06-05 10:36:30,718 synthtool [DEBUG] > Pulling Docker image: gapic-generator-typescript:latest\nDEBUG:synthtool:Pulling Docker image: gapic-generator-typescript:latest\nlatest: Pulling from gapic-images/gapic-generator-typescript\nDigest: sha256:c9bc12024eddcfb94501627ff5b3ea302370995e9a2c9cde6b3317375d7e7b66\nStatus: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest\n2020-06-05 10:36:31,670 synthtool [DEBUG] > Generating code for: google/cloud/vision/v1.\nDEBUG:synthtool:Generating code for: google/cloud/vision/v1.\n2020-06-05 10:36:32,626 synthtool [DEBUG] > Wrote metadata to synth.metadata.\nDEBUG:synthtool:Wrote metadata to synth.metadata.\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__\n    return self.main(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main\n    rv = self.invoke(ctx)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke\n    return ctx.invoke(self.callback, **ctx.params)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke\n    return callback(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main\n    spec.loader.exec_module(synth_module)  # type: ignore\n  File "<frozen importlib._bootstrap_external>", line 678, in exec_module\n  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n  File "/home/kbuilder/.cache/synthtool/nodejs-vision/synth.py", line 39, in <module>\n    extra_proto_files=[\'google/cloud/common_resources.proto\'],\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 66, in typescript_library\n    return self._generate_code(service, version, "typescript", **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 195, in _generate_code\n    f"Code generation seemed to succeed, but {output_dir} is empty."\nRuntimeError: Code generation seemed to succeed, but /tmpfs/tmp/tmpu_2_yi3w is empty.\n2020-06-05 10:36:32,670 autosynth [ERROR] > Synthesis failed\n2020-06-05 10:36:32,671 autosynth [DEBUG] > Running: git reset --hard HEAD\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 10:36:32,676 autosynth [DEBUG] > Running: git checkout autosynth-self\nSwitched to branch \'autosynth-self\'\n2020-06-05 10:36:32,682 autosynth [ERROR] > Command \'[\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\' returned non-zero exit status 1.\n2020-06-05 10:36:32,831 autosynth [DEBUG] > Running: git checkout d6b10b8e386461cdd6427b69679c89921c125435\nNote: checking out \'d6b10b8e386461cdd6427b69679c89921c125435\'.\n\nYou are in \'detached HEAD\' state. You can look around, make experimental\nchanges and commit them, and you can discard any commits you make in this\nstate without impacting any branches by performing another checkout.\n\nIf you want to create a new branch to retain commits you create, you may\ndo so (now or later) by using -b with the checkout command again. Example:\n\n  git checkout -b <new-branch-name>\n\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 10:36:32,836 autosynth [DEBUG] > Running: git checkout d53a5b45c46920932dbe7d0a95e10d8b58933dae\nPrevious HEAD position was be74d3e build: do not fail builds on codecov errors (#528)\nHEAD is now at d53a5b4 docs: improve README (#600)\n2020-06-05 10:36:32,853 autosynth [DEBUG] > Running: git checkout 40a354b0f47454be4986f9db504cca4d4371c8c3\nPrevious HEAD position was 7683d068 Add sandbox_tmpfs_path parameter by defaul in .bazelrc file. This is to avoid sporadic SIGBUS JVM crashes on highly parallel builds (like our CI). More details at https://github.com/bazelbuild/bazel/issues/3236\nHEAD is now at 40a354b0 chore: add protoc proto3_optional flag in bazelrc\n2020-06-05 10:36:32,924 autosynth [DEBUG] > Running: git branch -f autosynth-103\n2020-06-05 10:36:32,928 autosynth [DEBUG] > Running: git checkout autosynth-103\nSwitched to branch \'autosynth-103\'\n2020-06-05 10:36:32,934 autosynth [INFO] > Running synthtool\n2020-06-05 10:36:32,934 autosynth [INFO] > [\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\n2020-06-05 10:36:32,937 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata synth.metadata synth.py --\n2020-06-05 10:36:33,172 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/nodejs-vision/synth.py.\nOn branch autosynth-103\nnothing to commit, working tree clean\n2020-06-05 10:36:33,320 synthtool [DEBUG] > Ensuring dependencies.\nDEBUG:synthtool:Ensuring dependencies.\n2020-06-05 10:36:33,325 synthtool [DEBUG] > Cloning googleapis.\nDEBUG:synthtool:Cloning googleapis.\n2020-06-05 10:36:33,326 synthtool [DEBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\nDEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/googleapis\n2020-06-05 10:36:33,330 synthtool [DEBUG] > Pulling Docker image: gapic-generator-typescript:latest\nDEBUG:synthtool:Pulling Docker image: gapic-generator-typescript:latest\nlatest: Pulling from gapic-images/gapic-generator-typescript\nDigest: sha256:c9bc12024eddcfb94501627ff5b3ea302370995e9a2c9cde6b3317375d7e7b66\nStatus: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest\n2020-06-05 10:36:34,265 synthtool [DEBUG] > Generating code for: google/cloud/vision/v1.\nDEBUG:synthtool:Generating code for: google/cloud/vision/v1.\n2020-06-05 10:36:35,110 synthtool [DEBUG] > Wrote metadata to synth.metadata.\nDEBUG:synthtool:Wrote metadata to synth.metadata.\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__\n    return self.main(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main\n    rv = self.invoke(ctx)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke\n    return ctx.invoke(self.callback, **ctx.params)\n  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke\n    return callback(*args, **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main\n    spec.loader.exec_module(synth_module)  # type: ignore\n  File "<frozen importlib._bootstrap_external>", line 678, in exec_module\n  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n  File "/home/kbuilder/.cache/synthtool/nodejs-vision/synth.py", line 39, in <module>\n    extra_proto_files=[\'google/cloud/common_resources.proto\'],\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 66, in typescript_library\n    return self._generate_code(service, version, "typescript", **kwargs)\n  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_microgenerator.py", line 195, in _generate_code\n    f"Code generation seemed to succeed, but {output_dir} is empty."\nRuntimeError: Code generation seemed to succeed, but /tmpfs/tmp/tmpkq9pq3f9 is empty.\n2020-06-05 10:36:35,157 autosynth [ERROR] > Synthesis failed\n2020-06-05 10:36:35,157 autosynth [DEBUG] > Running: git reset --hard HEAD\nHEAD is now at d6b10b8 chore: release 2.0.0 (#572)\n2020-06-05 10:36:35,164 autosynth [DEBUG] > Running: git checkout autosynth\nSwitched to branch \'autosynth\'\n2020-06-05 10:36:35,169 autosynth [DEBUG] > Running: git clean -fdx\nRemoving __pycache__/\nTraceback (most recent call last):\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 615, in <module>\n    main()\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 476, in main\n    return _inner_main(temp_dir)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 595, in _inner_main\n    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 371, in synthesize_loop\n    synthesize_inner_loop(toolbox, synthesizer)\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 381, in synthesize_inner_loop\n    synthesizer, len(toolbox.versions) - 1\n  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 266, in synthesize_version_in_new_branch\n    synthesizer.synthesize(synth_log_path, self.environ)\n  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 119, in synthesize\n    synth_proc.check_returncode()  # Raise an exception.\n  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode\n    self.stderr)\nsubprocess.CalledProcessError: Command \'[\'/tmpfs/src/github/synthtool/env/bin/python3\', \'-m\', \'synthtool\', \'--metadata\', \'synth.metadata\', \'synth.py\', \'--\']\' returned non-zero exit status 1.\n'

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


2333 remove if else code around caseid being present in sdx receipt rrm

What? and Why?
https://trello.com/c/bJZQZ9Tc/2333-remove-if-else-code-around-caseid-being-present-in-sdx-receipt-rrm
Now that rrm no longer exists, there is a bunch of code that needs to be updated/removed.  We can assume there will always be a case id, otherwise we'll quarantine the receipt.
To test this, in the repos mentioned below, check out the branches with the same name as this branch:
sdx-console: https://github.com/ONSdigital/sdx-console/pull/137
sdx-mock-receipt: https://github.com/ONSdigital/sdx-mock-receipt/pull/12
Put though some submissions and it should go through (EDIT: and receipt) without a problem.
Checklist

[x] CHANGELOG.md updated? (if required)

I've done basic testing and haven't had any problems. The code looks fine, but I'm not really familiar enough with this to approve.

@insacuri can you make the title pretty?

@jonnyshaw89 Prettified it!

@AndrewTorrance Can you look at it again, I removed those unused variables.

@insacuri Probably need to dismiss Andrew's review.


Gh103 fix golint issues

Fix some golint issues and let people know if they're introducing new golint issues.
Issue to reference: https://github.com/bluek8s/kubedirector/issues/103
I believe this should be assigned to some sort of v0.3.0 project - I can't do anything about that since I'm a member and not an admin. I also can't assign Reviewers - I assume that is for the same reason.

Golint doesn't exist in the containers natively, closing.

Why was this PR closed and then reopened?
From the prior travis success run:

Previously golint didn't exist.
From the current travis success run:

Now golint exists.

Capturing the thing we talked about: travis CI could/should check that "make format" is a NOP.

There is a problem with the check-format make command that can be seen here:

I'll re-open the PR when this is resolved.

I think this is fixed now.


Version issues

Hello, I am having some issues with the current versions of these functions, is there an updated code I could use please? Thank you.

Hi @hbaker2 I'm not one of the developers, but it might help if you add more detail about what issues you're running into.
Can you provide a full traceback of the errors you're getting, and include the versions of packages installed into your environment? For example see the bug report template here: https://github.com/vocalpy/vak/issues/new?assignees=&labels=BUG&projects=&template=bug_report.md&title=BUG%3A

Sure, thank you for taking the time to help me, I am looking forward to utilizing this package.
Basically, I first changed my directory in Anaconda prompt to the amvoc-master folder which I had downloaded and relocated to my Desktop.
Then, I followed the instructions by running the code for
pip3 install -r requirements.txt
Then I changed directory to the src folder inside of amvoc-master in which the main.py file is located and ran the code for
python3 main.py -i data/B148_test_small.wav -c n
And the message I get is:
UserWarning: The dash_table package is deprecated. Please replace
`import dash_table` with `from dash import dash_table`

I also get an error for:
ModuleNotFoundError: No module named 'pyAudioAnalysis'
I get these errors even though I confirmed that both of the packages are already installed.
Thank you for your help.

Hello, @hbaker2, can you please tell me the Python version of your system?

The requirements file and codebase is now updated to run with Python 3.10.11.


GCC 4.8.5 Build failure, different inttypes.h?

I get this with the latest git :

src/stlini.cpp: In member function ‘void CIniFile::PutUint64(const char*, uint64_t, const char*)’:
src/stlini.cpp:325:41: error: expected ‘)’ before ‘PRIx64’
snprintf( buf, sizeof( buf ), "0x%" PRIx64, value );

Not sure where the problem is (RH or porting?)  but I couldn't build on gcc 4.8.5 / CentOS 7 without manually adding definitions for :
#define PRId64 "lld"
#define PRIx64 "llx"
#define PRIu64 "llu"
#define PRIo64 "llo"

to src/stlini.cpp
Including inttypes.h itself didn't work as they are defined differently.
/* The ISO C99 standard specifies that these macros must only be
   defined if explicitly requested.  */

#if !defined __cplusplus || defined __STDC_FORMAT_MACROS

# if __WORDSIZE == 64
#  define __PRI64_PREFIX        "l"
#  define __PRIPTR_PREFIX       "l"
# else
#  define __PRI64_PREFIX        "ll"
#  define __PRIPTR_PREFIX
# endif

# define PRIx64		__PRI64_PREFIX "x"

If you do a:
#define __STDC_FORMAT_MACROS
before the #include <inttypes.h>, does it work?

Bunch of warnings .. And this :)
Linking _release/gpuvis...
_release/src/gpuvis.o: In function `unzip_first_file':
build/mikesart/gpuvis.git/src/gpuvis.cpp:510: warning: the use of `tmpnam' is dangerous, better use `mkstemp'

.. but it does indeed.   Thanks Mike.

Should be fixed with change 81b84c1.
I'll look at cleaning the release build warnings up (they don't happen in debug builds). They're in imgui and stb, so have to get fixes pushed over there.
Also need to fix tmpnam but it has to work on Mac and Windows, so I don't think it's as easy as just switching to mkstemp.
Thanks h1z1.


Ameerul / Add Scroll To Accordion Functionality

Currently, the accordion component is not able to be scrolled to by whoever consumes it. Now users can pass a ref to the accordion, and a function to the component.
The new function onScrollToAccordion which is optional, and it should be handled by the consumer as for my case, I needed the accordion to be scrolled to the top of the page, and this needs to be handled by the main div that surrounds all of my accordions.
Also I changed the overflow value to scroll as using auto will add the scrollbar to the content as it opens, which causes it to shift the content. Scroll will already add it by default, and won't cause a shift.

Scrollbar Content Shift Issue:
https://github.com/user-attachments/assets/ebf7a187-08ff-41e4-ad33-988c1edd8c81
Scrollbar Content Shift Fix:
https://github.com/user-attachments/assets/fa536280-7920-4d02-be18-e782b5f9e6ee
Accordion Scroll To:
https://github.com/user-attachments/assets/251d8c9b-9d83-4215-b320-d5fdd4fff6fd
https://github.com/user-attachments/assets/cfb92cff-ccec-4fd2-8ae8-0895f4a5b5e3

@farrah-deriv when its opened it should be pointing up when its open, this is how it was already in staging

@ameerul-deriv  in the video, the accordion shows pointing to the left

@nada-deriv @farrah-deriv i forgot to remove the changes to the arrow since i was testing something before 😅 but i assure you its not pushed in the changes.
In my local, the reason why its rotated left was cause i changed the transform value here, which you can check in code changes, i didn't push

Here is a short demo:
https://github.com/user-attachments/assets/673e5f23-3eb5-45b0-9057-d185b732e0f0


src_unpack rewriting/removal

I think src_unpack() is not needed if we use the correct variable names

The reason I use src_unpack comes from the fact that the folder unpacked from the tar is really long. Do you know a better way to fix this?

Closing, this is now part of the eclass.


Simplify bridge interface

Implements suggestions in https://linear.app/tina/issue/ENG-916/spike-on-simplifying-bridge
cc @jeffsee55

@logan-anderson here's my proposal for getting rid of that updateConfig handler from the database: https://github.com/tinacms/tinacms/pull/3842

@kldavis4  and @jeffsee55  I updated the ConfigManager based on @jeffsee55  Feedback.


Getting Error in config.yml

Hi,
I'm getting an error during the move: section of the config.yml as below,
2015-09-26 23:36 ERROR    entry         sort-files      Failed ncis.la.701.hdtv-lol (Path value replacement /home/osmc/TV Shows/{{ tvdb_series_name }}/Season {{ tvdb_season }} failed: (UndefinedError) 'tvdb_series_name' is undefined)
I'm not that linux knowledgable, I've been struggling to get things working properly for a few days now.
Thanks for any help your able to provide.

Thanks for reporting.
What is happening here is that the TVDB service (which returns TV Shows information) doesn't know what to do with the filename ncis.la.701.hdtv-lol. There is a section inside the config.yml that defines  exceptions that do not work. Try to add this serie:
 series:
      - Adventure Time
      - NCIS Los Angeles

In any case, I just commited a fix, so if the series name is not found will rename the file using the word "Unknown" but will keep going.
Let me know if that worked for you.
All the best

I was able to edit your configure using information based on this forum post, http://discuss.flexget.com/t/match-filename-with-all-numeric-season-episode/805
This gave me the ability to rename these problem files.


Mock Verify does not validate that the member/property name provided is valid

SetupProperty
Guard-ArgumentNotNull 'PropertyName' $PropertyName
$member = $this._GetMemberFromOriginal($PropertyName)

if($member -isnot [System.Management.Automation.PSNoteProperty] `
    -and $member -isnot [System.Management.Automation.PSScriptProperty]) {

    $msg = "Member {0} is not a PSScriptProperty or PSNoteProperty." -f $PropertyName
    throw (new-object PSMockException([ExceptionReason]::MockConsistencyCheckFailed, $msg))
}

Verify, VerifyGet, and VerifySet do not do this.

Because of this, the exception we get is: The property 'Calls' cannot be found on this object. Verify that the property exists.


Using a CamelCase key in Redis breaks DatadogMetric

Hi, I am currently trying to configure DatadogMetric-based HPA autoscaling inside a Kubernetes cluster.
The goal is to scale a deployment based on the length of a Redis key named "testKey" using Datadog Redis integration.
Annotations on the Redis pod are set like so:
podAnnotations:
      ad.datadoghq.com/redis.check_names: '["redisdb"]'
      ad.datadoghq.com/redis.init_configs: '[{}]'
      ad.datadoghq.com/redis.instances: |
        [
          {
            "host": "%%host%%",
            "port":"6379",
            "password":"ENC[redis-password]",
            "keys": ["testKey"]
          }
        ]

Then we have the following DatadogMetric set up:
apiVersion: datadoghq.com/v1alpha1
kind: DatadogMetric
metadata:
  name: number-of-jobs
spec:
  query: max:redis.key.length{key:testKey}

And finally, the HPA:
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
  name: myhpa
spec:
  maxReplicas: 20
  minReplicas: 1
  metrics:
  - type: External
    external:
      metricName: datadogmetric@mynamespace:number-of-jobs
      targetAverageValue: 1

With this setup, Datadog fails to retrieve the key length and we see the following error logs in cluster agent:
2022-01-20 17:11:47 UTC | CLUSTER | ERROR | (pkg/clusteragent/externalmetrics/provider.go:103 in GetExternalMetric) | ExternalMetric query failed with error: DatadogMetric is invalid, err: Invalid metric (from backend), query: max:redis.key.length{key:testKey}
2022-01-20 17:11:47 UTC | CLUSTER | ERROR | (pkg/util/kubernetes/autoscalers/datadogexternal.go:157 in queryDatadogExternal) | Returned series slice empty

And the DatadogMetric is invalid:
    Message:               Invalid metric (from backend), query: max:redis.key.length{key:testKey}
    Reason:                Unable to fetch data from Datadog
    Status:                True
    Type:                  Error

The twist is, when we switch to using "testkey" instead of "testKey" in Redis and DatadogMetric configuration, everything works like a charm.
I suspect this is related to the fact that Datadog enforces lowercase tags, but this is definitely an issue because it prevents us from using camel-cased keys that are stored within our Redis database as metrics for our HPA.

Just realized I should maybe have opened this at https://github.com/DataDog/integrations-core
Let me know if I need to move this issue there

Hi @bgounon, indeed this is related to Datadog normalizing tags to lowercase on the data ingested (metrics, traces, etc).
You should however still be able to configure testKey in your redis integration configuration, and then define your query in your DatadogMetric as max:redis.key.length{key:testkey}. Does this help, or would the lowercase normalization in Datadog cause aliasing in your case?

Hi @olivielpeau,
It does help indeed, I am able to retrieve the value from those camelcased keys with this method, although I think it's kind of counter-intuitive, maybe it's worth documenting this behavior somewhere if it's not already the case.
This perfectly answers my needs for the moment though, so I guess this issue can be closed ?
Many thanks

Thanks for confirming @bgounon, I'll go ahead and close this issue then!
In general I'd recommend trying to perform the query in Datadog if the DatadogMetric displays such an error. This should help determine the correct metric query to configure, even in cases where there are some normalization steps done in the Agent or in Datadog's ingest.


python311Packages.langchain-core: 0.1.26 -> 0.1.27

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.langchain-core is: Building applications with LLMs through composability
meta.homepage for python311Packages.langchain-core is: https://github.com/langchain-ai/langchain/tree/master/libs/core
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.1.27 with grep in /nix/store/i76s73zj3vpcl0kg20j9ipiikvgppmsv-python3.11-langchain-core-0.1.27
found 0.1.27 in filename of file in /nix/store/i76s73zj3vpcl0kg20j9ipiikvgppmsv-python3.11-langchain-core-0.1.27

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
khoj
pentestgpt
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-core
python312Packages.langchain-community
python312Packages.langchain-core

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i76s73zj3vpcl0kg20j9ipiikvgppmsv-python3.11-langchain-core-0.1.27 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.langchain-core https://github.com/r-ryantm/nixpkgs/archive/2f812e4de49daef0f3836a9fb11862b887cf6dde.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2f812e4de49daef0f3836a9fb11862b887cf6dde#python311Packages.langchain-core

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i76s73zj3vpcl0kg20j9ipiikvgppmsv-python3.11-langchain-core-0.1.27
ls -la /nix/store/i76s73zj3vpcl0kg20j9ipiikvgppmsv-python3.11-langchain-core-0.1.27/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.langchain-community
python312Packages.langchain-core

1 package failed to build:

khoj

4 packages built:

pentestgpt
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-core

Maintainer pings
cc @natsukium for testing.

Superseded by #292022


Unify DAG creation/database cleaning fixtures for testing

Fixes

Fixes #2622  by @AetherUnbound
Description

There will be one clean_db() in conftest.py file because tests from multiple test modules in the directory can access the fixture function. Pool and TaskInstance from airflow.models will have a if condition because not all tests runs a filter and deletion for them. There is a override method for fixture on a test module level(link) There are default values get_test_dag_id, get_test_id, isPool, isTaskInstance in conftest.py. On each test involving clean_db(), there should be a get_test_dag_id() fixture and options to run isPool fixture and isTaskInstance fixture by returning True
Testing Instructions

run just down -v
run just catalog/up
run just catalog/init
run just catalog/test

Checklist

[X] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[X] My pull request targets the default branch of the repository (main) or a parent feature branch.
[X] My commit messages follow best practices.
[X] My code follows the established code style of the repository.
[X] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[X] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound unittest.TestCase only allow auto-use fixture(link) In test_single_run_external_dags_sensor.py, TEST_POOL and DAG_PREFIX are hardcode with the same outcome to fixture get_test_dag_id and get_test_pool. In clean_db, DagRun, TaskInstance and Pool will filter with startswith to search for prefix of names and delete them.


docs: add public cloud deployment docs

Coverage increased (+2.5%) to 74.332% when pulling 645938b31f85dd8b2bdf3e9005e179840be7d423 on yang-yinbo:main into d625adef75ce70291c1869b11e36eae4bad3ad3d on emqx:main.


mlx_lm.lora training don't report anything

{
    "adapter_path": "/Users/you/models/lora",
    "batch_size": 4,
    "config": null,
    "data": "/Users/you/data",
    "grad_checkpoint": false,
    "iters": 100,
    "learning_rate": 1e-05,
    "lora_layers": 16,
    "lora_parameters": {
        "rank": 8,
        "alpha": 16,
        "dropout": 0.0,
        "scale": 10.0
    },
    "lr_schedule": null,
    "max_seq_length": 2048,
    "model": "/Users/you/models/TinyLlama-1.1B-Chat-v1.0",
    "resume_adapter_file": null,
    "save_every": 100,
    "seed": 0,
    "steps_per_eval": 200,
    "steps_per_report": 10,
    "test": false,
    "test_batches": 500,
    "train": true,
    "val_batches": 25
}

The above is the configuration file. When running lora train, no message is output from the terminal after training for an hour. How can I make the terminal display relevant information? I want to know what the total training time is.

Usually you should see something after a few seconds. The fact that you do not suggests that it's using way too much memory for your machine. There are a few suggestions here on reducing memory use.
Basically:

Reduce the batch size
Reduce the number of LoRA layers
Use gradient checkpointing
Reduce the max_seq_length

Loading pretrained model
Trainable parameters: 0.074% (0.819M/1100.048M)
Loading datasets
Training
Starting training..., iters: 100
The above is all the information displayed by the terminal
My mac stuio has the highest configuration and has 192G memory.

How odd.

Can you share the version of MLX and MLX LM that you are using?

Loading pretrained model
Trainable parameters: 0.074% (0.819M/1100.048M)
Loading datasets
Training
Starting training..., iters: 100

mlx                0.10.0
mlx-lm             0.9.0

and my data just 1 message
{"prompt": "What is the capital of France?", "completion": "Paris."}
only for testing mlx lora trainning

Problem is the batch_size=4 and the dataset only has one example, so it's getting stuck in an infinite loop in the data construction. You can use a larger dataset or a batch size of 1 to get it to work immediately.
It's a bit of an edge case but I'll try to push a fix for this so it's more clear what is going on.

thx so much it's working


Add information on how chunks work

There is surprisingly no good isolated reference within the dask.array docs that show how chunks= should work.  I was looking for something to share with someone on gitter and couldn't find a good reference.

I suspect that most dask.array users "just know" how chunks works from previous projects.

There was this post: http://stackoverflow.com/questions/34895846/correct-choice-of-chunks-specification-for-dask-array


New API Proposal: X.509 Certificate Support

New API Proposal: X.509 Certificate Support
Motivation:
A big part of cryptography and security for multiple internet protocols is the X.509 standard, defining public key certificate formats. Not having the possibility to create or read certificates is a real bummer.
It would be a great addition:

Identity binding to a public key using digital signatures
Client certificate authentication, useful for Swift servers and clients
Certificate Authority (CA) support
Pretty Good Privacy (PGP) support
SSL/TLS support

Most of the core components to support X.509 certificates are already (partially) implemented:

ASN.1 support to encode and decode certificates and it's attributes
ECC/RSA signatures to sign CSR's and verify certificates

I would highly recommend also adding the certificate signing request (CSR), part of the PKCS#10 spec, to make the client certificate authentication and identities accessible more easily.
Importance:
X.509 is of great importance in cryptography:

It provides clients secure access to information and resources
It provides a way to prevent man-in-the-middle attacks (MITM)
It is an enabler for CA's
It is an enabler for PGP
It is an enabler for the public key infrastructure (PKI)

Is your use-case solved by swift-certificates?

It sure does, that's exactly what I was after. Can't believe I missed that, thanks a lot!


Update Issue - 65484517

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 78.0

Operating System
Windows 8.1

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


Incorrect fling velocity on zoom gesture end with Compose 1.7.0-alpha02

https://github.com/saket/telephoto/assets/118464521/746bc90b-0dbf-4889-b588-5beabd046894
VelocityTrackerAddPointsFix is enabled by default since Compose UI 1.7.0-alpha02.
Currently we set this flag to false as a workaround, but it will be removed in the future.
Related bug: https://issuetracker.google.com/269487059

I believe this is caused by
https://github.com/saket/telephoto/blob/1749177719156efe8ed5a7ce8fa15b7f54778f8c/zoomable/src/commonMain/kotlin/me/saket/telephoto/zoomable/internal/transformable.kt#L197-L199
where changes from different pointers are added to the same VelocityTracker.


⚠ Bofrost.es has degraded performance

In ef991f8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1470 ms

Resolved: Bofrost.es performance has improved in e006556 after 13 minutes.


Release 0.1.0

coverage: 26.239% (+0.1%) from 26.143% when pulling 1456754a3129beb8f7653974dc1089d6db0b0c32 on release_0.1.0 into cc39e4a3db45789555ed39f697e445dcd8ea9c3e on master.


[DONT MERGE] test on pull request security

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

The pull request triggered test can enabled directly.


best way to size custom pins

What is the best way to show image size for pins in cross development ?
scale or create all kind of images with different size ? Anyone has some example for me...

See #40 Why custom pin icon in iOS bigger than Android?
I don't understand size calculation mechanism via BitmapDescriptorFactory.FromStream.
Workaround is using BitmapDescriptorFactory.FromBundle("image01.png").
In this case, you can prepare image01.png each platform.
For more information, please see Custom marker support(v1.4.0-) - Comparison with Xamarin.Forms.Maps · amay077/Xamarin.Forms.GoogleMaps Wiki

is there a way to use the resources instead of the assets for android ? that way you can use it for different screen sizes (hdpi/xhdpi and so on)

I close this issue because this is duplicate of #40.
Please check #40 after this.


typo spelled allower_user instead of allowed_user

the last commit version havent be used for the pull request of 3h ago

@CasuallyCalm


Missing layer improvement

Made to address https://github.com/kartoza/rezoning-2-project/issues/31
Description:
Sometimes an applied filter will results in all zones being filtered out, this PR adds the ability to disable filters.
An error message in place of the zone results is also displayed to tell the user to check his filters in case all zones were filtered out.

TODO:

Decide which layers are to be always enabled.
Error message wording?

Error message wording proposal: << Unfortunately, your analysis did not yield results. If this does not look correct, please double check the filter range but also the data layers you have activated, which might actually not have data for your country of interest. >>

can we please delete the ERROR figure? it does not necessarily have to be an error, but just a fact; and it looks bad on the tool to have the Error red flag there

Closing this PR, since it's already merged to different branch. https://github.com/worldbank/WB-rezoning-explorer/tree/kartoza_develop


Upload 0.4.1 to crates.io?

It seems like one gets 0.2.0 (which doesn't seem to compile for me) when doing cargo install rkeep. Would it be possible to have the latest version uploaded there as well, so people aren't getting out-of-date versions?

I will re-release 0.4.1 and upload.


Revert "Convert remaining ui/common classes to Kotlin"

Reverts google/ground-android#1282
Instrumentation tests are failing

Codecov Report

Merging #1284 (b78b931) into master (4830f7a) will increase coverage by 0.21%.
The diff coverage is n/a.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JSunde PTAL


LogMatch invariant violated

Hello,
Through fuzz testing I found a test case that causes Raft's "Log Matching" invariant to be violated. "Log Matching" is defined as:
"if two logs contain an entry with the same index and term, then the logs are identical in all entries up through the given index"

One issue seems to be the following: Upon transitioning from Candidate to Leader, the Candidate sends an ElectedAsLeader message to itself. It is possible that the newly elected Leader will receive ClientMessages before the ElectedAsLeader message is delivered, e.g. if it had the ClientMessages in its mailbox before the transition occurred. Upon receiving the ElectedAsLeader message, the Leader then reinitializes its nextIndex and matchIndex fields (overwriting what they were previously after applying the client commands). It then sends AppendEntries messages that do not include the 1st client command.
The fix should be simple: initialize the nextIndex and matchIndex fields before transitioning to Leader (in ElectionMeta.forLeader()), rather than after ElectedAsLeader is delivered.
In more detail:

Suppose that before becoming Leader, the Candidate has two ClientMessages in its mailbox.
Candidate becomes elected, sends ElectedAsLeader message to itself.
Upon receiving the first ClientMessage, it adds the command to its log and sends out AppendEntries messages containing that command to all peers. Those AppendEntries messages are delayed
Upon receiving the second ClientMessage, the leader adds the command to its log, and sends out new AppendEntries messages containing both commands to all peers. These messages are also delayed.
The leader now receives the ElectedAsLeader message, and sets nextIndex = LogIndexMap.initialize(members, replicatedLog.lastIndex). The value of replicatedLog.lastIndex is currently 1, not 0.
The leader now sends out AppendEntries messages with fromIndex=nextIndex.valueFor(member) == 1, i.e. the AppendEntries messages include the 2nd but not the 1st client command. prevLogIndex for this entry is 1 - 1 == 0.
Upon receiving the AppendEntries containing the second command, followers pass the consistency check [since prevLogIndex for the entry is 0] and add the 2nd command to their log.
Now we have inconsistent logs: the leader's log contains (1st command, 2nd command) whereas the followers logs contain (2nd command)

I believe that https://github.com/ktoso/akka-raft/issues/37 describes another issue here: prevLogIndex should be -1 for an empty log, not 0 [or, alternatively, the log should be 1-indexed instead of 0-indexed]. If followers understood that prevLogIndex should be 0 for a log containing one entry, they would have failed the consistency check for the AppendEntries command, and properly rejected it.
Here are the reproducing steps for this execution:
$ git clone -b raft-58 git@github.com:NetSys/sts2-applications.git
$ git clone git@github.com:NetSys/sts2-experiments.git experiments
$ sbt assembly
$ java -d64 -Xmx15g -cp target/scala-2.11/randomSearch-assembly-0.1.jar Main 2>&1 | tee console.out

Here are my annotated notes on each step of the execution.
For what it's worth, this snapshot of the akka-raft code differs slightly from the master branch. In particular, it includes (hacky) fixes for all of the known leader election bugs, and a few printlns within raft.

Upon thinking about this a bit more:
Delayed nextIndex initialization is not the main issue here. That just causes a slight performance cost: it means that the Leader will have its AppendEntries messages initially rejected by followers, but the Leader will subsequently decrement nextIndex for those followers, resend the AppendEntries, and have them succeed.
The main issue here is that the initial value of prevLogIndex is ambiguous: followers can't distinguish between an AppendEntries for an empty log (prevLogIndex == 0), an AppendEntries for the leader's 1st command (prevLogIndex == 0), and an AppendEntries for the leader's 2nd command (prevLogIndex == 1 - 1 == 0). The last two cases need to be distinguishable.

For what it's worth, I have a (non-pull-request-worthy) fix for this issue here:
https://github.com/NetSys/sts2-applications/commit/1840499c07aecf10dbca9db050f41cb48212ca44
Tested by fuzz testing -- I verified that under non-failing scenarios, this behaves correctly at each step of the execution when replicated two client commands.


Updated commit with class changes and additional

Here is an updated branch of separated, sectioned classes defining the plugin player in terms of managing plugins, the tree, module/node widgets, modules/nodes, and utility functions such as importing classes and browsing files. Additional look at eval is still needed to be decided.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Initial code import.

This is an updated PR for putting the Shim layer in a separated repo (originated from https://github.com/opentracing/opentracing-java/pull/221).
Notes on it overall:

Provide a default TracerShim which wraps a 0.31 Tracer with its ScopeManager, providing no Continuation support out of the box.

Provides also a AutoFinishTracerShim which wraps a 0.31 Tracer using the contained AutoFinishScopeManager, which keeps the thread-local, reference-count based logic to support Continuations.

Currently it still throws IllegalArgumentException on null values of some methods (i.e. SpanBuilder.childOf() - throwing this would prevent a NullReferenceException when casting the wrapped object. Pavol mention we should not throw such Exception - so, what should we throw there instead? Or how should we report such errors? The spec doesn't mention thrown exceptions...

No Travis/CentralSync support yet (will do after we get this properly merged).

Maybe comment on this? @yurishkuro @pavolloffay @tedsuo @malafeev ?

meta-comment - could we merge the supporting files directly and only have the PR for the business code?


Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Add Malix to list

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Malix is a new and evolving programming language.

Hi @TheMRLokopOff, thanks for the contribution ❤.
Unfortunately, as per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Unaffiliated with the project (not self-promoting as e.g. a maintainer, creator, contractor or employee)

I don't know if this submission technically qualifies as self promotion, but we'd have more confidence merging this project in if there was enough support/activity in the community. Thank you!


Fix support for Metabase CI and future-proof DDL statements

Summary
This PR started as future proofing for an upcoming HoneySQL update which requires explicit quoting of identifiers in some cases.
As part of this work I got the main Metabase upload's test suite running against the driver. This required some updates to the driver to track interface changes, and also revealed some small bugs, which have also been fixed.
NOTE: this version will not be safe for v50 without further changes.
Checklist

[x] There is test coverage for these changes in the main metabase.upload test suite.

NOTE: this version will not be safe for v50 without further changes.

Shall we wait until 0.51 and merge after that?

Shall we wait until 0.51 and merge after that?

I think after https://github.com/metabase/metabase/pull/48233 merges we'll be good to release after its following point release. Will rerun the suite locally after the backport is merged.


std.range.chain with single elements too

jack (@JackStouffer) reported this on 2018-05-31T19:46:38Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=18929
CC List

greensunny12
tiberiulepadatu14

Description
In my opinion, this should compile as a matter of convenience.

============
import std.range;
import std.utf;

void main()
{
    auto r = chain("test".byCodeUnit, 'a');
}
============

Under the hood, this can be easily translated to

============
auto r = chain("test".byCodeUnit, only('a'));
============

tiberiulepadatu14 commented on 2018-10-20T15:39:43Z
Can I work on this?

greensunny12 commented on 2018-08-15T23:32:31Z
FWIW the built-in concatenation operator also allows this already:

---
([1, 2, 3] ~ 42 ~ [42, 43]).writeln; // [1, 2, 3, 42, 42, 43]
---

https://run.dlang.io/is/md3qKz


fixing cell differentiation terms

This follows on from [ 925921 ] Development -- suggested defs and
a few questions
https://sourceforge.net/tracker/index.php?
func=detail&aid=925921&group_id=36855&atid=440764
I have opened it as a place to keep track of discussions on the cell
differentiation terms and their children. The plan is to work through
these terms and see that they have the proper parentage and
standardized definitions, but to discuss each case as it comes since
there are many exceptions to the rules.
Jen
Reported by: jenclark
Original Ticket: "geneontology/ontology-requests/1706":https://sourceforge.net/p/geneontology/ontology-requests/1706

thanks www.movied.org


Smarter reordering algorithm

IS
Currently, node_map items are ordered by reinserting them when their index (absolute position) has changed.
SHOULD
Just reinsert them if their relative position has changed!
Note
In practice, this works well enough. But as shown by benchmark, this makes lui one of the slowest candidates for "remove row", since all n rows following get reinserted without any need. It just looks bad in the table!

The index-based method was pretty stable in most cases but in some rare cases, the reordering would have been incorrect, so I went for a temporary and much less efficient solution: Reinserting all items on each rerender.


Inserted Node doesn't get rendered?

For some reason (lack of morning coffee maybe), I posted a question to StackOverflow before coming here.
I'm trying to get Flexmark to render image alt text as a caption, the way Pandoc does it. I made a Visitor that visits all Image Nodes and does this:
BasedSequence text = image.getText();
Paragraph caption = new Paragraph(text);
Node parent = image.getParent();
parent.insertAfter(caption);

I have verified during debugging that calling parent.getNext() after this correctly returns my caption Paragraph object, so as far as I can tell, it's getting inserted correctly. However, when the document is rendered, the Paragraph I inserted isn't there.
Am I doing something wrong, or is this a bug? Thanks!

@sez11a, If you can give me a bit more information about the rendered HTML result you want, I can provide you with the corrected code.
In flexmark each node's text contains strings from original file, with start/end offsets. This means that inserting nodes is a bit more involved. The offsets are expected to be in increasing, non-overlapping order.
It is possible to insert text from outside of the original file but it requires providing a location where in the file it is inserted to allow the rest of the code expecting original file offset locations to work correctly.
I will be reworking the library to make AST manipulation easier amongst other improvements but for now it is a bit of a PITA.

Hi @vsch I would be very happy to provide an example:

Figure 1: Some description here.

The text is in the original file; I just need to copy it from the image element into its own paragraph.
Thanks for your help!

@sez11a, I added a sample with the code to do what you described NodeInsertingPostProcessorSample.java
I had to improvise on how to add attributes to a generic Paragraph node since the AST has no provisions for doing so. I did not want to provide a custom node and custom renderer.
I like the solution so much I am adding it by default into the core as of next release. It is also a quick and dirty way to attach any additional information to a node in the AST.
---- Markdown ------------------------

![Figure 1. Some description here.](http://example.com/image.png) **baz**

![bar]

![Figure 1. Some description here.][bar]

[bar]: http://example.com/image.png 'Image Title'

---- HTML ------------------------

 baz

Figure 1. Some description here.

bar

Figure 1. Some description here.

---- AST ------------------------

Document[0, 176]
  Paragraph[0, 74] isTrailingBlankLine
    Image[0, 65] textOpen:[0, 2, "!["] text:[2, 34, "Figure 1. Some description here."] textClose:[34, 35, "]"] linkOpen:[35, 36, "("] url:[36, 64, "http://example.com/image.png"] pageRef:[36, 64, "http://example.com/image.png"] linkClose:[64, 65, ")"]
      Text[2, 34] chars:[2, 34, "Figur … here."]
    Text[65, 66] chars:[65, 66, " "]
    StrongEmphasis[66, 73] textOpen:[66, 68, "**"] text:[68, 71, "baz"] textClose:[71, 73, "**"]
      Text[68, 71] chars:[68, 71, "baz"]
  Paragraph[74, 74]
    EmbeddedNodeAttributes[74, 74], attributes: Attributes{class="caption"}
    Text[74, 74] chars:[74, 74, "Figur … here."] text "Figur … here."
  Paragraph[75, 82] isTrailingBlankLine
    ImageRef[75, 81] referenceOpen:[75, 77, "!["] reference:[77, 80, "bar"] referenceClose:[80, 81, "]"]
      Text[77, 80] chars:[77, 80, "bar"]
  Paragraph[82, 82]
    EmbeddedNodeAttributes[82, 82], attributes: Attributes{class="caption"}
    Text[82, 82] chars:[82, 82, "bar"] text "bar"
  Paragraph[83, 124] isTrailingBlankLine
    ImageRef[83, 123] textOpen:[83, 85, "!["] text:[85, 117, "Figure 1. Some description here."] textClose:[117, 118, "]"] referenceOpen:[118, 119, "["] reference:[119, 122, "bar"] referenceClose:[122, 123, "]"]
      Text[85, 117] chars:[85, 117, "Figur … here."]
  Paragraph[124, 124]
    EmbeddedNodeAttributes[124, 124], attributes: Attributes{class="caption"}
    Text[124, 124] chars:[124, 124, "Figur … here."] text "Figur … here."
  Reference[125, 174] refOpen:[125, 126, "["] ref:[126, 129, "bar"] refClose:[129, 131, "]:"] url:[132, 160, "http://example.com/image.png"] titleOpen:[161, 162, "'"] title:[162, 173, "Image Title"] titleClose:[173, 174, "'"]

Thank you! I just implemented this and it works perfectly. I would never have been able to figure out all that by myself. Do you want me to close this issue/question?

@sez11a, you are welcome.
BTW, I cannot blame you for not being able to figure it out when I have not provided good enough docs to describe the internals. I have added a todo item on my list to give a better overview of the architecture and internal workings.
Of course every question leads to more samples. I will add a cross reference for samples in the docs too.
Feel free to close the issue.

https://github.com/vsch/flexmark-java/blob/master/flexmark-java-samples/src/com/vladsch/flexmark/java/samples/NodeInsertingPostProcessorSample.java


tried to remove vm from terraform

│ Error: error sending deployment to the node: workload 'zmachine' does not support upgrade: upgrade validation error

just remove a vm from the 2, and try to apply will not work
this should be possible
main.zip
Moved from: https://circles.threefold.me/project/test-tfgrid3/issue/92

most likey along with the removal of the vm, there were changes in the properties in the other vm, which isn't allowed in zos side yet
wil close


Add meta robots noindex for Swagger dev/staging URL

Description
PR, dev and staging deployments are being unnecessarily indexed by web crawlers.
This impacts the ranking of production content so we should instruct web crawlers to not index them.
Requirements
Include a <meta name="robots" content="noindex" /> tag in the dev/staging deployments to keep those URLs from being indexed by web crawlers.
Additional information
Through https://www.google.com/search?q=site%3A5afe.dev+safe+client+gateway we can see that the staging environment is being indexed

X-Robots-Tag was added to the Client Gateway staging response headers:
curl -I https://safe-client.staging.5afe.dev
HTTP/1.1 302 Found
...
X-Robots-Tag: noindex, nosnippet, noarchive
...

Theoretically, this will make search engines stop indexing this service in the staging environment. Thanks for reporting this @DiogoSoaress !


Add PrettierJS to format code

The title says it all :) This PR adds prettierjs and a npm script to format the codebase.

We can discuss and merge this one once rebuild branch is merged.

Closing in favour of https://github.com/webpack/webpack.js.org/pull/3109.
Thanks @tryzniak


str_limit() using voyager richtextbox not showing into view

Laravel Version: 5.5
Voyager Version: 1.0
PHP Version:7.0
Database Driver & Version:mysql 5.6

Description:
im using voyager as backend and i have added richtextbox and i want to display those content into view
as {!! $variable !!} and i want to truncate those content with 30 words..but its not working
im using this code to do {!! str_limit($variable, 30) !!}
its not showing any error just empty

Can you dd($variable) to see what it's actually holding?  We don't use anything named $variable as far as I'm aware, so we'll need a bit more information in order to figure this out.

Closing due to inactivity


wayland-server: alive check for Weak

In smithay we quite extensively use Weak as the key for caching some other resource. Cleaning up these resources
often requires checking if the key is still alive. Without an explicit function to check Weak for alive we have to resort to Weak::upgrade().is_ok(). An explicit function can save us from actually upgrading the resource itself, saving us quite some cpu time.

Could you split out the rustfmt changes into another PR? Looks like the check-minimal CI is unhappy about something so I'd prefer we split this to figure out what's going on.
Other than that, LGTM :+1:

https://github.com/Smithay/wayland-rs/pull/722 should fix the CI failure if this is rebased.

sorry for late reply, ran out of time trying to fix the CI build. dropped the commit with the attempt to fix the CI as it is already fixed in master, thx :)


JaceOptions case sensitivity does not get applied to FunctionRegistry or ConstantRegistry on engine constructor

FunctionRegistry and ConstantRegistry ignore JaceOptions.CaseSensitive, which has performance implications as there are lots of unnecessary calls to ToLowerFast().
        public CalculationEngine(JaceOptions options)
        {
            this.executionFormulaCache = new MemoryCache<string, Func<IDictionary<string, double>, double>>(options.CacheMaximumSize, options.CacheReductionSize);
            this.FunctionRegistry = new FunctionRegistry(false);
            this.ConstantRegistry = new ConstantRegistry(false);
            this.cultureInfo = options.CultureInfo;
            this.cacheEnabled = options.CacheEnabled;
            this.optimizerEnabled = options.OptimizerEnabled;
            this.caseSensitive = options.CaseSensitive;

Even after disabling case sensitivity, it gets checked by both ConstantRegistry.IsConstantName() and FunctionRegistryIsFunctionName().

This does not seem to break the case sensitivity it self as even this test case I wrote to CalculationEngineTests passes:
        [TestMethod]
        public void TestCalculateFormulaWithCaseSensitiveThrows()
        {
            Dictionary<string, double> variables = new Dictionary<string, double>();
            variables.Add("var1", 1);
            variables.Add("var2", 1);

            CalculationEngine engine = new CalculationEngine(new JaceOptions { CaseSensitive = true });
                //CultureInfo.InvariantCulture, ExecutionMode.Compiled, false, false, false);
            var ex = AssertExtensions.ThrowsException<VariableNotDefinedException>( () => engine.Calculate("VaR1*vAr2", variables));
            Assert.AreEqual("The variable \"VaR1\" used is not defined.", ex.Message);
        }

I also ran the Jace benchmarks as those seemed to allow testing performance with and without case sensitivity. The tests are neclecting to test the basic use case though that does not use the FormulaBuilder. FormulaBuilder seems to have been implemented as expected. The single benchmark does not take the input variable dictionary that are part of the problem here.
I created  some new benchmark cases to see the performance impact. The rightmost column ("Total Duration (no fix)") has results before fix and the one before that ("Total Duration (fix)") has fix to engine constructor applied. An improvement of ~200 ms can be observed in cases where case sensitivity is set to True.

Engine
Case Sensitive
Formula
Iterations per Random Formula
Total Iteration
Total Duration (fix)
Total Duration (no fix)

Interpreted
False
something2 - (var1 + var2 * 3)/(2+3)

1000000
00:00:01.6005267
00:00:01.5919016

Interpreted
True
something2 - (var1 + var2 * 3)/(2+3)

1000000
00:00:00.6069845
00:00:00.8390435

Compiled
False
something2 - (var1 + var2 * 3)/(2+3)

1000000
00:00:01.5865326
00:00:01.5770084

Compiled
True
something2 - (var1 + var2 * 3)/(2+3)

1000000
00:00:00.5930012
00:00:00.8189981

Here are also the full excel files before and after the fix. Note that only the benchmarks with formula "something2 - (var1 + var2 * 3)/(2+3)" are affected when case sensitivity is True.
jace_benchmark_var_dict_no_fix.xlsx
jace_benchmark_var_dict_fix.xlsx

@pieterderycke Created a PR #76 to fix the issue.

This bug can also cause some extra memory traffic. While this is likely Gen 0 Heap, it surely would not hurt to get it removed too. The fix should apply to this one too.


Draft Login Page

Added Login Page
Added form (inputs, errors) validation
Test endpoint (sheets api)

See comments in discord for general notes.
Overall, your logic for the user login looks good, but some code does not match with the existing codebase.

Make sure to review our tech stack and follow suit. For instance, we are using React Query instead of axios. If you want to add something significant/different, please consult with the leads/general chat first to ensure we're on the same page with design decisions. Reach out if you ever need any help!
I know the sheets api is just for testing purposes, but our database is also very easily ran locally as a file, so I don't see any reason not to use that - make sure you are familiar with it and its schema, as the relevant info for signin is already defined.
Ik you missed some of the meetings before, but for the future make sure that your tasks are discussed and identified as a need before doing them. We have a Figma (theoretically, at least).

Update
use react query and hook form (please check if its right), also need to add more styling but that will be done super soon!
i just tested with google sheets api again (it works) since auth wasnt up yet
i wasnt able to pull from sprint-2, im getting an error message so some of pages are not updated:(


[WIP] Changes allowing intercept to be cross-compiled with Mingw-w64 on linux

32-bit version compiles. I don't know it it works, though :).
~I'm going to check how to compile the 64-bit version tomorrow.~ It compiles now.
If your i686-w64-mingw32.static.posix-gcc -v says 7.0.0 or later, you don't need to compile anything. You need the .posix version to be installed, otherwise threaded code won't compile.
 It is taking too long right now anyway.
Release only would be fine though. I guess. But we don't really need it anyway as Appveyor already builds windows binaries.

This takes about the same time as a GCC build, only first build that caches things takes a long time, and that already happened.

As said by @jonpas this takes the same time as a regular GCC build, I would even go farther to say that it's quicker because the setup time is about 1 minute less for mingw (just fetch cross compiler from cache and unzip) than the regular GCC build (install from apt-get).
See here for my today's push to this PR: https://travis-ci.org/intercept/intercept/builds/251698724?utm_source=github_status&utm_medium=notification
The upside of having Mingw builds now is that as soon as someone writes some code that doesn't compile there, the test is going to fail, we won't have to wait until 4am when the runtime tests start and fail (not because Arma but because of our changes in the code). I'll try to finish the preliminary runtime tests in a few days so we can start running those.
If you're really bothered by the one-time (cross compiler) build times, I could prebuild them and store them on a github release (hopefully they will accept a 250MB file) so that travis fetches that instead of building it itself when it's not in the cache. I've kept it the way it is right now because it's more transparent - you don't get a binary blob from a guy that you don't necessarily trust but you can see it's all building from the sources.
But yeah, as i said, if that still bothers you, I can prepare a tbz/package to be fetched.
I'd suggest continuing this cross compiler discussion on slack because this PR is starting to become huge :)

The upside of having Mingw builds now is that as soon as someone writes some code that doesn't compile there, the test is going to fail
Which our Appveyor build also tells you already.
I also don't see why we need a cross-compiler if we could just fetch the latest build from appveyor and be done with it.

By "there" I mean with MinGW. There are some code quirks and changes that are needed to make it compile with MinGW even though it already compiles on Windows, with AppVeyor. (see: reinterpret_cast changes in search.cpp, for example). I'm not happy about it either but it's not me who makes the rules for compilers :).
If MinGW would be 100% compatible with MSVC, this whole PR wouldn't be needed at all.
I just want to prevent the case where the runtime tests fail not because BI guys changed something but because our changes have made the source not compile with MinGW. And also I would like to stress the need for the possibility to compile it with MinGW instead of just fetching a binary compiled in AppVeyor: you can then get any Intercept version, not just the latest master branch.

You can also get any Intercept version from Appveyor. Every push get's built and archived.

I guess we can remove this one, eh?
Since Intercept has been using Github Actions that normally build everything for both OS-es we don't have any need for cross-compiling. Not that this code has been updated in the last 4 years :P


bugfix and bump version to 0.1.5

Current coverage is 83.75%

Merging #200 into master will not affect coverage as of e71843e

@@            master    #200   diff @@
======================================
  Files           19      19
  Stmts          954     954
  Branches         0       0
  Methods          0       0
======================================
  Hit            799     799
  Partial          0       0
  Missed         155     155

Review entire Coverage Diff as of e71843e

Powered by Codecov. Updated on successful CI builds.

:+1:

To see the actual diff, refer to:

https://github.com/bigchaindb/bigchaindb/compare/0.1.4...9f62cddbaf44167692cfee71db707bce93e3395f


Webpack. Async chunk loading

I have an SPA apllication. It created it using vue.js, webpack. A ClientApp folder size - 422 Kb (contains components only). It's because I developed this application 4 months.
I have a components and loading it using lazy loading. Now I'm trying to split code using optimization property. But I can't understand how to do it. The bundle file size 687 Kb, but I need not bigger than 100 Kb.
I tried:
optimization: {     splitChunks: {         chunks: 'all'     } }
If I use it, I have the bundle size 28 Kb. Also I get new file (vendor) 658 Kb. And I need to include this file too, because without it render is failure. But after that nothing is changed.
I want to load the code required for initial render, after that load another code in async mode.
How can I do it? And is that possible?

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.


fix converterMap key for custome Converter

fixed #170

Kindly include a summary of changes along with the relevant test cases.
请添加修改说明和对应的测试用例。

test cases has been submitted

note:Ready for next release version.


[rancher-compose]

Rancher Versions:
Server: 1.3.1
healthcheck: 0.2.0
ipsec: 0.0.2
network-services: 0.0.8
scheduler: 0.3.0
kubernetes (if applicable): n/a
Docker Version:
1.11
OS and where are the hosts located? (cloud, bare metal, etc):
AWS, RancherOS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA Rancher (3 nodes)
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
When using rancher-compose, there should be a way to update services to a new version of a container, and make sure the new containers are in a running state before exiting.
Currently, you can use -d to detach, but then you get no feedback if there was an issue launching a container (cannot pull, out of disk space, etc). If you do NOT specify -d the command never exits automatically. This makes it hard to script a deploy.
I would like for some way to verify the service you are modifying gets to a healthy Upgraded state, rather than continuously failing to start the new image.

@drpebcak have you tried using the -w flag? According to this doc it might do the trick in conjunction with --confirm-upgrade

Unfortunately, -w is only good with the upgrade command, which doesn't take the rest of the options I want.
It looks like upgrade is only really good for doing things like scaling a service or updating links.
The actual update functionality I'm looking for is only available through the up command (modifying a service in place based on the contents of a docker-compose file).

Closing in favor of https://github.com/rancher/rancher/issues/8492
By fixing -w for rancher up, that should fix your original issue.


What data we need as the input

Hi
I have tried unsupervised segmentation using your codes, and confirmed working with VOC2012 dataset. Thanks for great attempt and source codes.
Im trying them with own dataset.
The question is 'What data should we exactly need to prepare?'.
When VOC2012, I prepared raw images, segcls, hed, pretrained weight, sbd_clsimg by downloading. However, I cannot prepare some of them because segcls are, for example, made by Matlab codes.
When I tried with only use raw images, the code is working. Is that correct?

Hi @yuchan-san,
Thanks for your interest in trying out the code!
For unsupervised segmentation, training would require raw images, hed, and trained weights.  Others would not be necessary.  However, if you'd like to obtain a quantitative evaluation, you'd need segcls as well, which is simply the ground truth encoded in the UINT8 format.
I hope this helps.
Best,
Jyh-Jing

Hi @jyhjinghwang
Thank you very much for your quick reply. I now understood that.
Although it has written 'segcls' on the used image path 'train+.txt', but you are replacing 'hed' in image_reader.py. right?
eg1, 'VOC2012/JPEGImages/2007_000032.jpg VOC2012/segcls/2007_000032.png' in train+.txt
eg2. 'seg = mask.replace('segcls', 'hed')' on line 172, in image_reader.py.
So, we need Matlab to calculate hed. Can I replace it to other method instead of 'gPb-owt-ucm'?
Additionally, hed means contours of grayscale right?, not edge detection.
If so, we can use SLIC functions for it at skyimage library.
Do you have any idea for that?

Yes, generally you can replace the HED-owt-ucm oversegmentations with any other masks.   I've also tried SLIC which would work.

Perfect!
Thanks so much.


Documentation error

Hi @kumailht,
There might be a documentation error in the Read Only Information section.
You have an example with a 'read-only-information' class:
`
Product Specs
`
I think the correct class is 'flakes-information-box'.

@codegaze Thank you for reporting this!
If you'd like to further contribute to the project, why not make a pull request?


Clean Up repo history

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Current git history contains binaries that should be ignored.
Clean up history so on git checkout they won't be included

main branch now has the history all cleaned up and force pushed. Developers and contributors may need to re-checkout the repo to see the new history.


Websocket handshake fails using a http proxy

First of all, thank you for your great work, the current version works very stable for me.
If i use a http proxy, the connection fails:
URI proxyUri = new URI("http", null, proxy.host, proxy.port, null, null, null);
WebOptionsBuilder webOptionsBuilder = Whatsapp.webBuilder()
                        .newConnection(UUID.fromString(session.uuid()))
                        .name(session.name())
                        .proxy(proxyUri)
                        .historyLength(WebHistoryLength.extended());

Presumably this is because the websocket handshake payload contains the wrong Host:
In WebSocketClient:
private CompletableFuture<Void> handshake(String path) {
    var payload = generateWebSocketUpgradePayload(path);
    return underlyingSocket.writeAsync(ByteBuffer.wrap(payload.getBytes()))
            .thenComposeAsync(writeResult -> readWebSocketUpgradeResponse())
            .thenComposeAsync(this::parseWebSocketUpgradeResponse);
}

The payload is:
GET /ws/chat HTTP/1.1
Host: proxy.host:1234
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: DludGb/DusK1iE8OHJVNHw==

If i fix up the handshake payload during debugging:
payload = payload.replace("proxy.host:1234", "web.whatsapp.com")

The connection works as expected.

Thanks for reporting, will be fixed in 0.0.8, eta next week


Fixed memory leaks in BuildExtremas and ComputeLocalization kernels

Added disposeIntermediateTensorInfo to BuildExtremas and ComputeLocalization kernels.
BuildExtremas is a bit odd, but I think what is happening is that tidy() is catching the original image0  and image2 tensor references. And not the ones we overwrite them with since this occurs inside of a kernel function.

@jmschrack  Why do you think there is memory leak?  I did a quick check using tf.memory() and the usage statistics stay the same across time.
I guess tf.tidy does pick up the garbage left over from engine().runKernel, whereas runWebGLProgram (used in other kernels) doesn't.

Hmm.... it's been a too long for me to remember exactly.  But I can't recreate the memory leak either.  I'll close it for now, but i'll leave this branch up in my fork in case we need to revisit it.


There are no docs which leads to lower than desired adoption and contribution rate

Currently there are no docs for bs-react-native.
We can just put comments for every api and docs will be auto generated.
@chenglou, Is there specific format of comments you prefer? Where it will be auto generated?

Possible duplicate https://github.com/reasonml-community/bs-react-native/issues/14

yes, closing.


Add another CSV path

Another CSV Path should be added to add additional metrics for the baseline graph

Issue not needed since it is fixed by the graphProvider


added url scheme in host name. Added support for backword compatibility

///////////////////⚡///////////////////
🚫 AWESOME A PR!
Added fix for https://github.com/danger/danger/issues/784.
I am not a ruby expert so I am not sure if this code will work 💯%.
///////////////////⚡///////////////////

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

          1 Warning

:warning:
Tests were not updated

          1 Message

:book:
@RishabhTayal is not a contributor yet, would you like to join the Danger org?

  Generated by :no_entry_sign: Danger

This looks great, 👍 - to add a test to this, add some space here
Then add something like this:
    it "handles http hosts" do
        env = stub_env
        env["DANGER_BITBUCKETSERVER_HOST"] = "http://my_url..."
        api = described_class.new("danger", "danger", 1, env)
       expect(api.pr_api_endpoint).to.equal("http://my_url/things/pull-requests/1")
   end

And that fail is legit - your changes would make changes to that test 👍

@orta I added a test case and CHANGELOG.md. Please review.

You still have two failing tests:

@orta Fixed!

Awesome, this looks good. I'll ship it 👍

Alright - this has gone off in 5.0.1 - thanks @RishabhTayal, this was a great PR
also, I've invited you to the org, as a part of Moya Community Continuity - you're welcome to participate in PRs and help out at a level that works for you.

Awesome. I not sure if I have the skills to contribute in ruby, but definitely going to try and contribute. +1

@orta found a issue where it's always using ssl while making http call. refer: bitbucket_server_api.rb. Will create another PR to fix this.

👍


Extension problem

Steps to reproduce

Opening Animixplay & Gogoanime Extension
Clicking on any Anime

Expected behavior
I want them to stay in English names
Actual behavior
Before opening any anime in Animixplay & Gogoanime extension it's name is in English but after opening it will be in Japanese permanently. This is a great problem for library. I don't remember japanese names so can't search them
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
Android 10
Device
Realme 7 Pro/ RMX2170
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

To add/fix extensions, make a github issue here if it does not exist already
https://github.com/aniyomiorg/aniyomi-extensions


Add text style support in reader

Add text style support in reader including tables.

Wdym, it already supports custom color, font, size and margins.


Implement autocomplete jump to identifier on package page

If user types "#" in search box on package page, then display autocomplete typeahead for exported identifiers on the page.  When user hits enter with leading "#" in query, then jump to the anchor instead of searching.
http://twitter.github.io/typeahead.js/ will be useful in implementing this feature.

That's what I miss now. :+1:

Can this be done in the same way I've implemented jump to identifier on gotools.org? When you press R anywhere on the page, a select-list-view with all identifiers appears. Typing filters/searches through the list.

Maybe.  Where's the code?

First, take a quick look at this sample of godoc.org/net/http page with the select-list-view component added (focus the page and press R to open it).

https://dl.dropboxusercontent.com/u/8554242/temp/gddo-with-select-list-view-demo/index.html
The only change to the the .html (aside from turning relative paths into absolute paths) is:
--- original.html
+++ modified.html
@@ -4,6 +4,7 @@
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.1/css/bootstrap.min.css" rel="stylesheet">
   <link href="https://godoc.org/-/site.css?v=bf1ccd6efc28f5d787d7c28c6d1c8d97e5ec1b47" rel="stylesheet">
+  <link href="select-list-view-style.css" rel="stylesheet">

   <title>http - GoDoc</title>
@@ -2663,5 +2664,6 @@
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
 <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.1/js/bootstrap.min.js"></script>
 <script src="https://godoc.org/-/site.js?v=d652d20bb449139d8586d925bdadedf46bdf64c5"></script>
+<script src="select-list-view-script.js"></script>
 </body>
 </html>

The reason it works with just .js and .css is because, by default, select-list-view component gets all of its entries by taking all <h3> and <h4> elements on the page. godoc.org already uses those elements for all the entries on the page. But I would imagine we'd want to tweak things further to achieve an optimal experience.

Maybe. Where's the code?

The code is at https://github.com/shurcooL/frontend/tree/master/select-list-view. The README in repo root explains things and shows how to get started. It's written in Go and can be compiled to JavaScript using the current version of GopherJS.

I think it's possible to implement the feature in a few lines of Javascript using existing dependencies.

It is a few lines of Javscript. I'll have something soon.

I agree, it is possible to implement this feature in a few lines of JavaScript using existing JavaScript dependencies and in a few lines of Go using existing Go dependencies.

I think this issue has been resolved via #242.


Rename Completion Queue to Poller

@nathanielmanistaatgoogle and I discussed changing the name Completion Queue to something different given its semantics in #1577. This change renames it from Completion Queue to Poller. It's probably not finished, but before spending too much time on it I wanted to see what people thought of the name, and to get #1577 in (this change will be complicated but semantically a no-op, the other is complicated enough already).
@a11r - any thoughts on the name?

My 2¢: it isn't really a 'poller', though, from the user code perspective. One polls it rather than it doing any polling. What we're popping off the queue are events (and not necessarily completion events, either - they're events associated with just about every GRPC core structure). I believe the name should reflect the direction of action between the user code and the API, and would thus prefer that at least queue somehow be kept in the name with the completion_ part perhaps changing to something more general.


Should functions like min_snr_proj_temp_prof return the profiles they create?

Might that make it easier for the user to interact with some of these functions? Rather than then having to go into the get methods of the source?

Yes they should, its actually quite convenient sometimes and I have implemented it for certain functions (like the hydro mass convenience function)


Tutorial Beijing Shapefile

In this section of the tutorial, https://mobilkit.readthedocs.io/en/latest/examples/mobilkit_tutorial.html#Create-tessellation-from-points, the file "DT19new/PopCensus2010_township.shp" is not in the data downloaded from the link, which appears to be for a different dataset "DT41". I was able to find the files for DT19 (https://www.beijingcitylab.com/app/download/12184598199/DT19_v2.zip?t=1644650253) on the website, and then follow the tutorial as expected, so perhaps the link in the tutorial needs to be changed.
https://github.com/openjournals/joss-reviews/issues/5201

Hi @ifthompson  , thanks for spotting this typo, we fixed it in ab1c93c.
Closing this issue.


Allow for more than one NODE to be connected to BOS telegram bot

Tried to connect my second node, while the first one is running quite successful already.
On the second node, I ran

bos telegram
Requested the same API code from BOT-father
Added API code to the new code
Triggered /connect in TG prompted the following error in the new node

? Connection code? (Bot command: /connect) (node:28877) UnhandledPromiseRejectionWarning: Error: 409: Conflict: terminated by other getUpdates request; make sure that only one bot instance is running     at Telegram.callApi (/home/bos/.npm-global/lib/node_modules/balanceofsatoshis/node_modules/telegraf/lib/core/network/client.js:258:19)     at processTicksAndRejections (internal/process/task_queues.js:93:5)     at async Polling.[Symbol.asyncIterator] (/home/bos/.npm-global/lib/node_modules/balanceofsatoshis/node_modules/telegraf/lib/core/network/polling.js:27:33)     at async Polling.loop (/home/bos/.npm-global/lib/node_modules/balanceofsatoshis/node_modules/telegraf/lib/core/network/polling.js:69:30) (Use node --trace-warnings ...to show where the warning was created) (node:28877) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag--unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:28877) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Desirable result would be to have both nodes connected to the same tg BOT and report independently

Arg, wrong Project, Please disregard


Training ERROR (train_config.json)

AttributeError: 'DatasetV1Adapter' object has no attribute 'element_spec'
Hello,
I have similar issue with the training step. I found that the output is in .json format and not in .tar.gz. assuming the .json format file is not the output for the trained model since the script says the output should be in .tar.gz format. I'm currently just testing out the scripts with the sample dataset Tomo110 (1 tomogram) that has been split to even and odd. I was able to get both training and validation data from the 1st script.
I look forward to hearing from you. Thank you for your time and cooperation.
Best Regards,
Virly A.

Duplicate issue, please see https://github.com/juglab/cryoCARE_pip/issues/13


Integrated ROM e2e tests

This PR creates 2 e2e tests for the Darjeeling ROM:

A smoke test that boots the real base ROM and jumps to a minimal second stage test ROM
A patched second stage ROM, that boots the real base ROM, applies a patch and jumps to the patched second stage test ROM

To implement those basic e2e tests, this PR:

Adds a second ROM to the verilator TB
Adds a second ROM image option to the opentitanlib verilator backend
Adds a second stage test ROM, with a weak second_rom_test_main() symbol to integrated ROM e2e tests to override

This PR is built on top of and obviously depends on the pending https://github.com/lowRISC/opentitan/pull/20344.

A couple of points re the PR itself; would it perhaps be preferable to make it clearer that the 'base_' and 'second_' files have been produced by copying the existing 'rom_' files? If a first commit involved just copying of the original files, with an explanatory comment, then the secondary commit would show only the introduced deltas, making it much easier and quicker for others to review.

@alees24 I did that now, hopefully it's clearer.

Secondly, I think it would be beneficial to separate out the patch generation from the ROM and patch application code, since the former is not as time-critical (and ideally will not even be needed).

This done as well. This PR now only contains the patch application code and the patch library.

Thanks again @alees24 and @pamaury for your reviews. In the meantime, @sameo has implemented your feedback (thank you, too!), so could you please check if this PR now gets an approval from your side?

Thanks @sameo for all the work you've put into this, and thanks @alees24 and @pamaury for your thorough reviews!