Mege in master branch from catalogueglobal which has all the tags.

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing
[x] The description lists all relevant PRs included in this release
[ ] e2e tests are all passing
[ ] Code coverage does not significantly worsen (ideally it improves)

Description
This PR merges in all relevant tags that were created in the master branch of the catalogue global datatools-ui repo. This should allow semantic-release to be able to make releases again.

Codecov Report

Merging #488 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #488   +/-   ##
=======================================
  Coverage   16.27%   16.27%
=======================================
  Files         309      309
  Lines       15308    15308
  Branches     4666     4666
=======================================
  Hits         2492     2492
  Misses      10954    10954
  Partials     1862     1862

Flag
Coverage Δ

#unit_tests
16.27% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fe8b5...b4163e2. Read the comment docs.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enhanced Footer UI by aditya

The UI of the footer has been enhanced by changing the format and user friendly #378


SB Only Increments Message Sequence Count Where There are Subscribers

In the current implementation of the Software Bus, sequence counter management is handled in the routing table.  The routing table only includes entries that have subscribed messages.  This results in the sequence counter being incremented only if there are subscribers to a message.  If a message is unsubscribed to and then resubscribed, the sequence counter will be reset to zero.
A message sequence count should reflect the production of the message vs. the receipt of a message.  One use case for this implementation is to support the filtering of a message via the sequence count.
APL/SPP project implemented a solution to increment the sequence count upon production of the message regardless of whether or not there are any subscribers.  The solution involved removing the sequence count table from the routing table.  This exact solution may not support the new/expanded APID/message ID name space.  Expanding the message ID name space will need to be considered when implementing the overall solution to increment the sequence count to reflect message production.

Imported from trac issue 70.  Created by sstrege on 2015-06-17T14:30:51, last modified: 2019-07-08T14:26:30

Trac comment by glimes on 2016-10-18 15:07:03:
Remove my name from many tickets (where it was applied by default), so others can tell that there are tickets that need some attention.

Trac comment by sstrege on 2016-08-26 13:55:09:
This is a feature of the software bus that most missions/projects have been living with unaffected.  This ticket has been deferred as it is not a high priority to change the software bus implementation on how sequence counters are incremented.

Trac comment by cdknight on 2018-10-22 14:58:42:
See [changeset:9a84396], this can be accomplished simply by allowing routes to have zero destinations. This has the benefit of only tracking sequence counts for ID's that are or were subscribed to and all new ID's start at seq id 0.

Trac comment by jphickey on 2019-02-21 16:07:26:
Looking at the old CCB notes from 2018-10-23, it looks like this change set was CCB approved but never merged.
I did a squash merge onto branch ic-jph-20190221 (to clean the history a bit) and the complete changeset is in commit [changeset:c0a3246a].
HOWEVER: this seems to trigger a failure in the SB unit test, as follows:
{{{
[ INFO] ut_stubs.c:223:Unexpected return in maximum message ID count test, i=255, exp=0x0, act=0xca000009
[ FAIL] 09.008 sb_UT.c:4621 - Test_Subscribe_API - Maximum message ID count test
}}}

Trac comment by cdknight on 2018-10-23 13:32:24:
Need to consider IsValidRouteIdx logic, events should be sent when no subs.
Should evaluate whether there's a unit test for no subs event.
SB 4305.5

Trac comment by jhageman on 2019-02-25 16:26:54:
Needs unit test update

Trac comment by jhageman on 2019-03-01 07:47:12:
CCB - review options and provide direction.  Email chain indicates this was seen on JHU/APL version of to/ci that unsubscribes/resubscribes on a table change (not how GSFC does it).  Seems to fall in the "different functionality" bin with associated trade-offs (bigger footprint, possibly slightly more efficient).  Recommend a document update for current behavior description, and the possible alternative approach that APL used.

Trac comment by jhageman on 2019-04-25 14:13:49:
CCB/community discussion needed on path forward options, see [comment:12 Comment 12].  CCB Agreed on 4/24/19 the counter resets don't comply with the CCSDS standard.

Trac comment by jhageman on 2019-04-24 12:28:02:
CCB discussion - Should follow CCSDS (resets should not happen), mark as bug

Trac comment by jwilmot on 2019-05-01 13:33:02:
The counter should increment on send as intended and per standard. It will have a performance impact on send with no subscribers but should have low impact to normal sends.  APL’s implementation to remove the counter from the routing table and add a separate counter table sounds good and would decouple the routing from the sequence counter.  The sequence counter table would be relatively small, (CFE_PLATFORM_SB_MAX_MSG_IDS size, default=256) and would be indexed by MsgKey (same as index into routing table).  Also remove the logic to reset the counter on subscription. The extended msgID is currently handled up to that same limit.  Large missions may need to change that and the CFE_SB_MsgKeyToValue logic.

Trac comment by jhageman on 2019-05-01 14:02:59:
Moved back to assigned to work Jonathan's suggestion.  Feel free to move back to review if CCB discussion is needed, or mark for redispatch if an owner change is desired.

Trac comment by jhageman on 2019-07-03 12:58:32:
Moved unfinished 6.7.0 tickets to next release

Trac comment by jhageman on 2019-07-08 14:25:14:
Moved ic-jph-20190221 to trac-70-seqcnt-squash [changeset:c0a3246a] and removed out of date trac-70-seqcnt [changeset:9a84396].  Still needs actions based on comment:19.


Fix bootstrapping

test pr

This branch was automatically deployed to https://keystone-nex-develop-xjq9adr0k.herokuapp.com/ cool


Automatic termination policy

@mzeidhassan and other users require the implementing an automatic termination policy similar to that existing in 2.5.

This has been implemented in the v4.0, available right now.


improved error message for system cmd - config, logs

Signed-off-by: kernelpanic77<EMAIL_ADDRESS>Notes for Reviewers
This PR fixes #6266
Added user friendly messages for the following system subcommands:

[x] config
[x] logs

I am improving the error messages for dashboard, login, logout and token. Will add more commits to the same PR. Please provide feedback for config and logs subcommands.
Suggestions in cobra does not seem to work for sub sub commands.  For instance,
running
mesheryctl pattern aply

does not suggest "did you mean ? apply".
Signed commits

[x] Yes, I signed my commits.

Codecov Report
Base: 16.63% // Head: 12.33% // Decreases project coverage by -4.31% :warning:

Coverage data is based on head (b18e123) compared to base (fd85ca8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6930      +/-   ##
==========================================
- Coverage   16.63%   12.33%   -4.31%
==========================================
  Files         116      116
  Lines       15931    15932       +1
==========================================
- Hits         2650     1965     -685
- Misses      12805    13653     +848
+ Partials      476      314     -162

Flag
Coverage Δ

gointegrationtests
?

unittests
12.33% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/config.go
5.22% <0.00%> (-0.04%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
4.00% <0.00%> (-43.02%)
:arrow_down:

mesheryctl/pkg/utils/platform.go
6.79% <0.00%> (ø)

mesheryctl/internal/cli/root/system/start.go
1.56% <0.00%> (-54.07%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.51% <0.00%> (-53.79%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.00% <0.00%> (-46.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.73% <0.00%> (-43.48%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.66% <0.00%> (-42.67%)
:arrow_down:

mesheryctl/internal/cli/root/root.go
25.49% <0.00%> (-40.20%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@kernelpanic77  Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@abdullah1308 will you review?

LGTM


Fix memory leak in ReceivedMessageQueue

What problem does this PR solve?
Issue Number: close #7951
Problem Summary:
What is changed and how it works?
The root cause is object stored in PODArray must be POD object, and clearly LooseBoundedMessageQueue is not a POD object
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/approve

/run-all-tests

/rebuild

/run-integration-test


sequelize sync adding the beginning structure to routes

double check please!!

Hi Antony, could you please add one more route for Quiz. We have a table called quiz. I have added all tables and their associations in Model.
Also could you please rename answerRoutes.js to choicesRoute. Because that table is named as choices and it stores the 4 choices of a question. Then the naming convention would be uniform.

Should be right! I fixed a typo in the User.js from model.export to module.export!

I am developing more fixes with the next branch in session helpers


suggestion : Resize pinned datatip display

Description
I often use this function when I usually code. However, there are times when I want to see more at a glance when I look at the api of each language. There is an inconvenience because the size can not be adjusted here. So I would like to be able to adjust the size of the pinned data tip freely.

Thanks for the suggestion, I believe this should go in https://github.com/facebook-atom/atom-ide-ui.


Bump deps

Coverage remained the same at 90.501% when pulling 21d2a8ca7954cc8222cefb7764faba82c24cd0db on bump-deps into 36f331500eb9e8907504893a30b9a0da3cce88c4 on main.


Scroll goes too far down if participant executes command on terminal

Describe what happened:
While running a live share session, if the guest/participant is given write access to the terminal, upon executing a command (e.g. executing a w in a debugging breakpoint with ipdb, which outputs quite a few lines), terminal scrolls down too much, losing the contents and forcing to always scroll back up.
What was your system configuration?
Product and Version: VSCode 1.43.2
OS Version: macOS Catalina 10.15.4
Live Share Extension Version: 1.0.1847 (Last updated 25/03/2020, 19:39:28)
Target Platform or Language: Python
Exactly the same configuration both host and guest/participant.
Steps to Reproduce / Scenario:

Host starts a live share session and invites participant
Host opens a terminal
(our scenario specific) Hosts shells into a Kubernetes pod with code that contains an ipdb breakpoint
Breakpoint is hit and terminal awaits debugger input (everything correct so far)
Participant requests write access to terminal. Host grants it.
Participant types for example w and enter (command to display a very verbose call stack trace)
Terminal shows briefly the content then scrolls down until is all black and cursor is "in the void". Both host and participant need to scroll back up a few lines to see the end of the content.

Tested with host creating both a read-only terminal -> participant asking for write access -> access granted, and host directly creating a terminal with write permissions for the participant. As soon as participant runs some command with a few lines of output the scroll glitches.
Note: Both host and participant using same terminal height (default one upon booting up VSCode) to avoid possible bug https://github.com/MicrosoftDocs/live-share/issues/2855.
Note II: Cannot provide logs due to company policies.

Thanks for reporting this issue. We'll try to reproduce it ourselves to see what's going on.

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.


Added CatChen/check-git-status-action@v1 to the build Workflow

Current dependencies on/for this PR:

main

PR #259

PR #260

PR #261

PR #262   👈

This comment was auto-generated by Graphite.


Can't do anything but to scale a rendered model inside a build application

Hi,
Bug description
While inside an application build on HL2, the only interaction I can have with a remote rendered model is scaling.
Rotating and translating do not work on the model.
I tried with both the test model (the engine) and a custom model (bigger than the test model although with less polys).
Inside the editor, interaction are working well (rotation, translation, scaling)
Checking via the editor, the box  collider is active and inside the app, the bounding box is working well.
Setup

MRTK 2.4
Unity 2019.4 LTS
Legacy pipeline

Additional Info
A short video showing off the issue.
https://www.youtube.com/watch?v=3gDdLHyuUKM&feature=youtu.be

Hi Mauryl,
can you provide a snippet that takes care of the position changes? Are multiple scripts touching the same object?
Does the ShowcaseApp work for you?
It looks like some script is resetting the position, it might be script execution ordering being different between editor and build app causing this to happen only on device?

Hi @janekvap !
I haven't tested the showcaseApp.
I have just followed the tutorials inside a newly created project.
I do not have any other interactions on the models beside the ones allowed by the (cloned) ObjectManipulator.cs and the only scripts I am using are the ones that I have created while going through the tutorials.

Sorry for long pause, I was out of office.
I can reproduce the issue with the stock tutorials and there seeems to be more than one comparing editor to device run.
I will let you know if there is fix you can try locally before we make it on our side and get it into some release.

Hey! Thx for the update!
I will wait then :)

There is WorldAnchor added to the entity root which prevents it from moving.
You can go to RemoteRenderingCoordinator.cs line 362 (LoadModel) and remove the code adding WorldAnchor component from there.
If you need it the world anchor should be on object one more level up, that is not movable and acts as a stage for models.

Ah! It is working like a charm ! Many thanks !


Feature: autofill username, GUI tweaks

This is cumulative, based on the previous xcode-6-updates branch, so you may want to eval/merge that first, and optionally merge this to a topic branch outside of master for now.
Added an import to use the SCDynamicStoreCopyConsoleUser method of grabbing the current user, which therefore only leaves the password field for end users to fill in.
Also added an awakeFromNib(self) function to run the console user check and populate the field, could use some more testing.
Since we wouldn't get here without a successful auth I thought it wouldn't be useful to allow changing their mind about what user to escrow with, so I disabled username field.
Updated wording as a result, did a tweak to hopefully fix an issue with the cursor not appearing in the password field when activated.

(addresses #21, for those playing along at home)


Add global auditor definition to config

Tracker story: https://www.pivotaltracker.com/story/show/134374455
Signed-off-by: Michael Xu<EMAIL_ADDRESS>

Thank you, michaelxupiv


Error while running face_spoofing.py

this is the error it shows :
ModuleNotFoundError: No module named 'sklearn.ensemble.forest'

Any update on this?

Upgrade your scikit-learn to latest version


set up Travis for continuous integration and deployment to PyPI/Github

hey Tal,
we need to publish extractor on the python package index, similar to what we did for ufoLib, defcon, fontMath etc. (extractor is required by TruFont, among others).
The problem is that the package name "extractor" is already taken by some old bindings for GNU Libextractor, so I had to find an alternative name, "ufo-extractor" (doesn't matter hyphen or underscore, as pip normalizes them anyway).
Note that this is only the name as it shows on the index, not the package import name, which of course we don't want to change.
In order for this to work, you need to log in your Travis CI account and enable the extractor repository from there.
Then we can merge this PR and make a v0.2.0 tag, which will be uploaded automatically to PyPI. I'll take care of that. I just need you to enable Travis on the repo.
Thanks

Just to clarify a typo in the previous message:
For this PR for work, @typesupply (the owner) needs to enable Travis CI on the repository, since this is a personal repo (not an organizational one). Thanks.

This basically means:

go to https://travis-ci.org/typesupply/extractor
click "Activate Repository"

... or just give me admin access ;)

Done.

thanks a lot, sorry for my insistence 😬

Name: ufo-extractor is fine. Will that mess up existing imports?

No, as I said, the import name stays the same.
The only thing that changes is the way you install it:
pip install ufo-extractor (or which is equivalent, pip install ufo_extractor)

or if you do pip list it will show up as ufo-extractor in the list of installed packages

Got it. Sorry. Lots of stuff on my mind at the moment.

no prob. I guess we should document this in the README.md.
I'll take care of it.
Thanks Tal

OK, I just added a basic README and tagged v0.2.0.
The package is now published on PyPI:
https://pypi.python.org/pypi/ufo-extractor


version change to 0.4.1

New UI workflow integration

Separation of website and network data management

Ability to cancel uploads
Show file count status while uploading folders
Open the download folder instead of opening the downloaded file
Initial root folder creation failure recovery
Show initial authorisation stages on loading
Ability to remap service home directory
Option to delete a service
various bug fixes and UX updates

This change is

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)


a way to change the position of the subtitle

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
so i want a way to change the position of the subtitle. like moving it up or down so that i can both see the English subtitle and the one that i loaded simultaneously
Describe the solution you'd like
A clear and concise description of what you want to happen.
N/A
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A
Additional context
Add any other context or screenshots about the feature request here.
N/A

closing this now as i was able to find out how


Heroku compatibility

Add one of those deploy to heroku buttons

My fork runs on Heroku just fine: https://github.com/MTRNord/electron-crash-report-server
Web Username can be defined with env var "user"
Web Password can be defined with env var "pass"
Port Env is added for Heroku.
But: I removed the config vars for it (I had no use for it :) )


Error when retrieving apt key on Ubuntu 14.04

On Ubuntu 14.04 machines, when I run 'ansible-playbook playbook.yml', I receive the following error:
fatal: [xxx.yyy.zzz.aaa]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to validate the SSL certificate for sks-keyservers.net:443. Make sure your managed systems have a valid CA certificate installed. If the website serving the url uses SNI you need python >= 2.7.9 on your managed machine or you can install the urllib3, pyopenssl, ndg-httpsclient, and pyasn1 python modules to perform SNI verification in python >= 2.6. You can use validate_certs=False if you do not need to confirm the servers identity but this is unsafe and not recommended. Paths checked for this platform: /etc/ssl/certs, /etc/pki/ca-trust/extracted/pem, /etc/pki/tls/certs, /usr/share/ca-certificates/cacert.org, /etc/ansible"}

Dear Michael,
thank you for reporting this issue.
I'll investigate it and provide a fix ASAP. :)
--
Andrea Tosatto
On Oct 4, 2016 6:52 PM, "Michael Klatsky"<EMAIL_ADDRESS>wrote:

On Ubuntu 14.04 machines, when I run 'ansible-playbook playbook.yml', I
receive the following error:
fatal: [xxx.yyy.zzz.aaa]: FAILED! => {"changed": false, "failed": true,
"msg": "Failed to validate the SSL certificate for sks-keyservers.net:443.
Make sure your managed systems have a valid CA certificate installed. If
the website serving the url uses SNI you need python >= 2.7.9 on your
managed machine or you can install the urllib3, pyopenssl, ndg-httpsclient,
and pyasn1 python modules to perform SNI verification in python >= 2.6.
You can use validate_certs=False if you do not need to confirm the servers
identity but this is unsafe and not recommended. Paths checked for this
platform: /etc/ssl/certs, /etc/pki/ca-trust/extracted/pem,
/etc/pki/tls/certs, /usr/share/ca-certificates/cacert.org, /etc/ansible"}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/atosatto/ansible-dockerswarm/issues/6, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA1LhgkUEcPxD6bcz-7kVJXLrcdkFRVPks5qwoRXgaJpZM4KN6NT
.

Hi @mklatsky.
I've started working on this issue on #7.
Right now the issue should be fixed. Before merging it into master I have to fix a small regression with Ubuntu 16.04.
Could you give it a try to give me some feedbacks?

When I used the updated version, I was able to successfully created a docker swarm cluster without error. Thank you!
Let me know if there is additional information you require.

Hello! I'm having the same issue

Hi @Mehonoshin.
I've currently working to fix this problem on PR #7.
Everything should now work on Ubuntu 14.04. but, before merging on master I would like to implement some checks to skip the "Install the Python SNI support packages" on Ubuntu 16.04.

@atosatto great! Meanwhile I'll test your branch on my environment

@Mehonoshin awesome! :) Keep my posted with the result of your tests.

I've just updated the f-issue6branch to e50158f.
@mklatsky and/or @Mehonoshin could you please give it one more run to be sure that everything is still working?
Thank you :punch:

@atosatto I've tested role on two Ubuntu trusty VMs inside vagrant. Everything looks good for me!

Thank you very much for your support.
I've now released version 1.3.0 containing this fix for Ubuntu 14.04.


TSLint causes TS features to become unresponsive on incorrect react component syntax.

I think I've got this broken down to the bare minimum number of steps to reproduce, and it's been happening for a while. I'm wondering if it's related to #55, but I can't guarantee that it is. It might be that this breaks on any sufficient number of TypeScript server errors, but here's the set of steps:
Environment: W10 (multiple editions)
VSCode version: All so far, including the latest insiders
TSLint version: 1.1.0

create tslint.json and ./src/test.tsx files (source below)
open src/test.tsx
wait for language features to initialize
go to the appropriately commented line
enter a letter, delete, and repeat.

After a few times (reliably 5 times for me), the error underlines, outline, autocomplete, and other related features stop responding.
This behavior doesn't occur if the TSLint extension is disabled or not installed.
tslint.json:
{
    "extends": ["tslint:recommended"]
}

test.tsx (NOTE: The outer div seems to be important here. Removing it prevents the crash):
const val: number = 1;

const Component = () => {
    return (

            {val === 0 ? (
                "test"
            ) : (
                // enter something here.

            )}

    );
};

export default Component;

Thanks for the repo steps. After testing this, from the logs I believe this is actually a TS error:
  ERR TypeScript Server Error (3.6.0)
Debug Failure. Did not expect JsxExpression to have an Identifier in its trivia
Error: Debug Failure. Did not expect JsxExpression to have an Identifier in its trivia
    at addSyntheticNodes (tsserver.js:121781:30)
    at createChildren (tsserver.js:121770:9)
    at NodeObject.getChildren (tsserver.js:121714:56)
    at find (tsserver.js:97255:30)
    at find (tsserver.js:97275:32)
    at find (tsserver.js:97275:32)
    at find (tsserver.js:97275:32)
    at find (tsserver.js:97275:32)

This is being tracked upstream by https://github.com/microsoft/TypeScript/issues/25487


Invalid JSON syntax in .eslintrc

Hi there,
There's a missing comma on this line:
https://github.com/chentsulin/electron-boilerplate/blob/ec245c4e2863b7b29b1626cf2561cb27d1ca6049/.eslintrc#L11
Not sure if you are aware of it, but just wanted to let you know. 👍

Thanks!


why can't an existing buffer (with syntax) be displayed in a popup?

Is your feature request related something that is currently hard to do? Please describe.
I have a plugin which wants to display a few lines of the current buffer in a popup window, with syntax highlighting.  My current options are a) send a large enough number of lines to the popup for syntax highlighting to work or b) compute current buffer's syntax regions and use text properties in the popup to emulate it.  This seems slightly inefficient since it "wastes" a buffer and requires re-computation of syntax.
Describe the solution you'd like
I'm wondering what the reason is for the restriction that the popup window is a completely new buffer and can't display pieces of an existing buffer.  There could be a bufnr option to popup_create which re-uses an existing buffer (starting at firstline) instead of creating a new buffer.
Describe alternatives you've considered
Sending 200 to 400 lines to the popup and setting the filetype will essentially work, but it seems inefficient.
Additional context
This is also useful for "preview" of code definitions (like ptag except in a popup).

Is your feature request related something that is currently hard to do? Please describe.
I have a plugin which wants to display a few lines of the current buffer in a popup window, with syntax highlighting.  My current options are a) send a large enough number of lines to the popup for syntax highlighting to work or b) compute current buffer's syntax regions and use text properties in the popup to emulate it.  This seems slightly inefficient since it "wastes" a buffer and requires re-computation of syntax.
Describe the solution you'd like
I'm wondering what the reason is for the restriction that the popup window is a completely new buffer and can't display pieces of an existing buffer.  There could be a bufnr option to popup_create which re-uses an existing buffer (starting at firstline) instead of creating a new buffer.
Describe alternatives you've considered
Sending 200 to 400 lines to the popup and setting the filetype will essentially work, but it seems inefficient.
Additional context
This is also useful for "preview" of code definitions (like ptag except in a popup).

Not sure if this can work.  At least currently the 'buftype'  is set to
"popup", meaning that it can only show in a popup window.  It's true
that practically all the properties are on the window, not the buffer.
But if we would have a buffer associated with a file in a popup window
we get a lot of questions, such as what happens if the popup is closed?
I suppose we could make the buffer hidden then.  Or only make it hidden
when it has changes.  But you don't what that for when the buffer is
only used in the popup, it should just be deleted.
Perhaps it can work if we have two ways to create a popup:

No buffer specified, create a buffer with 'buftype' set to "popup".
A buffer specified, then the buffer is not deleted when the popup
closes, 'bufhidden' applies.  But if the buffer has changes it always
becomes hidden, no prompt for saving changes.

--
This is an airconditioned room, do not open Windows.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

A buffer specified, then the buffer is not deleted when the popup closes, 'bufhidden' applies.  But if the buffer has changes it always becomes hidden, no prompt for saving changes.

Ah, I do see the problem now.  I personally think it would make more sense that the user still gets a prompt to write the buffer when closing the last non-popup window which is viewing the buffer (assuming hidden/bufhidden are not applicable).  Otherwise if a plugin is displaying the current buffer, the behavior will change for closing an editor window.

A buffer specified, then the buffer is not deleted when the popup
closes, 'bufhidden' applies.  But if the buffer has changes it
always becomes hidden, no prompt for saving changes.

Ah, I do see the problem now.  I personally think it would make more
sense that the user still gets a prompt to write the buffer when
closing the last non-popup window which is viewing the buffer
(assuming hidden/bufhidden are not applicable).  Otherwise if a plugin
is displaying the current buffer, the behavior will change for closing
an editor window.

The user has no "normal" way to close a popup window, it is most likely
closed by a plugin.  That plugin should deal with it then.  It would be
interruptive if a prompt pops up while the user has no clue why the
popup closed (e.g., when it's going to be replaced by another popup,
might even be showing the same buffer).
--
Back up my hard drive?  I can't find the reverse switch!
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I suppose this is fixed as of 7964873afe59d0896a921b7c585167674bb784d5 so closing


Zencashjs and npm package bumps

Travis linux job 966.2 finished, you can download the results here.


thanos: upgrade dependency and default to v0.5.0

Per https://github.com/coreos/prometheus-operator/pull/2623#issuecomment-499153323 and https://github.com/coreos/prometheus-operator/pull/2629#issuecomment-499270790, this upgrades the thanos dependency and default to v0.5.0.

cc @brancz

Thank you so much for your awesome contributions! lgtm on green :+1:

I have no idea why that test would fail that way... If it's a real issue and not just a flaky test, it may be a few days before I can get to it.

That was a known flake. Restarted.

Thanks lgtm :+1:


HI, why ADMIN not ROLE_ADMIN ？

where to add the role ADMIN ?
i not found role ADMIN any where but ROLE_ADMIN
where change ROLE_ADMIN to ADMIN in the code ?

What are you talking about?  Please don`t question here unless you find some feature or bug.

sorry . 因为我的英文不是很好。原来你在控制中注释有相关的说明。
public class MethodProtectedRestController {

    /**
     * This is an example of some different kinds of granular restriction for endpoints. You can use the built-in SPEL expressions
     * in @PreAuthorize such as 'hasRole()' to determine if a user has access. Remember that the hasRole expression assumes a
     * 'ROLE_' prefix on all role names. So 'ADMIN' here is actually stored as 'ROLE_ADMIN' in database!
     **/
    @RequestMapping(method = RequestMethod.GET)
    @PreAuthorize("hasRole('ROLE_ADMIN')")
    public ResponseEntity<?> getProtectedGreeting() {
        return ResponseEntity.ok("Greetings from admin protected method!");
    }

}


Some relations in the Noctua GPAD are not being converted from labels to identifiers correctly

As part of our QC, @LiNiMGI and I noticed that there are annotations not passing because they have 'invalid' relations in annotation extensions. Here is the list:
Invalid Relation in GO-Property
GOREL:0000032  exists_during.
GOREL:0001019 results_in_division_of.
GOREL:0098790 regulates_translation_of.
RO:0002232 has_end_location
RO:0002449 directly negatively regulates activity of.
In the Noctua GPAD output, relations are represented by their labels, but in the 'new' GPAD, they are represented by identifiers. I think most of them have been updated (or the policy for their usage has been updated) and the following changes need to be made:
GOREL:0000032  exists_during.    ---> RO:0002491 (existence starts and ends during)
GOREL:0001019 results_in_division_of.    ---> RO:0002233  (has_input-new policy and should be changed in the models? Although I can't find any documentation)
GOREL:0098790 regulates_translation_of. ---> deprecated (2 annotations from SynGO. see below)
RO:0002232 has_end_location --->     This one is correct, but not in MGI.  These extensions are the result of an inference that isn't very useful, but we could add it.
RO:0002449 directly negatively regulates activity of. ----> RO:0002630 (I think this is an incorrect translation of 'directly negatively regulates' See below).
[Typedef]
id: regulates_translation_of
name: obsolete regulates translation of
def: "OBSOLETE. A relationship that holds between a process and a protein coding gene whose translation is regulated by that process." []
comment: Regulation of translation includes processes that regulate the levels of mature mRNA available for translation, as well as direct regulation of the rate of translation.
comment: Usage of this relation has been deprecated in favor of 'has direct input'.
subset: display_for_curators
subset: valid_for_annotation_extension
xref: GOREL:0098790
property_value: local_domain BFO:0000015 xsd:string
property_value: local_range "PR:000000001 SO:0000673 SO:0000704" xsd:string
property_value: usage "Relates a regulatory process or function to the gene whose translation it regulates." xsd:string {xref="GOC:dos"}
is_obsolete: true
Annotation in the original Noctua file:
MGI     MGI:1345138    enables GO:0140678     PMID:15962011  ECO:0000315                    20230504       MGI        part_of(GO:0045742),directly_negatively_regulates(GO:0060090)        contributor=https://orcid.org/0000-0001-7476-6306|noctua-model-id=gomodel:6446bfcb00001000|model-state=production
Annotation in Lori’s import file:
Invalid Relation in GO-Property (11:Annotation_Extensions,12:Annotation_Properties): cannot find RO:,BFO: id: RO:0002449
MGI:MGI:1345138        RO:0002327     GO:0140678     PMID:15962011  ECO:0000315                   2023-05-04     MGI     BFO:0000050(GO:0045742),RO:0002449(GO:0060090)        contributor=https://orcid.org/0000-0001-7476-6306|noctua-model-id=gomodel:6446bfcb00001000|model-state=production

from managers call:
perhaps a question for @balhoff - is there a stale mapping somewhere in the ontology build?
check ontobio for these IDs (maybe there is a mapping file somewhere that don't have the ids specifically)

sierra: follow up with a small group call: David, Li, Sierra, Jim, Kimberly, Seth to figure out the relations mapping


Do not be so strict on pinned depedencies

Hello,
Is it something you would be interested in? I mean, as a third-party module, the requirements are too strict IMO. For instance, using an up-to-date requests version will output:
ERROR: mediawiki-dump 0.6.7 has requirement requests==2.22.0, but you'll have requests 2.23.0 which is incompatible.

Thanks, @BoboTiG !


nodejs4.3 runtime support

Support for nodejs0.10 has been deprecated in Lambda. This adds the following:

nodejs4.3 runtime support
overrides nodejs with nodejs4.3 on function create/update

Overriding nodejs makes it easier to transition to the newer runtime without having to edit current .lamvery.yml files.

Changes Unknown when pulling 62fbe7b23110c6fc527ac8488bf3f7b74937a099 on ijin:node into ** on marcy-terui:master**.

LGTM 👍  Thanks!!


Support Proxy by Slack webhook Handler

Like #1383 , we have some use case to proxy only for Slack.

Wanna check this? https://github.com/gmponos/monolog-slack


syntax highlighting is broken for myrial programs without store

see https://demo.myria.cs.washington.edu/queries?max=69062&limit=10
I'm fairly certain the code explicitly checks for store, but I thought the check shouldn't happen when the language field is set...

Update: the code was in fact never modified to check for the language field, and it turns out the backend wasn't correctly populating the language field anyway. So, fixed by two upcoming PRs: uwescience/myria#724 and #266


Implement luci-config

Issue to track luci-config progress.
CLs:

Boilerplate and README.md: CL
Config storage. get_config(), get_config_content(). CL
Gitiles import. CL

Upcoming CLs:

get_projects(), get_branches()
client component
config validation

CL
Added project support:

projects

projects are defined in services/luci-config:project.cfg
project configs live in projects/<project_id> config sets
project metadata lives in projects/<project_id>:project.cfg
get_projects() endpoint returns list of project
get_project_configs() endpoint returns config files in all project config
sets in a single request

branches

branches are defined in projects/<project_id>:branches.cfg, which
defaults to only master branch
branch configs live in projects/<project_id>/branches/ config sets
get_branches() endpoint returns list of branches for a projectj
get_branch_configs() endpoint returns config files in all branch config
sets in a single request

gitiles_import.py imports project and branch configs from defined
locations


Add music. (Recommendations)

Title.

https://www.fesliyanstudios.com/royalty-free-music/download/deep-meditation/310
^^ Possible title screen music.

https://www.youtube.com/watch?v=QAH1-zgc5mE
^^ Potential guide. (Can't try right now.)

https://www.youtube.com/watch?v=C-CG5w4YwOI

Music has been added.


Update versions

Update java 8 version to u212 to add docker support, see:
https://blog.softwaremill.com/docker-support-in-new-java-8-finally-fd595df0ca54
Update opentsdb to 2.4.0
Update gosu to 1.11

From opentsdb changelog, as "noteworthy changes"

Change tsd.storage.use_otsdb_timestamp to default to false.

see full list of changes here: https://github.com/OpenTSDB/opentsdb/releases/tag/v2.4.0

Thanks!

I see that there is a git-tag 2.4.0, but dockerhub doesn't seem to have picked up on it, only built 'latest' with this PR, do you need to push 2.4.0 tag specifically?


[Bug]:  UnstructuredElementNodeParser doesn't pass llm/embed model to internally generated service_context

Bug Description
I'm creating a llm and embed_model without setting the OpenAI environment variables for security reasons.
I've passed in the llm constructor parameter to UnstructuredElementNodeParser. I get the message: Could not load OpenAIEmbedding. Looking deeper into the code I found that UnstructuredElementNodeParser creates an ad-hoc service context without the embed_model parameter, which I've also thought about passing in to its constructor but that isn't possible.
I think it's good practice to allow the parser to use given llm and embed models rather than force it to recreate these objects. WDYT?
Version
0.8.5.post2
Steps to Reproduce
llm = AzureOpenAI(engine="query-engine-model",
                  mode="gpt-35-turbo",
                  temperature=0.0,
                  embedding_llm=embedding_llm,
                  api_key=get_openai_api_key(),
                  api_base=openai.api_base,
                  api_type=openai.api_type,
                  api_version="2023-03-15-preview")

node_parser = UnstructuredElementNodeParser(llm=llm)
raw_nodes = node_parser.get_nodes_from_documents([Document(text=str(pf.getvalue()), metadata={
    "filename": pf.name,
    "extension": pf.type
}) for pf in pdf_files])
base_nodes, node_mappings = node_parser.get_base_nodes_and_mappings(raw_nodes)

Relevant Logs/Tracbacks
File "/Users/user/my_project/my_script.py", line 54, in with_unstructured
    raw_nodes = node_parser.get_nodes_from_documents([Document(text=str(pf.getvalue()), metadata={
File "/Users/user/Library/Caches/pypoetry/virtualenvs/my-venv/lib/python3.11/site-packages/llama_index/node_parser/unstructured_element.py", line 290, in get_nodes_from_documents
    nodes = self.get_nodes_from_node(document)
File "/Users/user/Library/Caches/pypoetry/virtualenvs/my-venv/lib/python3.11/site-packages/llama_index/node_parser/unstructured_element.py", line 264, in get_nodes_from_node
    extract_table_summaries(table_elements, self.llm, self.summary_query_str)
File "/Users/user/Library/Caches/pypoetry/virtualenvs/my-venv/lib/python3.11/site-packages/llama_index/node_parser/unstructured_element.py", line 113, in extract_table_summaries
    service_context = ServiceContext.from_defaults(llm=llm)
File "/Users/user/Library/Caches/pypoetry/virtualenvs/my-venv/lib/python3.11/site-packages/llama_index/indices/service_context.py", line 163, in from_defaults
    embed_model = resolve_embed_model(embed_model)
File "/Users/user/Library/Caches/pypoetry/virtualenvs/my-venv/lib/python3.11/site-packages/llama_index/embeddings/utils.py", line 43, in resolve_embed_model

Thanks for raising this issue @moshewe . This is indeed quite unexpected.
I think the best solution is to set the service context globally to disable openai related config. See how to do this: https://docs.llamaindex.ai/en/stable/module_guides/supporting_modules/service_context.html#setting-global-configuration
Once you've done that, the local config will default to the global config, which should use the correct embedding model.

I'll try your solution, sounds like it should work.
I still think the parser should accept a service context as a parameter or all possible inputs to the service context to allow maximum flexibility. Deferring to the global service context is not a solution to all cases.

Setting the global service context didn't work. unstructured_element:110(extract_table_summaries) will still try to create a new OpenAI before getting to the service context handling (where the global default kicks in). Maybe initializing the parser's ServiceContext can more easily be done at construction time and then passed to the various functions it uses?
Would you like me to create a PR for the UnstructuredElementNodeParser to accept a service_context and/or ServiceContext parameters in its constructor?

Any updates on this issue? I am also encountering this.


can I use the icons for publication?

Hi I am using some of the icons in my diagram for publication. How to cite them properly?  Thank you so much.

For each icon that you're using you can click on the Attribute? button and get a summary of what you are allowed to do under what conditions. You can also copy a sample attribution to your clipboard.
This attribution you put in the figure caption or in the acknowledgements section of your article.

Thank you so much for your kind help. I really appreciate that.


Update tidb-profile

Description & motivation
dbt-tidb v1.2.0 has been published, and the corresponding doc needs to be updated.
https://github.com/pingcap/dbt-tidb/pull/6

Add a new config in the profile
Add grant and connection retry in feature support
Fix inaccurate feature support

@zhangyangyu @dataders PTAL

Add yourself to the author plz :-)


Corrected scope name for Microsoft Graph

As far as I know, there is no Graph scope named 'RoleManagement.ReadWrite.All', not many hits on Google for this value - I only found two articles on docs.microsoft.com and I'm submitting a PR for both of them.
I believe the correct scope name is 'RoleManagement.ReadWrite.Directory'
#ATCP

@stianstrysse : Thanks for your contribution! The author(s) have been notified to review your proposed change.

PR for the second article on docs.microsoft.com with the wrong scope name: https://github.com/microsoftgraph/microsoft-graph-docs/pull/15422

@rolyon - approved.

Merging with PM @abhijeetsinha approval. Thanks for the review.


Use providerID for subnets in aws-resolver-rules-operator

The ID field no longer contains the actual AWS ID and so we need to switch to using providerID instead

Released in https://github.com/giantswarm/aws-resolver-rules-operator/releases/tag/v0.15.0


The rule chain is evaluated repeatedly

Description
Sorry, I don't know English.
The evaluation will be repeated after the last rule is evaluated.
Please take a look at the screenshot I modified.

Hey ! Thank you very much for reviewing the code. I think it might be right:

We only start the loop if there is a chained rule
We evaluate the chain rule
We fail if the match chained rule doesn't match
We append the matched data if it "matched"
We assign the next chain to nr
We go back to the loop

Rules can be chained like this:
SecRule SOME_VAR "some_op" "id:1,....chain"
  SecRule SOME_VAR2 "some_op2" "chain"
  SecRule SOME_VAR3 "some_op3" ""

@jptosso
Hey ! Thank you for your reply.I just took a test.  Repeated evaluation occurs when the number of regular chains is greater than or equal to 3, which affects performance.
Here are the rules and results I used:
HTTP:
GET /login HTTP/1.1
Host: test.com
Content-Type: application/x-www-form-urlencoded
Content-Length: 29
username=root&password=123456
Rule:
SecRule REQUEST_FILENAME "@streq /login" "id:10000,phase:2,t:none,log,logdata:'username:%{TX.honeyhot_decipher_username},password:%{TX.honeyhot_decipher_password}',ver:'OWASP_CRS/3.4.0-dev',chain" SecRule ARGS:username "@unconditionalMatch" "t:none,setvar:'tx.honeyhot_decipher_username=%{MATCHED_VAR}',chain" SecRule ARGS:password "@unconditionalMatch" "t:none,setvar:'tx.honeyhot_decipher_password=%{MATCHED_VAR}'"
Result:

That's interesting, if you could post the specific rules you are using it would be super useful, still, I will add similar tests to testdata/engine/chains.yaml and get back to you

I have written the following working test:

func TestCompileMultipleChains(t *testing.T) {
	waf := coraza.NewWaf()
	p, _ := NewParser(waf)
	if err := p.FromString(`
	SecRule REQUEST_FILENAME "@unconditionalMatch" "id:100, phase:2, t:none, log,chain"
	SecRule ARGS:username "@unconditionalMatch" "t:none, setvar:'tx.some=lala',chain"
	SecRule ARGS:password "@unconditionalMatch" "t:none, setvar:'tx.some2=lolo'"
		`); err != nil {
		t.Error(err)
	}
	c := 0
	r := waf.Rules.FindByID(100)
	for r != nil {
		c++
		r = r.Chain
	}
	if c != 3 {
		t.Errorf("failed to compile multiple chains, expected 3, got %d", c)
	}
}

Please provide more information to replicate the issue.

@jptosso There is no problem loading the chains.
There are problems matching chains.
I have written the following working test:
func Test_directiveSecAuditLog(t *testing.T) {
	waf := engine.NewWaf()
	p, _ := NewParser(waf)
	if err := p.FromString(`
	SecAction "id:900010, phase:1, nolog, pass, t:none, ctl:forceRequestBodyVariable=On"
		`); err != nil {
		t.Error(err)
	}
	if err := p.FromString(`
	SecRule REQUEST_FILENAME "@unconditionalMatch" "id:100, phase:2, t:none, log, setvar:'tx.count=+1',chain"
	SecRule ARGS:username "@unconditionalMatch" "t:none, setvar:'tx.count=+1',chain"
	SecRule ARGS:password "@unconditionalMatch" "t:none, setvar:'tx.count=+1'"
		`); err != nil {
		t.Error(err)
	}
	tx := waf.NewTransaction()
	// request
	req, err := ExtractRequest("UE9TVCAvbG9naW4gSFRUUC8xLjENCkFjY2VwdDogKi8qDQpBY2NlcHQtRW5jb2Rpbmc6IGd6aXAsIGRlZmxhdGUNCkNvbm5lY3Rpb246IGNsb3NlDQpPcmlnaW46IGh0dHA6Ly90ZXN0LmNvbQ0KVXNlci1BZ2VudDogTW96aWxsYS81LjAgKFdpbmRvd3MgTlQgMTAuMDsgV2luNjQ7IHg2NCkgQXBwbGVXZWJLaXQvNTM3LjM2IChLSFRNTCwgbGlrZSBHZWNrbykgQ2hyb21lLzkxLjAuNDQ3Mi43NyBTYWZhcmkvNTM3LjM2DQpDb250ZW50LVR5cGU6IGFwcGxpY2F0aW9uL3gtd3d3LWZvcm0tdXJsZW5jb2RlZDsgY2hhcnNldD1VVEYtOA0KUmVmZXJlcjogaHR0cDovL3dvenVpbml1YmkueWFjbG9uZS5jb20vbG9naW4uanNwDQpYLVJlcXVlc3RlZC1XaXRoOiBYTUxIdHRwUmVxdWVzdA0KQ29udGVudC1MZW5ndGg6IDU5DQpBY2NlcHQtTGFuZ3VhZ2U6IHpoLUNOLHpoO3E9MC45DQoNCnVzZXJuYW1lPXJvb3QmcGFzc3dvcmQ9MTIzJnJlbWVtYmVyTWU9b24mdGltZT0xNjQ0OTc5MTgwNzU3")
	if err != nil {
		t.Errorf("Description HTTP request parsing failed")
	}
	_, err = tx.ProcessRequest(req)
	if err != nil {
		t.Errorf("Failed to load the HTTP request")
	}
	// There is no problem loading the rules
	c := 0
	r := waf.Rules.FindByID(100)
	for r != nil {
		c++
		r = r.Chain
	}
	if c != 3 {
		t.Errorf("failed to compile multiple chains, expected 3, got %d", c)
	}
	// Why is the number of matches 4
	c, _ = strconv.Atoi(tx.MacroExpansion("%{tx.count}"))
	if c == 4 {
		t.Errorf("Why is the number of matches 4")
	}
}

func ExtractRequest(raw string) (req *http.Request, err error) {
	b, err := base64.StdEncoding.DecodeString(raw)
	if err != nil {
		return nil, err
	}

	req, err = http.ReadRequest(bufio.NewReader(bytes.NewReader(b)))
	if err != nil {
		return nil, err
	}
	return req, nil
}

result
--- FAIL: Test_directiveSecAuditLog (0.00s)
    directives_test.go:66: Why is the number of matches 4
FAIL

@jptosso
If the above problem is confirmed, test the following steps

You use one of the child chains as the fourth chain.
You look at the value of the tx.count variable.

I have just noticed you are using coraza v2.0.0-beta.4, that version was deprecated and we are running v2.0.0-rc.2, the last version before v2 final release. There are a few differences and bug fixes, I have updated your code to use the new Macro interface and it works:
// from issue https://github.com/corazawaf/coraza/issues/159 @zpeasystart
func TestDirectiveSecAuditLog(t *testing.T) {
	waf := coraza.NewWaf()
	p, _ := NewParser(waf)
	if err := p.FromString(`
	SecAction "id:900010, phase:1, nolog, pass, t:none, ctl:forceRequestBodyVariable=On"
		`); err != nil {
		t.Error(err)
	}
	if err := p.FromString(`
	SecRule REQUEST_FILENAME "@unconditionalMatch" "id:100, phase:2, t:none, log, setvar:'tx.count=+1',chain"
	SecRule ARGS:username "@unconditionalMatch" "t:none, setvar:'tx.count=+1',chain"
	SecRule ARGS:password "@unconditionalMatch" "t:none, setvar:'tx.count=+1'"
		`); err != nil {
		t.Error(err)
	}
	tx := waf.NewTransaction()
	// request
	rdata := []string{
		"POST /login HTTP/1.1",
		"Accept: */*",
		"Accept-Encoding: gzip, deflate",
		"Connection: close",
		"Origin: http://test.com",
		"User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36",
		"Content-Type: application/x-www-form-urlencoded; charset=UTF-8",
		"Referer: http://wozuiniubi.yaclone.com/login.jsp",
		"X-Requested-With: XMLHttpRequest",
		"Content-Length: 59",
		"Accept-Language: zh-CN,zh;q=0.9",
		"",
		"username=root&password=123&rememberMe=on&time=1644979180757",
	}
	data := bytes.NewBuffer([]byte(strings.Join(rdata, "\r\n")))
	req, err := http.ReadRequest(bufio.NewReader(data))
	if err != nil {
		t.Errorf("Description HTTP request parsing failed")
	}
	_, err = tx.ProcessRequest(req)
	if err != nil {
		t.Errorf("Failed to load the HTTP request")
	}
	// There is no problem loading the rules
	c := 0
	r := waf.Rules.FindByID(100)
	for r != nil {
		c++
		r = r.Chain
	}
	if c != 3 {
		t.Errorf("failed to compile multiple chains, expected 3, got %d", c)
	}
	// Why is the number of matches 4
	macro, err := coraza.NewMacro("%{tx.count}")
	if err != nil {
		t.Error(err)
	}
	c, _ = strconv.Atoi(macro.Expand(tx))
	if c == 4 {
		t.Errorf("Why is the number of matches 4")
	}
}

Running tool: /opt/homebrew/bin/go test -timeout 30s -run ^TestDirectiveSecAuditLog$ github.com/jptosso/coraza-waf/v2/seclang

ok  	github.com/jptosso/coraza-waf/v2/seclang	0.437s

Please tell me if it works on upgrade. There are no major differences between both versions, Macro is the biggest one.

@jptosso
V2.0.0-rc.2 also has this problem.
There are problems matching chains.

I have written the following working test:
func TestDirectiveSecAuditLog(t *testing.T) {
	waf := coraza.NewWaf()
	p, _ := seclang.NewParser(waf)
	if err := p.FromString(`
	SecRule REQUEST_FILENAME "@unconditionalMatch" "id:100, phase:2, t:none, log, setvar:'tx.count=+1',chain"
	SecRule ARGS:username "@unconditionalMatch" "t:none, setvar:'tx.count=+1',chain"
	SecRule ARGS:password "@unconditionalMatch" "t:none, setvar:'tx.count=+1'"
		`); err != nil {
		t.Error(err)
	}
	tx := waf.NewTransaction()
	tx.RequestBodyAccess = true
	tx.ForceRequestBodyVariable = true
	// request
	rdata := []string{
		"POST /login HTTP/1.1",
		"Accept: */*",
		"Accept-Encoding: gzip, deflate",
		"Connection: close",
		"Origin: http://test.com",
		"User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36",
		"Content-Type: application/x-www-form-urlencoded; charset=UTF-8",
		"Referer: http://wozuiniubi.yaclone.com/login.jsp",
		"X-Requested-With: XMLHttpRequest",
		"Content-Length: 59",
		"Accept-Language: zh-CN,zh;q=0.9",
		"",
		"username=root&password=123&rememberMe=on&time=1644979180757",
	}
	data := bytes.NewBuffer([]byte(strings.Join(rdata, "\r\n")))
	req, err := http.ReadRequest(bufio.NewReader(data))
	if err != nil {
		t.Errorf("Description HTTP request parsing failed")
	}
	_, err = tx.ProcessRequest(req)
	if err != nil {
		t.Errorf("Failed to load the HTTP request")
	}
	// There is no problem loading the rules
	c := 0
	r := waf.Rules.FindByID(100)
	for r != nil {
		c++
		r = r.Chain
	}
	if c != 3 {
		t.Errorf("failed to compile multiple chains, expected 3, got %d", c)
	}
	// Why is the number of matches 4
	macro, err := coraza.NewMacro("%{tx.count}")
	if err != nil {
		t.Error(err)
	}
	c, _ = strconv.Atoi(macro.Expand(tx))
	if c > 3 {
		t.Errorf("Why is the number of matches %d", c)
	}
}

Result
--- FAIL: TestDirectiveSecAuditLog (0.00s)
    ruleprocessors_test.go:71: Why is the number of matches 4
FAIL

@jptosso If the problem is proven

The more number of chain，the more repeated matches there are.

The last rule actions on the chain are being triggered twice. Thank you for your report, we will try to fix this ASAP.

The rule chain was bugged, each rule was triggering it's own rule chain, it's now fixed in v2/issue-159, please check if it fixes your issue and I will merge it.
Thank you very much for your report


ERROR: hostapd not found.

I'm using Debian 9 Mate x64. I installed it and tried like this:
sudo create_ap -n wlx54e6fc990ab6 ap pata
And it says:
ERROR: hostapd not found.
What should I do?

apt install hostapd

Thanks, it worked.

Thank you, its working.

Thank you, its worked for me, but my cellphone say weak security, how upgrade wap to wap2 o wap3?


Add documentation to utilize JS testing for RSpec

What are you trying to accomplish?
Adding setup instructions for utilizing the newly added JS testing approach when using RSpec. Without these configurations, using the with_rendered_component_path would not work.
This was sparked by a comment left here - https://github.com/ViewComponent/view_component/pull/1061#issuecomment-1347567212
What approach did you choose and why?
N/A
Anything you want to highlight for special attention from reviewers?
This is assuming Capybara is being used in RSpec setup, which is common. This may need some updates once we want to include instructions that don't rely on Capybara.

@joelhawksley a bit of an oversight, we didn't include documentation for using the with_rendered_component_path with RSpec. Let me know if this makes sense, I can confirm this works on my project that uses RSpec

@edwinthinks thanks for adding the docs! Even with this change, I'm still seeing something weird. Our setups must be a little different. The server must be running, as I'm getting a 404. What would be the most useful information to share with you?
Screenshot of error from headless browser

@developius thanks for sharing that. Ummm can you confirm that Rails.env.test? is true? The route to _system_test_entrypoint is only open when its in Rails.env.test? It is likely it is already set that way.
Another option, which seems a bit strange... but let me know is to add change the type: :system and add the helpers to the system type:
  config.include ViewComponent::TestHelpers, type: :system
  config.include ViewComponent::SystemTestHelpers, type: :system
  config.include Capybara::DSL, type: :system
  config.include Capybara::RSpecMatchers, type: :system

You may also need to define (I noticed an issue if you don't define this when going this system test route), which you can add in the spec.
  def page
    Capybara.current_session
  end

Here is a sample of what I've got working on my local machine:
# frozen_string_literal: true

RSpec.describe "SidenavLinkComponent", type: :system do
  def page
    Capybara.current_session
  end

  it 'does render a link if no url is provided' do
    inline = render_inline(SidenavLinkComponent.new(label: 'Test', href: '#', options: {}))

    with_rendered_component_path(inline) do |path|
      visit path
      expect(page).to have_link('Test')
    end

  end
end

@developius lemme know if this works. Otherwise be interested to hear from others about why you might be encountering that issue. Might need to be a another issue we can add in the repo?

Apologies for the red herring @edwinthinks, we're setting config.view_component.preview_controller to a custom controller which has some auth stuff because we use the previews to power Lookbook.
Commenting out that configuration allows everything to work as expected 💯 thanks for the help!
This could probably be moved to another PR/discussion/issue, but sharing anyway...
I'm not sure I would've expected the preview controller to be used for this since it's not using previews - it's only rendering a file. Is that something you're set on keeping? I would definitely vote for decoupling it completely from previews. I suspect others might have similar setups with a custom preview controller, which will make it difficult to use this awesome new approach out of the box. What do you think?

@developius no worries! Good find. I think you aren't going to be the only person caught with this issue.
My gut feeling is that it should be a different PR/discussion. And I think we could move it out of previews_controller which I do agree seems to be responsible for something else which we can discuss in that other discussion/issue.
@joelhawksley what do you think?

I think we could move it out of previews_controller which I do agree seems to be responsible for something else which we can discuss in that other discussion/issue.

@edwinthinks I think we should fix the bug with custom preview controllers, yes. Would you be up for working on that?

@edwinthinks I think we should fix the bug with custom preview controllers, yes. Would you be up for working on that?

Hey @joelhawksley yeah I think I can tackle that. Upfront do we know if we are open to moving the system endpoint to a different controller action?

Upfront do we know if we are open to moving the system endpoint to a different controller action?

@edwinthinks yes, I think we should make a separate controller as this feature is not related to previews any more.

@joelhawksley sounds good! I think we can merge this in the meantime? The documentation is still neccessary for RSpec users.


MB-7650 Service counseling edit allowances frontend

Description
This PR creates a new form specifically for the service counseling to edit the allowances. Changes to the allowances form also affects the allowances form for the TXO portion.

As an office user
When I am on the service counselor move details page for a move
Then I am able to make edits to allowances including the following fields:
Branch, Rank, pro-gear, spouse pro-gear, RME, and OCIE

Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?

I made a new document wrapper specifically for the services counseling
We're still using the same form AllowancesDetailForm for both TXO and Service counseling
Authorized weight is only editable for the TXO roles

Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Test

login as Service Counseling role
Navigate to /counseling/moves/queue
Click on any move with status Needs counseling
Click on the Edit Allowances button
Modify inputs and Save

Check out new changes in storybook

Run make storybook
Navigate to http://localhost:6006/?path=/story/office-components-allowancesdetailform--basic
Play with the params in the Controls section
editableAuthorizedWeight is to enable/disable authorized weight input
header is to show any string you type in

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
https://user-images.githubusercontent.com/1522549/116590424-96b56180-a8d2-11eb-9b9a-58d120f62e02.mov

Messages

:book:
:link: MB-7650

  Generated by :no_entry_sign: dangerJS against e9d169d4c0ecb0a40288d74128d896824b3b5de3

@donaldthai As a services counselor if I have '0' values for pro gear, spouse pro gear, and RME weights the form loads those fields as blank input fields.  When I go to save a form with the blank values I get NaN errors.

@donaldthai One more issue, if I edit the orders form as the TOO it clears any values I had saved on the allowances form it looks like
https://user-images.githubusercontent.com/52669884/116617582-00059680-a90c-11eb-9793-4d665907228f.mov

@donaldthai One more issue, if I edit the orders form as the TOO it clears any values I had saved on the allowances form it looks like
Screen.Recording.2021-04-29.at.4.55.03.PM.mov

@duncan-truss So I ended passing in those new fields when we update the order. Reason being on the backend those fields aren't pointers. I'm thinking we can have a bigger discussion around how we want to handle optional fields that aren't nullable. I can make a storybook tonight.
Changes here: https://github.com/transcom/mymove/pull/6544/commits/d7d72370909d49fe12053909d3363d37765d6938

@donaldthai As a services counselor if I have '0' values for pro gear, spouse pro gear, and RME weights the form loads those fields as blank input fields. When I go to save a form with the blank values I get NaN errors.

I added a notRequired() validation to the Yup stuff. Should be good to save without those fields now.


[Feature]: Support ha-alert in title card

Is your feature request related to a problem?
I just noticed the Markdown card supports the ha-alert component for nice formatting of alerts in the card.
The markdown card only supports templates in the content part, and I also use templates in the title, so for me the markdown card doesn't work
Describe the solution you'd like
It would be nice if the title card would also support this
https://www.home-assistant.io/dashboards/markdown/#ha-alert
Describe alternatives you've considered
No response
Additional context
No response

Hello ! It's not planned to add markdown support or custom html in title card. Just plain text for now.


Stop execution / Interrupt overlap

The Jupyter extension contributes a notebook controller with an interrupt handler, the Stop Execution will then call the interrupt handler directly, which does the same as the Interrupt command contributed by the extension. We may want to hide the Interrupt command.
It's arguable that if we want to change the title of Stop Execution to Interrupt when the controller contributes interrupt handler but it's also impl details which users might not care.

Agreed. Jupyter does call it interrupt, but my bet would be customers wouldn't be too confused by either name for the command.

Personally I don't think we even need a command (i.e. an icon on the toolbar).


assertStream always passes

I am attempting to write a unit test on my DataStream, but it is constantly passing. Here is my code:
        testEnv = DataStreamTestEnvironment.createTestEnvironment(1);
        createTestStream(Arrays.asList(eventStreamPayload));
        DataStream<JSONObject> dataStream = createTestStream(Arrays.asList(eventStreamPayload)).flatMap(new myFlatMap());
        TestSink<JSONObject> outputFormat = createTestSink(hasItems(new JSONObject(eventStreamPayload2)));
        dataStream.addSink(outputFormat);
        JSONObject jsonObject = new JSONObject(eventStreamPayload2);
        assertStream(dataStream, hasItems(jsonObject));

Now in the above case, eventStreamPayload and eventStreamPayload2 are different and myFlatMap() modifies eventStreamPayload as well. Yet the TestSink and assertStream is always passing. What am I a missing?

It's hard to debug this while only having access to a smartphone. My best guess is the test pipeline is never executed. But I can only confirm this if I have see the whole code of the test class. Preferably with imports.
The second guess is the implementation of equals on the JSONObject class.
I could have a better look into it on Tuesday.
Am 18.05.2018 14:10 schrieb aschuhl<EMAIL_ADDRESS>I am attempting to write a unit test on my DataStream, but it is constantly passing. Here is my code:
    testEnv = DataStreamTestEnvironment.createTestEnvironment(1);
    createTestStream(Arrays.asList(eventStreamPayload));
    DataStream<JSONObject> dataStream = createTestStream(Arrays.asList(eventStreamPayload)).flatMap(new myFlatMap());
    TestSink<JSONObject> outputFormat = createTestSink(hasItems(new JSONObject(eventStreamPayload2)));
    dataStream.addSink(outputFormat);
    JSONObject jsonObject = new JSONObject(eventStreamPayload2);
    assertStream(dataStream, hasItems(jsonObject));

Now in the above case, eventStreamPayload and eventStreamPayload2 are different and myFlatMap() modifies eventStreamPayload as well. Yet the TestSink and assertStream is always passing. What am I a missing?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/ottogroup/flink-spector/issues/78, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHE18P-_JEjOTYipgdEOymXKt_U7L3Mkks5tzro1gaJpZM4UEoL1.

Yes myFlatMap() changes the structure of the eventStreamPayload, but no matter what I compared it to, it still passed.
So I switched to JUnit4 in case that was the problem and now see different results. The following asserts still always pass not matter what:
assertStream(dataStream, hasItems(jsonObject));
assertStream(dataStream,expectedRecords);

But the sink now fails and I don't know why. The line:
       dataStream.addSink(outputFormat);
Fails with:
java.lang.AssertionError:
Expected: (a collection containing <{"id":"aschuhl","type":"account","eId":"123456789","eType":"test"}>)
     but: a collection containing <{"id":"aschuhl","type":"account","eId":"123456789","eType":"test"}>

But both collections seem the same to me.

Also here are the imports
import io.flinkspector.core.collection.ExpectedRecords;
import io.flinkspector.core.input.Input;
import io.flinkspector.core.input.InputBuilder;
import io.flinkspector.datastream.DataStreamTestBase;
import io.flinkspector.datastream.DataStreamTestEnvironment;
import io.flinkspector.datastream.functions.TestSink;
import org.apache.flink.streaming.api.datastream.DataStream;
import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
import org.json.JSONObject;
import org.junit.jupiter.api.Test;
import java.util.Arrays;
import static org.hamcrest.Matchers.*;

public class test extends DataStreamTestBase {

The DataStreamTestBase has a lot of built in semantic sugar to reduce boiler plate code.
You've called some methods which the DataStreamTestBase normally hides. Also the TestBase only works with JUnit 4 for now.
        DataStream<JSONObject> dataStream =
        createTestStream(Arrays.asList(eventStreamPayload)).flatMap(new myFlatMap());
        JSONObject jsonObject = new JSONObject(eventStreamPayload2);
        assertStream(dataStream, hasItems(jsonObject));

This should be all you need to setup the test.
assertStream already instantiates a TestSink and  attaches it to the dataStream.
The TestSink validates the output this is why you see the AssertionError "too early".
The failed comparison between the two objects seems to stem from the equals Method on org.json.JSONObject, which only seems to do a reference comparison.
https://stackoverflow.com/questions/2253750/compare-two-json-objects-in-java

import org.junit.jupiter.api.Test;
means junit 5 was used. I had the same and 'fixed' it by calling initialize() and executeTests() manually. Are there 'plans' to switch or support junit5?

Yes there are plans but I have never used unit 5 myself and have to look into it.


Access token security

Hi, this kind of a support and feature request.
I have just started to learn jwt authentication mechanism with Laravel. During my research I found this article in which the author claims that storing the jwt token in cookie with httponly flag set is more secure than storing it in local storage. Currently L5AMS is storing token in local storage. Is it possible to provide a feature that enables us to choose where to store tokens during the initial setup?
Another question I have is regarding invalidating access tokens. Lets say a user has logged in to my web app in multiple devices and then successfully completes a password reset request on one of the devices. How do I invalidate or logout the user from all devices that he has logged in since the tokens given to those devices were obtained with an old or potentially breached password?
Thank you for your time and the amazing work! I am using L5AMS v3.3

also throttle login should be added.


Added arrowline annotation tool

Implementation
This pull request adds the arrow line annotation tool to the viewer app. To implement this functionality, I used the SVG line shape and added an arrowhead to the end of this line. This was done using the marker-end attribute that can be added to the <line /> tag. In the marker-end attribute the URL of an SVG definition needs to be given. So, we create an SVG marker definition for the arrowhead, add it to the SVG definitions - defs tag and reference the URL for this in the line attribute.
Changes

Created arrowline.js to add the functionality of the new tool.
mview.html: Loading the arrowline.js script
base.js: Made changes to handle the marker-end attribute. It needs to be added only for the arrow line annotation type.
annotation-svg.js: Added the code to add marker definition to the annotation SVG, changing the colour of the arrowhead on stroke change, parsing the saved arrow line annotations correctly and creating the corresponding marker SVG definitions for matching the stroke colours of the loaded arrow lines.
annotation-group.js: Added the arrow line annotation type case.
annotation-tool.js: HTML code changes to render the arrow line option in the tool and other arrow line case changes.

Misc
The PR might show other file changes, but those are due to the formatting being updated for the files. The exact lines for code changes are below:

mview.html: Loading the arrow line script.
arrowline.js: Created the entire file for the new annotation tool.
base.js: Lines 24, 216-219
annotation-svg.js: Lines 30-53,  75-79,  108-111, 409, 566-593
annotation-group.js: Lines 51-53
annotation-tool.js: Lines 86-88, 184

Closing this PR as discussed, will undo the formatting changes and raise another PR with just the code changes.


Sidenav does not work with mat-dialog-content

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When I place a sidenav inside mat-dialog-content, scrollable content should behave as if I placed it anywhere else.
What is the current behavior?
Currently if the mat-sidenav-content causes the dialog to overflow/scroll, a weird whitespace begins to take over the entire mat-dialog-content view
What are the steps to reproduce?
https://stackblitz.com/edit/angular-dialog-sidenav-whitespace
What is the use-case or motivation for changing an existing behavior?
I want to have a sidenav placed inside a dialog.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
I've only tried this on Angular 6.
Is there anything else we should know?

You should try mat-drawer; mat-sidenav is intended for top-level application navigation. Closing this for now, feel free to re-open if problems persist with mat-drawer.

I would like to re-open this issue.  I switched the components to use mat-drawer and still experience the same behavior.


Fix passing context around

This fixes #840 by allowing the context to be passed when initially creating an instance of ParseState. The old way of passing the context when calling parse is still supported to prevent BC breaks, but it no longer used internally.

Hi there, sorry if this is not a good place to comment this but was curious if you had a ballpark estimate on when 1.16 will be released. Mostly just need to know if I can wait it out or pivot to a different approach on the issue I'm running into currently.
Thanks for your hard work!

@fernakr is there a specific issue that has already been fixed, but not released?
This is the final PR that needs to be merged before v1.16.0 can be released, I'm just waiting on @RobLoach to review at this point.

Gotcha - it was the nested embeds problem: https://github.com/twigjs/twig.js/issues/708

@RobLoach if you could take a look at this and then just go ahead and merge and publish v1.16.0 that would be great. It would be great to go ahead and get it released since it has a lot of long standing bugs fixed in it.

@willrowe Thanks for the ping! This is looking really good, and will do some rigorous testing, along with getting the release out later on today :rocket:

Awesome thanks to you both!

It was all @willrowe!!!! MVP of this release for sure :rocket:


Default permissions

Hi,
Can we please get an example of how to set a folders default ACL's?
The following page mentions it is possible:
https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-access-control
But I am not sure I understand how to apply the umask (if that is the correct method)
Thanks
Mike

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18ec84b9-0311-d67f-60a8-428db54add42
Version Independent ID: af6292f5-b0ca-5874-3f50-cf539e28675a
Content: Use Azure CLI for files & ACLs in Azure Data Lake Storage Gen2 (preview)
Content Source: articles/storage/blobs/data-lake-storage-directory-file-acl-cli.md
Service: storage
Sub-service: data-lake-storage-gen2
GitHub Login: @normesta
Microsoft Alias: normesta

@michaelhambe Thanks for the feedback!. Your feedback has been shared with the content owner for further review.

@SumanthMarigowda-MSFT Any update on this example? This is something that I'm looking to complete for a production scenario.

@PhilipAnthonyMurray I was able to do this on, for instance, the owning user by adding default:user::rwx.
Check the REST API docs and look for the x-ms-acl request header.

@DJLemkes Thanks, I managed to figure it out yesterday evening. While it works it's a messy way to configure serveral accounts and groups plus specifiy Default definitions for each.

@SumanthMarigowda-MSFT, the functionality seems to be available - any idea when the documentation will be updated with cli examples?

Thanks for the inquiry @michaelhambe. I've updated the doc with an example and that change should appear live by tomorrow.  BTW - the ref for these commands are now appearing. For some time, the preview ref was not available. The specific command ref topic is here - https://docs.microsoft.com/en-us/cli/azure/ext/storage-preview/storage/blob/directory/access?view=azure-cli-latest#ext-storage-preview-az-storage-blob-directory-access-set. Basically, you'd add "Default:" to the beginning of the permission string. Thank you for raising!

#please-close

thanks @normesta


adminApiAddress

turms-admin会通过服务发现的接口返回adminApiAddress的地址，默认是服务所在的内网地址，如果需求通过外网或网关让turms-admin可以访问，是需要在turms-service或turms-gateway中去配置adminApiAddress的地址吗？
如果是需要怎么配置呢，感觉在文档中没有详细说明，还是我没找到？

The related properties are:
turms.gateway/service.admin-api.address.advertise-strategy=advertise_address
turms.gateway/service.admin-api.address.advertise-host=
If you want to access the admin APIs of turms-service or turms-gateway in public, you just need to provide public IPs or hosts for users to access (Just a reminder, you can configure the security group to limit the IPs that can access the IPs).

So if you want to configure the admin address to use the public IP, you can configure turms.gateway/service.admin-ap i.address.advertise-strategy=public_address.
If you want to use custom host/IP, you can configure:
turms.gateway/service.admin-api.address.advertise-strategy=advertise_address
turms.gateway/service.admin-api.address.advertise-host=<your_custom_ip_or_host>

好的，感谢解答


jquery 1.x and IE<=8 not work with default config

<script src="//cdn.polyfill.io/v2/polyfill.js"></script>
<script src="//code.jquery.com/jquery-1.12.4.js"></script>
<script>
    $(function(){
    $('[name=dd]').filter('.rx').show();
  });
</script>

I think Symbol and Event Polyfill brokes jQuery
some thing like for .. in .. wil iterate some Symbol key and jQuery does not test it
addEventListener,DOMContentLoaded polyfill is broken
finally I excludes some polyfills,and it seems work again
excludes=Event,Event.DOMContentLoaded,Set,Map,WeakMap,Symbol,Symbol.hasInstance,Symbol.isConcatSpreadable,Symbol.iterator,Symbol.match,Symbol.replace,Symbol.search,Symbol.species,Symbol.split,Symbol.toPrimitive,Symbol.toStringTag,Symbol.unscopables

is there any others i should exclude ?
is it possible to just exclude Symbol , and automatic exclude all Symbol related polyfills?
Thank you !

Have you tried with jQuery 2 or 3, with jquery-compat?

@tracker1
no， i havent try jquery 2 or 3
because maybe css or selector does not support <=ie8
i think jquery-compact is just an alias to jquery 1.x
do you mean jQuery Migrate ？
but jQuery Migrate is not for jquery 3.x support old bowsers
thank you

Hi @niphor can you try to include only enough polyfills to generate the problem?  Rather than using excludes, try using features to only include the features you want.  If you can nail it down to one feature that would help us figure out the problem (and even better if you can trace the code in jQuery which is triggering the problem).

@triblondon
I opened this issue at 30 Jun, that when cdn.polyfill.io was at 3.7.0
I have said I think Symbol and Event Polyfill brokes jQuery in this issue...

Event Polyfill
#L121
eventElement maybe is not function
this is fixed in 3.9.0rc,I think

Symbol Polyfill
jQuery uses for .. in .. https://github.com/jquery/jquery/blob/1.12.4/dist/jquery.js#L2135
so type will be something like __\u0001symbol:iterator0.166322325144687141
https://github.com/jquery/jquery/blob/1.12.4/dist/jquery.js#L2136
so matchExpr[ type ] equal undefinded,which not have exec method

I don't think compatibility with jQuery 1.x is going to make it to the top of our priority list, unfortunately. Of course we always welcome contributions and that includes a contribution that resolves this issue. Glad to hear that the issue is at least partly resolved by 3.9.0, and if you're still experiencing the second part of the issue we'd welcome a PR with a proposed fix.

Set 'default-3.5' works fine in ie8 with JQuery 1.12.4.


Examples/demos organization + fiddles/pens

We will have demos and lessons.
Lessons can be developped running: gulp lessons <lesson #>
Lessons run against the ami.js build in order to easily be used in JSFiddle.
Stay tuned.


fix task chain assign page

One restriction it has is that when type the dictionary parameters for ProcessSting, etc. It should be valid json (cannot use single quote only double quote)

@amaltaro, Alan please review. Tested in my vm

It looks good, Seangchan. Thanks!


Supplying pre training code

Thanks for this repo and congratulations on the superb paper.
Would it be possible to share the pre training code? Specifically loading the model and fine-tuning the DINO pretraining step further?

Hi, thanks for reaching out!  We're discussing plans to release them. Please stay tuned!

Hello, any update on that matter?
Would it be possible to release the YAML configuration used by DINOv2 during training, similar to how the UNI model’s YAML was shared?


Add Minimize and Maximize window controls

Seems too essential for users.

Duplicate of https://github.com/KeitIG/museeks/issues/41
I'll have to find a workaroud


Pre-trained weights

Even though we do have access to the NSRR datasets, we currently don't have any GPU clusters to train the model. Do you also provide pre-trained weights for U-Sleep?

Hi skjerns,
We do not currently provide the weights (although they are available for free usage via https://sleep.ai.ku.dk). However, this may change in the future and then I will let you know.
For now, I suggest you use the server, or if this is not feasible for your specific project, please reach out to me directly on email.
Cheers,
Mathias


Fix issue on invalid inlining of non-empty build_list by inline_arraycall

fixes #6053
The issue is only affecting python3.8 due to different bytecode.

BFID: numba_smoketest_cpu_62

smoketest was fine.

Marking as RTM

Note this does not close the related https://github.com/numba/numba/issues/5770


Only install cmti files for modules intended for end users

Also change the Dl interface to use only published types.
See the discussion under #444 here.

There is a small backwards incompatibility: the return type of Dl.dlsym has changed.  I don't think Dl.dlsym is widely used.


Midi clock

implemented midi clock. Tested with outboard gear and Ableton Live.
Ableton needs to be set to EXT to receive clock and SYNC/REMOTE should be enabled for the MIDI input device. SYNC/REMOTE should be disabled for output if using the same MIDI device.
MIDI Clock is toggled on/off from the MIDI menu.
Spacebar sends MIDI start and stop messages. Stop also sends a MIDI All Notes Off message to avoid hung notes.

Nice one :) Thanks!

The issue I had before is still there, I found how to reproduce.

Create any instrument in Ableton with a long release, 3-4 seconds.
Turn on midi clock, it'll cut off the notes, and trigger play/stop commands in ableton that'll make the playhead twitch. I've hidden the option from the menu again until we find a solution for that. I had that same issue when I last implemented the midi clock.

Can you post a pic of your midi setup in preperences/settings?
I’ll test later today
I wonder if this is an abelton issue more than orca issue

OK - I think this is an ableton bug or something.
Setting up like you suggested - long release pad sending
.D......
..:02Czm

If Orca is already already running and I start midi clock, I get a "blip" instead of a long note. However, if I stop/start orca from the spacebar, ableton plays the notes correctly (long tones).
So what I think is happening is that Ableton has not received a midi "start" command so it's confused about what to do with the midi notes. Spacebar in orca sends midi start/stop, so it works as expected.
A possible workaround would be to add a midi start command to the menu option so it always sends start or continue when you turn on midi clock send.
FWIW - just found this forum post about this same issue (but with no resolution).
FWIW - the stream of midi data from orca is "correct" here. I think the problem lies with Ableton.

Did a bunch more testing - can confirm that abelton is sending "all notes off" messages for some reason if it is set to EXT and has not received a "start" message to get it's transport running.
end result - I think this is a documentation issue - “if you wanna send clock to ableton, you gotta stop and start orca's transport with the spacebar after you enable midi clock”

we could force a play/stop of orca when activating the clock?

So here's the problem with forcing a "start" - A midi start message dictates that you are starting on the initial downbeat of a "song". If you're just randomly turning on the midi clock, that could be anywhere in a measure/song/structure and not at the "start".
More on that here: http://midi.teragonaudio.com/tech/midispec/seq.htm
Forcing a Stop of orca's transport might make sense as you would then be forced to "start" properly so that ableton gets it's sync properly.

Oh I see, I just tested and the order of messages becomes wrong if I just toggle play/stop.
Mhmm.. Maybe just a stop, to make sure the messages start with the right one.

Forcing a stop works well.


html: add parameter to enable/disable table title label

Add a switch to turn off the addition of <span class="table--title-label"> before the title during table generation.

My preference is not to add parameters for features like this, because it will lead to having 500+ parameters.
A workaround I use for this is
.table--title-label { display: none }

To hide the label.

OK good enough for me.


Angular purges <script type="text/plain" as if it were a security vulnerability

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Background
Imagine you have the following webcomponent:
<expression>
	<script type='text/plain'>
		If(var1 < var2,
			Sum([Field 1])
		,
			Sum([Field 2])
		)
	</script>
</expression>

The component reads the text inside the script tag and sends it to a server which evaluates the result.
The webcomponent should be embedded in an Angular App. It is no Angular component and should just rendered as is.
It has to contain a script tag because 'text/plain' allows it not to be parsed as HTML and like this, it is possible for expressions to contain characters like < as in var1 < var2 without being recognized as the beginning of a html tag.
Current behavior
Angular deletes all script tags inside templates, also those with text/plain. I read, that this is because you shouldn't mix JavaScript with Angular Templates, but this is just plain text.
Expected behavior
<script type="text/plain" should not be deleted. It is the only way to integrate text without having to escape all html characters.
Minimal reproduction of the problem with instructions
Insert the following code into a template and see if it will be deleted.
<script type='text/plain'>
    If(var1 < var2,
        Sum([Field 1])
    ,
        Sum([Field 2])
    )
</script>

What is the motivation / use case for changing the behavior?
If <script type="text/plain" would not be deleted it is possible to insert everything which is not html without having to escape it. HTML 5 supports it and as far as I know there is no alternative. Also it isn't a security vulnerability.
Environment

Dart SDK Version 2.0
Angular version: 6.1.0
AngularDart Version 5.0.0
Browser:
- [x] Chrome (desktop) version 69

I also filed it in the Angular TS repo: https://github.com/angular/angular/issues/26293

We don't plan on supporting this.


Call Event on trigger

change
this.settings[handler].apply(this, event);
to this
this.settings[handler].call(this, event);
"apply" requires to use array of arguments

Thanks :)

+1 to this, please guys add this in the dist lib

This is a limitation of the jQuery API surrounding the trigger method. We want to be able to pass in multiple parameters when using trigger, so we must use an array. We could use duck typing to help in the instance where there was only one parameter, but that raises some other issues.

Oops, I definitely misinterpreted the question here, so sorry about that. Got confused and assumed this was about .trigger('event.owl', ['value']) vs `.trigger('event.owl', 'value').
This fix is in beta 3 and was fixed in b01ddd0993f2a706f6f24ff26180dc796d4bc517


fix 1514 with empty string check

Check if the string value of the time passed to Util.toInstant is blank before trying to convert the value. This will prevent logging the error message when toInstant should not attempt a conversion. Also changed from warn to debug when logging the failed conversion because failed user conversions are expected rather than something that requires a warning.
closes #1514

Thanks @willr3, lgtm!

If it looks good would you please merge? I think we discussed no self merging so that when we review we have the added motivation of being the one to merge :)


Refactor Definition and Examples

Definition should be in its own class, and so should Examples
Definition should have many Examples
Examples should belong to one Definition

#9 :smile:


Update toc.md

Issue #3464 - Wrong URL was mapped. It has been corrected now.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome please review.


How to get username on client.connected?

Why I can't get username on client.connected but able to get username on session.created?

Fixed in 2.3.0 release

Thanks. I see this update is on develop branch, and I'm curious how to update it from my previous emqttd directory? What file I need to change in my emqttd directory?


Guidance on how to validate a schema with many $ref against a HTTP response

Environment

Nuget Package: 3.2.0
OS: Windows & Linux
.Net Target: .NET 7

How can I help you today?
I'm looking to use JsonSchema to test Open API (Swagger) JSON data contract files against our API.
I'm submitting a HTTP GET request & looking to compare the response body against our Open API json file to see if the response is valid against the json schema defined.
Our schema file will sometimes have something like this with many nested $ref:
"paths": {
    "/Cars": {
      "get": {
        "summary": "Get List of Cars",
        "responses": {
          "200": {
            "$ref": "#/components/responses/CarData"
          }
        }
      }
    }
  },
  "responses": {
      "CarData": {
        "description": "Collection of Cars",
        "content": {
          "application/json": {
            "schema": {
              "type": "object",
              "properties": {
                "value": {
                  "type": "array",
                  "items": {
                    "$ref": "#/components/schemas/Car"
                  }
                }
              }
            }
          }
        }
      },
   },
   "components": {
    "requestBodies": {},
    "schemas": {
      "Provider": {
        "type": "object",
        "examples": [],
        "description": "Single Provider ",
        "title": "Provider Response",
        "properties": {
          "Model": {
            "type": "string",
          },
          "Year": {
            "type": "string",
          },
          "Make": {
            "type": "string",
          },
       },
       "required": ["Model", "Make"]
   }
 }

Any suggestions on how to accomplish this would be greatly appreciated.

Thanks for the question.  There are a couple things going on here:

Only OpenAPI v3.1 supports JSON Schema properly.  Prior versions are an altered version of JSON Schema based on Draft 4 (which this library doesn't support.
v4 of JsonSchema.Net introduces the ability to resolve references in arbitrary documents.  This was added specifically to support things like OpenAPI documents which contain references that are relative to the document root rather than the schema root.

For point 2, you may be interested in PR #360 which added this ability.  There are some comments I included for some people over at OpenApi.Net that give basic instructions on how to use this feature.  Also take a look at the docs.

Thank you. That's incredibly helpful. We are using 3.1. I am testing out the preview build & reading through #360 to try & get it to work.


Update memory test to use real random generation

Now that the test harness properly supports random number seeding so we can do actually do random tests, update the test in harness_tests/mem so it makes use of this.

Don't call srand() or srandom() in the test file because this is taken care of in the test harness initialization
Please use separate functions for randomized tests (don't put hardcoded values and random values in the same function)

commit b1f88dd1137e9a9769ed35225452b02fc7a15287 addresses this


could not connect to development server

I followed the steps in this tutorial as follows and it is throwing me the below error. Can anyone help resolve this ? I am pretty new to this and I apologize if I am making some silly mistake. Here are the steps I followed. I would greatly appreciate if someone can correct me.
Downloaded the repository.
Installed all the prerequisites
cd'ed into este-master folder
ran npm install
ran npm start with no errors
However, when I opened Android Studio and opened the project under este-master-> Android folder and ran the project on a simulator, it is throwing me the below error.
Typically, I get this error when I forgot to run "npm start" or when I open the Android folder in a project different from where the command "npm start" is ran. However, that is not the case in this scenario and I couldn't figure out why I am still getting this error in red screen
could not connect to development server

Steps to reproduce
Expected Behavior
Actual Behavior

There's some good troubleshooting info here:
http://stackoverflow.com/questions/36163008/react-native-hello-world-quick-start-could-not-connect-to-development-server
I don't believe this is an este issue.


Added edge segmentation by distance

Updates to the iPython notebook as well to illustrate segmentation

Merge into master is incorrect...


refactoring to extract all inputs parameters for irrigation problem

Context
The code for irrigation class lacks of cohesion.

It is hardly readable: we don't have an overview on all the inputs for the irrigation problem (address, crop, irrigation planning, weather data queried etc)
It is difficult to test other parameters: we have to change the parameters directly in the source code

Also there is a lot of magic numbers every where: 8 for the dimension of the problem which appears to be 2 * 4:

4: number of irrigation days during the crop season starting from 2006-03-31 to 2006-10-20
2: dimension of an event in the irrigation planning: day of the month & amount of water in cm

This problem is too specific and hardly adaptable with the current code structure (if we add 1 event in the planning for irrigation, we will have to change the dimension of the problem from 8 to 10 everywhere in the code)
Solution proposed
Refactor the code to

extract input parameters
increase the readability of the code

FYI @chrichri17 @Ethel2003 @abiolaTresor

Refactor leaf area index
Reference: https://pcse.readthedocs.io/en/stable/user_guide.html#getting-started