Sensor has device class None

Receiving warnings from HA on each load.
Logger: homeassistant.components.sensor
Source: components/sensor/__init__.py:597
Integration: Sensor ([documentation](https://www.home-assistant.io/integrations/sensor), [issues](https://github.com/home-assistant/home-assistant/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+sensor%22))
First occurred: 2:43:15 PM (2 occurrences)
Last logged: 2:43:23 PM

Sensor sensor.strava_0_0 has device class None, state class measurement and unit None thus indicating it has a numeric value; however, it has the non-numeric value: 2023-03-04 18:43:59 (<class 'datetime.datetime'>); Please update your configuration if your entity is manually configured, otherwise report it to the custom integration author.
Sensor sensor.strava_0_2 has device class None, state class measurement and unit min/km thus indicating it has a numeric value; however, it has the non-numeric value: 12:31 (<class 'str'>); Please update your configuration if your entity is manually configured, otherwise report it to the custom integration author.

Thanks @codyc1515
I am aware of this but there is no quick fix.
I have already removed the device_class and state_class from the PACE sensor but HA still throws the warning as I set the unit_of_measure on the sensor.
To resolve this I need to get a device_class for PACE with the supported units of measure added to HA core.
I can sepcify the time value as an integer but then the formatting is not correct on the frontend.

Not only is PACE sensor impacted but also the _0_0 descriptor sensor. On checking, it seems like the attribute is static.

Hi @codyc1515
That is the inital setting of it as most of the sensors (besides 2) have this setting.
In the method def capability_attributes(self) the state_class is removed from both the PACE and Index 0 sensors.
The device_class for the index 0 sensor is set to datetime correctly in this method too.
Can you please check under

Deveveloper Tools --> Statistics
Search for strava
Check if any have a button FIX ISSUES and resolve them using this.

The _0_0 sensor shoudl not be logging any issues.

Hi @codyc1515
Please can you also confirm that you are running the latest version (3.2.16) of ha_strava from this repository https://github.com/craibo/ha_strava
Thanks

Nope, none of them have Fix Issues button available and am on the latest version.

This should be resolved with version 3.2.17


Resolve issues dicovered with PhpStorm's Inspection tool

Resolve issues dicovered with PhpStorm's Inspection tool

Resolved, for now. It's been awhile since I worked with PhpStorm, this issue is not really applicable anymore.


Web part to web part communication HOL

Q
A

content fix?
no - yes?

New article?
no - yes?

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
Guidance
You can delete this section when you are submitting the pull request.

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'staging' branch.

@manishgarg1,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


where is step 6 from the readme

Readme says:
6. cd into your experiment folder and run ./run_all.sh
where is the experiments folder?

generator_gsm.py will generate an experiment folder based on the base_path in the config here: https://github.com/SqueezeAILab/LLM2LLM/blob/main/GSM8K/config.yaml#L4. In this case, for example, there will be a folder called llama2_0.1_chatgpt_10steps_1example which will have run_all.sh inside it.


[XLA] Fix a bug in the copy operations

We found this bug in a TF1 model and the bug is also upstream. So I'm sending the fix.
Note, the test isn't ideal. When the bug is there, it read and write bound memory that are outside the tensor. This will generate an CUDA_ERROR_ILLEGAL_ADDRESS error only when the wrong addresses aren't allocated. But in other cases, they could be allocated to other tensor.
In CUDA, I would allocate an overly big tensors and fill them with dummy values. Then after the code, I would check the output that shouldn't change and see if it changed. I'm not sure if we can do this with reasonable effort with XLA.

The import failed and the WIndows and Mac CI failed, but I can't see the logs.

The windows error has a pretty useless message, but I think it implies that it's not your fault: tensorflow\compiler\xla\literal.cc(1166) : fatal error C1001: An internal error has occurred in the compiler.
The ubuntu and mac failures also seem to not be your fault as they look like tf_runtime related compilation problems.
I'll try find what's causing them and let you know once they're handled.

The windows error has a pretty useless message, but I think it implies that it's not your fault: tensorflow\compiler\xla\literal.cc(1166) : fatal error C1001: An internal error has occurred in the compiler.
The ubuntu and mac failures also seem to not be your fault as they look like tf_runtime related compilation problems.
I'll try find what's causing them and let you know once they're handled.

Sorry for the breakage in tf_to_cubin and cubin_creator, this was a CL by me. Should be fixed by now.

tf_runtime is still broken, and it seems this is hard to fix. The team did some refactoring in tf_runtime that means that tensorflow cannot update the tf_runtime hash, but without updating there are also breakages. Hopefully the team will find a solution soon.


Roll engine 2c0eee43923f..e3e5f8dabc2e (1 commits)

git@github.com:flutter/engine.git/compare/2c0eee43923f...e3e5f8dabc2e
git log 2c0eee43923f..e3e5f8dabc2e --first-parent --oneline
2019-11-27<EMAIL_ADDRESS>Adding support for enabling semantics on desktop (#14003)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


New examples needed to show how to use Node's require() function.

Also, ones that call scripts rather than inlined functions.

Sorry for very late reply.
v8eval supports V8 engine itself and JavaScript built-in functions.
So it does not support Node functions.


Any controller will accept an uploaded file even if there's no POST method and put it in scratch/

I tried uploading a file to the default / handler in my application with the following script. (cat.jpg is just a file sitting in the same directory as this script)
# upload.py tests file open vulnerability in Erlang "ChicagoBoss" framework
# use "poster" package https://atlee.ca/software/poster/
# pip install poster

from poster.encode import multipart_encode
from poster.streaminghttp import register_openers
import urllib2

# Register the streaming http handlers with urllib2
register_openers()

# Start the multipart/form-data encoding of the file "DSC0001.jpg"
# "cat" is the name of the parameter, which is normally set
# via the "name" parameter of the HTML <input> tag.

# headers contains the necessary Content-Type and Content-Length
# datagen is a generator object that yields the encoded parameters
datagen, headers = multipart_encode({"cat": open("cat.jpg", "rb")})

# Create the Request object
request = urllib2.Request("http://<IP_ADDRESS>/", datagen, headers)
# Actually do the request, and get the response
print urllib2.urlopen(request).read()

There's no POST handler at route /
-module(beakconsole_main_controller, [Req]).
-compile(export_all).

before_(_) ->
    user_lib:require_login(Req).

index('GET', [], ChannelMaster) ->
    % return the name of this node (node) and a list of all connected nodes (nodes)
    { ok, [{channelmaster, ChannelMaster}, {node, node()}, {nodes, nodes()}] }.

error404('GET', []) ->
    { ok, []}.

A scratch directory is created:
[famserve@localhost beakconsole]$ ls -lat
total 280
drwxr-xr-x.  9 famserve famserve   4096 Oct 10 14:55 .
drwxr-xr-x.  2 web      web       4096 Oct 10 14:55 scratch

and the file is there:
[famserve@localhost beakconsole]$ ls -l scratch/
total 24
-rw-r--r--. 1 web web 22491 Oct 10 14:55 63-138-82-204-201-145-151-170-221-154-79-155-142-101-27-104
[famserve@localhost beakconsole]$

It would probably be a good idea to at least check to see if there's a Post Method before allowing this.
Also, the user wasn't logged in, so the before_ method actually redirected to my login controller. And the file still made it up!
[swirsky@Thrills-iMac test (develop)]$ python upload.py

<form method="post">
Name:

<input name="name" />

Password:

<input name="password" type="password" />

<input type="submit" value="Log in" />
<input type="hidden" name="redirect" value="/main" />
</form>

I think I can handle this in the before_, but I didn't expect this. I noticed it when some systems we have in production were collecting all sorts of "malware" in this scratch directory. (Fortunately, none of this PhP malware has any power in this directory and in the Erlang Universe.)

I think this is mainly a SimpleBridge issue, but there may be away to control SimpleBridge so it doesn't do this.
The best workaround I found was to add a 'POST' handler that deletes the file.

Yeah this one also surprised me. The same behaviour does also apply to simple_bridge_handler_sample.erl, which could be easily reproduced with the simple_bridge example server:
> make run_inets
...
> curl -X GET http://<IP_ADDRESS>:8000/peer_ip -F 'file1=@<pathh_to_file>'

Not sure if it's some kind of default case misbehaviour or maybe even intentional. Maybe @choptastic could be so kind and give us some details on how it's intended?
@chatterbeak we came up with another workaround which seems IMHO to be a little bit more complete and prevents from forgetting some controller endpoints. We're using a boss_filter which looks similar to this one:
-module(some_boss_filter).

-export([
    after_filter/3
]).

after_filter({StatusCode, Payload, Headers}, _FilterConfig, RequestContext) ->
    case lists:keyfind(request, 1, RequestContext) of
        {request, Request} ->
            handle_request_cleanup(Request);
        false ->
            lager:error("Couldn't find request in context for final data cleanup", [RequestContext])
    end,
    {StatusCode, Payload, Headers};
after_filter(Other, _FilterConfig, _RequestContext) ->
    %% Will match for 500er errors
    Other.

%%--------------------------------------------------------------------
%%% Internal functions
%%--------------------------------------------------------------------

handle_request_cleanup(Request) ->
    lists:foreach(fun(Attachment) ->
        {LogLevel, DeleteResult} =
        case file:delete(sb_uploaded_file:temp_file(Attachment)) of
            {error, enoent} ->
                %% The file was already deleted from business logic so only a debug log is needed
                {debug, file_already_deleted};
            OtherReturn ->
                {notice, OtherReturn}
        end,
        lager:log(LogLevel, self(), "Deleting remaining temporary file ~p with name ~p, size ~p byte and "
                                    "field_name ~p from scratch folder; result: ~p", [
            sb_uploaded_file:temp_file(Attachment),
            sb_uploaded_file:original_name(Attachment),
            sb_uploaded_file:size(Attachment),
            sb_uploaded_file:field_name(Attachment),
            DeleteResult
        ])
    end, Request:post_files()).

and in in the boss.config:
[{boss, [
    ...
    {controller_filter_modules, [
         some_boss_filter
    ]},
    ...
]}]

Thanks for the ideas.
I noticed this because various "malicious" php scripts were appearing in the scratch directory on some of my ChicagoBoss sites. Fortunately, the couldn't really do harm. But if you look at the constant barrage of PHP exploit attempts that any public website sees, it's common for these exploit suites to try uploading files to "/" and seeing if they can get them to run.


Add HOC approach to work with stateless functional react components

Currently, react-suitcssify doesn't work with stateless functional React components. This pull request adds the Higher-Order Component approach which works with ES6 classes and stateless functional components. I've seen the continued need for the decorator approach (which modifies the component) in cases where I couldn't insert a HOC in the middle, so I left that one in there.

@pbomb This looks great, thanks!  I made an additional commit and opened a 2nd PR.  Care to have a look before I merge?  https://github.com/brentertz/react-suitcssify/pull/4


TBMQ - installation guides

PR description
The documentation updated for TBMQ getting started guide and new windows guide with several more improvements.
Link checker
The links will be checked by the build agent automatically once you create or update your PR.
You can use the following command to check the broken links locally.
docker run --rm -it --network=host --name=linkchecker ghcr.io/linkchecker/linkchecker --check-extern --no-warnings http://<IP_ADDRESS>:4000/


Add tls_crypt

Pull Request (PR) description
Add --tls-crypt in alternative to tls auth (new feature since 2.4)

Also tested on Ubuntu 18.04 LTS w/ Linux and MacOS Clients

Any idea when this will make it into a release? We were about to switch to this module and then found that this feature isn't available yet. Thanks.


feat: adds DATAHUB_REVISION acyrl-datahub-actions deployment

We are deploying action recipes in k8s configmaps which are mounted as k8s volumes in the acryl-datahub-actions deployment. However, updating the configmap also requires to manually rollup the pods in the k8s deployment so new recipes are picked up.
This is adding DATAHUB_REVISION from .Release.Revision as env var to force the redeploy of acryl-datahub-actions deployment with every new deployment.
This is following same strategy as GMS, and consumer jobs.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Not sure why this needs to be an environment variable. Anyway, how to achieve the desired effect is documented at Automatically Roll Deployments.

I didn't know about that helm feature or common practice. Definitely, it covers my use case: force the roll up of the pods. I understand DATAHUB_REVISION somehow follows the same approach: adding an annotation that changes with every deployment so it forces the roll up. Whether value is checksum, random number or release version is sort of implementation detail. Anyway, thanks for sharing @darnaut !
Specifically about the DATAHUB_REVISION environment var: I noted GMS or consumer jobs were rolled up in every deploy (even if no changes in the k8s objects) while acryl datahub actions didn't. I checked up differences and the only one I found was DATAHUB_REVISION. So I understood it was introduced to build such a behaviour.
I see the env var was mostly introduced here https://github.com/acryldata/datahub-helm/pull/254/files by @david-leifker . Maybe the author can clarify if the env var was introduced with such a purpose or it just became an additional side effect.

DATAHUB_REVISION is an actual environment variable used by some DataHub components.

Following @darnaut suggestion, this PR is superseded by PR #487


chore: refactor stream log functions to easy handle options

Adding some improvement on how to get the previous logs of a pod including a small refactor on the stream logs functions to make easy to test
Closes #1801

/test limit=local

/test limit=local

/ok-to-merge


chore(master): release 2.30.0

:robot: I have created a release beep boop
2.30.0 (2023-07-06)
Bug Fixes

always enabled registration (671bf03)
configuration: add correct label for show more button (2850ff8)
dao: read registrationEnabled from api (3ebefab)
dao: read registrationEnabled from api (3ebefab)
dho-card: share button link (#DEV-828) (#2292) (4232858)
language-drawer: remove automating translation widget (52bc2b3)
members: add correct value for filter (#2293) (76519f2)

Miscellaneous Chores

release 2.30.0 (425394c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hypha-dao/dho-web-client/releases/tag/v2.30.0 :sunflower:


HIVE-24509 Move show specific codes under DDL and cut MetaDataFormatter classes to pieces

What changes were proposed in this pull request?
Move the codes used by show commands only next to the classes processing those commands.
Why are the changes needed?
Move the codes from org.apache.hadoop.hive.ql.metadata.formatting to the show command related direcctories, cutting them to pieces to their specific commands, or the utility classes if used by multiple commands.
Does this PR introduce any user-facing change?
No
How was this patch tested?
All the unit tests and q tests are still running.

Thank you @belugabehr for your comments, please check out the modified PR.

Thank you @belugabehr for your comments, please check out the modified PR.

@belugabehr I've fixed most of the issues that you've mentioned. I was mainly focused on putting the code to it's proper location, in a manageable structure, and it was great that you've looked at the code thoroughly, finding these suboptimal solutions, thank you for that.Regarding the append().append() like issues:

@belugabehr I've fixed most of the issues that you've mentioned. I was mainly focused on putting the code to it's proper location, in a manageable structure, and it was great that you've looked at the code thoroughly, finding these suboptimal solutions, thank you for that.Regarding the append().append() like issues:

@belugabehr  removed unrelated changes from this patch.

@belugabehr  removed unrelated changes from this patch.


Demyx can not start after Docker Engine restarted.

Hi,
After restart docker engine, wp site was down, and the reason is that demyx_socket container did not started.
Running demyx command on terminal returned the following:
Starting demyx_socket ...

ERROR: for demyx_socket  Cannot start service socket: OCI runtime create failed: container_linux.go:370: starting container process caused: process_linux.go:459: container init caused: process_linux.go:422: setting cgroup config for procHooks process caused: resulting devices cgroup doesn't match target mode: unknown

ERROR: for socket  Cannot start service socket: OCI runtime create failed: container_linux.go:370: starting container process caused: process_linux.go:459: container init caused: process_linux.go:422: setting cgroup config for procHooks process caused: resulting devices cgroup doesn't match target mode: unknown

ERROR: Encountered errors while bringing up the project.
The only other container running on the same engine was Portainer.
Running on CentOS7
Docker version 20.10.3, build 48d30b5

Ok, this error happened after updating CentOS7 with yum update.
The packages that yum updated:
===========================================================================================================================================================================================================================================
 Package                                                           Arch                                           Version                                                    Repository                                                Size
============================================================================================================================================================================================================================================
Updating:
 containerd.io                                                     x86_64                                         1.4.3-3.1.el7                                              docker-ce-stable                                          33 M
 docker-ce                                                         x86_64                                         3:20.10.4-3.el7                                            docker-ce-stable                                          27 M
 docker-ce-cli                                                     x86_64                                         1:20.10.4-3.el7                                            docker-ce-stable                                          33 M
 docker-ce-rootless-extras                                         x86_64                                         20.10.4-3.el7                                              docker-ce-stable                                         9.1 M
 epel-release                                                      noarch                                         7-13                                                       epel                                                      15 k
 libblkid                                                          x86_64                                         2.23.2-65.el7_9.1                                          updates                                                  183 k
 libgudev1                                                         x86_64                                         219-78.el7_9.3                                             updates                                                  109 k
 libmount                                                          x86_64                                         2.23.2-65.el7_9.1                                          updates                                                  185 k
 libsmartcols                                                      x86_64                                         2.23.2-65.el7_9.1                                          updates                                                  143 k
 libuuid                                                           x86_64                                         2.23.2-65.el7_9.1                                          updates                                                   84 k
 net-snmp-libs                                                     x86_64                                         1:5.7.2-49.el7_9.1                                         updates                                                  751 k
 perl                                                              x86_64                                         4:5.16.3-299.el7_9                                         updates                                                  8.0 M
 perl-Pod-Escapes                                                  noarch                                         1:1.04-299.el7_9                                           updates                                                   52 k
 perl-libs                                                         x86_64                                         4:5.16.3-299.el7_9                                         updates                                                  690 k
 perl-macros                                                       x86_64                                         4:5.16.3-299.el7_9                                         updates                                                   44 k
 systemd                                                           x86_64                                         219-78.el7_9.3                                             updates                                                  5.1 M
 systemd-libs                                                      x86_64                                         219-78.el7_9.3                                             updates                                                  418 k
 systemd-sysv                                                      x86_64                                         219-78.el7_9.3                                             updates                                                   97 k
 tzdata                                                            noarch                                         2021a-1.el7                                                updates                                                  501 k
 util-linux                                                        x86_64                                         2.23.2-65.el7_9.1                                          updates                                                  2.0 M
 zlib                                                              x86_64                                         1.2.7-19.el7_9                                             updates                                                   90 k

Transaction Summary
============================================================================================================================================================================================================================================

Right after this update, demyx_socket container goes down and the error message above mentioned is displayed.

Hi, sorry I didn't get back to you in IRC. It looks like you got it fixed by downgrading Docker. I will need to do more testing on CentOS or Rocky Linux as it's called now.

NP @demyxco
The package that broke demyx_socket was docker-ce version 3:20.10.4-3.el7. I don't know why.

Won't know until I do more testing


Lazysizes + Flickity .lazyload immediately loaded

Hi.
I am using lazysizes + flickity in an overlay. Flickity is only initialised once the overlay is triggered (and then memoised for reuse). However the images inside the gallery are being directly loaded on pageload not respecting the `.lazyload like here:
https://codepen.io/aFarkas/pen/ogPxEa (btw the images are broken … but the lazyload still works if one inspects the network in dev tools)
Here is my markup for each gallery cell:

Probably worth noting that I use visibility: hidden on the cells until the slider is initiated – still, lazysizes greedily loads the images inside the gallery onpageload. Interestingly images further down the page are not loaded immediately, only when they get visible in the viewport.
I also tried the solution described here: https://github.com/aFarkas/lazyflickity … it didn't help either
Can recommend anything else @aFarkas?

lazysizes assumes, that images that are visibility: hidden but in view are soon to be seen. (These images are loaded, but not so eagerly). Additionally as long as flickity is not initialized all images are layered above each other
I also assume, that your dialog already uses visibility: hidden.
You should be able to use display: none though:
.dialog:not(.is-visible) .lazyload {
    display: none;
}

This would work, but it would again load all images at the same time when the dialog is visible.
In my case I use Flickty as a fader slideshow, and all images are stacked (with left:0; opacity:0;), so I assume this is why it loads them all at once resulting in a terrible slideshow experience.
I probably need to hook into the cellSelect and append the .lazyload class dynamically to the sibling  elements with Flickity.

Okay, I found a solution myself that is pretty decent and does not require any extra JS.
/* Always hide the not-lazyloaded images in the overlay */
.overlay .lazyload {
    display: none;
}

/* Gradually show the selected and lazy img next to the selected slide on interactions*/
.slideshow--slide.is-selected .lazyload,
.slideshow--slide.is-selected + .slideshow--slide .lazyload {
    display: block;
}

That works really well … unfortunately there is not prev selector in CSS (yet – one could use :has()) … but since the selected slide loads pretty fast that is a good trade off.


feat: add rate component

Thanks，There seems to be a slight problem with the test🤣

Thanks，There seems to be a slight problem with the test🤣

Sorry I didn't notice, let me check


[#4558] Cleanup

Codecov Report

Merging #5810 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5810      +/-   ##
==========================================
- Coverage   40.73%   40.69%   -0.04%
==========================================
  Files        2934     2935       +1
  Lines       88083    88158      +75
  Branches    11574    11589      +15
==========================================
+ Hits        35877    35880       +3
- Misses      49111    49184      +73
+ Partials     3095     3094       -1

Impacted Files
Coverage Δ

...point/profiler/sender/grpc/StatGrpcDataSender.java
0% <0%> (ø)
:arrow_up:

...filer/sender/grpc/RetryResponseStreamObserver.java
0% <0%> (ø)

...oint/profiler/sender/grpc/AgentGrpcDataSender.java
0% <0%> (ø)
:arrow_up:

...t/profiler/sender/grpc/MetadataGrpcDataSender.java
0% <0%> (ø)
:arrow_up:

...point/profiler/sender/grpc/SpanGrpcDataSender.java
0% <0%> (ø)
:arrow_up:

.../pinpoint/profiler/sender/grpc/GrpcDataSender.java
0% <0%> (ø)
:arrow_up:

...collector/receiver/grpc/ShutdownEventListener.java
0% <0%> (-50%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
66.66% <0%> (-3.34%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07829a0...a15d82a. Read the comment docs.


Feature/add properties v3

Let me know when you want a review. I'll need a detailed description of your aims though.

Release note

Add Size for string (maxLength)
Add Note in Diagram (in Note there are Description, Example, Format, Extension)
Add field in Class in addition link (like Diagram Class)
Replace {O} (optional) by {R} (Require)
There is a case on error when "array", so the type return object[]

Example

Looks interesting. Have you checked the appearance of the other diagrams in demos? What's good for you might be a whole lot of mess for others. Probably boils down to configuration options which you have a TODO for. Default will probably be to leave that stuff out.

Before

After

An option should be added to display the notes

Before

After

I think I'm done.
After, as you want if you are interested in my suggestion.

Hi Dimitri
Thanks for getting involved. My first comment is that there are too many enhancements mixed up in this PR. For the sanity of the reviewers you need to keep changes separate so that they can be discussed and worked on independently of other changes. This is something you pick up as you get into open-source contributions.
This is your summary:

Add Size for string (maxLength)
Add Note in Diagram (in Note there are Description, Example, Format, Extension)
Add field in Class in addition link (like Diagram Class)
Replace {O} (optional) by {R} (Require)
There is a case on error when "array", so the type return object[]

Each of those contributions should be a separate PR but the best idea is to discuss what you want to do first so you don't put too much effort in to something that doesn't get accepted.
The output of this project is a UML Diagram that communicates the essence of the API, not the details. I'm not happy with the addition of string maxLength and notes because it seems like needless clutter. For example with the notes, in general the times that a description adds more than just the existing name of the field is when the description is long and detailed. In that specific case I also don't want that appearing as extra clutter.  Here's a quick example of a long description (my apis have lots of long descriptions) that I definitely would not want in a diagram!
name: continuationToken
description: |
            Describes to the server the starting point of
            the next page of results and is obtained from
            the current page. May contain an offset if desired
            but is at the discretion of implementer. Note that
            it is possible that a call specifying a continuation
            token may return en empty list (but an empty list return
            should not have a continuation token on it so at
            that point paging would stop).

The {O} vs {R} usage is a style thing. Where have you seen {R} usage? Got links? I find {O} usage less noisy than {R} usage in general and that is apparent in the bookstore diagram above.

Add field in Class in addition link (like Diagram Class)
I need more info on this one.

There is a case on error when "array", so the type return object[]
I need more info on this effects of this one

So I'm not open to adding Note, size, and {R} instead of {O}. I don't see them as adding value but you can try and convince me!
The other two issues need more explanation and should be opened as separate PRs please.
I see your PR does not pass CI. This mean that running mvn clean install on the project is failing. Make sure you do that check before requesting review.
Another tip for PR contributions is to do all your work in your fork of the repo and only open a PR on the original repo when your PR is ready for review. That way I won't be drawn by notifications to inspect your changes only to see they are not ready for review.


Continuous integration for binary releases

Make everyone's life easier by not having to build the app by themselves.
This updates the releases and uploads the executable for Linux, Mac and Windows one every push automatically.
This is how the releases will look like: https://github.com/KorigamiK/VIR/releases

LGTM

LGTM, thanks a lot!

Awesome!


failed to deduplicate http url versions

<EMAIL_ADDRESS>  version "1.12.0"
  resolved "https://registry.yarnpkg.com/eslint-plugin-mdx/-/eslint-plugin-mdx-1.12.0.tgz#7d8a722eb6cd97f3d81aa02fb3430f5fe17c1797"
  integrity sha512-d+vmIyyoDvRjQ0XGZ1v9DtnEk79dUOK+LzHoDGlBvtQHjlMyHl54Mw4EblX3d3nysyLss3+1V0SOrj+e9F+lNQ==
  dependencies:
    cosmiconfig "^7.0.0"
    eslint-mdx "^1.12.0"
    remark-mdx "^1.6.22"
    remark-parse "^8.0.3"
    remark-stringify "^8.1.1"
    tslib "^2.1.0"
    unified "^9.2.1"
    vfile "^4.2.1"

"eslint-plugin-mdx@https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-plugin-mdx":
  version "1.12.0"
  resolved "https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-plugin-mdx#3e16a11e9ae1231d374ff3c60c0dc6af3dcbb09a"
  dependencies:
    cosmiconfig "^7.0.0"
    eslint-mdx "https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-mdx"
    eslint-plugin-markdown "^2.1.0"
    remark-mdx "^1.6.22"
    remark-parse "^8.0.3"
    remark-stringify "^8.1.1"
    synckit "^0.1.5"
    tslib "^2.2.0"
    unified "^9.2.1"
    vfile "^4.2.1"

"eslint-plugin-mdx": "https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-plugin-mdx" is used in package.json, and the normal one is installed by a (dev) dependency.
It should consider dep in package.json with higher priority, and deduplicate them.

I didn't know you can use an url as the version specifier.
I'll try to have a look to see what can we do about it, but my initial reaction is that this is not possible: there is no way to know that https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-plugin-mdx can (and will always) be satisfied by the same version used for<EMAIL_ADDRESS>no?

Yeah, I don't see how we can do this.
https://pkg.csb.dev/mdx-js/eslint-mdx/commit/6a3b2aa4/eslint-plugin-mdx is not a range but a specific version, so there is no easy way we can determine it overlaps with ^1.12.0 and deduplicate it.


Low resolution system tray icon on MX Linux

The tray icon showed in MX Linux, looks like does not have sufficient sharpness ? Now, this does not seem real issue to me, but how can I increase its resolution to sharpen it ?
Using the latest flatpak build on MX Linux 21 with xfce 4.16.

Oh. I got it. It picks up the favicon of the page and shows it as the tray icon. As WhatsApp Web does not supply icon resolution more than 16 * 16px, I am seeing it in low res.

Don't worry. I made a custom icon and I'm no longer get it from the favicon, because it fixes another bug. This is planned for the next release.

The new tray icon just works perfect..!! Thank you..!


Add Unique Reusable Rating Component

I have created 2 components rating score and rating input, please take a look and comment if you require any corrections. Tks!

@dtd0103 Good job and thanks for contributing! In future, its better to avoid using formatter on already formatted code. This creates merge conflicts. Cheers!


Makefile scripts not interpreting env variables

What happened:
Horusec reported a hardcoded password in a Makefile that was using an external env variable. One example error below:
Language: Leaks
Severity: HIGH
Line: 19
Column: 11
SecurityTool: HorusecLeaks
Confidence: HIGH
File: Makefile
Code: GIT_REMOTE=***github.com/ZupIT/ritchie-cli
Details: Password found in a hardcoded URL
A password was found in a hardcoded URL, this can lead to not only the leak of this password but also a failure point to some more sophisticated CSRF and SSRF attacks. Check CWE-352 (https://cwe.mitre.org/data/definitions/352.html) and CWE-918 (https://cwe.mitre.org/data/definitions/918.html) for more details.
Type: Vulnerability
ReferenceHash: e6b6b327efae6f8f8a846b603f143cbaad7c1c288b7f58b41605097e6e8456f5

The actual code implementation is
<EMAIL_ADDRESS>Where GIT_PASSWORD is not previously declared anywhere in the project
What you expected to happen:
Injected env variables should not present a security risk
How to reproduce it (as minimally and precisely as possible):
Create a makefile that exposes a url with password substituted by an env
i.e<EMAIL_ADDRESS>Environment:

Horusec version (use horusec version): v1-5-0
Operating System: Linux x64
Network plugin / Tool and version (if this is a network-related / tool bug):
Others:

Hi @henriquemoraeszup thanks for reporting.
apparently this is a false positive. you can ignore this vulnerability by adding the reference hash in the horusec-config.json file.
https://docs.horusec.io/referencia/cli#configuracoes-da-cli


README: Update version in maven dependency example

By the way: Thank you very much for developing email-rfc2822-validator and simple-java-mail!

 Also, thanks for triggering me to update the release notes which I forgot...


Add env wrapper with traj id for CRL

Looks good, no problems. Remark for posterity that this trajectory id could be the fix for why it's so hard to obtain good results in manipulation environments.


_posts/0000-01-02-ChristopherKDau.md

Add new file to _post
created a branch, created a file and made a commit, and opened a pull request

Updated file name

adding more comments


Outdated files in dev-1.20-ko.5

This is a Bug Report
Problem
Outdated files in the upstream/dev-1.20-ko.5 branch.
69 files to be modified

[ ] M1.  content/en/community/_index.html  | 21(+S) 2(-)
[ ] M2.  content/en/docs/concepts/architecture/controller.md  | 1(+XS) 1(-)
[ ] M3.  content/en/docs/concepts/architecture/nodes.md  | 4(+XS) 3(-)
[ ] M4.  content/en/docs/concepts/cluster-administration/_index.md  | 2(+XS) 2(-)
[ ] M5.  content/en/docs/concepts/cluster-administration/logging.md  | 63(+M) 69(-)
[ ] M6.  content/en/docs/concepts/cluster-administration/manage-deployment.md  | 16(+S) 7(-)
[ ] M7.  content/en/docs/concepts/configuration/configmap.md  | 1(+XS) 1(-)
[ ] M8.  content/en/docs/concepts/configuration/overview.md  | 2(+XS) 2(-)
[ ] M9.  content/en/docs/concepts/configuration/secret.md  | 2(+XS) 7(-)
[ ] M10.  content/en/docs/concepts/containers/container-lifecycle-hooks.md  | 16(+S) 17(-)
[ ] M11.  content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md  | 2(+XS) 2(-)
[ ] M12.  content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md  | 1(+XS) 1(-)
[ ] M13.  content/en/docs/concepts/extend-kubernetes/service-catalog.md  | 1(+XS) 1(-)
[ ] M14.  content/en/docs/concepts/overview/what-is-kubernetes.md  | 1(+XS) 1(-)
[ ] M15.  content/en/docs/concepts/overview/working-with-objects/labels.md  | 2(+XS) 2(-)
[ ] M16.  content/en/docs/concepts/overview/working-with-objects/object-management.md  | 2(+XS) 2(-)
[ ] M17.  content/en/docs/concepts/policy/pod-security-policy.md  | 1(+XS) 1(-)
[ ] M18.  content/en/docs/concepts/policy/resource-quotas.md  | 19(+S) 8(-)
[ ] M19.  content/en/docs/concepts/scheduling-eviction/assign-pod-node.md  | 1(+XS) 1(-)
[ ] M20.  content/en/docs/concepts/scheduling-eviction/scheduler-perf-tuning.md  | 1(+XS) 1(-)
[ ] M21.  content/en/docs/concepts/security/controlling-access.md  | 2(+XS) 2(-)
[ ] M22.  content/en/docs/concepts/security/overview.md  | 2(+XS) 0(-)
[ ] M23.  content/en/docs/concepts/services-networking/dns-pod-service.md  | 3(+XS) 3(-)
[ ] M24.  content/en/docs/concepts/services-networking/dual-stack.md  | 2(+XS) 2(-)
[ ] M25.  content/en/docs/concepts/services-networking/ingress-controllers.md  | 5(+XS) 3(-)
[ ] M26.  content/en/docs/concepts/services-networking/service.md  | 5(+XS) 5(-)
[ ] M27.  content/en/docs/concepts/storage/persistent-volumes.md  | 6(+XS) 1(-)
[ ] M28.  content/en/docs/concepts/storage/storage-classes.md  | 1(+XS) 1(-)
[ ] M29.  content/en/docs/concepts/storage/volume-pvc-datasource.md  | 1(+XS) 1(-)
[ ] M30.  content/en/docs/concepts/storage/volumes.md  | 4(+XS) 2(-)
[ ] M31.  content/en/docs/concepts/workloads/controllers/cron-jobs.md  | 5(+XS) 1(-)
[ ] M32.  content/en/docs/concepts/workloads/controllers/daemonset.md  | 2(+XS) 2(-)
[ ] M33.  content/en/docs/concepts/workloads/controllers/deployment.md  | 16(+S) 9(-)
[ ] M34.  content/en/docs/concepts/workloads/controllers/replicationcontroller.md  | 6(+XS) 5(-)
[ ] M35.  content/en/docs/concepts/workloads/pods/ephemeral-containers.md  | 2(+XS) 2(-)
[ ] M36.  content/en/docs/contribute/participate/roles-and-responsibilities.md  | 1(+XS) 1(-)
[ ] M37.  content/en/docs/reference/access-authn-authz/authorization.md  | 10(+S) 1(-)
[ ] M38.  content/en/docs/reference/command-line-tools-reference/feature-gates.md  | 2(+XS) 2(-)
[ ] M39.  content/en/docs/reference/glossary/api-group.md  | 1(+XS) 1(-)
[ ] M40.  content/en/docs/reference/kubectl/cheatsheet.md  | 2(+XS) 2(-)
[ ] M41.  content/en/docs/reference/tools.md  | 2(+XS) 3(-)
[ ] M42.  content/en/docs/setup/production-environment/container-runtimes.md  | 1(+XS) 1(-)
[ ] M43.  content/en/docs/setup/production-environment/tools/kops.md  | 2(+XS) 2(-)
[ ] M44.  content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md  | 1(+XS) 1(-)
[ ] M45.  content/en/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md  | 2(+XS) 2(-)
[ ] M46.  content/en/docs/setup/production-environment/windows/user-guide-windows-containers.md  | 1(+XS) 1(-)
[ ] M47.  content/en/docs/setup/release/notes.md  | 3(+XS) 3(-)
[ ] M48.  content/en/docs/tasks/access-application-cluster/access-cluster.md  | 1(+XS) 1(-)
[ ] M49.  content/en/docs/tasks/administer-cluster/access-cluster-api.md  | 1(+XS) 1(-)
[ ] M50.  content/en/docs/tasks/administer-cluster/access-cluster-services.md  | 1(+XS) 1(-)
[ ] M51.  content/en/docs/tasks/administer-cluster/change-default-storage-class.md  | 1(+XS) 1(-)
[ ] M52.  content/en/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes.md  | 1(+XS) 1(-)
[ ] M53.  content/en/docs/tasks/configure-pod-container/pull-image-private-registry.md  | 4(+XS) 12(-)
[ ] M54.  content/en/docs/tasks/configure-pod-container/static-pod.md  | 1(+XS) 1(-)
[ ] M55.  content/en/docs/tasks/extend-kubectl/kubectl-plugins.md  | 13(+S) 19(-)
[ ] M56.  content/en/docs/tasks/job/coarse-parallel-processing-work-queue.md  | 1(+XS) 1(-)
[ ] M57.  content/en/docs/tasks/job/parallel-processing-expansion.md  | 1(+XS) 1(-)
[ ] M58.  content/en/docs/tasks/run-application/delete-stateful-set.md  | 1(+XS) 1(-)
[ ] M59.  content/en/docs/tasks/run-application/horizontal-pod-autoscale.md  | 11(+S) 10(-)
[ ] M60.  content/en/docs/tasks/run-application/run-single-instance-stateful-application.md  | 6(+XS) 0(-)
[ ] M61.  content/en/docs/tutorials/_index.md  | 1(+XS) 1(-)
[ ] M62.  content/en/docs/tutorials/clusters/apparmor.md  | 1(+XS) 2(-)
[ ] M63.  content/en/docs/tutorials/kubernetes-basics/_index.html  | 1(+XS) 1(-)
[ ] M64.  content/en/docs/tutorials/kubernetes-basics/expose/expose-intro.html  | 1(+XS) 7(-)
[ ] M65.  content/en/docs/tutorials/stateful-application/basic-stateful-set.md  | 16(+S) 6(-)
[ ] M66.  content/en/docs/tutorials/stateful-application/zookeeper.md  | 48(+M) 47(-)
[ ] M67.  content/en/docs/tutorials/stateless-application/guestbook.md  | 66(+M) 124(-)
[ ] M68.  content/en/examples/application/guestbook/frontend-deployment.yaml  | 9(+XS) 15(-)
[ ] M69.  content/en/examples/application/guestbook/frontend-service.yaml  | 4(+XS) 6(-)

0 files to be renamed
6 files to be deleted

[ ] D1.  content/en/docs/tasks/debug-application-cluster/logging-elasticsearch-kibana.md
[ ] D2.  content/en/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
[ ] D3.  content/en/examples/application/guestbook/redis-master-deployment.yaml
[ ] D4.  content/en/examples/application/guestbook/redis-master-service.yaml
[ ] D5.  content/en/examples/application/guestbook/redis-slave-deployment.yaml
[ ] D6.  content/en/examples/application/guestbook/redis-slave-service.yaml

Proposed Solution
Use git diff to check what is changed in the upstream. And apply the upstream changes manually
to the content/ko of upstream/dev-1.20-ko.5 branch.
For example:
# checkout `upstream/dev-1.20-ko.5`
...
# check what is updated in the upstream
git diff upstream/dev-1.20-ko.4 upstream/dev-1.20-ko.5 -- content/en/community/_index.html
# apply changes to content/ko
vi content/ko/community/_index.html
...
# commit and push
...
# make PR to `upstream/dev-1.20-ko.5`

Pages to Update
/language ko

/milestone dev-1.20-ko.5

/triage accepted

/help

@gochist I can contribute M1 ~ M20

I can contribute M21 ~ M50.
M1 ~ M20 : @seokho-son
M21 ~ M50 : @pjhwa

I can contribute M51 ~ M69.
M1 ~ M20 : @seokho-son
M21 ~ M50 : @pjhwa
M51 ~ M69, D1 ~ D6 : @ysyukr

completed ~ !


Fix:-Simplified the Jest-haste-map API

Tried scratching The Jest-haste-map api and seems like the majority of it is unused and also no mention in docs too, we can simplify the api further which is what this PR is done for

Great minds.. ;) https://github.com/facebook/jest/pull/13023

its funny how both PRs look identical, indeed great minds think the same

hey @Smrtnyk could you help me with the lint issues!

@SimenB could you provide some direction with the duplicate import error, could not figure out something that can work!

Yeah, let's land #13023 👍


python error

it keeps coming up with this error everytime i try to open it

it keeps coming up with this error everytime i try to open it

This problem is from the side of your system, the script works without any errors. You may have changed the name of the files or you are not running the terminal in the right place
search on google : help about running python script


Create pull_request_template.md

added a sample pull request template in ./github/pull_request_template.md

This is good for the template, but i think we'll tailor it more to our project.


Last Week in Pony - September 3, 2023

Version 0.62.0 of ponylang/action-testing has been released.
See the release notes for more details.

Version 0.62.1 of ponylang/action-testing has been released.
See the release notes for more details.

Version 0.6.2 of ponylang/release-bot-action has been released.
See the release notes for more details.

Version 0.6.3 of ponylang/release-bot-action has been released.
See the release notes for more details.

Version 0.63.0 of ponylang/action-testing has been released.
See the release notes for more details.

Version 0.56.0 of ponylang/ponyc has been released.
See the release notes for more details.

Version 0.8.0 of ponylang/corral has been released.
See the release notes for more details.


[RFC] Add ability for custom meta tag logic

I currently generate my meta tags manually with some twig logic, and for the most part it is similar to the logic in this extension, but every project does things slightly differently.
I don't know how this would be implemented, but it would be great if we could somehow provide our own ways of specifying meta tag values in the "fallback chain" of logic in this extension. For example, I may want the title to be the combination of two different fields, if they're filled, and then fall back to what the extension specifies.

Correct me if I'm wrong. Could this be achieved by simple overriding the template in the themes directory?
Currently it seems the path is prefixed?
https://github.com/bobdenotter/seo/blob/master/Extension.php#L38


HTML ( External links ) are not getting downloaded from resources

Describe the bug
Many times , there are html files ( external links ) in the resources for a particular lecture .These files are not getting downloaded . They are pretty important as mostly they contain exercises and stuff
All other files from resources tab are getting downloaded but html files are getting skipped
To Reproduce
Simply try downloading a lecture which has external links ( html files ) in its resources
Screenshots
In the screenshots below , the files ticked are getting downloaded but external links are being skipped

**Python Environment : **

OS Platform: Manjaro Linux
Python Version : 3.8.3

@r0oth3x49 if you dont have any course which has these external links in resources , you can test in my account . You already have the credentials
To reproduce - Just simply try downloadiing the very first section from this course - https://www.udemy.com/course/automate
There are 3 lectures in this section and each have external links in their resources


Feedback for: compose/startup-order.md

URL: https://docs.docker.com/compose/startup-order.md
It could be just me, but it took me some time to figure out why my added arguments to the wait-for-it.sh script made it fail. It was because of the shift command which I didn't know yet. You might mention this in the documentation?

@Stasmo Thanks for the feedback, and sorry for the delay.
I've added a tip regarding this in the PR referenced ^^. I was going to do more to remove the little script examples altogether, but it seems like they are nice to have there. Let me know what you think. This will be published tonight.

@londoncalling Did you mean to post in #123?

@Stasmo sorry, no I haven't gotten to that yet :-) I tagged you instead of @raugustinus


Add license text (New BSD License)

According to the original Google Code archive:
https://code.google.com/archive/p/aobench/
https://github.com/syoyo/aobench/issues/2

👍


Tracking issue for tc39 process requirements

Stage 1

[x] introduced to TC39 (Presented on April 20, 2021)
[x] champions identified (@bnb)
[x] initial explainer (Explainer)

Stage 2

[x] committee approval (Approved on April 20, 2021)
[x] spec text written
[x] spec reviewers selected (@ljharb, @leobalter, @Felienne)

Stage 3

[x] committee approval
[x] spec editor sign off
[x] spec reviewer sign off

[x] @ljharb
[x] @leobalter
[x] @Felienne

[x] received developer/implementer feedback

[x] developers (has, lodash.has)
[x] implementers

Stage 4

[ ] committee approval
[ ] implemented in two browsers

[x] V8 (feature-flagged, on track to ship in Chrome 93 in late august) (PR: https://chromium-review.googlesource.com/c/v8/v8/+/2922117)
[x] SpiderMonkey (feature-flagged) (PR: https://hg.mozilla.org/try/rev/94515f78324e83d4fd84f4b0ab764b34aabe6d80)
[ ] JavaScriptCore (Bug: https://bugs.webkit.org/show_bug.cgi?id=226291)
[x] engine262 (PR: https://github.com/engine262/engine262/pull/163)

[ ] significant in-the-field experience (#18)

[x] SpiderMonkey has had Object.hasOwn enabled in nightly for the last month (as of July 2021) and has not received any bug reports (https://bugzilla.mozilla.org/show_bug.cgi?id=1711872#c8)
[x] v8 says that they are on track to ship Object.hasOwn() in Chrome 93 in late August.

[x] write test262 tests (PR: https://github.com/tc39/test262/pull/2995)
[x] merge test262 tests (PR: https://github.com/tc39/test262/pull/2995)
[x] prepare ecma262 pr (PR: https://github.com/tc39/ecma262/pull/2415)
[x] editor-approved ecma262 pr (Approval: https://github.com/tc39/ecma262/pull/2415#pullrequestreview-669344525)

@leobalter @Felienne ping on reviews. Happy to do whatever I can to help if it's needed ❤

My review for stage 3 advancement:
Normative spec is good! I have nitpicks for editorial. This can be fixed with the PR to ecma-262 and perhaps the current rendered text in this repo can be preserved as is for a better illustration.
The parameters and spec steps values should switch to match consistency with spec. See getOwnPropertyDescriptor for an example.
In this case: Object.hasOwn( O, P ).

Updated!

Spec text LGTM as an editor.

received developer/implementer feedback

Would it be possible for this proposal to get all the implementor feedback it needs during a future TC39 meeting? I assume since hasOwnProperty already exists, that they'd have an easy time saying if this is okay or not.

Would it be possible for this proposal to get all the implementor feedback it needs during a future TC39 meeting?

I imagine preliminary approval can be given here, but we'll still have to wait until web compat results come back. Eg, if anything has already defined Object.hasOwn but done so improperly (eg, didn't make it non-enumerable).

we'll still have to wait until web compat results come back

Is that something that I can start on?

Web compat feedback is only expected within stage 3; the kind of feedback needed for stage 3 is more like "we think we can implement this", which given that it already exists, seems like a given.

I just looked at this together with @codehag and it looks good to me!

Made it to stage 3!

Question: Does SerenityOS's LibJS count as a "browser" for stage 4 requirements? https://github.com/SerenityOS/serenity/commit/3ee092cd0cacb999469e50aa5ff220e397df2d79

@jamiebuilds it counts as an implementation, but no, definitely not a browser

PR for test262 tests is here: https://github.com/tc39/test262/pull/2995

PR for ecma262 spec is here: https://github.com/tc39/ecma262/pull/2415

Implemented in V8! https://chromium-review.googlesource.com/c/v8/v8/+/2922117
Currently behind the flag: --harmony-object-has-own

Implemented in SpiderMonkey! https://bugzilla.mozilla.org/show_bug.cgi?id=1711872
Currently only available in nightly builds
This brings us to two browsers with implementations, so that requirement should now be met for Stage 4

@jamiebuilds requirements are intentionally vague; sometimes it means “two unflagged browsers”, sometimes it means “one unflagged browser and one other”, sometimes it means “two anything”. For anything with web compat risk, it tends to require at least one fully unflagged browser.

@ljharb Is there something that can be done to evaluate web compat risk?
In other news, my company, Rome, has joined TC39 pending Ecma GA approval on June 22-23, so I should hopefully be able to co-champion this into stage 4 by the next meeting

@jamiebuilds there's metrics-gathering that can be done, but that's often more expensive than simply shipping the feature and seeing if it breaks anything.
Basically anything that's API is going to require at least one unflagged browser implementation, altho static properties are safer than prototype properties.

Is there something needed to unblock browsers to ship the feature unflagged or in stable releases? Or will that naturally happen

That'll happen naturally as part of their normal process.

Test262 tests have been merged! https://github.com/tc39/test262/pull/2995

Put together slides for a stage 3 update for the next TC39 meeting: https://docs.google.com/presentation/d/1UbbNOjNB6XpMGo1GGwl0b8lVsNoCPPPLBByPYc7i5IY/edit?usp=sharing

Based on the latest feedback from v8 and SpiderMonkey that they have had Object.hasOwn in nightly for over a month and haven't received any reports about it, and the fact that they both plan to ship the feature unflagged in the next month or so, I'm likely going to seek stage 4 at the next TC39 meeting (I'm assuming it will be sometime after August).

I'm assuming it will be sometime after August

Next meeting is August 31 & September 1 - the next couple meetings are always listed at the bottom of the agenda for a given meeting.

Shipped in v8 9.3 https://v8.dev/blog/v8-release-93

Reached Stage 4!


Lack of a download endpoint

It'd be nice if there was a way to download mod files.

Actually sent an email to the guy who manages the curse widgets, I'll let you know what he says.
I'm doing this now by parsing each mod page but I don't like doing that

I'm doing this now by parsing each mod page but I don't like doing that

Ironically, that's exactly how the widget works. If a Curse employee can't get a decent API for this then I wouldn't hold your breath :P

Yes, forgot to reply. He directly me to the curse widget.
Have a look at this https://github.com/amcoder/Curse.RestProxy

https://github.com/amcoder/Curse.RestProxy/wiki/Curse-Project-Feed

We have no current plans to expand on the API. Our priority is making it easy for authors to upload their mods. We may do so in the future.

I'm using the AddOnService.svc you guys supply. That has been doing everything great.


tuna/utils/merge_db - unused function removal

tuna/utils/merge_db - unused function removal
following lines of code is removed, as they refer to remote machines to collate data from databases.
elif not res:
no_job_merge(master_list, key, vals)
elif len(res) == 1:
single_job_merge(master_list, machine_id, key, vals, res)
elif len(res) > 1:
multi_job_merge(master_list, machine_id, key, vals, res)

@cderb @alexandraBara @JehandadKhan , let me know for review update.

function definitions are removed.


Does not work with matrix3d on parent

When the parent element has a matrix3d transformation on it, everything gets messed up and module is unusable.
Very basic example here:
http://codepen.io/anon/pen/dPWWZB

I am unable to get it working. Changing the "moveElement" to also use matrix3d helps to fix it partly (at least the display issues I have on my chromium) however have no luck with the main issue, the offest. Do not find a way to get the initial-position of the div to attach it properly to the mouse.
Anybody any idea where that value could be? Because I can not find it anywhere.

The offset code is located in the service function ngDraggable:: getPrivOffset

Thanks a lot! That helped and could now fix it. Created a pull-request.


Add PinvokeMarshal implementation for xplat mcg

Previously we moved Pinvoke marshalling support from System.Private.Interop to System.Private.Corelib to support CoreRT x-plat PInvoke and also leave PInvokeMarshal implementation for xplat-mcg as empty(see PInvokeMarshal.cs).  This breaks xplat-mcg scenarios and this change is to bring necessary PInvokeMarshal implementation back.

I thought that we have said that the standalone mcg is just for COM / WinRT. The methods you are adding seems to be for regular PInvoke. Could you please shed some light on the larger picture?

@jkotas ,  For  "the standalone mcg is just for COM / WinRT",  there is a mixed COM and PInvoke scenario which need to use PInvoke Marshalling.
Consider the following mixed scenarios(Pinvoke signature contains COM interface).
[DllImport("MyComDll"]
public extern static void GetCOMInterfaces(string s, out IMyComInterface pComInterface);
// IMyComInterface is a COM interface,
// This is a common code pattern.
The above Pinvoke won't work for .netcore, since its Pinvoke signature contains COM. so x-plat MCG kicks in to solve this problem by generating pinvoke stub --- these MCG generated stub need to use Pinvoke marshalling support.

Ok, I see. Just throwing some ideas:
You can leave marshaling of PInvoke non-COM arguments to the platform marshaler - e.g. generate marshaling stub like this:
static void GetCOMInterfaces(string s, out IMyComInterface pComInterface)
{
    GetCOMInterfaces(string s, out IntPtr pComInterfaceRaw);
    pComInterface = marshal pComInterfaceRaw;
}

Are these COM PInvokes common in the examples that we have seen? Would it be fine to not support them for the standalone x-plat MCG?

These are very common examples, since this is the only way to get first COM interface pointer in .netcore. As we know, .netcore doesn't support COM Activation.
We need to support it.  since this is the only value the standalone x-plat MCG bring to .netcore.
For your code pattern, We need to  update MCG to skip generate marshalling code for non-COM types and generate another Pinvoke signature ( GetCOMInterfaces(string, out IntPtr)).  and also if these COM methods need to support ANSI string(not common), then We still need these marshaling method.

if these COM methods need to support ANSI string(not common), then We still need these marshaling method

Why can't you delegate the ANSI marshaling to the platform PInvoke support?

Of course, We can. but Currently MCG generated code will always call McgMarshal support in System.Private.Interop instead of call Marshal API and these McgMarshal will call into PInvokeMarshal... In future, I would like to update MCG generated code to just call Marshal API but it will take a while to do, also maybe We need to expose more Marshal API.

in future, x-plat MCG should only do work for COM scenario and delegate all Pinvoke related work to .net core

@jkotas, will you take a look the new change again?

Thanks.


Add RichTextBlockFactory

I know there was #25 PR but was super super old, there were too much conflicts to solve :(

Hi @estyxx - are you still up for getting this over the line?
I think we need the following changes:

the factory should take either a string or a RichText object, and always generate a RichText value; and
we should have tests.

Please let me know if you don't have the opportunity to keep working on this.


Added deps_kali.sh Dependency script to support dependencies in Kali …

I added the file deps_kali.sh but only changed line 16 from:
APT_CANDIDATES="git build-essential libqt4-opengl mtd-utils gzip bzip2 tar arj lhasa p7zip p7zip-full cabextract cramfsprogs cramfsswap squashfs-tools zlib1g-dev liblzma-dev liblzo2-dev sleuthkit default-jdk lzop"

to
APT_CANDIDATES="git build-essential libqt4-opengl mtd-utils gzip bzip2 tar arj lhasa p7zip p7zip-full cabextract util-linux firmware-mod-kit cramfsswap squashfs-tools zlib1g-dev liblzma-dev liblzo2-dev sleuthkit default-jdk lzop"

Everything appeared to build correctly.  Adding this script helped me out - I hope it helps others as well!
Perhaps in the future it would be better to combine the two and pass a linux distro to ARGV - for example:
./deps.sh ubuntu

or
./deps.sh kali

@devttys0 could probably close this now that #268 has been merged in


added status.md file

Added my folder and status.md file to share my daily learnings

Welcome @shanmukh9 Good to have you here!! Keep learning and documenting.


Broadcast vectors across rows with plus(A, v).

Fixes #197.  This is the most narrow implementation as described in #197.

Closing in favor of https://github.com/metagraph-dev/grblas/pull/203


Remove Salsa database for 1.2× ~ 2× validation speed

See changelog

I think it definitely can, when used a certain way. But that’s hard to reconcile with using apollo-compiler 1.0’s arbitrarily mutable data structures as input.


Why is there a JVM version and an Android version?

This is somehow confusing since Android is actually a JVM library. There fore "JVM version" should work for Android too.

It works on Android as well, however, if you use Android, you will benefit from Android specific stuff, for example, you call back will run on Main thread automatically.
In short, JVM target usage outside Android context, meanwhile Android aims to support usage under Android development.


Minimize travis pinning and fix Py3.7 builds

As it says on the tin
Fixes #62
Closes #66 as this will supersede it
I have tested this with some personal repos. This correctly builds

@Lnaden My best guess is that Appveyor is building on your account. The MolSSI account cannot see this repo.


[BUG] Self-registration page is tight on mobile, has a lot of white space on desktop

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When a user opens the self-registration link, they are greeted with a either a tight page on mobile or a page with a lot of white space on desktop.

https://user-images.githubusercontent.com/81384847/129088691-1559d1ce-b025-45ff-898d-1e66f8bc7634.mov
Steps To Reproduce
Go

on a mobile and a desktop page
Expected Behavior
N/A - just want to flag to confirm that this is an intentional design
Additional context
No response
Does this issue have a priority label?

[X] I have added a priority label

Has issue been assigned to a team?

[X] I have added a team label

The design team reviewed this ticket and we think the mobile design is fine. It's standard to have minimal margins on mobile devices due to the small screen size.


MM-15403 Fixes highlight for date separators and new messages line on post hover

Collapsing date separator and new messages line to overlap with posts so we can use the hover of posts itself for creating similar effect without adding hover to date separators
Adding new classes based on the next and previous postID if it is a collapsed element. so we can add padding accordingly

@sudheerDev Is this ready for review?

@sudheerDev Is this ready for review?

Nope. I will turn on the dev review label. I am having a discussion with other devs on this.


Logout ??

Where is the option to logout ? I have 2 logins (1 pro, 1 private) so I have to switch, but I'm unable to find "logout" oO

It's not there, we plan to add one eventually.

thx


Two sleep messages from Rest

When a Pokemon uses Rest, the server sends the following messages:
|move|p2a: Giratina|Rest|p2a: Giratina
|-status|p2a: Giratina|slp
|-heal|p2a: Giratina|100/100 slp|[silent]
|-status|p2a: Giratina|slp|[from] move: Rest
It seems that the first message is redundant.

Yes, honestly, server messages are a huge mess right now, which I learned when writing the new message parser.

Do you have a replay link, by any chance?

omo shiroi

https://bitbucket.org/davidstone/technical-machine/issues/attachments/31/davidstone/technical-machine/1554995847.27/31/battle-gen4randombattle-2202.log.json
Turn 9:
||
|move|p1a: Cresselia|Psychic|p2a: Bibarel
|-damage|p2a: Bibarel|3/100
|move|p2a: Bibarel|Rest|p2a: Bibarel
|-status|p2a: Bibarel|slp
|-heal|p2a: Bibarel|100/100 slp|[silent]
|-status|p2a: Bibarel|slp|[from] move: Rest
|-enditem|p2a: Bibarel|Chesto Berry|[eat]
|-curestatus|p2a: Bibarel|slp|[msg]
||

slp in data/*/statuses.js and rest in data/*/moves.js both this.add('-status', 'slp', ...). I've reworked it such that only the status logic is responsible for the message. I'm sure there are other places outside of Rest that send redundant messages though.


Potential race condition causing commits to fail

I don't know Ruby, and I'm not entirely familiar with how everything in this app works, so this is a bit of a shot in the dark.
I will use a simplified version of my current setup to try to describe what I suspect is happening.
I have 3 files, en.pot, es.pot, and fr.pot.

I make a change to en.pot and commit/push directly to master
That updated file is sent to Transifex via Txgh.
es.pot and fr.pot are updated in Transifex to have this new entry
Transifex fires off 2 webhook requests to Txgh, one for es.pot and one for fr.pot, both very close to each other in terms of timing
Txgh creates a new commit for es.pot, using the current base_commit as the parent commit.
At roughly the same time, Txgh creates a new commit for fr.pot, also using this same base_commit as the parent commit.
The first commit is successfully pushed to master, but the 2nd commit fails with the error:

- Update is not a fast forward // See: https://developer.github.com/v3/git/refs/#update-a-reference:

To debug this a bit further, I modified the source code to enable force pushing.  With force pushing turned on, I was able to see a commit from Txgh come through (in our example, it would be es.pot being updated), and then that commit was wiped from the repo's history a moment later when fr.pot was updated, meaning fr.pot was a force push.
I don't know how to fix this behavior (nor am I 100% certain I am right, although I am confident I'm at least on the right path).  The only suggestion off the top of my head is switching to using this much simpler api for updating a file - https://developer.github.com/v3/repos/contents/#update-a-file
Any suggestions on possible work-around for this?

We were able to work around this by adding a sleep to the beginning of the Transifex handler's execute method that increased with each subsequent request.  This allowed us to effectively stagger these requests and avoid a race condition.  Not ideal, but it works for us.
Since the problem has not been solved, but only worked around, I will leave this issue open, in case you want to investigate further and apply a proper fix, if necessary.

@boblauer I agree that both solutions ("forcing" or "sleeping") are likely less than ideal.
My thought is that the async / stateless nature of webhook -> sinatra is actually the root problem.
Another way to solve this would be to add a configuration/mode that only allows one execute to run at a time.  That way this GitHub requests would always be handled sequentially.  However this config would take a bit of work because in addition to making the service a little-bit-stateful, we would also need to queue incoming webhook requests.


(feat. request) read marks from different branch

Hi,
Thanks for this great harpoon fork! I'm not sure how far you want to extend this plugin, but it would seem very handy to me, if one could read existing marks from a different branch (in the same project). This could facilitate switching to a new branch, but keeping the same marks in harpoon-core...
Cheers, Chris

Hi Chris,
Thank you for the interest, I am glad you're liking this fork :)
Sorry for the late response, I've definitely neglected coming back to this repo for some time.
In general my goals with this plugin were more a learning experience for myself and to keep a version of Harpoon around that had the features that I use. Though I personally don't use the branch level marks I tend to only keep marks at a project level and add / remove them as I work on different things.
However I think this feature sounds neat and I agree it could be useful, but I'll need your input on how exactly something like this should work.
What were you thinking in terms of how users would interact with this feature?
Would this be a separate UI you could enter that shows branches, then you go into branches to see the marks in them, where selecting one would then change the branch you are on as well as open the file?
Or would it just be a JSON blob you could dump somewhere with your branches and marks and what you do with that information from there is up to you.
Any and all ideas you have about this kind of a feature are appreciated!

Feel free to re-open if you come back to this, closing for the time being.


docs: fix a few typos

Just some minor typos. Thanks for your work. 😁

@faloi your very welcome. Thank you for your contribution 😇


Feature fix libbpf examples

Adding example to run a sample ebpf program which uses a map and updates a value in the map.

Hi @hp77-creator , is it ready to merge?

Hi @yunwei37 , so I am able to compile the example but when I try to run it using LD_PRELOAD, I am getting following error:
LD_PRELOAD=~/.bpftime/libbpftime-syscall-ser
ver.dylib ./main
fish: Unknown command. './main' exists but is not an executable file.
LD_PRELOAD=~/.bpftime/libbpftime-syscall-server.dylib ./main

I will need to create a userspace program to run it, right?

maybe you need to try something like DYLD_INSERT_LIBRARIES or DYLD_LIBRARY_PATH?
I'm not quite sure about that


After installation from Ubuntu PPA neoman crashes on startup

After installing neoman from the Ubuntu PPA I get the following failure to start:
$ neoman
Traceback (most recent call last):
  File "/usr/local/bin/neoman", line 4, in <module>
    import pkg_resources
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2749, in <module>
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 444, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 725, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 628, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: PySide

These are the pyside related packages that are installed on my system:
dpkg -l | grep pyside
ii  libpyside1.2:i386                                                1.2.1-4build1                                 i386         Python bindings for Qt 4 (base files)
ii  python-pyside                                                    1.2.1-4build1                                 all          Python bindings for Qt4 (big metapackage)
ii  python-pyside.phonon                                             1.2.1-4build1                                 i386         Qt 4 Phonon module - Python bindings
ii  python-pyside.qtcore                                             1.2.1-4build1                                 i386         Qt 4 core module - Python bindings
ii  python-pyside.qtdeclarative                                      1.2.1-4build1                                 i386         Qt 4 Declarative module - Python bindings
ii  python-pyside.qtgui                                              1.2.1-4build1                                 i386         Qt 4 GUI module - Python bindings
ii  python-pyside.qthelp                                             1.2.1-4build1                                 i386         Qt 4 help module - Python bindings
ii  python-pyside.qtnetwork                                          1.2.1-4build1                                 i386         Qt 4 network module - Python bindings
ii  python-pyside.qtopengl                                           1.2.1-4build1                                 i386         Qt 4 OpenGL module - Python bindings
ii  python-pyside.qtscript                                           1.2.1-4build1                                 i386         Qt 4 script module - Python bindings
ii  python-pyside.qtsql                                              1.2.1-4build1                                 i386         Qt 4 SQL module - Python bindings
ii  python-pyside.qtsvg                                              1.2.1-4build1                                 i386         Qt 4 SVG module - Python bindings
ii  python-pyside.qttest                                             1.2.1-4build1                                 i386         Qt 4 test module - Python bindings
ii  python-pyside.qtuitools                                          1.2.1-4build1                                 i386         Qt 4 UI tools module - Python bindings
ii  python-pyside.qtwebkit                                           1.2.1-4build1                                 i386         Qt 4 WebKit module - Python bindings
ii  python-pyside.qtxml                                              1.2.1-4build1                                 i386         Qt 4 XML module - Python bindings

Looks like you're on Ubuntu 15.04 ("Vivid Vervet"); is that correct?

Yes

If you installed from the PPA the neoman binary shouldn't be in /usr/local/bin, it should be in /usr/bin. I suspect you have a (partial?) manual installation in /usr/local/bin, perhaps from pip, which is unable to see your PySide installation. Try removing the installation in /usr/local/bin.

Yes that might have been it. I had started an install from source previously before I found the PPA, which I cancelled once I found it. Turns out that removing an installation from setup.py is quite dirty though:
python setup.py install --record files.txt
cat files.txt | xargs rm


Unable to refresh analysis services using service principal

Hi @Minewiskan @craigcaseyMSFT @v-alje @changeworld @CelesteDG ,
I was following the article - Asynchronous refresh with the REST API. The sample doesnt seem to work for OAUTH 2.0 as the Authorisation link seems to be wrong.
I have tried modifying the authority string to "https://login.microsoftonline.com//oauth2/v2.0/authorize" but still it gives me an error  - "Tenant 'authorize' not found. This may happen if there are no active subscriptions for the tenant. Check with your subscription administrator."
Any help in providing the sample with the new OAUTH 2.0 implementation would be helpful.
Also, I am trying to trigger a AAS model refresh from Azure Data factory using the WEB task within ADF. Can you suggest whether this is feasible and whether it is a good way to implement  Tabular model refresh?
Regards,
Sasi.

@sasi-thonangi-img Thanks for your comment. We are actively investigating and will get back to you shortly.

@sasi-thonangi-img  I would recommend you to create a thread on the forums - Azure Analysis Services.
Once you post your issue on forums, it will have visibility across the community which is a better-suited audience for such types of issues.
Please create a Forum thread and post its link here and tag me. I will now proceed to close this issue. Feel free to comment if you have any other queries.


Error: Failed fetching inputs: org.opensearch.OpenSearchSecurityException: no permissions for [indices:data/read/search] and associated roles[BUG]

When deploying an alert and the monitor is triggered, the following error is seen: Error: Failed fetching inputs: org.opensearch.OpenSearchSecurityException: no permissions for [indices:data/read/search] and associated roles
The alert then goes into an error state and cannot be acknowledged.

Seems like this is an issue with alerting based on the description

Role:
Allows users to use all alerting functionality
alerting_full_access:
  reserved: true
  cluster_permissions:
  - "*"
  index_permissions:
  - index_patterns:
    - ".opendistro-alerting-config"
    - ".opendistro-alerting-alert*"
    - "sol.equipment.availability"
    allowed_actions:
    - crud
    - search
    - data_access

Role Mapping:
alerting_full_access:
reserved: false
users:
- "admin"
backend_roles:
- "ROLE_SM_ADMIN"
- "ROLE_SM_KIBANA_ADMIN"
- "admin"

Any feedback on this?

Hi @ARud12 , can you please check if the backend roles have permissions to the index
https://opensearch.org/docs/latest/monitoring-plugins/alerting/security/#advanced-limit-access-by-backend-role

roles.yml: |
_meta:
type: "roles"
config_version: 2
# Restrict users so they can only view visualization and dashboard on kibana
kibana_read_only:
  reserved: true

# The security REST API access role is used to assign specific users access to change the security settings through the REST API.
security_rest_api_access:
  reserved: true

# Allows users to view alerts
alerting_view_alerts:
  reserved: true
  index_permissions:
    - index_patterns:
      - ".opendistro-alerting-alert*"
      allowed_actions:
        - read

# Allows users to view and acknowledge alerts
alerting_crud_alerts:
  reserved: true
  index_permissions:
    - index_patterns:
      - ".opendistro-alerting-alert*"
      allowed_actions:
       - crud

# Allows users to use all alerting functionality
alerting_full_access:
  reserved: true
  cluster_permissions:
  - "*"
  index_permissions:
  - index_patterns:
    - ".opendistro-alerting-config"
    - ".opendistro-alerting-alert*"
    - "sol.equipment.availability"
    allowed_actions:
    - crud
    - search
    - read
    - data_access

reports_full_access:
  reserved: true
  index_permissions:
  - index_patterns:
    - ".opendistro-reports-*"
    allowed_actions:
    - crud

ROLE_SM_ADMIN:
  reserved: true

ROLE_SM_KIBANA_ADMIN:
  reserved: false
  cluster_permissions:
  - "*"
  index_permissions:
  - index_patterns:
    - "*"
    allowed_actions:
    - "crud"
    - "manage"
    - "data_access"
    - "search"
  tenant_permissions:
  - tenant_patterns:
    - "Admin"
    allowed_actions:
    - "kibana_all_write"

ROLE_SM_KIBANA_VIEWER:
  reserved: false
  hidden: false
  cluster_permissions:
  - "cluster_composite_ops"
  - "indices_monitor"
  index_permissions:
  - index_patterns:
    - "*"
    allowed_actions:
      - read
      - search

roles_mapping.yml: |
---
# In this file users, backendroles and hosts can be mapped to OpenSearch Security roles.
# Permissions for OpenSearch roles are configured in roles.yml
_meta:
  type: "rolesmapping"
  config_version: 2

# Define your roles mapping here

all_access:
  reserved: false
  users:
  - "kibanaserver"
  - "admin"
  backend_roles:
  - "admin"
  - "ROLE_SM_ADMIN"
  description: "Maps admin to all_access"

own_index:
  reserved: false
  users:
  - "*"
  description: "Allow full access to an index named like the username"

readall:
  reserved: false
  backend_roles:
  - "readall"

alerting_full_access:
  reserved: false
  users:
  - "admin"
  backend_roles:
  - "ROLE_SM_ADMIN"
  - "ROLE_SM_KIBANA_ADMIN"
  - "admin"

reports_full_access:
  reserved: false
  users:
  - "admin"
  backend_roles:
  - "ROLE_SM_ADMIN"
  - "ROLE_SM_KIBANA_ADMIN"
  - "admin"

alerting_crud_alerts:
  reserved: false
  backend_roles:
  - "ROLE_SM_KIBANA_VIEWER"

ROLE_SM_ADMIN:
  reserved: false
  backend_roles:
  - "admin"
  - "ROLE_SM_ADMIN"

ROLE_SM_KIBANA_ADMIN:
  reserved: false
  backend_roles:
  - "ROLE_SM_KIBANA_ADMIN"

ROLE_SM_KIBANA_VIEWER:
  reserved: false
  backend_roles:
  - "ROLE_SM_KIBANA_VIEWER"

tenants.yml: |
---
_meta:
type: "tenants"
config_version: 2
# Define your tenants here

Admin:
  reserved: false
  description: "Tenant for admin users"

internal_users.yml: |
---
# This is the internal user database
# The hash value is a bcrypt hash and can be generated with plugins/opendistro-security/tools/hash.sh
_meta:
  type: "internalusers"
  config_version: 2

# Define your internal users here

admin:
  hash: "$2a$12$VcCDgh2NDk07JGN0rjGbM.Ad41qVR/YFJcgHp0UGns5JDymv..TOG"
  reserved: true
  backend_roles:
  - "admin"
  description: "Default 'admin' user"

kibanaserver:
  hash: "$2a$12$4AcgAt3xwOWadA5s5blL6ev39OXDNhmOesEoo33eZtrq2N0YrU3H."
  reserved: true
  backend_roles:
  - "admin"
  description: "Default 'kibanaserver' user"

The backend roles have "*" for cluster as well as index patterns

Any feedback on the attached roles and mapping?

A quick way to check this is to update the monitor as an admin user as they have full permissions access.

I tested the alerts by creating the alert with the admin user and is still seeing the issue

@ARud12, can you use the admin user listed in the internal_users.yml file? If that doesn't work still, can you post the monitor query and also try execute that query directly against the index in dev-tools? It would be something like:
POST <index>/_search {<query>}

I did test with the admin user in the internal_users.yml and is still getting the error. When doing POST /_search {} I get the following error:
{
"error" : {
"root_cause" : [
{
"type" : "json_parse_exception",
"reason" : "Unrecognized token 'POST': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\n at [Source: (org.opensearch.common.io.stream.InputStreamStreamInput); line: 1, column: 6]"
}
],
"type" : "json_parse_exception",
"reason" : "Unrecognized token 'POST': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\n at [Source: (org.opensearch.common.io.stream.InputStreamStreamInput); line: 1, column: 6]"
},
"status" : 400
}

Similar issue: https://github.com/opensearch-project/security-dashboards-plugin/issues/734

Did the following query: GET _plugins/_security/api/account
Delivered the following result:
{
"user_name" : "admin",
"is_reserved" : true,
"is_hidden" : false,
"is_internal_user" : true,
"user_requested_tenant" : "Admin",
"backend_roles" : [
"ROLE_SM_WORKFLOW_ADMIN",
"ROLE_SM_ADMIN",
"ROLE_SM_UHF2_ADMIN",
"ROLE_SM_KIBANA_ADMIN",
"ROLE_(GET|OPTIONS)http://edge.staging.local:32111/workflow*",
"ROLE_SM_CONFIG_ADMIN",
"ROLE_GEThttp://edge.staging.local:32111/opensearch*",
"ROLE_(GET|POST|PUT|DELETE|OPTIONS)http://edge.staging.local:32111/workflow*",
"ROLE_GEThttp://edge.staging.local:32111/config*",
"ROLE_ROLE_SM_KIBANA_ADMIN",
"ROLE_(GET|POST|PUT|DELETE|PATCH)http://edge.staging.local:32111/opensearch*",
"ROLE_(GET|POST|PUT|DELETE)http://edge.staging.local:32111/config*"
],
"custom_attribute_names" : [
"attr.jwt.user_name",
"attr.jwt.authorities",
"attr.jwt.tenant",
"attr.jwt.scope",
"attr.jwt.client_id",
"attr.jwt.exp",
"attr.jwt.jti"
],
"tenants" : {
"admin" : true,
"global_tenant" : true,
"Admin" : true
},
"roles" : [
"ROLE_SM_ADMIN",
"ROLE_SM_KIBANA_ADMIN",
"reports_full_access",
"own_index",
"alerting_full_access",
"all_access"
]
}

I tested the alerts by creating the alert with the admin user (in the Admin tenant space) and is still seeing the issue.

Along with @lezzago's suggestion, just to clarify @ARud12, when you say you "created the alert with the admin user", you do mean the Monitor was created/edited and then the conditions were met for the Alert to be created/updated correct?

I created the monitor with the admin user (in Admin tenant space) - the monitor was then triggered and the alert is then created but it is in an error state due to the security exception.

GET _plugins/alerting/monitors/0_T0W4QBLujM11LHolE:
{
"id" : "0_T0W4QBLujM11LHolE",
"_version" : 2,
"_seq_no" : 13,
"_primary_term" : 2,
"monitor" : {
"type" : "monitor",
"schema_version" : 4,
"name" : "gate-availability-alert",
"monitor_type" : "query_level_monitor",
"enabled" : true,
"enabled_time" :<PHONE_NUMBER>807,
"schedule" : {
"period" : {
"interval" : 1,
"unit" : "MINUTES"
}
},
"inputs" : [
{
"search" : {
"indices" : [
"sol.equipment.availability"
],
"query" : {
"query" : {
"constant_score" : {
"filter" : {
"bool" : {
"must" : [
{
"range" : {
"timestamp" : {
"from" : "{{period_end}}||-5m",
"to" : "{{period_end}}",
"include_lower" : true,
"include_upper" : true,
"boost" : 1.0
}
}
},
{
"match" : {
"type.keyword" : {
"query" : "equipment-state",
"operator" : "OR",
"prefix_length" : 0,
"max_expansions" : 50,
"fuzzy_transpositions" : true,
"lenient" : false,
"zero_terms_query" : "NONE",
"auto_generate_synonyms_phrase_query" : true,
"boost" : 1.0
}
}
}
],
"adjust_pure_negative" : true,
"boost" : 1.0
}
},
"boost" : 1.0
}
}
}
}
}
],
"triggers" : [
{
"query_level_trigger" : {
"id" : "0fT0W4QBLujM11LHolEv",
"name" : "gate-availability-trigger",
"severity" : "1",
"condition" : {
"script" : {
"source" : "ctx.results[0].hits.total.value > 0",
"lang" : "painless"
}
},
"actions" : [
{
"id" : "0vT0W4QBLujM11LHolEv",
"name" : "gate-availability-action",
"destination_id" : "0PT0W4QBLujM11LHoVHu",
"message_template" : {
"source" : """To<EMAIL_ADDRESS>Subject: Gate Availability Status Update
Gate availability status changed.
Start: {{ctx.periodStart}}
End: {{ctx.periodEnd}}
Monitor: {{ctx.monitor.name}}
Trigger: {{ctx.trigger.name}}
Severity: {{ctx.trigger.severity}}
""",
"lang" : "mustache"
},
"throttle_enabled" : true,
"subject_template" : {
"source" : "",
"lang" : "mustache"
},
"throttle" : {
"value" : 10,
"unit" : "MINUTES"
}
}
]
}
}
],
"last_update_time" :<PHONE_NUMBER>726
}
}

The Alerting plugin does not use tenants so the behavior is the same regardless of the tenant space.
Also can you rerun the query directly in the dev tools to see if the monitor query works? Also please paste that output here and please obfuscate any sensitive data. Additionally, change the from and to of the timerange to real values instead of {{period_end}}.
Based on the monitor definition, you should run:
GET sol.equipment.availability/_search
"query": {
    "constant_score": {
        "filter": {
            "bool": {
                "must": [{
                        "range": {
                            "timestamp": {
                                "from": "{{period_end}}||-5m",
                                "to": "{{period_end}}",
                                "include_lower": true,
                                "include_upper": true,
                                "boost": 1.0
                            }
                        }
                    },
                    {
                        "match": {
                            "type.keyword": {
                                "query": "equipment-state",
                                "operator": "OR",
                                "prefix_length": 0,
                                "max_expansions": 50,
                                "fuzzy_transpositions": true,
                                "lenient": false,
                                "zero_terms_query": "NONE",
                                "auto_generate_synonyms_phrase_query": true,
                                "boost": 1.0
                            }
                        }
                    }
                ],
                "adjust_pure_negative": true,
                "boost": 1.0
            }
        },
        "boost": 1.0
    }
}

The above query returns the following:  (Query is working fine)
{
"took" : 2,
"timed_out" : false,
"_shards" : {
"total" : 1,
"successful" : 1,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : {
"value" : 10,
"relation" : "eq"
},
"max_score" : 1.0,
"hits" : [
{
"_index" : "sol.equipment.availability",
"_type" : "equipment-state",
"_id" : "Hgt6W4QBrm55oUyyUeHb",
"_score" : 1.0,
"_source" : {
"device" : "",
"indextime" : "2022-11-09T08:20:53.353Z",
"timestamp" : "2022-11-09T08:20:53.353Z",
"type" : "equipment-state",
"topic" : "sol.equipment.availability",
"partition" : "0",
"@timestamp" : "2022-11-09T08:20:53.353Z",
"devicetype" : "gate",
"@version" : "1",
"state" : "Operational",
"offset" : "181"
}

Can you call this and get the output here? To also access system indices, follow this.
GET .opendistro-alerting-config/_search
{
  "query": {
    "match_all": {}
  }
}

I want to try see what roles are associated to the monitor itself.
Also this setting ("plugins.alerting.filter_by_backend_roles") is enabled, correct?

GET .opendistro-alerting-config/_search
{
"query": {
"match_all": {}
}
}
Delivers the following result:
{
"took" : 5,
"timed_out" : false,
"_shards" : {
"total" : 1,
"successful" : 1,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : {
"value" : 0,
"relation" : "eq"
},
"max_score" : null,
"hits" : [ ]
}
}

"plugins.alerting.filter_by_backend_roles" = true and version 1.3.2

Can it be problem if I run opensearch 1.3.2 but opensearch dashboards 1.3.1?

Attached is my alert.json - is it neccessary for the user part?
{
"type": "monitor",
"name": "gate-availability-alert",
"enabled": true,
"schedule": { "period": {
"unit": "MINUTES",
"interval": 5
}},
"inputs": [{ "search": {
"indices": ["sol.equipment.availability"],
"query": { "query": {
"constant_score": { "filter": {
"bool" : { "must" : [
{ "range" : { "timestamp" : { "gte": "now-10m", "lte": "now" }}},
{ "match" : { "state.keyword" : "Not connected" }}
]}
}}
}}
}}],
"triggers": [{
"name": "gate-availability-trigger",
"severity": "1",
"condition": { "script": {
"source": "ctx.results[0].hits.total.value > 0",
"lang": "painless"
}},
"actions": [{
"name": "gate-availability-action",
"destination_id": "email-webhook",
"message_template": {
"source": "To<EMAIL_ADDRESS>Gate Availability Status Update\nGate availability status changed.\nStart: {{ctx.periodStart}}\nEnd: {{ctx.periodEnd}}\nMonitor: {{ctx.monitor.name}}\nTrigger: {{ctx.trigger.name}}\nSeverity: {{ctx.trigger.severity}}\n",
"lang": "mustache"
},
"subject_template": {
"source": "",
"lang": "mustache"
},
"throttle_enabled": true,
"throttle": {
"unit": "MINUTES",
"value": 10
}
}]
}],
"user": {
"backend_roles": [],
"custom_attribute_names": [],
"roles": [],
"name": "",
"user_requested_tenant": null
}
}

Any feedback on this?

Any feedback on this?

Can it be problem if I run opensearch 1.3.2 but opensearch dashboards 1.3.1?

There should be no issue because of this.

I set "plugins.alerting.filter_by_backend_roles" = true now but cannot see the alerts anymore (created alert with admin and cannot see alert under admin user)? and version 1.3.2

Set it back to false. That is to have additional filtering that is explained here

Have you tried to replicate this issue on a new temporary cluster?
Also do you see the same error as admin, when you call the execute monitor API? Additionally, are you able to see any information in the Preview query and performance section when editing the monitor?

I set "plugins.alerting.filter_by_backend_roles" = true now but cannot see the alerts anymore (created alert with admin and cannot see alert under admin user)? and version 1.3.2

As this setting was not configured properly while alert was actually created and now after setting it you can't see alert this tells me that maybe user was not properly set for alert at first place. Can you try to create same alert now after you configured plugins.alerting.filter_by_backend_roles and see if it works?

@ARud12, are you still seeing the issue? And have you replicated it in a new cluster?

@lezzago I am still experiencing this issue. Are there any explicit security changes to opensearch dashboards alerts? Because I am not seeing this error when I am executing this alert, only seeing it in opensearch dashboards so I am trying to figure out what changed between kibana and opensearch in terms of the alerting plugin and the security settings. I am using the same security configuration for kibana as I am using for opensearch dashboards but is not seeing this problem on kibana.

@lezzago @partlov Any feedback on this?

@lezzago @partlov Any feedback on this?

@lezzago @partlov Any feedback on this?

@ARud12, can you clarify how you are running this on Kibana since you are using OpenSearch 1.3.2? Was this cluster upgraded from a ODFE cluster?
Also do you see the same error as admin, when you call the execute monitor API? Additionally, are you able to see any information in the Preview query and performance section when editing the monitor?
Additionally, have you tried to replicate this on a new cluster?

@lezzago I am still experiencing this issue. Are there any explicit security changes to opensearch dashboards alerts? Because I am not seeing this error when I am executing this alert in kibana, only seeing it in opensearch dashboards so I am trying to figure out what changed between kibana and opensearch in terms of the alerting plugin and the security settings. I am using the same security configuration for kibana as I am using for opensearch dashboards but is not seeing this problem on kibana.
The security model from ODFE 1.13 to OpenSearch did not change for the alerting plugin

GET .opendistro-alerting-config/_search { "query": { "match_all": {} } }
Delivers the following result:
{ "took" : 5, "timed_out" : false, "_shards" : { "total" : 1, "successful" : 1, "skipped" : 0, "failed" : 0 }, "hits" : { "total" : { "value" : 0, "relation" : "eq" }, "max_score" : null, "hits" : [ ] } }

Did you follow this documentation to call the index correctly? This method is needed as its a system index and without it, you would get no data. I want to see the user roles being associated to the monitor.
https://opensearch.org/docs/1.3/security/configuration/system-indexes/

For the alerting_full_access role, can you add these allowed actions to it?
"indices_monitor",
"indices:admin/aliases/get",
"indices:admin/mappings/get"

This is based on the alerting_full_access default permissions: https://github.com/opensearch-project/security/blob/main/config/roles.yml#L30


Jenkins: Utilize jabba to select jdks used in tests

Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

do you think it worth defining jdk versions in env variables
pipeline {
    environment {
        JDK_12=...
...

and accessing it in stages?


focal manipulator RGB menu GUI scale issue

The RGB menu doesn't scale correctly with other GUI scales expect auto for example using GUI scale large the box completely covers the focus slot and interferes with other parts of the menu

fixed in one of the new versions btw @Zokonius close this too

I'm still getting this in 1.4.0-pre4