A Personal Access Token is not actually required. A GITHUB_TOKEN will work

Hey,
First of all, thank you for making this Action, it's really helpful.
I wanted to point out that your readme says using a GITHUB_TOKEN will not work when in fact it can.
I had been struggling for days to figure out how to create an action that would auto-merge pull request from approved bots (or any approved user) to a protected branch after passing checks, but would NOT approve requests from just anybody. The question of how to auto-merge dependabot pull requests is a popular one. I ended up pulling it off with this workflow (Which as you can see does not use a PAT):
name: automerge
on:
  pull_request_target:
jobs:
  automerge:
    runs-on: ubuntu-latest
    env:
      # append additional users below to allow automerge for them
      USER_ALLOWLIST: |
        '[
          "${{github.repository_owner}}",
          "dependabot[bot]"
        ]'
    steps:

      - name: print troubleshooting info
        run: |
          echo "event name:" ${{github.event_name}}
          echo "event action:" ${{github.event.action}}
          echo "actor:" ${{github.actor}}
          echo "repository owner:" ${{github.repository_owner}}
          echo "pull request user:" ${{github.event.pull_request.user.login}}
          echo "pull request number:" ${{github.event.pull_request.number}}
          echo "allow list:" ${{ env.USER_ALLOWLIST }}
          echo "actor approved?": ${{contains(fromJSON(env.USER_ALLOWLIST), github.actor)}}
          echo "pull request user approved?": ${{contains(fromJSON(env.USER_ALLOWLIST), github.event.pull_request.user.login)}}

      - name: automerge
        if: >-
          ${{
            contains(fromJSON(env.USER_ALLOWLIST), github.actor) &&
            contains(fromJSON(env.USER_ALLOWLIST), github.event.pull_request.user.login)
          }}
        uses: peter-evans/enable-pull-request-automerge@v2
        with:
          token: ${{secrets.GITHUB_TOKEN}}
          pull-request-number: ${{github.event.pull_request.number}}
          merge-method: squash

The trick here is to use the "pull_request_target" event instead of the "pull_request" event. The GITHUB_TOKEN from a pull_request event does not have the required permissions because it runs in the security context of the requestor. On the other hand, the pull_request_target event is identical to the pull_request event in every way except that the GITHUB_TOKEN runs in the security context of the "target" (the approver).
Obviously then pull_request_target can be dangerous because it can allow anyone from the general public full write access to the repo by combining it with enable-pull-request-automerge. You can see that my approach to secure the workflow above is to build an allow list.
Anyway, I just wanted to share this with you because I was pretty excited to finally get it working and not having to use PAT. Feel free to share my workflow above as an example in your readme. I suspect a lot of people who are looking for a way to automerge dependabot and other bots wind up here.

Hi @grintor
Thank you for sharing this workflow. I'm aware of pull_request_target being a workaround for needing a PAT, but was a bit hesitant to suggest this because it can be misused and potentially dangerous. However, it does look like you have made it safe with the USER_ALLOWLIST. I still would recommend people use a PAT, but I'm sure some users would prefer this solution.
When I have some time I'll test this out and likely add it to the readme. For now I'll leave this issue open for people to find. Thanks!

Thanks @peter-evans,
I did fine one caveat in doing it this way though. Since events triggered by the GITHUB_TOKEN will not create a new workflow run, you cannot have any workflows that are triggered by the merge event created by this workflow.
So for example, if you have some CD workflow meant to deploy the main branch upon a new merge, that workflow will not be triggered when using a GITHUB_TOKEN here. That may or may not affect a given repository, but it's good to be aware of for when it does. I was scratching my head for quite a while trying to figure out why another workflow wasn't running on my main branch merges.

 I expect most use cases will have a workflow that runs on push to the main branch.

I had time to test auto-merging dependabot PRs. I've added an example in the readme.
https://github.com/peter-evans/enable-pull-request-automerge#dependabot-example
The conclusion is the same, you can use GITHUB_TOKEN but the merge won't trigger further workflow runs. Use a PAT if that is necessary.


Wrong permission of config.php

/var/www/html/moodle/config.php has wrong permissions:
root@moodle:/var/www/html/moodle# ls -la
[...]
-rwxr-xr-x  1 www-data www-data  56947 May  6  2022 config-dist.php
-rw-r-----  1 root     root        736 Jan 24 21:02 config.php
drwxr-xr-x  7 www-data www-data     13 May  6  2022 contentbank
[...]

/var/log/apache2/error.log:
[Tue Jan 24 22:04:50.365637 2023] [php:warn] [pid 229] [client <IP_ADDRESS>:39360] PHP Warning:  require_once(/var/www/html/moodle/config.php): Failed to open stream: Permission denied in /var/www/html/moodle/index.php on line 30
[Tue Jan 24 22:04:50.365863 2023] [php:error] [pid 229] [client <IP_ADDRESS>:39360] PHP Fatal error:  Uncaught Error: Failed opening required 'config.php' (include_path='.:/usr/share/php') in /var/www/html/moodle/index.php:30\nStack trace:\n#0 {main}\n  thrown in /var/www/html/moodle/index.php on line 30

playbook:
- import_playbook: .ansible/roles/robertdebock.moodle/molecule/default/prepare.yml
  when: '"moodle" in inventory_hostname'

- hosts: moodle
  tasks:
  - include_role: { name: robertdebock.moodle }

requirements.yml:
[...]
- src: robertdebock.moodle                                        # for moodle
- src: robertdebock.bootstrap                                     # for moodle
- src: robertdebock.buildtools                                    # for moodle
- src: robertdebock.epel                                          # for moodle
- src: robertdebock.mysql                                         # for moodle
- src: robertdebock.python_pip                                    # for moodle
- src: robertdebock.openssl                                       # for moodle
- src: robertdebock.php                                           # for moodle
- src: robertdebock.selinux                                       # for moodle
- src: robertdebock.httpd                                         # for moodle
- src: robertdebock.cron                                          # for moodle
- src: robertdebock.core_dependencies                             # for moodle
[...]

OS: Ubuntu 22.04 (lxc container), latest version of this role as of writing this bug report
When permissions are fixed, this no longer persists as an issue.

Thanks! I'll keep an eye on CI tests.


socket_wrapper: 1.2.5 -> 1.3.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/socket_wrapper/versions.
meta.description for socket_wrapper is: "A library passing all socket communications through unix sockets"
meta.homepage for socket_wrapper is: "https://git.samba.org/?p=socket_wrapper.git;a=summary;"
meta.changelog for socket_wrapper is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.3.3 with grep in /nix/store/mmvgprws6gm2lnb7yxrzwljlwp09n021-socket_wrapper-1.3.3

found 1.3.3 in filename of file in /nix/store/mmvgprws6gm2lnb7yxrzwljlwp09n021-socket_wrapper-1.3.3

directory tree listing: https://gist.github.com/b8ee0d79410d940d3cf5ae959a0b0948

du listing: https://gist.github.com/b0c1cf6d63cbbce11c0db0044df06351

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
socket_wrapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mmvgprws6gm2lnb7yxrzwljlwp09n021-socket_wrapper-1.3.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A socket_wrapper https://github.com/r-ryantm/nixpkgs/archive/2ada84ac2fccd8bc57b3e1be712b6f621ace1b8a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mmvgprws6gm2lnb7yxrzwljlwp09n021-socket_wrapper-1.3.3
ls -la /nix/store/mmvgprws6gm2lnb7yxrzwljlwp09n021-socket_wrapper-1.3.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

socket_wrapper

Maintainer pings

Result of nixpkgs-review pr 137755 at 2ada84ac run on aarch64-linux 1

1 package built successfully:

socket_wrapper

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/socket_wrapper/default.nix:13:3:
   |
13 |   meta = with lib; {
   |   ^


Fix flaky UT

Why we need this PR
improve pipeline stability for shorter dev cycles
Changes made
There was a race condition in the test where in some case the daemonset was created twice, it was fixed to make sure it will only happen once.
Which issue(s) this PR fixes

Test plan

Giving a chance to get more reviews
/hold

createDsBeforeConfig should not be needed. It should be sufficient to define order of code execution by level of nesting of BeforeEach and JustBeforeEach

That's a nice idea, but the inner JustBeforeEach  that belongs to the particular test in which I want to create the DS before the config runs after the outer JustBeforeEach which is shared with multiple tests so I'm not sure how to do it.

I don't see the value of isSkipCleanup.

In the cleanup process we verify that the delete was successful, we can't do it if no resources were created.

And directly related, what's the value of AfterEach checking the existence of the resources, before deleting them?

At that stage I know the resources  were set up to be created but since the creation is async we need to verify they were created, otherwise we run into the risk of resources being created after the delete was executed.

Did you try to just add the verify delete is done part to the old DeferCleanup()? That should ensure that no ds exists when the operator update tests run...

It's possible to run the AfterEach code in DeferCleanup, in this case I preferred using an "AfterEach" block because I think it has slightly better readability,  DeferCleanup creates another nesting and adds a bit of complication to the BeforeEach so I prefer to use it with a relative short cleanup code.
It's definitely  something I consider very minor so DeferCleanup is fine by me as well.

createDsBeforeConfig should not be needed. It should be sufficient to define order of code execution by level of nesting of BeforeEach and JustBeforeEach

That's a nice idea, but the inner JustBeforeEach that belongs to the particular test in which I want to create the DS before the config runs after the outer JustBeforeEach which is shared with multiple tests so I'm not sure how to do it.

ooohhhh.... that's a very fair point, I remembered it the wrong around. However, that made me wonder how the test ever succeeds! And revisiting the code, the problem isn't that we run into a race condition which fails the test sometimes, the problem is that it's coincidence that the test succeeds most times! Let me explain:

the outer JustBeforeEach creates the config
reconciling the config triggers ds creation
this competes with the ds creation of the inner JustBeforeEach

This can easily be demonstrated: just add a one second sleep at the end of the outer JustBeforeEach, that gives the config reconcile time to always create the ds before the inner JustBeforeEach creates the ds. The test always fails now.
Solution: make the code which is in the inner JustBeforeEach a function, and call it in the inner BeforeEach of both tests. That way the "inner" ds is always created before the one created by the "outer" config reconcile :)

In the cleanup process we verify that the delete was successful, we can't do it if no resources were created.

I don't see a need for this. Cleanup should ensure that resources don't exist after cleanup, no matter if they exist before. So you can just ignore DoesNotExist errors (don't remember the exact name). Let's keep it simple :)

At that stage I know the resources were set up to be created but since the creation is async we need to verify they were created

fair point, such verification should happen in test setup or execution though, not cleanup IMHO.

It's possible to run the AfterEach code in DeferCleanup, in this case I preferred using an "AfterEach" block because I think it has slightly better readability

I don't have a strong preference here as well. For more complex cleanup AfterEach() is probably easier to read, for just deleting a resource it's nice to have the cleanup code right after the creation code IMHO. However, my point here was that you added something valuable. And that could have been added to the existing DeferCleanUp(), in contrast to the bigger refactoring :)

the problem isn't that we run into a race condition which fails the test sometimes, the problem is that it's coincidence that the test succeeds most times!

Not splitting hair about the terminology, since I assume we mean the same thing here.
We can probably agree that there is an issue with timing.

just add a one second sleep

I'm not a fan of adding a fixed sleep to solve timing issues (not to say I never do it, but I try to avoid doing so).
I think it's harder to maintain and very dependent on system performance (which may vary) and it'll also cause a delay in all the rest of the tests.

Solution: make the code which is in the inner JustBeforeEach a function, and call it in the inner BeforeEach of both tests. That way the "inner" ds is always created before the one created by the "outer" config reconcile :)

I'm having a hard time to follow, IIUC the inner JustBeforeEach code Just verifies the ds is created, so it can't run before (i.e as part of a BeforeEach block) the outer JustBeforeEach code creates the config/ds.
Maybe you can give an example with a code snippet ?

I don't see a need for this. Cleanup should ensure that resources don't exist after cleanup, no matter if they exist before. So you can just ignore DoesNotExist errors (don't remember the exact name). Let's keep it simple :)

I think there is value for checking because we verify that the test is going as expected which means we'll catch errors earlier and improve maintainability, I do agree though that there is a trade-off  with readability.
Another reason is: that in case we are agnostic in the cleanup phase to whether resources were created or not, we risk the resources being created after we've already assumed we've deleted them in the cleanup.

And that could have been added to the existing DeferCleanUp()

The exiting DeferCleanUp() was located in a more nested JustBeforeEach block so it excluded some tests which are now part of the cleanup.

the problem isn't that we run into a race condition which fails the test sometimes, the problem is that it's coincidence that the test succeeds most times!

Not splitting hair about the terminology, since I assume we mean the same thing here. We can probably agree that there is an issue with timing.

sure, my point just is that the problem is more that it succeeds most times, not that it fails sometimes. The failure exposes a serious issue in the test setup

just add a one second sleep

I'm not a fan of adding a fixed sleep to solve timing issues (not to say I never do it, but I try to avoid doing so). I think it's harder to maintain and very dependent on system performance (which may vary) and it'll also cause a delay in all the rest of the tests.

as written, it can demonstrate the actual issue. I didn't want to propose adding a timeout permanently (it makes the test always fail). The proposal was to add the sleep on your machine so you can reproduce the issue always, and not just sometimes

Solution: make the code which is in the inner JustBeforeEach a function, and call it in the inner BeforeEach of both tests. That way the "inner" ds is always created before the one created by the "outer" config reconcile :)

I'm having a hard time to follow, IIUC the inner JustBeforeEach code Just verifies the ds is created, so it can't run before (i.e as part of a BeforeEach block) the outer JustBeforeEach code creates the config/ds. Maybe you can give an example with a code snippet ?

I was explaining the issue we have in the current test code, not in the PR code. When you look at the current code, my explanation of the issue should make sense, does it?

I don't see a need for this. Cleanup should ensure that resources don't exist after cleanup, no matter if they exist before. So you can just ignore DoesNotExist errors (don't remember the exact name). Let's keep it simple :)

I think there is value for checking because we verify that the test is going as expected which means we'll catch errors earlier and improve maintainability, I do agree though that there is a trade-off with readability.

sure, but verifying "that the test is going as expected" is very clearly a task for test setup ((Just)BeforeEach()) or execution (It()), not cleanup ((Just)AfterEach())!

Another reason is: that in case we are agnostic in the cleanup phase to whether resources were created or not, we risk the resources being created after we've already assumed we've deleted them in the cleanup.

On one hand: as stated above, the test setup or test execution should verify that resources we expect to be created are created already.
On the other hand you have a point indeed in this specific case: if we test the config only and don't care about ds, we might miss cleanup of the ds in case the test finishes faster than the ds is created. However, IMHO a Consistently with 1s for the ds deletion would be nicer than that boolean flag + Eventually for the getting the ds. Then we don't need to care about setting that flag for each test or not.

And that could have been added to the existing DeferCleanUp()

The exiting DeferCleanUp() was located in a more nested JustBeforeEach block so it excluded some tests which are now part of the cleanup.

fair point
btw, looking at the later tests, there are more things to improve:

"SNRC defaults": move config setup and creation into a BeforeEach()
"Wrong self node remediation config CR": can be removed, we don't allow multiple configs anymore

as written, it can demonstrate the actual issue. I didn't want to propose adding a timeout permanently

you are correct of course, I apologize for misunderstanding :+1:

I was explaining the issue we have in the current test code, not in the PR code. When you look at the current code, my explanation of the issue should make sense, does it?

I think I get what you mean, IIUC basically the BeforeEach of every test will trigger it's own resource creation (please correct me if I got it wrong again).
The downside of this approach IMO is that we don't utilize the a shared block (BeforeEach/JustBeforeEach) for several tests, so each Test needs to have a BeforeEach block of it's own, I think the more common pattern is to create the resource in a Joined JustBeforeEach block and only in case it's necessary use individual BeforeEach block to modify the resources prior to creation.

IMHO a Consistently with 1s for the ds deletion would be nicer than that boolean flag + Eventually for the getting the ds. Then we don't need to care about setting that flag for each test or not.

I think the downside of this approach that it would create false positives test results.
For example let's say that we delete and use a Consistently block to verify that the ds is gone: in case the timing was off (and the delete executed before the ds was created) the test will fail.
With the current approach it'll not happen and the ds will be successfully deleted.

btw, looking at the later tests, there are more things to improve:

In general  agree it can be improved, ATM I prefer not to have the discussion about the best way to it in this PR.

Maybe code can better explain what I mean 🤷🏼♂
https://github.com/medik8s/self-node-remediation/pull/208

Maybe code can better explain what I mean 🤷🏼♂
#208

Thanks for sharing that code, I understand better what you mean now, it's definitely an interesting approach I haven't considered.
I think though that there are couple of things to consider with this approach:

At the first block (in case we didn't get the DS in the test) it is still needs to be cleaned since not getting it in the test does not mean it wasn't scheduled to be created, by skipping the clean in case it isn't found we risk the ds being created after the cleanup phase.
Using this approach we will always wait for the maximum time (2 seconds in this case) in order to verify the ds deleted (vs the other approach were we just wait until the resource is actually deleted)
Because we always wait for the maximum time it would be an issue choosing a higher "safer" value (for example 5 or 10 seconds) for the verification. That means we need to settle for a lower wait time that might make the test less stable on resource heavy environment, comparing to the other approach where using a higher "maximum wait time" isn't an issue because it'll be applied only when necessary.
I think it's more intuitive to understand the approach of  a) I've delete a resource b) I wait to make sure it's deleted Vs a) Delete the resource b) make sure it doesn't exist c) keep doing that to make sure it's actually deleted.  I do agree though  that this is my subjective point of view and others my have  a different opinion which is no less valid.

At the first block (in case we didn't get the DS in the test) it is still needs to be cleaned

That's what it's doing, not?

we will always wait for the maximum time

Yes, but with the advantage of not having to care about cleanup by setting bools in the test code

make the test less stable on resource heavy environment

This is just a unit test with the fake envtest api server. We just need to be sure that the config was reconciled and it created the ds. I don't expect that we need a higher duration than 2 seconds. I would even go with 1 second only.

That's what it's doing, not?

Not the way I understand the code.
In case the DS wasn't set in the test (i.e ds.GetName() == "") and it isn't found (for example because it wasn't created yet) we will immediately exit the Consistently block on the return statement without waiting for the 2 seconds period.

I don't expect that we need a higher duration than 2 seconds

I wish I was that optimistic as well, but from what I've seen so far (there where several PRs in the past where I had to increase wait times)  there are situations where our unit tests needs more time.
I've found it to be particular true for Test container build phase which seems more flaky.

Yes, but with the advantage of not having to care about cleanup by setting bools in the test code

Slowing all the tests down in order to avoid a variable isn't a good tradeoff IMO.

That's what it's doing, not?

Not the way I understand the code. In case the DS wasn't set in the test (i.e ds.GetName() == "") and it isn't found (for example because it wasn't created yet) we will immediately exit the Consistently block on the return statement without waiting for the 2 seconds period.

No, the return is the same as leaving the function at the end, it does not change the behaviour of Consistently. The function will be called again after 500ms until the 2s is reached. I think it's not possible to leave Consitently early in any way, that's the whole point of Consistently in contrast to Eventually

No, the return is the same as leaving the function at the end, it does not change the behaviour of Consistently

Cool, didn't know that, thanks for the explanation :+1:


Can't Install

I copied the repo into customer_components.
Tried to search for BACnet in Settings -> Devices & Services -> + Add Integration.  BACnet does not show up.
Tried restarting Home Assistant the integration still doesn't show up.
Not sure what else to do.

Nevermind... you changed the method to install..

Please close.  I see you added a link to add the repo directly.

Of course! Let me know if there are any more issues.


Update cats-effect to 2.0.0

Updates org.typelevel:cats-effect from 1.4.0 to 2.0.0.
Release Notes/Changelog

Codecov Report

Merging #366 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage    80.8%   80.86%   +0.05%
==========================================
  Files         128      128
  Lines        3340     3340
  Branches       91       91
==========================================
+ Hits         2699     2701       +2
+ Misses        641      639       -2

Impacted Files
Coverage Δ

...ng/baker/runtime/akka/internal/RecipeRuntime.scala
93.24% <ø> (ø)
:arrow_up:

...rotomappings/SensoryEventStatusMappingHelper.scala
92.3% <0%> (+15.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b603b2...1333195. Read the comment docs.


using convertToExcalidrawElements to convert text  ExcalidrawElementSkeleton to ExcalidrawElement, the baseline property is not response to the fontsize

using convertToExcalidrawElements to convert text  ExcalidrawElementSkeleton to ExcalidrawElement
for example,
const myElements = convertToExcalidrawElements([
    {
      type: 'text',
      x: 100,
      y: 100,
      text: 'HELLO WORLD!!',
      fontSize: 25
    }
  ])

the converted baseline property of ExcalidrawElement is not the same as using Excalidraw library

Because jsdom cannot measure the offsetHeight of the DOM. ref
I calc the baseline by multiplying a constant ratio.
Release in 0.0.6


[EDPM] override edpm_sshd_allowed_ranges

Signed-off-by: Chandan Kumar<EMAIL_ADDRESS>

@rebtoor Thank you for reviewing it, I have addressed the comment.


Update README with information on how to work around the CSP…

… "unsafe-eval" issue
fixes #69

Thanks @localpcguy  !!!


Merge 1.1 to master (Feb 22)

Catchup with last 3 days worth of commits

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: louiscryan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@louiscryan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-dashboard

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-dashboard

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-dashboard

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-dashboard

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
3b0c5e9d3296f603c374ed81245eace775d1185b
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
36ede4adaa7d10c23c609f75c65ef24a37932009
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@louiscryan: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@louiscryan just going through my backlog.  I think @howardjohn has solved this.  If so, can you close this PR?
Cheers
-steve

outdated


GetObjectList doesn't behavior as authenticated

What is the problem?

When retrieving projects with GetObjectList, private projects are not
displayed. The Manager is authenticated with basic login (username and
password).

When performing a GET on /projects.xml, with basic authentication outside
redmine-net-api, all projects are returned, not just the public ones.

When does this problem occur?

When trying to retrieve projects with authentication as an administrator user.

What is the expected output? What do you see instead?

The expected output is all projects, not just public ones.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 4 Nov 2013 at 9:14

So, I am having the same issue. Would be nice if this is resolved. Thanks for your help.

Actually - this was resolved once i "enabled" Rest API in my redmine. So, clearly the issue was with my configuration and not with your api. Thanks.


[Question] Artifact limit in release pipeline?

Is there an upper limit on the number of artifacts that can be provided in a release pipeline?

@GitHubSriramB might able to answer this question.
@MattDavisRM i don't think we have any limits

@MattDavisRM We don't limit the number of artifacts in Release.


Test Ivy 2.5.2

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

When master use ivy 2.5.2 and the test targets use ivy 2.5.1:
[info]   : java.lang.RuntimeException: problem during retrieve of org.apache.spark#spark-submit-parent-8bd00540-3ae3-45c0-b8cb-adf54c547a85: java.lang.RuntimeException: Multiple artifacts of the module log4j#log4j;1.2.17 are retrieved to the same file! Update the retrieve pattern to fix this error.
[info]   	at org.apache.ivy.core.retrieve.RetrieveEngine.retrieve(RetrieveEngine.java:238)

Thank you for the investigation, @LuciferYang .

@dongjoon-hyun  @bjornjorgensen Synchronization:

The test failure appears to be due to incompatibility between the metadata created by Ivy versions 2.5.1 and 2.5.2 in the ivy.cache.dir. This can be resolved by using a separate ivy.cache.dir for the older versions of Spark being tested. The current pull request has already been tested successfully.

However, I think this issue is not just limited to testing. I conducted additional functional tests on my local machine as follows:

Prepared a Spark client using Ivy 2.5.2 with version 4.0.0-SNAPSHOT and another Spark 3.x version, such as Spark 3.4.2, using Ivy 2.5.1.
After clearing the ~/.ivy2 directory, submitted jobs in the order of 3.4.2, 4.0.0-SNAPSHOT with the config spark.sql.hive.metastore.jars=maven. Both versions were able to run successfully.
After clearing the ~/.ivy2 directory again, submitted jobs in the order of 4.0.0-SNAPSHOT, 3.4.2 with the same config spark.sql.hive.metastore.jars=maven. The execution of Spark 3.4.2 failed with the following error:

[info]   : java.lang.RuntimeException: problem during retrieve of org.apache.spark#spark-submit-parent-8bd00540-3ae3-45c0-b8cb-adf54c547a85: java.lang.RuntimeException: Multiple artifacts of the module log4j#log4j;1.2.17 are retrieved to the same file! Update the retrieve pattern to fix this error.
[info]    at org.apache.ivy.core.retrieve.RetrieveEngine.retrieve(RetrieveEngine.java:238)`

Therefore, it seems that upgrading to Ivy 2.5.2 can cause issues for end users. If a client with Ivy 2.5.2 is used first and then a client with Ivy 2.5.1 is intended to be used again, it is necessary to specify a different ivy.cache.dir or manually clear the ivy.cache.dir updated by Ivy 2.5.2 in order to use it again properly.

Apart from backporting the upgrade to branch-3.4 and branch-3.5, I can't think of a better way to reduce this compatibility impact now. So, shall we skip the upgrade to Ivy 2.5.2? Although there is a CVE issue with a score of 8.2 before Ivy 2.5.1 (CVE-2022-46751), it doesn't seem to have a significant impact on Apache Spark.

Although there is a CVE issue with a score of 8.2 before Ivy 2.5.1

it's Ivy 2.5.2 not 2.5.1

Although there is a CVE issue with a score of 8.2 before Ivy 2.5.1

it's Ivy 2.5.2 not 2.5.1

Yes, you are right

So the main issue here is that spark have a to old hive version? Are we going to update that to a newer version for spark 4.0?
"Although there is a CVE issue with a score of 8.2 before Ivy 2.5.1 (https://github.com/advisories/GHSA-2jc4-r94c-rp7h), it doesn't seem to have a significant impact on Apache Spark."
"SECURITY-2924 / CVE-2022-46751
Ivy Plugin 2.5 and earlier bundles versions of Apache Ivy vulnerable to
CVE-2022-46751.
This allows attackers able to control the input file for the "Trigger the
build of other projects based on the Ivy dependency management system"
post-build step to have Jenkins parse a crafted XML document that uses
external entities for extraction of secrets from the Jenkins controller or
server-side request forgery."
https://www.openwall.com/lists/oss-security/2023/09/06/9

So the main issue here is that spark have a to old hive version? Are we going to update that to a newer version for spark 4.0?

No, the main issue is incompatibility between the metadata created by Ivy versions 2.5.1 and 2.5.2

"SECURITY-2924 / https://github.com/advisories/GHSA-2jc4-r94c-rp7h
Ivy Plugin 2.5 and earlier bundles versions of Apache Ivy vulnerable to
https://github.com/advisories/GHSA-2jc4-r94c-rp7h.
This allows attackers able to control the input file for the "Trigger the
build of other projects based on the Ivy dependency management system"
post-build step to have Jenkins parse a crafted XML document that uses
external entities for extraction of secrets from the Jenkins controller or
server-side request forgery."
https://www.openwall.com/lists/oss-security/2023/09/06/9

For Spark, what specific harm will it suffer if it is not upgraded? Since I don't have a clear understanding of the specific results, I choose a way that does not break compatibility now. Due to my personal knowledge limitations, this decision may be wrong. If upgrading is necessary, could you submit a PR to fix it and explain in detail the specific harm to Spark if it is not upgraded? @bjornjorgensen  thanks ~


Webpack performance issue when using webpack-merge

Bug report

What is the current behavior?
When using official docs production setup  I've noticed significant performance loss in development and production build times.
Before moving to webpack-merge approach I was using the following way to split dev and prod config:
const config = { ... }
module.exports = (webpack, args) => {
  const isProduction = args.mode === "production";

  config.plugins.push(
    new DefinePlugin("process.env.NODE_ENV", JSON.stringify(args.mode)),
  );

  if (isProduction) {
    config.mode = "production";
    delete config.devServer;
    delete config.devtool;
  } else {
    config.mode = "development";
  }

  return config;
};

And In package.json
  "scripts": {
    "start": "webpack serve",
    "build": "webpack --mode=production"
  },

Also something interesting that I observed is bundle sizes are very different with webpack-merge approach they are much smaller than my original which was reason I started witching to webpack-merge approach.
If the current behavior is a bug, please provide the steps to reproduce.
For reproduction please visit the following repo:

"Slow" webpack-merge approach https://github.com/nparoski/webpack-performance/tree/webpack-merge
Faster, beefy bundles approach https://github.com/nparoski/webpack-performance/tree/master

What is the expected behavior?

Other relevant information:
webpack version:  ^5.93.0
Node.js version: 16.15.1
Operating System: macOS Sonoma 14.5
Additional tools:
Github sandbox repo: https://github.com/nparoski/webpack-performance/tree/master

Because of devtool: "source-map" - https://github.com/nparoski/webpack-performance/blob/webpack-merge/webpack.prod.js#L6 and https://github.com/nparoski/webpack-performance/blob/master/webpack.config.js#L85, they are different, in first case - no source maps, in second - yes


Database Pagination

I've already read #17, but after reading it I got the impression that you're talking about array pagination, after obtaining all of the messages from the database.
I have a migration scenario where some users have hundreds of thousands of messages, and so that approach doesn't work. We tried doing it with standard Rails scopes, but the way the queries and indexes are structured results in about 1 minute per query (even with limit scope), which can't be used to paginate (at least on Postgres).
Do you know if such a scenario has ever been tested ?

Hi Ricardo.
You got the correct impression, we were obtaining all the conversations by using conversations.uniq. This was done because Kaminari didn't count the way it should have (ignoring DISTINCT options). This was an old and forgotten issue, so thanks to notice it :)
Now it paginates as it should using ActiveRecord::Relation instead of Array and Kaminari handles distinct in the right way.
We have never tested it in such a crowded scenario, but with this change it should work properly.

Thanks Ricardo

Hi,
I'll try it later tonight and let you know.
best regards,
Ricardo Trindade
On Fri, Jan 20, 2012 at 11:42 AM, Eduardo Casanova <
<EMAIL_ADDRESS>
wrote:

I have just released Mailboxer 0.6.0 if you want to test with the packed
gem.
Thanks Ricardo

Reply to this email directly or view it on GitHub:
https://github.com/ging/mailboxer/issues/18#issuecomment-3582401

Hi,
I just noticed that mailboxer depends on rails 3.1, I had been using the
minalecs fork because of this. The 0.6.0 gem still reflects this
dependency. Is the gemspec wrong or does it really depend on rails 3.1 ?
best regards,
Ricardo
On Fri, Jan 20, 2012 at 4:39 PM, Ricardo Trindade <
<EMAIL_ADDRESS>wrote:

Hi,
I'll try it later tonight and let you know.
best regards,
Ricardo Trindade
On Fri, Jan 20, 2012 at 11:42 AM, Eduardo Casanova <
<EMAIL_ADDRESS>
wrote:

I have just released Mailboxer 0.6.0 if you want to test with the packed
gem.
Thanks Ricardo

Reply to this email directly or view it on GitHub:
https://github.com/ging/mailboxer/issues/18#issuecomment-3582401

As we use mailboxer on a rails 3.1 environment we had no issues with the rails dependency. Let me do some research on it, If you think it's an important topic, maybe we shall open an independent issue to keep things organized :)

Ok, I'll open an issue on it.
thanks,
Ricardo
On Mon, Jan 23, 2012 at 10:34 AM, Eduardo Casanova <
<EMAIL_ADDRESS>
wrote:

As we use mailboxer on a rails 3.1 environment we had no issues with the
rails dependency. Let me do some research on it, If you think it's an
important topic, maybe we shall open an independent issue to keep things
organized :)

Reply to this email directly or view it on GitHub:
https://github.com/ging/mailboxer/issues/18#issuecomment-3611809

Hi,
Now that I have your version working on Rails 3.0, I tried it, and I'm still getting bad performance. I'm trying to do messageable.mailbox.sentbox.limit(10). Is this the way to do it ? Or is there a different API ? With this example (on PGSQL), the query still takes about a minute on a user with about 100k sent emails
thanks,
Ricardo

Hi!
So you are getting nearly the same times or did you experience any improvement? I will take a look but I won't be able to reproduce the scene as 100k messages will last days to populate on a development enviroment :(
Can you provide me with some logs of the query and its times?

@Roendal maybe https://github.com/stympy/faker could help with that? I probably won't have time to get to this unfortunately

It seems pretty similar to https://github.com/sevenwire/forgery, isn't it?
We are using Forgery in our populate script at social_stream where I do some of the testing.
@karma just disappeared and I don't know if he is still interested in fixing this issue.

Hi,
Nice to know about forgery. We are still interested in this issue, and if needed will fix it eventually, but it has gone down a bit in our priorities, that's why we haven't done it yet.
cheers,
Ricardo

No problem Ricardo.
If you are still interested the issue will remain opened untill you can find some time ;)

Ok, thanks :)
On Mon, Mar 5, 2012 at 10:42 AM, Eduardo Casanova <
<EMAIL_ADDRESS>
wrote:

No problem Ricardo.
If you are still interested the issue will remain opened untill you can
find some time ;)

Reply to this email directly or view it on GitHub:
https://github.com/ging/mailboxer/issues/18#issuecomment-4320401


Yarn workspace not working when using nohoist

What version of Cloud Foundry and CF CLI are you using? (i.e. What is the output of running cf curl /v2/info && cf version?
{
   "name": "",
   "build": "",
   "support": "https://support.run.pivotal.io",
   "version": 0,
   "description": "Cloud Foundry sponsored by Pivotal",
   "authorization_endpoint": "https://login.run.pivotal.io",
   "token_endpoint": "https://uaa.run.pivotal.io",
   "min_cli_version": "6.22.0",
   "min_recommended_cli_version": "latest",
   "app_ssh_endpoint": "ssh.run.pivotal.io:2222",
   "app_ssh_host_key_fingerprint": "e7:13:4e:32:ee:39:62:df:54:41:d7:f7:8b:b2:a7:6b",
   "app_ssh_oauth_client": "ssh-proxy",
   "doppler_logging_endpoint": "wss://doppler.run.pivotal.io:443",
   "api_version": "2.133.0",
   "osbapi_version": "2.14",
   "routing_endpoint": "https://api.run.pivotal.io/routing",
   "user": "dc8ffa86-9ab4-4655-bcef-2bb02a43078f"
}
cf version 6.38.0+7ddf0aadd.2018-08-07

What version of the buildpack you are using?
nodejs-buildpack
I'm trying to deploy a nodejs app organized in yarn workspace. We use the nohoist feature, thus our package.json "workspace" structure is bit different. We conform to the following structure:
"workspaces": {
    "packages": ["packages/*"],
    "nohoist": ["**/react-native", "**/react-native/**"]
  }

However the buildpack doesn't pick up this structure:
Staging app and tracing logs...
   Downloaded app package (21.3M)
   Downloaded build artifacts cache (181.1M)
   -----> Download go 1.11.5
   -----> Running go build supply
   /tmp/buildpackdownloads/ddcdba8d520546385414ac76bc084798 ~
   ~
   -----> Nodejs Buildpack version 1.6.48
          **WARNING** buildpack version changed from 1.6.46 to 1.6.48
   -----> Installing binaries
          engines.node (package.json): ^8.12.0
          engines.npm (package.json): unspecified (use default)
   -----> Installing node 8.15.1
          Copy [/tmp/cache/final/dependencies/2132941ad918127765b1ea0f9d784441a06a9f07717fa2d3980ff200889be578/node-8.15.1-linux-x64-cflinuxfs3-bed0d0e6.tgz]
          Using default npm version: 6.4.1
   -----> Installing yarn 1.15.2
          Copy [/tmp/cache/final/dependencies/f0b0c3270dff2f11d91915a30302f19f6e252fcd55c95188bcedbd532c7412e2/yarn-1.15.2-any-stack-c4feca9b.tar.gz]
          Installed yarn 1.15.2
   -----> Creating runtime environment
          **ERROR** Failed parsing package.json: json: cannot unmarshal object into Go struct field .workspaces of type []string
   Failed to compile droplet: Failed to run all supply scripts: exit status 14
   Exit status 223
   Cell 52f83266-c73f-4215-935f-960455846157 stopping instance 31fd1fcc-d4bb-4752-8b41-264d6f730fdd
   Cell 52f83266-c73f-4215-935f-960455846157 destroying container for instance 31fd1fcc-d4bb-4752-8b41-264d6f730fdd
Error staging application: App staging failed in the buildpack compile phase
FAILED

Please confirm where necessary:
[] I have included a log output
[] My log includes an error message
*[] I have included steps for reproduction

This is now supported in the latest release
If you're interested in using this in CF, the next NodeJS CNB CF-Compatible CNB release artifact will support this behavior.


Run the tests using python3.9

Description
Run the tests using python3.9
Self Check:

[ ] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master, iso5 in 00a0b81d7c1b2d9c8b1bf8f4e9c85ab930f4dbde


Python SDK Modules

Except for d5fb5cd all changes are from the appengine python 1.8.2 sdk

https://ocd.appscale.com:8080/job/Daily Build/3568/


Extra Credit 3: Create a launch screen

Create a launch screen for your Calculator in LaunchScreen.storyboard. Remember that you will want to use some simple autolayout to make your launch screen look good on all platforms.

Some useful tips: iOS Human Interface Guidelines - Launch Screen

From iOS Human Interface Guidelines:

If you think that following these guidelines will result in a plain, boring launch image, you’re right. Remember, the launch image doesn’t provide you with an opportunity for artistic expression. It’s solely intended to enhance the user’s perception of your app as quick to launch and immediately ready for use. For example, Settings and Weather each supply a launch image that is little more than a background image.

so the launch screen for the calculator will only be a background color.


New GUI is unusable - creating snapshot practically unusable for my team

Very difficult to use the picker when creating a snapshot since its just a flat list:

requests with the same in different folders just appear as duplicates with no way to know what they refer to
list can get very long so lots of scrolling to find an item
also no way to search to find an item

Need something equivalent to git status where at least you have full paths so you can clearly see hierarchy.
Maybe have a filter and / or show paths ? 🤷🏽♂

Looks like there is already an open issue for improving the display #2597, do you mind changing this to be a request for the ability to filter? That way we can reduce scope and handle each ask individually 🤗


Break down plugin function in the docs

Make sure to note how to write google analytics queries; note the query explorer at https://ga-dev-tools.appspot.com/query-explorer/

Add #257 here too


Select's option text gets selected

After picking an option in a select, after a while the text inside the select gets selected.
Reproduced in Firefox 126 on Linux. Doesn't reproduce in Chromium 126 on Linux.

Done in https://github.com/beercss/beercss/releases/tag/v3.6.4, thanks for the catch 🍺

No work as expexted, I will reopen to fix another time

The user-select: none property not work as expected on Firefox. I will reopen to fix another time.

Just use -moz-user-select: -moz-none, it will work in Firefox.

Now it's ok, fixed on https://github.com/beercss/beercss/releases/tag/v3.6.5


Add any desired non-function type alias uses to core libraries.

This issue tracks support of the non-function type alias feature.  See the enclosing meta-issue for details.
@lrhn anything we want to do here?
cc @franklinyow @lrhn @natebosch @mit-mit

I'd love typedef any = Object?; in dart:core. Should probably be Any to avoid conflicts, though.
We could defined typedef JsonMap = Map<String, Object?>;, maybe also typedef JsonList = List<Object?>;.
Other than that, I'm not sure there's anything which belongs in the platform libraries.
(Other people have requested capitalized Int and Bool, others have requested lower-case string. Not something I think we should do in the platform libraries).

Does anybody else have an idea for a typedef that would belong in the core platform libraries (core, async, convert, collection, math or typed_data)?
I'll collect ideas here (no promises to actually add them):

[ ] typedef Any = Object?; in dart:core.
[ ] typedef JsonMap = Map<String, Object?>; typedef JsonList = List<Object?>; in dart:convert.
[ ] typedef Int = int; typedef Double = double; typedef Num = num; typedef Bool = bool; in dart:core (for cosistency).
[ ] typedef string = String; in dart:core (for a different kind of consistency).

Do we know how much work we're doing here?

I think nothing is planned here.

I personally don't care about JsonX types. I'd like the Any type, but that's the only one I'd use myself.
There has been absolutely no visible interest about any of these types, so I'm fine with doing nothing.

@mit-mit - I don't think we're likely to get any clear consensus on these to the point where we'd take action. Should we close again?


HAL_SPI_TransmitReceive_IT crashes when TX buffer is not 16 bit aligned

Describe the set-up

Tested on nucleo-g0b1re
arm-none-eabi-gcc version 10.3.1 (but compiler does not matter)

Describe the bug
Calling function HAL_SPI_Receive_IT() or HAL_SPI_TransmitReceive_IT() with buffer not aligned to 16 bits crashes MCU
How To Reproduce

Call HAL_SPI_Receive_IT() with unaligned buffer and more then 1 byte to send

Additional context
Real problem however is in SPI_2linesTxISR_8BIT() function that tries to optimize send using 16 bits access if there is more data.
For Cortex-M0+ unaligned read results in fault.
static void SPI_2linesTxISR_8BIT(struct __SPI_HandleTypeDef *hspi)
{
  /* Transmit data in packing Bit mode */
  if (hspi->TxXferCount >= 2U &&
    ((uint32_t)(hspi->pTxBuffPtr) & 1) == 0) // <= !!!! Additional check to use 8 bit for unaligned buffer here fixes the problem
  {
    hspi->Instance->DR = *((uint16_t *)hspi->pTxBuffPtr); // <= !!! Crashes here on Cortex-M0+
    hspi->pTxBuffPtr += sizeof(uint16_t);
    hspi->TxXferCount -= 2U;
  }
...

ST internal Reference: 184492

Fixed in commit https://github.com/STMicroelectronics/stm32g0xx_hal_driver/commit/1c95709a51b5a32e02c1469e12e5cfe6b8a1ce71

It's hard do believe that simple bug (unnecessary optimization that was flawed and could be fixed in one line) resulted in change of API that is less functional than before, adds a lot of checks that are not really needed.
It's not that SPI hardware has some limitation that restrict buffer alignment it's just unreasonable approach that uses "optimization".
Now if one uses DMA API that works fine and for some reason wants to switch to IT that has similar API and could be used interchangeable user can face serious crash and go through debugging to find out that both API are not compatible and application has to be aware of this unnecessary limitation (that is not present in non-Cortex-M0 based MCU's).
This is very disappointing solution and hardly could be referred as fixed but if counts toward KPI.


make tasks(), Task, and related methods public

This will allow users to have finer control over task dumping.
See https://discord.com/channels/500028886025895936/1032353237166211092/1090303227288879154

Looks great, thanks!

bors r+

@ahrens I just pushed out v0.2.5 with this functionality!


throttle disconnects if we are still finding peers

in networks with high latency, these types of disconnects are common, even with otherwise "good" peers. If even the best peers are laggy, it doesn't make sense to continually disconnect for these reasons:
For 3 types of infractions, don't actively disconnect if we are still finding peers

timeout
useless response
IO exception (common from DeFramer)

see #6210

Status?

closing this - it's being addressed in other ways


[14_linear_models]_shift_footnote's_cite

Good afternoon. @jstac , this PR puts a footnote's citation inside the comma in lecture linear_models:

which implies that :math:`x_t` is strictly periodic with period 4:[#foot1]_ -->> which implies that :math:`x_t` is strictly periodic with period 4[#foot1]_:

@shlff, why do you suggest this?
Usually a footnote symbol comes after the punctuation.

Thanks @jstac .
In lecture linear_model, I find the second footnote symbol [2] comes before the punctuation . and think whether we should keep the notation of [1] consistent with [2], that is, put [1] before the punctuation :?

Dear @jstac , thanks for your kind clarification. You are right and the usage of both footnotes here is correct!
I find some materials related to using footnotes and I will carefully learn it, please find here.
I will close this PR and thanks again!


Fix flaky unit Test_getCompleteCustomPortPairs

What type of PR is this:
/area testing
/kind flake

What does this PR do / why we need it:
This fixes flaky test.
Which issue(s) this PR fixes:

Fixes part of #6479
Fixes #6741
PR acceptance criteria:

[x] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

OC Failure:

  [FAILED] Timed out after 180.000s.
  Expected process to exit.  It did not.
  In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:211 @ 04/14/23 05:41:57.43
------------------------------

Summarizing 1 Failure:
  [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
  /go/odo_1/tests/helper/helper_dev.go:211

Windows Failure:
  [FAILED] No future change is possible.  Bailing out early after 1.332s.
  Running oc.exe with args [oc get pods -n interactive-add-binding-test577amu -o jsonpath='{range .items[*]}{.metadata.name}'] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0

  [FAILED] No future change is possible.  Bailing out early after 1.192s.
  Running oc.exe with args [oc exec nxbmst-app-7b69cff74b-9m7wl --namespace cmd-dev-test1738lfs -- ls -lai /projects/webapp] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0

  [FAILED] No future change is possible.  Bailing out early after 21.166s.
  Running oc.exe with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-delete-test625lsx] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3699/tests/helper/helper_cmd_wrapper.go:101 @ 04/14/23 00:19:16.65

Summarizing 3 Failures:
  [FAIL] odo delete command tests [BeforeEach] when a component is bootstrapped when the component is running in both DEV and DEPLOY mode and dev mode is killed when the component is deleted while having access to the devfile.yaml should delete the appropriate resources
  C:/Users/Administrator.ANSIBLE-TEST-VS/3699/tests/helper/helper_cmd_wrapper.go:101
  [FAIL] odo add binding interactive command tests [BeforeEach] when running a deployment when binding to a service in a different namespace should error out if service is not found in the namespace selected
  C:/Users/Administrator.ANSIBLE-TEST-VS/3699/tests/helper/helper_generic.go:58
  [FAIL] odo dev command tests when multiple projects are present - with metadata.name [It] should sync to the correct dir in container
  C:/Users/Administrator.ANSIBLE-TEST-VS/3699/tests/helper/helper_cmd_wrapper.go:101

Ran 437 of 805 Specs in 1189.646 seconds
FAIL! -- 434 Passed | 3 Failed | 0 Pending | 368 Skipped

/override windows-integration-test/Windows-test

/lgtm


Cij utils

Anisotropy indicies and matrix inversion: all with error propagation.

Hi @alanfbaird - I think this branch can be merged.


Added additional ignore patterns for Russian MediaWiki installations.

Ignore patterns for Russian MediaWiki installations. I’m not actually
sure if this (“Uchastnik_blog”) is how MediaWiki localizes “User_blog”
into Russian but I figure it's as good a guess as any. I disclaim
responsibility if these are incorrect, and offer this with no warranty
or guarantee of accuracy….. I found them by using the URLs that the
English equivalents of these pages redirected to on wiki.rutracker.org.

Hi,
I'd like to do a quick check over the URL patterns.  I don't read Russian and I don't know Cyrillic, but I can at least double-check these patterns (e.g. what happens if I plug them into a search engine).

Well, obviously my "quick check" didn't go as planned.  I can't tell whether or not these are accurate, which means I don't know if they're not accurate, so until someone points them out I guess they're mergeable.

Wow, this notification was a blast from the past, heh.


AWS CLI Windows - Deploying & Hosting NextJs SSR app Cannot find distribution folder

Oh, forgot to mention there is a third option:
You can install the AWS CLI and then set the use_awscli_for_static_upload attribute, which then uses the AWS CLI to perform the task that previously needed Bash and wGet.
...

module "tf_next" {
  source = "dealmore/next-js/aws"

+ use_awscli_for_static_upload = true

  providers = {
    aws.global_region = aws.global_region
  }
}

Not tested, but this should work on Windows.
Originally posted by @ofhouse in https://github.com/dealmore/terraform-aws-next-js/issues/148#issuecomment-866173714

I have added the use_awscli_for_static_upload attribute in the basic main.tf file
Downloaded Amplify-Cli npm install -g @aws-amplify/cli
amplify init

? Enter a name for the project: graphx
? Enter a name for the environment: dev
? Choose your default editor: Visual Studio Code (or your preferred editor)
? Choose the type of app that youre building: javascript
? What javascript framework are you using: react
? Source Directory Path: src
? Distribution Directory Path: build
? Build Command: npm run-script tf-next
? Start Command: npm run-script start ? Do you want to use an `AWS profile? Y
amplify publish
//Executes both tf-next and then build

Hi, the module is exclusive for Terrafom so it's not compatible with other deployment solutions such as AWS Amplify.
Amplify has built-in Next.js support that doesn't require tf-next: https://docs.amplify.aws/guides/hosting/nextjs/q/platform/js
Please note that AWS CLI and AWS Amplify are two different products.

Hi,
Thanks for your quick response.
I have tried deploying a SSR Next.js app build using Amplify, however had received 503 error. I'am still unsure how to fix :/

It looks like you are using the AWS Amplify service to deploy your application.
AWS Amplify is the all-in-one solution from AWS to deploy applications like Next.js on AWS.
The module here is built on top of Terraform which is developed by Hashicorp and uses a different approach to deploy Applications to different cloud providers like AWS.
You cannot mix these technologies together since they are using different data structures to manage the application stack.
If you have problems with AWS Amplify you should contact the AWS support or open an issue at their repository: https://github.com/aws-amplify/amplify-js


SS 723 - Schema Spy

Adds schema-spy config from template in repgrant.

Thanks @WadeBarnes, I've moved the changes to here. Closing this PR.


Move ImpossiblePolicy from error to warning

Category
Cedar validation features
Describe the feature you'd like to request
The validate function currently (v3.x) returns a ValidationResult, which consists of validation_errors and validation_warnings. One current validation error is the TypeError ImpossiblePolicy, which indicates that a policy will always evaluate to false (i.e., it will never fire). We had always intended for this to be more of a "warning" than an "error," but we didn’t add official support for warnings until recently (see #225). We would now like to move this error to be a warning instead.
Benefits

Since the ImpossiblePolicy error is returned on a best-effort basis (i.e., we may miss some "impossible" policies), it is sensitive to changes in our typing precision. This means that seemingly small changes to our typing algorithm could easily become breaking changes. For example: say that we decide to encode in the validator that an expression like 1 == 2 is always false (this is currently not checked). Then policies that previously validated will no longer be valid.
Although having a policy that never applies is likely an error, it is not an issue that would lead to an authorization-time error, which is what the validator is intended to protect against. So this "feels" more like a warning than an error.
There could be legitimate reasons for generating policies that never apply. For example, a user might be generating policies programmatically, expecting that "impossible" policies are ignored.
This would set the precedent for adding more warnings to the validator. Easy example: check whether a policy always evaluates to true (i.e., will always fire).

Impact
Some policies that previously would not validate will now validate, but with a warning. All previously-validated policies will remain valid.
Describe alternatives you've considered
We could leave ImpossiblePolicy as an error, which is the status quo.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Implemented via #716


How do I check If my database is encrypted

DBFlow Version: 4.2.4
Description: How do I check If my database is encrypted  using db-flow-cipher

simple google search gave me this: https://discuss.zetetic.net/t/android-how-to-check-if-a-database-is-already-encrypted/1481


fix compile error on darwin

And remove the dead codes
Signed-off-by: Gao feng<EMAIL_ADDRESS>

It seems that you need to go fmt the file hypervisor/network/network_darwin.go, others look good to me.


How to use proxy?

I have added proxies parameer code in binance_store.py, eg:
def init(self, api_key, api_secret, coin_refer, coin_target, testnet=False, retries=5):
proxies = {
"http": "<IP_ADDRESS>:19180",
"https": "<IP_ADDRESS>:19180"
}
# self.binance = Client(api_key, api_secret, testnet=testnet)
self.binance = Client(api_key, api_secret, testnet=testnet, requests_params={"proxies": proxies})
print(self.binance.get_account())
and I have print my account message, such as:

but my code also print error message, as follows:

Can you help me?

@chuzheng88 Sounds right, is your proxy working properly?
See at: https://python-binance.readthedocs.io/en/latest/overview.html?highlight=proxy#requests-settings


Loading bar instead of spinner

[ ] population statistics
[ ] course statistics

The current implementation is so god awful I hid it.


Fix typo

python -> Python

Learn Build status updates of commit 83e3093:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/defender-for-cloud/release-notes.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks @changeworld


Compute OBB2/OBB3 from a set of points.

As far as I can tell from the documentation, there are no such functions. I am aware that there are different techniques to go about this, but I still think the library could be improved by providing one implementation.

Collision detection was moved to collision-rs in #245. See #244 for more details. Closing as won't-fix.


Lock grafana

https://github.com/dependabot/feedback/issues/174 :( one day one day

renovate has it (an alternative to dependabot)


Add a plug and play QuadricSLAM example for use with a RealSense D435i

Goal is for example to be independent of ROS.
We can then also add another example for using with ROS if necessary.

Moved to qcr/quadricslam#6.


disable cert-manager Certificate creation

Really nice to see a solution to a problem we have since ages ago but we currently already create the certificate in our manifests, it would be nice if there was a way to only create the Resource for external-dns.
I have looked a bit and have no see any evidence this is currently possible.

That's a good point. Do you think it makes more sense to disable the generation globally (i.e. Switchboard should not generate certificates for all ingress routes it processes) or would you rather set an annotation? One could also think of having a global default and overwrite this default with annotations in the ingress routes.

It would be great to have a ConfigMap that holds all Switchboard settings. And in there the user has the option to turn on or turn off certain features. E.g. enableCertManagerIntegration which would be true by default or disableCertManagerIntegration which would be false by default (or something similar to that).
And the same for ExternalDNS and other future integrations or configuration options.

@mamiu following your idea with enabling Switchboard to generalize for arbitrary integrations, I refactored the codebase another time (see #4). You can freely enable and disable individual integrations now.  I think, now you've an amazing foundation for future changes, features, addons, etc. Thanks for doing all the work!

Switchboard Helm Chart v0.2.0 is now also released and supports this feature :)

Thanks, that's awesome :)
Sorry for radio silence I did not find the time to get back to this thread :/


Blog on converting full TF programs to Pulumi

Description
This PR adds a blog post on the new Terraform converter. It's combination of announcement + walkthrough of how to use it.
I still have one TODO in the body of the blog: I'm considering showing off how to handle a couple more cases of manual fixups. But other than that, it's ready for a review.
Checklist:

[x] I have reviewed the style guide.
[x] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

Thanks for the feedback, all! I believe I've addressed all the feedback


chore: split components file into primitives and sections

This looks good to me except there's an error running locally.
 Functions cannot be passed directly to Client Components unless you explicitly expose it by marking it with "use server". Or maybe you meant to call this function rather than return it.
I still haven't been able to figure this out but it seems to happen when rendering content variable generated from the docs Markdown


Duplicated workspace  appears in the recents list when selecting participants in IOU flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: Needs reproduction
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): @carlosmiceli
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @carlosmiceli
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712925797784229
Action Performed:

Click on green FAB
Select option 'Request Money'
Enter amount
search for a workspace

Expected Result:
Result shouldn't show duplicated workspace name
Actual Result:
Duplicated workspace name appears in the search result
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I was unable to review this one before going OOO, and I will test when I'm back online.
Heads up, I will be offline until Tuesday, April 23, 2024, and will not actively watch over this GitHub during that period.
If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

This one is on my testing list, I should have an update soon.

No update yet, I've been focused on other GHs.


Messages in groups aren't aligned for some reason

Known issue with the text input, it enters a leading space for some reason.
Tracked internally as LAND-411


Compability issue CKAN 2.9 python2 Trying to include unknown asset: <ckanext-geoview/geo-resource-styles_css>

using ckan 2.9.1 and ckanext-geoview-0.0.17
2021-04-21 10:19:29,551 ERROR [ckan.lib.webassets_tools] Trying to include unknown asset: <ckanext-geoview/geo-resource-styles_css>

@gallexme is the any solution?

@gallexme did you found a solution

@Georg1703 @pribadihcr https://github.com/ckan/ckanext-geoview/pull/80
It's already merged, do u still gäbe issues?


Comment pyspark for readthedocs because there is no wheel in PyPi

Coverage remained the same at 52.381% when pulling ba92405cb369dccda2a7e72be255aee77f581b05 on develop into b0360af92305a647c7f4805ca52896cbbaf37e4d on master.


Blog app - Views

Project Requirements

[ ] Added the Views associated with the Models and Controllers already created for the Blog App.
[ ] Implemented the designs from the sneak peek wire frames.
[ ] Use methods created in the Blog App - processing data in models.

@NahnahAJ


Fix to #8364 - Query: comparing collection navigations to null or to each other doesn't work

Also fixes (smaller in scope) #5825 - Query: Comparing collection navigation to NULL throws Null Exception
Problem was that we were not taking into account queries where collection navigation was being compared to null and/or each other. This would cause various exceptions during query compilation.
Some of the common cases can be simplified, making them much easier for the query compiler (i.e. navigation rewrite) to process.
When it comes to null comparison, we assume that collection navigation is only null if its parent entity is null, so we can actually just compare the parent entity to null instead
e.g.: customer.Orders == null ---> customer == null ---> customer.Id == null
However, it's possible that user wanted to check whether collection has any elements - we will issue a warning that the comparison to null could have unintended consequences and suggest to use .Any() instead.
When collection navigations are compared to each other we can also approximate by comparing the parent entities instead (if the collections are the same INavigation). If navigations are different, we assume they are never equal.
e.g.:
csutomer1.Orders == customer2.Orders ---> customer1.Id == customer2.Id
customer.Orders == company.ShippedOrders ---> false
This is not a perfect translation, since there can be two collections with exactly the same elements coming from different navigations (e.g. two empty collections: c.CompletedOrders, c.PendingOrders)
Therefore we also issue the warning in this case, saying that the result may not be what user expected.

cc: @ajcvickers for logging infra

@maumar Rules sound good. We should also consider an Equals -> SequenceEqual rewrite for enumerables - We have talked about this before WRT to byte[] comparisons on in-memory for example.

Logging stuff looks good.

new version up @anpete @smitpatel


Fix SubscriptObjectFunction and SubscriptFunction to utilize ColumnPolicy

Summary of the changes / Why this improves CrateDB
Fixes https://github.com/crate/crate/issues/14587 (follows https://github.com/crate/crate/pull/14593) as well as SubscriptFunction and SubscriptObjectFunction to better utilize ColumnPolicy available.
Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

See https://github.com/crate/crate/pull/14593#pullrequestreview-1666602000 and https://github.com/crate/crate/issues/14828


Add optional rowspan support for cells marked with '^^'

Closes #15

Because markdown-it disables es6 linting support on purpose, the arrow functions have to be rewritten in the legacy way. I just pushed consistent-eslintrc branch containing updated lint rules with markdown-it, you may need to rebase on it.
Sorry that I've disabled travis-ci integration by accident. It's now enabled and you could use make test to lint and run tests on local machine.

Branch has been rebased and I've bumped the package version as well.

Coverage increased (+1.8%) to 99.5% when pulling 96b14f85b6f03fe67b86964ba56fffbd2047f985 on pmccloghrylaing:rowspan into 7aefb12fda277edd2daa40b062d3d47da093dd18 on RedBug312:master.

Thanks! Please assign consistent-eslintrc as the merged branch. I will merge these branches into master in order.


Is there a better fork of this project?

Given that this repository seems dead, are there any more active forks around?

Yeah would like to know as well

Not sure if better but it's a fork: https://github.com/Vercjames/package-trpc-swagger

Are there any forks that supports v11 and are published on NPM? patch-package have been giving me trouble on packages that is depended on by other packages.

You can go with https://github.com/mcampa/trpc-to-openapi

cc @mcampa, do you wanna take over maintenance of https://github.com/trpc/trpc-to-openapi?
I finally got it transferred from James


Visualisation of the simulator while RL agent is being trained & CUDA GPU acceleration support.

Hello dear Christian,
I hope you are doing well. Thank you very much for your immediate responses to the issues that I have opened the previous week. I have stared now exploring the karolos API and its capabilities. I wanted to ask is it possible to visualise the simulation of the robot while executing the task ? Furthermore, is it possible to accelerate the training procedure of the RL agent by leveraging powerful NVIDIA GPUs like NVIDIA RTX A5000 using CUDA acceleration in PyTorch?
Thank you very much in advance for all the valuable help and support!
Kind regards,
Christos Peridis

Hey Christos,
yes and yes!
For visualization there are two cases:

Make sure the training pipeline is working as intended. For this, the environment config needs to set the parameter render=True. Also, set number_processes=1, because Pybullet can only spawn one window:

training_config = {
"number_processes": 1,
"env_config": {
"render": True,
}
}

Visualize a trained policy. Look at karolos/display.py and point it to the experiment folder. I just tested the file and found a little bug, so please pull the lastest version first.

Regarding cuda: The agent tries to use Cuda out of the box, see here: https://github.com/tmdt-buw/karolos/blob/1f277ce4a5ca34e3cd27dfb5cb361fcbd2df7a1c/karolos/agents/agent.py#L55
So if pytorch is installed correctly with cuda enabled, that should already work.
Hope that clears things up :) Let me know if you need anything else


Point readers to the related Control Bus component

Don't use the absolute url. Takeas as exaples the other links.. thanks

I hope I've fixed this correctly .....  pointing relatively, and to the adoc

Make sure to run mvn verify within the docs directory to prevent any broken links.

Thanks!


./src/btm: No such file or directory

When I run runExample.sh I am getting the following error
=============== Topic Learning =============
make: Entering directory /home/saipavan/Desktop/BTM-master/src' g++  -c -pipe -O3 model.cpp -o model.o  make: g++: Command not found make: *** [model.o] Error 127 make: Leaving directory /home/saipavan/Desktop/BTM-master/src'
../src/btm est 20 28634 2.500 0.005 500 501 ../output/doc_wids.txt ../output/model/
runExample.sh: line 31: ../src/btm: No such file or directory
When I browsw through the src folder I couldn't find any file named btm. Please respond.

src/btm is the executable created on the 'make' command. Looks like its not able to find the g++ compiler. Try to type  'g++' and run on the terminal. If you get a 'command not found' error, then the compiler is missing. You'll need to install g++ first.

Thanks @shachi04. I was able to run the program. As part of my final year
project, I wanted to use BTM for understanding topics of a user and his
followers. But to get a single output(topics of the user) BTM is taking
around 3-4 min ( I am using Ubuntu 2nd gen i5 system with 4GB RAM). This is
way too long as you can imagine the time it would take to understand the
topics of 1000 followers. Is there any way around. Any help is greatly
appreciated.
ᐧ
On Tue, Apr 12, 2016 at 2:34 AM, shachi04<EMAIL_ADDRESS>wrote:

src/btm is the executable created on the 'make' command. Looks like its
not able to find the g++ compiler. Try to type 'g++' and run on the
terminal. If you get a 'command not found' error, then the compiler is
missing. You'll need to install g++ first.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/xiaohuiyan/BTM/issues/8#issuecomment-208559901

--
Regards,
Sruteesh Kumar,
5th year Undergrad,
Dept. of Engineering Design
IIT Madras,
Ph:<PHONE_NUMBER>

Hi, @sruteesh, the training time of BTM is time-consuming, but the inference of BTM is fast. You can first training BTM to learning all the topics over the whole data, and then infer each person's topics.


Backend environment cannot be deleted

Describe the bug
Deleting backend environments failed:

Then this message does not disappear:

But I can continue to work with backend environments that are actually to be deleted.
Expected behavior
As a developer, I expect that the environments to be deleted will actually be deleted.

I am facing the same issue. I am seeing this message since last 30 minutes.

https://github.com/aws-amplify/amplify-console/issues/1330#issuecomment-740632418 does the trick.

At first I thought https://github.com/aws-amplify/amplify-console/issues/1330#issuecomment-739493860 does the trick. But after creating a new backend environment with the same name (test) I see the same error again for the complet new backend environment.

I had a web hook created for the build trigger which was blocking the
deletion. After removing the hook I was able to clear the message.
Best Regards
Bhavin Kamani
Gembatech
Mobile: +919342054041
=============================================================================
"This email is confidential and may contain legally privileged
information. If you are not intended recipient, you should not copy,
distribute, disclose or use the information it contains. Please email
the sender immediately and delete this message from your system.
Emails are susceptible to corruption, interception and unauthorized
amendment; we do not accept liability for any such changes, or for
their consequences."
Gembatech, Bangalore, India
On 12-Mar-2021 at 4:12:15 PM, centraltec GmbH @.***>
wrote:

Reopened #1642
https://github.com/aws-amplify/amplify-console/issues/1642.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-console/issues/1642#event-4450007014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS3JJJMKOOFXNGVS26W6JHDTDHVYPANCNFSM4ZBCL7SQ
.

@swaminator please reopen this issue. My problem was not solved.

This is still an issue. We have been waiting for an environment deletion to complete for over two weeks, and it it causing other deployments to fail.

@weeksseth  Try amplify-cli with amplify delete command. That worked for me. I tried this after waiting for a night.

@bhavinkamani-gt, thanks for the suggestion, but I only want a specific environment to be deleted, not the whole app.

Hi, any updates on that?

Found a solution:

Delete all related stacks in CloudFormation
In your local IDE: Add an empty dummy entry for the relevant environment in file team-provider-info.json
"amplify -push" --> Than you will get an error
"amplify env add" --> Here you can add the relevant environment again
"amplify -push" --> Tha should work
No you can delete the relevant environment with "amplify env remove" --> Now it should work and your repository is clean again.

@swaminator, could you please reopen this and take a look at my specific case? After everything went well for a while, it bothers me again after recreating the backend environment of the same name:

Closing due to age - please re-open if still experiencing issues.


Fix/top level inner hits

https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_50_search_changes.html#_inner_hits

Type and Path are now at the inner_hits level
Renamed NamedInnerHits => TopLevelInnerHits
Renamed GlobalInnerHit => TopLevelInnerHit

LGTM :+1: some small indentation issues but feel free to fix post merge :smile:


_archetype_playability "dings" a card for not being legal, but should not

This is like the opposite of the Kapsho Kitefins issue, and strongly related.
It should not be a black mark against Brainstorm's playability in Mono Blue Tempo that it was not legal in S32. For the playability of Brainstorm in Mono Blue Tempo we want only to consider (1) the number of Mono Blue Tempo decks playing Brainstorm, divided by (2) the number of Mono Blue Tempo decks IN THE SEASONS THAT BRAINSTORM WAS LEGAL.
To illustrate:
# MariaDB [decksite]> SELECT * FROM _archetype_playability WHERE archetype_id = 317 AND name IN ('Opt', 'Brainstorm', 'Ponder');
# +------------+--------------+-------------+
# | name       | archetype_id | playability |
# +------------+--------------+-------------+
# | Brainstorm |          317 |     0.12784 |
# | Opt        |          317 |     0.43107 |
# | Ponder     |          317 |     0.49669 |
# +------------+--------------+-------------+
# 3 rows in set (0.004 sec)

Brainstorm is surely more of a mainstay in Mono Blue Tempo when it is legal than Opt when it is legal. Ponder should crush Opt, not narrowly beat it.
An even better illustration is Dark Ritual in Necro Midrange:
# MariaDB [decksite]> SELECT * FROM _season_archetype_playability WHERE archetype_id = 109 AND name = 'Dark Ritual';
# +-------------+-----------+--------------+-------------+
# | name        | season_id | archetype_id | playability |
# +-------------+-----------+--------------+-------------+
# | Dark Ritual |         5 |          109 |     0.74310 |
# | Dark Ritual |         6 |          109 |     0.99971 | (Ignore this random deck that has the wrong season_id!)
# +-------------+-----------+--------------+-------------+
# 2 rows in set (0.003 sec)
#
# MariaDB [decksite]> SELECT * FROM _archetype_playability WHERE archetype_id = 109 AND name = 'Dark Ritual';
# +-------------+--------------+-------------+
# | name        | archetype_id | playability |
# +-------------+--------------+-------------+
# | Dark Ritual |          109 |     0.40678 | <<< has dropped hugely compared to S5 playabilty but it should just be the same value as S5 playability
# +-------------+--------------+-------------+
# 1 row in set (0.001 sec)

The practical effect of this is that the wrong cards might show in /seasons/all/metagame
And be returned by /api/key_cards when all-time is passed as the season id (but I don't think anything calls that? It was added as part of the banner but the banner doesn't use it?)


Always show multiselect checkboxes

Signed-off-by: Ruiyun Xie<EMAIL_ADDRESS>Summary of changes

Remove checkbox on the top
Remove state
Add new property to PackageCard

Context and reason for change

Checkbox in attribution view should always be shown

How can the changes be tested
Changes can be test via yarn test:unit, yarn test:integration-ci and yarn test:e2e and in the UI

In the enum CheckboxLabel the multi-select-mode should be removed. Also in the state.

works 👍


rename .rodata.{interrupts,exceptions} to .vector_table.{interrupts,exceptions}

to reduce the probability of foreign object files (that, for example, come from C code) from corrupting the vector table.
This will, at least, break the cortex-m-quickstart template and the cortex-m-rtfm crate.

Done as part of #18


ngModel not updating correctly on select multiple on iPhone

Hi,
The model bound to a select multiple element doesn't update the values correctly on iPhone 6 (ios 8). The same code is working properly in other mobile devices.
AngularJS Version: 1.4.2
There is a fiddle where you can test with your iPhone: http://jsfiddle.net/maku/GV9Ek/
<select multiple class="chosen-results" ng-model="mapCtrl.filters">                 <option value="a"></option>                 <option value="b"></option>                 <option value="c"></option>   </select>

I think this is the same as #13753


Rad Dropdowns not closing correctly when tapping outside of dropdown on mobile

Rad Dropdowns are supposed to close when clicking/tapping/touching outside of the dropdown context once a dropdown is open.
This behavior works as expected on desktop, but does not function correctly on mobile. Likely this is an issue with the event listener not being set up to work correctly for touch events and relying on the click event to correctly translate to touchEnd/touchStart.
Found on:
iPhone 6s / iOS 10.2 / Mobile Safari + Chrome for iOS

Fixed in v1.5.1


QueryBy is "" if it's not set

Description
If I omit the field QueryBy doing a search in a single collection (because I'm using a preset), NewSearchCollectionRequest generates an empty query_by and it's wrong. This field should be omitted in the query.
Example:
"https://.....typesense.net:443/collections/Name/documents/search?include_fields=id&page=1&per_page=100&preset=Preset&q=test&query_by="
Steps to reproduce
Don't include QueryBy

Expected Behavior
Don't add query_by= in the GET.
If I use the MultiSearch, it works

Actual Behavior
It adds query_by= in the GET
Metadata
Typesense Version:  typesense-go v1.1.0
OS: Mac

Fixed in https://github.com/typesense/typesense-go/pull/174