BUGFIX: #86 #40

What was done and how?

#40 was solved as described in the issue. Additionally, the workout page file is now refactored and reformatted.
#86 solved by removing the stream get user provider and fetching the user on demand and updating the flag and state. Additionally, navigation logic is updated as proposed in the issue.

Nice job! Could you open a new PR on this again? I accidentally merged it before merging some of the other PR's which meant the other smaller ones had big merge conflicts so I reverted this merge in order to first merge the other ones so that now I think this PR will merge easier.


⚠ SceneTime has degraded performance

In 5e793a5, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1611 ms

Resolved: SceneTime performance has improved in daa760a after 6 minutes.


Re-Enable a disabled source

I think there is no way to re-enable a source when it is disabled (status 3) due to consecutive failures. If I go to the database I can do it. But in the Front end there no option for that, nor using rake according to your manual.
rake db:sources:activate                # Activate sources
rake db:sources:inactivate              # Inactivate sources
rake db:sources:install                 # Install sources
rake db:sources:uninstall               # Uninstall sources
Nikos

This is intended, as for the most part there are good reasons why a source is disabled. You can do three things:

wait. The source will re-enable if there aren't any new failures
remove the alerts causing the source to become disabled (via /alerts?source_id=SOURCE_NAME)
make the source inactive and then active again

Please use the Lagotto support forum at http://discuss.lagotto.io for these kinds of questions.

Thanks Martin for the quick response.
I opened the issue in case this has been forgotten.
Closing it.


Skip to login in finish step if '-t' is specfied

If option --test (-t) is specified, we should skip to log into the guest in finish phase as it has been done already.
Fix: #1918

Unfortunately this breaks --step and --when functionality ...

@lukaszachy, how about introducing a variable to record the action to log into the guest is done? If it's done, skip to the login action in finish step.

Unfortunately this breaks --step and --when functionality ...

@lukaszachy, how about introducing a variable to record the action to log into the guest is done? If it's done, skip to the login action in finish step.

IMO it is not necessary. Your approach is good, just stop the login only if there isn't when or step used. Current patch is too eager to stop the login.
From the options --command doesn't affect whether the login should happen or not, but --test, --step and --when do.

Unfortunately this breaks --step and --when functionality ...

@lukaszachy, how about introducing a variable to record the action to log into the guest is done? If it's done, skip to the login action in finish step.

IMO it is not necessary. Your approach is good, just stop the login in finish only if there isn't when and step used. Current patch is too eager to stop the login.

@lukaszachy, to check when or step used, looks we can keep using opt('when') or opt('step').
$ find tmt -name "*.py" | xargs egrep -- "'--when|'--step"
tmt/steps/__init__.py:            '-s', '--step', metavar='STEP[:PHASE]', multiple=True,
tmt/steps/__init__.py:            '-s', '--step', metavar='STEP[:PHASE]', multiple=True,
tmt/steps/__init__.py:            '-w', '--when', metavar='RESULT', multiple=True,

Would you please help to paste a user case having both -t and --when or -t, --when and --step?

Would you please help to paste a user case having both -t and --when or -t, --when and --step?

How about the opposite question - Why should we disallow that?
I've realized that  '-c CMD' can be used to workaround fact one cannot append 'prepare' or 'finish' step from the commandline (it would replace step definition from the plan) to do something on the guest.
But I'm not sure how well one can combine options (e.g. tmt run ... login -c 'date' login -t login --step prepare -c 'some prep magic' ... ). I'll take a look later if you don't find it sooner.

While trying to create use case for login -t  --when I've realized that it behaves a bit surprising.
Current implementation is that -t logs into execute right after the test finishes and has same environment as the test (very easy to rerun the test) while --when logs into finish depending on the execute outcome.
IMO we could keep login --when RESULT work as is (login into finish step depending on the execute) however  the login -t --when RESULT should be changed to "log into execute right after the test depending on the test RESULT".
This would cover use case when User has several tests in the plan but want to login immediately after RESULT (usually fail or error) to investigate what has happened. Currently it is not easy as -t logs in after each test and login in finish is too late as later tests might change the SUT significantly.
WDYT @psss @happz @adiosnb @idorax ?

/packit test

While trying to create use case for login -t --when I've realized that it behaves a bit surprising.
Current implementation is that -t logs into execute right after the test finishes and has same environment as the test (very easy to rerun the test) while --when logs into finish depending on the execute outcome.
IMO we could keep login --when RESULT work as is (login into finish step depending on the execute) however the login -t --when RESULT should be changed to "log into execute right after the test depending on the test RESULT".
This would cover use case when User has several tests in the plan but want to login immediately after RESULT (usually fail or error) to investigate what has happened. Currently it is not easy as -t logs in after each test and login in finish is too late as later tests might change the SUT significantly.
WDYT @psss @happz @adiosnb @idorax ?

Yeah, for me it makes sense to be able to combine these parameters to be able to login to a server after each failed or error test.
+1 for me

This is the usual 'issue looks easy at first but later it explodes' example.
Conclusion from the hacking session:
login -t --when RESULT should login to the guest immediately after the test (so it has to be in the execute) if the test ended with RESULT . No additional login in the finish should happen unless requested.
We allow multiple --step and --when so one way to implement this could be to implicitly use --step execute if -t is used.
So login -t --when RESULT  would be the same as login -t --when  RESULT --step execute thus the login in finish will not happen.
However user can request login -t --when RESULT --step finish and because of the -t it would be as if login -t --when RESULT --step finish --step execute was used and login will happen in the execute (after each test with RESULT) and finish (if any test has RESULT). IF user doesn't want to login in execute for this command line they shouldn't specify -t option.
I'm not sure that mutiple login on the commandline work correctly so let's support single login command with several options.
This should ready for the  future once multiple subcommands can be used properly (the logic of login command can stay the same).

Would you please help to paste a user case having both -t and --when or -t, --when and --step

To finally reply the use cases:
-t --when : As tmt user I want to login to the guest with the same environment as the test immediately after that test finishes with RESULT so I can investigate why if finished in such result (e.g. --when fail to see why test fails)
-t --when --step: As a tmt user I want to investiage test result in execute step but I want to  login to the guest in other steps than execute as well.

My testing plan:
/p:
  execute:
    how: tmt
  discover:
    how: fmf
  provision:
    how: container

/t:
  /good:
    test: 'true'

  /bad:
    test: 'false'

The tmt run login -t works as expected -- logs in 'execute' step immediately after each test, no login in finish
But tmt run login -t --when fail however logs in 'finish' and there is no way to stop that (adding --step execute makes login happen at the end of 'execute' step (once all tests are finished')
Could the login in 'finish' be disabled when '-t --when' is set but '--step finish' is not?
So tmt run login -t --when fail will login only after '/t/bad' but I can ask tmt to login in finish as well by tmt run login -t --when fail --step finish

My testing plan:
/p:
  execute:
    how: tmt
  discover:
    how: fmf
  provision:
    how: container

/t:
  /good:
    test: 'true'

  /bad:
    test: 'false'

The tmt run login -t works as expected -- logs in 'execute' step immediately after each test, no login in finish
But tmt run login -t --when fail however logs in 'finish' and there is no way to stop that (adding --step execute makes login happen at the end of 'execute' step (once all tests are finished')
Could the login in 'finish' be disabled when '-t --when' is set but '--step finish' is not? So tmt run login -t --when fail will login only after '/t/bad' but I can ask tmt to login in finish as well by tmt run login -t --when fail --step finish

What do you think about extending the login test set with these cases?


UI change

Need the contributor for UI changes.

Hi Akshay, I am willing to work on this. Can this be assigned to me?
Thank you!

Yes. Off course. You can start work on this. Show your creativity. Good Luck.

I would also love to work on this.

@cchigo Welcome to collaborate. Please show your excellency. It really appreciated.

Hi, can you give the app a name? and do you have a logo for it? I would be working on the UI this weekend. Thank you.

This project is only for educational purpose.  But, if you want to create a logo then use the default project name (Online Electricity Billing System).

Alright then

can i join this project can help to upgrade programming structure to ModelView ViewModel(MVVM) architecture

@unclejo Yes. Of course.

i cannot able to  add bill  for customers showing error

please
give some solution faster

can u guys manage to log in?

@akshaykalola28 can i start change the ui?

@CodeStealerHAHA @hariharan25-03 It's due to a firebase server error. Please fork this repo. and set up your firebase account in this project.
@unclejo Yes. You can. Please make a separate branch for it and create PR after completion.

lease make a separate branch for it and create PR after completion.

but is it okay to change whole UI project and use module library to store all colors and styles in a single module?

Yes. You can use your own expertise.

@akshaykalola28 i created a branch woud you like to visit?

@akshaykalola28 i create pull request to be merge check it if you have available time.


Catalan translation

Hello,
This is the catalan translation for the strings.
Thanks!

Thank you, I'll add it for upcoming 4.0.9 release


No way to change when the plugin is run

Currently the plugin always runs in the emit stage. It would be desired to have the ability to specify that i want the plugin to run after the compilation is complete. This could be done through an option that defaults to emit.

Thanks for opening the PR. Is there a reason why you need to customise this behaviour? Are you encountering a case where the current process is not working for you?

Yes. Currently i am using this to bundle multiple files together after another webpack process that produces assets, and i need to use this plugin to modify those assets. Currently this only triggers early in the webpack cycle, so the assets do not exist when i go to activate this plugin.

To be honest, I don't feel comfortable exposing something that close the the webpack API via a configuration. However, there is no particular reason why this plugin is currently run during emit, so I'm considering to change it to something like afterEmit.
What exactly are those assets that are being generated, though? Shouldn't the responsible plugin be able to concat its output somehow?

Since the plugin that i'm using is what is the central runner of the build process, it only makes sense for it to run during the emit hook. The responsible plugin should be able to concat its output, but in my use case it has been unable to. For the moment, this plugin is the only way for me to do that. I'm not sure what the concern is of exposing something close to the webpack API like you mentioned though, it isn't exactly a security risk if the user is the one configuring the use of this library.

Changing it to afterEmit would work for my use case, but i cant guarantee that it will work for everyone. If a sizeable number of people use this plugin, changing it to afterEmit is bound to break some peoples builds.

Bumping to see if theres any update to this?

Hi @daniel-brenot, apologies for the delays.
I still think it would be best to solve your issue outside of this plugin. If you need to concat assets that have been emitted by other plugins, have you tried re-arranging the order of the plugins in your webpack config?
Also, if that plugin you mentioned should be able to concat its output on its own, but somehow cannot, it might be helpful to submit an issue for it as well.

I'm working with the angular cli, and with my use case this will never be fixed by them. Also, re-arranging the plugins won't change how they run, the plugin is the only way to decide when code is run in the stages. Your plugin will always be run before assets are emitted currently, and if that isn't fixed there is no way for me to continue using this moving forward. I have no way to fix this issue outside of the plugin because it is an issue with the plugin itself.

I ask that you seriously reconsider allowing controlling the point at which the plugin runs. It is a small change that already has a pr and doesn't have any risk associated with it. I'm sure i won't be the only one that benefits from this change. If not, then i will have to fork this for use in my workspace and i would really like to avoid that, especially since the change is so small.

It only matters in the sense that it affects when the plugin runs the hook specified. For example, if you register plugin a before plugin b, and they both have the 'afterEmit' hook tapped into, then plugin a will have it's afterEmit called first. However, if plugin b hooks into 'beforeEmit' for example, then it will be called first. In this case, you don't have any control over which one runs first.
I'm curious how having a flag is any different than using the bare hook name. The only difference functionally-wise between my solution and yours is that my solution allows greater control over when the plugin is run, and the one you propose only allows for having it execute before or during. If it's a worry of a user inputting an invalid value, I could always add input validation to ensure that the value is one of the valid webpack hooks.
For my use case i need afterEmit for the moment, however there is no guarantee that afterEmit or emit will cover the cases i will encounter in the future, and I don't want to run into that problem and have to come back and make another issue in a few months and request changing a flag to a string, requiring code that supports an older flag as well as a string, causing further confusion.
If you are worried about certain webpack hooks being used, we could also restrict the values to an array of hooks that could be used, that way if someone requested for more hooks to be added in the future, the list could easily be extended rather than the flag mechanism having to be changed to support an additional time to hook into.
I'm not quite sure how i would test this feature. It's just a string argument passed into webpack, so as long as it is in the accepted range of values in the documentation it shouldn't have any behaviour that is out of the ordinary. If you know of a way to test this, feel free to mention it and i will add a test to check for it.

As an example of another plugin that does this, the file manager plugin lets you execute steps at specific parts, and so does the webpack shell plugin:
https://github.com/s00d/webpack-shell-plugin-next

I'm curious how having a flag is any different than using the bare hook name. The only difference functionally-wise between my solution and yours is that my solution allows greater control over when the plugin is run, and the one you propose only allows for having it execute before or during. If it's a worry of a user inputting an invalid value, I could always add input validation to ensure that the value is one of the valid webpack hooks.

I don't want to expose webpack hooks to the end user, so I would prefer to map this with specific config values, like webpack-shell-plugin-next does with onBeforeBuild, etc. Not everyone might (want to) know which hooks are running when, so using specific configuration values should make it easier to understand.

For my use case I need afterEmit for the moment, however there is no guarantee that afterEmit or emit will cover the cases i will encounter in the future, and I don't want to run into that problem and have to come back and make another issue in a few months and request changing a flag to a string, requiring code that supports an older flag as well as a string, causing further confusion.

I'm sorry but I'm would only allow an option to have this plugin either run before asset emission or after. If your use case is that complex, it might be easier to just run a separate script after your webpack build.

I'm not quite sure how I would test this feature. It's just a string argument passed into webpack, so as long as it is in the accepted range of values in the documentation it shouldn't have any behaviour that is out of the ordinary. If you know of a way to test this, feel free to mention it and I will add a test to check for it.

I tried out your PR in a minimal setup, and it doesn't seem to work with afterEmit. Can you verify this?
In order to get this to run on that hook would require a different implementation (which should also be tested on its own), because currently, concatenated files are emitted as assets themselves.


Feature request: brew install compose-on-kubernetes

https://brew.sh
It is already possible to brew install docker-compose etcd helm kubernetes-cli so it would be awesome to be able to add compose-on-kubernetes to that list.

Hi! Thanks for your feedback. Unfortunately we're no longer maintaining this repository so I will close this issue.


Doesn't work at all - constant loop

I've installed and configured the package correctly. Upon running "grunt replace" it just sits there. I ran "grunt replace -v" and it shows that it's just constantly running "replace" task over and over indefinitely. It never actually makes any changes or ends the stask.
Here's the console.
Here's my setup. I changed the source links and regex to generics to maintain privacy of the project I'm working on. Note, I excluded "dest" because I want to overwrite. I also tried with "dest" and had the same results

you may want to check your setup, I've gotten it to work fine.  Here's my setup
grunt.initConfig....
        replace: {
        asset_properties_version: {
            src: ['<%= config.assets_properties_dir%>/<%= config.assets_properties_filename%>'],
            overwrite: true,                 // overwrite matched source files
            replacements: [{
                from: /asset_version=[0-9]{14}/g,
                to: "asset_version=<%= executionTime %>"
            }]
        }
    }
});

grunt.loadNpmTasks('grunt-text-replace');

grunt.registerTask('update_asset_version','Updates the assets.properties value for the asset_version key', ['replace:asset_properties_version']);

i have this problem too. use your setup but also loop


Scripting variables are not expanded in :out and :r commands

Hello Everyone,
in mssql-tools a SQL script can use variables even when composing a file path in :out and :r commands.
The go version is not able to expand variables in the filename of these commands:
:on error exit
:setvar WorkingDir ./tmp
:out $(WorkingDir)/file.sql
GO
PRINT '-- Test file.'
GO
:out stdout
GO
:r $(WorkingDir)/file.sql
GO

and leads the SQL script above to the following errors:
Sqlcmd: Error:  Error occurred while opening or operating on file $(WorkingDir)/file.sql (Reason: open $(WorkingDir)/file.sql: no such file or directory).
Sqlcmd: Error:  Error occurred while opening or operating on file $(WorkingDir)/file.sql (Reason: open $(WorkingDir)/file.sql: no such file or directory).

Tested on both v1.5.0 and v1.6.0.
TIA,
Matteo

thx for opening an issue! Is the support for variables supposed to be for all commands, or just ones that take file paths?

`:r' works for me, but ':out' and ':error' are definitely broken

Hi @shueybubbles,

`:r' works for me, but ':out' and ':error' are definitely broken

Didn't test them separately, just on top of my use case.
Thanks a ton for the PR!
Matteo


CodeCov token may need to be reuploaded

As per https://github.com/snok/django-auth-adfs/actions/runs/11106517309/job/30855027879#step:8:40
Run codecov/codecov-action@v2
==> linux OS detected
https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
==> SHASUM file signed by key id 806bb28aed779869
==> Uploader SHASUM verified (b37359013b48fbc3b0790d59fc474a52a260fb96e28e1b2c2ae001dc9b9cc996  codecov)
==> Running version latest
==> Running version v0.8.0
/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov -n  -Q github-action-2.1.0 -Z -f ./coverage.xml
[2024-09-30T12:54:20.870Z] ['info']
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.8.0
[2024-09-30T12:54:20.878Z] ['info'] => Project root located at: /home/runner/work/django-auth-adfs/django-auth-adfs
[2024-09-30T12:54:20.881Z] ['info'] -> No token specified or token is empty
[2024-09-30T12:54:20.888Z] ['info'] Searching for coverage files...
[2024-09-30T12:54:21.101Z] ['info'] => Found 1 possible coverage files:
  ./coverage.xml
[2024-09-30T12:54:21.101Z] ['info'] Processing ./coverage.xml...
[2024-09-30T12:54:21.104Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-09-30T12:54:21.265Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.8.0&token=*******&branch=master&build=11106517309&build_url=https%3A%2F%2Fgithub.com%2Fsnok%2Fdjango-auth-adfs%2Factions%2Fruns%2F11106517309%2Fjob%2F30855027879&commit=5ea3c87036461e727132efbdfba6d30d17a3687f&job=coverage&pr=&service=github-actions&slug=snok%2Fdjango-auth-adfs&name=&tag=&flags=&parent=
[2024-09-30T12:54:21.558Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 3093s."}

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Seems to be a GitHub (and opensource) wide issue;
https://github.com/codecov/feedback/issues/301
There is a workaround https://github.com/codecov/feedback/issues/301#issuecomment-2009355183 . In short it uploads the coverage report to GitHub itself (as an artefact) and will upload to codecov when it can.

Thanks @tim-schilling and @sajoku!
I don't really know if we want to continue with codecov upload on PRs after this? I think, without uploads, we'll just be able to see the coverage % in our pipelines, which is probably enough.
Or just wait for Codecov to fix it, the proposed workaround seems a bit hacky to me.

I'm fine with that change


hydra.errors.ConfigCompositionException: You must specify 'task', e.g, task=

Describe the bug
Receiving a config error to specify 'task' when running med_benchmarking baseline experiment, while 'task' is already specified in the experiment's config file at projects/med_benchmarking/configs/experiment/baseline.yaml:
# @package _global_

defaults:
...
- override /task: ContrastivePretraining
- _self_

To Reproduce
# clone mmlearn
git clone git@github.com:VectorInstitute/mmlearn.git

# create virtual env
python3 -m venv my_env
source my_env/bin/activate

# install mmlearn without any extra dependency
cd mmlearn
python3 -m pip install -e .

# install med_benchmarking dependencies
pip install -r projects/med_benchmarking/requirements.txt

# install some extra dependencies to resolve import issues
pip install pillow torchaudio opencv-python

# run baseline experiment
mmlearn_run 'hydra.searchpath=[pkg://projects.med_benchmarking.configs]' +experiment=baseline experiment_name=test

Expected behavior
Receive a warning about unavailability of experiment configs:
path/to/venv/lib/python3.9/site-packages/hydra/_internal/config_loader_impl.py:216: UserWarning: provider=hydra.searchpath in command-line, path=projects.med_benchmarking.configs is not available.

Then, at the end of Traceback, receive:
hydra.errors.ConfigCompositionException: You must specify 'task', e.g, task=<OPTION>
Available options:
        ContrastivePretraining

Version
mmlearn version 0.1.0a0.dev2 installed from source.

Solution: med_benchmarking experiment configs are not imported correctly due to missing packages.
To make sure all required packages can be imported correctly, run
python projects/med_benchmarking/configs/__init__.py

and resolve any import error that might occur.


⚠ Bofrost.de has degraded performance

In a7d7d5e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.de performance has improved in 602fa13 after 6 minutes.


fix: Use memory key/value storage for sparql backends

Closes #840 .
Due to all the work on storage I realized what the problem was and how to easily fix it.
The problem is that the sparql store was using the ResourceStore for the internal storage. But in that case the store only accepts RDF while the internal storage uses JSON. This explains the error message in the issue above since the converter tried to conver the JSON to JSON-LD and was missing the context. This also means #864 completely broke the sparql config since there we made it so the locker also used the ResourceStore for internal storage.
The solution is to just use the memory storage instead since that one does accept everything. It is partially a band-aid solution though since this means all IDP data (e.g. registrations) will be lost on server restart.
A more comprehensive solution would be to either set up a new file store specifically for the internal storage, or store the JSON documents in the sparql store as strings.

or store the JSON documents in the sparql store as strings.

Or slap on a JSON-LD context? But then we'd still have to frame it when we get it out again.


Can't read a SoundFile object for a wav file

It is impossible to read a wav file contained in a SoundFile object without specify a length, even though it is possible for the read function.  Consider this (using the PySoundFile test file mono.wav):
>>> import soundfile as sf
>>>
>>> sf.read('mono.wav')
(array([  0.00000000e+00,   3.05175781e-05,   6.10351562e-05,
         -6.10351562e-05,  -3.05175781e-05]), 44100)
>>> sobj = sf.SoundFile('mono.wav', 'r')
>>> sobj.read()
ValueError                                Traceback (most recent call last)
<ipython-input-9-8c7a6773277d> in <module>()
----> 1 sobj.read()

/usr/lib/python3.5/site-packages/soundfile.py in read(self, frames, dtype, always_2d, fill_value, out)
    944         """
    945         if out is None:
--> 946             frames = self._check_frames(frames, fill_value)
    947             out = self._create_empty_array(frames, always_2d, dtype)
    948         else:

/usr/lib/python3.5/site-packages/soundfile.py in _check_frames(self, frames, fill_value)
   1328                 frames = remaining_frames
   1329         elif frames < 0:
-> 1330             raise ValueError("frames must be specified for non-seekable files")
   1331         return frames
   1332

ValueError: frames must be specified for non-seekable files

I would think that if it is possible to call sf.read(fname) on a file, it would also be possible to call read() on an object for the same file.

It looks like you are using libsndfile version 1.0.26, which is broken, see #158 and https://github.com/erikd/libsndfile/issues/124.
You should install version 1.0.25 (at least until 1.0.27 is out).


Update to Danger 2.0

See #17234 for discussion.

Awesome 👍 - was just setting up to do this. Thanks @hramos


Trade UX tweaks

Fix estimates content clip in WebKit browsers
Speed up animations

Looks much better to me!


Running tests with MSTest

Hi,
I am trying to run my tests by using MSTest's command line interface. The weird thing is that I get an exception that chromedriver.exe cannot be found, while the file is in the folder. I also trying embedding the chromedriver.exe in the DLL containing my tests, the result was the same.
Do you have any suggestions how to fix this?
Thanks in advance!

Ok I found out that MSTest did not copy the chromedriver.exe to the Out folder. The fix was to use DeploymentItem on the method to force MSTest to copy it. (quite annoying though)

Can you please post more detail about the fix so anyone else with the same problem can solve it?
Thanks
--

On 10 Mar 2016, at 12:30 am, crazybg321<EMAIL_ADDRESS>wrote:
Ok I found out that MSTest did not copy the chromedriver.exe to the Out folder. The fix was to use DeploymentItem on the method to force MSTest to copy it. (quite annoying though)
—
Reply to this email directly or view it on GitHub.

The problem was that MSTest copies the files from the directory of the DLL containing the tests to a Out directory and runs the tests from there and by default it does not include the chromedriver.exe in that folder (don't know why). So the fix was adding the DeploymentItem("chromedriver.exe") attribute on the methods.
With some further investigation I came to the conclusion that it is better to create a base test class that has that attribute and a page object field and all my test classes are extending it (meaning all of them require the chromedriver.exe).


The factor/factor repo, or "is factor dead?"

Im talking about this one: https://github.com/factor/factor It says it's the github mirror. I've seen people on irc and hacker news think factor is a dead project because nothing happens in factor/factor, all the action is in slavapestov/factor. And it's bad if people have that perception. Can something be done about it? Like redirect from factor/factor to slavapestov/factor or rename the repo slavapestov/factor to factor/factor?

I'd love to switch to factor/factor. Would doing this before 0.98 be a good idea so it can be announced at the same time?

This has been done, y'all! Let's close this.

Done!!

Great work! :+1:


bosh health manager reports metrics with incomplete names

Bosh health manager intermittently reports via its graphite plugin metrics with names where the deployment name is missing. These metrics contain usually only one value. This means we have e.g. a metric with the name CF..cell_z1.22b7cd86-cb63-4599-99b6-9da3b4faf529.0d0e45d8-87ca-420a-a086-d7613f1b6fd1.system_cpu_sys that contains just one value and another metric with the correct name CF.cf-diego.cell_z1.22b7cd86-cb63-4599-99b6-9da3b4faf529.0d0e45d8-87ca-420a-a086-d7613f1b6fd1.system_cpu_sys which contains the expected values (one per minute).
This seems to occur often, but only for a short period of time (during startup of a new VM or at shutdown?).
The effect for us is that we have many useless metric names in the database (which is annoying in the Grafana dashboard editor, it displays a dropdown menu of the metric names). Would it be a good idea to filter out metrics without deployment names set in the health manager graphite plugin? If we created a pull request for that change, would it have a chance to get accepted?

I created a pull request anyway: #1473

Closing - as of ~v260.1, this should be working properly.


storage: fix the integration test of BR

Signed-off-by: 3pointer<EMAIL_ADDRESS>
What problem does this PR solve?
After #10132 #9706 merge into master, BR's integration test would be failed. This PR try to fix them.
What is changed and how it works?
What's Changed:

Fix the error lost in s3 put object.
Keep the changehost logic as before.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Release note

No release note

/run-br-integration-tests

/run-br-integration-tests

/run-integration-br-tests

/test

/lgtm

/merge


tests: use AnimatedVec4 instead of AnimatedVec3 for tests

The r32g32b32_sfloat format is not supported on AMD Polaris GPUs with
the Vulkan API.

Functionally OK but I'd split the function factor out from the API changes.
Also, removing the tests while keeping the feature means reducing the coverage and holding an half supported and non-tested feature, so it feels pretty incomplete as is to me.

These formats are not supported by Metal and not widely supported by
devices running Vulkan.

OK, but then this one looks unnecessary as it is more specific:

The r32g32b32_sfloat format is not supported on AMD Polaris GPUs with
the Vulkan API.

Note: we could also drop NGLI_FORMAT_R32G32B32_* but that can come later.
Aside from the description comment, LGTM

These formats are not supported by Metal and not widely supported by
devices running Vulkan.

OK, but then this one looks unnecessary as it is more specific:

The r32g32b32_sfloat format is not supported on AMD Polaris GPUs with
the Vulkan API.

Dropped.

Note: we could also drop NGLI_FORMAT_R32G32B32_* but that can come later.

NGLI_FORMAT_R32G32B32_* can still be used for buffers.

Aside from the description comment, LGTM

Note: we could also drop NGLI_FORMAT_R32G32B32_* but that can come later.

NGLI_FORMAT_R32G32B32_* can still be used for buffers.

Looking at pgcraft.c they're not mapped, probably because no such format exists in glsl?


✨use legacy successors, support skips and skipRange

Description

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[ ] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

Solves #54


Local cache is not used for "page level" queries

Somewhat relevant: https://github.com/RevereCRE/relay-nextjs/issues/41#issuecomment-1034546235
I tried to work around the shallow routing issue by just not using shallow routing. But I've ran into an issue where cache is not used at all when the page level query is ran. It's reproducible in the example app as well, even if you update relay-nextjs to 0.6.0.

Lol my bad, it is in fact using cache, it's just using store-and-network fetch strategy.

Would gladly accept a PR to make that configurable 😄 The reason it's currently set to store-and-network is that's what we found to be the most sensible default in our app.


[FR] Part Categories got harder to navigate

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
i Have structured my inventory based based on a general part group
eg:
-Voltage regulators
--Positive
---78xx
---LDO

etc.
Im not so sure at witch version this happend cause this is more like a "when you need it" thing,  i notised that when going to the part or stock Subcategories menu i had all the "tree" on the same list and i had to set a filter

that wasnt needed before .
Suggested solution
Revert back to doing the oposite . If someone wants everything listed like this :

have it be a filter
Describe alternatives you've considered
You could also have it be a option in the config if the user want by default

the Include Parameters Option be True or false
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

@eimparas any development in this area will focus on the new react interface. You can view the progress here: https://demo.inventree.org/platform

@SchrodingersGat  Yes i understand , but the same behavor seems to happen in the demo

But help me clear this up , did this behavor change indeed in some version or it was like a Mandela effect of some short?

I think this is a regression introduced with #6536 . (Found this by git bisect, that its working a commit prior to that (a310437dc71ae08af30c8079532e425bc1838c7d) and the first bad commit is 0bfbd45cece8ae7e68b077d61438b70c26ab5a12)

Ok, I think I misunderstood the issue here. So, you are saying that now by default, sub-categories are included in the results, but previously they were not included by default?

Exactly

Ok, I think I misunderstood the issue here. So, you are saying that now by default, sub-categories are included in the results, but previously they were not included by default?

Yes, thats what im saing .
having  sub-categories  included in the categories  list makes it quite confusing imho

As far as I can tell this is only the case for the "top level" part category.

You are right, but I think this is definitely a regression should be changed for the "top level" category.


A variation on your theme

Hi Terence -
I've made quite a few changes to your original - it's sufficiently different that you may want to completely ignore it, but I can do a pull request if wanted!
Basically, I've pulled your original tweeting code out into bmwtweet.py and made a more generic 'bmw' module.
You can do things like:
import bmw
c = bmw.ConnectedDrive()
print c.call('/user/vehicles/')

It uses the 'requests' module, so you need to pip install that if you don't already have it.
Anyway, it's at https://github.com/quentinsf/BMW-i-Remote if you're interested.  More to come soon.
Thanks again!
Quentin

Your Python-fu is mightier than mine! Go ahead with a PR :-)


Drop DataAlreadyLogged error

Fixes #431

Codecov Report
Base: 96.19% // Head: 96.15% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (6a8c3e6) compared to base (5cd55ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0     #445      +/-   ##
==========================================
- Coverage   96.19%   96.15%   -0.04%
==========================================
  Files          37       37
  Lines        2232     2239       +7
  Branches      187      189       +2
==========================================
+ Hits         2147     2153       +6
  Misses         49       49
- Partials       36       37       +1

Impacted Files
Coverage Δ

src/dvclive/error.py
82.35% <ø> (-4.02%)
:arrow_down:

src/dvclive/plots/base.py
85.71% <ø> (-1.39%)
:arrow_down:

src/dvclive/lightning.py
93.87% <100.00%> (-0.47%)
:arrow_down:

tests/test_main.py
100.00% <100.00%> (ø)

src/dvclive/studio.py
91.42% <0.00%> (-2.86%)
:arrow_down:

tests/test_dvc.py
100.00% <0.00%> (ø)

tests/test_studio.py
100.00% <0.00%> (ø)

src/dvclive/report.py
96.38% <0.00%> (ø)

src/dvclive/live.py
90.73% <0.00%> (+0.10%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use error-chain for Main Error Type

Can we make tantivy's error handling better using error-chain?
error-chain gives us better backtraces thanks to backtrace, which would be great given tantivy is complex and asynchronous, but it imposes a particular open-book structure on your error type.
Currently we've got small, specialised error types in submodules that are collected into this main user-facing Error. The idea is to use error-chain for the main user-facing tantivy::Error type and keep the specialised errors as just plain std::Errors. I guess we'd chain_err those?
Does anyone have any other thoughts/recommendations/considerations on how we could hold error-chain or something else to keep tantivys error handling idiomatic and useful? Any input would be really appreciated! I've got a quick spike here that could be a good starting point for discussion.
cc: @fulmicoton @brson @BurntSushi

One of the main concern is that understanding tantivy's Error type will not be accessible by
editor's go to definition nor will it be visible in the rust doc.

My general opinion is that the problems that error-chain solves are important, but that it's too much magic for my blood. Two things to note about myself:

I have a very high tolerance for code that is annoying to write, but a low tolerance for code that is hard to read.
I'm probably being a bit cranky.

I empathize with 1... Especially for a libraries. Library source code eventually tends to be more Write Once Read Many than higher level application in my experience.

In addition to this I think we could add more logging to tantivy so you can get a lot of useful debug info in verbose. There's a ticket here somewhere about slog.
If error-chain is a bit too much magic then we can use backtrace directly and tack it on to our error types like error-chain does. Reinventing it seems like a weird solution though, but would give us the flexibility to make Error a black box sometime in the future.
Alternatively if out-of-the-box logging is going to have all this detail then we could rely on that and leave the errors mostly as they are. We could have a bail! macro of our own that grabs a bacltrace if configured and tacks it on to the log.
Thoughts?

@KodrAus quick update... Let's give it one more week of thoughts.

@KeenS corrected me. The errorkind not showing in the rustdoc was just a matter of it being publicly exposed.
I think it might be a good idea to use error-chain for tantivy's toplevel error.

Ok, I'll get the error-chain branch in a reviewable state and open a PR :+1:

Closed by #177. The main Error type is now using error-chain and the directory errors implement std::error::Error.


[Bug] No coverage for file reported if JSX is used

Describe the bug
Coverage is not reported for files where JSX is used.
I've set up a minimal repository that recreates the issue with the same config - https://github.com/jMalojlo/sb-repro.
It's a basic button component with a story containing a play function to 'test' a click handler.
The component itself contains some JSX and imports some jsx and non-jsx module. What we see in the coverage report is that only the files without JSX are properly counted.
We're running an ejected CRA and I assume it's a Babel config issue, but can't figure this out myself.
Steps to reproduce the behavior

Clone https://github.com/jMalojlo/sb-repro
npm install && npx playwright install chrome
npm run storybook
npm run storybook-test runs tests with --coverage
npm run generate-storybook-coverage nyc report with lcov
open ./coverage/storybook/lcov-report/index.html to inspect the coverage HTML file

Environment

Node.js version: 20.9.0
NPM version: 10.1.0

For anyone stumbling upon this: Pin @storybook/react-webpack5 to 7.5.3. Anything higher breaks the report for JSX.
You can safely run all the other Storybook deps at latest (currently 7.6.4) though.

Same problem, istanbul/nyc/storybook was missing files in the coverage report. Pinning @storybook/react-webpack5 to 7.5.3 worked.

same issue for @storybook/react-vite 7.6.16

Looks like this change might be responsible.
From https://storybook.js.org/docs/api/main-config-babel#babelconfig

The options provided by Babel are only applicable if you've enabled the @storybook/addon-webpack5-compiler-babel addon.

We added @storybook/addon-webpack5-compiler-babel and coverage issues were fixed with 7.6.14

Same issue with @storybook/react-vite: 8.1.10. I am not using @storybook/react-webpack5 at all.
If my component looks like this I get coverage:
export function Greeting({ name }: { name: string }) {
  if (name) {
    return `Hello ${name}!`;
  }
  return 'Hello!';
}

But if my component looks like this I get no coverage:
export function DomactInfoCard({ name }: { name?: string }) {
  if (name) {
    return
Hello {name}!
;
  }
  return
Hello!
;
}

Getting the same issue with 8.1.10. Will try downgrading Vite version to see if it has any effect

I was actually able to fix it by upgrading everything in my project with npx sb@latest upgrade.
Relevant versions:

storybook: 8.1.11
@storybook/react-vite: 8.1.11
@storybook/addon-coverage: 1.0.4
@nx/storybook: 19.3.2
@storybook/addon-coverage/node_modules/istanbul-lib-instrument: 6.0.2


Add option to change the default domain (localhost) when connecting to Azure Storage Emulator.

Where I work we run azure storage emulator on a custom IP address instead of localhost, some people run it on a specific domain name. The problem is that there seems to be no way to change the connection string in the Storage Explorer unless you manually modify this file:
C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\out\CloudHub\js\Providers\Azure\Producers\AzureStorageProducer.js
Changing the connection string in that file seems to solve the problem but to be honest it would be better to be able to do this through the UI.

@diegonzls The default emulator location for most users is the local host, but you shouldn't have to change that. The only difference between the Emulator node and any other node is the Emulator node has a predefined connection string. If you have a connection string to your emulator, you can connect to it the exact same way as you would to any Azure resource.

We are adding support for HTTPS to Azurite and with so, the recommended hostname is localhost instead of <IP_ADDRESS>.
I would like us to allow a user to specify a hostname override on this form:

@jongio Gotcha. We can consider that in a future version.

Please do consider this.
I'm getting this issue when attempting to connect to Azurite using Storage Explorer now due this host name issue.
Unable to retrieve child resources.

Details:
{
  "name": "FetchError",
  "message": "request to https://<IP_ADDRESS>:10000/devstoreaccount1?comp=list&include=metadata failed, reason: Hostname/IP does not match certificate's altnames: IP: <IP_ADDRESS> is not in the cert's list: ",
  "stack": "FetchError: request to https://<IP_ADDRESS>:10000/devstoreaccount1?comp=list&include=metadata failed, reason: Hostname/IP does not match certificate's altnames: IP: <IP_ADDRESS> is not in the cert's list: \n    at ClientRequest.<anonymous> (C:\\Users\\JD0008\\AppData\\Local\\Programs\\Microsoft Azure Storage Explorer\\resources\\app\\node_modules\\se-blob-extension\\dist\\src\\index.js:2:2441854)\n    at ClientRequest.emit (node:events:513:28)\n    at TLSSocket.socketErrorListener (node:_http_client:481:9)\n    at TLSSocket.emit (node:events:513:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)\n    at emitErrorCloseNT (node:internal/streams/destroy:122:3)\n    at process.processTicksAndRejections (node:internal/process/task_queues:83:21)",
  "type": "system",
  "errno": "ERR_TLS_CERT_ALTNAME_INVALID",
  "code": "ERR_TLS_CERT_ALTNAME_INVALID"
}

DefaultAzureCredential appears to only support https so I am pretty screwed in terms of setting up a local dev environment with Azurite and Storage Explorer as far as I can see, unless I take some fairly unpalatable options.
One of either:

Proxying locally.
Hacking source code of Storage Explorer (although the above fix no longer seems to apply to the current version of storage explorer).
Creating certificates for development that include an IP address as a host.


[BUG] typing comma on mobile doesn't work

Description
As the description says
Screenshots
No response
Additional information
No response
🥦 Browser
Brave
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
None

can i be assigned to this?

can i be assigned to this?

Sure, make sure to read the contributing file properly. Good luck

can i be assigned to this?

Sure, make sure to read the contributing file properly. Good luck

noted

Hello, please the localhost is not directing me to spotify login and I have tried changing the client id from undefined and also tried putting the new redirecting url, still nothing. You can unassign me. Thank you.


typo/fix

ppa should be:
sudo add-apt-repository ppa:ondrej/php

I didn't update this repository for some time, will release an up to date version today.
Thank you.


First day of the week setting not saved

I constantly have to the first day of the week to Monday, again, every time I open Obsidian.
Am I holding it wrong? 😉

This is now fixed. Thank you for taking the time to report it. Just to update in Obsidian Community plugins.
I think you were holding it just fine ☺ rather developer bug ☺


Fixes error squiggles not clearing when warnings or tasks remain.

Fixes error squiggles not clearing when warnings or tasks remain.
Fixes unnecessary recursive self-imports.

Found these while working on #4547. I think the squiggles one is worth taking for 15.8 (to repro, import a missing module and add a syntax error, then fix either), but the self-recursive import is very safe.

I think it depends which one you fix, but fair enough.


[RFC] New Capacitor System

Prelude/Motivations
I've been looking into implementing capacitor scaling for machine energy storage and I'm personally not happy with the current implementation of capacitors. I'm using this issue as a draft for a different system, closer in nature to 1.12's system but keeping the complexity down like we attempted with the latest iteration.
Proposal
A capacitor's data will still have a base value for every single value that is pased through.
A capacitor can also "specialize" into specific features for any machine, for example alloy smelter consumption rate, sag mill buffer size etc. but can also target general properties such as buffer size on all machines, etc. The lengths to which these are actually used need to be discussed, I'm not 100% sure on the details from 1.12.2.
These specializations will then be used for scaling the appropriate value in machines. Scaling in the current system is simple linear multiplication and in 1.12.2 this appears to be configurable. I propose that instead each "specialization type" (e.g. buffer, consumption, transfer rate etc.) declares its own scaling method (so for example buffer can use power scaling, consumption linear, etc.) to make the levels have appropriate effects without needing to have extortionate values in capacitors to gain the intended effects.
I'd like for each base value to be configurable, either in mod config or in json form, however I'm unsure how that'd go yet as I'm still working out the implementation details on the above proposal, however I'm imaginging something slightly closer to 1.12.2's implementation of ICapacitorKey which will define how values are scaled and what the base value is, and each key will be defined in a big static class.
We should also consider some way of registering the capacitor specializations, either via some data driven JSON system, or a custom registry in order to support custom specializations from other addons etc. being considered for loot capacitors.
For Players
Capacitors will hopefully become easier to understand by taking some of the complexity out. I'm not really sure how to explain the above proposal in terms of gameplay yet as gameplay balancing has not yet been considered.

Merged


Please remove the google analytics "feature"

Why has this "feature" been included?
I do not want that a simple external plugin tracks all calls to the GitBlit-Server of my company. It gathers all the fully qualified path names of the files I opened using this plugin.
So your plugin got worthless for me. In the worst case I have to fork your plugin and remove the relevant code. Can you please remove the analytics!

Why has this "feature" been included?

Because I wanted it?

I do not want that a simple external plugin tracks all calls to the GitBlit-Server of my company. It gathers all the fully qualified path names of the files I opened using this plugin.

The current version, 1.6.4, only passes the version number, the host e.g. GitHub, GitLab, BitBucket selected from the settings, and the action e.g. Open or Open and Copy. Collecting usage statistics using Google Analytics has been suggested by JetBrains, see here.

So your plugin got worthless for me. In the worst case I have to fork your plugin and remove the relevant code.

Feel free to use a different plugin or make the fork.

Can you please remove the analytics!

No
Thanks

Why has this "feature" been included?

Because I wanted it?

I do not want that a simple external plugin tracks all calls to the GitBlit-Server of my company. It gathers all the fully qualified path names of the files I opened using this plugin.

The current version, 1.6.4, only passes the version number, the host e.g. GitHub, GitLab, BitBucket selected from the settings, and the action e.g. Open or Open and Copy. Collecting usage statistics using Google Analytics has been suggested by JetBrains, see here.

So your plugin got worthless for me. In the worst case I have to fork your plugin and remove the relevant code.

Feel free to use a different plugin or make the fork.

Can you please remove the analytics!

No
Thanks

@ben-gibson: Let's be constructive. How about checkbox in the options panel? It would be checked by default (= tracking enabled). Would you accept such a pull-request?

For the record. It has been removed by https://github.com/ben-gibson/jetbrains-open-in-git-host/pull/36


Add OpenStack provider

For https://github.com/giantswarm/giantswarm/issues/19400
Adds support for templating OpenStack clusters.
Adds the following OpenStack-specific flags:

--cloud
--cloud-config
--dns-nameservers
--external-network-id
--failure-domain
--image-name
--node-machine-flavor
--node-cidr
--root-volume-disk-size
--root-volume-source-type
--root-volume-source-uuid

Some of these flags will be dropped in favor of defaulting. Others will become flags common for all providers. For now we need the configurability for testing OpenStack alpha releases.

kubectl gs template cluster --help is already pretty messy, because of a lot of options, and I am worried that adding another 12 options will render it useless. That's a big side effect for all users, while the flags to be added will only serve a few.
What could we do?
Can me make the OpenStack related flags hidden, as they are meant to be used by a limited audience only (and may be removed in the future anyway)? This way we wouldn't have negative side effects for people using AWS or Azure only. But that would make the flags harder to use for those few who actually need them.
Can we structure the help output in a way that OpenStack-related flags form their own group? That would actually be a big improvement for every user.

@marians I don't really like the idea of hiding them because I want OpenStack customers to be supported just like AWS and Azure customers.
One option would be to add a subcommand under opsctl template cluster for each provider. Then, opsctl template cluster openstack could only show the flags for that provider.
Another option would be to parse the --provider flag immediately then initialize the other flags depending on its value. opsctl template cluster --provider openstack --help would show all flags including OpenStack only while opsctl template cluster --help would only show common flags. This isn't very intuitive though.
We could also write our own help message instead of using the automatically generated message.
One last option is to keep it like this until cobra merges the PR adding flag grouping support. It sounds like it will be soon. I actually saw your comment there :)
What do you think @giantswarm/sig-ux?

For reference, here is the upstream issue: https://github.com/spf13/cobra/issues/1327
I can't find a PR to close that issue. The linked PR 1003 implements grouping of commands, not flags.
I would suggest to override the flags help rendering then with our own "hard-coded" string.

Regarding the general UX concerns, we just discussed that in SIG UX. That should not block this PR in any way. I created this issue to tackle the necessary improvements independently:

https://github.com/giantswarm/roadmap/issues/605

I would suggest to override the flags help rendering then with our own "hard-coded" string.

After a team discussion, we decided to simply hide all of the provider-specific flags until we have a better solution.

^ sorry for the wrong commit - got mixed up with my CLI.


Added tag field to request

This will result in different snapshot output prefix. Currently its {tag}_snapshot.json, while by default if tag is not provided output file will be named like before snapshot.json

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 2.069%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
86

Relevant Lines:
4157

💛  - Coveralls


Extra parameters for the REST endpoint 'overlap/translation'. Will be…

… needed for a mapping to the PDB coordinates in a tool/feature using it

I believe I will have to update the test on the ensembl-rest repo

Coverage decreased (-0.009%) to 81.957% when pulling 720c069b02121dfb5326d89b0236ccbd97c94e7e on ens-lgil:master into 7eb9c015fdf82538b9ff5fe1aa06b8114ad81c9f on Ensembl:master.

Hi Laurent,
yes, but can you also add a relevant test to proteinFeature.t and/or proteinFeatureAdaptor.t if that's not too painful?
thanks

@avullo, you don't have tests about the method 'summary_as_hash'.
Do you mean I need to create tests for this method ?

That would be ideal, I saw this an an opportunity to start covering this uncovered part of the API, especially considering coverage has, even marginally decreased. Feel free to do or not do that. It could be just testing the newly added fields.

Ok, I just added few tests on "summary_as_hash"

Brilliant, well done!
Let's wait the tests then it goes in.
thanks a mil

Coverage increased (+0.03%) to 81.998% when pulling 6a946b500bbba7b0bcd22b152847fde3e260cec4 on ens-lgil:master into 7eb9c015fdf82538b9ff5fe1aa06b8114ad81c9f on Ensembl:master.


[question] cluster configuration guide

Hi, I would like to how is it possible for have following clustering setup mining core.
My current setup plan,
slave : miningcore-site1, miningcore-site2, miningcore-site3
master : miningcore-master
Slave will be running stratum port only and relay all informations to master.
On master side, it will have the persistent db and handle payment.
Now what not so clear to me is, where should i put my wallet daemon?
Does it make sense to have a setup where only master talk with wallet RPC?
Illustration,

Thanks

That's basically what coinfoundry.org is running.

How does miningcore handle communication between miner and stratum? ie "blocksubmit"
Does it goes into zmq and push to/pull from master?
I havent dive deeply into the code yet. Just try to get some sense is this configuration fully supported or require some tweaking. The goal here is to hide the wallet from slave.

@21void You could either go with one additional server for each location running the coin daemons or a master coin daemon server available to all three pool servers. Pool-Daemon communication is definitely not going through ZMQ which is exclusively used for streaming back processed shares to the master.

Thanks for the answer.
Look like I have to implement somekind of RPC call filtering to protect the wallet.

@21void You mean protect the wallet against a compromised pool site accessing the daemon?

Yes @oliverw , that is what I mean. From my understanding, once a pool is compromised, attacker can have full access to wallet via RPC call to daemon.

@21void By the way, is this for http://pool.btcprivate.org?

@oliverw Nope. Actually, havent started mine. Currently still in research mode. Looking for solution that is not only robust but  secure as well. Been trying different stratums, so far miningcore is the simplest and easy to play with.
@off topic, do we have any chatroom/slack for miningcore? Perhaps I can learn a thing or two there.

@21void There's a Gitter that's not often used https://gitter.im/miningcore/Lobby


Issues with tab and space keys ons Spyder

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
After updating the Python version on my computer, Spyder started giving me some weird problems. The tab key and the space key won't work.
also, when I hit the space keyboard, it resizes the window. I tried updating these on the preference but it won't work
I get this on the terminal

What is the expected output? What do you see instead?
to be able to indent and unindent using the tab key and space to make spaces between code.


(vcredist140) Fails installation on 64bit system when --x86 is used for parent package

We are using choco as an easy way to install (and update) software inside our containers.
we need to install the 32-bit python into a base Microsoft image,
The issue is reported by my colleague Chris Hopkins to the choco package maintainer here...
https://community.chocolatey.org/packages/python3/3.10.1
We think maybe it's a choco issue?
Expected Behavior
it works :-).
python3 32bit is installed.
Current Behavior
get an Error

Download of VC_redist.x86.exe (13.06 MB) completed.
Hashes match.
Installing vcredist140-x86...
vcredist140-x86 has been installed.
ERROR: This package does not support 32 bit architecture.
vcredist140 can be automatically uninstalled.
The install of vcredist140 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\vcredist140\tools\chocolateyInstall.ps1'.
See log for details

Steps to Reproduce (for bugs)
Get a PowerShell terminal in a docker container...
docker run --rm -it  mcr.microsoft.com/dotnet/framework/runtime:4.7.2-windowsservercore-ltsc2019 powershell
install choco inside the Container.
iex ((New-Object System.Net.WebClient).DownloadString("https://chocolatey.org/install.ps1"));
use choco inside the container to install python3, forcing 32 bit (--x86).
choco install python3 --version=3.10.1 -y --no-progress --reduce-package-size --x86 --installargs 'InstallAllUse
rs=1 Shortcuts=0 Include_doc=0 Include_pip=1 Include_test=0'
Context
we are using choco as an easy way to install (and update) software inside our containers.
we need to install the 32-bit python onto this base Microsoft image,
Your Environment
Docker desktop installed and set to windows containers and hyper-v isolation.
Docker image as above.

This looks to be an oversight in the vcredist140 package and not a problem with the python3 package itself.
The --x86 argument gets inherited by any dependent package as well, for now I would recommend that you install the dependency vcredist140 first without the --x86 argument before installing the python3 package itself.
At least until we have a fix available for the problem in the package.

Thanks for taking the time to look.
I can confirm that running
choco install vcredist140 -y --no-progress --reduce-package-size
before the python 32bit install is a successful 'workaround' for us.  :-)

Good to know that is a workaround for you, I do hope to look back into this when I have more time to work on this repository so that workaround won't be necessary for the future.
/cc @jberezanski for visibility

@jberezanski Are you able to look at this?

Fixed and pushed, versions:
14.31.31103.20220402 (Visual Studio 2022 stream)
14.29.30139.20220402 (Visual Studio 2019 stream)
14.16.27033.20220402 (Visual Studio 2017 stream)

However,

The --x86 argument gets inherited by any dependent package as well,

I don't like this behavior. I understand its usefulness in one narrow use case (metapackages depending on *.install), but in general I believe it is actively harmful, same as --apply-package-parameters-to-dependencies / --apply-install-arguments-to-dependencies (fortunately false by default).
Here, for example, only the 32-bit VC++ runtime will be installed as a dependency of python3, but the vcredist140 package will be considered fully installed by choco. Subsequent installation of some 64-bit software depending on the VC++ runtime will not trigger installation of the 64-bit runtime and the application will not work.


Sergio

Can one of the admins please verify this patch?

big sorry, wanted to pr to the develop branch of my team fork of the project and by mistake pr'ed to the main one. :S

No problem :D


Don't Work twitter-user... just appear "via @"

PR #49 should fix this issue

Hello @jdbrocca, sorry for the regression, a fix has been released https://github.com/nicolasbeauvais/vue-social-sharing/releases/tag/v2.2.8


Update meshkit version and meshmodel types

@MUzairS15 After updating the meshkit version, it also needs some types changes. But some types doesn't exist, do you know  what types they are now?


Text Editor

This feature enhances the game by allowing players to write and save their own notes, plans, or even basic scripts directly in the game interface.
When the player types edit , the game opens a basic editor where they can write multiple lines.

This implements a text editor, but it edits files and not nanobot logic. You should be editing the player.nano objects.


chore: spike on skeletons

This PR resolves []
Description
This is an early spike on how we can get the right skeletons ahead regardless of the rails order.
The idea here is simple, get the available sections and the order without data -> Use that for drawing skeletons while the data is coming from the nested query.
This adds of course an extra query to all home screen fetches - it is however a cheap one since does only one trip to MP and comes back without talking to any other services.

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 812eec2728d15b6df8f2f547414a139525fc5f64

I could see this working for legacy sections which almost all appear. For the new experience, I worry that Metaphysics may have to load all of the related data in order to determine the visible, personalized sections for a given user. Requesting the sections first and the data next might end up doing twice the work. We can wait and see if that is indeed an issue though.


Next NPM version

I've noticed that some features are not published yet to NPM. For example the Fields.radio() feature.
When are you planning to release a new version?
Thanks

@IGZgustavomarin great question! Just released! :+1:
Probably we need to write few words about release policy. Would love to get some contributions on that.


Error: Unable to run the browser

What is your Test Scenario?
Just running the steps from TestCafe Getting Started guide, here https://devexpress.github.io/testcafe/documentation/getting-started/
What is the Current behavior?

Try to perform the steps in the TestCafe Getting Started guide.
From a Windows command prompt, enter the command: "testcafe ie test1.js"
Upon issuing that command, the output appears to be escape codes for coloring the text. This is the output that gets shown in the command prompt window:

[?25l?[2K?[1A?[2K?[G?[36m|?[39m
?[?25l?[2K?[1A?[2K?[G?[36m/?[39m
?[?25l?[2K?[1A?[2K?[G?[36m-?[39m
?[?25l?[2K?[1A?[2K?[G?[36m?[39m
?[?25l?[2K?[1A?[2K?[G?[36m|?[39m
?[?25l?[2K?[1A?[2K?[G?[36m/?[39m
?[?25l?[2K?[1A?[2K?[G?[36m-?[39m
?[?25l?[2K?[1A?[2K?[G?[36m?[39m
?[?25l?[2K?[1A?[2K?[G?[36m|?[39m
?[?25l?[2K?[1A?[2K?[G?[36m/?[39m
?[?25l?[2K?[1A?[2K?[G?[36m-?[39m
?[2K?[1A?[2K?[G?[31mERROR ?[39mWas unable to open the browser "chrome:" due to error.
Error: Unable to run the browser. The file at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe does not exist or is not executable.
at Object.callee$0$0$ (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\lib\api\open.js:137:23)
at tryCatch (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)    at Generator.invoke [as _invoke] (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:334:22)
at Generator.prototype.(anonymous function) [as throw] (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:105:21)    at tryCatch (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at invoke (C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:146:20)    at C:\Users\UserName\Documents\TestCafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:156:13
What is the Expected behavior?
browser is launched and test runs
Steps to Reproduce:
Follow steps describe in the TestCafe Getting Started Guide - here: https://devexpress.github.io/testcafe/documentation/getting-started/
Your Environment details:

testcafe version:                   1.4.1
node.js version:                    10.16
command-line arguments:  testcafe ie test1.js
browser name and version: IE 11 (11.765.17134.0), Chrome 75.0.3770.142, Edge 42.17134.1.0
platform and version:          Windows 10 Enterprise (builds 1703 and 1803)
other:                                   This issue happens on 4 different PC's

-This issue also exists when trying to run on Chrome or Edge.
-Also tried running with command line:
testcafe "path:`C:\Program Files\Internet Explorer\iexplore.exe'" test1.js
-Also tried running with command line:
testcafe "chrome:C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" test1.js
-Also tried running command line:  "testcafe -b", and it found all the installed browsers: chrome, ie, edge

Thank you for your report.  Please install a debug build, run it with the following commands and share its output in this thread:
npm i -g https://git.io/fj7CF
set CI=1
testcafe -v
testcafe chrome tests

@AndreyBelym
Sorry for taking so long to get back to you, was out on vacation.
Here is the output captured from the command prompt window from the steps you described above:

C:\TestCafe_TM>npm i -g https://git.io/fj7CF
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Please, upgrade to core-js@3 or at least to actual version of core-js@2.
C:\Users\mjala\AppData\Roaming\npm\testcafe -> C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\bin\testcafe-with-v8-flag-filter.js

<EMAIL_ADDRESS>postinstall C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\core-js
node scripts/postinstall || echo "ignore"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:

https://opencollective.com/core-js
https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

<EMAIL_ADDRESS>added 427 packages from 295 contributors in 19.947s

C:\TestCafe_TM>set CI=1
C:\TestCafe_TM>testcafe -v
1.4.0-rc.1
C:\TestCafe_TM>testcafe chrome myfirsttest.ts
TCC: (Sys) The system cannot find the file specified.
".\chrome.exe"
[31mERROR [39mWas unable to open the browser "chrome:" due to error.
Error: Unable to run the browser. The file at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe does not exist or is not executable.
Error: Process start /D "C:\Program Files (x86)\Google\Chrome\Application" .\chrome.exe --remote-debugging-port=42318 --user-data-dir=C:\Users\mjala\AppData\Local\Temp\testcafe\chrome-profile-19248LtkTzbyVcHZv --disable-infobars --disable-session-crashed-bubble --no-first-run --new-window http://<IP_ADDRESS>:42316/browser/connect/TLLJDtp exited, code 2
at ChildProcess. (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\lib\utils\exec.js:118:34)
at ChildProcess.emit (events.js:198:13)
at ChildProcess.EventEmitter.emit (domain.js:448:20)
at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
at Object.callee$0$0$ (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\lib\api\open.js:137:23)
at tryCatch (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at Generator.invoke [as _invoke] (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:334:22)
at Generator.prototype.(anonymous function) [as throw] (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:105:21)
at tryCatch (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at invoke (C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:146:20)
at C:\Users\mjala\AppData\Roaming\npm\node_modules\testcafe\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:156:13
at process._tickCallback (internal/process/next_tick.js:68:7)
[90mType "testcafe -h" for help.[39m

The first error seems to indicate that the browser does not exist or is not executable, but it does exist, so perhaps there is a problem executing it? Perhaps a security setting needs to be changed?
I put that path to chrome in the command prompt and chrome was launched. Attached is a screenshot showing that chrome is at that path:

More info...
We are using Take Command/4NT for our ComSpec (command prompt). We need this for some of the other scripts that we run. We are using version:  Take Command v12.10.59 x64.  See: https://jpsoft.com/all-downloads/previous-versions.html  (closest available appears to be v12.11)
This may be the key difference as to why we are seeing this issue and others do not.

Hi @tgrodano
Thank you for the provided details. We will continue to investigate the problem.


Library downloaded/published will not load after upgrading from legacy

I upgraded from lbry 0.6.9 or so to latest 0.12.0, when going to downloads/publishes, it just sits on Loading... forever. I can see it running through lbry URLs for things I've download/published in the past in the console. Here are some potentially useful console warnings/errors, betting it's the last one:
2017-06-17 22:29:12,812 WARNING  lbrynet.core.sqlite_helpers:14: database was locked. rerunning <function save_name_metadata at 0x7fc698848578> with args (<lbrynet.core.Wallet.SqliteStorage object at 0x7fc696461310>, u'five', 6e0b0aedbe119fb3aafe89bf0c280464d11c77ab38dd9d45d10e40168b4d462e:1, '8be699fd598f2d6a5bc12490e375ff92f63eaedad7948f5d87f2ea43279ec674d4212022158d717eb34e97ddfd181ecb'), kwargs {}
2017-06-17 22:29:07,769 WARNING  lbrynet.core.Wallet:738: lbry://four#70a4753a0648d45346580c5c3dd5363e417d6a02 has an invalid signature
2017-06-17 22:28:45,074 ERROR    lbrynet.lbrynet_daemon.auth.server:346: Failed to process file_list: string indices must be integers
Traceback (most recent call last):
File "site-packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
File "site-packages/lbrynet/core/Wallet.py", line 770, in _handle_claim_result
File "site-packages/lbryschema/claim.py", line 140, in load_dict
File "site-packages/lbryschema/encoding.py", line 33, in decode_fields
TypeError: string indices must be integers
About
Your copy of LBRY is up to date.
daemon (lbrynet)	0.11.0
wallet (lbryum)	2.7.25
interface	0.12.0
Platform	Linux (Linux-4.4.0-75-generic-x86_64-with-Ubuntu-16.04-xenial)
Installation ID	3n1vtReZyaeUpTweiXPuVF7ncX1HVAKj3mJp9Lhpns71kbh6c9yv8yDzHenokJWRfc

It's a known issue, we have it logged under here https://github.com/lbryio/lbry/issues/661

@kimihiro64 can you see if this is still happening on 0.13? Personally I still have trouble with the download/published  list showing, but I don't get the 'string indices must be integers'. Instead, I have a Unicode issue which should be fixed soon (not in any build)
Please try again on 0.13 and repost log.

It sounds like @kimihiro64 already rescued his credits and reset his install from other messages. I am fairly confident that these issues were from old data that wasn't properly migrated, so looking into these issues will be low priority compared to issues affecting all users.
I'm going to close this, but please re-open if there is an issue we think still currently affecting anyone.


avoid use of undefined ABSL_HAVE_ELF_MEM_IMAGE

this avoids e.g. on macOS:
In file included from abseil-cpp/absl/debugging/internal/elf_mem_image.cc:18:
abseil-cpp/absl/debugging/internal/elf_mem_image.h:37:5: error: 'ABSL_HAVE_ELF_MEM_IMAGE' is not defined, evaluates to 0 [-Werror,-Wundef]
^
1 error generated.

I signed it!

CLA should now be ok and matching my mail address.
Only checking for "is defined" now.

Sure, thanks for taking care.
I assume I will have a few other warning fixes in the future as we use rather strict compiler flags for the code using the abseil headers (together with MSVC).

Sorry for the delay. I am the release manager this week and I will test this change against our internal code base asap.


Is it possible to find out which attribute it failed at when you are calling the fromMap in MapperComplex.java

Here is the method
 public   T fromMap(final Map<String, Object> map, final Class cls) { ..}
When I am passing in the map  with "birthday" & value "1231/12".
I am getting an SoftenedException with the erorr message that it is unable to parse to US date.
Is it possible to also the field at which exception occurred?
For example, The softenedException will have a field attribute where you can see the parsing failed at the attribute "birthday".
Thank you

It shows you exactly where the exception occurred in the JSON stream.
Also please include actual results and expected results in the bug report.
Also let me know if this is a feature request or a bug report. Either way. I need to know current results and expected results.


can not find consul all ref in spring cloud Brixton.M3 parent

Hi,
I want to use consul with spring-cloud-Brixton M3. But I could not find spring-cloud-consul-all 1.1.0.M4 ref in Brixton parent pom and found nothing in central repos. Need I download M4 code and compile it by myself ?

Brixton.RELEASE is the latest. Try and use that first.

I think you mean spring-cloud-starter-consul-all? It's there in the Brixton.RELEASE.


have no idea what this is

Hi, im running powerranks (1.10.5r2) on a 1.18.2 server.
It keeps giving this error :java.lang.NullPointerExceptionCannot invoke "nl.svenar.common.structure.PRRank.getWeight()" because "rank" is null
I have no idea what this means or if there is an easy fix for this and since theres some weird stuff going on with the perms and ranks i have no idea if this error that keeps popping up every 3 seconds is the cause of it.
This is the full error and what it says after it in the console: https://www.toptal.com/developers/hastebin/ebolivejih.yaml
Thanks

this issue can be solved within the discord server

This is indeed a bug (code) and will be fixed in the next release

aight whens next release planned?

No release date for the next version is available yet.

aight thanks o/


chore: add verbosity for partially filled upstream conf

@moshloop Self merging for now, if we need to add something, will do that in a separate PR


react-native-share: Android compiler error

Hi, I am getting following error when trying to compile the react-native project. It will be gr8 pleasure, if anyone help me help me urgently. I have done all the steps suggested for andoid setup...
Error:Project :app declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :react-native-social-share.

It was my mistake I was not removed react-native-social-share :) as I am using react-native-share.


Incomplete Message Received When Sending Message Larger Than Buffer Size Using NamedPipes

I am currently using NamedPipes from System.IO.Pipes in conjunction with MultiplexingStream and I've encountered an issue where sending a message that is larger than the buffer size results in an incomplete message being received on the other end.
I've attempted to create a simple reproducible case, but oddly enough, the issue doesn't seem to manifest in the reproducible environment, only in my actual application. I'm unable to pinpoint the exact cause of this issue and was hoping someone might have some insights or suggestions as to what could be causing this.
Here is the relevant section of my code:
// Sender:
var iStream = channel.Input.AsStream();
var oStream = channel.Output.AsStream();

var data = await JsonSerializer.DeserializeAsync<TData>(iStream);
var result = await handler(ctx, data);
await JsonSerializer.SerializeAsync(oStream, result);
await oStream.FlushAsync();
await oStream.DisposeAsync();

await channel.Output.CompleteAsync();

// Receiver:
var iStream = channel.Input.AsStream();

var ms = new MemoryStream();
await input.CopyToAsync(ms);
ms.Position = 0;
var msString = Encoding.UTF8.GetString(ms.ToArray());
return await JsonSerializer.DeserializeAsync<TResponse>(ms);

I can provide access to the actual application for anyone who might be able to assist with this issue. Any help or guidance would be greatly appreciated. Thanks in advance!
Expected behavior
When sending a message, even one that is larger than the buffer size, the entire message should be received intact on the other end.
Actual behavior
When sending a message that is larger than the buffer size, an incomplete message is received on the other end.
Possible Solution
Unknown at this time. It seems to work in a reproducible environment, but not in the actual application.

After some debugging i found out that adding a delay of 50ms in the sender,  before the completion "solves" the issue.
There seems to be a race condition somewhere in the  library.
var ms = new MemoryStream();
await JsonSerializer.SerializeAsync(ms, result);
ms.Position = 0;
var msString = Encoding.UTF8.GetString(ms.ToArray());

//await ms.CopyToAsync(oStream);

var fres = await channel.Output.WriteAsync(ms.ToArray());
await channel.Output.FlushAsync();
await Task.Delay(50);
await channel.Output.CompleteAsync();

Update: The channel was disposed after flush&completeAsync which led to the channel being disposed before the pending data was sent.
Looks counter intuitive to me

The issue is that you're explicitly disposing channels. This is counter to the API docs, which mentions the outcome you're seeing specifically:
https://github.com/dotnet/Nerdbank.Streams/blob/17998b25c219d525600fb839eeae2ec3200c15b5/src/Nerdbank.Streams/MultiplexingStream.Channel.cs#L327-L330

@AArnott Yes, i understand that now. But still, i expected pipewriter.flushasync to wait until the data is flushed to the remote.
If that's not possible, could something be implemented which waits for the current buffered data to be sent?

PipeWriter.FlushAsync doesn't behave like Stream.FlushAsync. Its documented behavior is merely that it makes the buffer available to the reader. In the case of a MultiplexingStream.Channel, the reader is also in the same process as you, as it's reading what you've written and transmitting it across the multiplexing stream. But when you dispose the channel, you cut off the transport over which transmission happens.
So I'm afraid offering a Complete() method and a Completion property for you to await on is the best thing I can offer.


Add brew_reinstall rule

Replaces install with reinstall when a package is already installed.

Wow, thanks for the quick merge!

Inception:


pip package out of date

i just noticed current Github Release is not matching pip.
Is this behavior intentional or bug as relevant GH Action didn't run @mshriver ?

@laDok8 thanks for the heads up!
https://github.com/RedHatQE/wrapanapi/actions/runs/3514726746/jobs/5889097853
I forced the tag for 3.5.13 to the HEAD commit, which included the GHA definition. The last tag wasn't pushed by travis.

Both #458  and #459 were added to address this, and move the repo forward.

https://pypi.org/project/wrapanapi/3.5.13/
Updated package is now available, @laDok8 has your issue been resolved?


New Storyboard and ViewController

Add segmented control and constraints to storyboard. Better display in
any devices and orientations using constraints.

Thank you for your project. I just update exemple code with a new storyboard for a better understanding of RingGraph on all devices.
Feel free to accept / modify my code

Hey @iLandes, your new layout looks pretty nice. Previously I aimed for the iPad mainly and this is a great upgrade. Thanks!

Your welcome, your RingGraph is pretty cool. Doing that help me to discover your code and use it in a future app.


NativeError should copy other properties too

https://nodejs.org/api/errors.html
By nodejs there is an error code and a system call property which should be copied to the NativeError if we want to force people to use it. Probably a for-in would be better by copying properties.

Closing in favor of #44


Add snowmachineconfig check in snow reconcilier

Issue #, if available:
Description of changes: 1) Add snowmachineconfig check 2) add unit test for snow reconciler
Testing (if applicable): unit test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/retest


Incorrect variance in normalization layer of EfficientNet

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04.5 LTS (Google Colab)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.5.0-0-ga4dfb8d1a71 2.5.0
Python version: 3.7.10
Bazel version (if compiling from source): n/a
GCC/Compiler version (if compiling from source): n/a
CUDA/cuDNN version: n/a
GPU model and memory: n/a

Describe the current behavior
EfficientNet includes a normalization layer within its model definition, but it seems like the variance is incorrect. The variance is [0.229, 0.224, 0.225], but those values are the standard deviations of the ImageNet dataset. When the normalization layer is called on new inputs, the inputs are normalized using the mean (which looks correct) and the square root of the variance. So in the current EfficientNet implementation, inputs are normalized using the square root of the standard deviation of ImageNet.
Describe the expected behavior
I expect inputs to EfficientNet to be normalized according to the standard deviation of the ImageNet dataset.
Contributing - Do you
want to contribute a PR? (yes/no): no, because I don't know where I would make this change. The change would have to be within the saved models.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import numpy as np
import tensorflow as tf

model = tf.keras.applications.EfficientNetB0(weights="imagenet")
norm_layer = model.layers[2]
assert "normalization" in norm_layer.name
print(norm_layer.mean.numpy())  # [0.485 0.456 0.406]
print(norm_layer.variance.numpy())  # [0.229 0.224 0.225]
# Generate sample inputs.
tf.random.set_seed(42)
x = tf.random.uniform((1, 224, 224, 3), 0, 255, dtype="int32", seed=42)

def get_reference(inputs):
    """Get the reference normalized outputs."""
    x = np.asarray(inputs).astype("float32")
    x /= 255.0
    x[..., 0] -= 0.485
    x[..., 1] -= 0.456
    x[..., 2] -= 0.406
    x[..., 0] /= 0.229
    x[..., 1] /= 0.224
    x[..., 2] /= 0.225
    return x

def get_current_tf_efficientnet_norm_output(inputs):
    """Get the normalized outputs from the current implementation."""
    x = np.asarray(inputs).astype("float32")
    x /= 255.0
    x[..., 0] -= 0.485
    x[..., 1] -= 0.456
    x[..., 2] -= 0.406
    x[..., 0] /= np.sqrt(0.229)
    x[..., 1] /= np.sqrt(0.224)
    x[..., 2] /= np.sqrt(0.225)
    return x

model_normalizer = tf.keras.Model(model.input, norm_layer.output)
# Below is True (they are the same)
np.allclose(get_current_tf_efficientnet_norm_output(x), model_normalizer(x), atol=1e-07)
# Below is False (they are different)
np.allclose(get_reference(x), model_normalizer(x), atol=1e-07)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
The Normalization layer normalizes using the square root of the variance (which equal to the standard deviation)

Could replicate the issue with Tensorflow Version 2.5. Please find the Gist. Thanks!

Thanks for reporting the issue. When I look at the original implementation from the paper in https://github.com/tensorflow/tpu/blob/master/models/official/efficientnet/efficientnet_model.py#L505, I didn't find any normalization layer for the inputs. (The rescale in expected in keras.application model to mimic https://github.com/tensorflow/tensorflow/blob/a4dfb8d1a71385bd6d122e4f27f86dcebb96712d/tensorflow/python/keras/applications/imagenet_utils.py#L190).
@fchollet, since the original implementation is added by you, could u provide more context about why the normalization layer is added?

My experiment using tf.keras.applications.EfficientNetB0 with TensorFlow 2.4.2 on ILSVRC2012 validation set only achieve ~74.6% of accuracy.
After fixing this problem by:
    mean, std, a = model.layers[2].get_weights()     model.layers[2].set_weights([mean, std**2, a])
the result increased to 77.2%, as in the paper.

The Keras implemention of EfficientNet is a re-implemention of reference code. Normalization function and args can be found at here and here.
It normalizes the data by x = (x - mean * 255) / (std * 255) and can be split into 2 steps: x = x / 255 for rescale and x = (x - mean) / std for normalization.
The normalization layer in tf.keras normalizes the data using mean and variance, and applys x = (x - mean) / sqrt(variance) to inputs, but it is standard deviation in current pre-trained weights of tf.keras.applications.efficientnet, so it applys x = (x - mean) / sqrt(std) to inputs, which is incorrect.

@fanstvn If there is any actionable PRs, please feel free to open them in keras-team/keras repository.
Please note that Keras development moved to keras-team/keras repository to focus entirely on only keras. Thanks!

@jvishnuvardhan - ok -- the rescaling weights of the trained model will have to be updated. can you transfer this pr to the keras repository? this pr was made while keras was still being developed in this repository.

I will take a closer look and fix this issue. Sorry for the long wait.

I was able to verify the correctness of fix by following code snippet.
import tensorflow_datasets as tfds
import tensorflow as tf

model = tf.keras.applications.EfficientNetB0(weights="imagenet")

BATCH = 128

def resize_and_center_crop(image: tf.Tensor, size: int) -> tf.Tensor:
  h, w = tf.shape(image)[0], tf.shape(image)[1]

  # Figure out the necessary h/w.
  ratio = (tf.cast(size, tf.float32) / tf.cast(tf.minimum(h, w), tf.float32))
  h = tf.cast(tf.round(tf.cast(h, tf.float32) * ratio), tf.int32)
  w = tf.cast(tf.round(tf.cast(w, tf.float32) * ratio), tf.int32)
  image = tf.image.resize(image, [h, w])
  top = (h - size) // 2
  left = (w - size) // 2
  image = tf.image.crop_to_bounding_box(image, top, left, size, size)
  return image

def eval_preprocess(features):
  image = features["image"]
  label = features["label"]
  assert image.dtype == tf.uint8
  image = tf.cast(image, tf.float32)
  # image = tf.keras.applications.resnet50.preprocess_input(image)
  image = resize_and_center_crop(image, 224)
  label = tf.one_hot(label, 1000)
  return image, label

dataset_builder = tfds.builder("imagenet2012")
eval_ds = dataset_builder.as_dataset(split='validation')
eval_ds = eval_ds.map(eval_preprocess, num_parallel_calls=tf.data.AUTOTUNE).batch(BATCH)

norm_layer = model.layers[2]
assert "normalization" in norm_layer.name
print(norm_layer.mean.numpy())  # [0.485 0.456 0.406]
print(norm_layer.variance.numpy())  # [0.229 0.224 0.225]
existing_variance = norm_layer.variance.numpy()

correct_variance = tf.math.square(existing_variance)
norm_layer.variance = tf.convert_to_tensor(correct_variance)

model.compile(metrics=['categorical_accuracy'])
model.evaluate(eval_ds, verbose=1)

# validation acc is 77.0

This should be fixed now in keras.