Filter output of docker images

Current output:
REPOSITORY                                           TAG                 IMAGE ID            CREATED             SIZE
homeassistant/amd64-builder                          latest              e3cebba27d39        1 second ago        716MB
homeassistant/amd64-base-ubuntu                      18.04               5280d4156ab4        18 hours ago        85.3MB
homeassistant/amd64-builder                          <none>              fad53788139a        24 hours ago        710MB
node                                                 10                  56387899b840        2 weeks ago         911MB
node                                                 12                  1f560ce4ce7e        2 weeks ago         918MB
buildpack-deps                                       stretch             b39de549c36a        2 weeks ago         835MB
buildpack-deps                                       buster              f3f98451c17d        2 weeks ago         804MB
debian                                               9                   c4ccba324c9c        2 weeks ago         101MB
debian                                               8                   091099bf65ad        2 weeks ago         129MB
node                                                 12-alpine           d8b74300d554        2 weeks ago         89.6MB
node                                                 10-alpine           57006130ce4b        3 weeks ago         83.5MB
ubuntu                                               14.04               df043b4f0cf1        5 weeks ago         197MB
jekyll/builder                                       latest              a8007cad4069        7 weeks ago         677MB
alpine                                               3.9                 78a2ce922f86        6 months ago        5.55MB
alpine                                               3.10                be4e4bea2c2e        6 months ago        5.58MB
alpine                                               3.8                 c8bccc0af957        9 months ago        4.41MB
alpine                                               3.7                 6d1ef012b567        20 months ago       4.21MB
mcr.microsoft.com/azure-pipelines/node8-typescript   latest              9a948d360778        2 years ago         595MB

With this change:
REPOSITORY:TAG                                                         SIZE
homeassistant/amd64-builder:32ca727c849578dc441e037a8fbe574b295d0b86   716MB
homeassistant/amd64-builder:latest                                     716MB
<none>:<none>                                                          716MB
homeassistant/amd64-base-ubuntu:18.04                                  85.3MB
homeassistant/amd64-builder:<none>                                     710MB

Another alternative is to list images before building, and checking images after, and compare against it

Yes, we need an before and after

Expanded the action to pull the image earlier so we get the ID for it, and then using the since filter to get all images created after that


Replace of seg_ms_lesion_mp2rage by UNIseg model on sct_deepseg

Description
This PR replace the current seg_ms_lesion_mp2rage model by UNIseg (single-class 3D nnUnet model discused here #75 ) keeping the same name:  seg_ms_lesion_mp2rage (after comparisons these models see #81 )
Updates also the README file, explaining how to use the model, datasets for training and acknowledgments to the collaborators.

@Nilser3 indicate where to find model to test

Thanks you @jcohenadad
The model is here https://github.com/ivadomed/model_seg_ms_mp2rage/releases/tag/r20240610
I have already replaced the seg_ms_lesion_mp2rage model and it is ready to be tested this branch:
SCT log: 86d5f8d5a473e5e034d365726a548d96776da755
branch: nlm/update-_seg_ms_lesion_mp2rage-model

Getting this message during inference:
/Users/julien/code/spinalcordtoolbox/python/envs/venv_sct/lib/python3.9/site-packages/nnunetv2/utilities/plans_handling/plans_handler.py:37: UserWarning: Detected old nnU-Net plans format. Attempting to reconstruct network architecture parameters. If this fails, rerun nnUNetv2_plan_experiment for your dataset. If you use a custom architecture, please downgrade nnU-Net to the version you implemented this or update your implementation + plans.
  warnings.warn("Detected old nnU-Net plans format. Attempting to reconstruct network architecture "

any concerns?

Another message, possibly concerning:
Found Intel OpenMP ('libiomp') and LLVM OpenMP ('libomp') loaded at
the same time. Both libraries are known to be incompatible and this
can cause random crashes or deadlocks on Linux when loaded in the
same Python program.
Using threadpoolctl may cause crashes or deadlocks. For more
information and possible workarounds, please see
    https://github.com/joblib/threadpoolctl/blob/master/multiple_openmp.md

Inference time is pretty long... I've tried without cropping on the basel data, inference time was 4min 6s.
With cropping:

Related question: the progress bar shows 100 iterations:
 19%|█████████████████████████████▊                                                                                | 19/100 [00:42<02:52,  2.14s/it]

What to these correspond to? And how come the number of iterations is the same across different input volume size?

Comparison with previous model, and current model with various crop sizes:

Conclusion: too narrow cropping (5x5x5) leads to bad segmentation. A minimum cropping size is required. What size? @Nilser3 that's a follow-up investigation

Conclusion: too narrow cropping (5x5x5) leads to bad segmentation. A minimum cropping size is required. What size? @Nilser3 that's a follow-up investigation

follow-up idea: given that the inference is sliiiiightly different across crop sizes, how about computing a soft segmentation based on the inference performed across various crop sizes?

The zipped model does not seem to include the list of subjects used for training and the version of the dataset used to train the model. It is required.

Thank you @jcohenadad,
Ok, the release r20240610 has been updated with the needed information!

@Nilser3 any update?

@Nilser3 any update? this is becoming urgent: https://forum.spinalcordmri.org/t/segmentation-of-spinal-cord-lesion-on-mp2rage-uni-images-doesnt-work/1302

The model was replaced in the release 6.4, this branch is ok for PR.


Readme cleanup

When using the readme, I've hit a couple of issues that create extra confusion or unnecessary overhead. So I've:

removed extra redirections
added HTTPS by default on all www.algolia.com
since www.algolia.com has HSTS, the browser will do it automatically but if it a first request, there is unnecessary delay in reaching the documentation caused by the redirection to HTTPS
fixed non-existent anchors to the documentation
most of the used anchors don't exist in the documentation anymore and the URLs had old format

Keep in mind we need to replicate the changes here https://github.com/algolia/algoliasearch-client-readme-generator as well.

Hmm, seems like I have merged a wrong repo. I have the change ready even for the parent repo ;)

On 14 Feb 2016, at 14:16, Sylvain Utard<EMAIL_ADDRESS>wrote:
Keep in mind we need to replicate the changes here https://github.com/algolia/algoliasearch-client-readme-generator as well.
—
Reply to this email directly or view it on GitHub.

Here is the PR in the parent repo: https://github.com/algolia/algoliasearch-client-readme-generator/pull/18

So we close this one?


Wrong LoRA Weights?

Hi, I have tried navigating your model via the instructions you have provided but with no success. After completing the set-up, I tried running a simple Text-to-Text inference but with no success. The model outputs repetitive word tokens that do not make sense (image below). After testing the weights for Vicuna and LLaMA separately and realising that this is not the problem I proceeded with checking the code-base. The way I achieved for the model to perform the basic Text-to-Text task was by disabling the LORA weights all together. However, after that I was of course not able to trigger any other modality...

Hi, this is my result. I cannot generate reasonable results as well. Have you solved it?

Hi @WenjiaWang0312 , if you want to resolve this issue you must disable the LoRA weights. However, that will only allow you do to text-to-text and not the cross-modality


Refreshing the wrappers for Sundials 6.6

This PR now has the newly generated C wrappers for Sundials 6.5. The package needs to be updated to match the changes in the wrappers.
There's some new ARKRhsFn_wrapper thing that needs to be dealt with (among other things). But at least the clang generators are now running through.
cc @ChrisRackauckas

➜  gen git:(vs/sundials_wrappers) ✗ ~/julia/julia --project generate.jl
[ Info: Parsing headers...
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:61:47: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:64:59: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:68:54: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:61:47: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:64:59: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:68:54: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:61:47: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:64:59: error: unknown type name 'FILE'
/Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h:68:54: error: unknown type name 'FILE'
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_arkstep.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_bandpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher_dirk.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_butcher_erk.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_erkstep.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/arkode/arkode_mristep.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_bandpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_diag.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_proj.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvode/cvode_spils.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_bandpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_diag.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_proj.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/cvodes/cvodes_spils.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/ida/ida.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/ida/ida_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/ida/ida_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/ida/ida_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/ida/ida_spils.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/idas/idas.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/idas/idas_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/idas/idas_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/idas/idas_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/idas/idas_spils.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/kinsol/kinsol.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/kinsol/kinsol_bbdpre.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/kinsol/kinsol_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/kinsol/kinsol_ls.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/kinsol/kinsol_spils.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/nvector/nvector_manyvector.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/nvector/nvector_serial.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_band.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_config.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_context.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_dense.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_direct.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_export.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_iterative.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_lapack.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_linearsolver.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_logger.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_math.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_matrix.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_memory.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_mpi_types.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_nonlinearsolver.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_nvector.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_profiler.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_types.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sundials/sundials_version.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_band.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_dense.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_klu.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_lapackband.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_lapackdense.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_pcg.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_spbcgs.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_spfgmr.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_spgmr.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunlinsol/sunlinsol_sptfqmr.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunmatrix/sunmatrix_band.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunmatrix/sunmatrix_dense.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunmatrix/sunmatrix_sparse.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunmemory/sunmemory_system.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunnonlinsol/sunnonlinsol_fixedpoint.h
[ Info: Processing header: /Users/viral/.julia/artifacts/9a548aba93a9f8fe35530046ae36e3a4f47321f2/include/sunnonlinsol/sunnonlinsol_newton.h
[ Info: Building the DAG...
┌ Warning: [CollectDependentSystemNode]: found symbols in the system headers: [:klu_l_common_struct, :__JL_Ctag_346, :klu_l_symbolic, :klu_l_numeric, :klu_l_common, :__JL_Ctag_344]
└ @ Clang.Generators ~/.julia/packages/Clang/skgwS/src/generator/passes.jl:95
[ Info: Emit Julia expressions...
┌ Warning: No Prototype for CLCursor (Clang.CLFunctionDecl) SUNMemoryNewEmpty() - assuming no arguments
└ @ Clang.Generators ~/.julia/packages/Clang/skgwS/src/generator/codegen.jl:129
[ Info: Done!
ERROR: LoadError: BoundsError: attempt to access 2-element Vector{Any} at index [3]
Stacktrace:
  [1] getindex(A::Vector{Any}, i1::Int64)
    @ Base ./essentials.jl:13
  [2] wrap_sundials_api(expr::Expr)
    @ Main ~/.julia/dev/Sundials/gen/generate.jl:93
  [3] rewrite(ex::Expr)
    @ Main ~/.julia/dev/Sundials/gen/generate.jl:227
  [4] _broadcast_getindex_evalf(f::typeof(rewrite), args::Expr)
    @ Base.Broadcast ./broadcast.jl:709 [inlined]
  [5] _broadcast_getindex(bc::Base.Broadcast.Broadcasted{Nothing, Tuple{…}, typeof(rewrite), Tuple{…}}, I::Int64)
    @ Base.Broadcast ./broadcast.jl:682 [inlined]
  [6] getindex(bc::Base.Broadcast.Broadcasted{Nothing, Tuple{…}, typeof(rewrite), Tuple{…}}, I::Int64)
    @ Base.Broadcast ./broadcast.jl:636 [inlined]
  [7] macro expansion
    @ Base.Broadcast ./broadcast.jl:1004 [inlined]
  [8] macro expansion
    @ Base.Broadcast ./simdloop.jl:77 [inlined]
  [9] copyto!(dest::Vector{Vector{…}}, bc::Base.Broadcast.Broadcasted{Nothing, Tuple{…}, typeof(rewrite), Tuple{…}})
    @ Base.Broadcast ./broadcast.jl:1003 [inlined]
 [10] copyto!(dest::Vector{…}, bc::Base.Broadcast.Broadcasted{…})
    @ Base.Broadcast ./broadcast.jl:956 [inlined]
 [11] copy(bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{…}, Tuple{…}, typeof(rewrite), Tuple{…}})
    @ Base.Broadcast ./broadcast.jl:928 [inlined]
 [12] materialize(bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{…}, Nothing, typeof(rewrite), Tuple{…}})
    @ Base.Broadcast ./broadcast.jl:903
 [13] top-level scope
    @ ~/.julia/dev/Sundials/gen/generate.jl:273
Some type information was truncated. Use `show(err)` to see complete types.
in expression starting at /Users/viral/.julia/dev/Sundials/gen/generate.jl:272

Why is >v1.6 required?

Never mind. I think this is generating for Sundials 5.2 still. I think I just need Julia 1.10 for generating the headers with the latest Clang.jl. Let me see if I can get it working first and then will worry about bumping julia_compat down to 1.6, which should just work.

This is the error running Clang. The clang wrappers need updating:
ERROR: LoadError: BoundsError: attempt to access 2-element Vector{Any} at index [3]
Stacktrace:
  [1] getindex(A::Vector{Any}, i1::Int64)
    @ Base ./essentials.jl:13
  [2] wrap_sundials_api(expr::Expr)
    @ Main ~/.julia/dev/Sundials/gen/generate.jl:93
  [3] rewrite(ex::Expr)

Minimum change that I think would be needed to the generated code in libsundials_api.jl to make the NVector memory management work as in the current release  (ie as it does following fixes in release v4.12.0 https://github.com/SciML/Sundials.jl/pull/380 ):
The generated ccall wrappers need to take NVector arguments and pass through to ccall so that ccall then uses the cconvert and unsafe_convert machinery to preserve the lifetime of the NVector (which may well be a temporary generated by the calling code).
So eg the generated wrapper
function CVodeInit(cvode_mem, f::CVRhsFn, t0::realtype, y0::N_Vector)
    ccall((:CVodeInit, libsundials_cvodes), Cint, (Ptr{Cvoid}, CVRhsFn, realtype, N_Vector), cvode_mem, f, t0, y0)
end

would need to be instead:
function CVodeInit(cvode_mem, f::CVRhsFn, t0::realtype, y0::NVector)
    ccall((:CVodeInit, libsundials_cvodes), Cint, (Ptr{Cvoid}, CVRhsFn, realtype, N_Vector), cvode_mem, f, t0, y0)
end

I'm guessing it might also be necessary to accept other types for y0 as in the current released code:

to avoid extra conversions where the caller already has an N_Vector and is responsible for managing the lifetime, allow

function CVodeInit(cvode_mem, f::CVRhsFn, t0::realtype, y0::Union{NVector, N_Vector})

to allow y0::Vector , provide

function CVodeInit(cvode_mem, f::CVRhsFn, t0::realtype, y0)
    return CVodeInit(cvode_mem, f, t0, convert(NVector, y0))
end

(or perhaps this is overcomplicated and just removing the type signature to vector arguments (y0 etc) would be enough to let ccall apply whatever is needed ? Not sure if it would chain together convert and then cconvert and unsafe_convert to handle a Julia Vector though ?)

Can this be rebased on master to see if it works now?

I thought this PR needs a substantial amount of work. I really doubt it will work.


WIP: Add map_with_ctx

While building a parser for yaml I found a method like this necessary. The context for my parser looks something like this:
pub struct ParsingContext {
    pub(crate) block_key: bool,
    pub(crate) in_block: bool,
    pub(crate) in_flow: bool,
    indent: Option<usize>,
}

Which is necessary context for parsing. Only one of these fields needs to be updated at a time, and normally this would be easy enough with map_ctx, but when trying to update indentation using a parser & ignore_with_ctx, it becomes a problem.
This could be solved a few ways directly:

A map_with_ctx function allowing the merging of existing and new context, which will then likely be used by a *_with_ctx call.
Add new *_with_ctx methods which support modifying the context being used
Reconfigure *_with_ctx to append to a tuple, instead of replacing existing context entirely. This would mean context would nest.

An example of it's usage:
    text::inline_whitespace()
        .configure(|cfg, ctx: &ParsingContext| cfg.at_least(ctx.indent.map(|x| x + 1).unwrap_or(0)))
        .count()
        .rewind()
        .map_with_ctx(|ind, ctx: &ParsingContext| { let ctx = ctx.clone(); ctx.indent = Some(ind); ctx })
        .ignore_with_ctx(line_parser)

Yeah, I wonder the same honestly. I'm no expert in Chumsky, but I did hit a wall with this one. Here's an example of where I think it'd be necessary. When setting the current indentation level, the current context needs to be merged with the output of a parser.
I didn't see another way of doing that, short of custom which would obviously work here. I assume Chumsky would want to be able to parse yaml eventually with no use of custom; so I planned on working towards that eventually.

I took another stab at the docs for map_with_ctx, though I'm not entirely happy with the example yet. It might also be good to add a try_map_with_ctx for completeness.
I'm struggling to come up with a simpler example than this that isn't contrived. I'm trying to demonstrate the issue I'm facing with parsing YAML using Chumsky: parsing bare strings (and to a lesser extent all scalars) is very context dependent. It's not feasible right now without using custom.
Parsing YAML is very different than any of the other examples I've seen Chumsky used for. But I think it's a perfect use-case for the context system; which I think could easily be made to be just powerful enough to do the job.

Just to let you know, this is absolutely on my list of things to fully review, I'll hopefully get to it within the next few days.

Ah, I can see the value here. So it looks like this is a way to add information to the context for specific patterns?

Looks like this might need a rebase.

Looks like the doc test has a problem.

Ah yeah, because tests are setup with all features enabled, sync was breaking because the dyn Parser wasn't Send + Sync.


Request for example: Weight Decay Optimizers / Super Convergence

A valuable set of optimizers that are available in Addons.
Related info:
https://www.fast.ai/2018/07/02/adam-weight-decay/
https://github.com/tensorflow/addons/blob/master/examples/README.md

I can take up this one if it is ok. Is it ok if we build this example based on lazy_adam example?
@seanpmorgan

I can take up this one if it is ok. Is it ok if we build this example based on lazy_adam example?
@seanpmorgan

Yeah we can use that as a starting point. I would like to include some info from that Fast AI blog (credit them where appropriate)... and it would be great to show the convergence speed against standard adam optimizer

Sure. I will keep you posted about the progress.

@seanpmorgan Can you please assign this issue to me? I am working on it

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Check Nile workflow

The Nile dataset is used to generate Figure 5 and several entries from Table 1 in the paper Spatio-temporal Bayesian On-line Changepoint Detection with Model Selection.
In this issue, we will check that we can regenerate the figure and values included in the table by first running nile_ICML18.py, and then paper_pictures_nileData.py.
Initial to do list:

[x] Ensure that nile_ICML18.py generates the results file needed by paper_pictures_nileData.py
[x] Update the file paths given in paper_pictures_nileData18.py

The changes in 1d1e21fd8c07274b3aa67551b0a332eee71a76da deal with the initial to do list - I can now run both scripts on my computer to generate the figure and get the MSE and NLL values for Table 1.
There is a lot of overlap between the plotting section of nile_ICML.py and paper_pictures_nileData.py - can we do something about that? It would be better to remove the plotting functionality from one of the two scripts, and either have nile_ICML18.py do everything (and get rid of paper_pictures_nileData.py) or restrict it to only detecting the CPs and saving the results. The first option would be simpler, while the second would be advantageous if there are any problems during the plotting stages - it would be easier to re-run the plotting section alone after any revisions (this won't be such an issue for the Nile dataset but could be for those that take longer).

@LouiseABowler SO COOL!! Way to go! And thank you @JeremiasKnoblauch for sharing the code so well!! 🎉 🍰 ✨
I don't have a strong opinion regarding the plotting section (I just came to say yaaaaay wooooo!) Both make sense to me so happy with whichever others prefer 😸


Unexpected warning when using ajv-merge-patch

What version of Ajv are you using? Does the issue happen if you use the latest version?
<EMAIL_ADDRESS><EMAIL_ADDRESS>in the runkit)
Ajv options object

{
  allowMatchingProperties: true,
  code: {
    lines: true,
  },
}

JSON Schema

N/A
Sample data
N/A
Your code

runkit:
https://runkit.com/craigphicks-public/ajv-issue-1560
const Ajv2019 = require('ajv/dist/2019');
const AjvMergePatch=require("ajv-merge-patch")
const draft7MetaSchema = require('ajv/dist/refs/json-schema-draft-07.json');
const ajv = new Ajv2019({
  allowMatchingProperties: true,
  code: {
    lines: true,
  },
});
ajv.addMetaSchema(draft7MetaSchema);
AjvMergePatch(ajv);

Validation result, data AFTER validation, error messages
There was no validation error.  However, the program emitted unexpected warning output:
"these parameters are deprecated, see docs for addKeyword"

What results did you expect?
I didn't expect a warning.
However, since there was a warning, I I expected a listing of which parameters are depracated.
Are you going to resolve the issue?
Can I resolve this problem by a change in usage?

Closing this issue for the time being - the example code I posted is not representative of the issue.

Changed the code sample to reflect using both 2019 and version 7.
However, the warning message still remains.

this is duplicate of https://github.com/ajv-validator/ajv-merge-patch/issues/38


Looks already great but...

Would be great to offer local hosted, optimized images per options etc.
Also it should be possible to pass rel attributes like noopener, noreferrer. nofollow
Cheers

I'll think about the option to host images locally.
To set link attributes, I use a separate plugin https://github.com/aloskutov/eleventy-plugin-external-links. It processes all links of the generated html page.

I'll think about the option to host images locally.
To set link attributes, I use a separate plugin https://github.com/aloskutov/eleventy-plugin-external-links. It processes all links of the generated html page.

Saw your other plugin later that day, made sense then^^


How to add custom achivements to lua

What is your question?
I'm trying to add Achievements for my mod and I haven't found any Youtube tutorials only tutorials on source code, so plz tell me how, Thanks!

You can't

but in the folders there's a folder named "Achievements" and I don't know how to use it

They're not used, there are several other posts clarifying this

close this


Advice on large number of PUTs

Hi All,
I need to create almost 2m small files in an S3 bucket (see the make.js script at https://github.com/Digital-Contraptions-Imaginarium/frugal-addresses-onspd/tree/write-to-s3-directly if you are curious).
I am wondering what is the best practice to use knox to do that effectively. At the moment, I am simply writing the files one by one and observing that after the first 4000 PUTs the process becomes very slow. My guess is that there is some "buffer" of PUT requests that can't get processed fast enough.
Any advice is welcome, thanks,
Giacecco

This could be due to any number of things. Here are my guesses:

Versions of node before io.js did not handle HTTP connection keep-alive very well, which seems possibly relevant
Amazon could be rate-limiting you (perhaps DDoS protection?)
Your machine could be running out of memory or other resources

https://www.google.com/search?q=s3+batch+upload has some interesting results too


Update User Interface

Problem
The UI seems to be too old and needs a punch of modernism.
My Solution
A concise and simplified UI with modern taste
Example

I'd be really happy to help :smile:


Change ToLower method to ToLowerInvariant in AdminPanel (#5766)

this closes #5766

@TRISHAHALDER Thanks for you contribution


S3 URL not found issue when install worker.sh is downloading binaries.

When running the MAKE file with default specifications, the install-worker.sh fails to download the binaries kubelet, kubectl,aws-iam-authenticator from

https://s3-us-west-2.amazonaws.com/amazon-eks-worker/1.10.3/2018-07-26/bin/linux/amd64/

and throws out the following error
amazon-ebs: --2018-08-02 19:18:11--  https://s3-us-west-2.amazonaws.com/amazon-eks worker/1.10.3/2018-07-26/bin/linux/amd64/kubelet
    amazon-ebs: Resolving s3-us-west-2.amazonaws.com (s3-us-west-2.amazonaws.com)... <IP_ADDRESS>
    amazon-ebs: Connecting to s3-us-west-2.amazonaws.com (s3-us-west-2.amazonaws.com)|<IP_ADDRESS>|:443... connected.
    amazon-ebs: HTTP request sent, awaiting response... 404 Not Found
    amazon-ebs: 2018-08-02 19:18:11 ERROR 404: Not Found.

Is there any workaround for this ??

Our bucket name is amazon-eks not amazon-eks-worker. Where are you getting that bucket name from?
This is specified in eks-worker-al2.json

Thanks, after changing that i have this issue now
    amazon-ebs:
    amazon-ebs: aws-iam-authenticator: OK
    amazon-ebs: Failed to execute operation: Bad message
==> amazon-ebs: Terminating the source AWS instance...
==> amazon-ebs: Cleaning up any extra volumes...
==> amazon-ebs: No volumes to clean up, skipping
==> amazon-ebs: Deleting temporary security group...
==> amazon-ebs: Deleting temporary keypair...
Build 'amazon-ebs' errored: Script exited with non-zero exit status: 1

==> Some builds didn't complete successfully and had errors:
--> amazon-ebs: Script exited with non-zero exit status: 1

This fails on these two move commands in install-worker.sh
sudo mv $TEMPLATE_DIR/kubelet-kubeconfig /var/lib/kubelet/kubeconfig
sudo mv $TEMPLATE_DIR/kubelet.service /etc/systemd/system/kubelet.service

The default script is working for me, is there anything else you’ve changed?

Okay. So i get the same error when I add a VPC , SUBNET variables and a encrypted EBS volume in launch_block_device_mappings
{
  "variables": {
    "profile": "agnnn",
    "aws_region": "ca-central-1",
    "ami_name": "eks-k8s-worker-AL2-ami-{{timestamp}}",
    "binary_bucket_name": "amazon-eks",
    "binary_bucket_region": "us-west-2",
    "binary_bucket_path": "1.10.3/2018-07-26/bin/linux/amd64",
    "creator": "agnnn",
    "instance_type": "m4.large",
    "vpc_id": "vpc-eda5384",
    "subnet_id": "subnet-1f8964",
    "source_ami_id": ""
  },

  "builders": [
    {
      "type": "amazon-ebs",
      "region": "{{user `aws_region`}}",
      "source_ami": "{{user `source_ami_id`}}",
      "source_ami_filter": {
        "filters": {
          "architecture": "x86_64",
          "name": "amzn2-ami-minimal-hvm-*",
          "owner-id": "137112412989",
          "root-device-type": "ebs",
          "state": "available",
          "virtualization-type": "hvm"
        },
        "most_recent": true
      },
      "instance_type": "{{user `instance_type`}}",
      "launch_block_device_mappings": [
        {
          "device_name": "/dev/xvda",
          "volume_type": "gp2",
          "volume_size": 20,
          "delete_on_termination": true
        },
        {
          "device_name": "/dev/xvdb",
          "volume_type": "gp2",
          "volume_size": 20,
          "Encrypted": true,
          "delete_on_termination": true
        }
      ],
      "ssh_username": "ec2-user",
      "ssh_pty": true,
      "run_tags": {
          "creator": "{{user `creator`}}"
      },
      "tags": {
          "created": "{{timestamp}}"
      },
      "ami_name": "{{user `ami_name`}}",
      "ami_description": "EKS Kubernetes Worker AMI with AmazonLinux2 image"
    }
  ],

  "provisioners": [
    {
      "type": "shell",
      "inline": ["mkdir -p /tmp/worker/"]
    },
    {
      "type": "file",
      "source": "./files/",
      "destination": "/tmp/worker/"
    },
    {
      "type": "shell",
      "script": "install-worker.sh",
      "environment_vars": [
        "BINARY_BUCKET_NAME={{user `binary_bucket_name`}}",
        "BINARY_BUCKET_PATH={{user `binary_bucket_path`}}",
        "BINARY_BUCKET_REGION={{user `binary_bucket_region`}}"
      ]
    }
  ],
  "post-processors": [
    {
      "type": "manifest",
      "output": "manifest.json",
      "strip_path": true
    }
  ]
}

Even if I run the default settings without changing anything.. i still get the same error
    amazon-ebs: aws-iam-authenticator: OK
    amazon-ebs: Failed to execute operation: Bad message
==> amazon-ebs: Terminating the source AWS instance...

Lets just focus on the default settings. If you'd like to customize the packer script, you're welcome to do so, but we won't be able to provide support for your own modifications.
When you run the default settings without changing the region or anything, can you post the full error you're seeing?

Any update on this? Can we close this?

Closing with no response


Modelica.Media.package.mo still has __Dymola_choicesAllMatching

Modified by dietmarw on 6 Mar 2015 17:15 UTC
All other occurrences of __Dymola_choicesAllMatching have been changed to the now standard choicesAllMatching, but there are still two occurrences of the former in Modelica/Media/package.mo

Reported by stefanv on 6 Mar 2015 15:25 UTC
All other occurrences of __Dymola_choicesAllMatching have been changed to the now standard choicesAllMatching, but there are still two occurrences of the former in Modelica/Media/package.mo

Migrated-From: https://trac.modelica.org/Modelica/ticket/1675

Modified by dietmarw on 6 Mar 2015 17:15 UTC

Comment by hubertus on 9 Mar 2015 19:50 UTC
This is fixed now. For reference, the problem was only present in the 3.2.1 branch, but not in trunk.

Changelog modified by hubertus on 9 Mar 2015 19:50 UTC
Removed erroneous __Dymola annotation that was somehow not fixed simultaneously in trunk and this branch.

Comment by stefanv on 9 Mar 2015 20:05 UTC
I just sync'd the branch, and it seems not to be fixed there.

Comment by hubertus on 9 Mar 2015 21:19 UTC
I committed the fix in 86b884e3fde6faa7129d3e873ff87598f0488416 to /Modelica/maintenance/3.2.1/Modelica/Media/package.mo. Are we really talking about the same branch? If there are more problems, or you need another branch, let me know. Note that chocesAllMatching was not in the specification some versions ago, so it should not be merged back in time longer than it was legal.

Comment by stefanv on 10 Mar 2015 13:48 UTC
I'm using the branch, tags/v3.2.1+build.3-rc1
Yes, I realize that choicesAllMatching is fairly new, but all the other occurrences of Dymola_choicesAllMatching in that branch had already been changed.
But here you can see that 86b884e3fde6faa7129d3e873ff87598f0488416 doesn't seem to have the fix yet, unless I'm using svn incorrectly.
$ svn co https://svn.modelica.org/projects/Modelica/tags/v3.2.1+build.3-rc1 .
Checked out revision 8125.

$ grep -n __Dymola Modelica/Media/package.mo
3494:          "Medium model" annotation (__Dymola_choicesAllMatching=true);
3555:          "Medium model" annotation (__Dymola_choicesAllMatching=true);

Comment by beutlich on 10 Mar 2015 13:53 UTC
Tagged branches won't be updated. Use the maint. branch to update.

Comment by hubertus on 10 Mar 2015 14:04 UTC
That is what I did, the maintenance branch was changed, but no tag. So I re-close this as fixed. Stefan, please use the branch maintenance/3.2.1.

Comment by dietmarw on 11 Mar 2015 08:07 UTC
Just a comment. Stefan did exactly the right thing that tool vendors were asked to. Testing the release candidate. If issues are found in the release candidate that are then fixed in the maintenance branch then we simply need a new release candidate.

Changelog modified by dietmarw on 11 Mar 2015 08:07 UTC
Removed erroneous __Dymola annotation that was somehow not fixed simultaneously in trunk and this branch.


max_width 训练的时候是256，预测的时候输入1024行不，这个参数是固定的么

max_width 训练的时候是256，预测的时候输入1024行不，这个参数是固定的么

actually, it's ok.but belval set the placeholder to a fixed length inputs = tf.placeholder(tf.float32, [batch_size, max_width, 32, 1]), so image's width must equal to max_width in testing.
you can modify his code, inputs = tf.placeholder(tf.float32, [None, None, 32, 1]) and other places.

Closing for lack of activity. Feel free to reopen if the above answer was unsatisfactory.


prepare code for caic #6

https://github.com/BUPT/awesome-chatbot/issues/10
I'll do a poster again on End-to-End Task-Completion Neural Dialogue Systems](https://bupt.github.io/conversational-ai-club/#/papers/end-to-end-task-completion-neural-dialogue-systems-2018), the goal is to run some code for demonstration.

💯


Possible Rust error format updates and IDE support

Hi all,
Sorry for using the issue as a message box, but I wanted to let you know that we're working on an RFC that updates the error messages output format: https://github.com/rust-lang/rfcs/pull/1644  If RustyCode is currently parsing the output from the compiler may be impacted.
That said, we're also talking about standardizing a JSON format to help give IDEs more information from compiler output.
Would love to chat about the VSCode support (which I use pretty much everyday :) ), and get your thoughts.

Hello!
Idea of standardizing a JSON format of errors sounds really good to me, because now we rely on some not so robust plain text parsing and changes in error format will of course have impact on RustyCode.
As I see it, some simple JSON would be more convenient, for example something like this:
{
    "lineFrom": 0,
    "lineTo": 10,
    "characterFrom": 0,
    "characterTo": 6,
    "severity": "error" | "warning",
    "message": "",
}

But maybe other guys have other ideas.

Rustc does have support for emitting json logs, and it is really easy to use, my only issue with it is that we can't get the usual log along with it, so our output window won't show the same stuff it would if we were building on the terminal.

@jonathandturner maybe we could include the "text" version of the message inside of the JSON?

@wycats - thanks for the reminder!  I started a thread on the Rust internals list about stabilizing the json format, which includes adding a field for the fully rendered compiler message:
https://internals.rust-lang.org/t/stabilizing-json-compiler-message-output/3691

I took a look at implementing this. I don't think it will be difficult at all, but there are a few potential annoyances:
To implement this on all cargo tasks, we could use the RUSTFLAGS env var, although this causes issues for people like myself who prefer to do the building and running from a terminal. A change to RUSTFLAGS will trigger a rebuild when you build from the terminal as one will expect the human readable compiler output. Likewise, having built from the terminal, VSCode will then have to rebuild when it builds/lints again.
The other option is to pass in the -Z unstable-options --error-format=json args ourselves, but that is a problem for the build/run tasks as they don't support custom rustc arguments.
A hybrid approach might be desirable where linters (cargo check/cargo clippy/etc) take the arguments on the command line, but build/run/bench/test take the environment variable. This would allow people who use the IDE for linting/formatting to be unimpeded by constant rebuilds as they switch between the terminal and IDE.
@jonathandturner Do you have any ideas?

If you put the flag in RUSTFLAGS, you're only doing it the one time, right?  If so, wouldn't that be a single rebuild?

From the IDE's point of view, yes. If, however, you decide to build it from a terminal then RUSTFLAGS is empty which triggers a rebuild as it is stored in the compilation settings somewhere.
I understand the reasoning behind it as you definitely want a rebuild if you change optimization settings or what have you, but the error output shouldn't (in my opinion) have such an impact.

I've created a feature request at https://github.com/rust-lang/rfcs/issues/1693 for an environment variable that only affects the error format. Suggest we continue discussions there.

https://github.com/saviorisdead/RustyCode/pull/159 adds support for JSON errors and I'll look into adding support for the new error format during the week :+1:

Sounds like this is in-progress, but I wanted to give you all a heads up that we're currently discussing turning the new error format on: https://github.com/rust-lang/rust/pull/35401
If there are any issues, please let us know.  Making the switch will only affect nightly, and there will still be some weeks before this goes into stable, which gives us some time to make changes if need be.

Awesome!


Adding auth in socket request

Server need to receive auth token from client, so it needs to send the auth. Is there any ways to add auth in socket request? Thank you

Have you try sending auth token data right after your socket connection was open?

Thank you for the quick response. Server request to send the auth when starting connection, so it need to send when the connect() method called. Is there any way to do that in current version?

If your token on header and sent during handshake you can try add your token in options during initialization
NWWebSocket(url: socketURL, options: options)
where
options.setAdditionalHeaders([("header_key","your_token")])

I've try to do that, but how to initialize the "options"?

let options = NWWebSocket.defaultOptions
options.setAdditionalHeaders([("header_key","your_token")])
NWWebSocket(url: socketURL, options: options)

Hey @ajinumoto, thanks for the help. Now, I can send my auth but the socket is not connected yet. It's not called the delegate method, so what's wrong here?
Here is my code
func connectSocket() {
        guard let accessJWT: String = UserDefaultManager.getUserDefault(key: .userData_AccessJWT) else {
            self.delegate.socketDidError(message: "Token socket not found")
            return
        }

        self.socketManager?.delegate = self

        let socketOption = NWProtocolWebSocket.Options()
        socketOption.setAdditionalHeaders([("token", accessJWT)])

        self.socketManager = NWWebSocket(url: self.socketURL,
                                         connectAutomatically: true,
                                         options: socketOption,
                                         connectionQueue: .main)

        self.socketManager?.ping(interval: 15)

        func webSocketDidConnect(connection: WebSocketConnection) {
        print("Socket: Connected")

        self.socketManager?.ping(interval: 15)
    }

    func webSocketDidDisconnect(connection: WebSocketConnection,
                                closeCode: NWProtocolWebSocket.CloseCode, reason: Data?) {
        print("Socket: Disconnected")

        self.connectSocket()
    }

    func webSocketDidConnect(connection: WebSocketConnection) {
        print("Socket: Connected")

        self.socketManager?.ping(interval: 15)
    }

Probably because you set
 self.socketManager?.delegate = self
before
self.socketManager = NWWebSocket(url: self.socketURL,                                           connectAutomatically: true,                                          options: socketOption,                                          connectionQueue: .main)
so your delegate is still on old self.socketManager value  (or nil)

I've move the delegate after the NWWebSocket initialization, but the delegate method is not called either
        self.socketManager = NWWebSocket(url: self.socketURL,
                                         connectAutomatically: true,
                                         options: socketOption,
                                         connectionQueue: .main)
        self.socketManager?.delegate = self
        self.socketManager?.ping(interval: 15)

but the delegate method is not called

All delegate not working really, even the connect and disconnect delegate? If all of delegate are not working, there is something wrong with your code. If you didn't receive message from socket try listen using self.socketManager?.listen()?
Btw, i highly recommend you to see NWWebSocket class for deeper understanding about this library


Trades history for all pairs in one call

Bitfinex API supports /trades/ call with symbol omitted completely. It returns trades for all symbols in one call. I added support for this in the code.

You can now call it just like this to retrieve trades on all pairs:
trades = bfx.trades_history()


Use ScriptModule object into the Jupyter kernel

I am having an hard time with the stdin/stdout/stderr stuff. PR is not working for now.
I also had to add the setScriptInfo() method to ScriptModule into scijava-commons

Closing in favor of #15 (for now !).


[Master] CI/CD: switch from gke to eks

Change Description

@jerstern Requested a migration from GKE builders/testers to EKS. This will allow us to scale and maintain these machines much easier.
They're also faster. We see almost half the time for builds in several pipelines (contracts went from 7m to 4m).
Deployment Changes

[ ] Deployment Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

What is the eks file that has nothing in it?

What is the eks file that has nothing in it?

Good catch, no clue. Removed!


Added the Date (shows the today's date & added AM | PM stamp to the D…

New Feature added : Shows Today's date + AM,PM stamp is added after digital clock.

Nice Feature


Update stable version in repo from 1.3.0 to 1.5.3

Think about update stable version to 1.5.3
Version: stable=1.3.0 (359 days old) => latest=1.5.3 (15 days old)
Installs: stable=1121 (56.67%), latest=295 (14.91%), total=1978
Click to edit

done


Using for-each loop to iterate Array cause problem.

Hi there, I use jquery-aciTree-4.4.0 and jquery-bootgrid plugin. jquery-bootgrid add some method to Array.
in jquery.aciTree.core.js line 1413, there is a for-each loop for Array: "for (var i in itemData) {", which could be change to "for (var i=0; i<itemData.length; i++) {", to avoid to generate some addtional tree items.
thanks for your greate work.

Just adding my vote for this fix - you end up with a bunch of undefined nodes without it


Update Completion to include completion_kwargs

Closing because it was not updated to latest main branch, see #116 instead


unbreakable spaces appear to be converted in html entities twice

Hello,
everything is in the title and here :
https://codepen.io/anon/pen/YERjgw
have a good day

That's because when the browser parses the text, it passes an   to Moon. There is no current escape code for it, but I can add it.
A fix would be to paste the entire div into the template option, so that Moon compiles it correctly.
CodePen Link

Thank you for your explanations :+1:

No problem. Since Moon can handle this escape for you, I'll keep this issue open.


hey!

hey umm problem is closed: https://github.com/David20122/sound-space-plus/issues/45
sooo.

hey umm problem is closed: #45 sooo.

No need to open a new issue on gh abt it lol
Ill re-open it
Closing this rn and reopening #45


Release 0.21.3

@zmerlynn

Vaguely waiting on Shippable...

Do you know what's going on here?
# github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/gce
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/gce/gce_test.go:57: gce.computeHostTag undefined (type *GCECloud has no field or method computeHostTag)
FAIL	github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/gce [build failed]

(Shippable's been okay on release branches for me on release-1.0.)

LGTM.


Start of the new user layer: client, daemon, registries

This is blocking my later enhancements. Would someone review, please?

Withdrawing this per https://github.com/dotnet/Docker.DotNet/issues/492#issuecomment-813056496


⚠ SceneTime has degraded performance

In 4ce3af7, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1349 ms

Resolved: SceneTime performance has improved in bf21c2d after 6 minutes.


Some properties are lost in failed uploaded images

Summary:
If image uploading failed, we can try later in CONTRIBUTIONS fragment. But some properties are not saved to Contribution database and they are lost. This caused the problem that these properties have to be manually added/edited after we successfully uploaded the failed image.
Steps to reproduce:
Upload an image with location and categories, interrupt the uploading process, so the image appears as Failed in contribution list.
Re-uploading this image in contribution list.
The location and categories properties are lost in the re-uploaded image.
Expected:
Re-uploaded image has its previously set location and categories properties.
Device and Android version:
Unrelated
Commons app version:
current master
Would you like to work on the issue?
Yes

I would like to work on this issue

@Kiraeraser Sorry this issue is assigned already but you can find others here, cheers!

I have closed previous sleeping PR. Anyone who claims the issue, please make sure you have inspired from the changes there. These changes were almost done with some minor details.

This issue was fixed and a release is available. Is it still happening? If yes, please reopen, thanks! :-)


Create Printing_LCS.java

A Technique to handle printing problems in dp.

How to get hacktoberfest accepted tag?!
On Sat, 22 Oct, 2022, 12:27 am Vijay, @.***> wrote:

Merged #643 https://github.com/vijaygupta18/Hacktoberfest-2022/pull/643
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/vijaygupta18/Hacktoberfest-2022/pull/643#event-7643030664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMZYBM6URZDDDK2Z6I6CIC3WELRTJANCNFSM6AAAAAARJIEBEI
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


About correspondence to phpunit 6.0

Since phpunit 6.0 was released and stabilized, we upgraded from 5.7.Now we are receiving following logs being outputted from phpci.

RUNNING PLUGIN: php_unit
PHPUnit 6.0.7 by Sebastian Bergmann and contributors.
unrecognized option --tap
Exception: No TAP log found, please check the configuration.
PLUGIN: FAILED

As a result of an examination, it seems that the --tap option is no longer available in phpunit 6.0.

Removed the --log-tap and --tap commandline options (deprecated in PHPUnit 5.7)
https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md

Are there any ways to make it work like before without using the --tap option?
Also please tell me if there is any schedule where you guys can respond to this issue to phpunit 6.0

any news on this?

Downgrade phpunit on your project composer.json to v5.7
It says in the wiki that if you have phpunit in your projects composer.json it will conflict. It just picks up the projects version instead of the one used by phpci.
So until this is updated you can downgrade phpunit.

Hello,
Can some test if this pull request works with phpunit 6.0?
https://github.com/Block8/PHPCI/pull/1275
It replaces the TAP parser.

I have tried the #1275 and it returns the following result.

RUNNING PLUGIN: php_unit
PHPUnit 6.2.3 by Sebastian Bergmann and contributors.
unrecognized option --log-json
Exception: No test executed.
PLUGIN: FAILED

Above is 6.2.3 execution log but even on 6.0, it returns the same result.

Removed the --log-json commandline option (deprecated in PHPUnit 5.7)
https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md

For reference I have attached the usable option on phpunit 6.2.3.

$ phpunit --help
PHPUnit 6.2.3 by Sebastian Bergmann and contributors.

Usage: phpunit [options] UnitTest [UnitTest.php]
       phpunit [options]

Code Coverage Options:

  --coverage-clover     Generate code coverage report in Clover XML format.
  --coverage-crap4j     Generate code coverage report in Crap4J XML format.
  --coverage-html        Generate code coverage report in HTML format.
  --coverage-php        Export PHP_CodeCoverage object to file.
  --coverage-text=      Generate code coverage report in text format.
                              Default: Standard output.
  --coverage-xml         Generate code coverage report in PHPUnit XML format.
  --whitelist            Whitelist  for code coverage analysis.
  --disable-coverage-ignore   Disable annotations for ignoring code coverage.

Logging Options:

  --log-junit           Log test execution in JUnit XML format to file.
  --log-teamcity        Log test execution in TeamCity format to file.
  --testdox-html        Write agile documentation in HTML format to file.
  --testdox-text        Write agile documentation in Text format to file.
  --testdox-xml         Write agile documentation in XML format to file.
  --reverse-list              Print defects in reverse order

Test Selection Options:

  --filter           Filter which tests to run.
  --testsuite       Filter which testsuite to run.
  --group ...                 Only runs tests from the specified group(s).
  --exclude-group ...         Exclude tests from the specified group(s).
  --list-groups               List available test groups.
  --list-suites               List available test suites.
  --test-suffix ...           Only search for test in files with specified
                              suffix(es). Default: Test.php,.phpt

Test Execution Options:

  --dont-report-useless-tests Do not report tests that do not test anything.
  --strict-coverage           Be strict about @covers annotation usage.
  --strict-global-state       Be strict about changes to global state
  --disallow-test-output      Be strict about output during tests.
  --disallow-resource-usage   Be strict about resource usage during small tests.
  --enforce-time-limit        Enforce time limit based on test size.
  --disallow-todo-tests       Disallow @todo-annotated tests.

  --process-isolation         Run each test in a separate PHP process.
  --globals-backup            Backup and restore $GLOBALS for each test.
  --static-backup             Backup and restore static attributes for each test.

  --colors=             Use colors in output ("never", "auto" or "always").
  --columns                Number of columns to use for progress output.
  --columns max               Use maximum number of columns for progress output.
  --stderr                    Write to STDERR instead of STDOUT.
  --stop-on-error             Stop execution upon first error.
  --stop-on-failure           Stop execution upon first error or failure.
  --stop-on-warning           Stop execution upon first warning.
  --stop-on-risky             Stop execution upon first risky test.
  --stop-on-skipped           Stop execution upon first skipped test.
  --stop-on-incomplete        Stop execution upon first incomplete test.
  --fail-on-warning           Treat tests with warnings as failures.
  --fail-on-risky             Treat risky tests as failures.
  -v|--verbose                Output more verbose information.
  --debug                     Display debugging information.

  --loader            TestSuiteLoader implementation to use.
  --repeat             Runs the test(s) repeatedly.
  --teamcity                  Report test execution progress in TeamCity format.
  --testdox                   Report test execution progress in TestDox format.
  --testdox-group             Only include tests from the specified group(s).
  --testdox-exclude-group     Exclude tests from the specified group(s).
  --printer          TestListener implementation to use.

Configuration Options:

  --bootstrap           A "bootstrap" PHP file that is run before the tests.
  -c|--configuration    Read configuration from XML file.
  --no-configuration          Ignore default configuration file (phpunit.xml).
  --no-coverage               Ignore code coverage configuration.
  --no-logging                Ignore logging configuration.
  --no-extensions             Do not load PHPUnit extensions.
  --include-path     Prepend PHP's include_path with given path(s).
  -d key[=value]              Sets a php.ini value.
  --generate-configuration    Generate configuration file with suggested settings.

Miscellaneous Options:

  -h|--help                   Prints this usage information.
  --version                   Prints the version and exits.
  --atleast-version      Checks that version is greater than min and exits.
  --check-version             Check whether PHPUnit is the latest version.

Any news on this?

I am going to bump this as well.

Any news on this? is 2018 now

Welcome to 2019, any news ?


Revert "Merge pull request #5705 from adrienthebo/pup-7283-refactor-ssl-validators

This reverts commit 1f8c92ee51a28331ca52dd5e7ef319643fa1ad63, reversing
changes made to cd9b9323e20e5af85ff6413718b6c70ff950f59a.
/cc @MosesMendoza

reverting due to CI failures


FanzyZones randomly forgetting layout on a desktop

Microsoft PowerToys version
0.43.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
I don't do anything particular, other than maybe using Windows' virtual desktop feature and using a different layout on each.
I experience that FanzyZones randomly forgets the layout of a given desktop. When I re-apply it it works again (until next time).
✔ Expected Behavior
I would expect FanzyZone to not forget the layout of any desktop.
❌ Actual Behavior
FanzyZones randomly forgets the layout of one (or more, but usually just one) of my desktops.
Other Software
I use Windows 11 Pro 10.0.22000. It also existed on Windows 10 21H2 from which I upgraded around a month ago.

Thanks for reporting! I'll close it as a duplicate of https://github.com/microsoft/PowerToys/issues/12985, it would be a tracker for similar issues.


Explicit Creation Of Endpoints

I appreciate  your approach to wanting to simply input a class with endpoints, however I would like to use python syntax to create my own openapi doc by iterating over endpoints in my schema. For instance I have a python klein app and would like to iterate over its endpoints inspect the source and create a spec from that to avoid some of the implicit assumptions about naming ect.

I am not sure I fully understand this feature request. Could you elaborate and/or provide an example?
We do use a Python syntax to define endpoints, and we use python-openapi capabilities to generate an OpenAPI Specification from the Python descriptor. How does the challenge you face differ from what python-openapi offers today?


#262 fix: Pass through existing extra data from the input

See #262 for details.  Small patch to pass through extra_data from the original input statement.  This is useful for knowing where/how to respond, who asked the original question, etc.

Thank you :+1: Looks good.


Stepping sometimes requires you to step twice, or ends up in Python's native implementation

Pre-requisites:

Mixed Mode Debugging enabled
Debug Python 2.7 environment

Repro script:
import sys

sys.path.insert("d:\\src")   # Step over this line
sys.path.insert("d:\\python_src")

When you step over this line, the first time nothing happens.  The second time, I end up in the C implementation of PyMain -- in native code.  I've seen double stepping in other instances as well where the second step actually succeeds and ends up on the next line of python code, but I can't find a reliable repro for that, so I'm not sure what triggers it to succeed on the second step sometimes vs. ending up in the implementation of Python on the second step other times.

Any particular reason this is a wontfix?

Same reasoning as #3


Releases Freestyle 0.4.1

Releases Freestyle 0.4.1.
It just integrates all the repositories all-in-one. As a result, we're releasing frees-http-client, which is not available in 0.4.0.

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   86.77%   86.77%
=======================================
  Files          39       39
  Lines         295      295
  Branches        3        3
=======================================
  Hits          256      256
  Misses         39       39


Add flag to disable writing volatile bits of statsfile

Description
Writing the milliseconds bit of the statsfile can cause hash sum differences in the disk cache. Adding a flag to disable writing the timestamp in attempt in improving cache hit rate when distributed with remote caching.
Also updating the creation time timestamp for stats file and diagnostics file from https://github.com/bazelbuild/rules_scala/pull/1286/commits/76f59507f0bda29091edb1fecbc95b17d6aa9bc4.
Motivation
We are trying to improve the cache hit rate for the action graph.
Manual Test
Doing the following should yield zero differences between the different disk caches when scala_toolchain enable_stats_file = False
rm -rf $DC1 $DC2
DC1=/tmp/disk_cache_15
DC2=/tmp/disk_cache_16
TARGET=<sometarget>
mkdir -p $DC1 && mkdir -p $DC2 && ./bazel clean && ./bazel build --disk_cache=$DC1 $TARGET && ./bazel clean && ./bazel build --disk_cache=$DC2 $TARGET && diff -r $DC1 $DC2

How is 76f5950 related to cache hit rate?

That was a conservative approach to make sure bazel treats the files with the same content to be same, rather than possibly distinguish them due to their last modified time, causing churns on AC and CAS.

Hi @adam-singer,
I like the idea of disabling stats_file (because not everyone cares or knows about it). But maybe it would be possible to completely stop generating that file if enable_stats_file = False (instead of generating empty file)?  Maybe this could be done by removing stats_file from "predeclared outputs" (defined via common_outputs) and conditionally add it to "default outputs" via DefaultInfo(files)? That way you wouldn't need to touch it. WDYT?

It can be done with additional output group:
Return OutputGroupInfo(scala_stats_files = files) from rule
and request them via --output_groups flag: --ouptut_groups=+scala_stats_files

@darl that would be ideal but I have two concerns with this approach:

potentially that could break some users (maybe not a an issue)
stats file comes from same scalac action and file would be generated regardless if output group was requested or not (not sure there is a way to check which output groups ware requested in rule implementation)

I'm ok with statsfile flag, but I think 76f5950 must be another PR with a proper backing to the problem (it must be clear if such problem exists and what needs to be done to reproduce it - essential information for maintainers and contributors).

ok, let me separate this patch, we have tested these changes internally while debugging remote caching. https://github.com/bazelbuild/rules_scala/commit/76f59507f0bda29091edb1fecbc95b17d6aa9bc4 is a defensive measure, but I would need to unbundle and do some testing to understand if we can benefit from it.

Hi @adam-singer,
I like the idea of disabling stats_file (because not everyone cares or knows about it). But maybe it would be possible to completely stop generating that file if enable_stats_file = False (instead of generating empty file)? Maybe this could be done by removing stats_file from "predeclared outputs" (defined via common_outputs) and conditionally add it to "default outputs" via DefaultInfo(files)? That way you wouldn't need to touch it. WDYT?

@simuons @darl I wanted to originally stop generating the file altogether but couldn't fully figure out what constructs were required to support that, I would need guidance in that approach. The backwards compatible approach I took was "opt out if disabled" but leaves the file in place and nulled. I wonder if a more ideal situation is to emit (if possible) this information to the overall bazel profiler and leave it out of the build graph altogether. In terms of approach and feasibility I wouldn't have much context on who depends on the stats file, I know we don't.

One of the tests fails with xargs: xmllint: No such file or directory, is that some missing binary on the test agents?

@adam-singer

One of the tests fails with xargs: xmllint: No such file or directory, is that some missing binary on the test agents?

try to rebase on master this was fixed in https://github.com/bazelbuild/rules_scala/commit/fd997e6f3dd4f9af7033116be1383a1be1c41554


[wallet-ext] cleanup app categorization code

Description
Missed these before merging
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

@Nikhil-Mysten may i also request that we remove border below the last item in the app list?


Fix lorem ipsum text on marketing page.

The github.io page for this has lorem ipsum text in a prominent position on the page. This replaces it with real text.

@microsoft-github-policy-service agree

Thanks! Interesting how nobody noticed this...


how to hide the Status Bar while LaunchScreen.xib is showing?

Once React-Native kicks in, its control of the status bar starts working, but I'd like to not see it while the splash screen is showing as well. How can you accomplish that?

It'd be easy enough with a change to [RCTSplashScreen Show] to accept a parameter to enable/disable the status bar. I'd accept a PR over at https://github.com/mehcode/rn-splash-screen

You can define it in your apps Info.plist file. This will initially hide status bar. Then if you want you can show again in the app..
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>UIStatusBarHidden</key>
	<true/>
...


Add nightly Lifecycle scan

I recently pushed a PR to a README.md file, and the PR failed due to a new vulnerability from IQ.
This exposes a need for a nightly Lifecycle scan to detect new vulnerabilities in the project so we can be notified outside of PR's, etc. when such vulnerabilities are detectable.

We have Continuous Monitoring enabled in Lifecycle - so we don't need to have a workflow that does this @bhamail.
Note: We haven't set up notifications yet from Lifecycle...

Notifications set up @bhamail.


Support Native AOT

This PR adds support for Native AOT and source generation through implementing framework multitargeting.
Resolves #390
Resolves #532
Replaces #618
Relates to #611

☝ this commit increases test runs to almost 52k!

I was expecting to see the use of the JsonSerializerContext source generator and addition of <IsAotCompatible>true</> in the csproj files. What's the strategy here for ensuring that we're NAOT compatible?

I was expecting to see the use of the JsonSerializerContext source generator and addition of <IsAotCompatible>true</> in the csproj files.

I'm getting there.

The majority of the tests that fail in c9035e2 are caused by https://github.com/dotnet/runtime/issues/97490.


Java 8 Windows CI status failing

Java 8 Windows CI Status is "Failing".
Error:
[ERROR] /T:/src/github/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/nativeimage/SpannerFeature.java:[20,38] cannot access org.graalvm.nativeimage.hosted.Feature
  bad class file: C:\Users\kbuilder\.m2\repository\org\graalvm\sdk\graal-sdk\22.3.0\graal-sdk-22.3.0.jar(org/graalvm/nativeimage/hosted/Feature.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

Seems to be related to native images.

@rajatbhatta Hm this looks familiar. It was previously addressed through https://github.com/googleapis/java-spanner/pull/1870/files so I'm curious as to why we're seeing this. Do you happen to have the PR that is running into this?

@mpeddada1: Thanks for looking into this. We've this latest nightly build that failed: https://source.cloud.google.com/results/invocations/47498ffc-9e1e-4c2f-916e-3453ff20b7ae/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-spanner%2Fnightly%2Fjava8-win.

Thank you! It looks like the JAVA11_HOME and JAVA8_HOME environment variables are not being set for this job. Troubleshooting continued at #2207.

Closed via #2207 and #2210


Rename "dynambus" to "dynamicbus"

Proposal for partial fix to #1025. Done to avoid the following build error:
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\dynamic\dynambus.inx(64-64): error 1293: Service name 'dynambus' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\dynamic\dynambus.inx(75-75): error 1293: Service name 'dynambus' is reserved.

I closed this PR unintentionally.  I apologize. I am reopening the PR.

The compile failure is intentional. The idea is to prevent somebody from copy the sample without updating service name etc.  Thus, reject the PR.

The compile failure is intentional. The idea is to prevent somebody from copy the sample without updating service name etc. Thus, reject the PR.

Understood. Still, it's confusing with sample projects that doesn't build as-is, especially for new driver developers. Would it be possible to instead document this on the project front-page with clear instructions on how to make the projects build?


A Dinosaur game.

Describe the project you want to add with tech stack
A dinosaur game which is made using HTML, CSS and JS.
Expected behavior
In this game a dinosaur will jump to protect it from the cactus coming its way. It will contain two pages, one the landing page and other the game page.
Screenshots (optional)

@pranjay-poddar can you please assign me this issue.


Fake DynamoDb PutItem bugfix

The fake dynamodb putItem operation will now properly replace an existing item with the same primary key

Will get this released asap 🙃

<IP_ADDRESS> coming up :)


[TESTING] Explore comparative performance S71500 V3.0 vs S71500 V2.9 and PLCSIM

closes #140

see #140


Document how to do release

ping @matzew @odra @laurafitzgerald @danielpassos
Guys could you have a short look at this document. It is slightly modified version of https://github.com/aerogear/collateral/wiki/Release-Process-(Java)
I initially was changing that one, but I hated adding comments like "if you're using JBoss Nexus do this, but if you're using Sonatype Nexus, do that". Also, I wanted to make sure the notes are untouched for you guys for things like UPS etc.

@matzew pushed some fixes

@laurafitzgerald Releasing process is easy to automate (at least releasing the snapshots), except one must have the credentials on the CI/CD system. So, it might be a bit problematic to use a public service provider like Travis. We can have some job in our private Jenkins, but I don't like it because it is not open :)
Perhaps we should create a JIRA for that and then ask for help from the wider group and the community.
What do you say?

@laurafitzgerald @matzew can I get your approvals to merge this?

+1


LSP Sample no longer working (may be related to PR #776)

I was just onboarding via https://code.visualstudio.com/api/language-extensions/language-server-extension-guide, and noticed that the tutorial wasn't working: the extension never seemed to start, and setting a breakpoint in extension.ts did not work:

However, if I reintroduce the activationEvents removed in PR #776, everything worked again: the Extension Development Host properly loaded the extension and setting breakpoints worked.
$ git diff
diff --git a/lsp-sample/package.json b/lsp-sample/package.json
index 8558cfa..ac07de0 100644
--- a/lsp-sample/package.json
+++ b/lsp-sample/package.json
@@ -16,7 +16,9 @@
        "engines": {
                "vscode": "^1.74.0"
        },
-       "activationEvents": [],
+       "activationEvents": [
+               "onLanguage:plaintext"
+       ],
        "main": "./client/out/extension",
        "contributes": {
                "configuration": {

Also not sure this matters, but I noticed that the vscode version in https://github.com/microsoft/vscode-extension-samples/blob/main/lsp-sample/client/package.json is still 1.63.

Well in my case it's actually not working and I reckon it's because I have enabled the new Settings Profiles, so it might not be pulling the extension folder the right way anymore? Know anything about this?

I also had the same issue,
adding this settings in the root package.json and restarting everything fixed it for me
Complete package.json
 "languages": [ 			{ 				"id": "plaintext", 				"extensions": [ 					".txt" 				], 				"aliases": [ 					"Plain Text" 				] 			} 		]

Thank you so much @ankrgyl . I have spent a lot of time to understand why it was not working? 😢
Everything worked the moment I added the the activation event back. ❤

I updated all dependencies here: https://github.com/microsoft/vscode-extension-samples/pull/826 and tested the extension. I can start and debug the extension out of VS Code when opening the lsp-sample folder.
Will close the issue. Please ping if it still doesn't work after the PR is merged.


Login with Facebook error: "User can not view this application due to developer settings"

Describe your environment

Objective C or Swift: ____Swift
iOS version: _____10.0
Firebase SDK version: _____4.0.20
FirebaseUI version: ____4.5.5
CocoaPods Version: ____1.5.0

Describe the problem:
At first I was getting known "This app is in development mode” error when trying to auth with FirebaseUI + Facebook. This was solved by making the app "available to the general public". After that I'm getting another error which reads:
"The user does not have sufficient rights to view the application. User can not view this application due to developer settings"
I followed all official instructions on setting up firebase & facebook in my app (info.plist, url types), tried different settings on developers.facebook.com, still don't understand what might cause the issue. On android version of the app login with Facebook works fine.
Relevant Code:
Presenting AuthViewController
func showAuthUI(delegate: FUIAuthDelegate) {
  presentModalViewControllerDerivedFrom({ (_) -> UIViewController in
      let authUI = FUIAuth.defaultAuthUI()
      authUI?.delegate = delegate
      let authViewController = authUI!.authViewController()
      return authViewController
  }, animation: true, completion: nil)
}

FUIAuthDelegate
extension ProfilePresenter: FUIAuthDelegate {

    func authUI(_ authUI: FUIAuth, didSignInWith authDataResult: AuthDataResult?, error: Error?){
        if let error = error as NSError? {
            if let errorMessage = error.userInfo["NSLocalizedDescription"] as? String {
                //Show Alert with message provided in 'errorMessage'
                print("auth ui didSignInWith authDataResult, error: \(errorMessage)")
            } else {
                //Show General Alert
                print("auth ui didSignInWith authDataResult, general error")
            }
        } else if let user = authDataResult?.user {
            //Logged in
            // ...
        } else {
            // Unknow State
            print("auth ui didSignInWith authDataResult, unknown state")
        }
    }
}

AppDelegate
override init() {
        super.init()
        FirebaseApp.configure()
        let authUI = FUIAuth.defaultAuthUI()
    }

  func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey : Any]? = nil) -> Bool {

        let authUI = FUIAuth.defaultAuthUI()

        let providers: [FUIAuthProvider] = [
            FUIGoogleAuth(),
            FUIFacebookAuth(permissions: ["public_profile", "email"]),
            FUIPhoneAuth(authUI:FUIAuth.defaultAuthUI()!),
            ]
        authUI?.providers = providers

        return true
    }

  func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any]) -> Bool {
        let sourceApplication = options[UIApplicationOpenURLOptionsKey.sourceApplication] as! String?
        if FUIAuth.defaultAuthUI()?.handleOpen(url, sourceApplication: sourceApplication) ?? false {
            return true
        }
        // other URL handling goes here.
        return false
    }

Login with other providers works just fine. Thanks in advance for any help.

This sounds like a Facebook issue and not a FirebaseUI issue. Consider also asking on StackOverflow or sending a ticket to Facebook developer support.

I've asked on SO, with no luck. Facebook support replied that they "don't support unofficial Facebook SDKs". Maybe somebody can explain what the error message "User can not view this application due to developer settings" actually means?

The only thing I was able to find was this Facebook developers page, which seems to suggest that all you have to do is toggle a setting in the app dashboard. However, since you're able to sign in on Android without issue, I doubt this is the cause of your problems. Are you able to reproduce this issue without FirebaseUI?


[WIP] Common and Master Changes for #1464

This is a subset of #1464 with all the integration tests and client changes reverted. This branch should only be used to review and should not be merged. Changes should be directed to the original wip branch and will be merged into this branch.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4715/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4716/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4729/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4732/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4735/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4743/
Test FAILed.

@gpang Overall the change looks good to me, main logical question is the retry policy in BlockMasterClient..

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4749/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4767/
Test FAILed.

Closing this as the comments have been addressed in the WIP branch or TODOs have been noted.


.gitignore from parent folders?

Hi,
Is there a way to tell ag to use .gitignore files from parent directories as well? Otherwise, starting a search from a subdirectory returns lots of irrelevant results.
Thanks!
Clément.

+1

Relatedly, if I am in directory repository_root and run ag somestring dir/, ag is not honoring repository_root/.gitignore.

ag, as currenly implemented, looks for .gitignore only in the dir being searched.
Every time it opens a new directory.

Duplicate of #144


Add ResourceFeedback and Bump Version to 4.3.8

Add ResourceFeedback and bump gem version to 4.3.8
Issue: https://github.com/Shopify/product-publishing-feedback/issues/193

I am not sure if we need to ping someone else.

@jamiemtdwyer I tested it by checkout the branch locally then change the gem file in facebook-commerce to point to the path where I clone the shopify_api and do a bundle install.

Should I wait on merging the gem? I am not sure how the release works.


Text blocks should be black instead of the theme color

Currently the fields that have text change with the theme color. This looked good on the mockups because there were not paragraphs of text there. When you see a lot of text in a color, it makes it overwhelming and harder to read. So it would be better to have the text blocks be black or white. This is the corresponding web issue.

Hey @tallent . I am Shubham Shah, a contributor to OpenForce 2022.
I would like to work on this issue
Can you brief me more about the issue before I send my PR.


Prototype Pattern

Prototype Pattern should be translated into Turkish.
Source: patterns.dev

Teşekkürler, kolay gelsin @dogancanulgu 🚀


Spike: Add integration test

Some test scenarios

No worries. I created these tests for the middleware and used them to confirm/ showcase test scenarios. Your tests look good


Make release builds the default

Presently, the default build is an assert build.  The default should be the peak performance build, release, in particular for CI perf testing.  Correctness tests could run w/ assert.
I recently got release builds working, but they regressed as developers use TT_ASSERT in the "default" statement of a switch.  Some of those cases fail to compile without the TT_ASSERT due to errors such as "variable may be used uninitialized in this fn".
Flipping to release as default will prevent these regressions from showing up again.
fyi: @tt-rkim

I believe there were runtime crashes that need to be resolved

CI builds are the default in CI, which is release build with DEBUG symbols.
We could try changing to release build for perf pipelines and see what kind of gains we get there>?

Here's a test run with release build https://github.com/tenstorrent/tt-metal/actions/runs/8808018734/job/24176285444

Looks pretty bad.  Can we try a run w/o -lto to see if it is lto or other?  Not clear to me why there would be so many issues, I even saw one mentioning an "assert" failure which...should be gone?

Something I just noticed while working with CMake: building with LTO enabled, or -flto flag set will break some tests
I accidentally built ttnn pybinds with -flto and test_print_tensor, test_reports` broke with assert failures.

here is a passing post commit with release build: https://github.com/tenstorrent/tt-metal/actions/runs/8950170132
Failures were bc:

TT_ASSERT is not defined for release build, so every test relying on that failed
a validate step in ttnn's run_operation is not defined, so tests such as tests/ttnn/unit_tests/test_validate_decorator.py would fail

Not sure if we want to define these in release build or keep them as DEBUG only and find another way?

How do tests relay on TT_ASSERT?  That's broken.  Asserts go away in release builds.  If they need to flag an error, they need to use TT_FATAL.

An example would be tests/tt_metal/tt_metal/unit_tests/host_apis/test_tilize_untilize.cpp tests such as TestTilizeThrowErrorForInvalidTileMandN that relies on the TT_ASSERT inside tt_metal/common/tilize_untilize.hpp to throw an exception to get caught by a EXPECT_ANY_THROW
TT_ASSERT(input.size() > 0 and m > 0 and n > 0, "None of the input size, m, nor n can be 0");
TT_ASSERT((input.size() % (m * n)) == 0, "Input size must be divisible by m  and n");

Validating API inputs must be done w/ TT_FATAL, not assert.  Asserts are for internally generated values when you want to confirm some invariant.  Looks like the code in tileize_untilize should be changed.

I think we need an effort to go and scan runtime code to change any production input validation from TT_ASSERT to TT_FATAL per @pgkeller
Can we bump this up on priority to enable release builds (ie. more perf!!) ?
cc: @TT-billteng

fwiw, I did this once a few months back, I suspect it isn't too far off what we need, however, we aren't consistent on how we handle this which makes the task harder...

should be done in this PR: https://github.com/tenstorrent/tt-metal/pull/8176

device perf in Release: https://github.com/tenstorrent/tt-metal/actions/runs/8987453667
models perf in Release: https://github.com/tenstorrent/tt-metal/actions/runs/8987456170
There was a slight improvement in models perf on Release build.

device perf in Release: https://github.com/tenstorrent/tt-metal/actions/runs/8987453667
models perf in Release: https://github.com/tenstorrent/tt-metal/actions/runs/8987456170
There was a slight improvement in models perf on Release build.

We should update the targets
This doesn't include the performance governor yet ?

No, performance governor is a machine dependent thing and @TT-billteng and @tapspatel are working on that.
Orthogonal to @vtangTT 's work here

Release build is fixed in main: https://github.com/tenstorrent/tt-metal/pull/8176


Update -Ztimings with CPU usage information

This commit updates the graph generated by -Ztimings to include CPU
usage information, ideally showing how Cargo/rustc used the CPU
throughout the build, ideally seeing nice periods of parallelism and
also periods of missed parallelism.

r? @nrc
(rust_highfive has picked a reviewer for you, use r? to override)

An example graph for building the compiler looks like this: http://gistpreview.github.io/?74d799739504232991c49607d5ce748a
and an example graph for cargo looks like http://gistpreview.github.io/?4c9e55c90cc58a908b7074a551ce5a89

r? @ehuss

This is awesome, thanks!
@bors r+

:pushpin: Commit 1d5d19e0e7c508304ec0d508d22790f8e764970a has been approved by ehuss

:hourglass: Testing commit 1d5d19e0e7c508304ec0d508d22790f8e764970a with merge b385d51ef64b4be32e84c4b0aee30dfe3828a5ba...

:sunny: Test successful - checks-azure
Approved by: ehuss
Pushing b385d51ef64b4be32e84c4b0aee30dfe3828a5ba to master...


To install pytorch 1.0:   conda install pytorch==1.0.0 torchvision==0.2.1 cuda100 -c pytorch

The command given by the author seems to install the latest pytorch

https://pytorch.org/get-started/previous-versions/


Revamp process

Using multiple_choice.
The core feature to understand is how to use doc_to_choice which process the doc to a set of viable options that will be used to construct instances during construct_requests.
                choices = self.doc_to_choice(doc)

The next question is which part uses the choices? This can be either (i) the continuation side; which is what most tasks like boolq, copa, cb, etc do. i.e given an input string the prediction is the continuation with the highest loglikelihood or (ii) the context side; which is required for some tasks like winogrande that has a static output string and different input strings (although the model prediction is still the one with the highest loglikelihood score).
Which part the choices goes to is determined by the output of doc_to_text and doc_to_target.

If doc_to_text returns an integer (referring to the gold index of that sample) then doc_to_choice will be used as the context side, this is what we can call Multiple Input - Singular Choice.

                cont = self.doc_to_target(doc)
                arguments = [(ctx, " {}".format(cont)) for ctx in choices]

If doc_to_target instead returns an integer, then doc_to_choice will be used for the continuation side which we can call Singular Input - Multiple Choice.

                arguments = [(ctx, " {}".format(cont)) for cont in choices]

The requests are then built like this.
            request_list = [
                Instance(
                    request_type="loglikelihood",
                    doc=doc,
                    arguments=arg,
                    idx=i,
                    **kwargs,
                )
                for i, arg in enumerate(arguments)
            ]

There can also be the case of Singular Input - Multiple Targets. In this case, doc_to_target should return a list of integers. A prediction will be considered correct if the predicted index is in the list of viable targets.
Notable changes:

create_choice changed to doc_to_choice for consistency
doc_to_choice accepts (1) dict, (2) list, as well as (3) a function or (4) jinja strings and expects to return a list.
doc_to_text and doc_to_target accepts strings that refer to a column in the dataset like label.
If doc_to_target returns an integer, for loading fewshot samples (in samplers.py), it will use doc_to_choice to convert the integer to the appropriate gold string.
Simplified jinja2 strings to avoid using set and instead work with variables in the doc directly.
Removed usage of gold_alias

I was thinking of making it doc_to_choices but wasn't sure if that would cause people to make typos? doc_to_choice seemed more resilient to users writing it wrong. But if you think otherwise, I think it's okay to opt for choices


travis: update go versions

Codecov Report

Merging #1250 into master will decrease coverage by 5.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
- Coverage   52.45%   46.82%   -5.63%
==========================================
  Files         131      131
  Lines       12373    12373
==========================================
- Hits         6490     5794     -696
- Misses       5124     5875     +751
+ Partials      759      704      -55

Impacted Files
Coverage Δ

internal/backend/b2/b2.go
0% <0%> (-79.32%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-73.9%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-61.93%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-59.85%)
:arrow_down:

internal/backend/swift/config.go
34.37% <0%> (-56.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c784a15...94c8ee1. Read the comment docs.

I tried this already in #1012, but unfortunately versions of Go Travis uses in that case are not the latest one. :(

Please look again, i think that travis use correct versions now.

Yeah, judged by my other project, the versions are now up to date. We can only hope it stays that way, otherwise 1.x.y notation doesn't make much sense.


More rubocop cleanup

This removes more findings from the rubocop to-do list.

Reviewed the changes and tested csv2kdi successfully.


Automatic formatting for Album & Item

Cut the need to format manually (and often incorrectly) when logging by implementing the __format__ magic method.
In beets.ui,

delete _pick_format
update print_obj
improve print_
add format_ (like format but the format spec can be None)

Next steps are:

adapt print & logging in plugins: if there's no real intent for a special formatting, just use the template configured (future commits in this PR)
make -p (path) and -f (format) top-level options that can be used in all situations (future PR, raises option name conflicts problems)
rename options list_format_{item,album} to format_{item,album}? (can be this PR, + we should keep the current names for retro-compatibility in any case)

This started by a discussion on PR #1262.

Looks great. This simplifies a lot of logging and listing statements, which is awesome to have. I have a few comments inline.
I conceptually like making -p and -f top-level flags, but for some reason that seems a little less intuitive to me from a CLI UI standpoint. Typing beet ls -p seems so much more natural to me than typing beet -p ls. I'm not sure what the right solution is, but I would love to find something that both avoids duplication and yet still feels intuitive.

Modulo these last two tiny behavioral tweaks (do we need format_, and how should print_ handle non-strings) this looks ready. We can tackle the other work (possibly renaming config options, and tracking down any other spuriously specific formatting) after merging.

Since print_() expecting strings has been working fine so far the best if probably to keep it that way: I removed the added check+cast in print_() and adapted a couple of print_(item).

Awesome. I'll merge this now & write a changelog entry.

Merged up! Thanks again for taking care of this. :sparkles: It's something I've been hoping to clean up for a long time.
This and #1271 might also make the PR in #1092 more palatable in the short term. Woohoo!


Get the framebuffer size and use it instead of DeviceScaleFactor

This sounds more portable.
GLFW: https://stackoverflow.com/questions/36672935/why-retina-screen-coordinate-value-is-twice-the-value-of-pixel-value

https://github.com/glfw/glfw/blob/1adfbde4d7fb862bb36d4a20e05d16bf712170f3/src/x11_window.c#L2231-L2234
Hm, this doesn't work on Unix/Linux well.