Run as admin and run at startup options do not persist after restart

Microsoft PowerToys version
0.61.1
Running as admin

[X] Yes

Area(s) with issue?
Settings
Steps to reproduce
Run powertoys as user.
Choose "Always run as admin"
Choose "Run at startup"
Exit from menu bar.
Exit from taskbar icon.
Check Task manager processes - not listed.
Reboot
Check Task manager processes - not listed.
goto step 1
✔ Expected Behavior
Powertoys to run at startup
Run as Admin & at startup options to persist in "on" state.
❌ Actual Behavior
Powertoys does not run at startup
Run as Admin & at startup options are in "off" state.
Other Software
No response

I have the same issue. I launch Powertoys from a short cut that has the properties set to run as admin. After the UI is open underneath the "Administrator mode" setting it shows "Running as administrator" and "Restart PowerToys as administrator" is greyed out.  "Always run as administrator" is not selected, though I have had this option selected for as long as Powertoys has been released. After I select "Always run as administrator", when I close the UI it reverts back to what it was before. Also the option to enable Awake won't stay set either. I turn it on, exit the UI and it's turned back off.
I have also tried running directly from the exe in folder C:\Program Files\PowerToys, then selecting "Restart PowerToys as administrator". The UAC asks for permissions, and like above it shows "Running as administrator". But closing the UI still results in the settings reverting back.
I know this isn't just a UI issue because I normally use Awake to keep my windows logon from going to sleep. With PowerToys running in the system tray Windows locks at the 15 minute inactivity timer showing that the Awake option isn't working. If I leave the PowerToys UI open, but minimized then Awake prevents Windows from locking as it should.
If I select the option to "Report Bug" it pops up and says the zip file was created on my desktop. But there's no zip file there. I've tried refreshing my desktop and running "Report Bug" multiple times. Nothing. Also tried rebooting.

Thank you for the workaround: "If I leave the PowerToys UI open, but minimized then Awake prevents Windows from locking as it should."
I only noticed this issue with version 0.62.

I installed 62.1 and tried again to create a "Report Bug" zip file to help with triaging this issue (Running as admin settings doesn't retain), but Report Bug still doesn't create a zip file on the desktop. And yes, I created folder %userprofile%\AppData\LocalLow\Microsoft\PowerToys\Logs. Anyone researching the Run as Admin and Awake settings not persisting?

FYI - I was able to fix mine by manually modifying the settings.json file in folder %userprofile%\AppData\Local\Microsoft\PowerToys
Not sure it's totally correct, but it's working for me. I changed "is_elevate", "run_elevated", and "is_admin" to true.
I don't have "Run at startup" toggled on because my user account is a standard account and I need to start PowerToys manually so I can enter my admin credentials. But I'm guessing you can change value "startup" to true to fix that as well.
{"startup":false,**"is_elevated":true,"run_elevated":true,"is_admin":true**,"theme":"system","system_theme":"light","powertoys_version":"v0.63.0","action_name":"","enabled":{"FancyZones":false,"Image Resizer":true,"File Explorer Preview":true,"Shortcut Guide":false,"Video Conference":true,"PowerRename":true,"Keyboard Manager":false,"PowerToys Run":false,"ColorPicker":false,"Awake":true,"FindMyMouse":true,"MouseHighlighter":true,"AlwaysOnTop":true,"MousePointerCrosshairs":false,"QuickAccent":false,"TextExtractor":true,"Measure Tool":true},"download_updates_automatically":false}

FYI - I was able to fix mine by manually modifying the settings.json file in folder %userprofile%\AppData\Local\Microsoft\PowerToys
Not sure it's totally correct, but it's working for me. I changed "is_elevate", "run_elevated", and "is_admin" to true.
I don't have "Run at startup" toggled on because my user account is a standard account and I need to start PowerToys manually so I can enter my admin credentials. But I'm guessing you can change value "startup" to true to fix that as well.
{"startup":false,**"is_elevated":true,"run_elevated":true,"is_admin":true**,"theme":"system","system_theme":"light","powertoys_version":"v0.63.0","action_name":"","enabled":{"FancyZones":false,"Image Resizer":true,"File Explorer Preview":true,"Shortcut Guide":false,"Video Conference":true,"PowerRename":true,"Keyboard Manager":false,"PowerToys Run":false,"ColorPicker":false,"Awake":true,"FindMyMouse":true,"MouseHighlighter":true,"AlwaysOnTop":true,"MousePointerCrosshairs":false,"QuickAccent":false,"TextExtractor":true,"Measure Tool":true},"download_updates_automatically":false}

The above fixed the 'run as admin' and 'run elevated' issues, but not the 'run at startup'

As a standard user, the above fix worked. As admin the startup settingalso worked after I placed a shortcut in the startup folder while running as admin. I


Import CellExecutionError from nbconvert from the right place

newer versions of nbconvert now define CellExecutionError only from nbconvert.preprocessors
I guess also a test is missing which made this part of code never trigger the crash ( I get it because in my sphinx build something is triggering it)

Thanks for this PR!
If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in https://github.com/jupyter/nbconvert/commit/c62f6e4cd5d666a435b4e59ded6fc35b1cb81f87.
BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

Thanks for this PR!
If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in jupyter/nbconvert@c62f6e4.

will do

BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

I see that the error has to do with the absence of pkg_resources.
As far as I know that dependency to deal with resources is deprecated in recent python versions in favor of importlib_resources.

The CI issues seem gone anyway

The CI error has been fixed (or rather worked-around) in #773.
Can you please re-base?

Thanks!


Fix SessionApiTest for real

Goal
Fix SessionApiTest by actually removing the expectation of the disk space attribute smdh

#1418  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Sep 24, 12:07 PM EDT: Graphite rebased this pull request as part of a merge.


Implement Github Action to programatically discover publishable libraries

idea: https://www.peterbe.com/plog/programmatically-control-the-matrix-in-a-github-action-workflow
Collect all non-private packages in the workspace

Implemented in https://github.com/AlexAegis/collect-public-packages


Find a way to store and compare artifacts from the performance tests

Summary
Store and compare performance test artifacts
Ticket Link
https://mattermost.atlassian.net/browse/MM-47869
Release Note
-->
NONE

@hmhealey fixed the path to the artifacts, you can download them now :)

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard


Thank you and question

First, thank you Andy for taking over and continuing development of FlexiRest (formally ActiveRestClient). As restful API's proliferate, having tools for consuming them based on conventions versus configurations become ever more important.
This is not an issue, but a question on best practices.
I need to add values to the body of all my requests. A Configuration module contains methods for setting and getting the userid and source values. Currently, I am doing the following.
module MyRestClient
  class Base < FlexiRest::Base
    include Configuration
    def initialize(args = {})
      super
      self.userid = self.class.userid
      self.source = self.class.source
    end

  end
end

module MyRestClient
  class Product < Base
    post :create, "/products"
  end
end

Is this the preferred method, or would you recommend another?

Sorry for the delay @hoenth, I apparently wasn't watching my own repository so I only noticed this issue when I came to look at the PR your emailed me about.
Given that you don't know at the point of defining your userid/source whether they'll be post or get variables, I think this is a sensible solution.  I personally would put the super after the initialisation of the variables (otherwise they will always override those variables if they happen to be set in a subclass), but that may be what you want.
The other solution would be a before_request callback on a base class, but to do that you'd need to know if they were always going to post or get variables.


Build fails with Xcode 10.2.* due to dependency build failure (Result 3.2.4)

Build fails with Xcode 10.2.* due to dependency build failure (Result 3.2.4)
*** Building scheme "Result-Mac" in Result.xcodeproj
Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/maxim/Carthage/Checkouts/Result/Result.xcodeproj -scheme Result-Mac -configuration Release -derivedDataPath /Users/maxim/Library/Caches/org.carthage.CarthageKit/DerivedData/10.2.1_10E1001/Result/3.2.4 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/vj/6123n5bd4374b__flrnclmdh0000gn/T/Result SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/maxim/Carthage/Checkouts/Result)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/vj/6123n5bd4374b__flrnclmdh0000gn/T/carthage-xcodebuild.cdAWDD.log

It should work on master. I can create a new release if that'd be helpful.

@mdiep please do!
BTW dependency on Result framework can probably be removed as Swift 5 has built-in result type.

https://github.com/SwiftGit2/SwiftGit2/releases/tag/0.6.0


Push to Sonatype

Hey guys, cool project! :)
Could this get pushed to Sonatype?

Oops, my bad. It's in Sonatype, but hasn't had a release yet. Thanks!


Painting Fence problem in Julia

💥 Proposal
Painting Fence problem in Julia
Have you read the Contributing Guidelines on Pull Requests?
YES

/assign


DiscordServerStatus heads up settings

DiscordServerStatus heads up settings
README.md and the DiscordServerStatus plugin have a extra text lenght to inform everyone that you must have "Message Content Intent" enable on your discord Bot. Otherwise it won't be able to read the request inside the discord channel.

Still awaiting merge.

Awaiting merge?


Update Contributing doc to update "VMware CLA should be signed "

Moving to CNCF Sandbox project , need to update the contributing.md

An example from harbor contributing

As Carvel has integrated the DCO (Developer Certificate of Origin) check tool, contributors are required to sign off that they adhere to those requirements by adding a Signed-off-by line to the commit messages.  Example, the security stuff on the website: https://carvel.dev/shared/docs/latest/security-policy/

updated contributing: https://github.com/carvel-dev/carvel/pull/634
need to update security and development guidelines...


injectable config

Config can be provided as managed bean in Spring

This change is

See https://github.com/canoo/dolphin-platform/issues/409

Coverage decreased (-0.04%) to 66.481% when pulling bf4076ae1a83a47d2973628ab2e564071f08fd31 on inject-config into cde4555f8aca4e41a663077ff10ce8098cece7d1 on master.


Refactor filesystem, fsContext into JobMaster/Worker contexts

This change moves the creation of FileSystem/Context out of
the job definitions and into the respective master/worker
processes. The processes should aim to create clients as few
times as possible because of all the underlying threadpools
and resources that are needed to instantiate a client.
The JobMaster and JobWorkers now pass in a single instance
of a filesystem client+context when selecting executors and
running tasks. This greatly reduces the amount of resources
that the job master and workers consume when there are lots
of jobs being executed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2691/
Test PASSed.

For context - Before this PR I tested this change locally by creating a directory tree with 5000 files with write type MUST_CACHE. I attempted to persist the directory with ./bin/alluxio fs persist /file-tree and the master/job master basically came to halt and couldn't handle any more than a hundred or so persist jobs. Logs would fill with things errors like "too many open files", "Job failed", etc.
After this change I was able to run this without any problem, even adding more concurrent persist jobs (./bin/alluxio fs persist -p 500, 500 concurrent persists) executed without any hiccups

@ZacBlanco Could you create a follow up PR which addresses the following two concerns:

Use Job*Context as early as possible in the call stack
Rename Job*Context to more suitable names, if any

Will do, thanks!

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2701/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2702/
Test PASSed.

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, merge this please


[CARBONDATA-1048] Updated Hive Guide

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2019/

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2020/

retest this please

retest this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/476/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3065/


Unable to edit IP under connections unless you are a superuser.

When trying to edit the IP address attached to a connection doesn't show the edit button, unless you have the superuser rights?
Am I missing something?
Which permission should I enable for a user to allow this?

The button is displayed if the user has the permission "IPAM > IP address > Can add IP address."

OK. This is enabled for the group and was working prior to the update to version 2.0.1.
Maybe this permission is no longer being picked up?

I've created a new user and assigned it the permission, and the button shows up as expected under 2.0.1 when logged in as that user.

Its the editing of the IP address which I am unable to do. One can add an address to an interface, but once its added, you can only remove it, not edit it.
eg: the blue pencil edit button is not displayed.

Apologies, I was focusing on the "add" button. Yep, the permission is incorrectly named in the template.

awesome thanks!


Correct WMTiming metrics to be collected at the job wrapper

Impact of the bug
WMAgent
Describe the bug
This issue:
https://github.com/dmwm/WMCore/issues/11604

initially conceived as a meta-issue style - requested timing metrics to be provided for the whole grid job.

Changes have been added to the bash job wrapper, but they apply those new metrics against the wrong Report pickle file.
Said that, this issue is to track the remaining investigation AND resolution/implementation of that feature.
How to reproduce it
Needs to have a job going through the agent, then looking into the documents uploaded to WMArchive.
Expected behavior
Some investigation is still required to find out what is possible and the best approach to finish this implementation. It could either be:
a) that at the job wrapper, we can actually persist these metrics in the correct FJR/Report (which is then automatically consumed by one of the agent's components)
b) or, that we will have to consume an indirect Report file and push it to the document that gets persisted in local CouchDB
c) yet another alternative would be to use multiple data source in the ArchiveDataReporter, such that the final document uploaded to WMArchive is enriched with the WMTiming metrics.
Once we have a clear path ahead, we need to implement the final details and conclude this feature. All to be addressed with this ticket.
Additional context and error message
Follow up of ticket https://github.com/dmwm/WMCore/issues/11604

@vkuznet Valentin, I ran a workflow with further debug statements and it turns out we are actually failing to add the WMTiming section to the report (this error is supposed to be in the standard logging level):
======== WMAgent add timestamps metrics to FJR Report.0.pkl ========
AMR Adding timestamps to report file: /srv/job/Report.0.pkl
WARNING: failed to update FJR with timestamps metrics, status=2
======== WMAgent finished adding timestamps metrics to FJR ========

and the directory structure is (I removed lines that make no difference for this task):
WMAgent bootstrap: WMAgent finished the job, it's copying the pickled report
AMR upper directory content (/srv):
-rw-r--r-- 1 cmsgli us_cms   71858 Sep 16 12:18 JobPackage.pkl
-rw-r--r-- 1 cmsgli us_cms     637 Sep 16 12:18 Report.0.pkl
drwxr-xr-x 7 cmsgli us_cms    4096 Sep 16 12:18 job
-rw-r--r-- 1 cmsgli us_cms   31834 Sep 16 12:58 wmagentJob.log

AMR WMTaskSpace content (/srv/job/WMTaskSpace):
-rw-r--r-- 1 cmsgli us_cms 24131 Sep 16 12:58 Report.0.pkl
drwxr-xr-x 4 cmsgli us_cms  4096 Sep 16 12:44 cmsRun1
drwxr-xr-x 4 cmsgli us_cms  4096 Sep 16 12:50 cmsRun2
drwxr-xr-x 4 cmsgli us_cms  4096 Sep 16 12:58 cmsRun3
drwxr-xr-x 3 cmsgli us_cms  4096 Sep 16 12:58 logArch1
drwxr-xr-x 3 cmsgli us_cms  4096 Sep 16 12:58 stageOut1
-rw-r--r-- 1 cmsgli us_cms 24131 Sep 16 12:58 WMTaskSpace/Report.0.pkl

WMTaskSpace/cmsRun1:
-rw-r--r--  1 cmsgli us_cms     24363 Sep 16 12:43 FrameworkJobReport.xml
-rw-r--r--  1 cmsgli us_cms      5693 Sep 16 12:58 Report.pkl

WMTaskSpace/cmsRun2:
-rw-r--r--  1 cmsgli us_cms    307561 Sep 16 12:50 FrameworkJobReport.xml
-rw-r--r--  1 cmsgli us_cms      6268 Sep 16 12:58 Report.pkl

WMTaskSpace/cmsRun3:
-rw-r--r--  1 cmsgli us_cms   374092 Sep 16 12:58 FrameworkJobReport.xml
-rw-r--r--  1 cmsgli us_cms     9767 Sep 16 12:58 Report.pkl

WMTaskSpace/logArch1:
-rw-r--r-- 1 cmsgli us_cms    2199 Sep 16 12:58 Report.pkl

WMTaskSpace/stageOut1:
-rw-r--r-- 1 cmsgli us_cms 1407 Sep 16 12:58 Report.pkl
======== WMAgent bootstrap FINISH at Sat Sep 16 12:58:35 GMT 2023 ========

In summary:

we need to understand why it fails to add the WMTiming section to the job report file
report pickle files can be found in 3 different locations, such as:
/srv/job/Report.0.pkl
/srv/Report.0.pkl  # copied from WMTaskSpace/Report*.pkl at the end of the job wrapper
/srv/job/WMTaskSpace/Report.0.pkl
/srv/job/WMTaskSpace/STEP_NAME/Report.0.pkl  # like cmsRun1, cmsRun2, logArch1, stageOut1

Which makes me think that we should wait for the Report.0.pkl to be copied and then add the WMTiming to that file. OR, add the WMTiming to "/srv/job/WMTaskSpace/Report.0.pkl" before it gets copied to a different location.
In addition, the condor job definition is defined like:
  TransferOutput = "Report.0.pkl,wmagentJob.log"

that means what is returned to the agent/schedd is actually /srv/Report.0.pkl. I believe this file will contain the CMSSW metrics that we add in the worker node and WMTiming, once we fix the latter.

Alan, thanks for looking this during my absence. I'll proceed with this info further.

This has been fixed by https://github.com/dmwm/WMCore/pull/11726 (which was mistakenly mentioned to be fixing the old issue). Closing this one out now.


Changed infoHash to always be hex

This is part of a suggested fix for: https://github.com/feross/webtorrent/issues/374

Merged, changed some things for clarity in https://github.com/feross/bittorrent-tracker/commit/e9322a32d6a84501a89983c7f5242dd7b595daf5, and released as 6.1.0.


Kuberhealthy creates incorrect host name when posting externalcheckstatus when not in kuberhealthy namespace

Describe the bug
When running kuberhealthy locally in the default namespace, the host name we try to report the success or failure of the kuberhealthy check defaults to the kuberhealthy namespace.
Steps To Reproduce

Run kuberhealthy locally in default namespace or any namespace not kuberhealthy
Run a kuberhealthy check

Expected behavior
The success or failure report should be sent to kuberhealthy.default.svc.cluster.local instead of kuberhealthy.kuberhealthy.svc.cluster.local
Screenshots
time="2019-09-25T00:22:32Z" level=info msg="Error reporting success to Kuberhealthy servers: Post http://kuberhealthy.kuberhealthy.svc.cluster.local/externalCheckStatus: dial tcp: lookup kuberhealthy.kuberhealthy.svc.cluster.local: no such host"

This fix is pushed and available in the quay.io/comcast/kuberhealthy:2.0.0alpha2 image.


Upgrade pinned black version

The old version of black started producing the following error when calling check/format-incremental --apply:
ImportError: {...}/python3.9/site-packages/typed_ast/_ast3.cpython-39-x86_64-linux-gnu.so:
undefined symbol: _PyUnicode_DecodeUnicodeEscape

Upgrading resolves the issue.

For deeper context: https://github.com/python/typed_ast/issues/169.


Test local debug

Summary by CodeRabbit

Chores

Enhanced the linting process to provide a preview of formatting changes before checks.

New Features

Introduced a new variable in the application code, maintaining existing functionality.

@alexcrtestapp full review


Implement Hashable conformance for Tuples

The relevant commit is the last one where I implement the conformance. The rest of the commits come from https://github.com/apple/swift/pull/30142
Tests coming soon™
cc: @jckarter @rjmccall

P.S. It feels super crazy to be able to have tuple keys for dictionaries!
var grid = [(x: Int, y: Int): String]()
grid[(x: 0, y: 0)] = "Bob"
print(grid[(x: 0, y: 0)]) // Bob

@Azoy, can you update this PR and fix the conflicts so that we can evaluate its impact on source compatibility? Could you also remove the redundant operator definitions in https://github.com/apple/swift/blob/master/stdlib/public/core/Tuple.swift.gyb?
The SE proposal mentions https://github.com/apple/swift/pull/30142 and https://github.com/apple/swift/pull/28833, but this seems to be a superset of those. I think it makes sense to just have this all on one PR so we can use CI to do source-compatibility testing. I noticed that https://github.com/apple/swift/pull/28833 does have an additional commit https://github.com/apple/swift/pull/28833/commits/7af1562f477d556cb2cf8de97d7e6d2fe90636fb, is that needed here?
Thanks

@milseman In the equatable pr I asked Joe about separating the prs, so I’ve been working on that pr to solidify a design. I can pull in the comparable changes and these changes into that pr if it makes things easier for testing. I’ve been fixing conflicts and updating the implementation for equatable these past couple of days, so I’ll push those soon.

@Azoy great, can you CC me on the PR you decide to go off of and close the others when it's ready? Thanks

This is superseded by https://github.com/apple/swift/pull/28833


Eliminate htmlproofer suppressions

htmlproofer is failing on some pages. We should determine the cause of the failures and fix the root causes. We generally should not be disabling htmlproofer.
One example is in .travis.yml:
  - bundle exec htmlproof ./_site --only-4xx --check-html --file-ignore "/mlab_observatory/" --href-ignore "http://projectbismark.net/signup.html"
We should remove the ignores. Are there others?

Here is one more example of a broken link that we may need to add an ignore on the htmlproofer to temporarily solve.
On this page (http://www.measurementlab.net/who/), there is a link to http://www.measurementlab.net/getinvolved, however, this page does not exist on the current site.  Any thoughts on where that is supposed to go?  Maybe to /contribute/ perhaps?
On that same page, there are also several links on that page linking to the same page itself (/who/).  This doesn't break html proofer per say, but felt like I'd mention it here to be sure that's what is desired.

Andrew,
The link to "get involved" should go to the contribute page, as you
suggested. The links to /who/ on this page can be removed.
Thanks,
Chris
On Feb 21, 2016 11:45 AM, "Andrew Newhouse"<EMAIL_ADDRESS>wrote:

Here is one more example of a broken link that we may need to add an
ignore on the htmlproofer to temporarily solve.
On this page (http://www.measurementlab.net/who/), there is a link to
http://www.measurementlab.net/getinvolved, however, this page does not
exist on the current site. Any thoughts on where that is supposed to go?
Maybe to /contribute/ perhaps?
On that same page, there are also several links on that page linking to
the same page itself (/who/). This doesn't break html proofer per say, but
felt like I'd mention it here to be sure that's what is desired.
—
Reply to this email directly or view it on GitHub
https://github.com/m-lab/m-lab.github.io/issues/27#issuecomment-186855913
.

Thanks for the clarifications @critzo .  I made these updates in the https://github.com/m-lab/m-lab.github.io/pull/41 pull request.

Adding to the list of things we want to grep for and remove at some point:

href-ignore
data-proofer-ignore


SFC installation error

Service Fabric Runtime Version: 7.2.445.9590
Environment: Standalone
Description: I'm using a new Windows 2016 installation on an Azure VM. Firewall down, NSG completly open. When I try the TestConfiguration.ps1 script with a config having iPAddress set to FQDN or external IP address of the server, the script fails:
PS C:\asf> .\TestConfiguration.ps1 -ClusterConfigFilePath letva.json
Trace folder doesn't exist. Creating trace folder: C:\asf\DeploymentTraces
Running Best Practices Analyzer...
Opening TraceWriter SFDeployer, path C:\asf\DeploymentTraces\SFDeployer-637433564841934494.trace
Config validation: Certificate *.mydomain.hr is not installed on node test1971.westeurope.cloudapp.azure.com under My. Check the node availability, certificate installation, and the remote certificate store read permission on the nodes.
Best Practices Analyzer determined environment has an issue. Please see additional BPA log output in DeploymentTraces folder.
Closing TraceWriter SFDeployer, path C:\asf\DeploymentTraces\SFDeployer-637433564841934494.trace

LocalAdminPrivilege        : True
IsJsonValid                : False
IsCabValid                 :
RequiredPortsOpen          :
RemoteRegistryAvailable    :
FirewallAvailable          :
RpcCheckPassed             :
NoDomainController         :
NoConflictingInstallations :
FabricInstallable          :
DataDrivesAvailable        :
DrivesEnoughAvailableSpace :
Passed                     : False

Test Config failed with exception: System.InvalidOperationException: Best Practices Analyzer determined environment has an issue. Please see additional BPA log output in DeploymentTraces folder.
   at System.Management.Automation.MshCommandRuntime.ThrowTerminatingError(ErrorRecord errorRecord)

However, the certificate is installed, and if I use internal IP address of the server, everything is fine:
PS C:\asf> .\TestConfiguration.ps1 -ClusterConfigFilePath letva2.json
Trace folder already exists. Traces will be written to existing trace folder: C:\asf\DeploymentTraces
Running Best Practices Analyzer...
Opening TraceWriter SFDeployer, path C:\asf\DeploymentTraces\SFDeployer-637433572542664589.trace
Best Practices Analyzer completed successfully.
Closing TraceWriter SFDeployer, path C:\asf\DeploymentTraces\SFDeployer-637433572542664589.trace

LocalAdminPrivilege        : True
IsJsonValid                : True
IsCabValid                 :
RequiredPortsOpen          : True
RemoteRegistryAvailable    : True
FirewallAvailable          : True
RpcCheckPassed             : True
NoDomainController         : True
NoConflictingInstallations : True
FabricInstallable          : True
DataDrivesAvailable        : True
DrivesEnoughAvailableSpace : True
Passed                     : True

The server in question is created from a shapshot that was already used to successfully install the cluster, so I know that with the internal IP address the installation will proceed successfully. I have noticed the problem with FQDN on a customer on-prem server, so the error is consistent across environments.
I observe the same problem on Windows 2019, and also if I add FQDN to local hosts file.
Config and traces: files.zip
Observed behavior: Not good, a confusing error message appears.
Expected Behavior: To be able to install the cluster.
OS(Windows/Linux): Windows
If this is a regression, which version did it regress from? n/a

Assignees: /cc @microsoft/service-fabric-triage

This VM was cloned from a snapshot if I understand correctly? I wonder if the ACL's need to be updated if the certs are still properly installed.
I'd recommend following these procedures and see if it helps get you further, specifically step 3
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-windows-cluster-x509-security#install-the-certificates

No, this is a clean Windows Server installation on a VM. I did follow the above-metioned procedure. Were the ACLs not set correctly, both checks (with internal IP and with FQDN) would fail.

Sorry for the delay, if you are still facing this issue I'd recommend filing a support case so we can assist further.
https://github.com/microsoft/service-fabric/blob/master/CONTRIBUTING.md#open-an-issue


Identify sumstats that have not been harmonised and harmonise them

[x] Identify unharmonised GWAS (sub harmonised from all)
[x] if has metadata and GWAS-SSF -> harmonised with v1.1.0)
[x] else create metadata file (pre-GWAS-SSF) -> filter where headers -> harmonise with v1.0.1
[ ] create metadata files for already harmonised sumstats (both raw and harmonised)

Will not be completed before James leaves.Should not need manual intervention once automated by gwas-utils#151. Will email gwas-dev-logs with success/fail. Failures will not hold up other files.

@jiyue1214 I think this ticket can be closed now, would you agree?


Radix node with multiple parameters

Describe the feature
Could radix3 support multiple parameters in a single node? The main use case is to represent a composite key in a URL.
For example: /patient/:name,:dob.
From RFC 3986

Aside from dot-segments in hierarchical paths, a path segment is considered opaque by the generic syntax.  URI producing applications often use the reserved characters allowed in a segment to delimit scheme-specific or dereference-handler-specific subcomponents.  For example, the semicolon (";") and equals ("=") reserved characters are often used to delimit parameters and parameter values applicable to that segment.  The comma (",") reserved character is often used for similar purposes.  For example, one URI producer might use a segment such as "name;v=1.1" to indicate a reference to version 1.1 of "name", whereas another might use a segment such as "name,1.1" to indicate the same.  Parameter types may be defined by scheme-specific semantics, but in most cases the syntax of a parameter is specific to the implementation of the URI's dereferencing algorithm.

Additional information

[X] Would you be willing to help implement this feature?

Hi thanks for issue and rfc reference. Let's track this via https://github.com/unjs/radix3/issues/11


Jesse: Watch ssalocator.livejournal.com

Jesse requests the watch of the watch_keyword ssalocator\.livejournal\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ssalocator\.livejournal\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


[FFmpeg][QSV][HEVC][DECODE] choose the best matched profile for profile-missing clips

Currently, unknown profile (parsed profile == 0) will cause the decode failure directly in
ffmpeg qsv.

cmdline:
$ ffmpeg -hwaccel qsv -hwaccel_device /dev/dri/renderD128 -v verbose -c:v hevc_qsv -i /root/media/testing/assets/hevc/id_main_SlideEditing_1280x720_30_qp22.bin -vf 'hwdownload,format=nv12' -pix_fmt yuv420p -f rawvideo -vsync passthrough -vframes 300 -y  test.yuv

(this clips could be shared internally if needed)

error message

Error while decoding stream #0:0: Invalid argument
[hevc_qsv @ 0x1ad0a00] video_get_buffer: image parameters invalid
[hevc_qsv @ 0x1ad0a00] get_buffer() failed
Error while decoding stream #0:0: Invalid argument

In msdk, UMC_HEVC_DECODER::MFX_Utility::CheckVideoParam_H265() returned an error directly if the profile is unexpected:
https://github.com/Intel-Media-SDK/MediaSDK/blob/5b23796ab993771718fec3b997c3f4a5c98c6c4c/_studio/shared/umc/codec/h265_dec/src/umc_h265_mfx_utils.cpp#L987

After some discussion in https://github.com/intel-media-ci/ffmpeg/pull/66,  we thought there is one possible solution to choose the best matched profile for these profile-missing cases. And this will make msdk more robust for all kinds of possible clips. (it seems in sample_decode, some default profile type will be chosen if the profile info is missing, I thought it would be good to step a little bit further)

Hi,
To resolve this issue i think you can use the function below
https://github.com/Intel-Media-SDK/MediaSDK/blob/5b23796ab993771718fec3b997c3f4a5c98c6c4c/_studio/mfx_lib/decode/h265/src/mfx_h265_dec_decode.cpp#L562
It should find best-matching codec profile too with this function
https://github.com/Intel-Media-SDK/MediaSDK/blob/5b23796ab993771718fec3b997c3f4a5c98c6c4c/_studio/mfx_lib/decode/h265/src/mfx_h265_dec_decode.cpp#L587
Also i would like you to share clips with me, so i can reproduce this issue

Hi@IlyaTikhanov , clips is shared internally.

The problem is broader than just selection of profile basing on given fourcc, because profiles like Rext\SCC allow 8\10b 420 streams (like main\main10) but requires special tools to be used for decoding, therefore requiring decoder to be initialized w/ certain VAProfile. So, in common, we can't properly initialize decoder basing on fourcc (bit depth, chroma format) only and can't guarantee correct output.
To somehow cope this we may initialize decoder w/ max supported (on certain platform) profile.

FFmepg qsv has swicted to MSDK parser, so it is not an issue now.

Closed, thanks for the support.


Open Preview on the side of Markdown documents

Add an "Open Preview to the side" interaction menu to right-clicked Markdown files (.md), and similar formats where you are often checking the preview, that allows you to open a preview on the side without having to drag it there yourself.

Have you tried using the already available keyboard command ⌘ + K   +   V for macOs and Ctrl + K   +   V for others or do you want a mouse command for that as well?

I didn't know there was a keyboard shortcut but I suppose a mouse command would be nice

There's a button in the toolbar of markdown files:


rm un-used apps

Pull Request
Description
remove website and ui-ux demos
How Has This Been Tested?

CI tests,

not tested, but these will be in git history

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Looks fine, should really test the main apps both build locally in case they have any funny dependencies on these (the build will now skip if the files in those apps haven't changed)
Also could you change the target branch to development to go through proper flow 👍

Do you want me to test them locally? Or you happy with the small risk of this?

@braddf you happy for this to merge?


Updates specific to Philippine Journal of Science

[ ] Create page
[ ] Orange area (or whatever alternative is decided upon)
[ ] Add papers
[ ] Share on socmed

Paper is under review


Should the spec define any event-specific behavior?

There are a number of subtle implementation details for some events.  Eg. does the sourceDevice of a keypress for an on-screen-keyboard represent the touchscreen or a logical keyboard device (probably the latter).
My thinking is that these are implementation details and since the API describes the behaviors you should see then it's OK if some user agents expose their subtly different behavior through this API.  There's certainly a slippery slope here where we could add a lot of complexity to the spec and implementation for little actual developer value.
My preference is to wait for specific concrete use cases before considering adding any such complexity to the spec.
@tdresser WDYT?

I agree that this is a slippery slope, but I think that deviating from the behavior of other browser vendors here could be quite painful for web developers in the future.
We may want to keep a list of the ambiguous cases. A small non-normative table might be adequate.

Yeah, I'm not opposed to some non-normative suggestions here.  I already kind of did that with the mention of resize.

I made some improvements in 1b11ca1cef560bd1948e9ef9fd04501006e5083e to attempt to more precisely specify how sourceDevice is supposed to behave in an abstract way (without needing to resort to event-specific text beyond examples).
Maybe this is good enough now?

In particular, are there any other scenarios whose behavior seems ambiguous?  I think the "all events that follow from a single action must have the same sourceDevice" rule removes a lot of the ambiguity.

This is a significant improvement. I'm not sure we can make a hard guarantee that all events triggered from a single user action will have the same sourceDevice though.
For instance, on Windows, if the user taps an unfocused window, I think we get a WM_FOCUS message, which causes us to fire a focus event, as well as a WM_TOUCH message, which causes us to dispatch a touch event. Setting the sourceDevice of the focus event to the touchscreen which created the touch event may not be possible.

Thanks, if we can find examples like that then I agree we'd have to change the definition.  I'm not sure I buy your example though.  WM_FOCUS causes window focus, right?  Does that in any scenario generate a 'focus' event (which is about indicating which element has keyboard focus)?  For that scenario I thought the web app would always see the touchstart first, and only get 'focus' as a result of a tap gesture.

If you:

focus a text input
defocus the window
press on the window (but not on the text input)

then on the touch press, you receive a focus event on the text input, even though no tap has occurred.
You can easily test this here (it just logs to the console every time the text input is focused).

Ah, that makes sense - thanks. I think we need to differentiate between the case where you press on the window chrome vs. on the web contents.  On the chrome this is just like any other system-determined interaction (like resize), so 'null' is appropriate.
On the contents (at least on the frame), a touchstart event will get dispatched, so ideally I think the focus would have a sourceDevice for the touchscreen.  eg. I can imagine affordance scenarios where you might like to know at focus time whether you should expect to see touchstart or mousedown following it.  It seems like it might not be too hard to fix this in theory.  Eg. queue sending 'focus' events on WM_FOCUS in this case and release the queue only when we see the input event.  Seems like a bit of an edge case though - I'd personally treat it as a pretty low priority bug unless we find some compelling use case.  WDYT?

This is getting pretty esoteric, but could we receive two focus events before dispatching a touch event?
I suspect that the queue approach would be adequate, and you're right that this is low enough priority that we can leave it for now, but I'm a bit worried that the queue could give us the same problems as the scroll event, where a single event can be contributed to by multiple inputDevices, and it isn't clear what the sourceDevice should be.
If the queue could reduce the number of focus events dispatched, that could be an incompatible change regardless of the reported sourceDevice.

I doubt eliding some focus events (which were immediately followed by a different focus event) would be a breaking change.  But regardless we could certainly implement a queue that preserves all the events if that's what we wanted (no reason we have to coalesce like 'scroll' events do).

Of course, thanks.
I'm happy with the state of this currently. I'll close this issue for now, please re-open if you think there's additional work that needs to be done here.


Override DefaultStreamCachingStrategy::resolveSpoolDirectory to avoid NPE

The default implementation of StreamCachingStrategy leverages the
ManagementNameStrategy to determine the name of the stream cache
spool directory but as there's no ManagementNameStrategy in Camel
Quarkus, it throws an NPE. The new method replaces the default
implementation with a simplified one

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/76/


User: part of the form was confusing

Question ID
download form

What was confusing
There are no instructions as to how to sign on the Computer. Most of the more information links are actually blue in color not green so one ends not knowing which link to follow to get more information.

Other information
Some of the sentences needs reconstruction because they do not make sense at all. There are words missing and or there is no space in between words.

Variable being sought
download_form

Package version
playground

Sentences have been improved. It's not clear yet what we can do about the other items.
I'm not sure we can do anything about signing instructions, but it would be great to talk about what instructions might help.


docs: README.md Draft

Kakao I OpenBuilder Java Library

Getting Started
Maven
<dependency>
  <groupId>dev.mini</groupId>
  <artifactId>kakao-i-openbuilder</artifactId>
  <version>1.0.0</version>
</dependency>

Gradle
implementation 'dev.mini:kakao-i-openbuilder:1.0.1'

Example
There is an example code implementing this library, you can check it out over here.
Resources

Kakao i Developers Docs

Contributing

Submit bugs and feature requests

License
Licensed under the Apache-2.0 license.
Development
Build
You need Apache Maven to build the project:
mvn clean install


Add support to parse Terraform state files

Is your feature request related to a problem? Please describe.
I'd like to query resources with states as close to the deployed resources
Describe the solution you'd like
Parsing state files to get resource information would be helpful
Describe alternatives you've considered
Look at plan files or base TF config files
Additional context
N/A

Addressed in https://github.com/turbot/steampipe-plugin-terraform/pull/47


[Feature Request] Blight uniques

I know you're busy being a dev and all, but any chance we can get blight uniques implemented/working in PoB with their unique modifiers?

I'm considering adding the items to my PoB's config file, but I have no idea how to share that with people here.

I'm considering adding the items to my PoB's config file, but I have no idea how to share that with people here.

Adding them is no issue for me. Coding in a new modifier is the hard part (like the complete workaround I did with Triad Grip gloves for minion conversions, just because I had no idea where to start in terms of coding the mod).

If, however, you got them coded in correctly, make a pull request.


Re-add possibility to record/replay & record/record inbound/outbound traffic

This was possible in early proof of concept implementation when recording/replaying was set on single component level.
record inbound/replay outbound is handy for making a 3d scan using recorded robot path
record/record is handy to map but at the same time learn the path
This needs:

adding record/replay support for TCP/IP layer (control protocol)
abstracting ReplayableUDPServer/Client for both TCP/IP and UDP as ReplayableServer/Client
fitting the replay outbound in framework with  TCP/IP  control state machine (e.g. synchronizing replay start is more difficult now, has to take into account connection state)

Requirements
None:
RecordInbound:
RecordOutbound:
RecordInboundRecordOutbound:

establish TCP/IP Control connection
all modules started as Autostart set
user can enable/disable modules from UI

ReplayInbound:

no TCP/IP Control connnection
no modules started
user can't enable/disable modules from UI

ReplayOutbound:
RecordInboundReplayOutbound:

establish TCP/IP control connection
no modules started from Control
modules started from recorded communication instead
user can't enable/disable modules from UI

ReplayInboundRecordOutbound

this setting doesn't make any sense and is not listed


Truffle's contract import code does not follow subdirectories

import "dev.oraclize.it/api.sol";

breaks down the compilation

Nevermind, not an issue.


Make the id editable - using uid WIP

This checkin includes:

Removed name field in edit server modal and model
Made the id editable in edit server modal
Added unique id validation to make sure no duplicate id updated/added
Fixed to not allow  duplicate of server added manually
Fixed problem where the last valid input can turn on the add more or save
button while the previous invalid inputs are ingnored.
Cleanup for unused cpu and ram item in the server data
Fixed issue when user updates in server role summary but the leftside
servers are not updated accordingly.
Fixed issue where the accordion table has part of gray and part of white
when overflow

Note:
To make this change smaller, will address existing problems separately

import duplicates in csv

This ui changes goes with backend https://github.com/ArdanaCLM/ardana-installer-server/pull/20


Update Avalonia - ReactiveUI.Avalonia.* to Splat.Avalonia.*

What kind of change does this PR introduce?

Update
What is the current behavior?

ReactiveUI.Avalonia does not follow solution names of Splat.
What is the new behavior?

Rename ReactiveUI.Avalonia.* to Splat.Avalonia.*
Remove ReactiveUi.Avalonia
Rename Avalonia Tests
What might this PR break?
Packages now have different names, ReactiveUi.Avalonia no longer exists.
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

when it's done can someone with nuget access deprecate the old package and mark this as the replacement?

when it's released can someone with nuget access deprecate the old package and mark this as the replacement?

I understand the original packages have already been unlisted.

the folder names could do with being tweaked

I will update the folder names in the morning, thank you.


Use version IRI in rdfs:isDefinedBy annotations

We decided to add these based on the discussion I initiated last year arguing for versioned IRIs for all ontology terms. We rejected that proposal, but decided to use rdfs:isDefinedBy as a mechanism for recording the ontology version each term belongs to. By using the unversioned ontology IRI we are not addressing that issue. I therefore propose using versioned IRIs in these annotations.
If this is not already an option in ontology-toolkit, it would have to be added, as well as modifying the gist bundle.yaml file.

This makes sense, are there and downsides/tradeoffs?  None come immediately to mind.

Discussion from triage meeting:

Generally gist is used either in a triple store or local file storage: dereferenceable URIs are not a critical use case
Even in the context of the linked data cloud, the value of rdfs:isDefinedBy as proposed here would only provide the most recent ontology the term is defined in, which would not help users trying to retrieve an older version of the ontology. rdfs:isDefinedBy does not substitute for versioned IRIs in the linked data context.

Therefore, the issue is being closed.

Discussion from triage meeting:

Generally gist is used either in a triple store or local file storage: dereferenceable URIs are not a critical use case
Even in the context of the linked data cloud, the value of rdfs:isDefinedBy as proposed here would only provide the most recent ontology the term is defined in, which would not help users trying to retrieve an older version of the ontology. rdfs:isDefinedBy does not substitute for versioned IRIs in the linked data context.

Therefore, the issue is being closed.

@Jamie-SA I mis-phrased the previous comment. rdfs:isDefinedBy would show only the most recent version of the ontology that defines a given term -- unless, of course, you want to have multiple assertions, adding a new one for every new release. In other words, if you retrieve a term that asserts rdfs:isDefinedBy <https://ontologies. semanticarts.com/o/gistCore9.5.0>, you don't know whether the term was also defined in version 9.4.0, unless, as I said, you add a new assertion rather than replacing the old one on each release.
If terms had versioned IRIs, you would be able to retrieve the version you wanted by IRI rather than rdfs:isDefinedBy - all published versions would be floating around in the linked data cloud.

@Jamie-SA I mis-phrased the previous comment. rdfs:isDefinedBy would show only the most recent version of the ontology that defines a given term -- unless, of course, you want to have multiple assertions, adding a new one for every new release. In other words, if you retrieve a term that asserts rdfs:isDefinedBy <https://ontologies. semanticarts.com/o/gistCore9.5.0>, you don't know whether the term was also defined in version 9.4.0, unless, as I said, you add a new assertion rather than replacing the old one on each release.
If terms had versioned IRIs, you would be able to retrieve the version you wanted by IRI rather than rdfs:isDefinedBy - all published versions would be floating around in the linked data cloud.


Fly.Io CI changes

Codecov Report
Base: 88.25% // Head: 88.23% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (0f3eea3) compared to base (4290c73).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   88.25%   88.23%   -0.02%
==========================================
  Files          52       52
  Lines        4027     4029       +2
==========================================
+ Hits         3554     3555       +1
- Misses        473      474       +1

Flag
Coverage Δ

unittests
88.23% <75.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

api/__init__.py
98.19% <50.00%> (-0.89%)
:arrow_down:

api/advanced/player_teams.py
100.00% <100.00%> (ø)

api/model.py
90.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


The new ADLS Gen2 blob explorer displays as a regular blob explorer

Storage Explorer Version: 1.31.0-dev
Build Number: 20230726.3
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.30.2)
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Select and right click one blob container -> Click 'Open in React'.
Check whether new ADLS Gen2 blob explorer displays correctly.

Expected Experience
The new ADLS Gen2 blob explorer displays correctly.
The screenshot of the previous ADLS Gen2 blob container:

Actual Experience
The new ADLS Gen2 blob explorer displays as a regular blob explorer.

We don't plan to use this explorer for Gen2 containers. I will remove the "Open React" action from Gen2 container nodes.

@v-kellyluo This issue should be resolved now. The Blob Explorer open code has been cleaned up.

Verified this issue on the build 20230802.3. Fixed.


Racon instead Sparc

Hi,
Did anyone run racon on DBG2OLC output instead of Sparc?
Thank you in advance,
Michal

Hi Michal,
we did a comparison between Sparc and Racon in our paper (https://doi.org/10.1101/gr.214270.116), although that was with miniasm raw assembly. Haven't tried it on DBG2OLC output.
Best regards,
Robert

Do you think these commands are correct to run racon?
DBG2OLC KmerCovTh 2 AdaptiveTh 0.01 MinOverlap 20 RemoveChimera 1 Contigs Contigs-1000.txt k 17 f input.fasta

cat Contigs-1000.txt input.fasta > ctg_pb.fasta

# Correction 1
source activate minimap2
minimap2 -t 8 -ax map-pb \
    backbone_raw.fasta \
    ctg_pb.fasta > output.gfa1.sam

source activate racon
racon -t 8 \
    ctg_pb.fasta \
    output.gfa1.sam \
    backbone_raw.fasta > output.racon1.fasta

# Correction 2
source activate minimap2
minimap2 -t 8 -ax map-pb \
    output.racon1.fasta \
    ctg_pb.fasta > output.gfa2.sam

source activate racon
racon -t 8 \
    ctg_pb.fasta \
    output.gfa2.sam \
    output.racon1.fasta > output.racon2.fasta

Thank you in advance,
Michal

Hi Michal,
what is stored in input.fasta and what in backbone_raw.fasta?
Best regards,
Robert

input.fasta contain the raw PacBio reads.
backbone_raw.fasta is DBG2OLC output.
Contigs-1000.txt is the Illumina assembly.

Hi Michal,
the commands look fine but I am not sure what the goal is by using Illumina assembly in polishing. If the assembly obtained from DBG2OLC is not polished, you can run two iterations of racon with PB reads and one iteration with Illumina reads (not Illumina contigs, as they will have much lesser coverage). If the DBG2OLC assembly was polished with Sparc, you can run one iteration of racon with Illumina reads.
Best regards,
Robert

Hi Michal,
if you have done everything up to step 2 of the DBG2OLC pipeline, use only the PB reads to polish the backbone. Optionally, you can polish with Illumina afterwards.
Best regards,
Robert

Hi Robert,
Do you think the command for minimap and racon are correct?
DBG2OLC KmerCovTh 2 AdaptiveTh 0.01 MinOverlap 20 RemoveChimera 1 Contigs sparse_pregraph.contig-1000.fasta k 17 f contamination_unmapped-5k.fasta

# Correction 1
source activate minimap2
minimap2 -t 8 -ax map-pb \
    backbone_raw.fasta \
    contamination_unmapped-5k.fasta > output.gfa1.sam

source activate racon
racon -t 8 \
    contamination_unmapped-5k.fasta \
    output.gfa1.sam \
    backbone_raw.fasta > output.racon1.fasta

# Correction 2
source activate minimap2
minimap2 -t 8 -ax map-pb \
    output.racon1.fasta \
    contamination_unmapped-5k.fasta > output.gfa2.sam

source activate racon
racon -t 8 \
    contamination_unmapped-5k.fasta \
    output.gfa2.sam \
    output.racon1.fasta > output.racon2.fasta

Thank you in advance,
Best wishes,
Michal

Thank you.

What is the minimum PacBio reads coverage to run Racon?
Thank you in advance.
Michal


Add env_package_manager_workspaces to public metadata

WHY are these changes introduced?
Related to https://github.com/Shopify/shopify-cli-planning/issues/346
We want to be able to track wether an app uses workspaces or not.
WHAT is this pull request doing?
This PR adds the env_package_manager_workspaces field to the public metadata.
A PR in the monorail repo that adds this field will need to be merged before this PR is merged.
I was debating naming this app_package_manager_workspaces instead of having the env_ prefix, but then was convinced by @stephszeto that this feels like an "environment" property, even if we can know about it only when loading the app and not from the environment where commands are run itself. For pure environment variables we've been using the oclif Config object, but we can't really use that here.
How to test your changes?
Not sure if we can test before deploying.
Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[x] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes

@gonzaloriestra let me know if this makes sense.

@gonzaloriestra I thought that because this new field is sent every time the app is loaded we don't need to add it there. The field should be sent in the buildPayload thanks to ...metadata.getAllPublic(),.
version doesn't load the app so it doesn't show there.
The reason why I built it this way is that environmentData doesn't use the appDirectory in any way. I suppose we could also pass it inside, but I thought it would be more convenient to reuse the already existing App structure.

This makes me think though that we might want to rename this flag to app_package_manager_workspaces. Workspaces is not really something that belongs to the environment developers are running commands in (e.g. shell, package manager), but depends directly on something that is saved inside the app.

I've created a PR for the new schema https://github.com/Shopify/monorail/pull/13589

@alvaro-shopify interesting, I've never seen it used like that. In the yarn docs it's just a plain array, but I suppose it can be used like that too?

Anyway, it seems that

@alvaro-shopify interesting, I've never seen it used like that. In the yarn docs it's just a plain array, but I suppose it can be used like that too?

Anyway, as your PR is only verifying that workspaces is present in the package.json then it works for both of the scenarios


Removed extra dot as per #849

Very minor change on documentation on website.
https://github.com/sButtons/sbuttons/issues/849

Issue:

Awesome thank you for noticing that!
@all-contributors please add @shubh710 for bug


microplane: init at 0.0.25

Motivation for this change
Wanted to add microplane since I'm looking in to using it.
Some notes:
Using buildGoPackage instead of buildGoModile, as this project uses dep, so it looks like I need goDeps that buildGoPackage provides.
Using subPackages = ["."]; because I noticed a binary named demo was being built, and I just wanted the microplane binary.
I'm renaming the binary to mp because that's how the Makefile has it. And I had trouble giving -o $out/bin/mp as a Go build flag, since it would complain that the directory didn't exist, so I just opted to rename it afterwards.
There doesn't seem to be a -v flag or version subcommand :confused: , so I'm not sure how to confirm that the version is correct.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107861 run on x86_64-darwin 1

1 package built:

microplane

Result of nixpkgs-review pr 107861 run on x86_64-linux 1

1 package built:

microplane


Add database schema version check for mysql

Coverage increased (+0.05%) to 66.711% when pulling 98e9040ea73a53cce65918e5249d8c3e6fd2f35f on mysql-version into 33321e278d04ce92073c2bad79295a21ec8338c2 on master.


Release v1

I see you've switched to go modules by adding go.mod.  Could you now release a semver-formatted version of this library?  I think that's as easy as git tag v1.0.0 and pushing.

I just took over maintainership of this project, so I'm not quite comfortable doing this just yet, but if things go well I might check with Dave Chenney eventually to do this.
I'll leave this hanging for a while.

Sounds good.  The downside of not doing semantic versioning is that every commit to main is a "release", so the pressure's a bit higher to make sure you're right every time you click "Merge PR" than it would be with semantic versioning.  And it also means that every such click triggers things like dependabot and renovate to file PRs for downstream libraries.

Hello!
I think that tagging a 1.0.0 may need a bit of planning, because if you follow semver, you're establishing a stable API.
But to start tagging 0.x.x releases shouldn't be problematic, since there is no commit to a stable API, and our go.mod files will be way nicer :)

Hello!
I think that tagging a 1.0.0 may need a bit of planning, because if you follow semver, you're establishing a stable API.
But to start tagging 0.x.x releases shouldn't be problematic, since there is no commit to a stable API, and our go.mod files will be way nicer :)

I don't expect the library to be v1 ready any time soon. sorry. I'd prefer not to do the v1, v2, v44 game as it serves little utility and adds the overhead of the go modules v2 nonsense.


Could not open library dep_gecode.bundle

Hi,
I just installed newest Vagrant and newest vagrant-berkshelf (2.0.0.rc3) and I'm having an issues with dep_selector / dep_gecode. Not sure if it's related to Berkshelf or dep-selector itself.
Details:
Chef 11.10.0 (solo)
$ vagrant -v
Vagrant 1.5.2

$ vagrant plugin list
vagrant-berkshelf (2.0.0.rc3)
  - Version Constraint: 2.0.0.rc3
vagrant-login (1.0.1, system)
vagrant-share (1.0.1, system)

Vagrant fails even for 'vagrant status' command:
[ryzy@ryzy-mbp : ~]$ vagrant status
Vagrant failed to initialize at a very early stage:

The plugins failed to load properly. The error message given is
shown below.

Could not open library '/Users/ryzy/.vagrant.d/gems/gems/dep_selector-1.0.0.rc.2/lib/dep_gecode.bundle': dlopen(/Users/ryzy/.vagrant.d/gems/gems/dep_selector-1.0.0.rc.2/lib/dep_gecode.bundle, 5): Symbol not found: __ZN6Gecode16ValBranchOptions3defE
  Referenced from: /Users/ryzy/.vagrant.d/gems/gems/dep_selector-1.0.0.rc.2/lib/dep_gecode.bundle
  Expected in: flat namespace
 in /Users/ryzy/.vagrant.d/gems/gems/dep_selector-1.0.0.rc.2/lib/dep_gecode.bundle

There's more details here - and there's more people reporting this just recently:
https://github.com/berkshelf/vagrant-berkshelf/issues/173
Many thanks for looking at it.
M.

I've had some issues in this area, did the following
gem uninstall dep_selector
gem uninstall dep-selector-libgecode
and then re-installed


isDisabled is no work

In this page https://frncsdrk.github.io/vue-slide-bar-demo-page/, loading field can disabled. only set a :showTooltip="false" ?

In the example, we use :isDisabled="true" to disable drag and click


Username URLs instead of account number

Is your feature request related to a problem?
It would be nice to have the url be /u/username instead of /u/1
Describe the solution you'd like
Not sure if this is possible. my guess is it would need to be done on the 'server' and then possibly need some conf changes if it's running behind a reverse proxy like nginx
Additional context
not a big issue - just a thought

fixed to https://github.com/usememos/memos/pull/1977


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit 1ca20f5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Protocol conformance: store conformances needed for the requirement signature

The protocol conformance checker verifies that all of the requirements
in the protocol's requirement signature are fulfilled. Save the
conformances from that check into the NormalProtocolConformance,
because this is the record of how that concrete type satisfies the
protocol requirements.
Compute, deserialize, and verify this information, but don't use it
for anything just yet. We'll use this to eliminate the "inherited
protocol map" and possibility some redundant type-witness
information.

@swift-ci please smoke test and merge

@swift-ci please smoke test OSX

@swift-ci please smoke test OSX

@swift-ci please smoke test OS X

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge


Update location of algorithm ids

implementation.h stated that Table 2 contains the algorithm identifiers from the TCG Algorithm registry. The current document, here: https://trustedcomputinggroup.org/wp-content/uploads/TCG_Algorithm_Registry_Rev_1.24.pdf shows it in Table 3.

Actually the whole thing is out of date, and needs to be updated. For example, TPM_ALG_SHA3_256 is missing.


feat: Support more than one IdP groups mapping

What does this PR change?
Allow mapping more than one IdP groups to an OIdC identity. This commit upgrades the kratos version (v0.11.0). Kratos v0.11.0 parses all id token claims into raw_claims. The raw_claims can be used in JsonNet mapper to map non-standard claims like groups to identity traits.
Tested this feature using Okta's Social Sign In flow.
Does the PR depend on any other PRs or Issues? If yes, please list them.
Fixes #109
Checklist
I confirm, that I have...

[X] Read and followed the contributing guide in CONTRIBUTING.md
[ ] Added tests for this PR
[X] Formatted the code using go fmt (if applicable)
[ ] Updated documentation on the Paralus docs site (if applicable)
[ ] Updated CHANGELOG.md

Demonstrate IdP user automatic groups mapping:
Screencast from 18-03-23 12:46:07 PM IST.webm
Note: After OIdC user registration, Kratos login is unsuccessful in demo. Kratos is not able to set the session cookie properly for the first time after registration. Next logins are working fine. This is a separate issue related to either Kratos or Paralus. Let's fix that separately.

Codecov Report

Merging #172 (e1da896) into main (f3cc930) will decrease coverage by 0.25%.
The diff coverage is 52.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   34.64%   34.40%   -0.25%
==========================================
  Files          74       74
  Lines       11609    11685      +76
==========================================
- Hits         4022     4020       -2
- Misses       7046     7120      +74
- Partials      541      545       +4

Impacted Files
Coverage Δ

pkg/service/user.go
55.15% <50.00%> (-0.67%)
:arrow_down:

pkg/service/test_utils.go
79.65% <100.00%> (ø)

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Needs update to Okta SSO setup page. I will do it soon.


DOC: Example of parsing a Pydantic object str returned by ToolNode

Issue with current documentation:
I saw in the examples that ToolNode is meant to be used to handle errors and retrying for function calling. However I don't want to actually call a tool, I just want to return the pydantic object after successful validation. It seems that the object is sent back as a message string, and it's unclear to me how to parse it back into a Pydantic object before returning it.
Here's an example below. The parse_obj function is the one that's unclear to me:

from typing import Literal

from IPython.display import Image, display
from langchain.pydantic_v1 import BaseModel, conlist, Field
from langchain_aws import ChatBedrockConverse
from langgraph.graph import StateGraph, MessagesState
from langgraph.prebuilt import ToolNode

num_weeks = 4

class Day(BaseModel):
    day_of_week: str = Field(..., description="Day of the week")
    activities: list[str] = Field(..., description="List of 1-3 high-level workout descriptions or rest day activities")

class Week(BaseModel):
    monday: Day
    tuesday: Day
    wednesday: Day
    thursday: Day
    friday: Day
    saturday: Day
    sunday: Day

class WorkoutProgram(BaseModel):
    """Generate a workout program for an individual"""
    weeks: conlist(Week, min_items=num_weeks, max_items=num_weeks)

tool_node = ToolNode([WorkoutProgram], handle_tool_errors=True)

model = ChatBedrockConverse(
    model="anthropic.claude-3-haiku-20240307-v1:0",
    temperature=0,
    max_tokens=4096,
)
model_with_tools = model.bind_tools([WorkoutProgram], tool_choice="any")

class ProgramState(MessagesState):
    workout_program: WorkoutProgram | None = None

def should_retry(state: ProgramState) -> Literal["model", "parse_obj"]:
    """Decide whether to send error to agent or tool response to parser"""
    messages = state["messages"]
    last_message = messages[-1]
    # Side question: Any better way to check for error?
    if "Error: ValidationError" in last_message.content:
        return "model"
    return "parse_obj"

def parse_obj(state: ProgramState) -> Literal['__end__']:
    """Parse the object from the tool response"""
    messages = state["messages"]
    last_message = messages[-1]
    # ISSUE: This doesn't work — how to parse the string back to a BaseModel?
    workout_program = WorkoutProgram.parse_obj(dict(eval(last_message.content)))
    state["workout_program"] = workout_program
    return state

def call_model(state: ProgramState) -> ProgramState:
    """Call the model with the messages"""
    messages = state["messages"]
    response = model_with_tools.invoke(messages)
    state["messages"] = [response]
    return state

workflow = StateGraph(ProgramState)

# Define the two nodes
workflow.add_node("model", call_model)
workflow.add_node("tools", tool_node)
workflow.add_node("parse_obj", parse_obj)

workflow.add_edge("__start__", "model")
workflow.add_edge("model", "tools")
workflow.add_conditional_edges(
    "tools",
    should_retry # back to agent or to parse_obj
)
workflow.add_edge("parse_obj", "__end__")

app = workflow.compile()

display(Image(app.get_graph().draw_mermaid_png()))

response = app.invoke(
    {"messages": [("human", "Create a workout program for a beginner with the following characteristics: height: 5 feet 10 inches, weight: 180 lbs, age: 30, goals: Lose weight and improve overall fitness.")],
    },
    {"recursion_limit": 10},
)

workout_program = response["workout_program"]

last_message.content in parse_obj is a str that may look like, for example:
"weeks=[Week(monday=Day(day_of_week='Monday', activities=['30 mins cardio (e.g. brisk walking, jogging)', '20 mins strength training (e.g. bodyweight exercises)']), tuesday=Day(day_of_week='Tuesday', activities=['Rest day']), wednesday=Day(day_of_week='Wednesday', activities=['30 mins cardio (e.g. cycling, swimming)', '20 mins strength training (e.g. resistance bands)']), thursday=Day(day_of_week='Thursday', activities=['Rest day']), friday=Day(day_of_week='Friday', activities=['45 mins cardio (e.g. elliptical, rowing)', '15 mins core exercises']), saturday=Day(day_of_week='Saturday', activities=['Rest day']), sunday=Day(day_of_week='Sunday', activities=['60 mins outdoor activity (e.g. hiking, bike ride)'])), Week(monday=Day(day_of_week='Monday', activities=['40 mins cardio (e.g. jogging, swimming)', '25 mins strength training (e.g. bodyweight exercises, light weights)']), tuesday=Day(day_of_week='Tuesday', activities=['Rest day']), wednesday=Day(day_of_week='Wednesday', activities=['40 mins cardio (e.g. cycling, rowing)', '25 mins strength training (e.g. resistance bands, dumbbells)']), thursday=Day(day_of_week='Thursday', activities=['Rest day']), friday=Day(day_of_week='Friday', activities=['50 mins cardio (e.g. elliptical, stair climber)', '20 mins core exercises']), saturday=Day(day_of_week='Saturday', activities=['Rest day']), sunday=Day(day_of_week='Sunday', activities=['75 mins outdoor activity (e.g. hiking, bike ride)']))]"
Idea or request for content:
Can a simple example be added to the examples section for combining retry logic (including error messages) with Pydantic object outputs?

Under normal circumstances, ToolNode expects to receive a BaseTool object and will package the execution result of the tool into a ToolMessage.
If the return value of the tool function is not a string or list, it will be forcibly converted and inserted into the content of the ToolMessage.
If you pass in a BaseModel, it will convert the BaseModel object into a string and insert it into the content of the ToolMessage, making it difficult to convert it back to a Python object (the issue you are currently encountering).
If you always bind only one tool and ensure that only one result will be called, I believe using with_structured_output is the simplest approach.
If you will bind multiple tools or may have multiple tool_calls, you can use bind_tool() and then connect to PydanticToolsParser, storing the execution results in the state instead of having ToolNode execute it for you.
Here is an example, and I replaced your model with ChatOpenAI(model="gpt-4o").
from typing import Annotated, TypedDict

from dotenv import load_dotenv
from langchain.pydantic_v1 import BaseModel, Field, conlist
from langchain_core.messages import AnyMessage
from langchain_core.runnables import RunnableConfig
from langchain_openai import ChatOpenAI
from langgraph.graph import StateGraph, add_messages

load_dotenv()

class Day(BaseModel):
    day_of_week: str = Field(..., description="Day of the week")
    activities: list[str] = Field(
        ...,
        description="List of 1-3 high-level workout descriptions or rest day activities",
    )

class Week(BaseModel):
    monday: Day
    tuesday: Day
    wednesday: Day
    thursday: Day
    friday: Day
    saturday: Day
    sunday: Day

class WorkoutProgram(BaseModel):
    """Generate a workout program for an individual"""

    weeks: conlist(item_type=Week, min_items=4, max_items=4)

model = ChatOpenAI(model="gpt-4o")
# model = ChatAnthropic(model="claude-3-haiku-20240307")
model_with_tools = model.with_structured_output(WorkoutProgram)

class ProgramState(TypedDict, total=False):
    messages: Annotated[list[AnyMessage], add_messages]
    workout_program: WorkoutProgram

def call_model(state: ProgramState, config: RunnableConfig) -> ProgramState:
    return {
        "workout_program": model_with_tools.invoke(state["messages"], config),
    }

workflow = StateGraph(ProgramState)
workflow.set_entry_point("call_model")
workflow.add_node("call_model", call_model)
workflow.set_finish_point("call_model")
app = workflow.compile()

response = app.invoke(
    {
        "messages": [
            (
                "human",
                "Create a workout program for a beginner with the following characteristics: height: 5 feet 10 inches, weight: 180 lbs, age: 30, goals: Lose weight and improve overall fitness.",
            )
        ]
    },
    {"recursion_limit": 10},
)
print(response["workout_program"])

If you still insist on using ToolNode, I think converting it to BaseTool and using artifacts is also an option.
By the way, your original class ProgramState(MessagesState), which is a TypedDict, setting its initial value has no effect.

@gbaian10 Thanks for your reply. The main functionality I wanted out of ToolNode was was Pydantic verification and error passing logic to add an intelligent retry loop in the case when an LLM returns a structured output with schema violations. I found that I can actually use ValidationNode instead of ToolNode:
import ast
from typing import Literal

from IPython.display import Image, display
from langchain.pydantic_v1 import BaseModel, Field, conlist
from langchain_aws import ChatBedrockConverse
from langgraph.graph import MessagesState, StateGraph
from langgraph.prebuilt import ValidationNode

num_weeks = 5

class Day(BaseModel):
    day_of_week: str = Field(..., description="Day of the week")
    activities: list[str] = Field(..., description="List of 1-3 high-level workout descriptions or rest day activities")

class Week(BaseModel):
    monday: Day
    tuesday: Day
    wednesday: Day
    thursday: Day
    friday: Day
    saturday: Day
    sunday: Day

class WorkoutProgram(BaseModel):
    """Generate a workout program for an individual"""
    weeks: conlist(Week, min_items=num_weeks, max_items=num_weeks)

validation_node = ValidationNode([WorkoutProgram])

model = ChatBedrockConverse(
    model="anthropic.claude-3-haiku-20240307-v1:0",
    temperature=0,
    max_tokens=4096,
)
model_with_tools = model.bind_tools([WorkoutProgram], tool_choice="any")

class ProgramState(MessagesState):
    workout_program: WorkoutProgram | None = None

def should_retry(state: ProgramState) -> Literal["model", "parse_obj"]:
    """Decide whether to send error to agent or tool response to parser"""
    messages = state["messages"]
    last_message = messages[-1]
    print(f"should_retry: {last_message.content}")

    # Side question: Any better way to check for error?
    if "ValidationError" in last_message.content:
        return "model"
    return "parse_obj"

def parse_obj(state: ProgramState) -> Literal['__end__']:
    """Parse the object from the tool response"""
    messages = state["messages"]
    last_message = messages[-1]
    workout_program = WorkoutProgram.parse_obj(ast.literal_eval(last_message.content))
    state["workout_program"] = workout_program
    return state

def call_model(state: ProgramState) -> ProgramState:
    """Call the model with the messages"""
    messages = state["messages"]
    last_message = messages[-1]
    print(f"call_model: {last_message.content}")
    response = model_with_tools.invoke(messages)
    state["messages"] = [response]
    return state

workflow = StateGraph(ProgramState)

# Define the two nodes
workflow.add_node("model", call_model)
workflow.add_node("validate", validation_node)
workflow.add_node("parse_obj", parse_obj)

workflow.add_edge("__start__", "model")
workflow.add_edge("model", "validate")
workflow.add_conditional_edges(
    "validate",
    should_retry # back to agent or to parse_obj
)
workflow.add_edge("parse_obj", "__end__")

app = workflow.compile()

display(Image(app.get_graph().draw_mermaid_png()))

response = app.invoke(
    {"messages": [("human", "Create a workout program for a beginner with the following characteristics: height: 5 feet 8 inches, weight: 250 lbs, age: 50, goals: Lose weight and improve overall fitness.")],
    },
    {"recursion_limit": 10},
)

workout_program = response["workout_program"]

It seems you have found the answer that suits you.
Let me say something.
The part WorkoutProgram.parse_obj(ast.literal_eval(last_message.content)) can be changed to
json_str = last_message.content
WorkoutProgram.parse_raw(json_str)  # if in pydantic v2, use `.model_validate_json()`

ValidationNode convert a pydantic object into a JSON string and store it in content attr.
If you want to convert the JSON string back into a BaseModel object, doing so is simpler and more readable.


hivex: 1.3.21 → 1.3.23

Description of changes
Compatibility with latest versions of OCaml.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 268891 run on x86_64-linux 1

11 packages built:

diffoscope
diffoscope.dist
diffoscope.man
guestfs-tools
hivex
libguestfs
python310Packages.guestfs
python310Packages.guestfs.dist
python311Packages.guestfs
python311Packages.guestfs.dist
vagrant


py2nim will fail if we don't call main

I don't know if any project will break after this, so maybe it would be good to keep this in a py2nim branch?

I think it should be ok

Thanks!


beagleconnect_freedom: Add digital, analog, pwm pins

Add pin layout described here: https://openbeagle.org/beagleconnect/zephyr/arduino-core/-/commit/1ce0b0bfca16ffc9eb781f263525347e0b42cef5
Also remove LED_BUILTIN. Seems the dts entry is sufficient.

Cc: @jadonk

My main concern here is a person comin new to the platform should be able to quickly make sense of what pin mapping you've created

Thanks. Looks good to me. Do you have a test procedure?

Thanks. Looks good to me. Do you have a test procedure?

Can you provide some clarification regarding how the pin numbering was chosen. Analog numbering seems simple but not sure about digital pin order.

Thanks. Looks good to me. Do you have a test procedure?

Can you provide some clarification regarding how the pin numbering was chosen. Analog numbering seems simple but not sure about digital pin order.

Sure.
I looked around for some examples of Arduino Click Shields such that Arduino examples that used mikroBUS boards might "just work", but I found that there wasn't much consistency between the Shields. I chose what I thought was both reasonably popular, affordable and included a reasonably good set of pins and documentation.
I want with MikroE Arduino MKR Click Shield

I tried to match up the equivalent Arduino pin with the pins on the 2 mikroBUS ports on BeagleConnect Freedom. My thinking was that if it worked on an Arduino MKR with the MikroE Arudino MKR Click Shield, then it should work with BeagleConnect Freedom. That should provide a great test resource.
Can you add this information to the documentation in a reasonable way?

@jadonk Thanks for the input. I do not think there is any board specific docs currently, but we can certainly add a section in our own docs regarding this.
@DhruvaG2000 I think this provides the context for the pin layout?


Use transition when changing data

I have a situation where I need to perform the following steps:

Step 1: Load navio with data1
Step 2: Again load navio with data2

I would like to slow down the transition between these steps. Does Navio provide any function where you can reload the data and specify the transition duration (like in d3.js)?

Hi, unfortunately transitions wouldn't be possible as I use canvas for drawing the records. Because of that the traditional transitions from D3 wouldn't apply


Documentation issue for EnableOptimizedParameterBinding

If EnableOptimizedParameterBinding is true and you are calling a stored procedure with optional parameters, then the call may behave unexpectedly.
For example, say you stored procedure is
CREATE PROCEDURE dbo.UploadToMaxTest
	@AnsiLimted VarChar(500)  = null,
	@UniLimited NVarChar(1000)  = null,
	@Ansi VarChar(Max)  = null,
	@Uni NVarChar(Max)  = null
AS
[...]

And you want to pass in two parameters.
EXEC dbo.UploadToMaxTest @Ansi = 'AAAA', @Uni = N'UUUU';

If you turn on EnableOptimizedParameterBinding, then the generated SQL is...
EXEC dbo.UploadToMaxTest 'AAAA', N'UUUU';

Which means the wrong parameters will be used.
It should be called out in the documentation that EnableOptimizedParameterBinding  is not compatible with missing optional parameters because the parameter names will be missing from the SQL.

Can you tell us how you got the generated sql output? SqlClient doesn't send a string like that, instead it sends an RPC and as part of that RPC the parameters are passed and enabling optimized binding only prevents the name being sent. So the sql you're seeing is being generated by something and it's assuming that the names will be present.
If the parameter names are required for the sproc rpc type then it should be easy enough to disable them. could you write up a short test that shows this incorrect behaviour?

I'm looking at the SQL Server profiler. So this is what the database is seeing regardless of how it got there.

Code wise, I'm just using a normal SqlCommand, providing the proc name and two SqlParameter objects.

and enabling optimized binding only prevents the name being sent

Exactly!
By not passing in the name, the database doesn't know that I'm skipping an optional parameter.
Which is fine so long as the documentation says that can happen.

The reason for adding the ability to skip the names came from situations where there were hundreds to thousands of parameters which exposed the algorithm that the server uses when matching input and output names doesn't scale well. That situation can't occur with stored procedures unless you're writing one with hundreds to thousands of parameters which feels very unlikely.
I'm thinking we could just disable that option when you're executing a sproc, we could do it silently or throw an exception like we currently do it you try to use it with an out parameter.

I'm thinking we could just disable that option when you're executing a sproc, we could do it silently

I think that's reasonable. It has a "pit of success" vibe to it which i appreciate.


Moving away from coffeescript?

How would you feel about moving from coffeescript over to es6 for v6 ? Many people are stopping building things with coffeescript and just moving over to es6 now its natively supported etc. It would make reading code much easier for those of us who always disliked coffeescript ;)

Your statement contradicts recent reports on this very project. Apparently people are (still) using this module in production with Node.js 0.10.
Anyway, any specific technical issue you'd like to see addressed?


Fixes #3798 Migrate special completions to server

Fixes #3798 Migrate special completions to server
Removes old completion analysis classes
Adds CompletionAnalysis to language server to identify correct completions based on context.

Still making tweaks to ensure behavior does not regress, but this change is mostly here.

The tooltip trimming is still busted, since the algorithm changed by the tests weren't updated. I've got it much closer, but it's not that big a deal and I don't have the brainpower right now to analyze the new algorithm.


14 open vulnerabilities (8 High, 5 Moderate, 1 Low) + 2 leaked secrets

This ticket is initially opened by @mars-lan, which was accidentally deleted. Here is the image for reference

Affected module
Does it impact the UI, backend or Ingestion Framework?
Describe the bug
https://metaphor.io/blog/is-open-source-software-more-secure) for additional context
To Reproduce

Fork the repo
Turn on Dependency graph & Dependabot alerts in Code security and analysis
View the alerts under Security tab

Expected behavior
0 vulnerability & 0 leaked secret

Hi @mars-lan,
Thanks for filing the issue and bringing this up. I want to take a moment to address the concerns raised, especially around the security of OpenMetadata, and to highlight a few key points about the advantages of open-source software in general.
Open Source vs. Closed Source Security
There’s a common misconception that open-source software is less secure than closed-source software. Actually, open source often has the edge when it comes to security. With projects like OpenMetadata, the code is out in the open—meaning it’s constantly reviewed by developers, security experts, and users all over the world. This level of scrutiny leads to faster identification and fixing of vulnerabilities compared to closed-source software, where only a small internal team typically reviews the code.
Keeping code hidden doesn’t inherently make it more secure—it just means fewer eyes are on it. Closed-source software can leave vulnerabilities unnoticed for long periods, whereas open-source projects benefit from the transparency and speed of the community. With so many people actively involved, issues get flagged and resolved much more quickly.
OpenMetadata Security Practices
1.	**Disclosure Policy:** We follow a responsible disclosure policy, which you can find here: [Responsible Disclosure Policy](https://github.com/open-metadata/OpenMetadata?tab=security-ov-file#readme). Moving forward, please use this channel for reporting any potential security vulnerabilities to ensure they’re addressed quickly and appropriately.
2.	**Automated Scanning:** OpenMetadata undergoes daily scans via GitHub and bi-weekly scans via Snyk to identify vulnerabilities, whether in our code or containers. This is part of our ongoing effort to keep everything secure and up-to-date.
3.	**Secure Releases:** All of our images are scanned to ensure zero vulnerabilities at the time of release.

On the Specific Issues Raised
It looks like the issues mentioned in your blog post might be based on an outdated version of OpenMetadata. Please ensure you’ve pulled the latest main branch or the most recent release when reviewing.
1.	**Secrets in the Repo:** This claim doesn’t hold up with our current main or any recent release branches. We do not have any secrets checked into the repo.

2.	**UI Dependency Vulnerabilities:** Most of the UI dependency vulnerabilities have already been addressed. However, in cases where third-party libraries are involved, we’re still working on it. We don’t always control when those third-party libraries push their updates, but rest assured, we’re on it.

Open Source Strength
One of the great things about open source is the transparency. Anyone can inspect the code, identify vulnerabilities, and contribute fixes. With open-source projects like OpenMetadata, we get feedback from researchers and users across hundreds of different organizations, helping us stay ahead of potential issues. This level of community involvement and oversight is a huge advantage over closed-source software, where security flaws can go unnoticed simply because fewer people are looking.
Thanks again for your feedback. We’re always open to more collaboration and appreciate the engagement from the community. Looking forward to continuing to work together to make OpenMetadata better and more secure.

Thank you for the thorough reply. This is much better than the Acryl team, which hasn't responded my issue for 3+ days.
Here are a few follow-ups:
Clear text secrets
These were indeed secrets (case 1, cast 2) committed to the repo several years ago. I can confirm that both credentials are no longer valid. Unfortunately, git never forgets so they got picked up by GitHub's scanner:

Vulnerabilities from third-party
It's understandably more complex to resolve transitive vulnerabilities resulting from third-party libraries, but that's the very definition of software supply chain security. There are established ways and best practices that can be adopted here.
Responsible Disclosure Policy
We're fairly familiar with how this works, given that we created and open-sourced DataHub. However, I don't believe it applies in this case, as the vulnerabilities are all well known and highlighted by GitHub's dependabot already. Anyone who forked this repo would have direct access to the list.
Open Source vs. Closed Source Security
The real point of my blog post wasn't about whether OSS is more or less secure, but that it ultimately depends on the team behind the project. In this very example, some of the vulnerabilities are known for 90+ days. I highly suspect that if it were not the post, they'll continue to be ignored for another while.

Hi @mars-lan,
Thanks for your follow-up. I want to clarify a few things based on your points.
Clear Text Secrets
Yes, there were historical secrets in the repo several years ago, which were rendered invalid a long time ago. While we understand that GitHub’s scanner picked them up,   let’s be clear: these credentials are completely irrelevant now and do not pose any ongoing risk.
Now that you agree that this is not a risk, we will appreciate if you can issue a edit to your blog on clarifying the stance

Third-Party Vulnerabilities
You’re correct that transitive vulnerabilities are part of the software supply chain security landscape. However, managing dependencies in an open-source project requires a careful balance. While best practices exist, third-party libraries can sometimes be slow to update, and we do not control their timelines. That said, we are actively improving how we handle these issues, but let’s not overlook the fact that some delays are beyond our immediate control. We are committed to securing OpenMetadata, but there are inherent complexities in supply chain security that apply to all software, not just this project.
Responsible Disclosure Policy
While I respect your familiarity with responsible disclosure, the policy is there for a reason. If your intention was to raise awareness of already-known vulnerabilities, we appreciate that. However, GitHub’s dependabot scans are publicly visible to any fork of the repo—so these aren’t exactly hidden issues. It’s worth noting that simply posting known vulnerabilities without going through proper channels doesn’t necessarily help move things forward any faster.
Open Source and Team Responsiveness
Regarding your comment about our responsiveness: We take security seriously. It’s worth noting that many of the libraries flagged by GitHub’s scans are not even used at runtime—they’re development dependencies or transitive ones. For each flagged vulnerability, we document where it’s used and how it impacts the project, if at all, as part of our ongoing vulnerability scans.
Claiming that these vulnerabilities would have been ignored without your post is quite a stretch. We continuously monitor and work on these issues. Your feedback is appreciated, but it doesn’t singularly dictate the project’s direction. Security is dynamic, and our team is committed to ensuring OpenMetadata remains secure through constant improvements, regardless of external prompts.
In conclusion
While we value constructive feedback, it’s clear that this conversation isn’t solely about helping improve OpenMetadata. We recognize that you are involved with a competitive, closed-source product, and we understand the underlying motivation to draw attention. That said, we are committed to staying focused on facts and transparency. OpenMetadata is driven by a global community, and we hold ourselves accountable to rigorous standards—not to drive-by critiques aimed at gaining attention.
We will continue to prioritize security, document our practices, and engage with those who are genuinely interested in improving the project. We welcome meaningful collaboration, but we won’t be distracted by attempts to undermine our work. Open-source thrives on openness and collaboration, not on spreading doubt for competitive advantage.

Clear Text Secrets
I've edited Is Open-Source Software More Secure? to clarify the false positive.
Responsible Disclosure Policy
Let's agree to disagree here. However, I'd like to reiterate the fact (see below) that no one seems to be paying attention to these already-known/publicly visible issues. Without my public disclosure, they'll most likely continue to get ignored for years to come.
Open Source and Team Responsiveness
I understand your team's desire to take security seriously. Sadly, this doesn't quite match up to the reality. As far as I can tell, there are at least 3 HIGH vulnerabilities that have been published for more than 2 months (one is as old as nearly 2 years!):

https://github.com/advisories/GHSA-36jr-mh4h-2g58 (published 9/29/2022)
https://nvd.nist.gov/vuln/detail/CVE-2024-4068 (published 5/14/2024)
https://nvd.nist.gov/vuln/detail/CVE-2024-37890 (published 6/17/2024)

It could be that dependabot had a serious bug and never raised these issues until recently. If so, please post a screenshot of the Dependabot Alerts page from the official branch, which should show the original dates these alerts were first raised.

Great job for closing all the dependabot issues!


If entering unique repo name in comparator, skip to version select

What feature would you like to have?
If I enter a unique rtepository name, say renovatebot/renovate in the repo name box, then I'd expect to be able to Tab trough to the version select boxes right away.
This doesn't work, you always need to select the repository name from the dropdown selector.
I'd like Octoclairvoyant to recognize that the input is unique (only 1 match), and allows me to select the versions, without needing to "confirm/select" the repo name.
What problem will be solved by having the feature?
Makes it easier to enter the repository name, maybe somebody has it memorized, or can just type really fast.
I don't know if this feature is hard/easy to do, maybe the real bottleneck in this process is the need to fetch the list of repositories from GitHub, so maybe we not winning any time in the grand scheme of things with this feature? 😄
Do you want to help making the feature?
I do not know enough code to do build this. 😄
Feel free to close this if we're not winning any time here, or if doing this would be too much of a hassle. 😉

I like this improvement. I've been in this situation few times, and I love when other apps handle the single option like that, so we are definitely going for it!

Another example to test this when it gets implemented: eslint-config-kentcdodds repo.


Fix a typo that prevents assemblies from working

I am going to merge this because it is straightforward.