Support will add child operation observer in GroupOperation

GroupOperation will inform an observer when new operations are going to be added to its queue. This would be a direct reflection of the OperationQueueDelegate, but it can be used like a regular observer.

Coverage increased (+0.06%) to 73.55% when pulling b3eea73191f9aeafa3ddd02b797a95dd5d782ce1 on feature/OPR-239_group_operation_added_child_observer into 30f9789e92b157961e4c88d73ffc7cb85e953174 on development.


cdn bug

What does this PR do?
Changes in the Math library CDN link
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues

(Related PR or issue)

Checklist

[x] Have you read the Contributing Guidelines on issues?

Thanks @Bolaji06
We will see if the bug is fixed, if not I'll let you know


Synchronously render chart.

I am trying to build a server side version of chartist that renders xml vs dom for use in isomorphic react applications.
I have everything setup with a lightweight virtual dom and I can create the svg string but the main issue I have is that the api is forced to be async.
// Must wait for chart to be created (async) to pull out svg string.
chart.on('created', function () {
  ...
})

Is there a way to force chartist to render synchronously?

I was thinking about this a lot in the past. The main reason why we're deferring initialization through the event loop was to allow registration of event handlers in the same call-stack when creating the chart instance. Unfortunately it's not possible to create the chart synchronously at the moment since the initialize function in Base.js is closure scoped and not exposed.
We will reconsider this and maybe provide a sync option or even get rid of the constructor based initialization and force something like new Chartist().on().on().render(). This is covered by #813 which will be part of our 1.0 work.

Hi,
I am also in the need to have a synchronous rendering. Until it is developped in version 1.0, is there any workaround that can be used to achieve a similar result?
Thanks for your help and this awesome library!


apply conduit version checks to bp plugin poly support

Description
Applies #17509  to the 3.2RC.
Type of change

[x] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

Checklist:

[x] I have followed the style guidelines of this project.~~
[x] I have performed a self-review of my own code.~~
[x] I have commented my code where applicable.~~
- [ ] I have updated the release notes.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
- [ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~
- [ ] I have assigned reviewers (see VisIt's PR procedures for more information).

BTW and FWIW, I didn't think a second review of the same work merged to another branch is needed. However, I don't see any verbiage in our docs explicitly speaking to that. Maybe I should add an issue to add that?


Clarification for INCIDENT_CHANNEL_ID and INCIDENT_REPORT_CHANNEL_ID

Based on the README.md on the Update your settings.py section. It says to define INCIDENT_CHANNEL_ID. But based on the demo settings.py there are INCIDENT_CHANNEL_ID and INCIDENT_REPORT_CHANNEL_ID. What are the difference between these two? What configuration is better and recommended?

any update on this ?

There's an option to have incidents be "report only".  These ones don't create an incident channel for co-ordinating a response from engineers as it's just for reporting.  These "report only" incidents can be posted in their own channel so that they don't clog up the "live" incident channel.
This is why both channel IDs exist.

Thanks Chris for quick response.


failure eslint nuxt-class-component

How do I use nuxt-class-component?
An error occurs in eslint.
Is there anything other than turning off the bottom?
    extend (config, ctx) {
      if (ctx.dev && ctx.isClient) {
        config.module.rules.push({
          enforce: 'pre',
          test: /\.(js|vue)$/,
          loader: 'eslint-loader',
          exclude: /(node_modules)/
        })
      }
    }

This question is available on Nuxt.js community (#c2174)

This questions can be answered on CMTY


Blank output when cmd+enter (start a new chat)

Frequently Asked Questions

[X] I have read the FAQ before opening the issue.

Workflow version
v2024.7
Alfred version
5.5 [2257]
macOS version
Sonoma 14.4.1
Debugger output
[10:47:32.226] ChatGPT / DALL-E[Keyword] Processing complete
[10:47:32.233] ChatGPT / DALL-E[Keyword] Passing output 'tell me something short' to Arg and Vars
[10:47:32.234] ChatGPT / DALL-E[Arg and Vars] Processing complete
[10:47:32.235] ChatGPT / DALL-E[Arg and Vars] Passing output '' to Run Script
[10:47:32.313] ChatGPT / DALL-E[Run Script] Processing complete
[10:47:32.322] ChatGPT / DALL-E[Run Script] Passing output '' to Call External Trigger
[10:47:32.323] ChatGPT / DALL-E[External] Processing complete
[10:47:32.324] ChatGPT / DALL-E[External] Passing output '' to Arg and Vars
[10:47:32.324] ChatGPT / DALL-E[Arg and Vars] Processing complete
[10:47:32.325] ChatGPT / DALL-E[Arg and Vars] Passing output '' to Conditional
[10:47:32.325] ChatGPT / DALL-E[Conditional] Processing complete
[10:47:32.326] ChatGPT / DALL-E[Conditional] Passing output '' to Run Script
[10:47:32.436] ChatGPT / DALL-E[Run Script] Processing complete
[10:47:32.446] ChatGPT / DALL-E[Run Script] Passing output '' to Arg and Vars
[10:47:32.447] ChatGPT / DALL-E[Arg and Vars] Processing complete
[10:47:32.448] ChatGPT / DALL-E[Arg and Vars] Passing output '/Users/max/Library/Application Support/Alfred/Workflow Data/com.alfredapp.vitor.openai
/Users/max/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.vitor.openai' to Split Arg
[10:47:32.449] ChatGPT / DALL-E[Split Arg] Processing complete
[10:47:32.450] ChatGPT / DALL-E[Split Arg] Passing output '(
    "/Users/max/Library/Application Support/Alfred/Workflow Data/com.alfredapp.vitor.openai",
    "/Users/max/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.vitor.openai"
)' to Automation Task
[10:47:32.451] ChatGPT / DALL-E[Automation Task] Running task 'New Folder' with arguments (
    "/Users/max/Library/Application Support/Alfred/Workflow Data/com.alfredapp.vitor.openai",
    "/Users/max/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.vitor.openai"
)
[10:47:32.549] ChatGPT / DALL-E[Automation Task] Processing complete
[10:47:32.557] ChatGPT / DALL-E[Automation Task] Passing output '(
    "/Users/max/Library/Application Support/Alfred/Workflow Data/com.alfredapp.vitor.openai",
    "/Users/max/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.vitor.openai"
)' to Arg and Vars
[10:47:32.558] ChatGPT / DALL-E[Arg and Vars] Processing complete
[10:47:32.559] ChatGPT / DALL-E[Arg and Vars] Passing output '' to Text View
[10:47:32.567] ChatGPT / DALL-E[Text View] Running with argument ''
[10:47:32.692] ChatGPT / DALL-E[Text View] Script with argv '' finished
[10:47:32.699] ChatGPT / DALL-E[Text View] {"response":"","behaviour":{"scroll":"end"}}

More details
Ever since 2024.6 or 2024.7 (not sure which one, I updated both before trying this) cmd+enter no longer works. Simply pressing Enter to continue an existing conversation does work.
Typed: gpt tell me something short (gpt is my custom trigger word) and pressed cmd+enter.
Expected output from ChatGPT, got:

Thank you for the report.

Typed: gpt tell me something short (gpt is my custom trigger word) and pressed cmd+enter.

This was crucial information to understand the issue, as it was working from inside the Text View itself.
Fix is now live in 2024.8.


Disappearing after press!

I use SvgCss from this library for displaying and changing the color of  several external svgs.
I put onPress on it and it works as expected in most cases. but I noticed that some svgs have weird behavior after pressing on them. for example the below svg disappears after pressing!
what's the problem here?
<svg xmlns="http://www.w3.org/2000/svg" width="188" height="195" viewBox="0 0 188 195">
    <defs>
        <clipPath id="sjkzt87o0a">
            <path fill="none" stroke="#707070" d="M0 0H188V195H0z" transform="translate(277 228)"/>
        </clipPath>
    </defs>
    <g clip-path="url(#sjkzt87o0a)" transform="translate(-277 -228)">
        <g>
            <path fill="currentColor" d="M424.413 141.66A183.073 183.073 0 0 0 241.34 324.733h139.35a43.723 43.723 0 0 1 87.445 0h139.35A183.073 183.073 0 0 0 424.413 141.66z" transform="rotate(14 -112.125 652.114) rotate(-14 269.633 431.384)"/>
            <path d="M-419.71-981.787a184.43 184.43 0 0 1-5.317-36.7 182.149 182.149 0 0 1 2.037-35.924 183.1 183.1 0 0 1 8.855-34.257 184.4 184.4 0 0 1 15.136-31.7 184.393 184.393 0 0 1 20.881-28.245 183.1 183.1 0 0 1 26.09-23.9 182.158 182.158 0 0 1 30.763-18.664 184.426 184.426 0 0 1 34.9-12.535 183.84 183.84 0 0 1 44.431-5.482 182.2 182.2 0 0 1 36.685 3.741 183.411 183.411 0 0 1 34.685 10.834 184.485 184.485 0 0 1 31.712 17.342 184.062 184.062 0 0 1 27.767 23.265 182.161 182.161 0 0 0-127.848-52.183 183.849 183.849 0 0 0-44.432 5.482c-96.058 23.95-156.256 121.918-134.191 218.387l-2.153.537zm220.059-54.867a43.8 43.8 0 0 0-10-18.771 43.609 43.609 0 0 1 7.076 8.251 43.559 43.559 0 0 1 4.9 10.028l-1.974.492z" transform="rotate(14 -112.125 652.114) translate(636.09 1316.532)" style="mix-blend-mode:multiply;isolation:isolate" fill="#bfbfbf"/>
        </g>
    </g>
</svg>

@msand Could you take a look at this please?

Could you please give some more info about the versions you are using (react-native/react-navigation/react-native-svg)? I think I have the same behaviour as you mention above, and this happened after I upgraded react-navigation to version 5.

Could you please give some more info about the versions you are using (react-native/react-navigation/react-native-svg)? I think I have the same behaviour as you mention above, and this happened after I upgraded react-navigation to version 5.

Hello @minafa96,
If the issue still persists, could you share an example and the steps to reproduce it?
Thank you.


[Event Request] codeunit 5760 "Whse.-Post Receipt"- OnBeforePostSourceDocumentPurchPost2

Hi, in the codeunit 5760 "Whse.-Post Receipt", would it be possible to get an event OnBeforePostSourceDocumentPurchPost2, like this :

                   DATABASE::"Sales Line": // Return Order
                    begin
                        if "Source Document" = "Source Document"::"Sales Order" then
                            SalesHeader.Ship := true
                        else
                            SalesHeader.Receive := true;
                        SalesHeader.Invoice := false;

                        SalesPost.SetWhseRcptHeader(WhseRcptHeader);
                        case WhseSetup."Receipt Posting Policy" of
                            WhseSetup."Receipt Posting Policy"::"Posting errors are not processed":
                                begin
                                    IsHandled:= false;
                                    OnBeforePostSourceDocumentSalesPost(SalesPost, SalesHeader, IsHandled);
                                    if not IsHandled then
                                    if SalesPost.Run(SalesHeader) then
                                        CounterSourceDocOK := CounterSourceDocOK + 1;
                                end;
                            WhseSetup."Receipt Posting Policy"::"Stop and show the first posting error":
                                begin

                                    OnBeforePostSourceDocumentSalesPost2(SalesPost);

                                    SalesPost.Run(SalesHeader);
                                    CounterSourceDocOK := CounterSourceDocOK + 1;
                                end;
                        end;
                        Clear(SalesPost);
                    end;

  [IntegrationEvent(false, false)]
   local procedure OnBeforePostSourceDocumentSalesPost2(var SalesPost: Codeunit "Sales-Post")
   begin
   end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Print out stdout/stderr in TestPackageInstall

Print out the output from the presto-admin commands so that we can
diagnose the automation failures in which Presto is not installed.

@petroav can you take a look? I want to get this in before the weekend so we can better diagnose mystery jenkins issues

LGTM but please update what tests you ran in the commit message.

looks good


Fix several code style & spacing issues + 'UIKit' typos

As many developers will use this cheat sheet in the future, I think we should make sure to be good citizens and have good and consistent code styling in the README. I also fixed the most annoying typo for me as a reader, which was the multiple appearance of UIKIT which is incorrect. I don't even know what the IT at the end could be abbreviations of (UI abbreviates User Interface).
The code should be much more readable and consistent once this is merged.

@Dschee
😘 You are a very careful developer, I also have a similar warehouse, I hope to help you.
https://github.com/Jinxiansen/SwiftUI
@Sadmansamee

@Jinxiansen I just checked out your repo, It's very nice and helpful! Please all kinds of helps is very much welcome!

☺☺☺


About huggingface-hub version

If I use: huggingface-hub 0.20.3
Will prompt:
Cannot import /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-BrushNet module for custom nodes: cannot import name 'split_torch_state_dict_into_shards' from 'huggingface_hub' (/root/miniconda3/lib/python3.10/site-packages/huggingface_hub/__init__.py)
Of course, after upgrading the huggingface-hub version, all the problems are solved. Can you write the huggingface-hub version requirements into the "requirements.txt" file?

It is interesting, but the nodes do not use huggingface_hub library. I also didn't find uses of this library in ComfyUI. So, it seems your way of loading custom nodes needs it, do you use Manager?

This problem does exist, many people install it through the manager

Here is the complete message:
[START] Security scan
[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-07-08 01:24:23.399507
** Platform: Linux
** Python version: 3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0]
** Python executable: /root/miniconda3/bin/python
** ComfyUI Path: /root/autodl-tmp/ComfyUI
** Log path: /root/autodl-tmp/ComfyUI/comfyui.log

Prestartup times for custom nodes:
0.9 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Manager

Total VRAM 11012 MB, total RAM 384797 MB
pytorch version: 2.1.1+cu121
xformers version: 0.0.23
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 2080 Ti : cudaMallocAsync
Using xformers cross attention
Total VRAM 11012 MB, total RAM 384797 MB
pytorch version: 2.1.1+cu121
xformers version: 0.0.23
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 2080 Ti : cudaMallocAsync
### Loading: ComfyUI-Impact-Pack (V5.16)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.6)
[Impact Pack] Wildcards loading done.
[comfyui_controlnet_aux] | INFO -> Using ckpts path: /root/autodl-tmp/ComfyUI/custom_nodes/comfyui_controlnet_aux/ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
DWPose: Onnxruntime with acceleration providers detected
(pysssss:WD14Tagger) [DEBUG] Available ORT providers: TensorrtExecutionProvider, CUDAExecutionProvider, AzureExecutionProvider, CPUExecutionProvider
(pysssss:WD14Tagger) [DEBUG] Using ORT providers: CUDAExecutionProvider, CPUExecutionProvider
[ReActor] - STATUS - Running v0.5.0-b4 in ComfyUI
Torch version: 2.1.1+cu121
[Crystools INFO] Crystools version: 1.12.0
[Crystools INFO] CPU: Intel(R) Xeon(R) Platinum 8255C CPU @ 2.50GHz - Arch: x86_64 - OS: Linux 5.15.0-88-generic
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA GeForce RTX 2080 Ti
[Crystools INFO] NVIDIA Driver: 535.129.03
### Loading: ComfyUI-Manager (V2.46)
### ComfyUI Revision: 2341 [628f0b8e] | Released on '2024-07-07'
Traceback (most recent call last):
File "/root/autodl-tmp/ComfyUI/nodes.py", line 1907, in load_custom_node
module_spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-BrushNet/__init__.py", line 1, in <module>
from .brushnet_nodes import BrushNetLoader, BrushNet, BlendInpaint, PowerPaintCLIPLoader, PowerPaint, CutForInpaint
File "/root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet_nodes.py", line 8, in <module>
from accelerate import init_empty_weights, load_checkpoint_and_dispatch
File "/root/miniconda3/lib/python3.10/site-packages/accelerate/__init__.py", line 16, in <module>
from .accelerator import Accelerator
File "/root/miniconda3/lib/python3.10/site-packages/accelerate/accelerator.py", line 34, in <module>
from huggingface_hub import split_torch_state_dict_into_shards
ImportError: cannot import name 'split_torch_state_dict_into_shards' from 'huggingface_hub' (/root/miniconda3/lib/python3.10/site-packages/huggingface_hub/__init__.py)

Cannot import /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-BrushNet module for custom nodes: cannot import name 'split_torch_state_dict_into_shards' from 'huggingface_hub' (/root/miniconda3/lib/python3.10/site-packages/huggingface_hub/__init__.py)

Import times for custom nodes:
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/websocket_image_save.py
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-WD14-Tagger
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/stability-ComfyUI-nodes
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI_experiments
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI_UltimateSDUpscale
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-IC-Light
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/AIGODLIKE-COMFYUI-TRANSLATION
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-VideoHelperSuite
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Video-Matting
0.0 seconds (IMPORT FAILED): /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-BrushNet
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-AnimateDiff
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/comfyui_controlnet_aux
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Advanced-ControlNet
0.0 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/comfyui-reactor-node
0.1 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Manager
0.5 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI_InstantID
2.5 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Crystools
2.8 seconds: /root/autodl-tmp/ComfyUI/custom_nodes/ComfyUI-Impact-Pack

Starting server

I upgraded the manager to the latest version and tried to install a few plugins with it, and it worked smoothly until I installed "ComfyUI-BrushNet" or "kijai/ComfyUI-BrushNet-Wrapper" and I got the same error.

I understand that the error is caused by the requirement "accelerate>=0.29.0". Is version 0.29.0 or higher really necessary?

Ok, I found a culprit. huggingface_hub>=0.21.0 should be added to accelerate library requirements. I added pull request for it.

I think, limiting accelerate to less than 0.32.0 is an option, it has higher compatibility, and even if huggingface_hub is lower, say 0.20.3, it can still be compatible.

The pull request of accelerate was approved and merged.

I think, limiting accelerate to less than 0.32.0 is an option, it has higher compatibility, and even if huggingface_hub is lower, say 0.20.3, it can still be compatible.

That is a good idea. Done it for a while.

i guess accelerate could be a bit relaxed now >=0.29.0, !=0.32.0, 0.32.1,<=0.33.0 due to https://github.com/huggingface/accelerate/pull/2932
it also seems that they are constantly removing version bounds for tests and forgetting to add it back according to history in git blame
https://github.com/huggingface/accelerate/blame/main/setup.py


Seems not working with pipeline-operator + template literal

function getTachyonsCSS(shorthand) {
	return shorthand |> snakeCase |> tachyons[_] |> toPairs |> flatten |> it.join(': ') |> `${_};`;
}

this throws
PartialError: param.macro: Placeholders must be used as function arguments or the right side of a variable declaration
while this works fine:
const getTachyons = tachyons[_];
const addColon = it.join(': ');
const addSemi = `${_};`;
function getTachyonsCSS(shorthand) {
	return shorthand |> snakeCase |> getTachyons |> toPairs |> flatten |> addColon |> addSemi;
}

How to deal with it?

This is an odd one because technically this is correct behavior, and the error message spells out why. But I think it should be considered a bug because it seems inconsistent from a user perspective, since as you've shown it works if you just hoist them out and reference them.
Since the pipeline operator implicitly calls its RHS as a function it should be treated the same as an assignment during the transform.


Fix whitespace and remove print

Fixes #11
Additionally removes the print statement which I found highly distracting. I think it's okay to notify about an error, but printing about suceeding in it's intended action doesn't seem necessary. Feel free to cherry pick only the fix if you disagree

@naefl Thanks a lot for helping! I haven't created much time to work on this repository.

Tested and merged.
Thanks again @naefl!


Tiledesk URL Redirects to port 8081 instead of Nginx

I am using TileDesk Docker version. I have configured host Nginx Configuration to use SSL Certificate but website goes to 8081 port it redirect to 8081 instead of staying at 443.

Here is nginx.conf file
ap $http_upgrade $connection_upgrade {
default upgrade;
'' close;
}
server {
listen 80;
server_name td.plzhelp.org;
location / {
proxy_pass http://localhost:8081;
proxy_http_version 1.1;
proxy_set_header        Upgrade $http_upgrade;
proxy_set_header Connection $connection_upgrade;
}
}


Fix cve 2019 10743

Referencing #169 which appears to have gone stale.
I have rebased this against master and resolved the introduced of the linting issues.
Am happy to pick this up and get it to where it needs to be to get the CVE-2019-10743 closed.
I will loop those on #169 into this for feedback.
Thanks

Thanks for the PR.
I've been sick most of the year and am finally getting better, but now my first priority is making the Caddy project (https://github.com/caddyserver/caddy) sustainable, since that is currently my full-time job and I only have a couple months of runway left. Once I have a stable job situation OR enough sponsors to make my open source work sustainable, I will have time to return to this project more. Thanks again!

@mholt I hope your personal situation improves so that you are able to review and merge this security fix.

Alternatively, consider using Join again—which calls filepath.Clean—to resolve the input path to root, thus eliminating any upward traversal, before resolving again to the destination dir:
func (t *Tar) untarFile(f File, destination string, hdr *tar.Header) error {
	to := filepath.Join(destination, hdr.Name)

func (t *Tar) untarFile(f File, destination string, hdr *tar.Header) error {
	to := filepath.Join(destination, filepath.Join("/", hdr.Name))

@mholt It seems the latest archiver release (3.2) is still vulnerable to https://nvd.nist.gov/vuln/detail/CVE-2019-10743#vulnCurrentDescriptionTitle - is there anyone available to review this PR? Many thanks.

I've pushed a commit to resolve the merge conflict here in #231.

Thanks for working on it; sorry, this is a really bad time as I've been swamped for a few weeks with work and personal things, but I'm currently working through my backlog and hope to be caught up in a couple weeks. Anyone else in the meantime is welcome to collaborate.

Fixed in https://github.com/mholt/archiver/pull/231


Better progress indicator for serialization

Currently serialization states the file/path to be written and prints "." each time a write happens. This is a primitive progress bar.
Suggest a replacement that refreshes current line of the form
Writing file NAME1: Done
Writing file NAME2: Done
Writing file NAME3: [/-\|] (progress bar with spinner)

Fixed in b82e414d39304424f3335636f14088fe1fc9ca80


Problem with Admin Tab

I have installed refinerycms-inquiries using refinerycms edge and rails 3.2.1. When clicking on the tab in the admin backend, this error shows:
Started GET "/assets?controller=refinery%2Finquiries%2Fadmin%2Finquiries" for <IP_ADDRESS> at 2012-02-07 07:31:56 -0600
Served asset  - 404 Not Found (3ms)
Processing by Refinery::PagesController#show as HTML
Parameters: {"path"=>"assets", "locale"=>:en}

... snip ...
ActiveRecord::RecordNotFound (Couldn't find Refinery::Page with id=assets):
  activerecord (3.2.1) lib/active_record/relation/finder_methods.rb:340:in `find_one'
  friendly_id_globalize3 (<IP_ADDRESS>) lib/friendly_id/active_record_adapter/relation.rb:81:in `find_one_with_slug'
  friendly_id_globalize3 (<IP_ADDRESS>) lib/friendly_id/active_record_adapter/relation.rb:25:in `find_one'
  friendly_id_globalize3 (<IP_ADDRESS>) lib/friendly_id/active_record_adapter/relation.rb:163:in `find_one'
  activerecord (3.2.1) lib/active_record/relation/finder_methods.rb:311:in `find_with_ids'
  activerecord (3.2.1) lib/active_record/relation/finder_methods.rb:107:in `find'
  activerecord (3.2.1) lib/active_record/querying.rb:5:in `find'

Perhaps there should be a plugin.url line in refinerycms-inquiries / lib / refinerycms-inquiries.rb?

It occurs to me that the reason I've encountered this issue is because my project is using precompiled assets, and that's why /assets is showing in the URL…

Unfortunately I can't reproduce it... @ghoppe is it only inquiries or you see similar behavior with other refinery engines?

Comparing my broken installs with a new fresh install, I'm guessing the problem is in an old devise initializer.

Closing this. Thanks for response.


Regression on copy-paste: pasted elements lose selection

Hey! I'm using the paid version and lately I noticed a regression in the copy-paste functionality.
When I copy-paste a group of selected elements, all elements besides text lose selection. Just the pasted text elements remain selected.

I either need to paste them in an "empty space" in the canvas or reselect.
group before i copy, paste, and then ungroup.

both options harm the experience obviously.
before the bug, any pasted elements used to be selected which was great UX wise.

@ShayDavidson do you mind recording a video with the above steps so its more clear ?

This seems a regression in the editor itself. Looking into it.

@ShayDavidson fix now deployed in Excalidraw+ too. Thanks for the report!

wow thanks for the quick turn around 🙏🏻


Bug fix: don't error out on out-of-sync lock file

Description
As far as I can see, the --no-check-lock argument has been available since Composer 1.0, so adding this argument to the composer validate command should be safe and should prevent the issues as reported in #206.
Includes tests (though the test isn't running properly yet).
Motivation and context
Fixes #206
How has this been tested?
I've tested this locally with the plain command with both Composer 1 and 2, but have not tested this in the context of this action.
I've added a unit test, but haven't managed to get it running properly.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING.md document.
[x] I have added tests to cover my changes.

Aside from the typo causing problems in the test, this looks great to me. I think this is the right approach. Thanks!

I wonder if that's because it needs the executable bit. Do you have a way of setting chmod +x on that file and committing that change?

I wonder if that's because it needs the executable bit. Do you have a way of setting chmod +x on that file and committing that change?

Ha! Yes. That was it! Might be useful to add that information to the CONTRIBUTINGfile.
If it helps, even though file permissions are not handle the same on Windows, the git ls-files -s command to check the status works and will show the correct chmod status. The permissions for a file can be changed on Windows by running this command: git update-index --chmod=+x <file>.
I've updated the PR and have verified the new test fails without the fix and passes with the fix in place, so should be good to go now.
Thanks @ramsey for coaching me through this one.

Hmm.. curious that Codecov doesn't pick up the new unit test...

Hmm.. curious that Codecov doesn't pick up on the new unit test...

I'm still learning how the Bash code coverage tooling works. 🤷🏻♂

I have a suspicion that multi-line commands in Bash (like this one) aren't being correctly reported.

That might well explain it, though the second line of the command is recognized as covered (correctly).


Invalid RsaKeyAlgorithm publicExponent returned

crypto.subtle.generateKey({
  name: 'RSA-PSS',
  hash: { name: 'SHA-256' },
  modulusLength: 2048,
  publicExponent: new Uint8Array([0x01, 0x00, 0x01]),
}, false, ['sign', 'verify'])

An RSA-PSS, RSASSA-PKCS1-v1_5, or RSA-OAEP crypto key that's generated or imported is supposed to have an algorithm.publicExponent property that's supposed to be a Uint8Array. ref.
Workerd (and most likely also the workers platform) returns an ArrayBuffer.
cc @jasnell

ping @jasnell

ah right, yeah forgot about this one. Making a ticket internally to make sure we remember!

Fixed in #1268


Invalid use of reject  causing real error to be swallowed

The "onabort" handler of indexedDB transaction
https://github.com/localForage/localForage/blob/b6a47080ba946e3ca659c1d7358a04521440e5cf/src/drivers/indexeddb.js#L668-L671
is throwing following error
Uncaught Error: The error you provided does not contain a stack trace.
    at parseError (index.js:2370)
    at getStackFrames (index.js:2263)
    at crashWithFrames (index.js:1927)
    at index.js:1945
    at rejectionHandler (index.js:2041)

when getting DOMException
DOMException
  code: 22
  message: ""
  name: "QuotaExceededError"
  __proto__: DOMException

That happened in Chrome on Android ^5 device. Sorry can't provide more details, because don't have direct access to that device at this moment.
PS I still have no idea why "QuotaExceededError" arose but its not related to this issue.

FYI, if it helps, I get a similar message from React when audioEl.play() rejects (DOMException with no stack trace). So pretty sure this is specific to indexedDB used within React.


Words beginning with "in" triggering indentation accidentally

It's somehow hard to come up with a good example, but just playing around in a do block, where let is also used without in, it feels like in triggers indentation accidentally. This is especially the case for words beginning with "in" e.g. intercalate.
It could be an improvement to use in<space> as trigger for indentation and not in.

I see this behavior even with
let g:purescript_disable_indent = 1

or
let g:purescript_indent_in = 0

Is this possible?

I see this behavior even with
let g:purescript_disable_indent = 1

or
let g:purescript_indent_in = 0

Is this possible?

@vladciobanu Could we release a new version of the library? Looks like there are some nice improvements included in the latest. I can take a look at releasing this if you don't have time.

@vladciobanu Could we release a new version of the library? Looks like there are some nice improvements included in the latest. I can take a look at releasing this if you don't have time.

@andys8 Can you help maintain this so we don't all need to use your fork?

Hey, it's two years later and I'm currently trying to figure out what I did and why :D
The only difference of my fork is: https://github.com/purescript-contrib/purescript-vim/compare/main...andys8:purescript-vim:main
But turns out, I'm not using my fork myself, but instead disabled indentation completely.
https://github.com/andys8/dotfiles/commit/d3de003849308797fc22611dd8de08480342edec
Since you seem to be using the fork: do you think it makes sense to open a pull request for the in commit today?


[ComposedModal] double scrolling

Describe the bug
The ComposedModal will under some conditions (modal height interval) get a double scrollbar when the error message is showing.

Please create a reduced test case in CodeSandbox:
https://codesandbox.io/s/github/IBM/carbon-addons-iot-react/tree/master/examples/codesandbox

Expected behavior
No double scrollbars.

:tada: This issue has been resolved in version 2.99.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[QUESTION] Is provisioning of the M365 Learning Pathways allowed for multiple sites within one tenant?

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Submit your question
What is the context of your question

[] Installation
[] Administration
[] Custom Content
[] M365 learning pathways web part

What is your question

Provide related screen-shots to help us understand your question

No. Duplicate #242


Kickoff

Discuss available data sources, flow and plan for the project.
Result should be visible in the README.md on this project.

@stirringhalo - available for Skype / Hangout? Check your email please...

Done. Thanks for the call @stirringhalo

@stirringhalo is interested esp.in hillshading. We are going to use RAW dem data from OpenSnowMap project - http://blog.opensnowmap.org/post/2015/10/25/Relief-layer-updated

@stirringhalo is interested esp. in hillshade vector tiles. We are going to use RAW DEM data from OpenSnowMap project - http://blog.opensnowmap.org/post/2015/10/25/Relief-layer-updated
👍 1

So it is really possible to create vector hill shade polygons as Mapbox does it with this data source?

Yes, it is possible - but it means rendering the raster hillshading with correct paramters (combined with slopeshading probably, etc), then vectorisation (either on range of colors or on a posterised image with limited number of colors) - all of this on 285 GB of raster data.
After we have vectors do import into PostGIS, generalization for upper zoom levels, finetuning of .tm2 and use of workers in docker on a cluster to get the tiles.

The contour lines are low-hanging fruit, as we have shapefiles ready to be used. Only import into PostGIS, assigning of extra attributes, making .tm2 and rendering. It has a lower priority for @stirringhalo - he is keen on vector hillshading.
If anybody is interested (@lukasmartinelli?) I can advise, it is probably a work for one weekend with the knowledge of OSM2VectorTiles project.

I have the OpenSnowMap DEM fully downloaded, and I'll do some experimentation in my free time to get posterize and dumping to vectors working (probably using polygonize). I think it's doable, but it's lots of reverse engineering to get something looking similar while still being style compatible

In light of #3, this is on hold until we can come up with a different schema and style that respects Mapbox licensing. I had not seen the issue (https://github.com/osm2vectortiles/mapbox-gl-styles/issues/3) until after this comment was made.

@stirringhalo : Are the OpenSnowMap DEMs freely available somewhere? Is it possible to use this data?


go fmt message.go & update Timestamp types of int to uint64

Sorry, my push slower.
Signed-off-by: dingdayu<EMAIL_ADDRESS>

Wow, what a HUGE pr for renaming to uint64!


Screen freezes or crashes on pixel2 after upgrade to latest stable

Steps to Reproduce
When we run a screen containing our recursive_image widget the screen freezes or our app even crashes. This happens after we upgraded from flutter version v1.5.4-hotfix.2 to v1.7.8+hotfix.3
Recursive widget can be found here:
https://gist.github.com/remonh87/378fefbc89d3f160509f4b474eff7c77

Create a simple app containing some text and that uses the recursivewidget. e.g.

Center(child: RecursiveImage(
                recursionDepth: 2,
               //simple screen can be a simple screen e.g. refer to counter counter
                builder: (_, image) => SimpleScreen(
                  viewModel: viewModel,
                  image: image,
                ),
),

Run the screen and the app either crashes or freezes.

Logs
Crash log (happens one out of 3 attempts):
W/Adreno-GSL(15095): <gsl_ldd_control:549>: ioctl fd 60 code 0xc040094a (IOCTL_KGSL_GPU_COMMAND) failed: errno 71 Protocol error W/Adreno-GSL(15095): <log_gpu_snapshot:458>: panel.gpuSnapshotPath is not set.not generating user snapshot W/Adreno-GSL(15095): <gsl_ldd_control:549>: ioctl fd 60 code 0xc040094a (IOCTL_KGSL_GPU_COMMAND) failed: errno 71 Protocol error W/Adreno-GSL(15095): <log_gpu_snapshot:458>: panel.gpuSnapshotPath is not set.not generating user snapshot W/Adreno-GSL(15095): <gsl_ldd_control:549>: ioctl fd 60 code 0xc040094a (IOCTL_KGSL_GPU_COMMAND) failed: errno 71 Protocol error W/Adreno-GSL(15095): <log_gpu_snapshot:458>: panel.gpuSnapshotPath is not set.not generating user snapshot W/Adreno-GSL(15095): <gsl_ldd_control:549>: ioctl fd 60 code 0xc040094a (IOCTL_KGSL_GPU_COMMAND) failed: errno 35 Resource deadlock would occur W/Adreno-GSL(15095): <log_gpu_snapshot:458>: panel.gpuSnapshotPath is not set.not generating user snapshot

Flutter doctor output
[✓] Flutter (Channel unknown, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-NL)
    • Flutter version 1.7.8+hotfix.3 at /Users/user/huedlc/hue_blue/dev/flutter
    • Framework revision b712a172f9 (8 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/user/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/user/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • CocoaPods version 1.7.2

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 36.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.5 Preview.app/Contents
    • Flutter plugin version 36.1.1
    • Dart plugin version 191.7830
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Community Edition (version 2019.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 37.0.3
    • Dart plugin version 191.7830

[✓] VS Code (version 1.28.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.15.0

[✓] Connected device (4 available)
    • Pixel 2   • <123>                         • android-arm64  • Android 10 (API 29)

cc @jason-simmons if you have the time, can you see if you can track this down? sounds like it's a regression.

Do you have any more info on how to reproduce this?
I tried creating a default template app, copying the RecursiveImage class, and replacing the SizedBox with an Image.asset.  I then instantiated a few RecursizeImages in the app's layout:
            RecursiveImage(
                recursionDepth: 3,
                builder: (_, image) => image,
            ),

Ran this on a Pixel 2 XL with Android 8.0.1.  The app worked as expected, and I didn't see any logs from Skia or the GL drivers.  I tried both the current master branch of Flutter and v1.7.8+hotfix.3.

@jason-simmons  thanks for looking into this. I created an app that contains the crash: https://github.com/remonh87/recursive_image_repro

I reproduced this on a Pocophone F1.  The recursive_image_repro app results in GPU driver error logs and crashes.
Did a bisect and found that this started at this change to Skia: https://github.com/google/skia/commit/08b260c27b519ac8fb17b3ff8ddccf4a2ac0e278

We have found that the issue is caused by a combination of the rotation transform and the blur backdrop filter of the in progress widget. Given this limitation, limiting transforms to just scales and translates will let still render recursive backdrop blurs without crashing the GPU.
A key part of the Skia linked above was to fix backdrop filters so that they applied the blurring and filtering in the proper, local coordinate system. In this particular case, the blurs with the same X and Y blur radii won't look any different before or after. Unfortunately, our image filtering API doesn't expose enough information to detect this case and optimize away the rotation components of the transform.
For reasons yet unknown, the new backdrop code path tickles what appears to be a driver bug on Adreno drivers but we haven't found a simple workaround. That being said, I am currently working on a much larger overhaul of the image filtering code in Skia, which will hopefully bypass this issue. I do not have a time estimate for that yet, though.

@jason-simmons Did you file an upstream bug or reach out to the Skia team about this? (No worries if you didn't, I just don't want to file a duplicate bug.)

We've discussed this with Skia (see the response from @lhkbob)

Ah, thanks missed that.
So the status here is that we are waiting for the overhaul of the related area of code in Skia.
@lhkbob do you have a bug# for the overhaul that we can follow?

The overall tracker for our image filter overhaul is here: https://skbug.com/9279. The components that would address this issue hopefully are https://skbug.com/9074 and https://skbug.com/9283

@lhkbob Is it ok if I assign this to you? Do you have a (conservative) estimate of when this will be addressed? (Just for tracking purposes.)

Yes, that is ok. I have an aggressive goal to have this addressed by the first week of September.

Our working hypothesis has been that these crashes on Android devices are triggered by the same temporary image change that caused severe performance regression on iOS devices. I have landed https://skia-review.googlesource.com/c/skia/+/237904 and it has rolled into the flutter engine. This CL should bring the image allocation behavior back to more like before the regression CL landed.
However, I haven't confirmed this. If someone can test that it no longer crashes when using the ToT flutter engine, then we can close this.

The other Android/iOS bugs have been fixed with my recent changes, so I would expect that this issue is resolved as well.  @remonh87, If you can test with Flutter ToT, that would be appreciated and let me know if I can close this out, or if there is something else going on in your case.

@lhkbob thanks for the fix. I am not familiar with the term Flutter ToT . Which version or branch do I need to grab in order to test it?

ToT refers to tip of tree, so if you're able to test with the 'master' channel it will see these Skia changes. https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

@lhkbob  Great news! I did test the issue on master branch  and it is solved now. I propose to close the issue

Confirm that it's working for me in the master channel.

Closing per @cachapa's comment. Feel free to reopen if I'm wrong. Thanks!


"sbt-networkchannel-0" java.lang.NullPointerException

sbt.version=1.6.2
Darwin foo.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64
java --version
openjdk 11.0.14 2022-01-18
OpenJDK Runtime Environment Microsoft-30447 (build 11.0.14+9-EA)
OpenJDK 64-Bit Server VM Microsoft-30447 (build 11.0.14+9-EA, mixed mode)

steps
Reload a project in intellij a few times when sbt is already running
problem
sbt
[info] welcome to sbt 1.6.2 (Microsoft Java 11.0.14)
[info] loading settings for project scala-integration-tests-build from plugins.sbt ...
[info] loading project definition from /Users/foo/test/project
[info] loading settings for project scala-integration-tests from build.sbt ...
[info] set current project to integration-tests (in build file:/Users/foo/test/)
[info] sbt server started at local:///Users/foo/.sbt/1.0/server/b63181f1ee0df9d4309b/sock
[info] started sbt server
[info] new client connected: network-1
[info] shutting down client connection network-1
[info] new client connected: network-2
sbt:integration-tests> Exception in thread "sbt-networkchannel-0" java.lang.NullPointerException
	at sbt.internal.server.NetworkChannel.sbt$internal$server$NetworkChannel$$doFlush(NetworkChannel.scala:671)
	at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:567)
	at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:553)
	at sbt.internal.server.NetworkChannel$$anon$3.run(NetworkChannel.scala:189)
[info] new client connected: network-3
sbt:integration-tests> Exception in thread "sbt-networkchannel-0" java.lang.NullPointerException
	at sbt.internal.server.NetworkChannel.sbt$internal$server$NetworkChannel$$doFlush(NetworkChannel.scala:671)
	at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:567)
	at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:553)
	at sbt.internal.server.NetworkChannel$$anon$3.run(NetworkChannel.scala:189)
exit
[info] shutting down client connection network-2
[info] shutting down client connection network-3
[info] shutting down client connection network-2
[info] shutting down client connection network-3
[info] shutting down sbt server

Notes
This is not breaking anything as far as I know

Exception in thread "sbt-networkchannel-0" java.lang.NullPointerException: Cannot enter synchronized block because "this.sbt$internal$server$NetworkChannel$$outputBuffer" is null
        at sbt.internal.server.NetworkChannel.sbt$internal$server$NetworkChannel$$doFlush(NetworkChannel.scala:672)
        at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:568)
        at sbt.internal.server.NetworkChannel.shutdown(NetworkChannel.scala:554)
        at sbt.internal.server.NetworkChannel$$anon$3.run(NetworkChannel.scala:190)

here's a more verbose NPE from 1.9.2.


Turn off eslint on edit

It is taking too long to lint

wfm, maybe when it gets faster we can reenable.


GPC-509: Add xray resource policy back in

Out of curiosity, do multiline string like https://yaml-multiline.info/ work?


Publish to live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/api/rate-limits.md
:white_check_mark:Succeeded
View

docs/create-packages/Publish-a-package.md
:white_check_mark:Succeeded
View

docs/create-packages/Supporting-Multiple-Target-Frameworks.md
:white_check_mark:Succeeded
View

docs/includes/install-cli.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio.md
:white_check_mark:Succeeded
View

docs/reference/Package-Versioning.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/packages-config.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-4.7-RTM.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Improve support for Download Notebook Set (jupyter_html pipeline)

The option  jupyter_image_urlpath should be renamed and confined to the jupyter_download_nb pipeline. make site should use relative references and this urlpath option is really only needed in the download set of notebooks for referencing images and figures on the web.

https://github.com/QuantEcon/lecture-source-py/issues/517

perhaps we should rename it jupyter_download_nb_image_urlpath


EasyFullControl.hpp not found in humble

Bug report
/home/user/ros2_ws/src/fleet_adapter_tb4/fleet_adapter_tb/src/FleetAdapter.hpp:24:10: fatal error: rmf_fleet_adapter/agv/EasyFullControl.hpp: No suchfile or directory
24 | #include <rmf_fleet_adapter/agv/EasyFullControl.hpp>
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Required information:

Operating system and version: Ubuntu 22.04
OpenRMF installation type: Source for humble
OpenRMF version or commit hash: the source version for humble
ROS distribution and version: Humble
ROS installation type: Debs

Description of the bug
When compiling, it doesn't find this rmf_fleet_adapter/agv/EasyFullControl.hpp.
After close inspection, this is not present in the source installation of RMF for humble.
Any idea why? I this EasyFullControl not supported anymore?

Steps to reproduce the bug
Install rmf by source for humble
download the latest version of this git for tb4 adapter an compile.
Expected behavior
I would expect that works with the latest version iunles there is something I'm missing or this adapter has no support anymore
Extra
I imagine that the preferred way to create adapters is now using the templates and the examples of the awesome_adapters.
Thanks in advance

Thanks for raising the issue.
The EasyFullControl API is a work in progress in this PR https://github.com/open-rmf/rmf_ros2/pull/235
The API is still being refined before it can be merged into main. The goal is to make the experience of using this API as easy as possible for users. This fleet adapter is written using this beta API. If you would like to build this adapter, kindly switch to the feature/easy_full_control branch in rmf_ros2.
I'll leave this ticket open until we merge that branch into main.

After changing and recompiling the rmf_ros2 in branch feature/easy_full_control
Having now this error when compiling:
/home/user/ros2_ws/src/fleet_adapter_tb4/fleet_adapter_tb/src/FleetAdapter.cpp:362:10: error: no viable conversion from returned value of type '(lambda at /home/user/ros2_ws/src/fleet_adapter_tb4/fleet_adapter_tb/src/FleetAdapter.cpp:355:5)' to function return type 'FleetAdapter::GoalCompletedCallback' (aka 'function<rmf_fleet_adapter::agv::EasyFullControl::GoalStatus ()>')
  return cb;

Any ideas of what could it be?

[fleet_adapter-1] [INFO] [1672747561.320252385] [fleet_adapter_tb]: Failed to create EasyFullControl adapter instance.
[ERROR] [fleet_adapter-1]: process has died [pid 30511, exit code -11, cmd '/home/user/ros2_ws/install/fleet_adapter_tb/lib/fleet_adapter_tb/fleet_adapter --ros-args -r __node:=fleet_adapter_tb -r __ns:=/ --params-file /tmp/launch_params_bbhpc0_u --params-file /tmp/launch_params_20y5w80w --params-file /tmp/launch_params_6twc1025'].
When launched it states this, no mor info, so I don't know exactly where is failing. Is there any way to get more verbose to know where exactly is failing?

Switching to yadu/easy_full_control is not a good long term solution. It would be great if you could open a PR here to get it to compile with feature/easy_full_control. Unfortunately, I don't have the bandwidth at the moment to fix this issue.
Regarding the runtime issue, are you able to share the entire terminal log from launch till crash?

Sure ;):
This is all the output
ros2 launch fleet_adapter_tb fleet_adapter_turtleenv.launch.py
[INFO] [launch]: All log files can be found below /home/user/.ros/log/2023-01-03-14-26-02-088405-1_xterm-56990
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [fleet_adapter-1]: process started with pid [56991]
[fleet_adapter-1] [INFO] [1672755962.282235652] [fleet_adapter_tb]: Starting fleet_adapter_tb
[fleet_adapter-1] [INFO] [1672755962.282372309] [fleet_adapter_tb]: Configuring fleet [barista].
[fleet_adapter-1] [WARN] [1672755962.286694179] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodeswith the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[fleet_adapter-1] [INFO] [1672755962.296888904] [fleet_adapter_tb]: Parameter [discovery_timeout] set to: 60.000000

[fleet_adapter-1] [INFO] [1672756022.355973455] [fleet_adapter_tb]: Failed to create EasyFullControl adapter instance.
[ERROR] [fleet_adapter-1]: process has died [pid 56991, exit code -11, cmd '/home/user/ros2_ws/install/fleet_adapter_tb/lib/fleet_adapter_tb/fleet_adapter --ros-args -r __node:=fleet_adapter_tb -r __ns:=/ --params-file /tmp/launch_params_zh2z8yr5 --params-file /tmp/launch_params_vd5ruhq5 --params-file /tmp/launch_params_dcmoe9ae'].

I'm looking into the code to see whats going on there in case its not finding the navigate_to_pose action server or something similar related to the parameters.
As for opening a PR, no problem, just want to at least have this working an then we can backtrack to feture/easy_full_control branch and see why its not compiling

I've posted a pull request to "fix" one of the errors of compilation using the feature/easy_full_control branch f the rmf_ros2 repo: Pull REquest
I just placed a false in the action input of the RobotState` initialization ( although I don't really understand what's the use of that varioable'  but its compulsory for the init of that RobotState.
As for the other errro related to the callback, no idea for the moment why this is happening:
/home/user/ros2_ws/src/fleet_adapter_tb4/fleet_adapter_tb/src/FleetAdapter.cpp:362:10: error: no viable conversion from returned value of type '(lambda at /home/user/ros2_ws/src/fleet_adapter_tb4/fleet_adapter_tb/src/FleetAdapter.cpp:355:5)' to function return type 'FleetAdapter::GoalCompletedCallback' (aka 'function<rmf_fleet_adapter::agv::EasyFullControl::GoalStatus ()>')
  return cb;

I have the same error. To fix it I compile the original version of fleet_adapter_tb4 but with rmf_ros2 using rmf_fleet_adapter and rmf_fleet_adapter_tb4 from the branch feature/easy_full_control and the another packages from humble branch (this fork).
Now I have another problem when I run:
ros2 launch rmf_demos_gz_classic office.launch.xml easy_fleet:=1

I get the next error:
[easy_fleet_adapter-16] Starting fleet adapter...
[easy_fleet_adapter-16] Traceback (most recent call last):
[easy_fleet_adapter-16]   File "/easy_ws/install/rmf_demos_fleet_adapter/lib/rmf_demos_fleet_adapter/easy_fleet_adapter", line 33, in <module>
[easy_fleet_adapter-16]     sys.exit(load_entry_point('rmf-demos-fleet-adapter', 'console_scripts', 'easy_fleet_adapter')())
[easy_fleet_adapter-16]   File "/easy_ws/build/rmf_demos_fleet_adapter/rmf_demos_fleet_adapter/easy_fleet_adapter.py", line 342, in main
[easy_fleet_adapter-16]     adapter = FleetAdapter(
[easy_fleet_adapter-16]   File "/easy_ws/build/rmf_demos_fleet_adapter/rmf_demos_fleet_adapter/easy_fleet_adapter.py", line 121, in __init__
[easy_fleet_adapter-16]     self.configuration = adpt.easy_full_control.Configuration.make(
[easy_fleet_adapter-16] AttributeError: type object 'rmf_adapter.easy_full_control.Configuration' has no attribute 'make'


parseListOfPoints sometimes has empty "nums"

I get the following traceback
scour.py -i lib/images/cover-chapter-2.svg -o build/lib/images/cover-chapter-2.svg --remove-metadata --quiet
Traceback (most recent call last):
  File "/home/sebastien/Local/share/scour/scour.py", line 3183, in <module>
    out_string = scourString(in_string, options).encode("UTF-8")
  File "/home/sebastien/Local/share/scour/scour.py", line 2952, in scourString
    cleanPolygon(polygon, options)
  File "/home/sebastien/Local/share/scour/scour.py", line 2164, in cleanPolygon
    pts = parseListOfPoints(elem.getAttribute('points'))
  File "/home/sebastien/Local/share/scour/scour.py", line 2136, in parseListOfPoints
    prev = nums[len(nums)-1]
IndexError: list index out of range

and the following fixes it
diff scour-fixed.py scour.py
2136,2141c2136,2138
< 					if len(nums) > 0:
< 						prev = nums[len(nums)-1]
< 						if prev[len(prev)-1] in ['e', 'E']:
< 							nums[len(nums)-1] = prev + '-' + negcoords[j]
< 						else:
< 							nums.append( '-'+negcoords[j] )
---
> 					prev = nums[len(nums)-1]
> 					if prev[len(prev)-1] in ['e', 'E']:
> 						nums[len(nums)-1] = prev + '-' + negcoords[j]

(by sebastien-type-z)

(by louis-simard-deactivatedaccount)
cynthia@alakazam ~/scour/scour$ ./scour.py -i ~/temp/cover-chapter-2.svg -o ~/temp/cover-chapter-2.opt.svg --remove-metadata --quiet
cynthia@alakazam ~/scour/scour$ ./scour.py --version
0.26
cynthia@alakazam ~/scour/scour$ ls -la ~/temp/cover*
-rw-rw-r-- 1 cynthia cynthia 26918 Nov  6 13:55 /home/cynthia/temp/cover-chapter-2.opt.svg
-rw-rw-r-- 1 cynthia cynthia 32477 Nov  6 13:53 /home/cynthia/temp/cover-chapter-2.svg
I'm not positive this bug still occurs. What version of Scour are you running, and is it the latest code in the Bazaar repository? (See Code, above in Launchpad, to know how to get the code freom Bazaar.)

(by u-chris-k)
I'm using 0.26 and see this error, as well.
$ python ~/Applications/scour/scour.py -i oak-color.svg -o output.svg
scour 0.26
Copyright Jeff Schiller, Louis Simard, 2010
Traceback (most recent call last):
File "/Users/chrish/Applications/scour/scour.py", line 3183, in
out_string = scourString(in_string, options).encode("UTF-8")
File "/Users/chrish/Applications/scour/scour.py", line 2952, in scourString
cleanPolygon(polygon, options)
File "/Users/chrish/Applications/scour/scour.py", line 2164, in cleanPolygon
pts = parseListOfPoints(elem.getAttribute('points'))
File "/Users/chrish/Applications/scour/scour.py", line 2136, in parseListOfPoints
prev = nums[len(nums)-1]
IndexError: list index out of range

(by a13b)
I also see this bug with two files, one of them being:
http://upload.wikimedia.org/wikipedia/commons/c/c2/Dublin_Rail_Network3.svg
The "s" parameter received by parseListOfPoints(s) is:
-7.227,-7.227 7.227,-7.227 7.227,7.227 -7.227,7.227
The parseListOfPoints method crashes if the first number is negative. That method needs some cleanup.

This was fixed in Scour 0.32, see ab1aa0e2f8cb3faf1487249eea56cf83906b1f39


Adjust zIndexs to not overlap with onchainkit

What changed? Why?
Before:

After

Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Correct permissions can edit organisations.

Acceptance Criteria

Only user with correct permissions can edit organisations.

Testability

[x] Can be tested?
[x] Can be demoed?

Optional Business Notes

RHC: See organizations, manage organizations, manage grid areas.
TML: See organizations, manage actors.

Optional Techical Notes

None

Optional Task List
Tasks in Development
Tasks Completed

RHC can mange organisations. Test ok

TML can see organizations, manage actors. Test passed.


Sonar - Code Brush up

There are some low hanging fruits in SonarCloud right now, which can be quickly fixed:

https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJw_vPFV4POpyUFe&open=AXI3CJw_vPFV4POpyUFe
https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI4Cmvdi9scHiKbJc85&open=AXI4Cmvdi9scHiKbJc85
https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJtzvPFV4POpyUE7&open=AXI3CJtzvPFV4POpyUE7 and similar
https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJwuvPFV4POpyUFX&open=AXI3CJwuvPFV4POpyUFX and similar
https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJuavPFV4POpyUE-&open=AXI3CJuavPFV4POpyUE

See also https://github.com/corona-warn-app/cwa-server/issues/268

Hi, I am new to open source and would love an opportunity to work on this issue.

Hi @vikram111! Sure, feel free to have a look at this, thanks!

thanks @johanneseschrig  Can I please get write permissions as I am unable to push to the remote to make a pull request?

Hey @vikram111, you can still create PR's when you forked this repo.

Hi @vikram111! Here is a guide on the steps to create a PR from a fork: https://guides.github.com/activities/forking/
Thanks!

thanks a lot for your help @johanneseschrig, really appreciate it. I have raised a pull request for this now : https://github.com/corona-warn-app/cwa-server/pull/274


#205 Fix : handles ConnectionError

Handled ConnectionError.
ran the local tests without new FAILURES.

Hi @aalbatross
Before we can merge this pull request, we need you or your organization to agree to one of our contributor agreements. One of the big concerns for people using and developing open source software is that someone who contributed to the code might claim the code infringes on their copyright or patent. To guard against this, we ask all our contributors to sign a Contributor License Agreement. This gives us the right to use the code contributed and any patents the contribution relies on. It also gives us and our users comfort that they won't be sued for using open source software. We know it's a hassle, but it makes the project more reliable in the long run. Thank you for your understanding and your contribution!
If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:

Go to: https://www.bigchaindb.com/cla/
Read the Individual Contributor Agreement
Fill in the form "For Individuals"
Check the box to agree
Click the SEND button

If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:

Go to: https://www.bigchaindb.com/cla/
Read the Entity Contributor Agreement
Fill in the form "For Organizations”
Check the box to agree
Click the SEND button

We will email you (or your employer) with further instructions.

@ttmc i have accepted CLA. @vrde will update the PR with test.

@aalbatross Please copy the block of text that I emailed you to the comments in this pull request.

BEGIN BLOCK
This is to confirm that I agreed to and accepted the BigchainDB Individual Contributor Agreement at https://www.bigchaindb.com/cla/ and to represent and warrant that I have authority to do so.
9gga4Agz9jJT91bjR58Abi6lTbQIHtvmAqsvDb6yJ33RWbo4fi2u7zL3TdVJwFH
END BLOCK

I approved because the CLA step is complete.

Hi @aalbatross, any updates on this PR? Thanks!

Hi vrde,
Working on writing testcase. Will update it asap.
Thanks
Ravi
On 02-Aug-2017 6:51 PM, "vrde"<EMAIL_ADDRESS>wrote:
Hi @aalbatross https://github.com/aalbatross, any updates on this PR?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bigchaindb/bigchaindb/pull/1694#issuecomment-319669989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtd_g-9-HE6I9gYZojprrWzctnuP0jDks5sUHfNgaJpZM4OgZfh
.

Codecov Report

Merging #1694 into master will decrease coverage by 0.06%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   98.46%   98.39%   -0.07%
==========================================
  Files          59       59
  Lines        2862     2867       +5
==========================================
+ Hits         2818     2821       +3
- Misses         44       46       +2

@vrde
I added the testcase, but the test didnot PASS because Failed: DID NOT RAISE <class 'bigchaindb.backend.exceptions.ConnectionError'>
Since test runs with rethinkdb server started. How can i stop it while running the test. or can i mock it ? If yes how ?

Since test runs with rethinkdb server started. How can i stop it while running the test. or can i mock it ? If yes how ?

Yes you can mock it. I guess something like this should work.
Moreover, there are other places where a connection can fail, like run_drop.

Since there is no further development, I'll close this PR.


2FA support

Has there been any progress in 2FA support or would I need to disable it to use this?

Short Answer
No progress.
Long Answer
The precious attempt (see #11) no longer works because our interaction with the server was completely reworked from "use a virtual browser and virtually click through the UI" to a more stable "use the API directly". Since then, nobody has attempted to implement 2FA support.
My guess is that it's not brutally hard but requires some reverse engineering to figure out how the 2FA challenges are encoded and how the user interaction would work for a CLI tool.


Cast to ObjectId failed for value "[object Object]" (type string) at path "_id" for model "XXX"

Bug Report
This is bug report for issue discussed in #911.
I managed to replicate the error in minimal project. I believe that the problem is that query/dataloader expands relationship fields when it shouldn't at depth 0 and then it tries to expand already expanded fields at proper level causing the type cast error.
Test query:
query {
  MyPosts {
    docs {
      title
      owner {
        email
      }
    }
  }
}

See comment at
payload.config.ts::75
Expected Behavior
Relationship field objects should get expanded only at their respective depth.
Current Behavior
Relationship field objects get expanded one level sooner.
Steps to Reproduce

Create user
With that user create a Post
While logged in send test query

Detailed Description
<EMAIL_ADDRESS>

Hey @chladog — unfortunately I still can't replicate. I noticed that you are probably automatically filling the owner field on your MyPosts collection with a hook or similar, so I tried to replicate. Did you mean to provide a sample repo?
I just added a test suite to reflect your exact scenario in the Payload source code, including autofilling the owner field based on the logged in user's ID:
https://github.com/payloadcms/payload/blob/master/test/dataloader/config.ts
The new test passes. And here's a screenshot of the query I am making in the test suite:

I have a sneaking suspicion that maybe however you're trying to autofill the owner field might be wrong. You may be passing the full user object, where you really just need to pass the ID of the user object. See the sample config for how I am doing that with a field hook.
Can you help me figure out how to take this test and replicate your scenario?
Any ideas?

Hi @jmikrut, ofc I wanted to share repo - my bad.
Here it is: https://github.com/chladog/payload-chladog-bug-replicator

Ah ok. I see exactly why this is happening now and I fully understand why.
So, when your custom resolver is fetching the results, you need to specify depth: 0 as you suspected, because otherwise you would be doing quite a bit of extra querying.
I don't think that we should change anything in Payload's source code for this for a few reasons:

Consider if your posts collection had a lot more relationship fields—in your local API find call, you'd be populating all relationships for no reason if your GraphQL query only wanted the owner to be populated.
Being that you're specifying the default depth, in this case, 2, you could have extra "levels" of depth being populated for no reason, where you really only need the first level of owner.
You might think that we could safely use the pre-populated document that is provided, rather than having to use the dataloader to manually fetch related documents, but the fetched documents themselves could still be the wrong shape (populated further than they should) if the remaining depth is greater than 0.

Internally, Payload find within GraphQL resolvers all specify 0 as the depth for this exact reason. Because it needs to be up to the shape of the query.
TL;DR: it's going to be more performant for you to specify depth: 0 in your custom resolver in the long run, and the error is actually proper. It will help avoid extra overhead by functioning the way it is now.
Is there a reason why you can't specify depth: 0? If so, I'm up for brainstorming ways to get around this. We could set up GraphQL resolvers to use the data if it's there, but that's kinda putting a bandaid over top of something that should really not be done in the first place IMO.
I'm gonna bump this back to a discussion for now as I don't think there's anything that should be changed at this point internally within Payload.
What do you think?


Problems with defaultRule while migrating form v1.7 to v2.1

hi,
I have problems with the migration form v1.7 to v2.1.
We use traefik in the development. It runs as a dedicated project on any development machine next to dnsmasq which points any .test domains to <IP_ADDRESS>.
All services (which have the corresponding labels) of a project are accessible via
{service_name}.{compose_project_name}.test which worked like a charm for v1.7 with the following toml config:
debug = true
defaultEntryPoints = ["http", "https"]

[entryPoints]
    [entryPoints.http]
    address = ":80"
    [entryPoints.https]
    address = ":443"

[traefikLog]
    format = "json"

[accessLog]
    format = "json"

[web]
    address = ":8080"

[docker]
    domain = "test"
    exposedbydefault = false
    watch = true

While migrating to v2.1 I came up with the following toml config:
[entryPoints]
    [entryPoints.http]
    address = ":80"
    [entryPoints.https]
    address = ":443"

[providers]
  [providers.docker]
    watch = true
    exposedByDefault = false
    defaultRule = "Host(`{{ .Name }}.test`)"

[api]
  insecure = true
  dashboard = true
  debug = true

[log]
  format = "json"

[accessLog]
  format = "json"

The dashboard works like expected but when services enable traefik the dashboard registers the hosts domains as {service_name}-{compose_project_name}.test and when I try to access them via browser I get the message: Internal Server Error.
Maybe someone has a solution for the problem.
Thanks in advance
bambamboole

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


TagGroup: Add docs for maxRows and onAction

✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

This action is firing when pressing (with mouse but not keyboard) on tag names as well, is that intended?

@matthewdeutsch just handled this in #3893, just haven't pulled in those new changes to this branch yet.

Docs look good to me, but whats up with the additional translations in the aria package?

Ahh thanks, that was left over from a merge.


feat: replace next-seo with custom solution

Why

We’re replacing next-seo because we haven’t been using it too much, and we’re trying to reduce our external dependencies

ENV varibables

Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present.
fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Considerations

Multiple open graph images were unable to be properly tested, as the social media platforms I tested could not properly select from multiple images.
changed seo.json to seo_meta.json to accommodate JSON+LD data structure files in the future.

@dominiksipowicz just found this PR while checking out how to add more metadata for instagram + facebook. I saw you guys added Twitter here. I was wondering, are there any guidelines for adding instagram and facebook? I'd be happy to try to put something up if you point me in the right direction. Thanks!

Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present.
fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Hi @dominiksipowicz , these variable names are not included in the .env.template on main branch.
Should they be to help avoid confusion?

@dominiksipowicz just found this PR while checking out how to add more metadata for instagram + facebook. I saw you guys added Twitter here. I was wondering, are there any guidelines for adding instagram and facebook? I'd be happy to try to put something up if you point me in the right direction. Thanks!

Hi @aecorredor, The purpose of this PR was to minimise the dependencies for the commerce project and give developers more freedom to customize. If you have a lightweight implementation please submit a PR. You can use this PR as an example how to add more OG tags.

Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present.
fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Hi @dominiksipowicz , these variable names are not included in the .env.template on main branch.
Should they be to help avoid confusion?

@CraigWatt I think the NEXT_PUBLIC_STORE_URL can be added. Good spot! Thanks. Do you want to submit PR?


I am packaging F3D as Flatpak, problem with compiling OSPRay.

Hello, I tried to package F3D as Flatpak and I want to submit to Flathub.
https://github.com/flathub/flathub/pull/2282
I could build and run F3D without OSPRay just fine.
But since OSPRay is needed for ray tracing, I will try to add them.
Right now I have some problem with ISPC needed by OSPRay because it need glibc-32bit, which I have a bit of issue how to do it in flatpak.
https://github.com/flathub/org.freedesktop.Sdk.Extension.llvm11/issues/10

more info here: https://gitlab.kitware.com/f3d/f3d/-/issues/226

@kevinsmia1939 closing this as VTK 9.1 was released and you mentioned that it was going to fix the issue (in the gitlab discussion). Feel free to discuss here if anything is unclear.


Implement Option for capnp_conv

Note that we cannot cover options for primitives in the capnp_conv macro, because only pointer types can reasonably be nullable.

As discussed with @rafal-ch , we are still determining the code this macro needs to generate.  This work is on ice for now.


Comment "regarding" field not round-tripping correctly

Once I start working on #339, I may want to create a test for this scenario. Repro:

Start with sena-3 project.
Language Forge creates comment on word "adidi", Portugese gloss "bom"
LF S/R
Delete LF project
Clone from LexBox
Click on "adidi"
The comment is there, but the UI indicator next to the field has been lost

This is because the "regarding" field isn't getting set correctly on the LF side of things, for reasons yet to be determined.

The TODO status on comments is also failing to round-trip, due (in part) to the model differences between FLEx and Language Forge (FLEx doesn't have TODO). There's code that's supposed to round-trip it, but it might be failing.


Override GOPROXY if using default direct proxy

This made make -C client/go complete in 9 seconds instead of the typical >3 minutes.

Is this because SD uses an older Go compiler which doesn't use proxy.golang.org by default?

yes


Foundation's JS is not working.

I follow the wiki then served it locally by run npm start, but it won't initialize Foundation. Why?
I though there was a problem on the local machine, so I deployed it on Netlify on the following address: http://inspector-zebra-64764.netlify.com/kitchen-sink/ (Source Repo)
The result is the same.

Did you uncomment the component's JS in /gulp/config.yml?

Wow. It works! SUPER!


Updates behavior of split-path when working with UNC roots.

Currently splitting a UNC root on windows will return a empty string.
Please reference:
https://github.com/PowerShell/PowerShell/issues/2301

@dchristian3188, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Closing due to incorrect tests


Service Example doesn't increment the counter

The service_struct_impl doesn't actually increment the counter between requests

Not sure what you mean, it does right here: https://github.com/hyperium/hyper/blob/8f6d0a2f7ec23882c93a1cc0e1bf40db806f8249/examples/service_struct_impl.rs#L51
Do you mean that the counter isn't shared with other connections? That's true, you'd need change the usize into something that shares and synchronizes memory (like an Arc<AtomicUsize>).

Yeah, I meant not shared across connections. For what it's worth, I think the example is a little contrived, I can't do any more than what I can do with https://github.com/hyperium/hyper/blob/master/examples/tower_server.rs and I could just hardcode that counter.
I'm trying to build a proxy that splits requests based on some body-params but I ended up just using Warp even though it seems like overkill for my use-case (thanks for Warp by the way haha).

Sorry for the spam... I have my head stuck in vanilla HTTP 1, one connection per request. this example makes a lot more sense now.


consider installing goodfirstissue app on project

Hi,
First of all thank you for making vscode. I use this for both office/personal work.
I've developed a github app goodfirstissue which tweets 'good first issues' via twitter handle @goodfirstissue. (ofcourse 100% coding for this project was done on vscode) and I saw a lot of issues in vscode that are marked as goodfirstissue.
I was hoping if you can install the app on vscode repo. It needs only read access to issues/metadata.
the targeted audience for twitter account are first time contributors, and to encourage open source contributions.
Some details:
Permissions this app need: read permission on issues and metadata.
Twitter Handle used to tweet: @goodfirstissue
Source code of the app/webhook: https://github.com/rajatjindal/goodfirstissue
Instructions to install github app: https://github.com/rajatjindal/goodfirstissue#how-to-install
Thank you for considering this app.
Disclaimer: i am the author of goodfirstissue app. I am relatively new to opensource community and looking to engage more in open source contributions myself too.

Hi @kieferrm
Requesting your feedback on this. If there is any other information I can provide, I would be happy to provide that.
Thanks
Rajat Jindal

kind reminder to provide feedback @kieferrm


Convert usage of SchemaIO to SchemaTransform

This bug tracks removing usage of SchemaIO and replacing with usage of SchemaTransform which is a more general API that covers all the use cases of SChemaIO.
See https://s.apache.org/beam-schema-transform and BEAM-14020.
Once the subtasks are complete than SchemaIO can be removed entirely.
Imported from Jira BEAM-14021. Original Jira may contain additional context.
Reported by: laraschmidt.

The following subtask(s) are associated with this issue: #21407, #21408, #21409, #21410, #21411, #21412, #21413, #21414, #21415, #21416

@damondouglas unfortunately there's not, only committers and the issue reporter are able to modify an issue 😞. In general, the GitHub-y way is probably to just tack on comments

The output of this task an implementation of Read and Write SchemaTransforms and their respective Configurations to support reading from and writing to Kafka.
This task will be separated into four PRs to focus on Read and Write SchemaTransforms and their respective Configurations. See BigQuerySchemaTransformReadProvider and BigQuerySchemaTransformWriteConfiguration as an example design pattern.

@damondouglas let me know what edits you need on this

for jdbc schemaio is also used for expansion service: https://github.com/apache/beam/tree/master/sdks/java/extensions/schemaio-expansion-service
we probably also need to adjust that one?


Config for esbuild target

The current rollup build targets es2020 explicitly, which is good for most use cases. However, I had an issue where node 12.x support was needed on a build.
Happy to attempt a PR for it, just was a bit unsure of the best way to go about that with keeping the abstract nature of the build.

I needed this to change all entries, it looks like you can use the esbuild.target config key to accomplish that.
If anyone else needs this, see:

export default defineBuildConfig({
  declaration: true,
  rollup: {
    emitCJS: true,
    cjsBridge: true,
    esbuild: {
      target: 'es2019'
    }
  },
  clean: true,
  entries: [
    'src/plugin',
    // loaders aren't part of the plugin entry
    { input: 'src/loaders/dev-tools', name: 'loaders/dev-tools', declaration: false, format: 'cjs', ext: 'cjs'  },
    { input: 'src/loaders/virtual-module', name: 'loaders/virtual-module', declaration: false, format: 'cjs', ext: 'cjs'  },
    { input: 'src/loaders/windicss-css', name: 'loaders/windicss-css', declaration: false, format: 'cjs', ext: 'cjs' },
    { input: 'src/loaders/windicss-style-pitcher', name: 'loaders/windicss-style-pitcher', declaration: false, format: 'cjs', ext: 'cjs' },
    { input: 'src/loaders/windicss-template', name: 'loaders/windicss-template', declaration: false, format: 'cjs', ext: 'cjs'  },
  ],
  externals: [
    'webpack',
  ],
})

Better support for per-entry configurations seems like it would be its own feature so I'll close this off


Not deploying all build files

Hi there,
I am using the SFTP deploy option with the automatic build step before and it seems that not all of the build files for my project are deployed.
Any hints what might lead to this? I'm on a mac and everything else is working like a charm...
Regards, Chris

also seeing this, switched to rsync and that looks to be working


Client Query as Expression

Hello!!!
Client side query can be improved.
instead of saving queries in Queries.graphql File  and then calling them as
await client.GetHeroAsync(Episode.Empire);
let strawberry-shake generate a client like this.
var hero = await client.GetHero(Episode.Empire).Select(hero=> {
name = hero.Name,
}).FirstOrDefualtAsync();

Now client is responsible for creating Query on run time.
Selection will be in C# not in graphql so It's more powerful.
Don't need to build and generate code multiple time just once.
Don't need to even touch graphql File so no maintenance,

Thanks!

Just want to add a data point that this is exactly what I was looking for when initially trying to use StrawberryShake. It does seem like the slowness of client query generation can be mitigated by caching queries.


Fix typos and cleanup

The Travis failure was caused by https://github.com/dashevo/dashcore-p2p/commit/1d11fe132b95e3864b2f55ac7dc0d33498b29762

I'm unable to push to this source branch to manually resolve, conflicts, so will have to fix later. Thanks for the submission.
Closing this.

Just a reminder that the conflicts were not caused by my commit but from
https://github.com/dashevo/dashcore-p2p/commit/1d11fe132b95e3864b2f55ac7dc0d33498b29762
Thanks for reviewing.


Pagination

I'm facing issues with pagination:
https://api.trakt.tv/sync/watched/movies?page=1&limit=10
No matter what value is passed in page and limit, it's always returning the same data.
Tried with retrofit, postman

Seems like this endpoint doesn't support pagination

Pagination in /watched endpoint similar to /watchlist ?

As you mentioned, this endpoint doesn't support pagination. The idea is all watched items are returned so you can fully sync locally.


Abstraction for metrics and tracing

The goal of this PR is to introduce an abstraction to remove from the core sdk module the dependencies over metrics and tracing. Part of #619
Content of this PR:

the core module doesn't depend anymore on opencensus
the core module provides an abstraction to plug tracing and metrics in send/receive/request, called ObservabilityService
there is a new separate module that provides the same support as before for opencensus + extras
Observability is now used only in Client and not anymore in marshalling/unmarshalling hot paths
Fixed some wrong context propagation with http using the client receiver

Breaking changes:
Users of metrics and tracing will have to modify their code to support this change. Now they won't need to use client.NewObservable and http.NewObservable, but they'll must use the observability service and the http protocol factory from the opencensus package
Deprecated (and short-circuited functions):

client.NewObservable (now it's like client.New)
http.NewObservable (now it's like http.New)

Removed functions:

Most of the stuff in v2/observability module which were exposing opencensus types
All the ObsEncode and ObsDecode
Some methods on DistributedTracingExtension which were exposing opencensus types (which were implementing the distributed tracing extension in the wrong way https://github.com/cloudevents/spec/blob/v1.0.1/extensions/distributed-tracing.md#using-the-distributed-tracing-extension)

Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>

LGTM
APPROVE

LGTM
APPROVE


WIP - Support creation of providers with default values

Context
This commit improves the provider API by allowing to set
a default value provider when creating the property instance.
This leads to more idiomatic code in plugins, in particular
when they need to provide a default value.

Since Adam merge these changes, this PR is obsolete. I will just garbage collect this PR and close it. If you feel otherwise just reopen it and accept my apologies.


Print metatdata Array

Hello (again) :grin: ,
Trying print an array in my twig-file, but very strange it didn't show the array :confused:
Looking at some themes how they shows an array, but didn't work here.
Yaml:
links:
  - name: website-1.be
    url: https://website-1.be
  - name: website-2.be
    url: https://website-2.be

Twig:
{% for name, url in meta.links %}

{{ name }}

{% endfor %}

Output:
Array
When adding quotes:
links:
  - name: 'website-1.be'
    url: 'https://website-1.be'
  - name: 'website-2.be'
    url: 'https://website-2.be'

Output:
0
1
So, it not shows the metadata variables in the array.

Found it!
{% for item in meta.links %}

{{ item.name }}

{% endfor %}

Item is the index! :smiley:

Glad you figured it out. 👍🏻
You can sometimes use the syntax you had first... it's just used for something different: key/value pairs.
You might see code like {% for key, value in meta.items %}.
If you were iterating over this data:
items:
  name: 'website-1.be'
  url: 'https://website-1.be'

Then on the first loop, {{ key }} would be name and {{ value }} would be website-1.be.
Then on the next loop, {{ key }} would be url and {{ value }} would be https://website-1.be.
So, this syntax doesn't do what you wanted it to. 😉
It's only useful if you specifically need code that prints out the name of each key as you go.

@mayamcdougall aha okay, now i understand :smiley:
It was a littje confused when looking at Pico-themes using this for-loop methods, but yes, i figured out :smiley:


Bug fix and toggle button

Added a toggle button for the ruler.
Fixed a compatibility bug with the 'copy-coordinates' script.

Thank you for your contribution!
I will test this out soon(ish), and merge it if I have no further remarks!

I tried your code out but:

I couldn't see the toggle (well, a marker does appear named bm-popup-set but it's untoggleable)
But the distance does appear in web console + in that bm-popup-set marker)

The bm-popup-set marker is not my own, the 'Distance Measurer' addon alone also makes it appear. I only reworked the code for the moment.
If the toggle does not appear, it is possibly due to the fact that it is not positioned in the same place for everyone. When I coded the button, I gave it a position (modifiable in the code) but friends of mine pointed out to me that depending on the size of the screen, the browser or the zoom applied to the same browser, the button was not in the same place, or even behind the BlueMap buttons. Which can be very annoying since it is the one that allows you to enable and disable the distance measurement.


Receive data from backend

Use Case
Description
Use http-Client with observer pattern in order to receive records from the database on init as well as update data every time new data is stored inside the database
Trigger
When open the app and new data is stored inside the database
Precondition
Data is available inside database
Result
List all assessment records inside a table
Postcondition
Observe database for new incoming records

Currently we only get data when starting and reloading the page. It seems to be not that easy to update data, every time new data is stored inside the database. We need to check to specifications to decide if this state of functionality is okay.


skip test_window_aggs_for_rows_lead_lag_on_arrays

If some rows of order-by columns (it's a,b,c in the test) are equal,
then it may fail because CPU and GPU can't guarantee the order for the
same rows, while lead/lag is typically depending on row's order.
The solution is we should add the aggregation column d and the default column
d_default columns into the order-by to guarantee the order. But for now,
sorting on array has not been supported yet, see
https://github.com/NVIDIA/spark-rapids/issues/2470.
So this PR just skip the test
Signed-off-by: Bobby Wang<EMAIL_ADDRESS>

build

So fix this test instead of skipping it!  There are ways to generate data that has no ambiguity in the order.


Error: Unable to lookup source

I'm trying to get coverage tests for my vuejs project. My webpack2 rules look like this...
      rules: [{
        test: /\.js$/,
        exclude: /node_modules|vue\/src|vue-router\//,
        loader: 'babel-loader',
        options: {
          presets: [
            ['es2015', { 'modules': false }]
          ],
          plugins: ['transform-runtime']
        }
      }, {
        test: /\.styl$/,
        loaders: ['style-loader', 'css-loader', 'stylus-loader']
      }, {
        test: /\.vue$/,
        loader: 'vue-loader',
        options: {
          postLoaders: {
            js: 'istanbul-instrumenter-loader?esModules=true'
          }
        }
      }, {
        include: /\.json$/,
        loaders: ['json-loader']
      }, {
        enforce: 'post',
        test: /\.js$/,
        exclude: /node_modules|vue\/src|vue-router\/|test\//,
        loader: 'istanbul-instrumenter-loader',
        query: {
          debug: true,
          preserveComments: true,
          esModules: true
        }
      }]
    },

My karma config looks like this.
        {
          frameworks: ['jasmine'],
          singleRun: true,
          colors: true,
          browsers: ['Chrome'],
          phantomjsLauncher: {
            exitOnResourceError: true
          },
          reporters: ['spec', 'coverage-istanbul'],
          files: [
            { pattern: 'test/unit/**/*-spec.js', watched: false }
          ],
          preprocessors: {
            'test/unit/**/*-spec.js': ['webpack']
          },
          webpack: {
            devtool: 'source-map',
            output: {
            },
            module: webpack.module,
            resolve: webpack.resolve
          },
          webpackMiddleware: {
            noInfo: true,
            stats: 'errors-only'
          },
          coverageIstanbulReporter: {
            dir: './build/reports/unit',
            reports: [ 'text-summary', 'html' ],
            fixWebpackSourcePaths: true,
            'report-options': {
              html: {
                verbose: true,
                subdir: 'html'
              }
            }
          }
        },
        specReporter: {
          suppressSkipped: false
        }
      }

The istanbul-instrumenter-loader is used specifically for the javascript section of the .vue files as a postLoader. When I run karma I'm getting a report but its just an error Error: Unable to lookup source: /Users/user/Development/app/src/components/background.vue?094fc1b7(ENOENT: no such file or directory, open '/Users/user/Development/app/src/components/background.vue?094fc1b7'), note the has on the end of the filename. Is there something I'm doing wrong?

+1. Same here. The code coverage report shows 100% with 0/0 checked for statements, branches, functions and lines.

This was fixed in the karma coverage reporter in this PR: https://github.com/mattlewis92/karma-coverage-istanbul-reporter/issues/2


Autoreconnect and timeout handling

Describe what you would like to know or do
I don't think it's clear whether or not this lib has support for auto reconnect when it looses connection to the websocket server(which in my case is written in nodejs using the https://github.com/websockets/ws).
I have tried to use the async-http-client but it feels really basic and only has the neccessites and I don't want to have to implement all the stuff like auto reconnect and what not.
Describe the solution you'd considered
A clear and concise description of any solutions you've considered.
Additional context
Add any other context or links about the question here.

No, this lib does not support auto reconnect.
We think that a developer has to react to the close codes and trigger specific actions!
Best regards,
Marcel


Ameriflux call notes 2019-07-03

Check with Avni about high latitude synthesis (Sue N?)
Per Deb, take a careful look at e.g. CC-BY instead of current MIT, which is more of a software license and less familiar to e.g. journals.
May want to reconsider acknowledgment policy—requiring citation of individual datasets and/or COSORE paper
Follow up with Danielle (?) about an Ameriflux blog entry about COSORE
In August, schedule call to discuss next steps, in particular no COSORE design decisions prevent a future COSORE->BADM transfer. Probably Ben and Danielle should review technical details ahead of this

Call with Danielle 2019-09-11

Design decisions - esp. vis-a-vis BADM
Trivial - units
Categorization questions
Timestamps and aggregation
Metadata and data

What we're thinking about:

Anything that BADM requires that's not in COSORE?
Anything in COSORE that BADM should add?

Goal: Google doc with mapping
BADM - overall design philosophy and organization

crosses both BADM and continuous data products
consistent resolution at a common interval -> continuous fluxnet data product
sporadic data -> BADM
Metadata: groups of metadata get entered together
Location information about chamber? Some have asked about this
What about identifying Ameriflux sites?
Everything is in local standard time - UTC offset
Start and end of observations - what about observation length as metadata?

Ben TODO

[ ] Make a time resolution report
[ ] Point her to the RPubs document & download link
[ ] Set up a google sheet
[ ] Think about further QA/QC
[ ] Think about observation length field

Meeting with Danielle - 2019-10-17
Broad agreement on approach to heavy/light software stack, nimbleness, standards.
Things to think about technically:

Flag whether flux computed by instrument, PI, COSORE, other
Timestamp start and stop issue
CSR_PAR not well defined
CSR_SM is ratio, not percent, right?
Maybe a flag for suspected daylight savings problem?
Google form -> everything should be captured in database
Think hard about dark versus light versus Rs/Rh/NEE

Meeting with Danielle and Stephanie at AGU 2019-12-09

Summarized issues, institutions, goals for SCP
Things like webinars could be supported by ESS-DIVE team
See two bold issues above--there may be others but these currently known problems
Talked about 2020: data ingestion, infrastructure development, and standards/outreach
First step for outreach #72 might be to survey existing COSORE contributors - treat as a pilot survey


x86-64 throws BadDataError on basic disassembly

While attempting to use sleighcraft for x86-64 disassembly I've run into a problem with BadDataErrors being thrown on valid code.
Code to reproduce when using the python package:
from bincraft import Sleigh
# Opcodes for xor rax, rax in x86-64
# Also for dec eax; xor eax, eax in x86
code = [72, 49, 192]

# x86 test case
sleigh = Sleigh("x86", code)
print(sleigh.disasm(0)) # works

sleigh = Sleigh("x86-64", code)
print(sleigh.disasm(0)) # fails with OSError: cpp exception: BadDataError

I'm unsure as to what could be causing this issue, or if I missed a configuration step somewhere in the process.
Any feedback is appreciated.

This should be a bug. We will be working on it shortly. Thanks!