__eq__ is not implemented and equals isn't great either

By default Python checks for object identity when __eq__ is not implemented. This means that grid objects are only considered equal if they refer to the same object exactly.
This results in problems if you instantiate the same grid twice, and then concatenate the result; the resulting UgridDataset then has two separate topologies with the same name. Furthermore, it's currently possible to join two different topologies in a UgridDataArray if the dimensions happen to match exactly.
Moreover, .equals now only tests if grids share the same type, so is too permissive.
Ideally, we match the behavior of xarray as much as possible. In xarray terms, the Ugrid topology is an Index. So the equals behavior should match the equals behavior of xarray Indexes. These are mostly pandas Indexes: the equals check looks like:
    def equals(self, other: Index):
        if not isinstance(other, PandasIndex):
            return False
        return self.index.equals(other.index) and self.dim == other.dim

See:
https://github.com/pydata/xarray/blob/e22b47511f4188e2203c5753de4a0a36094c2e83/xarray/core/indexes.py#L794C1-L797C72
The challenge is that the Ugrid topology object is more complicated, it has:

Required coordinates / connectivities
Optional coordinates / connectivities
Required attributes
Optional attributes

A reasonable assumption seems:

All required fields must be exactly the same (including attrs/metadata).
Optional attributes may be absent one or or more, but if present on multiple, they should equal exactly.

E.g. if derived coordinates such as centroid_coordinates are slightly dissimilar, the equals check should fail -- since that's what xarray does as well.
An overly strict implementation could be very short: simply convert to xarray via .to_dataset() and use xarray to compare for equality. This may be possible, depending on options available in the xarray .equals() methods.

To quickly solve this now, maybe:
def identical(self, other) -> bool;
    if other is self:
         return True
    elif not instance(other, type(self)):
         return False
    else:
         xr_self = self.to_dataset()
         xr_other = other.todataset()
         return xr_self.identical(xr_other)

This is arguably too strict (because it doesn't identify optional attributes). But better to be too strict than too accepting.

Some other thoughts I had: the to_dataset doesn't actually include all optional attributes. So it's only somewhat strict and actually quite a nice way of testing (the to_dataset decides what's essential info and what isn't). It's potentially only a bit strict on attributes; we could skip checking those via the standard xarray .equals() method and add some code to specifically check those ourselves separately.
Regardless, almost anything is an improvement over the current implementation...

Update:
@Huite and I discussed that __eq__ could potentially behave similar as the PandasIndex: returning an array of bools, but we are undecided if this behavior is warranted. More useful is a is_equivalent method which tests if differently ordered topologies are equal.
The code suggested here is implemented as .equals:

To quickly solve this now, maybe:
def __eq__(self, other) -> bool:
    if other is self:
         return True
    elif not instance(other, type(self)):
         return False
    else:
         xr_self = self.to_dataset()
         xr_other = other.to_dataset()
         return xr_self.identical(xr_other)

This is arguably too strict (because it doesn't identify optional attributes). But better to be too strict than too accepting.

Closing this issue for now. Reopen if there is a demand for __eq__.


feat: datacite parser first draft

Merging w/o edits yet (to resolve merge conflicts/code edit overlaps) - will make edits in a future PR


mobile - teammate have the option to join a team

A teammate could have the option to directly join a team in the mobile application.
He could enter a team token to join it.
( should it send the join team request in the admin captain view ? )

designed changed, not relevant anymore


Return NotSuchKey error code for bucket S3 DeleteObject method

Fixes for S3 DeleteObject

return 404 status code instead of 204 No content
return xml encoded error with code NoSuchKey

Sample s3 response:
curl -v -X DELETE localhost:8333/not/exist
*   Trying ::1:8333...
* TCP_NODELAY set
* Connected to localhost (::1) port 8333 (#0)
> DELETE /not/exist HTTP/1.1
> Host: localhost:8333
> User-Agent: curl/7.68.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< Accept-Ranges: bytes
< Content-Length: 201
< Content-Type: application/xml
< Date: Thu, 11 Jun 2020 14:56:48 GMT
< X-Amz-Request-Id:<PHONE_NUMBER>636162435
<
<?xml version="1.0" encoding="UTF-8"?>
* Connection #0 to host localhost left intact
<Error>NoSuchKey<Message>The specified key does not exist.</Message><Resource>/not/exist</Resource><RequestId>1591887408636143362</RequestId></Error>

@chrislusf actually I'm not sure about 404 status code when deleting nonexisting object in AWS.
I'm doing tests with Minio S3 server and it returns 404. I don't have AWS account to check it.

Actually no - Minio returns 204 No content.
Ceph S3 returns 204 as well - https://tracker.ceph.com/issues/7502.
So I'll remove handling of 404. The actual fix adds NoSuchKey code for GetObject/HeadObject

Thanks!
btw: How do you compare SeaweedFS S3 vs Minio vs Ceph S3?

@chrislusf I don't have own experience here but my employer looks for Ceph S3 alternatives. Main pain points are operations burden and not good enough latency.


QR Bill with QR Reference or Creditor Reference

Permits to create 2 new BankCreditTransfer specializations

BankCreditTransferWithCreditorReference
BankCreditTransferWithQRR

And produce correct XML structure

@z38 ping

Nice pull request, works well. Would it be possible to merge it @z38 ?

@z38 Could you please consider to merge this PR? It is working on my side since june 2020.

@z38 Could you please consider to merge this PR? It is working on my side since june 2020.

I'm very sorry for not responding sooner. Please see #47 about the plans for the future. If a fork emerges, I think this would be a very valuable contribution and good feature to get users move over to a new version.


configure error about ncurse lib

Steps to reproduce

git fetch -v
git pull
./configure
here we are

Expected behaviour

git fetch -v
git pull
./configure
here we are

Version of Vim
VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Mar 24 2024 13:16:49)
Environment
running debian bookworm // second station is trikie with the very exact similar issue
Logs and stack traces
[...]
checking for pid_t... (cached) yes
checking for size_t... (cached) yes
checking for uid_t in sys/types.h... (cached) yes
checking for uint32_t... (cached) yes
checking for ino_t... (cached) yes
checking for dev_t... (cached) yes
checking whether byte ordering is bigendian... (cached) no
checking for inline... (cached) inline
checking for rlim_t... (cached) yes
checking for stack_t... (cached) yes
checking whether stack_t has an ss_base field... no
checking --with-tlib argument... empty: automatic terminal library selection
checking for tgetent in -ltinfo... (cached) yes
tinfo library is not usable
checking for tgetent in -lncurses... no
checking for tgetent in -ltermlib... no
checking for tgetent in -ltermcap... no
checking for tgetent in -lcurses... no
no terminal library found
checking for tgetent()... configure: error: NOT FOUND!
      You need to install a terminal library; for example ncurses.
      On Linux that would be the libncurses-dev package.
      Or specify the name of the library with --with-tlib.

so I did
./configure --with-tlib=ncurses --enable-static --disable-shared  to force
I got
./configure --with-tlib=ncurses --enable-static --disable-shared
configure: WARNING: unrecognized options: --enable-static, --disable-shared
configure: loading cache auto/config.cache
checking whether make sets $(MAKE)... (cached) yes
checking for gcc... (cached) gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... (cached) o
checking whether the compiler supports GNU C... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to enable C11 features... (cached) none needed
checking how to run the C preprocessor... (cached) gcc -E
checking for grep that handles long lines and -e... (cached) /usr/bin/grep
checking for egrep... (cached) /usr/bin/grep -E
checking for fgrep... (cached) /usr/bin/grep -F
checking for gawk... (cached) gawk
checking for strip... (cached) strip
checking for sys/wait.h that is POSIX.1 compatible... (cached) yes
checking for unsigned long long int... (cached) yes
checking for long long int... (cached) yes
checking if the compiler supports trailing commas... yes
checking if the compiler supports C++ comments... yes
checking --enable-fail-if-missing argument... no
checking for clang version... N/A
checking for buggy tools... checking uname... Linux (cached)
checking uname -r... 6.0.0-4-amd64 (cached)
checking uname -m... x86_64 (cached)
checking for Haiku... no
checking for QNX... no
checking for Darwin (Mac OS X)... no
checking for stdio.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for stdint.h... (cached) yes
checking for strings.h... (cached) yes
checking for sys/stat.h... (cached) yes
checking for sys/types.h... (cached) yes
checking for unistd.h... (cached) yes
checking for sys/time.h... (cached) yes
checking for sys/select.h... (cached) yes
checking for sys/socket.h... (cached) yes
checking for AvailabilityMacros.h... (cached) no
checking for dispatch/dispatch.h... (cached) no
checking --with-local-dir argument... Defaulting to /usr/local
checking --with-vim-name argument... Defaulting to vim
checking --with-ex-name argument... Defaulting to ex
checking --with-view-name argument... Defaulting to view
checking --with-global-runtime argument... no
checking --with-modified-by argument... no
checking if character set is EBCDIC... no
checking --disable-smack argument... no
checking for linux/xattr.h... (cached) yes
checking for sys/xattr.h... (cached) yes
checking for XATTR_NAME_SMACKEXEC in linux/xattr.h... no
checking --disable-selinux argument... no
checking for is_selinux_enabled in -lselinux... (cached) yes
checking for selinux/selinux.h... (cached) yes
checking --enable-xattr argument... yes
checking for sys/xattr.h... (cached) yes
checking --with-features argument...  OK.
checking for glib-compile-resources... (cached) /usr/bin/glib-compile-resources
checking glib-compile-resources... usable.
checking --disable-icon-cache-update argument... not set
checking for gtk-update-icon-cache... (cached) /usr/bin/gtk-update-icon-cache
checking --disable-desktop-database-update argument... not set
checking for update-desktop-database... (cached) /usr/bin/update-desktop-database
checking for X11/SM/SMlib.h... (cached) yes
checking for X11/xpm.h... (cached) no
checking for X11/Sunkeysym.h... (cached) yes
checking for XIMText in X11/Xlib.h... yes
X GUI selected; xim has been enabled
checking for /proc link to executable... /proc/self/exe
checking for CYGWIN or MSYS environment... no
checking whether toupper is broken... (cached) no
checking whether __DATE__ and __TIME__ work... yes
checking whether __attribute__((unused)) is allowed... yes
checking for elf.h... (cached) yes
checking for main in -lelf... (cached) yes
checking for dirent.h that defines DIR... (cached) yes
checking for library containing opendir... (cached) none required
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for sys/select.h... (cached) yes
checking for sys/utsname.h... (cached) yes
checking for termcap.h... (cached) yes
checking for fcntl.h... (cached) yes
checking for sgtty.h... (cached) yes
checking for sys/ioctl.h... (cached) yes
checking for sys/time.h... (cached) yes
checking for sys/types.h... (cached) yes
checking for termio.h... (cached) yes
checking for iconv.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for langinfo.h... (cached) yes
checking for math.h... (cached) yes
checking for unistd.h... (cached) yes
checking for stropts.h... (cached) no
checking for errno.h... (cached) yes
checking for sys/resource.h... (cached) yes
checking for sys/systeminfo.h... (cached) no
checking for locale.h... (cached) yes
checking for sys/stream.h... (cached) no
checking for termios.h... (cached) yes
checking for libc.h... (cached) no
checking for sys/statfs.h... (cached) yes
checking for poll.h... (cached) yes
checking for sys/poll.h... (cached) yes
checking for pwd.h... (cached) yes
checking for utime.h... (cached) yes
checking for sys/param.h... (cached) yes
checking for sys/ptms.h... (cached) no
checking for libintl.h... (cached) yes
checking for libgen.h... (cached) yes
checking for util/debug.h... (cached) no
checking for util/msg18n.h... (cached) no
checking for frame.h... (cached) no
checking for sys/acl.h... (cached) no
checking for sys/access.h... (cached) no
checking for sys/sysinfo.h... (cached) yes
checking for wchar.h... (cached) yes
checking for wctype.h... (cached) yes
checking for sys/ptem.h... (cached) no
checking for sys/sysctl.h... (cached) no
checking for pthread_np.h... no
checking for strings.h... (cached) yes
checking if strings.h can be included after string.h... yes
checking whether gcc needs -traditional... (cached) no
checking for an ANSI C-conforming const... (cached) yes
checking for working volatile... (cached) yes
checking for mode_t... (cached) yes
checking for off_t... (cached) yes
checking for pid_t... (cached) yes
checking for size_t... (cached) yes
checking for uid_t in sys/types.h... (cached) yes
checking for uint32_t... (cached) yes
checking for ino_t... (cached) yes
checking for dev_t... (cached) yes
checking whether byte ordering is bigendian... (cached) no
checking for inline... (cached) inline
checking for rlim_t... (cached) yes
checking for stack_t... (cached) yes
checking whether stack_t has an ss_base field... no
checking --with-tlib argument... ncurses
checking for linking with ncurses library... configure: error: FAILED

I checked my libs list I have 100% needed libs as far as I know
I think there is really a code bug on finding or selecting libraries
dpkg -l | grep ncurses
ii  libncurses-dev:amd64                                        6.4+20240113-1                       amd64        developer's libraries for ncurses
ii  libncurses6:amd64                                           6.4+20240113-1                       amd64        shared libraries for terminal handling
ii  libncursesw6:amd64                                          6.4+20240113-1                       amd64        shared libraries for terminal handling (wide character support)
ii  ncurses-base                                                6.4+20240113-1                       all          basic terminal type definitions
ii  ncurses-bin                                                 6.4+20240113-1                       amd64        terminal-related programs and man pages
ii  ncurses-term                                                6.4+20240113-1                       all          additional terminal type definitions

no response

0-1995-4-~/GITLAB/others/vim $ ls configure*
configure
0-1995-5-~/GITLAB/others/vim $
there is no configure.log created

it's in the auto directory.

so you mean src/auto/config.log
but it doesn't help
[...]
#define HAVE_X11_SM_SMLIB_H 1
#define HAVE_X11_SUNKEYSYM_H 1
#define FEAT_XIM 1
#define PROC_EXE_LINK "/proc/self/exe"
#define HAVE_DATE_TIME 1
#define HAVE_ATTRIBUTE_UNUSED 1
#define HAVE_LIBELF 1
#define HAVE_DIRENT_H 1
#define HAVE_STDINT_H 1
#define HAVE_STDLIB_H 1
#define HAVE_STRING_H 1
#define HAVE_SYS_SELECT_H 1
#define HAVE_SYS_UTSNAME_H 1
#define HAVE_TERMCAP_H 1
#define HAVE_FCNTL_H 1
#define HAVE_SGTTY_H 1
#define HAVE_SYS_IOCTL_H 1
#define HAVE_SYS_TIME_H 1
#define HAVE_SYS_TYPES_H 1
#define HAVE_TERMIO_H 1
#define HAVE_ICONV_H 1
#define HAVE_INTTYPES_H 1
#define HAVE_LANGINFO_H 1
#define HAVE_MATH_H 1
#define HAVE_UNISTD_H 1
#define HAVE_ERRNO_H 1
#define HAVE_SYS_RESOURCE_H 1
#define HAVE_LOCALE_H 1
#define HAVE_TERMIOS_H 1
#define HAVE_SYS_STATFS_H 1
#define HAVE_POLL_H 1
#define HAVE_SYS_POLL_H 1
#define HAVE_PWD_H 1
#define HAVE_UTIME_H 1
#define HAVE_SYS_PARAM_H 1
#define HAVE_LIBINTL_H 1
#define HAVE_LIBGEN_H 1
#define HAVE_SYS_SYSINFO_H 1
#define HAVE_WCHAR_H 1
#define HAVE_WCTYPE_H 1
#define HAVE_STRINGS_H 1

configure: exit 1

it just displays exit 1 ;)

I seriously doubt that this is all of the logfile.

I have stumbled upon the same problem, I believe.
My system: Fedora 39
gcc version: gcc (GCC) 13.2.1 20231205 (Red Hat 13.2.1-6)
Here's the relevant part of my config.log:
configure:12695: checking --with-tlib argument
configure:12705: result: ncurses
configure:12708: checking for linking with ncurses library
configure:12721: gcc -o conftest -O2 -fno-strength-reduce -Wall -Wno-deprecated-declarations  -Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1    -L/usr/local/lib conftest.c -lelf  -lselinux  -lncurses >&5
configure:12721: $? = 0
configure:12723: result: OK
configure:12828: checking for tgetent()
configure:12841: gcc -o conftest -O2 -fno-strength-reduce -Wall -Wno-deprecated-declarations  -Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1    -L/usr/local/lib conftest.c -lelf  -lselinux  -lncurses >&5
conftest.c: In function 'main':
conftest.c:91:20: warning: unused variable 'res' [-Wunused-variable]
   91 | char s[10000]; int res = tgetent(s, "thisterminaldoesnotexist");
      |                    ^~~
/usr/bin/ld: /tmp/ccrJtmZ9.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIE
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
configure:12841: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME ""
| #define PACKAGE_TARNAME ""
| #define PACKAGE_VERSION ""
| #define PACKAGE_STRING ""
| #define PACKAGE_BUGREPORT ""
| #define PACKAGE_URL ""
| #define UNIX 1
| #define HAVE_SYS_WAIT_H 1
| #define HAVE_UNSIGNED_LONG_LONG_INT 1
| #define HAVE_LONG_LONG_INT 1
| #define HAVE_STDIO_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_UNISTD_H 1
| #define HAVE_SYS_TIME_H 1
| #define HAVE_SYS_SELECT_H 1
| #define HAVE_SYS_SOCKET_H 1
| #define STDC_HEADERS 1
| #define HAVE_SELINUX 1
| #define HAVE_XATTR 1
| #define FEAT_HUGE 1
| #define USE_XSMP_INTERACT 1
| #define FEAT_DIFF 1
| #define FEAT_PERL 1
| #define FEAT_PYTHON3 1
| #define HAVE_X11 1
| #define SIZEOF_WCHAR_T 0
| #define SMALL_WCHAR_T 1
| #define HAVE_X11_SM_SMLIB_H 1
| #define HAVE_X11_XPM_H 1
| #define HAVE_X11_SUNKEYSYM_H 1
| #define HAVE_X11_XMU_EDITRES_H 1
| #define HAVE_XM_XM_H 1
| #define HAVE_XM_XPMP_H 1
| #define HAVE_XM_JOINSIDET_H 1
| #define HAVE_XM_TRAITP_H 1
| #define HAVE_XM_MANAGER_H 1
| #define HAVE_XM_UNHIGHLIGHTT_H 1
| #define HAVE_XM_NOTEBOOK_H 1
| #define XPMATTRIBUTES_TYPE XpmAttributes
| #define FEAT_XIM 1
| #define PROC_EXE_LINK "/proc/self/exe"
| #define HAVE_DATE_TIME 1
| #define HAVE_ATTRIBUTE_UNUSED 1
| #define HAVE_LIBELF 1
| #define HAVE_DIRENT_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_SYS_SELECT_H 1
| #define HAVE_SYS_UTSNAME_H 1
| #define HAVE_TERMCAP_H 1
| #define HAVE_FCNTL_H 1
| #define HAVE_SGTTY_H 1
| #define HAVE_SYS_IOCTL_H 1
| #define HAVE_SYS_TIME_H 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_TERMIO_H 1
| #define HAVE_ICONV_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_LANGINFO_H 1
| #define HAVE_MATH_H 1
| #define HAVE_UNISTD_H 1
| #define HAVE_ERRNO_H 1
| #define HAVE_SYS_RESOURCE_H 1
| #define HAVE_LOCALE_H 1
| #define HAVE_TERMIOS_H 1
| #define HAVE_SYS_STATFS_H 1
| #define HAVE_POLL_H 1
| #define HAVE_SYS_POLL_H 1
| #define HAVE_PWD_H 1
| #define HAVE_UTIME_H 1
| #define HAVE_SYS_PARAM_H 1
| #define HAVE_LIBINTL_H 1
| #define HAVE_LIBGEN_H 1
| #define HAVE_SYS_SYSINFO_H 1
| #define HAVE_WCHAR_H 1
| #define HAVE_WCTYPE_H 1
| #define HAVE_STRINGS_H 1
| /* end confdefs.h.  */
| int tgetent(char *, const char *);
| int
| main (void)
| {
| char s[10000]; int res = tgetent(s, "thisterminaldoesnotexist");
|   ;
|   return 0;
| }
configure:12846: error: NOT FOUND!
      You need to install a terminal library; for example ncurses.
      On Linux that would be the libncurses-dev package.
      Or specify the name of the library with --with-tlib.

I managed to fix this changing the compiler to clang in src/Makefile (dirty way):
CC=clang

clang version: 17.0.6 (Fedora 17.0.6-2.fc39)
With clang everything worked out well. Hope it helps in some way.

      You need to install a terminal library; for example ncurses.
      On Linux that would be the libncurses-dev package.
      Or specify the name of the library with --with-tlib.
1-2042-45-~/GITLAB/others/vim $

still just the same

I suppose you both used --enable-perl ? The problem is, that the PERL_CFLAGS leak into CFLAGS I think.
This is just a guess, but can you test this patch please:
diff --git a/src/auto/configure b/src/auto/configure
index 0e0cf8efe..ffed969c8 100755
--- a/src/auto/configure
+++ b/src/auto/configure
@@ -6501,6 +6501,7 @@ printf "%s\n" "$vi_cv_perl_xsubpp" >&6; }
                -e 's/-pipe //' \
                -e 's/-flto\(=auto\)\? //' \
                -e 's/-W[^ ]*//g' \
+               -e 's/-Wl,-z,relro//' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
             perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
diff --git a/src/configure.ac b/src/configure.ac
index f6e54b30b..e45e7b791 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1171,6 +1171,7 @@ if test "$enable_perlinterp" = "yes" -o "$enable_perlinterp" = "dynamic"; then
                -e 's/-pipe //' \
                -e 's/-flto\(=auto\)\? //' \
                -e 's/-W[[^ ]]*//g' \
+               -e 's/-Wl,-z,relro//' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
       dnl Remove "-lc", it breaks on FreeBSD when using "-pthread".
       perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \

It removes -Wl,-z,relro which I think causes the error about relocation .. cannot be used
@goblinrieur please show the actual error from your log and not just the end. Thanks.

Actually, I think there is also a bug coming from patch 8.0.1156 If you look closely, the change in configure.ac is slightly different then in configure:
	-e 's/-W[^ ]*//g' \

This was at the time in configure, but in configure.ac there is a typo:
	-e 's/-W[[^ ]]*//g' \

I think, fixing this bug, will also clean up the -Wl,-z,relro flag from the PERL_CFLAGS. I'll make that change now, please check if it still fails after 9.1.406

ah sorry, no that's not it.

can any of you please share the complete configure.log file?

config.log

That is strange, configure add -lelf earlier:
configure:11415: checking for main in -lelf
configure:11445: result: yes

This should have compiled and linked using -lelf.
But later it uses -lelf and it errors out:
configure:12803: gcc -o conftest -g -O2   -L/usr/local/lib conftest.c -ltinfo -lelf  -lselinux >&5
/usr/bin/ld: cannot find -lelf: No such file or directory
collect2: error: ld returned 1 exit status

I have no idea how this happens. In any case, try to install libelf-dev

config.log
In my case there's no -lelf error.

removed and forced reinstall libelf-dev did the spot

@goblinrieur so your issue is fixed now?
@chesheer-smile in your case the PERL_LIBS when enabling --perl-interp leak into the normal LIB flags.
Can you check if this patch fixes it? I am only guessing, that this is caused by -Wl,-z,relro so not sure.
diff --git a/src/auto/configure b/src/auto/configure
index 0e0cf8efe..c0e6be8f3 100755
--- a/src/auto/configure
+++ b/src/auto/configure
@@ -6502,9 +6502,9 @@ printf "%s\n" "$vi_cv_perl_xsubpp" >&6; }
                -e 's/-flto\(=auto\)\? //' \
                -e 's/-W[^ ]*//g' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
-            perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
+                  perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
-                       -e 's/-bE:perl.exp//' -e 's/-lc //'`
+                       -e 's/-bE:perl.exp//' -e 's/-lc //' -e 's/-Wl,-z,relro//'`
                   perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
                -e 'ccdlflags' | sed -e 's/-bE:perl.exp//'`

diff --git a/src/configure.ac b/src/configure.ac
index f6e54b30b..1dce6467b 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1173,9 +1173,10 @@ if test "$enable_perlinterp" = "yes" -o "$enable_perlinterp" = "dynamic"; then
                -e 's/-W[[^ ]]*//g' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
       dnl Remove "-lc", it breaks on FreeBSD when using "-pthread".
+      dnl Remove "-Wl,-z,relro" This breaks linking:  "relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object"
       perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
-                       -e 's/-bE:perl.exp//' -e 's/-lc //'`
+                       -e 's/-bE:perl.exp//' -e 's/-lc //' -e 's/-Wl,-z,relro//'`
       dnl Don't add perl lib to $LIBS: if it's not in LD_LIBRARY_PATH
       dnl a test in configure may fail because of that.
       perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \

BTW: I don't know if you really need libelf-dev. I had never installed it and Debian also does not include it in the list of build-dependencies for Vim. So you may as well get rid of it.

I Ran the configure successfully just now.  Ran the make successfully too.
I do not understand why the libelf-dev had to be removed\reinstalled but that seems to fix my use-case.

No, this diff doesn't work on my machine. I attach config.log for comparison.
config.log

can you show me the output of those two commands:
/usr/bin/perl -MExtUtils::Embed -e 'ldopts'

/usr/bin/perl -MExtUtils::Embed -e 'ccdlflags;print"\n"'

Here:
me@desktop:~$ /usr/bin/perl -MExtUtils::Embed -e 'ldopts'
-Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1  -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1  -fstack-protector-strong -L/usr/local/lib  -L/usr/lib64/perl5/CORE -lperl -lpthread -lresolv -ldl -lm -lcrypt -lutil -lc
me@desktop:~$ /usr/bin/perl -MExtUtils::Embed -e 'ccdlflags;print"\n"'
 -Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1

So it is in both, even twice in perllibs :/
Try this one here then please:
diff --git a/src/auto/configure b/src/auto/configure
index 0e0cf8efe..b0a336b62 100755
--- a/src/auto/configure
+++ b/src/auto/configure
@@ -6502,11 +6502,11 @@ printf "%s\n" "$vi_cv_perl_xsubpp" >&6; }
                -e 's/-flto\(=auto\)\? //' \
                -e 's/-W[^ ]*//g' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
-            perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
+                  perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
-                       -e 's/-bE:perl.exp//' -e 's/-lc //'`
-                  perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
-               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//'`
+                       -e 's/-bE:perl.exp//' -e 's/-lc //' -e 's/-Wl,-z,relro//g'`
+                        perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
+               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//' -e 's/-Wl,-z,relro//g'`

                   { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking if compile and link flags for Perl are sane" >&5
 printf %s "checking if compile and link flags for Perl are sane... " >&6; }
diff --git a/src/configure.ac b/src/configure.ac
index f6e54b30b..50d04086c 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1173,13 +1173,15 @@ if test "$enable_perlinterp" = "yes" -o "$enable_perlinterp" = "dynamic"; then
                -e 's/-W[[^ ]]*//g' \
                -e 's/-D_FORTIFY_SOURCE=.//g'`
       dnl Remove "-lc", it breaks on FreeBSD when using "-pthread".
+      dnl Remove "-Wl,-z,relro" This breaks linking:  "relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object"
       perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
-                       -e 's/-bE:perl.exp//' -e 's/-lc //'`
+                       -e 's/-bE:perl.exp//' -e 's/-lc //' -e 's/-Wl,-z,relro//g'`
       dnl Don't add perl lib to $LIBS: if it's not in LD_LIBRARY_PATH
+      dnl Remove "-Wl,-z,relro" This breaks linking:  "relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object"
       dnl a test in configure may fail because of that.
       perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
-               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//'`
+               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//' -e 's/-Wl,-z,relro//g'`

       dnl check that compiling a simple program still works with the flags
       dnl added for Perl.

config.log
Sadly, still doesn't work.

okay, I used a CentOS Steam vm and tested it. It seems to come from -spec arg. So something like the following patch should (this time really!) fix it:
diff --git a/src/auto/configure b/src/auto/configure
index 0e0cf8efe..ffa01a5bc 100755
--- a/src/auto/configure
+++ b/src/auto/configure
@@ -6504,9 +6504,10 @@ printf "%s\n" "$vi_cv_perl_xsubpp" >&6; }
                -e 's/-D_FORTIFY_SOURCE=.//g'`
             perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
+                       -e 's/-specs=[^ ]*//g' \
                        -e 's/-bE:perl.exp//' -e 's/-lc //'`
                   perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
-               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//'`
+               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//' -e 's/-specs=[^ ]*//g'`

                   { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking if compile and link flags for Perl are sane" >&5
 printf %s "checking if compile and link flags for Perl are sane... " >&6; }
diff --git a/src/configure.ac b/src/configure.ac
index f6e54b30b..bc0db7cfd 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1175,11 +1175,12 @@ if test "$enable_perlinterp" = "yes" -o "$enable_perlinterp" = "dynamic"; then
       dnl Remove "-lc", it breaks on FreeBSD when using "-pthread".
       perllibs=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed -e 'ldopts' | \
                sed -e '/Warning/d' -e '/Note (probably harmless)/d' \
+                       -e 's/-specs=[[^ ]*]//g' \
                        -e 's/-bE:perl.exp//' -e 's/-lc //'`
       dnl Don't add perl lib to $LIBS: if it's not in LD_LIBRARY_PATH
       dnl a test in configure may fail because of that.
       perlldflags=`cd $srcdir; $vi_cv_path_perl -MExtUtils::Embed \
-               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//'`
+               -e 'ccdlflags' | sed -e 's/-bE:perl.exp//' -e 's/-specs=[[^ ]*]//g'`

       dnl check that compiling a simple program still works with the flags
       dnl added for Perl.

Hooray! This time it works. Thank you for your efforts and time.

thanks all
@chesheer-smile so we close the issue ?

Yeah, sure. Everything works as intended on my side.

let me include this patch then.


[core-amqp] handle possible undefined receiver in timeout handler

The live test logs shows that under some circumstance this.receiver could be
undefined.  We do have code to clean up the timer already so that might have
happened before the clean up and after receiver is closed.
     Uncaught TypeError: Cannot read properties of undefined (reading 'address')
      at Receiver.get address [as address] (/Users/runner/work/1/s/common/temp/node_modules/.pnpm/rhea-promise@2.1.0/node_modules/rhea-promise/lib/link.ts:96:24)
      at Timeout._onTimeout (/Users/runner/work/1/s/sdk/core/core-amqp/src/requestResponseLink.ts:158:39)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

This PR ensures that we don't throw when this.receiver is undefined.  The
address is only used in logging.

API change check for @azure/core-amqp
API changes are not detected in this pull request for @azure/core-amqp

sounds like the receiver type could be better?

sounds like the receiver type could be better?

Good question!  I've search around but couldn't see how this could become undefined at runtime.  I will keep the current typing.


Test.sol import statement changed

Import file path changed to relative path. By the way, only this line was using this type of import statement (with remappings).
If we want to different remappings or even don't want to use remappings, some checker/analyzer tools can be confused that hard to understand of remappings. Nested libraries can be problematic.
My suggestion is using relative path for libraries but I'm open too other suggestions.

@mattsse do you have a preference on this? given your comment here: https://github.com/foundry-rs/forge-std/pull/195#discussion_r1001448633 (though I'm not sure if this has ever caused issues, since ds-test is pretty stable and everyone is using the same version anyway)
@GokhanPolat if we do want this change, let's change the target branch to the v0.3 branch of #184

I'm not aware of any issues re Test import.
there's a possibility that at different ds-test remapping will override this, but as mentioned it's pretty stable.
But the motivation for this PR seems unrelated.
given that forge-std is bundled with ds-test I think we can safely make this change?
But I guess using a relative import here ensure we always pull in the expected version.

given that forge-std is bundled with ds-test I think we can safely make this change?

Yea, I think this should be safe, and I guess it can't hurt, so may as well do it? Though personally I don't like using relative paths hehe, but since forge-std is included by default, guess it's ok to err on the side of "ensure remappings always get correct ds-test version"

@mds1

Though personally I don't like using relative paths

Absolutely agree with you. So how should we proceed?

I'm going to close this for now since I don't think it's needed—ds-test has been stable in this repo for quite some time, and we haven't heard reports of any issues resulting from it, let's leave this as-is
But if we ever update the ds-test submodule version, we can make this change at the same time to ensure the new one is used. Thanks @GokhanPolat!


Improvements

Hello,
I have implemented the improvements on module 5. I would appreciate any feedback and if you would like to pull them feel free.
Thanks for the guide pdf.

I'm sorry, but I cannot merge this PR. Remember these are exercises designed for beginners. Using an additional NuGet package is not part of what we would like to be teaching them this early on. Also, I'm not sure what your improvements are all about. Could you provide more context?

It's fine if you cannot merge it.
I am a beginner myself but I just could not think of any other way to implement them without a NuGet package.
If you have suggestions that will be great.
The improvements I am referring to are the bullet points below taken from the pdf at Module 5 Lab:
● Display the maximum delay in addition to the average.
● Some people say not all airlines are equally bad. Display the results grouped by airline,  so you can make more informed decisions.
● Determine which is the worst airport to fly from, and which is the worst airport to fly to

OK, I now understand what you were trying to do. I would love to merge your work if you rewrite it so that it doesn't depend on external NuGet packages. It is definitely doable with just plain LINQ.


How can I use case insensitive values in oneof validator

The case is I need to validate case insensitive oneof values in the field of JSON struct and not able to find anything. Can anyone suggest me anything to achieve the same?

The field to be compared with the oneof values can be converted to lower case before validating the struct.

@vijsourabh as @filikos stated you could normalize the data if that's an option; here's a lib to help out with that https://github.com/go-playground/mold
If not then a custom validator is also an option.

@deankarn & @filikos, It worked, Thanks :)

This is a rather obtuse solution "downcase the value before validating" the point of the project is to add magic to model validation right? Adding another meta tag that will handle casing would be rather helpful. There are more applications to model validations that serving up 400s to a client, and using the same model across a platform is of benefit. I could accept "we are taking pull requests!" as a better answer than "downcase the value", it's essentially a non-answer.

@draper-lucid

Please try not to comment on closed issues unless it's also asking to be re-opened.
This is a rather obtuse solution is it? Depends on your use case. Sanitization of data before storing is the norm in my experience ymmv. In any case, it's not a non-answer.
Nobody's stopping anyone from making a PR for a new validation tag, something like case_insensitive_oneof or alike.
Library also allows creating and registering custom validations for you use case that's not supported by default. In fact for oneof I usually register my own custom one in order to leverage an internal map, array etc.. that holds these concrete values in the code and if any are added or removed there's no forgetting to update the struct tags.

Just another idea
Register your new validation
validate.RegisterValidation("oneof_insensitive", validateOneOfInsensitive)

Validation logic for oneof_insensitive case
func validateOneOfInsensitive(fl validator.FieldLevel) bool {
	fieldValue := fl.Field().String()
	allowedValues := strings.Split(fl.Param(), " ")

	for _, allowedValue := range allowedValues {
		if strings.EqualFold(fieldValue, allowedValue) {
			return true
		}
	}

	return false
}


4652/work on flakes

Description
Updated the test cases 2.1 and 5.1
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Merged into branches iso6, master in bb2f3d47eb59d1fbe0ae240ad2419b82df447f88


Give Resample UI some <3

Series, and particularly Rule could be a dropdown.
Rule is just the time period, so frontend backend need to agree, backend code is at https://github.com/grafana/gel-app/blob/master/pkg/mathexp/resample.go#L15

https://github.com/grafana/grafana/issues/24057


Add travis

Add travis to run the linters

Please see this: https://travis-ci.org/hackupc/frontend/builds/262490397?utm_source=github_status&utm_medium=notification

I already said it in the PR I integrated the linter that there were a few hundreds of style errors 🙃

Yay. Is there any way to have it automatically fixed (or at least some?)

I think some of the js ones can be fixed automatically. Will try to do it. Regarding html and scss I believe not

I fixed all the js. Only css and html missing sigh

closing this as its stale now


Alias for value doesn't work.

Describe the bug
No action is taken when selecting field's Alias for value menu in chart view or dashboard edit screen.
Return value for request is :
{"code":"GB0001","details":"NullPointerException: "}
To Reproduce
Steps to reproduce the behavior:

Go to workbook
Click on edit dashboard
Click on Alias for value metnu on datasource field.
See error

Expected behavior
We should see a screen where you can edit the alias value for the field value.
Screenshots
Desktop (please complete the following information):

Version 3.2.0

Additional context
Add any other context about the problem here.

@eltriny plz check as below


add a worker-src suggestion

Depending on how your restrictive your CSP policy is, worker-src may need to be added to support the bot detection
worker-src 'self' is required for some policy implementations to support Javascript Implementations

Hi @computeronix ! Thanks for bringing this to our attention. As long as the script-src (which is always required) is fine, the worker-src should not matter.
I will be closing this ticket now but please feel free to open another in case you would like to show a scenario in which it's required.


Fix Spain Almeria code

Almeria, a region from Spain, is incorrectly identified as 'AN' instead of 'AL'.
'AN' is the code for 'Andalucia'
Reference: ISO 3166-2:ES-AL

Thanks!


Expose service properties to D-Bus API (revised)

Introduces only "Version" and "Adapters" as Properties for org.bluealsa.Manager1 DBus interface

I've applied the patch with some minor and two major changes. In order to speed up merge process, I've updated the PR by myself (I hope you don't mind). Fixed "issues" with original PR:

It is not right to access ba_adapter without referencing it with ba_adapter_ref() or locking all adapters with mutex. It is possible that "if" which checks for available adapter will pass, and in the same time in some other thread this adapter will be freed, so accessing adapter fields will lead to invalid memory access.
I've changed parse_dbus_string_array function into more generic bluealsa_dbus_message_iter_array_get_strings which work in a similarly to g_variant_get_strv but without malloc usage. I did not like this part: &array[count * strlen] -accessing elements of char[][] via char[index * element_size].

Other that that I've also added "Service" to the listing. So in case of multi bluealsa setup, it will be easier to spot which listing is for which service.


won't start up

I have a brand new system, my first time using MacOS, followed this tutorial: https://youtu.be/k94qImbFKWE?si=mPhpvX5OPSK_R6wF
just used yabai --start-service instead of brew services start yabai
I got to the point where I needed to give acces in the System settings. But after that I used yabai --start-service and restart and stop, but it just won't turn on no matter what and I'm stuck with this now
It doesn't even respond, screenshot shows the Terminal.

It looks like the terminal did not give any errors when you put in yabai --restart-service. It looks like yabai should be running.
Try running yabai --start-service on the terminal, and then try running this command yabai -m config layout bsp. (best to run it with multiple windows on your current space) If this command works to tile your windows, then that means that yabai is working, and you should then configure skhd to run these commands with keyboard shortcuts.

brew services start yabai has been replaced by yabai --start-services

You have to run yabai --start-service at least once before you can use --restart-service. You can't restart something that isn't running. If you run --stop-service you also need to run --start-service again, not --restart-service.


Resolved the conflicts for become partner page

https://github.com/anuragverma108/WildGuard/issues/68
This pull request adds a new "Become-a-Partner" page to the WildGuard project . The following changes have been made:
1.Basic Contact Info: Name, email, phone.
2.Partnership Type: Choose between sponsor, donor, or event partner.
3.Agreement: Consent to terms and conditions
4.Submit.
Before Changes :
https://github.com/user-attachments/assets/9fa28e9b-6f8f-4d17-9cd5-272224f7722d
After Changes:
https://github.com/user-attachments/assets/fb852195-a9cb-476c-a4bf-9c232270292f
Key changes:
Added folder : Become-a-Partner which contains the necessary files

@anuragverma108  I have resolved the conflicts and suggested please check

Great contribution to Hacktoberfest'24! 🎉


Consider adding a different effect that holds an implicit Scope

In https://github.com/TristanCacqueray/ki-effectful/issues/1 and https://github.com/TristanCacqueray/ki-effectful/issues/6 we went back and forth on whether or not StructuredConcurrency should hold a Scope.
I wonder whether we might want to just have a different effect (straw name: Scoped) that holds a Scope. That is:

StructuredConcurrency tells us that the computation may create structured concurrency scopes
Scoped tells us that a computation is actually running in a structured concurrency scope.

This isn't an unusual pattern, it's a bit like having one effect that says "you can access the database" and one effect that says "you are in a transaction".
Concretely, this might look like this:
module Ki.Effectful.Implicit where

data Scoped :: Effect

scoped :: StructuredConcurrency :> es => Eff (Scoped : es) a -> Eff es a

fork :: Scoped :> es => Eff es a -> Eff es (Thread a)

Why do this? Well, it seems to me that Scope is a handle for a local effect, namely spawning threads into the scope you created. We have a bit of a split in the effect-systems community about whether we like explicit handles (bluefin-style) or constraints (effectful-style). Since effectful tends to go for managing effect handles using constraints, perhaps it is more idiomatic to do that for Scopes.
What about the worry in https://github.com/TristanCacqueray/ki-effectful/issues/6 ? My take on that is that the suspicious thing is taking a Scope as an argument to a top-level. The only change with Scoped would be that having Scoped as a constraint on a top-level function would be a bit suspicious. Perhaps it makes it seem more natural to inherit Scoped constraints, and that's bad? But that seems like an education problem, much like it seems natural to pass around Scopes, but maybe that's bad.
Plus, because Scoped is a separate effect, you can still run everything in local scopes perfectly well. And we can provide both styles without them interfering with each other.

Hello @michaelpj,
That sounds good to me. However, while this should fix #6, I'm concerned about the increased complexity. For example:

The types doesn't guarantee that a new scope obtained after calling scoped will take precedence over an existing Scoped constraint. It seems like this boil down to the implementation of consEnv and I would worry this may not work as expected.

How to fork into a higher scope, do we also need to bring back (from #2):

-- | Provide a callback function to run an action within the current `Scope`.
withCurrentScope ::
    Scoped :> es =>
    ((forall es' a. Scoped :> es' => Eff es' a -> Eff es' a) -> Eff es b) ->
    Eff es b
withCurrentScope f = do
    rep <- getStaticRep @Scoped
    f (localStaticRep (const rep))

Should the Scoped constraint allow using atomically? It looks like we would need a dedicated STM effect to make this cleaner.

I wouldn't mind integrating this new design to see how it works in practice, though I have to say that I'm not using this library. I was hoping to pull it in Butler, but I'm still debating the complexity cost of an effect system.
So I'd love to get the opinion of @mmhat and @mitchellwrosen on this new design.
Perhaps @arybczak could tell us if having a new STM effect would make sense too.
Thanks!

Perhaps @arybczak could tell us if having a new STM effect would make sense too.

For the record, effectful puts atomically into the Concurrent effect. IIRC I did it since if you use STM, you work with threads anyway so you'd need stuff from Concurrent anyway.

The types doesn't guarantee that a new scope obtained after calling scoped will take precedence over an existing Scoped constraint.

I think they do. What I'm proposing is really just a synonym for Reader Scope, and it should work just as well (or not) as that. I think it will all work out fine: if you have another Scoped effect in the tail of your effects but you can't see it, you won't use it! If you want to access two you need to use labelled effects (just like for Reader).

How to fork into a higher scope, do we also need to bring back

I'm not sure I'm understanding the use case, but if you want to have two Scoped effects and chose which one to fork into, then you can just use labelled effects (again, see Reader).

Should the Scoped constraint allow using atomically? It looks like we would need a dedicated STM effect to make this cleaner.

Awkward. Arguably you in fact only need STM in Scoped, not StructuredConcurrency, if all you're using it for is to await scopes!
But I do agree this would be nicer with a STM effect.

IIRC I did it since if you use STM, you work with threads so you'd need stuff from Concurrent anyway.

I think there are interesting cases here. One is if you have some code that will run in a multi-threaded scenario, but is itself single-threaded. Such code often reads and writes TVars, but doesn't need the full power of Concurrent. Similarly, in the scenario we are thinking of here, we have code which does only structured launching of threads, or maybe none at all (in the case of Scoped), but needs STM. So I think there is some value...

The types doesn't guarantee that a new scope obtained after calling scoped will take precedence over an existing Scoped constraint.

I think they do.

Correct, given E :> es => Eff (E : es) a when you make use of E, the first one on the list is picked (to access the underlying one at this point you need raise). This is the only way :> can work, implementation of consEnv isn't a factor.

I'm afraid I don't have too much to add to the discussion here beyond the scattered thoughts in #6 and in a few discussions, but regarding this:

Scoped tells us that a computation is actually running in a structured concurrency scope.

I will note that Scoped wouldn't exactly mean "is running in a structured concurrency scope" but rather "can spawn threads into an implicitly-passed structured concurrency scope".
"Running a structured concurrency scope" isn't captured in the type system in any of these variants as far as I understand: it's just an IO action.
I can certainly imagine Reader Scope being put to good work, but I happen to have avoided that design in my own work in favor of an explicit Scope object.
Cheers!

Thank you for taking the time to provide your feedback. I really appreciate it!
I think @michaelpj meant that Scoped guarantees forks don't leak. I'd be curious to see a use-case where you wouldn't want the StructuredConcurrency effect too.
Thank you for introducing labeled effects, that looks useful, though I'm not sure how I would use that in butler. My use-case is for a helper function (code) to create a kill-able 'Process', using the hitman trick from https://github.com/awkward-squad/ki/discussions/12#discussioncomment-3394438 . This helper takes an optional parent process to enable building a process hierarchy along side ki machinery. Therefor I need to pick the parent scope based on the parameters. I guess this helper could be implemented differently, but I worry such usage become too complicated when using type level effect to carry the scope.
Additionally, I’m cautious about the debugging experience. I had to take this helper apart to reproduce https://github.com/awkward-squad/ki/issues/19 , and having an explicit scope helped the investigation.
That being said, I’m open to being persuaded otherwise, but Scoped looks like a significant type-level work for a marginal gain at the term-level.

I think @michaelpj meant that Scoped guarantees forks don't leak.

I hadn't thought about that, but I guess it is somewhat true: if you have only Scoped and not StructuredConcurrency then you can fork into the scope but not create new ones. I'm not sure how useful that is.

Thank you for introducing labeled effects, that looks useful, though I'm not sure how I would use that in butler

Our use case is pretty much the one I describe here: https://github.com/awkward-squad/ki/discussions/35
To be honest, my main motivation is the abstract one I gave in the original post about how we track effect handles. Scopes look like effect handles and so I feel like I should be putting them in constraints! But it's not exactly a big deal.


Cannot add new container

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing 😞


Extract ThreadManager and introduce EngineStatus

First step of the engine lifecycle redux.
This step

moves threading related elements of the engine into a ThreadManagementSubsystem
introduces EngineStatus and EngineStatus subscription. This allowed the SplashScreen to be moved into the PC facade.
tweaks the various broad states of the engine (initialised/running/shutdown/disposed)

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/153/
Hooray Jenkins reported success with all tests good!

Poking potentially interested parties: @msteiger @MarcinSc @prestidigitator @flo @synopia

It's better then what we had be fore. So I am up for merging it.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/160/
Hooray Jenkins reported success with all tests good!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/161/
Build Log
last 5 lines
[...truncated 91 lines...]
   at hudson.model.Executor.run(Executor.java:240)
[ANALYSIS-COLLECTOR] Skipping publisher since build result is FAILURE
Notifying upstream projects of job completion
Setting status of 12edab53aa30ec79088403c8ec73576ddd026952 to FAILURE with url http://jenkins.terasology.org/job/TerasologyPRs/161/ and message: Merged build finished.

Uh oh, something went wrong with the build. Need to check on that

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/162/
Build Log
last 5 lines
[...truncated 2427 lines...]
Build step 'Publish JUnit test result report' changed build result to UNSTABLE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #160
Notifying upstream projects of job completion
Setting status of 58892c5510b6e1bfddf956252a61a37291c4bcfd to FAILURE with url http://jenkins.terasology.org/job/TerasologyPRs/162/ and message: Merged build finished.

Uh oh, something went wrong with the build. Need to check on that

I wish we could distinguish between unstable (test failures) and build failure in Jenkins on these PR tests (at least the log snippet gives a clue). The "failure" is from a single unit test seemingly breaking
http://jenkins.terasology.org/job/TerasologyPRs/162/testReport/junit/org.terasology.identity/CertificateTests/checkGeneratedSelfSignedCertificateValid/
Might fail in the main job too, still running. Probably an easy fix :-)
Thanks for all the work and review!


Entities can sometimes be missing

已收到~

Fixed in: https://github.com/vircadia/vircadia-web-sdk/pull/235

已收到~


feat(watcher): add symbol queries for ruby rspec tests

I've been using these symbols queries via ruby-lsp[^1] on a Ruby on Rails RSpec application for the past few weeks with success. The watcher feature is so useful!
Most RSpec classes look like this:
RSpec.describe MyClass do
  it "my first test" do
    # ...
  end
end

It also covers name spaced modules like so, MyClass is the returned symbol.
RSpec.describe NameSpaceModule1::NameSpace2::MyClass do
  it "my first test" do
    # ...
  end
end

References:
[^1]: https://github.com/Shopify/ruby-lsp

Thanks for the PR! :smile:


Fix typo in frFR.ts

Correct the spelling of nœud.

Hi!
Justing changing the target branch to dev, as master automatically triggers a release draft for new version.
Thanks for the fix.


WIP: Cleanup Vagrant and make it use userdata.txt

smoothing out Vagrantfile to run "puppet apply --tags packages first"
Adding a default sources.list, this does the initial package pull faster. (WIP)
adding provision to move to a configurable mirror

WIP, so please do not merge

please test this

please test this

this patch conflates way too many changes. I would prefer if you can isolate the changes that only effect vagrant from those that potentially effect all builds (ie: things that touch userdata) and submit them separately.


error during verifying trs context: Invalid transaction timestamp

Testnet delegate gr8blondino reported: I'm unable to increase stack amount. getting "invalid transaction timestamp

Telegram user yarooo can't reproduce the bug

System time of gr8blondino was ~30seconds ahead`
no bug


Support for text line height and input border color(focus state)

Description
This PR:

Adds support for line height for text block component.
Adds functionality to configure border color for input component when in focus.

How Verified

Line Height
Before
After

iOS

Android

Input Border
Before
After

iOS

Android

LGTM


Added the advanced section, for selecting Chat and Tab Completion separately

Simple Section:

Advanced Section:

the second information snippet should only show up in simple mode
in simple mode, when both combos are set to "Keep existing", the Setup button is not disabled, as in advanced mode

thanks @SachinS10-lab


Recipients Item issue

While trying to set this up, in the Send push notification V2, Recipients Item field I can only select fields from the Bookable Resource Booking entity. The email address of the Bookable Resource is not on this entity so the Flow can not be configured as stated in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da4aebce-e190-4abd-d2e3-ba57fe98b059
Version Independent ID: 76f622bf-bbee-4223-fc3b-0f0e565e8ed1
Content: Enable push notifications for the Field Service (Dynamics 365) mobile app
Content Source: ce/field-service/mobile-power-app-push-notifications.md
Service: dynamics-365-customerservice
GitHub Login: @FieldServiceDave
Microsoft Alias: daclar

Thanks for raising this issue! I've added your feedback to our backlog for upcoming doc updates.
In the meantime, if you need any troubleshooting input, feel free to post on our community site for more eyes on the issue! https://community.dynamics.com/365/fieldservice


Add DBA-RegServer is getting an error message about activedirectorytenant

Environmental information
Version Information
PSVersion                      5.0.10586.117
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.117
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
dbatools Module version:
Name    : dbatools
Path    : C:\windows\system32\WindowsPowerShell\v1.0\Modules\dbatools\dbatools.psd1
Version : 1.0.9
SQL Server:
Microsoft SQL Server 2014 (SP3-CU2) (KB4482960) - 12.0.6214.1 (X64)
Feb  2 2019 01:10:18
Copyright (c) Microsoft Corporation
Enterprise Edition: Core-based Licensing (64-bit) on Windows NT 6.3  (Build 9600: ) (Hypervisor)
Report

Host used

[ X] powershell.exe
[ ] ISE
[ ] VS Code
[ ] Other (please specify)

Errors Received
writeErrorStream      : True
PSMessageDetails      :
Exception             : System.Exception: The property 'ActiveDirectoryTenant' cannot be found on this object. Verify that the property exists and can be set. --->
                        System.Management.Automation.RuntimeException: The property 'ActiveDirectoryTenant' cannot be found on this object. Verify that the property exists and can be set.
                           at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
                           at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
                           --- End of inner exception stack trace ---
TargetObject          :
CategoryInfo          : InvalidOperation: (:) [Write-Error], Exception
FullyQualifiedErrorId : dbatools_Add-DbaRegServer,Stop-Function
ErrorDetails          : The property 'ActiveDirectoryTenant' cannot be found on this object. Verify that the property exists and can be set.
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at Stop-Function, C:\windows\system32\WindowsPowerShell\v1.0\Modules\dbatools\allcommands.ps1: line 79739
                        at Add-DbaRegServer<Process>, C:\windows\system32\WindowsPowerShell\v1.0\Modules\dbatools\allcommands.ps1: line 848
                        at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {0, 1}

Steps to Reproduce
#Run the following powershell commands
Add-DbaRegServerGroup -SqlInstance 'MyMachine,myport' -Group IderaMonitoredInstances -Name IderaMonitoredInstances -Description "CMS designed to allow you to run commands on all idera monitored instances."
Connect-DbaInstance   -SqlInstance 'MyMachine,myport'  | Add-DbaRegServer -Group IderaMonitoredInstances -ServerName 'MyMachine,myport' -Name IderaMonitoredInstances -Description "CMS designed to allow you to run commands on all idera monitored instances."

Expected Behavior
I expected it to add a server to the reg server group.
Actual Behavior
VERBOSE: [14:57:41][Get-DbaRegServerGroup] Processing IderaMonitoredInstances
VERBOSE: [14:57:41][Get-DbaRegServerGroup] Added IderaMonitoredInstances
VERBOSE: [14:57:41][Add-DbaRegServer] ID: 8)
WARNING: [14:57:41][Add-DbaRegServer] Failed to add MyMachine,myport on  | The property 'ActiveDirectoryTenant' cannot be found on this object. Verify that the property exists and can be set.

I get a completely different error. Can you update to the latest version of the module (1.0.64) and see if you get the following as well?
[18] pwsh [6.2.3] > Connect-DbaInstance -SqlInstance 'localhost\sql17'  | Add-DbaRegServer -Group IderaMonitoredInstance
s -ServerName 'dba1' -Name IderaMonitoredInstances -Description "CMS designed to allow you to run commands on all idera
monitored instances." -Verbose
VERBOSE: [17:24:18][Add-DbaRegServer] Parsing local
VERBOSE: [17:24:18][Add-DbaRegServer] String group provided
VERBOSE: [17:24:18][Get-DbaRegServerGroup] Processing IderaMonitoredInstances
VERBOSE: [17:24:18][Get-DbaRegServerGroup] Added IderaMonitoredInstances
VERBOSE: [17:24:18][Add-DbaRegServer] ID: )
VERBOSE: Performing the operation "Adding IderaMonitoredInstances" on target "Local Registered Servers".
WARNING: [17:24:18][Add-DbaRegServer] Failed to add dba1 on Local Registered Servers | Format of the initialization stri
ng does not conform to specification starting at index 0.

The test fails with the same error that I get above as well.

Ah disregard those last two...forgot I was in PS and not Windows PS. In Windows PS 5.1 I get a different result, but not the expected behavior.
Add-DbaRegServerGroup never adds the group on my local instance.
[16] PS [5.1.18362.145] > Connect-DbaInstance -SqlInstance 'localhost,1411' -SqlCredential $containerCred  | Add-DbaRegS
erver -Group IderaMonitoredInstances -ServerName 'dba1' -Name IderaMonitoredInstances -Description "CMS designed to allo
w you to run commands on all ideramonitored instances." -Verbose
VERBOSE: [17:35:09][Add-DbaRegServer] Parsing local
VERBOSE: [17:35:09][Add-DbaRegServer] String group provided
VERBOSE: [17:35:09][Get-DbaRegServerGroup] Processing IderaMonitoredInstances
VERBOSE: [17:35:09][Add-DbaRegServer] String group provided
VERBOSE: [17:35:09][Get-DbaRegServerGroup] Added all root server groups
VERBOSE: [17:35:09][Get-DbaRegServerGroup] Filtering for id 1. Id 1 = default.
VERBOSE: [17:35:09][Get-DbaRegServerGroup] Processing IderaMonitoredInstances
VERBOSE: [17:35:09][Get-DbaRegServerGroup] Added IderaMonitoredInstances
VERBOSE: [17:35:09][Add-DbaRegServer] ID: )
VERBOSE: Performing the operation "Adding IderaMonitoredInstances" on target "Local Registered Servers".
VERBOSE: [17:35:09][Get-DbaRegServer] Filtering by name for IderaMonitoredInstances
VERBOSE: [17:35:09][Get-DbaRegServer] Filtering by servername for dba1

The above shows it ran but nothing is ever added, nor does it error.

Interesting.  I upgraded to 1.60 of dbatools and got "Format of the initialization stri
ng does not conform to specification starting at index 0."
Then I upgraded to 1.64 and I still got "Format of the initialization stri
ng does not conform to specification starting at index 0."
Then I looked at the code for that function... I don't think there has been a change since 1.09.
Did you check in SSMS to see if that server was added to the CMS?

I was talking with WSMelton over at slack and he asked that I include some more details I figured out.
Keith Ramsey 9:50 AM
Something is odd about that regserver stuff.  I think there are is pre-req or something that I don't fully understand.
So I tried things on a newer machine that didn't have SQL Server on it as a service
wouldn't run.
So I downloaded the SQLSERVER module from powershell gallery, it worked
It did NOT have the sqlps module present either
then, I tried putting the SQLSERVER module on a different machine, and it wouldn't work again.
But that machine has older versions of SSMS on it, and 18.3, and sqlps.
make sense?
wsmelton 10:19 AM
Wouldn't work meaning it erred?
Keith Ramsey 10:32 AM
yeah
new messages
wsmelton 10:52 AM
Installed the sqlserver module but didn't import?
Keith Ramsey 10:57 AM
I just put the module in place, then imported it.
then that machine I mentioned, which only had SSMS, worked
So I'm guessing if you had a BLANK machine, with nothing but dbatools and the SQLSERVER module, the commands would work
wsmelton 11:08 AM
Well that likely means we are missing a dependent dll. At least first guess.
If you can add those details to the issue I'll get Chrissy to check.


Feature/update docs

scrutinizer still fails, moving to code climate probably

scrutinizer still fails, moving to code climate probably


Using It with RxJava2

How to use it with rxjava2?

Use the interop library or wait until #281 is done.

thanks for the quick response


Feature/export adjustments

WIP export toolbar (third and fourth items in #45).

Closing in favor of #59.


Up to 100 Instances?

According from the document, single App Service can hold up to 100 instances.
However, the subscription limit and quota document says, ASE can have up to 50 for Per App Service.
Is I'm comparing different things??
Dedicated-environment
https://docs.microsoft.com/en-us/azure/app-service/environment/intro#dedicated-environment
An ASE is dedicated exclusively to a single subscription and can host 100 App Service Plan instances. The range can span 100 instances in a single App Service plan to 100 single-instance App Service plans, and everything in between.
App Service Limits
https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#app-service-limits
Scale-Out (max instances)	1 shared	1 shared	3 dedicated3	10 dedicated3	20 dedicated (50 in ASE)3,4

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af931817-c3c8-6376-d2c2-a10795161d04
Version Independent ID: d2b59e0c-0c35-a335-b523-64f4d6f29d09
Content: Introduction to Azure App Service Environments
Content Source: articles/app-service/environment/intro.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

Actually....... please close this, I just got answer!

@KeiroKamioka0000
We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


refactor: capitalize locales when creating i18n config

Motivation
Locale labels must be initially uppercased, because it is currently renders as lower-cased for active item in dropdown.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Before
After

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Why not just add style={{textTransform: 'capitalize'}} to the dropdown label? Would there be any other concerns?

Yes, we can do that, but then we will have two style attributes with the same purpose. So isn't it better to normalize a locale label and just use it without any CSS?


Making Webview localstorage persistant after app closed

Hi.
I'm using this module in an Cordova project and it works on the browser...
But on the Android App when I close the app it loses all the information stored on the localstorage....
I've noticed that the "ngStorage" module does not do that... But I want to use this one....
Can you fix this problem or tell me what I need to change?

I haven't noticed or heard of this issue until now. I am not sure what is
causing it.
Can you create an Issue on Github so someone can look into it?
Thanks.
Greg
On Mon, Mar 16, 2015 at 4:56 PM, Rodrigo Graça<EMAIL_ADDRESS>wrote:

Hi.
I'm using this module in an Cordova project and it works on the browser...
But on the Android App when I close the app it loses all the information
stored on the localstorage....
I've noticed that the "ngStorage https://github.com/gsklee/ngStorage"
module does not do that... But I want to use this one....
Can you fix this problem or tell me what I need to change?
—
Reply to this email directly or view it on GitHub
https://github.com/grevory/angular-local-storage/issues/202.

Hi @grevory this is an issue on Github....
You are replying from your email and got confused right...?

Yes. Thought this came in as a personal message. Not sure why. I clearly did not read it well.

I guess this is a problem with this particular module...
As I said before it works with another one...
And now I discovered that making it "by hand" also works: http://learn.ionicframework.com/formulas/localstorage/ (first code block)


⚠ 한경주요지수-코스피200 has degraded performance

In 7d57448, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 5519 ms

Resolved: 신규상장 performance has improved in c82f8b3.


Can cancel the menu button on NavigationAppBar in PaneDisplayMode.minimal?

I want the navigation bar to display only text, but I can't find a way to cancel the menu button.
In previous updates, fluent has been able to programmatically open menus in the minimal state.
Therefore, adding this method does not cause the menu to fail to open.

Sorry, I don't get it! Could you explain it better?

Like this, I customized a navigation bar on the child page, but the parent navigation bar added a menu button that could not be deleted

parent navigation bar↑

Sorry, I don't get it! Could you explain it better?

If I delete the parent navigation bar, the entire navigation will overlap with the status bar, so is there any way to delete the menu button? thank you very much!

This button seems to be generated only in the PaneDisplayMode.minimal state


build: fix building on non-English locales

depsgen works on file lists and globs, consuming stat output
to calculate dependencies. This commit adds an explicit C locale
setting to avoid build failures on non-English locales.

lgtm on green

LGTM.
All green ;)

All green, self-merged.


Cannot create a collector using set_datum property.

Hi, I am experiencing an issue when creating a collector like this:
from pyoos.collectors.coops.coops_sos import CoopsSos

collector = CoopsSos()
sos_name = 'water_surface_height_above_reference_datum'

datum = 'NAVD'
collector.set_datum(datum)
collector.end_time = stop
collector.start_time = start
collector.variables = [sos_name]
response = collector.raw(responseFormat="text/csv")

With OWSLib version > 0.8.9 I get got an unexpected keyword 'result', but it works nicely with OWSLib <= 0.8.9.  The only change I see that could be the culprit is the passing of the keyword argument to openURL (that is absent in previous versions):
response = openURL(base_url, data, method, username=self.username, password=self.password, **kwargs).read()

I'm not familiar with pyoos but I'm guessing @kwilcox is. I'm also guessing this is somehow related to https://github.com/geopython/OWSLib/commit/bfff06eb45a5773428aa516752fa6801c94a1f57.
@lukecampbell any idea?

Forgot to mentioned that I am using pyoos 0.6.2.

Wow, I somehow missed this.


Improving pointer behavior in SelectingItemsControls

Currently, Avalonia's pointer behavior in SelectingItemsControls differs from other UI frameworks. In Avalonia, selecting an item (in a ComboBox/ListBox/TabControl/Menu) is all done on PointerPressed. In addition we also allow selection using the right mouse button. In other frameworks (all of Windows (Win32 and Xaml), Qt, gnome on linux for alternate OS comparison) invokes or selects with only the left mouse button and on pointer up. The only exception to this rule is top level menu items in a MenuBar (Windows HMENU or Qt menubar, for example) where the dropdown opens on pointer down. The menu items in the drop down though still invoke on pointer up.
We also don't clear the ":pressed" state if the pointer is pressed but dragged outside the bounds of the item.
Advantages to using only left button and pointer up:

You can cancel an accidental pointer/mouse press - just drag the mouse outside the bounds of the item and release and the capture releases, but the item itself doesn't select/invoke
Not handling right mouse means the item won't get selected if a ContextMenu/Flyout is opened on the item. (Add one to a ListBoxItem and you'll see the ListBoxItem get selected before the menu opens)
The current behavior renders the :pressed pseudoclass less important since the pointer-triggered action has already happened, but the pressed visual state indicates you're about to do something to this item

I don't think this is too big of a change to actually implement. It will break the current behavior, but it will align it with other UI frameworks and what I think others would expect. Two things to consider with the change though: pointer up should only invoke/select the captured control (moving to another item and releasing should not select that item). And, MenuItem will need to adapt whether its toplevel or actually in a menu - this might be the more complicated bit?
With the other items control related changes going on, this might be a good time to adjust this - though it is of different scope to that PR.

Yep, there are various problem with out selection logic, mainly caused by the fact that selection follows focus, which is incorrect. I hope to address this some time soon, though if you want to help out let me know and I can discuss my (vague) plans with you ;)


Feature: MySQL - Seed Database

Has the ability to import a seed database into MySQL

[x] WHEN I enter schema and seed commands
[x] THEN a development database is created and is seeded with test data

Verified this is setup and working.


Site name missing in email to user  for new site

When a new site is published<EMAIL_ADDRESS>and possibly the site owner get an email confirming publication. Currently the email just says the site was published but doesn't give the name.
Is it possible to put the site name in the subject line and the body of the email?

wp-resources/plugins/webonary-create-site/webonary-create-site.php

We tested this on webonary.work and didn't see a change in the email. The message says it has been published on webonary.org is this just static text in the email?

This is now working.


Make ArrayValueConverterMap an ItemConverter

To simplify things before the 1.0 release.

Is this still valid? (Now, that steps are merged)

Nope, there is now a MappingStep.


Duplicate user creation should return error

We currently log an error when a user tries to create an account at
https://github.com/freeCodeCamp/open-api/blob/staging/src/dataLayer/mongo/user.js#L61
I believe we should thrown an error instead. This message has more use to the client than our logs.

PR is good to go, just needs a rebase and resolving of conflicts.


laravel 5.4 it's usable or not

laravel 5.4 it's usable or not

Too old code but good one. Few modifications are required to make compatible with Laravel 5.4

https://github.com/baklysystems/laravel-shop
This is fork to make support for Laravel 5.4


Unable to connect

If this mod is installed, no player can connect to my lobby.

@mrakrmakmrka Can you please send your modpack code and BepInEx LogOutput.log file?

@ZehsTeam my modpack code: 018ed052-2707-2f30-18da-105d875d6628
logout.txt

@mrakrmakmrka I forgot to ask, are you playing on v49 or the v50 public beta?

@ZehsTeam I'm playing on version 49.

@mrakrmakmrka I tested your modpack with my mod on version 49 and had no issues with other clients connecting to my lobby. Unless you have logs with errors from my mod stopping other clients from connecting to your lobby, it's not my mod causing the issue.

@ZehsTeam I tried to play only with your mod, no one can join me. i installed a new profile, reinstalled mod manager, still no one can join....
It keeps writing this in the table:
[Warning: Unity Log] [Netcode] NetworkConfig mismatch. The configuration between the server and client does not match
[Info :LobbyControl] 2 disconnected
[Info : Unity Log] Disconnect callback called
[Info : Unity Log] Is server: True; ishost: True; isConnectedClient: True
[Info : Unity Log] Disconnect callback called in gamenetworkmanager; disconnecting clientId: 2
[Info : Unity Log] A Player disconnected but they were not in clientplayerlist
The mod is good, but it doesn't work for me, I have to delete it.
Translated with DeepL.com (free version)

@mrakrmakmrka This mod is for all clients. My mod has networking and special events, so ALL players must have it installed!


This script should be moved to TheAlgorithms/.github

If this script is to be used by multiple language repos then it should be moved to https://github.com/TheAlgorithms/.github

@maltejur?

From my understanding the .github repository contains the default files for a new repository. But the script in this repository shouldn't just be placed into a new repository, it has to be integrated manually via a workflow.
But since the website doesn't require the directory.md anymore, I think the more important question is if all of the repositories still even need those files or this script. I don't think any repository actually directly uses this repository, so maybe we should just delete it.

For Python, I would like to keep directory.md because many people come to the code via GitHub, not via the website.


using retinaface.extract on multiple images

Currently i am using retinaface.extract in a for loop.
Is there a faster way to run this where like we can give it an array of images and it does batch processing?

this is not covered


Feature Request: Optional Overlay

I would like to be able to have an overlay cover the remaining screen portion when the aside opens.  When the aside closes, then the overlay should also disappear.  Is this feature request something that seems doable?  Does it already exist and I'm just unaware?  Would I be able to fork this repository and attempt to create this functionality?  Thanks!

Hi @harbhub,
Aside is a modal instance, so there is already a backdrop (assuming you mean it by overlay). In demo plank please notice the backdrop: false option. It's true on default.


issue with unicode variable names

Hi,
I'm making a javascript renamer. When testing it on underscore's code, I found that whenever I rename variables into unicode, the test suite would fail.
For example, if you put this line anywhere in underscore.js, the test suite will fail with messages like "... is not defined".
var ☺ = 0;
The variable is never used, so ideally the test suite should pass as usual. I wonder if the test framework is not handling unicode properly. I appreciate any ideas regarding this. Thanks.

A unicode smiley face is not a valid variable name.

Oh I made a bad example. Indeed smily is not valid, but try another one which is valid and the same problem will happen:
var ꎂ=1;
Other libraries like backbone's test suite will pass, and it's using the same version of qunit. So I wonder what's special in underscore.

It's due to the linter:
var ꎂ= 1;

(function() {

  var ꎂ= 1;

  // Baseline setup
  // --------------

  // Establish the root object, `window` in the browser, or `exports` on the server.
  var root = this;

///...

$ npm test
// snip...
><EMAIL_ADDRESS>lint /Users/jridgewell/src/underscore
> eslint underscore.js test/*.js

underscore.js
     6:4   error    Infix operators must be spaced                                   space-infix-ops
    10:6   error    Infix operators must be spaced                                   space-infix-ops
// snip...
    10:6   error    ꎂ is defined but never used                                      no-unused-vars

But if you change the variable name to some unused ascii name, the tests will pass...

Even an ASCII name will fail:
><EMAIL_ADDRESS>lint /Users/jridgewell/src/underscore
> eslint underscore.js test/*.js

underscore.js
//snip...
    10:6   error    unused is defined but never used                                 no-unused-vars

On another note, Backbone should probably be linted - the jsl script isn't being run by travis

@michaelficarra: mind closing this time?

Yes can be closed.
I ran the test suite in an incorrect way (I just loaded test/index.html into browser). If I run it using
npm run test-browser
the tests will pass even with unicode names. Thanks.


Add Haskell-specific cycle pairs

Using either vim-cycle or vim-cycle.
Remember to mention the dependency in the README.

Closed because of #9.


IconButton is using color fg.default instead of fg.muted

Description
Throughout GitHub I suddenly noticed that all our IconButton components use a fg.default instead of fg.muted. This creates inconsistencies with high surfacing areas like the global navigation or UnderlineNav where the icons are always muted. It also doesn't match the previews in our documentation.
For context our icons inside a normal button are also fg.muted.

Steps to reproduce
Visit our storybook
Version
Latest
Browser
Safari

@maximedegreve just wanted to confirm, are you also seeing this behavior in PVC, as well? Was taking a look over at: https://view-components-storybook.eastus.cloudapp.azure.com/view-components/lookbook/inspect/primer/beta/icon_button/default and it seems like it may also have the same issue but wanted to confirm first.


NPM package release

this package on npm still 1.0.0, When will you release 1.0.2 on npm ?

ping @roadmanfong

ping


ValidationModeNone?

Thanks for this great project!
I have a scenario where I really don't care if validation fails during a split command, and I've found that the split command succeeds even when validation has failed in relaxed mode. While I believe it's ultimately beneficial to continue to improve validation, I was hoping you would consider this suggestion for those of us who would rather rely on a failure to split or extract than a failure to validate.
For example, would it be possible to add a third validation mode, something like ValidationModeNone, that would cause certain commands to bypass the validation stage altogether? The Split() function calls readValidateAndOptimize(), which then calls readAndValidate(). With a new validation mode, maybe it results in a call to a new function readAndOptimize(), combining ReadContextFromFile() and OptimizeContext() while avoiding validation.

This is something to consider also because of the performance impact of validation.


Fix for #48

I removed the resource files

I apologize for the confusion. You shouldn't need to make any changes to the assets or resources folders. It may be easier for you to refork so that all the resources are in their proper locations/

Already merged


Table

This should not be the appropriate place for this question, but you do not find it more appropriate. Caniuse.com displays the data in a table. Is this table a plugin? How can you display a similar table in another project?

While not exactly the same, I recommend the third party CanIUse Embed (
https://caniuse.bitsofco.de ) for that purpose.

Ah, I see. The tables you see are custom coded specifically for caniuse data so unfortunately not really portable to use for other purposes. Using the DOM inspector from a borwser's dev tools may help a bit.


[HackaDoc] Add missing reference to HBase SDK NuGet

Second part of the article misses reference to HBase SDK NuGet. The reference to proto-buf is removed as it is no longer needed - hbase sdk pulls it in automatically.

Hi @maxluk, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (maxluk). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


undefined method `workflow' for class

Hi, I'm getting an undefined method error just trying to mount the module on a basic application. I'm able to reproduce it on this repo as well. I'm aware the tests pass for Ruby 2.6 and Rails 5, and I am perplexed as to why. Maybe it's something on my machine.
Steps to reproduce
Start a console from this projects root
irb -I./lib -r workflow_activerecord -r active_record

Create a model:
class TestIssue < ActiveRecord::Base
  include WorkflowActiverecord
end

It blows up with:
8: from (irb):2:in `include'
7: from /workflow-activerecord/lib/workflow_activerecord.rb:9:in `included'
6: from /workflow-activerecord/lib/workflow_activerecord.rb:9:in `include'
5: from /workflow-activerecord/lib/workflow_activerecord/adapters/active_record.rb:6:in `included'
4: from /workflow-activerecord/lib/workflow_activerecord/adapters/active_record.rb:6:in `extend'
3: from /workflow-activerecord/lib/workflow_activerecord/adapters/active_record.rb:47:in `extended'
2: from /workflow-activerecord/lib/workflow_activerecord/adapters/active_record.rb:48:in `singleton class'
1: from /workflow-activerecord/lib/workflow_activerecord/adapters/active_record.rb:48:in `alias_method'
NameError (undefined method `workflow' for class `#<Class: TestIssue (call 'TestIssue.connection' to establish a connection)>')

Note: I can run the tests locally and they pass fine. But I can't actually use it. Same error results when including this gem in my project. This isn't blocking me, as I can use the Workflow 2.0 gem, cause I don't use scopes and can define the interface methods this gem provides on my model directly. Wanted to share anyway in case it helps.

If I do the "Steps to reproduce", I get the same message. Once I add -r workflow the error does not appear anymore. Will prepare a fix...

Fixed in 4.1.5

Confimed the issue is fixed. Thanks 👍


Split the build into a multi-project plugins build

This pull request refactors the build, so that instead of consisting of a single plugin project, it's now a multi-project, multi-plugin build.
There are now those major plugin subprojects:

minimal-plugin, consisting of the io.micronaut.minimal.xxx plugins
docker-plugin, which adds support for building Docker images via Ben Mushko's docker plugin
graalvm-plugin, which adds support for building native images on applications or libraries via the official GraalVM native build tools
aot-plugin, which adds support for Micronaut AOT, and depends on the above plugins
gradle-plugin, which is the "legacy" micronaut-gradle-plugin and depend on all of the above

For a user of the micronaut-gradle-plugin, there should be no difference since the plugin has the same functionality and lives at the same coordinates.
However, this refactor highlighted that the previous implementation was faulty in terms of leaking plugin dependencies. In particular, it didn't matter if you were using the shadow plugin or not, if you were using the kotlin plugin or not, those were added to the build script classpath. This isn't the case anymore (which is also a reason for this change), making each plugin's classpath cleaner.
Part of the problem was that testing was faulty: the optional plugins were systematically added to the plugin under test classpath. This meant that we couldn't properly test the behavior if one of those plugins wasn't on the plugin classpath.
To fix this, testing is now using a more complex setup:

each plugin has its own tests, when possible. The "possible" only depends on whether it's enough to apply this plugin, and only this plugin
if a test requires an optional plugin (say the shadow plugin or the kotlin plugin), or if a test requires another Micronaut plugin (say the graalvm plugin), then the tests need to be moved to the functional-tests project.

This test project is designed so that tests are executed with "clean" plugin classpath: instead of relying on TestKit to inject the plugin classpath, the tests use a real, build local Maven repository. Therefore, each build under test is going to resolve their plugins from that repository.
Unfortunately, the setup to publish to that "build local" repository as a task input is a bit nasty, because publishing is never up-to-date with Gradle. A workaround is implemented but is quite fragile.
Regarding the shuffling of plugins into their own subprojects, it now means that the plugin publishing will publish several plugins at once. Some of those plugins used to live into the micronaut-gradle-plugin jar, but will now live in their own GAV coordinates. @ljacomet I would appreciate if you could tell me if you think this is going to cause troubles, at least for a first publication of this new setup: we will have plugins which use the same ids as before, but will be published in different GAV coordinates. Will it be a problem for validation?

The publication with the same plugin ID but using different GAV coordinates for the plugin JAR will effectively trigger a manual validation step on the plugin portal.
You could reach out right before making that first release so it gets approved in a timely fashion, although we now are much better on that front 😉

Right, that's what I feared. Since we release from CI, this may be tricky if there's an approval error. Do you see anything obvious that I could be missing, to reduce the risks?


Ortho: replace cluster graph with gene tree

Mockups here
Focus is on the list of proteins, pfam architecture and cluster graph sections of the group page. We mean to condense the list of proteins and architecture tables into one. This new table should have the ability to add new columns and drag to reorder existing columns. The first column by default should be the architecture, and the second check boxes to highlight the accompanying tree viz. It should also have aligned on its left edge a tree viz built using tidy tree. Tidy tree will support nearly all our needs out the box except highlighting edges and guaranteed equally spaced leaves for the dendrogram view. @asizemore is scoping out adding these features to tidy tree.

Input to the tree is a newick file, provided by datadev. Contact stuart for details there.

probably someone else will take it once we have the component where we need it to be to support ortho and mbio needs.

here is a hopefully clearer/ more comprehensive list of needs for the ortho group page, based on the linked mockups:

remove the cluster graph
combine the contents of the ‘list of proteins’ and ‘pfam domains’ sections into a single section. UX can decide what to call it later.
The new section starts w the Pfam Legend table from the ‘pfam domains’ section, which now needs a column of check boxes as well.
this is followed by the ‘list of all proteins’ table from the ‘list of proteins’ section. The list of all proteins needs to have a tree aligned to its left side, using the TidyTree lib.
the proteins tree+table needs to be searchable, which will remove rows from the table and leaves from the tree.
if someone sorts by a column in the table, the tree is grayed out w some explanatory message and ideally a means to get the tree back.
if someone checks one or more boxes in the pfam legend table, associated protein table rows/ tree leaves are highlighted
the protein table should have a column of check boxes as well, for custom highlighting. there should be a means (maybe a checkbox in the column header) to highlight all currently visible tree nodes/ rows. this should allow someone to search the tree+table to only interesting nodes, highlight them, then remove the search term.
ideally, the tree+table should have the ability to add new columns and drag to reorder existing columns
first column of the tree+table by default should be the pfam architecture

Ill also say that i have a fork here of the TidyTree lib which has the additional features we need. the cdc has been open to merging these changes, but has not (yet) approved all of them.


Documentation bugs fixed

Description:
The documentation has been updated by removing  the grammatical errors and understanding issues of the npm through the documentation.
Fixes #10

Type of change:

[x] This is a documentation update

Checklist:

[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Update the details of terminal option in readme


remove results from status when type mismatched and add more logs

Changes
This commit fixes https://github.com/tektoncd/pipeline/issues/6023. Before this commit we only log the result name
and needed types, but omit the want types and the invalid results are in
status. This commit adds the want types in error message and remove
invalid results from status
/kind bug
Signed-off-by: Yongxuan Zhang<EMAIL_ADDRESS>
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
taskrun results which have type mismatched are removed from taskrun status

/hold
need to fix result in status as well

/hold cancel

/retest

/retest

/lgtm