Floating toolbar

Description
Added the floating toolbar component
References #1420
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
I've added the component to the index.html using its HTML tag.
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Heya @sorina-ocheana - is your PR finished and ready for review from your side? If so can you please resolve the conflicts? We are aiming to ship a release tomorrow (Thursday 21) so if your PR is finished, reviewed and merged in time it can go in the last release of the year!

 I see that it'll apply fixes on 2 of the toolbar files.  You may ignore the other lint issues, those need addressed outside this PR.

thanks for your work on this @sorina-ocheana - we have a (floating) Toolbar component added now!
https://modus-web-components.trimble.com/?path=/story/components-toolbar--default


Consider changing the 'purpose' to device identifier

Hi,
Currently the method ValidateAsync from the IUserTwoFactorTokenProvider<TUser> contains a parameter called 'purpose' which is always equals to 'TwoFactory' if the default method in UserManager is not overridden.
This is because the default implementation inside the Microsoft.AspNetCore.Identity.UserManager<TUser>
of the method VerifyTwoFactorTokenAsync(TUser user,string tokenProvider, token)
looks that:
var result = await _tokenProviders[tokenProvider].ValidateAsync("TwoFactor", token, this, user);
So this 'purpose' parameter seems to be pretty useless right now. However it could be replaced by some kind of device identifier so it would be easier to store multiple devices for the same TokenProvider (so the single user could have 2 devices for the same token provider).
Please let me know what you think.

We have no plans to add support for multiple devices which have different tokens.


Add note about newline handling

I added a note about new-line handling. Maybe its a bug that I should be reporting elsewhere?
class ExampleClass:
    """This class is broken because of \n

    Example:
    ```python
    msg = "There should be a newline char at the end of this example\n"
    print(msg)
    ```
    """
    pass

produces this:

Escaping the "\n" with an additional "" produces:

my mkdocs.yaml:
markdown_extensions:
    - admonition
    - codehilite
    - pymdownx.superfences

plugins:
- search
- mkdocstrings:
    handlers:
      python:
        options:
          docstring_style: "google"

I’ll check when I have a second if it still breaks if you do a raw docstring, eg r”””
For example pydoctor says:

Since docstrings are Python strings, escape sequences such as \n will be parsed as if the corresponding character—for example a newline—occurred at the position of the escape sequence in the source code.

To have the text \n in a docstring at runtime and in the generated documentation, you either have escape it twice in the source: \n or use the r prefix for a raw string literal. The following example shows the raw string approach:

def iter_lines(stream):
r"""Iterate through the lines in the given text stream,
with newline characters (\n) removed.
"""
for line in stream:
yield line.rstrip('\n')

I like your edit. I tested r""", and it works as well, so I added that to the comment

thank you!


copy rtf error：Unhandled Promise Rejection: No string found

When copying content from Word, an error message will appear if the content contains headings

+1

I will take a look today

What is your environment? I tried word on mac and it works fine. Are you using Windows?


Validation message is showing while creating catalog rules

#7442

@gitesh-webkul
Fix the same for the cart rule as well.

@gitesh-webkul
Still getting the same issue while trying to edit the cart rule.


Calling client.start() many times leaks websocket connections

plugins/websocket/lib/Socket.js
const sock = this.socket = new WebSocket(url, ['xmpp'])

will overwrite and leak WebSocket connection when calling start on an already started client connection.

I propose start resolves if the entity is already online.

+1

and stop resolves if entity is already offline/stopping/closing/...

@smokku or we could cache the initial start/stop promise and return that
What do you think?

hmm actually I'm thinking throwing would probably better, there's no reason to call start twice

How would .catch() determine whether the connection actually failed or it is fine but already connected?
smk
On Tue, Jun 6, 2017 at 3:28 PM +0200, "Sonny Piers"<EMAIL_ADDRESS>wrote:
hmm actually I'm thinking throwing would probably better, there's no reason to call start twice
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thinking of it... Resolving is not correct, as we cannot guarantee that the client is connected to the server user intended. And even if we compare the URLs, then we cannot guarantee that the JID/resource is the intended one.
If the application is willing to work with already started connection, it is up to the application code to decide how to handle it.

@smokku agree plus the reconnect plugin is supposed to handle everything for the user so there's definitely no reasons to call start twice.
What about stop() ? On one hand I feel like it should be consistent with start on the other, you might wanna call stop any time even if you're not already connect without throwing.
Thoughts?

I think .stop() should be safe escape hatch. No matter the connection state it should just shut it down. It should be safe to call .stop() in every error handler, catch, etc. Just call stop() to be safe and try to recover.

https://github.com/node-xmpp/node-xmpp/pull/428


Speedup thefuck --alias

Some users complain that thefuck --alias call increases shell startup time.

Related:

https://github.com/pypa/setuptools/issues/926
https://github.com/ninjaaron/fast-entry_points

Before:
thefuck --alias  0,29s user 0,01s system 99% cpu 0,303 total

After:
thefuck --alias  0,13s user 0,02s system 99% cpu 0,149 total


remove pandas-related FutureWarning

Issue #, if available: #87
Description of changes: addressed pandas complaints.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-88/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-88/1/index.html

Job PR-88/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-88/2/index.html

Codecov Report

Merging #88 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   78.63%   78.64%   +<.01%
==========================================
  Files         110      110
  Lines        6282     6283       +1
==========================================
+ Hits         4940     4941       +1
  Misses       1342     1342

Impacted Files
Coverage Δ

src/gluonts/dataset/artificial/_base.py
32.16% <ø> (ø)
:arrow_up:

src/gluonts/evaluation/_base.py
99.38% <100%> (ø)
:arrow_up:

src/gluonts/model/seasonal_naive/_predictor.py
96.66% <100%> (ø)
:arrow_up:

src/gluonts/evaluation/backtest.py
87.5% <100%> (ø)
:arrow_up:

Is this fix already installable via pip install --upgrade gluonts? I am running python 3.7.3 and I am still getting this issue when I am trying to train a feedforward model.

@rherbrich74 not yet, we will make a new release tomorrow probably. In the meantime you can
pip install git+https://github.com/awslabs/gluon-ts.git

@lostella: That worked - thanks! I have one more question on the semantics of make_evaluation_predictions and the parameter num_eval_samples: If I follow the tutorial, the first element of the forecasts array contains 100 sample paths and they are all around the target values:
forecasts[0].samples
array([[ 678.3231 ,  576.42914,  561.24054, ...,  800.3523 ,  901.3257 ,
916.05774],
[ 690.817  ,  593.2066 , 1075.1001 , ...,  852.2531 ,  808.0277 ,
665.4199 ],
[ 684.40814,  601.9213 ,  523.0439 , ...,  847.2773 ,  773.35095,
712.46436],
...,
[ 676.9368 ,  563.7203 ,  405.0648 , ...,  679.5283 ,  732.5705 ,
680.9393 ],
[ 655.64545,  642.0739 ,  524.64435, ...,  819.95447,  777.0701 ,
768.63086],
[ 741.4884 ,  668.1726 ,  518.23926, ...,  840.6607 ,  858.57776,
774.19196]], dtype=float32)
But the second element of this array is a factor of five too high:
forecasts[1].samples
array([[3119.2852, 2552.321 , 2850.9817, ..., 3502.2512, 3602.2888,
2993.7017],
[2985.6204, 2787.8015, 2402.0273, ..., 3434.465 , 2011.0767,
3282.1006],
[2831.7378, 2684.3398, 2630.1077, ..., 1831.2285, 3129.4214,
2915.8489],
...,
[2978.8643, 2787.955 , 2404.7107, ..., 3094.3599, 3225.1023,
3651.5989],
[2733.5464, 2616.9783, 2448.9888, ..., 3635.505 , 3800.9192,
3365.458 ],
[3255.8765, 2840.524 , 2388.526 , ..., 3959.009 , 3052.5603,
2729.477 ]], dtype=float32)
Also, I do not understand the logic of this parameter. The number of sample paths for the predictor are initialized in the constructor
estimator = SimpleFeedForwardEstimator(
num_hidden_dimensions=[10],
prediction_length=dataset.metadata.prediction_length,
context_length=100,
freq=dataset.metadata.time_granularity,
num_eval_samples=1000,
trainer=Trainer(ctx="cpu", epochs=5, learning_rate=1E-3, hybridize=True, num_batches_per_epoch=200,),
)
Can you help clarify?

@rherbrich74 sure:

The forecasts[1] I get looks OK to me. Are you comparing it to the corresponding time series? In the notebook, you should change

tss[0][-plot_length:].plot(ax=ax)  # plot the time series
forecasts[0].plot(prediction_intervals=prediction_intervals, color='g')

into
tss[1][-plot_length:].plot(ax=ax)  # plot the time series
forecasts[1].plot(prediction_intervals=prediction_intervals, color='g')

to do the right comparison.

I believe the num_eval_samples argument of make_evaluation_predictions is unused by some models (e.g. SimpleFeedForward, as you noticed) which have it hard-coded since their creation. But maybe other types of predictors (like the R-based one) allow customizing this at inference time. This is definitely a potentially confusing point, we'll think about how to streamline the API wrt this. Thanks for the feedback!

Thanks for the quick response, @lostella ! I still don't get the right output; this is what I see

I made the code publicly available at https://github.com/rherbrich74/gluon-ts-experiments/; maybe there is something obvious I am doing wrong.

That does look funny. Thanks for the sample.
FYI num_eval_samples should be fixed by #103


Pages section in vue.config.js results in returning index.html file for other files in public directory

Version
4.5.8
Reproduction link
https://github.com/zwik/vue-config-external
Environment info
Environment Info:

  System:
    OS: Windows 10 10.0.16299
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Binaries:
    Node: 12.16.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 86.0.4240.183
    Edge: Spartan (41.16299.1480.0)
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.2.1
    @vue/babel-helper-vue-transform-on:  1.0.0-rc.2
    @vue/babel-plugin-jsx:  1.0.0-rc.3
    @vue/babel-plugin-transform-vue-jsx:  1.2.1
    @vue/babel-preset-app:  4.5.8
    @vue/babel-preset-jsx:  1.2.4
    @vue/babel-sugar-composition-api-inject-h:  1.2.1
    @vue/babel-sugar-composition-api-render-instance:  1.2.4
    @vue/babel-sugar-functional-vue:  1.2.2
    @vue/babel-sugar-inject-h:  1.2.2
    @vue/babel-sugar-v-model:  1.2.3
    @vue/babel-sugar-v-on:  1.2.3
    @vue/cli-overlay:  4.5.8
    @vue/cli-plugin-babel: ~4.5.0 => 4.5.8
    @vue/cli-plugin-eslint: ~4.5.0 => 4.5.8
    @vue/cli-plugin-router:  4.5.8
    @vue/cli-plugin-vuex:  4.5.8
    @vue/cli-service: ~4.5.0 => 4.5.8
    @vue/cli-shared-utils:  4.5.8
    @vue/component-compiler-utils:  3.2.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^6.2.2 => 6.2.2
    vue: ^2.6.11 => 2.6.12
    vue-eslint-parser:  7.1.1
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.9.5 (16.0.0-beta.10)
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.11 => 2.6.12
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
npm install
npm run serve
open the browser and watch the output in the console. The test.js file should be ran and give the output this is now being executed but it doesn't. Because HTML is returned an Uncaught SyntaxError: Unexpected token '<' is being thrown because of unexpected HTML.
What is expected?
Console should output: this is now being executed. Important here is that the code is actually living in another directory, which is also configured is the vue.config.js file. When a default configuration is used, so no vue.config.js file and the code in the default location, it works.
What is actually happening?
Console outputs: Uncaught SyntaxError: Unexpected token '<'

CLI can only handle the public folder in the root directory. Maybe It's better import test.js in main.js?
├── public
│   ├── favicon.ico
│   └── test.js
└── vue.config.js

Or you can use yarn workspace/monorepo
├── package.json
├── packages
│   └── my-app
│       ├── package.json
│       ├── public
│       ├── src
│       └── vue.config.js
└── yarn.lock

That indeed does solve the issue. Why is that actually? Would it be nice to configure this as well?

Any static assets placed in the public folder will simply be copied to outputDir.  If you want to put some assets to  packages/someapp/, these assets look more like "private".  Public assets can be used by packages/app1, packages/app2, etc.  So, personally I think it is reasonable that the public folder is located in the root of the project.
For monorepo, you can organize the structure like this
├── package.json
├── packages
│   ├── app1
│   │   ├── package.json
│   │   ├── public
│   │   ├── src
│   │   └── vue.config.js
│   └── app2
│       ├── package.json
│       ├── public
│       ├── src
│       └── vue.config.js
└── yarn.lock

Issue resolved with the help of @fangbinwei .


goaccess: 1.8 -> 1.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/goaccess/versions.
meta.description for goaccess is: Real-time web log analyzer and interactive viewer that runs in a terminal in *nix systems
meta.homepage for goaccess is: https://goaccess.io
meta.changelog for goaccess is: https://github.com/allinurl/goaccess/raw/v1.8.1/ChangeLog
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.1 with grep in /nix/store/s9cmbiwv6957d0micmn88ignns5hwbq2-goaccess-1.8.1
found 1.8.1 in filename of file in /nix/store/s9cmbiwv6957d0micmn88ignns5hwbq2-goaccess-1.8.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
goaccess

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s9cmbiwv6957d0micmn88ignns5hwbq2-goaccess-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A goaccess https://github.com/r-ryantm/nixpkgs/archive/b9d1da32525e493c7005178fdd6ac9ac44b8b499.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b9d1da32525e493c7005178fdd6ac9ac44b8b499#goaccess

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s9cmbiwv6957d0micmn88ignns5hwbq2-goaccess-1.8.1
ls -la /nix/store/s9cmbiwv6957d0micmn88ignns5hwbq2-goaccess-1.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

goaccess

Maintainer pings
cc @ederoyd46 for testing.

Result of nixpkgs-review pr 265179 run on aarch64-darwin 1

1 package built:

goaccess


Incorrect result count reported to webhook

Describe the bug
When a spider completes and a webhook is triggered, the result_count property is 0 instead of the actual number of results.
To Reproduce
Steps to reproduce the behavior:

Create a new spider
Add a web hook for the spider
Run the spider

Expected Behavior
The result count reported on the user interface should match the result count reported to the webhook.
Notes

The crawler was a short running job that produced 6 results in 2 seconds.
Tried with latest master and 0.5.1 release

It could be a short task issue. But will double check. Thanks for the bug report.


Integrate with websocket mod

Use streams from https://github.com/KK964/SynthRiders-Websockets-Mod to provide life pct updates on each note hit/miss, instead of periodically. Or, use the play time event to poll for life pct (see if it can be done at the expected frequency, or if it'd need to be more often)

Integration done with #21


feat: get the underlying gocql session

When using third party libraries, like go-migrate, we need to access the underlying gocql session. Added the method to access the gocql.Session

Thank you for the contribution!


Hotkey remapping isn't working

The remapping function doesn't seem to work for me, even with the setting "Use modified hotkeys" is enabled.
My keymap.json looks like this:
{
    "W": "Z",
    "A": "Q",
    "S": "S",
    "D": "D",
    "Z": "W",
    "X": "X",
	"C": "C",
	"G": "G",
	"E": "E",
	"N": "N"
}

I use an azerty keyboard, so being able to remap would be great!
Thanks in advance.

Oh yeah you're right, this got broken with the recent update. I fixed this real quick; there may have been a little too much find + replacing with the latest update heh

Bad news: from the rebinding I have done, the "A" key isn't working, rebinding it to something else just disable the key entirely, the original and new one stop working.
It works for the other keys, although I haven't tried the ones I didn't originally rebind.


Mobile toggle not working - vannila js

Hi, please, can somebody help me with mobile menu on clone not working.
const menu = document.querySelector('.mmenu');

menu.addEventListener('click', () => {
      menu.classList.toggle('change');
});

Thanks

Please include a reproducible example (and the classname has a different name)

Please include a reproducible example (and the classname has a different name)

Hi, here is example of my code: https://jsfiddle.net/9cyz24tb/
Works good, but when headhesive.js make clone, menu clone not working.

Hi, here is example of my code: https://jsfiddle.net/9cyz24tb/
Works good, but when headhesive.js make clone, menu clone not working.


Add known issue for Redis Worker Scaling property

[#168005525]
Signed-off-by: Glenn Oppegard<EMAIL_ADDRESS>

Thank you, @oppegard. Made slight changes and approved.

@kbakas it will be fixed in HW 1.6.3, which wasn't ready for release when this PR was created a month ago. Should I update this PR to reference 1.6.3?

Yes please

On Sep 19, 2019, at 16:50, Glenn Oppegard<EMAIL_ADDRESS>wrote:
@kbakas it will be fixed in HW 1.6.3, which wasn't ready for release when this PR was created a month ago. Should I update this PR to reference 1.6.3?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@kbakas, Glenn and I have updated this PR to mention that the issue is fixed in HW 1.6.3+.

@JacobLNewton Would you merge if it looks good to you


Sc336/api documentation refresh

PR type: doc improvement
Related issue(s)/PRs: Contributes to #1823
Summary
A few comments were in places that meant they weren't getting picked up by Sphinx.  A few others were unclear enough I had to ask for some help in understanding them; I've updated these to make them more clear.
Fully backwards compatible: yes
PR checklist

[ ] New features: code is well-documented

[x] detailed docstrings (API documentation)
[ ] notebook examples (usage demonstration)

[ ] The bug case / new feature is covered by unit tests
[ ] Code has type annotations
[x] Build checks

[x] I ran the black+isort formatter (make format)
[ ] I locally tested that the tests pass (make check-all)

[x] Release management

[ ] RELEASE.md updated with entry for this change
[x] New contributors: I've added myself to CONTRIBUTORS.md

@uri-granta

(as an aside, it would be nice if the pretty printing were accessible via a public method!)

gpflow.utilities.print_summary() ?


Fix #15

Properly set representation of version parts to use it in version file

Hi, thanks for the PR. May you please consider adding some tests? There is no test case that exposes the failing feature, so it is pretty impossible to understand if the additions are correct or even useful. Thanks!

May you please check if #22 solves the issue? I added a test case for what I think was the original issue, i.e. having dates specified with integers in the version file.

I'm sorry in the last two months I didn't have time to follow the project and I slightly lost track of what was happening. I'm closing this as I think #22 solves the issue, but feel free to reopen an issue if something is still missing. Sorry for ignoring the thread for months.


Do not serialize the errno field

We already get the exit code when the program exits so there is no need
to include it in the json. Podman will reject unknown fields to prevent
reading unexpected stuff.

LGTM

/lgtm


Dependency on jaxsim?

Installation following the README fails on my machine with:
$ pip install git+https://github.com/ami-iit/meshcat-viz-python
...
ERROR: Could not find a version that satisfies the requirement jaxsim (from meshcat-viz) (from versions: none)
ERROR: No matching distribution found for jaxsim

I see that this is an experimental project at https://github.com/ami-iit/jaxsim. Ways to fix this include putting a pre-release on PyPI (won't appear in search but still be pip-installable), or updating the README instructions to install other deps via git+https.

Hi @stephane-caron, thanks a lot for the feedback! I'm in the process of streamlining all these libraries and push them to PyPI. The overall ecosystem will be:

rod for parsing model descriptions
meshcat-viz as visualizer
jaxsim as simulator

As you might have noticed, all of these libraries are very young and experimental. I'm finalizing their deployment to PyPI in these days. For easing local development (i.e. laziness, sorry for that), I didn't use git+ modifiers because local tests were overriding my personal editable installation with the latest online commit.
Deployment at least to PyPI for pre-releases is imminent (few days top). If you want to try all these projects today, I'd recommend for the time being to install all of them manually with pip install git+<url>.

Given that PyPI release is blocked by https://github.com/ami-iit/rod/pull/9, I addressed the problem in #6.


feat: Go backend API docs

Feat: https://github.com/casbin/casdoor/issues/31

Deployed at: https://door.chromium.link/

Something wrong with the commits, I will make a new PR later

@Kininaru a kind note: you don't need to re-create PR to adjust commits. Just do the job and your PR will be auto-updated.


Add a Gitter chat badge to README.md

Olical/impl now has a Chat Room on Gitter
@Olical has just created a chat room. You can visit it here: https://gitter.im/Olical/impl.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Added manually.


flutter-engine: Add pkgconfig dep (#61)

It failed to build on Oniro kirkstone branch
Forwarded: https://github.com/meta-flutter/meta-flutter/pulls?q=author%3Arzr
Origin: https://github.com/meta-flutter/meta-flutter/pull/61
Signed-off-by: Philippe Coval<EMAIL_ADDRESS>

@rzr forgot to ask.  What's the error?

pkgconfig is just a built utility not related to x11

I am also facing  X11 issues may be fixed by disabling with "--no-build-glfw-shell"
https://github.com/meta-flutter/meta-flutter/pull/41

@rzr That flag only works if the build has it present.  It's not present in every build.  So it's not a universal fix.  The only universal fix is to have the engine dev revert his commit.

@rzr The beta channel has hot fix.  So if you build beta channel tag, it will work fine.
What is the error around pkgconfig not being present? I have never had a problem due to this.

well  in meta-flutter/recipes-graphics/flutter-engine/flutter-engine.inc it's used "PACKAGECONFIG ??=" so I guess it won't hurt to have this patch. maybe i need it because i  am not on later branch than dunfell .
To select beta , should I change to this?
FLUTTER_RUNTIME ??= "beta"

On dunfell FLUTTER_SDK_TAG = "2.10.0-0.3.pre".  I went to https://github.com/flutter/flutter/commits/beta to find a Flutter SDK tag reference.  It's in the commit name.  I'm looking at writing a script to help with tag selection.  It's terribly confusing as they do not increment in a linear fashion.
On honister FLUTTER_CHANNEL = "beta"
FLUTTER_CHANNEL is deprecated in dunfell, and will be removed from honister which is why I pointed you to dunfell.

@rzr Also either FLUTTER_SDK_TAG or FLUTTER_CHANNEL is set in your local.conf as multiple recipes depend on them.


[Automation] Generate Fluent Lite from redisenterprise#package-preview-2023-03

[Automation] Generate Fluent Lite from redisenterprise#package-preview-2023-03

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-redisenterprise


file: writing a File with no batches will error

What were you trying to do?
Write an empty File with a file header and control using NewWriter(io.Writer).Write(f *File)
What did you expect to see
The ACH file written to io.Writer
What did you see?
Error: BatchCount calculated 0 is out-of-balance with file control 1
What's the use-case?
An FI wants an empty file with a file header/control and no transactions to be able to confirm that a communication path with the originator is alive.

Potential implementation: add this as an option in ValidateOpts to bypass the error.

Another implementation for this could be:
fh := ach.NewFileHeader()
// fill in fields

fc := ach.NewFileControl()
// fill in fields (tricky with EntryHash, etc)

var buf bytes.Buffer
buf.WriteString(fh.String() + "\n")
buf.WriteString(fc.String() + "\n")

// ioutil.WriteFile(path, buf.Bytes(), 0644)

@adamdecaf That is exactly what I was going to recommend when I saw the thread in Slack.

Appreciate the ideas! The Slack member mentioned he's using the HTTP server, so we'll need to enable this there.


switch to SciMLBase

Closes #1006

It's already registered and we're using it in the tests (because of the compat bound in our Project.toml).

It's already registered and we're using it in the tests (because of the compat bound in our Project.toml).

Oh, then TagBot must be sleeping in SciMLBase's repo...


There is no support for applying black to check for non-compliant code, this should be a future change.
Tests not run locally, relying on automated tests, but without functional changes, there should be no regression.
Quality-of-life changes:

ignore venv (typical location for a python virtual environment.)

I worked out a better pipenv setup for macos and included instructions in the PR. Still a kink or two to work out.
I use macports, so I removed all traces of python, pip, and pipenv, and then started from scratch, although it is not really starting from  from scratch on a development machine without wiping the system. Hmm, I could create a temporary account, at least that would be a clean account.
https://github.com/kbase/sample_service/pull/413
Well, at least the existing tests pass.
Were you saying you’d rather I just remove the black-formatted code from the docker compose PR https://github.com/kbase/sample_service/pull/412, rather than have this simple black-formatted PR, and then merge that into the docker compose branch (making those file changes disappear)?
The commit message for the black-formatted files in the docker compose PR notes that this was done because I was debugging tests, and it was troublesome to read the source files because they were full of warnings. black-formatting them removed the warnings.
Still, I’m fine reverting those files in the PR as well.

I think we decided to table going full Black for now.  So I'm going to close this one.


wip: supporting classifiers and packaging in ArtifactOrProject

Sorry for the churn on this. This is based on my comments in https://github.com/johnynek/bazel-deps/issues/69#issuecomment-372370151, and works on our codebase, and should work for multiple classifers. It supports the "front half" of specifying packaging and classifiers. (Classifiers should "just work", but there's no work done yet to distinguish between jar packaging and non-jar packaging in the BUILD files, so if you depend on a non-jar package, I believe the BUILD files will be broken.

this works on our codebase. The only change is the addition of packaging+classifier
in target names and bind
needs some real tests
needs consensus on the palatability of this .yaml syntax
I probably broke scala somehow
I snuck in support for exclude of particular packaging/classifiers

Definitely needs work:

non-jar packaging is added to .bzl and BUILD files, but results in broken BUILD files
needs test for the changes around excludes
I haven't tested .yaml generation yet, or the maven Tool.scala

I'm digging this PR.  I tried the branch to import a few scala jars with classifiers (e.g. com.twitter:inject-core_2.11:jar:tests) and it works great.  Let's get it merged!

I added some more tests, and made some tweaks to the PR (functionality is the same)
I'm planning to look at Tool.scala next.
This is still a problem:

non-jar packaging is added to .bzl and BUILD files, but results in broken BUILD files

I'm tempted to not address that in this PR, partly because I'm not sure what the appropriate course of action is (e.g., is it sufficient to just add anything with a non-jar packaging to runtime_deps instead of deps? Does that even work? The one place we use non-jar deps, we appear to add them as data for a test target). I'd be happy to explicitly disallow non-jar packaging in the dependencies.yaml file (except for in excludes). It seems like the appropriate place to do that would be in the decoding phase, but I couldn't figure out how that would work. I can always pop in a hack after everything is decoded if we think it'll only be short-lived too.
Sounds like @kevingessner is on board w/ the syntax. @johnynek what're your thoughts?

Just tried this out, it works for aar on maven.google.com too.
I did run into an issue where the aar transitive dependencies of an aar resolves incorrectly to jar. The debugger led me to Aether's resolving mechanism, so I don't think this PR has anything to do with that.

Dug a little bit more and found an issue that might affect this PR.
Even if the correct packaging type is passed to Aether, if the transitive dependencies of the artifact do not specify the  in the  section in the pom.xml, Aether defaults the type to jar. This causes errors like:
failed to find sha of com.android.support.test:rules:aar:1.0.1: org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact com.android.support.test:runner:jar:1.0.1 in google (https://maven.google.com)
Exception in thread "main" org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact com.android.support.test:runner:jar:1.0.1 in google (https://maven.google.com)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:444)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:246)
        at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifacts(DefaultRepositorySystem.java:302)
        at com.github.johnynek.bazel_deps.Resolver$$anonfun$getExt$1$1.apply(Resolver.scala:105)
        at com.github.johnynek.bazel_deps.Resolver$$anonfun$getExt$1$1.apply(Resolver.scala:103)
        at scala.util.Try$.apply(Try.scala:192)
        at com.github.johnynek.bazel_deps.Resolver.getExt$1(Resolver.scala:103)
        at com.github.johnynek.bazel_deps.Resolver.getShas(Resolver.scala:117)
        at com.github.johnynek.bazel_deps.MakeDeps$.apply(MakeDeps.scala:88)
        at com.github.johnynek.bazel_deps.ParseProject$.main(ParseProject.scala:11)
        at com.github.johnynek.bazel_deps.ParseProject.main(ParseProject.scala)
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact com.android.support.test:runner:jar:1.0.1 in google (https://maven.google.com)
        at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:39)
        at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:355)
        at org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)
        at org.eclipse.aether.connector.basic.BasicRepositoryConnector$DirectExecutor.execute(BasicRepositoryConnector.java:581)
        at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:249)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:520)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:421)

@jin do you know if there's something that can be done in this PR to address that? Or is it something upstream that we'll just have to live with for now?

note, I found some issues with aether sometimes not finding all dependencies. We implemented a coursier backend #145 .
It  may do better for this. I would like to get this issue solved, sorry I've been so quiet about this, I don't personally use the feature so I have less intuition about the corner cases.

Or is it something upstream that we'll just have to live with for now?

I think this has to be an upstream fix, since it's Aether doing the pom parsing and making the assumption that untyped artifacts are jars. The other upstream fix is to add the types directly to Google Maven poms.

@roblg in the short term, it would be nice to support classifiers on both backends, but it may be that we will abandon aether. It seems it is no longer developed (was sent to apache and renamed). So, not sure the best way forward.

Updated the PR to reflect the Resolver->AetherResolver move, and added classifier support to CoursierResolver.
Coursier exposed several fun data bugs in the public maven repository, and in our internal maven repository. :) No bugs in coursier itself though (afaict)! Lots more runtime_deps magically appeared on the switchover.

can we update the README with an example of how to use this feature?
Also, note I have a coursier resolver test currently, can you add a test using a classifier?

Thank you for staying with this!

No problem! I was going to be using this branch internally either way. Makes my life much easier if it's on master. ;) Thanks for putting up with my (barely) rudimentary Scala!


Update Pipfile

There were some dependencies not being install when running 'pipenv install' These were missing from the 'pipfile/pipfile.lock'
Description
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
django = "*"
django-cors-headers = "*"
python-decouple = "*"
djangorestframework-jwt = "*"
djangorestframework = "*"
Pillow = "*"
django-taggit = "*"

[dev-packages]
pylint = "<2.0.0"

[requires]
python_version = "3.6"```

Please include a summary of the change and a link to which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

`Adds missing dependencies to pipfile`

Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [x ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

- [x ] Test A - `pipenv shell` `pipenv install` `manage.py runserver` should no longer fail to start server after fresh install of project
- [ ] Test B

# Checklist:

- [ ] My code follows the style guidelines of this project
- [x ] I have performed a self-review of my own code
- [ ] My code has been reviewed by at least one peer
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

good work. Merging request.


Scroll test button

Problem:
We need a way to reproducibly trigger smooth user interactions. This makes manual measurements easier, but also enables automated tests.
Fix:
This PR is the easiest and very first of these interactions.

if you press the P S button it scrolls the canvas for 100 frames. If you run the performance measurement during this time, you can see it leaves helpful performance marks there too.
Commit Details:

The dispatch now returns the (internally used) Promise that succeeds if the entire update is done (dom-walker included).
I made a new hook that triggers a scroll interaction, waits for the dom-walker, then requests an animation frame, and triggers another scroll interaction until the counter reaches 100.

Note:
It's actually very powerful to try even in manual mode! It makes jank so visible I am mad at myself for not implementing this sooner.

you can try me here, it's a lot of fun https://utopia.pizza/project/5596ecdd/?branch_name=feature/perf-test-button

I hereby award @balazsbajorics the 30fps Merit Badge (formerly known as the Performance Merit Badge with Silver Clasp)

It is traditionally worn in public on special occasions, with semi-formal or formal apparel only.


[BUG] NVTabular and torch.masked_select cause each other failed.

Describe the bug
CASE 1
1. run PyTorch's `masked_select` function and backward, success ✅
2. run NVTabular snippet, failed ❌

and in another order. CASE 2:
1. run NVTabular snippet, success ✅
2. run PyTorch's `masked_select` function and backward, failed ❌

Steps/Code to reproduce bug
(environment.yml: https://github.com/YKX-A/debug_nvt_pt/blob/main/environment.yml)
conda env create -n debug_nvt_pt -f environment.yml
conda activate debug_nvt_pt

import and definition section

import numpy as np
import nvtabular as nvt
from nvtabular import Workflow, ops

import os
import torch
import torch as t

print(nvt.__version__)

bsz = 8
ebd_dim = 32

# ========== to trace the error ==========
os.environ['CUDA_LAUNCH_BLOCKING'] = '1'
torch.autograd.set_detect_anomaly(True)

def run_nvtabular_snippet():
    gdf_test = nvt.dispatch._make_df(
        {
            "ad_id": [1, 2, 2, 6, 6, 8, 3, 3],
            "source_id": [2, 4, 4, 7, 5, 2, 5, 2],
            "platform": [1, 2, np.nan, 2, 1, 3, 3, 1],
            "cont": [1, 2, np.nan, 2, 1, 3, 3, 1],
            "cont2": [10, 90, np.nan, 20, 10, 30, 30, 10],
            "clicked": [1, 0, 1, 0, 0, 1, 1, 0],
        }
    )

    cats = ["ad_id", "source_id", "platform"]
    cat_features = cats >> ops.Categorify() >> ops.Rename(postfix='_log')

    cont_features = ["cont", "clicked", "cont2"] >> ops.FillMissing()
    rename = cont_features[["cont"]] >> ops.Normalize() >> ops.Rename(
        postfix='_rename_cont')

    p = Workflow(cat_features + cont_features + rename)
    p.fit_transform(nvt.Dataset(gdf_test)).to_ddf().compute()

def run_torch_backward_with_masked_select_operation():

    # ========== forward ==========
    a = t.nn.Linear(ebd_dim, ebd_dim).cuda()
    ipt = t.randn(bsz, ebd_dim).cuda()
    res = a(ipt)
    random_mask = (t.rand(bsz) > 0.5).cuda()

    res2 = t.masked_select(res, random_mask.unsqueeze(1))  # use masked_select

    loss = res2.sum()

    # ========== backward ==========

    print('before backward')
    print(loss)
    loss.backward()
    print('backward finished ')

def run_torch_backward_with_substituted_masked_select():
    # ========== forward ==========
    a = t.nn.Linear(ebd_dim, ebd_dim).cuda()
    ipt = t.randn(bsz, ebd_dim).cuda()
    res = a(ipt)
    random_mask = (t.rand(bsz) > 0.5).cuda()

    idx = (random_mask == True).nonzero().squeeze(-1)  # substitute masked_select
    res2 = t.index_select(res, 0, idx)

    loss = res2.sum()

    # ========== backward ==========
    print(loss)
    print(t.masked_select(res, random_mask.unsqueeze(1)).sum())
    print('before backward')
    loss.backward()
    print('backward finished ')

Case 1: RuntimeError: scan failed on 2nd step: cudaErrorInvalidValue: invalid argument

run_nvtabular_snippet()  # ✅
run_torch_backward_with_masked_select_operation()  # ❌

Case 2 (before run, reopen the python interpreter/ retrart the kernel)
RuntimeError: CUDA error encountered at: ../include/cudf/detail/null_mask.cuh:326: 101 cudaErrorInvalidDevice invalid device ordinal:

run_torch_backward_with_masked_select_operation()  # ✅
run_nvtabular_snippet()  # ❌

Further description:
If we run run_nvtabular_snippet or run_nvtabular_snippet seperately (e.g, in a new kernel), there is no problem here.
I doubt the problem is on the torch.masked_select operator, which causes the backward() to fail when I have run some NVTabular code before.
Inversely, I can backward through torch.masked_select, but then I would failed in run_nvtabular_snippet.
A wordaround towards this problem is that we avoid using torch.masked_select and find an alternative:
(suppose we are in a clean kernel)

wordaround

# for case 1
run_torch_backward_with_substituted_masked_select()  # ✅
run_nvtabular_snippet()  # ✅

# for case 2
run_nvtabular_snippet()  # ✅
run_torch_backward_with_substituted_masked_select()  # ✅

Expected behavior
They shouldn't affect each other, right?
Environment details (please complete the following information):

all packages are installed via conda
environment.yml: https://github.com/YKX-A/debug_nvt_pt/blob/main/environment.yml

Additional context

Ubuntu 18.04.5 LTS
GPU: GTX 2080TI

I think this might be caused by this issue in pytorch: https://github.com/pytorch/pytorch/issues/52663#issuecomment-803642518
In our docker container we've shipped a version of pytorch that is compiled with -Xcompiler -fno-gnu-unique - which should fix this issue.
Can you try this out on our latest pytorch training container (docker pull nvcr.io/nvstaging/merlin/merlin-pytorch-training:21.12)  and see if that resolves?

@benfred things seem to work fine in docker nvcr.io/nvstaging/merlin/merlin-pytorch-training:21.12, except that I have to run  conda install -c conda-forge cudatoolkit=11.2 cupy to fix an error raised by cupy.
cupy's error is as follow.
cupy/cuda/function.pyx in cupy.cuda.function.Module.load()

cupy/cuda/function.pyx in cupy.cuda.function.Module.load()

cupy_backends/cuda/api/driver.pyx in cupy_backends.cuda.api.driver.moduleLoadData()

cupy_backends/cuda/api/driver.pyx in cupy_backends.cuda.api.driver.check_status()

CUDADriverError: CUDA_ERROR_UNSUPPORTED_PTX_VERSION: the provided PTX was compiled with an unsupported toolchain.

related to https://github.com/cupy/cupy/issues/5095;
probably caused by my incompatible CUDA Build Version, CUDA Driver Version and CUDA Runtime Version
python -c "import cupy; cupy.show_config()"
...
CUDA Build Version           : 11040
CUDA Driver Version          : 11020
CUDA Runtime Version         : 11050
...

after being reinstalled, my version is :
...
CUDA Build Version  : 11020
CUDA Driver Version : 11020
CUDA Runtime Version : 11020
...

Thanks for verifying @YKX-A !  Can you run nvidia-smi and paste the output here ?
@albert17 you've seen the the provided PTX was compiled with an unsupported toolchain error before right? Is this going to be fixed in the next version of our containers?

Thanks for verifying @YKX-A ! Can you run nvidia-smi and paste the output here ?
@albert17 you've seen the the provided PTX was compiled with an unsupported toolchain error before right? Is this going to be fixed in the next version of our containers?

My output in the docker is:
root@9cefda1b22a5:/workspace# nvidia-smi
Fri Dec 31 01:23:39 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.91.03    Driver Version: 460.91.03    CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  GeForce RTX 208...  Off  | 00000000:26:00.0 Off |                  N/A |
|  0%   39C    P8    24W / 280W |     43MiB / 11016MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
+-----------------------------------------------------------------------------+

Hi @YKX-A
If you update the driver you should be able to stop seeing this error.
Please try 510.00+

Thanks, @albert17


chmod: cannot access '/github/workspace/CodeCoverage'

Bug description
After running the unit-test action for edit mode tests with the following error :
chmod: cannot access '/github/workspace/CodeCoverage'

How to reproduce
Trigger the unit test ci.

Expected behavior

Not sure.
Additional details
The error is triggered when some of my unit-test fails. My understanding is that I should have a nice-ish report and not a bash error ?
The error indicates that the file CodeCoverage does not exist. The last line of dist/platforms/ubuntu/run_tests.sh does make a call to chmod without checking for file presence. Maybe wrapping it with a check would help ?
if test -f "FULL_COVERAGE_RESULTS_PATH"; then
  chmod -R a+r "$FULL_COVERAGE_RESULTS_PATH"
fi

I checked the various paramaters for code coverage to see if I could disable the feature, but as far as I know, the file name CodeCoverage is hardcoded in the action and the chmod cannot be avoided via configuration.
See the following places for the hardcoded string :

main.ts:71
image-environment-factory.ts:37

Is there a way to avoid the failure of the CI ?

I fixed this by installing the Code Coverage tool in my unity project, the error does not seem to show that this might be the issue, but once I installed that package to the project it instantly worked!


The remove migration directory command is updated

The remove migration directory command is updated.
The bash command for removing a directory recursively would be rm -r <directoryName>  or  rm -rf <directoryName>.

@harsh-vm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@harsh-vm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#sign-off


File name setting for "Refactor -> move to a new file"

The "Move to a new file" refactor is a great tool, except that the generated file keeps the casing of whatever you are moving.
Example:
export interface UserSettings {
  language: string;
}

Using the refactor here creates a file named "UserSettings.ts" (PascalCase) while I would like it to be named "user-settings.ts" (kebab-case)
A setting to change this behavior with options like:

Keep case of class/interface/etc name (current behavior)
Convert to PascalCase
Convert to kebab-case
Convert to lower case
(plus snake_case and camelCase i guess)

would remove an extra step (renaming the generated files or creating files by hand and manually importing it) and would make me and at least one other person on stack overflow very happy.

Letting users explicitly specify the file name (#50685) would address this. If we add an explicit set of options for the name, we could keep adding new options forever and never make everyone happy


Allow method parameter override for training based indices

Description
From mode/disk-based feature, we introduced concept of mode and compression level that will dynamically set default resolution. For indices created directly from the method (i.e. mapping) we allow users to override parameters if they want.
However, for training, we added the mode and compression, but made them mutually exclusive with method. See: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/plugin/rest/RestTrainModelHandler.java#L138-L139. We need to remove this and allow method overriding to provide a consistent ux experience across the plugin.

Hey Jack! Could you please assign me to this issue?


template literals don't work with ie11

Note: for support questions, please use one of these channels:
https://github.com/angular/material2/blob/master/CONTRIBUTING.md#question.
This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?
This is a bug

What is the current behavior?
The page does not open in ie11. I get an error:  Invalid character

What is the expected behavior?

The code should be transpiled correctly

What is the motivation / use case for changing the behavior?

Which version of Angular and Material, and which browser and OS does this issue affect?
alpha1 and ie11
Did this work in previous versions of Angular / Material?
Please also test with the latest stable and snapshot versions.

Other information
(e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)
The code of the button looks like this:
selector: '[md-button]:not(a), [md-raised-button]:not(a), [md-fab]:not(a), [md-mini-fab]:not(a)',
inputs: ['color'],
host: {
'[class.md-button-focus]': 'isKeyboardFocused',
'[class]': 'setClassList()',
'(mousedown)': 'setMousedown()',
'(focus)': 'setKeyboardFocus()',
'(blur)': 'removeKeyboardFocus()'
},
template:             <ng-content></ng-content>          ,

Template literals are not supported in ie11:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

I think this was fixed by https://github.com/angular/material2/commit/915585621432e413f0f5eeef9ba006201d41133f


What is the loss function you used in the 'vot_SiamRPN'

@foolwood hello~
What is the loss function you used in the 'vot_SiamRPN', when you count the distance between res[x,y,w,h] and the label_position.   Is that cross entrophy loss or?

@ZhangSanFengByGit
The loss functions are consistent with sec3.2 of the origin paper.
L_cls is the cross-entropy loss and L_reg is smooth L_1.
Thanks for your question.


bootstrapCDN certificates are not valid

All https downloads are disabled due to
The server presented a certificate that was not publicly disclosed using the Certificate Transparency policy. This is a requirement for some certificates, to ensure that they are trustworthy and protect against attackers.

in Chromium Version 53.0.2785.143
Your connection is not private

Attackers might be trying to steal your information from maxcdn.bootstrapcdn.com (for example, passwords, messages, or credit cards). NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED
Subject: *.bootstrapcdn.com
Issuer: RapidSSL SHA256 CA
Expires on: Oct 13, 2017
Current date: Nov 14, 2016

from
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css

related https://knowledge.rapidssl.com/support/ssl-certificate-support/index?page=content&id=ALERT2165&actp=LIST&viewlocale=en_US

@b264 Thanks for the report. @jdorfman is working with our CDN provider's support team on this, I believe.
Adding the twitter thread here for tracking as well: https://twitter.com/monobotBlog/status/798097238140387328
@jdorfman LMK if you need anything from me.
Cheers!

https://sslmate.com/blog/post/ct_redaction_in_chrome_53

I don't believe this is a bootstrap-cdn issue any more, but I'm not 100% certain

@jdorfman Just FYI -- not debating the issue -- SSL tests appear to be okay.
https://www.ssllabs.com/ssltest/analyze.html?d=maxcdn.bootstrapcdn.com

The current cert seems fine to me. I don't get how @b264 sees another certificate?

I'm seeing this issue as well.
Google Chrome	53.0.2785.101 (Official Build) (64-bit)
Revision	d68319683072a27031ebac6ac151e59f4190cab7-refs/branch-heads/2785@{#838}
OS	Mac OS X

Troubling, I am not getting alerts when issues are created =/
@b264 @EdgeCaseBerg as @jmervine said I have been working with MaxCDN support and we have yet to find anything. Not saying that your issues are invalid, it is just taking longer to diagnose.
Are you still seeing the same issues?

@b264 @EdgeCaseBerg we believe it might have something to do with this:
https://sslmate.com/blog/post/ct_redaction_in_chrome_53 (we use GeoTrust)
cc: @jmervine

Isn't there a newer Chrome version out already? I'm a Firefox user, but I tried with the latest stable Chrome on my Windows 7 VM and works fine.

I get the same error message here ( NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED ) when going to https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
Sertificate details:
SSL Server Certificate
Issued To

Common Name (CN)	*.bootstrapcdn.com
Organization (O)	<Not Part Of Certificate>
Organizational Unit (OU)	<Not Part Of Certificate>
Issued By

Common Name (CN)	RapidSSL SHA256 CA
Organization (O)	GeoTrust Inc.
Organizational Unit (OU)	<Not Part Of Certificate>
Validity Period

Issued On	Thursday, October 13, 2016 at 2:00:00 AM
Expires On	Saturday, October 14, 2017 at 1:59:59 AM
Fingerprints

SHA-256 Fingerprint	DC 56 27 A2 52 C2 52 D6 D6 F6 80 D5 20 01 CC F4
39 F2 FF 26 33 C9 F7 66 D6 D5 AB 6E 85 EE 64 33
SHA-1 Fingerprint	7C 00 F2 22 04 A9 91 14 C3 05 89 D5 D7 3A 78 7C
BA BD A7 A5

@kek91 what are your Browser and OS?

@jdorfman Sorry, my post has been updated.
Browser: Chromium, v 53.0.2785
OS: Linux elementary 0.4 (Loki) 64-bit

@kek91 can you try updating to the latest version of Chrome (54.0.2840.59) and tell me what happens?

@kek91 what datascenter are you hitting http://debug-17.netdna-cdn.com/ ?

This is currently the latest Chromium version for my ppa and I currently don't have time to troubleshoot when something inevitably breaks my Linux, so I'll just get a vm up tomorrow and replicate the issue there. I'll keep you posted :)
Regarding your newest comment, I'm hitting the MaxCDN London2 Datacenter

@kek91 sounds good thanks so much

@b264 && @EdgeCaseBerg -- Mind checking your datacenters as well... http://debug-17.netdna-cdn.com/

FYI, I just got home and there's no sertificate issues here (StackPath AMS1 datacenter).

@kek91 same system (OS & Browser)?

Oh sorry I was so focused on the physical location I forgot about that. Running Chrome, but it's updated to v 54.0.2840.87 so the issue could be resolved there as well. Windows 7 64-bit.

@kek91 all good just wanted to make sure. Yeah unfortunately this Chrome bug really screwed things up, but don't worry all of Google's properties are fine... 😠

I am going to close this for now. If anyone is having any further issues please open a new issue.
Solution: Upgrade Chrome to 54 and the problem will be fixed.
More details:
Due to a bug in Chrome, versions of Chrome 53 that are more than 10 weeks old now display this error message for all websites using Symantec certificates that were issued on or after June 1, 2016 (including from Symantec-owned brands like Thawte and GeoTrust). As of Friday, November 11, 2016, Chrome users can simply restart Chrome to avoid the bug. Chromium users must upgrade.

I personally did not see the problem resolve itself by restarting, however it does appear to be a bug in Chromium (and, by extension, Chrome) and not bootstrap-cdn.  I've also found a bunch more ssl sites with the same "issue".
TL;DR: use Firefox.

@b264 yes this year alone we have had to change the cert 2 times due to the unstable state of the digital SSL/TLS certificate infrastructure. As big as our service is, we refuse to change it again. The industry really needs to get it together since it is hurting not only service providers, but hundreds-of millions of people that rely on those services.

@jmervine

@EdgeCaseBerg

It's affecting a bunch of other things too (AWS for example)

Can you please elaborate?

@EdgeCaseBerg I also had to use Firefox for AWS and countless other things....  Chromium and Chrome are currently completely broken....

@b264 AWS had issues as well?

It still does; it's unuseable

OMG this is unbelievable. I am working with our support to update the cert (again).

It makes me feel a little better that they are having issues as well. I am just appalled of how many careless mistakes have been made by Browser and SSL vendors this year.

This seems to have just been fixed, in Chromium anyway

we are still seeing it...

net::ERR_INSECURE_RESPONSE suggests the SSL cert expired. Pointing to a different CDN gets the UI working again.

Hello @suchakra, are you able to replicate the issue in all web browsers on your end or just in Chrome? Also, could you please perform a traceroute towards the maxcdn.bootstrapcdn.com URL and paste it here in the comments? I'd like to get this checked out in more detail. Thanks!

Cannot reproduce it anymore; Appears fixed now. It was on chrome.

@suchakra Thank you for confirming! If the issue reappears, please let us know here in the comments (the exact web browser and its version, along with the traceroute towards the subdomain would help us a lot along the way).

@petarpetrovic  - Our corporate proxy is picking up the following:
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css?ver=3.3.7

@sanjaygovindan: you are commenting on a pretty old issue. Also, personally I can't reproduce so make sure you need every info you can (including browser version obviously)

@XhmikosR  - Thanks for the pointers. TBH, it's most likely proxy/filter related on our end. Have asked for the site to be whitelisted. Will see if that works.

I'm getting the following error
`NET::ERR_CERT_AUTHORITY_INVALID
Subject: *.bootstrapcdn.com
Issuer: Sectigo RSA Domain Validation Secure Server CA
Expires on: 14 oct 2020
Current date: 13 may 2020`

@XhmikosR please make a new issue with the info filled. Everything seems to work fine here.


Update renovate.json

Changes introduced with this PR
Please explain your changes here.

By contributing to this repository, I agree to the contribution guidelines.

@dustinblack Please merge. My previous change didn't work. Trying another direction.


[task]: move contribution guidelines

Move the contributing guidelines to the .github folder

this issue is being closed


uncommon charm parity with other explorers

Most people already associate a diamond with an uncommon its become the standard across different explorers and marketplaces. Doesn't look like the rare and others gemstones are emojis so we could start with this one.
🌱 -> 💎

We already don't use gemstones for Rare and Epic, so those won't match. Plus, the current charms are color-coded, so they match the color of the rarity. Also, I think the diamond looks to rare for uncommon. So I'm inclined to keep it as it is.


Incorrect value of remote_addr variable when receiving bad request and when http listen proxy_protocol

Environment
Docker, nginx:1.26.2-bookworm
nginx version: nginx/1.26.2
built by gcc 12.2.0 (Debian 12.2.0-14)
built with OpenSSL 3.0.11 19 Sep 2023 (running with OpenSSL 3.0.14 4 Jun 2024)
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-http_v3_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -ffile-prefix-map=/data/builder/debuild/nginx-1.26.2/debian/debuild-base/nginx-1.26.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'

Linux *****.fastvps-server.com 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 GNU/Linux

Description
When using ngx_stream_proxy_module with proxy_protocol on and ngx_http_realip_module with real_ip_header=proxy_protocol.
In the case when a correct HTTP request is received, the $remote_addr variable in the HTTP server logs is filled correctly - with the real IP of the user who accessed the proxy stream.
Example:
correct HTTP request: curl -k https://***** -H "Content-Length: 0"
in logs: {"proxy_protocol_addr": "89.179.***.***", "proxy_protocol_port": "58064", "proxy_protocol_server_addr": "185.4.**.**", "proxy_protocol_server_port": "443", "remote_addr": "89.179.***.***", "status": "200", ...
This is OK
If a bad request is received, the $remote_addr variable is filled with the proxy address, not the real client address, although as we can see from the $proxy_protocol_addr variable, nginx still receives the real address from the proxy.
Example:
invalid HTTP request, for example: curl -k https://***** -H "Content-Length: bad header"
in logs: {"proxy_protocol_addr": "89.179.***.***", "proxy_protocol_port": "58065", "proxy_protocol_server_addr": "185.4.**.**", "proxy_protocol_server_port": "443", "remote_addr": "<IP_ADDRESS>", "status": "400", ...
This is not ok. Why under the same conditions, $remote_addr = "<IP_ADDRESS>"
This leads to the fact that in the logs we do not see the real IP of the user, especially when bots send incorrect requests, we can mistakenly take them for requests from the internal network when this is not the case. This is especially dangerous if we have configured permission rules for requests from <IP_ADDRESS> or from the local network.
nginx configuration
Stream configuration:
upstream https_upstream {
  server <IP_ADDRESS>:444;
}

server {
  listen 443 default_server;
  listen [::]:443 default_server;

  ssl_preread on;
  proxy_protocol on;
  access_log off;

  proxy_pass https_upstream;
}

HTTP configuration:
server {
  listen <IP_ADDRESS>:444 ssl proxy_protocol;
  real_ip_header proxy_protocol;
  set_real_ip_from <IP_ADDRESS>;

  server_name *****;

  add_header Strict-Transport-Security "max-age=31536000; includeSubDomains; preload" always;
  proxy_set_header Host $http_host;
  proxy_set_header X-Real-IP $remote_addr;
  proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
  proxy_set_header X-Forwarded-Proto $scheme;

  proxy_buffering on;

  location / {
    proxy_pass http://backend-*****;
    proxy_http_version 1.1;
  }
}

This isn't a bug, request line & headers are fully processed and checked for validity prior to the POST_READ phase, where real_ip module runs (which populates $remote_addr with $proxy_protocol_addr).

This leads to the fact that in the logs we do not see the real IP of the user, especially when bots send incorrect requests, we can mistakenly take them for requests from the internal network when this is not the case.

...It's in the logs in your example. For logging/visibility just use $proxy_protocol_addr instead of $remote_addr.

This is especially dangerous if we have configured permission rules for requests from <IP_ADDRESS> or from the local network.

No further processing of the request (in terms of user configuration) by NGINX happens if request line & headers is malformed, as is the case in your example, so "permissions" (like the access module) are never reached in any case.


[FLINK-7798] [table] Add support for stream windowed inner joins to Table API

What is the purpose of the change
The PR enables the time-windowed inner join for StreamExecutionEnvironment in Table API.
Brief change log

Remove the inner join check for StreamTableEnvironment in operators.scala.
Add some tests for stream table inner join translation.
Update related docs.

Verifying this change
This change adds tests to JoinITCase.scala, which can be run directly.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

Thanks for the PR @xccui. I'll do some minor refactorings and merge it


Added  IContextEvents

Removed the onInit event for all scenes - now it is only on the first main scene.
Added IContextEvents to allow the app to respond to all scene change events.
There was a Resonance Audio demo that actually changed scenes but I can't find it. @ragner  please modify that demo to use IContextEvents and test that it still works.

too many files


Remove ClientInfo from API

ClientInfo isn't really necessary in the API as Properties can be used instead in most cases. I would like to remove it from the API and make the following changes:

Remove changeUser() and info() from AccumuloClient
Use Properties where ClientInfo is used
Keep ClientInfo as internal class
Add properties() and token() to AccumuoClient. token() is needed for code that creates ClientContext from AccumuloClient.
Stop creating ClientInfo from Accumulo.newClient() builder and create a Accumulo.newProperties() builder.

Current
New

ClientInfo info = client.info()
Properties props = client.properties(); Authentication token = client.token()

client.changerUser(user, token)
Accumulo.newClient().from(oldClient.properties()).as(user, token).build()

ClientInfo info = Accumulo.newClient().to(instance, zoo).from(user, token).info()
Properties props = Accumulo.newProperties().to(instance, zoo).from(user, token).build()

Can token() be added to AccumuloClientImpl rather than AccumuloClient to satisfy the requirements for ClientContext? I'm not sure it should be on the public API... and if we really need it, we could always add it later.
I think the method should be Accumulo.newClientProperties() instead... just to be more explicit about the scope of the properties.
:+1: to everything else in the proposal.

Updated with feedback from @ctubbsii:

Remove changeUser() and info() from AccumuloClient
Use Properties where ClientInfo is used
Keep ClientInfo as internal class
Add properties() to AccumuoClient
Stop creating ClientInfo from Accumulo.newClient() builder and create a Accumulo.newClientProperties() builder.

Current
New

ClientInfo info = client.info()
Properties props = client.properties()

client.changerUser(user, token)
Accumulo.newClient().from(oldClient.properties()).as(user, token).build()

ClientInfo info = Accumulo.newClient().to(instance, zoo).from(user, token).info()
Properties props = Accumulo.newClientProperties().to(instance, zoo).from(user, token).build()


how can I change emmet expand "className" back to "class" when using typescript for angular 2?

I'm using angular 2 with typescript but the emmet alway expand the class to "className" and I have to rename it to "class". How can I fix this ?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I just got this to work by

Atom Setttings
"Open Config Folder"
Open file to "/packages/emmet/node_modules/emmet/lib/filter/jsx.js"
Commenting out line 14 // 'class': 'className',
Restart Atom

@ccwasden thanks for the trick!
Looks like this behavior is expected for react developers, but is is really annoying when editing pure html or angular2 templates.
What about adding a parameter to enable/disable it (should probably be disabled by default)?

Another hack is to add
    "jsx": {
        "filters": "html",
        "extends": "html",
        "profile": "xml"
    }

to your ~/emmet/snipets.json
Bear in mind this will stop JSX expansions working, but if you're primarily working in Ng2 then that's probably not a problem.
N.B you will have to restart Atom after amending ~/emmet/snipets.json


Warning at launch - "uses 'requires' key in fabric.mod.json, which is not supported"

Every time I launch via MultiMC I get the below warning in the log:
[main/WARN]: Mod `lightoverlay` (4.1) uses 'requires' key in fabric.mod.json, which is not supported - use 'depends'
It doesn't seem to be causing any current problems but I thought it worth flagging up in case compatibility gets broken in future Fabric versions.
Running MultiMC version 0.6.7-1316 with the latest Minecraft and Fabric (Minecraft 1.15.1 and Fabric version 0.7.3+build.176) as available through MultiMC.

Has there been any update to this at all? I am running into the same issue myself currently.


Mail?

How about support for quoting e-mails (with headers)?

Linguist only selects the right highlighter for a file or snippet. Do you know a TextMate bundle or Sublime Text package that could be used to highlight emails?

Closing as stale.


Fix remoteMap may be null to avoid NullPointerException being thrown(#7653)

What is the purpose of the change
In this issue(https://github.com/apache/dubbo/issues/7653 ) RemoteMap may be null, NullPointerException will be thrown in ClusterUtils, this pr is to fix this issue, to avoid throwing NullPointerException in ClusterUtils, thanks
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7654 (cc9ed3a) into master (68062c1) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #7654      +/-   ##
============================================
- Coverage     59.17%   58.99%   -0.18%
+ Complexity      529      528       -1
============================================
  Files          1076     1076
  Lines         43451    43405      -46
  Branches       6352     6320      -32
============================================
- Hits          25711    25606     -105
- Misses        14901    14947      +46
- Partials       2839     2852      +13

Impacted Files
Coverage Δ
Complexity Δ

...apache/dubbo/rpc/cluster/support/ClusterUtils.java
69.81% <50.00%> (-1.35%)
0.00 <0.00> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-20.69%)
0.00% <0.00%> (ø%)

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
50.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
53.46% <0.00%> (-10.90%)
0.00% <0.00%> (ø%)

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
62.06% <0.00%> (-10.35%)
0.00% <0.00%> (ø%)

.../remoting/transport/netty4/NettyClientHandler.java
76.27% <0.00%> (-10.17%)
0.00% <0.00%> (ø%)

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
0.00% <0.00%> (ø%)

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68062c1...cc9ed3a. Read the comment docs.


[d3d11] [regression] [dissected] Automobilista 2 (1066890) severe performance regression since v1.9.4

Regression (77fps->30fps with the same scene) did start with the following commit:
https://github.com/doitsujin/dxvk/blob/d34bbdb58e547c943ef1eaeac38a88c35f51f52a/src/dxvk/dxvk_memory.cpp#L421
As the master branch has additional changes I am unable to say how this translates to current code base.
System information

GPU: AMDGPU POLARIS11 (rx 460) 2GB
Driver: 21.3.6
Wine version: Proton 7 with self built drop in dlls
DXVK version: master / v1.9.4 branch

Commenting the condition and code in 1.9.4 branch will restore performance to 1.9.3 levels.
Unfortunately setting log levels completely freezes my game launch and I can not provide any of them.
Other games tested with 1.9.4 vs 1.9.3 showed no obvious performance change (Assetto Corsa / Dirt Rally 2.0)

"Just" installed the game (why exactly is this 80GB?) and even at 1080p lowest settings it requires more than 3GB of VRAM, so yeah, this is not going to run well on a 2GB GPU. Not much we can do here.

As I understand the code should help with memory pressure , is there some hidden overhead for the GPUs memory controller or CPU in certain edge cases ?

Not really, and 100% GPU load indicates that the GPU is just busy fetching data over system RAM because there seems to be one allocation that gets paged out into system RAM. Again this isn't really something we can improve on right now, and I would suggest just using an older DXVK build for this game that happens to work.

But I already showed that my VRAM is not exhausted, and 100% GPU load is because it renders as much frames as possbile?
Checking radeontop with v1.9.2 vs v1.9.4 with proton 7 shows me that v1.9.4 uses LESS VRAM and GTT:
radeontop for v1.9.2:
All values at 100% utilisation except
Vertex Grouper + Tesselator 76%
Texture Addresser 93%
Primitive assembly 76,76%

1987M / 1991 VRAM 99,82%
1903 / 3063 GTT 62,12%

radeontop for v1.9.4:
All pipes pretty much 100% only depth block util. 80%

1761M / 1991 VRAM 88,47%
507 / 3063 GTT 16,54%

So by NOT allocating as much video memory it somehow saturates PCIe bus because it accesses system RAM.
Ok , as I am on PCIe 2.0 and my card has PCI 3.0 8x so it essentially kills performance.
I guess you can close it (wontfix :-1: ), I do not have the skill to optimize dxvk code, I just thought that hitting vram limit with 4 and later 8 gb cards could impact performance too, but I have no way to test.

I tried the branch , unfortunately it exactly matches v1.9.4 performance wise.

Not much we can do then. I'm not going to revert the changes because they genuinely help in other situations.

Ok , I am now in the process in making the chunksize configurable , because it seems this was the right call.
With a chunksize of 16 I now get v1.9.2 ish performance (a bit less than stock v1.9.3), will test various chunk sizes to see what works best.
Right now I am hacking it in as dxvk option because it is already accessible in dxvk_memory.cpp :+1:

Also tested using more VRMA than available by increasing the texture detail:
Automobilista 2 slightly overcommiting ~110%
128MB: 25.9
  1MB: 29.5

Automobilista 2 overcommiting ~ 150%
128MB: 9.6
  1MB: 7.7

And finally Dirt Rally 2.0 with over 147% mem usage
128MB: 52.6
  1MB: 39.5

So an all size fits nobody situation I guess :)

I'm not interested in making the chunk size configurable, even if 16M works well right now there's no guarantee that it will work in the future since it depends what the driver does behind your back. Not to mention that we already use small chunks for small resources.
Ideally we'd have TTM page out memory allocations that aren't used while keeping all high-priority allocations in VRAM at all times, the information is there, but I don't think the driver does that at the moment. This probably does already work better on Windows even with DXVK than it does on Linux.

I'm not interested in making the chunk size configurable, even if 16M works well right now there's no guarantee that it will work in the future since it depends what the driver does behind your back. Not to mention that we already use small chunks for small resources.
Ideally we'd have TTM page out memory allocations that aren't used while keeping all high-priority allocations in VRAM at all times, the information is there, but I don't think the driver does that to the necessary extent at the moment. This probably does already work better on Windows even with DXVK than it does on Linux.

No problem, I did it only for faster testing.
I think there is everything said and done, if there is anything more I should test, say the word, otherwise this issue can be closed.

Retested with never DXVK versions:
Sample race cockpit view from back of the grid:
v1.9.3   -> 62.2 fps
v1.9.4   -> 27.7 fps
v1.10.0 -> 72.6 fps
v1.10.1 -> 73.1 fps
Sample race menu looking over grid:
v1.9.3   -> 39.8 fps
v1.9.4   -> 21.8 fps
v1.10.0 -> 38.9 fps
v1.10.1 -> 38.7 fps
Whatever optimizations took place also fixed the issues I had with v1.9.4. :+1:

Just for future reference:
Unfortunately after a new round of testing, there are still combinations of races with "clear" weather that essentially half the frame rate with > 1.9.3 versions on my RX460 hardware.

Is there a way to migrate other applications running (e.g. Firefox) from VRAM to system memory (GTT), so that more becomes available for DXVK?
Having for example GameMode do that on enablement, would solve issues on e.g. a PCIe bandwidth (64 bits bus) and VRAM (2 GB) limited RX 550.

@yuzhaogoogle MGLRU for GTT next? :smiley:

I do not know of a way and without any insight i would imagine that would be a job for the kernel or the applications themselves.
I don't know if you know @ yuzhaogoogle but if not then please don't ping random people from random issues.
If you have a issue with or question about dxvk feel free to open a new one 🙂


Create gempush.yml Github Action

I think this action should be able to build/push the gem whenever a matching tag is pushed.
Status
Ready for Merge?

Hey @highb - I was thinking something similar. It'd be nice to have an action for this so I'm not just shipping it from my computer :laughing: Question: Does this run on every commit to master? Maybe it could be run per tag when a tag gets pushed? Maybe that's how it already will work!
Also, I'm happy to add you to the rubygems page if you wanted to use your API key here. It looks like it already does this, but it would be good to confirm that the API key doesn't accidentally get dumped any where visible :pray:

@briancain Yeah from reading the GH action docs, I think this means it will only trigger when a matching tag is pushed:
on:
  push:
    tags:
      - 'v*.*.*'

Oh and if you want to add me on Rubygems: https://rubygems.org/profiles/highb
I think the secret should be hidden with GH actions as long as it's saved as a secret and not as a plain ENV variable.

@highb - Looks like I need your rubygems email address to add you, can't do it through the website :open_mouth:

@highb - scratch that. Looks like it accepted a rubygems username just fine despite what it claimed to be asking for! :sweat_smile: You should be an owner now.

I guess let's merge this and the version bump, I'll plug in the API secrets from my account, then push a tag and 🤞

@briancain Hey sorry to bug you again but it seems like the action isn't showing up? Are actions enabled in Settings? https://github.com/briancain/vmfloaty/settings/actions I also think that the only people who get access to the Secrets tab are admins, if I'm reading the docs right https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization

Hey @highb - Yep, they are enabled from what I can see

From what I can tell, workflows won't show up or run until there's something to run. We haven't pushed any tags since merge (and looks like I forgot to push the last tag for v0.9.1), so I imagine if we tag and push, the workflow will run? :thinking:
Also if you want, you could send me your API key through keybase and I can add it. I can't see a way to give you admin access to this repo, but if that's a possibility I'd be happy to do that too.


Only load here package

Hi Seb,
I had a look at error message we were getting and I think the problem is actually coming from the vignette in the archived folder. I  suggest we delete that folder because we don't need it.

I've deleted the archive folder now

I've squashed the previous two commits in this branch into one (and seem to have merged it into master at the same time?)


Change title of Collections modal as you browse

Acceptance Criteria

AC1

GIVEN user is viewing clean/fresh collections modal
WHEN user taps into a collection (e.g. nitnem / sundar gutka)
THEN title of modal should change to name of collection (e.g. nitnem / sundar gutka)

AC2

Given titles of collections modal changes
When user is going into a collection or going back to the list of collections
Title change should be animated. For now it can be a cross fade, but it would be even better to indicate direction by moving the old text in the away direction and the new text from the coming direction.

Approach

[ ]

Mockup

Done