Deberta v2

Splits DeBERTa in two: DeBERTa and DeBERTa-v2.
I added an integration test for the model and the tokenizer so you can easily compare it gives the same results as your implementation.

Splits DeBERTa in two: DeBERTa and DeBERTa-v2.
I added an integration test for the model and the tokenizer so you can easily compare it gives the same results as your implementation.

Thanks @LysandreJik  for the quick PR. I just tested the code with all of the pre-trained DeBERTa models including v1 and v2, and I fixed few issues with loading v2 models and mnli fine-tuned models. Here is the (PR)[https://github.com/huggingface/transformers/pull/10129/files] Please take a look and merge it into this PR.
Thanks!
Pengcheng

@BigBird01, the PR was merged! Could you merge this PR? Thank you!

Thanks @DEBUT<EMAIL_ADDRESS>I just merged it. Could you continue to merge it to main branch?
Thanks!
Pengcheng
From: Lysandre Debut<EMAIL_ADDRESS>Sent: Monday, February 15, 2021 2:14 AM
To: BigBird01/transformers<EMAIL_ADDRESS>Cc: Pengcheng He<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [BigBird01/transformers] Deberta v2 (#1)
@BigBird01https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBigBird01&data=04|01|Pengcheng.H%40microsoft.com|8b7869326f5f499ddcaa08d8d19a6cb6|72f988bf86f141af91ab2d7cd011db47|1|0|637489808474455801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=IWjIJ%2BPuHXC0%2FOwMzh9g4fpmXQbw6s5zAOQ5PcEIxWw%3D&reserved=0, the PR was merged! Could you merge this PR? Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBigBird01%2Ftransformers%2Fpull%2F1%23issuecomment-779115574&data=04|01|Pengcheng.H%40microsoft.com|8b7869326f5f499ddcaa08d8d19a6cb6|72f988bf86f141af91ab2d7cd011db47|1|0|637489808474465759|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=SdXAzRiBU2ksznDBFvb0NH6pNLjcfDaZplE1R%2BZWDOw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJDNDRQX2GISJHH65S35GUTS7DXWVANCNFSM4XLHZP7A&data=04|01|Pengcheng.H%40microsoft.com|8b7869326f5f499ddcaa08d8d19a6cb6|72f988bf86f141af91ab2d7cd011db47|1|0|637489808474465759|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=v7l48iVxKMUbnr1yQwv4y1i3sU1ZgiOVSsfCNolmTrg%3D&reserved=0.


Update CMakeLists.txt

Allow plugin to build if required library exists

[approve ci rocky]

@JosiahWI Please make sure when you make such change requests are you more exact in what you request. What is cmake-format?? I don't see this as a command on my system.

We need to set up something similar to the clang-format hook for cmake-format. To document a workflow here:
python3 -m pip install cmake-format
cmake-format -i <path-to-CMakeLists.txt>

[ci approve clang-format]

[approve ci clang-format]

[approve ci]

[approve ci autest]

We need to set up something similar to the clang-format hook for cmake-format. To document a workflow here:
python3 -m pip install cmake-format
cmake-format -i <path-to-CMakeLists.txt>

I agree.. we have a pipenv file in test for testing.. we might want to consider having this file in the root as part of a better setup process.

[approve ci autest]

Closing PR.. will remake a new one with other tweaks as the better pattern is now known for us to use


Add option to provide a middleware function

For:
A middleware function could be used to add addition functionality to the logger without having them be implemented in the library. This would allow the library to stay true to its roots and remain as small and as simple as possible while not making it self irrelevant as a logging tool.
An example of such a middleware could be to add persistent or temporary storage to the logger.
Against:
Adding middleware functionality will quickly increase the use cases for better-logging and with it, bring more responsibility and expectations on the library. As stated in the readme:

better-logging is not meant to be the be all and end all of node.js logging. It is just supposed to increase the usefulness of the default logging methods.

In order to stay true to this statement; I believe that adding features such as middleware support should be considered out of scope.
Possible API:
const logs = [];
require('better-logging')(console, {}, e => {
  logs.push(e);
});

console.loglevel = 3;
console.info('foo');
console.warn('bar');
console.error('biz');
logs /* [
  { type: 'info', message: '[11:46:35] [info] foo', raw_message: 'foo', loglevel:  3 },
  { type: 'warn', message: '[11:46:35] [warning] bar', raw_message: 'bar', loglevel:  3 },
  { type: 'error', message: '[11:46:35] [error] biz', raw_message: 'biz', loglevel:  3 }
]
*/

This kinda goes hand in hand with #3
The "middleware" implementation could look like this:
const middlewares = [
  msg => msg,
  { log: msg => `[log] msg` }
];
require('better-logging')(console, ...middlewares);
console.log('hi'); // [log] hi
console.info('hi'); // hi

Just shipped a basic implementation of this with the latest version.


Wrong data type for users.users..pamMount?

Describe the bug (Not a bug but a missing feature?)
I was able to mount a luks2 partition via users.users.name.pamMount
  users.users.lorem.pamMount =
      {
        user = "lorem";
        fstype = "crypt";
        cipher = "aes-xts-plain64";
        options = "no_read_workqueue,no_write_workqueue,allow_discard,fstype=ext4";
        path = "/dev/disk/by-uuid/<uuid>";
        mountpoint = "/mnt/<mountname>";
   };

but how will I be able to mount a second one with this?
Shouldn’t this be a list of set of attributes instead of single set of attributes?
What am I missing?
Notify maintainers
@dnr @edolstra @rnhmjoj @pennae @volth @rickynils

The intention of that option was just a generalized version of cryptHomeLuks to mount the user's home directory. You shouldn't really be specifying user or mountpoint there, they're implicit. If you want more arbitrary entries, just add them to security.pam.mount.extraVolumes.

I understand now, thank you. Maybe it needs more explanation, examples. security.pam.mount.extraVolumes, too.
And security.pam.mount.extraVolumes can be list of set of attributes, so would be more nixified? Just a suggestion, I might be wrong.


test_host_endpoint_combinations test case is failing for Calico-3.1.3

executed make st on calico-3.1.3 which resulted a test case failure.
Expected Behavior
All TCs should pass.
Current Behavior
test_host_endpoint_combinations is failing on RHEL 7.5 (both Intel and non-Intel architectures).
[fail] 11.58% tests.st.policy.test_felix_gateway.TestFelixOnGateway.test_host_endpoint_combinations: 13.1786s
Steps to Reproduce (for bugs)
1.#Install GO 1.10
2.git clone http://github.com/projectcalico/calico $GOPATH/src/github.com/projectcalico/calico
3.cd $GOPATH/src/github.com/projectcalico/calico
4.git checkout v3.1.3
5.cd $GOPATH/src/github.com/projectcalico/calico/calico_node
6.RELEASE_STREAM=v3.1 make dist/calicoctl
7.RELEASE_STREAM=v3.1 make calico/node
8.RELEASE_STREAM=v3.1 make st
Output of RELEASE_STREAM=v3.1 ST_TO_RUN=tests/st/policy/test_felix_gateway.py:TestFelixOnGateway.test_host_endpoint_combinations  make st :
felix.log
Your Environment

Calico version - 3.1.3
Operating System and version: Intel , RHEL-7.5

Looks like the release-v3.1 branch is currently passing all STs: https://semaphoreci.com/calico/calico-old-releases/branches/release-v3-1


What's the different of simulate between shallow and mount?

In the document of Shallow Rendering, it says the simulate() will target the component's prop based on the event you give it. simulate of shallow.
How about in Full DOM Rendering? Is it the same? Does the event propagate as in real environment?

Full Dom Rendering use Simulate from react-addons-test-utils, find the answer by looking at the source code.


List destroyed comments in the admin activity log

I'm a bit confused, isn't this exactly how it is already? https://github.com/EloHellEsports/workshop.codes/blob/6de0f89ee63e88cf2aab7f03678873967fdba2c7/app/views/admin/base/index.html.erb#L83

Huh, could've sworn it wasn't there. No idea how I didn't catch that.


chore(release): v0.11.0

Version bump in package.json for release v0.11.0

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


c4

PR Description 📜
Adding new game : c4
Fixes #1514

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @U-DAY-333 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @U-DAY-333 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Thank you  @U-DAY-333 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Stop ignoring errors in sub-agent startup

Previously, when a subagent couldn't be started, the install process would claim that the ops agent was installed successfully and would simply skip the failing agent. This is confusing and hides problems. The way I ran into this was in the case of a flaky install error, which is supposed to be handled by OS Config via a retry loop. However, the retry loop doesn't kick in because it thinks the install succeeded. After this PR, it should at least notice the error and try again.

hi, FYI I've never made a PR before, so I dunno how this works.


[Event Request]Fault/Resol. Cod. Relationship page 5930 procedure UpdateOrginalRecord

(1) Between line 215 and 216, please add an event so we can modify more customized field
There is a spelling error on 'Original'.  Should we keep the wrong spelling or correct it?
OnUpdateOriginalRecordOnBeforeServitemLineModify(Rec, ServItemLine)
[IntegrationEvent(false, false)]
local procedure OnUpdateOriginalRecordOnBeforeServitemLineModif(FaultResolCodRel: Record "Fault/Resol. Cod. Relationship"; var ServItemLine:Record "Service Item Line")
begin
end;
(2) Between line 224 and 225, please add an event so we can modify more customized field
OnUpdateOriginalRecordOnBeforeServiInvineModify(Rec, ServInvLine)
[IntegrationEvent(false, false)]
local procedure OnUpdateOriginalRecordOnBeforeServInvLineModif(FaultResolCodRel: Record "Fault/Resol. Cod. Relationship"; var ServLine:Record "Service Line")
begin
end;
Thanks very much.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52511.


⚠ Bofrost.at has degraded performance

In 4268f43, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2719 ms

Resolved: Bofrost.at performance has improved in a2b2139.


Add link to contact threefold support in VDC deployer and in the VDC controller

Support page link https://support.grid.tf/

verifying this...

@xmonader  @samaradel this link to support added to threebot dashboard and to VDC Controller as this PR #3134. but I think this should be added to the VDC Deployer as well as mentioned in the issue but I can't spot the button there.
commit f0c115eb251c0273eab357b282242804d691ff61

verfied
commit b308cdf18af6a4d751440b44b7ff86dd8d9fa4ab


Question on Quantized version

Hi, this is wonderful job to bring it to comfyui. However, with limited resouces I am unable to run 5b version. Since the model has transformer architecture, can't we quantize it to make it fit in low-end systems with 6gb cards? Since gguf formats are omnipreset and users are much more comfortable using it, I guess that is the way forward.

Maybe, I'm unsure how it would perform at 4bit, it's already possible to do fp8 with these nodes. I also added the diffusers sequential_cpu_offload as option, it will reduce the VRAM use a lot (16 frames would be only about 3GB), but also slow down the process.

The thing is it has only 12 gb RAM and 15 gb vram and I am already using ggfu q4 version of T5 text encoder. Unfortunately it loads the cogx5b in the ram and crashes.  However, I am able to run 2b version smoothly. Will try sequential_cpu_offload node to see if something happens positively. Also fp8 option is not supported by the  t4 GPU. If possible, can u upload a quantized 8 or 6 bit version of the cogxvideo-5b , or help me with any conversion tips. Any help is appreciated.   Thank u.

Unfortunately it loads the cogx5b in the ram and crashes.

I had a similar problem: everything loaded but then the script got stuck at 0%

Details
(I have windows 11, nvidia rtx 3060 12 gb vram, 64 gb ram; I haven't tried today the fp8 transformer option but yesterday it didn't work: Unsupported type of tensor: nullptr (uninitialized), and yesterday there wasn't the cpu offload option and I deleted the full model in the meantime)

, anyway if you want to test the model while waiting for the gguf version you can use camenduru's 8bit version, it worked for me, I downloaded and renamed the model into diffusion_pytorch_model.safetensors, and changed the existing diffusion_pytorch_model.index.safetensors with the camenduru's config.json. Sadly the fp8 model too didn't fit for an inch in my vram (around 12,8 vram against a total of 12), so I had to turn on the cpu offload option and with that the fp8 version worked using only 2gb vram, such a waste of my rtx;

Thoughts
I suppose that since I'm using the cpu option maybe we could even have enough vram left for the full model, but I'll make the vram usage and speed comparison test when I'll have the will to download it again

Unsupported type of tensor: nullptr (uninitialized)
I have never seen this before, what torch version are you using?

Me neither, it was a rare bug also to find online, only around 2-3 cases
open-clip-torch           2.24.0
pytorch                   2.1.2
pytorch-cuda              12.1
pytorch-lightning         2.2.5
pytorch-mutex             1.0
torch                     2.3.1+cu121
torchaudio                2.3.1+cu121
torchmetrics              1.4.0.post0
torchsde                  0.2.6
torchvision               0.16.2
diffusers                 0.30.1
```

Unfortunately it loads the cogx5b in the ram and crashes.

I had a similar problem: everything loaded but then the script got stuck at 0%
Details
, anyway if you want to test the model while waiting for the gguf version you can use camenduru's 8bit version, it worked for me, I downloaded and renamed the model into diffusion_pytorch_model.safetensors, and changed the existing diffusion_pytorch_model.index.safetensors with the camenduru's config.json. Sadly the fp8 model too didn't fit for an inch in my vram (around 12,8 vram against a total of 12), so I had to turn on the cpu offload option and with that the fp8 version worked using only around 3gb vram, such a waste of my rtx;
Thoughts
Edit:
Ah and I too am using the t5-v1_1-xxl-Q8.gguf, which is half the size of the full clip

can you share your workflow please ?

Sure: CogVideoX-5b_workflow.json
Also, at the moment in the transformer folder there is the fp8 version

When I want to use the full model I rename the folder into smth else, like transformer_fp8, and rename transformer_full into transformer, this way you have both models and you are telling the script which folder to see. You can make a test to see what's best for you and then delete what necessary.

In the full model folder I have this:

Sure: CogVideoX-5b_workflow.json

Thanks, just downloaded vae and other smallers files (not transformers or t5 clips) and made the rest of the folders then put the smaller model with config inside, It worked BUT as usual with my gpu it gave up on vae decoding. In the past with other video models I needed some tricks , also if we can use our own vae tiling maybe I could get around this. (amd rx 6600 with zluda) , at cfg 1 it takes around 30-35 sec per iteration (just to test stuff , I wasn't going to wait forever for potentially getting errors in the end and I was right:) )

it gave up on vae decoding.

Same here... I'm testing the cogvideo decode node options to see if someone can make it work 'till the end


Update MoE examples

Update the FP8 Mixtral example to not use GPTQ and add it to examples list

slightly unrelated once your fp8 moe PR in vllm lands, we should add an e2e test case: https://github.com/vllm-project/llm-compressor/blob/main/tests/e2e/vLLM/test_vllm.py


Only clocked/sampled communication

Currently the communication is cyclic only.
Proposal: This is taken from a trigger type implementation we once did for CAN and where more trigger options are available.
type trigger_type=enumeration(
  event_trig "Event",
  cyclic_trig "Cyclic",
  cyclic_event_trig "Cyclic + Event",
  initial_trig "At Start only",
  terminal_trig "At Stop only") "Use as trigger";

@dietmarw May be interesting for you that the syntax hiliting of the closing bracket is blue where it should be black.

I'll ping @thorade as he knows more about what highlighter is currently used by GH.

Modelica syntax highlighting was added as a reaction to this issue:
https://github.com/github/linguist/issues/2053
here is the corresponding pull request:
https://github.com/github/linguist/pull/2059
In that pull request, the repo@commit https://github.com/BorisChumichev/modelicaSublimeTextPackage/commit/d7e50e39c14a49153d3c17dfbd623258cf1a5d69 was chosen for syntax highlighting. The repo has since then seen some updates, so the pointer to the hash should be updated. But before doing that, you should file an issue that demonstartes your problem here:
https://github.com/BorisChumichev/modelicaSublimeTextPackage/issues
Upload some problematic Modelica code e.g. to Gist, then use Lightshow:
https://github-lightshow.herokuapp.com/
E.g. like this:
http://bit.ly/19e6Mv1

@thorade Feel free to do it. Thanks. :grinning:

@bernhard-thiele Do you think we can reuse PackageIn.trigger and PackageOut.trigger for alternative triggers? Can we use backwardTrigger only enable if trigger_type is cyclic? Is this alloed in a connector?

@tbeu Yes, I think so. I will try something once I have some time and a free dymola license. I will try to support an additional external Boolean trigger input signal which is conditional available if some Boolean parameter is set. The different triggering options could be realized by a distinctive "trigger" block. I think this would be a pretty flexible solution.

Good idea. I believe I can support you. Cylclic should be independet of Boolean trigger input to realize "Cyclic + Event" triggering.

@tbeu I just made a first attempt in a new feature branch. Example Modelica_DeviceDrivers/Blocks/Examples/NEWTestExternalTriggerSerialPackager.mo illustrates the idea.
Note that this is a backwards compatible change. What do you think about it?

Thanks for fast implementation. My thought:

Why did you choose to add the trigger port to the SerialPackage? Answering myself, one reason might be to do it only once at exactly one location in the package. But if I had done it I'd select the communication send/receive blocks for the addtional trigger port. In my opinion it logically belongs there. It is the possible to create a package and connect multiple send blocks (wih different triggers) to it.
There is no need to support the "Cyclic + Event"  triggering like we did in the past and I mentioned above. Best way of modeling is like mentioned above with one package and multiple communication blocks.
Imagine the case where two ore more packages need to be sent in a particular order (in order to realize some special communication protocol). This would require an extra Boolean outport returning the I/O success for the communication blocks for modeling chained communication processes.

Let me hear what you think about these comment. Thanks.

Ok, my thoughts:

I implemented the mechanism for the SerialPackager just as an example for discussion and planned to implement the same mechanism also for the various receive and send blocks. However, that alone is probably still not sufficient for the use case that you describe, since it wouldn't allow to connect several send blocks to one package. The triggering logic would need to be extended so that it can cope with several sinks or sources. For the sinks and sources one would need to be careful so that the same device can be shared. But maybe I'm thinking to complicated...
The Boolean output is an interesting idea. But a simple I/O success might not be sufficient for modeling chained communication processes. We could either generate a new event that is capable of triggering the next blocks, or we could try to ensure that all blocks are synchronized at events and use an additional signal to establish data-flow dependencies that would ensure the correct ordering. What scenario to you have in mind?

You are right: Multiple communication sinks are too complicated if possible at all. Maybe the extended trigger type is a solution.
I was thinking of custom protocols where packages need to be sent in a particular order, e.g, do a handshake first and then do sampled communication. It should be possible as custom text but maybe not with generic block components since different packages may be required for the different protocol steps.

Just created branch externalTriggerFeature in which I added an option to use an external trigger for triggering the read/write operations. This approach uses conditional connectors which adds another challenge to Modelica tools and people trying to understand the code ;-).
@tbeu Does the new code work in SimulationX and do you have any comments on it?

Can test it next week.


Correct way of adding typescript def files in version ce ?

Hi,
I am using webpack with expose-loader to have Phaser etc available on the global scope. Things are working well, I decided to upgrade to phaser-ce and the only way I could get my IDE (webstorm) to recognise that Phaser was actually a type was doing the following in MY tsconfig.json file
  "include": [
    "**/Game.ts",
    "../node_modules/phaser-ce/typescript/phaser.d.ts"
  ],
  "exclude": [
    "node_modules",
    "**/*.spec.ts"
  ]

Now it does work but says there are Multiple Options i.e. phaser.d.ts and phaser.comments.d.ts and phaser_box2d.d.ts.
I was wondering if I was doing the above correctly ?
I of course decided to remove the Includes section above but then that fails probably due to the fact that I have the exclude node_modules so the types are never being picked up.
I am using typescript 2.1 and decided to try and use the typeRoots but this also failed
    "typeRoots" : ["../node_modules/phaser-ce/typescript"]
I am little confused of how to proceed do I leave the     "../node_modules/phaser-ce/typescript/phaser.d.ts"  inside the include section of the tsconfig.json ? It just feels kind of wrong.
Also even if I use this way then 'Phaser' seems to show Multiple Implementations for Phaser
Any help or info really appreciated
Thanks

In your tsconfig.json you need to add the following;
{
...
    "files": [
        "./node_modules/phaser-ce/typescript/phaser.comments.d.ts",
        "./node_modules/phaser-ce/typescript/pixi.comments.d.ts",
        "./node_modules/phaser-ce/typescript/p2.d.ts"
    ]
}

Closing this, but if any relevant Phaser docs are incorrect/incomplete, please add an issue.


Updating Feedback Form

Simplifying the feedback back and displaying responses in a table.

@TejasNasre
As you instructed me to take only 4-5 questions for feedback, the table structure will change. How can I display the responses in the table if they are larger? Also, I need to remove the check response button for that.
It is okay to take four or five questions from this.Let me know what you want.
How would you rate your overall experience at the event? (Rating/Slider)
What did you enjoy most about the event? (Text Input)
What aspects of the event could be improved? (Text Input)
How likely are you to recommend this event to a friend or colleague? (Rating/Slider)
Did the event meet your expectations? Why or why not? (Yes/No + Text Input)
How satisfied were you with the event's organization? (Rating)
How was the registration process? (MCQ: Excellent, Good, Average, Poor)
Was the event well-structured and on time? (Yes/No + Text Input)
Were the event facilities (venue, seating, etc.) adequate? (MCQ: Excellent, Good, Needs Improvement)
How would you rate the quality of the speakers/presenters? (Rating/Slider)
Was the content presented by the speakers engaging and informative? (Yes/No)
Who was your favorite speaker, and why? (Text Input)
How clear were the presentations or workshops? (MCQ: Very Clear, Somewhat Clear, Not Clear)
How relevant was the event content to your interests? (Rating/Slider)
Did you learn something new or valuable at this event? (Yes/No + Text Input)
Which sessions/topics were most useful for you? (Text Input)
How can we improve the event's content for the future? (Text Input)
Did you have enough opportunities to network and engage with other participants? (Yes/No)
Was there enough time allotted for Q&A or interaction with speakers? (Yes/No)
How would you rate the networking opportunities at the event? (Rating)
Was the event location easy to access? (Yes/No)
How would you rate the event facilities (Wi-Fi, seating, catering, etc.)? (Rating/MCQ)
Were you satisfied with the communication about event logistics (venue details, schedule, etc.)? (Yes/No)

Yeah all correct don't take all questions any 5, 4 questions will be options and 1 will be. Input text and I am but busy figure out which questions are useful to ask just think yourself and implement

Yeah, okay, I will be finalizing these as feedback questions.
What did you enjoy the most about the event?(Text Input)
How would you rate the overall organization of the event?(MCQ)

Excellent
Good
Average
Poor

How would you rate your overall satisfaction with the event? (Rating)
How likely are you to recommend this event to a friend or colleague?(Slider)
What could we improve for future events?(Text input)

Yeah, okay, I will be finalizing these as feedback questions.
What did you enjoy the most about the event?(Text Input) How would you rate the overall organization of the event?(MCQ)

Excellent
Good
Average
Poor

How would you rate your overall satisfaction with the event? (Rating) How likely are you to recommend this event to a friend or colleague?(Slider) What could we improve for future events?(Text input)

Great mak PR after completion

@0xPratikPatil sir any updates ?


Update README.md

Added a note clarifying that this repo is intended for experimental use, and to visit the forums to ask questions/etc.

@kesmit13 - I can self-merge, but I wanted to double check with you to make sure it was appropriate to add the disclaimer to this repo.


[docker] trace-agent: fix entrypoint

What does this PR do?

This fixes a stale entrypoint script that still uses -config instead of the new --config since the adoption of cobra from #16387.
Motivation

The old script will/can cause the trace-agent launch to fail, expecting --config it would be supplied the incorrect -config.
Additional Notes

Related PR: https://github.com/DataDog/helm-charts/pull/1129
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Note that these changes are now no longer, "mandatory" as PR #18492 ultimately introduced a backward-compatibility layer that will allow the old trace-agent calls to "just-work".


SSL Cert not fully trusted by Chrome

Chrome's claims:

''The identity of this website has been verified by StartCom Class 2 Primary Intermediate Server CA but does not have public audit records."

"The site is using outdated security settings that may prevent future versions of Chrome from being able to safely access it." (the one causing the red strike through)

StartCom forum thread discussing topic and possible solutions:
https://forum.startcom.org/viewtopic.php?p=21511
Screenshot of issue:

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/21790459-ssl-cert-not-fully-trusted-by-chrome?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Sounds like a dupe of https://github.com/gratipay/gratipay.com/issues/3278. What version of Chrome are you using, @catskul?

Closing as a dupe of #3278.


Permanent AJAX request

While trying to find bug in our application I have run into these lines: https://github.com/ublaboo/datagrid/blob/master/assets/dist/datagrid.js#L576-L581 which were in fact the root cause!
Our problem was that there is ajax call on every page (we have included the @datagrid.js@ in our JS assets) reloading page after it is loaded even if there is no datagrid on the page... That causes flickering of the page, loosing progress of user etc.
Is there any reason why this is done this way?

When you filter in datagrid, the url is changed alongside with every request using history API. Then you can go to another page, but when you come to datagrid page again, there is not persistent parameters in URL even though there are grabbed from session and placed in filter inputs. User can then copy the URL, but there are no filters in URL as long as user triggers firt xhr on site (then the url is refreshed using history API again).
I understand your situation. There is not a right way how to solve this. Argh..
I will probably place an if statement within the script, which will trigger the mentioned xhr only on sites with datagrid. I will also put this script in separate file, so users can decide whether to use it or not.
Do you have any further comments?

The described solutions seems good enough for our case.
Though thinking about the issues... shouldn't be reloading just the URL be enough (i.e. do the request everytime, but not to end up with reloading content of whole page?)

The JS snippet you mentioned above is not reloading the content of whole page. It just triggers a datagrid handler, that will redraw non existing snippet.
It is not enough. When there is a non ajax request to datagrid site, there are persistent url parameters missing.

I feel a bit puzzled because "reloading the content of whole page" is exactly what I see (especially when I open network console and display the content of the response of such AJAX handler). That's weird.

v4.4.18 - There is a datagrid-instant-url-refresh.js and ...min.js, where i put the instant url refresh updated functionality.

@paveljanda Isn't that BC break?

@juniwalk Well it was when i added the url refresh couple days ago. Then a realized it is a BC break and moved it to separate file.. so I made a BC break again, but it should fix the previously created BC break. :D
The previous BC break was making ajax callas on every non-ajax page load.  Now it creates ajax call on every non-ajax page load only if there is at least one datagrid on page (Yes, you have to include the datagrid-instant-url-refresh.js script into your project).
What is your opinion on that?

@paveljanda So if I understand this correctly, that AJAX request is getting information about rendered datagrid? Current page, filtering, sorting etc? If so, then this fix is alright. :)

@juniwalk That's right.

@paveljanda Thank you :-)


There is error in 0.0.19

Error: parse error at (signoz/templates/otel-collector-metrics/config.yaml:9): unexpected unclosed action in command

how come it wasn't caught in lint-test. :thinking:

@medicharlachiranjeevi  can you please share which K8s version and cloud vendor you are using?
Not able to reproduce from my side.
$ helm search repo signoz --versions

NAME               	CHART VERSION	APP VERSION	DESCRIPTION
signoz/signoz      	0.0.19       	0.8.2      	SigNoz Observability Platform Helm Chart
signoz/clickhouse  	16.0.6       	<IP_ADDRESS> 	A Helm chart for ClickHouse

hey I was using the same values even the default one.
# Default values for SigNoz.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

# SigNoz chart full name override
fullnameOverride: ""

# Clickhouse default values
clickhouse:
  # fullnameOverride: signoz-clickhouse
  # zookeeper:
  #   fullnameOverride: signoz-zookeeper

  # clickhouse service
  service:
    httpPort: 8123
    tcpPort: 9000

  # Based on the cloud, storage class for the persistent volume is selected.
  # We can pass anyone of ['aws','gcp','hcloud'].
  # When set to 'aws' or 'gcp', new expandible storage class is created.
  # When not set, the default storage class (if any) from the k8s cluster is selected.
  # cloud:

  # We can override the storage class for the persistent volume.
  # Also, note that 'storageClass' takes more precedence than 'cloud'.
  # So if you set both of the configurations, 'cloud' will be no-op.
  # storageClass:

  # -- Cloud service being deployed on (example: `aws`, `gcp`, `azure`, `hcloud`, `other`).
  # cloud:

  # -- Whether to install clickhouse. If false, `clickhouse.host` must be set
  enabled: true

  # -- Name override for clickhouse
  # nameOverride: clickhouse

  # -- Name override for clickhouse
  # fullnameOverride: signoz-clickhouse

  # -- Which namespace to install clickhouse and the `clickhouse-operator` to (defaults to namespace chart is installed to)
  namespace:
  # -- Clickhouse cluster
  cluster: cluster
  # -- Clickhouse database (SigNoz Metrics)
  database: signoz_metrics
  # -- Clickhouse trace database (SigNoz Traces)
  traceDatabase: signoz_traces
  # -- Clickhouse user
  user: admin
  # -- Clickhouse password
  password: 27ff0399-0d3a-4bd8-919d-17c2181e6fb9

  # -- Clickhouse cluster shards
  shardsCount: 1
  # -- Clickhouse cluster replicas
  replicasCount: 1

  # -- Clickhouse image
  image:
    # -- Clickhouse image registry to use.
    registry: docker.io
    # -- Clickhouse image repository to use.
    repository: yandex/clickhouse-server
    # -- Clickhouse image tag to use (example: `21.8`).
    #    SigNoz is not always tested with latest version of ClickHouse.
    #    Only if you know what you are doing, proceed with overriding.
    tag: <IP_ADDRESS>
    # -- Clickhouse image pull policy.
    pullPolicy: IfNotPresent

  # -- Whether to use TLS connection connecting to ClickHouse
  secure: false
  # -- Whether to verify TLS certificate on connection to ClickHouse
  verify: false
  # externalZookeeper:
  # -- URL for zookeeper.
  # servers:
  # - host: signoz-signoz-zookeeper
  #   port: 2181

  # -- Toleration labels for clickhouse pod assignment
  tolerations: []
  # -- Affinity settings for clickhouse pod
  affinity: {}
  # -- Clickhouse resource requests/limits. See more at http://kubernetes.io/docs/user-guide/compute-resources/
  resources: {}
  #   limits:
  #     cpu: 4000m
  #     memory: 16Gi
  #   requests:
  #     cpu: 1000m
  #     memory: 5Gi
  securityContext:
    enabled: true
    runAsUser: 101
    runAsGroup: 101
    fsGroup: 101

  # -- Service Type: LoadBalancer (allows external access) or NodePort (more secure, no extra cost)
  serviceType: ClusterIP

  # -- If enabled, operator will prefer k8s nodes with tag `clickhouse:true`
  useNodeSelector: false

  persistence:
    # -- Enable data persistence using PVC.
    enabled: true

    # -- Use a manually managed Persistent Volume and Claim.
    #    If defined, PVC must be created manually before volume will be bound.
    #
    existingClaim: ""

    # -- Persistent Volume Storage Class to use.
    #    If defined, `storageClassName: <storageClass>`.
    #    If set to `storageClassName: ""`, disables dynamic provisioning.
    #    If undefined (the default) or set to `null`, no storageClassName spec is
    #    set, choosing the default provisioneralertmanager
    # -- Persistent Volume size
    size: 20Gi

  ## -- Clickhouse user profile configuration.
  ## You can use this to override settings, for example `default/max_memory_usage:<PHONE_NUMBER>0`
  ## For a full list of clickhouse settings, see https://clickhouse.com/docs/en/operations/settings/settings/
  profiles: {}

  ## -- Default user profile configuration for Clickhouse. Don't overwrite this!
  defaultProfiles:
    default/allow_experimental_window_functions: "1"

  ###
  ###
  ### ---- MISC ----
  ###
  ###

  # When the `installCustomStorageClass` is enabled with `cloud` set as `gcp` or `aws`,
  # it creates custom storage class with volume expansion permission.
  installCustomStorageClass: false

  # cold storage configuration
  coldStorage:
    enabled: false
    # Set free space size on default disk
    defaultKeepFreeSpaceBytes: "10485760"   # 10MiB
    endpoint: https://<bucket-name>.s3.amazonaws.com/data/
    role:
      enabled: false
      annotations:
        # aws role arn
        eks.amazonaws.com/role-arn: arn:aws:iam::******:role/*****
    accessKey: <access_key_id>
    secretAccess: <secret_access_key>
  # ClickhouseOperator node selector
  clickhouseOperator:
    nodeSelector: {}

## External clickhouse configuration
## This is required when clickhouse.enabled is false
##
externalClickhouse:
  # -- Host of the external cluster.
  host:
  # -- Name of the external cluster to run DDL queries on.
  cluster: cluster
  # -- Database name for the external cluster
  database: signoz_metrics
  # -- Clickhouse trace database (SigNoz Traces)
  traceDatabase: signoz_traces
  # -- User name for the external cluster to connect to the external cluster as
  user: ""
  # -- Password for the cluster. Ignored if existingClickhouse.existingSecret is set
  password: ""
  # -- Name of an existing Kubernetes secret object containing the password
  existingSecret:
  # -- Name of the key pointing to the password in your Kubernetes secret
  existingSecretPasswordKey:
  # -- Whether to use TLS connection connecting to ClickHouse
  secure: false
  # -- Whether to verify TLS connection connecting to ClickHouse
  verify: false
    # -- HTTP port of Clickhouse
  httpPort: 8123
  # -- TCP port of Clickhouse
  tcpPort: 9000

# Default values for query-service
queryService:
  name: "query-service"
  replicaCount: 1
  image:
    registry: docker.io
    repository: signoz/query-service
    tag: 0.8.2
    pullPolicy: IfNotPresent
  imagePullSecrets: []
  serviceAccount:
    # Specifies whether a service account should be created
    create: true
    # Annotations to add to the service account
    annotations: {}
    # The name of the service account to use.
    # If not set and create is true, a name is generated using the fullname template
    name:
  initContainers:
    init:
      enabled: true
      image:
        registry: docker.io
        repository: busybox
        tag: 1.35
        pullPolicy: IfNotPresent
      command:
        delay: 5
        endpoint: /ping
        waitMessage: "waiting for clickhouseDB"
        doneMessage: "clickhouse ready, starting query service now"
  configVars:
    storage: clickhouse
    # ClickHouse URL is set and applied internally.
    # Don't override unless you know what you are doing.
    # clickHouseUrl: tcp://my-release-clickhouse:9000/?database=signoz_traces&username=clickhouse_operator&password=clickhouse_operator_password
    goDebug: netdns=go
    telemetryEnabled: true
    deploymentType: kubernetes-helm

  podSecurityContext:
    {}
    # fsGroup: 2000

  securityContext:
    {}
    # capabilities:
    #   drop:
    #   - ALL
    # readOnlyRootFilesystem: true
    # runAsNonRoot: true
    # runAsUser: 1000

  service:
    type: ClusterIP
    port: 8080
    internalPort: 8085

  ingress:
    enabled: false
    annotations:
      {}
      # kubernetes.io/ingress.class: nginx
      # kubernetes.io/tls-acme: "true"
    hosts:
      - host: chart-example.local
        paths: []
    tls: []
    #  - secretName: chart-example-tls
    #    hosts:
    #      - chart-example.local

  # adjust the resource requests and limit as necessary
  resources:
    requests:
      cpu: 200m
      memory: 300Mi
    limits:
      cpu: 750m
      memory: 1000Mi

  nodeSelector: {}

  tolerations: []

  affinity: {}

# Default values for frontend
frontend:
  name: "frontend"
  replicaCount: 1

  image:
    registry: docker.io
    repository: signoz/frontend
    tag: 0.8.2
    pullPolicy: IfNotPresent
  imagePullSecrets: []
  serviceAccount:
    # Specifies whether a service account should be created
    create: true
    # Annotations to add to the service account
    annotations: {}
    # The name of the service account to use.
    # If not set and create is true, a name is generated using the fullname template
    name:

  initContainers:
    init:
      enabled: true
      image:
        registry: docker.io
        repository: busybox
        tag: 1.35
        pullPolicy: IfNotPresent
      command:
        delay: 5
        endpoint: /api/v1/version
        waitMessage: "waiting for query-service"
        doneMessage: "clickhouse ready, starting frontend now"

  configVars: {}

  podSecurityContext:
    {}
    # fsGroup: 2000

  securityContext:
    {}
    # capabilities:
    #   drop:
    #   - ALL
    # readOnlyRootFilesystem: true
    # runAsNonRoot: true
    # runAsUser: 1000

  service:
    type: ClusterIP
    port: 3301

  ingress:
    enabled: false
    annotations:
      {}
      # kubernetes.io/ingress.class: nginx
      # kubernetes.io/tls-acme: "true"
    hosts:
      - host: frontend.domain.com
        paths:
          - path: /
            pathType: ImplementationSpecific
    tls: []
    #  - secretName: chart-example-tls
    #    hosts:
    #      - chart-example.local

  # adjust the resource requests and limit as necessary
  resources:
    requests:
      cpu: 100m
      memory: 100Mi
    limits:
      cpu: 200m
      memory: 200Mi

  nodeSelector: {}

  tolerations: []

  affinity: {}

# Default values for Alertmanager
alertmanager:
  name: "alertmanager"
  replicaCount: 1

  image:
    registry: docker.io
    repository: signoz/alertmanager
    pullPolicy: IfNotPresent
    # Overrides the image tag whose default is the chart appVersion.
    tag: 0.23.0-0.1

  command: []
  extraArgs: {}

  imagePullSecrets: []

  service:
    annotations: {}
    type: ClusterIP
    port: 9093
    # if you want to force a specific nodePort. Must be use with service.type=NodePort
    # nodePort:

  serviceAccount:
    # Specifies whether a service account should be created
    create: true
    # Annotations to add to the service account
    annotations: {}
    # The name of the service account to use.
    # If not set and create is true, a name is generated using the fullname template
    name:

  initContainers:
    init:
      enabled: true
      image:
        registry: docker.io
        repository: busybox
        tag: 1.35
        pullPolicy: IfNotPresent
      command:
        delay: 5
        endpoint: /api/v1/version
        waitMessage: "waiting for query-service"
        doneMessage: "clickhouse ready, starting alertmanager now"

  podSecurityContext:
    fsGroup: 65534
  dnsConfig: {}
    # nameservers:
    #   - <IP_ADDRESS>
    # searches:
    #   - ns1.svc.cluster-domain.example
    #   - my.dns.search.suffix
    # options:
    #   - name: ndots
    #     value: "2"
    #   - name: edns0
  securityContext:
    # capabilities:
    #   drop:
    #   - ALL
    # readOnlyRootFilesystem: true
    runAsUser: 65534
    runAsNonRoot: true
    runAsGroup: 65534

  additionalPeers: []

  livenessProbe:
    httpGet:
      path: /
      port: http

  readinessProbe:
    httpGet:
      path: /
      port: http

  ingress:
    enabled: false
    className: ""
    annotations: {}
      # kubernetes.io/ingress.class: nginx
      # kubernetes.io/tls-acme: "true"
    hosts:
      - host: alertmanager.domain.com
        paths:
          - path: /
            pathType: ImplementationSpecific
    tls: []
    #  - secretName: chart-example-tls
    #    hosts:
    #      - alertmanager.domain.com

  resources:
    # adjust the resource requests and limit as necessary
    requests:
      cpu: 100m
      memory: 100Mi
    limits:
      cpu: 200m
      memory: 200Mi

  nodeSelector: {}

  tolerations: []

  affinity: {}

  statefulSet:
    annotations: {}

  podAnnotations: {}
  podLabels: {}

  # Ref: https://kubernetes.io/docs/tasks/run-application/configure-pdb/
  podDisruptionBudget: {}
    # maxUnavailable: 1
    # minAvailable: 1

  persistence:
    enabled: true
    ## Persistent Volume Storage Class
    ## If defined, storageClassName: <storageClass>
    ## If set to "-", storageClassName: "", which disables dynamic provisioning
    ## If undefined (the default) or set to null, no storageClassName spec is
    ## set, choosing the default provisioner.
    ##
    # storageClass: "-"
    accessModes:
      - ReadWriteOnce
    size: 100Mi

  ## Using the config, alertmanager.yml file is created.
  ## We no longer need the config file as query services
  ## delivers the required config.
  # config:
    # global:
    #   resolve_timeout: 1m
    #   slack_api_url: 'https://hooks.slack.com/services/xxx'

    # templates:
    #   - '/etc/alertmanager/*.tmpl'

    # receivers:
    # - name: 'slack-notifications'
    #   slack_configs:
    #   - channel: '#alerts'
    #     send_resolved: true
    #     icon_url: https://avatars3.githubusercontent.com/u/3380462
    #     title: '{{ template "slack.title" . }}'
    #     text: '{{ template "slack.text" . }}'

    # route:
    #   receiver: 'slack-notifications'

  ## Templates are no longer needed as they are included
  ## from frontend placeholder while creating alert channels.
  # templates:
  #   title.tmpl: |-
  #       {{ define "slack.title" }}
  #       [{{ .Status | toUpper }}{{ if eq .Status "firing" }}:{{ .Alerts.Firing | len }}{{ end }}] {{ .CommonLabels.alertname }} for {{ .CommonLabels.job }}
  #       {{- if gt (len .CommonLabels) (len .GroupLabels) -}}
  #         {{" "}}(
  #         {{- with .CommonLabels.Remove .GroupLabels.Names }}
  #           {{- range $index, $label := .SortedPairs -}}
  #             {{ if $index }}, {{ end }}
  #             {{- $label.Name }}="{{ $label.Value -}}"
  #           {{- end }}
  #         {{- end -}}
  #         )
  #       {{- end }}
  #       {{ end }}
  #   text.tmpl: |-
  #       {{ define "slack.text" }}
  #       {{ range .Alerts -}}
  #       *Alert:* {{ .Labels.alertname }}{{ if .Labels.severity }} - `{{ .Labels.severity }}`{{ end }}

  #       *Summary:* {{ .Annotations.summary }}
  #       *Description:* {{ .Annotations.description }}

  #       *Details:*
  #         {{ range .Labels.SortedPairs }} • *{{ .Name }}:* `{{ .Value }}`
  #         {{ end }}
  #       {{ end }}
  #       {{ end }}

  ## Monitors ConfigMap changes and POSTs to a URL
  ## Ref: https://github.com/jimmidyson/configmap-reload
  ##
  configmapReload:
    ## If false, the configmap-reload container will not be deployed
    ##
    enabled: false

    ## configmap-reload container name
    ##
    name: configmap-reload

    ## configmap-reload container image
    ##
    image:
      repository: jimmidyson/configmap-reload
      tag: v0.5.0
      pullPolicy: IfNotPresent

    # containerPort: 9533

    ## configmap-reload resource requests and limits
    ## Ref: http://kubernetes.io/docs/user-guide/compute-resources/
    ##
    resources: {}

# Default values for OtelCollector
otelCollector:
  name: "otel-collector"
  image:
    registry: docker.io
    repository: signoz/otelcontribcol
    tag: 0.45.1-0.3
    pullPolicy: Always
  serviceType: "ClusterIP"
  imagePullSecrets: []
  serviceAccount:
    # Specifies whether a service account should be created
    create: true
    # Annotations to add to the service account
    annotations: {}
    # The name of the service account to use.
    # If not set and create is true, a name is generated using the fullname template
    name:
  minReadySeconds: 5
  progressDeadlineSeconds: 120
  replicaCount: 1
  ballastSizeMib: 683
  initContainers:
    init:
      enabled: true
      image:
        registry: docker.io
        repository: busybox
        tag: 1.35
        pullPolicy: IfNotPresent
      command:
        delay: 5
        endpoint: /ping
        waitMessage: "waiting for clickhouseDB"
        doneMessage: "clickhouse ready, starting otel collector now"
  # ports used by the container
  ports:
    zPages: 55679                     # Default endpoint for ZPages.
    otelGrpcReceiver: 4317            # Default endpoint for OpenTelemetry gRPC receiver.
    otelHttpReceiver: 4318            # Default endpoint for OpenTelemetry HTTP receiver.
    otelGrpcLegacyReceiver: 55680     # Default endpoint for OpenTelemetry gRPC legacy receiver.
    otelHttpLegacyReceiver: 55681     # Default endpoint for OpenTelemetry HTTP/1.0 legacy receiver.
    jaegerGrpcReceiver: 14250         # Default endpoint for Jaeger GRPC receiver.
    jaegerHttpReceiver: 14268         # Default endpoint for Jaeger HTTP receiver.
    zipkinReceiver: 9411              # Default endpoint for Zipkin receiver.
    queryingMetrics: 8888             # Default endpoint for querying metrics.
    prometheusExportedMetrics: 8889   # Default endpoint for prometheus exported metrics.

  ## Configure liveness and readiness probes.
  ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes
  ##
  livenessProbe:
    enabled: false
    port: 13133
    path: /
    initialDelaySeconds: 5
    periodSeconds: 10
    timeoutSeconds: 5
    failureThreshold: 6
    successThreshold: 1
  readinessProbe:
    enabled: false
    port: 13133
    path: /
    initialDelaySeconds: 5
    periodSeconds: 10
    timeoutSeconds: 5
    failureThreshold: 6
    successThreshold: 1

  ## Custom liveness and readiness probes
  customLivenessProbe: {}
  customReadinessProbe: {}

  # adjust the resource requests and limit as necessary
  resources:
    requests:
      cpu: 200m
      memory: 400Mi
    limits:
      cpu: 1000m
      memory: 2Gi

  nodeSelector: {}

  tolerations: []

  affinity: {}

  # configurations to form the file in configmap
  config:
    receivers:
      otlp/spanmetrics:
        protocols:
          grpc:
            endpoint: localhost:12345
      otlp:
        protocols:
          grpc:
            endpoint: <IP_ADDRESS>:4317
          http:
            endpoint: <IP_ADDRESS>:4318
      jaeger:
        protocols:
          grpc:
            endpoint: <IP_ADDRESS>:14250
          thrift_http:
            endpoint: <IP_ADDRESS>:14268
      hostmetrics:
        collection_interval: 30s
        scrapers:
          cpu: {}
          load: {}
          memory: {}
          disk: {}
          filesystem: {}
          network: {}
    processors:
      batch:
        send_batch_size: 1000
        timeout: 10s
      signozspanmetrics/prometheus:
        metrics_exporter: prometheus
        latency_histogram_buckets: [100us, 1ms, 2ms, 6ms, 10ms, 50ms, 100ms, 250ms, 500ms, 1000ms, 1400ms, 2000ms, 5s, 10s, 20s, 40s, 60s]
        dimensions_cache_size: 10000
        dimensions:
        - name: service.namespace
          default: default
        - name: deployment.environment
          default: default
      # memory_limiter:
      #   # 80% of maximum memory up to 2G
      #   limit_mib: 1500
      #   # 25% of limit up to 2G
      #   spike_limit_mib: 512
      #   check_interval: 5s
      #
      #   # 50% of the maximum memory
      #   limit_percentage: 50
      #   # 20% of max memory usage spike expected
      #   spike_limit_percentage: 20
      # queued_retry:
      #   num_workers: 4
      #   queue_size: 100
      #   retry_on_failure: true
    extensions:
      health_check: {}
      zpages: {}
    exporters:
      clickhousetraces:
        datasource: tcp://${CLICKHOUSE_HOST}:${CLICKHOUSE_PORT}/?database=${CLICKHOUSE_TRACE_DATABASE}&username=${CLICKHOUSE_USER}&password=${CLICKHOUSE_PASSWORD}
      clickhousemetricswrite:
        endpoint: tcp://${CLICKHOUSE_HOST}:${CLICKHOUSE_PORT}/?database=${CLICKHOUSE_DATABASE}&username=${CLICKHOUSE_USER}&password=${CLICKHOUSE_PASSWORD}
        resource_to_telemetry_conversion:
          enabled: true
      prometheus:
        endpoint: "<IP_ADDRESS>:8889"
    service:
      extensions: [health_check, zpages]
      pipelines:
        traces:
          receivers: [jaeger, otlp]
          processors: [signozspanmetrics/prometheus, batch]
          exporters: [clickhousetraces]
        metrics:
          receivers: [otlp, hostmetrics]
          processors: [batch]
          exporters: [clickhousemetricswrite]
        metrics/spanmetrics:
          receivers: [otlp/spanmetrics]
          exporters: [prometheus]

# Default values for OtelCollectorMetrics
otelCollectorMetrics:
  name: "otel-collector-metrics"
  image:
    registry: docker.io
    repository: signoz/otelcontribcol
    tag: 0.45.1-0.3
    pullPolicy: Always
  imagePullSecrets: []
  serviceType: "ClusterIP"
  serviceAccount:
    # Specifies whether a service account should be created
    create: true
    # Annotations to add to the service account
    annotations: {}
    # The name of the service account to use.
    # If not set and create is true, a name is generated using the fullname template
    name:

  minReadySeconds: 5
  progressDeadlineSeconds: 120
  replicaCount: 1
  ballastSizeMib: 683
  initContainers:
    init:
      enabled: true
      image:
        registry: docker.io
        repository: busybox
        tag: 1.35
        pullPolicy: IfNotPresent
      command:
        delay: 5
        endpoint: /ping
        waitMessage: "waiting for clickhouseDB"
        doneMessage: "clickhouse ready, starting otel collector metrics now"

  # ports used by the container
  ports:
    zPages: 55679                   # Default endpoint for ZPages.
    otelGrpcReceiver: 4317          # Default endpoint for OpenTelemetry gRPC receiver.
    otelHttpReceiver: 4318          # Default endpoint for OpenTelemetry HTTP receiver.
    otelGrpcLegacyReceiver: 55680   # Default endpoint for OpenTelemetry gRPC legacy receiver.
    otelHttpLegacyReceiver: 55681   # Default endpoint for OpenTelemetry HTTP/1.0 legacy receiver.
    jaegerGrpcReceiver: 14250       # Default endpoint for Jaeger GRPC receiver.
    jaegerHttpReceiver: 14268       # Default endpoint for Jaeger HTTP receiver.
    zipkinReceiver: 9411            # Default endpoint for Zipkin receiver.
    queryingMetrics: 8888           # Default endpoint for querying metrics.

  ## Configure liveness and readiness probes.
  ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes
  ##
  livenessProbe:
    enabled: false
    port: 13133
    path: /
    initialDelaySeconds: 5
    periodSeconds: 10
    timeoutSeconds: 5
    failureThreshold: 6
    successThreshold: 1
  readinessProbe:
    enabled: false
    port: 13133
    path: /
    initialDelaySeconds: 5
    periodSeconds: 10
    timeoutSeconds: 5
    failureThreshold: 6
    successThreshold: 1

  ## Custom liveness and readiness probes
  customLivenessProbe: {}
  customReadinessProbe: {}

  # adjust the resource requests and limit as necessary
  resources:
    requests:
      cpu: 200m
      memory: 400Mi
    limits:
      cpu: 1000m
      memory: 2Gi

  nodeSelector: {}

  tolerations: []

  affinity: {}

  # configurations to form the file in configmap
  config:
    receivers:
      otlp:
        protocols:
          grpc:
            endpoint: <IP_ADDRESS>:4317
          http:
            endpoint: <IP_ADDRESS>:4318
      # Data sources: metrics
      prometheus:
        config:
          scrape_configs:
            - job_name: otel-collector
              scrape_interval: 30s
              static_configs:
                - targets:
                  # the following string is replaced with OTel service name using the helper template
                  - $OTEL_COLLECTOR_PROMETHEUS
    processors:
      batch:
        send_batch_size: 1000
        timeout: 10s
      # memory_limiter:
      #   # 80% of maximum memory up to 2G
      #   limit_mib: 1500
      #   # 25% of limit up to 2G
      #   spike_limit_mib: 512
      #   check_interval: 5s
      #
      #   # 50% of the maximum memory
      #   limit_percentage: 50
      #   # 20% of max memory usage spike expected
      #   spike_limit_percentage: 20
      # queued_retry:
      #   num_workers: 4
      #   queue_size: 100
      #   retry_on_failure: true
    extensions:
      health_check: {}
      zpages: {}
    exporters:
      clickhousemetricswrite:
        endpoint: tcp://${CLICKHOUSE_HOST}:${CLICKHOUSE_PORT}/?database=${CLICKHOUSE_DATABASE}&username=${CLICKHOUSE_USER}&password=${CLICKHOUSE_PASSWORD}
    service:
      extensions: [health_check, zpages]
      pipelines:
        metrics:
          receivers: [otlp, prometheus]
          processors: [batch]
          exporters: [clickhousemetricswrite]

try running helm template . in signoz  chart path

╰─ helm template . --debug                                                                                ─╯
install.go:173: [debug] Original chart version: ""
install.go:190: [debug] CHART PATH: /home///***/charts/charts/signoz
Error: parse error at (signoz/templates/otel-collector-metrics/config.yaml:9): unexpected unclosed action in command
helm.go:81: [debug] parse error at (signoz/templates/otel-collector-metrics/config.yaml:9): unexpected unclosed action in comman

@medicharlachiranjeevi can you share the versions of K8s and Helm?
Also output of the following?
helm template my-release -s templates/otel-collector-metrics/config.yaml signoz/signoz

Error: parse error at (signoz/templates/otel-collector-metrics/config.yaml:9): unexpected unclosed action in command

Use --debug flag to render out invalid YAML```

helm version:
`version.BuildInfo{Version:"v3.5.2", GitCommit:"167aac70832d3a384f65f9745335e9fb40169dc2", GitTreeState:"dirty", GoVersion:"go1.15.7"}`

kubectl version:
`
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.5", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-03-18T01:10:43Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.12-eks-a64ea69", GitCommit:"d4336843ba36120e9ed1491fddff5f2fec33eb77", GitTreeState:"clean", BuildDate:"2022-05-12T18:29:27Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}

`

@medicharlachiranjeevi  Works for me:

Possible it could be issue with older version of ARGOCD - as I don't see configurations which are set as blank or {} by default.

Ha might be we are using 2.2.5 which version u had tried deployed?

I used v2.4.0.
Deployed using the following manifest:
https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml

Closing this issue.
Feel free to re-open if you think the issue is not resolved on the latest version.


[Snyk] Upgrade @babel/core from 7.24.7 to 7.24.9

Snyk has created this PR to upgrade @babel/core from 7.24.7 to 7.24.9.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.

The recommended version was released on 23 days ago.

Release notes

Package name: @babel/core

7.24.9 - 2024-07-15v7.24.9 (2024-07-15)
🐛 Bug Fix

babel-core, babel-standalone

#16639 Avoid require() call in @ babel/standalone bundle (@ nicolo-ribaudo)

babel-types

#16638 fix: provide legacy typings for TS < 4.1 (@ JLHwung)

💅 Polish

babel-generator, babel-plugin-transform-optional-chaining

#16617 Avoid extra parens in TS as/satisfies (@ nicolo-ribaudo)

🏠 Internal

babel-helper-module-transforms

#16629 Lazy top-level initializations for module transforms (@ guybedford)

Committers: 5

Babel Bot (@ babel-bot)
Guy Bedford (@ guybedford)
Huáng Jùnliàng (@ JLHwung)
Nicolò Ribaudo (@ nicolo-ribaudo)
@ liuxingbaoyu

7.24.8 - 2024-07-11v7.24.8 (2024-07-11)
Thanks @ H0onnn, @ jkup and @ SreeXD for your first pull requests!
👓 Spec Compliance

babel-parser

#16567 Do not use strict mode in TS declare (@ liuxingbaoyu)

🐛 Bug Fix

babel-generator

#16630 Correctly print parens around in in for heads (@ nicolo-ribaudo)
#16626 Fix printing of comments in await using (@ nicolo-ribaudo)
#16591 fix typescript code generation for yield expression inside type expre… (@ SreeXD)

babel-parser

#16613 Disallow destructuring assignment in using declarations (@ H0onnn)
#16490 fix: do not add .value: undefined to regexp literals (@ liuxingbaoyu)

babel-types

#16615 Remove boolean props from ObjectTypeInternalSlot visitor keys (@ nicolo-ribaudo)

babel-plugin-transform-typescript

#16566 fix: Correctly handle export import x = (@ liuxingbaoyu)

💅 Polish

babel-generator

#16625 Avoid unnecessary parens around async in for await (@ nicolo-ribaudo)

babel-traverse

#16619 Avoid checking Scope.globals multiple times (@ liuxingbaoyu)

Committers: 9

Amjad Yahia Robeen Hassan (@ amjed-98)
Babel Bot (@ babel-bot)
Huáng Jùnliàng (@ JLHwung)
Jon Kuperman (@ jkup)
Nagendran N (@ SreeXD)
Nicolò Ribaudo (@ nicolo-ribaudo)
Sukka (@ SukkaW)
@ H0onnn
@ liuxingbaoyu

7.24.7 - 2024-06-05v7.24.7 (2024-06-05)
🐛 Bug Fix

babel-node

#16554 Allow extra flags in babel-node (@ nicolo-ribaudo)

babel-traverse

#16522 fix: incorrect constantViolations with destructuring (@ liuxingbaoyu)

babel-helper-transform-fixture-test-runner, babel-plugin-proposal-explicit-resource-management

#16524 fix: Transform using in switch correctly (@ liuxingbaoyu)

🏠 Internal

babel-helpers, babel-runtime-corejs2, babel-runtime-corejs3, babel-runtime

#16525 Delete unused array helpers (@ blakewilson)

Committers: 7

Amjad Yahia Robeen Hassan (@ amjed-98)
Babel Bot (@ babel-bot)
Blake Wilson (@ blakewilson)
Huáng Jùnliàng (@ JLHwung)
Nicolò Ribaudo (@ nicolo-ribaudo)
Sukka (@ SukkaW)
@ liuxingbaoyu

    from @babel/core GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

merged manualy
to 7.26.0


Json xml

Closes #15
Changes/Additions:

Deserialization an serialization from json of each sample type
Moved  everything into own file
Added jsdoc documentation

@KamyaPA I don't know if this is something that you want to work on yourself? I can also add an issue, and we can put it into our sprint at some point :)

Btw, it is hard to search for ? because there will be a thousand lines of code that is using the questionmark legitimately. It is much better to use TODO, as that will only be present in places where there is work to be done.


how to read the converted sql string

is there a way to find out how the language converted to the final sql string?
for example:
  var queryParams = new
    {
        FirstName = "John",
        Street = "Creek Street"
    };

    var persons = dbConnection.Find<Person>(statement => statement
        .WithAlias("person")
        .Include<Address>(join => join.InnerJoin()
                                      .WithAlias("address"))
        .Where($@"
           {nameof(Person.FirstName):of person} = {nameof(queryParams.FirstName):P}
           AND {nameof(Address.Street):of address} = {nameof(queryParams.Street):P}")
        .OrderBy($"{nameof(Person.LastName):of person} DESC")
        .Skip(10)
        .Top(20)
        .WithParameters(queryParams);

what the code above finally convert to the sql string , can we debug to see the sql string?
most of the time sql string is easy to read & write, but how to convert the two language?
as I mentioned https://github.com/MoonStorm/FastCrud/issues/178
the fastcrud is not user friendly enough.

FastCrud lives on top of Dapper which lives on top of ADO.NET. You can use the regular tracing tools in your favorite IDE for capturing ADO.NET events. As the last resort you can also profile the TSQL that goes through your favorite database server.


${cwd} in contributed pattern matchers doesn't use task's cwd option

VSCode Version: 1.31.1 and master
OS Version: Ubuntu 18.04

Steps to Reproduce:

Create a contributed pattern matcher that uses ${cwd} in the fileLocation
Create a build that generates relative paths

The relative paths end up being relative to the workspaceFolder, not to the cwd option of the task. I must have misread the Variables Reference since I had assumed ${cwd} would be of the task. It would sure help if it was from the task.

Duplicate of #58980


Money not being looted.

Money isn't being looted. I can't find any reports of this issue, so I have no idea what's going on.

Money isn't being looted. I can't find any reports of this issue, so I have no idea what's going on.

With this information, it will be difficult for a person to reproduce the problem and for us to determine the problem that exists. Or perhaps, due to the time that has passed, this problem no longer exists and the module is currently working fine. If the problem persists, please re-create an issue by filling in all the data in the form, so that we can have a little more information and be able to solve the problem. Thank you.


Removed volume mounts from compose files

removed volume mounts per issue #148

Need to have authentication part

I think we'll want to have one Compose file that does still have the volume mounts, specifically to show the dev use case. What I'd propose is copying the current docker-compose-simple.yml to docker-compose-dev.yml and then we can take the mounts out of the other files.

Sorry no one responded a year ago.  I'm going to close this, but if you'd like to submit a small PR, please open a ticket for a problem you'd like to solve first, and that way we can ensure the PR focuses on a single fix, thanks!

My bad... I had completely forgotten about this PR, and recently I started using my fork as the basis for some experimentation.  My apologies that these recent edits got pushed back into the PR


Use url_launcher plugin in Flutter Gallery

You'll have to revert some recent changes to flutter_gallery: https://github.com/flutter/flutter/pull/9770

I think this PR also fixes https://github.com/flutter/flutter/issues/7928


Refactor into separate package and extract constants

As requested.

LGTM 👍 .

@bergerdenes can you please squash your commits?
(I prefer separate commits when addressing review comments, or to indicate logically separate sub-changes, as they make reviews easier.  But unfortunately this repo does not allow "Squash and merge" for PRs.)

To be continued in #5009.


fix(overlay): remove overlay container on destroy

@crisbeto passed everywhere except browserstack. I changed the test to ensure that all overlay containers are remove with a beforeAll. Also got rid of body.

needs rebase


Websocket closes after being open

Anyone have a problem with websockets?  I have created my class but once i connect to the websocket, it close after about 2-3 seconds, with a code of 1006.
Here is my code, if anyone knows of anything i have done wrong.
import android.content.Context;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;

import com.google.gson.Gson;
import com.google.gson.GsonBuilder;

import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import fi.iki.elonen.NanoWSD;

public class MyHttpServer extends NanoWSD {
    private Context context;
    private static final int PORT = 8765;
    private List<MyWebSocket> connections = new ArrayList<MyWebSocket>();

    public MyHttpServer(Context context) throws IOException {
        super(PORT);
        this.context = context;
    }

    public List<MyWebSocket> getConnections() {
        return this.connections;
    }

    @Override
    protected WebSocket openWebSocket(IHTTPSession handshake) {
        return new MyWebSocket(handshake, this);
    }

    @Override
    public Response serveHttp(IHTTPSession session) {
        String url = session.getUri();

        // some custom code here for serving web responses

        return super.serve(session);
    }
}

And i have also created a webSocket class
import fi.iki.elonen.NanoWSD;

public class MyWebSocket extends NanoWSD.WebSocket {

    MyHttpServer httpServer;
    NanoHTTPD.IHTTPSession httpSession;

    public MyWebSocket(NanoHTTPD.IHTTPSession handshakeRequest, MyHttpServer httpServer) {
        super(handshakeRequest);
        this.httpSession = handshakeRequest;
        this.httpServer = httpServer;
    }

    @Override
    protected void onOpen() {
        httpServer.getConnections().add(this);
    }

    @Override
    protected void onClose(NanoWSD.WebSocketFrame.CloseCode code, String reason, boolean initiatedByRemote) {
        this.httpServer.getConnections().remove(this);
    }

    @Override
    protected void onMessage(NanoWSD.WebSocketFrame message) {

    }

    @Override
    protected void onPong(NanoWSD.WebSocketFrame pong) {

    }

    @Override
    protected void onException(IOException exception) {

    }
}

I am guessing this is all ok??  Why would the websocket be disconnecting after a couple seconds?

You MUST ping websockets. It's part of the protocol. That's how the server knows the client is still there.
Whoever created this implementation did not add any sort of automatical pinging, so you must do it manually.

@Gillardo What is your javascript implementation for webscoket

I'll just add that if you ping the socket from the server side clients will automatically pong. It has proven to be enough for me.

My websocket javscript implementation is very simple, its used for angular2 and looks like this.
import { Injectable } from '@angular/core';
import { Device } from './models/device';
import { Http } from '@angular/http';
import { DbService } from './db.service';

@Injectable()
export class WebsocketService {

    private url: string;
    private ws: WebSocket = null;

    constructor(
        private http: Http,
        private dbService: DbService) {

    }

    connect(device: Device) {
        if (this.ws == null || this.ws.readyState == WebSocket.CLOSED) {
            this.url = device.url;
            this.ws = new WebSocket(device.url.replace(/http:/g, 'ws:') + ':8766');

            // When a connection is made
            this.ws.onopen = () => { this.onOpen(); } ;

            // When data is received
            this.ws.onmessage = (e) => { this.onMessage(e); };

            // A connection could not be made
            this.ws.onerror = (e) => { this.onError(e); };

            // A connection was closed
            this.ws.onclose = (e) => { this.onClose(e); };
        }
    }

    disconnect() {
        if (this.ws) {
            this.ws.close();
        }
    }

    private onOpen() {
        console.log('Opened connection ');
    }

    private onMessage(event) {
        console.log('message received');
    }

    private onError(event) {
        console.log(event);
    }

    private onClose(reason: CloseEvent) {
        console.log(reason);
    }
}

All i need is for the client to open a connection and listen for a message.  Once a message is  received, the client will do something.  This works if i use java_websocket but i would rather use 1 framework, then 2

Have you checked for exceptions on the server side?

I have to bring this question up again: As far as I see none of the NodeJS oder Browser implementations of WebSocket clients seem to send out a ping - which causes java.net.SocketTimeoutException: Read timed out exceptions and connections breaks every five seconds on the server side. And as far as I see the server does not send any ping frames either. So could you please tell us how to properly keep a Websocket connection open?

On my implementation I spawn a thread that every n seconds loops the list of active sockets and pings them all.

@LordFokas be very interested in that code 😄

You see, my goal with the changes I attempted to introduce to NanoHTTPD in 3.0 were exactly aiming to allow setting up the system like a pipeline, where you can change components independently to add or modify behavior seamlessly in each stage. It still has a long way to go, and I'm not sure which version of the code I'm using here, it might be a commit somewhere between versions, but this should work regardless.

@LordFokas Thanks for providing your code - now I think I understand the behaviour a little bit better.

Feel free to give me feedback on it ;)

It's probably better to use a SecheduledExecutorService(Executors.newSingleThreadScheduledExecutor()) and call scheduleAtFixedRate() instead of implementing the thread yourself.

@NoahAndrews that's for when you want to write proper code that performs. I just hacked at it until it worked and stopped there, had way more pressing matters to attend to :p

Yeah, I get it. You did say this though:

Feel free to give me feedback on it ;)

Ah yes, I meant something more like if it didn't work as expected so I could have a look at my own mess

Gotcha gotcha. I'll probably post a link to my implementation once it's finished and publicly viewable, for anyone else who stumbles upon this issue.

I am also having the same difficulties. Is there a cleaner way to deal with the need to ping the sockets, than the one @LordFokas posted? It seems like a lot of trouble just to pacify NanoWSD into not closing the connection. I think perhaps this should be bumped from a question to a bug?

I simplified the code a bit by using java.util.Timer (Java 7), which seems to work well on Android.
    private TimerTask ping = null;

    @Override
    protected void onOpen() {
        if (ping == null) {
            ping = new TimerTask() {
                @Override
                public void run(){
                    try { ping(PING_PAYLOAD); }
                    catch (IOException e) { ping.cancel(); }
                }
            };
            new Timer().schedule(ping, 1000, 2000);
        }
    }

    @Override
    protected void onClose(NanoWSD.WebSocketFrame.CloseCode code, String reason, boolean initiatedByRemote) {
        if (ping != null) ping.cancel();
    }

Same thing here.. Simple FIX.
If you follow the class trail you end up at Line 165 of NanoHTTPD..
public static final int SOCKET_READ_TIMEOUT = 5000;
..Just change that.
OR.. better.. If you dig a little deeper you'll notice
public void start(final int timeout) throws IOException {
start(timeout, true);
}
And just the plain start() is called in the echosocket.. just switch it for the one where you specify a timeout.
It works.
Big Up LordFokas for sharing this great little project with all of us.. :)

I hope this PR is helpful for someone in trouble with WebSocket.
https://github.com/NanoHttpd/nanohttpd/pull/618


Bug: All zip types are accepted

I just tried to manually install a random zip file and it gave a success alert that the plugin is installed successfully. BUt the plugin does not show up anywhere obviously as it was just a random .zip of files unrelated to kanboard plugins.
I was expecting an error alert to say the zip file is not recognised.
@alfredbuehler Can you please have a look at that part of the code again?

I'd suspect the same with install by URL. I guess you should check for Plugin.php existence.

I think I did the same “verification” as KB does when installing a plugin. And this surely could be improved.
I'll do it, but is checking the existence of Plugin.php really sufficient?

It's definitely a minimumal check, but better than no check.

@alfredbuehler @creecros Can somebody please check this?  I don't think the file version is working... because I THINK it looks for Plugin.php and never finds it because it will be in a subfolder and I don't know how to check a dynamic subfolder

If I have broken the code due to converting to Kanboard syntax, just let me know so I can revert it to the original PR

There is little kanboard checks for the from file and no checks for the from url... I have done the from file but I dont know how to code the from url in https://github.com/aljawaid/PluginManager/blob/9541f546d4a8e9acf7675c94ef92e8bda89cc6e1/Controller/PluginManagerController.php#L54

It should be fixed by 38db9fcb576815d0b6391221ae57242752f65461

It should be fixed by 38db9fc

I dont understand the merge, will look at it properly from a computer tonight... I noticed you moved the redirects in each error... I did it that way because if the install fails for whatever reason, a user should return to the page it came from - manual plugins.... kanboard by habit, redirects to the installed page regardless of response which is wrong i believe.  I will put them back in for the erro messages once I can get my head around the changes.

the url, produces a zip, that meets all the criteria. your file does not. surely you can see that.

Are you sure the URL option is following the same tests?

Please see the code. The URL method calls the same method as for file, after downloading the archive.

Omitting the directory was not a great idea, you should assert that dirname == pluginname.
https://github.com/aljawaid/PluginManager/blob/master/Controller/PluginManagerController.php#L94

i just tested and both installed, obviously the folder name is incorrect to work, but they both installed it.

Omitting the directory was not a great idea, you should assert that dirname == pluginname.
https://github.com/aljawaid/PluginManager/blob/master/Controller/PluginManagerController.php#L94

Maybe I did it wrong then. I need help. I kitted the directory because plugin.php is in the subdirectory

i just tested and both installed, obviously the folder name is incorrect to work, but they both installed it.

Exactly but only as a success message, because of the wrong folder structure it will never install or show as installed but still give a success message.

Another solution could be, performing these checks after installing.

Dir name wrong: remove plugin & fail
Plugin.php missing: remove plugin & fail

i just tested and both installed, obviously the folder name is incorrect to work, but they both installed it.

Exactly but only as a success message, because of the wrong folder structure it will never install or show as installed but still give a success message.

i get the message for neither

I honestly don't know what to do
I will release it as it is and see if anyone reports anything.
Creecros says he got no error messages so that's baffled me more.

I will release it as it is and see if anyone reports anything.

No wait. I'll amend another check.


Support for spring-security-core 4.0.0

A few days ago Spring released version 4.0.0 of spring-security-core. spring-security-oauth still depends on 3.2.6.
Are there any plans to update the dependency soon? There's a migration path available: http://docs.spring.io/spring-security/site/migrate/current/3-to-4/html5/migrate-3-to-4-xml.html
Thanks in advance!

If anyone wants to try it, go ahead. My guess is that we might need to wait for 2.1 or 3.0 of the OAuth framework - it depends on the changes required to existing apps.

OK, thanks for the reply. I'll make a try in the next days against 4.0.0. I doubt it will be representative (small feature set, few unit tests...), but could be enough for a "will never run" statement ;-)

As expected from reading the migration guide it's not possible to simply replace the security JARs. For example, "access-denied-page" is no longer allowed for security:http elements.


Search Results in "Replace" mode has wide empty space on checkbox's column

Tested versions

Reproducible: 4.2.1.stable, 4.1.3.stable, 4.0.stable
Non-reproducible: 3.5.2.stable

System information
Windows 11 - Godot v4.2.1.stable
Issue description
When using the function "Find in Files" with "Replace..." mode, the following image happens.

(Alt: The checkbox column has the same length as the file path above, or the parent tree. Whilst a normal behaviour, it's untidy and can be done better with solution below.)
Issue mostly happens at this part of the file: https://github.com/godotengine/godot/blob/13a0d6e9b253654f5cc2a44f3d0b3cae10440443/editor/find_in_files.cpp#L635
The current code has the column set to NOT expand when space is available, but it expands possibly due to its parent/sibling column having long content (file path), causing the checkbox column to follow suit.
A possible fix would be including _results_display->set_column_clip_content(0, true); to the condition content of if (with_replace) { ... }, that will make the checkbox column & parent column to stay at the minimum size set without expanding. However, the parent column (file path) is already set to expanding to right but only to itself, regardless of sibling's width (later in the same file at line 720), so the fix won't affect the file path column.
But I've only tested it on my own plugin that has the same feature but in GDScript, so unsure if it'll work the same with the code above.
Edited:
Also, not actually sure if there's a bug introduced in 4.0, or some internal things changed but didn't get update in this file, the issue doesn't happen in 3.5.2.stable

Steps to reproduce
Perform a search for text residing inside a long file path name, and select "replace..." button to show the result.
Minimal reproduction project (MRP)
N/A

Not sure in which version, but this is already fixed by 4.3.rc3!
I don't see any changes in the latest find_in_files.cpp, so I guess it's on the tree.cpp itself somewhere.
I guess I can now close this thread? (Might need mod's helps on removing labels)


Broken Display and Interactivity

Hi, I tried to run your examples within Tests/ using PySide 1.2.4 (Windows 7 x64, Python 2.7.10 x64). The widget opens and I can see some sort of node graph, but its broken both in what it shows and also in that I cannot change anything. Any ideas why this may happen? Are you maybe using a different PySide version?

I recently saw this with Kraken which is built on top of Pyflow Graph and I had to use PySide 1.2.2

Thanks, I can run the examples now! I'll suggest making this a python package with a setup.py/requirements.txt to specify the dependency version and simplify the installation.


Explicit Installation of dotnet ef tool

According to an announcement from back in April the dotnet ef tool is no longer is no longer part of the .NET Core SDK. The tutorial should be updated to specify the explicit install of the dotnet ef tool before attempting to use the EF Core Migration feature.
dotnet tool install --global dotnet-ef --version 3.0.0
Announcement Reference: https://devblogs.microsoft.com/dotnet/announcing-entity-framework-core-3-0-preview-4/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d975a83-1550-b284-d0d8-7fe2ea206ff5
Version Independent ID: 48e81b42-7c2b-afbf-71e6-d4f442a4bd1f
Content: Add a model to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/adding-model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

That's what it says
dotnet tool install --global dotnet-ef
dotnet tool install --global dotnet-aspnet-codegenerator
dotnet add package Microsoft.EntityFrameworkCore.SQLite
dotnet add package Microsoft.VisualStudio.Web.CodeGeneration.Design
dotnet add package Microsoft.EntityFrameworkCore.Design
dotnet add package Microsoft.EntityFrameworkCore.SqlServer


tomowallet chush when trying to send tomos

Describe the bug
tomowallet crash when trying to send tomos
To Reproduce
Steps to reproduce the behavior:

Click on QR code on the tomowallet
Click on "enter a recipient address"
and tomowallet crashes

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots/Video
If applicable, add screenshots/video to help explain your problem.
Device specification (please complete the following information):

Device: Samsung Galaxy S7 edge]
TomoWallet version [V0.14.1]

fixed at version 0.14.4

Update perfectly corrected the issue! thanks Lê Mạnh Niên!


[FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test

The test was unstable because the broker tried to connect to ZK before ZK was running.
With this change, we wait for ZK to be running before proceeding.

Thanks a lot. Merging ...


language / script detection

In order to fill the language layer in the opfs we import from OCR, we are currently relying on the language tag returned by the ocr service. While this works reasonably well for Google Vision, the hocr files of Google Books only have that information at a page level, which is an issue when we have multiple language on a page (a title page of a modern print, with a Tibetan and a Chinese title for instance).
What we should do instead is have a script detection system. In a first iteration, we could only detect:

Chinese script, that we would tag with the language "zh"
Tibetan script, tagged "bo"
Devanagari script, tagged "sa-Deva"
letters (not numbers or symbols) in Latin script, tagged as "en"
the rest would be the default language

so that means I have write a regex to detect what language is the text belong to and put that as the Language in bbox, rather than parsing the page language info from the hocr or parising the paragraph language in IA format hocr right ?

correct yes, although you just need to detect the script, not the language

the latest Unicode data is on http://www.unicode.org/Public/UNIDATA/Scripts.txt . Oddly enough, I can't find a straightforward library in Python that would give the result directly... Note that the "common" script should be mapped to the default language

something like that should work to parse it: https://github.com/googlefonts/nototools/blob/main/nototools/unicode_data.py#L470
you can do this in the main OCR class since it's probably also something we want to do for Google Vision import

okay got it, thanks

A function that does exactly this in a very efficient way is fontTools.unicodedata.script(), let's use it
see https://github.com/fonttools/unicodedata2/issues/57


Fix absolute paths issue in Jest

This PR fixes #7818, by fixing the entry added to Jest's moduleNameMapper that unintentionally matched with paths that did not start with src.

Thanks!


dcm2niix: 1.0.20211006 -> 1.0.20230411

Description of changes
Update from fairly old previous version.
https://github.com/rordenlab/dcm2niix/releases/tag/v1.0.20230411
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Compliled and tested. Sadly not w/ sandbox due to https://github.com/NixOS/nix/issues/4119
However this is a low-risk project with only one python package declaring a depencency (is uses the binary).

Add a :+1: reaction to pull requests you find important.

Thanks very much for checking over. I didn't quite understand the issue at dcm_qa#9 - is this a separate issue or relevant for this PR? Let me know if anything requried.


Call of outputSetting with errorColor doesn't works

Hi,
I really like your plugin and use it on a project. Continue your good works.
Fix in resemble.js:
Line 721 remove if (options.hasOwnProperty(key)) {
Line 726 remove }
Without this fix it required to call outputSettings like this to works:
resembleControl.outputSettings({
errorColor: {
red: 255,
green: 0,
blue: 0
},
red: 255,
green: 0,
blue: 0
}).repaint();
Thanks

Thanks, I've added a test, and fixed the issue.


Find & Replace missing in v5

I can replace some text when I press Command + F in V4,
but there is only popup a browser find bar in V5,
my browser is chrome 61 on OSX 10.12.

Should be available in the v5.1.

@miaoyushun did this get implemented, do you know?  Can't seem to find it on v5.1.

@theoryshaw, you can use find & replace functionality by pressing mod+alt+f or mod+g. I found it by looking for the shortcuts on Menu/More../Settings/Default settings.

Wow, that's well hidden functionality. ;-)

@theoryshaw, you can use find & replace functionality by pressing mod+alt+f or mod+g. I found it by looking for the shortcuts on Menu/More../Settings/Default settings.

works, If can have a help page to see all the shortcut will be good!

find the default keymap, it is in the setting config:

# Keyboard shortcuts
# See https://craig.is/killing/mice
shortcuts:
  mod+s: sync
  mod+f: find
  mod+alt+f: replace
  mod+g: replace
  mod+shift+b: bold
  mod+shift+c: clist
  mod+shift+k: code
  mod+shift+h: heading
  mod+shift+r: hr
  mod+shift+g: image
  mod+shift+i: italic
  mod+shift+l: link
  mod+shift+o: olist
  mod+shift+q: quote
  mod+shift+s: strikethrough
  mod+shift+t: table
  mod+shift+u: ulist
  '= = > space':
    method: expand
    params:
    - '==> '
    - '⇒ '
  '< = = space':
    method: expand
    params:
    - '<== '
    - '⇐ '


fix: add docker.io creds to tekton-logging ns

Description
this should fix the konflux bootstrap issue recently seen on ROSA HCP cluster:
Failed to pull image "timberio/vector:0.42.0-distroless-libc": fetching target platform image selected from image index: reading manifest sha256:872e4daa04a347d61841cc387f0b56ea7e3031f9b2eb2ca2e0a936696d7def3c in docker.io/timberio/vector: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

The bootstrap issue was fixed, it failed on 2 unrelated test cases. Merging.


Unique base defenses roll

The bar and percentage for base defenses roll on uniques counts from zero to maximum roll, which means it never goes below 85%. You can instead utilize the whole range by counting from minimum roll, the same way as BaseDefensePercentile property on trade site and in loot filter.
For example:
Steel kite shield has base armor range 146 to 167, my shield has 147. The overlay displays it as 88% = 147 / 167. With proposed change, it will display as 5% = (147-146) / (167-146).
Mirrored spiked shield has base evasion range 151 to 174, mine has 168. The overlay shows 97% = 168 / 174. With proposed change, it will be 74% = (168-151) / (174-151).

Huh, I didn't know the trade site calculates it that way. I chose the current method because I felt that taking the absolute range as the basis and displaying such low percentages introduces unnecessary negative bias towards an item when the discrepancy between min and max is rather insignificant in reality (like the 20 armor in your example, and many others).
Another factor was data-base size: holding ALT in game shows the range of that roll, but it's not included when copying the item-info into clipboard. I had to build a custom data-base for item-bases, and I tried to keep it minimal in order to also keep loading-time low.
Thanks for bringing this to my attention, I'll do some testing. It's probably better to change it to be in line with official calculations. I really appreciate the inputs/suggestions I have received from you.

Alright, I have implemented the necessary changes. They'll be part of the next release.


Various methods can be made less accessible to increase encapsulation

I have noticed that the following methods are declared public:

AdbProtocalHandler.send()
DeviceWatcher.watch()
SyncTransport.readInt() and readString()
Transport.readString() on line 43 and getCommandLength()

Unless these methods are called by name via reflection, these members should be private to improve information hiding.
If this change is indeed regarded as desirable, I could make a PR for it.

DeviceWatcher.watch() I thought this was the actual function you called to watch for new connections?
AdbProtocalHandler.send() - Sure, sounds good :+1:
SyncTransport.readInt() and SyncTransport.readString() - Sure, sounds good :+1:
Transport.readString() - This should probably be used somewhere? Seems strange to me. Let's leave as public.

Thanks for checking in first. Looking forward to pr :-)


Triple generate with deprecated package

When generating a triple pattern project, the slide set a dev_dependencies deprecated flutter_modular_test instead of modular test.
Error after run flutter pub get.
Because flutter_modular_test >=1.0.2 depends on flutter_modular ^3.4.1+1 and teste depends on flutter_modular ^4.0.0+6, flutter_modular_test >=1.0.2 is forbidden. So, because teste depends on flutter_modular_test ^1.0.4, version solving failed. Running "flutter pub get" in teste...                                    pub get failed (1; So, because teste depends on flutter_modular_test ^1.0.4, version solving failed.)

I came here with the goal of opening this. Thank you.

updated


error TS2456: Type alias 'Resolved' circularly references itself.

node_modules/@azure/core-tracing/types/core-tracing.d.ts:81:21 - error TS2456: Type alias 'Resolved' circularly references itself.

81 export declare type Resolved<T> = T extends {
                       ~~~~~~~~

node_modules/@azure/core-tracing/types/core-tracing.d.ts:83:41 - error TS2315: Type 'Resolved' is not generic.

83 } ? F extends (value: infer V) => any ? Resolved<V> : never : T;
                                           ~~~~~~~~~~~

node_modules/@azure/core-tracing/types/core-tracing.d.ts:131:212 - error TS2315: Type 'Resolved' is not generic.

131     }, Callback extends (updatedOptions: Options, span: Omit<TracingSpan, "end">) => ReturnType<Callback>>(name: string, operationOptions: Options, callback: Callback, spanOptions?: TracingSpanOptions): Promise<Resolved<ReturnType<Callback>>>;

Following the MS Learn path but getting this when debugging the apis... I might have had a chance with JS, I have 0 TS knowledge

Run into the exact errors as noted - TS2456 once, TS2315 twice.

Resolved requires TS V4 according to https://github.com/Azure/azure-sdk-for-js/issues/21745

It worked for me when I updated the typescript version

Thanks @biofool

open a pull request?

It worked for me when I updated the typescript version in my package.json
Thanks @biofool

I had the same issue and this fix (updating the typescript version in the package.json) worked for me as well.

TypeScript level has been updated. Thanks for the feedback.