mo.ui.refresh and stopping long running code in a cell leads to "The Python kernel died unexpectedly."

Describe the bug
Hello,
when running the given Marino notebook, stopping a long running cell code (greater than refresh interval) stops Marino and raises:
The Python kernel died unexpectedly.

Kind regards
Environment
{
  "marimo": "0.2.8",
  "OS": "Windows",
  "OS Version": "10",
  "Processor": "Intel64 Family 6 Model 58 Stepping 9, GenuineIntel",
  "Python Version": "3.11.8",
  "Binaries": {
    "Chrome": "121.0.6167.189",
    "Node": "v21.1.0"
  },
  "Requirements": {
    "black": "24.2.0",
    "click": "8.1.7",
    "jedi": "0.19.1",
    "pymdown-extensions": "10.7",
    "starlette": "0.37.1",
    "tomlkit": "0.12.3",
    "typing_extensions": "4.9.0",
    "uvicorn": "0.27.1"
  }
}

Code to reproduce
refresh_sleep_and_dead_kernel.py
import marimo

__generated_with = "0.2.8"
app = marimo.App()

@app.cell
def __(mo):
    refresh_button = mo.ui.refresh(
        options=["1s"],
        default_interval="1s",
    )
    refresh_button
    return refresh_button,

@app.cell
def __(refresh_button, time):
    refresh_button
    time.sleep(5)
    return

@app.cell
def __():
    import time
    import marimo as mo
    return mo, time

if __name__ == "__main__":
    app.run()

marimo edit refresh_sleep_and_dead_kernel.py

stopping
refresh_button
time.sleep(5)

cell raises each time this error and notebook is stopped and needs to be run again.

Pluto.jl seems to resist to such a "badly coded" notebook
### A Pluto.jl notebook ###
# v0.19.39

using Markdown
using InteractiveUtils

# This Pluto notebook uses @bind for interactivity. When running this notebook outside of Pluto, the following 'mock version' of @bind gives bound variables a default value (instead of an error).
macro bind(def, element)
    quote
        local iv = try Base.loaded_modules[Base.PkgId(Base.UUID("6e696c72-6542-2067-7265-42206c756150"), "AbstractPlutoDingetjes")].Bonds.initial_value catch; b -> missing; end
        local el = $(esc(element))
        global $(esc(def)) = Core.applicable(Base.get, el) ? Base.get(el) : iv(el)
        el
    end
end

# ╔═╡ c5872ac3-a15f-45b8-8289-f7873b1650ae
using PlutoUI

# ╔═╡ 8b41c61e-d4a5-11ee-0643-17de92206bba
@bind ticks Clock(1, true)

# ╔═╡ 9f9e9664-f0c6-4767-9592-ec52d3447f13
begin
	ticks
	sleep(5)
end

# ╔═╡ 00000000-0000-0000-0000-000000000001
PLUTO_PROJECT_TOML_CONTENTS = """
[deps]
PlutoUI = "7f904dfe-b85e-4ff6-b463-dae2292396a8"

[compat]
PlutoUI = "~0.7.58"
"""

# ╔═╡ 00000000-0000-0000-0000-000000000002
PLUTO_MANIFEST_TOML_CONTENTS = """
# This file is machine-generated - editing it directly is not advised

julia_version = "1.10.1"
manifest_format = "2.0"
project_hash = "acf8a7d70217bc877a8d448fd5475fd91c6dd480"

[[deps.AbstractPlutoDingetjes]]
deps = ["Pkg"]
git-tree-sha1 = "c278dfab760520b8bb7e9511b968bf4ba38b7acc"
uuid = "6e696c72-6542-2067-7265-42206c756150"
version = "1.2.3"

[[deps.ArgTools]]
uuid = "0dad84c5-d112-42e6-8d28-ef12dabb789f"
version = "1.1.1"

[[deps.Artifacts]]
uuid = "56f22d72-fd6d-98f1-02f0-08ddc0907c33"

[[deps.Base64]]
uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

[[deps.ColorTypes]]
deps = ["FixedPointNumbers", "Random"]
git-tree-sha1 = "eb7f0f8307f71fac7c606984ea5fb2817275d6e4"
uuid = "3da002f7-5984-5a60-b8a6-cbb66c0b333f"
version = "0.11.4"

[[deps.CompilerSupportLibraries_jll]]
deps = ["Artifacts", "Libdl"]
uuid = "e66e0078-7015-5450-92f7-15fbd957f2ae"
version = "1.1.0+0"

[[deps.Dates]]
deps = ["Printf"]
uuid = "ade2ca70-3891-5945-98fb-dc099432e06a"

[[deps.Downloads]]
deps = ["ArgTools", "FileWatching", "LibCURL", "NetworkOptions"]
uuid = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
version = "1.6.0"

[[deps.FileWatching]]
uuid = "7b1f6079-737a-58dc-b8bc-7a2ca5c1b5ee"

[[deps.FixedPointNumbers]]
deps = ["Statistics"]
git-tree-sha1 = "335bfdceacc84c5cdf16aadc768aa5ddfc5383cc"
uuid = "53c48c17-4a7d-5ca2-90c5-79b7896eea93"
version = "0.8.4"

[[deps.Hyperscript]]
deps = ["Test"]
git-tree-sha1 = "179267cfa5e712760cd43dcae385d7ea90cc25a4"
uuid = "47d2ed2b-36de-50cf-bf87-49c2cf4b8b91"
version = "0.0.5"

[[deps.HypertextLiteral]]
deps = ["Tricks"]
git-tree-sha1 = "7134810b1afce04bbc1045ca1985fbe81ce17653"
uuid = "ac1192a8-f4b3-4bfe-ba22-af5b92cd3ab2"
version = "0.9.5"

[[deps.IOCapture]]
deps = ["Logging", "Random"]
git-tree-sha1 = "8b72179abc660bfab5e28472e019392b97d0985c"
uuid = "b5f81e59-6552-4d32-b1f0-c071b021bf89"
version = "0.2.4"

[[deps.InteractiveUtils]]
deps = ["Markdown"]
uuid = "b77e0a4c-d291-57a0-90e8-8db25a27a240"

[[deps.JSON]]
deps = ["Dates", "Mmap", "Parsers", "Unicode"]
git-tree-sha1 = "31e996f0a15c7b280ba9f76636b3ff9e2ae58c9a"
uuid = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
version = "0.21.4"

[[deps.LibCURL]]
deps = ["LibCURL_jll", "MozillaCACerts_jll"]
uuid = "b27032c2-a3e7-50c8-80cd-2d36dbcbfd21"
version = "0.6.4"

[[deps.LibCURL_jll]]
deps = ["Artifacts", "LibSSH2_jll", "Libdl", "MbedTLS_jll", "Zlib_jll", "nghttp2_jll"]
uuid = "deac9b47-8bc7-5906-a0fe-35ac56dc84c0"
version = "8.4.0+0"

[[deps.LibGit2]]
deps = ["Base64", "LibGit2_jll", "NetworkOptions", "Printf", "SHA"]
uuid = "76f85450-5226-5b5a-8eaa-529ad045b433"

[[deps.LibGit2_jll]]
deps = ["Artifacts", "LibSSH2_jll", "Libdl", "MbedTLS_jll"]
uuid = "e37daf67-58a4-590a-8e99-b0245dd2ffc5"
version = "1.6.4+0"

[[deps.LibSSH2_jll]]
deps = ["Artifacts", "Libdl", "MbedTLS_jll"]
uuid = "29816b5a-b9ab-546f-933c-edad1886dfa8"
version = "1.11.0+1"

[[deps.Libdl]]
uuid = "8f399da3-3557-5675-b5ff-fb832c97cbdb"

[[deps.LinearAlgebra]]
deps = ["Libdl", "OpenBLAS_jll", "libblastrampoline_jll"]
uuid = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

[[deps.Logging]]
uuid = "56ddb016-857b-54e1-b83d-db4d58db5568"

[[deps.MIMEs]]
git-tree-sha1 = "65f28ad4b594aebe22157d6fac869786a255b7eb"
uuid = "6c6e2e6c-3030-632d-7369-2d6c69616d65"
version = "0.1.4"

[[deps.Markdown]]
deps = ["Base64"]
uuid = "d6f4376e-aef5-505a-96c1-9c027394607a"

[[deps.MbedTLS_jll]]
deps = ["Artifacts", "Libdl"]
uuid = "c8ffd9c3-330d-5841-b78e-0817d7145fa1"
version = "2.28.2+1"

[[deps.Mmap]]
uuid = "a63ad114-7e13-5084-954f-fe012c677804"

[[deps.MozillaCACerts_jll]]
uuid = "14a3606d-f60d-562e-9121-12d972cd8159"
version = "2023.1.10"

[[deps.NetworkOptions]]
uuid = "ca575930-c2e3-43a9-ace4-1e988b2c1908"
version = "1.2.0"

[[deps.OpenBLAS_jll]]
deps = ["Artifacts", "CompilerSupportLibraries_jll", "Libdl"]
uuid = "4536629a-c528-5b80-bd46-f80d51c5b363"
version = "0.3.23+4"

[[deps.Parsers]]
deps = ["Dates", "PrecompileTools", "UUIDs"]
git-tree-sha1 = "8489905bcdbcfac64d1daa51ca07c0d8f0283821"
uuid = "69de0a69-1ddd-5017-9359-2bf0b02dc9f0"
version = "2.8.1"

[[deps.Pkg]]
deps = ["Artifacts", "Dates", "Downloads", "FileWatching", "LibGit2", "Libdl", "Logging", "Markdown", "Printf", "REPL", "Random", "SHA", "Serialization", "TOML", "Tar", "UUIDs", "p7zip_jll"]
uuid = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
version = "1.10.0"

[[deps.PlutoUI]]
deps = ["AbstractPlutoDingetjes", "Base64", "ColorTypes", "Dates", "FixedPointNumbers", "Hyperscript", "HypertextLiteral", "IOCapture", "InteractiveUtils", "JSON", "Logging", "MIMEs", "Markdown", "Random", "Reexport", "URIs", "UUIDs"]
git-tree-sha1 = "71a22244e352aa8c5f0f2adde4150f62368a3f2e"
uuid = "7f904dfe-b85e-4ff6-b463-dae2292396a8"
version = "0.7.58"

[[deps.PrecompileTools]]
deps = ["Preferences"]
git-tree-sha1 = "03b4c25b43cb84cee5c90aa9b5ea0a78fd848d2f"
uuid = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
version = "1.2.0"

[[deps.Preferences]]
deps = ["TOML"]
git-tree-sha1 = "00805cd429dcb4870060ff49ef443486c262e38e"
uuid = "21216c6a-2e73-6563-6e65-726566657250"
version = "1.4.1"

[[deps.Printf]]
deps = ["Unicode"]
uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7"

[[deps.REPL]]
deps = ["InteractiveUtils", "Markdown", "Sockets", "Unicode"]
uuid = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"

[[deps.Random]]
deps = ["SHA"]
uuid = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

[[deps.Reexport]]
git-tree-sha1 = "45e428421666073eab6f2da5c9d310d99bb12f9b"
uuid = "189a3867-3050-52da-a836-e630ba90ab69"
version = "1.2.2"

[[deps.SHA]]
uuid = "ea8e919c-243c-51af-8825-aaa63cd721ce"
version = "0.7.0"

[[deps.Serialization]]
uuid = "9e88b42a-f829-5b0c-bbe9-9e923198166b"

[[deps.Sockets]]
uuid = "6462fe0b-24de-5631-8697-dd941f90decc"

[[deps.SparseArrays]]
deps = ["Libdl", "LinearAlgebra", "Random", "Serialization", "SuiteSparse_jll"]
uuid = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
version = "1.10.0"

[[deps.Statistics]]
deps = ["LinearAlgebra", "SparseArrays"]
uuid = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
version = "1.10.0"

[[deps.SuiteSparse_jll]]
deps = ["Artifacts", "Libdl", "libblastrampoline_jll"]
uuid = "bea87d4a-7f5b-5778-9afe-8cc45184846c"
version = "7.2.1+1"

[[deps.TOML]]
deps = ["Dates"]
uuid = "fa267f1f-6049-4f14-aa54-33bafae1ed76"
version = "1.0.3"

[[deps.Tar]]
deps = ["ArgTools", "SHA"]
uuid = "a4e569a6-e804-4fa4-b0f3-eef7a1d5b13e"
version = "1.10.0"

[[deps.Test]]
deps = ["InteractiveUtils", "Logging", "Random", "Serialization"]
uuid = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[[deps.Tricks]]
git-tree-sha1 = "eae1bb484cd63b36999ee58be2de6c178105112f"
uuid = "410a4b4d-49e4-4fbc-ab6d-cb71b17b3775"
version = "0.1.8"

[[deps.URIs]]
git-tree-sha1 = "67db6cc7b3821e19ebe75791a9dd19c9b1188f2b"
uuid = "5c2747f8-b7ea-4ff2-ba2e-563bfd36b1d4"
version = "1.5.1"

[[deps.UUIDs]]
deps = ["Random", "SHA"]
uuid = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"

[[deps.Unicode]]
uuid = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"

[[deps.Zlib_jll]]
deps = ["Libdl"]
uuid = "83775a58-1f1d-513f-b197-d71354ab007a"
version = "1.2.13+1"

[[deps.libblastrampoline_jll]]
deps = ["Artifacts", "Libdl"]
uuid = "8e850b90-86db-534c-a0d3-1478176c7d93"
version = "5.8.0+1"

[[deps.nghttp2_jll]]
deps = ["Artifacts", "Libdl"]
uuid = "8e850ede-7688-5339-a07c-302acd2aaf8d"
version = "1.52.0+1"

[[deps.p7zip_jll]]
deps = ["Artifacts", "Libdl"]
uuid = "3f19e933-33d8-53b3-aaab-bd5110c3b7a0"
version = "17.4.0+2"
"""

# ╔═╡ Cell order:
# ╠═c5872ac3-a15f-45b8-8289-f7873b1650ae
# ╠═8b41c61e-d4a5-11ee-0643-17de92206bba
# ╠═9f9e9664-f0c6-4767-9592-ec52d3447f13
# ╟─00000000-0000-0000-0000-000000000001
# ╟─00000000-0000-0000-0000-000000000002

Thanks for the snippet - I cannot repro on Mac. This might be a Windows issue. @akshayka has a windows laptop so can check this out.

@scls19fr -- the latest release has a fix. Thanks for reporting!

Thanks for this fix


[4.0.0-rc.0] Android back button can unexpectedly switch tabs

Bug Report
Ionic version:

[x] 4.x
Current behavior:

When you tap on Android back button, it can unexpectedly switch tabs
Expected behavior:

On the tabs layout, Android back button should do nothing, since tabs layout is root component already
Steps to reproduce:

create a new project from tabs starter
add platform android
run app on Android device
randomly tap on any tab to generate a navigation history
keep tapping on Android back button, the app just went way back of all its navigation history

Related code:

insert short code snippets here

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.6.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-rc.0
   @angular-devkit/build-angular : 0.11.4
   @angular-devkit/schematics    : 7.1.4
   @angular/cli                  : 7.1.4
   @ionic/angular-toolkit        : 1.2.2

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : android 7.1.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.3.1, (and 4 other plugins)

System:

   Android SDK Tools : 26.1.1 (/Users/Dev/Android/android-sdk-macosx)
   ios-deploy        : 1.9.4
   ios-sim           : 6.1.2
   NodeJS            : v10.14.2 (/usr/local/bin/node)
   npm               : 6.4.1
   OS                : macOS Sierra
   Xcode             : Xcode 9.2 Build version 9C40b

I would suggest differentiating between top tabs to bottom tabs. Top tabs should not respond to back button, while bottom tabs should maybe navigate to the home button.

I would suggest differentiating between top tabs to bottom tabs. Top tabs should not respond to back button, while bottom tabs should maybe navigate to the home button.

In my case, it's bottom tabs. But if you look at native apps, they don't switch either top or bottom tabs by Android back button

This is something for #16611


Robot

What's the issue?

No description.

thias15<EMAIL_ADDRESS>(időpont: 2020. aug. 29., Szo, 10:06)
ezt írta:

What's the issue?

no problem.  it was all a coincidence.  i installed the github app and
suppressed something.  I'm sorry!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/intel-isl/OpenBot/issues/6#issuecomment-683254294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANLG4KPV3YF2EV3VCPXU2BDSDCY5JANCNFSM4QO2CGAA
.

Ok, thanks. Let us know if you face any problems.


[Feature] Escape when writing a note

Problem
Using Vim on the web, am looking for a note taking app that will allow me not to use my mouse. Currently there is no way to escape a note section without using a mouse.
Solution
Allow escape when in note taking section.
Notes

What does "escape a note section" mean?

https://prnt.sc/10dsaux
When the caret is within the note body, hitting Esc is not doing anything. Is there a way to escape that section without using a mouse?

By caret you mean text cursor? What do you expect to happen when you click escape?

Yes, text cursor.
When clicking escape it will escape the text field. I'll provide screen
when I'm back at my pc.
On Fri, Mar 5, 2021, 11:02 AM Tania Rascia<EMAIL_ADDRESS>wrote:

By caret you mean text cursor? What do you expect to happen when you click
escape?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/taniarascia/takenote/issues/495#issuecomment-791551196,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLVE7LTMA56TRKOWCQEBKTTCEFBBANCNFSM4YVLSYSA
.

https://prnt.sc/10e05t7
That way i can use the key highlights again, and not typing. Github comments allows you to do it.

Awesome product by the way!

https://takenote.dev/app
I think in this issue @vlad-terin is trying to improve the keyboard navigation of the app. Typically you would jump around using tab or shift + tab, however, once you are editing a note, the tab key becomes functional inside the writing experience.
You can sort of get around this by using Ctrl + Atl + F, which currently will jump you to the search box, outside of the note screen.

Once you focus on the search box and hit the tab key, you lose focus of the cursor. In the demo, I had to hit the tab key 9 times until eventually, the cursor ended up in the open note on screen,

Got it, apologies for the confusion. Yes, this would be very helpful for keyboard navigation.


Make sure the lightbox pops over comfyui-body-bottom

.comfyui-body-bottom is also at z-index 1000

https://github.com/Comfy-Org/ComfyUI_frontend/commit/2c90735bb19e6de6d5dd1fa8def372cceb89ae38


Typo in Readme

I believe in the readme when you say ....

Set the variables at the top of this repository's extensions/homeassistant/script.sh

You actually mean

Set the variables at the top of this repository's extensions/homeassistant/config.sh

Thanks a lot! Indeed the config was part of the script.sh some years ago :)


alexkrechik.cucumberautocomplete overrides feature icon

extension: Cucumber (Gherkin) Full Support
config: alexkrechik/VSCucumberAutoComplete/package.json
languageId: feature
fileExtensions: .feature, .testcase

oopsie I need to learn to read.
closing this as we have a solution, this is a duplicate of #10


Create an event sequence documentation of the pivoting based e2e tests [CAPM3]

This is a tracker issue for documenting all the tests that are classified as "pivoting based" tests.
Reference : https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/docs/e2e-test.md
pivoting based tests are:

[ ] - Pivoting
[ ] - Certificate rotation
[ ] - Node reuse
[ ] - Re-pivoting

/triage accepted

/remove-lifecycle stale

/remove-lifecycle stale
/lifecycle frozen


Critical build issue with the MRTK "Standard" Shader

Describe the bug
We hit an issue through our automation whereby the MRTK Standard Shader is being stripped during our automated builds (for some reason it is not stripped when doing a manual build, automation seems more aggressive in stripping)
Obviously, this creates severe issues when trying to load remote models and applying the shader through code at runtime.
However, the bigger issue is that we tried to address this by adding the MRTK Standard shader to Unity's "Always included shader" list in the Graphical settings, but this causes any Unity build (even local) to fail due to the sheer number of variations that Unity tries to build.
To reproduce
Steps to reproduce the behavior:

Create a new Unity project and install the MRTK
(optional) configure the Project for MRTK, including OpenXR
Add the MRTK Standard shader to the "Always Included Shaders" list
Try and do a build for UWP

Expected behavior
The build should work and produce a build
Screenshots

Your setup (please complete the following information)

Unity Version [e.g. 2021.3.11f1]
MRTK Version [e.g. v3.0.Preview10]

Target platform (please complete the following information)

HoloLens 2

Additional context
Add any other context about the problem here.

Assigning @Cameron-Micka here for MRGT build issue.
@SimonDarksideJ could you share what sort of way you're doing your automated build? Script, etc? @keveleigh wasn't there something we ran into earlier with stripping in our CI?

Hey @SimonDarksideJ, thank you for filing this issue. Unity will strip the shader if it finds it is not referenced by any scenes you have specified in the build settings.
You could add the shader to the always include settings, but because it is an uber shader with millions of variants you will have to use a shader variant collection to specify which variants you need.
That being said, for your use case:

when trying to load remote models and applying the shader through code at runtime

I'd recommend making a "default" material for the models you plan on loading and then instantiating new instances of that material in code rather than making a new material completely programmatically. You can reference this material in a scene you build or in the streaming assets folder.
The default material should have the settings you need to enable specified at build time. If you need to enable/disable shader keywords dynamically at runtime, then you will need to fall back to your previous method and use a shader variant collection.

I would say so @AMollis , considering it is currently impossible to build an MRTK project through automation where the content is not already in the project (downloaded) and using the MRTK Standard shader.  EXACT same solution works in a standalone build.
Ultimately, the general feeling is that the MRTK standard shader is too big and should really be broken up into smaller chunks as it causes way too many issues once you have the need for variants, for instance, turning mult-compile for even one or two properties results in MILLIONS of variants which Unity cannot handle.

Hi @SimonDarksideJ! I agree with you that the MRTK/Standard shader grew quite a bit (especially in the MRTK2) days. In MRTK3 we've done some work to move many, not all, of the UI materials to using bespoke shaders. We've also done some work to ensure we don't abuse the multi_compile and have slimmed down the list a bit.
I'm curious for this issue if you had a chance to try the above suggestion? https://github.com/microsoft/MixedRealityToolkit-Unity/issues/11151#issuecomment-1293941312 This has worked for other customers when loading content dynamically. If it doesn't work for you, I'd love to hear that as well.
As for the stripping during automated builds, we've not seen that locally in our automated builds. So that might take some more info or investigation from @AMollis and team. Dropping the MRTK/Standard (or Graphics Tools/Standard) into the "Always included shader" list may sound like an easy fix, but that's not generally recommended by Unity for "uber" shaders. For example, if you drop the Universal Render Pipeline/Lit shader into that list you will spend around 20 minutes per build generating tens of thousands of shader variants your project doesn't need:

It's recommended to curate a material you need for your dynamic content or build a shader variant collection.

Actually, dropping the MRTK shader into the "Always Included List" is the worst thing you can do, we found in testing that this even prevented local builds because there were simply TOO MANY varients to compile, it easily passes the max 2 million mark.

In MRTK3 we've done some work to move many, not all, of the UI materials to using bespoke shaders. We've also done some work to ensure we don't abuse the multi_compile and have slimmed down the list a bit.

Yes, however, we found that in some cases removing the multi-compile from certain keywords degraded the quality too much and caused artefacts, we had to re-add two to bring the quality level back up.

@SimonDarksideJ you may want to re-read @Cameron-Micka's comments. He doesn't appear to be saying what you seem to think he's saying.

@SimonDarksideJ , thank you for reporting the issue with the MRTK Standard Shader. To help us troubleshoot it, could you please provide a simple project that shows how it gets stripped during an automated build? We appreciate your cooperation and we will look into it as soon as possible.


[JOSS Review] Small error in installation instructions

In the installation instructions it is stated for optional dependencies to run
pip install amltk[notebook]
...

I believe this has to be
pip install "amltk[notebook]"
...

to function - at least on Linux. :)
(opened as part of JOSS Review https://github.com/openjournals/joss-reviews/issues/6367 )

Good spot, I've ran into the issue a few times in other repos. Funnily enough, I think it is also dependant on which shell is being used, i.e bash vs zsh


Bump dependencies

Bump dependencies

Codecov Report

Merging #1093 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1093   +/-   ##
==========================================
  Coverage      36.12%   36.12%
  Complexity       542      542
==========================================
  Files            103      103
  Lines           4482     4482
  Branches         693      693
==========================================
  Hits            1619     1619
  Misses          2717     2717
  Partials         146      146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5ff0e...b16512c. Read the comment docs.


Duplicate assertion used by with

In cases like this duplicate assertion is detected and removed incorrectly.
with self.assertRaises(ValueError):
    x = 3
with self.assertRaises(ValueError):
    x = 4

leads to this:
with:
    x = 4

@OlesiaSub have you fixed it?

@SmirnovOleg I did. sorry, forgot to link it to pr-fixes pull request


make wait longer than installplan timeout

Signed-off-by: akihikokuroda<EMAIL_ADDRESS>
Description of the change:
Increased the wait timeout for the installplan state change.  The installplan timeout is 60 seconds by default.  The test must wait longer than that.  The default Eventually timeout is also 60 seconds.  This PR change the wait time for the specific wait to 90 seconds.
Motivation for the change:
Closes #2638
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky
[ ] Tests that remove the [FLAKE] tag are no longer flaky

/approve

closing PR as stale. Please re-open if it's still important.


Bug in find files. Missing attributes.

This is a quick fix. I want to make another fix to add resiliency.
IIRC casting an int to an enum in .Net does not blow up if the value isn't defined on the enum. I did not expect this line to blow up in PowerShell. After this quick fix, I'll continue looking into what can be done for resiliency.


Update to Chromium 96.0.4664.93

This PR updates to chromium 96.0.4664.93
I've not seen notable changes to any patches, just different offsets
Builds and runs fine
Resolves #1763

Have you incorporated suggestions from Zoraver from a previous PR? I'm just not sure to be seeing them. I may be wrong though.

I have not, I'm honestly not quite to which extent hunks should be moved to remove-unused-preferences-fields.patch

By section do you mean the include directive and piece of code below like
 #include "components/policy/core/common/policy_types.h"
-#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
 #include "content/public/browser/browser_context.h"

 namespace base {
@@ -78,12 +77,6 @@ class ConnectorsService : public KeyedSe
   // is no token to use.
   absl::optional<std::string> GetDMTokenForRealTimeUrlCheck() const;

-  // Returns the value to used by the enterprise real-time URL check Connector
-  // if it is set and if the scope it's set at has a valid browser-profile
-  // affiliation.
-  safe_browsing::EnterpriseRealTimeUrlCheckMode GetAppliedRealTimeUrlCheck()
-      const;
-
   // Returns the CBCM domain or profile domain that enables connector policies.

?
Also this is my first time using quilt really, is there any faster way than pushing the patch I want to change and then manually call quilt edit on every file where I want to adjust something?

The include removals are all you would need to move.
For quilt, source the set_quilt_vars.sh in the devutils directory.  Then you can refresh all of the patches in one go with quilt push -a --refresh.

The patches mentioned in https://github.com/Eloston/ungoogled-chromium/pull/1750 is not included?

The patches mentioned in #1750 is not included?

I thought @Ahrotahn will make another PR with them, wouldn't he?

Yeah, I figured we'd make another PR for that.  I'm strapped for time currently, so I might not be able to get that going until later.  I wanted to see what everyone's thoughts were on the best way to implement those changes and figured I'd make a discussion when I get the time.