[KIECLOUD-694] - fixes duplicated item in the rhpam-image.yaml

Fixes ERROR Found multiple container definitions ([{'image_build_method': 'imagebuilder', 'platforms': {'only': ['x86_64', 'ppc64le']}}, {'image_build_method': 'imagebuilder', 'platforms': {'only': ['x86_64']}}])
Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

Run operator BDD testing
Please add comment: /jenkins test

Run RHPAM operator BDD testing
Please add comment: /jenkins RHPAM test

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

CI issue is not related. See https://github.com/kiegroup/kogito-operator/pull/1418


Improve the JavaScript bridge

<EMAIL_ADDRESS>commented:

The use of QVariant for QtWebKit bridging causes a lot of problem.
We need to investigate alternative solutions.

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #456.
:star2:   4 people had starred this issue at the time of migration.

AFAIU, there are two approaches to solve this (without resorting to use of different JS implementation for control script):

Introduce new wrapper class for JS values akin to QScriptValue, and convert bridge APIs to use it instead of QVariant. This will allow JS object to keep their behavior instead of being converted to QVariantMap, will preserve null properly, and maybe fix other issues
Avoid using Qt bridge and use strongly typed IDL-based bindings, in the same way as all DOM APIs in WebKit are implemented. In addition to type safety and conformance to JS rules this will allow to achieve the best possible performance. Downside is that I don't see a clean way to have generated code outside of Webkit source tree, as it would require exporting many WebCore symbols and scripting machinery. Also, idl sources and their C++ implementations need to be in sync with WebKit code. If CommonJS provides stable well defined interfaces with formal specifications (even better if accompanied by WebIDL), I can consider adding them to QtWebKit code base under runtime flag, so they are not accidentally exposed to Web

/cc @Vitallium

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be closed. In the future, if we see the need to attend to this issue again, then it will be reopened.
Thank you for your contribution!


Can't handle this error:

[Nest] 110  - 12/01/2024, 9:46:23 AM   ERROR [TrpcService] Can't handle this error:
docker-compose 部署成功后，添加读书号报错，接口500

dns解析不出来ip，增加环境变量 PLATFORM_URL=https://weread.965111.xyz 试试


Volume level constantly decreases

I've had this problem for a very long time on different devices and macOS versions. When the script is running, no matter how many times I set the volume at 50%, it keeps falling back to somewhere around 40% after each song. I does it in a few steps from what I see, very quickly.
I can't be the only one who experiences this, right?

I was able to reproduce the error. It doesn't happen if the volumen is set a 100%.
Not sure if I can solve the bug entirely, but at least I can try to avoid that dropping of 10%.
I will be working on this ASAP.
Thanks for the report 😉

I was able to fix it. The bug was causing the volume to drop 1 point every now and then, specially when changing to a new song.
Please update the script with the autoupdate feature by just running the script again and when asked to update the script select Y.
Close the ticket if the everything is working properly.

Seems to be working seamlessly. Thank you!


Windows 10

The name of the product
Windows 10 (22H2)
Describe the product
Most popular OS of the years
Initial release date of the product
7/29/2015
Discontinuation date of the product
10/14/2025
Relevant links
https://microsoft.com/windows10
Additional context
it's October not November

Updated to October 10th instead of November.  Pull request and public site update should reflect this by EOD.


Parse references from HTML LS

HTML LS has two headings containing the word "references" (because of "named character references"), which activates the mode in parse-references.js where it looks for normative/informative subsections, which don't exist in that document.
As a result, no references are found in the document.

Fixed in #39


.env problem

Hi,
I have
$this->runRemote('export SYMFONY_ENV=prod');
but uppon deploy error
 PHP Fatal error:  Uncaught Symfony\Component\Dotenv\Exception\PathException: Unable to read the "/var/www/vhosts/iwebi.pl/app-s4.iwebi.pl/releases/20190129153613/.env" environment file. in /var/www/vhosts/iwebi.pl/app-s4.iwebi.pl/releases/20190129153613/vendor/symfony/dotenv/Dotenv.php:466
butr

I confirm that changing /repo/* to /repo/. works for Symfony 4.2.

I've hit this problem too.  A note is by doing the change in the repo copy it's going to copy the full .git directory over too.  Instead since often you don't want all your dotfiles copied it'd be better to use beforePreparing:
    public function beforePreparing()
    {
        $this->log('
Copying over the .env files</>');
        $this->runRemote('cp {{ deploy_dir }}/repo/.env {{ project_dir }}');
    }

the /release directory doesn't contain .env file while /repo dir has this .env file

Could I please describe this issue in documentation? I confused about best practices of managing .env when I using this bundle.

This works for me.
public function **beforeUpdating**()     {         $this->runRemote('cp {{ deploy_dir }}/repo/.env {{ project_dir }}');         parent::beforeUpdating();      }

Hi,
On my side I prefer :
public function beforePreparing()     {         $this->log('
Copying over the .env files</>');         $this->runRemote('cp {{ deploy_dir }}/repo/.env.dist {{ project_dir }}/.env');     }

For Symfony 4.3 it should be copy .env to .env.local
On Wed, Jul 17, 2019, 2:44 PM Nicolas Guillard<EMAIL_ADDRESS>wrote:

Hi,
On my side I prefer :
public function beforePreparing() { $this->log('Copying over the .env
files</>'); $this->runRemote('cp {{ deploy_dir }}/repo/.env.dist {{
project_dir }}/.env'); }
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EasyCorp/easy-deploy-bundle/issues/87?email_source=notifications&email_token=AKMP3X5HWWYVCTWI5O7EGE3P74H4NA5CNFSM4GTAYAKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ECEDQ#issuecomment-512238094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMP3XZJ7GYINMMFOCHDUATP74H4NANCNFSM4GTAYAKA
.

The deploy script don't seems to copy dot files on projet root folder, is that only for me ?

I also faced this issue.
As a workaround, I put the .env and .env.local file as shared file.
->sharedFilesAndDirs(['.env','.env.local'])
The drawback is that you now have to handle manually the change in your .env file as it won't be synchronized with your repo, but anyway you would have to edit your .env.local file. No big deal.

Hello, I have also to put the .env as a shared file. Check out https://stackoverflow.com/q/59111354/633864, in fact I don't need to use env vars as my application only relies on .env files. Do you think I would be ok to introduce a new parameter to see if the APP_ENV env should be set?

Using Symfony 5 with PHP 7.4, the PR above fixes that issue:
https://github.com/EasyCorp/easy-deploy-bundle/pull/114

Judging from this issue and the PR still not being merged, it seems like this project is abandoned.
The Symfony 5 support is hacky and requires quite some jumping through hoops.
Also I tried to get this to work with a docker-compose setup and all the private methods and properties in DefaultDeployer.php make it impossible to gracefully add customizations., e.g. not being able to set another path for {{ console_bin }}.
I was lured in and liked the Symfony-centric and simple approach but it seems I'll have to move over to https://deployer.org/ for now.

I thought we shouldn't commit any secrets in .env ? If that the case we have to manual copy paste our .env.local.php each time we deploy and not relying on the .env from git.

I thought we shouldn't commit any secrets in .env ? If that the case we have to manual copy paste our .env.local.php each time we deploy and not relying on the .env from git.


Update reviewers and approvers

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Some people have moved on into other projects.
Some have increased their participation.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

cc @tenzen-y @kerthcet @denkensk @ArangoGutierrez @mimowo
/hold

cc @ahg-g

@ahg-g Thank you for driving Batch WG and kueue! Without you, we would not have been able to boot the Batch WG.

/lgtm

Suggesting that I may still be kept in the reviewer, then I can help give feedback on some personal opinions. @kerthcet

It's always good to have you @denkensk

Thanks for maintaining the list, and for adding me :). FWIW I'm happy to keep @denkensk in reviewers.

@denkensk I'm thinking of establishing a similar process to the one we have for kube-scheduler:
https://github.com/kubernetes/community/blob/master/sig-scheduling/CONTRIBUTING.md#best-practices

It is best if a PR is first reviewed by the Reviewers.
Once the PR gets a /lgtm from a Reviewer, Approvers will review the PR to approve it.

Do you think you'll be able to take first passes in the PRs that will be assigned to you automatically?

@denkensk I'm thinking of establishing a similar process to the one we have for kube-scheduler:
https://github.com/kubernetes/community/blob/master/sig-scheduling/CONTRIBUTING.md#best-practices

It is best if a PR is first reviewed by the Reviewers.

Once the PR gets a /lgtm from a Reviewer, Approvers will review the PR to approve it.

Do you think you'll be able to take first passes in the PRs that will be assigned to you automatically?

I thought I could take the time to help with the first round of code review.

Thanks!
I added @denkensk back to reviewers :)

/lgtm

/hold cancel


Licensing issue

You’re redistributing and relicensing the Alexa Top 1 Million list. Here be legal dragons.

You’re redistributing and relicensing the Alexa Top 1 Million list

You are right, I'll remove the Alexa Top 1 Million list file, and include the link to download it.
thanks


Gate execution of expensive tests on JS being up to date

Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

Fixes #182.
I actually thought while doing this that we could just merge these two workflow files, I am not sure that we are getting any benefit from them being separate are we?

What was it that prompted you to do this?

I should have followed the link to #182 before commenting so that's my bad. I see we all agreed to do this before and I just forgot about it. I'd still be interested to know what magnitude of effect it'll have if that's possible to calculate, but it might be quite hard to work out.

It was mainly a desire to close out #182 I'll be honest. Personally I often forget to regenerate the javascript, and it would save running them in that case, so it seems worthwhile.

I think I would vote for merging to avoid the duplication, but that could be a follow-up.


Update docs to latest github-script action version

See https://github.com/marketplace/actions/github-script#breaking-changes-in-v5

Thanks @britter . Would you be able to update https://github.com/gradle/gradle-build-action/blob/main/.github/workflows/pr-build-scan-comment.yml as well? That workflow should verify that the code in README.md is functional (although we don't have any automated way to keep them in sync).

@bigdaz done!

Thanks for the contribution, @britter !


[Feature]: Teams App Test Tool

Summary

This pull request introduces changes primarily aimed at improving the local development experience by integrating the Teams App Test Tool and refining the bot environment configuration. It also includes minor improvements to the response handling of the chat bot.
Key changes include:
Integration of Teams App Test Tool:

.vscode/launch.json: Added a new debug configuration for the Teams App Test Tool.
.vscode/tasks.json: Added new tasks related to the Teams App Test Tool, including starting the tool, validating prerequisites, deploying, and starting the application.
package.json: Added new scripts to start the Teams App Test Tool and launch it.
teamsapp.testtool.yml: Created a new YAML file for the Teams App Test Tool, which includes environment variable generation for the bot and the installation of development tools.

Refinement of bot environment configuration:

src/env.ts: Made BOT_ID and BOT_PASSWORD optional, and added a new refiner to check their presence when not using the Teams App Test Tool. [1] [2] [3]
teamsapp.local.yml: Moved the generation of custom environment variables to the TeamsFX settings section. [1] [2]

Improvements to response handling of the chat bot:

src/helpers/utils.ts: Enhanced the extractJsonResponse function to handle different types of JSON responses.
src/skills/chatGPTSkill.ts: Modified the response handling to use the improved extractJsonResponse function.

Other changes:

README.md: Updated the testing section with instructions for using the Teams App Test Tool.
env/.env.testtool.template: Added a new environment template file for the Teams App Test Tool.
.webappignore: Updated the ignore pattern for .localConfigs.

Why

What

Testing

Deployment

[ ] Have you bumped the version for this PR following semantic versioning.

Notes

Summary
This pull request introduces changes primarily aimed at improving the local development experience by integrating the Teams App Test Tool and refining the bot environment configuration. It also includes minor improvements to the response handling of the chat bot.
Key changes include:
Integration of Teams App Test Tool:

.vscode/launch.json: Added a new debug configuration for the Teams App Test Tool.
.vscode/tasks.json: Added new tasks related to the Teams App Test Tool, including starting the tool, validating prerequisites, deploying, and starting the application.
package.json: Added new scripts to start the Teams App Test Tool and launch it.
teamsapp.testtool.yml: Created a new YAML file for the Teams App Test Tool, which includes environment variable generation for the bot and the installation of development tools.

Refinement of bot environment configuration:

src/env.ts: Made BOT_ID and BOT_PASSWORD optional, and added a new refiner to check their presence when not using the Teams App Test Tool. [1] [2] [3]
teamsapp.local.yml: Moved the generation of custom environment variables to the TeamsFX settings section. [1] [2]

Improvements to response handling of the chat bot:

src/helpers/utils.ts: Enhanced the extractJsonResponse function to handle different types of JSON responses.
src/skills/chatGPTSkill.ts: Modified the response handling to use the improved extractJsonResponse function.

Other changes:

README.md: Updated the testing section with instructions for using the Teams App Test Tool.
env/.env.testtool.template: Added a new environment template file for the Teams App Test Tool.
.webappignore: Updated the ignore pattern for .localConfigs.

Why
What
Testing
Deployment

[ ]  Have you bumped the version for this PR following semantic versioning.

Notes

while running it on my local I observed that it asked to add following fields in .env.testtool.
AAD_APP_CLIENT_ID,
SECRET_AAD_APP_CLIENT_SECRET,
AAD_APP_TENANT_ID,
AAD_APP_OAUTH_AUTHORITY_HOST,
M365_TITLE_ID,M365_APP_ID

We should call it in ReadMe

In order to test using Test Tool we need to run it and get all these fields generated and stored in .env.local
from .env.local we copy them to .env.testtool


Incorrect error message on invalid union type assignation

🔎 Search Terms
error message union type assignation
🕗 Version & Regression Information

This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.2.1-rc#code/MYewdgzgLgBMBcMDeAPGiDkBDDMA+MGARrvocBgL4wC8yK82VMAUKJLEYqpjtQT0IlqdYAG4gA
💻 Code
const c: {x : 'a' | 'b'  | 'c'} = {x:'c'}
const b: {x: 'a'} | {x: 'b'} = c;

🙁 Actual behavior
The error message is
Type '{ x: "a" | "b" | "c"; }' is not assignable to type '{ x: "a"; } | { x: "b"; }'.
  Type '{ x: "a" | "b" | "c"; }' is not assignable to type '{ x: "b"; }'.
    Types of property 'x' are incompatible.
      Type '"a" | "b" | "c"' is not assignable to type '"b"'.
        Type '"a"' is not assignable to type '"b"'.(2322)

The problem starts with the line   Type '{ x: "a" | "b" | "c"; }' is not assignable to type '{ x: "b"; }'.. It is true that the types are incompatible, but it is not true that this is the source of the error.
In this simple case, it's easy to see where the actual problem is, but with large unions, it becomes hard to know where the error comes from.
🙂 Expected behavior
The actual problem is that type 'c' is not assignable to 'a' | 'b', and the error message should mention it. Maybe the full trace should look like this:
Type '{ x: "a" | "b" | "c"; }' is not assignable to type '{ x: "a"; } | { x: "b"; }'.
    Types of property 'x' are incompatible.
      Type '"a" | "b" | "c"' is not assignable to type '"a" | "b"'.
        Type '"c"' is not assignable to type '"a" | "b"'.(2322)

Additional information about the issue
When the unions are large and aliased, the misleading message makes errors hard to debug.

Maybe it's a bit similar, yes. But there isn't any non-distinct discriminating property here.

@MartinJohns

But this would imply that a value typed "a" | "b" can be used, which is not the case.

I'm not sure I understand. A value of type "a" | "b" can be used for property x. The following would be correct, for instance :
const c: {x : 'a' | 'b'} = {x:'a'}
const b: {x: 'a'} | {x: 'b'} = c;

In general, { x: A } | { x: B } is not equivalent to { x: A | B }.  In some limited cases where TS can prove it's safe it will allow an assignment, but as a general rule those types aren't interchangeable and the compiler therefore won't merge them for the purpose of producing error messages.

To come back to the main topic of this issue, the incorrect error message seems to come from the way typescript checks assignation to union types. It checks each of the union members individually (which is correct), but if none match, it reports a mismatch between the source type and the last member of the union, which is incorrect and confusing.

if none match, it reports a mismatch between the source type and the last member of the union

IIRC it only does this for discriminated unions, which is what you have in the OP.

Yes, running tests, I can see that. I see that
type X<T> = {x: T};

function f<A, B>(x: X<A|B>): X<A> | X<B> {
    return x
}

does not typecheck, whereas it should.


Frontend Projects: Added Scroll To Top Button to "Food Website"

Title and Issue number
Added a scroll to top button for the food website in frontend projects using CSS & Javascript in separate files!
Preview

Close #3623

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

@TusharKesarwani @MohitGupta121 sir kindly review this PR

@MohitGupta121 @TusharKesarwani #3760
#3649 #3565 #3555 #3045 rohansx/informatician#950 kunjgit/GameZone#2361
She has scroll to top buttons in multiple projects. Please dont accept new issues and remove labels from all pr's except 1. @gurjeetsinghvirdee @palakag29 @rachitag112 Mods please check

huh but its a feature and not a project spam why wont it count?

@MohitGupta121 @TusharKesarwani #3760
#3649 #3565 #3555 #3045 rohansx/informatician#950 kunjgit/GameZone#2361
She has scroll to top buttons in multiple projects. Please dont accept new issues and remove labels from all pr's except 1. @gurjeetsinghvirdee @palakag29 @rachitag112 Mods please check

also the informatician PR isnt even a scroll to top button its literary making buttons in the footer scroll to top.


Parsing Realm object in FlatList its to slow

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS 10.14.1
CPU: (4) x64 Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz
Memory: 334.15 MB / 8.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.11.4 - /usr/local/bin/node
Yarn: 1.9.4 - /usr/local/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 23, 24, 25, 26, 27, 28
Build Tools: 23.0.1, 25.0.0, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.3, 28.0.1, 28.0.3
System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.3.1 => 16.3.1
react-native: 0.57 => 0.57.7
npmGlobalPackages:
react-native-rename: 2.2.2
Description
I'm using Realmjs as a database for my react-native application but when I try to rendring a Realm objects in my FlatList view its take a lot of time and its to slow.
https://realm.io/docs/javascript/latest/#react-native-listview

This issue is missing a minimal reproduction. Can you add a link to a Github repo which can be used to show the issue? Ideally, a maintainer should be able to reproduce in these minimal steps:

clone
yarn
react-native run-ios

There is nothing actionable for maintainers in the issue as you describe it right now. This issue needs a git repo example as opposed to an expo snack because of the native dependency.
Also, slow compared to what? First render, scrolling? Is the scrolling smooth, but the data doesn't show if you scroll far down or is the scrolling stuttering? There are many possible interpretations to 'it is slow'.
If you provide this information, someone can have a look and help resolve the issue.

@bartolkaruza thank you for your response,
The main problem is when FlatList rendering Realm data.
<FlatList                 data={this.state.data}                 extraData={this.state.data}                 keyExtractor={this._keyExtractor}                 renderItem={this._renderItem}                 ItemSeparatorComponent={this._itemSeparatorComponent}                 onEndReached={() => {                   setTimeout(() => {                     this.setState(                       {                         pagination: this.state.pagination + 1                       },                       () => {                         if (this.props.settings.connection) {                           this._search();                         } else {                           this._paginationRealm();                         }                       }                     );                   }, 400);                 }}                 initialNumToRender={8}                 maxToRenderPerBatch={2}                 onEndReachedThreshold={0.5}               />

That is still not enough to reproduce, unfortunately.


[GOBBLIN-2041] Fix NPE in CopySource::getCopyEntityClass

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-2041

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Access to the property gobblin.copy.copy.entity.class, which is NOT mandatory in a WorkUnit can cause CopySource::getCopyEntityClass to throw NPE:
java.lang.NullPointerException:
	at java.lang.Class.forName0(Native Method:0)
	at java.lang.Class.forName(Class.java:264)
	at org.apache.gobblin.data.management.copy.CopySource.getCopyEntityClass(CopySource.java:558)
	at org.apache.gobblin.temporal.ddm.activity.impl.ProcessWorkUnitImpl.getOptCopyEntityClass(ProcessWorkUnitImpl.java:204)
	at org.apache.gobblin.temporal.ddm.activity.impl.ProcessWorkUnitImpl.getOptCopyableFile(ProcessWorkUnitImpl.java:184)
        ...

This change adds a guard, to avoid the NPE and now log, such as:
java.io.IOException: property 'gobblin.copy.copy.entity.class' not found in state: WorkUnit(super=Common:{}
 Specific: {source.filebased.fs.snapshot=<<redacted-URL>>, converter.avro.jdbc.date_fields={}, writer.staging.table=stage_2663272993647806, source.filebased.files.to.pull=<<redacted-URL>>, job.id=<<job-id>>, task.key=0, task.id=<<task-id>>}, extract=Common:{}
 Specific: {extract.extract.id=20240412013924, extract.table.name=<<path>>, extract.table.type=APPEND_ONLY, extract.namespace=<<namespace>>, extract.extractIdTimeZone=UTC, extract.is.full=false})
	at org.apache.gobblin.data.management.copy.CopySource.getCopyEntityClass(CopySource.java:558)
	at org.apache.gobblin.temporal.ddm.activity.impl.ProcessWorkUnitImpl.getOptCopyEntityClass(ProcessWorkUnitImpl.java:194)
	at org.apache.gobblin.temporal.ddm.activity.impl.ProcessWorkUnitImpl.getOptCopyableFile(ProcessWorkUnitImpl.java:174)
	...

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

manual verification
Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

This would be changing the NPE into an IOException instead right? The underlying issue is that not every source has a CopyEntityClass which is depended on by ProcessWorkUnitImpl, it seems that you need to decouple the ProcessWorkUnitImpl with the CopySource since there are different Gobblin sources that can be used.

This would be changing the NPE into an IOException instead right? The underlying issue is that not every source has a CopyEntityClass which is depended on by ProcessWorkUnitImpl, it seems that you need to decouple the ProcessWorkUnitImpl with the CopySource since there are different Gobblin sources that can be used.

I do agree with addressing the presumption in ProcessWorkUnitImpl, but will do so separately.  RN the presumption of CopyEntity only shows up there for informational logging, but I agree, that it's too CopySource-specific for the general case.
that said, protecting against NPE by first checking the result seems a reasonable stand-alone change, and this method already has IOException in its signature.


Procedurally generate UVW data

The simplest route for me (for now) with the testing is to generate my own data that would come from a measurement set (using simms). Right now, I am trying to figure out how I could possibly create the UVW data with shape (n_row, 3). The code that fetches it from the table for data simulation is as follows:
...
    # Get convention
    if args.phase_convention == 'CASA':
        uvw = -(ms.UVW.data.astype(np.float64))
    elif args.phase_convention == 'CODEX':
        uvw = ms.UVW.data.astype(np.float64)
    else:
        raise ValueError("Unknown sign convention for phase")
...

where it is then used to generate model-visibilities using the africanus.dft.dask.im_to_vis. How would I go about trying to do this?

My only method right now would be to have a separate uvw_XXX.npy file that contains the array of pre-calculated coordinates (from using casa through simms) for XXX time-steps, and just load that in when needed.

Having a small .npy file committed to your repo is fine in my opinion. It
is also completely ok to have a measurement set which you read data from.
If you want a bit of a hands on demo with how I do this in QuartiCal, I
would be happy to take you through it.
Generating realistic uvw coordinates is probably more effort than it is
worth. Plus, static uvw in a .npy file won't change under you.
On Tue, 23 Feb 2021, 18:54 Brian Welman<EMAIL_ADDRESS>wrote:

My only method right now would be to have a separate uvw_XXX.npy file
that contains the array of pre-calculated coordinates (from using casa
through simms) for XXX time-steps, and just load that in when needed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brianwelman2/kal-cal/issues/2#issuecomment-784346933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSHDWIJRH2LMJ6SQ4EXRDLTAPMVJANCNFSM4YCZV27A
.

Having a small .npy file committed to your repo is fine in my opinion. It is also completely ok to have a measurement set which you read data from. If you want a bit of a hands on demo with how I do this in QuartiCal, I would be happy to take you through it. Generating realistic uvw coordinates is probably more effort than it is worth. Plus, static uvw in a .npy file won't change under you.
…
On Tue, 23 Feb 2021, 18:54 Brian Welman, @.***> wrote: My only method right now would be to have a separate uvw_XXX.npy file that contains the array of pre-calculated coordinates (from using casa through simms) for XXX time-steps, and just load that in when needed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSHDWIJRH2LMJ6SQ4EXRDLTAPMVJANCNFSM4YCZV27A .

I think a demo with QuartiCal would be useful. If I had to use a measurement set for it, I would then still have to generate the measurement set or at least have it pre-generated, for different combinations of n_time and n_chan, which is what I am trying to avoid, especially with the testing. I would essentially be creating an measurement set for the single purpose of retrieving the UVW coordinates.
I could do the .npy files as a short fix for now, but ideally I would like to dynamically generate it.

We can likely manage something that doesn't require multiple measurement
sets. If you make one with the maximum number of times and channels you
wish to test, we can write a fixture to select out subsets.
I will shoot you a mail in the morning and we can organise a time for a
demo.
On Tue, 23 Feb 2021, 19:41 Brian Welman<EMAIL_ADDRESS>wrote:

Having a small .npy file committed to your repo is fine in my opinion. It
is also completely ok to have a measurement set which you read data from.
If you want a bit of a hands on demo with how I do this in QuartiCal, I
would be happy to take you through it. Generating realistic uvw coordinates
is probably more effort than it is worth. Plus, static uvw in a .npy file
won't change under you.
… <#m_-295029650542020488_>
On Tue, 23 Feb 2021, 18:54 Brian Welman, @.***> wrote: My only method
right now would be to have a separate uvw_XXX.npy file that contains the
array of pre-calculated coordinates (from using casa through simms) for XXX
time-steps, and just load that in when needed. — You are receiving this
because you are subscribed to this thread. Reply to this email directly,
view it on GitHub <#2 (comment)
https://github.com/brianwelman2/kal-cal/issues/2#issuecomment-784346933>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSHDWIJRH2LMJ6SQ4EXRDLTAPMVJANCNFSM4YCZV27A
.
I think a demo with QuartiCal would be useful. If I had to use a
measurement set for it, I would then still have to generate the measurement
set or at least have it pre-generated, for different combinations of
n_time and n_chan, which is what I am trying to avoid, especially with
the testing. I would essentially be creating an measurement set for the
single purpose of retrieving the UVW coordinates.
I could do the .npy files as a short fix for now, but ideally I would
like to dynamically generate it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/brianwelman2/kal-cal/issues/2#issuecomment-784379103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSHDWPTMEI6S3UPNG3B3FTTAPSE3ANCNFSM4YCZV27A
.

I would essentially be creating an measurement set for the single purpose of retrieving the UVW coordinates.

Not necessarily a bad idea considering the alternative... I would just pull a single empty measurement set from packratt and populate it at the time of testing. I'm sure we can host it on elwood

I would essentially be creating an measurement set for the single purpose of retrieving the UVW coordinates.

Indeed why not. Making a single-channel MS for this purpose creates very little overhead, and saves you a ton of headaches with coordinates.
And if you're only using it to retrieve UVWs and don't write anything back, there's no problem with locks and the MS can be shared among multiple tests.

Thank you for all the assistance. I had a short meeting with Jon and he discussed how he accomplishes parameterizing with a single MS. I have yet to see if github actions will build and past some simple tests, but so far so good. For now, I have one MS with a large number of channels and time-steps. Then using Jon's advice, I cut it up as need be for each test using pytest.fixture.


[BACKLOG-20617] - changes to base streaming to support repository ktr…

…s and aborting

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd clean install && mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd site
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd build-helper:remove-project-artifact && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/SubtransExecutor.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BlockingQueueStreamSource.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/FixedTimeStreamWindow.java
  engine/src/test/java/org/pentaho/di/trans/streaming/common/BlockingQueueStreamSourceTest.java
  plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/FileStream.java
  plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/TailFileStreamSource.java
  plugins/file-stream/src/test/java/org/pentaho/di/trans/step/filestream/FileStreamTest.java

Newly Fixed Tests:
org.pentaho.di.trans.streaming.common.BlockingQueueStreamSourceTest.testError:
:large_blue_circle: java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.streaming.common.BlockingQueueStreamSourceTest.testError(BlockingQueueStreamSourceTest.java:173)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.5% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.SubtransExecutor

Complexity Change: -2.9% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:
Method Change: -10.7% :small_red_triangle_down:

org.pentaho.di.www.cache.CarteStatusCache

Instruction Change: -1.2% :small_red_triangle_down:
Line Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

@pentaho/ackbar please review


Pointer events on transparent parts of canvas

Is there a way to have pointer events pass through the transparent parts of the canvas (and on to divs behind) while still correctly manipulating the image when they are within the image bounds?
Thanks!

I'm not aware of such a thing, but perhaps you could do the transparency detection yourself and marshal the events across as needed? Any thoughts, @msalsbery?
Just out of curiosity, @EmilyReif, what sort of transparency shapes do you have?

I just meant the transparent parts of the viewport that are outside of the image bounds. That is, if the image is zoomed out far enough to not take up the entire viewport, the parts around the outside.
I know I can detect whether or not I'm within bounds  with something like:
	var clickP = _viewer.viewport.pointFromPixel(new OpenSeadragon.Point(evt.x, evt.y))
	if ((clickP.x < 1) &&
		(clickP.x > 0) &&
		(clickP.y <  _viewer.viewport.contentAspectY) &&
		(clickP.y > 0)){
		return true
	} else{
		return false
	}

But I was more wondering if there was a way to automatically have events propagate only if they are not in bounds (basically have the outer canvas have pointer-events: none, and the actual image have pointer-events: auto). This might just not be possible though!
(Does that make sense?)
Thank you so much!

Yes, that makes sense. I'm not aware of any way to do that, since it's all a single canvas. There might be a way to capture the events and then trigger them on the underlying element though. Of course if you are in control of the underlying element it might be more robust to talk to it directly without going through the DOM event chain.

Ah, that makes sense. Yeah, we were considering that too but we weren't sure if there was a more direct way.
Thanks!


suggest:form-label name??

sugguest:change class name:col-form-label => form-label,remove prefix col-

We just changed it to .col-form-label in Alpha 3 to account for it's specific use case with the grid classes. Not likely to change it back yet unless there's more feedback around the class name. Thanks though.


Creating web Failed

Failed to upload Template
Failed to create directory /public/cinetotal CoreError::MutationFailure::MutationError::LowBalance
OK

This looks like a valid error, @madmaxero . The upload has failed because of 100 put requests made by the user account.
I hope you had uploaded files and consumed some space before trying to upload the template. If my assumption is right can we close this issue?

Yes its like that.

Thanks for confirming. I will close this issue then.


(FEATURE REQUEST) Dragon Head & Sign support

Seeing as the other mob heads have been changed, I'd love to see Dragon Heads get the same treatment as well, since at the moment their hitbox is all sorts of weird in general.
Signs make a bit more sense being the way they are (especially considering they're pretty old in general), but I still think it would be kind of neat to see!

Upward rails would be neat too!


In the detailed Workitem creation dialog, a status of "Created" is always displayed - even if the workitem is not yet created

See attached screenshot:

@fabric8io/uxd confirming the Created behaviour - we will not display the "Created" text during work item creation via the dialogue box.

@ldimaggi / @naina-verma please verify the fix on demo.almighty.

@nimishamukherjee , Fix works fine !


feat: 4031 - different layout for "empty" product list page

Impacted files:

app_en.arb: removed the ! from the "start scanning" label
app_fr.arb: removed the ! from the "start scanning" label
product_list_page.dart: FAB instead of custom button; different layout for svg and text

What

Different layout for "empty" product list page

FAB instead of custom button
Different layout for svg and text

Screenshot

Fixes bug(s)

Fixes: #4031

Codecov Report

Merging #4052 (304ab7a) into develop (a007367) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4052   +/-   ##
========================================
  Coverage    11.00%   11.00%
========================================
  Files          270      270
  Lines        13369    13364    -5
========================================
  Hits          1471     1471
+ Misses       11898    11893    -5

Impacted Files
Coverage Δ

...pp/lib/pages/product/common/product_list_page.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #8516 (b152122) into main (63ecb07) will increase coverage by 0%.
The diff coverage is 72%.

:exclamation: Current head b152122 differs from pull request most recent head 3dc959d. Consider uploading reports for the commit 3dc959d to get more accurate results

@@          Coverage Diff          @@
##            main   #8516   +/-   ##
=====================================
  Coverage     71%     72%
=====================================
  Files        377     377
  Lines      23917   23920    +3
  Branches    3680    3681    +1
=====================================
+ Hits       17180   17223   +43
+ Misses      5254    5211   -43
- Partials    1483    1486    +3

Impacted Files
Coverage Δ

...ent/datascience/jupyter/jupyterNotebookProvider.ts
78% <ø> (ø)

src/client/datascience/types.ts
100% <ø> (ø)

...datascience/interactive-common/notebookProvider.ts
72% <50%> (-5%)
:arrow_down:

.../datascience/notebook/notebookControllerManager.ts
75% <100%> (+4%)
:arrow_up:

...ience/variablesView/variableViewMessageListener.ts
77% <0%> (-23%)
:arrow_down:

...ascience/data-viewing/dataViewerMessageListener.ts
83% <0%> (-17%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
67% <0%> (-11%)
:arrow_down:

src/client/common/errors/index.ts
70% <0%> (-10%)
:arrow_down:

...t/common/application/webviewPanels/webviewPanel.ts
61% <0%> (-9%)
:arrow_down:

...client/datascience/raw-kernel/rawJupyterSession.ts
71% <0%> (-7%)
:arrow_down:

... and 44 more


[HB-7028] Handle Memory Leak

Fixes a memory leak for fullscreen ads.
Updated CHANGELOG, README, Adapter version to <IP_ADDRESS>.4

This fixes the leak. Trying the approach in which we create a new class for the Listener causes the close delegate to no longer trigger. 🤔 May need to look more into it, if we want to go with adding more preventive measure.

Will be pushing another commit that moves the listener to an internal class.


as of v0.2.45 mangayomi doesn't launch anymore

Steps to reproduce
just trying to run the executable
Expected behavior
do i really need to?
Actual behavior
the program crashes and dumps memory to C:\Users<USER>\AppData\Local\CrashDumps\
Mangayomi version
0.2.45
Device
Desktop Windows 10 (64-bit) x86_64
Other details
i can't be sure if this is a me problem or not, but it's happening to me
latest version that still launched without any issues was v0.2.25
just in case my computer specs are the following:
Intel(R) I7-3770
GTX 750 Ti
you may request a crash dump by windows from me here > eridreemurr (discord)
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated all installed extensions.

just tested 0.2.4 and it launched fine


PR with Job/Correspondence changes

We're using dev as the main branch for right now, maybe close this and re-open it to dev?


nm device: Treat disabled IPv6 as OK to reapply

When IPv6 is disabled, interface can use reapply()

Coverage increased (+3.0%) to 69.357% when pulling 351c9e482db605175807f7891ede8798754e05a4 on cathay4t:fix_reapply_ipv6_disable into 3590ef82d3aed6c1e248ef3b0f39d70e1f1716dc on nmstate:master.

Rebased it so it could be merged.


Fix install script not working for RHEL 7

Same change as https://github.com/docker/docker/pull/23817 , this should fix https://github.com/docker/docker/issues/23787

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:Purple90/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Closing. This doesn't actually fix the issue when RHEL like I thought it did. The script still generates a bad URL
Repository 'docker-main-repo': Error parsing config: Error parsing "baseurl = 'https://yum.dockerproject.org/repo/main/centos/no package provides centos-release'": URL must be http, ftp, file or https not ""


Read More Link inside of content link.

I use dotdotdot on an element.
That element contains a link (let's call that link JIMMY) and a readmore link (let's call that link BOB).
I make sure to use the "after" parameter when calling dotdotdot to specify BOB.
dotdotdot happens to truncate in the middle of JIMMY.
I'd expect BOB to be after JIMMY.
BOB ends up inside of JIMMY.
JIMMY isn't happy.

That's odd, on line 343 a link ("a") is specified. So BOB should have been added after JIMMY.

Ok, found the issue.
a table, etc should have been a, table, etc.
Will release a new version soon.

Cool! I'm looking forward to this issue getting closed.

The bug has been fixed in the latest version. Closing this issue now.

this isn't fixed

demo: http://codepen.io/howlingmad/pen/vOeoGd


v0.0.5

README
Updated parameter details
Updated example scripts
Updated deployment instructions (include "local")
Updated stats
The actual scripts
Major overhaul:

I realised I had two functions that were simply there to call other functions. They weren't doing anything for themselves! Therefore, function dynamicPolyfill, function pageLoaded and function checkNativeSupport have now all been combined into a single, function: function dynamicPolyfill - closes #14
Iterate through array values using Array.forEach()
Split out loadMyScript repeated code into a helper function - minimising duplication! See #12.
Refactored init function to include a micro-helper function to avoid duplication! See #12.
initialiseMyScript is no longer called from the "core" pageLoaded function - instead it is called depending on whether the scripts that are to be used have loaded or not. See #12.
initialiseMyScript had an unnecessary var (var fn = new Function) which has been instead moved inline into the try{}. See #12.
fns in loadPolyfill was unused... not sure how it even got there! See #12.
Order functions logically
Inline comments to explain what each step is doing
Retain backwards compatibility!
Support for Safari and its weird behaviours. Closes #13.
General tidying up of code. See #12.
Formatting fixes

Previous beta's:
Fix erroneous try{}catch{}
Remove console.log from dynamicPolyfill.js that shouldn't have remained
Add various console messages to dynamicpolyfill-consolemessages.js for troubleshooting/debugging/fun purposes [NOW DEPRECATED]
Allow array to be passed for:

features (parameter 1)
scriptURL (parameter 2)
initFunction (parameter 3)
You can still pass simple strings to each if you want though
Closes #10 and closes #8

Fix issue where if initFunction wasn't an array, it wouldn't execute
Deprecated dynamicpolyfill-consolemessages.js due to complexity to maintain (if you really want it - log an issue and I'll re-add it!)

Updated PR message with recent changes.
Ready to merge 🚀


nimble ble_gatts_find_chr always zero (IDFGH-7567)

Hello,
I am testing the BLE nimble stack and on a central node was trying to get the handle of a given characteristic by calling the function
ble_gatts_find_chr(BLE_UUID16_DECLARE(SERVICE_UUID), BLE_UUID16_DECLARE(CHAR_UUID), &handler_characteristic, &handle_value);
but it always returns zero in both. Is there a particular function that needs to be called first?
As an alternative, I tried to access the result of peer_disc_all(...). but no success. Where is the result stored and how can it be read?
My ultimate goal is to verify the characteristic UUID when the notification is received. Any other way this can be done?

I've never used that function, but you can get the handles like so, before you register:
extern uint16_t pd_ble_gatt_handle_midi;

// Define new custom service
static const struct ble_gatt_svc_def gatt_defs[] = {
    {
        // Service: Midi
        .type = BLE_GATT_SVC_TYPE_PRIMARY,
        .uuid = (const ble_uuid_t*) &pd_ble_uuid_svc_midi,
        .includes = 0,
        .characteristics = (struct ble_gatt_chr_def[]) {
            {
                // Midi Characteristic
                .uuid = (const ble_uuid_t*) &pd_ble_uuid_chr_midi,
                .access_cb = gatt_access_handler,
                .arg = 0,
                .descriptors = NULL,
                .flags = BLE_GATT_CHR_F_READ |
                         BLE_GATT_CHR_F_WRITE_NO_RSP |
                         BLE_GATT_CHR_F_NOTIFY,
                .min_key_size = 0,
                .val_handle = &pd_ble_gatt_handle_midi,
            },
            {
                // No More Characteristics
                .uuid =  0,
                .access_cb = 0,
                .arg = 0,
                .descriptors = 0,
                .flags = 0,
                .min_key_size = 0,
                .val_handle = 0,
            }
        },
    },
    {
        // No More Services
        .type = 0,
        .uuid = 0,
        .includes = 0,
        .characteristics = 0
    }
};

Hi @chipweinberger ,

gatts_* functions are to be used by server, gattc_* functions are primarily for client side.
ble_gatts_find_chr is for finding in local database. Client doesn't have database, server has. So using this function on client side may not give any information.
So to cross check the notification received on client side :
a. client subscribes to notification using specific attr_handle, so it can be saved on client side and when it receives the    notification, it can be compared and verified.
b. Or the other way, one can find the attr_handle associated with the specific UUID using this api - peer_chr_find_uuid()
You can check it's demo implementation in examples/bluetooth/nimble/ble_spp/spp_client/main/main.c line 41
This attr_handle obtained will be same to that when notification is received.

its solved. Thanks


openai api endpoint configurable

OpenAI cannot be used directly in some countries, users living in such countries need a proxy endpoint to use it, add an endpoint configuration for them to use.

It is configurable. Right there in the Workflow Environment Variable you’re deleting. This is considered an advanced feature that the overwhelming majority of users will never care for and only be confused by, which is why it’s where it is.

Thanks for your explanation, I understand the method.


electron: 1.7.9 -> 1.7.11

Motivation for this change
Upstream releases:
https://github.com/electron/electron/releases/tag/v1.7.10
https://github.com/electron/electron/releases/tag/v1.7.11
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS x86_64 and i686
[ ] macOS
[ ] arm
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" --- tested one dependent app: marp
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build electron

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘electron-1.7.11’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/tools/electron/default.nix:10 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
  inflating: /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/locales/nb.pak
shrinking RPATHs of ELF executables and libraries in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/libffmpeg.so
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/libnode.so
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/electron
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib  /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/bin
patching script interpreter paths in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11
checking for references to /tmp/nix-build-electron-1.7.11.drv-0 in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11...
/nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11

Success on x86_64-darwin (full log)
Partial log (click to expand)
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Headers -> Versions/Current/Headers
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Modules -> Versions/Current/Modules
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/ReactiveCocoa -> Versions/Current/ReactiveCocoa
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Resources -> Versions/Current/Resources
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current -> A
  Electron.app/Contents/Frameworks/Squirrel.framework/Headers -> Versions/Current/Headers
  Electron.app/Contents/Frameworks/Squirrel.framework/Modules -> Versions/Current/Modules
  Electron.app/Contents/Frameworks/Squirrel.framework/Resources -> Versions/Current/Resources
  Electron.app/Contents/Frameworks/Squirrel.framework/Squirrel -> Versions/Current/Squirrel
  Electron.app/Contents/Frameworks/Squirrel.framework/Versions/Current -> A


Define upsert columns

1⃣ Why should it be added? What are the benefits of this change?
This PR adds the ability to setup/configure the list columns that should be updated when using upsert functionality. Right now, WithUpserts will update all columns (based on the model's filled attributes) which can be troublesome in some cases. Especially, if you want to use ToModel interface as well as batch inserts.
Example: I'm importing a set of work orders and using UUID as an identifier. Import file does not have any identifier information (and obviously, I want to preserve UUIDs between imports). During import, I need to instantiate the model and fill it with data from the import, but also generate a UUID.:
    public function model(array $row): Model
    {
        return new WorkOrder([
            'id' => Str::orderedUuid()->toString(),
            'code' => trim($row[0])
        ]);
    }

code is upsert unique (I know that I can set an array of uniques, but this example is just to show that things can be improved).
Using current upsert functionality, id column will be updated, which is undesirable.
2⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3⃣ Does it include tests, if possible?
Yes.
4⃣ Any drawbacks? Possible breaking changes?
No. In order to avoid such changes, I've introduced a separate interface WithUpsertColumns that allows specifying a list of columns for upsert.
Of course, my "naming" proposition or code style is subject to discussion/change. I'll be happy to adjust it if needed.

Looks good, thanks! Can you have a look if you can update the docs as well?

@patrickbrouwers thanks for the merge. Sure thing, I'll update the docs.


Android installs missing gcc_64 directory

If you install Android Qt6 builds on linux like (this is how the github action works):
python3 -m aqt install 6.3.0 linux android android_armv7 -O /home/runner/work/GPXSee/Qt
the resulting Qt installation is broken as it is missing the gcc_64 directory which contains the actual
Qt binaries (in android_armv7 there are only symlinks) like qmake.
As a result, qmake-based builds are not possible with Qt installed using aqtinstall.

Ok, so there is a workaround to install both the desktop Qt and the Android Qt using aqtinstall, but this is:

questionable, if this is the desired behaviour
nowhere documented (if you install Android Qt like described in aqtinstall documentation, qmake-based builds will not work)

Here is what we do before call `install-qt``  for  android on CI test.
https://github.com/miurahr/aqtinstall/blob/d6aa879d7f9477512b35dc05c76069c73f8a5f21/ci/steps.yml#L53-L59
aqtinstall is an unofficial simple tool to download and extract package which are specified by user who knows how to do. Because a genuine installer (internal) behavior is undocumented in official Qt site, all the documentation for aqtinstall can be filled only by user contributions.
@tumic0 you may be first person who can contribute to documentation for android packages.

Ok, so you do the same (install the desktop version before the Android version) in your CI test. But the question, whether it is something one would expect/want stays. I would rather see aqtinstall to install a complete/working Qt setup when used to install Qt for the Android target than having to go through the documentation to find the required "hack".

you may be first person who can contribute to documentation for android packages.

I do evidently not have a better knowledge than you have as you already know, that the Android aqtinstall (the official installer works fine) does not work without further actions, it's just missing in the documentation. And here it is much easier for you, who knows how the doc works/is generated to add a sentence like: "You must also install the platform's desktop Qt version for the Android version to work properly" then for me to find it all out. Moreover, I have already learned it the hard way, so being written in the doc is of no use for me anymore... ;-)

@tumic0
Here is a XML metadata file at download.qt.io https://download.qt.io/online/qtsdkrepository/linux_x64/android/qt6_630_armv7/Updates.xml
I cannot find any dependency for gcc_64 binary in the definition from Qt distribution site.  All the specified binaries in the XML file are end with ARMv7.7z in the case.
So even when #332 resolved, this may not be resolved and may need some tweaks.
@ddalcino

There is a potential issue with the way aqt patches android Qt files on Windows; I think it assumes that you have installed Qt for mingw 8.1. I think this will need to change at some point because that architecture doesn't exist for several versions of Qt 6.

I agree that this is another issue we should see.

I cannot find any dependency for gcc_64 binary in the definition from Qt distribution site. All the specified binaries in the XML file are end with ARMv7.7z in the case.
So even when #332 resolved, this may not be resolved and may need some tweaks.

Apologies; I thought I saw it in one of the <Dependencies> tags, and I can't find it now. Clearly, I was wrong. It sounds like this issue is unrelated to #332.
I think I agree with @tumic0 that aqt should be able to install the required desktop version of Qt automatically, but I have questions about how this feature should work.

Should aqt install-qt linux android 6.3.0 also install the desktop gcc_64 version of 6.3.0 automatically, or should a flag be required to trigger that behavior?
a. What should the flag be called?
b. Should the user be able to pass other options to the desktop Qt installation, like --archives and --modules?
For installations on Windows, how should we choose which architecture of desktop Qt to install by default? I think it would make sense to just automatically choose one of the available mingw architectures, but there are often several mingw choices available. For Qt 5.12-5.15, you can usually choose either 64 or 32 bit mingw, and I thought there were a few versions that let you choose between mingw 7.3 and 8.1 (I cannot find them now).

I've had the same problem for a while, building softwares on GitHub CI using aqtinstall to get the latest Qt versions (great tool, thanks guys).
Now using the workaround mentioned here and in other threads (installing desktop then mobile version), it works well enough.
But today I had to build Qt modules (both patched and unofficial modules) before building my own software, and I came across a new problem.
In the file android_arm64_v8a/lib/cmake/Qt6/ there are paths to my desktop install of Qt set in stone, but not in GitHub CI using aqtinstall:
# Set up QT_HOST_PATH and do sanity checks.
# A host path is required when cross-compiling but optional when doing a native build.
# Requiredness can be overridden via variable.
if(DEFINED QT_REQUIRE_HOST_PATH_CHECK)
    set(__qt_toolchain_host_path_required "${QT_REQUIRE_HOST_PATH_CHECK}")
else()
    set(__qt_toolchain_host_path_required "TRUE")
endif()
set(__qt_toolchain_initial_qt_host_path
    "/home/emeric/Dev/tools/Qt/6.3.1/gcc_64")
set(__qt_toolchain_initial_qt_host_path_cmake_dir
    "/home/emeric/Dev/tools/Qt/6.3.1/gcc_64/lib/cmake")

This is easy enough to bypass by using a QT_HOST_PATH environment variable once you understand the problem, but still.
If both versions would be installed at the same time, that variable might have been set automatically?
1/ The Android and iOS versions cannot be used without their desktop counterpart right? So I fail to see why they should be installed separately (even without using a flag, it should probably default to the most common desktop arch)
2/ But yeah I understand that a some kind of indication might be needed anyway. Why not use the name of the directory (the equivalent of gcc_64, I don't now if that has a name) like host=gcc_64.

In the file android_arm64_v8a/lib/cmake/Qt6/ there are paths to my desktop install of Qt set in stone, but not in GitHub CI using aqtinstall:

Yes, there are probably a lot of these. The Updater module does some work to patch a small subset of these files, but there are a lot more that we don't know about. Contributions are welcome!
I have a PR at #540 that should help with this. I will make sure that the path to the desktop Qt install is available in the Updater module.

1/ The Android and iOS versions cannot be used without their desktop counterpart right? So I fail to see why they should be installed separately (even without using a flag, it should probably default to the most common desktop arch)

Automatically installing a desktop version of Qt is a breaking change for the UI. All of our users who are currently using aqt to build android/ios apps are currently installing the desktop version separately. If we start installing the desktop version automatically, we will cause a lot of CI jobs to download hundreds of extra MBs and waste a lot of CPU cycles unnecessarily; that will cost our users real money. I would rather not do that. The new feature in #540 will be opt-in only, and it will emit a warning if you don't use it when you probably should.
You are right that this should probably be an opt-out feature, and that aqt should just "do the right thing" automatically when you don't set any flags. Since this would be a breaking change, it has to wait for version 3 according to semantic versioning rules.

2/ But yeah I understand that a some kind of indication might be needed anyway. Why not use the name of the directory (the equivalent of gcc_64, I don't now if that has a name) like host=gcc_64.

I was asking about the specific case on Windows, where there are multiple architectures available (mingw73_32, mingw81_64, etc). #540 attempts to just pick the newest version available. If the user wants a different version, they can install it themselves.

If we start installing the desktop version automatically, we will cause a lot of CI jobs to download hundreds of extra MBs and waste a lot of CPU cycles unnecessarily; that will cost our users real money. I would rather not do that.

I understand

I was asking about the specific case on Windows, where there are multiple architectures available (mingw73_32, mingw81_64, etc). https://github.com/miurahr/aqtinstall/pull/540 attempts to just pick the newest version available. If the user wants a different version, they can install it themselves.

The desktop installation is there just for the tools? Picking the newest mingw installation should be ok. But I don't cross compile on Windows so I don't really know.
I'll keep an eye on #540 then, thank you for your work!


请问一下 报这个错怎么处理呢 Function.prototype.apply was called on [object Object], which is a object and not a function

这个是wx小程序的
执行完
yarn add @antv/f-wx
然后构建 npm
接下来就报一个
Function.prototype.apply was called on [object Object], which is a object and not a function

我也遇到了，同问

同问，相同报错

一些底层依赖问题，已修掉了


Ramcache disabled does not split remaining free cache

Reported by Steve Malenfant, when setting ram_cache=false the ram cache will not be allocated for that volume, however the ram cache that would now be free to allocate to other volumes is not allocated to them. So the calculation for the ramcache allocation is done across the total size and not total_size-vols_with_ram_cache_disabled_size
Need to see if there is a better way to do this, if we can scan for all ramcache disabled volumes ahead of time to properly split up the remaining ramcache

Current results:
# cat /opt/trafficserver/etc/trafficserver/records.config | grep ram_cache.size
CONFIG proxy.config.cache.ram_cache.size INT<PHONE_NUMBER>04

# curl -s http://<IP_ADDRESS>/_astats | grep volume | grep total_bytes
   "proxy.process.cache.volume_1.ram_cache.total_bytes":<PHONE_NUMBER>68,
   "proxy.process.cache.volume_2.ram_cache.total_bytes": 122868320,
#

# Adding ramcache=false on RAM volume
volume=1 scheme=http size=50%
volume=2 scheme=http size=50% ramcache=false

# curl -s http://<IP_ADDRESS>/_astats | grep volume | grep total_bytes
   "proxy.process.cache.volume_1.ram_cache.total_bytes":<PHONE_NUMBER>68,
   "proxy.process.cache.volume_2.ram_cache.total_bytes": 0,


trying to install node-red but stuck at gyp verb extracted file from tarball include/node/v8.h

I do :
npm install node-red --verbose
After 2 hour, installation progres is stuck at gyp verb extracted file from tarball include/node/v8.h
npm -v
2.15.9
node -v
v4.5.0

Thanks

Can you post the full output?

Here, the maximum line i can copy from the verbose output:

Thank you @bnoordhuis

Can you rm -rf $HOME/.node-gyp and then post the output of npm install --production heapdump?  I picked heapdump because it's a standalone native module, no other dependencies.

@bnoordhuis Ok, here the output:
https://gist.github.com/sumarouno/f606a51b3711ca8d28ff9b6e2af9b0c9
Thanks

Good, we've established that building native modules works.  Can you try rm -rf $HOME/.node-gyp one more time (maybe nuke $HOME/.npm or wherever your npm cache is as well) and try to install node-red again?

Before I post this issue, I tried npm cache clean . Now, I will do your suggestion, and try again. I will give you a report. Thanks

@bnoordhuis , i'm back to give you a report. Now, the installation stuck at gyp verb extracted file from tarball include/node/openssl/pem.h
Thanks.
FYI my OS is Fedora 24

@bnoordhuis
HI, my problem is solved.
I install node-gyp for all user: sudo node install -g node-gyp
And then install node-red for local user: node install node-red
I don't know why, and don't know the real problem, but IT WORK like a charm.
Thanks for helping me


[2|Topic Detail Page] A list of topic resources

 🍰 Appetite 🍰

Property
Value

Points
20 points

Difficulty rating
★★★☆☆

Maximum Assignees
4 person

🤔 Problem Statement

Create a list of items that make up the various resources of the topic that is displayed on the topic detail page. An example of a resource can be a video, a livestream, or an article. A resource can also have external links, or it can have internal links.
As the user clicks on each resource, once they view it, a flag will be set in the database that will indicate they viewed it (like a purple link on a Google Search result). If they have already viewed this resource, the row should somehow indicate its viewed; but doesn't have to be with the word "Done!". A checkmark is fine, for example, feel free to be creative here! There is no need to label it as "New" to start with.
Most resources will look the same inside this list, regardless of their type, but the livestream one is special: it should display a date and time of when the livestream will happen in the row somewhere (it doesn't have to look the same as the sketch), and when you click on it will leave the app and go to an external link. If the livestream is already concluded, instead of displaying the date and time, it should instead show a message saying "livestream over. Click for recording" or something along those lines; and when the user clicks on it, it will take them to the recording page.
The content that is linked on each item, regardless of if it is an external link or internal link, will be managed on Payload CMS. The team responsible for this feature should also make sure that the list fetches the row data from the CMS, and that the proper support for updating what is on the list is added into Payload CMS.
🧪 Required Tests
Mainly screenshot tests, some integrations tests for Payload CMS.
Review the Code & Testing Guidelines for more info.
⚠ Careful about:
No major rabbit holes identified. But always be careful with scope creep!
🤖 Technologies focused on in this feature

React
Tailwind
Shadcn
Payload CMS
NextJS
Supabase/PostGresQL

I would like to work on this one @puma

I want to build this!! @puma

I want to build this one @puma

I would loke to work on this one @puma

@mariannalf @PJ-Bernal @ViniOkamoto @NicoleOkamoto you are now assigned! May the code be with you...

@ViniOkamoto Phase 1 never got completed and the assignees are unavailable. Would you like me to add you to Issue 4 so you can complete it and receive the points?

Hi, You can use https://ui.shadcn.com/examples/dashboard for better UI !

@ViniOkamoto @NicoleOkamoto @PJ-Bernal @mariannalf @khnatiuk
I've assigned points and merged the code.
Please remember to remove the mock when database is implemented


V1.2 Assembly spec update and implementation

Add INC and DEC to increase and decrease the current register by one respectively.
Update spec document to include opcodes, add opcodes to Opcodes in shared project and implement them in the virtual machine.

V1.2 has been fully implemented and is working as expected.


Configure pollInterval with a time.Duration

Description
To configure the polling interval we were using an int in the config field PollInterval.
This field is now deprecated we should use PollingInterval instead that accept a time.Duration instead.
⚠ If you were using PollInterval you should migrate and use PollingInterval. We will continue to support PollInterval during the next versions but will remove it in 1.0.0.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)
Resolve #136
Checklist

[ ] I have tested this code
[ ] I have added unit test to cover this code
[ ] I have updated the documentation (README.md and /docs)
[ ] I have followed the contributing guide

Coverage increased (+0.02%) to 96.748% when pulling a52ebc34b47bcacbf74f985403ea1bcbaf678a56 on change/interval-time-duration into ed104e9a7461f1fa70cfad1c46d48756cf6f7195 on main.


Presence branch

Added status branch reference.


"odigos ui" does not work with custom namespace

odigos install command can be run with custom namespace with the -n flag.
odigos ui can then be used to launch a UI to control odigos, but it also needs to know the namespace to use. The UI binary already accept a -n flag here, but the cli does not propagate the flag to the UI when executing it, thus the UI opens with the wrong namespace and shows empty results.
To fix this, we need to add the following changes to the UI command:

find the namespace of the odigos installation with this function.
Add the relevant -n flag here so the UI binary will be exec.Command(...) with the proper namespace of odigos.
Verify the fix by setting up odigos installation with the instructions here but use odigos install -n foo and then run odigos ui and make sure we can see sources in odigos

I'd like to see if I can work on this and solve this issue. Please assign me this.
Thank you

Awesome @Shauryagulati thank you so much
For any question, please write here or reach out in odigos slack


veracrypt-np: Add version 1.25.9

Closes https://github.com/ScoopInstaller/Extras/issues/2381
Closes https://github.com/ScoopInstaller/Extras/issues/10728

[x] I have read the Contributing Guide.

/verify

Thank you for mentioning this PR, @aliesbelik.
@FlawlessCasual17, I tested your manifest, and it works for me like a charm. However, as of now, there is already version 1.26.7 available. Scoop installs only version 1.25.9, and scoop update doesn't seem to have an effect. Am I using Scoop incorrectly in this case?

@Gabriel-Graf I changed it

may i ask why this PR is not added to main?

may i ask why this PR is not added to main?

You mean the Main bucket?

sorry for the confusion. i meant why is this PR not merged because i would like to install veracrypt with scoop and the extra bucket-repo.

sorry for the confusion. i meant why is this PR not merged because i would like to install veracrypt with scoop and the extra bucket-repo.

Sorry, but you are going to have to wait, as I am doing already, until somebody with admin privileges wants to merge my Pull Request.


feat(registry): gitlab support

Closes #2956 .
Breaking change
With this PR we are building /registries/{id}/proxies/gitlab/api/v4/xxx (strip /registries/{id}/proxies/gitlab) for gitlab API.
For more consistency we change /registries/{id}/v2/xxxx to /registries/{id}/proxies/docker/v2/xxx (strip /registries/{id}/proxies/docker) for docker native registry API.
With this change, we can now proxy any API that starts with the same pattern. E.g. we can proxy a prospective DockerHub API (docker.hub.com/v2/xxxx) with the URL /registries/{id}/proxies/dockerhub/v2/xxxx.

@xAt0mZ please have a quick look at the codeclimate report https://codeclimate.com/github/portainer/portainer/pull/3107 and fix the two gofmt issues.

Any news on this?

cc @xAt0mZ for conflict resolution

@xAt0mZ can we give more information on the required scopes for the PAT ?

@deviantony updated

Took care of the changes and updated layout.

Ready to merge.
Blocked as it requires some update on the extension side and the creation of an extension manifest associated to the develop branch.

https://github.com/portainer/extension-registry-management/pull/19 must be merged first

@xAt0mZ  yeah :raised_hands:


tortoise: provide API to trigger rerun

Description
We need to occasionally trigger a rerun of verifying tortoise to account for new information that may have accumulated for old layers that slipped outside the tortoise window. It's unlikely, but theoretically possible that enough new information (e.g., newly-arrived ATXs or blocks from the other side of a network split) may have arrived that might change the tortoise opinion about block/layer validity.
Right now, we do the Simplest Possible Thing and just trigger a full rerun from genesis every once in a while, but this is highly inefficient:
https://github.com/spacemeshos/go-spacemesh/blob/cccc75614ab32d2bee8d31997706b00dbaf283a7/tortoise/verifying_algorithm.go#L157-L169
It would be better to account for the weight of newly received information, and trigger a rerun only when that weight is high enough to possibly cross the threshold of changing tortoise opinion.
Some other things to figure out (with placeholder TODOs in the code):

should the rerun happen "in the background" in a separate goroutine? does it need to hold the tortoise mutex? related to #2415
how to handle errors

Affected code
tortoise/verifying_algorithm.go
Possibly related to sync: CC @countvonzero
This issue appears in commit hash: e13b3aa467335aef4d3552348ef929f419f72e94

@dshulyak still relevant?


RESEARCH carbon emissions per banana

1.28 kgCO2eq per kg bananas
Source

A medium sized banana is ca. 150 g


Feature/nav 174 implementation raptor xx

info, i will add next to the time measure table the system info on what ma machine i ran the tests.
@Brunner246


perf(connector): support zero-copy access during parsing

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add a new method named access_cow to Access trait, allowing implementors to return a borrowed DatumRef, to achieve zero-copy parsing.
Currently only Varchar field in JSON returns a borrowed ScalarRef. This improves the performance by ~11% in micro-benchmark nexmark_integration. Will adopt it more in following PRs.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#17153  👈
#17146
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on  Graphite

Merge activity

Jun 10, 12:51 AM EDT: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.


Bring in US Core extensions for patient profile

@dwwinters Why are there null values here when we know how these should be represented according to US Core?
Originally posted by @mickohanlon23 in https://github.com/ccsm-cds-tools/ccsm-cds-with-tests/pull/23#discussion_r918224821

These have all been addressed in subsequent pull requests. patientInfo no longer has null values for any of its fields.


Incorrect format of "ignoreURLParametersMatching" values generated via workbox wizard cli command

Library Affected:
workbox-cli
Browser & Platform:
Windows
Issue or Feature Request Description:
Running workbox wizard resulted in the following config file:
module.exports = {
  "globDirectory": "dist/",
  "globPatterns": [
    "**/*.{js,webmanifest,html,png,css}"
  ],
  "swDest": "dist/sw.js",
  "ignoreURLParametersMatching": [
    "/^utm_/",
    "/^fbclid$/"
  ]
};

Running workbox generateSW on this config file results in this error:
[1] "ignoreURLParametersMatching[0]" must be of type object

From the docs, it is clear that ignoreURLParametersMatching expects an array of Regular Expressions, not strings.
The wizard script should be fixed to reflect this.

Same here

Thanks for reporting this; we have a PR out to fix it, but in the meantime, feel free to manually edit the config file to remove the " around the RegExps.


update to 0.2.0

Description

Vagrant provisioner script

Fixes: # Needs an issue
How Has This Been Tested?

Manual test with vagrant and virtual box

Ran through setup guide in docs/quickstarts/VAGRANTVBOX.md

How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[x] updated the documentation and/or roadmap (if required)
[x] added unit or e2e tests
[x] provided instructions on how to upgrade

Hey @james-martinez , we just merged a PR that uses the Tinkerbell Helm chart v0.4.2 and remove a significant amount of code. Please do check it out. If you still want PR this, please do reopen the PR. Thanks for your intent to contribute!

Just in time for kubecon


Add stage target

Closes #1

Codecov Report

Merging #29 (e40bd05) into main (b881d76) will increase coverage by 0.02%.
The diff coverage is 92.39%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   95.69%   95.71%   +0.02%
==========================================
  Files          10       10
  Lines        1300     1354      +54
==========================================
+ Hits         1244     1296      +52
- Misses         56       58       +2

Flag
Coverage Δ

unittests
95.71% <92.39%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

build_magic/cli.py
93.83% <92.39%> (+1.52%)
:arrow_up:

build_magic/core.py
93.75% <0.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b881d76...e40bd05. Read the comment docs.


Create spacewar.ts

Submitting a clone of Spacewar! for consideration in the user gallery.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alex-kulcsar sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

We should probably rename it just to be safe... Spacefight? (suggested by @jwunderl)

Fine by me, @jwunderl and @riknoll. I've updated the commit, but the splash screen still includes an appropriate attribution. Let me know if you want me to remove that.

I really like this one!
There's a lot of blocks in there, so I split a few parts up with functions and other minor changes to cut off about 100 blocks to get it down to 675 - still a bit too high to go to typescript and back, but we can work on that a bit. I also accidentally pressed Format Code, so it's laid out a bit differently from the one you linked but should behave the same. https://makecode.com/_A8CA91C4FixV
A couple minor things;

it feels like the game tends to end really quickly, as I end up hitting either the star or the other player within about 5-10 seconds most of the time -- maybe we can remove some of the game overs and convert them to just reset the player and give score to someone? Or possibly even just go for a one minute timer, with the goal being to get the most points by then (either by destroying the other player, or reaching the goal a bunch, etc).
It might be worth just moving the just using on game update events to handle fuel and rockets instead of being exact about the timing; it cuts off another ~85 blocks, which can be important on computers that aren't high end: https://makecode.com/_PCueTXE5aHMm . The timings a bit off with that (e.g. sometimes you'll fire a rocket and then immediately get one back), but you can regain much of the timing either with some flags (e.g. ignore the first time it would refuel in a row flip the flag, then continue to refuel while the flag is true / set it to false when full) or by increasing the number of fuel and rocket 'units' consumed and obtained (instead of 1 every 5 seconds, use 10 at once but get them every half second, etc)

A couple other tangential things;

I like your 'draw text' extension a lot, I'll have to take another look at it some time
For your extensions, you can add a variable dropdown for blocks with variables.shadow="variables_get", so you don't have holes in the blocks when users drag them out. Related: There's a minor bug preventing them from behaving perfectly - https://github.com/Microsoft/pxt-arcade/issues/409 - but if you omit the initial value in parens they will show up nicely for now
This game really makes me think we should add a single block to set default values for controller repeat events delay and interval (related: https://github.com/Microsoft/pxt-arcade/issues/767). That way we can cut half the controller events in this game immediately, and also make it easy to use repeat events in a wider variety of contexts

Thanks, Joey (@jwunderl)! Glad you liked! I've added you to the list of credits. :-)
I've done some updates to the gameplay, using your comments as guidance. Give this a try and see what you think as far as gameplay is concerned:
https://makecode.com/_ffxf03UiT2hy
Changes that I've added to your modifications:

Shortened the game clock to two minutes.
Collisions with the star or with another player no longer end the game. They now count toward players' scores instead.
The version that I provided to you somehow was missing the warp (a.k.a. hyperspace) functionality. I've added it to this version.

it feels like the game tends to end really quickly, as I end up hitting either the star or the other player within about 5-10 seconds most of the time -- maybe we can remove some of the game overs and convert them to just reset the player and give score to someone? Or possibly even just go for a one minute timer, with the goal being to get the most points by then (either by destroying the other player, or reaching the goal a bunch, etc).

SpaceFight! used SpaceWar! as its starting point, including the replication of the original game play -- a ten-minute timer with the game ending on collision with the gravity well or another player. Because the screen in MakeCode Arcade is considerably smaller than the oscilloscope used on the PDP-1, it makes the MakeCode Arcade game considerably more challenging.
I retained the original gameplay to fulfill my own needs for the course that I am writing. Because this version does not need to be an actual clone, I'm happy to alter the gameplay to make it more appropriate for this platform. It's provided me with an interesting thought exercise, and it's something that I will document in my course.

It might be worth just moving the just using on game update events to handle fuel and rockets instead of being exact about the timing; it cuts off another ~85 blocks, which can be important on computers that aren't high end: https://makecode.com/_PCueTXE5aHMm . The timings a bit off with that (e.g. sometimes you'll fire a rocket and then immediately get one back), but you can regain much of the timing either with some flags (e.g. ignore the first time it would refuel in a row flip the flag, then continue to refuel while the flag is true / set it to false when full) or by increasing the number of fuel and rocket 'units' consumed and obtained (instead of 1 every 5 seconds, use 10 at once but get them every half second, etc)

I love this idea! I did not realize that you could have multiple game.onUpdateInterval() routines, nor that you could use them in conjunction with game.onUpdate(), so that never entered my thoughts as a possibility. I've retained your modifications in this regard and built on them in this revision. The minor timing issues that you mentioned don't bother me for this game. I also will keep this in mind for future games!

I like your 'draw text' extension a lot, I'll have to take another look at it some time

Thanks, Joey. Y'all did most of the work; I just exposed some of the functionality in Blocks form. I was worried that I was going to have to create bitmap fonts, figure out how to load them, and all of that other stuff. When I realized that y'all had already built image.print() routines, everything fell into place.
The GitHub repository for the extension is here:
https://github.com/robo-technical-group/pxt-arcade-display-strings

For your extensions, you can add a variable dropdown for blocks with variables.shadow="variables_get", so you don't have holes in the blocks when users drag them out. Related: There's a minor bug preventing them from behaving perfectly - #409 - but if you omit the initial value in parens they will show up nicely for now

Excellent feedback, Joey. I've already updated my extensions with the shadows. I'll keep an eye on #409 and, when that gets corrected in production, I'll update the extensions again to suggest a more appropriate default variable.

This game really makes me think we should add a single block to set default values for controller repeat events delay and interval (related: #767). That way we can cut half the controller events in this game immediately, and also make it easy to use repeat events in a wider variety of contexts (added in Microsoft/pxt-common-packages#794)

Let's revisit this again when Microsoft/pxt-common-packages#794 gets incorporated into pxt-arcade and pushed out to production. I'd like to remove the duplicate code for the controller events when that's possible, as that obviously will help with the block count.
Let me know if you'd like to make additional changes to the code to SpaceFight! and I'll be happy to incorporate them back into the pull request. Otherwise, let me know that you're happy with the game as-is, and I'll update the pull request with the current URL and code.
Thanks again for the time and energy, Joey. It means a lot.

@alex-kulcsar There's a small error in the destroyPlayer2 function (if (true)) but besides that it looks great to me!

If you could update the file with the new version of the code, and possibly rename it docs/community/spacefight.md (markdown file extension instead of typescript), it should be good to go for me; I can make the community page and add this to it / link the extensions in a separate pr. For now, it'll have to be displayed as a typescript game, as the docs are all saved as typescript and it seems like it has a few too many blocks to decompile for now (but the link will still show it is originally created in blocks, of course)
Also, if we could see your course when you're finished, it sounds very interesting from what I've seen on the forum / here!
(also tagging @ganicke in case I missed anything)

Change the file from *.ts to *.md and put it in the ./docs/community path. Edit it to also include:
# Space Quest

` ` `blocks
...TS example source here...
` ` `

Good catch, Joey (@jwunderl). Given that both you and @ganicke mentioned that the file should be posted as a MarkDown file, you may want to update the instructions at https://arcade.makecode.com/game-submission, as it currently says to create a TypeScript file.
The new version of SpaceFight, which will be referenced in the updated commit, is available at https://makecode.com/_e2LM0JKsiFee
I'll update my repo shortly. Thanks again for all of your great feedback!

Since Joey was so kind to mention it here, and since I failed to do so in my previous comment (oops!), I'll briefly comment here. :-)
The course that I am writing has a ways to go yet, but I'm having a ton of fun! MakeCode Arcade has provided me with a perfect platform. The course outline is done, and I'm working on some smaller activities before diving headlong into writing.
I'm also reading Seymour Papert's Mindstorms at the moment. He and Jean Piaget were such instrumental forces in the constructivist model, and I want to make sure that I am properly incorporating those ideas in my own teaching. It's been a very long time since I've read material from either of them, and I figured now would be a good time to refresh my memory. :-)
I'll be sure to post about my progress in the MakeCode forums. Thanks again for the encouragement, Joey!

Thanks again for submitting! I'll be adding an attribution at the bottom when I fix up the contribution guide and add links for this, so let me know if there's anywhere you want linked or anything else you want mentioned -- I saw http://www.alexkulcsar.com/ on your profile. (If you'd prefer to phrase it yourself, here's an example of a submitted example for micro:bit: https://makecode.microbit.org/projects/karel)

Hi Alex! I'm the PM on the MakeCode Team, and loving that you're digging into Arcade and putting it through its paces!  MakeCode was created based on the Constructionist Learning Theory and we take a lot of our design cues from that philosophy of iterative, learning-by-doing approach.  Awesome that you are building your course incorporating this philosophy!  Keep the feedback and suggestions coming!  We are happy to continue collaborating with you and would be honored to post and help promote your work.  Thanks again for digging into Arcade!

@alex-kulcsar we're trying to make this process a little more clear: #922