Get master performance workers working again

Merging early: everything this could affect is broken anyway.

@dgquintas - assuming this works, it likely wants to be pulled into v1.2

@ctiller   why do we need port_server.py to run on performance workers? (if microbenchmarks need it, they should start it, but AFAIK qps_workers have nothing to do with port_server)


First screen appears on pressing back

Describe the bug
Hi, I have 6 screens in the bottom nav bar, From any index except 0, when I click android back button, index 0 screen appears but selected item of bottom app bar not updated, on Pressing second-time android back buttom, Bottom nav bar  selected item updated to 0 index.
To Reproduce
Steps to reproduce the behavior:

Take 6 items and thier screens.
From bottom nav bar click on any bottom nav bar item except first
Click the android back button
First screen appears , but bottom nav bar item still showing that 3rd/4th screen is selected.

Expected behavior
Either it will not be navigated to first screen or if navigated , then nav bar item will be updated with android back button

I followed your steps but sadly was not able to reproduce your issue. Can you post a minimal example that shows your behavior and tell the version of this package that you are using?

I followed your steps but sadly was not able to reproduce your issue. Can you post a minimal example that shows your behavior and tell the version of this package that you are using?

Its fixed for me now , so i close this issue.

I followed your steps but sadly was not able to reproduce your issue. Can you post a minimal example that shows your behavior and tell the version of this package that you are using?

Its fixed for me now , It was not an issue in your code, so i close this issue.

how can you fixed it? i face with the same problem


bugfix: make the jsonfile log friendly

The file related error may be os.ErrClosed. If so, we can show the
container has been stopped.
Signed-off-by: Wei Fu<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Make the jsonfile log friendly.
Ⅱ. Does this pull request fix one issue?

Fixes #1325
Ⅲ. Describe how you did it
Since the error has been wrapped by the Write function, we should use the strings.Contain to check the error if it contains the file already closed.
Ⅳ. Describe how to verify it
Basically, it's hard to verify it without change the logic, because it causes by the concurrent issue:
Before jsonfile writes the data into the file, the container manager has been stopped it and closed it.
In order to make it happen, we can add the time.Sleep before Write. It will show up.
Ⅴ. Special notes for reviews

Codecov Report

Merging #1330 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
- Coverage   17.33%   17.32%   -0.01%
==========================================
  Files         189      189
  Lines       11815    11818       +3
==========================================
  Hits         2048     2048
- Misses       9619     9622       +3
  Partials      148      148

Impacted Files
Coverage Δ

daemon/containerio/jsonfile.go
1.42% <0%> (-0.07%)
:arrow_down:

LGTM


Deployment failing due to seed not working

Have you experienced this bug with the latest version of the template?
Yes
Steps to Reproduce
Running the CI/CD pipeline through github actions or the fly deploy and then I get error that results in failure of deployment.
Expected Behavior
Deployment works and seeding succeeds
Actual Behavior
2022-12-29T09:58:59Z app[63b7991f] sea [info]Running seed command `ts-node --require tsconfig-paths/register prisma/seed.ts` ...
2022-12-29T09:58:59Z app[63b7991f] sea [info]An error occurred while running the seed command:
2022-12-29T09:58:59Z app[63b7991f] sea [info]Error: Command failed with ENOENT: ts-node --require tsconfig-paths/register prisma/seed.ts
2022-12-29T09:58:59Z app[63b7991f] sea [info]spawn ts-node ENOENT

Looks like as the "prisma.seed" in the package.json and using ts-node while the Dockerfile in production image doesn't have ts-node so it just fails. I couldn't find where the prisma seed is being invoked from either in docker file or elsewhere so not sure what needs to be moved where.

prisma db seed will automagically run when prisma does migrations docs

@mcansh the main issue I see is the following.
Running seed command `ts-node --require tsconfig-paths/register prisma/seed.ts` ...

I think that seems to happen because the Dockerfile only copies the node_modules that are in production dependency while the ts-node is in devDependencies. I tried changing that in docker file and that fixed the issue.
FROM base

WORKDIR /myapp

COPY --from=production-deps /myapp/node_modules /myapp/node_modules

I can confirm that Fly is not automatically seeding the DB when deploying with this stack.  I've reached out to Fly support to see what can be changed.  I believe the Indie Stack had a similar issue and a change was made that got it working.

From my testing so far, removing --require tsconfig-paths/register allows the seeding to proceed for at least the example provided by this stack.  If, for some reason, tsconfig-paths is really required for seeding, it should no longer be a devDependency.  Either way, it is likely that some change to this stack is required in addition to the changes I'm making to fly.

@kentcdodds Can you remember why --require tsconfig-paths/register was added to the seed script in the first place?

It's so you can import things using the ~ feature common to most Remix app setups.

So I guess we should move tsconfig-paths to dependencies then?
Although I don't think seeding is happening in production, so it's fine to have it in devDependencies 🤔

For now I am getting around it this way:

create a tsconfig.seed.json for compiling the seed.ts to JS

    "include": ["./prisma/seed.ts"],
    "compilerOptions": {
      "lib": ["ES2019"],
      "target": "ES2019",
      "moduleResolution": "node",
      "module": "CommonJS",
      "esModuleInterop": true,
      "resolveJsonModule": false,
      "skipLibCheck": true,
      "experimentalDecorators": true,
      "outDir": "./seed-dist",
      "baseUrl": ".",
      "paths": {
        "~/*": ["./app/*"]
      }
    }
  }

Add this script to my package.json:
"seed:build": "tsc --project ./tsconfig.seed.json && tsc-alias -p ./tsconfig.seed.json"

Run the script to generated a compiled JS seed file at the seed-dist/seed.js path.

Commit and deploy.

After deploy fly ssh to the app, and run node myapp/seed-dist/seed.js.

This could probably be automated, but I still consider it a workaround and not a long term solution.  The reason this compilation is necessary is because trying to fly ssh and run ts-node prisma/seed.ts leads to OOM and other dependency errors.  Hope this is helpful for anyone until the stack is updated to automate it.

Although I don't think seeding is happening in production, so it's fine to have it in devDependencies 🤔

With fly.io, seeding is run using the same image as what will be used in production.

@rubys Should we create another build for doing so?
All tsconfig-paths docs are referring to installing it as a dev dependency

On fly.io, build machines don't have access to secrets or postgres databases.  Looking at the prisma documentation, it looks like seeds aren't applied on the first prisma migrate deploy, and I don't see any information on the bluestack readme on how to apply seeds in production - am I just missing it?
In any case, the way it works out is that the only place where you can run your seed script on fly.io machines is on a machine that is set up for production.


Deal with invisible chars

Like BOM - https://en.wikipedia.org/wiki/Byte_order_mark, now they marked as a whitespace, it seems we just need to miss them

+1 to get this fixed, it used to work fine before upgrading to version 3

I would also like to see this fixed, although I believe it's partially a problem in Babylon. In Babylon, they tokenize the JS, but if there is a BOM at the beginning of the file, the first token starts at index 1. Then in cst (elementTree.js: 163), anything between the last token (nothing) and the next token (first token) is made into a whitespace token. So there's a whitespace token with only an invisible character as the first token, then the next token is where it actually starts. So, at that point, cst could ignore/throw away the BOM, label it as another token, or keep labeling it as whitespace and let the users deal with it. I almost made a pull request, but I wasn't sure what the devs wanted to do about it, so I ended up just making a temporary change in JSCS.

Sounds like you figure it out - send a pull request :)
Regards,
Oleg

On 20 Jul 2017, at 16:28, Colin Ashburn<EMAIL_ADDRESS>wrote:
I would also like to see this fixed, although I believe it's partially a problem in Babylon. In Babylon, they tokenize the JS, but if there is a BOM at the beginning of the file, the first token starts at index 1. Then in cst (elementTree.js: 163), anything between the last token (nothing) and the next token (first token) is made into a whitespace token. So there's a whitespace token with only an invisible character as the first token, then the next token is where it actually starts. So, at that point, cst could ignore/throw away the BOM, label it as another token, or keep labeling it as whitespace and let the users deal with it. I almost made a pull request, but I wasn't sure what the devs wanted to do about it, so I ended up just making a temporary change in JSCS.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


print effective port when port is automatic (zero)

fix #142
example output
$ pproxy
Serving on ipv4 <IP_ADDRESS>:8080 by http,socks4,socks5
Serving on ipv6 :::8080 by http,socks4,socks5

$ pproxy -l http://<IP_ADDRESS>:0/
Serving on ipv4 <IP_ADDRESS>:35847 by http

$ pproxy -l http://<IP_ADDRESS>:0/
Serving on ipv4 <IP_ADDRESS>:35041 by http

$ pproxy -l http://<IP_ADDRESS>:0/
Serving on ipv4 <IP_ADDRESS>:41479 by http

thanks for merging : )
note to future: this could be made better
ipversion = "ipv4" if f == "AddressFamily.AF_INET" else ("ipv6" if f == "AddressFamily.AF_INET6" else "ipv?") # TODO better

https://docs.python.org/3/library/socket.html#socket-families


new(website): add sticky graduation announcement

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind user-interface
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area documentation
What this PR does / why we need it:
Add the graduation banner on top of each page
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
to check the preview

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 0b28cfc30d896c8621168d16980301f10718384d

/unhold


Update performance test results for Ballerina v1.1.0

Purpose
This PR updates the performance test results for Ballerina v1.1.0.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20491 into release-stage will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-stage   #20491   +/-   ##
==============================================
  Coverage          15.21%   15.21%
==============================================
  Files                 50       50
  Lines               1341     1341
  Branches             208      208
==============================================
  Hits                 204      204
  Misses              1121     1121
  Partials              16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8f307...85dbcc3. Read the comment docs.

@ldclakmal I think we should change the base to ballerina-1.1.x


Added 'switchit' - cli app framework

switchit is a framework to build modern OOP-based, promise-aware command-line applications and I believe it should be included in the awesome-node list! :)

Nice work, but too much OOP for my taste. Seems like classes and inheritance are used in many places just for the sake of it. I personally much prefer yargs.


fix: 1.2.1

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Migrate docs to readthedocs

Currently, we are building our documentation site with a github action and hosting at the github pages.
This approach gives more flexibility sometimes but comes with some cost on time to maintain things.
I believe it will be better if we migrate to readthedocs and also to change our theme to the jupyter-book theme.
These are highly maintained tools and I think we will have an easier time keeping our docs working.

Closed with #808.


pkg/ipam: protect map against concurrent access

Fixes: 58579f18280c ("ipam: Use Blacklist() to reserve IP in allocation range")
Signed-off-by: André Martins<EMAIL_ADDRESS>Fixes #8278

This change is

test-me-please

test-me-please

Coverage decreased (-0.003%) to 42.012% when pulling 7b5c54c7fffdba227be47d3d2f28c644f3bde65e on pr/fix-ipam into ab10bc531b58d15d65eff08f13342eb9f9774b52 on master.


ChefBuildError Installing mmh3

Would appreciate any help.
When following steps of Quickstart: first of all I had created venv by VS Code. And then after the venv created by poetry, activate the shell, and "poetry install", the error message:
• Installing mmh3 (3.0.0)
ChefBuildError
Backend subprocess exited when trying to invoke build_wheel
running bdist_wheel
running build
running build_ext
building 'mmh3' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
at env_chatgpt-retrieval-plugin\lib\site-packages\poetry\installation\chef.py:152 in _prepare
148│
149│                 error = ChefBuildError("\n\n".join(message_parts))
150│
151│             if error is not None:
→ 152│                 raise error from None
153│
154│             return path
155│
156│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:
Note: This error originates from the build backend, and is likely not a problem with poetry but with mmh3 (3.0.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "mmh3 (==3.0.0)"'.

I had already visited and installed the latest Microsoft C++ Build Tools. And then, run:
pip wheel --use-pep517 "mmh3 (==3.0.0)"

Collecting mmh3==3.0.0
Using cached mmh3-3.0.0.tar.gz (10 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: mmh3
Building wheel for mmh3 (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for mmh3 (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [5 lines of output]
running bdist_wheel
running build
running build_ext
building 'mmh3' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for mmh3
Failed to build mmh3
ERROR: Failed to build one or more wheels

Resolved because C++ Build Tools were not properly installed when using the installer. C++ should be selected for installation.


Support connector Core Tables in fivetran_connector_schema_config

Currently if you provide a connectors 'core tables' in the schema config, it will successfully apply, but then if you do another plan/apply the Fivetran provider thinks the 'core tables' don't exist and attempt to apply them again.
This is because the underlying Fivetran API doesn't return 'core tables' when Terraform does the refresh.
Is there a way to support this scenario by either having Fivetran's API return Core Tables, or the Fivetran Terraform provider filtering out the Core Tables in the schema config? Or maybe something else?

Hi @michael-robbins, thank you for reporting this! I created internal ticket.


Update README.md

A minor text correction to the "Add a header to a bigWig file" README section

Good catch, thanks!


Automatic PR from RestAPI-PR1877

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/1877

Codecov Report

Merging #1566 into master will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1566     +/-   ##
=========================================
+ Coverage   54.18%   54.39%   +0.2%
=========================================
  Files        3595     3594      -1
  Lines       88698    88328    -370
=========================================
- Hits        48065    48046     -19
+ Misses      40633    40282    -351

Impacted Files
Coverage Δ

...17_09_01/operations/network_watchers_operations.py
6.69% <ø> (+0.07%)
:arrow_up:

...9_01/operations/application_gateways_operations.py
9.05% <ø> (+0.49%)
:arrow_up:

..._09_01/operations/network_interfaces_operations.py
52.04% <ø> (+11.03%)
:arrow_up:

...2017_09_01/operations/load_balancers_operations.py
95.93% <ø> (+16.6%)
:arrow_up:

...01/operations/local_network_gateways_operations.py
16% <ø> (+2.61%)
:arrow_up:

...17_09_01/operations/virtual_networks_operations.py
84.75% <ø> (+11.45%)
:arrow_up:

...09_01/operations/public_ip_addresses_operations.py
65.1% <ø> (+7.83%)
:arrow_up:

...etwork/v2017_09_01/operations/usages_operations.py
93.75% <ø> (ø)
:arrow_up:

.../operations/virtual_network_gateways_operations.py
15.58% <ø> (+0.87%)
:arrow_up:

...01/operations/express_route_circuits_operations.py
67.24% <ø> (+6.62%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b3ce0...0729fcd. Read the comment docs.

Wrong branch


fix(hosts): extra-host params should be 'domain:ip'

@AkihiroSuda Could you please help me merge this pr? ^_^

@tosone
ping https://github.com/containerd/nerdctl/pull/1267#discussion_r933314875


Reproduce OutOfBounds error when hvar index map has fewer entries than glyphs

https://github.com/googlefonts/fontations/pull/668#issuecomment-1775536793
/cc @drott

fails as expected:
https://github.com/googlefonts/fontations/actions/runs/6617440064/job/17973745815?pr=670#step:5:127
thread 'tables::hvar::tests::advance_deltas_from_hvar_with_truncated_adv_index_map' panicked at read-fonts/src/tables/hvar.rs:108:22:
called `Result::unwrap()` on an `Err` value: OutOfBounds


Revert "Modified ip_ranges to accept no arguments"

see https://github.com/winebarrel/piculet/pull/13#issuecomment-107134590

Sweet, altough you can just rebase... but that's a matter of taste


Update CarbonPlan images

@maxrjones test this out and let us know if this works?

@maxrjones test this out and let us know if this works?

Works great! I'll open a separate PR to make Pangeo notebook the default while we work on the custom images.
Thanks for both of your reviews! Hope the conference is going well!


Disk: Update Size value in example

This Pull Request (PR) fixes the following issues
A value with a size unit (like MB or GB) does not work.
It generates the following error message:

Compilation errors occurred while processing configuration 'DscConfigurationName'. Please review the errors reported in error stream and modify your configuration code appropriately.

CategoryInfo : InvalidOperation: (DscConfiguration:String) [], InvalidOperationException
FullyQualifiedErrorId : FailToProcessConfiguration

Entering only a number works fine.
Task list

[ ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md in the resource folder.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #214 into dev will not change coverage.
The diff coverage is n/a.

@@        Coverage Diff         @@
##           dev   #214   +/-   ##
==================================
  Coverage   95%    95%
==================================
  Files        7      7
  Lines      980    980
==================================
  Hits       939    939
  Misses      41     41

Hi @fullenw1 - that is really strange. Using 10GB etc should work and passes the example compilation tests. See: https://ci.appveyor.com/project/PowerShell/StorageDsc/branch/dev?fullLog=true#L565
How are you compiling the examples?

Hi @PlagueHO

How are you compiling the examples?

As I got the error message, I spotted by dichotomy the size parameter.
My intended value was different but I gave a try to 10GB like in the example (just copied/pasted the value) and got the same error.
When I used<PHONE_NUMBER>0 (the size in bytes), the error message disappeared.
By the way I got the exact same behavior on another resource:
https://github.com/PowerShell/ComputerManagementDsc/pull/278

I tried this as well yesterday and you're right - it is failing. Not sure how the Example tests are passing though. That is something I should look into. Anyway, let's proceed with this change.
Can you add an entry into the CHANGELOG.MD for this change?

Can you add an entry into the CHANGELOG.MD for this change?

Done!
Please have a look. First time I do this on a DSC module...

Closing because superseded by #218


I can't get mutation line using get_next_dialogue_line() method

Describe the bug
I'm trying to find out if there is a do something() method after my dialog line. The something() method is in the DialogueScreen node. When I try to check if there is a mutation using get_next_dialogue_line() I get the error "Assertion failed: Method "something" not found. States with directly referenceable properties/methods/signals include "TestScene". Autoloads need to be referenced by their name to use their properties." Although the something() method itself works fine.
Affected version

Dialogue Manager version: 2.41.4
Godot version: 4.3

To Reproduce

Create method something() in DialogueScreen node (that contains all balloon logic including responses and DialogueLabel node)
Call that method in dialogue resource file after some line (let's say after line 5)
Try to check if there is mutation line "do something()" after line 5 using get_next_dialogue_line(dialogue_line.next_id) method

Can you attach a tiny project that demonstrates the issue?

Here is project. If you comment 151 line in balloon.gd and run dialogue.dialogue it will work fine and something() func on line 160 will also work. But if you uncomment 151 line and run dialogue again you will get error "Assertion failed: Method "something" not found. States with directly referenceable properties/methods/signals include "TestScene"
tinyproject.zip

Alright, after adding temporary_game_states to get_next_dialogue_line, the error does indeed disappear. However, in the resulting DialogueLine, we immediately land on the fifth line. This can still be reproduced in the tiny project I sent earlier.
line 3: Nathan: [[Hi|Hello|Howdy]], this is some dialogue.
(Here I check if there is any mutation on the next line using resource.get_next_dialogue_line(dialogue_line.next_id, temporary_game_states))
line 4: do something()
line 5: Nathan: Here are some choices.
(For some reason, get_next_dialogue_line returns this line, skipping the one with the mutation.)


Document validation error message format in time_options.proto

In this PR we move from using the String.format(..) syntax for the constraint violation messages to the new syntax with placeholders.
The validation will eventually be removed from base and time. Thus, we only modify the option declaration. The old validation lib parts are left intact.

@armiol, PTAL.


Check a time like cron settings instead of every x minutes

Hi, it would be beautiful if at line 52 of sheperd file (sleep "$sleep_time") there will be a "cron style" check.
Let me explain: on an ENV var you insert a string like "30 22 * * 1". This string means "at 22:30 of every day in every month but only on monday".
Then on script you can check if this conditions are met and if yes you fire the update.
May be a useful idea?

Would be interesting. As I do not need this myself, I am open for a PR.

Maybe there's lot of enhancement, i'm not so expert in programming


Builder api for EM engine

Add a bunch of params to the engine builder so that rtds and sds tests can be run with override_builder_config_ = false.
TBD before shipping: Add these build API params to the other languages.  Wait for formatting CI to un-break.

Talked with Alyssa and I'll put this on hold for a sec.  We realized that...

These tests are supposed to be using DFP not direct addressing.  So I will fix that in a separate PR before this one.
It will be wise to break this out into separate PRs, so I will start with just doing the admin piece in all languages.

Still good imo to have done it all in one place so at least we know this works.

These tests are supposed to be using DFP not direct addressing.  So I will fix that in a separate PR before this one.

Not sure I follow; the integration tests (e.g. rtds_integration_test.cc, sds_integration_test.cc) use clusters with a single fake upstream as an endpoint.  Where would DFP come into play?

It will be wise to break this out into separate PRs, so I will start with just doing the admin piece in all languages.

+1 on splitting out into separate PRs.

The clusters have a single fake upstream yes but I'm told it's better to use DFP since that's how envoy mobile actually works in practice, and this is also how the other tests work.
In other words we would point the xds cluster at xds_cluster.lyft.com and let DFP work out the IP.

sorry if I wasn't clear I think we want DFP for data plane.  For xDS I think for production use cases we're probably going to want logical dns, pointed at whatever the public TD hostname is (trafficdirector.google.com) and for tests it's fine to point to ip:port - I think the addXdsCluster API should take a string and if that string is an IP adress we set up the clutster we have today, and we TODO to hand the other case later?

sorry if I wasn't clear I think we want DFP for data plane. For xDS I think for production use cases we're probably going to want logical dns (yet another cluster type) pointed at whatever the public TD hostname is (trafficdirector.google.com) and for tests it's fine to point to ip:port

Ah yes, that makes perfect sense.  Thanks for clarifying!

I think the addXdsCluster API should take a string and if that string is an IP adress we set up the clutster we have today, and we TODO to hand the other case later?

+1, makes sense to me.


Fix untyped PLC tests

Semantic merge conflict between the UPLC PR and the CEK PR. Fairly sure this is the right thing (at least the tests pass).

Merging to unbreak master, do check my work though!


remember window size

the programm should remember the window size and maybe the position

the programm should remember the window size and maybe the position

Yes please fix this to where it remembers the window size because it opens nearly in full screen every time.

Same issue here. Please fix the window size!


empty vector/pointer

In Arduino I can run the QuickStart Example with my own credential and I get the statusReport, but when trying the TypicalExampel the display boots when executing the command with the getIndoorModulePointer. It seems the Vector/pointer is empty and not caught. I can't figure out why it should be empty if the generateFullStatusReport is working
I'm using a Lilygo T5 4,7 display - and this is my first atemt with ESP32 and C im very long timer.....

Hi, I tried to reproduce the issue but unfortunately I have troubles with my netatmo station.
I agree with you, the description of the symptoms you've made match a pointer issue.
I suspect the origin of your issue to be the way the library return the pointers of the indoor and outdoor modules .
Could you replace the indoorModule by the rainGauge, the windModule or the stationModule? and then tell  me if it didn't work

By replacinrg :
IndoorModule* indoorModule;
with
RainGauge* rainGauge;
And
indoorModule = station.getIndoorModulePointer();
with
rainGauge = station.getRainGaugePointer();
And in the void loop() changing the code to :
station.update();
float last_24hr_total_rain_mm = rainGauge->getLast24hrTotalRainMM();
uint32_t timestamp = rainGauge->getMeasureTimestamp();
Serial.println("at "+ String(timestamp) + ", for the last 24H there has been "+ String(last_24hr_total_rain_mm) + "mm rain");
The code is working OK without reset.
As mentioned my C knowledge is 30year old, and OO in C++ is hard to read for me. But I was wondering why you are using vector in the indoor and outdoor modules but not in the others.

okay, thanks, that confirm my hypothesis. I certainly made a mistake in using vector for indoor and outdoor modules. I used vector because it allowed me to make lists of dynamicaly allocated module , as the number of such module could vary from user to user, I used vector.But I believe that a simple list should be enough and I will make the modifications when my netatmo station will work again


multiple headers, increased GET timeout, for_loop search for Graphiql…

As mentioned in issue #12

Hi! thanks for the PR - can you bump up the version?

I think I've done it now.. first time though, please check


Migrate Command: !shutdown

I actually can't think of a reason for this command anymore, so I'm not migrating it.


footer icons fixed correctly

Fixes Issue #7422

Changes proposed
Based on the suggestions of @dan-mba I changed the icons(viewBox) which was present in the footer.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

@shaikahmadnawaz We appreciate the enthusiasm about contributing to the PR. But please keep the guidelines of the projects in mind.
Please do not create a PR before the issue is assigned to you. I have assigned the issue to you this time but please keep this in mind next time. Thank you.
You can read the guidelines here https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

@shaikahmadnawaz We appreciate the enthusiasm about contributing to the PR. But please keep the guidelines of the projects in mind.
Please do not create a PR before the issue is assigned to you. I have assigned the issue to you this time but please keep this in mind next time. Thank you.
You can read the guidelines here https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

Okay, I will remember and follow them 👍

Looks good 👍

Thank you.


AddOptionContract() is unable to fetch the current price of the option contract

Expected Behavior

With OptionChainProvider, the specified option contract should be available to trade immediately after AddOptionContract().
Actual Behavior

As AddOptionContract() is unable to fetch the current price of the option contract, in the option algorithms using OptionChainProvider, the filtered contract should wait until next time step to be available to trade. The algorithm returns the error message like  Backtest Handled Error: AMZN  170616C01000000: asset price is $0. If using custom data make sure you've set the 'Value' property.
Reproducing the Problem

https://github.com/QuantConnect/Lean/blob/master/Algorithm.CSharp/OptionChainProviderAlgorithm.cs
System Information

LEAN
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

We've decided that for now you can't add contract and purchase that contract on the same time step. This is actually (somewhat) realistic as far as running in live mode is concerned. For example, if we were to add a subscription for new data and on the very next line of code query the price, there's no guarantee that we would have received a tick for that contract yet (so price would still equal zero). The alternative is to issue a history request every time we add a subscription. We actually used to do this but determined that performance cost out weighed the marginal utility. For now you'll need to add the contract on one time step and on the next time step submit the order for the contract.


Remove VS2012 KB2707250 patch installation

Given that AppVeyor has recently updated its build images, we are now assuming that the Visual Studio 2012 installation available has Update 5 installed.
Removed custom patch installation to simplify process but retained failure procedure introduced in pull-request #41.

Well done! Seems to work now...


Is yaml supported really needed?

What is the use case behind yaml support?
Asking because the template file exposed by the Step-Functions UI is JSON.
Because I am usually a bit picky about my dependencies and the used js-yaml library doesn't seem to be maintained any more (no update since 3 years).
So I personally would vote against yaml support, unless there is a specific use case.
If you want to support yaml it would be cool if you can replace js-yaml with the better maintained library called yaml
(didn't want to come across as rude or similar, just curious 😄 )

The use case was mostly "some people like yaml instead" and since CFN/SFN supported it, I wanted to support it in the construct as well.
As for js-yaml vs yaml, I used it because it was mature and I was fine with it being untouched in years. If there are functional issues with using it, please let me know what so I can address them and switch to something that will resolve those issues.


Camel-15211: add props to configure SSL context parameters

Added  camel.main.ssl. parameters allowing Camel's SSL security parameters to be configured.
Tests added to camel-jetty, camel-netty, and camel-vertx.

Thanks for the review.  Give me a day to make the changes.

Added camel.main.ssl.xxx, and updated PrepareCamelMainMojo and BaseMainSupport.
Thanks.

Can we change camel.main.ssl to camel.ssl as this is not tied to main only.

Yes of course. Let me do that.

Changes committed changing camel.main.ssl to camel.ssl.  Thanks

We also need some work for camel-spring-boot, to make camel.ssl configuration possible via its auto configuration.
Its something like threadpool but not exactly the same, but you can take a look
https://github.com/apache/camel-spring-boot/tree/main/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/threadpool

Yes certainly, let me take a look.


minecraft.CommandUtils / update PosUtils

This is very much my fault but I feel like some of the libraries need updating?
Some of them are still fine though, maybe splitting this into multiple prs would be easier for both of us xD


[TASK] Simplify XmlFileProcessor

@andreaswolf I understand the intention but i think it makes the things overly complicated at the moment. PHP and it´s XML features has a lot of traversal capabilities implemented already. Right now i would like to keep it simple. It will simplify the reporting and skipping part a lot as far as i can see.

I am going to close the PR and try to open a new one with less changes.


Hanging Connection

The connection deadline is only set after smtpNewClient was called. Since smtpNewClient already wants to read 220 from the connection, a server that does not respond will result in a hanging connection.
This issue should be resolvable by moving the deadline code just after creation of the connection.
func (d *Dialer) Dial() (SendCloser, error) {
	conn, err := NetDialTimeout("tcp", addr(d.Host, d.Port), d.Timeout)
	if err != nil {
		return nil, err
	}

	if d.SSL {
		conn = tlsClient(conn, d.tlsConfig())
	}

	c, err := smtpNewClient(conn, d.Host)
	if err != nil {
		return nil, err
	}

	if d.Timeout > 0 {
		conn.SetDeadline(time.Now().Add(d.Timeout))
	}

Duplicate of #49


Supporting no code entities conversion build functions

So people can use their own packages

literally removing code entity support as it is pretty broken.
let user handle it.


New versions without accepted pull requests with gzip requests

Hi,
My pull requests was accepted #950 but in new versions I can't see gzip compress for incoming requests:
In master branch is: https://raw.githubusercontent.com/SeldonIO/MLServer/master/mlserver/rest/requests.py
from typing import Any
from gzip import decompress as gzip_decompress
from fastapi import Request as _Request

try:
    import orjson
except ImportError:
    orjson = None  # type: ignore

class Request(_Request):
    """
    Custom request class which uses `orjson` if present.
    Otherwise, it falls back to the standard FastAPI request.
    """

    async def body(self) -> bytes:
        if not hasattr(self, "_body"):
            body = await super().body()
            if "gzip" in self.headers.getlist("Content-Encoding"):
                body = gzip_decompress(body)
            self._body = body
        return self._body

    async def json(self) -> Any:
        if orjson is None:
            return await super().json()

        if not hasattr(self, "_json"):
            body = await self.body()
            self._json = orjson.loads(body)

        return self._json

in Version 1.24 requests.py have value:
from typing import Any

from fastapi import Request as _Request

try:
    import orjson
except ImportError:
    orjson = None  # type: ignore

class Request(_Request):
    """
    Custom request class which uses `orjson` if present.
    Otherwise, it falls back to the standard FastAPI request.
    """

    async def json(self) -> Any:
        if orjson is None:
            return await super().json()

        if not hasattr(self, "_json"):
            body = await self.body()
            self._json = orjson.loads(body)

        return self._json

I see that there is multiple branches 1.2.x and 2.x.x
I will create pull requests for those branches

Added pull requests for this #1041 #1040

Hey @gawsoftpl ,
These branches are internal branches used to prepare releases.  PRs should only be merged against master.
Since #950 was merged after the 1.2.x release was out, it will need to wait until the 1.3.x release. In the meantime, if you want to try it out, you should be able to use our dev releases (e.g. 1.3.0.dev3).


Updated the tutorial.

It no longer refers to deprecated functions like n_byte_align.

That's great. Thanks for that and well done :)

No problem. I have no idea why the python 3 build failed. Do you have any ideas?

Nope. I think it was a problem in building scipy, but I'm not sure and I don't know why this would fail rather than error. I've solved it by switching to miniconda, which I made a cursory attempt to do a while ago but this time actually understood what I was doing! It actually picked up a bug in the cache code that only showed up in Python 3.4, which I was previously neglecting to test, so good work test benches :)


Nilary's Codex should not generate cards that grant metaupgrades

Anything that grants greed/gluttony/wrath
Anything that heals you

Healing can be handled by the game by adding CardTags.HEALING.
The memories can add a new tag (PERMANENT_UPGRADE?) and patch AbstractDungeon.returnTrulyRandomCardInCombat to filter its list before returning a value.

Note that AbstractDungeon has several different variants that would each need to be patched similarly.
The other option would be to cheat and just use CardTags.HEALING even for the metaupgrade cases, but it would probably be preferable to use a separate tag unless the patches become really outrageous.

Adding Pride to the list of memories that should not be remembered, since it permanently upgrades a card.

Oh no. I hope I'm seeing this wrong. We want to patch the two overloads of AbstractDungeon.returnTrulyRandomCardInCombat. One of them has no arguments. ModTheSpire's Patcher.java assigns a null for its 'ctParamTypes' variable when method to be patched has only the void.class parameter. When that's null at line 336, there must be only one method count.
If I'm reading this right, we can't patch the 0-argument version as it stands. Two options I see so far:

Fork ModTheSpire and submit a pull request to handle this behavior. Use our fork until the PR is accepted.
Patch the patcher code with our own use of Javassist before the patcher code runs.

Thoughts? I might just submit the tagged Mending card in the meantime.

I think what you're looking for is to set paramtypez = { } in the SpirePatch for the nullary case. I'd bet this scenario is exactly why ModTheSpire is using { void.class } instead of the more natural { } as its sentinel value for paramtypez. I was able to get the game to patch and run with the following patch layout:
    @SpirePatch(
            clz = AbstractDungeon.class,
            method = "returnTrulyRandomCardInCombat",
            paramtypez = { }
    )
    public static class AbstractDungeon_returnTrulyRandomCardInCombat_1 {
        @SpirePrefixPatch
        public static void patch() {
            JorbsMod.logger.info("in returnTrulyRandomCardInCombat() patch");
        }
    }

    @SpirePatch(
            clz = AbstractDungeon.class,
            method = "returnTrulyRandomCardInCombat",
            paramtypez = { CardType.class }
    )
    public static class AbstractDungeon_returnTrulyRandomCardInCombat_2 {
        @SpirePrefixPatch
        public static void patch(CardType cardType) {
            JorbsMod.logger.info("in returnTrulyRandomCardInCombat(CardType cardType) patch");
        }
    }

Thanks, the empty list is exactly what I was looking for.


A means to turn off all platform-specific features in s2n-quic-platform

The conversation arose out of: https://github.com/aws/s2n-quic/pull/1849
Basically, non-s2n_quic_platform_socket_mmsg and non-s2n_quic_platform_socket_msg (as in, falling back to s2n_quic_platform::message::simple) codepaths were not being compiled, leading to the issue that #1849 fixed.
@camshaft indicated that it would be good to have some way of disabling all platform-specific features to prevent issues like this.
I had patched build.rs to notice an env var, although a cfg var can be used too and is probably more appropriate.

Thinking about it a bit, I think the best approach is to use a environment variable rather than a cfg, since that would require passing that cfg to all of the dependencies and force a recompilation if changed. For the env var, I think something like S2N_QUIC_PLATFORM_FEATURES_OVERRIDE=msg,pktinfo,gso would be the most flexible for testing weird combinations in CI. If you want to disable all of the features, then you can simply pass an empty env value.

Here's a patch, I won't open the PR since I have no idea how the CI works:
diff --git a/quic/s2n-quic-platform/build.rs b/quic/s2n-quic-platform/build.rs
index 0777e6cf..ca2012ce 100644
--- a/quic/s2n-quic-platform/build.rs
+++ b/quic/s2n-quic-platform/build.rs
@@ -1,9 +1,22 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0

-use std::{fs::read_dir, io::Error, path::Path, process::Command};
+use std::{error, fs::read_dir, io, path::Path, process::Command};
+
+fn main() -> Result<(), Box<dyn error::Error>> {
+    const FEATURES_OVERRIDE_ENV_VAR: &str = "S2N_QUIC_PLATFORM_FEATURES_OVERRIDE";
+    println!("cargo:rerun-if-env-changed={}", FEATURES_OVERRIDE_ENV_VAR);
+    match std::env::var(FEATURES_OVERRIDE_ENV_VAR) {
+        Ok(val) => {
+            for feature in val.split(",") {
+                supports(feature);
+            }
+            return Ok(());
+        }
+        Err(std::env::VarError::NotPresent) => {},
+        Err(e) => return Err(e.into()),
+    }

-fn main() -> Result<(), Error> {
     let env = Env::new();

     for feature in read_dir("features")? {
@@ -77,7 +90,7 @@ impl Env {
     }

     // Tries to compile the program and returns if it was successful
-    fn check(&self, path: &Path) -> Result<bool, Error> {
+    fn check(&self, path: &Path) -> Result<bool, io::Error> {
         let mut command = Command::new(&self.rustc);

         command


Curly underline is rendered as single

Windows Terminal version
1.20.3131.0
Windows build number
10.0.19045.3448
Other Software
No response
Steps to reproduce
Originally posted in https://github.com/microsoft/terminal/pull/16097#discussion_r1389476524

Set display scaling to 100%

Run OpenConsole or WT

Set font to Consolas

Set font size to:

34 or smaller for OpenConsole, e.g. 20
19 or smaller for WT, e.g. 12

Run something to showcase new underlines, e.g. this script

@echo off

echo 4:1 [4:1;58:2::255:000:000mtest
echo 4:2 [4:2;58:2::255:255:000mtest
echo 4:3 [4:3;58:2::000:255:000mtest
echo 4:4 [4:4;58:2::000:255:255mtest
echo 4:5 [4:5;58:2::255:000:255mtest

pause

- where � is \x1b, or whatever else you might have.
Expected Behavior
Clearly visible underline styles, curly in particular, e.g.:

Actual Behavior
Curly is rendered as single in both OpenConsole and WT:

OpenConsole also renders double underline as single, which may or may not be related.

Other terminals, e.g. wezterm, seemingly have no issues with even smaller sizes:

Technically it's not too small if the wave height is at least 2 pixels:

Additionally, OpenConsole with even smaller sizes, e.g. Consolas 15, doesn't render anything but "double" at all:

Technical limitations are understandable, but, assuming that the key selling point of this feature is spellchecking, any ugly/incorrect/clipping/overlapping rendering would be better than nothing at all.

There are two issues in this Issue
1. Curly line drawn as Singly line
Admittedly, I've a high dpi screen which I use at 175% scaling. I guess the threshold we kept for curly underlines can be find tuned for 100% display scaling. Something that works for 100% should work for 175% as well 🙂
Can someone try a different value for minCurlyLinePeakHeight, and see which one works better at 100% display scaling?
AtlasEngine (WT)
https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/renderer/atlas/BackendD3D.cpp#L311-L313
GDI (Conhost)
https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/renderer/gdi/state.cpp#L410-L432
In GDI, we have two conditions to check before drawing curly underline:

Underline width is atleast 1px.
Space between cell bottom and underline position is atleast MinCurlyLinePeakHeight (2px).

2. Underlines not visible at smaller font-sizes in Conhost

Additionally, OpenConsole with even smaller sizes, e.g. Consolas 15, doesn't render anything but "double" at all:

I guess the underline offset we're calculating is making underlines to be drawn below the cell bottom, effectively not visible at all. The fix could be to clamp the offset within cell boundary🤔 (For me, this happens at font-size 9pt with Consolas.)

The line offsets should have already been set to their correct positions based on the provided font metrics in the GdiEngine::UpdateFont method. The problem is that we've now added an additional offset at render time here:
https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/renderer/gdi/paint.cpp#L622-L626
That's almost certainly wrong. Even if if wasn't pushing the offsets out of range, it doesn't make sense to be altering the value here. What was the reason for this change?

Also, assuming you're looking at this code again, note that the underlineWidth should never be less than 1. We've got a check for that here:
https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/renderer/gdi/state.cpp#L379-L383
So I think the test below should never be necessary.
https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/renderer/gdi/state.cpp#L409-L413

I'm gonna pull this one out of the triage queue and assign it to you, Tushar! Let me know if you have any objections. Thanks for working on it!

Hey @tusharsnx, I've got a crazy plan... but it might need this bug fixed for me to pull it off 😁

@DHowett

(are you able to look into it?)

Almost ready! 🙂

Okay I definitely thought that's what you meant on Twitter, I just had to make sure!


replay-sorcery: 0.5.0 -> 0.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/replay-sorcery/versions.
meta.description for replay-sorcery is: Open-source, instant-replay solution for Linux
meta.homepage for replay-sorcery is: https://github.com/matanui159/ReplaySorcery
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.0 in filename of file in /nix/store/na5bdp1x8z9r71fr35dgdzcj2vnsipcb-replay-sorcery-0.6.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

replay-sorcery

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/na5bdp1x8z9r71fr35dgdzcj2vnsipcb-replay-sorcery-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A replay-sorcery https://github.com/r-ryantm/nixpkgs/archive/e85ec7d3d197d43613841868bd357d4a158d9186.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e85ec7d3d197d43613841868bd357d4a158d9186#replay-sorcery

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/na5bdp1x8z9r71fr35dgdzcj2vnsipcb-replay-sorcery-0.6.0
ls -la /nix/store/na5bdp1x8z9r71fr35dgdzcj2vnsipcb-replay-sorcery-0.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

replay-sorcery

Maintainer pings
cc @kira-bruneau for testing.

replay-sorcery is being removed in #326894, i'm going to leave this open until that's merged so the update bot doesn't open a new pr again.


update status on HAP Server

Hello,
it's not an issue but i need your help. everything works fine with HAP Server but i want also to trigger some lights (ESP8266) with my PHP Server but how can i update the state on the HAP Server that the light switched on/off?
thank you for your help
christian

I would use the lightweight MQTT communication and write a client in your HAPnode that listens for events from your 8266.
I'm using https://www.npmjs.com/package/mqtt on my RPI, there are many good ones around..

ok i made it like this in the accessory at the end:
client.on('message', function(topic, message) {
console.log(String(message));
if(String(message) == "SwitchedOn"){
LIVINGROOM.powerOn = 1;
console.log("value is on");
}else if(String(message) == "SwitchedOff"){
LIVINGROOM.powerOn = false;
console.log("value is off");
}
});
i publish a second message on the same topic with either SwitchedOn or SwitchedOff

@chrigu1981 You can use this to improve readability.

thx


5.8 Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

Laravel 5.8
EBUG [9485c7aa] Command: cd /var/www/html/mcms/releases/20190328173840 && /usr/bin/env composer install --no-dev --quiet --prefer-dist --optimize-autoloader
DEBUG [9485c7aa]       Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1
trying to figure why it keeps failing

I am having the same issue. Please someone help
Note : I am only facing that error when running composer update online in my web hosting area, not on local server.
Thanks

Same problem.

Hi, I got a solution : this issue was due to one of my config/ files that was empty (caused by error when uploading files to server), especially the auth.php which was there but empty (0 octets).
I figure that by running php artisan clear and i got error in the ServiceProvider at line 72 where merging config arrays $this->app['config']->set($key, array_merge(require $path, $config));
So, simple solution : upload again your app files and make sure everything is place 🙂

Hi, I got a solution: this issue was due to one of my config/database.php that were empty (caused by an error when the composer updated).
I figure that by running php artisan clear and I got an error in the Database [] not configure DatabaseManage.php at line 252
So, simple solution: upload again your config/database.php files and make sure everything is place 🙂

Hi, I got a solution : this issue was due to one of my config/ files that was empty (caused by error when uploading files to server), especially the auth.php which was there but empty (0 octets).
I figure that by running php artisan clear and i got error in the ServiceProvider at line 72 where merging config arrays $this->app['config']->set($key, array_merge(require $path, $config));
So, simple solution : upload again your app files and make sure everything is place 🙂

nice

For who has this issue :
I figured out problem is one of my configs. missing return or using a class that not exists.
Check /config and be sure that every thing is normal at there

Same issue here, on my case the bootstrap/cache directory wasn't with the right permissions. After updating the permissions everything started to work on the cloud server.

Try these command. In my case solved.
sudo chown -R $USER:www-data storage
sudo chown -R $USER:www-data bootstrap/cache
chmod -R 777 storage
chmod -R 777 bootstrap/cache

i cloned a project from github and then run composer install. I got the following error.
Script @php artisan package:discover handling the post-autoload-dump event returned with error code 1
I added .env file and run the composer install command. i got the same error again. Then i deleted  composer.lock file and vendor folder and run the composer install command again. The error was gone.

So is the general consensus on this a dir permissions issue or a an error or typo caused by uploading or clear function in artisan?  OR is this a problem with composer, or both? It seems there's alot of this with these latter rounds of composer versions that seem to be more apt for throwing the odd curveball and overwriting files and folders, not sure if it's related and was unsure of any origin docs or.a general definition or causal predisposition for this particular coded error. Thanks for input, will be back if no dice on the suggested fixes.It's odd because i've worked on several laravel projects in the last few days on the same environment/terminal used composer, worked fine, worked on another project which threw me an error i resolved with changing permissions on my cloud host ( digital ocean - laravel image, first time i've used their seemingly new pre- configured one click, i've always manually configured my linux environments, i'm wondering if you think that it could be the continuous integration script or something with my image relating to laravel projects that is changing permissions or overwriting configs? I should let this go. It's getting me too worked up.

So is the general consensus on this a dir permissions issue or a an error or typo caused by uploading or clear function in artisan?  OR is this a problem with composer, or both? It seems there's alot of this with these latter rounds of composer versions that seem to be more apt for throwing the odd curveball and overwriting files and folders, not sure if it's related and was unsure of any origin docs or.a general definition or causal predisposition for this particular coded error. Thanks for input, will be back if no dice on the suggested fixes.It's odd because i've worked on several laravel projects in the last few days on the same environment/terminal used composer, worked fine, worked on another project which threw me an error i resolved with changing permissions on my cloud host ( digital ocean - laravel image, first time i've used their seemingly new pre- configured one click, i've always manually configured my linux environments, i'm wondering if you think that it could be the continuous integration script or something with my image relating to laravel projects that is changing permissions or overwriting configs? I should let this go. It's getting me too worked up.

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255
I followed these steps to fix it

ran php artisan clear and got "PHP Fatal error:  Uncaught ErrorException: Method, ReflectionParameter::getClass() is deprecated in and not allowed in php 8.0"
My system had php version <IP_ADDRESS> and ReflectionParameter::getClass() is deprecated to in php version 8
I brew unlink<EMAIL_ADDRESS>to downgrade my php and that was the fix

just run composer update it worked for me


Default mock of MatTooltip breaks tests in Angular14

See https://github.com/angular/components/issues/25563
There is a comment that seems to indicate that the default MatTooltip mock causes the issue.
For my own project, to fix my tests, I have had to .keep(MatTooltipModule) as a workaround

Hi @craigsnyders,
Thanks for the report.
Could you share a min repo with the issue?

I've tried an example with MatTooltipModule, but it doesn't look like the problem: https://codesandbox.io/s/elastic-wildflower-uovnk0?file=/src/test.spec.ts

Hi @Chris2fourlaw, @KasimJasarevic,
could you help me to reproduce the issue?

For I've found so far is that this can be caused by importing MatCommonModule and/or A11yModule.
Do you use any of those?
If yes, to get the failure, they shouldn't be mocked. Is there a reason why you don't mock them?
Basically, the solution here is to .keep(NG_MOCKS_ROOT_PROVIDERS) or .keep(BreakpointObserver), in this case, BreakpointObserver won't be mocked and won't cause the issue.
If you want to mock BreakpointObserver, then you need to stub its .observe():
ngMocks.defaultMock(BreakpointObserver, () => ({
  observe: jasmine.createSpy().and.returnValue(EMPTY)
}));

Here is the updated test: https://codesandbox.io/s/elastic-wildflower-uovnk0?file=/src/test.spec.ts
Feel free to reopen the issue if the fix doesn't work for you.


Segmentation fault in "h3_polyfill" function

In regions.c:120 value is passed to DatumGetPolygonP without checking if value is NULL, but it is possible to have NULL in holes array.
Unfortunately I cannot yet provide a reproducible test case.
Backtrace: bt-full.txt

Thank you for the report!
If you manage to provide a reproducible test case it would be a big help. In any case we will try and fix this. 👍🏿


Fix Grafana dashboard metric name

The Grafana dashboards were referencing an incorrect metric name. The name should be http_server_request_duration instead of http_server_request_duration_seconds according to the documentation.
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service agree company="Pandora Intelligence B.V."

@JamesNK

The names here are based on what the OTEL Prometheus library exporter provides. I assume you are using something else to get metrics?
If we change to the format you propose then metrics via OTEL and Prometheus will break. I think they should stay as they are.

@JamesNK
I see now. Is it then an option to have different dashboard files? For example one for OTEL Prometheus and one using the .NET metric name? I am currently exporting the metrics via the OTEL exporter and collecting it via an OTEL collector. In Grafana I can then choose the metrics with a name that is described in the .NET documentation.

No, I don't want to duplicate them. It's harder to maintain and I don't know how many people want different names, and what the possible names are. If more people asking for this then we'll re-evaluate based on demand.


actions: Add windows-latest to test matrix.

Closing this to reduce spam in my inbox. :sweat_smile: Once github updates to a newer version of windows that has better docker / VM support, it should be possible to reopen this PR thread again.


Respond with status OK on root path

Signed-off-by: Matej Gera<EMAIL_ADDRESS>Small change that makes the API respond with 200 on root path / instead of current 404. This is in order to enable us to do some basic closed-box checking, to differentiate between 'real' not found case and case where API is actually serving.
Also bumps the version for signal package used in internal server instantiation.

Hmm this seems wrong to me. There is literally nothing to serve at this path, so from an HTTP point of view the correct status is 404

Hmm this seems wrong to me. There is literally nothing to serve at this path, so from an HTTP point of view the correct status is 404

@squat there are other non-4** status codes for communicating an OK status with no payload response. However, i'm not certain a 204 is appropo either.

Right, but those typically indicate that an operation was performed or was scheduled, which is not the case here. In this case it seems like a hack to enable testing. More than anything, i worry this change will be confusing as the API literally does nothing with this endpoint.
An option would be to respond with a list of available endpoints, e.g. use / as an HTTP API discovery endpoint. Of course, care would have to be taken to not leak tenant metadata, e.g. tenant X exists.

Right, but those typically indicate that an operation was performed or was scheduled, which is not the case here. In this case it seems like a hack to enable testing. More than anything, i worry this change will be confusing as the API literally does nothing with this endpoint.
An option would be to respond with a list of available endpoints, e.g. use / as an HTTP API discovery endpoint. Of course, care would have to be taken to not leak tenant metadata, e.g. tenant X exists.

I can certainly see the point, although I do not think this is a hack just for testing purposes. The API might not be doing anything per se, but it's still a signal to the user that 'yup, you're in the right place'. The API is doing something - it's telling you're on the right address, this is the base / host root path. IMHO it's not an uncommon thing.
But I also agree that listing available endpoints would be a much nicer addition (we already had users who were unsure about paths they were using), so if that'll make this more palatable I'm happy to do it.

@matej-g just wondering two things here:

Is there a precedent set for this in any of our upstream repos - Thanos / Prometheus?
Could we just call the /metrics endpoint or even /healthy like the kube probe that indicates service health?

@matej-g just wondering two things here:

Is there a precedent set for this in any of our upstream repos - Thanos / Prometheus?

AFAIU Prometheus / Thanos does not have this 'problem', since they redirect from / to /graph (or in case of Thanos UI, possibly to other endpoint, depending on the component). But for example, for Telemeter, we do return available external routes on /, which was also the suggested alternative from @squat.

Could we just call the /metrics endpoint or even /healthy like the kube probe that indicates service health?

Since these are served by the internal server, they are not reachable from the outside.
I will rework this to make the / serve list of available external endpoints, since that seems like the more agreeable option for most of us here and we can iterate / discuss on that.

Closing in favor of https://github.com/observatorium/api/pull/182


mtd:add dhara compatiblity layer

Summary
to support dhara ftl for fatfs
Impact
Testing

@guohao15 maybe we could include dhara directly, instead of downloading it. Greg's main rules was: not to include active projects and dhara doesn't appear active any longer. Also avoiding downloads makes it easier to compile in security environment, where the machine cannot have Internet access.

@guohao15 maybe we could include dhara directly, instead of downloading it. Greg's main rules was: not to include active projects and dhara doesn't appear active any longer. Also avoiding downloads makes it easier to compile in security environment, where the machine cannot have Internet access.

@acassis since dhara need to format per nuttx coding style before including it directly, I would suggest we do this in the next step.

Ok, let to do it step by step!


Default image for association

You should add a default image for association (other than android default icon).

Fixed in commit 0368350


[HOLD for payment 2024-12-05] [$250]  Tags - State field is not auto selected when there is only one tag

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.58-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5188086
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

Workspace is set up with dependent multi tags (use the file attached below).

Launch hybrid or ND app.
Go to workspace chat in which dependent multi tags are set up.
Tap + > Submit expense > Manual.
Enter amount > Next.

Expected Result:
State field will be auto selected with the only one tag because "Members must tag all expenses" in Tags settings is enabled. (It is auto selected on staging web and production hybrid).
Actual Result:
State field is not auto selected with the only one tag even when "Members must tag all expenses" in Tags settings is enabled.
This issue only happens on Android and iOS app (both hybrid and standalone).
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/a69be543-24a0-43c4-b69c-8337d8ec2c3a
Bug6656808_1730914735568!Dependent_-_Multi_Level_tags_NEW.csv

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021854535982635221591
Upwork Job ID:<PHONE_NUMBER>635221591
Last Price Increase: 2024-11-14
Automatic offers:

truph01 | Contributor | 104908657

Issue OwnerCurrent Issue Owner: @strepanier03

@IuliiaHerets can you please post the video for it working in production as well? Thanks!

@danieldoglas Can you please check the added video? it includes the prod behavior too

Oh, I think I got confused because you downloaded both from test flight. Thanks for confirming

Proposal
Please re-state the problem that we are trying to solve in this issue.

Tags - State field is not auto selected when there is only one tag

What is the root cause of that problem?

The transaction in this useEffect can be undefined, and because we removed the transaction data from the its dependences:

https://github.com/Expensify/App/blob/ef76462dd29427b098d7567ff1a4c119218f5076/src/components/MoneyRequestConfirmationList.tsx#L697
so the useEffect is not called again once the transaction data is available.
What changes do you think we should make in order to solve the problem?

We should add the transaction to the dependence, and create a flag to make sure the auto select logic is only called one time:

+  const didCalledAutoSelectTagRef = useRef(false);
    useEffect(() => {
+      if (!transaction || didCalledAutoSelectTagRef.current) {
+          return;
+      }
+      didCalledAutoSelectTagRef.current = true;

        let updatedTagsString = TransactionUtils.getTag(transaction);
        policyTagLists.forEach((tagList, index) => {
            const enabledTags = Object.values(tagList.tags).filter((tag) => tag.enabled);
            const isTagListRequired = tagList.required ?? false;
            if (!isTagListRequired || enabledTags.length !== 1 || TransactionUtils.getTag(transaction, index)) {
                return;
            }
            updatedTagsString = IOUUtils.insertTagIntoTransactionTagsString(updatedTagsString, enabledTags.at(0)?.name ?? '', index);
        });
        if (updatedTagsString !== TransactionUtils.getTag(transaction) && updatedTagsString) {
            IOU.setMoneyRequestTag(transactionID, updatedTagsString);
        }
+  }, [policyTagLists, policyTags, transaction]);

What alternative solutions did you explore? (Optional)

Hey @danieldoglas I decided not to block on this as this is very easy for users to figure out -- simply select it manually as the violation suggests.
I think it can be made external to speed up the fix, we have a decent proposal already. We will also need to locate the regression though. I'm unsubscribing so please tag me if you need me 👋

Proposal
Please re-state the problem that we are trying to solve in this issue.
Tag is not auto-selected on submit expense when the workspace has enabled required tags.
What is the root cause of that problem?
Initially, the component renders with transactionID=-1  which is then used in this block to add the required tag:
https://github.com/Expensify/App/blob/ef76462dd29427b098d7567ff1a4c119218f5076/src/components/MoneyRequestConfirmationList.tsx#L692-L694.
As a consequence you can find on Onyx this key transactionsDraft_-1 which holds only the tag in the value:
{tag: 'tst'}
What changes do you think we should make in order to solve the problem?

We need to update the useEffect dependencies to add the transcationId in it in this line:
https://github.com/Expensify/App/blob/ef76462dd29427b098d7567ff1a4c119218f5076/src/components/MoneyRequestConfirmationList.tsx#L697
And to avoid creating the onyx entry for the -1 id we should add an early return in the useEffect:
if(transactionID === '-1'){
            return;
        }

What alternative solutions did you explore? (Optional)

@hoangzinh I actually tested both the bug and my solution on macOS chrome only

Thanks for your proposals. @truph01 @klajdipaja does anyone know why it only happens in native apps? It works for me in Web

It seems that react-native-onyx behaves slightly differently across platforms (web vs. native). Based on my RCA, try logging the transaction data inside this useEffect:
https://github.com/Expensify/App/blob/ef76462dd29427b098d7567ff1a4c119218f5076/src/components/MoneyRequestConfirmationList.tsx#L682
on both native and web platforms to compare the results. In native, the transaction is undefined on the first render, whereas in web, it already holds a defined value.

@hoangzinh I added the alternative solution to my proposal

@hoangzinh Also, did you test this solution and it works well, right? I tested from my side, but it does not work in native. Please correct me if I am wrong.
Proposal updated

it aligns with our root cause

The root cause isn’t simply that transaction data is initially undefined, but rather that it hasn’t been loaded yet, which makes the data undefined until it’s fully retrieved. Recognizing this helps us understand that transaction data can appear undefined during loading, potentially leading to similar issues in the future. To address this more generally, a loading indicator should be shown if isLoadingTransaction is true in here:
    if (isLoadingTransaction) {
        return <FullScreenLoadingIndicator />;
    }

This approach suggests that the proposed solution serves as a temporary workaround rather than a direct fix for the root issue.
Additionally, if my root cause analysis is correct, you’ll notice that this proposal doesn’t address it directly, which is a significant factor when selecting a solution as noted in this issue."

It is a widely used approach in the app that when the onyx value is not found we check for -1 and that is also used in many other occurrences in the IOU flow.
If we wanted to acknowledge the fact that the Onyx transaction is loading then we would need to do that at the root of the issue in WithFullTransactionOrNotFound and expose that as a property of the HCO component so that all wrapper components can handle it as they wish.
        return (
            <WrappedComponent
                // eslint-disable-next-line react/jsx-props-no-spreading
                {...(props as TProps)}
                transactionLoading={shouldUseTransactionDraft ? transactionDraftLoading : transactionLoading}
                transaction={shouldUseTransactionDraft ? transactionDraft : transaction}
                ref={ref}
            />
        );

If we check for the loader only in IOURequestStepConfirmation then we still will end up in the future having to go through long debugging work to understand the edge case.
But t if we do this change we have to align all components instead of the -1 check to do the transactionLoading check. That sounds like a major change to me to a minor problem.

If we wanted to acknowledge the fact that the Onyx transaction is loading then we would need to do that at the root of the issue in WithFullTransactionOrNotFound and expose that as a property of the HCO component so that all wrapper components can handle it as they wish.

I already mentioned it in my alternative solution

Proposal updated

Update my main solution with the general solution I mentioned here.

PR is ready

@strepanier03 I think this is ready for payment

I believe this is ready for payment @strepanier03?

Contributor: @truph01 paid $250 via Upwork
Contributor+: @hoangzinh due $250 via NewDot

It was a DB, so I believe we already had a regression test for this issue.

@hoangzinh , I believe you're correct, which makes me think we could, maybe, update a process (or automation?) that states something like "If QA caught the bug during regression testing and linked to it in the OP, a new test case likely isn't needed." ie. from the OP here.

If this was caught during regression testing, add the test name, ID and link from TestRail: expensify.testrail.io/index.php?/tests/view/5188086

$250 approved for @hoangzinh


networking.vpnc: remove option

Motivation for this change
This PR is part of the networking.* namespace cleanup.
The Cisco VPN module is currently of limited value since it just creates config files but does not manage services. The same functionality can be achieved by using environment.etc instead.
It would be a different situation if we had a full service module. So if you are annoyed by this change, please consider write a more featureful module and put its options unter services.networking.vpnc.
Note that this change affects only Cisco VPN, not networkmanager-vpnc.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date -> not mentioned outside options.html
[x] Fits CONTRIBUTING.md.

@ckauhaus thanks!


Automatically compute train_iters when train_epochs is specified.

Major changes:

Introduces a train_epochs argument
Reorders events in the pretrain function, changing from: model/optimizer creation -> data iterator creation to: data loader creation -> model/optimizer creation -> data iterator creation
Removes save_iters property from NeoX args and replaces it with a runtime is_save_iter function
Adds support for non integer checkpoint factors when using logarithmic checkpointing

Note: Most of these changes are a consequence of not being able to compute train_iters when creating the NeoX Args object. At a high level we pass both train_epochs and train_iters down to the dataloader, and use the one that is not none to specify the dataloader behavior, then if train_iters is unspecified we infer it from the dataloader after constructing it.

fixes https://github.com/EleutherAI/gpt-neox/issues/1268


Gk contribution thinkst

Required items, please complete
Change(s):

No change but new content being submitted in the form of a folder called ThinkstCanary-Alert-Ingestion a playbook file called azuredeploy.json, and a readme file called readme.md.

Reason for Change(s):

No change but the addition is becuase there is no available playbook for ingesting alerts from a Thinkst Canary cloud
console at present.

Version Updated:
N/A for playbook submission
Testing Completed:

Yes - tested and the template deployed using the deploy to Azure button I had pointed at my personal Github repository.
Connector tested in a MS Sentinel Environment with no custom parsers or functions.

Checked that the validations are passing and have addressed any issues that are present:

Not submitting a KQL or YAML file.

@microsoft-github-policy-service agree company="Bridewell Consulting Limited"

@manishkumar1991 - is there anything else needed from me at this time? Cheers

Hi @manishkumar1991, @m4nbat responded on your comments please check and provide your feedback. Thanks.

Hi @manishkumar1991, @m4nbat responded on your comments please check and provide your feedback. Thanks.

I am checking


Add benchmarks for Coinbase Smart Wallet

Adds benchmarks for Coinbase Smart Wallet and also updates gas for Ecotone.

Update: I went ahead and verified this using https://github.com/alchemyplatform/aa-benchmarks/pull/47. After removing the signature overhead 68n * 16n and OP_FIXED_OVERHEAD from the calculations, we should be all set!
Once this is merged, I'll rebase my stack on top.

@jaypaik thanks for the review. Rebased and updated to remove fixed overhead.

Will merge this and address the fixes on top!


feat: show labels in UI

This uses english by default and allows users to modify their preferred language in the app. Maybe it's best to use the default per the browser? And should we allow the user to modify their preferred language in app or they should change in the browser?

Okay, so we have American English in Wikidata but there is no American English in that mediawiki code I got the languages from...


Setting a custom link string

I am converting a custom link renderer from pegdown to flexmark. Under certain conditions, I need to construct my own link string (it happens to be xhtml) instead of a standard link. In pegdown that was accomplished by using new Rendering("", link) where link was the exact string I wanted. How can I do the same thing in flexmark?

Just to clarify, I have a CustomLinkResolver that implements LinkResolver in flexmark from what use to be a CusotmLinkRenderer that extended LinkRendered in pegdown.

@bobswift, in flexmark-java the only way to do this is to create a custom node renderer and register the nodes it will handle. See NodeRendererSample
I would recommend overriding Link, Image, LinkRef and ImageRef since these all generate links by starting with the code for these in CoreNodeRenderer, at the moment the API does not have a way to handle some rendering and passing the rest to the previously registered renderer. It has been on my to do list and I will be adding it. Giving a custom handler stack that will allow handling of special cases without having to worry about every nuance.

@bobswift, changes made to the API to allow node rendering to handle special cases with the rest passed on to the "usual" renderer.
Sample code modified to add a conditional custom renderer PegdownCustomLinkResolverOptions

API Change: add node renderer API for delegating rendering to previously registered node
renderer stack, allowing partial node rendering customizations with non-customized rendering
passed to previous renderer.

NodeRendererContext.delegateRender() to delegate current node rendering to previously
registered handler for the current node. Should only be called from handler's render()
method. If there is no renderer to which to delegate then the node will not be rendered.
NodeRendererContext.getDelegatedSubContext(Appendable, boolean) to get a sub-context to be
used in delegated rendering, this context inherits current node rendering handler and node
information needed for delegateRender() method.
Added DelegatingNodeRendererFactory which should be implemented by custom renderers which
rely on delegating some rendering of their nodes to existing renderers. It provides a set of
NodeRendererFactory classes to which this renderer may delegate to provide a controlled
ordering of renderers independent of registration order.

Making release now.

@bobswift, repo updated. Maven update in progress.

Wow! Thanks for the pointers. My understanding of this is very superficial, so even with the tips, it will take me a while to sort out how to make this work. I will have to get back to it later.

@bobswift, I can sympathize with the learning curve for the library when it comes to customizations it is more flexible but also more complex than pegdown.
Based on your description, the sample PegdownCustomLinkResolverOptions has condition based on the link node to override standard rendering to make it easier to customize some links while passing others through for standard rendering.
If you give me more information about what your custom rendering did with pegdown or the pegdown code used, I will be able to give your more usable sample code.

It was really simplistic and I think it was just trial and error to get to making it work with new Rendering("", link)
public class ConfluenceWikiLinkRenderer extends LinkRenderer {
    ...
    @Override
    public Rendering render(WikiLinkNode node) {
        Matcher matcher = CONFLUENCE_WIKI_LINK.matcher(node.getText());
        if (matcher.find()) {
            String link = "..."
            return new Rendering("", link); // the blank url seems to get ignored
        } else {
            return super.render(node); // do whatever the default is
        }
}

@bobswift, I am assuming that the link in your code refers to the complete HTML you want to generate for it. For that you can use the HtmlWriter.raw() methods.
You would need to change PegdownCustomLinkResolverOptions.java Lines 117-128
To:
set.add(new NodeRenderingHandler<WikiLink>(WikiLink.class, new CustomNodeRenderer<WikiLink>() {
    @Override
    public void render(WikiLink node, NodeRendererContext context, HtmlWriter html) {
        // test the node to see if it needs overriding
        Matcher matcher = CONFLUENCE_WIKI_LINK.matcher(node.getChars());
        if (matcher.find()) {
            String link = "...";
            html.raw(link);
        } else {
            // otherwise pass it for default rendering
            context.delegateRender();
        }
    }
}));

Thanks! I will have a try at that tomorrow. I appreciate your help.

So, I think it is roughly changing from a CustomLinkResolver to a CustomLinkRenderer where I can use the html.raw(link) as you have above ...  . That seems pretty straightforward now.  Seems to be working!!!public class CustomLinkRenderer implements NodeRenderer {
public static class Factory implements DelegatingNodeRendererFactory {
    @Override
    public NodeRenderer create(final DataHolder options) {
        return new CustomLinkRenderer();
    }

    @Override
    public Set<Class<? extends NodeRendererFactory>> getDelegates() {

        Set<Class<? extends NodeRendererFactory>> set = new HashSet<Class<? extends NodeRendererFactory>>();
        // add node renderer factory classes to which this renderer will delegate some of its rendering
        // core node renderer is assumed to have all depend it so there is no need to add it
        set.add(WikiLinkNodeRenderer.Factory.class);
        return set;

        // return null if renderer does not delegate or delegates only to core node renderer
        // return null;
    }
};

@Override
public Set<NodeRenderingHandler<?>> getNodeRenderingHandlers() {

    HashSet<NodeRenderingHandler<?>> set = new HashSet<NodeRenderingHandler<?>>();

    set.add(new NodeRenderingHandler<WikiLink>(WikiLink.class, new CustomNodeRenderer<WikiLink>() {
        @Override
        public void render(WikiLink node, NodeRendererContext context, HtmlWriter html) {

            // custom link generation logic goes here - return a link string if we match the node to something we need to act on
            String link = getLink(node);
            if (link != null) {
                html.raw(link);
            } else {
                // otherwise pass it along for default rendering
                context.delegateRender();
            }
        }
    }));
    return set;
}

...
}

@bobswift, yes. If you are not using standard link rendering then there is no point in implementing a link resolver since you will render the link yourself. Link resolver is only needed to make default link rendering generate the right URL.
The changes from pegdown to flexmark-java are only serious in parsing extensions. The rest is usually easier in flexmark-java.

Just to be clear, I am only handling one specific case where I will provide the link directly. Otherwise, every other case should just be handled normally. And this appears to be what is happening. The logic is virtually the same as before and even a bit easier with flexmark - it just bails out (link == null) to get back to the default handling as soon as the special case matching fails.
Anyway, thanks very much for all the help. I have more testing to do, but, I think this is it.

@bobswift, you are welcome. Don't hesitate to open an issue if you find anything else.


multiline comment syntax highlighting

I'm using haskell-vim-now (https://github.com/begriffs/haskell-vim-now) as my IDE for writing Haskell and I'm told that it uses this package for syntax highlighting.

I noticed that multi-line comments don't get syntax highlighting as shown above. Any help would be appreciated!
Thanks,
Akhilesh Srikanth

I cannot reproduce this. I'm not using haskell-vim-now so I guess it's a problem over there.

Cool, good to know.

For future reference, there is a conflict with the 'rainbow-parentheses' plugin. Disabling it on haskell source files fixed this specific issue.

Thank you @freuk, you saved me, never would have thought of this!

@freuk You saved me countless hours man. Thank you very much.


Add bip39 passphrase test

Thanks for the PR and further contributing, much appreciated! A small thing that I think should be changed though for increased robustness.

Np. What is it? I will change.

This might be rarted, but I can't find the comment. I can see a preview if I hover on this link of latest comment, but clicking it (or the preview) doesn't have any effect.

Weird... The comment was:

I think it's better if we use the actual function which derives keys for recovery. Otherwise we risk an implementation error in the function while the tests still pass.

It's related to the construction of the test. You reconstructed the flow of the function. It would be better to test the function itself. If the function is wrong we would not notice in the current test setup.

I think I understand it, just not sure if this is the right approach. Please check again.

left a comment in the reviews and would be great if you could resolve the merge conflicts

Cool, looking at the keys_test.go this looks fine now. I "fixed" the Github issue by using a different base branch. I'll merge that into master from there.
One problem though. https://github.com/setavenger/blindbitd/pull/7/commits/8429317b337dcbf1f739d103775670bba83c24da introduced a change to BlindBit-Protos which should not be the case.

Sorry, I'm not used to submodules and made a mess here. I will close this PR do a new one with a single commit.
I see other tests are breaking, maybe because of that reason too:

Error: /27 16:28:08.212734 /home/runner/work/blindbitd/blindbitd/src/coinselector/selector.go:160: [ERROR] Failed to decode address: decoded address is of unknown format

No worries, I thought submodules would be a good fit here. They are creating some trouble for me too though, might retire this structure if it creates more problems.
Some errors are actually supposed to popup (get logged) per design of some tests.


Allow JSON Objects (maps)

Currently, we always split atrtibutes when sending e.g. a status update:
{"h": 34, "w": 56}
But sometimes it might be easier to send some attributes as maps (json objects):
{"size": {"h": 34, "w": 56}}
But what about sending an array of size? With the current approach we allow lists, but what is allowed inside a list?
[{"h": 34, "w": 56}, {"h": 23, "w": 32}]
We're not really clear about this at the moment. I think we should just be explicit that allow any json structure. But of course it must be described in the sxl.
Perhaps we should add a guideline on designing SXLs, specifically about how to name and structure attributes.
This is a follow up to #133.

Part of this would to move a bit away from describing the data types we support, and instead just state that it's json. The SXL then define the data structure used for each message.

It would be really interesting to have this new possibility of sending some attributes as "maps (json objects)".
It could be introducted in a new patch RSMP version 3.2.x ? (not really breaking anything, just an addon).

As this would be an addition, it would at at least bump the version to 3.3.

Hello,
The day this new "type" is added to RSMP Core in the "4.6 Dataypes" chapter,
what "Datatype" name would be used ?
"map" ?
(it might be interesting for future SXL projects under construction to mention it instead of "array" as at present...)
Thanks.

About this new adddon of "type", perhaps using simply the name "object" would be interesting.
This seems to be the term used in JSON specification
(even if theses others are also mentionned: "record" / "hash table" / "keyed list" / "struct" / ...)
If a term could already at least be chosen to start....

For reference,
the associated PR is here : #195


Request: Allow Category for Bash expose commands

Describe the solution you'd like
I would like to be able to specify the Home Assistant Category for custom bash sensors/buttons, in order for them to be grouped more appropriately in the HA Device page.
Additional context
HA allows for 3 categories; Config, Diagnostic, and Sensors.  Currently, buttons are set as Config, and Sensors are set as Sensors.  I would like to be able to set some sensors as Diagnostic if appropriate.

It should be easy to implement a sensor category.
I'll look into it and I'll update you accordingly.

I've added the category choice which is between diagnostic and config.


Test Kotlin 1.9.0-RC

See https://github.com/JetBrains/kotlin/releases/tag/v1.9.0-RC

@bot-gradle test AFT AST APT

I've triggered the following builds for you:

AllFunctionalTestsPullRequestFeedback build
AllSmokeTestsPullRequestFeedback build
AllPerformanceTestsReadyForRelease build

@bot-gradle test AFT

I've triggered the following builds for you:

AllFunctionalTestsPullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Update Datadog SDK to version 2.5.1

This PR has been created automatically by the CI
Updating Datadog SDK from version 2.5.0 to version 2.5.1: diff

Codecov Report

Merging #219 (5a79a44) into develop (5895876) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #219   +/-   ##
==========================================
  Coverage      78.05%   78.05%
  Complexity       186      186
==========================================
  Files             22       22
  Lines            665      665
  Branches          85       85
==========================================
  Hits             519      519
  Misses           116      116
  Partials          30       30


Fix Issue 18081 - dlangspec.pdf: don't escape dollars in code examples

Before:

After:

Before:

After:

See also: https://github.com/dlang/dlang.org/pull/1983

Is it just the font, or are those backticks actually single quotes?

Is it just the font, or are those backticks actually single quotes? -- must be the font, the code looks right.

Ah yes, we shouldn't execute the macro here nor use the $(DOLLAR).
-> https://github.com/dlang/dlang.org/pull/1996


Why are the features in the official documentation not working??? !!!!!

I am a beginner in Web3. The official documentation from Leon is very unfriendly. I understand the rebranding, but can you guarantee that your rebranding code works 100%? The rebranding happened at the end of September, but I would like to use WalletConnect v2 until February next year. However, since you’ve wiped out all the official documentation, I can’t find any information anywhere. Also, the "recommended wallet" and "excluded wallet" features are not working. Additionally, when I set Coinbase to false, the build keeps failing. What on earth is going on?
problem 1
if set coinbase enabled : false  app crash (very bad!!!),
problem 2
if set excludedWallet, includedWallet is not working (very bad!!!),

if set coinbase enabled : false app crash

today I'm releasing version 1.0.6 with a fix


[REQUEST] Folders for organizing connections.

It'd be amazing if we could create our own "folders" to group connections for various projects, where we could drag and drop them inside.
I have dozens of servers I connect to regularly, having one long list of connections is not ideal.

i like this feature too

Now I integrated the ssh function into the new extension, it supports grouping of connections, but free users can create up to 3 connections, and you can create unlimited connections after upgrade premium @ibnux .

Now I integrated the ssh function into the new extension, it supports grouping of connections, but free users can create up to 3 connections, and you can create unlimited connections after upgrade premium @ibnux .
https://marketplace.visualstudio.com/items?itemName=cweijan.vscode-database-client2.

Great 👍
Thank you


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/types-emoji-feedstock#4.


Accessing the website results in a 404 error

🐛 Bug Report
When navigating to https://facebook.github.io/jest/, I get a 404 error. Other sites (e.g. the react-native site) load fine.
To Reproduce
Steps to reproduce the behavior: Go to the Jest website. Direct URL, via the facebook.github.io website, via google, etc.
Expected behavior
Website loads.
Run npx envinfo --preset jest
Paste the results here:
n.a.

Closing in favor of #6239


Current Comfy3D not support the last ComfyUI with Cuda 12.4

Unfortunately, Comfy3D is not compatible with the latest Comfy because, according to the installation information, Cuda 12.4 is already required, but Comfy3D is still Cuda 12.1
I installed Comfy3D from ComfyUI Manager
Please update to full compatibility

Please update to full compatibility

I installed with CUDA11.8 with not problem? But it would be nice to get updated version! Thanks!

That is really weird, v0.1.2 is support Cuda 12.4, and ComfyUI-Manager should pull directly from my main branch.
I'll take a closer look at this install from ComfyUI-Manager matter
But I'm sure if you git clone and pip install -r requirements.txt and then python install.py it would be work.
Cheers 👍

i try this pip install -r requirements.txt is no, now i will try cuda 12.1 version。

@MrForExample are you working on the _Wheels_win_py312_torch2.5.1_cu124 version but for linux?


Visual brand identity: Design exploration (moodboards)

User story
As a ReportStream team member/user, I want to experience the ReportStream brand identity in a consistent and recognizable way.
Background & context
Goal: Establish an identity that clarifies ReportStream's brand & offerings through a modern visual system built to scale.
This ticket captures the work of conducting visual research (moodboards) and to inform possible visual brand directions in #9953. Moodboards serve as inspiration and alignment tools during the design phase.
Working links

Mural: Visual branding workspace
Moodboards: Visual identity drafts slide deck

Acceptance criteria

[x] Moodboards completed in accessible format
[x] Moodboards referenced with draft design(s) in #9953

Moodboards created and completed in the Visual identity draft(s) deck.