AuroraBoot missing dependencies when running binary, not starting pixieboot when running in container.

Kairos version:
quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1
CPU architecture, OS, and Version:
Linux spacebar 6.4.10-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 11 Aug 2023 11:03:36 +0000 x86_64 GNU/Linux
Describe the bug
When I run AuroraBoot in a container, pixieboot does not seem to start. When I run AuroraBoot directly it only works with github artifacts not with container images, then it is missing dependencies to build/serve netboot artifacts.
To Reproduce

Running AuroraBoot container

sudo podman run --privileged --net host --rm -i -t -v $PWD/aurora.yaml:/aurora.yaml -v $PWD/build:/tmp/auroraboot -v $PWD/data:/tmp/data quay.io/kairos/auroraboot --debug /aurora.yaml

Running AuroraBoot binary

sudo ./AuroraBoot --debug ./aurora.yaml

Expected behavior
When I use AuroraBoot binary, it should be able to build/serve iso/netboot artifacts.
When I use AuroraBoot in a container with host networking, it should have no problems serving all it needs to.
Logs

Running binary:

5:07PM INF Pulling container image 'quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1' to '/home/thomas/kairos/build/temp-rootfs' (local: true)
5:08PM DBG Output 'INFO   Downloading quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1 to /home/thomas/kairos/build/temp-rootfs
 INFO   Size: 2.402GiB'
5:08PM INF Generating iso 'kairos' from '/home/thomas/kairos/build/temp-rootfs' to '/home/thomas/kairos/build/iso'
5:08PM DBG Output '/bin/sh: line 1: /entrypoint.sh: No such file or directory'
5:08PM ERR Failed generating iso 'kairos' from '/home/thomas/kairos/build/temp-rootfs'. Error: exit status 127
4 errors occurred:
	* exit status 127
	* 'extract-netboot' deps gen-iso failed
	* 'start-httpserver' deps gen-iso failed
	* 'start-netboot' deps extract-netboot failed

Running in container:

3:33PM DBG #cloud-config
install:
  auto: true
  device: /dev/nvme1n1
  reboot: true
hostname: kairos-node-{{ trunc 4 .MachineID }}
users:
  - name: kairos
    passwd: kairos
    ssh_authorized_keys:
      - github:tbrasser
debug: true
strict: true
k3s:
  enable: true
bundles:
  - targets:
      - run://quay.io/kairos/community-bundles:system-upgrade-controller_latest
      - run://quay.io/kairos/community-bundles:cert-manager_latest
      - run://quay.io/kairos/community-bundles:kairos_latest
kairos:
  entangle:
    enable: true
  entangleProxy:
    enable: true
p2p:
  role: master
  network_token: |
    <redacted>
reset:
  reboot: true
  reset-persistent: true
  reset-oem: true
upgrade:
  reboot: true

3:33PM DBG 1.
3:33PM DBG  <prepare-iso> (background: false)
3:33PM DBG  <prepare-netboot> (background: false)
3:33PM DBG  <prepare-temp> (background: false)
3:33PM DBG
3:33PM DBG 2.
3:33PM DBG  <container-pull> (background: false)
3:33PM DBG  <copy-cloud-config> (background: false)
3:33PM DBG
3:33PM DBG 3.
3:33PM DBG  <gen-iso> (background: false)
3:33PM DBG
3:33PM DBG 4.
3:33PM DBG  <start-httpserver> (background: true)
3:33PM DBG  <extract-netboot> (background: false)
3:33PM DBG
3:33PM DBG 5.
3:33PM DBG  <start-netboot> (background: true)
3:33PM DBG
3:33PM INF Pulling container image 'quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1' to '/home/thomas/kairos/build/temp-rootfs' (local: false)
3:37PM DBG Output ' INFO    Downloading  quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1  to  /home/thomas/kairos/build/temp-rootfs
 INFO    Pulled: sha256:e01b4602b73d840b452dcfe3750d9e331b11adea3baaaa11be81f5dd8afe6239 quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1
 INFO    Size: 2.402GiB
'
3:37PM INF Generating iso 'kairos' from '/home/thomas/kairos/build/temp-rootfs' to '/home/thomas/kairos/build/iso'
3:40PM DBG Output '+ enki --config-dir /config --debug --name kairos build-iso --squash-no-compression --overlay-iso /tmp/geniso69068545 --date=false --output /home/thomas/kairos/build/iso dir:/home/thomas/kairos/build/temp-rootfs
INFO[2023-08-22T15:37:57Z] Starting enki version 0.0.1
DEBU[2023-08-22T15:37:57Z] {Version:0.0.1 GitCommit: GoVersion:go1.20.6}
DEBU[2023-08-22T15:37:57Z] Full config loaded: &v1.BuildConfig{
  Date: false,
  Name: "kairos",
  OutDir: "/home/thomas/kairos/build/iso",
  Config: v1.Config{
    Logger: &v1.logrusWrapper{ // p0
      Logger: &logrus.Logger{
        Out: &os.File{},
        Hooks: logrus.LevelHooks{},
        Formatter: &logrus.TextFormatter{
          ForceColors: true,
          DisableColors: false,
          ForceQuote: false,
          DisableQuote: false,
          EnvironmentOverrideColors: false,
          DisableTimestamp: false,
          FullTimestamp: true,
          TimestampFormat: "",
          DisableSorting: false,
          SortingFunc: ,
          DisableLevelTruncation: false,
          PadLevelText: false,
          QuoteEmptyFields: false,
          FieldMap: logrus.FieldMap(nil),
          CallerPrettyfier: ,
        },
        ReportCaller: false,
        Level: 5,
        ExitFunc: os.Exit,
        BufferPool: nil,
      },
    },
    Fs: &vfs.osfs{}, // p1
    Mounter: &mount.Mounter{},
    Runner: &v1.RealRunner{ // p2
      Logger: p0,
    },
    Syscall: &v1.RealSyscall{},
    CloudInitRunner: &cloudinit.YipCloudInitRunner{},
    ImageExtractor: nil,
    Client: &http.Client{},
    Platform: &v1.Platform{
      OS: "linux",
      Arch: "x86_64",
      GolangArch: "amd64",
    },
    Cosign: false,
    Verify: false,
    CosignPubKey: "",
    Repos: []v1.Repository{},
    Arch: "x86_64",
    SquashFsCompressionConfig: []string{},
    SquashFsNoCompression: true,
  },
}
DEBU[2023-08-22T15:37:57Z] Loaded LiveISO: &v1.LiveISO{
  RootFS: nil,
  UEFI: []*v1.ImageSource{
    &v1.ImageSource{},
  },
  Image: []*v1.ImageSource{
    &v1.ImageSource{},
    &v1.ImageSource{},
  },
  Label: "COS_LIVE",
  GrubEntry: "Kairos",
  BootloaderInRootFs: false,
}
INFO[2023-08-22T15:37:57Z] Preparing squashfs root...
INFO[2023-08-22T15:37:57Z] Copying /home/thomas/kairos/build/temp-rootfs source...
INFO[2023-08-22T15:37:57Z] Starting rsync...
DEBU[2023-08-22T15:37:57Z] Running cmd: 'rsync --progress --partial --human-readable --archive --xattrs --acls --exclude=/mnt --exclude=/proc --exclude=/sys --exclude=/dev --exclude=/tmp --exclude=/host --exclude=/run /home/thomas/kairos/build/temp-rootfs/ /tmp/enki-iso324095657/rootfs/'
DEBU[2023-08-22T15:38:02Z] Syncing data...
DEBU[2023-08-22T15:38:07Z] Syncing data...
INFO[2023-08-22T15:38:07Z] Finished syncing
INFO[2023-08-22T15:38:07Z] Finished copying /home/thomas/kairos/build/temp-rootfs into /tmp/enki-iso324095657/rootfs
INFO[2023-08-22T15:38:07Z] Preparing EFI image...
INFO[2023-08-22T15:38:07Z] Copying /efi source...
INFO[2023-08-22T15:38:07Z] Starting rsync...
DEBU[2023-08-22T15:38:07Z] Running cmd: 'rsync --progress --partial --human-readable --archive --xattrs --acls --exclude=/mnt --exclude=/proc --exclude=/sys --exclude=/dev --exclude=/tmp --exclude=/host --exclude=/run /efi/ /tmp/enki-iso324095657/uefi/'
INFO[2023-08-22T15:38:07Z] Finished syncing
INFO[2023-08-22T15:38:07Z] Finished copying /efi into /tmp/enki-iso324095657/uefi
INFO[2023-08-22T15:38:07Z] Preparing ISO image root tree...
INFO[2023-08-22T15:38:07Z] Copying /efi source...
INFO[2023-08-22T15:38:07Z] Starting rsync...
DEBU[2023-08-22T15:38:07Z] Running cmd: 'rsync --progress --partial --human-readable --archive --xattrs --acls --exclude=/mnt --exclude=/proc --exclude=/sys --exclude=/dev --exclude=/tmp --exclude=/host --exclude=/run /efi/ /tmp/enki-iso324095657/iso/'
INFO[2023-08-22T15:38:07Z] Finished syncing
INFO[2023-08-22T15:38:07Z] Finished copying /efi into /tmp/enki-iso324095657/iso
INFO[2023-08-22T15:38:07Z] Copying /grub2 source...
INFO[2023-08-22T15:38:07Z] Starting rsync...
DEBU[2023-08-22T15:38:07Z] Running cmd: 'rsync --progress --partial --human-readable --archive --xattrs --acls --exclude=/mnt --exclude=/proc --exclude=/sys --exclude=/dev --exclude=/tmp --exclude=/host --exclude=/run /grub2/ /tmp/enki-iso324095657/iso/'
INFO[2023-08-22T15:38:07Z] Finished syncing
INFO[2023-08-22T15:38:07Z] Finished copying /grub2 into /tmp/enki-iso324095657/iso
INFO[2023-08-22T15:38:07Z] Copying /tmp/geniso69068545 source...
INFO[2023-08-22T15:38:07Z] Starting rsync...
DEBU[2023-08-22T15:38:07Z] Running cmd: 'rsync --progress --partial --human-readable --archive --xattrs --acls --exclude=/mnt --exclude=/proc --exclude=/sys --exclude=/dev --exclude=/tmp --exclude=/host --exclude=/run /tmp/geniso69068545/ /tmp/enki-iso324095657/iso/'
INFO[2023-08-22T15:38:07Z] Finished syncing
INFO[2023-08-22T15:38:07Z] Finished copying /tmp/geniso69068545 into /tmp/enki-iso324095657/iso
DEBU[2023-08-22T15:38:07Z] Copying Kernel file /tmp/enki-iso324095657/rootfs/boot/vmlinuz-6.2.0-27-generic to iso root tree
DEBU[2023-08-22T15:38:07Z] Copying initrd file /tmp/enki-iso324095657/rootfs/boot/initrd-6.2.0-27-generic to iso root tree
INFO[2023-08-22T15:38:07Z] Creating squashfs...
DEBU[2023-08-22T15:38:07Z] Running cmd: 'mksquashfs /tmp/enki-iso324095657/rootfs /tmp/enki-iso324095657/iso/rootfs.squashfs -b 1024k'
INFO[2023-08-22T15:40:29Z] Creating EFI image...
INFO[2023-08-22T15:40:29Z] Creating file system image /tmp/enki-iso324095657/iso/boot/uefi.img
DEBU[2023-08-22T15:40:29Z] Running cmd: 'mkfs.vfat -n COS_GRUB /tmp/enki-iso324095657/iso/boot/uefi.img'
DEBU[2023-08-22T15:40:29Z] Running cmd: 'mcopy -s -i /tmp/enki-iso324095657/iso/boot/uefi.img /tmp/enki-iso324095657/uefi/EFI ::'
DEBU[2023-08-22T15:40:29Z] Running cmd: 'mcopy -s -i /tmp/enki-iso324095657/iso/boot/uefi.img /tmp/enki-iso324095657/uefi/var ::'
INFO[2023-08-22T15:40:29Z] Creating ISO image...
DEBU[2023-08-22T15:40:29Z] Running cmd: 'xorriso -volid COS_LIVE -joliet on -padding 0 -outdev /home/thomas/kairos/build/iso/kairos.iso -map /tmp/enki-iso324095657/iso / -chmod 0755 -- -boot_image grub bin_path=/boot/x86_64/loader/eltorito.img -boot_image grub grub2_mbr=/tmp/enki-iso324095657/iso//boot/x86_64/loader/boot_hybrid.img -boot_image grub grub2_boot_info=on -boot_image any partition_offset=16 -boot_image any cat_path=/boot/x86_64/boot.catalog -boot_image any cat_hidden=on -boot_image any boot_info_table=on -boot_image any platform_id=0x00 -boot_image any emul_type=no_emulation -boot_image any load_size=2048 -append_partition 2 0xef /tmp/enki-iso324095657/iso/boot/uefi.img -boot_image any next -boot_image any efi_path=--interval:appended_partition_2:all:: -boot_image any platform_id=0xef -boot_image any emul_type=no_emulation'
DEBU[2023-08-22T15:40:32Z] Xorriso: xorriso 1.4.6 : RockRidge filesystem manipulator, libburnia project.

Drive current: -outdev '/home/thomas/kairos/build/iso/kairos.iso'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data,  182g free
xorriso : UPDATE : 1168 files added in 1 seconds
Added to ISO image: directory '/'='/tmp/enki-iso324095657/iso'
xorriso : NOTE : Copying to System Area: 512 bytes from file '/tmp/enki-iso324095657/iso/boot/x86_64/loader/boot_hybrid.img'
xorriso : UPDATE : Writing:      12896s    2.0%   fifo   9%  buf  50%
xorriso : UPDATE : Writing:      64528s   10.2%   fifo  41%  buf  50%
xorriso : UPDATE : Writing:     566736s   89.3%   fifo  99%  buf  50%  741.9xD
ISO image produced: 634343 sectors
Written to medium : 634352 sectors at LBA 48
Writing to '/home/thomas/kairos/build/iso/kairos.iso' completed successfully.

'
3:40PM INF Extracting netboot artifacts 'kairos' from '/home/thomas/kairos/build/iso/kairos.iso' to '/home/thomas/kairos/build/netboot'
3:40PM INF Listening on <IP_ADDRESS>:8080...
3:40PM DBG Output ''
3:40PM INF Start pixiecore

Tried building with osbuilder on kind and getting better results (@2.4.0-rc1)!
netboot: true works, but gkeImage: true doesn't. At least I got a WoW now that is usable.
Can update here or close and create new issues when they come up.

I'm getting the same errors when trying to use ghcr.io/kairos-io/provider-rke2:v2.3.3 with Auroraboot in Docker.
https://github.com/kairos-io/kairos/discussions/1793

@tbrasser I don't have podman installed so I just replaced podman with docker in your command:
sudo docker run --privileged --net host --rm -i -t -v $PWD/aurora.yaml:/aurora.yaml -v $PWD/build:/tmp/auroraboot -v $PWD/data:/tmp/data quay.io/kairos/auroraboot --debug /aurora.yaml

also I don't know what your aurora.yaml looks like. I created one that would pull the same image as in the description:
container_image: quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1

It works just fine. Among the rest of the output, I see this line:
6:52AM INF Pulling container image 'quay.io/kairos/kairos-ubuntu:v2.4.0-alpha2-k3sv1.27.3-k3s1' to '/tmp/temp-rootfs' (local: false)

Your output says local: true. Are you prefixing your image in the aurora config with docker:// . This will make auroraboot try to use a local image and not pull it.

I tried various combinarions, will try again with 2.4.0 release. What is the suggested WoW? osbuilder or auroraboot? (also encountering some race conditions in the main/sidecar containers there, seems to me all should be initContainers with exporter to nginx as single main container. (also probably job instead of bare pod))

Regarding osbuilder, I agree. On osbuilder master branch, we've already switched to InitContainers. Also, it used to be a Job but was later converted to a Pod. I still think it should be a Job and we'll probably change it back to a Job in the future.
There is a lot of work planned on osbuilder and when we are done, auroraboot will be used internally by osbuilder but will also be used directly by users that don't want to use Kubernetes for building.
Relevant issue with more information: https://github.com/kairos-io/kairos/issues/1633

@tbrasser since we can't reproduce it, I'll close this. Please give it a try with 2.4.0 and feel free to re-open is the issue persists. Thanks for reporting!


ISSUE-283: Pulsar Manager keeps saying "This environment is error. Please check it"

Original Issue: apache/pulsar-manager#283

OS:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.4 LTS
Release:	18.04
Codename:	bionic
Hi,
I have Pulsar instance running in standalone mode.
Also I started Pulsar-Manager with docker. Here is the command line:
docker run -it -p 9527:9527 -e REDIRECT_HOST=http://<IP_ADDRESS> -e REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e URL='jdbc:postgresql://<IP_ADDRESS>:5432/pulsar_manager' -e USERNAME=pulsar -e PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data apachepulsar/pulsar-manager:v0.1.0 /bin/sh
On Add Environment action

i'm getting following error

But there is no any errors in the logs of Pulsar.
Did I miss some configuraion?
Thanks.

an external contributor has worked on this issue. Here is the PR link: https://github.com/apache/pulsar-manager/pull/314


Each refresh counts as 3 API calls?

Im running into Error 429 (Request limit exceeded)..
I noticed that each request counts as 3 on the Viessmann API...
For example i open the Viessmann Dashboard and i see that i used 100 requests so far..
When the Adapter pulls the data the counter is increasing to 103.
So it seems like the adapter is making three calls every time the interval is triggered..?

For each device one request you can see this in debug log

I only have one device...

please reinstall again


Google translate detect invalid language(und) for string 123.

Hi All,
I was trying to use google translate module.
for string 123 it is detecting some invalid language.
var translate = require('@google-cloud/translate');
var text= "123";
var translateClient = translate({
  projectId: '<ProjectID>',
  key: '<KEY>'
});
translateClient.detect(text, function(err, results) {
  if (!err) {
  console.log(results.language);
  }
});

Here i just gave small snippet to reproduce issue.
Environment details

OS:
Node.js version: v6.10.2
npm version: 5.0.1
google-cloud-node version: @google-cloud/translate": "^0.8.2

Steps to reproduce

Save code as temp.js,Populate projectID and key and run it as node temp.js
Language detected by google translate will be und.

According to a little blip of info on this page, it apparently stands for "undetermined":

If the source language or target language is unknown, use the “und” language specification to indicate undetermined language.

The context in this document isn't the same, but it's the only place I found that mentions und in a response means the language could not be determined. Sorry for the confusion!


Config: Update all leftover references to sync_version_file_path

Commit 8e56ea8 renamed sync_version_file_path to
version_sync_file_location, however some places still refer to the old name.
This is mostly relevant in the README and in the error messages (as sync_version_file_path needs to be set to use bob sync is still printed, which uses the wrong name and is quite confusing)
The commit was generated from this command running on MacOS
find src/**/* -type f | xargs sed -i '' -e 's/sync_version_file_path/version_sync_file_location/g'

(and then I also edited the README manually)

looks good!


UI - Fix display IP Address allow input

Description
Fixes https://github.com/apache/cloudstack/issues/5567

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5569 (SL-JID-748)

@blueorangutan ui


Cannot use Apify Python Client at Coegil platform

From email conversation:

We are using Coegil platform to run apify-client library and getting this issue.
Pip install passed fine, installing all dependencies.
from apify_client import ApifyClient
ModuleNotFoundError: No module named 'apify_client'

This is most probably not a bug with the Python Client, but rather with the way the user is installing the package at Coegil, which is a very closed off data science platform. I think there's nothing we can do about this.


Chat Sample account creation doesn't work

The chat sample has issues with the versions of the EF packages preventing you from creating new users.
@BrennanConroy
fail: Microsoft.EntityFrameworkCore.Query.Internal.SqlServerQueryCompilationContextFactory[1]
      An exception occurred in the database while iterating the results of a query.
      System.Data.SqlClient.SqlException: Cannot open database "aspnet-ChatSample-f11cf018-e0a8-49fa-b749-4c0eb5c9150b" requested by the login. The login failed.
      Login failed for user 'REDMOND\mimengis'.
         at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, Object providerInfo, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling)
         at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
         at System.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
         at System.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
         at System.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
         at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
         at System.Data.ProviderBase.DbConnectionPool.WaitForPendingOpen()
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Is it really package versions? The exception is just saying that the connection to the database can't be opened...

He didnt mention that running 'dotnet ef' fails
Get Outlook for Androidhttps://aka.ms/ghei36

From: Pawel Kadluczka<EMAIL_ADDRESS>Sent: Thursday, November 17, 2016 12:02:47 PM
To: aspnet/SignalR
Cc: Brennan Conroy; Mention
Subject: Re: [aspnet/SignalR] Chat Sample account creation doesn't work (#38)
Is it really package versions? The exception is just saying that the connection to the database can't be opened...

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FSignalR%2Fissues%2F38%23issuecomment-261353651&data=02|01|brecon%40microsoft.com|18c0a562f75c4bd6748508d40f24b523|72f988bf86f141af91ab2d7cd011db47|1|0|636150097708691824&sdata=KzFg27SHhUAWxKHz0Z%2BQ4sF9KaMXUILXyakXs93Gs%2Bw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHOVESY3jZGL4F6W-HZUa83BrHrfYOwQks5q_LLngaJpZM4K1vGd&data=02|01|brecon%40microsoft.com|18c0a562f75c4bd6748508d40f24b523|72f988bf86f141af91ab2d7cd011db47|1|0|636150097708691824&sdata=HKcF5gMix%2FmWGOr1g4Qg0WAOLz%2FcuJv9wyLoDzkie24%3D&reserved=0.

So, migrations were not applied as a result there is no database hence the error at runtime if I understand correctly.

So turns out the Microsoft.EntityFrameworkCore.Tools here in the tools section needs to be  Microsoft.EntityFrameworkCore.Tool.Dotnet and we need another reference to Microsoft.EntityFrameworkCore.Tools  in the dependencies section.

Fixed in 1a29ddb9dedfb59fb0ec0154debe23fa42e61c4d


Underscores disappeared for y -> ies plurals

4.1.0 includes #366 that broke method names for plurals that are not strict suffix of the singular kind.
Differences between method names in kubeclient 4.0.0 to 4.1.0, across multiple kubernetes & openshift versions:
https://gist.github.com/cben/344a0c7bf74ea50f185c29b52fe0678f#file-changes-diff

network_policy	network_policies became networkpolicy	networkpolicies.
pod_security_policy	pod_security_policies became podsecuritypolicy	podsecuritypolicies.
egress_network_policy	egress_network_policies became egressnetworkpolicy	egressnetworkpolicies.
cluster_policy	cluster_policies became clusterpolicy	clusterpolicies.
network_policy	network_policies became networkpolicy	networkpolicies.

it's not in principle limited to y -> ies plurals, e.g. if you had a CRD with BigDatum / bigdata then methods were big_datum big_data previously and became bigdatum  bigdata in 4.1.0.
I want to fix the above ASAP in 4.1.1, restoring the underscores.

Other change that I'd say is a bug:
Entities where kind is inconsistent with plural name previously were skipped — no methods were defined for them:

ReplicationControllerDummy	replicationcontrollers  (extensions/v1beta1)
DeploymentConfig	generatedeploymentconfigs  (oapi/v1)
Template	processedtemplates  (template.openshift.io/v1, oapi/v1)

Now these always get "fallback" methods defined — using kind.downcase and name, with no underscores attempted.
This change I kinda intended.  cc @masayag — you're tweaking this fallback in #373 — do you agree this last fallback is good, or is there a reason we revert these as well in 4.1.1?

This change I kinda intended. cc @masayag — you're tweaking this fallback in #373 — do you agree this last fallback is good, or is there a reason we revert these as well in 4.1.1?

@cben I think the tweaked fallback is good. It makes more sense to me to have
(replicationcontrollerdummy, replicationcontrollers) than having (replication_controller_dummy, replicationcontrollers) in terms of predictability.

The plot thickens (out-of-scope for this issue — this one is just about disappeared methods — but continuing here as we're already discussing this):
Of the 3 methods now added thanks to the fallback, "ReplicationControllerDummy" is silly and obsolete, and the other 2 collide with other resources with same kind:
      "name": "templates",
      "kind": "Template",
      "verbs": ["create", "delete", ...]
...
      "name": "processedtemplates",
      "kind": "Template",
      "verbs": ["create"]

(both oapi/v1 as well as apis/template.openshift.io/v1 contain this collision)
Previous behaviour ignored processedtemplates — no methods were created for this.
New behaviour would try creating methods for both:
	template	processedtemplates
	template	templates

with last one arbitrarily winning for get_template :-(
Up to openshift v3.6, it also had a 2nd kind collision:
      "name": "generatedeploymentconfigs",
      "kind": "DeploymentConfig",
      "verbs": []
...
      "name": "deploymentconfigs",
      "kind": "DeploymentConfig",
      "verbs": ["create", "delete", ...]

Amusingly, this one does not result in method collision, because only the former gets underscores:
	deployment_config	deployment_configs
	deploymentconfig	generatedeploymentconfigs

In theory, the generic fallback is useful for CRDs, but looking at these examples it's mostly harmful :unamused:
Perhaps cleanest solution is special-casing processedtemplates to processed_template processed_templates.


fix NoClassDefFoundError - io.airlift.compress.lz4.UnsafeUtil

Motivation
Java client fails with Java 16 while receiving a message. Error:
[org.apa.pul.cli.imp.ClientCnx] (pulsar-client-io-2-1) [localhost/<IP_ADDRESS>:6650] Got exception java.lang.NoClassDefFoundError: Could not initialize class io.airlift.compress.lz4.UnsafeUtil
	at io.airlift.compress.lz4.Lz4RawDecompressor.decompress(Lz4RawDecompressor.java:60)
	at org.apache.pulsar.common.compression.CompressionCodecLZ4.decode(CompressionCodecLZ4.java:91)
	at org.apache.pulsar.client.impl.ConsumerImpl.uncompressPayloadIfNeeded(ConsumerImpl.java:1507)
	at org.apache.pulsar.client.impl.ConsumerImpl.messageReceived(ConsumerImpl.java:1037)
	at org.apache.pulsar.client.impl.ClientCnx.handleMessage(ClientCnx.java:447)
	at org.apache.pulsar.common.protocol.PulsarDecoder.channelRead(PulsarDecoder.java:186)
...

Can be reproduced with the official example for Java Client from the docu while using JDK 16.
Workaround
Locally I use pulsar-client-original, and exclude the aircompressor 16. Example:
<dependency>
  <groupId>org.apache.pulsar</groupId>
  <artifactId>pulsar-client-original</artifactId>
  <version>${pulsar.version}</version>
  <exclusions>
    <exclusion>
      <groupId>io.airlift</groupId>
      <artifactId>aircompressor</artifactId>
    </exclusion>
  </exclusions>
</dependency>

<!-- https://mvnrepository.com/artifact/io.airlift/aircompressor -->
<dependency>
  <groupId>io.airlift</groupId>
  <artifactId>aircompressor</artifactId>
  <version>0.19</version>
</dependency>

Modifications
Upgrade io.airlift.aircompressor to version 19.
Does this pull request potentially affect one of the following parts:

Dependencies yes upgrade

@newur We also need to update the version in the license files:
Run src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
io.airlift-aircompressor-0.19.jar unaccounted for in LICENSE
io.airlift-aircompressor-0.16.jar mentioned in LICENSE, but not bundled
aircompressor-0.19.jar unaccounted for in lib/presto/LICENSE
aircompressor-0.19.jar unaccounted for in lib/presto/LICENSE
aircompressor-0.16.jar mentioned in lib/presto/LICENSE, but not bundled
src/check-binary-license: line 120: echo: write error: Broken pipe

It looks like there are issues with the LICENSE/NOTICE.
Error: Process completed with exit code 2.

You can find them at:

distribution/server/src/assemble/LICENSE.bin.txt
pulsar-sql/presto-distribution/LICENSE

For the record: deep down the following error is thrown when using JDK 16 and aircompressor <19:
Unable to make field long java.nio.Buffer.address accessible: module java.base does not "opens java.nio" to unnamed module

Could not make it work with VM parameters like --add-opens java.base/java.nio=ALL-UNNAMED.

I cannot reproduce the failing unit tests locally. Checkout tag v2.8.0, changed the the aircompressor version and looks okay...

It is a flaky test.
I restarted the job. Don't worry


[plot] Split PlotWindow toolbar and refactor silx.gui.plot.PlotTools

This PR adds a new silx.gui.plot.tools package.
Content of silx.gui.plot.PlotTools has moved there and is now depreacted.
It also contains a few "ready to use" toolbars:

for interactive modes
for copy, save, print
for basic plot config for curves
for basic plot config for images

The first 2 toolbars are used in PlotWindow.
It is not possible to further refactor PlotWindow, Plot1D and Plot2D toolbars without breaking the API and I don't think it worth it.
examples/plotWidget.py sample code was update to illustrate how to create an ad hoc PlotWindow-like widget by reusing toolbars, actions and the colorbar.
closes  #1162

LGTM


Fix CAD conversion and merge commit

This pull request fixes the CADC conversion and includes a merge commit. The CADC conversion was not validated properly, and this PR ensures that the conversion is validated correctly. Additionally, the merge commit '2bc85bdd7aa871538e83717a09ef5433e92d36a8' is included in this pull request.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


UI Computer

Updated branch

Should probably assign the footprint just as a general rule before merging this one.
What's up with the 1K and 10K resistors on the digital inputs?
Connections look good though!

Should probably assign the footprint just as a general rule before merging this one.
What's up with the 1K and 10K resistors on the digital inputs?
Connections look good though!

The RaspberryPi symbol is in the RespiraWorks library, ready to be added to this sheet - it's linked to the appropriate footprint so there'll be an outline and placement guide for the connector.

The RaspberryPi symbol is in the RespiraWorks library, ready to be added to this sheet - it's linked to the appropriate footprint so there'll be an outline and placement guide for the connector.

oh the 1k and 10k were bc on foundrym it was pulled up w/o resistor so I put a 1K and a note. And edwin said didn't need to be pulled up so just DNP them in case we want to put a pull up for some reason. I can just remove the 1K if preferred

oh the 1k and 10k were bc on foundrym it was pulled up w/o resistor so I put a 1K and a note. And edwin said didn't need to be pulled up so just DNP them in case we want to put a pull up for some reason. I can just remove the 1K if preferred

should be good to go now

should be good to go now

Oh I was talking about the value of the resistors (as in, why they're not all 0) rather than the extra DNP ones.
Looks like the changes here includes the rescue libraries and the indicator sheet changes, along with a bunch of others - probably best to do the same as with indicators, just save ui_computer.sch, ditch this branch and create a new one, and paste in the updated ui_computer.sch.

Oh I was talking about the value of the resistors (as in, why they're not all 0) rather than the extra DNP ones.
Looks like the changes here includes the rescue libraries and the indicator sheet changes, along with a bunch of others - probably best to do the same as with indicators, just save ui_computer.sch, ditch this branch and create a new one, and paste in the updated ui_computer.sch.

recommend adding decoupling and bulk capacitors to the 5V input power
did we conclude that we want to move to giving ports generic (GPIO1, GPIO2, PA0, PA1) names at the sub-sheet level?  I think we discussed making those assignments at the top sheet level.

recommend adding decoupling and bulk capacitors to the 5V input power
did we conclude that we want to move to giving ports generic (GPIO1, GPIO2, PA0, PA1) names at the sub-sheet level?  I think we discussed making those assignments at the top sheet level.


Move the vector-add sample to icpx/icx-cl

This PR moves the vector add sample from the dpcpp driver to icpx on Linux and icx-cl on Windows.

Added @ishaghosh27 to review the README

On Windows environment with recent oneapi installed, I get this error when I try building vector_add.
``
CMake Deprecation Warning at C:/Program Files/CMake/share/cmake-3.25/Modules/CMakeForceCompiler.cmake:89 (message):
The CMAKE_FORCE_CXX_COMPILER macro is deprecated.  Instead just set
CMAKE_CXX_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
CMakeLists.txt:8 (CMAKE_FORCE_CXX_COMPILER)
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19044.
CMake Error at CMakeLists.txt:14 (project):
The CMAKE_CXX_COMPILER:
icx-cl
is not a full path and was not found in the PATH.
-- Configuring incomplete, errors occurred!
``
I have enabled oneapi environments with setvars.bat and icx-cl is in my path so I am not sure why it wont use icx-cl. Instead,I have replaced CMAKE_FORCE_CXX_COMPILER(icx-cl IntelDPCPP) to set(CMAKE_CXX_COMPILER "icx-cl") and it works.

The deprecation warning is expected as we are supporting an old version of cmake and it can be safely ignored.
For the icx-cl issue, that's an interesting one, which version of cmake are you using?


I used the yaml configuration provided by the official website, but it was an exception when I started building the datasource

I used the yaml configuration provided by the official website, but it was an exception when I started building the datasource
exception:

ymal-config:

version: 3.0.0

Your yaml format is error, please see example or document and try to verify it


Expose tools for building & normalizing hotkey & sequence strings

This PR expands the usefulness of the hotkey package by exposing lower-level utilities so that external tools can work with hotkey strings directly instead of only binding event handlers. This closes #93.
The changes include the following:
New types NormalizedHotkeyString and NormalizedSequenceString. These are simple branded string types that should help to encourage the safe use of the hotkey & sequence strings. Normalized hotkey strings can be parsed from plain strings with normalizeHotkey or they can be obtained from events with eventToHotkey (renamed from hotkey). This way, a comparison of string === NormalizedHotkeyString will obviously be false and cause a lint error, ensuring that consumers don't forget to normalize before comparing. The same applies to `NormalizedSequenceString.
Combined the sequence.ts and normalize-sequence.ts files since they are closely related. This groups the code that creates sequence strings together.
Added a new normalizeSequence helper that is the sequence form of normalizeHotkey, enabling abstracting away the splitting and rejoining of sequences. Also added a SEQUENCE_DELIMETER constant.
Exposed all exports from sequence.ts and hotkey.ts. publicly.
This is a breaking change.

Perhaps we should target this change a v3-candidate branch to keep the main branch deployable?

I added this PR to https://github.com/github/hotkey/issues/74


Consider adding normalized names for lookups

Id Name, Scope name, Client id?

@scottbrady91 @leastprivilege So I have identified for this:
Clients => NormalizedClientId
ApiResource => NormalizedName
ApiScope => NormalizedName
IdentityResource => NormalizedName
PersistedGrant => NormalizedClientId and NormalizedSubjectId
Do those really make sense? Should client/scope names be case-insensitive? Should SubjectIds also be case-insensitive?
Why/who asked for this feature? Is there a real use-case here?

This was to handle case sensitivity between db providers. The normalized approach is what the ASP.NET Core Identity library does.
Implementer should be able to register their own normalizer, with the default implementation just uppercasing the values.

When would someone need to replace it?

Given that we don't have an API to create these, I'm finding it hard to have a hook to do the normalization, unless I hard code it in the properties somehow (which means not from DI).

Ok, PR here. Have a look: https://github.com/IdentityServer/IdentityServer4.EntityFramework/pull/96

Do we normalize keys? Subject ids? This is becoming complicated and potentially a security issue.

Killing this, as it seems like a rat's nest.


[Feature] Provide SavedModels of pretrained models

Can you provide SavedModels of pretrained models (with the saved_model.pbfile)?

Related to this, do you have any plans to convert the model to a TensorflowJS model? Having a Javascript counterpart would be pretty useful for embedding Spleeter in other applications.

Update: SavedModels are already currrently being outputted to /tmp/serving after running a spleeter separation.
You can change this output directory via the DEFAULT_EXPORT_DIRECTORY constant in estimator.py.

Related to this, do you have any plans to convert the model to a TensorflowJS model? Having a Javascript counterpart would be pretty useful for embedding Spleeter in other applications.

This will not happening from our side, the only migration we would consider at some point is porting library with TensorFlow 2. Plus I had checked a little bit before releasing and it would be very complicated as TensorFlow JS does not provide the range of functionality Spleeter is currently using in Python (estimator API to be more specific)
But if you are motivated feel free to explore, we would love having other language adoption from contributors.

Update: SavedModels are already currrently being outputted to /tmp/serving after running a spleeter separation.
You can change this output directory via the DEFAULT_EXPORT_DIRECTORY constant in estimator.py.

I will close the issue since you seem to have figured out how but we will also upload those model on the release soon.

@JeffreyCA did you succeed in properly convert the SavedModes into tf.js?
I used the method explained here but had these warnings during conversion:
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_8/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_20/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_20/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_9/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_9/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_21/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_21/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_10/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_10/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_22/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_22/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_11/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_11/cond/FusedBatchNorm'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_23/cond/FusedBatchNorm_1'
WARNING:tensorflow:Didn't find expected Conv2D or DepthwiseConv2dNative input to 'batch_normalization_23/cond/FusedBatchNorm'

No I did not try to do that


Exercise 2.11

Dataset c2_testing_one_percent.rds is missing or has another name. Also, it is never used in the exercises 2.11 part 1 and 2

Aaaaah, it is missing because, yes, in fact, it is never used. I believe I originally intended to include it just to show that the student would in fact need to make a testing set in a realistic situation, but that doesn't seem necessary to me now. I will remove the loading of the testing dataset.


[WIP] fix GOPATH issue when build edge-orchestration project

-. create {BASEDIR}/go and {BASEDIR}/vendor for packages for build
-. do not modify origin GOPATH
Signed-off-by: wansu.yoo<EMAIL_ADDRESS>

may this be rebased on
https://github.com/lf-edge/edge-home-orchestration-go/pull/54


Introducing Naming/ConstantWording cop

Follow up of https://github.com/rubocop-hq/rubocop/pull/6466#issuecomment-437805394.
Introduce this cop to promote clearer and more descriptive constant naming concepts, discourage some of the historical words do not convey the meaning well. Another example from JavaScript community.
710d231 fixed a constant naming found by this new cop.
Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I don't understand clearly the purpose of this cop. Why you set whitelist as an unclear constant naming ?
Also if it would be useful, I think, you should extend the #6352 new cop. Extend it to deal with constants and with your default proposals.

I don't understand clearly the purpose of this cop. Why you set WhiteList as an unclear constant naming ?
Also if it would be useful, I think, you should extend the #6352 new cop. Extend it to deal with constants and with your default proposals.

I don't understand clearly the purpose of this cop. Why you set WhiteList as an unclear constant naming ?
Also if it would be useful, I think, you should extend the #6352 new cop. Extend it to deal with constants and with your default proposals.

I don't have strong preference between having separate cops for dealing with variables, methods and constants and a simple cop handling all of them.

Why you set WhiteList as an unclear constant naming ?

It's racially charged term.

Good purpose, it was not explicit in the pull request presentation.
Using only one cop for any context will simplify the configuration. We might set these terms as unfit for all these contexts in once.

I'm closing this PR due to no recent activity. Feel free to re-open it if you ever come back to it.


A quick question about computing the metrics for genes and cells

Hi, thanks for your great work. After reviewing your codes to compute the correlation, I have some questions.
def get_across_x_correlation(
    ad: ad.AnnData,
    axis: Literal[0, 1] = 0,
    obs_layer: str = "X",
    pred_layer: str = "predicted",
    return_per_entry: bool = False,
):
    """Calculate correlation pred vs obs across given axis

    Arguments
    ---------
    ad: ad.AnnData
        AnnDataFrame hosting observations,
        should be in the orientation gene(obs) x cells(var).
    axis: int [0,1]
        Select the axis across which to correlate
        observations with predictions.
        0 - across genes; 1 - across cells
    obs_layer: str = 'X'
        Name of the anndata layer in which the observations are
        stored. If 'X' is supplied will use the default anndata.X
        matrix. Default = 'X'
    pred_layer: str = 'predicted'
        Name of the anndata layer in which the observations are
        stored. If 'X' is supplied will use the default anndata.X
        matrix. Default = 'predicted'
    return_per_entry: bool = False
        Toggle if to return a dataframe with the per entry correlations.

    Output
    ------
    mean_cor: float
        The mean Pearson correlation across all entries.
    cor_per_entry: [Optional] pd.DataFrame
        Listing the correlation per entry along the non selected axis.

    Notes
    -----
    Will compute the correlation of observations vs. predictions
    per entry. Depending on the axis selected:
    axis=0 -> across genes -> entries are cells
    axis=1 -> across cell (types) -> entries are cells
    """
    print(ad.shape)
    if obs_layer == "X":
        obs = ad.to_df()
    else:
        obs = ad.to_df(layer=obs_layer)

    if pred_layer == "X":
        pred = ad.to_df()
    else:
        pred = ad.to_df(layer=pred_layer)

    # correlation across genes per cell
    cor_per_entry = obs.corrwith(pred, axis=axis)

    mean_cor = np.nanmean(cor_per_entry)

    if return_per_entry:
        return mean_cor, cor_per_entry
    else:
        return mean_cor

It seems that your comments mention that "   axis=1 -> across cell (types) -> entries are cells" I think there exists a typo. It should be entries are genes, otherwise the commetns for axis=0 and axis=1 are the same.
I check the shape of anndata for computing the metrics, which are strange to me:
no hvg:
(11824, 2600)
hvg:
(5000, 2600)

Should we only use the genes for testing to compute the metrics? If so, I found that I receive high low across gene correlation and high cell correlation. Does this conclusion conflict with your figure 3? Thanks a lot.

Hi HelloWorldLTY,

Yes thats a typo it should read entries are genes. Also the comment above the correlation computation only covers one use case.

So we transposed the AnnDataFrame to be genes x cells, because each gene is a training example for seq2cells, but I acknowledge this is a bit counter intuitive to start.

nohvg --> 11_824 genes and 2_600 cells
subsetting to hvg genes --> 5_000 genes and 2_600 cells
For the results in figure 3 we only used test set genes, although the data in the paper are from the HSC dataset and you are looking at the PBMC example.
We did however NOT subset genes to only highly variable genes. We trained and evaluated on all genes (after train, val, test split).
When you calculate the correlations for only the highly variable genes the values will be different to what you see in Figure 3. I believe in the hvg case for the HSC dataset we saw something similar to what you observed for the PBMC dataset:

higher across cell correlation --> relatively more variability to learn when ditching the genes that are more or less the same in all cells, and learning the variation in those later is probably hard because it's mostly noise.

lower cross gene correlation --> focussing on the hvg genes, esp. when called liberally as we did also contains many very noisy genes while you drop many genes that are readily detected, just not variable enough across cells.

For the paper we chose to stick to a single evaluation on all genes, but one could stratify the correlation over highly expressed genes, highly variable genes and also the conservativeness with which they are called.
Hope this helps

Thanks for your comprehensive answers!


feat: Upgrade pydantic to v2

Overview
Hi team,
Do you have any plans to upgrade pydantic to v2 from v1.8.2? Is there maybe any branch that I could use if such transition is happening? It becomes a problem when you want to use opentrons library in a project where packages dependencies requires pydantic v2. I couldn't find any issue that address that.
Thanks!
Implementation details
I haven't tested that, but this could be a simple fix by using v1 apis from within v2 version, see below:
from pydantic.v1 import BaseModel
There is also a helper package bump-pydantic which may help with that. Here is also a migration guide.
Design
No response
Acceptance criteria
Lift the dependency from pydantic 1.8.2 to pydantic >=2.

Yeah, we definitely want to upgrade Pydantic. (Internal reference: RSS-227)
Unfortunately we haven't started that work yet, so there's no branch you could use. We don't have a timeline for it, since we're focusing on the new Opentrons Flex.

There is also a helper package bump-pydantic which may help with that. Here is also a migration guide.

This is helpful. Thank you!

Hello @SyntaxColoring is there any proposed plan for this?
You could even use the new namespace pydantic.v1

Sorry for the lack of updates here. Yes, we're working on this in PR #14871. It's not our first priority, though, so I can't promise it will be completed soon.

Hello @SyntaxColoring, any updates on this?

Latest update: https://github.com/Opentrons/opentrons/pull/14871#issuecomment-2294227559

please please please prioritize this. Pydantic should have fixed many import perf issues. It's a major pain that we can't easily interoperate between core models in parts of our codebase.

Done in PR #14871.


confirmed:{target} doesnt work

Versions:

VueJs: 2.4.2
Vee-Validate: 2.0.0-rc.18

Description:
If I install validator like in docs, validator confirmed:some_target doesnt work. Installiation validation rules via v-validate="'target:some_target'" works fine all the time
Steps To Reproduce:
// init validation
this.validator = new Validator({
  pswd: 'required|confirmed:repeat',
  repeat: 'required|confirmed:pswd', // event without this line
});

// hml markup
<input  type="password" placeholder="password" name="pswd"
	  v-model="pswd" :class="{ 'error' : errs.has('pswd') }">
<input type="password" name="repeat" placeholder="repeat password"
	  v-model="pswdRepeat" :class="{ 'error' : errs.has('repeat') }">

error throws all the time on this.validator.validate('pswd || repeat ', this.someVariable) and this.validator.validateAll( {pswd: this.pswd, repeat: this.pswdRepeat} )

with attach() method same picture - doesnt work at all

Sadly manual targeting isn't supported yet for various reasons, please take a look at #811


S2 message decryption errors when setting config params on multiple devices

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
Changing a configuration parameter in two S2 secured devices in short succession.
What do you observe?
Frequent messages in the logs about Duplicate commands and "Message authentication failed" for about a minute, slowing down the entire z-wave network.
What did you expect to happen?
Both devices should have the config parameter update and report back to the controller.
Steps to reproduce the behavior:

Add two devices with S2 Security (in my case both are Access Control)
Set a configuration parameter on one device, then immediately set a configuration parameter on the second.
Wait about 10 seconds
The logs will be flooded for about the next minute with error messages from both nodes.

Device information
Manufacturer: Allegion/Schlage
Model name: BE469ZP
Node ID in your network: 2 and 66
How are you using node-zwave-js?

[ ] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[X] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[ ] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version:
node-zwave-js branch: 8.5.0
zwavejs2mqtt branch: <IP_ADDRESS>f1b6b
Did you change anything?
yes (please describe)
If yes, what did you change?
Upgraded both locks from S0 to S2 security
Did this work before?
Yes (please describe)
If yes, where did it work?
If both locks where at S0 security there were no issues.
Attach Driver Logfile
zwavejs_2021-10-12.log
Around 18:02:29Z you can see an example of the behavior I'm seeing. Around 18:05:05Z you can see the same exact call, but with a 10 second delay between setting the config param on node 2 and node 66.

I don't think this is related to the quick succession of the commands, might just be a coincidence.
For Node 66, the following happens:

The response comes before the acknowledgement that the request was received by the node. I'm not sure why that causes decoding the response to fail - will need to investigate.
Because the decoding failed, the driver requests a new nonce, to which the device incorrectly responds with its own nonce instead of re-transmitting the command including the nonce. This causes a bunch of weirdness, because the driver can't handle that incorrect response yet. https://github.com/zwave-js/node-zwave-js/issues/3305 tracks this.

From Node 2, the stick actually receives duplicate commands. These seem to be caused because the node sends another configuration report with Supervision encapsulation a couple of seconds after responding to the verification poll:
# poll
2021-10-12T18:02:32.094Z DRIVER » [Node 002] [REQ] [SendDataBridge]
                                  │ source node id:   1
                                  │ transmit options: 0x25
                                  │ route:            0, 0, 0, 0
                                  │ callback id:      80
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 242
                                    └─[ConfigurationCCGet]
                                        parameter #: 4
...
# response
2021-10-12T18:02:37.381Z DRIVER « [Node 002] [REQ] [BridgeApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 253
                                    └─[ConfigurationCCReport]
                                        parameter #: 4
                                        value size:  1
                                        value:       255
... pause ...
# 🤷🏻♂
2021-10-12T18:02:40.005Z SERIAL « 0x011e00a8000102159f03fe00f4f797011499061ed6580d70dcf69c2e0100c493  (32 bytes)
2021-10-12T18:02:40.012Z DRIVER « [Node 002] [REQ] [BridgeApplicationCommand]
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 254
                                    └─[SupervisionCCGet]
                                      │ session id:      22
                                      │ request updates: false
                                      └─[ConfigurationCCReport]
                                          parameter #: 4
                                          value size:  1
                                          value:       255

Then it gets impatient because it doesn't get a response within 1s, but the driver cannot respond yet, because it is waiting for a callback from the controller to the message it just sent to node 66. Notice how the serial data is exactly the same as the first one:
2021-10-12T18:02:41.158Z SERIAL « 0x011e00a8000102159f03fe00f4f797011499061ed6580d70dcf69c2e0100c493  (32 bytes)
2021-10-12T18:02:41.160Z DRIVER   Dropping message with invalid payload
2021-10-12T18:02:41.160Z DRIVER « [Node 002] [REQ] [BridgeApplicationCommand]
                                  └─[Security2CCMessageEncapsulation] [INVALID]
                                      error: Duplicate command
...
2021-10-12T18:02:41.437Z SERIAL « 0x011e00a8000102159f03fe00f4f797011499061ed6580d70dcf69c2e0100c493  (32 bytes)
2021-10-12T18:02:41.438Z DRIVER   Dropping message with invalid payload
2021-10-12T18:02:41.439Z DRIVER « [Node 002] [REQ] [BridgeApplicationCommand]
                                  └─[Security2CCMessageEncapsulation] [INVALID]
                                      error: Duplicate command
2021-10-12T18:02:41.439Z SERIAL » [ACK]                                                                   (0x06)
2021-10-12T18:02:41.469Z SERIAL « 0x011e00a8000102159f03fe00f4f797011499061ed6580d70dcf69c2e0100c493  (32 bytes)
2021-10-12T18:02:41.471Z DRIVER   Dropping message with invalid payload
2021-10-12T18:02:41.471Z DRIVER « [Node 002] [REQ] [BridgeApplicationCommand]
                                  └─[Security2CCMessageEncapsulation] [INVALID]
                                      error: Duplicate command

Part of the reason is that the ACK from Node 66 takes very long
2021-10-12T18:02:37.387Z DRIVER » [Node 066] [REQ] [SendDataBridge]
                                  │ source node id:   1
                                  │ transmit options: 0x25
                                  │ route:            0, 0, 0, 0
                                  │ callback id:      81
                                  └─[Security2CCMessageEncapsulation]
                                    │ sequence number: 144
                                    └─[SupervisionCCReport]
                                        session id:          29
                                        more updates follow: false
                                        status:              Success
                                        duration:            0s
...
2021-10-12T18:02:37.400Z DRIVER « [RES] [SendDataBridge]
                                    was sent: true
... 4 seconds later ...
2021-10-12T18:02:41.237Z DRIVER « [REQ] [SendDataBridge]
                                    callback id:     81
                                    transmit status: OK

IMO there are multiple things to be done:

You need to figure out whats blocking the nodes so long - this will need a Zniffer to identify potential routing issues
You should check the device configuration if it is possible to turn off these supervised Configuration CC Reports
I need to make the driver recover better from the incorrect responses to nonce requests
And I need to make more use of Supervision for SET commands, avoiding the verification polls.

I'm not certain if it will work, but a bit of googling should be able to tell you.

Ok, first things first - the file in errors.zip already tells a good story...
This is how communication over a hop should look like:

Node 1 wants to send a command to 56 via node 4.
Line 1: 1 -> 4
Line 2: 4 forwards to 56
Line 3: 56 sends 4 an acknowledgement
Line 4: 4 knows 56 has received the command, sends 1 an acknowledgement.
Now the response (56 -> 1 via 4) already has problems:

Line 6: 56 -> 4
Line 7-9: 4 tries 3 times to reach 1, doesn't get an ACK
Line 10: 4 tells 56 that it couldn't reach 1
Line 11: 56 tells 4 "ok, got it"
Then 56 tries again a couple of times via different routes, each with retransmission attempts, until it finally tries the direct connection:

Line 75: 56 -> 1
Line 76: 1 to 56 "got it"
Line 77: 56 -> 1
Line 78: 1 to 56 "got it"
I'm pretty sure that some of those messages did reach the controller, since you're having these duplicated commands all over your log.
At the end you can see that the missing ACKs also cause retransmission of the S2 commands.
Does not get retransmitted:

Does get retransmitted due to missing ACK:

I'm a little worried by the large amount of Routed Errors where the controller is involved (and the huge amount of CRC_ERRORs for the Zniffer, which might indicate that the Zniffer itself has interference problems).
Maybe your controller placement is suboptimal?
Z-Wave sticks in particular are prone to interference by USB ports, especially by USB3 ports. We recommend putting the stick in a suitable location:

on an USB extension cord (this works wonders!)
away from other USB ports
away from metallic surfaces
and especially not in the back of a server rack

The Zniffer should ideally be next to the controller (or next to a problematic node to see what it sees).

Okay, I moved the controller a bit, and healed the two locks a few times. I had it on an extension cable already, but I think my HVAC ducts might have been causing some interference. The routed errors are gone now, but I'm still getting the decode errors if I change config settings on both locks quickly:
aftermove.log
aftermove.zip
One of the locks also got into the state where it keeps sending the ConfigurationCCReport endlessly, but that really feels like it has to be a device issue.

FYI, part of this will be fixed in the v10 release. We now briefly remember the nonce used for the last outgoing S2 encapsulated message and attempt decryption with that first if certain criteria are met.
As a result you should no longer (or much less frequently) see the described collisions and the resulting re-synchronization weirdness.


Hotspot Name
Flaky Daisy Coyote
Hotspot b58 Address
137Yd3LiSTyUL7nnMgM5Mk1u49iAB6G5G8TqNL9eJYqr6dYiFDx
Discord Handle
No response
Hotspot Manufacturer
panther.global
Removal Reason
The hot spot has just been transferred, which is the real layout
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

Hotspot Name
Flaky Daisy Coyote
Hotspot b58 Address
11FkMDdXXtAVmkUN2F892opWVCtCnQp5ebSaVDf91NEHZuRzWRE
Discord Handle
No response
Hotspot Manufacturer
panther.global
Removal Reason
The hot spot has just been transferred, which is the real layout
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Add Allow-/Block-List for Migrate & Mirrors (#13610)

Backport #13610

@zeripath made a whole backport ... as per discord
@gary-kim ping

Thanks for the reping

:rocket:


Dragging the slider isn't smooth when thumb is small (but interactivethumb size is large)

I have a minimal slider with a small thumb size (8x8) but a 36x36 interactive thumbsize.
I have the options set to [.interactiveTrack]
I notice that a tap on the track works great, but a drag updates the track value after a second on so, without any smoothness.

Sorry, my bad. i have an overlay that's causing the issue. When I tried with the examples app, it works great.


SPIKE - OpenSearch Back-up

Description
We want to have a way to back-up/restore metadata stored in our OpenSearch instance.
Requirements

Investigate what options are available for backing-up OpenSearch

Related tickets

#53

Follow up tickets
This spike is not considered complete until at least one follow up issue is created.

[ ] Placeholder ticket

Input:
I looked into options 1 and 2, and it seems that they can occur at the same time. I do not know the difference in cost, but it could be something worth looking into if we can get the best of both worlds.
O1: This seems to be the most cost-efficient. I want to say that it can be run with cdk, or at least the CLI in AWS.  I think the flexibility and specification are great!
O2: If this backup is internal only, then O1 is the way to go. However, we could use an internal and a separate one for the manual snaps. This could get too complex if we are trying to keep it simple.
O3: This option could save $, but it is a hassle to re-index when needed. What else would OpenSearch be used for?

I think option 1 sounds like a good path forward from what you described. I doubt the maintenance would be too terrible since we shouldn't be touching it all that often. It sounds like Option 2 is newer, so if it does progress and become a better option (like CDK integration) I don't see an issue with switching over to that in the future if we want.

I just wanted to note that I reviewed what was written here and I agree that options 1 and 2 both sound good, with option 1 being slightly better.  But this is based on my very limited knowledge of OpenSearch and cdk 😅


dev.boringcrypto: 1.16.2b7 release

1.16.2 have many bug fixes and we are gating our upgrade to Go 1.16  on a dev.boringcrypto release with them.
https://github.com/golang/go/issues?q=milestone%3AGo1.16.2+label%3ACherryPickApproved
Can you give us some input on the timeline?
Thanks again for maintaining this great branch!
@katiehockman @FiloSottile

I see that Go 1.16.3 is in the works, so if the goal is to skip 1.16.2b7 and release 1.16.3b7 we're fine with that. We would love a timeline though.
https://github.com/golang/go/issues?q=milestone%3AGo1.16.3+label%3ACherryPickApproved
Thank you.

The release is now done. Sorry about the delay, we are hoping to move the process into the release process so delays will get more rare.

Thanks a lot @FiloSottile ! Our security team is very excited about the new FIPS certificate, and our developers are looking forward for the Go 1.16 improvements.


R.generated does not generate at every build since Xcode 11

Hello,
Since Xcode 11, my file R.generated it is not generated at every build. I need to delete all content in R.generated and clean my project and build to regenerate the file.
I have check the configuration and everything it's ok and it's work very well before Xcode 11.
Somebody can help me ?
Thanks

That's unfortunate, I haven't seen this issue in other projects using R.swift and Xcode 11.
Are you using the latest R.swift release (5.1)?
Which build system are you using? (Legacy or New)
Did you follow the instructions for the appropriate build system: https://github.com/mac-cain13/R.swift/blob/master/Documentation/Migration.md#upgrading-to-50

Great ! Since Xcode 11, i use legacy build and i have not seen this line :

If you are using the "Legacy Build System":
Add the flag --disable-input-output-files-validation and do not add input/output files to the Build Phase, See an example screenshot.

Thank you very much it's work now


Minor improments to 11ty

Update yarn to stable
Update other dependencies
Sort apps in .eleventy.js so they are only sorted once to save a bit of build time (thanks @robvanderleek)
Remove autogenerated CSS from the repo

closes #378

@AaronDewes something broke on CI, could you have a look please?
https://github.com/probot/probot.github.io/runs/3233418334?check_suite_focus=true

Sorry, fixed it.


Correctly publish StaticFinancials collection

I did this (just using default data) when trying to use the Collection in the Dashboard page.


0.16.22 compatibility issue

When clicking the Todo List button at top left:
Key "column_count" not found in property tree at ROOT
stack traceback:
	__Todo-List__/UI.lua:52: in function 'create_task_table'
	__Todo-List__/UI.lua:22: in function 'create_maximized_frame'
	__Todo-List__/todo.lua:45: in function 'maximize'
	__Todo-List__/todo.lua:187: in function 'on_gui_click'
	__Todo-List__/control.lua:18: in function <__Todo-List__/control.lua:17>```

Hi,
thanks for the report. It is already fixed in the bugfix branch and I'm planning on releasing the new version hopefully this weekend, maybe earlier.
If you don't want to wait this long you can open the UI.lua in your local installation, navigate to line 52 and replace the "colspan" with "column_count". Everything should work as expected afterwards.

A new version has been released. Thanks again for the bugreport. If anything pops up in the future I would be thankful for another issue here :)
Have fun and happy building.

Hooray! Thanks so much for the prompt fix! I'm really excited to add this to my server's modpack.


How to implement a macos app prompt password to launch it with admin privilege?

On MacOS I still don't find a better solution to implement this requirement.
Now I use the flutter framework to develop app GUI and the GUI will load library in Rust, this library need some privilege as service to listen port.
I can load library use sudo on terminal, but don't load the libray by GUI. It will cause "permission error(13 'permission denied')" .
any suggestion is very appreciated.

I can load library use sudo on terminal, but don't load the libray by GUI. It will cause "permission error(13 'permission denied')" .

@irocn Does this mean the app prompt password / permission is being triggered only through terminal but not by macos app itself and you are expecting that the macos app should be asking / prompting for the password ?

Ok, see if this issue relates to your use case or not.
If not, can you provide steps to replicate along with complete error to analyze this further ?

the macos app itself can prompt for the password to hold the admin/root privilege to launch itself like sudo on terminal.

An application on macOS cannot control its own launch permissions. This is not related to Flutter, that's just not how macOS works.
If you want special permissions you need to launch an authorized subprocess, using native code. This could be fine directly in your application, or you could build a plugin for that use case.
Closing as authorized sub-agents are out of scope for Flutter itself.


Destroy scene in specs

Any time a scene is created in the specs, it should be destroyed at the end

Thanks for the pull request @hpinkos!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Works just as expected. Thanks @hpinkos!


Exclude ManagedBeanTypesTest

Fixes #485

I'm only submitting this to the 4.0 branch, because the test in fixed on master (which will be 4.1).


improvement in compatibility with windows

improvement in compatibility with windows, especially in the flash process and other work with directories.

I am working on it. There is always something new.


fix: Allow to use the COMPOSE_FILE variable in finch compose

nerdctl allows us to launch containers using a Docker Compose file specified in the COMPOSE_FILE environment variable.
For example, suppose we have created the following Docker Compose file.
> cat a.yaml
services:
  test:
    image: amazonlinux:2023

By specifying this Docker Compose file in the COMPOSE_FILE environment variable and running nerdctl compose up, we can start the container.
> sudo COMPOSE_FILE=a.yaml _output/nerdctl compose up
INFO[0000] Ensuring image amazonlinux:2023
INFO[0000] Re-creating container nerdctl-test-1
INFO[0000] Attaching to logs
INFO[0000] Container "nerdctl-test-1" exited
INFO[0000] All the containers have exited
INFO[0000] Stopping containers (forcibly)
INFO[0000] Stopping container nerdctl-test-1

However, since the COMPOSE_FILE environment variable is not passed in finch compose, the following error occurs.
> COMPOSE_FILE=a.yaml finch compose up
FATA[0000] no configuration file provided: not found
FATA[0000] exit status 1

And this bug is reported in the following issue.

https://github.com/runfinch/finch/issues/347

Therefore, this fix allows the finch compose command to use the Docker Compose file specified in the COMPOSE_FILE environment variable.
Issue #, if available: #347
Description of changes: The details are described in this commit message.
Testing done: Yes

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

A test of the finch compose command using the COMPOSE_FILE environment variable will be added to the common-tests repository.

Added an e2e test for finch compose command with Docker Compose file specified in COMPOSE_FILE.

https://github.com/runfinch/common-tests/pull/172

CI in windows-e2e-tests is failing.

https://github.com/runfinch/finch/actions/runs/9634987119/job/26581295031?pr=994

The error messages are as follows.
Details

------------------------------
 Additional disk Retains container user data after the VM is deleted
C:/actions-runner/_work/finch/finch/e2e/vm/additional_disk_test.go:25
  time="2024-06-24T04:00:16Z" level=debug msg="Creating limactl command: ARGUMENTS: [stop --force finch], LIMA_HOME: C:\\actions-runner\\_work\\finch\\finch\\_output\\lima\\data"
  time="2024-06-24T04:00:16Z" level=info msg="Forcibly stopping Finch virtual machine..."
  time="2024-06-24T04:00:16Z" level=debug msg="running detach cmd: C:\\Program Files\\WSL\\wsl.exe --unmount \\\\?\\C:\\Users\\Administrator\\AppData\\Local\\.finch\\.disks\\1bdf7778552c21f8.vhdx"
  time="2024-06-24T04:00:16Z" level=info msg="Finch virtual machine stopped successfully"
  time="2024-06-24T04:00:17Z" level=debug msg="running detach cmd: C:\\Program Files\\WSL\\wsl.exe --unmount \\\\?\\C:\\Users\\Administrator\\AppData\\Local\\.finch\\.disks\\1bdf7778552c21f8.vhdx"
  time="2024-06-24T04:00:17Z" level=debug msg="Creating limactl command: ARGUMENTS: [remove --force finch], LIMA_HOME: C:\\actions-runner\\_work\\finch\\finch\\_output\\lima\\data"
  time="2024-06-24T04:00:17Z" level=info msg="Forcibly removing Finch virtual machine..."
  time="2024-06-24T04:00:18Z" level=info msg="Finch virtual machine removed successfully"
panic: test timed out after 2h0m0s
running tests:
	TestVM (2h0m0s)

goroutine 85 [running]:
testing.(*M).startAlarm.func1()
	C:/Program Files/Go/src/testing/testing.go:2366 +0x385
created by time.goFunc
	C:/Program Files/Go/src/time/sleep.go:177 +0x2d

goroutine 1 [chan receive, 119 minutes]:
testing.(*T).Run(0xc00018dba0, {0x11c9727?, 0xc01b468244?}, 0x1213a70)
	C:/Program Files/Go/src/testing/testing.go:1750 +0x3ab
testing.runTests.func1(0xc00018dba0)
	C:/Program Files/Go/src/testing/testing.go:2161 +0x37
testing.tRunner(0xc00018dba0, 0xc0000f3c70)
	C:/Program Files/Go/src/testing/testing.go:1689 +0xfb
testing.runTests(0xc0000085a0, {0x169db40, 0x1, 0x1}, {0x1?, 0xced493?, 0x16d4680?})
	C:/Program Files/Go/src/testing/testing.go:2159 +0x445
testing.(*M).Run(0xc000256640)
	C:/Program Files/Go/src/testing/testing.go:2027 +0x68b
main.main()
	_testmain.go:47 +0x16c

goroutine 6 [runnable]:
context.WithDeadlineCause({0x12babd0, 0x175cf20}, {0x66790b3b?, 0x2057cbbc?, 0x16d4680?}, {0x0, 0x0})
	C:/Program Files/Go/src/context/context.go:642 +0x268
context.WithDeadline(...)
	C:/Program Files/Go/src/context/context.go:612
golang.org/x/net/context.WithDeadline({0x12babd0?, 0x175cf20?}, {0x16d4680?, 0x12a05f200?, 0x16d4680?})
	C:/Users/Administrator/go/pkg/mod/golang.org/x/net@v0.26.0/context/go17.go:47 +0x29
golang.org/x/net/context.WithTimeout({0x12babd0, 0x175cf20}, 0x12a05f200)
	C:/Users/Administrator/go/pkg/mod/golang.org/x/net@v0.26.0/context/go17.go:62 +0x47
github.com/onsi/ginkgo/v2/internal.(*Suite).generateProgressReport(_, _)
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:373 +0x15d
github.com/onsi/ginkgo/v2/internal.(*Suite).runNode(_, {0x16, 0x4, {0x11e9df4, 0x33}, 0xc000270880, {{0x136d407, 0x42}, 0x19, {0x0, ...}, ...}, ...}, ...)
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:959 +0x119f
github.com/onsi/ginkgo/v2/internal.(*group).attemptSpec(0xc0002c9130, 0x1, {{0xc00029a008?, 0xc00049a000?, 0x2?}, 0x0?})
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/group.go:199 +0xc33
github.com/onsi/ginkgo/v2/internal.(*group).run(0xc0002c9130, {0xc00040c060?, 0x0?, 0x0?})
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/group.go:349 +0x925
github.com/onsi/ginkgo/v2/internal.(*Suite).runSpecs(0xc0000d1508, {0x11dc329, 0x1f}, {0x175cf20, 0x0, 0x0}, {0xc00001f530, 0x2a}, 0x0, {0xc0002ae008, ...})
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:489 +0xac5
github.com/onsi/ginkgo/v2/internal.(*Suite).Run(_, {_, _}, {_, _, _}, {_, _}, _, {0x12be4d0, ...}, ...)
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:130 +0x405
github.com/onsi/ginkgo/v2.RunSpecs({0x12b6600, 0xc00018dd40}, {0x11dc329, 0x1f}, {0x0, 0x0, 0x0})
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/core_dsl.go:300 +0x8b3
github.com/runfinch/finch/e2e/vm.TestVM(0xc00018dd40)
	C:/actions-runner/_work/finch/finch/e2e/vm/vm_windows_test.go:55 +0x1ca
testing.tRunner(0xc00018dd40, 0x1213a70)
	C:/Program Files/Go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	C:/Program Files/Go/src/testing/testing.go:1742 +0x390

goroutine 7 [syscall, 119 minutes]:
os/signal.signal_recv()
	C:/Program Files/Go/src/runtime/sigqueue.go:152 +0x29
os/signal.loop()
	C:/Program Files/Go/src/os/signal/signal_unix.go:23 +0x13
created by os/signal.Notify.func1.1 in goroutine 6
	C:/Program Files/Go/src/os/signal/signal.go:151 +0x1f

goroutine 8 [select, 119 minutes]:
github.com/onsi/ginkgo/v2/internal/interrupt_handler.(*InterruptHandler).registerForInterrupts.func2(0x0?)
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/interrupt_handler/interrupt_handler.go:131 +0x7d
created by github.com/onsi/ginkgo/v2/internal/interrupt_handler.(*InterruptHandler).registerForInterrupts in goroutine 6
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/interrupt_handler/interrupt_handler.go:128 +0x165

goroutine 9 [select, 119 minutes]:
github.com/onsi/ginkgo/v2/internal.RegisterForProgressSignal.func1()
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/progress_report.go:32 +0x8b
created by github.com/onsi/ginkgo/v2/internal.RegisterForProgressSignal in goroutine 6
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/progress_report.go:30 +0xd9

goroutine 98 [syscall, 119 minutes, locked to thread]:
syscall.SyscallN(0x7ff98b573bf0?, {0xc000423a48?, 0x3?, 0x0?})
	C:/Program Files/Go/src/runtime/syscall_windows.go:544 +0x107
syscall.Syscall(0x3?, 0x3?, 0xc00040ea60?, 0x0?, 0x0?)
	C:/Program Files/Go/src/runtime/syscall_windows.go:482 +0x35
syscall.WaitForSingleObject(0x304, 0xffffffff)
	C:/Program Files/Go/src/syscall/zsyscall_windows.go:1142 +0x5d
os.(*Process).wait(0xc000339980)
	C:/Program Files/Go/src/os/exec_windows.go:18 +0x50
os.(*Process).Wait(...)
	C:/Program Files/Go/src/os/exec.go:134
os/exec.(*Cmd).Wait(0xc0001e6420)
	C:/Program Files/Go/src/os/exec/exec.go:897 +0x45
os/exec.(*Cmd).Run(0xc0001e6420)
	C:/Program Files/Go/src/os/exec/exec.go:607 +0x2d
github.com/runfinch/finch/e2e/vm.init.func6(0xc00024d1d0)
	C:/actions-runner/_work/finch/finch/e2e/vm/vm_test.go:32 +0x2f9
github.com/runfinch/finch/e2e/vm.init.func8.1.1()
	C:/actions-runner/_work/finch/finch/e2e/vm/additional_disk_test.go:26 +0x3a
github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x0?, 0x0?})
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/node.go:472 +0x13
github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:894 +0x8d
created by github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 6
	C:/Users/Administrator/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.19.0/internal/suite.go:881 +0xdb0
FAIL	github.com/runfinch/finch/e2e/vm	7200.073s
FAIL
make: *** [test-e2e-vm-serial] Error 1
Error: Process completed with exit code 1.
##[debug]Finishing: Run e2e tests

CI is failing due to the following logic not completing successfully, possibly Flaky Test.

https://github.com/runfinch/finch/blob/main/e2e/vm/vm_test.go#L28C1-L33C3

This may be related to the draft that austinvazquez is creating.

https://github.com/runfinch/finch/pull/993

However, the root cause of this CI failure is not clear at this time.
I would appreciate any guidance from other maintainers regarding appropriate approaches to addressing this matter.

@haytok Can you bump common-tests to v0.7.23 in this PR?

Sure, i'll update go.mod and go.sum.

https://github.com/runfinch/finch/blob/main/go.mod#L16
https://github.com/runfinch/finch/blob/main/go.sum

Thanks for checking!!!, @pendo324
I bumped common-tests to v0.7.23.

Thanks, the change looks good to merge after the new test passes

Looks like the new test failed on Windows

I'll check the root cause of the failure.

I will demonstrate the results of the operational verification conducted in the Windows environment.
Details

Set COMPOSE_FILE env var
~
$env:COMPOSE_FILE = "a.yaml"

Check env var
~
Get-ChildItem env:

Name                           Value
----                           -----
...
COMPOSE_FILE                   a.yaml
...

Execute finch compose up
~
 .\_output\bin\finch.exe compose up
INFO[0000] Creating network finch_default
INFO[0000] Ensuring image busybox
...
INFO[0000] Creating container finch-echo_env-1
INFO[0000] Attaching to logs
echo_env-1 |PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
echo_env-1 |DEFAULT=1
echo_env-1 |HOME=/root
INFO[0000] Container "finch-echo_env-1" exited
INFO[0000] All the containers have exited
INFO[0000] Stopping containers (forcibly)
INFO[0000] Stopping container finch-echo_env-1

It was possible to execute the "finch compose up" command using the Docker Compose file (a.yaml) specified with the COMPOSE_FILE variable.
Therefore, I will proceed to investigate the tests in the Windows environment.

There seemed to be an error because the process to convert the file path specified by the environment variable in the e2e test to a path in WSL was not performed.

https://github.com/runfinch/finch/blob/main/cmd/finch/nerdctl_windows.go#L18C1-L32C2

I'll think about how to resolve it.

I found out why the test is failing.
The path to the file specified in COMPOSE_FILE in Windows environment needs to be converted to a WSL path.
So, the following patch is needed.
Details

> git diff .\cmd\finch\nerdctl.go
diff --git a/cmd/finch/nerdctl.go b/cmd/finch/nerdctl.go
index f363171..820ef70 100644
--- a/cmd/finch/nerdctl.go
+++ b/cmd/finch/nerdctl.go
@@ -234,13 +234,17 @@ func (nc *nerdctlCommand) run(cmdName string, args []string) error {

        passedEnvs := []string{
                "COSIGN_PASSWORD", "AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY",
-               "AWS_SESSION_TOKEN",
+               "AWS_SESSION_TOKEN", "COMPOSE_FILE",
        }

        var passedEnvArgs []string
        for _, e := range passedEnvs {
                v, b := nc.systemDeps.LookupEnv(e)
                if b {
+                       if e == "COMPOSE_FILE" {
+                               path, _ := convertToWSLPath(nc.systemDeps, v)
+                               v = path
+                       }
                        passedEnvArgs = append(passedEnvArgs, fmt.Sprintf("%s=%s", e, v))

Test locally on windows and darwin and then create the commit again.

Hi @haytok, I merged #993 to workaround the Windows CI WSL hanging issue. If you get a chance to rebase your branch that should resolve the Windows test-e2e-vm-serial issue for you.

@austinvazquez Thank you for fixing the CI and shareing the Info!!!
I will rebase and make an additional commit!

Hi, @pendo324
Fix the code, rebase and push. All tests passed, so could please review when you have time?

LGTM, thanks!

Thanks for approving!!!
I have hecked PR again and found no problem, so merge.


[BUG] items not showing in crucibles

when making custom blocks to lava/liquid amounts, if amount of liquid is over 1000mb per item, the item shows up blank in NEI

Could you upload your json file so I can use it for testing.

heres an example
Working
"minecraft:snow": {
"fluid": "cryotheum",
"amount": 1000
},
Not Working
"minecraft:snow": {
"fluid": "cryotheum",
"amount": 4000
},

Fix merged.


Animation call method track not being called in inherited scene

Tested versions
v4.2.1.stable.official [b09f793f5]
System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Forward+)
Issue description
When inherited gltf animated model to a scene, the call function in animation player not called.
Steps to reproduce
Inherit an animated gltf/glb format to a scene.
Edit the animation player and add a function call track in one animation
play the animation. the function can not be called.
Minimal reproduction project (MRP)
call_func_in_anim.zip

Good day,
You need to reimport the asset with the animation "idle" set to these properties:

Any path will do.
Writing down any custom tracks to an animation belonging to an inherited scene will not be saved as stated here when you view the animation before adding a new track to call a method:

And reload the project just in case however and it will call the method just fine:
87403_call_func_in_anim.zip

Bumping as I'm also seeing this issue. It seems to work fine in a simple scene, but upon changing some parameters / moving nodes around, moving a branch into its own scene and instantiating it as a child scene, etc., call method tracks seem to completely stop working. Tested in stable 4.3, attaching a reproduction project.
call_method_track_test.zip
Play this project, click to activate the "jump" animation which has a call method track to print "1 2 3 4" to the terminal as the animation plays. This worked on first creation of the project, but after making some changes and trying again it all of a sudden no longer works. I'm seeing this behavior on a large project that I'm working on as well. On that project (which has many layers of child scenes as my animation controller is a component used inside both my player and enemy scenes), the call methods tracks on my animations completely refuse to work.


Use Codecov Github Actions instead

https://github.com/codecov/codecov-action

Codecov Report

Merging #36 (a928ead) into main (5654ab1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   98.57%   98.57%
=======================================
  Files          65       65
  Lines         492      492
  Branches       30       30
=======================================
  Hits          485      485
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5654ab1...a928ead. Read the comment docs.