UfsJournal ignores unrecognized journal entries

Alluxio Version:
2.1.0-SNAPSHOT
Describe the bug
An unrecognized journal entry is simply ignored.
To Reproduce

Write a journal entry newly added in v2.x
Read journal from v2.y < v2.x
Master starts up successfully

Expected behavior
Master should crash with IllegalStateException as a journal entry was unrecognized
Urgency
Medium, this an an early detection of journal compatibility
Additional context
EmbeddedJournal calls JournalAssociation and will throw an IllegalStateException whereas UfsJournal does not

UfsJournal did/does not need the JournalAssociation method, since each master reads its own journal files, so all those entries are known to belong to the that specific master.

https://github.com/Alluxio/alluxio/blob/master/core/server/common/src/main/java/alluxio/master/journal/ufs/UfsJournalCheckpointThread.java#L178 ignores the return value, which should signify if the master recognizes the entry or not.


Fix type spec of Mailer.deliver_later/1

After updating to 2.0.0, my dialyzer fails with a message like this:
lib/my_app/mailer/mailgun.ex:17:invalid_contract
The @spec for the function does not match the success typing of the function.

Function:
MyApp.Mailer.Mailgun.BambooMailer.deliver_later/1

Success typing:
@spec deliver_later(_) ::
  {:error,
   <<_::64, _::size(8)>>
   | %{
       :__exception__ => true,
       :__struct__ => Bamboo.EmptyFromAddressError | Bamboo.NilRecipientsError,
       :message => <<_::64, _::size(8)>>
     }}
  | {:ok,
     %{
       :bcc => {binary(), binary()},
       :cc => {binary(), binary()},
       :from => {binary(), binary()},
       :to => {binary(), binary()},
       _ => _
     }}

________________________________________________________________________________
done (warnings were emitted)

This PR fixes that spec error.

Note that this is not part of https://github.com/thoughtbot/bamboo/pull/583, since it seems that the generated functions inside __using__ are not dialyzed in that PR.

Good catch! Thanks for opening this PR and thanks for the little note disambiguating from #583. Those kinds of notes are so helpful. 🎉


Browser Web Developer Tool not showing the events in the EventStream tab

While I do receive the Server-Side events and the eventListeners pick them up, when I look for those events in the different browsers' (Chrome, Firefox) Web Developer Tools, the EventStream tab does not show them.
This is not a critical thing, but it would be useful for troubleshooting to be able to see these in the web developer tools.
See an example below:

It seems this is not a new issue:
https://stackoverflow.com/questions/55201372/event-stream-data-not-showing-in-chrome-console


packet loss is not shown on graphs

My graphs consistently show loss 0 / 0 but concurrent ping and mtr invocations on the same machine show 10-15% packet loss.  Is this a bug or is my config wrong?  My plugins section looks like this:
plugins:
  - name: std_fping
    type: fping
    count: 10
    interval: 3s
    output:
      - vodka

  - name: vodka
    type: vodka
    logging:
      version: 1
      formatters:
        simple:
          format: '%(asctime)s - %(name)s - %(levelname)s: %(message)s'
      handlers:
        console:
          class: logging.StreamHandler
          level: DEBUG
          formatter: simple
          stream: ext://sys.stdout
      loggers:
        vodka:
          level: DEBUG
          handlers:
            - console

    data:
      - type: fping
        handlers:
          - type: index
            index: host
          - type: store
            container: list
            limit: 500

    apps:
      graphsrv:
        tmpl_engine: jinja2
        enabled: true
        graphs:
          multitarget:
            id_field: host
            type: multitarget
            plot_y: avg
            format_y: ms

          smokestack:
            id_field: host
            type: smokestack
            plot_y: avg

    plugins:

      - name: http
        type: flask
        host: <IP_ADDRESS>
        port: 7021
        debug: true
        static_url_path: /static
        server: self
        async: thread
        routes:
          /targets : graphsrv->targets
          /graph_data :
            methods:
              - POST
              - GET
            target: graphsrv->graph_data
          /graph : graphsrv->graph_view
          /overview_read_file : graphsrv->overview_read_file
          /: graphsrv->overview_view

This is an issue with graphsrv, made a corresponding ticket here: https://github.com/20c/graphsrv/issues/13, thanks for the report

fixed in graphsrv 1.1.1

Thanks! Have upgraded and restarted and now looking forward to seeing some non-zero counters :-)


HOW-TO configure Idol FIND for displaying %-relevance and database-name

HOW-TO configure Idol FIND for displaying %-relevance and database-name in the List-of-results?
Is there a 'config-way' ?

If you're just using configs; you can configure custom templates to configure the fields, which will work for database name. However, it doesn't currently support % relevance. If you have the Find Admin guide, it'll be in the 'Configure Templates in Find' part of the documentation.
If you're willing to change the code, you can use something like this:
https://github.com/microfocus-idol/find/commits/example/database-and-weight
which will show the database and the score next to it.

I'll add the % relevance (aka weight) option to the template renderer for the next release so it won't need custom code in future.


Renamed branch to main in links in README

I renamed branch to main in links that are pointing to the .md files with docs inside the repo. The links were working but with "redirected to default branch" message, and I think this way it is cleaner :)

Thank you 👍


Robotium with Android Studio

I try to move our tests from eclipse to android studio. I Just have the APK, do not have the source code.
I Just want to mannually installed my app and run tests.
I know can launch my app in eclipse with the setting in AndroidManifest.xml

So what should I do in Android Studio?
Such as setting in build.gradle
defaultConfig {
minSdkVersion 16
targetSdkVersion 23
versionCode 1
versionName "1.0"
testApplicationId "com.xx.autotest.myApp"
testInstrumentationRunner "android.test.InstrumentationTestRunner"
testHandleProfiling true
testFunctionalTest true
}
And anything else?
Thanks in advance.

I have the same question。。。。

I have the same question。。。。


Add support for other platforms

Currently, the application run on windows only. We could build the server for mac & linux aswell.

We should change the CI to build the application on linux & mac, in the meantime, the extension is now using the WASI version of the server on unsupported OS, so it should be working on Linux & Mac aswell.


⚠ Spryr has degraded performance

In eb7ac92, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 503
Response time: 4874 ms

Resolved: Spryr performance has improved in b57a999 after 12 minutes.


Release with gh instead of with hub

Uses gh (GitHub CLI) instead of hub to make the release
Generates release notes on the server instead of locally

/cc @eregon @hsbt

I see. Thanks ❤


⚠ Text Filter API Endpoint has degraded performance

In 7306ad1, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 25668 ms

Resolved: Text Filter API Endpoint performance has improved in bd844d2.


Remote directives execution optimization

This PR contains multiple code cleanup as suggested by IDE (mostly about final fields, unused methods/classes, and logic simplification).
The following optimizations related to remote directives execution are made:

Fixed the logic in UserDirectiveRegistry to avoid creating multiple classloaders of the same artifact.
Avoid calling DirectiveRegistry.reload inside the remote task. This is achieved by:

Gather information about system directives before submitting to the remote task.
Load the system directive class directly, instead of using reflection to query for all available system directives in the task (i.e. avoid creating SystemDirectiveRegistry in the task).
Any non system directives are considered as UDD, and they are loaded directly via the plugin manager API, instead of looping through all artifacts at the beginning (e.g. avoid calling UserDirectiveRegistry.reload in the task).

Avoid task executor to restart if no UDD was executed

In the process, also fixed a bug about the #pragma directive is not added when UDD is used.
With all these changes, the wrangler RemoteExecutionTask execution time was reduced from 2 seconds to 200ms (in a hot container).

This PR needs a new API introduced in https://github.com/cdapio/cdap/pull/13604


Change Request: READMEs could provide how to deploy resources

This is a question that might lead into a recommendation to update the README template: https://github.com/Azure/azure-sdk/blob/master/docs/policies/README-TEMPLATE.md though some other changes could end up being necessary.
READMEs could provide how to deploy resources
Users of the Azure SDKs could encounter issues while trying to run our samples or live tests, since they might require specific configurations to run. Our readmes could have additional indications around how to deploy the required resources.
In this issue, I will describe the history behind this request, and the possible solutions. For each solution, I will include the pros and cons that I personally can think of while writing this issue.
Background
While developing the Azure SDK for JavaScript and TypeScript, our team was encountering an issue regarding how to properly express how to deploy the exact resources needed to run our live tests. We started going through what other teams had been using, and we spotted that the Service Bus SDK for .Net had a Deploy Button in their README:

We also discovered their use of ARM templates. This started a multi-month effort of bringing ARM templates to our projects. Nowadays, most (if not all) of our SDKs make heavy use of ARM templates for the automation of test resources.
Having these templates at hand, it seemed natural to continue to use these Deploy Buttons. They currently can be seen in some of the READMEs of the Azure SDK for JavaScript/TypeScript. Here's one example from the KeyVault Certificates' readme: https://github.com/Azure/azure-sdk-for-js/blob/2afdad15f4b2d6ffc449ed6e245e0389c428b64a/sdk/keyvault/keyvault-certificates/README.md#getting-started
In parallel, the Engineering Team has been working with different members of our team at large to continue improving on the test tooling, and now these tools are more approachable and can be used more easily by anyone who wants to build their test resources.
Currently, the TS/JS team has halted the adoption of the Deploy Button and has started the conversation to move towards the PowerShell Tooling.
General requirements
If we decide to expand our READMEs to include information on how to deploy resources, this information must at least clearly state:

How to deploy TEST resources.
How to deploy SAMPLES resources.
What resources will be deployed in each case.

Keep in mind that these indications could be in either the main README of a project, or in READMEs located at the samples folder, or at the test folder. At first glance it seems reasonable to suggest that this is better explained in the individual folders.
Possible solutions
Deploy Button
The Deploy Button is a simple image that links to an Azure endpoint that generates a form based on an ARM template. The Markdown source code is as follows:
[![](http://azuredeploy.net/deploybutton.png)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fazure-sdk-for-js%2Fmaster%2Fsdk%2Fkeyvault%2Ftest-resources.json)

The image ![](http://azuredeploy.net/deploybutton.png) is linked to the Azure endpoint https://portal.azure.com/#create/Microsoft.Template/uri/, to which we pass at the end the URL encoded path of an ARM template. In that case: https://github.com/Azure/azure-sdk-for-js/blob/2afdad15f4b2d6ffc449ed6e245e0389c428b64a/sdk/keyvault/test-resources.json
Pros and cons of the Deploy Button
Pros:

It is a visible element on our READMEs that could be interpreted as a call to action.
A button and a web form might be easier to work with for a greater population, in comparison to PowerShell.
The button goes to an auto-generated form, and the ARM template used can re-use some of the contents of the ARM template used for live tests, so some of the work up-front, and perhaps even maintenance work, can be saved.

Cons:

This approach requires ARM template knowledge for developers.
Requires writing, testing and maintaining several ARM templates.
The automatic generation of the form might not be intuitive depending on how the ARM template is written.
The number of resources generated is hidden from plain sight for users unaware of how this deployment happens. People might end up purchasing undesired resources.
The READMEs might end up needing indications on how to fill these forms, and what resources are being purchased.

PowerShell Tooling
In the process of improving the Engineering Automation of the test resources, our teams have made our Test tools more approachable. We currently have a guide and examples of how to use these tools to deploy test resources. Something similar could be used for both tests and samples.

The current guide on Integration Testing with live services for JS/TS.
Examples of using the test tooling to generate resources based on ARM templates: https://github.com/Azure/azure-sdk-for-js/blob/master/eng/common/TestResources/New-TestResources.ps1.md#example-1
A PR to the JS/TS repository which we've doing in parallel to this issue, in which we are changing from the Deploy Buttons to the already documented and properly working Test tools, only for test resources though: https://github.com/Azure/azure-sdk-for-js/pull/8398/files

Pros and cons of the PowerShell Tooling
Pros:

These tools already exist in the majority of our SDKs (if not in every SDK).
Documentation for these tools already exist.
New specific ARM templates, one for test and one for samples, can be made from existing ARM templates, and they will be instantly compatible with the existing documentation.
Minimal new documentation would need to be added to the samples README and the test README.
Any improvement to these tools can be carried on to every other SDK we have with minimal effort.
Most of our engineers can work well with PowerShell.

Cons:

Requiring powershell might be a barrier to some of our users, even if small.
This approach requires some level of maintenance to new ARM templates and small sections in many READMEs.

Tutorial
Another approach would be to provide a step by step tutorial on how to deploy the necessary resources for both tests and samples.
Some of our packages currently employ a minimal tutorial showing how to deploy the most minimal resource that they are targeting. An example can be seen in the TS/JS @azure/search-documents README: https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/search/search-documents#prerequisites
Pros and cons of the Tutorial
Pros:

A tutorial is a more human to human approach of guiding contributors to participate in our projects.
The tutorial can start with the most minimal setup for tests and samples, and then link to more advanced settings from existing documentation outside of our projects.
Potentially requires no knowledge of ARM templates or PowerShell. The Azure CLI is likely sufficient.
The resources being deployed will be clearly stated as part of the tutorial. There will be no abstracted out procedures or configurations (besides the intrinsic behavior of the Azure CLI).

Cons:

Test and samples tutorial might take some time to be properly written.
A template tutorial, and a sample tutorial, should probably be made to show what are the expectations for these documents.

Closing statement
Deploying resources are a key part of running tests and samples. The fact that each project has been approaching the related documentation slightly differently most likely means that we're getting ready to work together on some standard to include as part of the general guidelines, so that future work can minimize variations, and potentially maximize the possibilities of seeing contributions from users at every level of knowledge, as well as increasing the incentives to try and purchase Azure resources.

This is a good use of these files, though we may need to consider how the user supplies inputs required by the scripts I wrote that process test-resources.json for both CIs and dev workflows. It definitely centralizes and unifies resource deployment across languages.

I'd make the distinction between audiences, personally.   We should be providing a lightweight and free-standing template for customers wishing to explore the library and create applications.   I see this as part of our "getting started" area where customers can quickly use these to create a minimal set of resources to play with snippets and use with samples.
I'd avoid trying to keep things at this level for contributors who which to compile the library and run tests; the test resources are typically heavier and have deeper ties to the ambient environment (CI, developer setup) which would make using the simple button rather difficult.    I'd love to see us have a full "F5" experience where contributors could run a setup script or get a plug-in for their development environment that helps make running tests using the "per-run" test resources seamless as well - but I see the two efforts as independent.

//cc: @czubair, for visibility as our documentation owner.

All of the things described here are definitely of benefit to customers - but I'm not entirely sure that they are entirely appropriate to the readme itself.
Our user studies consistently show that users don't read almost any text on documentation, instead scrolling directly to code samples. The consistent ask of customers is for quick snippets of code that help them get done what they are doing. The normal case for customers is that they already have Azure resources deployed, and they are looking to quickly interact with existing resources used in existing projects.
We are working on a re-work of the developer hub documentation - these are the language-level pages linked from here: https://docs.microsoft.com/en-us/azure/developer/
Information about how to best test with the SDK is already on the roadmap for that rework - perhaps this would be more appropriate in that content?

Here's a new issue emphasizing only the main README template: https://github.com/Azure/azure-sdk/issues/1248
Please let me know if this new issue is better! I can make sure to improve it to properly present the issue I'm trying to express.
While the main README of a package can express how to deploy the most basic version of the resource that the package is managing, other users might want to run samples and tests. This problem then also occurs in those readmes, and even if the solution could be similar in nature, the configurations and implications will be for sure different.
@maggiepint what you mention about the roadmap of the test docs rework, that sounds good to me!
Please help me: How can I bring up issues about those other readmes?
Thank you for your time.

I have updated the title and the first paragraphs to more accurately mention that this issue is not specifically about the main README of each package.

@jsquire that's what these test-resources.json files facilitate. Right now, they require a separate invocation but are otherwise uniform in how they are used (all by running eng/common/TestResources/New-TestResources.ps1 - both for CI and devs). But this is for the README experience, not CONTRIBUTING (which should mention these steps). The same file can be used to proffer resources customers need and will do so in a manner consistent with CI and dev environments, which - because we should be compiling and running samples that use those resources - we know will work. So we have validation built-in as well.

Getting to just an F5 experience is still on the backlog. Other things have been priority, but having a simple step prior to that to prepare things is still simpler than what many OSS repos (including in Microsoft) have you do. Still seems like a win, and we can evolve it over time.


Undo fix

Fixes lua error that occurs when undoing while pasting.

Damnit git, I didn't want those other commits in this pr.

Fixed it with a rebase

There error is caused by this https://github.com/garrynewman/garrysmod/blob/ead2b4d7f05681e577935fef657d4a4d962091e6/garrysmod/lua/includes/modules/undo.lua#L369

Good catch. Presumably Player.AdvDupe2.Name isn't allowed any quotation marks in it?

Merge soon?

uhh yeah how did that even cause an error in the first place

@Divran the custom undo text is eventually sent via Player:SendLua, and so if it contains quotation marks then the Lua is invalid.

Somebody should check that Player.AdvDupe2.Name can't have quotation marks in it, but this itself is a sensible change to merge.


Ability to customized look

Just being able to specify a CSS class for the various elements would be enough.
Or is it possible already to customize look?

Hi, @bolerio
No, if you install it by NPM, you can't customize any design on this version. But! Maybe you can download this file and change style sheet to customize design.

I am closing this issue. If you still have problem, reopen the issue.

Hi @bolerio, I am added styling features for v1.1.5.
https://github.com/linmasahiro/vue3-table-lite/blob/master/src/examples/CustomizeStyle.vue

Hi,
Thanks to class, we can style and add custom css
But my problem is the opposite:
When using your component into existing styled project (for example, where bootstrap is used), your embeded css will override default template css.
I would be great to be able to leave embeded css away
Thanks

Hi, @PCes83
I used <style scope> tag to styling my component, because I not hope override it from outside style.
If you need override the embedded style, you can use ::v-deep to override it. Please reference this.
※ If you want styling header/column only, I already added new options to styling they, ref this issue


Getting: Warning: You are manually calling a React.PropTypes validation function for the minW prop on GridItem.

Getting these warnings using React 15.3.0
also for maxW, minH, maxH

This was fixed in the latest release.


Harshal0902/GOSW6

Issue Number 6
ISSUE #

Describe the changes you've made
Added a map showing location of Student Chapter. Please enter your own Google Map API to view the map.
Describe if there is any unusual behavior of your code(Write NA if there isn't)
No
Additional context (OPTIONAL)

Test plan (OPTIONAL)
NA
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Please tell me if any change recquired.

@pixan198 Can you please review this.

Hey @Harshal0902
Sorry for the delay
Problems in your code:

Your build is failing please see that

I think it is because you've not updated your package.json file, please see that

You've changed the App.js file you've to never do that unless told to do so

Changes you've to make:

Make a component for the map inside the components folder
Put your code inside in a file
Revert all the changes you've made to the App.js file

@pixan198 done, Can you please review it.

Hey @Harshal0902 there are still merge conflicts with your PR
Please resolve it
So, you don't have to import the component as of now in App.js and revert the changes you've made in the App.js file

@pixan198 is this fine now

Hey @Harshal0902
I've fixed the App.js file
Why you've deleted all components which were present in the components folder
You don't have to delete anything
Please restore all the components as they were

AboutUs
Committee
Homepage
Contact-us
Timeline

I may have missed something but please restore all components as they were before

@pixan198 done, can you please review it

@pixan198 please review this

Yeah @Harshal0902
Your checks are failing because of few things:

you've not updated the package.json as you're using axios. So try running npm install --save axios in your terminal inside client/ directory
You've named your files as Map.js please rename it to something like GMap.js or whatever suitable you prefer
inside your Map.js file at export statement, replace Map with App

I think this should fix it

@pixan198 I did as you told me, but still this is showing all check failed

Don't worry @Harshal0902 It is not because of your code
I'll soon merge your PR

@pixan198 Thanks a lot, for helping me out.

You're welcome @Harshal0902
Congratulations on Successfully merging your Pull Request 🎉🎉
Don't forget to update your PR count and fill the form.


ENH: Compute and expose per-tile registration reliability

Dynamic range of reliabilities is expected to be low.


Add back arrow to actionbar

Add feature to have back arrow in toolbar or option for that.
Thank you.

Use Picker.Builder.setBackBtnInMainActivity, make sure to update to 1.2.2 first


React 15.0 support?

It's already RC2: https://facebook.github.io/react/blog/2016/03/16/react-v15-rc2.html

And it released today.

Sorry, was on vacation, just got back and merged the compat update. I'll cut a release, just  waiting on a rebase on one of the latest PRs

@kenwheeler could you please release the react@15 compat?

Sadly, the change in #73 is not enough because react-tween-state specifies the peer dependency, too:
https://github.com/chenglou/react-tween-state/issues/57
https://github.com/chenglou/react-tween-state/pull/55
When the above is merged, nuka-carousel will have to follow and update, too.

@sompylasar what happens when you try and install master? you get an unmet warning for tween state?

@kenwheeler Yes, exactly. And npm@3 refuses to rebuild the shrinkwrap because of that. For now, I've made a fork with a proper dependency: https://github.com/sompylasar/nuka-carousel/commit/a9d871b7c46b9a1a3d7c3f599b5d9d2df3f810c8

Was this fixed @sompylasar? I'm currently debating to use nuka or react-slick not sure if they support react v15.0 as of yet.

@kennetpostigo I use "nuka-carousel": "^1.2.0", with "react": "^15.0.2", without issues.

Thank you!


Migrate to GMavenplus

I meant to open this against my fork, but GitHub changed the default behavior when opening a PR so it opened here. It's OK, it can sit as draft for now.

@keeganwitt Great pr. one minor detail, can you describe why the two tests are to be ignored? Ps. I think a reviewer needs to be requested for this one to be moved.

@keeganwitt Great pr. one minor detail, can you describe why the two tests are to be ignored? Ps. I think a reviewer needs to be requested for this one to be moved.

I think I commented in another PR about that. They were failing, but I didn't know enough about RestAssured to fix them.
See #1745 for related conversations.


Can I use it for other datasets?

Hi,
Thank you very much for sharing a useful tool. I am wondering if I can use it for other face datasets?
How to set the move_h, move_w parameters?
Thanks!

@ilovecv Yes, you can use the code for any dataset if you provide the landmarks. Like here https://github.com/LynnHo/Facial-Landmarks-of-Face-Datasets. Default move_h and move_w will be fine, they are used for tuning the location of the face in the image.

Hi @LynnHo,
Thank you very much for your quick reply. I used the command: python align.py --crop_size_h 256 --crop_size_w 256 --order 4 --save_format jpg --n_worker 32 to align the dataset. However, the result looks not correct:
original image:

aligned image:

May I ask the reasons? Thanks!

@ilovecv Which dataset did you use?  Have you provided the correct landmark format?


feature: http and network filter that load and run dynamic filters (.so files)

Issue Template
Title: Write a http & network filter that are capable of running dynamic filters - .so files
Description:

We would like a native envoy http & network filter capable of invoking dynamic filters compiled as .so. Main reason is that this can easily be integrated to grab remote .so files download them in envoy location and run them - making it easy to deploy a new version of that filter or other filter. Another reason is that you are able to write your filters in go and than with cgo make a .so file that can easily be included and run through this filter

We can contribute this feature back to envoy if it's relevant for you guys. We would like this to be a part of envoy since we don't want to build our custom envoy.
Do you think it's worth it? Do you see any performance impact or other potential issues?
Thanks.

I think this is a duplicate of https://github.com/envoyproxy/envoy/issues/2053. Can we track there? At a high level I would like to see this land and I don't think it would be that difficult. The main thing will be to figure out what ABI guarantees we make, if any, and what symbols get exported from the main binary.


feat(start/goal_planner): increse max dry steering angle

Description

tuning max dry steer angle with real vehicle.  use 0.4 rad becauses it's lateral deviation is not large

Screencast from 08-29-24 13_52_15.webm
https://docs.google.com/spreadsheets/d/11E7iOB-pH0HPChzvNQvsN8rY6sVnwd9SEy3HRQyNavQ/edit?gid=122359661#gid=122359661
https://star4.slack.com/archives/CEV8XMJBV/p1724909641188309?thread_ts=1724832203.130269&cid=CEV8XMJBV
Tests performed

https://evaluation.tier4.jp/evaluation/reports/77e5936f-10cb-5050-9aa1-8f41f866878e?project_id=prd_jt
real vehicle
Effects on system behavior

Not applicable.
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara @shmpwk
this is just parameter tuning based on real vehicle experinmet. cound you please check it?


Tf Grid Demo2: Mattermost failed

1st time

2nd time

@DylanVerstraete we've managed to deploy mattermost multiple times since this was opened.
I'll close, but please reopen with env details if you come across any issues


Dev

Codecov Report

Merging #6 (f12576a) into master (1d858cf) will increase coverage by 9.52%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master        #6      +/-   ##
===========================================
+ Coverage   90.47%   100.00%   +9.52%
===========================================
  Files           2         2
  Lines          21        21
===========================================
+ Hits           19        21       +2
+ Misses          2         0       -2

Impacted Files
Coverage Δ

src/config.js
100.00% <100.00%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d858cf...f12576a. Read the comment docs.


Training on CPU can only utilize 1 physical core when using autopilot

I am trying to train wmt using the tranformer model via autopilot on a CPU machine. However, I noticed,

After the data (pre-)processing completes, and the training session starts, only one CPU core is unitilized.
(I observe this by using htop/top command, and only one core is 100% loaded, even the machine equipped with Xeon processor and 40 physical cores).

If the training session is initiated via sockeye.train, after the data (pre-)processing completes, all the CPU cores are utilized and via htop/top command, and the training speed is much faster than which achived via method 1.

I also try initializing the training session via the command generated by "call_sockeye_train" functions implemented in autopilot.py, similiar phenomenon and CPU loads observed as which achived via method 2.

May I know this is the expected result when start a CPU training session via autopilot?
Thanks.

Hi Shufan,
CPU mode should use all available cores by default.  There are no explicit options in Sockeye to control the number of CPU threads, but MXNet should respect the OMP_NUM_THREADS environment variable.  If you're using the recommended version mxnet-mkl, it should automatically choose the optimal number of threads.

Hi Shufan,
Autopilot is just calling sockeye.train as a subprocesses using the same Python executable from the Autopilot invocation (code).  We haven't observed this issue--the subprocess should inherit the current environment and behave as if it was called directly by the user.
Typically, GPUs are used for training except for small test models.  Are you actively exploring using CPUs for general model training?

Closing for now.  Feel free to reopen if you have more questions.


iPad1 refresh not drawing properly

Hello !
I'm testing the kitchen-sink on an iPad1 and for example "List View" when we scroll up the new content appears only partially.

Here is the "Lazy Load Images":

Also on the "Forms" -> "Checkboxes And Radios" the "RADIO BUTTONS GROUP" do not show checked:

The same, iOS 6, and especially iPad 1 are not supported, they are too outdated


Global parameters when workers != 1 not being passed to workers

I'm not sure what the status of global parameters (apart from being in the documentation), I tried to use them but since I plan on using palatalization I can't since whenever I use run with workers != 1 the global parameter values don't seem to propagate correctly to the workers (I get the default value for the parameter), I say it doesn't propagate to the workers because if I break the run before the workers are assigned the tasks the values seem to be as passed in the command line.

I am looking for the standard way to share common task parameters, if Global config can't be relied on I could give all tasks of type A a parameter to set is as global but thing is that if I build a hierarchy of task classes, inheriting classes won't get the common parent's parameter since luigi only propagates the parameters to the actual parent Task and not children of that Task.

Reproducible test case would help here.

I have had problems with logging that I think are related. See issue:
https://github.com/spotify/luigi/issues/2247
The problem is that variables cannot be shared when forking in Windows, simply due to the model or spawning processes in the OS. Window  does not allow subprocess read-only access to objects in the parent process's space, Linux do.
Can you confirm that you are using Windows? If so I do not think there is a good solution, other than creating a permanent file or other temporary storage and have each sub-process re-read them.
In our logging setup on Windows, I have each worker re-read the logging config at startup.

Yep, I'm developing using windows and deploying on redhat, I had to drop the global config way to out of other reasons so this is not an issue anymore for me, but thanks for the tip, its good to know that issues are handled.
Also, FYI, the solution you propose doesn't use luigi parameters which means that there is no single task per set of parameters which is bad for caching, recalculation, stuff like that...

Come to think of it you guys might be interested in the other reason I decided not to use global parameters from a design concern...
I needed to be able to run the inards of the task outside of the luigi framework in order to speed up prediction of my ML models, so, I have run which among other things has an inner process(message) method that processes a single message and my pipeline designers must adhere that piping large amounts of messages through the pipeline tasks will lead to training but then that in order to process a single message I just need to build the dependency DAG and pump that message in order along that DAG (the process(message) method works by taking out some features from the message and putting back some other features so that this is totally general for all types of ML pipelines and assures that the production will not be slowed down by using luigi and file Target overheads to pass a single message for prediction while in production)
In order to do this I had to have the parameters during luigi.run equal to the ones that are passed in the task instantiations, Task parameters are ok in this sense, but try as I might I couldn't get global parameters to give me the same parameters when run outside and inside of luigi.run so as I said I stopped using a global config class and instead wrote a method that wraps task instantiation and passed all pipeline (my wrapper class for wrapperTask) parameters to all tasks instantiated in the pipeline.
If you came to this line, thanks for reading this, hope you found it useful.

Unfortunately multiple workers are not supported on Windows, as stated here: https://luigi.readthedocs.io/en/stable/running_luigi.html?highlight=windows#luigi-on-windows 😞


Imports.cmake should work with a MSVC front-end

Imports.cmake uses CMAKE_AR assuming that it's a MSVC linker (link.exe), and attempts to enforce this by checking the CMAKE_CXX_COMPILER_ID or CMAKE_C_COMPILER_ID. But this fails with clang-cl.exe. This change loosens the restrictions by just checking the CMAKE_CXX_COMPILER_FRONTEND_VARIANT or CMAKE_C_COMPILER_FRONTEND_VARIANT - which is MSVC when using MSVC's cl.exe or Clang's clang-cl.exe, and in both cases, link.exe is the linker. I imagine that somehow checking CMAKE_AR to see if it is link.exe might be the more right thing to do, but checking the COMPILER_FRONTEND_VARIANT seems to be a more direct, less heuristicy approach for the time being.

Ah. The "ntdll_imports_library.def: no such file or directory" error appears to be an LLVM 16.0 problem (the Agents use 16.0.5), that doesn't repro with 17.0.


Remove jetifier, again

Codecov Report

Merging #59 (73fcd5e) into master (b206a79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #59     +/-   ##
========================================
  Coverage    0.00%   0.00%
========================================
  Files         367     364      -3
  Lines       11363   10038   -1325
  Branches     1140     913    -227
========================================
+ Misses      11363   10038   -1325

Impacted Files
Coverage Δ

...pmobilny/ui/modules/photoview/PhotoViewActivity.kt
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b206a79...73fcd5e. Read the comment docs.


Better support for TZ locations in the times module

I've added a location parameter to times.date to allow for creating a timestamp in a specific location. The call now works the same as the equivalent Go function. This parameter is optional so as not to break existing code.
Along with this I've also added times.in_location(t time, l string), which works similar to func (t Time) In(loc *Location) Time

Nice!


Simplify the nodejs events template

Pretty-printing the contents of the event and its envelope for each
request. This is handy when invoked as a Knative event sink as some
sources, e.g. Kafka, ignore the response body.

@jcrossley3 I have just realized that the faas-js-runtime dependencies in both event/package.json and http/package.json should be updated to 0.7.1 before this lands.

@jcrossley3 I have just realized that the faas-js-runtime dependencies in both event/package.json and http/package.json should be updated to 0.7.1 before this lands.

Done


Verbose Validation Error Message Shown

I have the following schema:
let validateSchema = yup.object().shape({
    title: yup.string().trim().required("Title Required!"),
    url: yup
        .string()
        .url("URL must be Proper!")
        .required("Job URL is Required!"),
    salary: yup.object({
        min: yup
            .number("Salary must be a number!")
            .positive("Salary must be greater than 0!")
            .integer("Salary must be an Integer!"),
        max: yup
            .number("Salary must be a number!")
            .positive("Salary must be greater than 0!")
            .integer("Salary must be an Integer!")
            .moreThan(
                yup.ref("min"),
                "Max Salary must be larger than Minimum!"
            ),
        currency: yup.string().required(),
    }),
});

However the message shown is not the one I specified:

If I use <input type="number"> and give default value as a number, then the error message isn't this hideous.
However, if I try to delete those numbers, than at last '0' remains and I can't delete that.
If I use <input type="text">, then the above verbose error message is shown.
What's the best course of action?

Fixed the issue with hit and trial. Yup documentation doesn't even mention this.
Adding Truncate worked wonders!!
salary: yup.object({
    min: yup
        .number()
        **.truncate()**
        .positive("Salary must be greater than 0!")
        .integer("Salary must be an Integer!"),
    max: yup
        .number()
        **.truncate()**
        .positive("Salary must be greater than 0!")
        .integer("Salary must be an Integer!")
        .moreThan(
            yup.ref("min"),
            "Max Salary must be larger than Minimum!"
        ),
    currency: yup.string().required(),
}),

Result:


Remove the Splash-Screen

Was thinking to add it to the Remove-Clutter PR - but isolating it as it is a functional change here.
Splash-Screens are one UX anti-pattern - especially when there is no loading done in this case - the user is just blocked for 1s+ without any reason

valid point. back then i couldnt resist the temptation to show off our amazing logo. :)
any other opinions?

but..but.. the logo!
No, seriously - I also think it should be removed. Maybe we can find a nice spot for the logo somewhere else - maybe in a redesigned about tab?. Would be a shame not to use it :)

2 against 1...
i surrender! ;)

Great! You did the right thing - big day for the UX of criticalmaps. We will find a nice place to show of the logo ;-)


fix(reactivity): observe instance from subclass of Collection (close …

…#1489)

It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct.
Just like concept vs real world.
IMO the best way to deal with it is to put this into limitations section.


Merge gulp/grunt workflow using simple bash switcher

It's kind of time consuming to maintain to branches of the same repository with very similar structure, except a few folders and files. Here is a solution:

place grunt/gulp or npm (in future) stuff in related folders
add simple bash script that allows to swithc task runner (or even npm scripts) and remove the rest variants.
It should work like very simplified scaffold generator.

Basicly implemented here https://github.com/orlovmax/front-end-scaffold/commit/60390800b3fa15eff23964451f2c82d717f17c07


New package: FunJL v0.1.0

Registering package: FunJL
Repository: https://github.com/HyperSphereStudio/Fun.jl
Created by: @HyperSphereStudio
Version: v0.1.0
Commit: b8b955318ca6e11ff8ef752a17b682e7ba155f4f
Git reference: HEAD

Superseded by #51473


Oxplay workbranch adjustments pull request

Please note its not related to any issue/feature (at least directly)
As we spoke before, its mainly for testing purpose, now you will be able to see that current Messages send too many class names.

Tests extension
logger feature
connectionTimeout adjustment
changed cacheDisabled to softCachingResolver for a Class Resolver.
moved Test messages into separate package
Test server set into headless mode

Result output in Server when receiving messages:
More detailed message values:
Got message Test TCP Big Message A from client /<IP_ADDRESS>:36124
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Got message Test UDP Big Message A from client /<IP_ADDRESS>:36124
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Got message Test TCP Big Message B from client /<IP_ADDRESS>:36124
{test2=[I@212e74ac, test3=[TestValue1, TestValue2, TestValue3], test1=12}
Got message Test UDP Big Message B from client /<IP_ADDRESS>:36124
{test2=[I@436b74dc, test3=[TestValue1, TestValue2, TestValue3], test1=12}

Logger was set to INFO so now we also see what package exactly send:
(This currently log only TCP messages)

         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 00 00 01 4d 05 73 72 01 00 33 69 6f 2e 74 6c 66 |...M.sr..3io.tlf|
|00000010| 2e 6d 6f 6e 6b 65 79 6e 65 74 74 79 2e 74 65 73 |.monkeynetty.tes|
|00000020| 74 2e 6d 65 73 73 61 67 65 73 2e 54 65 73 74 54 |t.messages.TestT|
|00000030| 43 50 42 69 67 4d 65 73 73 61 67 65 41 78 70 73 |CPBigMessageAxps|
|00000040| 72 01 00 36 69 6f 2e 74 6c 66 2e 6d 6f 6e 6b 65 |r..6io.tlf.monke|
|00000050| 79 6e 65 74 74 79 2e 74 65 73 74 2e 6d 65 73 73 |ynetty.test.mess|
|00000060| 61 67 65 73 2e 54 65 73 74 53 65 72 69 61 6c 69 |ages.TestSeriali|
|00000070| 7a 61 62 6c 65 44 61 74 61 41 78 70 73 72 01 00 |zableDataAxpsr..|
|00000080| 13 6a 61 76 61 2e 75 74 69 6c 2e 41 72 72 61 79 |.java.util.Array|
|00000090| 4c 69 73 74 78 70 00 00 00 0a 77 04 00 00 00 0a |Listxp....w.....|
|000000a0| 73 72 01 00 0e 6a 61 76 61 2e 6c 61 6e 67 2e 4c |sr...java.lang.L|
|000000b0| 6f 6e 67 78 72 01 00 10 6a 61 76 61 2e 6c 61 6e |ongxr...java.lan|
|000000c0| 67 2e 4e 75 6d 62 65 72 78 70 00 00 00 00 00 00 |g.Numberxp......|
|000000d0| 00 00 73 71 00 7e 00 06 00 00 00 00 00 00 00 01 |..sq.~..........|
|000000e0| 73 71 00 7e 00 06 00 00 00 00 00 00 00 02 73 71 |sq.~..........sq|
|000000f0| 00 7e 00 06 00 00 00 00 00 00 00 03 73 71 00 7e |.~..........sq.~|
|00000100| 00 06 00 00 00 00 00 00 00 04 73 71 00 7e 00 06 |..........sq.~..|
|00000110| 00 00 00 00 00 00 00 05 73 71 00 7e 00 06 00 00 |........sq.~....|
|00000120| 00 00 00 00 00 06 73 71 00 7e 00 06 00 00 00 00 |......sq.~......|
|00000130| 00 00 00 07 73 71 00 7e 00 06 00 00 00 00 00 00 |....sq.~........|
|00000140| 00 08 73 71 00 7e 00 06 00 00 00 00 00 00 00 09 |..sq.~..........|
|00000150| 78                                              |x               |
+--------+-------------------------------------------------+----------------+

this will help ivestigate https://github.com/tlf30/monkey-netty/issues/4

Those changes look good to me.
I would like to know more on the softCachingResolver. The javadoc (as with most in netty) leaves a lot to be desired.
Does this have a noticeable increase in performance when dealing with a large number of messages?

Another question, have you had any luck on getting the timeout to work when the server is killed?

About softCachingResolver
Well, i were looking at their sourcecode.
Advantage of not using "cacheDisabled" but some cache is that we get class from cache instead:
return classLoader.loadClass(className);
doing this each time, so i suppose its much faster to get it from some HashMap.
When using some "concurrent cache CachingResolver", it will just use special HashMap for concurrent, it will be slower, but work parallel, but i was not sure were it need parallel for this, so i just added "softCachingResolver"
in some question, they use weak one like:
https://stackoverflow.com/questions/8660491/how-to-implement-objectdecoderclassresolver-in-netty-3-2-7
but trully the only difference of this methods is how they store cached classes:
new WeakReferenceMap<String, Class<?>>(new HashMap<String, Reference<Class<?>>>()));

new SoftReferenceMap<String, Class<?>>(new HashMap<String, Reference<Class<?>>>()));

new WeakReferenceMap<String, Class<?>>(PlatformDependent.<String, Reference<Class<?>>>newConcurrentHashMap()));

new SoftReferenceMap<String, Class<?>>(PlatformDependent.<String, Reference<Class<?>>>newConcurrentHashMap()));

where cacheDisabled use none of them, just each time execute return classLoader.loadClass(className);
so in Case of Feature https://github.com/tlf30/monkey-netty/issues/4,
we would probably need find what to put instead of null here:
new ObjectDecoder(Integer.MAX_VALUE, ClassResolvers.softCachingResolver(null)),
since null mean default ClassLoader, so maybe its a way to change way Classes are loaded to some ID instead Strings.
If you ask about increased performance, i didnt stress-test it, but im almost sure its micro-optimization we can do.
About "have you had any luck on getting the timeout to work when the server is killed?"
Nope, the only change i did was to allow user setup timeout per AppState.
Myself i have exception each like 0.1 sec. so it do not use timeout for "off" server.
Will need investigate it, i assume worth to create issue for it.

Also looks like i forgot to change "changelog" file,
so i will push additional commit for this

No, I will do that prior to a release

Lets get this merged in after #11 that way it only needs rebased once.

Please let me know, when update this with HEAD repo.
I need go sleep now, so will do it tomorrow.

Sounds good, you can rebase to head when you are ready.
I am in AKST, so probably a bit different from where you are at :)

Merged remote-tracking branch 'upstream/master' into working-oxplay (this PR)


Pre Selecting  an escaped value

I am opening here a bug report, following my question on Stackoverflow.
The problem is, that it's currently not possible to populate select input at init:

it's empty, but filtering works correctly.
As found by Datatables developer on their forum , maybe there is a race condition which is causing the YADCF plugin to clear the input value.

As you can see it shows up for a sec, then it's become hidden.
I tried multiple solution, but none seem to be work:
$('#mytable').on( 'init.dt', function () {
     yadcf.exFilterColumn(oTable, [[4, '3/2020']], true);
  } );

 yadcf.initOnDtXhrComplete(function() {
   yadcf.exFilterColumn(oTable, [[4, $("#yadcf-filter--mytable-4 option:eq(1)").val()]], true);
  });

Test site:
init.d
yadcf.initOnDtXhrComplete

@adrianmihalko you can get the final 0.9.4.beta.40 js version with the fix


Fix isWorkspaceMemberLeavingWorkspaceRoom condition for threads

Details
Fix the redirection logic when leaving a thread in a room.
Fixed Issues
$ https://github.com/Expensify/App/issues/33875
PROPOSAL: https://github.com/Expensify/App/issues/33875#issuecomment-1875645298
Tests
Same as QA
Offline tests
Same as QA
QA Steps

Go to a room of the Workspace you are a member of (it can be your own workspace);
Send a message and create a thread reply.
In the thread, click the 3-dot menu > "Leave"

[ ] Verify you are redirected back to the room

In the room chat, click the 3-dot menu > "Leave"

[ ] Verify you are redirected to the Concierge chat

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/12595293/86e400cb-0b82-48ef-8c08-73a41a7b9645

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/8d0a7135-934d-4a44-afe6-f4189b2f816d

iOS: Native
https://github.com/Expensify/App/assets/12595293/0385449f-d005-4810-9c8e-260ee0014fe8

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/71c30de1-b6b2-47dc-8cee-4b43a3b34c6e

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/0c76b8e8-b57d-435f-9f15-a18a38a25f4e

MacOS: Desktop
https://github.com/Expensify/App/assets/12595293/dd7a2813-64da-4c0a-8d58-9244985de9a2

@Ollyws a friendly bump on the review, thanks 🤝

Can we please expand QA steps and tests to also check when exiting a normal workspace room

@MonilBhavsar done ✔
Updated also the web recording to cover the "leave room" test.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.27-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Story: viewing published versions of a specific package

Story link
This is a story issue to track the overall progress towards achieving a user story.
Task issues will be track here soon.

Cleaning up old issues


bug

When i install this plugin it works great but i wanted to do more testing with it so i have found that if a player already has the banned item they can still right/left click it essentially use the banned item but if they drop it, it will remove it from there inventory
you can reproduce this problem by using some sort of plugin that does /invsee take a look/modify someone inventory so you can put the banned item in there can the player without permission to use the banned item can still use it

fixed somehow


Dartanalyzer doesn't warn about mixin's superclass member

This is offshot of #25762
Class derived from the mixin application should have only those members that explicitly declared in it, not in its superclass. Otherwise analyzer should warn about that. But in fact it doesn't. Example:
class S {
  int get g1 => 1;
}
class M1 {
  int get g2 => 2;
}
class M2 extends M1 {
  int get g3 => 3;
}
class C extends S with M2 {
}

main() {
  C c = new C();
  c.g2; // g2 is not mixed into C, so there should be a warning about not existing getter g2
}

Tested on Dart VM version: 1.15.0-dev.2.0 (Wed Feb 10 02:55:12 2016) on "windows_x64"

I wonder if the real issue is that the analyzer should complain that C only partially implements the M2 interface because it's missing the g2 getter.

Since (with the super mixin feature) a base class must be a subtype of the superclass of the mixin, this issue is now meaningless.


Signature does not match error

Hello,
We are facing issue with error returned as below from file stack server,
<Error>SignatureDoesNotMatch<Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message>
We are using latest lib (compile 'com.filestack:filestack-android:2.0.0-alpha.2')
We are using below code to upload files,
Config config=new Config(BuildConfig.FILE_STACK_API_KEY, "","");
Client client=new Client(config);
Flowable<Progress<FileLink>> progressFlowable = client.uploadAsync(strLocalFilePath, true);

It was working code.
Don't know why suddenly this error is being faced.
Please help.
--
Thanks,
Abhijit

That error message is from the AWS S3 API. We upload files in parts and this message means the hash of the part didn't match what S3 received. You shouldn't be seeing that. I'm not able to reproduce this error myself though. Could you give me specifics on the file or files you're uploading and the path you're passing into the upload call? What kind of files are they? What's the file size or range of sizes?

Hey @shawnmaten ,
We are uploading the image file from SD card which can be nearly 5 MB utmost.
 (e.g.: /storage/emulated/0/ProjectName/IMG_20171221_161402228.jpg)
Currently we have two File Stack API key.
One for production (client supplied api key) and one for development (we registered with free account for this api key)
We are able to upload the files successfully with the development API key.
But for production API key it fails.
Development API key is linked with the free account where all the files are uploaded to default storage of File Stack.
Production API key is linked with the premium account where while uploading the files we set the default storage of File Stack. But in case of production, client have S3 bucket which must have been linked with the File Stack.
We think this must be causing issue.
Please check.
--
Thanks,
Abhijit

@AbhijitKurane I'm still not able to reproduce this issue. That your seeing the S3 error is still odd to me, but if the exact same code works for one key and not another, the account configuration must have something to do with it. I would like you to open a support ticket so we can check out your application settings.

@shawnmaten ,
Thanks for the reply.
I will open the support ticket as well as you suggested.
But just wanted to highlight that the same production API key is working smoothly on iOS and for Android it is working smoothly with the development API key.
For iOS platform currently developers are using library as below,
pod ‘Filestack’, ‘~> 0.3.9’
Please guide.
--
Thanks,
Abhijit


desktop capture extension for iframeless demo not installed on google extension store.

We seem to have lost this.

"As of November 21st, 2016, all newly published packaged or hosted apps are restricted to Chrome OS, and are not available to users on Windows, Mac or Linux. Existing apps will continue to be available on all major platforms and will continue to receive updates"
You can't publish anymore.

Check that one from Google:

https://github.com/webrtc/testrtc/tree/master/src/manual/peer2peer/extension


incorrect Infinity timestamp and float values display

Operating system (distribution) and version: Windows 10 (last update) / x64
DBeaver version: <IP_ADDRESS>101130717
Database name and version: PostgreSQL 13

SELECT 'Infinity'::timestamp, '-Infinity'::timestamp, 'Infinity'::timestamptz, '-Infinity'::timestamptz;
Show: (292278994-08-17 02:00:00, 292269055-12-03 02:00:00, 292278994-08-17 02:00:00, 292269055-12-03 02:00:00)
Must be: (∞, -∞, ∞, -∞) or (+Infinity, -Infinity, +Infinity, -Infinity)

SELECT 'Infinity'::float4, '-Infinity'::float4, 'Infinity'::float8, '-Infinity'::float8;
Show: (∞, -∞, +Infinity, -Infinity)
Must be: (∞, -∞, ∞, -∞) or (+Infinity, -Infinity, +Infinity, -Infinity)

Please enable date/time and numeric formatting (Edit connection>Data Editor>Data Formats) to see the correct result.

Please enable date/time and numeric formatting (Edit connection>Data Editor>Data Formats) to see the correct result.

If you disable the formatting of date/time and numerics, we get the correct result:
SELECT 'Infinity'::float4, '-Infinity'::float4, 'Infinity'::float8, '-Infinity'::float8;
(+Infinity, -Infinity, +Infinity, -Infinity)

SELECT 'Infinity'::timestamp, '-Infinity'::timestamp, 'Infinity'::timestamptz, '-Infinity'::timestamptz;
(+Infinity, -Infinity, +Infinity, -Infinity)

That is, the bug manifests itself only when formatting is enabled.

I would like infinite values to be displayed correctly also when formatting is enabled.
As far as I understand, with date/time and numerics formatting enabled, the result should be like this:
SELECT 'Infinity'::timestamp, '-Infinity'::timestamp, 'Infinity'::timestamptz, '-Infinity'::timestamptz;
(∞, -∞, ∞, -∞)

SELECT 'Infinity'::float4, '-Infinity'::float4, 'Infinity'::float8, '-Infinity'::float8;
(∞, -∞, ∞, -∞)

If you disable the formatting of date/time and numerics, we get the correct result:
SELECT 'Infinity'::float4, '-Infinity'::float4, 'Infinity'::float8, '-Infinity'::float8;
(+Infinity, -Infinity, +Infinity, -Infinity)

SELECT 'Infinity'::timestamp, '-Infinity'::timestamp, 'Infinity'::timestamptz, '-Infinity'::timestamptz;
(+Infinity, -Infinity, +Infinity, -Infinity)

That is, the bug manifests itself only when formatting is enabled.

I would like infinite values to be displayed correctly also when formatting is enabled.
As far as I understand, with date/time and numerics formatting enabled, the result should be like this:
SELECT 'Infinity'::timestamp, '-Infinity'::timestamp, 'Infinity'::timestamptz, '-Infinity'::timestamptz;
(∞, -∞, ∞, -∞)

SELECT 'Infinity'::float4, '-Infinity'::float4, 'Infinity'::float8, '-Infinity'::float8;
(∞, -∞, ∞, -∞)

verified


⚠ Roblox Site has degraded performance

In c107498, Roblox Site (https://roblox.com/) experienced degraded performance:

HTTP code: 503
Response time: 1290 ms

Resolved: Roblox Site performance has improved in d1c8763 after 29 minutes.


Command-i to Toggle the Info Panel in the Preference Pane

Ever since I first saw that little "i" button in QS's preference I always thought it should be accessible via the command-i key combo.
It would be consistent with Apple's apps and would make perfect sense.  Wouldn't you agree?

Completely agree. Hopefully someone else will take it on. Interface Builder is my Kryptonite.

Yay. A +1 from me. :-)


feat(accountUpdateTransaction): Implement AccountUpdateTransaction E2E tests: TCK

Description:
This PR implements the tests documented in test-specfications/crypto-service/accountUpdateTransaction.md. Since some of the work was already done for AccountUpdateTransaction tests, this reworks those tests to match what is in the test specifications, in addition to adding any new tests. The docs were also updated to mark the tests as implemented.
Reminder, according to the development process we have established for the TCK (https://github.com/hashgraph/hedera-sdk-tck/pull/202), this SHOULD NOT be approved by an SDK lead until their SDK has done any development required to run these tests against their SDK and those tests have passed. Feel free to provide comments and input to the PR, but approvals should not be granted until testing has occurred.
Issues opened in SDKs that encompass the SDK server work should be linked back to the TCK's AccountUpdateTransaction development issue (https://github.com/hashgraph/hedera-sdk-tck/issues/39) for easy tracking.
The work in this PR also consumes the work required for #196.
Related issue(s):
Fixes #217
Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

All tests are passing in JS.


Get rid of visited link colors

So far we've had visited links a different color (purple instead of blue, on the black and white theme).  If Bootstrap is an indicator, they've totally retired visited link styling 10 years ago.  I personally don't feel having two colors to indicate links is helpful, but i'm open to hear about situations where it IS helpful, and figure out how visited links can be indicated in a more useful way.
I do think it's useful for example to indicate on a matrix box that you've already viewed that observation. I'd like to do it a different way, though.
This fixes an issue where left bar links are incorrectly styled on the Amanita theme.

Coverage: 93.601%. Remained the same when pulling 80dd23e69f3fef31db6719aca36145a3c9920be8 on nimmo-add-fastimage into 79d9c705d75551b2ec3b709a8bf31dc0425a69c6 on main.


Please lint :)

Many files in Zurvan have a mix of tabs and spaces, even on the same line.  The result is that, unless I have the same tab settings, the code looks like it was indented in a freak cat-on-keyboard incident.
It would be great to pick one or the other (preferably spaces) and enforce it using eslint.

(I would do this but of course it will conflict with any other work in progress or pull requests, so it's best done by a maintainer)

done in 8ce825c75331f1f97321ae7cd7fd06babdd9f8dc

Wow, thanks :D


Update .gitignore

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Just an example how to make it better.

Thanks a lot! Very reasonable improvement. I have merged it manually


Consider editing repository setings to remove "Packages" section

"Packages No packages published" is displayed right now, fortunately this pointless section can be removed.
Edit repo page config to remove it (cog next to the description).
I am not making a PR as it is defined in proprietary github settings, not in a git repository - and I have no rights to modify repo settings.
Releases section also likely makes sense to remove.

Should be fixed now


onupdatefiles is called two times when using react-filepond

Summary
The onupdatefiles function is called two times, when I add a file to the default filepond compontent.
How to reproduce
Import the react-filepond component.
Add function to onupdatefiles and log it to the console.
You will see it two times.
Expected behaviour
It only should be called one time.

I believe it's currently called twice so it's synced correctly when a file is rejected by one of the validation plugins. Will look into this, but for now, it manages to correctly sync the files list with a parent state ( in React, which is the main purpose of this method ).

When using filepond-jquery same thing happens.

It's run by the internal FilePond library so it will indeed happen everywhere. Will leave this as is for now.

Summary
The onupdatefiles function is called two times, when I add a file to the default filepond component.
How to reproduce
Import the react-filepond component.
Add function to onupdatefiles and log it to the console.
You will see it two times.
Expected behaviour
It only should be called one time.

You can call your custom functions or trigger whatever you want using the "onaddfile" callback, and you will get a very similar behaviour.
Source: https://pqina.nl/filepond/docs/print-version/#callbacks

How did you solve that, The problem continues on my code?

onupdatefiles is called twice, and between those 2 calls, onaddfile is called once. Adding a working example with typescript:
`
import { FilePondFile, ActualFileObject } from 'filepond';
export type FileList = FilePondFile[];
const MyComponent: FC = () => {
const [files, setFiles] = useState([]);
const onAddFile = async () => {
if (files && files.length > 0) {
const file = files[0].file; // actual File API object
const readBlobToText = (blob: ActualFileObject) =>
new Promise((resolve, reject) => {
const reader = new FileReader();
reader.addEventListener('load', () => resolve(reader.result));
reader.addEventListener('error', () =>
reject(new Error('Reading file failed'))
);
reader.addEventListener('abort', () =>
reject(new Error('Reading file aborted'))
);
reader.readAsText(blob);
});
  const result = await readBlobToText(file);
  console.log('file contents', result);
}

};
return ()
`


webSocketFeed.Close event firing every 60 seconds

As per the title... the webSocketFeed.Close event firing every 60 seconds.
This causes WebSocket.WebSocket_Closed to fire, which restarts/resubscribes etc.
It seems that the reason its closing every 60 seconds is because of inactivity. I get this behavior if I subscribe to the User channel and then don't do anything for 60 seconds.... which happens :)
The problem is that the majority of the time (but strangely not always), once the socket has been restarted I don't get the activity events like Receive, Open, Done firing.
The solution is to add:
webSocketFeed.AutoSendPingInterval = 30;
into the CoinbasePro.WebSocket.WebSocketFeed constructor... then the Socket will not close and everything remains rock solid stable.
The reason for logging this issue is that it would be nice to have some way to set or configure this value out the box. I can't think of a neat solution to getting the value in without complicating the construction of CoinbaseProClient.

@chrisw000 i have seen this happen. I think we should be able to add this easily to the websocket and it doesn't have to be added when the websocket is constructed. I opened a PR here: https://github.com/dougdellolio/coinbasepro-csharp/pull/172 and ran a quick test on it... let me know what you think.

Nice... I'd assumed it needed to be set on construction.
While you're in that area... I noticed that the WebSocketFeed class has a .Invoke method... which is used to hookup the events in WebSocket class, this doesn't seem necessary? You could remove the Invoke method entirely and hookup the events like this (its the same, just a bit easier to read)
                case ResponseType.Received:
                    var received = JsonConfig.DeserializeObject<Received>(json);
                    //dont need to do it like this:
                    //webSocketFeed.Invoke(OnReceivedReceived, sender, new WebfeedEventArgs<Received>(received));

                    OnReceivedReceived?.Invoke(sender, new WebfeedEventArgs<Received>(received));

Actually.... there is an issue with the PR as it is... I'll put comments onto the PR


Changing GPIO ports/adding several devices

How can i change the gpio ports so how that i want it? Just change gpio in main.c?
Can i add more devices controlled by one esp?

So, the general idea is: esp-homekit is a framework for creating firmwares for various devices. So, you take it and develop your own firmware and customize it to whatever your heart desire. Although, this might be a complicated software for beginners as it requires quite a few things to set up. So, this repo holds examples of typical firmwares so you can use them as a starting point. Some people find it sufficient to use off-the-shelf (off-the-repo) examples as is on their devices though.
If you're not a programmer (or do not want to mess with all that software stuff), I would recommend looking at HAA - a third-party universal firmware based on esp-homekit that you can customize to do particular stuff.

Thank you for your answer! I read about haa before but i dont like the code with only letters. Well i am used to c/c++ but i dont find a good code with documentation. I struggle with the library functions. I can read the code good but i dont know how to write it with the functions, i Is there a well documented code or a good manual? I would like to configure the esp ports to switch the door lock or a light bulb or read about temperature data :)

Dealing with GPIOs is outside of scope of this framework. Handling GPIOs and interfacing with external hardware is a generic topic and you should look e.g. materials on Arduino (but keep in mind that APIs in esp-open-rtos will be a bit different.


unusual behavior

I previously used ver 2<IP_ADDRESS>  Recently I updated to version 2<IP_ADDRESS>.  With the latest version installed in my project --- any class where I had a reference to both:
System.ComponentModel
PropertyTools.DataAnnotations
an error is thrown for every property that has an annotation.
The error reports that the BrowsableAttribute or the DisplayNameAttribute is ambiguous.
This was not the case in the older version.
The solution for me was to remove the reference to System.ComponentModel, on every class that includes PropertyTools but it is not clear that someone may use some part of System.ComponentModel that is not included in PropertyTools.DataAnnotations.  In any case, for a large project the upgrade requires a lot of hand work when thousands of errors are thrown accompanying the upgrade, so it would probably be nice for others if the ambiguous situation were resolved.

I have created #36 and #37 to cover the problems described here. Can we close this issue?

Thank you, I will watch 36 & 37 - Closed


Add popup UI

Add buttons for starting speech synthesis and settings

Assumption is that the Haolan unit testing broke the code, therefore we are postponing the merge until we can see the a change in which the build is functioning in relation to the MVP

We are good to merge.

Well, let me merge then


Give packit-prod postgres 2Gi memory

It a bit worries me that it's been just a couple of months since I last increased it from 512Mi to 1Gi (898c2ea5c) and it's again not enough.
We can afford it so let's do it, but next time we should probably play with POSTGRESQL_SHARED_BUFFERS & POSTGRESQL_EFFECTIVE_CACHE_SIZE whose default values are based on the memory limit, so the more memory we give it the bigger buffers/cache it uses.


Allow specifying navigation items target attribute

Summary
When adding navigation items to external sources need to be able to open target URL in a new Tab.
Motivation
Currently main navigation replaces current page which is fine for normal nav items, but when you have navigations items pointing to external sites need to be able to open them in a new tab.
Updates needed
updating masthead.html allows this

    {{ link.title }}

This then can be activate using the navigation.yml
# main links
main:
  - title: "Home"
    url: /
  - title: "Tools"
    url: /tools/
  - title: "Blog"
    url: /blog/
  - title: "About"
    url: /about/
  - title: "GitHub"
    target: _blank
    url: https://github.com/wildone/maxbarrass.com
  - title: "Search"
    url: /search/

Related: #2388

Not interested in doing this for all the reasons cited in #2392
It is a better UX for the user to decide when they want a link to open in a new tab rather than force it upon them.

@mmistakes This one is fundamentally different than similar ones in that it's not a request to change, but to enable to change. To me it's definitely a decent move to defer this decision to site creators.


The old "pre-recieve hook declined" strikes back after updating Dokku to latest

Not sure what's causing this guy. Have removed all third-party plugins.
https://gist.github.com/angusfretwell/c73208e056187594efcc

It looks like it's failing to fetch the custom buildpack. First, is this DO? If so, turn off IPv6. We've also seen folks have issues with DNS. So try the resolvconf -u trick from the troubleshooting docs.  That's all in the case your on DO.
If not, try downloading the buildpack url you're using from inside a container on that box. See if there is an error. There's reference steps in the troubleshooting docs if you need an example.

Hello I am new to this projects. I have experimented with dokku in the past week extensively and have also encounter this issue. Firstly the buildpack detection mechanism seems to be far off from what I would expect. When pushing some laravel apps Dokku would take them as node.js.
Only later I learned to use the dokku config set command
dokku config:set <app_name> BUILDPACK_URL=https://github.com/CHH/heroku-buildpack-php
Then later one other thing I noticed is that Dokku .env file where one can specify the BUILDPACK has a potential conflict with laravel 5 new .env files which are not meant to be git imported. Or am I wrong ?

You didn't encounter the same error, you encountered a different error. You need a Procfile for PHP support, exactly the same as how heroku works.  See this test app for an example.
All of our buildpacks are pretty much the heroku buildpacks. As for laravel .env files, you can always rename them to .env.local and then source the file in locally, which should have the same effect as having it named .env.

@angusfretwell did you get any resolution on this?

Same issue on a fresh install at Digital Ocean, no IPv6 enabled. Logs with dokku_trace=1:
https://gist.github.com/stepri/9e28e9e21d01da0ffe2b

@stepri you seem to be having a different issue than the OP. Please open a new issue so we may track the resolution there.
Thanks.

@michaelshobbs, It started working for me after disabling the build-env and checks plugins. I haven't had a chance to look into it further yet, but I will do so at some point today.

@angusfretwell any idea what the issue could be? Neither of those should cause issues if you:

Don't have checks set
Don't set invalid config

Maybe you had one or the other?

Closing as there hasn't been feedback from op. Let us know if you found anything useful for debugging :)


strace ping fails as admin

C:\WINDOWS\system32>bash.exe -c 'exec ping <IP_ADDRESS> -c1'
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=57 time=35.9 ms

--- <IP_ADDRESS> ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 35.947/35.947/35.947/0.000 ms

C:\WINDOWS\system32>bash.exe -c 'strace ping <IP_ADDRESS> -c1'
execve("/bin/ping", ["ping", "<IP_ADDRESS>", "-c1"], [/* 12 vars */]) = -1 EPERM (Operation not permitted)
write(2, "strace: exec: Operation not perm"..., 38strace: exec: Operation not permitted
) = 38
exit_group(1)                           = ?
+++ exited with 1 +++

What exactly is causing this?

This is not allowed even on native Ubuntu.
`strace ping <IP_ADDRESS> -c1
capget({_LINUX_CAPABILITY_VERSION_3, 0}, {0, 0, 0}) = 0
socket(PF_INET, SOCK_RAW, IPPROTO_ICMP) = -1 EPERM (Operation not permitted)
capget({_LINUX_CAPABILITY_VERSION_3, 0}, NULL) = 0`
From man [strace] (http://man7.org/linux/man-pages/man1/strace.1.html), unless the '-u' option is used setuid and setgid programs are executed without effective privileges. And ping probably falls in that category.

Ahhh, fail on my part. Thanks!


Skip loading parameter 'heads.weight' to the model due to incompatible shapes: (751, 2048) in the checkpoint but (0, 2048) in the model! You might want to double check if this is expected.

I have retrained the model with Market1501 using bagtricks_R101-ibn.yml configuration file.
Accuracy is as expected, but I am getting the following warning while loading the model for inference.
Skip loading parameter 'heads.weight' to the model due to incompatible shapes: (751, 2048) in the checkpoint but (0, 2048) in the model! You might want to double check if this is expected.

Hi nazmulnnb, I also encountered the same problem, have you figured it out? Thanks in advance for replying.

@chansongoal
I was not able to fix it. After checking the codes, it seems like the model built for inference differs from the model built for training. The head of the inference model doesn't contain the softmax layer. As we are using only in embedding output, I think it's okay not to worry about the softmax layer. I just left it like it was. If the warning bothers you, you can just simply delete it from the weight.
I might be wrong. I am also expecting a clarification from the original author.

I agree with you that the softmax layer is not necessary for inference. But I got another problem: many parameters like "heads.bottleneck.0.weight", "heads.bottleneck.0.bias", etc., cannot be found in the pertrained model. And some parameters   like "heads.bnneck.weight" which contained in the pertrained model are not used.
I guess "heads.bnneck.weight" contained in the pretrained model is the "heads.bottleneck.0.weight" needed in the model.   And I rename the parameters in the pretrained model, but the evaluation results is lower than those reported in the MODEL_ZOO. Did you encounter the same problem?

@chansongoal I was not able to fix it. After checking the codes, it seems like the model built for inference differs from the model built for training. The head of the inference model doesn't contain the softmax layer. As we are using only in embedding output, I think it's okay not to worry about the softmax layer. I just left it like it was. If the warning bothers you, you can just simply delete it from the weight.
I might be wrong. I am also expecting a clarification from the original author.

I agree with you that the softmax layer is not necessary for inference. But I got another problem: many parameters like "heads.bottleneck.0.weight", "heads.bottleneck.0.bias", etc., cannot be found in the pertrained model. And some parameters like "heads.bnneck.weight" which contained in the pertrained model are not used.
I guess "heads.bnneck.weight" contained in the pretrained model is the "heads.bottleneck.0.weight" needed in the model. And I rename the parameters in the pretrained model, but the evaluation results is lower than those reported in the MODEL_ZOO. Did you encounter the same problem?


Missing effective area suggested units

Hi all,
I just realized in the specs we don't suggest any unit for the effective area (unlike all the rest IRFs).
Shall we suggest to use cm^2? I can do the change in a second if people agree.

@TarekHC - Yes, we should mention the unit.
I checked one AEFF file from HESS, from MAGIC and from CTA, and they all had "m^2" as unit. (and not "cm^2" as you suggest)
In Gammapy we take the unit from the FITS header, i.e. don't rely an using "m^2" or "cm^2":
https://github.com/gammapy/gammapy/blob/cebedcf1f630e2ae84f4f294157951dc759dcefc/gammapy/irf/effective_area.py#L399
@jknodlseder - Can you confirm that Gammalib / ctools expects "m^2" for AEFF?

Also, the example IRF files we have in the spec should be updated to have a unit:
https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/blob/master/source/irfs/full_enclosure/aeff/create_example_file.py
@TarekHC - I think you wrote that? Note that for Table you can assign quantities as columns and then the unit will be written to the FITS header. Example: https://github.com/gammapy/gammapy/blob/master/examples/example_write_irf.py
Would you be willing to update the scripts / example files for IRFs as well? If no, I could put that on my TODO list.

I checked one AEFF file from HESS, from MAGIC and from CTA, and they all had "m^2" as unit. (and not "cm^2" as you suggest)

Indeed. I checked later and I saw the m^2. I was lazy to update the issue... :)

Would you be willing to update the scripts / example files for IRFs as well? If no, I could put that on my TODO list.

Sure, no problem. I can do that.

Just in case the discussion on area units is still open: I vote for "nano-acres"! (Wikipedia)

Just in case the discussion on area units is still open: I vote for "nano-acres"! (Wikipedia)

:D   I really loved the Power as "Pirate Ninja" unit...


Generator CDN API throwing 401 Unauthorized error for jspm.system provider

I am trying to generate import map using the CDN API using "jspm.system" provider. Few days ago it was working, but now it is throwing 401 Unauthorized error! Please check the screenshot attached.
** Please note that it is working for other providers like "unpkg"!

Thanks for posting, this was due to an overloaded subservice combined with Google for some reason caching error responses in the cloud run pool, affecting some requests. I've expanded the service capacity and am looking into why the health check failed. This should be working now though.


Partial algebras, second try

This starts a reimplementation of #341, with the following choices:

the partial algebra hierarchy will be separated from the standard hierarchy
the partial algebra hierarchy will be implemented using Nullbox
implicit conversions will be provided from regular to partial algebras
the Nullbox extractor has been adapted for Scala 2.10 (at the price of Option instantiations for 2.10 only)

@non : there is still one problem. The partial and regular algebras share two methods: .isId and .inverse; so they have to use the same enrichment Ops class to provide these methods.
There are few options here:

either have both Group and Groupoid inherit traits that provide the methods needed (this is the option I choose here, with two traits HasIsId and HasInverse), but they would have to be provided on non/algebra as well,
either have a trick in the implicit conversion to XXXOps class, for example using union types

What do you think ?

Also pinging @tixxit

Arrgg, Scala 2.10 needs its own hashCode and equals.

Note: the HasIsId and HasInverse split is needed because otherwise, the Group -> Groupoid conversion is kicking in when calling (a: Group[A]).inverse, and then there are problems ambiguous implicits. Another advantage is having a single typeclass per enriched method.
There are two other solutions:

making the Group -> Groupoid implicit conversion low-priority, but how robust is it ?
call the isId and inverse methods partialIsId and partialInverse, even if they always suceed (by the algebraic laws)

2nd note: I don't have a PartialMonoid instance in this PR, because I did not find a use case for it either in my own work or in the mathematical litterature.
Thus, the partial algebras are Semigroupoid and Groupoid.

Completed partial algebraic structures.

Hey this looks great! I think there are just three issues in this PR:

We should probably come up with a better name than Nullbox. I just slapped that name on the idea and I worry that it is not very clear. Any suggestions? Opt[_]?

It is possible we will later need to remove HasInverse and HasIsId and just duplicate the Ops classes. Once algebra is published and we start porting Spire to depend on it we'll be constrained by its structure. I don't think this issue blocks the PR but just wanted to let you know.

There was a minor issue with using == instead of === in the tests that I commented on.

I could also imagine using ScalaCheck to test Nullbox[_] as well but honestly the tests right now seem good, so I'm happy to worry about that later and merge this sooner, once we resolve (1) and (3).
What do you think @tixxit ?

Agree with Nullbox[_] becoming Opt[_]; I did a quick Google search, the name is already used in a book example for the exact same class, an option-like derivative wrapping a reference. Waiting for @tixxit approval.
I will have a try without, by demoting the Group -> Groupoid implicit conversion to a lower priority using traits.
For a while, I did not have a Eq[Nullbox[_]] instance; thanks for spotting the issue!

Opt[_] is good.

Looks great! I'm merging now. Thanks for all your hard work navigating the murky waters of this PR, @denisrosset.


Moving components doesn't trigger import updates

Hello, first of all, thanks for the awesome extension!
System info

OS: Linux Mint 19.3
VS Code version: 1.71.2
Volar version: v0.40.13
Vue 3 / Typescript / SFC

Issue
Recently I noticed that while moving my components (SFC), other components that relies on them didn't get updated to match the new paths. I have tested both Takeover mode (with VS Code's version TS, which right now is 4.8.2) and without Takeover, both gives the same result.
For example, using Vue's startup project, where we have this structure:
src/
|- components/
    |- HelloWorld.vue
|- App.vue

and with App.vue importing HelloWorld.vue:
import HelloWorld from './components/HelloWorld.vue'

if I move HelloWorld.vue to the src folder, giving me:
src/
|- components/
|- HelloWorld.vue
|- App.vue

App.vue keeps the import as ./components/HelloWorld.vue, which is an error. The dialog asking if I want it to update imports doesn't show up at all.
Additional info
Old versions:
I tried downgrading to older versions of Volar and I noticed that it works fine on v0.39.5, the dialog shows up and once I accept, it update the imports. Upgrading to v0.40.0 and testing a few version between it and v0.40.13 (current) failed in every case.
Project setup:
If it helps, I created the project using vue cli tool with the following settings:
» npm init vue@latest

Vue.js - The Progressive JavaScript Framework

✔ Project name: … test
✔ Add TypeScript? …  Yes
✔ Add JSX Support? … No
✔ Add Vue Router for Single Page Application development? … Yes
✔ Add Pinia for state management? … Yes
✔ Add Vitest for Unit Testing? … Yes
✔ Add Cypress for End-to-End testing? … No
✔ Add ESLint for code quality? … Yes
✔ Add Prettier for code formatting? … No

Is it fixed? I have 2 files for a component: .vue and .ts in one folder. When i move folder, imports are not updated

How to fix this?

@felixele217 do you use SFC? For me, this bug occurred when I split components into .vue and .ts files. I tried SFC once and it worked fine.

I was advised to use WebStorm, which has better Vue support, but I couldn't quit vscode


ssd-mobilenetv2 takes some time.

@dusty-nv Every time I run detectnet it takes forever to start running because I think ssd-mobilenetv2 is trying to load. Even though I have ran the script many times it still takes forever to load. Is there a reason or fix to get out of the long wait time

Hi @DigeSegun, the first time a new model is loaded (or when that model has changed), TensorRT optimizes the model and saves the optimized engine to disk.   It should then start up quickly the next time.   After the program runs, does it save a .engine file in your model's folder?

@dusty-nv I don't believe it saves an .engine file. How long goes optimization usually take I've ran the script all the way through multiple times

@dusty-nv [TRT]    network profiling complete, saving engine cache to /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.1.1.8201.GPU.FP16.engine
[TRT]    failed to open engine cache file for writing /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.1.1.8201.GPU.FP16.engine

[TRT] failed to open engine cache file for writing /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.1.1.8201.GPU.FP16.engine

Are you running the jetson-inference container?   If not, did you run sudo make install when you built jetson-inference from source?
You might want to try:   sudo chown -R $USER /usr/local/bin/networks

@dusty-nv I am running from source and I believe I did do a sudo make install. I just tried the sudo chown command and this is my output now
[TRT]    failed to open engine cache file for writing /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.1.1.8201.GPU.FP16.engine
[TRT]    device GPU, completed saving engine cache to /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.1.1.8201.GPU.FP16.engine
[TRT]    saving model checksum to /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.sha256sum
[TRT]    sha256sum /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff | awk '{print $1}' > /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.sha256sum
[TRT]    failed to save model checksum to /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff.sha256sum
[TRT]    device GPU, loaded /usr/local/bin/networks/SSD-Mobilenet-v2/ssd_mobilenet_v2_coco.uff


ARTEMIS-262 Fix Bridge OOM exception

Netty 4.x uses pooled buffers.  These buffers can run out of memory when
transferring large amounts of data over connection.  This was causing an
OutOfMemory exception to be thrown on the CoreBridge when tranferring
large messages.  Netty provides a callback handler to notify listeners
when a Connection is writable.  This patch adds the ability to register
connection writable listeners to the Netty connection and registers the
relevant callback from the Bridge to avoid writing when the buffers are
full.

@clebertsuconic @jbertram Please wait for an Ack from @andytaylor before merging this patch.


Control truncation of long lines

Truncated fields are hard to read.
Some other output modes that might be helpful:

A vertical listing (like \gx in psql) option?
Opinionated formats, like -d long or -d brief?

Hi @groner !
Finally getting around to looking into this. Could you give some examples? Would also be nice to know how many columns you're typically working with.