Clean architecture example

Copy of the PR for the master version. The goal is to add an example on how to use Express with the Clean Architecture approach

I'm getting an "Unexpected identifier" error up to Node v 6.17. Installing that version of node locally I'm not able to make tests run. Could someone help me? Or maybe we can publish the ES5 version that works fine and add a comment that tells users to use ES6 classes instead

Hi @dougwilson could we merge the pr? Or do you have other advice to improve the example? :)

Thanks for your work! I can't help but notice this example seems very similar to our mvc example, splitting the apps into sets of object operations by file and such. What are the differences this example does from the mvc one?

Thanks for your work! I can't help but notice this example seems very similar to our mvc example, splitting the apps into sets of object operations by file and such. What are the differences this example does from the mvc one?

Good question! When I was studying the clean architecture I made myself the same question. The answer is subtile. We can say that the Clean Architecture is a set of principles that you have to follow when you create the architecture. You can build really complex architectures like this (but I wanted to keep the example simple).
MVC (for some aspects) could be seen as a subset of Clean Architecture but the use of MVC doesn't guarantee the respect of all the Clean Architecture rules.
You can find more in this topic.

Hi @import-brain, sorry for the ping but I don't know how to progress with this PR. Do you think it could be merged or are required other approvals?

Hi @import-brain, sorry for the ping but I don't know how to progress with this PR. Do you think it could be merged or are required other approvals?

No worries :)! I do not have PR merge permissions on this repo. @dougwilson, what do you think?

Sorry about that, thanks for the ping! So I guess reading your response there, I'm just really confused. Does "Clean Architecture" mean something? Is there a link to where that is defined? I thought that was just a term you were using to describe your example and didn't mean anything further :)

Sorry about that, thanks for the ping! So I guess reading your response there, I'm just really confused. Does "Clean Architecture" mean something? Is there a link to where that is defined? I thought that was just a term you were using to describe your example and didn't mean anything further :)

Hi, sure! Clean Architecture is the name of the book by Robert C. Martin (the same author of the book Clean Code) and describes a set of rules and best practices to create scalable architectures. You can find the book on Amazon and by searching onine you can find other resources releated :)

Sorry about that, thanks for the ping! So I guess reading your response there, I'm just really confused. Does "Clean Architecture" mean something? Is there a link to where that is defined? I thought that was just a term you were using to describe your example and didn't mean anything further :)

Hi  @dougwilson i think the main difference between this example and the mvc is the usage of that pattern, this example in my opinion is a pure backend microservice example which expose some api (a crud in this case).
The mvc example looks like server side rendering, it expose some url in GET and return an html template to render.
Also if we watch in deep, in this pull request we can see an Object Oriented way (obviusly with common js compatibility 😃) but that is the idea behind it.

HI @dougwilson! Sorry for the ping XD. I would really appreciate a feedback on the PR if you have time. I have followed your advice. Now I think everything is correct :)

Hi @dougwilson  :) I see that the RR is still pending. Would you consider merging it? :)

Hi @dougwilson, do you think is worth merging it? If not, I can just close the PR to keep the repo as clean as possible :)


⚠ Spryr has degraded performance

In 8aa361d, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 8429 ms

Resolved: Spryr performance has improved in 097c785 after 47 minutes.


zipl: error when title is not the first field in BLS file

following error occurs when the title entry is not the first line in a BLS file:
Error: Config file '/root/zipl.conf': Line 0: keyword 'image' not allowed in section 'defaultboot'
zipl.conf:
[defaultboot]
defaultauto
prompt=1
timeout=5
target=/boot

BLS file:
initrd /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/initramfs-5.0.9-200.fc29.s390x.img
title Fedora 29 (CoreOS preview) 29 (ostree)options
ostree=/ostree/boot.1/fedora-coreos/c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/0 ignition.firstboot
linux /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/vmlinuz-5.0.9-200.fc29.s390xversion 1

zipl uses the BLS snippet title field to create a new menu entry, when in BLS snippet the initrd field is before title, zipl wrongly assumes that initramfs is for the only section it has defined (defaultboot).
if title before initrd and linux, it should work, since by the time it parses the initrd and linux, it would already created a new section for 'Fedora 29 (CoreOS preview) 29 (ostree)'.

BLS file:
initrd /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/initramfs-5.0.9-200.fc29.s390x.img
title Fedora 29 (CoreOS preview) 29 (ostree)options
ostree=/ostree/boot.1/fedora-coreos/c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/0 ignition.firstboot
linux /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/vmlinuz-5.0.9-200.fc29.s390xversion 1

there are some paste error
whatever the  correctly worked one is :
title Fedora 29 (CoreOS preview) 29 (ostree)
version 1
initrd /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/initramfs-5.0.9-200.fc29.s390x.img
options ostree=/ostree/boot.1/fedora-coreos/c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/0 ignition.firstboot
linux /ostree/fedora-coreos-c2182f8fe3ba1f8ffe5dbc9ee89503637e06a7e1d7a0e12b50d4d0d4665c063e/vmlinuz-5.0.9-200.fc29.s390x

We could pretty easily change ostree for this if it helps; what exactly is zipl expecting here?  title, linux, options, initrd in that order?

We could pretty easily change ostree for this if it helps; what exactly is zipl expecting here? title, linux, options, initrd in that order?

@cgwalters I think the only constraint is that the title must be the first field. Since as @zhengxiaomei123 mentioned, zipl uses the title field to add a new IPL section that will be the one associated with the other fields in the BLS snippet.

@cgwalters @martinezjavier : and also no blank line in loader entries file or else zipl will complain.

But I think it's zipl's business to peacefully discard blank lines and accept any order of loader entries file.

Just realized blank line issue seems to be fixed in https://github.com/ibm-s390-tools/s390-tools/commit/53f166673d0a338822362f500da4fa33df6c3296 but not backported to F29/F30 yet.

It seems that the scan code makes an implicit assumption that title is always on the top. I would add an early explicit check for this (to make sure that the title is on the top). If the check is failed, then return an error with a message that "title is not on the top", which is a hint for user to edit BLS file properly.

There is no real need to have the title field in the first position, also the BLS documentation does not say this. So I would prefer to have the scanner sort the fields properly.

"Title" is something which is always on the top - I don't think that it needs to be documented . So, I would first start from identifying a real need for having it not on the top (just because it will add a complexity to the implementation).


AbstractConfigTest.appendAnnotation not stable in Java 10

line 270:
        TestCase.assertEquals("<dubbo:annotation filter=\"f1, f2\" listener=\"l1, l2\" />",
                annotationConfig.toString());

Sometimes failed, the error is:
junit.framework.ComparisonFailure:
Expected :<dubbo:annotation filter="f1, f2" listener="l1, l2" />
Actual   :<dubbo:annotation listener="l1, l2" filter="f1, f2" />

org.apache.dubbo.config.AbstractConfig#toString use reflection to iterate the methods, according to the java doc, the elements in the returned array are not sorted and are not in any particular order.
I am afraid that this issue will affect all Java versions.

#2097 has fixed this problem.


Missing fuzzy-match element in completion suggestion pop up

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Announcement

[X] I have checked Breaking change announcement.

Minimal reproducible full config
function M.config()
  local present, cmp = pcall(require, "cmp")
  if not present then
    return
  end

  local present, luasnip = pcall(require, "luasnip")
  if not present then
    return
  end

  -- select_item detects the order in which elements are shown
  -- and keeps the same motion.
  local select_item = function(direction, behavior)
    return function(fallback)
      if cmp.visible() then
        if cmp.core.view.custom_entries_view:is_direction_top_down() then
          ({ next = cmp.select_next_item, prev = cmp.select_prev_item })[direction]({ behavior = behavior })
        else
          ({ next = cmp.select_prev_item, prev = cmp.select_next_item })[direction]({ behavior = behavior })
        end
      else
        fallback()
      end
    end
  end

  cmp.setup({
    sources = {
      { name = "nvim_lsp" },
      { name = "luasnip" },
      { name = "buffer",
        option = {
          -- keyword_pattern = [[\k\+]],
	  keyword_length = 5,
        },
      },
      { name = "nvim_lua" },
      { name = "path" },
    },

    completion = {
      completeopt = 'menu,menuone,noinsert'
    },

    preselect = cmp.PreselectMode.None,

    view = {
      entries = { name = 'custom', selection_order = 'near_cursor' }
    },

    window = {
      completion = {
        border = CUSTOM_BORDER,
	winhighlight = "NormalFloat:Normal,CursorLine:Visual"
      },
      documentation = {
        border = CUSTOM_BORDER,
	winhighlight = "NormalFloat:Normal,CursorLine:Visual"
      },
    },
    snippet = {
      expand = function(args)
        luasnip.lsp_expand(args.body)
      end,
    },

    formatting = {
      format = function(entry, item)
        item.kind = string.format("%s %s", kind_icons[item.kind], item.kind)
	item.menu = ({
          buffer = "[Buffer]",
	  path = "[Path]",
          nvim_lsp = "[LSP]",
          -- nvim_lsp_signature_help = "[Signature]",
          luasnip = "[Snip]",
          nvim_lua = "[Lua]",
        })[entry.source.name]

        return item
      end,
    },

    mapping = cmp.mapping.preset.insert {
      ["<C-j>"] = select_item('next', cmp.SelectBehavior.Select),
      ["<C-k>"] = select_item('prev', cmp.SelectBehavior.Select),
      ["<C-d>"] = cmp.mapping.scroll_docs(4),
      ["<C-u>"] = cmp.mapping.scroll_docs(-4),
      ["<C-Space>"] = cmp.mapping.complete(),
      ["<C-e>"] = cmp.mapping.close(),
      ["<CR>"] = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Insert, select = true }),
      ["<Tab>"] = cmp.mapping(function(fallback)
	if luasnip.expand_or_jumpable() then
          luasnip.expand_or_jump()
	else
	 fallback()
	end
      end),
      ["<S-Tab>"] = cmp.mapping(function(fallback)
	if luasnip.jumpable(-1) then
          luasnip.jump(-1)
	else
	 fallback()
	end
      end),
    },

  })

Description
No items that should appear in autocompletion actually appear. In the example that I mention below, VSCode pops up multiple suggestions but Neovim does not. Would like to know if it is possible to replicate the same functionality in nvim-cmp.
Steps to reproduce
1.- Paste the following golang code snippet into a file:
import (
	"net"
	"os"
)

func main() {
	Unit
}

2.- Inside the main function, start typing Unit. No pop up is triggered because there is no suggestions.

3.-  Typing the same value Unit in VSCode suggests multiple options:

Expected behavior
A pop up with the very same suggestions that are shown in VSCode when typing the same word.
Actual behavior
No suggestion at all when typing Unit.
Additional context
VScode and Neovim are using the same version of gopls.

You can use
cmp.setup {
  matching = {
    disallow_partial_fuzzy_matching = false
  }
}

Thanks for your reply and for implementing this new option.


RC Screen Space Reflection (SSR)

Hi Stefan
Maybe you are waiting for each RC to go into full release before including everything, but you may know there is also an option for Screen Space Reflection (SSR) level within gfx config.
Be nice if you could build that into the settings available.
No major thing for the moment though ;-)

Hey Andy, thanks for the hint! I thought it's a little early to add that. I'm pretty sure they will add and/or refine the settings quite a lot until the next stable build. I guess other Screen Space calculated features are not that far aswell(e.g. SSAO).

Makes perfect sense, going to be interesting to see how all these new things work, and what sort of impact they will have on comfortably running it in Vr ;-)


update graph and grafting

Description

Update grafting params to index #575
Bump graph packages to have indexer hints i.e. pruning defined at the Manifest file

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[x] Other

Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas

I've checked that build and lint works locally


MultiSelectBottomSheetField how to create checkbox select all

@notufure Hello,
Currently this feature is not included in the widget, you'd have to manage it from outside but I'd like to add a bool parameter checkAllOption that will show a check all checkbox when true.

now i am unable to do select all

can you resolve this issueu

Please let me know if this feature is added.
Many thanks

Hi! I can implement this feature.

Hi! I can implement this feature.

Please let me know if it's done!

Hi! I can implement this feature.

Please let me know if it's done!

Already done! #122

I saw that, but it's not in package... =(
But thanks a lot for implementing this!

@CHB61 Thanks for build this package.
Please review this PR. :)


Area chart with x,y and color throws error

The following spec throws an error in the console and breaks the code.
{
  "marktype": "area",
  "encoding": {
    "x": {"name": "Cylinders","type": "O"},
    "y": {"name": "Acceleration","type": "Q"},
    "color": {"name": "Miles_per_Gallon","type": "Q"}
  },
  "config": {"singleHeight": 400,"singleWidth": 400,"largeBandMaxCardinality": 20},
  "data": {"url": "data/cars.json"}
}

Can be reproduced with any field for "color".

What version are you using?

I used polestar online demo.
On Aug 19, 2015 6:18 PM, "Dominik Moritz"<EMAIL_ADDRESS>wrote:

What version are you using?
—
Reply to this email directly or view it on GitHub
https://github.com/uwdata/polestar/issues/310#issuecomment-132804952.

I see. There is a bug in the area code. Moved to https://github.com/uwdata/vega-lite/issues/560


How to Keep Listening to events after crawler is stopped

Hi,
I am doing a lot of async work inside the fetchComplete event. Unfortunately when the crawler stops, All the processes inside the event also dies. Is there any way to let the crawler complete the tasks in events before closing everything at once?

Hi @coderingo! The node process shouldn't terminate before all work is done, including any async operations in progress, and simplecrawler doesn't do anything to exit the process either. Could you provide a code sample demonstrating your problem?

Closing this issue since it hasn't been active in a while. Feel free to re-open it if you're still having trouble, @coderingo!


No module named 'geotransformer.ext'`?

I tried to run test.py of 3Dmatch, but there is something wrong. Where is the file geotransformer.ext?
CUDA_VISIBLE_DEVICES=0 python test.py --snapshot=~ -benchmark=3DMatch
Traceback (most recent call last):   File "test.py", line 17, in <module>     from dataset import test_data_loader   File "/workspace/3dBuild_workspace/GeoTransformer/experiments/geotransformer.3dmatch.stage4.gse.k3.max.oacl.stage2.sinkhorn/dataset.py", line 2, in <module>     from geotransformer.utils.data import (   File "/workspace/3dBuild_workspace/GeoTransformer/geotransformer/utils/data.py", line 6, in <module>     from geotransformer.modules.ops import grid_subsample, radius_search   File "/workspace/3dBuild_workspace/GeoTransformer/geotransformer/modules/ops/__init__.py", line 1, in <module>     from geotransformer.modules.ops.grid_subsample import grid_subsample   File "/workspace/3dBuild_workspace/GeoTransformer/geotransformer/modules/ops/grid_subsample.py", line 4, in <module>     ext_module = importlib.import_module('geotransformer.ext')   File "/opt/conda/lib/python3.7/importlib/__init__.py", line 127, in import_module     return _bootstrap._gcd_import(name[level:], package, level) ModuleNotFoundError: No module named 'geotransformer.ext'

How to deal?

How to deal?
you need build it in " setup.py "


[bn] Localize training / index.html

Fixes Issue : https://github.com/kubernetes/website/issues/44993
Related PR : https://github.com/kubernetes/website/pull/45009
Tracking Issue: https://github.com/kubernetes/website/issues/31677

/lgtm


feat(TDKN-127): add format properties provider

Add FormatPropertiesProvider

Add DefinitionRegistry injection for properties

Add post deserialization process for definition registry injection

Add tests

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Add FormatPropertiesProvider which gets possible format definitions/properties from definition registry.
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://jira.talendforge.org/browse/TDKN-127

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:


AWS Perspective VPC stack fails to create.

Followed the procedure to set up AWS Perspective, from here:
https://docs.aws.amazon.com/solutions/latest/workload-discovery-on-aws/automated-deployment.html
I've configured it with the default options, except for modifying

The stack creation works, except for the following component:
AWS Perspective VPC Stack

The status is CREATE_FAILED and the reason is the following:
The following resource(s) failed to create: [FlowLogGroup].

Any advice on what could be the issue?

I've just tried it in another region, same result, but the error message changed:
The following resource(s) failed to create: [ElasticIP0].

The IP error is probably due top service quotas, the default number of EIP addresses in an account is only 5. I've not seen the flow log error before, there should be more detailed error in the VPC stack in the cfn console.


Add names to a few declaration questions

Add names to the questions for the summary page and to support testing.

These should be displayed on the declaration overview page in the summary table I think (pretty sure 'name' is used rather than 'question'?)

At least, I think 'name' will be used in preference over 'question' if it exists.

Of course... :) I will chat to @andymcaleer

servicesDoNotInclude.yml

It would be good to change the name from:

'Other characteristics of your service'
to:
'Services in scope for G-Cloud'

Add a ':' after include

Change: 'you are' to 'you're'.

servicesHaveOrSupport.yml

Change: 'you are' to 'you're'.

I have some reservations about the names but :+1: to keep things moving.

Cool. Cath and I need to go through the whole journey in the app so maybe
we can fix then. Would be good to either run through it with you or have a
chat to make sure we know what your main worries are.
On Mon, Feb 27, 2017 at 2:35 PM, Kevin Keenoy<EMAIL_ADDRESS>wrote:

I have some reservations about the names but 👍 to keep things moving.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alphagov/digitalmarketplace-frameworks/pull/390#issuecomment-282737101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AISwf7XHoNBtdNAd1Ezrg7NlQFStS0soks5rgt8_gaJpZM4MM3ww
.


Updated for App proxy screenshot and steps

Learn Build status updates of commit 7c2f40e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/saas-apps/ms-confluence-jira-plugin-adminguide.md
:warning:Warning

Details

articles/active-directory/saas-apps/ms-confluence-jira-plugin-adminguide.md

Line 125, Column 52: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/app-proxy/what-is-application-proxy' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 125, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/app-proxy/what-is-application-proxy' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Another PR 99549 was raised to address these changes. Closing this PR.


Row Delete and enhancement for date picker and readme

Solving issue #3.
Date Picker outlook and readme enhanced.

@kavimaluskam looks like the travis build is failing. if you run npm t -- --fix and commit it should fix most of those issues. You might have to fix some by hand though.

@emkay Sorry that i didnt pay attention to travis building issue. You may check the update.

@kavimaluskam It looks like there are still a couple of errors:
https://travis-ci.org/emkay/material-ui-table-edit/jobs/239323815


Missing module import? pybind11 not found during installation

I created a new virtual environment using venv and then installed the requirements file (pip install -r requirements.txt). It failed to install after looking for pybind11.
(.venv) (23:32) ubuntu@host:/var/www/election $ python -m pip install -r requirements.txt
Collecting tabulate==0.8.7 (from -r requirements.txt (line 1))
  Using cached https://files.pythonhosted.org/packages/c4/f4/770ae9385990f5a19a91431163d262182d3203662ea2b5739d0fcfc080f1/tabulate-0.8.7-py3-none-any.whl
Collecting pysimdjson==3.1.0 (from -r requirements.txt (line 2))
  Using cached https://files.pythonhosted.org/packages/d4/bc/3e26ecd51f2f697f6e5cf7844e921b04e92419cd2d3674ff46611bd816f6/pysimdjson-3.1.0.tar.gz
Collecting GitPython==3.1.11 (from -r requirements.txt (line 3))
  Using cached https://files.pythonhosted.org/packages/24/d1/a7f8fe3df258549b303415157328bfcc63e9b11d06a7ad7a3327f3d32606/GitPython-3.1.11-py3-none-any.whl
Collecting gitdb<5,>=4.0.1 (from GitPython==3.1.11->-r requirements.txt (line 3))
  Using cached https://files.pythonhosted.org/packages/48/11/d1800bca0a3bae820b84b7d813ad1eff15a48a64caea9c823fc8c1b119e8/gitdb-4.0.5-py3-none-any.whl
Collecting smmap<4,>=3.0.1 (from gitdb<5,>=4.0.1->GitPython==3.1.11->-r requirements.txt (line 3))
  Using cached https://files.pythonhosted.org/packages/b0/9a/4d409a6234eb940e6a78dfdfc66156e7522262f5f2fecca07dc55915952d/smmap-3.0.4-py2.py3-none-any.whl
Installing collected packages: tabulate, pysimdjson, smmap, gitdb, GitPython
  Running setup.py install for pysimdjson ... error
    ERROR: Command errored out with exit status 1:

      ...

      File "/home/ubuntu/Python-3.8.2/Lib/distutils/ccompiler.py", line 565, in compile
        self._setup_compile(output_dir, macros, include_dirs, sources,
      File "/home/ubuntu/Python-3.8.2/Lib/distutils/ccompiler.py", line 341, in _setup_compile
        pp_opts = gen_preprocess_options(macros, incdirs)
      File "/home/ubuntu/Python-3.8.2/Lib/distutils/ccompiler.py", line 1076, in gen_preprocess_options
        pp_opts.append("-I%s" % dir)
      File "/tmp/pip-install-68_2tm7_/pysimdjson/setup.py", line 19, in __str__
        import pybind11
    ModuleNotFoundError: No module named 'pybind11'
    ----------------------------------------
ERROR: Command errored out with exit status 1: /var/www/election/.venv/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-68_2tm7_/pysimdjson/setup.py'"'"'; __file__='"'"'/tmp/pip-install-68_2tm7_/pysimdjson/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-tbebpj0s/install-record.txt --single-version-externally-managed --compile --install-headers /var/www/election/.venv/include/site/python3.8/pysimdjson Check the logs for full command output.

After installing the module manually, everything went smoothly:
(.venv) (23:32) ubuntu@host:/var/www/election $ python3 -m pip install pybind11
Collecting pybind11
  Downloading pybind11-2.6.0-py2.py3-none-any.whl (187 kB)
     |████████████████████████████████| 187 kB 13.8 MB/s
Installing collected packages: pybind11
Successfully installed pybind11-2.6.0

(.venv) (23:34) ubuntu@host:/var/www/election $ python -m pip install -r requirements.txt
Requirement already satisfied: tabulate==0.8.7 in ./.venv/lib/python3.8/site-packages (from -r requirements.txt (line 1)) (0.8.7)
Collecting pysimdjson==3.1.0
  Downloading pysimdjson-3.1.0-cp38-cp38-manylinux2014_x86_64.whl (2.3 MB)
     |████████████████████████████████| 2.3 MB 9.6 MB/s
Collecting GitPython==3.1.11
  Using cached GitPython-3.1.11-py3-none-any.whl (159 kB)
Collecting gitdb<5,>=4.0.1
  Using cached gitdb-4.0.5-py3-none-any.whl (63 kB)
Collecting smmap<4,>=3.0.1
  Using cached smmap-3.0.4-py2.py3-none-any.whl (25 kB)
Installing collected packages: pysimdjson, smmap, gitdb, GitPython
Successfully installed GitPython-3.1.11 gitdb-4.0.5 pysimdjson-3.1.0 smmap-3.0.4

This is with Python 3.8.2.

Issues with python dependency installation are not really something we can fix, and is out of scope.

Quick pointer: From when I got this working you could install it directly, it wasn't captured in the simdjson deps for some reason.

What do you mean it is out of scope? Why not add the dependency to the requirements file? I did that and it worked as expected.

Huh, ideally this would be an issue with simdjson then? Sorry for closing so quick we'll look into adding it for now.

diff --git a/requirements.txt b/requirements.txt
index 82fb198..483d3b1 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,3 +1,4 @@
 tabulate==0.8.7
+pybind11==2.6.0
 pysimdjson==3.1.0
 GitPython==3.1.11

That worked without any issues.

This should only happen if you have an old version of pip. Pybind11 is only required when building from source, and binary wheels are distributed for most platforms and interpreter versions. However, since this has happened a few times now, I'll probably bundle pybind.

I was using the latest version of pip in python 3.8.2 for whatever that's worth.


Update manifests/e/Eugeny/Tabby/1.0.197/Eugeny.Tabby.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels


Cleanup imports

Now that all of the types are deduplicated,
we can clean up the imports so they're not just all over the place.
I also added spacing between all of the items now.
In cleaning up the imports in the non-rav1d crate code, I realized there was still a bunch of duplication left and extern "C" imports of rav1d types, so those are now all removed and converted to use rav1d::s.

I think you might have extra commits in here, it looks like the commits for deduplicating Dav1dDSPContext and friends are showing up in this PR.

I think you might have extra commits in here, it looks like the commits for deduplicating Dav1dDSPContext and friends are showing up in this PR.

Hmm, yeah it seems like it got messed up somehow.  I'll figure it out.

@randomPoison, should be fixed now.


(GH-1211) Return Target object with plan function add_facts

In order to be more consistent with the other set_* plan methods for setting target data, this commit updates the add_facts function to return a Target where previously a Hash of the updated facts was returned. Given this is a breaking change it is gated with the future flag.
Closes https://github.com/puppetlabs/bolt/issues/1211

CLA signed by all contributors.


Ignore group order in test_struct_groupby_count

Contributes to #2406
Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

It may not be the entire fix but the test_struct_groupby_count fails when run manually on dataproc and locally using #2410 , and succeeds with this PR.


Added semantics label to widgets

Closes https://github.com/EnsembleUI/ensemble/issues/1308

how to use this?


No explenation of newly introduced term

WINRT_ASSERT macro used in the last example and it was not commented at all, nor any link was provided.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b97f1e3-af78-453e-6140-0fd37460d6c3
Version Independent ID: e74f6cdb-2ac4-5a4d-8f73-0e97958f997b
Content: Boxing and unboxing scalar values to IInspectable with C++/WinRT - Windows UWP applications
Content Source: windows-apps-src/cpp-and-winrt-apis/boxing.md
Product: uwp
Technology: platform
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Thanks for filing this issue, @sm-sabat. You raise a good point. Before the end of the day, I'll update the docs with more info.
WINRT_ASSERT is a macro definition, and it expands to _ASSERTE.
Thanks!
Steve


feat: add definition list editor component

Summary

Hugo's Goldmark markdown parser supports definition lists - this component provides a way to edit them in Netlify CMS without editing raw values.
Test plan

Tests added.

I had an issue when testing it locally and creating a new definition list for an empty entry.
Default values are inferred from the fields list and always return a map, while the definition list expects a default value of an array. Not sure my approach is the best one, but couldn't think of a better way to do it atm.

FYI, tests are failing since matchAll is not supported in node 10. We can use this as an opportunity to remove the node 10 build.

Good catch, can't believe I didn't try creating a new definition list 🤦♂
This is another example of a need for widgets to manage their own default values - the code you updated is leftover from when all widgets were object widgets. I'd rather not surface defaultValues in the API, looking for other options now.

Doing this well requires a true inline mode for the markdown widget - if you can still create blocks (Eg., headers) through raw markdown, and the markdown widget still parses that markdown, that makes this editor component pretty unstable. Defaults handling is another problem uncovered here - if widgets can't handle their own, then upstream entities like editor components have to patch together a way to provide them. Closing for now.


component/BookCard

Closes #33
Adds the BookCard component from the Figma design.

I'm not sure of the best way to pass images as props. If anyone has suggestions that would be amazing!

The image prop needs to be a URL, as we'll most likely be serving images from an s3/cloudinary bucket.
Put the images you want to use for storybook in: /public/assets/images/your-image.png then pass the url to the component.

The image prop needs to be a URL, as we'll most likely be serving images from an s3/cloudinary bucket.
Put the images you want to use for storybook in: /public/assets/images/your-image.png then pass the url to the component.

Ok will do. Will we be pulling the URL from the database in production?
The prop passed in is being used as the source URL, is that correct? If so, I'll just move the image used for Storybook as above.

Made the changes requested


Dependency Bug for Auth0-spa-sdk>=v1.7.0

After upgrading Auth0-spa-sdk to v1.7.0, gatsby fails to build with the response similar to this:
 ERROR

There was an error compiling the html.js component for the development server.

See our docs page on debugging HTML builds for help https://gatsby.dev/debug-html ReferenceError: Blob is not defined

 ^
  16 | //# sourceMappingURL=auth0-spa-js.production.esm.js.map
  17 |

  WebpackError: ReferenceError: Blob is not defined

  - auth0-spa-js.production.esm.js:15
    node_modules/@auth0/auth0-spa-js/dist/auth0-spa-js.production.esm.js:15:44578

  - auth0-spa-js.production.esm.js:15 Module.<anonymous>
    node_modules/@auth0/auth0-spa-js/dist/auth0-spa-js.production.esm.js:15:44698

  - gatsby-ssr.js:1 Module../gatsby-ssr.js
    gatsby-ssr.js:1:1

Step to reproduce

Change https://github.com/chanzuckerberg/dcp-prototype/blob/9d73bcf06be03567a85ab197a98bc085c14e5064/dcp_prototype/frontend/package.json#L8 to "@auth0/auth0-spa-js": "^1.7.0",
Run npm install
Run gatsby develop

Closed during triage with Arathi. @Bento007 - please re-open if this is still required.


Support MinChunkSizePlugin

What problem does this feature solve?
required by the test case webpack-test/configCases/plugins/min-chunk-size/
What does the proposed API of configuration look like?
The same as https://github.com/webpack/webpack/blob/9fcaa243573005d6fdece9a3f8d89a0e8b399613/lib/optimize/MinChunkSizePlugin.js#L1-L113

This issue has been closed, and I'm not sure if it still accepts PR. If it does, I can give it a try.

This issue has been closed, and I'm not sure if it still accepts PR. If it does, I can give it a try.

yeah it is acceptable


added ECS fargate spring boot free course

What does this PR do?
Added new free course that I've written on Deploying spring boot application on ECS fargate covering major areas in multiple articles series.
For resources
Description
Why is this valuable (or not)?
There are really minimal resources related to Spring Boot and ECS fargate deployments in the current stage.
How do we know it's really free?
All the tutorials are publically open and can access without any payment or registration to the website.
For book lists, is it a book? For course lists, is it a course? etc.
This is a course which includes 10 tutorials that covers all the major areas in deploying spring boot applications on ECS fargate.
Checklist:

[* ] Read our contributing guidelines.
[ *] Search for duplicates.
[* ] Include author(s) and platform where appropriate.
[ *] Put lists in alphabetical order, correct spacing.
[ *] Add needed indications (PDF, access notes, under construction).
[* ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

This resource has the appearance of a list of articles rather than a "course". I will accept it for now, but if you want it to stay, I suggest that you add navigation to the articles to make clear they are part of a course. ("next lesson", "previous lesson", "course outline", etc.)


Geolocation watchPosition update rate

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
  System:
    OS: macOS High Sierra 10.13.6
    CPU: x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
    Memory: 4.02 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.1.0 - /usr/local/bin/node
    npm: 6.0.1 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
  IDEs:
    Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.5.0 => 16.5.0
    react-native: 0.57.0 => 0.57.0
  npmGlobalPackages:
    create-react-native-app: 1.0.0
    react-native-cli: 2.0.1

Description
I'm making a generic google map (for now) with live user location:
navigator.geolocation.watchPosition(
  ({coords}) => {
    const {latitude, longitude} = coords

    this.setState({
      position: {
        latitude,
        longitude,
      },
      region: {
        latitude,
        longitude,
        latitudeDelta: 0.0922,
        longitudeDelta: 0.0421,
      }
    })
  },
  (error) => alert(JSON.stringify(error)),
  {enableHighAccuracy: true, timeout: 20000, maximumAge: 0, distanceFilter: 0}
)

However, the current position's update rate is very slow--at about 5-8 second/update.

I'm not entirely sure if this is a bug or an expected behavior, but I've built a similar app using ionic + google map javascript api and the update rate is real-time, so I don't think this 5-8 second/update rate is normal.
Reproducible Demo
Please check out my issue branch to reproduce the app/bug.

As I’m digging around, looks like the enableHighAccuracy option only operates for a few seconds before it sets itself to false. I can get accurate returns from watcPosition including heading, speed, and accuracy if I open other map apps such as Google Maps and iOS’ Maps and jump back to my app.

How did you solve it?


Fix BN problem, it works with copy().

In current BN implementation, it assign new values to avg_mean and avg_var.
It causes a problem when you use copy() to make a new model for validation (as ImageNet example does).

LGTM, and I think this PR is important and should be merged asap.


TileLayer: change onViewportLoaded to onViewportLoad

Background
v8.0 API audit

Change List

TileLayer: onViewportLoaded -> onViewportLoad

Coverage decreased (-0.01%) to 83.08% when pulling d4473d5957d4fc3acb6d4eba7d08e088fc012428 on xx/tile into c7b1b9ec720b0b8cfcb1f978aba828a1307c1d22 on master.


Excessive Training Time

It takes about two days to train a model on the GPU. Is this normal? How can I shorten the training time? Thank you for your help.

bro,how can you fix "Unkonwn command line flag 'cfg'.Did you mean: cfg_path"?.Thanks for your help

bro,how can you fix "Unkonwn command line flag 'cfg'.Did you mean: cfg_path"?.Thanks for your help


Move helpers into class

As a dev,
I want the toPath and prefixed extensions to be namespaced,
so that I don't accidentally use them elsewhere in my app.
Instead of using the toPath and prefixed extensions, allowing them to "leak" into the rest of the application code, these should only be available when constructing a route. Put them in the base route class?

Instead of using the toPath and prefixed extensions, allowing them to "leak" into the rest of the application code, these should only be available when constructing a route. Put them in the base route class?

One suggestion was to use a method to join the path segments using a spread or ...args argument, similar to JS.


Stop using deprecated props for Dropdown components

Description
We recently upgraded the minor version of Antd and some of the props that we are using are now deprecated. This PR fixes the Dropdowns.
Details
URL to issue
N/A
Link to staging deployment URL (or set N/A)
https://ui-ivababukova-ui28.scp-staging.biomage.net/
Links to any PRs or resources related to this PR

Integration test branch
master

Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.

Code updates
Have best practices and ongoing refactors being observed in this PR

[ ] Migrated any selector / reducer used to the new format.
[ ] All new dependency licenses have been checked for compatibility.

Manual/unit testing

[ ] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[ ] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[ ] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[ ] Relevant Github READMEs updated or no GitHub README updates required.
[ ] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

Based on the changes I've seen we shouldn't use Menu anymore, right? Is there anything else we shouldn't use?
Asking to make sure I am aware of what shouldn't be used anymore.

Based on the changes I've seen we shouldn't use Menu anymore, right? Is there anything else we shouldn't use?
Asking to make sure I am aware of what shouldn't be used anymore.

That is correct, this PR is not solving any current issues -- it is just fixing deprecations

Based on the changes I've seen we shouldn't use Menu anymore, right? Is there anything else we shouldn't use?
Asking to make sure I am aware of what shouldn't be used anymore.

@cosa65 you can still use the Menu Antd component, but not defined as overlay prop as part of a Dropdown


Update ESLint config

Coverage remained the same at 100.0% when pulling 5b2a1ffea7884380d17145d1645d52a44e75e037 on eslint into d49b695a1c6079a4c12f620338eff05fdd28180a on master.


GEODE-2644: Make Log4j2 appenders optional and support log4j2.xml

This PR was previously reviewed and committed as #2778. I reverted it to fix a bug in Log4jAgent#configure which was unconditionally updating the log level which resulted in commands such as validate-disk-store logging info level log statements. This is now fixed.
Fixes:

GEODE-2644: Provide ability to configure Geode appenders in log4j2.xml
GEODE-5789: gfsh command "change loglevel" only updates the cache.getLogger
GEODE-5637: Flaky: SingleHopClientExecutorWithLoggingIntegrationTest fails intermittently

High level description of these changes:

Follow log4j2 best practices
Make the Geode appenders configurable from log4j2.xml and pausable so that we can delete the majority of manipulating log4j2 core code. Geode used to dynamically add/remove appenders, now we pause/resume appenders that remain registered. Also, use log4j2 core testing JUnit Rule for integration tests involving a log4j2.xml config file.
Make log4j2 core dependency optional
Replace direct manipulation of singletons from Geode code with a simple internal LoggingSession API that makes log4j2 core optional and makes Geode logging/alerting pluggable for other logging engines such as Logback.

Performance:
New Appenders

Benchmark                                Mode  Cnt        Score   Error  Units
CacheLoggingBenchmark.infoLogStatement  thrpt        188672.952          ops/s
CacheLoggingBenchmark.putStatement      thrpt       1530589.450          ops/s

Old Appenders

Benchmark                                Mode  Cnt        Score   Error  Units
CacheLoggingBenchmark.infoLogStatement  thrpt        143247.397          ops/s
CacheLoggingBenchmark.putStatement      thrpt       1486630.605          ops/s

The IntegrationTestOpenJDK11 failures are unrelated to logging and are occurrences of GEODE-3506:
org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > startDeletesStaleControlFiles FAILED
    java.lang.IllegalStateException: Status file '/tmp/junit507810544128914182/vf.gf.locator.status' is blank

org.apache.geode.distributed.ServerLauncherRemoteFileIntegrationTest > startDeletesStaleControlFiles FAILED
    java.lang.IllegalStateException: Status file '/tmp/junit15327867236960940397/vf.gf.server.status' is blank

I think this change should be ok.  If distributed tests look good, then I think this should be fine


installation via krew fails for the new arm64 release

Describe the bug
Installing via krew fails on Apple M1.
To Reproduce
Steps to reproduce the behavior:

Have a machine with Arm processor :-)
Run kubectl krew install rolesum
See error

$ kubectl krew install rolesum
Updated the local copy of plugin index.
Installing plugin: rolesum
W0528 09:40:35.196321   10093 install.go:164] failed to install plugin "rolesum": plugin "rolesum" does not offer installation for this platform
failed to install some plugins: [rolesum]: plugin "rolesum" does not offer installation for this platform

Expected behavior
rolesum should be installed correctly.
Laptop (please complete the following information):

Chip: Apple M1 Max
Processor: arm64
OS: macOS monterey 12.1

Additional context
Installation via homebrew works as expected.

It will be available after the following PR has been merged :)
https://github.com/kubernetes-sigs/krew-index/pull/2289


Add support for gounlimited.to

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.04.30
[x] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://gounlimited.to/embed-9j77hdv3266u.html
Single video: https://gounlimited.to/embed-8nyps2gihvti.html

Description

Gounlimited is a video hosting platform. Siginin not required

Those videos are not accessible.

Anyway, the site should be decently easy to support since the video URL's are exposed directly in page source.

There is a video, who can watch without restriction.
Link: https://gounlimited.to/ck9lwxr59j9y/Instalar_ION_vendas.mp4
But when if you use youtube-dl, it gets error on 'extracting information' process.

Anyone has a update about it?


BUG: make time type string [s ns]

🦟 Bug fix
Fixes #642
Summary
While I did this in #643 I think it makes sense to make it a separate PR and rebase. This way this bug can be fixed while awaiting feedback for different things in the other PR.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

This is such an odd failure. double_pendulum.sdf doesn't even use a state element and by extension neither a time element, which is the only one I touched.
The log seems to agree with me:

Here is the relevant section from the jenkins log:
test 103
        Start 103: INTEGRATION_schema_test

103: Test command: /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/test/integration/INTEGRATION_schema_test "--gtest_output=xml:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/test_results/INTEGRATION_schema_test.xml"
103: Environment variables:
103:  SDF_PATH=/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.8:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.7:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.6:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.5:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.4:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.3:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.2:/Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/sdf/1.0:
103: Test timeout computed to be: 240
103: Running main() from gtest_main.cc
103: [==========] Running 3 tests from 1 test case.
103: [----------] Global test environment set-up.
103: [----------] 3 tests from SDFSchemaGenerator
103: [ RUN      ] SDFSchemaGenerator.TestDoublePendulum
103: error : Operation in progress
103: warning: failed to load external entity "http://sdformat.org/schemas/rfidtag.xsd"
103: http://sdformat.org/schemas/sensor.xsd:19: element include: Schemas parser error : Element '{http://www.w3.org/2001/XMLSchema}include': Failed to load the document 'http://sdformat.org/schemas/rfidtag.xsd' for inclusion.
103: WXS schema /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/sdf/1.8/root.xsd failed to compile
103: CMD[xmllint --noout --schema /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/sdf/1.8/root.xsd /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/model/double_pendulum.sdf]
103: /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/schema_test.cc:52: Failure
103: Failed
103: Fail in parsing the model
103: [  FAILED  ] SDFSchemaGenerator.TestDoublePendulum (62365 ms)
103: [ RUN      ] SDFSchemaGenerator.TestPR2Model
103: /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/model/pr2.sdf validates
103: CMD[xmllint --noout --schema /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/sdf/1.8/root.xsd /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/model/pr2.sdf]
103: [       OK ] SDFSchemaGenerator.TestPR2Model (3036 ms)
103: [ RUN      ] SDFSchemaGenerator.TestTurtleBotModel
103: /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/model/turtlebot.sdf validates
103: CMD[xmllint --noout --schema /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/build/sdf/1.8/root.xsd /Users/jenkins/workspace/sdformat-ci-pr_any-homebrew-amd64/sdformat/test/integration/model/turtlebot.sdf]
103: [       OK ] SDFSchemaGenerator.TestTurtleBotModel (2949 ms)
103: [----------] 3 tests from SDFSchemaGenerator (68350 ms total)
103:
103: [----------] Global test environment tear-down
103: [==========] 3 tests from 1 test case ran. (68350 ms total)
103: [  PASSED  ] 2 tests.
103: [  FAILED  ] 1 test, listed below:
103: [  FAILED  ] SDFSchemaGenerator.TestDoublePendulum
103:
103:  1 FAILED TEST
103/216 Test #103: INTEGRATION_schema_test ................................***Failed   68.36 sec

humm strange failure, only on macOS. There aren't known flakes for this branch and platform, that's why we set the check as Required.
Issues on macOS could be due to different dependency versions... Sometimes it's a clang vs gcc thing, or a timing issue (because our macOS CI machines are slow), but I don't think it could be those here.

Okay. It could indeed be a timeout, considering that the test took ~ 1 minute to fail for such a simple thing (running xmllint should take ms, right?). I'm not a Jenkins user myself, but is the setup included in this time? If not, this could be further evidence for a timeout.


Add test for @JsonProperty annotation on enum constant level

See: #503

@dstepanov Added test for this case. All works fine with databind

Please add this and other test as @PendingFeature so it can be merged

done

Yes, now all works fine. Just close this PR or merge?

We can have extra test


Use computed property to PostgresConnection.Configuration.TLS.disable for concurrency safe

PostgresConnection.Configuration.TLS.disable is declared as var but it causes compiler warning on strict concurrency checking.

This value seems to not to be modified in runtime.
So this should be changed to let.

This is a breaking change but it does seem to me that the property was supposed to be a computed property not stored.
I personally don't mind letting it slide although it's a breaking change, because it isn't supposed to be used like that anyway.

@gwynne beat me to it while i was typing on phone 😅

It is technically a breaking change, but in this case the likelihood of someone having an actual source-compatibility issue is very low, and would have required doing something that was fairly obviously unintended.


cleanup the clusterloader2 load testing config file and deployment yaml

As a part of #1125, default value of the variables
ENABLE_CONFIGMAPS, ENABLE_DAEMONSETS, ENABLE_JOBS, ENABLE_SECRETS, and ENABLE_STATEFULSETS are set to true, and these values are not overriden in any of the tests. The config file and deployment yaml can now be be simplified as discussed in https://github.com/kubernetes/perf-tests/issues/1036#issuecomment-607631768 .

/ok-to-test

Thanks!
/lgtm
/approve


Fixes #11: 'bool' object is not iterable

I kinda need a path to reproduce this and it needs to pass the linters etc. If you can help me with that I can look into it.


Display limit

Describe your changes
Issue number
Closes #X
Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

:books: Documentation preview :books:: https://jupysql--462.org.readthedocs.build/en/462/

please mark as draft if this isn't ready for review. also, did you see my comment? https://github.com/ploomber/jupysql/issues/419#issuecomment-1522456875

Added some test cases to cover more
Now the default value is 10
When config value is:

0, it will render all table rows
None, it will still use default value (This is unexpected behavior since we think the value should be int now, but we still add the special handle for this)
Negative Integer, will set the config value unsuccessfully
Positive Integer, will set the config value successfully

Link to displaylimit was added

@yafimvo

Now None and 0 will be no limit setup now. Please test again

lgtm, @tonykploomber please fix the display limit from above, it's still on 60 for some reason.

Please check the doc again!
From my side, it shows 10

Please check the doc again!

@tonykploomber I think the issue is with this section

@tonykploomber is this ready?

@yafimvo
I think I tried to rebuild the doc and still see the preview shows old config value -> 60
However, I re-raised another PR with preview and it shows new config value -> 10

I think it might be some cache issue in readthedocs, do you want to merge the another PR  instead of this one? Although they are same code changes

Yes, I think it's a cache issue. I ran %config SqlMagic on Binder and it shows the correct number.
lgtm.
@idomic

@idomic
This should be good to ship


giving access to tetgenio member variables

Consider the following example, that could lead to a segfault:
// beginning of some scope
{
  //
  // ...
  //

  CADMesh cadMesh(someFileName, someFileType);

  //
  // ...
  //

  // create mesh
  G4AssemblyVolume* someMesh = cadMesh.TetrahedralMesh();

  // get "raw" output
  tetgenio tetgenOutput = cadMesh.GetTetgenOutput();

  //
  // ...
  //

  // At the end of the scope:
  //
  //  - cadMesh will invoke tetgenio:~tetgenio() for CADMesh::out
  //  - tetgenOutput's destructor is called
  //
  // Both would try to call delete[] for the same pointer arrays, e.g. tetgenio::pointlist,
  // resulting in a segfault  during the call of the second destructor,
  // since tetgenio doesn't reset pointers to NULL.
}

CADMesh::GetTetgenOutput doesn't return a pointer, but I will test this scenario anyway, just to make sure.

Not directly, but indirectly. tetgenio gives public access to its pointer arrays, like tetgenio::pointlist, it's essentially a struct. To be specific, you can do this:
tetgenio tetgenOutput = cadMesh.GetTetgenOutput();

// this will delete the data used both by tetgenOutput and cadMesh.out
delete[] tetgenOutput.pointlist;

Ok. It looks like you could trigger a double free by deleting data out of the tetgen output object. Where this is most annoying though, is probably if you are returning a tetgenio object that has been generated by CADMesh, and the CADMesh object is subsequently deleted.
With this code put at line 81 in DetectorConstructor.cc for the example code:
// Create the tetrahedral mesh with tetgen.
G4AssemblyVolume * cad_assembly = tet_mesh->TetrahedralMesh();

// Get a copy of the tetgen output.
tetgenio tetgen_output = tet_mesh->GetTetgenOutput();

// Delete the CADMesh object.
delete tet_mesh;

std::cout << "Points: " << tetgen_output.numberofpoints << std::endl;
std::cout << std::cout;

Gives the following:
user@380cf63dc1fd:/src/examples/basic$ gdb build/cadmesh_example
GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from build/cadmesh_example...done.
(gdb) break DetectorConstruction.cc:81
Breakpoint 1 at 0x40a248: file /src/examples/basic/src/DetectorConstruction.cc, line 81.
(gdb) run macros/vis.mac ../../models/cone.ply PLY
Starting program: /src/examples/basic/build/cadmesh_example macros/vis.mac ../../models/cone.ply PLY
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

*************************************************************
 Geant4 version Name: geant4-10-03-patch-01    (24-February-2017)
                      Copyright : Geant4 Collaboration
                      Reference : NIM A 506 (2003), 250-303
                            WWW : http://cern.ch/geant4
*************************************************************

Breakpoint 1, DetectorConstruction::Construct (this=0x8869a0)
    at /src/examples/basic/src/DetectorConstruction.cc:81
81	        G4AssemblyVolume * cad_assembly = tet_mesh->TetrahedralMesh();
(gdb) display/a tet_mesh.out.pointlist
1: /a tet_mesh.out.pointlist = 0x0
(gdb) display/a tet_mesh.out.numberofpoints
2: /a tet_mesh.out.numberofpoints = 0x0
(gdb) display/d tet_mesh.out.numberofpoints
3: /d tet_mesh.out.numberofpoints = 0
(gdb) display/a tetgen_output.pointlist
4: /a tetgen_output.pointlist = 0x7fffffffe080
(gdb) display/a tetgen_output.numberofpoints
5: /a tetgen_output.numberofpoints = 0x1b3b11c7
(gdb) display/d tetgen_output.numberofpoints
6: /d tetgen_output.numberofpoints = 456856007
(gdb) next
Opening ../../models/cone.ply.
Delaunizing vertices...
Delaunay seconds:  0.006146
Creating surface mesh ...
Surface mesh seconds:  0.001087
Recovering boundaries...
Boundary recovery seconds:  0.001662
Removing exterior tetrahedra ...
Exterior tets removal seconds:  0.000327
Recovering Delaunayness...
Delaunay recovery seconds:  0.000272
Optimizing mesh...
Optimization seconds:  0.000694

Writing nodes.
Writing elements.
Writing faces.
Writing edges.

Output seconds:  0.000198
Total running seconds:  0.010721

Statistics:

  Input points: 50
  Input facets: 96
  Input segments: 144
  Input holes: 0
  Input regions: 0

  Mesh points: 50
  Mesh tetrahedra: 72
  Mesh faces: 192
  Mesh faces on facets: 96
  Mesh edges on segments: 144

84	        tetgenio tetgen_output = tet_mesh->GetTetgenOutput();
6: /d tetgen_output.numberofpoints = 456856007
5: /a tetgen_output.numberofpoints = 0x1b3b11c7
4: /a tetgen_output.pointlist = 0x7fffffffe080
3: /d tet_mesh.out.numberofpoints = 50
2: /a tet_mesh.out.numberofpoints = 0x32
1: /a tet_mesh.out.pointlist = 0x950070
(gdb) next
87	        delete tet_mesh;
6: /d tetgen_output.numberofpoints = 50
5: /a tetgen_output.numberofpoints = 0x32
4: /a tetgen_output.pointlist = 0x950070
3: /d tet_mesh.out.numberofpoints = 50
2: /a tet_mesh.out.numberofpoints = 0x32
1: /a tet_mesh.out.pointlist = 0x950070
(gdb) next
89	        std::cout << "Points: " << tetgen_output.numberofpoints << std::endl;
6: /d tetgen_output.numberofpoints = 50
5: /a tetgen_output.numberofpoints = 0x32
4: /a tetgen_output.pointlist = 0x950070
3: /d tet_mesh.out.numberofpoints = 50
2: /a tet_mesh.out.numberofpoints = 0x32
1: /a tet_mesh.out.pointlist = 0x950070
(gdb) next
Points: 50
90	        std::cout << std::cout;
6: /d tetgen_output.numberofpoints = 50
5: /a tetgen_output.numberofpoints = 0x32
4: /a tetgen_output.pointlist = 0x950070
3: /d tet_mesh.out.numberofpoints = 50
2: /a tet_mesh.out.numberofpoints = 0x32
1: /a tet_mesh.out.pointlist = 0x950070
(gdb) continue
Continuing.
*** Error in `/src/examples/basic/build/cadmesh_example': double free or corruption (!prev): 0x0000000000950070 ***
0x60f6c8
Program received signal SIGABRT, Aborted.

As tetgenio doesn't have a copy constructor, and the implicit copy constructor won't reallocate memory for all of the pointers contained within, CADMesh::GetTetgenOutput() should return std::shared_ptr<tetgenio>.
To work around this, for now, just make sure that the original CADMesh doesn't get deleted.

This also applies to CADMesh::GetTetgenInput()


Pool connection with postgres

Hello,
I tried node-orm2 for the first time today. I think there is an issue on pool connection with pg driver from v7.0.
With newer version I have "TypeError: this.db.connect is not a function" error when trying to connect using pool connection. No error with "query: {pool: false}" option.
I downgraded pg driver version to 6.4.1 and it fixed the issue. But there is warning at connect: "DeprecationWarning: PG.connect is deprecated - please see the upgrade guide at https://node-postgres.com/guides/upgrading". The link explain how to resolve the connect issue.
I'll continue to discover your tools.

Yeah someone needs to add support for PG driver versions >= 7.0.

Seems I resolved this a while ago but forgot to mention that here.
https://github.com/dresende/node-orm2/blob/master/Changelog.md#v500


Cookies aren't always restored on Windows

Our userDataDir + cookies test has been flaky on AppVeyor for months. I have been unable to reproduce it locally though.

I had to do this in Puppeteer-Sharp.
internal static async Task WaitForCookieInChromiumFileAsync(string path, string valueToCheck)
{
    var attempts = 0;
    const int maxAttempts = 10;
    var cookiesFile = Path.Combine(path, "Default", "Cookies");

    while (true)
    {
        attempts++;

        try
        {
            if (File.Exists(cookiesFile) && File.ReadAllText(cookiesFile).Contains(valueToCheck))
            {
                return;
            }
        }
        catch (IOException)
        {
            if (attempts == maxAttempts)
            {
                break;
            }
        }
        await Task.Delay(100);
    }
}

It seems that by the time we load the second browser, the cookies file hadn't been saved yet.

@kblok oh wow, interesting. Do you have a way to reproduce this locally? We tried many different things but none worked, so we see this happening only on Appveyour.

Same here. I was getting random failures in AppVeyor.
I got that error locally a few time on my Mac while running the entire test suite (not just that test). I considered that a possible issue was some IO race. Checked that the Cookies file was plain text(ish) and it solved the issue by waiting for the content to be updated.
I was trying to replicate this on windows and what's interesting is that I'm getting this in a chrome_debug.log file

[0305/154238.569:WARNING:sqlite_persistent_cookie_store.cc(1612)] Failed to post task from Close@../../net/extras/sqlite/sqlite_persistent_cookie_store.cc:1490 to background_task_runner_.

Rings a bell?

I was trying to replicate this on windows and what's interesting is that I'm getting this in a chrome_debug.log file

Yeah might be related, but it's hard to tackle this unless there's a repro. Cookies work pretty reliable in Chrome, so must be something finicky with our shutdown sequence.

Could you try running this on Windows @aslushnikov ?
(async () => {
  await TestServer.create(assetsPath, port);
  for(var x = 0; x < 100; x++) {
    console.log(x);
    const userDataDir = await mkdtempAsync(TMP_FOLDER);
    const options = Object.assign({userDataDir}, {headless: true});
    const browser = await puppeteer.launch(options);
    const page = await browser.newPage();
    await page.goto(`http://localhost:${port}/empty.html`);
    await page.evaluate(() => document.cookie = 'doSomethingOnlyOnce=true; expires=Fri, 31 Dec 9999 23:59:59 GMT');
    await browser.close();
    console.log(userDataDir);
    const browser2 = await puppeteer.launch(options);
    const page2 = await browser2.newPage();
    await page2.goto(`http://localhost:${port}/empty.html`);
    const cookie = await page2.evaluate(() => document.cookie);
    console.log(cookie);
    if(!cookie.includes('doSomethingOnlyOnce'))
    {
      console.log("UPS");
      return;
    }
    await browser2.close();
    // This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778
    await rmAsync(userDataDir).catch(e => {});
  }
})();

@kblok Worked like a charm:

@jschfflr maybe this is a test that can be re-enabled now given that AppVeyor is no longer used?

@OrKoN mind checking my last comment if we could maybe re-enable the test? Thanks.


Suggest clarification that Azure DNS IP (<IP_ADDRESS>) is static and will not change.

The IP address <IP_ADDRESS> is used in all regions, all sovereign clouds, and will not change.  I can't find the master IP list for Azure but that document (if it exists) should mention this IP as well.  Suggest cross-referencing the master IP list in this document as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7b1b215-0434-145b-cd11-95d0f32bc015
Version Independent ID: d328a868-a151-1985-2b62-f3884f7ad76c
Content: Name resolution for resources in Azure virtual networks
Content Source: articles/virtual-network/virtual-networks-name-resolution-for-vms-and-role-instances.md
Service: virtual-network
GitHub Login: @subsarma
Microsoft Alias: subsarma

@markmassad Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Please assign this to @vhorne

Added Azure DNS IP to article.
#please-close


Discussion: Document a set of commands to pull intermediate results and final results in unencrypted form

Is this a discussion?  Seems more like an action item no?

No idea why I opened this. I'm going to close it.


Old file transfers do not get removed from the File Transfers list

The file transfers list shows uploads and downloads that are happening. But when an upload or a download finishes the progress bar does not get removed from the list, instead it lingers around. Since the list is ordered by progress all the completed transfers stay at the top of the list, so you have to scroll down to view the progress of the active transfers.
Uploads should either be removed once they reach a redundancy value of 6.00 or 1.00 (I'd day 6.00, since that counts as 100% uploaded in siad). And downloads should simply be removed once the download is complete.
I've noticed that restarting the UI does remove the completed download progress bars. But it does not remove the completed uploads, they will just stick around forever. As a result the upload queue has just become a complete list of every file in the renter.
EDIT: Tested on version 1.0.3-RC

I've checked the API and all my uploads do seem to have 100% upload progress. I know there used to be a rounding error there in older versions of sia but it has since been fixed. I don't know what caused the uploads to linger around in my queue for so long, but when I arrived at my PC this morning the upload queue was empty. I left the client running overnight and it had finished all my uploads.

Closing this for now.


Cython acados and minor

Work on acados cython interface plus some minor changes.
Changing the acados option qp_solver_cond_N = 1 leads to non significant differences in the process replay.
First few lines of the diff:
***** tested against commit 60f58f58dae514eb8b956c03afa5f9b91c12a122 *****
***** differences for segment fakedata|2022-01-20--17-49-04--0 *****
*** process: plannerd ***
	('change', ['longitudinalPlan', 'speeds', 5], (9.423521995544434, 9.423521041870117))
	('change', ['longitudinalPlan', 'jerks', 0], (-0.0013856348814442754, -0.0013860478065907955))
	('change', ['longitudinalPlan', 'jerks', 1], (-0.0014040004462003708, -0.0014043424744158983))
	('change', ['longitudinalPlan', 'jerks', 2], (-0.0014590970240533352, -0.0014592264778912067))
	('change', ['longitudinalPlan', 'accels', 1], (-1.614632651580905e-06, -1.8924523601526744e-06))
	('change', ['longitudinalPlan', 'accels', 2], (-6.45853060632362e-06, -7.5698094406106975e-06))

Instead of just changing the acados template can you modify the build script and use that?
https://github.com/commaai/openpilot/blob/master/third_party/acados/build.sh
Besides that and pending batch tests, LGTM

Changed the version in the build script 95c5c89
Ran batch tests on 1.5k segments! Thanks for the support there!
Speed: comparing maximum speed diffs over segment
decent: < 2m/s: 1532/1532 aka 100.00%
good:   < 1m/s: 1532/1532 aka 100.00%
best: (<.5m/s): 1532/1532 aka 100.00%

Acceleration: maximum acceleration diffs over segment
decent: < 1m/s^2: 1532/1532 aka 100.00%
good: (<.5m/s^2): 1532/1532 aka 100.00%
best  (<.2m/s^2): 1531/1532 aka 99.93%


Add a --reencrypt option to fsck

It can happen that we are doing a "key rotation" or have changed some things related to PGP that require us to fully re-encrypt our store.
Currently the only process to do so it adding a dummy recipient and then removing it.
This is not really desirable as it can lead to side effects such as committing secrets with a "weaker" key or so to our pw store.
Ideally we should be able to use fsck --reencrypt in order to decrypt all secrets and "re-encrypt" it with the current set of recipients.
This would also help solving issues such as "My process failed while I was adding a recipient", "I ^C Gopass in the middle of the removal of a recipient" or other things like that and would fit nicely under fsck responsabilites, IMO.
This would also have helped for example in #1977 when it was needed to fully re-encrypt the store using a downgraded PGP version because the latest PGP version wasn't being properly supported and cross-compatible for our usecase.
This also help with "expired subkeys": I can just add a new subkey to my key and "re-encrypt" the whole store.
So it would relate to: #1969, #1107, #1430
What it should do: re-encrypt in place all secrets for the current set of recipients, using the "main" encryption subkey of a key (or the specified subkeys) for each recipient, and then commit/push/sync the whole as per existing config.

We already have a decrypt option that's implemented here. I guess all that's missing is another flag that's evaluated in that condition to make it always re-encrypt?!

for me that flag doesn't seem to actually re-encrypt anything because when I run it twice in a row, I get the same list of passwords that needs re-encrypting.  I would have expected --decrypt to actually do that.  Maybe I'm doing something wrong, but I try:
$ gopass fsck --decrypt

as the help command says and it runs exactly as if I had not passed that.  I then tried this and still the same result.
$ gopass fsck --decrypt=true

That seems to be a bug of some kind then.


Tests fail after upgrading to node 6.5 and above.

After upgrading to node 6.5 (and above) I get the following when trying to run jest:
    SyntaxError: Invalid or unexpected token

      at ModuleMocker._createMockFunction (../node_modules/jest-mock/build/index.js:408:31)
      at Array.forEach (native)
      at Array.forEach (native)

the --debug flag tells me:
jest version = 17.0.3
test framework = jasmine2
config = {
  "automock": "true",
  "rootDir": "/Users/dan.green/Code/build-cloud/src",
  "coverageDirectory": "/Users/dan.green/Code/build-cloud/coverage/jest",
  "coverageReporters": [
    "lcov",
    "json"
  ],
  "collectCoverage": "true",
  "testEnvironment": "/Users/dan.green/Code/build-cloud/node_modules/jest-environment-node/build/index.js",
  "resetModules": "true",
  "unmockedModulePathPatterns": [
    "moment",
    "underscore",
    "wrappy",
    "\\bnode_modules/util\\b",
    "depd",
    "uuid",
    "node_modules/express",
    "deep-extend",
    "test/mock",
    "node_modules/clone"
  ],
  "name": "-Users-dan.green-Code-build-cloud-src",
  "setupFiles": [
    "/Users/dan.green/Code/build-cloud/node_modules/babel-polyfill/lib/index.js"
  ],
  "testRunner": "/Users/dan.green/Code/build-cloud/node_modules/jest-jasmine2/build/index.js",
  "transform": [
    [
      "^.+\\.jsx?$",
      "/Users/dan.green/Code/build-cloud/node_modules/babel-jest/build/index.js"
    ]
  ],
  "usesBabelJest": true,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/7l/r7p08mp563g14w9rt8fpgks0yg0yr1/T/jest",
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "expand": false,
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "resetMocks": false,
  "snapshotSerializers": [],
  "testPathDirs": [
    "/Users/dan.green/Code/build-cloud/src"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "transformIgnorePatterns": [
    "/node_modules/"
  ],
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true
}

This is not actionable. Can you provide a repository that shows this issue?

demo
Now that I've dug all the way down to the root cause it makes a little more sense. We've got a isomorphic file for extending linkedin's dustjs with some helpers. I'm thinking that it has something to do with how we're hacking together support for requirejs and commonjs. I'm sure jest isn't expecting this kind of franken-module.
The error it's throwing is pretty vague though.
If anyone can help me understand the error I can probably fix the code so as not to do turrible things.

Jest does not support requirejs. If you'd like to support it, you'll likely need to build your own transformer that injects requirejs like functionality into specific files.
In your specific case it seems like you have automocking set to true, which we advice against. It seems like dustjs or some other modules cannot be automocked (because of their use of generics or something similar), so I advice to either not use mocking for these kind of modules or provide a manual mock.

any ideas why this broke from node 6.4 to 6.5?
I assume it's got something to do with the the V8 update, but  I don't know how that interacts with jest. Any sort of insight as to why jest is erroring out in this situation would be great.


Fix clang-16 build of unit tests in debug mode

The linker does not go ahead without the atomic library being linked, if debug build mode is used.
/kind improvement

/approve


add support for R32F

Description of change

This might be somewhat niche, but I wanted a single-channel float texture for my project. So I've added support for that.
An alternative / adjunct to this would be making internalFormat an option when creating a BaseTexture, so that users could set it by hand for their niche uses. I wouldn't mind that either, but I figured this was the minimal clean way to get what I wanted.
Please let me know what you think. Thanks!
Pre-Merge Checklist

[x] Tests and/or benchmarks are included
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

That's funny; tests seem to be passing on my machine. Let me try something diagnostically...

OK that's weird! One of those tests is for the new code path. The other I just added is for an old code path. Both of them should pass. Both pass on my computer (with npm run unit-test). Does anyone know why they might be failing on the test server? (Thanks for any help!)

I'm not sure why it's failing. but it seems like renderer.gl is missing R32F and RGBA32F on GitHub Actions.
One thing worth trying is to console.log props on gl to see what the tests here return:
console.log(Object.keys(this.renderer.gl.__proto__).filter(i=> i.startsWith("R")));

Also, when I run your tests locally:
npm run unit-test:debug -- --package=@pixi/core

I get this warning in the console:
BaseImageResource.ts:96 WebGL: INVALID_VALUE: texImage2D: invalid internalformat

For the test should set internalFormat correctly for red-channel float textures.

it seems like renderer.gl is missing R32F and RGBA32F on GitHub Actions.

WebGL 1
So we have to test it on webgl1, whats internalFormat for RED in that case if R8 doesnt exist?

Usually its handled by custom user BufferResource: https://www.pixiplayground.com/#/edit/xpLx-ElnpPPPXFJUkxoRa
We are sure that we can't handle all the cases. We really dont know where to stop adding formats. That's why I'm afraid of it: https://github.com/playcanvas/engine/blob/master/src/graphics/graphics-device.js
However R32F might be a good general format, shame it does not exist in webgl1

Finally, build is green @joshuahhh, sorry this took so long to sort.

Woohoo! Thanks @bigtimebuddy. Haven't been following the details, but I'm happy to see the test situation has been improved! :)


Windows Web Engine tests are too slow

These tests are currently the long pole on Engine LUCI builds at ~55 minutes. The next longest tasks are 10-20 minutes faster, so addressing this will result in quicker turnaround on every PR, roll, etc..
The TODO here indicates that the sharding is already done for Linux, and that it could be done for Windows and Mac as well, but I'm not really sure what the difficulty level is or if there are other missing pieces still.
/cc @ferhatb @godofredoc @yjbanov

Seems like linux is using:

dev/felt.dart test '--browser=chrome' --integration-tests-only
dev/felt.dart test '--browser=chrome' --unit-tests-only
dev/felt.dart test '--browser=firefox' --integration-tests-only
dev/felt.dart test '--browser=firefox' --unit-tests-only

@yjbanov @ferhatb are the same flags applicable to windows platform?

I don't think these will help. On Windows we seem to only run the unit tests and only on Chrome. Basically felt test on Windows is equivalent to dev/felt.dart test --browser=chrome --unit-tests-only.
Most of the time goes into compiling the tests, not running them.

@yjbanov Is this test compilation faster in other platforms? the reason I'm asking is because I remember from a conversation with you that we could compile the tests in Linux and then just run in other platforms.

@yjbanov Has finer-grained sharding of dev/felt.dart test --browser=chrome --unit-tests-only been considered? Whether the time is spent compiling or running, it would be a big help to make this configuration run faster however we can.

Yes, we have considered finer-grained sharding of windows tests. However, compiling all tests once and sharing the output across all platforms (like @godofredoc suggests in https://github.com/flutter/flutter/issues/83222#issuecomment-849932663) is probably the most optimal solution.

@yjbanov Do we have another issue filed for that already, or should we repurpose this one?

Does goma support dart to js compilation? I found this in the felt docs:
You can use an internal instance of Goma to parallelize your builds. Because Goma compiles code on remote servers, this option is effective even on low-powered laptops.

By default, when compiling Dart code to JavaScript, we use 8 dart2js workers.

@godofredoc Those two sentences are probably closer to each other than they should be :) Unfortunately no, goma can't parallelize dart2js, at least not with our setup AFAIK.
I'm going to poke around. One idea I have is to compile all unit-tests as a single compilation unit and then route to each test's main. Another idea is to switch from dart2js to DDC, which can cache each library. If one of these works we may not need sharding for now.

@yjbanov is felt threadsafe? can we run the shards using multiprocessing in the recipe?

Closing. Let's file a new issue if/when 20-30min becomes not good enough.


[release-4.7] Fix kubebuilder installation in the build root Dockerfile

Update the base.Dockerfile and fix the kubebuilder installation. That
vanity URL is no longer correctly serving the v2.3.1 release tar.gz
file. Update to instead curl directly from the github releases URL.

Description of the change:
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

force merging due to permafailing ci


Alteracao do compile SDK

Alteracao do compileSDK para versão 34;

Testado no M10.

https://pub.dev/packages/elgin/changelog
feito!
Em sex., 12 de abr. de 2024 às 17:34, Shelmo @.***>
escreveu:

Testado no M10.
—
Reply to this email directly, view it on GitHub
https://github.com/brasizza/flutter-elgin/pull/1#issuecomment-2052491080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGV4NQJIAFXE7CJOVCJ23DY5BAL7AVCNFSM6AAAAABGEX5LPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGQ4TCMBYGA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Marcus Vinicius Brasizza
Já codou hoje?
https://jacodouhoje.dev/ https://jacodouhoje.dev/


Have homekit_controller use device registry

Description:
Now that config entries for homekit_controller is merged this updates homekit_controller to use the device registry. This includes tests to make sure that entries are created in the device registry. It tests that seperate hub devices are created when appropriate - and that a hub device isn't created when there isn't a hub as is often the case with HK accessories.
I have some outstanding questions about what HA expects from an integration though:

For connections, the only existing types are mac, zigbee and upnp. None of these really factor into the workings HomeKit protocol, and i don't know what HA uses them for. There is a mac like identifier called the accessory id (people often confuse them) (conn.unique_id in the PR) which i have passed in and i was going to make it a proper const of its own but it feels more like an identifier than a connection. Is it acceptable for connections to be blank? Are there any consequences if its blank?

If i do treat the accessory id as an identifier and not a connection then i will have 2 identifiers for a device - its serial number and its accessory id. Instead of using the DOMAIN as the first value in the tuple would I use DOMAN + '-serial' for one and DOMAIN + '-hkid' for the other?

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]

It's fine to leave connections empty and to have multiple identifiers.
Under the hood connections and identifiers work the same, they are used to look up a device. However, in the future I would want to start creating a map of a Home Assistant instance, using the connection types to identify how things communicate.


[3.1] SqlServer BuildPageQuery

Hey,
Hitting an issue in SqlServerDatabaseType.BuildPageQuery. If the original query is
SELECT [table].[id], [table].[name] AS [alias] FROM [table] ORDER BY [table].[name]

The resulting query will be
SELECT * FROM (SELECT poco_base.*, ROW_NUMBER() OVER (ORDER BY [name]) poco_rn
FROM (
SELECT [table].[id], [table].[name] AS [alias] FROM [table] ) poco_base ) poco_paged
WHERE poco_rn > @0 AND poco_rn <= @1
ORDER BY poco_rn

Which will fail because ORDER BY [name] is invalid here as [name] is not a valid column in the poco_base column. It should be ORDER BY [alias]. As a consequence, it is not possible to paginate a query that has aliased columns that are also used in the sort order.

Have created PR https://github.com/schotime/NPoco/pull/249 which adds a test + a fix. The fix does work somehow, by looking for an AS statement for the ORDER BY columns. I am not entirely happy with it though, as I think it still can fail on complex queries, plus it creates a new Regex, which is not optimal, perfs-wise.

Is there an issue ordering by the alias?

No issue ordering by "alias" -- that is precisely what we want. The difficulty is to find "alias" since all we have is "name". So the code in my PR tries to look for the match in the rest of the query. No issue, it works, only I'm not 100% sure it will always work, depending on the complexity of the query (if it has inner select & things like that).

Sorry i meant. Cant the query be rewritten to use the alias?

Uh... not sure we understand each other ;-) The original query is using the alias (and needs to). Then the SqlServerDataType, when building a paged query, extract the ORDER BY infos to bring them back into the OVER (ORDER BY ...) block. So it is SqlServerDataType that is writing that part of the query.
Unless... you imply that the original query could be written as
SELECT [table].[id], [table].[name] AS [alias] FROM [table] ORDER BY [alias]

Ie using "alias" in the ORDER BY clause. Mmm... that could work, but would require that we refactor how queries are generated. Looking into it.

Yeah i was referring to your last statement.

Ie using "alias" in the ORDER BY clause. Mmm... that could work, but would require that we refactor how queries are generated. Looking into it.

I think the same or similar problem arises if using multiple non aliased fields with same name.
Common scenario is paging over a join from multiple tables:
select * from T1 inner join  T2 on T1.id = T2.parentid
This will result in

The column 'Id' was specified multiple times for 'poco_base'.

@enriko-riba in that type of situation, the only solution is to alias the fields

Finally, it looks much cleaner to generate proper queries where ORDER BY uses the aliases. So I've closed the PR and also close this issue. It should be documented somehow, however, as that might confuse people.