Option to stop the simulation on demand

First of all, thanks for this great software piece!
We are using OceanParcels for simulating underwater objects and we would like to have the ability to stop the simulation when a certain condition is reached.
For example: how could the argo float example be stopped after drifting 10 km or after returning to the surface for the second time? Is there any other way to stop the simulation than running over the entire simulation time?

Very good idea, @miquelmassot; thanks for the suggestion!
I have now implemented an ErrorCode.StopExecution in PR #780. If you change to that branch, you can then add the following to your Kernel
if particle.driftdistance > 10e3:
    return ErrorCode.StopExecution

This should do what you suggested (assuming of course that you keep track of driftdistance for your particle)

Thanks @erikvansebille! I will give it a try.


[2602] Discard provider should discard their courses

Context
When a provider is discarded it should also discard their courses.
Changes proposed in this pull request

Add before block that discards a providers courses before provider.discard
Add this functionality to MCB provider discard command

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

like it :+1:

 During course creation accredited body provider must pass hidden fields from previous steps.

 Delete provider O10 and update how provider.discard works


Follow the update of trunk to 5.2

Update all the CI jobs for trunk so that they build OCaml 5.2, following the branching of 5.1 earlier this week.

All green!
I'll merge to restore trunk testing - and then we can correct the above in a follow-up if we need to.


chore(travis): remove firefox addon

Travis was still installing firefox as an addon, but we are not using it anymore on the CI tests.
Should reduce CI test time by roughly 30ish seconds.

lgtm


A tag may not be selected more than once

Reason (Why?)
It shall not be possible to select a tag more than once and when the tag is created, it shall no longer be in the search bar.
Solution (What?)
If the user added a tag to the search he should not be able to add the same tag again. Furthermore, no tags should be displayed in the search, which are already in the search. After a tag was added the value inside of the search bar should be cleared.
Not doing
The search algorithm.
Relation to other Issues
None
Acceptance criteria

User writes 'Macher/in' in the search bar.
User presses enter.
The tag 'Macher/in' should be added to the search.
The value of the search bar is empty.
User writes 'Mach' in the search bar.
There shall be no proposal for 'Macher/in'.
User writes 'Macher/in' in the search bar.
User presses enter.
The tag 'Macherin' should only be present once in the search.

I am confused by this issue description.
It is correct, that an already selected search tag shall not be available in the autosuggest list for the next time.
However, the user may refine the search by adding other search tags.  So, the list of tags in the search bar is NOT cleared after executing a search operation.

Von: JanF<EMAIL_ADDRESS>Gesendet: Freitag, 19. Juni 2020 21:21
An: hochschule-darmstadt/einander-helfen<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Betreff: [hochschule-darmstadt/einander-helfen] A tag may not be selected more than once (#57)
Reason (Why?)
It shall not be possible to select a tag more than once and when the tag is created, it shall no longer be in the search bar.
Solution (What?)
If the user added a tag to the search he should not be able to add the same tag again. Furthermore, no tags should be displayed in the search, which are already in the search. After a tag was added the value inside of the search bar should be cleared.
Not doing
The search algorithm.
Relation to other Issues
None
Acceptance criteria

User writes 'Macher/in' in the search bar.
User presses enter.
The tag 'Macher/in' should be added to the search.
The value of the search bar is empty.
User writes 'Mach' in the search bar.
There shall be no proposal for 'Macher/in'.
User writes 'Macher/in' in the search bar.
User presses enter.
The tag 'Macherin' should only be present once in the search.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/hochschule-darmstadt/einander-helfen/issues/57 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYWHS346QUV55IEP5RFRTDRXO3BPANCNFSM4OC7MEYQ .  https://github.com/notifications/beacon/ABYWHS6TWDMANVLARA5F4XDRXO3BPA5CNFSM4OC7MEY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JSG2ATA.gif

@BernhardHumm

However, the user may refine the search by adding other search tags. So, the list of tags in the search bar is NOT cleared after executing a search operation.

Not the list of tags but the search value should be cleared.
Currently if you do free text search (f.e. 'Mach') and press enter, the tag 'Mach' is added and the value inside of the search bar is still 'Mach'.

This is not best practice, as the user must now delete 'Mach' from the search bar before searching for another tag.

Now I understand and fully agree. A screenshot often clarifies the issue.
My suggestion: when no entry in the autosuggest list is chosen (full text search) then indicate this by double quotes in the tag,
In the example: “Mach”
(analogous to openArtBrowser).

Von: JanF<EMAIL_ADDRESS>Gesendet: Montag, 22. Juni 2020 14:01
An: hochschule-darmstadt/einander-helfen<EMAIL_ADDRESS>Cc: Humm, Bernhard, Prof. Dr<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [hochschule-darmstadt/einander-helfen] A tag may not be selected more than once (#57)
@BernhardHumm https://github.com/BernhardHumm
However, the user may refine the search by adding other search tags. So, the list of tags in the search bar is NOT cleared after executing a search operation.
Not the list of tags but the search value should be cleared.
Currently if you do free text search (f.e. 'Mach') and press enter, the tag 'Mach' is added and the value inside of the search bar is still 'Mach'.
https://user-images.githubusercontent.com/64203299/85284982-5f934a00-b490-11ea-8608-b8eb05c5e9bb.png
This is not best practice, as the user must now delete 'Mach' from the search bar before searching for another tag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hochschule-darmstadt/einander-helfen/issues/57#issuecomment-647472464 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYWHS663J6APBU73WPSFWTRX5BX7ANCNFSM4OC7MEYQ .  https://github.com/notifications/beacon/ABYWHS7GCPHRXP5N3EADXDDRX5BX7A5CNFSM4OC7MEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE2L2KUA.gif

@BernhardHumm
I have an alternative suggestion to your free text search idea. How about as soon as no more tags match the search a small info text like in the following screenshot is provided. I find this a bit more user-friendly than simply putting the tag in quotation marks when it's a free text search.

The previous behaviour remains of course unchanged. Only as soon as the free text search no longer matches the provided tags, the info text will appear.

This looks like good information for the user.

when the tag is created, it shall no longer be in the search bar.

This has not been implemented. See #113

Fixed by #113

Good idea!

Von: andresesam<EMAIL_ADDRESS>Gesendet: Sonntag, 28. Juni 2020 10:19
An: hochschule-darmstadt/einander-helfen<EMAIL_ADDRESS>Cc: Humm, Bernhard, Prof. Dr<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [hochschule-darmstadt/einander-helfen] A tag may not be selected more than once (#57)
@BernhardHumm https://github.com/BernhardHumm
I have an alternative suggestion to your free text search idea. How about as soon as no more tags match the search a small info text like in the following screenshot is provided. I find this a bit more user-friendly than simply putting the tag in quotation marks when it's a free text search.
https://user-images.githubusercontent.com/39090774/85942253-7b7f6b80-b928-11ea-8451-201c8b371c52.png
The previous behaviour remains of course unchanged. Only as soon as the free text search no longer matches the provided tags, the info text will appear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hochschule-darmstadt/einander-helfen/issues/57#issuecomment-650716209 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYWHSYN4QGYJZOKZXTXNKLRY34GLANCNFSM4OC7MEYQ .  https://github.com/notifications/beacon/ABYWHS7JDXNM26SWTXYTHI3RY34GLA5CNFSM4OC7MEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE3ESIMI.gif


Wrong course/exam title corrected

The index file showed the wrong descriptor for the exam's hyperlink.

Good catch... merged


Log user-friendly message when certificate/privkey is inaccessible

We shouldn't assume that xrdp daemon is running under root privilege.
In many cases, root privilege is not really needed for xrdp daemon.
xrdp may fail to load certificate/privkey due to lack of permissions
when running under user privilege. Checking existence of files is not
enough and xrdp should output user-friendly log in such case.
Reported by Debian user in bug 856436 [1].
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856436

Actually, the only valid way to find out whether you can read a file is trying to read it. On all platforms.
Checking existence and access rights is not enough. Just the... open it and see what happens.
-nik

Indeed.

OK, these calls should error when failed to load valid certificate or privkey.
Use log_message instead of g_writeln should help users.
    if (SSL_CTX_use_RSAPrivateKey_file(self->ctx, self->key, SSL_FILETYPE_PEM)
            <= 0)
    {
        g_writeln("ssl_tls_accept: SSL_CTX_use_RSAPrivateKey_file failed");
        return 1;
    }

    if (SSL_CTX_use_certificate_chain_file(self->ctx, self->cert) <= 0)
    {
        g_writeln("ssl_tls_accept: SSL_CTX_use_certificate_chain_file failed");
        return 1;
    }

Switching to log_message from g_writeln doesn't fail on security negotiation.

As @Natureshadow says, checking readability is not enough.  Fundamentally, certificate should be validated. Access rights check and user-friendly log help some users.  Better than nothing. Let's ship this.


ProtocolDeprecateCallback: The callback argument of protocol module APIs is no longer needed

Seeing this running our integration tests, I think it originates from https://github.com/microsoft/vscode/blob/811c4b5552e4165262cb25eeb6480e04c295bd9a/src/vs/workbench/contrib/webview/electron-browser/webviewProtocols.ts#L18

https://www.electronjs.org/docs/api/breaking-changes-ns#planned-breaking-api-changes


qtbase_git: remove path of the build host from qmake.conf

OE_QMAKE_CFLAGS and OE_QMAKE_CXXFLAGS contain path of the build
host, which is not useful for the target, and can be a potential
security risk.
It looks like the following in the target qmake.conf (actual build host path replaced with $PATH_OF_BUILD_HOST):
isEmpty(QMAKE_CFLAGS): QMAKE_CFLAGS =  -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=$PATH_OF_BUILD_HOST/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0=/usr/src/debug/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0                      -fdebug-prefix-map=$PATH_OF_BUILD_HOST/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0=/usr/src/debug/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0                      -fdebug-prefix-map=$PATH_OF_BUILD_HOST/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0/recipe-sysroot=                      -fdebug-prefix-map=$PATH_OF_BUILD_HOST/qtbase/5.15.0+gitAUTOINC+f6fe4bbab7-r0/recipe-sysroot-native=
-fmacro-prefix-map and -fdebug-prefix-map are therefore removed from
qmake.conf on the target, as these are default options only that can be
overridden any time.
Signed-off-by: Mingde (Matthew) Zeng<EMAIL_ADDRESS>

In master-next now, but I would be surprised if this is the only place where such paths are leaking

Great! This is what I discovered so far.

Merged thanks


Remove non-functional UI elements/components

This removes all remaining non-functional UI elements and unnecessary UI components.

Aside from this and other PRs, the only remaining things I can think of are:

Navigation - I think there's some logic that hides the navigation when in the context of cockpit. But at the moment, this tool is only available in the context of cockpit. Should we just remove navigation altogether and add it back later when it becomes necessary?
Ability to comment on a commit - See example below. This UI is functional, but it also implies that the comments are viewable somewhere in the UI, which currently is not available.

closes #251

Should we just remove navigation altogether and add it back later when it becomes necessary?

Sounds like a good plan to me.

Ability to comment on a commit - See example below. This UI is functional, but it also implies that the comments are viewable somewhere in the UI, which currently is not available.

Can you see them from the CLI somehow?

Can you see them from the CLI somehow?

@bcl Can you comment on that? I thought that composer-cli blueprints changes http-server would show comments along with the changes, but I'm not seeing them.

@bcl Can you comment on that? I thought that composer-cli blueprints changes http-server would show comments along with the changes, but I'm not seeing them.

It isn't included in the POST, right? Right now the content is converted directly to a blueprint and the subject of the commit is auto-generated using the version number and name. We haven't added any way to include a commit message along with the blueprint yet. That would require a schema change, instead of posting the blueprint JSON directly you'd wrap it {"comment":"wonderful fixes", "blueprint":{"name":...

This is what I get from the CLI with the changes command:
[root@m1 ~]# composer-cli blueprints changes newprint
newprint
    2018-06-28T17:29:01Z  f0295738fbc248472e05c3b4421b12ad77f0b304
    Recipe newprint, version 0.0.3 saved.

    2018-06-28T17:28:20Z  07c3e07a12d58d2712847402cfa9ea4a052606eb
    Recipe newprint, version 0.0.2 saved.

    2018-06-28T17:27:50Z  5d897a8c5592521c695dd914c7da7dd70131cadb
    Recipe newprint, version 0.0.1 saved.

This is what I get from the CLI with the changes command:

That's the correct output. To implement including comments in the commit we would need API and UI changes.

If there's currently no way to get at the commit message, I agree that we should remove the possibility to enter one in the UI.

I'm not sure what the best approach is for this one. There is more to the Comments field than just an input field that isn't hooked up. If we plan to add the ability to include commit messages, then I'm wondering if we should just hide this element in the UI, and keep the remaining code there so that we can easily hook it up later.
This is the approach I took in my last commit, which results in the UI shown below:

But if we think it's best to pull everything related to the commenting feature out, then I'd prefer to capture that in a separate issue and PR.
Let me know what you think.

@jgiardino I think hiding it is the right approach, I don't see any reason to remove code that's eventually going to be useful.

Looks good to me ui-wise.

@larskarlitski can you review the code on this one?

@jgiardino, could you please resolve conflict and rebase master to make end to end test work. Thanks.

@henrywang I made those changes, but I'm still seeing this test fails.
When I look at the file, this looks incorrect to me, since the Edit Blueprint is only a link:
    // Button - Edit Blueprint
    this.btnEditBlueprint = '.list-view-pf-actions a button';

Should it be this instead:
    // Button - Edit Blueprint
    this.btnEditBlueprint = '.list-view-pf-actions a button';

Also, we could add data- attributes to make it easier to identify elements for tests, for example:
    // Button - Edit Blueprint
    this.btnEditBlueprint = '[data-test="edit-blueprint"]';

@larskarlitski, do you have any comment on this PR? Thanks.

This looks good to me. Thanks!

@jgiardino, there's a conflict due to PR merge order. Sorry about that.
Could you please resolve this conflict? Thanks.

Codecov Report

Merging #252 into master will increase coverage by 2.47%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   30.25%   32.73%   +2.47%
==========================================
  Files          78       74       -4
  Lines        2581     2395     -186
  Branches      338      321      -17
==========================================
+ Hits          781      784       +3
+ Misses       1526     1354     -172
+ Partials      274      257      -17

Impacted Files
Coverage Δ

components/ListView/ComponentSummaryList.js
5.88% <ø> (ø)
:arrow_up:

components/Modal/PendingChanges.js
11.11% <ø> (ø)
:arrow_up:

components/ListView/BlueprintListView.js
75% <50%> (ø)
:arrow_up:

pages/blueprints/index.js
55.71% <0%> (+4.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f5658...f7cc425. Read the comment docs.

@henrywang Before I rebased, I though all tests were passing. I've tried restarting the build, but that doesn't seem to change the outcome. Do you have any suggestions?

@jgiardino, the failed case is not caused by your code change. Sometimes, Available Components and Selected Components keep on loading status when entering edit blueprint page by entering edit blueprint page directly by URL, like http://localhost:9090/welder#/edit/test.I filed a new issue #286 to track this issue and let it move on.


Gateway timeout on 200k images

Describe the bug
After adding 200,000 images through Python SDK recognition service does not work anymore and returns 504 gateway timeout error.
To Reproduce
Steps to reproduce the behavior:

Add 200k images
Go to UI and try recognition service

Expected behavior
Person is recognised
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Ubuntu 20.04
Chrome
CompreFace 1.0.0
RTX2060
64GB RAM

Additional context
Logs (Using external host as files are too big)
https://www.mediafire.com/file/h2gap9jn3cja01i/DB.log/file
https://www.mediafire.com/file/sl76j63by5f0xcl/Admin.log/file
https://www.mediafire.com/file/d4jumgd0b609ssl/FE.log/file
https://www.mediafire.com/file/ibvtf15kdvaq10l/API.log/file
https://www.mediafire.com/file/41z5mttlld1us0n/Core.log/file

Hi, sorry for so long response, I was on a long vacation.
According to your API.log file, java fails because it lacks memory. Did you update the .env file? There is such an option in the default configuration:
compreface_api_java_options=-Xmx4g
You should update it, e.g.:
compreface_api_java_options=-Xmx16g

Hey,
Yeah I did update the .env file and it fixed the issue, however even if I set it to 16gb on 180k images it shoots up to 28GB, correct me if I am wrong but if I was to use a million images we would be looking at 256 - 384GB of RAM?

yes, unfortunately, CompreFace is not optimized for such huge face collections.
This will require different approaches which could be too heavy for small collections.
So we had to choose which collection size to support and for now we chose small collections.
I believe 100k is the max comfortable size for CompreFace, of course, it will work with bigger collections, but as you mentioned it would cost too many resources.

I see you prioritized smaller collections. From your knowledge, what would be the steps to optimize CompreFace for bigger collections?
I have also noticed very slow service initialization, on a 180k images. Meaning that after a reboot, system takes at least 30 minutes of time to load images back into the RAM. Could that be addressed as well?

Thank you for your answer and sorry for the delay in getting back to you. So having had a look at Milvus, I understand it will be situated before Postgres in the architecture, so embeddings will be saved in Milvus, while subject information would be on Postgres. Am I correct?
Having said that could you advise on which scripts will require changes in order to integrate Milvus? I am looking at above a million images, and using the current architecture has a high cost in terms of resources.

I didn't research it deeply. I think yes, it should be similar to your description.
You need to replace this class, and probably lots of logic related to it with Milvus logic:
https://github.com/exadel-inc/CompreFace/blob/master/java/api/src/main/java/com/exadel/frs/core/trainservice/component/classifiers/EuclideanDistanceClassifier.java

What is the maxium practical amount of faces?

I didn't research it deeply. I think yes, it should be similar to your description. You need to replace this class, and probably lots of logic related to it with Milvus logic: https://github.com/exadel-inc/CompreFace/blob/master/java/api/src/main/java/com/exadel/frs/core/trainservice/component/classifiers/EuclideanDistanceClassifier.java

Would that be the sole class that requires modification or are there others as well?

Others as well, this is just where you can start discovering.


Meetings are now inside

Update 2.10.2023 1430

Meetings will be stored like this
Attendees are not considered when finding duplicates
You can add as much attendees in a meeting
currently only way to view is from the data storage

Add link between attendee and Person, so that we can actually see a 1 to 1 relationship.

closes #7


♻  context create -> context add

#50  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RTLS and the rest of your teammates on  Graphite


Auth API: guide about working with views and regular API keys

After several discussions around Auth API, I have detected the pattern of people trying to restrict access to partial information from datasets. E.g., I have a clients dataset, I just want to build an application with clients from NYC area.
Using PostgreSQL and Auth API, you could create a view of your dataset with —basic or geospatial— constraints and grant access to a regular API key to that view. This avoid creating a separate table that you have to keep in sync with your original clients dataset.
My view:
CREATE VIEW clients_nyc AS (SELECT * FROM clients WHERE ...);

My API key:
{
  "name": "Clients-NYC",
  "grants": [
    {
      "type": "apis",
      "apis": [
        "maps"
      ]
    },
    {
      "type": "database",
      "tables": [
        {
          "schema": "public",
          "name": "clients_nyc",
          "permissions": [
            "select"
          ]
        }
      ]
    }
  ]
}

It would be nice to create a guide about how to do this.

@oriolbx @jsanz this theme is that one we discussed at the time of the Auth release. I think you have been working with some clients this way. Do you think we can start writing a draft on the staging of the developer center?

Yes, @jsanz detected this pattern some time ago with the Auth API too. :) I think that we could start the documentation draft for the usage of the Auth API.

yeah, that'd be super useful
@oriolbx do you mind start rolling the ball? :smile:
Since we (CARTO Solutions Team) should be doing this procedure more and more, it'd be great for you to have a chat with @inigomedina on the best way to tackle the guide contribution process and eventually explain to the rest of the team afterward.

Ok! :)

Already on https://carto.com/developers/auth-api/guides/Authorizaration-CARTO-views/

Awesome! Now we just need to fix that url, right? 😛
--
Jorge Sanz
CARTO - Predict through location
Sent from my phone, excuse my brevity and typos
El mié., 16 may. 2018 8:52, Oriol<EMAIL_ADDRESS>escribió:

Already on
https://carto.com/developers/auth-api/guides/Authorizaration-CARTO-views/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/13920#issuecomment-389414002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALfaHbd3uqtl-ZxU1jDqWNbZAnH9ZZ0ks5ty8y0gaJpZM4TxHZc
.

Awesome, @oriolbx. 👏
Let's fix the url, and then use this resource in any conversation through support related to a similar problem, so that this resource becomes the first response.

@oriolbx, can you fix that URL? 🙏

Sure, what should be the correct URL?

From guides/Authorizaration-CARTO-views/ to guides/Authorization-for-CARTO-views/. Look at the typo in Authorizaration, it's also present in the left menu.

Pull request has been merged but the changes haven't been applied yet

Updated URL: https://carto.com/developers/auth-api/guides/Authorization-CARTO-views/


Keyset pagination - aggregate field must be included in query when sorting on that field

When performing a keyset paginated read that sorts on an aggregate field, an error occurs if that same aggregate field is not also included in the GQL query. The error only occurs when loading the second page specifying an after value.
Assuming that the Post resource has an aggregate field called authorName, this query to get the first page works as expected:
query KeysetPaginatedPosts {
  keysetPaginatedPosts(
  sort: [{field: AUTHOR_NAME}]
  first: 1
) {
    count
    startKeyset
    endKeyset
    results{
      id
    }
  }
}

Taking the endKeyset value from the first query, and using it to request the second page causes the error to occur:
query KeysetPaginatedPosts {
  keysetPaginatedPosts(
  sort: [{field: AUTHOR_NAME}]
  first: 1
  after: "keyset value from first query here"
) {
    count
    startKeyset
    endKeyset
    results{
      id
    }
  }
}

The error is:
** (Ash.Error.Unknown) Unknown Error

* ** (Ecto.Query.CastError) deps/ash_postgres/lib/expr.ex:485: value `#Ash.NotLoaded<:aggregate>` in `where` cannot be cast to type #Ash.Type.StringWrapper.EctoType<[]> in query

The issue can be worked around by including the aggregate field name in the query, and then fetching the second page works as expected.
query KeysetPaginatedPosts {
  keysetPaginatedPosts(
  sort: [{field: AUTHOR_NAME}]
  first: 1
) {
    count
    startKeyset
    endKeyset
    results{
      id
      authorName
    }
  }
}

Thanks for the report, I'll take a look tomorrow!

This should be solved in ash version 2.9.18 :) Its building from CI currently, and will be released shortly.

This is confirmed fixed in my codebase now. Thank you!


"Search: Focus Next Search Result" should put cursor in the editor panel

Issue Type: Feature Request
When going through large refactorings based on search keywords it would be really nice if the F4 Keybind would actually put the cursor in the code instead of just highlighting and focusing the next item.
EDIT: Currently the cursor only lands on the sighting if it was in the same file.
VS Code version: Code - Insiders 1.35.0-insider (4ca38ce5584d7cd67b435b3c32ef1240c6a29628, 2019-05-21T05:18:31.618Z)
OS version: Windows_NT x64 10.0.17763

related https://github.com/Microsoft/vscode/issues/69443

I just verified that this is a regression using the following version:
Version: 1.33.0 (system setup)
Commit: 0dd516dd412d42323fc3464531b1c715d51c4c1a
Date: 2019-04-04T15:14:28.026Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

@roblourens , I just looked at this and found the following
This is where the focus is set
next.range().startLineNumber will give the lineNumber , But i could not figure out how to put cursor there ?

That block fires an event which is debounced, then handled here: https://github.com/microsoft/vscode/blob/8cd962e8418660e52f4bb0a1896e085469e81bb9/src/vs/workbench/contrib/search/browser/searchView.ts#L710
The problem is probably in this code which handles selection and decides whether to preserveFocus (should be false for focus to go to editor) https://github.com/microsoft/vscode/blob/master/src/vs/platform/list/browser/listService.ts#L726
This code is a bit weird so it might be hard to understand. Or it might be an obvious mistake, not sure :)

Oh now that's how that works.. i was trying my best... i'm not a TS dev but gave it a try and threw me off real hard 🤣🤣🤣

@roblourens , Found the issue.

onSelection was not being called after we do setSelection
The reason why this was not called is because of the function being registered this way
So there are two possible ways of fixing this , By removing the condition in listService OR
by setting the openOnSelection to true here

PS : I thought the second way makes more sense and sent a PR for the same.

Thanks @skprabhanjan but this is quite tricky and I am still not sure that I haven't broken something else.


[to be merged with 2 other address search PRs] Address search

All looks good.

reviewed this alongside the other stuff looks legit


Introduce Vector#match_substring?

Introduce Vector#match_substring?(pattern, ignore_case: nil)

#match_substring?(string): tests with a string, returns boolean Vector.
#match_substring?(regexp): tests with a regexp, returns boolean Vector.

#209 .


Identifiers validation failed for dataset Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila

Identifier validation failed for the dataset Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila:

Crawler attempt: 323
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 74
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 74 total records; 74 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740405/step

New IDs sample:

Old IDs sample:

0429a4a3a01c765441da0545604f0a19
0591f0a342d4639fb66683ad8c96abd6
0a807c9d33cdffcebe87cb1b2c2bd0ab
131363236de7a517c81da1433272e323
150bd943f7d4d118d77d4cae835942b9
15c6b68ece12f1733f76e6d46d545875
1caba5ef7f39a33806154860529bce7c
1cc16c8ebf25fcf6463abbc929eb82db
235d023bc2c2229318b6585188d46313
24e9f036ae5fc382181deddc71148b47

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila : https://doi.org/10.15468/hesa5e.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila:

Crawler attempt: 324
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 74
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 74 total records; 74 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741214/step

New IDs sample:

Old IDs sample:

0429a4a3a01c765441da0545604f0a19
0591f0a342d4639fb66683ad8c96abd6
0a807c9d33cdffcebe87cb1b2c2bd0ab
131363236de7a517c81da1433272e323
150bd943f7d4d118d77d4cae835942b9
15c6b68ece12f1733f76e6d46d545875
1caba5ef7f39a33806154860529bce7c
1cc16c8ebf25fcf6463abbc929eb82db
235d023bc2c2229318b6585188d46313
24e9f036ae5fc382181deddc71148b47

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila : https://doi.org/10.15468/hesa5e.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila:

Crawler attempt: 326
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 74
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 74 total records; 74 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741841/step

New IDs sample:

Old IDs sample:

0429a4a3a01c765441da0545604f0a19
0591f0a342d4639fb66683ad8c96abd6
0a807c9d33cdffcebe87cb1b2c2bd0ab
131363236de7a517c81da1433272e323
150bd943f7d4d118d77d4cae835942b9
15c6b68ece12f1733f76e6d46d545875
1caba5ef7f39a33806154860529bce7c
1cc16c8ebf25fcf6463abbc929eb82db
235d023bc2c2229318b6585188d46313
24e9f036ae5fc382181deddc71148b47

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Estudio poblacional de Turbinicarpus valdezianus en el Cañón de las Bayas, Municipio de Arteaga, Coahuila : https://doi.org/10.15468/hesa5e.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


watch for report changes

If changes are made to report files, then Quarkus should restart, just the same as if Java source files are changed.

@all-contributors add @nderwin for code


feat(log-viewer): add ansi color support for logs

Closes https://github.com/portainer/portainer/issues/1654
This PR adds colorized output for logs by parsing foreground and background color ANSI codes and generating spans with CSS styles applied, and it does not interpret the log text as HTML as mentioned in https://github.com/portainer/portainer/pull/1666
Color output can be tested using colortest, for example via this image: ricmatsui/colortest
And no problem if this is wrapped into https://github.com/portainer/portainer/issues/3749

Awesome @ricmatsui, I'll have a look shortly.

/azp run

/azp run

@pull-dog down

@pull-dog up

@pull-dog down

Thanks for reviewing @deviantony I've added a fix for copying logs and https://github.com/portainer/portainer/pull/4367 would also fix the commas being added

/azp run

@pull-dog down

@pull-dog up

@pull-dog down

Related to https://github.com/portainer/portainer/issues/3749

@itsconquest ready for test :)


Fixed-navbar logo gets pulled right and stuck when using slider on mobile

Helping a fellow user @andersonsouzars from chat post their issue.
When using a fixed-navbar with a slider below on mobile, the center "logo" gets pulled to the right and stuck when user scroll-drags to the right with the actual slider image, not the indicator buttons. Once it's stuck it won't move back when trying to scroll the opposite way. This only happens on mobile, as a few people tried testing the problem with chrome dev tools, but it doesn't let you scroll drag the images.
Image: https://files.gitter.im/Dogfalo/materialize/MTdB/blob
Code: here
Thanks!

+1 this is happening on iOS/safari for me.

I'm unable to reproduce it :/
Could you check if this is still an issue with the last version?
Closed due inactivity, feel free to reopen it if it is still necessary.

Works with the latest version: https://codepen.io/anon/pen/gmNRZq


Support detecting .lgtm file inside .github folder

Github has now supporting .github folder for these kind of configuration. Issue and PR templates are detected if they are in .github folder.
LGTM can do the same too.

I recommend altering the following function [1] to accept a list of files:
-GetContents(*model.User, *model.Repo, string) ([]byte, error)
+GetContents(*model.User, *model.Repo, string...) ([]byte, error)

This function would then return the first file in the list it is able to successfully download. We could then specify [2] multiple configuration files paths including in the .github directory:
-GetContents(c, user, repo, ".lgtm") ([]byte, error)
+GetContents(c, user, repo, ".lgtm", ".github/.lgtm") ([]byte, error)

This change shouldn't be too difficult, however, I have other priorities and am therefore marking this issue as help wanted. If anyone is interested in sending a pull request let me know!
[1] https://github.com/lgtmco/lgtm/blob/master/remote/remote.go#L45
[2] https://github.com/lgtmco/lgtm/blob/master/web/hook.go#L40


Appreciate it

It's just an appreciation not an issue i am really really thankful that you added the series option too its working great.Thanks Man
P.S-You can close this "issue" after you're done reading

Thanks @Zeroo097


All Gather Regression

Commit https://github.com/tenstorrent/tt-metal/commit/4fe8c0e717fab7c4f0a402b80ef8d7fb55e88b1d
causes a regression of test
pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit[mem_config0-input_dtype0-4-2-input_shape0-0-layout0]
with error Always | FATAL    | Max number of packed sub commands are 28 but requesting 32

Moving to P0 as this is blocking other changes from being tested and merged.

Merged the fix to main. Confirm it now passes on ci https://github.com/tenstorrent/tt-metal/actions/runs/9892002446


3730 - Port over FedKeyPairGen Tool to StratisBitcoinFullNode

FederationSetup and StratisFederationApp projects migrated to Full Node from FederatedPeg repository. Repository history is also preserved.

@YakupIpek please fixed conflicts.

@fassadlr  Conflicts are fixed now.


Update CONTRIBUTING.md

Associated Issue

Closes N/A
Implemented Solution

N/A

@all-contributors please add @The-Debarghya for docs


freebsd adding getrandom interception.

note that os support was added in same time as getentropy.

@rustbot review

Looking good, thanks!
@bors r+

:pushpin: Commit 2ef304c8e890c57abd6116a5a73a562ab0bb4e79 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 2ef304c8e890c57abd6116a5a73a562ab0bb4e79 with merge 0533425e5cc342a1c007e86351aec75d1f9cbc8d...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 0533425e5cc342a1c007e86351aec75d1f9cbc8d to master...


Support Amazon linux 2

Issues Resolved
#17
@peterzhuamazon  Tested the playbook with latest amazon linux 2, its compatible for almost all tasks except one which is fixed now.

Logs
PLAY [opensearch installation & configuration] ************************************************************************************************************************
TASK [Gathering Facts] ************************************************************************************************************************************************
ok: [os3]
ok: [os5]
ok: [os4]
ok: [os2]
ok: [os1]
TASK [centos7/opensearch : hostname] **********************************************************************************************************************************
changed: [os3]
changed: [os5]
changed: [os2]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Install the libselinux-python for Amazon Linux 2] ******************************************************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os1]
changed: [os2]
TASK [centos7/opensearch : Disable the selinux] ***********************************************************************************************************************
ok: [os3]
ok: [os4]
ok: [os2]
ok: [os5]
ok: [os1]
TASK [centos7/opensearch : Hosts | populate inventory into hosts file] ************************************************************************************************
changed: [os3]
changed: [os4]
changed: [os5]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Set vm.max_map_count in sysctl.conf] *******************************************************************************************************
changed: [os3]
changed: [os5]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Set open files limit in sysctl.conf] *******************************************************************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : OpenSearch Install | Download opensearch 1.2.0] ********************************************************************************************
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
changed: [os5]
TASK [centos7/opensearch : OpenSearch Install | Create opensearch user] ***********************************************************************************************
changed: [os5]
changed: [os3]
changed: [os1]
changed: [os4]
changed: [os2]
TASK [centos7/opensearch : OpenSearch Install | Create home directory] ************************************************************************************************
changed: [os3]
changed: [os5]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : OpenSearch Install | Extract the tar file] *************************************************************************************************
[WARNING]: Consider using the unarchive module rather than running tar.  If you need to use command because unarchive is insufficient you can add warn=False to this
command task or set command_warnings=False in ansible.cfg to get rid of this message.
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : OpenSearch Install | Copy Configuration File] **********************************************************************************************
changed: [os3]
changed: [os5]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : OpenSearch Install | Copy jvm.options File for Instance] ***********************************************************************************
changed: [os3]
changed: [os5]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : OpenSearch Install | create systemd service] ***********************************************************************************************
changed: [os3]
changed: [os5]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Create local temporary directory for certificates generation] **********************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Download certificates generation tool] *********************************************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Extract the certificates generation tool] ******************************************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Make the executable file] **********************************************************************************
ok: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Prepare the certificates generation template file] *********************************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Generate the node & admin certificates in local] ***********************************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Security Plugin configuration | Copy the node & admin certificates to opensearch nodes] ****************************************************
changed: [os3] => (item=root-ca.pem)
changed: [os5] => (item=root-ca.pem)
changed: [os4] => (item=root-ca.pem)
changed: [os3] => (item=root-ca.key)
changed: [os1] => (item=root-ca.pem)
changed: [os5] => (item=root-ca.key)
changed: [os2] => (item=root-ca.pem)
changed: [os3] => (item=os3.key)
changed: [os5] => (item=os5.key)
changed: [os4] => (item=root-ca.key)
changed: [os3] => (item=os3.pem)
changed: [os2] => (item=root-ca.key)
changed: [os1] => (item=root-ca.key)
changed: [os5] => (item=os5.pem)
changed: [os3] => (item=os3_http.key)
changed: [os4] => (item=os4.key)
changed: [os5] => (item=os5_http.key)
changed: [os3] => (item=os3_http.pem)
changed: [os2] => (item=os2.key)
changed: [os1] => (item=os1.key)
changed: [os5] => (item=os5_http.pem)
changed: [os3] => (item=admin.key)
changed: [os4] => (item=os4.pem)
changed: [os5] => (item=admin.key)
changed: [os2] => (item=os2.pem)
changed: [os3] => (item=admin.pem)
changed: [os1] => (item=os1.pem)
changed: [os5] => (item=admin.pem)
changed: [os4] => (item=os4_http.key)
changed: [os2] => (item=os2_http.key)
changed: [os4] => (item=os4_http.pem)
changed: [os1] => (item=os1_http.key)
changed: [os2] => (item=os2_http.pem)
changed: [os4] => (item=admin.key)
changed: [os1] => (item=os1_http.pem)
changed: [os2] => (item=admin.key)
changed: [os4] => (item=admin.pem)
changed: [os1] => (item=admin.key)
changed: [os2] => (item=admin.pem)
changed: [os1] => (item=admin.pem)
TASK [centos7/opensearch : Security Plugin configuration | Copy the security configuration file 1 to cluster] *********************************************************
changed: [os5]
changed: [os3]
changed: [os2]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Copy the security configuration file 2 to cluster] *********************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Prepare the opensearch security configuration file] ********************************************************
[WARNING]: Consider using the replace, lineinfile or template module rather than running sed.  If you need to use command because replace, lineinfile or template is
insufficient you can add warn=False to this command task or set command_warnings=False in ansible.cfg to get rid of this message.
changed: [os3]
changed: [os5]
changed: [os2]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Set the file ownerships] ***********************************************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Set the folder permission] *********************************************************************************
changed: [os5]
changed: [os3]
changed: [os2]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Restart opensearch with security configuration] ************************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Pause for 3 seconds to provide sometime for OpenSearch start] ******************************************************************************
Pausing for 3 seconds
(ctrl+C then 'C' = continue early, ctrl+C then 'A' = abort)
ok: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Copy the opensearch security internal users template] ******************************************************
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Set the Admin user password] *******************************************************************************
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Set the kibanaserver user pasword] *************************************************************************
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Initialize the opensearch security index in opensearch] ****************************************************
changed: [os1]
TASK [centos7/opensearch : Security Plugin configuration | Cleanup local temporary directory] *************************************************************************
changed: [os1 -> localhost]
TASK [centos7/opensearch : Remove cluster.initial_master_nodes setting from configuration] **************************************************************************
changed: [os3]
changed: [os5]
changed: [os2]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Make sure opensearch is started] ***********************************************************************************************************
ok: [os3]
ok: [os5]
ok: [os4]
ok: [os2]
ok: [os1]
TASK [centos7/opensearch : Get all the installed ES plugins] **********************************************************************************************************
changed: [os5]
changed: [os3]
changed: [os4]
changed: [os2]
changed: [os1]
TASK [centos7/opensearch : Show all the installed ES plugins] *********************************************************************************************************
ok: [os1] => {
"msg": "opensearch-alerting\nopensearch-anomaly-detection\nopensearch-asynchronous-search\nopensearch-cross-cluster-replication\nopensearch-index-management\nopensearch-job-scheduler\nopensearch-knn\nopensearch-observability\nopensearch-performance-analyzer\nopensearch-reports-scheduler\nopensearch-security\nopensearch-sql"
}
ok: [os2] => {
"msg": "opensearch-alerting\nopensearch-anomaly-detection\nopensearch-asynchronous-search\nopensearch-cross-cluster-replication\nopensearch-index-management\nopensearch-job-scheduler\nopensearch-knn\nopensearch-observability\nopensearch-performance-analyzer\nopensearch-reports-scheduler\nopensearch-security\nopensearch-sql"
}
ok: [os3] => {
"msg": "opensearch-alerting\nopensearch-anomaly-detection\nopensearch-asynchronous-search\nopensearch-cross-cluster-replication\nopensearch-index-management\nopensearch-job-scheduler\nopensearch-knn\nopensearch-observability\nopensearch-performance-analyzer\nopensearch-reports-scheduler\nopensearch-security\nopensearch-sql"
}
ok: [os4] => {
"msg": "opensearch-alerting\nopensearch-anomaly-detection\nopensearch-asynchronous-search\nopensearch-cross-cluster-replication\nopensearch-index-management\nopensearch-job-scheduler\nopensearch-knn\nopensearch-observability\nopensearch-performance-analyzer\nopensearch-reports-scheduler\nopensearch-security\nopensearch-sql"
}
ok: [os5] => {
"msg": "opensearch-alerting\nopensearch-anomaly-detection\nopensearch-asynchronous-search\nopensearch-cross-cluster-replication\nopensearch-index-management\nopensearch-job-scheduler\nopensearch-knn\nopensearch-observability\nopensearch-performance-analyzer\nopensearch-reports-scheduler\nopensearch-security\nopensearch-sql"
}
TASK [centos7/opensearch : Wait for opensearch to startup] ************************************************************************************************************
ok: [os5]
ok: [os3]
ok: [os4]
ok: [os2]
ok: [os1]
TASK [centos7/opensearch : Check the opensearch status] ***************************************************************************************************************
[WARNING]: Consider using the get_url or uri module rather than running curl.  If you need to use command because get_url or uri is insufficient you can add
warn=False to this command task or set command_warnings=False in ansible.cfg to get rid of this message.
changed: [os3]
changed: [os2]
changed: [os5]
changed: [os4]
changed: [os1]
TASK [centos7/opensearch : Show the opensearch status] ****************************************************************************************************************
ok: [os1] => {
"failed_when_result": false,
"msg": {
"active_primary_shards": 2,
"active_shards": 7,
"active_shards_percent_as_number": 100.0,
"cluster_name": "development-cluster",
"delayed_unassigned_shards": 0,
"discovered_master": true,
"initializing_shards": 0,
"number_of_data_nodes": 5,
"number_of_in_flight_fetch": 0,
"number_of_nodes": 5,
"number_of_pending_tasks": 0,
"relocating_shards": 0,
"status": "green",
"task_max_waiting_in_queue_millis": 0,
"timed_out": false,
"unassigned_shards": 0
}
}
ok: [os2] => {
"failed_when_result": false,
"msg": {
"active_primary_shards": 2,
"active_shards": 7,
"active_shards_percent_as_number": 100.0,
"cluster_name": "development-cluster",
"delayed_unassigned_shards": 0,
"discovered_master": true,
"initializing_shards": 0,
"number_of_data_nodes": 5,
"number_of_in_flight_fetch": 0,
"number_of_nodes": 5,
"number_of_pending_tasks": 0,
"relocating_shards": 0,
"status": "green",
"task_max_waiting_in_queue_millis": 0,
"timed_out": false,
"unassigned_shards": 0
}
}
ok: [os3] => {
"failed_when_result": false,
"msg": {
"active_primary_shards": 2,
"active_shards": 7,
"active_shards_percent_as_number": 100.0,
"cluster_name": "development-cluster",
"delayed_unassigned_shards": 0,
"discovered_master": true,
"initializing_shards": 0,
"number_of_data_nodes": 5,
"number_of_in_flight_fetch": 0,
"number_of_nodes": 5,
"number_of_pending_tasks": 0,
"relocating_shards": 0,
"status": "green",
"task_max_waiting_in_queue_millis": 0,
"timed_out": false,
"unassigned_shards": 0
}
}
ok: [os4] => {
"failed_when_result": false,
"msg": {
"active_primary_shards": 2,
"active_shards": 7,
"active_shards_percent_as_number": 100.0,
"cluster_name": "development-cluster",
"delayed_unassigned_shards": 0,
"discovered_master": true,
"initializing_shards": 0,
"number_of_data_nodes": 5,
"number_of_in_flight_fetch": 0,
"number_of_nodes": 5,
"number_of_pending_tasks": 0,
"relocating_shards": 0,
"status": "green",
"task_max_waiting_in_queue_millis": 0,
"timed_out": false,
"unassigned_shards": 0
}
}
ok: [os5] => {
"failed_when_result": false,
"msg": {
"active_primary_shards": 2,
"active_shards": 7,
"active_shards_percent_as_number": 100.0,
"cluster_name": "development-cluster",
"delayed_unassigned_shards": 0,
"discovered_master": true,
"initializing_shards": 0,
"number_of_data_nodes": 5,
"number_of_in_flight_fetch": 0,
"number_of_nodes": 5,
"number_of_pending_tasks": 0,
"relocating_shards": 0,
"status": "green",
"task_max_waiting_in_queue_millis": 0,
"timed_out": false,
"unassigned_shards": 0
}
}
TASK [centos7/opensearch : Verify the roles of opensearch cluster nodes] **********************************************************************************************
changed: [os1]
TASK [centos7/opensearch : Show the roles of opensearch cluster nodes] ************************************************************************************************
ok: [os1] => {
"msg": "ip          heap.percent ram.percent cpu load_1m load_5m load_15m node.role master name\n<IP_ADDRESS>            22          96  14    0.23    0.15     0.06 di        -      os5\n<IP_ADDRESS>           17          95  14    0.28    0.19     0.08 di        -      os4\n<IP_ADDRESS>           20          95  25    0.40    0.25     0.10 dm        -      os2\n<IP_ADDRESS>           14          93  25    0.68    0.32     0.13 dm        -      os1\n<IP_ADDRESS>             6          96  15    0.23    0.16     0.07 dm        *      os3"
}
PLAY [opensearch dashboards installation & configuration] *************************************************************************************************************
TASK [Gathering Facts] ************************************************************************************************************************************************
ok: [dashboards1]
TASK [centos7/dashboards : hostname] **********************************************************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Install the libselinux-python for Amazon Linux 2] ******************************************************************************************
ok: [dashboards1]
TASK [centos7/dashboards : Disable the selinux] ***********************************************************************************************************************
ok: [dashboards1]
TASK [centos7/dashboards : Hosts | populate inventory into hosts file] ************************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Set open files limit in sysctl.conf] *******************************************************************************************************
ok: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | Download opensearch dashbaord 1.2.0] **********************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | Create opensearch user] ***********************************************************************************************
ok: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | Create home directory] ************************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | Extract the tar file] *************************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | Copy Configuration File] **********************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Dashboards Install | create systemd service] ***********************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Make sure opensearch dashboards is started] ************************************************************************************************
changed: [dashboards1]
TASK [centos7/dashboards : Get all the installed dashboards plugins] **************************************************************************************************
[WARNING]: Consider using 'become', 'become_method', and 'become_user' rather than running sudo
changed: [dashboards1]
TASK [centos7/dashboards : Show all the installed dashboards plugins] *************************************************************************************************
ok: [dashboards1] => {
"msg": "alertingDashboards@<IP_ADDRESS>\nanomalyDetectionDashboards@<IP_ADDRESS>\nganttChartDashboards@<IP_ADDRESS>\nindexManagementDashboards@<IP_ADDRESS>\nobservabilityDashboards@<IP_ADDRESS>\nqueryWorkbenchDashboards@<IP_ADDRESS>\nreportsDashboards<EMAIL_ADDRESS>}
PLAY RECAP ************************************************************************************************************************************************************
dashboards1                : ok=15   changed=9    unreachable=0    failed=0
os1                        : ok=42   changed=33   unreachable=0    failed=0
os2                        : ok=28   changed=22   unreachable=0    failed=0
os3                        : ok=28   changed=22   unreachable=0    failed=0
os4                        : ok=28   changed=22   unreachable=0    failed=0
os5                        : ok=28   changed=22   unreachable=0    failed=0

@peterzhuamazon

The folder name is still centos7, can we change to something else or remove the folder?

Changed to linux.

Can you also update the README to include AL2? As of now only centos7 is mentioned.

Done

I recently noticed that a lot of people still using Oracle Linux which is also RedHat based, if that can be test and support at some time it would be great.

Sure, created an issue #22

Seems like there are some conflicts after my merge of #19.
I will test this once the conflicts are resolved.
Thanks.

@peterzhuamazon  merge conflicts are resolved. Please continue with test.

@peterzhuamazon  We need to merge this PR before any other PR's. Because this one have major change (folder changed from centos7 into linux) so it keep creating merge conflicts whenever new PR is merged and thus creating duplication work.
Could you please prioritize this one?
May be we can have a call today to close this and ubuntu PR.

Hi @saravanan30erd I am releasing 1.2.3 now so very little time on my side.
Can we have a discussion for this later?
Meanwhile, @TheAlgo if you can take a look it would be great.
Thanks.

Update: I will update this PR today with more comments of testing.
Able to find a small time window to do some tests.
Sorry about delays.

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'selinux'
fatal: [os2]: FAILED! => {"changed": false, "msg": "Failed to import the required Python library (libselinux-python) on os2's Python /usr/bin/python3.7. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}

@peterzhuamazon  but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter may be its using wrong interpreter python 3 because in my case, its used python2.7 and I didn't face this issue. There was lot of issues due to different python versions since centos7/RHEL7 uses python2.7 only and AL2 have both python2.7 & 3, ubuntu only having python 3. so we need to stick with some stable ansible version which supports all. Can we have a call to check this?

@peterzhuamazon but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter may be its using wrong interpreter python 3 because in my case, its used python2.7 and I didn't face this issue. There was lot of issues due to different python versions since centos7/RHEL7 uses python2.7 only and AL2 have both python2.7 & 3, ubuntu only having python 3. so we need to stick with some stable ansible version which supports all. Can we have a call to check this?

Reply email.

Verified AL2:
IP  28 27 0 0.00 0.06 0.03 di - os5
IP  8 36 2 0.01 0.12 0.07 dm * os1
IP 26 27 0 0.00 0.08 0.05 di - os4
IP 27 27 0 0.00 0.06 0.03 dm - os2
IP 25 27 0 0.02 0.07 0.03 dm - os3

$ curl https://IP:9200/_cluster/health?pretty -u admin:admin --insecure
{
  "cluster_name" : "development-cluster",
  "status" : "green",
  "timed_out" : false,
  "number_of_nodes" : 5,
  "number_of_data_nodes" : 5,
  "discovered_master" : true,
  "active_primary_shards" : 3,
  "active_shards" : 9,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 0,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 100.0
}


Trigger workflows for pull requests

Currently workflows only trigger on push. This means that pull requests from forks do not trigger actions to run, and as such can not be merged.

All actions updated


Fix ng link for the multiple bigstitcher run

[x] There is a typo in the solution filename pattern. It should be bigstitcher.xml~1 and not bigstitcher~1.xml.
[x] Fix the broken run with re-running the ng link generation in the interactive notebook.

[ ] Add ng_links to the DataProcess.outputs.

[ ] New exaSPIM datasets will have multiple signal channels that we want to process independently at the moment. Add a channel option to the pipeline select one explicitly to process and verify its consistency with the metadata.


Dependent Suspense Queries

Currently dependent queries can be used only with atomWithQuery.
In the scenario of 2 atoms, we can get the result of the first atom by unwrap which resolves to be undefined/Result. We use the enabled flag on the 2nd atom to make the API request only when its 'Result'
We cannot await because these atoms don't support async getOptions.

Does #30 help? Or it's unrelated.

Same problem here, unfortunately :-/

#30 would have helped, except it was removed in 0.8.0...
...so it's not possible to use Suspense and dependent queries at the same time at all now?

In relation to this comment and this PR - I have a idea how to retrieve this feature.
My proposal involves abandoning the use of baseAtomWithQuery and separating the implementation of atomWithQuery and atomWithSuspenseQuery.
In my view, the main distinction between query hooks and atoms lies in the fact that hooks serve as a proxy for the queryObserver API, whereas atoms need to hold a value. This complexity becomes apparent when trying to achieve sometimes-async functionality.
Due to this difference, atoms cannot replicate the implementation of hooks, requiring a different approach.
I'd like to hear your opinion on this approach @kalijonn

In my view, the main distinction between query hooks and atoms lies in the fact that hooks serve as a proxy for the queryObserver API, whereas atoms need to hold a value. This complexity becomes apparent when trying to achieve sometimes-async functionality.

Interesting take. My mental model was that an atom is a proxy for the store. atom itself doesn't hold a value but a config that lets you get that value from the store. My mental model around a store was that it's an observable. In libraries like jotai-tanstack-query and jotai-urql, we are working with an additional observable. In the read function of the atoms, we also setup a subscription (to the additional observable - tanstack/urql).
I would love to know what @dai-shi  thinks.
But I agree that it needs a different approach compared to hooks. With hooks, we are leveraging react to suspend when the 1st query is in flight which ensures the 2nd query is never triggered. And when 1st query is completed, 2nd query can access it's contents and the component still suspends until the 2nd query is resolved. The problem with our scenario is the dependency graph is outside react. While the component suspends while the 1st query is in flight, it doesn't stop the 2nd query from fetching.
This makes me want to try creating a Promise that doesn't resolve or reject until both are done synchronously. I've worked on this so long ago that I don't remember if I tried this already and found some issue.

Well, an atom has a value in a store, and we try best to synchronize it with the outside world. It's the same with hooks, hooks have values in a React fiber.

The problem with our scenario is the dependency graph is outside react.

I agree that it's the difference.

Sorry, I took some mental shortcuts and it seem to be a cause of misunderstanding.
When using useQuery/useSuspenseQuery state is held in two places - query cache, and in react fibers.
When using atomWithQuery/atomWithSuspenseQuery state is held in three places - query cache, react fibers and in jotai store.
When component is getting unmounted, then query result is no longer kept as state of react fiber.
When component is getting mounted again (eg. after resetting error boundary) we can run some code (eg. reset query) before react fiber will establish it's state.
Therefore, if query result has an error, we can somehow modify query state, before agreeing what should be the state for react fiber.
With jotai it's getting more complicated, because if query atom has an error (mental shortcut there - as You have mentioned, atom is a proxy for fragment of store), we need to either manually set value for that atom, or somehow trigger recalculation of that atom.
I propose to cut this discussion out there, and move it to #75.


IN ALE, Show in Map function should link to Location Services in Action instead of gmaps

Done locally. Note that rather than use the lat/lon, it uses the input addressString value, ie. it links to:
https://ols-demo.apps.gov.bc.ca/index.html?q=1207+douglas+st
instead of:
https://ols-demo.apps.gov.bc.ca/index.html?q=48.4256448,-123.3647132
This has the benefit of displaying the actual info about the address match in the demo app. I've set it up so that the ALE now uses the same "?env=(dlv|tst|rri)" options that the ols-demo uses, in order to specify which geocoder to use. It also passes the env option through to the demo app, so that it uses the same version of the geocoder, which ensures consistency of the results being shown.

The demo app should call the ALE with the fullAddress value, not the addressString value.

Change made and committed to github, viewable here: https://cmhodgson.github.io/ols-devkit/ale/


Version Information

Run go version to get version of Go from the VS Code integrated terminal.

go version go1.19.3 windows/amd64

Run gopls -v version to get version of Gopls from the VS Code integrated terminal.

golang.org/x/tools/gopls v0.10.1

Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.

1.73.1

Check your installed extensions to get the version of the VS Code Go extension

0.36.0

Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.

GOBIN: undefined
toolsGopath:
gopath: C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go
GOROOT: C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go
PATH: C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR;C:\Program Files\dotnet\;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\System32\Wbem;%SYSTEMROOT%\System32\WindowsPowerShell\v1.0\;%SYSTEMROOT%\System32\OpenSSH\;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Programs\Python\Python310\Scripts\;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Programs\Python\Python310\;%PNPM_HOME%;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Programs\Python\Launcher\;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Microsoft\WindowsApps;C:\Users\root.DESKTOP-FTCACMV\.aftman\bin;C:\Users\root.DESKTOP-FTCACMV\.deno\bin;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\JetBrains\Toolbox\scripts;C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Microsoft\WindowsApps;C:\Users\root.DESKTOP-FTCACMV\VSCodium-win32-x64-<IP_ADDRESS>89;C:\Users\root.DESKTOP-FTCACMV\VSCodium-win32-x64-<IP_ADDRESS>89\bin;C:\Users\root.DESKTOP-FTCACMV\AppData\Local\Programs\Hyper\resources\bin;C:\Users\root.DESKTOP-FTCACMV\node\node-v18.12.1-win-x64\node_modules\npm\bin;C:\Users\root.DESKTOP-FTCACMV\node\node-v18.12.1-win-x64\node_modules\npm;C:\Users\root.DESKTOP-FTCACMV\node\node-v18.12.1-win-x64;C:\Users\root.DESKTOP-FTCACMV\AppData\Roaming\Spotify;C:\Users\root.DESKTOP-FTCACMV\git;C:\Users\root.DESKTOP-FTCACMV\git\bin;

	go:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\go.exe: go version go1.19.3 windows/amd64

	gotests:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\gotests.exe	(version: v1.6.0 built with go: go1.19.3)
	gomodifytags:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\gomodifytags.exe	(version: v1.16.0 built with go: go1.19.3)
	impl:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\impl.exe	(version: v1.1.0 built with go: go1.19.3)
	goplay:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\goplay.exe	(version: v1.0.0 built with go: go1.19.3)
	dlv:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\dlv.exe	(version: v1.9.1 built with go: go1.19.3)
	golint:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\golint.exe	(version: v0.0.0-20210508222113-6edffad5e616 built with go: go1.19.3)
	gopls:	C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\bin\gopls.exe	(version: v0.10.1 built with go: go1.19.3)

go env
Workspace Folder (nemo): c:\Users\root.DESKTOP-FTCACMV\dev\nemo
	set GO111MODULE=
	set GOARCH=amd64
	set GOBIN=
	set GOCACHE=C:\Users\root.DESKTOP-FTCACMV\AppData\Local\go-build
	set GOENV=C:\Users\root.DESKTOP-FTCACMV\AppData\Roaming\go\env
	set GOEXE=.exe
	set GOEXPERIMENT=
	set GOFLAGS=
	set GOHOSTARCH=amd64
	set GOHOSTOS=windows
	set GOINSECURE=
	set GOMODCACHE=C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\pkg\mod
	set GONOPROXY=
	set GONOSUMDB=
	set GOOS=windows
	set GOPATH=C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go
	set GOPRIVATE=
	set GOPROXY=https://proxy.golang.org,direct
	set GOROOT=C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go
	set GOSUMDB=sum.golang.org
	set GOTMPDIR=
	set GOTOOLDIR=C:\Users\root.DESKTOP-FTCACMV\go1.19.3.windows-amd64\go\pkg\tool\windows_amd64
	set GOVCS=
	set GOVERSION=go1.19.3
	set GCCGO=gccgo
	set GOAMD64=v1
	set AR=ar
	set CC=gcc
	set CXX=g++
	set CGO_ENABLED=1
	set GOMOD=c:\Users\root.DESKTOP-FTCACMV\dev\nemo\go.mod
	set GOWORK=
	set CGO_CFLAGS=-g -O2
	set CGO_CPPFLAGS=
	set CGO_CXXFLAGS=-g -O2
	set CGO_FFLAGS=-g -O2
	set CGO_LDFLAGS=-g -O2
	set PKG_CONFIG=pkg-config
	set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\ROOT~1.DES\AppData\Local\Temp\go-build2785085047=/tmp/go-build -gno-record-gcc-switches

Share the Go related settings you have added/edited
None, all default.
Describe the bug
The lint process of the extension is extremely bugged, and ends up deleting random bunches of code. If you save it during this process, the file's contents get discarded entirely.
Steps to reproduce the behavior:

Create a large file, with over 300 lines of code.
Make some changes, and save the file.
If you instantly save the file once you input your code (possibly before the code can be checked by the extension), it discards all the changes made.
If you wait for a minute before saving the file (possibly after the code has been checked by the extension), it removes random characters from your code and saves the file.

Screenshots or recordings
Following are screenshots of before and after saving a file with changes made. Notice how the fmt.Sprint(instanceCheckingErr) I added magically disappears once saved.
Before:

After:

Thanks, while we haven't yet reproduced locally, I think we have enough information about the nature of the bug. I have transferred this to the Go issue tracker.

@CompeyDev unfortunately this is going to take a little while to fix. We have ideas, but it is a rather low level bug. We will try to fix this for the next minor release, which is slated for ~February, but there is no guarantee.

@CompeyDev unfortunately this is going to take a little while to fix. We have ideas, but it is a rather low level bug. We will try to fix this for the next minor release, which is slated for ~February, but there is no guarantee.

Understood, is there at least a way I can mitigate this? It is quite disruptive at the moment.

@CompeyDev sorry for missing your last comment. If you can get your editor to agree about file casing that would avoid the problem.
I'm working on a fix now, but as I said it will not arrive this month. I will ping here when there is something ready for testing.

If you can get your editor to agree about file casing that would avoid the problem.

How exactly can I achieve this in VSCode? I'm not really sure what kind of casing VSCode on Windows follows.

How exactly can I achieve this in VSCode? I'm not really sure what kind of casing VSCode on Windows follows.

Sorry, I'm not sure why VS Code is choosing a different spelling of this file.
The CL above (not yet submitted) fixes the file corruption, but there is more work yet as other features won't work in this file: we need to identify that this is the same file as returned to us from the go command.

Heya, it's been a while now - any new updates, @findleyr?

@CompeyDev sorry, missed your ping.
We have been busy with the v0.12.0 release, but this is one of the largest issues we hope to fix for v0.13.0, as we believe it is the largest outstanding gopls bug.

Alright, as for now I've switched my environment to Linux & everything seems to work as expected.
Thanks for the update!

I am facing the same issue right now... can i at least somehow restart/clear gopls completely so it stops doing it? it happened when i renamed User.go to user.go on windows... I guess it has User.go stored somewhere, so some sort of clearing would help, how do i do that?

@alesji are you experiencing corruption, or just a broken LSP server?
Your files should no longer be corrupted.


refactorDump groupid

Proposed changes
This is for debug.
When dump physical plan to treeString,  we print group ID of each node. it helps us to find the nodes in memo.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


07/16/2018 21:57 : Create Pull Request for branch master -> prTesting1_2018071621

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat:smart_scandir support ‘with’ operate

https://github.com/megvii-research/megfile/issues/181

Codecov Report
Patch coverage: 95.65% and project coverage change: -0.03 :warning:

Comparison is base (bd4e8e8) 100.00% compared to head (eadd180) 99.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #186      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%
===========================================
  Files           35       35
  Lines         4557     4571      +14
===========================================
+ Hits          4557     4570      +13
- Misses           0        1       +1

Impacted Files
Coverage Δ

megfile/interfaces.py
99.00% <88.88%> (-1.00%)
:arrow_down:

megfile/fs_path.py
100.00% <100.00%> (ø)

megfile/s3_path.py
100.00% <100.00%> (ø)

megfile/sftp_path.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

👍


code discussion

what does the parameters sublayer_first and sublayer_second mean in your code?

Please refer to my answer in this issue: #2


Concerns about SPAD dataset

Hi,
Thanks for sharing your great work. We notice that the size of the SPAD dataset mismatch the publicly available one (638, 464 vs 638, 492). Is there any pre-process operation implemented? Besides, we meet an issue when we train the released code on SPAD dataset, where the negative SSIM is dropped to 0 at step 97760, almost half of one epoch. We wonder about any solution to this problem.  For reference, we didn't change the parameter in train_derain.py, except --nepoch to 20.

Thanks for replying to my emails, and it is clear to me now.


HeroTabBarAnimation would cause crash if switch tabs quickly

Hi,
I added tab bar animation in Storyboard, and I found that if you quickly switch between tabs, especially switching to another tab before the animation finishes, there is possibility that the tabBarController would display nothing, or even the app would crash.
This can happen in the example that you provided. Here's a screenshot of the example that lost all content in tabBarController after some quick switches.

When causing crash, I found that the problem is due to the 338th line of Hero.swift, transitionContainer = context.containerView. I didn't have time to deeply look into the code so I cannot provide further help. Sorry about that.
Thanks for bringing out Hero. It's awesome.

I also have this problem @lkzhao

@xnth97 Hi, guy, I have spent a day fix this bug, see that.

I have an issue that is properly related to this, on the newest commit on master e84209f3538....
I have a modal view controller (vc) that is being dismissed to a vc inside a tab bar. In the vc's viewWillAppear method, I am setting the selectedIndex on the tab bar, to switch to another tab, and that causes the app to behave very weirdly and a restart is necessary.
I have solved it by temporary setting isHeroEnabled on the tab bar, before switching tab, and then enabling it after the switch is done

A great concept product but sadly with many bugs.


[bug] Fibaro Dimmer & HA autodiscovery?

Version
Build/Run method

[x] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: 2.0.6-dev
Openzwave Version: 1.6.962
Describe the bug
Autodiscovered HA light entity for a Fibaro Dimmer 2 device doesnt work in HA. While i can adjust brightness, i cannot switch the device on and off. The switch is stuck in off position regardless of light being on and off.
When im trying to manipulate the HA entity to switch the light on, i can see
Jan 01 17:38:05 zwave/Backyard/6/38/1/0/set 255
Jan 01 17:38:05 zwave/Backyard/6/38/1/0 99
Jan 01 17:38:05 zwave/Backyard/6/38/1/0 99

being posted to mqtt. But besides brightness, Fibaro Dimmer should also have on and off, as it does in HA zwave implementation.
I cannot see any on/off switch in web interface either, but i can switch off the light by submitting value "0" to "Instance 1: Level (6-38-1-0)".

If your device doens't have a switch valueID this is not possibile, however you could edit hass discovery payload to manually manage this, just remember to set max an min vaule to 100 and not 255. Here an example:
discovery_payload: {
      schema: 'template',
      brightness_template: '{{ (value_json.value ) | round(0) }}',
      state_template: '{{ "off" if value_json.value == 0 else "on" }}',
      command_on_template: '{{ ((brightness) if brightness is defined else 255 }}',
      command_off_template: '0'
    }

Thanks @robertsLando. How can i check if it doesnt have ValueID though? My Dimmers were always presenting on/off switches in HA/OZW1.4. Also the descriptions of config options in OZW1.6 xml file mention that the device should have on/off capability in addition to dimming.

@Dinth It should show up on the screenshot you posted under user section, If it doesn't it's not a problem related to z2m but someting on openzwave side :(

@robertsLando Thanks. Could you please say something more about editing discovery_payload? I couldnt find any documentation about that in HA wiki

@Dinth Here: https://www.home-assistant.io/docs/mqtt/discovery/
If you need help with sometinh specific post it here :)

Weirdly, while all my other nodes have "Home Assistant Devices" tab, the Dimmer 2 doesnt have it.

@Dinth It could mean that it hasn't found any associated device to create, try the manual way so:
https://selfhostedhome.com/migrating-to-zwave2mqtt-for-home-assistant/

Thanks @robertsLando, it is helpful.
Would it be possible to make Z2M discover if its dealing with Switch or Dimmer and act accordingly.
BTW. I have just found out that normal switches (just on/off states) are also advertised as dimmers to HA.

Hi @robertsLando
Ive just noticed that when i run light.turn_on or light_turn_off service in HA (which both work) or manually switch the light using a physical switch im getting the following error in HA:
2020-02-03 21:46:09 ERROR (MainThread) [homeassistant.util.logging] Exception in state_received when handling msg on 'zwave/Backyard/Light/38/1/0': '99'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/mqtt/light/schema_template.py", line 241, in state_received
    ].async_render_with_possible_json_value(msg.payload)
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 276, in async_render_with_possible_json_value
    return self._compiled.render(variables).strip()
  File "/usr/local/lib/python3.7/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.7/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "
TypeError: unsupported operand type(s) for /: 'str' and 'int'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/mqtt/light/schema_template.py", line 241, in state_received
    ].async_render_with_possible_json_value(msg.payload)
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 276, in async_render_with_possible_json_value
    return self._compiled.render(variables).strip()
  File "/usr/local/lib/python3.7/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.7/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "

@Dinth Please set the payload to JSON time value or Entire zwave object


virt-handler: fix a possible panic when handling UID

The getVMIFromCache may create a empty object to return, After that, it will entry if string(vmi.UID) == "" branch, the WatchdogFileGetUID will panic by precond.MustNotBeEmpty(vmi.GetObjectMeta().GetNamespace()). At this point vmiExists is false.
Signed-off-by: wanglei01<EMAIL_ADDRESS>kubernetes version v1.22.3

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

Looks good, but please add a unit test for this.

Thanks, @maiqueb.
Added, but the ut case is not necessarily correct, I will continue to modify it.

Looks good, but please add a unit test for this.

Thanks, @maiqueb. Added, but the ut case is not necessarily correct, I will continue to modify it.

Thank you! I may have jumped too soon at it then - if so, please ignore my comment.
Let me know once the test is good to be reviewed, so we can trigger CI on this.
Thanks for the contribution!

/test pull-kubevirt-unit-test

Sorry I have no time to deal with this, turn to Draft.


Enhancements

Q
A

Is bugfix?
❌

New feature?
✔/❌

Breaks BC?
✔/❌

Fixed issues
-

👍


Fixed a bug where "OutOfStockItemId" was equal to "InStockItemId"

This PR was for the last commit and it's been moved to #10 for a clean history.


nixos/opengl: enable S3TC by default

Motivation for this change
The patents expired in 2017:

https://www.phoronix.com/scan.php?page=news_item&px=S3TC-Patent-Expires-Next-Week

https://www.phoronix.com/scan.php?page=news_item&px=S3TC-For-Mesa-Finally

Resolves #82627.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM. Did similar research to file the linked bug. Wikipedia has more primary sources that confirm the patent expiration.

I'm actually curious whether libtxc_dxtn is still needed for anything these days. I can't figure out what or how it would get loaded by anything (it's not a build time dependency, so presumably there is some kind of plugin system that would load it?) and it doesn't seem like the package is carried by the likes of Debian and others anymore.
In any case, I'm in strong favor of removing the option and either 1. getting rid of libtxc_dxtn; 2. just using the s3tc version by default. The current option is technical debt that ~nobody will use and can easily be implemented with local overrides if people really strongly care.

More digging: it seems like the only reason for libtxc_dxtn being useful was some wine-staging patch that could use it sometimes, and that patch was also picked up by Lutris.
This matches the build-time dependencies in nixpkgs. There could be other run-time dependencies, but I would expect the runtime path thing was also for wine-staging. Looking at the wine-staging docs from 2017:

Since 1.7.37 it is not necessary anymore to have this library available at build time, if it is called either libtxc_dxtn.so or libtxc_dxtn_s2tc.so.0. If your distro uses a library with a different name, you still need it. This change was done to simplify building Wine Staging on distros where libtxc_dxtn is not available in the official repositories.

However, wine-staging stopped using libtxc_dxtn around 2018: https://github.com/wine-staging/wine-staging/pull/56
Gentoo went through the same deprecation process, though they had to keep the package for compatibility with old overlays: https://bugs.gentoo.org/654466
Let's just kill the package and all uses of it?

S3TC should now be built directly with mesa.  This old split is obsolete, I believe.
Maybe we do need to tweak our mesa derivation, though.  I don't even know off the top of my head how to test the support.

Release notes for 17.3.0 said:

libtxc_dxtn is now integrated into Mesa. GL_EXT_texture_compression_s3tc and GL_ANGLE_texture_compression_dxt are now always enabled on drivers that support them

I believe this NixOS option should be deprecated, and we could probably even remove expressions for the two libraries.  I don't feel strongly about backporting to 20.03.

Agreed re: killing the packages; closing this PR in favour of that (might not get around to submitting a new one soon, so anyone else can feel free to open a replacement too).

Just sent one FYI.


Update pickle_dataset.py

Fixes a typo.

Jenkins, test this please

Jenkins CI test (for commit 9877217ccba99b6d282d7fe01c4e79b242f5eee4, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 9877217ccba99b6d282d7fe01c4e79b242f5eee4, target branch master) failed with status FAILURE.

LGTM. Thanks!


JBPM-5424: Version selector does not work in the new form modeler.

Merge with: https://github.com/droolsjbpm/kie-wb-common/pull/646

@ederign can you take a look please?

jenkins retest this.


AMD: CommonJS and RequireJS support

I've added support for AMD (requirejs and commonjs). Could you merge it?

When 0.7.1 version is going to be released? I'd be awesome to have this AMD support :)


License

Just wondering what the license for this project would be or if you could add one? I'd like to fork this and make some additions/enhancements but don't want to run afoul of any issues with not giving proper credit or using the library according to the right licensing. Thanks.

@robweber I forgot to add the license to git before the last push. Thanks for checking, I added the MIT license in the project root directory.


Use better type for voting power in node.js

Description
The amount of voting power is typed as string in the Node.js bindings, we might want to change that to either number or bigint.
Motivation
Better UX.

Participation will most probably be its own package, won't do this in the SDK itself.


Update the application status view simply like below

These commit also change the check url's validate rule from "active_url" to "url".
Tips:
@REBELinBLUE  I use the sublime.phpfmt plugin to format the php code. You can try it.

👍


Quick Q: Does DenSPI depend on CoreNLP?

Its in the installer here
but its commented out in the Dockerfile.
I haven't seen any other reference to it.

Hi @waalge , the DrQA installation requires the CoreNLP installation. You might not need that if you don't want to use the CoreNLP tokenizer in DrQA.

Thanks for your reply,
Ok. Yeah, I understood that its interchangeable with spacy.
Although its not immediate whether this gives comparable results.


Add a "Select formatter" command

Ala Select linter, list the formatters we support and allow a user to select one that we then activate as appropriate. Provides an easy way for people to know what formatters we support and to get them on to their machine.

We may actually remove them eventually. VS engine provides formatting. May not be in the first release, but it does exist.

I don't think we should remove this at all. We need to keep supporting external tools for formatting. People have formatting rules in Python that use these existing tools.

Right, while we would provide formatting via the analysis engine out of the box we will continue to support third-party formatters for those people who have their internal style guides set up for those tools.

Related https://github.com/microsoft/vscode-python/issues/5121

Closing in favor of #5121


What's the role of Dapr in this project?

Can you clarify what features from Dapr are used?
I see Dapr dependencies are included in some projects in this repo, but then I see it included MassTransit as well

Dapr plans to work on infrastructure level for observability with OpenTelemetry... but right now, we haven't had implement it yet


Audit React components for updates

The React component library has fallen behind Twig in terms of updates, testing and correspondence to styles. We need to audit the components and make a list of the ones that need to be updated. This is a master issue that we'll use to track the work of updating the React lib.

The audit is complete and the work to be done is listed in #1274


Conditions on dataset (collection) level

In a project the different dataset types might need different follow-up questions. If I am correct the conditions are project wide, if this is the case are there any thoughts to apply them on collections or reasons against it? As I see the information to do so is in the database.

Hi @hgoerzig , this will be possible in the new version 1.6 which we will release soon ... There is a release candidate for testing available. Conditions will be checked using the answers for a particular dataset only.

Indeed this was introduced in RDMO 1.6.