Fuse some similar pointwise broadcast expressions

This PR uses @fused_direct to fuse some broadcast expressions

We're going to put this on hold until we fix https://github.com/CliMA/ClimaCore.jl/issues/1910.

Hm, not sure why this closed when I force-pushed.. I'll reopen a new one.


Help - erro on generate template

Hi, I'm trying to use cargo generate, but it throw this error:
cargo generate https://github.com/esp-rs/esp-template
error: Found argument 'https://github.com/esp-rs/esp-template' which wasn't expected, or isn't valid in this context

USAGE:
    cargo generate [FLAGS] [OPTIONS] --git <git>

For more information try --help

when I use  --git:
cargo generate --git=https://github.com/esp-rs/esp-template
 Project Name: test-esp8266
 Creating project called `test-esp8266`...
Error:  Git Error: failed to clone into: /home/samuel/Downloads/test-esp8266IXEFXF

Have I did something wrong ?
why there is no esp8266 template ?

Please make sure your version of cargo-generate is up to date, I'm running 0.16.0. Not sure why you're seeing this error, I just ran the same command and it worked fine:
jesse@mbp ~
λ cargo generate --vcs none https://github.com/esp-rs/esp-template
⚠   Favorite `https://github.com/esp-rs/esp-template` not found in config, using it as a git repository: https://github.com/esp-rs/esp-template
🤷   Project Name : foo
🔧   Destination: /Users/jesse/foo ...
🔧   Generating template ...
✔ 🤷   Configure project to use Dev Containers (VS Code, GitHub Codespaces and Gitpod)? · false
✔ 🤷   Which MCU to target? · esp32
[ 1/11]   Done: .cargo/config.toml
[ 2/11]   Done: .cargo
[ 3/11]   Done: .gitignore
[ 4/11]   Done: .vscode/settings.json
[ 5/11]   Done: .vscode
[ 6/11]   Done: Cargo.toml
[ 7/11]   Done: LICENSE-APACHE
[ 8/11]   Done: LICENSE-MIT
[ 9/11]   Done: rust-toolchain.toml
[10/11]   Done: src/main.rs
[11/11]   Done: src
🔧   Moving generated files into: `/Users/jesse/foo`...
✨   Done! New project created /Users/jesse/foo

We do not currently support the ESP8266 mostly just because it's not a part of the esp-hal mono-repository, and probably never will be. It does not share common peripheral hardware like the other ESP32* chips do. It should be possible to add an option for the ESP8266 which pulls in esp8266-hal, though.

You are right, I have used  an old version of cargo generate.
I have an esp8266 and I'm trying to use esp-rs, Do you know where can I get some tips or started point ?

Unfortunately esp8266-hal isn't really actively maintained anymore, but there are some basic examples there. There is no support for Wi-Fi but most of the other peripherals have some level of support. You won't be able to use esp-template but the required configuration files are all present in the repository, so you should be able to just copy them.

thank you  @jessebraham  👍🏽


Adding SIMD support for math calculations

Thanks for the wonderful project.
I was analysing the code out of curiosity and found that the underlying math does not use the advantages of SIMD and Vector co-processors in any hardware. I would like to know if there is any plans to add these supports. This would definitely make the library much faster. Though multi-threading and GPU support are in pipeline, SIMD will give upto 4x speed boost without much effort.
I would like to contribute to this if it is in scope of your project roadmap. Let me know your thoughts.

Forgot to mention, Eigen is a beautiful high-level C++ library of template headers for linear algebra, matrix and vector operations. If you are open to add such external libraries, we can evaluate a few.

Currently, I am trying to reduce cache misses and to improve algorithms. After this, the execution will be more compute bound and therefore SIMD will be the next step to improve the speed of the library.
Of course, if you want to take some time to try to use SIMD in the library, do not hesitate to test it on your side. I am really interested to see what could be the improvement.

For SIMD support, I would highly recommend just using the what the compiler already provides. gcc, clang and msvc should all have built-in support for using AMD64's SSE/AVX intrinsics and ARM's NEON/SVE intrinsics with a simple #include. Any other architecture that might have SIMD is too exotic to be worth the effort anyways.

I'd just like to chime in here and share my experience with SIMD.

SIMD will give upto 4x speed boost without much effort

If you're talking about SSE/NEON, it's significant effort. It's a huge pain adding compiler checks and handing the different ways compilers will support either instruction set. For example:
  /* Not all compilers will translate the + operator to _mm_add_ps */
  __m256 a = _mm_set_ps(1.0) + _mm_set_ps(2.0);

And if you're talking about trying to do something like this:
struct Vec3 final
{
  union {
    __m256 data;
    float x, y, z, unused;
  }
};

Don't, it doesn't work well for other instruction sets (AVX-2, AVX-512).
Fast-BVH used to do something like this, removing it actually improved the performance because it led to better compiler optimizations.

For SIMD support, I would highly recommend just using the what the compiler already provides. gcc, clang and msvc should all have built-in support for using AMD64's SSE/AVX intrinsics and ARM's NEON/SVE intrinsics with a simple #include. Any other architecture that might have SIMD is too exotic to be worth the effort anyways.

I agree that it's practical to rely on compiler optimizations. Choosing to include the headers and write your own SIMD code is not relying on the compiler though, it's doing the work yourself. Only including the header buys you nothing.
For any algorithm: If you've made all efforts to optimize the algorithmic logic and cache usage (based on data collected by a profiler), then try and write an optimized function to improve the performance using either a SIMD library or ISPC. I've used ISPC extensively and generates SIMD code far better than any C++ compiler, due to its explicitly parallel syntax.


cmd/go: list -compiled -find ignores cgo caching

What version of Go are you using (go version)?

$ go version
go version devel +90dca98d33 Thu Dec 20 22:11:45 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?
Think so.
What did you do?
time ~/go/bin/go list -e -json -compiled -x net >/dev/null
~/go/bin/go list -e -json -compiled -x net > /dev/null  0.14s user 0.07s system 216% cpu 0.094 total

time ~/go/bin/go list -e -json -compiled -find net >/dev/null
~/go/bin/go list -e -json -compiled -find net > /dev/null  0.45s user 0.27s system 106% cpu 0.674 total

What did you expect to see?
I expected -find to make it faster or at least not slower.
What did you see instead?
It made it slower, because it's rerunning cgo compilation with -find for some reason.

When "go list" is invoked with -find, it clears the list of imports for each package matched on the command line. This affects action IDs, since they incorporate dependencies' action IDs. Consequently, the build triggered by -compiled won't find sources cached by "go build".
I don't think there's any reason we shouldn't use sources produced by previous runs of "go list -find -compiled" though. cgo-generated sources are not affected by imported packages, as far as I know.


Feature/74 drop python 2

Coverage remained the same at 99.727% when pulling c1d53c4e536e2429a54e6e7ea463babe8a49c4a3 on feature/74_drop_python_2 into 56c74e9c0bdfbb80a16d0d2765ce49d5fc83e805 on develop.


Fixed shape computation in map

The shape computation in BoltArraySpark.map was not correct for maps over sets of axes that did not include zero. This issue has been fixed, and the map/reduce unit tests have been updated with ~4 additional tests each to cover these cases.

Looks great, merging it in


Melee gets no sensor info / no target lock penalties (but presumably shouldn't?)

Reported in a RT ticket - melee may not be interacting with attack penalties as expected. Research.

Do you mean the "no sensor" and "no vision" penalties are not being applied to the preview of a melee attack?
I haven't seen a "no target lock" penalty at all yet.


Default "More Field" to not show

@vincentdavis
we shouldn't have this issue. I think that is because they didn't clear cache.


Syntax Error on this line: new>>+= "\0" + c

Code being parsed:
    new = ""
    for c in orig:
        new += "\0" + c
    return new

--------------------------------------------------------------------------------
Syntax Error on this line:
        __new__>>+= "\0" + c
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/bin/transpile", line 1951, in <module>
    main()
  File "/usr/local/bin/transpile", line 1725, in main
    package = build(modules, base_path, datadirs=datadirs )
  File "/usr/local/bin/transpile", line 834, in build
    pyjs = python_to_pythonjs(script, go=True, module_path=module_path)
  File "<string>", line 5627, in python_to_pythonjs
  File "<string>", line 2364, in __init__
  File "<string>", line 1390, in transform_source
  File "<string>", line 1466, in parse_and_fix_code
  File "<unknown>", line 116
    __new__>>+= "\0" + c
              ^
SyntaxError: invalid syntax

(^ is under the =)

To be compatible with javascript and other backends, new is a reserved keyword in rusthon.  There should be a better error message, to let you know that it is reserved.


Question about the setting of voxel version

Thanks for your great work! However, the setting of the voxel version confused me.
https://github.com/Haiyang-W/DSVT/blob/a0ab685b573896fc4bc9a64b187bdc2b574c3741/tools/cfgs/dsvt_models/dsvt_3D_1f_onestage.yaml#L78
Each stage only has 1 block. Therefore, for each stage, it can only use non-shift or shift, not both. For example, in stage-0, the block only uses the window [12, 12,  32] with shift [0, 0, 0] X and Y set_voxel_inds. But in stage-1, the block only uses the window [24, 24  8] with shift [6, 6, 0] X and Y set_voxel_inds. Therefore, within each stage, is there no shift and hybrid setting to propagate the inter-window feature?

Yes, there is no shift and hybrid setting within one stage. However, shift window between stages can still provide global receptive field.

Thanks for your reply!


Config isn't parsed into the correct classes, just POJOs

I added a few assertions to the tests to illustrate this issue, see this branch:
https://github.com/NickBolles/ts-configurable
Could we use Reflection, or just recognize that the property isn't a POJO and instead of replacing it copy values to it? I'm wondering what the best route would be, but I can submit a PR once we decide.

@NickBolles Thank you for submitting the issue and suggestion this improvement to the ts-configurable library. I finally got around to implementing this, based on the tests you kindly provided in your pull request.
Commit implementing the suggestion: https://github.com/derbenoo/ts-configurable/commit/7c537c09d66614d1090c12522557cb135b7b273e
Tests merged and failing: https://circleci.com/gh/derbenoo/ts-configurable/149
Feature implemented and tests succeeding: https://circleci.com/gh/derbenoo/ts-configurable/150
:pray:

@derbenoo Awesome!! I actually updated my packages in my project and a test that I had, which was a workaround for this started failing. Then I came to find this! Thank you! now I can remove my workaround!

@derbenoo also, the code changes were way more concise than what I was going to try to do. Nice!


examples - todo - palette is ambiguous

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
I've clone the repository git clone https://github.com/iced-rs/iced.git and tried to run the todos examples with cargo run --package todos but I got the following error message: error[E0659]: `palette` is ambiguous.
What is the expected behavior?
Expectation here was to run the todos example without any errors (just like the tour example did)
Version
crates.io release
Operating System
Linux
Do you have any log output?
Compiling iced_wgpu v0.12.0 (/home/my-user/Projects/iced/wgpu)
   Compiling iced_style v0.12.0 (/home/my-user/Projects/iced/style)
   Compiling window_clipboard v0.3.0
   Compiling overload v0.1.1
   Compiling winit v0.28.6 (https://github.com/iced-rs/winit.git?rev=c52db2045d0a2f1b8d9923870de1d4ab1994146e#c52db204)
   Compiling rand_chacha v0.3.1
   Compiling tracing-log v0.2.0
   Compiling sharded-slab v0.1.7
error[E0659]: `palette` is ambiguous
 --> style/src/theme.rs:4:9
  |
4 | pub use palette::Palette;
  |         ^^^^^^^ ambiguous name
  |
  = note: ambiguous because of multiple potential import sources
  = note: `palette` could refer to a crate passed with `--extern`
  = help: use `::palette` to refer to this crate unambiguously
note: `palette` could also refer to the module defined here
 --> style/src/theme.rs:2:1
  |
2 | pub mod palette;
  | ^^^^^^^^^^^^^^^^
  = help: use `self::palette` to refer to this module unambiguously

   Compiling nu-ansi-term v0.46.0
   Compiling dirs-sys-next v0.1.2
For more information about this error, try `rustc --explain E0659`.
error: could not compile `iced_style` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Should this line https://github.com/iced-rs/iced/blob/master/style/src/theme.rs#L4 be converted to: pub use self::palette::Palette; ?

We only offert support the latest Rust stable toolchain! Try updating it with rustup update.


Fix typo in Excercise no.23,42.

I have edited the typo in exercise no 23 , 42
"Consider two random array A anb B, check if they are equal (★★☆)"
instead of and it was typed as anb
AND

Create a custom dtype that describes a color as four unisgned bytes (RGBA) (★☆☆)

unisgned --> unsigned

Thanks.


Support vector registers in FindAccessedAddrs

We only support 8 byte initial values, which are broadcast across the register. To avoid introducing unnecessary uarch dependencies, we find the largest vector register size used in the snippet, and only copy into that. Similarly, we detect whether the 16 extended registers introduced in AVX-512 are used, and only copy into them if so.
If no vector registers are used at all, we will skip over all instructions touching vector registers to avoid as much of the overhead as possible.

LGTM for the code and the tests.
It looks like the test runners do not support ZMM instructions. We should perhaps add a check that the ZMM registers are supported and bail out if they are not (not in this PR though).

LGTM for the code and the tests.
It looks like the test runners do not support ZMM instructions. We should perhaps add a check that the ZMM registers are supported and bail out if they are not (not in this PR though).

I've added this check since it was pretty simple to do and keeps the tests green. I just added a small subclass test fixture which checks cpuid and skips the test if the AVX512 extensions we need aren't available.


Translate cilium-etcd-service to cluster IP address without a DNS

Read per commit basis.

This change is

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Coverage decreased (-0.03%) to 42.951% when pulling 66137307fac3fcdb3b191c99a93309c0e8dfe417 on pr/add-ownd-dns into b428cf781a207a4d721f99d344146978fea04935 on master.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Depends on #7191

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-plase

please-me-please

test-me-please

test-me-please

test-me-please

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/10425
FQDN restart test - known issue, not related to this PR.

test-me-please

test-me-please

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/10525
FQDN restart test failed, which is a known issue unrelated to this PR.


Anonymous mode

Search this repo, it seems like this is an option, but how can it be enabled with the GUI?

https://github.com/picotorrent/picotorrent/issues/353

https://github.com/picotorrent/picotorrent/issues/79

https://github.com/picotorrent/picotorrent/pull/355

why not

Either no one has convinced me to do it, or no one has done it themselves
:)
You can still enable the anonymous mode from the config file, though, so
it’s not as if the option is unavailable.
On Wed, 20 Dec 2017 at 22:01, Steven Penny<EMAIL_ADDRESS>wrote:

why not
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/picotorrent/picotorrent/issues/513#issuecomment-353181382,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABbDcHjQo_Lje2OVRl9ROYTNo3MONtXMks5tCXW4gaJpZM4RE6aA
.

allow me to convince you - qBitTorrent has had GUI support for over 6 years
https://github.com/qbittorrent/qBittorrent/commit/59906152489c014846e54af95e96bed97f830d8f

I’m not really convinced. qBittorrent has a lot of great features that
we’re missing, but anonymous mode isn’t really one of them. It’s only
really beneficial when running I2P or SOCKS5, and as I said you can still
enable it.
It will for sure be added to the GUI sometime in the future, but not now
since I’m currently working on finishing a major refactor and all my time
and focus is spent working on that.
If it is urgent then I will happily accept a pull request for the feature :)
On Wed, 20 Dec 2017 at 22:41, Steven Penny<EMAIL_ADDRESS>wrote:

allow me to convince you - qBitTorrent has had GUI support for over 6 years
qbittorrent/qBittorrent@5990615
https://github.com/qbittorrent/qBittorrent/commit/59906152489c014846e54af95e96bed97f830d8f
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/picotorrent/picotorrent/issues/513#issuecomment-353190276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABbDcGJ7Zug_qkBcDqN-ynslQddV551fks5tCX76gaJpZM4RE6aA
.


Native Notebooks - Timer Issues

Steps to Reproduce:

Open notebook
Run some cells
Re-run cells
Watch timers

Issues:

Sometimes timer for multiple cells runs at the same time - I would expect the timer for one to start only after the previous has completed
After running cells once, the timer starts at random strange values. If I continued running the cells the timer for the second cell would start at 10 seconds or 80 seconds or 100 seconds etc - I would expect the timer to start from zero again each time

@claudiaregio this is an issue with the Jupyter extension.
Please could you close this & file it in the Jupyter extension repo.
Also the time is an estimation, not an accurate time (communication, translation of protocols/messages could be adding a few extra milliseconds).
if you want more accurate times we could use %%time magic & probably do that as a separate feature.

@claudiaregio this is an issue with the Jupyter extension.
Please could you close this & file it in the Jupyter extension repo.
Also the time is an estimation, not an accurate time (communication, translation of protocols/messages could be adding a few extra milliseconds).
if you want more accurate times we could use %%time magic & probably do that as a separate feature.


Add test cases for IDENTITY-6961 and IDENTITY-6958

IDENTITY-6961 : Check whether the correct status code is returned for invalid client request.
IDENTITY-6958 : Test whether the OAuth App / SP gets cleanedup during a request failure.

Please merge this after https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/718

Merged with https://github.com/wso2/product-is/pull/1464


InterfaceGraphics.pas(2962,67) Error: (3205) Illegal qualifier

Hi,
i am trying to build soldat according to your description.
fpc -l -B -MDelphi -Scgi -O1 -g -gl -l -vewnibq -vh- -dDEBUG -dDEVELOPMENT -Fi../3rdparty/Indy10/Lib/Core -Fi../shared -Fl./libs -Fu./libs -Fu../3rdparty/Pascal-SDL-2-Headers -Fu../3rdparty/Indy10/Lib/System -Fu../3rdparty/Indy10/Lib/Core -Fu../shared -Fu../shared/libs -Fu../shared/libs/GameNetworkingSockets -Fu../shared/libs/PhysFS -Fu../shared/libs/SteamWrapper -Fu../shared/mechanics -Fu../shared/network -Fu../server -Fu./libs/dglOpenGL -Fu./libs/stb -Fu./libs/FreeType -Fu./libs/openal -FE./build/ -o./build/soldat_x64 -k-rpath -k'\$ORIGIN/' -FU./build/linux -Tlinux -Px86_64 soldat.lpr
Compiling Debug Version
Free Pascal Compiler version 3.0.0 [2020/05/03] for x86_64
Copyright (c) 1993-2015 by Florian Klaempfl and others
(1002) Target OS: Linux for x86-64
(3104) Compiling soldat.lpr
(3104) Compiling Client.pas
(3104) Compiling GameStrings.pas
(3104) Compiling /home/user/build/soldat/shared/libs/PhysFS/PhysFS.pas
(3104) Compiling /home/user/build/soldat/shared/TraceLog.pas
(3104) Compiling Client.pas
(3104) Compiling GameStrings.pas
(3104) Compiling /home/user/build/soldat/shared/libs/PhysFS/PhysFS.pas
(3104) Compiling FileClient.pas
(3104) Compiling GameRendering.pas
(3104) Compiling Gfx.pas
(3104) Compiling /home/user/build/soldat/shared/Vector.pas
(3104) Compiling ./libs/dglOpenGL/dglOpenGL.pas
(3104) Compiling /home/user/build/soldat/3rdparty/Pascal-SDL-2-Headers/sdl2.pas
(3104) Compiling BinPack.pas
(3104) Compiling ./libs/stb/stb.pas
(3104) Compiling ./libs/FreeType/freetype.pas
(3104) Compiling Input.pas
(3104) Compiling /home/user/build/soldat/shared/Constants.pas
(3104) Compiling /home/user/build/soldat/shared/Weapons.pas
(3104) Compiling Client.pas
(3104) Compiling FileClient.pas
(3104) Compiling GameRendering.pas
(3104) Compiling Client.pas
(3104) Compiling FileClient.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Version.pas
(3104) Compiling /home/user/build/soldat/shared/Util.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Cvar.pas
(3104) Compiling /home/user/build/soldat/shared/Command.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Cvar.pas
(3104) Compiling Client.pas
(3104) Compiling ClientCommands.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Parts.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sprites.pas
(3104) Compiling /home/user/build/soldat/shared/Anims.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sprites.pas
(3104) Compiling /home/user/build/soldat/shared/MapFile.pas
(3104) Compiling /home/user/build/soldat/shared/Waypoints.pas
(3104) Compiling /home/user/build/soldat/shared/Calc.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sprites.pas
(3104) Compiling /home/user/build/soldat/shared/PolyMap.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sprites.pas
(3104) Compiling /home/user/build/soldat/shared/network/Net.pas
(3104) Compiling /home/user/build/soldat/shared/libs/GameNetworkingSockets/GameNetworkingSockets.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sprites.pas
(3104) Compiling Sound.pas
(3104) Compiling ./libs/openal/openal.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/LogFile.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/network/NetworkClientConnection.pas
(3104) Compiling /home/user/build/soldat/shared/libs/BitStream.pas
(3104) Compiling Client.pas
(3104) Compiling GameMenus.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Demo.pas
(3104) Compiling ClientGame.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Demo.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Console.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Game.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Sparks.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Game.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Bullets.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Things.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Game.pas
(3104) Compiling /home/user/build/soldat/shared/mechanics/Bullets.pas
(3104) Compiling /home/user/build/soldat/shared/network/NetworkClientBullet.pas
(3104) Compiling /home/user/build/soldat/shared/network/NetworkServerBullet.pas
(3104) Compiling Client.pas
(3104) Compiling /home/user/build/soldat/shared/Game.pas
(3104) Compiling Client.pas
(3104) Compiling ControlGame.pas
(3104) Compiling /home/user/build/soldat/shared/network/NetworkClientMessages.pas
(3104) Compiling /home/user/build/soldat/shared/network/NetworkUtils.pas
(3104) Compiling InterfaceGraphics.pas
(3104) Compiling MapGraphics.pas
/home/user/build/soldat/client/InterfaceGraphics.pas(132,20) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(132,38) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2955,53) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2956,95) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2957,83) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2958,73) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2958,143) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2959,71) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2959,140) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2960,80) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2961,78) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2961,132) Error: (3205) Illegal qualifier
/home/user/build/soldat/client/InterfaceGraphics.pas(2962,67) Error: (3205) Illegal qualifier
InterfaceGraphics.pas(3065) Fatal: (10026) There were 13 errors compiling module, stopping
Fatal: (1018) Compilation aborted
Error: /nix/store/hrn6dbmychiskxyjiwbfc66p8pngclb1-fpc-3.0.0/bin/ppcx64 returned an error exitcode
make: *** [Makefile:58: linux_x86_64] Error 1

I am using fcp 3.0.0:
$ fpc -v
Free Pascal Compiler version 3.0.0 [2020/05/03] for x86_64
Copyright (c) 1993-2015 by Florian Klaempfl and others
Fatal: No source file name in command line
Fatal: Compilation aborted

Thanks so much for making Soldat open source, i'd love to replay some parts of my youth!

I'm not 100% sure here what the issue is, I'll try compiling myself soon.
But from what I understood Soldat requires FPC version 3.0.4 and above.
Could you try getting it and coming back with results?

i tried with 3.0.4 and the build continues until some linker errors:
(9015) Linking ./build/soldat_x64
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: warning: ./build/link.res contains output sections; did you forget -T?
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lSDL2
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lphysfs
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lstb
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lfreetype
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lX11
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lGameNetworkingSockets
/nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/ld: cannot find -lopenal
/home/makefu/build/soldat/client/soldat.lpr(63,1) Error: (9013) Error while linking
/home/makefu/build/soldat/client/soldat.lpr(63,1) Fatal: (10026) There were 1 errors compiling module, stopping

it seems that there are some libraries required in the build process.

Okay i've made made it through all the linker problems and i am now at the following:
/nix/store/0x8pbk0578knfpxf9gbl0lhmpynh2947-binutils-2.31.1/bin/ld: warning: ./build/link.res contains output sections; did you forget -T?
/nix/store/0x8pbk0578knfpxf9gbl0lhmpynh2947-binutils-2.31.1/bin/ld: ./build/linux/Gfx.o: in function `CREATE':
/home/user/soldat/client//Gfx.pas:2329: undefined reference to `stbi_xload_mem'
/home/user/soldat/client/soldat.lpr(63,1) Error: (9013) Error while linking
/home/user/soldat/client/soldat.lpr(63,1) Fatal: (10026) There were 1 errors compiling module, stopping

i am using the stb library coming from https://github.com/nothings/stb with the makefile from the debian distribution. The source code of stb does not contain anything related to stbi_xload, only stbi_load any hints on how i can fix it?

Compile stb with Makefile located in client/libs/stb and put it in client/libs and build

Also make sure to not have the systems libstb installed or used by the linker.

i've made it through the whole thing, thanks for the help!


Simple form example causes TypeError: this.refs is undefined in 6.0.0-rc.3

I'm giving 6.0.0-rc.3 a try but I'm stuck with the simplest example. I've been following the new Getting Started guide.
I'm receiving the following error: TypeError: this.refs is undefined
Thrown here, in redux-form.js:
{
	key: 'valid',
	get: function get() {
		return this.refs.wrapped.getWrappedInstance().isValid();
	}
}

// TestForm.jsx
import React from "react";
import { Field, reduxForm } from "redux-form";

class TestForm extends React.Component {
    render() {
        const { handleSubmit } = this.props;

        return (
            <form onSubmit={handleSubmit}>

                    First Name
                    <Field name="firstName" component="input" type="text"/>

                    Last Name
                    <Field name="lastName" component="input" type="text"/>

                    Email
                    <Field name="email" component="input" type="email"/>

                <button type="submit">Submit</button>
            </form>
        );
    }
}

TestForm = reduxForm({
  form: 'contact'
})(TestForm);

export default TestForm;

// TestPage.jsx
import React from "react";
import PageContent from "components/PageContent";
import IBox from "components/IBox";
import TestForm from "./TestForm";

export default class FindOrders extends React.Component {
    showResults(values) {
        console.log(values);
    }

    render() {
        return <PageContent header="Ordre Oversigt">
            <IBox>
                <TestForm/>
            </IBox>
        </PageContent>
    }
}

I'm not sure if this is the cause, but I noticed you're defining the name TestForm twice in the same scope. Depending on the way you're compiling the Javascript, your browser might be choosing the first or second definition of TestForm. To prevent any possible name clash, I would replace this:
TestForm = reduxForm({
  form: 'contact'
})(TestForm);

export default TestForm;

... with this:
export default reduxForm({
  form: 'contact'
})(TestForm);

TestForm = reduxForm({
form: 'contact'
})(TestForm);
export default TestForm;

The Simple example Erik provides does the same.

That's true. The cause is probably something else. I've never seen the error you're encountering, sorry.

All right. I'll continue debugging to see if there's something conflicting with redux-form.

So, I've found the issue. It's when the webpack loader react-hot is enabled for jsx files. If I remove this, redux-form is working as expected.
Anyone using the react-hot loader with redux-form 6?

FWIW, I'm using webpack-hot-middleware (based on https://github.com/davezuko/react-redux-starter-kit) instead of react-hot-loader. I've seen one nasty compilation error (it broke a let variable with a different value per branch), but other than that, it has been working for the last few months.

The same issue here. react-hot loader causing the issue also confirmed.

It sounds like this is caused by react-hot-loader and is not a problem with this library. I'd recommend submitting an issue over there.

Just for those who are interested, upgrading react-hot-loader to 3.0.0-beta.2 fixed the issue for me. Although it brought another react-router related issue when using async routes in the project, I did find a way to overcome that issue after some searching.


Add VM listing and information endpoints

This PR adds the following new endpoints and their documentation:

/v/vm/ - POST: Get information about a virtual machine
/v/vm/list - POST: List all virtual machines for a group

Good to merge and is used by the web interface in the coming commits.

@zimsneexh Regarding the list endpoints, I do think the same. You could open an issue for discussion


feat: Add StandardScaler transformer

Closes #[142].
Summary of Changes

Co-authored-by: sibre28<EMAIL_ADDRESS>

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
3
1
0
0.66s

❌ PYTHON
mypy
3

1
1.56s

✅ PYTHON
ruff
3
1
0
0.02s

✅ REPOSITORY
git_diff
yes

no
0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

@zzril 2a670cb69ab520e7f08ba1772d3302f6545299dd fixed the mypy error for whatever reason.

@zzril 2a670cb fixed the mypy error. It seems that mypy cannot handle something in tests/helpers/_resources.py. Because the file is no longer changee now, it is also no longer linted, so the error went away.

I think the issue was that the entry of the new helper method in tests/helpers/__init.py__ was missing.

:tada: This PR is included in version 0.14.0 :tada:
The release is available on:

v0.14.0
GitHub release

Your semantic-release bot :package::rocket:


[Removal]: Wobbly Wool Newt part 2 (previous #337)

Hotspot Name
Wobbly Wool Newt
Hotspot b58 Address
11Yx9JyaimtjHNsAXuaSyriBFR6erpcsWR2NkSVU3ygqt3vs8q4
Discord Handle
ArgelTa1#3410
Hotspot Manufacturer
RAK
Removal Reason
The hotspot is regular, added to the denylist, removed and now added again.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Dear Helium support team,
This is my 2nd request regarding this hotspot. Please see link to the 1st request:
https://github.com/helium/denylist/issues/337
I don't know the reason for blocking it again, but my hotspot is regular, real location, one antenna, etc.
I kindly ask you to remove me from the denylist and not added it again.
I am available for any questions.
Best Regards,
A

We do not have sufficient evidence to remove these hotspots from the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

Hello Abhay,
This is a real hotspot, what info do you need?

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

Hello Abhay,
I see that you have uploaded a new denylist, but my hotspot is still on it.
Please take care of that.

Hello @abhay
Please let me know what evidence you need to remove the hotspot from the denylist.
I am an active member of the community and I use only the allowed practices.
Please respond.


Bedrust unable to get credentials from an external process natively from the SDK

Hello,
First of all Kudos to you on bringing this to life ! it really is a great asset to bring more GenAI stuff closer to the dev as part of next gen dev experiences !
While trying to play around with Bedrust, I was unable to get it to work when my environment sources credentials with an external process as per https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sourcing-external.html
Bedrust error message states that the credentials provider was not enabled as you can see in the attached screenshot:

Here's an example content of ~/.aws/config:
[profile developer]
credential_process = /opt/bin/awscreds-custom --username helen

Thanks a lot !
Bests and keep it up

@schniber - I believe this issue is now fixed. Please do try :)

Hey @darko-mesaros !
Good job looks like all is good now ! Keep it up mate !


Same values for follower list and reward table

Set values that match the values in "Followers reward" table into the "Coveted Creator" section of list
Description

Fixes

Thanks again - we'll most likely be adjusting this soon again and I don't think the values need to match exactly. Maybe you can alter a screenshot that says "LBC values may not match, see table for actual reward amount". Can we show you some appreciation?

Thanks for appreciation offer, but I have gotten much more than my content deserves(some gameplay videos to test lbry) from the view rewards, so that's enough appreciation :D
Should I close this pull request then, I don't really know how git works.

You can just edit the existing file and let me know.

Closing for now, you can submit a new PR :)


fix(provision): load Nucleus recipe from build file to component store and config store

Issue #, if available:
Description of changes:
Problems:

GIVEN nucleus and CLI provisioned on the device, WHEN use CLI to create local deployment to change Nucleus config while device is offline, THEN deployment fails because Nucleus recipe is missing in component store

If Nucleus recipe does exist and references an artifact, deployment still fails because artifact is also missing

GIVEN nucleus provisioned on the device, WHEN create a first deployment (local or cloud) to change any Nucleus config, THEN deployment succeeds but Nucleus always restarts, because Nucleus bootstrap lifecycle step is not initialized and any changes in bootstrap step leads to the restart workflow.

The solution to both problems is to properly initialize Nucleus service config and component store during the initial provision.

Initialize JVM options from current setting
Copy Nucleus recipe from {release_zip_unpack_dir}/conf/recipe.yaml to local component store

Copy unpacked artifacts to local component store (as it's referenced in lifecyle.bootstrap in the recipe)

Load dependencies and lifecycle definitions from the recipe to config store

Why is this change necessary:
To enable Nucleus deployments when device is offline.
To prevent unnecessary restarts in Nucleus config deployments.
How was this change tested:
End-to-end scenarios:

GIVEN nucleus and CLI provisioned on the device, WHEN device goes offline, AND use CLI to create a deployment to change Nucleus config logging.level=DEBUG, THEN deployment succeeds (and Nucleus doesn't restart)
GIVEN nucleus and CLI provisioned on the device, WHEN device goes offline, AND use CLI to create a deployment to change Nucleus config jvmOptions=-Xmx64m, THEN Nucleus restarts and deployment succeeds
GIVEN nucleus v2.0.0 and CLI provisioned on the device, WHEN create a cloud deployment of nucleus v2.0.1, THEN Nucleus restarts into the new version and deployment succeeds. WHEN device goes offline, AND use CLI to create a deployment of Nucleus v2.0.0, THEN Nucleus restarts into the old version (using the local recipe) and deployment succeeds

Any additional information or context required to review the change:
When device is online, deployments will always download latest recipe from Cloud and overwrite the local copy (if the content doesn't match).
In this PR, the changes focus on common scenarios of local deployments when offline. As a result, the local recipe and artifacts don't have to be exact matches as in Cloud component service.

Local recipe doesn't have artifacts section
Unpacked artifacts are copied to component store instead of the original artifact zip file

Checklist:

[ ] Updated the README if applicable
[x] Updated or added new unit tests
[ ] Updated or added new integration tests
[x] Updated or added new end-to-end tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looking good. Maybe test with BootstrapManager#isBootstrapRequired to make sure it won't have unexpected restart.

Did you account for cases where there is some existing configuration for the nucleus already in the config such as when the customer has manually created the config.yaml file for manual provisioning?

Yes. The main logic is still in deviceConfiguration.initializeNucleusFromRecipe. I've updated it so that all the setup steps should always be reached.


Upgrade core-js version

Got this warning,

warning evergreen-ui > glamor > fbjs ><EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

Although it's through fbjs, maybe upgrading the glamor version will fix it.

Duplicates #1146, #1304.
We ultimately need to move off of glamor.


using hidden_field

How do I provide for the adapter sufficiently?
module Views
  #
  # the date component is a wrapper for the date_field form input field
  #
  class Components::Form::HiddenField < Phlex::HTML
    include Phlex::Rails::Helpers::HiddenField

    def initialize( form: nil, field: nil, value: nil )
      @form = form
      @field = field
      @value = value
    end

    def template()
      @form.hidden_field( @field, value: @value)
    end
  end
end

renders:
<input autocomplete="off" type="hidden" name="account_id[{:value=>3}]" id="account_id_{:value=>3}">

whereas I'd like it to render:
<input value="3" autocomplete="off" type="hidden" name="asset[account_id]" id="asset_account_id">

(wrapping the form (in this case asset) nicely around the field attribute - as Rails does out-of-the-box so to speak)

I've solved this issue - not how I'd like it to work but ...
module Views
  #
  # the date component is a wrapper for the date_field form input field
  #
  class Components::Form::HiddenField < Phlex::HTML
    include Phlex::Rails::Helpers::HiddenField

    def initialize( resource: nil, field: nil, value: nil )
      @resource = resource.class.to_s.underscore
      @field = field
      @value = value
    end

    def template()
      hidden_field( @resource, @field, value: @value)
    end
  end
end

I don't get to enjoy the form_builder niceties but see the rendering I like
<input value="3" autocomplete="off" type="hidden" name="event[account_id]" id="event_account_id">

The HiddenField adapter corresponds to this view helper https://api.rubyonrails.org/classes/ActionView/Helpers/FormTagHelper.html#method-i-hidden_field_tag
You should never need to use that adapter directly.
The FormWith adapter yields an adapted Rails FormBuilder that corresponds to this https://api.rubyonrails.org/classes/ActionView/Helpers/FormBuilder.html
That means you can call methods on the yielded form builder like this
class Foo < Phlex::HTML
  include Phlex::Rails::Hepers::FormWith

  def template
    form_with(model: Post.new) do |f|
      f.hidden_field :bar
    end
  end
end

This is the equivalent of this in ERB and produces the same output.
<%= form_with(model: Post.new) do |f| %>
  <%= f.hidden_field :bar %>
<% end %>


rc.conf: default to unicode console

it's the high year of 2023, after all.
closes #607

perhaps it should be changed elsewhere instead of here, given that before it was just a commented-default

the default is "no" by virtue of being empty, and the various init scripts treating "" as "no".  changing this config is the least disruptive for people upgrading.  we can prob give it a year/few releases before commenting it out and changing the init scripts to default the value to "yes" manually.

that makes sense. thanks for elaborating vapier :)

The convention should be to comment out the default in rc.conf and uncomment it only when it is being changed.

as a generalism, that is absolutely true, but i as i mentioned above, i think changing defaults requires a bit more consideration.  an /etc config change, e.g. in Gentoo, encourages/forces people to review & accept the new default.  after we go through that transition period, we can rewrite the code internally to consider unset $unicode to be yes by default, and update the config file to be commented out again (with it being documented as yes).

@vapier  In gentoo, we already use sed to force the unicode default to be yes, so we deviate downstream from what the OpenRC releases have as default (see the last openrc release ebuild). If we make the internal default yes, we are just moving Gentoo's default upstream.
People will see the changes in /etc/rc.conf via etc-update, so if they want to turn off unicode they can.

i haven't looked at the ebuild to see if it needs changing. this isn't about Gentoo defaults though, this is simply doing the right thing out of the box: Unicode/UTF8 enabled should be the default, and anyone wanting to live in a 7bit/non-UTF8 world has to change their config.
if you think simply changing the commented out default is sufficient notification (and something in the release notes), I'm fine rolling that now.

i'm also fine with this being reverted in itself and being replaced by your preference for the same changes. how it's done doesn't matter to me :)

In gentoo, we already use sed to force the unicode default to be yes,

if you had done it here ages ago instead, everyone could've had those benefits, and i wouldn't have been confused for a really long time why my console was broken by default until i figured out what part of the stack even controlled this :p
of course, no real harm done. thanks for the hard work :)


✨ Add n_observations to tiledbsoma artifacts

Fixes https://github.com/laminlabs/lamindb/issues/1919

Could we also populate the accessor for these artifacts so it's not "unknown" here?

Yep

How should i call it? tiledbsoma?

We currently have "AnnData", "DataFrame", "MuData", so maybe "TileDB-SOMA"?

Yes, makes sense, added like this.

Ha, you did the same already! :D


Docs on cloud.google.com are out of date

After 2.0 shipped, we didn't update the reference docs on cloud.google.com:
https://cloud.google.com/nodejs/docs/reference/storage/1.7.x/

@crwilcox just checking in - did this happen?

@JustinBeckwith the docs rollout happened yesterday. I haven't closed this yet as

there are outstanding updates for a few libraries.
A report came in via Slack that some content isn't included in the latest generation of 2.0.x docs for storage.

https://cloud.google.com/nodejs/docs/reference/storage/2.0.x/File and other storage docs are now up to date.


UX: think again on what time related information user will need? Calendar is not relevant?

Not applicable in react native version anymore


Turn off Java8 doclint, see http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

Turn off Java8 doclint, see http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

@fernandezpablo85 Please check this again, I've added conditional profile based on http://stackoverflow.com/a/22296107/122441

is it actual? ScribeJava is jdk8-compilable at the moment.
I'll close for now. In case it's actual, rebase on the master pls and reopen (make new PR)


No App file created

I'd expect this to spin up an entire project, including an app file. The app file is isn't created with generation, so you can't run a project right away, as you can with rails.

I am not sure what you mean, there is a generator and it bootstraps a project for you. What are you missing?


Dimension of evaluation

Is the evaluation done on the complete image size or is the evaluation done on the downsized image ?
For example, if an image is of size (320,240) and the feature map size leading to the softmax is (160,120) or (40,30), is the evaluation done on (320,240) or on the (40,30) vs gt_resized(40,30) ?

the evaluation is done on the original size - (320, 240) in your example.
On 13 June 2018 at 01:07, sm176357<EMAIL_ADDRESS>wrote:

Is the evaluation done on the complete image size or is the evaluation
done on the downsized image ?
For example, if an image is of size (320,240) and the feature map size
leading to the softmax is (160,120) or (40,30), is the evaluation done on
(320,240) or on the (40,30) vs gt_resized(40,30) ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DrSleep/tensorflow-deeplab-resnet/issues/185, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHemmJFtrZomczdVy5ebXF3ovHu12vhGks5t7-AegaJpZM4UkrRf
.

Thanks for the clarification.


iterable__user_unsubscriptions - bad updated_date

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
Note on iterable dbt package.
iterable__user_unsubscriptions:
updated_at Timestamp of when the user unsubscribed from the channel or message type
The above definition for that column is wrong in that table - it seems that the update_at - is the last date of any unsubscription - not the actual date of the unsubscription. So if I unsubsubcribed from X 2 years ago - and the I unsubscribe from Y yesterday. All those rows will be updated to the yesterday date. Its also mixing subscriptions to lists vs. channels/messagetypes when it comes to dates. Makes this table difficult to work with.
https://fivetran.github.io/dbt_iterable/#!/model/model.iterable.iterable__user_unsubscriptions
Relevant error log or model output
Note on iterable dbt package.

iterable__user_unsubscriptions:

updated_at Timestamp of when the user unsubscribed from the channel or message type

The above definition for that column is wrong in that table - it seems that the update_at - is the last date of any unsubscription - not the actual date of the unsubscription. So if I unsubsubcribed from X 2 years ago - and the I unsubscribe from Y yesterday. All those rows will be updated to the yesterday date. Its also mixing subscriptions to lists vs. channels/messagetypes when it comes to dates. Makes this table difficult to work with.

https://fivetran.github.io/dbt_iterable/#!/model/model.iterable.iterable__user_unsubscriptions

Expected behavior
The updated_date should be the date of the actual unsubscription date
dbt Project configurations
Default package
Package versions

package: fivetran/iterable
version: 0.10.0

What database are you using dbt with?
bigquery
dbt Version
Most recent
Additional Context
I love these iterable packages - keep them coming :)
These queries are difficult to write so these come in handy. I'd love to see this table fixed tho - this one is quite important to us:)
Are you willing to open a PR to help address this issue?

[ ] Yes.
[X] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

Hi @rick1290 thank you for opening this issue. We will review this in the next day or so and let you know if we have any questions.

Thanks! @fivetran-catfritz Will stay posted :)

Hi @rick1290 I am reviewing this and have a couple questions. Could you confirm if you have the source table USER_UNSUBSCRIBED_CHANNEL with the column _fivetran_id? There was a schema change on August 10, 2023, so it would be helpful to know if you're on the old schema or the new schema.
Also I see that you are on v0.10.0 of the package. I don't think upgrading to the current version v0.11.0 will necessarily solve this particular issue, but I'm also wondering if you have tried it out/had issues with it?

@fivetran-catfritz I'm on the old schema
Agreed - don't think upgrading as well will help. I've been upgrading over time and havn't seen any changes. I can try when I get some time next week.

Hi there @rick1290 -- this latest_batch_index window function is likely the culprit, as it will return the latest unsubscribed timestamp for each user across all channels/message types, and we use it to filter out records here.
I believe adding channel_id or message_type_id to the partition clause of the window functions would resolve the issue, mostly. This would then return the latest unsubscription timestamp per user per channel/message type. I am wondering if it makes sense to return the latest timestamp (in case a user has unsubscribed, re-subscribed, and unsubscribed again from the same channel) or instead return the first unsubscription timestamp?
As for your later point

Its also mixing subscriptions to lists vs. channels/messagetypes when it comes to dates. Makes this table difficult to work with

Would you mind clarifying a bit here?

@fivetran-jamie Great!
latest unsubscription timestamp per user per channel/message type
The above is the logic we want for this.
In regards to clarifying - we just want to make sure that the timestamps are for channel/message types - and not when a user drops from a list.
Really glad you are working on a fix for this!

Gotcha cool! Would you be willing to test out a working branch when we have a fix drafted?

Yep :)

@fivetran-jamie Any update or progress on this issue :)
Thanks1

Hi @rick1290 ! I've currently taken on the work on this bug from @fivetran-jamie  and am hoping to have a fix ready by the end of this sprint.
I've deployed the proposed changes in the dbt_iterable_source package that should bring in the latest unsubscription behavior for an email based on channel_id and message_type_id, and should bring in the latest unsubscribes on both the message_type and channel level.
You can test the changes before we go ahead and deploy them alive. Would you be able to update the packages.yml file in your dbt_iterable package to:
packages:
  - git: https://github.com/fivetran/dbt_iterable_source.git
    revision: bugfix/catch-all-recent-unsubscribes
    warn-unpinned: false

Then run your package and see if everything looks as proposed? This will provide the final level of validation needed for us to merge this into a new release!
Thanks for your patience.

Hi @rick1290 ! This new version of dbt_iterable_source is now live in our latest v0.8.1 release with the changes that should bring in all the latest unsubscribes in the iterable__user_unsubscriptions model. You can run dbt deps to pick up the latest version of the package.
Let us know if you experience any issues here!

@fivetran-avinash Thanks! Do I need to run a full refresh or anything?

@fivetran-avinash
I get the following errors when I run a ful-refresh. Mind you - our data is from 2021 - so we are on legacy schema. Have the new updates been tested on the original schema? I read the breaking changes - but not sure it should be causing errors.
Thanks!!
02:45:43    Database Error in model int_iterable__latest_user (models/intermediate/int_iterable__latest_user.sql)
  Unrecognized name: unique_user_key at [13:38]
  compiled Code at target/run/iterable/models/intermediate/int_iterable__latest_user.sql
02:45:43
02:45:43
02:45:43    Database Error in model int_iterable__list_user_history (models/intermediate/int_iterable__list_user_history.sql)
  Unrecognized name: unique_user_key at [23:47]
  compiled Code at target/run/iterable/models/intermediate/int_iterable__list_user_history.sql
02:45:43
02:45:43
02:45:43    Runtime Error in model iterable__user_unsubscriptions (models/iterable__user_unsubscriptions.sql)
  404 Not found: Table tsn-marketing-operations:dbt_models_stg_iterable.stg_iterable__user_unsubscribed_channel was not found in location US; reason: notFound, message: Not found: Table tsn-marketing-operations:dbt_models_stg_iterable.stg_iterable__user_unsubscribed_channel was not found in location US

Just reverted back to v10 and its working. Would love to see how I can get v11 working with these awesome new changes :)

Morning @fivetran-avinash Please see the below:
15:52:29 Running with dbt=1.6.14
15:52:30 Installing fivetran/iterable
15:52:31 Installed from version 0.11.0
15:52:31 Up to date!

Hey @rick1290, @fivetran-avinash is OOO for the rest of the week, so I'll jump in to help for the time being.
It looks like the only contents we see there are for the fivetran/iterable dbt package, but not the fivetran/iterable_source package (where Avinash's changes were made). 🤔
Would you be able to share the contents of your packages.yml?

@fivetran-joemarkiewicz See below. I believe the fivetran iterable source is automatically included in the iterable package.
Let me know if you need anything else! :)
`
Name your project! Project names should contain only lowercase characters
and underscores. A good package name should reflect your organization's
name or the intended use of these models
name: 'x'
version: '1.0.0'
config-version: 2
This setting configures which "profile" dbt uses for this project.
profile: 'default'
These configurations specify where dbt should look for different types of files.
The source-paths config, for example, states that models in this project can be
found in the "models/" directory. You probably won't need to change these!
model-paths: ["models"]
analysis-paths: ["analysis"]
test-paths: ["tests"]
seed-paths: ["seeds"]
macro-paths: ["macros"]
snapshot-paths: ["snapshots"]
target-path: "target"  # directory which will store compiled SQL files
clean-targets:         # directories to be removed by dbt clean
- "target"
- "dbt_packages"
tests:
+severity: warn  # all tests
Configuring models
Full documentation: https://docs.getdbt.com/docs/configuring-models
In this example config, we tell dbt to build all models in the example/ directory
as tables. These settings can be overridden in the individual model files
using the {{ config(...) }} macro.
models:
shift_analytics_project:
# Applies to all files under models/example/
materialized: table
staging:
materialized: view
pinterest:
enabled: false
pinterest_source:
enabled: false
# disable both linkedin ads models if not using linkedin ads
linkedin:
enabled: false
linkedin_source:
enabled: false
# disable both twitter ads models if not using twitter ads
twitter_ads:
enabled: false
twitter_ads_source:
enabled: false
# disable both snapchat ads models if not using snapchat ads
snapchat_ads:
enabled: false
snapchat_ads_source:
enabled: false
# disable both instagram business models if not using instagram business
instagram_business:
enabled: false
instagram_business_source:
enabled: false
# disable both twitter organic models if not using twitter organic
twitter_organic:
enabled: false
twitter_organic_source:
enabled: false
# disable both tiktok ads models if not using tiktok ads
tiktok_ads:
enabled: false
tiktok_ads_source:
enabled: false
google_ads:
+schema: google_ads
google_ads_source:
+schema: google_ads_source
facebook_ads:
+schema: facebook_ads
facebook_ads_source:
+schema: facebook_ads_source
facebook_ads_creative_history:
+schema: facebook_ads
microsoft_ads:
+schema: microsoft_ads
microsoft_ads_source:
+schema: microsoft_ads_source
ad_reporting:
+schema: ad_reporting
vars:
facebook_ads_schema: fb_ads
google_ads_schema: google_ads_new_api
microsoft_ads_schema: bingads
ad_reporting__pinterest_ads_enabled: False
ad_reporting__amazon_ads_enabled: False
ad_reporting__linkedin_ads_enabled: False
ad_reporting__twitter_ads_enabled: False
ad_reporting__snapchat_ads_enabled: False
ad_reporting__tiktok_ads_enabled: False
social_media_rollup__twitter_enabled: False
social_media_rollup__linkedin_enabled: False
ad_reporting__apple_search_ads_enabled: False
ad_reporting__reddit_ads_enabled: False
amplitude_schema: amplitude_new
amplitude__date_range_start: '2020-01-01' # your start date here
amplitude__date_range_end: '2023-12-31' # your end date here
event_properties_to_pivot: ['pns','pagePath', 'title','url', 'nid','utmSource', 'attribution_id','email', 'position', 'rating','comment', 'status', 'orderid']
user_properties_to_pivot: ['utm_source','utm_medium', 'utm_campaign', 'utm_content', 'isPractitioner', 'learningPreference', 'goals']
id-columns: ('anonymous_id', 'user_id', 'email', 'context_traits_email', 'amplitude_id')`

Hey @rick1290 it looks like you shared the contents of the dbt_project.yml. Would you be able to share the packages.yml contents? Additionally, do you by chance have a package-lock.yml in your project? You are correct that the source package should be installed automatically, but it doesn't seem to be the case as we don't see the source installation in your above response.

@fivetran-joemarkiewicz Oops.
`packages:

package: fivetran/iterable
version: 0.11.0

package: fivetran/ad_reporting
version: [">=1.6.0", "<1.7.0"] # we recommend using ranges to capture non-breaking changes automatically

package: fivetran/social_media_reporting
version: 0.2.0

package: fivetran/youtube_analytics
version: 0.3.0

package: narratorai/activity_schema
version: 0.1.0

package: dbt-labs/audit_helper
version: 0.9.0

package: mjirv/dbt_product_analytics
version: [">=0.1.0"]

package: fivetran/amplitude
version: [">=0.4.0", "<0.5.0"] # we recommend using ranges to capture non-breaking changes automatically`

@fivetran-joemarkiewicz No lock.yml in the project
Any other ideas?

Thanks @rick1290, and just to confirm you do not see fivetran/iterable_source anywhere in your dbt deps log?
 It doesn't seem like the upstream changes were captured in the run where you see the error. I can mainly see this due to the error message that stg_iterable__user_unsubscribed_channel does not exist. This is a renamed model from the v0.8.0 dbt_iterable_source release. On a full refresh (while also running the upstream models) this error shouldn't occur.
One last attempt here would be to try the following steps:

run dbt clean
run dbt deps (confirm iterable_source v0.8.1 is installed)
run dbt run -s +iterable --full-refresh

Ideally after these steps you should see success. Let me know if this works!

@fivetran-avinash @fivetran-joemarkiewicz
The above worked - thanks!
That said - take a look at the following screenshot. I'm still seeing the same original bug on the new tables. The updated_at date is being attached to ALL channels and messages. The updated_at date should be the date the user unsubscribed from the channel or message_type. Should be a unique date_time for each channel if they were unsubscribed individually.

Below is an example of a user actually 'subscribing' to the channel/type and non unsubscribing on 5-10-24 but the channel is included in the unsubscribe table along with the date subscribed.

I'm wondering if we need another column in here - that is boolean - that lets us know if they are current unsubscribed from the message_type_name? Any other ideas?

An example of a user who unsubscribed 2-27-24 then resubscribed on 4-10-24. The 6-05-24 was attached to no subscription action.
I'm thinking subscribe may be getting mixed in here somehow - and something else I can't figure out for the 6-05 date stamp.

Hi @rick1290 , I'm wondering if your run is still utilizing the old version of the iterable_source package. If this data you provided is all reflective of one user, the new partitions should be creating unique indices based off of the email/channel_id and email/message_type_id mode  and taking those unique updated_at times.
Are you able to view the compiled code on the new tables? It should be in your target/compiled folder. Can you check and see if the new compiled code for stg_iterable__user_unsub_message_type and stg_iterable__user_unsubscribed_channel matches the new partition logic on the v0.8.1 version?

Below is an example of a user actually 'subscribing' to the channel/type and not unsubscribing on 5-10-24 but the channel is included in the unsubscribe table along with the date subscribed.

I'm wondering if we need another column in here - that is boolean - that lets us know if they are current unsubscribed from the message_type_name? Any other ideas?

Interesting findings @rick1290 ! These last two messages feels like a separate issue though--why is any subscription data appearing in the unsubscribe table? That feels like a connector issue. This is worth  filing a support ticket with our Fivetran team) to see why subscription data is appearing at all.

@fivetran-avinash

Hi @rick1290 , I'm wondering if your run is still utilizing the old version of the iterable_source package. If this data you provided is all reflective of one user, the new partitions should be creating unique indices based off of the email/channel_id and email/message_type_id mode and taking those unique updated_at times.
Are you able to view the compiled code on the new tables? It should be in your target/compiled folder. Can you check and see if the new compiled code for stg_iterable__user_unsub_message_type and stg_iterable__user_unsubscribed_channel matches the new partition logic on the v0.8.1 version?

It matches - confirmed.

Below is an example of a user actually 'subscribing' to the channel/type and not unsubscribing on 5-10-24 but the channel is included in the unsubscribe table along with the date subscribed.

I'm wondering if we need another column in here - that is boolean - that lets us know if they are current unsubscribed from the message_type_name? Any other ideas?

Interesting findings @rick1290 ! These last two messages feels like a separate issue though--why is any subscription data appearing in the unsubscribe tables? That feels like a connector issue. This is worth  filing a support ticket with our Fivetran team to see why subscription data is appearing at all.

I don't believe this is a sync issue as I initially filed a ticket which led me to filing the issue here as I believe this is tied to the underlying data models being run in this package. When I look at custom events in the iterable_event table - all those unsubscribe and subscribe events are correct. For some reason though - the subscribe event date/time is being added to the updated_at field.
Happy to hop on a quick call to discuss this more :) I'm going to be thrilled once this use-case can be solved by the package.

I'm now spot checking the user_unsubscribed_channel_history table... could be a sync issue....
These dates don't make any sense :( :(

I was thinking maybe the new connector could solve this - but i'm not seeing any date stamps on the unsubscribe tables. Filed a ticket in the meantime - thanks for the help on this!

Hi @rick1290, thanks for the thorough investigation! I believe this is still a Fivetran connector issue. The updated_at value is not properly processing the unsubscribe time events in the way we would expect. That is not something our data models can control for, as we expect the updated_at value to be consistent for the time of an unsubscribe event.
So to summarize,

The iterable event table is properly bringing in subscribe and unsubscribe events at the time they occur.
However, the iterable user_unsubscribed_message_type_history and user_unsubscribed_channel_history tables are not getting the proper times from the updated_at value.

Some examples of incorrect updated_at behavior in these tables in the examples you've shown above:

Subscribe events showing up in the unsubscribe tables
The same updated_at value for an email regardless of channel or message type (Maybe it's taking the most recent event? unsure of the behavior)
Users who unsubscribe, resubscribe, but the unsubscribe times do not capture the unsubscribe, only the resubscribe.

I'm seeing you created an additional ticket. I would relay all this information in the last few comments you provided in this thread to Fivetran support, particularly the screenshots regarding the edge cases you see. That way they can investigate what's happening in each case thoroughly. Hopefully, it's a bug, and this can be resolved internally.
If the behavior of the connector has changed for the updated_at values in these history models, then we can schedule a call, reopen this ticket, and take next steps.
Let me know if this all makes sense!

I see - thanks everything.. .very much appreciated!!!

@fivetran-avinash
Still not progress with support on this request unfortunately.
I thought I'd note one thing. I think it would be quite awesome if we can take event_name = 'emailUnSubscribe' and use that event to build an unsubscribe table and then compares it to the user table. Somehow I think this is the only way to get accurate unsubscribe data as the current methods are not accurate.

Hi @rick1290 , good investigation on your side! It'd be interesting to see if we could incorporate this idea to create a more sustainable event model.
Would you be able to share your data of how using the event_name= emailUnSubscribe would be able to fill the same role for rebuilding the  iterable__user_unsubscriptions model for your purpose, particularly with the additional grains on channel and message type? Also, is the proper timestamp coming through in all cases in your data?
(You can do it in the support ticket too if it's PII, but just let me know here so I can take a look!)

@fivetran-avinash Yep - this would be awesome to see.
event_name= emailUnSubscribe and emailSubscribe match our data perfectly - so it makes sense to use.
Essentially, you'd use the iterable__event table - to get emailUnSubscribe and emailSubscribe data/events.
UNEST channel_id's and message_types in additional_properties ---> which would create a new row for each email, id + unsubscribe event.
Write a rule to check if emailUnSubscribe date > emailSubscribe date for each email, id combo. This will provide accurate data on IF the user is current unsubscribed or subscribes to a channel or message type.
You can then join this back on the channel group - and find out if they are unsubscribed channel wide.
Happy to do a workshop and discuss with you more. I've gone down a rabbit hole on this and build something for this today --- pretty raw tho - but it works.

@fivetran-avinash Were you able to see the query that was created by the support team in my ticket? If you have time - would love to get your thoughts and see how it can be reflected in the dbt package to make things accurate.
The query they provides works - but i'm still not sure its the best approach - but want to see what you think. Thanks!!


Memory embeddings example does not work with multiple facts related to one subject

Describe the bug
When adding additional facts around a subject (for example, what I do for work), the result will randomly pick a fact and use it as the response, instead of stating all the relevant facts.
To Reproduce
Steps to reproduce the behavior:

Follow the example in 06-memory-and-embeddings.ipynb
Replace the facts with:

await kernel.Memory.SaveInformationAsync(MemoryCollectionName, id: "info1", text: "My name is Andrea");
await kernel.Memory.SaveInformationAsync(MemoryCollectionName, id: "info2", text: "I currently work as a tourist operator");
await kernel.Memory.SaveInformationAsync(MemoryCollectionName, id: "info3", text: "I also currently work as a bus driver");
await kernel.Memory.SaveInformationAsync(MemoryCollectionName, id: "info4", text: "I sometimes work as a teacher");

Just ask the question: "what do I do for work?",
4. The question returns "I sometimes work as a teacher".
Expected behavior
A full listing of what I do for work.
Desktop (please complete the following information):

OS: Windows
IDE: Visual Studio 2022
NuGet Package Version: 0.13.277.1-preview

Additional context
The issue extends towards other facts, and was found when trying to develop a chat bot that answers questions about gene-disease associations. When "taught" 1:M associations, I continually get just one of the answers as a result, which is incomplete.

I think you'll need to return say the top 3 vector results and send that to GPT for a completion to compile the results.  I wouldn't say it doesn't "work", its just a proof of concept highlighting potential

Here's what I tried following your suggestion:

what are all the things I do for work?
I sometimes work as a teacher
what are the 3 things I do for work
I sometimes work as a teacher

The example above is highlighting the most basic form of vector search and is only returning back a single result.  For me, it helped conceptualize how vector search works in memory.  It's definitely not intending to be robust and representative of more advanced use cases.
Just below that one though, it goes a step further, and I think this is where you find the solution to the question you were describing.  It set a limit to return the top 5 nearest matches.  If there is more than one vector that has subject matter around your question, there's a good chance it will return in those 5 results.  I would send those top vectors as context over to GPT with the questions as completions and then GPT is capable of providing the reasoning and inference to understand.  I have strong confidence you'd get the answer you're expecting this way.

Hi @cchighman. Thank you for the very detailed response. The concern I have is that I'm trying to feed a very large amount of information into the knowledgebase - in this specific case, associations of Gene-Disease. There are > 20,000 of those associations, and I'd like to be able to ask simple questions like: "How many diseases are associated with X", or "Which genes share an association with disease Y". Therefore, loading them all into context wouldn't work.

Late to respond here, so perhaps you've already solved?
With a large 1-many set, could you use the model to first work out the name of the gene or disease in the statement?
That would at least give a good starting point for your next step.
Prompt could look something like:
Based on the following input

{{$input}}

Return JSON in the following format:
 {"type":"disease|gene", "name":"name of the disease or gene", "confidence":value between 0 and 1 based on how confident you are with the response}

Closing for now as I believe the original issue has been resolved, feel free to reopen if needed


Add missing function declarations

Added missing function declarations:

inet_ntoa_r
inet_ntop
inet_pton
VPADGetTPCalibratedPointEx

Looks good to me. Did you reverse-engineer this? It's good info.
The inclusion of doxygen makes me happy~

@QuarkTheAwesome, I was previously using dynamic_libs and those functions were part of it. Those function were already in nsysnet.def and vpad.def in wut. So only the declarations were missing. I am currently using inet_ntop and VPADGetTPCalibratedPointEx with a newly ported project to wut.
The doxygen comments are mostly the ones from VPADGetTPCalibratedPoint, so it's basically a copy paste 😞

Yeah, the defs are autogenerated to have every function in them. Anyway, all good, and thanks!


Removing prop mutation in v-model usage

Summary
Mutating props has never been a good idea but we've tolerated it due to architectural choices that were made. The vue3 compiler will now complain about this so we're taking steps to stop doing it here.
We will likely want to make another change once vue3 is made to switch back to using v-model but that will take significantly more changes and can't be done in a crosscutting way like this.
Technical notes summary

Areas or cases that should be tested
All components that have been touched here.
Areas which could experience regressions
All components that have been touched here.
Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

The vue3 compiler will now complain about this so we're taking steps to stop doing it here.

Just for posterity - we are still mutating the value prop via set() and assignment in most of these components, but the Vue3 compiler will mostly complain about v-model=value usage, which is the problem being addressed by this PR.


istio: Add source labels to analysis matching rules

This PR adds the sourceLabels filed to the Canary CRD. This allows running an A/B test using source labels matches when a service is attached to the Istio mesh gateway.
Example:
kind: Canary
metadata:
  name: backend
spec:
  provider: istio
  service:
    port: 9898
    gateways:
      - mesh
  analysis:
    interval: 15s
    threshold: 10
    iterations: 10
    match:
    - sourceLabels:
        app: frontend

Fix: #580
For testing update the CRD with kubectl apply -f https://raw.githubusercontent.com/weaveworks/flagger/istio-source-labels/artifacts/flagger/crd.yaml before using sourceLabels.

Codecov Report

Merging #594 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   55.00%   55.00%
=======================================
  Files          62       62
  Lines        5303     5303
=======================================
  Hits         2917     2917
  Misses       1959     1959
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a3b9d...4f299e5. Read the comment docs.


release: 0.16.6

Bugfix / soundness release for the 0.16 series. As well as the capsule fixes I cherry-picked the panic-payload soundness.
I will put out 0.17.0 just following this (separate PR incoming). I plan to do both on Tuesday evening.

Release is live!


Add ExportTxtSkipUnlicensed option to Export-NAVContainerObjects

Can you add the option ExportTxtSkipUnlicensed to the Export-NAVContainerObjects?
That helps in the scenario where you have 3rd party objects in the database but miss the permissions to export them to text.

Is added in <IP_ADDRESS>


⚠ Bofrost.at has degraded performance

In 24aee9d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1177 ms

Resolved: Bofrost.at performance has improved in b1fd70a.


Capital letter PostgreSQL column names make Scalar Functions test fail

I did not test if it's a general issue or related to the scalar functions test. But it looked like it's something general.

The problem seems to be connected to the scalar functions.
PosgreSQL table  withColumn numBer
SELECT "NUMBER" from test: works
SELECT ABS("NUMBER") from test: broken

The query also fails if not all columns are selected.
e.g: table with column numBer and other.
Select "NUMBER" from test

This behavior is intended: https://github.com/exasol/postgresql-virtual-schema/blob/main/doc/dialects/postgresql.md#postgres-identifiers. Use PRESERVE_ORIGINAL_CASE instead.


[Bug]: Changing the Default Git Branch is not supported in RBAC

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Changing the Default Git Branch doesn't track the newly added pages in the roles tab

Steps To Reproduce

Connect a app to git
Login as admin
Got o admin setting page
Create a custom role
Assign it to user 2
now login as user 2
Create a branch 1 from master
Now make branch 1 as default branch from git
Now add a new page 1 in Branch 1
Go to roles tab refresh the page
The newly added page is not tracked

Public Sample App
No response
Issue video log
No response
Version
release

Is there any update on this issue?


remove settability from Unique.id's interface + small refactor

Summary

remove settability from Unique.id's interface
Switch GuildChannel.shard_id from a try except to a trait bound instance check

Checklist

[x] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

Related issues

LGTM
Why did you mark it as breaking? I cant seem to find any breaking part of it

LGTM
Why did you mark it as breaking? I cant seem to find any breaking part of it

In practice it's probably not really breaking but it's removing something from an abstract interface so I marked it as breaking


Replace option

An option to replace instead of adding a fallback would be great

https://github.com/maximkoretskiy/postcss-initial/pull/10


[DYOD] Support window function queries

Since the preliminary changes for our project are not merged into the Hyrise main branch yet, we set up two branches in this repo that yield a reasonable diff for reviewing.
We would recommend starting a review with the header files and then to go top-down, that is, start at WindowFunctionEvaluator::_on_execute and stepping into the used functions from there. The implementation of SegmentTree is independent from the rest of the code, so should be okay to review in parallel. Similarly, the construction of the operator (lqp translation) is also rather boilerplate, so you can do it at any time.

Now that upstream has merged the preliminary PR, we can PR against them :)


What happens and what should happen when combining two shapes with different values for the same key?

Example:
type A = Shape<X, { name: Auto; }>;
type B = Shape<X, { name: Alias<X, 'surname', Auto>; }>;
type X = A & B;

Shapes and aliases are not a thing anymore.


Long press broken for TouchableNativeFeedback

🐛 Bug Report

After upgrading from React Native 0.58.6 to 0.59.1, any <TouchableNativeFeedback /> with onLongPress is no longer working i.e. the handler is never fired.
To Reproduce

Use TouchableNativeFeedback with onLongPress in a React Native 0.59.1 app.
Expected Behavior

Long pressing the TouchableNativeFeedback triggers the onLongPress handler
Code Example

https://github.com/mjmasn/rn59_tnf_longpress
Environment

info
  React Native Environment Info:
    System:
      OS: Linux 4.15 Ubuntu 16.04.6 LTS (Xenial Xerus)
      CPU: (8) x64 Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
      Memory: 856.03 MB / 15.54 GB
      Shell: 4.3.48 - /bin/bash
    Binaries:
      Node: 8.11.3 - ~/.nvm/versions/node/v8.11.3/bin/node
      Yarn: 1.15.2 - /usr/bin/yarn
      npm: 5.6.0 - ~/.nvm/versions/node/v8.11.3/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      Android SDK:
        API Levels: 16, 19, 22, 23, 26, 27, 28
        Build Tools: 23.0.1, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.3, 28.0.2, 28.0.3
        System Images: android-16 | Google APIs Intel x86 Atom, android-17 | Google APIs Intel x86 Atom, android-18 | Google APIs Intel x86 Atom, android-19 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64
    IDEs:
      Android Studio: 3.1 AI-173.4907809
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.1 => 0.59.1
    npmGlobalPackages:
      create-react-native-app: 2.0.2
      react-native-cli: 2.0.1
      react-native-create-library: 3.1.2
      react-native-git-upgrade: 0.2.7

Hey @mjmasn thanks for filing, I looked into this and the long press appears to be working in your repo:

If you can clarify how to repro I'm happy to look again and re-open 👌

@rickhanlonii hmm, it's broken on a variety of real devices in our office. Could be a specific Android version maybe? I haven't tried any emulators yet but will do so this afternoon. The issue does appear to be intermittent, sometimes after a few attempts it does trigger the onLongPress handler but it's probably 1 in 10 attempts or fewer.
I'm running Android 9 on a Samsung Galaxy S9+

Ok cool, lmk if you can find a simulator to repro in 👍

Working on emulators:
Nexus_5X_API_25
Nexus_6P_API_26
Pixel_C_API_27
Pixel_2_XL_API_28
Working on real devices:
LGE Nexus 5 running Android 6.0.1 (API 23)
Huawei P8 lite 2017 running Android 7.0 (API 24)
LGE Nexus 5X running Android 8.1.0 (API 27)
Broken on real devices:
Samsung Galaxy A5 (2016) running Android 7.0 (API 24)
Samsung Galaxy S9+ running Android 9 (API 28)
Possibly a Samsung theme here but I don't have any other devices to hand. Would be helpful if other Samsung users could chime in...

Hey @mjmasn, thanks for more testing!
Re-opening so we can test on those devices and figure out what's happening

Thanks @rickhanlonii :+1:
One final piece of information: the issue is also affecting <TouchableHighlight /> in the same way.
<TouchableOpacity /> and <TouchableWithoutFeedback /> are not affected.

@rickhanlonii hmm actually it looks like your commit here might have triggered this: https://github.com/facebook/react-native/commit/3bef4bddbfbdaaa7f431bbada5d72c26e01a45d6#diff-580446e098bcae0cd35585b8cf689f2aL501
Apparently that line was not just a perf optimisation :upside_down_face:

also affecting TouchableHighlight on iOS

Yeah I'm having this issue on both iOS and android with TouchableHighlight.
React native 0.59.0
iOS 12.2, iPhone X
android 8.0.0, Samsung Galaxy S8

i have this problem in TouchableHighlight as mentioned above @rickhanlonii , its a big mistake that i upgrade my project and see this ridiculous bug

I'm having this issue too on iOS and Android!
iOS 12.1.4, iPhone X and Android 9.0, Pixel 3

RN 0.59.2 ,This bug still exists

@rickhanlonii hmm actually it looks like your commit here might have triggered this: 3bef4bd#diff-580446e098bcae0cd35585b8cf689f2aL501
Apparently that line was not just a perf optimisation 🙃

FYI. Just forked a private repo to revert this commit. It is confirmed that commit causes the issue.

was able to reproduces it on OnePlus 5t.

@rickhanlonii is a fix for this set for an upcoming release?

This is fixed by https://github.com/facebook/react-native/pull/24238

Fixed #24268

Same here, OnePlus 6. #24238 solved the issue for me as well.

Fixed by https://github.com/facebook/react-native/commit/59e50237bff9521d2b78d7576abf4e23d844ac1b

Is the fix released? Is there we can use this fix?

yes this is fixed<EMAIL_ADDRESS>

Just upgraded to 0.59.4, I'm still not getting the trigger for Pixel 2 on Android 9

Confirmed broken on 0.59.10 on a Pixel 3 XL using TouchableOpacity

Wanted to update, the issue on 0.59.10 only seemed to happen when remote-debugging was turned on, onPress would trigger onLongPress instead
However, after upgrading to RN 0.60.0, onLongPress on touchableOpacity is not working at all when using remote debugger.

@danielidt this particular bug was fixed and the issue has been closed for a while. It sounds like you're experiencing a different problem so I'd recommend opening a new issue in this repo. I doubt you'll get any replies on this one.

I wanted to report to whoever is seeing this on Android 10, I tried on Nokia 6.1 with react-native: 0.59.1 the onLongPress was triggering right away (even with a delay) -- but that was the case only when remote-debugging as @danielidt mentioned above.
Turning off the remote debugging worked fine without having to update the react-native packager. I left it at 0.59.1, and all works as expected.


Access data from Event Bus in visitModal

Is there any way to access data emitted from the child modal in the parent when using visitModal?

You can pass data to the emit method, and also data from the component itself:
<script setup>
const number = ref(123);
</script>

<template>
    <Modal #default="{ emit }">
        <button type="button" @click="emit('button-clicked', { foo: number })">
            Click me!
        </button>
    </Modal>
</template>

I understand emitting data from the modal itself. But how about listening for the omitted event in the parent component when using visitModal? eg when using ModalLink component, I can listen for the emitted event like this:
<script setup>
function handleClickedEvent(payload){
    // do something with the emitted payload
}
</script>

<template>
      <ModalLink @button-clicked="handleClickedEvent' href='/user/1/edit'">
        Edit page
      </ModalLink>
</template>

But what if I am not using ModalLink and instead doing a manual visit using visitModal like this:
<script setup>
import { visitModal } from '@inertiaui/modal-vue'

function visitModalPage(){
    visitModal(route('users.edit', 1), {
        config: {
            slideover: true,
        },
        onClose: () => console.log('Modal closed'),
        onAfterLeave: () => console.log('Modal removed from DOM'),
    })
}
</script>

<template>
    <button @click="visitModalPage">Manually visit page</button>
</template>

In this case, how do I react to an event emitted from the modal?

Ah, I understand! I'll check it out and get back to you.

Added in v0.7.0: https://inertiaui.com/inertia-modal/docs/event-bus
visitModal('/users/create', {
    listeners: {
        increaseBy(amount) {
            console.log(`Increase by ${amount}`);
        }
    }
})


can it be used with arduino ide ?? having a lot of trouble compling and flashing using rtos ?? and can it be used on esp8266-01??

This guy was workign on an Arduino library https://github.com/An00bIS47/Homekit not sure how far he has progressed.
Follow the step by step provided and let us know which part you are getting stuck at

ok sir, the problem im facing is that the build version is different and cant use the basic examples of homekit whereas rtos examples are working for me. how do i compile the homekit code with new rtos version as this doesnt have rtos/bin folder so cant complie the code and flash

evertime i "make" i het some errors or the other really confused now but really want to use standalone homekit switch

@surya31 well, there are no fortune tellers here, so if you do not give us details we won't be able to help.
I personally run on macOS and to workaround problem with toolchain not liking case insensitive file system I have all toolchain packaged into Docker containers. Here is my configuration:

a docker image with esp-sdk
a docker image with esp-open-rtos (based on esp-sdk image)
esp-open-rtos repository
esp-homekit-demo repository
then I just run build inside docker image (see commands example in Gist)

https://gist.github.com/maximkulkin/bca710444cbbc01a1845687a266f45a4

I just checked with latest esp-open-rtos version and it compiles without problems.


devbox ~/.ssh is read-only

So things like adding known_hosts doesn't work.
Maybe let the user specify their own config https://stackoverflow.com/a/10765980/5518313

Not a blocker for me for the moment but a nice to have

Could be a symlink to ~/jupyter/.ssh.

The setup uses that directory for sshd, which is probably wrong. That should be ~/.devbox_sshd or something and mounted read-only. The other directory could be a link to ~/jupyter/.ssh

vm_devbox


Gallery: opening and closing "About Flutter" misses lots of frames

Open Gallery, open the drawer, then tap "About Flutter Gallery". Notice how the display of the box and the darkening of the background are not smooth. Then, close the box. Also seemingly missing frames.
Tested on a Nexus 5.

The performance overlay shows results after opening and closing the About Flutter Gallery a few times.

Closing as not reproducible. If you disagree, please file an issue at https://github.com/flutter/gallery.


⚠ Bofrost.at has degraded performance

In b204be7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1920 ms

Resolved: Bofrost.at performance has improved in bcfbbc7.


Create LiTransaction for governance

Description:

Required to display governance txs on the Transaction Page

[x] TmUI Components
[ ] Integrate to voyager wallet

@jbibla any idea of the colors we should use for each of the gov txs ?

Do we 100% need this prelaunch?

imo it's required. It shouldn't take too much time

re: colors - as long as they are the same for all governance txs we'll be fine!

Blocked because waiting for new release of tendermint/ui to be published.

published 0.3.1