Server API endpoint not called if the URL is missing "randomfilename.png"

I can confirm that sd_setImage does not hit the server if the url is missing some string that ends with imageformat extension, for example .png, .jpg
Initially the URL was something like /path/to/image/{id}, the id was enough to find and return image. In that case, the library would not hit the server.
However , after modifying the route to accept a fake filename at the end it started working
/path/to/image/{id}?name=image.jpg

By default, SDWebImage's HTTP request, will use a NSURLSessionDataTask to download anything from the URL. It supports any HTTP URL like https://foo/bar/1, if the HTTP response is correct and return a valid HTTP content-type. (HTTP response which does not contains Content-Length is adoptable, but this will disable the progressive download feature, so it's better to provide this header in HTTP response)
I think, you should better try to use a HTTP debugger tool, like Charles to identify the real HTTP requset & response. And if you can provide a more detailed information, like using SDWebImage version, iOS firmware version, demo, is better for us to idenfity and provide the suggestion.

you can close this issue if you like, just wanted to help if someone else is facing a similar problem
I used postman to initially get image using the URL "/path/to/image/{id}", it returns the image as expected.The http response and content-type were correct. however the same did not work with SDWebImage
After appending a filename and modifying the route , it worked on SDWebImage.
I am using the latest version of SDWebImage, IOS 11.3
This is great library, thanks for your continuous effort improving it.

@rushilMethsof Feel free to reopen, we all can help you, would you please give a url of image that can reproduce? a little demo would be the best.

Thanks you guys for following up on this, indeed I would like to see a url that reproduces this issue, since it is something we should fix (if reproducible).

@rushilMethsof I have re-added the issue template info (which is very important) to the issue description. Please fill in the info there.

because of the nature of the project, I will not be able to post the actual URL here.
I may have to create a dummy local server and allow access to it from my home laptop.
that might take some time

Then what can we do next? @rushilMethsof can you debug and see what is happening? If the request goes through? If we get a response?

Closing due to lack of response. @rushilMethsof feel free to reopen if you are willing to help us reproduce and fix the issue.


Please remove references to BFKit-Swift

I don't care that you have copy the first part of your README from the one of BFKit-Swift, but please, remove the alt tag of your image that references to BFKit-Swift ahah
It's in the first line of your README

BFKit-Swift is very nice, Please don't mind my mistake, I have removed, thx

Don't worry :+1:


Can't create VM from SharedImage in another subscription

Hello.
I tried the steps written in this article and I got an error “New-AzVm : The image subscription doesn't match the current subscription.”
I also found this comment https://github.com/Azure/azure-powershell/issues/8670#issuecomment-494637394 and tried to run code specified there. It successfully creates the VM.
Please update the article.
The following code works fine.
$imageId = "/subscriptions/<subscr1>/resourceGroups/images-rg/providers/Microsoft.Compute/galleries/<gallery>/images/dev2016/versions/2019061711.51.38";
$rgname = "dev-rg-uw2-t";

# Common
$loc = "West US 2";
New-AzResourceGroup -Name $rgname -Location $loc -Force;

# Create a VM first
$vmsize = 'Standard_D2_v2';
$vmname = 'vm' + $rgname;
$p = New-AzVMConfig -VMName $vmname -VMSize $vmsize;

# NRP
$subnet = New-AzVirtualNetworkSubnetConfig -Name ('subnet' + $rgname) -AddressPrefix "<IP_ADDRESS>/24";
$vnet = New-AzVirtualNetwork -Force -Name ('vnet' + $rgname) -ResourceGroupName $rgname -Location $loc -AddressPrefix "<IP_ADDRESS>/16" -Subnet $subnet;
$vnet = Get-AzVirtualNetwork -Name ('vnet' + $rgname) -ResourceGroupName $rgname;
$subnetId = $vnet.Subnets[0].Id;
$pubip = New-AzPublicIpAddress -Force -Name ('pubip' + $rgname) -ResourceGroupName $rgname -Location $loc -AllocationMethod Dynamic -DomainNameLabel ('pubip' + $rgname);
$pubip = Get-AzPublicIpAddress -Name ('pubip' + $rgname) -ResourceGroupName $rgname;
$nic = New-AzNetworkInterface -Force -Name ('nic' + $rgname) -ResourceGroupName $rgname -Location $loc -SubnetId $subnetId -PublicIpAddressId $pubip.Id;
$nic = Get-AzNetworkInterface -Name ('nic' + $rgname) -ResourceGroupName $rgname;
$nicId = $nic.Id;
$p = Add-AzVMNetworkInterface -VM $p -Id $nicId -Primary;

# OS & Image
$user = "Foo12";
$password = "pwd";
$securePassword = ConvertTo-SecureString $password -AsPlainText -Force;
$cred = New-Object System.Management.Automation.PSCredential ($user, $securePassword);
$computerName = 'test';
$p = Set-AzVMOperatingSystem -VM $p -Windows -ComputerName $computerName -Credential $cred;

$p = Set-AzVMSourceImage -VM $p -Id $imageId;

# Virtual Machine
New-AzVM -ResourceGroupName $rgname -Location $loc -VM $p;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4c09d03-24b1-f376-34fd-cbfd8d29d3d7
Version Independent ID: 763073bf-734e-e079-2d4c-97c097eb7c88
Content: Share gallery images across tenants in Azure
Content Source: articles/virtual-machines/windows/share-images-across-tenants.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! We are currently investigating and will update you shortly.

@cynthn if I remember correctly, there is a known issue with this? Can you confirm?

@ivasilyev-servicetitan-com and @MicahMcKittrick-MSFT Yep, that is an issue with the simplified parameter set. It looks like the updates for this file got lost when I did the rest of the updates to change the VM creation to the version using a vmconfig file. I'll get this doc updated and double-check that nothing else went missing in the meantime :)
Thanks for catching that!!!
I'm going to leave this issue open until the doc gets updated (hopefully later today or early tomorrow).


[feat req] process crds before any helm installs

This is more of a feature request than an issue. I have been using a separate crds directory to make sure the crds exist, in a fresh cluster, prior reconciling helmrelease files. This can get very cumbersome, having to create kustomizations & git repositories resources for crd manifests in addition to the helmreleases, etc etc. The best example for this is the prometheus-operator CR's. If servicemonitors and alert rules are defined in helmrelease values, they won't reconcile unless kube-prometheus-stack crd's get installed first. What would be a cleaner approach is having flux install all crd's first, if defined in the helmrelease like below, before doing any helm installs.
current approach
cluster/crds
├── external-dns
│   ├── crds.yaml
│   └── kustomization.yaml
├── kube-prometheus-stack
│   ├── crds.yaml
│   └── kustomization.yaml
└── kustomization.yaml

helm-release.yaml
  install:
    crds: CreateReplace
  upgrade:
    crds: CreateReplace

The Flux approach uses a Kustomization to install a HelmRelease, and those are two separate transactions in terms of server side apply. Since Flux added support for server side apply, Kustomize controller itself no longer has the problem of not being able to apply CRDs and CRs of those definitions at the same time due to validation issues. As you are experiencing the same issue in a different way, this is slim consolation and I'm sorry for the poor experience you're having!
Since Flux v0.18, the Kustomize controller is smart enough to apply CRDs using server-side, keeping the apply operation open, then using server-side to apply the instances of CRs, in the proper order so that validation succeeds where it might have failed like as in this case.
Kustomize controller however is not smart enough (nor is there a simple design or change which I can imagine that does not radically alter the way Flux works) to install a Kustomization, then wait for HelmRelease to become ready, and apply Custom Resources finally after that. Well, maybe there could be such an optional behavior added without compromising too much, speculating, but I think the complexity that it adds is not worth the benefit of being able to manage CRDs from within Helm.
I understand you're requesting a particular feature and you may be aware of workarounds already, but as an issue report it should be in scope to reply with workarounds... feature requests should properly go in flux2/discussions and are not issue reports. That does not preclude the possibility this might also be a valid issue report worthy of keeping open as an issue.

Here's my cleanest workaround / alternative configuration approach suggested example based on cert-manager: https://github.com/kingdonb/bootstrap-repo/blob/staging/apps/cert-manager/kustomization.yaml
Prom-operator doesn't publish the CRD as a separate release artifact so it's not so easy.
(Come to think of it, this strategy that I'm using to grab from releases might just as easily get rate limited too, and I think it has occurred at least once in a high-profile outage recently... it has worked for me and rarely contributes much noise to my Flux slack notifications. What would be better than using the artifact at an HTTP URL is using it from a GitRepository source, so that Flux can cache it and avoid fetching them again when the source hasn't changed.)
This specific approach will not work for prometheus-stack for prom-operator I'm afraid because they do not publish the CRDs in the same way at a release URL. You can still reference them directly as files from a raw github HTTP URL in a git branch or tag, but this is sub-optimal and seems likely to incur the wrath of rate limiting as it will not be cached if it's done this way in the Kustomize overlay.
This approach is IMHO the best for solving this particular problem:
https://github.com/kingdonb/bootstrap-repo/blob/staging/infrastructure/crds/traefik-crds.yaml
Create the CRDs in a Kustomization by themselves, then include them from the git repository source. You can use this example directly from Traefik, combine it with the CRDs from prometheus-operator that are published in their git repository:
https://github.com/prometheus-operator/prometheus-operator/tree/main/example/prometheus-operator-crd
Apply them in a Flux Kustomization by itself, then apply that Kustomization from another one called infrastructure as in the example of my bootstrap-repo. There is honestly quite a lot going on in my bootstrap-repo example repo, maybe it would be better if I linked to this version with a lot less going on in it, (still has the same great example, we're installing Traefik CRDs in advance, then waiting for them to be ready before making downstreams apply): https://github.com/jakubhajek/traefik-gitops
I think the best thing to do if you don't like having two separate dependsOn Kustomizations, is to disregard the CRD installation that happens inside of the helm chart altogether and handle CRD installation in the Kustomize overlay instead.
tl;dr: cert-manager publishes the CRD as part of the release artifacts, which makes this really easy for us:
https://github.com/kingdonb/bootstrap-repo/blob/staging/apps/cert-manager/kustomization.yaml#L4
... but prometheus-operator does not. With a complete understanding of how Flux caches artifacts, it should be clear enough that the "traefik-crd" approach above is better than the "cert-manager" one in terms of caching and avoiding failed applies due to rate limiting or other temporary/intermittent kinds of remote availability failures.

I was going to lead with this info, but I wanted to say the workaround more concisely and get to the point, in case you're actively struggling with this, and that bifurcated into two ideas, so unfortunately this wall of text. Maybe better to start with: the classic solution to this issue uses Flux Kustomization's dependsOn: first install the HelmRelease, including CRDs there with install.crds and upgrade.crds set to CreateReplace just as you have done. In the Kustomization which installs it, set Kustomization.spec.wait so that Kustomization waits for the HelmRelease to become ready. This will signal that CRDs are applied and a second Kustomization can dependsOn the first one, now it will be able to apply its own CRs reliably.
Personally I think that while it's nice Helm Controller supports CRD operations that even Helm itself does not, it's working against the grain of the tool, and it's better to acknowledge that Helm itself just isn't very good at managing CRDs at all. If we can use a different tool to manage them it would be better, and realistically though I have an idea for how it could work, I think it unlikely to be adopted and more likely that Flux will never reach through Kustomization and wait for HelmReleases as I've described before, it's not currently smart enough for that, and would require Flux to treat HelmReleases specially again.
The approach is not much different, same as above: first install the CRDs, then install the instances, except that when it is all handled by Kustomize controller, you don't need a separate one or any dependsOn just for applying CRDs and CRs in the right order. So when the CRDs are applied by Kustomize Controller, the HelmRelease can still manage the helm installation, there is only one Flux Kustomization needed, and you can apply the CRs at the same time as the CRDs and HelmRelease.
(That strategy won't work if HelmRelease installs any admission webhooks that might have been required to validate the CRs. I don't think that's a concern for any of these, but maybe others truly need HelmRelease to be ready before CRs can be installed, else they fail validation by admission webhook... that's another complicated issue outside of what you asked.)
I have some ideas about how prometheus-operator could publish their CRDs differently to make it easier for Flux users to do this in whatever way suits them best; in my opinion the example of cert-manager is top notch, but that idea is not required if you use the solution above. Basically we need an HTTP url for the CRD so we can include it in a Kustomize Overlay, then the configuration required can be drastically simplified compared to above. This is harder than it needs to be, but maybe better this way for caching opportunities, and to avoid being rate limited later by Kustomize pulling the same HTTP url every time.
Utilities like prometheus-operator should provide better guidance about which CRDs to apply at install time and how to handle this. They do acknowledge the Helm chart for kube-prometheus-stack has CRDs which will helm does not manage with a note in the docs: https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack#upgrading-chart – I feel like this is one place where deferring to the Helm docs is quite a bit less than helpful, given Helm basically leaves it up to the chef in how to handle installing CRDs and upgrading them; Helm Controller users have the privilege of using CreateReplace strategy for both install and upgrade, but, prometheus-stack surely doesn't assume its users will be using Flux v2 and Helm Controller. It's not clear what other options there are, and it would be better if prom-operator explained specifically how to go about managing the CRDs as it suggests. (It seems they assumed you'd be smart enough to know that Helm's doc means you should apply the CRD at the latest version before or during every upgrade.)
The cert-manager installation provides the best example model for prometheus-operator here IMHO:
https://cert-manager.io/docs/installation/helm/#option-1-installing-crds-with-kubectl
They actually include this step in their Helm installation docs as Option 1; as I have suggested, they also suggest, don't even bother using Helm's support for CRDs. You can use it, but with Flux you're currently stuck with this issue as it's not smart enough to reach through the HelmRelease, and as I mentioned it probably never will be. (I should take a highlighter and note any forward-looking statements are my opinion and could be up for debate! It's certainly not up to me to decide...)
In Flux, if you take that option, just manage the CRDs outside of Helm altogether, you can get away with using a single Kustomization and a single HelmRelease. I don't have any complete example handy that actually uses HelmRelease too, maybe I should add one, but since we're just handling the CRD for ourselves that doesn't change much.
Hopefully this adds some additional color about the dimensions of this problem, and known possible solutions that are already extant for this issue. 👍 thanks for your report @jr0dd

@kingdonb I appreciate the thoroughness in your replies! I was reorganizing my repo last night and just thought no better time than now to bring for discussion. CRD management in k8s is just a mess in general.
After moving most out of the CRD directory in my repo last night I'm debating moving them all back for consistency. I just find it a little cumbersome and then having to create a regexManager for renovate to keep them up-to-date when they don't follow semver.
I didn't even realize flux had that CRD install/upgrade option until last night. Which is great if they are actually located in the crds dir and if no other helm releases need to install their CR's beforehand...

@jr0dd I should highlight this: https://github.com/jakubhajek/traefik-gitops/blob/18c3373233fb26997849d335e179623809d98393/infrastructure/crds/traefik-crds.yaml#L11-L16
spec:
  interval: 30m
  url: https://github.com/traefik/traefik-helm-chart.git
  ref:
    tag: v10.3.0
  ignore: |
    # exclude all
    /*
    # path to crds
    !/traefik/crds/

This is really the best example, when GitRepository has in spec.ref a semver tag, hypothetically you can even combine this with ImageUpdateAutomation so that CRD changes always get a commit in the repo. That would be a good example... 👍

@kingdonb That is an interesting approach with the configmap and image automation controller.

Yeah as an approach it would be more usable if charts and app version were the same, but they're not likely to be the same in most cases, so you can't really use image automation for that... except in certain cases where maybe you can.
If it looks like it won't work, don't strain too hard at it. But the configmap + envsubst to avoid writing the same version number twice in two different manifest files (and inevitably forgetting to update one of them along the way somewhere) is definitely a winning strategy 👍

I think there's a pretty strong argument in terms of usability that if HelmReleases are going to be able to manage CRDs, then there ought to be a special case of Kustomization which waits for a HelmRelease before applying from a bucket of CRs.
It's not that different than what the Flux Kustomization does now, it enables a common pattern, and it is a use case that would allow Flux to shine more brightly and send fewer users away complaining about a tedious but necessary workaround.
Anyway, I think feature requests, along with Q&A and RFCs/Proposals are all meant to start out on the Flux2 Discussions page, based on our support policy around feature requests, this should be a discussion.
I'm not sure if it's possible to migrate an Issue to a Discussion, but I'm afraid that it isn't, and we'll have to close it instead. You're welcome to open up a discussion and refer back to this one though!
Closing, (it's labeled as a feature request and the issues queue is meant for bug reports)


Help me.

I have one slider menu to open another activity then delete the current title in tabhost then add the tab title new.With old material used
 for (int i = 0; i < 25; i++) {
            tabHost.removeAllViews();

        }
  for (int i = 0; i < this.pagerAdapter.getCount(); i++) {
            this.tabHost.addTab(
                    this.tabHost.newTab()
                            .setText(this.pagerAdapter.getPageTitle(i))
                            .setTabListener(this)
            );
        }

Work fine.
but I use it in the new version can remove title but not add title.

I don't get your problem.
You use the materialtabhost where? inside a fragment or an activity?
Then, what is the problem?

@toankul I think, your issue is about your activity's toolbar pading. Check your activity theme or toolbar layout property.


[FEAT]: Pre-Processing User Queries with LLM for Improved Similarity Search

What would you like to see?
Add a feature  where user queries are first processed by an LLM to better match the indexed data. This processed query is then sent to the vector database for improved search results.
Workflow:
User submits a query.
Query is processed by an LLM to align with indexed data.
Processed query is sent to the vector database.
Search results are returned to the user.
Benefits:
Enhanced search accuracy.
More relevant results.
Improved user experience.
Example:
Original Query: "How to fix login issues?"
LLM Processed Query: "Resolving authentication errors in user access"
Thank you for considering this request.
Other benefits: extract matadata from query that suits db || translate user query into general language of embeded-models exemple: translate chinese query to be translated by LLM into english to match db data that is in english

Closing this as not planned. Any pre-processing steps would be very use-case dependent and results of using an LLM to "expand" a query for better RAG results are typically better handled via implementation of knowledge graph support and even reranking models. These results even then tend to be highly dependent on the documents used and increase latency by a lot with minimal improvements to the end result.
however, its worth mentioning that this really I think would be better handled via a middleware/plugin system that can run in AnythingLLM that a user can inject. This way, the tool can still support the workflow you intend to use but does not have to be maintained by the core-team since any specific pre/post processing to a query would likely be unused by some greater population of users.

Thank you!


Add 2022-02-01-preview to Microsoft.MachineLearningServices

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
March 1st, 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
End of March
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

    "x-ms-long-running-operation": true

Noticed that your PUT calls seem to be async but you didn't add this property, is that intentional?

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json:3337 in 3b1ac1f. [](commit_id = 3b1ac1f420a939a22e125869b16e6381001d291d, deletion_comment = False)

  "put": {

Here's an example of PUT that seems to be async without x-ms-long-running property

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json:3101 in a3e5550. [](commit_id = a3e55502b1488e7878a5faf00fa24d9b920bcb36, deletion_comment = False)

  "put": {

Here's an example of PUT that seems to be async without x-ms-long-running property
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json:3101 in a3e5550. [](commit_id = a3e5550, deletion_comment = False)

EnvironmentVersion is not async, and thus not decorated with the x-ms-long-running-operation property. as per ARM (non-async) PUT guidelines:

The resource provider should return 200 (OK) or 201 (Created) to indicate that the operation completed successfully synchronously.

where 200 means updated and 201 means created

    "x-ms-long-running-operation": true

Noticed that your PUT calls seem to be async but you didn't add this property, is that intentional?
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json:3337 in 3b1ac1f. [](commit_id = 3b1ac1f, deletion_comment = False)

I think our async APIs are decorated properly... I'm not sure I understand which APIs you're referring to, specifically. or did my previous comment address this?

    "x-ms-long-running-operation": true

Noticed that your PUT calls seem to be async but you didn't add this property, is that intentional?
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json:3337 in 3b1ac1f. [](commit_id = 3b1ac1f, deletion_comment = False)

I think our async APIs are decorated properly... I'm not sure I understand which APIs you're referring to, specifically. or did my previous comment address this?

Yes, I am making sure that your intention is to model a sync API and not async -> see here for async recommendation:
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put which specifies HTTP 201 or 200 for async as well.

Signing off with a small comment - the modeled POST API for now is sync but needs to be modeled as async in the upcoming api-version, reason to be async is because the API might exceed KPI/P99 of 2 seconds.

Hey @forteddyt we have quite a few required CI failures, could we fix those first?

hey @ArcturusZhang - the remaining LintDiff (see https://github.com/Azure/azure-openapi-validator/issues/248) and ModelValidation failures are false negatives. I've looked into the azure-sdk-for-go gate failure and will fix the issue once I have some time. I haven't looked at the other, non-required, gates :)
Regarding the ModelValidation failures, the “secrets” property in the spec is both x-ms-secret and required. From the x-ms-secret documentation, this scenario should not have the property be present in responses.

/azp run

/azp run


Fix and Enhance Core doxygen generated docs

The doxygen generated docs could use http://mcss.mosra.cz/doxygen/ as layout, which would give us instant search results and a better look and feel (imo)
However currently the docs are not displayed at all: https://docs.inexor.org/core/index.html

We could also use a solution like that: https://htmlpreview.github.io/?https://github.com/OlafvdSpek/ctemplate/blob/master/doc/index.html
no need to host the docs ourselves.

We could use travis and github gh-pages:
https://gist.github.com/vidavidorra/548ffbcdae99d752da02
@Croydon Would it be possible to integrate this into our travis pipeline?

It is live now again on https://docs.inexor.org/core/master/


Scrape Professor Data

Create a scraper to get data from https://profiles.utdallas.edu/ for professor data to populate the database.

It's done on Josh's fork.


Breadcrumbs problem with Gem

In the latest Gem from the foundation package there's in an error in the foundation.css stylesheet related to the new breadcrumbs UI element.
The styles are using the name '.breadcrums' instead of '.breadcrumbs'.
ul.breadcrums {

Thanks, the following commit resolves this issue:
zurb/foundation-rails@457c3762c6a17cb01bc3c541bdb181587e0a1bcd
I've also released v<IP_ADDRESS> of the gem, so go ahead and run 'bundle update zurb-foundation' and you should be all set.  Thanks!


Fixed HaxeRunner, HaxeDebugRunner for HXCPP, Flash targets in OpenFL Lime toolchain

Fixed HaxeRunner, HaxeDebugRunner for HXCPP, Flash targets in OpenFL Lime toolchain

Hi @EBatTiVo , Can you please review and approve?
Thanks,

All these changes were already part of src/13.1 code line.
These were not cherry picked when making src/14, and src/14.1 versions.
These cannot be moved into src/common due to some API differences.
e.g. setWorkingDirectory is correct call in 13.1, where as it is deprecated and replaced by withWorkingDirectory. Similarly, Runner's calls to instantiate a process does not take 'project' and few other parameters that were in 13.1. Also, 14 and 14.1 differ in some templatized types.

Approved.


Ubuntu 16.04 - working fine in CLI, does not as an Apache2 module

I've set up a new Ubuntu 16.04 (which comes with PHP7) and need to install a 5.x version of PHP. Installation works fine, no errors when building and libphp5.4.12.so exists in /usr/lib/apache2/modules (folder and file are chmodded correctly).
The Apache2 module is active and /etc/apache2/mods-enabled/php5.load contains
LoadModule php5_module        /usr/lib/apache2/modules/libphp5.4.12.so
The problem is that PHP code is shown as code in the browser and it seems that PHP 5.4.12 is not executed on Apache2. I followed all steps in the cookbook and troubleshooting sections but to no avail.
Command
phpbrew --debug install 5.4.12 +apxs2 +mysql +debug
Platform
OS: Ubuntu 16.04
Running PHP: PHP 7.0.4-7ubuntu2 (cli) ( NTS )
Installing PHP: 5.4.12

do you have
AddHandler application/x-httpd-php .php
in your apache config file?

@jhdxr now this is really humiliating ;)
I was indeed missing the Handler for PHP in mime.conf - thanks for pointing that out.


How to drop some nuxt runtime config into service worker context?

My app needs to make requests to the api. The api endpoint is set in a runtimeConfig variable that is inlined during assembly so it can be inlined in both context. How can I drop the config into service worker context?

@cawa-93 have you tried to import useRuntimeConfig from #app or #imports and use it inside the sw (never tested)? Or maybe you can use import.meta.env inside the sw.

@userquin Yeap. SyntaxError: Cannot use import statement outside a module. Everything looks like the plugin does not process or interact with scripts at all.

@cawa-93 have you configured devOptions.type = 'module'?

@cawa-93 have you configured devOptions.type = 'module'?

Yes.
    devOptions: {
      enabled: !false,
      type: 'module',
    },

I'm getting this error:
...
import { useRuntimeConfig } from 'nuxt/app'
import { onNotificationClick, onPush } from './web-push-notifications'
import { onShareTarget } from './share-target'

declare const self: ServiceWorkerGlobalScope

self.addEventListener('message', (event) => {...})

const singleInstance = useRuntimeConfig().public.singleInstance
console.log('Single Instance', singleInstance)

I suggest you to provide some process.env variable and use it in define, then access it using import.meta.env in the sw. Reuse the variable for nuxt runtime config entry

Running this script in elk.zone repo "dev:mocked:pwa": "VITE_DEV_PWA=true nuxi dev --port 5314 --dotenv .env.mock",:

I was confused that the default strategy was generateSW and my little custom script for was included as workbox.importScripts. It seems that I will have to change the strategy to injectManifest and somehow write the worker myself


Custom extended hints mode

Hi
I just recently switched to pentadactyl and it solves most of the limitations I had with vimperator.
One annoyance remains, however (that I didn't manage to solve):
Is there the possibility to create custom hint actions? The default one is "open", ";" allows for different ones, but is there a way to define a new one?
The uses I have in mind are:

I have a "mpv" command that opens the current page with the mpv video player (I use this for youtube videos). I'd like to be able to open links directly in mpv without having to load the link first.
I would like being able to save links to pocket without opening them (although I would have to figure out how to save links to pocket through pentadacyl at all, currently I am using the default hotkey the pocket addon offers)

Am I missing a feature or is this just not possible?

you can add new extended hints for ; with
javascript <<EOS
hints.addMode("k", "prompt", function)
EOS

There are several example pentadactylrc gists with such commands. The second argument to the function would be the hint's location, see https://github.com/5digits/dactyl/blob/174b8ae0b67b501509494ba4462c077010955915/common/content/hints.js#L790
I was in a similar situation with pocket, and have found a relevant function at https://dxr.mozilla.org/mozilla-central/source/browser/components/pocket/pktApi.js#319. But now I have switched to wallabag, which just uses a simple GET to add an url.

Thanks, I already gave up hope but this is exactly what I needed.
For the record, if anybody finds this on his quest to add a mpv extended hint:
javascript <<EOS
hints.addMode("m", "prompt", (elem, loc) => dactyl.execute("!mpv '" + loc + "' &", null, true));
EOS

You have to press escape after selecting a link, otherwise the navigation somehow doesn't work.
The pocket api also is quite helpful. I suppose this is where the integration everybody hates proves itself helpful. However, when I try
:javascript pktUI.tryToSaveUrl("https://github.com", "github")

nothing happens. Manually pressing the "pocket" button in firefox works though.
Maybe I should simply also try out wallabag before fighting the pocket api further. I intended to do it for a while now anyways.
Thanks again!

In case anyone is still looking for pocket integration, you can use ;c<hint>o to access the "Save link to Pocket" context menu item.


Drop Preview in Schema editor?

@roll I wonder if users need to see the resulting JSON at all. They can't edit it anyway so I think it would be simpler to just have a Save button.

Fixed in #25 (with<EMAIL_ADDRESS>


Us070

https://trello.com/c/nnkdCIqd/157-us070-int-view-all-outstanding-responses-l-needed-for-release-18

Codecov Report

Merging #104 into master will decrease coverage by 0.09%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master     #104     +/-   ##
=========================================
- Coverage   97.46%   97.37%   -0.1%
=========================================
  Files          29       29
  Lines         988      992      +4
=========================================
+ Hits          963      966      +3
- Misses         25       26      +1

Impacted Files
Coverage Δ

response_operations_ui/views/surveys.py
100% <100%> (ø)
:arrow_up:

response_operations_ui/views/reporting_units.py
98.85% <66.66%> (-1.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eaa41b...ab30b13. Read the comment docs.

:+1: Looks good but we do need tests for the new functionality


feat: Use the Slivers mechanism with the Gallery view

Hi everyone,
As explained in #4912, the Box mechanism in Flutter ensures that ALL Widgets are built, even if they are not visible by the user. For that, we have Slivers and their lazy loading capacity.
This PR moves the code to Slivers and also simplifies it by not relying on rows of 2 items.
A demo:
https://github.com/openfoodfacts/smooth-app/assets/246838/6081c7eb-5da5-4513-a7fa-70d44b38005b

Codecov Report
Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (fe7e1f8) 9.67% compared to head (273b2d8) 9.66%.

Files
Patch %
Lines

.../lib/pages/product/product_image_gallery_view.dart
0.00%
70 Missing :warning:

packages/smooth_app/lib/widgets/slivers.dart
0.00%
25 Missing :warning:

.../pages/image/product_image_gallery_other_view.dart
0.00%
21 Missing :warning:

...p/lib/generic_lib/widgets/images/smooth_image.dart
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4913      +/-   ##
==========================================
- Coverage     9.67%   9.66%   -0.01%
==========================================
  Files          318     319       +1
  Lines        16115   16125      +10
==========================================
  Hits          1559    1559
- Misses       14556   14566      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks @g123k and @monsieurtanuki 👍


make sure helpers return strict string

not sure if this is look good to everyone, but it reduce lots of code like:
(this.charset || '').toLowerCase();
(this.get('ua') || '').indexOf('chrome');
(this.type || '').match(/\/^text/);

and this won't break your app if your are using !this.get('referer') etc.

LGTM. can't see any possible breaking changes. anyone else?

LGTM but I think there are missing return ''; in request.get(field)

LGTM

Strictly it's still a breaking change because we didn't tell people to use lose equality checks, if someone is strictly comparing typeof this.get('referer') === 'undefined' it breaks. i'm not sure though if someone does that even.

LGTM

:+1:

0.20.0 ?

go for it!


Tooltip in member table about vote probability is not working

Cannot figure out why the tooltip isn't working. Identical code to other tooltips that do work on that page and other pages. Maybe something in the javascript or css that I couldnt find out.

I think this is the newer version of jquery-tablesorter fighting with the tooltip. I am looking at this.


bmw  md

It works!
On Sat, Aug 24, 2024, 06:14 request-info[bot] @.***>
wrote:

Thanks for this. Do you mind providing a bit more information about what
problem you're trying to solve?
—
Reply to this email directly, view it on GitHub
https://github.com/pages-themes/hacker/issues/169#issuecomment-2307961234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKN7HX3F5TWPYXDDSQBCHCTZS7JQFAVCNFSM6AAAAABNBCNLVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DCMRTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Move validate from transfer app to ui-common

next to tx queue would make more sense, and avoid circular dependencies like accoutns app requiring trnasfer app in order ot validate and queue extrinsics.

fixed in #369


URLS flowing to service discovery

Several times now I have either wanted to consume a resource that I had a URL for OR run a container that I would communicate with via a URL. Therefore I wanted to model both these in the AppHost and then use Service Discovery in another part of my application.
In my mind the first of these is something like the AddConnectionString method we have, something like this:

Where the ollama url would be a parameter that needs to be filled in during deployment somehow, i.e. we wouldn't do anything to try and make it work you would have to provide it.
For the second one the code I wrote naturally without thinking looked like this:

In both these cases I had code in the backend that would communicate with the endpoint of both using HTTPClient either directly or because their SDK would accept a HTTPClient that I would resolve from DI.

With containers you can do this:
.WithReference(vectordb.GetEndpoint("http"))

With regards to having something like AddUrl(...) ... I think we tried something like that and in the end I don't think it ended up being that compelling vs. just using an environment variable/connection string. It isn't something that is dynamically allocated at deployment time (like an ACA hosted endpoint).

Sure, but it is configuration that must be used during development and known about during deployment. So by not modelling it you are creating a piece of dependency information that you cannot reason about in deployment tooling. I would want an ability for an interactive deployment experience like azd to prompt me or for something that is generating deployment artifacts to know that this information is required.
I also want to name the service that I am calling on and have that work with service discovery as I would in the sample code, allowing me consistent HTTPClient usage rather than pulling a URL out of config for just this instance.

Putting this in 8.1. I think it's reasonable to have a concrete overload of WithReference that takes a container resource and has this behavior. We didn't want to enable this by default on the base resource because our containers are mostly connection string based, but we can avoid the ambiguous interface problem with more overloads.

I am interested in the ambiguity as I don't know what you hit before. Had parameters been designed last time? since I think this is that with some bells on.
Something else that may be a completely different feature. A thing I am working on at the moment has multiple projects that call into the same external API, and therefore need to be configured with the same bearer token to allow access to that API. Right now I am using user secrets and environment variables in the AppHost to avoid duplication on each project. These two things seem related if I was to model the URL for the external API the way I described here then I would also want to configure the token here and say that it is a bearer token that needs to be set when creating a client for this URL.
I thought it was worth throwing this in for consideration as we looked at it. Not sure we have to solve it.

Just to add some ideas here, I would add some more points.
builder.AddExternalApi<IStock>("stock")
    .WithHttpsHealthCheck("/health",r=>r.Health() ); // added one of the APIs as a health check

Add the url as a resource , with health check, could add to the dashboard possibility to monitor when the resource is down, and to mark the main api as degraded
another point to health check is to add circuit break in the resource, that could be added to the service defaults
I'm not sure if the interface of the webapi client could or should be added to the apphost project for this, or if it could be added like the project reference
this could be used to reference the environment version of the api
we could add Infrastructure information to the apis, like vpn, certificate, reverse proxy, and to configure timeout, retries, etc.


meta-raspberrypi: refactoring for consistency

I did some refactoring work to meta-raspberrypi to be more consistent across all recipes and hence easier to maintain/understand the layer. See below.

standardised all files directories to ${PN} and adapted bbappends according to official Yocto recommendations
use _git suffix for recipes pulling from git repositories without a specific version
use _% suffix for bbappends when missing or instead of specific versions
standardised installation of udev rules into /etc/udev/rules.d
flattened xserver-xf86-config files directory

Affected recipes:

bcm2835-bootfiles
formfactor
rpi-u-boot-scr
pi-bluetooth
psplash
udev-rules-rpi
udev-rules-udisks-rpi
pi-blaster
wiringpi
vc-graphics-hardfp
vc-graphics
xserver-xf86-config
linux-raspberrypi-dev
linux-raspberrypi_4.9
gstreamer1.0-omx
x264

I tested all the affected recipes and they are all building successfully.

You need to break this down into separate patches that can be reviewed. You have some non-functional whitespace cleanup in with some changes which do affect the resulting images (e.g. standardised installation of udev rules into /etc/udev/rules.d).

Thanks for the feedback @betafive.
I thought about doing this one by one but then I realised it might create too many PRs.
Or do you mean to separate into multiple commits in the same PR?
Github allows to comment every part (renames, code change, etc.) of the PR/commit I submitted too.
I am curious about the issue you mention (the non-functional whitespaces). I guess you mean this piece?:
SRC_URI = " file://99-com.rules"

turned into
SRC_URI = "file://99-com.rules"

I did build the recipes individually and into an image and they worked fine in my build env using the standard image recipes.
Let me know how should I proceed. Thanks and happy to help.

Ah I see, I got confused. Ok I will separate the cleanups into logical commits in this PR.
Thanks for the patience guys :)

separated refactoring/cleanup into separate commits per recipe now

I think I've explained this badly. The idea isn't to split out changes to each recipe into commits, it's to split out functional changes from whitespace changes and cleanups. https://github.com/agherzan/meta-raspberrypi/pull/263/commits/f95536d9369df61c82a366100178f9271b888621 is a good example - this should be at least 3 separate commits (base_libdir -> sysconfdir change, setting S (which I'd argue is unnecessary) and whitespace cleanup).
You can have a single whitespace cleanup patch the touches several recipes, a single files -> ${PN} rename patch which touches several recipes, etc. The idea is to be able to debug more easily later if we find problems. For example, renaming an _${PV}.bbappend file to _%.bbappend' may be something we need to look at again later if the underlying recipe changes but this is logically separate to renaming ${PN}directories tofiles` everywhere.
Does that make sense?

hi @betafive , yes I agree with you.
I re-did the PR now grouping the refactoring, clean-up and functional changes apart from each other.
I hope is clearer now. I'm traveling tomorrow until next week, but I will check the comments once I return.

This is where I hate GitHub as I can't comment on commits themselves, so I'll give my review here:

https://github.com/agherzan/meta-raspberrypi/pull/263/commits/ea53ac55599343c8b9aecbf9f4ff52a98158d0c9: LGTM now
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/1b131735e5cbc4778a47ad956502b17a0be931fe: LGTM
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/644520eb5d2a80daa568aaad8f79b4206fb7fb30: LGTM
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/6ad53e3780394a104eec7b5bdd4c2ec2a2430293: The rpi directory is there so that the modifications are only applied to Raspberry Pi devices. I'd say we should keep the current directory structure as-is here.
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/08c9a0315177b84b3d1e38d01f5471112674979b: LGTM
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/2f7aac2f9517cf2b06da3f9a1255f2eca639954c: Not sure what this achieves.
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/530672d981d78876481185d34eecfc9784a9c9b3: LGTM
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/dc8adcc3a0ba7a8025be535306d647c4f735e3df: Why is this change needed?
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/3dc4b7010ac3b40ccc5ca1a8c49b7a7fdd5cfd54: LGTM
https://github.com/agherzan/meta-raspberrypi/pull/263/commits/3e59ecb7b9f86e87cfea66142f7b6b026141e597: LGTM

One common thing - could you modify the commit summaries so they don't wrap onto a second line?

I have questions about this series. So for expediency please divide it into multiple pulls. One could be just the formatting changes and there are more intrusive changes which I think should be dropped.

Hi all, this PR is now just for renaming files and directories (no recipe content changes), with the sole exception of updating how generic licenses from Poky are used. In summary this PR now only contains:

wiringpi: use lower-case in recipe directory name
meta-raspberrypi: use generic licenses in ${COMMON_LICENSE_DIR} from Poky
meta-raspberrypi: use _git suffix in recipes without a specific version
meta-raspberrypi: use _% suffix instead of specific versions for bbappends

Those changes are all tested and doesn't change anything beyond cosmetics and files naming.
I will submit more PRs with the other proposed changes separatedly.
@betafive , you asked for commit messages to not be split. This is only happens in GitHub's UI, I can't control it. However, I can assure the messages aren't chopped in the actual git log.
Hopefully all is ok now and can be merged in stages =)

Mmm you are right. I got confused because it fetches from github using a commit hash instead of a particular version tag.
Should I update the recipe name to reflect the date, e.g. bcm2835-bootfiles-20180417.bb?
The same then applies for the vc-graphics recipes that also pull from common/firmware.inc.
I know this implies more work at every update (needing to rename the recipe every time), however it makes clear what version the recipe builds, and is the same approach many recipes in Poky adopt.
My objective is just to make the layer clearer (easy to understand) and manage.

I just noticed that the variables controlling the firmware version/revision are default assignments (?=):
RPIFW_DATE ?= "20180417"
SRCREV ?= "5db8e4e1c63178e200d6fbea23ed4a9bf4656658"
RPIFW_SRC_URI ?= "https://github.com/raspberrypi/firmware/archive/${SRCREV}.tar.gz"
RPIFW_S ?= "${WORKDIR}/firmware-${SRCREV}"

So this makes the firmware version configurable from local.conf and renders naming the recipe after a version number such as the date inviable/irrelevant.
Is this an intended feature or should the firmware version be static in the recipe itself like any other package? If the former, then maybe this should be documented and I agree the _git suffix doesn't apply.

This is intended and it's something I've used a few times. It's undocumented as it's not a "normal" configuration setting (such as RPI_USE_U_BOOT) where we test the different options. So yes, this can be overridden but if you do so you're on your own.

Hi @betafive , thanks for the clarification.
I decided to leave the bcm2835-bootfiles and vc-graphics recipes untouched for now after your and kraj's remarks, so no _git suffix for these. I updated the PR accordingly.
In summary, this PR's changes are:

meta-raspberrypi: use _% suffix instead of specific versions for bbappends
pi-bluetooth: use _git suffix in recipe filename
meta-raspberrypi: use generic licenses in ${COMMON_LICENSE_DIR} from Poky
wiringpi: use lower-case in recipe directory name


KryptonDataGridViewComboBoxColumn and DataSource

Hi guys, I welcome your incredible software.
but I have a question: how can I fill a KryptonDataGridViewComboBoxColumn with a collection like the standard ComboBox, I see that it does not have the DataSource property.
Please, if anyone could indicate me, thank you.

I use Items like this.
var column =  new KryptonDataGridViewComboBoxColumn();
column.Items.Add("item 1");
column.Items.Add("item 2");
column.Items.Add("item 3");

In this way it's not possible to bind the list to a key/value structure. If you set the ColumnType poperty to DataGridViewTextBoxColumn, it works but the appearence is different from the rest of the form

In this way it's not possible to bind the list to a key/value structure. If you set the ColumnType poperty to DataGridViewTextBoxColumn, it works but the appearence is different from the rest of the form


Is the return-type of process_bind_param correct?

here the return type is defines as typing_Text and I'm not sure if that's correct. If I have the following type-decorator I get a typing error but the code works:
class DbInfiniteInt(TypeDecorator):  # type: ignore
    """
    A codec which maps a database integer value to "MaybeInfiniteInt"
    """

    impl = Integer

    def process_bind_param(
        self,
        value: Optional[MaybeInfiniteInt],
        dialect: Dialect,
    ) -> Optional[int]:  # <-- mypy complains about this return-type
        if value is None:
            return None
        if value.is_infinite():
            return -1
        return int(value)

I think you're right, that it's not. We've had to use # type: ignore on our process_bind_param functions. (I think this is a duplicate of #205 and #206.)

You're right. It's a duplicate. I'm closing this in favour of #205


Lacks support for MacOS

Currently, this package does not support MacOs.  This needs to be addressed.

fixed in https://github.com/ryanrosello-og/pict-pairwise-testing/pull/6
Release 1.1.0


Fixed bugs in generate_dataset.py

Fixed bugs:

The latest version of pytube can work now. We just have to reinstall it. I added a comment to remind others of this approach.
videoname is referenced before the declaration. I declared this variable and checked None before using it to solve the error.
At this line, we should use [-1], not [-2]: if videoname_candinate.split('.')[-1] == '/current_' + mode:. Because ./current_train is the part we want to find.

Thanks for PR.
I'm afraid to say that currently I have no PC to run this script, so I reviewed your PR without running.
Regarding 3. , I have one question. I suspect that videoname_candinate.split('.')[-1] is file extension. So it seems current code is correct. Is this idea wrong? If it's wrong, I'm going to accept your PR.

Thanks for your reply. After some experiments, I am sure it should be [-1]. Here is my explanation.
I printed the videoname_candinate and get videoname_candinate =  ./current_train. After splitting by ".", the last element denoted by [-1] is '/current_' + mode which is the part we want. If we use [-2], we will get a None and result in an error of the empty video name. I just made an experiment on my PC to make sure that [-2] doesn't work and [-1] works.

I think yaoxiao is correct. The index shoud be -1.


jx-build-controller CrashLoopBackOff - could not read Username for 'https://github.com': No such device or address'

Hello,
I followed all the steps mentioned. The EKS cluster is created and the jx operator is installed successfully. But when i see the pods inside jx namespace, i see the two jx-build-controller pods are in status CrashLoopBackOff. When i looked in to the logs, i see this.
FATAL: failed to get cluster requirements: failed to clone cluster git repo https://github.com/awsomedevops/jx-cluster.git: failed to clone repository https://github.com/awsomedevops/jx-cluster.git to directory: /tmp/jx-git-794802922: failed to run 'git clone https://github.com/awsomedevops/jx-cluster.git /tmp/jx-git-794802922' command in directory '/tmp', output: 'Cloning into '/tmp/jx-git-794802922'... fatal: could not read Username for 'https://github.com': No such device or address
I have updated the cluster git URL and the github bot username correctly in the variables.tf. Could you please help me what is the issue here?

Hi, could you please help me on this?

Hi, could you please help me on this?

Hi, Could you please help me on this issue?

Hi, Could you please help me on this issue?

I think there was a bug which was fixed already, did you try running jx gitops upgrade?

I think there was a bug which was fixed already, did you try running jx gitops upgrade?

I did a fresh install. Still i need to do jx gitops ? or it will automatically take the latest version of git-ops?

I did a fresh install. Still i need to do jx gitops ? or it will automatically take the latest version of git-ops?


upgrade webrtc library to latest stable release 51/52

track this with a new issue.
folks, I created a branch upgrade-webrtc-51 which upgraded webrtc core library to correspond release version 51 branch.
I only tested simple audio part and it looks fine without any slow problems on android.
Since I don't have enough time to test whole stuffs like video or data channel yet, I wish someone whi have problems on the old library can git it a try to see if it solves your problem or makes PR to that branch.
once the branch have been fully tested, we can merge it into the master branch.
for version related discussions, see #79
cheers

51 branch revision is 12700 ( Stable )
52 branch revision is 13039 ( Beta )

NOTE:
I have some problems when uploading large library files several times. ( seems my ip get blocked for a while)
thus, in these two new branch 51 and 52, I stored library files on Git Large File Storage (LFS). I'm not sure but if you have problems when clone branch, try install git-lfs first, it has a handy command for installation on website.

The only problem with lfs is that npm does not currently support it, so I can't specify a lfs repo as a package.json dependency. I'll just try to merge the 52 branch into my fork and remove lfs manually.

ah, forgot to mentioned. my bad.
you can just specify install from github by change your package.json like:
"react-native-webrtc"<EMAIL_ADDRESS>or you can clone this repo, said, to the previous level of your project's directory ( ../react-native-webrtc ), and manually checkout react-native-webrtc to the branch you want, then edit your project's package.json to:
"react-native-webrtc": "file:../react-native-webrtc"
finally, npm install will install the branch you specified

Hm, I was doing that for a fork but running into git lfs issues I just removed lfs and it worked fine. I'll try that tomorrow. In any case, 52 works fantastically. It dropped the ICE connection time from 30-60 seconds to 5-10 seconds.

@zxcpoiu thanks for your work!
does this version fixed bugs with camera switching and black screen?

@mobileDevNativeCross
I'm not sure, my use case only involved audio for now, totally no idea with video. :scream:
That's why I invited you guys to test on newer version of webrtc to see if it fixed or improved.

0.10.0 released with branch 52 stable.
It seems not differences between beta and stable, but just in case, I still recompiled again and including it in master.


Add jpeg and png format for logo

Logo should support jpg and png format.
logo.jpg and logo.png should be supported.

I added jpeg and png format for logo.


Add SHR support for JS-WAM bridge

This feature adds the below support to the token binding work on MSAL Browser:

Adds support for POP tokens
Generates SHR in the msal-browser in case native layer doesn't support it

Codecov Report

Merging #4627 (2bd9d37) into wam-bridge-server-first (6825c67) will not change coverage.
The diff coverage is 88.46%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.39% <ø> (ø)

Carriedforward from 6825c67

msal-browser
87.80% <100.00%> (ø)

Carriedforward from 6825c67

msal-common
85.01% <85.71%> (ø)

Carriedforward from 6825c67

msal-core
82.67% <ø> (ø)

Carriedforward from 6825c67

msal-node
82.20% <ø> (ø)

Carriedforward from 6825c67

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from 6825c67

msal-react
92.46% <ø> (ø)

Carriedforward from 6825c67

node-token-validation
83.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

...er/src/interaction_client/BaseInteractionClient.ts
98.03% <ø> (ø)

.../msal-common/src/client/AuthorizationCodeClient.ts
76.80% <83.33%> (ø)

lib/msal-common/src/crypto/PopTokenGenerator.ts
93.75% <86.66%> (ø)

lib/msal-browser/src/app/ClientApplication.ts
96.39% <100.00%> (ø)

Are there tests that be added? Or will those be added later?

Later. Thomas is manually testing this. I will have a cache PR out soon which will include some unit tests for SHR too.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #31.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #31

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin rerender


Move SVM examples to a new workspace

Problem
SVM examples contain too many dependencies that are not necessary for the crate. When we create a new repository out of it, we don't want it to depend on other parts of the validator, so tests dependencies would ideally be separated from those of the main crate.
Summary of Changes
Make the examples a separate cargo workspace. It will also need a new CI job, since it is now self-contained.

Looks like some dep change is causing the CI failure. I tried running it manually, and it's failing consistently with this PR, and passes on the prior commit.

Looks like some dep change is causing the CI failure. I tried running it manually, and it's failing consistently with this PR, and passes on the prior commit.

I'll check that. I had the impression it was unrelated, because I didn't touch on any Rust file.

The CI in my test PR turned out green: #3635. I had to rebase this one and make some adjustments, so I'll wait for CI to finish before requesting everyone's review again.


Dymoconnectdesktop label

Added Dymo Connect label, downloadURL uses the Dymo Compatibility chart webpage (https://www.dymo.com/compatibility-chart.html ) and looks for all the pkg links and arranges the latest. App New Version looks for the same links and cuts the version number.

Thank you!


Update Azure Maps python SDK example code

Update Azure Maps python SDK example code. Consider zero result case
author: sinnypan
ms.author: sipa
ms.date: 03/21/2023

@eriklindeman
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off


Prediction doesn't work if levels/labels have been deleted and replaced

If annotations are deleted and then new ones created an error occurs on prediction
Example error message:
[IndexError]
Index 2 is out of bounds for axis 0 with size 2

Fixed in SuRVoS 1.5.2


Make available as meteor package

I'll fork and create a pull request.

I've created the package in my local machine, but I just realize I'll have to use jandres:js-combinatorics where jandres in the user.
Is it fine if its like that? The preferred way is dangkogai:js-combinatorics, but that needs you need atmosphere account.
Tell me and I'll push my local commit and file a pull-request.

Please PR me.  PR is always welcome so long as it does not break other package environments.

Pull requested is now filed.


unable to remove keys from hashes after interop

in a normal lua environment, my understanding is that the normal way to remove a key from a hash is to set its value to nil, like this:
lua -e "obj={print_me='foobar',dont_print_me='foobar'}; obj.dont_print_me=nil; for k,v in pairs(obj) do print(k); end"

prints only the one key
in wasmoon it works the same with no interop
node << EOF
new (require("wasmoon").LuaFactory)().createEngine().then(lua => lua.doString("obj={print_me='asdf',dont_print_me='asdf'}; obj.dont_print_me=nil; for k,v in pairs(obj) do print(k); end"));
EOF

prints only the one key
but if i interop at all with js i get both keys
node << EOF
new (require("wasmoon").LuaFactory)().createEngine().then(lua => { lua.global.set('identity', x => x); lua.doString("obj=identity({print_me='foobar',dont_print_me='foobar'}); obj.dont_print_me=nil; for k,v in pairs(obj) do print(k); end") });
EOF

gets both keys
i'm experiencing a bunch of bugs because in normal code you never expect looping over pairs to return null values, but with wasmoon it does in this case. is there something i can do to fix this?
using<EMAIL_ADDRESS>

looks like that does fix it
node << EOF
>  new (require("wasmoon").LuaFactory)().createEngine({enableProxy:false}).then(lua => { lua.global.set('identity', x => x); lua.doString("obj=identity({print_me='foobar',dont_print_me='foobar'}); obj.dont_print_me=nil; for k,v in pairs(obj) do print(k); end") });
> EOF
print_me

i saw some other issues mentioning these config options, but no documentation describing what they do. is there some somewhere?

closing because the enableProxy:false was the solution here, but i would suggest some more documentation for these options.

i saw some other issues mentioning these config options, but no documentation describing what they do. is there some somewhere?

No, I'm very bad at documenting (PRs welcome)

also, you might consider disabling the proxy by default, because it really causes some issues in otherwise valid LUA code

Actually I think this issue specifically can be a bug and not a expected behaviour of proxying. I will reopen to check this later.


Add CHANGELOG

Maybe I'm blind but I can't seem to find release history for the project. Any plans to add one?

Yeah, there's no CHANGELOG, I always thought that the git log would've been enough for most uses.
But I should at least add some release notes to every release that I tag, do you think that would be enough, or do you need a separate CHANGELOG for some other reason?

Well, it's quickest and simplest to just take a look at CHANGELOG.md that most projects provide these days. Or HISTORY.rst.
Going into git commits is nowhere near the convenience of simply taking a look at single file (in Github), that lists whole history of project in human-readable form. git log contains bloat, bad/non-descriptive commit messages, etc. Plus if there are changes or upgrade instructions that you want to highlight, then you need a separate changelog.
Maintaining a changelog requires some effort (though not very much) but it's valuable to lazy/busy followers of the project.

Ok, but for all of that, it's probably still enough to rely on git tags.
Example:
https://github.com/purescript/purescript/releases
Don't expect me to keep the same quality and amount of details for my release notes, though:p
I have way less manpower than that other project
Do you think that would be enough?

Purescript changelog looks good. While I think it's mostly constructed of commit messages(?), there are also clarifications for some items (plus very user-friendly New Feature blocks).
Doing changelog in git tags is actually nice because tools like https://sibbell.com may include the changelog in the notification about new release.
So yeah, following purescript-style is definitively a good start. Just remember to point to https://github.com/berdario/pew/releases from your README.md (like purescript does).
(FYI: There is also https://github.com/vaab/gitchangelog that auto-builds release notes from git log. You may want to check it out.)

A changelog sounds like a good idea to me. I'm a fan of the format suggested by https://keepachangelog.com/en/1.0.0/


App Extension support

This adds workarounds for the code that was preventing React from compiling when linked against an iOS App Extension target.
Some iOS APIs are unavailable to App Extensions, and Xcode's static analysis will catch attempts to use methods that have been flagged as unavailable.
React currently uses two APIs that are off limits to extensions: [UIApplication sharedApplication] and [UIAlertView initWith ...].
This commit adds a helper function to RCTUtils.[hm] called RCTRunningInAppExtension(), which returns YES if, at runtime, it can be determined that we're running in an app extension (by checking whether the path to [NSBundle mainBundle] has the "appex" path extension).
It also adds a RCTSharedApplication() function, which will return nil if running in an App Extension. If running in an App, RCTSharedApplication() calls sharedApplication by calling performSelector: on the UIApplication class.  This passes the static analysis check, and, in my opinion, obeys the "spirit of the law" by only calling sharedApplication after we've determined that it's kosher to do so.
Existing calls to [UIApplication sharedApplication] have been replaced with calls to RCTSharedApplication(), with nil checks where appropriate.
The absence of UIAlertView is similarly handled with a runtime workaround.  If we're running in an App, the  RCTAlertView(NSString *title, NSString *message, id delegate, NSString *cancelButtonTitle, NSArray *otherButtonTitles) function uses NSInvocation to call the extension-unavailable initWithTitle:message:delegate:cancelButtonTitle:otherButtonTitles: selector.  In an Extension it just logs an error and returns nil.
As a result of these changes, React can be linked into a shared library that is then linked into both an App and an App Extension. When running in the App, all existing functionality will continue to work as before.  When running in the Extension, AlertIOS will be unavailable, as will APIs that depend on access to [UIApplication sharedApplication].
APIs that are unavailable to extensions are:

RCTActionSheetManager - uses sharedApplication to access the window of the app delegate
RCTImagePickerManager - uses sharedApplication to get the keyWindow property
RCTLinkingManager - uses sharedApplication to open URLs
RCTPushNotificationManager - uses sharedApplication to badge the app icon and register for permissions
RCTDevMenu - uses sharedApplication to get the keyWindow property
RCTPerfStats - uses sharedApplication to access the window of the app delegate

RCTAppState has been updated to return "extension" if running in an app extension.
This PR doesn't attempt to expose the NSExtensionContext to javascript, although a native module could be written to do so.
UIExplorer integration and unit tests all pass.  I have a basic proof of concept app, but it needs some cleanup; I'll push it to a repo soonish

OK, if you remove the extra error, this looks good to me.

@nicklockwood last commit removes the error.  Thanks for reviewing this!

Lovely, nice work @yusefnapora

@brentvatne thanks!

@yusefnapora - can you rebase this please so it can be a clean merge? Thanks!

@brentvatne I just force-pushed a rebase onto this existing branch; hope that's alright.   I encountered a small conflict in RCTPushNotificationManger.m, but it was straightforward.  Integration tests still pass.  Don't have time to poke at it more tonight, but if there's anything else you need let me know and I'll circle back tomorrow :)

Great, ping me when you've had a chance to circle back and verify, then I will check it out and update the tag @yusefnapora!

@brentvatne last commit fixes up a couple new invocations of [UIApplication sharedApplication] that I missed last night.
I added a brain-dead example project here: https://github.com/yusefnapora/ReactExtensionDemo/

cc @nicklockwood - this looks ready for review and is rebased against master so it's sync ready

@yusefnapora I notice you've not done anything to disable UIActionSheet - are action sheets available in extensions?

@nicklockwood I'm glad you brought that up, since I hadn't really thought it through.  I looked in the headers, and the designated initializer is marked as unavailable:
- (instancetype)initWithTitle:(NSString *)title delegate:(id<UIActionSheetDelegate>)delegate cancelButtonTitle:(NSString *)cancelButtonTitle destructiveButtonTitle:(NSString *)destructiveButtonTitle otherButtonTitles:(NSString *)otherButtonTitles, ...  NS_REQUIRES_NIL_TERMINATION NS_EXTENSION_UNAVAILABLE_IOS("Use UIAlertController instead.");

It didn't trigger the static analysis because  RCTActionSheetManager calls [[UIActionSheet alloc] init] instead.  But that means we should bail out and hit the failure callback in showActionSheetWithOptions..., since I assume trying to use it from an extension will trigger a runtime error.
I'll do that as soon as I've got time, probably tonight.

Although, the fact that the call to alloc/init slipped by the static analysis makes me think that we might not need to use NSInvocation for creating a UIAlertView.  We could just use alloc/init and call the setters, like RCTActionSheetManager is doing now.
I'm not sure, but the fact that the call to init is allowed makes me think that Apple is just blacklisting selectors.  Since init is everywhere they can't outlaw that, but there's nothing else using the initWithAMillionSpecificParameters selectors.

Hey @nicklockwood, this took me a little longer to get to than I thought, sorry about that.  I added a check to RCTActionSheetManager to bail out if running in an extension, and also changed RCTAlertView() to use [[UIAlertView alloc] init] which does pass the static analysis check.  That seems cleaner than using NSInvocation.
Also rebased onto latest master.
Let me know if anything else is blocking this, and I'll try to get to it soon.  Thanks :)

@yusefnapora - sorry for the delay, could you rebase this again so it would be a clean merge?

What is the status of App Extensions support for React Native? @brentvatne
@yusefnapora  can you rebase as requested? :) excited to try!

@brentvatne: I just rebased this & ran the UIExplorer integration tests.  Don't have much time today, but hopefully soon I can put up a decent example of using react in an extension.
@idibidiart: right now the support is pretty basic; you can link react into an extension and use it to render (so long as you create your own RCTRootView), but you're missing out on the Dev Menu, redbox, etc.
This PR also doesn't do anything to expose extension inputs to javascript, although I've got a proof-of-concept native module that can load images shared from the camera roll, via the extension.  Needs cleanup though & I don't know when I'll have time to work on it.

Looks good to me. I left some small remarks, if you could address those, I'll merge this in master.

@facebook-github-bot shipit


Verify semantic versions are incremented properly

Describe the bug
In theory, the semantic versions should parse the commit message and increment appropriately
To Reproduce
Steps to reproduce the behavior:

Merge a PR with the words "BREAKING CHANGE" or "feat" in the commit message
Check if the major/minor versions are incremented

Expected behavior
When a user merges a PR with the phrase BREAKING CHANGE, then the major version number should increment.
When a user merges a PR with the phrase feat, then the minor version number should increment.
Documentation exists for how to do this, either in readthedocs or another markdown file somewhere.
Additional context
This might be working and may be a matter of checking the commit messages when merging into main

I just merged a branch with "feat: "in the squashed commit and it bumped the minor version. Normal PRs without feat: seem to bump the patch version. So this does seem to be working (pending someone merging a breaking change to see if it bumps major version)

I'm going to go ahead and close this out


Cannot access WebAssembly module exports before synchronous instantiation

I get a problem when trying to access an uninitialized wasmModule. I used the example given here. I was attempting to perform a synchronous instantiation.

For async initialization you should defer log and wrap it to main for example:
javascript:
(async () => {
  const wasmModule = await loader.instantiate(module_wasm, {
    myConsole: {
      log(ptr) {
        let str = wasmModule.exports.__getString(ptr);
        output.value += str;
        console.log(str);
      }
    }
  });
  wasmModule.exports.main();
})();

assemblyscript:
@external("myConsole", "log")
declare function log(str: string): void;

export function main(): void {
  log("Hello world!");
}

Hi! Thanks for dropping the comment. I am getting an error that has to do with accessing the wasmModule variable from within the log function in the myConsole object (Node/JavaScript API - not within AssemblyScript). The same thing happens in both (a)synchronous cases. Here is the error signature:
UnhandledPromiseRejectionWarning: ReferenceError: Cannot access 'wasmModule' before initialization

Hmm, but it works in playground

The error appears to indicate that the module is being accessed before instantiation returns, i.e. code accessing the module runs before the await finished respectively then is called. This might also happen indirectly, for example if the module calls an import from WebAssembly during startup that in turn attempts to call back into WebAssembly from JS. If the latter is the case, --explicitStart may help (calling exports._start() manually after instantiation is complete).


TraceBounds: Add unit tests

Just for TraceBounds unit test. Not added cython version yet.

Current coverage is 57.89% (diff: 100%)

Merging #198 into master will not change coverage

@@             master       #198   diff @@
==========================================
  Files            17         17
  Lines           703        703
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            407        407
  Misses          296        296
  Partials          0          0

Powered by Codecov. Last update c144330...fde169c

@cdeepakroy @manthey Could you take a look at setup.py? Is this right way to add ext_modules?

@cdeepakroy Could you see this? Still got the import error.

@manthey Can you please take a look? Adding python setup.py build_Ext --inplace seems to produce this error.

@manthey Nevermind, Looks like it got resolved.

@cdeepakroy I put the test cases for isbf algorithm. Could you take a look into it?

@slee172 Few more comments. Rest LGTM!

@slee172 Did you put a print statement for each case and check if all print statements are being executed by your test?

It was tested at my local machine.


ReverseProxy.Direct.Sample sample coding issue

For reference, we are using Microsoft.ReverseProxy 1.0.0-preview.8.21065.1 in an empty ASP.NET Web Application using .NET 5
I follow this instructions to input the code, but it had error as below.

then I checked below commit history. I found the code is correct before commit. Why?

Those docs were updated to reflect API changes in Preview 9 which just shipped. Sorry for any confusion. Please try Preview 9 and let us know how it works for you.
https://github.com/microsoft/reverse-proxy/releases/tag/v1.0.0-preview9


Updated Contributing.md

Fixed

venv for linux
fork link
few typos

great @the-hoodieguy, for any further issue I rather suggest you raise an issue and then raise a PR so that we can track contributors!


ciao: create admin-openrc and demo-openrc

The playbooks were creating a ciaorc to authenticate the cli
with the ciao user.
The ciao user is reserved for ciao services authenticating into keystone
and should not be used in the cli to create instances.
This changes creates admin-openrc with credentials for the admin user
and demo-openrc with credentials for the demo user to be used by ciao-cli.
Fixes #46
Signed-off-by: Alberto Murillo<EMAIL_ADDRESS>

@tpepper please review


Avoid broken action URL in text notification mail

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)
Fix this by moving the action text before the action URL.

Replaced by https://github.com/symfony/symfony/pull/41738


[Auth] Remove deprecated MiqLdap in favor of external authentication

There is some work in the UI that can not be done until this is removed from the backend.
See: https://github.com/ManageIQ/manageiq-ui-classic/pull/7230#issuecomment-665033572


PT Assessment - Bug Fixes from testing (Rounding Assessment)

User Story
As a ministry, I need to calculate the awards accurately. This includes displaying the amounts correctly to the student so they know what to expect and to send the request to NSLSC to fund the student in the correct amount to prevent rejection. If the amounts are rounded at the wrong stage or not rounded to the nearest dollar it could result in a
Current Behaviour
$0.20 calculations round up to $1 in the front end
TC3831 (Astrid's Run)
SIMS
Student Name: Mightymouse EIGHTYONE
Application:<PHONE_NUMBER>
BCAG: SIMS: $588, Mass: $587
CSPT: SIMS: $1943, Mass: $1942

Camunda
ProcessInstance:<PHONE_NUMBER>565924
finalFederalAwardNetCSPTAmount: 1942.08
finalProvincialAwardNetBCAGAmount: 587.2033
Questions for Analysis

The display in the assessment seems to show a full round up to the nearest full number. Do we store the final amounts as 1942 / 587 respectively or do we keep the 1942.08 and 587.20?
Which value do we send on the ecert?

@Joshua-Lakusta I've added some questions to the bottom for analysis. If you have any other please add

New Ticket as a result of this ticket is #3539


Rename some titles to avoid confusion between request and response schemas

Cherry-picked from https://github.com/matrix-org/matrix-doc/pull/1186 (thanks @KitsuneRal!)
This PR documents existing behaviour and does not attempt to improve or change the situation.

@anoadragon453 ptal

yea, one my list of things to do is go through and apply the equivalent of a linter to the spec. I'll add quotes to my list.


Flutter tool process is killed when using use-application-binary option

When using the use-application-binary option with flutter run there is some code that kills the flutter tool running process.
For example:
flutter run --use-application-binary my_executable_path
When this code https://github.com/flutter/flutter/blob/3fedb8cb5ada929a697f29fb1e5783f9cfa76a15/packages/flutter_tools/lib/src/desktop.dart#L13 runs from https://github.com/flutter/flutter/blob/d6bd1c0584d761e622c9f9331581bcae3655f0c4/packages/flutter_tools/lib/src/linux/linux_device.dart#L90, any process that includes the string my_executable_path is killed, even the one that is running the flutter tool, since the string is passed as an argument.
My suggestion would be to exclude the current running process when looking for processes to kill using https://api.dartlang.org/stable/2.4.0/dart-io/pid.html

Sounds like a good idea


fix: crash on coming back from AuthFragment

Detail:

popBackstack() changed into navigating from from action pop backstack in navigation graph. This might be a problem from Navigation Component as both methods are pretty much the same but the latter one doesn't produce the crashes so this is just a workaround.
Please give an advice if a better solution can be made

Fixes: #1803
Screenshots for the change:

Please give an advice if a better solution can be made

I Have done the same for my last PR. The app was crashing on the welcome fragment.


Q Estimator : Visual heading support

Getting in support for external visual yaw in the new attitude_estimator_q is essential, since the attitude ekf has been mostly phased out.
Ideally, we would separately track heading states from the mag and vision, and have expose a parameter to do either of the following :
1 . Use both mag and vision. Vision would correct the estimate differentially, giving us a long term stable and true global heading. This also makes sure that visual tracking going bad isn't going to cause wild yawing in flight.
2. Disable the mag completely for indoor situations with magnetic interference, like the current approach.
I should be able to take this up soon-ish depending on testing capabilities.

:+1: for this. I was planning to advance to this soon or later, so let me know if you need something ;)

Long-since fixed.


Impossible to have rulesets in different terraform state for a single zone

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.5.1
on windows_amd64
+ provider registry.terraform.io/cloudflare/cloudflare v4.9.0
Affected resource(s)

cloudflare_ruleset

Terraform configuration files
resource "cloudflare_ruleset" "this" {
  zone_id = data.cloudflare_zone.this.id
  name    = "Append ${var.env} to path"
  kind    = "zone"
  phase   = "http_request_transform"

  rules {
    action = "rewrite"
    action_parameters {
      uri {
        path {
          expression = "concat(\"/${var.env}\",http.request.uri.path)"
        }
      }
    }
    description = "Append ${var.env} to path"
    expression  = "(http.host eq \"${var.env}.example.com\")"
    enabled     = true
  }
}

Link to debug output
https://gist.github.com/lewisn40/17371221f2204fa196c30260bdeff8f8
Panic output
No response
Expected output
We would like to be able to manage multiple rulesets in the same zone and for the same phase, but from different terraform states.
Actual output
Depending on the terraform description, it is either replacing the ruleset and all included rules with the latest version of the plan:
  # cloudflare_ruleset.this must be replaced
-/+ resource "cloudflare_ruleset" "this" {
      ...
      ~ name        = "Append dev to path" -> "Append qa to path" # forces replacement
      ...
    }

Plan: 1 to add, 0 to change, 1 to destroy.

or complaining about exisiting similar configuration
Error: failed to create ruleset "http_request_transform"
│
│   with cloudflare_ruleset.dev,
│   on main.tf line 21, in resource "cloudflare_ruleset" "dev":
│   21: resource "cloudflare_ruleset" "dev" {
│
│ A similar configuration with rules already exists and overwriting will have unintended consequences. If you are migrating from the Dashboard, you will need to first import the
│ existing rules using cf-terraforming. You can find details about how to do this at
│ https://developers.cloudflare.com/terraform/additional-configurations/ddos-managed-rulesets/#optional-delete-existing-rulesets-to-start-from-scratch```

### Steps to reproduce

1. Create a terraform resource with a dynamic ruleset based on some variables
2. Run and apply the plan with a first configuration `terraform plan -var env=dev`
3. Re-run the plan with a new configuration `terraform plan -var env=qa`

### Additional factoids

This scenario is overly simplified, but for backward compatibility we need to use a single zone for our dev and qa environments.  The fact that transform and origin rules must be managed in a single terraform state is a major blocker for us.

### References

I feel it might be related to https://github.com/cloudflare/terraform-provider-cloudflare/issues/2488

duplicate of #2423. you cannot manage individual rules outside of the ruleset itself.


Failure to match regexes on chunk boundaries

The block size for stream is probably 64KB or so, so a regex match on the order of 16 bytes should always work, since it's a lot smaller than the block size.
However, whether it works depends greatly on the location in the file. Test case:
const find = require("find-in")['default'];
const fs = require("fs");

let flen = 64 * 1024 * 3;
let rlen = 10;

let test = (i) => {
    let buf = Buffer.alloc(flen, ' ', 'utf8');
    buf.fill('B', i - 1, i + rlen + 1, 'utf8');
    buf.fill('A', i, i + rlen, 'utf8');
    fs.writeFileSync("test.txt", buf);
    find("test.txt", [/BA*B/], (err, report) => {
        let found = false;
        for (let r = 0; r < report.length; r++) {
            if (report[r].isFound) {
                found = true;
            }
        }
        if (!found) console.log(`${i}: missing`);
        if (i < flen - rlen - 10) {
            test(i + 1);
        }
    });
};

test(10);

In other words, for offsets in the file starting at 10 bytes and ending near 192KB, fill the file with  , then insert BAAAAAAAAAAB at the offset. Then search for it and report if it wasn't found.
That will churn for a while, then print:
65526: missing
65527: missing
65528: missing
65529: missing
65530: missing
65531: missing
65532: missing
65533: missing
65534: missing
65535: missing
65536: missing

I killed it at this point.
When the regex match overlaps the block boundary, it's not matched.
You can solve this by gluing subsequent pairs of blocks together. You'll still be able to match everything up to 64KB long. You'll be able to do this with a fixed amount of memory.

Hi @dhasenan  again
I changed the chunk size to 128 * 1024
and ran the same code
          if (!found) console.log(`${i}: missing`);
          else console.log(`${i}: found`);

Then test it
23559: found
23560: found
23561: found
23562: found
23563: found
23564: found
23565: found
23566: found
23567: found

passing the chunk size will fix this issue.

Passing in a larger chunk size reduces the number of chunk boundaries where I could miss a match. However, I don't know where in the file I might find a match, so I don't know what chunk size is right.
In order to fix this problem by specifying chunk sizes, I would need to:

Figure out how long a match I want to accept (say 1024 bytes)
Divide the length of the file by that twice number
Find two numbers whose least common multiple is greater than that ratio
Search with a chunk size based on the first number
Search again with a chunk size based on the second number

This ensures that any chunk boundary on the first pass is sufficiently far from a chunk boundary on the second pass that I can find every match. But then I have to search the whole file twice and do a bunch of awkward math.
Alternatively,  you could keep two chunks in memory, the current and the previous, join them together, and search through that union. So you read the first chunk, store it, read the second, and search through the first two as one string. Then you discard the first chunk, read the third, and search through both the second and third. And so forth.

This is definitely helping
I will work on it
This technique can help me also improving  fmod


Remote repo login to GitHub just hangs.

ADD ISSUE DESCRIPTION HERE
Version: 1.76.2
Commit: ee2b180d582a7f601fa6ecfdad8d9fd269ab1884
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/110.0
Embedder: vscode.dev

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Improve 'discoverability' for enabling preview pane in explorer via helper text in settings

Hello,
File Explorer Preview is not working.  My General screen does not even look the same.  But all the options turned on for File Explorer Preview to work.
There is also NO option in the ribbon to enable it.

First of all, thanks for including the screenshots. I see you don't have the Preview pane visible yet, you smarty-pants. Click the button top left in the Ribbon.
Second, just to be clear, these plug-ins are only for two specific filetypes.

Oh, Duh...   Feels like a Monday..
Thanks. Its working now 🙂
Robert

From: Jay<EMAIL_ADDRESS>Sent: Friday, May 29, 2020 9:26 AM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: rorsino<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] File Explorer Preview not working (#3858)
First of all, thanks for including the screenshots. I see you don't have the Preview pane visible yet, you smarty-pants. Click the button top left in the Ribbon.
Second, just to be clear, these plug-ins are only for two specific filetypes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F3858%23issuecomment-635971666&data=02|01||1c563f6a9af447ca36ed08d803d3f329|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637263556130825294&sdata=86AUzK3m6dC5FbWXN7tOeLAx8x25KT4gHpqKwg0Yq4E%3D&reserved=0, or unsubscribehttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACSYWQRRFGFDJQ4CTEVURPDRT6ZZXANCNFSM4NOBDSEA&data=02|01||1c563f6a9af447ca36ed08d803d3f329|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637263556130825294&sdata=rDAMjjilrSLM9txzLPaXznxN9MUybgvIs9xxnRlaOs0%3D&reserved=0.

@Jay-o-Way Missed that one to... lol

Maybe a bit of text, on the Settings page, would be nice. I think literally mentioning the name  would help a lot.

That is a really good idea Jay.
@rorsino, stuff like this is a great chance for us to improve.  https://github.com/microsoft/PowerToys/tree/master/src/modules/previewpane does make it pretty clear but i think having additional text in the settings app would be helpful too.

https://github.com/microsoft/PowerToys/tree/master/src/modules/previewpane does make it pretty clear but i think having additional text in the settings app would be helpful too.

Yeah, I like to think of this as a Help file/page, and the less you need it, the better 👍

@niels9001, i'm torn between quick helper text and linking to a helper doc.  I like the helper doc since we can embed an animated gif

@crutkas Is there a way to turn on the preview pane programatically? And is there something we want to do?
Or - can we detect that it's not turned on? If so additional helpertext can be shown.
Easy fix: a hyperlink button that is both a helper text and a link to the doc. Or some hybrid thingy.

Is there a way to turn on the preview pane programatically? And is there something we want to do? Or - can we detect that it's not turned on? If so additional helpertext can be shown.

According to https://winaero.com/enable-preview-pane-windows-10/ yes, in the registry. But I'd be careful to change things that aren't called for by a user.
C:\WINDOWS\system32\shell32.dll icon -256.

Since we've added icon previews, we've explicitly called out Preview Pane in the settings. Should we further include a tooltip saying preview pane can be toggled in file explorer with Alt + P?

@crutkas @niels9001

Since we've added icon previews, we've explicitly called out Preview Pane in the settings. Should we further include a tooltip saying preview pane can be toggled in file explorer with Alt + P?

You mean adding that shortcut to the infobar preview text we show on the settings page?

Can we do a recap of what the plan is here @dedavis6797?

@crutkas @niels9001 This was my idea:

I can open a PR for this unless either of you think there's a better approach.

There's more than one way to toggle the preview pane: the ribbon.
There's also the Explorer setting for showing previews in the first place.
Aside from that, I remember Explorer settings also have this:

[ ] Always show file icons, never previews

Should we mention that too, then? There's going to be a lot of infobars then...

Should we only show this new message if the preview pane is actually hidden

I wonder how difficult it would be to implement. Possibly worth pursuing in future iterations but isn't a high priority IMO.

There's more than one way to toggle the preview pane: the ribbon.

We don't need to provide every path. The goal of the info is just to provide exposure/raise awareness that it's something that may need to be turned on. Alt + P was just the most concise description I could come up with.
For icon previews, you raise a good point. I believe that setting is off by default so anyone this would impact is likely already aware of how to turn it on/off. If feedback comes in saying the thumbnail functionality is unclear similar to this issue for preview pane we can work on adding a concise description.

The was fixed in in 0.53.  Head over to https://aka.ms/installpowertoys to try it out