Doc Request: More examples for plugin authors

Hi, I struggle writing plugins for webpack. I tried to get help on Gitter and StackOverflow (see), but while many people use webpack there are just a few plugin authors and its hard to get starting. It would be nice to have some simple commented plugin templates for common use cases:

append/prepend files
replace/check content
use different files
rewrite URLs
...

Can you comment at the new doc site repo? That's the right place to resolve this.


error

Getting this error

Getting this error

Go to Google Cloud, enable the Google Analytics Reporting API, credentials > keys > Add Key > Create New Key > JSON, add this to the auto-gpt and rename it firebase.json.

i got it fixed. i was doing the credentials wrong. So for anyone else that got stuck. Here is what you need to put there.


Providing action-creators through context

Hi. I would like to make my Component files cleaner by getting rid of imports.
Actioncreators and actions could be provided using context.
Is there a technical reason why react-redux does not implement action creator providing through context?
This was ~ what is was thinking:
... index.jsx
const ActionProvider = createActionProvider({addTodo, ...etc});

const Root = () => (
    <Provider store={store}>
         <ActionProvider>
             <Todos/>
         </ActionProvider>
    </Provider>
)

... Todos.jsx
const Todos = (props, context) => [
    <AddTodo onSubmit={context.addTodo}/>,
   {props.todos.map(todo => <Todo todo={todo} ... />)}
]
/*define actions types in contexTypes*/
Todos.contextTypes = {
  addTodo: func,
  ...
}
export default connect(...)(...);

This would also simplify the logic that has to be performed by the Component created by 'connect'

A few reasons.  One is that that simply isn't part of the original API design.  Another is that connect is about being explicit, and only intended to pass values directly to the wrapped component.  After all, the entire state isn't just passed to every deeply nested component, or even every connected component - only the values and functions you return from your own mapState and mapDispatch functions.
Beyond that, the React team advises that context be used sparingly, and when it is used, it should be hidden from app code.  A feature like this would involve a much tighter tie to context, which we're trying to avoid.  (In fact, the React team just introduced a proposed new API that will eventually replace the existing context API.)

Ok. It will be interesting to see how context API will change.
I see the the point, of in being explicit, but I still think that how mapDispatchToProps is defined separately on every single Component, is gallons of explicit:y.


[Documentation] Doc comments for Swagger annotations are missing

These are required for the generated docs.

This is referring to [1]
[1] https://ballerinalang.org/docs/api/0.95.0/ballerina.net.http.swagger.html

This is done.


Change website name to hash.bin

hey @QueshAnmak can you assign me the task?

Hi @QueshAnmak I want to work under this issue as a GSSoC'22 contributor. Can you please assign it to me?


[4.0] Cannot run project or scenes

Godot version:
4.0.dev a17fba3f2
OS/device including version:
Windows 10 1903
Issue description:
When running scene, window opens and remains white. After 1-2 seconds closes immediately with below printed to log:
platform\windows\os_windows.cpp:494 - Condition "!process_map->has(p_pid)" is true. Returning: FAILED
Steps to reproduce:
Run a scene
Minimal reproduction project:
Blank

Full log:
Godot Engine v4.0.dev.custom_build.f97280a01 - https://godotengine.org
ERROR: Can't find layer: VK_LAYER_KHRONOS_validation
   at: VulkanContext::_check_layers (drivers\vulkan\vulkan_context.cpp:157) - Can't find layer: VK_LAYER_KHRONOS_validation
ERROR: Can't find layer: VK_LAYER_LUNARG_standard_validation
   at: VulkanContext::_check_layers (drivers\vulkan\vulkan_context.cpp:157) - Can't find layer: VK_LAYER_LUNARG_standard_validation
ERROR: Can't find layer: VK_LAYER_GOOGLE_threading
   at: VulkanContext::_check_layers (drivers\vulkan\vulkan_context.cpp:157) - Can't find layer: VK_LAYER_GOOGLE_threading
WARNING: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
	ReadDataFilesInRegistry: Registry lookup failed to get layer manifest files.
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 273561136
   at: VulkanContext::_debug_messenger_callback (drivers\vulkan\vulkan_context.cpp:133) - GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
	ReadDataFilesInRegistry: Registry lookup failed to get layer manifest files.
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 273561136

ERROR: Condition "err" is true. Returning: err
   at: GDScript::load_source_code (modules\gdscript\gdscript.cpp:825) - Condition "err" is true. Returning: err
ERROR: res://Node2D.tscn:24 - Parse Error: Can't load cached sub-resource: res://Node2D.tscn::1
   at: ResourceLoaderText::_parse_node_tag (scene\resources\resource_format_text.cpp:282) - res://Node2D.tscn:24 - Parse Error: Can't load cached sub-resource: res://Node2D.tscn::1
ERROR: Failed loading resource: res://Node2D.tscn.
   at: ResourceLoader::_load (core\io\resource_loader.cpp:198) - Condition "found" is true. Returning: RES()
ERROR: Failed loading scene: res://Node2D.tscn
   at: Main::start (main\main.cpp:2238) - Condition "!scene" is true. Returning: false
ERROR: 1 RID allocations of type 'class SpaceBullet *' were leaked at exit.
ERROR: 1 RID allocations of type 'class Area2DSW *' were leaked at exit.
ERROR: 1 RID allocations of type 'class Space2DSW *' were leaked at exit.
ERROR: 1 shaders of type VolumetricFogShaderRD were never freed
   at: ShaderRD::~ShaderRD (servers\rendering\rasterizer_rd\shader_rd.cpp:470) - 1 shaders of type VolumetricFogShaderRD were never freed
ERROR: 2 RID allocations of type 'struct RasterizerSceneRD::ShadowAtlas' were leaked at exit.
ERROR: 1 RID allocations of type 'struct RasterizerSceneRD::ReflectionAtlas' were leaked at exit.
ERROR: 1 RID allocations of type 'struct RasterizerStorageRD::RenderTarget' were leaked at exit.
ERROR: 2 RID allocations of type 'struct RasterizerStorageRD::Texture' were leaked at exit.
ERROR: 1 RID allocations of type 'struct RenderingServerCanvas::Canvas *' were leaked at exit.
ERROR: 1 RID allocations of type 'struct RenderingServerViewport::Viewport *' were leaked at exit.
ERROR: 1 RID allocations of type 'struct RenderingServerScene::Scenario *' were leaked at exit.
WARNING: 6 RIDs of type 'Texture' were leaked.
   at: RenderingDeviceVulkan::finalize (drivers\vulkan\rendering_device_vulkan.cpp:7486) - 6 RIDs of type 'Texture' were leaked.
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
   at: ObjectDB::cleanup (core\object.cpp:1948) - ObjectDB instances leaked at exit (run with --verbose for details).

Looks like I just needed to create a new project. The godot 4.0 testing project was quite old, some formatting must have changed.


fix: meilisearch disk space grow every day

Describe the bug
Discovered with monitoring : https://discord.com/channels/248936708379246593/1023378285935198208/1051908954583748638
The PVC of meilisearch seams grow up, incrementally and reach the alert point of 75%.
Need to be investivate quick due to the fact of : if we increase the pvc size, we cannot reduce it after.
To Reproduce
REQUIRED AN ADMIN ACCESS

Watch the pvc size on https://dashboards.s42.app/d/lexkUXnVk/panels-library?orgId=1&from=now-30d&to=now&var-pvc=meilisearch-data&var-namespace=production
Watch the file system on kubernetes cluster directly

Expected behavior
The Database size with 26,846 users is ~ 70 Mb, the databse of meilisearch must be close of the data size.
Relevant log output
No response
Version of software
v0.20
Environment
Live (https://s42.app)
Additional context

Code of Conduct

[X] I agree to follow this project's Code of Conduct

After investigation on pod directly :
700Mb are used by tasks database. Need to found a solution to auto clean tasks.


PGPainless should not emit an uncompressed compressed data packet

Even though that is a MUST implement, some implementations don't, and this creates interoperability problems.
See:

https://tests.sequoia-pgp.org/#Encrypt-Decrypt_roundtrip_with_key__Bob_
https://tests.sequoia-pgp.org/#Compression_Algorithm_support

This is about the "encryption phase" right?
So if the recipients key does not support any compression, PGPainless should not wrap the LiteralDataPacket in a CompressedDataPacket with algorithms NULL, but instead directly place the LiteralDataPacket in the EncryptedDataPacket, right?

Yes.


Some version updates and no more 2.10

Codecov Report

Merging #24 into master will increase coverage by 15.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #24       +/-   ##
===========================================
+ Coverage   82.57%   98.47%   +15.89%
===========================================
  Files           9        8        -1
  Lines         132      131        -1
===========================================
+ Hits          109      129       +20
+ Misses         23        2       -21

Impacted Files
Coverage Δ

...n/scala/io/circe/benchmarks/CirceDefinitions.scala
100% <ø> (+100%)
:arrow_up:

...in/scala/io/circe/benchmarks/PlayDefinitions.scala
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08fa71...ca00db8. Read the comment docs.


hotkeys: Make "n" key cycle to PMs as well as streams.

We should make the popular "n" key work with PM conversations as well as streams.
The mode of operation should be this:

if you're in streams, keep cycling in streams
if you're in PMs, keep cycling in PMs
if you run out of unread threads in streams/PMs, switch to PMs/streams respectively

A related thing to fix, which we should probably split out an issue for if it's not easy to piggyback on to this change, is that if you are narrowed to a muted stream, you should cycle topics in that stream while you have unread topics there.  (But for all other situations, ignore muted topics.)

I am currently fixing the muted-stream isssue, but adding in PMs is a bigger fix that's still open.

Another option here would be to add another shortcut, p, that just cycles PMs.
Not sure which I prefer (having an ability to jump between PMs and streams, that p would provide, or just having to think about 1 keyboard shortcut n.)

@zulipbot claim
I'm starting with the other-shortcut approach (p or some other key), mostly because it's easier, but also because I think it might make more sense for users to want that level of control.

:+1:

see #8333

We have the "p" key now. Closing.


Support near-api-js ^1.1.0

Is your feature request related to a problem? Please describe.
I get a build warning, because the near-api-js version I'm using which is a peer dependency of wallet-selector is too high:
[2/2] Regenerating lockfile and installing missing dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "@near-wallet-selector/ledger ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>
I want to use a recent version of near-api-js and wallet-selector.
Describe the solution you'd like
I would like to be able to use near-api-js version ^1.1.0 along with wallet-selector.
Acceptance criteria
The packages core, ledger, wallet-utils and my-near-wallet need to work with version ^1.1.0 of near-api-js
...
 "peerDependencies": {
    "near-api-js": "^1.1.0"
  }

Hey, @felixniemeyer thank you for raising this issue.
You can install any version of near-api-js equal to or higher than ^0.44.2 the above log seems to be just a warning you can ignore it for now. We have been testing the wallet selector with the latest versions and it works just fine.
We will soon update the range of near-api-js in this project.
Will close the issue for now, feel free to open it if there are any errors with the version you're using.


close is a reserved word in go, rename close variables to closeFunc

golangci-lint tripped over close being a reserved word, so this PR renames close to closeFunc, to avoid using reserved words.

close is a pre-declared method, not a reserved word. It's totally fine to have locally defined variables that shadow those. See recently added ones like "min" and "max"
Closing this PR since I don't want to take patches for arbitrary churn.

Thank you no problem.


ESLint configuration

That'd be good to have ESLint configured for the project, so we can have a pattern for the codebase and help more new contributors.
Any thoughts on famous JavaScript/React style guides to be followed? (like Airbnb or Standard)

I always see people using AirBnb settings so I think it might be the best option since many people are used to these settings. But let's wait for some more opinions

Hello @luizbaldi can i take this up ?

Hello @luizbaldi can i take this up ?

Of course! Feel free to ping us on the discord channel if you need anything :)

I am not sure of what is meant by discord channel. Shall we go with airbnb initially ? Should I raise a pull request to master branch with my changes ?

@vnallamhawk yeah lets do AirBnb, and you can do pull request to master too 🤟🏻

closed in #52


Add run-tests.py

Feature description
A request to add the run-tests.py script for developers who are not using nox to run the tests.
Motivation
No response
Possible implementation
No response
Additional context
No response

Hi Nicola, here's a solution to the testing suite without the nox environment:
pytest --unit or python -m pytest --unit
For parallelised runs, pytest-xdist is available (and recommended):
pip instal pytest-xdist
pytest -n auto --unit

This will spam and automated number of workers and run the testing suite. auto can be replace with an exact number of workers. More information on running the testing suite has been added to the contributing.md on this branch.


Add path_provider

getApplicationDocumentsDirectory() requires package path_provider

You can use another solution to get a directory. On desktops you can even use the current directory

path_provider was included in the quickstart tutorial so I thought it would be appropriate here as well.


Reacting to media play button doesn't work when Sweyer is not running

Steps to reproduce

Make sure Sweyer is not running (force close the app).
Trigger a KEYCODE_MEDIA_PLAY event or KEYCODE_MEDIA_PLAY_PAUSE event, e.g. press the play button on a connected headset.
Observe the logcat logs.

What did you expect?
The app should be able to start from the audio_service and start playing audio.
What happened instead?
The app does start in the background, but never plays audio. This is because the following error is thrown:

Error
I/System.out: ### onAttachedToEngine
I/System.out: ### 1 client handlers
I/System.out: ### new AudioHandlerInterface
I/System.out: ### connect
D/MediaBrowserCompat: Connecting to a MediaBrowserService.
I/System.out: ### connect returned
I/System.out: ### onAttachedToEngine completed
D/DeviceInfoPlugin: Use TaskQueues.
I/System.out: flutterEngine warmed up
I/System.out: ### onStartCommand
I/System.out: ### onMediaButtonEvent: KeyEvent { action=ACTION_DOWN, keyCode=KEYCODE_MEDIA_PLAY_PAUSE, scanCode=0, metaState=0, flags=0x0, repeatCount=0, eventTime=0, downTime=0, deviceId=-1, source=0x0, displayId=0 }
2022-06-26 17:39:10.733 6154-6154/com.nt4f04und.sweyer I/System.out: ### listener = com.ryanheise.audioservice.AudioServicePlugin$AudioHandlerInterface@8194acc
I/System.out: ### calling onClick
I/System.out: ### sending click map: {button=0}
I/System.out: ### called onClick
I/System.out: ### onGetRoot. isRecentRequest=false
I/System.out: ### onConnected
I/System.out: ### registered mediaController callback
I/System.out: ### onConnected returned
I/flutter: The Dart VM service is listening on http://<IP_ADDRESS>:45025/VEcJ_HFwVvI=/
I/flutter: ----------------FIREBASE CRASHLYTICS----------------
I/flutter: MissingPluginException(No implementation found for method retrieveSongs on channel content_channel)
I/flutter: #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:165:7)
    <asynchronous suspension>
    #1      MethodChannel.invokeListMethod (package:flutter/src/services/platform_channel.dart:353:35)
    <asynchronous suspension>
    #2      ContentChannel.retrieveSongs (package:sweyer/logic/player/content_channel.dart:113:18)
    <asynchronous suspension>
    #3      ContentControl.refetch.<anonymous closure> (package:sweyer/logic/player/content.dart:444:33)
    <asynchronous suspension>
    #4      ContentControl.refetch (package:sweyer/logic/player/content.dart:441:5)
    <asynchronous suspension>
    #5      Future.wait.<anonymous closure> (dart:async/future.dart:521:21)
    <asynchronous suspension>
    #6      Future.any.onValue (dart:async/future.dart:611:5)
    <asynchronous suspension>

The reason for the error is that ContentChannel initialization is triggered by MainActivity.onCreate, but when the app is not running and we are starting via the audio service, no MainActivity is ever created and therefore the MethodChannel is never registered.
The only workaround I found (suggested by https://github.com/ryanheise/audio_service/issues/399#issuecomment-657326724) is to extract the method channel into a separate plugin and use the plugin registration system to initialize the method channel under all conditions.
@nt4f04uNd do you have a better idea how to approach this?
Sweyer version
Latest on the 1.0.8 branch; c6386e62fcae56165233ab1c09e0d7f024075cc2
Android version
No response

I can confirm that extracting the content channel and pretty much all of our Java code into a plugin solves the issue.


Does tf.keras.metrics.AUC work on multi-class problems?

Hi,
I have a multi-class classification problem and I want to measure AUC on training and test data.
tf.keras has implemented AUC metric (tf.keras.metrics.AUC), but I'm not be able to see whether this metric could safely be used in multi-class problems. Even, the example "Classification on imbalanced data" on the official Web page is dedicated to a binary classification problem.
I have implemented a CNN model that predicts six classes, having a softmax layer that gives the probabilities of all the classes. I used this metric as follows
self.model.compile(loss='categorical_crossentropy',
optimizer=Adam(hp.get("learning_rate")),
metrics=['accuracy', AUC()]),
and the code was executed without any problem. However, sometimes I see some results that are quite strange for me. For example, the model reported an accuracy of 0.78333336 and AUC equal to 0.97327775, Is this possible? Can a model have a low accuracy and an AUC so high?
I wonder that, although the code does not give any error, the AUC metric is computing wrong.
Somebody may confirm me whether or not this metrics support multi-class classification problems?
Thanks in advance,
Oscar

Hi @ogreyesp! We're tracking the request for multi-class AUC in https://github.com/tensorflow/addons/issues/265

i have a similar question: do tf.keras.metrics.Precision() and tf.keras.metrics.Recall() support mutliclass classification?  I do pixelwise semantic segmentation, so I was wondering if the values would be averaged pixelwise or categorywise ?
Or do tf.keras.metrics.Precision() / tf.keras.metrics.Recall() only support binary classification? If so, which class is the one that is used for calculating recall and precision?

I have the similar behavior using AUC metric.
Also, do you know how to load_model when you trained using AUC metrc?? I cannot do that.


IIITBH-IITP

https://github.com/WING-NUS/scisumm-corpus/blob/master/2018-evaluation-script/program/task1_eval.py replace "annv3.csv" to ".csv"

if anyone is facing WordNet error
/scisumm-corpus/2018-evaluation-script/program/rouge/data$ rm WordNet-2.0.exc.db

/scisumm-corpus/2018-evaluation-script/program/rouge/data$ ./WordNet-2.0-Exceptions/buildExeptionDB.pl ./WordNet-2.0-Exceptions ./smart_common_words.txt ./WordNet-2.0.exc.db

Still cumulative Task1 B results are not present in scores.txt

According to the script program/run.sh, results for the overall tasks should be present in ./input/res/Task1/, however, there is no such folder generated currently. Am I right in assuming that this would contain the final scores used for evaluation?

@dennlinger results(here I mean scores) will be present in the output directory. Whereas  ./input/res/Task1/ contains our submitted CSV files

No, .input/ref/ contains the input files. However, if you look at line 3 in the aforementioned script, it states input/res/, which is different (s, not f). Further, script task1_eval.py, which is called indirectly by the same script, then uses this specific input parameter, to write the overall evaluation of the task (see ll. 489-501 in script task1_eval.py). According to my understanding, the written values consider the results across all files, instead of the currently generated output over one file only.

For a single run, these two results are written in score.txt

and

which of these should I report system description paper?

@dennlinger @Saichethan  Thanks for this discussion! I had made he change in rename.py from .txt to .csv. I won't merge this PR to an evaluation script to be fair to all participants.

@dennlinger It is very unlikely that we have errors in how scores are computed since the script has not been changed since 2018. So please double check and confirm if you are reporting bug (as a separate github issue). Note that we check the system output files against multiple reference / ground truth files for each reference document (3 annotators).

@cmkumar87 @dennlinger  My intentions are just to cross-check if I am doing the evaluation correctly...

@Saichethan @dennlinger   Is this change required to run the script?
https://github.com/WING-NUS/scisumm-corpus/blob/master/2018-evaluation-script/program/task1_eval.py replace "annv3.csv" to ".csv"
If so I will make it to the repo; please run the script from the repo and not the modified version from your fork.
I am not merging this PR for fairness to other contestants since this is from a participant. thanks!

@Saichethan   Your PR is not going into your evaluation folder but to 2018-evaluation-scripts. I am not able to merge any pull request outside of the your evaluation folder. Also from the PR I am not able to find scores for all the runs in your submission. Please advise and raise a new PR

@cmkumar87 all my runs scores are in https://github.com/Saichethan/scisumm-corpus/tree/master/2018-evaluation-script/setup. Should I add this to the CLSciSumm_2020_Evaluation folder? are there any naming conventions bcz 43-IIITBH-IITP folder is already present

please check once now, if the updated version is in alignment with your requirements?


Labels getting clipped in tile mode (node version)

I mentioned this issue in https://github.com/maplibre/maplibre-gl-native/issues/279 , but did not want to pollute that thread with an unrelated problem.
In my testing of the node version of maplibre-gl-native in my branch of tileserver-gl I have noticed labels getting clipped more than in the mapbox-gl-native version.
For example, in the maplibre-gl-native version it is consistently cutting off labels all over the place like this

Where in the maptiler version using mapbox-gl-native v5.02, does not have this issue

Looking at several similar threads I found these related mapbox issues
https://github.com/mapbox/mapbox-gl-native/issues/15805
https://github.com/mapbox/mapbox-gl-native/issues/14011
https://github.com/mapbox/mapbox-gl-native/pull/15880
The first article in this list mentions this was improved in v5.0.2, which I did find the change they mentioned here https://github.com/mapbox/mapbox-gl-native/commit/d500b67d4a73ccbfbc59b78a3277538b01d1cb5e. the padding was increased when in tile mode to help the labels to help with the trimming (a change which still exists, slightly rewritten). Also, in tileserver-gl they added the code to use tile mode here https://github.com/maptiler/tileserver-gl/commit/5048388d1fbfce3f983e6ee0338bafaa90e947ce
Looking though the related code in https://github.com/maplibre/maplibre-gl-native/blob/main/src/mbgl/text/collision_index.cpp#L26-L50 it seems like the changes that added padding in tile mode are still there and looking in my tileserver-gl code the tile mode option is still set ( https://github.com/acalcutt/tileserver-gl/blob/main/src/serve_rendered.js#L574 )
From this, to me, it seems like it should be showing the labels correct like in the second screenshot, but for some reason it is not.
One idea I had is maybe it is ignoring the tile mode switch? I'm guessing that would be this code in the node binding code?
Does anyone have any other idea or tips that could help? I am told there is no issue with labels in the android version, which Is why I was thinking something with the node mode switch.

Thanks for reporting this @acalcutt Is there a way to reproduce this cropping problem with the linux native renderer and the demotiles?

Is the any information on using the linux native renderer? like at least switches mbgl-render needs?
Basically I would want to try an recreate this view, where it trims "United States"
https://tiles.wifidb.net/styles/demotiles/?raster#6/39.470/-98.701

I tried various zoom levels, like
xvfb-run -a ./mbgl-render -z 6 -y 39.436 -x -101 --style style.json --output out6.png
but I wasn't able to see any clipping. I always assumed this was where the label was at the edge of the tile. so I think to test this you would need two tiles that are side by side where the label gets clipped off. also, I'm not sure this mbgl-render can do tile mode, where it overdraws a bit to help with the labels.

I've made a application to test this issue here
https://github.com/acalcutt/maplibre-label-clipping-test
( Note, this is made to be run in node 10 to be compatible with the mapbox-gl-native release )
Test 1 - With maplibre-gl-native
git clone https://github.com/acalcutt/maplibre-label-clipping-test.git
cd maplibre-label-clipping-test
npm i
xvfb-run -a node index.js
2 images are generate, which look like this

Test 2 - With mapbox-gl-native
Edit index.js.
uncomment line 8 (let mbgl = require('@mapbox/mapbox-gl-native');)
comment line 9 (//let mbgl = require('@acalcutt/maplibre-gl-native');)
xvfb-run -a node index.js
2 images are generate, which look like this

Compare the maplibre version to the mapbox version. In the maplinre version, the "North" in "North Adams", which is right on the edge, is missing. However in the mapbox version, it is there as expected.

I also tried with
wget https://raw.githubusercontent.com/maplibre/demotiles/gh-pages/style.json
./build/bin/mbgl-render --style style.json --output out.png --zoom 6 --lat 39.470 --lon -103

but always got correctly clipped labels...

Hm interesting, is the diff between mapbox-gl-native and maplibre-gl-native large? When was their last common commit?

The diff is pretty large between the mapbox last version.
My assumption right now is this is related to the mode switch. If I go remove this line (mode: 'tile',) https://github.com/acalcutt/maplibre-label-clipping-test/

blob/main/index.js#L147 , with the mapbox version, it produces the same output as maplibre.
The code for tile mode has been refactored a bit, since mapbox 5.0.2...maybe there was some mistake with that
https://github.com/maplibre/maplibre-gl-native/blob/main/src/mbgl/text/collision_index.cpp#L26-L50

I've done a few thing to try and track this down...non successful so far.
1.) I tried setting viewportPaddingDefault  to 1024, like is supposed to happen in tile mode to see if maybe the tile mode switch was not working. However even at 1024 the label clipping still occurred.
2.) I tried reverting back to the first maplibre node release in  cfcbc62fadd72224aac242c516a5a86510a1d102 , but the issue seemed to be happening in that release also
3.) I tried going back really far to a mapboc release that mentioned tile mode b84449e35fd38788fbbbe9c67e338e8317cd7150 , but unfortunately I couldn't get it to build. I used the instruction for that release, but I assume in needs an older GCC since I was getting syntax errors.

Maybe you can install it from a local folder https://stackoverflow.com/questions/8088795/installing-a-local-module-using-npm

Have you made any progress @acalcutt ? I'm seeing a fair amount of clipping and overlaps.

Unfortunately I haven't figured anything else. I haven't had much time to look though since my real job has kept me really busy this month.
My last test leads me to believe maybe it isn't tile mode padding like I was originally thinking.

I updated<EMAIL_ADDRESS>to include these render fixes. unfortunately it doesn't look like they fixed the issue here.
I was hopeful since the fixes were in the same files... but somewhat expected since I had tried to revert https://github.com/maplibre/maplibre-gl-native/pull/270 before and it didn't fix this issue.

Maybe also look in the ignored tests.
If I run
cmake .
For some reason in platform/node/src/node_map.cpp , the map "withMapMode" was hardcoded to "mbgl::MapMode::Static" and not using the "mode" variable
L1424 and L645

It worked! So far I have tested in my tileserver-gl  for and in the label clipping test above and it seems like it is fixed
This should be fixed in my npm package
"@acalcutt/maplibre-gl-native": "5.0.25
This is what the two images from my label test look like now, no longer clipping labels

Fixed by #415

@wipfli unfortunately I am not aware of how to run the render tests for node, or if there are any.

@wipfli
To do the basic tests the build does in linux, it would be something like ubuntu 20.04
install prereqs from https://github.com/acalcutt/maplibre-gl-native/tree/main/platform/linux
git clone --recurse-submodules https://github.com/maplibre/maplibre-gl-native.git
npm ci --ignore-scripts
cmake . -B build -G Ninja -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
cmake --build build -j $(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null)
xvfb-run --auto-servernum npm test

however, looking in the package.json there are some other tests that didn't seem to work for me on my test vm
    "test-memory": "node --expose-gc platform/node/test/memory.test.js",
    "test-expressions": "node -r esm platform/node/test/expression.test.js",
    "test-render": "node -r esm platform/node/test/render.test.js",
    "test-query": "node -r esm platform/node/test/query.test.js",

Ah interesting. The render test fixtures are indeed in the maplibre-gl-js submodule. Maybe even the test harness from GL JS is used for node?


Fix bike-rental-app image

Description

It seems like the old manifest was deleted from quay.io. It probably didn't have a tag referring to it. This updates to the latest tagged image, and shouldn't get untagged.
How Has This Been Tested?

I pointed my config to the source branch of this PR, and I can see that the image is rolled out successfully and is healthy:

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/lgtm


Support for windows arm64 cmake?

Hi @lukka,
Is there a chance that the windows arm64 cmake packages are added to the catalog?
For example, https://github.com/Kitware/CMake/releases/tag/v3.28.6 has https://github.com/Kitware/CMake/releases/download/v3.28.6/cmake-3.28.6-windows-arm64.zip
Thanks,
Hiroshi

@hjyamauchi please test this out: https://github.com/lukka/get-cmake/pull/166
I haven't tested it at all, feel free also to create another PR based on that one, or just let me know what does not work.

@lukka That worked for me! It'd be great if you can merge it.

@hjyamauchi, could you provide some evidence to show how it worked? Specifically, I'd like to confirm that the ARM64 executable was run instead of the x64 version. Verifying this would be easier with a hosted ARM64 agent, but since there isn't one available (as far as I know), I'd appreciate seeing some log excerpts or other details before we proceed with the change. Thanks!

@lukka I tested it in an internal CI running on a self-hosted win/arm64 runner that needs to override the version of cmake due to a cmake bug based on my fork of get-cmake with https://github.com/lukka/get-cmake/pull/166 patched in. I know this is working because if it doesn't override, the cmake bug would cause a build failure later, which it didn't.
Here's what the workflow step looks like:
      - uses: hjyamauchi/get-cmake@main
        with:
          cmakeVersion: 3.28.6

Here's the raw log:
Run hjyamauchi/get-cmake@main
useCloudCache:true
useLocalCache:false
user defined cmake version:3.28.6
user defined ninja version:
cmake version:3.28.6
ninja version:latest
Computing cache key from the downloads' URLs
Restoring from GitHub cloud cache using key '858378870' into 'D:\r\_work\_temp\858378870'
  Cache Size: ~36 MB (38[1](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:1)45323 B)
  "C:\Program Files\Git\usr\bin\tar.exe" -xf D:/r/_work/_temp/ff8d29ca-ba31-4e3a-889c-350be3b0b252/cache.tgz -P -C D:/r/_work/swift-build/swift-build --force-local -z
  Received 38145323 of 38145323 (100.0%), 36.2 MBs/sec
  Cache restored successfully
  Cloud cache hit.
Add CMake and Ninja to PATH
  CMake path: 'D:\r\_work\_temp\8[58](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:59)378870\cmake-3.28.6-windows-arm64\bin\'
  Ninja path: 'D:\r\_work\_temp\858378870'
Validating the installed CMake and Ninja
  CMake actual path is: 'D:\r\_work\_temp\858378870\cmake-3.28.6-windows-arm[64](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:66)\bin\cmake.exe'
  Ninja actual path is: 'D:\r\_work\_temp\858378870\ninja.exe'

get-cmake action execution succeeded

@hjyamauchi ok, could you please test get-cmake@main. If that is working, then I'll release it.

@lukka It worked fine in the same setup.
      - uses: lukka/get-cmake@main
        with:
          cmakeVersion: 3.28.6

Run lukka/get-cmake@main
useCloudCache:true
useLocalCache:false
user defined cmake version:3.28.6
user defined ninja version:
cmake version:3.28.6
ninja version:latest
Computing cache key from the downloads' URLs
Restoring from GitHub cloud cache using key '858378870' into 'D:\r\_work\_temp\858378870'
  Cache Size: ~36 MB (38[1](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:1)44563 B)
  "C:\Program Files\Git\usr\bin\tar.exe" -xf D:/r/_work/_temp/3eccf67b-790a-4b7c-9[54](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:55)e-5a8bcb2464d2/cache.tgz -P -C D:/r/_work/swift-build/swift-build --force-local -z
  Received 38144[56](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:57)3 of 38144563 (100.0%), 35.8 MBs/sec
  Cache restored successfully
  Cloud cache hit.
Add CMake and Ninja to PATH
  CMake path: 'D:\r\_work\_temp\8[58](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:59)378870\cmake-3.28.6-windows-arm64\bin\'
  Ninja path: 'D:\r\_work\_temp\858378870'
Validating the installed CMake and Ninja
  CMake actual path is: 'D:\r\_work\_temp\858378870\cmake-3.28.6-windows-arm[64](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:66)\bin\cmake.exe'
  Ninja actual path is: 'D:\r\_work\_temp\858378870\ninja.exe'

get-cmake action execution succeeded

@hjyamauchi thank you for the support and suggestion!
Released with https://github.com/lukka/get-cmake/releases/tag/fix-issue-165.

@lukka Thank you for adding this support. Highly appreciate!


use complain in setuphost function instead of exit

make a failure more prominent by using the complain function on failure

:+1:

+1


Has anyone able to successfully run it on MacOS?

Issue
sp1up: installing sp1 (version nightly, tag nightly)
sp1up: downloading latest cargo-prove
curl: (7) Failed to connect to pub-e4d9616fb885415597ff4c4d2b476ffb.r2.dev port 443: Connection refused
sp1up: command failed: download https://pub-e4d9616fb885415597ff4c4d2b476ffb.r2.dev/cargo_prove_nightly_darwin_amd64.tar.gz
env
macOS ventura 13.0.1
steps taken
tried with both option for installation but no luck.
tried brew update, reinstall<EMAIL_ADDRESS>rebooting etc

Thanks for the issue! Sorry you ran into that, it's definitely something we need to fix. In the meantime, did you try brew install openssl@3 + the manual installation?

Hi chowdhurry, when you open the download link what happens? I have seen this issue in the past without someone who's malware preventer stopped them from accessing the download URL.

Pretty sure I had this happen on both Mac OS and Linux.
I believe the issue was simply that I had not sourced my shell  after installing via cURL, but before running sp1up.
In my case, this meant running 'source /Users/furnic/.config/fish/config.fish' as directed.

FWIW I have it working on MacOS, latest MacBook Pro (M3).
Have the full Fibonacci example working, proof generation and everything.

Should be fixed now.


Merge agent iptables rules

Merges the change that's on the release-v0.6 branch to master.

What is the status of this? It's a pretty old PR, has this been superseded by something or is this still about to be merged?

I have no further comment, I gave my feedback. If there's nothing else then we can merge this.

This branch has conflicts that must be resolved. Will do it manually.


Add warnings and helpers for prompt='consent'.

Fixes #453
This is the last one for 3.0.0. After this, I'll send the release PR.
:)

First pass completed.

@nathanielmanistaatgoogle this should be ready for another look. I was going to wait on travis but it seems we've been put back in the slow lane.

Travis is (finally) green. :)

Thanks for all the reviews today, @nathanielmanistaatgoogle. I'll be cutting 3.0.0 tomorrow morning.


Bump version 0.1.0 -> 0.1.1

bump version 0.1.1 to include export.version_data for union package
update @tensorflow/tfjs in demo example for updated model.fitDataset

This change is

It has already been updated in https://github.com/tensorflow/tfjs-data/commit/dce3505b52eef837d5d7b28f603b5016171f2fc2


Rename hexAreaM2 and edgeLengthM

The functions hexArea(Km|m)2 and edgeLength(Km|M) is a bit misleading, given the fact each edge and hex area are not made equally. Additionally, there are 12 pentagons that do not conform. Given these functions actually produce the average size, I recommend renaming these to averageHexArea(Km|m)2 and averageEdgeLength(Km|M)

Following this, I propose hexArea(Km|m)2 and edgeLength(Km|M) to take in H3Index as argument and produce the exact area/length

Closing this, as I think we've agreed on these changes with #308.
@wwchen, let me know if you disagree and we can re-open!


Install Python 3 in Docker image

Description

Updates the OpenTSDB Dockerfile to use python 3. Later versions of the
alpine base image need an explicit version of Python specified. The
previous python package without a version doesn't exist anymore.
Fixes #2491
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

[x] Ran docker-compose -f docker/docker-compose.yml up

Checklist:

[x] This contribution follows the project's code of conduct
[x] This contribution follows the project's contributing guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] ~I have commented my code, particularly in hard-to-understand areas~
[ ] ~I have made corresponding changes to the documentation~
[ ] ~I have added tests that prove my fix is effective or that my feature works~
[x] New and existing unit tests pass locally with my changes
[ ] ~Any dependent changes have been merged and published in downstream modules~

Hi @muffix,
I tested your changes in my local computer and I am getting a Connection refused to the OpenTSDB.
If I look at the logs for the opentsdb container, this is what I can see:
2020-09-23T12:10:50.481113900Z 2020-09-23 12:10:50,480 INFO Set uid to user 0 succeeded
2020-09-23T12:10:50.482775500Z 2020-09-23 12:10:50,482 INFO supervisord started with pid 1
2020-09-23T12:10:51.489117500Z 2020-09-23 12:10:51,488 INFO spawned: 'hbase' with pid 7
2020-09-23T12:10:51.490212300Z 2020-09-23 12:10:51,489 INFO spawned: 'opentsdb' with pid 8
2020-09-23T12:10:51.491080700Z 2020-09-23 12:10:51,490 INFO exited: hbase (exit status 127; not expected)
2020-09-23T12:10:51.492116100Z 2020-09-23 12:10:51,491 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T12:10:52.498672600Z 2020-09-23 12:10:52,497 INFO spawned: 'hbase' with pid 9
2020-09-23T12:10:52.505058600Z 2020-09-23 12:10:52,503 INFO spawned: 'opentsdb' with pid 10
2020-09-23T12:10:52.509655300Z 2020-09-23 12:10:52,509 INFO exited: hbase (exit status 127; not expected)
2020-09-23T12:10:52.513100900Z 2020-09-23 12:10:52,512 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T12:10:54.520886800Z 2020-09-23 12:10:54,519 INFO spawned: 'hbase' with pid 11
2020-09-23T12:10:54.526963000Z 2020-09-23 12:10:54,525 INFO spawned: 'opentsdb' with pid 12
2020-09-23T12:10:54.531328100Z 2020-09-23 12:10:54,530 INFO exited: hbase (exit status 127; not expected)
2020-09-23T12:10:54.534260200Z 2020-09-23 12:10:54,533 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T12:10:57.539153400Z 2020-09-23 12:10:57,538 INFO spawned: 'hbase' with pid 13
2020-09-23T12:10:57.540344500Z 2020-09-23 12:10:57,540 INFO spawned: 'opentsdb' with pid 14
2020-09-23T12:10:57.541482500Z 2020-09-23 12:10:57,541 INFO exited: hbase (exit status 127; not expected)
2020-09-23T12:10:57.542009200Z 2020-09-23 12:10:57,541 INFO gave up: hbase entered FATAL state, too many start retries too quickly
2020-09-23T12:10:57.542303000Z 2020-09-23 12:10:57,542 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T12:10:58.543643700Z 2020-09-23 12:10:58,543 INFO gave up: opentsdb entered FATAL state, too many start retries too quickly

Did you get this to work with your changes?
Thanks in advance.

Yes, @jmelosegui, works for me. I just double-checked with a clean Docker setup. Are you sure you've rebuilt the image? Just running docker-compose -f docker/docker-compose.yml up from the repo root directory did it for me.

Yeah, not sure what could be wrong here.
This are the 3 containers running
❯ docker ps | Select -First 4
CONTAINER ID        IMAGE                  COMMAND                  CREATED             STATUS              PORTS                                                                        NAMES
ba6b2a39a074        docker_bosun           "sh -c '/usr/bin/supΓÇª"   18 minutes ago      Up 18 minutes       5252/tcp, 9565/tcp, <IP_ADDRESS>:8070->8070/tcp                                   bosun
47c4644511f5        docker_opentsdb        "sh -c '/usr/bin/supΓÇª"   18 minutes ago      Up 18 minutes       <IP_ADDRESS>:4242->4242/tcp, <IP_ADDRESS>:16010->16010/tcp, <IP_ADDRESS>:16030->16030/tcp   opentsdb
4d189c455e29        redis:6                "docker-entrypoint.sΓÇª"   18 minutes ago      Up 18 minutes       <IP_ADDRESS>:6379->6379/tcp                                                       redis

and this is the log for the opentsdb container still failing after 18 minutes
❯ docker logs -t opentsdb
2020-09-23T16:29:36.186136400Z 2020-09-23 16:29:36,186 INFO Set uid to user 0 succeeded
2020-09-23T16:29:36.187694900Z 2020-09-23 16:29:36,187 INFO supervisord started with pid 1
2020-09-23T16:29:37.189767600Z 2020-09-23 16:29:37,189 INFO spawned: 'hbase' with pid 7
2020-09-23T16:29:37.190567900Z 2020-09-23 16:29:37,190 INFO spawned: 'opentsdb' with pid 8
2020-09-23T16:29:37.191637800Z 2020-09-23 16:29:37,191 INFO exited: hbase (exit status 127; not expected)
2020-09-23T16:29:37.192315400Z 2020-09-23 16:29:37,192 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T16:29:38.197743200Z 2020-09-23 16:29:38,196 INFO spawned: 'hbase' with pid 9
2020-09-23T16:29:38.199154200Z 2020-09-23 16:29:38,198 INFO spawned: 'opentsdb' with pid 10
2020-09-23T16:29:38.200215600Z 2020-09-23 16:29:38,200 INFO exited: hbase (exit status 127; not expected)
2020-09-23T16:29:38.200967100Z 2020-09-23 16:29:38,200 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T16:29:40.207303000Z 2020-09-23 16:29:40,206 INFO spawned: 'hbase' with pid 11
2020-09-23T16:29:40.210802400Z 2020-09-23 16:29:40,209 INFO spawned: 'opentsdb' with pid 12
2020-09-23T16:29:40.214541400Z 2020-09-23 16:29:40,214 INFO exited: hbase (exit status 127; not expected)
2020-09-23T16:29:40.216771900Z 2020-09-23 16:29:40,216 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T16:29:43.221018800Z 2020-09-23 16:29:43,220 INFO spawned: 'hbase' with pid 13
2020-09-23T16:29:43.221778700Z 2020-09-23 16:29:43,221 INFO spawned: 'opentsdb' with pid 14
2020-09-23T16:29:43.222878100Z 2020-09-23 16:29:43,222 INFO exited: hbase (exit status 127; not expected)
2020-09-23T16:29:43.223387800Z 2020-09-23 16:29:43,223 INFO gave up: hbase entered FATAL state, too many start retries too quickly
2020-09-23T16:29:43.223537400Z 2020-09-23 16:29:43,223 INFO exited: opentsdb (exit status 127; not expected)
2020-09-23T16:29:44.224843400Z 2020-09-23 16:29:44,224 INFO gave up: opentsdb entered FATAL state, too many start retries too quickly

I will continue investigating, but not sure where to start looking at.

Looks like the HBase process keeps dying and is then respawned by the supervisor. You can look into the HBase logs (or supervisor's) inside the container. This has nothing to do with the fix mentioned in this PR, though.
I just double-checked and reset my Docker installation and rebuilt the containers. Works as expected.

Ok, thanks for your help @muffix!!!


Add AVM and TVE headers, functions and enums

My first big PR here so I expect you'll have some suggested changes for me but hopefully most of it is OK.

I will split it into two commits.

Thanks!


sngrep: 1.4.6 -> 1.4.7

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/irontec/sngrep/releases.
meta.description for sngrep is: "A tool for displaying SIP calls message flows from terminal"
meta.homepage for sngrep is: "https://github.com/irontec/sngrep"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.4.7 with grep in /nix/store/60q34da2ybnwi3mw8vrf9hc8wmn7l6kl-sngrep-1.4.7

directory tree listing: https://gist.github.com/2543e9b7239c4a7c0dc920430a826dfe

du listing: https://gist.github.com/e38c07c50f13ce478400f955ce4489af

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
sngrep

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/60q34da2ybnwi3mw8vrf9hc8wmn7l6kl-sngrep-1.4.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A sngrep https://github.com/r-ryantm/nixpkgs/archive/ba6a89321863b3cff919c87f4694c479a5b98c3b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/60q34da2ybnwi3mw8vrf9hc8wmn7l6kl-sngrep-1.4.7
ls -la /nix/store/60q34da2ybnwi3mw8vrf9hc8wmn7l6kl-sngrep-1.4.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- sngrep

Maintainer pings
cc @JorisE for testing.

lgtm


Optimize the calls to enrich_swagger (#164)

This pull request:

adds enrich_swagger() method to the startup event handler.
cleans up unnecessary calls to enrich_swagger()
fixes tests

Initially, only three tests failed because lifespan events don't work for tests, and now we need to manually call the enrich_swagger() in tests, after manipulate the routes.

@devla  sorry for disappearing -- vacation time but I am back!
Only three small changes left:

CHANGELOG entry
A suggestion I added
Need to run ruff format as per our pre-commit

Thanks for your contribution!


fix(ui) Avoid tags duplicates in datasets from two sources

This PR is suggested fix for #10886 .
Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[X] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Enhanced the merging functionality for global tags, ensuring unique tags based on the tag.urn property during array merges.

Bug Fixes

Improved data integrity and consistency when merging objects that include global tags.

Could anyone please review this?

@pedro93 , @david-leifker @jjoyce0510 Would you please have a look or recommend a reviewer for this kind of change?


RTL Support

This theme is the most complete one in documentation themes. The only feature that is missing is RTL languages (Arabic, Hebrew, Persian, etc.) support.
I am ready to help and open to suggestion to do this.

@h-enk I'm highly motivated to assist with the RTL work if I can be helpful. I would like to use this for my site, and I'm willing to invest some significant time and effort into it. Could you give me some guidance? E.g. I see you have an experimental PR; do you have a punchlist of things that need fixing? It looks like that changes in there are extremely minor - is it simply sufficient to surface what I imagine are a ton of issues?

@StevenEWright That would be super! I think Doks 1.0 should be used as the starting point - it will be released soon.
I'll get back to you in a week (I'm on the road).

I'll get back to you in a week (I'm on the road).

Looking forward to working with you on this ☺

Me too! ☺


git-ls-tree process receives sigpipe signal (exit code 141)

The Symfony Process spawned by the gitter dependency receives the 141 Exit Code (SIGPIPE: Write to pipe with no one reading) on HP UX if a directory contains a fairly large list of files (in my case, anything over 8000 bytes fails).

I was able to fix (read: botch into submission) it by replacing
    $process->run();

    if (!$process->isSuccessful()) {
          throw new ProcessFailedException($process);
    }

    return $process->getOutput();

by
$oldcwd = getcwd();
chdir($repository->getPath());
$output= exec($this->getPath().' '.$command,$data);
chdir($oldcwd);
return implode("\n", $data);

I asume this is an issue for the Gitter project?

@alehaa and perhaps even the Symfony Process component. But because this project includes them as-is instead of through a package.json, and because it may be due to how this project uses them, I thought it wiser to open the issue here and let the maintainers escalate it from there? Is this wrong?

If I get you right, the patch above needs to be applied in the Gitter sources, so I thought it needs to be done there.

Sorry I wasn't being entirely clear. The above "patch" is not an acceptable solution, but more a dirty workaround. This workaround could be implemented either in the Gitter or in the Gitlist code, but in my opinion this project is broken on HP UX for its choices of dependencies or for how it uses them. I thought because the maintainer is the same person, this would be a good place to start. But if you maintain I should open the bug in the Symfony Process component repo or in the Gitter repo, I will.

I'm just a maintainer of GitList. However, I think the Symfony maintainers will appreciate any contribution.

I will try my luck with them. But I'm afraid they'll point me right back here :)


Make A README & doc

based on https://github.com/Alamofire/Alamofire&
https://github.com/ethereum/web3.js

[ ] Donate button
[ ] etc

Going on in https://github.com/matterinc/web3swift/tree/feature/readmeImprovement

It seems that the issue is resolved, so its closed


chore: Use eslint-plugin-jsdoc's recommended-typescript-error ruleset

[x] Addresses an existing open issue: fixes #303
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview
ran pnpm install --save-dev eslint-plugin-jsdoc, added "jsdoc" to eslint plugins array, and enabled the recommended rules in the eslint config extends array with "plugin:/jsdoc/recommended"

👋 just checking in @emday4prez, is this still something you have time to work on? If so, anything I can help with?

👋 just checking in @emday4prez, is this still something you have time to work on? If so, anything I can help with?

Yes! I am away from my computer this weekend. I can finish this on Monday. Sorry about the delay! Thank you.

No rush, thanks! 🙌


build:enable building static executables

Enable the build system to create statically linked executables.
Currently we build both static and shared libraries, but the example
executables were always dynamically linked executables. Change the
meson.build files to build only static or shared libraries, the default
is to build shared libraries.
To simpify the meson.build dependencies and utilize the newer dependency()
function it is now required to use meson >= 0.60.0 version.
Adding 'static_build=1' to the make line 'make static_build=1 rebuild install'
will rebuild all of CNDP as a set of static libraries and executables. A new
cne-build.sh command line option was created called 'static' to build the
system e.g.: 'cne-build.sh static clean build'
Added a new makefile target to 'make help' to display the usage help text.
Building a debug image can also be built statically using the static_build=1 on
the make command line e.g.: 'make clean static debug'
Building as static makes the executables larger, but they do not require using
the LD_LIBRARY_PATH variable, which means 'sudo ./usr/local/bin/test-cne ring'
should work as expected.
Signed-off-by: Keith Wiles<EMAIL_ADDRESS>

@manojgop can you please verify Rust builds and the wireguard patches work and build. Thanks

Need to update the meson on the test machines to at least 0.60.0 version. Using pip to install a newer version of meson is needed. How is that done.

We should be moving to 21.04 soon, not sure what version that one, but most likely not 0.60.0.
I was using the dependency() for multiple library lookup in a single call, but I can revert back to using two dependency() calls.
From: jeffreybshaw @.>
Date: Wednesday, July 20, 2022 at 6:07 PM
To: CloudNativeDataPlane/cndp @.>
Cc: Wiles, Keith @.>, Author @.>
Subject: Re: [CloudNativeDataPlane/cndp] build:enable building static executables (PR #132)
Need to update the meson on the test machines to at least 0.60.0 version. Using pip to install a newer version of meson is needed. How is that done.
What feature from 0.60.0 is needed? I like packages from the package manager. Ubuntu 20.04 uses 0.53.2-2ubuntu2
—
Reply to this email directly, view it on GitHubhttps://github.com/CloudNativeDataPlane/cndp/pull/132#issuecomment-1190854217, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUWTDRKQBLBP4I4AIB2S4C3VVCBCHANCNFSM54FLZTEQ.
You are receiving this because you authored the thread.Message ID: @.***>

We should be moving to 21.04 soon, not sure what version that one, but most likely not 0.60.0. I was using the dependency() for multiple library lookup in a single call, but I can revert back to using two dependency() calls. From: jeffreybshaw @.> Date: Wednesday, July 20, 2022 at 6:07 PM To: CloudNativeDataPlane/cndp @.> Cc: Wiles, Keith @.>, Author @.> Subject: Re: [CloudNativeDataPlane/cndp] build:enable building static executables (PR #132) Need to update the meson on the test machines to at least 0.60.0 version. Using pip to install a newer version of meson is needed. How is that done. What feature from 0.60.0 is needed? I like packages from the package manager. Ubuntu 20.04 uses 0.53.2-2ubuntu2 — Reply to this email directly, view it on GitHub<#132 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUWTDRKQBLBP4I4AIB2S4C3VVCBCHANCNFSM54FLZTEQ. You are receiving this because you authored the thread.Message ID: @.***>

https://github.com/CloudNativeDataPlane/cndp/blob/main/.github/workflows/smoke.yml#L13 smoke test uses ubuntu:latest ( which is ubuntu 20.04 according to this table https://github.com/actions/virtual-environments#available-environments ) if we use ubuntu:22.04 we could use meson 0.63 package (https://packages.ubuntu.com/jammy/meson)

I reverted the requirement back to 0.53.2, but when we move to 21.04 we can move up to the next meson/ninja versions in the package manager. We still 20.04 build systems for now :-(

@manojgop can you please verify Rust builds and the wireguard patches work and build. Thanks

Do you mean to verify Rust with CNDP static build?. Current Rust uses shared library.


correctly re-raise exception to keep backtrace

When it crashes, we lose the original backtrace on stderr.

:+1:  looks good.


ClusterLoader - density test update

Adding multiple iterations of latency pods creation.

/assign @wojtek-t

/hold
Waiting for #255 to be merged.

/hold cancel

@wojtek-t
Code is rebased. All changes from other PRs are applied.

#264 merged. PR rebased.

I applied changes from #264 . Currently we are waiting for RCs being ready instead of waiting just for pods. There are two separate measurement instances. One for saturation RCs, the other for latency RCs.  I also changed the operationTimeout for saturation RCs, due to 20pods/s assumption.
@wojtek-t PTAL

/lgtm


ModuleNotFoundError: No module named 'magent'

I use Ubuntu System, and when I try run "python3 train_battle.py --algo mfac", I got an Error "ModuleNotFoundError: No module named 'magent",  and "AttributeError: 'GridWorld' object has no attribute 'game'".
I'm a new learner,  I don't know how to fixt it, I hope someone can help me to solve this problem.Thanks

Did you solve the problem? I had the same question. Hope to get a reply.


[ALLUXIO-2527] Update setTtl documentation grammar

Fix the grammar of setTtl documentation in docs/_data/table/en/operation-command.yml.
https://alluxio.atlassian.net/browse/ALLUXIO-2527

Can one of the admins verify this patch?

alluxio-bot, check this please

ok to test

add to whitelist

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13951/
Test PASSed.

Merged build finished. Test PASSed.


Use Node 18

Node 18 is stable now, and there are a number of features I'd like to take advantage of, such as:

Built-in args parser (would make yargs obsolete)
Built-in fetch API (would make axios and undici obsolete)

I've ditched yargs in this PR as a proof-of-concept. Feedback is encouraged.
Those of us not developing in Docker will need to update our dev environments to Node at least 18.17.0. nvm is a useful tool for this.

If #93 merges before this, then I'll go ahead and drop undici during the rebase.


HW accelaration on Debian Stretch

Hi! Bionic images supports hw accelaration but debian stretch does not. Can you fix it? Debian and Ubuntu are very similar distributions and according to the Rockchip official page  they build their custom kernel and mali driver for debian stretch. So, my question is why we see bionic images supporting hw and not debian stretch images. Is it because of different versions?  If the answer is yes, Bionic relies on debian testing so if we use debian-backports repo we cannot fix unmet dependencies? I would appreciate if you support Debian Stretch as well. Thanks in advance!

I would like to see hw acceleration on stretch, too. While video acceleration with mpv works good opengl/2D accleratrion would be great for gaming. I played quite a few AGS-Games on my rock64 (Shard Light, alle Ben Jordan Games, A Golden Wake and Puzzel Bots), SCUMM VM Games work mostly okay, too. Anything else unfortunatly to slow. Would like to see acceleration cause the stretch image is really stable and therefore very recommemended.


Issues while using between operator

React Query Builder version
7.4.4
Platform
No response
Description
When I try to use between operator for a text field, if the text field contains a comma, the generated SQL is fine but when I try to import the SQL, the UI gets messed up.
Please refer to the attached video
https://github.com/react-querybuilder/react-querybuilder/assets/150130308/bd84e072-8af8-4470-a75b-6b33b1f1965b
Reproduction
NA
Expected behavior
I should be able to switch between operators seamlessly
Additional information
No response

That's a good catch. You can sort of work around it today with the listsAsArrays option:
parseSQL("firstName between 'Vi,ram' and 'Jain'", { listsAsArrays: true })

yields
{
  "combinator": "and",
  "rules": [
    {
      "field": "firstName",
      "operator": "between",
      "value": ["Vi,ram", "Jain"]
    }
  ]
}

However that doesn't really address the bug, so I've resolved it in #716.

Fix for this was included in v7.5.0.


Cannot start crashed VM because MAC address still bound to previous macvlan virtual interface

Required information

Distribution: Ubuntu
Distribution version: 22.04
The output of "lxc info": see attached lxd-issues_x_lxc-info.txt

Issue description
Very similar situation with ticket #11089 where a VM crashes for some reason and then cannot start because the MAC address is still bound to an old virtual macvlan interface.
someadmin@ud2204-iph-lxd03:~$ lxc start mw2022-ivm-cxv01
Error: Failed to start device "eth0": Failed adding link: Failed to run: ip link add name mac03537ca4 link eno1 address 00:16:3e:d1:00:d7 allmulticast on up type macvtap mode bridge: exit status 2 (RTNETLINK answers: Address already in use)
Try `lxc info --show-log mw2022-ivm-cxv01` for more info

someadmin@ud2204-iph-lxd03:~$ lxc info --show-log mw2022-ivm-cxv01
Name: mw2022-ivm-cxv01
Status: STOPPED
Type: virtual-machine
Architecture: x86_64
Location: ud2204-iph-lxd03.domain.tld
Created: 2023/03/02 16:01 EST
Last Used: 2023/03/26 09:34 EDT
Error: open /var/snap/lxd/common/lxd/logs/mw2022-ivm-cxv01/qemu.log: no such file or directory

someadmin@ud2204-iph-lxd03:~$ ip link show | grep -B 1 '00:16:3e:d1:00:d7'
184: mac80680caa@eno1: <BROADCAST,MULTICAST,ALLMULTI,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 500
    link/ether 00:16:3e:d1:00:d7 brd ff:ff:ff:ff:ff:ff

someadmin@ud2204-iph-lxd03:~$ ip link delete mac80680caa

someadmin@ud2204-iph-lxd03:~$ lxc start mw2022-ivm-cxv01

Steps to reproduce
I am unable to reproduce the crash at the moment however 3 Windows VMs have recently crashed and required the same ip link delete command to release the MAC address to start the VM.
Information to attach

[x] Any relevant kernel output (dmesg): see attached lxd-issues_x_dmesg-T.txt
[ ] Container log (lxc info NAME --show-log): Error: open /var/snap/lxd/common/lxd/logs/mw2022-ivm-cxv01/qemu.log: no such file or directory
[x] Container configuration (lxc config show NAME --expanded): see attached lxd-issues_x_lxc-config-show_mw2022-ivm-cxv01.txt
[x] Main daemon log (at /var/log/lxd/lxd.log or /var/snap/lxd/common/lxd/logs/lxd.log): see attached lxd-issues_x_lxd-daemon-log*.txt
[ ] Output of the client with --debug
[ ] Output of the daemon with --debug (alternatively output of lxc monitor while reproducing the issue)
[x] VM qemu.old.log: see attached lxd-issues_x_mw2022-ivm-cxv01_qemu-old-log.txt
[x] Snap LXD auto refresh date: does not match VM crash 5.12-c63881f @ 6 days ago, at 09:15 EDT
[x] grep syslog for crashed VMs: see attached lxd-issues_x_syslog-grep-vms.txt

Have you checked for OOM situations?

Good morning... Thanks for the super quick response.
No. Will do now.
FYI I'm just uploading the attachments now, needed to create the ticket for the ticket number.

Memory info:
someadmin@us2204-iph-lxd03:/home/someadmin# free -h
               total        used        free      shared  buff/cache   available
Mem:           377Gi       247Gi        38Gi        80Gi        91Gi        45Gi
Swap:          8.0Gi       3.3Gi       4.7Gi

someadmin@us2204-iph-lxd03:/home/someadmin# grep -i kill /var/log/syslog

someadmin@us2204-iph-lxd03:/home/someadmin# grep -i memory /var/log/syslog

someadmin@us2204-iph-lxd03:/home/someadmin# grep -i ooo /var/log/syslog/

I think the crash for Windows VM instance mw2022-ivm-cxv01 was this line in the attached lxd-issues_11520_dmesg-T.txt:
[Mon Mar 27 22:10:47 2023] set kvm_intel.dump_invalid_vmcs=1 to dump internal KVM state.

because the qemu.old.log lxd-issues_11520_mw2022-ivm-cxv01_qemu-old-log.txt has a similar mod time:
someadmin@us2204-iph-lxd03:/home/someadmin# ls -lh /var/snap/lxd/common/lxd/logs/mw2022-ivm-cxv01/
total 16K
-rw-r----- 1 root root 4.7K Mar 26 09:34 qemu.conf
srwxr-x--- 1 root root    0 Mar 26 09:34 qemu.console
-rw-r--r-- 1 root root    0 Mar 26 09:34 qemu.early.log
-rw-r--r-- 1 root root 1.3K Mar 27 22:11 qemu.log.old
srwxr-x--- 1 root root    0 Mar 26 09:34 qemu.monitor
srwxr-x--- 1 root root    0 Mar 26 09:34 qemu.spice
srwxr-xr-x 1 root root    0 Mar 26 09:34 virtio-fs.config.sock
-rw-r--r-- 1 root root  198 Mar 26 09:34 virtiofsd.pid

Sounds like it could be a kernel issue:
https://forum.proxmox.com/threads/vm-shutdown-kvm-entry-failed-hardware-error-0x80000021.109410/

Could very well be.... 5.19.0-35 has messed with my devices at home so I now have missing graphics and sound devices in them. I've done an update to -38 and other things then rebooted the host, but I think these are just security related fixes.

No joy after the update and reboot. Just created a new Windows VM and during the sysprep stage it died and I have to delete the macvlan interface manually.
from qemu.log.old:
someadmin@us2204-iph-lxd03:/home/someadmin# cat /var/snap/lxd/common/lxd/logs/mw2022-ivm-test01/qemu.log.old
qemu-system-x86_64: Issue while setting TUNSETSTEERINGEBPF: Invalid argument with fd: 48, prog_fd: -1
KVM: entry failed, hardware error 0x80000021

If you're running a guest on an Intel machine without unrestricted mode
support, the failure can be most likely due to the guest entering an invalid
state for Intel VT. For example, the guest maybe running in big real mode
which is not supported on less recent Intel processors.

EAX=00000008 EBX=00040ee0 ECX=800003ac EDX=00000000
ESI=32e2f000 EDI=32e26040 EBP=813d2810 ESP=813d2790
EIP=00008000 EFL=00000002 [-------] CPL=0 II=0 A20=1 SMM=1 HLT=0
ES =0000 00000000 ffffffff 00809300
CS =8000 7ff80000 ffffffff 00809300
SS =0000 00000000 ffffffff 00809300
DS =0000 00000000 ffffffff 00809300
FS =0000 00000000 ffffffff 00809300
GS =0000 00000000 ffffffff 00809300
LDT=0000 00000000 00000000 00000000
TR =0040 ff2a0000 00000067 00008b00
GDT=     ff2a1fb0 00000057
IDT=     00000000 00000000
CR0=00050032 CR2=7c3fa0b0 CR3=001ae002 CR4=00000000
DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000
DR6=00000000ffff0ff0 DR7=0000000000000400
EFER=0000000000000000
Code=qemu-system-x86_64: ../hw/core/cpu-sysemu.c:77: cpu_asidx_from_attrs: Assertion `ret < cpu->num_ases && ret >= 0' failed.

Good morning
So this ticket is mainly about not being able to start the instances following a crash due to the MAC address still being used on the previous iteration of the macvlan NIC. We know what to do and it's not too bad:
Try start the instance
lxc start {instance}

Get the MAC in the error and find the macvlan interface using it
ip link | grep -B 1 {mac-address}

Copy the macvlan NIC name before the @ and delete it
ip link delete {macvlan-nic-name}

The other reason is to help us to find a workable solution to run WS2022 VMs in LXD when we run into this scenario, which looks like a combination of things, but mainly older CPUs, TDP MMU, and not so good kernel updates.
Thanks for the thread link and I've read through all of it. It helped me find this document which has some (hopefully) useful advice:
https://pve.proxmox.com/wiki/Upgrade_from_6.x_to_7.0#KVM:_entry_failed.2C_hardware_error_0x80000021

intel-microcode is already up to date by default.
I've gone for disabling tdp_mmu via the modprobe config module option.

I did this late last night, so we should know by Monday whether this helps.
Have a great weekend !

Good morning, and hope you had a good weekend.
Some good news is that that modprobe method disabling TDP MMU / Intel EPT from the Proxmox upgrade KB above, seems to have stabilised these Windows Sever 2022 VMs.
Sadly the CPU is old but does support this apparently (last feature right at the bottom):
https://www.intel.com/content/www/us/en/products/sku/75277/intel-xeon-processor-e52680-v2-25m-cache-2-80-ghz/specifications.html
Question: would the LXD team recommend that I should report it to the Canonical Kernel Team as I do know that 5.19.0-35 onwards is causing a bit of havoc with other things as well ?
Thanks

Raised ticket:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2015455


Jws/JweHeaderSet critical value should not be encoded by BASE64

This is a bug

I have released v0.8.2 which fixes this bug.


resolves #11

vestigial test code that caused gilbert_d2xy(&x, &y, 7861, 490, 490) to incorrectly return
-1 (there was a max_iter check to return after some hard coded value)
added test to make sure at least that condition is tested for
gilbert.c had buffer overrun setting last byte of buf, correctly sets buf[1023]='\0'
instead of buf[1024]

Thank you. I'm just wondering: how can one get so many iterations? Unless this was called in a loop, the recursion depth should never be this large (it should be a logarithm).

Getting individual values is logarithmic and calling the function a few times doesn't trigger the issue.
The C program version (compiled with the GILBERT_MAIN define set) loops over every element, either (x,y) pairs or the index, so any dimensions that exceed the hard coded value will trigger this issue. In this case, max_iter was set to 100,000, and 460 * 460 = 211600 > 100000.
The problem was actually much much worse, in that the max_iter variable is static to the function, so it's not just that it gets incremented if the function gets called in order, it gets incremented if the function gets called at all, so calling the function gilbert_d2xy_r(&x, &y, 0, 10, 10) over 100,000 times would have also triggered the issue.


Adjustable contrast

When Dark mode is selected, the block organization modal doesn't show up with the right colours.

Temporarily disable this feature pending cleanup of styles.


Remove the D-Bus code from Crosswalk

This is not needed after the Shared Process model is dropped.

lgtm


Add brycahta to ec2-fleet-plugin

Description
Requesting permissions for @brycahta for https://github.com/jenkinsci/ec2-fleet-plugin
Existing maintainers (@imuqtadir & @haugenj) are no longer with the team; however, I have been granted Admin permissions to repo and therefore also have commit permissions. Recently merged PR for reference: https://github.com/jenkinsci/ec2-fleet-plugin/pull/343

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

All newly added users have logged in to Artifactory at least once

Logs show I am failing due to not logging into Jira (which is true). I will login now, then update this checklist via PR.

It takes about an hour or so for you to show up in https://reports.jenkins.io/artifactory-ldap-users-report.json


[BUG] Seedfarmer fails to destroy modules when deployed in VPC

Describe the bug
I have a codeseeder project  within VPC. When I try to destroy modules, some were destroyed but now the destroy process is stuck, as codeseeder codebuild project is stuck at QUEUED phase error: UNAUTHORIZED_OPERATION_DELETE_NETWORK_INTERFACE: The service role is not authorized to perform ec2:DeleteNetworkInterface
To Reproduce
Steps to reproduce the behavior:

Deploy modules from codeseeder in VPC
Start destroying modules in VPC
See error

Expected behavior
Codeseeder codebuild project should not fail when destroying modules when running inside VPC
Additional context
Required permissions to deploy in VPC: https://docs.aws.amazon.com/codebuild/latest/userguide/auth-and-access-control-iam-identity-based-access-control.html#customer-managed-policies-example-create-vpc-network-interface

Can you give some more information so we can try and replicate?  Is this during seedfarmer destroy invocation or after you removed modules from the manifest and invoked seedfarmer apply?    What were the modules that were successfully destroyed and not?  Did some fail to destroy?
The seedkit is not managed by a codebuild job - what is that screenshot from?  Is that a module?  At what point in the process did you get there?  The steps you indicated above have been followed previously and we did not encounter this issue, so we are trying to fully understand how to replicate.

Sure.

Is this during seedfarmer destroy invocation or after you removed modules from the manifest and invoked seedfarmer apply?  Yes, about half of the modules were successfully destroyed.
What were the modules that were successfully destroyed and not? There is a lot of them, but for example EKS module was destroyed but replication module cannot be destroyed due to the error.
Did some fail to destroy? No, all succeeded.
The screenshot is from the codebuild project called "codeseeder-addf", its the one that deployes the modules. Screenshot is from the codebuild job that was trying to run destroy of replication

Hi - the seedfarmer apply and seedfarmer destroy cli does not operate within a codebuild project.  You may be invoking the seedfarmer cli from a codebuild project (and that invocation is done via the codebuild service role) but that is outside of the scope of seedfarmer and the deployment roles.
So there are two scenarios where creating / removing a ENI can occur:

as part of a module -- in which any problem that occurs lies with the module itself and not seedfarmer
when creating / destroying the seedkit (via codeseeder api in seedfarmer) - in this scenario, a seedfarmer deployment role (for an account/region mapping) has the permissions to create a codebuild project with VPC support.  SeedFarmer does not destroy the seedkit on a seedfarmer destroy invocation and thus will not cause an error due to lack of destroy ENI permissions

None of the modules directly create/destroy the ENI.  I do not see how this could be a module problem. I can add delete ENI permissions to modulestack and that probably will work but create ENI permission is added by default (and delete is missing).

Closing this issue as the root cause cannot be linked to SeedFarmer...we can reopen once further details are gathered.


custom program error: 0x1004

Hi!
I deployed the program to my own program_id,
but when I'm trying to play using the CLI I'm getting an Error,
state command is working well.
how to solve it?
Thanks.
Command:
cargo run -q --package roulette-cli -- play
Output:

Loading a bullet and spinning the cylinder..
Error: RPC response error -32002: Transaction simulation failed: Error processing Instruction 0: custom program error: 0x1004 [4 log messages]
Caused by:
0: RPC response error -32002: Transaction simulation failed: Error processing Instruction 0: custom program error: 0x1004 [4 log messages]
1: RPC response error -32002: Transaction simulation failed: Error processing Instruction 0: custom program error: 0x1004 [4 log messages]

Expected Output:

-- Using RPC https://api.devnet.solana.com, keypair <PATH_TO_MY_KEYPAIR> -- ------
Loading a bullet and spinning the cylinder..
Waiting for the round to finish..
CLICK! Player <MY_PUBLIC_KEY> is alive after 1 round(s)

Command:
cargo run -q --package roulette-cli -- state
Output == Expected Output:

-- Using RPC https://api.devnet.solana.com, keypair <PATH_TO_MY_KEYPAIR> -- ------
Player <MY_PUBLIC_KEY> has never played

Hi.
Have you checked if your deployed program_id is the same as the one specified in lib.rs? This looks like DeclaredProgramIdMismatch error.


Add Validate(), Execute() to cmd/

We should uniformly follow the execution of every command. First we should validate the input, e.g. validate if the component exists, or application exists, etc. Then we should execute the program.
It would be worthwhile to refactor code such as to accommodate an interface that helps us with this.
Something like -
func (c *command) validate(comp component, app application) error {
  if !comp.Exists() {
    return err
  }
  if !app.Exists() {
    return err
  }
  return nil
}

func main() {
  c := command{
  action: "create",
  }

  checkError(c.valdate())
  c.execute()
}

@kadel I think we should cose this for now. We have enough validation within the commands already!


RViz ignores 'joint_limits.yaml' in MoveIt Config when using moveit_rviz default launch file

Description:
I encountered an issue where RViz ignores the joint limits specified in the joint_limits.yaml file within the MoveIt configuration package when launching using the default launch files generated by the MoveIt2 Setup Assistant.
Steps to Reproduce:
(On branch humble)

Create a MoveIt2 configuration package using the Setup Assistant.
Define custom joint limits in the joint_limits.yaml file within the config directory.
Notice how these joint_limits are ignored by looking at rviz parameters

Observed Behavior:
In my case, Motion planning within RViz results in unexpectedly large joint movements. Upon further inspection, it appears that RViz is using the same joint limits as in the URDF (in my case, a UR10e robot with 720° angle ranges), rather than the limits specified in joint_limits.yaml present in the moveit_config of my robot package.
My move_group node (whose launch file was also created with the setup assistant), however, uses the values from the local joint_limit.yaml file.
Expected Behavior:
I believe the RViz motion planning plugin should use the same joint limits as the move_group's when performing motion planning.
My Solution:
I modified the generate_moveit_rviz_launch function to include the joint limits in the node parameters passed to RViz. Here is the reimplementation of the function:
from launch import LaunchDescription
from launch.actions import DeclareLaunchArgument
from launch.substitutions import LaunchConfiguration
from moveit_configs_utils import MoveItConfigsBuilder

def generate_moveit_rviz_launch_using_joint_limits(moveit_config):
    ld = LaunchDescription()

    ld.add_action(DeclareBooleanLaunchArg("debug", default_value=False))
    ld.add_action(
        DeclareLaunchArgument(
            "rviz_config",
            default_value=str(moveit_config.package_path / "config/moveit.rviz"),
        )
    )

    rviz_parameters = [
        moveit_config.planning_pipelines,
        moveit_config.robot_description_kinematics,
        moveit_config.robot_description_joint_limits  # Added joint limits here
    ]

    add_debuggable_node(
        ld,
        package="rviz2",
        executable="rviz2",
        output="log",
        respawn=False,
        arguments=["-d", LaunchConfiguration("rviz_config")],
        parameters=rviz_parameters,
    )

    return ld

Question:
Is this behavior intentional, or is it an oversight that RViz does not use the joint limits from joint_limits.yaml? Should the default generate_moveit_rviz_launch function be updated to include these limits, or is there another recommended approach?
Thank you for your assistance!

I was having this same issue and created a PR #3901. My solution was basically the same as @Dabuss although it seems like robot_description_joint_limits became just joint_limits at some point.

This is fixed in main - I just started the back port to humble in https://github.com/moveit/moveit2/pull/3136


2.2.2 fails on FreeBSD 11-CURRENT

After looking at the logs, if there's anything else I can check for, let me know!
$ uname -a; freebsd-version
FreeBSD z600 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r286893: Tue Aug 18 18:44:28 UTC 2015     root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
11.0-CURRENT

$ rbenv install 2.2.2 -v > ~/freebsd222build.log
Downloading ruby-2.2.2.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/5ffc0f317e429e6b29d4a98ac521c3ce65481bfd22a8cf845fa02a7b113d9b44
load: 0.58  cmd: curl 46215 [select] 2.37r 0.07u 0.03s 1% 9184k
giInstalling ruby-2.2.2...

BUILD FAILED (FreeBSD 11.0-CURRENT using ruby-build 20150818)

Inspect or clean up the working tree at /tmp/ruby-build.20150908103654.46184
Results logged to /tmp/ruby-build.20150908103654.46184.log

Last 10 log lines:
                              power_assert-0.2.2.gem
installing rdoc:              /usr/home/tony/.rbenv/versions/2.2.2/share/ri/2.2.0/system
installing capi-docs:         /usr/home/tony/.rbenv/versions/2.2.2/share/doc/ruby
The Ruby readline extension was not compiled.
ERROR: Ruby install aborted due to missing extensions
Configure options used:
  --prefix=/usr/home/tony/.rbenv/versions/2.2.2
  CFLAGS= -O3 -Wno-error=shorten-64-to-32
  LDFLAGS=-L/usr/home/tony/.rbenv/versions/2.2.2/lib
  CPPFLAGS=-I/usr/home/tony/.rbenv/versions/2.2.2/include

Verbose Log: https://gist.github.com/tony/07fa8415f3f74e1d39f6

Have you tried installing libreadline or readline-devel using the package manager for FreeBSD? It seems that might fix the problem

I had the same problem as tony.  I have readline installed, and it still fails.

readline was installed when I posted the original issue.  I get the same response from rbenv install 2.2.2. Here are more details on readline (You can also see where the libs install to)
$ pkg info readline-6.3.8
readline-6.3.8
Name           : readline
Version        : 6.3.8
Installed on   : Tue Sep  8 10:21:36 CDT 2015
Origin         : devel/readline
Architecture   : freebsd:11:x86:64
Prefix         : /usr/local
Categories     : devel
Licenses       : GPLv3
Maintainer<EMAIL_ADDRESS>WWW            : http://cnswww.cns.cwru.edu/php/chet/readline/rltop.html
Comment        : Library for editing command lines as they are typed
Options        :
	DOCS           : on
	TERMCAP        : on
Shared Libs provided:
	libreadline.so.6
	libhistory.so.6

$ pkg info -l readline-6.3.8
readline-6.3.8:
	/usr/local/include/readline/chardefs.h
	/usr/local/include/readline/history.h
	/usr/local/include/readline/keymaps.h
	/usr/local/include/readline/readline.h
	/usr/local/include/readline/rlconf.h
	/usr/local/include/readline/rlstdc.h
	/usr/local/include/readline/rltypedefs.h
	/usr/local/include/readline/tilde.h
	/usr/local/info/history.info
	/usr/local/info/readline.info
	/usr/local/info/rluserman.info
	/usr/local/lib/libhistory.a
	/usr/local/lib/libhistory.so
	/usr/local/lib/libhistory.so.6
	/usr/local/lib/libreadline.a
	/usr/local/lib/libreadline.so
	/usr/local/lib/libreadline.so.6
	/usr/local/man/man3/history.3.gz
	/usr/local/man/man3/readline.3.gz
	/usr/local/share/doc/readline/CHANGES
	/usr/local/share/doc/readline/INSTALL
	/usr/local/share/doc/readline/README
	/usr/local/share/licenses/readline-6.3.8/GPLv3
	/usr/local/share/licenses/readline-6.3.8/LICENSE
	/usr/local/share/licenses/readline-6.3.8/catalog.mk
	/usr/local/share/readline/excallback.c
	/usr/local/share/readline/fileman.c
	/usr/local/share/readline/hist_erasedups.c
	/usr/local/share/readline/hist_purgecmd.c
	/usr/local/share/readline/histexamp.c
	/usr/local/share/readline/manexamp.c
	/usr/local/share/readline/rl-callbacktest.c
	/usr/local/share/readline/rl-fgets.c
	/usr/local/share/readline/rl.c
	/usr/local/share/readline/rlcat.c
	/usr/local/share/readline/rlevent.c
	/usr/local/share/readline/rlptytest.c
	/usr/local/share/readline/rltest.c
	/usr/local/share/readline/rlversion.c

@tony Thanks for sharing this info. Can you try specifying RUBY_CONFIGURE_OPTS=--with-readline-dir=/usr/local/include/readline?
@hsbt This might be a Ruby build bug on FreeBSD. Do you know anything about that?

@tony @mislav It seems issue of Ruby core extension. I will report our tracker.
ref. https://bugs.ruby-lang.org/issues/11546

@tony @apotheon In the meantime, try RUBY_CONFIGURE_OPTS=--disable-install-doc to skip the RDoc generation phase. Ruby might still be compiled without readline support, but most of your programs should work fine.

@tony Can you provide ext/readline/mkmf.log ?  It exists under /tmp/ruby-build.20150908103654.46184/ruby-2.2.2  directory.

@hsbt:
$ cat /tmp/ruby-build.20150908103654.46184/ruby-2.2.2/ext/readline/mkmf.log
have_library: checking for tgetnum() in -lncurses... -------------------- yes

"cc -o conftest -I../../.ext/include/x86_64-freebsd11.0 -I../.././include -I../.././ext/readline -I/usr/home/tony/.rbenv/versions/2.2.2/include     -O3 -Wno-error=shorten-64-to-32  conftest.c  -L. -L../.. -L. -L/usr/home/tony/.rbenv/versions/2.2.2/lib  -fstack-protector -rdynamic     -Wl,-R/usr/home/tony/.rbenv/versions/2.2.2/lib -L/usr/home/tony/.rbenv/versions/2.2.2/lib -lruby-static -lncurses  -lelf -lexecinfo -lprocstat -lthr -lcrypt -lm   -lc"
conftest.c:13:57: error: use of undeclared identifier 'tgetnum'
int t(void) { void ((*volatile p)()); p = (void ((*)()))tgetnum; return 0; }
                                                        ^
1 error generated.
checked program was:
/* begin */
 1: #include "ruby.h"
 2:
 3: /*top*/
 4: extern int t(void);
 5: int main(int argc, char **argv)
 6: {
 7:   if (argc > 1000000) {
 8:     printf("%p", &t);
 9:   }
10:
11:   return 0;
12: }
13: int t(void) { void ((*volatile p)()); p = (void ((*)()))tgetnum; return 0; }
/* end */

"cc -o conftest -I../../.ext/include/x86_64-freebsd11.0 -I../.././include -I../.././ext/readline -I/usr/home/tony/.rbenv/versions/2.2.2/include     -O3 -Wno-error=shorten-64-to-32  conftest.c  -L. -L../.. -L. -L/usr/home/tony/.rbenv/versions/2.2.2/lib  -fstack-protector -rdynamic     -Wl,-R/usr/home/tony/.rbenv/versions/2.2.2/lib -L/usr/home/tony/.rbenv/versions/2.2.2/lib -lruby-static -lncurses  -lelf -lexecinfo -lprocstat -lthr -lcrypt -lm   -lc"
conftest.c:13:15: warning: implicit declaration of function 'tgetnum' is invalid in C99 [-Wimplicit-function-declaration]
int t(void) { tgetnum(); return 0; }
              ^
1 warning generated.
checked program was:
/* begin */
 1: #include "ruby.h"
 2:
 3: /*top*/
 4: extern int t(void);
 5: int main(int argc, char **argv)
 6: {
 7:   if (argc > 1000000) {
 8:     printf("%p", &t);
 9:   }
10:
11:   return 0;
12: }
13: int t(void) { tgetnum(); return 0; }
/* end */

--------------------

have_header: checking for readline/readline.h... -------------------- no

"cc -E -I../../.ext/include/x86_64-freebsd11.0 -I../.././include -I../.././ext/readline -I/usr/home/tony/.rbenv/versions/2.2.2/include     -O3 -Wno-error=shorten-64-to-32   conftest.c -o conftest.i"
conftest.c:3:10: fatal error: 'readline/readline.h' file not found
#include <readline/readline.h>
         ^
1 error generated.
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: #include <readline/readline.h>
/* end */

--------------------

have_header: checking for editline/readline.h... -------------------- no

"cc -E -I../../.ext/include/x86_64-freebsd11.0 -I../.././include -I../.././ext/readline -I/usr/home/tony/.rbenv/versions/2.2.2/include     -O3 -Wno-error=shorten-64-to-32   conftest.c -o conftest.i"
conftest.c:3:10: fatal error: 'editline/readline.h' file not found
#include <editline/readline.h>
         ^
1 error generated.
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: #include <editline/readline.h>
/* end */

--------------------

readline nor libedit not found
Failed to configure readline. It will not be installed.

You need to pass --with-opt-dir=/usr/local option to configure.
I don't know how it can with rbenv.

@nobu
RUBY_CONFIGURE_OPTS=--with-opt-dir=/usr/local

Works.
Is this something that'd be fixed here or want us to do it via our packaging?
$ RUBY_CONFIGURE_OPTS=--with-opt-dir=/usr/local  rbenv install 2.2.2
Downloading ruby-2.2.2.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/5ffc0f317e429e6b29d4a98ac521c3ce65481bfd22a8cf845fa02a7b113d9b44
Installing ruby-2.2.2...
Installed ruby-2.2.2 to /usr/home/tony/.rbenv/versions/2.2.2

We could change ruby-build to include --with-opt-dir=/usr/local on FreeBSD by default if no explicit --with-opt-dir was specified. That would take care of the problem temporarily. Future Ruby versions might fix this in their build process. What does everyone think about this?

Sounds good.
If we can make a new tag I'll make a patch to update the port package as
well.
On Sun, Sep 27, 2015 at 7:46 AM, Mislav Marohnić<EMAIL_ADDRESS>wrote:

We could change ruby-build to include --with-opt-dir=/usr/local on
FreeBSD by default if no explicit --with-opt-dir was specified. That
would take care of the problem temporarily. Future Ruby versions might fix
this in their build process. What does everyone think about this?
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/805#issuecomment-143547211
.

As an update, FreeBSD-11 has released and the problem does remain.  When rbenv installed out of my home directory, the above RUBY_CONFIGURE_OPTS did not work for me.

  I have just run the following after reading the bin scripts.
RUBY_CONFIGURE_OPTS=--with-readline-dir="/usr/local" rbenv install 2.2.5
Which has resulted in a functional ruby in my users home directory on FreeBSD 11-RELEASE.
The option I'd tried before was RUBY_CONFIGURE_OPTS=--with-opt-dir=/usr/local, which didn't work.

I confirm to build with --with-opt-dir on FreeBSD 11
[freebsd@chkbuild015 ~]$ RUBY_CONFIGURE_OPTS=--with-opt-dir=/usr/local rbenv install 2.2.5
Downloading ruby-2.2.5.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.2/ruby-2.2.5.tar.bz2
Installing ruby-2.2.5...
Installed ruby-2.2.5 to /home/freebsd/.rbenv/versions/2.2.5

I couldn't reproduce this issue.

We have a solution of this issue on FreeBSD 11, I close this.


Lost text when click to edit

Hi. Im using lastest Select2, enable tag mode. While Im typing a new tag, i want use mouse to focus to this text (still not Enter yet), but the text gone. Could you guys helpe me keep text when focus mouse to that?

I too find it bad for usability that the input is deleted and the dropdown closed when one tries to click into their written text (i.e. to correct spelling). This is very counterintuitive.


Fix patching on 3 new spec files

Issue #, if available:
Description of changes:

The 3 new specs had some messed up patches and merge issues.  Fixing all of that.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   84.18%   84.18%
=======================================
  Files         111      111
  Lines        5958     5958
  Branches     1341     1341
=======================================
  Hits         5016     5016
  Misses        621      621
  Partials      321      321

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b45fe5...6667636. Read the comment docs.


Update Dockerfile Fixes #29

It is interesting that I don't have this issue. I can only assume that I probably already have an earlier and less strict version of Node 18 (or similar dependency / versioning issue).
What you are proposing is definitely going to "fix" the issue, but I just wonder if the natural thing to do instead wold be to just move @types/react-syntax-highlighter from devDependencies to dependencies in package.json?

I'm happy with any approach you prefer. In general, if we need to do a "build" step in the container, I think of b any build requirements as "dev" dependencies. But that's not a hard rule.

It looks like docker build is still broken in the main branch. @vlad-ignatov would you prefer to merge this PR or to apply a different fix as outlined above?


Maybe we should change the name 'Structure' to 'Column'

Structure -> Columns
Add field -> Add column
is it more understandable？

Hi! In my opinion, this suggestion does make it clearer in the table view interface, I just want to make sure that the concept of "structure" & "field" is still intact after we change it, is it still conceptually clear?
Ideas?

@Tumao727 @nameczz what do you guys think?

halo, I prefer [structure],and [add column]

The structure is consist of multiple columns only.
I think "Columns" maybe a better word here.  @congtan0224

In create collection dialog,   we have two fixed columns, but there is no label telling user what are these. if we change "Define Structure" to "Define Columns", it is more obvious these two are columns.
What do you think @congtan0224


Update required Kubernetes version

@lisaguthrie : Thanks for your contribution! The author, @"ghogen", has been notified to review your proposed change.

@lisaguthrie Thank you for change!
@ghogen @erickson-doug
#sign-off

@JennieHubbard: I'm sorry - only the author of this article, @"ghogen", can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Consumer ctk aws deployment

Pls review this PR for the consumer. I have few confusion or question about DB. The consumer has DB. Let's discuss this later.

I believe whatever you did is correct. I must accept it. It will be nice to know the details

I restored the branch, because the PR was not done, there is still work to do on it

Alright. Hopefully, we will finish it soon.


bash script version watchdog

Try to use bash script to implement factorio version check
Before merging this PR, you need to create a token that can be written to this project at https://github.com/settings/personal-access-tokens/new and configure it into the REPO_TOKEN secret so that GitHub Action can trigger docker builds
ref #459

Added REPO_TOKEN

Is there more that needs to be changed, and if not maybe consider merging?

@KagurazakaNyaa Thanks for adding an update solution via github actions, it looks like a very good option which is also more transparent then my solution before.
The jobs are running for up to 20secs which looks good based on the free pipeline quota.
Sadly i am not that familiar with the github actions, so i didn't remeber about the schedule option.
Thanks again for this PR, i think that will make a lot of people happy.


Bug 1924472: Tag gogo/protobuf to v1.3.2

/bugzilla refresh

/bugzilla refresh

/retest

@joelddiaz Well this wasn't as straightforward :cry:

Fixed in https://github.com/openshift/aws-pod-identity-webhook/pull/136


Add note that crate can compile assembly.

Closes #193. I tried to keep the brief summary style of the rest of the main crate doc. If you would like me to include an example I can do that, I just need a place to put them. The top of the crate docs didn't seem like the right place.

Thanks!