connectedCallback of child element is called after connectedCallback of parent

If custom element A contains child Custom Element B,
connectedCallback of A is called before B.
With lit-element 0.5.2, B was called before A.
(I believe the correct behavior is that B should be called before A)
Live Demo
With v0.6.2: https://jsfiddle.net/shihn/9yjt50k4/1/
With v0.5.2: https://jsfiddle.net/shihn/bjn5ko3m/4/
(Look at the console logs)
Browsers Affected
All, afaik
Versions

lit-element: v0.6.2

I'm not sure if there's anything in the spec guaranteeing the order - as these components should deal with their lifecycle independently.  (I know that older lit-element and Polymer 2.x components behaved the same way. child called before parent.)

I think the root here is that render happens asynchronously after connectedCallback which wasn't the case before.
It seems we should only use lit-element lifecycle callbacks (the native callbacks have less  meaning)?

Blabbering on...
firstUpdated is also called in the parent before the child.

Sorry for the delayed response. There's no spec issue here. An element's connectedCallback is called when it's appended to the document and this is whenever the code appending the element runs. For elements within a LitElement's shadowRoot, this occurs when LitElement updates and renders.
In version 0.5.x rendering was done synchronously in an element's connectedCallback. As of version 0.6.x rendering is asynchronous after an element is connected. This change was made for consistency, since LitElement generally renders asynchronously.


feat(ingest): indent sql queries for redshift usage

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Just curious why this feature is required. Isn't it better to perform indentation on the read side rather than ingestion side?


[Workers] Remove per-worker cron limits

There is no longer a limit on the number of cron schedules per worker
The limit on total cron schedules per account still applies

Thanks Max! Could you also add this to the changelog: https://developers.cloudflare.com/workers/platform/changelog/

This is awesome. 👏 @maxwellpeterson


Pokemon White 2 EU vs USA

Hi,
i've been trying to connect to ALTWFC(pokeclassic.net) and to do it i've needed AR code from your program. Currently I play pokemon white 2 European Ver., but only found rom from USA. I can open Nintendo wfc setting so it seems that code works fine, but i can't connect to server and it shows error 20100. Question is there difference between those game? sorry for my really bad English;)

Pokémon Black, White, Black 2 and White 2 use the same ROM file for the North American and English European version cartridges. So, a code generated for White 2 US will work for White 2 EU, provided that it's the English language version. If it's not the English version of the game, you will need to generate the code for that game specifically.
If you have a device that can run DS homebrew, you should use Wood Dumper to dump your own cartridge's ROM file and generate your AR code. You can also find a list of some codes (including White 2 EU English) on Pokémon Classic Framework issues page at mm201/pkmn-classic-framework#11.

I consider that I have to dump my cartridge, but if you say that US and EU is same rom, so it should work (My version of Pokemon White 2 is English language version, so it is useless to buy that tools). Despite that it is same version and I opened port that are recommended on Pokemon Classic Framework. Actually it helps, becouse earlier coudn't even save connection setting now I can do it and even when connection is tested it shows that works, but when I want to connect to WFC in game i just wait wait and it stops and shows same 20100 error. Thanks for respond and advice.

Have you tried the troubleshooting steps listed here? 20100 can also mean that you haven't set the DNS settings correctly.

Prof9 of course I set up right DNS address. I was fighting with this 2 days, and finally found solution. It was all about port forwarding. Actually, I haven't forwarded UDP Ports, becouse there it was written, forward all traffic in all destination. Didn't know what to do, so I left it. Then after 2 days of looking for solution, new codes, and other stuff, I went back to those UDP, couse i didnt know how to forward all ports(there is over 60k ports), was looking for something and found DMZ Firewall and it helped. And here's brand new story. I and my firend we traded some mons from Pkmn White2 and Pkmn White. His White ver. is rom on flashcard, and he just run this game with NoSSL code and it works fine, but then, he tried to connect on original Cartridge of Platinum, Heart Gold, even Black 2 and couldn't connect to GTS. That's wierd, we don't know what to do.

Glad to hear you got your issue resolved. I wasn't aware that not setting up port forwarding properly could lead to a 20100 error. As for your friend, was he just not able to connect to the GTS or was he not able to connect to any WFC services at all (trade, battle etc.)?
For Platinum and HeartGold, the US and EU versions use different ROMs IIRC so the NoSSL codes for those games may not be interchangeable between regional versions. Additionally, each of those needs its own NoSSL code (i.e. you can't use the one from White 2 for them). Which versions was he trying to use?

Sure, we know that there's difference between White 2 and Platinum or HG, of course we used different codes. Let me explain his problem(and my) from begining. After my problem's gone we traded between my Pokemon White 2(original cartridge at 3ds xl) and his White 2(rom in r4 at regular DS) and it's worked fine. Then He tried to connect to GTS in Platinum, Heart Gold and Black 2, all of them are in original cartridge and he couldn't connect. What's wierd that then he tried to connect in Platinum at r4 and it's worked! That's wierd and we don't know what to do...


[DNM] De-underscore @frozen, apply it to structs

Implementation for this pitch.
This leaves classes and vars with @_fixed_layout for now. It also seems like leaving the compiler using the term "fixed layout" internally makes sense.
I've added some tests for the old names, but migrated most of the tests to the new. Not sure if more tests of the old names are merited.
IHaveNoIdeaWhatImDoing.gif, sorry if this doesn't match some conventions.

Oops, can you make a PR a draft retroactively?

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 0fe74e65881e27ab3238da6b7c1e6ff14ae947d8

Build failed
Swift Test Linux Platform
Git Sha - 0fe74e65881e27ab3238da6b7c1e6ff14ae947d8

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 0fe74e65881e27ab3238da6b7c1e6ff14ae947d8

Build failed
Swift Test Linux Platform
Git Sha - 0fe74e65881e27ab3238da6b7c1e6ff14ae947d8

@swift-ci please test


Add EVP demo for Poly1305 demonstrating Poly1305-AES

Fixes #14122.

@t8m Done.

@paulidale still OK?

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to both, thanks.


heaphook: roadmap to stable debian package

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
I've developed https://github.com/tier4/heaphook to resolve the performance bottleneck caused by the heap allocation (See https://github.com/autowarefoundation/autoware/discussions/3274).
When Autoware is distributed as Debian packages as discussed in https://github.com/autowarefoundation/autoware/issues/3222, as many ROS packages as possible should be installed as Debian packages from the Autoware side to reduce the build time burden.
Since heaphook is still under development, I'd like to first add it to autoware.repos, and show here the roadmap until it is eventually installed as a Debian package.
Purpose
Provide heaphook as a Debian package for Autoware.
Possible approaches
The following significant changes are expected to be made to heaphook.

Design changes to make it easier to add new memory allocation algorithms (separation of policy and mechanism)
Add new memory allocation algorithms
Major API changes (currently, a so file with different names for each memory allocation algorithm are specified directly in LD_PRELOAD, but this may change in the future)
Performance evaluation and resulting changes

After the development gets stable, provide heaphook as a Debian package for Autoware.
Manage heaphook packages as discussed  in https://github.com/autowarefoundation/autoware/issues/3222.
Definition of done
Development of heaphook gets stable and stable versions are distributed as Debian packages.

With the release, I am closing the issue.
It is possible to perform sudo apt install ros-humble-heaphook right now.
https://github.com/ros/rosdistro/blob/master/humble/distribution.yaml#L2326-L2340


Create ERD for reporting

Describe the task
In order to ensure that we account for everything CAS internal need from reports, we need an entity relationship diagram. BA have offered to go through this process together. Ideally we will have someone who is intimately familiar with the existing requirements and formats of SWRS, as well as someone with expertise on CIIP. We need to agree upon the entities needed to wholly capture the information required in an emission and compliance report. This will include the structures already in the Registration module.
As a part of this process, it would be a good idea to establish how Moose Giraffe and BA will communicate when changes need to be made to the resulting model.
Acceptance Criteria

[ ] Clear definition of the end state (what exactly we need in order to assess the report) of all types of report (If_a/b/c, SFO, LFO, New entrants etc)
[ ] Business Area and DST are in agreement on the entities needed for reporting
[ ] Working ERD exists representing these structures

Definition of Done

[ ] The entity relationship diagram representing the data needed to assess reports is accessible to all who need it
[ ] Process for making / requesting updates to the model are in place and documented

Blocking

#14

@mikevespi given the amount of work required for this I'm wondering if we can break this down into sprint-sized chunks of work. Thoughts?
I will create a ticket to capture the first part of work that IRC is doing to go through the SWRS spreadsheet as I believe that blocks much of this ticket's work.

@mikevespi to break down into more discrete pieces

Breaking it down

emissions (including mandatory extra fields from WCI/regs)
production
annual report section 2

Broken down into #227 and #228 .
Will discuss at refinement if we need a card for annual report section 2.


Incorporate CI/CD in options in project build + docs

Is your feature request related to a problem? Please describe.
Today the generator assumes you want to deploy the project to an Azure web app using the included .deployment file. This doesn't account for other deployment options (to other platforms or using Azure DevOps).
Describe the solution you'd like
Option in the generator to prompt "do you to deploy to Azure web apps?" or "do you want to deploy using Azure DevOps?" in the long term. These options would add either a .deployment or azure-pipelines.yml file to the root.
But in the short term, I propose the following to ensure the process is solid:

[ ] remove .deployment file from the generator
[ ] add docs on "How to deploy to Azure web apps" that explain how to add the .deployment file
[ ] add docs on "How to deploy with Azure DevOps Pipelines" that explains how to set it up by adding a azure-pipelines.yml file and configuring a pipeline

Down the road, we can add the options to the generator that can add these files to a project, either a new project or an existing project
Feel free to assign to me

Can anyone provide basic steps to getting this to work with CI/CD? I've got my pipelines yaml all setup and it's generating the zip archive for deployment, but it appears to only be serving the raw HTML pages after deployment. None of the express routes defined in server.ts for the SSO are available, and whenever I try to run node server.js manually through Kudu, I get an error saying express isn't found, even though it is part of the package.json. I suspect I'm just missing some silly little piece, but I can't get it to work :-(.

@webdes03 this is a pipeline I use for Azure DevOps
variables:
  vmImageName: "ubuntu-latest"
  tag: "$(Build.BuildId)"
  appName: "my-teams-webapp"
  subscription: "Microsoft Azure Enterprise(00000000-0000-0000-0000-000000000000)"

trigger:
  - main
  - dev

stages:
  - stage: Build
    displayName: Build and package
    jobs:
      - job: Build
        displayName: Build and package
        pool:
          vmImage: "ubuntu-latest"
        steps:
          - task: NodeTool@0
            displayName: Use Node 12.x
            inputs:
              versionSpec: "12.x"
          - script: |
              sudo curl -sfL https://install.goreleaser.com/github.com/tj/node-prune.sh | sudo bash -s -- -b /usr/local/bin
            displayName: Install node-prune
          - script: |
              npm install
            displayName: npm install
          - script: |
              npm run build
            displayName: npm run build
          - script: |
              npm prune --production
            displayName: npm prune
          - script: |
              /usr/local/bin/node-prune
            displayName: execute node-prune
          - task: CopyFiles@2
            displayName: Only publish files needed for runtime
            inputs:
              SourceFolder: "$(System.DefaultWorkingDirectory)"
              Contents: |
                dist/**
                library/**
                package.json
                node_modules/**
              TargetFolder: "$(Build.ArtifactStagingDirectory)"
          - task: ArchiveFiles@2
            inputs:
              rootFolderOrFile: "$(Build.ArtifactStagingDirectory)"
              includeRootFolder: false
              archiveFile: "$(Build.ArtifactStagingDirectory)/$(appName).zip"
              archiveType: zip
          - task: PublishPipelineArtifact@1
            inputs:
              targetPath: "$(Build.ArtifactStagingDirectory)/$(appName).zip"

  - stage: Deploy
    displayName: Deploy to App Service (dev)
    dependsOn: Build
    jobs:
      - deployment: deployDev
        displayName: "Deploy to dev"
        environment: knok-dev
        strategy:
          runOnce:
            deploy:
              steps:
                - task: DownloadPipelineArtifact@1
                  inputs:
                    downloadPath: "$(System.DefaultWorkingDirectory)"
                - task: AzureWebApp@1
                  inputs:
                    azureSubscription: $(subscription)
                    appType: "webAppLinux"
                    appName: $(appName)
                    runtimeStack: "NODE|12-lts"
                    startUpCommand: "node dist/server.js"

Awesome, thanks @wictorwilen, I'll give this a try.

As we've removed the "old Azure git deploy stuff" from V3, should we close this one? And, an example of deployment using Azure DevOps is documented here: https://www.wictorwilen.se/blog/deploying-yo-teams-and-node-apps/.


Remove multi on the Redis adapter for removing a feature

multi fails on a cluster set.
Fix #451
See https://github.com/jnunemaker/flipper/issues/450#issuecomment-561702603

Hi @jnunemaker - thanks for merging this!
Do you have an ETA for the next release including this change?


Support for multiple instances of same object class

Is it possible to train the network on a dataset with multiple instances of the same object class? I've tried to adapt the code to my own dataset but I'm unsure how to handle multiple instances of the same object.
Best regards, Mikkel

It requires some modification to deal with multi instances in one scene using our full models:

For data preprocessing, the semantic label is kept still but the center and keypoint offset map should be modified. Specifically, take the center offset map as an example, it should be updated per-instance rather than per class here.
The training scripts can be kept still.
For inference:

The PyTorch Cuda version of the MeanShift algorithm we implemented here only output one cluster center (one instance) for each class. It should be modified to output multi-instance clusters. Or you can use the skilearn version on CPU.
After each instance cluster is obtained, the following keypoint and pose estimation procedure (After here) also need to be modified accordingly to output the pose parameter of each instance.

Another way is to utilize on-the-shelf instance segmentation/detection architecture to obtain the RoI of each instance and then cropped them out to train our pose estimation network. In this case, you can shrink the network of FFB6D, eg, replace ResNet34 with ResNet18 to speed up the network.

For data preprocessing, the semantic label is kept still but the center and keypoint offset map should be modified. Specifically, take the center offset map as an example, it should be updated per-instance rather than per class here.
Thanks for your answer. I tried to modify my data loader class according to your instructions. However, when I start training, I get this error:

RuntimeError: stack expects each tensor to be equal size, but got [6, 3, 4] at entry 0 and [5, 3, 4] at entry 2
I think the problem is that the number of instances differs from frame to frame, e.g. there may be 6 instances in one frame but only 5 instances in another. How do I deal with this issue?

Has this problem been solved?Who can share this code or more detailed suggestions?

I'd also like to know if this has been solved :)

Hi, can someone point me towards correcting the code to output poses for all objects in the scene?


[ci.yaml] Add recipe revision property

This enables us to track what version of the recipes is rolled into the repo at the time.
This will enable us to know what flutter/recipes revision to use in this ci.yaml. This removes the need to branch flutter/recipes, which is a best estimate.
The work required here is to add a skia autoroller that can roll the revision in the ci.yaml, and update the ci.yaml starlark configs to pass this value in flutter/infra.

@CaseyHillers would this still be needed if we can branch the recipes and pass the ref directly to the buildbucket apis?

@CaseyHillers would this still be needed if we can branch the recipes and pass the ref directly to the buildbucket apis?

No.
We'd instead rely on the branch ci.yaml is from to set the version of the recipe bundle.

Awesome, I'll go ahead and close it. Thanks!


⚠ Bofrost.fr has degraded performance

In dc85c21, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 935 ms

Resolved: Bofrost.fr performance has improved in c980fe9 after 14 minutes.


MSBuild ignores assembly binding in web.config

I've the same problem as described here: http://stackoverflow.com/questions/34271216/msbuild-step-in-teamcity-considers-app-config-instead-of-web-config-for-asp-net
and here
http://stackoverflow.com/questions/34292288/how-does-msbuild-finds-bindingredirect-attributes-for-asp-net-projects
When executing MSBuild on our build server it shows me the warnings. When executing MSBuild on my dev machine (Visual Studio installed) the warnings won't show up.
How should I configure our build server to retrieve the binding redirection information from the web.config instead of from the app.config?

Maybe this is the same problem: https://social.msdn.microsoft.com/Forums/de-DE/70c0753c-a644-4463-a830-1637bec27cf6/visual-studio-tools-version-14-tv140-throws-microsoftcommoncurrentversiontargets-error-on
Do I need install the Microsoft ASP.NET and Web Tools 2015?

In our project we just store copy of required files in repository, because I'm not a fan to install a lot of prerequisites just for build.
We copied those two folders:
c:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\WebApplications
c:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\Web
and changed path to c:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\WebApplications\Microsoft.WebApplication.targets to new location.

Thanks. That helped me.
But this is just a workaround for this issue.

It looks like installing the ASP.NET workload is the right fix for this problem.


LocalTransaction: Try to address the flakeyness of the test

Looking at the test, it seems to be the same cause as @hewison-chris has been fixing all over the code base, so giving a try to the same solution.

@Geod24 can I update this one. I think I need the fix now in a different PR.

Sure

Tested locally and works well. I'll merge it.

Superseded by https://github.com/bosagora/agora/pull/2397


Can't Read or Change Site's data

Describe the bug
The extension icon is grayed out and says "Can't read or Change site's data". I've tried quitting and re-opening chrome, not working. I've also tried Chrome Canary and Firefox, all with the same issue.
To Reproduce
Steps to reproduce the behavior:

install GraphQL Inspector chrome extension
Click on extension icon

Expected behavior
Not grayed out, and show a tab in the developer console.
Screenshots

Desktop (please complete the following information):

OS: macOS 13.1
Chrome Version: Version 110.0.5481.100 (Official Build) (arm64)

This is not a bug. You can only use this extension by opening the DevTools and click on the "GraphQL Network" tab:

I think this is not the first time people are saying this. I believe we should update the readme to explain how this extension works.

Ah, I see; there is a "GraphQL Network" tab.

I'll update the readme. Thanks for raising!


Test Issue created at Sat, 11 Dec 2021 02:22:19 GMT

Test issue body  Sat, 11 Dec 2021 02:22:19 GMT

Comment on issue at Sat, 11 Dec 2021 02:22:22 GMT


DeleteLine command for text editors

By Ctrl+Y, current line should be removed

Ctrl + Enter, editor should append empty line after current line


Add 4.0.0-beta3 development build

LGTM just if you want to add bitcore-testing-legacy-cpu to Building locally section under Readme file

Done


feat: support using tsconfig files for compilerOptions

Summary

Adds support for resolving a tsconfig file for compilerOptions with support for extends through the use of tsconfck.
Fixes converting the raw compilerOptions from a json file, including docgen.json, and converts them into the format that ts-morph/typescript expects of ts.CompilerOptions.

Details
I'm working on creating a monorepo based on @effect/platform, but with 19 different packages, and I'm finding that the repetition is quite a lot to write and maintain. Being able to utilize extends would be really helpful to minimizing duplication.
Additionally, things like "moduleResolution": "node" leads to runtime errors with the current compilerOptions provided to ts-morph since they are not converted to the corresponding enums defined by TS. Becomes a lot more noticeable when you're reading from tsconfigs which likely define more options.

@TylorS thanks!


Create a ESM build for node

Fixes #89
It fixes the XMLHttpRequest is not defined error when "import"ing (versus "require"ing) library from node. We now have 2 ESM in the dist, one for node, one for the browser. Quick reminder on why there are 4 files:

browser: archethic.js (UNCHANGED)
browser import: archethic-browser.mjs  (RENAMED)
node import: archethic-node.mjs (NEW)
node require: archethic.cjs (UNCHANGED)

I tested with the TransactionBuilder (browser import) and the AEWeb CLI (node import).
No code change required anywhere.

Added a small example to demonstrates how to use the archethic.js without any build system


Expose a C-API for legacy bare-metal systems

Is there a way to condense the smoltcp API so that it could be exported as a C library?
With the design goals stated in the readme, this library seems particularly well suited for embedded systems, and considering the mess that is LwIP, I think it could be interesting to use smoltcp (which is extensively tested and fuzzed) as the TCP/IP stack instead of LwIP or other C-based TCP/IP stacks.
Example use case:

FreeRTOS running on a microcontroller
Uses LwIP on a seperate task for networking, does a bunch of heap allocations within FreeRTOS

With the design goals stated in the readme, this library seems particularly well suited for embedded systems, and considering the mess that is LwIP, I think it could be interesting to use smoltcp (which is extensively tested and fuzzed) as the TCP/IP stack instead of LwIP or other C-based TCP/IP stacks.

This was the original goal of smoltcp: replacing lwIP. At the very beginning, I've been thinking about such a C API. However, as work went on, I've started to doubt that an ergonomic interface would be easy to build, and it also didn't seem so urgent for other reasons.


Fix for TAF v5.8.0 : no store-dir to non-existing variables

After PR #683, variable "OmegaC" is only available when DIC_CALCITE_SAT is defined (never used otherwise), but CPP has not been updated and this store dir now applies to undefined "OmegaC" when DIC_CALCITE_SAT is undef.
Remove storage since DIC_CALCITE_SAT code has never been tested in TAF adjoint set-up so a) might not be needed but b) other storage dir might be.

What changes does this PR introduce?
Remove TAF storage dir for non-existing variables
What is the current behaviour?
These storage dir were just ignored by TAF until version v5.7.7
What is the new behaviour
With version 5.8.0, these wrong storage dir cause an error.
By removing these wrong storage dirs the TAF errors are gone
and the code is cleaner.
Does this PR introduce a breaking change?
No.
Other information:
Suggested addition to tag-index
o pkg/dic:

remove TAF storage dir for variable "OmegaC".

@mjlosch Thanks !
It seems that this was the only place where a TAF storage-dir was applied to an non-existing variables (but I remember not that long ago removing other like this one):
with version 5.8.0, only tutorial_dic_adoffline & tutorial_global_oce_biogeo show an error (http://mitgcm.org/testing/results/2023_03/tr_villon-b_20230315_0/), and this goes away with this fix.
And also tried with new version global_oce_cs32 from verification_other and it's fine.
Going to merge this PR soon (so that tonight testreport will run these 2 exp).


Add update mechanism for :penguin:

Temporary(?) solution to #2956 while better solution is discussed.

This PR is a good shot at fixing the single biggest issue on Linux. It has now been tagged "needs-review" for almost a month. Any chance of speeding up the review process so there can be progress on this issue?
The way I see it, while the approach of trying to identify the distro and then downloading packages is not pretty, it's the only way to move forward given the circumstances. There is one – and only one – proper way to install and update packages on Linux: From repositories. If the Atom team is unwilling to create official aptitude/yum repos, the "semi-manual" approach is the next best thing. Using third-party repos is simply not an option in many environments due to security concerns.

This would be great to have. I hope it gets merged soon.

Has it been reviewed at all? There are no comments to this effect...

@Zireael07 I can't really attest to the functionality of this fix as it was only tested on two local builds and I didn't really care to mess with CoffeeScript's syntactic bull.  I think the only part that really needs "reviewing" is the decision of whether or not to continue using the release channel for updates or to make use of a ppa (as we await a response in #2956).
In my personal opinion, the update process should be automated regardless.  I might push a commit later today to touch up some things and make it more likely to be implemented.

Passes unit tests now.
As a side note, this is why I generally dislike CoffeeScript (see a6d4b91 d9c68a4)

The linux packages are only for 64-bit right now, but I'm fairly certain that 32-bit users can build it manually and run Atom (possibly pinning it to a release version and enabling updates).  If so, that should be addressed in the auto-updater so that it doesn't try installing 64-bit builds on 32-bit machines.

... I'll just wait for the official repositories

Thanks @stanier for all your hard work on this. We talked this over and we're not comfortable with supporting a partial solution like this. We're still planning on having support for the official repositories. I don't have an ETA on when that will be accomplished right now though.
Thanks again for driving this!


Remove redundant requirements.txt

requirements.txt is typically used by pip to install a dependency set. We use poetry so the requirements.txt is redundant.

requirements is used so netlify will install poetry in their runner environment.

I think all the other files can be removed though.


Basic ReplacePathWithStrokedPath Implementation

This initial implementation leverages cairo_copy_path_flat that returns a
copy of the current path with all line elements. The underlying elements
for the path may be drastically different because all the curves will be
replaced by line elements. Everything else should be similar to iOS
behavior, such as order of the points, so functionality like an animation
along a path should behave in a similar fashion.
Endcap styles are supported. Line join styles are not yet implemented.

Hi @tcunning, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@bdrlamb-ms is added to the review. #Closed

@jaredhms is added to the review. #Closed

It is important to have some unit tests for this API.  Granted, it won't behave same on reference platform, but will be helpful to catch regressions if we make changes in the future.

The last push was to address some of the feedback for the CGCatalog example.

@rajsesh-msft I committed the current state of the looping implementation with d28fbc781becf0d6e48c0292343a56e839de9158. This should be in a similar state as the recursive implementation we had earlier.

:clock1:

Given our plan to move to D2D for coregraphics, we can get D2D to do this instead of hand rolled implementation.  Closing this PR as such.


fix: properly close the symbol table on shutdown

Current dependencies on/for this PR:

main

PR #65   👈

This comment was auto-generated by Graphite.


[FLINK-23190][runtime] Make schedulers allocate slots more evenly

What is the purpose of the change
Flink does not really do a good job at distributing the tasks uniformly across the taskmanagers of the cluster.
The reason is that there is no strategy for spreading out the tasks, they are simply assigned to the next available slots. This PR improves this by simply sorting the available slots in a way that slots from different TMs are interleaving as evenly as possible.
This works for both the the Default and Adaptive scheduler. The new behaviour can be turned on and off by a new config.
Verifying this change
New unit tests have been added.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not documented

cc @dmvk @zentol
I would love to hear your thoughts on this (and the problem in general). I opened this as a draft because it feels a bit hacky but it seems to solve the task imbalance in practice for both the default and adaptive scheduler.

In the context of the auto scaler, my first thought is that if this improves things for you, it signals a lack of "vertical scaling" awareness. If we could approximate the required resources for each allocation, this becomes a bin-packing problem that could be more robustly addressed with fine-grainer resource management.
I think you've also mentioned that this helps when slot sharing is enabled, is that correct?

@dmvk a bit more context on this.
First of all, this fix did not come about in connection to the autoscaler, we have been actually using this for quite a long time (long before the autoscaler work). So I would say this is a long standing issue in Flink and independent of the autoscaler.
The JIRA description illustrates the main problem when we have multiple operators with very different parallelism settings in the same slot sharing groups. The more different parallelisms there are in the same slot sharing group the worse the imbalance gets.
Because of the different parallelisms tasks in the slot sharing groups would be of very different sizes, lets say op1 - 4 have all different parallelisms but are in the same slot sharing group. Then we have 4 types of tasks:

OP1, OP2, OP3, OP4
OP1, OP2, OP3
OP1, OP2
OP1

It stands to reason that 1 is the heavies, 2 is less heavy, 3 is eaven less, and 4 is the cheapest to execute. But still it will likely happen that TM1 will get only of tasks 1, ... and the last TM will get some from 3/4.
So some TMs will work much more than the others.

Got it, so the problem starts when you combine slot sharing + per-vertex parallelism
I'll think about that.


Fixed Make file to make it build and updated the version number of…

Fixed Make file to make it build and updated the version number of the project. I also updated the error handling of the OKHttpNetwork Handler to work the same in no network situations for iOS and Android.

Fixed @djlewisxactware


Fix Docker metadata labels in prebuilt images

The prebuilt Docker images for releases do not include all the metadata one would like. See here, for example: https://github.com/praetorian-inc/noseyparker/pkgs/container/noseyparker/137062442?tag=v0.15.0. No labels!

You could also include a sha512 sum of the image as a label, version, etc.?

I thought I had fixed this issue in c43334c066aa9d048ab465473c439baf5ec5f9d8, but it turns out I did not. I manually re-ran the Release Artifacts workflow, and its multi-architecture Docker image still comes out with missing labels!
It sounds like this is a bug or limitation in the build-push-action, specifically with regard to multi-architecture images: https://github.com/docker/build-push-action/issues/846#issuecomment-1546123964
In another project, they worked around this by manually merging the single-architecture Docker image manifests: https://github.com/dbschenker/vaultpal/issues/31
Fixing this deficiency in Nosey Parker will require some more work, probably a manual merge of manifests. It may make sense anyway to manually merge single-architecture Docker images, as the overall Docker workflow could be drastically sped up that way (instead of using qemu to build the ARM64 image, we could use the new M1 macOS runner, avoiding slow binary translation). See https://github.com/docker/build-push-action/issues/846 for inspiration.

A "fast" way to build a multi arch docker image that I found easier, is simply to use the 2 different build aka x86_64 and arm64 and then just 'publish' to the same container image repo. It should 'just work'. Havent' tried this with non docker repos though!

Be sure to use the same tag!


Ignore blank columns

Where a column header is blank, rather than it being given an arbitrary name fieldN and the column being included, it would be great if there was a way to ignore that column.

Thanks! @mcarans.


Add AppVeyor config to move away from Travis

Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:

[ ] Write/update tests
[ ] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1263 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1263   +/-   ##
========================================
  Coverage    94.48%   94.48%
========================================
  Files           72       72
  Lines         3738     3738
  Branches       740      740
========================================
  Hits          3532     3532
  Misses         104      104
  Partials       102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3725f00...3bc6f6c. Read the comment docs.


[Issue]: Controller and Webhook remain in pending

Problem Description
When deploying the gpu-operator on a Kubernetes cluster where the controlplanes are hidden such as in a Managed Kubernetes environment the controller and webhook pods remain in pending.
The pods are unable to schedule because of the node affinity rules in the default values:
  nodeAffinity:
    nodeSelectorTerms:
      - key: node-role.kubernetes.io/control-plane
        operator: Exists
      - key: node-role.kubernetes.io/master
        operator: Exists

https://github.com/ROCm/gpu-operator/blob/main/helm-charts/values.yaml
There doesn't appear to be any reason why these pods require a controlplane versus just targeting a non-gpu node. It would be better if those values are recommended in install instructions versus being forced in the default values.
Operating System
Ubuntu
CPU
AMD Epyc
GPU
AMD Instinct MI300X
ROCm Version
ROCm 6.2.3
ROCm Component
No response
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Hi @happytreees thanks for using AMD GPU Operator, Please take a look at the example values.yaml of our helm charts at https://github.com/ROCm/gpu-operator/blob/main/example/helm_charts_k8s_values_example.yaml where we defined the template for specifying nodeAffinity and nodeSelector for related resources.
Specifically, if you want to remove the nodeAffinity, you can modify them in the values.yaml to be:
  nodeSelector: {}
  nodeAffinity:
    nodeSelectorTerms: []

you can configure it for AMD GPU Operator controller manager, KMM controller manager and KMM webhook separately. Then use the new values.yaml  in the -f option with your helm install command.
helm install xxxxxx -f new_values.yaml
We will discuss the default values in  values.yaml for the next release.

thanks for the suggestion @happytreees , we will discuss and provide a fix in the future releases.


[SR-184] Better diagnose error via unwrapping optional before initialized.

Added a check for whether the escape use is due to an UncheckedTakeEnumDataAddrInst, which accesses the memory to grab the .Some part of an Optional during “?.” or “!”. In that case, use the
generic used-before-initialized diagnostic, since it isn’t actually because of closure capture.
Added test cases, including specifically testing that capturing in a closure in order to unwrap the optional is still ok.

Tests pass! I initially thought that the last-resort else here might just be mistaken, and should be the generic used-before-initialized diagnostic instead, but that fails definite_init_diagnostics.swift:65 (capturing an Int to increment it before initialization). So added the more specific check for unchecked_take_enum_data_addr instead.

Oh, and would be happy to add a more specific "optional unwrapped before initialized" diagnostic if that sounds like a good idea. The existing "used before being initialized" seems accurate, if inexact, and I think is quite clear enough.

@rudkx Looks good to me.

Nice!


Removing unused code and extra spaces for all pages

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
these codes were making the code unnessarily big i fixed it
Fixes:  #639

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@sk66641 please review and merge this pull request before 7 pm

@sk66641 only 1 hour left please merge this pull request


add missing parts to machine sim

screws
gears
belt
pen
servo

@Sheepy3 can you provide us with these models so we can add them to the website

repairing assembly in onshape. so far:
-updated carriage with eccentric spacers
-added missing screws to upper rail
-updated pen holder with eccentric spacer

no longer using machine sim?


Heroku button for each demo

https://devcenter.heroku.com/articles/heroku-button
Here's how you get user-set configuration:
https://github.com/cobyism/ghost-on-heroku/blob/master/app.json

This issue was moved to Dallinger/Dallinger#81


fix: utilization should not affect reserved charge type

PTAL

@LiuJi-Jim PTAL

Solved conflict, noting changed.
PTAL


If you use the Fast Configurable 2 Sided shader texture works only with initial texture

If you use the Fast Configurable 2 Sided shader, don't set an initial Texture and try to set it runtime it will not display the texture
Workaround - set a dummy texture at startup . Any texture. Just make sure there is a startup texture.

I would recommend using the new MRTK/Standard shader with the "Cull Mode" set to "Off" for two sided materials.

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Master

Your sheet.json is missing the commas to make it a valid JSON. This is an easy fix, so I will do it myself, but you will have to be sure to pull down my changes or you'll run into merge conflicts if you try to make more changes.


Add missing comma

See https://github.com/davidyell/CakePHP3-Proffer/pull/177

Ace, thanks very much.


Update Existing Message Using Incoming Webhook

Description
From what I understand you can only update an existing message with the Option 2 i.e. Technique 2: Slack App. Is it possible to do the same with incoming webhook? If so how
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @ShahroZafar, thanks for asking the question! Unfortunately, it's not feasible to do the same with incoming webhooks.

Hi @seratch. Thanks for the reply.
I ended up using the Technique 2.


bfs is not an Arch Linux package

The README says pacman -S bfs may work, it doesn't.

Forgot to update, congrats on becoming an official package :)


fix(wsdl): improve dark mode

Will fix #5
Light mode look now like this

And dark mode like

Looks good! 🚢


Disable libarcher tests on Debian

Can we please disable libarcher tests on Debian? They routinely fail to the point that it's hard to trust CI pipeline results because we need to continually remember that these are unrelated failures.
Failed Tests (17):
--
  | libarcher :: critical/critical.c
  | libarcher :: parallel/parallel-firstprivate.c
  | libarcher :: races/critical-unrelated.c
  | libarcher :: races/lock-nested-unrelated.c
  | libarcher :: races/lock-unrelated.c
  | libarcher :: races/parallel-simple.c
  | libarcher :: races/task-dependency.c
  | libarcher :: races/task-taskgroup-unrelated.c
  | libarcher :: races/task-taskwait-nested.c
  | libarcher :: races/task-two.c
  | libarcher :: reduction/parallel-reduction-nowait.c
  | libarcher :: reduction/parallel-reduction.c
  | libarcher :: task/task-create.c
  | libarcher :: task/task-taskgroup.c
  | libarcher :: task/task-taskwait-nested.c
  | libarcher :: task/task_early_fulfill.c
  | libarcher :: task/task_late_fulfill.c

(For reference, this has come up in the following randomly-selected reviews: https://reviews.llvm.org/D102343, https://reviews.llvm.org/D106302, https://reviews.llvm.org/D105951, https://reviews.llvm.org/D102728, and basically every other review I've seen in the past few months.)
Thanks!

@AaronBallman do you know by any chance it's possible to disable test with cmake / ninja args? Also, maybe we should fix those tests?

@metaflow -- I have no idea if they can be disabled from cmake or ninja arguments (it took me a while to even figure out where to go to ask for them to be disabled; they're not in the llvm project tree that I've found). Fixing the tests would probably be a good idea though, if someone knows how to do that.

Seems to be controlled by LIBOMP_OMPT_SUPPORT : https://github.com/llvm/llvm-project/blob/main/openmp/tools/archer/CMakeLists.txt#L11

Thank you! I can confirm that this seems to be resolved now, so closing the report.

then I will re-enable openmp back


[Question] restore env when job fail

Hi @syphar,
I have a question regarding cache configuration. I have noticed that when the job running the action does not end successfully, the cache component is not stored. My suspect is because these jobs are skipped when the job fails

Do you think there is a way to tell the action to cache even if the job fails?
This is because I would like to cache dependencies always when I run my CI. Not just for success jobs

Hi @dtcMLOps ,
this is defined in the action here:
https://github.com/syphar/restore-virtualenv/blob/bb833b42c7eba4a9b92e1109bd9fe17500f8f894/action.yml#L9
the main reason back then was simplicity.
To keep in mind: you probably don't want to save the virtualenv when restoring the virtualenv failed.
I'm happy to review a PR, if you find a way to optimise this.

Hi @syphar,
I would suggest having that as an input parameter to the action, something like:
with:
 save-on-fail: true

That's a good idea, I'm happy to review a PR implementing this.

Regarding this

To keep in mind: you probably don't want to save the virtualenv when restoring the virtualenv failed.

When I am referring to a failed job, it means because it fails for something after the virtualenv, and installation dependencies, e.g.
My CI is as follows
[...]
In this case, the project dependencies and the dev dependencies are fine. The job is failing because of flake8. And every time I am running this job to validate flake8, the workflow is installing the dependencies.

From what I know the problem is that the action wouldn't be able to differentiate between a failure after restoring from a failure while restoring.


Incomplete HTML open comments are silently discarded

Consider the following two parser invocations:
cherow.parseScript('<!');
cherow.parseScript('<!-');

Expected behaviour:
I expect both invocations to fail with a parse error.
Actual behaviour:
Both succeed, returning an AST representing the empty program.
Background:
This behaviour is caused by a bug (indirectly) flagged by lgtm: https://lgtm.com/projects/g/cherow/cherow/alerts/?mode=tree&severity=warning&rule=7880096
The other alerts reported by lgtm may also be worth fixing. (Full disclosure: I work on lgtm's JavaScript analysis.)

Thanks for this. Will take a look soon.

@xiemaisi I couldn't find any Test262 tests for this? Do you know about any?  BTW. I clicked on your link, and looked at the 6 alerts. For line 869 where unicode line are flagged as never read is wrong. If I remove that line, the surrogate pairs will fail. The other warnings are fixed now.
I will try to fix the HTML comment issue soon as I'm done with something locale, or if you want to send a PR. It's ok too.

I couldn't find any Test262 tests for this? Do you know about any?

I'm not familiar enough with the test262 suite to tell whether there is a test. Maybe they just didn't think to add one?

I clicked on your link, and looked at the 6 alerts.

Thanks, I'm always grateful for feedback!

For line 869 where unicode line are flagged as never read is wrong. If I remove that line, the surrogate pairs will fail.

True, but the alert doesn't actually say that the entire line is useless; it's just that you don't need to assign the result of the call to code, since that variable isn't read before being overwritten. In other words, you can replace that line with this.peekUnicodeChar(), I think. (The rule help mentions this: "if the right-hand side has a side-effect, it is important to keep this to preserve overall behavior".)

The other warnings are fixed now.

Great! If you want to make sure they don't accidentally get unfixed, you could take a look at our CI integration: once you turn it on, every GitHub pull request against your repo is analysed and information about new and fixed alerts is displayed as part of the PR status. Here is an example of what it looks like in practice: Open-MBEE/MDK#132 (comment).

I will try to fix the HTML comment issue soon as I'm done with something locale, or if you want to send a PR. It's ok too.

No rush, I'm happy to wait for your PR.

Ok. I'm closing this now. The entire fix for this is up on NPM, not GH for now. It fails as expected. I also fixed the other alerts.
I will take a look at the CI soon as I find time. It's a great tool!


refactor: refactor functions over 100 lines and complexity over 20

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

@alexeldeib @cameronmeissner Here is PR2

stray mariner e2e failure?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

111 of 115 (96.52%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.646%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/agent/params.go
57
59
96.61%

pkg/agent/utils.go
37
39
94.87%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2480

Relevant Lines:
4023

💛  - Coveralls


speed up deployment

Speed up deployment: only build and deploy the changed branche.
Be eventual consistent by building and deploying all brances every night, including copying the main branch to the root.

Move branches.json to the root and load it dynamically so that the branch menu is always up to date.


Feat/joao flow improvement requests

Disclaimer: This review was made by a crew of AI Agents.
Code Review Comment for crewAI Flow System Changes
Overview
The recent changes in this pull request enhance the crewAI Flow system by introducing new routing capabilities and improvements to visualization across three main files: flow.py, utils.py, and visualization_utils.py. The efforts made here are commendable and I would like to highlight both the positive aspects and areas for improvement.
1. Flow.py Changes
Positive Aspects

The introduction of the enhanced router decorator allowing OR/AND conditions shows a significant step forward in routing flexibility.
Improved type checking and error handling enhances the reliability of routing logic.
The conditional routing logic is clear and well-structured, which is beneficial for future maintainability.

Issues and Recommendations

Router Condition Type Validation

The current validation logic could be more robust. Consider modifying it as follows:

if (
    isinstance(condition, dict)
    and all(key in condition for key in ("type", "methods"))
    and isinstance(condition["methods"], (list, tuple))
    and condition["type"] in ("OR", "AND")
):

This ensures clarity and thoroughness in the validation process.

Add Type Hints

The addition of type hints to the router function would greatly enhance code comprehension. Example:

def router(condition: Union[str, Dict[str, Any], Callable]) -> Callable:

Error Message Enhancement

Improving the error messages enhances debuggability:

raise ValueError(
    f"Invalid router condition: {condition}. Must be a method, string, or a "
    f"result of or_() or and_(). Got type: {type(condition)}"
)

2. Utils.py Improvements
Findings

The handling of return constants was refactored positively to avoid duplicates, which will aid decision-making in flows.

Recommendations

Dictionary Assignment Visitor Optimization

Enhance type checks within the DictionaryAssignmentVisitor to ensure rigorous validation of dictionary assignments.

Return Value Collection Enhancement

Recommendations for clearer handling in function source parsing:

try:
    source = inspect.getsource(function)
    code_ast = ast.parse(source)
except (IOError, TypeError) as e:
    logger.warning(f"Failed to parse function source: {e}")
    return None

3. Visualization Utils Improvements
Recommendations

Edge Style Configuration

Consider creating a configuration class for managing edge styles:

class EdgeStyleConfig:
    ROUTER_EDGE = {
        "color": "#2B7CE9",
        "width": 2,
        "arrows": "to",
        "dashes": True
    }

Position Validation Enhancement

Implement comprehensive validation of node positions before proceeding with visualizations:

def validate_node_positions(node_positions: Dict[str, Tuple[float, float]]) -> bool:
    return all(
        isinstance(pos, tuple) and len(pos) == 2
        for pos in node_positions.values()
    )

General Recommendations

Documentation: Ensure new methods have thorough docstrings and example usages to facilitate understanding for future developers.
Testing Coverage: Expand unit tests to cover all new features and edge cases surrounding routing and visualization.
Code Organization: Refactor logic into separate classes (e.g., RouterManager, ConfigManager) to improve modularity.
Performance Optimization: Investigate caching strategies for route resolution and optimize visualization rendering for efficiency.

Security Considerations

Validate inputs rigorously to safeguard against invalid router conditions and prevent potential configuration errors leading to runtime issues.
Implement safeguards for circular routing paths to avoid infinite loops during execution.

In summary, the changes implemented in this pull request significantly enhance the crewAI Flow system, but addressing these recommendations would further improve the codebase's robustness and maintainability.

@joaomdmoura Would you mind sharing these crew AI agents for  code review?


Fix Form Validation

On the data entry page, only Name and Type are required.  If either is missing, notify the user when the user presses save.
The optional fields should not hold up the saving.  It's ok to put in default values of 0 in places for now.

Name is required
Description should be blank if left off and not changed out to "UNSPECIFIED"


Control outside of the popover

I would like to leave the navigation control outside of the popover in a fixed div or in draggable modal panel.
Is anybody have an idea how it could be done?

You can build it yourself with your own html/css code and the methods prev(), next(), end(). See the documentation for the available methods list http://bootstraptour.com/api/.

Thank you, I did it. I thought to create a branch is someone could be intetested


Added support for non-English environment.

Added support for non-English environment by setting the language of Chrome to English.
The language of Chrome must be English regardless of the environment, because this tool can recognize only English.

LGTM


Call-site sometimes off-screen when clicking thru (Python) call stack

Type: Bug
I've hit an exception in my .py (line 155).
If I click through my call-stack frames, usually the code-window centers around the hilighted code-line. But sometimes it doesn't, and the hilighted line is off-screen.
Then I have to figure out which way to scroll the window to get it on-screen!
From playing around, I see that whenever the top item is selected, the NEXT item I click will ALWAYS fail.
And any clicks after that will be correct (even a second click on the same item)... until again the top item is clicked (which will again work, only the NEXT click after that will again fail).
I'll attach a video.

In case this is the case for others, here's a 720p version:
https://github.com/user-attachments/assets/fef61ef2-4070-4ee4-bd73-1a020b24283a
One thought: Maybe the calculation for where-to-scroll-to-next is getting messed up by the red "stack-trace" block, which is present only in the top frame.


napi_create_arraybuffer problem

I'm attempting to call napi_create_arraybuffer from https://github.com/nodejs/node-addon-api/blob/294a43f8c6a4c79b3295a8f1b83d4782d44cfe74/napi-inl.h#L1998.
However, writing to the memory pointed to by the output data void pointer does not correctly update the state of the arraybuffer in javascript.  I was able to successfully use napi_create_external_arraybuffer from emnapi by passing in the desired buffer during ArrayBuffer construction rather than mutating the allocated buffer after construction.
Any ideas what might be going wrong?  I didn't really understand the logic in emnapiExternalMemory.getArrayBufferPointer.  It appears to be correct if you want to read the buffer, but since it makes a copy, I don't see how it could properly provide write access to the caller.
According to the napi docs https://nodejs.org/api/n-api.html#napi_create_arraybuffer:
The underlying buffer is optionally returned back to the caller in case the caller wants to directly
manipulate the buffer. This buffer can only be written to directly from native code.

Thanks!

Actually this is a limitation (https://emnapi-docs.vercel.app/reference/list.html#arraybuffer-related), unlike in native, wasm code can not directly access V8 API so there is no way to "link" the memory of ArrayBuffer (managed by V8) to a char* buffer (wasm memory). you need to use emnapi_sync_memory from C/C++ side or EmscriptenModule.emnapiSyncMemory from JavaScript side to sync ArrayBuffer memory manually

Is there any way possible to malloc from the wasm heap the necessary memory and take a view as the ArrayBuffer?

https://github.com/toyobayashi/emnapi/blob/416fa06e992ed1f17ae0bbd760914ddcae3f9397/packages/emnapi/include/node/emnapi.h#L61

Fair enough.  I was hoping there was a way to simulate the ArrayBuffer since it would be easier to integrate emnapi into another external project without modifying their code to do the memory synchronization.  I'll work around emnapi's limitation instead.  Thanks!

I have also been wondering if there is a way to simulate an external ArrayBuffer, but the key problem is that the JS engine's memory and wasm memory are isolated from each other. What I can think of is to use WeakMap to associate the simulated ArrayBuffer and wasm memory, but when this simulated ArrayBuffer is passed to other JavaScript APIs, it will not work as expected, for example, new Uint8Array(simulatedArrayBuffer) will return the wrong Uint8Array.


Can it work on chinese ? how can I train my chinese text dataset  to use this?

wish reply

check issue #30

hi @gitathrun. Are you using python 2 or 3?

@jonnykira Firstly, thanks for your code on mlstm, very sleek and well formed tensorflow code.
No, I have not done any yet, but I will train a Chinese based model sometimes in the future.


Toolbar flash issue when using custom detents with nested NavigationStack

Description
When using a custom detent with PresentationLink and the sheet content contains a NavigationStack,
the sheet's toolbar briefly appears in the parent view's navigation bar. This issue doesn't occur
when using constant detents.
Reproduction Steps

Create a sheet using PresentationLink with custom detents
Add NavigationStack to both parent view and sheet content
Add toolbar items to the sheet's NavigationStack
Open the sheet
Observe the toolbar items briefly appearing in the parent view

Minimal Reproduction Code

@main
struct DemoApp: App {
    var body: some Scene {
        WindowGroup {
            ContentView()
        }
    }
}

// MARK: - ContentView

struct ContentView: View {
    // MARK: Internal

    var body: some View {
        NavigationStack {
            VStack {
                PresentationLink(
//                    transition: .sheet(detents: [.constant("constant", height: 250)])

                    transition: .sheet(detents: [.custom("custom", resolver: { context in context.maximumDetentValue * 0.25 })])
                ) {
                    SheetContent()
                } label: {
                    Text("Sheet (constant Detent)")
                }
            }
        }
    }

    // MARK: Private

    @State private var showSheet = false
}

// MARK: - SheetContent

struct SheetContent: View {
    // MARK: Internal

    var body: some View {
        NavigationStack {
            VStack {
                Text("Sheet Content")
            }
            .toolbar {
                ToolbarItemGroup(placement: .topBarTrailing) {
                    Button {
                        dismiss()
                    } label: {
                        Text("Done")
                    }
                }
            }
        }
    }

    // MARK: Private

    @Environment(\.dismiss) private var dismiss
}

https://github.com/user-attachments/assets/95fd14ec-79d9-4ac4-8862-11beeca9268e

Not able to repo, tested on device/simulator on iOS 18, simulator on iOS 17/18.
Are you able to repo in a particular simulator? Can you please share your Xcode version and iOS sim version

Not able to repo, tested on device/simulator on iOS 18, simulator on iOS 17/18.
Are you able to repo in a particular simulator? Can you please share your Xcode version and iOS sim version

Thanks for checking. Here's my environment info:

Xcode Version: 16.0 (16A242d)
iOS Version: 18.0
Device: iPhone 16 Simulator


[CI] stop MCAD build when first test case fails from ginkgo e2e test suite

Describe the Bug
MCAD build does not stop after the first test case fails.
Codeflare Stack Component Versions
Please specify the component versions in which you have encountered this bug.
Codeflare SDK:
MCAD: Main Branch
Steps to Reproduce the Bug
Run an E2E test case with an error in it.
What Have You Already Tried to Debug the Issue?
NA
Expected Behavior
MCAD build should fail when the first e2e ginkgo test fails saving build time.
Screenshots, Console Output, Logs, etc.
NA
Affected Releases
Main branch
Additional Context
NA
Add any other information you think might be useful here.

FYI @sutaakar @Srihari1192 @anishasthana


Add cross links to service API

You'll see that part of the diff is changing the target to html.  botocore/boto3 never set the target so it was defaulting to man page.  This meant that for certain style calls in bcdoc, the proper refs/links weren't being generated.
In order to use the new external_link method, the target needed to be html.
One option was to only turn on target html when generating html docs, but the man target doesn't make much sense for boto3/botocore.

Current coverage is 97.64% (diff: 100%)

Merging #1112 into develop will increase coverage by <.01%

@@            develop      #1112   diff @@
==========================================
  Files            44         44
  Lines          7013       7021     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6848       6856     +8
  Misses          165        165
  Partials          0          0

Powered by Codecov. Last update 92d1f78...dc4f6e7


Common login service

Develop a common login service for Chaise. The login service should be a proper angular service. From what I understand it should support login, logout, and session interfaces. While you are at it, also please remove the login, logout, session interfaces from ermrestjs. The chaise login service should use the angular $http service for network operations. It will also need to get the server base url from the context or rootScope, however, we want to start doing this.

While this is primarily focused on the data-entry app, try to retrofit recordset too if possible.

Actually, the server base url may be in the chaise config object I suppose.

Just realized that this module will need to handle errors from server, like NotFoundError for session not found. We don't have those defined in Chaise (anymore).

I think its okay to redefine those here. Like LoginService.NotFound. I would not reuse the ERMrest module errors in this context. My $0.02…
From: Jennifer Chen<EMAIL_ADDRESS>Reply-To: informatics-isi-edu/chaise<EMAIL_ADDRESS>Date: Wednesday, June 8, 2016 at 12:35 PM
To: informatics-isi-edu/chaise<EMAIL_ADDRESS>Cc: Robert Schuler<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [informatics-isi-edu/chaise] Common login service (#429)
Just realized that this module will need to handle errors from server, like NotFoundError for session not found. We don't have those defined in Chaise (anymore).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/chaise/issues/429#issuecomment-224703242, or mute the threadhttps://github.com/notifications/unsubscribe/AEAhWtlx05r8OI7FD6wF8pkIjomnFnmrks5qJxmfgaJpZM4Iwdv1.


/usr/local/bin/composer is not accessible from PHP images

Tested with circleci/php:7.1.4-cli-browsers

Hello @wundo,
Are you sure it's not available from here?
https://github.com/circleci/circleci-images/blob/30939b17ee05423bb6bf49dbded86e1ae2a38f57/php/generate-images#L9-L14
It looks like we installed it in the right place, what do you think? I'm not familiar with PHP toolchain.

@zzak I runned this image with SSH in circle, and the wasn't a composer in /usr/local/bin/
As I don't have access to the actually generated Dockerfile it's kind of hard for me to debug this.

@zzak any news?

This was fixed sometime in the past few months.
Newer versions of the Docker PHP 7.1.x, 7.0.x, and 5.x images properly include Composer.
Testing a few out myself, the 7.1.9 has it and the 7.0.22 and newer have it.


[FEATURE REQUEST] Make OTG configurable to not replace vanilla worldgen screen

So, I know I have a minority opinion, but I would like to configure OTG to let me use the original New World  screen. I play with modpacks with very different mods, some modpack include OTG that I personally not like but the other mods in the pack or the entire pack otherwise is fits in my favorites. However I feel OTG too obtrusive now. I not want to use any feature of OTG I just want to generate a world with "Default" terrain generator with my heart's seed. Please provide a way me to do it and do it in obvious way because your current screen is a whole mess for me. I do not know what terrain gen will be used (and no way to change it), I have no option to make a superflat creative world, etc. The screen not provides any option that vanilla screen does. No bundles no other stuffs fits my needs, I want my vanilla screen back.
Minecraft 1.12.2.

Hey hron48,
I'm currently working on an update which will allow users to have non-OTG overworlds, so they can have a vanilla overworld and add OTG dimensions. After that's done the vanilla world creation screen will also be brought back.

Thanks. Just out of curiosity, why you cannot use currently the vanilla screen to switch between different generators?

Any update on this, @PG85?

Another issue related to this is that no matter what generator you use for a world (say, you generate your world with flat) originally, OTG happily replaces this generator, fucks up level.dat and starts generating its own BS in a world it should never even touch.
This needs to stop, as it leads to ruined SP worlds by just installing the mod.

Vanilla world creation screen is accessible via the OTG world creation menu in v7 btw.

nice!


IE 10 Windows Phone 8 - Lumina 920

None of the tests for hammer v2 worked for me on my Nokia Lumina 920.

Is this still an issue its the oldest open issue. If it is can some one point me to a reproducible test case? I have access to a full device lab and can test this.


Victorg1991 master

Current coverage is 73.88% (diff: 100%)

Merging #390 into master will increase coverage by 0.09%

@@             master       #390   diff @@
==========================================
  Files            14         14
  Lines          1656       1662     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1222       1228     +6
  Misses          434        434
  Partials          0          0

Powered by Codecov. Last update 86ae54d...bff7a87


KPIs - Seek buy-in (DG, CIO)

Might need more details or to close if nothing is going to be done on this specific issue. @remyb2canada, what do you think?


Feature/contributing docs

Created a CONTRIBUTING.md, CODE_OF_CONDUCT.md and updated README.md.

@Wissididom when you have some time, can you take a look at the added files to see if you can find any issues that need to be updated? If needed I will update my PR before we merge.

Regarding the git-flow, no worries. It isn't really a standard but a suggestion on how to use github to organize branches. It helps later when it comes to managing existing and outdated branches, and it makes the git log graph much easier to understand visually.

I'm going to go ahead and merge this in.
Regarding minor points like the git-flow question and styling guide, we can always modify that on the go. Maybe we can talk about it in the meeting.


WIP - column transformer and mixed sparse arrays

We would like for column transformer to work well when some of the results are scipy.sparse arrays.

So far this is just a test.  We have a problem because we want the following:
dataframe + numpy -> dataframe
dataframe + sparse array -> array

but currently we're not able to differentiate between dense and sparse arrays.  I've raised this upstream here: https://github.com/dask/dask/issues/4070

For things like OneHotEncoder (probably others) we could inspect get_params for a sparse key.
In [6]: OneHotEncoder().get_params()['sparse']
Out[6]: True

Do we want to do this as a stop-gap, or is there some other approach we can take?  We could also take in sparse_output as a keyword to the make_column_transformer function.

I'm not sure. That feels fragile but barring something like https://github.com/dask/dask/issues/2977 I'm not sure there's a perfect way to do this.

FWIW, sklearn's ColumnTranformer has a sparse_threshold keyword.
sparse_threshold : float, default = 0.3
    If the transformed output consists of a mix of sparse and dense data,
    it will be stacked as a sparse matrix if the density is lower than this
    value. Use ``sparse_threshold=0`` to always return dense.
    When the transformed output consists of all sparse or all dense data,
    the stacked result will be sparse or dense, respectively, and this
    keyword will be ignored.

That may be new in sklearn dev. I think setting that to 1 would be the same as accepting sparse_output?

Another option is that we could reverse the default and always have dataframe + array -> array.  This has some obvious usability drawbacks though.

dataframe_threashod? :) I'm not sure what's best here.
As a workaround for the criteo case study, you could manually convert your dataframes to arrays when you know you're done with them with something like #372, or by subclassing the dask-ml estimator and just doing
class MyTransformer(Transformer):
   def predict(self, X):
        return super().predict(X).values

and using MyTransformer in the pipeline. Not the most elegant, but it may get you unstuck for now.

I realize now that the previous implementation was buggy. dd.concat and pd.concat don't know how to handle arrays, so a dataframe + array has to be an array.

We could convert arrays to dataframes though.
I pushed up a commit doing what you just said, but it's not clear to me that it's best.  I'm playing around a bit.

A keyword is inelegant, but maybe the best we can do here. Leave it up to the user to decide.

What should the default be?

I think an array, but either seems fine.
On Fri, Oct 12, 2018 at 11:34 AM Matthew Rocklin<EMAIL_ADDRESS>wrote:

What should the default be?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/394#issuecomment-429385579, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABQHIi18BM2jxFumxXVjuWIA3-Kbx_3Fks5ukMSxgaJpZM4XT2s2
.

A keyword is inelegant, but maybe the best we can do here. Leave it up to the user to decide.

I started working on this and then noticed that we already had a preserve_dataframe keyword, which has a semi-overlapping purpose.  It seems like we might want to combine these two in some way, although I'm not sure how.  Any creative thoughts would be welcome here :)

As you note preserve_dataframe isn't entirely overlapping. The fact that its used elsewhere in dask_ml led me to not suggest it as the keyword to control this behavior here.

Yeah, I'm mostly concerned about the user experience.  A user might reasonably expect that if they set preserve_dataframe=True that they'll get a dataframe out.


e2e tests separate build job per plugin

@itsankit-google @rmstar Please review.
This PR contains :

Updated e2e tests run condition.
We should run all e2e tests on PR raise, for addition of new test scenarios or updates in existing scenario.

When all e2e tests are executed (on PR merge / manual trigger / any change in existing tests) - create separate parallel build jobs to execute all tests per plugin.

Workflow runs:

Required tests
https://github.com/data-integrations/google-cloud/actions/runs/2789291303
All tests
https://github.com/data-integrations/google-cloud/actions/runs/2789558834

Rebased PR.

Please squash commits.

Commits squashed.


Simple Browser: unable to open any page

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87.0
OS Version: macOS Sonoma

Steps to Reproduce:

Run Simple Browser: Show
Enter any url, like https://www.google.com
It just shows a blank page

I know there are other similar reports, all of them were closed because of reasons that don't seem to apply here. I can't open anything at all. Perhaps I'm not understanding how this is supposed to work.
This is what the output log shows when I try to open e.g. Google:
2024-03-07 02:33:03.937 [info] update#setState idle
2024-03-07 02:35:29.441 [error] CodeWindow: failed to load (reason: ERR_BLOCKED_BY_RESPONSE, code: -27)

I'm closing this because I realize that I can open a local server which is all I want to do. But if someone could explain why I'm not able to open external pages I would be grateful.


[terra-tabs] Overflow in icon-only collapsible tabs.

Bug Report
Description
This issue occurs only when all tabs are icon-only. In a scenario when some tabs need to be collapsed into a menu due to unavailability of space, container supposedly appears to overflow — few tabs that needed to be actually hidden are visible pushing the "More" button to the right and causing an overflow.
Steps to Reproduce

Display, let's say, 50 icon-only tabs.

Additional Context / Screenshots

Repro
import React from 'react';
import IconSearch from 'terra-icon/lib/icon/IconSearch';
import Tabs from 'terra-tabs';

const createTabPanes = () => {
  const tabPanes = [];
  for (let i = 0; i < 50; i += 1) {
    const tabPane = (
      <Tabs.Pane label={`Search${i}`} icon={<IconSearch />} isIconOnly key={`Search${i}`} id={`search${i}`} />
    );

    tabPanes.push(tabPane);
  }
  return tabPanes;
};

const IconOnlyTabs = () => (
  <Tabs id="icononlytabs" responsiveTo="none">
    {createTabPanes()}
  </Tabs>
);

export default IconOnlyTabs;

Expected Behavior
Horizontal scroll should not appear, 'More' button should not look cut off.
Possible Solution
The minimum width set to icon-only tab affects the logic that we have to calculate the hideStateIndex that decides how many tabs to show and how many to collapse into the menu. Increasing the min-width fixes this issue.
https://github.com/cerner/terra-framework/blob/6cf7f8722f57836915c06589297b30efd09fb1df/packages/terra-tabs/src/Tabs.module.scss#L58-L62
Environment

Component Name and Version: terra-tabs v6.18.0
Browser Name and Version: All browsers.

@ Mentions
@neilpfeiffer

@neilpfeiffer, thoughts?

Not fully understanding why min-width fixes the dynamic handleResize calculation, but would interested to see the change applied in PR and evaluate.

@neilpfeiffer
Draft PR - https://github.com/cerner/terra-framework/pull/984
Deployment - [WIP]

Not fully understanding why min-width fixes the dynamic handleResize calculation, but would interested to see the change applied in PR shown with a new test case and evaluate.

I don't understand how it affects that either. But it seems to work.


Are there plans to enable Sessions for AllReady?

so we can use things like TempData and Session? Right now, looks like AllReady does not configure it Startup.

I was looking into this. I want TempData so we can convert to PRG.
I want to incorporate this into AllReady.

we already do PRG in some places, but we're "going back to the well" (aka, the database) way more than we have do. TempData is a GREAT tool to offload db redundant db queries into memory and really helps with PRG
as far as the article goes, we have the SAME exact thing wired up where I work. We can drop warnings and errors into TempData and let it do the work for us.
It's super useful for "confirmation" screens... which we don't really have on AllReady yet, we just redirect back to the "Index" action method in order to do a fresh ready after something like a delete, for example.

any plans to simply enable Session (and thus, enabling TempData) w/out the changes @MisterJames proposed? Having TempData available would make PRG much easier in controllers

What about using the IMemoryCache to prevent duplicate DB calls and cache some of the data. I've been using this a fair amount on a current project. I suspect a combination of approaches to suit specific requirements would make sense.
Note IMemoryCache works while we're at a scale of 1. If the app scales out we might want to look at the distributed cache option also.

@stevejgordon caching is kind of overkill for what TempData would bring us. TempData is a nice abstraction over Session that is simple to use and doesn't have the overhead of cache management: expiration policies, stale data, etc...
Granted, I don't know anything about IMemoryCache as I've never used it before.
Either way having Session/TempData enabled and eventually deciding on a caching strategy for AllReady would be a good thing

@mgmccarthy TempData only lives until the next request so caching would certainly reduce DB calls if traffic gets higher from multiple users. I don't think we have much instrumentation in the code but we'd ideally want to monitor that and reduce DB calls where possible.
Agreed it might be a bit early to optimise but caching in ASP.NET Core is pretty easy with the IMemoryCache abstraction. Inject it and then a couple of lines to use it.

@stevejgordon, that's why I want to use TempData and not a cache for some operations. An example of where TempData is very useful is:

initial read on Get
post back form with changes
redirect to a confirmation screen (I don't think we have much of these in AllReady). This is where we're use TempData to carry the changes from the post back to display to the user via a screen
submit changes
(there are other examples I'm sure, but this is one that comes to mind)

TempData does not carry the same cognitive load as caching does, although the purpose of both is the same, to alleviate reads on the db.
If you only need the data for one redirect, use TempData. If you need the data more often, then we can use caching.
Caching carries a cognitive load that requires a developer to know what they're doing... cache expiration policy... etc... Also, as you pointed out, if we scale out, then we need to introduce distributed caching, and that's where things like cache expiration become more difficult b/c we're dealing with multiple machines.
I like TempData b/c its's simple and easy to use. Put you data in it, redirect, then get the data back out. The cleanup of that data from Session is handled for you by the TempData implementation. No injected cache provider, no cache expiration policy, etc...

Setting to vNext as this would be useful for some between request messaging. On the set team lead I currently cheat and return a querystring value to the details action so it knows whether to show a status message or not. This would be much better if implemented via TempData.

@stevejgordon, first, we need to implement TempData, which is based off of Session. For some reason, the ASP.NET Core team did not include TempData as part of the framework (not too sure why, as I find it a very useful abstraction)

@mgmccarthy I think if we're happy with an in memory session implementation (i.e. not scalable without sticky sessions) it looks quite straightforward to get this added.

remember the beauty of issues is we can implement it that way with a limitation and log an issue (tag it as devops) that it doesn't scale without sticky so we can track later when it becomes an issue (pun intended) 😸

I don't think we're load balancing in the live environment, so in-memory should be safe. The IMemoryCache you added for route optimization relies on the live environment not being load balanced so we can use an in-memory cache (which is the fastest).

Andre Locke wrote a great blog on a TempData implemenation for ASP.NET Core https://andrewlock.net/post-redirect-get-using-tempdata-in-asp-net-core/.
After wiring up sessions, this might be a good place to start to our TempData functionality.


Generate service manifests not finding Docker credentials

Summary :
Steps to replicate:

I ran docker login registry.hub.docker.com successfully

Creds stored in ~/.docker/config/json:
{
    "registry.hub.docker.com": {
        "auth": "****"
    }
    },
    "HttpHeaders": {
        "User-Agent": "Docker-Client/19.03.12 (darwin)"
    }
}

testservice.hspec looks like:
name: testservice

image:
    registry: registry.hub.docker.com
    name: ***/test
    tag: 1.0.0

external: true

ports:
    - port: 3001/tcp

Receive the following warning:
[WARN]  Missing credentials for the registry registry.hub.docker.com. Please perform 'docker login registry.hub.docker.com ' to continue with the deployment

Expected result:
The command can find my docker credentials and finish running.
Actual result:
I get the warning [WARN]  Missing credentials for the registry registry.hub.docker.com. Please perform 'docker login registry.hub.docker.com ' to continue with the deployment

HI @MitchellCash ,
We have replicated the steps and didn't find any issues.
Are you using the existing docker image from the repository to deploy the service and also could you please let us know if the docker login is performed with same user(User who is running the hyscale command)? Because the config.json with docker credentials gets created in the home directory of that particular user and will not be accessed by other users.
Refer the below logs:
logged into registry.hub.docker.com with some user and executing the hyscale command with root user and the execution gets failed
*************************                      ERROR                       **************************
[ERROR]  REASON :: [Cannot find registry.hub.docker.com credentials . Do 'docker login registry.hub.docker.com' to continue with the deployment]
**************************                 Deployment info                  **************************
logged into registry.hub.docker.com with some user and executing the hyscale command with the same user, Here in this scenario the service got deployed successfully
**************************               SERVICE: testservice               **************************
**************************              Dockerfile Generation               **************************
[ACTION]  Generating Dockerfile ............................................................  [SKIPPED]
**************************               Image build and Push               **************************
[ACTION]  Image build and push .............................................................  [SKIPPED]
**************************               Manifest Generation                **************************
[ACTION]  Generating manifest for Secret ...................................................  [DONE]
[ACTION]  Generating manifest for Deployment ...............................................  [DONE]
[ACTION]  Generating manifest for Service ..................................................  [DONE]
**************************                    Deployment                    **************************
[ACTION]  Applying Secret ..................................................................  [DONE]
[ACTION]  Applying Service .................................................................  [DONE]
[ACTION]  Applying Deployment ..............................................................  [DONE]
**************************        Waiting for deployment completion         **************************
[ACTION]  Pod initialization ...............................................................  [DONE]
[ACTION]  Pod creation .....................................................................  [DONE]
[ACTION]  Pod readiness ....................................................................  [DONE]
[ACTION]  Waiting for service IP .............
..............................................  [DONE]
**************************                 Deployment info                  **************************
[INFO]  Total time : 46s
[INFO]  Manifests  path : /root/.hyscale/hyscale/apps/test/testservice/generated-files/manifests/
[INFO]  Deploy Logs : /root/.hyscale/hyscale/apps/test/testservice/logs/deploy.log


Module not found: can't resolve './fonts/fontname' in 'path/to/workspace/src/'

An error occured when run the command npm run build --production

Please clone with submodules.


Auto import css for css prop

What:

Why:

How:

Checklist:

[x] Documentation
[x] Tests
[x] Code complete

Codecov Report

Merging #200 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   90.82%   90.91%   +0.09%
==========================================
  Files          22       22
  Lines         850      859       +9
  Branches      220      224       +4
==========================================
+ Hits          772      781       +9
  Misses         63       63
  Partials       15       15

Impacted Files
Coverage Δ

src/babel.js
98.07% <100%> (+0.07%)
:arrow_up:

src/css-prop.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e3438...96149d8. Read the comment docs.


User settings

Add settings persistence (local storage backed) to UserService.

LGTM

Thanks! I've updated it again after discussing with @ancorgs to move setting user and room.

LGTM


enhancement : msi installer should install system wide and not a system wide installer

Prerequisites

[ X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
A MSI installer as been created for Atom. But it's not an installer for Atom. It's an installer for the Installer ! After installation, you don't have Atom in c:\Programs but an Installer of Atom and atom.exe still lives in personnal directory
Steps to Reproduce
install with msiexec
Expected behavior:
having atom.exe living in c:\Programs\atom\
Actual behavior:
An atom installer lives in C:\Programs and atom.exe lives in user personnal directory. Why is it so crucial for us ?  We are a high shcool and we teach code to our students. We have 1200 students and are low on budget for server storage space.
Every student has an allocation of approximately 300M for personnal space, and another 200M for sharing space. That's all we can do.
And... atom installation is more than 300M in size ! It's useless because those 300M could perfectly be stored in C:\Program\atom\ and shared for all the users of the computer.
Reproduces how often:
100%
Versions
1.14.1 on windows 7 64bits
Additional Information
I've made some test so far, with copying brutally the content of a personnal atom setup in the system Programs directory, it seems to work for non priviledged users. The program files should live in system, and only customization should live in personnal data

I have similar issue. I've used Aomt 64 MSI installer but I did't see Atom icon everywhere after it finish.
No icon on desktop. No icon on start menu. No atom in AppData. No atom in Program Files.
I can't find it everywhere but Add/Remove programs. Can only uninstall it. 😕

gluons, it kinda works ... it justs install an atom installer in c:\Programs
Without any icon or shortcut.

This is intentional and by-design.  A shared copy of Atom is not supported.

damieng, shared copy is not necessary (computer in a school are not running multiple user at once).
But having a machine install is mandatory. In secure environment, pupils can not have an executable in their own personnal folder or any shared data folder for security reason. Plus, even if they should, the space overhead would be unusable
Here in France, we are begin to massively teach computer science. Atom would be perfect for an editor, but actually, it cannot be used because of the installation method.
A machine install is really mandatory. Plus, it works ! I've just put all the file from a personnal folder in the %PROGRAMS% folder, and there be it, for a single user, it works flawlessly !
The design intention is perfect for developpers having the keys of his desktop, but that's not the only use case.

If you want to deploy a single copy to machines I would suggest unpacking the zip file and adding an icon to atom.exe to the all users\Start menu location.
The packaging system we use today - Squirrel - does not support a machine-wide installation and we do not have the resources to develop one given our other priorities.


feat: Adding binary signing test

Description
Tests signing pre-merge so that errors with signing can be caught earlier.
TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)
Updated CircleCI configs

/bin/bash: line 15: ./bin/terragrunt_darwin_arm64: Bad CPU type in executable

I suspect we can't verify by running terragrunt on different CPU, I think leaves only option for codesign -dv --verbose=4 <file>


Is this something we can use?

I found a site where you can see if the server are up or if theye have any problems.
Theye have made a API: https://github.com/rubenvereecken/pokemongo-api
Maybe we can use it for some kind of monitoring?

This system uses the same API to detect this...

I don't see why the bot would need this, if you want to monitor if the service is up check https://pgorelease.nianticlabs.com/plfe/ (if you see text, it's up).
Please close this issue.

Answer above, closing this for now.
/closed


SAK-30087 & SAK-29824 - Clean up redundant attributes from submission.

Would also fix the bug with this being invalid and not maching in
assignment xml

I tested this locally on most of the pages, the student submission, instructor grading. It looks okay. I don't see anywhere these were really needed. I think that having all of those inner classes in BaseAssignmentService (like BaseAssignmentSubmission) also lead to possible problems with redundant code in AssignmentSubmissionAccess (which is fixed here) but I figured we could maybe refactor that after so this merge could be possible.

Based on some feedback rewrote this using this new method addElementsToList that further simplifies this code. I believe the AssignmentSubmissionAccess will also be collapsed eventually to use this service method but that inner class still needs to be pulled out.

Nice refactor!

Is this ready to go?

Let me double check for Earle's review then I'll commit

Pretty sure it's good, but I'd like to leave it open for a few more days (contrary to my earlier comment). We're just starting a round of internal QA, so just in case we find any issues we can leave this open (and the other related PRs).


Using pagination and an infinite scroll on rivers

We had an offline meeting yesterday to talk about the issue of performance in building rivers, and Spencer Morin suggested something I had not considered, and didn't fully understand, that we get a small number of items for the river, to begin with, and when the user scrolls past the end we get the next batch, and keep going as long as the user wants more and there is more to return. I thought this sounded promising, so we're going to explore it and probably implement something.
My first step was to ask ChatGPT for advice.
Spencer replied, again offline:

I read through what ChatGPT generated and that looks great for paginating by item order (other than swapping out feedUrl for feedId and reversing the ORDER BY). My initial comment here is ordering by id, while very fast, won’t guarantee publish dates that are in order. We’d still need to order by pubDate and use a limit + offset to paginate if we want to preserve date order, which is much slower. However, limiting the amount of data we query at a time (because we’re paginating) will speed things up significantly.

My thoughts.

As far as I know, there is nothing sacred about sorting on pubDate, and the feedId may be a more honest report on when the news really was published. We will still display the pubDate in the river, while using the feedId to sort. If that makes it faster, I say let's go for it.

pubDate has been problematic, no one really knows what to do there. In my own feeds, I generate the pubDate when I publish, it's really very much like the feedId value, only from the publishing side.

My next step is to get one of the queries getRiver generates, both before and after modification to support pagination.
However I have a server issue I have to attend to first, a semi-emergency, so this may take a bit of time...

Here's a  river query.
select * from items use index (feedId) where feedId in (2403,13216,12702,3824) and pubDate > '2023-02-21 10:12:30.928'  order by pubDate desc limit 175;

Back in a minute with proposed changes.

I've built out the code on the client side to do the infinite scrolling, but I need to do the database side before I can go any further.
Do you see problems with the new version in the post above? I'm trying to get this done in a single day, so I can return to the project I was focused on.
Any help much appreciated. ;-)

I'm going to go ahead. Wish me luck! :-)

Okay obviously my new version is wrong.
It's not the feed's ID that must be less than the last ID, it's the item's ID.
I'm going to think some more. ;-)

Hi! Sorry for the radio silence! I'm looking through this now. Give me just a couple of minutes and I'll have some comments.

Ah, yeah. You've already detected the issue. :)
and feedId < LASTID order by feedId desc limit 100;

I'm going to think some more. ;-)

It should be as simple as replacing feedId with id.
and id < LASTID order by id desc limit 100;

That will also be much faster than ordering by feedId.

I think I have it.

The first query --

select id, title from items use index (feedId) where feedId in (2403,13216,12702,3824) order by id desc limit 50;

The second query --

select id, title from items use index (feedId) where feedId in (2403,13216,12702,3824) and id < 2489238 order by id desc limit 50;

A couple of things.

It is much faster for 50 than 100.
You need the index. It's way too slow without it.

Nice! This is looking good!

I'm not sure how to characterize the result, but I'll give you the report.
The tests are running against the feedland.org database.
It's quite a bit slower than it was.
Here's a screen shot of a test I did at the mySql command line with the code generated for the Politics river.

That was just for the first 50 items. I assume it would be the same for the second and so on.