Move xds tests to xds_test package and split out NewFakeDiscoveryServer

This refactors all tests that use NewFakeDiscoveryServer into xds_test instead of xds package. In general, IMO, its best to use the black box test mode in general, to avoid testing low level details and instead target things at a higher level. In particular, when using the fake DS, which is intended for a high level. However, the primary motivation for this is for a future change which moves NewFakeDiscoveryServer out of the production code. This removes quite a few dependencies on our prod binaries and is overall cleaner. This work will be done in a followup, as this PR is fairly large (but should be mostly trivial refactorings).
edit: actually decided it was less noisy to just move NewFakeDiscoveryServer as part of this as well.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0c6c55803def005c2b87cde0d369c8eeb2afcd1e
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0c6c55803def005c2b87cde0d369c8eeb2afcd1e
link
true
/test lint

gencheck_istio
0c6c55803def005c2b87cde0d369c8eeb2afcd1e
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
0c6c55803def005c2b87cde0d369c8eeb2afcd1e
link
true
/test gencheck

lint_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test lint

gencheck_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test lint

gencheck_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test gencheck

unit-tests-arm64_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test lint

gencheck_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test gencheck

unit-tests-arm64_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests-arm64

unit-tests_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test lint

gencheck_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test gencheck

unit-tests-arm64_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests-arm64

unit-tests_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests

integ-pilot-multicluster_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test gencheck

unit-tests_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test unit-tests

integ-pilot-multicluster_istio
4f7b889263d489d4da6c010984fb0851d275f039
link
true
/test integ-pilot-multicluster

unit-tests-arm64_istio
c99afb7cb15a03e510ae643df2c58962d2e53928
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

when you resolve the conflicts, probably you can take care of Zhonghu's last comment as well

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

integ-telemetry_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry

integ-telemetry-discovery_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

integ-telemetry_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry

integ-telemetry-discovery_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-discovery

integ-telemetry-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

integ-telemetry_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry

integ-telemetry-discovery_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-discovery

integ-telemetry-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-mc

integ-pilot-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

integ-telemetry_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry

integ-telemetry-discovery_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-discovery

integ-telemetry-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-mc

integ-pilot-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-multicluster

unit-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests-arm64

integ-ambient_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ambient

gencheck_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test gencheck

integ-cni_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-cni

integ-distroless_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-distroless

integ-pilot-istiodremote-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote-mc

integ-ds_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ds

integ-operator-controller_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-operator-controller

integ-helm_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-helm

integ-pilot_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot

integ-ipv6_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-ipv6

integ-pilot-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-notes

release-test_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test release-test

lint_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test lint

integ-security_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security

integ-telemetry-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-multicluster

analyze-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test analyze-tests

integ-telemetry_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry

integ-telemetry-discovery_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-discovery

integ-telemetry-mc_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-telemetry-mc

integ-pilot-multicluster_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-pilot-multicluster

unit-tests_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test unit-tests

integ-security-istiodremote_istio
aa128d3a4498c57f07c61ca9ae24bbcbde870110
link
unknown
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Right Y Axis Support

Added the ability to have a second y axis visible within the cartesian visualization.

I am going to close this since its totally superseded by the multi-scale-axis branch.  If we for some reason need to break the two features up I can sort it out again.


implement LSP handling of multiple same names within a single file

currently LSP does not differentiate variables with same names within different scopes, so could be a cause for potential bugs

The language server now has infrastructure for mitigating this sort of problem.
See the all_references_of_token fn here.


js error in documentation

there seems to be a js error on this page: https://semantic-ui.com/behaviors/visibility.html#fixing-content-to-viewport when you click the example code.
Mac OS Chrome and Safari.

It says in the console:
"semantic.min.js:15 Popup: Popup does not fit within the boundaries of the viewport

…
"

Hi, can’t find it, can you please elaborate?

I get 4 errors:
Sticky: "Element is hidden, you must call refresh after element becomes visible. Use silent setting to surpress this warning in production."
https://semantic-ui.com/dist/semantic.min.js:7353:126
Visibility: "Element is hidden, you must call refresh after element becomes visible"
https://semantic-ui.com/dist/semantic.min.js:9461:126
those two repeat

This is just because the page lazily initializes the sticky elements. The ones that are in the closed tabs are initialized before they are visible and so positions can't be determined on first init.
I can fix this in docs code, but it shouldnt cause any bugs.


Pull request for code review, completed body section of mobile version portfolio page.

Implemented
Header, logo, and nav icon
Main title
Main paragraph
Social Media icons


Solution for Language Detector Project

Thanks
On Thu, Jun 1, 2017 at 9:21 AM, Santiago Basulto<EMAIL_ADDRESS>wrote:

@santiagobasulto commented on this pull request.
In language_detector/main.py
https://github.com/rmotr-group-projects/pyp-w1-gw-language-detector/pull/124#discussion_r119611291
:

@@ -1,8 +1,17 @@

-- coding: utf-8 --

+import re
+from languages import LANGUAGES
Try removing this one please.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rmotr-group-projects/pyp-w1-gw-language-detector/pull/124#pullrequestreview-41506130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpetjIcb2V56I3zMOnF4OlyMKdHRkTsks5r_rrGgaJpZM4Ns8f2
.


[BUG] Tests against OpenSearch main are failing

What is the bug?
Tests against OpenSearch main branch are failing in the CI. https://github.com/opensearch-project/opensearch-go/actions/runs/3114891404/jobs/5051224763
How can one reproduce the bug?
Run the integration-unreleased workflow against OpenSearch main.
What is the expected behavior?
Tests should pass successfully.
What is your host/environment?
Operating system, version.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

TestBulkIndexerIntegration test with body compression fails when testing against OpenSearch main:
FAIL: TestBulkIndexerIntegration/With_body_compression (9.46s)
        --- FAIL: TestBulkIndexerIntegration/With_body_compression/Default (9.25s)
            bulk_indexer_integration_test.go:114: Unexpected NumIndexed: want=100000, got=0
            bulk_indexer_integration_test.go:118: Unexpected NumFailed: want=0, got=100000
            bulk_indexer_integration_test.go:122: Unexpected countSuccessful: want=100000, got=0
        --- FAIL: TestBulkIndexerIntegration/With_body_compression/Multiple_indices (0.21s)
            bulk_indexer_integration_test.go:188: Unexpected NumIndexed: want=30, got=0

Stacktrace from OpenSearch end:
{"type": "server", "timestamp": "2022-10-20T22:44:46,490Z", "level": "WARN", "component": "r.suppressed", "cluster.name": "docker-cluster", "node.name": "8e1ce1e71492", "message": "path: /test-bulk-integration, params: {wait_for_active_shards=1, index=test-bulk-integration}", "cluster.uuid": "3bPso61HQZWlstl9afmOZg", "node.id": "jZN3cDgWQWGNTA6E4eQpcg" ,
"stacktrace": ["org.opensearch.common.compress.NotXContentException: Compressor detection can only be called on some xcontent bytes or compressed xcontent bytes",
"at org.opensearch.common.compress.CompressorFactory.compressor(CompressorFactory.java:71) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.common.xcontent.XContentHelper.convertToMap(XContentHelper.java:144) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.rest.action.admin.indices.RestCreateIndexAction.prepareRequest(RestCreateIndexAction.java:79) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.rest.BaseRestHandler.handleRequest(BaseRestHandler.java:103) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.rest.RestController.dispatchRequest(RestController.java:312) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.rest.RestController.tryAllHandlers(RestController.java:398) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.rest.RestController.dispatchRequest(RestController.java:241) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.http.AbstractHttpServerTransport.dispatchRequest(AbstractHttpServerTransport.java:366) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.http.AbstractHttpServerTransport.handleIncomingRequest(AbstractHttpServerTransport.java:445) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.http.AbstractHttpServerTransport.incomingRequest(AbstractHttpServerTransport.java:356) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.http.netty4.Netty4HttpRequestHandler.channelRead0(Netty4HttpRequestHandler.java:55) [transport-netty4-client-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",
"at org.opensearch.http.netty4.Netty4HttpRequestHandler.channelRead0(Netty4HttpRequestHandler.java:41) [transport-netty4-client-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]",

Another test failure due to compression
--- FAIL: TestTransportCompression (0.01s)
    opensearchtransport_integration_test.go:162: Unexpected StatusCode, expected 201, got: 400

For TestTransportCompression, PUT and POST requests are failing with 400 bad request (against OpenSearch main):
&{PUT /shiny_new_index HTTP/1.1 1 1 map[] <nil> <nil> 0 [] false  map[] map[] <nil> map[]   <nil> <nil> <nil> 0xc0000160c0}
&{400 Bad Request 400 HTTP/1.1 1 1 map[Content-Type:[application/json; charset=UTF-8]] 0xc00000f680 -1 [] false true map[] 0xc0001cbb00 <nil>}

&{GET /shiny_new_index HTTP/1.1 1 1 map[] <nil> <nil> 0 [] false  map[] map[] <nil> map[]   <nil> <nil> <nil> 0xc0000160c0}
&{200 OK 200 HTTP/1.1 1 1 map[Content-Type:[application/json; charset=UTF-8]] 0xc00000f8c0 -1 [] false true map[] 0xc00014df00 <nil>}

&{POST /shiny_new_index/_doc HTTP/1.1 1 1 map[Content-Type:[application/json]] {0xc00000f9a0} 0x856a00 19 [] false  map[] map[] <nil> map[]   <nil> <nil> <nil> 0xc0000160c0}
&{400 Bad Request 400 HTTP/1.1 1 1 map[Content-Type:[application/json; charset=UTF-8]] 0xc0002e68c0 -1 [] false true map[] 0xc000442100 <nil>}

Against OpenSearch 1.x and 2.x, the requests succeed.

Upon picking the commits from OpenSearch main, looks like https://github.com/opensearch-project/OpenSearch/pull/3847 is the change from which the tests have started failing. Looking into why this is the case.

@reta Any suggestions on how this can be fixed?

@VachaShah thanks a lot for bringing this up, looking into it

@VachaShah thanks a lot for bringing this up, looking into it

Thank you!

@VachaShah ah, found the issue, the fix on the way ... sorry about that ...

@VachaShah ah, found the issue, the fix on the way ... sorry about that ...

Thats awesome! Thank you @reta :)

@VachaShah the fix is in, could you please rerun the failing action(s), I don't  have permissions sadly to do that, thank you

@VachaShah the fix is in, could you please rerun the failing action(s), I don't have permissions sadly to do that, thank you

Thank you @reta! I have rerun it for PR https://github.com/opensearch-project/opensearch-go/pull/142, will rerun for others as well.

The tests are passing now, thank you @reta for the fix!
Closing this now.


Encapsulation design

Discussed in https://github.com/akuleshov7/ktoml/discussions/92

Originally posted by Peanuuutz January 12, 2022
Currently encapsulation is not present, which is an urgent problem for a widely used application. We should only expose those classes and functions that are necessary for users. This will help users to quickly find what they want, as well as help us develop new features as well as modify existing code without worrying about breaking users' applications.

I'm going to copy what I have done. (Actually these are quite common)

The following are public:

Entrypoint for serialization and deserialization: Toml. (Consider this suggestion)
AST: TomlValue(which derives TomlBoolean, TomlLong, TomlBasicString, TomlArray, TomlTable to name a few).
AST manipulation: like JsonPrimitive.int.
Exceptions: only sealed TomlEncodingException and TomlDecodingException.

The following are internal:

Encoders
Emitters
Decoders
Parsers

Also, I suggest separating AST itself and the actual parsing process, like Toml<type> only has content property, while Toml<type>Parser is responsible for parsing and producing it.

Sync the answer.
New question raised.

Sync the answer.
New question raised.

Yes, let it be open. At least we will mark internal methods with opt-in and revise private methods


fix(deps): update all non-major

This PR contains the following updates:

Package
Type
Update
Change

ring
dependencies
patch
0.17.7 -> 0.17.8

serde (source)
dependencies
patch
1.0.196 -> 1.0.197

serde_json
dependencies
patch
1.0.113 -> 1.0.114

ureq
dependencies
patch
2.9.5 -> 2.9.6

Release Notes

serde-rs/serde (serde)
v1.0.197
Compare Source

Fix unused_imports warnings when compiled by rustc 1.78
Optimize code size of some Display impls (#2697, thanks @nyurik)

serde-rs/json (serde_json)
v1.0.114
Compare Source

Fix unused_imports warnings when compiled by rustc 1.78

algesten/ureq (ureq)
v2.9.6
Compare Source
Fixed

hootbin is optional dep. Tests must be run with feature testdeps (#729)
Exclude script files from cargo package (#728)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.15 :tada:
The release is available on:

GitHub release
v1.2.15

Your semantic-release bot :package::rocket:


Potentially circular log caused fast-safe-stringify to clog the event loop

Please tell us about your environment:

winston version?

[ ] winston@2
[x] winston@3

node -v outputs: 10.15.3
Operating System? (Windows, macOS, or Linux) Linux (heroku node)
Language? (all | TypeScript X.X | ES6/7 | ES5 | Dart) ES6/babel

What is the problem?
We added what seemed like an innocuous debug log to our code. It looked like this:
    this.logger.debug('_notifyLocationContactViaSMS', 'inputs', {
      data,
      locationContact,
    })

Whenever that code path got hit, we would see our eventLoopLatency metrics spike and every other request was held up. Even when at LOG_LEVEL info. Both data and locationContact contain a mix of information returned from Sequelize. It's possible that a sequelize instance was contained somewhere in data.
To figure out what was breaking the server, we ran a single box with --perf enabled and got a collection of v8 logs. They consistently pointed to this log statement which triggered a cascade of calls to decirc*, which looks to be contained in fast-safe-stringify.
To confirm it might be bad stringification, we redeployed with the code like this:
    this.logger.debug('_notifyLocationContactViaSMS', 'inputs', {
      data: data.toJSON(),
      locationContact: locationContact.toJSON(),
    })

That immediately resolved the event loop problems, confirming to us it was indeed stemming from the data we passed to the logger.
Attached at the bottom is a screenshot of the v8 profiling log
Other information
I believe this issue was closed due to logform having fast-safe-stringify
https://github.com/winstonjs/winston/issues/1248

I had this exact problem.  I would characterize the bug as: "logger.verbose(), logger.debug(), etc should not spend time formatting a log statement when log level is set at a level that would not trigger a log statement."  Seems like https://github.com/winstonjs/winston/issues/1627 is one workaround.  I just deployed my own similar workaround in my code and saw an 8x increase in server throughput!


Update filesystem.md

Add the newest android 13 granular permission

Thanks for the pull requests, but this file is generated from https://github.com/ionic-team/capacitor-plugins/blob/main/filesystem/README.md, so should be changed there.
Also, those changes are only needed if targeting SDK 33, which is not officially supported by Capacitor yet.


yq dependency conflicts with go-yq

Hey, I am not sure if this is something that you can do, I think I saw somewhere people were talking about putting an if:then in their PKGBUILD because there isn't a more graceful way to deal with multiple options, like an (OR) statement (like a double-pipe || or anything like that)
Anyway, this is probably overkill for the issue, and the real issue might be upstream (PKGBUILD).  But if there's a way you can build an option for either yq or a drop-in, that would be awesome, and please tell me how it's done, because I've been trying to figure it out myself.
I removed yq from dependencies, but I assume that's not going to work for people who don't have a package that will do the same work.
Thanks,
b-report synopsis:
Possible to enable package build with alternative yq-compatible drop-in go-yq?
expected result:
for makepkg -s to build aur-pull without interruption, either identifying or downloading dependencies as needed
actual result (process):

makepkg -s began process of building the aur-pull package
makepkg stopped due to missing dependency yq during check
yq was identified as a conflicting with installed package go-yq
User aborted build process re: unwillingness to replace go-yq with yq

workaround:

PKGBUILD alteration options:

(A) change dependency from yq to go-yq or

(B) remove yq from dependencies array

decided option (B) and removed yq from dependencies array
built aur-pull package without further complaint from makepkg
tested aur-pull functions for build incompatibility artifacts

Result: No noticed side-effects from building with go-yq instead of yq.

Hey @averyfreeman,
thanks for reaching out.
I just checked out go-yq for a couple of minutes, and found a couple of minor incompatibilities that keep it from playing well with aur-pull.
My findings for now:

Unlike yq,go-yq doesn’t come with a tomlq executable. I’d have to change settings.bash slightly to accommodate that, i.e. detect whether go-yq is installed, and if so, invoke yq -oy instead of tomlq -t.

aur-pull depends on the --arg feature of yq. From what I’ve seen, go-yq doesn’t offer anything like it. To make this work, I’d have to make a few changes to settings.bash, i.e. remove the // \$default_value expression, check whether yq returns null, and if so, return the default value.

I’d be ok with adding a feature that checks which yq flavor is installed, and makes the correct invocation (tomlq -t or yq -oy. PRs welcome.

workaround:
PKGBUILD alteration options:
   (A) change dependency from yq to go-yq or
   (B) remove yq from dependencies array

Removing the dependency is not really an option, because without them aur pull would fail at runtime.
However, I’d be willing to upload and maintain an aur-pull-go-yq package that contains an exact copy of aur-pull, just with the depends entry changed to go-yq. They can share a common pkgbase so it’s actually not much duplication.

On second thought – I’d prefer ditching yq altogether and use python-tomlkit directly instead, the engine backing yq. python-tomlkit can be installed without conflicts so I’d strongly prefer that.
PR incoming.

@averyfreeman Cut a new release v0.1.1 and uploaded a new version of the AUR package, which no longer depends on yq. Feel free to give it a try!

Hi Claui, wow that was fast.
Paraphrasing:

My findings: go-yq = no tomlq.  settings.bash would req mods:  go-yq ? yq -oy : tomlq -t

However,
aur-pull --arg == yq, != go-yq; if settings.bash // \$default_value + $(yq -f0nse $TAR) == null >=< RET $TAR (?)

I agree, dealing with two jq-alike dependencies for aur-pull undoubtedly an over-commitment to maintenance. especially when you can trade both to deal with a format easily a gazillion times more forgiving (assertion carefully quantified, of course, thanks to gazillionaire's AI - with gazillions of As and somewhere some Is eventually).
I am slightly attached to go-yq's flags spelling -f0nse, if I chose correctly (there may have been bias)
mm, tomlkit is the reason I have poetry. go, lib.


Support maps

We should support maps/dictionaries as a first-class datatype. Syntax could be something like:
x: !map
  keys: string
  values: int

Keys can only be primitive scalar types.
Shorthand syntax could look like:
string->int

We should also make sure maps can be used in computed fields.

Implemented.


Calender feature

hard coded calender removed with real calender with tap function so that user can select date of shedules class 3 days ahead and 3 days before of current date

LGTM..Great Work @ajay963


Beta10 Navigation does not work

To reproduce
cesco@cesco-desktop: ~/code/src/bitbucket.org/cescoferraro/pip
$ ionic info

Your system information:

Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
OS: Distributor ID:     LinuxMint Description:  Linux Mint 17.3 Rosa
Node Version: v5.12.0

cesco@cesco-desktop: ~/code/src/bitbucket.org/cescoferraro
$ ionic start test --ts --v2
....
....
....

cesco@cesco-desktop: ~/code/src/bitbucket.org/cescoferraro/pip
$ ionic generate component hello
√ Create app/components/hello/hello.html
√ Create app/components/hello/hello.ts

Then add this func to the home component and create the button on html
  go(){
    this.navController.push(Hello)
  }

<button (click)="go()" >sdfdsf</button>

The hello component wont show unless you click it twice clogging up the document with unwanted multiple copies of the hello tag.

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

It seems to be working already on the plunker you provided. Maybe is related to de cli IDK.
I have pushed a  Github repo with the steps I took.
I am seeing the same issue when upgrading my real app from beta 9.

Hi, I had the same problem with beta10. Check if the hello page has a selector, sometimes if the page that you are trying to push have a selector the nav doesn't work properly, remove the selector fixes my problem.

I can confirm that @mihaben tip solved the issue. Cannot belive I let that splip by. @jgw96  Is this the expected behavior? maybe you guys could consider documenting this. Maybe here

Its worth mentioning that I have come across similar situation where the only thing that worked, was setting the component selector to ion-page
selector: 'ion-page'

Hello all! This is expected behavior, components that are used as a page should not have a selector. I am going to make an issue on the ionic-site repo to document this to avoid the confusion. Thanks!

@jgw96 -- When you say "This is expected behavior" are you referring to the fact that adding selector: 'ion-page' to the @Component annotation fixes this issue.  I am experiencing the same issue and @cescoferraro's suggestion fixed this for me.  I'm using Beta 10 on Angular RC 4 with @angular/forms 0.2.0

Sorry, I should have been more clear (: Components that are used as pages in an Ionic 2 app should not have a selector of any kind. Does the page your having trouble pushing have a selector on it? Also, I always check to make sure that I do not have a syntax error in my templates. If there is a syntax error in the template it will not compile and therefore the page will not be pushed onto the stack. Thanks, hope this explains things better!

@jgw96 You're right. It seems that I had an error in my template. Is there any way to make these errors more apparent?

Hmm, usually there is an error. What browser are you developing in?

In both Safari and Chrome on macOS, I'm not seeing any template errors come through.

Would you mind opening a separate regarding this? I want to look into it more


multiworld disabling

Hiya I am wondering if there is any way to disable Gringotts on certain worlds or disable the creation of vaults on certain worlds. I have a separate creative building world on my server and have realized you can just create a vault on this world and have infinite money. This is not ideal.
Is there any fix or any feature you could add in the config for this.
many thanks
AltF4

Is there any way to do this?

Currently Gringotts doesn't support multi-worlds settings.
I'll have a look on it and depends on how difficult will be to implement it, it will be added, or not :)
Thanks.


HTTP methods

Hello,
serve response contains header
access-control-allow-methods: HEAD, OPTIONS, GET, POST, PUT, PATCH, DELETE

but it isn't clear how to get key/value posted via POST method on the server side.
Could please clarify this?

This is simply a file server that renders file over HTTP GET - There is no POST mechanisms.


DocsArchive-1.0.21078.2Auto archive content

Auto archive content from https://github.com/opstestppe2/E2E_DocsArchive.git

Docs Build status updates of commit 0334b1e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

e2e_archiveDocs_20210426134429/TOC.yml
:white_check_mark:Succeeded
View

e2e_archiveDocs_20210426134429/breadcrumb/e2e_archiveDocs_20210426134429/toc.yml
:white_check_mark:Succeeded

e2e_archiveDocs_20210426134429/docfx.json
:white_check_mark:Succeeded

e2e_archiveDocs_20210426134429/fallback.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Feature: Add steps for getting ACR credentials

@sundharakanth please review and test. Try to fix spellcheck issues which are not really spelling mistakes.

To resolve the errors from spellcheck, we need to add the 6 valid words (ECR, ecr, dkr, aws, amazonaws, azurecr) in the dictionary - https://github.com/devonfw/.github/blob/master/en-devonfw.dict

There is one word mis-spelt as "accesing" instead of "accessing" which is to be corrected.

Hi @albertdb - Opened a PR https://github.com/devonfw/.github/pull/126 to add new words ECR and ACR in Dictionary and got it reviewed and merged. For all other words failing, we need to use backticks (as code) since those are not new technical words rather those are specific words from each providers as per Devon Core Team review.

@sundharakanth Thanks. Apart from that, do the commands work as expected?

@sundharakanth Thanks. Apart from that, do the commands work as expected?

Thanks for the updates @albertdb . Yes, all the commands are working as expected and once we merge the current file, we can check if it resolves SpellCheck issues.

Hi @albertdb , right now, only the 3 words (imagesdir, partnums, sectnums) are failing in SpellCheck.

There are a couple of options to fix this issue:

We can check with Jan @SchettlerKoehler if we are going to use the below format in all the documentation folders as template in all devonfw github projects and if not, we can remove this part.

If this format is required, then, we can check with Malte @maybeec and add regex to escape words starting with colon and ending with colon to escape words like
(a) :imagesdir:
(b) :partnums:
(c) :sectnums:

@sundharakanth Please go ahead preparing the solution mentioned in the second option while we get more opinions on this matter. Not much work to throw away in case a different decision is finally taken.

@albertdb - The following regex takes care of escaping the single words (not the ones with hyphen in between like :toc-title: ). Please confirm.

Hi All ( @maybeec , @SchettlerKoehler , @ssarmokadam , @isandesh1986 , @sujith-mn ),
I can see the following templated related non-standard words in dictionary.
148   doctype
614   toc
249   idprefix
250   idseparator
516   reproducable [Looks like mis-spelling of reproducible]
If we have the above words, then, I think, it is okay to add the following few more words. Please confirm.
(a) :imagesdir:
(b) :partnums:
(c) :sectnums:

[ FYI - @albertdb ]

Hi All ( @maybeec , @SchettlerKoehler , @ssarmokadam , @isandesh1986 , @sujith-mn ), I can see the following templated related non-standard words in dictionary.
148 doctype 614 toc 249 idprefix 250 idseparator 516 reproducable [Looks like mis-spelling of reproducible]
If we have the above words, then, I think, it is okay to add the following few more words. Please confirm. (a) :imagesdir: (b) :partnums: (c) :sectnums:

[ FYI - @albertdb ]

That is kicking the can down the road, because we can have arbitrary attributes in a document: https://asciidoctor.org/docs/asciidoc-recommended-practices/#document-attributes-i-e-variables

@sundharakanth Please go ahead preparing the solution mentioned in the second option while we get more opinions on this matter. Not much work to throw away in case a different decision is finally taken.

@albertdb - The following regex takes care of escaping the single words like :sectnums: , :partnums: , :imagesdir: , etc. Please confirm. [ FYI - @ssarmokadam , @isandesh1986 , @sujith-mn ]

Note: The above one does not take care of the words with hyphen in between like :toc-title: , :chapter-label: , etc. But, those are not having any spellcheck issues as of now.

Please try to make it work for cases with hyphens also.

Just one question, why do we need all this properties here?
Normally we generate the website / pdf with a central tool and not configuring asciidoc in each document. Is it really needed?

Hi All ( @maybeec , @SchettlerKoehler , @ssarmokadam , @isandesh1986 , @sujith-mn ), I can see the following templated related non-standard words in dictionary.
148 doctype 614 toc 249 idprefix 250 idseparator 516 reproducable [Looks like mis-spelling of reproducible]
If we have the above words, then, I think, it is okay to add the following few more words. Please confirm. (a) :imagesdir: (b) :partnums: (c) :sectnums:

[ FYI - @albertdb ]

That is kicking the can down the road, because we can have arbitrary attributes in a document: https://asciidoctor.org/docs/asciidoc-recommended-practices/#document-attributes-i-e-variables

@sundharakanth Please go ahead preparing the solution mentioned in the second option while we get more opinions on this matter. Not much work to throw away in case a different decision is finally taken.

@albertdb - The following regex takes care of escaping the single words like :sectnums: , :partnums: , :imagesdir: , etc. Please confirm. [ FYI - @ssarmokadam , @isandesh1986 , @sujith-mn ]

Note: The above one does not take care of the words with hyphen in between like :toc-title: , :chapter-label: , etc. But, those are not having any spellcheck issues as of now.

Please try to make it work for cases with hyphens also.

Just one question, why do we need all this properties here? Normally we generate the website / pdf with a central tool and not configuring asciidoc in each document. Is it really needed?

I think the problem is more general. If we want to create a variable for a URL, the spellchecker will complain. For me is the same as running it against source code, completely absurd.

Raised the PR https://github.com/devonfw/.github/pull/127 for change in spellcheck.yml

@sundharakanth Any advances on this?

@sundharakanth Any advances on this?

@albertdb Tested the regex changes in my fork and it is working fine. Need to test negative scenarios as well. Same changes are already added to this PR in Hangar repo.

Hi All ( @maybeec , @SchettlerKoehler , @ssarmokadam , @isandesh1986 , @sujith-mn ), I can see the following templated related non-standard words in dictionary.
148 doctype 614 toc 249 idprefix 250 idseparator 516 reproducable [Looks like mis-spelling of reproducible]
If we have the above words, then, I think, it is okay to add the following few more words. Please confirm. (a) :imagesdir: (b) :partnums: (c) :sectnums:

[ FYI - @albertdb ]

@ssarmokadam and @sujith-mn - Shall we go ahead with this option? Please confirm.

@sundharakanth You have force pushed and removed changes in spellcheck.yaml
Please check.

@albertdb - Yes, thats right. To fix the issue temporarily, I added the 3 new words in dictionary and get it merged. So, removed all the .spellcheck.yml file changes.
Now, you can merge this PR#43 which will make spellcheck workflow to execute successfully in Hangar repo.
Currently Spellcheck is passing in the branch feature/acr-credentials and failing in master.

@sundharakanth As I commented before about adding new attributes to dictionary:

That is kicking the can down the road, because we can have arbitrary attributes in a document: https://asciidoctor.org/docs/asciidoc-recommended-practices/#document-attributes-i-e-variables

Please reintroduce spellcheck change if that is valid for any :watheverVariable-with-hyphens:

@sundharakanth As I commented before about adding new attributes to dictionary:

That is kicking the can down the road, because we can have arbitrary attributes in a document: https://asciidoctor.org/docs/asciidoc-recommended-practices/#document-attributes-i-e-variables

Please reintroduce spellcheck change if that is valid for any :watheverVariable-with-hyphens:

@albertdb - I will discuss with Devon Core team ( @ssarmokadam , @sujith-mn , @isandesh1986 ) and get back.

Devon Core team ( @ssarmokadam , @sujith-mn , @isandesh1986 ) and get back

@albertdb - A JIRA Ticket is created for this requirement and Devon Core team ( @ssarmokadam , @sujith-mn , @isandesh1986 ) would get back to you on the timelines of the same.


[Menu] Different Menu UIs/Options

Rodrigo and I, are looking at different UIs.
Rodrigos:
Mine:

Mine:

Solved Link used by Seba is Mentor, Rod was Admin (main root url)


Web application Proxy site has errors

https://docs.microsoft.com/en-us/windows-server/remote/remote-access/web-application-proxy/publishing-applications-with-sharepoint%2C-exchange-and-rdg
I think there are few errors on that site above.
It states that Exchange Activesync works only with pass-through but this site claims that it can be configured with ADFS & HTTP Basic. Referring to : https://docs.microsoft.com/en-us/windows-server/remote/remote-access/web-application-proxy/publishing-applications-using-ad-fs-preauthentication & https://docs.microsoft.com/en-us/windows-server/remote/remote-access/web-application-proxy/web-application-proxy-windows-server
Also EAC should work like the OWA. Referring to link: https://technet.microsoft.com/en-us/library/dn635116(v=exchg.150).aspx
At RDG section there is a statement: "If the External and Internal FQDN's are different you should disable request header translation on the RDWeb publishing rule. "
---> Shouldn't this be the opposite? If the URLS are different, then it needs translation enabled which is by default.

Hey, @mitiih - It's been ages since you opened this, but I did want to circle back with a bit of information. RD doesn't actually support this scenario with Web App Proxy. RD DOES support using Azure app proxy, though, which is described accurately here: https://docs.microsoft.com/en-us/azure/active-directory/active-directory-application-proxy-get-started


Ministry: update email templates going to the Ministry

As a Ministry User, I would like to receive an email triggered by event in SIMS, where I can see Student given name and last name in a separate line.  With certain names it will be hard to tell which names are their given name or last name and would save time having to do multiple searches if the notification email clearly showed that.
Current behavior:

Desired behaviour:
Split the line Student: ((givenNames)) ((lastName)) into two lines
Student Given Name: ((givenNames))
Student Last Name: ((last Name))
All other fields remain the same.
Acceptance criteria:
The desired behavior across the following templates

Ministry - Student Requests BasicBCeID account
Ministry - Partial Student Profile Match
Ministry  -Student Submits Application with Exception Request
Ministry - Legacy Restriction Added
Ministry - Student application is edited for 5th time
Ministry - Student File Upload
Ministry - Student Submits Change Request after COE
Ministry - Change to a Student's Program or Offering
Ministry - Disbursements Blocked by Federal/eCert
Ministry - eCert Feedback File Error

Business analysis request template (1) (2).docx

All the templates are updated in GC Notify.


Please help me get curl and wget onto my machine

As a scientist working with Windows in the lab, I do not know how to check for curl or wget on my machine. It is a mystery. Can you provide some helpful information on how to verify that I have the tools on my machine. In case I do not have them please help me and document how and where I can download and install them from.

Honestly, since curl is even officially shipped with Windows 10 and 11 (https://curl.se/windows/microsoft.html), I don't see why it up to us to support here.
We must not started to link external resources, since there is no guarantee they are a) up to date and b) not orphaned at some point.
A simple search via "How to use/install curl on Windows" is getting you there.


Deep hierarchy

original https://github.com/twilio/guardrail/pull/98
I couldn't merge it twice :(

@blast-hardcheese Could you check it again?

@blast-hardcheese approve and merge it soon. please.

@blast-hardcheese Would you like to check & approve it?)

Thank you for your work on this; I'll review, but there were still some points from the last review

This is wildly cool. I'm going to do one more full review and some local testing before merging.

🎉


ModifyAckDeadline does not convert deadline to seconds

It looks like there is a missing division by time.Second in this line:
https://github.com/GoogleCloudPlatform/gcloud-golang/blob/master/pubsub/pubsub.go#L116
which makes the whole function work incorrect.

Mailed https://code-review.googlesource.com/#/c/2600/.

Fixed by @rakyll in https://github.com/GoogleCloudPlatform/gcloud-golang/commit/b0ed34171eb0f730dda336155af9a3f60aa203b0
Closing.


NAV Web Client vs BC Web Client

I am working with BC1810 RC03 (October Release Candidate 3).
By default, in the RTC, it appears that some profile personalization has been done to both of these pages.  For the Resources list, there is no Navigate option in the ribbon; just a Prices group on the Home ribbon.  For the Resource Card this is a Navigate option; however there is also a Prices group on the Home ribbon.  This same personalization does not appear in the BC web client.  The same default personalization was in NAV 2018 and the 2018 Web Client showed the personalization.
Is this a change for BC or a bug?  If it is a change, does that mean you can't "configure" the ribbon on page in the web client any more?
NAV/BC RTC Ribbon

BC Web Client ribbon

NAV 2018 Web Client

Okay so I found something else weird.  If I "search" for the Resources list from the "light bulb" I get the ribbon in my original post.  If I use http://localhost:8080/BC130/WebClient/?Page=77 (like it does from the from VS Code using startobjectid/startobjecttype).  I get this this ribbon, which does have the personalization.

What is the difference?  Is this a bug?  Intentional?

We received a reply from the client team:
The page gets different personalization ID depending if it is opened as ListPlace or ListPage in V1 personalization. In WebClient list pages from Tellme are opened as ListPages and as ListPlaces when navigating by url or navigation action. WinClient opens list pages as ListPlaces both from search and navigation. V2 personalization is applied differently and does not have this issue. We are working on enabling V2 action personalization in Web Client.


Infrastructure: Issue Templates

It would be useful to set up issue templates for specific kinds of issues, e.g. bugs, feature requests, questions, etc. so contributors can automatically categorize and label issues.

Since this is a repeated request i will handle it.

done. Feel free to suggest improvements using the github interface for this (look under repository insights)


evolution-data-server: 3.32.1 -> 3.32.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/evolution-data-server/versions.
meta.description for evolution-data-server is: '"Unified backend for programs that work with contacts, tasks, and calendar information"'.
meta.homepage for evolution-data-server is: '"https://wiki.gnome.org/Apps/Evolution"

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.32.2 with grep in /nix/store/jhmjiqh03zmazy92dizmgks74akn0a26-evolution-data-server-3.32.2
directory tree listing: https://gist.github.com/8b6744d62dd37cf3f7ab5b845f939fcd
du listing: https://gist.github.com/b3f7e7d6cb90b9183e5475f6fb2309e7

Rebuild report (if merged into master) (click to expand)

163 total rebuild path(s)
54 package rebuild(s)
54 x86_64-linux rebuild(s)
54 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
53 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
adapta-gtk-theme
almanah
arc-theme
chrome-gnome-shell
deja-dup
dropbox-cli
ekiga
empathy
evolution-data-server
folks
gnome3.bijiben
gnome3.cheese
gnome3.empathy
gnome3.evolution
gnome3.evolution-data-server
gnome3.evolution_data_server
gnome3.file-roller
gnome3.folks
gnome3.geary
gnome3.gnome-applets
gnome3.gnome-books
gnome3.gnome-boxes
gnome3.gnome-calendar
gnome3.gnome-contacts
gnome3.gnome-control-center
gnome3.gnome-documents
gnome3.gnome-maps
gnome3.gnome-notes
gnome3.gnome-panel
gnome3.gnome-photos
gnome3.gnome-session
gnome3.gnome-shell
gnome3.gnome-terminal
gnome3.gnome-todo
gnome3.gnome-tweak-tool
gnome3.gnome-tweaks
gnome3.gnome-user-share
gnome3.gnome_control_center
gnome3.gnome_session
gnome3.gnome_shell
gnome3.gnome_terminal
gnome3.nautilus
gnome3.nautilus-python
gnome3.pomodoro
gnome3.totem
gnome3.tracker-miners
gnomeExtensions.gsconnect
pantheon.elementary-calendar
pantheon.elementary-greeter
pantheon.elementary-session-settings

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jhmjiqh03zmazy92dizmgks74akn0a26-evolution-data-server-3.32.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A evolution-data-server https://github.com/r-ryantm/nixpkgs/archive/3682b4934ff5a1e13b70c151771db60162603cd5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jhmjiqh03zmazy92dizmgks74akn0a26-evolution-data-server-3.32.2
ls -la /nix/store/jhmjiqh03zmazy92dizmgks74akn0a26-evolution-data-server-3.32.2/bin

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

news: https://gitlab.gnome.org/GNOME/evolution-data-server/blob/f6385fd8087253b95df0a2f37b62aaa7de61dafb/NEWS

Evolution-Data-Server 3.32.2 2019-05-06
Bug Fixes:
I#89 - [IMAPx] Downloads content for offline in unsubscribed folders (Milan Crha)
I#99 - Fails to build against git master of OpenLDAP (vendor version check) (Дилян Палаузов)
I#102 - Change order of gtkdoc-scangobj libraries (Milan Crha)
I#105 - Invalid UTF-8 letters in a mail body get lost (Milan Crha)
Miscellaneous:
Address several issues reported by Coverity Scan (Milan Crha)
[EWebDAVDiscover] Prevent crash on GError use in gio functions (Milan Crha)
Translations:
Gianvito Cavasoli (it)


Use BigAutoField for User.id

Types of changes

[x] Bugfix (I'm not entirely sure)
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
We have been using the bigint data type for User.id since ab2573d6a25a, but the id field that Django automatically create for us uses AutoField, which maps to the int data type.
This mismatch in data type is mostly benign, but when User.id grow large enough, it will blowup when we try to use setval on User.id (e.g. importing fixture with manage.py loaddata), with an error complaining value out of range.
Steps to Test This Pull Request
Steps to reproduce the behavior:

Start the development environment
Import this fixture with python manage.py loaddata fixtures.json

Expected behavior
Importing fixture data succeed without error
Related Issue
None that I know of.
More Information

Question for reviewers: can we omit src/users/migrations/0012_auto_20200712_1632.py?

Codecov Report

Merging #826 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   76.14%   76.33%   +0.19%
==========================================
  Files          70       70
  Lines        2687     2688       +1
==========================================
+ Hits         2046     2052       +6
+ Misses        641      636       -5

Impacted Files
Coverage Δ

src/users/models.py
90.47% <100.00%> (+0.09%)
:arrow_up:

src/core/models.py
96.42% <0.00%> (+1.78%)
:arrow_up:

src/events/views.py
65.94% <0.00%> (+2.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f2e02...8615a9e. Read the comment docs.

Does the migration work locally? Not sure if we need to do --dry-run here. It should be good to go if this succeeds locally.

I remember it worked locally for me, but I'll check again (probably tomorrow) just to be sure.

Migration works locally, and after the migration user creation still works.
However, there's one change in the schema that might need to be reviewed (the diff is below); user.id is changed from DEFAULT public.users_user_id_generator() NOT NULL to simply NOT NULL, which is probably not what we want.
@uranusjr what do you think we should do here?
 This may be easier.

I guess another option is to add a migrations.RunSQL operation in  src/users/migrations/0012_auto_20200712_1632.py that change the default for user.id back.
But I'd like to avoid this option if possible, and rather have things declared in our Django model.

This could work (not tested)
from psycopg2.extensions import AsIs

id = models.BigAutoField(primary_field=True, default=AsIs('public.users_user_id_generator()'))


Simple optimization of Money#allocate

So I noticed amounts_from_splits quite high on the profiles:

Right now when you call allocate with Money instances as argument (rather common), the money instances are converted as follow: BigDecimal#to_f#to_s#to_d
It's kind of wasteful...
I changed the codepath so we return the value attribute directly since it's a BigDecimal already.
@wvanbergen @DazWorrall for review please.

Jus out of curiosity how are you profiling @casperisfine, or is this data from Newrelic?


please unreserve underscore, and allow it for user usage

Version
2.3.4

I have been a developer for many years, and I, as many others, have been using underscore-starting variables and functions to convey special meaning: this is somehow restricted / it's temporary / it's for internal use / it's the real implementation and the other one is a wrapper etc.
Taking away this ability is unnecessary, it is handicapping developers, and opens the door for bugs. I was bitten by Vue's handling of _ properties a long time ago and had to do the same googling many others have done before me. But what prompted me to submit this issue is I just created a _render method: given that I was renaming a method that was already used in a few places, combine this with some other edits before and after the rename, the outcome was, as you can imagine, a long and frustrating session of debugging.
I propose underscore should be cleared for regular usage by users. This could be really simple, like renaming the internal stuff to start with $_ instead, or namespacing everything under something like this.$ (but I presume that would require some serious code shuffling).

Properties prefixed by _ and $ are historically used internally by vue. I don't think there is enough reasoning to change that.

I don't think that it makes much sense to define methods etc in components as "internal", because generally, all of them should be considered internal - the public API of a component is defined by its props and events.
While you can access methods or data of a component programmatically through e.g. a $ref, that's something that's rarel happening.

accessing methods does happens happens but trying to hide properties from the user by just prepending _ or $ is an illusion

Yes, _ and $ are used internally, but there's a huge difference between them: $ provides a useful, documented, public API, while _ provides bug-prone unexpected behaviour.
(Yes, it's true the unexpected part is "somewhat documented", but nobody tells you "no, really, don't use underscores for anything, unless you like pain.")
My argument is simple, and frankly seems very compelling to me as a newcomer:

_ is bug-prone. People will shoot themselves in the foot due to the unexpected behaviour. There's many issues in this here tracker proving that (though I think my _render()-related experience is the worst yet).
seasoned developers love _. Don't alienate them.
_ is unnecessary. Getting rid of it is one simple search & replace away.

This is unlikely to happen because this almost certainly will break someone's existing code, and the gain is arguable.
What we can do is raise warnings when users declare data/props/computed/methods that start with _. I'd be open to a PR for that.

I am probably going to get an ass whippin' for suggesting this, but I would like to see a refactoring of __ and $$ instead of _ and $ internally in the next major version of Vue.   Sure they are ugly, but they are internal and I won't have to see them.
Two very common javascript conventions reserved internally?  That does not seem to have been the best choice.
I can live with losing the '$', but not the _ .  Perhaps consider converting the internal '_' to '$$' or '__'.?
IDK ¯_(ツ)_/¯

This naming reservation is a pain when using languages like TypeScript where the common syntax for a member variable backing getters/setters starts with an underscore.
This just sounds like Vue getting in the way of languages, when it is unnecessary and solvable by vue reserving double underscores, or just $

I just learn that the hard way.

Vue is a beautiful piece of engineering, with a few shortcomings. Which is to be expected, everything has shortcomings.
What's unconstructive though (and if there's something that qualifies for the expression you used I'd say this is it) is the attitude "if I don't find it helpful, then it can't be to others".
Pair that with logic of the sort "this is internal and undocumented so don't use it, but we can't change it because someone might rely on it.", and you have a recipe for frustration.
Projects that care about their users don't mind re-architecting, and have a deprecation strategy such that they warn clients of their API of oncoming changes. But then, that's not to be found here.

As was stated many professional developers have come to use _ (underscore) as a prefix for special cases (Even the developers of Vue found it useful for their purposes!)  It is one of two non alpha characters that can be used to start a variable name, $ being the other and is also take by Vue!
A simple case to demonstrate is to have a prop of something like "searchTerm".  In order to do a .sync I will often have a local variable that receives that props value and then will emit the value as the local variable changes.  Since "searchTerm" is a good descriptive name for the prop and since I can't reuse that name for my local variable I need a prefix.  _ is a simple perfect match.  "_searchTerm" is easy to recognize as being related to searchTerm and makes my code readable.  Again, the underlying language does not allow for other single prefix characters and Vue is taking away the one that should be available.  On the Vue side, simply changing the reserved _ (underscore) to __ (double underscore) would still be simple, concise and not collide with THE SINGLE REMAINING PREFIX WE HAVE AVAILABLE TO US.  Vue 3.0 would be a good place to give underscore back the people (us developers)

Really just needs another open issue at this point, because the decision to maintain this is some serious quality oversight...

What would be handy: if we declare variables with underscores warnings get thrown.
Had some people on my team caught with this, it isn't immediately intuitive and nothing gives feedback as this being inappropriate (vue-cli, eslint, etc.), I get the reasoning but it would be good to provide a bit better feedback for the developer against this behavior when defining variables we expect to show up under this._thing don't.

@vertic4l not what you suck

@vertic4l not what you suck

Creative! So you are the bottom of the shitheads.
See you all in some years regreting your chosen path.

Whatever you say Mr. Lindner

You that this is against law and can be charged in real Life?


[Fabrica] ⚠  Could not find dependency 'composer'.

Hi,
I'm getting this issue trying to run ./setup.rb.
[Fabrica] ⚠  Could not find dependency 'composer'.
So I run composer -v, just to be sure, which logs : Composer version 1.4.1 2017-03-10 09:29:45
What do I miss?

Hey,
Are you using any virtual environment tool (rbenv, rvm, virtualenv, etc.)?
Do you get any error if you run if hash composer; then echo "ok"; fi in the command shell? What about ruby -e "puts 'ok' if system 'hash composer'"?

Hi,
Thanks for your help. Both of the commands you gave me return: composer: not found.

Thanks for trying that out. That's odd, hash composer should detect the executable if available. Can you try these two other alternative ways to see if they work in your system:
if command -v composer; then echo 'ok'; else echo 'not found'; fi
and
if type composer >/dev/null; then echo 'ok'; fi

hi there, same problem, you figured out what happen ?

@tiojoca
The first command returns:

alias composer='php /usr/local/bin/composer.phar'
ok

and the second returns:

ok

I'm guessing composer isn't available in my Ruby env?

@enguerranws very good point, you should gem install composer and this solve our problem

@maxperei @enguerranws thanks for looking at this together – can you confirm if gem install composer does the trick?

Yes it does! I had to overwrite my previous install of composer with the Ruby Gem version.
Thanks!

Great, good to get to the bottom of this.


Corrects environment and failing tests

Corrects "Respect idAttribute" and "Remove duplicate models" tests
Corrects "Collections handle duplicates correctly" test
Updates deprecated browserify version
New versions of Backbone take up changes that affects to Supermodel library.
Collections are no longer going to merge attributes from duplicate models inside a collection. Instead, and for fixing the "Collections handle duplicates correctly" test, you have to pass an option specifically ({merge: true}).
Regarding "Respect idAttribute" test, Collections now require the model constructor passed as a parameter to take advantage of the specific model context, for example, to be able to get a model from a collection by the custom idAttribute definition. Thus, the collection associated for each particular model constructor (all) must be defined in such a way.
Finally, the "Remove duplicate models" test got failed in the last Backbone version (1.2.1) as a regression bug was created (jashkenas/backbone#3693). For the moment, the Backbone version defined at the package has been limited by versions prior to 1.2.1 version, until it is fixed.

Nice :+1:

Fantastic thank you!


new feature leisure=pitch

Description
Pitches are quite easy to recognize with aerial views.
It would be welcome for municipalities to know how many pitches and kind of sport is practiced.

Version
RapiD 1.1.9
What browser are you seeing the problem on? What version are you running?
No response
Steps to reproduce
No response
The browser URL at the time you encountered the bug
https://mapwith.ai/rapid#background=fr.ign.bdortho&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w218595684&map=19.40/44.22082/5.14273

Thanks for the report! Is this a Machine learning / detection request to pre-identify the type of sport that the pitch supports? And have RapiD automatically update the area tags accordingly?

There could be also some easy detection when some contributors have created node then generate a polygone.


update ci.yml

Ci setup branch has updated the ci.yml file. Kindly request to merge into the master branch. Please review

Done merge


Infinite spinner

I am running a docker-compose project with a nginx proxy that proxies requests to my docker-compose services (nginx is part of my docker-compose). When I am running strapi behind nginx, the only thing I can see is an infinite loading spinner. The scripts are loaded but nothing happens. What is the correct configuration to make this work?

Trying proxying trough my node.js app since nginx did not work for, but same result. Proxying /admin to http://strapi:1337 (docker-compose network)

Hi @Macke97,
I do not have enough informations to help you. You will need to share your docker configurations and nginx config too so I can see what's up.

Docker compose
version: '3'

services:
    api:
        build: ./services/api
        volumes:
            - ./services/api:/app
        environment:
            - PORT=80
            - HOST=${HOST:-http://localhost:3000}
            - WP_HOST=${WP_HOST:-http://wp.boilerplate.se.localhost}

    frontend:
        build: ./services/frontend
        environment:
            - SCRIPT_VERSION=0-dev
            - HOST=${HOST:-http://boilerplate.se.localhost}
        volumes:
            - ./services/frontend:/app
    nginx:
        build: ./services/nginx
        ports:
            - 3000:80
        depends_on:
            - api
            - frontend
            - strapi
        restart: on-failure

    redis:
        image: redis

    strapi:
        image: strapi/strapi
        depends_on:
            - mysql
        environment:
            NODE_ENV: production
            DATABASE_CLIENT: mysql
            DATABASE_HOST: mysql
            DATABASE_PORT: 3306
            DATABASE_NAME: strapi
            DATABASE_USERNAME: strapi
            DATABASE_PASSWORD: strapi
            PROXY_HOST: localhost // Do I need these?
            PROXY_PORT: 8000
        volumes:
            - ./services/strapi:/srv/app
    mysql:
        image: mysql:5.7
        volumes:
            - ./data:/var/lib/mysql
        restart: on-failure
        environment:
            - MYSQL_ROOT_PASSWORD=dettavarkul
            - MYSQL_DATABASE=strapi
            - MYSQL_USER=strapi
            - MYSQL_PASSWORD=strapi

Nginx
events {
  worker_connections  4096;  ## Default: 1024
}

http {
    server {
        listen 80;
         location /admin {
            proxy_set_header Host $host;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_pass_request_headers on;
            proxy_redirect off;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
            proxy_pass http://strapi:1337;
        }
        location / {
            proxy_set_header Host $host;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_pass_request_headers on;
            proxy_redirect off;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
            proxy_pass http://frontend:80;
        }
    }
}

Did you modify the proxy config in config/environments/env/server.json ??

I have tried both modifying it and keeping it default

To clarify: I want Strapi to be accessible through /admin in my nginx config.

@Macke97 I think serving strapi in a sub folder won't work right now. You could use 2 different domain name instead and redirect /admin to the strapi domain.

@alexandrebodin Ahh, that's a bummer :/

@alexandrebodin Ahh, that's a bummer :/

I will try something when I get some free time and let you know

Thanks!


HTTP persistent session support

Current session implementation keeps the session state in-memory until the server is online. But with the container based architecture, we need to persist session in a database and it should be enabled by using a parameter if the user needs to.

We have removed the sessions APIs and hence this is not needed.


Move controllers and webhooks into internal/

These are not public APIs
Moving the them to internal simplifies the root directory.
Saves having to copy every new root directory in Dockerfiles
Adheres to https://github.com/golang-standards/project-layout#internal

I know the Go project layout suggests this, but KubeBuilder has its own expected layout and won't work without it kubernetes-sigs/kubebuilder#1268. So this change would break future use of KubeBuilder.

Same argument applies if we move main.go to cmd/manager/main.go (which I'd assumed we would do). Here for example is what happens if you attempt  to add a conversion webhook:
richard   internal  ~  projects  improbable-eng  etcd-cluster-operator  130  git diff
diff --git a/main.go b/main.go
index 1f1fd45..e8543ba 100644
--- a/main.go
+++ b/main.go
@@ -12,6 +12,7 @@ import (
        "sigs.k8s.io/controller-runtime/pkg/log/zap"

        etcdv1alpha1 "github.com/improbable-eng/etcd-cluster-operator/api/v1alpha1"
+       "github.com/improbable-eng/etcd-cluster-operator/controllers"
        "github.com/improbable-eng/etcd-cluster-operator/internal/controllers"
        "github.com/improbable-eng/etcd-cluster-operator/internal/etcd"
        "github.com/improbable-eng/etcd-cluster-operator/internal/version"
@@ -103,6 +104,10 @@ func main() {
                setupLog.Error(err, "unable to create controller", "controller", "EtcdBackupSchedule")
                os.Exit(1)
        }
+       if err = (&etcdv1alpha1.EtcdCluster{}).SetupWebhookWithManager(mgr); err != nil {
+               setupLog.Error(err, "unable to create webhook", "webhook", "EtcdCluster")
+               os.Exit(1)
+       }
        // +kubebuilder:scaffold:builder
        if os.Getenv("DISABLE_WEBHOOKS") != "" {
                setupLog.Info("Skipping webhook set up.")

This means that we can't clean up the main.go file, for example moving the manager setup logic to a function that can also be re-used in tests.
My preference is to diverge from the kubebuilder layout at this point and set things out cleanly.
It'll always be possible to run the kubebuilder generation in isolation and copy the generated files into our preferred directory structure.

Even if there was an option to configure KubeBuilder to use a different layout, I think there's value in leaving it 'standard' so that someone unfamiliar with the project can onboard faster by reading the KubeBuilder documentation and examples.

I don't buy that. The Kubebuilder layout is unfamiliar. Better to stick to the standard structure.
I'll close this for now, but would like to revisit in future.
See also https://github.com/kubernetes-sigs/kubebuilder/issues/932#issuecomment-524975469


The possibility to extend Envoy metrics to emit custom-metrics in addition to the Envoy existing built-in metrics.

Title: The possibility to extend Envoy metrics to emit custom-metrics in addition to the Envoy existing built-in metrics.
Description:
Envoy already emits many metrics in the stats endpoint. Can we add some extra/custom metrics for our bootstrap extension to it? If yes, any how-to link?
To give you context, I have a bootstrap extension that I want to emit custom metrics within that extension process. I was think of using something like the code below but it does not work.

// Envoy::Server::Configuration::ServerFactoryContext* server_context_;

Envoy::Stats::CounterSharedPtr counter =
      new Envoy::Stats::NullCounterImpl(
          server_context_->serverScope().symbolTable());
  counter->add(n);
  counter->incRefCount();

  server_context_->serverScope()
      .store()
      .createScope("mycustomerextentionmetric")
      ->store()
      .counters()
      .push_back(counter);

Thanks,
Parsa

there's some discussion of the stats architecture here: https://github.com/envoyproxy/envoy/blob/main/source/docs/stats.md
This is not really a how-to guide to add new stats but it might be a good start, as well as grepping around the source.
It also might be interesting to explore the codebase using the sourcegraph tool, e.g. with this as a starting point: https://sourcegraph.com/github.com/envoyproxy/envoy/-/blob/source/common/stats/utility.h?L95:16&popover=pinned

Thanks Joshua for the links. I ended up using adding the metric using
scope_ = server_context_->scope().createScope("mymetric")
stats_ = {ALL_TCP_PROXY_STATS(POOL_COUNTER(*scope), POOL_GAUGE(*scope))};

from my extension and it worked. I think the important part is to keep the pointer to the created scope and the stat itself alive for the lifetime of the server since they seem to be a RefPointer.
Thanks,
Parsa

@ppourali  I have similar requirement, could you please guide me how to add custom metric to envoy ?


(GH-2522) Add 'resolve' key to modules config

This adds support for a new resolve key for both Forge and git module
specs in bolt-project.yaml. It also adds support for a name key for
git module specs, which is required when setting the resolve key to
false.
When resolve is false, Bolt will skip dependency resolution for the
module. This allows users to include modules that would otherwise break
Bolt's dependency resolution in their Bolt projects, avoiding the need
to manually manage a Puppetfile. This includes modules with broken
metadata and git modules hosted in a repository other than a public
GitHub repository.
If a unresolved module shares the name of another module's dependency,
Bolt will error indicating that there is a name conflict. This is in
line with r10k's behavior when installing a Puppetfile that has
duplicate module names.
!feature

Add resolve key for Forge and git module specifications
(#2522)
Forge and git module specifications in bolt-project.yaml now support
a resolve key. When setting resolve: false, Bolt will skip
dependency resolution for the module, allowing users to include
modules with broken metadata or modules hosted in a repository other
than a public GitHub repository in their project configuration.

Test cases

[ ] Requires git modules to have a name if resolve: false
[ ] Skips resolution for modules with resolve: false when installing and adding modules
[ ] Allows non-public or non-GitHub git modules to be installed without --no-resolve
[ ] Allows modules with broken metadata to be installed
[ ] Errors if no-resolve modules have a name conflict with resolved dependencies

Woops, quick rebase.

Woops, quick rebase.

[x] Does not install dependencies when resolve: false
[x] Installs dependencies when resolve is:

[x] Unset
[x] True

[x] Errors if resolve isn't boolean
[x] Errors if resolve is set for a git module and name isn't set
[x] Git module with a name different from actual name uses provided name
[x] Adding a fake module with resolve: false doesn't fail until installing modules

[x] Adding a fake module with resolve: false doesn't prevent other modules from being installed

[x] Errors when resolve: false module has the same name as a module dependency

[x] Does not install dependencies when resolve: false
[x] Installs dependencies when resolve is:

[x] Unset
[x] True

[x] Errors if resolve isn't boolean
[x] Errors if resolve is set for a git module and name isn't set
[x] Git module with a name different from actual name uses provided name
[x] Adding a fake module with resolve: false doesn't fail until installing modules

[x] Adding a fake module with resolve: false doesn't prevent other modules from being installed

[x] Errors when resolve: false module has the same name as a module dependency