Widen dependency on Kitura to next major

Kitura-CORS only relies not he middleware interface in Kitura so there shouldn't be any reason why it is tied to a specific minor level of Kitura.
Widening its dependency means its much less likely to cause version conflicts when people move up Kitura levels.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chris Bailey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   89.18%   89.18%
=======================================
  Files           2        2
  Lines          74       74
=======================================
  Hits           66       66
  Misses          8        8

Flag
Coverage Δ

#KituraCORS
89.18% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c583b21...bbc93ec. Read the comment docs.


bump vault helm chart to 040

bump vault helm chart to version 0.4.0
this makes it work instead of not working, which is bad.
the old helm chart version doesn't work with helm3

This does not work when I run it in sandbox.
$ helm install vault --namespace vault --kubeconfig "~" --values ~/vault_sandbox_agent_helm_values.yml https://github.com/hashicorp/vault-helm/archive/v0.4.0.tar.gz
Error: failed to download "https://github.com/hashicorp/vault-helm/archive/v0.4.0.tar.gz" (hint: running `helm repo update` may help)
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
	Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: connect: connection refused
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈
$ helm install vault --namespace vault --kubeconfig "~" --values ~/vault_sandbox_agent_helm_values.yml https://github.com/hashicorp/vault-helm/archive/v0.4.0.tar.gz
Error: failed to download "https://github.com/hashicorp/vault-helm/archive/v0.4.0.tar.gz" (hint: running `helm repo update` may help)


module: change calls to jq to use absolute path

Solves #36

I can confirm that it worked for me on MacOS

@jordanisaacs Is there anything that blocks merging this PR?

@spikespaz sorry for taking a while. Just haven't paid been paying close attention to the merge requests.


Roll Engine from effb529ecec8 to b0f739ba6b54 (8 revisions)

https://github.com/flutter/engine/compare/effb529ecec8...b0f739ba6b54
2021-01-14<EMAIL_ADDRESS>Roll Dart SDK from 3629a798353d to a461c2b3366d (1 revision) (flutter/engine#23699)
2021-01-14<EMAIL_ADDRESS>Add support for rendering using Metal on macOS (flutter/engine#23599)
2021-01-14<EMAIL_ADDRESS>Remove unused fml::Message serializer (flutter/engine#23669)
2021-01-14<EMAIL_ADDRESS>SkParagraph: enable the ICU breaker cache (flutter/engine#23667)
2021-01-14<EMAIL_ADDRESS>Add winuwp as one of the choices in --target-os.
2021-01-14<EMAIL_ADDRESS>removed variable-sized array (flutter/engine#23102)
2021-01-14<EMAIL_ADDRESS>Return null in Future.catchError handler (flutter/engine#23101)
2021-01-14<EMAIL_ADDRESS>Ensure gen_snapshot for the target is built when needed (flutter/engine#23694)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.

Commit queue failed; closing this roll.


Zonal stats of reduced image

I also encountered this issue when reducing a ImageCollection:
test = ee.ImageCollection("MODIS/061/MOD17A3HGF").select('Gpp').sum()
# zonal statistics
geemap.zonal_statistics(
    test,
    geemap.gdf_to_ee(ws),
    outdir,
    statistics_type='MEAN'
)

I did not find the "mean" column in the output CSV file.
I found that the image ‘’test‘’ is like:

I am not sure what the problem is.
Originally posted by @JiehaoZhang1993 in https://github.com/gee-community/geemap/issues/598#issuecomment-1842564557

Set out_file_path and scale
https://geemap.org/common/#geemap.common.zonal_stats


About evaluation

Hey,
I have a question on the difference in APs computed by COCO-API vs computed by the official MATLAB evaluation tool:

Using COCO-API to compute the<EMAIL_ADDRESS>I get ~78 on test sequences (test_b.json), which is lower than what has been reported using MATLAB evaluation tool.

I am evaluating your released model: 'ua-detrac_model_best.pth' so no training involved.

I cannot run MATLAB tool as it is not compatible with my OS.

Thanks :)

Hi,
I have two hypothesis as to why that might be. First of all, you have to make sure to ignore the detection in the ignore regions for each sequence. That will have an impact for sure. Second, you have to do the evaluation with the full image resolution, the "--keep_res" parameter. I ran the evaluation in a VM using Octave, maybe you can set up something similar? Hope that helps!

Thanks for the prompt response :)
The keep_res flag is set and the predictions are made over the whole image (as in your implementation). And I am evaluating over all of the predicted and ground-truth boxes. So I agree that the difference is probably coming from the ignore regions.
Very helpful! thanks.


[Simplified Collect][Taxes] Creating new taxes

Details

This PR introduces the ability to create a new tax rate on the Taxes page:

the WorkspaceNewTaxPage,
the TextPicker component,
the AmountPicker component.

Fixed Issues

$ https://github.com/Expensify/App/issues/37793
PROPOSAL: N/A
Tests

Make sure you are using the staging server (production doesn't support creating new taxes yet).
Go to the Workspace Collect.
(If needed) Turn on the Taxes feature in the More features tab.
Press the Add rate button in the top right corner.
Pick a name and value.
Press save.
Verify a new tax rate was added to the list.
Open again the Add rate modal.
Verify the form is cleared (draft is not stored).
Validations (remember to press Save each time):

Select a duplicated name.
Select an empty name.
Select an empty value.
Select a tax value of more than 100 percent.

Log out and log in to check if the changes are persisted on the backend (alternatively: use two devices).

Offline tests

Offline mode scenario:

[ ] Turn on Offline mode.
[ ] Create a new tax rate.
[ ] Verify it is shown with half opacity.
[ ] Turn off Offline mode.
[ ] Verify the Tax Rate is saved.

Failure scenario:

[ ] Turn on Simulate failing network requests in the Troubleshoot menu.
[ ] Create a new tax rate.
[ ] Verify the error message is shown near the new tax rate (it should be displayed after 10 retries, so it might take a while).
[ ] Verify the brickRoadIndicator is displayed in the LHN list (near the Taxes item).
[ ] Verify you can clear the error message by clicking on it.

QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Do the tests from the above.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android & iOS: Native

https://github.com/Expensify/App/assets/104823336/b3fa9b56-dc8c-4ec5-964b-ea0abcfd66e6

Android & iOS: mWeb

https://github.com/Expensify/App/assets/104823336/6bd0f7b2-08d6-4c97-92ce-29f023395baf

MacOS: Chrome / Safari
Uploading web.mov…

MacOS: Desktop

https://github.com/Expensify/App/assets/104823336/63ae945c-4f44-4c52-98ef-6c383c03cb30

I will complete my review before Monday

Yeah, I will finish before Monday

@kosmydel  There nothing happens when clicking on "fix the errors"
https://github.com/Expensify/App/assets/141406735/8ffdf0a8-46b1-4450-9fc7-dde041749be8
@luacmartins What is expected for this case?

@kosmydel I have reviewed the PR. Please help to resolve comments and merge the latest main. Then I can complete the PR checklist and make a final test on the platforms
Note that: I am available from 8 am to 11:59 pm (GMT +7). Let's collab to merge this PR asap

@DylanDylann
I think I responded to all the comments.

There nothing happens when clicking on "fix the errors"

It scrolls to the invalid field, but most of the time it looks like it does nothing.
https://github.com/Expensify/App/assets/104823336/3566107d-084c-4a89-b58a-c32c213531df

Checking again

@kosmydel minor comments. Please update it
Waiting for translation confirmation here

@kosmydel Updated suggestion: https://github.com/Expensify/App/pull/37967#discussion_r1528442736

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Tests were passing

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Feature/probe

resolved: #94, #107
details:
need to fix test cases
Test case

[x] ping
[x] indirect-ping
[x] indirect-probe
[x] probe
[x] startFailureDetector

Now the code tries to process both the probe and the indirect ping in a single routine, which seems to require a lot of channels. It would be better to separate the probe and indirect and run them sequentially!

When to use timeoutFD?!


onChosen default animation is incorrect

The current animation performed when a card is chosen changes the frame of the card. This is not correct, because the frame won't be correctly changed since there is a transform applied to the card. UIView documentation says that only bounds and center should be changed when a transform is present.
There is a simple fix, though. Instead of changing the frame, just change the center to the center of the newly calculated frame.

Fixed in pull request #73.


Add docker-compose firefox

even deleting action file leaves phantom on PR - bad

closing as this is a duplicate


Allow to collapse sidebar even on Desktop.

The logic seem to be here already on mobile. I would suggest to extend it to be collapsible on Desktop as well, in order to have the option to get distraction-free reading.

I don't know if there's a way to hide it yet, but I can't find it, and I have a migraine from the accursed sidebar.

Because of RSI, I use an eye-tracker and foot mouse buttons to minimize hand use. The eye-tracker only works with a single-monitor setup. Even though I have the widest monitor that works with the eye tracker, the sidebar makes the main text extremely narrow when I have the documentation in a browser in one window at the same time as an IDE in another window.

My current workaround is to go into responsive design mode. (CTRL+ SHIFT + M on Firefox) I set the resolution to 768x847. The "responsive design mode" toggle toggles the sidebar.

Closing as dup of #987 that has more discussion about this.


sticky notes app completed

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] New and existing unit tests pass locally with my changes

Screenshots or example output

@Coderamrin Please add the issue associated to this PR.

tapas added the video

@Coderamrin
Thanks for your effort in building this.
Don't forget to tell the world about your work, and when you do so, please tag ReactPlay with a tag #2PlayAMonth.
Looking for the second one!

will do.
thanks for the assistance. : )


Value mappings

Would it be possible to set value mappings to be displayed in the panel ?
This will avoid many queries updates / data modification.
Anyway having this type of panel is amazing !
Thanks

Thanks for the suggestion, I think it's a great idea! Also don't think this would be to difficult to implement.


Google colab compatibility

Hello, I am sorry if this is a bit naive or silly. But I was wondering if PTArcade can be somehow made compatible with Windows, or can be made possible to be installed on Google Colab?
Before doing pip install, one needs to install Tempo2. And from what I gathered, it can not be installed on Windows. Due to such linux/ mac dependencies, I am unable to install PTArcade on Google colab.
Is it possible to have a version which works on windows too? Or if there's already a way to do it, I will be grateful for the help.
Also, this is the first time I am posting/ commenting on GitHub, so I am open to any suggestions/ feedback.
Thank you!

I was able to install dependencies like Tempo2, sckit-sparse using conda install on Google Colab after installing conda there. So now PTArcade was successfully installed. And hopefully it will work smoothly from here on. :)


How to use the rules

Hello. I'm trying to make sure that all my traffic goes directly (without a VPN), and from the Test application goes through a VPN. How do I do this? I kind of wrote the configuration, but when I try to connect, it just doesn't connect (there are no errors, and it doesn't connect). When checking the ping, it writes Timeout. I have written the configuration rules below. Help please. Did I write them correctly? Thank you.
"routing": {
"rules": [
{
"type": "field",
"outboundTag": "vpn",
"process": ["Test.exe"]
},
{
"type": "field",
"outboundTag": "direct",
"process": []
}
]
},

Я в этом не шарю, но методом тыка заработал такой конфиг. Спасибо за наводку.
"route": {
"rules": [
{
"type": "field",
"outboundTag": "vpn",
"process": [
"test.exe"
]
},
{
"type": "field",
"outboundTag": "direct",
"process": []
}
]
}
}

Такая же проблема, как получилось решить?


Add StackExchange.Redis 2.X.X package

Some of this can be cleaned up in the 3.0 change.
Basically copied all the SignalR.Redis and SignalR.Redis.Tests code into new folders and moved the TestConnectionMulitplexer file into both Test folders so the Test.Utils project wouldn't cause issues.
And skipped/removed all the unit tests for StackExchangeRedis.Tests which is tracked by https://github.com/aspnet/SignalR/issues/3088

Dang, guess I have to disable the Redis benchmarks for 2.2

As discussed in person, can you try to share as much of the code as possible? If only so the code reviewing is easier :).

Many thanks @BrennanConroy


Make ADB feature switchable

That's probably a good idea to make adb switchable within the configuration file, so user can disable all the port forwarding to host, if adb access is not required at all. This switch is also probably should be turned off by default, to minimize the possibility of some weird random issues.

Starting from the 2660cdbaad9a05a3df05a601dc10861afb19ac5e (Already merged to master branch), Android Debug Bridge port forwarding becomes the optional feature and must be enabled explicitly from the user configuration file variable.

Snippet from the default configuration
https://github.com/maximilionus/android-qemu-launcher/blob/2660cdbaad9a05a3df05a601dc10861afb19ac5e/vm.conf#L16-L17


fix: atomic creation of VMs or fast fail

From https://cloud.google.com/compute/docs/instances/multiple/create-in-bulk

Compute Engine creates at least MIN_COUNT VMs up to a maximum of COUNT VMs. If MIN_COUNT VMs can't be created, the request fails and no VMs are created.

Might be worthwhile to support folks who want to have a pool somewhere between 1 and their desired number of instances, but this makes sense for now and preserves prior behavior (from the n=1 case).


Benchmark Design

Output: Proposed Benchmark Design for MultiNet

[ ] Identify task-wise metrics
[ ] Formulate task-category-wise metrics
[ ] Formulate overall, unified metric


Add Order method for KeysetPaginationBuilder for conditional ordering.

Can be useful for cases when the order calculates based on a some input if we like to avoid redundant if-else branching.

Related to https://github.com/mrahhal/MR.EntityFrameworkCore.KeysetPagination/issues/50. Worth checking if you haven't.
I would rather make ConfigureColumn itself public. There's no need for an additional method that just calls into ConfigureColumn without doing anything else. Whether Order is a better name for this method can be argued though.
But as mentioned in https://github.com/mrahhal/MR.EntityFrameworkCore.KeysetPagination/issues/50#issuecomment-1779263978, if we do that I would want a KeysetColumnDirection enum instead of an opaque boolean for the isDescending param. You're welcome if you would like to work on that, but I would prefer a new PR.

I've just read #50 and agree.


[vk-bootstrap] New port

Describe the pull request
This adds the commonly used vk-bootstrap library as a port. vk-bootstrap is used to quickly and efficiently use Vulkan. This is based on the freshly released 0.5 version of the library.

Which triplets are supported/not supported? Have you updated the CI baseline?
All as far as I know.

Does your PR follow the maintainer guide?

Yes

Thanks for the new port!


Added backwards compatibility support for Windows XP

Fixes #130

Where is this code from actually? Does it have a license? If it's GPL for example we would be in trouble :) Otherwise LGTM, merge at will.

The code is from this Stack Overflow answer.
It was enhanced from code in this Stack Overflow answer within the same question.
Code on Stack Overflow is under CC-BY-SA 3.0.
The first link in BackwardsCompatiblity.cpp is the Stack Overflow question.
The only changes I made where to add code documentation/comments in the header of the files and fix a typo in the comments.
I can add more to attribute the authors in code comments as indicated here and also indicate the license of those two files.
After that, do you know if there's anything else I need to do?
Thank you.

I found this Stack Overflow answer where the author waived all copyright and related or neighboring rights to the code.
So I'm using that code instead.


Improve static example validation

Have I gotten the logic correct here? I think so.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS


[improve] Improve flink 1.15 dependency version

Problem Summary:
Improve flink 1.15 dependency version
What is changed and how it works?
Proposal: xxx
Feel free to ping committers for the review!
Contribution Checklist

Make sure that the pull request corresponds to a GITHUB issue.

Name the pull request in the form "[Feature] [component] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

Minor fixes should be named following this pattern: [hotfix] [docs] Fix typo in README.md doc.

Purpose of this pull request

LGTM


test: add test for sign_message

What I did
Was having a hard time figuring out now to sign a message. I thought there was a bug (I was using vrs when the eth-account module was asking for rsv). Nonetheless, I felt we needed a simple test for this, especially as there are no places where sign_message() is used.
How I did it

Test that the signature is expected
Test that the sender address is expected

How to verify it
test passses
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

Should we add a method to recover accounts from signatures?
Or maybe a way to to determine if an account signed something e.g.:
from ape.types.signatures import _Signature  # NOTE: baseclass of both signature types

...

class AccountAPI:
    ...

    def check_signature(self,
        data: Union[SignableMessage, TransactionAPI],
        signature: _Signature=None,  # TransactionAPI doesn't need it
    ) -> bool:
        if isinstance(data, SignableMessage):
            return self.address == Account.recover_message(data, vrs=signature)
        elif isinstance(data, TransactionAPI):
            return self.address == Account.recover_transaction(data.encode())
        else:
            raise Exception(f"Unsupported Message type: {type(data)}")

Yes. I much rather call an ape method for this.

If this merges in, I can create 2 non-urgent tickets in ape-ledger and ape-trezor (and ape-keyring) to use the new method in its tests


Understanding of jsa.np.rtSpeciesTyping output

Hi,
We just tested jsa.np.rtSpeciesTyping tool with a sample data and produced a .tsv file. Can you help me to explain what is the meaning of the header (reads, bases, prob, err, tAligned, sAligned)? Thanks a lot!

@hsnguyen Thanks!


Update requirements file and fix minimum pre-commit version

The .python-version file is using Python 3.6 which is really 3.6.15.
When installing pre-commit with pip under 3.6 it installs pre-commit version 2.17.0.
So I have downgraded the min pre-commit version.
Also I have removed the cloudmonkey package from the requirements file as we now use the Go CLI
When using Python 3 you cannot even install the original requirments.txt file.
The pre-commit package has also been added to the requirements file
Description
This PR fixes the requirements file and it will now install the Python packages

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Main steps were:
Installed python 3.6 with pyenv
I created a "cloudstack" virtualenv with pyenv and then installed the requirements file.
Then tested running pre-commit.

@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6872

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7293

for the sake of the change in requirements.txt I am going to run regression
@blueorangutan test

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8195)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44873 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7901-t8195-kvm-centos7.zip
Smoke tests completed. 113 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_trigger_shutdown
Failure
336.99
test_safe_shutdown.py

test_02_upgrade_kubernetes_cluster
Failure
553.71
test_kubernetes_clusters.py

failing tests are not due to this change or all would fail. agree @shwstppr ?


Merge develop to master (#25)

update the examples based on change in the config (#22)

Update README.md (#24)

Coverage decreased (-9.1%) to 90.854% when pulling 8eb5173e739fa8f931f7bd8440fc968918517160 on master into 8b9a56602c1d417f9112f3f5b07104d275086ea2 on develop.

Coverage remained the same at 100.0% when pulling 03b49151eb67858ec5d05a0c4ebfec54ec2e710a on master into 8b9a56602c1d417f9112f3f5b07104d275086ea2 on develop.


fixed link to getting started

Currently link "Getting Started" leads to 404 page.

In this PR the link is fixed.

@kostrubin thank you for your contribution, however the latest version is back in docs


Whats the usage difference between EspMqttClient::new and EspMqttClient::new_cb ?

TLDR: I want to know when should I be using EspMqttClient::new and EspMqttClient::new_cb ? Also I believe mqtt example should be updated.
documentation reference.

using EspMqttClient::new returns Result<(Self, EspMqttConnection), EspError>
while using EspMqttClient::new_cb returns Result<Self, EspError>

Note: I am using xtensa-esp32-.
Following the given mqtt example I am assuming that I need to use EspMqttClient::new_cb version. Which has been working as expected.
Here is my code snippet:
let mut mqtt_client = EspMqttClient::new_cb(&broker_url, &mqtt_config, move |_msg| {})?;

However, when I try to use the other varient EspMqttClient::new nothing is getting published to the mqtt broker, even though I haven't changed the publishing method.
Here is my code snippet:
let (mut mqtt_client, _mqtt_connection) = EspMqttClient::new(&broker_url, &mqtt_config)?;

What am I supposed to do with _mqtt_connection?
For reference, here is complete code snippet;
let mqtt_config = MqttClientConfiguration::default();
let mut mqtt_client = EspMqttClient::new_cb(&broker_url, &mqtt_config, move |_msg| {})?;

let payload: &[u8] = &[];
mqtt_client.publish("home/default", QoS::AtLeastOnce, true, payload)?;

Suggestion:
The example defines the new client as follows,
let mut client = EspMqttClient::new(&broker_url, &mqtt_config, move |_message_event| {})?;
but the function has been updated to use EspMqttClient::new_cb instead for EspMqttClient::new.
Updated code:
let mut mqtt_client = EspMqttClient::new_cb(&broker_url, &mqtt_config, move |_message_event| {})?;
PS: This is literally my first bug report/pull request, so please let me know if I need to provide any additional information or if there are any issues with my report.

First you can have a look at our official example here.
The technical difference between the two api's is that with the callback api, the things that need to be done will directly be called from within the thread that is executing the mqtt stack itself. This has pro's and con's. It maybe simpler to use as you don't have to fiddle with a messaging system, because you get everything directly handeld. One disadvantage is that you are executing in the mqtt stack itself, so you need to limit yourself with the work you are doing in the callback, so to not starve the system. The mqtt stack is executed in a higher priority thread.
With the "new" api your execution runs in either your main thread or in a separate thread.So running in general in a lower priority compared to the still ruining mqtt-stack thread. This rises to some awkard problems at the start, but in general decouples the system a bit.


⚠ Bofrost.es has degraded performance

In 3922f03, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1309 ms

Resolved: Bofrost.es performance has improved in 85a6a32 after 23 minutes.


[DEMO] Diagnostic Features

Method directive parameter validation
This is a very simple diagnostic feature, added as a first step to add a logic for further dignostic features in coc-laravel in the future.
https://github.com/yaegassy/coc-laravel/assets/188642/6ab9156a-bf99-4a71-9de9-e0bbb93675ed

Missing component validation
https://github.com/yaegassy/coc-laravel/assets/188642/d3877193-6c86-4cb0-99c9-f31ef871bf01


Minor side-channel security issue: SecretEqual() can reveal secret length

    private static bool SecretEqual(string inputA, string inputB)
    {
        if (ReferenceEquals(inputA, inputB))
        {
            return true;
        }

        if (inputA == null || inputB == null || inputA.Length != inputB.Length)
        {
            return false;
        }

        bool areSame = true;
        for (int i = 0; i < inputA.Length; i++)
        {
            areSame &= inputA[i] == inputB[i];
        }

        return areSame;
    }

Since we return immediately if input length doesn't match with the expected length, an attacker can figure out the length of a secret by observing the response time.
Fix: Introduce a for loop similar to the actual secret comparison routine inside if (inputA == null || inputB == null || inputA.Length != inputB.Length) clause before returning false.

Note: We're using the same implementation that @HenrikFrystykNielsen is using in his ASP.NET WebHooks library (source code here).

Closing this by design for now


Incorrect parsing of numeric values from glb file

When importing models from a glb file, properties cgltf_float of class cgltf_accessor such as 0.9999997019767761 and 0.9999993443489075 are parsed as 0, and -0.9999990463256836 as -0:

I already wrote to Khronos developers about why their plugin exports 1 and -1 values from Blender 3D so incorrectly, but they replied that this is a flaw in the JSON parser, not in their plugin.
I'm attaching some of my code:
if (data->accessors[j + iBufferView].has_min) ParsingMesh->vMin = glm::vec3(data->accessors[j + iBufferView].min[0], data->accessors[j + iBufferView].min[1], data->accessors[j + iBufferView].min[2]);
if (data->accessors[j + iBufferView].has_max) ParsingMesh->vMax = glm::vec3(data->accessors[j + iBufferView].max[0], data->accessors[j + iBufferView].max[1], data->accessors[j + iBufferView].max[2]);

and the textual analog of its glb file: model.gltf.json.
P.S. Parser TinyGLTF exports all numeric values correctly, but: https://github.com/syoyo/tinygltf/issues/483...

My guess would be that you're not using the English locale; cgltf uses stdlib functions like strtod for parsing, which are locale sensitive. Normally the locale would default to C but maybe something in your application is setting it to system; using setlocale(LC_ALL, "C"); before calling cgltf_parse could fix this.

The script gave a syntax error next to the unexpected token "LC_ALL," and this can't be done via C++ so I don't have to write a bash script?

The script generated a syntax error next to the unexpected marker "LC_ALL," but can't we solve this issue via C++ so that we don't have to write a script separately???

Thank you very much for the idea, added the following code and the parsing became correct:
#include <clocale>
* * *
setlocale(LC_ALL, "C");


Publish ember-list-view to npm

Self explanatory. Currently, https://www.npmjs.com/package/ember-list-view is a 404.

pushed,
@taras has been added as an owner, @tim-evans what is your npm username?

tce


Merge PR 47 to live

Docs Build status updates of commit 73be385:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/how-to-authenticate-an-ews-application-by-using-oauth.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


tools21cm

UZH provides a simulation tool for 21cm radiation and simulation of foreground signals

[ ] should we consider this package for our pipeline?
[ ] is this kind of radiation covered with the UZH simulation of WP-C331?

UZH WP-C331 work on H1 region structures of galaxies and larger structures. They intend to cover large scale with high resolution, where currently only one of them at a time was possible.
This may be the data which ETHZ is interested in since they intend to simulate intensity mapping with SKA interferometry I think?

We need this for #266 for gyro-synchrotron emission.

I was able to successfully create a conda-package from tools21cm. However, I think it makes sense to integrate this into Karabo-Feedstock, which is why I sent the associated meta.yaml @fschramka . The build is tested so far that I could install and import it into a Python3.9 venv with conda install -c i4ds -c conda-forge tools21cm. So the tools21cm version 2.0.2 can be built into Karabo and then specified as dependency.

It is also important to mention that version 2.0.2 was fixed to a commit on the master branch. I deliberately did not choose version 2.0.1 which is the current latest version on PyPi tools21cm because it depends on cosmospectra (very messy package which also has no Conda installation) and version 2.0.1 is also very old.

The integration into Karabo in terms of dependency resolvement worked and is integrated in PR #332 .
I think as soon as the build is integrated into Karabo-Feedstock we can close this issue.


Backblaze B2 transfers with an encrypted destination do not complete

Linked from #533
I have a B2 remote called "remote" and a secret remote going to this called "secret". I'm using the command line:
rclone -I -v sync etc secret:flibble/etc2 2>&1
The -I is there because I was getting errors where it wouldn't transfer because the modification times are the same, which is strange because the directory is empty on B2. This might be an indicator.
This is using the rclone beta provided by @ncw version v1.33-6-g2eaac80β running on Ubuntu 16.04 amd64.
The output is, with a few lines removed:

2016/09/06 09:49:04 rclone: Version "v1.33-6-g2eaac80β" starting with parameters ["./home/marc/git/rclone-v1.33-6-g2eaac80β-linux-amd64/rclone" "-I" "-v" "sync" "etc" "secret:flibble/etc2"]
2016/09/06 09:49:04 Encrypted Local file system at /remote/berbg28gsc22d0pktgipsqshkg/n9nn9n1mk24irmrt29gu5ce7ek: Modify window is 1ns
2016/09/06 09:49:04 resolv.conf: Can't transfer non file/directory
2016/09/06 09:49:05 legal: Uploading unconditionally as --ignore-times is in use
2016/09/06 09:49:05 login.defs: Uploading unconditionally as --ignore-times is in use
2016/09/06 09:49:05 mtab: Can't transfer non file/directory
2016/09/06 09:49:05 upstart-xsessions: Uploading unconditionally as --ignore-times is in use
2016/09/06 09:49:05 vdpau_wrapper.cfg: Uploading unconditionally as --ignore-times is in use
....many, many other files uploading unconditionally
2016/09/06 09:49:30 fonts/conf.avail/58-dejavu-lgc-sans-mono.conf: Copied (replaced existing)
2016/09/06 09:49:30 fonts/conf.avail/57-dejavu-sans-mono.conf: Copied (replaced existing)
2016/09/06 09:49:30 ssl/certs/java/cacerts: Copied (replaced existing)
2016/09/06 09:49:30 Waiting for deletions to finish
2016/09/06 09:49:30
Transferred:   8.023 MBytes (322.229 kBytes/s)
Errors:                 0
Checks:              1869
Transferred:         1869
Elapsed time:       25.4s
2016/09/06 09:49:30 Go routines at exit 2

This actually completes near instantly, but you see different timestamps because I used less. Nothing is actually transferred to B2 from what I can tell.

It looks like a total of 8 MBytes of files were transferred.
What do you see when you do rclone ls secret:flibble/etc
How are you looking to see whether files are transferred or not? What do you see on the web interface?
And in the definition of your crypt remote did you chose a bucket, eg b2:bucket as the docs recommend?  If you didn't then rclone will have created a new funny named bucket (lots of lower case letters and numbers) to store flibble in. That might be confusing things.

Hi,
OK, I've got there in the end. It is because the crypt remote didn't have a bucket specified. I think it was copying the files locally instead. So human error, but perhaps an enhancement would be to warn about locally copied files, missing buckets or something similar.
I've left my thought process below in any case:

I agree it looks like there was a transfer. For the whole lot to finish within a second makes me think that nothing was transferred.
The web interface shows no files in the etc2 directory and no additional buckets or directories having been created.
Interestingly, rcclone ls secret:flibble/etc2 does show all the files (and returns instantly, like it's not actually connecting to a remote host):

    8 hostname
   18 subuid
 1078 group-
   12 debian_version
67946 mailcap
 1094 group
  436 hosts.sbak

...

But doing rclone ls remote:flibble/etc2 shows nothing (and takes a few seconds):

    0 .bzEmpty

2016/09/06 10:35:49
Transferred:      0 Bytes (0 Bytes/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:        2.5s

In the definition of the crypt remote, no, I did not specify the bucket. However, as I'm doing it on the command line (the bucket name being flibble) should this make a difference? I certainly don't see any additional buckets having been created. [and then I created a new crypt remote and it worked]

Many thanks for your help here, and it looks like the transfer and sha1 issue is fully resolved as I see properly encrypted files, with encrypted filenames, in B2 now.

Ah, so you put as your remote in remote rather than remote: or remote:bucket.  I'll try to make the docs a bit clearer here.  Maybe I can get the crypt to give a warning (though I do use crypt a lot to and from local disk for testing).
I'm glad you've got to the bottom of it, and I'll leave this ticket open to remind me to put some more stuff in the docs.

Yes, that's exactly right. I guess in this case, it acts like scp when you don't have a host (i.e. a ":").

I've fixed this with this text
Remote to encrypt/decrypt.
Normally should contain a ':' and a path, eg "myremote:path/to/dir",
"myremote:bucket" or maybe "myremote:" (not recommended).


Install Bob v2.0 on Ubuntu 14.04LTS ？

Hi，
I have read the paper <Bob: A Free Signal Processing and Machine Learning Toolbox for Researchers>, and I am interested in it. But when I install this toolbox by myself, there is an problem.  The problem is described as follow:

Install Bob v2.0 on Ubuntu 14.04LTS

All external dependencies are installed. (https://github.com/idiap/bob/wiki/Dependencies)

In the process of intalling, I got a cue that the version of setuptools is too low,
so I install setuptools v8.3 (https://pypi.python.org/pypi/setuptools)

In Python 2.7.6  and Python 3.4.0, when executing /bob-master/bin/buidout, the errors emerge ：

An internal error occurred due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "/home/ABC/bob-master/eggs/zc.buildout-2.3.1-py3.4.egg/zc/buildout/buildout.py", line 1946, in main
    getattr(buildout, command)(args)
  File "/home/ABC/bob-master/eggs/zc.buildout-2.3.1-py3.4.egg/zc/buildout/buildout.py", line 488, in install
    installed_develop_eggs = self._develop()
  File "/home/ABC/bob-master/eggs/zc.buildout-2.3.1-py3.4.egg/zc/buildout/buildout.py", line 730, in _develop
    zc.buildout.easy_install.develop(setup, dest)
  File "/home/ABC/bob-master/eggs/bob.buildout-2.0.1-py3.4.egg/bob/buildout/extension.py", line 212, in develop
    zc.buildout.easy_install.call_subprocess(args)
  File "/home/ABC/bob-master/eggs/zc.buildout-2.3.1-py3.4.egg/zc/buildout/easy_install.py", line 159, in call_subprocess
    % repr(args)[1:-1])
Exception: Failed to run command:
'/usr/bin/python3', '/tmp/tmp5v2u3945', '-v', 'develop', '-mxN', '-d', '/home/ABC/bob-master/develop-eggs/tmpjdlacslcbuild'

THX a lot.

We had some trouble with buildout, where the authors of that package have lately changed the bootstrap.py to bootstrap-buildout.py. Your issues might be related to that.
We have now corrected the installation instructions in https://github.com/idiap/bob/wiki. I hope that this solves your problem. As usual, try to clean up everything and start the build process from scratch.

I am still facing the issue on Mac OS X . What changes need to be made for configuration file?

No feedback on this one after 2 months. @StevenLobo2, please check discussion about your OS X issue in the other bug. I'll close this one. Otherwise, please start a thread at our mailing list: https://groups.google.com/forum/?fromgroups#!forum/bob-devel


Lazily decode chunks for fuzzy metric names

Can use an interval tree to find chunks intersecting a time point. (chunks can overlap in cortex)

We've made the decoding lazy in the chunk store in #873, and use iterators for chunk access, so I think this can be closed.


Add default_authentication delegates

Add delegates similar to the ones for the default endpoint simplifying accessing and assigning the default credentials

@agrare ping when you made those rubocop changes.
LGTM


feat: auto inject keyframe

Codecov Report

Merging #27 (93bc630) into master (3ec21fa) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 93bc630 differs from pull request most recent head 352a86f. Consider uploading reports for the commit 352a86f to get more accurate results

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   98.69%   98.68%   -0.01%
==========================================
  Files           8        8
  Lines         306      304       -2
  Branches      105      104       -1
==========================================
- Hits          302      300       -2
  Misses          4        4

Impacted Files
Coverage Δ

src/Keyframes.ts
100.00% <100.00%> (ø)

src/useStyleRegister.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec21fa...352a86f. Read the comment docs.


Add an ability to choose center of the particle set during display

As an example one may want to focus on (weightened) median instead of mean (which is center of mass) or even on some particular particle.

Even more usecases:

want to sort particles by potential, take the lowes few and compute their average position. Than use it as a center.


Camera is not correctly rotated

1 - Open camera
2 - Rotate mobile device
3 - Image shows cropped and with wrong orientation
4 - Rotate mobile device again
5 - Image shows cropped and with wrong orientation

iOS/Android?
Device/Simulator?
React-Native version?
OS version?

@guyca Can u take a look plz? u like to rotate the device lately 🤠

Is there any news about this?

I'm attaching some screenshots of my App. Please, I need a fix ASAP for this. How could I help?
This is how the app looks before opening the camera:

This is the camera when I start it:

This is the camera in landscape mode:

The I move the device to portrait mode again:

Finally, I close the camera an the App shows a black square on the bottom.

The issue can be reproduced on IOS (Tested on Ipad)

Hey there,
You should lock the device orientation when showing the camera view. The native camera view doesn't support orientation changes, we should mention this in the docs.
The actual image should be taken according the the device rotation angle even if orientation is locked.

How can I accomplish that? I' doing some researching.

Anyone fix this?

I simply decided to delete the frame, and just work with the basics for landscape use:
`<CameraKitCameraScreen
    actions={{ rightButtonText: "Done", leftButtonText: "Cancelar" }}
    onBottomButtonPressed={() => this.props.goBackCodeReading()}
    scanBarcode={true}
    onReadCode={event => {this.props.callback(event.nativeEvent.codeStringValue);}}
  />`

Later, you can overlap a frame with another component and style. Hope this helps someone

Android is being redone. Closing this for now.


Inconsistencies when type arguments are missing from generics

Suppose you have the following declaration for a generic data structure:
declare class MySet<T> {
  constructor();
  add(key: T): MySet<T>;
  delete(key: T): boolean;
  has(key: T): boolean;
}

If you attempt to initialize a variable by instantiating this class without specifying a type argument, the compiler will still accept it as valid code and set the type of the variable by performing type inference:
var ms = new MySet();

However, if you manually specify the variable type but omit the type argument, the compiler will report an error:
var ms: MySet; // error TS2314: Generic type 'MySet<T>' requires 1 type argument(s).

This behaviour seems to me a bit inconsistent: I'd expect both to work and be equivalent.
Another inconsistency is that the inferred type of the variable ms seems to be MySet<{}> instead of MySet<any>. I understand the reasoning behind this (to be as conservative/strict as possible with the inferred types), but this is probably surprising given that for the built-in Array type, if you write new Array() you get the inferred type any[] and not {}[].
The other generic types in the standard library (e.g. Set, Map) suffer from this inconsistency as well.
var m = new Map(); // Map<{}, {}>
var s = new Set(); // Set<{}>
var a = new Array(); // any[]

var m2: Map; // error TS2314: Generic type 'Map<K, V>' requires 2 type argument(s).
var s2: Set; // error TS2314: Generic type 'Set<T>' requires 1 type argument(s).
var a2: Array; // error TS2314: Generic type 'Array<T>' requires 1 type argument(s).

For maximum consistency, it would be nice if the arguments were also inferred when manually specifying the type of a variable, and if it was possible to specify a default type for generic arguments:
declare class MySet<T = any> {
  constructor();
  add(key: T): MySet<T>;
  delete(key: T): boolean;
  has(key: T): boolean;
}

var ms = new MySet(); // MySet<any>
var ms2: MySet; // MySet<any>

With this feature, the Map and Set generic types in the standard library could then be updated to match the behaviour of the Array built-in.

Some reasonable arguments here. Here's where things stand today and why:
var ms = new MySet();

This infers MySet<{}> today and is not an error. We give an error when type argument inference has multiple candidates that conflict (ie result in {} as a best common supertype) but not when there are 0 candidates. We have talked in the past about making this an error but it is a breaking change. We'd have to be very sure we're only breaking code that is essentially already broken. For example with these types of collections there's no error upon construction, but generally at some point later we do report an error when you have to interact with the {} type that was inferred. Giving the error sooner (essentially requiring explicit type arguments on the constructor) could be an improvement.
var ms: MySet; // error TS2314: Generic type 'MySet<T>' requires 1 type argument(s).

This is disallowed under the assumption that you went to the trouble to write a TypeScript type annotation and we feel it's a little silly to allow you to write such a useless type annotation. This differs from the new MySet case because in one you have very explicitly done extra work to help the TS compiler (presumably to help yourself get good strong typing), while in the other you've simply brought along some working JavaScript. This rule also first came into being when the default inference for type parameters was any and not {} so allowing you to accidentally end up with a MySet<any> was even worse than a MySet<{}>.
Array has a signature that returns any[] for new Array(). Set and Map do not have this sort of signature but probably should. Default type parameter values are a thing that has come up before I think. The simpler solution for now is definitely to fix the construct signatures for Set and Map.

It currently appears to be inferring any instead of {} even when --noImplicitAny is turned on.
The following compiles just fine:
const m = new Map()
m.set(0, 1)
console.log(m.get(0).toUpperCase())

looks like https://github.com/Microsoft/TypeScript/issues/2175 should address the underlying issue.


Gradle considers tasks up-to-date when it should not

Here's a doozy.
Given a task like this (distilled to just the important parts):
class CustomTask extends DefaultTask {
    @OutputDirectory File outputDir = new File(project.buildDir, "output")

    @TaskAction
    public void generate() {
        File outputFile = new File(outputDir, "file.txt")
        outputFile.text = "generated"
        outputFile.lastModified = 0
    }
}

and a build file:
task customTask(type: CustomTask)

If you run this sequence of steps, the customTask will be up-to-date even though build/output/file.txt does not exist.

Run gradle customTask as usual. (Gradle will execute the task, the file is created.)
Upgrade Gradle or delete the project .gradle.
Run gradle customTask. (Gradle will execute the task, the file is not overwritten.)
Run gradle clean. (Gradle will delete the file.)
Run gradle customTask.  (Gradle will mark customTask as up-to-date.)  This is wrong.

Expected Behavior
Gradle should not consider the task up-to-date.
Current Behavior
Gradle considers the task up-to-date.  The only way to get out of this state is to change an input to the task or run with clean and --rerun-tasks.  A clean alone isn't enough to cause the task to re-execute.
Context
This problem was found with a task that uses javah to generate header files.  javah will not overwrite header files if the source file has not changed.  This combined with a Gradle upgrade (or loss of the .gradle directory) caused the up-to-date checks to consider a task up-to-date because it had no output snapshots.
I think the problem has something to do with this check:
https://github.com/gradle/gradle/blob/b708c31ed0e78ecf1bcc2d63812ab09418c1498e/subprojects/core/src/main/java/org/gradle/api/internal/changedetection/state/OutputFilesSnapshotter.java#L79-L79
When a file exists in an output directory before the task executes and the file doesn't change (modification time or content), we don't consider it part of the output snapshot.
Steps to Reproduce (for bugs)
See integration test: https://github.com/gradle/gradle/blob/master/subprojects/core/src/integTest/groovy/org/gradle/api/tasks/IncrementalBuildIntegrationTest.groovy#L1132-L1132
Your Environment
Observed on macOS, but I would suspect any OS would do.

If #1074 is merged, we could register the output file for cleanup and that would fix the problem, right?
For caching, we would cache the right thing on the first run since we cache all of the outputs but we wouldn't pull from the cache after the clean since the task is UP-TO-DATE, right?
If we would not have overlapping output directories then we should just consider everything in the output directory as an output for a task - regardless if it has been modified or not.

Yes, i think that would have helped.

When we know that the task owns the output directory (using the same information by which we know that we can clean the directory on version change) then we certainly should consider the entire contents of the directory to be the task's outputs.
We'd also need to do some form of cleanup prior to running the task's actions, to deal with other tools that scribble into the output directory. We might remove those output files that have changed since the task was last run (where 'add' is-a kind of change), or just remove all of the outputs when we need to run the task's actions (for tasks that aren't incremental of course).

This issue was of significant impact to us after our last Gradle upgrade. In our case, the Gradle tasks that delegate to our gulp tasks are being incorrectly marked as UP-TO-DATE, which causes the WAR file to be built without CSS and other front-end files.
We're seeing the scope of this issue to be greater than what is listed here, specifically:

Step 1 is extraneous. We can reproduce this issue whether or not the task was run previously prior to the upgrade or removal of the .gradle folder.
Step 2 can also include a fresh clone of the repository. Issue occurs after the first clean.
Only changing an input resolves the incorrect state. Running clean with --rerun-tasks does not resolve the issue.
We see the issue even when the files are rewritten and the modification time changes. (*)
We can also reproduce this with 3.2.

This was particularly challenging to track down as most of our developers are not updating front-end files and were considering most actions they took other than clean to be the trigger. This also causes unreliable builds in CI systems that clean but do not nuke the entire working directory.
(*) While I can reproduce this reliably in our project with Gradle releases >= 3.2, so far the modification time is the only item above that I've been able to simulate in the integration test, so I'm still looking for an additional contributing variable.

This issue was of significant impact to us after our last Gradle upgrade. In our case, the Gradle tasks that delegate to our gulp tasks are being incorrectly marked as UP-TO-DATE, which causes the WAR file to be built without CSS and other front-end files.

This is exactly the same problem for us, and it's biting us really bad.

Although the symptoms spread to the gulp tasks, it's the npmInstall task that has similar behavior to the javah command where files in the node_modules dependency folders are not touched when the task runs if they already exist.
@ketan: We are working around the problem by adding a task action that updates the last modified time of any output file of tasks with the problem (only npmInstall in our case). See this gist for the details: https://gist.github.com/jjustinic/f86451edc3ff1de41966a687630664e1.

This will be fixed in 4.2.

I'm running on a recent nightly Gradle 4.2-20170810012648+0000 with revision 569d3e31713898f8f7e6b90882841dc666427cfd. I'm still hitting the same issue.
My custom task is a wrapper around that executes yarn run ${inputArgs}, and generates JS assets for a webapp. Since this is usually an expensive operation, I've added a @CacheableTask annotation to it.
However when I manually remove the assets dir (declared as an @OutputDirectory) using rm -rf ..., gradle says that the task is UP-TO-DATE and does nothing.
I've read my code to make sure that I'm not doing something obviously wrong, and I'm fairly confident it's not. If there's any specific debugging I can help with to resolve this issue, I'm happy to help out in any way.

@ketan Thanks for the feedback. Could you describe how you got into that situation? Could you provide a reproducible way how to get into that situation?
Does the asset dir live within the build directory?

Thanks for the feedback. Could you describe how you got into that situation? Could you provide a reproducible way how to get into that situation?

Does the asset dir live within the build directory?

No, it does not. I'm not sure how to reproduce this issue anymore. I blew away the .gradle dir in my project root and cleared the gradle cache under ~/.gradle/cache/build-cache-* and things are back to what's expected....

@ketan The bug is only fixed for outputs which we think are safe to delete. This is everything the clean task would remove. So if you add the output directory of your task as a clean target to the clean task, then the problem should be gone. You can do something like this:
clean {
    delete 'path-to-output-dir'
}

Hi @wolfs
Why only safe to delete outputs?
Is in it better maybe a new annotation which force outputs to be taken in consideration ?
thanks ahead Jonathan

Hi @wolfs
I was able to reproduce the  issue even when setting the 'path-to-output-dir' in the clean task.
Step to reproduce:
1. Create a root  folder with a build gradle script
2. Add the following code to the script:
apply plugin: 'base'
defaultTasks 'create'
task create {
inputs.file "${projectDir}/in.txt"
outputs.dir "${projectDir}/result"
doLast {
def f1 = file("${projectDir}/result/file1.txt")
if (!f1.exists()) {
f1.text = "Foo"
println "File was created in executrion: ${f1}"
}
}
}
clean { delete file("${projectDir}/result") }

Run the task create , it will create the result/file1.txt file
.4. Change the task name create to create1
Run the task create1 it will run (execute) but without creating the file (since it exists already)
Delete manually the file1.txt and re-run the task create1 - it will show as up-to-date and it will not create
the file

I tried in the clean task to set the delete with task.create1 then task.create1.outputs  then with path to the Dir hard-coded, each time same result: Up-To-Date
Thanks
Jonathan

@Jonatha1983 Thank you for the example. You are right, renaming a task will not result in the files from the now non-existing tasks to be cleaned up. The simple reason is that Gradle has now way to know that the task has been removed. So the result/file1.txt is still an output of the create task. I can't see how Gradle could track the renaming of tasks.
What could be possible is that a task could declare that it has exclusive access to the output directories and Gradle could clean up the output directories if that is the case. But that is a different story.

@wolfs  Thanks for your answer.
I meant to demonstrate files created by a different source and with some logic that they would not be created when run the 2nd time - the rename of the task is confusing in this regard and I did not mean to refer the rename operation itself.
Since a lot of tools (npm included) perform some caching and optimization, the combination with Gradle's incremental feature will results in hard-to-find bugs until such an annotation of exclusive output for a task will exist. For the sake of exclusive outputs - I think it would be better for gradle to cache whatever exists in the folder before the task runs rather than cleaning.
We used to work around it by touching the files during the execution phase, but obviously it is a fragile workaround that lacks real optimization.
Thanks again


[WIP] Workflow automation tutorial

I'm not sure where this belongs, to be honest. I know it uses variant analysis but since it doesn't cover science really, just the dev portion, I'd lean to this belonging more in the dev section?

Maybe into "Using Galaxy and Managing your Data"

yeah better suggestion @bgruening!

Yes, I was also unsure about the section. I don't think it really fits in the dev section, it's definitely targeted at users rather than devs.
"Using Galaxy and Managing your Data" is a good idea, thanks @bgruening.

@simonbray is this still WIP or can we merge it?

Still WIP @shiltemann. Going to add a section or so this afternoon/tonight.

ok great!


Injected web3 is not properly detected

When using this with MetaMask the check for typeof web3 !== 'undefined' fails in getWeb3.js causing fallback to local web3
Error Received
console.log of 'No web3 instance injected, using Local web3.' even though MetaMask is enabled.
Fix:
Replace usage of the local web3 with window.web3 IE:
window.addEventListener('load', function(dispatch) {
    var results

    // Checking if Web3 has been injected by the browser (Mist/MetaMask)
    if (typeof window.web3 !== 'undefined') {
      // Use Mist/MetaMask's provider.
      results = {
        web3Instance: new Web3(window.web3.currentProvider)
      }

      console.log('Injected web3 detected.');

      resolve(store.dispatch(web3Initialized(results)))

https://github.com/apackin/groupBuy/commit/a6881c53fa1d0271a14766a86e1e6d9dd25086fb

Thank you for formatting this so well! It's now fixed.


shared_queue consuming higher memory

Describe the bug
We have 5 Sink objects and our application is crashing due to out of memory. The shared_queue shows count around 131071 in the crash dump. We are on 2.4 version of g3log.

Windows 10, Visual Studio 22, C++ 17, build x86

Is this a bug or bad configuration please suggested?

While there are custom setups out there that have restrictions of the queues usage the default is that it doesn't restrict
It does seem to be a lot of objects in the queue.
There's lots of unknowns here

What type of logging philosophy is followed -- is this a case of logging too much and simply overwhelming the system?

5 sinks is more than I typically see, I'm assuming these are custom sinks. What type and what differences are there between the sinks

Have you diagnosed them to make sure none of them is blocked? A blocked sink, or a sink moving slow in a situation where logs aren't restrictive and its full throttle will lead to a continuously growing queue.

Thank you very much for your prompt response. I apologize for the delayed reply on my part.

Not exactly; we're simply pushing data to the G3Log queue with a specific delay, and we use our own wrapper class for this purpose.
Our use case involves five different sinks, each logging to a separate custom file, with the files being archived once a certain count threshold is reached.
We discovered this in the crash dump but did not find any blocked threads.

Hi @nand2023  since you closed it, I figure it's resolved.
it would be great if you could share the root cause in case other people run into some similar scenario in the future.

Hi @KjellKod We are continuing our investigation into this issue and have not yet identified the resource-intensive module in our project.
The reasons for considering this bug resolved are as follows:

Based on your observation, the custom sinks might be the root cause in our case, which seems valid. We are further exploring this possibility.
Given the queue count of 131,071, and assuming a maximum log data size of 300 bytes, the total size amounts to approximately 40 MB. This suggests that another component may be consuming the remaining process memory.

If we identify a bug in the G3Log code, we will certainly share a patch.
Thank you for your insights and support.


Multiple embedded profiles

Fixes the multiple embedded profiles found error with applications that also have watchapp included.

:+1:  nice @birmacher . Now we don't have to use our fork.


Use Async Interop

Q
A

Bug?
no

New Feature?
yes

I think it's time to begin the work to use the standard defined by async-interop : https://github.com/async-interop.
Their are not stable, but it's, from what i have seen, in a testable state.
So I think this is better to give it a shot now, as we can give some input before it's done and make some adjustement to the spec if needed.
But before doing that :

Do you agree on using this standard ?
How should we do for dealing with BC, should we add a compatibility layer in 1.X (will be hard i think) or do we switch directly to the 2.0 ?

IMO, we should use this standard, people working on it are contributors of all majors async framework in the php world (amp, icicle, react and others), even if they are not going to be a PSR standard i think it will be the defacto reference to do async in PHP.
For the BC layer i want to propose to create a new package for async and deprecate the current interface and decide on a time for going to 2.0 (like 1 year) where we will remove this interface.

begin to work on it on https://github.com/php-http/httplug-async

Sorry for not getting back earlier. I have been looking at the async-interop as well prior to our first HTTPlug release. Normally it would be okay for me to switch to a stable-enough interop project, even if it means a BC break on our side to use the PSR growing out of it (as we also did it ourselves), because it might take a lot of time to get there.
However, in our case async is used in plugins which makes me think whether we really want to break BC to use the async-interop and then break BC when the PSR is out.
The fact that major version let's us breaking BC does not mean we should do it.
Also, even if it's not going to be a PSR, I am not sure if async-interop is stable enough. Looking at the dependents of the composer packages: none of their authors use them in their packages.

i agree with mark, BC breaks are ok between major versions, but not a
great thing even then.
imho we are in no hurry with this, lets see for a while how fast psr
advances and how much adoption the interop thing gets and then re-discuss.

imho we are in no hurry with this, lets see for a while how fast psr
advances and how much adoption the interop thing gets and then re-discuss.

I updated the PR with last version.
In term of adoption, all major projects of async contribute on this spec, so it will be compatible with all library using async behavior then it sure will be adopted. Like php-http, adoption of this spec is not user related but more library related and this is already the case.

In term of BC i didn't think too much on how we should handle this, my first goal is to achieve the wanted behavior with this new specification and then think about we switch from our old spec to this new one.

closing this async interop is on hold


Asset Suggestion: CryptoCrystal

Name: CryptoCrystal
Kind: ERC-721 nonfungible token?
Smart Contract(s): Will update when known (NOT the ERC-20 address).
Website: https://cryptocrystal.io/

According to website, pre-release stage.


Add newer tests to the tsdb module for validating chain propagation

Describe
As the database is managed by the tsdb, the data is being stored in the JSON file in the form of an array of objects. The JSON file contains a chain of blocks and various operations are implemented on the data like append, pop, Positional Block etc. So during the use of the data, we need to validate if the data stored is correct or have been corrupted in the way while performing different functions.
There are various ways. As one of them is that the data can be tested by chain propagation i.e. propagating through every block of the element and making a check does the address of the Next Block exists or not. And finally having a check on the length of the element with the loop size for the final confirmation.
Other suggestions are most welcome.

@Jayashree-panda  please have a look

@Harkishen-Singh I would like to work on this.

@binayakbehera999  sure. pls go-ahead


[AMBARI-26185] Upgrade commons-collections to resolve CVEs

What changes were proposed in this pull request?
upgrading commons-collections to 4.4
(Please fill in changes proposed in this fix)
How was this patch tested?
tested on installing a local cluster.
all services and ambari server was start with no error.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

@sandeep318kumar Since the previous /jdk-spring-dependencies was not correct, I updated it and submitted a PR for verification. All tests have passed. Your PR's CI/CD failed. You can take a look at the PR I submitted based on upgrade/jdk-spring-dependencies. The CI/CD has passed: https://github.com/apache/ambari/pull/3873"
Let me know if you need further adjustments!

Few test cases have failed in CI. Working on fixing them.

Http status 400- bad request is coming.

@JiaLiangC @virajjasani @zRains any idea? how to view CI runs now?

@sandeep318kumar The Apache foundation team updated the CI environment, which caused incorrect redirect links here. I'll provide you with a link, please check if you can open it. https://ci-hadoop.apache.org/job/Ambari/job/Ambari-PreCommit-GitHub-PR/view/change-requests/job/PR-3871/

full log: https://ci-hadoop.apache.org/job/Ambari/job/Ambari-PreCommit-GitHub-PR/view/change-requests/job/PR-3871/6/console

Thanks @JiaLiangC I am able to open this.


php artisan migrate error

Symfony\Component\Debug\Exception\FatalThrowableError]   Type error: Too few arguments to function Illuminate\Cache\Console\ClearCommand::__construct(), 1 passed in C:\xampp\htdocs\bukang\vendor\laravel\framework\src\Illuminate\Foundation\P   roviders\ArtisanServiceProvider.php on line 217 and exactly 2 expected
i don't know what is wrong?

This… rather seems like a problem within the Laravel framework?
Also pretty sure, this dating back to 2017 that it was based on versions we're not supporting anymore
@barryvdh without more info I suggest to close this issue :}


Certain Symbols and/or Text Not Showing

Steps to reproduce

Expected behavior
The text should be showing on the reader.
Actual behavior
Specific Symbols and/or Text does not show.
LNReader version
2.0.0-beta.2
Android version
Android 14
Device
Nothing Phone (2)
Other details
I have texted with other sources and the issue is the same.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 2.0.0.
[X] I will fill out all of the requested information in this form.

Fixed, issue can be closed.


Incorrect capitalization of securityContext

What happened?
The RedPanda CRD defines clusterSpec.statefulset.sideCars.configWatcher.SecurityContext (with a capital S) and will pass it on as SecurityContext to the values section of the HelmRelease. However, the chart expects securityContext. As a result, the configured config watcher security context will be missing.
What did you expect to happen?
Configuring the config watcher security context via the CRD should add it to the statefulset.
How can we reproduce it (as minimally and precisely as possible)?. Please include values file.
apiVersion: cluster.redpanda.com/v1alpha1
kind: Redpanda
metadata:
  name: redpanda
  namespace: redpanda
spec:
  chartRef: {}
  clusterSpec:
    statefulset:
      sideCars:
        configWatcher:
          SecurityContext:
            allowPrivilegeEscalation: false
            runAsNonRoot: true

Anything else we need to know?
No response
Which are the affected charts?
No response
Chart Version(s)
chart repo commit f09c338cb40aceda1578ad724ef5b155765f41d5
Cloud provider
AWS EKS

great catch!


Split override 快退

快退 快退 [kuai4 tui4] /fast-rewind (media player)/
But 快退 can also be used for commanding people to 'quickly move back', e.g.,
https://www.youtube.com/watch?v=dQyNgCDhoVA&t=508.25509s#:~:text=快退

Unfortunately I'm struggling to make it out from just the audio

Unfortunately I'm struggling to make it out from just the audio

Prior to split override, the English is annotation was fast-rewind (media player), media player is not yet invented at the time :D


Update Tor site http://oshiatwowvdbshka.onion/ for https://oshi.at (URGENT)

Hi.
This is not an issue,its more of a question for you.
There is no email to send to you,so I'll post it here.. Could you please update the site http://oshiatwowvdbshka.onion/ to v3? It will end soon. check out: https://support.torproject.org/onionservices/v2-deprecation/

Thanks for bringing it into concern, the onion address will be migrated to v3 soon.

The current onion address is 5ety7tpkim5me6eszuwcje7bmy25pbtrjtue7zkqqgziljwqy3rrikqd.onion, however we may add yet another address within next weeks.


Minimal speculative decoding implementation

Add support for base speculative decoding. Currently does not support batching or efficient kv-cache memory management.
(12/8/23: batching has been added)
Demo is a notebook running Llama-7bF with speculator on cpu, using model weights that I have stored locally. Let me know how/if this should be changed to a demo format more proper for the repo

Added a speculative_inference.py demo script, and updated speculative_generate() to accept inputs of varying lengths. Note that this does make the setup for the prefill step slightly ridiculous, and mypy is complaining due to not linking the paths of a couple if/else trees. Will try to clean that up later

OK, tests should be passing now. Outstanding issue at this point is the question of broader support for include_embeds in generative models (beyond just Llama)

@daviswer since we're putting a speculator in fms-extras, should this PR be closed?


mysql bley_log is created bot not populated

My mysql bley_log is created but when bley runs.. the disk log shows;
2019-04-02 13:44:53,231 bley: decided CACHED action=DEFER_IF_PERMIT This server employs greylisting as a means of reducing spam. Your message has been delayed and will be accepted later. (cached result<EMAIL_ADDRESS><EMAIL_ADDRESS>but the sql log table does not get update.
I have the bley.conf file doing:
Where to save the log file?
#log_file = syslog
log_file = /var/log/bley.log
I didn't see a log to sql table option. I see where it's supposed to do:
    def dump_log(self):
        query = '''INSERT INTO bley_log (logtime, ip, sender, recipient,
                action, check_dnswl, check_dnsbl, check_helo, check_dyn,
                check_db, check_spf, check_s_eq_r, check_postmaster,
                check_cache)
                VALUES(%(time)s, %(ip)s, %(from)s, %(to)s, %(action)s,
                %(DNSWL)s, %(DNSBL)s, %(HELO)s, %(DYN)s, %(DB)s,
                %(SPF)s, %(S_EQ_R)s, %(WHITELISTED)s, %(CACHE)s)'''

but I don't see it doing that... or giving me an error.

The logging only happens once every 30 minutes and on app-shutdown:
https://github.com/evgeni/bley/blob/c7ee10966c4ee8ec26f42a32042a31ed0b1e9d65/bley.py#L411-L412

Closing due to inactivity and me believing this works fine.


Error when creating a new project on deploy in Azkaban 3.59.0

We are currently running Azkaban 3.1.0 in our production environment and all aspects of this code works great on 3.1.0.
However we are in the process of getting 3.59.0 working in our lab, in preparation of upgrading to a more current version. Almost everything works, however we have one issue that we have discovered.
Issue

We execute the following to build and upload a project: azkaban build -cp project.py -a lab-azkaban
When a Project does exist in Azkaban, the build and upload works without issue.
When the project does not exist in Azkaban, get this error after we enter the password and press enter to upload the project:

Azkaban password for username@http://azkaban.example.com:
Traceback (most recent call last):
  File "/path/to/virtualenvs/venv_name/lib/python2.7/site-packages/azkaban/util.py", line 310, in wrapper
    return func(*args, **kwargs)
  File "/path/to/virtualenvs/venv_name/lib/python2.7/site-packages/azkaban/__main__.py", line 502, in main
    ['ZIP', '--url', '--alias', '--replace', '--create', '--option']
  File "/path/to/virtualenvs/venv_name/lib/python2.7/site-packages/azkaban/__main__.py", line 460, in build_project
    res = _upload_zip(session, project.name, _zip, _create, archive_name)
  File "/path/to/virtualenvs/venv_namelib/python2.7/site-packages/azkaban/__main__.py", line 320, in _upload_zip
    callback=_callback,
  File "/path/to/virtualenvs/venv_name/lib/python2.7/site-packages/azkaban/remote.py", line 673, in upload_project
    data=form,
  File "/path/to/virtualenvs/venv_name/lib/python2.7/site-packages/azkaban/remote.py", line 902, in _request
    raise err
HTTPError: 410 Client Error: Gone for url: http://azkaban.example.com/manager

This error only manifests when we have the -c argument being passed and the project does not already exist. If the project already exists, then the build and upload works without issue.
Are there any recommendations regarding where this issue might be arising? I was hoping you might have some insight.
Thank you.

Fixed in https://github.com/mtth/azkaban/pull/34 - thanks again for the PR @Ralnoc!


Spork, build system and multiplatform updates

Minor fix to use the correct constant to switch algo with.
Add libcurl to depends folder for portability. Only set up curl environment once, calls to curl_global_cleanup were unreachable, move the call to shutdown. There's now one call to set up the environment for curl and one to destroy that environment. In some calls using curl move the "else" return statement to the end to get rid of compiler warnings.
Enforce masternode payment by spork.
Set grace period to 20,000 blocks, a spork is unnecessary for this.
Set version to <IP_ADDRESS> in configure.ac
Replace magic number with params variable.
Fixes for compiling on Mac. Calling of GetArg for token API URL in chainparamsbase triggers recursive_mutex assert, move calls to curl_read. Backport from Dash to fix depends Qt compilation error on MacOS.
Add missing bool for uptime in vRPCCommands.

Final updates for release <IP_ADDRESS>


Confusion about the audio representation in Figure 8

When using PE+ReLU to fit the audio, the network output layer passes through a sigmoid (code), which means the output values are always within (0, 1). However, the audio amplitude is within (-1, 1), which will result in the complete loss of audio signals in the (-1, 0) range. Did you have any additional settings in your experiments?

@lif314, Thank you so much for pointing that out. I included that code for image representation, but I originally did not use it for audio representation in my experiments. I'll fix it in the repo. Thanks!

@lif314, Thank you so much for pointing that out. I included that code for image representation, but I originally did not use it for audio representation in my experiments. I'll fix it in the repo. Thanks!

Looking forward to it! I am also interested in issue Frequency Analysis, could you also send a copy of the code to my email (cslinfeili@gmail.com)? Thank you very much!


Add opt-in Project.systemSetting to perform searches on readers when available

Previously, only GraphQL queries (except mutations) would be sent to readers. With this, searches can also be sent to readers if configured that way by a super-admin.

Just curious, why the change to opt-in for this?

Yeah I understand the desire to be able to control projects going to the readers for search maybe (in the case of saturating the connection pool with lots of FHIR searches and graphql requests) but feel like maybe it should be opt-out?
Not a strongly held opinion though

@mattwiller @ThatOneBro Regarding opt-in vs opt-out, the main concern is that replication-lag between writer and readers can be non-trivial (e.g. ~20 ms) even in the steady state and can spike higher for various reasons so we want to limit the blast radius of reading inconsistent data as much as possible for now.


Useful features.

Please refactor my code if nessesary. :dash: :smile:

Store Pokeballs. - OK

Choose pokeballs by availability in stock and CP value. - WIP
Farm pokestops if no pokeballs left  - WIP

Store Pokemons. - OK

Transfer duplicates except most CP. - OK

#######################################
Get pokemons > store them >
group them by ID >
sort CP in each group for each pokemon >
transfer all low CP pokemon duplicates. (commented for now, uncomment if want to test.)
#######################################

There should be exception ?

@PokemonGoF exception for what?


ARROW-10797: [C++] Vendor and use PCG random generator library

This exposes a small precision issue in the variance kernel tests in MinGW32 on 32-bit floats (because of rounding issues perhaps?):
https://github.com/pitrou/arrow/runs/2400347814?check_suite_focus=true#step:10:831
According to Numpy, the two float64 values differ by 5 ULPs:
>>> a
1011966660.249961
>>> b
1011966660.2499604
>>> np.testing.assert_array_max_ulp(a, b)
Traceback (most recent call last):
  File "<ipython-input-15-48fada135e2b>", line 1, in <module>
    np.testing.assert_array_max_ulp(a, b)
  File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.7/site-packages/numpy/testing/_private/utils.py", line 1643, in assert_array_max_ulp
    (maxulp, np.max(ret)))
AssertionError: Arrays are not almost equal up to 1 ULP (max difference is 5 ULP)

Should be the MinGW32 rounding issue we met with many times before.
Guess PCG generator produces different random numbers than std::default_random_engine. So this issue is always there, just not revealed by previous test data.
I think we can disable the random test for MinGW32. ASSERT_DOUBLE_EQ expects at most 4ULP diff, it's almost there.

Ok, I added a skip on MinGW32.

@github-actions crossbow submit -g nightly

CentOS error may be caused by gcc-4.8 build failure from earlier pr.


Getting Invariant Violation when using redux-react with Typescript/TSX

Now that Typescript supports JSX (with TSX), I'm excited to use React and Redux with it! However, I seem to be getting an issue when I try to wrap a React class with Provider. The code is as follows:
Invariant Violation: onlyChild must be passed a children with exactly one child.
The files I'm using are in This gist
As I dug into the redux-react code, the error is being generated from this stanza:
  Provider.prototype.render = function render() {
    var children = this.props.children;

    return _react.Children.only(children);
  };

And it turned out that this.props.children was a function which returned a React element rather than a React element itself? I don't know how this could be occurring. Any suggestions would be appreciated!

The code you're running is for Redux React 3.x.
The version you're using is 4.x.
4.x no longer allows function-as-a-child for <Provider> because the only reason we had it is for React 0.13 compat, and now we require React 0.14.
https://github.com/rackt/react-redux/releases/tag/v4.0.0
You need to change
React.render(
    <Provider store={store}>
        {() => <Main />}
    </Provider>, document.body);

to
ReactDOM.render(
    <Provider store={store}>
        <Main />
    </Provider>, document.body);

Thanks for the quick answer!

I'm facing the same issue. Can't solve it!!

@paramsingh88 can you paste your code? I was getting this same error message but that's because I put a comment between the  tags.
FROM
render( // React render   <Provider store={store}> {/* Provider function is a container component from redux */}     <Router history={browserHistory} routes={routes} />   </Provider>,    document.getElementById('app') // root element of react app );
TO
render( // React render   <Provider store={store}>     <Router history={browserHistory} routes={routes} />   </Provider>,    document.getElementById('app') // root element of react app );


PIC16. GPIO out

Make an example using a the peripheral GPIO as an output in a PIC16.

This project is completed and tested, it works as expected.


adds health check path

Issue #, if available:
Description of changes:
In order to be able to use a greater range of apps when demoing the sample load-balanced-fargate-svc template, it would be nice to be able to change the health check.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This has been tested.


Added cleanup for mtls.

/cc @geeknoid @diemtvu

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


ApiGateway not upating via codeBuild

Describe the bug
My client is trying to hit an old APIGateway endpoint after updating the stack via codebuild. I have calls being made to https://oakcalov4g.execute-api..... when the only live gateway is now https://bed2g6zyd1.execute-api....
To Reproduce
Deploy stack
Make some change to the codecommit repo
Kick off a codeBuild for the stack
Expected behavior
Updated stack should point to the correct endpoint.
Please complete the following information about the solution:

[v1.0.1] Version:
[us-east-1] Region:
[Y] Was the solution modified from the version published on this repository?
[N] If the answer to the previous question was yes, are the changes available on GitHub?
No changes have been made to any sort of deployment scripts. Just tinkering with the site & excel file generation.
[Y] Have you checked your service quotas for the sevices this solution uses?
[N] Were there any errors in the CloudWatch Logs?

I would assume that the APIGateway needs to be updated in waht seems like a .env file, but I have no idea where that file lives.
I also kicked a codebuild off manually, not via the codePipeline. I can't see why this would matter but I recognize that's different from the turnkey solution.

@spencerrichardhenry, thank you for reaching out. We are working on new features and updates and we will address this issue with upcoming releases.


Remove intermittently failing test

The quasi-static component test is intermittently failing on LC. As this is the legacy physics module, it is not worth investigating as it will be deprecated soon.
See https://github.com/LLNL/serac/issues/668

Sure you wouldn't rather just comment it out?

I honestly wasn't sure if ATS would bork at an empty ats file.

Ahhh yes. This might be the cause of our weird CI failures.


Errors with Tensor Flow 0.9

Hello, I'm unable to run this example with tensor flow 9.
Here is my bug reports on tensorflow issue tracker :
https://github.com/tensorflow/tensorflow/issues/3167
https://github.com/tensorflow/tensorflow/issues/3169

Any update for this?

I'm not writing for the fix. I'm wondering for you! Are you alive?

haha, I was out for vacation and work traveling =) Let me take a look - we just removed all the old TensorFlowXXX classes from tf.learn - so should rewamp all the examples.

Just updated everything in titanic.py - can you please check if it all works? (note was updating for latest version of TF 0.10)

Hi, Thank you for your response. It is nice to know you are alive :) I'm going to check and write here if anything is not working.
Thanks.


Javascripts are not correctly exercised in CI

The CI-environment doesn't exercise the javascript tests at the moment

Closed, we have removed the javascript API's.