support metaword '\n'

Hi @StephenArk30 and thanks for your interest in this project :)
The trick with meta-characters is usually that they match several characters, but your proposal will only match a single character. If you wanted to match a line-break, I think you would search for the character '\n'.
I have added two tests to the test-suite, to showcase how I would match line breaks.
E.g. the pattern "[a-z]+\nafter newline" will match the text

blahblahblah
after newline

Please help me understand the use-case for the new meta-character, i.e. answer the question "When is a meta-character for line-breaks usable?"

Hi @StephenArk30 and thanks for your interest in this project :)
The trick with meta-characters is usually that they match several characters, but your proposal will only match a single character. If you wanted to match a line-break, I think you would search for the character '\n'.
I have added two tests to the test-suite, to showcase how I would match line breaks.
E.g. the pattern "[a-z]+\nafter newline" will match the text

blahblahblah
after newline

Please help me understand the use-case for the new meta-character, i.e. answer the question "When is a meta-character for line-breaks usable?"

Thanks a lot for the instructions! I will dig into this case and back to this problem later.


Verbose log dump shows up every time I start VS Code

Product and Version [VS/VSCode]: 1.24.0
OS Version [macOS/Windows]: macOS 10.13.5
Live Share Extension Version: 0.3.292
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:

Open VS Code
See verbose log

Every time I start up VS Code, the Output window opens up and I get a log dump. I'm not sure why I'm seeing this all of a sudden.
[Client I] Trace log: /var/folders/8q/70wn2qfs43gb_87n1n991wfc0000gn/T/VSFeedbackVSRTCLogs/20180614_154752_15289912725650_VSCode.log
[Client I] Extension, IDE, OS : VSLS/0.3.292 VSCode/1.24.0 MacOS/17.6.0
[Client I] Did not find user settings at </<redacted>/<redacted>.json>
[Client I] Passed version check for MacOS: found 17.6.0
[Client I] No workspaceId found in workspace settings.
[Client I] No workspace url found in cascade.json file.
[Agent I] (1002) Trace log: /var/folders/8q/70wn2qfs43gb_87n1n991wfc0000gn/T/VSFeedbackVSRTCLogs/20180614_154753_Agent.log
[Agent I] vsls-agent v0.3.292.48773 (pid: 52466)
[Agent I] Reminder: You may only use this software with Visual Studio and Visual Studio Code, as described in the license (https://go.microsoft.com/fwlink/?linkid=872556).
[Agent I] Start time: 2018-06-14 15:47:53.486
[Agent I] Using VSLS service: https://insiders.liveshare.vsengsaas.visualstudio.com/
[Agent I] VSLSAgent/0.3.292.48773 VSLS/2.2 PlatformName/Darwin 17.6.0 PlatformVersion/<IP_ADDRESS>
[Agent I]
[Agent I] Proxy settings from env variable: http_proxy was null and https_proxy was null
[Agent I] (1001) Listening on pipe "faa0ae1a235846f39f5c7d719054c52d"
[Client.Rpc V] Agent connection not completed: Error: connect ENOENT /var/folders/8q/70wn2qfs43gb_87n1n991wfc0000gn/T/CoreFxPipe_faa0ae1a235846f39f5c7d719054c52d; Retrying...
[Client.Rpc I] Agent connection success - net.pipe://localhost/faa0ae1a235846f39f5c7d719054c52d
[Client.Rpc V] < version.exchangeVersions()
[Client.Rpc V] < telemetry.initialize()
[Agent I] Accepted incoming pipe connection.
[Agent I] RPC session #1 established.
[Agent V] > #1 [0] version.exchangeVersions(<0:>)
[Agent V] < #1 [0] Result: <84:8bcd6153>
[Telemetry V] > #1 [1] telemetry.initialize(<0:>)
[Telemetry V] < #1 [1] Result: <19:167142d9>
[Client.Rpc V] > version.exchangeVersions() succeeded
[Client I] Client version: 0.3.292 (VSLS/2.2), agent version: 0.3.292.48773 (VSLS/2.2)
[Client.Rpc V] > telemetry.initialize() succeeded
[Client.Rpc.Auth V] < auth.loginWithCachedToken()
[Agent.Rpc.Auth V] > #1 [2] auth.loginWithCachedToken(<0:>)
[Agent.Auth V] SecKeychainFindGenericPassword(<9:fdbd77f6>, <9:fdbd77f6>) => Success
[Agent.Auth V] SecKeychainFindGenericPassword(<9:fdbd77f6>, <6:913991a7>) => Success
[Agent.Auth V] SecKeychainFindGenericPassword(<6:913991a7>, <13:85e2486b>) => Success
[Agent.Auth I] Passed token validation: isValidExpirationTime=True (7/5/18 2:29:19 AM - 6/15/18 3:47:54 PM), isValidIssuedAtTime=True (6/11/18 2:29:19 AM - 24), isValidAudience=True (https://insiders.liveshare.vsengsaas.visualstudio.com/api/v0.2/ - https://insiders.liveshare.vsengsaas.visualstudio.com/)
[Agent.Auth V] SecKeychainFindGenericPassword(<8:5c643e2e>, <20:11784b02>) => Success
[Agent.Auth I] Profile cache hit (expires 6/18/18 4:21:10 PM)
[Agent.Auth V] SecKeychainFindGenericPassword(<6:913991a7>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainItemDelete(<6:913991a7>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainAddGenericPassword(<6:913991a7>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainFindGenericPassword(<9:fdbd77f6>, <6:913991a7>) => Success
[Agent.Auth V] SecKeychainItemDelete(<9:fdbd77f6>, <6:913991a7>) => Success
[Agent.Auth V] SecKeychainAddGenericPassword(<9:fdbd77f6>, <6:913991a7>) => Success
[Agent.Auth V] SecKeychainFindGenericPassword(<9:fdbd77f6>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainItemDelete(<9:fdbd77f6>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainAddGenericPassword(<9:fdbd77f6>, <13:85e2486b>) => Success
[Agent.Auth V] SecKeychainFindGenericPassword(<9:fdbd77f6>, <9:fdbd77f6>) => Success
[Agent.Auth V] SecKeychainItemDelete(<9:fdbd77f6>, <9:fdbd77f6>) => Success
[Agent.Auth V] SecKeychainAddGenericPassword(<9:fdbd77f6>, <9:fdbd77f6>) => Success
[Agent.Rpc.Auth V] < #1 [2] Result: <81:6fd515d5>
[Client.Rpc.Auth V] > auth.loginWithCachedToken() succeeded

@ffxsam Thanks for reporting this! We're tracking this issue via #545, and are working on the fix right now. In the meantime, I'll close this as a duplicate, and we'll report progress via #545. Thanks!


Tools & features to support benchmarking under realistic loads

To test and benchmark BigchainDB under realistic loads, we need some additional tools & features:

[ ] tools to generate realistic transactions, for various applications
[ ] tool to read files of test transactions from files
[ ] tool to deploy a large number of testing clients and have them send requests to a test cluster
[ ] ? a tool to bulk-upload realistic transactions directly into the backlog table of a test cluster?
[ ] Integration of the above tools with our existing benchmarking tools and features

Maybe this is too much to put in one issue.
@r-marques do you think it would be a good idea if i split it apart into a bunch of separate issues, maybe with a common GitHub Label, such as "testing" (doesn't exist yet)?

@ttmc I agree. That would also make it easier to then review the pull requests

Okay I will go ahead and do that now. Once the new issues exist, I will close this one.

great :+1:

Okay I created Issue #111, #112, #113, #114 to replace this issue. I'm closing this issue.


Implement new Changelog format

We have an existing changelog, but it's had only minimal updates:
https://github.com/openweave/openweave-core/blob/master/CHANGELOG
Since we don't have a formal release process with versioning and notes, we should reformat the changelog to be a bit more comprehensive, and use it for all substantial feature and dependency changes that should be highlighted for end users.
Taking inspiration from:
https://keepachangelog.com/en/1.0.0/
https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md
I can get it started with some of the recent updates made to the project.

Obsolete


How to maintain user state?

I am integrating my app to teams using Tabs feature. I am able to integrate authentication with my API. My challenge is how can I maintain state - for example - I am getting some configuration values from my API when the user is authenticated, and I want to display the content inside the tab based on these values. How or where I can store these kinds of state information? I tried with local storage in browser but it is not working in the Desktop app it seems. Is there a Microsoft recommendation available? or any API to store custom values?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b1dcd0d-471b-2d33-54b5-39a93dfba2a8
Version Independent ID: 5bd44149-777e-b449-bd2e-f20b9bd04038
Content: Authentication for tabs using Azure Active Directory - Teams
Content Source: msteams-platform/tabs/how-to/authentication/auth-tab-aad.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@anuraj - What values are you trying to send?

Something like my user's tenant info, their email address, their rank, profile pic information like this. Also, authentication token, which is required for all the requests once they logged in to our app.

@anuraj - All this information can be fetched from tab context. Check these docs

So if I understand correctly, as part of the response I need to set those values as query strings, and teams runtime will set it as part of context? So I can later read it from the context.

@anuraj , No, microsoftTeams.getContext(function(context) { /* ... */ }) uses Teams javascript client SDK which returns you users email, UPN, tenant id and much more information, while uploading the manifest within teams you need to set entity Id for your tab and the content url which you want to display within Teams tab That's it. you can get the context and save it for further use, however it doesn't return you the profile pic infomartion or token. You can get the photo using Graph API

@Trinetra-MSFT Let me explain my scenario, I am authenticating with my token endpoint. I am getting a token. This token is required for all other API calls.
As per my understanding, I need to store the token is some storage which is associated with the current user. Since the authentication is happening with Teams SDK, I won't be getting the users credentials. I tried with local storage API to store the token and all, it is working in the web app, but in the Desktop app it is not. So my question is - is there place available in teams where I can store the user state data?
I am using my API token endpoint. So I don't think I can use adal.js.
Do you have a sample available - in which a tab is showing content after authentication? I tried to create an ASP.NET Core MVC app with Cookie authentication, and load it inside tab - But that also is not working 😢

@anuraj , We have Bot builder SDK v4 samples for authentication. May be this will help you to solve the issue. Please take a look at TeamsAuth sample code.

@Trinetra-MSFT I saw the content for Bots. But what about tabs? I do see a lot of applications running in the tab. Why MS doesn't have a sample for tabs with authentication? 😕

@anuraj , Here is the sample for Authentication in Tabs. You can try this , let me know if this doesn't help you.

@Trinetra-MSFT Thanks. Let me explore and will try to implement it. Will get back if there are any questions.

Please feel free to reopen if you have further queries

Please guide me if you find any solution I'm stick on same problem where I store user-credential and access-token ?
Please reply im waiting


comment has white space in end of line

//test1;
//test2;

first line parse
//test1;
second line parse
//test2;
is this the expected behavior?

Hi @zoomer-k ,
I am not sure what the issue is here.
The output of $ tree-sitter parse <file.sv> gives the following parsed tree, which seems correct to me:
(source_file [0, 0] - [2, 0]
  (comment [0, 0] - [0, 8])
  (comment [1, 0] - [1, 8]))

Please first make sure it is not a tool related issue instead of a parser error running the tree-sitter parse command on the snippet.

Hi @gmlarumbe
thank you for researching
i try it in windows10
(source_file [0, 0] - [1, 8]
  (comment [0, 0] - [0, 9])
  (comment [1, 0] - [1, 8]))

Hi @zoomer-k ,
It seems it might be because of CRLF Windows format for newlines.
Can you try updating tree-sitter to the latest release and check the result of the parsed tree?
Thanks!

Hi @gmlarumbe
I'm trying but recently tree-sitter add tree-sitter.json file
https://github.com/tree-sitter/tree-sitter/issues/3637
could you update repository for latest tree-sitter?

Hi @zoomer-k ,
I updated generated files with tree-sitter 0.24 on 4344f7e, including the new tree-sitter.json file.
Hope it helps!


Add support for additional audio formats

Example from the Heavensward benchmark: cut/ffxiv/sound/benchm/benchm00007/SE_NC_benchm00007.scd

Finished as of c5f0bc40b521516d0aeff45686b448420975c6e3 for currently known sound files.


[website] Font weight consolidation

According to Edge's CSS Overview tool, we still have occurrences of IBM Plex Sans at 600 weight:

As we don't specify font-face at this weight, we should replace them with either 500 or 700.
As a side note, perhaps using fewer font sizes would make the site look more consistent.
cc @danilo-leal

Oh, shoot. I'm going to look for those extra 600 instances that got lost there. I think that using three (400, 500 and 700) weights is very ok, it's already very limited.

Found some of them, in 7 files to be more precise. Removed it on the refinement PR. The other instances aren't from the new website pages I guess!

Great, thanks!

Found some of them, in 7 files to be more precise. Removed it on the refinement PR.

@danilo-leal Is this PR already open? If so and the PR fixes the issue, then please link this issue from the PR so that GitHub automatically closes the issue, once we merge the PR.

@danilo-leal Is this PR already open? If so and the PR fixes the issue, then please link this issue from the PR so that GitHub automatically closes the issue, once we merge the PR.

I pushed the changes on the #28081 PR, sorry for not mentioning before!

I'm closing this issue, then.


is it possible to calculate Body degree angle using pose estimation

Click to expand!
Issue Type
Feature Request
Source
source
Tensorflow Version
pod 'TensorFlowLiteSwift', '~> 0.0.1-nightly', :subspecs => ['CoreML', 'Metal']
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
How to calculate degree of angles using body keyPoints? & Pose angle. ie. 45 degree, 90 degree.

Standalone code to reproduce the issue
I want to detect human body pose angle is it possible?

Relevant log output
No response

As of now, I don't think there is any direct way to calculate angle using tflite.
However, you can find the angle using your custom functions, you can refer this code example which was implemented using MediaPipe.
Let us know if this helps you. Thanks!


mamaIO_* functions?

HI Frank:
I notice that you provide what looks like a complete implementation of the mamaIO_* functions in the zmq bridge, although it's not at all clear to me what those functions do, or what one would use them for.
I also notice that those functions appear to be completely unused.
Are these vestigial appendages that exist merely to allow the bridge to pass the Mama unit tests?  Or do they serve some purpose that I'm not seeing?
Thanks!
Bill

Hi Bill,
Yes this was always a bit of a grey area for me. It's effectively a pass-through public API (https://openmama.github.io/reference/mama/c/io_8h.html) so we can't really touch it in OpenMAMA 6 but i'm keen to take it out in OpenMAMA 7 since there are many libraries out there that will do a better job than OpenMAMA at solving that problem.
The only example app that actually uses it (ignoring the unit tests for now) is https://github.com/OpenMAMA/OpenMAMA/blob/master/mamda/c_cpp/src/examples/orderbooks/bookviewer.cpp which unfortunately depends on IO behaving in a quite specific way so it's not even a properly generic API for I/O (it depends on getting a callback on IO change rather than allowing wait for flush on newline for keypresses).
But yes because that example application uses it, I wrote an implementation for it in zmq and qpid (which eventually i'm hoping to collapse, see: https://github.com/OpenMAMA/OpenMAMA/issues/322), and I didn't remove the existing unit tests (as much as I wanted to).
Within internal MAMA though (unlike timers and queues), it's literally not mandated anywhere.
Cheers,
Frank

Thanks Frank.
So, it's still not clear to me, but from your comments it sounds like the mamaIo* functions are intended for console (screen/keyboard) I/O?
If that's the case I would tend to agree that they really don't belong in OpenMAMA ;-)


Add --read-data-subset flag to check command

What is the purpose of this change? What does it change?
This change introduces ability to check integrity of a subset of repository
data packs. This can be used to spread integrity check of larger repositories
over period of time.
Was the change discussed in an issue or in the forum before?
See #1497
Checklist

[x] I have read the Contribution Guidelines
[ ] I have added tests for all changes in this PR
[x] I have added documentation for the changes (in the manual)
[x] There's a new file in a subdir of changelog/x.y.z that describe the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Thank you for the feedback, I think I made all the requested changes but let me know if I missed anything.
PS: You have nothing to apologize for. I fully understand it takes time and effort to do review and provide feedback about external contributions. And from my experience restic is one of the better projects when it comes to reviewing and accepting external contributions.

Cool, thanks!


Harine hacktoberfest2022

Added Tooltip for info icon. Made some CSS changes for the header.

add screenshot and resolve conflicts


EI-776 command line tool to populate EUPS spreadsheet from query results

Closed as functionality is not required


Table 39 "Purchase Line" - procedure CalcVATAmountLines(...)

Hi,
The three calls to event
OnCalcVATAmountLinesOnBeforeVATAmountLineSumLine(Rec, VATAmountLine, QtyType);
Must use as the first parameter the variable PurchLine received in the procedure:
CalcVATAmountLines(QtyType: Option General,Invoicing,Shipping; var PurchHeader: Record "Purchase Header"; var PurchLine: Record "Purchase Line"; var VATAmountLine: Record "VAT Amount Line")
when I use this event to calculate the statistics adding some modifications, I receive the Rec un-initialized and cannot do anything, but using the var PurchLine would be OK.
could you please substitute the call by this one:
OnCalcVATAmountLinesOnBeforeVATAmountLineSumLine(PurchLine, VATAmountLine, QtyType);
in the three calls to the event.
Thanks in advance.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Use consistent naming for page component

Q
A

Fixed Issues?
Fixes #53

Patch: Bug Fix?
Yes

Minor: New Feature?
No

Major: Breaking Change?
No

Tests Added + Pass?
No

Documentation Provided
No

Any Dependency Changes?
No

License
Apache License, Version 2.0

Renames MainContentComponent to PageComponent in the Angular app to get consistent naming with the React app.

I am not an expert in the area but isn't the MainContentComponent being exported like an API ?
Are we breaking the API ? Wouldn't this be Backwards In-compatible ?

I re-thought about this and I guess, the archetype is to be used only once while starting the project. So, probably, we won't need to bother about name/API change.
Better to confirm with others as well

I agree that this should be a one-time operation. The archetype:generate command can be used for an existing project, but I assume that would just overwrite the existing (and possibly modified) files? So taking over desired changes manually seems like a better option.
Furthermore, the archetype currently isn't set up to allow this anyway.


Open image in a new tab

Open the image (that appears on image route with id) in a new tab for hd version.

Hey @parthpanchal123 I would like to work on this for Hacktoberfest 2021. Is is okay for you?


fix termio.lflag wrong name

This fixes the name of termio.lflag in the documentation. It was lflags before.

Nice catch, thanks.  Merged!


[FIX] Arbitrary file read using secure arguments for PhantomJS

Bounty URL: https://www.huntr.dev/bounties/1-npm-node-html-pdf/
⚙ Description *
The node-html-pdf module is vulnerable against arbitrary file read due to a unsafe usage of phantomjs, which makes possible reading local files when parsing html files to convert in pdf ones.
💻 Technical Description *
As suggested on https://github.com/marcbachmann/node-html-pdf/issues/530#issuecomment-536546934, I added as default argument the --local-url-access=false options, which makes impossible reading local files :smile:
The user is still able to provide access to the local files setting the readLocalFile option to true :smile:
🐛 Proof of Concept (PoC) *

Download the repo
Go on the directory node-html-pdf
Create the poc.js file:

var fs = require('fs');
var pdf = require('./');
var html = fs.readFileSync('./test/example.html', 'utf8');
var options = { format: 'Letter' , phantomArgs: ["--web-security=no"]};

pdf.create(html, options).toFile('./example.pdf', function(err, res) {
  if (err) return console.log(err);
  console.log(res); // { filename: '/app/businesscard.pdf' }
});

node poc.js
A example.pdf file with the content of /etc/passwd is created

🔥 Proof of Fix (PoF) *
Same steps with fixed version doesn't create a file with the content of the /etc/passwd file
If the user explicity uses readLocalFile inside the options, then the internal files are fetched again (only who writes the code can change it, so no possible bypasses are allowed for other users :smile:)
👍 User Acceptance Testing (UAT)
Run a unit test or a legitimate use case to prove that your fix does not introduce breaking changes.

Congratulations Mik317 - your fix has been selected! 🎉
Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section. Your bounty is on its way - keep hunting!


Use non-whitespace contents in a button padding test

libtxt has different policies than Blink for trimming whitespace.  This change
will make the test results consistent in both text renderers.

@chinmaygarde

FWIW, I would have expected the space not to be trimmed. We expect our users to trim spaces if they don't want them taken into account.

minikin::LineBreaker does not include trailing whitespace in its calculations of line widths, which affects what libtxt returns for maxIntrinsicWidth
What assumptions does the framework make about whitespace and text widths?

I don't think the framework itself is affected by this.
But as a general rule, we need to be able to measure the widths of spaces, which means we can't trim the spaces before measuring the width of the string.


Whitelist Apache-2.0 WITH LLVM-exception

The "LLVM Exception" is a new Apache-2.0 relative registered with SPDX. It modifies Apache-2.0 by adding an exception for GPLv2 compatibility, and an exception for compiler output.
It is the license the LLVM project is planning to transition to, and it's an attractive option for other compiler-related projects as well, because of the strengths of the base Apache-2.0 license, the flexibility granted by the exception clauses, the extensive scrutiny it has received by numerous parties involved in the LLVM license change process, and the fact that LLVM itself is expected to use it.
As such, it's desirable for crates.io to accept it as a valid license option.

[This is in-flight][1] with #19, although I won't be able to push a new release until #12 is resolved.

Ok, great. I'll close this issue then, and follow #19.


Adding public key validation documentation for ecvrf

Added docs to the verify() function for clarifying that public key validation occurs either when deriving from a VRFPrivateKey, or in the TryFrom for VRFPublicKey.

Codecov Report
Patch coverage has no change and project coverage change: -0.04% :warning:

Comparison is base (5c2bc73) 87.77% compared to head (aa0a856) 87.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   87.77%   87.74%   -0.04%
==========================================
  Files          39       39
  Lines        8771     8771
==========================================
- Hits         7699     7696       -3
- Misses       1072     1075       +3

Files Changed
Coverage Δ

akd_core/src/ecvrf/ecvrf_impl.rs
91.92% <ø> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support for language only resx files

Here is the current AppResources structure in my app:

I only use the language code in the file name in some cases. I have them set up like this to prevent duplicate strings that would need to be checked by a stakeholder. For example, I may have a user in The Netherlands or in Belgium that speaks Dutch. Mostly all the text is the same for these two users, except if the user is in Belgium, then there are a few strings that need modified. According to the documentation, the app chooses the right file for the resource key in order of specificity.

https://docs.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/localization/text?pivots=macos#test-localization
There is a requirement for this extension that the files have both the language and the region in the AppResources file name, which my files obviously don't meet. Would you consider changing the requirement to have just the language specified, instead of the whole culture?

Hi I will add it to my backlog.
//joacim

Hi There is a new version 1.0.27 that should suport your request. In your sample above when you right click the master file and select sync or translate it will only effect the .fr.resx and .nl.resx file.
Please try it out and comment her if it's ok or if something missing.
//Regards Joacim

Hi I tried this out and it worked as you said. It only synced and translated the the fr.resx and nl.resx. Thanks!


Intellij 2020.1.1 version is not supported

Hi,
I got the following error in Intellij 2020.1.1:
Plugin Error: Plugin "TFS" is incompatible (until build 193.SNAPSHOT < IU-201.7223.91).

The plugin has reached end-of-support in 2020.1. See https://blog.jetbrains.com/idea/2020/01/end-of-support-for-tfs-2014-and-older/

Thanks @dmitriysmirnovjb
built the plugin from the source, let me upload it if someone is needed:
idea-tfs-201.zip
(Load the jar using Settings/Preferences - Plugins)
regards,


fixtype coercion: in-pred handle null literal bug

Proposed changes
fix two bug about nullLiteral

fix type coercion bug
1 in (2, null)
in type coercion rewrite, nereids cast null to tiny int. This is wrong.

NullLiteral should be passed as a function parameter of any data type.
for example, sum(x) expects integerType as input parameter. But it also accept NullLiteral.
We do not need to cast nullLiteral to Integer and then pass it to sum()

Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.75 seconds
load time: 644 seconds
storage size:<PHONE_NUMBER>5 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230104063948_clickbench_pr_73243.html

fix by #15880


Popover overflows bottom

I open an issue to track it better, I hope that's ok.
Reference:

#447
https://github.com/thednp/bootstrap.native/commit/6f8188139094379d853dc6145714f03d3e1c9bc7

Latest changes for v5.0.0-alpha2, has no effect in my tests. The popover is still positioned not correctly.

I have an idea on how to improve this, will let you know asap, perhaps tomorrow.

@jcorporation I've played with the code a bit, I made it work to take this case into account and well... it's not right, mostly because the new positioning system based on position fixed for the tooltip and a much more simple algorithm makes Popovers always stick to the viewport edges, even if their trigger elements are not in the viewport at all. In short, it solves one niche case and produces an even bigger problem for everything else.
In my mind a solution can be for us to implement the inserted.bs.popover event (it shouldn't be hard at all) and you can use a custom CSS class to position your Popover however you want when this event triggers. What do you think?
Happy New Year!!

This additional events should solve my problem. Could you add this events also to the dropdown component?
As reference my current patch to solve this: https://github.com/jcorporation/bootstrap.native/commit/73aa96402667ceb8e75fcc4166bf763d28d361a9#diff-73e8e7ae57dcf21616bd61f7eac8e8190db171f06e1f908cd7ae724b95b9c379

Let me finish updating the tests and I'll see what I can do. Meanwhile let me know what you think regarding:

where you think the inserted event should trigger? I think an updated event would work better since it triggers on both inserted and updated, in fact it might be just to add to our update prototype method update () => { styleTip(this); /* trigger updated here */ }
same question for Dropdown, similar context, however the dropdown menu is always in the DOM, so on updated would again work better.

What do you think?

We can use only an updated event. It should trigger after the position styles are applied and before the dom becomes visible.

@jcorporation I've implemented the feature, however I'm having problems with the Cypress testing suite. The same old fix one crap 2 more pop.

@thednp : notify me, as soon it can be tested

@jcorporation the implementation is live, since this morning. I still have some testing scripting to fix.

Works as intended. Many thanks for this enhancement!


Is change user functionality working on the development site?

@valearna
I was testing the Change user functionality on the development site and wasn't able to change the user even though I had selected a new user name from the autocomplete.
Is this functionality enabled on the development site?
Thx.

Ah....I see now that I need to double-click on the selected name in the autocomplete.
Maybe we should add a submit or change button to the pop-up window to make this clearer?

Good point @vanaukenk, I'll add a button to enable single click on the name and 'submit' with the button.

Thanks @valearna !

ready to test on dev @vanaukenk


Allow arguments to be used for tfsec

I would like to be able to set arguments for tfsec as in https://github.com/aquasecurity/tfsec-sarif-action

Hi there! Any idea when this could be merged? Thanks!

Thanks @YOwatari  - looks great


Cost/licence dashboard

Hi,
We were wondering if it's possible for someone on the Aerospike side to take a look at adding a "cost dashboard" that would make it easier for us to track our usage vs our contract.
At the very least it would be nice to easily track # of clusters and storage (measured in the same way as the contract, not just disk used), along with total's across all running clusters!
We were about to build it, but we're not sure the right metrics exist and it would be better if this was done once and available to all customers!

Hi @apenney-beeswax We have a tool to do this in progress. (cc @rbotzer )


FREQ: Add folding support for nested code and Aliasmask's RPEdit format?

Your "Planned Features" list includes an impressive set of functionality — I'm looking forward to it!
Something to add (?) to your list would be folding support so that nested code can be collapsed/expanded but also support for doing the same with Aliasmask's RPEdit format (which includes the ability to delineate multiple macros in a single source file, which makes it much easier to edit related UDFs as a single unit).
Thanks for sharing!

To my delight, VSCode supports folding for matching brackets, so [code: { ... }] sections and the like should be fold-able already. I think that's out of the box, but maybe it's from a setting or other extension I have somewhere?
I'll have to look into that RPEdit format. Adding folding to that should be doable, but may have to wait till I get more semantic features under my belt.
I haven't set up proper issue labels and templates in this repo yet, so I'll update this when I get around to that.

So looks like folding is auto-calculated by default by looking at indentation, which I always follow, so that's why it is working for me. In language-configuration.json one can add a single pair of begin/end Regexes for additional folding, for anything more complicated one needs to implement a FoldingRangeProvider which will likely require more semantic support.
I added FoldingRangeProvider to the roadmap.
RPEdit folding is implemented using regexes and will be supported next version.


CORS middleware issue when origin host starts with a digit

We have noticed an issue with the CORS middleware (default CORS.policy implementation) whereby it doesn't recognise a request as a CORS request if the host in the Origin header starts with a digit. For example, a CORS request with header Origin: https://www.example.com will work correctly, but a CORS request with header Origin: https://2ww.example.com will not.
This is an issue in the 0.23.6 release but it looks like it has already been fixed in the series/0.23 branch (presumably via one of the merges into that branch that have occurred since 0.23.6 was cut). I think the issue is caused by a missing .backtrack in the Rfc3986.ipv4Address parser meaning that in the case where the host starts with a digit, we never actually run the subsequent parser which should match the RegName host. Compare in v0.23.6 vs in series/0.23.
If the above is correct, would it be possible to get a release cut from the current series/0.23 branch so that we can just upgrade to fix the issue? 🙏

I'll look into a release train this afternoon.

That would be amazing, thank you 🙌

I'm going to bed before it finishes, but if all goes well, 0.23.7 will be on Maven Central in ~90 minutes.

Looks like the release of 0.23.7 failed due to #5691 - sorry to be a pain, but would it be possible to get a release cut if/when that's fixed in series/0.23 please?

The website publishing failed because of that, but I see 0.23.7 jars on Maven Central.  The Sonatype publish happens before the website publish in that job.  Let me know if you're still unable to resolve them.

Ah yep I can get it now. Apologies, for some reason I couldn't see it when I checked yesterday morning.


verify 120fps on pro-motion displays

egui.rs, as an example, measures it's own frame rate and reports 120fps on my macbook

an easy way would probably be to drop into continuous mode and measure the framerate
https://developer.apple.com/documentation/metalkit/mtkview/1536027-preferredframespersecond

metalkit & egui will happily do 120fps in continuous mode with preferredframespersecond set to 120. We're going for a more energy efficient reactive drawing strategy, however


Undesired changes when performing diff on a simple model change

What are you trying to achieve?
We author our model in Power BI Desktop, and use tabular editor v16.0 to serialize model changes, which we then perform diffs on. Most of the time this works well, but we occasionally get undesired diffs, like the one below:

This seems to be auto generated. We are wondering what we are doing to create these undesired changes (we have 700+). Is it a setting? Can it be avoided?
I got these changes when adding a calculation group. I had already prepared the DAX in a previous model, so I simply opened TE > new calculation group > copy and paste > save.

These annotations are not created by Tabular Editor.  We are working on an import model, with partitions in Power Query. Our prior change was hiding columns (including the one in the screenshot). Perhaps this was generated by Power BI when we hit the column?

@otykier Your responsiveness is nothing short of legendary. We are working on an import model, with partitions in Power Query. Our prior change was hiding columns (including the one in the screenshot). Perhaps this was generated by Power BI when we hit the column?

Could be. As you may know, modifying column properties through external tools is not supported, so I guess this is one example of the consequences of performing unsupported modeling operations. I’ll ask around to see if I can learn more on what these annotations do.

@otykier Yes, we were aware of that limitation. We did modify the column properties directly in Power BI. I have tried my best to Google any clues. If you find anything that would be greatly appreciated. Thank you!


Abillity to send slack message only on status change

For example I'd like to have nightlies, and expect them to suceed 99% of the time, no need to spam my channel each night. But I'd like to be notified when the build fails. So I would love to have this step send message only on build status being different then the last one.

Great idea! Unfortunately this can't be done right now, as there's no Environment Variable or API to get the previous build's status - but this can be fixed ;)
Could you please create a UserVoice feature request to have this information as EnvVar? Probably it should include more than one EnvVars, to be able to get the previous build's status on the same branch, or just the absolute last build's status (which might be on another branch).
IMO this can be related to this request: https://bitrise.uservoice.com/forums/235233-general/suggestions/6901955-add-previous-commit-message-support-to-git - if you want to you can upvote that one and add a comment about the status env. It would work similar to what it's described in this request, just not for commit hashes but for build statuses.

I voted and linked back to this issue from the UserVoice you posted

Thanks, I changed the title of the request to better reflect the fact that it shouldn't be just git info ;)

+1
We have a few people on the team. We are interested in getting Slack message in our team's channel whenever build fails and then when it becomes green again. There is no value for us in having repetitive messages that the build has passed every time someone pushes.
Thanks in advance!

+1, this would be great.

Feel free to create a feature request at: https://discuss.bitrise.io/c/feature-requests , for better visibility ;)

Btw, if all you want to do is "But I'd like to be notified when the build fails." it's already possible, see: http://devcenter.bitrise.io/tips-and-tricks/disable-a-step-by-condition/#run-a-step-only-if-the-build-failed

+1 please consider adding this!

@gheine isn't https://github.com/bitrise-io/steps-slack-message/issues/2#issuecomment-272622607 enough?

https://discuss.bitrise.io/t/check-if-last-build-failed-status-changed-e-g-only-slack-notify-if-build-failed-or-fixed/1781
This is open for more than a year. Is it any closer to being supported?

@rajit not yet, not enough attention - thanks for creating the feature request on discuss, if it gets enough votes there we'll definitely bump the priority!

+1 here too!

Closing this thread here as there's a feature request for it - please vote & comment for it at: https://discuss.bitrise.io/t/check-if-last-build-failed-status-changed-e-g-only-slack-notify-if-build-failed-or-fixed/1781
Thank you! :)


Add Colorful

A curated list of awesome resources to choose your next color scheme.

Ping me here in a few weeks and I'll reopen ;)

Since then, it hasn't changed much, but as per your advice I've re-opened it :)

Some feedback:

Use ## type headings for Table of Contents, Tools and Articles.
The Tools section should be split up. Web based tools, libraries, etc.
Are there any communities like Slack channels, gitter rooms, forums, IRC channels, etc, where people can discuss colors? If yes, link to it.
Totally optional, but would be cool to have an illustration at the top. Here's a good example: https://github.com/websemantics/awesome-synthetic-biology You could have some color scheme illustration or something.

@sindresorhus thanks for all the suggestions. It does look better now.

[x] I have read and understood the contribution guidelines and the instructions for creating a list.
[x] This pull request has a descriptive title.
The list I added

[x] is not a duplicate,
[x] has been around for a few weeks,
[x] only has awesome items with descriptions,
[x] contains the awesome badge on the right side of the list heading,
[x] has an appropriate license,
[x] has contribution guidelines,
[x] has been checked for inconsistent formatting, spelling and grammar, and
[x] has been added at the bottom of the appropriate category.

I think an illustration would work better than just a random (in this case, boring) stock photo. Also drop the <br> between sections.


Repaired this plugin bad links (we changed our company name on github)

@jdsantos please resolve merge conflict

@jdsantos

We added the plugin in the refactoring where we moved the plugins into seperate files #7805


chore: bump devDependencies to run on node 16 & npm 8

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

@dr-itz sorry, this was in draft mode. This is only a quick fix for the ci pipeline. I am not sure if we use the GitHub actions right, but the versions changed on the fly. So this is a quick fix.
E.g. should should discuss for a larger project dev update here. Still tslint and other archived libs are used. So we should switch to eslint, ng13, ivy

@dr-itz I reset the "typescript": "^4.3.5" so that we have minimal change that builds on the ci. We should do a project update within another MR then.


New implementation of style and style_sheet macro for more performance.

Doing the optimaztions discussed in this issue

These changes will be released as a new major version as we discussed in this issue.

@MrNossiom while resolving merge conflicts, I couldn't directly merge all the changes. I have manually added some of your changes. If you like to do, please check the code on this branch and try adding missing changes.


Login issue with Skoda CityGo

This is what the debug log shows for current master:
DEBUG:skodaconnect.connection:Failed to verify connect token, error: module 'jwt.algorithms' has no attribute 'RSAAlgorithm'
DEBUG:skodaconnect.connection:The Connect services token is invalid
ERROR:skodaconnect.connection:Failed to fetch VW-Group API tokens, Invalid connect token

Looks like you have the wrong version of pyjwt. Make sure you are using pyjwt==1.7.1 as stated in requirements.

Same thing after doing:
❯ pip3 install pyjwt==1.7.1
Collecting pyjwt==1.7.1
  Using cached PyJWT-1.7.1-py2.py3-none-any.whl (18 kB)
Installing collected packages: pyjwt
  Attempting uninstall: pyjwt
    Found existing installation: PyJWT 2.1.0
    Uninstalling PyJWT-2.1.0:
      Successfully uninstalled PyJWT-2.1.0
Successfully installed pyjwt-1.7.1
WARNING: You are using pip version 21.1.3; however, version 21.2.4 is available.
You should consider upgrading via the<EMAIL_ADDRESS>-m pip install --upgrade pip' command.

You might need to install the cryptography module as well. I will add it as a dependency

Check. pywt[crypto] does the trick.


[FIX] Travis-CI Java 8 building environments

What is the purpose of the change
Fix Travis-CI Java 8 building environments.

Figure: bugs in .travis.yml

Brief changelog
...
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.02%) to 50.647% when pulling b567f3533475bda3f4bae74c1f4df4844737e3f3 on zihengCat:ziheng_dev into 40c255d6b55b03fbff8cd7c1d78af6f5edcab5fa on apache:master.

@duhenglucky

https://github.com/travis-ci/travis-ci/issues/10428

Could you please move this PR to the develop branch?

Fine! @ShannonDing

@zihengCat good job！Could you please split this PR  into two separate ones? One is about the document, the other aims to modify the CI and the copyright time.

@duhenglucky @ShannonDing
The error occurred because Travis-CI using an OpenJDK 11.0.2 building environment, jdk_switcher is no longer exists in this building environment. Specify an Oracle JDK 8 building environment could fix that.
I only fixed Travis-CI Java 8 building environments in .travis.yml at b567f35, other changes like modify documents or update README.md were completed by Alibaba Group staff.
It's better to merge this pull request to master branch. After that, merge branchmaster into develop to get latest changes.

@duhenglucky @ShannonDing
The error occurred because Travis-CI using an OpenJDK 11.0.2 building environment, jdk_switcher is no longer exists in this building environment. Specify an Oracle JDK 8 building environment could fix that.
I only fixed Travis-CI Java 8 building environments in .travis.yml at b567f35, other changes like modify documents or update README.md were completed by Alibaba Group staff.
It's better to merge this pull request to master branch. After that, merge branchmaster into develop to get the latest changes.

Thanks for your good job. To keeping the master clear and as same code as the release version, as usual, it 's forbidden to merge PR into master directly. all PRs will be merged into develop branch, then merge into master after tests. Could you please move this PR to the develop branch?

This pr have many commit logs that pushed by other contributors. Could you please rebase it first?  maybe a new pr will be much more better.


Invalid flow specified

I'm trying to get this integration to work, but everytime I (re)install this integration it is throwing me errors.
The API is created as documented (with the 'authentication API' and the 'Gardena Smart System API' and I've updated to the last version of this integration.
I've copied the 'Application Key' and 'Application secret' and then loading animation is shown. After 30 seconds (or so) an error is given 'Unknown error occurred', when I send the credentials again in the open window it is throwing me the error 'Invalid flow specified'.
What am I doing wrong here?

I just updated everything.
There is a new release 1.1.1-rc2, can you give it a try please ?
Thanks,
grm

git checkout 1.1.1-rc3
and voila ;-)
TNX

Awesome!
Works perfectly now. Thank you!

I'm trying to get this integration to work, but everytime I (re)install this integration it is throwing me errors. The API is created as documented (with the 'authentication API' and the 'Gardena Smart System API' and I've updated to the last version of this integration. I've copied the 'Application Key' and 'Application secret' and then loading animation is shown. After 30 seconds (or so) an error is given 'Unknown error occurred', when I send the credentials again in the open window it is throwing me the error 'Invalid flow specified'.
What am I doing wrong here?

Same problem here, i tried with Version 1.1.0 and 1.1.1 RC2, 1.1.1 RC3. Everytime the same. I did the resgistration at Husqvarna Developement Portal and added both APIs (Authentication and Gardena smart system). I entered the key and secret, then it loads and loads and loads till an undefined error occured. when I try again i get "invalif flow specified".
I also did several ha reboots and system reboots.

same here too.


Design LED holder

The LED's need some form of holder for placement in the car grille. Possibly including diffusion as well?

Maybe a transparent hose can be used to house the LEDs and the wires, or perhaps multiple hoses to separate LEDs and wires?


Peer Feedback - Link to readthedocs

From slbsolomon's review:
The link to readthedocs in the README under Documentation wasn't working, but I was able to get to the page via the badge

Hmm...the link seems to work for me. Can anyone else replicate this issue? @lisebraaten @tguo9 @YueJiangMDSV

The link works for me. I can open the docs.

The link also works for me... I think we can close this issue?

Sounds good. Thanks for checking!


Some Prior Art That May Be Of Interest

Cool project -- wanted to point you to some tools you may or may not be aware of.
NVLabs/CGBN
CUDA Accelerated Multiple Precision Arithmetic (Big Num) using Cooperative Groups
https://github.com/NVlabs/CGBN
data61/cuda-fixnum
Extended-precision modular arithmetic library that targets CUDA.
https://github.com/data61/cuda-fixnum
matter-labs/bella_cuda
Implementation of various primitives for bellman using CUDA (WIP)
https://github.com/matter-labs/belle_cuda
In addition, check out the challenge for GPU acceleration of zksnarks.
https://codaprotocol.com/blog/snark-challenge.html

Thank you very much! I'll take a look, looks very promising


backend: editing personal information. Update of database

User story

As a {HR-employee}
I want / need {the information in the backend to be adjusted accordingly if I edit a digital identity via the frontend}
So that {all information in the system is valid}

Acceptance criteria

backend offers the frontend the functionality of changing personal information
personal information is changed accordingly in the database

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

@jackDS008
I hope the acceptance criteria are ok like that. Otherwise, just comment on it ;)


Fix/faster analyse

@pbrunet : travis likes me! merge me!

Changes Unknown when pulling 90a7bd9c17cb2e4ea2b33e218bf9721d6fb5dfae on fix/faster-analyse into ** on master**.

Changes Unknown when pulling 90a7bd9c17cb2e4ea2b33e218bf9721d6fb5dfae on fix/faster-analyse into ** on master**.


Nested sampling integration

Very happy to hear about the funding from Alan Turing Institute!
I was wondering if there is still interest for working on the NestedSamplers integration, as this is possibly a very powerful sampling backend (for example popular in the astronomy community). Previous attempts seem to have stranded.
Very willing to help out by testing and contributing to the nested sampling code itself, but the integration into Turing is well over my head.

Integrating Turing is now way easier than it used to be. There are few examples that should be straightforward to follow. See this repo, which is intended as a tutorial. Also this one, which is a more realistic example.

OK, I'll take a look in some time. Thanks


Change data preparation from class to function

A bit nicer interface for calling the preparation. Instead of:
preparer = TIMIT_Preparer(...)
preparer()

Just do:
prepare_timit(...)

[x] timit
[x] librispeech

The above two issues still exist in the latest master.


typo phopshate

FYPO:0008123
Ontology | fission_yeast_phenotype
Term name | loss of viability in stationary phase upon phopshate starvation

fixed. The ID for this term does not show up in Protege?

Still the ID does not show. I don't know why, this should be automated.
I do locate the term with an ID (FYPO:0008123) search though...

Three could be lots, I only spotted this by chance...
But I don't understand how all of the checks pass
@manulera  @kimrutherford   do you know how to troubleshoot this?

Shouldn't this happen automatically?
There was another change (fairly recently).
Now the obo name space (fission yeast phenotype)  is not automatically  populated , but it used to be ( I am not quite sure when this happened).
I don't know who to ask about issues like this because I don't really know  who  or where which bits happen. Do you think  these would be suitable questions to ask on obo community, or phenotype  ontology Slack channels?

I would say ask in OBO, I am sure @matentzn or @gouttegd know something about this.
It probably has to do with Protege config, or with the OBO annotation plugin.

It looks like FYPO transitioned from the OBO Flat File format (fypo-edit.obo) to the OWL Functional Syntax format (fypo-edit.owl) for its main editing format a few years ago (#4192).
When using OWL Functional Syntax as the edit format, it is normal that the id and the OBO namespace (oboInOwl:id and oboInOwl:has_obo_namespace annotations, respectively) do not appear in Protégé; they only appear when working from an OBO Flat File format.
The terms where those annotations are present in the current version of ontology are most likely terms that were created before the migration to OWL Functional Syntax.

Wow, thanks, @gouttegd - I am embarrassed that I only just spotted that! I had assumed that did not get added until the release pipeline until now.
Do you know how we can configure so that
obo name space "fission_yeast_phenotype" appears automagically? I am sure that it used to. It would be one less typo to make.

Hi @gouttegd thanks for rescuing the original place where this happened!
If I am not mistaken, the reason for this was that using .obo the diffs were always polluted with an incredibly long line that contained the logical definitions. When we transitioned to owl, we could see meaningful diffs that included the logical definitions, and when I had to add a lot of phenotype terms (e.g. for papers with screens) I was able to use scripts that added the logical definition in owl syntax.
Are logical definitions still stored in OBO like that? And is there a way to include those missing annotations easily via protege settings?

Now the obo name space (fission yeast phenotype) is not automatically populated , but it used to be ( I am not quite sure when this happened).

Hi Val.  I'm confused by this.  The OBO files in the release have this at the top:
default-namespace: fission_yeast_phenotype

That seems OK?

Its about the namespace that is needed on every new term:
has_obo_namespace fission_yeast_phenotype
It used to be there automatically, and now I need to add it manually.


Install the App clarification

Does the current text also applies to application being developed (i.e. when in developer mode). Launching and implicitly deploying from Visual Studio (e.g. F5) won't work?
It does not seem to be so with the CustomCapability SDK sample.
Could you please clarify?
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d835c91-424a-a096-ea00-f1dd7c0bc0c4
Version Independent ID: 1e73f683-6a1e-6794-8831-b6e6b170fa88
Content: Hardware Support App (HSA) Steps for App Developers - Windows drivers
Content Source: windows-driver-docs-pr/devapps/hardware-support-app--hsa--steps-for-app-developers.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Closing out due to inactivity - please reopen as needed

Closing out due to inactivity - please reopen as needed


feat: add interactive config on first start

Hi,
I've seen your request for contribution in rust discord.
I wanted to try it out and see how I can contribute.
And immediately, on first start, it just bailed out and told me to update the config file. That is fine, however i feel like an interactive configuration would be nice.
Here is a proposal to add interactive wizard in case config file does not exist yet.
It only asks for the twitch config atm but it other options can be added.
it also asks if you wish to do the interactive wizard and if not, it reverts to original way of creating default config and bailing out.

Thank you very much for this contribution! I've been meaning to do a start screen like #121 for a while, but haven't gotten around to it yet.
This will be great for the time being. I'll test this out, and see if there's anything that needs improving.

I'll just go ahead and merge this.
Thanks again!


[Draft] [SCM] Logging policy prototype with double logging

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel


Data analysis for build vs. buy

Details on the dataset and proposed analysis:  https://docs.google.com/document/d/15wtHF1HSxYm-CZzeTUk24OYkJb3UUCC-tKIRj9dKVrw/edit?usp=sharing


:construction_worker: build: run workflows for alpha branch too

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Include hash property to the native contract classes

Summary or solution description
Implemented a property in the native contract classes to access their script hash inside of other smart contracts
How to Reproduce
https://github.com/CityOfZion/neo3-boa/blob/e5af3af0bca98410a6254b7e7ed6172335f2d62a/boa3_test/test_sc/native_test/contractmanagement/GetHash.py#L2-L8
Tests
https://github.com/CityOfZion/neo3-boa/blob/e5af3af0bca98410a6254b7e7ed6172335f2d62a/boa3_test/tests/compiler_tests/test_native/test_contract_management.py#L16-L21
https://github.com/CityOfZion/neo3-boa/blob/e5af3af0bca98410a6254b7e7ed6172335f2d62a/boa3_test/tests/compiler_tests/test_native/test_cryptolib.py#L29-L34
https://github.com/CityOfZion/neo3-boa/blob/e5af3af0bca98410a6254b7e7ed6172335f2d62a/boa3_test/tests/compiler_tests/test_native/test_ledger.py#L17-L22
Platform:

OS: Windows 10 x64
Python version: Python 3.7+

Task linked: CU-31n7xq0 Include hash property to the native contract classes


There is no icon after install.

Describe the bug
There is no icon after install.
Screenshots

Technical Info (please complete the following information)

OS: Manjaro KDE
Ao Version:5.6

Did anyone find a fix?
I'm having the same problem using the AppImage on Solus.


chore: add py.typed file

Having this file available makes pyright happier when checking code that imports Scenario.

This could be the easiest code review ever, and also my most boring PR ever :laughing:.


Add Redux

In this branch

I created a redux store
Upon first render fetch data from the SpaceX API endpoints
Dispatched an action to store the selected data in Redux store

Hi @uchexm ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
✅ Correct use of Github workflow
✅ No linter error
✅ README is okay
✅ Good PR Description👍
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Linked successfully but not show on Google Home app

Before submit a support ticket, just want to see if we are lucky that someone can help.
We have 1-2 case among the the thousands, since recently Google account shows the service is linked, but we can't make devices show on Google Home app. Meanwhile from state report log, we got "Requested entity was not found error".
We check the discovery response with validator and all looks good.

Finally we assist the customer to find the issue. One of the device name is one space, so that makes the sync a bit of trouble. We fixed the problem by renaming the space only device if there was.


New to Hoobs,  Isssues adding doorbird

Hi,
I just purchased hoobs aand uploded to latesst release 3.3.1. i have 2 doorrbird systems and downloaded the plugin s/w, but do not know how to proceed further. appreciatee your guidance herer. homebridge does show in my homekit aas a bridgee, but not  the accessory yet.
thanks

Hi! Welcome to the Homebridge ecosystem. Unfortunately, I don't use HOOBS, I use Homebridge directly (which also has a nice webUI) so I'm afraid I can't help you track down the details within HOOBS. Essentially, you need to configure the plugin. There should be a webUI within HOOBS that you can use.
Take a look at the HOOBS documentation on configuring plugins: https://support.hoobs.org/docs/5e7644ece87d1e02b6c19d42
Hope it helps.

thanks a lot for the prompt response. will do and will revert back. happy
to follow the same process as Homebridge as i beleive they are similar.
would be great if you could share also the Hombridge plugin config for
doorbird.
thanks !
Moustafa
On Thu, Dec 17, 2020 at 5:57 PM hjdhjd<EMAIL_ADDRESS>wrote:

Hi! Welcome to the Homebridge ecosystem. Unfortunately, I don't use HOOBS,
I use Homebridge directly (which also has a nice webUI) so I'm afraid I
can't help you track down the details within HOOBS. Essentially, you need
to configure the plugin. There should be a webUI within HOOBS that you can
use.
Take a look at the HOOBS documentation on configuring plugins:
https://support.hoobs.org/docs/5e7644ece87d1e02b6c19d42
Hope it helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hjdhjd/homebridge-doorbird/issues/162#issuecomment-747454218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASFDBR6MOSULQTMYPLA44K3SVIE6JANCNFSM4U7TVDXA
.


Check size of screenshots

Ideally images should be <100kb so the doc pages load quickly. It would be worth reviewing the screenshots after fixing issue #49 (turning the linter off as in https://github.com/r-devel/r-dev-env/issues/49#issuecomment-1889621409 will change the appearance of R scripts in VS Code).
Images can be optimized in R, for some example code, see https://github.com/r-devel/r-project-sprint-2023/blob/main/participants/optimize_photo.R.

Incidentally, I'm not sure where the source images are that end up in https://github.com/r-devel/r-dev-env/assets. Is it possible to put them in a regular repo folder so it is easier to track them down?

Work to be Done:
Few updates for screenshot is remaining

Several of the new screenshots are ~200KB or more, so should be optimised.

Redirect #145


Refactored project structure to allow a simpler installation

Put everything into a python module, so that it can be installed using the setup.py standard syntax. Plus, in this way the imports are not relative anymore, and that makes it simpler to avoid circular imports and allows a better structure. This is a starting point to solve #12

Well done! Amazing first contribution. #shipIt


feat: handle Matic token icon

Test plan
Check http://localhost:3000/token/eip155:137:0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee?s=64 returns Matic icon.

Would this work with short names (EIP-3770)?

This returns Ethereum logo for me somehow http://localhost:3000/token/eip155:137:0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee?s=64
Same with short names.

@bonustrack doesn't for me:

Looks like AWS somehow caches it.


[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0

What this PR does / why we need it:

update scdf version to 2.4.0
update skipper version to 2.3.0
update chart dependency versions

Signed-off-by: Chris Schaefer<EMAIL_ADDRESS>Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @sabbyanandan


BUG: TV Super Resolution Node crashes with segmentation fault

See trace below.
Note that --nipype_nb_of_cores and --openmp_nb_of_cores parameters not specified, and SR image is well computed and saved.
Inner loop optimization took 96.245 (Unix time)
##########################################################################################################

Writing /output_dir/nipype-1.6.0/sub-ctrl0038/ses-20180912073131/rec-3/srr_pipeline/srtkTVSuperResolution/SRTV_sub-ctrl0038_ses-20180912073131_6V_rad1.nii.gz ... done.
  > Write JSON side-car...
  > Load SR image /output_dir/nipype-1.6.0/sub-ctrl0038/ses-20180912073131/rec-3/srr_pipeline/srtkTVSuperResolution/SRTV_sub-ctrl0038_ses-20180912073131_6V_rad1.nii.gz...
    Image properties: Zooms=(1.125, 1.125, 1.125)/ Shape=(320, 320, 94)/ FOV=[360.   360.   105.75]/ middle cut=[160, 160, 47]
  > Crop SR image at (100:220, 100:220, 0:-1)...
Fatal Python error: Segmentation fault

Current thread 0x00007f0a56ad1780 (most recent call first):
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/numpy/linalg/linalg.py", line 1456 in eigh
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/quaternions.py", line 211 in mat2quat
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/nifti1.py", line 1031 in set_qform
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/nifti1.py", line 1817 in _affine2header
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/spatialimages.py", line 503 in update_header
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/nifti1.py", line 1807 in update_header
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/nifti1.py", line 2044 in update_header
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/spatialimages.py", line 469 in __init__
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/analyze.py", line 923 in __init__
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/nifti1.py", line 1772 in __init__
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nibabel/spatialimages.py", line 350 in __getitem__
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/pymialsrtk/interfaces/reconstruction.py", line 422 in _run_interface
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/interfaces/base/core.py", line 434 in run
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 741 in _run_command
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 635 in _run_interface
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 516 in run
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 67 in run_node
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/process.py", line 239 in _process_worker
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/process.py", line 99 in run
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/process.py", line 297 in _bootstrap
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/popen_fork.py", line 74 in _launch
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/popen_fork.py", line 20 in __init__
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/context.py", line 277 in _Popen
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/multiprocessing/process.py", line 112 in start
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/process.py", line 607 in _adjust_process_count
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/process.py", line 583 in _start_queue_management_thread
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/process.py", line 641 in submit
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 175 in _submit_job
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 367 in _send_procs_to_workers
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/plugins/base.py", line 184 in run
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/engine/workflows.py", line 632 in run
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/pymialsrtk/pipelines/anatomical/srr.py", line 679 in run
  File "/opt/mialsuperresolutiontoolkit/docker/bidsapp/run.py", line 235 in main
  File "/opt/mialsuperresolutiontoolkit/docker/bidsapp/run.py", line 306 in <module>
exception calling callback for <Future at 0x7f09e1868a10 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/_base.py", line 324, in _invoke_callbacks
    callback(self)
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 159, in _async_callback
    result = args.result()
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/_base.py", line 428, in result
    return self.__get_result()
  File "/opt/conda/envs/pymialsrtk-env/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

Please reopen issue if needed


[Staging & Production] Graph blank when results published longer than 3 months ago

Steps

Go to the SHARE page on production
Enter 'nosebleed' into the search query

Expected
The graph of events would update showing the events from the search. Updating the x-axis from 'Last 3 months' to index a longer length of time to include the search results.
Actual
The graph retains the length of time of 'Last 3 months' and is blank.

The released data on this event is 2014-11-04 and the other one is 2014-10-29, which is more than 3 months ago. I assume this is the right behavior since there are actually no event going on in the last three months. @nicipfeiffer @erinspace

@erinspace -- Can you provide insight on whether this is an issue or not? Thanks.

Will be addressed in @bdyetton 's search page ui update.


Carousel Initial Index

Is this a bug report or a feature request?
Bug Report

Have you read the guidelines regarding bug report?
Yes
Have you read the documentation in its entirety?
Yes
Have you made sure that your issue hasn't already been reported/solved?
Yes
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Both
Is the bug reproductible in a production environment (not a debug one)?
Yes

Have you been able to reproduce the bug in the provided example?
No

Environment

(Write your answer here.)
Steps to Reproduce

(Write your steps here:)

Create Carousel with this config

<Carousel
            ref={(c) => { this._carousel = c}}
            data={this.state.milkingPositions}
            renderItem={this._renderItem}
            sliderWidth={width}
            itemWidth={width * 0.8}
            firstItem={17}
          />

Carousel only initiate on index 9 instead index 17. For index smaller than 09 it works.

Expected Behavior

Carousel initiate on index 17.
Actual Behavior

Carousel Initiate on Index 09 instead index 17.
Reproducible Demo

(Paste the link to an example project or paste the entirety of the relevant source code. Then provide instructions to reproduce the issue.)

Hi @filiipake,
This is the same issue as #235.
Take a look at this comment to learn more about the matter and to find out potential workarounds.

Ops, sorry man, i try to find in your repo and didnt found anything. Thanks!


⚠ Samsung has degraded performance

In df6bc64, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2329 ms

Resolved: Samsung performance has improved in 9efe713.


[Feature] Support use histogram statistics estimate row count

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

[FE PR Coverage check]
:disappointed: fail : 25 / 159 (15.72%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/Bucket.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnHistogramStatsCacheLoader.java
0
4
00.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java
8
132
06.06%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnStatistic.java
6
8
75.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
11
14
78.57%

[FE PR Coverage check]
:heart_eyes: pass : 116 / 129 (89.92%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnHistogramStatsCacheLoader.java
0
4
00.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java
74
80
92.50%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/Bucket.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/Histogram.java
22
22
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnStatistic.java
8
8
100.00%


Automated cherry pick of #9441: bugfix(region): server change config rebase to sched task

Cherry pick of #9441 on release/3.6.
#9441: bugfix(region): server change config rebase to sched task

/lgtm
/approve


Adding '!' (Factorial) Operator

I want to implement the '!' (factorial) operator to allow users to calculate factorials of numbers.
So may I work on this issue under Hacktoberfest 2023?

Are you from STIC event?

No


Update js name of file with all app JS to main.js

build/js/app.bundle.js link is not present anymore in generated index.html file. I think the new file is build/main.js if I'm right ? So I update it...

Rewrote this a bit.
https://github.com/driftyco/ionic-site/commit/ba9cca502b91e4fdd3af22934e6ee7a8acfba63d
Closing since it's no longer needed, but thanks.


Max-heap howto?

Hi, I noticed that the current implementation creates a min-heap (root is min value in heap). How can I construct a max-heap, where max value will take the root position? I know that it is basically switching the <> operators but I'd rather ask here in case it is something more than just operator change.

Can't you just provide a comparison operator in the heap constructor?  I think that's what I did...digs in old code... yep local h = heap:new(function(a, b) return a > b end)

I see, didn't realize comparison function can be used to do that. Thanks.


Add internal/limitreader package

This implements something similar to io.LimitReader, but reports error
when it's read beyond the limit.
It's under internal as this is a special case that we don't want to make
as part of our public API. We can move it out of internal in the future
if there are wider demands for it.
Switch filewatcher to use that instead of io.LimitReader. It could also
be used in https://github.com/reddit/baseplate.go/pull/385.

For example, if we e.g. read the first 1k of a file, do envsubst on it, and then combine with the rest, using the presence of the error to report to the user a warning that their config was too long

This is not a realistic scenario. An env var can be just at the boundary. For example you have this: $ENVVAR while the $ENV part is before boundary and VAR is after, and if you do that you will substitute $ENV and combine that with literal VAR, which is wrong.
And if we really want to do that, stdlib is sufficient and we don't need to build our own:
func envVarSubstitutionMaxN(r io.Reader, n int) io.Reader {
  var buf bytes.Buffer
  _, err := io.CopyN(&buf, r, n)
  // handle err, do env var substitution inside buf
  return io.MultiReader(buf, r)
}

Replaced by https://github.com/reddit/baseplate.go/pull/390


Update milestone-deliverables-guidelines.md

Some suggestions. Let me know what you think.

Thanks!


feat: add Terraform directory example

@aliscott we'd like the examples to show how they can be used with     on: [pull_request] as that's the default behavior we want to encourage (to post a single PR comment that gets updated). Does that require changes to the test automation to override that so the example tests are run on master in this repo too?

@aliscott we'd like the examples to show how they can be used with on: [pull_request] as that's the default behavior we want to encourage (to post a single PR comment that gets updated). Does that require changes to the test automation to override that so the example tests are run on master in this repo too?

It's only the config from the jobs key in the example that is pulled into the test, so anything before that such asa on: [pull_request] can be whatever we want in the example.


Allow UDP listening port selection for Android

Problem
In AndroidDeviceControllerWrapper.cpp, the UDP listen port is assigned to CHIP_PORT + 1. If multiple processes are using the SDK, this can cause message delivery failures as both processes are bound to the same port.
Proposed Solution
Either of:

Fix this port to 0 to allow random selection.
Allow propagating a value for this port from the Android Java layer.

@gmarcosb will look into this.
regarding deferral candidate, will leave it up to Marcos if this is important pre 1.0 or not given that this is platform-specific.

For now assuming not deferral since this is relating on Android platfor support for controllers.

Yeah, notably since we expect multiple applications to include this SDK, I think the default behavior here will cause incompatibility. (e.g. if two apps A and B are installed with the default configuration, and both processes are running, then they will run into collissions).


[Feature Request] Add Active Effects to Half and Three-Quarters Cover

Currently applying the 'Half Cover' and 'Three-Quarters Cover' only applies a status icon but still requires manual input of -2/-5 to an attack or manual adjustment of the AC.
It would be nice for those two statuses to apply the AC bonuses automatically while the status is applied to an actor, which will help avoid players and GMs forgetting to add a situational bonus of -2/-5 to the roll dialog and keeping the visuals for hits/miss in the chat cards consistent to the AC of an actor.

Insert witty comment here.


fix(demo): remove player.reset before loading a new source

Description
Calling player.reset() before loading a new source was preventing the webkitneedkey event from being listened by videojs-contrib-eme resulting in the inability to play DRM protected content.
Changes made
Removed this call from the demo and added a KNOWN_ISSUES describing the problem and the solution for tracking purposes.

@jboix I think this problem could be solved if #113 is made instead.

@jboix I think this problem could be solved if #113 is made instead. It also brings back the problem of the poster when transitioning from one content to another, or when playing content that doesn't have a poster.

My bad ! I completely forgot about the poster bug. I reverted the fix in the demo from this PR and I will implement #113 here. The issues with calling player.reset() still exists, I think it is good to have it documented though.
Potential fixes that I see in pillarbox are :

Reproduce the fix that was implemented in the letterbox middleware, for reference:

 if (videojs.browser.IS_ANY_SAFARI && Drm.hasDrm(resourcesList)) {
  player.eme = videojs.getPlugin('eme');
  player.eme();
}

Submit a change request to videojs-contrib-eme that listens to the playerreset and reattaches the webkitneedskey event to the tech (videojs-contrib-eme/src/plugin.js#L234).

Updated the description of the pull request to reflect the new changes that are implemented as suggests in #113.

@jboix I don't really like the Letterbox approach, and I'm pretty sure I wrote it. 🥲
To address all the issue we can follow video.js recommendations, please refer to Showing and Hiding a Player
With this in mind, we can imagine doing something like the following:
demo/src/player/player.js
import Pillarbox from '../../../src/pillarbox.js';
import '../../../src/middleware/srgssr.js';

// Expose Pillarbox and player in the window object for debugging
window.pillarbox = Pillarbox;

// TODO must be remove once tagCommander is pillarbox ready
//
// Allows to track comscore events
//
// This is necessary because a tagCommander script uses videojs directly for some
// unknown reason. Pillarbox does not expose videojs, because pillarbox
// is a superset of videojs, this causes an error preventing comscore
// from initializing correctly.
window.videojs = Pillarbox;

export const disposePlayer = () => {
  Pillarbox.getPlayer('player').dispose();
};

export const createPlayer = () => {
  window.player = new Pillarbox('player', {
    fill: true,
    html5: {
      vhs: { useForcedSubtitles: true },
    },
    liveTracker: {
      trackingThreshold: 120,
      liveTolerance: 15,
    },
    liveui: true,
    muted: true,
    playsinline: true,
    plugins: { eme: true },
    responsive: true,
    restoreEl: true
  });

  return window.player;
};

Then:
demo/src/player/player-dialog.js
import { createPlayer, disposePlayer } from './player';

// ... I removed the rest for the sake of simplicity

dialog.addEventListener('close', () => {
  disposePlayer();
});

export const openPlayerModal = ({ src, type, keySystems }) => {
  const player = createPlayer();

  player.src({ src, type, keySystems });

  dialog.showModal();
  dialog.classList.toggle('slide-up-fade-in', true);
};

With this, there is no more DRM issues with Safari, and we also address the #113.
Disclaimer, I didn't test the code above 😅

@amtins That's exactly what I did. I changed this PR right before your comment:

Updated the description of the pull request to reflect the new changes that are implemented as suggests in #113.

Indeed your code didn't work during my testing since player.dispose() got rid of the HTML element, that's why I resorted to create the element using videojs DOM utilities right before initialising it.
I agree that the letterbox fix is not clean, my suggestion is to keep this issue documented in KNOWN_ISSUES until we can find a cleaner solution.

@jboix sorry, I should have add a comment about the property restoreEl set to true in my example. Adding this property to the options allows to avoid recreating manually a videoElement each time. See restoreel

@jboix sorry, I should have add a comment about the property restoreEl set to true in my example. Adding this property to the options allows to avoid recreating manually a videoElement each time. See restoreel

That works! I've changed the code. Thanks for the feedback 👍


Fixed broken Advanced Linux Programming link

Would it be better to instead link to the web archive link for the website, which still allows you to download the PDF? https://web.archive.org/web/20160324235624/http://advancedlinuxprogramming.com/

why not use https://mentorembedded.github.io/advancedlinuxprogramming/ ?

Oh, even better. Didn't see that.


Textures for pre-1.5 animated blocks and items

Still water: Documented here. Don't know of any changes that happened to it between 0.0.19a and 13w01b (unless you count swamp tinting), so I'm assuming it stayed the same.
Still lava: Again documented here. Also don't think this changed at all between 0.0.19a and 13w01b.
Flowing water: Not too sure how this was generated, although probably very similar to still water. The texture seems to have been first added in the first indev version, for the sides of water blocks, although it appeared to be still without any translational effects to imply motion. This translation was first added in the June 15th infdev build. I am not aware of any other changes.
Flowing lava: Probably first introduced in the 0616 build, this is identical to the still lava of the time but had the translation effect. Again, not aware of any other changes.
Fire: Not sure how this was generated. Worth noting is that in the current (1.5 and up) versions of the game there are two fire textures, which are visually similar but still different, seemingly used to make fire appear more random. The existence of two different fire placeholder textures in terrain.png since Beta 1.2 implies this was also the case this far back as well (and may have been even before that, although I can't be sure).
Nether portals: Again not sure how this was generated. Documentation as to how this, fire and flowing water were generated would be useful.
Gears: Again there were two instances, one for each direction of rotation. These without a doubt used the misc/gearmiddle.png remaining stationary, and rotated misc/gear.png around it, pixelated to appear 16x16 at all times.
Clocks: These used the clock file from terrain.png, with the purple section replaced with a rotated and pixelated dial.png. Clocks were far more precise with these textures than what they were changed to in 1.5 and up.
Compasses: A similar story, although the needle appears to be automatically generated and not based on any texture. Again much more precise than 1.5's replacement.

I do not know how animated textures for all of these were generated in early Pocket Edition or Console Edition where applicable, although I'd assume mostly the same (possibly with subtle hardware differences perhaps due to using a different RNG or the like).

Still water: Documented here. Don't know of any changes that happened to it between 0.0.19a and 13w01b (unless you count swamp tinting), so I'm assuming it stayed the same.
Still lava: Again documented here. Also don't think this changed at all between 0.0.19a and 13w01b.
Flowing water: Not too sure how this was generated, although probably very similar to still water. The texture seems to have been first added in the first indev version, for the sides of water blocks, although it appeared to be still without any translational effects to imply motion. This translation was first added in the June 15th infdev build. I am not aware of any other changes.
Flowing lava: Probably first introduced in the 0616 build, this is identical to the still lava of the time but had the translation effect. Again, not aware of any other changes.
Fire: Not sure how this was generated. Worth noting is that in the current (1.5 and up) versions of the game there are two fire textures, which are visually similar but still different, seemingly used to make fire appear more random. The existence of two different fire placeholder textures in terrain.png since Beta 1.2 implies this was also the case this far back as well (and may have been even before that, although I can't be sure).
Nether portals: Again not sure how this was generated. Documentation as to how this, fire and flowing water were generated would be useful.
Gears: Again there were two instances, one for each direction of rotation. These without a doubt used the misc/gearmiddle.png remaining stationary, and rotated misc/gear.png around it, pixelated to appear 16x16 at all times.
Clocks: These used the clock file from terrain.png, with the purple section replaced with a rotated and pixelated dial.png. Clocks were far more precise with these textures than what they were changed to in 1.5 and up.
Compasses: A similar story, although the needle appears to be automatically generated and not based on any texture. Again much more precise than 1.5's replacement.

I do not know how animated textures for all of these were generated in early Pocket Edition or Console Edition where applicable, although I'd assume mostly the same (possibly with subtle hardware differences perhaps due to using a different RNG or the like).

@muzikbike Wow, this is a large amount of very useful information, thanks for posting it here! I'll try to work my way through implementing some of these. Sorry for not responding until now, GitHub doesn't seem to notify me when someone makes an issue on a project.

There is now a wiki page, which also includes nether portal details: https://minecraft.fandom.com/wiki/Procedural_animated_texture_generation

It also seems that lava was different around c0.0.19a, but finding out how that works will probably require some reverse engineering.

@muzikbike The gear rotation animation has been added to the latest release! It'll take a while to work through the entire collection of procedurally generated textures, but I'll try to keep you updated.

Should I split this ticket into one per animated texture?

Should I split this ticket into one per animated texture?

@muzikbike That would probably be easier to manage, so I'd be happy for you to do it! By the way, I just implemented nether portal texture generation, so you won't need a new ticket for it!

Now split fully into 10 separate cases.


improve failure detection for XyzGeoresources

fixes #2572

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

43 of 43 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.679%

Totals

Change from base Build<PHONE_NUMBER>1:
0.001%

Covered Lines:
13041

Relevant Lines:
13042

💛  - Coveralls


E-Mail - Suggest Mailcow

E-Mail section is marked as work in progress, I presume it will be how to do everything manually.
An alternative to manually setting up everything for the e-mail server, is Mailcow. It would be a nice addition alongside the manual setup guide.
https://mailcow.email/
It uses pretty much all the common tools, and just nicely configures everything. The most you really have to do is is setuo your dns records.
https://mailcow.github.io/mailcow-dockerized-docs/
I know Luke also has a script, and wants to abstain from containerization, however at least mentioning mailcow would be a good idea in my opinion.
It's just a nice alternative

E-Mail section is marked as work in progress, I presume it will be how to do everything manually.
An alternative to manually setting up everything for the e-mail server, is Mailcow. It would be a nice addition alongside the manual setup guide.
https://mailcow.email/
It uses pretty much all the common tools, and just nicely configures everything. The most you really have to do is is setuo your dns records.
https://mailcow.github.io/mailcow-dockerized-docs/
I know Luke also has a script, and wants to abstain from containerization, however at least mentioning mailcow would be a good idea in my opinion.
It's just a nice alternative

For that you cloud use something like https://workaround.org/ISPMail/Buster/.

That actually looks pretty nice, however it's a completely different concept from Mailcow.
That guides you through and helps you understand how everything works and how to set it all up (which is excellent knowledge to have).
But it also takes significant time and if you already have a general idea, not a lot of time, Mailcow may be more of interest to someone. It's very actively maintained, and has a large community, and as I've said it essebtially does all the work for you, it could be setup in under 20min.

That's why Luke wants to abstain from docker, because you dont know what is running on the underhood which is an issue for yourself, as Mailcow cloud easily run a crypto miner whitout you noticing, i am not saying that it is going to run it but it cloud.

That's why Luke wants to abstain from docker, because you dont know what is running on the underhood which is an issue for yourself

This can literally be said about any piece of software or script and isn't really a container specific issue.
Anyways all of the software being used is completely libre, as is mailcow itself. Docker allows for excellent replicability, while I wish Mailcow also offered a non-containerized version. Everything is isolated and consistent, and are portable.
Mail can be pretty complex and for users who barely understand how to setup a website, Mailcow can make things pretty simple to be able to have their own Mail server up and running. While there are concerns about the user should really know how everything is working so they can administer it better, it is not much different than someone just installing Luke's mail script and automating the setup.
Again, I'm not saying to use instructions to install Mailcow over a manual install or Luke's script, but I think it should at least be mentioned.
Luke's really hasn't given much for reasoning as to why he dislikes containerization, I feel he hasn't used it much, nor looked into it much, it has many practical uses, security benefits, portability benefits, and is pretty consistent across systems. While I do think all software should also offer direct host installation, I don't entirely agree with the abstaince from containerization.
Also that being said Docker does have it's issues, although Podman has been attempting to resolve those. But directly installing onto the host has it's issues as well, which is why containers have become more common. Allow the users to choose which works best for them, at least provide them with the basic knowledge that other options exist.

I really liked this article, however I think Luke uses Postfix instead of OpenSMTPD
https://poolp.org/posts/2019-09-14/setting-up-a-mail-server-with-opensmtpd-dovecot-and-rspamd/

Mailcow requires a lot of resources to run, including ClamAV and Solr (a whopping 6gb ram minimum). It includes groupware features preinstalled, which might be quite a lot of bloat for just a mailserver; why not at that point setup nextcloud?
Since we're talking about newcomers owning just a tiny Vultr server with just 512mb of RAM, I don't see how running even one container on it could be possible.
 They wouldn't know what containerization and Docker is and what it does, how to manage it if something goes wrong.

Mailcow requires a lot of resources to run, including ClamAV and Solr (a whopping 6gb ram minimum). It includes groupware features preinstalled, which might be quite a lot of bloat for just a mailserver; why not at that point setup nextcloud?
Since we're talking about newcomers owning just a tiny Vultr server with just 512mb of RAM, I don't see how running even one container on it could be possible.
 They wouldn't know what containerization and Docker is and what it does, how to manage it if something goes wrong.

True, i think you explained it better than i did.

Mailcow requires a lot of resources to run, including ClamAV and Solr (a whopping 6gb ram minimum ).
ClamAV and SOLR are both optional, that's clearly stated. none the less the minimum specs they suggest are way overstated, and I and others have suggested lowering this but they don't want to.
I and many others have been running Mailcow for a long time with ClamAV and SOLR on VPS's with 2gb of ram and we usually just give it like 2-4gb of swap just in case.

 They wouldn't know what containerization and Docker is and what it does, how to manage it if something goes wrong.

In what way do you feel MANUALLY setting all this up would be a easier for a newcomer than offering the users an option like Mailcow? The only reason I can see would be that they have a better understanding of what is going on under the hood, however if they can barely use a terminal, they really shouldn't be running a mail server. Either way, something like Mailcow (even if they had to learn docker basics) would be SIGNIFICANTLY simpler than manually installing all of the components, piecing them together, configuring them, then their DNS records, then also dealing with inevitable issues due to their misconfiguration, and hoping they also have done proper basic security measures. It's not that complex, but to someone who has never touched a terminal, this seems like a very poor idea imo.
And this wouldn't be any different than running a script, just instead the script will be less maintained than a project like Mailcow.
And once again, I NEVER suggested making the e-mail page only ahout Mailcow, but at least link to it within the e-mail page, would be a good idea for users who would prefer that method.


contact us section

hey there @KiranAminPanjwani , i want to improve contact us section as it is covering so much area and form is not looking good i want to make it more attractive
#hackoctoberfest22

Sure, please go ahead! 🤩

Hii, @KiranAminPanjwani , i want to contribute. Please give a chance.

Hii @KiranAminPanjwani , Please assign this issue to me.