b2EPCollider::Collide method doesn't use m_radius of the shapes

The collision manifold calculating code of the b2EPCollider::Collide method  in b2CollideEdge.cpp  (as of commit 374664b from Jun 19, 2016) calculates the total radius on line 435 as 2 * b2_polygonRadius. A b2EdgeShape instance or a b2PolygonShape instance can have a different m_radius than b2_polygonRadius however.
For shapes having m_radius settings greater than b2_polygonRadius, this results in a dynamic polygon body in a gravitational world that would otherwise sit atop the edge repeatedly bouncing up and down from the edge.
Everything appears to work correctly if the total radius calculation is changed to be the sum of the m_radius values of each shape.

In a sort of similar problem, b2CollidePolygon.cpp in function 'b2CollidePolygons()', the 'm_radius' of each edge is just extended along the edge and tangent to it which is fine for a small radius (such as b2_polygonRadius) however if it's increased then collisions are not detected using a correct radius around the edge vertices.  This can been seen when using the Capsule shape contribution which uses an edge with a radius; it just doesn't work correctly if you want to use Polygon/Polygon with a radius that's substantial (visible!).

@MelvMay Thank you for bringing a problem with b2CollidePolygons to our attention! I'm unclear however what the problem is that you're describing. Are you pointing out how collisions with vertices (as opposed to edges/faces formed by vertex pairs) aren't been treated as rounded corners except for edge-circle collisions (where a e_circles type manifold should really be getting calculated)?

So I'm the guy who integrates 2D physics into Unity: Various stuff here.
When I was implementing its CapsuleCollider2D my first approach was to use the Box2D capsule contribution and all seemed well until the capsule tried to slide off a platform corner.  I noticed that the capsule acted like a box rather than have rounded ends.  I ended up writing my own version but the problem with the b2ColliderPolygons still exists.
So, the capsule contribution above highlights the problem as it uses a single edge polygon with a radius as a capsule.  This works, as you referred to, when doing edge/circle (e_circles type manifold) however for edge/edge i.e. polygon/polygon (e_faceA & e_faceB type manifold) then obviously 'b2ColliderPolygons()' is used.  This function results in both edges+radius acting like simple boxes.  Sutherland-Hodgman clipping is used here with the segments extended by the total radius of both edges.
This is a shame because the b2Distance function that uses simplexes works perfectly for a simplex-2 (edge+radius) so overlap checks are fine.
As an example, create two b2PolygonShape boxes with a fairly large and clearly visible radius.  Then position them so that the rounded corners don't quite overlap.  The existing algorithm detects that as a colliison as if the boxes were not rounded (see attached image).  Note that you can do the same with a single box with large radius and a box with the stock b2_polygonRadius and get the same result.
Hopefully, this image will help explain a little better:

@MelvMay Thanks for the clarification! This is indeed the problem that I was thinking you could have meant. I've actually been working on the collision code to add handling like we're talking about. I have the code changes necessary for the polygon-circle manifold calculating function done and I'm working on the changes for the remaining collision-pair types. I've also created a separate issue (issue #429) for this other problem.

I'd be interested in seeing your solution.
My code for CapsuleCollider2D inside Unity is a little convoluted and I'll be working on making it more efficient in the new year for Unity 5.6 but I'd be interested to see what you've come up with.  I can only say that if it's better than what I've got then, with your permission, I'd have no problem switching to your code, with the proper attribution of course!
As an aside, I did have an 'Edge Radius' in 5.6 however it's been removed due to the problems with poly/poly + radius above.  Various other things have stopped me working on this unfortunately but again, it stems from the same issue above.

@MelvMay I have the code working now for this in my dev branch (prior to commit dfd51ec). Sorry it took me till now. I've been working on another thing that I wanted to change in the code but got this done now as a side-effect of sorts of trying to make the other change. Here's a screen shot of it:

This picture shows a circles-type collision occurring between a triangle and a capsule. These are implemented both as polygons (the triangle having 3 vertices and the capsule having 2).
Unfortunately I believe it will take some translation and temporal Kung-fu of my code to recognize where things are getting done for this. When I developed the code, I found it preferable to generalize the polygon shape type to handle two or one vertices rather than create yet another new shape type. And this code is still very much in flux. If you want to see it though, look around in Box2D/Collision/CollideShapes.cpp, specifically from the Manifold CollideShapes(const PolygonShape& shapeA, const Transformation& xfA, const PolygonShape& shapeB, const Transformation& xib) function.
Algorithmically speaking, I achieved this solution essentially by removing the addition of the skin radius total from the incident edge clipping and then checked for the vertices being within that total radius of each other when edge collision wasn't detected. If the vertices were within the total radius of each other, then a 'e_circles' type manifold is returned from the manifold calculating code (instead of the face type manifold that would have formerly been returned).

I worked on this over xmas and it sounds pretty much what I came up with by removing the 'side offsets' part then checking the vertex.  I'll check out your code this week.  I very much appreciate you getting back to me, thanks!

Hi Guys, sorry I'm late to respond. The radius exists for polygonal shapes only to support continuous collision detection. There is no support for rounded polygons. In my experience it is best to implement capsule collision directly and handle all the different cases with new collision functions. I'm making the change suggested in b2EPCollider::Collide, but that is just for correctness and does not provide new capability. I've also added this comment to b2Shape::m_radius:
/// Radius of a shape. For polygonal shapes this must be b2_polygonRadius. There is no support for
/// making rounded polygons.

@MelvMay-Unitywhich way is currently used in Unity? Do you use edge radius or recommended separate capsule shape?


Fixed issues #6 and #9.

In all honesty, I've been a bit busy with school, and most of my interest has drifted off to Rust. Perhaps you'd be interested in maintaining this?

If you no longer have the interest or time, I think I could take over maintaining it if you'd like.


Better arviz support in base inference

Motivation
When I was doing bug fixing I noticed my arviz changes were lost in the shuffle. These commits add the functionality while keeping the APIs unchanged as much as possible.
Changes proposed
Changes the
Test Plan
Please provide clear instructions on how the changes were verified. Attach screenshots if applicable.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

:D Ah, this is a nice feature to have for our next release. Thanks for working on this, Rob! I'm going to import the PR now just so that we can see the test results. I'll have to review this a bit later, though, since there're a few other pre-launch items that we have to focus on at the moment.
In the mean time, there's a get_chain method that returns another MonteCarloSamples that people sometimes use to retrieve the data for a particular chain. Could you check if that's still working as expected with your change?

I think get_chain should still work like it did before, but I should pass likelihoods to the MonteCarloSamples object returned by that method.

@zaxtax Was facebook-github-bot acting crazy? Or did you actually update this PR 42 times this afternoon? 🤣

I force-pushed once and I think I upset the bot. I apologise to everyone
else you got that flood of emails 😅
On Wed, 15 Dec 2021, 05:01 Xiaoyan Wang, @.***> wrote:

@zaxtax https://github.com/zaxtax Was facebook-github-bot acting crazy?
Or did you actually update this PR 42 times this afternoon? 🤣
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/beanmachine/pull/1269#issuecomment-994293750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACCUPHGBOSTJRPIM2667TURAOI5ANCNFSM5KB2AA5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Haha don't worry, this is actually hilarious. I'm going to report this bug to our internal support team :)

I thought we still have a type error on this diff but seems like I was wrong :). Our internal tool does warn us that this PR is a bit old, so I'm going to rebase and rerun the internal tests. If the signal is still green then we are good to go. Thanks again for working on this, Rob!


[FEATURE] Serving SLI_REC model with TFServing2.0

Description

The SLI_REC model is for realtime-inference, it would be better if we have the model serving part to be included in the repo.
Expected behavior with the suggested feature
Adding Model serving part will help people understand more about industrial use case scenarios. For industry use case,  the model latency, scalability are also key metrics.
Other Comments

It is good feature to have. Really thanks @weiczhu for the feedback!

I've been trying to do this using tf.saved_model.builder to create a a saved_model.pb file set that can be easily served from a  TFServing Docker container. I'm new to TF so I've sort of jumped into the deep end here. From what I can find, tf.saved_model.builder needs to have the model inputs and outputs specified. This step of identifying model inputs and outputs has been surprisingly complicated. I've tried plotting the model in Tensorboard but am still struggling.
Any guidance on saving a SLi_REC model with tf.saved_model.builder would be very much appreciated and would help fill the gap until the feature above is implemented. Thanks @yueguoguo .

I am updating the  examples/00_quick_start/sequential_recsys_amazondataset.ipynb and add a serving example at the end of the notebook, hope this can help you.
https://github.com/microsoft/recommenders/pull/1254


Webview scroll fails on android

hi,
the issue is when using webview in the content, scrolling not responsive. Sometimes it detects sometimes not.
I though it prevent by flutter_slider_drawer, maybe up and down gestures.
https://youtu.be/RzgO9DUi4FI

i got this problem too, and now still no solution for this...

trying using another library got same result, i endup create my own code, its not complex code, just using AnimatedPositioned widget... and my webview it's working normaly now...

I created a fork and conditioned the part related to the gesture detector. If it doesn't affect your application's usability, you can try using it by simply adding the attribute "useGestures = false". Link: https://github.com/Segatti/flutter_slider_drawer

Hello @Segatti , Can you able to raised the Pull Request for this issue?

@NikhilVadoliya There is already an old PR with these commits.  https://github.com/NikhilVadoliya/Flutter_slider_drawer/pull/34


Dubbo- #1684

What is the purpose of the change
add dubbo-container unit test
XXXXX
Brief changelog
add dubbo-container unit test
Verifying this change
add dubbo-container unit test
]

@stoneapple I'll close this PR, if necessary pls. send a new PR with the review comments. Thanks.

https://github.com/apache/incubator-dubbo/issues/1685

@stoneapple ,please see the review result


AppDelegate application(_:didFinishLaunchingWithOptions:) did change

Description
Resolves build issues in Xcode 6.2 (6C131e) resulting from the change of application(_:didFinishLaunchingWithOptions:)
Testing
Project should build and run successfully under Xcode 6.2 (6C131e).

Thanks @palmassi for pull request.


histogram: calculate lengths using round-to-nearest

It was rounding down.

/cc @mdakin

Merged, thanks!


Update content-item-horizontal.mdx

cap C for Content item horizontal and add design spec file link
Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

@jeffchew Ready for your review so we can merge the update to the live site asap. Thank you.


[ForYou] Implementing offline screen and removing SnakeBar

There are a few changes I've made:

Removed SnakeBar from the NiaApp.
Implemented the offline mode and error based on design spec.
Separated components to make it easier to read on the ForYou screen.

Output:

I'm closing this PR because of the new changes made for the author feature - I will create a new PR for it.


baetyl-455 批量查询节点信息接口

Codecov Report

Merging #69 into master will increase coverage by 0.39%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   75.57%   75.96%   +0.39%
==========================================
  Files          79       79
  Lines        5555     5534      -21
==========================================
+ Hits         4198     4204       +6
+ Misses        934      912      -22
+ Partials      423      418       -5

Impacted Files
Coverage Δ

api/node.go
83.33% <68.42%> (-1.49%)
:arrow_down:

server/router.go
79.31% <100.00%> (+8.50%)
:arrow_up:

service/sync.go
57.25% <0.00%> (ø)

config/config.go
100.00% <0.00%> (ø)

server/node_server.go

server/sync_server.go
0.00% <0.00%> (ø)

common/string.go
100.00% <0.00%> (+15.38%)
:arrow_up:

api/sync.go
88.00% <0.00%> (+49.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e5dcd...6cce18d. Read the comment docs.


feat(branding): add hooks for opensphere to pickup brand from suite

of a suite
Opensphere supports application level branding. This change makes it easier to rebrand if its part of a application suite

I guess a note for anyone who extends opensphere, they'll also have to move their favicon location


Country still not required for Mailchimp and Land Portal Sign up

As I have mentioned, we need to require country for all who sign up to the Land Portal and for Mailchimp as well. This was the case before and it enabled us to track, at least temporarily and partially, the origin of our users. We need this to be re-established asap. I made it a requirement in Mailchimp again, but I don't know if this has a negative interaction with how you have set it up with regard to the Mailchimp integration.
Also, I get notifications often when approving accounts still that there is a problem with the newsletter registration.

also fixed (see other tickets)


python312Packages.python-hcl2: 4.3.5 -> 5.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.python-hcl2 is: A parser for HCL2 written in Python using Lark
meta.homepage for python312Packages.python-hcl2 is: https://github.com/amplify-education/python-hcl2
meta.changelog for python312Packages.python-hcl2 is: https://github.com/amplify-education/python-hcl2/releases/tag/v5.0.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.0.0 with grep in /nix/store/yfwvy61060fn3bxfmbpb8r05bs3knmpv-python3.12-python-hcl2-5.0.0
found 5.0.0 in filename of file in /nix/store/yfwvy61060fn3bxfmbpb8r05bs3knmpv-python3.12-python-hcl2-5.0.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.python-hcl2
python312Packages.python-hcl2
terraform-local

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yfwvy61060fn3bxfmbpb8r05bs3knmpv-python3.12-python-hcl2-5.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.python-hcl2 https://github.com/r-ryantm/nixpkgs/archive/5692ac5118aa013276a38aa844ff9544e89a989f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5692ac5118aa013276a38aa844ff9544e89a989f#python312Packages.python-hcl2

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yfwvy61060fn3bxfmbpb8r05bs3knmpv-python3.12-python-hcl2-5.0.0
ls -la /nix/store/yfwvy61060fn3bxfmbpb8r05bs3knmpv-python3.12-python-hcl2-5.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python311Packages.python-hcl2
python311Packages.python-hcl2.dist
python312Packages.python-hcl2
python312Packages.python-hcl2.dist
terraform-local
terraform-local.dist

Maintainer pings
cc @shivaraj-bh for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 347140 run on aarch64-darwin 1

6 packages built:

python311Packages.python-hcl2
python311Packages.python-hcl2.dist
python312Packages.python-hcl2
python312Packages.python-hcl2.dist
terraform-local
terraform-local.dist


326047 Add capabilities schema and relations

We added capability and capability values schema.
W/ @OrGur1987
main repo PR: https://github.com/ManageIQ/manageiq/pull/22137
schema PR: https://github.com/ManageIQ/manageiq-schema/pull/667

this can be closed, sorry

@OrGur1987 Do you still want https://github.com/ManageIQ/manageiq/pull/22137 to be open?

@OrGur1987 Do you still want ManageIQ/manageiq#22137 to be open?

no, we took Adam's and Jason's approach to adding capabilities as json fields.
thanks

this can be closed, sorry

Ok closing.
Thanks again for all the help on the project


[BUG] Requires Investigation: Bitmap loader on netcore and net462

Describe the bug
When I was sense checking the Bitmap loader for android and increasing the test coverage I think I spotted a gap in the .net core\wpf availability of a platform bitmap loader. This is a reminder as it needs to be checked.
Steps To Reproduce
The unit test for the platform loader was restricted to android, so remove the #if macro. need to assess and discuss.
Expected behavior
Platform bitmap loader works as expected on each platform.

WPF .net core is still in previous and is on the preview/8.0 branch. https://github.com/reactiveui/splat/blob/preview/8.0-dotnet/src/Splat/Platforms/netcoreapp3/Bitmaps/PlatformBitmapLoader.cs is the bitmap loader.

closing. not an issue. thing I spotted it specific to android and the reflection for resources.


Can't find $libdir/duckdb_fdw

Hello,
I am trying to install the extension using this Dockerfile:
FROM postgres

RUN apt-get update && apt-get install -y \
  git \
  build-essential \
  cmake

RUN git clone https://github.com/cwida/duckdb.git \
  && cd duckdb \
  && make

RUN apt-get install -y postgresql-server-dev-13
ENV PATH="/usr/include/postgresql/13/server/:${PATH}"

RUN git clone https://github.com/alitrack/duckdb_fdw.git  \
   && cd duckdb_fdw \
   && cp -R /duckdb/build/release/tools/sqlite3_api_wrapper/* .  \
   && cp -R /duckdb/tools/sqlite3_api_wrapper/include/* .  \
   && make USE_PGXS=1 \
   && make install USE_PGXS=1

RUN cp -R duckdb_fdw/* /usr/share/postgresql/13/extension/
RUN cp -R duckdb_fdw/sql/* /usr/share/postgresql/13/extension/

COPY ./db.sql /docker-entrypoint-initdb.d/

db.sql
CREATE EXTENSION duckdb_fdw;
CREATE SERVER DuckDB_server FOREIGN DATA WRAPPER duckdb_fdw OPTIONS (database '/tmp/test.db');

But then I have this error when I run PostgreSQL:
2021-01-24 15:28:42.387 UTC [47] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2021-01-24 15:28:42.401 UTC [48] LOG:  database system was shut down at 2021-01-24 15:28:41 UTC
2021-01-24 15:28:42.414 UTC [47] LOG:  database system is ready to accept connections
2021-01-24 15:28:43.233 UTC [91] ERROR:  could not access file "$libdir/duckdb_fdw": No such file or directory
2021-01-24 15:28:43.233 UTC [91] STATEMENT:  CREATE EXTENSION duckdb_fdw;

May I know how can I install the extension properly ? Thanks !

After make install, the extension files are not placed into the right directory, nothing seems to happen in fact, I need to manually copy them, but still where is the duckdb_fdw I need to copy to $libdir ?

After make install, the extension files are not placed into the right directory, nothing seems to happen in fact, I need to manually copy them, but still where is the duckdb_fdw I need to copy to $libdir ?


fix(ngx-ssr-timeout): timeout only after HttpSentEvent

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release


Update ModelType.php

Getting error message:
   "message": "Gemini 1.0 Pro Vision has been deprecated on July 12, 2024. Consider switching to different model, for example gemini-1.5-flash.",

Please update model as previous model is depreciated.

This change can cause break changes. I just released a new version, now there is a separate enum for flash. I also marked pro vision usages as deprecated.


[Codegen] Add op for flattening warp and thread ids of forall ops

Normalizing the thread/warp ids of an scf.forall op eases later transformations between loops by decoupling the delinearization of indices from the (common) flat id. Currently this only supports cases with lower bound zero and unit stride with a "descending" mapping.

Transform dialect, so I dont really care, but we should just use the coalesceLoops from upstream for scf.forall as well.

coalesceLoops is more about multiple nested loops collapsing to a single loop, whereas this is collapsing a few ids on a single operation. The DeviceMappingAttributeInterface is super weird also which is why I hard coded for thread/warp and don't know how to do it in general without depending on the GPU dialect, so something to figure out later.


[FEATURE] LUKS-Style Headers

Provide a LUKS-style header, with room for keyslots.
This feature should be optional as it probably requires a fair amount of storage overhead (a few hundred bytes at most, but still noticeable)
A cryptographically secure 32-byte key should be generated.
The user's key is hashed, and that is used for encrypting the "master key".
This will allow for multiple keys to unlock the same file. security = strength of the weakest password
This would also require management functions, such as dexios keyslot add/del <file>

I plan to alter this a bit, and not add support for multiple keys just yet.
I am going to implement LUKS-style headers, but with space for one key just to start. This will probably add 32ish bytes onto the header size, but it will dramatically increase security.
If a header is stripped from a file, it would become exponentially more computationally-expensive to brute force the key. It's already pretty expensive, but implementing this functionality would be a very good change.

This was added, with current support for one key.


[ALLUXIO-2466]add a skip method in HdfsFileInputStream.java

https://alluxio.atlassian.net/browse/ALLUXIO-2466

Thanks @TeddyBear1314 ; Suggest to add an unit test.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12797/
Test PASSed.

ok, I'll do it! Thanks for the comment!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12798/
Test PASSed.

Merged build finished. Test PASSed.

@TeddyBear1314 I left one comment regarding javadoc. After adding a unit test as mentioned by @haoyuan , I will LGTM this PR. thanks for the improvement!

write a simple ut! I think it can be improved! Can anyone give me some advice about how to write a ut for this skip(long n)?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12805/Failed Tests: 1org.alluxio:alluxio-core-client: 1alluxio.hadoop.HdfsFileInputStreamTest.skip
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12806/
Test PASSed.

+1 LGTM
thanks for the improvement!


proxy: parallel merge and dedup

Is your proposal related to a problem?
Sorting series in the querier seems to be done using a single heap-like structure, which means we can only utilize one core for deduplication.
Describe the solution you'd like
It would be nice to be able to use multiple cores when fetching and deduplicating data in order to speed up query execution.
Since the engine does not require series to be sorted, we could dedup using multiple heaps in parallel and iterate through all heaps when expanding series.
The only thing to be careful about is that series which are replicas of each other must end up on the same heap. This can be done by:

first removing replica labels from received series
hashmoding the rest of the labels
putting the series on the heap that corresponds to the value from the hashmod operation

Describe alternatives you've considered
All Thanos stores can now shard series dynamically by or without certain labels. We could therefore make multiple requests to stores, each for one specific shard, where a shard is calculated by hashmoding series without replica labels used in the query.
However, this will put more load on stores, and is not a good strategy when querying Prometheus sidecars.
@GiedriusS let me know if I am missing something obvious here that could be a blocker :)

Maybe you could add a small diagram showing how all of this could work? Hard to understand now just from text :smile:

Hm hard to explain with a diagram, but let me try with code links.
From what I see, we start a gorouting for each store that we query, and that goroutine returns a single respSet.
Could we instead return N respSets, where each respSet contains disjoin series. The way we decide which series ends up in which respSet is by hashmoding series without their replicalabels, so that replicated series always end up in the same respSet. Now we can take these N respSets and build N heaps in parallel.
When expanding series in the engine, they don't need to be sorted. So we can simply iterate through each series in each heap in order through some compound iterator. Does that help?

I'll give this a shot in a few weeks.


V1.0.3

PR Type
enhancement, bug_fix

Description

Refactored background and content scripts for improved modularity and maintainability.
Introduced new classes BackgroundService, StateManager, ContentManager, and UIManager for better code organization.
Enhanced GitHub integration with structured settings and improved error handling.
Added new UI components for notifications and upload status management.
Updated manifest and README to reflect version changes and new features.

Changes walkthrough 📝
Relevant filesEnhancement8 files

BackgroundService.tsModularize background service with enhanced GitHub integration.

src/background/BackgroundService.ts
Introduced BackgroundService class for improved modularity.  Added methods for GitHub service initialization and ZIP handling.  Implemented connection and storage listeners.

+263/-0

StateManager.tsIntroduce StateManager for centralized state management.

src/background/StateManager.ts
Added StateManager class for managing GitHub settings and project IDs.  Implemented singleton pattern for state management.

+27/-0

ContentManager.tsImplement ContentManager for content script management.

src/content/ContentManager.ts
Created ContentManager class for managing content script operations.  Implemented connection handling and UI updates.

+185/-0

UIManager.tsAdd UIManager for UI component and notification handling.

src/content/UIManager.ts
Added UIManager class for handling UI components and notifications.  Implemented upload status and button state management.

+513/-0

Notification.svelteCreate Notification component for alert display.

src/content/Notification.svelte
Created Notification component for displaying alerts.  Implemented fade transition and auto-dismiss functionality.

+107/-0

settings.tsIntroduce SettingsService for GitHub settings management.

src/services/settings.ts
Added SettingsService for managing GitHub settings.  Implemented methods for retrieving and setting project IDs.

+68/-0

zipHandler.tsRefactor ZIP file processing with ZipHandler.

src/services/zipHandler.ts
Refactored ZIP file processing with ZipHandler class.  Improved status updates and error handling.

+189/-151

types.tsEnhance type definitions for message and status handling.

src/lib/types.ts
Added new types for message handling and upload status.  Updated existing interfaces for better type safety.

+43/-1

Configuration changes1 files

manifest.jsonUpdate manifest for new version and script paths.

manifest.json
Updated version to 1.0.3.  Changed service worker and content script paths.

+4/-3

Documentation1 files

README.mdUpdate README with latest version and features.

README.md
Updated version information to 1.0.3.  Added new features and project management details.

+18/-2

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

@CodiumAI-Agent /update_changelog

Changelog updates: 🔄
2024-12-02
Added

Introduced modular classes (BackgroundService, StateManager, ContentManager, UIManager) for improved code organization.
Added new UI components for upload status and notifications.
Enhanced GitHub integration with structured settings and improved error handling.
Introduced a "Projects" tab for managing Bolt projects and GitHub repositories.

Changed

Refactored background and content scripts for better modularity and maintainability.
Updated manifest and README to reflect version 1.0.3 changes.

Fixed

Resolved issues with upload status container initialization to ensure proper handling when the document body is not ready.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Changelog updates: 🔄
2024-12-02
Added

New GitHub integration features, including branch validation and commit count retrieval.
Improved project management with a dedicated Projects tab for viewing and managing Bolt projects and GitHub repositories.

Changed

Enhanced UI components with better notifications and upload status handling.
Updated GitHub settings validation and error handling for a more robust user experience.

Fixed

Addressed issues with GitHub upload reliability and ensured proper handling of large ZIP files.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'


Can cppflow2 directly call pb files?

Hello, dear developer，I'm learning cppflow2 recently and want to ask a question.
In the example of cppflow2, cppflow2 can directly load the model saved with the (.save) function in the python script.
Can I directly use cppflow2 to rebuild the  "mnist" example in cppflow1?Is there a way for cppflow2 to directly call the pb file in this example？

#152 may be the way you're looking.

Thank you, this looks like the way I am looking for.
After reading the link you gave, I found an example (load_frozen_graph--it can directly call the .pb file) in this link.
But when I ran this example on my computer, an error occurred.The error message is as follows:
SavedModel load for tags { serve }; Status: fail: Not found: Could not find SavedModel .pb or .pbtxt at supplied export directory path: ../model.pb. Took 12592 microseconds.
terminate called after throwing an instance of 'std::runtime_error'
  what():  Could not find SavedModel .pb or .pbtxt at supplied export directory path: ../model.pb

I have tried many ways to solve this error(for example, put the pb file into the "model" folder and load it, but it will not run)
If anyone has run this example successfully, please tell me.
In order to better use cppflow, should I use python to learn tensorflow first?Because there are many function interfaces in cppflow, I don't know what they mean, and I don't know how to call them.

I guess cppflow1 is better if you want to load pb files. Commit c38997cbc2fdde9e77002c302d891cbd30ceab87 is the last cppflow1.

Thank you, this looks like the way I am looking for. After reading the link you gave, I found an example (load_frozen_graph--it can directly call the .pb file) in this link. But when I ran this example on my computer, an error occurred.The error message is as follows:
SavedModel load for tags { serve }; Status: fail: Not found: Could not find SavedModel .pb or .pbtxt at supplied export directory path: ../model.pb. Took 12592 microseconds.
terminate called after throwing an instance of 'std::runtime_error'
  what():  Could not find SavedModel .pb or .pbtxt at supplied export directory path: ../model.pb

Its a problem of example code. You need to instantiate model class with
    cppflow::model model("../model.pb", cppflow::model::FROZEN_GRAPH);

, not
    cppflow::model model("../model.pb", {});

I guess cppflow1 is better if you want to load pb files. Commit c38997c is the last cppflow1.
Ok,thanks.
But I think cppflow2 is more convenient to use, so I want to consult how to call pb files on cppflow2.

Its a problem of example code. You need to instantiate model class with
    cppflow::model model("../model.pb", cppflow::model::FROZEN_GRAPH);

, not
    cppflow::model model("../model.pb", {});

Yes, this example will work when I modify it as you suggested.
Does cppflow2 only have a few examples?In addition to this website, where can I get learning materials for cppflow2？Because I don’t know what function interfaces exist in cppflow2 and what they can do.

Does cppflow2 only have a few examples?In addition to this website, where can I get learning materials for cppflow2？Because I don’t know what function interfaces exist in cppflow2 and what they can do.

It's the only documentation for this cppflow. In general, TensorFlow is less documented other than Python and JavaScript, and other language wrappers are out of the TensorFlow's itselse.
See: https://www.tensorflow.org/api_docs
Since this cppflow is the one of wrappers, so I recommend using limited functions like constructing Tensor and model inferences. If you are familiar with TensorFlow, you could use low level ops through raw_ops.

Yes, this feature is now in the code thanks to #152.


Use HTTPS to reduce man-in-the-middle attack vector

The URL also works as "https://www.mls-software.com/files/setupssh-7.1p1-1.exe" so this would reduce potential for man-in-the-middle attacks compromising the build.

I am kind of shocked to see that this is even a thing thoughout multiple points of the scripts. This is a high security risk. Searching for 'http:' shows some more results:
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/compact.bat#L2
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/compact.bat#L7
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/puppet-enterprise.bat#L2
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/puppet.bat#L2
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/rsync.bat#L3
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/rsync.bat#L8
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/vm-guest-tools.bat#L2
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/vm-guest-tools.bat#L18
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/chef.bat#L2
https://github.com/joefitzgerald/packer-windows/blob/c4a111f4f95d311f37ec0f2ae545ffa5407597cb/scripts/openssh.ps1#L9
This is not good!


created assignment_3

Assignment 3 README.md file and evaluation script completed.

@prassr I have added my comments. Please check


Add namespace to RespondActivityTask* requests

This is how client will pass the namespace it is configured for as part of those requests. Will help us detect mismatches between that namespace and one in the token.

also include RecordActivityTaskHeartbeatRequest


kfctl set-image-name command appends inventory:omitempty: null into all the kustomization.yaml files

kfctl set-image-name command appends "inventory:omitempty: null" into all the kustomization.yaml files in the manifests dir
Command to reproduce the issue:
kfctl set-image-name test-repo.io
with this "inventory:omitempty: null" key-value pair in the yaml file, kfctl apply fails.
Workaround by deleting the added line.
re := regexp.MustCompile("(?m)[\r\n]+^.omitempty.$")
res := re.ReplaceAllString(string(data), "")
........
........
                                    if _, err := file.Write([]byte(res)); err != nil {
					return err
				}

Thanks @xaniasd
We are using set-image-name command in our on-prem installation.
Are you planning to fix this in 1.0?

@xaniasd Do you want to submit a cherry-pick to the 1.0 branch so it will be included in a future RC?

sure thing!


Can not curl exported service

I am trying to deploy Submariner on 2 kubeadm clusters (same network)... the problem I see is that I have installed exactly the same as in the instructions but my cluster1 cannot resolve the svc of cluster2. Here is how I deployed 2 clusters
cluster1
pod-cidr: <IP_ADDRESS>/16
service-cidr: <IP_ADDRESS>/16
// Calico CNI:
kubectl create -f - <<EOF
kind: Installation
apiVersion: operator.tigera.io/v1
metadata:
name: default
spec:
registry: quay.io/
cni:
type: Calico
calicoNetwork:
bgp: Disabled
ipPools:
- cidr: <IP_ADDRESS>/16
encapsulation: VXLAN
apiVersion: operator.tigera.io/v1
kind: APIServer
metadata:
name: default
spec: {}
EOF
kubectl create -f - <<EOF
apiVersion: projectcalico.org/v3
kind: IPPool
metadata:
name: svc-c2
spec:
cidr: <IP_ADDRESS>/16
natOutgoing: false
disabled: true
apiVersion: projectcalico.org/v3
kind: IPPool
metadata:
name: pod-c2
spec:
cidr: <IP_ADDRESS>/16
natOutgoing: false
disabled: true
EOF
// deploy broker on cluster1
curl -Ls https://get.submariner.io | bash
export PATH=$PATH:~/.local/bin
echo export PATH=$PATH:~/.local/bin >> ~/.profile

cluster2:
pod-cidr: <IP_ADDRESS>/16
service-cidr: <IP_ADDRESS>/16
//Calico CNI:
kubectl create -f - <<EOF
kind: Installation
apiVersion: operator.tigera.io/v1
metadata:
name: default
spec:
registry: quay.io/
cni:
type: Calico
calicoNetwork:
bgp: Disabled
ipPools:
- cidr: <IP_ADDRESS>/16
encapsulation: VXLAN
apiVersion: operator.tigera.io/v1
kind: APIServer
metadata:
name: default
spec: {}
EOF
kubectl create -f - <<EOF
apiVersion: projectcalico.org/v3
kind: IPPool
metadata:
name: svc-c1
spec:
cidr: <IP_ADDRESS>/16
natOutgoing: false
disabled: true
apiVersion: projectcalico.org/v3
kind: IPPool
metadata:
name: pod-c1
spec:
cidr: <IP_ADDRESS>/16
natOutgoing: false
disabled: true
EOF
// Deploy broker
subctl deploy-broker --kubeconfig ./config-cluster1
// Join cluster1 and cluster2 to the Broker
subctl join --kubeconfig ~/.kube/config-cluster1 broker-info.subm --clusterid cluster1 --natt=false
subctl join --kubeconfig ~/.kube/config-cluster2 broker-info.subm --clusterid cluster2 --natt=false
What you expected to happen:
I have deployed and tested on KinD, after joining 2 clusters, when checking connections, it will look like this:

But currently I check and only display only one as follows:

I tried again many times and the results were the same
Environment:

AWS EC2 instance (same VPC)
Kubeadm
Submariner
Calico CNI

cluster1:

cluster2:

Check that service is actually imported in each cluster with:
kubectl -n default get serviceimport

Please check the installation following the User Guide
BTW, Use tool command subctl gather to provide logs and other information, instead of screen snapshots

As far as I can see only cluster1 is collected

A.
cluster1

cluster2

B.

@yboaron A. output of submariner components logs

@yboaron  A. output of  submariner components logs,
submariner-20240221080342.zip
submariner-20240221080414.zip

why this ticket closed?

Please share the output of $subctl verify --context < context1 > --tocontext < context2 > --only connectivity command
and the content of Calico IPPools resources from both pools

@yboaron   the output of $subctl verify --context < context1 > --tocontext < context2 > --only connectivity command

Calico IPPools:
cluster1:

cluster2:

The logs in the Submariner Operator:

@yboaron I used Globalnet, it works well...

yes, I understand that I don't need to use Globalnet when I have deployed non-overlap CIDR.
I will redeploy and share you @yboaron


Analyze move from Create-react-app to Vite

Objective
Check technical feasibility for technology change from create-react-app to vite, and in a positive case, do the required work.

Description
After some months without any activity and started working on tickets related to dependency updates and vulnerability patches, I looked for ways to work with tools that could help my future work to be done in less time and with fewer possible problems.
Here comes Vite, that despite existing other tools/frameworks like NextJs (which I want to learn in the future) or Remix among others, I want to give it a try to Vite and have an opinion based on research and decide if migrate is for the best.

Tasks

[x] Check on Vite's page for features, instalation process and other useful documentation.
[x] Look for articles, documentation or other kind of bibliography to find the good, the bad and ugly parts of a possible migration to Vita from create-react-app.
[x] Create new Vite-flavored project
[x] Migrate Storybook configuration to coexists with Vite
[x] Migrate package dependencies and configurations
[x] Migrate components (with its structure and tests)
[x] Make tests work using Vitest
[x] Check all functionality works as before
[x] Change deployment configs before merge to avoid possible deployment errors

Ticket relationships

Relationship
Involved tickets

Is child of
none

In parent of
none

Is related to
none

Is blocked by
none

It blocks
none

Technical notes
Used documentation so far:

[Article] - Migrating from create-react-app to vite
[Article] - Create react app to Vite

I add the main link where I looked for knowledge in my work to migrate from CRA to Vite:

Getting started with Vite
Configuring Vitest
How to use Context on React instead Redux


How to activate a page?

I want to open a page (https://www.nseindia.com/all-reports), click a link [bhavcopy file (csv)] and download the file.
Attaching the Jupytr notebook for your reference
The downloadNseEodPrice function fails to download the file unless I navigate to the Chrome opened by RPA and click on the page.
Surprisingly the call to input is successful though the hello text is not visible on the browser
I am sure I am making some silly mistake.  Can you pls help?
nseDownload.txt

Hi @rmrao-peruri is this still an issue? Could you try copying all the Jupyter notebook code into a .py file and see if it happens? Do also paste the code here and let me try to replicate if it also happens on my computer.
Sounds like it might be the webpage has some logic that only allows download to happen if a user is really focusing on the browser and not through automation. We'll see.. In any case, there are alternative methods like using visual automation which can simulate a real user's actions and should be able to get around that.

For example, something like r.click('chrome_icon.png') can be used to click on the Chrome icon to bring it to foreground.


Adds fabric worker mgmt

@ mention of reviewers
@jimmykodes
A brief description of the purpose of the changes contained in this PR.
Resolves #340 adding a script to maintain compute workers
A checklist for hand testing

[x] prereq: pip install fab-classic outside of docker, uses your SSH key on host machine
[x] create server_config.yaml and add the gpus to it (I'll just send you this), run fab -R autodl-gpu status
[ ] update some workers with fab -R autodl-gpu update (may be overkill, can wait until we have relevant changes)

Checklist

[x] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[x] Code review by reviewer
[x] Hand tested by reviewer
[x] Ready to merge

:shipit:


[migration] runner migration for k8s_e2e_template and trigger_release jobs to k8s

What does this PR do?
migrate k8s_e2e_template and k8s_e2e_template stages to k8s runners

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Yeah make sense, will do once the pipeline finishes 👍

Hi @Pythyu
quick question: why this PR is still not merged?

I'm going to merge it today, just struggling to start the k8s-e2e-dev job correctly


getOrderBook related changes

update selector to process new structure of open orders
update tests to reflect this change

Coverage increased (+0.01%) to 76.731% when pulling 8722362efde4793f6850362fc9d7f5067aa58f7e on getOrderBook into 043003cccea71b6a346fffd62cde19f2a89beb24 on master.


:test_tube: add tests for schengen calculator

add base tests for schengen calculator
add test for summary
add test for calculating summary for 1 future trip
add test for calculating summary for multiple future trips

#33  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szamanr and the rest of your teammates on  Graphite


Flash messages

For:

failed logins
broken connection to backend

Basic implementation working but needs to fade away. Support for different colours would be good too.


After mdbook version 0.4.41, the rendering doesn't work as expected.

After version 0.4.41 of mdbook, it seems that the rendering isn't working as expected.
I checked the update logs, and it looks like the index.hbs file needs updating. Could you please update it?
I confirmed that it was working fine with version 0.4.40.

Thank you for fixing this issue. 😊


sentinl 5.2.2 & Kibana 5.2.2 : initialization fails

Hi,
I installed sentinl 5.2.2 on Kibana 5.2.2 successfully.
Then, when I start Kibana, I see the following log every 30s :
log   [14:28:55.609] [info][status][Sentinl] No indices found, Initializing
And when I go to "Kibana Console", I see that no one sentinl index is created.
=> It seems that sentinl initialization fails on Kibana 5.2.2.

Thanks for the report. I believe this is related to changes in the client usage, but might already be fixed in our upstream private, assigned to @SergeyBondarenko to confirm

At Kibana startup, I see well the following logs :
 log   [14:56:55.575] [info][status][Sentinl] Core Index check...
 log   [14:56:55.578] [info][status][Sentinl] Alarm Index check...
But never Creating Sentinl core Index... (log defined in helpers.js:59)
As if 'indices.exists' function was never called...

@lmangani @SergeyBondarenko
I just sent a PR that fix the problem.
It also fix sentinl alarm index check.

@fbaligand thanks!
@SergeyBondarenko can you validate and merge to our private?

@lmangani this bug is resolved already. The fix is in the master branch, in https://github.com/sirensolutions/sentinl-private repo. Today, I'm going to sync the branches and produce 5.3.2 release.

Try the master branch.

Hi,
If you speak about master branch from public repository, I already tested with the very last version (no commit since then) and I reproduced the issue. Then I fixed the issue and pushed the PR.
If you speak about private repository, I have no access to it.

Sorry @SergeyBondarenko
I realized you made commits after my last git pull.
I just tested with the last version and it works great !
Thanks a lot for the fix !

@SergeyBondarenko
Do you plan also to make a new 5.2.2 release ?

@fbaligand yes, I do. But there are problems installing via kibana-plugin script. Both in Kibi 5.3.2 and Kibana 5.2.3.
^[[C[trex@Latitude-E5510 kibi-internal5_3_2]$ ./bin/kibi-plugin install https://github.com/sirensolutions/sentinl-private/releasesnload/tag-5.2.2/sentinl-5.3.2.zip
Attempting to transfer from https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.3.2.zip
Attempting to transfer from https://artifacts.elastic.co/downloads/kibana-plugins/https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.3.2.zip/https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.3.2.zip-5.3.2.zip
Plugin installation was unsuccessful due to error "No valid url specified."

[trex@Latitude-E5510 kibana]$ ./bin/kibana-plugin install https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.2.3.zip
Attempting to transfer from https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.2.3.zip
Attempting to transfer from https://artifacts.elastic.co/downloads/kibana-plugins/https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.2.3.zip/https://github.com/sirensolutions/sentinl-private/releases/download/tag-5.2.2/sentinl-5.2.3.zip-5.2.3.zip
Plugin installation was unsuccessful due to error "No valid url specified."

Then, it's weird, because in your url, your tag is "tag-5.2.2" and your archive name is "sentinl-5.2.3"

I don't see this archive here :
https://github.com/sirensolutions/sentinl/releases/tag/tag-5.2.2
Do you mean the tag on private repository ?

@fbaligand it was done in private, for tests

Ok. I have no access to private repository.
Have you tried to install the plugin using a file URL ?
I mean : file:///path/to/sentinl.zip

@fbaligand please try the latest release https://github.com/sirensolutions/sentinl/releases/tag/tag-5.3.2, the command is
./bin/kibana-plugin install https://github.com/sirensolutions/sentinl/releases/download/tag-5.3.2/sentinl.zip

What needs to be done to get sentinl to work with ELK V5.4?
./bin/kibana-plugin install https://github.com/sirensolutions/sentinl/releases/download/tag-5.3.2/sentinl.zip
Attempting to transfer from https://github.com/sirensolutions/sentinl/releases/download/tag-5.3.2/sentinl.zip
Transferring 5711270 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete
Plugin installation was unsuccessful due to error "Incorrect Kibana version in plugin [sentinl]. Expected [5.4.0]; found [5.3.2]"

Hi @jeffforbes
Not tried 5.4.0 yet, but if you feel brave you can try clone the 5.3.2 repo, change the version parameters to 5.4.0 and build a custom SENTINL archive to test with. In reality, this probably needs further adjustments but any input is welcome. If you give that a shot please let us know the outcome here.

@SergeyBondarenko
I will test v5.3.2.
But it would be great to release again v5.2.2. The current issue is really a blocking bug.
if v5.2.2 does not contain the fix, it is not usable.
Today, I made a full sentinl test with kibana 5.2.2 and the following commit :
https://github.com/sirensolutions/sentinl/commit/4160a426c1f2222b4a037f0c5aeac73c585d9e2a
=> It would be great to create a new release 5.2.2-1 using this commit or to move 5.2.2 release to this commit.

I tried v5.3.2.
Concerning this issue, it works great !
Sentinl index creation works now like a charm.
However, I found another annoying issue (using v5.2.2 and v5.3.2).
=> I open a new issue for that : #128

It was fixed check new releases https://github.com/sirensolutions/sentinl/releases

I tried the fix in v5.2.2-1 and it works great !

looks like this is still happening in<EMAIL_ADDRESS>

@djtecha could you attach the relevant log/error messages?

Is there any other log I should look for? that's the only thing that pops up for me. it's the kibana.log

out of curiosity, is there a way to pass the username and password in the sentinl plugin? Looks like it's not passing a user for me.
[2017-05-31T16:04:51,708][INFO ][c.f.s.c.PrivilegesEvaluator] No permissions for {}

@djetcha
It seems you have a very different issue from this one : an security/authentication problem between sentinl and searchguard.
=> I invite you to open a new issue for that.

Same issue here, Its frustrating Please help !! i am using readonly rest similar to searchguard for authentication

This issue was open for an initialization error with no security. And it is closed.
Because you have a security plugin, it is another issue.
So, I invite you either to open another issue or to give more details about your issue (logs, error message, ...) in this issue : https://github.com/sirensolutions/sentinl/issues/137

@fbaligand Already done check : https://github.com/sirensolutions/sentinl/issues/145


Revert "build(deps-dev): bump phpstan/phpstan from 1.6.8 to 1.7.14 in /composer/helpers/v2"

Reverts dependabot/dependabot-core#5266
May have broken CI

I think the failing test is requesting a malformed URL? Looks like it has an : tacked on at the end.
https://github.com/dependabot/dependabot-core/runs/6920582472?check_suite_focus=true#step:9:304
Not sure what changed in the phpstan to cause that one


Remove obsolete features from grid environment

Pull request information

Status: Ready to merge
Kind of changes: Cleaning
Code affected: environments (grid only)

Description

Removed obsolete features from the grid. The function record_obs_var() is not called anywhere, and the function sort_by_intersection_dist() is only called by its tester.

This is related to Flow 0.4.0 release

Pull Request Test Coverage Report for Build 3466

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 89.384%

Totals

Change from base Build 3462:
0.07%

Covered Lines:
8024

Relevant Lines:
8977

💛  - Coveralls


Incorrect result when rolling up Activity Date from an Event

I have set up the Activity Object so that it is related to the Campaign object.
I want to calculate the min and max dates of activities associated with the Campaign.  This works GREAT except when the Activity is a All Day Event.  Somehow, if it is an All Day Event the min and max computed are 1 day less than the actual dates.
Any ideas?

Need to try and reproduce this.

Can you help me reproduce this with a screenshot of your rollup please?

Hi Andrew,
Thanks for following up on this.
I think it's a SF issue and not a problem with the roll up.
Basically, the problem occurs when I try to rollup the min Event date when
the event is an All Day event.  It doesn't happen when the event is not an
All Day event.  I think the problem has something to do with SF storing
events at GMT and the nature of All-Day events.  e.g. If a user sets up an
All Day Event in San Francisco, how should it look to the user in Cairo?
I think that for some reason, the rollup uses the GMT date/time for the all
day event and not the locale time.  (Probably because that's all SF lets
the rollup use).  When I add  an offset for the GMT time, I get the correct
results.
Would you still like to see this in action?
With Thanks.
Susan
On Thu, Apr 30, 2015 at 12:23 AM, Andrew Fawcett<EMAIL_ADDRESS>wrote:

Can you help me reproduce this with a screenshot of your rollup please?
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/136#issuecomment-97590242
.

Yep i think thats a reasonable explanation, and yes the code gets GMT date/time info from the system. Are you saying you have a workaround or do you still want to see if we can come up with a code fix here?

Closing this for now, let me know if you still need help and we can re-open.


Release on GitHub

Making sure things are a-OK in GitHub:

[x] Make a release on GitHub

Removed the three other tasks which are more oriented on community. Let's put it out first :')


Feature/upgrade to dpy 2.0

Transitioning to discord.py 2.0 and other improvements. Trying to avoid stylistic changes where possible.

Looks good. I will merge once I am done testing it on the Canary bot.
Great work.


⚠ Bofrost.fr has degraded performance

In 38272f7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1292 ms

Resolved: Bofrost.fr performance has improved in 3c56b74 after 6 minutes.


docs(stablecoin): [EPIC] messages, events, keepers, params, buybacks

[ ] docs: Messages and Events
[ ] docs: Keepers and Parameters
[ ] docs: Buybacks

No longer relevant


Use https://wave.webaim.org/help to improve accessibility

https://wave.webaim.org/report#/coderefinery.org

This is now "done". I went through all pages. We will have to revisit this every now and then.


Colorize keys in YamlView

If we can colorize the keys in the YamlView yaml string prop, dense yaml would be a lot easier to parse through.
AC:

Is it possible?
keys become primary10

@joshri is looks like the enterprise YAML component already has this capability.


Error evaluating injectedJavaScript

Hi,
It seems that I have this error only on a ios simulator. It works on real devices (both Android and ios). Tested with Expo version: "33.0.0" and WebView (react-native-webview) version > 5.0.0.
The only thing I've noticed is that the error message appears with a little delay after the building of the bundle is finished. It works fine when I import the WebView from react-native but crashes with the react-native-webview library. Do you have any ideas?

@sonytooo The injected script is here: src/HTMLTable/script.ts. Indeed, there is no return type used.
Can you provide a minimal reproduction? Are you using WKWebView or UIWebView?

@sonytooo I see two related issues from react-native-webview:

react-native-community/react-native-webview#502
react-native-community/react-native-webview#341

They suggest executing code in a closure. I'll add a patch, and you'll be able to test and tell me if the error remains.

@sonytooo please try npm install<EMAIL_ADDRESS>and tell me if the bug persists.

@sonytooo any news?

After upgrading to 0.4.0-rc.1 the issue seems to persist.
`
Error evaluating injectedJavaScript: This is possibly due to an unsupported return type. Try adding true to the end of your injectedJavaScript string.
__45-[ABI33_0_0RNCWKWebView evaluateJS:thenCall:]_block_invoke
ABI33_0_0RNCWKWebView.m:767
WTF::Function<void (API::SerializedScriptValue*, bool, WebCore::ExceptionDetails const&, WebKit::CallbackBase::Error)>::CallableWrapper<-[WKWebView _evaluateJavaScript:forceUserGesture:completionHandler:]::$_0>::call(API::SerializedScriptValue*, bool, WebCore::ExceptionDetails const&, WebKit::CallbackBase::Error)
WebKit::GenericCallback<API::SerializedScriptValue*, bool, WebCore::ExceptionDetails const&>::performCallbackWithReturnValue(API::SerializedScriptValue*, bool, WebCore::ExceptionDetails const&)
WebKit::WebPageProxy::scriptValueCallback(IPC::DataReference const&, bool, WebCore::ExceptionDetails const&, WebKit::CallbackID)
WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_deleteIPC::Decoder >)
IPC::Connection::dispatchIncomingMessages()
WTF::RunLoop::performWork()
WTF::RunLoop::performWork(void*)
CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION
__CFRunLoopDoSources0
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start
`
I tried clearing my packager cache and I am using the Minimal working example

@jsamr thank you for a fix in v0.4.0-rc.1! I confirm, problem is resolved on our end with this version! :)
PS: @sonytooo says thanks too! Sorry that he couldn't reply to you earlier.

@jsamr thank you for a fix in v0.4.0-rc.1! I confirm, problem is resolved on our end with this version! :)
PS: My colleague @sonytooo says thanks too! Sorry that he couldn't reply to you earlier.

Could you tell me your other dependencies versions?
I am still experiencing the issue on:
expo: "^33.0.0"
react-native-render-html": "^4.1.2"
react-native-render-html-table-bridge": "^0.4.0-rc.2"
react-native-snap-carousel": "^3.6.0"
react-native-webview": "^5.8.1"

@jsamr thank you for a fix in v0.4.0-rc.1! I confirm, problem is resolved on our end with this version! :)
PS: My colleague @sonytooo says thanks too! Sorry that he couldn't reply to you earlier.

Could you tell me your other dependencies versions?
I am still experiencing the issue on:
expo: "^33.0.0"
react-native-render-html": "^4.1.2"
react-native-render-html-table-bridge": "^0.4.0-rc.2"
react-native-snap-carousel": "^3.6.0"
react-native-webview": "^5.8.1"

Same for everything, except we don'h have react-native-snap-carousel and we are using react-native-webview at v5.12.1. Try to update it maybe?
One more thing is that we're using fixed versions of these libs. Maybe this helps:
"expo": "33.0.0",
"react-native-render-html": "4.1.2",
"react-native-render-html-table-bridge": "0.4.0-rc.1",
"react-native-webview": "5.12.1",

Unfortunately I am still getting the same error, even after using the exact same dependencies.
This ist my components displaying the html:
import React, {PureComponent} from 'react';
import { View, Text } from 'react-native';
import HTML from 'react-native-render-html';
import { IGNORED_TAGS, alterNode, makeTableRenderer } from 'react-native-render-html-table-bridge';
import WebView from 'react-native-webview';
import styles from '../constants/Styles';
import Colors from '../constants/Colors';

const config = {
    WebViewComponent: WebView
};

const renderers = {
  table: makeTableRenderer(config)
};

const htmlConfig = {
  alterNode,
  renderers,
  ignoredTags: IGNORED_TAGS,
  tagsStyles: styles.htmlStyles,
  listsPrefixesRenderers: {
    ol: (htmlAttribs, children, convertedCSSStyles, passProps) => {
      return (
        <Text allowFontScaling={passProps.allowFontScaling} style={{
          marginRight: 5,
          marginTop: 1,
          fontSize: 14,
          color: Colors.app.text
        }}>{ passProps.index + 1 })</Text>
      )
    },
    ul: (htmlAttribs, children, convertedCSSStyles, passProps) => {
      return (
        <View style={{
          marginRight: 10,
          width: 14 / 2.8,
          height: 14 / 2.8,
          marginTop: 14 / 2 + 1,
          borderRadius: 14 / 2.8,
          backgroundColor: Colors.app.text
        }} />
      );
    }
  }
};

export default class Html extends PureComponent {
  render() {
    const { html } = this.props;
    console.log(html);
    return (

    )
  }
}

And this is the html I am trying to render:

Option
Description

data
path to data files to supply the data that will be passed into templates.

engine
engine to be used for processing templates. Handlebars is the default.

ext
extension to be used for dest files.

Is there any more Information I can provide for debugging?

@janrop @superKalo Perhaps the bug is orthogonal from the dependency tree, and instead related to the iOS version of the terminal you tested. Could you please provide a list of terminals you tested, and the output of those tests?

How do describe a terminal? After your comment I tried running it on devices and it seems to work there. Only the Simulator still shows the error message.

@janrop That's a confusion of words of my own! In french « terminal » stands for « device »; I just mixed the two languages ^^


verify the number of tests run by IonHashTests matches expectations

In particular, since each test is defined as a property of a suite object, if two distinct Ion test values from ion_hash_tests.ion result in the same test name, the last one wins by overwriting an earlier test (of the same name).  We should verify that this is not occurring and thereby confirm that we have the test coverage we think we have.

The ion_hash_tests.ion file defines 166 identity expectations and 5 md5 expectations, and all the digesters defined in IonHashTests.ts (BinaryReader, BinaryWriter, ReaderSkip, TextReader, TextWriter) are performing 157 identity assertions and 5 md5 assertions.  The 9 missing identity assertions are:

redundant/duplicate tests:
null.null  // redundant with null
 1234.5 // duplicate test
2017-01-01T00:00:00+00:00  // redundant with 2017-01-01T00:00:00Z
skipped tests:
$0
{$0:1}
$0::{}
-0 issues:
-0
0d-0
-0d-0

There's nothing particularly unexpected here, which is encouraging.  Removing from M2, but keeping open as there's some cleanup to be done at some point (specifically $0 support and addressing the edge cases around -0).


Reason for stdin(stdio::null)?

I have a command-line app that I wishes to use PGO and BOLT. It takes a few inputs from stdin at the startup. It works well with cargo run.
cargo pgo seems to be overriding stdin by passing stdio::null().
Is it necessary for cargo pgo functionalities? cargo pgo run obviously works differently than cargo run due to this.

Hi, good point. I think that I did this only out of habit, but for cargo pgo run it doesn't make sense. Can you please try if this PR fixes your problem?
$ cargo install --git https://github.com/kobzol/cargo-pgo --branch pass-stdin

No problem! I'm glad that it helped. I will release a new version with the patch soon if there won't be any other changes in the meantime.

Published 0.2.4 with this change.


Fix Accordion restful routes in ems_infra

Most restful routes in ems_infra were addressed when ems_infra was converted to have restful routes for new, edit and show https://github.com/ManageIQ/manageiq/pull/7808
However, there were a few areas that were not addressed like the Relationships and Timelines routes in the Accordions.
This PR addresses those areas.
https://bugzilla.redhat.com/show_bug.cgi?id=1329578
Fixes https://github.com/ManageIQ/manageiq/issues/8201

@miq-bot add_label darga/yes

@AparnaKarve Does #8141 fight with this PR?

This PR also addresses https://bugzilla.redhat.com/show_bug.cgi?id=1330230


Tracking Issue for SSH related problems

List of related issues

http(s) to ssh rewrite:

#874

protected ssh keys:

#817

default ssh key assumption:

#384

tests for ssh repo

#383

All fixed issues will be released with v0.22.0


changed to prod

The end point for IBM Cloud needs to point to the production version.

Changes implemented


d handling of right-side argument

Currently we use the same interpretation as AnyDice, where 1d(1d10) is the same as 1d10. However, other interpretations of the d operator exist:

Foundry VTT interprets this as rolling a die that has between 1 and 10 faces, i.e. 1 is the most likely result and 10 is the least likely.
Roll20 parentheses don't seem to interact with their d operator. However, using the "inlining" double brackets has the same effect as Foundry VTT, e.g. [[ 1d[[1d10]] ]]
AFAICT Fantasy Grounds parentheses don't work with their d operator. Extensions can do anything but I didn't see any consensus in a brief look.

I decided to:

[x] Make the free function d() an alias for standard().
[x] Remove the die method version of d().
[x] Allow @ to cast the right side to a Die.

This seems more consistent in the Python context, even if it doesn't match AnyDice.
TODO:

[ ] Allow random number of faces to standard().


Release 1.0.5

Purpose

Release 1.0.5

Codecov Report

Merging #20154 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #20154   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6227e...a64db42. Read the comment docs.


How does force sv cheat works

https://github.com/danielkrupinski/Osiris/blob/084848b54fb6a93badc055e70995befa88631cef/Osiris/Hooks.cpp#L636

I tried making the value 1 it didnt work.
Im trying to do onetap force svcheat thing.

https://github.com/danielkrupinski/Osiris/blob/084848b54fb6a93badc055e70995befa88631cef/Osiris/Hooks.cpp#L636

I tried making the value 1 it didnt work.
Im trying to do onetap force svcheat thing.

It doesn't work like that, svCheatsGetBool function returns true whenever you want to force sv_cheat 1, for example when you want to set third person view.
anyway, why do you want to force sv_cheats? what is the onetap thing?

when you join like pivate server or your friends host you can get godmode, noclip

when you join like pivate server or your friends host you can get godmode, noclip

if the server owner enables sv_cheats, there is no need to spoof that with cheats on your side.
all you have to do is open your console and type any command.
spoofing sv_cheats won't give you god mode or noclip.


Examine icons for objects in your hand are rotated

https://user-images.githubusercontent.com/19853115/118354307-5afbd800-b51f-11eb-92e1-5ec3b6409377.mp4
Additional context
???????????????????

If it uses SpriteView you can look at https://github.com/space-wizards/space-station-14/pull/3764 for reference on how to fix.


How to upload binary data files?

Hello there,
I considered posting this to Gitter, but it does not seem very active so I wanted to post here instead.
I'm evaluating using uplink for our API clients, and so far it looks like a wonderful tool, checking all of the boxes I'd expect. However, we have a few routes that accept binary data (think simple document store), and I don't see a way to upload unstructured binary data using uplink. Here's what I tried:
from uplink import Consumer, Body, post

class SampleApi(Consumer):
    @post("post")
    def create(self, body: Body):
        """Post some data to httpbin's /post method"""

Then I start httpbin locally with docker run --rm -p 80:80 kennethreitz/httpbin, and fire up an interpreter and tried a few things (which you'll see below). I've combed the docs and cannot find any examples of arbitrary data being uploaded, and when I search binary, bytes, file, or bytearray in this project I didn't see much. I'd like to know how to do this, and I'm thinking it should probably be added to the project's documentation as well.
>>> api = Sample(base_url="http://localhost")
>>> api.create(body=b'1234')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/builder.py", line 99, in __call__
    self._request_definition.define_request(request_builder, args, kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/commands.py", line 267, in define_request
    self._argument_handler.handle_call(
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 153, in handle_call
    self.handle_call_args(request_builder, call_args)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 158, in handle_call_args
    annotation.modify_request(request_builder, call_args[name])
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 182, in modify_request
    self._modify_request(request_builder, converter(value))
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/interfaces.py", line 6, in __call__
    return self.convert(*args, **kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 19, in convert
    return self._converter(value)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/interfaces.py", line 6, in __call__
    return self.convert(*args, **kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 30, in convert
    dumped = json.dumps(value, default=self._default_json_dumper)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/__init__.py", line 234, in dumps
    return cls(
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 25, in _default_json_dumper
    return obj.__dict__  # pragma: no cover
AttributeError: 'bytes' object has no attribute '__dict__'

>>> api.create(body=bytearray([1, 2, 3]))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/builder.py", line 99, in __call__
    self._request_definition.define_request(request_builder, args, kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/commands.py", line 267, in define_request
    self._argument_handler.handle_call(
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 153, in handle_call
    self.handle_call_args(request_builder, call_args)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 158, in handle_call_args
    annotation.modify_request(request_builder, call_args[name])
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/arguments.py", line 182, in modify_request
    self._modify_request(request_builder, converter(value))
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/interfaces.py", line 6, in __call__
    return self.convert(*args, **kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 19, in convert
    return self._converter(value)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/interfaces.py", line 6, in __call__
    return self.convert(*args, **kwargs)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 30, in convert
    dumped = json.dumps(value, default=self._default_json_dumper)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/__init__.py", line 234, in dumps
    return cls(
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/home/mjholler/.pyenv/versions/3.8.0/lib/python3.8/site-packages/uplink/converters/standard.py", line 25, in _default_json_dumper
    return obj.__dict__  # pragma: no cover
AttributeError: 'bytearray' object has no attribute '__dict__'

Then, when this didn't work, I just wanted to try something with plain requests, which of course did work:
>>> import requests
>>> r = requests.post("http://localhost/post", data=b'1234')
>>> r.status_code
200
>>> r.json()
{'args': {}, 'data': '1234', 'files': {}, 'form': {}, 'headers': {'Accept': '*/*', 'Accept-Encoding': 'gzip, deflate', 'Connection': 'keep-alive', 'Content-Length': '4', 'Host': 'localhost', 'User-Agent': 'python-requests/2.22.0'}, 'json': 1234, 'origin': '<IP_ADDRESS>', 'url': 'http://localhost/post'}
>>>

Note the 'json' field has 1234 which I posted is binary, but it's just coincidentally rendering it as valid JSON (since it is). I don't know if httpbin has something for binary files, so this was what I thought I could use.

Update: httpbin has a POST /anything method which doesn't do the weird json interpretation that my requests example shown above does, but results in the same error when I tried to use uplink in a similar way to above with that path.

Hi @mikeholler,
Thanks for opening this issue! This looks related to #180, in that it is an issue with the library's default serialization strategy: before data is passed through requests.post, Uplink applies the StandardConverter, which tries to the data through the json serializer; frankly, this default logic is outright wrong, and the library should just pass the data to requests without any transformation. I'll prioritize this work for the next minor release.
A workaround for now is to register a custom, pass-through converter yourself, like so:
from uplink.converters import interfaces, register_default_converter_factory

@register_default_converter_factory
class PassThroughConverter(interfaces.Factory):
    def create_request_body_converter(self, type_, *args, **kwargs):
        return lambda value: value

@prkumar thank you for the timely response! The code snippet is great, too. Any idea, with this workaround, how I might adapt it to have one route that interprets the body as JSON and one that just passes it through as bytes in the same class?
I love that you're prioritizing this work, too. It does seem like this is pretty fundamental behavior and I'm glad to see that you think so as well :)

@mikeholler - Sure thing! If you need to accept both JSON and binary data, I would recommend you define two separate methods, one for each content type. Here's an (untested) example that illustrates this approach:
from uplink import Consumer, Body, post, json

class SampleApi(Consumer):
    @post("post")
    def create_binary(self, body: Body):
        """Post some binary data to httpbin's /post method"""

    @json
    @create
    def create_json(self, body: Body):
        """Post some JSON data to httpbin's /post method"""

(This example demonstrates the ability to extend consumer methods.)
You could take this further and expose a third method to joins the behavior and picks the correct request based on the type of the given body:
from uplink import Consumer, Body, post, json

class SampleApi(Consumer):
    def create(self, body):
        if isinstance(body, binary):
            return self.create_binary(body)
        return self.create_json(body)

    @post("post")
    def create_binary(self, body: Body):
        """Post some binary data to httpbin's /post method"""

    @json
    @create
    def create_json(self, body: Body):
        """Post some JSON data to httpbin's /post method"""

@prkumar that's a great workaround. I think you've misunderstood my use-case a little bit (I only want to except binary OR json in a method, mutually exclusive, but I do want to have a Consumer that has methods that do both). However, I am clear on exactly how to solve my problem now. Thank you for the help and I look forward to an update making this into master in the future.


Model Brew Messages

I suggest we model the messages brew uses for brew cask actions.
An related example can be found in issue #4785 where:
Example of the difference between brew install vs. brew cask install in the case where a package is already installed:
Brew
brew install brew-cask
Warning: brew-cask-0.36.0 already installed

Brew Cask
brew cask install github
Error: Cask for github is already installed. Use `--force` to install anyways.

@philoserf A valid idea, but the issue is too broad. Would you care to find said incongruent messages and open issues for each one? That way we can tackle them as they are found.


Xcode installation on bots do not include default simulator runtime

These logs show flutter_internal/ios/xcode/mac and flutter_internal/ios/xcode/ios being installed, but not the corresponding ios_runtime package, which includes the iOS simulator runtime that matches that Xcode version.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804806691052681793/+/u/install_xcode/stdout
[P12179 18:58:48.592 action_plan.go:163 I] In root:
[P12179 18:58:48.592 action_plan.go:175 I]   to update:
[P12179 18:58:48.592 action_plan.go:177 I]     flutter_internal/ios/xcode/mac (KsuhkEd8wy6ByBw9GeM1dI6T_zY08dWhbS26q4IGtIMC -> cL0iunZRZxSY8Q0bCLGb-deBZ4ZCLI7fun8EgKGsz7UC)
[P12179 18:58:48.592 action_plan.go:177 I]     flutter_internal/ios/xcode/ios (C0CJehG6krz2kPiqhRtnxEvaN6UV4fbcdQHbtiA4VQoC -> qqL6geMoQuE7y0qAWizc1bnPjFtvavQxC6cn5lSt0DMC)

This is resulting in test failures as the expected simulator runtime is unavailable https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804806691052681793/+/u/run_plugin_dependencies_test/test_stdout:
[plugin_dependencies_test] [STDOUT] stdout:     xcodebuild: error: The run destination Any iOS Device is not valid for Running the scheme 'Runner'.
[plugin_dependencies_test] [STDOUT] stdout:     	iOS 16.0 is not installed. To use with Xcode, first download and install the platform

When I run the same mac_toolchain command locally (https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804806691052681793/+/u/install_xcode/execution_details) on a depot_tools checkout from today I do see ios_runtime being installed:
$ mac_toolchain install -kind ios -xcode-version 14a5294e -output-dir test-14a5294e-download/Xcode.app -cipd-package-prefix flutter_internal/ios/xcode '-with-runtime=True'
[P20460 15:02:04.592 action_plan.go:163 I] In root:
[P20460 15:02:04.593 action_plan.go:169 I]   to install:
[P20460 15:02:04.593 action_plan.go:171 I]     flutter_internal/ios/xcode/mac:cL0iunZRZxSY8Q0bCLGb-deBZ4ZCLI7fun8EgKGsz7UC
[P20460 15:02:04.593 action_plan.go:171 I]     flutter_internal/ios/xcode/ios:qqL6geMoQuE7y0qAWizc1bnPjFtvavQxC6cn5lSt0DMC
[P20460 15:02:04.593 client.go:1890 I] Dry run, not actually doing anything.
[P20512 15:02:05.251 action_plan.go:163 I] In root:
[P20512 15:02:05.251 action_plan.go:169 I]   to install:
[P20512 15:02:05.251 action_plan.go:171 I]     flutter_internal/ios/xcode/mac:cL0iunZRZxSY8Q0bCLGb-deBZ4ZCLI7fun8EgKGsz7UC
[P20512 15:02:05.251 action_plan.go:171 I]     flutter_internal/ios/xcode/ios:qqL6geMoQuE7y0qAWizc1bnPjFtvavQxC6cn5lSt0DMC
[P20512 15:02:05.251 instancecache.go:189 I] Using temporary instance cache at /Users/m/xcode-cipd/test-14a5294e-download/Xcode.app/.cipd/tmp/dl_2555098529
 • [fetch 1/2] Fetched flutter_internal/ios/xcode/mac:cL0iunZRZxSY8Q0bCLGb-deBZ4ZCLI7fun8EgKGsz7UC in 81.7s
 • [fetch 2/2] Fetched flutter_internal/ios/xcode/ios:qqL6geMoQuE7y0qAWizc1bnPjFtvavQxC6cn5lSt0DMC in 0.9s
 • [unzip 1/2] Deployed flutter_internal/ios/xcode/mac:cL0iunZRZxSY8Q0bCLGb-deBZ4ZCLI7fun8EgKGsz7UC in 37.2s
 • [unzip 2/2] Deployed flutter_internal/ios/xcode/ios:qqL6geMoQuE7y0qAWizc1bnPjFtvavQxC6cn5lSt0DMC in 2.3s
[P20512 15:04:07.680 client.go:2127 I] All changes applied.
Packages:
  flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC
[P21752 15:04:10.694 action_plan.go:163 I] In root:
[P21752 15:04:10.694 action_plan.go:169 I]   to install:
[P21752 15:04:10.694 action_plan.go:171 I]     flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC
[P21752 15:04:10.694 client.go:1890 I] Dry run, not actually doing anything.
[P21767 15:04:11.177 action_plan.go:163 I] In root:
[P21767 15:04:11.177 action_plan.go:169 I]   to install:
[P21767 15:04:11.177 action_plan.go:171 I]     flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC
[P21767 15:04:11.177 instancecache.go:189 I] Using temporary instance cache at /Users/m/xcode-cipd/test-14a5294e-download/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/.cipd/tmp/dl_1203370802
 • [fetch] Fetched flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC in 141.4s
...

Blocking https://github.com/flutter/flutter/pull/110302

Is /opt/s/w/ir/cache/osx_sdk/mac_toolchain out of date?

@godofredoc any idea what's going on here?

If runtimes is set the default runtime is being deleted because there is no way to know if the default runtime is the same one we are trying to install. https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/osx_sdk/api.py;l=198

If runtimes is set the default runtime is being deleted because there is no way to know if the default runtime is the same one we are trying to install. https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/osx_sdk/api.py;l=198

runtime_versions wasn't set, I just updated that PR to try it as a workaround.
This is the original commit: https://github.com/flutter/flutter/pull/110302/commits/083065e46a159624cb30ca4ba4364ad17c5004c7

runtime_versions wasn't set, I just updated that PR to try it as a workaround.

Here's the swarming task for the linked install_xcode command, you can see that property isn't set: https://chromium-swarm.appspot.com/task?id=5cf0af7a4a08c310&o=true&w=true

You can see the same command working as expected in the engine (again, no runtime_versions set):
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804449615568574945/+/u/install_xcode/execution_details
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804449615568574945/+/u/install_xcode/stdout
Packages:
  flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC
[P32450 17:39:42.235 action_plan.go:163 I] In root:
[P32450 17:39:42.235 action_plan.go:175 I]   to update:
[P32450 17:39:42.235 action_plan.go:177 I]     flutter_internal/ios/xcode/ios_runtime (xbExNWHTJfpNf8vDNXhmLNx9sjfFvAl4ed74gTrXl3cC -> MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC)
[P32450 17:39:42.235 client.go:1890 I] Dry run, not actually doing anything.
[P32451 17:39:42.450 action_plan.go:163 I] In root:
[P32451 17:39:42.450 action_plan.go:175 I]   to update:
[P32451 17:39:42.450 action_plan.go:177 I]     flutter_internal/ios/xcode/ios_runtime (xbExNWHTJfpNf8vDNXhmLNx9sjfFvAl4ed74gTrXl3cC -> MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC)

Adding the default runtime_versions version worked, but shouldn't be necessary, and wasn't necessary on the engine run.
      runtime_versions: >-
        [
          "ios-16-0_14a5294e"
        ]

This is probably related to caches, once we use a build with runtime_versions in a given cache namespace we need to use it for all builders otherwise the local caches default runtime version will not be deterministic.

once we use a build with runtime_versions in a given cache namespace we need to use it for all builders

Where did that property come from though, runtime_versions was never set in the framework (until I updated my PR after I filed this issue to see if I could work around it).

Maybe it's seeing the cached default runtime from the order Xcode version?

@godofredoc do you think specifying the runtime is an acceptable workaround for now?  Will that cause collisions for the default caches that don't specify it?
https://github.com/flutter/flutter/pull/110302/files#diff-9e73abde9fff445f31e5928e80d2d3f88847e02fd8f76d46f66f147fdc82786dR2364
@CaseyHillers may also have an opinion.

How does the framework get runtimes? I see the engine specifies it explicitly in the ci.yaml, but I can't find any references in flutter/flutter's ci.yaml.
After sampling a few Mac Flutter tasks, I don't see any named caches for the runtimes (the engine correctly shows them)

How does the framework get runtimes?

It should be getting the default one associated with the Xcode version, and mac_toolchain handles that, like this:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804449615568574945/+/u/install_xcode/execution_details
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804449615568574945/+/u/install_xcode/stdout
Packages:
  flutter_internal/ios/xcode/ios_runtime:MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC
[P32450 17:39:42.235 action_plan.go:163 I] In root:
[P32450 17:39:42.235 action_plan.go:175 I]   to update:
[P32450 17:39:42.235 action_plan.go:177 I]     flutter_internal/ios/xcode/ios_runtime (xbExNWHTJfpNf8vDNXhmLNx9sjfFvAl4ed74gTrXl3cC -> MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC)
[P32450 17:39:42.235 client.go:1890 I] Dry run, not actually doing anything.
[P32451 17:39:42.450 action_plan.go:163 I] In root:
[P32451 17:39:42.450 action_plan.go:175 I]   to update:
[P32451 17:39:42.450 action_plan.go:177 I]     flutter_internal/ios/xcode/ios_runtime (xbExNWHTJfpNf8vDNXhmLNx9sjfFvAl4ed74gTrXl3cC -> MdZtRSDgehNcVVlroSXWVAaoq6ch3D6bv_r0s_NDgcMC)

I'm not sure why it's working in the engine but not the framework.  I was thinking maybe mac_toolchain is out of date there and isn't downloading the default runtime?

This is adding ~8 minutes to many framework tests, even when cached:
https://ci.chromium.org/p/flutter/builders/prod/Mac build_tests_1_4/6504

Is /opt/s/w/ir/cache/osx_sdk/mac_toolchain out of date?

We have been using latest version of mac_toolchain: https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/osx_sdk/api.py;l=48

If runtimes is set the default runtime is being deleted because there is no way to know if the default runtime is the same one we are trying to install. https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/osx_sdk/api.py;l=198

We are removing all existing runtime (default one+customized ones) and re-install customized ones: https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/osx_sdk/api.py;l=199, which seems not necessary. This only adds extra time to the whole build. I am wondering if we can check existence of customized runtime, and skip the remove+re-install if yes.

There shouldn't be any difference between engine and framework tasks, as they share the same version, same mac_toolchain, etc. Ran LEDs on all existing tasks (that have customized runtime ios-16-0_14a5294e) by removing this runtime dependency, all passed and installed the default runtime correctly:

Mac build_tests_1_4
Mac build_tests_2_4
Mac build_tests_3_4
Mac build_tests_4_4
Mac module_test_ios
Mac plugin_lint_mac
Mac plugin_test_ios
Mac tool_host_cross_arch_tests
Mac tool_integration_tests_1_4
Mac tool_integration_tests_2_4
Mac tool_integration_tests_3_4
Mac tool_integration_tests_4_4

Also ran 10 times for a specific builder: Mac plugin_dependencies_test, all passed as well.
I would assume this bug (not running default runtime) is a temporary issue with mac_toolchain. If there is some issue when installing the runtime, we should followup with toolchain team to investigate why the runtime is missing.
Opening https://github.com/flutter/flutter/pull/111492 to remove those runtime, as they have increased the total validation a lot (even doubled for some targets)

Hm, weird it's working now.  Thanks for checking again @keyonghan!

https://github.com/flutter/flutter/pull/111492 merged.  Closing.


[LAUNCHER] Layout bug when not logged in.

I think I made a layout bug somehow, when I switched things up on the launcher when you aren't logged in.

new launcher in flutter/dart is on the way.


To much Padding or Margin / self build

Describe the bug
To much Padding or Margin
To Reproduce
Self-Build on Mac
Screenshots

Desktop (please complete the following information):

OS: MacOS
Terminal: Terminal.app

note: I was able to reproduce this with kitty


forge test panic when logging negative numbers

summary
forge test panics with following error:
$ forge test
compiling...
success.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: FromDecStrError(InvalidCharacter)
Location: evm-adapters/src/sputnik/cheatcodes/cheatcode_handler.rs:90

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Abort trap: 6

steps to reproduce
minimal reproduction, excerpted from https://github.com/dapphub/ds-test/blob/master/demo/demo.sol
pragma solidity 0.8.11;

import "ds-test/test.sol";

contract DemoTest is DSTest {
    function test_logs() public {
        emit log("-- log_named_decimal_int(string, int, uint)");
        emit log_named_decimal_int("decimal int", -1.0e18, 18);
    }
}

This happens here

This is happening because the value is being passed through U256::from_dec_str from here which doesn't expect a -
So -- are negative values here valid?
Would be easy enough to work around if so. If not, maybe this just needs a better error message.

Looks like this is related. @mds1 are you still working on this?

Workaround here: #441
If I256 support gets added upstream, this should be removed


Network operations for packages should be done in parallel

Currently this is serialized and is quite slow when you have many dependencies.
Note that I expect initial fetches to be slow, but this is the case where the git repos are all unchanged. This is happening to me all the time because I'm constantly failing builds while getting Servo ported over.

Clarifying that I'd like to download packages in parallel in as well. I'd basically like to have the ability to perform all of our network operations in parallel, even if we don't necessarily take advantage of it by default.

If multiple dependencies share the same origin and are served via HTTP/2, a parallelized network IO stack should be able to make use of multiplexing.

I'm planning to take this. Some insights:
The point of parallelizing (or multiplexing) is to reduce the impact of network latency. Multiple connections has its own pros and cons, but I'm planning to maintain only one connection per server, as they are supported below.

https://crates.io/ (Heroku, used for redirects) probably have a correct HTTP 1.1 pipelining implementation.
https://static.crates.io/ (S3 CloudFront, used for tarballs) supports H2.

Another thing I'd like to do is to add file sizes to crates.io-index, so we can know the total download size beforehand and display a united progress bar. I'm not sure if the migration can be done smoothly though.

Parallelizing download is fater, beacuse of TCP congestion control
If the TCP window size is large enough, when the server waits for the client to respond to an ACK, it still sends packets. But in the real world, most of the time, the TCP window size is not large enough, especially with a large number of short connections ( Because of TCP slow start).
There are two solutions:

Multiplex: When a connection waits for ACK, other connection can still be sent.
HTTP/2 based on QUIC.

Close?

Because of #6005 (is the question-I'm not sure, myself)

Ah yes, we can indeed close! There's also a call for testing on internals.