GH Actions release binary builders

@achew22, converting most of the release flow to GH Actions as macOS hardware is seemingly required for cgo on macOS.
per: https://github.com/bazelbuild/bazel-watcher/pull/406
I think this is a truly compatible release flow. Biggest changes:

You are still creating release notes, tag (and pushing the tag) from your local (./release/release.sh)
The binaries are built only once and shared between GH and NPM (windows + linux from ubuntu, and darwin from macOS)
If the build(s) fail, your local release script does not detect it and rollback (not sure how you want to handle this one)
You need to add "NPM_TOKEN" as a GH Secret to allow publishing to NPM from an action (https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow)

Let me know what you think, of course this could be done many different ways, but I took an approach that seemed to be close to what you were already doing.

For what its worth, I was going to add a side-by-side pre-submit check in GH Actions, but running them on macOS may be to costly, given that GH allots only 2000 min/month for all exec, and for macOS they charges 10x.

For what its worth, I was going to add a side-by-side pre-submit check in GH Actions, but running them on macOS may be to costly, given that GH allots only 2000 min/month for all exec, and for macOS they charges 10x.

@joeljeske Sorry this is taking a while to look at. I really feel like I need to think about it before committing since I don't want to become the next supply chain attack 😉 . I'm starting to feel like I know what's going on after reading a lot of GH actions documentation, but I'm not quite there yet

@joeljeske Sorry this is taking a while to look at. I really feel like I need to think about it before committing since I don't want to become the next supply chain attack 😉 . I'm starting to feel like I know what's going on after reading a lot of GH actions documentation, but I'm not quite there yet

@achew22, no worries at all! I appreciate that you are dilligent in reviewing changes, especially ones like this that change things up a bit. I would have no hurt feelings if you felt more comfortable with a different approach (e.g. archiving the npm package bundle and then manually publishing from your own machine).

@achew22, no worries at all! I appreciate that you are dilligent in reviewing changes, especially ones like this that change things up a bit. I would have no hurt feelings if you felt more comfortable with a different approach (e.g. archiving the npm package bundle and then manually publishing from your own machine).

Okay, let's see what happens! Thanks so much @joeljeske I hugely appreciate all your efforts here. This is much better than what I had been doing and is a great lanchpad for future release enhancements.

@joeljeske this was the easiest release I've done yet. Thanks so much! It feels like we're very close.
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@bazel%2fibazel - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

https://github.com/bazelbuild/bazel-watcher/actions/runs/542055506
Do you know if it's possible to trigger it without actually hitting the release button and causing a new tag?

It feels like we're very close.
@achew22 hmmm... Did you remember to generate a NPM token and add it to github secrets?

It should be automatically picked up by npm and interopolated into the .npmrc It should be just a hex string token. You would need to have created
https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow#continuous-deployment

Do you know if it's possible to trigger it without actually hitting the release button and causing a new tag?

You can create a release draft to try it out i believe. You would not have to run your scripts locally, just create a release draft in GH UI. Currently the pipeline relies on information about the release being available so it knows what to modify. WE could create a different similar pipeline that can be run on-demand or on other triggers.

It feels like we're very close.
@achew22 hmmm... Did you remember to generate a NPM token and add it to github secrets?

Yes, sir.

It should be automatically picked up by npm and interopolated into the .npmrc It should be just a hex string token. You would need to have created
https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow#continuous-deployment

Do you know if it's possible to trigger it without actually hitting the release button and causing a new tag?

~You can create a release draft to try it out i believe. You would not have to run your scripts locally, just create a release draft in GH UI.~ [Edit, I read the docs more carefully which states drafts are ignored.] Currently the pipeline relies on information about the release being available so it knows what to modify. We could create a different similar pipeline that can be run on-demand or on other triggers.

Lemme try the draft release thing and see what happens.

I just created a draft release and it looks like it isn't going to be run by the releaser script until I publish it, which I'm a little reluctant to do.

Also, it looks like that release is only visible to maintainers on the repo :-(

Created a new PR to try to fix the issues
https://github.com/bazelbuild/bazel-watcher/pull/459


Automatic printing does not work - update documentation and raise exception when config not enabled

Some people have issues when trying to send a report to the printer (which is connected to the application server) and the printIsEnabled flag is not activated in the .properties file.
Todo

Update the documentation for that use case
Raise an exception when printing is requested but the flag is not set in the .properties file

Tested with the new error handling, see: #94 .


ISIC2018_segmentation-s4824208

Name: Snorre Sveen
SID:s 4824208
Taks1: Segmentation of the ISIC2018 with UNet
This pull request contains the implementation of a UNet model designed to preform segmentation on the ISIC2018 dataset.
For more information about the model and the results, see the README file.
README.md--Report for the task completed
Report_img--Contains images for the README report.
train.py-- Used to train and test the UNET model
predict.py-- Prints plots of preformance on testingset + prediction images compeard with thruths
dataset.py-- Loads the dataset and applies image transforms
utils.py-- Contains dice loss function
models.py--  Defines the model arcitchture for the UNet model
To train the model:
1.) Go to dataset.py
Add path to training set in line 84
Add path to truths for training set in line 87
Add path to test set in line 90 and test set truths 91
2.) Run train.py
3.) The model will be saved in same folder as train.py with the name "UNet_model.pt"
4.) Now its possible to run predict.py to get a plot of the scores on the test set and some example images.

Well organized files.
Algorithm solves the problem appropriately. Average Dice Coefficient in testing dataset: 0.79, but no evidence to support this score. Tending to train the model for only 2 epochs. No predicted Mask output.
Correctly using PyTorch to construct the Improved U-Net models and functions.
Sufficient comment in the code, but need some references.
Easy difficulty problem, no higher difficulty marks.
The format of the readme.md is not reasonable.

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks missing -1
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Easy -10
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe OK, Markdown no used well -1, missing usage -1
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good


initial content for finaid 2024

Should the "Deadline to accept a first-round grant" and "Deadline for submitting second-round applications" perhaps be after "First round of grant notifications"?🤔


GRADLE-3250 Add NTLM test to prepare support of SNI.

This test check that the 3 messages exchange is OK when using NTLM
authentication.

@kenji21 I haven't reviewed this code (I expect @bigdaz will relatively soon when he is back from vacation).
In the meantime though, would you mind signing the CLA?

@hansd do you know what the legal implication here is of @kenji21 explicitly declaring that this is public domain and therefore no CLA being required?  Does this meet our legal obligations?
@kenji21 thanks for the contribution. It may take a little bit of time to resolve this CLA issue. The implementation looks good to me, but we'll take a deeper look once the CLA issue is resolved.

On Thu, Apr 30, 2015 at 7:36 PM, Luke Daley<EMAIL_ADDRESS>wrote:

@hansd https://github.com/hansd do you know what the legal implication
here is of @kenji21 https://github.com/kenji21 explicitly declaring
that this is public domain and therefore no CLA being required? Does this
meet our legal obligations?

We need a CLA. It protects the Gradle community. We need the guarantees
that the code is owned by the contributor (not by the company he might be
working for) and that it is free from copyright issues. We use a similar
CLA like Apache does which is also mandatory for all Apache projects.  It could be a ticking legal time
bomb.
@kenji21: What is your objection with our CLA?

@kenji21 https://github.com/kenji21 thanks for the contribution. It may
take a little bit of time to resolve this CLA issue. The implementation
looks good to me, but we'll take a deeper look once the CLA issue is
resolved.
—
Reply to this email directly or view it on GitHub
https://github.com/gradle/gradle/pull/444#issuecomment-98029415.

No objection over the CLA, I've done these PR afterwork => individual just signed :-)

Thanks @kenji21 !

Do you have any updates on when this could be merged?

As stated in the dev list : https://groups.google.com/forum/#!topic/gradle-dev/RxmS3j2aD8w
Got a failing test after updating to http 4.4.1, it becomes "only testable" on windows, but I have no windows machine available to go further.

Hey @kenji21. Thanks again for the work you put into this. It's on my list to take a look at.

Did you look at the "test for windows only issue" I got while updating as I said on the dev list ? @bigdaz

Hi @kenji21. We really appreciate the work put into this pull request.
The Gradle team doesn't currently have the capacity to deal with all of the bugs, feature requests, great ideas and pull requests that we receive. We already have a pretty big backlog, so it might take some time for us to take a look at this.
Pull requests are interesting because they may seem like they come for "free". Our experience has shown that in order to maintain the level of quality and consistency that Gradle users expect, we need to invest significant engineering effort in all but the most trivial PRs.
We are actively recruiting to increase our engineering team, so hopefully this is a temporary situation. We ask for patience in the meantime.

In fact, I can't send a PR because updating HTTPClient to 4.4 make it rely on native access for NTLM Auth :
java.lang.UnsatisfiedLinkError: Unable to load library 'Secur32': dlopen(libSecur32.dylib, 9): image not found
And I have no idea how to make this test "only windows", maybe it has already happened for other tests ?

@kenji21, do you mind rebasing on master? Looks like there have been some changes that causes compilation to fail.
https://builds.gradle.org/viewLog.html?buildId=487292&tab=buildResultsDiv&buildTypeId=Gradle_PullRequest_LinuxJava17withSanityChec

sure, my PR was on gradle branch REL-2.2.1... maybe there will be some work

Ok, updated this PR from master. This first one adds a tests to show that NTLM auth is OK.
Now, have to update the patch provided at https://groups.google.com/forum/#!topic/gradle-dev/RxmS3j2aD8w to update to HttpClient  4.4.1

Thanks @kenji21. I am looking to get this pulled in the next release once we get Gradle 2.10 out the door.

Ok, so I can add a second commit to this that adds HttpClient update (and make the added test still pass) ?

That should be a separate pull request.

Ok, so I should create another branch (issue-3250-phase2 ?), and name the PR "GRADLE-3250 Update HttpClient to 4.4.1"

@kenji21 sounds like a good plan.

nice. 18 tests are failing after moving to HttpClient 4.4.1 (and having made some changes, and many deprecation removals)

@kenji21 There are a number of things that need to be addressed here. Mainly, we want to be able to test NTLM authentication in a more general way, similarly to how we currently do for BASIC and DIGEST auth schemes rather than simply add a single NTLM test.

We'll want to add a new AuthScheme to the HttpServer test fixture for NTLM.
This will likely mean implementing (or finding an existing implementation for) a Jetty Authenticator for NTLM.
Implementation should be as real as possible. The code in this PR doesn't look at the Type3Message LanManager or NT responses. This means the password being sent isn't checked at all, only the username.
Rather than adding a new integration test we should augment existing ones that use authentication to additionally test NTLM auth. You should be able to search for uses of HttpServer.AuthScheme. Note that NTLM auth should only be used in cases where an authentication { } block is not explicitly configured.

@kenji21, is this something you think you'll have time for, or feel comfortable doing. In fact, preferably we'd have coverage for SPNEGO as Kerberos falls under this umbrella as well. Let me know if you won't be able to take this on.

@kenji21, I've gone ahead and merged this pull request. I'll take care of the issues I've listed above post-merge. Thanks for the contribution. As for PR #546 we've decided to take that on as a priority in house so it's been closed.

Nice, thank you for help.


[BUG] Longhorn Air Gap installation from private repo

Chart_version: v1.0.1
Describe the bug
Based on the current Charts, Although the Private Registry URL was set in the Rancher Apps UI before deploying Longhorn, but the images were still pulled from the dockerhub during the deployment action.

Therefore, I modified the Charts and added the registryUrl prefix for the image parameter. As long as the user has configured the Private Registry URL (user name and password are optional), the images will be pulled from the private image registry.
PR: https://github.com/longhorn/charts/pull/6
Related issue
For the first installation of Longhorn and configuring the Private Registry URL, it has been tested.
However, if you are updating the Chart and configuring the Private Registry URL in an existing environment, there are currently some issues.
issue: https://github.com/longhorn/longhorn/issues/1642

What's the difference between this one and #1642 ?

@xiaoluhong In Longhorn installation using Rancher UI, if user wants to use private registry, setting up a private registry (URL, user, password) is the first step out of three steps. As you has noticed, just setting up a private registry does not make Longhorn pull images from the private registry. There are 2 other steps here https://longhorn.io/docs/1.0.1/advanced-resources/deploy/airgap/#using-rancher-app .
Specifically, we need to select false for the section Use Default Images and specify the full image image <REGISTRY_URL>/<Longhorn-component> for manager, engine, ui, instance manager, csi attacher, csi provisioner, CSI Driver registrar, CSI Driver resizer.
I think that the reason Longhorn is designed this way is so that user can use both public and private registry (Not locked into the private registry once it is setup in the cluster)

Hi All,
@yasker  The expected effect of adding environment variables in updated Longhorn-Driver-Deployer workload should automatically update the image of the csi-attacher, csi-provisioner, csi-resizer, longhorn-csi-plugin workload, but the actual effect is not updated. A look at the Longhorn-Driver-Deployer Workload log seems to indicate that the Workload already exists and the update is skipped.
@PhanLe1010
For the user usage that has been collected so far, the pull image is either done through DockerHub or private repo, with no other usage scenarios.
Users habitually use the default configuration, so if there is no custom image <<REGISTRY_URL>/< longhorn-component > > will pull the image from dockerhub by default. In my opinion, on the basis of following users' habits, users only need to fill in the private Registry to pull images from the specified image repo, and do not need to modify too much image configuration, which is better for the use experience of offline deployment scenarios.
Thanks.

For the user usage that has been collected so far, the pull image is either done through DockerHub or private repo, with no other usage scenarios.

@xiaoluhong Yeah, you have a great point. Thank you!
Should we change the logic @yasker ?

@xiaoluhong It makes sense, thanks for the explanation. I am going to assign this issue to you too since you already have a PR ready for it.

Hi @yasker ,
I submitted the new PR https://github.com/longhorn/longhorn/pull/1650.
Thank you.

@xiaoluhong the chart PR is merged. Can you help to check the doc to see if we need to update it? See https://longhorn.io/docs/1.0.1/advanced-resources/deploy/airgap/ . The doc repo is at https://github.com/longhorn/website

@yasker
Yes, the doc needs to be updated. I will submit a PR.

@PhanLe1010 Can you help to check and update the doc for this issue?

@yasker Sure

Validation: PASSED
Longhorn Version: v1.0.2-rc1

Waiting for docs to be updated

Updated doc merged to staging branch.

Validation: PASSED


Implemented blogger validation

New validation system based on node-validator then heavily modified.
Some validation functions made from validator.
Validation takes place in model and controller so it can be used in website and API.
/register now displays error messages and highlights fields that are invalid.
Closes issue #80

Closed pull request to fix merge conflicts in new request.


Net-new test configs

Describe the feature
Let's add configs for:

where
limit
warn_if, error_if (picking up from https://github.com/fishtown-analytics/dbt/issues/2219 + https://github.com/fishtown-analytics/dbt/issues/2982)

Following the work in #3257, these will be configurable from config() + dbt_project.yml + .yml instantiation (for generic tests).
Mechanism

Add to TestConfig:
https://github.com/fishtown-analytics/dbt/blob/7203123d56e42007d569a03c76bea0f351fb1611/core/dbt/contracts/graph/model_config.py#L437-L440

Add to schema test builder (along with methods lower down):
https://github.com/fishtown-analytics/dbt/blob/7203123d56e42007d569a03c76bea0f351fb1611/core/dbt/parser/schema_test_builders.py#L187-L188

Add to shortcut method for "fast" schema tests:
https://github.com/fishtown-analytics/dbt/blob/7203123d56e42007d569a03c76bea0f351fb1611/core/dbt/parser/schemas.py#L490-L491

Not sure if this issue is the right place for this but @jtcohen6 what do you think of supporting where at the model level? Use case:
With high-volume date-partitioned tables (especially for web traffic data), we often want to be able to test only the most recent partition each time. Testing the entire table each time would be too expensive and adding a where to each test individually doesn't seem particularly clean. I'd love to be able to just do something like this
models:
  - name: some_table
    test_where: "date_col = date_sub(current_date, interval 1 day)"

columns:
  ...

@prratek Such a good thought. I was also thinking about this in light of whether, for models with the require_partition_filter config set (new in v0.20), dbt should "automatically" set the where config for tests.
I'm thinking about this in a few ways:

A workaround that's possible today
A better (but still verbose) way possible in v0.20.0
How this could be better in the future

Today, it's be possible to define an ephemeral model that wraps ref('some_table') in a where condition, and then define tests on that ephemeral model instead. This doesn't feel like "first-class" support, but it's totally plausible and accomplishes what you're after.
In v0.20.0, it will be possible to define test configs in dbt_project.yml. Unfortunately, test FQNs are pretty silly , so in practice this looks like:
tests:
  my_project:
    schema_test:
      exact_name_of_schema_test:
        +where: "date_col = date_sub(current_date, interval 1 day)"
      exact_name_of_other_schema_test:
        +where: "date_col = date_sub(current_date, interval 1 day)"

We could improve test FQNs (#3259) so that they include the name and path of the model they're defined on, allowing them to instead work like:
tests:
  my_project:
    subdirectory:
      some_table:
        +where: "date_col = date_sub(current_date, interval 1 day)"

Finally, in a post-#2401 world (reconciliation of node configs and resource properties), we may be able to get quite close to the proposal you make above. I'm interested in tests being able to "inherit" configs from the parent models they're defined on (https://github.com/fishtown-analytics/dbt/issues/3256), so that you could define a where config as a model-level property, and have those be inherited by the tests beneath it. How would this work in practice, given that the implementation in #3336 adds where only as a test config, not as a model config? I'm not so sure.

This all sounds really great, particularly the improvements to test FQNs and what that enables! My only thought re: potentially inheriting this from model config is that the where doesn't intuitively feel like model config. What do you think? Being able to specify a where clause for tests by model name/path on the other hand makes sense to me.


Associated Access Entry Policies for Custom Access Entry are deleted with module ~> 20.0

Description

I followed the migration guide 　and everything works perfectly.
However, things are different when I try change my approach i.e after the following the migration guide until step 3（as shown in the image) where I add custom access entry with access policy and then applying the change and then moving forward to step to 5 and 6 where change the module source to 20.x and apply it. I see that the access policy associated with custom access entry is getting deleted.

Versions

Module version : ~> 20.0

Terraform version: v1.5.4

Provider versions

- Using previously-installed hashicorp/null v3.2.2
- Using previously-installed hashicorp/external v2.1.0
- Using previously-installed hashicorp/time v0.10.0
- Using previously-installed hashicorp/kubernetes v2.18.1
- Using previously-installed hashicorp/cloudinit v2.3.3
- Using previously-installed hashicorp/helm v2.4.1
- Using previously-installed hashicorp/aws v5.38.0
- Using previously-installed hashicorp/tls v4.0.5
- Using previously-installed gavinbunney/kubectl v1.14.0

Reproduction Code [Required] till Step 3 of the Migration Guide
Based stripped down version of what we are using
module "eks" {
    source          = "github.com/clowdhaus/terraform-aws-eks-v20-migrate.git?ref=c356ac8ec211604defaaaad49d27863d1e8a1391"

  cluster_name    = "test"
  cluster_version = "1.27"

   cluster_endpoint_public_access  = true
  cluster_endpoint_private_access = false

   vpc_id                    = module.vpc.vpc_id
  subnet_ids                = module.vpc.private_subnets
  enable_irsa               = true
  manage_aws_auth_configmap = true
  aws_auth_roles            = local.map_roles

    access_entries = {

    my_ae = {

      kubernetes_groups = []
      principal_arn     =  "arn:aws:iam::xxxxxxxxxxx:role/test"

      policy_associations = {
       my_ae = {
          policy_arn = "arn:aws:eks::aws:cluster-access-policy/AmazonEKSClusterAdminPolicy"
          access_scope = {
            namespaces = []
            type       = "cluster"
          }
        }
      }
    }
  }

  fargate_profiles = {
    kube-system = {
      name = "kube-system"
      selectors = [
        { namespace = "kube-system" }
      ]
    }
  }
}

if I do terraform apply Access entry called my_ae will be created with its associated policy.

Terraform plan till step 3 of the migration guide
Terraform will perform the following actions:

  # module.base.module.eks.aws_eks_access_entry.this["my_ae_my_ae"] will be created
  + resource "aws_eks_access_entry" "this" {
      + access_entry_arn  = (known after apply)
      + cluster_name      = "test-cluster"
      + created_at        = (known after apply)
      + id                = (known after apply)
      + kubernetes_groups = (known after apply)
      + modified_at       = (known after apply)
      + principal_arn     = "arn:aws:iam::xxxxxxxxxx:role/trial-role"
      + tags_all          = (known after apply)
      + type              = "STANDARD"
      + user_name         = (known after apply)
    }

  # module.base.module.eks.aws_eks_access_policy_association.this["my_ae_my_ae"] will be created
  + resource "aws_eks_access_policy_association" "this" {
      + associated_at = (known after apply)
      + cluster_name  = "test-cluster"
      + id            = (known after apply)
      + modified_at   = (known after apply)
      + policy_arn    = "arn:aws:eks::aws:cluster-access-policy/AmazonEKSClusterAdminPolicy"
      + principal_arn = "arn:aws:iam::xxxxxxxx:role/trial-role"

      + access_scope {
          + type = "cluster"
        }
    }

A very unusual thing about the terraform plan is the resource name which has my_ae_my_ae . In other words, the resource name is being repeated twice.

Steps to reproduce the behavior:

Moving forward the migration guide for step 5 and 6 i.e  changing source module back to "terraform-aws-modules/eks/aws" and module to v20.

module "eks" {

  source  = "terraform-aws-modules/eks/aws"
  version = "~> 20.0"

  cluster_name    = "test"
  cluster_version = "1.27"

   cluster_endpoint_public_access  = true
  cluster_endpoint_private_access = false

   vpc_id                    = module.vpc.vpc_id
  subnet_ids                = module.vpc.private_subnets
  enable_irsa               = true
 # manage_aws_auth_configmap = true
  # aws_auth_roles            = local.map_roles

    access_entries = {

    my_ae = {

      kubernetes_groups = []
      principal_arn     =  "arn:aws:iam::xxxxxxxxxxx:role/test"

      policy_associations = {
       my_ae = {
          policy_arn = "arn:aws:eks::aws:cluster-access-policy/AmazonEKSClusterAdminPolicy"
          access_scope = {
            namespaces = []
            type       = "cluster"
          }
        }
      }
    }
  }

  fargate_profiles = {
    kube-system = {
      name = "kube-system"
      selectors = [
        { namespace = "kube-system" }
      ]
    }
  }
}

terraform apply shows the plans to delete the associate policy

Terraform plan during step 6 of migration guide

Terraform used the selected providers to generate the following execution plan. Resource actions are
indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.base.module.eks.aws_eks_access_entry.this["my_ae"] will be created
  + resource "aws_eks_access_entry" "this" {
      + access_entry_arn  = (known after apply)
      + cluster_name      = "test-cluster"
      + created_at        = (known after apply)
      + id                = (known after apply)
      + kubernetes_groups = (known after apply)
      + modified_at       = (known after apply)
      + principal_arn     = "arn:aws:iam::xxxxxxx:role/trial_role"
      + tags_all          = (known after apply)
      + type              = "STANDARD"
      + user_name         = (known after apply)
    }

  # module.base.module.eks.aws_eks_access_entry.this["my_ae_my_ae"] will be destroyed
  # (because key ["my_ae_my_ae"] is not in for_each map)
  - resource "aws_eks_access_entry" "this" {
      - access_entry_arn  = "arn:aws:eks:ap-northeast-1:xxxxxxxxxx:access-entry/test-cluster/rolexxxxxxx/my-ae/xxxxxxxxxx" -> null
      - cluster_name      = "test-cluster" -> null
      - created_at        = "2024-03-07T17:40:30Z" -> null
      - id                = "test-cluster:arn:aws:iam::xxxxxxxx:role/trial-role" -> null
      - kubernetes_groups = [] -> null
      - modified_at       = "2024-03-07T17:40:30Z" -> null
      - principal_arn     = "arn:aws:iam::xxxxxxxrole/trial-role" -> null
      - tags              = {} -> null
      - tags_all          = {} -> null
      - type              = "STANDARD" -> null
      - user_name         = "arn:aws:sts::xxxxxxxx:assumed-role/trial-role/{{SessionName}}" -> null
    }

  # module.base.module.eks.kubernetes_config_map_v1_data.aws_auth[0] will be destroyed
  # (because kubernetes_config_map_v1_data.aws_auth is not in configuration)

   -  deleted map_config values

Again the access entry is recreated but this time with the correct name that is my_ae
However it is deleting the previously associated policy my_ae_my_ae.

I think is this because of the way the module is handling the name in the intermediate module of Step 3 of the migrations guide
Expected behavior

I expected Terraform to only delete the auth-config map after migration and not the associated access entry policy for the custom access entry.

Actual behavior

Changing module to ~>20.0 is deleting the auth_configmap which is expected
Changing module to ~>20.0 is recreating the custom access entry(with correct name) which is not expected
Changing module to ~>20.0 is deleting the previous associated access entry policy (with incorrect name) which is not expected

Additional context

I think The way source  = "git@github.com:clowdhaus/terraform-aws-eks-v20-migrate.git?ref=c356ac8ec211604defaaaad49d27863d1e8a1391" is handling the resource name is incorrect because the names repeating in the terraform plan

In order to reproduce the principal arn used for custom access entry should be present in the account. for example if IAM role's principal arn is used a role should exist before adding as IAM pricipal.

Custom Access entry I am adding is not present in the config map.

resolved in https://github.com/clowdhaus/terraform-aws-eks-migrate-v19-to-v20/pull/4 - thank you!


project status?

Is this abandoned? Assimilated into OrbitDB? Blocked by something?

We are looking for maintainers. As of now, the project is on standby.


image_zfs: destroy correct zpool on cleanup

As of image_zfs: Allow same-as-host pool names, if an error is encountered while building an image via image_zfs.sh, it's possible the wrong pool will be destroyed on cleanup. This happens because the on-disk name is used when destroying the pool instead of the in-core name.

I'll try running this over the next week. I had several failures today (on poudriere-devel from ports) where the message was "unable to destroy zroot" - which is a good thing it was unable, since that's my root pool! Then poudriere and any zfs commands would hang, and I had to reboot. So, I'm hopeful that this addresses that.

I'm happy to report that using this branch, poudriere cleans up the correct zpool and doesn't try to destroy my zroot! Thank you :rocket:

ping


18 - Fix config on Windows

Changes

Adds ability to remove the usage of __restrict (frequently causes errors relating to implicit conversions that drop restrict qualifiers)
Compiles PhysX as static library
Disables SIMD as it does not compile on the modern Windows SDK

DO NOT MERGE!!!

Consolidating my findings:

PhysX assumes you're on MSVC when you're on Windows (PxAoS.h checks for WIN64 not for MSVC)
PhysX's Windows SIMD codebase is written in MSVC-style SIMD code which is completely broken on Clang and Clang-CL.
It is broken because originally __m128 was supposed to be an opaque type but it has fields and members on MSVC.

So I don't think it is possible to enable SIMD on Windows using Clang, so perhaps instead we can gate SIMD to Windows & MSVC in the CMakeLists file

Fixed with @Derpius 's suggestion to just use the UNIX SIMD backend :trollface:


Overall uptime displays two percentage characters

On the summary page, the percent value is printed with two %-characters. Would have loved to submit a PR, but this is hard to track down

Duplicate of https://github.com/upptime/upptime/issues/92

Mohammed


RuntimeError: Could not fetch template files

I received the following error from MRIQC v21.0.0rc2. I ran it on four datasets and this error only occurred in three subjects spanning two of the datasets:

(main) login4.frontera(1012)$ cat /scratch1/03201/jbwexler/openneuro_derivatives/derivatives/mriqc/ds000030-mriqc/.reproman/jobs/local/20211214-102828-29c5/stderr.8
Downloading https://templateflow.s3.amazonaws.com/tpl-MNI152NLin2009cAsym/tpl-MNI152NLin2009cAsym_res-01_label-GM_probseg.nii.gz
100%|██████████| 7.57M/7.57M [00:00<00:00, 17.1MB/s]
Downloading https://templateflow.s3.amazonaws.com/tpl-MNI152NLin2009cAsym/tpl-MNI152NLin2009cAsym_res-01_label-WM_probseg.nii.gz
100%|██████████| 6.91M/6.91M [00:00<00:00, 14.7MB/s]
Process Process-2:
Traceback (most recent call last):
File "/opt/conda/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/opt/conda/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/opt/conda/lib/python3.8/site-packages/mriqc/cli/workflow.py", line 43, in build_workflow
retval["workflow"] = init_mriqc_wf()
File "/opt/conda/lib/python3.8/site-packages/mriqc/workflows/core.py", line 50, in init_mriqc_wf
workflow.add_nodes([anat_qc_workflow()])
File "/opt/conda/lib/python3.8/site-packages/mriqc/workflows/anatomical.py", line 122, in anat_qc_workflow
iqmswf = compute_iqms()
File "/opt/conda/lib/python3.8/site-packages/mriqc/workflows/anatomical.py", line 318, in compute_iqms
for p in get_template(
File "/opt/conda/lib/python3.8/site-packages/templateflow/api.py", line 104, in get
raise RuntimeError(msg)
RuntimeError: Could not fetch template files: /scratch1/03201/jbwexler/openneuro_derivatives/derivatives/mriqc/ds000030-mriqc/code/containers/binds/HOME/.cache/templateflow/tpl-MNI152NLin2009cAsym/tpl-MNI152NLin2009cAsym_res-01_label-WM_probseg.nii.gz.

The following error also occurred in two subjects spanning one dataset:

(main) login2.frontera(1062)$ cat /scratch1/03201/jbwexler/openneuro_derivatives/derivatives/mriqc/ds000201-mriqc/.reproman/jobs/local/20211214-105515-f641/stderr.0
Traceback (most recent call last):
File "/opt/conda/bin/mriqc", line 5, in
from mriqc.cli.run import main
File "/opt/conda/lib/python3.8/site-packages/mriqc/cli/run.py", line 24, in
from mriqc import config, messages
File "/opt/conda/lib/python3.8/site-packages/mriqc/config.py", line 108, in
from templateflow import version as _tf_ver
File "/opt/conda/lib/python3.8/site-packages/templateflow/init.py", line 19, in
from . import api
File "/opt/conda/lib/python3.8/site-packages/templateflow/api.py", line 7, in
from .conf import TF_LAYOUT, TF_S3_ROOT, TF_USE_DATALAD
File "/opt/conda/lib/python3.8/site-packages/templateflow/conf/init.py", line 42, in
_update_s3(TF_HOME, local=True, overwrite=True)
File "/opt/conda/lib/python3.8/site-packages/templateflow/conf/_s3.py", line 20, in update
retval = _update_skeleton(skel_file, dest, overwrite=overwrite, silent=silent)
File "/opt/conda/lib/python3.8/site-packages/templateflow/conf/_s3.py", line 55, in _update_skeleton
zipref.extractall(str(dest))
File "/opt/conda/lib/python3.8/zipfile.py", line 1647, in extractall
self._extract_member(zipinfo, path, pwd)
File "/opt/conda/lib/python3.8/zipfile.py", line 1697, in _extract_member
os.mkdir(targetpath)
FileExistsError: [Errno 17] File exists: '/scratch1/03201/jbwexler/openneuro_derivatives/derivatives/mriqc/ds000201-mriqc/code/containers/binds/HOME/.cache/templateflow/tpl-Fischer344'

The command I'm using is:
code/containers/scripts/singularity_cmd run code/containers/images/bids/bids-mriqc--21.0.0rc2.sing sourcedata/raw /scratch1/03201/jbwexler/openneuro_derivatives/derivatives/mriqc/ds000201-mriqc participant --participant-label '9001' -w '/scratch1/03201/jbwexler/work_dir/mriqc//ds000201_sub-9001' -vv --nprocs 11 --ants-nthreads 8 --verbose-reports --dsname ds000201 --ica --mem_gb 30

What is the contents of code/containers/scripts/singularity_cmd? Seems relevant to what bindings and environment variables are being set.

Here's that file: https://github.com/ReproNim/containers/blob/master/scripts/singularity_cmd

What if we just make https://github.com/templateflow/templateflow another subdataset in sourcedata/ and set SINGULARITYENV_TEMPLATEFLOW_HOME=sourcedata/templateflow/?

Would we also need to bind that directory or no?

Probably not, since the repository root will already be bound.

Any updates on this?

Yep, we solved this by installing templateflow via datalad (as an ephemeral clone to avoid having to download or copy for each dataset). And then:
SINGULARITYENV_TEMPLATEFLOW_HOME="/path/to/templateflow" SINGULARITYENV_TEMPLATEFLOW_USE_DATALAD="true"


Issue with yeoman

Hi,
I can see that windows power shell is reused in the window (which is great! ), but it seems that there is some sort issue with yeoman, it cannot find any generators.
I am running windows 7.

I have the same issue, the generators are installed globably as well.

@FDIM run yo doctor on terminal-plus and do what it tells you to do.
in my case i needed to set an environment variable.

doing yo doctor brings up a problem with the a env variable.
changing the variable needed has no effect in terminal-plus (doing set), however in the normal cmd i can see the variable change.


Replace the Release backend API mutators with a single PATCH op that takes patch instructions

The nature of the UI that we want for releases is that individual UI interactions all get immediately persisted to the backend. So that means we don't CRUD the entire object - we just want to mutate small sections of the object. This is because our 'resources' like release are quite large and complex. We don't really want to do a "save all" of the entire object by POSTing the whole thing to the backend.
Currently these individual mutates have been done ad-hoc - but the routes for release are very ugly. Thinking is to replace the mutates with a single PATCH operation that can handle a sequence of ops.
This ticket is to try this out on the release API and set a pattern for other resources.

https://jsonpatch.com/

To be clear - not sure we have to exactly match JSON patch (unless we evaluate it and that matches what we want to do).
Just saying that is the vibe of the PATCH data format I am thinking.
e.g.
{ "op": "add", "path": "/diseases", "value": { "system": "MONDO", code: "12345" } }


Running ve4 locally

Hello,
I am trying to run ve4 with following docker image link, but cannot find a way to actually run the view editor.
Is there a more comprehensive guide out there?
Which version do you recommend for running the ve4 locally?
cheers

hey @1-Kelvin . Unfortunately we don't have a more comprehensive guide at this time for setting up the environment. Perhaps I can help you over email or slack, though. Are you on the openmbee community slack group? https://openmbee.slack.com/

@blake-regalia were you able to help @1-Kelvin get this up and running... I'm assuming this is the only ve version that will work with mdk5.x. If you guys have any build notes I would appreciate them.

repo name changed to reflect different deployment


Change surface_azimuth convention in get_pvgis_hourly

[x] Closes #1724
[x] I am familiar with the contributing guidelines
[x] Tests added
[ ] Updates entries in docs/sphinx/source/reference for API changes.
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Nearly everything in pvlib represents azimuth angles as values in [0, 360) clockwise from north, except pvlib.iotools.get_pvgis_hourly. This PR modifies the get_pvgis_hourly function such that it follows the pvlib convention.

The supplied azimuth is echoed in the inputs return value... I guess we should translate that one as well? Or maybe just get rid of that return value altogether so that the function can have the same data, metadata return structure as the rest of iotools?

So the second returned element "inputs" actually also contains metadata describing the outputs, so it is useful. I am a strong believer in sticking with the (data, meta) output format and think that the output related content in "inputs" should simply be included in the meta dictionary and the input related content in "inputs" should be discarded. Consistency is key, and I always forget how many items the PVGIS functions return. But changing this would be a breaking change...?

Regarding inputs: how about we translate azimuth in this PR and open a new issue for changing the number of return values? Might want to get that into 0.10.0 too.

Translating the azimuth is surprisingly convoluted. First off, it is necessary to update both the description:
metadata['inputs']['mounting_system']['fields']['azimuth']['description'] = \
    'Orientation (azimuth) angle of the (fixed) PV system (0 = N, 90 = E, 180 = S)'

and the value (changing the value requires some wrangling due to the field name changing depending on the type of mounting system):
inputs['mounting_system'][list(inputs['mounting_system'].keys())[0]]['azimuth']['value'] = \
    inputs['mounting_system'][list(inputs['mounting_system'].keys())[0]]['azimuth']['value'] + 180

However, the above line is not sufficient, given that for certain tracking mounting systems the azimuth value is specified as '-'.
Also, the metadata structure is completely different for the json and the csv output formats. In short, translating the azimuth will add significant lines of code to the function, which I don't think is worth it. I'm more inclined to add a warning message stating that the metadata concerning the azimuth is not corrected. @kandersolar what do you think of this?


Improve policy constraint error message

This PR besides aiming to improve the policy constrain error message, introduces a minor refactor. TargetHostnames and ValidateHierarchicalRules were controller methods that didn't need to make any use of the K8s client, thus they were extracted, simplified and unit tested .
The error message now looks like this:
rule host (keystep.arturia.com) does not follow any hierarchical constraints,
for the *v1beta1.RateLimitPolicy to be validated, it must match with at least one
of the target network hostnames ["*.moog.com", "*.korg.com"]

This new version, besides showing the wrong policy target hostname, it shows the Type of the policy being reconciled and the target network object (HTTPRoute or Gateway) hostnames.
closes https://github.com/Kuadrant/kuadrant-operator/issues/113
Verification Steps

Setup your local Kind env with

make local-setup

Create a route with the following spec:

 kubectl apply -f - <<EOF
---
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: HTTPRoute
metadata:
  name: toystore
  labels:
    app: toystore
spec:
  parentRefs:
    - name: istio-ingressgateway
      namespace: istio-system
  hostnames: ["*.toystore.com"]
  rules:
    - matches:
        - path:
            type: PathPrefix
            value: "/toy"
          method: GET
      backendRefs:
        - name: toystore
          port: 80
EOF

Note the hostnames value being "*toystore.com"

Apply the following RLP:

kubectl apply -f - <<EOF
---
apiVersion: kuadrant.io/v1beta1
kind: RateLimitPolicy
metadata:
  name: toystore
spec:
  targetRef:
    group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: toystore
  rateLimits:
    - rules:
        - hosts: ["*.petstore.com"]
      configurations:
        - actions:
            - generic_key:
                descriptor_key: "limited"
                descriptor_value: "1"
      limits:
        - conditions:
            - "limited == 1"
          maxValue: 5
          seconds: 10
          variables: []
EOF

Note here that the spec.rateLimits[0].hosts value is "*.petstore.com"

Once applied, the status of the RLP should show a failed condition with the following message:

kubectl get ratelimitpolicies/toystore -o yaml | yq ".status.conditions[0].message"

rule host (*.petstore.com) does not follow any hierarchical constrains,
for the *v1beta1.RateLimitPolicy to be validated, it must match with
at least one of the target network hostnames ["*.toystore.com"]

it must match with at least one of the target network hostnames [".moog.com", ".korg.com"]

I think you meant *.moogmusic.com... 😉

LGTM
There are conflicts to be merged as main has changed since the PR was created


There is a chance the array is empty

@gtanner I know this has been like forever, but did this particular issue address any of the open bugs?

@evilpacket I have this exact same bug. The problem is easily reproducible with Mongoose and can be seen with something like this :
const myMongooseResults = await SomeMongooseModel.findOne({ category: someCategory, name: someName }).exec();

@evilpacket I have this exact same bug. The problem is easily reproducible with Mongoose and can be seen with something like this :
const myMongooseResults = await SomeMongooseModel.findOne({ category: someCategory, name: someName }).exec();

Closing in favor of #82


Add unit filter to cloudwatch query get_metric_data

Codecov Report

Merging #5722 (25cbf20) into master (4844af0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5722   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files         748      748
  Lines       73225    73234    +9
=======================================
+ Hits        70442    70451    +9
  Misses       2783     2783

Flag
Coverage Δ

servertests
36.79% <0.00%> (-0.01%)
:arrow_down:

unittests
96.13% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/cloudwatch/models.py
95.27% <100.00%> (+0.03%)
:arrow_up:

moto/dynamodb/responses.py
94.98% <0.00%> (+0.05%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


training detail

Hello, I have some questions about the training details. Your NRP model uses coco data set. When compared with other algorithms, the data set they train should not be coco. Is this comparison a reasonable explanation

Hi,
Yes, as NRP can be trained on any other dataset as well. The performance of NRP is expected to boost with training on ImageNet or any different large-scale dataset.


[FR] Using # in Part Names

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

Problem statement
I am currently trying to import my old partkeepr database into partkeepr, but it seems like Invnetree is not allowing '#' in a part name. Those # are quite important for my inventory structure, and it would not be easy to replace those.
There might be some other people out there with the same or a similar problem, that is why i would recommend to allow # in part names.
Suggested solution
I would suggest to support # in part names.
Describe alternatives you've considered

Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

The existing part naming restrictions are outdated now, recent improvements (especially around sanitisation of data) may have rendered these redundant.
@matmair can you see any reason not to allow these restricted characters back into the part naming schema?

@SchrodingersGat I see no security reason; the only thing I can think of is possible collisions in the URL schema (ie if we use a part name there a # is certainly not a good symbol to have).
Should be good to go. TBH this is very low on my priority list - would be a good first issue / hacktober thing.

A good starting point for the required changes is this validator; The character should be removed from the blocklist and then some testing (if something broke) is required
https://github.com/inventree/InvenTree/blob/193b69eeb59e0fb8fe431dd1905626b380446067/InvenTree/InvenTree/validators.py#L40-L46

@matmair I've another PR in the works which makes sense to roll this into, I'll tackle it :)

I would appreciate # because e.g. Texas Instruments uses it in standard part names and these parts can't be handeled right now

@gooutbefree we are working on it. Small team so it might take a while.


Render delay when switch new layer

when change layer visibility(or add) everything is lagging  even I make the globe visible after render complete/loaded.
One workaround is  to replacing add/remove logic with set opacity and load all layers when initialize the globe, it works when there are only few layers, but when layer number increase, this is not scalable.


7.5.1. unable to enter tags

Whenever I try to type anything into the tag search bar, nothing shows up. Typing anything besides numbers will not work, and when I do type in numbers I can only type in a maximum of three things before I can type literally nothing else. Below is a gif of what I explained above. I'm spamming my keys but only the numbers are working, up to a maximum of 3, then I can't type anymore.
https://user-images.githubusercontent.com/81654627/115615385-e4234480-a2bc-11eb-85a0-f74007b0fce4.mp4

Looks like the favorites tab?
In that case, this field is the page number, not some sort of search field.
You should go to (or create) another tab if you want to perform a normal search.

Use a wildcard "*". Some sites for some reason is returning zero results without it.


Add useEffect Function

We need to build our own useEffect function (we're pretty much rebuilding React step-by-step).
If you want to claim this, drop a comment.

Hi, I am new to open source. and interested to contribute to this issue. I have good knowledge of react JS

Hey @Kingkp007– Do you know a lot of Javascript? It's pretty much just creating our own version of the 'useEffect' function– you could probably look through the React docs on how they implement it.


refactor(api): implement thermocycler SetTargetBlockTemperature command

Overview
This PR implements the new, non-blocking thermocycler/setTargetBlockTemperature command in the Protocol Engine.
Changelog

refactor(api): implement thermocycler SetTargetBlockTemperature command

Review requests

This PR touches the hardware control layer of the thermocycler. Careful review of the changes is appreciated
Test with real hardware, if you can

Risk assessment
Medium. Hardware control changes need to be validated

I have tested this on an OT-2R with an attached thermocycler, and I am able to set the target block temperature using the POST /commands API


no longer create default athena query results bucket

Feature or Bugfix

Feature

Detail

Match new behaviour of athena: https://docs.aws.amazon.com/athena/latest/ug/querying.html#query-results-specify-location-previous-defaults

Relates

#1707

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-ATYtnXPE7MOa
Commit ID: 79d3aa5b8e10a1fe79ab4667c35a28b374cea7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 79d3aa5b8e10a1fe79ab4667c35a28b374cea7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 79d3aa5b8e10a1fe79ab4667c35a28b374cea7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-ATYtnXPE7MOa
Commit ID: 914a9eb997012fff04bff1f2cefc0d36dbe2aca8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 914a9eb997012fff04bff1f2cefc0d36dbe2aca8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 914a9eb997012fff04bff1f2cefc0d36dbe2aca8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 055503d1f69585a864120d8de36d9fdb44be0b95
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 055503d1f69585a864120d8de36d9fdb44be0b95
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws/aws-sdk-pandas we must make a decision on this one as we approach 3.0 release. Athena is not creating the S3 bucket anymore. Replicating that behaviour would mean that most wrangler Athena apis would require the s3_output parameter to be specified (including 100s of our own tests), forcing a breaking change on our users potentially.
Personally I find creating the bucket to be quite convenient and useful. So I would vote for making the bucket a bit more secure (non-public objects for instance), making it clearer in the docs/logging, but keep the same behaviour.

Closing as a decision was made to keep the current behaviour, thanks for the PR @cnfait


uguid: Change the u16 Guid fields back to arrays

These were previously changed to u16 for consistency with the use of u32 in the time_low field. That use of u32 is needed to control the alignment of Guid, but arrays are a more natural representation so stick with arrays for the other fields.

Codecov Report

Merging #138 (f77d4f8) into main (2c9caad) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   94.33%   94.32%   -0.01%
==========================================
  Files          14       14
  Lines        1500     1498       -2
==========================================
- Hits         1415     1413       -2
  Misses         85       85

Files
Coverage Δ

uguid/src/guid.rs
98.98% <100.00%> (-0.02%)
:arrow_down:


feat: Support Dell iDrac

:tada: This PR is included in version 1.82.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.82.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


window screen location issue with multiple screens

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

Windows 7 enterprise SP1
Hyper.app version: 1.2.1
The issue is reproducible in vanilla Hyper.app: yes

Issue

Required hardware configuration is a laptop connected to a dock with extra screen.
Steps to reproduce the issue:

Open hyper and move its window to the extra screen
Close hyper
Disconnect laptop from dock.
Open hyper again
Hyper is still created at the former location (that now points outside my laptop screen), and there is no way to bring it back except by restarting the laptop entirely.

Basically, the issue comes from the very poor additionnal screen management in Windows, but most other programs I use like Atom for instance handle this, probably by resetting the window location on startup.

@Overdrivr Yes, this is an issue since we memorize the screen position on quit. But if an extended display is disconnected. It will open at the recorded position. You can temporaly overide this by deleting the electron-config cache.

For those like me that went hunting around, the electron-config cache is at AppData/Roaming/Hyper/config.json. Deleting it does bring back the window.

Alternately, you should be able to move the window around using the normal windows window moving keys (windows+left, windows+right, and windows+up).  That should get it back on screen pretty easily.

@MartyGentillon tried this, but Hyper doesn't seem to respond. Also tried moving it to a new virtual desktop.

What worked for me was actually adjusting the "scaling" on my laptop display from 125% (preset) to 100%, something about this made Hyper open off-screen on the external monitor.

Will be fixed by: https://github.com/zeit/hyper/pull/2459


ldap documentation example configuration fix

Signed-off-by: Mert Can Bilgiç<EMAIL_ADDRESS>Hey, I just made a Pull Request!

There was a problem with example configuration at https://backstage.io/docs/integrations/ldap/org#docsNav
When you didn't give set as object array, it gives the error below.

Then when you made it object array, it requires path and value variables shown at the screenshots below,

I've added this required parameters to example configuration.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[✔ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4871-zoqtej2wxz0zxchf2gprkapqivh0pxro.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60462b9cf285af2556a35e48

ping, did you have time to look into the discrepancy between schema and code and docs?

Closed by https://github.com/backstage/backstage/pull/5395


Is there a limitation of 200 test classes?

Hi,
I tried using ApexUnit for our app which has around 300+ test classes. The final report however shows 200 test classes executed. Is there any limitation on number of test classes that can be executed using ApexUnit?
Thanks,
Jinesh

Hello @jineshkenandy
There is no limit set on the # of test classes. Currently tests with 'default' namespace will be picked. If you have test classes belonging a different namespace, those will probably not be picked.
Also, We have a enhancement request to support different namespaces(Issue #23  ) . Let me know if you have any questions

@jineshkenandy  Please let me know if you have any questions. Closing this question for now. Thanks


Use regex to catch more source layer cases

for #25
Using this regex to catch those cases:  COPY .*\/src ?(# .*)?$ which should catch any layer that COPY's into /src.

I think this isn't actually a general solution. We might need a "layer picker" menu when we can't find the src layer directly


Padding with std::numeric_limits::lowest() gives different results on CPU/GPU

Related to #484 for fp16_tiny_yolov2.  When Maxpool is called, there is asymmetric padding applied via the pad operator. The lowest value on the GPU for half is currently not correct (it is being set to 0). I created a simple unit test to verify this behavior.
FAILED: ../../test/onnx/maxpool_half_test.onnx
error: 0.203961
cpu:0.75, 0.75, 0.6875, 0.6875, -0.9375, 0.75, 0.75, 0.6875, 0.9375, 0.9375, 0.75, 0.9375, 0.9375, 0.9375, 0.9375, 0.625, 0.9375, 0.9375, 0.25, 0.25, -0.1875, 0.5, 0.5, 0.25, 0.25
gpu:0.75, 0.75, 0.6875, 0.6875, 0, 0.75, 0.75, 0.6875, 0.9375, 0.9375, 0.75, 0.9375, 0.9375, 0.9375, 0.9375, 0.625, 0.9375, 0.9375, 0.25, 0.25, 0, 0.5, 0.5, 0.25, 0.25
Cpu data is all zeros
Gpu data is all zeros
Max diff: 0.9375
Mismatch at 4: -0.9375 != 0

In the file target/gpu/device/pad.cpp, we have the following code,
type device_val = value;
if(float_equal(value, std::numeric_limits::lowest()))
{
device_val = device_cast(std::numeric_limits::lowest());
}
Could this be the reason for the error?

@kahmed10, can you point me where is the onnx file maxpool_half_test.onnx? I want to try it.
Thanks

I just modified the gen_onnx.py script as follows:
@onnx_test
def maxpool_half_test():
    x = helper.make_tensor_value_info('x', TensorProto.FLOAT16, [1, 1, 5, 5])
    y = helper.make_tensor_value_info('y', TensorProto.FLOAT16, [1, 1, 5, 5])

    node = onnx.helper.make_node('MaxPool',
                                 inputs=['x'],
                                 outputs=['y'],
                                 kernel_shape=[2, 2],
                                 auto_pad='SAME_UPPER')

    return ([node], [x], [y])

In the file target/gpu/device/pad.cpp, we have the following code,
type device_val = value;
if(float_equal(value, std::numeric_limits::lowest()))
{
device_val = device_cast(std::numeric_limits::lowest());
}
Could this be the reason for the error?

For some reason std::numeric_limits::lowest() fails to set the correct value for fp16 on the GPU (it sets it to 0). The CPU is unaffected, and fp32 datatype works fine with this logic.


Fix: Prompt for credentials when a network share access is denied

Resolved / Related Issues

[ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #14903

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Launch Files with a low-privileged user account
Access a server adminsitrative share (\myserver\c$)

Screenshots (optional)

Congrats on your first PR to Files!


[WIP] Extend scope of a GithubApp token to multiple repos in a particular namespace

Changes
Fixes: https://issues.redhat.com/browse/SRVKP-2911
PAC now support to extend scope of a GithubApp token to multiple repos in a particular namespace when scope_token_to_namespace set to true

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Pending E2E


File Editor Interface

Not really an issue, more a feature request.
I have been searching for a replacement to web matrix for some time, and in my list of viable alternatives, Jexus manager is in the top 3. If a code editor or file editor interface with syntax highlighting could be added (either integrated or as an addon), this tool would be the perfect solution.

Thanks for the comment, but code editing is too much to work on. There is currently no plan to make that part of Jexus Manager.

New issues are marked as low priority by default. Becoming our commercial customers, and then your reports are handled with higher priority after triage.


Deleting image attachment from issue continues to show attachment until page reload

Gitea version (or commit ref):  1.12.0+dev-320-g4a04740da (docker image d0d4dd915d2e)
Git version:
Operating system: Docker on a Synology NAS
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (below from https://try.gitea.io/bjj/x/issues/1 )
[ ] No
[] Not relevant

Log gist:

Description
Deleting attachment from an issue continues to show the attachment until the page is reloaded. Attachment link actually continues to work.
...
Screenshots
Create issue and drag in attachment:

Edit, remove attachment

(note attachment still showing) Hit Save

Attachment still visible (and link still works!)

Looks correct after reloading

I think this has been resolved. Please feel free to reopen it if it's still a problem.


All of my links are not linking properly

My main website is at www.productmanagerhq.com where I had one page 'Forum' redirect to www.productmanagerforum.com (which is the custom URL I point to my Herokuapp for Telescope). Whenever I post a link on www.productmanagerforum.com, none of the links work. Instead the link URL seems to append to the end of www.productmanagerhq.com/forum for some strange reason instead of linking straight to the correct URL.
Can anyone help explain what might be going wrong here?

Found a fix, turns out in the settings section I had used the wrong URL


recombine webpack, and a fix for "npm run test"

Current coverage is 97.75%

Merging #692 into master will increase coverage by +0.03% as of c67d127

@@            master    #692   diff @@
======================================
  Files           72      72
  Stmts         3473    3473
  Branches       282     282
  Methods          0       0
======================================
+ Hit           3394    3395     +1
+ Partial         36      35     -1
  Missed          43      43

Review entire Coverage Diff as of c67d127

Powered by Codecov. Updated on successful CI builds.

Note on second commit:
Took out the BABEL environment variables passed.  Not sure you wanted those.  But can pass multiple now in npm script in cross-env way, thanks to kentcdodds repo
Noticed Dan has those in on Redux now, along with building an ES version for the js:next / rollup

I noticed those changes in Redux, too. Was meaning to find time to do this. Best kind of PR! :+1: Thanks!


install node modules don't work

Hello,
I tried to install : "npm install ng2-datepicker --save" .
I followed the procedure but the component does not work.
The error returned by the chrome console is:
localhost:3000/ng2-datepicker Failed to load resource: the server responded with a status of 404 (Not Found).
Thank you so mutch!

@enzinoieva thank you for using our product. It seems the problem is from Datepicker, not from our Material Dashboard. I've found this on StackOverflow, hope it will help you: http://stackoverflow.com/questions/40289639/ng2-datepicker-404-not-found-latest-rc
Best,
Alex


SourceGenerator can't find dependent projects

I'm trying to use the source generator to generate typescript files for several C# class libraries. I wanted to have a shared config, so I created a simple BaseConfig class in a different library project that will be shared with the others.
using NTypewriter.Editor.Config;
namespace MySharedLib;
public class BaseConfig : EditorConfig {
    public override bool AddGeneratedFilesToVSProject => false;
    // etc.
}

Then, in one of those projects, I created the project config (ProjConfig.nt.cs) that inherits from the BaseConfig like so:
using MySharedLib;
using System.Collections.Generic;
namespace Proj1.NTypewriter;
public class ProjConfig : BaseConfig {
    public override IEnumerable<string> NamespacesToBeSearched {
        get {
            yield return "Proj1.Dtos";
            yield return "Proj1.Controllers";
        }
    }
}

This all compiles fine, but when the source generator runs, it says it can't find MySharedLib.
Does the source generator not share the same dependencies as the project it's running on? Is there some way to configure this? Hoping I'm just missing something obvious. 😅
Also, on a sidenote, using System.Collections.Generic; is also required even though the editor says it's not needed and can be removed.

A source generator, in general, is run in the context of a given project, it does not know anything about other projects in the solution, nor does it have access to source files from other projects. A source generator is run as a part of a compilation, it shares dependencies with the compiler (VS/MsBuild/dotnet build), not with the project that is compiled.
So, the only way to share base config file between projects is by linking that file to the projects.

Thanks for the tip! I managed to get the BaseConfig compiling by adding it as a linked file and ensuring it had a .nt.cs extension (I originally just had .cs and it was giving the same error as before saying it couldn't find it). Not the best, but it's working. 👍


AUTH-336: PSA Violation alert: add ocp_namespace label

This should help us see the ocp_namespace label in the PodSecurityViolation alerts, outlining the platform and "openshift-" prefixed namespace of the violating workloads.
/cc @deads2k @ibihim

This looks good from the technical perspective, you will get the ocp_namespace label in your alert.
I think there is a chance here to improve the alert as a whole as well. You just added information in which namespace the offending pod is running, but its only exposed as a label. The summary and description of the rule don't make use of it ("A workload (pod, deployment, daemonset, ...) was created somewhere in the cluster").
The tricky part with this is that the ocp_namespace label is only sometimes useful. non-platform doesn't really add much. To solve this you could either use templating to add the label value to the descirption (and maybe summary?) when it's useful. Or partition the alert into two alerts based on the ocp_namespace label. Something along the lines of:
  groups:
  - name: pod-security-violation
    rules:
    - alert: PodSecurityViolation
      annotations:
        summary: One or more workloads users created in the cluster don't match their Pod Security profile
        description: >-
          A workload (pod, deployment, daemonset, ...) was created somewhere in the cluster but it
          did not match the PodSecurity "{{ $labels.policy_level }}" profile defined by its namespace either via the cluster-wide
          configuration (which triggers on a "restricted" profile violations) or by the namespace
          local Pod Security labels.
          Refer to Kubernetes documentation on Pod Security Admission to learn more about these
          violations.
      expr: |
        sum(increase(pod_security_evaluations_total{decision="deny",mode="audit",resource="pod",ocp_namespace="non-platform"}[1d])) by (policy_level, ocp_namespace) > 0
      labels:
        namespace: openshift-kube-apiserver
        severity: info
    - alert: PodSecurityViolation
      annotations:
        summary: One or more workloads users created in the cluster don't match their Pod Security profile
        description: >-
          A workload (pod, deployment, daemonset, ...) was created in namespace "{{ $labels.ocp_namespace }}" but it
          did not match the PodSecurity "{{ $labels.policy_level }}" profile defined by its namespace either via the cluster-wide
          configuration (which triggers on a "restricted" profile violations) or by the namespace
          local Pod Security labels.
          Refer to Kubernetes documentation on Pod Security Admission to learn more about these
          violations.
      expr: |
        sum(increase(pod_security_evaluations_total{decision="deny",mode="audit",resource="pod",ocp_namespace!="non-platform"}[1d])) by (policy_level, ocp_namespace) > 0
      labels:
        namespace: openshift-kube-apiserver
        severity: info

This would also allow you to set a different value for severity if that is appropriate.
I would also leave the namespace label untouched. This label conveys where this alert was defined and users might rely on it for some reason already.

Thank you Jan for your review! I incorporated the suggested changes.

Out of curiosity, since PSA has been more of an auth topic, would it make sense to move this alert to https://github.com/openshift/cluster-authentication-operator?

It's based on a metric from the kube-apiserver, hence the location.

/retitle  AUTH-336: PSA Violation alert: add ocp_namespace label

I couldn't find where the ocp_namespace label is defined and what values it can take. Can you provide me with a link?

https://github.com/openshift/kubernetes/pull/1454/files is the relevant PR for that.

/approve
approvign in concept
top level question for the detailed reviewer: will we see the ocp_namespace in telemetry

/retest-required

/retest-required

/test e2e-gcp-operator
this appears stuck

/retest-required

/retest-required

/retest-required

/test e2e-gcp-operator-encryption-aescbc
this test should not be required but the bot does not want to merge the PR w/o it?

That's super odd :O. I broke e2e-gcp-operator-encryption-aescbc intentionally knowing it wasn't mandatory to be able to test a new feature in https://github.com/openshift/cluster-kube-apiserver-operator/pull/1449.

Oh wait it is actually required for aescbc. Not sure why they were triggered here, but I'll send a PR to make them optional until https://github.com/openshift/cluster-kube-apiserver-operator/pull/1449 is merged.

/retest-required

/retest-required

/retest-required
infra

/retest-required
infra

/unhold
/retest-required
Failures are unrelated

/retest-required

/retest-required

/retest-required
infra

/retest-required

/override ci/prow/e2e-aws-ovn-serial
This is on the path to security fixes backported to 4.13.0.  I'm overriding the oauth-proxy (likely networking) failure.

/retest-required

/retest-required
broken installs, still?

/retest-required

/jira refresh

/retest-required

/retest-required

/retest-required

/retest-required

/retest-required

/retest-required

/test e2e-aws-ovn-serial

/hold cancel
/retest-required

/retest-required

/retest-required


[Bug] Netty Epoll is unavailable for the RSS Client.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
When the RSS Client enables Netty and sets the mode to Epoll, the following error will be reported:
[22:21:37:071] [pool-3-thread-1] INFO  RetryUtils.retryWithCondition - Retry due to Throwable, java.lang.UnsatisfiedLinkError
After further investigation, it was found that this issue is related to this PR #924 not functioning properly.
The Netty native libraries have never been successfully shaded. PR #924 is not working at all.
Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Done by #1410


Implemented new time handling for time_map_async

Previously it was easy to accidentally swap departure and arrival times places when adding support for new endpoints. This PR fixes that issue by merging them both into one time_info variable.

Is this PR stuck or just waiting for reviews? @arnasbr

Is this PR stuck or just waiting for reviews? @arnasbr

@Donatas-L This is a bit of a confusing one. To fix the problem I created a lot of code duplication, and fixing the code duplication reintroduced the original problem. We thought that we're gonna make some breaking changes in the future and fix it properly, but this can just be merged IMO

Yes, I'd say that we can merge it


Defining an Enum

Enum variants, values
enums combined with custom types
traits implementations for enums
The Option Enum and its advantages

Estimated: 2 hours

I can work on this :)


add support for multiple instances

Codecov Report

Merging #4 into master will not impact coverage by -1.7%.

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
- Coverage   59.87%   58.17%   -1.7%
=========================================
  Files           7        7
  Lines        1934     2073    +139
  Branches      364      399     +35
=========================================
+ Hits         1158     1206     +48
- Misses        585      649     +64
- Partials      191      218     +27

Impacted Files
Coverage Δ

tests/mock_parodus.c
60.38% <100%> (+0.19%)
:white_check_mark:

src/libparodus_log.c
52.76% <58.62%> (-20.57%)
:x:

src/libparodus.c
65.8% <72.83%> (-4.2%)
:x:

tests/libpd_test.c
66.03% <90.9%> (-1.53%)
:x:

src/libparodus_queues.c
69.91% <ø> (+1.62%)
:white_check_mark:

src/libparodus_time.c
70.21% <ø> (+14.89%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44df8f...c585abe. Read the comment docs.


Update aws-core, http-client-spi, ... to 2.17.169

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.104 to 2.17.169.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #125.


Switch to native pytest in tests/driver

This continues the migration to native pytest started in #1387, #1423 and #1426.
pytest.mark.asyncio plays well with pytest.mark.parametrize while
run_async does not: this is why we're using that dependency in one
place. A future pull request will remove run_async completely.

Yes, it's expected. The first one is because you did not upgrade pytest-asyncio, and the second one is in a third-party dependency

Yes, it's expected. The first one is because you did not upgrade pytest-asyncio, and the second one is in a third-party dependency

Sorry for that. Upgrading pytest-asyncio took care of the dependency and resolved both issues.


Provide ability to track a bulk imported file

This is similar to #650 but different enough I thought it warranted a separate ticket.  The is related to the 1.x versions.
Basically the problem is being able to absolutely verify that a bulk imported file was successfully loaded into the system.  This requires being able to determine what the file is renamed to during the bulk import process.  Given that information we would be able to scan the accumulo.metadata table to find its matching entry.  We realize that there is a race condition here in which the GC could have removed it before verification could take place.  That situation could be handled by looking in the GC logs which is not very clean but doable.  We could of course monitor the master log to determine the file mapping as well but I was hoping for a cleaner solution.
One possibility is to actually include the name of the original file in the key or value within the file column family of the accumulo metadata.  Another possibility is to have the master pass back the list of file name mappings to the client.  The later could be achieved by writing a mapping file into the directory that was being imported or alternatively the failure directory.

Perhaps a trace mechanism akin to a scan trace is doable where we can trace the life of a file through the accumulo system.  That could include everything from initial mapping through to deletion.

I would like this ticket to stand as something to consider which is to create a mechanism akin to trace which allows us to track a file through the system; from bulk import through compaction through garbage collection.

#1480 added a TabletLogger class to centralize management of logging events for tablet activity. A similar logger utility class could be used for centralized tracking of log messages pertaining to file activity.


Add MIT License

Add license.rst.

Description

Motivation and Context

The project didn't have the required lines.
Types of changes

Documentation

Checklist:

[x] I have updated the documentation accordingly.
[] I have written unit tests

Thank you @2echoi for your PR, but @utahmechris just submitted a similar request that I already merged.


DIfference in Text rendering between Webkit and Firefox

Hi there! Another issue I stumbled upon.
This is a text rendered on webkit (safari & chrome looks the same):

This one is Firefox:

Using WebGL renderer. If I force Canvas renderer, the text is nice (but has a weird position). I don't understand why Firefox messes this up because PIXI.Text is supposed to be rendered on an off screen canvas (Context2D) either way right ?
I guess using PIXI.BitmapText would be an option at this point.
Thanks !
Update: Tested with BitmapText, and also with a different font, without success :'( Seems like a texture rendering issue ?
OSX Webkit:

OSX Firefox:

Is this on Firefox mobile ? Firefox for android generally blurs any text for me :/

Ah yeah sorry I forgot to precise: it's on Firefox Mac OS X. Though the same issue arise on mobile Webkit (Android & iOS) :(
I need to check if the font can be guilty here.

eeeewwwww! that looks nasty :/
almost looks like it rendered twice??

So I updated the main post, I tested with BitmapText, using 2 fonts, and also using a .png with the same text as a Sprite, the result is the same. I tested on Pixi v2 and the problem doesn't appear!
Even worse: I tested with a JPG with white background, and the same in PNG (so no transparency). Same result !

very strange indeed! If you could provide a fiddle / example I will take a look..
cheers man! :+1:

Gah, I found it... Removing renderer.antialias solve that thing...
Also if I keep antialias but remove my background (a 1920x1080 PIXI.Sprite), it also solve that thing...
Here is a test case : http://ayamflow.fr/pixi/text-render/

This is caused by the FXAA shader.  And is a classic issue with FXAA in general (the only issue really, in every other way FXAA is excellent).
Almost certainly you will find that your hardware/software configuration is unable to support native multisample anti aliasing and PIXI is therefore switching to FXAA.  Which for 99% of apps/games is a great choice (better than using native MSAA also, particularly performance-wise)
However, the algorithm, as clever as it is, just cannot deal with text properly when placed against a non transparent background.
Just a suggestion for the fantastic PIXI dev team.  There are several other nice shader based anti-aliasing algorithms out there.  None are as performant or as nice looking in general as FXAA but perhaps it would be worth adding another option for those that are going to be dealing with text frequently?

@gordyr Nice catch, will definitely look into the best way to solve this.

Is there a way I can apply the FXAA only on my images, not the text? I tried quickly to use it a a regular filter but it was messed up (the image looked like a Renaissance painting). Not sure how to use the uniforms I guess.

until I apply a fix - might be worth trying to add a background image or graphics object to the stage that covers the full scene.

IMHO the FXAA magic should be removed and the decision offloaded to the user, see my thoughts here

closing this guy for now as its more of an FXAA issue than a font one. Cheers! :+1:


⚠ ClamAV has degraded performance

In 900573a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 35f613a.


german umlaute

Thanks for the awesome library!
I'm using for transforming names into an appropriate email-address and noted some german umlaute aren't transformed correctly. So I added some additional replacements in my code:
		str = str.replace("ä", "ae"); // got "a"
		str = str.replace("Ä", "ae"); // got "a"
		str = str.replace("Ö", "oe"); // got "o"
		str = str.replace("ö", "oe"); // got "o"
		str = str.replace("Ü", "ue"); // got "u"
		str = str.replace("ü", "ue"); // got "u"
		str = str.replace("Ý", "y"); // got "u"

Not sure if it is intentional or not. Maybe these mappings only make sense in german and otherwise it's fine. Do you happen to know?
And some special signs for numbers:
		str = str.replace("Ø", "0"); // got "o" U+006F : LATIN SMALL LETTER O
		str = str.replace("ø", "0"); // got "o" U+006F : LATIN SMALL LETTER O

These seem more clear to me that they should actually get replaced by the number 0.

You are welcome :) All the praise actually goes to the orignal perl library by Sean M. Burke, text::unidecode.
Junidecode behaviour here is consistent with text::unidecode. Quoting Sean's docs:

In German, there's the typographical convention that an umlaut (the double-dots on: ä ö ü) can be written as an "-e", like with "Schön" becoming "Schoen". But Unidecode doesn't do that-- I have Unidecode simply drop the umlaut accent and give back "Schon".
I chose this not because I'm a big meanie, but because generally changing "ü" to "ue" is disastrous for all text that's not in German. Finnish "Hyvää päivää" would turn into "Hyvaeae paeivaeae"

I should provide a function to override the default settings, so that if you know that you are dealing mostly with german text, you can override its default behaviour.
For Ø and ø the correct mapping is "O" and "o" because they are letters, not numbers. Using them as "0" is as wrong as using "O" (letter O), so junidecode is doing the right thing here.
I'll try and remember to add character overrides, but feel free to open an issue about it, if you'd like.
I hope this helps.

Thanks for your reply. It makes sense to me now. I think a character override is not really needed because I can just do it myself before I use the junidecode function to replace the remaining characters.


LMB-588 | Redesign legislatuur page

Description
The legislatuur got a new design and we need to implement it.
How to test
Look at the descirption in the ticket and the figma design to make sure I did not miss anything.
Attachments

The beleidsdomeinen are not editable in the mandataris new form. cc: @bfidlers


How do I create my own store

I'm using Sea-ORM for a project of mine and I wanted use axum-login to handle authentication. I'm using postgres as the database so I know I can use the postgres feature. But I was wondering if I can create my own store using Sea-ORM. If so, how would I go about doing that?
I tried implementing it on my own using memory_store.rs and sql_store.rs as examples but the compiler keeps complaining about AuthUser not being satisfied for my User struct (even though I believe I've implemented it). Can you give me some pointers?
Thanks.

I'm not too familiar with SeaORM but I believe it uses sqlx under the covers.
Can you share an example so I can take a closer look?

after struggling a bit to get my own store working, i just recently got it working with Sea-ORM. here's my store, hope it helps you. let me know if you need anything clarified! also, i've been on and off with rust over the years, so the code itself might not be greatest!
use axum::async_trait;
use axum_login::{secrecy::SecretVec, AuthUser, UserStore};

use ba_core::{sea_orm::DatabaseConnection, Query};

type Result<T = ()> = std::result::Result<T, eyre::Error>;

#[derive(Debug, Clone)]
pub struct TestUser {
    pub id: String,
    pub password: String,
}

impl<Role> AuthUser<Role> for TestUser
where
    Role: PartialOrd + PartialEq + Clone + Send + Sync + 'static,
{
    fn get_id(&self) -> String {
        self.id.clone()
    }

    fn get_password_hash(&self) -> axum_login::secrecy::SecretVec<u8> {
        SecretVec::new(self.password.clone().into())
    }
}

#[derive(Debug, Clone)]
pub struct TestUserStore {
    conn: DatabaseConnection,
}

impl TestUserStore {
    pub fn new(conn: &DatabaseConnection) -> Self {
        Self { conn: conn.clone() }
    }
}

#[async_trait]
impl<Role> UserStore<Role> for TestUserStore
where
    Role: PartialOrd + PartialEq + Clone + Send + Sync + 'static,
{
    type User = TestUser;

    async fn load_user(&self, user_id: &str) -> Result<Option<Self::User>> {
        // my user id is a Vec<u8>, so it's stored base64 encoded
        let id = base64::decode(user_id)?;
        let user = Query::find_user_by_id(&self.conn, &id).await?;
        match user {
            Some(u) => Ok(Some(TestUser {
                id: base64::encode(u.id),
                password: u.password.unwrap(),
            })),
            None => Ok(None),
        }
    }
}

Thank you @smorks ! This is exactly what I needed.
@maxcountryman Thanks for such a great library. It's been very useful.

you're welcome @mtelahun, and yes, thanks @maxcountryman for the library. it's working great! axum is fun!


[BUG] found 3 issues

hi, i got to some issues, hope those notes will help improve the development of RAiDER:
Issue 1: RAiDER expects non-existing function of dem_stitcher:
in dem.py:
from dem_stitcher.stitcher import download_dem as download_stitched_dem
there is no such function in currently available dem_stitcher (installed from conda-forge, but should equal github repository codes)
Issue 2: some bug in use of 'statevectors'
having S1 EOF file and a station list with heights (i.e. csv with Lat,Lon,Hgt_m columns), the following command:
raiderDelay.py --date 20211210 --time 17:00:00 --model ERA5 --statevectors ../S1A_OPER_AUX_POEORB_OPOD_20211230T121611_V20211209T225942_20211211T005942.EOF --station_file raider_station.list

ends up in errors:
2022-02-16 15:51:29,209 DEBUG Beginning DEM calculation
2022-02-16 15:51:29,233 DEBUG DEM height range for the queried region is 10.00-10.00 m
2022-02-16 15:51:29,234 DEBUG Lats shape is (1,)
2022-02-16 15:51:29,234 DEBUG lat/lon box is -20.544445/-20.544445/-175.390417/-175.390417 (SNWE)
2022-02-16 15:51:29,234 DEBUG Beginning line-of-sight calculation
Traceback (most recent call last):
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/losreader.py", line 148, in getLookVectors
    svs = np.stack(get_sv(los_type, time, pad), axis=-1)
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/losreader.py", line 213, in get_sv
    svs = read_txt_file(los_file)
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/losreader.py", line 395, in read_txt_file
    with open(filename, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'sv'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/bin/raiderDelay.py", line 12, in <module>
    parseCMD()
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/runProgram.py", line 198, in parseCMD
    _tropo_delay(new_args)
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/runProgram.py", line 210, in _tropo_delay
    (_, _) = tropo_delay(args_copy)
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/delay.py", line 165, in tropo_delay
    los, lengths = getLookVectors(los, lats, lons, hgts, zref=zref, time=time)
  File "/gws/smf/j04/nceo_geohazards/software/mambalics/lib/python3.8/site-packages/RAiDER/losreader.py", line 164, in getLookVectors
    'getLookVectors: I cannot parse the file {}'.format(look_vecs)
UnboundLocalError: local variable 'look_vecs' referenced before assignment

Issue 3: the request for weather models must be improved, especially in case of CDSAPI:
ok, that's not really a 'bug', but i think you may want to improve things, i.e.
first of all, it now contains the HRES, while ecmwf_api is sometimes less preferred source (as in my case).
second,
the requests should be done using whole set of requested epochs, not one-by-one, as the waiting time can be e.g. 1 request processed in hours (!)
basically, for cdsapi, one may just include parameter 'date' instead of the 'months, years,....', so this can be enough:
params = {
            "product_type": dataset_name,
            "{}".format(levType): 'all',
            "levtype": "pl",
            "param": var,
            "stream": "oper",
            "type": "an",
            "step": "0",
            "area": nwse,
            "format": "netcdf"}
params['date'] = list(dates.strftime('%Y-%m-%d %H:%M')) \
        if isinstance(dates, pd.core.indexes.datetimes.DatetimeIndex) \
        else list(dates)

i also recommend disabling warnings using:
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

(after import urllib3 )
OS Linux CentOS 7

Hi @espiritocz thanks for these comments! We are working on them; #339 should fix issue 1, #332 should fix issue 2. issue 3 is one we haven't addressed yet, so thanks for the suggestion! Hopefully these will get integrated soon.


Add static lib building for VS2005

Original issue 37 created by schuhschuh on 2010-08-16T10:30:33.000Z:
Our project, on windows using vs2005, needs to have all libs statically linked.
I met some problems when I tried to make a static lib building for gflags. The main issue seems that, for static lib build, there's no need to dllexport/dllimport anything. There's already the macro GFLAGS_DLL_DECL to take care of all methods exported in library for this purpose, but for DECLARE_VARIABLE/DEFINE_VARIABLE macro, dllexport/dllimport is hard-coded, which causes problem. Note that the problem doesn't show up for unit test, because all things are in one compile unit. To see the problem, one example is to compile google-glog lib with gflags, as static lib of cause, in vs2005, and the linker will complain. (btw, maybe a unit test case for this situation is needed).
Because of this, I intended to resolve it by adding 2 more macros, GFLAGS_VAR_DECLARE/GFLAGS_VAR_DEFINE, to control if we need dllexport/dllimport according to the build type(dll or lib). Also, I added 2 project files for static lib and static-link unittest, just like google-gflags does. The details are all in the attached patch. Note that I have to update all solution to vs2005 version, but I think it's easy to down-grade to vs2003 if you want to test. Also, I don't have resource to test if the patch affect linux build.
Hope that helps.
ps: sorry for my poor english, let code speaks...

This issue should be no longer relevant after the migration of the build system to CMake.


Add GitHub link to readme - Christina

Markdown to add a link:
[@yourusername](https://github.com/yourusername)

Markdown to add a link:
[@yourusername](https://github.com/yourusername)


Relative cursor based pagination not working

Hello,
I have implemented a Relative cursor based in my app but it is giving me an error in the next_page? and fetch_next_page like https://prnt.sc/q95sjp
My Shopify API gem version is "shopify_api (8.0.0)"
api_version = '2019-10'
'rails', '~> 5.2.3'
'shopify_app' , '>= 10.0.0'
Any insight?

@garethson @DrewMartin any insight here?

When I look at the class of the products in my tests, I see it's an instance of ShopifyAPI::PaginatedCollection but yours is an instance of Shopify::Kaminari::Collection. It looks like that's another pagination library. Without seeing all your code and poking through it, it looks like it's causing problems when used with the Shopify API

Hey @DrewMartin
Thanks for your insight :)
Yes, 'kaminari','shopify-kaminari' gem is creating an issue. I removed those two gems and rerun the query it's working fine.
But is there any solution that we can use both of them as we are making pagination using those two gems.
It is really helpful if you can.

I think that would be something that would have to be done in the shopify-kaminari gem as it's built on top of the shopify-api gem and is not something built or maintained by us. Just at a glance it seems that it's adding functionality for making paging using page param/offset easier, but that's exactly what we've removed. Is there anything else it's adding?

Ok thanks @DrewMartin. I'll contact to shopify-kaminari gem support.