Searchable snapshot blog

Description
Blog post for searchable snapshots GA
Issues Resolved
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

The attached image shows the value remote_storage being supplied to the storage_type parameter. It should be remote_snapshot.

@kolchfa-aws  Lets add the following

The scan time from the quip, so we can co-relate the statement it takes twice the time for the first search.
Section to clarify "When to use Searchable Snapshot"
Remove the column, single segment in the performance matrix.

Some clarifications will be helpful:

There is a mention of 36 million docs.  It would be helpful to note the doc size;  How much data is that in GB?
How much disk space is available on the nodes?
How much of that is allocated for snapshot restore?
What is the local:remote ratio if this is a cache implementation?
For the repeat scan (590 vs 641), is all the data resident locally, i.e., is this really not cached behavior?  What is the hit and eviction rate?
What does 1.5 ops/sec signify?  Where was this derived from?
There does not seem to be a long tail in latency.  The system does not seem to be under pressure.  Perhaps a different workload or a more constrained system will provide other insights
Why was stackoverflow chosen in particular?  It has only a 30 GB data set.  nyc_taxis has about 75 GB.  The latest version of OSB has an expand corpus feature that allows one to increase the corpus size to several hundreds of GB for http_logs
How many runs were carried out to verify repeatability?  What was the variance?
Would a time-series workload like http_logs be a alternative candidate, since users might query only recent data most often and a cache strategy will be illustrative?
What is the performance of searchable snapshots when there are other activities on the node, like indexing and/or search on non-snapshot indices?
How does this compare with tiered storage options and Serverless offerings?
If multiple nodes are used for searchable snapshots, does the feature scale evenly?

I didn't mean to click approve just yet so please ignore my approval above :) It doesn't seem that I'm able to revoke the approval since I'm not a maintainer here...

@gkamat Regarding your comments at a high level, the simple testing was done to show relative performance to a local index. The scroll-based scan is contrived but shows the impact of caching and not needing to fetch the data again if it has already been fetched. The nyc_taxis test does show the high latencies of remote fetch at the p99+ percentiles. The tests here are far from exhaustive but are meant to give a basic idea of the performance characteristics. Users will need to run tests against their own workloads to get more realistic data on how this feature will work for them. Do you think we should redo the testing here with a different dataset and testing strategy to introduce this feature?

@pajuric @krisfreedain The changes have been implemented, so this blog is ready to publish.


[release-0.44] fix vm restore of vm with runstrategy

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/retest


added new icon recommend-filled

Summary
Added new icon recommend-filled
GitHub Issue Link
https://github.com/kyndryl-design-system/shidoka-icons/issues/10
Figma Link
https://www.figma.com/design/ZNudJzPCnqRpzUEnDatcMb/Shidoka-Icon-Library?node-id=2056-6010&t=1A2i1NXSdT0hLI3F-1
Checklist

[x] Exported all SVG files using the Figma SVG Export plugin with the Monochrome and Duotone presets.
[x] Used Conventional Commit messages as outlined in the contributing guide.

[ ] Noted breaking changes (if any).
[ ] Identified deprecated features (if any).

Screenshots

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The dataset is 503.

I want to download 2D-3D Match Dataset but it is 503 now.
Thanks!
Best wishes!

Hi, please find the updated link here: http://hkust-vgd.ust.hk/2d3dmatch/

Hi, please find the updated link here: http://hkust-vgd.ust.hk/2d3dmatch/

Thank you very much! It helps me a lot.


quantile gives wrong gradient on Julia 1.6

On Julia 1.9 and Enzyme main (6692fad483dbe4002be9d254dae959c634d841c9) this works:
using Enzyme, Statistics
f(x) = sum(quantile([1.0, x], [0.5, 0.7]))
autodiff(Reverse, f, Active, Active(2.0))[1][1]

1.2

But on Julia 1.6.7 it gives the wrong answer:
0.7

autodiff(Forward, f, Duplicated(2.0, 1.0))[1] also gives 0.7.
A possibly simpler variant: sum(quantile([1.0, x], 0.7)) gives the correct 0.7 on both versions but sum(quantile([1.0, x], [0.7])) gives 0.7 on Julia 1.9 (correct) and 0.0 on Julia 1.6 (incorrect).

Looks like the primal computation itself got messed up:
julia> autodiff(Forward, f, Duplicated,Duplicated(2.0, 1.0))
(0.0, 0.0)

julia> f(x)=sum(quantile([1.0, x], [0.7]))^C

julia> x=1.0
1.0

julia> quantile([1.0, x], [0.7])
1-element Vector{Float64}:
 1.0

julia> f(2.0)
1.7

julia> f(x)=sum(quantile([1.0, x], [0.7]))
f (generic function with 1 method)

using Enzyme, Statistics

Enzyme.API.printall!(true)

@inline function myquantile(v::AbstractVector, p::Real; alpha::Real=1.0, beta::Real=alpha)
    n = length(v)

    m = alpha + p * (one(alpha) - alpha - beta)
    aleph = n*p + oftype(p, m)
    j = clamp(trunc(Int, aleph), 1, n-1)
    γ = clamp(aleph - j, 0, 1)

    if n == 1
        a = v[1]
        b = v[1]
    else
        a = v[j]
        b = v[j + 1]
    end

    return a + γ*(b-a)
end

function f(x)
    v = [1.0, x]
    return first(map(x->myquantile(v, x, alpha=1., beta=1.), [0.7]))
end

@show f(2.0)
@show autodiff(Forward, f, Duplicated,Duplicated(2.0, 1.0))

This turns out to be a bug in the attributor which changes a store double ... into a store double undef
https://godbolt.org/z/Pa7Eejcq4
@jdoerfert any insights here?

The bug appears to occur in LLVM 11 (above) and 12 (https://godbolt.org/z/YehKx37h8), but not 13+

This is effectively fixed by disabling the attributor in https://github.com/EnzymeAD/Enzyme.jl/pull/986 for lower LLVM versions, but is still quite unsatisfying. Either way closing as now resolved and the attributor bug is independent of Enzyme.jl


friarbird, drivellers

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,f]

/trunk merge


pypy{,3}: use openssl_1_1

Motivation for this change
Per #80746. I haven't actually checked that this builds yet, so don't merge!
"We now support building PyPy with OpenSSL 1.1 in our built-in _ssl
module, as well as maintaining support for previous versions."
-- https://pypy.readthedocs.io/en/latest/release-pypy2.7-v5.6.0.html
@GrahamcOfBorg build pypy pypy3
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pypy pypy3

Well, it timed out on ofborg, but I've verified that pypy{,3} build, so this should be about ready for merging.

They build for me locally.  I can try something else as well, if it's easy to do.

Not sure about good stress tests for PyPy in general, but building nextpnr should exercise it a a fair bit through use of icestorm; those are the packages I maintain so they're what prompted this update.

nextpnr also built for me, neko-san.   I suppose I won't merge yet to give others some time to react?


MINOR: Updated StreamTableJoinIntegrationTest to use TTD

The StreamTableJoinIntegrationTest is a known flaky test. This PR converts the StreamTableJoinIntegrationTest to use the ToplogyTestDriver which will eliminate the flakiness.
Also, note that the StreamTableJoinIntegrationTest extends the AbstractJoinIntegrationTest class.  There are two other tests (StreamStreamJoinIntegrationTest and TableTableJoinIntegrationTest that also extend AbstractJoinIntegrationTest.  These tests will also get coverted to use the TTD in a follow-up PR soon.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @vvcephei and @ableegoldman for review.

Retest this, please.

Merging, despite on flaky test failure (https://issues.apache.org/jira/browse/KAFKA-7940)

Merging, despite on flaky test failure
So begins the reign of terror of John the Committer

cherry-picked to 2.4


AzureFrontDoor tags works at Azure Firewall

[Enter feedback here]

It seems that we cannot use AzureFrontDoor tag in Azure Firwall,however we can find those tags in Azure Firewall. And I were able to confirm that AzureFrontDoor.Frontend tag works in my lab. Could you please double check tags and fix this document? Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08217244-82bb-13b5-46f7-454801d8f865
Version Independent ID: 4a8b0a32-bf57-7544-c60d-6b7f250c4477
Content: Azure service tags overview
Content Source: articles/virtual-network/service-tags-overview.md
Service: virtual-network
GitHub Login: @mbender-ms
Microsoft Alias: mbender

You can find tags at Azure Firewall Network Rule. I have tested AzureFrontDoor.Frontend tag and it works.
BTW,in my knowledge, I cannot image the scenario that we should use AzureFrontDoor.Backend tag at Azure Firewall Network Rule to allow the outbound traffic.

@donghui-wu777, thank you for your feedback. We'll review this and get back to you shortly!

Hi @donghui-wu777 , I got an update from our Product Group.
There is some mismatch between the tags documented and the tags supported.
This is because our PG is still working on them.
There will be a public announcement once they are globally available, and we will update the documents accordingly.
In the meantime, we request you not to use them in a Production environment.
However, you may continue to use the tags for Test and QA.
I shall close this thread, for now.
In case there are any follow-up questions, do let us know.
Thanks,
Kapil


builds fail due to missing components on non tier 1 platforms using the default profile

Problem
On platforms that don't have rustfmt and/or clippy, packages that use a rust-toolchain file that contains a toolchain that isn't already present on the host machine will fail because cargo does not call rustup with the --force option. e.g.
$ rustup toolchain install nightly-2019-10-02-powerpc64le-unknown-linux-gnu
info: syncing channel updates for 'nightly-2019-10-02-powerpc64le-unknown-linux-gnu'
info: latest update on 2019-10-02, rust version 1.40.0-nightly (702b45e40 2019-10-01)
error: some components unavailable for download for channel nightly-2019-10-02: 'clippy', 'rustfmt'
If you require these components, please install and use the latest successful build version,
which you can find at <https://rust-lang.github.io/rustup-components-history>.

After determining the correct date, install it with a command such as:

    rustup toolchain install nightly-2018-12-27

Then you can use the toolchain with commands such as:

    cargo +nightly-2018-12-27 build

This is problematic for 2 reasons. 1, it probably shouldn't happen at all unless the package actually depends on one of those tools, and 2, nothing in the above message says anything about --force being a thing, so it's not obvious how I can fix it. I had to ask on discord to figure that out.
$ rustup --version
rustup 1.20.2 (13979c968 2019-10-16)

So I think the right fix here is that if rustup decides to install a toolchain because it's missing (e.g. from an override) then we should force the installation so that it's more likely to succeed.
This ought to be a fairly small job to write (there're three sites which call install_from_dist() in the config.rs::Cfg code, and the one in update_all_channels() should be left alone.  As such there are two sites to amend a boolean.
The difficulty will be in devising a nice set of tests to verify that this works.  I'd be happy to mentor someone through this and I should be contacted on Discord if you want to help.

Friendly note: gonna tinker to try a fix. Will either open a PR or ask questions on Discord if stuck.


Add url_for_self() function to reference current endpoint

It's often useful to reference current endpoint, sometimes modifying some of arguments. For example, imagine some generic item viewer application which shows items from different sources:
@app.route("/<source>/<item>")
def item(source, item):
    return render_template("item.html")

This item from another source
Different item from the same source

Currently, request.endpoint and request.view_args may be used to construct such urls, but it's cumbersome if done generic way:
This item from another source
Different item from the same source

So I propose to add url_for_self() function which does it in simple way. I've implemented it like this for myself:
def url_for_self(**args):
    return flask.url_for(flask.request.endpoint, **dict(flask.request.view_args, **args))

app.jinja_env.globals['url_for_self'] = url_for_self

This simplifies above mentioned template code into much more readable:
This item from another source
Different item from the same source

Note that this allows both adding, modifying and clearing (with foo=None) parameters.

I'm -1 on this. If you need this, it's obviously an easy thing to implement.

Yes, I don't see any saving in typing there.

FWIW I've used this copy-pasta a few times

Thank you, Azariz. It worked for me by adding _external=true
Ex:


Remove heading and content for More related material...

Removed the use of More related material. NavBoxes will only be used on the Landing Page an not in doc sets..


SBT plugin: return non zero code when trying to run nonexistent simulation

The environment:
OS: Ubuntu 16.04.6 LTS
Scala: 2.13.4
Gatling: 3.5.1
SBT: 1.4.7
Gatling-sbt-plugin: 3.2.1
Running methods: Travis CI, Gitlab CI, locally in sbt
The steps

Create any Gatling project in sbt: here's the example which has Travis CI where you can see the bug in action.
Run sbt 'gatling:testOnly <simulationName>' with literally any simulation name that doesn't exist.

The problem
See the run.
Current result:
[info]   Compilation completed in 13.51s.
[info] done compiling
[info] Simulation(s) execution ended.
[info] No tests to run for Gatling / testOnly
[success] Total time: 21 s, completed Feb 1, 2021, 12:16:41 PM

The command sbt 'gatling:testOnly computerdatabase.NonexistentSimulation' exited with return code 0.
Expected result:
The command sbt 'gatling:testOnly computerdatabase.NonexistentSimulation' exited with non zero return code as it's clearly not a successful run.

Hello
contributions welcome!

@Isammoc gtling-sbt is based on sbt's test framework. Do you know if we have any way to crash if there's no detected test classes?

First time I navigate in this code, so I'm not sure what I see, yet.
Indeed, we do have a GatlingFramework that extends sbt.testing.Framework.
First, we should ensure that we do have a taskDef argument in GatlingRunner.scala#L32
Not tested, but I think we do have a taskDef with the NonExistentSimulation className.
And the className should be given in a taskDef in GatlingTask.scala#L44-L45
We manage status code in this, perhaps should we have more fined grain in our process.
If there is no class provided => as currently, ie: simulation if it's alone or ask for user to choose.
If there is a className provided => if no matching in the simulation list, return an error.
But I'm concerned by this behavior generally speaking. Should we really fail in that case?
Let's a root project we 2 submodules subA and subB.
When we execute gatling:testOnly subA.simulation1 for a simulation that only exists in subA submodule, we expect that sub1.simulation1 is ran correctly and no other error will interfere.
But if change the behavior as requested in this issue. The root submodule that aggregates both subA and subB will dispatch the same task to both submodules, and will aggregate the result (one success for subA and ... one error for subB because the simulation does not exist in subB)
I don't think this behavior is suitable either.

Same explanation as #4105. This is idiomatic sbt test framework. testOnly takes a pattern and doesn't fail when no tests are executed.


Updated CONTRIBUTING.md

Updated CONTRIBUTING.md to reflect close coordination with schemas and server projects,
in preparation for more significant upcoming change to compliance suite.

+1

+1

+1


Add CSU program to eductaion table

Please add the following course that has been teaching systemc for the past 12 years:
University: Colorado State University ((https://www.engr.colostate.edu/~sudeep/teaching/hardwaresoftware-design-of-embedded-systems/)
Department: Embedded, High Performance, and Intelligent Computing (EPIC)
Country: USA
Course/Lectures: Hardware/Software Design of Embedded Systems

Thank you to report this issue and suggestion to improve systemc.org. It has been implemented.


Allow Setting Istio CA_ADDR independently

Gloo Edge Product
Open Source
Gloo Edge Version
v1.18
Is your feature request related to a problem? Please describe.
https://istio.io/latest/docs/reference/commands/pilot-agent/
The Istio documentation indicates that CA_ADDR defaults to the PROXY_CONFIG discovery address. Though it should be possible to specify a CA_ADDR that is unrelated to the discovery address.
However, Gloo helm forces these two separate fields to be aligned as it is driven from a single helm value.
Describe the solution you'd like
Part 1: Edge Helm Chart

Introduce an istioSpiffeCertProviderAddress property resolving the problem.
The default is kept as istioDiscoveryAddress to ensure backward compatibility.

Part 2: K8s Gateway API, Istio Auto-mTLS Support

The same solution from Part 1, should be applied

Describe alternatives you've considered
No response
Additional Context
No response
┆Issue is synchronized with this Asana task by Unito

This is still relevant to Snyk!


Inform on dashboard when on a later version than the official release

For people that are running a development or RC version that is later than the official release, this will display that on the dashboard version check.

Closing in favour of #1825 which is integrated with the latest master.


Configurable buffer size and flat compression for file entries for SBT

We noticed that in CI pipelines running sbt, substantial part of the time and resources are spent to compress and uncompress the artefacts.
This is very pronounced for the remote cache feature, which is a great way of sharing the stuff between several jobs in the same CI pipeline - however, actually storing and fetching artefacts is a heavy process.
It is aggravated by the fact that the CI pipelines usually are constrained by CPU and memory, and gzip compression is quite demanding on that. Our CI jobs could easily spend as much as half of the time pulling and pushing stuff from remote cache.
As the storage is cheap, reduced artefact size doesn't really add much of the value.
The proposed minimal change doesn't alter existing behaviour by default, but adds a way to override file copy buffer size and disable compression for the file entries created by SBT.

signed  CLA, please revalidate

We noticed that in CI pipelines running sbt, substantial part of the time and resources are spent to compress and uncompress the artefacts.

While that might be true:

Would calling setMethod turn off the compression?
Why not call setLevel on ZipOutputStream?
Would turning off the compression speed up the overall build time?

In general, parameterizing only via system property might end up creating untested code paths or worse, a build tool that behaves differently depending on the machine setup. For behavior that only affects the performance or UX it might be ok, but compression level hits a bit different, because creating a JAR is a major job of sbt.

@jacum Not sure if this is 100% relevant but sbt zinc serializes incremental compilation dependency data called Analysis with its own GZIP compression stream. Just want to confirm that the overhead is indeed on compression done with sbt io instead of Zinc's own compression.

Yea. This is also a good point, we recently introduce parallel gzipping, so maybe that could be affecting some environments in a negative way.

Thanks for paying attention!
All we wanted to achieve now is to prevent sbt pushRemoteCache from applying any gzip on the jars being created as cache artefacts.
Unlike jars published to repositories, the cached jars are short living anyway - in the scope of the pipeline - and trading tons of cpu and pipeline runtime spent on g(un)zipping isn't definitely worth a few saved megabytes of the cache size.
Hope to be able to share some figures with you soon.

Thanks for paying attention!
All we wanted to achieve now is to prevent sbt pushRemoteCache from applying any gzip on the jars being created as cache artefacts.
Unlike jars published to repositories, the cached jars are short living anyway - in the scope of the pipeline - and trading tons of cpu and pipeline runtime spent on g(un)zipping isn't definitely worth a few saved megabytes of the cache size.
Hope to be able to share some figures with you soon.

Will look into it. I think maybe we can add a settings key at sbt side either called enableCacheCompression or cacheCompressionLevel.

@Friendseeker your insights are much appreciated.
We run quite a lot of CI workloads and sbt does seem to be the CPU hog.
gzip-free local cache should definitely relieve this source of the load.


test-integration depends on the helm tool

How to categorize this PR?

/area robustness
/kind bug
What this PR does / why we need it:
This PR fixes isse #10441. It makes the make target test-integration independent from side-effects (e.g. executing other targets that depend on helm before).
Which issue(s) this PR fixes:
Fixes #10441
Special notes for your reviewer:
Release note:

NONE

Thank you!
/lgtm
/approve

/cherry-pick release-v1.102

/cherry-pick release-v1.101

/cherry-pick release-v1.100

/ok-to-test


Android Basics: Fragments Navigation component

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-fragments-navigation-component?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-fragments-navigation-component#0
In which task and step of the codelab can this issue be found?
Chapter 8 Using the Navigation Graph. Under the subheader "Use FragmentContainerView in MainActivity" step 3
Describe the problem
There is a typo of an XML attribute that has effects along the line.
The codelab text says - add an attribute called app:navHost and set it equal to "true". However I am sure it meant app:defaultNavHost.
I think it is an error because

when I try to build I get an error pointing to that
in the code snippet of what you should write, it says  app:defaultNavHost  and not app:navHost
The solution code also says  app:defaultNavHost  and not app:navHost

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@pokumars
Thank you so much for reporting this issue. This is fixed and will be published soon.


BUG: Add missing Python string prefix in wrapping warning

The prefix was accidentally removed during refactoring of the Python wrapping in 53e4fe066fa0955a2a4ee5899b400477ff93f198.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

/AZP run ITK.Linux

The prefix was accidentally removed during refactoring of the Python wrapping in 53e4fe066fa0955a2a4ee5899b400477ff93f198

Looking at its diff, it seems to me that commit 53e4fe066fa0955a2a4ee5899b400477ff93f198 did not remove the prefix (f) from "as {cl}":
             message = (
-                "Template %s\n already defined as %s\n is redefined " "as %s"
-            ) % (normFullName, self.__templates__[normFullName], cl)
+                f"Template {normFullName}\n already defined as {itkTemplateBase.__all_templates__[normFullName]}\n is redefined "
+                "as {cl}"
+            )

But I agree, it should be added anyway 😺


[FLINK-22250] flink sql parser module ParserResource.properties lack createSystemFunctionOnlySupportTemporary describe message.

…createSystemFunctionOnlySupportTemporary describe message.

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

What's the problem if we don't add it?

What's the problem if we don't add it?

There are two descriptions on the original file that have been added to the ParserResource.properties, and the calcite official also added the corresponding CalciteResource.properties file to its own CalciteException.


Add Member button is disabled for Cluster Owner which is an Standard User

What kind of request is this:
bug
Steps to reproduce:

Install Rancher
Create three Standard Users with the local admin
Logout from the admin account and login as the one of the Standard Users account
Create a cluster (I used an RKE DO)
Once the cluster is created click Edit -> Member Roles

Result:

Other details that may be helpful:
If I navigate to Cluster -> Members I can add users to the cluster in that page.
Reproducible in v2.4.5
Environment information

Rancher version: master-head (07/21/2020) c289ff7de
Installation option: single and HA

Cluster information

Cluster type: Infrastructure Provider - RKE DO
Machine type: VM
Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-16T00:04:31Z", GoVersion:"go1.14.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

On 2.4.5 and on 2.4-head commit id: b7ab53e95

Create a DO/custom cluster as a standard user - user1
Click on edit cluster --> Members --> "Add Member" button is enabled. User1 is able to add members and save.

Reproducible in master-head (07/24/2020) 80542c31b single install.

Not sure if this is a UI issue or not. The code where all of this logic resides has not been updated since late 2019 (in master and dev2-4) so if it was a UI issue I would suspect this would also be reproducible in 2.4.5 at least.

When logged in as a standard user the /v3/users call only returns the currently logged in user. If you log back in as the admin and give that standard user who created the cluster Manage Users permissions you can then add members to the cluster. This seems correct to me but either way it doesn't appear to be a UI issue.

I don't see this work in 2.4.5 either.
Adding members works when tried from the Members page, because on that page the search box is always enabled and UI makes search principals API call.
But on edit cluster, it looks like only users with "Manage Users" permission can add the users (same as what @westlywright said)

@izaac @sowmyav27 Can you confirm it's not a blocker anymore if we can reproduce it in 2.4? After removing the blocker label i will move this out of 2.5

Original issue mentioned here is also seen on 2.4.5.


Display Loss  during Optimization

Hi there,
This might sound silly but how do I manage to display the loss at each iteration of the optimization process?

Thanks a lot ! Does seem like a pretty byzantine process just to print the ELBO.

It does a lot more than just printing the ELBO :) Take a look at the example notebook.
The process is a bit byzantine. This is partly the nature of using Tensorflow -- the ELBO is never returned to Python during optimisation, and partly due to that it can be easy to add a quick fix of logging optimisation, but hard to do things in general. The gpflow-monitor tool does things in general.

Hi,
I haven't tried this in GPflow 1.0, but previously if you used the ScipyOptimizer you can pass the disp=1 argument to print the intermediate loss values.


Security Group Updates are Broken.

Description
Due to the lifecycle rule of create_before_destroy, updating the inbound security group rules is extremely unstable. Somertimes, the apply goes through and changes are reflected. Other times, the apply errors out on "duplicate security groups" and the state file gets corrupted (the ingress and egress resources are removed from the state file).
Versions

Module version [Required]: 7.2.2

Terraform version: 1.2.4

Provider version(s):  ">= 4.5"

Reproduction Code [Required]

Steps to reproduce the behavior:

Create a postgres RDS aurora instance
Change the inbound security group rule via the allowed_cidr_blocks variable.
Change the inbound security group rule again after step 2.
View the state file, the ingress and egress resources are gone, and the apply from step 3 should error out

This sometimes works, sometimes doesn't, due to the unstable nature of "create_before_destroy"
What is the reason to use "create_before_destroy" for the security group? AFAIK aren't the updates made inplace anyways?

@alexandros-genies - I'm a little unclear about your steps 2 and 3; it sounds like you're talking about making one change, applying, then making another change, and applying.
I see the duplicate rule problem with just a single change to the allowed_cidr_blocks list.
Plan:
  # module.vpc-tenant[0].module.aurora.module.cluster-primary.aws_security_group_rule.cidr_ingress[0] must be replaced
+/- resource "aws_security_group_rule" "cidr_ingress" {
      ~ cidr_blocks              = [ # forces replacement
            # (1 unchanged element hidden)
            "<IP_ADDRESS>/20",
          - "<IP_ADDRESS>/22",
            "<IP_ADDRESS>/20",
            # (15 unchanged elements hidden)
        ]
      ~ id                       = "sgrule-2304924885" -> (known after apply)
      + security_group_rule_id   = (known after apply)
      + source_security_group_id = (known after apply)
        # (7 unchanged attributes hidden)
    }

Apply:
Error: [WARN] A duplicate Security Group rule was found on (sg-0200d25e93a96964b)

I believe this is the same issue that the eks module has:
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/984
the fix seems to be creating a separate rule for each CIDR block in the allowed_cidr_blocks list.  Maybe the same fix would help the rds-aurora module?

Looks like somebody has already thought of this, based on the comment in the code here:
https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/blob/master/main.tf#L348

@jpriebe Yes! that's exactly it.
If you apply a change to a security group ingress rule, and change the rule afterwards to apply again, you'll (sometimes) run into the duplicate security group rule issue.
That's good to see there is a todo to fix this issue.

this will be resolved soon in #335

So our solution was to apply the CIDR range security group rules outside of the module. The module outputs the security group ID, so you can put your own rules in CIDR by CIDR.
I converted the list to a map, so that order is not important, otherwise you will have large numbers of rules being rewritten if you reorder the list in any way.

This issue has been resolved in version 8.0.0 :tada:


Revoke Keys with reason

I have the requirement to accept tokens signed with expired key(resulting in key beeing revoked). This can still be done with your awesome library. But I also wan't accept tokens signed by key expicit revoked by admin user. Currently I can't distinguish both kind of revokation.
I've made some possible extension to enable this by letting me specify the reason for revokation so I can prevent to use some revoked keys I have "blacklisted"
Are you interested in such extension or would you suggest other some solution for my problem.
Thank you

Hi,
thank you for your prompt feedback.
In my scenario I have some long time range validity tokens already issued. I want to accept this tokens even the key is already rotated and revoked. On the other side I would like to revoke specific key manually (by allow security administrator to do so). Those tokens should not be acceptable anymore.
To summarize, I want to distinguish keys expired naturally way by time rotation from those that were revoked explicitly.
I have found the easy way to additionally provide the Reason for revokation (the field was already there at least by DataProtection Store). So the extension was to add additional field "RevokedReason" to KeyMaterial and give possibility to revoke a key with optionally revokedReason parameter. This parameter defaults to same value that was already used. I have also added additional Unit Tests keeping same structure. All existing functionality remains without breaking changes.
If you don't mind, I can share the change by pull request.

Great, go ahead and make pr!

Added at pr #38


Checkpoint save location and disk space

@sid @StellaAthena
Suggested save locations for checkpoints. I have also increased disk space so more checkpoints can be saved

@sdtblck @StellaAthena when you kill a cluster, can you use bash kubernetes/kill_k8s.sh foo as this will also delete the mount drive associated with it. Otherwise we might start to have loads of dangling mounts that aren't being used

lgtm :rocket:


Centralize openrewrite configuration with clientcore

Update usage to make it a plugin that users:
Add this plugin to your POM
Run it
Validate code changes
Remove the plugin / report bugs if found


[UT] Fix CreateLakeTableTest in shared-data mode (2/3)

remove all mocked objects, use real code to test the LakeTable

Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[X] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergifyio backport branch-3.1


Right clicking an entry removes checkmark from all others

A scenario:

Go through your applications list with checkbox mode enabled
Checkmark (possibly a lot of) applications to uninstall
See an entry you want to know more about
Right click entry to open it in explorer or search for it in the internet
This just removed the checkboxes from all entries you had marked before. Ouch.

This cant be intended behavior, right?

This happens if you right click an entry that is not checked, it will check that entry if you right click it. I guess I could change it so that it will add the item to the selection but that's probably also not going to be entirely "as expected".


Errors on build and launching the language server

Thanks for the hard work! ❤
I got the following error while running the command pnpm run build, even though the CI passes. 😕
❓ Error 1
> @ build C:\Users\xxx\workspace\grammarly-language-server
> rollup -c && node scripts/build-web-extension.mjs

packages\grammarly-languageclient\src\index.ts → packages/grammarly-languageclient/dist/index.d.ts...
packages/grammarly-languageclient/src/protocol.ts(23,11): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
packages/grammarly-languageclient/src/protocol.ts(26,13): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
packages/grammarly-languageclient/src/protocol.ts(29,13): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.

[!] (plugin dts) Error: Failed to compile. Check the logs above.
...

but once I have removed the console.log in packages/grammarly-languageclient/src/protocol.ts then it built correctly!
...
        return async (...args: unknown[]): Promise<unknown> => {
          //console.log('Request:', property, ...args)
          try {
            const result = await client.sendRequest(`$/${property}`, args)
            //console.log('Response:', property, result)
            return result
          } catch (error) {
            //console.log('Error:', property, error)
            throw error
          }
...

then I tried to start the server, another error occurred.
❓ Error 2
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '../dist/index.cjs'
Require stack:
- C:\Users\xxx\workspace\grammarly-language-server\packages\grammarly-languageserver\bin\server.js
←[90m    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:778:27)←[39m
←[90m    at Module.require (node:internal/modules/cjs/loader:1005:19)←[39m
←[90m    at require (node:internal/modules/cjs/helpers:102:18)←[39m
    at Object.<anonymous> (C:\Users\xxx\workspace\grammarly-language-server\packages\grammarly-languageserver\bin\server.js:3:16)
←[90m    at Module._compile (node:internal/modules/cjs/loader:1103:14)←[39m
←[90m    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)←[39m
←[90m    at Module.load (node:internal/modules/cjs/loader:981:32)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:822:12)←[39m
←[90m    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)←[39m {
  code: ←[32m'MODULE_NOT_FOUND'←[39m,
  requireStack: [
    ←[32m'C:\\Users\\xxx\\workspace\\grammarly-language-server\\packages\\grammarly-languageserver\\bin\\server.js'←[39m
  ]

And realized the dist/index.cjs does not exists in the language server. 😖

I forgot to update bin/server. Will fix.


Add Error handling when KnitServer hasnt been started

https://github.com/Sleitnick/Knit/blob/56fd149deb97ada007c995936da9f21eec11ed92/src/Knit/KnitClient.lua#L29
KnitClient stops if KnitServer isnt started, this should instead error or add a some other design.
This means if the server isnt started or the serverfolder is destroyed all other clients wont start.
I think it should error instead, and KnitClient.Start() should return a rejected Promise.

Using Start, KnitClient would yield until the server is ready and loaded. Immediately returning an error can break many cases where the client loads faster than the server. Although one can argue there should be a timeout until error... no. Something like this could determine if a user is even able to play your game. Maybe a warning could suffice for unusual loading times, but technically that is already supplied by a infinity yield from WaitForChild.

I agree with @ok-nick that WaitForChild will bring in a warning. However, there could be a case of adding something like an attribute to indicate the server's current startup state to the client.


Bug: Slow right click panel

Description
When I right-click on files, the panel appears without any problems, but when I right-click on a folder, the panel freezes for a few seconds and then lets me select options. Also, a couple of times when I right-click on different files and folders to check the speed at which I can interact with the panel, Files suddenly closes. If I put the shell extensions without a submenu, I see that until they load, I can't interact with the panel, so I don't know if that's what's slowing it down.
Steps To Reproduce
1-Right click on a folder
2-Locked context menu panel
3-Wait several seconds for the shell extensions to load
4-Context menu panel unlocked
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.4317
User ID
f9452645-268a-402c-8a07-991100aa7da4
Log File
2024-11-05 12:26:51.1050|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-05 12:26:53.2920|Information|Adding cloud provider "OneDrive" mapped to D:\Diego\OneDrive
2024-11-05 12:26:54.0150|Information|Running on ARM: False
2024-11-05 12:26:54.0942|Information|Drive added: C:, Fixed
2024-11-05 12:26:54.2765|Information|Drive added: D:, Fixed
2024-11-05 12:26:57.3088|Information|SIDELOAD: Checking for updates...
2024-11-05 12:26:58.0661|Information|SIDELOAD: Current Package Name: Files
2024-11-05 12:26:58.0664|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 12:26:58.0666|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 12:26:58.0668|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 12:26:58.0670|Information|SIDELOAD: Update found.
2024-11-05 12:26:58.0671|Information|SIDELOAD: Starting background download.
2024-11-05 12:27:01.7752|Information|Download time taken: 00:00:03
2024-11-05 12:34:40.1734|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-05 12:34:42.4555|Information|Adding cloud provider "OneDrive" mapped to D:\Diego\OneDrive
2024-11-05 12:34:42.7800|Information|Drive added: C:, Fixed
2024-11-05 12:34:42.8689|Information|Drive added: D:, Fixed
2024-11-05 12:34:44.8958|Information|SIDELOAD: Checking for updates...
2024-11-05 12:34:45.7185|Information|SIDELOAD: Current Package Name: Files
2024-11-05 12:34:45.7187|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 12:34:45.7189|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 12:34:45.7190|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 12:34:45.7191|Warning|SIDELOAD: Update not found.
2024-11-05 12:35:51.5075|Warning|System.Runtime.InteropServices.COMException (0x800705B4): Se devolvió esta operación porque se agotó el tiempo de espera. (0x800705B4)
at Vanara.PInvoke.Shell32.IShellLinkW.Resolve(HWND hwnd, SLR_FLAGS fFlags)
at Vanara.Windows.Shell.ShellLink.LoadAndResolve(String linkFile, SLR_FLAGS resolveFlags, HWND hWin, UInt16 timeOut)
at Files.App.Utils.Storage.FileOperationsHelpers.ParseLinkAsync(String linkPath)
2024-11-05 12:35:51.5234|Information|Running on ARM: False
2024-11-05 12:38:34.1832|Warning|System.Runtime.InteropServices.COMException (0x800705B4): Se devolvió esta operación porque se agotó el tiempo de espera. (0x800705B4)
at Vanara.PInvoke.Shell32.IShellLinkW.Resolve(HWND hwnd, SLR_FLAGS fFlags)
at Vanara.Windows.Shell.ShellLink.LoadAndResolve(String linkFile, SLR_FLAGS resolveFlags, HWND hWin, UInt16 timeOut)
at Files.App.Utils.Storage.FileOperationsHelpers.ParseLinkAsync(String linkPath)
2024-11-05 12:38:40.7963|Warning|System.Runtime.InteropServices.COMException (0x800705B4): Se devolvió esta operación porque se agotó el tiempo de espera. (0x800705B4)
at Vanara.PInvoke.Shell32.IShellLinkW.Resolve(HWND hwnd, SLR_FLAGS fFlags)
at Vanara.Windows.Shell.ShellLink.LoadAndResolve(String linkFile, SLR_FLAGS resolveFlags, HWND hWin, UInt16 timeOut)
at Files.App.Utils.Storage.FileOperationsHelpers.ParseLinkAsync(String linkPath)
2024-11-05 12:38:40.9365|Warning|System.Runtime.InteropServices.COMException (0x800705B4): Se devolvió esta operación porque se agotó el tiempo de espera. (0x800705B4)
at Vanara.PInvoke.Shell32.IShellLinkW.Resolve(HWND hwnd, SLR_FLAGS fFlags)
at Vanara.Windows.Shell.ShellLink.LoadAndResolve(String linkFile, SLR_FLAGS resolveFlags, HWND hWin, UInt16 timeOut)
at Files.App.Utils.Storage.FileOperationsHelpers.ParseLinkAsync(String linkPath)
2024-11-05 12:42:39.3385|Information|SIDELOAD: Checking for updates...
2024-11-05 12:42:39.3856|Information|The app is being activated. Activation type: LaunchActivatedEventArgs
2024-11-05 12:42:39.6870|Information|Drive added: C:, Fixed
2024-11-05 12:42:39.7794|Information|Drive added: D:, Fixed
2024-11-05 12:42:40.0622|Information|SIDELOAD: Current Package Name: Files
2024-11-05 12:42:40.0625|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 12:42:40.0626|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 12:42:40.0627|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 12:42:40.0628|Warning|SIDELOAD: Update not found.
2024-11-05 12:48:26.5484|Information|The app is being activated. Activation type: FileActivatedEventArgs
2024-11-05 12:49:02.6825|Information|The app is being activated. Activation type: FileActivatedEventArgs
2024-11-05 12:54:54.3633|Information|The app is being activated. Activation type: FileActivatedEventArgs
2024-11-05 12:59:55.8345|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-05 12:59:56.4883|Information|Adding cloud provider "OneDrive" mapped to D:\Diego\OneDrive
2024-11-05 12:59:56.7715|Information|Drive added: C:, Fixed
2024-11-05 12:59:56.8805|Information|Running on ARM: False
2024-11-05 12:59:56.9156|Information|Drive added: D:, Fixed
2024-11-05 12:59:59.0194|Information|SIDELOAD: Checking for updates...
2024-11-05 12:59:59.5675|Information|SIDELOAD: Current Package Name: Files
2024-11-05 12:59:59.5678|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 12:59:59.5680|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 12:59:59.5681|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 12:59:59.5682|Warning|SIDELOAD: Update not found.
2024-11-05 13:01:33.5926|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-05 13:01:34.0396|Information|Adding cloud provider "OneDrive" mapped to D:\Diego\OneDrive
2024-11-05 13:01:34.5441|Information|Drive added: C:, Fixed
2024-11-05 13:01:34.6156|Information|Running on ARM: False
2024-11-05 13:01:34.6464|Information|Drive added: D:, Fixed
2024-11-05 13:01:36.6126|Information|SIDELOAD: Checking for updates...
2024-11-05 13:01:37.0714|Information|SIDELOAD: Current Package Name: Files
2024-11-05 13:01:37.0717|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 13:01:37.0719|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 13:01:37.0720|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 13:01:37.0721|Warning|SIDELOAD: Update not found.
2024-11-05 13:13:35.1098|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-05 13:13:35.7703|Information|Adding cloud provider "OneDrive" mapped to D:\Diego\OneDrive
2024-11-05 13:13:36.0749|Information|Drive added: C:, Fixed
2024-11-05 13:13:36.2044|Information|Running on ARM: False
2024-11-05 13:13:36.3728|Information|Drive added: D:, Fixed
2024-11-05 13:13:38.3381|Information|SIDELOAD: Checking for updates...
2024-11-05 13:13:38.9960|Information|SIDELOAD: Current Package Name: Files
2024-11-05 13:13:38.9963|Information|SIDELOAD: Remote Package Name: Files
2024-11-05 13:13:38.9965|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-11-05 13:13:38.9967|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-11-05 13:13:38.9968|Warning|SIDELOAD: Update not found.

I already had the shell extensions in a submenu and I tried to remove them from the submenu to see if it would do something and that's when I realized that until that was loaded I couldn't interact with the panel.
No, I'm not using a column layout, I'm using the grid layout

Do you have a lot of options in the sub menu?

In the folders I have 11 options in the submenu, but in the submenu when I right-click on a .exe, for example, I have 14 and in this case it is not slow or takes a long time to load, it only happens in the folders.

Same happening for me
it takes a good 1-2 sec to show the right-click menu for a folder/file

Can you send a screenshot of the extensions? It's possible there is an extension that's only present for folders which is slowing down the menu,

Can you send a screenshot of the extensions? It's possible there is an extension that's only present for folders which is slowing down the menu,

below extensions are present in the folder where it takes time to right-click

rar
mkv hevc (1gb+ each too many)
folders
zip
1 or 2 txt

should i send a ss?

I meant the list of shell extensions for folders compared to files. This can help narrow down if there is a specific shell extension that's slowing down the menu. In any event, we're going to continue tracking this in #11112.

I meant the list of shell extensions for folders compared to files. This can help narrow down if there is a specific shell extension that's slowing down the menu on your device. In any event, we're going to continue tracking this in #11112.

not sure how to do " list of shell extensions for folders compared to files"

These are the differences I see when I open the context menu on an .exe and a folder:
EXE:
Nanazip, Notepad++, Unlock with File Locksmith, Notepad, Change name with PowerRename, Add to favorites, Fix compatibility issues, Unlock with File Locksmith (again?), Scan with Malwarebytes, Change name with PowerRename (again?), Restore previous versions and Pin to start menu.
Folder:
Nanazip, Unlock with File Locksmith, Open with Visual Studio, Search in Adobe Bridge, Restore previous versions, Change Folder Icon (from folderico program), Scan with Malwarebytes, Unlock with File Locksmith (again?) and Pin to start menu.

for EXE

for Folder

The duplicates are from PowerToys and I see them with Windows Explorer as well. Regarding Notepad++, I don't know what it has to do with it, because Notepad++ doesn't appear in the context menu of the folders, which is what slows it down, it only appears in other types of files.

My apologies, I thought the issue was only with files. Can you check if disabling PowerToys solves the issue?

It's because of Folderico, which allows you to have direct access to various icon libraries from the context menu. If I remove those libraries, the context menu for folders loads faster. The thing is that this doesn't happen with Windows Explorer, but I don't care about not having those libraries with quick access.

Thank you for the update. The reason you’re not experiencing the issue in File Explorer is because of its heavy caching. While Files does implement basic caching, it isn't as robust as what File Explorer offers. We’re actively exploring ways to improve caching in Files and will continue to monitor this issue in #11112.


Persistent ToC data stored in chunk

According to Persistent TOC data defining persistent-toc-filename as empty should embed the persistent toc into each chunk rather than using JavaScript referring to a centralized external file. But I can't get this working:

java -jar ... -s:../book.xml -xsl:/.../docbook.xsl chunk=index.html persistent-toc=true
This creates the default persistent-toc.html file being embedded by JavaScript.

Trying setting to an empty string by adding ...persistent-toc-filename=''  fails:
Error at xsl:apply-templates on line 24 column 55 of chunk-output.xsl:
  XTDE3365  Duplicate key in constructed map: {file:/home/goik/Downloads/tmp/...}
  In template rule with match="/" on line 20 of chunk-output.xsl
    invoked by xsl:apply-templates (tail calls omitted) at file:/home/goik/Downloads/docbook-xslTNG-2.4.1/xslt/docbook.xsl#347
In template t:docbook on line 163 column 32 of docbook.xsl:
    invoked by xsl:call-template (tail calls omitted) at file:/home/goik/Downloads/docbook-xslTNG-2.4.1/xslt/docbook.xsl#158
Duplicate key in constructed map: {file:/home/goik/Downloads/tmp/...}

persistent-toc-filename="''" (Two single inside double quotes) , ..='()' etc. will create corresponding filenames. Unfortunately I never get an embedded TOC to be browsed as local file:/... rather than in a web server context.

I'm aware of the difference between an empty string vs. an empty sequence but having no clue how to define this in my (Bash shell) context

The way to define it is with an expression: persistent-toc-filename="?()" but that's tedious and very non-obvious. For the next release, an empty string will also work.


Update 02_Routing.md

Seem like we need to add ‘#modelascontrollerroutes’ to the “After” block of myroutes, to be able to override the '' route to HomeController
Thanks for contributing, you're awesome! :star:
Please describe expected and observed behaviour, and what you're fixing.
For visual fixes, please include tested browsers and screenshots.
Search for related existing issues and link to them if possible.
Please read https://docs.silverstripe.org/en/contributing/code/

@eeerlend  We’re currently going through pull-requests that haven’t had much activity for a while to see what is still active and what now makes sense to be closed.
Are you going to be doing further work on this or would you prefer to now close this one?

It seems like there's going to be no further activity on this pull request, so we've closed it for now. Please open a new pull-request if you want to re-approach this work, or for anything else you think could be fixed or improved.


Begin/End Block Event support

Just code notes for https://github.com/cosmos/relayer/issues/568

Closing this PR.
The provider interface has been removed from Lens.
See: https://github.com/strangelove-ventures/lens/issues/85


chemitypies, academised

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,c]

/trunk merge


Icons - Stroke width

It's unclear for me (reading the docs) if and how I can change the stroke width for the hero icons.
Thanks in advance!

I don't think you will be able to do that as icons are bundled as CSS. You might want to take a look at https://github.com/nuxt-modules/icon instead.


Revert pub dependencies artifact to universal

issue_link
https://github.com/flutter/flutter/issues/100350#issuecomment-1074434539
Commit Hash
50f3e47
Impacted Users
Flutter devs
Impact Description
Flutter cli commands (so far just found with "test" but it could impact more than this one) when a user download the flutter sdk
Workaround
Build the flutter tool before running any commands (users that downloaded the sdk)
Risk
medium
Test Coverage
yes
Validation Steps
https://github.com/flutter/flutter/pull/100508#event-6280132871

Merged into beta.


How to map mouse event (x,y) to node position?

Hi. Sorry for asking the questions here instead of SO.
But could you please guide me how to map current mouse event position to target node position.
My motivation is that I want to add new node at the middle of the current pane (or dnd it).
I can zoom in/out, I can move pane but still want to add new element to the center.
Can you share example or code pointer?

In this example we are adding a node on click. You can use the project function of the useZoomPanHelpers to calculate the position https://reactflow.dev/docs/api/hooks/

Yes. It is exactly what I need. Missed it at docs. Thank you so much.


store: key not found error

Problem: currently, there is no easy way to distinguish "key not found" situation, from other KVStore errors.
Tasks:

[ ] create ErrKeyNotFound sentinel variable
[ ] properly handle badger.ErrKeyNotFound
[ ] properly handle "key not found situation" in da/mock package (after #146)

I'll give it a try, tell me what you think!


add support for UFOZ and fs-powered ufoLib

This patch enables loading/saving a defcon.Font from/to zipped UFO (*.ufoz) using the latest ufoLib (yet unreleased, master branch).
The save method has a new 'structure' keyword argument, which can be either "zip" or "package" (or a value from UFOFileStructure enum).
The Font has a new 'ufoFileStructure' read-only attribute that stores the original file structure from the UFOReader (or None if the font is created from scratch).
The rest of the patch is basically avoiding to use os.path interface, e.g. path separator is always "/" with pyfilesystem2.
I marked a few of the problematic spots with 'XXX'.

Grr.. Windows

There is a fundamental incompatibility between defcon's testForExternalChanges and the new UFOZ zipfile format. It's impossible for an external process to modify a UFO that is stored in a zip, because two processes can't modify the same zip file. I'll open a separate issue for that.

if UFOZ, should it just check the file mod time to see if it's later than what it knows, if so, it needs to reload? (thinking of other tool using the same UFOZ and then saving, you'd want to know that)

@benkiel you mean, in the main public method Font.testForExternalChanges only, right?
because the tests also call the private testForExternalChanges methods of the various sub-object (layerSet, layer, etc.), which are bound to fail with UFOZ.

the thing is, that method returns a dictionary describing the changes. With your proposal, you would like to return a boolean, True/False result.. i dont know. We need to think this through.
But I would like to merge this ASAP, since I've pushed ufoLib 3 today and now I worry that if we don't also push a defcon update that uses the new ufoLib, other tools that depend on defcon may break.
As you know I tried to keep API breaking changes to the minimum, but there were some that were not possible to avoid. E.g. the fact that fs API requires forward slashes for path names on all platforms, and the methods for retrieving UFO3 data files had been using native os.path-like path names.

I don't think that with a UFOZ you should get nothing, nor do I think that it should return a boolean. Perhaps a UFOZ specific dictionary that functions as True/False, but leaves open the possibility of future refinement. Public method can check to see if file type is UFOZ and return that dictionary and not call the private methods. Something is better than nothing.

I'm reading code and trying to piece together what has happened. Please hold off on merging until I respond.

thanks, no rush. I don't mean to break anything. Feel free to pick this up from here.

thanks, no rush. I don't mean to break anything. Feel free to pick this up from here.

I see why this is all such a surprise to me. Somehow GitHub stopped sending me notifications about comments on ufoLib Issue 172 (even though I'm still subscribed to the issue). So, I didn't see any of that discussion. I have to go through all of that and see what is going on before I can make a call on the defcon change. I'll try to do it today/tonight but I have my day job duties first.

Sorry Tal, take your time. I can work on other things. And if breakages occur people can always (and they should) pin the versions of each package.

Sorry Tal, take your time. I can work on other things. And if breakages occur people can always (and they should) pin the versions of each package.

Now I'm wondering what other discussions the rogue algorithm cut me out of. Yikes. I could have answered a ton of stuff on 172. Ping me via email if I ever disappear when you need me to explain why I did something in old code. Anyway, I read through that issue and will start looking at your implementation in a bit. I'm pretty sure I had figured out how to handle testForExternalChanges in UFOZ back in the day. I just need to see how you are doing things and then try to refresh my memory.

There is a fundamental incompatibility between defcon's testForExternalChanges and the new UFOZ zipfile format. It's impossible for an external process to modify a UFO that is stored in a zip, because two processes can't modify the same zip file.

Could you expand and clarify this a bit? I've been reviewing the code and it's a bit discombobulating to jump into so I'm trying to get a handle on things. (I don't mean that the code is bad, it's just that this stuff is complex and running it in the Python compiler in my head isn't working that well. 😄) I get that a second UFO modifier can not manipulate a UFOZ as long as a file system object for modifying that UFOZ is open in a first UFO modifier. Is the file system object being retained inside of defcon and therefore there can be no external changes? Or, is it something else?

Is the file system object being retained inside of defcon and therefore there can be no external changes

yes, the Layer objects retain a reference to the GlyphSet instance, which in turn holds a reference to the SubFS instance, which in turn holds a reference to the parent ZipFS instance, but the latter may be closed because Font.save() has been called.
we need to make testForExternalChanges for the Layers not rely on their self._glyphSet attribute, but rather get a new GlyphSet instance from the UFOReader that's been instantiated inside Font.testForExternalChanges, and pass that down to the Layer.testForExternalChanges...

when doing Font.save() for a UFOZ we must close the UFOWriter otherwise the latter's ZipFS doesn't complete its job (compressing itself).
However, in Layer.save we set the self._glyphSet attribute of Layer to the current writer's GlyphSet, which is going to be closed immediately after. Accessing methods of a closed FS will lead to an error, so it should be avoided.

It's impossible for an external process to modify a UFO that is stored in a zip, because two processes can't modify the same zip file.

I should clarify this sentence. With fs module, one does not actually write to a zip file in place (not even sure if that's possible at all). When opening a ZipFS with write=True, pyfilesystem2 creates a TempFS (a temporary local filesystem) where the files/directories are stored until you call its close() method and then everything is compressed.
So, in a way, an external process may potentially write to the temporary folder where the ZipFS is storing its temporary files but it being temporary, the external process doesn't (and should not) know where on the local filesystem that folder is located, so it cannot concurrently modify it.
on the other hand, it is conceivable that two different processes (say two defcon-based apps) write at different times to the same UFOZ path. At any point in time, each may request its testForExternalChanges to report what has changed since the last time it had loaded the Font from that path.
We just need to solve the technical problem of: 1) can't keep ref to GlyphSet after UFOWriter is closed, 2) need a GlyphSet to get the GLIF modified time

also, note that when UFOWriter is asked to write to a path which points to an already existing UFOZ zip file, it has to first unpack the UFOZ to a temporary location, then work from there until finally the writer.close() method is called, and only then create the final ZipFS and compress the result.
This is because a ZipFS in write mode does not update a zip in-place, but truncates the destination. It uses zipfile.ZipFile with mode "w": https://docs.python.org/3/library/zipfile.html
The python zipfile API has an "append" mode but I guess that only works for adding files, but UFOWriter may need to also remove stuff.

I don't mean that the code is bad, it's just that this stuff is complex and running it in the Python compiler in my head isn't working that well. 😄

I know... I've been discombobulating for the whole week 😉

Got it. This is refreshing my memory on the race conditions.
Before solving testForExternalChanges I think we should reconsider retaining the GlyphSet object. That effectively locks out any other process from modifying any part of the UFO. That's been an allowed part of UFO behavior since day 1, so I think it is something we need to solve. I don't think this is a problem with UFOZ in general. It's an issue with defcon's internal optimizations. The only way that I can think of to handle this is for the GlyphSet to be either a fully cached object (with no retained file system object) or create the GlyphSet each time it is requested. The former isn't fun and the later could be expensive.
Neither of those seem ideal and I may be missing the point entirely. I'm still trying to restart my thinking on all of this...

retaining the GlyphSet object. That effectively locks out any other process from modifying any part of the UFO.

does it? From what i understand, it just means that, from within the current python process, one cannot call any fs methods on the GlyphSet's SubFS instance after the latter's parent ZipFS object has been closed (from inside Font.save). That's it.

as I said, it's impossible for an external process to modify the same ZipFS object that is hold by another process. This is because for the read-only ZipFS object (write=False), files in the zip are decompressed on the fly as they are opened, and they are held in an internal MemoryFS object that exists only in memory and has the same file hierarchy as the zip, as this was the time it was first read.
If another process modifies that zip file on disk, its representation in the other process is not updated.

Okay. I thought your "does it?" comment meant that it was possible to have > 1 modifier of the .zip at a time. I knew that wasn't possible when I wrote my implementation, but it's been two years so I thought maybe someone had figured out a way. :smile:
So, given that ufoLib is out there with UFOZ support and defcon is now out of sync, let's do this:

Go ahead and release defcon as you have it.
I'll open an issue noting that testForExternalChanges does not work for UFOZ.
I'll try to figure out a way to make testForExternalChanges work so that callers don't need to know what the file structure is. I have some ideas, but it's going to take some significant replumbing inside of defcon and I won't have time to work on that for a while.

after discussing this with @justvanrossum I realised that releasing ufoLib 3.0 was a bit rushed, so we decided to remove it from PyPI...
See https://github.com/robofab-developers/fontParts/pull/370#issuecomment-429403000
But it's still available from github though if you wish to test it.
So this means we can't merge the current PR as it is now, because it depends on ufoLib being installable from PyPI.
Best thing is that we shall rework this PR after we have a working fontTools.ufoLib.
Sorry for the inconvenience.

I suggest we merge this and address the issue with UFOZ and testForExternalChanges later.
I stumbled on a minor inconvenience in ufo2ft, because defcon currently expects data filenames to use os.path.sep (backslahs on Windows, forward slash on POSIX), whereas fontTools.ufoLib wants always forward slashes (as the fs module requires those)
https://github.com/googlei18n/ufo2ft/pull/289/commits/31c91619b83db44a31ae1bd4657d3f323058247e
this current defcon PR would fix that, among other things.

not sure why Appveyor failed, can somebody try to restart the build (I don't have permissions on @typesupply's appveyor)

I would be ok with this plan, as it was what @typesupply suggested earlier.

Please go ahead and merge. I'm still swamped with other stuff.

@anthrotype merged! I'll let you pick a version number and push to pypi

it'll be 0.6.0

I guess I'll wait until tomorrow, maybe @typemytype also would like have the chance to check everything is ok and it doesn't break RF


Import PUG guide to MANIFEST.in

Summary of changes
The Packaging User Guide has a page on using MANIFEST.in to control the data files in a distribution. This is very setuptools-specific since other build backends do not use MANIFEST.in files. Thus, I think it is better for this information to live in the setuptools documentation.
After this is merged, I will open a PR on the PUG to make https://packaging.python.org/en/latest/guides/using-manifest-in/ a redirect.

Thank you very much for the contribution @jeanas.

I didn't keep it because it looks redundant with the start of docs/guides/miscellaneous.rst:

Maybe we should add the list because it feels more complete? (some minor update might be needed from https://github.com/pypa/distutils/blob/main/distutils/command/sdist.py#L233-L246).

Not sure, maybe some dependency released a new version recently... I will need to find some time to properly fix this

Thank you very much!


Highlight sidenav for more release note pages

Previously, when looking at many of our  specific release note pages,
the sidenav would collapse. Now:

When looking at any supported production release of CRDB,
the sidenav stays open to:
CockroachDB > Releases > Production Releases > All Production Releases
When looking at any testing release for the upcoming version,
the sidenav stays open to:
CockroachDB > Releases > Testing Releases
When looking at any but the latest CockroachCloud release,
the sidenav stays open to:
CockroachCloud > Release Notes > All Release Notes

For CRDB, pages for earlier production releases continue and pages
for earlier testing releases are not reflected in the sidenav.
We could cover those, too, but I'm not sure it's worth the effort.
Fixes #9957
Fixes #8454
One open issue: The "All Production Releases" and "Testing Releases" links
in the sidenav open /releases/index.html at specific anchor points. These
links work, but our sidenav doesn't seem to able keep the right entry
highlighted in the sidenav due to the anchors. I've opened an issue
for that: https://github.com/cockroachdb/docs/issues/9982.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dbff332183fd73e5146f763eb802920c68ebee1f/


Install page expects an email for "Sender Email".

Gitea version (or commit ref):
Git version: 2.11.1
Operating system: Arch Linux
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
The install page SMTP configuration requires an email address for "Sender Email"; however, many SMTP services such as Spark Post and Send Grid have APIs that require user names that are not email addresses.  Configuring the user in app.ini works, but is not user-friendly.
This issue has been fixed in an accompanying pull request.
Screenshots

If regarding the Web Interface, please include a screenshot

Makes sense to me, LGTM

@strk  This is the issue, not the PR.

Yep, figured after the fact. LGTM'd the PR too...


Add support for config file

Codecov Report

Merging #12 (1e8831c) into main (0cbc407) will increase coverage by 0.38%.
The diff coverage is 95.23%.

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
+ Coverage     86.53%   86.92%   +0.38%
+ Complexity      381      364      -17
============================================
  Files            22       22
  Lines          1040     1048       +8
============================================
+ Hits            900      911      +11
+ Misses          140      137       -3

Impacted Files
Coverage Δ

src/Report/SniffViolation.php
67.39% <ø> (+3.10%)
:arrow_up:

src/Command/TwigCsFixerCommand.php
97.82% <94.73%> (-2.18%)
:arrow_down:

src/Ruleset/Ruleset.php
100.00% <100.00%> (+25.00%)
:arrow_up:

src/Environment/StubbedEnvironment.php
91.30% <0.00%> (-8.70%)
:arrow_down:

src/Sniff/BlankEOFSniff.php
95.23% <0.00%> (-0.22%)
:arrow_down:

src/Sniff/EmptyLinesSniff.php
100.00% <0.00%> (ø)

src/Sniff/AbstractSpacingSniff.php
100.00% <0.00%> (ø)

src/Runner/Linter.php
57.57% <0.00%> (+2.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbc407...1e8831c. Read the comment docs.


feat: Expose meta field and ensure encoder sets it

Blocked til https://github.com/waku-org/js-waku/pull/1341 is merged and released


Allow users to override default table row styles

This allows users to override default row styles on tables with a style object.
Since the object was spread before the defaults, there was no way to override them, and users had to use a class.
Fixes  #1171
I looked if this change should be made in other places, and didn't see anything, but please let me know if I missed something!

@wuweiweiwu any chance you get this merged and released soon?

I'll push out a minor release soon! @emroussel

Thanks!


messages problem

Subject: messages problem
Description:
Answer a couch request
Results:
The surfer can't read my messages. He gets the notification but can't see my messages. He text me back and I do see his messages
Backend version: develop-7291678f
Frontend version: develop-7291678f
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
Page: https://app.couchers.org/messages/request/4308
User: geraldeke (5499)

Forwarded to support


az ssh vm failure

Describe the bug
az ssh vm command fails with the following error.
cli.azext_ssh.ssh_utils: __init__() got an unexpected keyword argument 'text'
cli.azure.cli.core.util: azure.cli.core.util.handle_exception is called with an exception:
cli.azure.cli.core.util: Traceback (most recent call last):
  File "/home/bastion/.azure/cliextensions/ssh/azext_ssh/ssh_utils.py", line 65, in start_ssh_connection
    connection_status = subprocess.run(command, env=env, text=True)
  File "/usr/lib64/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'text'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 658, in execute
    raise ex
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 692, in _run_job
    result = cmd_copy(params)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/home/bastion/.azure/cliextensions/ssh/azext_ssh/custom.py", line 57, in ssh_vm
    _do_ssh_op(cmd, ssh_session, op_call)
  File "/home/bastion/.azure/cliextensions/ssh/azext_ssh/custom.py", line 191, in _do_ssh_op
    op_call(op_info, delete_keys, delete_cert)
  File "/home/bastion/.azure/cliextensions/ssh/azext_ssh/ssh_utils.py", line 70, in start_ssh_connection
    const.RECOMMENDATION_SSH_CLIENT_NOT_FOUND)
azure.cli.core.azclierror.BadRequestError: Failed to run ssh command with error: __init__() got an unexpected keyword argument 'text'.

cli.azure.cli.core.azclierror: Failed to run ssh command with error: __init__() got an unexpected keyword argument 'text'.
az_command_data_logger: Failed to run ssh command with error: __init__() got an unexpected keyword argument 'text'.
Ensure OpenSSH is installed and the PATH Environment Variable is set correctly.
Alternatively, use --ssh-client-folder to provide OpenSSH folder path.

To Reproduce
Expected behaviour
The command should initiate the SSH connection. If it fails it should display a  helpful debug message. The message Ensure OpenSSH is installed and the PATH Environment Variable is set correctly. is misleading as ssh is accessible via the path and OpenSSH is updated to latest stable version;
Environment summary
OS: centos 7
azure-cli                         2.35.0

core                              2.35.0
telemetry                          1.0.6

Extensions:
ssh                                1.1.0

Dependencies:
msal                              1.17.0
azure-mgmt-resource               20.0.0

Python location '/usr/bin/python3.6'
Extensions directory '/home/bastion/.azure/cliextensions'

Python (Linux) 3.6.8 (default, Nov 16 2020, 16:55:22)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-44)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy

Additional context
The behaviour is not consistent as the same plugin works flawlessly on other systems.

route to CXP team

@siddharth234 Apologies for the late reply. Thanks for reaching out to us and sharing this feedback. I was able to reproduce the same issue at my end. After I installed the OpenSSH, on my box and then created a PATH environment variable and used a new cmd session to run the same CLI command it worked fine. Could you please set the PATH env variable with the openssh installation path and then try running the same command and let me know if that helps. Awaiting your reply.

@siddharth234 I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you need any further assistance on this. Awaiting your reply.

Hi,
I got the same error message when executing az ssh vm and  az ssh config since the ssh update today morning (4 hours ago).
I think we hit the bug.
Here are the information that help your team to trace the issue

az version
{
"azure-cli": "2.35.0",
"azure-cli-core": "2.35.0",
"azure-cli-telemetry": "1.0.6",
"extensions": {
"ssh": "1.1.0"
}
}

az ssh config --file C:\Users\roqqett.ssh\config --ip *
Failed to create ssh key file with error: [WinError 2] System cannot find the file。.
Ensure OpenSSH is installed and the PATH Environment Variable is set correctly.
Alternatively, use --ssh-client-folder to provide OpenSSH folder path.

echo %PATH%
C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.12.10983.0_x64__8wekyb3d8bbwe;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Program Files\Microsoft\jdk-<IP_ADDRESS>-hotspot\bin;C:\Program Files\Python39\Scripts;C:\Program Files\Python39;C:\Program Files (x86)\Intel\iCLS Client;C:\Program Files\Intel\iCLS Client;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\TortoiseGit\bin;C:\Program Files\Git\cmd;C:\Program Files\Microsoft VS Code\bin;C:\Program Files\Docker\Docker\resources\bin;C:\ProgramData\DockerDesktop\version-bin;C:\WINDOWS\System32\OpenSSH;C:\Users\roqqett\AppData\Local\Microsoft\WindowsApps;

ssh -V
OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2

python -V
Python 3.9.0

ls c:\windows\system32\Openssh

Directory: C:\windows\system32\Openssh
Mode                 LastWriteTime         Length Name

-a----        04/06/2021  06:53 PM         307712 scp.exe
-a----        04/06/2021  06:53 PM         374272 sftp.exe
-a----        04/06/2021  06:53 PM         481280 ssh-add.exe
-a----        04/06/2021  06:53 PM         382976 ssh-agent.exe
-a----        04/06/2021  06:53 PM         662016 ssh-keygen.exe
-a----        04/06/2021  06:53 PM         557568 ssh-keyscan.exe
-a----        04/06/2021  06:53 PM         946176 ssh.exe
I did install OpenSSH-Client for a long time. Even I gave the  --ssh-client-folder parameter, the error is still the same.
Please advice. If you want more information to trace the issue, please let me know.
Regards,
Jean

@navba-MSFT which path did you add to your PATH environment variable? We are facing the same issue, and C:\Windows\System32\OpenSSH is in our PATH, and we are still receiving the error message.

The new code of extension v1.1.0 is not able to translate C:\Windows\System32\OpenSsh to c:\windows\sysnative\openssh.
You can either :

specify flag --ssh-client-folder with c:\windows\sysnative\openssh
set c:\windows\sysnative\openssh to the PATH environment variable.

This is what fixed it for us.

@navba-MSFT this issue is related to the same problem : https://github.com/Azure/azure-cli/issues/22144

@lbergeron01 Thanks for sharing an update and the workaround you followed. We have involved the Product Owners in the background and they are working on permanent fix. We will share an ETA on the fix release as soon as we have more details.

@lbergeron01 sharing the PR details for the fix https://github.com/Azure/azure-cli-extensions/pull/4728. This is under review phase now.

@vthiebaut10 / @navba-MSFT Thanks for the quick response. For me the issue was related to python version. With some basic digging around I was able to pin-point the cause. The text parameter in subprocess.run was introduced in python 3.7 and is absent in python 3.6 which is the default version for centos7 distributions. IMO, A better debug or error message which points to the exact problem would be desirable.

@vthiebaut10 The issue has been resolved for me after updating the plugin to the latest version. Thanks. Closing the issue.


Add alphfold multimer model

I added the alphafold2 multimer support. I also updated the konstin/alphafold.

I am not sure how to update the alphafold_colabfold dependency in poetry and pip.


the class .slideInRight acts weird on mobile phone.

It create an extra area, because of that, user can scroll right and see an blank area. How to fix it?
<!DOCTYPE html>

	<meta charset="UTF-8">
	<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no">
	<title>Animate It</title>
	<link rel="stylesheet" href="animate.min.css">

animate

overflow: hidden in your container...
It's basic, if you translate or change the position of any element you're risking increase your page's dimensions. If you don't want this to happens, you'll have to use overflow hidden.

It doesn't work. I tried to add it to body.

apply overflow:hidden to html too.

Nice try.
May I ask, should I remove all animation class after the animation finished?

Nope. You may break something and won't gain in performance.

@c9n you never want to apply  css to the html tag unless youre SURE you want it to affect everything. use a surounding div.

Just noticed this on the homepage of Animate. Definitely an issue.

Not an issue.. This is the way the DOM works. If you get an element out of the visible canvas it doesn't cease to exist, it creates more space in the document (in this case, the page) and stay there. Animate uses translations to move the element. If the element break the document's boundaries while animating this will happen.
That's why there's the overflow property. It "masks" the area, but the leftover parts don't cease to exist...
Again, not an issue.

Why the demo page remove class after animation finished?
https://daneden.github.io/animate.css/

as far as i know, overflow hidden does not work with width 100%, it must be fixed not "fluid"

@littlee  It wouldn't make sense to keep the classes as it have to re-animate the same element over and over with any different animation chose by the user.
In a real case scenario you could do this if you're chaining animations.
@kafeltz I never heard about this. Is it in the specs or is it a bug? I've never had any issue with it...


less flaky: test newest java only. use batch download (.github actions)

Category
github workflow:

builds in batch mode
tests once on every platform, and at least once for java8 and java14. but not every java on every platform any more. this helps tests not beeing so flaky

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[ ] a bug fix (Fix #...)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ x] a new feature

Description
Please add details about your change here.
Testing
Required verification:

[ ] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[ ] I've verified that this change works as intended.

[ ] Downloads all relevant content.
[ ] Downloads content from multiple pages (as necessary or appropriate).
[ ] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[ ] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

included here:
https://github.com/ripmeapp2/ripme/actions

included here:
https://github.com/ripmeapp2/ripme/actions


Green datepicker input field issues

Bug already reported?

[X] I confirm that I have checked if the bug already has been reported

For which framework/library you are reporting the bug
Angular
Component name
datepicker
Description

You can input numbers like "2024-01-123412341234" and only after clicking away it corrects itself. It should be limited to yyyy-mm-dd.

If you limit the earliest possible date (for ex. max 5y.) you can still input the text field dates like "2019-01-01" (more than five years). It shows an error, but doesn't correct itself to the earliest possible day as it should.

Steps To Reproduce

Input via keyboard "2024-01-123412341234".

Limit the earliest previous date to max 5 years.
Input "2019-01-01" via keyboard and click away.

Current Behaviour
Days in date can take a longer than DD input. Date doesn't correct itself if the date is earlier than set limit if the year and month is correct and the day is altered manually via keyboard.
Expected Behaviour

Should limit input field to YYYY-MM-DD.
Should correct itself if manually written date surpasses the set earliest limit instead of just showing an error underline.

@viliusmac Thanks for creating an issue. A fix is underway in #1176
The second point is actually the correct behaviour as is. As a user, you should be able to enter dates outside of the range and receive and error message. Otherwise, chances are that you don't notice or realise the field "autocorrected" and you end up submitting something else than you expected.
If you really need to autocorrect the field, you can always do it on the application side.


Convert static_assert into enable_if

enable_if shows compilation errors in the caller side instead of callee.

I would argue that static_assert gives a more friendly error message than enable_if.

It is friendly but it doesn't point to caller code and doesn't drop function from callable functions list.
There are some tricks to make enable_if user friendlier such as using deleted function and class names for errors:
https://gracicot.github.io/tricks/2017/07/01/deleted-function-diagnostic.html

In general, I'd probably argue that the static_asserts give the better experience (error messages, simpler code, etc.). Plus every compiler I know about originates errors back to the first caller in a non-dependent context.

Currently IDE don't evaluate static_assert and don't remove the function from code completion, unlike enable_if which is evaluated during code writing.