Doesn't build with GCC5

I'm seeing build failures on GCC5.3 when building hostboot, several unused variable warnings. This seems to be because of how Hostboot code defines some constants.
The below patch is a quick stab at solving it, but this just gets hostboot to compile, booting does not work (checkstop) - this is probably due to me being very rusty on C++ linkage for constants and not entirely sure how hostboot links itself at runtime that may cause problems.

--- a/src/include/usr/targeting/attrPlatOverride.H
+++ b/src/include/usr/targeting/attrPlatOverride.H
@@ -52,13 +52,7 @@ struct AttrOverrideSection
  *        enums and make it obvious which layers map to what PNOR section.
  *        Currrently the pair is only used in a test case to keep it in order
  */
-const std::pair
-    tankLayerToPnor[AttributeTank::TANK_LAYER_LAST] =
-    {
-        std::make_pair(AttributeTank::TANK_LAYER_FAPI, PNOR::ATTR_TMP),
-        std::make_pair(AttributeTank::TANK_LAYER_TARG, PNOR::ATTR_TMP),
-        std::make_pair(AttributeTank::TANK_LAYER_PERM, PNOR::ATTR_PERM)
-    };
+extern const std::pair tankLayerToPn
or[AttributeTank::TANK_LAYER_LAST];

 /**
  * @brief This function gets any Attribute Overrides in PNOR
diff --git a/src/include/usr/targeting/common/targetservice.H b/src/include/usr/
targeting/common/targetservice.H
index 828fe86f3e51..8603f5174743 100644
--- a/src/include/usr/targeting/common/targetservice.H
+++ b/src/include/usr/targeting/common/targetservice.H
@@ -134,10 +134,7 @@ namespace TARGETING
  *      DD framework to bring PNOR device driver online.  Note this target
  *      cannot be used as input to any target service APIs.
  */
-static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
-    = (sizeof(void*) == 4) ?
-        reinterpret_cast(0xFFFFFFFF)
-      : reinterpret_cast(0xFFFFFFFFFFFFFFFFULL);
+extern Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL;

 /**
  *  @brief TargetService class
diff --git a/src/usr/i2c/i2c.C b/src/usr/i2c/i2c.C
index 2afd7730c4ba..0261dda6db9b 100755
--- a/src/usr/i2c/i2c.C
+++ b/src/usr/i2c/i2c.C
@@ -89,6 +89,7 @@ const TARGETING::ATTR_I2C_BUS_SPEED_ARRAY_type g_var = {{NULL}};

 namespace I2C
 {
+uint64_t g_I2C_NEST_FREQ_MHZ = i2cGetNestFreq();

 // Register the generic I2C perform Op with the routing code for Procs.
 DEVICE_REGISTER_ROUTE( DeviceFW::WILDCARD,
diff --git a/src/usr/i2c/i2c.H b/src/usr/i2c/i2c.H
index 05f11d5514d6..0b15c5a096d7 100755
--- a/src/usr/i2c/i2c.H
+++ b/src/usr/i2c/i2c.H
@@ -88,7 +88,7 @@ ALWAYS_INLINE inline uint64_t i2cGetNestFreq()

   return sysTarget->getAttr();
 };
-static uint64_t g_I2C_NEST_FREQ_MHZ = i2cGetNestFreq();
+extern uint64_t g_I2C_NEST_FREQ_MHZ;

 /**
diff --git a/src/usr/targeting/attrPlatOverride.C b/src/usr/targeting/attrPlatOverride.C
index 9368c4af1378..4edac1fa339a 100644
--- a/src/usr/targeting/attrPlatOverride.C
+++ b/src/usr/targeting/attrPlatOverride.C
@@ -30,6 +30,13 @@

 namespace TARGETING
 {
+const std::pair
+    tankLayerToPnor[AttributeTank::TANK_LAYER_LAST] =
+    {
+        std::make_pair(AttributeTank::TANK_LAYER_FAPI, PNOR::ATTR_TMP),
+        std::make_pair(AttributeTank::TANK_LAYER_TARG, PNOR::ATTR_TMP),
+        std::make_pair(AttributeTank::TANK_LAYER_PERM, PNOR::ATTR_PERM)
+    };

 errlHndl_t getAttrOverrides(PNOR::SectionInfo_t &i_sectionInfo,
                       AttributeTank* io_tanks[AttributeTank::TANK_LAYER_LAST])
diff --git a/src/usr/targeting/common/targetservice.C b/src/usr/targeting/common/targetservice.C
index cd3870dedced..2822b47080e3 100644
--- a/src/usr/targeting/common/targetservice.C
+++ b/src/usr/targeting/common/targetservice.C
@@ -61,7 +61,7 @@

 namespace TARGETING
 {
-
+Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL = reinterpret_cast(~0);
 #define TARG_NAMESPACE "TARGETING::"

 #define TARG_CLASS "targetService"

Can paste in the compile errors that you saw as well?  We compile with unused vars as fails so it is a little weird that a different GCC exposes new fails.

On (maybe 1 or 2 revisions behind what's in master-next):

In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from compdesc.C:31:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/devicefw/userif.H:41:0,
                 from userif.C:27:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/devicefw/userif.H:41:0,
                 from ../../../src/include/usr/devicefw/driverif.H:37,
                 from driverif.C:26:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ./misctest.H:28:0,
                 from ../../../../obj/modules/testkernel/testkernel.C:18:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../../obj/modules/testkernel/testkernel.o' failed

In file included from ../../../src/include/usr/devicefw/userif.H:41:0,
                 from ../../../src/include/usr/devicefw/driverif.H:37,
                 from scomtrans.C:38:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../../src/include/usr/initservice/initserviceif.H:31,
                 from ../baseinitsvc/initservice.H:53,
                 from extinitsvc.H:47,
                 from extinitsvc.C:44:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from ./xscomtest.H:35,
                 from ../../../../obj/modules/testxscom/testxscom.C:16:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../../src/include/usr/initservice/initserviceif.H:31,
                 from ./../baseinitsvc/initservice.H:53,
                 from ./initservicetest.H:40,
                 from ../../../../obj/modules/testinitservice/testinitservice.C:17:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from errludcallout.C:33:0:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../../src/include/usr/initservice/initserviceif.H:31,
                 from initservice.H:53,
                 from initservice.C:57:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../src/include/usr/initservice/initserviceif.H:31,
                 from errlmanager.C:46:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../src/include/usr/initservice/initserviceif.H:31,
                 from errlmanager.C:46:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../../src/include/usr/initservice/initserviceif.H:31,
                 from ../baseinitsvc/initservice.H:53,
                 from istepdispatcher.H:47,
                 from sptask.C:59:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/targeting/attrrp.H:40:0,
                 from ./common/target.C:44:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ./common/entitypath.C:48:0:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ./common/predicates/predicatebase.C:42:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from splesscommon.C:51:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../../obj/modules/istepdisp/splesscommon.o' failed
make[10]: *** [../../../../obj/modules/istepdisp/splesscommon.o] Error 1
    DEP        getPllRingInfoAttr.C
    CXX        fapiPlatMvpdAccess.C
In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from ../../../../src/usr/initservice/bootconfig/bootconfigif.C:29:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../../obj/modules/istepdisp/bootconfigif.o' failed
make[10]: *** [../../../../obj/modules/istepdisp/bootconfigif.o] Error 1
    DEP        getPllRingAttr.C
In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from fapiPlatHwAccess.C:36:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../../obj/modules/plat/fapiPlatHwAccess.o' failed
make[10]: *** [../../../../obj/modules/plat/fapiPlatHwAccess.o] Error 1
make[10]: *** Waiting for unfinished jobs....
    DEP        getMBvpdAttrData.C
    DEP        getMBvpdAttr.C
In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from ../../../../src/usr/initservice/bootconfig/bootconfig.C:29:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../../obj/modules/istepdisp/bootconfig.o' failed
make[10]: *** [../../../../obj/modules/istepdisp/bootconfig.o] Error 1
    DEP        DQCompressionLib.C
    DEP        getISDIMMTOC4DAttrs.C
    DEP        getDQAttrISDIMM.C
    DEP        getDQSAttrISDIMM.C
In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ./common/predicates/predicatectm.C:41:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../obj/modules/targeting/predicatectm.o' failed
make[8]: *** [../../../obj/modules/targeting/predicatectm.o] Error 1
In file included from ../../../src/include/usr/ipmi/ipmisensor.H:38:0,
                 from errlmanager_common.C:30:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../obj/modules/errl/errlmanager_common.o' failed
make[8]: *** [../../../obj/modules/errl/errlmanager_common.o] Error 1
    DEP        getControlCapableData.C
In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ./common/predicates/predicatepostfixexpr.C:42:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors
../../../src/build/mkrules/cc.rules.mk:33: recipe for target '../../../obj/modules/targeting/predicatepostfixexpr.o' failed
make[8]: *** [../../../obj/modules/targeting/predicatepostfixexpr.o] Error 1

In file included from istepdispatcher.C:49:0:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ./common/predicates/predicateisfunctional.C:32:
../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from fapiPlatSystemConfig.C:37:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/targeting/common/predicates/predicateisfunctional.H:58:0,
                 from ../../../../src/include/usr/targeting/common/predicates/predicates.H:34,
                 from ../../../../src/include/usr/targeting/common/commontargeting.H:39,
                 from ../../../../src/include/usr/initservice/initserviceif.H:31,
                 from fapiPlatUtil.C:42:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from ../../../../src/include/usr/devicefw/userif.H:41:0,
                 from fapiPlatMvpdAccess.C:42:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

In file included from fapiPlatAttributeService.C:38:0:
../../../../src/include/usr/targeting/common/targetservice.H:137:22: error: ‘TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL’ defined but not used [-Werror=unused-variable]
 static Target* const MASTER_PROCESSOR_CHIP_TARGET_SENTINEL
                      ^
cc1plus: all warnings being treated as errors

(and there's a few more of those specific ones).

See https://github.com/open-power/hostboot/issues/38 for a different method of fixing this.

We could add Joel's warning removal to the op-build recipe for the time being.
Stewart, you mentioned that Hostboot "checkstoped" with your changes. Is this due to your changes or due to something else with GCC5?

@williamspatrick It was pretty early in boot (I didn't even get any SOL output) and didn't have time to hook up any debugging tools (FSP2 or pdebug) - so I'm completely unsure as to what it was checkstopping on... it's just what the BMC said and I thought I'd file this before running off to deal with the other fire..

@williamspatrick I think the checkstop was actually due to some oddity in how I was building HB... it seems that HOSTBOOT_SITE_METHOD=local gives you a not bootable system, but HOSTBOOT_SITE_METHOD=git and cloning from my repo works....

This pull request https://github.com/open-power/hostboot/pull/62 fixes master-p8 up to build and boot with GCC6.


Fix bugs which have been occurring

Whenever some named types are not found, since snowcrash gives us warnings, drafter doesn't check for their existence. This PR makes sure that drafter.js checks if they the given named types are valid or not.

@pksunkara it would be helpful if you would write what bugs exactly. Eg. PT backtrace logs

@pksunkara also add tests for those that can be reproduced locally.

Sure. I am just waiting to fix the other bugs too.

well nothing to review here

Tests first! How can you test something that is working?

@zdne Updated.

@pksunkara since it is not clear from the description – does this fixes all 3 exceptions we have encountered yesterday? (sections, typeDefinition & push)

Yes, it does.

BTW the name of the PR is not the most helpful exactly


error with apt

Hello, I have an error while installing postgres on ubuntu 14
Response body length 4026 does not match HTTP Content-Length header 3011.

Do you an idea of what is the issue ?
Thank you

the issue came from my version of chef, I was using chef 11.12


bug(cdk-dialog): Unable to inject providers provided via route config into dialog

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Injecting providers into a dialog that are provided via route config currently always results in a R3InjectorError. Adding the view container ref or injector of the current component to the dialog's config does not fix this problem.
Reproduction
StackBlitz link: https://stackblitz.com/edit/angular-x5794s?file=src%2Fmain.ts
Expected Behavior
Injecting providers provided via route config should work.
Actual Behavior
Injecting providers provided via route config always results in a R3InjectorError
Environment

Angular: 16.2.10
CDK/Material: 16.2.9
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

This is the components repo, for framework specific issues please follow the instructions here: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#submit-issue.
Although there is a similar issue here that might answer your question: https://github.com/angular/angular/issues/51676.


Better support for graphql-scalars

DX proposal:
{
   // ...
   scalars: "graphql-scalars#clientTypes"
   // ...
}

Map to the primitive (serialized) value, always, and not use the GraphQLScalar or anything from graphql-scalars lib.

Related https://github.com/dotansimha/graphql-code-generator/issues/8412, https://github.com/dotansimha/graphql-code-generator/issues/8296#issuecomment-1256916743

I would also suggest writing in more details, maybe a guide around the whole integration of these two tools as sometimes there is a lot of confusion around them and what's possible and what not

Fixing this would also obviate https://github.com/dotansimha/graphql-code-generator/issues/7763

this seems to break usage with noexports and using the generated files in tsconfig include

I know this is in the v5 roadmap, but is there a temporary workaround?
Currently my graphql schema has
scalar DateTime

This generarates
export type Scalars = {
  ID: { input: string; output: string; }
  String: { input: string; output: string; }
  Boolean: { input: boolean; output: boolean; }
  Int: { input: number; output: number; }
  Float: { input: number; output: number; }
  DateTime: { input: any; output: any; }
};

Is there any way to force DateTime to be type string instead of any?
I tried the suggestion here, but it looks like the client preset and the typescript plugin work independently and don't affect each other.
Here's my current codegen configuration:
import type { CodegenConfig } from '@graphql-codegen/cli';

const config: CodegenConfig = {
  schema: './src/gql/**.graphql',
  documents: ['src/**/*.{ts,tsx}'],
  generates: {
    './src/generated/gql/': {
      preset: 'client',
      presetConfig: {
        fragmentMasking: { unmaskFunctionName: 'getFragmentData' },
      },
    },
  },
  hooks: { afterAllFileWrite: ['prettier --write'] },
};

export default config;

Ok, figured it out. Had to add a config.scalars in the preset itself:
import type { CodegenConfig } from '@graphql-codegen/cli';

const config: CodegenConfig = {
  schema: './src/gql/**.graphql',
  documents: ['src/**/*.{ts,tsx}'],
  generates: {
    './src/generated/gql/': {
      preset: 'client',
      presetConfig: {
        // see https://the-guild.dev/graphql/codegen/plugins/presets/preset-client#the-usefragment-helper
        fragmentMasking: { unmaskFunctionName: 'getFragmentData' },
      },
      config: {
        scalars: {
          DateTime: 'string',
        },
      },
    },
  },
  hooks: { afterAllFileWrite: ['prettier --write'] },
};

export default config;


Create the Nordic case study

@abelsiqueira  Please rename this issue to distinguish it from #101 in the issue list. :)

This was closed but I don't know where the Nordic case study is. I think the action for closing could be adding it to this repo or linking to another repo that has it.


Feature Request: Overlays for Accounts

Hey,
I think a great feature for this app would be overlays on accounts to change the shown balance, without having a accompanied transaction.
I track my transactions in the app and regularly export them to Gnucash on the Desktop. I have the option to either keep the running balance as new opening balance or to delete it with the exported transactions (keeping all my transactions on a device that can easily be stolen is not my thing). The problem with keeping the running balance as new opening balance, is that it always generates a transaction pair with the equity account.
A nice mitigation for this, and the topic of this feature request, would be the ability to add custom offsets to each account, that are independent of the exported transactions.

If I understand right, you mean to save the opening balance just within the account and not as a transaction right?
This way of storing the opening balance was chosen for compatibility with GnuCash desktop. I considered saving just an offset, but ultimately it is better to have the two apps working in a similar fashion conceptually.

Your understanding is correct, but I don't really see how the current setup
helps with compatibility.
Currently, when I delete all transactions the old balance is saved as the new
opening balance. Unfortunately, when I export my transactions the next time it
will also the export the opening balance, which I then have to manually delete
on the gnucash desktop.
Having an option to not export the opening balance or have some sort of offset
or non-exportable opening balance would be great.

That we can do :)
I think it makes sense not to export the opening balances by default. I will create an issue for it.
Thanks for the feedback

Splendid. Thanks for the great app, looking forward to this functionality. Closing this bug.

Just for reference, the new issue is #273 "Do not export opening balances"