Creating Uint8Array from Vec using sub_array() gives diffferent values compared to view()

I am working on this WebGL example from: https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
in Rust.
I tried creating a Uint8Array similarly to how its done for f32 at: https://rustwasm.github.io/docs/wasm-bindgen/examples/webgl.html
But the result produced by Uint8Array(..).sub_array(..) produces different output than produced by the unsafe view(..) method:
let data = vec![255,0,255,255];
let memory_buffer = wasm_bindgen::memory()
	.dyn_into::<WebAssembly::Memory>()?
	.buffer();
let buffer_loc = data.as_ptr() as u32;
let array = Uint8Array::new(&memory_buffer)
	.subarray(buffer_loc, buffer_loc + data.len() as u32)
log!("{:?}", array.to_string()); //displays "255,0,0,0"
let array = unsafe {
       js_sys::Uint8Array::view(&data[..])
};
log!("{:?}", array.to_string()); //displays "255,0,255,255"

Never mind, It seems to work if I do it on a separate empty project. Must be something wrong with the rest of my code!

Hmm.. This is weird. I just tried commenting the bottom block let array  = unsafe{... from the above code and the problem still exists. Here's my entire code. I just spun up a new wasm-pack project and edited the lib.rs file:
use wasm_bindgen::prelude::*;

macro_rules! log {
    ( $( $t:tt )* ) => {
        web_sys::console::log_1(&format!( $( $t )* ).into());
    }
}

#[wasm_bindgen(start)]
pub fn main() {
		use wasm_bindgen::JsCast;
		let data = vec![255,0,255,255];
		let memory_buffer = wasm_bindgen::memory()
			.dyn_into::<js_sys::WebAssembly::Memory>().unwrap()
			.buffer();
		let buffer_loc = data.as_ptr() as u32;
		let array = js_sys::Uint8Array::new(&memory_buffer)
			.subarray(buffer_loc, buffer_loc + data.len() as u32);
		log!("AN ARRAY: {:?}", array.to_string()); //displays "255,0,0,0"
//		let another_array = unsafe {
//			   js_sys::Uint8Array::view(&data[..])
//		};
//		log!("ANOTHER ARRAY: {:?}", another_array.to_string()); //displays "255,0,255,255"
}

If I uncomment, magically both output become the same.

Turns out I should've been using a slice instead of vec and should have explicitly mentioned the type of vec.
Calling .as_ptr() on a vec without specified type was the culprit.
        let vec: Vec<u8> = vec![255,0,255,255];
        let data = &vec[..];

This fixed the issue. You might be wondering why I didn't use a fixed sized array instead. But the reason I got into this confusion initially was because I was aiming to write a generic function for converting a vec into some generic JsArray type.
Something like fn js_array_from_vec<T>(data: &Vec<T>)->JsArray
where JsArray would be a enum:
pub enum JsArray {
	F32(Float32Array),
	U16(Uint16Array),
	U8(Uint8Array),
}

And I would then implement the Into trait to convert each individual into respective js array type. But doing so resulted in incorrect values. So I am now resorting to writing three individual functions instead such as: js_u8_from_slice(..), js_f32_from_slice, etc.
This issue can be closed. But any suggestion on how to successfully write such a generic function  without messing up the u8 array conversion or using the unsafe view(..) would be highly appreciated.

Also guessing from https://github.com/rustwasm/wasm-bindgen/issues/1615,
using subarray instead of view results in copying the data so I might just stick to view since it simplifies my code as I no longer have to write custom code to convert from specific slice to specific typed js array.

Be very careful when using view, it is an unsafe function for a reason: you have to immediately make a copy (without doing any Rust allocation) in order to avoid undefined behavior.
Is there any particular reason the following doesn't work for you?
impl<'a> From<&'a [u8]> for JsArray {
    fn from(slice: &[u8]) -> Self {
        JsArray::U8(unsafe { Uint8Array::new(&Uint8Array::view(slice)) })
    }
}

impl<'a> From<&'a [f32]> for JsArray {
    fn from(slice: &[f32]) -> Self {
        JsArray::F32(unsafe { Float32Array::new(&Float32Array::view(slice)) })
    }
}

impl<'a> From<&'a [u16]> for JsArray {
    fn from(slice: &[u16]) -> Self {
        JsArray::U16(unsafe { Uint16Array::new(&Uint16Array::view(slice)) })
    }
}

Now, rather than using js_array_from_vec(&foo) you can instead use JsArray::from(foo.as_slice())
Or if you really want a separate function, that's not hard to do:
fn js_array_from_vec<T>(data: T) -> JsArray where T: Into<JsArray> {
    data.into()
}

And now you can use js_array_from_vec(data.as_slice())
P.S. It's always better to use &[T] rather than &Vec<T> for the arguments of a function.

Thanks! This is exactly what I wanted.


Give pages team write permissions to select cloud-gov repos

The pages-ops Github org should be given write access to these cloud-gov repos:

product
caulking
cg-scripts

The Pages team already has access to the product repo since all team members are a part of the cloud-gov-team Github org. And that org has write access to the product repo

Instead of giving the pages-ops team write access to these repos, I gave the cloud-gov-team org write access, since that org includes Pages team members and possibly other subteams we may have in the future.


Convert ztunnel Dockerfile registry to ARG

Please provide a description of this PR:
Convert ztunnel Dockerfile base registry to ISTIO_BASE_REGISTRY ARG.
And add the same one in at the proxyv2.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

Test and Release

Please check any characteristics that apply to this pull request.

Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @yankay. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@yankay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
abed4fb224e8f15a4828a5f0e13ce1b62d5ba22e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes


No gulpfile found

I have followed the instructions to use, but when I come to run gulp --watch I get the error ' no gulpfile found'

I figured out to run the npm command, not just gulp --watch from command.


When using /edit, the first line above the marked code area disappears.

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:Win 10 Enterprise
- Continue version:v0.9.215
- IDE version: VSCode
- Model: Same for all models, We run on local Ollama
- config.json:

{
  "models": [
    {
      "title": "CodeLlama",
      "provider": "ollama",
      "model": "codellama:latest",
      "apiBase": "xxx"
    },
    {
      "title": "Default (llama3-8b Q4)",
      "provider": "ollama",
      "model": "llama3:latest",
      "apiBase": "xxx"
    },
    {
      "title": "Llama3-70b-Q8_0",
      "provider": "ollama",
      "model": "llama3:70b-instruct-q8_0",
      "apiBase": "xxx"
    },
    {
      "title": "Llama3.1",
      "provider": "ollama",
      "model": "llama3.1:latest",
      "apiBase": "xxx"
    },
    {
      "title": "codegeex4",
      "provider": "ollama",
      "model": "codegeex4",
      "apiBase": "xxx"
    }
  ],
  "tabAutocompleteModel": {
    "title": "codegeex4",
    "provider": "ollama",
    "model": "codegeex4",
    "apiBase": "xxx"
  },
  "embeddingsProvider": {
    "provider": "ollama",
    "model": "nomic-embed-text",
    "apiBase": "xxx"
  },
  "customCommands": [
    {
      "name": "test",
      "prompt": "{{{ input }}}\n\nWrite a comprehensive set of unit tests for the selected code. It should setup, run tests that check for correctness including important edge cases, and teardown. Ensure that the tests are complete and sophisticated. Give the tests just as chat output, don't edit any file.",
      "description": "Write unit tests for highlighted code"
    }
  ],
  "contextProviders": [
    {
      "name": "open",
      "params": {
        "onlyPinned": true
      }
    },
    {
      "name": "code",
      "params": {}
    },
    {
      "name": "docs",
      "params": {}
    },
    {
      "name": "diff",
      "params": {}
    },
    {
      "name": "terminal",
      "params": {}
    },
    {
      "name": "problems",
      "params": {}
    },
    {
      "name": "folder",
      "params": {}
    },
    {
      "name": "codebase",
      "params": {}
    }
  ],
  "slashCommands": [
    {
      "name": "edit",
      "description": "Edit selected code"
    },
    {
      "name": "comment",
      "description": "Write comments for the selected code"
    },
    {
      "name": "share",
      "description": "Export the current chat session to markdown"
    },
    {
      "name": "cmd",
      "description": "Generate a shell command"
    },
    {
      "name": "commit",
      "description": "Generate a git commit message"
    }
  ]
}

Description
I mark a piece of code and use crtl + l to open Continue, then use /edit and prompt the LLM. In the diff-window, the first row  of code (and the last) is deleted.
I've tested with different models, different type of code. Same result.

To reproduce

Open file to edit
Mark code to ask questions about.
Ctrl + L to open Continue and insert the marked code.
"/edit" to edit the code. Ask the LLM  question.
Check the edits.
First row missing in right window. See image above.

Log output
No response

Hey @goveebee! Thanks for the report. This should be solved now along with our new cmd+I UI for making edits


Simplified various assignment statements.

Tidied up the following:

Used more augmented assignment statements.
Avoided assignment followed by immediate return.

Identified using the following commands:
$ git grep '\(\<[_a-zA-Z0-9]\+\>\) *= *\1 *[-+/*^%&|<>@]' ':*.py'
$ pcre2grep --line-number --multiline --recursive \
        "(?s)(\n +)(\w+) = [^\n]+\1return \2;?$" \
        django docs extras js_tests scripts tests

I think the term you're looking for is augmented assignment statement grin

Yeah... I was a little bit handwavy in my description.
That's the bit I always struggle to find in the Python docs!
Thanks @shangxiao 👍🏻

@ngnpope Thanks :+1:


Feature Proposal: List utilities

Hey again!
I'm currently using tailwind together with reveal.js for creating presentation slides. Therefore I needed a different list style and noticed that there are no helpers for list-style-type. Only a list-reset class is available currently.
As with my former proposals, I'd work on this feature if you guys would agree on implementing it.

That's really great @hacknug. I personally think this should be part of the core. @adamwathan Would you be interested in a PR, or is this plugin-land?

Added for 1.0: #761


pull request for e2e test at 01/30/2017 22:15:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix #105, more robust handling of tslint output

Makes handling of paths reported by tslint more robust to casing issues (on case-insensitive filesystems) and differences between relative and absolute path specification

Coverage decreased (-0.4%) to 92.26% when pulling 2d6ab37c05f9a5f1a0b596681602bf1f11fe0141 on issue105 into 0a6b9aa920f645327fcd2497fc0bc65a7bc63251 on master.


ecdsa public key format uncompressed vs compressed

Reviewing the SDK and environments crypto functions and noticed that we're returning the public key from secp256k1_recover as 65-bytes uncompressed.
I expected that this would have been the 33-byte compressed form.
The value returned will likely be == compared with a public key stored in contract storage, or passed in as an input into to a contract fn, and so the format returned by this function will likely influence how contract developers pass ecdsa public keys to contracts, and how they use keys in their own applications.
The reason I expected compressed form is that it's less data being passed around and stored, meaning more cost effective.
Also the uncompressed form has a quality that developers must be aware of: the points may not be on the curve, and may not be valid. The compressed form doesn't have this quality because developers must derive one of the points and so the points will always be valid. I don't think this quality would especially affect Soroban development directly, but if Soroban encourages the uncompressed form it's possible it encourages use of uncompressed form in the ecosystem outside contracts.
I'm not sure if compressed vs uncompressed was a conscious and intentional decision. Compressed form does require the Soroban environment to do more work and maybe we evaluated that was too expensive? I think we should reconsider though.
This is the function exposed in the Soroban SDK:
/// Recovers the ECDSA secp256k1 public key.
///
/// The public key returned is the SEC-1-encoded ECDSA secp256k1 public key
/// that produced the 64-byte signature over a given 32-byte message digest,
/// for a given recovery_id byte.
pub fn secp256k1_recover(
    &self,
    message_digest: &BytesN<32>,
    signature: &BytesN<64>,
    recorvery_id: u32,
) -> BytesN<65>

Ref: https://github.com/stellar/rs-soroban-sdk/blob/349cd57fc7f20c67730ff89762e99e64e280e4d5/soroban-sdk/src/crypto.rs#L50-L60
This is the code in the Soroban Environment that generates the public key. It appears that changing to compressed is a one line change not including updating tests and redoing calibration:
https://github.com/stellar/rs-soroban-env/blob/8e593abadd9d3723810c644af01e1124badca244/soroban-env-host/src/host/crypto.rs#L158-L160
I started a conversation about this on Discord, but the issue can be discussed here on GitHub.
Related issue:

https://github.com/stellar/rs-soroban-env/issues/1235

@kwantam do you have an opinion if ecdsa apis that output public keys should do so uncompressed or compressed? Any insight if this is okay as is or concerns we might not be considering?

@leighmcculloch your summary of the tradeoffs here is on target. A few random thoughts:

my general impression is that Eth-ish and Btc-ish APIs tend to work with uncompressed keys (as examples: Eth and Btc addresses are hashes of the uncompressed key; the ecrecover precompile returns an uncompressed key)

it's a pretty straightforward byte manipulation to go from uncompressed to compressed SEC1 format. Rustishly:
let sec1_uncompressed_pubkey: [u8; 65] = get_uncompressed_public_key();
let sec1_compressed_pubkey = {
    let mut tmp = [0u8; 33];
    tmp[1..].copy_from_slice(&sec1_uncompressed_pubkey[1..33]);
    tmp[0] = 0x02 | (sec1_uncompressed_pubkey[64] & 0x01);
    tmp
};

So at least in principle if the keygen or recovery procedure returns uncompressed it's still efficient to check against compressed.

if you only use public key recovery to check ECDSA signatures, you don't have to worry about off-curve public keys: the recovery procedure will always return a valid curve point

the recovery procedure needs to do a point decompression whether it returns a compressed or uncompressed point. So you'd end up paying for a modular square-root either way.

Corollary to the above: the only way to get the computational efficiency benefit of working with uncompressed keys is to avoid key recovery in favor of the standard signature verification procedure. And in this case, of course, it's vital to check that the purported public key is really on the curve.

In sum, there doesn't seem to be much of a disadvantage to working with compressed points; there's probably not even an efficiency hit. On the other hand, it's a departure from the way folks are used to doing things in other ecosystems, and it's not clear there's any safety benefit if people are anyway going to be using public key recovery for signature verification.

Yeah, I'm not too concerned with the size difference at the API level. If someone's making zillions of them and want to optimize, yeah they can transform to compressed manually (I expect they'll be compressing XDR long before, but whatever). I went with the uncompressed because as @kwantam originally pointed out it's what existing systems use. Less deviation.


Built from source, how do I run the tests?

We've got some version skew and some problems defining (let!) so I built from source.
But what is the right target to run the tests in the makefile and how do I check the results?

With Z3 4.8.5 in your PATH, you can use make ci-uregressions. This is the rule we use in our continuous integration. With -j 24 on a Intel Xeon E5 v4 at 2.4 GHz with 128 GB RAM, this takes around 15 minutes.


fix: 格式化输出前校验有效性

关于StrToTime方法中匹配正则改成(\d{4})-/.-/.直接获取年月日匹配结果?

Codecov Report
Patch coverage: 15.38% and project coverage change: -0.03 :warning:

Comparison is base (4fc24e1) 79.11% compared to head (3d7672e) 79.09%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2755      +/-   ##
==========================================
- Coverage   79.11%   79.09%   -0.03%
==========================================
  Files         633      631       -2
  Lines       52010    51926      -84
==========================================
- Hits        41150    41072      -78
+ Misses       8825     8812      -13
- Partials     2035     2042       +7

Flag
Coverage Δ

go-1.15-386
?

go-1.15-amd64
79.09% <15.38%> (-0.03%)
:arrow_down:

go-1.16-386
?

go-1.16-amd64
?

go-1.17-386
?

go-1.17-amd64
79.04% <15.38%> (-0.09%)
:arrow_down:

go-1.18-386
?

go-1.18-amd64
?

go-1.19-386
?

go-1.19-amd64
?

go-1.20-386
?

go-1.20-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gtime/gtime_time.go
85.57% <15.38%> (-10.62%)
:arrow_down:

... and 10 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

关于StrToTime方法中匹配正则改成
(\d{4})[-/\.](\d{1,2})[-/\.](\d{1,2})

直接获取年月日匹配结果?

不建议支持这种。


Symbiotic uses system headers, but does not search all system locations

$ ./install/bin/symbiotic --prp=memsafety mem_heap_bug01.c
cc: /usr/include/stdlib.h:33:10: fatal error: 'stddef.h' file not found
cc: 1 warning and 1 error generated.
RESULT: ERROR (Compiling source 'mem_heap_bug01.c' failed)
ERROR:  == FAILURE ==
Compiling source 'mem_heap_bug01.c' failed

running echo | clang -v -x c - shows that more there are three search locations on my installation (/usr/local/include, /usr/bin/../lib/clang/4.0.1/include, /usr/include) seems like symbiotic is using only /usr/include
the code is
#include <stdlib.h>

int main() {
    int *array = malloc( 32 );
    if ( array == 0 ) {
        return 1;
    }
    array[ 4 ] = 16;
}

Duplicate of #61


Add live debugging support to loki.relabel

PR Description
The loki.relabel publishes the log entry with the labels before and after the processing.
Which issue(s) this PR fixes

Fixes #1303
PR Checklist

[x] CHANGELOG.md updated
[x] Documentation added
[x] Tests updated

Docs are fine. :-)


Can the reogrid do this?

This is someone else's grid

and this is my grid,I want to be like it. has line and circle.

What method should I use? Thanks.

not in current version ,but you can modify the source code to add another drawing layer to draw those lines .

not in current version ,but you can modify the source code to add another drawing layer to draw those lines .

oh, it's hard to me.

Hi @ivi-cc, as @waizui said you may have to implement this by your own code since currently we haven't a plan to make it available as a built-in feature.
I'm going to close this and if you have other questions please feel free to open the new.


ls command in example notebook assumes you are Daffydd!

This cell in the example notebook obviously doesn't work on my machine:
ls /Users/dafyddstephenson/Code/my_c_star/cstar_ocean/roms_marbl_example_cstar_case/output/

In my case this worked ls ./roms_marbl_example_cstar_case/output/, but I'm not sure we can assume we know where the notebook is being run from? This is something that we could solve with pathlib I think.

we can use the caseroot variable. Good catch!


Exclude Restlet endpoints from Security Filter Mapping

Closes https://github.com/Jasig/cas/issues/886

@leleuj See this one too please

Restlet behaviour is pretty strange, the RequestParameterPolicyEnforcementFilter is just a regular filter.
+1 for the solution

Added an alternative solution in 886


Add examples for Fluids models

Improved the deep_copy method of the MeshedRegion (the generic _deep_copy in core.py paves the way for future improvements in deep_copy for other types.
Added an example to demonstrate averaging in fluid results.

@JennaPaikowsky This PR is ready for review. In particular, could you take a look at the examples/12-fluids files, please? Thanks!


LlamaCpp Not available for some models

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
The following code :
const squeeze = async (text: string): Promise<string> => {
  const llm = await import('@langchain/community/chat_models/llama_cpp')
  const model = new llm.ChatLlamaCpp({ modelPath: modelPath })
  // const llm = await import('@langchain/community/llms/llama_cpp')
  // const model = new llm.LlamaCpp({ modelPath: modelPath })
  console.log('model ok')
  const response = await model.invoke([
    new HumanMessage({ content: `please summary this : ${text}` })
  ])
  console.log(response)
  return response.content as string
}

Error Message and Stack Trace (if applicable)
There is no error message. Just terminate process after this log.
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: freq_base  = 10000.0
llama_new_context_with_model: freq_scale = 1
ggml_metal_init: allocating
ggml_metal_init: found device: Apple M1
ggml_metal_init: picking default device: Apple M1
ggml_metal_init: default.metallib not found, loading from source
ggml_metal_init: GGML_METAL_PATH_RESOURCES = nil
ggml_metal_init: loading '~~'
ggml_metal_init: GPU name:   Apple M1
ggml_metal_init: GPU family: MTLGPUFamilyApple7  (1007)
ggml_metal_init: GPU family: MTLGPUFamilyCommon3 (3003)
ggml_metal_init: GPU family: MTLGPUFamilyMetal3  (5001)
ggml_metal_init: simdgroup reduction support   = true
ggml_metal_init: simdgroup matrix mul. support = true
ggml_metal_init: hasUnifiedMemory              = true
ggml_metal_init: recommendedMaxWorkingSetSize  = 11453.25 MB

I try debug and interrupt point is here
LlamaCpp > constructor
this.maxTokens = inputs?.maxTokens;
this.temperature = inputs?.temperature;
this.topK = inputs?.topK;
this.topP = inputs?.topP;
this.trimWhitespaceSuffix = inputs?.trimWhitespaceSuffix;
this._model = createLlamaModel(inputs);
this._context = createLlamaContext(this._model, inputs); // << here
this._session = null;

Description
I'm trying to use langchain community > llamacpp
when i use mistral-7b.Q4_K_M.gguf it works well.
However i try to use llama-2-7b.Q4_K_M.gguf , it didn't work.
There is no error message, just interrupted.
Same as chat_model and llm
It is not issue of node-llama-cpp library because this works well. npx --no node-llama-cpp chat --model ./resources/llama-2-7b.Q4_K_M.gguf
System Info
"@langchain/community": "^0.0.34",
"langchain": "^0.1.25",
"node-llama-cpp": "^2.8.8"
mac m1
node : v21.6.2

Oh,, As rubber duck debugging,, maybe it is issue of node-llama-cpp library. I try debugging more

Thanks for the report. I will try to give it a look as soon as I can! Sorry you're running into it.

My application is using electron, and it seems to be a problem between electron and node-llama-cpp. I will close the issue. Thank you.


issues with OSMcha Slow response

I'm submitting a bug report_
Slow response of OSMcha. Long time waiting. Sometimes ending in an error 504. Gateway time=out
Tab for ranking  don't show up. when it shows The tab ranking don't show or much later. some tags cannot be ticked.
I often review changesets of mappers.
What is the motivation / use case for this feature?

What  is the current behaviour, (attach relevant screenshots) ?

What  is the expected behaviour ?

When does this occur ?

Please tell us about your environment:

Windows PC. Firefox Internet browser. Fast Glass fiber Internet

Performance issues constantly. When I just tried to load "https://osmcha.org/api-docs/" I got "504 Gateway Time-out"
When I load "https://osmcha.org/" I get a page with almost no content.

It seems to be an issue that is intermittent, but makes it very difficult to use the website or API.

I also have this problem. I'm getting a 504 Gateway Time-out error when loading the osmcha.org page.

$ ping osmcha.org
PING osmcha.org (<IP_ADDRESS>): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 1
Request timeout for icmp_seq 2
Request timeout for icmp_seq 3
Request timeout for icmp_seq 4
^C
--- osmcha.org ping statistics ---
6 packets transmitted, 0 packets received, 100.0% packet loss

The situation is even worse.
I cannot even log in direct on OSMCha
result :
Authorization request failed
The authorization token is not valid.

The situation is still that bad.
When can I expect improvement
I am fairly deprived by not being able to view results and not being able to respond.

My HOT validation workflow also depends heavily on OSMCha: detecting bad data asap, and informing the creators of it, getting a more in-depth view of what happened in a task in the HOT Tasking Manager, this is only possible with OSMCha.

Today I tried several times to get access to OSMcha .  No access.
The images shows the error messages.
This situation is very annoying  due to the fact that we cannot review bad mapped  work.

In addition, even the very useful RSS functions are not working!

Today I even can not visit OSMCHA website: "503 Service Temporarily Unavailable"

Here also "503 Service Temporarily Unavailable"


[firebase_messaging] Fetch whether notifications are enabled or disabled by user

Firebase messaging is the primary plugin for delivering notifications for Flutter apps. It is a fairly common use case for notification handling apps to determine whether user has disabled notifications for the app.
E.g.: https://developer.android.com/reference/android/support/v4/app/NotificationManagerCompat.html#areNotificationsEnabled()
This is a fairly easy fix. I am opening this to see whether @collinjackson agrees this belongs to firebase_messaging.

Hey all 👋
As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues.
If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.
Given the scope of the rework I'm going to go ahead and close this issue in favor of trying out the latest plugin. I'd recommend checking out the new getNotificationSettings API specifically for this issue.
Thanks everyone 🤓


A few Functional Test failures after commit b3e269e

After commit b3e269e, the following functional tests started to fail.
    CortanaVoiceCommandForegroundActivation::Cortana_VoiceCommandForegroundActivationDelegateMethodsCalled [Failed]
CortanaProtocolForegroundActivation::Cortana_ProtocolForegroundActivationDelegateMethodsCalled [Failed]
ToastNotificationForegroundActivation::ToastNotification_ForegroundActivationDelegateMethodsCalled [Failed]
ActivatedAppReceivesToastNotification::ToastNotification_ActivatedAppReceivesToastNotification [Failed]
FileActivationForegroundActivation::FileActivation_TestForegroundActivationDelegateMethodsCalled [Failed]
Repro is pretty straight forward:
git checkout b3e269e
build winobjc.
Run functional tests.

Fixed with https://github.com/Microsoft/WinObjC/pull/1640


Ability to copy the present working directory to your clipboard

The part you want to Enhancement
As title said.
https://github.com/yorukot/superfile/discussions/10#discussioncomment-9655337
Why it is necessary to enhancement
Please explain why it needs to be enhancement, what are the flaws in the existing design, etc.
Additional context
Add any other context or screenshots about the feature request here.

It could be a good feature if someone is not using some kind of clipboard manager right.


Add notes about project domain setting

Add notes about Custom Vision project domain setting. Percept Studio requires Compact domains to export models.

@nkgami : Thanks for your contribution! The author(s) have been notified to review your proposed change. @tsampige

#label:"aq-pr-triaged"

#sign-off

@nkhuyent: I'm sorry - only the author of this article, @tsampige, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I'm going to close this request because this feedback has been merged through another path.


update azidentity to 1.2.1

Update to azidentity dependency to 1.21, includes in memory cache of managed identity credential (introduced in 1.2.0) and msal update.  https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazidentity%2Fv1.2.1

please update CHANGELOG in the root

Codecov Report

Merging #90 (2075049) into main (f481f92) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   74.64%   74.42%   -0.22%
==========================================
  Files          29       29
  Lines        5592     5592
==========================================
- Hits         4174     4162      -12
- Misses       1175     1183       +8
- Partials      243      247       +4

Impacted Files
Coverage Δ

tds.go
71.51% <0.00%> (-1.46%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support for sysex mesages

Implements sysex part of issue #1.

Hey @SpotlightKid this looks great!
I'll try to have a thorough look and hopefully merge tonight.

Please note that I also included a fix in the try/except block in the main function, which prevents a NameError in the except clause when the program is interrupted with Control-C before the OSC server is created. Sorry that should normally have been a different PR but somehow slipped through.

Heya @SpotlightKid please see the comments for #5
Also, I build this PR with py 2.7.9 and while it did indeed build and start/connect, I get spammed with
...
Exception TypeError: TypeError('<functools.partial object at 0x7f65bf3a74c8> is not a Python function',) in 'liblo._msg_callback' ignored
Exception TypeError: TypeError('<functools.partial object at 0x7f65bf3a74c8> is not a Python function',) in 'liblo._msg_callback' ignored
...

when receiving /midi from touchosc. Could you check that?
It would be awesome to have sysex!

This seems to be a bug in pyliblo. From its documentation (my emphasis):

add_method(path, typespec, func, user_data=None)
func – the callback function. This may be a global function, a class method, or any other callable object,
pyliblo will know what to do either way.

It works in Python3, but not Python 2. I've opened a pyliblo issue.
In the meantime, I can go back to your original method with a wrapped function or - which I prefer - a handler class. Updating the PR now.

Have you tried running the branch after my latest changes to the PR? Do you need any more input on this?

I am wondering... why was this never merged?

why was this never merged?

blame on me :blush: -- mainly lack of testing environment/specs and attention/time. This plus the python 2/3 difficulties (see #5 ).
Now that I see some (very welcome) traction for the project, I promise to look at it again.

Python difficulties eh? I've heard about this before, but again, no experience with it. I'll install and try to integrate it into my regular testing setup, so maybe that way I can catch some problems.

If the project revives and accepts PRs again, I have a few more improvements lined up:
https://github.com/SpotlightKid/touchosc2midi/commits/feature/generickeys

I'm terribly sorry @SpotlightKid ! I did not show enough appreciation for all your efforts (software- as well as outreach-wise).

No worries, I needed the features for my own setup, so I went ahead and implemented them. If there's something useful for you in there, let me know.

hmm. no idea how exactly I ended up here, but I got your PR merged, just not in a way that github acknowledges.
Thank you very much for your contributions @SpotlightKid ! I'll give it a couple of tests and will try to create a new release soon!


Common: remove short-hostname addon from travis.yml

It was added to get around OpenJDK bug. But we've dropped OpenJDK support.
https://github.com/snowplow/snowplow/blob/master/.travis.yml#L14-L15

Good call

It fixed test. Moving to "Dedupe" milestone.


Add representation of LogicalReplication

Opening this since it's in our ecosystem runsheet, feature request for Admin-UI.
cc @jweberpm

tracked elsewhere


vscode, vscodium: 1.73.1 -> 1.74.0

Description of changes
Has been broken on insiders for probably around a month now.

Closes #205042
Closes #205074
Closes #205672

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

(Some notes for reviewers)
Ofborg failures are (hopefully) not related to this bump:
https://hydra.nixos.org/job/nixpkgs/trunk/vscode-extensions.vadimcn.vscode-lldb.x86_64-darwin
https://github.com/NixOS/nixpkgs/pull/159220#issuecomment-1036231572
To test some extensions, e.g. vscode-extensions.vadimcn.vscode-lldb, use
nix-build -I nixpkgs=. -E 'with import <nixpkgs> { config = { allowUnfree = true; }; }; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ vscode-extensions.vadimcn.vscode-lldb ]; }'

Don't just nix-build -A vscode-extensions.vadimcn.vscode-lldb, e.g. the former will fail to eval on ca331f365ab2045c452f20dba71e54a2b6ee1d59 but the latter does build.
I haven't tested all manually packaged extensions yet.

May want to update the title of this PR if it's going to bump the vscode versions.

I’m currently trying to build my home-manager configuration with this PR applied, I will review it then

Doesn’t work for me. I tried building my home-manager configuration with a nixpkgs set to this PR’s head and VS Code still boots w/o extensions. For reference, my configuration: https://github.com/schuelermine/home-manager-configuration/tree/test/205080 (I had added a nixpkgs-test input in flake.nix and an overlay in config/vscode.nix that uses nixpkgs-test)

InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state.

Sounds like an existing issue, https://github.com/NixOS/nixpkgs/issues/188222

Hi @eadwu, looks like you just reverted some previous changes I pushed, if you don't wish this branch to be pushed do you mind fixing both the editorconfig error and the ofborg-eval error, and disable Allow edits and access to secrets by maintainers from this page?

Hi @eadwu, looks like you just reverted some previous changes I pushed

Now this PR is extra confusing because it doesn't include the upgrades anymore. :/

Feel free to use this as a base in your local branch.
I usually don't have a lot of time nowadays and don't quite check GitHub on the daily as much (got lucky here - otherwise your work would have been overwritten everyday).
My daily workflow for updates usually involves a git push -u --all --force for reasons that probably don't apply anymore.

Note that vscode-fhs is likely still broken after this and will require some butchery on the wrapper script since the extensions.json would have to be writable to still install extensions outside of Nix.

Hmm, it that a regression introduced in this update? I think we don't pass --extensions-dir <nix-store-path> to vscode-fhs in the wrapper at all and it should be something sitting in ~/.vscode/extensions/extensions.json :thinking:
# bobby285271 @ inspiron in ~/nixpkgs on git:vscode o [9:00:53]
$ cat $(nix-build -I nixpkgs=. -E 'with import <nixpkgs> { config = { allowUnfree = true; }; }; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ ]; }')/bin/code
#! /nix/store/nfgpn9av331q7zi1dl6d5qpir60y513s-bash-5.1-p16/bin/bash -e
exec "/nix/store/jjyyy1jdvg9id01mv4y43j76rnr34pii-vscode-1.74.0/bin/code"  --extensions-dir /nix/store/xx6c96p08c9xsq2p5q37msyg7wj4i741-vscode-extensions/share/vscode/extensions "$@"

# bobby285271 @ inspiron in ~/nixpkgs on git:vscode o [9:01:13]
$ cat $(nix-build -A vscode-fhs)/bin/code | tail
  --ro-bind-try $(/nix/store/h48pjfgsjl75bm7f3nxcdcrqjkqwns7m-coreutils-9.1/bin/readlink -m /etc/ca-certificates) /etc/ca-certificates
  --ro-bind-try $(/nix/store/h48pjfgsjl75bm7f3nxcdcrqjkqwns7m-coreutils-9.1/bin/readlink -m /etc/pki) /etc/pki
  "${ro_mounts[@]}"
  "${symlinks[@]}"
  "${auto_mounts[@]}"

  /nix/store/q75szbm4d0dc0w099inbjdq822rh74vi-code-init/bin/code-init "$@"
)
exec "${cmd[@]}"

# bobby285271 @ inspiron in ~/nixpkgs on git:vscode o [9:02:03]
$ ls /nix/store/xx6c96p08c9xsq2p5q37msyg7wj4i741-vscode-extensions/share/vscode/extensions
extensions.json


Optimize Topic List Rendering for More Topics

<Improve rendering performance and optimize 'more topics' functionality in the topic list using solid.js>
Fixes: https://github.com/zulip/zulip/issues/29666

@ArfaNada this looks like a very early prototype - -can you mark it as a draft?


fix: remove blank spaces

I just have removed some redundant spaces.

@all-contributors please add @dipeshbabu for bug, content


Fix assumed public hostnames for EC2 instances in us-east-1

fix #397

--- FAIL: TestEtcdClusterDNSNames (0.01s)
    --- PASS: TestEtcdClusterDNSNames/WithENI (0.00s)
        --- PASS: TestEtcdClusterDNSNames/WithENI/WithoutCustomDomain (0.00s)
            --- PASS: TestEtcdClusterDNSNames/WithENI/WithoutCustomDomain/us-east-1 (0.00s)
            --- PASS: TestEtcdClusterDNSNames/WithENI/WithoutCustomDomain/us-west-1 (0.00s)
        --- PASS: TestEtcdClusterDNSNames/WithENI/WithCustomDomain (0.00s)
            --- PASS: TestEtcdClusterDNSNames/WithENI/WithCustomDomain/us-east-1 (0.00s)
            --- PASS: TestEtcdClusterDNSNames/WithENI/WithCustomDomain/us-west-1 (0.00s)
    --- FAIL: TestEtcdClusterDNSNames/WithEIP (0.00s)
        --- FAIL: TestEtcdClusterDNSNames/WithEIP/us-east-1 (0.00s)
        	etcd_cluster_test.go:70: invalid dns names: expecetd=[*.us-east-1.compute.amazonaws.com], got=[*.compute-1.amazonaws.com]

Fixed the test case and force pushed.

Codecov Report

Merging #398 into master will decrease coverage by -0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   38.75%   38.71%   -0.04%
==========================================
  Files          29       29
  Lines        2276     2278       +2
==========================================
  Hits          882      882
- Misses       1275     1277       +2
  Partials      119      119

Impacted Files
Coverage Δ

model/region.go
0% <0%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d299961...d7afc76. Read the comment docs.


After customizing help generation, hep VERB does not work

Did this
static async Task Main( string[] args )
{
    _logger.Info(CommandLine.Text.HeadingInfo.Default);

    var parser = new Parser(p => { p.AutoVersion = false; p.CaseInsensitiveEnumValues = true;  });
    var parserResult = parser.ParseArguments<SyncOptions, QueryOptions, TokenOptions>(args);
    await parserResult.MapResult(
            (SyncOptions opts) => SyncAsync(opts),
            (QueryOptions opts) => QueryAsync(opts),
            (TokenOptions opts) => ShowTokenAsync(opts),
            errors => Task.FromResult(DisplayHelp(parserResult, errors))
        )
        .ContinueWith(t => {
            if ( System.Diagnostics.Debugger.IsAttached )
            {
                Console.WriteLine("Press enter...");
                Console.ReadLine();
            }
        });
}

private static int DisplayHelp<T>( ParserResult<T> result, IEnumerable<Error> errs )
{
    var helpText = CommandLine.Text.HelpText.AutoBuild(result, h =>
    {
        h.AdditionalNewLineAfterOption = false;
        h.AddNewLineBetweenHelpSections = true;
        h.AddEnumValuesToHelpText = true;
        h.AutoVersion = false;
        h.Heading = CommandLine.Text.HeadingInfo.Empty;
        h.MaximumDisplayWidth = 110;
        h.AddVerbs(typeof(SyncOptions), typeof(QueryOptions), typeof(TokenOptions));
        return CommandLine.Text.HelpText.DefaultParsingErrorsHandler(result, h);
    }, e => e,
    true);
    Console.WriteLine(helpText);
    return 1;
}

Before this I could type MyProgram help VERB and it would tell me the same as MyProgram VERB minus errors section. Now this gives me only verb list, like if help lost its first argument. This does not work either: MyProgram VERB help but this does: MyProgram VERB --help.
Am I doing something wrong here?

starting v2.7+, there is a new simplified  overload method:
 private static int DisplayHelp<T>(ParserResult<T> result, IEnumerable<Error> errs)
        {
            var helpText = CommandLine.Text.HelpText.AutoBuild(result, h =>
            {
                h.AdditionalNewLineAfterOption = false;
                h.AddNewLineBetweenHelpSections = true;
                h.AddEnumValuesToHelpText = true;
                h.AutoVersion = false;
                h.Heading = CommandLine.Text.HeadingInfo.Empty;
                h.MaximumDisplayWidth = 110;
                //  h.AddVerbs(typeof(SyncOptions), typeof(QueryOptions), typeof(TokenOptions));
                return h;  // only h
            });
            Console.WriteLine(helpText);
            return 1;
        }

Let me know if this working with you

I was trying one of the examples on the FAQ section ([https://dotnetfiddle.net/IbwLbX]) and it seems that the help doesn't work for verbs. I was using the following list of options
new string[] { "help" }
			,new string[] { "help clone" }
			,new string[] { "help commit" }
			,new string[] { "commit help" }
			,new string[] { "clone help" }
			,new string[] { "help clone" }
			,new string[] { "clone -help" }
			,new string[] { "clone --help" }
			,new string[] { "clone -?" }
			,new string[] { "?" }

But all of them fails except for the first one.
Which of them should work?
Since On .netfiddler I can't see the Error output, I modified the  __YourMain method as follows
	static int __YourMain(string[] args)
	{
		int exitcode;
		var helpWriter = new StringWriter ();
 		var parser = new CommandLine.Parser (with => with.HelpWriter = helpWriter);

		exitcode = parser.ParseArguments<CommitOptions,CloneOptions>(args)
			.MapResult(
			(CommitOptions opts) => RunCommitCommand(opts),
			(CloneOptions opts) => RunCloneCommand(opts),
			//(AddOptions opts) => RunAddCommand(opts),
			(parserErrors) => DisplayHelp (parserErrors, helpWriter)
		);
		//this works because there's a Dummy verb "NextVerbOptions" class
		//exitcode = CommandLine.Parser.Default
		//	.ParseArguments<CommitOptions,CloneOptions>(args)
		//	.MapResult(
		//	(CommitOptions opts) => RunCommitCommand(opts),
		//	(CloneOptions opts) => RunCloneCommand(opts),
		//	//(AddOptions opts) => RunAddCommand(opts),
		//	(parserErrors) => 1
		//);

		return exitcode;
	}

 	static int DisplayHelp (IEnumerable<Error> errs, TextWriter helpWriter) {
 		//if (errs.IsVersion () || errs.IsHelp ())
 			Console.WriteLine (helpWriter.ToString ());
 		//else
 		//	Console.Error.WriteLine (helpWriter.ToString ());
		return 1;
 	}

I'm doing something wrong or I'm missing something here?

@DkAngelito
Just modify args as:
new string[] { "--help" }
,new string[] { "clone", "--help" }
,new string[] { "clone", "git://github.com/commandlineparser/commandline.git" }
,new string[] { "add","--help" }
,new string[] { "add", "addfile.cs" }
,new string[] { "commit", "-m", "initial commit" }
,new string[] { "push", "-f" }
,new string[] { "push", "--force" }
,new string[] { "push" }

Wiki will be modified to a new  modified version

I don't understand the above instructions. My heavily-cut adjustment from the example can be found here
(My actual code is using  a set of verb classes, but the setup here is the same)
What do I "modify args as"?

My actual code is using a set of verb classes, but the setup here is the same

You should add VerbAttribute to your classes like:
[Verb("myverb")] //whatever name, here  verb is named 'myverb'
class Options
{
...
}

To display help for verbs use this syntax:
<MyVerbName> --help
# for the above verb, type:
myverb --help

I added a comment to explain args[]
I modified  your code here and adding verb attribute, and it's working fine.

Hmm. I was trying to use the help auto-verb, is that not possible with a custom help text?

You can not customize auto generated help.

I don't want that, I want there to be the implicit "help" verb that uses the positional argument 0 as the verb to get help with.
i.e. help myverb gets auto translated to myverb --help
Do I just have to make this myself?

I don't want that, I want there to be the implicit "help" verb that uses the positional argument 0 as the verb to get help with.
i.e. help myverb gets auto translated to myverb --help
Do I just have to make this myself?

That works by default
you could try it
in this example from @moh-hassan
new string[] { "clone", "--help" }
would be equivalent to
new string[] { "help", "clone" }

That's what I'm saying is not working. Adjusting my example here, it just shows... nothing. Presumably because there is not help verb.

Upgrade your example to the latest version (2.8+) and change your helptext class for the following and it should work
var helpText = HelpText.AutoBuild(result, h =>
{
	h.AdditionalNewLineAfterOption = false; //remove the extra newline between options
	h.Heading = "Myapp 2.0.0-beta"; //change header
	h.Copyright = "Copyright (c) 2019 Global.com"; //change copyrigt text
	return HelpText.DefaultParsingErrorsHandler(result, h);
}
//		, e => e); Remove this line
); // add this one

That worked!
Just gotta get the errors lines to stop repeating and I'm golden...

Hi @Tsaukpaetra
You need to change the return HelpText.DefaultParsingErrorsHandler(result, h); to just return h as the AutoBuild will already call this method internally.

@DkAngelito Thank You!

//		, e => e); Remove this line

This one line was what was throwing me of and I was banging my head on my keyboard. The overload with this should be marked obsolete and/or killed with fire. What a headache!

Did this
static async Task Main( string[] args )
{
    _logger.Info(CommandLine.Text.HeadingInfo.Default);

    var parser = new Parser(p => { p.AutoVersion = false; p.CaseInsensitiveEnumValues = true;  });
    var parserResult = parser.ParseArguments<SyncOptions, QueryOptions, TokenOptions>(args);
    await parserResult.MapResult(
            (SyncOptions opts) => SyncAsync(opts),
            (QueryOptions opts) => QueryAsync(opts),
            (TokenOptions opts) => ShowTokenAsync(opts),
            errors => Task.FromResult(DisplayHelp(parserResult, errors))
        )
        .ContinueWith(t => {
            if ( System.Diagnostics.Debugger.IsAttached )
            {
                Console.WriteLine("Press enter...");
                Console.ReadLine();
            }
        });
}

How you got that async to work? I cannot see any async/await support at all.

Did this:
static void Main(string[] args)
{
    Parser.Default
        .ParseArguments<ListItemsOptions, AddItemOptions>(args)
        .WithParsed(Run<ListItemsOptions>(ListItems))
        .WithParsed(Run<AddItemOptions>(AddItem));
}

private static Action<T> Run<T>(Func<T, Task> listItems) =>
    (T item) => listItems(item).GetAwaiter().GetResult();

private static async Task AddItem(AddItemOptions args)
{
    // do some async stuf...
}

private static async Task ListItems(ListItemsOptions args)
{
    // do more async stuf...
}


Could not find Xcode version that satisfied version spec: '15.2'

Looks like this action doesn't work with relatively new XCode versions. This is my setup:
- uses: maxim-lobanov/setup-xcode@v1
     with:
       xcode-version: '15.2'

Error:

Fixed by running the action on node-14


go vet error on literal copy of a lock value, with go 1.7.3

$ make vet
+ vet-utils
+ vet-database
+ vet-testutils
+ vet-monitor
monitor/checks.go:292: literal copies lock value from check: monitor.check contains monitor.syncBool
exit status 1
make: *** [vet-monitor] Error 1

It seems is a false positive:
https://github.com/golang/go/issues/16227
In any case, I will prepare a patch to make go vet happy and take the opportunity to include 1.7 in the travis builds.
Thanks for reporting it!

Fixed in https://github.com/bitnami/gonit/pull/11


Host Capacity & Utilization page, scrolling is broken

Host Capacity & Utilization page, scrolling is broken and page is cutted

@epwinchell this is present on pages where patternfly is involved, so except vm_infra!


[hotfix] fix typo, use the delay in millisecond rather than the raw parameter which may not in TimeUnit.MILLISECONDS precision.

What is the purpose of the change
fix typo, use the delay in millisecond rather than the raw parameter which may not in TimeUnit.MILLISECONDS precision.
Brief change log
fix typo, use the delay in millisecond rather than the raw parameter which may not in TimeUnit.MILLISECONDS precision.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

ping @xintongsong

@xintongsong
I think it is better the tests and this change in one PR for future review more clearly.

Thanks @est08zw. Then please ping me once you have the tests ready for review.

@est08zw,
I have opened FLINK-22055 for this issue and attached this PR to the ticket.
Please leave a message on the ticket, so I know your jira id and can assign you to the ticket.


NodeResizer - SvelteFlow

Please describe the feature that you want to propose
Please provide a NodeResizer in SvelteFlow like ReactFlow.

Hey @ahornbeck, we will add it :)

@moklick Thank you and team!  Just for my planning purposes, rough ETA? (days, weeks, months)

@ahornbeck Working on it now. Release probably next week.

published in 0.0.32 https://svelteflow.dev/examples/nodes/node-resizer


turn connection seems to 'freeze' after approx 300 sec

Won't fix.
This must be fixed in 1tp, which uses turn-js to establish e2e connection.


Enables line-selection functionality

Fixes #5
Line has a buffer which it uses to compare versus intersecting points. The line buffer factor can be specified when initialized with the Origo map.

Tested with latest origo-map/origo , does what it says on the tin : )
The only really tiny thing I noticed was that if you init the plugin with  var multiselect = Multiselect({ lineBufferFactor: 0 }) or a negative number it will crash (when line-selecting).
  let lineBufferFactor = Object.prototype.hasOwnProperty.call(options, 'lineBufferFactor') ? options.lineBufferFactor : 1;   if (lineBufferFactor <= 0) {     lineBufferFactor = 1;   }
seems to fix it and can probably be written prettierly :) It's uncertain if even needed because using a minus BufferFactor seems counterintuitive. I suppose someone might try 0 though. It depends a bit on the given documentation.

All lineBufferFactor values below 1 will now force it to 1.
Recommended values would be 2 or 3.


[e2e]: container schedule main provenance-repository slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7649311667
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.provenance-repository.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.provenance-repository.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Jan 25 03:08:03 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7663444246
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.provenance-repository.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.provenance-repository.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Jan 26 03:08:36 UTC 2024
Tests are passing now. Closing this issue.


Fix and improve path finding

This PR fixes several bugs and adds improvements making path finding results better, returning them in a shorter time.
The most severe bug was found in pathNode.Cost method. pathNode is a linked list node with Tail field pointing to the next asset on the path. So the front of the list is the currently extended source asset and the tail is always the destination asset. The previous code was wrongly consuming offers in the wrong order. Fixing this bug required to walk through the current path from the tail (the destination asset) to front (the current source).
I added a new test explaining why the old code was wrong. Consider the path: AAA -> BBB -> CCC. The core of the problem is that the previous code was using DestinationAmount as a starting value for AAA -> BBB trade, in other words: "give me amount of AAA needed to buy DestinationAmount of BBB". It doesn't make any sense. What you should do first is: "give me amount of BBB needed to buy DestinationAmount of CCC". So for the destination amount equal 10 and the following offers (scc notation):
offer :trader, {for:["AAA", :gateway], sell:["BBB", :gateway]}, 1, 11
offer :trader, {for:["BBB", :gateway], sell:["CCC", :gateway]}, 10, 0.1

The old algorithm would not find a path as it is not possible to buy 1 BBB with 10 AAA and 1 BBB is needed to buy 10 CCC.
Fixing this introduced a huge optimization opportunity. Basically the cost of trades between current source asset and the destination asset does not change after prepending the path with a new asset. So we can cache the results instead of checking every order book on the path every time we add a new asset in the front of the path.
Another improvement was to remove A -> B -> A subpaths from the paths as they will always be a bad deal. This also removed all destination asset -> A -> destination asset paths.
Finally, added MaxPathLength that is configurable via CLI switch or environment variable and defines the maximum length of the path that /paths will return, with a default value of 4 (source asset -> A -> B -> destination asset). The default value of 4 comes as a result of observation of paths found between many different assets: most of them have the maximum length of 4 and if the path length was higher it was a bad deal. The MaxPathLength allowed another optimization in search.extendSearch method. Basically if p.Depth == s.MaxLength-1 and connected asset is not a target we don't extend such path as it will not be possible to extend the path any longer.
After implementing all the optimizations average search time for my queries dropped from 10 seconds to 2 seconds giving a better results.
Finally, a single search is run in REPEATABLE READ, READ ONLY DB transaction to have a stable view of the offers table.

Thanks @nikhilsaraf! I will merge it now and it will be autodeployed to https://horizon-dev-pubnet.stellar.org/ so more people can easily test it. In the end we can revert this PR is there's a need but I believe it should work fine and give better results.


MAINT: special: small fixes for digamma

Remove an unnecessary variable
Handle nonfinite values correctly
Add a test for nonfinite values.

Failure appears to be the expected one from https://github.com/scipy/scipy/issues/8145.

LGTM, merged. Thanks @person142


Incorrect short parameters in README

In the project readme, a few shortcuts do not exist but in the documentation they are listed as available. The ones I've noticed are -f for --from (which is actually -f for --file so can't be correct anyway) and --to. The cli help does not list them like this.

Thanks for pointing out. I have removed those shorthands.


Inviter Cancel cause error

I am trying to cancel the call on establishing state. This is my code:
const currentState = this.session.state;
switch (currentState) {
case SessionState.Initial:
case SessionState.Establishing:
// An unestablished outgoing session
this.session.cancel();
break;
case SessionState.Established:
// An established session
this.session.bye();
break;
case SessionState.Terminating:
case SessionState.Terminated:
// Cannot terminate a session that is already terminated
break;
default:
break;
This is the error I received:
Mon Oct 04 2021 15:33:37 GMT-0700 (Pacific Daylight Time) | sip.Inviter | Session ou7thehijqam4ovcb4nhe5t3t1en0n in state Terminated is being disposed logger-factory.js:93
Mon Oct 04 2021 15:33:41 GMT-0700 (Pacific Daylight Time) | sip.SessionDescriptionHandler | SessionDescriptionHandler.getDescription failed - Error: Peer connection closed. index.js:1
Mon Oct 04 2021 15:33:41 GMT-0700 (Pacific Daylight Time) | sip.Inviter | Session.getOffer: SDH getDescription rejected... index.js:1
Mon Oct 04 2021 15:33:41 GMT-0700 (Pacific Daylight Time) | sip.Inviter | Peer connection closed. index.js:1
Mon Oct 04 2021 15:33:41 GMT-0700 (Pacific Daylight Time) | sip.Inviter | Peer connection closed. logger-factory.js:93
Uncaught (in promise) Error: Invalid state transition from Terminated to Terminated
invalidTransition session.js:1139
stateTransition session.js:1169
invite inviter.js:348
promise callback*invite inviter.js:345
call webphone.js:398
call NewCallKeypad.jsx:32
React 14
unstable_runWithPriority scheduler.development.js:468
React 15
js index.js:14
js main.chunk.js:15396
Webpack 7
I tried to add this listener:
this.session.stateChange.addListener((state) => {
switch (state) {
case SessionState.Initial:
break;
case SessionState.Establishing:
console.log('>>>>Tri------Connecting: ');
break;
case SessionState.Established:
console.log('>>>>Tri------Connected: ');
break;
case SessionState.Terminating:
// fall through
case SessionState.Terminated:
console.log('Tri-----Session Terminated')
break;
default:
throw new Error('Unknown session state.');
}
});
The listener showed that State Change change to Terminated twice. Can anyone please help me with this problem?
Thank you.

I think the problem happens when I cancel the request on SessionState.Initial

I am also doing it on Initial state, and I didn't observe any issues yet, nor our QA team that are awesome with trying to break things up heh.
It is strange that there's that error that session state is transitioned from Terminated to Terminated. Maybe if you'll share a full console log with the SIP messages and SIP.js logs it might clear things up. It'll help more to the developers of this project.

Hi guys, any follow-up on this? I'm having the same error when I start a call and cancel it straight away.

I am facing the same issue? Any update on this?

I'm hit the same snag using the latest version of the library (0.20.0)

I think the problem happens when I cancel the request on SessionState.Initial

Yes, you need to end the call when the session state === Establishing, if the session has not yet been initialized or is in the Initial state, there will be an error.

inviter.invite() is calling getOffer() which is failing and throwing which is caught and results in a request to transition state to Terminated. But the session is already Terminated and so the request to transition is in turn throwing - that's a bug as we shouldn't be trying transition state to a state we are already in.
But as to cancelling triggering the getOffer() failure, will need to take closer look at how that could happen. Could have something to do with being in Initial state, but will need to take a closer look.

But fixed the double state transition to Terminated and the associated double error throwing here: f06939c119149a3e00ad8acf69f37360d3331a62
TL;DR - invite() can reject with an Error and does so if cancel() is called before the INVITE is actually sent (before the session transitions to state Establishing).
I believe the double throw may have been obscuring what is going on because it was eating an error message - so good to be rid of it. And I can explain what is going on.
With a plain old invite (without cancel being called) things look like this...

invite() called
session in Initial state
getUserMedia() (and other async stuff) is called (down in session description handler)
getUserMedia() (and other async stuff) resolves
session transitions to Establishing
invite() resolves

.invite() is async and in the default case if .cancel() is called before it resolves, the following sequence occurs...

invite() called
session in Initial state
getUserMedia() (and other async stuff) is called (down in session description handler)
cancel() called
Warning sip.Inviter | Canceled session before INVITE was sent  is logged
session transition to Terminated
cancel() resolves
session description handler disposed and associated peer connection closed
getUserMedia() (and other async stuff) resolves
session description handler throws because peer connection gone (or whatever else bad happened cause rug got pulled)
invite() catches error and rejects

So, if you call invite() and don't wait for it to resolve (or alternatively wait for the session state transition to Establishing) and then call cancel() (or otherwise terminate the session in some fashion) you need to be prepared for invite() to reject.
The documentation for session description handler currently states - "Rejects with ClosedSessionDescriptionHandlerError when this method is called after close or when close occurs before complete." - and a nice typed error like that would allow for nice clean rejection handling, but that's not implemented (yet) and for now one needs to just catch whatever generic Error on the invite promise rejecting and perhaps just log (or not) and move on.
Hope that makes sense? Assuming so will close this out shortly.


Add NetEase to our user list.

A new user informed in the discuss channel.

@kezhenxu94 All tests skip successfully with the only doc changed.


Rooms with mesh connections

Hi bro!
You did a great job and made a very cool stuff!
Could you please make an example with rooms AND a mesh connection? So that multiple players can connect to one room
(I tested the rooms and I couldn’t get them to work with more than 1 connection)
It would be amazing!
Thanks for the work you've done!

The bobble example is using mesh. If you mean the lobby system, thats still under development.
Im still struggling a bit with the mesh type because:

Syncing peers is a bit tricky because you must make sure everybody uses the same node names
Authoritive mesh mode would be nice (negotiating a host) but thats a bit tricky

But you can be sure i will keep improving the library :)


Update to keycloak 21.0.0

Update to keycloak 21.0.0
Updates cypress as well

@daniel-frak Hi! This would be ready for your review :+1:

LGTM! Thanks for the contribution :)


Doesn't work unless going to .html page

I was thinking I could use this plugin on my sites, but my sites don't have "index.html" in the URL bar. Every link ends with a forward slash. Is it possible to make it work for me?

@NetOperatorWibby i know it's been almost 4 years, but i wanted to ask: does smoothstate.js work with Jekyll?


fix logging calls

What this PR does / why we need it:
If don't use formatted output,fix logging calls
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

@mikeweiwei Thanks for your first contribution to Kubernetes,
Please add some details about your PR in the section "What this PR does / why we need it:"

/ok-to-test

/lgtm

/approved

/approve


Intent to archive

This repository contains a lot of tools which were once used in the Noto production process; however, the process has changed and simplified over time, and the only parts of the repo which are now used (by the Noto team) are noto_lint.py and test_vertical_extents.py.
noto_lint.py should really be replaced by the Noto profile in fontbakery; test_vertical_extents.py is a handy script which could find a home in gftools.
Having the other tools around is misleading, as it implies they are used by Noto when they aren't. However, if there are tools out there which people are using, I'd like to hear about it, so we can think how those uses can be best supported. If I don't hear anything, I'm planning to convert two tools we do use and then the archive this repo by the end of April.

I believe some parts of this are actively used by https://github.com/googlefonts/noto-emoji and therefore we should not deprecate. Pruning away long-unused parts is fine, maybe we can rescope to that?

Moving noto-emoji specific parts to noto-emoji sounds good to me.
Youseedee also sounds good to me, if you add an Apache license and the other typical G-OSPO stuff and transfer to me then I will transfer to /googlefonts and you can take it from there?

I defer to Rod on these choices :)

(technically I am off until next week - just wanted to point out unicodedata2 is simply a backport of the latest cpython unicodedata and as such it is bound by the upstream)

Yeah, youseedee and unicode_data both provide a much richer interface to the whole of the UCD, not just the limited bits that the Python API exposes. unicodedata2 would need a lot of work to come up to the same level.

@simoncozens : please add me to PRs

@rsheeter @marekjez86 @anthrotype please see
https://github.com/googlefonts/nototools/pull/637
https://github.com/googlefonts/nototools/pull/638
https://github.com/googlefonts/nototools/pull/639
https://github.com/googlefonts/nototools/pull/640
https://github.com/googlefonts/nototools/pull/641
(for starters)

Merged the first three, defer to @marekjez86 on #640, approved #641 but did not merge as it appeared to be reporting anger from CI.
Lets keep unicode_data here for now.


Fix version check on windows/powershell

Replace fzf#shellescape with shellescape as it was surround the command in "^" characters that powershell did not recognise as escape characters
Prepend command with '&' in powershell to deal with quoted exe name

Thanks.

Unfortunately, the fix actually broke my fzf commands on Windows. I noticed it is related to the shellslash flag. If I set it in .vimrc, commands fail. If it's set after the plugin loads, it works.

@Freedzone That's unfortunate. Does this patch fix your problem?
diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index 40f01a0..ca2dbaa 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -164,7 +164,7 @@ function s:get_version(bin)
   if has_key(s:versions, a:bin)
     return s:versions[a:bin]
   end
-  let command = (&shell =~ 'powershell' ? '&' : '') . shellescape(a:bin) . ' --version --no-height'
+  let command = (&shell =~ 'powershell' ? '&' : '') . s:fzf_call('shellescape', a:bin) . ' --version --no-height'
   let output = systemlist(command)
   if v:shell_error || empty(output)
     return ''

@Freedzone That's unfortunate. Does this patch fix your problem?
diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index 40f01a0..ca2dbaa 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -164,7 +164,7 @@ function s:get_version(bin)
   if has_key(s:versions, a:bin)
     return s:versions[a:bin]
   end
-  let command = (&shell =~ 'powershell' ? '&' : '') . shellescape(a:bin) . ' --version --no-height'
+  let command = (&shell =~ 'powershell' ? '&' : '') . s:fzf_call('shellescape', a:bin) . ' --version --no-height'
   let output = systemlist(command)
   if v:shell_error || empty(output)
     return ''

That works! With and without shellslash. Thank you!

@Freedzone Thanks for the confirmation. Fix pushed to master.


BCSV Website BETA Testing

Good Afternoon.
We are preparing the BCSV Website for further BETA testing.
Users may notice moments of slow loading during the time of BETA testing.
MP Productions will continue to monitor the website and the server to make sure that they are able to handle the load that is placed on them.
At any stage that we have further updates, we will post them here.
Thank You. - MPM

BETA Testing still in progress.
The website is performing well.
MP Productions will continue to monitor the website for any issues that might occur.
Thank You. - MPM


Test should return None

In the newest version of pytest a warning is issued when a test does not return None. I changed most of the tests so they return None. I could not change all of them because some of our tests call other tests and expect a return value. Tests calling other tests is probably bad practice and should be changed.

We can implement pytest.fixtures here as well. Same as Pastas and SPEI.


Colocate matchers

Describe the problem
Currently matchers are placed in a seperate folder, away from the routes.
Describe the proposed solution
Place matchers in +page.js (or +page.server js) or even +matcher.js.
Recurring matchers can still be placed in $lib and imported/exported in the page file.
This change would also remove the need to name the matcher and simplify the file name.
Alternatives considered
Keep the status quo
Importance
nice to have
Additional Information
No response

As in #4539, matchers in +page.js or +page.server.js is a no-go. I have slightly less strong feelings about +matcher.js, but it's still not immediately clear how to deal with path segments that contain multiple params.

I feel like some extra background can be beneficial.  I am trying to solve the 'translated routes' problem and came to this solution:
route: /routes/[about=about]/+page.svelte
and in /matchers/about.js
import canBeTranslatedAs from '...';
export function match(param) {
  return canBeTranslatedAs(param, "about");
}

With this change the files would become
/routes/[about]/+page.svelte
/routes/[about]/+matcher.js
Which I think would be an improvement.
export default function(

As in #4539, matchers in +page.js or +page.server.js is a no-go. I have slightly less strong feelings about +matcher.js, but it's still not immediately clear how to deal with path segments that contain multiple params.

What about +match.name.ts (or ,matcher.name) where name is the name of the param? It would allow multiple matchers and drop the awkward [name=matcher_type] syntax. Alternatively: allow one +matchers.ts with multiple exports named after the param names.
We also use matchers for transitions and having the [name=matcher_type] syntax in every folder is quite distracting.

As in #4539, matchers in +page.js or +page.server.js is a no-go.

Yes, I forgot about that one again, thanks for not reflexively closing this issue.

but it's still not immediately clear how to deal with path segments that contain multiple params.

Not sure what you mean here with "multiple params", wouldn't this work exactly as it does now?
/matchers
    categories.js
    uuid.js
/routes
  /[category=categories]
     /[id=uuid]
         +page.svelte

would become:
/routes
   /[category]
      /[id]
         +matcher.js    //uuid
         +page.svelte
      +matcher.js     // categories

Unless I am missing a usage of matchers that I am not fully aware off.
I reckon this change might lead to more files in case of recurring matchers, with partially duplicate code though, but those could be simple one liners (but with correct syntax):
export { uuid as match } from '$lib/matchers;

(as an aside: could the matcher be export default?)

What about +match.name.ts (or ,+matcher.name.ts) where name is the name of the param? It would allow multiple matchers and drop the awkward [name=matcher_type] syntax. Alternatively: allow one +matchers.ts with multiple exports named after the param names.

Not sure where this goes, the +matcher.js would be specific to one route and hence one param, so the dot name seems unnecessary.  Unless, as in my previous post, I missed something obvious.

but it's still not immediately clear how to deal with path segments that contain multiple params.

Not sure what you mean here with "multiple params", wouldn't this work exactly as it does now?

He is talking about routes/[param1=matcher1]-[param2=matcher2].[param3=matcher3]/+page.svelte.
One question that comes to my mind, how would the matchers be deduped?
If you have 10 routes with a numeric param, you have to create 10 matchers with the same logic.
Even if you do something like:
// lib/my-matcher.js
export const numeric = ...;

// routes/thing1/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

// routes/thing2/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

// routes/thingN/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

The client would need to load the same matcher 10 times.

He is talking about routes/[param1=matcher1]-[param2=matcher2].[param3=matcher3]/+page.svelte.
Tho that could be resolved with:
// routes/[param1=matcher1]-[param2=matcher2].[param3=matcher3]/+matcher.js

export const param1 = ...;
export const param2 = ...;
export const param3 = ...;

I would rather change the signature of the matcher function to take an object (which I believe to be better in general anyway because of the extensibility):
export function match({ param1, param2, param3 }) {

}

One question that comes to my mind, how would the matchers be deduped? If you have 10 routes with a numeric param, you have to create 10 matchers with the same logic.
Even if you do something like:
// lib/my-matcher.js
export const numeric = ...;

// routes/thing1/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

// routes/thing2/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

// routes/thingN/[id]/+matcher.js
export { numeric as match } from '$lib/my-matchers';

The client would need to load the same matcher 10 times.

Yes this could be problematic, but as you show this feels to me to as not that bad, the actual code of numeric would not be duped, just the part where it is being invoked.  I do not know how this is resolved in the current implementation but would expect to find duplication there as well regardless.  I have full confidence in the core team that they would be able to solve this in a good way :)
Another point I thought of was how to do multiple paths with the same param but a different matcher:
/routes
  /product
    /[slug=integer]
    /[slug=string]

But that is a mere naming issue, just call the params something differently:
/routes
  /product
    /[id]
    /[name]

The route-local matchers should be available in addition to the current system. So common matchers like int, uuid etc could still go to the params directory. For us at least, it's the route specific matchers (namely those for localization) that add unwanted noise.

This is a dupe of https://github.com/sveltejs/kit/issues/5298#issuecomment-1238288084. Ultimately I don't think matchers are the right solution for internationalising routes, even if they're the best tool we have right now


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
d6af6b1 -> c00572c

github.com/gruntwork-io/terratest
require
patch
v0.46.14 -> v0.46.15

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.33.2 -> v1.34.1

Release Notes

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.46.15
Compare Source
Description

Updated golang.org/x/net from 0.17.0 to 0.23.0.

Related links

https://github.com/gruntwork-io/terratest/pull/1402

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.34.1
Compare Source
Bug Fixes

Fixed bug where Projects deploy fail reason was not being output (#819) (ede430e)

v1.34.0
Compare Source
Features

Projects parallel deploy and cleanup (#818) (cc9aa18)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline


Don't free the EVP_PKEY on error in set0_tmp_dh_pkey() functions

We should not be freeing the caller's key in the event of error.
Fixes #17196

I should perhaps ask whether the security level check should avoid a time of check vs. time of use issue?
Currently the DH key is checked against the security level that's effective at the time at which the key is configured, but the security level can change after that, perhaps for a specific SSL connection, ...
I don't know whether an already configured key is rechecked at time of use?  The right thing to do may be to ignore out of spec keys (as if not configured), or (more intrusive) fail the attempted handshake?  But a check at time of configuration may not quite provide the expected semantics?

@vdukhovni, that sounds like a different issue to this.

@vdukhovni, that sounds like a different issue to this.

Yes, I stand by the approval on the pull request.  But it just occurred to me while I was thinking about the semantics, and thought I'd mention it before I forget.  If you think it may warrant further discussion, we could open a new ticket, but if it seems unimportant, we could drop it...

A new ticket seems reasonable.  It's not something I'm aware has been discussed previously and it's not clear what semantics make the most sense.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Pushed. Thanks.


fix(agent): remove useless variables

These variables have never been used.

formally there are also unused "bl" and sinon in test/agent.js ... maybe also remove it there? :-)

They have already been removed in PR #219

awesome :-)


Glue Exporter: Support Hadoop directory markers + test

Closes #7023
Glue uses directory markers by default, now supporting them.

@nopcoder FYI tested also manually in Athena and Glue studio for the same setup as the issue itself.

@talSofer FYI, will be in the next lakeFS release 😃


Incorrect abbreviated plural for 'minutes', should be just 'min'

According to General Rules for International System of Units (SI):

Symbols of units do not have a plural form; e.g., 25 kg, not 25 kgs.

Hence, instead of 'mins", localisation for English should be 'min'.

Sure. Please submit a PR with this change.


Minor README Update

For some reason, add the extra space auto-rendered it as code for the README so this is a minor update to get the tags back to properly formatted.

Thank you GenericP3rson! Merged!


Stdin/stdout/stderr dup in enclave

This is taken from #1822
There are some issues with opening /dev/[stdin/stdout/stderr], instead of duplicating 0,1,2. They would have seperate entries in the kernel file description table, so they would have different file poisition, etc. This means that all the reads / writes to stdin/stdout/stderr are completely unsynchronized between the host and the guest. For example, if you have something like ./host ./enc > log.txt, the enclave and host would overwrite the each other due to no file pointer synchronization. Further, /dev/std... are just symlinks to the process's 0,1,2 fds, so if the host closes or changes them before the enclave runs, the enclave would just pick up the changes. Personally, I think just doing dup on 0,1,2 would be a better alternative. There are some disadvantages of the dup approach though. For example, the enclave would pick up the fcntl settings and anything that changes the kernel file description object.

Here's a quick sample program that illustrates the issue with opening /dev/stdout:
#include <stdio.h>
#include <sys/fcntl.h>
#include <unistd.h>
#include <string.h>

int main(int argc, char** argv)
{
        int fd = -1;

        if (argc > 1 && strcmp(argv[1], "host") == 0)
                fd = 1;
        else if (argc > 1 && strcmp(argv[1], "dup") == 0)
                fd = dup(1);
        else
                fd =  open("/dev/stdout", O_WRONLY);

        if (fd == -1)
        {
                perror("Failed to open stdout");
                return -1;
        }

        write(1, "Hello ", sizeof("Hello ") - 1);
        write(fd, "World!\n", sizeof("World!\n") - 1);
        close(fd);
        return 0;
}

If stdout is the tty, you get the expected behavior:
akashg@akash-client:~/test-posix$ ./a.out
Hello World!

On the other hand, if stdout is a file, you see that it overwrites the file:
akashg@akash-client:~/test-posix$ ./a.out > file.txt
akashg@akash-client:~/test-posix$ cat file.txt
World!

You can see this in hello world sample in master too:
akagup@akash-acc:~/openenclave/samples/helloworld$ ./host/helloworldhost ./enclave/helloworldenc.signed
Hello world from the enclave
Enclave called into host to print: Hello World!

vs
akagup@akash-acc:~/openenclave/samples/helloworld$ ./host/helloworldhost ./enclave/helloworldenc.signed > a.txt
akagup@akash-acc:~/openenclave/samples/helloworld$ cat a.txt
Enclave called into host to print: Hello World!

We should build a test for this.

Fixed by #1966


Cds 96639

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Closing this one as it is a reopened branch that was merged earlier.


Add CMake build to GitHub CI

This is ready for review and should not have any impact on 6.10. Although the cmake test doesn't pass currently, this should be merged so that we can double-check fixes to the cmake build.

Needs another review.


Release for snarkyjs 0.9

& check examples didn't break

This should be done once this PR is merged and SnarkyJS 0.9.0 is published to npm.


[Improve]: Set the expiration time according to the expire parameter

What changes were proposed in this pull request
Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)

Set the expiration time according to the expire parameter returned by the login interface

hi sizhu:
The bug has been fixed in this PR, Thanks for your contribution


Downloader to download directly to target location

Proposed changes
Downloader to download directly to target location instead of first downloading to temp location and then moving it. This eliminated the need to move the downloaded file between file systems.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

This is correct, however I wonder if this can be the opportunity to clean the Downloader API.

The Downloader struct is missing the key attribute of a download: its url.
The download() method can be called with different urls that will downloaded in the same file.
The cleanup() method seems unused.
The new_sm() function is weird

Considering all those changes together, I'm even wondering if the Downloader even needs to be in it current object-oriented form but rather move everything to a single associated function Downloader::download() that takes the url, target location and permissions.


Problem 4 (Handled by Narendran Ramakrishnan)

I have been trying to fit the model in part C, but it keeps throwing an error. The error message is saying unable to evaluate fn at initial points. Could you please look into this?

I saw that in the data provided, claims takes the value 0  at a certain point. As  the domain of log normal is (0,$\infty$), the code is throwing an error when we provide  the value 0 for log normal. Lets try removing that and running the code again.


fix for 74.5.x test pattern

newer spring version AntPathMatcher disallow characters

Multiple integration test failures
326 tests completed, 23 failed

Task :cloudfoundry-identity-uaa:integrationTest FAILED

We will be looking into the integration test failures.

I might have test results mixed up.  I cannot repro the integration test failure anymore.


[ie] Add issue URL to broken extractor warning

The warning currently issued by _WORKING does not provide any details on what is broken. This PR deprecates _WORKING in favor of a new field _BROKEN_ISSUE (name open to change).
When marking extractor as broken, _BROKEN_ISSUE should be set to the GH issue URL. The URL will be shown in both supportedsites.md and in the warning issued in CLI.
I've set crunchyroll and hidive issues for demonstration. We could probably merge it in this PR anyway
I considered allowing for custom warning messages too, but am not sure if it'd be sufficiently useful.
Example:
WARNING: [crunchyroll] The program's functionality for this site has been marked as BROKEN, and will probably not work.
         See  https://github.com/yt-dlp/yt-dlp/issues/9453  for more information. Do NOT open a new issue for this.

I like it. Done

I don't know if this is possible, but how about:
WARNING: [crunchyroll] As of YT_DLP_VERSION this site's extractor is broken.
See https://github.com/yt-dlp/yt-dlp/issues/9453 for more information.
If that issue is closed, please run `yt-dlp --update-to master`, and DO NOT OPEN A NEW ISSUE ABOUT THIS!

If the logic tested ie._WORKING is True it wouldn't be necessary to deprecate it. Then other truthy values could be used

a URL, to be presented in a message as above
other text, to be formatted into the message

with other truthy values treated like False.
But maybe some API users check ie._WORKING?
In that case I suggest just _BROKEN perhaps automatically setting _WORKING = not _BROKEN.


How about copy_from_string / copy_from_stream / copy_to_stream

Thanks for the great work.
copy_to_string is nice, but how about adding a method to do the reverse?

If you are looking for something like copy_from_string: use copy_from and pass a StringIO into it which wraps your input string


added reducers and components

Related Issuse

Info about Issue or bug

Closes: #192 [issue number that will be closed through this PR]
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.(Specially for Backend)
[x] My changes generate no new warnings.

@codewithvk, @purnima143  pls review


TypeError: Cannot read properties of undefined (reading 'update')

im using Node.js v17.0.1 & ubuntu 20.04 LTS

Needs additional log output, stack trace, where the error is originating from.
CNR.
Sys details:
Ubuntu 21.04 LTS
Node v16.x

Yo, I didnt try it yet but I saw that you arent using a db, what will happen in there are giveaways in the queue and the bot goes off

Yo, I didnt try it yet but I saw that you arent using a db, what will happen in there are giveaways in the queue and the bot goes off

There are plugins for it within discord-giveaways the manager will create a JSON file for it in storage dir called giveaways.json, you may choose to switch your storage to MongoDB, quick.db etcetra, you may refer to the package documentation for such.

Closing this due to 48 hours of inactivity feel free to add a comment if you think this needs to be reopened.


add buildResult into getAvgDuration query

If user doesn't provide the buildResult, we use default SUCCESS or UNSTABLE
fixes: #242
Signed-off-by: Yixin Qian<EMAIL_ADDRESS>

API URL(don't use buildResult):/api/getTestAvgDuration?platform=x86-64_mac&level=hs_sanity&jdkVersion=14&group=perf
Response: {     "testListTime": [         3375892     ],     "testLists": [         [             {                 "_id": "renaissance-akka-uct_0",                 "avgDuration": 2417830             },             {                 "_id": "renaissance-fj-kmeans_0",                 "avgDuration": 588234             },             {                 "_id": "renaissance-future-genetic_0",                 "avgDuration": 322095             },             {                 "_id": "dacapo-h2_0",                 "avgDuration": 30952.333333333332             },             {                 "_id": "dacapo-lusearch-fix_0",                 "avgDuration": 16734             },             {                 "_id": "IdleMicrobenchmark_HS_0",                 "avgDuration": 46.666666666666664             },             {                 "_id": "Pre Test",                 "avgDuration": null             },             {                 "_id": "Post Test",                 "avgDuration": null             },             {                 "_id": "renaissance-naive-bayes_0",                 "avgDuration": null             }         ]     ] }

API URL(set buildResult to SUCCESS|FAILURE): /api/getTestAvgDuration?platform=x86-64_mac&level=hs_sanity&jdkVersion=14&group=perf&buildResult=SUCCESS|UNSTABLE
Response: same as above

API URL(set buildResult to FAILURE): /api/getTestAvgDuration?platform=x86-64_mac&level=hs_sanity&jdkVersion=14&group=perf&buildResult=FAILURE
Response: {     "testListTime": [         0     ],     "testLists": [         []     ] }
expected, since no tests folder is created for this build

No test duration data found. in TKG output. Is it expected?

Sorry I forgot to pull the latest API changes, it's not expected as the json parse format has changed.. here is the updated output from TKG:
Attempting to get test duration data from TRSS:
curl --silent --max-time 120 localhost:3001/api/getTestAvgDuration?limit=10&jdkVersion=11&platform=x86-64_mac&group=openjdk&level=sanity

TEST DURATION
====================================================================================
Total number of tests searched: 7
Number of test durations found: 7
Top slowest tests:
        47m08s jdk_lang_j9_0
        37m03s jdk_util_j9_0
        10m38s jdk11_tier1_pack200_0
====================================================================================

Test target is split into 1 lists.
Reducing estimated test running time from 104m32s to 104m32s.


refactor(material/tabs): extract tab list

Refactors tab-group by extracting the tab-list logic as a subcomponent.
An incremental step towards addressing https://github.com/angular/components/issues/23404.

@byanofsky Did you want to continue work on this PR?

Hey - feel free to re-open this back up with a new PR if you'd like to rebase and continue to work on landing it.


cmd/link external linking on darwin strips symbols starting with "l"

What version of Go are you using (go version)?

$ go version
1.13 locally built

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/jfaller/go/bin"
GOCACHE="/Users/jfaller/Library/Caches/go-build"
GOENV="/Users/jfaller/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jfaller/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/jfaller/src/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/jfaller/src/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kt/9h7gfgy955lgbm_cys108l2c002pwh/T/go-build423342355=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

[16:12]~/go/src/hello $ cat hello.go
package main

import "log"

func main() {
	log.Fatalf("See we called a function that started with l")
}
[16:12]~/go/src/hello $ go build .
[16:12]~/go/src/hello $ nm hello | grep Fatal
000000000109c170 t log.Fatalf
[16:12]~/go/src/hello $ go build -ldflags="-linkmode external"
[16:12]~/go/src/hello $ nm hello | grep Fatal
[16:13]~/go/src/hello $

What did you expect to see?
I expected that with log.Fatal would still be in my executable.
What did you see instead?
Symbols starting with an l have been stripped.
Oringally reported HERE

CC @cherrymui @aarzilli @diffmike

I think we already add leading _ to symbol names for plugins, for exactly the reason mentioned in https://github.com/go-delve/delve/issues/1635#issuecomment-524443933 : dlsym needs it. We may want to do this for other build modes as well.

Given that the change was reverted this issue should be reopened, I think.

Totally right. I'm on vacation till Monday, but will fix whatever caused the trybots unhappiness first thing.

Apparently external linking hasn't ever worked on darwin_386. I'll exclude that in the test, and resubmit.


update %sqlrender api doc

Describe your changes
Added a sample schema for the example 'authors' and displayed the table
Added the detail spec '-w/--with'
Modified some of the names/variables of the sample queries to match information of new sample schema
Issue ticket number and link
Closes #100
https://github.com/ploomber/jupysql/issues/100
Please let me know if I should fix anything, or am missing anything

:books: Documentation preview :books:: https://jupysql--279.org.readthedocs.build/en/279/

I'm not sure why all the Metadata was removed, but I will fix that, and I'll look into the CI tests failing. Should be ready for review by the end of the day after these fixes

could someone help me figure out why some of the CI tests are cancelled? The only changes I made from the previous commit were changing variable names.


Add macro and subrule to globals

FYI @brandjon This will allow rulesets to adopt symbolic macros early.