[sdk-trace] make activeSpanProcessor private

Description
activeSpanProcessor is currently public and that allows users to modify the span processor by setting it on the fly even though the should be done via addSpanProcesssor() or - ideally - only via the constructor as the user is not supposed to hold on to the SDK instance of the TracerProvider after the initialization phase, as this can have unintended side-effects on the exported telemetry and should therefore be avoided.
This issue is considered done when

[x] the activeSpanProcessor property at  https://github.com/open-telemetry/opentelemetry-js/blob/47444f2a4c13a80f3328ffafc5b4c8db9e9a0886/packages/opentelemetry-sdk-trace-base/src/BasicTracerProvider.ts#L73 has been marked private or protected
[ ] it has been verified that activeSpanProcessor is not public in any other way for the BasicTracerProvider
[ ] it has been verified that activeSpanProcessor is not public in any other way for the WebTracerProvider
[ ] it has been verified that activeSpanProcessor is not public in any other way for the NodeTracerProvider

@pichlermarc can I pick this up?

[ ] it has been verified that activeSpanProcessor is not public in any other way for the BasicTracerProvider
[ ] it has been verified that activeSpanProcessor is not public in any other way for the WebTracerProvider
[ ] it has been verified that activeSpanProcessor is not public in any other way for the NodeTracerProvider

BasicTraceProvider has a getter function getActiveSpanProcessor which is used in Tracer & Span classes. The ref is accessible but user cannot replace it so I guess we could check those

should be done via addSpanProcesssor() or - ideally - only via the constructor as the user is not supposed to hold on to the SDK instance of the TracerProvider after the initialization phase,

@pichlermarc  as for now the constructor does not accept processors. should we go for it?

@pichlermarc #5134 does remove the addSpanProcessor API. Since the change affect lots of files I'd prefer to defer the discussion and possible PR of removing getActiveSpanProcessor
Your feedback is very welcome :)

Done in #5152 & #5192


[Observer Decoder] Fix bugs in elan_format_raw.py

Pass the --gcs_bucket_name flag properly
Document the --gcs_bucket_name flag in the README.md
Allow skipping the screenshot processing step
Add missing dependency google-cloud-storage to requirements.txt

Thanks for the review!


Add generic cloud config upstream refresher

Refreshing and checking differences in upstream config spec for all
new cloud drivers can be done by generic service. Code base from existing
eksupstreamrefresher should be reused and prepared for adding new cloud drivers.

@rmweir @thedadams I have added also mechanism for cleaning up old setting object.

lgtm, this is working great for me in https://github.com/rancher/rancher/pull/31625

@cbron Who can restart Drone or can we get privileges for restarting it ?
Currently CI is broken because drone failed, needs to be restarted:
default-windows-1809: Error response from daemon: failed during hnsCallRawResponse: hnsCall failed in Win32: Element not found. (0x490)

It was rebased

I have addressed @dramich comments:

[ ] https://github.com/rancher/rancher/pull/31771#pullrequestreview-618776507
[ ] https://github.com/rancher/rancher/pull/31771#pullrequestreview-618788856
[ ] https://github.com/rancher/rancher/pull/31771#pullrequestreview-618791980
[ ] https://github.com/rancher/rancher/pull/31771#pullrequestreview-618796203


GUI crashes with buffer not divisible by scale (2)

When scaling is used (in my case 2) under wayland GUI crashes with:
$ RUST_BACKTRACE=1 amdgpu_top --gui
wl_surface@24: error 2: Buffer size (359x465) is not divisible by scale (2)
Protocol error 2 on object wl_surface@24:
Protocol error 2 on object wl_surface@24:
Protocol error 2 on object wl_surface@24:
Failed to set up a graphics context (OpenGL).
winit EventLoopError: Exit Failure: 1
thread 'main' panicked at crates/amdgpu_top_gui/src/lib.rs:274:9:
explicit panic
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

--list output:
$ amdgpu_top --list
amdgpu_top v0.7.0

#0:
    AMD Radeon Graphics (0x15BF.0xC4)
    DevicePath { render: "/dev/dri/renderD128", card: "/dev/dri/card1", pci: "0000:c1:00.0" }

Window manager is Sway. If scaling is set to 1 it starts fine.

I couldn't reproduce the issue in my environment.
I found a similar issue reported in winit crate, but it should have been fixed in 0.29.9.
https://github.com/alacritty/alacritty/issues/7559

Could you please attach the sway version and config file?
The error is occurring on the sway (wlroots) side.

I think this issue to introduction of this event to the wayland protocol preferred_buffer_scale.
My config at least related part are:
output eDP-1 {
    scale 1.5
    pos 0 0 res 2256x1504
}

And sway version is 1.8.1 operating system is Archlinux.
I have also build amdgpu_top from git master, and it is reproducible there.

Here is also a full log of crash with wayland debug and rust backtrace enabled:
amdgpu_top_waland_debug.txt

I couldn't reproduce it with sway-1.8.1 and wlroots-0.16.2.
As amdgpu_top does not directly handle the wayland protocol, it is assumed to be the problem with the crate used by amdgpu_top or with the wayland compositor.
Sorry, there's nothing I can do.


Add crate: datafusion-rs

Please add crate to category: Data Processing
If you think it belongs there that is: https://github.com/andygrove/datafusion-rs

Sorry for the delay. This is now added.


Image auth UI design

Introduction
Sub item of #206
Issues / Motivations
Proposals / Solutions
Work Plan
Process Check List

[ ] Item 1
[ ] Item 2

Test cases

[ ] Test 1
[ ] Test 2


Touch events do not get fired on specific devices

The above issue can be reproduced with the TouchEvents view from the library's example. It works fine on the simulator and specific devices like iPhone 6, iPad or the emulator but not with iPhone X or iPhone 7 Plus. The touch events in the 1st & 3rd part of the "TouchEvents" section of the example, cause the alerts to appear on some devices but not others. The same is true for the "hover the svg path" that registers every time in some devices and in the some others it registers once or not at all. All of the devices run on iOS 12

seems to be a duplicate of #592

That is correct.


Travis build does not copy JAR to S3 on Pull Request branches

There are conditional clauses in the travis-ci configuration that intentionally skip uploading JARs for pull requests. This prevents us from testing out pull requests on staging. I would like to understand why such an exception was ever introduced before removing it.

Here is the reason: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

This leads to another problem: the $TRAVIS_BRANCH on pull requests is the branch the PR is merged into, not the branch of the PR itself. So the JAR file is often called master-X.jar instead of having the right branch name.


Source the .bashrc automatically?

Operating system and version:
Ubuntu 18.04.3 LTS
When installing, I had to exit the server and login again (essentially re-sourcing the .bashrc) in order for nvm to work. It would be great if the script did this after all the previous commands so that users can install it and just use it right away!

I'm afraid that's impossible, since the install script is piped to bash - so it has no access to the outer shell session in which nvm.sh needs to be sourced.


Running 'HTML Language Features' Formatter: FormatOnSave is extremely slow

I use FormatOnSave for all my files. Lately, I'm encountering a major delay when saving my files. Here an example of an attempt to save a quick fix in an HTML file using HTML Language Features Formatter (it happens frequently with ESLint and Prettier as well):

VS Code Version: 1.51.1

To investigate I need sample files that reproduce the issue...

@aeschli
https://github.com/mxshapira/todo-js


Add schema validation on plugin and loader options

Use https://github.com/webpack/schema-utils to validate options

@alexander-akait I need clarification about Node.js version in user vs maintainer context.
The package-lock.json should be generated with which version of Node.js?
For example, the project supports v12+ (the engines.node indicates it) but I want to update the dependencies and play the tests in CI with newer versions (all upcoming LTS releases).
I tried to use v18 for the development on the project, and generated a package-lock.json with this version (which seems to me to be the right way to proceed) but I have an error related to the package schema-utils with the following scenario:

The package-lock.json was generated with v18
CI run npm ci with v14
The following error appears npm ERR! Cannot read property 'schema-utils' of undefined

What would you recommend?


How to fix 414 Error (request uri is too long) when using DataTables which works in all major browsers

This works fine when testing manually, but using Capybara with a JS driver (such as Selenium Webdriver), it stalls out because the GET request is too large. Switching the index route to a POST allows this to work, but is not RESTful (a POST to /resources should create an object, not return an index, that's what GET at /resources is for). And again, it works in normal browsers.

How long is your uri?  Different browsers have different limits as do different servers -  Capybara starts up the rails app using WEBrick which IIRC has a limit around 2048, for url length, to match some version of IEs limit - I believe you can change WEBricks default limit (check the WEBrick docs for that), but using a URL anywhere near a browsers or servers length limit is not a great idea - maybe your routing scheme needs a rethink

I'm not using any special routing, this is a DataTables default which is used on thousands of sites. I could change it to a POST but that seems to defy convention. Works fine in Thin, which is what my Rails app uses.

Switched Capybara's server to Thin, resolved.

another option is
https://github.com/raggi/capybara-puma

How did you switch capybara's server to thin? Also, the capybara-puma gem is now deprecated saying capybara has "native features". How can we increase the max uri length for get requests and do so in a portable way(eg so it can run remote CI like Travis)?

@synth capybara-puma is now deprecated because you can just do Capybara.server = :puma with recent versions of Capybara.  To switch to thin you'd need to use Capybara.register_server to setup thin, and then after that specify Capybara.server = :thin  - see https://github.com/jnicklas/capybara/blob/master/lib/capybara.rb#L481 for how puma is registered as an example

👍 Thanks!

I fixed by adding:
Capybara.server do |app, port|
  require 'rack/handler/thin'
  Rack::Handler::Thin.run(app, :Port => port)
end

@ashish91 How old is the Capybara you are using?  The code you show should give a deprecation warning -- use Capybara.register_server to register a named server and then specify that one.  See the answer above.

@twalpole I am using capybara 2.13.

@ashish91 And that's not outputting a deprecation warning???  It definitely should be.

Yes I get DEPRECATED: Passing a block to Capybara::server is deprecated, please use Capybara::register_server instead

Add in initializer (selenium.rb):
 Capybara.register_server(:thin) do |app, port|
  require 'rack/handler/thin'
  Rack::Handler::Thin.run(app, Port: port)
end

And set in spec config:
Capybara.server = :thin

But I suggest to choose :puma
-> It is getting more updates for now and you do not need to register with above method

Thanks @choosen It also works with puma:
Capybara.register_server :puma do |app, port, host|
  require 'rack/handler/puma'
  Rack::Handler::Puma.run(app, Port: port, Host: host, Threads: "0:4")
end
Capybara.server = :puma

@ashish91 Capybara has already registered a :puma server, so you don’t need to do the register_server call.


Support custom-css attribute to set custom CSS URL

This is to implement some sort of custom theming for utterances elements. I proposed one way of doing it, by using custom-css attribute to set URL of desired CSS file to be loaded by the embeded iframe.
By doing this, users could write their own CSS to style utterances, since their blog styles do not always come along with the default GitHub theme.

@JokerQyou thanks for the PR. Custom styling was something I had considered early on in the project but hadn't implemented because I was concerned about the security implications. That post is pretty old, I'm not sure whether the attacks mentioned there are still applicable in today's browsers. I'm going to take another look at the security issues.

Will update the code as per your request.
As I've did know that CSS could have been an attack vector, should we limit the CSS file URL to be on the same origin as the page that is embedding utterances?
Say if I use utterances in pages on example.com, then utterances would load stylesheet only if it is also hosted on example.com. Of course we should also warn users about this potential securtity issue on the documentation page.

For colors I think it will be fine, but what about other variables? For instance, users like me might want to adjust the width of utterances' timeline since a fixed max-width does not fit with other blog styles. And what about border-radius? And to remove background gradients for button?
Also I did not get an overall feeling of how a user would configure these variables. Say if I want to set background color to #333, then how should I do that? To set background="#333" on the <script> tag?
Here's an example of how I would (and already have, by using a selfhosted instance) customize the look of utterances for my blog, to show some of the potential customization options.

I for one would love to see custom CSS, unless the variables are going to let me customize everything like backgrounds, widths, font size, etc

@JokerQyou & @herohamp I've added theme support to utterances. I'll be adding more instructions for contributing themes to the  contributor guide. Basic theming (colors, font, margins, padding, borders) is achievable by providing values for the primer sass variables. CSS rules can be overridden for advanced theming scenarios. Take a look at the dark theme for examples: https://github.com/utterance/utterances/tree/master/src/stylesheets/themes
The utterances home page has a theme switcher to enable previewing the themes.

Question for clarification: can theme variables be set in the script tag, or just the overall theme?


Unable to "Register"

The Register button would not move forward. This is the same for all browsers ( not tested in FF )

@sharriexie Can you take a look at this issue?

Hi Folk, it seems to work now. Thank you & close this "bug".


Spatial management for solid biomass (transport)

Similar to #148 manage the spatial resolution of solid biomass (copperplated or with biomass transport) through a namespace (think: global dictionary).
This allows to easily vary the spatial resolution of biomass in the model without removing components that are added inside the same script.
Currently the option biomass_transport triggers both spatial resolution of biomass as well as the transport of biomass. One could split this into two options.
PR against https://github.com/PyPSA/pypsa-eur-sec/tree/biomass-transport

Very cool with the global dictionary! Yes, it definitely makes sense to split the spatial resolution and the transport into two options! Can we formulate the function define_spatial(nodes) more general so that we can use it also for H2 and gas? I guess one would need two more parameters, the name, e.g. in this case "solid biomass" and a bool (maybe called "spatial") which indicates if there should a spatial resolution or one European node. One would probably need a map dict for all further nodes which should be added (e.g. spatial.biomass.industry = nodes + " solid biomass for industry"

Yes, that's what I had in mind: to add to define_spatial all of biomass, H2, gas and co2. I will think about whether we add parameters to define_spatial for different carriers, or whether it's better to treat all cases through the global config options because the dict for spatial components like "solid biomass for industry CC" is not so general. E.g. in combination with #148 where I also added define_spatial it could look like this:
def define_spatial(nodes):
    """
    Namespace for spatial

    Parameters
    ----------
    nodes : list-like
    """

    global spatial
    global options

    spatial.nodes = nodes

    spatial.biomass = SimpleNamespace()
    spatial.co2 = SimpleNamespace()

    if options["biomass_transport"]:
        spatial.biomass.nodes = nodes + " solid biomass"
        spatial.biomass.locations = nodes
        spatial.biomass.industry = nodes + " solid biomass for industry"
        spatial.biomass.industry_cc = nodes + " solid biomass for industry CC"
    else:
        spatial.biomass.nodes = ["EU solid biomass"]
        spatial.biomass.locations = "EU"
        spatial.biomass.industry = ["solid biomass for industry"]
        spatial.biomass.industry_cc = ["solid biomass for industry CC"]

    if options["co2_network"]:
        spatial.co2.nodes = nodes + " co2 stored"
        spatial.co2.locations = nodes
        spatial.co2.vents = nodes + " co2 vent"
    else:
        spatial.co2.nodes = ["co2 stored"]
        spatial.co2.locations = "EU"
        spatial.co2.vents = ["co2 vent"]

    spatial.co2.df = pd.DataFrame(vars(spatial.co2), index=nodes)
    spatial.biomass.df = pd.DataFrame(vars(spatial.biomass), index=nodes)


Not user friendly behaviour of menu items in settings screen

User unable to read the whole phrase in menu item

suggestion: text wrap instead of ellipsis/truncation.


Cannot change email for imported accounts

Description
The Email field for users imported from Jellyfin cannot be changed and always falls back to their username.
This prevents users from getting notifications about events.
Version
1.7.0
Steps to Reproduce

Go to Users
Press Import Jellyfin Users
Edit a user account & change email
Save changes
User email switches back to username

Screenshots
No response
Logs
No response
Platform
desktop
Device
MacBook Air M2 (2022)
Operating System
macOS 14.3
Browser
Firefox 122.0
Additional Context
I don't think the platform details above are relevant for this issue since it seems server based.
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

Why was this issue closed? Did it work?
(In my testings emails are changeable)

Strangely it worked right after I created the issue 😀
However it there still seems to be a small bug, which does not always accept the change.. Sometimes when I try to update the email it switches back to the default Jellyfin user right upon saving the changes.
If you want, we can reopen the ticket but since it worked for me afterwards I decided to close it.

Yeah, the first time you change your email, it requires a change twice. There's already an issue opened for it so it's good c:

Alright, sorry for the bother in that case :)


BEP: Dynamic Frontend Plugins

🔖 Feature description
The dynamic frontend plugins feature is a way of loading additional frontend plugins at runtime, without the requirement of rebuilding and restarting a running backstage instance.
This system should significantly improve frontend plugin management for backstage instances.
The dynamic plugins leverage the declarative UI system to define what a plugin is and how it should be represented in the browser.
🎤 Context
https://github.com/backstage/backstage/tree/master/beps/0002-dynamic-frontend-plugins
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

A new PR was added with some results of the initial exploration of combining different module federation builds tools in a single runtime.
Code: https://github.com/scalprum/mf-mixing-experiments
PR: https://github.com/backstage/backstage/pull/22429

@Hyperkid123, regarding https://github.com/backstage/backstage/pull/22513/commits/4d3cbf7877a9eb100c995a7c9ec3472487a17aee#r1472665454: is there any reason not to maximise module sharing? Basically listing every single external dependency as a shared module? Asking just as a way to explore that extreme.
Selecting the correct version range might be a bit tricky, since using the package.json ranges risks that you're testing the plugin towards newer versions of your dependencies, but if a shared module brings in an older one that might not be something that the plugin supports in practice. That could be mitigated by switching out the package.json dependency bump strategy, but it might also make sense to go with a completely different solution, like using the versions that's currently installed as the base.

@Rugvip  Sure. If you list all available modules from a package, the module federation is smart enough to share and include in the output only modules that are used in the source code. So there is no problem if only a fraction of modules is used. We use this approach in our projects and it works well. You minimize the overhead.
If you share the entire package (for example MUI), tree shaking is disabled and you bundle everything even if it's never used.
There are a few scenarios where this becomes problematic.

Massive module libraries like icons where you usually use a fraction of available modules will be just added to the build assets. No way around that.
Required version mismatch. If a remote module has a shared config set to a specific version, and no module in the shared scope would match the version requirement, the remote will fall back to its own. This means that you are constantly pulling new assets (which might not be required), which has a performance impact. I think the impact becomes even worse in backstage use case where all plugins are preloaded even though the user never interacts with them.

And because AFAIK backstage plugins do pin their dependencies, the version requirements would rarely be met.
I would say either don't share these types of dependencies at all or just share individual modules and transform the imports at build time.

A quick summary of module federation feature support by individual tested packages in https://github.com/scalprum/mf-mixing-experiments.
Tested packages

Rspack
Webpack native
Webpack @module-federation/enhanced
Vite @originjs/vite-plugin-federation

Dynamic remotes support

Tool
Out of the box support
Possible to implement custom support

Rspack
:white_check_mark:
:white_check_mark:

Webpack
:white_check_mark:
:white_check_mark:

@module-federation/enhanced
:white_check_mark:
:white_check_mark:

@originjs/vite-plugin-federation
:x:
:white_check_mark:

@module-federation/vite
:question:
:question:

Runtime compatibility

:white_check_mark: Out of the box compatibility
:warning: Requires custom implementation
:x: Not compatible

x
Rspack
Webpack
@module-federation/enhanced
@originjs/vite-plugin-federation

Rspack
-
:white_check_mark:
:white_check_mark:
:warning:

Webpack
:white_check_mark:
-
:white_check_mark:
:warning:

@module-federation/enhanced
:white_check_mark:
:white_check_mark:
-
:warning:

@originjs/vite-plugin-federation
:warning:
:warning:
:warning:
-

None of Vite builds are compatible with @module-federation/runtime package out of the box. An extra bridge is required. Rspack and Webpack (both the core and the @module-federation/enhanced packages) are compatible out of the box.
Module Scope sharing

:white_check_mark: Out of the box compatibility
:warning: Requires runtime specification
:x: Not compatible

x
Rspack
Webpack
@module-federation/enhanced
@originjs/vite-plugin-federation

Rspack
-
:white_check_mark:
:white_check_mark:
:warning:

Webpack
:warning:
-
:warning:
:warning:

@module-federation/enhanced
:white_check_mark:
:white_check_mark:
-
:warning:

@originjs/vite-plugin-federation
:warning:
:warning:
:warning:
-

Feature parity
The best feature parity is between Rspack and Webpack using @module-federation/enhanced tooling.
As mentioned previously, we can make all of the above work with each other. But we have to keep in mind, that runtime dynamic remote support is critical for plugins to be truly dynamic. Currently, that is something the Vite plugin does not support and I was not able to find any plugin that officially supports the feature or a future plan.
We could write a custom plugin, or augment the tested and add a custom dynamic remote support.

Sorry for the radio silence on this for the last lil bit. Love the research into module federation 👍 🎉 I think it's safe to say that we have a way forward there for now right? Likely sticking to Webpack at least in the short term to keep things simple, and use @module-federation/enhanced. Switching to Rspack still seems a lil bit early but def a potential path for the future.
I've now had a proper read through of the BEP and summarized my top prio questions in its current state:

Plugin integration into shell applications

Something I've been thinking about a bit is how we actually manage this config in practice. For example, do you think it's worth building in the ability to essentially dynamically install a plugin + config straight away, or just keep them separate for now?

Plugin registry

It's not actually immediately obvious to me what the purpose of the registry is? Could this be simplified to an interface instead, probably with a baseline implementation that grabs manifest locations or similar from config?
Alternatively I wonder what you think about making this part of the app backend in some form? So that the app backend is generally the source of truth for what additional manifests should be loaded in, maybe even doing some caching/hash validation.

Plugin discovery

Scanning what? isn't the plugin registry already be intended to be the source of truth?

Plugin manifest

At a glance it looks like plugin manifests will be simple to generate, i.e. they're just a build step/artifact, it's not something plugin builders usually need to interact with. Do you agree that that's the case?

Plugin storage

The current proposal covers the case where plugins are deployed and then integrated. What do you think about the case where one wants to install a plugin directly, without requiring a deployment step?

Likely sticking to Webpack at least in the short term to keep things simple, and use @module-federation/enhanced. Switching to Rspack still seems a lil bit early but def a potential path for the future.

Agreed. RSPack seems promising, but it still has a long way to go to.

Something I've been thinking about a bit is how we actually manage this config in practice. For example, do you think it's worth building in the ability to essentially dynamically install a plugin + config straight away, or just keep them separate for now?

I see no harm in having this out of the box. From the experience in Janus, making a plugin dynamic was in many cases just a question of triggering the new build pipeline with no changes required in the plugin itself. And because of how the new UI system works in backstage the occasional code tweaks we needed to do will be obsolete.

Alternatively I wonder what you think about making this part of the app backend in some form? So that the app backend is generally the source of truth for what additional manifests should be loaded in, maybe even doing some caching/hash validation.

This is basically what I had in mind. Because backstage is a full stack app, leveraging the backend is a no-brainer IMO. If the config/registry is then exposed via API or embedded into the main HTML file is probably a matter of preference. The important part is, that the registry/config is not cached by the browser or the API cache is always refreshed on a config change.

Scanning what? Isn't the plugin registry already intended to be the source of truth?

More or less. The discovery should be the mechanism that triggers whatever it is that is responsible for generating the registry. It can be as sible as having a chokidar watching a directory in which plugins are loaded. I think this will be more relevant in a future where some sort "plugin catalog" exists where users can enable/disable plugins in the UI. Then there is a question about where to actually look for plugins that can be installed. I might be thinking a bit ahead here.

At a glance it looks like plugin manifests will be simple to generate, i.e. they're just a build step/artifact, it's not something plugin builders usually need to interact with. Do you agree that that's the case?

I don't think they will need to interact at all. Plugin metadata can be generated without the dev input. Again, maybe in the future of some plugin catalog, the manifest might be the right place to add some metadata. Adding an option to extend the manifest with custom properties should not be a big deal if we decide it's needed in the future.

The current proposal covers the case where plugins are deployed and then integrated. What do you think about the case where one wants to install a plugin directly, without requiring a deployment step?

I now realize I was not clear in the BEP. I am working with the assumption that the frontend plugins installation will work similarly if not the same as the backend dynamic plugins. Both frontend and backend plugins are just JS modules so if we can find a common way to handle the installation I think it would benefit all.
Adding plugins without the extra deployment is the end goal we'd like to achieve.

Without an extra build I would say is the main goal?

@Rugvip Yes, sorry got the terms mixed up. Deployments are handled by whoever is running the instance.


Avoid fetching images directly from IIIF-server URL

The URL you are using here
https://github.com/acdh-oeaw/kretschmer-static-py/blob/856754541447bd428c1b120730a938810c95f3ab/templates/object.html#L254
can change any time
The nice thing though about ARCHE-API is that you can access the IIIF-Endpoint via the ARCHE-Resource ID, either it's handle-id or (more useful) the ARCHE-ID designed by you, the https://id.acdh.oeaw.ac.at/{whatever}
because https://id.acdh.oeaw.ac.at/{whatever}?format=iiif redirects you to the iiif-server, something like https://loris.acdh.oeaw.ac.at/uuid:/{whatever}/full/full/0/default.jpg
https://id.acdh.oeaw.ac.at/auden-musulin-papers/amp_0003.jpg?format=iiif -> https://loris.acdh.oeaw.ac.at/uuid:/auden-musulin-papers/amp_0003.jpg/full/full/0/default.jpg
The good thing using the ?format=iiif param is that if the underlying IIIF service or its logic changes, your app shouldn't be affected at all

6442f9dd3e5fb4d58fcc8672db56a1286034ed69


Lindsey spec organization

Added tagging to the different specs to allow easy running of sets of tests on demand.  Tags were applied at the outer describe block of each file.  See sample below.
To run tests:
be rspec --tag model
be rspec --tag controller
be rspec --tag feature
be rspec   (no tag will run all tests)
Sample tag syntax:
describe User**, model: true** do
it 'something' do
expect...
end
end


Test suite oganisation

I need to organise different test suites using mocha, but I ain't find the way to do that, need some help!
something like these:
    //main entry for testing stuff
    for (let p : testSuiteCollection) {
        runSuite(p);
    }

thx in advance

If this is still relevant I suggest you ask in the gitter channel: https://gitter.im/mochajs/mocha


RuntimeError: probability tensor contains either inf, nan or element < 0

error
Traceback (most recent call last):
File "BELLE/train/src/inference.py", line 68, in
generation_output = model.generate(
^^^^^^^^^^^^^^^
File "/home/.conda/envs/user/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/.conda/envs/user/lib/python3.11/site-packages/transformers/generation/utils.py", line 1565, in generate
return self.sample(
^^^^^^^^^^^^
File "/home/.conda/envs/user/lib/python3.11/site-packages/transformers/generation/utils.py", line 2648, in sample
next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either inf, nan or element < 0
cmd
inference.sh
#! /bin/bash

model_name_or_path=belle_ext_13b/

python BELLE/train/src/inference.py \
    --model_name_or_path ${model_name_or_path} \
    --ckpt_path ${model_name_or_path} \
    --llama \

model weights
download the weight from https://huggingface.co/BelleGroup/BELLE-LLaMA-EXT-13B
convert the weight following the instructions from the above URL
check md5sum of the decrypted files, and ensure the complete recovery.
environment
GPU: 1*A100
python==3.11.3
pytorch==2.0.1 (py3.11_cuda11.7_cudnn8.5.0_0)
transformers==4.29.1
cuda==11.7

same error，how to solve it?

You can try other models. If there are no errors, it indicates an issue with weight conversion for the model.
Moreover, when loading the model, you may also try torch.float16 or torch.float32, as this error seems to be caused by numerical precision.

You can try other models. If there are no errors, it indicates an issue with weight conversion for the model. Moreover, when loading the model, you may also try torch.float16 or torch.float32, as this error seems to be caused by numerical precision.

I run the script again without changing anything, and it runs well. Though the instability of the script may caused by some reason, I'm going to close this issue. Thanks a lot!

try running in 8-bit worked for me vs when trying in 4-bit got the same issues with mlabonne_phixtral-2x2_8....8-bit solved the nan, inf error


[build] Add ASTGen libraries via a CMake function

We currently add all modules in lib/ASTGen via the top-level CMakeLists.txt and then modify them. in a loop at the end of the file. This doesn’t scale as we add more modules.
Create a CMake function that adds a Swift compiler library and move the definition of these libraries to separate CMakeLists.txt files in Sources subdirectories.

What I would prefer here is:

Move ASTGen/* into lib/*
Have the macros call a separate function
Move the extra C++ interop logic into _add_host_swift_compile_options
No need for the foreach loop 🥳


Update recover-deleted-computer-object-failover-cluster.md

Updating article from 2008 to current supported OS'es and terminology.
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

@jeffhughes-msft The changes are live. This PR will be closed.


500 on searches that contain ":"

It seems that after adding KQL, a search like "test:test" is causing 500s in oCIS.
I didn't see any other issue reporting something similar, hope I didn't miss it.

Thanks, we had a hack week, sorry for late answer!
I’ll have a look tomorrow morning.

@diocas i had a look, no 500 here for me, i tested it locally using the latest master!
i used the following body for the request:
<?xml version="1.0"?>
<oc:search-files  xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:permissions />
    <oc:favorite />
    <oc:fileid />
    <oc:file-parent />
    <oc:name />
    <d:lockdiscovery />
    <d:activelock />
    <oc:owner-id />
    <oc:owner-display-name />
    <oc:shareid />
    <oc:shareroot />
    <oc:share-types />
    <oc:privatelink />
    <d:getcontentlength />
    <oc:size />
    <d:getlastmodified />
    <d:getetag />
    <d:getcontenttype />
    <d:resourcetype />
    <oc:downloadURL />
    <oc:tags />
  </d:prop>
  <oc:search>
    <oc:pattern>test:test</oc:pattern>
    <oc:limit>8</oc:limit>
  </oc:search>
</oc:search-files>

and received a 207 response.
Can you please show me how your request looks?

now i think i got what you mean, you mean terms wrapped in quotation marks, for example "test:test".
I can reproduce it with that term, but it looks like bleve is the problematic part in that case, not the kql parser.
I've also adde a testcase for that:
https://github.com/owncloud/ocis/blob/6eea04987b4b0505202558b77e66922cc64eed17/services/search/pkg/query/kql/dictionary_test.go#L1211
i have a look aftert my current kql pr is merged. cc.: @2403905

Yes... I was using web, which has it's own way of creating the pattern:
<oc:pattern>name:"*test:test*"</oc:pattern>

We have to care about escaping the characters +-=&|><!(){}[]^\"~*?:\\/   following  docs https://blevesearch.com/docs/Query-String-Query/

Yes... I was using web, which has it's own way of creating the pattern:

@diocas thanks for your report, will be fixed!


For 'lazy', make "cannot override with a stored property" a warning

Previous versions of Swift accidentally treated lazy properties as computed properties because of how they were implemented. Now that we check this correctly, we've broken source compatibility. Downgrade the error to a warning in this case.
(Arguably we could allow overriding with a stored property. The original concerns were that you could accidentally end up with extra storage you didn't need, and that observing accessors would behave differently based on whether or not the property was overriding. But there's at least no ambiguity for 'lazy', which can't have observing accessors today.)
rdar://problem/35870371

@swift-ci Please test


[Uperf] Allow different request and response sizes

Currently we support
- sizes

as a list of message sizes in the CR for uperf.
This translates into the same size for request and response in the uperf xml. We need a way to specify a response size that is differetn from the request size to do things like request-response tests with 64B requests and 1K responses for example (typical HTTP request response sizes, with smaller requests than responses).

definitely want this for Ceph, since reads and writes are a perfect example of asymmetric message sizes.

Done with PR #481


Resolvable soft-validations

Raised by various users and developers.
   When I see a soft validation
      and it has a resolvable attribute set
        then I should see a link beside it to resolve (fix) it

Potential steps to implement:

Straightforward, but not very integrated - add an attribute to soft_validation instances that points to route, this end point of this route is a form that lets the problem be resolved
Integrated, but trickier - provide a mechanism to popup a form inline, the convention for defining these popups (partial name, RESTful request etc) would have to be worked out before hand.  Would perhaps require multiple new attributes within the soft validation, though we should try to minimize this.  Could likely take advantage of a set endpoint and a global_id.

This is increasingly being requested, and is becoming fairly high priority.

This is actually the kind of interface we originally thought of here to
implement the "new taxon name" task, just create the name and then click on
the soft validation errors to be redirected to forms to fill-in missing
data.
On Wed, Dec 7, 2016 at 3:25 PM, Matt<EMAIL_ADDRESS>wrote:

This is increasingly being requested, and is becoming fairly high priority.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/21#issuecomment-265529263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEwrtdrgjbr5CNBK8c2rxcHzCMdHJuaGks5rFvofgaJpZM4Jv0O5
.

Are you now thinking about that approach as a replacement for the wirefame that was proposed?

Yes. I just talked with MM about this idea again and she (in a bit of a
hurry) agreed on it. I think this is a better first step before going into
creating the new taxon name task (if we discover that resolvable
soft-validations alone are not handy enough). In fact it could probably be
built on top of it, first complete basic information and in a next step you
are guided to complete the rest of the data in any order you want rather
than a single big form.
On Wed, Dec 7, 2016 at 3:54 PM, Matt<EMAIL_ADDRESS>wrote:

Are you now thinking about that approach as a replacement for the wirefame
that was proposed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/21#issuecomment-265537402,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEwrtTFFADeOQVg6e3lXSd07Tuk_IvSpks5rFwDngaJpZM4Jv0O5
.

Thinking quickly- I think we still need the form as we designed, but it's certainly not a bad step to do this first. We need to do the following:

Extend the invocation pattern soft_validate(:other_soft_validation_method, set: :some_set, resolutions: ['route_name_only_no_path_or_url_postifx', ... 'other_path'])  (prioritize the first path, but here recognize that tasks may ultimately overlap, so we might give users different views that both solve the problem- likely don't use this pattern too much, but at least make it possible)
Extend SoftValidation (singular) with an accessor that stores an array of (see below) the resolution paths, set on initialization
Add a helper method(s) that generated the fully qualified path to resolution, and optional other paths if there are more based on some click through event

Soft validation code is quite (very?) well tested, so we should be able to extend it quickly.  Do you want me to tackle it, or do you want to take a look (and maybe make general improvements)?

With f7ec60a817e you can make a soft validation resolvable by including resolution_with: __method__ in soft_validations.add() (note that method is literally what you use).  It feels a little crude, and not as automagic as it could be, but might be workable, and gives us the flexibility to user/not resolution with a particular soft validation instance.  Need to further document what's going on.

Going to close this, the existing solution provides resolvable soft validations, albeit with some extra weight.  We can open an new issue when we need specific changes.


NonStdAttribute is not supported in JSONRPCNofication,is it a bug or jsonrpc protocal limitation?

From appendNonStdAttribute, there java doc as follwing:

@param name  The attribute name. Must not conflict with the existing

         "method", "id", "params", "result", "error" and "jsonrpc"

         attributes reserved by the JSON-RPC 2.0 protocol, else

         an {@code IllegalArgumentException} will be thrown. Must

         not be {@code null} either.

In parseJSONRPC2Notification method, "params" is not removed before appedNonStdAttribute.

// Extract params
Object params = json.get("params");
JSONRPC2Notification notification = null;
if (params == null)
notification = new JSONRPC2Notification((String)method);
else if (params instanceof List)
notification = new JSONRPC2Notification((String)method, (List)params);
else if (params instanceof Map)
notification = new JSONRPC2Notification((String)method, (Map)params);
else
throw new JSONRPC2ParseException("Invalid JSON-RPC 2.0 notification: Method parameters have unexpected JSON type", jsonString);
// Extract remaining non-std params?
if (parseNonStdAttributes) {
Iterator it = json.entrySet().iterator();
while (it.hasNext()) {
Map.Entry <String,Object> entry = it.next();
notification.appendNonStdAttribute(entry.getKey(), entry.getValue());
}

Hi,
It's an implementation limitation and not a JSON-RPC limitation.
Can you send an example of a Request Object that you did?
Thank you.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Don't miss out on your $1500 in BNB! Act now to secure your tokens.
Winners: @joaoabreu22, @Kewilleen, @m0nad, @luizstramasso, @Catureba, @felipesantos2, @jeffersonb7, @bryan-becker-isi, @paulo-santana, @Cyn-C, @Nilliam, @Aledev21, @JakeXp, @victorflll, @raimundo-matias, @vykthor1997, @renatanesio, @MA-Andrade, @dversoza, @passoz, @brunakauany, @cherryramatisdev, @gul4rtt, @leonardodf95, @diegolara, @muriloconsul, @osamucaaaa, @yaansz, @lucas-lucena, @doaard, @gabrieldep, @Douglasrochajp, @danilobarrosribeiro, @orihamos, @vitshenriques, @thiagoissao, @igorcaavalcante, @andretorquato, @maiaramendes, @rodriguesntc, @whoxer, @vinigofr, @gabrielpadron, @rocosttaa, @lesimoes, @gutoobrandao, @jonathan-eduardo, @lucasfok, @gusbruschi13, @brnmartins1


Dialog "Open coolmaze.net on computer" before scan

Caption "Please open page coolmaze.net on target computer, for scan".
Button [Yes] or [OK] or [Got it].
Checkbox or button "Don't show next time".
Then the "Open coolmaze.net ... ..." hint on scan screen (landscape instead of portrait) can be safely removed.

This would bypass issues #39 and #89.

Not needed anymore, since #39 is fixed. The full caption is now at bottom of scan view, in correct portrait mode.


Added new domain wu.ac.at, added english name on wu-wien.ac.at

Hi,
We kindly ask you to add another domain -> wu.ac.at, already existing domain name: wu-wien.ac.at
e.g. https://www.wu-wien.ac.at is already redirected to https://www.wu.ac.at
CHANGES:

added wu.ac.at as new domain name (same university)
added english name of university to wu-wien.txt

@pip3dr3am Pull request merged. Thank you!


Action icon has false color on quick order page

Actual Behavior
"Trash" action icon is black.

Expected Behavior
Actions icons have primary color and hover effect. See other clickable icons.

Steps to Reproduce the Bug
Steps to reproduce the behavior:

Go to 'Quick Order'
See trash icon

Environment Details

Desktop:

Browser: chrome
Version: 5.0.0

Additional Context, like Screenshots, Log File Snippets etc.

AB#94580

is fixed with 5.1


Handle flutter & unhandled platform errors

In this PR, I handled flutter-related errors and displayed the error widget

we are catching the errors on main() of both ensemble_starter and ensemble_live. You want to remove from there?

Yes, Can you check the new changes?

@vinothvino42 this was approved in July. what's the status here?

@vinothvino42 what's the delay here!!!

Sanjay handled a few flutter exceptions for the studio to be hanged (ex: incorrect parent widget exception). Right now, this change will trigger the overlay view whenever a minor error occurs in the app, so we need to do it with a different approach. Having a backup of this change and closing it as of now for monorepo


Not building on WSL

Hey Sagiri.
Someone wanted to have this injected into a FireRed ROM so I decided to lend them a hand because they're unable to set up a suitable environment to inject this by themself.
I got armips ready, I got the pret-preproc ready, I got all the other packages needed too I believe (git, make, python, devkitPro's gba-dev package, cmake, and build-essential), and yet, when I try to build this, I get the following error:
lunos:~/bpre-fame-hall$ make
(echo '#line 1 "src/fame-hall.c"' && pret-preproc "src/fame-hall.c" charmap.txt) | arm-none-eabi-gcc -O2 -mlong-calls -Wall -Wextra -mthumb -mno-thumb-interwork -fno-inline -fno-builtin -std=gnu11 -mabi=apcs-gnu -mcpu=arm7tdmi -march=armv4t -mtune=arm7tdmi -x c -c -MMD -I include -I gflib  -MF "build/src/fame-hall.d" -MT "build/src/fame-hall.o" -o "build/src/fame-hall.o" -
arm-none-eabi-ld --relocatable -T rom.ld  build/src/fame-hall.o -o "build/linked.o"
arm-none-eabi-size -d -B build/linked.o | awk 'FNR == 2 {print $4}' > "build/linked.sz"
python tools/freesia --rom rom.gba --start-at 0x0871A240 --needed-bytes 2840 > "build/linked.alloc"
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/lunos/bpre-fame-hall/tools/freesia/__main__.py", line 3, in <module>
    import sys, freesia
  File "tools/freesia/freesia.py", line 13
    def find_needed_bytes(*, rom, needed_bytes, start_at):
                           ^
SyntaxError: invalid syntax
make: *** [makefile:56: build/linked.alloc] Error 1
lunos:~/bpre-fame-hall$

Evidence that my terminal is reading armips and Pret's preproc just fine:
lunos:~/bpre-fame-hall$ armips
armips assembler v0.11.0 (Jan  8 2022 19:34:23) by Kingcom
Usage: armips [optional parameters] <FILE>

Optional parameters:
 -temp <TEMP>              Output temporary assembly data to <TEMP> file
 -sym  <SYM>               Output symbol data in the sym format to <SYM> file
 -sym2 <SYM2>              Output symbol data in the sym2 format to <SYM2> file
 -root <ROOT>              Use <ROOT> as working directory during execution
 -equ  <NAME> <VAL>        Equivalent to '<NAME> equ <VAL>' in code
 -strequ <NAME> <VAL>      Equivalent to '<NAME> equ "<VAL>"' in code
 -definelabel <NAME> <VAL> Equivalent to '.definelabel <NAME>, <VAL>' in code
 -erroronwarning           Treat all warnings like errors
 -stat                     Show area usage statistics

File arguments:
 <FILE>                    Main assembly code file
lunos:~/bpre-fame-hall$ pret-preproc
Usage: pret-preproc SRC_FILE CHARMAP_FILE [-i]
where -i denotes if input is from stdin
lunos:~/bpre-fame-hall$

EDIT: I use WSL2 with Ubuntu 20.04, for whatever that's worth.
If there's any other specific information that I need to provide, let me know.

Try doing make PYTHON=python3.
I personally use Arch and ArchWSL where python is automatically python3, so that's what I'm used to and what my makefiles are geared towards. I kind of forgot that most distros will have python be python2.
I should probably change that in my makefile(s).

I completely forgot about trying this yesterday. It worked perfectly, thank you!


How to hide a single Page from the list?

Hi all,
I need to hide a single page from the list in lib/template/directive/pages.html.
I need something like below in the config/menu.json, but conversely, and that working in Pages.html
    "type": "internal",
    "route": "public.pages.id({ id: 43 })"

It's possible?

You can use this hook to filter the response:
 onDataLoaded(response){
// filter here
    }

in this file https://github.com/shprink/wordpress-hybrid-client/blob/develop/lib/pages/pages.controller.js


test: add code coverage for nodejs

WIP
Web platform tests does not include the tests for search setter
Potentially strip trailing spaces from an opaque path with this.

Restarting CI jobs.


Streaming provider still shown in artist view after being removed

What version of Music Assistant has the issue?
2.0.0b141
What version of the Home Assistant Integration have you got installed?
2024.4.0
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
I removed Spotify as a provider. I observed two problems. Firstly for an Artist where I don't believe I had any items added to the library from Spotify I still see this at the bottom of the artist view

Then in an artist which did have a Spotify album added the album is still there but greyed out. No change after a MA restart nor a REFRESH ITEM

How to reproduce
Add a local file system provider.
Add Spotify
Add an album from Spotify to Artist A
Observe Artist B has Spotify in the Provider Details section of the Artist view due to linking
Remove Spotify
Restart MA
Observe Album in Artist A still visible but greyed out
Observe Artist B still showing Spotify in the Provider Details section
Music Providers
Local Provider
Spotify
Player Providers
Not relevant
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.4.4
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi

this one should be fixed in the next beta (b143)


"-t cleandead" does not clean up after itself when files are created outside of ninja

If a build rule formerly outputted a file libsomething.so, and then build.ninja is recreated to produce libsomething.so.1, the cleandead tool will delete the stale libsomething.so.
However, this might be created outside of ninja. Meson does this, and doesn't create a build rule for it. I have tried two solutions:

run cleandead once, then create the symlink after. This fails, because cleandead, run multiple times, will continue to delete the "dead" file, even though it already cleaned it once and no longer owns it
make the symlink into an implicit output of the regeneration command, which seems semantically logical as that's exactly what it does. This fails, because ninja goes into an eternal loop. Since it's a symlink, it reports ninja explain: output libsomething.so doesn't exist and tries to repeatedly recreate build.ninja

I believe that cleandead should be wiping the line from .ninja_log so that it doesn't try to re-delete a file that cannot be a dead output anymore.

The log is append only, try running cleandead once, then running recompact to get rid of the stale entry. Let us know if this solves your issue.


Beta Boot Issues

Pi 4 - interface didn't come up on first boot?

i might not have waited long enough. It worked fine after a manual reboot and on all reboots after

Pi 0/3 - got stuck in boot... No idea what's going on.

Will try again and see if i can capture the error message. It goes by too quickly. Whatever it is, it happens before the USB device is initialized

The pi3 image that built claims to have a corrupt initram or something.
The pi0 did boot, but I ran into this issue when it tried to start mqtt for the first time:
2021-11-19 02:58:50,148 CRIT Supervisor is running as root.  Privileges were not dropped because no user is specified in the config file.
2021-11-19 02:58:50,940 INFO supervisord started with pid 460
2021-11-19 02:58:51,951 INFO spawnerr: unknown error making dispatchers for 'mqtt': ENXIO
2021-11-19 02:58:52,975 INFO spawnerr: unknown error making dispatchers for 'mqtt': ENXIO
2021-11-19 02:58:55,005 INFO spawnerr: unknown error making dispatchers for 'mqtt': ENXIO
2021-11-19 02:58:58,026 INFO spawnerr: unknown error making dispatchers for 'mqtt': ENXIO
2021-11-19 02:58:58,038 INFO gave up: mqtt entered FATAL state, too many start retries too quickly

I was able to manually start the service, but not through systemctl. It seems as if MQTT is unable to start.

That was a bit of a rabbit hole. We need to change the systemd service ExecStart to look like /bin/sh -c "/mnt/persist/rhasspy/bin/rhasspy-voltron --user-profiles /mnt/persist/skiff/profiles --profile en 2>&1 | tee". systemd makes stdout look like a socket, but if you pipe to tee/cat it will directly write to the underlying stdout proc, getting around the socket situation. I'll make the change and then see what happens. We might be getting close!


bug: Wrong spacing in the searchView

Describe the bug
See https://github.com/Decathlon/vitamin-design/issues/124

In Compose, we have some hardcoded paddings in the TopAppBar and AppBar components from Material artifacts.
// TODO: this should probably be part of the touch target of the start and end icons, clarify this
private val AppBarHorizontalPadding = 4.dp
// Start inset for the title when there is no navigation icon provided
private val TitleInsetWithoutIcon = Modifier.width(16.dp - AppBarHorizontalPadding)
// Start inset for the title when there is a navigation icon provided
private val TitleIconModifier = Modifier.fillMaxHeight()
    .width(72.dp - AppBarHorizontalPadding)

Here, it is a snippet from AppBar.kt file. As you can see:

In all cases, there is always a padding of 4.dp at the beginning and the end of the appbar.
If there isn't navigation icon, the padding will be 16.dp (16.dp + 4.dp (automatically added) - 4.dp).
If there is an icon (the search icon for example), the padding will be 72.dp (72.dp  + 4.dp (automatically added) - 4.dp).

According this capture from the original issue:

We have 16.dp as initial padding, 24.dp for the navigation icon and 32.dp for the padding between the icon and the title, 16 + 24 + 32 = 72.
We are all good in compose! :)


Problem with NavController events when open tabbed page again from menu

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

When I open page with tabs subpages again from menu (SplitPane) I got next order of navController events for active subpage:

subpage ionViewDidLoad()
subpage ionViewWillUnload()

Events ionViewDidLeave and ionViewWillLeave not fired. They fired only when I change current tab to another.
Expected behavior:

I think events must be fired in next correct way:

ionViewWillUnload()
ionViewDidLoad()

and also must be fired event ionViewDidLeave and ionViewWillLeave.
In current version I can't do some things (unsubscribe important events) on ionViewWillUnload event because it fired after ionViewDidLoad!
Steps to reproduce:

Open page with tabs subpages from menu then open this page again from menu.
Related code:
MenuPage.html
<ion-split-pane>
  <ion-menu [content]="content">
    <ion-list>
    	<ion-item *ngFor="let p of pages" menuClose detail-none (tap)="openPage(p)">
	    	<ion-icon name="{{p.icon}}" item-start></ion-icon>
        {{p.title}}
      </ion-item>
    </ion-list>
  </ion-menu>
  <ion-nav #content main [root]="rootPage"></ion-nav>
</ion-split-pane>

MainPage.html
<ion-content>
	<ion-tabs #mainTabs ion-fixed>
	  <ion-tab [root]="page1Page"></ion-tab>
	  <ion-tab [root]="page2Page"></ion-tab>
	</ion-tabs>
</ion-content>

page1Page.ts
ionViewDidLoad() {
    console.log('ionViewDidLoad page1Page');
    this.events.subscribe('page:subevent', (format, period) => {
     ...
    });
  }
ionViewWillLeave() {
  	console.log('ionViewWillLeave page1Page'); // not fired when open mainPage again
  }
  ionViewDidLeave() {
  	console.log('ionViewDidLeave page1Page'); // not fired when open mainPage again
  }
  ionViewWillUnload() {
  	console.log('ionViewWillUnload page1Page');
	this.events.unsubscribe('page:subevent');
  }

console output:

ionViewDidLoad page1Page // opened first time
// opened second time
ionViewDidLoad page1Page
ionViewWillUnload page1Page

After this actions page not subscribed to page:subevent event.
Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : ios 4.4.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    Node       : v6.11.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b
    ios-deploy : 1.9.1
    ios-sim    : 6.0.0
    npm        : 3.10.10

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue with the page not having subscriptions?
Each load of the page should be its own instance of the page, not a shared instance. So it should work as such:
pageOne-Instance1 loaded, instance 1 subscriptions made
pageOne-Instance2 loaded, instance 2 subscriptions made
pageOne-instance1 unloaded, instance 1 subscriptions unsubscribed
At that point, though, the instance 2 subscriptions should remain subscribed as they exist on an entirely different object than the instance 1 subscriptions.

It's not about subscription. It's about order of NavController events. Subscription it's only example what works uncorrected with current behavior.

Also, my sample app is getting the ionViewWillLeave and ionViewDidLeave LC events when I click on the same menu item twice, so please include an example of that issue in your sample app as well.

Do you use tabs subPages on this page?

It would be best if you would provide a GitHub repo showing how this is causing issues in your application.
After discussing this issue with one of the developers who is familiar with the nav system coding and specifically the lifecycle events I have marked this as something to be addressed in version 4.x of Ionic.

Here I am again. I created repo (modified Tabs template): https://github.com/mifkys/ionic3-nav-problems and record video with wrong order of ionView events: https://youtu.be/FZe9Rm8Mc5w

Thank you. This will be very helpful when we revisit navigation and the lifecycle events.

Hi - we'll take a look at this ASAP.
Thanks,
Dan

Hi, this should be fixed. Please comment if it does not. It will be in the next release on Wed.
npm install<EMAIL_ADDRESS>
Thanks,
Dan


Remove tests for EventInvocation API that is going to be removed

We are planning to remove the EventInvocation API entirely and the "EventInvocationSynchronousEventServiceTest" tests are flaky, so removing them.
On the contrary, I wasn't able to get rid of "_future_invocation_asynchronous_event_service" based tests because "future_invocation" is not going anywhere and we need the tests.

Looks good; merge when test results come in.

Fixes #5567 and #5565.

Merging as this PR is part of python fixit.


Adding a webhook to build docs automatically with new commits

With the nbclassic readthedocs documentation up, a nice feature to make use of is to add a webhook to allow the documentation to build automatically. We can also add a badge to show the status of the docs in the Readme file for visibility.

@RRosio I think you said that the hook was enabled, but don't have the details. Is the website built on each merged PR?
For the badges, https://github.com/jupyter/notebook has a bunch of those, including the docs.

The code for that is

![Github Actions Status](https://github.com/jupyter/notebook/workflows/Build/badge.svg)
[![Documentation Status](https://readthedocs.org/projects/jupyter-notebook/badge/?version=latest)](https://jupyter-notebook.readthedocs.io/en/latest/?badge=latest)
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/jupyter/notebook/main?urlpath=tree)
[![codecov](https://codecov.io/gh/jupyter/notebook/branch/master/graph/badge.svg)](https://codecov.io/gh/jupyter/notebook)

@echarles Yes I believe that with each PR merged to the main branch the docs are built.
Thank you for the code samples I will work on adding them in a new PR!

Badge was added by #160 so I will close this issue as it's complete at this time.


drivers/syslog:support stream as syslog backend.

Signed-off-by: 田昕<EMAIL_ADDRESS>Summary
This is related to https://github.com/apache/incubator-nuttx/pull/7659.
This is the syslog which uses the stream(such mtd out stream) as backend.
Impact
When enabled, impact on syslog output,
Testing
Tested on ESP32C3

https://github.com/apache/nuttx/pull/7715 is a independent patch to add putchar interface for mtd and blk stream


Retry expired credentials

@bcall-r7 @bturner-r7 @eciramella-r7 Thoughts? I extended some changes that I found lying around from the brilliant @athompson-r7. Recalled those when I hit the credential error today.

I think a few rescue cases are missing:

availability_zones
validate
get_status
get_resources
get_events

I think a few rescue cases are missing:
availability_zones
validate
get_status
get_resources
get_events

@athompson-r7 Fixed in 63b2721! Removed some instances were we were rescuing the get_status higher in the chain as well.

Thanks @erran-r7 and @bcall-r7 for seeing this change through!


query OR

Hi guys,
How can I query with OR value?

This isn't supported in Firestore yet. We plan on supporting this before the end of beta (I think).

@morganchen12 it's on the roadmap in general but I don't think it will come by the end of Beta.

Ok tks guys,
I hope firestore will support it 💃


Fix asini bin linking

Fixes the issue identified in #79.  I do not have time to fix the test framework for this (sorry!), but automated tests really should test the functionality, not the existence of the function.

Note: this build is failing because of the issue identified in #78.  If you want me to change the package.json file in this PR to allow builds to pass, I can do that.  It makes more sense to me, however, to publish the 1.4.0 versions of the asini packages to NPM, then reinitiate builds.

No longer maintained.  Closing PR.


README

From the readme, i discovered that for every request I have to pass in username and password with token. Thats very very wrong.
Why  will I have to do that? Then, what's the use of the token generated?
Once I have been registered, When I login with the username and password, it should generate a token that I should just use for subsequent requests.
I dont need no username and password, only the token for all the other requests that needs authorization. Please Fix!

I actually already fixed this issue. I consulted with Bendozy on it and he said exactly what you just said. I fixed it thereafter, but didn't update the readme as regards it. I''m updating it now.


fix: sync consul health check service

Description:
fix sync consul health check service

Testing done:
Done

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Is this a breaking change? no

Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@e044260). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

pkg/connector/provider/consul.go
0.00%
13 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #586   +/-   ##
===============================================
  Coverage                ?   14.88%
===============================================
  Files                   ?      845
  Lines                   ?    62446
  Branches                ?        0
===============================================
  Hits                    ?     9298
  Misses                  ?    52972
  Partials                ?      176

Flag
Coverage Δ

unittests
14.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feat: display viewCount for Conversations

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:

Test Configuration:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Testing in PR Client
curl -X POST -H "Content-Type: application/json" -s \
 -H "Authorization: $TOKEN" \
 https://pr-143.d35bsvaicfsnob.amplifyapp.com/api/convos/f13c73e0-03a4-45ee-a8f7-2a233f997568/viewcount/increment | jq

example of working shared convo showing the viewCount: pr-143.d35bsvaicfsnob.amplifyapp.com/chat/share/a085f5cc-a125-4226-8b0e-a2614188517f


[sourcekitd] Fix some compiler warnings

remove nullability attribute from a non-pointer argument
const-correctness on custom buffer casts
remove statically unreachable code

@swift-ci please smoke test


saveToGallery

Thank you for this lovely code nicolay,
i'm trying to run it on mi Ipad but i got this error in xcode linking :
Undefined symbols for architecture armv7:
"_saveToGallery", referenced from:
RegisterMonoModules() in RegisterMonoModules.o
Do you have any idea how to resolve this issue ?
Thanks in advance

Thanks @kivzark
As i've told in readme.md file. I've used 3d party software. ScreenshotGallery is one of them. You don't have to use this plugin. and what you can to do is just search in project ScreenshotManager and remove or just replace this usages. also you should delete Assets/Plugins/ScreenshotManager.cs class


Bump metric-registrar plugin to v1.3.7

Built with Go 1.19.3

Submitting Plugins
If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins
In particular ensure the following requirements are being met:

[X] The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
[X] The plugin's url field in repo-index.yml contains the same version from the version field

Description of the Change
Bumps Go to 1.19.3.

Thanks!


feature/pop-up-overlay-behavior-consolidation-1.0.0

Consolidated the click behavior for indicators and oral history icons.
What is left

adding logic and/or updating data to allow longer descriptions to display a "show more" link
Adding logic to support displaying the larger modal window is a user selects to "show more"

Apologies for all the commented out code!

looks good. Merging.


writefilefromquery inconsistent date handling

I love this library, first of all.
I'm getting a strange result when trying to write an xlsx file directly from a query.  Some dates are being dumped as odbc timestamps, others are a datetime string.  Is there any way to override this or make it more consistent?  It would be very helpful to be able to pass in a date formatting string as well, such as dateformat='yyyy-mm-dd' or 'dd/mm/yyyy'
https://www.screencast.com/t/qiAAxgvj

NM - ignoring query data types and passing in a datatype object made them consistent.


Text input loading state

Issue: https://github.com/github/primer/issues/156
Adds a loading state to the text input. The loading indicator is positioned to avoid layout shifts in the component when it hides and shows.
loadingIndicatorPosition="auto" (default behavior)
Does not have a leadingVisual OR trailingVisual?
Show at the end of the input
Has a leadingVisual?
Show in place of the leadingVisual
Has a trailingVisual?
Show in place of the trailingVisual
Has a leadingVisual and trailingVisual?
Show in place of the trailingVisual
Does not have a leadingVisual?
Show at the end of the input
loadingIndicatorPosition="leading"
Show in place of leadingVisual if there is one, or show at the start of the input
loadingIndicatorPosition="trailing"
Show in place of trailingVisual if there is one, or show at the end of the input
Screenshots

Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Link to API exercise
This is the option that we all liked:
<TextInput
  leadingVisual={MergeIcon}
  trailingVisual={CheckIcon}
  isLoading={true | false}
  loaderPosition="auto | leading | trailing"
/>

What is the accessibility story for loading state? Does it need to be announced? Do we need to change the aria-describedby in FormControl?

I don't think we need to announce it, but I could be wrong. @alliethu - any input on this?

What is the accessibility story for loading state? Does it need to be announced? Do we need to change the aria-describedby in FormControl?

I don't think we need to announce it, but I could be wrong. @alliethu - any input on this?

@mperrotti I believe you would still want to indicate a busy/loading status to SR users.
cc/ @primer/accessibility-reviewers

Adding some potentially helpful resources (there's a description, notes, and a link to a recording inside):

https://github.com/github/accessibility/issues/415
https://github.com/github/accessibility/issues/560


HDFS-17675 BlockManager add logs

Description of PR
Add debug and warn logs in BlockManager for monitoring datanode decommissioning，which is useful for locating problems

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 59s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
37m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 78 unchanged - 0 fixed = 81 total (was 78)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
37m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
270m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

412m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7190/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7190

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fb94871e1532 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 22d59749c9543db185528ec3b7a4e1041c3750ed

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7190/1/testReport/

Max. process+thread count
3187 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7190/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


mano mean params.npz

When running the train file, the problem "No such file or directory, _DATA/data/mano_mean_params.npz" appeared. Could you please provide this file? Or how do I get this file? Sorry, I'm new to this.Any advice would be greatly appreciated. Thanks.

You will need to download the demo data to get this file. Please check the installation instructions.

Thank you very much for your help.

您需要下载演示数据才能获取此文件。请查看安装说明。
Thank you very much for your help.


[SPARK-40538][CONNECT][FOLLOW-UP] Fix less than comparison in Spark Connect expression

What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/38270 that changes __lt__ to use < that is less than comparison.
Why are the changes needed?
To less than comparison to use < properly.
Does this PR introduce any user-facing change?
No, the original change is not released yet.
How was this patch tested?
Unit test was added.

Test failure is not from this PR. Let me fix it in another PR.
Merged to master.


Improvement CD/CI

feat(build): Add Pub Score verification step
chore(workflows): Add pre-publish dry run step
refactor(dependency): Update dart_code_linter source
feat(workflows): Add Dart code linter to GitHub actions
docs: updated changelog
refactor(analysis_options): Update linter rules
chore: updated license

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
204

Relevant Lines:
204

💛  - Coveralls


List install VS Code extensions as part of --doctor

Just a little idea I had: What if we list the extensions as part of --doctor to aid with troubleshooting? The intention would be that people can paste this into an issue.

Stock VSCode is surely by far the most popular flavor but there are other like VSCodium https://github.com/VSCodium/vscodium which enjoys some usage. Another plus when delegating this to the extenion since it uses a different binary name and code doesn't exist, or worse, prints entirely different extensions.

@andyw8 do you still want to add extensions to --doctor flag after #2456?


CLIPSIM score for text-to-image generation

Is there a reference to the implementation for CLIPSIM score mentioned in the paper?

We use the CLIP model to calculate the similarity between the input query and the generated image, and our implementation is similar to the origin implementation in CLIP repo.


Investigate StyleCop tool

Investigate the StyleCop tool and ability to enforce predefined rules for every pull request to the Fragments-back-end repository

Estimation 6 hours

Is a part issues #9 #90 #94
Added to subtasks and done


Add support for streaming speech-to-text results

Large audio is split into multiple chunks, now we support stream: true, so that output chunks are emitted as soon as they are available.

@josevalim Nx should be good to go with respect to streaming, awesome job!


Dynamic shards

Added command line option: specify -d to use DeployDynamicShards in digtextsimilaritysearch/similarity_server.py

No rush on this. Just setting up Pull Request for the near future.

Will re-open this next week


Not working with window.parent?

Hi,
first of all, thanks for this great library!
I have the following situation where smoothscroll isn't working as expected:
A script of mine runs in an iFrame on a Wordpress page. The script detects whether it is called on its own or whether it's running in an iFrame and uses scrollIntoView in the former case and window.parent.scrollTo in the latter.
The former works nicely on Safari, but the latter does not. It just jumps directly to the given position as it would without smoothscroll.
I have tried setting window.__forceSmoothScrollPolyfill__ = true; before including smoothscroll and run it on Firefox where the problem does not arise (the parent window is scrolled smoothly which it also does natively without smoothscroll). So I assume this is not because window.parent.scrollTo is not supported by smoothscroll, but some kind of Safari related issue?
You can see this behavior in my project https://evangelisch-im-wendland.de/gottesdienste - just click on the "Suchen" button and it should scroll to the result section (instead of jumping there).
If there's anything I can do to provide more information for debuggin, please let me know - thanks!

Ok, I found the solution: In order to access smoothscroll from an iFrame on the parent window, smoothscroll has to be loaded there as well. Once this is done, it works like charm. Thanks again for your great work!


Error Inquiry - PlanBuild or MultiUserChest

Hey MSchmoecker, I can't tell if this error is related to PlanBuild or MultiUserChest.
Both mods still work.
[Error  : Unity Log] ArgumentException: An item with the same key has already been added. Key: -1394152847
Stack trace:
System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Collections.Generic.Dictionary`2[TKey,TValue].Add (TKey key, TValue value) (at <695d1cc93cca45069c528c15c9fdd749>:0)
ZNetView.Register[T] (System.String name, System.Action`2[T1,T2] f) (at <afd4e3f8ab8b460f8ff25d476fbd573e>:0)
MultiUserChest.Patches.ContainerPatch.RegisterRPCs (Container __instance) (at D:/Projects/No-Chest-Block/MultiUserChest/Patches/ContainerPatch.cs:40)
MultiUserChest.Patches.ContainerPatch.ContainerAwakePatch (Container __instance) (at D:/Projects/No-Chest-Block/MultiUserChest/Patches/ContainerPatch.cs:33)
(wrapper dynamic-method) Container.DMD<Container::Awake>(Container)
UnityEngine.Object:Instantiate(GameObject)
Player:DMD<Player::SetupPlacementGhost>(Player)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<Player::SetupPlacementGhost>?-977103872(Player)
PlanBuild.Blueprints.BlueprintManager:Player_SetupPlacementGhost(orig_SetupPlacementGhost, Player)
MonoMod.Utils.DynamicMethodDefinition:Hook<Player::SetupPlacementGhost>?-317712000(Player)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<Player::SetupPlacementGhost>?993413120(Player)
PlanBuild.Plans.PlanManager:Player_SetupPlacementGhost(orig_SetupPlacementGhost, Player)
MonoMod.Utils.DynamicMethodDefinition:Hook<Player::SetupPlacementGhost>?687405696(Player)
Player:SetSelectedPiece(Vector2Int)
Hud:SelectPiece(UIInputHandler)
Hud:OnLeftClickPiece(UIInputHandler)
UIInputHandler:OnPointerDown(PointerEventData)
UnityEngine.EventSystems.EventSystem:Update()

Thanks for taking a peak!

Do you have the OdinShipPlus mod installed? This error is because of an conflict with it. OdinShipPlus creates two containers on ships which is not done in vanilla and instead uses custom code. I'm working on a fix at the moment to exclude those ships from the interaction with MUC.
If you don't have the mod installed, what piece do you select when the error pops up? At least the stacktrace indicates that this is thrown when doing this.

Hey MSchmoecker, we do have OdinShipPlus mod install on the server. Is this something that could be a better player experience if we coordinated with Marlthon (mod author of OSP)? Happy to bridge the connection, just not familiar with the error and solution for that best experience.
Thanks for taking time to consider and look at the error!

I've already spoke with Marlthon an we concluded that this has to be fixed on the MUC side. The solution will be to exclude the OSP ships from interacting with MUC.

Fixed in 0.4.4. Ships with multiple containers from OdinShipPlus are excluded from MUC and behave as they normally would in the mod.


Update install command in README.md

Hey! I got an error when I ran the original install command. Maybe I'm being dumb or doing something wrong, but I edited the repo URL and it worked. Not super sure why, but it worked. This is the error I got:
❯ git clone git@github.com:Jean-Tinland/simple-bar.git $HOME/Library/Application\ Support/Übersicht/widgets/simple-bar
Cloning into '/Users/jasonaa/Library/Application Support/Übersicht/widgets/simple-bar'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Thanks for making this!

I have no problem into changing the project cloning protocol (HTTPS over SSH). It should work for everyone.
Thanks for the report and I'm glad this bar suits you!


⚠ Cioos National CKAN has degraded performance

In 96ccdbb, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5953 ms

Resolved: Cioos National CKAN performance has improved in a4c83e9 after 8 minutes.


⚠ Bofrost.de has degraded performance

In c4bc371, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 788 ms

Resolved: Bofrost.de performance has improved in da6c377.


fix choppy video

The video feels kind of choppy right now (as noted by jzwart). For instance, if you move the video slider through time, you can't get it to stop at every single day. Look into options for fixing that.

I think this might be what I need: https://unix.stackexchange.com/questions/68770/converting-png-frames-to-video-at-1-fps


mqtt Rollershutter Component - Buttons reversed on UI

I am trying to get the mqtt Rollershutter service operational but It seems that the buttons on the UI are displaying in reverse to what they should actually be. In the screen cap below, notice that the state of the door is 'closed'

This is the corresponding UI screen cap. Although though the door is closed, only the down arrow is highlighted which is wrong. When the door is in the 'open' position only the UP arrow is available. Obviously this cannot function correctly and needs to be reversed to allow the right button to be operational. It seems there is nothing else wrong with the component as I have tested STATES and the SERVICE and both work fine.

Thanks in advance
Kman

The current rollershutters are implemented that a position of 0 means it is closed: fully rolled up. It describes the state of the rollershutter, not the hole that it covers (door/window/etc). So the arrows are correct for what is being represented.


Add some features and more tests

Connection with issue(s)
Solution description
I've added a bunch of tests. There are some issues with null checks etc that should be fixed.
Screenshots or Videos

To Do

[x] Read contributing guide
[x] Check the original issue to confirm it is fully satisfied
[x] Add solution description to help guide reviewers
[x] Add unit test to verify new or fixed behaviour
[x] If apply, add documentation to code properties and package readme

Maybe in this MR can add the think that I commented here https://github.com/flutter-form-builder-ecosystem/form_builder_validators/pull/101#pullrequestreview-2079579665
Validate a lot the all validators, is something important before publish a new version

@deandreamatias I can look into faker_dart but for now would first like to implement the current tests and get a release out. Are you adding it in #104 ?

We can add the two things.
My idea is implementing in #104

@deandreamatias I've done a couple of fixes but one thing i notice is inconsistency in handling null and '' string checks. In general should a empty string or null value pass a validation? I would think not? But in all the older code it does.
What is your opinion?

@deandreamatias This one is finished now. I would prefer to refactor the inconsistency in handling null and '' and bump the whole release to a v11 with the breaking changes. If that is ok for you i'll make a new PR for that.

@martijn00 I don't know if empty string or null should be pass on validation. Maybe not.
I will take a look on code to understand better this behavior

Remember to use the macro on validators
/// {@macro hex_template}
static FormFieldValidator<String> colorCode({

@deandreamatias thanks! I'll have a look at the null checks next. In general I think the behaviour should be that if a value is null or empty it should show the error message, right?


feat(input-autocomplete): added onApply, onClear props

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 83.069%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
8770

Relevant Lines:
9694

💛  - Coveralls


ci: Fix bad workflow syntax

My previous fix to this workflow made a mistake in the syntax of the checkout ref.

Oops.  😢


Implement CIDRE-based tool for building flat-field illumination correction profiles

Also explore BaSiC.

Can we make use of the tile overlap to additionally constrain (i.e. improve) the correction? This paper might be relevant: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6011154/

I wanted to follow up if this is still active. If so it might be interesting to reconsider BaSiC as a python version was recently released  (https://github.com/peng-lab/BaSiCPy).


app.ens.domains occasionally unstable in Brave

no idea what the issue may be but the app occasionally crashes in Brave (v 0.66.100).
Happened just a few times:
(1) very first time loading, got stuck in a recursive flicker (seemed to load, but display unstable);
(2) second time don't recall exact sequence, but same symptom (flicker)
(2) once after using the app with no problem in Brave, it just bounced back into the strobe-like flicker.
No such problems in Chrome, where it works flawlessly. Just wanted to mention -- fwiw.  Each time fixed just by closing & reloading tab.
Thx for this great tool -- btw!
-- just updated to 0.70.123 & will let you know if it comes back.

Can you check to see if you are still having this problem? Thanks


CONTRIBUTING.md refers to next branch which is now v1-alpha

Problem description
The CONTRIBUTING.md refers to a branch called 'next' but it doesn't exist and gives an error, while cloning the alpha release version.
It Should be changed to 'v1-alpha'.
I am a first-time contributor and would like to fix and send a PR. Any additional information is welome.
Link to minimal working code that reproduces the issue

These two lines are in question:

Work towards rebuilding Material-UI with a new styling system is underway on the next branch. Please refer to the roadmap for more details.

Clone your fork to your local machine git clone --depth 1 git@github.com:<yourname>/material-ui.git
(For the next branch, add the -b next flag to the above command.)

Close to #7342, any PR is welcomed 👍


[380] enhance SonataFlowClusterPlatform.spec

Description of the change:
Enhance SonataFlowClusterPlatform.spec to better communicate which platform capabilities are being used by workflows cluster-wide. If spec.capabilities = nil,  defaults to capabilities.workflows["services"].
apiVersion: sonataflow.org/v1alpha08
kind: SonataFlowClusterPlatform
metadata:
  name: cluster-platform
spec:
  platformRef:
    name: sonataflow-platform
    namespace: central-platform-ns
  capabilities:
    workflows:
    - services

Motivation for the change:
fixes https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/380
There are 2 goals in mind -

Communicate, via the api, that workflows are the consumers of these cluster-wide platform capabilities. NOT services or any other future components.
Communicate, via the api, WHICH capabilities are being made available cluster-wide. Currently, that would be services... but there could be more in the future, e.g. build configs.

Checklist

[x] Add or Modify a unit test for your change
[x] Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede we can't preview the future atm, @wmedvede. But the core engine is already based on those capabilities in the form of Quarkus extensions. So, for instance, I can see cluster-level messaging, persistence, monitoring, and so on in the future. So leaving the API capable of accommodating those is the intention of this PR.

@tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller.

@jordigilh @ricardozanini should i add them to this PR or a separate one?

@tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller.

@jordigilh @ricardozanini should i add them to this PR or a separate one?

Any reason for not adding them to this PR already? Perhaps dependencies to other unmerged PRs?

Any reason for not adding them to this PR already? Perhaps dependencies to other unmerged PRs?

@jordigilh let me see what i can do

@jordigilh @ricardozanini i've added e2e tests

@tchughesiv can you please rebase?

@ricardozanini done


Condense prebid video docs into something more manageable.

🏷 Type of documentation

[ x] text edit only (wording, typos)

@karimMourra Thoughts? I have slimmed down the video sidebar significantly. I'm trying to highlight the prebid video module while still providing a path for people to implement things themselves if they so choose. I've also brought in the implementation examples from the Prebid.js repo.

I like the clean up. I haven't paying close attention the to instream vs outstream debate. What I noticed, is that Prebid.js for Video Overview there's still a distinction between outstream, instream and long-form video, which is not mentioned in the video module docs. A note what is support and what not would be helpful, if we cut all the links in the sidebar.
The general idea is that the video module should be used for all use-cases, right?

Thanks for the review Muki. Yeah the idea is that the video module should be used for all cases. I can clean up and update the wording in the video overview section good idea.


How to save/serialize model: WeibulAFTFitter

Hi there! Nice library this one! I have trained a model using WeibullAFTFitter and would like to reuse it without training it again... I've tried with the suggestions given in the documentation (pickle, dill, and also joblib...) but it keeps on throwing the same mistake:
" Sorry, pickling not yet supported. See https://github.com/pydata/patsy/issues/26 if you want to help."
If I try with the CoxPH model it works, but not under the WeibullAFTFitter. And the last one is the one showing best performance so I need to save it to disk.
Any thoughts on how to save/serialize a trained WeibullAFTFitter model for future usage?
Thanks

Hi @torresxavier, there was a recent regression in the latest lifelines: in order to support formulas (which, I am guessing you are using), we had to sacrifice some serialization. However, a solution is coming soon, in #1131 - should only be a few weeks.
If you are comfortable with pip, you can do pip install https://github.com/CamDavidsonPilon/lifelines/archive/try-formulaic.zip to install a working lifelines with full support for serialization.

I'll check that. Thanks @CamDavidsonPilon !!!

This is now native in lifelines


Updating cookiecutter1/3

This is the first PR out of three to update the cookiecutter. It is based upon PR #30.

[current] step 1: Merge master into cookiecutterbranch.
[next]  step 2: Remove validator sub-project (to be implemented later).
[next] step 3: Update cookiecutter with new project template.

@googlebot I consent.

@xyhuang I think you need to comment "@googlebot I consent."

Not relevant anymore.


Use ref for audioElement events instead of DOM interaction

Working on it.

Reference - https://github.com/anyaudio/anyaudio-web-app/blob/1d1e55c9ad1ec69c4ed3aa7f42f772b5d58bee8e/src/components/player/index.js#L67