Don't display properties marked as Deprecated in the request/response examples

Describe the Bug
OAS 3.1.x supports a deprecated tag, which Fern correctly applies to the schema. However, in Response Examples, deprecated properties still appear even when they are not defined in the OAS definition.
This results in inaccurate examples that may mislead customers.
Information to Reproduce
CLI Version
"version": "0.45.0-rc52"
Actual Behavior

Expected Behavior
For properties where deprecated: true not to render in response examples.

API Definition (if relevant)
In Example 1 below:

The customAddress array is null, but the rendered response example still incorrectly includes categoryName.
The chainalysisIdentification array is not null but does not define a categoryName example, yet the rendered response example still incorrectly includes categoryName.

              examples:
                example1:
                  summary: Example 1
                  value:
                    - asset: ETH
                      address: "0xC8a65Fadf0e0dDAf421F28FEAb69Bf6E2E589963"
                      cluster:
                        name: "PolyNetwork Hack 2021-08-10"
                        categoryId: 6
                      rating: "lowRisk"
                      customAddress: null
                      chainalysisIdentification:
                        addressName: "STOLEN FUNDS: PolyNetwork Hack 2021-08-10"
                        description: ""
                        categoryId: 6

@nateKlaux agreed that we should make this change! We're working on a project now to improve our parsing of OpenAPI. @RohinBhargava think this falls within scope of the OpenAPI parser improvements?


fix: double paste inside webviews

issue: pasting text into the inner webview would result in the text appearing twice. this was due to electron's handling of paste events in webviews which under certain conditions might trigger the event twice
to circumvent this a flag has been introduced to intercept and ignore every second paste event
https://github.com/smol-ai/menubar/assets/90765930/d603c75f-4cfd-431e-8e0b-2fd123cfebb3

another great PR!

Nice. Thanks for the fix!

@moismat i'm currently running v0.0.6 and i think i still have the issue.. can you confirm?

Looks like the issue still exists. It was triple-pasting; now it's only double-pasting. :)


TypeError("'ObjectId' object is not iterable")

Hi All
I'm trying to use this library to paginate data from a mongodb database using Motor.
I can get the paginate() query to work, and this returns the data from MongoDB/Motor - all good.
My issue comes when I try to then return this via fastAPI return_model and I get the following trace:
Traceback (most recent call last):
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 152, in jsonable_encoder
    data = dict(obj)
           ^^^^^^^^^
TypeError: 'ObjectId' object is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 157, in jsonable_encoder
    data = vars(obj)
           ^^^^^^^^^
TypeError: vars() argument must have __dict__ attribute
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 428, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/applications.py", line 284, in __call__
    await super().__call__(scope, receive, send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 259, in app
    content = await serialize_response(
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 146, in serialize_response
    return jsonable_encoder(
           ^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 66, in jsonable_encoder
    return jsonable_encoder(
           ^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 117, in jsonable_encoder
    encoded_value = jsonable_encoder(
                    ^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 131, in jsonable_encoder
    jsonable_encoder(
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 117, in jsonable_encoder
    encoded_value = jsonable_encoder(
                    ^^^^^^^^^^^^^^^^^
  File "/Users/myuser/GIT/fm_webCrawler/.venv/lib/python3.11/site-packages/fastapi/encoders.py", line 160, in jsonable_encoder
    raise ValueError(errors) from e
ValueError: [TypeError("'ObjectId' object is not iterable"), TypeError('vars() argument must have __dict__ attribute')]

I have the following setup to serialise the ObjectId to a string and can prove this works by just returning a List[MyModel] via fast api.

class PyObjectId(ObjectId):
    @classmethod
    def __get_validators__(cls):
        yield cls.validate

    @classmethod
    def validate(cls, v):
        if not ObjectId.is_valid(v):
            raise ValueError("Invalid objectid")
        return ObjectId(v)

    @classmethod
    def __modify_schema__(cls, field_schema):
        field_schema.update(type="string")

class Result(BaseModel):
    name: Optional[str]
    videolinks: Optional[List] = Field(default_factory=list)
    longdesc: Optional[str]
    highlights: Optional[List] = Field(default_factory=list)
    spec: Optional[List] = Field(default_factory=list)

    class Config:
        allow_population_by_field_name = True
        arbitrary_types_allowed = True
        json_encoders = {ObjectId: str}

class AMSStandardProduct(BaseModel):
    id: PyObjectId = Field(default_factory=PyObjectId, alias="_id")
    mpn: Optional[str]
    status: str = 'NEW'  # Set to enum when done.
    supplier: str
    url: Optional[str]
    result: Optional[Result]

    class Config:
        allow_population_by_field_name = True
        arbitrary_types_allowed = True
        json_encoders = {ObjectId: str}

@app.get(
    "/", response_description="List all products", response_model=Page[AMSStandardProduct]
)
async def list_products():
    products = await paginate(collection=db['supplier'])
    return products

@app.get("/all", response_model=List[AMSStandardProduct])
async def list_all_products():
    products = await db['supplier'].find().to_list(10)
    return products

It appears to be around the fact that when my model is no longer the top level, the serialiser fails.
Does anyone have any good examples of this pattern working with Mongo and Motor.
I'm happy to write the examples into the docs etc once I find the answer out :)

Hi @Bobspadger,
I guess you need to update json_encoders for Page class:
Page.__config__.json_encoders = {ObjectId: str}

Thanks - that is fantastic and it fixed it.
What is the best way for me to provide an example in the docs?

As an update to this, removing the PyObjectId and just setting the standard model to use the following:
class AMSStandardProduct(BaseModel):
    # id: PyObjectId = Field(default_factory=PyObjectId, alias="_id")
    id: str = Field(alias="_id")
    sku: str
    mpn: Optional[str]
    status: str = 'NEW'  # Set to enum when done.
    supplier: str
    url: Optional[str]
    result: Optional[Result]

    @validator('id', pre=True, allow_reuse=True)
    def validate_id(value):
        return str(value)
    class Config:
        allow_population_by_field_name = True
        # arbitrary_types_allowed = True
        # json_encoders = {ObjectId: str}

And it all now serialises happily through the Page object without having to monkey patch in the serialiser.

What is the best way for me to provide an example in the docs?

I guess the best way will be to add Examples sections to docs.

@Bobspadger I am closing this issue. I am happy if you will open PR with fix in docs.


Setting force = True in RegionGrowingAlgorithmBase.run() deletes smoothed_distances

To delete previous seeds and 4D objects-by-change (4D-OBCs) in the analysis object when running the  4D-OBC algorithm, one can set force to True.
The function then calls the invalidate_results() function, without any parameters. The default then deletes the smoothed_distances: https://github.com/3dgeo-heidelberg/py4dgeo/blob/bd7039430bae76accc06c9a42380a721c596aefd/src/py4dgeo/segmentation.py#L697C1-L697C42
This seems to be unwanted behavior, as one probably wants to use the smoothed_distances when computing 4D-OBCs, even if previous seeds and 4D-OBCs are preferably deleted.
A solution would be to either specify which attributes of the analysis object to delete in the invalidate_results function call, or change the default behavior of the invalidate_results function, to not delete the smoothed_distances.

I think the preferred way is to change the default parameters of invalidate_results() and would support this, as I agree that in most cases users will want to re-run solely the seed detection and segmentation:
def invalidate_results(self, seeds=True, objects=True, smoothed_distances=False) here
If parametrizing the function within the run() method, there would be two different behaviors when the function is called automatically or standalone, which could lead to confusion in usage.
A solution at the moment, without changing the source code, is to call invalidate_results()  before run() and setting the parameters as wanted:
analysis.run()

I do not have strong feelings here. Also, as using precalculated smoothed distances is purely a performance optimization, I do not see too big issues with backwards compatibility. (Also we are in the wild west that is v0.*)

@hdaan could you implement the suggested change and make a pull request?


ACC 3.2.1's output is not sufficient

Hi,
is there no specific CVE for Apache commons collection 3.2.1?
I only get CVE-2015-6420  (reads like Cisco only) and CVE-2017-15708 (reads like Apache Synapse) only. I also wasn't able to find anything else except CVE-2015-7501 which sounds like JBoss / Oracle only.
This can indicate to the user that there's no problem using this library which sounds like a bug to me.
Wouldn't it make sense for this renowned vulnerability at least to add something which doesn't come from the feed?
Thanks, Dirk
PS: Dependency-Check Core version 5.2.3-SNAPSHOT

You will need to ask either the Apache project,as a maintainer of AAC, or NIST as the maintainer of the CVE list.
see also https://nvd.nist.gov/vuln/search/results?form_type=Basic&results_type=overview&query=commons+collections&search_type=all

Why should I? As said the perception of the user matters and I am a user of this tool and it doesn't show me anything related which seems dangerous.
PS: yes, I read the Apache blog.

All dependency-check attempts to do is link the identified dependencies to the data from the NVD. We are 100% reliant on the data provided by 3rd parties regarding vulnerability information.  If you don't find the data valuable then please work with the NVD to improve the write-up.

I appreciate the project, believe me(!), but this is not a satisfying answer to me. Sounds like you pushing responsibilities to some place else instead.
How about some kind of an internal feed which includes such (rare and remarkable) cases so that a user gets a better picture?

PS: CVE-2015-7501 wasn't in there either

Yes I am pushing the responsibility of the data to another location. When I originally designed dependency-check one of the key tenets was that the project was not going to maintain a database mapping dependencies to CPE/CVE.  We've gotten away from that a little with our hints and suppression files.  Maintenance of an enhanced data-set is one of the things you will get with commercial offerings.
This project is 100% free, I do not make any money at all on this project - I am not a consultant, nor do I use this project at my day job. By creating an enhanced data-feed it adds an additional maintenance burden on the project that I feel is unacceptable.
Any updates to an enhanced data-feed would only benefit this project. However, if one were to contact the NVD suggesting updates to a vulnerability (I have and you can too - email that<EMAIL_ADDRESS>you then benefit everyone that uses the NVD data including other OWASP projects like dependency-track.

Hi @jeremylong ,
first of all: I much appreciate this tool. I didn't want to cause frustration or appear unappreciative.. I can also follow your arguments regarding maintenance burden for free software as I have two own projects.
WRT to the technical point: of course I respect+accept that. It was just an idea for an interface, which can be used for those rare case, not meant for general additions.
I can try when I have little more space on my desk to contact NVD but I am afraid my leverage is small.
Cheers, Dirk

The people at the NVD are really good. What I would suggest is just take some snippets from the Apache blog that would be a good addition to the current write-up(s) and send them the actual updated text with a reference to the blog.  That will get the fastest response.


Keep technology detections up to date

WebPageTest integrates with Wappalyzer to get the list of detection rules and run them through the detection engine during each test. The results are parsed from the HAR and written to the technologies dataset in the Dataflow pipeline. IIUC the biggest challenge is keeping the engine up to date because it needs to be reimplemented for WebPageTest's environment; it's less of an issue to keep the detection rules up to date for each technology since it's a simple JSON schema. Still, WebPageTest needs to periodically check for updates and stay in sync.
When technology detections are outdated or broken, several HTTP Archive dependencies are affected. Many Web Almanac chapters segment by technologies, like JS, CSS, CMS, and Ecommerce. Additionally, the Core Web Vitals Technology Report is a direct visualization layer on top of the output of the detections, so any bugs would be immediately visible there.
Similar to #30, the WebPageTest repo can use automation like GitHub Actions and/or dependabot to keep the rules in sync. But the engine will be much harder because it requires manual integration. At a minimum we need to know when the engine is out of date, using something like a file watcher on the engine's source code. I think it'd be worth connecting with @AliasIO and @tkadlec to brainstorm more reliable ways to keep Wappalyzer and WebPageTest in sync.
There's also more we can do on the HTTP Archive side to try to catch any anomalies late in the pipeline. While it'd be too late to fix broken detections, this should hopefully alert us to the bugs so that we can get them fixed before the next crawl. One thing we can do is look at a subset of individual pages with known technologies, and assert that they're detected correctly month after month. We could also look at the adoption rates in aggregate and flag anything anomalous like a steep rise or drop. The individual page approach has the benefit of being able to alert us ASAP before the crawl is even complete, but it does require some manual curation and upkeep. Not only can these approaches catch bugs arising from version skew across projects, but they can also help catch bugs in the rules/engine itself.

You should be able to automatically pull in updates to technology definitions. For API changes, I can create a discussion that anyone can subscribe to and announce changes there.

The automated updates are implemented.
It allows us to move the quality and freshness discussion to the technology definitions.
After we implemented the automation I listed a few actionable insights based on historical analysis. I suggest to move the discussion there.
@rviscomi do you have an idea on critical tech/websites list for an early detection? We could add those into wappalyzer Github checks.


Question about expected results

Hi @clarkkev ,

How long did you train ELECTRA-Small OWT
In the expected result section of READEME.md, you have mentioned "OWT is the OpenWebText-trained model from above (it performs a bit worse than ELECTRA-Small due to being trained for less time and on a smaller dataset)". How may steps have you trained ? And AFAIK openwebtext should be larger than wikibook, is that mean you use only part of the data ?

How come the scores in expected results
You have also mentioned "The below scores show median performance over a large number of random seeds.", is that mean the scores listed in that section is the scores of models pretrained from scractch with random seeds and each model was finetuned for 10 runs with random seeds, or is one pretrained model and finetuned for 10 runs with many random seeds ?

Did you use double_unordered in training models for expected results ?

Below is the original Kevin's reply to my email.

It is was trained for 1 million steps. I'm actually not sure how many epochs over the dataset it does, but the (public) OWT dataset is only about 50% bigger than Wikibooks I believe.

They are from the same pre-trained checkpoint with different random seeds for fine-tuning. The number of runs was at least 10, but much more (I think 100) for some tasks; I left the eval jobs running for a while and took the median of all the results.

Yes


feat: Use Swagger native OIDC/OAuth2 for handling user login [DEV-2921]

Task linked: DEV-2921 Use Swagger native OIDC/OAuth2 for handling user login

Superseded by #316


Finish i18n initial integration

fixes #651
translates menu
adds missing translations
adds translation automation

@romicolman
A next step would be creating a follow-up issue that covers:

language persistence
language detection from the system settings
testing not in English and catching all the missing translations (might be a separate one)

@roll when i was trying to implement this, I had the same e2e test error. if you are testing locally with the web app or even with make preview it doesn't mean the app build is working. Please test that the proper build is working.

@roll when i was trying to implement this, I had the same e2e test error. if you are testing locally with the web app or even with make preview it doesn't mean the app build is working. Please test that the proper build is working.

I just checked and the local build in Linux looks great and the translations work perfectly... I noticed the error report translations are missing, but this we knew already, but this line here is also missing: https://github.com/okfn/opendataeditor/blob/main/client/components/Views/Report/Table.tsx#L30 where it says 'Row number', could you add this translation?

@romicolman
Thanks!
Let's discuss the label on the planning. It might be better to keep it because I think it's a requirement regarding accessibility that all the input have to have corresponding labels.

Ok, perfect! Let's merge it for now :)


Dark/Light Mode Images Outside Header/Footer

Ideally, I would like to be able to include images in the body of the website that are dependant on the dark/light mode.
At the very least, I would like to be able to include another dark/light mode image in the footer as well as have a dark/light mode banner image.
My apologies, I am a relative novice when it comes to this kind of website development so I'm not yet able to describe problems using technical terminology...
I guess this comes down to three things:
Problem 1:
Using existing layout .html definitions - My first thought was to use something similar to header.html where the navbar {{ partial "logo" }} is used. I assume this partial is something inbuilt but I can't find any useful documentation on the usage (other than amending the logo.html which doesn't exist here).
Problem 2:
Determining dark/light mode status - I have also found documentation on this issue but it is dependant on the user's system setting as opposed to the dark/light mode "switch". I understand that, for example, in the page-header.html the class="from-body to-theme-light dark:from-darkmode-body dark:to-darkmode-theme-light ..... etc" is how it is determined. However, it seems to be implemented quite differently than other dark/light switching.
Problem 3:
Generic setting - I can see that it is possible to have dark/light mode images in general. I can't see how this would be done in the body text, though the above 2 points probably demonstrate why!
Thank you, in advance, for any help.

Hey @espinlove, Sorry for the late reply, you can add a class to handle this case. For light-mode images, you can add img-light and for dark-mode, use img-dark class.
here is an example
{{ partial "image" (dict "Src" "/images/img-light.png" "Class" "img-light") }}
{{ partial "image" (dict "Src" "/images/img-dark.png" "Class" "img-dark") }}


properly throw an exception in case an invalid state is encountered

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/14849
Properly throw an exception in case an invalid state is encounteredin TableCache::clear(). The previous implementation just used throw;, which is not valid here.
This is a trivial code improvement for an issue that we have never seen happening anywhere.

[x] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.

[ ] http://jenkins01.arangodb.biz:8080/job/arangodb-ANY-cppcheck/59/


Additional population guidance - EMS Event Header Information

EMS-MessageHeader-1 resource

Element
Description   or requirement

extension(eventMessageType)
The   spec does not mention the eventMessageType even though this item is mandatory   in the resource. There is no information to say when to use the   "new", "update" or "delete" values. We should   make clear what the expected use of the values should be if we want a generic   EMS approach or we should say that the expected functionality will   by outlined by the specific event message specifications if   the meaning of this field can be different for each of the events.       DF - We need to do a small   piece of work on the lifecycle of an event which we can refer to here.

event
I   assume guidance around which event type to use will be   included in the event specific guidance pages, therefore I think we   should add additional wording to say that which "event" value to   use will be specified in the specific event message specifications.

timestamp
This   is a mandatory element in the resource and has a meaningful description in   the profile so probably does not need to be in the spec, I would suggest   removing it as having it in the guidance page does not add any information.  DF - Agree

source
Currently   it says that the source element should be included but all the sub elements   are optional within the profile. I think we should add to the guidance a   minimum set of elements that we would like populating, probably the name,   contact.system, contact.value, ie enough information to be able to   contact the origional source of the event message. This could be done in the   profile by making the elements we want 1..1       DF - We do need to make the   provenance of the event clear – there are obvious overlaps with the   Organization resource so we need to consider which attributes the publisher   needs to include.

focus
We   should probably add wording to make clear that the "focus" element   will reference a different resource type depending on the event message being   sent and outline that the specification for each event message will define   which resource type this element will reference.       DF - Agree – we need to make   it clear what the focus refers.

EMS-Communication-1 resource

Element
Description   or requirement

status
The   "status" element is mandatory in the resource, we should probably   specify what it should be populated with as the different values can change   the meaning of the resource significantly, for example "completed"   is very different to "entered-in-error".      DF - Agree – this should be   linked to the lifecycle of an event which will define what values we would be   expecting.

sender
We   could do with additional information around which circumstanses this might   contain an organization or a helthcareService resource reference or no   reference. What are the use cases for each type of reference and   inclusion of the different resources?

payload
The   "payload" elemnet is mandatory so we should give guidance as to   what should be referenced and when. If the "payload" element   population is event specific then we should call it out in the spec to say   that population details will be in the event specific message specifications.

EMS-HealthcareService-1 resource

Element
Description   or requirement

providedBy
We   should probably call out what the reference "organization" resource   should represent and containing, for example an organization   resource containing an ODS Code identifier, representing the legal entity of   an organization?      DF - Agree

type
The   healthcare service "type" element has a fixed valueset which does   not have consistent values. For example EMS and PDS are services, UHV Health   Visitor is a person, CHO Child Health Organisation is an organization. Should   the service types actually all be clearly identifiable services, do we need   to re-visit this value set and make sure we have clear guidlines on what this   value set represents?

CareConnect-EMS-Patient-1 resource

Element
Description   or requirement

identifier   (localIdentifier)
The   local identifier slice is meaninless as it has a fixed value of "https://fhir.nhs.uk/Id/local-patient-identifier"   which means if two suppliers populate it with their local identifier, it is   no use to the other system as they don't know where the origional identifier   came from or what type of identifier it actually is. I would suggest removing   this slice from the profile. I heard this identifier slice is a hang over   from some CDA identifier stuff but is not appropriate or useful for fhir   resources    DF - Makes sense.

address
If   an address is included we should mandate atleast population of the text   element with the full address and only include structured address details if   all details can be populated fully, what is the minimum we would accept as a   structured address, just the post code and first line of the address? It   simplifies the consumers job if they know what to expect as a minimum rather   than the data possibly coming through in different ways within the resource   element.

contact
Probably   not relevant to NEMS core spec but we should have a consitent   expectation that if a contact is included for a patient what details we would   expect as a minimum, name, telephone number once again for consistency making   it easier for the consumer?

CareConnect-Organization-1 resource

Element
Description   or requirement

identifier
should   we want to add guidance that if the identifier is an odsSiteCode that there   should be an identifer with ODS Org Code or a partOf element with reference   to an organizaition. We need to make it clear where a consumer of this   resource can get the information to build up a picture of where this data   came from, i.e. if this is a site as per the site code where can I find   in the resource the organization which manages this site.      Like in other resources the local identifier slice is meaningless outside the   same fhir server as consumers may be using a different local identifier   system, because the system is a fixed value it is impossible to know what   sort of identifier is sent in this slice.

name
It   would be useful to have a name for the organization that a consumer could   just display, it might be worth mandating that publishing systems populate   this element, possibly making the element 1..1 in the profile.

telecom
Do   we want organizaiton resources to contain some sort of contact details for   the organization, ie make this mandatory for a publisher of an event?

Done most of the updates. A couple of things need seperate work such as event life cycle and I will create new issues for them. Changes have been committed to the develop branch.

This has been merged in and pushed to current version so closing.


Fix realtime statistics refresh

What?
The RealtimeStatistics widget periodically fetches data on each new momentum, but does not update the RealtimeTxsChart widget with the newly retrived data. The new data is only loaded when navigating from another tab.
Why?
The RealtimeTxsChart widget generates the Znn and Qsr spots data when the widget is initialized in the initState method.
@override
void initState() {
  super.initState();
  _znnSpots = _generateZnnSpots();
  _qsrSpots = _generateQsrSpots();
}

This method is only called once when the widget is created. When the stream is updated, the widget gets rebuild but does not generate new spots.
How?
The RealtimeTxsChart widget must generate the Znn and Qsr spots data whenever the widget configuration changes by overriding the didUpdateWidget method.
@override
void didUpdateWidget(RealtimeTxsChart oldWidget) {
  _znnSpots = _generateZnnSpots();
  _qsrSpots = _generateQsrSpots();
  super.didUpdateWidget(oldWidget);
}

Anything else?
This PR depends on PR https://github.com/zenon-network/syrius/pull/7; otherwise no chart will be displayed.

I'm not super familiar with flutter so just dropping this as reference for anyone else in the same boat
https://api.flutter.dev/flutter/widgets/State/didUpdateWidget.html


Change marker icon size

Is there a way to adjust the marker icon size ? I have alot of images which i am using as the marker icon but the sizes are too big so was wondering how to change the size and possibly make them rounded like normal CSS. Suggestions ?

Do you try this method to adjust the size ? https://github.com/tomchentw/react-google-maps/issues/306

Please refer to Getting Help section in the README (or #469).


Education version without TenantID Check?

Hi, recently a modification was found to play online on education edition without having a tenant, and, i tried this project to see if it works, but it doesn't, there appears to be an issue with tenantid check, that will not work. There is a version of geyser reversion that works without TenantID? and btw i can't compile this

Sorry I havn't been updating this is a long time as I moved towards trying to create a proxy that can sit in front of Geyser. Do you know more about the tenantid checking? Also depending on how it avoids the check it may only be a temporary thing till they patch it

well, the TenantID was removed from exe, so education doesn't check if you been logged in on a school account, with the own tenant geyser actually does check that and i think it gliches out without knowing what to do. The solution that i'm thinking its removing that check, and btw, i send you the modded exe so if you want, you could try it
1.14.70 V2.zip
https://archive.org/download/minecraft-education-edition-win32/MinecraftEducationEdition_x86_<IP_ADDRESS>.exe

Servers were cracked now :) only working on versions before 1.12!


Live

Test PR

Docs Build status updates of commit 8dce002:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


net: gptp: fixes related to multiple ports management

Hello, first let me introduce myself ;)
I am a software engineer working on automotive SoC that embed a TSN Ethernet switch. I am doing some tests using the Zephyr L2 gPTP stack. And well, I must thank all the contributors for this very nice job.
That is said, I met some issues especially whenever several gPTP ports are enabled:

Whenever my device under test behave as a transparent clock (so when SYNC/FUP messages must be forwarded from one gPTP slave port to another gPTP master port), I met an issue related to correction field of FUP message that was not properly updated (it was systematically set to 0 instead of taking link propagation delay & residence time into account). So  I did the following patch:

net: gptp: fix again computation of follow up correction field

I also noticed SYNC/FUP could be mistakenly generated by ClockMasterSyncSend state machine event if time aware system is not acting as the grand master clock (but is just a transparent clock). So this patch:

net: gptp: do not run clock master sync send SM if we are not the GM clock

Then, in case time aware system is the Grand Master clock, I saw that computation of scaled_rate_offset variable
in gptp_md_follow_up_prepare() looks not correct. So this patch:

net: gptp: fix rate_ratio in gptp_mi_set_ps_sync_cmss()

Finally, if the device is acting as a Grand Master clock (while having several gPTP master ports as capable), I noticed that SYNC/FUP messages were only transmitted to one port after a couple of time. So I did this patch:

net: gptp: fix race condition on timestamp callback
While it seems to build on latest HEAD of main branch, I only tested it on a quite old revision of Zephyr kernel (that is compatible with my DUT).  Transparent-clock & GM clock test-cases with multiple ports of our DUT connected to certified tools looks ok at first sight.
But those patches may not be perfect for sure. So feel free to challenge of course!
Regards, Jean-Nicolas.

Hi guys,
So I finally did a gPTP transparent clock test (relaying GM time in between gptp Slave port of DUT to a gPTP Master port), and monitoring time synchronization offset in between Master and Slave endpoint. Test is still running after 13 hours of testing with slave endpoint still synced to master endpoint.

Regards Jean-Nicolas.

Hi guys,
So I finally did a gPTP transparent clock test (relaying GM time in between gptp Slave port of DUT to a gPTP Master port), and monitoring time synchronization offset in between Master and Slave endpoint. Test is still running after 13 hours of testing with slave endpoint still synced to master endpoint.

Regards Jean-Nicolas.

Thanks for the test, I'm in the middle of moving to another city right now, I'll rebuild the test platform to try it out when I'm done, Zypher does seem to be missing the PPS API at the moment, I think the MCU's 1588 timer (such as STMF4 and NXP RT10xx which tested) is also generally weak to programming PPS, this could be one of the reasons.
Here's my another PR: #61521 if you're interested in. After apply those patches, I use RT1052 as GM and STM32F407 as Endpoint, 802.11AS defaule profile(125ms sync interval), accuracy can be within 40ns.

Hi guys,
So I finally did a gPTP transparent clock test (relaying GM time in between gptp Slave port of DUT to a gPTP Master port), and monitoring time synchronization offset in between Master and Slave endpoint. Test is still running after 13 hours of testing with slave endpoint still synced to master endpoint.

Regards Jean-Nicolas.

Thanks for the test, I'm in the middle of moving to another city right now, I'll rebuild the test platform to try it out when I'm done, Zypher does seem to be missing the PPS API at the moment, I think the MCU's 1588 timer (such as STMF4 and NXP RT10xx which tested) is also generally weak to programming PPS, this could be one of the reasons.
Here's my another PR: #61521 if you're interested in. After apply those patches, I use RT1052 as GM and STM32F407 as Endpoint, 802.11AS defaule profile(125ms sync interval), accuracy can be within 40ns.

Hi Chen, No worry take your time. Thanks for the answer and for sharing #PR 61521.
Basically, without implementing any kind of PID algorithm in gptp_update_local_port_clock(), I tried to tune a bit that function. My PTP reference clock on our current (FPGA) setup is rated at a quite low frequency. So, I guess I cannot get something very accurate for the moment.
My DUT implements the full PTP clock. The only hack I changed in gptp_update_local_port_clock() to avoid getting high jitter, was to only call the fine correction method (=ptp_clock_rate_adjust()) and not the coarse one based on time increment (=ptp_clock_adjust()), this once time offset in between GM and local clock reached some minimum value. But this might not be optimal at all for sure. I will take a look to your patches. Thanks.

Hello, any updates about reviewing/merging this PR ? Thanks Jean-Nicolas.

ping @chencaidy

Hello @chencaidy, did you find some time to cherry-pick this PR and check it works well at your side ?
Thanks.


TestcontainterBuilder hangs / crashes test process

Description
We are using TestcontainerBuilder to configure a MsqlDatabase to be used for testing. The tests are then executed via Azure Pipeline run, whereas 'dotnet test' is called.
In some cases we cannot see any progress in the pipeline task when the test case is hitting the TestcontainerBuilder. It's like the whole process freezes or even gets killed.
To Reproduce
The issue shows up only on every 10th run, i.e., it usually works. We can not clearly reproduce it but just be retriggering the pipeline several times.
Expected behavior
The issue should not show up in any case.
Code
private async Task<ITestcontainersBuilder<MsSqlTestcontainer>> CreateTestContainerBuilderAsync(MsSqlTestcontainerConfiguration configuration)
        {
            var waitStrategy = new SqlInContainerWaitStrategy(IntegrationTestDatabaseName);
            Console.WriteLine("Created wait strategy for TestContainer...");
            try
            {
                ITestcontainersBuilder<MsSqlTestcontainer> testcontainersBuilder = null;
                lock (_lock)
                {
                    Console.WriteLine("Before creation of test container...");
                    testcontainersBuilder = new TestcontainersBuilder<MsSqlTestcontainer>()
                                .WithEnvironment("ACCEPT_EULA", "true")
                                .WithDatabase(configuration)
                                .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(waitStrategy))
                                .WithCleanUp(true); // Temporarily change this to false if you want to inspect docker container after it stops:
                    Console.WriteLine("After creation of test container...");
                }

                return await Task.FromResult(testcontainersBuilder);
            }
            catch (Exception e)
            {
                Console.WriteLine($"Could not create Testcontainer builder: {e}");
                return null;
            }
        }

When  the issue occurs, 'Before creation of test container...' is the last statement we can see on the pipeline window. Note that we, for the sake of debugging, introduced a timeout on the calling client, i.e., if the Task shown above does not finish within a certain time period, it shall be cancelled and rerun. However, as stated, nothing happens after the last printed statement like if the process is dead, caused by new TestContainersBuilder() as we assume.
The WaitStrategy's constructor does not do anything else than just assigning a string property.
The lock-block is there as multiple threads hit that location in parallel: We just wanted to make sure it's not caused by multi-threading.
Desktop (please complete the following information):
We use the latest release, say 2.2.0 (NuGet)

Hm, this example looks wrong in multiple ways, especially the TPL part looks odd. I don't understand why you wrap it inside a task. I assume most of the stuff is not necessary. Can you test a simpler implementation? Considering we keep the task, what about:
TestcontainerDatabaseConfiguration configuration = new MsSqlTestcontainerConfiguration();
configuration.Password = Guid.NewGuid().ToString("D");

var containerDefinitions = await Task.WhenAll(CreateContainerDefinitionAsync(configuration), CreateContainerDefinitionAsync(configuration), CreateContainerDefinitionAsync(configuration))
  .ConfigureAwait(false);

await Task.WhenAll(containerDefinitions.Select(containerDefinition => containerDefinition.StartAsync()))
  .ConfigureAwait(false);

private static Task<MsSqlTestcontainer> CreateContainerDefinitionAsync(TestcontainerDatabaseConfiguration configuration)
{
  return Task.FromResult(new TestcontainersBuilder<MsSqlTestcontainer>()
    .WithDatabase(configuration)
    .Build());
}

This starts multiple MSSQL containers. How do you call and await CreateTestContainerBuilderAsync(MsSqlTestcontainerConfiguration)?

The WaitStrategy's constructor does not do anything else than just assigning a string property.

I would not recommend to override the module wait strategy without the default wait strategies. Your setup will indicate readiness to early. Use something like:
WithWaitStrategy(configuration.WaitStrategy.AddCustomWaitStrategy(new SqlInContainerWaitStrategy(IntegrationTestDatabaseName)))

All this 'odd' things in there have just been introduced in order to find the root cause. We don't need the task, it's just there to be able to introduce a timeout - but in the end this did not help at all.
The original implementation simply looks as:
Console.WriteLine($"Container configuration created with image {sqlTestcontainerConfiguration.Image}");
var testcontainersBuilder =
                new TestcontainersBuilder<MsSqlTestcontainer>()
                    .WithEnvironment("ACCEPT_EULA", "true")
                    .WithDatabase(sqlTestcontainerConfiguration)
                    .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(waitStrategy))
                    .WithCleanUp(true); // Temporarily change this to false if you want to inspect docker container after it stops:

Console.WriteLine($"Container builder initialized...");

var testcontainer = testcontainersBuilder.Build();

Same issue here: We can see 'Container configuration created with image' on the output, but not "Container builder initialized..."
We see two threads running the initalization in parallel - that's why we played around with lock() and other stuff.
The wait strategy looks like:
 public class SqlInContainerWaitStrategy : IWaitUntil
    {
        private readonly string _integrationDatabaseName;

        /// <summary>
        /// Initializes a new instance of the <see cref="SqlInContainerWaitStrategy"/> class.
        /// </summary>
        public SqlInContainerWaitStrategy(string integrationDatabaseName)
        {

            _integrationDatabaseName = integrationDatabaseName;
        }

        /// <summary>
        /// This wait strategy trying to execute a simple query on the database to check if it is ready.
        /// </summary>
        public async Task<bool> Until(ITestcontainersContainer testcontainers, ILogger logger)
        {
        }
}

As Until() is only executed later, say not in new TestcontainersBuilder(), we did not expect to find the root cause in here.

Can you please share how you call the method that returns the configuration? What test framework do you use?

We use XUnit test framework.
The relevant code portions are as:
public sealed class SqlInContainerDbStrategy : ITestDbStrategy, IAsyncDisposable {

        private const int MaxRetries = 5;
        private MsSqlTestcontainer _testcontainer;

        public async Task InitializeAsync()
        {
            var retries = 0;

            while (_testcontainer == null && retries < MaxRetries)
            {
                Console.WriteLine($"Initializing container. Retry: {retries}");

                try
                {
                    _testcontainer = await CreateContainerAsync();
                }
                catch (Exception ex)
                {
                    retries++;
                    if (retries > MaxRetries)
                    {
                        var errorMsg = $"Error! Failed to start SqlServer in Docker! Max tries count has been reached! ErrorMsg: {ex.Message}";
                        Console.WriteLine($"Error! Failed to start SqlServer in Docker! Max tries count has been reached! ErrorMsg: {ex.Message}");
                        throw new Exception(errorMsg, ex);
                    }

                    Console.WriteLine($"Failed to start SqlServer in Docker, retries = {retries}/{MaxRetries}, {ex} ");
                    await Task.Delay(TimeSpan.FromSeconds(3));
                }
            }

            if (_testcontainer == null)
            {
                throw new OperationCanceledException($"Could not initialize container after {MaxRetries} retries.");
            }

            Console.WriteLine($"Container created based on image {_testcontainer.Image.Name}:{_testcontainer.Image.Tag} and its state is: {_testcontainer.State}");
        }

        private async Task<MsSqlTestcontainer> CreateContainerAsync()
        {
            Console.WriteLine($"Creating SQL container...");
            var imageName = Environment.GetEnvironmentVariable("SqlInContainerImage"); // @"mcr.microsoft.com/mssql/server:2019-CU16-ubuntu-20.04";

            if (imageName != null)
            {
                Console.WriteLine($"Using container image: {imageName}");
            }

            var waitStrategy = new SqlInContainerWaitStrategy(IntegrationTestDatabaseName);

            var sqlTestcontainerConfiguration =
                string.IsNullOrEmpty(imageName) ?
                new MsSqlTestcontainerConfiguration() :
                new MsSqlTestcontainerConfiguration(imageName);

            // See MSSQL password policy at https://hub.docker.com/_/microsoft-mssql-server
            sqlTestcontainerConfiguration.Password = _faker.Internet.Password(length: 10, prefix: "aB1");

            Console.WriteLine($"Container configuration created with image {sqlTestcontainerConfiguration.Image}");

            var testcontainersBuilder =
                new TestcontainersBuilder<MsSqlTestcontainer>()
                    .WithEnvironment("ACCEPT_EULA", "true")
                    .WithDatabase(sqlTestcontainerConfiguration)
                    .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(waitStrategy))
                    .WithCleanUp(true); // Temporarily change this to false if you want to inspect docker container after it stops:

            Console.WriteLine($"Container builder initialized...");

            var testcontainer = testcontainersBuilder.Build();

            Console.WriteLine($"Container initialized with image: {testcontainer.Image.Name}:{testcontainer.Image.Tag}");

            try
            {
                // Adding timeout for the container initialization.
                var tokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(60));
                await testcontainer.StartAsync(tokenSource.Token);

                return testcontainer;
            }
            catch (Exception ex)
            {
                await testcontainer.DisposeAsync();
                throw new Exception("Failed to create container!", ex);
            }
        }
}

Thank you very much! I'll try your proposals!
But anyhow - at least to me - it's working in 9 out of 10 times approximately.
Will keep you posted.

is that it's working in 9 out of 10 times approximately.

Yes, something is broken then. Never saw a behavior like that. I am also not aware of any blocking task in the 2.2.0 builder. Notice the logging is not part of 2.2.0. To receive the messages checkout develop.

Hi Andre,
after some more resarch it's very likely the issue is / was caused by Xunit. I found some articles in which others reported issues with parallel initalization of Xunit Collections. After having disabled that for our case through:
[CollectionDefinition(SharedDatabaseTestCollection.Name, DisableParallelization = true)]

The issue did not occur again since then.
Thank you very much again for your outstanding support!


Requests

Describe the feature you'd like to see added

Able to disable rain to increase FPS after Del Lago Boss Fight
Crosshair style (gamecube, cross, triangle, square, circle)
Crosshair thickness
Disabled QTE needs increase the ability to do things like swim fast during Del Lago fight, operating (canon on castle, Ashley rotating), being hold/bitten by enemies/boss
Disable fade & become quick loading when opening doors for the next checkpoint
Disable Separate Ways Title Animation
Switchable day and night. I love to play and enable night time for new experiences.
Add playtime in real-time (up to 12-hr) while you're playing in any campaign outside the typewriter save
Scope style
Infrared scope color variation inspired from re4 remake
Smaller subtitles in main game, extras and mercenaries
Fix drops disappearance from enemies
Even smaller buttons interaction of objects, doors, QTEs, etc.

Auto-collect drops from enemies (without animation), and disable the big glow thing too, thanks.

Auto-collect drops from enemies (without animation)
Disable big glow thing is already in nexus by Renzk https://www.nexusmods.com/residentevil4/mods/248

The players will pick up the drops from enemies or from objects without animation showing just like re4 remake.

Big glow removal, great idea, thanks for the link... i extracted HDProject's core.udas (i use the one from  SMALLER, SIMPLIFIED HUD) and compared ....
... this six files are different but i don't know if the HDProject HUD mod will be impacted if merged :
core\core_01.EFF
core\core_06.MDT
core\core_17.MDT
core\core_27.UWF
core\core_34.UWF
core\core_36.UWF

also an option to prevent the forced map-opening you get in some new areas.


Build workflow

Implementation of a workflow to perform the build and tests of the application when a pull request is created for the develop branch

closed with PR #2


FALCON-710 , FALCON-711, FALCON-712. Process Updates to sla changes, Start Instances and end instances. Duplicate entries.

Merging it  as per discussion with @pallavi-rao


Yarn Support!!!! 🎉🎉🎉🎉

Utilizes the new pattern of adding dependencies to the store then installing all dependencies simultaneously near the end of the main function. I think @alocke12992 that you'll find this is a far cleaner PR than the previous work.

we will see.....
https://s-media-cache-ak0.pinimg.com/originals/9d/ab/90/9dab90322c4fdd35f0c3e7bb3eaed9d1.jpg


Remove DataReader interface, stop using GraphHopperOSM

Now that OSMReader is in core, we do not really need GraphHopperOSM anymore. Also the DataReader interface is no longer useful. Custom data reading is best implemented by overriding GraphHopper#readData now.

Ok, lets do further changes in subsequent commits:

rename get/setDataReaderFile -> get/setOSMFile

datareader.file -> osm.file

remove GraphHopperOSM

seems simple enough to me. 2) I am not sure because it will break so many/all configurations and maybe we will have to rename it again in case we make the configuration more hierarchic/modular? Sure considering that the java variable is called osmFile this might be a bit counter-intuitive, but then again it always was? Same thing for 3). Removing it forces lots of down-stream code to change while keeping it means little extra cost for us at the moment. I think we should just deprecate it here and remove it for GH 4.0?

Ok, lets do further changes in subsequent commits:

rename get/setDataReaderFile -> get/setOSMFile

datareader.file -> osm.file

remove GraphHopperOSM

seems simple enough to me. 2) I am not sure because it will break so many/all configurations and maybe we will have to rename it again in case we make the configuration more hierarchic/modular? Sure considering that the java variable is called osmFile this might be a bit counter-intuitive, but then again it always was? Same thing for 3). Removing it forces lots of down-stream code to change while keeping it means little extra cost for us at the moment. I think we should just deprecate it here and remove it for GH 4.0?

Now that OSMReader is in core, we do not really need GraphHopperOSM anymore. Also the DataReader interface is no longer useful. Custom data reading is best implemented by overriding GraphHopper#readData now.

Sorry for kicking an old PR, so mostly not relevant, but if GraphHopper#readData is the preferred way to read data, shouldn't this method be public instead of protected?

Which version are you looking at? GraphHopper#readData no longer exists in the current master branch.


"Import Brownie could not be resolved"

Its basically the same problem with solcx a few days ago, but its not working with a virtual environment either.
So I copied every step from Patrick.
i installed pipx:
python3 -m pip install --user pipx
Then:
python3 -m pipx ensurepath
Then I've installed brownie and it works perfectly fine.

I can even compile stuff, its working:

Here comes the problem. "Import Brownie could not be resolved":

Then I remembered, maybe I need a virtual environment. So deleted the folder brownie_simple_storage and started again from scratch.
mkdir brownie_simple_storage
Open the folder.
I created the virtual environment python3 -m venv tutorial-env activated it source tutorial-env/bin/activate after that I've installed everything on the virtual env, tried brownie init and it didn't work, it showed an Error.
To solve this I deleted the virtual environment tried brownie init again and then brownie worked.
So I did understand that brownie init must come first, after that comes the virtual environment, otherwise it won't work.
So after brownie init I create the virtual environment python3 -m venv venv after that I activate it source venv/bin/activate, so it look like this:

After that I try to install python3 -m pip install --user pipx on the venv, it don't work, I take out the --user it works.
Then I do python3 -m pipx ensurepath, no error.
I do install eth-brownie successfully. I do have pipx and pip installed successfully.
pip list, pipx list:

brownie --version, pip --version, pipx --version:

Unfortunately its still not working, can't import from Brownie. I have a guess that maybe somethings wrong with the Path.
I know its a really long Issue, but I wanted to show every detail.
I would be really thankful if somebody could help me out.

Did you try to run a script using for example "brownie run scripts/deploy.py"?
I always discard yellow problems from VS, and everything works, even if it says "Import "brownie" could not be resolved"

brownie run scripts/deploy.py

It worked.  Thank you very much.
You know because last time in solcx when I compiled, it didn't work, so I thought it won't work here also, so I didn't even try to  do brownie run scripts/deploy.py.

Thx man, big love

To get rid of the yellow warning the suggestion for VS code from here helped me:

Ctrl+Shift+P (or Ctrl+Cmd+P on Mac)
Python: select Interpreter
Choose the python in your virtenv, e.g  ~/.local/pipx/venvs/eth-brownie/bin/python

This seems like some voodoo magic to me. @ArsenPe can you give any more details on how you were able to change that? I've got this screenshot here as the closest I can get.

@louisamira:

Click Python: Select Interpreter
Click Enter interpreter path...

That's should be it :slightly_smiling_face:


New Contributor Hex-24

Added contributor

I guess you have some problem in naming the json file, otherwise everything looks good and still build is failing.

Thanks Abhishek ....new to github


cvat memory usage too high

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Steps to Reproduce (for bugs)

update cvat from v2.4.5 to v2.6.0
just start the container by docker compose -f docker-compose.yml -f docker-compose.override.yml up -d

Expected Behaviour

not occupying too much memory, according to my colleague the previous 2.4.5 version only consumes around 2G, however current service round 6G above.
Current Behaviour

current service occupys around 6G above.
Possible Solution

I think may restart service can solve the problem, however it doesn't change too much.
Context

Cause we're using cvat in our company, and when mem is above certain threshold, it continue throws warning, which is very annoying, and we can't close it.
Your Environment

Git hash commit (git log -1): zip version of release 2.6.0
Docker version docker version (e.g. Docker 17.0.05): 24.0.2
Are you using Docker Swarm or Kubernetes? maybe the first one
Operating System and version (e.g. Linux, Windows, MacOS): Linux
Code example or link to GitHub repo or gist to reproduce problem:  referring to https://opencv.github.io/cvat/docs/administration/advanced/upgrade_guide/#how-to-upgrade-cvat-from-v220-to-v230
Other diagnostic information / logs:
Logs from `cvat` container

cvat_server.log

It would be nice if you could add some details about the problem (which container is consuming more memory than you expect, screenshots, etc) and help to investigate this issue, especially you have full access to the machine that cvat is running on.

From your screen, it looks like the clickhouse-serv process is only consuming ~206MB RAM... You're talking about 4GB in your first post. Have I missing something?
Please provide as much information as possible, without this it is impossible to guess which CVAT component is consuming RAM in your case.

sorry to miss the total mem occupied by the whole cvat project, can you help me figure out the cpu usage, I only have two core for the machine, however the clickhouse-server cosumes about 400% of it, and it often throws out the error that "load5 per core", which meas the cpu load is very high.

You can set cpu limits for clickhouse https://docs.docker.com/compose/compose-file/deploy/#resources
or disable analytics if you don't need them https://github.com/opencv/cvat/issues/6863
or consider using a machine with a larger cpus

Same for me :( Running on 2 cpus and 8GB memory the instance dies with:
Mar 07 13:22:43 cvat systemd[1]: docker-cc7f54d21eebd5e6a4e8fd5304a20eb48578a60e9b3cdf277cad1c8491ba6d80.scope: A process of this unit has been killed by the OOM killer.

Watching top command cvat_clickhouse consumes a lot...
trying to set limits on cvat_clickhouse fails with this error:
validating /root/cvat/docker-compose.override.yml: services.cvat_clickhouse Additional property limits is not allowed


Are you planning to licence this project?

Hi, I just started working on pngme and was wondering if you could license the project? I know lots of people have probably already started implementing their own version of pngme, but I was wondering how you would like to be accredited?

You don't have to credit me at all.

I added a note to the README

I'd suggest adding a proper license anyways since if you don't license your project you technically retain complete exclusive copyright.
Since you are fine with not being credited at all, I'd suggest something like Creative Commons Zero which allows people to do whatever they want with this to the maximum extend allowed by the law.

Added CC0! Thanks for the suggestion!


can add a example to the project docs that how to insert a text chunk into a png image?

I wanted to insert a text chunk into a png image, but i did't find the code example, so i wrote one. I hope the author of pypng can add this example to the project docs, so other people in need can be more conveniently obtained it. The example link is below(the part answered by cfh008):
https://stackoverflow.com/questions/9036152/insert-a-text-chunk-into-a-png-image/51058689?noredirect=1#comment93319814_51058689

when excuting that example , png.write_chunks( ) function encountered an error when using python 3
File "pyChunk_v1.py", line 59, in main
png.write_chunks(dst_file,chunk_list)
File "/usr/local/lib/python3.5/dist-packages/png.py", line 979, in write_chunks
write_chunk(out, *chunk)
File "/usr/local/lib/python3.5/dist-packages/png.py", line 966, in write_chunk
outfile.write(tag)
TypeError: a bytes-like object is required, not 'str'
someone can help me how to solve it .Thank you


Update SDK to preview 8

aspnet/AspNetCore-Internal#2979

Hmm this might not be straight forward and needs a fix @wtgodbe can you take a look in case you have time. Not too high of a priority compared to the other work items you have though.

@NTaylorMullen is there a known incompatibility between the Razor SDK and the preview 8 .NET Core SDK?

@NTaylorMullen is there a known incompatibility between the Razor SDK and the preview 8 .NET Core SDK?

Hmm, not that I know of. @pranavkm ?

/azp run AspNetCore-Tooling-ci

cc @aspnet/build


fix the join bug

What do these changes do?

Related issue number

Fixes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wangzhibin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

hi @wzbxpy, thanks for your first commit to this repo! Please add a brief intro in the summary (even a sentence) and link this PR to the related issue. :)

Added.


Update Apps to 8.1 Mobile app branch

Merge changes from dev and update Apps to 8.1 Mobile app branch

Merge conflicts messed up. Closing the PR


Refactor and improvement in the RouteNode tree router implementationFix/match route

Description
This PR resolves conflicts between dynamic parameters and static routes.
Key changes:

Refactor of params: The argument params = {} was changed to params: {}, using keyword arguments.
Handling of multiple dynamic routes: The dynamic_children is now a list, allowing multiple dynamic routes to coexist at the same level without overwriting each other.
Clear separation between static and dynamic routes: Static routes are stored in static_children, while dynamic ones are handled separately in dynamic_children.
Recursive matching: The match_route method was adjusted to perform recursive route matching, ensuring both static and dynamic routes are checked efficiently.

Motivation:

Resolution of conflicts between dynamic parameters and static routes: The separation of static and dynamic routes solves parameter overwriting issues, ensuring each route is handled correctly.

Performance and scalability: The new implementation optimizes how routes are stored and matched, allowing greater flexibility and improved performance in scenarios with a large number of routes.

Next steps:
Benchmark tests: Benchmark tests are still pending to assess the impact of the refactor on performance. I believe the results may not be as encouraging as the initial ones, but it’s important to run them to ensure the refactor does not negatively affect performance. 🙃

I ran the initial tests and noticed that the use of find slightly impacted the RPS performance.
dynamic_node = current_node.dynamic_children.find { |node| node.param_key == param_sym }

This was actually expected. To address this, I changed the structure of dynamic_children to use a hash instead of an array and replaced the linear search with find by directly accessing dynamic_children. Now that it’s a hash, this significantly improved the route matching performance
current_node.dynamic_children[param_sym] ||= RouteNode.new
dynamic_node = current_node.dynamic_children[param_sym]

The implementation still proves to be efficient and reliable for handling a high volume of requests. 🙂


Add this lib to ULID spec page with list of libraries

I would suggest a request to add a link to this library on the official ULID spec page which has a list of libraries.
https://github.com/ulid/spec

See ulid/spec#60


[New extension] Bing Search

Description
New extension to handle Bing Search.
Based on Google Search.
Screencast

Checklist

[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder

Thanks @pernielsentikaer
Now it's time to integrate Bing Chat :)


Unable to crawl page using scrapyd-deploy portia spider

Hello, I  created a portia spider and downloaded it as scrapy project. I run Windows 10 with docker and scrapyd is running it's service on port 6800 properly. However, when I schedule a spider to run, the following log is displayed: https://pastebin.com/raw/29EU34XM
Using the following commands for scheduling spider:
$ curl http://localhost:6800/schedule.json -d project=myproject -d spider=spidername
Any help would be appreciated. Thanks.

#786


Added support for local WSDL path.

I'm closing this PR as there was no activity for nearly a year now...


aix: fix setting of physical addresses

Changes based on code in src/unix/bsd-ifaddrs.c.
https://github.com/libuv/libuv/blob/f9618443920fd0cbd3ab11c9d37c1f24a7aa1067/src/unix/bsd-ifaddrs.c#L128-L143
Spotted the physical addresses were always 00:00:00:00:00:00 on AIX.
e.g. (v1.x) https://ci.nodejs.org/job/libuv-test-commit-aix/1668/nodes=aix72-xlc-ppc64/console
# uv_interface_addresses:
#   name: en0
#   internal: 0
#   physical address: 00:00:00:00:00:00
#   address: <IP_ADDRESS>
#   netmask: none
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: <IP_ADDRESS>
#   netmask: none
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: ::1
#   netmask: none

compared to (for this PR) https://ci.nodejs.org/job/libuv-test-commit-aix/1670/nodes=aix72-xlc-ppc64/console
# uv_interface_addresses:
#   name: en0
#   internal: 0
#   physical address: 5a:c6:c5:74:19:02
#   address: <IP_ADDRESS>
#   netmask: none
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: <IP_ADDRESS>
#   netmask: none
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: ::1
#   netmask: none

(Both running on test-osuosl-aix72-ppc64_be-2:
$ netstat -ni
Name  Mtu   Network     Address            Ipkts Ierrs    Opkts Oerrs  Coll
en0   1500  link#2      5a.c6.c<IP_ADDRESS>         38611838     0         10522321     0     0
en0   1500  140.211.9   <IP_ADDRESS>             38611838     0         10522321     0     0
lo0   16896 link#1                                1545544     0          1545544     0     0
lo0   16896 127         <IP_ADDRESS>                 1545544     0          1545544     0     0
lo0   16896 ::1%1                                 1545544     0          1545544     0     0
$ ifconfig -a
en0: flags=1e084863,814c0<UP,BROADCAST,NOTRAILERS,RUNNING,SIMPLEX,MULTICAST,GROUPRT,64BIT,CHECKSUM_OFFLOAD(ACTIVE),LARGESEND,CHAIN>
        inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
         tcp_sendspace 262144 tcp_recvspace 262144 rfc1323 1
lo0: flags=e08084b,c0<UP,BROADCAST,LOOPBACK,RUNNING,SIMPLEX,MULTICAST,GROUPRT,64BIT,LARGESEND,CHAIN>
        inet <IP_ADDRESS> netmask 0xff000000 broadcast <IP_ADDRESS>
        inet6 ::1%1/64
         tcp_sendspace 131072 tcp_recvspace 131072 rfc1323 1
$

)

cc @libuv/ibmi as aix-common.c is used there as well.

The changes look good to me. @dmabupt , please also review and test. Thanks!

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1629/

CI seems good (by our standards anyway).

I have tested the patch with Node.js on IBM i and it seems that all mac addresses became zero.
I would suggest wrap these changes with #ifndef __PASE__ for now.
current nodejs ->
  '<IP_ADDRESS>': [
    {
      address: '<IP_ADDRESS>',
      netmask: '<IP_ADDRESS>',
      family: 'IPv4',
      mac: '00:00:00:80:60:e3',
      internal: false,
      cidr: '<IP_ADDRESS>/24'
    }
  ]

applied the patch https://github.com/libuv/libuv/pull/2546.patch
  '<IP_ADDRESS>': [
    {
      address: '<IP_ADDRESS>',
      netmask: '<IP_ADDRESS>',
      family: 'IPv4',
      mac: '00:00:00:00:00:00',
      internal: false,
      cidr: '<IP_ADDRESS>/24'
    }
  ]

I have tested the patch with Node.js on IBM i and it seems that all mac addresses became zero.
I would suggest wrap these changes with #ifndef __PASE__ for now.
current nodejs ->
  '<IP_ADDRESS>': [
    {
      address: '<IP_ADDRESS>',
      netmask: '<IP_ADDRESS>',
      family: 'IPv4',
      mac: '00:00:00:80:60:e3',
      internal: false,
      cidr: '<IP_ADDRESS>/24'
    }
  ]

applied the patch https://github.com/libuv/libuv/pull/2546.patch
  '<IP_ADDRESS>': [
    {
      address: '<IP_ADDRESS>',
      netmask: '<IP_ADDRESS>',
      family: 'IPv4',
      mac: '00:00:00:00:00:00',
      internal: false,
      cidr: '<IP_ADDRESS>/24'
    }
  ]

@dmabupt is 00:00:00:80:60:e3 the correct MAC address? (i.e. is the current Node.js reporting accurate information?)

@richardlau No, This MAC address is not correct either. We may need to call some IBM i specific API to get the true MAC address.

@dmabupt Could you also check the alternative implementation in https://github.com/libuv/libuv/pull/2547 on IBM i?
If the current code produces incorrect MAC addresses then having them as zero (in this PR) is no less wrong, and arguably more obviously to the end user that it is wrong (or could be interpreted as undetermined).

@richardlau The result of #2547 is the same. Personally I believe that this PR is doing the right thing. The code would diverge in future to support IBM i.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1637/

@richardlau would you mind rebasing this?

Rebased.
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1649/

Landed in https://github.com/libuv/libuv/commit/0a4e0b9d305b53be732470a16cf226904e65faf4.


Add<EMAIL_ADDRESS>

CLI11 is a command line parser for C++11 and beyond that provides a rich feature set with a simple and intuitive interface.
This library already supports the Bazel build system along with bazelmod (see https://github.com/CLIUtils/CLI11/pull/1033).

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cli11) have been updated in this PR. Please review the changes.


Two-step storage node registration

Before a storage node is eligible to be elected into a storage committee it should self-report that it is fully synced. This should be done by flipping a flag in the registration descriptor (could be added into a new "storage" capability).

See also #2039

Ah yes, we can probably generalize this, closing in favor of #2039.


[jsoncons] Update to v0.147.0

Describe the pull request
Update jsoncons to v0.147.0

What does your PR fix? Fixes issue #

Version upgrade

Which triplets are supported/not supported? Have you updated the CI baseline?

All are supported. Yes.

Does your PR follow the maintainer guide?

Yes

Thanks @danielaparker :) This is awesome :D


[WIP] target_dir for execute mars

Prepare for CePH cache storage
FYI, the target kwarg from the original execute_mars is not used in any call of the method, therefore it is safe to separate this to target_fname and target_dir

Starting again with a clean PR


Certificate Renewal & Dependant Containers

Automatic certificate renewal
Every hour (3600 seconds) the certificates are checked and every certificate that will expire in the next 30 days (90 days / 3) are renewed.

The readme does not clearly explain what actually happens upon renewal. By investigating the source, it looks like nginx is restarted.
What about proxied containers that depend on these certificates? ie
$ docker run -d \
    --name example-app \
    -e "VIRTUAL_HOST=example.com,www.example.com,mail.example.com" \
    -e "LETSENCRYPT_HOST=example.com,www.example.com,mail.example.com" \
    -e<EMAIL_ADDRESS>\
    tutum/apache-php

Will example-app also be automatically restarted to work with the updated certificates?
Apologies if I missed something.

The nginx proxy is not restart but reload.
Only the nginx proxy have the certificates so no other containers need to be restart/reload.

So I don't need to run proxies containers as https and I don't need to give them the letsencrypt certs?

Exactly


Multiple scrolls

I have edited your script to allow for multiple scrolls on one page, but the 2nd and 3rd columns now loop the original content instead of loading newer items from the database. Can anyone help me?
My code:
$(document).ready(function() {

    var Engine = {
        utils : {
            threeColumnScroll : function(container, selector){
                var $container = $(container);
                  $container.isotope({
                    itemSelector : selector
                  });

                  $container.infinitescroll({
                    navSelector  : '.pagination',    // selector for the paged navigation
                    nextSelector : '.pagination li.pag-next a',  // selector for the NEXT link (to page 2)
                    itemSelector : selector,     // selector for all items you'll retrieve
                    behavior: 'local',
                    loading: {
                        finishedMsg: 'No more pages to load.',
                        img: 'http://i.imgur.com/qkKy8.gif'
                      }
                    },
                    // call Isotope as a callback
                    function( newElements ) {
                      $container.isotope( 'appended', $( newElements ) );
                    }
                  );
            }

        }

    };

    Engine.utils.threeColumnScroll('#container_left','.element_left');
    Engine.utils.threeColumnScroll('#container_middle','.element_middle');
    Engine.utils.threeColumnScroll('#container_right','.element_right');

});

Sorry to hear you're having trouble with Infinite Scroll.
Infinite Scroll v3 is out!. It's an all new re-write, so take a look at how to upgrade from v2.
I recommend upgrading to v3. Please open a new issue if you run into trouble with Infinite Scroll v3. 🌈🐻


Made crawlers establish the connection for each crawl

resolved #167

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #233   +/-   ##
======================================
  Coverage    2.13%   2.13%
======================================
  Files          39      39
  Lines         935     935
  Branches       96      96
======================================
  Hits           20      20
  Misses        914     914
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abe45a...189499d. Read the comment docs.


Short solution needed: "How to list databases in Redis" (redis)

Please help us write most modern and shortest code solution for this issue:
How to list databases in Redis (technology: redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

How to list all databases in Redis


Fixed percent_encode when handing it bytes.

percent_encode fails when handed a string that's already been encoded into bytes. Have it just URL-quote that instead.
This fixes an error I'm running into when using S3 via the "django storages" package. I have a few keys with non-ASCII characters. Django storages handles this by encoding them as UTF-8 and handing the bytes off to boto. On Python 2 this fails with a UnicodeDecodeError, and on Python 3 I don't think it will raise an exception, but will return a url-encoded repr of the string passed in (which is probably not what you would want).

Will re-open when tests pass.


Can't Install MDX-DECK

Whenever  I run npm i -D mdx-deck, I'm getting an Error Like this,
npm i -D mdx-deck
npm ERR! Unexpected end of JSON input while parsing near '...,"webpack-configurato'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/athul/.npm/_logs/2019-07-21T03_57_59_235Z-debug.log

I had been using MDX-DECK for a while but upgraded it from Version 1.6 to 3.0.6 yesterday, It didn't work then so I was trying to reinstall the smae then caught up with this error

try to use yarn

Thanks @sibelius it worked using yarn. @jxnblk love the new updates ❤


After connection and join client.action() throws "not connected" error.

Actual behaviour:
After connecting to Connecting to irc-ws.chat.twitch.tv on port 80 and joining my channel i call
client.action('instak', 'this is my message').then(data =>{
    console.log(data);
}).catch(err => {
    console.log(err);
});

It throws a "not connected" error even though my console just told me I connected succesfully.
Expected behaviour:
Not to tell me I'm not connected when in fact I am.
Error log:
[10:33am] info: Connecting to irc-ws.chat.twitch.tv on port 80..
[10:33am] info: Sending authentication to server..
[10:33am] info: Connected to server.
[10:33am] info: Joined #instak
.js:84 Not connected to server. (throw of .action)

Server configuration

Operating system: OSX Yosemite 10.10.5
Node version (if applicable): 6.2.0
NPM version (if applicable): 3.8.9
tmi.js version: 1.1.1

Do you have your function inside a chat event (IE on connected or on chat)?
client.on("connected", function(address, port)	{ 	Twitch.client.action('instak', 'this is my message').then(data =>{ 	    console.log(data); 	}).catch(err => { 	    console.log(err); 	}); });
Works just fine for me. And by responding to events received by the client you know that it has successfully connected.

I do, I have it in a join event because I want to check my CSS without constantly having to type a message in my own chat. I want a message in my channel as soon as I connect, that's why I put it in a join event, so this is what i totally looks like:
client.on('join', () => {
    client.action('instak', 'this is my message').then(data =>{
        console.log(data);
    }).catch(err => {
        console.log(err);
    });
});

The join event fires whenever anyone JOINs the channel. Your code should look more like this:
const tmi = require('tmi.js');

let client = new tmi.client({
			connection: {
					reconnect: true,
					secure: true
				},
			channels: [ 'instak' ],
			identity: {
					username: '',
					password: ''
				},
			options: {
					debug: true
				}
		});

client.on('join', (channel, username, isSelf) => {
		if(isSelf) {
			client.action(channel, 'this is my message');
		}
	});

client.connect();

So @AlcaDesign with that code I should put in my account credentials? If yes, (I greyed out my other code just to test this) I still get an error:
Uncaught (in promise) Invalid NICK.

(my credentials are correct ^^)

It's not the password that you use to log in with, it's an OAuth token you get with the scope "chat_login" which you can get one quickly by using this tool: http://twitchapps.com/tmi/
{
    /* ... */
    identity: {
            username: 'alca',
            password: 'oauth:abc123def456ghi789jkl...'
        }
    /* ... */
}

Oh, sorry. That does seem to work :)  ... I don't really know what the difference is between my old code and the new? I also think it's weird I should add the parameter isSelf because you just said it gets triggered when ANYONE (so including me?) joins the channel?

"isSelf" is just a simplification of
client.on('join', (channel, username) => {
    if(channel.slice(1) !== username) {
        return false;
    }
});

because the "join" event when the client joins is triggered by the ROOMSTATE command from Twitch.

I'm actually getting the same error like above, with an other sort action, but I honestly can't figure out what's needed to fix it...
componentDidMount(){
	let options = {
		options: {
			debug: true
		},
		identity, //identity gets imported from another file so i can include that in my .gitignore
		connection: {
			reconnect: true
		},
		channels: ['instak']
	};

	const client = new tmi.client(options);

	client.on(`chat`, (channel, userstate, message, self) => {
		if (message === `!kluiten`) {
			console.log(userstate.username);
			fetch(`/api/users/${userstate.username}`) // fetch from Express.js server
			.then(response => response.json())
			.then(result => {
				console.log(result);
				// result logs: {
				// 	createdAt: "2016-10-02T16:27:44.000Z",
				// 	id: 19,
				// 	instakluiten: 18625,
				// 	role: "moderators",
				// 	updatedAt: "2016-10-09T13:06:28.000Z",
				// 	username: "instak"
				// }
				client.action(channel, `You've got ${result.instakluiten} instakluiten.`);
				//client.action logs:
				//client.js:1071 Uncaught (in promise) Not connected to server.
			});
		}
	});

	// Connect the client to the server..
	client.connect();

}

Anything you can spot I'm doing wrong here?

If the client is assigned a Justinfan username for some reason, it will reject: https://github.com/tmijs/tmi.js/blob/c7c896dbc8ac728c74e42cb0757060265973a1f1/lib/client.js#L1024 That's all I can think of.

I can't see a reason why that would be happening?...

Try this before calling action:
console.log(client.ws !== null, client.ws.readyState === 1, client.getUsername());

that returns
true true "justinfan35951"

You should check that the identity is actually loaded before making and connecting the client.

So this means I'm not connected as 'instakbot'? And since it doesn't know my identity, it just takes a random number after "justinfan"?

If identity is undefined, it will generate a justinfan username.

Fair enough, then I probably should fix my bad import first (because identity is indeed undefined...) which will hopefully fix my issue!


Default 'change assignee/category' buttons for tasks in board view

Would be nice to have some default buttons for tasks without assigned assignee/category, so task could be updated directly from board view, without editing.

Click on the number of the task:

I've totally missed this, thanks!


Implement Pandora extended advertising

Support extended advertising and scanning  Pandora APIs on 1M and coded phys.
Tested with new Avatar tests:
https://github.com/BenjaminLawson/avatar/tree/extended-advertising
Note that some tests fail, pending https://github.com/google/rootcanal/issues/24 and updating rootcanal to include the fix for https://github.com/google/rootcanal/issues/23 .

Okay, I fixed the linter issues.


fix(label): correct label selector parameter handling and test case

Checklist

[x] npm test passes

[x] commit message follows commit guidelines

Description of change

Ensure label selector correctly filters data at specified index
Maintain consistent test behavior with original requirement

fixed #6020

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.653%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
10610

Relevant Lines:
11865

💛  - Coveralls

tests/data/indices.json 这个文件是必须加的吗？看看当前仓库中是否有这个数据。


Allow custom event handler annotations for complex implementations

Allow developers who use this library to create their own event handler annotations, as for example @NurioEventHandler.
This will be very useful for using reflected event handlers with multiple event managers at once. For example one for handling Potatoes related stuff and another one for Apples related stuff.

Also, doing this will make the annotation handling much better. 🚀

It's done! 🥇


Fix detection of forced/default subtitles.

This might have been a change in FFMPEG from 1-2 years ago, but now DISPOSITION is in all caps.

I added dvb_subtitle to the bad codec list as it is a picture-based subtitle.


Reversed map ordering of flashcards to reflect numbering

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Do not change the following line aside from replacing YOUR-ISSUE-HERE with the issue this PR fixes
fixes #577
Please provide enough information so that others can review your pull request:

Changed data={cardData[cardData.length - i - 1]} to data={cardData[i]} in FlashCards component
Explain the details for making this change. What existing problem does the pull request solve?
Flashcards would show up in reverse order starting with fact 15 and going to fact 1
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
https://gyazo.com/4fadc4cacc10b4a44b388749af670552

Final Checklist

[x] Have you bumped the version in package.json?

Second decimal for major change, third decimal for minor change. This can go past 10 i.e. 1.0.9 !=> 1.1.0, 1.0.9 => 1.0.10
Read here for more info

[ ] Have you added any new tests necessary?
[x] Is your PR rebased off the most current master?
[x] Have you squashed all commits, or if you will merge will you squash all commits?
[x] Did you use yarn, not npm?
[x] Did you use Material-UI wherever possible?
[x] Did you format according to Prettier?
[x] Did you run all of your most recent changes locally to make sure everything is working?

Can you add a photo/gif of the code working in the UI, not the code itself :)

Oops, sorry I thought the gyazo gif would show up automatically

I know you mentioned this, but would you be able update the flashcard numbers in fakeCardData.js? I'm not sure why this happened, but we should change this for now. Also, rebase off current master / bump package.json since new PRs have merged in since opening this 👍

Will do!

 The new commit shows up on my repo but here it still says only 2 files changed when it should be 3, does this mean its messed up?


Update device-information-properties.md

added related DevicePanel properties

@eliotcowley  : The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!

@smadasam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @smadasam, I've merged your changes and they should be live soon.


Add an API endpoint to generate a CSV compliance report

Generating a report as described in the design.
Ref: https://issues.redhat.com/browse/ACM-6884

@JustinKuli @mprahl  Ready again Thanks!!!

@mprahl  @JustinKuli  Ready Again! Thanks all


This changeset fixes syntax highlighting via text properties, if the text contains multi byte characters.

The prop_add api of vim expects the column to be the byte offset and
not the character count. So if a comment for example would contain
a multi byte character, for example a german umlaut, then the last
character of the comment would not be included in the text property.

Nice one, thanks!


Please update documentation

Regarding Admin - added app and model icons support there is no (obvious) location where we can read about which icons can be used.

Documentation updated with the 0.9 release.
The admin options documented at  http://docs.viewflow.io/admin_customization.html

The docs show nothing about a simple way to change the admin theme colours yet most the images show it with different colours is is it just a case of overriding the admin styles.

Themes are documented here in case you didn't find the docs. http://docs.viewflow.io/forms_themes.html

@pysysops Nice thank you :)


setBackgroundColor

Is there any reason for restricting us to your SuperToast.Background enum? It would be good to be able set my own color.
So having a new method that simply set the backgroundColor like that:
mRootLayout.setBackgroundColor(Color.parseColor("#F4F4F4"))
PS: great job

thomasMary,
Thanks for the input. I can't honestly remember my logic behind it so I'll assume it was made in error. Version 2.0 allows background to be any RGB value in addition to its presets.
Thanks,

John


Fix licenses in ranger gaian plugin

As per email
There are 8 files within the /open-metadata-implementation/adapters/governance-engines-plugins/gaian-ranger-plugin/ directory, which have a different style of Apache-2.0 license header. This version of the license header is used by projects that are actually hosted by the Apache Software Foundation; it makes reference to the files being contributed to ASF via a CLA agreement. (Example: https://github.com/odpi/egeria/blob/master/open-metadata-implementation/adapters/governance-engines-plugins/gaian-ranger-plugin/src/main/resources/conf/ranger-gaian-security.xml)
Do you know whether these files did in fact originate from an ASF-hosted project? If so, then it likely makes sense to keep the existing header.
But if these files are instead original to Egeria, and were not from an ASF project, then this is likely the wrong license notice to use -- and should likely be replaced with just an SPDX identifier and/or the "standard" Apache-2.0 header text.

Licenses corrected
removed 2 unused files (for geo)

run-clm


As a team member I would like to open terminal with kubectl access

User story
As a team member I would like to open terminal with kubectl access, so I can monitor state of k8s resource and perform some basic maintenance actions
Use cases

A user can open ttyd in we browser and use kubectl with a service account associated with this particular user

Definition Of Ready

[ ] The story use cases are clear and described in Gherkin
[ ] Requirements and use cases have been reviewed (in our daily session -- the developers rotate -- everyone is responsible!)
[ ] The story is self-contained and has no dependencies on other stories
[ ] The story has been estimated in complexity points
[ ] Atomic SMART tasks have been created that reflect the functional requirements
[ ] Atomic SMART tasks reflect any dependencies on other tasks in this story (affecting order of delivery)
[ ] The story is reviewed and approved by @srodenhuis or @morriz

Tasks
core:

[ ] define ingress for ttyd services  (core.yaml)

api:

[ ] implement endpoint to create ttyd Pod
[ ] call k8s api to create  ttyd Pod in a team namespace
[ ] call k8s api to create service account for a user in a team namespace
[ ] call k8s api to create role to access  in a team namespace
[ ] call k8s api to create role binding  in a team namespace
[ ] do not allow users to read service account tokens

console:

[ ] add button to create/join ttyd console

Definition Of Done

[ ] Tasks are done.
[ ] Unit Tests are added with the code (if relevant and practical)
[ ] Functional Tests are written down (if relevant and practical)
[ ] Functional Tests are performed by another developer/ tester(if relevant and practical)
[ ] (Architecture) Design Record(s) have been added as adr/*.md and appended to list in adr/_index.md.
[ ] Schema and demo files have been updated to reflect code changes (if relevant).
[ ] Documentation has been updated (if relevant).
[ ] Functionality, code, and/or documentation have been peer reviewed.

Currently working on cloudshell branch of otomi-core. The branch contains the core.yaml file changes where we added entry for the tty. endpoint and also a folder containing the starting point manifests for tty. The folder contains a small readme on how to deploy it.
In order to make the setup work I need to:
1 - add a new entry in the hosts section for the team-dev (testing team) gateway resource to math the url in the Virtual service (ex. tty.<IP_ADDRESS>.nip.io)
2 - I have to delete the automatically created VirtualService in the team-admin since it conflicts with the new VS created in the team-dev

After talk with Jeho we concluded that the igress resource is not needed since it otomi creates one (after adding it to the core.yaml) and also to hardcode the value of the gateway in the virtualservice resource. Also updated the naming of the resources.
Issue: the tty endpoint created by otomi contains this hosts configuration:

The string before the slash indicates the allowed namespaces from which a VirtualService can use the gateway. Check https://istio.io/latest/docs/reference/config/networking/gateway/
This means we either modify the gateway hosts field or why not deploy the tty pod in the admin namespace ?? 🤨 @j-zimnowoda
The user does not need to see the pod and/or modify it.
ToDo:

Integrate the role and config map at the team-ns chart
Improve the image creation

Reworked again the tty manifests file:

now we will use a pod instead of a deployment for tty
added the team as part of the pod name in case a user tries to create tty sessions for different teams(otherwise it would conflict because of the name)

Important: at the moment we are extending the otomi-api serviceaccount roles in order for it to be able to create the related resources. This is something we should discuss if it is acceptable or not

Extending the otomi-api roles was not enough since as part of the tty creation we need to deploy also a rolebinding resource. The rolebinding is expected to bind the tty pod service account with a role that has access to all resources and verbs of the namespace its going to interact with( so * resources and * verbs).
To prevent privilege escalation the K8s RBAC model works as follows:
To allow a user to create/update roles:

Grant them a role that allows them to create/update Role or ClusterRole objects, as desired.
Grant them permission to include specific permissions in the roles they create/update:
implicitly, by giving them those permissions (if they attempt to create or modify a Role or ClusterRole with permissions they themselves have not been granted, the API request will be forbidden)
or explicitly allow specifying any permission in a Role or ClusterRole by giving them permission to perform the escalate verb on roles or clusterroles resources in the rbac.authorization.k8s.io API group

Created the following pipeline for building, pushing and versioning the cloudtty image.
Need access to set the correct dockerhub token in the github actions secrets @j-zimnowoda

Created final pipeline and pushed the initial tty image to otomi's dockerhub repository: https://hub.docker.com/r/otomi/tty
After its merged to main:

if we need to bump the MAJOR version we need to pass the  "[TTY][MAJOR]" string in the commit message
if we need to bump the MINOR version we need to pass the  "[TTY][MINOR]" string in the commit message
if none of this conditions are met will check if the "tools/Dockerfile-tty" file was changed. If yes will bump the patch version

We will create two enhancements:

user authn with istio
proper handling JWT groups that are not reflected in k8s cluster


Crashes IntelliJ Idea

when trying to connect to localhost through the emBrowser the IDE crashes

hi
i agree withe @Chris9540 it effectively crashed ...  it looks to not be stable with phpstorm starting from 2018 3.1