Custom Delimiter for rules to prevent issues with metrics including colon

Added the -ruledelimiter option to the args to allow for custom delims on rules.
Specific example where this is needed is NFS mounts have : in the path which will break the rules parser if you want to monitor an NFS mount on a device.
Example broken rule:
filesystem.nfs.local.server:/nfs/path.used_percent < 1 : NFS not mounted
Now with custom delimiter you could run: wirestat -ruledelimiter '|'
and use rule:
filesystem.nfs.local.server:/nfs/path.used_percent < 1 | NFS not mounted
And have a successful startup.

Thanks for offering this @cbattlegear but I'm not keen on adding additional options since I want to keep the scope as limited as possible as per the low maintenance statement in the readme.
I would however be willing to accept backslash escaping of colons within the metric part of a rule as an alternative way to achieve this without adding an option.

Totally! Wasn't sure if it would fit in expanding the scope or not, I'll work on getting backslash escaping working this evening!

@ssddanbrown I switched to an escape character concept using replaceall and a magic string, was going to regex it but realized you can't do lookbehinds in golang...
Either way, would you like it as a separate PR or added to this one?

Thank you very much for this @cbattlegear.
All worked well from my testing (Once I found an NFS share to mount for testing) so all now merged.
Some minor changes in d1cd457f5cc7d53233276dd21742eb62293843c2 but are really just syntax/wording, upon updating the test changes to also check escapes in rule names.


CUI-7416 Coral-Spectrum Tooltip is not included in accessibility name when referenced using aria-labelledby

Description
In Chrome, foundation-autocomplete in AEM is not including the error tooltip text as part of the accessibility name even though the appropriate IDREF is included in the aria-labelledby attribute for the combobox input.
Possible solution is to set visibility: initial on the coral-tooltip animation to close has completed. Chrome seems to ignore the element with display: none, visibility: hidden, and aria-hidden="true", when calculating the accessibility name.
Related Issue
CUI-7416
Motivation and Context
For accessibility, when a form element is invalid, we need to communicate the reason it is invalid to assistive technology.
How Has This Been Tested?
Updated Tooltip example documentation to set aria-describedby on target element for tooltip. Accessibility description updates when the target tooltip changes.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

@mohiaror, @icaraps, @indra2gurjar

Looks good to me.

@icaraps , @indra2gurjar  can you please review and merge this PR? It is for a long pending sev2 accessibility issue which is being flagged.

How does this visibility change affect the overlays like Popover or Dialog ?

How does this visibility change affect the overlays like Popover or Dialog ?

@icaraps I see no noticeable change in the behavior. On hide, we remove visibility: hidden from the overlay by setting visibility: initial, but only after display: none has already been set. On show, we restore the CSS-specified visibility and display before setting .is-open to transition visibility, opacity and position.


Release v 0 12 5

What is the problem / what does the code in this PR do
New release v0.12.5

Okay, also changed the corresponding tag. I will add this step to our "How-to".

Okay, also changed the corresponding tag. I will add this step to our "How-to".
Thanks, this is not always required though, only if we induce incompatibility on the strax side.


Add option to open existing palette in palette generator

Add option in 3 dot menu that opens a copy of palette in PaletteListScreen

This is added in the palette menu in home screen. We need to also add this in the edit palettes screen


Cannot Export Token on Http Response

I have a global script that is defined at the top of my .http file for testing. The purpose of this script is to hit an endpoint to grab a bearer token to pass to as an HTTP header for testing. My code is as follows:
{{
// Script to grab our Bearer Token for testing.

const https = require('https');

var postData = new URLSearchParams({
    username: 'xxx',
    password: 'xxxx',
    grant_type: 'password',
    scope: 'xxx',
    client_id: 'xxx',
    client_secret: 'xxx'
});

var options = {
    hostname: 'xxx',
    port: 443,
    path: 'xxx',
    method: 'POST',
    headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
        'Content-Length': postData.length
    }
};

var req = https.request(options, (res) => {
    let result = '';

    // Append our data to the result
    res.on('data', (dataChunk) => {
        result += dataChunk;
    });

    // Return compiled data
    res.on('end', () => {
        exports.authToken = JSON.parse(result).access_token;
    });
});

req.on('error', (e) => {
    console.error(e);
});

req.write(postData);
req.end();
}}
###

GET https://xxxx
Content-Type: application/json
Accept: application/json
Authorization: {{authToken}}

The first error I get is that UrlSearchParams is not defined, even though it is a standard package with Node. If I put this script into a Javascript file and run it via node someJsFile.js it executes without issue. Putting that aside, if I use the querystring package which is the legacy equivalent version I get an error saying that authToken is not defined. I have tried to move the script to the scope of only the one test as well and still get the same error.
I am using<EMAIL_ADDRESS>Any insight into this?
Thanks!

The first error I get is that UrlSearchParams is not defined,

To make the variables easy to access. the context of the script is switched (custom context instead of NodeJS default). I still try to add the most important methods or classes like Buffer to the global context, however, there may be deviations. To use UrlSearchParams I need an import of the Url package and therefore did not import it automatically. You can work around this behavior by importing your script using require, but then you don't have access to the variables and have to pass them to a function (example).

Putting that aside, if I use the querystring package which is the legacy equivalent version I get an error saying that authToken is not defined.

The cause is that my script cannot recognize that the code is async. The result is exported only after receiving the request, but by then the next http request has already been executed. The solution would be that you have to export a Promise, which is resolved on end(example).
exports.wait = new Promise(resolve => {
...
res.on('end', () => {
        resolve(JSON.parse(result).access_token);
    });
...

]}

Is there a reason to use the https package?
I would solve your use case using @ref and @name.
# @name login
POST /login
Content-Type: application/x-www-form-urlencoded

username=john&password=123456&grant_type=password&scope=xxx&client_id=foo&client_secret=bar

GET /app
Authorization: Bearer {{login.access_token}}

and I notice that it is basically an OAuth2 Password Flow. I would use it like this, because then my extension manages the session and automatically makes a new session. If refresh_token is available it keeps the session open.
@oauth2_clientId=...
@oauth2_clientSecret=...
@oauth2_tokenEndpoint=...
@oauth2__username=...
@oauth2_password=...
@oauth2_scope=...

GET /app
Authorization: oauth2 password

@AnWeber Thanks for all the information, untimely I ended up utilizing your solution of using @oauth2 that worked for me. I;ll close the issue now.

Thx:-)


Comment the testing suite, especially TestLoadDatasets

Could use some more detailed comments. @mikkokotila if you let me know what TestLoadDatasets actually does let me know and I can comment the rest. I did write the code for it but only because it was included in the original testing suite. I still am not sure what it does. 😄
Also, are you done refactoring Reporting? I probably should wait until you are before I dig into it right?

The idea for providing the datasets "ready to go" together with the corresponding params (and eventually corresponding models for each) is meant for two things:

for more robust testing (not feasible with travis) where we validate the results for major releases in a completely standard way

to give various examples (eventually covering as many typical prediction tasks as possible) so that its easy for the user to get going with Talos

Regarding the datasets, there is also of course the case where its useful to have access to datasets that require no further prep before ingesting it into a model. Some common ones (like Iris) and some uncommon ones like (like icu_mortality).
I'll try to get the Reporting pushed on Monday.

Ah ok, so the point is just to ensure the datasets load in properly? I'm just curious why they need to be tested.

I guess that the only concern is where those codes would be changed for some reason, or the file where those codes reside is changed and there is an accident related with that. Or maybe pandas would update and something fundamental would change and things would not work anymore as intended in getting the right data out.

Ah ok I understand. Thank you!


Link autocomplete README to country-picker README

Fixes #224.
This PR updates the autocomplete README with:

a definition of the component
advice to users about when not to use it
a link to the country-picker README

So as not to have multiple PRs floating around, I'm also going to use this PR for the updated message about support.

I'm not sure it's clear what we mean by 'standardise user input'. I guess the way the autocomplete does this is to provide suggestions which hopefully users would pick if they matched, but ultimately allow the user to type whatever they want, which is what makes it different from the use case in the first sentence?

@36degrees It depends how it's configured - In some configurations that's right, but in others users are meant to pick from the options only.

Holding off on merging till the sibling PR for country autocomplete gets an approval.


firefox-bin: 73.0.1 -> 74.0

Motivation for this change
Update done using nixpkgs attributes:
firefox-bin-unwrapped.updateScript
firefox-beta-bin-unwrapped.updateScript
firefox-devedition-bin-unwrapped.updateScript
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build firefox firefox-bin
@GrahamcOfBorg test firefox

The compiled one needs:

revert d4446c563d5 (patch included in 74.0)
nss update: #82247

(maybe something else as well?)

@andir will take care of firefox, this PR will be firefox-bin only

@GrahamcOfBorg build firefox-bin firefox-devedition-bin firefox-beta-bin

Yes, it's probably better to split them in this case.

works-for-me©
All three versions of firefox-bin can be executed and are usable on my system.

Small nitpick: Usually we update each of them in a separated commit. Can you fix that? They all work for me locally (as well).

I picked the default variant as 8899c729902.  This was conflicting due to 1cbef111 and af48019a updating the non-default variants to b2 (this PR has b1).


chore(deps): update dependency ember-resolver to v12

This PR contains the following updates:

Package
Type
Update
Change

ember-resolver
devDependencies
major
11.0.1 -> 12.0.1

Release Notes

ember-cli/ember-resolver (ember-resolver)
v12.0.1
Compare Source
:bug: Bug Fix

#976 Fix peer range for ember-source (@NullVoxPopuli)

Committers: 1

@NullVoxPopuli

v12.0.0
Compare Source
:boom: Breaking Change

#973 Do not use global ember -- drop support for ember-source < 4.12 (@NullVoxPopuli)

:house: Internal

#974 Update test format to modern qunit (@NullVoxPopuli)

Committers: 1

@NullVoxPopuli

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


initial commit for mtsre-1645 and mtsre-1675

What type of PR is this?
cleanup
What this PR does / why we need it?
Re-enables TLS for metrics and webhook components when developing locally.
Which Jira/Github issue(s) this PR fixes?
https://issues.redhat.com/browse/MTSRE-1675
https://issues.redhat.com/browse/MTSRE-1645
Fixes #
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Ran make test-unit command locally to run all the unit tests and mock tests locally.
[ ] Included documentation changes with PR
[ ] Squashed your commits

/retest

/retest

/retest

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8b37924) 73.06% compared to head (6854798) 73.06%.
Report is 25 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   73.06%   73.06%
=======================================
  Files          51       51
  Lines        3289     3289
=======================================
  Hits         2403     2403
  Misses        743      743
  Partials      143      143

/retest

The only things that failed were PKO tests related to things tearing down which wasn't anything I'd touched. I can re-run them and put the output's in the JIRA though just to make sure they look fine.
I ran test-integration, test-integration-local, go-test, and test-integration-short IIRC. Not sure which one is the most comprehensive?

Reviewed the Jira comments, works for me, thanks.

/retitle Dev: Re-enable TLS for metrics and webhook components
/override ci/prow/precommit-check


Upgrade to commons-compress 1.18

The latest version commons-compress has new compression formats like Zstandard.
Are pull requests allowed to make jarchivelib work with 1.18 and the new formats?
Or is there some kind of timeline or milestones planned ahead for this?

somewhat relates to #22, and that jarchivelib still maintains compatibility with java 6 (new commons compress version require java 7). but i think it's really time to drop it. i always had in mind to release a major version before upgrading to java 7. so feel free to integrate the new formats and make pull requests. i might redirect them to a new branch or something.


api file not found

after recloning Hygieia on another machine I realized that there is no api file and the machine that had all of the original files connects to the Hygieia UI but lacks API connectivity. is there updated documentation on how to proceed with setup and configurations of the api through alternate means/ or was the file just not uploaded?

@aalabi3 API is still needed and this project has been migrated to its own repository, Going forward all components within Hygieia project will be under their own repositories. Here is the link to the new repository - https://github.com/Hygieia/api


exec: "FR": executable not found in %PATH%

Hi !
Thanks for your library, it's really a good job :)
I faced an issue when doing a go get -v github.com/veandco/go-sdl2/sdl :
# github.com/veandco/go-sdl2/sdl
exec: "FR": executable not found in %PATH%

My configuration is :

Windows10 64bit
MinGW-w64/x86_<IP_ADDRESS>-posix-seh-rt_v5-rev1
go1.9.4 windows/amd64
SDL-2.0.7

The MinGW bin directories are added to my PATH.
When I run a go build -v -work -x -n, I can see that the library use cgo, which in turn call the C compilation command, by using FR instead of gcc.
FR -I "C:\\Users\\me\\Documents\\Projects\\src\\github.com\\veandco\\go-sdl2\\sdl" -m64 -mthreads ...

As a workaround, I create a copy of my gcc.exe file in theMinGW\bin directory, and rename it FR.exe (ugly, but do the job).
I'm still analysing why the cgo executable will change the executable's name, but if you have an info about this, I'm interested :)

Hmm strange. Does it also do that when compiling a simple cgo program? Perhaps you can try go run on this snippet and see if it does the same thing.
package main

/*
static int twice(int x)
{
        return x * 2;
}
*/
import "C"

func main() {
        x := C.twice(2)
        println(x)
}

@s-nieuwlandt-dev
Can you please run this commands in your windows console?
echo %CC%
echo %GCC%

This is how compiler used by cgo is set. It basically takes one from CC or GCC if they are set or defaults to "gcc".
// gccBaseCmd returns the start of the compiler command line.
// It uses $CC if set, or else $GCC, or else the compiler recorded
// during the initial build as defaultCC.
// defaultCC is defined in zdefaultcc.go, written by cmd/dist.
func (p *Package) gccBaseCmd() []string {
	// Use $CC if set, since that's what the build uses.
	if ret := strings.Fields(os.Getenv("CC")); len(ret) > 0 {
		return ret
	}
	// Try $GCC if set, since that's what we used to use.
	if ret := strings.Fields(os.Getenv("GCC")); len(ret) > 0 {
		return ret
	}
	return strings.Fields(defaultCC(goos, goarch))
}

func defaultCC(goos, goarch string) string {
	switch goos+`/`+goarch {
	}
	return "gcc"
}

So you either have environment variable set for CC or GCC, or something else (console) replaces "gcc" to "FR" with alias after that.

Hi !
Thanks for your answers :)
I can reproduce the error on the snippet, and effectively, my %CC% var is set to FR (which is strange because I tried the same install on a different windows10_64bits computer, and was unable to reproduce this behavior).
So clearly this is not a go-sdl2 issue :)
Thanks for the informations and your time !


I am so sorry about this.


NSynth multigpu generate

Allow for running multiple instances of nsynth_generate at once, to generate with multiple gpus.

LGTM, but is there a matching CL?

Nope, I'll do that.


viewbuilders not ordering properly

hie :)
what i am trying to achieve :  i create sales invoice and related to sales invoice i create accounting entries and if there is problem in creating accounting entries then i want to cancel sales invoice created earlier.
on salesInvoiceCreated event

salesInvoiceCreated viewbuilder executes and creates readmodel
salesInvoiceCreatedSaga.js listens and creates command createAccounting.
i forcefully generated error in businessrule of createAccounting so that it will throw rejectedCommand event
on rejectedCommand event it will fire cancelSalesInvoice

my sample with context and saga implemented

problem:
some times every thing works fine it creates sales invoice then and on problem in creating accounting entries it cancels sales invoice created earlier and keeps giving AlreadyDenormalizedError error
but but but
some times cancel sales invoice fires first and then create sales invoice and keeps giving AlreadyDenormalizedError error
solutions that i tried :
also i tried to set priority in viewbuilder

priority in viewbuilder only guaranties order for same event on multiple viewBuilders
what you need is having just 1 aggregate that generates these events, or try to use the "retry" function in the viewbuilder

your module works properly
actually problem was : if PostgreSQL make update faster, update will return result before insert


Fails to Build on Apple Silicon

When I try to build this on an Apple Silicon Mac it fails to build with the following error:
swiftc watchid-pam-extension.swift -o pam_watchid.so -target x86_64-apple-macosx10.15 -emit-library
<unknown>:0: error: unable to load standard library for target 'x86_64-apple-macosx10.15'
make: *** [all] Error 1

The TARGET needs to be platform-sensitive and use the right value for the given OS and architecture, I think.

Someone in issue #7 got it to run on Apple Silicon by changing the build architecture in the make file.


Simplify random selection of context words for word2vec example

Use random.sample to simplify random selection of context words

Can one of the admins verify this patch?

I signed it!

Jenkins, test this please.

@frankchn recreated PR #13531


add skip changelog to ignore

because that's what @hannahilea and I thought it was 😄

bump @christopher-dG :)


Images In Markdown

Current behavior
Images do not display in markdown preview
How to reproduce it (as minimally and precisely as possible)

Go to text-> Markdown Preview
Paste or type in markdown for an image "![image](https://github.com/heribertolugo/DevToys/assets/26213368/c20122b5-2609-482a-9337-c9123f7b090f)"

Expected behavior
image should be displayed
Screenshots

Workaround
No response
Affected platforms
Windows
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | 2706c6c2 | 2706c6c2
Relevant Assets/Logs
No response

This will be fixed in DevToys 2.0 thank to its design.

Coming soon in DevToys 2.0 😁


Add EngineProgram to QuantumEngineSampler

Note that I chose not to validate that the EngineProgram was created from the same Engine as the sampler.  We could add this.
Alternatively we could add another type of Sampler.

Fixes #1982


importError

Hello, i have a problem to run the sc2-benchmark. There is no 'model_urls' in 'torchvision.models.segmentation.deeplabv3', but i exactly install torchvision0.11.1.

Thank you @ZqCATCAT for reporting that.
I forgot to update the minimum requirements in setup.py for the change (model_url was introduced to deeplab.py from v0.12.0)
Please update torch and torchvision with 1.11.0>= and 0.12.0>= respectively. I will edit setup.py soon for next version release


Reverse a  Linked List(GFG SDE Sheet Problem) in C++.

@Mridul-1-Sharma Kindly assign me this issue under Hacktoberfest 2022.

I want to work on this so please assign this to me

I want to work on this so please assign this to me

Please contribute by creating a PR


Predicate

Umbrella issue for tracking moving Predicate to FoundationPreview

Addressed in https://github.com/apple/swift-foundation/pull/3


Create file for GSoC 2022

thanks, @xukai92 @cpfiffer!

I directly pushed Martin's fixes into master.


Spec the failure behaviors & knobs

We need to provide some knobs, if only at the limitador level, to help users specify the behavior in the face of a "too slow request" or being partitioned from the backend datastore.

Right now, all we have added is the ability to set the timeout after which Limitador will consider itself network partitioned from the underlying Redis


use main field if pointing to css

While playing around with choo & sheetify - I noticed I was unable to import my tooltip lib of choice (wenk).
The package specifies a "main" field, but no "style" field.
As per the sheetify#use-npm readme:

To consume a package from npm that has .css file in its main or style field:

However in its current form, style-resolve is overwriting the "main" field with the implicit "index.css" entry and leaving the non-existent "style" field untouched.

I suppose this could trip up if there are packages out there with both fields set:
{
  "name": "my-awesome-css-lib",
  "main": "src/awesome-css-lib.css",
  "style": "dist/awesome-css-lib.min.css"
}

I'm no CSS guy so I couldn't tell you if the above is a common (anti-?)pattern or not.

@yoshuawuyts wdyt?


regression: first commit message

for some reason the first commit message is not coming from angular-cli, but from ember-cli

Yes very strange. Just spent few minutes but did not find the solution for the moment


How would I add multiple checks?

I checked your sample and it works fantastically. I display different months on the header, but I would like to have another check to see if the day is today. That is I would like to have a header for the first item which will have the day = today display a header just for that, and from the next item the usual grouping according to the month...

Hi @Superblazer.
As I understood your issue correctly, you need to in your implementation of the method onBindSubheaderViewHolder(SubheaderViewHolder holder, int nextItemPosition) check nextItemPosition whether item at this position is today or not. If today - you display header for today, for months - otherwise.


Bun crashes (Segmentation Fault) when running benchmarks against certain template engines

I want to create a set of performance comparisons of template engines running on Node or Bun, and decided to use Mitata as the benchmark framework because that's what the Bun project uses.
I have found several template engines -- EJS, Nunjucks, MarkdownIT so far -- that cause Bun to segfault when running the benchmark using Mitata.  Full details are in the Bun issue queue:  https://github.com/oven-sh/bun/issues/811
Reporting here because you may have an idea.
Simplest example is:
import { bench, run } from "mitata";

import * as ejs from 'ejs';

let people = ['geddy', 'neil', 'alex'];

bench('literal', () => { return `${people.join(', ')}`; });

bench('ejs-join', () => {
    ejs.render('<%= people.join(", "); %>', { people: people });
});

try {
    await run();
} catch (err) { console.error(err); }

If I run this code standalone (without Mitata) it executes perfectly on Bun.  If I comment out the ejs-join stanza, it still segfaults, and if I comment out the import for ejs then Bun does not segfault.

Did you test it with bun 0.1.8? It should have fixed segfaults.

I hadn't been aware 0.1.8 was available, I'd seen 0.1.7 was available a couple days ago.  Thank you for letting me know.
This is what I get with  my rendering test on Bun.  There's no segfault, and I haven't investigated the Nunjucks failure yet.
><EMAIL_ADDRESS>render:bun
> bun render-bun.js

cpu: Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz
runtime: bun 0.1.8 (x64-linux)

benchmark                 time (avg)             (min … max)
------------------------------------------------------------
literal               138.63 ns/iter (113.11 ns … 589.08 ns)
ejs-join               24.47 µs/iter     (16.8 µs … 3.59 ms)
ejs-list               44.79 µs/iter    (31.96 µs … 2.98 ms)
handlebars-join-once    4.21 µs/iter     (2.94 µs … 2.44 ms)
handlebars-list-once     4.5 µs/iter   (3.33 µs … 772.88 µs)
liquid-join            39.59 µs/iter    (21.56 µs … 2.84 ms)
liquid-list           124.14 µs/iter    (81.42 µs … 1.62 ms)
nunjucks-join         error: _Loader.call is not a function. (In '_Loader.call(this)', '_Loader.call' is undefined)
FileSystemLoader@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/src/node-loaders.js:31:27
configure@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/index.js:31:52
renderString@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/index.js:76:18
@/home/david/Projects/akasharender/akashacms-perftest/bench/render-bun.js:62:39
@/home/david/Projects/akasharender/akashacms-perftest/node_modules/mitata/src/lib.mjs:37:19
@/home/david/Projects/akasharender/akashacms-perftest/node_modules/mitata/src/cli.mjs:188:40
@[native code]
nunjucks-list         error: _Loader.call is not a function. (In '_Loader.call(this)', '_Loader.call' is undefined)
FileSystemLoader@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/src/node-loaders.js:31:27
configure@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/index.js:31:52
renderString@/home/david/Projects/akasharender/akashacms-perftest/node_modules/nunjucks/index.js:76:18
@/home/david/Projects/akasharender/akashacms-perftest/bench/render-bun.js:65:39
@/home/david/Projects/akasharender/akashacms-perftest/node_modules/mitata/src/lib.mjs:37:19
@/home/david/Projects/akasharender/akashacms-perftest/node_modules/mitata/src/cli.mjs:188:40
@[native code]
markdown-render        37.61 µs/iter    (21.89 µs … 5.59 ms)
cheerio                 94.1 µs/iter    (55.77 µs … 3.53 ms)


Updated HolidayList For Year 2019

Fixes #27
Updated Holiday List

@Anu1601CS Please look at these PR's

@Anu1601CS Please look all these PR's ASAP.

@Anu1601CS Please look all these PR's ASAP.


MINOR: KAFKA-3989_follow_up_PR: update script to run from kafka root eg ./jm…

…h-benchmarks/jmh.sh

@ijuma - script updated  ./jmh-benchmarks/jmh.sh works now

@ijuma - my apologies for the oversight.  Confirmed the following all work with this update.

./jmh.sh
./jmh-benchmarks/jmh.sh
jmh-benchmarks/jmh.sh

LGTM. Merged to trunk and cherry-picked to 0.11.0.


react-prosemirror requires "babbel-loader?optional=runtime"

Since react-prosemirror relies on Object.assign it needs to be compiled with babel-runtime. Hence it would be great to update to update the README for other developers.
{
  test: /\.js?$/,
  include: [/prosemirror/, /react-prosemirror/],
  loaders: ["babel-loader?optional=runtime"]
},

If I'm not mistaken, something like babel-polyfill is actually what is needed here. I've added a note about that to the readme, along with the basic required options to use Babel 6. Please let me know if I missed something. Thanks!


Edit window not opening on the correct side

The edit window opens left of the main window if the main window is on the right side of the screen, but I move the main window a little bit to the left, the edit window moves to the right of it, although there's not enough space to show the whole edit window. Could you please fix this behaviour in order to always show the whole edit window? Thanks.

For me the behaviour is the intended one:

The edit popup opens on the right side if and only if there is enough space.
Otherwise it opens on the left (where there may not be enough space, nothing special is done in that case).

User seems to report 1. not being the case, which I cannot reproduce at the moment.

Closing until we can reproduce or get more information.

Another user has reported the same, and I did see the problem myself the other day. May have to do with higher DPI settings (though I was not able to reproduce it with any settings when I tried).
Needs investigation, debugging and fixing.

I can now confirm that the problem is related to DPI settings. Specifically, WPF gives all positions/sizes DPI aware (not actual pixels), while the code we use to determine the size of the screen returns actual pixels. We'll probably have to transform one set of coordinates to the other and do the calculations that way.


More info about pushState and replaceState actions

Basic pushState example and replaceState info

Just wanted to say that this was helpful, thanks for writing it up. Gets a :+1: from me since it helped explain how to use these to change state (I am new to Redux) and I think moves the documentation forward.

Thanks for spelling correction, still waiting for merge :)

Hey, if you could update this according to the latest version, I will merge this in. :+1:

It should be fine now.


Update to use Environment Files in CI

receive-pr-and-deploy
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This is not completed yet!!!

This is not completed yet!!!

Looks tumultuous with all the issue opens and closes hope that you have this under control. 👀

This one has been quite complicated to follow with the references to multiple issues/PRs. For future reference @0xcodercrane I've been trying to keep the payment proofs on the actual issues/bounties instead of the PRs.
I presume that this is all finished according to the spec.
@kfukue what is your Ethereum wallet address? We will send DAI and UBQ. Thanks.

@pavlovcik  @0xcodercrane Thanks, yea sorry I wasn't too familiar with github's CI/CDs but I'll use the forked version going forward.
@pavlovcik My eth address is 0xB33aC2640b814145F76c1ba3B5D6aAB2216098aD. I'll look into more tasks going forward!

https://etherscan.io/tx/0xb7b64a41e7085d7b05b60b4dabe2fafc997d69977a57f66038c29d47867a4836
https://etherscan.io/tx/0x0b01b9d9f3c3a510fb786f0b1efa3936561d1b55b4b695a51392bfc780b9d426

@pavlovcik Thanks!


Fixed files json updated to 4.2

Hello,
Just wanted to point out that, on my repository i've fixed and updated all the jsons in data to be compatible with Final Fantasy XIV patch 4.2
https://github.com/easly1989/ffxiv_act_dfassist/tree/master/data
You may include those updated files to your project as well.
Just one thing.
For all the language i've used the English names for the dungeons (and comments).
If you have/can find the source for the correct translation feel free to modify them.
best regards,
Carlo

Hello,
Thanks!
Unfortunately, the IDs seem to be completely different on my computer (tested with several friends too) for some reason.
Sastasha, for example, is instance ID #4 on my and my friends' clients.
We are all using English and we're all on Aether.
The IDs might have become specific to datacenters.

A quick update:
Also for me Sastasha had ID 4, so I think the ID are still "global" and not related to datacenters!
The thing I've noticed is that, the event I capture while "Matching" is still using the old ID (infact i can see the right instance in the log window), while the "Matched" and "Begin Matching" events receive the updated version.
I've tried searching for another byte on the data we receive, but without results.
After work i'll try to get as much instance IDs as I can "manually" xD... but this is not the right approach imho;
If you find a better/reliable source for this datas, please keep me updated,
Thank you (:

Found out those new IDs are used at the moment when duty "matched".  Old IDs and New IDs are both used now.


Update 5_oracles-supra-vrf.md

Fix broken
Please refer to the Supra documentation

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


.npmrc != npmrc, it should be npmrc

fixes #46

Thank you very much - I was just about to fix this myself. Thanks for fixing!

@felixrieseberg thanks, can you rel tag it?

Already done - the button doesn't update for a while, but 0.5.1 was just released. Thanks again!


Avoid using out-of-bounds field elements (in impossible cases)

secp256k1_fe_set_b32_limit says that when it returns 0, one is not allowed to use the resulting output value.
This refactors the code so that 0 is returned early (indicating failure) in cases where sha256 would output an out-of-bounds hash value. This makes secp256k1_generator_generate_internal variable-time in its "t" argument, but this not a problem because this value is public in applications.
Note: This situation is cryptographically impossible to occur.
Alternative to #282. cc @roconnor-blockstream What do you think?

Seems okay to me if you folks are okay with the variable time in these (impossible) cases.

Seems okay to me if you folks are okay with the variable time in these (impossible) cases.

AFAIU, we should be okay even if the cases were more likely. The derivation of generators should only be a public computation (except maybe blinding), but it will be nice if @apoelstra can confirm that I haven't overlooked anything in this argument.

I agree with you, except that the code seems to have been clearly and deliberately written to be constant time for some reason.


Can't sent Twitter notification - exception

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
.49.1
Python release (python3 --version):
3.5.2
Component/platform:
notify/twitter
Description of problem:
I cannot send notifications using twitter because of an exception
Expected:
Notification to be sent.
Problem-relevant configuration.yaml entries and steps to reproduce:
- id: to_work
  alias: 'to work
  trigger:
    platform: zone
    entity_id: device_tracker.person
    zone: zone.the_zone
    event: enter
  action:
    service: notify.twitter
    data:
      message: 'message'

Traceback (if applicable):
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
    result = coro.throw(exc)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/core.py", line 1023, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/notify/__init__.py", line 136, in async_notify_message
    yield from notify_service.async_send_message(**kwargs)
  File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/notify/twitter.py", line 63, in send_message
    media = data.get(ATTR_MEDIA)
AttributeError: 'NoneType' object has no attribute 'get'

Additional info:

Was fixed with #8513.
Duplicate of #8514.

@fabaff is this in .49.1? I have upgraded and am still getting twitter exceptions.

No, sorry...will be in 0.50. I missed to mark it for 0.49.1

@fabaff Gotcha - thank you very much!


Represent node problems using NoExecute taint, and allow user-defined eviction time threshold using tolerationSeconds

Feature Description

One-line feature description (can be used as a release note):
Primary contact (assignee): @gmarek
Responsible SIGs: @kubernetes/sig-scheduling-feature-requests
Design proposal link (community repo):
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
Approver (likely from SIG/area to which feature belongs):
Feature target (which target equals to which milestone):

Alpha release target (x.y)
Beta release target (x.y)
Stable release target (x.y)

# Description
Today, a class of node problems is reported via NodeStatus.Condition["Ready"]. In particular, False ("NotReady") means that Kublet has detected a problem, and "Unknown" means that NodeController has lost contact with the node. Today NodeController evicts all of the pods from a node when the node has been in either state for five minutes (subject to various rate limiting policies).
This feature will allow pods to customize their response to these events: they can specifying whether they want to be evicted, and if so how long to wait to see if the problem is resolved before the eviction happens (i.e. replacing the current 5 minute period that is applied to all pods). The node problems that we want pods to be able to configure their response to, will be represented using taints, and pods can specify their desired response using a toleration that specifies tolerationSeconds (unless they want to be evicted immediately, in which case no toleration is necessary).
Taints and tolerations (#108) will be going to beta in 1.6. In contrast, this feature corresponds to

implementing NoExecute behavior option for taints, which means "evict already-running pod that does not tolerate the taint" (currently, taints only prevent scheduling, they do not trigger eviction). Eviction will be done in NodeController for now.
adding tolerationSeconds field to toleration, which will be respected by the aforementioned eviction agent.  (this used to be called "forgiveness")
modifying NodeController to create taints when it sees or sets NotReady or Unknown NodeCondition. These taints will trigger eviction using the mechanism in (1) instead of using the existing codepath for evictions in NodeController.

Progress Tracker

[ ] Alpha

[ ] Write and maintain draft quality doc

[ ] During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK

[ ] Design Approval

[ ] Design Proposal.  This goes under design-proposals.  Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation.  Paste link to merged design proposal here: PROPOSAL-NUMBER
[ ] Decide which repo this feature's code will be checked into. Not everything needs to land in the core kubernetes repo. REPO-NAME
[ ] Initial API review (if API).  Maybe same PR as design doc. PR-NUMBER

Any code that changes an API (/pkg/apis/...)
cc @kubernetes/api

[ ] Identify shepherd (your SIG lead and/or<EMAIL_ADDRESS>will be able to help you). My Shepherd is<EMAIL_ADDRESS>(and/or GH Handle)

A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.

[ ] Identify secondary/backup contact point. My Secondary Contact Point is<EMAIL_ADDRESS>(and/or GH Handle)

[ ] Write (code + tests + docs) then get them merged.  ALL-PR-NUMBERS

[ ] Code needs to be disabled by default.   Verified by code OWNERS
[ ] Minimal testing
[ ] Minimal docs

cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io

[ ] Update release notes

[ ] Beta

[ ] Testing is sufficient for beta
[ ] User docs with tutorials
- Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
- cc @kubernetes/docs on docs PR
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Thorough API review

cc @kubernetes/api

[ ] Stable

[ ] docs/proposals/foo.md moved to docs/design/foo.md
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Soak, load testing
[ ] detailed user docs and examples

cc @kubernetes/docs
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need.  Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs.  Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing.  They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

[ ] Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

This is finished except for documentation.
The PRs involved were:

kubernetes/kubernetes#39469: Forgiveness (tolerationSeconds) API changes
kubernetes/kubernetes#39914: Forgiveness (tolerationSeconds) library changes
kubernetes/kubernetes#41414 and kubernetes/kubernetes#41815: defaultTolerationSeconds admission controller
kubernetes/kubernetes#41896: Make DaemonSets survive taints
kubernetes/kubernetes#40355: TaintController
kubernetes/kubernetes#41014: Refactoring
kubernetes/kubernetes#41133: NodeController sets node taints instead of deleting pods
kubernetes/test-infra#197: Enable e2e test suite in Jenkins

@davidopp @gmarek @kevin-wangzefeng please, provide us with the release notes and documentation PR (or links) at https://docs.google.com/spreadsheets/d/1nspIeRVNjAQHRslHQD1-6gPv99OcYZLMezrBe3Pfhhg/edit#gid=0

Documentation PR out for review at https://github.com/kubernetes/kubernetes.github.io/pull/2774/files

ref/ https://github.com/kubernetes/kubernetes/issues/43815#issuecomment-290560053

Regarding "taint-based eviction for node problems is in Alpha": nobody is available to move it to beta in 1.7, so it will stay in alpha in 1.7.

@davidopp I can help on this and target for 1.7, one question is that I saw https://github.com/kubernetes/kubernetes/pull/40355 is already enabled by default, so can you please explain more for what do you mean by move this to beta in 1.7?

@gyliu513 - taint controller is enabled by default, but using taints instead of direct evictions in case of node problems isn't. To move it to beta there's at least one thing to be done (except renaming stuff from alpha to bete), which is to rewrite/write new NodeController unit tests, as they currently assume direct evictions. There are some very basic tests for taint-based evictions, but they should be drastically extended (e.g. cover all master-disruption logic).

I think we can only do this in 1.7 if @gmarek has the bandwidth to do all the reviews and define what we need to do to move it to beta. (Sounds like he's already done most of the second thing above.)
@gmarek do you have time?

Yes, I can find time for reviews and I can find time to think through what needs to be done, if there's someone willing to work on it.

@davidopp @gmarek I will be the volunteer for this, can you please assign this to me? @gmarek will go through this feature and propose sth to you

assigned

@gyliu513 OK - let me know if you need some directions.

@davidopp @gmarek I've updated the feature description to fit the new template. Please, fill the empty fields in the new template (their actual state was unclear).

Move to Beta is goal for 1.7.

@gmarek I want to split the work to two tasks:

Rename from alpha to beta.
Update unit test for node controller to cover more cases.

Comments?

Renaming involves updating feature gates as well. I'd add:

Update docs

Figuring out a solution to the discussion that starts here https://github.com/kubernetes/kubernetes/issues/44445#issuecomment-300851815 is a blocker to moving this to beta.

BTW I'm pretty nervous that we haven't really had people try out the alpha feature. Unless we can get some significant uses of the alpha feature very soon, we shouldn't move this to beta in 1.7. This feature can cause significant disruption/problems if there are bugs.

@davidopp so, have you finally agreed on the feature goal for 1.7? Will you keep it as alpha or promote to beta? cc @kubernetes/sig-scheduling-feature-requests

I don't think we should move it to beta in 1.7. Nobody has stepped forward to coordinate getting users of the alpha version of the feature, and until we have people successfully using the alpha it's not safe to move it to beta.

@davidopp thanks, will remove from 1.7 milestone.

https://github.com/kubernetes/kubernetes/issues/45342

@davidopp @timothysc This will be moved to beta in v1.8, right?

Maybe. It has lower priority that moving other NodeConditions to Taints.

@gmarek @davidopp @kubernetes/sig-scheduling-feature-requests any updates for 1.8? Is this feature still on track for the release?

@k82cn

@k82cn can you please write e2e tests for this?

@gmarek can you confirm this is ready for Beta? And you feel it is safe to enable by default (switch the NodeController path from using status for eviction to using taints for eviction)?

If it does not have e2e tests I do not think we should enable it...

As far as I understood from @k82cn, this would stay in alpha for one release and become beta in v1.9...
I think we renamed a couple of constants, that should be reflected in release notes for v1.8

wow, sorry for the late response. let's add this into my queue for 1.9.

This feature will still be alpha in 1.9 as we discussed; but I'll add e2e test for it. We'll upgrade to beta (enabled by default) when there're enough user of this feature :).

@kubernetes/sig-node-feature-requests

@k82cn @davidopp What's blocking this to graduate to beta?

@luxas I'd really like a few "real" Kubernetes users to try this out before we move it to Beta (hence enable by default). It's a dangerous change because in the worst case it can evict all the pods in the cluster. It also needs (more) e2e tests; looks like @k82cn offered to write some.
BTW there was also an unofficial agreement with sig-node that we would transfer ownership of this from sig-scheduling to sig-node. So I think they should make the decision about when it moves to Beta, but this is my opinion.

@luxas I'd really like a few "real" Kubernetes users to try this out before we move it to Beta

@davidopp How can we get these "real" users? Do we have an action plan for that?

Pretty much what David wrote. We need more data and more tests. Current NC unit tests are bad but they cover original behavior pretty well. We do have some basic unit tests for this behavior (and an e2e test for it: https://k8s-testgrid.appspot.com/google-gce#gce-taint-evict - which also shows that it is possible to write non-flaky e2e test:), but we need to noticeably increase the unit test coverage for the new behavior.
Testing part is probably a week-ish of work, but finding someone to test is probably much more work.

davidopp@ How can we get these "real" users? Do we have an action plan for that?

Can we enable this by default in some test/dev tools, e.g. local cluster? That's really a challenge for user to try it in prod environment for this feature :).
/cc @luxas @davidopp @gmarek

/lifecycle frozen

The best we can do in OSS is to create a dedicated test suite for this. If someone is running tests internally it would be good to know, but I don't think we ever figured out how to gather such data.

@gmarek
Any plans for this in 1.11?
If so, can you please ensure the feature is up-to-date with the appropriate:

Description
Milestone
Assignee(s)
Labels:

stage/{alpha,beta,stable}
sig/*
kind/feature

cc @idvoretskyi

/remove-lifecycle frozen

@justaugustus , the draft plan will be 1.13 if no one help on that. We (sig-scheduling) would like to get TaintNodesByCondition and ScheduleDaemonSetPod graduated to beta firstly. Assign to myself to follow up :)
/assign

/remove-lifecycle rotten

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.
If so, please ensure that this issue is up-to-date with ALL of the following information:

One-line feature description (can be used as a release note):
Primary contact (assignee):
Responsible SIGs:
Design proposal link (community repo):
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
Approver (likely from SIG/area to which feature belongs):
Feature target (which target equals to which milestone):

Alpha release target (x.y)
Beta release target (x.y)
Stable release target (x.y)

Set the following:

Description
Assignee(s)
Labels:

stage/{alpha,beta,stable}
sig/*
kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.
In addition, please be aware of the following relevant deadlines:

Docs deadline (open placeholder PRs): 8/21
Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.
Happy shipping!
P.S. This was sent via automation

/milestone next-milestone

/milestone v1.13

@k82cn  can you plz update this issue with your level of confidence, whats pending in terms of PR, test and docs for this feature to wrap in 1.13? Considering the various test stability issues we ran into last cycle, it will be great to land the open PRs sooner in this cycle to we have enough time to watch the CI signals and stabilize.
Currently Code Slush for 1.13 is Nov 9th and Freeze starts on Nov 15th. Thanks

FWIW I put a /hold on https://github.com/kubernetes/kubernetes/pull/69824 because it seems to me like not everything has been finished before promoting to beta.  Am I misunderstanding what that PR is doing?

@k82cn thanks for the update above
@Huang-Wei and @ravisantoshgudimetla I see only 1/7 tasks complete in #69533. Is there any ETA for other tasks to be complete and when this will be enabled in master? As mentioned earlier, we would like to get this feature code and test complete sooner than later so we have enough time to  monitor the test results in master and stabilize. Is it possible to get all open PRs wrangled by end of this month?

@AishSundar we're tracking this as our highest priority. We're optimitic to finish them by end of this month - among the resting 6 ones: one might be duplicated, one is docs update, one is performance enhancement (good to have, not blocker). The other 3 ones are being reviewed, should be able to be merged soon.

Thanks for the update @Huang-Wei. could you point me to the performance enhancement PR/ issue plz? thanks

It's https://github.com/kubernetes/kubernetes/pull/65350.

Hi @Huang-Wei @davidopp @ravisantoshgudimetla , I'm the docs wrangler for the 1.13 release. Could you please open a placeholder PR for the docs for this enhancement against the dev-1.13 branch of k/website and send me a link? If you already have a docs PR open, or if this doesn't require docs in k/website, please let me know.
The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible.
If you have any questions about any of this, I'm happy to help. You can also message me on slack (I'm tfogo there too). 😀
Thanks! ✨

@tfogo there is already a docs PR: https://github.com/kubernetes/website/pull/10765.
It's being reviewed right now. cc/ @k82cn @bsalamat @ravisantoshgudimetla that

The deadline for placeholder PRs for the 1.13 release is November 8`.

@Huang-Wei Awesome thanks!

@Huang-Wei -I'm an enhancements shadow checking in on this issue - sounds like progress is being made - as an FYI code slush is 11/9 and Code freeze is 11/15 - any concerns about making those dates

@claurence We're trying to enhance one final e2e test. Right now we have PR https://github.com/kubernetes/kubernetes/pull/70681 ongoing, and it's the plan A. If its changes is too aggressive or can't make the date, we also have a plan B PR.
So generally I'm optimistic on making the 11/15 date.

I think we need to keep this open until it GAed.

Oh yes wee will keep this open, but no PR pending for going Beta in 1.13, right?

@AishSundar we're good for going Beta in 1.13.

Hello @gmarek @k82cn @Huang-Wei , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. This will also need a KEP to be included.
Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

Hi @gmarek @k82cn @Huang-Wei , I'm the 1.16 Enhancement Lead/Shadow.  Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.
Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.
As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.
Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.
Thank you.

Hey there @gmarek @k82cn @Huang-Wei , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?
The current release schedule is:

Monday, September 23 - Release Cycle Begins
Tuesday, October 15, EOD PST - Enhancements Freeze
Thursday, November 14, EOD PST - Code Freeze
Tuesday, November 19 - Docs must be completed and reviewed
Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
Please note that all enhancements should have a KEP, the KEP PR should be merged, the KEP should be in an implementable state, have a testing plan and graduation criteria.
Thanks!

/remove-lifecycle stale

Hey there @gmarek @k82cn @Huang-Wei -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to [alpha|beta|stable] in 1.18 or having a major change in it's current level?
The current release schedule is:

Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release,

The KEP PR must be merged
The KEP must be in an implementable state
The KEP must have test plans and graduation criteria.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks! :)

@palnabarun Thanks for the reminding. Given that it's been beta since 1.13, and we haven't got any blocker issue. We'd like to promote it to GA in 1.18.
(BTW: in 1.17, we refactored the TaintBasedEviction e2e test - to transform it to integration test for portability, and also fixed some flakiness)

@Huang-Wei Thank you for the updates. I will update the tracking sheet accordingly.
I see that this enhancement predates the KEP process. Just a nit here, in order to be able to track this enhancement, we need a merged KEP, in an implementable state and with test plans and graduation criteria.

/stage stable

/milestone v1.18

I see that this enhancement predates the KEP process. Just a nit here, in order to be able to track this enhancement, we need a merged KEP, in an implementable state and with test plans and graduation criteria.

/cc @damemi ^^ Could you please update the KEP as well? Thanks.

Hi @damemi, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March.
Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement?
Thank You :)

Hi @palnabarun, we have an umbrella issue which links to the issues/PRs that are in the works for this: https://github.com/kubernetes/kubernetes/issues/87161

Thank you @damemi for updating this. :)

Hey @damemi  -
Seth here, Docs shadow on the 1.18 release team.
Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?
If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.
Let me know if you have any questions!

@sethmccombs IIUC, given I have the doc PR opened against dev-1.18 branch, there's no need to update any sheet, right?

@ingvagabund you got it, I'll update the Enhancement tracking sheet!

Hi @damemi, this a reminder that we are just two days away from Code Freeze on 5th March.
By the Code Freeze, all the relevant PR's should be merged else you would need to file an exception request.

@palnabarun I've updated the 3 PRs that this is waiting on to see if they will merge by code freeze.

https://github.com/kubernetes/kubernetes/pull/88152
https://github.com/kubernetes/kubernetes/pull/87487
https://github.com/kubernetes/website/pull/19302

@palnabarun actually before those 3 can merge, we need to get the KEP move approved: https://github.com/kubernetes/enhancements/pull/1510

@damemi I see that the PR's are blocked on approvals at the moment. Do you think they would make it before the deadline?
Today EOD is the Code Freeze
Please file an exception if you think the PR's might slip the deadline.

I think we will need more time to get the approvals, what's the process to file an exception?

@damemi, you can find the process here https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@jeremyrickard thanks, exception filed

@damemi The exception request was approved. :)

Hi @damemi, since this enhancement graduated to Stable this release :rocket:, the status can now be set to be Implemented.
Can you please update the status? After that, we will close this issue.

@palnabarun sure, opened that here: https://github.com/kubernetes/enhancements/pull/1625

Thank you @damemi :)

The corresponding enhancement has graduated to Stable. :partying_face:
Closing this issue.
/close

Edit: The issue description here had a 404 link. Pointed it to the correct one.


update datatables responsive plugin

Updating datatables responsive plugin to 2.2.7

A new inspection was created.

@tabacitu is the the correct way to update this dep ?
Best,
Pedro

The inspection completed: No new issues

Hi @pxpm, I talked with @tabacitu about this update.
This PR is not enough, @tabacitu will need to run the full asset compilation.
Also, this new version of datatables introduced a breaking change, we need to do a small change on list.css I described it here; https://github.com/Laravel-Backpack/CRUD/pull/3594

Closed in favor of #3594


Add logout link in Chinese translations in screen.*.security properties (4.2.x)

same update as #2548, but for 4.2.x branch

Thank you. Please see https://apereo.github.io/cas/developer/Maintenance-Policy.html


Using async items inside mapDispatchToProps

Hi @moroshko,
first, many thanks for react-autowhatever. Great work. And great name.
I’m having difficulties with onMouseDown and onKeyDown(case: 'Enter').
They access items inside mapDispatchToProps, as in items[focusedItemIndex].
My items are loaded asynchronously.
The actions inside mapDispatchToProps can’t find the items, which are Redux state, and they stay undefined.
Any suggestion on how to correctly tie the items coming from the state to those functions?
Here’s my component if you’d like to see the context: https://gist.github.com/gusaiani/afd56e4655e2aca83859
Thanks in advance for your help.

@gusaiani I'd probably have the items you retrieved asynchronously injected to Companies as props via mapStateToProps(). Then, you could use ownProps in mapDispatchToProps() (the second argument) to get those items.
Having said that, it looks like you are trying to implement an Autosuggest component. Have you considered using react-autosuggest?
Btw, how did you find about react-autowhatever's existence?

Thanks, @moroshko, I’ll give that a try.
I found a more verbose to make it work but yeah...need to make it elegant.
I found this lib by googling, really.
I also tried react-autosuggest for a few hours, but to be honest I found it much easier to implement react-autowhatever.
Read the source code for each example and it was quite easy.
For some reason I found the implementation code for autosuggest, in the README and Codepen examples, were harder to learn from.
I’m sticking with this one :)
Thank you again!

@gusaiani Thanks for your feedback.

Thank you.
The lib is "live" at www.lookintens.com as a matter of fact.
The data is not real yet, I will add a disclaimer soon, but autowhatever seems to work very well.

@gusaiani Thanks for the link! FYI, if I press Enter when input is focused, I get a JS error.
Btw, I simplified the API in react-autosuggest recently, so you might want to give it another chance in the future ;)

Thanks, I'll fix that.
Awesome, I'll sure check out react-autosuggest again then.


Routing + Additional Dashboard UI Component/Functionality

Major addition in PR is the routing functionality

Clicking different pages routes URL to corresponding pages
Dashboard page is '/'
Business process page is '/business-process/'
Log events page is '/LogEvent/'

Additional features:

Counts components
Clicking SEE MORE button on counts/timelines routes to log events page
Clicking on the timeline routes to log events page
Timeline interactivity passes important parameters to log events page
Donut charts, timelines, and counts component display data according to 20,000 fake data entries we created
Dashboard is interactive with the timeframe dropdown
Refresh button fetches latest data relative to timeframe

For filter passing between Dashboard --> Log Event page:

LogEvent component can access through props by props.logEventFilters
props.logEventFilters is a dictionary with attributes:
start: Moment() object (inclusive)
end: Moment() object (inclusive)
type: 'severity' or 'priority'
if type is severity --> severity: 'Error', 'Warning', or 'Logs' (Logs = all logs)

@Phil-Nettekoven Oops I just added a change to fix our lint errors--could you approve it again? Thanks!


[SPARK-30216][INFRA] Use python3 in Docker release image

What changes were proposed in this pull request?

Reverts commit 1f94bf4 and d6be46e
Switches python to python3 in Docker release image.

Why are the changes needed?
dev/make-distribution.sh and python/setup.py are use python3.
https://github.com/apache/spark/pull/26844/files#diff-ba2c046d92a1d2b5b417788bfb5cb5f8L236
https://github.com/apache/spark/pull/26330/files#diff-8cf6167d58ce775a08acafcfe6f40966
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test:
yumwang@ubuntu-3513086:~/spark$ dev/create-release/do-release-docker.sh -n -d /home/yumwang/spark-release
Output directory already exists. Overwrite and continue? [y/n] y
Branch [branch-2.4]: master
Current branch version is 3.0.0-SNAPSHOT.
Release [3.0.0]: 3.0.0-preview2
RC # [1]:
This is a dry run. Please confirm the ref that will be built for testing.
Ref [master]:
ASF user [yumwang]:
Full name [Yuming Wang]:
GPG key<EMAIL_ADDRESS>DBD447010C1B4F7DAD3F7DFD6E1B4122F6A3A338
================
Release details:
BRANCH:     master
VERSION:    3.0.0-preview2
TAG:        v3.0.0-preview2-rc1
NEXT:       3.0.1-SNAPSHOT

ASF USER:   yumwang
GPG KEY:    DBD447010C1B4F7DAD3F7DFD6E1B4122F6A3A338
FULL NAME:  Yuming Wang
E-MAIL<EMAIL_ADDRESS>================
Is this info correct [y/n]? y
GPG passphrase:

========================
= Building spark-rm image with tag latest...
Command: docker build -t spark-rm:latest --build-arg UID=110302528 /home/yumwang/spark/dev/create-release/spark-rm
Log file: docker-build.log
Building v3.0.0-preview2-rc1; output will be at /home/yumwang/spark-release/output

gpg: directory '/home/spark-rm/.gnupg' created
gpg: keybox '/home/spark-rm/.gnupg/pubring.kbx' created
gpg: /home/spark-rm/.gnupg/trustdb.gpg: trustdb created
gpg: key 6E1B4122F6A3A338: public key "Yuming Wang<EMAIL_ADDRESS>imported
gpg: key 6E1B4122F6A3A338: secret key imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg:       secret keys read: 1
gpg:   secret keys imported: 1
========================
= Creating release tag v3.0.0-preview2-rc1...
Command: /opt/spark-rm/release-tag.sh
Log file: tag.log
It may take some time for the tag to be synchronized to github.
Press enter when you've verified that the new tag (v3.0.0-preview2-rc1) is available.
========================
= Building Spark...
Command: /opt/spark-rm/release-build.sh package
Log file: build.log
========================
= Building documentation...
Command: /opt/spark-rm/release-build.sh docs
Log file: docs.log
========================
= Publishing release
Command: /opt/spark-rm/release-build.sh publish-release
Log file: publish.log

Generated doc:

Test build #115167 has started for PR 26848 at commit 3039465.

Generating markdown files for SQL documentation.
19/12/11 08:57:10 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Traceback (most recent call last):
  File "/opt/spark-rm/output/spark/sql/gen-sql-markdown.py", line 222, in <module>
    from pyspark.java_gateway import launch_gateway
  File "/opt/spark-rm/output/spark/python/lib/pyspark.zip/pyspark/__init__.py", line 51, in <module>
  File "/opt/spark-rm/output/spark/python/lib/pyspark.zip/pyspark/context.py", line 22, in <module>
ImportError: No module named threading
log4j:WARN No appenders could be found for logger (org.apache.spark.util.ShutdownHookManager).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
jekyll 3.8.6 | Error:  SQL doc generation failed

Another error.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19978/
Test PASSed.

Test build #115167 has finished for PR 26848 at commit 3039465.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115167/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19999/
Test PASSed.

Test build #115188 has started for PR 26848 at commit 9832f05.

Test build #115188 has finished for PR 26848 at commit 9832f05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115188/
Test PASSed.

Test build #115204 has started for PR 26848 at commit 98cd80a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20015/
Test PASSed.

Test build #115206 has started for PR 26848 at commit 02896e3.

Test build #115209 has started for PR 26848 at commit 1f2ede8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20019/
Test PASSed.

Test build #115206 has finished for PR 26848 at commit 02896e3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #115204 has finished for PR 26848 at commit 98cd80a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115206/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115204/
Test PASSed.

Test build #115209 has finished for PR 26848 at commit 1f2ede8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115209/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20030/
Test PASSed.

retest this please

Test build #115228 has started for PR 26848 at commit 71b642d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20041/
Test PASSed.

Test build #115228 has finished for PR 26848 at commit 71b642d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115228/
Test FAILed.

retest this please

Test build #115237 has started for PR 26848 at commit 71b642d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20046/
Test PASSed.

Test build #115237 has finished for PR 26848 at commit 71b642d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115237/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20050/
Test PASSed.

Test build #115242 has started for PR 26848 at commit 71b642d.

Test build #115242 has finished for PR 26848 at commit 71b642d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115242/
Test PASSed.

I tested it on the master branch. Do we need to test on branch-2.4?

No~  This is for 3.0. branch-2.4 release script is for 2.4.

I tested it on the master branch. Do we need to test on branch-2.4?


docs: add notes about development dependencies

Resolves #705.
PR Checklist

[x] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[x] If you've added or modified a feature, documentation in docs is updated

Description of changes
Add notes about development dependencies, so that users better understand that development dependencies are not considered for DEP002 rule.

🙏 thanks for this change


[TEST Only] test sbt 1.10.0 performance without local maven repo cache

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

In the mima step
1.with local maven repo cache:
2.without local maven repo cache:

cc @LuciferYang @dongjoon-hyun

I have narrowed the scope of the impact of not using local maven repo cache to the step MIMA test of the job lint

MIMA took 8 minutes and 6 seconds, and there doesn't seem to be a significant performance difference. I think this is feasible.
Could you have it run a few more times to confirm that this execution time is relatively stable?

MIMA took 8 minutes and 6 seconds, and there doesn't seem to be a significant performance difference. I think this is feasible.
Could you have it run a few more times to confirm that this execution time is relatively stable? @panbingkun

Sure, let me to do it.

I ran it twice again today.
It was verified that the performance of the mima step seemed to be stable at about 8 min and ... seconds without local maven repo cache.
@dongjoon-hyun @LuciferYang

This is fine for me, and the time is about the same as using the maven local cache. But I suggest splitting disable maven local cache and upgrade to sbt 1.10.0 into two separate PRs.

This is fine for me, and the time is about the same as using the maven local cache. But I suggest splitting disable maven local cache and upgrade to sbt 1.10.0 into two separate PRs.

1.Disable maven local cache on GA's step MIMA test
https://github.com/apache/spark/pull/46551
After the above pr is merged, I will upgrade the sbt to 1.10.0 based on this pr.

A test without local maven repo cache
https://github.com/apache/spark/pull/46606


Blob properties dialog: no visible or audible error message when there is no metadata name or value

Storage Explorer Version: 1.2.0
Platform: Windows
Architecture: win32
Regression From: Unknown
Steps to Reproduce:

Open the properties dialog for a blob with
Tab to the add metadata button
Hit enter
Tab up to the value text box and enter a value
Tab to the name text box and delete it

Expected Experience:
There should be a text error message that says the metadata needs a name. The same error should also be ready the screen reader.
Actual Experience:
There's neither of those! 😢

This issue has been fixed. So close it.


[BUG] Graphscope installation fails on Apple M1/Silicon

Describe the bug
When running import graphscope after installing graphscope on an Apple Silicon Mac, the Python interpreter crashes with the following error:
[libprotobuf ERROR google/protobuf/descriptor_database.cc:559] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
[libprotobuf FATAL google/protobuf/descriptor.cc:1357] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
libc++abi: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
zsh: abort      python

To Reproduce
Steps to reproduce the behavior (on Apple Silicon):

Install graphscope via pip install graphscope in a Python virtual environment.
Run import graphscope in a Python shell inside the virtual environment.

Expected behavior
No output upon import as graphscope would have correctly initalised.
Environment:

GraphScope version: 0.13.0
OS: macOS Monterey
Version: 12.3.1
Python version: 3.9.11
Kubernetes Version [e.g., 1.19]: None

Hi @gillesmag,
Thanks for reporting. Could you please provide the output of pip freeze in your virtual environment?
Thanks!

Hi @sighingnow, thanks for responding so quickly!
Here's the output of pip freeze:
aenum==3.1.11
aiobotocore==2.3.2
aiohttp==3.8.1
aioitertools==0.10.0
aiosignal==1.2.0
aliyun-python-sdk-core==2.13.36
aliyun-python-sdk-kms==2.15.0
argcomplete==2.0.0
async-timeout==4.0.2
attrs==21.4.0
botocore==1.24.21
cachetools==5.1.0
certifi==2<IP_ADDRESS>
cffi==1.15.0
charset-normalizer==2.0.12
cmake==3.22.4
crcmod==1.7
cryptography==37.0.2
Cython==3.0a6
etcd-distro==3.5.1
frozenlist==1.3.0
fsspec==2022.5.0
future==0.18.2
google-auth==2.6.6
graphscope==0.10.0
graphscope-client==0.10.0
gremlinpython==3.6.0
grpcio==1.46.3
grpcio-tools==1.46.3
gs-coordinator==0.11.0
gs-engine==0.10.0
gs-include==0.10.0
gs-jython==0.13.0
gs-lib==0.10.0
hdfs3==0.3.1
idna==3.3
isodate==0.6.1
jmespath==0.10.0
kubernetes==23.6.0
multidict==6.0.2
nest-asyncio==1.5.5
networkx==2.8.2
numpy==1.22.4
oauthlib==3.2.0
oss2==2.15.0
packaging==21.3
pandas==1.4.2
protobuf==3.18.1
psutil==5.9.1
pyarrow==8.0.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.21
pycryptodome==3.14.1
pyparsing==3.0.9
python-dateutil==2.8.2
pytz==2022.1
PyYAML==6.0
requests==2.27.1
requests-oauthlib==1.3.1
rsa==4.8
s3fs==2022.5.0
scipy==1.8.1
six==1.16.0
sortedcontainers==2.4.0
tqdm==4.64.0
treelib==1.6.1
typing_extensions==4.2.0
urllib3==1.26.9
vineyard==0.3.16
vineyard-io==0.4.2
websocket-client==1.3.2
wrapt==1.14.1
yarl==1.7.2

It seems that my installation was downgraded (updated original post to reflect this). If I try to specify the latest version of graphscope with pip install graphscope==0.13.0, I get the following error:
ERROR: Could not find a version that satisfies the requirement gs-lib==0.13.0 (from graphscope) (from versions: 0.9.1, 0.10.0)
ERROR: No matching distribution found for gs-lib==0.13.0

It seems that pip decides to install an older version of graphscope, namely 0.10.0 (updated original post to reflect this). If I try to specify the latest version of graphscope with pip install graphscope==0.13.0, I get the following error:
ERROR: Could not find a version that satisfies the requirement gs-lib==0.13.0 (from graphscope) (from versions: 0.9.1, 0.10.0)
ERROR: No matching distribution found for gs-lib==0.13.0

We haven't upload the prebuilt wheels for v0.13.0 to pypi yet.

Hi @sighingnow, thanks for responding so quickly!
Here's the output of pip freeze:
aenum==3.1.11
aiobotocore==2.3.2
aiohttp==3.8.1
aioitertools==0.10.0
aiosignal==1.2.0
aliyun-python-sdk-core==2.13.36
aliyun-python-sdk-kms==2.15.0
argcomplete==2.0.0
async-timeout==4.0.2
attrs==21.4.0
botocore==1.24.21
cachetools==5.1.0
certifi==2<IP_ADDRESS>
cffi==1.15.0
charset-normalizer==2.0.12
cmake==3.22.4
crcmod==1.7
cryptography==37.0.2
Cython==3.0a6
etcd-distro==3.5.1
frozenlist==1.3.0
fsspec==2022.5.0
future==0.18.2
google-auth==2.6.6
graphscope==0.10.0
graphscope-client==0.10.0
gremlinpython==3.6.0
grpcio==1.46.3
grpcio-tools==1.46.3
gs-coordinator==0.11.0
gs-engine==0.10.0
gs-include==0.10.0
gs-jython==0.13.0
gs-lib==0.10.0
hdfs3==0.3.1
idna==3.3
isodate==0.6.1
jmespath==0.10.0
kubernetes==23.6.0
multidict==6.0.2
nest-asyncio==1.5.5
networkx==2.8.2
numpy==1.22.4
oauthlib==3.2.0
oss2==2.15.0
packaging==21.3
pandas==1.4.2
protobuf==3.18.1
psutil==5.9.1
pyarrow==8.0.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.21
pycryptodome==3.14.1
pyparsing==3.0.9
python-dateutil==2.8.2
pytz==2022.1
PyYAML==6.0
requests==2.27.1
requests-oauthlib==1.3.1
rsa==4.8
s3fs==2022.5.0
scipy==1.8.1
six==1.16.0
sortedcontainers==2.4.0
tqdm==4.64.0
treelib==1.6.1
typing_extensions==4.2.0
urllib3==1.26.9
vineyard==0.3.16
vineyard-io==0.4.2
websocket-client==1.3.2
wrapt==1.14.1
yarl==1.7.2

Thanks for the information. We would try to reproduce.

Hi @gillesmag ,
I have noticed that you have pyarrow==0.8.0 installed. Could you please try to downgrade it to v6.0.0 and try again (with graphscope v0.10.0).
pip3 install pyarrow==6.0.0

The wheel of latest release for M1 Mac will be uploaded in the next few days.

Oh that did indeed fix it! I remade a new virtual environment and simply ran pip3 install graphscope, but it did install pyarrow==8.0.0 by default. By running pip3 install pyarrow==6.0.0, it did indeed fix the error on import.
As a reference here is the output of pip freeze:
aenum==3.1.11
aiobotocore==2.3.2
aiohttp==3.8.1
aioitertools==0.10.0
aiosignal==1.2.0
aliyun-python-sdk-core==2.13.36
aliyun-python-sdk-kms==2.15.0
argcomplete==2.0.0
async-timeout==4.0.2
attrs==21.4.0
botocore==1.24.21
cachetools==5.2.0
certifi==2<IP_ADDRESS>
cffi==1.15.0
charset-normalizer==2.0.12
cmake==3.22.4
crcmod==1.7
cryptography==37.0.2
Cython==3.0a6
etcd-distro==3.5.1
frozenlist==1.3.0
fsspec==2022.5.0
future==0.18.2
google-auth==2.6.6
graphscope==0.10.0
graphscope-client==0.10.0
gremlinpython==3.6.0
grpcio==1.46.3
grpcio-tools==1.46.3
gs-coordinator==0.11.0
gs-engine==0.10.0
gs-include==0.10.0
gs-jython==0.13.0
gs-lib==0.10.0
hdfs3==0.3.1
idna==3.3
isodate==0.6.1
jmespath==0.10.0
kubernetes==23.6.0
multidict==6.0.2
nest-asyncio==1.5.5
networkx==2.8.2
numpy==1.22.4
oauthlib==3.2.0
oss2==2.15.0
packaging==21.3
pandas==1.4.2
protobuf==3.18.1
psutil==5.9.1
pyarrow==6.0.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.21
pycryptodome==3.14.1
pyparsing==3.0.9
python-dateutil==2.8.2
pytz==2022.1
PyYAML==6.0
requests==2.27.1
requests-oauthlib==1.3.1
rsa==4.8
s3fs==2022.5.0
scipy==1.8.1
six==1.16.0
sortedcontainers==2.4.0
tqdm==4.64.0
treelib==1.6.1
typing_extensions==4.2.0
urllib3==1.26.9
vineyard==0.3.16
vineyard-io==0.4.2
websocket-client==1.3.2
wrapt==1.14.1
yarl==1.7.2

@sighingnow Thanks for the help, I really appreciate it!

@gillesmag You can try the latest version(0.14.0) of GraphScope by pip3 install -i https://pypi.org/simple/ graphscope==0.14.0 -U

@gillesmag You can try the latest version(0.14.0) of GraphScope by pip3 install -i https://pypi.org/simple/ graphscope==0.14.0 -U

@lidongze0629 Thanks for getting back to me! I will try the new version of GraphScope!


Cargo test  Error

🐛 Bug
I followed :
$ git clone https://github.com/libra/libra.git
$ cd libra
$ ./scripts/dev_setup.sh
$ source ~/.cargo/env
$ cargo build
$ cargo test
everything fine but the last step: cargo test,
I got this error:
Compiling storage-service v0.1.0 (/home/zzl/libra/storage/storage-service)
error[E0432]: unresolved import libradb::test_helper
--> storage/storage-service/src/storage_service_test.rs:12:14

To reproduce
Code snippet to reproduce
# Your code goes here
# Please make sure it does not require any external dependencies

Stack trace/error message
// Paste the output here

Expected Behavior

System information
Please complete the following information:

Additional context
Add any other context about the problem here.

Due to cargo's feature unification bug you'll need to run cargo xtest in order to run tests with no compile errors.


draft: teammate feature (very much wip)

Pull Request
Description

Related Issue

Type of Changes

Added

Changed

Fixed

Checklist

[ ] I have added commit messages that are descriptive and meaningful.
[ ] I have tested the changes locally.
[ ] I have reviewed the code changes.

Screenshots

Additional Notes

Closing after TS migration - opening #97 instead


(PUP-6290) Ignore, warn, or fail when evaluated resources are overridden

This commit changes the Puppet::Parser::Resource#set_parameter so that
it checks if the resource has already been evaluated. If that's the case,
then the behavior is controlled by the setting of Puppet[:strict]:
strict=off, the attempt silently sets the parameter although no
re-evaluation of the resource takes place. In essence, the new value is
ignored (same as before this commit).
strict=warning, same as strict=off, but the attempt is also logged as a
warning.
strict=error, compilation fails.

CLA signed by all contributors.


group layer scraping only supports immediate child feature layers

Scraping a group layer currently only works if the immediate child layers are feature layers. The children themselves may be group layers and so on. Following example has 3 sub-group layers:
http://gps.digimap.gg/arcgis/rest/services/JerseyUtilities/JerseyUtilities/MapServer/0
Enhancement should provide the ability to recursively scrape feature layers at any sub-group level, possibly writing them to dynamically created directories/sub-directories to mirror the group structure

fixed with dcf78b15c5 awesome recursiveness


"Git not configured" fatal error

So, I manage many repos on my machine, so of course I have Git set up with my e-mail and username.
And yet, upon activation, I get a "Git not configured" error from your plugin.
UPDATE:
It must failing to fetch my data from my system.

Please what OS

Sorry about that.
Running macOs Sierra (10.12.1) and Godot from master.

The problem is that i didn't test it on OSX cause i don't own a Mac or Hack but can you please run this command in your terminal and tell me what it prints
whereis -b git

I found the problem.
Just swap the line (at command_manager.gd::76):
return self.run_command(["-b", "git"], "whereis")[0].strip_edges();
with
return self.run_command(["git"], "whereis")[0].strip_edges();
OS X does not support the -b flag in whereis.

What a coincidence :D, I have already change from using whereis to which binary (for searching for git) on both linux and mac (I have already pushed the changes). Please test it to see if there is any issue.

You are free to close this issue if everything works fine.

I would, but this wasn't yet updated on the AssetLib D:
No matter, I downloaded the changed files and applied them. Works great! Thanks.


Fix JSON bool value

When you read JSON object with boolean field - its always false.

Sorry the FirebaseJson library update is in process and nearyly to finish. Almost APIs and functions are changes which makes the code that being pull request will be removed.


Array.back() says it should return null if the array is Empty. It does not.

Godot version:
Godot 3.2 Stable (non-mono)
OS/device including version:
MacOS Mojave
Issue description:
Array.back specifically states in the documentation:

Returns the last element of the array, or null if the array is empty.

However as of Godot 3.2, null is not returned from an empty array. Instead, the following error appears in the debugger log:
E 0:00:00.312   back: Can't take value from empty array.
  <C++ Error>   Condition "_p->array.size() == 0" is true. Returned: Variant()
  <C++ Source>  core/array.cpp:141 @ back()
  <Stack Trace> Node.gd:12 @ _ready()

Steps to reproduce:
var my_array = []

func _ready():
    assert(my_array.back() == null)

Minimal reproduction project:
Attached is an MRP. Just run the game and you'll see the error appear in the console.
Array Back MRP.zip

Sure, the error appears in the console but I think it is intentional. Array.back causes that error but it also returns null when called on an empty array.
Just run
func _ready() -> void:
	assert(non_empty.back() == 1)
	assert(empty.back() == null)
	print(empty.back())

It will print Null and the error in debugger console.

May not be a bug: see https://github.com/godotengine/godot/pull/7149#issuecomment-261665870.
In case you wanted to modify it instead of modifying the docs, I have prepared a commit and can issue a PR if necessary...

The documentation was updated accordingly, closing: https://github.com/godotengine/godot/blob/56838ca009ca7d20eb89e7b1c182beff1ce1190d/doc/classes/Array.xml#L149-L150


Removed condescending language from docs

Closes #389
As discussed in the issue, this PR attempts to remove as many instances of condescending or isolating language (ie. simple, easy, just, etc) as possible in the documentation.
Disclaimer: I may have stretched in some parts 😂 so feel free to revert. If even a fraction of these changes can be merged then it will be a huge step towards making the documentation more inclusive!

Thank you for the thoughtful review @luke-hill! I've updated based on your comments.

Thank you so much @carolstran - this is my absolute favorite PR ever! <3

Hi @carolstran,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber


problem when writing files to disk

what screen says:
Trying to log with saved cookie
Login successfull.
PixivDownloader2 version 20160613
https://github.com/Nandaka/PixivUtil2/releases
Donate at https://bit.ly/PixivUtilDonation

Download by member_id
Download by image_id
Download by tags
Download from list
Download from online user bookmark
Download from online image bookmark
Download from tags list
Download new illust from bookmark
Download by Title/Caption
Download by Tag and Member Id
Download Member Bookmark
Download by Group Id

d. Manage database
e. Export online bookmark
m. Export online user bookmark
r. Reload config.ini
p. Print config.ini
x. Exit
Input: 1
Member ids: 104247
Start Page (default=1):
End Page (default=0, 0 for no limit):
Processing Member Id: 104247
Reading /root/pixivutil2/config.ini ...
done.
Page  1
Member Url: http://www.pixiv.net/member_illust.php?id=104247&p=1
Member Name  : 無言
Member Avatar: http://i1.pixiv.net/img11/profile/gunhoguns/87063.jpg
Member Token : gunhoguns
Getting remote filesize...
Using Referer: http://www.pixiv.net/member_illust.php?id=104247&p=1
Start downloading... Using Referer: http://www.pixiv.net/member_illust.php?id=104247&p=1
Creating directory: /root/data/[104247] [無言]
Traceback (most recent call last):
File "PixivUtil2.py", line 126, in download_image
downloadedSize = PixivHelper.downloadImage(url, filename, res, file_size, overwrite)
File "/root/pixivutil2/PixivHelper.py", line 503, in downloadImage
os.makedirs(directory)
File "/usr/lib/python2.7/os.py", line 157, in makedirs
mkdir(name, mode)
OSError: [Errno 22] Invalid argument: '/root/data/[104247] [\xe7\x84\xa1\xe8\xa8\x80]'
Error at download_image(): (<type 'exceptions.OSError'>, OSError(22, 'Invalid argument'), <traceback object at 0x76192300>) at http://i1.pixiv.net/img11/profile/gunhoguns/87063.jpg (9000)
Retrying [1]...
1 2 3 4
Getting remote filesize...
Using Referer: http://www.pixiv.net/member_illust.php?id=104247&p=1
Start downloading... Using Referer: http://www.pixiv.net/member_illust.php?id=104247&p=1
Creating directory: /root/data/[104247] [無言]
Traceback (most recent call last):
File "PixivUtil2.py", line 126, in download_image
downloadedSize = PixivHelper.downloadImage(url, filename, res, file_size, overwrite)
File "/root/pixivutil2/PixivHelper.py", line 503, in downloadImage
os.makedirs(directory)
File "/usr/lib/python2.7/os.py", line 157, in makedirs
mkdir(name, mode)
OSError: [Errno 22] Invalid argument: '/root/data/[104247] [\xe7\x84\xa1\xe8\xa8\x80]'
Error at download_image(): (<type 'exceptions.OSError'>, OSError(22, 'Invalid argument'), <traceback object at 0x7617c490>) at http://i1.pixiv.net/img11/profile/gunhoguns/87063.jpg (9000)
Retrying [2]...
I'm pretty sure that config.ini was UTF-8, and I mount disk with -w on /root/data
And also I've tried the same config.ini on windows and it works well(except there's no /root/data)
So I change the rootdirectory back to '.' and it worked, the problem disappeared
I can't understand why, and one more thing, when I set rootdirectory to '/root/data', folder.jpg has been downloaded to my disk normally with error messages above. But no sub-folders like 'Creating directory: /root/data/[104247] [無言] ', it appears to be '/root/data/folder.jpg'.
When I change rootdirectory back to '.' and run python pixivutil2.py (I should have mentioned I usually runs on linux) , I got the right result '/root/pixivutil2/[104247] [無言]/folder.jpg'

P.S.
I uesd list.txt and there is
104247 /root/data

I'm not sure too, as I don't have linux.
what if you set the root dir from config.ini in rootdirectory = <path>

It's wired……and I found another problem
Let me tell what I have tried:
pixivutil2(.py) is in the folder  /root/pixivutil2
I edited config.ini and changed these:
uselist = True
rootdirectory = ./year/
and in list.txt
104247 /root/data
finally the image downloaded to (space for clear looking)
/root/pixivutil2/year/ (sub-folder what I set in config.ini) / filename.jpg
It seems to be that list.txt did't work though rootdirectory works perfectly.

Oh Sorry I got that!
the disk I used is in vfat format and caused system error. I changed to ext4/xfs which usually linux system use and the problem solved!!
Now only remains list.txt 's problem.


Save the sns messages in the PlatformEndpoint

This makes it easier to test the correct sns messages are sent.
For example in my test cases I can now do:
    from moto.sns.models import sns_backends
    messages = sns_backends['eu-west-1'].platform_endpoints.values()[0].messages

    # check number of messages
    assert len(messages) == 1
    assert 'Hello' in messages.values()[0]

thanks!

@mvantellingen Is it possible to read these messages when moto is in server mode?

Hi @tzusman, it is of course possible to use the receive_message to verify whether a message has been sent.
Directly accessing the backend to read the messages is not possible at the moment, though.
Slightly related feature request: https://github.com/spulec/moto/issues/2882

Hey @bblommers thanks for getting back to me.  I just wanted to confirm that you're talking about using SQS's receive_message to get these push notification payloads?  It doesn't look like the messages are being published anywhere, but rather just stored in the Dict

Ah, my bad @tzusman - I misread it as SQS. You're right, in that case, the SNS messages are not published anywhere.

I had to hack it (now it sends an http request whenever a message is sent to a PlatformEndpoint).  Obviously this is less than ideal.  @bblommers what do you think would be the least dirty way of pulling that messages data out in server mode?

@tzusman Probably a custom HTTP endpoint in the MotoServer to download the internal state, with filters to retrieve the state of a specific service.
That would be the most generic solution, and usable for any language/platform/service.