[dcmtk] re-enable support on arm64-osx

Describe the pull request

What does your PR fix?
Re-enables dcmtk build on arm64-osx

Which triplets are supported/not supported? Have you updated the CI baseline?
arm64-osx is a community triplet and not applicable to ci.baseline.txt from what I can tell.
arm64-windows and arm-uwp still fail in CI, so support has been excluded for those in the port file
arm[64]-{android,ios,linux,mingw} etc. are untested, I might be able to test crosscompilation for arm[64]-linux if that is necessary
Since  #23034 explicitly references arm mac, I think this should be ok.

Does your PR follow the maintainer guide?

Yes

@microsoft-github-policy-service agree

Thanks!

Since  #23034 explicitly references arm mac, I think this should be ok.

That says that it does not work on arm mac. However it also removed entries from ci.baseline.txt and maybe that was a drive-by. I'm interpreting that you made this PR as "it works for me" so I merged it.


fs/nfs/nfs_util.c: Fix compilation error

Summary
The build gets broken when both the NFS and DEBUG_FS_ERROR configurations enabled. This tiny change fixes the compilation error.

I push a change to fix the style failures.  There is still on that is not fixable:
fs/nfs/nfs_util.c:69:39: error: C++ style comment

which results from the line:
/* This logic just supports "//" sequences in the path name */

(took me a couple of tries to get everything straightened, but I think we are good).


remove "ignore=W391" in syntastic plugin config

After many test I come to the conclusion that it's not a a bug or an inconsistency in flake8, sorry for my old PR ( #87 )

@drgarcia1986 :+1:


If sample_shape is used, mark Random Variable as is_datamodel

The context of datamodel is used to expand the RandomVariable when required. Optionally, the user might find easier to use sample_shape instead of using the context datamodel.
Multiple tests should be done to test this behaviour. Moreover, at least one change must be done in order to make this working correctly: if sample_shape is used, the Random Variable should change the attribute is_datamodel=True.

This is discouraged, because we need to know which variables are in datamodel. As one variable, which is child of another whose sample_shape has been provided, is a datamodel too, we need to label it as datamodel=True.
In this way, it is easier for the user to use the datamodel context, and, if he wants to specify a datamodel size, the argument for the context can be provided (or not).


drivers: adc: Add support for the ESP32 board

This is the draft PR for the work on implementing an ADC driver for the ESP32. The related issue is #44908.

As a WIP, this implementation is not yet final in several aspects, including the calls to espressif library functions. In the final state, HAL calls will be favoured. The current objective is getting the driver to a functional state ASAP.

It looks like it has stopped updating, will anyone continue to maintain it?

There is still some pending changes in hal repository, which is ongoing.

@sylvioalves
i add the adc to driver, and compile, get the error "fatal error: esp_adc_cal.h: No such file or directory "
How can we add this file  to the include path.

Hello everyone.
I' designing a PCB based on ESP32 for a project. As a part of the project I have to report battery level every 2 minutes. According to basic implementation of ADC which is already done (or going to) which pin number shall I use?

For reference, the implementation of this was taken over by @marekmatej and has now been merged in PR https://github.com/zephyrproject-rtos/zephyr/pull/52751


BUG: Right-click to pan persists

When using the right mouse button + mouse movement to pan the scene, the expected behavior for me was for it to end when I let go of the right mouse button. However it stays in the 'drag mouse to pan' mode until you left click.
Its not a huge deal but it is rather jarring when you let go of the mouse and the whole scene keeps moving around.

Should be fixed now, a lot of the camera code has been changed


Is this intended to be used like one would use netsh?

As in netsh http add urlacl url=http://localhost:1234/wcfService user=Everyone?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 540a3f30-d598-0223-2e92-b1f50b2b793e
Version Independent ID: 1cfd217d-bf73-763c-40de-bb18777c66c1
Content: SocketPermission Class (System.Net)
Content Source: xml/System.Net/SocketPermission.xml
Product: dotnet-api
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks @StingyJack for your comment. @davidsh can you help with this question about SocketPermission?

As in netsh http add urlacl url=http://localhost:1234/wcfService user=Everyone?

No. SocketPermission refers to the use of .NET Framework APIs to grant various permissions to applications.
See: https://docs.microsoft.com/en-us/dotnet/framework/misc/code-access-security-basics
Most .NET Framework applications runs in "full-trust" and so already have all the permissions.  But scenarios such as web hosting can run in "partial-trust" and only have certain permissions.

Thanks @davidsh!


Environment names containing Japanese characters are not displayed correctly

Environment names containing Japanese characters are not displayed correctly
I have a PowerPlatform environment with display names set using Japanese.
Japanese is not displayed correctly in the VS Code tree view of environments and solutions.
When selecting an environment, the error message
Unexpected token in JSON at position xxx
is displayed.

Tracking internally as AB#3085166
The UI panel is based on the output of pac.exe running in the background with the command pac org list.   It looks like PAC correctly writes the data with UTF-8, and the extension is set to read the exe's stdout in UTF-8, but the symbol garbling is occurring between those steps due to the NodeJS spawn mechanics using the OS's default shell, which for Windows in the Command Prompt.
Tested on two Linux boxes (WSL and GH CodeSpaces), and the text appears correct there:

Presumably this should work on Mac as well, but I don't currently have my test Mac nearby to check.
On Windows, I get the garbled output in the UI:

Running the underlying pac org list works in PowerShell, but is garbled using the win Command Prompt:

Fixed in PAC v1.21.4+ and the VSCode Extension v1.1.14


UFACTORY Lite 6 version

Description
I made similar leader follower system for UFACTORY Lite 6. Please add this to GELLO repository.

Looks great! Thank you for your contribution!


Zooming does not work with perfect scrollbar

First of all, thank you for this great plugin!
Unfortunately it is not possible to zoom in/out using a trackpad or ctrl+scroll while hovering over an area that uses perfect scrollbar. Is there a way to fix this?
Edit:
QuickFix: If event.preventDefault is not called inside the mousewheelHandler function, it works as expected.
....
    updateGeometry(element);

    shouldPrevent = (shouldPrevent || shouldPreventDefault(deltaX, deltaY));
    if (shouldPrevent) {
      e.stopPropagation();
      //e.preventDefault();
    }
}

Edit 2: I'm using version 0.6.5 by the way (and did not update yet because I had to make some other adjustments)
Edit 3: Not calling preventDefault on the wheel event reenables the "back" gesture on MacBooks, which is super annoying...
Edit 4: I found a solution that works perfectly for my purposes so far.
// If deltaX is 0, the user probably wants to zoom in which case we should not call preventDefault
shouldPrevent = (shouldPrevent || shouldPreventDefault(deltaX, deltaY)) && (Math.abs(deltaX) > 0);
if (shouldPrevent) {
  e.stopPropagation();
  e.preventDefault();
}

Maybe there should be an option to allow the back gesture if element.scrollLeft is 0?

I'm really sorry for the late response.
This is very true as it cannot tell if a wheel event is triggered by just a normal scrolling or a pinch. I'm not sure if there is a JS way to tell them. Any idea?

The only fix I came up with so far is the "delta-check" (Edit 4). But suddenly it does not work anymore (after I updated to 0.6.10 I guess). Also, I can't get the gulp tasks to work properly anymore. They seem to be working but my changes aren't reflected in the output... If I find the time, I will look into it a little more next week.

While detecting a pinch gesture may be difficult, it should be easy to detect if the user holds the ctrl key during scrolling uing MouseEvent.ctrlKey, no? I am a Windows user, but ctrl+mouse wheel is used for zooming on Mac OSX, too, I think. This would at least cover zooming for mouse/keyboard usage.

Fixed by #709


Community Tools

Is your feature request related to a problem? Please describe.
By all measures woke is a successful project. It is in active use by multiple companies and individuals. According to the main repository page there are over 20 contributors. Also you have done a fantastic job of quickly responding to feature requests and pull requests. I know that I would like to find additional ways to help and I'm sure there are others that feel the same way. To that end, I'd like to suggest that it would be great to add some tools for enhancing collaboration for both contributors and users.
Describe the solution you'd like
Some examples of tools that could be helpful:

A collaboration tool such as Discord, IRC, Slack, Mattermost, etc

Bounce ideas off of other contributors, see if anyone is already working on a feature, etc
Place for users to post questions and get help, or collaborate on ways to implement woke at their companies or projects
Discuss ways to increase exposure of woke
Announcements

Mailing list (notification of new releases, etc)
Expanded getwoke.tech (roadmap, etc)

Describe alternatives you've considered
N/A
Additional context
N/A

I enabled GitHub Discussions which is a perfect fit for this in the immediate. If woke outgrows it, I'll be happy to consider alternatives. This project has had its fair share of trolls so I plan on being cautious about it and will use my own discretion in disabling it if I need to.
I'm also working on building an official documentation website because the README is starting to get too long
Regarding a mailing list, people should "Watch" this repo to automatically get notifications when new releases are published. You can even customize which events you get notified for. I would prefer not to have to manage a separate release notification workflow when there's already one built into GitHub.
The email looks like this:

Thanks Caitlin! This sounds perfect. Really I was looking for something less formal than a new Issue for each one of my crazy ideas :) and GitHub Discussions is perfect for that. I totally understand what you are saying about trolls, I've been put down and called names before just for putting in PRs on open source repos to fix non-inclusive language. Honestly more than a little disheartening. One of the reasons I'm so happy that this project exists. Thank you.


Update database-refresh.md

Since we have seen impact to customer's prod system due to multiple copies of refreshes running. adding an important warning in the document.

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


List contents of Janus Debian package during CI

It's helpful for refactoring the build process if we have a record of everything that's in the Debian package, similar to what we did in the TinyPilot build:
https://github.com/tiny-pilot/tinypilot/pull/1139

Automated comment from CodeApprove ➜
⏳ @jotaen4tinypilot please review this Pull Request


loss does not decrease in Google Colab and local computer. (TF.Keras 1.13 vs from TF.Keras 1.14 to TF.Keras 2.6)

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
1.13 vs 2.6
Custom Code
Yes
OS Platform and Distribution
Windows 10
Mobile device
No response
Python version
3.7.4
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.2.0 / 8.1.0
GPU model and memory
No response
Current Behaviour?
I asked this issue to tensorflow, but tensorflow told me to ask keras repo.
https://github.com/tensorflow/tensorflow/issues/56080
This is my full source code!
https://colab.research.google.com/drive/1tSE7t3GPa8r4x7F4sPgj8CqiYqtOrej5?usp=sharing
https://drive.google.com/drive/folders/17Nnl5FcrUWnRgzz4DM_fNAI3KhwqcK3r?usp=sharing
I studied with my data and tf-gpu 1.6 and keras in 2019.
At this time, training was done normally.

Although it is the same code as in the past,
training loss and validation loss are decreased
when training with TF 1.13  (working TF 1.6 ~ TF 1.13).

However, from TF 1.14 to TF 2.6,
both train loss and validation loss have increased.

When the model weight made with TF 1.6 was called from TF 2.6 (tried to TF 1.14, TF 1.15, TF 2.0 and TF 2.6),
it was called without any problems and the results were the same as those from the past.

So I can't understand why that happen.
I wonder what parts of TF 1.13 and TF 1.14 and above are different and affect training!!!!!!

Also, I tried updating the source code through tf_upgrade_v2,
but it was not solved at all.
https://www.tensorflow.org/guide/upgrade?hl=en
tf_upgrade_v2 --infile my_code.py --outfile my_code_upgraded.py

Relevant log output
decreased the loss when using TF 1.13

increased the loss when using TF 1.14 and TF 2.6

No response

@gowthamkpr Hello. How are you? Is there any problem with my code?

@HeewonChung92 Can you please create a colab notebook and attach it here..!! Thanks!

@gowthamkpr Here is my code!!! https://colab.research.google.com/drive/1tSE7t3GPa8r4x7F4sPgj8CqiYqtOrej5?usp=sharing
https://drive.google.com/drive/folders/17Nnl5FcrUWnRgzz4DM_fNAI3KhwqcK3r?usp=sharing

@HeewonChung92 Sorry for the inconvenience. Can you please install different versions of tensorflow and run the code with different versions and attach the gists here. Also can you please use the latest versions of tensorflow. Thanks!

@gowthamkpr  I attach the colab code here with two versions.
Code - Tensorflow version: 1.13.2
decreased the loss when using TF 1.13.2
https://colab.research.google.com/drive/1f-eUOLIDTESbWjw0WDmZjl-D65KwGT8H?usp=sharing
Code - Tensorflow version: 2.8 (latest version)
increased the loss when using TF 1.14 and TF 2.6
https://colab.research.google.com/drive/1uh9VMLrMcFJUAlCwDkbRBdiVclcLoKiL?usp=sharing

@HeewonChung92 Thank you! Will look into this

@HeewonChung92 Can you debug the model layer by layer and check where the issue is coming from. Thanks

@gowthamkpr
I think it will take some time because I have a lot of work to do. I will check and let you know which layer is the problem.

@HeewonChung92 Please let me know if you were able to debug it layer by layer as mentioned above. Thanks!


[Feature]: Add armour subtype category.

Describe the feature
As a user, I would like to split my gear in bag by its sub type category [wrists, chests, 2h, 1h, trinkets].
Describe the implementation
when i go into options to pick a category i would like to be able to select split by gear sub type only.

this is the biggest feature I'm looking for as well

I believe this is generally covered by 'Equipment Location'
More refined options are being developed


Implement Parameter Propagation

Tekton Pipelines resources are verbose mostly because of explicitly propagating Parameters. Implicit Parameters feature was added to reduce the verbosity. However, there are challenges caused by mutating specifications to support Implicit Parameters. This PR builds on this prior work by propagating Parameters without mutating specifications to improve usability of Tekton Pipelines. This addresses features proposed in TEP-0107.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

Parameters are propagated in embedded specifications without mutations.

Hmmm...weird that we need an ok-to-test here given @chitrangpatel was added to the org in https://github.com/tektoncd/community/pull/692
@afrittoli do you think our peribolos sync is broken?

/ok-to-test

thank you @chitrangpatel!
please add tests for the changes in this PR - here are the guidelines for tests in tekton pipelines: https://github.com/tektoncd/community/blob/main/standards.md#tests

Thanks @jerop! I added examples and unit tests.

Hmmm...weird that we need an ok-to-test here given @chitrangpatel was added to the org in tektoncd/community#692
@afrittoli do you think our peribolos sync is broken?

I don't see @chitrangpatel in the org - something went wrong with the CI job probably.
I sent an invite manually now.
We should add a nightly job to peribolos to make sure things stay in sync.

/retest

please add documentation as well
Yes, will do.

just to make sure this is not missed, are you planning to remove the existing implicit parameters in a follow up pr?
Hmm. I thought that currently there was no implicit parameters support in v1beta1. Are you referring to v1alpha1?

/retest

/retest

/retest

/retest

@jerop propagating parameters changes are now behind the alpha feature gate. Its ready for review again.

/retest

/retest

/test pull-tekton-pipeline-unit-tests

/test pull-tekton-pipeline-build-tests

/retest

/retest

/test pull-tekton-pipeline-integration-tests

@chitrangpatel please add some test cases with parameter of type array to apply_test.go

@jerop Thanks for suggesting this. I think I may have found an overlooked bug/missing feature. When I pass array, the replacement does not happen (ie. $(params.HELLO) is not replaced by the array values). Is that what is supposed to happen?
I tracked the replacement it down to these lines. Where if you see step.Script = substitution.ApplyReplacements(step.Script, stringReplacements) only applies stringReplacements, not arrayReplacements (seems missing?).
I can fix this in this PR if you think it should be a valid feature.

I think I figured it out. Apparently, arrays don't work with Script, just Args. If it needs to work with script,, it is captured in the issue. I updated my tests using args to test arrays.

@jerop test cases with parameter of type array to apply_test.go added.

/test tekton-pipeline-unit-tests

@tektoncd/core-maintainers please take a look 🙏🏾

/lgtm


Notification Slider

[x] Create slide in plant view
[ ] Boolean value turns notifications on/off
[ ] Plant array is populate from boolean values
[x] #31

Scrapping due to time.


TypeError: Cannot read property 'tagName' of null

I created React app by using npx create-react-app i then run npm run eject to add @svgr/webpack follow the docs i changed webpack.config.js file to
{
   test: [/\.bmp$/, /\.gif$/, /\.jpe?g$/, /\.png$/, /\.svg$/],
     use: [{
         loader: '@svgr/webpack',
           options: {
              limit: imageInlineSizeLimit,
              name: 'static/media/[name].[hash:8].[ext]',
             }
          },
     {
          loader: 'url-loader'
     }]
},

NotFoundPage component
import React from 'react';
import { ReactComponent as NotFound } from '../assets/images/404.svg';
/** @jsx jsx */ import { jsx, css } from '@emotion/core';

export default function PageNotFound() {
    return <div css={{
          width: '100vw',
          height: '100vh',
          overflow: 'auto',
          display: 'flex',
          justifyContent: 'center',
          alignItems: 'center',
     }}>
         <NotFound/>;
    </div>
}

It was working perfectly at the time. Day after I back run the project again and the error is shown in the command

./src/assets/images/404.svg (./node_modules/@svgr/webpack/lib?-svgo,+titleProp,+ref!./src/assets/images/404.svg)
TypeError: Cannot read property 'tagName' of null

Have anyone had encountered this problem? and how to fix it? Thanks in advance!

#362

Recording to #362 this issues has been fixed in v5. I have install the latest version yarn add @svgr/webpack@latest but it still shows the same error. Anybody have fixed it yet? and how to fix it? Thanks

I try both v5 and v4 and have the same issue. Any update on it?

Show please svg which breaks svgr

Show please svg which breaks svgr

I copied svg from undraw.co

Outdated issue, I am sorry but it looks like it does not affect enough people to be solved. Please takes time to fix it by opening a PR if you are affected.

Faced the same issue, resolved it by adding individual export entries in image directory like below.
/Icons
  success.svg
  error.svg
  info.svg

Actual Issue
It's been imported as direct svg file as ReactComponent like below.
import { ReactComponent as PaymentAggregation } from './Icons/success.svg';

Fix
Step 1: Added index.js to Icons directory.
/Icons
  index.js
  success.svg
  error.svg
  info.svg

Step 2: Exported as individual file in index.js
export { default as SuccessIcon } from './success.svg';
export { default as ErrorIcon } from './error.svg';
export { default as InfoIcon } from './info.svg';

Final Step 3: call them as component
import { SuccessIcon } from './Icons';

Faced the same issue, resolved it by adding individual export entries in image directory like below.
/Icons
  success.svg
  error.svg
  info.svg

Actual Issue
It's been imported as direct svg file as ReactComponent like below.
import { ReactComponent as PaymentAggregation } from './Icons/success.svg';

Fix
Step 1: Added index.js to Icons directory.
/Icons
  index.js
  success.svg
  error.svg
  info.svg

Step 2: Exported as individual file in index.js
export { default as SuccessIcon } from './success.svg';
export { default as ErrorIcon } from './error.svg';
export { default as InfoIcon } from './info.svg';

Final Step 3: call them as component
import { SuccessIcon } from './Icons';

I do have the same error when updating:
@svgr/webpack from '4.3.3' to '5.5.0' (due to react-scripts update from '3.4.1' to '4.0.3')
Which version of '@svgr/webpack' are you using please? And react-scripts as well if you use it?

still facing this issue

try this:
import { default as CloseSvg } from<EMAIL_ADDRESS>works for me

I had this same issue updating react-scripts from 3.4.1 to 4.0.3. I tried the import suggestions above but that solution didn't allow me to pass className attributes to the svg components as I could before.
After digging into my package-lock.json I found that storybook was using an older version of @svgr/webpack.
These are the steps I took to fix the issue:

Remove storybook from my project completely
Install latest version of @svgr/webpack
remove node_modules folder
npm install and npm start

I hope this is useful to someone!


Remove 300ms delay when selecting ion-inputs

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

When clicking between ion-inputs, there is a significant delay between selecting the input and the input becoming usable. Specifically, there is a 300ms delay.
Expected behavior:

Users can switch between input fields without the usability-killing lag.
Steps to reproduce:

Make an Ionic 2 Angular 2 app with ios 10.3.x (also saw this issue on iOS 11). Create a ion-form using ion-items and ion-inputs. Attempt to move between these input fields. Suffer the lag.
Related code:

insert short code snippets here

Other information:

Both FastClick and wkwebview plugins solved this, but had disastrous side effects. FastClick made context menus unusable and disabled button animations, while wkwebview killed CORS.
It would be nice if the 'tappable' flag on an ion-item actually made it tappable.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (/Users/connorodoherty/Projects/jetinsight-mobile-crew/node_modules)

    @ionic/cli-utils  : 1.14.0
    ionic (Ionic CLI) : 3.14.0

global packages:

    cordova (Cordova CLI) : 6.5.0

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : browser 4.1.0 ios 4.3.1
    Ionic Framework    : ionic-angular 3.6.0

System:

    ios-deploy : 1.9.1
    ios-sim    : 6.0.0
    Node       : v8.5.0
    npm        : 5.3.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b

Misc:

    backend : pro

Hello! Thank you for opening an issue with us!
Ionic handled and removed the 300ms tap delay quite a while ago. You can read more about it here: http://blog.ionic.io/hybrid-apps-and-the-curse-of-the-300ms-delay/
And here is a tiny app that demonstrates that there is no delay: https://github.com/kensodemann/test-input
Thank you for using Ionic

Hi Ken,
This works on buttons, but NOT on ion-inputs. Fastclick and wkwebview both solved this issue, but have unusable side effects. This makes me think it is the 300ms delay.
On top of that, the 300ms delay shows when profiling the app. Again, this happens on ion-input, not on buttons.
Why is the delay still being fired on inputs, but not on buttons?

My sample app uses four ion-input items and has no delay so far as I can tell.
It also uses WKWebView, however, as that is the way forward and is now our default configuration.
What issues are you having with WKWebView?

Ahhh, there it is. Yeah, the UI worked great with WKWebView!
However, this broke CORS and XHR. So I was looking for an alternative to WKWebView and FastClick. Am I using the correct WebView: https://github.com/ionic-team/cordova-plugin-ionic-webview ?
Without WkWebVIew, your example still has the delay on iOS :(

Yes, that is the correct webview.
For the CORS issues, be sure to see here: http://ionicframework.com/docs/wkwebview/#cors

Is there a way to solve this delay issue without additional plugins? Implementing WKWebView would require a fairly big refactor, and I would prefer to not keep layering plugin upon plugin to get things working.

Not that I know of. I do know that there are several bugs with UIWebView that Apple is not likely to fix. I believe most of those revolve around scrolling related issues.
You may want to try asking around on our forum or on our slack channel.

If you stick with UIWebView, you may want to have a look at this to get around some of those other issues with UIWebView (mostly iOS11 related): https://github.com/ionic-team/ionic-site/issues/1286


Cleaned the main README a little

Added a tag line and quick links to make it more accessible when someone first visited the repo

Working on the doc table of content. will be on a PR in a little, Please anyone can propose changes aswell!


Check all links in docs and make them more accessible

Guidelines for links are as follows:

We should comply with https://vizro.readthedocs.io/en/stable/pages/development/documentation-style-guide/#language
Links should always work.

Task (1) Fix all links
Before we have perfection, we need to run through all the docs pages and fix issues like this one https://github.com/mckinsey/vizro/pull/422#discussion_r1566440210 where they arise.
Task (2) Set up style checking for future content
One way to enforce this ongoing would be to use Vale. I've asked how to do this:
https://github.com/errata-ai/vale/discussions/807
Task (3) Add external link checking (if not already running) to CI.
We already have this for internal links in that we build with --strict but need to have something check links to Dash etc as Kedro does.
This ticket doesn't need technical writing skills nor does it need Vale knowledge. Good first issue for a new contributor!

Hi @kaestro That would be fantastic, thank you for offering a contribution. Here are a few answers:

Yes, it's the markdown under vizro-core/pages/ and likewise the vizro-ai/pages docs, although they are a much smaller set. It would be wonderful if you could run through those pages and look at the descriptive text for links so they read well and are useful as per the style guide: https://vizro.readthedocs.io/en/stable/pages/development/documentation-style-guide/#links

To answer your question, the internal links are all OK because we use a --strict flag on our build tool and detect them at build time. So there's nothing to check with those.

Task 3 is to make sure that all links out to other docs (absolute links rather than relative links within the docs) are working. It's annoying when they break but we should catch them as part of our CI and fix them. Kedro use Sphinx to build their docs and use the linkcheck flag, but we use a different docs tool, so need to investigate if MkDocs have a similar option. I think they probably do, and if so, we just need to configure it.

If you prefer to focus just on Task 1, that would be wonderful, and the other two tasks can wait, or you can tackle all. Up to you! It's wonderful that you've offered to contribute.

@stichbury
Thank you for all the replies and welcome. It helped a lot
I'll try to catch up on the Task 1 first.
If you don't mind, for it's my first time trying to contribute on open-source, I might take some time to start on working itself. It's because I've only used github as contributor only, although the guide page is pretty much helpful. Also I'm not yet experienced with hatch.
Would it be okay for me to take some time? If it's okay, I want to start working on it from today

Hi @kaestro Welcome to the project. Please take as long as you like to work on this. It's late here in the UK but I'll write you some basic instructions tomorrow to use Hatch and docs.

@stichbury
sorry for the late contact. It's 6:45 am in Korea right now.
Thank you for the support, and have a good night!

sorry for the late contact. It's 6:45 am in Korea right now.
No problem at all! We are used to working asynchronously.

My advice for working on a docs PR is to fork the repo, pip install vizro and install hatch with brew or pipx (as our docs describe).
Before you make any changes, make sure you can build the docs. Navigate to the vizro-core folder of the code, as that's the package you'll mostly work on. In your terminal: hatch -v env create which should take a few minutes.
Then try hatch run docs:serve and this should build the docs and serve them (copy the URL and paste it into your browser to see them running).

Any problems at this stage, please let us know!
Then you can modify the .md files to make any changes and save them. While the docs:serve is running, they docs will automatically rebuild and update. You'll need to keep an eye out for any warnings/errors though, as we build --strict so any change that's considered a problem will stop the server updating until you fix it and save that markdown again.
Good luck, and let us know how you get on.

@stichbury
Thank you for all the supports. This project's CI is absolutely amazing, I'm really astonished.
Do you want me to request pr after I feel like finished the task 1, or do you want me to request pr step by step? I wonder if there's some style suggested.
If there's none, I prefer the second

Great news! We are really pleased you've found it easy to get up and running 👯
I think it would make sense, as it's your first time, to request a PR review after task 1, just so you can be sure of the end-to-end process. It's all very straightforward for docs but you'll need to run hatch run lint on your changes to make sure you've not introduced any issues that the style checker Vale objects to. Let's get you through the entire cycle once, and then future tasks (should you choose to accept them) you can be more self-contained.
Thanks again!

It's me who's really thankful of.
Before I get started, I've found some questions hope I'm not bothering you too much to answer.
Right now, I'm reading Explore vizro page and having confusions on how to apply the documentation rule
the second and third part of documentation says that

don't repeat the internal links => which is not followed for api internal links are duplicated a lot in this page
consider how they will navigate from where they land in the API documentation back to the narrative content. => which is mostly not followed if I'm not losing it.

So, Q1 should I be removing the duplicates on this page? Or do you want me to leave the duplicates for APIs like this page.
Q2 Do you want me to add some links for those API links which can help users back to where their narrative content?
Q3 Do you have any commit conventions?

So, Q1 should I be removing the duplicates on this page? Or do you want me to leave the duplicates for APIs like this page.

Good spot! But please leave that for now in favour of working on the task for this issue, which is to make the link text accessible and descriptive. Reason being that I am yet to edit some pages that will make revisions such as the ones you suggest here.

Q2 Do you want me to add some links for those API links which can help users back to where their narrative content?

Likewise, you can leave those for now, but thank you for offering.

Q3 Do you have any commit conventions?

I wouldn't worry too much about individual commits. I tend to group them together and commit small chunks for a particular page, feature or task, rather than all at once or random collection. So for example, I might commit changes to the nav of the docs in one and typo fixes in another, even though it's all the same PR to add a new page. Don't sweat it too much!

@stichbury
Questions. Is it ok for me to remove some duplicate links that I think it would make better readability?
for example, what I'm trying to change is from this

into this

Also, I've made some changes on explore vizro page  and want to check whether this is what this issue wanted, and I'm following the style guide correctly.
72130f5751e1a9334fccc41f24decf1f48449016
Once again, thank you for all your supports and have a nice week

@stichbury
I think I'm about 50~60% done for vizro core and wonder if I might send a pull request to get reviews on whether I'm doing it properly. May I?

Hi @kaestro Please do make a PR when you are ready! I'm out of office until Wednesday 8th May but one of the team can help if you need it, and may be able to offer you a review, but I will otherwise pick up on my return.

@stichbury should this ticket still remain open? At a glance, Task (3) definitely done now; Task (2) sounds like is not feasible; Task (1) was handled in #453 but maybe not fully?
If there's still some work to do but it's just a subset of the original ticket, please could you close this and open a new one for it so we can make it easier for any hacktoberfest participants to pick it up without needing to understand what's left to be done? 🙏

@antonymilne I'll close this -- as you summarised, it's done for (3) and (2) was something the vale team couldn't particularly help with. Best to just keep an eye on links as we write new copy and review existing pages, and encourage the standards as we go.


Pin tag 210

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@zhangchj1990 Looks mistakenly open. Mind closing this please?

Close this @zhangchj1990


Notification Popup in VSC after workflow run is complete

When a workflow run is finished, it would be nice to get a popup notification inside VSCode. Therefore I would immediately be informed about the result of my CI/CD flow. Sometimes I tend to oversee a failed pipeline because I do not always take the extra effort to check the result in the browser.
Would be super cool! 🙏

We've discussed this but unfortunately the lift isn't worth the effort for this feature right now.


Add info about primary keys in the pg_catalog.pg_constraint view

Is your feature request related to a problem? Please describe.
In the recent DBeaver version, we added support for the RisingWave connector.
In the database navigator tree, we can see table columns and indexes but not the primary keys.

Because pg_catalog.pg_constraint view is empty. And we use it for primary keys metadata reading.
For now, I can only find my key in the DDL statement. I didn't find anything like the SHOW KEYS command in the documentation.
Describe the solution you'd like
It will be helpful to have primary keys info in pg_catalog.pg_constraint view.
Describe alternatives you've considered
The SHOW PRIMARY KEYS command. But it is usually not so convenient to use it for the whole schema.
Additional context
My current database version: PostgreSQL 9.5-RisingWave-1.6.0

For now, I can only find my key in the DDL statement. I didn't find anything like the SHOW KEYS command in the documentation.

May use following commands
dev=> DESCRIBE newtable;
       Name        |   Type   | Is Hidden | Description
-------------------+----------+-----------+-------------
 column1           | bigint   | false     |
 primary key       | column1  |           |
 distribution key  | column1  |           |
 table description | newtable |           |
(4 rows)

dev=> select * from rw_catalog.rw_columns where relation_id = 17001;
 relation_id |  name   | position | is_hidden | is_primary_key | is_distribution_key | data_type | type_oid | type_len | udt_type
-------------+---------+----------+-----------+----------------+---------------------+-----------+----------+----------+----------
       17001 | column1 |        1 | f         | t              | t                   | bigint    |       20 |        8 | int8
(1 row)


clean up existing Product training tooltips

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53086
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Sign up with new Account (say Account A). Completed Onboarding flow
2.( On desktop, resize screen to mobile size) verify Tooltip on Concierge is displayed
3.Create a workpace, go back and open FAB menu, Verify that a tooltip on QAB is visibile
Go to search screen > Filters > Add and save a filter verify tooltip is shown on saved search threedot. (this is visible on desktop screen size only)
As another user create a workspace, invite this user A to the workspace
As user A go the invited workspace chat verify tooltip on "+" is shown.

Offline tests

QA Steps

Same as test steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/6428319a-8b01-4ee3-8b1a-2d70c1a05444

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/a4f1c1e0-01f7-475a-97ef-70cf2cd320fa

iOS: mWeb Safari

https://github.com/user-attachments/assets/58aea308-9bb6-419f-9c3f-3d3809fd1434

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/4fc5db7e-8abf-4ace-ad8d-5c736eefa3ad

MacOS: Desktop
https://github.com/user-attachments/assets/f77d60b9-60fd-44c0-ac08-5589e3f935dc

This PR is failing because of issue  #54127


Grammar issue

There is a problem with this PR, it contains 1047 commits. Please submit a proper PR.


Get Marker position on dragend

Hi. Just got a dragend-event to work but I cannot figure out how to get the new position of my marker.
I'm doing onDragend={this.onMarkerPositionChanged} and
onMarkerPositionChanged(e) {
}
But how do I get the new position?

Nevermind. Just found the solution... e.latLng.lat()

:+1:

never mind figured it out:)

@graig12 Maybe share your full solution for the next commenter to come?


Document HoistField concept of delegateProps

Explain function of delegateProps, particularly which attributes should be listed / how those determinations are made.

Added some minor documentation here.  Think this is really an implementation concept for control writers only, and am not sure how much I want to push the pattern, so left it minimal.


📊 Update World Bank income groups

Main issue https://github.com/owid/owid-issues/issues/1625
When updating income groups, I am not sure if I should replace in every step that is using them? ~I thought it was the right thing to do, but let me know if it's better to not do that.~ Now I am not doing that, because some steps fail because when I change it.

Thank you, @pabloarosado!


encoded: Unalias interfaces

Per reasoning in #928, this redeclares all three interfaces in the
encoded package and adds bi-directional compile-time checks to verify
that the interfaces do not fall out-of-sync.
The only reason I could find for the interfaces to be aliased was
client.Client's re-use of an internal.Client.
package client

type Client interface {
  ...
  QueryWorkflow(...) (encoded.Value, error)
}

func NewClient(...) Client {
  return internal.NewClient(...)
}

Where,
package internal

type Client interface {
  ...
  QueryWorkflow(...) (internal.Value, error)
}

This mismatch in QueryWorkflow's return value makes internal.Client
not match client.Client.
To resolve this, we introduce a clientAdapter which adapts an
internal.Client into a client.Client. It does so by embedding
internal.Client and implementing the compliant version of
QueryWorkflow.
Resolves #928

@vitarb This avoid the mocking aliased type issues we ran into during build

CI appears to be misconfigured. The other jobs haven't fired.


Add support for node-gyp-build

See https://www.npmjs.com/package/node-gyp-build.

@guybedford Looks like node-gyp-build is used here: https://github.com/zeit/node-file-trace/blob/d7410632a5aadc1c461b59d39ce761dfbb95cf48/src/analyze.js#L99-L101
Anything else need to be implemented to support node-gyp-build or can we close this?

Yes this was added with the Node.js 12 CI fixes.


Small fixes and features

Fix Capsule inertia
Add CombinedShapes shape
Add function for merging bodies connected by fixed joints

Codecov Report

Merging #65 (eed5f81) into main (0ff6c2d) will decrease coverage by 39.74%.
The diff coverage is 33.03%.

@@             Coverage Diff             @@
##             main      #65       +/-   ##
===========================================
- Coverage   87.71%   47.97%   -39.75%
===========================================
  Files          94       94
  Lines        5154     5211       +57
===========================================
- Hits         4521     2500     -2021
- Misses        633     2711     +2078

Impacted Files
Coverage Δ

src/gradients/state.jl
0.00% <0.00%> (-89.77%)
:arrow_down:

src/joints/impulses.jl
50.00% <ø> (-50.00%)
:arrow_down:

src/mechanism/methods.jl
20.33% <0.00%> (-79.67%)
:arrow_down:

src/mechanism/set.jl
52.85% <0.00%> (-9.86%)
:arrow_down:

src/orientation/rotate.jl
53.33% <0.00%> (-8.21%)
:arrow_down:

src/visuals/visualizer.jl
22.75% <87.50%> (-32.98%)
:arrow_down:

src/bodies/shapes.jl
63.00% <96.66%> (-23.14%)
:arrow_down:

src/mechanism/urdf.jl
92.93% <100.00%> (ø)

src/solver/options.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/contacts/linear.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Terraform - global storage bucket name

A small PR to ensure that the storage bucket name for the terraform config is always unique

There's also a place in main.tf where it's referenced!

Good catch! This is annoying though as I cannot put a variable in there (not allowed) so it might mean editing this file too, which I wanted to avoid.
I'll do a bit more research to see if it's possible to edit the storage bucket name into one single place.

'm creating a script to do all this file editing...


Update isArray type declaration for T | T[]

Fix under pattern.
const a: int | int[] = [0]

if (Array.isArray(a)) {
  const b = a; // it is int[] | unknown[]. But I expect int[]
}

Type

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description

Now declaration make T[] | unknown[] from T | T[].
But fixed version make just T[] | T[] 🎉
Related

Related Issue #
Closes #

it breaks test, also unsure the type would be correct, what about Array<A> | Array<Array<A>>?

it breaks test, also unsure the type would be correct, what about Array<A> | Array<Array<A>>?

You’re absolutely right—when handling something like Array<A> | Array<Array<A>>, it would indeed resolve to Array<A>, which I hadn’t considered before. Thank you for pointing that out.
I also noticed the test failures, and while I’m not entirely sure of the cause, it’s clear that this approach has introduced more unintended side effects than I expected.
Would it be alright if I withdrew this pull request and instead re-framed it as an issue to gather more information and explore potential solutions? I feel that might be a more productive way forward without causing additional disruptions.
Thank you again for your time and valuable feedback—I really appreciate it!

it breaks test, also unsure the type would be correct, what about Array<A> | Array<Array<A>>?

You’re absolutely right—when handling something like Array<A> | Array<Array<A>>, it would indeed resolve to Array<A>, which I hadn’t considered before. Thank you for pointing that out.
I also noticed the test failures, and while I’m not entirely sure of the cause, it’s clear that this approach has introduced more unintended side effects than I expected.
Would it be alright if I withdrew this pull request and instead re-framed it as an issue to gather more information and explore potential solutions? I feel that might be a more productive way forward without causing additional disruptions.
Thank you again for your time and valuable feedback—I really appreciate it!

as you prefer, I don't have much insight and think the current version is ok


Filter out empty lines in CmdPair.toJsCmd

This PR filters out all empty lines in CmdPair.toJsCmd.  The CmdPair case class is what is used when combining JsCmds with &.  The extra empty lines are particularly noticeable when we produce the page-specific JS.  In a simple test page, I observed that we produced a 155-line JS file with only 4 non-empty lines.  While this will be slightly more performant, the biggest gains IMO are when we need to examine any JS produced while developing.
Per this ML thread, we decided that rather than write a lot of code for only the page-specific JS case, we would always toss out empty lines in this PR.

You'll have to update some of the HtmlNormalizer specs that were assuming the newlines would still be there, but this is lookin' good.

Nailed it. :+1: looks good to me!

:+1: :100:

This is something that has long annoyed me. Glad to see it fixed!


[material-ui][Select] Fix to show notched outline when displayEmpty

[x] I have followed (at least) the PR section of the contributing guide.

Fixes #27533 specifically https://github.com/mui/material-ui/issues/27533#issuecomment-960559489 and https://github.com/mui/material-ui/issues/27533#issuecomment-1910674201.
The outlined input should have a notch when displaying an empty value using the displayEmpty prop, even if the select isn't focused.
Before: https://codesandbox.io/p/sandbox/material-ui-outlined-select-label-is-not-rendering-properly-forked-8q5kwv?file=%2Fsrc%2FApp.js%3A25%2C18
After: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-nl2kt4?file=%2Fsrc%2FApp.tsx%3A52%2C25

Thanks for the PR! The sandboxes you linked seem to be missing. Could you take a look?

Thanks for the PR! The sandboxes you linked seem to be missing. Could you take a look?

Somehow it was set as private. I changed it to public now. Are you able to see it now? Looks like sandboxes will be private in future.

Yes, it's OK now, thanks!

Is the difference in margins related to your changes or are there different styles in these sandboxes?

Not related to my changes. The CodeSandboxes had different styles. The "After" one had CssBaseline. I updated the link for the "After" CodeSandbox. You can check again.

However, the before/after sandboxes still differ. Ideally, they should use the same sources and only reference different packages.

Agreed. I've kept them the same now and referenced different packages. I updated the links in the description.


Fix the scope of exceptions dict, fix #67

The exceptions dict is defined across events so that other recurring
events on the same day without EXDATEs are also excluded.

@chrko also already solved by: https://github.com/jazzband/icalevents/pull/97
Can you maybe review the changes from #97 :heart:


Add way to mute self in Discord

Ways to toggle mute in Discord:

[ ] In Discord
[ ] In Game

How do you plan to keep track of which minecraft player is which discord user?


There is any way to disable js wrapper at controller level?

Hi, I need to disable the js inclusion for some specific actions. There is any way I could achieve this?
Thanks

@waltjones could you take a look at this?

@ngelx, There is an env key rollbar-gem uses internally to ensure the JS is never injected twice to the same response. You can put this in your controller before render, and it will skip injecting the JS for that request.
request.env['rollbar.js_is_injected'] = true

However, I should not be recommending this. It's undocumented and should be treated as subject to change. Still, it's there and that's how it works.
Maybe it would make sense to add a documented, reliable flag. I'll reply here with any update on that.

@waltjones thanks! adding a documented interface for disabling this would be amazing. In the mean time, I've abstracted like:
class ApplicationController < ActionController::Base
...
  def do_not_injet_rollbar_js
    request.env['rollbar.js_is_injected'] = true
  end
...
end

And then, used in controller like:
before_action :do_not_injet_rollbar_js, only: :some_action

Mark as enhancement, to add a documented request.env['rollbar.skip_js_injection'] or similarly named env flag.

Thank you very much @waltjones and @ngelx!!


Anerdw: Watch (?-i:^Peter Austin$)

Anerdw requests the watch of the watch_keyword (?-i:^Peter Austin$). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:^Peter Austin$) has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


1.17 version of immersive portals gives me an infinite loading screen

Only the latest version is being supported. If you are using an outdated version, upgrade to the latest version.
If you find an issue, check whether this issue happens with only this mod. If not, check which mod it's incompatible with. And include that mod's link in the issue.
The Forge version is not being supported. If you find an issue of the Forge version, check whether the same issue exists for the Fabric version. Forge-version-specific issues belong to  https://github.com/qouteall/ImmersivePortalsModForForge/issues
The red MOJANG screen will load and then go instantly back to loading. It does this infinitely.

Post the log, it's gameDirectory/logs/latest.log

Are you using Mac?

Are you using Mac?

No I'm on Windows.

latest.log

Does this version work? https://github.com/qouteall/ImmersivePortalsMod/releases/tag/v0.04-1.17

Does this version work? https://github.com/qouteall/ImmersivePortalsMod/releases/tag/v0.04-1.17

Yes. Thank you.


[SPARK-16406][SQL] Improve performance of LogicalPlan.resolve

LogicalPlan.resolve(...) uses linear searches to find an attribute matching a name. This is fine in normal cases, but gets problematic when you try to resolve a large number of columns on a plan with a large number of attributes.
This PR adds an indexing structure to resolve(...) in order to find potential matches quicker. This PR improves the reference resolution time for the following code by 4x (11.8s -> 2.4s):
val n = 4000
val values = (1 to n).map(_.toString).mkString(", ")
val columns = (1 to n).map("column" + _).mkString(", ")
val query =
  s"""
     |SELECT $columns
     |FROM VALUES ($values) T($columns)
     |WHERE 1=2 AND 1 IN ($columns)
     |GROUP BY $columns
     |ORDER BY $columns
     |""".stripMargin

spark.time(sql(query))

Existing tests.
Author: Herman van Hovell<EMAIL_ADDRESS>Closes #14083 from hvanhovell/SPARK-16406.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

JMWG

jttp

retest this please

JMWG

Saw merge directive 'JMWG'. CSD Jenkins auto merging


Is there a problem with products route?

Hi!
Is there a problem with products route?
I have tested : orders, customers, coupons , products/categories and all of them have a responses.
But when i try return Woocommerce::get('products'); terminate the  connection and i am getting a
No data received
ERR_EMPTY_RESPONSE
Thanks
Very nice job

So for debugging! I am getting the following error :
Whoops, looks like something went wrong.
1/1 HttpClientException in HttpClient.php line 303: Invalid JSON returned
in HttpClient.php line 303
at HttpClient->lookForErrors(null) in HttpClient.php line 345
at HttpClient->processResponse() in HttpClient.php line 381
at HttpClient->request('products/1330', 'GET', array(), array()) in Client.php line 82
at Client->get('products/1330', array()) in WoocommerceClient.php line 59
at WoocommerceClient->get('products/1330') in Facade.php line 218
at Facade::__callStatic('get', array('products/1330')) in testController.php line 19
at testController->index()
at call_user_func_array(array(object(testController), 'index'), array()) in Controller.php line 76
at Controller->callAction('index', array()) in ControllerDispatcher.php line 146
at ControllerDispatcher->call(object(testController), object(Route), 'index') in ControllerDispatcher.php line 94
at ControllerDispatcher->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 52
at Pipeline->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in ControllerDispatcher.php line 96
at ControllerDispatcher->callWithinStack(object(testController), object(Route), object(Request), 'index') in ControllerDispatcher.php line 54
at ControllerDispatcher->dispatch(object(Route), object(Request), 'App\Http\Controllers\testController', 'index') in Route.php line 174
at Route->runController(object(Request)) in Route.php line 140
at Route->run(object(Request)) in Router.php line 703
at Router->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 52
at Pipeline->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Router.php line 705
at Router->runRouteWithinStack(object(Route), object(Request)) in Router.php line 678
at Router->dispatchToRoute(object(Request)) in Router.php line 654
at Router->dispatch(object(Request)) in Kernel.php line 246
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 52
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in CheckForMaintenanceMode.php line 44
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
at call_user_func_array(array(object(CheckForMaintenanceMode), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 32
at Pipeline->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Kernel.php line 132
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 99
at Kernel->handle(object(Request)) in index.php line 53

I'm constantly working with the products resource and it's working fine.
Are you sure the product with the id 1330 exists ?
Have you tried it with a different id ? Maybe something in the product data screws up the JSON response.

Yes! You are semi-right! :)
I create a new product! I tried to call the product and i get back Invalid JSON returned.
I change the product title from Greel Language to English (latin characters) and i tried to call the product!
The product returned fine!
So the problem maybe is in the non-latin characters.

If i change the automatic\woocommerce\HttpClient\HttpClient.php -> line 343 ,
from   ->    $parsedResponse = $this->decodeResponseBody($this->response->getBody());
to ->  $parsedResponse = $this->response->getBody();
i take back a result.

So probable the problem is in the decodeResponseBody function and greek characters

I have no problem with getting products from the api having german umlauts (ä, ö, ü) in the title.
Also I have no problems with a title like "test product ä ö ü βήτα".
Please check your server and database configuration I everything is configured to work with utf-8.
Additionally try a direct call to the api on the console with curl or wget

Everything on my server is configured to work with utf-8.
the direct call to the api with curl working fine!
Thanks
You can see the result
{"products":[{"title":"\u0394\u03bf\u03ba\u03b9\u03bc\u03b1\u03c3\u03c4\u03b9\u03ba\u03cc \u03c0\u03c1\u03bf\u03ca\u03cc\u03bd","id":1336,"created_at":"2016-01-24T17:48:08Z","updated_at":"2016-01-24T17:48:52Z","type":"simple","status":"publish","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/lets-test-a-product/","sku":"111","price":"11","regular_price":"11","sale_price":null,"price_html":"£11.00","taxable":false,"tax_status":"taxable","tax_class":"","managing_stock":false,"stock_quantity":null,"in_stock":true,"backorders_allowed":false,"backordered":false,"sold_individually":false,"purchaseable":true,"featured":false,"visible":true,"catalog_visibility":"visible","on_sale":false,"product_url":"","button_text":"","weight":null,"dimensions":{"length":"","width":"","height":"","unit":"cm"},"shipping_required":true,"shipping_taxable":true,"shipping_class":"","shipping_class_id":null,"description":"test product description
\n","short_description":"dddd
\n","reviews_allowed":true,"average_rating":"0.00","rating_count":0,"related_ids":[],"upsell_ids":[],"cross_sell_ids":[],"parent_id":0,"categories":["testcat"],"tags":[],"images":[{"id":0,"created_at":"2016-01-24T18:13:43Z","updated_at":"2016-01-24T18:13:43Z","src":"https://aldr.do.gr/wp-content/plugins/woocommerce/assets/images/placeholder.png","title":"Placeholder","alt":"Placeholder","position":0}],"featured_src":"","attributes":[],"downloads":[],"download_limit":0,"download_expiry":0,"download_type":"","purchase_note":"","total_sales":0,"variations":[],"parent":[],"grouped_products":[],"menu_order":0},{"title":"Updated title","id":1330,"created_at":"2016-01-18T20:10:24Z","updated_at":"2016-01-24T17:29:03Z","type":"variable","status":"publish","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/test2/","sku":"","price":null,"regular_price":"","sale_price":null,"price_html":"","taxable":false,"tax_status":"taxable","tax_class":"","managing_stock":false,"stock_quantity":null,"in_stock":true,"backorders_allowed":false,"backordered":false,"sold_individually":false,"purchaseable":true,"featured":false,"visible":true,"catalog_visibility":"visible","on_sale":false,"product_url":"","button_text":"","weight":null,"dimensions":{"length":"","width":"","height":"","unit":"cm"},"shipping_required":true,"shipping_taxable":true,"shipping_class":"","shipping_class_id":null,"description":"","short_description":"","reviews_allowed":true,"average_rating":"0.00","rating_count":0,"related_ids":[],"upsell_ids":[],"cross_sell_ids":[],"parent_id":0,"categories":["\u0394\u03bf\u03ba\u03b9\u03bc\u03b1\u03c3\u03c4\u03b9\u03ba\u03ae \u03ba\u03b1\u03c4\u03b7\u03b3\u03bf\u03c1\u03af\u03b1"],"tags":[],"images":[{"id":0,"created_at":"2016-01-24T18:13:43Z","updated_at":"2016-01-24T18:13:43Z","src":"https://aldr.do.gr/wp-content/plugins/woocommerce/assets/images/placeholder.png","title":"Placeholder","alt":"Placeholder","position":0}],"featured_src":"","attributes":[{"name":"\u03a7\u03c1\u03ce\u03bc\u03b16","slug":"colore","position":0,"visible":true,"variation":true,"options":["120gr","2","7"]}],"downloads":[],"download_limit":0,"download_expiry":0,"download_type":"","purchase_note":"","total_sales":0,"variations":[{"id":1331,"created_at":"2016-01-18T20:10:24Z","updated_at":"2016-01-24T17:29:03Z","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/test2/?attribute_pa_colore=2-3","sku":"","price":"","regular_price":"","sale_price":null,"taxable":false,"tax_status":"taxable","tax_class":"","managing_stock":false,"stock_quantity":null,"in_stock":true,"backordered":false,"purchaseable":false,"visible":false,"on_sale":false,"weight":null,"dimensions":{"length":"","width":"","height":"","unit":"cm"},"shipping_class":"","shipping_class_id":null,"image":[{"id":0,"created_at":"2016-01-24T18:13:43Z","updated_at":"2016-01-24T18:13:43Z","src":"https://aldr.do.gr/wp-content/plugins/woocommerce/assets/images/placeholder.png","title":"Placeholder","alt":"Placeholder","position":0}],"attributes":[{"name":"\u03a7\u03c1\u03ce\u03bc\u03b16","slug":"colore","option":"2-3"}],"downloads":[],"download_limit":0,"download_expiry":0}],"parent":[],"grouped_products":[],"menu_order":0},{"title":"test","id":1327,"created_at":"2016-01-18T17:38:33Z","updated_at":"2016-01-18T20:22:17Z","type":"variable","status":"publish","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/test/","sku":"","price":"111","regular_price":"","sale_price":null,"price_html":"£111.00","taxable":false,"tax_status":"taxable","tax_class":"","managing_stock":false,"stock_quantity":null,"in_stock":true,"backorders_allowed":false,"backordered":false,"sold_individually":false,"purchaseable":true,"featured":false,"visible":true,"catalog_visibility":"visible","on_sale":false,"product_url":"","button_text":"","weight":null,"dimensions":{"length":"","width":"","height":"","unit":"cm"},"shipping_required":true,"shipping_taxable":true,"shipping_class":"","shipping_class_id":null,"description":"","short_description":"","reviews_allowed":true,"average_rating":"0.00","rating_count":0,"related_ids":[],"upsell_ids":[],"cross_sell_ids":[],"parent_id":0,"categories":[],"tags":[],"images":[{"id":0,"created_at":"2016-01-24T18:13:43Z","updated_at":"2016-01-24T18:13:43Z","src":"https://aldr.do.gr/wp-content/plugins/woocommerce/assets/images/placeholder.png","title":"Placeholder","alt":"Placeholder","position":0}],"featured_src":"","attributes":[{"name":"\u03a7\u03c1\u03ce\u03bc\u03b16","slug":"colore","position":0,"visible":true,"variation":true,"options":["#2","1","120gr"]}],"downloads":[],"download_limit":0,"download_expiry":0,"download_type":"","purchase_note":"","total_sales":0,"variations":[{"id":1328,"created_at":"2016-01-18T17:38:33Z","updated_at":"2016-01-18T20:22:17Z","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/test/?attribute_pa_colore=120-1000gr","sku":"001","price":"111","regular_price":"111","sale_price":null,"taxable":false,"tax_status":"taxable","tax_class":"","managing_stock":true,"stock_quantity":8,"in_stock":true,"backordered":false,"purchaseable":true,"visible":true,"on_sale":false,"weight":null,"dimensions":{"length":"","width":"","height":"","unit":"cm"},"shipping_class":"","shipping_class_id":null,"image":[{"id":0,"created_at":"2016-01-24T18:13:43Z","updated_at":"2016-01-24T18:13:43Z","src":"https://aldr.do.gr/wp-content/plugins/woocommerce/assets/images/placeholder.png","title":"Placeholder","alt":"Placeholder","position":0}],"attributes":[{"name":"\u03a7\u03c1\u03ce\u03bc\u03b16","slug":"colore","option":"120-1000gr"}],"downloads":[],"download_limit":0,"download_expiry":0},{"id":1329,"created_at":"2016-01-18T17:38:33Z","updated_at":"2016-01-18T20:22:17Z","downloadable":false,"virtual":false,"permalink":"https://aldr.do.gr/product/test/?attribute_pa_colore=1","sku":"","KONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elstKONSTANTINOSs-iMac:woostorage elst

Maybe @claudiosmweb can help here because I don't have any other idea (right now). Sorry.

I agree :-)
Thank you very much for your time :-)

@limeframe can you please export some of this products?
So I can test it.

Yes ofcource @claudiosmweb.
export_product-2016_01_25-09_17_43.csv.zip
Thanks

Well, your exported products are working for me.
Doesn't seem to be a data issue.

ok! I installed a new clean WP with woocommerce for testing purposes!
Take a look to the following video (screen capture)
http://mobisoft.gr/video-for-api/

@limeframe please, try our master now with this patch ^

@claudiosmweb its working now (after your changes)!
I will test more later and i will keep you informed
Thanks thanks and thanks again
Kostas

I believe this is enough. I'm creating a new release.
Thanks :)


python312Packages.mkdocs-rss-plugin: 1.14.0 -> 1.15.0

Diff: https://github.com/Guts/mkdocs-rss-plugin/compare/refs/tags/1.14.0...1.15.0
Changelog: https://github.com/Guts/mkdocs-rss-plugin/blob/refs/tags/1.15.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 324657 run on x86_64-linux 1

4 packages built:

python311Packages.mkdocs-rss-plugin
python311Packages.mkdocs-rss-plugin.dist
python312Packages.mkdocs-rss-plugin
python312Packages.mkdocs-rss-plugin.dist


Problems when working with Portable Class Library

I'm having some problems when working with Portable Class Library at ASP.NET 5 project using 6.0.0-beta7 release.
When I add a PCL reference to my project, NuGet package is trying to download and don't recognize my PCL project a solution project reference.
I put my PCL project reference at project.json file at "dependencies" node like this:
{
    "webroot": "wwwroot",
    "version": "1.0.0-*",

    "dependencies": {
        "Microsoft.AspNet.Diagnostics": "1.0.0-beta7",
        "Microsoft.AspNet.Mvc": "6.0.0-beta7",
        "Microsoft.AspNet.Mvc.TagHelpers": "6.0.0-beta7",
        "Microsoft.AspNet.Server.IIS": "1.0.0-beta7",
        "Microsoft.AspNet.Server.WebListener": "1.0.0-beta7",
        "Microsoft.AspNet.StaticFiles": "1.0.0-beta7",
        "Microsoft.AspNet.Tooling.Razor": "1.0.0-beta7",
        "Microsoft.Framework.Configuration.Json": "1.0.0-beta7",
        "Microsoft.Framework.Logging": "1.0.0-beta7",
        "Microsoft.Framework.Logging.Console": "1.0.0-beta7",
        "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.0.0-beta7",
        "Microsoft.AspNet.Mvc.WebApiCompatShim": "6.0.0-beta7",
        "<MyPCLProjectNameGoesHere>": "1.0.0-*"
    },
(rest of project.json file)
}

Some help?
Tks

Same problem. Is it possible to reference a PCL assembly in a ASP.NET 5 project?

What kind of PCL project? What does it target? Also how did you add the reference? Using the VS UI or some other way?

I solve the problem including when updating to Beta8...


Dataset preparation shell files are not working

Hi, thank you for sharing this awesome work.
I want to download your  ov-setting datasets.
However, bash data_download.sh is not working now.
Could you check this shell file, especially for the onedrive link?
When I tried to this shell file, I got this error message.
{"error_description":"Invalid JWT token. The token is expired."}
Thank you in advance!

Hi, thanks for your interest!
`data_download.sh' has been updated. Please try again :)

Awesome! Thank you so much for your quick response :)

I am sorry for bothering you. I just tried your fixed download scripts, but they are not working.
The error message is the same as before.
{"error_description":"Invalid JWT token. The token is expired."}
Could you check one more time? I think the access token expired very shortly.

Thank you for your kind response.
I tried to download it via OneDrive, but the file size is too large, so it is really unstable to download the full dataset.
Can you share how did you make the curl download URL link?
And I have a question about the OV setting dataset configuration.
In the README, you mentioned this.
"To achieve the OV setting, we re-organize the original ScanNet and SUN RGB-D and adopt annotations of more categories."
How is it different from the original dataset (ScanNet v2 and SUN RGB-D)? I'm curious about the number of datasets, etc.
I downloaded the dataset and wanted to check it out, but it was taking a long time to download, so I asked.

Thank you for your kind response. I now try to download it via OneDrive!
And I have a question about the OV setting dataset configuration. In the README, you mentioned this.
"To achieve the OV setting, we re-organize the original ScanNet and SUN RGB-D and adopt annotations of more categories."
How is it different from the original dataset (ScanNet v2 and SUN RGB-D)? I'm curious about the number of datasets, etc (I think there is some scene sub-sampling?!)

The difference is that we utilize annotations of more novel categories. And we have fixed some typo mistakes in the category name. As for the scene number, we didn't conduct sub-sampling. It should be the same as the original datasets.


remove Mainifest.toml

In an offline discussion, we decided to remove the Manifest.tomls from the library, since a library should build its dependencies from scratch every time.

@szabo137 I resolved the conflicts. Ready to merge.

@szabo137 Ready to merge

@szabo137 ping


CI: Fix CI Fail

Some action versions have been deprecated and thus should be updated.
I have also updated some which have not been deprecated to hopefully speed up the CI.

Thanks @Ayush1325 , merged.


feat: Git import - generate and save SSH Keys

Description

Approach 1: Create application(similar to create datasoource flow) and then delete application only if the user deletes. But the homepage will be filled with lot of applications. This is a bad experience.
Approach 2: Dont create application until the user input the git client url. To achieve this we need to store the generated SSH Keys in a separate collection. Similar to reset password flow where the token is stored in a collection for a time period.
This PR implements changes per approach 2.
Fixes #9755
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally
JUnit Tests

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

/ok-to-test sha=a7ffafd

/ok-to-test sha=5a7d471

/ok-to-test sha=fad8041

/ok-to-test sha=fad8041

/ok-to-test sha=3aaf349


Update input style

Issue
https://github.com/traefik/faency/issues/148
How to test

Run storybook
Check stories:

Input
TextField
IconButton => small impact from commit

Design opinion required on

Ghost variant rework for Input
Adornments for Input

specific layout when there are icon buttons

Rest follows design preco from the issue
Code review
Don't hesitate to be picky, I'd like to see learn your design patterns
Blocked by
Blocked by #153 (must add elevation on focused input) and #162

@seedy  TODO: fix native controls positionning.

@matthieuh All comment issues resolved.
I fixed some extra issues I found out with extra stories.
Please review changes + have a look at new stories in storybook (Input + TextField)
Thanks in advance

Input focused invalid has green border, it would be better as red
Tab interaction is broken because of adornments order. It would be better to make sure start is before the input and end is after in case of tabbable adornments

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


npm install found vulnerabilities

Hi, I did clone repository and run npm install and npm told me there is a vulnerabilities.
git clone --depth=1 https://github.com/Microsoft/TypeScript-Node-Starter.git <project_name>
cd <project_name>
npm install

found 377 vulnerabilities (220 low, 120 moderate, 37 high) in 13455 scanned packages
run `npm audit fix` to fix 333 of them.
44 vulnerabilities require semver-major dependency updates.

Yes, but all of them are dev-dependencies: Dependency of   jest [dev].
They are not intended to be used in production anyway.

I've updated there anyway 👍


the meaning of loss_Q

Hello, I found self.losses contains ['labels', 'masks', 'plane_depths', 'params', 'Q', 'plane_depths'], I don't understand the meaning of loss_Q. Did the paper mention this loss? Thanks for your effort.

Plane parameter loss is in a similar form to previous works "PlaneTR". loss_Q is the third term.


Update react configs

Pull Request Test Coverage Report for Build 24

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 22:
0.0%

Covered Lines:
29

Relevant Lines:
29

💛  - Coveralls


Buttom moving

In previous version there was a possibility to change positioning of buttons. Now this functionality is moved/removed?

What do you mean? anchor_x/anchor_y properties in DefaultProperty category are still there.

Sorry for taking your time, I guess I was blind that day. See everything now.


Differentiating snapTo from user snap in callbacks

Currently, onSnap gets fired for these two cases:

User snaps view by manually dragging it
Programatically snapping with snapTo

These two use cases are often reactions to very different types of interactions. It would be useful to have additional callbacks so that you have more granular control (e.g. onDragSnap vs onProgrammaticSnap, these names are terrible but illustrate the need).
Is this possible?

Any workaround for this?


Can mock APIs for HTTP but not HTTPS

Describe the bug
We are able to mock HTTP API requests but when we attempt to mock HTTPS API requests, they instead pass through to the original, un-mocked endpoints.
To Reproduce
Here I've set up three mocks.

Manually configured http://google.com
Manually configured https://google.com
Moctokit configured https://api.github.com/rate_limit

I added the moctokit one so I could be sure I wasn't doing the mock setup incorrectly.

Workflow
name: Mock API Test

on:
  pull_request:

jobs:
  metrics:
    name: Metrics
    runs-on: ubuntu-latest
    steps:
      - name: HTTP api call
        run: |
          result=$(curl -s http://google.com)
          echo "$result"

      - name: HTTPS api call
        run: |
          result=$(curl -s https://google.com)
          echo "$result"

      - run: |
          curl -s -L \
            -H "Accept: application/vnd.github+json" \
            -H "Authorization: Bearer ${{ github.token }}" \
            -H "X-GitHub-Api-Version: 2022-11-28" \
            -o response.json \
            https://api.github.com/rate_limit
          cat response.json

Jest Test Code
let { MockGithub, Moctokit } = require("@kie/mock-github")
let { Act, Mockapi } = require("@kie/act-js")
let path = require("path")

jest.setTimeout(60000)

let mockGithub
beforeEach(async () => {
  mockGithub = new MockGithub({
    repo: {
      testCompositeAction: {
        files: [
          {
            src: path.join(__dirname, "mock-api.test.yml"),
            dest: ".github/workflows/mock-api.test.yml",
          },
        ],
      },
    },
  })

  await mockGithub.setup()
})

afterEach(async () => {
  await mockGithub.teardown()
})

test("it mocks api calls", async () => {
  const moctokit = new Moctokit()
  const mockapi = new Mockapi({
    google_https: {
      baseUrl: "https://google.com",
      endpoints: {
        root: {
          get: {
            path: "/",
            method: "get",
            parameters: {
              query: [],
              path: [],
              body: [],
            },
          },
        },
      },
    },
    google_http: {
      baseUrl: "http://google.com",
      endpoints: {
        root: {
          get: {
            path: "/",
            method: "get",
            parameters: {
              query: [],
              path: [],
              body: [],
            },
          },
        },
      },
    }
  })
  const act = new Act(mockGithub.repo.getPath("testCompositeAction"))
    .setGithubToken("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") // fake token
  const result = await act.runEvent("pull_request", {
    logFile: path.join(__dirname, "../logs/metrics.log"),
    mockApi: [
      mockapi.mock.google_http.root
        .get()
        .setResponse({ status: 200, data: "mock response" }),
      mockapi.mock.google_https.root
        .get()
        .setResponse({ status: 200, data: "mock response" }),
      moctokit.rest.rateLimit
        .get()
        .setResponse({ status: 200, data: "mock response" }),
    ]
  })
  console.log(result)
})

Test Output
console.log
  [
    { name: 'Main HTTP api call', status: 0, output: 'mock response' },
    {
      name: 'Main HTTPS api call',
      status: 0,
      output: '<meta http-equiv="content-type" content="text/html;charset=utf-8">\n' +
        '<TITLE>301 Moved</TITLE>\n' +
        '
301 Moved
\n' +
        'The document has moved\n' +
        'here.\n' +
        ''
    },
    {
      name: 'Main curl -s -L \\',
      status: 0,
      output: '{\n' +
        '"message": "Bad credentials",\n' +
        '"documentation_url": "https://docs.github.com/rest"\n' +
        '}'
    }
  ]

Expected behavior
All three mocks should intercept the api calls and respond with 'mock response'.
Instead only the HTTP API request is being mocked. The other two are hitting the actual APIs.
Logs

Logs
[Mock API Test/Metrics] 🚀  Start image=ghcr.io/catthehacker/ubuntu:act-latest
[Mock API Test/Metrics]   🐳  docker pull image=ghcr.io/catthehacker/ubuntu:act-latest platform=linux/amd64 username= forcePull=true
[Mock API Test/Metrics]   🐳  docker create image=ghcr.io/catthehacker/ubuntu:act-latest platform=linux/amd64 entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[Mock API Test/Metrics]   🐳  docker run image=ghcr.io/catthehacker/ubuntu:act-latest platform=linux/amd64 entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[Mock API Test/Metrics] ⭐ Run Main HTTP api call
[Mock API Test/Metrics]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/0] user= workdir=
[Mock API Test/Metrics]   | mock response
[Mock API Test/Metrics]   ✅  Success - Main HTTP api call
[Mock API Test/Metrics] ⭐ Run Main HTTPS api call
[Mock API Test/Metrics]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1] user= workdir=
[Mock API Test/Metrics]   | <meta http-equiv="content-type" content="text/html;charset=utf-8">
[Mock API Test/Metrics]   | <TITLE>301 Moved</TITLE>
[Mock API Test/Metrics]   |
301 Moved

[Mock API Test/Metrics]   | The document has moved
[Mock API Test/Metrics]   | here.
[Mock API Test/Metrics]   |
[Mock API Test/Metrics]   ✅  Success - Main HTTPS api call
[Mock API Test/Metrics] ⭐ Run Main curl -s -L \
  -H "Accept: application/vnd.github+json" \
  -H "Authorization: Bearer ***" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  -o response.json \
  https://api.github.com/rate_limit
cat response.json
[Mock API Test/Metrics]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/2] user= workdir=
[Mock API Test/Metrics]   | {
[Mock API Test/Metrics]   |   "message": "Bad credentials",
[Mock API Test/Metrics]   |   "documentation_url": "https://docs.github.com/rest"
[Mock API Test/Metrics]   | }
[Mock API Test/Metrics]   ✅  Success - Main curl -s -L \
  -H "Accept: application/vnd.github+json" \
  -H "Authorization: Bearer ***" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  -o response.json \
  https://api.github.com/rate_limit
cat response.json
[Mock API Test/Metrics] 🏁  Job succeeded

Additional context
I've tried this on a macbook (Ventura 13.5) as well as an AWS EC2 instance (Amazon Linux 2023) with the same results.

This seems pretty similar to https://github.com/kiegroup/mock-github/issues/72

Is this an issue of documentation? Is it a known issue and we need to be more clear what's said here?:

You can use Mockapi and Moctokit to mock any kind of HTTP and HTTPS requests during your workflow run provided that the client being used honours HTTP_PROXY and HTTP_PROXY env variables. Depending on the client, for HTTPS they might issue a CONNECT request to open a secure TCP tunnel. In this case Act won't be able to mock the HTTPS request. (Note - For Octokit, you can mock HTTPS requests because it does not issues a CONNECT request)

Is it common or uncommon for a client to honour these env vars?
How do you know if your client honours these?
Should a client that honours HTTP_PROXY not also honour HTTPS_PROXY?

Hi @walkerab, yes this is a known issue. I am not able to mock HTTPS requests yet because under the hood I use a proxy which decides whether or not to mock a request. Now even if I set the HTTPS_PROXY env var to a "http://" location some clients will issue a CONNECT request first. This request is used to tell a proxy to set up TCP tunnel to the destination which is then secured by TLS. Since the tunnel is encrypted the proxy is not able to read the actual requests and is not able to mock it. So for example:

Client wants to make a request to https://google.com via the proxy running at http://localhost:3000
Client issues a CONNECT request to proxy. This request only contains the host ("google") and port ("443") and not nothing else from the request
Proxy sets up a tunnel between client and google
Client initiates TLS handshake after which any data flowing through the tunnel in encrypted

So, as for your questions:

Is it common or uncommon for a client to honour these env vars?

It is common for clients to honor these variables. I know that curl does but sometimes clients such as Octokit don't and have to be configured manually

How do you know if your client honours these?

It is usually in their documentation

Should a client that honours HTTP_PROXY not also honour HTTPS_PROXY?

They do but that is not the issue here as I explained above. I do try to "fool" these clients by setting HTTPS_PROXY to a http location but it doesn't work for all clients, for example it doesn't work for curl but it works for axios
Now as for the workarounds for this, I would suggest if possible store the base url of your APIs as env variables in your workflow. Then while testing you should be able to change the env variables and set your base url to be http (for example all workflows have $GITHUB_API_URL available, you can easily override that while testing). I do have a plan of trying to handle HTTPS directly by implementing some sort of a MITM proxy but haven't been able to get to it yet. I am open to more ideas, if you have any, on how to handle this :)
Sorry for the unclear documentation, I will fix it.

Thanks for the response, @shubhbapna. What you are saying makes enough sense to me.
For now I have worked around this by using the mockttp library instead like so:

Workflow
name: Mock API Test

on:
  pull_request:

jobs:
  metrics:
    name: Metrics
    runs-on: ubuntu-latest
    steps:
      - name: CA Cert File
        run: |
          echo "$CA_CERT" > /tmp/ca-cert.pem

      - name: HTTP api call
        run: |
          result=$(curl -s http://google.com)
          echo "$result"

      - name: HTTPS api call
        run: |
          result=$(curl --cacert /tmp/ca-cert.pem -s https://google.com)
          echo "$result"

      - run: |
          result=$(\
            curl --cacert /tmp/ca-cert.pem -s -L \
            -H "Accept: application/vnd.github+json" \
            -H "Authorization: Bearer ${{ github.token }}" \
            -H "X-GitHub-Api-Version: 2022-11-28" \
            http://api.github.com/rate_limit \
          )
          echo "$result"

Jest Test Code
const { MockGithub } = require("@kie/mock-github")
const { Act } = require("@kie/act-js")
const mockttp = require('mockttp');
const path = require("path")

jest.setTimeout(60000)

let mockGithub
beforeEach(async () => {
  mockGithub = new MockGithub({
    repo: {
      testCompositeAction: {
        files: [
          {
            src: path.join(__dirname, "../.actrc"),
            dest: "/.actrc",
          },
          {
            src: path.join(__dirname, "mock-api.test.yml"),
            dest: ".github/workflows/mock-api.test.yml",
          },
        ],
      },
    },
  })

  await mockGithub.setup()
})

afterEach(async () => {
  await mockGithub.teardown()
})

test("it mocks a github api call", async () => {
  const https = await mockttp.generateCACertificate()
  const server = mockttp.getLocal({ https })
  await server.start()
  await server.forGet("http://google.com").thenReply(200, "mock response")
  await server.forGet("https://google.com").thenReply(200, "mock response")
  await server.forGet("http://api.github.com/rate_limit").thenReply(200, "mock response")

  const server_url = `http://host.docker.internal:${ server.port }`

  const act = new Act(mockGithub.repo.getPath("testCompositeAction"))
    .setEnv("HTTP_PROXY", server_url)
    .setEnv("http_proxy", server_url)
    .setEnv("HTTPS_PROXY", server_url)
    .setEnv("https_proxy", server_url)
    .setEnv("CA_CERT", https.cert)
    .setGithubToken("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") // fake token
  const result = await act.runEvent("pull_request", {
    logFile: path.join(__dirname, "../logs/metrics.log"),
  })
  console.log(result)

  await server.stop()
})

Oh nice this library looks promising. Thank you!
Although it looks like it has the same issue I was worried about in a MITM proxy - manually having to pass the cacerts but I think it is a good starting point!

updated the docs feel free to open it again if it is unclear:
https://github.com/kiegroup/act-js#mocking-apis-during-the-run
opened an issue to hopefully implement complete mocking of HTTPS request: #53


Rotation inconsistent in/out side of regions

Rotation doesn't look bad outside of regions.  In these pics, there's one region in the top left. Figure out the difference, make it consistent, and make it look like it does outside of regions.
I suspect it is applied twice within regions.
Rock texture

Checkered texture

As of 0.9, rotation is now doubly applied uniformly inside and out of regions. So maybe go back to 0.8.3 or 0.8.2, and look at it there to figure out what causes it to work better outside of regions.


Group permission placeholder

e.g.
%luckperms_{groupname}_has_permission_{permission}%
which returns true/false.
I want to return this value to a deluxemenu gui item to show if a group has access to chat (for an admin chat toggle system) so i can write
"Enabled: %luckperms_{groupname}_has_permission_{permission}%"

Sorry, I feel like this is a bit too niche for including in the LP expansion.
Of course, you (or another developer) can access this info using the API and implement your own placeholder for it :)


constantly dies

this thing cannot stay up for longer than 2 days n a production cluster before it starts not responding, i cant trust it under load, i cant even delete it from the cluster it wont let me

is there an actual stable version? its been like this for months

@webcoderz Thank you for the feedback. Cloud you also provide logs so that we can better understand what's going on? Thank you again in advance!
By the way as I know it's being used by a couple of organizations in production environment for years, it's quite stable.

sorry, for being frustrated, just breaks alot, what logs would you specifically need? here is my milvus cluster yaml
`apiVersion: milvus.io/v1beta1
kind: Milvus
metadata:
name: cluster
namespace: milvus
labels:
app: cluster
spec:
mode: cluster
components:
dataNode:
replicas: 2
indexNode:
replicas: 2
queryNode:
replicas: 2
mixCoord:
replicas: 1
dependencies:
etcd:
inCluster:
values:
replicaCount: 1
deletionPolicy: Delete
pvcDeletion: true
pulsar:
inCluster:
values:
components:
autorecovery: false
functions: false
toolset: false
pulsar_manager: false
monitoring:
prometheus: true
grafana: false
node_exporter: true
alert_manager: false
proxy:
replicaCount: 1
resources:
requests:
cpu: 0.01
memory: 256Mi
configData:
PULSAR_MEM: >
-Xms256m -Xmx256m
PULSAR_GC: >
-XX:MaxDirectMemorySize=256m
bookkeeper:
replicaCount: 2
resources:
requests:
cpu: 0.01
memory: 256Mi
configData:
PULSAR_MEM: >
-Xms256m
-Xmx256m
-XX:MaxDirectMemorySize=256m
PULSAR_GC: >
-Dio.netty.leakDetectionLevel=disabled
-Dio.netty.recycler.linkCapacity=1024
-XX:+UseG1GC -XX:MaxGCPauseMillis=10
-XX:+ParallelRefProcEnabled
-XX:+UnlockExperimentalVMOptions
-XX:+DoEscapeAnalysis
-XX:ParallelGCThreads=32
-XX:ConcGCThreads=32
-XX:G1NewSizePercent=50
-XX:+DisableExplicitGC
-XX:-ResizePLAB
-XX:+ExitOnOutOfMemoryError
-XX:+PerfDisableSharedMem
-XX:+PrintGCDetails
zookeeper:
replicaCount: 1
resources:
requests:
cpu: 0.01
memory: 256Mi
configData:
PULSAR_MEM: >
-Xms256m
-Xmx256m
PULSAR_GC: >
-Dcom.sun.management.jmxremote
-Djute.maxbuffer=10485760
-XX:+ParallelRefProcEnabled
-XX:+UnlockExperimentalVMOptions
-XX:+DoEscapeAnalysis -XX:+DisableExplicitGC
-XX:+PerfDisableSharedMem
-Dzookeeper.forceSync=no
broker:
replicaCount: 1
resources:
requests:
cpu: 0.01
memory: 256Mi
configData:
PULSAR_MEM: >
-Xms256m
-Xmx256m
PULSAR_GC: >
-XX:MaxDirectMemorySize=256m
-Dio.netty.leakDetectionLevel=disabled
-Dio.netty.recycler.linkCapacity=1024
-XX:+ParallelRefProcEnabled
-XX:+UnlockExperimentalVMOptions
-XX:+DoEscapeAnalysis
-XX:ParallelGCThreads=32
-XX:ConcGCThreads=32
-XX:G1NewSizePercent=50
-XX:+DisableExplicitGC
-XX:-ResizePLAB
-XX:+ExitOnOutOfMemoryError
config:
milvus:
log:
level: info
component:
  proxy:
    timeTickInterval: 150

`

I thought you mean milvus-operator constantly dies? or do you mean the milvus cluster?
Before you reply, I assume it's the  milvus cluster.
From the configuration you provided, it's not suitable for production environment. It's like a minimum deployment. It use only 1 replica of etcd & only 256MB memory for pulsar pods. which may cause pulsar to crash easily when you insert data.
For production, try using the default dependencies configurations by leaving dependencies: {}:
apiVersion: milvus.io/v1beta1
kind: Milvus
metadata:
  name: my-release
  labels:
    app: milvus
spec:
  mode: cluster
  components:
    dataNode:
      replicas: 2
    indexNode:
      replicas: 2
    queryNode:
      replicas: 2
    mixCoord:
      replicas: 1
  config:
    milvus:
      log:
        level: info
    component:
      proxy:
        timeTickInterval: 150
  dependencies: {}

milvus-operator will fill the suitable configurations for you.

Okay thank you , yes it's the brokers that keep dying, I am only running single node for now but will be adding nodes soon once my bare metal nodes arrive, thank you I will see if this helps, and the operator itself is fine , this helps a lot .. thanks for your help! Will test it and let you know if I have problems from there

both the in-cluster dependencies & PVCs are set to retain by default, to avoid data loss when you delete a production env milvus by mistake.
If you want milvus-operator to delete them after you deleted milvus, check the demo manifest
in short you need to add below config block for each dependency you use.
inCluster:
  values:
    deletionPolicy: Delete
    pvcDeletion: true

Okay great thanks 🙏 and sorry for my frustrations