Partner recommendation system

Seeing the growing need among students (and professors maybe, sighting a recent case) to find a partner , I propose to implement a partner recommendation system, which will search a partner for you from the college itself, based on the information you input. So you could describe the characteristics of the partner you're looking for, and the system will search one for you. Think of it as Intra-IIIT-Tinder.
This is not a joke, I'm dead serious.
Currently students travel vast distances just to catch up with their tinder dates. This leads to various complications, such as not being allowed inside the gate (after 10 p.m), seeing your name on Hibiscus, being forced to meet some faculty investigating the reason for the delay. We've witnessed several such cases in the college.  As a result of this, the students aren't able to spend quality time with their dates. This app could avoid this hustle, and make the process of dating much more simple, effective (and help you save money, maybe) and hopefully long-term.
Tech Stack: ML, App Development (apps are always better).

which will search a partner for you from the college itself, based on the information you input.

So you want something like an OkCupid but for our college only.

and professors maybe, sighting a recent case

Are you talking about that recent incident that traumatized us all :laughing: ?
Just to be sure this app will be a secret amongst students right? Because if the faculties get to know then TT will be furious and might ban us or some shizz

(apps are always better)

Maybe in this case (and I don't wanna start a war) but CLI tools are always better
Since it is ML I hope that @knrt10 wouldn't mind if we write the API  in python.
@ayush1999 you can build the recommendor system that will integrate with a Flask API which @knrt10 can query in his app written in JS

Are you talking about that recent incident that traumatized us all laughing?
@palash25 dude that was unscripted and out of the box.
TT will be furious
Kamleshhhhhhhh.
Since it is ML I hope that @knrt10 wouldn't mind if we write the API in python.
I got no problem. Like sapat. Haich nahi..
Although most work @ayush1999 will do. So I am cool.

Finally, some work required ML.
Count me in too.
@ayush1999 what are you thinking of applying.

@ankitjha97 First of all, I think we'd need to come up with a set of features that a person might look for in his date. Such as personality, appearance, and similar attributes. Depending on these, we could decide the architecture to implement . What do you think?

Great idea to work upon, well we have to keep it little secretive else there will be no less than a DC (saying this by experience with college people).😂😂
Once done on our college level, it can definitely be expanded to a larger domain. So, Cool👌
@hdidwania have a look.

I love the new label @knrt10 but I am not sure whether this is appropriate or not.

We need to think on some points-

How does tool get to collect information/features.
How to avoid fake information, which may lead to bad predictions.
Dataset.
Use of NLP/CV maybe to extract some features
and many more..
Well this will be awesome. Let's put Tinder out of business.

@ayush1999 Count me in too.

@ayush1999 , the idea on which the Recommender System works goes like this:
1) There a matrix containing ratings of all the users to the items(movies, songs).
2) From this matrix we apply ways to find the recommendation.These ways include:
a) User Based: In this we group users of similar types
b) Item based: In this we group items of same types
The moral of this story is somehow, in these cases we didn't have direct data like for Movies, we didn't have Action, Adventure, Fantasy, Comedy, etc. as a  separate column for data but these algos are able to find out these latent factors themselves.The point I want to say is that we can two things.First, we can give them and let them swipe and from these images, identify the latent factors.Or Second, We can give them preferences and ensemble both the latent factors and preferences to assign a match.
How's it for an idea @ayush1999 @shivank01 @hdidwania

@hdidwania , yes we should aim big and replacing them is not a big task. There is one site called betterhalf.ai which uses AI to predict matches. It's still in its development phase and so figuring out the algos is tough for the present moment.

The biggest drawback of Tinder, I feel, is it works around pretension and presentation. Before swiping, one only has access to some photos and a little bio. These things can easily be made up by anyone and faked. We can try to match features which are better than images, features like interests.
Since we are starting with the domain of college, everyone in the domain has quite a lot of common features, age group, career path, etc. We can focus more on interests of every user: Music Taste, Favorite Series, Books read recently, etc. We need to have some thought over it though, but if we can implement this, I believe we will have a real good model for matches.

I was thinking that maybe we could take natural language as input in the later stages. For now, suppose we have the feature of Movie Taste (similar to what @hdidwania just said). For starters, we could map the various sub-categories inside this to different  numbers. So the app would ask you your movie taste, with different options, such as:

Action
Comedy
Thriller
Romance
.
.
.
And we could map the user's choice to the corresponding index. This could be an naive yet simple start to the network. (The user should also be able to input more that one category, ofcourse). The same could be done to various other features like Music, Sports, (Ronaldo/Messi should certainly be there :laughing: ) and so on. What do you think?

So at the end, the input we'd have for the network would be just a set of numbers (depending on the users inputs). We can then build the model on this basis.
Any ideas? @ankitjha97 @shivank01 @hdidwania

I think we should migrate to some other group for the confidentiality of the model.

So at the end, the input we'd have for the network would be just a set of numbers (depending on the users inputs). We can then build the model on this basis.

So we would have many variables as inputs, all of type discrete numbers. We also need to think whether to keep it as a classification problem, outputting 1/0 or a regression problem, outputting maybe a similarity score between 0 to 1.

I think we should migrate to some other group for the confidentiality of the model.

Yup, its really a great idea, and much more can be planned by you people, so don't keep it open for now, better discuss it in a private group. Later keep adding up people, who show their interest over here.

I think if we are talking the input as integer value for the variables like people mentioned above regression is highly suited for it.We can also have a personality based partner recommendation app for which we need to take inputs for a personality test and on the basis of that test inputs we can run a classification algorithm to match.

@ayush1999,  not necessarily integers. They should be one one-hot encoded so that each separate category falls into a different dimension. Assigning only integer values can lead to errors and building of a false relationship between categories based on the closeness of integers in case of regression.

@ayush1999 @hdidwania @shivank01, this is where we can exploit unsupervised learning.

Someone create a group on telegram and add me in.

not necessarily integers. They should be one one-hot encoded so that each separate category falls into a different dimension. Assigning only integer values can lead to errors and building of a false relationship between categories based on the closeness of integers in case of regression.

I agree we should keep it one hot encoded.

this is where we can exploit unsupervised learning.

Yeah, I think unsupervised learning will work well here.

Yeah in this case KNN can be used to group users based on similar interests. A group a neighborhood models will be useful.

I like the KNN idea. This may work.

As the conversation is moved to the telegram group.I am closing this issue. Anyone who wants to join it can join it through this link - https://t.me/joinchat/ImdqDBHmLgpvglhae6kElA .


ZEPPELIN-44 Interpreter for Apache Flink

Interpreter for Apache Flink.
Flink people helped a lot to write the interpreter. Thanks so much! Some codes are copied from Flink's development branch. Once Flink releases 0.9, copied code and snapshot repository configuration will be removed.
Build
if there're no options, by default it is building against flink 0.9.0-milestone-1.
With combination of Zeppelin, it is good idea to use 0.9-SNAPSHOT, because of it support .collect() that helps really a lot to get results data and display it on Zeppelin.
So, you might want to build in this way,
mvn package -Dflink.version=0.9-SNAPSHOT -DskipTests

Screenshot

@Leemoonsoo Wow, Does it work?

@jongyoul Yes it works!

I'm very excited to see Flink support in Zeppelin :+1:

@Leemoonsoo Great!!

This PR has some test using FlinkMiniCluster.
Tests are fine when i run them on my IDE.
But if i run them using maven, it fails. (CI is failing, too)
I think everything is ready, except for this test failure. Any advice is very appreciated.
here's failure message
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.flink.FlinkInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/incubator-zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 106.131 sec <<< FAILURE! - in org.apache.zeppelin.flink.FlinkInterpreterTest
org.apache.zeppelin.flink.FlinkInterpreterTest  Time elapsed: 106.131 sec  <<< ERROR!
java.util.concurrent.TimeoutException: Futures timed out after [100000 milliseconds]
	at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:219)
	at scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:223)
	at scala.concurrent.Await$$anonfun$result$1.apply(package.scala:107)
	at scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:53)
	at scala.concurrent.Await$.result(package.scala:107)
	at akka.remote.Remoting.start(Remoting.scala:180)
	at akka.remote.RemoteActorRefProvider.init(RemoteActorRefProvider.scala:184)
	at akka.actor.ActorSystemImpl.liftedTree2$1(ActorSystem.scala:619)
	at akka.actor.ActorSystemImpl._start$lzycompute(ActorSystem.scala:616)
	at akka.actor.ActorSystemImpl._start(ActorSystem.scala:616)
	at akka.actor.ActorSystemImpl.start(ActorSystem.scala:633)
	at akka.actor.ActorSystem$.apply(ActorSystem.scala:142)
	at akka.actor.ActorSystem$.apply(ActorSystem.scala:119)
	at akka.actor.ActorSystem$.create(ActorSystem.scala:67)
	at org.apache.flink.runtime.akka.AkkaUtils$.createActorSystem(AkkaUtils.scala:82)
	at org.apache.flink.runtime.minicluster.FlinkMiniCluster.startJobManagerActorSystem(FlinkMiniCluster.scala:105)
	at org.apache.flink.runtime.minicluster.FlinkMiniCluster.<init>(FlinkMiniCluster.scala:61)
	at org.apache.flink.runtime.minicluster.LocalFlinkMiniCluster.<init>(LocalFlinkMiniCluster.scala:44)
	at org.apache.zeppelin.flink.FlinkInterpreter.startFlinkMiniCluster(FlinkInterpreter.java:297)
	at org.apache.zeppelin.flink.FlinkInterpreter.initializeFlinkEnv(FlinkInterpreter.java:152)
	at org.apache.zeppelin.flink.FlinkInterpreter.open(FlinkInterpreter.java:115)
	at org.apache.zeppelin.flink.FlinkInterpreterTest.setUp(FlinkInterpreterTest.java:40)

Results :

Tests in error:
  FlinkInterpreterTest.setUp:40 Â» Timeout Futures timed out after [100000 millis...

I forwarded the error to the Flink dev mailing list. Hopefully somebody from the Flink community can help with this.

I figured out the problem: It is a wrong protobuf-java version. flink-runtime depends on akka-remote_2.10:2.3.7 which depends on protobuf-java:2.5.0. However, in the Zeppelin parent pom the protobuf-java version is manually set to 2.4.1. There is a comment which declares this as a work-around to make Zeppelin build with Hadoop/YARN 2.2.
As a quick work-around you can set the protobuf-java version to 2.5.0 in the zeppelin-flink pom.xml. I'll also open a JIRA to shade the protobuf and akka dependency away in the flink project. This should solve this issue permanently.

Really appreciate for investigating the problem.
I think this is wrong in Zeppelin side. That, Zeppelin used to have dependency configuration for spark in pom.xml not in spark/pom.xml. I think it should be moved into spark/pom.xml to not interfere the other modules.
I'll create issue for it in Zeppelin side.

Okay, so this pull request is not blocked by anything from the Flink side right now?

@rmetzger Not blocked by anything from Flink side.
I'm testing the branch with 9 node Flink cluster environment. Works well but looks like need special build command. I'll update build configuration.

After resolving Zeppelin side issue by #88, Tests are passing.
Ready to merge.

Merging it if there is no more discussions :-)

W000t!


[5.0.0] NamedModulesPlugin is not a constructor

Hello everyone. After update to 5.0 I have problem when i start app.
TypeError: webpack.NamedModulesPlugin is not a constructor
plugins: options.plugins.concat([
        // It is needed to provide a workaround for moment js working with webpack.
        new webpack.ContextReplacementPlugin(/^\.\/locale$/, context => {
            if (!/\/moment\//.test(context.context)) {
                return;
            }
            // context needs to be modified in place
            Object.assign(context, {
                // include only ru and en variants
                // all tests are prefixed with './' so this must be part of the regExp
                // the default regExp includes everything; /^$/ could be used to include nothing
                regExp: /^\.\/(en|ru|pl)/,
                // point to the locale data folder relative to moment's src/lib/locale
                request: '../locale',
            });
        }),
        new webpack.DefinePlugin(StringifiedEnvVars),
        new webpack.NamedModulesPlugin(),
    ]),

NamedModulesPlugin ↦ optimization.moduleIds: 'named'

https://webpack.js.org/migrate/5/#update-outdated-options

@jouni-kantola thanks

This plugin was removed, you even don’t need this anymore, we use better logic for long term caching out of box


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1497

Questions ?
Please refer to the Backport tool documentation


Folders tree like old Webmin java filemanager: enhancement

Is it possible to have a "folders tree" like the old file manager? Could be very useful for navigate folders without return back every time. Thanks.
Simone

Tis was discussed in forum thread.
This feature will require some redesign to maintain overall compactness of da interface.
If you have any suggestions how to make things nice and clear visually, then be my guest.
I'll think about adding this feature, but no promises of doing it quickly :D

+1 for this feature request

Maybe something like this Jquery plugin?
http://www.jqueryscript.net/layout/jQuery-jQuery-UI-Dynamic-Tree-View-Plugin-Fancytree.html

Yep, nice plugin, how can we integrate it to the current interface without making it look wobbly?

Planned for 1.1.0

Sorry if i can't help you, i'm not so good with this code!
Thanks for planning this!

It does not matter, cause I already know how to do this :)

Added in 1.1.0


adapting the custom language switcher example to mkdocs-theme-bootstrap4

is mkdocs-static-i18n compatible with mkdocs-theme-bootsrap4 ?
i'm trying to adapt the custom language switcher example that you describe and i can't get it to work. Any pointers ?

hi @inouthack
mkdocs-static-i18n is independent of themes so yes it is compatible with them all since it just offers variables that you can use to modify any jinja macro / template
I've never checked that theme and you're not providing any code / sample so it's hard to point you somewhere. The example I provide tho does work, I guess you tried it on the basic mkdocs theme first?


Metadata loading fails

I'm trying to load the library like this: import { parse, format } from 'libphonenumber-js'; and gives me an error during build.
ERROR in ./~/libphonenumber-js/metadata.min.json
Module parse failed: ./node_modules/libphonenumber-js/metadata.min.json Unexpected token (1:34)
You may need an appropriate loader to handle this file type.

I'm using ES6+, babel and Vue 2 with Laravel as framework

It tells you what to do:

ERROR in ./~/libphonenumber-js/metadata.min.json
You may need an appropriate loader to handle this file type.

Now tell me what do you need to do to make it work

I needed to include json-loader with my webpack configuration.
Thanks for pushing me, I should've thought of that.

@MarkoSulamagi Yeah, it's described in the end of the README but not everyone gets there


Disable warnings for ControlAddins

@sirhc101 Would it be possible to provide a fix for this issue, or should we wait for the new version? Any ETA on when the new release would be available?
We've configured our workspace with following settings
"al-xml-doc.CheckObjectDocumentationInformationLevel": "Disabled",
    "al-xml-doc.CheckProcedureDocumentationInformationLevel": "Warning",
    "al-xml-doc.CheckProcedureDocumentationForType": [
        "Global Procedures"
    ]

However, I can't get rid of the warnings (neither via #pragma) that are shown on the events for our controladdin objects. Any idea on how to disable these?

Hi @fvet
Sure, that's a small change. I will provide a fix for this asap.
Regarding your question for the new version. The base version is completed, but we're currently testing a lot to make sure performance is good. Right now I'm not very happy with the performance of big files, but we've some ideas how to solve the problems.

You can now specify two new options in CheckProcedureDocumentationForType:

Control Add-In Events
Control Add-In Procedures

Additionally procedures in control add-ins will no longer be recognized as global, local or internal procedure. All are now handled with Control Add-In Procedures instead

Version 1.1.7 is on it's way to marketplace

Just installed the latest version and it works fine!
Thanks a lot for the quick fix ;)


ExtractFiles should allow overwriting destination

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
bug
Enter Task Name: ExtractFiles
Environment

Server : Azure Pipelines

Agent : Private : Windows Server 2019

Issue Description
Task fails if "Clean destination folder before extracting" is not checked and destination folder is not empty.
Task logs
2019-10-19T12:13:02.9307087Z ##[section]Starting: Extract files
2019-10-19T12:13:02.9446365Z ==============================================================================
2019-10-19T12:13:02.9446437Z Task         : Extract files
2019-10-19T12:13:02.9446466Z Description  : Extract a variety of archive and compression files such as .7z, .rar, .tar.gz, and .zip
2019-10-19T12:13:02.9446510Z Version      : 1.151.1
2019-10-19T12:13:02.9446551Z Author       : Microsoft Corporation
2019-10-19T12:13:02.9446577Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/extract-files
2019-10-19T12:13:02.9446604Z ==============================================================================
2019-10-19T12:13:03.2123419Z No path specified for search pattern: *.zip defaulting to: C:\azagent\A1\_work\r1\a
2019-10-19T12:13:03.2124863Z Searching for: *.zip under directory: C:\azagent\A1\_work\r1\a
2019-10-19T12:13:03.2200742Z Found: 1 files to extract:
2019-10-19T12:13:03.2200895Z C:\azagent\A1\_work\r1\a\Staging - CI\AssetToDeply\AssetToDeply.zip
2019-10-19T12:13:03.2207021Z Extracting file: C:\azagent\A1\_work\r1\a\Staging - CI\AssetToDeply\AssetToDeply.zip
2019-10-19T12:13:03.2219725Z [command]C:\azagent\A1\_work\_tasks\ExtractFiles_5e1e3830-fbfb-11e5-aab1-090c92bc4988\1.151.1\7zip\7z.exe x -oC:\Apps\AssetDest\dev C:\azagent\A1\_work\r1\a\Staging - CI\AssetToDeply\AssetToDeply.zip
2019-10-19T12:13:03.2435313Z
2019-10-19T12:13:03.2435539Z
2019-10-19T12:13:03.2435783Z ERROR: Can't allocate required memory!
2019-10-19T12:13:03.2435822Z 7-Zip [64] 16.00 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-10
2019-10-19T12:13:03.2435867Z
2019-10-19T12:13:03.2435912Z Scanning the drive for archives:
2019-10-19T12:13:03.2435961Z 1 file, 35814372 bytes (35 MiB)
2019-10-19T12:13:03.2435994Z
2019-10-19T12:13:03.2436042Z Extracting archive: C:\azagent\A1\_work\r1\a\Staging - CI\AssetToDeply\AssetToDeply.zip
2019-10-19T12:13:03.2436104Z --
2019-10-19T12:13:03.2436184Z Path = C:\azagent\A1\_work\r1\a\Staging - CI\AssetToDeply\AssetToDeply.zip
2019-10-19T12:13:03.2436216Z Type = zip
2019-10-19T12:13:03.2436292Z Physical Size = 35814372
2019-10-19T12:13:03.2436347Z
2019-10-19T12:13:03.2436377Z
2019-10-19T12:13:03.2436424Z Would you like to replace the existing file:
2019-10-19T12:13:03.2436475Z   Path:     C:\Apps\AssetDest\dev\Api.Abstractions.dll
2019-10-19T12:13:03.2436519Z   Size:     10240 bytes (10 KiB)
2019-10-19T12:13:03.2436548Z   Modified: 2019-10-19 10:16:40
2019-10-19T12:13:03.2436639Z with the file from archive:
2019-10-19T12:13:03.2436730Z   Path:     Api.Abstractions.dll
2019-10-19T12:13:03.2436761Z   Size:     10240 bytes (10 KiB)
2019-10-19T12:13:03.2436841Z   Modified: 2019-10-19 10:16:40
2019-10-19T12:13:03.2436915Z ? (Y)es / (N)o / (A)lways / (S)kip all / A(u)to rename all / (Q)uit?
2019-10-19T12:13:03.2436981Z Archives with Errors: 1
2019-10-19T12:13:03.2437000Z
2019-10-19T12:13:03.2438414Z code: 2

Troubleshooting
Need to add "-aoa" switch (Overwrite All existing files without prompt.) to 7zip command.
  Is it still stuck in review?  Once the code appears here on Github how long does it take until Azure DevOps starts leveraging the updated ExtractFiles task?

I agree with jrbacek - we need this feature, and it's not present.

I agree with jrbacek - we need this feature, and it's not present.

I've been begging, I've opened tickets.  Its crickets, Microsoft, please.  Help!

Just faced this issue, I think it's a bug rather than an enhancement.
Consider this: I have explicitly stated in task parameters that I do not want to clear the destination folder - which implies that I'm OK with any possible file name conflict during the extraction.

I will get this PR merged this week. Thanks!

@stephenmichaelf  Any update on this

I will get this PR merged this week. Thanks!

Any update on this

I was on call last week but I have time blocked on it today, I am going to open a new PR and will link to it here!

Has the PR been merged ? I am waiting for this

I'm excited to have this fixed as well.  We are waiting on migrating to Azure DevOps until this is fixed.  Stephen, I'm sure you are quite busy, but we appreciate your help.  Once its committed, do you know how long it will take to end up in Azure DevOps services?

@stephenmichaelf  We're waiting for your response and PR.

Hit this today. Any update on timing?

As far as I can tell, Microsoft is the only one that can actually accept the pull request.  I could be wrong here, but we are still waiting on Microsoft.  Please keep adding comments to the thread, it appears to be the only way it will get noticed.  Microsoft ignores our complains through our enterprise contract.  I wonder why we even pay it.

I had to use the standard copy files as a work around. @stephenmichaelf we need this merged asap!

Just seen 167 open pull requests. WTH!?

@ShreyasRmsft please review this. I have had to use pwsh to work around this issue which should be a simple fix for you guys :-)

@Miles-Davies-HORIBA sadly i'm not the owner for this task and the practice is generally for code owners or the team that owns the task to approve the PR.
Also FYI a couple of tests are failing https://github.com/microsoft/azure-pipelines-tasks/pull/11594/checks?check_run_id=673857387
I'll see what I can do and drop a mail to @stephenmichaelf and a few others who might be able to help here.

PR in progress here, almost done with testing then will merge: https://github.com/microsoft/azure-pipelines-tasks/pull/12902

@stephenmichaelf  Do you have any good news here?

We are excitedly waiting for this feature, so we can finally put this issue to bed.  Is there something we can do with our corporate Microsoft contacts to help prioritize this work?

PR in progress here, almost done with testing then will merge: #12902

Any update?

I echo the need for an overwrite option. Or perhaps just an arguments option where we can pass any 7zip argument.
In the mean time, easy enough to make due in PowerShell.

I echo the need for an overwrite option. Or perhaps just an arguments option where we can pass any 7zip argument.
In the mean time, easy enough to make due in PowerShell.

Hi David, would once you figure out the PowerShell script, would you mind posting it back here?  I know what 7zip arguments I need, but I'm not super familiar with what environment variable names reference the zip file and output directory.

@jrybacek I just used the microsoft.powershell.archive module in a PowerShell task. Pretty simple.

@stephenmichaelf when this PR is accepted, how long will it take to get into the Azure DevOps cloud product?

@stephenmichaelf  when this PR is accepted?

Hi @murugan-mp @jrybacek @AlexA-1976 could you please check it now? We have rolled out related changes for ExtractFiles task - so it should be available now

@TFleury  @murugan-mp  @jrybacek @AlexA-1976 I'm closing it at the moment - please let us know if there are still any issues


use cyordereddict

I see about a 25% speed improvement dropping this in instead of using collections.OrderedDict or the one in gemini_utils.py
https://pypi.python.org/pypi/cyordereddict

this is in my lazy-deserialize branch.


Add string for too many custom object requirements

We're limiting the number of custom object requirements for EAP to some yet to be determined number. We need a validation string for that (and for whatever the eventual GA limit will be).

@zendesk/dingo @zendesk/localization This is ready for review

👌 for string


[ADD] Check for input on deposit view before continue

Is your feature request related to a problem? Please describe.
At the moment it is possible to continue on message deposit view without or incorrect input.
Describe the solution you'd like
Check for following input in text fields:

[x] Amount: only positive, on Mac negative numbers are possible.
[x] Node address: only viable address format for respective chain
[x] Provider: having description optional as a placeholder and checking for correct address format
[x] Fee: having description optional as a placeholder and only positive numbers

if not, prompt user error message to complete missing or bad input.

Regarding the amount field, it is highly unlikely that users will enter a negative number for the bond, especially since we already use a numeric keypad to input the amount. Therefore, this scenario should not occur. Moreover, implementing this kind of validation would significantly increase the complexity of the deposit process due to its dynamic nature.
The node address is already being validated for Thor and Maya.


Reject creating property with name that case-insensitively matches an existing property

It's currently possible to create multiple properties that only differ by case: https://staging.getodk.cloud/#/projects/103/entity-lists/cacti
It's unlikely that users actually want such duplicate names. I think it's pretty easy to accidentally end up in this state if multiple form definitions update the same properties by introducing a case typo in one of them.
I believe we already reject Entity List names that are case-insensitive duplicates. I think we should do the same for property names.

Need help with the copy of the error message, specially the list of duplicate properties, does following look okay? Each bullet point shows name of the property provided in the uploaded Form definition and in the bracket name of the existing property is shown:<provided in the Form> (existing: <current in the Entity list>)

How about

This form attempts to create new Entity properties that match with existing ones except for capitalization:

Geometry (existing: geometry)
Species (existing: species)

We finished testing. The only thing we're not sure about is the message in case when I try to add a new form which contains 2 duplicate entities. When I upload a new version of an already publish form there's information :"This form attempts to create new Entity properties that match with existing ones except for capitalization". So when a user tries to add a new form with duplicate entities there's a bit less information what to correct in the form - is it expected?

This is an existing error message but we can certainly add list of duplicated properties here as well.

Tested with success! (issues were filed separately)

Tested with success!


Adjust visualizations for dark/light mode compatibility

This pr resolves issue #5361 and adjusts the background color of the visualizations, ensuring they adapt to both light and dark modes. The overall color scheme and theme remain unchanged.
Demo:
Review visualizations for dark_light mode compatibility #5361.webm

Hi @svrnm, could you please review my pr for this issue.
Thank you

kick

Thanks for the feedback. Lemme take a look and make the necessary changes

@SusanGithaigaN @svrnm - Here's an example of the kind of minimal changes I had in mind. I've done the update for only one of the images, you can work on the other images if you'd like:

#5436


Issue 662 explore globset

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
In #662 Charlie was asking if globset could speed up runtimes of file matching. After discussing a test strategy for the use case was decided.
What does this change do?
swaps out glob for globset entirely, Strips code of FilePattern as those are now compiled Globs which instead of being stored in Vec<FilePattern>s are grouped together in a GlobSet. is_excluded is modified to reflect this change and now takes in GlobSets.
What is your testing strategy?
Compiled the base image using glob and compiled altered code, per Contributing guide, benchmarked using hyperfine. Based on the discussion in #662 kneecapped the linter.rs#lint_path function to immediately return default Diagnostic, in order to exclusively test path discovery. below are current code state benchmarks.

Is this related to any issues?
#662 - as above mentioned
Have you read the Contributing Guidelines?

[x] I have read the Contributing Guidelines

Thank you for this PR! Let me know if you're up for tackling the comments.

I think that's all your reviews addressed.
Benchmarks for me are still showing ~10 ms improvement even after changes. Do LMK if there are any other changes you'd like to see. I won't be on here over Thanksgiving weekend, but we can continue going back and forth on changes after that if any are needed.

Great, thanks! I'll try to get this merged in the next few days.

@CelebrateVC - Thank you for this! I ended up making some tweaks to restore FilePattern (rather than using a tuple with Option), and moved the GlobSet stuff out of Configuration and into Settings which (I think) simplified a few things.


SUBACK fixed header, 1st byte

Expected behavior
fixed header should be 0x90
Actual behavior
it is 0x92
Steps to reproduce
connect, subscribe to any topic
Netty version
4.1
JVM version (e.g. java -version)
1.7
OS version (e.g. uname -a)
ubuntu 18.04 bionic beaver LTS

@matfil would you be interested in providing a PR ?

@matfil Can you please provide more information for example which broker you are used ?  I checked test and it's look properly with SUBACK(9).

Closing as no follow up provided


What is the purpose of data/personalize.toml file?

All the params in data/personalize.toml can be shifted to config.toml and the about section can be shifted to an _index.md file in the content directory.
Advantages:

Single configuration file (config.toml).
Seems to be the standard way based on most of the themes I've used (Could be wrong on this one).
Possible to embed raw HTML in about section.
Syntax highlighting for about section html / markdown.

Hey @suyash192 , thanks for the suggestion.
I had kept a different file to keep it decoupled in the beginning.
I think it all makes sense and this change will make the setup easier.
We can go ahead this.
Mind sending a PR?
Or let me know if you aren't interested in contributing, I'll be glad to make the changes.

@invinciblycool Just submitted a PR #9. Please check if everything is alright.


Modifying files with only types doesn't trigger rebuild. No errors thrown by fork-ts-checker-webpack-plugin.

I'm using rspack + fork-ts-checker-webpack-plugin with a pretty simple configuration:
const isDev = true;
const isHot = true;

module.exports = {
    target: 'browserslist',
    mode: isDev ? 'development' : 'production',
    entry: path.resolve(__dirname, 'src/main.ts'),
    context: path.resolve(__dirname),
    devtool: isDev ? 'cheap-module-source-map' : false,
    output: {
        filename: isHot ? '[name].js' : '[name].[contenthash].js',
        assetModuleFilename: '[name][ext]',
        clean: true,
        scriptType: 'module',
        ...
    },
    devServer: {
        host: 'localhost',
        port: 4200,
        headers: { 'Access-Control-Allow-Origin': '*' },
        open: false,
        compress: false,
        client: {
            overlay: {
                errors: true,
                runtimeErrors: false,
                warnings: false,
            },
        },
        hot: isHot,
    },
    plugins: [
        isHot && new RefreshPlugin(),
        new ForkTsCheckerWebpackPlugin({
            typescript: {
                configFile: path.resolve(__dirname, './tsconfig.app.json'),
                mode: 'write-references',
            },
        }),
    ...
};

The problem is, if I make a change to a file that only contains type, like a .d.ts file, no rebuild will be triggered, and I assume therefore, fork-ts-checker-webpack-plugin will not know to run either. Interestingly, the browser DOES refresh when I make a change.
This contrasts with the behavior of webpack-dev-server with fork-ts-checker-webpack-plugin, which responds to all file changes.

This is actually worse than I thought. If I make a change to a type that results in an error, ForkTsChecker wont pick up on the error even if I trigger a rebuild from the dev server in a regular file.


check sha256 fingerprint

download file
create the checksum file
check fingerprint
unarchive
remove archive

Shouldn’t the sha sum be an arg?

It depends on how we are building the image :
is it using --build-arg ?
or every time a version upgrade occurs the Dockerfile is changed ?
To be consistent, if VERSION is ARG then SHA256SUM should also be ARG
However, FILENAME should not be ARG but ENV in my opinion
since it build using VERSION otherwise the build stage could be broken this way :
docker build -t linkyard/docker-helm --build-arg FILENAME='foo' .
What do you think ?

I see that, this was previously addressed with the following commit
https://github.com/linkyard/docker-helm/commit/3fea824b7130841be07b396c40efbcfc3e5c9572

ENV is for run-time
ARG for build-time

@tmaier is right
But this is a multi stage build, in the final image here is what environnement contains :
env
HOSTNAME=903c4eca0f72
SHLVL=1
HOME=/root
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/

Very good point! Sorry I’m always a bit unsure when to use which.
So let’s change both to env


Enhance tracks ui

Coming from this GCI task and earlier issue #850
Changes:

TracksActivity:

[x] Replace SessionDetailActivity with a persistent bottom sheet (implementation from design support library On second thought, adding a transition like this example might be a better idea; the only thing that needs to be changed is the transition, so the original activity structure can be kept the same.
[ ] Make bookmark button add bookmark

TracksFragment:

[ ] Reduce each item to one line, or add description text to second line
[x] Edit item layouts to conform with list specs

I'm done! PR: #861
I realise that the "bookmark button" on Track cards is acting more like a status indicator currently, and there already is description text implemented, just not in the sample data.


how to set Sampling Configuration for same operation name with different request URI

Reqirement
for example, I have a service. Service have two http interface, and both are POST method:

http://localhost/decrypt
http://localhost/encrypt

I want to set different sampling for interfaces above:
{
  "service_strategies": [
    {
      "service": "myservice",
      "type": "probabilistic",
      "param": 0.8,
      "operation_strategies": [
        {
          "operation": "encrypt",
          "type": "probabilistic",
          "param": 0.4
        },
        {
          "operation": "decrypt",
          "type": "probabilistic",
          "param": 0.6
        }
      ]
    }
  ]
}

Main Question
Because all operation name are http method, how can I set different sampling configuration for them?
Thinking
1, I want to change operation name by ServletFilterSpanDecorator, but it performs after sampler action.
2, According to #42 and #45, it is not recommended to change operation name. Two reasons as following:

request URI may have multiple pattern. /user/{id}
high cardinality

(1) request URI may have multiple pattern.
If resolves multiple pattern problem, jaeger-client maybe need to implement pattern resolver.
(2) high cardinality. It is appreciated that talk more details about high cardinality, such as high cardinality affects what(storage? query? or others?) @pavolloffay

(2) basically, it violates the semantics. Different components in a tracing system might rely on it - for instance analytics pipeline which aggregates data.
One solution would be to set sampling.priority tag on the span. However this will sample all spans.
We didn't think about sampling indications when designing span decorator, otherwise, we could have passed span builder instead of span.
The other solution might be to support tag_srategies in jaeger. cc) @yurishkuro

@pavolloffay thanks for quick reply. Two more questions.
1, that looks like there is no solution form how can I set different sampling configuration for them? question, is that right?
2, Even if Adaptive Sampler is avalible, it can not resolve this quesiton. Because it bases on span operation name too. Is that right?

1, that looks like there is no solution form how can I set different sampling configuration for them? question, is that right?

If the operation name is always the same no.

2, One of goal of Adaptive Sampler is to resolve starvation problem. Even if Adaptive Sampler is avalible, it can not resolve this quesiton. Because it bases on span operation name too. Is that right?

It could work, we would add URL tag to span builder.

thanks for replay. no more question.


Populate network types from config

Added function for setting network types from external side;
Description
This patch allows to populate network types from external user's side. It might be data from yaml config or simple string slice.
Since function for creating network type from string is private we can't move this function to user side.

Hey @r-novel thank you so much for the patch.
What do you think of exporting the function to do string -> NetworkType instead? Since we have SetNetworkTypes already this will cause some duplication. Pushback if you disagree, totally subjective :)


bids() returning Path instead of str breaks workflows

It looks like returning Path objects instead of str can break things in some workflows.
e.g. using snakemake's multiext with bids() as here throws an error because it tries to join a Path and a str with +.
Traceback (most recent call last):
  File "/local/scratch/pypoetry_venv/snakebids-JiNcMeMJ-py3.8/lib/python3.8/site-packages/snakemake/__init__.py", line 593, in snakemake
    workflow.include(
  File "/local/scratch/pypoetry_venv/snakebids-JiNcMeMJ-py3.8/lib/python3.8/site-packages/snakemake/workflow.py", line 1186, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "/local/scratch/snakedwi/snakedwi/workflow/Snakefile", line 65, in <module>
  File "/local/scratch/pypoetry_venv/snakebids-JiNcMeMJ-py3.8/lib/python3.8/site-packages/snakemake/workflow.py", line 1186, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "/local/scratch/snakedwi/snakedwi/workflow/rules/prepdwi.smk", line 16, in <module>
    shell('cp -v {in_file} {out_file}')
  File "/local/scratch/pypoetry_venv/snakebids-JiNcMeMJ-py3.8/lib/python3.8/site-packages/snakemake/io.py", line 1192, in multiext
    return [flag(prefix + ext, "multiext", flag_value=prefix) for ext in extensions]
  File "/local/scratch/pypoetry_venv/snakebids-JiNcMeMJ-py3.8/lib/python3.8/site-packages/snakemake/io.py", line 1192, in <listcomp>
    return [flag(prefix + ext, "multiext", flag_value=prefix) for ext in extensions]
TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'

In hippunfold, things also get broken -- though I'm not exactly where it specifically breaks, as the failure manifests as a dag error in that workflow.  I suspect it may be related to rules like this
Building DAG of jobs...
WorkflowError:
MissingInputException: Missing input files for rule copy_to_results:
results/work/sub-001/surf/sub-001_hemi-L_space-T2w_den-0p5mm_label-hipp_surfaces.spec
WorkflowError:
    MissingInputException: Missing input files for rule copy_to_results:
    results/work/sub-001/surf/sub-001_hemi-L_space-T2w_den-0p5mm_label-hipp_gyrification.shape.gii
    WorkflowError:
        MissingInputException: Missing input files for rule copy_to_results:
        results/work/sub-001/surf/sub-001_hemi-L_space-T2w_den-0p5mm_label-hipp_surfarea.shape.gii
        CyclicGraphException: Cyclic dependency on rule warp_gii_to_native.

@pvandyken do you have any objections to going back to have bids() ultimately cast to str when returning, so we can fix these issues? The issue with multiext seems to indicate snakemake maybe isn't completely compatible with Path objects.. Do you have any existing workflows or use-cases where bids() returning Path is needed?

That's annoying. My apologies, I made that change under the presumption that Snakemake fully supported Paths, but clearly did not do my due diligence checks. We can definitely revert it.
It's something I'd still advocate for in the future, though with the realization now that it's a breaking change. I'm going to raise the multiext thing as an issue on Snakemake. I'm curious what's going on in the second error, although I can't makes heads or tails of it without the full context.

Yea I see the benefit of having bids() return Path.. For the hippunfold workflow would take some digging through the rules to see how it is actually breaking..  once snakemake fully supports Path we can revive returning it in bids() and try to make our workflows compatible.

In hindsight it was definitely a naive decision to just switch the return type like that. My own workflows generally don't do complicated logic with paths, and when they do, I always convert to Path() anyway, but I wasn't thinking at all behind that. So I'll be sure to raise it as a discussion point next time first

Would have caught this if I ran the PR with hippunfold or some other workflows initially -- wonder if we should add some test cases at some point that pull and dry-run some stable snakebids workflows? something to think about..


[CP] Do not format the messages file for gen-l10n

issue_link
https://github.com/flutter/flutter/issues/119594
Commit Hash
4ae2d3b6dfafbeafeb0957aa38b6f3d3634716e3
Target
stable
pr_link
https://github.com/flutter/flutter/pull/119770
Impacted Users
Who used to have untranslated fields after they upgraded to Flutter 3.7 if they use format during gen-l10n.
Impact Description
The l10n tool should not use dart format for the untranslated message file because it cannot be formatted by dart format, which will cause the generator to fail.

See also: https://github.com/flutter/flutter/issues/119594#issue-1563556261.
Workaround
Not use format for gen-l10n.
Risk
low
Test Coverage
yes
Validation Steps
No response

cc @christopherfujino @thkim1011

Am I understanding it correctly that this issue only affects invocations of flutter gen-l10n --format? In which case, wouldn't the workaround be not using the flag --format?

Am I understanding it correctly that this issue only affects invocations of flutter gen-l10n --format? In which case, wouldn't the workaround be not using the flag --format?

Yeah that's correct.

Actually moving this one back to review until somebody with more context approves it.

The consensus was that there's currently a workaround to this issue by disabling the format flag, so we should rather wait for this to land in the next release. cc @christopherfujino


trying to launch error

Warning: OpenCV not installed. To use facial recognition, make sure you've properly configured OpenCV.
HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: /microphone?enabled=False (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7ff7334de890>: Failed to establish a new connection: [Errno 111] Connection refused',))
Traceback (most recent call last):
File "bot.py", line 679, in
bot.start()
File "bot.py", line 49, in start
requests.get("http://localhost:8090/clear")
File "/usr/local/lib/python2.7/dist-packages/requests-2.18.4-py2.7.egg/requests/api.py", line 72, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.18.4-py2.7.egg/requests/api.py", line 58, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.18.4-py2.7.egg/requests/sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.18.4-py2.7.egg/requests/sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.18.4-py2.7.egg/requests/adapters.py", line 508, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8090): Max retries exceeded with url: /clear (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7ff7334de8d0>: Failed to establish a new connection: [Errno 111] Connection refused',))

HTTPConnectionPool(host='localhost', port=8080): Max retries exceeded with url: /microphone?enabled=False (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f63a756c890>: Failed to establish a new connection: [Errno 111] Connection refused',))
Found face
Traceback (most recent call last):
File "bot.py", line 679, in
bot.start()
File "bot.py", line 53, in start
recognizer, audio = self.speech.listen_for_audio()
File "/home/cowboysdude/Smart_Mirror/speech.py", line 33, in listen_for_audio
m = sr.Microphone()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 79, in init
self.pyaudio_module = self.get_pyaudio()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 113, in get_pyaudio
raise AttributeError("PyAudio 0.2.11 or later is required (found version {})".format(pyaudio.version))
AttributeError: PyAudio 0.2.11 or later is required (found version 0.2.8)

PyAudio 0.2.11 is installed......

post the output of the following code
python -c 'import speech_recognition as sr; print(sr.Microphone.list_microphone_names())'

Also I suggest you to do this again:
pip install -r requirements.txt
pip install --global-option='build_ext' --global-option='-I/usr/local/include' --global-option='-L/usr/local/lib' pyaudio

Requirement already satisfied: pyaudio in /usr/local/lib/python2.7/dist-packages
Also I continue to get the 8080 error even though I have changed all the ports to 8090 in the bot.py......

try this to check version. Sometimes it happen. Also, clear the cache
import speech_recognition as sr;print(sr.version)
import pyaudio as p;print(p.version)

try this to check version. Sometimes it happen. Also, clear the cache
import speech_recognition as sr;print(sr.version)
import pyaudio as p;print(p.version)
Neither of those commands work.......
bash: syntax error near unexpected token p.version' bash: syntax error near unexpected token sr.version'

Warning: OpenCV not installed. To use facial recognition, make sure you've properly configured OpenCV.
Used wrong endpoint for microphone debugging
Found face
Traceback (most recent call last):
File "bot.py", line 679, in
bot.start()
File "bot.py", line 53, in start
recognizer, audio = self.speech.listen_for_audio()
File "/home/cowboysdude/smartmirror/speech.py", line 33, in listen_for_audio
m = sr.Microphone()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 79, in init
self.pyaudio_module = self.get_pyaudio()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 113, in get_pyaudio
raise AttributeError("PyAudio 0.2.11 or later is required (found version {})".format(pyaudio.version))
AttributeError: PyAudio 0.2.11 or later is required (found version 0.2.8)

I couldn't understand the exact issue which is causing the error. So lets try few commands:
sudo apt-get install portaudio19-dev
sudo apt-get install python-pyaudio
sudo apt-get install libjack-jackd2-dev portaudio19-dev
brew install ffmpeg
also try to install alsa.lib
update brew
Atleast something should work. Hit and try

Used wrong endpoint for microphone debugging
Found face
Traceback (most recent call last):
File "bot.py", line 679, in
bot.start()
File "bot.py", line 53, in start
recognizer, audio = self.speech.listen_for_audio()
File "/home/cowboysdude/smartmirror/speech.py", line 33, in listen_for_audio
m = sr.Microphone()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 79, in init
self.pyaudio_module = self.get_pyaudio()
File "/usr/local/lib/python2.7/dist-packages/speech_recognition/init.py", line 113, in get_pyaudio
raise AttributeError("PyAudio 0.2.11 or later is required (found version {})".format(pyaudio.version))
AttributeError: PyAudio 0.2.11 or later is required (found version 0.2.8)

For the record I do in fact have 0.2.11 installed and why it's not recognizing that is beyond me......

python -m speech_recognition try this . This error is beyond the scope of my knowledge. For me it just worked what we can do is try some methods. Also do check your pyaudio version manually before running the code.

It continues to tell me I don't have pyaudio 0.2.11 installed and will not install it.  Tells me I have the latest version 0.2.8
Not sure but it seems to be an issue for others as well not just your package but many other people trying to use the newest pyaudio.......

Yeah NOW I'm not happy.  My stable version of MM now automatically starts and I cannot kill it.


BootTime

Hi there Marshall.
Time to Boot went from about the same as the web version(2-3sec) to 20-30sec.
Didn't have this issue before christmas.
I checked for a similar one but can't find it so maybe it's just me ? (although i reinstall it)
Thanks.

@raphael22 No update was released over that time, the only explanation is something changing on your machine.  Maybe a new anti-virus update or something 🤔


Add SELinux packages to toolchain

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[ ] The toolchain has been rebuilt successfully (or no changes were made to it)
[ ] The toolchain/worker package manifests are up-to-date
[ ] Any updated packages successfully build (or no packages were changed)
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

The chroot environment requires some SE Linux packages to be available. tdnf was silently failing due to a missing libselinux library. This would result in occasional "corrupt RPM" errors. These changes make the toolchain and chroot successfully support SE Linux.
Change Log

Update misc signature files via tooling to avoid diffs in the future
Add libselinux runtime requirement to rpm (No version bump since we have not successfully build this package yet)
Add libsepol, libselinux to pkggen manifests
Add finger to pkggen & toolchain manifests
Update update_manifests.sh to include selinux, finger packages
Add finger to the toolchain build
Set --rpmverbosity=y when cloning using tdnf inside rpmrepocloner.go
Small update to PR template to suggest a toolchain validation command to run.

Does this affect the toolchain?

YES
Test Methodology

Full local toolchain build (in progress)
Full local package build (in progress)
Full local image build (todo)
aarch64 full build (todo)

I wanted to get the PR up prior to finishing testing, so people could review it.
I probably want to do:

rebase to tip of 1.0-dev
aarch64 build
finish the x86_64 build
quick smoke test of the resulting image

Need a tooling update to properly resolve this. We have always had the assumption that shadow-utils is fully supported by the toolchain, which is no longer the case (the selinux packages bring a lot of dependencies with them).
I see two options here:

We accept this, and add all the required packages into the toolchain (ie finger, and now also cyrus-sasl, etc...). Not sure of the full list yet
We allow shadow-utils to build without some of these requirements in the toolchain, and rebuild it later (bootstrap).

This means we need to fix the SearchAndClone() function, currently it can't handle referencing unbuilt nodes when searching for a dependency. (ie we want /usr/sbin/groupadd, which means we need shadow-utils. The current implementation 'caches' it from the toolchain (effectively a no-op), but tdnf notices that it needs additional dependencies (such as cyrus-sasl) which we haven't built yet it will fail.
Obviously we can get this far, and built packages. We would need to find a way to extract the dependencies from the 'cached' package and add nodes to our graph.

Since you're already here: could you fix the "as" typo as well? I always forget to fix that myself and it's an eyesore.:)

Refers to: .github/pull_request_template.md:48 in c6e48ac. [](commit_id = c6e48ac4e116f131dd67e82f8f3778f6a29ea14a, deletion_comment = False)

chroot_and_install_rpms systemd

We're doing this earlier now, so we should probably remove it here. No need to install twice.

Refers to: toolkit/scripts/toolchain/build_official_toolchain_rpms.sh:512 in c6e48ac. [](commit_id = c6e48ac4e116f131dd67e82f8f3778f6a29ea14a, deletion_comment = False)

Now targeting SE Linux stabilization branch.

rebased
added toolchain build for cyrus-sasl, needed by openldap


Request to Adding an MIT License

Hi,
We are interested in this repository and want to use the source code in our own commercial product.
Would you please add an MIT license to this repository?
The license can be found as following link:
https://choosealicense.com/licenses/mit/
Thanks in advance.

Hi @bckk-yzhou ,
Thanks for considering this project in your project. That really good to know that this library is becoming helpful to the community. I am also available for freelancing in my spare time, if there is any opportunity, please let me know.
Thanks,
Sauvik.


Communication common api types

Error definition follows API guidelines format.
Identifier definition matches JS identifier models in the SDK.
I considered type instead of kind but stuck to kind as it's recommended as a common property name in the API guidelines and is identical to the format in TypeScript/JavaScript.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

Common types for communication services, who will use those before going GA.

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
n/a

When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
n/a I guess?

If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

The linter rule that forbids Required and Readonly on the same property doesn't make sense imo and it conflicts with how autorest generates code for TypeScript.
https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/openapi-authoring-automated-guidelines.md#r2056-requiredreadonlyproperties

@anuchandy This is ready for review, can you help?
If you need more context, feel free to ping me on Teams. @tjprescott has already reviewed communication swaggers in the past but I didn't want to reassign without comment.

Looks good to me now. Lets merge this puppy so we can hook it up to the chat swagger for the review @DominikMe


CPU usage increases with time in v2.2.0<=

Bug reason is not yet confirmed and this is opened to keep a track on it.
Describe the bug
There is an OBSERVATION raised by @mostoview and myself. CPU usage increases with time in v2.2.0<= , possibly due to changed wrtc library (last properly working version is v2.1.3)
I have noticed increased CPU usage as well with newer haxball.js versions, but not yet confirmed the reason.
CPU load rises with empty rooms with time, after one day increasing ~100x (e.g. from 0.4% to 40%).
To Reproduce
Run a room with haxball.js==2.1.3 and haxball.js@latest and observe the process CPU usage.
Expected behavior
Not increasing CPU load.
Device (please complete the following information):

node 18, node 20, node 22
ubuntu 24, ubuntu 22

Additional context
Benchmarking the process between versions will take some time, but Issue is opened to see if someone has a similar overview and could share more findings.

I'm currently running all servers with koush/wrtc and I didn't notice any CPU usage improvement.


Browser reload or refresh

I'd like to check if there's a better way to handle if user is idle and screen is locked, if user reloads the page I want the screen to stay locked. Currently I'm saving a flag in local storage and on app.run when app is loading I check for flag status, if true I set the timeout to 0.1 seconds. Let me know if there's a better way of locking the screen, as I'd like to maybe call my API to save the flag in database to increase the security. Is there a better way to lock the screen programatically?
`app.run(['authService', 'Idle', function(authService, Idle){
   if(authService.screenLocked){
       Idle.setIdle(0.1);
       Idle.setTimeout(0.1);
       Idle.watch();
   }

}]);`

Well since nobody want's to reply, I will add that it seems to be working when I reverse the order of functions executing. Now after the page is refreshed the lock screen comes back.
Idle.watch();
Idle.setIdle(0.1);
Idle.setTimeout(0.1);


Update jackson-annotations, jackson-core, ... to 2.16.1

About this PR
📦 Updates

com.fasterxml.jackson.core:jackson-annotations
com.fasterxml.jackson.core:jackson-core
com.fasterxml.jackson.core:jackson-databind

from 2.16.0 to 2.16.1
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.jackson.core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.fasterxml.jackson.core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #1959.


Call IsEnabled with Serilog's instead of LibLog's log level

Also deduplicate some code by translating the level before branching the code.
This is the error that occurs when calling logger.Log(severity, null) where logger is a ILog interface and severity is of type LogLevel:
System.InvalidCastException was unhandled
  _HResult=-2147467262
  _message=Specified cast is not valid.
  HResult=-2147467262
  IsTransient=false
  Message=Specified cast is not valid.
  Source=Anonymously Hosted DynamicMethods Assembly
  StackTrace:
       at lambda_method(Closure , Object , Object )
       at Flowcal.Logging.LogProviders.SerilogLogProvider.SerilogLogger.Log(LogLevel logLevel, Func`1 messageFunc, Exception exception, Object[] formatParameters) in f:\src\flowcal-foundation\src\Logging\Flowcal.Logging\App_Packages\LibLog.4.2\LibLog.cs:line 1524
       at Flowcal.Logging.LoggerExecutionWrapper.Log(LogLevel logLevel, Func`1 messageFunc, Exception exception, Object[] formatParameters) in f:\src\flowcal-foundation\src\Logging\Flowcal.Logging\App_Packages\LibLog.4.2\LibLog.cs:line 614
       at FCLog.Logger.IsEnabled(LogLevel severity) in f:\src\flowcal-foundation\src\Logging\Flowcal.Logging.COMInterop\Logger.cs:line 37
  InnerException:

appveyor seems to be broken for all branches.  Is it OK if I ignore that?

I'll look into AppVeyor shortly..
On 13 January 2016 at 23:41, Ben Brandt<EMAIL_ADDRESS>wrote:

appveyor seems to be broken for all branches. Is it OK if I ignore that?
—
Reply to this email directly or view it on GitHub
https://github.com/damianh/LibLog/pull/95#issuecomment-171460442.

@damianh, could you please merge this one as well?

Merged (via pull & rebase). Thanks!

4.2.5 up on nuget.org


System.IO.DirectoryNotFoundException - Nexus - Mod Manager Download

*************** Error message ***************
System.AggregateException: One or more errors occurred.
**************** System Info ****************
Operating system:  Windows 11 64-bit
Program version:   1.12.6
User agent:        Fo76QuickConfiguration/1.12.6 (Windows NT 10.0.22631.0; x64) .NETFramework/4.7.2
Running as admin:  No
System culture:    English (United States)
App locale:        en-US
Game edition:      Steam
**************** Stack Trace ****************
If any files are listed (like "at ... in ...*.cs:line 123"):
Those are files on my computer, so don't worry if you can't find them.
System.AggregateException: One or more errors occurred.
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at Fo76ini.Mods.ModInstallations.DownloadFile(String url, String path, Action1 ProgressChanged) in X:\Repos\Fo76\Fo76ini\Mods\ModInstallations.cs:line 263    at Fo76ini.Mods.ModInstallations.InstallRemote(ManagedMods mods, String nxmLinkStr, Boolean useSourceBA2Archive, Action1 ProgressChanged) in X:\Repos\Fo76\Fo76ini\Mods\ModInstallations.cs:line 220
at Fo76ini.FormMods.<>c__DisplayClass93_0.b__0() in X:\Repos\Fo76\Fo76ini\Forms\FormMods\FormMods.cs:line 1207
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
************** Inner Exception **************
System.Net.WebException: An exception occurred during a WebClient request.
************** Inner Exception **************
System.IO.DirectoryNotFoundException: Could not find a part of the path 'F:\Games\Steam\steamapps\common\Fallout76\Quick Configuration\Downloads\Nuka Label Fix (BA2)-1260-1-0-1639442043.7z'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access)
at System.Net.WebClient.DownloadFileAsync(Uri address, String fileName, Object userToken)

After enabling "Associate with 'Mod Manager Download' links", and clicking the related download button on the nexus, QC app freezes on the downloading screen and throws the error shown above.

Unable to reproduce with given steps.
Please try shortening the path to the utility, ie:
'F:\Games\Steam\steamapps\common\Fallout76\QC'
instead of
'F:\Games\Steam\steamapps\common\Fallout76\Quick Configuration'.
You can also try running as admin, or please verify you selected the correct path when launching the program for the first time.
Example:

Thank you, shortening the path solved my issue!


when i change a model how to update the cached redis obj

when i change a model how to update the cached redis obj

I am sorry for replying late.
I will add method to evict old cached data, soon.


Various Onkyo fixes

Various small fixes:

Register an entity service, and let HA tackle dispatch to the correct entity
Moved zone checking and HA update on message received to the entities (this will simplify things when we use a config entry)
Only call close() once (all zones are sharing the same connection)
Backfill when added to HASS, instead of in async_setup_platform (once again, will simplify things when we use a config entry)
self._avr instead of self.avr
Mark some more async-safe functions as callback

@winterscar @klaashoekstra94 I did some basic testing, but I can't test more than one zone, nor setting HDMI output (I believe the latter is broken prior to this PR anyway, so at least I'm not making things worse :) )

I'm also getting:
2020-07-31 12:28:46 WARNING (MainThread) [pyeiscp.connection] Closing connection to AVR
2020-07-31 12:28:46 WARNING (MainThread) [pyeiscp.protocol] eof from receiver?

On shutdown (even before my changes)

@winterscar @klaashoekstra94 I did some basic testing, but I can't test more than one zone, nor setting HDMI output (I believe the latter is broken prior to this PR anyway, so at least I'm not making things worse :) )

Do you mean multiple zones and setting HDMI output don't work, or that you don't have the hardware to test it?

No that they don't work -but rather that I can't test. I don't have a second zone connected and I can't change HDMI output (generally, not just through the integration), because of a specific issue in my environment that somehow screws up the connection between the receiver and the TV and the only way to fix it is reset the receiver to factory defaults, so it's not a process I want to go through :)

I'm also getting:
2020-07-31 12:28:46 WARNING (MainThread) [pyeiscp.connection] Closing connection to AVR
2020-07-31 12:28:46 WARNING (MainThread) [pyeiscp.protocol] eof from receiver?

On shutdown (even before my changes)

The Closing connection to AVR is from here.
It shows because it is a warning log, although I agree it should be in info log.
The eof from receiver? is from here
This is in the connection lost callback of of the asyncio protocol.
It makes sense this is triggered after calling protocol.transport.close here
But I don't think that at this level, there is a way of knowing if we purposely closed the connection, or if something went wrong.
On the other hand, if something goes wrong, we already get logging of the _reconnect function.
Should we remove the logging, or at least change it to info?

I tested setting the HDMI output and this does not work yet.
I think I already fixed it, but I cannot add code to this PR.
Should we merge this one and then continue fixing stuff?

You can make a PR against my branch, but we might be going too deep (feels like Inception :))
Want to tell me how you fixed it and I'll it here?

Should we remove the logging, or at least change it to info?

I think the first one should definitely be changed to info - closing is a normal part of the lifecycle.
As for the second one (the eof), ideally we'd have a way to gracefully handle a shutdown, or at least differentiate between the states. If we don't, I say we change to info as well.

You can make a PR against my branch, but we might be going too deep (feels like Inception :))
Want to tell me how you fixed it and I'll it here?

Change output to hdmi_output in async_select_output, like this:
    async def async_select_output(self, hdmi_output):
        """Set hdmi-out."""
        self._update_avr("hdmi-output-selector", hdmi_output)

And I also added this in services.yaml, for completeness:
# Onkyo component services.yaml entry

onkyo_select_hdmi_output:
  description: Selects the HDMI output of an Onkyo AVR
  fields:
    entity_id:
      description: Name of the Onkyo entity to set
      example: "media_player.onkyo_avr"
    hdmi_output:
      description: Select HDMI output
      example: 'yes'

After going through the docs for connection_lost() I think that log should simply be removed. An abrupt disconnection will populate exc. If it's None, everything is ok.
It could simply be changed to:
def connection_lost(self, exc):
    """Called when asyncio.Protocol loses the network connection."""
    if exc is not None:
        self.log.warning("Lost connection to receiver: %s", exc)

Change output to hdmi_output in async_select_output, like this:

Great, I pushed that change.
As for services.yaml it's a bit more complicated - now that it's an entity service it can potentially also accept area ids, etc... I'll try to see what other integrations are doing. In the mean time, if setting the output works for you I think we can merge this.

After going through the docs for connection_lost() I think that log should simply be removed. An abrupt disconnection will populate exc. If it's None, everything is ok.
It could simply be changed to:
def connection_lost(self, exc):
    """Called when asyncio.Protocol loses the network connection."""
    if exc is not None:
        self.log.warning("Lost connection to receiver: %s", exc)

I also just read this and I agree with you. I can change it in my repo, but I'll have to make a new PR against @winterscar his pyeiscp repo.

Change output to hdmi_output in async_select_output, like this:

Great, I pushed that change.
As for services.yaml it's a bit more complicated - now that it's an entity service it can potentially also accept area ids, etc... I'll try to see what other integrations are doing. In the mean time, if setting the output works for you I think we can merge this.

I tested setting the output and it works with the code as you have it now!
I did check out some services.yaml files of other components, but I did not check if they were entity services or integration services. But by implementing the services.yaml file, we atleast get a description and example data in the developer tools services tab, which I think is quite important.

Yeah, I looked at a few integrations and it looks like they're all just using entity_id even though you can pass an area. I'll push this now.


[Access Request] table 5717 "Item Cross Reference" procedure  CreateItemVendor

Can you please change the access modifier of  procedure CreateItemVendor in  table 5717 "Item Cross Reference"
     // >>>>>>>>>>>>>>>>>
    //local procedure CreateItemVendor()
    procedure CreateItemVendor()
    // <<<<<<<<<<<<<<<<
    begin
        if ("Cross-Reference Type" = "Cross-Reference Type"::Vendor) and
           ItemVend.WritePermission
        then begin
            ItemVend.Reset();
            ItemVend.SetRange("Item No.", "Item No.");
            ItemVend.SetRange("Vendor No.", "Cross-Reference Type No.");
            ItemVend.SetRange("Variant Code", "Variant
...

This table replaced by Item Reference in 17.0 and will be obsoleted in 18.0. Do you really need to use it?

Excuse me. We have overlooked that. Of course, you are welcome to close this issue.


Add tvOS deployment target

@suguru
I Added tvOS deployment target.
I want to use this library in tvOS.
I tried to test lightly, it will work well in tvOS.

I close this since the conflict


vtkpack (to dataSetList h5 file)

new vtkpack command (only a list of files as arguments)
vtkMesh: compute volumes from pyvista
vtkMesh: can be initialized by a hdf5 group "mesh" with attribute "unsvtk" (cell connectivity and nodes positions only)


Docs/Concept: Handling basic form errors using "errors" or alternative concept?

Coming from REST like a lot of other people I wonder how to differentiate between actual system errors and more trivial form errors.
I know that I can throw exceptions which are transformed into ApolloError instances. This feels like a typical 5xx error in HTTP. In our case, for form field errors and/or general system warnings (think more of 4xx errors in HTTP) it would be interesting to have a list of invalid forms with error codes attached to all of them.
There is also the idea of normalization of values e.g. auto correct slightly wrong written street names, mismatching zip codes, etc.
For mutations we receive basically a data structure with data and errors. data returns us the data which is defined in the query part of the mutation where errors most of the time is relevant for real "hardcore" errors where the system fails to fulfill the request.
Together with my team we figured it would be sensible to add another top-level key on the server side. After some discussion we came with the following data structure:
- data
- errors
- request
  - input
    - name: { valid: true, normalized: "Henry Barmer" }
    - address
      - zipCode: { valid: false, normalized: "", errors: [{ code: 456, message: "This zip code does not exist" }] }
      - city: { valid: true, normalized: "" }
  - errors
    - { code: 123, message: "Form validation failed" }
    - ...

Our thinking:

We want to handle multiple field errors at once and inform the user about all errors.
We want an easy way to differentiate between system errors (status codes 5xx) and input errors (status codes 4xx)
We need a mapping of errors to form field ids (mutation variables) so that we can show the errors on their respective fields.

Our questions?

Is this something which somehow conflicts with the normal approaches to use Apollo/GraphQL?
How do you differentiate between the different levels of errors.
Is there some equivalent of status code for GraphQL?

(We are using apollo-react, apollo-client, express-apollo)

Fundamentally, GraphQL doesn't force you to use any particular kind of error handling system. You can create classes based on Error in order to create a structure similar to HTTP if you would like.
For your first point, what currently prevents you from presenting/handling all input errors at once? Is it that these errors are presented as responses to different queries, making it difficult to handle them in one block of code?
It seems that you can achieve your second point (i.e. differentiation between system errors and input errors) by subclassing ApolloError and creating an error type tree of your choosing rooted at that point.
For the third, I think this is possible pretty easily since this PR to graphql-js. I'm not sure if it is being worked on currently.
Please let me know if I have misunderstood any of your points.

I kind of think this is a concern at the application level rather than the library level.
The way we've been approaching it is to have the "status" of a mutation in the result type.
type SaveProjectResultType {
  success: Bool!
  validationErrors: [String!]
  newProject: ProjectType
}

Then your code for handling of the mutation result needs to check whether it was successful, and apply if not, display the validation errors.

@Poincare and @armstrjare make good suggestions. I’m also an advocate of just replicating some validation logic client side. It may be easier to implement and could provide a better user experience at a low cost. I’m going to close this for now. If you feel like you need more help on this I encourage you to open a question on Stack Overflow under the GraphQL tag as this is more of a general GraphQL design question 👍


Add "generic-hmac" Provider

This commit adds the "generic-hmac" Provider type for authenticating
webhook requests coming from notification-controller. I extended the
Forwarder notifier to accept an optional key used for generating the
HMAC. If the key is nil or empty no HMAC header is generated and the
forwarder behaves as before. If it is provided an X-Signature HTTP
header is added to the request carrying the HMAC.
I transformed the TestForwarder_Post test into a table-driven test
so that we can use the same setup and testing code for testing HMAC
and non-HMAC forwarder instances.
The Flux CLI will support this new type automatically as it doesn't validate the given type by itself (this is done by the API server using the CRD spec.
closes #99

Sorry, I broke the unit tests with my latest change. Will fix them right away.


review: psychiatric and mental disorders

A lot of existing resources seem to handle this poorly, and classify a lot of things as psychiatric that are not (or were considered this way historically). We need a review of this area

Example:

when combined with

makes all pain disorders neuroses

pain disorder has been obsolete. I converted this to a discussion


allow_None not enforced when set to False and the default value is None

Setting allow_None to False when the default Parameter value is None automatically sets it to True. I believe Param shouldn't be doing that, when allow_None is explicitly set to False this value should be enforced. The annoying bit being that for Parameters whose default default value is None (like Callable below) you'd have to provide a value that is not None. Unless this applies only after the Parameter has been instantiated, to allow it to be instantiated with None as the value for default with allow_None=False, but preventing it to be set to None afterwards, which I believe is what you can do now with ObjectSelector.
import param

class A(param.Parameterized):
    c = param.Callable(allow_None=False)

print(A.param.c.allow_None)
# True!

Just got hit by this too. Would expect the below to raise an exception when trying to instantiate the Viewer.
import param

class Viewer(param.Parameterized):
    data = param.DataFrame(allow_None=False)

viewer = Viewer()

Facing this issue as well.


S12: As a host I want to be able adjust the time given for each round, the number of rounds and as a user I want to be able to see these changes while they are happening. This will allow users to see the current game settings.

Acceptance Criteria

[ ] #61
[ ] #62


Fixes #3351. TabIndex with the same setter value but with wrong index return without set the correct value.

Fixes

Fixes #3351

Proposed Changes/Todos

[x] Check if the index also belong to the view.
[x] Add unit test to proof

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[ ] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

XUnit.Assert is contradicting itself, frankly. Using Equal/NotEqual causes failing on another unit tests.


"key" prop warning on column name containing icon

Using an icon in the column name returns a warning.
Expected Behavior
No warning if using an icon for a header column name
Current Behavior
index.js:1446 Warning: Each child in a list should have a unique "key" prop.
Check the render method of l. See https://fb.me/react-warning-keys for more information.
Steps to Reproduce (for bugs)

{ field: '', name: [<FontAwesomeIcon icon={['fas','sort']} color="gray" fixedWidth size="lg" />], options: { customBodyRender: (value) => { return <a href={/WorkItemDetails/${value.ID}}>... }, filter: false},},

Your Environment

Tech
Version

Material-UI
3.9.2

Material-datatable
0.3.8

React
16.8.3

browser

etc

@bluebeag

Can you try set name with no "[]"?
Do you see error when column name value something like "name 1" (name: "test 1").

@Diaver Removing the [] worked! Thank you!  This fix makes sense given the compiler thought it was a collection.

Solved per @Diaver solution


BROOKLYN-356: workaround, by increasing timeout

@neykov can you take a look please?

Looks good. Nice fix for the long running test.
Will merge after tests complete.


Enable aarch64/ppc64le

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Required by https://github.com/conda-forge/r-testthat-feedstock/pull/16


Update the signal-service URL

New client versions won't connect properly anymore, since the proxy rejects connections to the new URL.

Commenting to hopefully gain visibility for this PR.
This fixes the issue discussed on reddit here, where newer versions of Signal's mobile client will fail to connect to the signal proxy.
I have personally tested this modification and it works with Signal Android client v5.22.7.
Steps to apply this fix for those who come across this PR before it gets merged:

log in to your server, navigate to the Signal proxy directory Signal-TLS-Proxy/, and stop your server by executing sudo docker-compose down
go to the Signal-TLS-Proxy/data/nginx-relay folder
rename the old nginx.conf file to nginx.conf.bak
download the new nginx.conf file modified by u/Elsensee into the same folder; I will use wget wget -c https://github.com/signalapp/Signal-TLS-Proxy/raw/837dde482712dca05d1720933ab9b65b9f4804d1/data/nginx-relay/nginx.conf
now go back to the Signal proxy root folder Signal-TLS-Proxy/, do cd ../../
start up your proxy server again by executing sudo docker-compose up --detach
voila! now your Signal proxy should work properly!

Thanks for sending this PR and raising this issue. I just noticed it here, but also just updated the config file with all three of the currently valid hostnames for reaching the chat service after hearing about the issue from another channel earlier today.
I will go ahead and close it out as the latest in the repo fixes the issue.

Thanks for solving this @Elsensee , but I deleted  textsecure-service.whispersystems.org	signal-service; on line 12 before I got it working, apparently the proxy was still trying to connect to the old server before I removed that line


merge from arlac77/template-kronos-module,arlac77/template-github

README.md

docs(README): update from template

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   85.53%   85.53%
=======================================
  Files           8        8
  Lines         560      560
  Branches       67       67
=======================================
  Hits          479      479
  Misses         80       80
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8f955...475201d. Read the comment docs.

:tada: This PR is included in version 7.5.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Class 'Illuminate\Support\Facades\Http' not found

Hi guys. I'm getting this error:
Symfony \ Component \ Debug \ Exception \ FatalThrowableError (E_ERROR)
Class 'Illuminate\Support\Facades\Http' not found
Laravel: 6.20.13
In my controller:
use Illuminate\Support\Facades\Http;
use Kutia\Larafirebase\Facades\Larafirebase;
Can someone help me please?

Why you use this in your Controller: use Illuminate\Support\Facades\Http; ?
Larafirebase uses this inside. No need to use in your Controller ?

Hi @gentritabazi01,
I've removed the line and got the same error:
Symfony \ Component \ Debug \ Exception \ FatalThrowableError (E_ERROR)
Class 'Illuminate\Support\Facades\Http' not found

The error appear in this line:
(vendor/kutia-software-company/larafirebase/src/Services/Larafirebase.php)
$response = Http::withHeaders

Just checked, laravel has no support for Http Client <= 6.
We need to update package.

Check: Release 1.3.0


validate(&$value, &$error = null) and validateValue(&$value)

What steps will reproduce the problem?
I try to create "validator" class.
Validation can change a values under validation (like filter validator)
I wish use validate and nested validateValue functional
I can't change the value in this way.
I am right?
So... How about change signature? Or other way needed?
Additional info

Q
A

Yii version
2.0.13@dev

PHP version
7.1.11

Operating system

Sorry, can't get the problem from description.

@samdark
Signature of function can't provide &$value, only $value (this can't be redefine)
i.e. I can't create the validator, who will change $value outside of model

https://github.com/yiisoft/yii2/blob/b7d5393a08e5eb66cfcb917c278eea61bd483de6/framework/validators/Validator.php#L287-L340

Ah, that is correct.

What BC broken may be if we try to change a signatures?

Anything. Signature change is not for 2.0.

$value = 'uncnanged value';
$result = $validator1->validate($value, $errors);
$result = $validator2->validate($value, $errors); // in this line we have been change in $value

Another case - from tests
        $val = new TestValidator();
        $val->validate('abc');

same case
        $val = new TestValidator();
        $val->validate(someFunction('someValue'));

over 50 BC


[benchmark] Some questions about the details to generate files in step 1 during Video-based Generative Performance Benchmarking.

Hello, follow the instructions of step 1 in quantitative_evaluation, I obtain three files:

one file generated with generic_qa.json and run_inference_benchmark_general.py
one file generated with consistency_qa.json and run_inference_benchmark_consistency.py
one file generated with temporal_qa.json and run_inference_benchmark_general.py

Then, do I need to generate any other file? And how does them function in step 2? More specifically, if I want to evaluate correctness and detailed, which file generated in step1 should I input to the pred_path in step 2 command?

Hi @Aopolin-Lv,
Apologies for the late reply.
Note that the question-answer pairs (gt_file) are the same for correctness, detailed orientation and Contextual understanding.
So, In your case, you want to evaluate the correctness and detailed orientation criteria:
If you run the first step using the below command: the predictions are stored in --output_dir <output-dir-path>.
python video_chatgpt/eval/run_inference_benchmark_general.py \     --video_dir <path-to-directory-containing-videos> \     --gt_file <ground-truth-file-containing-question-answer-pairs> \     --output_dir <output-dir-path> \     --output_name <output-file-name> \     --model-name <path-to-LLaVA-Lightening-7B-v1-1> \     --projection_path <path-to-Video-ChatGPT-weights>
In order to evaluate the criteria, you will need to pass the same '--output_dir ' as the pred_path here.
Hope its clear now.


Tests all fail with mvn verify when there is an application tag in server.xml

Describe the bug
When using mvn liberty:dev the application and tests run perfectly. However, running the same tests with mvn verify fails, because the application is not deployed, testcontainer complains that it cannot find the war taht was just build.
To Reproduce
I found the reproduction to be a bit tricky. But I managed it as follows:
Check out the  https://github.com/openliberty/guide-microshed-testing.git openliberty guide
Alter the server.xml to look like this:
`
<featureManager>
    <feature>microProfile-4.0</feature>
    <feature>beanValidation-2.0</feature>
</featureManager>

<application location="guide-microshed-testing.war" type="war" context-root="guide-microshed-testing">
</application>

`
When I run mvn clean install I get the following message:

[ApplicationContainer] [WARNING ] CWWKZ0014W: The application guide-microshed-testing could not be started as it could not be found at location guide-microshed-testing.war.

And the tests all threw a 404 exception.
When removing the  tag, it will work properly.
The weird thing is, that I have seen it work when there was an  tag, but this is the minimal setup that I could reliably reproduce it. Sometimes adding and removing a feature seemed to make it work or fail, but I could not find any logic in it.
Expected behavior
I expect the test to succeed, since the .war was made just before in the package step:

[INFO] Building war: /home/vin/code/guide-microshed-testing/finish/target/guide-microshed-testing.war
And mvn liberty:dev also works just fine.

System information:

OS: Linux and Windows
Java Version: 8 and 11
MicroShed Testing Version: 0.9.1

Additional context
I had this in my own application, but managed to reproduce it in the microshed guide of openliberty. While trying to find the minimal reproduction recipe I did see it work and fail with the same configuration, so I hope that setup works correctly to reproduce.

@vzorge Could you please provide the output from running mvn verify or mvn install vs running the tests with mvn liberty:dev?

Attached two log outputs. I now notice it seems to find the application twice when using mvn verify. Perhaps that is the root cause?
liberty:dev
mvn verify

Thanks @vzorge, we will investigate this further. I am able to intermittently reproduce the same issue with the steps above. The tests seem to fail with mvn verify or mvn install about half of the time. I wonder if the application is not being cleaned up properly.
I did notice that cleaning up unused Docker images and removing the testcontainers image after a failing run seemed to help the tests pass on subsequent runs.
cc: @scottkurz @yeekangc

Before we get to the specific symptoms there's a basic problem here.
The built-in Dockerfile is building the apps into dropins rather than the apps dir like you'd use with explicit application config in server.xml, like you added.
If you're not supplying your own Dockerfile in your app project (which this guide is not), you're going to end up using a default Dockerfile that's programmatically embedded into the Liberty adapter here which also aligns with the snippet documented at: https://microshed.org/microshed-testing/features/SupportedRuntimes.html.
That said.. I'm not sure I explained the exact symptom.
But you're probably going to want to make the change to correctly align anyway.
So to fix this problem... I'd start make a Dockerfile and drop it in your project root, and code it to ADD or COPY the app into /config/apps rather than /config/dropins.
Please see if that helps and let us know if you have issues/questions.

@scottkurz Thank you for your reply, this fixed my issue. If I add a Dockerfile it now runs perfectly.
I actually had a dockerfile before and removed it because it was not working with maven and the example did not have a Dockerfile. Your comment made me re-add it and fix the error that was in it (and not obvious to me at the time).
Would it be a good idea to have the example application add a rudimentary Dockerfile?

Would it be a good idea to have the example application add a rudimentary Dockerfile?

Great idea:   opened https://github.com/OpenLiberty/guide-microshed-testing/issues/98
Glad to help !


illegal indirection for linalg.hpp

The following is giving the C2100 "illegal indirection" error.
#include <iostream>
#include <tuple>
#include "xtensor/xarray.hpp"
#include "xtensor/xio.hpp"
#include "xtensor/xmath.hpp"
#include "xtensor/xview.hpp"
#include "xtensor-blas/xlinalg.hpp"
using namespace std;
using namespace xt;
int main()
{
	auto test = empty<double>({ 5,5 });
	auto test1 = ones_like(test);
	cout << test1;
	auto eig = linalg::eigvals(test1);
        return 0;
}

The message states that the error is in line 487 of xlinalg.hpp which is
std::array<std::size_t, 2> shp({N, N});
I'm not sure if I'm doing any thing wrong or not. For clarity, I'm using Visual Studio for my C++.

Hi @ccphysics . Thanks for the report. I am far from a Visual Studio export, nor do I have access. That being said, I have noticed that the mentioned constructor call was not entirely according to the standard. Could you check if QuantStack/xtensor-blas#133 fixes your problem?

That seems to have fixed that issue, but now two more have been raised:
A C2440 has been raised twice.
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2440	 '=': cannot convert from 'void' to '_Ty'
        with
        [
            _Ty=double
        ]	File_Name	C:File_Path\xassign.hpp	497

and
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2440	 'static_cast': cannot convert from '_Ty' to 'T'
        with
        [
            _Ty=const std::complex<double>
        ]
        and
        [
            T=result_type
        ]	File_Name	C:File_Path\xutils.hpp	633

This seems to have fixed this issue, thanks.

great!


feat: add storybook and animated planet component

What's done

Installed storybook
Implemented the AnimatedPlanet component, which will be used on the main page. Tested that it runs smoothly in Chrome, Firefox and Safari
Set up github action for deploying static to S3. Currently to my personal bucket, but we can change that at any time just by editing a couple of secrets

One issue remains — website currently displays incorrectly; page renders twice. That maybe fixed later, maybe in another PR.

@shadowusr Super good!
I have question about https://storage.yandexcloud.net/testplane-ci/testplane-docs/website-static/8551288637-17-1/index.html — imho there is a bug, page is duplicated.

I have question about https://storage.yandexcloud.net/testplane-ci/testplane-docs/website-static/8551288637-17-1/index.html — imho there is a bug, page is duplicated.

Yeah, that's a bug, I mentioned it in the PR description. I'm going to address it in the next PR, because it's not linked to current changes.
Still not sure why this is happening. Definitely related to server side rendering (when I turn it off, page renders just fine). But the most weird thing about it is that if I serve the exact same bundle locally, page renders correctly. After uploading to S3, this happens. Not the first time, same thing happened with a different bucket and different docusaurus project.