Cleaning up OpenShift CI files

What kind of PR is this?

/kind cleanup
/kind test
What does does this PR do / why we need it:
Cleaning up openshiftci presubmit files.
Which issue(s) this PR fixes:
Fixes - No, however cleanup is needed after #2401 went in
How to test changes / Special notes to the reviewer:
OpenShift CI should pass

 [odo]  ✗  Failed to create component with name nodejs. Please use `odo config view` to view settings used to create component. Error: unable to wait for build nodejs-myapp-1 to run: timed out waiting for the condition

/test v4.1-integration-e2e-benchmark

LGTM.
/lgtm

#2088
/test v4.1-integration-e2e-benchmark

/approve

/assign @amitkrout
/approve

/approve

/approve


ISPN-4986 Updated User Guide to use proper JCache interceptor classes

https://issues.jboss.org/browse/ISPN-4986

Integrated, thanks a lot!


Focal loss for single label classification?

Checklist

I have searched related issues but cannot get the expected help.
I have read related documents and don't know what to do.

Describe the question you meet
I'm trying to train a resnet18 with a LinearClsHead using the focal loss for a single label binary classification problem, but the current focal loss implementation raises an assertion error as the predictions have shape [batch_size, 2] and target has shape [batch_size]. According to the documentation the implemented focal loss only works for multilabel tasks. Is there any way of using it also for single label tasks?
Post related information

The output of pip list | grep "mmcv\|mmcls\|^torch"
mmcls                     0.17.0
mmcv-full                 1.3.9
torch                     1.9.0
torch-model-archiver      0.4.1
torchvision               0.10.0

This is the model config I'm using:

# type: ignore
model = dict(
    type="ImageClassifier",
    backbone=dict(
        type="ResNet", depth=18, num_stages=4, out_indices=(3,), style="pytorch"
    ),
    neck=dict(type="GlobalAveragePooling"),
    head=dict(
        type="LinearClsHead",
        num_classes=2,
        in_channels=512,
        loss=dict(type="FocalLoss", loss_weight=1.0),
        topk=(1),
    ),
)

load_from = "/media/VA/pretrained_weights/mmcls/resnet18_batch256_20200708-34ab8f90.pth"

I am getting the following error during training:

File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/apis/train.py", line 164, in train_model
    runner.run(data_loaders, cfg.workflow)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcv/runner/epoch_based_runner.py", line 50, in train
    self.run_iter(data_batch, train_mode=True, **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcv/runner/epoch_based_runner.py", line 29, in run_iter
    outputs = self.model.train_step(data_batch, self.optimizer,
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcv/parallel/data_parallel.py", line 67, in train_step
    return self.module.train_step(*inputs[0], **kwargs[0])
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/classifiers/base.py", line 146, in train_step
    losses = self(**data)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcv/runner/fp16_utils.py", line 98, in new_func
    return old_func(*args, **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/classifiers/base.py", line 90, in forward
    return self.forward_train(img, **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/classifiers/image.py", line 110, in forward_train
    loss = self.head.forward_train(x, gt_label)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/heads/linear_head.py", line 53, in forward_train
    losses = self.loss(cls_score, gt_label)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/heads/cls_head.py", line 46, in loss
    loss = self.compute_loss(cls_score, gt_label, avg_factor=num_samples)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/losses/focal_loss.py", line 106, in forward
    loss_cls = self.loss_weight * sigmoid_focal_loss(
  File "/media/data/miniconda3/envs/ai-project-screen_classification/lib/python3.8/site-packages/mmcls/models/losses/focal_loss.py", line 36, in sigmoid_focal_loss
    assert pred.shape == \
AssertionError: pred and target should be in the same shape.

Thank you!

We will try to reproduce and fix it recently

Hello, by now, the FocalLoss is only for multi-label tasks, refers to https://github.com/open-mmlab/mmclassification/pull/131, and we will support single-label task in the future.

@mzr1996 Hi. If I want to train the network with asymmetric binary classes dataset, which Loss  in mmcls is the better?

@juanjompz Hi. I met the same problem and I think I slove it. One-Hot is the key.
You can insert this code in line 37, focal_loss.py (before assert pred.shape ==...)
code:
    from .utils import convert_to_one_hot
    if target.dim() == 1 or (target.dim() == 2 and target.shape[1] == 1):
        target = convert_to_one_hot(target.view(-1, 1), pred.shape[-1])

Then, mmcls can work succeddfully.

Thank you @zhongqiu1245, indeed, converting target to one hot format fixes the problem.  Are you going to pull request these changes?

Sorry, I haven't create PR yet. I'm learning it.

https://github.com/open-mmlab/mmclassification/issues/541#issuecomment-1478030322


undifined

Hallo, i have installed the module and have no issues.
But no global comes?
a view minutes stay undefined and then Black, nothing, empty.
is there a fix or update. Is there anything that has been changed or that I need to know.
Many Thanks
Meine config:
{
module: "MMM-Globe",
position: "middle_center",
config: {
style: "geoColor",
imageSize: 300,
ownImagePath:'',
updateInterval: 10601000
}
},

same here, no picture ...
{
module: 'MMM-Globe',
position: 'center',
config: {
style: 'geoColor',
imageSize: 600,
ownImagePath:'',
updateInterval: 10 * 60 * 1000 (without the spaces)
}
},

only the last third URI´s are available in MMM-Globe.js ...

same here, image is no longer working.

Same Problem !
Fixing?


Empty CDATA breaks highlighting

Hi,
Just noticed that empty CDATA breaks formatting:

Fixed in e925b5de5cd1a31522e01c51d7668346950ce4ff

I updated to latest "release" but the issue is still present.
Am I doing something wrong ?

I forgot to tag the new release.


added if (helper != null) { ..... } to avoid crashes

Hi,
i have some issues with crashes, so this is kind of a "hotfix" as long as i couldnt fix the real problem.
i added if (helper != null) { ..... } to avoid crashes in cases where there is no helper object or the wrong purchasemanager has been bound.
this shouldnt be a bad addition
bye
phil

Great idea! :)  One minor change: could you add an else-condition and output an error message via Log.e(...) so we know there was a problem during restore rather than letting it fail silently?

done!

added the same to purchase(), too


Can't able to connect to triton

Hi @npuichigo , I am facing some issues in connecting to my Triton server running locally.
Here are the steps that I followed. Please correct me if any of the steps is incorrect.

Start triton server in docker environment.

sudo docker run --gpus=1 --rm -d -p 8000:8000 -p 8001:8001 -p 8002:8002 -v <path_to_configpb_files>:/models -v <path_to_engine files>:/engines nvcr.io/nvidia/tritonserver:24.01-trtllm-python-py3 tritonserver --model-repository=/models

Go to openai_trtllm code checkout directory run the command below:
sudo docker compose up --build

I am getting this error:
Error response from daemon: driver failed programming external connectivity on endpoint openai_trtllm-openai_trtllm-1 (97471c25c1d3fe60e8b43c97ecbc4b7ed9ed7775aec79327ba3126a269ec6a34): Bind for <IP_ADDRESS>:3000 failed: port is already allocated
In case I do not run the triton server as mentioned in Step 1 and directly try to run openai_trtllm, I get this error:
{"timestamp":"2024-04-16T06:08:41.955297Z","level":"INFO","message":"Connecting to triton endpoint: http://tensorrtllm_backend:8001","target":"openai_trtllm::startup"}
Can you suggest the exact steps that I can execute?
Regards
Tapan

I think I got it. I need to modify docker-compose.yml as per my needs. Thanks!

Sorry for reopening it @npuichigo . Is it necessary to use your docker image for triton server as mentioned in docker-compose.yml?
In case I use that image I am not able to run it and get below error in the logs:
exec /opt/nvidia/nvidia_entrypoint.sh: exec format error
Due to which openai_trtllm container is not able to connect and get:
{"timestamp":"2024-04-16T07:08:33.823905Z","level":"INFO","message":"Connecting to triton endpoint: http://tensorrtllm_backend:8001","target":"openai_trtllm::startup"}
Error: failed to connect triton endpoint

Can I run my own triton server and then connect to it?

It's fine and recomended to use official NVIDIA NGC docker like nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3.
The warning seems related to your platform (maybe you're using mac? I'm not sure how do u use nvidia gpu).

I am using the following docker-composr.yml to connect to my triton server.
version: "3"

services:
  openai_trtllm:
    image: openai_trtllm
    build:
      context: .
      dockerfile: Dockerfile
    command:
      - "--host"
      - "<IP_ADDRESS>"
      - "--port"
      - "3000"
      - "--triton-endpoint"
      - "grpc://<IP_ADDRESS>:8001"
    ports:
      - "3000:3000"
      - "8001:8001"
    restart: on-failure

Getting the error:
Error response from daemon: driver failed programming external connectivity on endpoint openai_trtllm-openai_trtllm-1 (3f7959a66bf5632f19674354775af8d13ddcdc8908f2aba79b5080241137aba8): Bind for <IP_ADDRESS>:8001 failed: port is already allocated

Process in docker cannot connect to process outside do. Please refer to https://www.squash.io/tutorial-host-network-in-docker-compose/#google_vignette

Thank you very much @npuichigo .
This is from container logs:
Attaching to openai_trtllm-1
openai_trtllm-1  | {"timestamp":"2024-04-16T15:36:55.132920Z","level":"INFO","message":"Connecting to triton endpoint: grpc://<IP_ADDRESS>:8001","target":"openai_trtllm::startup"}
openai_trtllm-1  | {"timestamp":"2024-04-16T15:36:55.133327Z","level":"INFO","message":"Starting server at <IP_ADDRESS>:3000","target":"openai_trtllm::startup"}

Just want to confirm now that I believe openai_trtllm is properly setup and connected to triton server using grpc protocol.

I think it’s correct

Thanks @npuichigo . I have made the progress.
I am connecting to openai_trtllm using Postman as client and I think model_stream_infer failed here.
let mut stream = client
        .model_stream_infer(request)
        .await
        .context("failed to call triton grpc method model_stream_infer")?
        .into_inner();

My POST request from Postman:
http://localhost:3000/v1/completions

{
    "model": "ensemble",
    "prompt": ["In python, write a function for binary searching an element in an integer array."],
    "max_tokens": 200,
    "stop": ["--"],
    "temperature": 0.0
}

INFO and ERROR logs at openai_trtllm end:
openai_trtllm-1  | {"timestamp":"2024-04-17T10:04:12.973172Z","level":"INFO","message":"request: Json(CompletionCreateParams { model: \"ensemble\", prompt: [\"In python, write a function for binary searching an element in an integer array.\"], best_of: 1, echo: false, frequency_penalty: 0.0, logit_bias: None, logprobs: None, max_tokens: 200, n: 1, presence_penalty: 0.0, seed: None, stop: Some([\"B. London\"]), stream: false, suffix: None, temperature: 0.0, top_p: 1.0, user: None })","target":"openai_trtllm::routes::completions","span":{"headers":"{\"content-type\": \"application/json\", \"user-agent\": \"PostmanRuntime/7.37.3\", \"accept\": \"*/*\", \"postman-token\": \"2fb36acd-53dc-4689-a7be-166a21f8d631\", \"host\": \"localhost:3000\", \"accept-encoding\": \"gzip, deflate, br\", \"connection\": \"keep-alive\", \"content-length\": \"201\"}","name":"completions"},"spans":[{"http.request.method":"POST","http.route":"/v1/completions","network.protocol.version":"1.1","otel.kind":"Server","otel.name":"POST /v1/completions","server.address":"localhost:3000","span.type":"web","url.path":"/v1/completions","url.scheme":"","user_agent.original":"PostmanRuntime/7.37.3","name":"HTTP request"},{"headers":"{\"content-type\": \"application/json\", \"user-agent\": \"PostmanRuntime/7.37.3\", \"accept\": \"*/*\", \"postman-token\": \"2fb36acd-53dc-4689-a7be-166a21f8d631\", \"host\": \"localhost:3000\", \"accept-encoding\": \"gzip, deflate, br\", \"connection\": \"keep-alive\", \"content-length\": \"201\"}","name":"completions"}]}
openai_trtllm-1  | {"timestamp":"2024-04-17T10:04:12.973745Z","level":"ERROR","error":"AppError(failed to call triton grpc method model_stream_infer\n\nCaused by:\n    status: Unknown, message: \"Bad :scheme header\", details: [], metadata: MetadataMap { headers: {\"content-type\": \"application/grpc\"} })","target":"openai_trtllm::routes::completions","span":{"headers":"{\"content-type\": \"application/json\", \"user-agent\": \"PostmanRuntime/7.37.3\", \"accept\": \"*/*\", \"postman-token\": \"2fb36acd-53dc-4689-a7be-166a21f8d631\", \"host\": \"localhost:3000\", \"accept-encoding\": \"gzip, deflate, br\", \"connection\": \"keep-alive\", \"content-length\": \"201\"}","name":"non-streaming completions"},"spans":[{"http.request.method":"POST","http.route":"/v1/completions","network.protocol.version":"1.1","otel.kind":"Server","otel.name":"POST /v1/completions","server.address":"localhost:3000","span.type":"web","url.path":"/v1/completions","url.scheme":"","user_agent.original":"PostmanRuntime/7.37.3","name":"HTTP request"},{"headers":"{\"content-type\": \"application/json\", \"user-agent\": \"PostmanRuntime/7.37.3\", \"accept\": \"*/*\", \"postman-token\": \"2fb36acd-53dc-4689-a7be-166a21f8d631\", \"host\": \"localhost:3000\", \"accept-encoding\": \"gzip, deflate, br\", \"connection\": \"keep-alive\", \"content-length\": \"201\"}","name":"completions"},{"headers":"{\"content-type\": \"application/json\", \"user-agent\": \"PostmanRuntime/7.37.3\", \"accept\": \"*/*\", \"postman-token\": \"2fb36acd-53dc-4689-a7be-166a21f8d631\", \"host\": \"localhost:3000\", \"accept-encoding\": \"gzip, deflate, br\", \"connection\": \"keep-alive\", \"content-length\": \"201\"}","name":"non-streaming completions"}]}

At Triton server end:
I0416 07:36:30.688923 1 grpc_server.cc:2519] Started GRPCInferenceService at <IP_ADDRESS>:8001
I0416 07:36:30.689069 1 http_server.cc:4623] Started HTTPService at <IP_ADDRESS>:8000
I0416 07:36:30.729902 1 http_server.cc:315] Started Metrics Service at <IP_ADDRESS>:8002
E0417 07:52:12.717523050     557 hpack_parser.cc:1235]       Error parsing metadata: error=invalid value key=:scheme value=grpc
E0417 08:41:05.601946513     557 hpack_parser.cc:1235]       Error parsing metadata: error=invalid value key=:scheme value=grpc

Please note that I am providing triton-endpoint in docker-compose.yml as "grpc://<IP_ADDRESS>:8001". Is that the right way?

@npuichigo, Thanks for being patient :-). I am able to run end to end. The triton end point should have had http protocol instead of grpc. Worked fine! I am closing this issue.
Thanks again!


Update CHANGELOG.md

Update change log for https://github.com/kedacore/keda/pull/1073
Signed-off-by: Anson Au<EMAIL_ADDRESS>Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[ ] Tests have been added
[ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
[x] Changelog has been updated

Relates to #967

LGTM, but can you fix the DCO issues please?

Tried but face an error. Any idea?
(base) Ansons-MBP:keda anson$ git commit --amend --signoff
[patch-1 1e26138] Update CHANGELOG.md
Author: Anson Au<EMAIL_ADDRESS>Date: Sun Sep 6 20:01:27 2020 +0800
1 file changed, 1 insertion(+)
(base) Ansons-MBP:keda anson$ git push --force-with-lease origin patch-1
remote: Permission to kedacore/keda.git denied to ansonauhk.
fatal: unable to access 'https://github.com/kedacore/keda.git/': The requested URL returned error: 403

@ansonauhk could you give us output of:
git remote -v

Will open new one to fix DCO


How to get 10001 random numbers from VRF V2?

What would you like us to add?
I want to mint 10001 nfts,but the URI of each token is generated by a random word from chainlink oracle.
What should I do?
What I have done below does't work!
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.8;

import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>
contract VRFCoordinatorTest is  VRFConsumerBaseV2 {
    // Chainlink VRF Variables

    address vrfCoordinatorV2 = 0x6168499c0cFfCaCD319c818142124B7A15E857ab;
    uint64 subscriptionId = 14422;
    bytes32 gasLane = 0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc;
    uint32 public callbackGasLimit = 2500000; //already max gaslimit

    //network coordinator
    VRFCoordinatorV2Interface private immutable _vrfCoordinator;

    // The default is 3, but you can set this higher.
    uint16 public  REQUEST_CONFIRMATIONS = 10;

    // retrieve NUM_WORDS random values in one request.
    // Cannot exceed VRFCoordinatorV2.MAX_NUM_WORDS.
    uint32 public NUM_WORDS = 500;

    //keep the randomWords from fulfillRandomWords() function.
   uint256[][] public _randomWords;
   //uint256[] public _randomWords;

    event RequestedRandomWords(uint256 requestId ,address requester);

    constructor() VRFConsumerBaseV2(vrfCoordinatorV2) {
        _vrfCoordinator = VRFCoordinatorV2Interface(vrfCoordinatorV2);
    }

    function fulfillRandomWords(uint256, uint256[] memory randomWords) internal override{
        _randomWords.push(randomWords);
       // _randomWords = randomWords;
    }

    function requestRandomWords()public{
        uint256 requestId = _vrfCoordinator.requestRandomWords(
            gasLane,
            subscriptionId,
            REQUEST_CONFIRMATIONS,
            callbackGasLimit,
            NUM_WORDS
        );
        emit RequestedRandomWords(requestId, msg.sender);
    }

    function set_REQUEST_CONFIRMATIONS(uint16 comf)public{
        REQUEST_CONFIRMATIONS = comf;
    }
    function set_NUM_WORDS(uint32 num)public{
        NUM_WORDS = num;
    }
    function set_gasLimit(uint32 gasl) public{
        callbackGasLimit = gasl;
    }

    function getMaxLengthAndNum()public view returns(uint256,uint256){
        uint256 lth = _randomWords.length;
        uint256[] memory tmpArray = _randomWords[lth-1];
        uint256 maxNum = tmpArray[tmpArray.length-1];
        //uint256 maxNum = _randomWords[_randomWords.length-1];

        return (lth,maxNum);
    }
}

How important it is?
Very Very important，the sooner the better，please！

Hi @Eric0718
thanks for this issue. Currently having a look. will get back to you

Thank you so much.

I think I have some details for you：When I set NUM_WORDS less than 100, it was successful, and the basic configuration related to VRF V2 I think should be correct,like add funds or add consumers,But I want 10001 random numbers,I dont't know how to config...

Hello @Eric0718
I tested your example, and the fulfillRandomWords runs out of gas. The gas limit set for your callback is 2,500,000, so you must make sure that  fulfillRandomWords doesn't take more than 2,500,000 during its execution.
you can find a detailed answer on your SO thread.

Hello @Eric0718 ,
have you had time to read and test the Stackoverflow answer? Is the answer helpful?


UI: Register User with Password

As a developer, I want to be able to register a user with username password.
Acceptance criteria

[ ] I am able to register my user with username, password
[ ] The minimum needed fields should be available (Firstname, Lastname, Email, Username will be filled with the email)
[ ] Required policies will be taken into account

Depends on #5017

@peintnermax I think first and lastname are required so it should be set, displayname is set automatically by what you set on the user

And i guess the username and email implement the same as we have currently. so depending on the policy


Search CI/CD alternatives

Background
We are in github, but we have no money.
Tasks

Get some info on CircleCI, Travis, and other tools that could give us free credits for being open sourced

Why would we initially use the CICD ? for run tests in the PRs ?

As we don't count with any founding at all (for the moment), it would be a good idea to find all free CI/CD tools that we could start using.
Github Actions give us around 2.000 minutes per month without cost: https://github.com/organizations/plan
Circle CI starts with 6.000 minutes per month without cost: https://circleci.com/pricing/
Harness can give us 100 builds per month without cost: https://harness.io/pricing?module=ci#
We could also host some CI/CD solution, but I think this needs to be considered in the future.
The idea would be to decide if we want link this account to these providers, and also choose which kind of event/trigger will be handled by each provider.
For example:
PRs builds/tests could be handled by CircleCI
Merges could be handled by GithubActions
Releases could be handled by Harness

I think, for now, we could start running tests before merging to master.
Then, we could try building afterwards.
When te project starts to get bigger, we could start thinking on automate other kinds of tests, builds, releases, etc.


"ubuntu-latest" and "macos-latest" don't use correct version.

Description
When using "ubuntu-latest" and/or "macos-latest", they are normally supposed to be using their latest counter-parts of their operating systems, However what they actually do is reuse older versions of their operating systems instead.
Windows on the other hand is not affected as it is already using the correct version as expected.
Platforms affected

[x] Azure DevOps
[X] GitHub Actions - Standard Runners
[X] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
(Any GitHub Actions + Azure DevOps agents are affected)
Is it regression?
No.
Expected behavior
Using "ubuntu-latest" will use ubuntu 22.04 lts meanwhile using "macos-latest" will use macos-12.
Actual behavior
Using "ubuntu-latest" will use ubuntu 20.04 lts meanwhile using "macos-latest" will use macos-11 instead.
Repro steps

Make any github actions you like,
Ensure the operating system is either on "ubuntu-latest" or "macos-latest",
Send out the commit and check the operating system context.

@Kichura
Hi! We are already working on this, but it is a rather complicated and long process, given that it should bring more benefit than loss to all of our users.

@Kichura
Hi again! Take a look here, please. #6384
First half of your request is already publicly in progress.

Excellent, is there an related issue with ubuntu 22.04 lts as a relationship?

@Kichura I'll send you a link when we start the public part of a process with Ubuntu. But we are working on that too.

@Kichura so, next part published. #6399

Alright, Thank you for the redirections. :)


App testing hackathon

I already added the webhook to giantswarm/giantswarm-todo-app

@giantswarm/team-fusion-engineers are you cool with this?


Update IHCaptchaApi.cs

Changed the Refit path to be a string because constants aren't supported by Refit (yet)

Thanks for your feedback!
I combined your PRs together with another fix!
https://github.com/BenjaminAbt/hcaptcha/pull/4


OCC correct problem

Job1&Job2 do upsert concurrently, and they both have the same primaryKey record (pk1 ...), and this pk1 record does not exists in the table before.
because these two jobs upsert concurrently, so Job1&Job2 do indexlookup and both treat pk1 as insert type.
And Job1 first commit to table, then Job2 commit to table and check file level conflict with Job1's commit, there is no conflict, and also insert pk1 record. Now there are two pk1 record in the table, this is incorrect.
so currently OCC can not handle this multiple concurrent upsert correctly?

yes, this is a known limitation I guess. @n3nash : Can you confirm and add more if any.

Closing this as this is a known problem .


update: bumped driverkit to v0.15.3.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/kind cleanup

@FedeDP: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

/kind cleanup

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, maxgio92
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,maxgio92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Error at the end of rendering

version: v1.3.0
...
2019-03-22T15:04:50.882Z [info]: Completed rendering lesson file /Users/mokos/Developer/udacity/Deep Learning v6.0.0/Part 09-Module 02-Lesson 01_Introduction to TensorFlow/17. Outro.html
2019-03-22T15:04:50.883Z [info]: ____________________

2019-03-22T15:04:50.884Z [error]: ERROR: ENOENT: no such file or directory, open 'Deep Learning v6.0.0/assets/css/fonts/data.json'
CODE: ENOENT
STACK: Error: ENOENT: no such file or directory, open 'Deep Learning v6.0.0/assets/css/fonts/data.json'
    at Object.openSync (fs.js:436:3)
    at Object.readFileSync (fs.js:341:35)
    at writeHtmlLesson (/usr/local/lib/node_modules/udacimak/lib/commands/render/functions/writeHtmlLesson.js:38:26)
    at renderCourse (/usr/local/lib/node_modules/udacimak/lib/commands/render/functions/renderCourse.js:115:45)

Please read this README section:

https://github.com/udacimak/udacimak#important-render-directory-note

I think you were rendering into the downloaded folder, hence the error. We should render into a completely different location instead.


fix(dateparser): baseDate only care about dates

So, setFullYear won't respect the time part, and since we want to respect the timezone, it doesn't make sense anyway right?
So I removed all the time part and also added tests to it.
Not entirely sure if I am right, but I think so.
Thoughts @wesleycho ?

So we want to preserve the other information if possible because some people will use the same model with the timepicker & datepicker - there was a previous issue here involving the datepicker incorrectly modifying the other values.

So, if I do:
parse('1', 'd', new Date(2010, 10, 10, 23, 13));

I want to change the day to day 1, but maintain that hour (23:13), right?
If I do that (with this PR code), I get:
Mon Nov 01 2010 23:13:00 GMT+0100 (CET)

Is that right?

In fact, this PR is not doing anything different, the other 4 parameters are getting ignored, so I removed them, removed them from initialization and tested it.

Right, so it turns out I broke that feature in this refactor - IMO we should try to fix this and retain that information in the date object constructed.

I am confused. This is what we achieve in here right? If you pass a baseDate to it, it will come just with the date part modified, the timezone won't change.

Oh you're right, I should have took a second look at the code


Extract service worker from lively4-core

@jgraichen @Somae

We have moved the source tree preserving the history and are no working on providing a boot loader as well as working on testing and a first kind of overlayfs.

Service worker is loaded from this repo now due to new swx-loader.js in core.


[Question]: Why is the default to mount docker.sock socket into containers?

Describe your question
This issue is similar to the other discussions regarding the default configuration/behaviour of the ADO agent, and in some ways similar to the request raised by @joshchngs in the following ticket:
https://github.com/microsoft/azure-pipelines-agent/issues/4332
Looking at the code that configures the mount of the docker socket into the pipeline container, it's not clear why it has been added. The comment suggests that docker.sock is enabled default on Linux and not Windows, but it doesn't explain the motivation for mounting it.
https://github.com/microsoft/azure-pipelines-agent/blob/d8e2b00f37fd2ef4ba586977e90a671dea2b10ef/src/Agent.Sdk/ContainerInfo.cs#L56-L57
This commit was roughly four years ago, so I suspect this was done as a method to run docker in docker, or execute container builds inside the container agent.
This flag is then used to mount the socket
https://github.com/microsoft/azure-pipelines-agent/blob/d8e2b00f37fd2ef4ba586977e90a671dea2b10ef/src/Microsoft.VisualStudio.Services.Agent/HostContext.cs#L521-L524
I don't believe this approach is endorsed anymore, and at worst, this may actually be a security issue depending on how the container host is configured as this socket can provide significant levels of access to host from inside the container. Additionally, modern container implementations such as podman don't use the docker.socket by default, and it would be nice to not have to work around this configuration if it's not required.
I have done some initial investigation on removing this mount, and as it can't be removed from the configuration, one workaround is to create an empty docker.sock file by simply running touch /var/run.docker.sock. This removes the need for the socket all together (and potential security issue), and a dummy file also passes the 'stat' check in the initialisation step here:
https://github.com/microsoft/azure-pipelines-agent/blob/d8e2b00f37fd2ef4ba586977e90a671dea2b10ef/src/Agent.Worker/ContainerOperationProvider.cs#L698
When using a dummy file for the docker.sock there has been no impact to container execution, demonstrating that it is not required for common use cases.
This issue is to raise awareness of this default configuration, and request that it be revisited. Ideally I believe the ADO agent configuration should have an option to disable this mount, and potentially also remove it from the default configuration due to security issues (ie. mark as deprecated, and people who explicitly need access to the socket from within the container can turn it on through configuration).
All that being said, interested if anyone is actually using this docker.sock in their Linux containers?
Versions
Azure DevOps Agent 3.220.2
Environment type (Please select at least one environment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
RHEL 8, RHEL 9
Version controll system
git
Azure DevOps Server Version (if applicable)
Azure DevOps Services

Hi @pixdrift thank you for the feedback. We have higher priority issues now, but we'll get to that soon.


[Service Bus] deadletter bug fixes and backup message settlement for track 1

Deadletter bug fixes porting from track 2
Backup message settlement for track 1 (similar to track 2 - https://github.com/Azure/azure-sdk-for-js/pull/8340)

The changes look good, but is it possible to port some of the tests from track2 over as well?

The changes look good, but is it possible to port some of the tests from track2 over as well?

Porting all of the tests.. ongoing.

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests


[Question/Docs] how to access S-R trend analysis statistical details

Summary of question
@AnujTiwari wrote at issue #851.

Which trend analysis technique S-R trend is using? Is it possible to access the trend type, p-value, z-value, slope, and other parameters related to the trend results? Also, is it possible to collect the resultant parameters for homogeneity analysis?

Dear @AnujTiwari,
Could you me the details of trend analysis technique and homogeneity analysis?

We can get MSE, MEPE, RMSLE score etc. with TrendDetector class.
import covsirphy as cs
data_loader = cs.DataLoader()
jhu_data = data_loader.jhu()
population_data = data_loader.population()
country = "Italy"
record_df, _ = jhu_data.records(country=country, population=population_data.value(country))

for i in range(3, 80):
    detector = cs.TrendDetector(record_df, min_size=i)
    _ = detector.sr(algo="Binseg-normal")
    df = detector.summary(metrics="MSE")
    score = df["MSE_S-R"].sum()
    duration_diff = df["Duration"].mean() - i
    print(f"min_size={i:2}: MSE={score:.2g}, [mean of (duration - min_size)]={int(duration_diff):2}")

A change-point is usually related to an abrupt or structural change in the distributional properties of data, whereas trend detection is an analysis that looks for the existence of gradual departure of data from its past.  Change-point and trend detection are both long-lived research questions that have been frequently raised in statistical and non-statistical
communities for decades. We have parametric (assumption: data follows a normal distribution) and non-parametric (assumption: data does not follow a normal distribution) trend assessment techniques. In the case of COVID-19, there are a lot of articles that are in the favor of one or another considering their pros and cons.
We can discuss more about them but my current understanding with COvSirPhy is that you have implemented a change point detection algorithm (rapture package) to find out the abrupt changes and obviously dataset between the two change points represents a trend. But there is no any trend assessment technique is implemented for accessing the nature of the test.

Yes, change point detection is a challenging task and it is the time to update our trend analysis to academic level. Because the accuracy of trend analysis affect the outcome of the subsequent analysis, improvements and detailed assessments are necessary.
However, please confirm the background of implementation of our trend analysis. We consider the series of the following steps as one workflow.
snl.trend()
snl.estimate(cs.SIRF)
snl.score()

S-R trend analysis was just created to improve the accuracy of parameter estimation by splitting the time series data to phases. The purpose of S-R trend analysis is to find change points which ensure that the records between change points follow a SIR-derived model with stable parameter values.
(I think we can know "trend of outbreak" with the history of model parameter values. S-R trend analysis is not a tool to know the "trend of outbreak" and this is confusing for experts?)
Accuracy of trend analysis + parameter estimation is assessed with Scenario.score(), and I thought that of trend analysis is assessed with TrendDetector.summary() with MSE etc. as I mentioned in the previous comment.
I'm not familier with the scientific background of change point analysis (I just studied it with documentation of ruptures and quick reading of its papers). I have two questions.

It is possible to get slope by updating TrendDetector, but what information we will get with slope?
How can we calculate p-value and z-score with S-R trend analysis?

Yes - It is possible to compute the slope and all the other statistical parameters too (p-value and z-score) using some non-parametric trend analysis techniques like Mann Kendall and Sen Slope Trend Analysis. I can try if it is possible to access the S-R time series?

S-R time series data has Date/log10(Susceptible)/Recovered and we can create it (sr_df) with JHUData as follows.
import covsirphy as cs
import numpy as np
import pandas as pd
loader = cs.DataLoader()
jhu_data = loader.jhu()
subset_df, _ = jhu_data.records(country="country name", province="province name")
sr_dict = {
    "Date": subset_df["Date"],
    "R": subset_df["Recovered"],
    "log10S": np.log10(subset_df["Susceptible"].astype(np.float64)),
}
sr_df = pd.DataFrame(sr_dict).set_index("Date")

Thanks, Lisphilar for the code. I will definitely provide you update on the trend analysis soon.

I'm preparing for version 3 release after some 2.x versions and revising class structures and methods of analysis.
We are using ruptures package to find structural changes of ODE parameter value sets indirectly by decting chainge points of logS and R. We called it as "S-R trend analysis," but "S-R change point analysis" should be used?

"S-R change point analysis" will be used from the next stable version 2.25.0.


For Release binary Problem: Exec format error?

Hi SmartGridToolbox Team,
I just download the release version. I try to execute the pvdemo, and I get the error: bash: ./pvdemo: cannot execute binary file: Exec format error. My machine is Ubuntu 14.04 64bit.
Thanks

Hi there,
To help you out, I’ll probably need to know much more information. But for now, I can say the following:

We don’t do binary releases, so you’ll need to build from scratch.

I’d recommend using git / github to checkout a recent version of SmartGridToolbox. I use:

git clone https://github.com/NICTA/SmartGridToolbox.git

This will get you the “master” branch of SmartGridToolbox, which is stable-ish.
I don’t think I have published a “release” for quite some time (and I should do so ASAP), so if you download the latest release rather than using git, you’ll miss out on some good improvements. Also, using git makes the process of obtaining new bugfixes and updates much easier.

Building using Ubuntu 14.4 is fine. You’re best off using g++4.9 or later. Read the INSTALL file to find out which third party components need to be installed, etc. and to get some tips.

We haven’t had too many people from outside our organisation try to build SmartGridToolbox, and it is pretty much just me working on it, so it is quite possible that some of the information about building is out of date. I’m really happy to help out with any problems you might have, and would welcome any information I can get from you about what doesn’t work, etc. You can probably expect that there will be some bumps in the road before you manage to get things running.

The PV demo requires gurobi.

——————————
At present, I’d say the learning curve is reasonably steep, and you need decent C++ development skills. You should think of SmartGridToolbox as being primarily a library for developing custom software rather than a standalone tool for power systems analysis.
There’s heaps more help and information I can give, but I think the best idea is if you give me a bit more detail and I’ll have a much better chance of being able to help you out.
Cheers, Dan

On 31 Jul 2016, at 11:20 PM, pfsun<EMAIL_ADDRESS>wrote:
Hi SmartGridToolbox Team,
I just download the release version. I try to execute the pvdemo, and I get the error: bash: ./pvdemo: cannot execute binary file: Exec format error. My machine is Ubuntu 14.04 64bit.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/NICTA/SmartGridToolbox/issues/40, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvbLtAJkDj1tjEftzNePWxKNhvKIW8sks5qbKEOgaJpZM4JZB5K.

Hi Dan,
Thanks for the detail answer. Now I can build SmartgridToolbox successfully. However, when I compile PvDemo, there are one error. Even if I fix this error, there will be other include error.

Hi pfsun,
Sorry for the delay in getting to this. The latest release (v. 4.0.0) of SmartGridToolbox should take care of the problem.  Alternatively, you can download from the github website.
To run the PvDemo, you'll need to obtain and successfully compile the third party package PowerTools - also available in the SmartGridToolbox/third_party directory. (I said earlier you need Gurobi; this was, in fact, incorrect). This, in turn, requires you to install Ipopt, which itself requires some fiddling to get the correct third-party dependencies installed. Hassan Hijazi, the maintainer of PowerTools, may be able to help you out, or you can ask me about it.
When you configure SmartGridToolbox, you'll also need to specify that you wish to use the optional PowerTools support, e.g.
configure CXX=g++-5 --enable-power-tools
You can then run make and make install.
I'll close this issue now, but feel free to ask for more help on this.


gccemacs error preventing start: void: comp-deferred-compilation-deny-list

What did you expect to happen?
Doom has to start in gccemacs as earlier after building from the latest commit, both feature/native-comp of emacs and doom configs.
What actually happened?
$ ~/.emacs.d/bin/doom sync
Symbol’s value as variable is void: comp-deferred-compilation-deny-list

The specific place of reference to above error is:
https://github.com/hlissner/doom-emacs/blob/fbb8d1b99e77435f43f9f0d99e84b4d82f792251/core/cli/packages.el#L231
Thanks!

Not a bug; update gccemacs. Doom tracks (near enough) its bleeding edge and offers no backwards compatibility for earlier versions. Sorry for the trouble!

Not a bug; update gccemacs. comp-deferred-compilation-black-list was renamed to comp-deferred-compilation-deny-list upstream within the past two weeks.
Doom tracks (near enough) its bleeding edge and does not offer backwards compatibility for earlier versions. Sorry for the trouble!

In my case, the gccemacs is three-days old from the main repo.
git branch of emacs-native-comp I used was be907b0ba82c2a65e0468d50653cae8a7cf5f16b
Anyway I shall try again.


change 'bower install' progress so it doesn't scroll?

I'd love it if the output of 'bower install' would avoid making a new line for each update in progress and would prefer if it would have one line for each file it is downloading which is updated with progress - a bit like the output of wget.

Bower is in maintenance mode and we won't fix cosmetic changes to not break other things


minimatch ps3

switched from gulp to make.js and added minimatch for ps3. the basic functionality is there and seems to be working. now i need to port the unit tests.


feat: rate limiting

release 0.26.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.083%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4902

Relevant Lines:
5673

💛  - Coveralls


UTF-8 console I/O on Windows

A Windows console cannot display UTF-8 characters out of the box:
puts "×😂" # => ├ù≡ƒÿé

From my investigation there are some ways to fix this:

Use SetConsoleCP(CP_UTF8) and SetConsoleOutputCP(CP_UTF8). This appears to be broken to some extent before Windows 10.
Detect whether a file descriptor represents a terminal, then convert to/from UTF-16 and use ReadConsoleW / WriteConsoleW if that is the case. Python does this.
Use _setmode(_fileno(...), _O_U16TEXT) and always convert to/from UTF-16 when interfacing with the standard streams. This causes an assertion error for non-wide functions.
Do nothing and direct the users to run chcp or configure their terminals themselves.

This thread might be useful for consideration. Also note that cmd.exe and Windows Powershell will not support anything outside the BMP regardless of how Crystal handles this, because they use UCS-2 internally, not UTF-16 (Windows Terminal will display emojis just fine, and so does Visual Studio Code's integrated terminal, for example).

It seems like this does not work correctly for reading from stdin (#13731). We might want to remove setting the console codepage.


Attach: Select an ID from the list table has tons of whitespace

Happens with scope ps and scope attach NAME and is due to the column-layout.

Seems to be an issue with the table rendering. After trying to use the options in the library to no avail, I have filed an issue : https://github.com/olekukonko/tablewriter/issues/189

@coccyx are you aware of any option we can set that will fix this?

Not that I know of. We'll probably have to fix it in the library ourselves and send a PR (although it looks like a ton of PRs are piling up). We could also pretty easily replace the table library as well, and there are likely other options.


Define relationship between preferred versions and ToChange/ChangeAll params

Right now, preferred versions get added to the queue without regard for the ToChange and ChangeAll params. I'm not completely sure what the best behavior here is, but I think it should probably look like this:

If ChangeAll is not set and ToChange does not have a given project in it, then add prefv to version queue as normal
If ChangeAll IS set and ToChange does not have a given project in it, AND the root neither imports nor constrains the project (aka, it is entirely a transitive dep), then add prefv to version queue. This allows general updates to maintain stability in projects the user isn't directly paying attention to.
Regardless of ChangeAll or the root import/constraints, if ToChange is set with the project name, then don't add prefv to the version queue. (Explicit user input always wins)

This issue was moved to golang/dep#440


Add reference and checks to type hints / mypy

see optuna:

type hints, PEP484, are checked with mypy.

done


fix: 优化标签列表查询速度

这个 PR 实现什么功能/修复什么问题:
优化标签列表查询速度
是否需要 backport 到之前的 release 分支:
None
/area region
/cc @swordqiu

Codecov Report

Merging #5564 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5564      +/-   ##
==========================================
- Coverage    6.86%    6.86%   -0.01%
==========================================
  Files         612      612
  Lines      103327   103332       +5
==========================================
  Hits         7090     7090
- Misses      95665    95670       +5
  Partials      572      572

Flag
Coverage Δ

#aFlag
6.86% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/metadata.go
6.72% <0%> (-0.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78688a8...a4c1f3b. Read the comment docs.

/lgtm


Authentification and request file logging make the pode application freeze

Describe the Bug
Activating bearer authentification and request file logging make the api freeze when multiple call to an endpoint are done at the same time. When the api is frozen, you have no choice to restart the pode application to fix the problem.
If you disable either the authentication or the logging file, the problem seem to disappear. Also, this problem doesn't seems to happen when using the terminal logging.
Steps To Reproduce
Steps to reproduce the behavior:

Create a pode application with bearer authentification, request file logging and a endpoint using the authentification.
Make multiple simultaneous call to the created endpoint during more or less 15 seconds
At this point, the api should be frozen

Platform

OS: Windows

Hi @PoSam66,
I've tried to reproduce this but I can't seem to get the freeze to occur. Would you be able to give a minimum script that causes the freeze to happen?
If not, would you be able to give me a bit more info into what your Bearer Add-PodeAuth script is doing? And potential how much load you're putting the endpoint under when the freeze triggers?
Under normal circumstances this technically shouldn't ever happen, as the Authentication and the Logging are in two separate runspaces 🤔
For the API to freeze it could indicate that an error is occurring that causes the main Route runspaces to crash. If you try enabling Error logging to see if an error/stacktrace appears that could be useful.
Hope that helps, and thanks

Hi @Badgerati,
Thanks for your quick response! I did more testing on my side and it looks like it could be caused by the file monitoring. You can try to reproduce the issue with the Freeze_test.zip that I joined to this message.
Freeze_Test.zip
Thank you.

Hey @PoSam66,
So with that I managed to reproduce it! I've pushed a potential fix, it was being caused when sessions were enabled - if you made the auth sessionless the freeze didn't happen.
The change is to make the ScriptMethods of the InMem PSObject session store be NoteProperty ScriptBlocks instead - which also increases the performance as well!
With the change, I couldn't get the freeze to trigger again.
Would you be able to test with the above commit (Issue-509 branch), see if it resolves the issue?


GO entry terms are URLs

Describe the issue/bug
We have just inserted GO (data from 05_10_2023) into the Unified Medical Language System (UMLS) and found three GO ETs that are URLs instead of text strings.
Expected behavior
Are these strings legitimate ETs within the GO data, or are these mistakes?
To Reproduce
https://github.com/geneontology/go-ontology/issues/21791 [GO2023_05_10/ET/GO:0004303]
https://github.com/geneontology/go-ontology/issues/24479 [GO2023_05_10/ET/GO:0099099]
https://github.com/geneontology/go-ontology/issues/24269 [GO2023_05_10/OET/GO:0046855]
Thanks,
Miranda Jarnot, UMLS Source Coordinator

Dear @mirandajarnot
Thank you for reporting this, I have now fixed the issues.
Best regards,
Pascale
@suzialeksander


Is it possible to handle subtasks ?

It would be great if TaskBoard can handle sub-tasks.
I don't know how it could be done : either allowing to create items in another item, or by linking to an other board (I do such way with the url of the other board, but using a board for 3 item isn't really pertinent) or just a check-list in description (with box to check)
For example, I have a project with ten items, each items can be itself cut into 3 items, and sometimes I can't process all the 3 (sub)items to move the main item to another column. It goes fast into something fuzzy to remember what has been done or not when not moving the items.
PS maybe there is a way to do such thing with comments ? but how ? I take all your ideas :)
PS' TaskBoard is a great tool by the way !

+1 :)

I would like to provide an argument here in support of this feature request.
Tasks used in a kanban tool like TaskBoard are often connected hierarchically. For me, as a Product Manager for a software company I create epic stories. The epics are split into user stories during discussions with the development team. Each User Story again is divided into (implementation) Tasks. It would be great to put all the tasks of a user story on the TaskBoard. Once all the tasks are done the User Story (the parent task) is done.
For me as a Product Manager I am only interested to know when all Tasks for a Story are done, so i can start testing and demoing it.

+100 !  Sub-task support is very important.  While one can add bullets with markdown, it's hard to either check these off, or assign due dates.

Yeah, subtasks would come in really handy!


refactor test suite

I'd like to suggest a refactoring of the current test suite. Having all tests under the tests/ directory which follows the same pattern as the module. i.e.
e3nn_jax/
 ...
tests/
 noxfile.py
 conftest.py
 ...

A lot of modern JAX based frameworks follow the same structure, viz flax, jax-md, jax (itself) and kfac-jax.

Sounds good to me


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:41: missing_description: The recipe is missing a description
ERROR: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:41: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:41: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_28ubsz9_cz/clone/recipe/meta.yaml:41: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:41: missing_description: The recipe is missing a description
ERROR: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:41: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:41: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_2c5saxohc2/clone/recipe/meta.yaml:41: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


Add retry to subscription

Hey, this change works fine! Thanks!

Closes #23

Hi @fabriziosestito, this commits seem to be lost in the main branch. Do you know how that happened? I cannot even find it in the git blame, it seems there was a force push?


attr -> prop

Issue #132

Coverage remained the same at 38.916% when pulling 42e53472888b24a14f8aa89b8417a63790934b26 on attrs_to_props into f4dd9f2efe00c4759b6c1bf6fd196c06947e6d55 on master.


Made paths relative

Biggest change: Paths are now relative because we had to put smicscore in a subdirectory.
Other Changes:

Added .placeholder in Certificates folder to keep the folder in GIT

Optimized Dockerfile and added a second Key for R repository
Chart.js was included two times - removed the 2.5.0 version
Added a local copy of chart.js 2.9.4 to prevent external loading...

renamed the docker-compose.yml to docker-compose.yml.example and added the file to .gitignore because ist contains passwords....


Added 'Have Fun With Machine Learning'

Added Have Fun With Machine Learning, an absolute beginner's guide to Machine Learning and Image Classification with Neural Networks https://github.com/humphd/have-fun-with-machine-learning. Also looks like my text editor removed some errant trailing white space.

@ujjwalkarn Saw a pull request get merged before this one. Did I miss something or a notification didn't get pushed?

Thanks for reminding!


Add teams from UI

You can add teams using:

The file picker
The designated textbox in the UI

In any case, the teams get added to the end of the container so you can keep on adding

@hovo-hakobyan Please check my last commit. Merge if you approve


Lower complexity of Schedule#& method

Code Climate was not happy.

@alex-stone @joshlam @kpandya91 @kbrainwave

:+1:, although the attached Code Climate build doesn't indicate that it was fixed


Linux support

Are there any current or future plans to add Linux support?
Proton doesn't currently support the Windows Graphics Capture api.

Sorry, the Window Capture method is very different for each OS, so currently only Windows will be supported.


Add a CRUD for users

Something really small/simple,but cool to start another issues...

Create an user -> username + password ;
Get an user by id or username ;
Delete an user by id or username ;and
Update an user;

Thinking again: it's not necessary. I'll keep just a "get user" as an example.


Inputs: Defines styles: width, max-width, typography, color, margin, padding

Define in figma for text inputs:

[x] Width / max-width
[x] Typography (labels, descriptions etc.)
[x] Colour
[x] Border
[x] Padding

Outcomes
Determine base styles for our text inputs
Deliverables
Styles documented in figma (and on a sandbox webpage if time permits)
Estimated Effort

[ ] XS: 1 to 2 hours
[ ] S: half a day
[x] M: 1-2 day
[ ] L: 1 week
[ ] XL: Move to an epic

Out of scope

Styles in figma
https://www.figma.com/file/VUxfzUWHbMmOpasyNM6e5m/GC-DS-Product-Design?node-id=3160%3A1024

Sandbox demo page
https://sandbox-brown.vercel.app/inputs


NoMessage when no pool items

Pull Request Test Coverage Report for Build 612006164

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 26.633%

Totals

Change from base Build 611884140:
0.0%

Covered Lines:
1692

Relevant Lines:
6353

💛  - Coveralls


ConstrainedReschedule raises an error with reset

Environment

Qiskit Terra version:  main
Python version: 3.10.12
Operating system: macOS 13.4.1

What is happening?
ConstrainedReschedule raises TranspilerError with reset.
How can we reproduce the issue?
from qiskit import QuantumCircuit
from qiskit.providers.fake_provider import FakeBogotaV2
from qiskit.transpiler import PassManager
from qiskit.transpiler.passes import ALAPScheduleAnalysis, ConstrainedReschedule, TimeUnitConversion

backend = FakeBogotaV2()
target = backend.target
durations = target.durations()

circuit = QuantumCircuit(2)
circuit.cx(0, 1)
circuit.reset(0)

pm = PassManager(
    [
        TimeUnitConversion(durations),
        ALAPScheduleAnalysis(durations),
        ConstrainedReschedule(),
    ]
)

_ = pm.run(circuit)

output
Traceback (most recent call last):
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/runningpassmanager.py", line 226, in wrapper
    return meth(*meth_args, **meth_kwargs)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/runningpassmanager.py", line 148, in run
    return super().run(
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/passmanager/passrunner.py", line 235, in run
    passmanager_ir = self._run_pass_generic(
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/passmanager/passrunner.py", line 190, in _run_pass_generic
    passmanager_ir = self._run_pass_generic(
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/passmanager/passrunner.py", line 151, in _run_pass_generic
    passmanager_ir = self._run_base_pass(
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/runningpassmanager.py", line 188, in _run_base_pass
    pass_.run(FencedDAGCircuit(passmanager_ir))
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passes/scheduling/alignments/reschedule.py", line 241, in run
    self._push_node_back(dag, node)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passes/scheduling/alignments/reschedule.py", line 122, in _push_node_back
    raise TranspilerError(f"Unknown operation type for {repr(node)}.")
qiskit.transpiler.exceptions.TranspilerError: "Unknown operation type for DAGOpNode(op=Instruction(name='reset', num_qubits=1, num_clbits=0, params=[]), qargs=(Qubit(QuantumRegister(2, 'q'), 0),), cargs=())."

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passmanager.py", line 447, in wrapper
    return meth(*meth_args, **meth_kwargs)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passmanager.py", line 154, in run
    return super().run(
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/passmanager/passmanager.py", line 225, in run
    out_program = self._run_single_circuit(in_programs[0], callback, **metadata)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passmanager.py", line 173, in _run_single_circuit
    out_program = pass_runner.run(input_program, callback=callback, **metadata)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/runningpassmanager.py", line 228, in wrapper
    raise TranspilerError(ex.message) from ex
qiskit.transpiler.exceptions.TranspilerError: "Unknown operation type for DAGOpNode(op=Instruction(name='reset', num_qubits=1, num_clbits=0, params=[]), qargs=(Qubit(QuantumRegister(2, 'q'), 0),), cargs=())."

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ima/tasks/3_2023/ntc/ntc-ibm-programs/tmp/432-min.py", line 22, in <module>
    _ = pm.run(circuit)
  File "/Users/ima/tasks/3_2023/qiskit/terra/qiskit/transpiler/passmanager.py", line 449, in wrapper
    raise TranspilerError(ex.message) from ex
qiskit.transpiler.exceptions.TranspilerError: "Unknown operation type for DAGOpNode(op=Instruction(name='reset', num_qubits=1, num_clbits=0, params=[]), qargs=(Qubit(QuantumRegister(2, 'q'), 0),), cargs=())."

What should happen?
If ConstrainedReschedule does not support reset instruction, it would be great if the error message is more comprehensive rather than "Unknown operation type...".
Any suggestions?
No response

Thanks @t-imamichi. It seems that running ConstrainedReschedule on circuits with resets became disallowed in my PR #10007, in particular due to the following code:
if isinstance(node.op, Gate):
    alignment = self.pulse_align
elif isinstance(node.op, Measure):
    alignment = self.acquire_align
elif isinstance(node.op, Delay) or getattr(node.op, "_directive", False):
    # Directive or delay. These can start at arbitrary time.
    alignment = None
else:
    raise TranspilerError(f"Unknown operation type for {repr(node)}.")

I don't know whether resets cannot be supported, or whether resets behave like Measure, or whether resets can start at arbitrary time.
I agree that the error message is not very helpful.

Thank you for your information!


[CN] This commit fixes issue #295

Fix the Chinese translation error referred in issue #295

Thank you @cizixs!! 😁


Mixed Workload 7 1.11

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-39476 Scalable mixed workload with DRF on 1.10 .

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

rebased to latest 1.11

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee


feat: Add replaceChild and replaceAll methods [WIP]

Description
This adds two utility methods, replaceChild and replaceAll, as per suggested:

There are some points to consider about the implementation:

should we wait for the removal? remove methods are not awaitable currently
what if we are trying to replace something with itself?
what if the removal portion fails (component doesn't exist as child, etc)?
what if the addition portion fails (component already child of someone else, etc)

@erickzanardo what do you think of the questions above, since you had the idea originally?
Checklist

[x] I have followed the Contributor Guide when preparing my PR.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

I believe the replace() method is a much needed functionality, I believe I've seen several cases in the past where it might have proved really useful.
However, a simple ..remove(child)..add(newChild) combo is too trivial. A much more useful functionality would be if the replace() method could replace a component without losing its order within the parent's list of children. That is, an actual replacement.
It would be more challenging, of course, since we can't really rely on priority field here. But it should be doable, probably needing a new method within the OrderedSet.
As for replaceAll() method -- its name suggests that it replaces all components within the parent. So why not make it like that? replaceAll(Iterable<Component> newChildren) would simply remove all current children and add new ones. This would be simpler to implement than the replace().

should we wait for the removal? remove methods are not awaitable currently

I'd say the replace() method should not be async at all, for several reasons:

this would create an impression that the returned future resolves once the new component has fully replaced the old one, which isn't true;
returning such future is possible, it's just newChild.mounted -- but in most cases it won't be needed, and in those cases where users might want it, they can just access the .mounted future directly.

It is worth pointing out that the future returned from Component.add() also suffers from a similar problem: it creates an impression that the future resolves once the component was added, which is not true. Instead, .add() returns a future that resolves when the component finishes loading, and even that only sometimes.

what if we are trying to replace something with itself?

This should probably be a no-op.

what if the removal portion fails (component doesn't exist as child, etc)?
what if the addition portion fails (component already child of someone else, etc)

This should produce assertion errors, similarly to how .remove() and .add() work right now.

Those are good points @st-pasha, thanks for the thorough review
for the return type: agreed. I will change to void
for the replaceAll: agreed. we can have the Map<to, from> version too and call it something else if @erickzanardo feels passionate about that signature
about the "keeping the order": I agree it would be nice as a user, and I agree it is hard but doable, but I have fears that it might actually cause more confusion than it's worth.
while we could add a "bypass" to ordered_set, it would be kept in a "wrong" state. if anything re-set it, the ordering would suddenly shift.
also it would be weird for unaware users that might for example try to setup a specific priority and it "does't work" because some elements were replaced and had "phantom" priorities.
I think there is a question to be had about getting completely rid of priority, but mixing both priority + a bypass seems more confusing that its worth. wdyt? and also everyone else

it would be kept in a "wrong" state. if anything re-set it, the ordering would suddenly shift.

Ah, that's true. We could make a distinction here that when B replaces A and they have the same priority, then B is put exactly where A was. However, if their priorities are different, then we perform the regular add() and let the ComponentSet deal with the ordering. We could even have a special flag replace(A, B, {bool copyPriority = false}) which would copy A's priority to B.
There are many cases where the user doesn't explicitly set the priority of components and thus they all remain at 0. At the same time, the relative order of those components still matters, and replace should honor it.

I think there is a question to be had about getting completely rid of priority, but mixing both priority + a bypass seems more confusing that its worth. wdyt?

We had a discussion about this some time ago (#1457), but I don't think we figured out what to do there.

for the replaceAll: agreed. we can have the Map<to, from> version too and call it something else if @erickzanardo feels passionate about that signature

That is a fair point, I agree that replaceAll would replace all the current components to the received set.
About having a version that receives a Map<to, from>, we could name it replaceWhere, wdyt?

About having a version that receives a Map<to, from>, we could name it replaceWhere, wdyt?

replaceWhere sounds more like it should replace if it fulfills some precondition.
Maybe this isn't needed? It would be pretty easy for the user to just iterate over that map and run replace instead?

I agree and disagree :P

replaceWhere sounds more like it should replace if it fulfills some precondition.

Exactly, the map that you pass is they one that sets that condition right, it is a one to one condition clause, but a clause nevertherless?

Maybe this isn't needed? It would be pretty easy for the user to just iterate over that map and run replace instead?

I agree with that hahahha

Going to close this for now since we never really reached a conclusion and I never followed up. I will open an issue and link this discussion, if anyone is interested to take this on.


[dark theme] Don't work

I set theme dark and not work.
const chartProperties = {
          width: document.body.height,
          height: document.body.width,
          theme:"dark",
          timeScale: {
            timeVisible: true,
            secondsVisible: false
          },
}

which docs I can see the theme option and how to set it.

I set theme dark and not work.
const chartProperties = {
          width: document.body.height,
          height: document.body.width,
          theme:"dark",
          timeScale: {
            timeVisible: true,
            secondsVisible: false
          },
}

I set theme dark and not work.
const chartProperties = {
          width: document.body.height,
          height: document.body.width,
          theme:"dark",
          timeScale: {
            timeVisible: true,
            secondsVisible: false
          },
}

which docs I can see the theme option and how to set it.

Where you've find it? We don't support themes ouf-the-box, but you might apply any custom themes via options (colors, settings, etc).

See https://jsfiddle.net/TradingView/6yLzrbtd/


A student has one active IEP document; not many

Notes

Updated my understanding of the IEP data model after a conversation with John Breslin: https://github.com/studentinsights/studentinsights/pull/1102#issuecomment-332923369

Checked in the production database; there are some students with more than one IEP so will need to write a migration to destroy all except the most recent.

Tested the migration in production without actually destroying any records (commented out the line that actually destroyed database records); looks good.


Create DoraLsCommandIntegrationTest

What changes are proposed in this pull request?
I have created a new file named DoraLsCommandIntegrationTest and it can test the 'ls' command whether it can correctly run.Also, I revised the base class that can create byte files in alluxio.What's more, I have added a new test named DoraMkdirCommandIntegrationTest which it can test cli 'mkdir'.
Why are the changes needed?
1、New Test does not have a function that can create file in alluxio.
2、Add a IntegrationTest.
Does this PR introduce any user facing changes?
No.

Good job!

alluxio-bot, merge this please.


Change service date to have a start and end date

Change the current service date column to be a service period start and end date

Placeholder values for service period separators: January 10, May 10, September 10.


Catalog-of-my-things: Setup

What this PR does:

Setup GitHub Actions
Setup Rubocop linter
Created .gitignore file

thanks @NataliaPoletaeva :+1:


Npm scripts explorer: cannot debug node versions < 8.0

testing #48354:

use nvm which 7.10.1 to find the path to a node executable of a pre-8.0 version of node
create an npm script that uses this version of node, e.g.
"debug": "/Users/weinand/.nvm/versions/node/v7.10.1/bin/node --debug-brk hello.js"
in npm script explorer select the new script and run the context menu action "Debug" on it

Observe: debugger times out after 10 seconds.
I've debugged this on the VS Code side and the problem is a missing "protocol": "legacy" attribute in the launch config passed to vscode.debug.startDebugging. Without that the debugger assumes the "inspector" protocol.
I suggest to always pass the "protocol" attribute. Use a value of "inspector" when detecting a "inspect" option and a value of "legacy" when detecting a "debug" option in the npm script.

@thanks for tracking this down!


Edit/Delete custom email addresses

The steps to edit or delete a custom email address does not reflect the actual behaviour. The ellipsis is for editing the domain, not the individual email addresses. I've attempted to edit and delete addresses from within this screen however the changes are not retained after closing the confirmation screen.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de7f630e-4f17-e26e-9301-104da653b3b6
Version Independent ID: c6030265-1d20-3981-5540-3fc387df4176
Content: Customize the From address of the email
Content Source: cv-docs/customize-sender-email.md
Service: dynamics-365-customervoice
GitHub Login: @sbmjais
Microsoft Alias: shjais

Thanks for the feedback. We have updated the documentation: https://docs.microsoft.com/en-us/dynamics365/customer-voice/customize-sender-email. Closing this issue.


dark background on error view when using dark theme

What steps will reproduce the problem?
On the latest Google Chrome version when using a dark theme on the OS (Windows 10) it sets the default page color to black instead of white.
This makes the error page unreadable (look at the provided screenshots)
Setting the background color to white on the body element solves it. I could make a PR but I am not sure where the styles are located.
What is the expected result?
To see the error page with white background (using Windows 10 light theme):

What do you get instead?
Using Windows 10 dark theme

Additional info

Q
A

Yii version
2.0.45

PHP version
7.4

Operating system
Windows 10

Browser
Google Chrome  98.0.4758.102

I'm not sure what is going here but did you put word dark before return and expect it to work?

Ohh, my bad, this is just to show the contrast, right?

Yes, I put the string dark on purpose to force the error page.

error view use outdated highlightJs, replace code and any theme


code-gen: support atomic updates in generated queries

Some things that come to mind:

basic arithmetic operations on the number type
string concatenation
add / overwrite / delete value in array field
add / overwrite / delete value of jsonb column

This is going to bump the generated file size by a lot, so I think we want to refactor this to to the same as the 'where' generator


Create all of the endpoint classes, with empty handlers

This issue focus on registration of the endpoints. The handle method does not implement concrete implementation.

Oh, so what you are saying with "registering", is really just creating the empty endpoints? If so, then by all means go for it.

Haha yeah, maybe sounds silly but do get my point of the issue will get too big?

For any endpoint, we should make its own issue.

I am not sure if I follow. The way I understood your phrasing was that this issue should create all of the endpoint classes, with empty handlers (which on its own sounds like a lot for one issue).
FEP automatically scans the program for endpoints and registers them accordingly.
So I am not sure what you mean.
Please clarify.

Sorry for the vague phrasing. But yeah, you understood me right. This issue says create all of the endpoint classes, with empty handlers.
What do you say we should do for the part you're saying "which on its own sounds like a lot for one issue"?

I am saying that it is a lot to review in one issue. It might just be better to create an issue for each endpoint. That will reduce the scope.

Which includes the implementation of the handlers as well?

Other this to discuss. How should we deal with packing/foldering them? A folder for an endpoint?
├── server
│   ├── FirstEndpoint
│   │   ├── Request.cs
│   │   ├── Response.cs
│   │   ├── Endpoint.cs
│   │   ├── Mapper.cs
│   │   ├── Validator.cs
│   ├── SecondEndpoint
│   │   ├── Request.cs
│   │   ├── Response.cs
│   │   ├── Endpoint.cs
│   │   ├── Mapper.cs
│   │   ├── Validator.cs
│   ├── Program.cs

Leave the handlers empty, but fill the constructors.
That structure looks good! I assume that not all endpoints has validators and mappers right?

Other this to discuss. How should we deal with packing/foldering them? A folder for an endpoint?
├── server
│   ├── FirstEndpoint
│   │   ├── Request.cs
│   │   ├── Response.cs
│   │   ├── Endpoint.cs
│   │   ├── Mapper.cs
│   │   ├── Validator.cs
│   ├── SecondEndpoint
│   │   ├── Request.cs
│   │   ├── Response.cs
│   │   ├── Endpoint.cs
│   │   ├── Mapper.cs
│   │   ├── Validator.cs
│   ├── Program.cs

I will add this to the wiki


support dot(vector, vector) for fp16 inputs on GPU

Description
As title. @ptrendx @szha @DickJC123
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [pr-awaiting-review, Operator]

@szha @ptrendx @DickJC123
Could you please help review the PR?


Inpainting seems to alter parts of the image that are not in the inmapinting area.

When trying out inpainting it seems to alter parts of the image that are not in the inpainting region. I can show some examples if you would like.

It's not supposed to do that!
Please post a couple of examples, and be sure to provide the transparent and/or mask image.

Its probably user error, but here are the pictures and the command I used. In the output it looks like his mouth has been modified.

I tried to run it in full precision mode and it did the same thing. Could it be because my image is 32 bit depth and the output image is 24 bit?

I think this may be the result of repeated png decompression/recompression
rather than anything the AI is doing. I'm going to give you a switch to
change the PNG compression level and then you can try with compression of 0.
Lincoln
On Fri, Oct 7, 2022 at 8:14 PM Eu4yk @.***> wrote:

I tried to run it in full precision mode and it did the same thing. Could
it be because my image is 32 bit depth and the output image is 24 bit?
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/978#issuecomment-1272172827,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMGRTWQ2XSKJGENIBDWCC4GNANCNFSM6AAAAAAQ7ZKNUE
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Written on my cell phone. Anything that seems odd is the fault of
auto-correct.

Thanks for taking the time to look into it. Your the best :D I wish I couldn't been more of a help, sadly I just code for fun.

Just to let you know that this is still in the queue, but may be a couple of days because of other obligations.

Hi @lstein
It seems unlikely to me that PNG re-compression is the culprit here because it is lossless. The compression amount as I understand it is simply a trade-off between file size and the cost of decompressing the image. Therefore, end result should be the same as the input every time and there should be no cost in un-compressing and re-compressing.
I think this is particularly noticeable in the new inpainting Web UI. If you send an image to inpainting and select a 512x512 region to inpaint, you can often see that inpaint box in the resulting image, and it varies from iteration to iteration.
Here's my original image at 704 x 512 (note the completely smooth gradient in the background)

Here in the UI with the central region selected for inpainting and a mask applied

And here is a particularly obvious example after I asked for a lego man to me inserted:

and a diff between the two:

Here's another example from the exact same invocation... this time the AI completely forgot to add a lego man despite the prompt asking for one but....

This time the background is darker inside the bounding box, not lighter.  Here's diff (brightened a bit to show the effect better):

@psychedelicious apologies for the delay in replying, this was indeed fairly shortly after the 1.5 inpainting model was available, seems all good now. Thanks.

@ctalibard Good to hear, thanks for getting back to us.

Are we sure this is truly fixed? It still seems to be happening in recent versions.


Some bug fixes, I think there's no actual tests yet

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #10 (79cdc9c) into master (36afac8) will decrease coverage by 1.69%.
The diff coverage is 69.32%.


Weka refinement

Cleaning up some of the Weka interface code.

Merged in with both master and the cure branch.
Jon, Ying, and Will, please take a look... this should have much better prediction accuracy from Weka.


Review existing API endpoints

It seems that some of the API endpoint have changed since their original inception in this package. In most circumstances, either additional request parameters have been added, or additional response parameters have been added on Twitch's end.
For example, the Get Clips endpoint has the following request parameters: id, broadcaster_id, game_id, after, before, ended_at, started_at and first. Of which only id is catered for in this package as it currently stands.
We need to review all implemented endpoints to verify they are to current spec.

I'm currently working on this issue. See here.