Added Product Page

Related Issue
#564 Created a Buy Product Page for Farmers
Description
[Please include a brief description of the changes or features added]
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/113294672/3a5315d1-2493-4504-a795-2e2a3ad0244b
Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Please don't add this on home page create a separate page.

And don't make any changes in home page

I have created a separate page

Create a services option in navbar under which create a option Buy products and attach your page there. Also remove all the changes made on home page. I can see the social icons in footer can't be seen but on my side its perfectly fine so look into it.

If you have made the changes kindly attach a video.

I have already attached the video

There are conflicts in this branch

Done

No change is visible as it is showing the files are deleted. Create another PR with all the files again.


Sleuth + WebMVC + log4j2 can't log traceId and spanId

Sleuth + WebMVC + log4j2 can't log traceId and spanId
log4j2 version:  2.11.0
spring-boot version: 2.3.2.RELEASE

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Fix issue with UserAPIKey.key returning incorrect value

Fixes: https://github.com/realm/realm-swift/issues/8021

Would be interesting to test againts the admin API if the server API key is the same as the one we receive in our end, but because this is a short fix is not necessary and probably something that will be better to be tested in core.


Parse server seems to return incorrect count if master key is provided

Check out this issue for an ideal bug report. The closer your issue report is to that one, the more likely we are to be able to help, and the more likely we will be to fix the issue quickly!
For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities. For database migration help, please file a bug report.
Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites.

[x] You're running the latest version of Parse Server.

[x] You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Parse server seems to return incorrect count if master key is provided.
Steps to reproduce
Request from parse-dashboard (Chrome dev tools / Copy as CURL)
$ curl 'https://SERVER_ADDRESS/classes/DiscoverLike'
-H 'pragma: no-cache'
-H 'accept-encoding: gzip, deflate'
-H 'accept-language: en-US,en;q=0.8,lt;q=0.6,ru;q=0.4'
-H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36'
-H 'content-type: text/plain'
-H 'accept: */*'
-H 'cache-control: no-cache'
--data-binary '{"where":{},"limit":0,"count":1,"_method":"GET","_ApplicationId":"1B804BBB-581B-4AE0-8A48-33E017B4D1F2","_ClientVersion":"js1.6.14","_MasterKey":"REMOVED_FOR_PRIVACY"}'
--compressed | underscore pretty

Response:
{ results: [ ], count: -1 }
Modified request with removed _MasterKey;
$ curl 'https://SERVER_ADDRESS/classes/DiscoverLike'
-H 'pragma: no-cache'
-H 'accept-encoding: gzip, deflate'
-H 'accept-language: en-US,en;q=0.8,lt;q=0.6,ru;q=0.4'
-H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36'
-H 'content-type: text/plain'
-H 'accept: */*'
-H 'cache-control: no-cache'
--data-binary '{"where":{},"limit":0,"count":1,"_method":"GET","_ApplicationId":"1B804BBB-581B-4AE0-8A48-33E017B4D1F2","_ClientVersion":"js1.6.14"}'
--compressed | underscore pretty

Response: (As expected)
{ results: [ ], count: 13 }
Logs/Trace

Closing due to lack of activity, please update to latest parse-server version and reopen if the issue persist.
Don't forget to include your current:

node version
npm version
parse-server version
any relevant logs (VERBOSE=1 will enable verbose logging)


If child component has no public methods parent component re-render fails

Hey, great work, congrats! Really enjoying playing with Tetra :)
Noticed one mini bug/issue - if child component has no public methods parent component re-render fails. Because child components without public methods doesn't have __state and THIS check fails. Because wrong (parent) component is resolved from data["state"]. Not sure how to address that best :)
Steps to reproduce
One way to reproduce - just remove all @public methods from example ToDoItem component and try adding couple of new items/to-dos. Adding a dummy public method fixes the issue.
@default.register
class ToDoItem(Component):
    title = public("")
    done = public(False)

    def load(self, todo):
        self.todo = todo
        self.title = todo.title
        self.done = todo.done

    template: django_html = """
    <div class="list-group-item d-flex gap-1 p-1" {% ... attrs %}>
        <label class="align-middle px-2 d-flex">
            <input class="form-check-input m-0 align-self-center" type="checkbox"
                x-model="done">
        </label>
        <input
            type="text"
            class="form-control border-0 p-0 m-0"
            :class="{'text-muted': done, 'todo-strike': done}"
            x-model="title"
            maxlength="80"
        >
    </div>
    """

    style: css = """
    .todo-strike {
        text-decoration: line-through;
    }
    """

Current behaviour
500 error (Component of ivalid type.) when calling parent component public method which re-renders the template.
Thank you!

Thanks for the report, really appreciate the feedback! I’m not surprised I had missed something there…
So the reason for excluding the state on components with no public methods was to reduce the output html size. Clearly forgot about that after I got nested components working.
Easiest fix would be to always include the state, but would be better to keep track of if any parent has public methods. Will take a look today and fix it one way or the other.
(As an aside, the next thing on my to do list if a full set of tests so that these sort of issues are covered. Obviously needed before anyone would want to use Tetra in production)

I have just released v0.0.2 which fixes this. I have removed the check for public methods so the state is always included. I'm going to revisit excluding state for efficiency at a later date, it will need a little thought how best to do as there are quite a few edge cases. Thanks for the report again!


Authoring guidelines: general

Breakdown of #139
This part would be a set of guidelines related to authoring activities in general, which would have to be followed by every type of content and every author. I am not sure yet if there will be enough of them to create separate section, but let's see.
Proposed guidelines:

Meta

all types of guidelines should be followed where applicable, and can be ignored where not.
should be used by authors while writing, and for reviewers before approving
... somehow encourage users to participate in reviews

Quality

do your best, stick to guidelines specific to the type of created content (kata, translation, snippets, ...)
When reviewing, do it properly.
you keep responsibility for all content you approved or created. Fix issues, consider suggestions, answer questions.
if your content does not keep up to quality standards, others are allowed to improve it
in extreme cases, privileges for authoring or approving can be revoked
when in doubt, ask for help

Do you think such set of general rules will be OK?

I guess so, but not sure it needs to be separated from CoC. => ?

I think CoC is more about relations between community members, like be nice, don't cause harm, etc. This one is strictly about content, i an not sure if these two belong together.

I am thinking about adding a guideline which would state that existing solutions should not prevent improvements.  But I am not sure what should be the extent of such guideline. For example I am not sure if renaming a function because its name does not conform to PEP is sufficient reason for 4 years old kata with 3k of solutions. OTOH there are many old kata with many solutions which definitely should be fixed because they are simply broken and possible to pass only because of hints available in discourse.
What do you think?

sounds like another section about "maintaining kata", imo.

Could be, yes. But having it here in the official (I hope) guidelines would make it (as suppose) enforceable and could be used as an argument for authors who say that "yeah I know there's a problem, just resubmit 5 times and it will pass. I won't fix it because there's 1000 of solutions".
Point them to the guideline, ask politely to comply, and if it does not help, fix it by yourself.

Also maybe something about sticking to the guidelines rigorously for new content, and somehow easier for the old kata? I am not sure how to approach this, I imagine there could be some people wanting to fix some old, bugged kata and possibly call out the guidelines to finally be able to do this. Should they be allowed to so?

I'd say there are several things at stake, here:

what to do about minor "bugs"?
how lax to be about those minor "bugs"?
what to do about major bugs? (here it's easy: fix them)
critical part: when does a problem fall into one or the other category?

As usual when it comes to this, the main problem will actually be that people will disagree. And with a lot of energy (why do I think about FArekkusu, suddenly? x) Well, I bet I fit into the categro as well...). So even with a direction, differences in interpretation will be huge.
So I'd just stay pretty "vague". Something like

Bugs need to be fixed. Even if discovered long after the approval. Other things, if not harmful for the kata (like wrong naming conventions) could be fixed, especially when it's possible to do so without breaking old solutions, but it's not mandatory. Tho, if the author doesn't want to fix it himself, he'd have to suffer the presence of the related issue(s), so that a PU can go by and fix it if he wants.

?
Ofc, @kazk opinion here is of critical importance. => ?

Maybe try and differentiate somehow between bugs (which prevent valid solutions from passing in some way), and style (naming, coding conventions)?
We have two opposite sides here: one side is authors not wanting to comply (mentioned already in this post ), and another is (over)eager reviewers and users fed up with poor quality going edit-frenzy because now they finally can.
I am not really sure how to address it in guidelines.

Sounds to me like people related, hence, s a lost cause up front...? x)
Not really sure what to suggest. But if people have to comply in a way or another, there is one sure thing: there need to be some kind of (meaningful) consequences if they do not comply. And not just a bunch of honor points. Otherwise ntohing will "move".

I am thinking about adding a guideline which would state that existing solutions should not prevent improvements.

Yeah, in general, invalidating existing solutions should not prevent improvements. If it's possible to make the change backwards compatible without too many hacks, it should be considered though.
Sometimes the issue is relatively minor and a fix is not really worth it. Those should include a disclaimer in the description acknowledging the issue so the new users will know it's a known issue and it's not fixed because of historical reason.

OTOH there are many old kata with many solutions which definitely should be fixed because they are simply broken and possible to pass only because of hints available in discourse.

If the solver needs to dig through the comments, then that information should be included in the description. It's much more efficient for the authors too, so I don't understand why they decide to keep replying to similar comments over and over instead of improving the description.

So even with a direction, differences in interpretation will be huge.

Having clear guidelines should help.

But if people have to comply in a way or another, there is one sure thing: there need to be some kind of (meaningful) consequences if they do not comply. And not just a bunch of honor points. Otherwise ntohing will "move".

Yeah, that's what I've been concerned about.
As I've been saying, it's difficult to start enforcing some rules after so many years of chaos. I don't expect this to go smoothly at all, but we need to start it.

If the solver needs to dig through the comments, then that information should be included in the description. It's much more efficient for the authors too, so I don't understand why they decide to keep replying to similar comments over and over instead of improving the description.

Sometimes, even having hints in description how to work around issues should not stop the kata from being fixed at (almost) any cost. Sometimes the explanation is in the description, but this explanation is something like "if you keep failing due to precision errors, try reordering operations in your formula". All issues are insta-closed because, uh, excuses are many: "it's user error", "it works if you do things in good order", "there are 2k solutions so kata is ok", "there are 2k solutions so it's too late to fix it".
Yeah, kata with issues related to FP precision, rounding, handling floats as strings, these are particularly fun :) both to solve, and to fix.

Closed with #173


UILayoutPriorityDefaultLow in iOS 11.2 is invalid!

New Issue Checklist
In iOS 11.2, to run Masonry's demo, I get a constraint error.
Issue Info

Info
Value

Platform
e.g. ios

Platform Version
e.g. 11.2

Masonry Version
e.g. 1.1.0

Integration Method
e.g. cocoapods

Issue Description
In MASExampleUpdateView class, followed code:
[self.growingButton updateConstraints:^(MASConstraintMaker *make) {
make.center.equalTo(self);
make.width.equalTo(@(self.buttonSize.width)).priorityLow();
make.height.equalTo(@(self.buttonSize.height)).priorityLow();
make.width.lessThanOrEqualTo(self);
make.height.lessThanOrEqualTo(self);
}];
In this block, priorityLow() method make self.growingButton's both width and height constraint priority to @1000, then click button to update constraint is invalid.

this issue is caused by UIButton's contentSize, which have default width and height priority(@250), you reset this button's width and height to priorityLow, so that both width and height constraint ambiguity.


Object-Graph Mapper Interfaces. Script Management. Correct handling of Decimals.

Hello,
I started making these changes mostly because the Bulbs project had no obvious way to properly specify and communicate Decimal properties on classes. If you have used sqlalchemy before, you will notice its strong influence on the 'ogm' layer here.
I trust these additions will be valuable, since I see there have been multiple false-starts along similar lines. And according to http://www.slideshare.net/fphhotchips/a-quick-review-of-python-and-graph-databases, they seem one of the main things holding OrientDB back for python developers.

I should mention, these changes are also dependent on the recent changes to expose Gremlin functionality by @lebedov

These most recent changes make the query interfaces substantially more expressive. Still to come, support for the TRAVERSE command.

Hi
@TropicalPenguin Great features you have added there. And as you've mentioned, lack  of ogm features is one of the things holding orientdb back.
I had actually started a similar library (https://github.com/davidkyalo/orientedpy) a while back though I haven't had time to do much. The idea behind Orientedpy was to create a simple OGM driven by pyorient.
However I think having these features under pyorient would be better. And that way we can focus our efforts in maintaining it.

Hi all,
@TropicalPenguin  i'm very happy you worked on that, i will merge your code and add this Pyorient.
In my mind the driver would have had to grow up so, with the contribution of all users, so i can use the time to work at the internals.
I will mention this feature in the Readme and i will quote it as early development stage and to be tested. More documentation, tests or code for that is welcome.
@davidkyalo thank you, if you want contribute directly to this driver you're welcome too.
Thank you again


Link related with setting up a custom web hooks for MS Teams not working

Link:
https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/connectors#setting-up-a-custom-incoming-webhook
displays wrong page - "page not found".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbdb8216-60c7-a0a1-7eb6-02d42d783292
Version Independent ID: 77a75dd2-6f45-bc76-b968-0cf58c427ef5
Content: Requested page cannot be found. - Teams
Content Source: msteams-platform/404.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Should be good now, thanks for letting us know.


Tildify path in title bar

This will shorten the directory path displayed in the title bar
PR:

Master:

:-1: on this as it introduces another dependency and because this is unexpected behavior on Windows.

@50Wliu Got it. I didn't thought about Windows.

/cc @atom/feedback

I agree with @50Wliu. A version of this that didn't introduce a dependency and didn't modify the displayed path on Windows would get a 👍 from me.

I opened a PR (https://github.com/atom/fs-plus/pull/32) to include this functionality in fs-plus. This won't add another dependency and doesn't have a effect on windows.

I'm going to close this and reopen when https://github.com/atom/fs-plus/pull/32 is merged.


[Feature]: Resource start, stop, restart queue

Scope
Web
Feature Description
I want to know if it is possible to make a selection of resources in the resources list start in a queue. If it could be done it could be a great time saver
Use Case
I have had a lot of times where I need to restart, stop or start a few resources at the same time and doing this by writing commands or via the resources tab is not all that fast.
Proposed Solution
You have a selection box right next to a resource and if you select more than one you can choose to start, stop or restart the selected resources.
Additional Info
No response

I think your issue is very very particular.
If it's always the same resources, I recommend saving a restart_things.cfg alongside your server.cfg containing the exact operations you execute (stop/ensure/etc) and when you need you can just run exec restart_things.cfg in the live console.

For now i'm closing this feat request, but am willing to reconsider if new information comes up.


Issue32

adding events page and attaching it to the navigation.

Not sure how to change my "approve" but I believe you want to use android:src and not tools:src In your fragment_events.xml file to get the image to show up on the app.  I downloaded your code and used android:src="@drawable/img"to verify that I was able to see that image on your card in the emulator.  Without that change to your code, the card does not show an image to me.
Per https://stackoverflow.com/questions/39753804/differences-androidsrc-and-toolssrc


Allow parrying with arbitrary non-tool items

Some mods, like Tetra, have tools and weapons that for some reason don't inherit from the vanilla ToolItem class, which means they won't be able to parry with this mod.
A config setting to manually add a list of items (or tags) to the mod's item types would solve this, but I think allowing any item with an attack speed attribute to parry (with block/parry cooldowns proportional to its attack speed, maybe with a multiplier config setting for each) would work better, as it would cover more or less every item someone is likely to want to parry with, in any mod, while allowing modded weapons with faster attack speeds to automatically have a lower parry cooldown, which I think makes sense.

Done


Fixes fair view crash on fairs with no profiles #trivial

For example: https://www.artsy.net/affordable-art-fair-battersea-spring-2019

nice call


Missing Civo with GitLab installation flow diagram

What type of suggestions?
Missing Information
What page is concerned?
https://docs.kubefirst.io/preprod/kubefirst/civo/gitlab/install
What is the issue?
Missing Civo with GitLab installation flow diagram.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I requested the design team to create one for light & dark themes (sorry, internal link).


Monitor EBS volumes being resized and resize filesystem and partition automatically

As of yesterday, AWS now supports EBS volume resizing. A while back, @edolstra added support for resizing the filesystem on boot of our EC2 instances, but it would be cool if we supported the resize live. I don't know how to monitor the underlying resize event though. Once we can catch it, it seems fairly easy to apply the same logic that he added at boot time.

Are there any updates to this issue, please?


Switching tabs doesn't update command bar

When switching tabs, the search bar and the command buttons do not update to the corresponding tab.
This functionality slipped past development.

Fixed.


Adding a parameter to scale the data in each fitter internally

Normally the data needs to be scaled, so that the fitters can converge when minimizing the negative log-likelihood. It is trivial to scale the parameters afterwards in order to get the correct order of magnitude of the parameters.The problem with this approach is, however, that we loose all the built-in functionality of lifelines, i.e. we cannot directly use the summary information nor the graphics, since they are in another scale.
Maybe I am missing something, but in case I am not, it would be nice to add a parameter to consider scaling the data internally, so that directly after the minimization process the necessary parameters would be re-scaled. Then, all the statistics (max log-likelihood, confidence intervals, etc.) could be computed using these parameters. Maybe it could be defined at the moment of creating the fitter object, like this:
from lifelines import WeibullFitter

weibull = WeibulFitter(data_scaling_factor=1e-2)

weibull.fit(...)

This would require for each fitter to define which parameters should be scaled (typically the location and scale if present). What do you think @CamDavidsonPilon ?

I've thought about something like this too, but I would want it to be automatic, i.e. the user doesn't need to know this is happening. This came up when dealing with the Gamma stuff recently.

That would be even better. However, I have realized that it is not so trivial to implement (especially considering the parametric models, e.g. AFT, where the regression coefficients would need to be scaled). It would imply some extra considerations for user-defined fitters. If something like this is implemented, maybe it should be deactivated by default?


test failure with testDeepCloneWithJsonParser

Data which is serialized to JSON is not ordered
18:23:36 com.couchbase.lite.util.DeepCloneTest > testDeepCloneWithJsonParser[hudson_en-US_160_WVGA_android-19_armeabi-v7a_param(AVD) - 4.4.4] FAILED
18:23:36 	junit.framework.ComparisonFailure: expected:<{"[map":{"hello":"world"},"ints":[1,2],"objs":["a","b"]],"list":["a","b"]}> but was:<{"[objs":["a","b"],"ints":[1,2],"map":{"hello":"world"}],"list":["a","b"]}>
18:23:36 	at com.couchbase.lite.util.DeepCloneTest.testDeepCloneWithJsonParser(DeepCloneTest.java:45)

PR https://github.com/couchbase/couchbase-lite-android/pull/1032


adjust spacing trading page mobile

This should be adjusted to have a bit less padding on the outsides of the text and add a small amount of padding to the middle section between the 2 columns of values. maybe something like this:

It should look like this for mobile. This should remove any of those issues
Design:
https://www.figma.com/file/fLWVwmanAwetVZbujQquEi/Market-Page?node-id=449%3A925

closing as there's a new ticket for handling this


geocode_location not an attribute?

Hello, I am trying to use the geocoding feature by passing it an address.  It says the below doesn't exist. Am I using this wrong?
googleplaces.geocode_location(location, sensor=False)
Converts a human-readable location to a Dict containing the keys: lat, lng.
Raises googleplaces.GooglePlacesError if the geocoder fails to find the
specified location.
My work around is using the places nearby, populating the latitude and longitude from places using a for loop, but my terrible coding is not letting this work, so I figured I'd ask if the geocode_location is supposed to still exist somewhere? I am using 1.3.

Hey @robertlmyers,
Doesn't this simple code work for you?
from googleplaces import geocode_location
print geocode_location('Buckingham Palace')

Sorry, I didn't realize I needed to import geocode_location. Still learning. I thought it was a part of the Google places import from the readme.  Thanks for the response!


Warn if goog.object.createSet optimization would create an illegal (in strict mode) object literal

https://closure-compiler-debugger.appspot.com/#input0%3Dvar%2520set%2520%253D%2520goog.object.createSet('a'%252C%2520'b'%252C%2520'b'%252C%2520'c')%253B%26input1%26conformanceConfig%26externs%3Dvar%2520goog%253B%250Agoog.object%253B%250Agoog.object.createSet%253B%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1
The object literal that is produced is illegal in strict mode. It looks like Chrome and Firefox are lenient on this but IE10 and IE11 (and possibly Edge) are not: They give an error: "Multiple definitions of a property not allowed in strict mode"
So it would be good for the compiler to give this error instead.

Already sent a change to remove the duplicate 'br' at https://github.com/google/closure-library/blob/b1c29d2d086eca9a603ab063a6d3957a22b57f25/closure/goog/format/htmlprettyprinter.js#L136-L137 but I suspect if we add this compiler error then we'll find more duplicates lurking :)


training on a custom dataset

Hi, thank you so much for sharing this great project!
I have trained the model using my own datasets, and the images size of my trained datasets is (1280,720).
In the first training, I trained my own datasets using input size of (512,288), and I got the results as figure 2.
In the second training,  I trained using input size of (1024,576), I only got a black image after 10epoch shown as figure 3，and I found the loss is not converge shown as figure 4.
I have only modified the input size in config file between the first training and the second training because the input camera intrinsics is normalization.
Do you have an idea what is going?
Thank you very much for your help!

Hi, I found another problem with the following code:

I want to know whether this parameter is fixed, and should it be changed to the same size as the input size as shown?
pose_feats = {f_i: F.interpolate(inputs["color_aug", f_i, 0], [self.opt.height, self.opt.width], mode="bilinear", align_corners=False) for f_i in self.opt.frame_ids}

(1) If you change the input image size, you should revise camera intrinsices.
For exmaple, denotes camera intrinsices is K which is a 3*3 matrix,
K[0] *= target_image_width / original_img_width
K[1] *= target_image_height / original_img_height
(2) the self.opt.height and self.opt.width is the image size for posenet, you should keep the same aspect ratio.

Thank you for your replay.
(1) I am sorry, I don't quite understand where this camera intrinsices should be modified. In this code, the camera intrinsics matrix k is normalization as following,

and in mono_dataset.py, camera intrinsics matrix can be obtained using the input size,
K[0, :] *= self.width
K[1, :] *= self.height
Is this the parameter K that needs to be modified?
(2) I have modified the image size(1024,320) to (512,288) in cfg_kitti_fm.py for training our datasets, whether the self.opt.height and self.opt.width should be replaced (192, 640) in posenet code?

(1) It is correct if you normalize the camera intrinsics before writing into cfg files.
(2) right, you can also use a smaller size, only if you keep the same aspect ratio.
I think the problem may caused by static camera, since the whole method is built on structure from motion theory, if no motion exist between continuous frames, it will make the whole scene is from a infinite distance.

@orange2xiaoyu hi, I meet the same problem using my own data, have you find a resolution? Thanks a lot!

Do you mean the first issue？
Maybe you load the kitti pretrained model before training?
But I haven't tested whether the problem will be solved if do not loading the kitti pretrained model,  maybe you can try it.

Do you mean the first issue？
Maybe you load the kitti pretrained model before training?
But I haven't tested whether the problem will be solved if do not loading the kitti pretrained model, maybe you can try it.

I mean i got  black image too using my own data，even if i removed the static images. Also, i used the imagenet pretrained weight instead of the kitti pretrained model.
Is your result still total black?

Are you sure you get the correct  camera intrinsics for your own data?
And whether the input size keeps the same aspect ratio with your original image size?

Are you sure you get the correct camera intrinsics for your own data?
And whether the input size keeps the same aspect ratio with your original image size?

I don‘t have the exact camera intrinsics for my own data, this might be the reason。
Yes, I do keep the aspect ratio.

Thank you for your timely reply, I will continue to try to solve this problem.

Hello @orange2xiaoyu. Did you find any solutions to remove black images when training on certain image sizes? I have tried multiplying the intrinsic parameter as follows:
K[0, :] *= self.current_width/self.original_width
K[1, :] *= self.current_height/self.original_height
More than that, I switched the hardcoded input size in pose_feats from [192, 640] to [self.opt.height, self.opt.width]. With all of this being done, some image sizes work, and some don't. What solutions did you find in your case? Thank you in advance!

https://github.com/sconlyshootery/FeatDepth/issues/40#issue-816588356
This issue said that when the width and height are multiples of 64 works, you can try whether this assumption is correct.
I will also check my code to figure it out.

mono/datasets/folder_dataset.py
BTW, you can refer to this code to build your own dataloader for your custom dataset.
And you can show me your codes about dataloader, I will help you review it.

This code for my custom dataset reference to kitti_dataset.py.
navinfo_dataset.txt

https://github.com/sconlyshootery/FeatDepth/blob/db7344ae9d9cefafc92983fc8c5b30920751be68/mono/datasets/mono_dataset.py#L152
Whether your image name is continuous, here the dataloader will find frame_index + i, if it fails, it will still load current image.

Of course, my image names are continuous.
And I can get correct depth image using input size of (512,288).

Someone tell me that the issue can be solved in this way, 'Later I figured it out that there was nothing wrong with the code. Due to a change in nvidia-driver version, I was facing this issue. I was able to solve this issue by installing numba==0.43.1. ’
You may try.

Ok, thank you very much!

I will close this issue, you can reopen it if you have further question.


Billing Address & Shipping Address

Both fields reference a new address model that will be in the https://github.com/tipoff/addresses/issues/19 package and both are nullable on Cart #34 and Order #32

The booking package will not use a shipping address.

How about https://packagist.org/packages/rinvex/laravel-addresses ?

I have a different approach to how I want to handle addresses. We can discuss later in the tipoff/addresses package

If product is not currently being shipped, is shipping address a placeholder for a far-off requirement?
Does address include contact information as well (phone for address)?  Or, does phone stay w/user (like email)?  (For shipped products w/expedited delivery, the carrier often wants a phone for the recipient which might not be the same as the purchaser).

Good point. In addition to phone and address, it might also need name in the case you are shipping to someone else. Let me think on it and get back to you.


feat: add extra stuff from mod.netlify.com

I used https://mod.netlify.com/ to generate the json and then cherry picked the missing parts. Hopefully this is an improvement. You tell me :)
refs #4632
closes #4632

Thanks for adding these fields. I'm curious how you found the submit site. It hasn't been publicized anywhere really.

@slibby is my homie


V4 Folders Extension

fallback folders (search one folder, then another if not there) #59
folders (find template in folder like admin::main)

@ragboyjr curious, why isn't it possible to add an array of folders during engine configuration?
Would be better DX if upstream did foreach dance :)

@lkraav an array is the canonical form of the base_dir, if you pass in a string, it converts it into an array :)


Fix inflight merge conflict by adapting rollingupdate to #2861

ClientConfig changed right as rollingupdate was introduced in #3061

@bgrant0607 Fixes the merge conflict I introduced, please merge when travis is passing.


feat: add description list element styling

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
What is the new behavior?
Adds support for cds-list on a dl element, as well as layout styling with dl/dd/dt
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
This is still in draft, but I wanted to get some early feedback.
A couple of open questions:

Should this be part of the existing list files/css?
If it should remain separate, should it use a different attribute than cds-list?

Screenshot:

Clarity, what about a default gap (md? sm? which do you prefer?) between dt+dd pairs? It seems like a decent thing to have by default, and then <dl cds-list="unstyled"> would remove both the gap and the font-weight on the dt

Should this be part of the existing list files/css?

I think they should be combined, ul/ol/dl kinda belong with each other IMO and I think using cds-list makes sense here.

Updated screenshot:

@colinreedmiller
Does this meet expectations UX-wise? The dl definition list largely follows the specification for forms. We are punting on the horizontal layout of having the dt and dd appear on the same line. Maybe the team can revisit that in the near future to lock down responsive behaviors, etc.?

@colinreedmiller
Does this meet expectations UX-wise? The dl definition list largely follows the specification for forms. We are punting on the horizontal layout of having the dt and dd appear on the same line. Maybe the team can revisit that in the near future to lock down responsive behaviors, etc.?

I agree with waiting on horizontal, if it is needed we will hear about it and can address adding it based on requirements - seems like an odd case offhand. Same line for dt and dd is not the sort of thing I'd recommend anyway simply because of usability / harder to scan and read. What I see in vertical with space and layouts is good.


Connect-MicrosoftTeams Limitation With -TeamsEnvironmentName And -CertificateThumbprint

When Connect-MicrosoftTeams is used with -CertificateThumbprint and -ApplicationId, the parameter set restrictions do not allow use of -TeamsEnvironmentName.  This is a problem because if -TeamsEnvironmentName TeamsGCCH is not specified when connecting to a TeamsGCCH tennant, some cmdlets such as Get-Team will fail with the following error:

Some cmdlets will work (such as Get-TeamUser) without specifying -TeamsEnvironmentName TeamsGCCH, but notably these cmdlets connect to graph.microsoft.com instead of graph.microsoft.us which is also not desirable.  The fact the cmdlets even partly work potentially present an information security issue.
Can the Connect-MicrosoftTeams parameter set be altered to support specifying -TeamsEnvironmentName TeamsGCCH when using -CertificateThumbprint and -ApplicationId or is there a workaround that can be used?

Alright, I developed a workaround for this by replacing the default environment ('AzureCloud') properties with the parameters of the government environment.  However, this would be easily fixed by adjusting the cmdlet parameter set properties so hopefully somebody can adjust it on the Microsoft side for the next version of the cmdlet.
Import-Module MicrosoftTeams
[Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments.Remove('AzureCloud')
[Microsoft.Open.Teams.CommonLibrary.Models.TeamsEnvironment]::setMsGraphEndPoint('TeamsGCCH',`
   [Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments['AzureUSGovernment'])
[Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments['AzureUSGovernment'].Name = 'AzureCloud'

Alright, I developed a workaround for this by replacing the default environment ('AzureCloud') properties with the parameters of the government environment.  However, this would be easily fixed by adjusting the cmdlet parameter set properties so hopefully somebody can adjust it on the Microsoft side for the next version of the cmdlet.
Import-Module MicrosoftTeams
[Microsoft.Open.Teams.CommonLibrary.Models.TeamsEnvironment]::setMsGraphEndPoint('TeamsGCCH',`
   [Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments['AzureUSGovernment'])
[Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments['AzureCloud'] = `
   [Microsoft.Open.Teams.CommonLibrary.AzureEnvironment]::PublicEnvironments['AzureUSGovernment']

Connect-MicrosoftTeams --CertificateThumbprint ...

@officedocsbot assign @yogkumgit

Thank you for raising this issue and sharing your workaround! I'm presently following-up with our team on next steps.

Thanks @brandber Brandon for your feedback here!
@NoMoreFood As the documentation currently shows that behavior in the parameter set, I do not see a need for a change in documentation. If the cmdlet is updated with your valuable feedback, we will proceed updating the cmdlet's article.
Thanks

@get-itips I agree that no documentation needs to be changed.  The only reason for even mentioning it here (which I recognize is a repository for documentation), is because the the MicrosoftTeams module's "Project Site" link points here, and simple changes on uservoice seem to be obfuscated by functionality requests that obviously get many more votes.

@get-itips I agree that no documentation needs to be changed. The only reason for even mentioning it here (which I recognize is a repository for documentation), is because the the MicrosoftTeams module's "Project Site" link points here, and simple changes on uservoice seem to be obfuscated by functionality requests that obviously get many more votes.

No issues at all, I just need to explain the reason I can not take any action on the documentation -for now- ;)
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @NoMoreFood
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


FileHelpers.Dynamic missing in 3.4.1?

As I have read here https://github.com/MarcosMeli/FileHelpers/issues/340
and in the readme:
Dynamic: ClassBuilder and CsvClassBuilder. ClassBuilder is difficult to maintain and a rewrite in .NET Core / Standard as is, would require to reference three NuGet packages. There must be better ways to write record structures at runtime.
So I need to downgrade to something below 3.3 and run full framework to use a dynamic ordering of columns? Or is it something that will be brought back any time soon?

I rewrote a chunk of the ClassBuilder to use Roslyn instead of System.CodeDom and now I've got dynamic class generation back in my .net core projects

I'm don't see the Dynamic classes in the netstandard2.0 version yet.  I'm looking that 3.4.2 alpha branch.  Is this checked-in somewhere else?

For ClassBuilder and .NET Standard please see here
https://github.com/MarcosMeli/FileHelpers#current-support-for-net-standard--net-core
Matthias


a way to change generall game world settings

i would love a way to settings for the gameworld ( PalWorldSettings )
currently have no idea how to find the file used to configure this
wouuld love to to fo example set item drop on death to off /or set a hasher penalty

+1

You can edit it at "YourPath/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini", and the example config is at "YourPath/DefaultPalWorldSettings.ini"

You can edit it at "YourPath/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini", and the example config is at "YourPath/DefaultPalWorldSettings.ini"
I modified the .ini file in "YourPath/DefaultPalWorldSettings.ini" and when you save and close it defaults to default.

I check the "YourPath/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini" but the file is empty?
Has anyone else migrated the save from another server to their dedicated server and lost the map progression?

You can edit it at "YourPath/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini", and the example config is at "YourPath/DefaultPalWorldSettings.ini"
I modified the .ini file in "YourPath/DefaultPalWorldSettings.ini" and when you save and close it defaults to default.

I check the "YourPath/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini" but the file is empty?
Has anyone else migrated the save from another server to their dedicated server and lost the map progression?

You can copy config at "YourPath/DefaultPalWorldSettings.ini", this is the example config.

I have added the following documentation: https://github.com/thijsvanloef/palworld-server-docker?tab=readme-ov-file#editing-server-settings
@fynaltgn Does this help you set the correct settings?

For me it does not the file is not recreated and the setting don't apply.
I added a server name and password. The password is now there but I don't see my server in the community list and can not join the server anymore because the ip login does not allow to enter a password.

@dotlogix please make sure you have pulled the latest image before starting:
docker compose pull

@thijsvanloef Same deal unfortunately I don't see my server in the server list and can not login if I set a server password using the IP

@dotlogix can you try this workaround:

Open Community Servers list.
Click on any Passworded Server
Enter the password for "your" server
Click Ok, then Click No
Use Direct Connect with your IP:Port to your server

This actually worked, however it is still weird why it is not showing up in the server list.
This is my compose file:
services:
   palworld:
      image: thijsvanloef/palworld-server-docker
      restart: unless-stopped
      container_name: palworld-server
      ports:
        - 8211:8211/udp
        - 27015:27015/udp
      environment:
         - PORT=8211
         - PUID=1000
         - PGID=1000
         - PLAYERS=16
         - MULTITHREADING=FALSE
         - COMMUNITY=TRUE
         - SERVER_PASSWORD="****"
         - SERVER_NAME="****"
         - ADMIN_PASSWORD="****"
      volumes:
         - /opt/docker/palworld/data:/palworld/

And this is my ini:
[/Script/Pal.PalGameWorldSettings]
OptionSettings=(Difficulty=None,DayTimeSpeedRate=1.000000,NightTimeSpeedRate=1.000000,ExpRate=1.000000,PalCaptureRate=1.000000,PalSpawnNumRate=1.000000,PalDamageRateAttack=1.000000,PalDamageRateDefense=1.000000,PlayerDamageRateAttack=1.000000,PlayerDamageRateDefense=1.000000,PlayerStomachDecreaceRate=1.000000,PlayerStaminaDecreaceRate=1.000000,PlayerAutoHPRegeneRate=1.000000,PlayerAutoHpRegeneRateInSleep=1.000000,PalStomachDecreaceRate=1.000000,PalStaminaDecreaceRate=1.000000,PalAutoHPRegeneRate=1.000000,PalAutoHpRegeneRateInSleep=1.000000,BuildObjectDamageRate=1.000000,BuildObjectDeteriorationDamageRate=1.000000,CollectionDropRate=1.000000,CollectionObjectHpRate=1.000000,CollectionObjectRespawnSpeedRate=1.000000,EnemyDropItemRate=1.000000,DeathPenalty=All,bEnablePlayerToPlayerDamage=False,bEnableFriendlyFire=False,bEnableInvaderEnemy=True,bActiveUNKO=False,bEnableAimAssistPad=True,bEnableAimAssistKeyboard=False,DropItemMaxNum=3000,DropItemMaxNum_UNKO=100,BaseCampMaxNum=128,BaseCampWorkerMaxNum=15,DropItemAliveMaxHours=1.000000,bAutoResetGuildNoOnlinePlayers=False,AutoResetGuildTimeNoOnlinePlayers=72.000000,GuildPlayerMaxNum=20,PalEggDefaultHatchingTime=10.000000,WorkSpeedRate=1.000000,bIsMultiplay=False,bIsPvP=False,bCanPickupOtherGuildDeathPenaltyDrop=False,bEnableNonLoginPenalty=True,bEnableFastTravel=True,bIsStartLocationSelectByMap=True,bExistPlayerAfterLogout=False,bEnableDefenseOtherGuildPlayer=False,CoopPlayerMaxNum=4,ServerPlayerMaxNum=32,PublicPort=8211,PublicIP="",RCONEnabled=False,RCONPort=25575,Region="",bUseAuth=True,BanListURL="https://api.palworldgame.com/api/banlist.txt")

Am I missing sth?

@dotlogix nope not missing anything, community tab is bugged: https://github.com/thijsvanloef/palworld-server-docker/issues/24

Thx for the help at least it is secure now :)
also awesome response times :) have a nice one.

@dotlogix Thanks :D

@ilco3 has your issue been resolved?

yes
Op wo 24 jan 2024 om 21:29 schreef Thijs van Loef @.***

:

@ilco3 https://github.com/ilco3 has your issue been resolved?
—
Reply to this email directly, view it on GitHub
https://github.com/thijsvanloef/palworld-server-docker/issues/53#issuecomment-1908865589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABF6LSHNI56SBIY2GKDS74LYQFVJTAVCNFSM6AAAAABCFMXSXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYHA3DKNJYHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Suggestion]Better dependencies management of the repo

In the last few days, i find out that many dependencies of angular-cli and then try to get my feet wet.
And I just find @hansl #3488 also updates some of the dependencies. But I think it's less perfect.

My opinions
As the repo is a host for several packages, what does the dependencies means for the repo itself? It will not be published.
Let's say the repo is the host.
In fact, the host is responsible for linting, building and testing the real-world packages. Without tests, the host theoretically ought to have devDependencies only.
However, in real development, developers need to run unit tests and write code with the power of Typescript and IDE. So, we have to install dependencies of those packages. (Note: e2e tests don't require that because they install dependencies independently)
Therefore, it can be concluded that the dependencies field in the package.json of the host itself, should be the combination of the  dependencies of those several packages. And then, the update workflow of the dependencies should be:

If they are the dependencies of those packages, developer should update them in those packages' package.json

then, make a join of the packages' dependencies and make a update in host's package.json
one should not directly add dependencies into dependencies field of host's package.json

If they are the devDependencies, of course they should be updated in devDependencies in package.json of repo itself.
If there is duplication between dependencies and devDependencies, I would perfer to remove it from devDependencies

The currents status is, lacking a util to sync the dependencies from the packages and a note to warn contributor not to manually update dependencies in repo's package.json

yarn workspaces as been implementing which eliminates the duplication of dependencies.


angularjs-country-select was not injected in your file

When using yeoman's grunt serve command, my command prompt tells me that "angularjs-country-select was not injected in your file. Please go take a look in 'app/bower_components/angularjs-country-select' for the file you need, then manually include it in your file."
Any idea what's going on?

Similar issue here?
Font-awesome issue:
https://github.com/stephenplusplus/grunt-wiredep/issues/25

This might possibly be the cause:
Popcorn.js injection problem/solution:
http://stackoverflow.com/questions/21840776/popcorn-was-not-injected-in-your-file

yes, adding the following property within the bower.json file of the project resolved the issue for me.  If I have time, I will add this to the open source code base.

Acutally, I don't see the bower.json file - not sure how to proceed.


Python: Small docstring fix

Motivation and Context
This is a single-line fix to a Python docstring to get it to conform to Sphinx standards and convention used elsewhere in the project.
(My team owns the reference docs generation process for this and other libraries. We forced a build the other day from our side for test purposes and noticed it stumbled over this line. Feel free to ping me if any questions.)
Description
See changes, it's a one-liner :grin:
Contribution Checklist
I ashamedly admit I have done none of the below; hopefully this is a gimme, apologies if it creates noise.

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Python 3.8 Test Coverage Report • FileStmtsMissCoverMissingTOTAL5561102382% report-only-changed-files is enabled. No files were changed during this commit :)
Python 3.8 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1207
11 :zzz:
0 :x:
0 :fire:
1m 21s :stopwatch:


Navigating via the bottom links resets the build tab to the top of the page

After the 8.2.7 patch the Equipment tab now also resets to the top of the page everytime you return to it.

I wonder if its because the placeholders when you switch are not the right size, so its temporarily making the screen "short", effectively scrolling you to the top.

There isnt a easy way to fix this. the tabpages are either physically shorter during transitions, or unloaded. The build tab are taller, but harder to fix the height, since it lazy loads the builds, which makes it very hard to retain scroll information.


ISPN-5980 Updated Scala artifact version to 2.11.7

Updated Scala artifact version to 2.11.7 in the bom

Pushed, thanks


Fix CI

This required pinning elastic-transport-python to <8.10 in the tests, as the urllib3 patching done in elastic-transport-python is incompatible with the patching done by VCRPy. (I haven't looked at the details.)

Approved in https://github.com/elastic/enterprise-search-python/pull/186 but I would like to merge this first.


NodeJS valve permission example

I can't find an example anywhere on how to set valve permission in NodeJS. Is it possible to set with:
server.set('permissions', Example permissions)
Please provide an example

@MedSolve you put all your permissions in the config file deepstream is run with. Take a look here https://deepstream.io/docs/server/configuration/#permissioning

There are a good number of reasons why I would not have my confuguration in an actual file. But this feature is not supported by deepstream?
-------- Oprindelig besked --------Fra: Alex Harley<EMAIL_ADDRESS>Dato: 19/07/2017  00.23  (GMT+12:00) Til: "deepstreamIO/deepstream.io"<EMAIL_ADDRESS>Cc: Rune Rasmussen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Emne: Re: [deepstreamIO/deepstream.io] NodeJS valve permission example (#748)
@MedSolve you put all your permissions in the config file deepstream is run with. Take a look here https://deepstream.io/docs/server/configuration/#permissioning
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/deepstreamIO/deepstream.io","title":"deepstreamIO/deepstream.io","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/deepstreamIO/deepstream.io"}},"updates":{"snippets":[{"icon":"PERSON","message":"@AlexBHarley in #748: @MedSolve you put all your permissions in the config file deepstream is run with. Take a look here https://deepstream.io/docs/server/configuration/#permissioning "}],"action":{"name":"View Issue","url":"https://github.com/deepstreamIO/deepstream.io/issues/748#issuecomment-316047361"}}}


Add an integration test for blkio statistics.

High Level Description
Add an integration test to make sure blkio statistics can be successfully collected from Mesos agent's endpoint /monitor/statistics.
Related Issues

CORE-1235 DC/OS integration tests for blkio stats.

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label Ready For Review

cc @vinodkone

@mesosphere-mergebot bump-ee

@jgehrcke Thanks for your comments! I have updated the commit by adding more comments in the code, can you please take a look again?

@jgehrcke Thanks for your comments! I have addressed all of them, can we merge this PR?

I've asked @gpaul to make another review. @qianzhangxa in general you should simply ask others directly for getting quicker reviews :-).

Thanks @jgehrcke! This is my first time to submit a PR for DC/OS integration test, I just did not know whom I should ask to review the PR, will do it directly next time :-)

@qianzhangxa there is a common misunderstanding in that area. "We" have tried to resolve that with the following part of the pull request template which you have surely read :-)

All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner.

No worries, but we all need to be a bit more proactive in that regard.

@orsenthil  Do I take that this will automatically get merged in the next train?

@orsenthil Do I take that this will automatically get merged in the next train?

This will only be put on the next train after having set the ship-it label.

@mesosphere-mergebot bump-ee

@vinodkone @qianzhangxa I am pushing this further ahead now, but please make sure your team can provide the same in the future :-).

@mesosphere-mergebot ship_it_label_status_check

Thanks @jgehrcke ! Am I supposed to be doing "@mesosphere-mergebot ship_it_label_status_check
" after it got approvals?

@vinodkone  - Not required. A metronome job automatically applies in 5 minute intervals.


Feature Request: Enforce Case-Insensitive Email Matching for User Authentication

I have come across an inconsistency in the authentication process when using email addresses. Currently, the system requires an exact case match for email addresses during authentication, leading to failed login attempts if the case does not match exactly. This behavior contrasts with the case-insensitive handling of usernames as seen in this past request.
Email is documented as an alternative to username for authentication purposes. However, it fails to authenticate when the case of the email string does not match exactly, as demonstrated below:

Authenticates

await<EMAIL_ADDRESS>'12345678');

Returns invalid

await<EMAIL_ADDRESS>'12345678');

For consistency and improved user experience, adopting a case-insensitive behavior for email addresses, akin to the handling of usernames, would be beneficial. This change could potentially reduce user login issues and support requests, thereby improving overall user satisfaction.
Here are a few examples illustrating the benefits of this feature:

Reduced user friction during the login process, particularly for new users unfamiliar with the case sensitivity requirement.
Consistent behavior between email and username authentication, aligning with common practices in other platforms and meeting user expectations.

I understand there might be technical or security considerations impacting this feature's feasibility. However, I am keen to learn if there are specific reasons for the current case-sensitive email handling, and I am open to discussing alternative solutions that achieve the same user-friendly outcome.
I have checked the issue tracker to the best of my ability and hope this isn't a duplicate request. Thank you in advance for considering this feature request and I am looking forward to any feedback or further discussion on this topic.

P.S. This body was mostly produced by chatGPT after clarifying my thoughts on this issue to improve the readability. Cheers

This deliberate and was discussed in https://github.com/pocketbase/pocketbase/discussions/756.


fix(to-dts): use double quatation marks for literals

Strip ' from literals to ensure it becomes type: 'axis' (instead of type: "'axis'").

A unit test validating this would be nice.

A unit test validating this would be nice.

I have added a unit test to verify the functionality.


Name conflict with QuantEcon and LQ

In fundamental_types.rst:
WARNING: using QuantEcon.LQ in module Main conflicts with an existing identifier.

Done, I put the using QuantEcon in a hide-output block. That's the best fix for now until QuantEcon.jl comes up with a new name.


Setting to disable collapsing identical lines in Debug Console

I think it would be useful to be able to toggle off the collapsing of identical lines in the Debug Console .
Here is my problem

This is a fair feature request to add a setting, however for now I would wait for more user feedback.
Is there something common for these lines that should not be collapsed? Maybe we should collapse only line which are longer than 1 character...
I am open for ideas.

The output was a drawing. So collapsing identical lines was not a good idea to see the result of it !

I'm generating ASCII art. The default behavior is quite annoying there. A setting would definitely be appreciated.

Hi, I saw that you just recently added this feature, but I agree a toggle would be nice.
I am also drawing some shapes in my debug output and this collapsing completely messes up the output.
I think a simple toggle would be enough - collapsing duplicate lines like introduced here #104162 or not at all - no extra rules required...
Thanks!

Hi, I saw that you just recently added this feature, but I agree a toggle would be nice.
I am also drawing some shapes in my debug output and this collapsing completely messes up the output.
I think a simple toggle would be enough - collapsing duplicate lines like introduced here #104162 or not at all - no extra rules required...
Thanks!

A big issue for me is that when you right-click Copy All in the Debug Console, it copies the collapsed line only once - the collapsed lines (i.e. the counts) are "lost" when you paste and that's very undesirable, and I would go so far as to say just wrong, since it makes no mention of the number of times a line was writtent to the console - so that information after the paste is truly lost/missing.
A toggle to turn off collapsing repeated lines would of course solve this issue and is probably easier/more desirable than unrolling the copied lines into the paste buffer or adding the count into the paste buffer.
I rely on all lines being present after paste (I can run the application in a terminal and catch the output but it was much nicer before when I could do it all in the VS Code UI).

A big issue for me is that when you right-click Copy All in the Debug Console, it copies the collapsed line only once - the collapsed lines (i.e. the counts) are "lost" when you paste and that's very undesirable, and I would go so far as to say just wrong, since it makes no mention of the number of times a line was writtent to the console - so that information after the paste is truly lost/missing.
A toggle to turn off collapsing repeated lines would of course solve this issue and is probably easier/more desirable than unrolling the copied lines into the paste buffer or adding the count into the paste buffer.
I rely on all lines being present after paste (I can run the application in a terminal and catch the output but it was much nicer before when I could do it all in the VS Code UI).

I pushed a fix for the Copy All.
As for the setting I am open to add it in the future. However waiting for more user feedback right now.

I pushed a fix for the Copy All.
As for the setting I am open to add it in the future. However waiting for more user feedback right now.

So are these comments the user feedback you are waiting for or do I need to give this feedback somewhere else? :)

So are these comments the user feedback you are waiting for or do I need to give this feedback somewhere else? :)

In most cases, the collapsing is helpful. However, my unit test outputs get collapsed strangely with the new feature. Without it, I was quickly able to determine what part of my code base caused a failing unit test (instead of a "." I see an "F"). Now it's just some unintelligible output and I have to go through the details to find the culprit.

In most cases, the collapsing is helpful. However, my unit test outputs get collapsed strangely with the new feature. Without it, I was quickly able to determine what part of my code base caused a failing unit test (instead of a "." I see an "F"). Now it's just some unintelligible output and I have to go through the details to find the culprit.

I don't like it. Please add an option to disable it.
To me it makes the output visually harder to scan. ("I expected three lines here, why is it only... oh right.")
Plus in the current implementation the collapsed lines are shifted to the right (by three full character widths) which messes up all sorts of outputs that rely on correct placement of characters. We use constant width characters in terminals for a reason. But even if there were a margin I still would like to have the option to disable it.

I have added the following setting debug.console.collapseIdenticalLines with the default value true.
Try it out with VS Code insiders starting on Friday and let me know how it works for you.
This will only be available in VS Code stable in 5 weeks.

@isidorn what happens for those users that don't have the new debug.console.collapseIdenticalLines setting?
If (for backward compatibility) a missing setting means "do collapse lines", that would break our rule that missing settings should have the same meaning as the value false.
In this case I suggest to invert the setting to debug.console.doNotCollapseIdenticalLines or debug.console.ExpandIdenticalLines or debug.console.keepIdenticalLines or debug.console.showIdenticalLines.

@weinand thanks for the suggestion.
I went with the current approach because our rule of "missing settings should have the same meaning as false" is only applied in the debug adapter protocol. This is actually not true for VS Code configurations, where we have many settings which have the value true even if not present. I guess the motivation for this is implementaion detail since the configurationService nicely handles all this and give the correct default value always.
With that in mind I have absolutely no problem inverting the setting name.
From your proposals, I like the debug.console.expandIdenticalLines the most.
Let me know what you prefer. Thanks

No, I don't want to change the name unnecessarily.
I just wanted to make sure that we do not break users.

Okey. We will not break users, so we are good. Let's stick with the debug.console.collapseIdenticalLines setting name then.

Try it out with VS Code insiders starting on Friday and let me know how it works for you.

Looks to be working good for me, just came here to look for the same suggestion as I needed it disabled.


Add S3 region for object store channels to the application editor

Signed-off-by: sahare<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/11492

Hi @swopebe , could you please take a look at the placeholder and tooltip texts for the AWS Region which has been added to the UI. Thanks!


Html::activeListInput() failed loading data to model attribute have array type

What steps will reproduce the problem?
Model:
class Form extends \yii\base\Model
{
    public array $values = [];

    public function rules()
    {
       return [
        [['values'], 'safe']
      ];
    }
}

View:
use \yii\widgets\ActiveForm;
$form = ActiveForm::begin();
echo $form->field($model, 'values[]')->checkboxList([1 => 'foo', 2 => 'bar']);
echo \yii\widgets\Html::submitButton();
ActiveForm::end();

Controller:
class TestController extends \yii\web\Controller
{
   public function actionForm()
   {
       $model = new Form();
        if ($this->request->isPost && $model->load($this->request->post()) && $model->save()) {
            return $this->redirect(['index']);
        }

        return $this->render('form', ['model' => $model]);
   }
}

What is the expected result?
No errors on load form data into model when i don't check values
What do you get instead?
Error: can't set string to array property $values because https://github.com/yiisoft/yii2/blob/f72310c398759841a0f8b52e1aba7990086c0d9c/framework/helpers/BaseHtml.php#L1845
Additional info

Q
A

Yii version
2.0.45

PHP version
-

Operating system
-

Framework works exactly as documentation says and it allows developer to override default behavior if needed in cases like this.
Documentation for BaseHtml::activeCheckboxList() and BaseHtml::activeRadioList() clearly says:

@param array $options options (name => config) for the checkbox list / radio button container tag.
The following options are specially handled:
...
- unselect: string, the value that should be submitted when none of the checkboxes / radio buttons is selected.
You may set this option to be null to prevent default value submission.
If this option is not set, an empty string will be submitted.

Per documentation:
If Form::$values isn't intended to allow unselect, 'unselect' should be set to null and that works without issue as designed:
echo $form->field($model, 'values[]')->checkboxList([1 => 'foo', 2 => 'bar'], ['unselect' => null]);

Also, if Form::$values expect any other value for unselect, custom value can be set and that works without issue as designed:
echo $form->field($model, 'values[]')->checkboxList([1 => 'foo', 2 => 'bar'], ['unselect' => 0]);

IMHO, this isn't bug and should be closed.
Also, as both @rob006  and I stated in PR #19447 discussion, if Model::load() throws exception, issue is in concrete Model implementation, not in helper for printing forms. If invalid data is submitted (which doesn't need to be submitted exclusively via form printed using this helper), that should trigger validation error, not exception.


[VL] Daily Update Velox Version(2024_08_15)

https://github.com/facebookincubator/velox/pull/10716 This PR change the config class


proposal: net/http: Turning on/off canonical headers

Proposal Details
Currently the http headers are treated in canonical style.
I would like to be able to turn on and off this functionality (in runtime).
The reason is to be able to pass the header name as-is.
--Or--
Provide a way to manipulate the headers before sending them.
Best Regards,
Kobi

I encourage you to read the documentation carefully before filing issues, see https://pkg.go.dev/net/http#Header.Set

I encourage you to read the documentation carefully before filing issues, see https://pkg.go.dev/net/http#Header.Set

Thank you for the info.
I'm aware that..
Yet, if I set user-agent header (for specific request) I will still have 2 headers "User-Agent" and "user-agent".
So, still we need an option to "disable" the canonical or something similar.
Please advise,

set the canonical User-Agent it to the empty slice.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Register user error

Hey there!
Then I try to register new user http://<IP_ADDRESS>:8000/auth/register
I get an error
  File "/home/y700/Env/text-detector/lib/python3.7/site-packages/fastapi_users/db/sqlalchemy.py", line 123, in get_by_email
    query = self.users.select().where(
AttributeError: 'str' object has no attribute 'select'

The changes that I made
Extend user model
model.py
Custom user
class UserTable(Base, SQLAlchemyBaseUserTable):
    name = Column(String(50))

users = UserTable.__tablename__

And add fields name to pydantic file
schemas.py
from fastapi_users import models

class User(models.BaseUser):
    name: str

class UserCreate(models.BaseUserCreate):
    name: str

class UserUpdate(User, models.BaseUserUpdate):
    name: str

class UserDB(User, models.BaseUserDB):
    name: str

Is it right idea to add field name to each pydantic clases?
The main question is, what is the cause of the error that occurs?
p.s.
The same result after run
http://<IP_ADDRESS>:8000/auth/jwt/login

Hey!
The problem is here:
users = UserTable.__tablename__  # This a string representing the table name

You should write:
users = UserTable.__table__  # This is the actual table instance on which we can make requests

As for adding the field to each Pydantic class, yes, you can do it like this. Actually, you don't have to repeat them when you inherit from User, but it doesn't do any harm.

@frankie567 Great! it works? thank you


How could get different branch deployment status?

Thanks for you project let us get more fun with brage status.
But there found a problem, if there so many branch in one project ,  how to set different branch deployment status, hope there can give some help, thanks.

In Vercel each branch is deployed on a different URL (Ex: https://site-git-master-username.vercel.app). In this case the APP_NAME will be site-git-master-username.
You can view the deployment domains in the deployment page at Vercel.

Got it and working now, thanks.


Hubs have no way of knowing whether a message requires authorization, attestation, or data encryption

Problem
The spec does not indicate how an Identity Hub Instance decides whether a message requires authorization, attestation, or for data to be encrypted.
Context
Let's assume the following request is sent to an Identity Hub:
{
    "requestId": "862b44c7-cd7b-4974-8782-b32f470064ef",
    "target": "did:ex:alice",
    "messages": [{
        "descriptor": {
            "objectId": "0f913c1e-cde5-4bbf-956a-80aa481687ad"
            "method": "CollectionsWrite",
            "schema": "https://schema.org/MusicPlaylist",
            "dataFormat": "application/json"
        },
        "data": {...}
    }]
}

The message in the request above does not contain attestation or authorization, nor is data encrypted, yet it is a valid message. Further, even if authorization was provided, Alice's hub instance currently has no clue whether it should expect authorization or not. She should be able to configure what requires any combination of attestation, authorization, and data encryption based on an individual message's descriptor.
if the combinatorial suggestion seems like overkill, i'd like to know why and propose that there should be a way to configure what requires authorization at the very least.
Proposal
This proposal only focuses on supporting configuration of authorization. If there's consensus around supporting configuration of any combination of authorization, attestation, and encryption, we can extend the proposal.
We can borrow the concept of DMZ from routers and loosely apply it here.
Pseudocode
  async processMessage(message) {
    // message validation and other things

    const { descriptor } = message;

    // build DMZ policy out of message's descriptor
    const policy = {};
    for (let field of ['dataFormat', 'method', 'schema']) {
      if (field in descriptor) {
        policy[field] = descriptor[field];
      }
    }

    // check to see if policy is within DMZ
    const isWithinDMZ = !! await this.DMZStore.get(policy);

    // authorization is required if message op is not within DMZ
  }

Logic

Build policy out of fields within message.descriptor
Check to see if policy exists in hub's DMZ store
if it does, no auth is required.
Otherwise, expect auth

DMZ Policy Data Model

Field
Data Type
Required (Y/N)

dataFormat
String
N

method
String
N

schema
String
N

Follow up questions

Should DMZ be it's own interface or live underneath the Permissions interface?

If as it's own interface, what would that interface look like?

would there need to be some hardcoded logic to prevent DMZ checks for DMZ-related messages?

if underneath Permissions how would that work? Additional Methods?

Are there any DMZ policies that should be included by default?

This kind of thing should be in Permissions, not DMZ in my opinion. Encryption material exchange would be given out at permission issuance time anyway, and the capability would flag that it needs to be encrypted, which it can check on authz eval.

Agree that this could be capability based. The policy you've described seems to match with a capability if you have a way to do 'implicit capabilities' - meaning, if someone has a certain authenticated message from a known DID, they auto-get a capability.
The tuple of <schema, dataFormat, method> makes sense for assigning capabilities.

Closing this out. There was a bunch teased out here that we'll be considering when spec'ing out permissions


Inconsistencies between the various windows' styles and the back button position

Any reason why the webcam window has the default window style and a back button in the bottom left corner, while the recorder and board windows have a custom style and their back button in the top left corner?
I think it would be better if the back button position was consistent between windows.
I'm also not sure if there is a technical reason for the custom window style or not, but I miss some features of the native windows. (For example the ability to maximize the window, either with the maximize button, or by dragging a window to the top of the screen. More generally, I miss Aero Snap.)
What's your opinion about this?
Anyway this tool is great, thank you!

There's a technical reason for the screen recorder and board recorder to have custom windows.
It's possible to use the default window style for the board recorder, but that requires some kind of big changes (that I'm planning to do by the end of the year).

The back button will be removed following version 2.13.


Display class, Btn small

The new display class is awesome but doesn't wrap or scale well in small screens.
The btn-sm class need a padding top of .30rem to look properly padded. it apeares that chrome give the text a default padding or some space under the text.
-chorme for windows

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via JS Bin or CodePen and report back with your link, Bootstrap version, and specific browser and OS details.

CodePen
https://codepen.io/tobioye88/pen/VbBjxJ

@tobioye88

The new display class is awesome but doesn't wrap or scale well in small screens.
for a long word you coud use word-wrap: break-word;

Closing for #22856 for the display heading change.


feature: Adding support for LngLatBounds in fitBounds

Mapbox API supports multiple argument types for the fitBounds method.

[[1, 2], [3, 4]]: https://docs.mapbox.com/mapbox-gl-js/example/fitbounds/
new LngLatBounds([1, 2], [3, 4]): https://docs.mapbox.com/mapbox-gl-js/example/zoomto-linestring/

This PR adds the functionality for new LngLatBounds([1, 2], [3, 4]) to be passed into the fitBounds method.
It tackles the two areas of where fitBounds is used within react-mapbox-gl:

the.calcCenter that is called within componentDidMount().
fitBounds prop updates within UNSAFE_componentWillReceiveProps().

Related issue: https://github.com/alex3165/react-mapbox-gl/issues/851


Develop content of ModelCard

Signed-off-by: Jael Gu<EMAIL_ADDRESS>Export model_details, training_configs, training_summary (start_epoch, num_train_epoch) to ModelCard after each training is done.
Closes /598

Codecov Report

Merging #599 (546e307) into training (894b9e3) will increase coverage by 0.49%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##           training     #599      +/-   ##
============================================
+ Coverage     59.79%   60.28%   +0.49%
============================================
  Files           151      150       -1
  Lines          5997     5988       -9
  Branches        888      888
============================================
+ Hits           3586     3610      +24
+ Misses         2171     2138      -33
  Partials        240      240

Impacted Files
Coverage Δ

towhee/trainer/trainer.py
69.34% <92.85%> (+3.05%)
:arrow_up:

towhee/trainer/modelcard.py
71.42% <100.00%> (+20.36%)
:arrow_up:

towhee/engine/thread_pool_task_executor.py
80.85% <0.00%> (+2.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894b9e3...546e307. Read the comment docs.

/lgtm

/approve

/lgtm

/approve


Github Repositories: Allow me to stage all changes in a folder

In the following scenario I'd like to have a simple way to stage all changes in folder A:

have a workspace with folders A and B
in folder A make changes in many files
in folder B make one change
in the SCM view, choose the directory presentation
-> allow me to select A and stage all changes below

Just realized that I was in GitHub repos and not local. Locally this works as expected.

This is mostly low hanging fruit, since we recently already added support for multiple selection, RemoteHub now only needs to contribute the stage/unstage/discard actions to the scm/resourceFolder/context menu in package.json: https://code.visualstudio.com/api/extension-guides/scm-provider#menus.
Though in desktop, the SCM tree presentation has these very nice 'Contains emphasized items' badges (check out the dots on the resource folder list items in the RHS of the screenshot below). Not sure why they are not appearing for RemoteHub.

Separately, while testing this I noticed that RemoteHub contributes extra inline commands inconsistently from desktop git:

Just to document the differences:

In desktop the Changes and Staged Changes resource groups have an option to Stash Changes or Stash All Changes. RemoteHub doesn't support stashing.
RemoteHub contributes an extra Discard Changes command to the staged resource state and group menus. I'm a bit worried that the icon is too similar to stash changes and is in the same position that the stash button is in desktop. Will users accidentally discard changes when they expect to stash?
There's no + option in RemoteHub for the Merge Conflicts resource group, and there's no discard option in desktop for the Merge Changes resource group
RemoteHub's + means 'Keep Changes' in the Merge Conflicts resource group. But in desktop, + means 'Stage Changes'. 'Keep Changes' also doesn't do anything in the new merge conflict flow, tracking that in https://github.com/microsoft/vscode-remote-repositories-github/issues/125

In desktop the Changes and Staged Changes resource groups have an option to Stash Changes or Stash All Changes. RemoteHub doesn't support stashing.

Did you mean "In desktop the Changes and Staged Changes resource groups have an option to Staging Changes or Stage All Changes. RemoteHub doesn't support staging."

@lszomoru no, RemoteHub doesn't support stashing. RemoteHub does support a simplified staging experience. We don't have support for staging files in the merge conflict resource group, which is tracked in https://github.com/microsoft/vscode-remote-repositories-github/issues/125


The dialog "Configuring the project" takes forever

Basically the title. I opened a (qt) project with CIDE and the whole IDE is stuck and waiting the Configuring the project dialog to finish.
Any clue what is going on? Is it due to parsing? Maybe my system is at fault here?

I think that the time that this dialog takes should usually mostly depend on the time that CMake takes to configure the project. Possibly this project takes a while to configure with CMake?
I did not observe this yet for any of my projects, but I think this could easily happen in the case above. Ideally, CIDE should do this step in the background instead of in the foreground.

I think that the time that this dialog takes should usually mostly depend on the time that CMake takes to configure the project. Possibly this project takes a while to configure with CMake?

Yes maybe you are right. What if cmake messages were visible? So we can see the progress of the process and if it failed?

That also seems like it would be a step in the right direction. I'll put it on my to-do list such that I'll consider it the next time I work on CIDE.

IMO this issue can stay as open until further progress on the matter. If you feel it can be reopened feel free to close it.

It's nice and fast. Thank you for your work. Do you think this can now be closed?

I considered keeping this issue open, since it would still be preferable to do the whole configuration in the background while the editor widgets can be used. But that does not seem important for now and may be added as a separate issue, so let's close it.


Easier Contributions

Hey there 👋
We are on a mission to simplify open-source work and encouraging contributors to get started, through automated dev environments.
This PR adds a minimal config to this repo, which allows your community to quickly spin up a ready-to-code dev environment. Please note, that this not only automates the setup of a dev environment but also pre-builds the project before users open it - think CI for dev environments.
I have configured it so, that during prebuild yarn install && yarn installer is executed using the default values (i.e. using https://demo.vuestorefront.io as api backend). It would be certainly feasible to get all the backend services setup as well.

You can try it out yourself:
https://gitpod.io/#https://github.com/svenefftinge/vue-storefront/tree/develop
If you think this could be useful for your community, I'll be happy to also add your project to https://contribute.dev.
Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To
It doesn't affect a certain deployment, as it is an optional development setup.
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

This is awesome! I like the idea! Just one comment here: instead of using an installer, you can call just yarn install and yarn dev to run the development mode. When it comes to api - it depends: I think it the next.storefrontclooud.io. supposed to be there instead, because demo has the newest stable version which means there could be differences between develop and the current stable one. Basically you can use simply use echo / cat to create a local config that overrides just this field - something like: echo "{ api: { url: '....' }}" >> local.json

Cool, thanks for the feedback. Getting rid of the hack I put around the installer is great.
I've updated the PR.
Btw. I'd suggest you set the 'develop' as the default branch, so GitHub (and Gitpod) will use that for new PRs automatically.

FWIW I don't think the failing Travis build is due to my changes.

@andrzejewsky should I do anything about the CI build (I cannot manually restart it)?

@svenefftinge ok great! default branch should be master in our repository - but is there any possibility to change that to develop in the gitpod.yml? Actually it can be master as well, but usually develop branch is dedicated to new features/improvements. Anyway, from my side, it's ready to merge, just let me know 👍

Ok, I think it is good to merge then. Please reach out in case you have issues with it.


yii.activeForm.js. Add 'updateInput' to 'methods'.

Function of updateInput very need!
Example: Now I was make auto-save form after successfully validation via Ajax. And we can change one field at a time and get errors by this field. I would like to have a possibility set errors manually after validation. This can handle updateInput in yii.activeForm.js, but  this method is private.
Please, add to public methods. =)

Periodically I scan to see if any progress on this. In case it isn't realized this is the same issue as https://github.com/yiisoft/yii2/issues/5420
https://github.com/yiisoft/yii2/pull/7260
https://github.com/yiisoft/yii2/issues/5991
https://github.com/yiisoft/yii2/issues/3017
Currently I used a hacked yii.activeForm.js with
    var methods = {
        updateInputs: function (messages) {
            updateInputs($(this), messages, true);
        },
        init: function (attributes, options) { ...

In order to access updateInputs. Am not good at explaining my use cases and tend to over-complicate but figured others would find the same issue and raise it - which is happening. No major - other than using  a hacked framework file. Am sure it is in the pipeline to be resolved but thought I would aggregate the issues together here.


#2298 - Removed DynamicDeck dependency on deprecated package com.day.…

…cq.dam.api.collection which causes problems w/ AEM CS deployments.

Pull Request Test Coverage Report for Build 5796

0 of 32 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 54.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundle/src/main/java/com/adobe/acs/commons/indesign/dynamicdeckdynamo/utils/DynamicDeckUtils.java
0
32
0.0%

Totals

Change from base Build 5755:
-0.03%

Covered Lines:
15550

Relevant Lines:
28281

💛  - Coveralls


fix: Remove System suffix from manifest file

Current manifest outputs names like SpawnSystem rather than Spawn
    {
      "name": "SpawnSystem",
      "inputs": [],
      "outputs": [],
      "class_hash": "0x7b7dcd290f420ecb9064f3c123c7a9d22f37e5529d06a5e15f73879110a5ce5",
      "dependencies": [
        "Moves",
        "Position"
      ]
    },

Good idea. We can remove the system suffix right now. The component one is required until we get the new contract syntax, otherwise the contract name conflicts with the struct name

hello ! can i try this one?


Importer not working with Amasty Sorting extension installed on Magento 2.2.0

We have a Magento ver. 2.2.0 and installed the channable extension and connect this Magento on https://app.channable.com/
On this Magento, we have installed Amasty Sorting extension and when we want to download/add products on https://app.channable.com/ we have an error

We could not import the Magento product information

Solution: We recommend an unrecognizable answer from the Magento plugin,
check whether the plugin is installed correctly.
Follow this support article to check your Magento plugin...

After checking the backend code, we have found that issue is with this extension (channable extension is trying to find DB unknown table name, probably DB table alias name from Amasty extension ). If this extension is disabled, the importer is working.

Hi @nenadcvyounify. Thank you for the detailed error report. Just tested the compatibility with Improved Sorting 2.5.2 by Amasty, but was not able to reproduce this. The Amasty module is using a plugin on the product collection for extra sorting. Are you using the latest version of the Amasty module?

No. On this store version is 2.2.3 for Amasty Sorting. We will try with the latest and will back with feedback to you. Than you

Hi @nenadcvyounify, any update on this?

Hello Marvin,
I am sorry for not informing you earlier about this issue. After importing
latest version, everything is ok now. It is working fine now.
Thank you for your support.
Best regards
On Tue, May 14, 2019 at 11:38 AM Marvin Besselsen<EMAIL_ADDRESS>wrote:

Hi @nenadcvyounify https://github.com/nenadcvyounify, any update on
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/magmodules/magento2-channable/issues/63?email_source=notifications&email_token=AKGR3A2CZWCOQCIUUTICL53PVKB73A5CNFSM4HJJYHQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVK5NDA#issuecomment-492164748,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKGR3A3V4EFLECHHFDKVDJTPVKB73ANCNFSM4HJJYHQA
.

--
https://www.younify.nl/
Nenad Cvetković  |  Frontend Developer
Vožda Karađorđa 5/14 | 18000 Niš | Serbia t: +31 (0) 26 700 9750
Nieuwe Stationsstraat 20 | 6811 KS Arnhem | Netherlands m: +31 (0) 6 139 38
947


Factorize empty range check in all parsers

All parsers do more or less the same check on empty ranges and generate the same error. It could be factorized.

Done in #4


Add fail-on functions, tests, and constants for reporting module

Related issue
Supports internal issue 623 in Team-backlog
Description of changes
This is a sub-PR of https://github.com/IBM/detect-secrets/pull/46 (I'm breaking down the reporting PR for easier readability for reviewers).

Added get_secrets_list_from_file to audit.py. This makes it simpler to extract a list of secrets from a baseline file. To be used by fail on functions to get secrets list, as well as for getting secrets information for the report console output.
Added conditions.py to a reporting directory under detect-secrets/core. The functions within this file correspond to the report fail-on-xx CLI arguments.
Added a constants.py file which contains exit report exit code and secret type enums ~as well as custom types~.
Added a conditions_test.py file which contains various tests for the fail-on functionality.
Added a baseline.py to the testing directory since I noticed this baseline dictionary object is reused throughout our testing files.

TypedDict wasn't added until Python 3.8 🤦 , so we may not be able to annotate with custom types 😞 .
https://github.com/python/typeshed/issues/3500#issuecomment-558205265

The build is now failing due to insufficient test coverage:
py38 run-test: commands[3] | coverage report --show-missing '--include=tests/*' --fail-under 100

Name                                   Stmts   Miss Branch BrPart  Cover   Missing

----------------------------------------------------------------------------------

tests/core/report/conditions_test.py     113      3     14      1    97%   20-21, 28

----------------------------------------------------------------------------------

TOTAL                                   2144      3    280      1    99%

35 files skipped due to complete coverage.

Coverage failure: total of 99 is less than fail-under=100

ERROR: InvocationError for command /home/travis/build/IBM/detect-secrets/.tox/py38/bin/coverage report --show-missing '--include=tests/*' --fail-under 100 (exited with code 2)

___________________________________ summary ____________________________________

ERROR:   py38: commands failed

Makefile:16: recipe for target 'test' failed

make: *** [test] Error 1

The command "make test" exited with 2.
cache.2

store build cache

Done. Your build exited with 1.

So I can take one of two approaches:

1: Continue creating separate PRs for the reporting feature

Pros: smaller, more digestible PRs for reviewers
Cons build will fail until all the PRs have been merged (future PRs will add more test coverage)

2: Have a mega-PR with all changes (example: https://github.com/IBM/detect-secrets/pull/46)

Pros: test coverage check will pass
Cons: reviewers may miss things, more difficult to review

^ My preference is option 1, we just accept that the test coverage check will fail until all PRs are finished being merged.

Have u already rebased this with the staging branch? I know you merged a few other prs before this last one

Have u already rebased this with the staging branch? I know you merged a few other prs before this last one

All done!


Collections should provide a default format for the scalars they contain

It should be possible to e.g. parse [ 0x01, 0x02, 0x03 ] as a sequence of hexadecimal integers, and to:

Automatically assign added items to have the same format, such that after seq.items.push(4), the sequence would be stringified as [ 0x01, 0x02, 0x03, 0x04 ].
Re-format it as a sequence of octal integers [ 0o1, 0o2, 0o3 ].

Dropping this, as it would complicate things too much compared to the benefit. To implement this externally, do something like this:
const doc = YAML.parseDocument('[ 0x01, 0x02, 0x03 ]')
doc.contents.items.push(YAML.createNode(4))
for (const item of doc.contents.items) if (!item.format) item.format = 'HEX'
String(doc)
// '[ 0x1, 0x2, 0x3, 0x4 ]\n'


We don't show off the hotness of Flutter, in motion, on the homepage

(From a UX study)
We realized that visuals are powerful, and motion/animated visuals are even more powerful. And that our current homepage doesn't have an impactful way to show how powerful Flutter is in action.
An embedded movie, above the fold, can go a long way in showing off what Flutter can do. We believe a movie is required because A) you can't just click a link and experience flutter in your browser and B) you're probably not going to install all of Flutter to run the gallery to evaluate Flutter in your first five minutes C) you might be on an iPhone and can't just install the Gallery and D) you might be pretty hesitant to install an app while you're trying to learn what Flutter is for the first five minutes.

+1 for a short and sweet movie to show the best of Flutter (IMO, Hot Reload, Single code base, and hi-fi Material Design implementation, and high performance). The homepage needs to convey the value proposition really clearly and fast.

+1
stuff that moves like on the homepage of https://www.sublimetext.com/ feel very succinct and captivating