runtime errors in new control_flow_collections tests

control_flow_collections/await_for_null_test
control_flow_collections/for_await_test
has runtime errors.
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --no-background-compilation --enable-experiment=control-flow-collections,spread-collections,constant-update-2018 --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/language_2/control_flow_collections/await_for_null_test.dart

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
asyncExpectThrows<NoSuchMethodError>(): Did not throw.
#0      asyncExpectThrows.<anonymous closure> (package:async_helper/async_helper.dart:127:5)
#1      _RootZone.runUnary (dart:async/zone.dart:1379:54)
#2      _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:639:45)
#4      Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#5      Future._complete (dart:async/future_impl.dart:473:7)
#6      _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#7      _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:28:18)
#8      _completeOnAsyncReturn (dart:async-patch/async_patch.dart:294:13)
#9      main.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/tests/language_2/control_flow_collections/await_for_null_test.dart)
<asynchronous suspension>
#10     asyncExpectThrows (package:async_helper/async_helper.dart:120:17)
#11     main.<anonymous closure> (file:///b/s/w/ir/tests/language_2/control_flow_collections/await_for_null_test.dart:14:5)
<asynchronous suspension>
#12     asyncTest (package:async_helper/async_helper.dart:90:11)
#13     main (file:///b/s/w/ir/tests/language_2/control_flow_collections/await_for_null_test.dart:11:3)
#14     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:300:19)
#15     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

DART_CONFIGURATION=DebugX64 out/DebugX64/dart --no-background-compilation --enable-experiment=control-flow-collections,constant-update-2018 --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/language_2/control_flow_collections/for_await_test.dart

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
NoSuchMethodError: Class 'int' has no instance getter 'keys'.
Receiver: 3
Tried calling: keys
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:50:5)
#1      Expect.mapEquals (package:expect/expect.dart:334:32)
#2      testMap (file:///b/s/w/ir/tests/language_2/control_flow_collections/for_await_test.dart:60:10)
<asynchronous suspension>
#3      main.<anonymous closure> (file:///b/s/w/ir/tests/language_2/control_flow_collections/for_await_test.dart:17:11)
<asynchronous suspension>
#4      asyncTest (package:async_helper/async_helper.dart:90:11)
#5      main (file:///b/s/w/ir/tests/language_2/control_flow_collections/for_await_test.dart:15:3)
#6      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:300:19)
#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

Crashes for
Future<void> testMap() async {
  // Await in for-in body value.
  Expect.mapEquals(map,
      {for (var i in [1, 2, 3]) i: await Future.value(i)});
}

This is the incoming kernel file. The asyn temporary aliasing seems suspect:
          :async_temporary_0 = [@vm.inferred-type.metadata=dart.collection::_InternalLinkedHashMap?] for::map;
          final core::Map<dynamic, dynamic> #t2 = <dynamic, dynamic>{};
          for (core::int i in <core::int>[1, 2, 3]) {
            :async_temporary_0 = i;
            [yield] let dynamic #t3 = asy2::_awaitHelper([@vm.inferred-type.metadata=dart.async::_Future] asy2::Future::value<core::int>(i), :async_op_then, :async_op_error, :async_op) in null;
            [@vm.direct-call.metadata=dart.collection::__InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin::[]=] [@vm.inferred-type.metadata=!? (skip check)] [@vm.call-site-attributes.metadata=receiverType:dart.core::Map<dynamic, dynamic>] #t2.{core::Map::[]=}(:async_temporary_0, :result);
          }
          exp::Expect::mapEquals(:async_temporary_0, block {} =>#t2);

/cc @kmillikin

That looks like a bug in the VM-specific async transformation.  I'll fix it.

CL 98664 fixes for_await_test at the cost of sometimes using more temporary variables than necessary in the VM's async transformation.  Eventually this should be fixed but that needs a different way to know about liveness.
await_for_null_test doesn't seem to have anything to do with control-flow collections.  A similar test with an await for statement fails in the same way, so it's not the collection that is the problem.  This seems like a VM issue.

This test fails in the same way as await_for_null_test:
import 'package:async_helper/async_helper.dart';

void main() {
  asyncTest(() async {
    // Null stream.
    Stream<int> nullStream = null;
    asyncExpectThrows<NoSuchMethodError>(() async {
        await for (var i in nullStream) 1;
    });
  });
}

Does this bug need to be split, @a-siva ?

I have created https://github.com/dart-lang/sdk/issues/36483 to track the second issue with await_for_null_test. Since this is an already existing issue and not related to control-flow collections I am not tagging that issue with the 2.3 milestone.
@kmillikin once your CL lands you can close this issue.


bridge: Patron-only Patreon.com Bridge

This PR creates a new bridge that is an extension of the PatreonBridge that allows a patron to load their session cookie into config.ini.php and individually fetch their current patreon memberships. Plus, with ★,°:.☆ cookie management ☆.:.°★
To be honest, I'm not totally sure if cookie management is really needed.

@Roliga

Yes, turns out all you need is the session-id cookie and returns the unlocked links for the logged in patron.
This comment showing the difference in the presentation extension is actually from a patron-only post: https://www.patreon.com/posts/patreon-poll-of-86317614
https://github.com/RSS-Bridge/rss-bridge/pull/3617#issuecomment-1678745825
I'm also realising now that this PR may need an explainer in the docs on how to set up the config for this bridge?

Just not sure whether if it is appropriate if this can be combined with the current PatreonBridge as an optional session_id config or if a seperate bridge extending off of PatreonBridge is needed to have both "non-patron / public" and "patron-unlocked" Patreon bridges.

Upon further thought, I am closing this PR and will not be submitting PRs for bridges that provide access to a user's personalised page(s).
These kinds of bridges will stay on my fork of this repo.


nhost Hasura Browse Query Failed Bug

Hello Everyone!
I am facing issues with Hasura GQL Engine since morning. Whenever I try to add a new field in any on my table it takes so much time to load and after sometime an Error message comes up which

states:
TypeError: Cannot read properties of undefined (reading 'length')
at n (https://subdomain/console/assets/versioned/main.js.gz:1:5611811)
at fo (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5422039)
at es (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5430999)
at Ql (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5469702)
at zl (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5461435)
at jl (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5461360)
at kl (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5458210)
at https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5409182
at t.unstable_runWithPriority (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5484993)
at oa (https://subdomain.nhost.run/console/assets/versioned/vendor.js.gz:1:5408891)
But at the same time that field is added into my table with an error message that can be seen in following screenshot

We had some issues with the database yesterday but I think we fixed it. Do you still experience this issue?

It's fixed now.


Badge style is inconsistent

When you repeatedly click the 4 rounded badges it's quite noticeable that:

The Firefox logo has different sizes
The Firefox logo has a different vertical offset inside the badges
The badge's bottom part has a slightly varying curvature

Also the font size above "Firefox" varies, but I find that acceptable.

Thanks - will get those logos lined up!


🐛 The error message in terminal is not highlight for lint-staged.

Environment information
CLI:
  Version:                      1.6.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v16.20.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/8.19.4"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Linter:
  Recommended:                  true
  All:                          false
  Rules:                        a11y/all = false
                                complexity/useRegexLiterals = "off"
                                correctness/useExhaustiveDependencies = "off"
                                style/useImportType = "off"

Workspace:
  Open Documents:               0

What happened?
Screen shot

Normal Using
Lint Staged

Expected result
The lint-staged error should highlight.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Have you tried to use the --colors=force option?
If yes, I would seek support with the lint-staged community. As you noticed Biome prints colours in your terminal as expected. This means that lint-staged isn't probably piping stdout/stderr to your terminal

Adding --colors=force option is OK, thx!


Fast Fix : remove the arg

Contributing guidelines
Please read our contribution workflow before submitting a pull request.

@xiang90  I think you have forget a args here , I have removed it

@arthurkiller what's in master builds against the vendored version of go-systemd. Likewise, the interface etcd is using conforms with go-systemd's master (https://github.com/coreos/go-systemd/blob/master/daemon/sdnotify.go#L32) which has been that way since November.
Please follow the build instructions for building etcd with vendoring and etcd should build fine. Thanks!


Update Presentations.md

Analysis of Rainfall in India
@Anas07860 @Pritvii @Sharwannnn @VanshitRawat
Guys please mention your missed out teammates GitHub id here


Difference to Hoot

Hi, do you know this project?

I've heard of it, and it looks really cool. It's much farther along than this project. This is something I've been spending spare time on but unfortunately I haven't had much of that lately. That's a funded full-time project with multiple contributors. This project started from the ground up with the sole purpose of targeting wasm. Hoot is based on Guile. I'm not involved in the development process or know any details, but I'd imagine it inherits quite a few design decisions that were made long before wasm.
I'm using Guile to bootstrap this compiler, but at some point that should disappear. The main difference is the module system. I'm trying to avoid all other Guile-specific features.

Wouldn't you like to unite with Hoot?


Enable preset overrides

Description
This PR makes changes to allow for preset overrides from convert parameters. Additionally, a test appeared to require sorting as a result of this change so a minor change was added for this.
Closes #64
What is the nature of your change?

[x] Bug fix (fixes an issue).
[ ] Enhancement (adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] This change requires a documentation update.

Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.

[x] I have read the CONTRIBUTING.md guidelines.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] New and existing unit tests pass locally with my changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have deleted all non-relevant text in this pull request template.

Thanks @falquaddoomi for the review and comments! I love the idea of being able to supply JSON or similar as preset options to CytoTable and have created #66 to address this in the future. Please note: I also updated tests to avoid the use of Dagger, which has been showing unpredictable results concerning temporary directories within Github Actions images.


implement async mode (automatic speech recognition)

Done!
If it's not working as expected please don't hesitate to reply to this issue so we can investigate.
Thanks!

Nice.


Class changes when setting value

Describe your question
I´ve created this as question because I wasn´t sure if this is the intended behavior.
https://github.com/esfomeado/fixture-monkey-bug/blob/e4d3128a4cb798fff7ed6aa3c4c8b64d15ba68f3/src/test/java/com/example/bug/FixtureMonkeyTest.java#L171
On this test I have two class. A and B.
I then I create a B object and set it on the Alphabet. The issue is that the class will change from B to A sometimes.
If I use the Values.just it works but I would except to use the same class type as the one that I pass in and not another subtype.
Thanks

@esfomeado
Hello, it is unintentional. It is actually a bug.
I'll fix it in 1.0.15

@esfomeado
Thanks for waiting. 1.0.15 is released.
Please check if it is fixed.

It's fixed. Thanks


Creating two conda environments and then running makes only one show up

Testing #18731
Did this:
conda create -n testNoPython1
conda create -n testNoPython2

Then created a python file
Then ran the python file
Python file ran
Then selected an interpreter to try to pick 'testNoPython2'.
It wasn't listed.
I hit refresh and this happens:

Every time I hit refresh another instance(s) of testNoPython1 appears.

Might be a dupe of #18749

No I created both of them ahead of time. Everything is fine until I ran something with python.

Yeah reloading the window still showed multiple copies.

After the latest build, I get this now.

Initial interpreter list only includes one of my environments:

Forcing a refresh lists the other one

Initial interpreter list only includes one of my environments:

I see, did you wait for the initial refresh to finish? (Did "Discovering Python Interpreters" text disappear?)
I assume you created new envs before the extension was started. If so, I would again require the verbose logs until the initial interpreter list is loaded.
Thanks for helping with this.

I assume it was up to date. No more output was coming in the python output tab. I get this:

Here's the log:
pythonlog.txt

Please try the latest build: https://github.com/microsoft/vscode-python/suites/5784118548/artifacts/192898285, where we now use conda.bat over conda.exe.

Verified offline that it works with the latest bits.


rudimentary slack parser

This is my attempt at a Slack Incoming Webhook parser. It is just a quick hack so I can receive notifications from justinbarrick/fluxcloud whenever a deploy happens in my kubernetes cluster.
This is also my first time writing anything in go, so sorry about the code quality. It does however pass on the webhook messages so someone might find this useful
Things to note:

I had to add a From:  entry to the stanza.MessageBody instances. Otherwise my server would not deliver any messages to me
Slack requires a response of code 200, plain text ok so I added a new Response object to the return of the parserFunc.
This seems like an ugly change since go functions seem to work with the err code mixed in there however I couldn't figure out the proper go way of doing this. And as before it works so it might be useful
fluxcloud sends the notification in a single attachment. I tried to code for other message formats but I'm sure there are some messages which can not be parsed yet.

Hi @svensp,
thanks for your work on the Slack handler, i much appreciate it. I will review the PR this weekend!
Br, Thomas

Hi @svensp,
could you by any chance provide the body of the request you used to test the endpoint?
Br, Thomas

I used a mix of the slack webhook docs from https://api.slack.com/messaging/webhooks and the one actually sent by fluxcloud(after piping it through a json formatter for ease of reading and anonymizing my data):
{
   "channel":"#channel",
   "icon_emoji":":heart:",
   "username":"Flux Deployer",
   "attachments":[
      {
         "color":"#4286f4",
         "title":"Applied flux changes to cluster",
         "title_link":"https://GITURL/USERNAME/kubernetes/commit/COMMITSHA",
         "text":"Event: Sync: 0f34755, jabber:deployment/test\nCommits:\n\n* \u003chttps://GITURL/USERNAME/kubernetes/commit/COMMITSHA\u003e: change test to test webhook\n\nResources updated:\n\n* jabber:deployment/test"
      }
   ]
}

The very basic Use your Incoming Webhook URL to post a message version gets parsed:
POST https://hooks.slack.com/services/T00000000/B00000000/XXXXXXXXXXXXXXXXXXXXXXXX
Content-type: application/json
{
    "text": "Hello, world."
}

I did not work at supporting the more complicated webhook example Making it fancy with advanced formatting. Reason for this is the blocks used there build an interactive message. And I don't think a simple webhook can support that anyway.

Hi @svensp,
there are actually some changes i would like to make to your PR. I think the best would be to re-issue the PR (to the new branch slack-handler). But first, could you:

Use https://golang.org/cmd/gofmt/ on the changed files, otherwise my changes would change like every line you made.
Place the beforementioned POST body besides grafana-webhook-alert-example.json in the dev folder?
Br, Thomas

I wouldn't mind if you did the changes. I am by no means a go programmer so I'm sure it would be faster if you did them yourself, rather than instructing me on how to do them.
I enabled allow edits from maintainers too so changing them in the PR should work too.

If that works, we can do it as you suggested aswell.

Thanks so far. I think i'll refactor the handler tomorrow!


Change "copy" icon | Issue #28700

Changes the files copy_to_clipboard_svg.hbs to have the new icon from https://feathericons.com/?query=copy as required by the issue
Fixes: #28700

Screenshots and screen captures:
Before:

After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Please include screenshots of everywhere in the app that we have a "copy" icon, not just code blocks.

@alya I have added the screenshots of everywhere where we have a "copy" icon. Please review the PR.

@alya I have added the screenshots of everywhere where we have a "copy" icon. Please review the PR.

As you can see, there are major problems with the appearance of the icon, which it would have been helpful to point out.
It's my bad for not linking the Figma frame that has the icon. Can you try exporting it from there and seeing if that fixes the problem?

As you can see, there are major problems with the appearance of the icon, which it would have been helpful to point out.
It's my bad for not linking the Figma frame that has the icon. I've added a link to the issue. Can you try exporting it from there and seeing if that fixes the problem?

@alya I have changed changed the copy icon design according to the figma design link attached. Please review the PR.

Thanks! It looks in your screenshots like you've changed colors, and not just the icon? Was this requested somewhere?
Your PR also needs to pass test in order to be ready for review.

Closing in favor of https://github.com/zulip/zulip/pull/29455 for this issue.


data race from concurrent write/flush

Concurrent write/flush to http.ResponseWriter or http.Flusher would cause data race. This change sequentializes event processing. Normally this shouldn't be a performance bottleneck. If there are too many events, we could change this to batch processing, flush when there are no more events, or a small timer (20 milliseconds) expires.
Signed-off-by: Dong Chen<EMAIL_ADDRESS>

LGTM


Add files via upload

@COSLangworthy I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host csupueblo.edu.co not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Issue 447: mute buttons for other peoples' video/audio

It's a little janky - if you disable the video the elements jump up. I guess you could put a spacer square in there somehow (?)

And awesome, I was going to split out ParticipantChatView for something I was working on, glad you beat me to it 👍🏻


model.through() & collection.through() documentation

While improving bookshelf.d.ts I noticed a lack in Bookshelf documentation, it seems that:

Model.through() always returns a Model
Collection.through() always returns a Collection

This way it works beautifully with my app code + with Bookshelf examples:
    class Doctor extends bookshelf.Model<Doctor> {
        // belongsToMany() returns a Collection
        patients(): Bookshelf.Collection<Patient> {
            return this.belongsToMany(Patient).through<Patient>(Appointment);
        }
    }

    class Patient extends bookshelf.Model<Patient> {
        doctors(): Bookshelf.Collection<Doctor> {
            return this.belongsToMany(Doctor).through<Doctor>(Appointment);
        }
    }

    class Book extends bookshelf.Model<Book> {
        // Find all paragraphs associated with this book, by
        // passing through the "Chapter" model.
        paragraphs(): Paragraphs {
            return this.hasMany(Paragraph).through<Paragraph>(Chapter);
        }
    }

    class Paragraph extends bookshelf.Model<Paragraph> {
        // belongsTo() returns a Model
        // A reverse relation, where we can get the book from the chapter.
        book(): Book {
            return this.belongsTo(Book).through<Book>(Chapter);
        }
    }

Also it fits well Bookshelf unit tests, examples:

https://github.com/tgriesser/bookshelf/blob/0.9.4/test/integration/relation.js#L21

      // belongsToMany() returns a Collection
      // patient*s*() returns a Collection<Patient> not a just a single Patient
      patients: function() {
        return this.belongsToMany(Patient).through(Appointment);
      }

https://github.com/tgriesser/bookshelf/blob/0.9.4/test/integration/relation.js#L42

      doctors: function() {
        return this.belongsToMany(Doctor).through(Appointment);
      }

https://github.com/tgriesser/bookshelf/blob/0.9.4/test/integration/relation.js#L62

      // hasOne() returns a Model
      accountHistory: function() {
        return this.hasOne(AccountHistory).through(Account);
      }

https://github.com/tgriesser/bookshelf/blob/0.9.4/test/integration/relation.js#L73

      // belongsTo() returns a Model
      supplier: function() {
        return this.belongsTo(Supplier).through(Account);
      }

https://github.com/tgriesser/bookshelf/blob/0.9.4/test/integration/helpers/objects.js#L65

    info: function() {
      return this.hasOne(Info).through(SiteMeta, 'meta_id');
    }

...

I could not find a counterexample.

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again

This is might be not a top priority but it's still valid.
Model.through() still returns a Collection in the documentation. It propably should be a Model


Failing test and fixture for syncdata with natural keys

Failing test for Issue #1549

Coverage decreased (-71.5%) to 0.0% when pulling 61787ff53a7e5c9e882a7bb0022c43875caad3df on MattFisher:syncdata-natural-keys into 3d4a7d3f36357f1dac93ed79ce82751c6d4a0a1e on django-extensions:master.

I would love to merge but i am busy at work and likely won't have the time to work on a fix :-(
What we can do if we cannot make a PR for a permanent solution soon is to put one of these tests on expected to fail ( @xfail  ).
And maybe revert the previous change depending on what's the worst problem to keep :-)

@MattFisher Looks like the fixtures are not loading properly. Would you take a look and open a new PR so we can start fresh?


chore(backend): migrate from gin-gonic/gin to go-chi/chi

Gin comes with a lot of dependencies and doesn't use Go standard http handler.
Chi is smaller and allows to use standard middleware.


Add basic tool bar with unicode symbols

This PR, following a discussion with @hoechenberger and strongly inspired by cbrnr/mnelab#61, adds a tool bar with useful bindings to the features of _TimeViewer:

It's also an item of #7162 since it adds buttons to the interface.

This is not compatible with https://github.com/mne-tools/mne-python/pull/7589

I prefer unicode so no need to add any file in the repo.

works like a charm for me!

(I honestly think this looks so much worse than the SVG icons you had in the other PR…  Honest question :)

So, regarding which toolbar looks better, this one or the SVG one – maybe it is just a matter of taste.
But if the reasoning behind using an (imho) inferior UI design is technical limitations (e.g. keeping the sdist slightly smaller or sth), I really believe this decision should be reconsidered. TimeViewer is quickly gaining in features and is already one of the BIG selling points of our 0.20 release. It will only continue to get even more useful and at one point will be the "face" of MNE when it comes to source analysis. I think it's important that this face is looking as great as possible: a beautiful app creates a better UX and higher user affinity! UI candy is really important to many users (and me personally – hey, I'm using a Mac for a reason ;)) Just my… USD 2, this time ;)

looking at the size of this diff:
https://github.com/mne-tools/mne-python/pull/7592/files
it seems easier to maintain (1 file) and yes it keeps the sdist small.

It really looks like a KDE or Gnome app from 20 years ago on my computer. I don't like it.

Maybe I missed it, but why is FontAwesome not an option?  If distribution size is the only concern, it is possible to create a derivative font with only the icons we need (e.g., online tool fontello does this).

but why is FontAwesome not an option?

I proposed FA but I think it hasn't been considered / discussed yet :) Thanks for bumping this, this could really be a middle ground? :)

How big was the size diff, looks like it has been force-pushed over?
+1 for the trim-font idea from @drammock. It will keep pip install small. As we add icons it will hurt our repo size diff, but seeing as the entire fontawesome in our doc/_static/fonts is 165 kB and we will use a tiny fraction, I think this will be negligible.

Just for a "newcomer", why is the repo & sdist size so crucial? Users download the sdist… how many times a year? And I clone the full repo only when I move to a new computer. Why is size so important in 2020, where we have TB hard drives and fast internet connections?

I also think that file sizes in the kB range shouldn't matter in 2020. Moreover, SVG icons are much smaller than a font; MNELAB's icons are between 186 bytes and 2 kB. In addition, SVG icons are text files and thus better suited for version control than binary (font) files (although I doubt that we will ever change SVG icons).

Are people happy with these?  I included 2 options for "help", 2 options for "trash", and 3 options for "scale" (personally I like the sliders best for that one)

Your idea looks very promising @drammock and I really want to see how it looks but I do not know how to integrate it. Do you create a new font that should be loaded by PyQt?

@GuillaumeFavelier you can take this JSON config file and load it into the Fontello website, to pick up where I left off.  It will provide fonts in TTF, WOFF, WOFF2, EOT, and SVG format. I'm assuming PyQt can handle at least one of those.

I have the impression that rather than saving a day of work to different
people by trying to KISS
i now create more work. I will just say "be pragmatic" and keep in mind
that timing is not negligible

i now create more work. I will just say "be pragmatic" and keep in mind that timing is not negligible

I see what you mean, and sorry if I've been utilizing everybody's time here a little too much too :\ But I think that UI design is extemely crucial to make users happy.  I mean, there's a reason why big companies like Apple conduct extensive studies on their new products to finetune the UI and ensure good UX. Therefore I, personally, think that any time to discuss UI eye candy is time very well spent, if the goal is to increase the MNE adoption rate :)

I 100% agree with @hoechenberger. In my limited Qt experience, (SVG) icon files are the standard way to create icons. I've never seen someone use characters from special fonts. I'd just use the SVGs from the previous issue, they look good and weigh only a few kB.

Also, I'd try to make sure that the app looks as native as possible. This mean that the menu bar should not be attached to the window, but should go in the global menu bar at the top of the screen.

do what you think is best. I remove my vote from the polling booth

I would propose to merge this for now and improve later. Any objection?

Current status:

Alex has "retracted" his vote
Clemens is in favor of SVG icons, based on looks and his experience with Qt (and the use by other apps)
Daniel suggested to look into FontAwesome symbols, however this would require further work from Guillaume's side
I'm in strong favor of the SVG approach in #7589 too
So far I'm not aware of any strong technical implications "forcing" us to save on a few KB required for bundling SVGs, but correct me if I'm mistaken here

I would, therefore, like to suggest to close this one in favor of a re-opened (and merged :)) #7589 :) The work has already been done there, and we could move forward with a solution with which, to my understanding, we all could live.

I agree with @hoechenberger. I also want to add that if we have to bundle a new font this will take much more space than all SVG icons we're ever going to need. Still in the kB range though so not even important.

I won't vote again but please don't spend days on this...

+100 on moving ahead! @GuillaumeFavelier the stage is yours. 👌

Let's continue the effort on https://github.com/mne-tools/mne-python/pull/7589 then


No types for args in .find[...] methods when withAccelerate extension is applied

Bug description
When we apply withAccelerate extension to the prisma client, args types are lost for all .find[...] methods
findUniqueOrThrow(args: {}): AcceleratePromise<{ id: string; key: string; url: string; listId: string; blurHash: string | null; }>
How to reproduce

Expected behavior
No response
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS:
Database: PostgreSQL
Node.js version: 20

Prisma Version
5.10.2

Hi @devnaumov 👋
Can you please send a minimal reproducible example so we can investigate further?

@ludralph Here is the client initialization example
import { PrismaClient } from "@prisma/client";
import { withAccelerate } from "@prisma/extension-accelerate";
import withPaginate from "prisma-paginate";

const extendedPrismaClientGetter = () => {
	const prisma = new PrismaClient({
		log: process.env.NODE_ENV === "development" ? ["error", "warn"] : ["error"],
	});

	return prisma.$extends(withPaginate).$extends(withAccelerate());
};

export type ExtendedPrismaClient = ReturnType<typeof extendedPrismaClientGetter>;

declare global {
	var prisma: ExtendedPrismaClient | undefined;
}

export const prisma = global.prisma ?? extendedPrismaClientGetter();

if (process.env.NODE_ENV !== "production") {
	global.prisma = prisma;
}

-> generate schema via npx prisma generate
-> [entity].findUnique(args) type for args here is args: {}
-> remove withAccelerate extension
-> npx prisma generate
-> everything is back to normal
"@prisma/extension-accelerate": "^0.6.3",
"prisma-paginate": "^5.2.1",
"@prisma/client": "^5.10.2",
"prisma": "^5.10.2",

Can you update the client intialization as described in this issue comment to see if it resolves it for you?

@ludralph No, the problem still exists unfortunately


Instead of asterisk(*), version number found in cpes field for CVE-2024-34750

🐛 Summary
Thanks for the swift response team on #94. Raising this one as a follow up issue from #94
Clarify the following plz -
I can see cpe:2.3:a:apache:tomcat:*:*:*:*:*:*:*:* values in the "cpes" field changed to cpe:2.3:a:apache:tomcat:9.0.0:m1:*:*:*:*:*:* like values in this fix commit - https://github.com/cisagov/vulnrichment/commit/e938a179bdd9b1cf581b52ed1fae843f4f6b0d44#diff-2096d6367b2e2d315cc26b29d81287e5b29e07c0221f7b9938d51a96a26d4145
I have not seen NVD CVEs with version in CPEs when the affected config holds a range of versions. Similarly, should we stick here to cpe:2.3:a:apache:tomcat:*:*:*:*:*:*:*:* for "cpes" field values as all three affected the cases have version ranges? 🤔

@RamvigneshPasupathy Thank you for the questions. I don't have an answer for you right now, but we will discuss this to see how we want to handle entries like these.

Looping in @amanion-cisa and @todb-cisa.

CPE usage is, perhaps unclear at best, particularly within current CVE Record Format (see this issue). One approach, as noted by @RamvigneshPasupathy, is to only use vendor:prduct in cpes and then express version ranges or other details in the affected element. Another is to use vendor:product:version:and:possibly:more when that information is known, for instance, a single version, or the start or end of a range.

Overall "use of CPE in CVE" issues aside, the current CPE procedure is:

Only use vendor:product in the cpes list (except see #3 below)
Express version ranges in the affected[].versions object
If there is no range, and only a single vendor:product:version is affected, then list the version in the cpes list

Thanks for the update @amanion-cisa
And, will there be a data migration done to the CVE json files complying with the above CPE procedure.
Like for CVE-2024-20311, there are two cpes list - one with 390 cpes and another with 318 cpes; there are also corresponding affected[].versions values; as there are no range values associated with this case, shall we consider the affected[].versions field itself be removed from the CVE json in this case?


Android: Set/Update root properties

The iOS guide mentions appProperties to update the props of the root-view. There doesn't seem to be such a method for Android.

Any ideas on this?

@facebook-github-bot label Icebox

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-setupdate-root-properties
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot close

This is missing in the documentation.


gview WebApps (Version 6.24.2701) - Problems starting under IIS

I installed gView WebApps (v 6.24.2701) in two modes: locally and under IIS.
When starting the App via localhost:45... in an Edge Browser, everything works fine (i can login with admin credentials and the different Application tiles are displayed).

When starting the IIS mode via "https://{servername}/gview6-web/" i am able to login as admin, but i can't see any Application tiles.
I only get the "LOGIN" Button. When refreshing the Page via "F5" i can see the tiles and the "Logout" Button for a split second. Klicking the "LOGIN" Button once again has no effect.

When pressing F12 to track the problem the console shows two issues. One is a .css file (when adjusting the filename this error disappears), the second is a blazor.web.js issue. Maybe this is a proxy problem?
Are there any proxy settings in the WebApp configuration?
Any suggestions are highly appreciated.

Maybe you do not installed the WebSocket Protocol for you IIS:

The gView WebApps are Blazor Apps that uses interactivity via Web Socket Connections
If this is not solving your problem, please post the errror message from the console.

Now it works! Thanks a lot!


Drives Columns - Meaning

Most of the column meanings I understand. Does Ø = Average?
What do these mean?

TR Loss
Ø Speed
Ø Consumption
Consumed (would I use this value to calculate the consumed kWh of say 7.7 kWh and multiply that by my utility rate ($0.15663/kWh) to find the cost of how much going on that trip would cost me to charge at home)

Even on a larger screen the columns get mushed together. Is there a better way to format/display this?
Thanks!

TR means Typical Range. It is calculated as the difference of the reported "ideal range" at the start and end of a trip.
Ø is used as a symbol for the average. Apparently it's particularly known in German-speaking countries. I initially thought it's more common :D
Yep, "Consumed" can be used to calculate the costs of a trip. The value is not directly reported by the car and therefore needs to be derived from other measurements. It should be fairly accurate, though.


[PatchRelease][Part1] Prepare April Patch Releases

Exclude packages in Part 1:

Communication family
Content Safety

Edited:

typo in Search CHANGELOG: Cleint and Vetor
Remove Storage NIO and Changefeed tests. Both packages are still in beta and not in the patch release list. It is safe to remove them.

API change check
API changes are not detected in this pull request.


Remove thisArg from non-nativesque operators

Per discussion here #787, we will remove the thisArg arguments from all operators that aren't meant to mirror something in native JavaScript.
So really, only map, filter, reduce and forEach should have thisArgs.
Furthermore, the internal bind helper introduces a closure and should probably be removed in favor of using apply or call directly within those operators, or it should be otherwise refactored to not use closures.

+1 I think this is important for consistency.
Just adding that the following also need a thisArg: some find findIndex and every

Reopening until #993 is merged.

Closed by #993


Add tooltips

Todo

[x] Add tooltip CSS
[x] Add tooltips to the global toggle
[x] Add tooltips to the platform icons
[x] (Optional) Add tests to check that the tooltips don't show when the extension is first opened

Motivation
Some platform icons may be unfamiliar to users. The purpose of the global toggle is not obvious.
Summary of changes

The CSS controls whether the tooltip is shown/hidden using the visibility property and :hover selector.
The tooltip-element class defines which elements are hoverable. The tooltip span must be nested inside this. The tooltip-element could not be directly added to the <img .. /> tag as this does not work.

Attached GitHub issue
Closes #101
Checklist
Documentation

[x] New functions and methods have additional comments added to document their usage

Local Build

[x] Ran all pre-commit hooks pre-commit run --all-files
[x] Extension has been tested to build correctly cd extension && yarn && yarn build
[x] Backend has been tested to build correctly cd backend && docker-compose build
[x] Extension test suite has been run locally cd extension && yarn && yarn test
[x] Backend test suite has been run locally cd backend && python3 -m unittest

GitHub

[x] Target branch has been set correctly
[x] PR has been rebased onto target branch
[x] PR has been assigned an owner
[x] Author has performed a self-review of the code
[x] Removed the WIP message from the top of this PR

Codecov Report

Merging #102 (68c0051) into Release-2.0 (9885078) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           Release-2.0     #102   +/-   ##
============================================
  Coverage        71.31%   71.31%
============================================
  Files               12       12
  Lines              387      387
  Branches            56       56
============================================
  Hits               276      276
  Misses              79       79
  Partials            32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update to rails 5.0.0

I got this:
rake appraisal:rails50 test_jdbc_mysql

NoMethodError: undefined method `accept' for nil:NilClass
                                                                                to_sql at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/connection_adapters/abstract/database_statements.rb:12
                                                                                select_all at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/connection_adapters/abstract/database_statements.rb:32
                                                                                select_all at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/connection_adapters/abstract/query_cache.rb:70
                                                                                find_by_sql at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/querying.rb:39
                                                                                exec_queries at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation.rb:699
                                                                                load at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation.rb:580
                                                                                records at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation.rb:260
                                                                                find_take at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation/finder_methods.rb:525
                                                                                take at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation/finder_methods.rb:100
                                                                                find_by at /Users/pavel/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-5.0.0/lib/active_record/relation/finder_methods.rb:78

Solved undefined method 'accept' for nil:NilClass, problem was with recent arel gem

thanks for the PR - not sure how to proceed ... yet. the rails-5 branch is off 1-3-stable but has breaking changes in terms of 1.3 compatibility with JRuby as well as AR versions. this seems to bring those changes further down the path. thus I rather hold off merging until a solid Rails 5 release plan is in place.
anyways I much appreciate your effort - thanks!

@kares @headius Any chance of merging the PR? I would really love to migrate to Rails 5 with pg support in jruby. Let me know how I can help.

@zoras unfortunately, as far as I know NO adapter (except SQLite3) is Rails 5 complete/tested.
PR is not bad but "hacky" ... if arel removed those AR-JDBC's code should deal with that without forcing things back onto the Arel name-space (as my original comment above suggested).
code-base is hard to manage as is and there's little :purple_heart: coming back ... these days.
will look into an alternative piece of code, although not sure I like the rails-5 branch as is ... maybe later


New package: Orbits v0.9.1

Registering package: Orbits
Repository: https://github.com/cadojo/Orbits.jl
Created by: @cadojo
Version: v0.9.1
Commit: 060237b8b7b1faff2c8e08f675e148061f57180e
Reviewed by: @cadojo
Reference: https://github.com/cadojo/Orbits.jl/commit/060237b8b7b1faff2c8e08f675e148061f57180e#commitcomment-50332514

[noblock] This package name is similar to CORBITS.jl. That package is a wrapper for a C library. This package is a pure Julia package, which provides astrodynamics calculations. It's the (final) rename and refactor for UnitfulAstrodynamics.jl. If anyone has any comments or concerns about this new name, or rename, please let me know!

[noblock] To give a bit more context for the name change, there are several other astrodynamics-related packages, including SatelliteToolbox.jl, OrbitalTrajectories, and currently un-registered Astrodynamics.jl and AstroBase.jl.
My package (currently named Orbits.jl) provides structures, calculations, propagations, and plotting for Restricted Two-body Problem orbits, Circular Restricted Three-body Problem orbits and N-body Problem orbits. It also provides some simple ephemeris interpolation, and Halo orbit, Lambert, and Kepler solvers.
This is to say, this package isn't specific to one sub-domain of astrodynamics, it's a general package for astrodynamics problems. At my highest aspiration (it's nowhere near this), this package is similar to Python's poliastro. I hope to add maneuver and mission planning features this coming year.
Hope the name is accepted, but of course open to other name suggestions & comments.


Cannot make rpm with incompatible install of geopm in user/system path

Remove make check from make rpm
Update internal CI to run make check explicitly

Fixed with 18270fa5de0527e71ceb99b54bf4a9e790ce700a


rocm-1.6 vector copy hsa runtime failed.

cd /opt/rocm/hsa/sample
./vector_copy
Initializing the hsa runtime failed. This issue is similar to #145.
But my platform is

Haswell i5 + Fiji Nano + Ubuntu 16.04

Before, rocm-1.5 works very well.
$ uname -a
Linux tim-hsa 4.9.0-kfd-compute-rocm-rel-1.6-77 #1 SMP Wed Jun 28 07:30:27 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux
$ hipconfig (part of the result to make it concise)
HIP version  : 1.2.17263
HCC clang version 5.0.0  (based on HCC 1.0.17262-e8cf396-540c9ca-363dd5c )
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/rocm/hcc/bin
LLVM version 5.0.0svn
Optimized build.
Default target: x86_64-unknown-linux-gnu
Host CPU: haswell
== Linux Kernel
Hostname     : tim-hsa
Linux tim-hsa 4.9.0-kfd-compute-rocm-rel-1.6-77 #1 SMP Wed Jun 28 07:30:27 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial

This issue is caused by using an old version libhsakmt.so in /opt/rocm/libhsakmt/. Check its date and
make sure you have a good latest version.


[TASK] Add RenameClassNonPhpRector

see: https://github.com/rectorphp/rector/pull/6373

Thank you
Could you run fix cs as well? There seems to be some new fixes from PHP CS Fixer.
composer fix-cs

Thank you :hugs:


Update Sarama to 1.20.1

Which problem is this PR solving?

#1335

Short description of the changes
Update Sarama to latest version that includes a related fix as per: https://github.com/Shopify/sarama/releases

Resolves #1335


better handling of exceptions in async contexts

This oneliner crashes the python client:
py vim.session.threadsafe_call(lambda: [vim.eval("3"),undefined_variable])
yes the vim.eval("3") is needed.
Print exceptions arising from async plugin handler, as already is done for sync ones.
Define nvim.threadsafe_call a wrapper around nvim.session.threadsafe_call) that prints uncaught exceptions in the async call, as well as the context the call came from. Also I don't think we should recommend plugins to call methods on nvim.session if they can avoid it, it's better to put all exported methods, including threadsafe_call on the api objects.
Docs are missing, so WIP.

I wonder if threadsafe_call should be async_call because it also makes sense to call it in a sync request handler in the same thread like this
    @neovim.function("IPyConnect", sync=True)
    def ipy_connect(self, args):
        # do stuff that would be racy if it was an async contexts
        # (configuring an output buffer in my case)
        self.do_sync_stuff(args)
        # do the rest asynchronously
        # (waiting on an external process, so should be async)
        self.vim.async_call(self.do_async_stuff,args)

or even in an nvim-aware old-style plugin
if has('nvim')
   :python vim.async_call(async_function)
else
   :python sync_function()
end if

only problem it might be confusing with nvim.call(..., async=True)

:+1:


conditional action sequences?

My question is related to a feature I hope Openwhisk supports.
I have 3 actions A1, A2 and A3 and a condition C which evaluates to true/false. I want to chain these actions together such that:
A1;
if(C){
A2;
}else{
A3;
}
I only see that OpenWhisk has a way to have a fixed sequence A1->A2->A3 but is it possible to chain these actions based on some boolean condition?
I'm happy to provide more details if needed.

We refer to this as ECA (event condition action) -currently you can do this by returning any error from the condition action. There's a proposal to improve this which I'll cross link.

See https://github.com/openwhisk/openwhisk/issues/995#issuecomment-265589172.


Support for node removal

Hi, currently, this (nice) plugin only watch for node adding, but when a node is removed, the HTML DOM node is not removed, leading to… garbage display.
Is it plan to handle node removal?

Ah, good shout. Should be pretty trivial to fix. I guess there are two cases that should be handled, the data changes so there is no longer a 'dom' value, or the cytoscape node is actually removed from the graph.

I've implemented this in my fork, see https://github.com/mwri/cytoscape-dom-node/compare/master...nielsboogaard:cytoscape-dom-node:master.
I can create a PR for it if you want @mwri

Hi @nielsboogaard I think it would be great if you did a PR. Looking at your diff, shouldn't it listen to the remove event though to facilitate this?

Yes, that's what I said. Implemented it now upon changes in the data object, but can be extended with listening to remove as well. Will do and create a PR after that.

Hi @nielsboogaard I think it would be great if you did a PR. Looking at your diff, shouldn't it listen to the remove event though to facilitate this?

Yes, that's what I said. Implemented it now upon changes in the data object, but can be extended with listening to remove as well. Will do and create a PR after that.

Hey. Did you managed to get the PR done and ready to submit?

Hi @nielsboogaard I think it would be great if you did a PR. Looking at your diff, shouldn't it listen to the remove event though to facilitate this?

Yes, that's what I said. Implemented it now upon changes in the data object, but can be extended with listening to remove as well. Will do and create a PR after that.

Hey. Did you managed to get the PR done and ready to submit?

Not yet, very busy lately and the coming weeks. Hopefully more time in some weeks.


Problem with Rails 4.1 and cancan

If I use the cancan gem with Rails Admin I get the following error after logging in:
No route matches {:action=>"new", :controller=>"devise/sessions"} missing required keys: []
There doesn't seem to be a way to get past it. Can anyone recreate this or point at a likely cause?

Please reopen if there's any update.


Environment variable does not pass-through by limactl shell

Description
$ cat printenv.sh
echo $MY_VAR

# in host
$ MY_VAR=test ./printenv.sh
test

$ MY_VAR=test limactl shell default ./printenv.sh
# print nothing

# in guest
$ MY_VAR=test ./printenv.sh
test

So the environment variables are not passed through by limactl shell today. Is this the expected behaviour? If so, I'm interested to learn the reason of it.
I'm aware of Lima yaml has a field to pass env var but seems it can only be populated one time during booting, instead of passing-through in each limactl shell command.
Context of my use case.

limactl shell is just establishing an ssh connection. You would have to configure both the client and the server side to allow transfer of an environment variable.
An easier way is to just assign the variable explicitly in your remote command:

$ MY_VAR=test limactl shell default ./printenv.sh
# print nothing

$ MY_VAR=foo; limactl shell default printenv MY_VAR
$ MY_VAR=foo; limactl shell default MY_VAR=$MY_VAR printenv MY_VAR
foo


Test/new deploy setup

This PR aims to update the test setup to use more modern tooling like hardhat et all. A few dependencies like the rns-sdk which requires node v19 for the tests to successfully pass makes makes this PR a bit ahead of it time. The amount of work already expended and still required to make it work with current tooling renders this very low priority.

The approach this PR takes to update the project has made this PR become obsolete.  Hence we'll no longer continue to work on this. Incremental updates that still preserve backwards compatibility was the way the team decided to go.


Add passport auth & RethinkDB sessions

We'll want to add freeyourstuff.cc-style authentication with local/Twitter/Facebook/Google accounts, but this time we'll be using RethinkDB and Express-Passport.

Local done, FB/Twitter/Google/... remaining


decrease min ping interval for rpc servers

Description
This PR decreases the minimum allowed ping interval on the interchain router and broker rpc server (serves the CLI) to make sure we are not cancelling streams due to server timing issues.
Related PRs
List related PRs if applicable
Todos

[ ] Tests
[ ] Documentation
[ ] Link to Trello

 Maker connection periodically drops


Build for tini-static fails on centos 7

When running cmake . && make I run into
cmake . && make
-- The C compiler identification is GNU 4.8.5
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kstam/git/tini
Scanning dependencies of target tini
[ 50%] Building C object CMakeFiles/tini.dir/src/tini.c.o
Linking C executable tini
[ 50%] Built target tini
Scanning dependencies of target tini-static
[100%] Building C object CMakeFiles/tini-static.dir/src/tini.c.o
Linking C executable tini-static
/usr/bin/ld: cannot find -lc
collect2: error: ld returned 1 exit status
make[2]: *** [tini-static] Error 1
make[1]: *** [CMakeFiles/tini-static.dir/all] Error 2
make: *** [all] Error 2
Any hints on how to go about fixing this?
Thx!

You're probably missing yum install glibc-static
(see http://stackoverflow.com/questions/16024978/usr-bin-ld-cannot-find-lc-while-compiling-with-makefile)

yup that was it. Thx for your quick reply.

No problem!


Keyboard Manager - Limitations Link Incorrect

ℹ Computer information

PowerToys version: v<IP_ADDRESS>
PowerToy Utility: Keyboard Manager
Running PowerToys as Admin: True
Windows build number: 20H2 10.0.19042.746

📝 Provide detailed reproduction steps (if any)

In "Keyboard Manager" module, click link to "Learn more about remapping limitations" directly below "Enable Keyboard Manager" "on" slider.

✔ Expected result
Should link to https://docs.microsoft.com/en-us/windows/powertoys/keyboard-manager (preferably to the box halfway down - "Note"
❌ Actual result
Links to https://github.com/microsoft/PowerToys/wiki/Keyboard-Manager-Overview which says "This file has been moved" then has link to above page.
📷 Screenshots

Apologies if I misplaced or miscategorised this bug - it could be documentation as well, first time doing this! Didn't spot a duplicate bug already, sorry if I missed it. Sorry!!

@smckane
I cannot reproduce it using PowerToys 0.31.2


Prevent unnecessary journal read on first bake/create call, fixes #114

Codecov Report

Merging #115 into master will decrease coverage by 7.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   83.89%   76.84%   -7.06%
==========================================
  Files         119      119
  Lines        2595     2837     +242
  Branches      127      132       +5
==========================================
+ Hits         2177     2180       +3
- Misses        418      657     +239

Impacted Files
Coverage Δ

.../main/scala/com/ing/baker/runtime/actor/Util.scala
80.64% <ø> (ø)
:arrow_up:

...ker/runtime/actor/process_index/ProcessIndex.scala
84.61% <100%> (ø)
:arrow_up:

...ntime/actor/process_instance/ProcessInstance.scala
95.37% <100%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644733b...ee11696. Read the comment docs.

for this is blocked by: https://github.com/akka/akka/issues/25072


node-mapnik faster on linux

@millzpaugh is seeing slower results in staging benchmarking, so I'm concerned that some of the vtcomposite code may not be faster than node-mapnik.
So I just ran the latest benchmarks on linux (a stageyprod machine) using vtcomposite @ 695dd3d  (with the fixes to the bench in #77).
I'm able to consistently replicate slower results with vtcomposite than node-mapnik for 3 bench rules using this command:
node bench/bench.js --iterations 200 --concurrency 6 --package node-mapnik --compress --mem

node-mapnik
5: tiles completely made of points, overzooming, no properties ... 6667 runs/s (30ms)
6: tiles completely made of points, same zoom, no properties ... 4878 runs/s (41ms)
17: buffer_size 4096 - tiles completely made of polygons, overzooming (2x) and lots of properties ... 1980 runs/s (101ms)
Benchmark peak mem (max_rss, max_heap, max_heap_total):  993.38MB 9.48MB 18.03MB
Benchmark iterations: 200 concurrency: 6

vtcomposite
5: tiles completely made of points, overzooming, no properties ... 4878 runs/s (41ms)
6: tiles completely made of points, same zoom, no properties ... 2439 runs/s (82ms)
17: buffer_size 4096 - tiles completely made of polygons, overzooming (2x) and lots of properties ... 1460 runs/s (137ms)
Benchmark peak mem (max_rss, max_heap, max_heap_total):  563.96MB 8.2MB 13.03MB
Benchmark iterations: 200 concurrency: 6

/cc @artemp @alliecrevier @millzpaugh @joto @ericfischer

I did some digging here (still on linux). I've noticed 2 things:

The work at #79 does not benefit these particular rules (while it does benefit others)
The speed of node-mapnik is not as great (or the same) when individual benchmarks are run (using https://github.com/mapbox/vtcomposite/commit/fe20f22e422afab0e8cbcfad11a5a3959b219934). It is only when all the benchmarks are run that node-mapnik is predictably faster
profiling with perf shows that the bottlenecks are different for node-mapnik and vtcomposite: for some reason longest_match is a more severe bottleneck for vtcomposite

Doing this:
perf record -g node --perf_basic_prof_only_functions bench/bench.js --iterations 500 --concurrency 1 --package vtcomposite --compress --mem --only 'tiles completely made of points, overzooming, no properties'
perf report -g --no-children

Gives this for node-mapnik:

And this for vtcomposite:

Further digging reveals one potential cause for longest_match being a larger bottleneck for vtcomposite: it is called more times than in node-mapnik.
I found this out by using gdb to count the number of times it is called (which I learned from https://monoinfinito.wordpress.com/2014/11/18/gdb-hit-count-ignoring-breakpoints-for-a-while/):
I ran the benchmark with just one iteration (to keep things sane):
gdb --args `which node` bench/bench.js --iterations 1 --concurrency 1 --package vtcomposite --compress --mem --only 'tiles completely made of points, overzooming, no properties'

I changed the bench.js code like this (to reduce the deflate calls from node.js's zlib):
diff --git a/bench/bench.js b/bench/bench.js
index 0da5d22..b6c405d 100644
--- a/bench/bench.js
+++ b/bench/bench.js
@@ -46,7 +46,7 @@ if (rules.length < 1) {
 }

 rules.forEach(function(rule) {
-  if(argv.compress){
+  if(false){
     rule.tiles.forEach(function(t){
       const compressedTile = zlib.gzipSync(t.buffer);
       t.buffer = compressedTile;

Then in gdb I set a breakpoint on longest_match:
b longest_match

Then I ask gdb to skip past all matches:
ignore 1 999999999

Then I ran the program:
r

That reveals that longest_match was called 2535 times:
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   0x0000000001273ea0 <longest_match>
	breakpoint already hit 2535 times
	ignore next 999997464 hits

Doing the same thing for node-mapnik with gdb --args which node bench/bench.js --iterations 1 --concurrency 1 --package node-mapnik --compress --mem --only 'tiles completely made of points, overzooming, no properties'.
This shows that node-mapnik only called longest_match 1634 times:
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   0x0000000001273ea0 <longest_match>
	breakpoint already hit 1634 times
	ignore next 999998365 hits

Okay, this hypothesis is starting to feel solid: that longest_match is being called more with vtcomposite generated data than with node-mapnik generated data and that this is the source of the larger bottleneck on longest_match and slower compression times.
I've now also found that longest_match being called more is also replicable on OS X, locally.
And I've been able to isolate outside of vtcomposite. I wrote a CLI tool for gzip over at https://github.com/mapbox/gzip-hpp/pull/29 and dumped the vtcomposite and node-mapnik output by adding this to the bench:
diff --git a/bench/bench.js b/bench/bench.js
index ea4fc3f..9175975 100644
--- a/bench/bench.js
+++ b/bench/bench.js
@@ -100,6 +100,7 @@ function runRule(rule, ruleCallback) {
           if (err) {
             throw err;
           }
+          fs.writeFileSync('testcase-vtcomp.mvt',result);
           return done(null,result);
         });
         break;
@@ -126,6 +127,7 @@ function runRule(rule, ruleCallback) {
             if (err) {
               return cb(err);
             }
+            fs.writeFileSync('testcase-mapnik.mvt',result.getData());

             let options = {compression:'none'}
             if (rule.options.compress){

Then I ran the CLI from https://github.com/mapbox/gzip-hpp/pull/29 on each of these .mvt files and detected the count of longest_match in lldb like:
$ lldb -- ./build/gzip ../vtcomposite2/testcase-vtcomp.mvt
(lldb) b longest_match
(lldb) r
(lldb) c -i 999999997
(lldb) breakpoint list

Which outputs this for node-mapnik:
	1: name = 'longest_match', locations = 1, resolved = 1, hit count = 8375 Options: ignore: 999991623 enabled
	  1.1: where = gzip`longest_match, address = 0x00000001000084d0, resolved, hit count = 8375

And this for vtcomposite:
	1: name = 'longest_match', locations = 1, resolved = 1, hit count = 10805 Options: ignore: 999989193 enabled
	  1.1: where = gzip`longest_match, address = 0x00000001000084d0, resolved, hit count = 10805

Aha! Dumping the .mvt file using protoc shows they have a different order of feature fields...
mason/mason install protobuf 3.2.0
./mason_packages/osx-x86_64/protobuf/3.2.0/bin/protoc --decode_raw < testcase-mapnik.mvt > testcase-mapnik.raw.txt
./mason_packages/osx-x86_64/protobuf/3.2.0/bin/protoc --decode_raw < testcase-vcomp.mvt > testcase-vtcomp.raw.txt

Gives a long diff with a lot of this:
   2 {
     3: 1
-    1: 2000
     4: "\t\240.\370."
+    1: 2000
   }

So node-mapnik features look like:
  2 {
    3: 1
    4: "\t\314\034\250-"
    1: 1
  }

While vtcomposite features look like:
  2 {
    3: 1
    1: 1
    4: "\t\314\034\250-"
  }

Wow. The different field order explains the difference in speed between node-mapnik and vtcomposite. Here is my proof:
I rebuilt node-mapnik (on linux/stageyprod) with this patch applied to mapnik-vt (which makes the field order the same as vtcomposite): https://gist.github.com/springmeyer/407798879f7b552a3af52e7d3ecc81f3
Then I ran the benchmark again and profiled and 💥 the massive longest_match bottleneck now shows up in node-mapnik:

And the bench shows the difference too:
normal/unmodified node-mapnik:
node bench/bench.js --iterations 500 --concurrency 1 --package node-mapnik --compress --mem --only 'tiles completely made of points, overzooming, no properties'

1: tiles completely made of points, overzooming, no properties ... 1042 runs/s (480ms)
Benchmark peak mem (max_rss, max_heap, max_heap_total):  58.55MB 7.4MB 18.03MB
Benchmark iterations: 500 concurrency: 1

vtcomposite master:
# node bench/bench.js --iterations 500 --concurrency 1 --package vtcomposite --compress --mem --only 'tiles completely made of points, overzooming, no properties'

1: tiles completely made of points, overzooming, no properties ... 912 runs/s (548ms)
Benchmark peak mem (max_rss, max_heap, max_heap_total):  44.64MB 7.28MB 13.03MB
Benchmark iterations: 500 concurrency: 1

modified node-mapnik (https://github.com/mapnik/node-mapnik/compare/vtzero-feature-field-order) with crippled performance due to the new gzip bottleneck:
# node bench/bench.js --iterations 500 --concurrency 1 --package node-mapnik --compress --mem --only 'tiles completely made of points, overzooming, no properties'

1: tiles completely made of points, overzooming, no properties ... 780 runs/s (641ms)
Benchmark peak mem (max_rss, max_heap, max_heap_total):  58.54MB 7.41MB 18.03MB
Benchmark iterations: 500 concurrency: 1

The only guess I have here is that the different order either makes the data align better in some way or makes better use of CPU caches or so. The longest_match code in zlib is deeply magic and can optionally use an assembler implementation, so it is hard to tell what's going on in there.
If this is the case, it should also depend on the IDs used, whether they fit in a byte or need more. Of course we could change the order of the fields in vtzero, but that could make other cases worse and/or depend on the zlib version and other details. We need many more benchmarks before we could justify this. It might well be that with slightly other data, things are different and the benchmarks are misleading here, because the data they use is quirky in some way.
Oh, and there is a reason the feature_id comes first when using vtzero: When filtering by ID, it is faster that way.https://github.com/mapbox/vtzero/blob/master/include/vtzero/layer.hpp#L388-L419 has less work to do.

We need many more benchmarks before we could justify this.

I think @millzpaugh and @alliecrevier may be seeing a similar pattern as my single/local test in production with a huge range of traffic. But they will need to confirm. If production traffic shows an overall slowdown with vtcomposite and perf output that shows longest_match is a larger bottleneck then I think we should consider what it would take to have vtcomposite/vtzero write fields in a different order.

Of course we could change the order of the fields in vtzero, but that could make other cases worse and/or depend on the zlib version and other details.

Yes, its possible. Per my first comment I think @millzpaugh and @alliecrevier should benchmark and profile with perf to compare node-mapnik vs vtcomposite with a lot of varied traffic and see if the pattern persists or not.

Oh, and there is a reason the feature_id comes first when using vtzero: When filtering by ID, it is faster that way.https://github.com/mapbox/vtzero/blob/master/include/vtzero/layer.hpp#L388-L419 has less work to do.

👌 thanks for pointing that out. Which application has this usecase? (also, perhaps better to discuss this at /vtzero I realize)

Wow @springmeyer, thank you for such clear documentation throughout your debugging process.
@alliecrevier and I will pull two random samples of compositing traffic from the elb logs to run again and confirm that longest_match is a bottleneck in vtcomposite.

We are sticking with our current compression library gzip-hpp for now. Going to close this issue and reopen if we want to optimize feature field ordering + compression.

We are sticking with our current compression library gzip-hpp. Going to close this issue and reopen if we want to optimize feature field ordering + compression.

👌 Good call to stick with the current for now. I will say however that I have a strong hunch that a speedup awaits us if we can dig into either changing the field order or moving to faster zlib implementation. But we can handle that in other tickets at a future time.


should use from tensorflow import keras as tfkeras

Use tensorflow==1.5.0,
this line (https://github.com/qubvel/classification_models/blob/master/classification_models/tfkeras.py#L1)
would be failed.
And I revised this line to from tensorflow import keras as tfkeras and then it works.

Hi, please update your tf version, 1.5 is too old.


new: LICENSE file with MIT License template

Added license to repository and this project.
License corresponds to MIT template

Build and Deploy to Cloud Run action manually canceled to this PR


Some Updates

X11 updated dialog to create T98-Next hdd image with size larger than 999MB.

Oh, thanks!
If you find other problem, send me request feel free.


[HOLD for payment 2023-07-26] Connect Bank - Connect bank account step counter disappeared

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login
Go to setting => workspace => your workspace
Bank account => Connect Manually
Observe that  "Step 1 of 5" that appears not appears in the header like the production

Expected Result:
In manually connecting we should have a Step counter
Actual Result:
In manually connecting  Step counter is missed from the header
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.42-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/76e33624-397d-44ca-aadb-2987a6004ede
https://github.com/Expensify/App/assets/93399543/f8172d27-af27-4f28-b338-c7f1ad917882
Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689660526773759
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
by : @ahmdshrif
Problem Restatement:
The problem we are addressing is that the steps counter is not appearing in the header of the manual connect to the bank feature.
Root Cause:
The root cause of this issue is the refactoring of the HeaderWithBackButton component from a class component to a function component. During this refactoring, the default value of shouldShowStepCounter was changed. Previously, the default value was true, as shown in this code:  link. However, when the component was converted to a function component, the default value of shouldShowStepCounter was mistakenly set to false, as seen in this code:  link. As a result, any component that did not explicitly pass the shouldShowStepCounter prop would take the default value of false, causing the steps counter to be hidden.
Proposed Solution:
To resolve the problem, we recommend reverting the aforementioned change and setting the default value of shouldShowStepCounter back to true. By doing so, the steps counter will be correctly displayed in the header.
an additional issue related to the connect with Plaid in production. Once the initial issue is addressed, the steps counter should not be displayed during the Plaid integration. We have proposed a solution for this in the following Slack thread: https://expensify.slack.com/archives/C049HHMV9SM/p1689660306598649?thread_ts=1689660228.939159&cid=C049HHMV9SM
Alternative Solution Explored:
An alternative solution that has been explored is to keep the default value of shouldShowStepCounter as false and explicitly pass this prop to all the places where the steps counter needs to appear like BankAccountManualStep.js

@ahmdshrif thanks for the investigation. I took a closer look at that prop and I think it's unnecessary since we can derive its value from subStep prop. I went ahead with my solution of removing the prop entirely.

This regression came from https://github.com/Expensify/App/pull/21852 and there's possibility that PR would be reverted. - https://github.com/Expensify/App/issues/23052#issuecomment-1640394821

I think even if we revert that PR, this is still a good clean up

We just CP'd the fix, I'll retest and close this out once the CP is done

@ahmdshrif sorry about that! We'll make sure you get paid out. Thanks for raising this to your attention.

@ahmdshrif please ask for help in this slack thread which is a lot quicker than waiting for update on closed GH

First off.. let's reopen this puppy 🐶
@ahmdshrif can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~013d200e4dffabf2cf
(sidenote.. this very likely won't be paid, in final, til after the holidays, sorry for the delay)

Reporter: @ahmdshrif paid $250 via Upwork (report was in July)


VSCode on Mac not showing all subscriptions

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:
From MAC

Sign into Azure via Sign in on GUI
cmd palete to list subscriptions "Azure: Select Subscriptions"
Not all subscriptions are showing up.

From Windows

Sign into Azure via Sign in on GUI
cmd palete to list subscriptions "Azure: Select Subscriptions"
Not all subscriptions are showing up.

Can you please report this over in https://github.com/Microsoft/vscode-azureresourcegroups ? This repo is for the base product, VS Code and what you're reporting is coming from an extension.


after load jit file, torchscript runtimeError

File "Grounded-Segment-Anything/EfficientSAM/app.py", line 60, in efficient_sam_box_prompt_segment
predicted_logits, predicted_iou = model(
^^^^^^
File "/root/anaconda3/envs/ml_zb/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: shape '[0, 3, 1, 2]' is invalid for input of size 1572864
after add env like this:
export PYTORCH_NVFUSER_DISABLE=fallback && python EfficientSAM/app.py
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/root/anaconda3/envs/ml_zb/lib/python3.11/site-packages/gradio/queueing.py", line 501, in process_events
response = await self.call_prediction(awake_events, batch)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/anaconda3/envs/ml_zb/lib/python3.11/site-packages/gradio/queueing.py", line 465, in call_prediction
raise Exception(str(error) if show_error else None) from error
Exception: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: thread_predicates_.find(tv_inp) != thread_predicates_.end() INTERNAL ASSERT FAILED at "../third_party/nvfuser/csrc/lower_thread_predicate.cpp":221, please report a bug to PyTorch. Thread predicate map was not initialized, couldn't find T6_l[ 0 ]
can anyone help me ?

Can you share the code being used here?


Fixing segmentation fault on certain instances (ta022) multiGPU version Chapel.

Pool capacity might not be big enough depending on the size of s in function pushBackBulk. This should fix the problem for highly irregular instances.

Closed in favor of #8


Unable to get SCIM extension attributes via SCIM filter operation

Steps to reproduce
Create SCIM user with extension attributes. e.g. "wso2Extension":{"organization":"WSO2"}
Invoke filter with the extension attribute.
curl -v -k --user admin:admin https://localhost:9443/wso2/scim/Users?filter=wso2Extension.organization+Eq+"WSO2"
Response: {"Errors":[{"code":"400","description":"Filter attribute is not supported.."}

Fixed


Add campaign fields

Closes #168

Added support for Amazon S3 following https://github.com/jschneier/django-storages
Added support for displaying media urls locally for debugging.
Added new fields in DB.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

44 of 46 (95.65%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 91.925%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

safe_locking_service/campaigns/models.py
14
16
87.5%

Totals

Change from base Build<PHONE_NUMBER>8:
0.07%

Covered Lines:
2163

Relevant Lines:
2353

💛  - Coveralls


Address Selection drop down is unstyled

When given suggestions for an address field, the drop down has only generic browser list styles

Resolved as of v1.0.0


Start RPC server before loading snapshot

Summary of changes
Changes introduced in this pull request:

Change the ordering of tasks in daemon.rs to start the RPC server prior to loading the snapshot

Reference issue to close (if applicable)

Closes #1800
Other information and links

I modified the code to properly shutdown if ctrl-c is detected.


pablodraw: init at 3.3.13-beta

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi! I've created a PR here: https://github.com/NixOS/nixpkgs/pull/287984

Do you want to maintain this package? I may not use it often.

I thought this was too niche and did not even think of seeing if someone already did a PR (:

Sure, I can maintain the package!


Update schema.graphql

prepare for storing annotations for sub assessments or supplementary metadata. Ideally bible-graph stores both the data and metadata necessary for assessments and the full output including assessments and annotations. Combined with a model, hardware, and a description of how the assessment works, it should allow full-reproducibility.

Ok. I say this is enough talk. Let's try it out and see what works well and what doesn't work!


Add failing integration test for v0.2

With new versions of ember-test-helpers, integration tests for components invoked in block-form fail in apps using ember-engines. This PR has a failing test to debug against.
The failures start with @rwjblue's recent changes to use outlets in integration tests (ref). So I am almost positive the issue lies somewhere in the outlet keyword modifications.
cc @tjni

@rwjblue / @dgeb unsure if this is the best fix, but I've backported the current outlet behavior from upstream and it seems to fix the issue.

LGTM - thanks @trentmwillis :shipit:

v0.2.9 contains this change.

Thanks @trentmwillis for this fix.


Unable to add comments to existing/new lines

While reviewing a PR I can only add comments to deleted lines of code (left panel in figure, line 1), while I cannot do this for existing/new lines.

Extension version: 5.814.597
VSCode Version: 1.66.2
OS: Windows 10 Enterprise build 19044.1586

@martijnkriebel I haven't been able to reproduce this issue. Does this happen every time for you?

@alexr00 I tried it for a new PR, and for some reason the extension does work as expected here!. Unsure why I had troubles with the other PR though, as it worked fine for my colleague (who is using the same version of the extension and VS Code as me).

Hmm. There have been some changes in this area. I'll investigate further.

I've got the same thing happening right now in Codespaces, VS Code v1.67.0, extension v0.42.0.
I'm in review mode for a pull request, and I can only open comments in the left pane:

No amount of clicking will let me do the same thing in the right pane.
Let me know if there's anything I can do to help debug this; I checked the extension output and there's nothing noteworthy.

@aaronadamsCA does this happen every time? And, if the PR is in a public repo can you share it?
I haven't been able to reproduce the issue yet.

I've tried several times today and I can't seem to reproduce the issue again. I don't know what changed!

Thanks for the update! Closing, we can re-open create a new issue if we see it again.

Think I found what was going on: https://github.com/microsoft/vscode-pull-request-github/issues/3556#issuecomment-1126038772


Add Bind DNS

If possible,

Add Bind DNS node that has a caching DNS server configured
A master zone and reverse zone that contain the hostname of every node installed
The resolv.conf of every node points to the DNS node

Hi @jaimesicam ,
There is a hostname:server.domain.local option. It populates /etc/hosts on all nodes.


Binary version mismatch: Available version (1.7) lags behind stable version (1.7.1)

I noticed that the currently available binary version of mev-boost (1.7) does not align with the latest stable version (1.7.1).
To ensure  users have access to the most up-to-date and reliable version, I kindly request that the maintainers update the available binary to reflect the latest stable version (1.7.1).
Thank you for your time and consideration.

See https://github.com/flashbots/mev-boost/issues/626


Too many # at the end of my title line

Hi there!
I have a super small issue with the boxes...
From:

I obtain:

One of my colleague has the same problem with one computer but not the other.
Any ideas to solve it?
=]

Yup, I noticed this issue as well since https://github.com/ThinkRstat/littleboxes/commit/b4b97bd8bfac871a20660b4219d92b34e047d405.
I am unsure what the purpose of this commit is.
Are you sure your colleague uses the latest github version of this addin? Ask them to run
devtools::install_github("ThinkRstat/littleboxes")

My guess is that they should now be able to reproduce your issue.
For the time being, you can probably go around this issue by using my fork, where I reverted the faulty commit. Run:
devtools::install_github("Bisaloo/littleboxes")

Restart rstudio and it should now work.

the extra ### was a request from some users. The purpose was to use the collapse functionnality from Rstudio
see https://support.rstudio.com/hc/en-us/articles/200484568-Code-Folding-and-Sections
I will make a new branch without this.
thanks @Bisaloo for your review

devtools::install_github("ThinkRstat/littleboxes") # without ####
devtools::install_github("ThinkRstat/littleboxes",ref="collapse") # with ####


MFA in the CMS (create the modal)

Create the ability to show the MFA app in the CMS. This would be rendered in a modal.
Example design, that would be handled in separate issues: https://projects.invisionapp.com/share/H2R2N2EFTMY#/screens/352910417
ACs

The modal should be stand alone
Able to initialise the app in different views, i.e display recovery codes when reset in the CMS.

I'd be keen to discussing how this could relate to the following RFC https://github.com/silverstripe/silverstripe-framework/issues/8595
The 'sudo mode' would appear to simplify the transition to handling the authentication of user for CMS actions (as the list is growing: site MFA settings, update password, update email, update/add MFA method, reset backup codes, etc)

I'd be keen to discussing how this could relate to the following RFC

I think this is less relevant now as we've been investigating only requiring a password to enter a potential sudo-mode, not full MFA authentication.

whether the implementation of 'Accessway' makes this issue redundant

I thought that adding additional MFA methods would still use a modal and not the "accessway"/login flow - I'm very happy to be told otherwise.
/cc @silverstripeux

I also thought it was still in the modal too. I see Accessway is an authenticating tool (provides initial signup for just one method and then after that, it only serves a purpose of authenticating? the others need to be added via the CMS). I think the user flow isn't going to be the best if every time you need to add to your settings you get taken away.

I'm open to using the modal, my comment was just meant to ask the question of an alternative.


Fix --version not returning the version

--version is returning the commit hash because the checkout step in CI is not fetching the tags.
According to the doc:

Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.

Should close https://github.com/tarides/ocaml-platform-installer/issues/125

Still outputting the wrong answer...
$ ./ocaml-platform --version
1c7de42

I have something slightly better at https://github.com/Julow/ocaml-platform/tree/test-release-action (1.7.0-4-... instead of test). Still WIP.

I seem to have fixed the issue. It might be a bug in actions/checkout, which doesn't fetch the annotated tags correctly (relevant issue: https://github.com/actions/checkout/issues/882)

I can't find a test release in your fork with the newest fix. I would prefer if we can test this one before releasing another ocaml-platform version!

It's this one: https://github.com/Julow/ocaml-platform/releases/tag/test


Can this work with angular > 1.7

I noticed the package.json has a semver range:
"angular": ">=1.3 <1.7"

Is there a known issue in angular 1.7 that prevents this package from being compatible or is it more of a safe upper bound of what is known to work well with the package?

Hi, it will likely work with later 1.x versions. Happy to relax the version if the tests pass. It will probably not work with later major versions.

Hi Ben. I noticed that the package.json file has the updated angular version, but the NPM package does not. Any way you could push a new build to the NPM repo? Thanks in advance.


Schema validation: fails for "molecule.yml" : pipelining: true not allowed as an option to ssh_connection in the provisioner schema

Issue Type

Bug report

Molecule and Ansible details
ansible --version && molecule --version

ansible [core 2.13.5]
  config file = /Users/REDACTED/.ansible.cfg
  configured module search path = ['/Users/REDACTED/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/REDACTED/workspace/.venv/lib/python3.10/site-packages/ansible
  ansible collection location = /Users/REDACTED/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/REDACTED/workspace/.venv/bin/ansible
  python version = 3.10.8 (main, Oct 13 2022, 10:17:43) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
  jinja version = 3.1.2
  libyaml = True
molecule 4.0.3 using python 3.10
    ansible:2.13.5
    delegated:4.0.3 from molecule
    docker:2.1.0 from molecule_docker requiring collections: community.docker>=3.0.2 ansible.posix>=1.4.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used:
Desired Behavior
No error when running schema validation with the following provisioner config in molecule.yml
provisioner:
  config_options:
    ssh_connection:
      pipelining: true

Actual Behaviour
Schema validation fails:
molecule -vvv test
DEBUG    Validating schema /Users/REDACTED_USER/REDACTED_ROLE_NAME/molecule/default/molecule.yml.
CRITICAL Failed to validate /Users/REDACTED_USER/REDACTED_ROLE_NAME/molecule/default/molecule.yml

["Additional properties are not allowed ('pipelining' was unexpected)"]

Removing pipelining: true from molecule.yml let me run molecule without issue since the schema validation does not fail anymore.
    ssh_connection:
      pipelining: true

It seems that pipelining is not one of the valid option in the schema and adding it or maybe setting  "additionalProperties": true would fix the config validation issue I am now running into since schema validation has been implemented/moved into molecule.
https://github.com/ansible-community/molecule/blob/f8d08dff973e8e65cdac81a804cdb8015925fabe/src/molecule/data/molecule.json#L416-L429
REM: It seems a bit restrictive to only allow. control_path and scp_if_ssh  as ssh_connection properties.

It seems that pipelining is not one of the valid option in the schema and adding it or maybe setting "additionalProperties": true would fix the config validation issue I am now running into since schema validation has been implemented/moved into molecule.

@fredflev
You are absolutely right. Could you plz submit a PR to fix it?
@ssbarnea
There are many options in ssh_connection connection plugin.
It will make this schema bigger if we add each option in it.
So I think "additionalProperties": true is acceptable as well as other model which may contains many options.
Let me know if you have any concern.


Sql lab queries not working

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

I'm trying to run query in async mode using celery and redis. But I'm getting this error::
ERROR/Worker-1] Query with id 16 could not be retrieved
This is my celery config-
class CeleryConfig(object):
  BROKER_URL = 'redis://localhost:6379/1'
  CELERY_IMPORTS = ('superset.sql_lab', )
  CELERY_RESULT_BACKEND = 'redis://localhost:6379/1'
  CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
  CELERYD_LOG_LEVEL = 'DEBUG'
  CELERYD_PREFETCH_MULTIPLIER = 1
  CELERY_ACKS_LATE = True
CELERY_CONFIG = CeleryConfig

SQL_CELERY_DB_FILE_PATH = os.path.join(DATA_DIR, 'celerydb.sqlite')
SQL_CELERY_RESULTS_DB_FILE_PATH = os.path.join(DATA_DIR, 'celery_results.sqlite')

redis --
from werkzeug.contrib.cache import RedisCache
RESULTS_BACKEND = RedisCache(
    host='localhost', port=6379, key_prefix='superset_results')

Superset version
0.20.6
Expected results
The sql lab query should run in celery in async mode
Actual results
Celery giving an error:
ERROR/Worker-1] Query with id 16 could not be retrieved
Steps to reproduce

Are you sure your worker is pointing to the same metadata database? My guess is that your superset_config is different or not in effect (not in your PYTHONPATH perhaps) on your worker.
For this to work the web server and worker need to share the same metadata db.

I'm using the same superset config. I'm using sqlite as the db.
I tested the config. Its the custom config I'm using.

How do I check if I'm using the same metadata db?

Well SQLLite won't work here as it's a poor man's database that's on the local file system. It has limited support for concurrency, you should use MySQL or Postgres.


Fix not being able to remove networks from user config

Fixes #211, a bug introduced by #57.
Previously it used to simply override entire networks object, but #57 made it use merge method, which makes it impossible to remove disconnected networks. This PR changes it to assign which works similarly to merge, but only on root keys, which overrides the networks object just fine.
http://stackoverflow.com/a/33247597/2200891

So, am I right in saying that if we are removing a network, the opts object will have that network as undefined, and "assign" will then override it to be undefined in the user object, but "merge" will always set it to the non-undefined one, which means it can't be removed?

Not sure I understand, in which case would it be undefined? The network is removed using _.without. And opts is always passed in with networks object.
https://github.com/thelounge/lounge/blob/2201e2b941bd13427c38d6934b84ceda245aa20e/src/plugins/inputs/quit.js#L10
https://github.com/thelounge/lounge/blob/2201e2b941bd13427c38d6934b84ceda245aa20e/src/client.js#L411-L413

Well I don't understand the change then. What is assign doing that merge doesn't then?

It only overwrites root keys, so the entire networks object is overwritten.

Right, that's what I meant. So the new networks object has the old networks without the one(s) that was removed. If merge was being used, it would take the non-undefined networks from the user object and use them in the merge, yeah?

Yes.

Cool. :+1: . Simple fix, so no need for second review. Merging.


Breaking within triple functions.

Bug
Breaking bug within triple loops.
Try this out.

Thanks for the report.
The test case work fine with latest code, please retest with upcoming 1.11 release


[skip ci] rgw users/buckets module

module to bulk create rgw users and buckets

sorry i should have read the contribution file. As for unit test i don't have any currently i can work on that, the module depends on a rgw host to do anything so ill need to deal with that. I have an example playbook. where should i put it? the infrastructure-playbooks directory?


Everything that takes a name should have the name be the first parameter.

Describe the refactor you'd like.
Things that have names (especially when the field is literally called name should have the name come first.
Why should the refactor happen?
Name is the second argument in lots of functions because it was added after a first argument.
We should standardize this, and name first leads to prettier code:
    val islandBuilder = EvvoIsland.buildecr()
      .addObjective(Objective(nameOfObjectiveOne, "Function1", Maximize))
      .addObjective(Objective(maybeAnInlineFunction, "Function2", Maximize))
      .addObjective(Objective(f3, "Function3", Maximize))

will become
    val islandBuilder = EvvoIsland.buildecr()
      .addObjective(Objective("Function1", nameOfObjectiveOne, Maximize))
      .addObjective(Objective("Function2", maybeAnInlineFunction,  Maximize))
      .addObjective(Objective("Function3", f3, Maximize))

See how they line up nicely? It's easy to scan for names now. Also, having a consistent calling convention is good.
Additional context
{Creator,Mutator,Deletor}Func as well as Objective need to be updated. Possibly other places, but definitely those four

This also needs to be changed in AAgent, as @rachlin pointed out on PR #109


ERROR: .FileNotFoundError: [Errno 2] No such file or directory: './docker-compose-LocalExecutor.yml'

Hello, I am totally new to airflow and have been following your steps to learn more on DAGS before creating a one for myself, I have done the initial setup and on UI when I turn ON the DAG's files and begin execution (trigger) the program enters running mode but it goes on indefinitely never stops.
Unable to see the task progressing as well.

In my investigation I found this:
To run any DAGs, you need to make sure two processes are running:
1.airflow webserver
2.airflow scheduler
so I guess I do not have a scheduler running so I ran --
docker-compose -f docker-compose-LocalExecutor.yml up -d
AND
docker-compose -f docker-compose-CeleryExecutor.yml up -d
However I am getting below error:
ERROR: .FileNotFoundError: [Errno 2] No such file or directory: './docker-compose-CeleryExecutor.yml'
ERROR: .FileNotFoundError: [Errno 2] No such file or directory: './docker-compose-LocalExecutor.yml'
Does anybody know how do I resolve this?  I have docker-compose installed.
docker-compose --version
docker-compose version 1.22.0, build f46880fe

@pratikhonrao I know this is going to sound silly, but are you running the docker-compose command in the same directory you cloned the repository into?

@ls12styler
Hi Ashley,
Issue resolved. I did not had LocalExecutor.yml file and was trying to run docker-compose -f docker-compose-LocalExecutor.yml up -d. Silly me.
Solution was to simply create clone that file into your directory where you are trying to run  docker-compose -f docker-compose-LocalExecutor.yml up -d.
Issue resolved. Closing. Thanks for your help !