Ctrl+H does not have any effect

Issue Type: Bug
The Ctrl+H key combination no longer displays the Find & Replace dialog. Selecting Edit > Replace from the menu bar does work. The Ctrl+F combination does display the Find dialog.
Repro Steps:

Type Ctrl+H.
No action occurs.

VS Code version: Code - Insiders 1.43.0-insider (c94724193451009962e2c116808f71a3328a9836, 2020-02-19T09:02:21.024Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.83GB (15.81GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

vscode-azurefunctions
ms-
0.20.2

mssql
ms-
1.8.0

remote-ssh
ms-
0.49.0

remote-ssh-edit
ms-
0.49.0

remote-wsl
ms-
0.42.3

azure-account
ms-
0.8.8

powershell-preview
ms-
2020.2.0

markdown-preview-enhanced
shd
0.5.2

@sc-bperry can you go to Keybindings Editor (F1 -> Preferences: Open Keyboard Shortcuts) and search for ctrl+h, and then share what you get ?

Thanks @rebornix! It looks like there is indeed a keybinding for the Replace command. Here are the results when I search for Ctrl+H:
Command                   Keybinding        When  Source
Replace                   Ctrl + H          --    Default
Search: Replace in Files  Ctrl + Shift + H  --    Default

Thanks, it means the keybinding is not override by any other commands. Could you please try to turn on keyboard recording mode (by toggling the first button in the search bar on the right side) and see what happens when you press ctrl+h?

It looks like my OS is not registering the "H" in the Ctrl+H command. When I type Ctrl+H in the recording mode, I get this result:
"ctrl+"
For further illustration, when I type Ctrl+F followed by Ctrl+H, I get this:
"ctrl+f ctrl+"
I just noticed that Ctrl+H doesn't work in other apps, such as Notepad++. This is not a problem with VSCode. I'll see what's going on post the answer just in case someone else comes across this thread. (FYI, my H key does work, just not Ctrl+H).

thanks for the detailed info! The keyboard shortcut might be used already by some other application.


Add change icon to tabs

[x] New feature (non-breaking change which adds functionality)

Proposed changes
This adds a change icon (blue circle) to the tabs based on whether their context have changed at all. This will help users find things that have changed and provide another visual cue they have un-deployed changes.

Whilst we did a good job of track changes on individual nodes, being able to properly track tabs that contain changes was actually quite hard to do. However, the Node Proxy object added as part of locking flows gave us the start of a mechanism to centralise the logic for reacting to the node's changed/moved state changing. But this had to be extended to include Groups and Junctions.
Tracking links was harder still, as their whole lifecycle is just a bit different to other flow objects.
Along the way, found and fixed a couple pre-existing bugs around tracking change history with undo and deploy.
Checklist

[ ] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage: 68.583% (-0.02%) from 68.608% when pulling bbc1a82c2a0adfdaf1f35db4e4b8fba49552b17d on change-tab-notification into 196a9ae43abd4211195f4698912a758bb904e6ab on dev.

Will it be visible if the tab has a very long name?

Thanks for testing it, Nick. I thought it could glitch with the text label fade effect.


Cleric Can’t see Enchantments

When you pick cleric, and look at the enchantments you are supposed to get, you get something completely different, and it can vary. This is due to the better enchants cleric is supposed to have but is rather useless when you don’t actually know what enchants you’re getting.

Closing this because it concerns Origins: Classes, not the base mod. See the issue here: https://github.com/apace100/origins-classes/issues/20


Update eosio dependency to 1.3.1

Do we need to keep updating to the latest version? Or should we take a "minimum version" dependency route?

We now have a more flexible dependency check (#89) that takes a hard minimum and optional hard maximum.


New version: TyPython v0.3.0

Registering package: TyPython
Repository: https://github.com/Suzhou-Tongyuan/jnumpy
Created by: @songjhaha
Version: v0.3.0
Commit: 4872893ce86cd3a1e87958140463b75ae514ec95
Reviewed by: @songjhaha
Reference: https://github.com/Suzhou-Tongyuan/jnumpy/commit/4872893ce86cd3a1e87958140463b75ae514ec95#commitcomment-83819695
Description: Writing Python C extensions in Julia within 5 minutes.

[noblock]


Uncapped framerate causing coil whine

Opening passive tree causes coil whine from gpu and somewhat unresponsive tree.
This is on a gtx 1080 and all attempts at capping framerates have been unsuccessful.
Solution might be something like this https://stackoverflow.com/questions/14968857/controlling-fps-limit-in-opengl-application

There's a replacement for SimpleGraphic.dll here which uses an event loop instead of an unbounded loop, which greatly reduces resource usage: https://github.com/Openarl/PathOfBuilding/issues/636


[AMORO-1744] Rename the name of classes with the arctic identifier in the mixed-format-hive module

Why are the changes needed?

As titled.
Brief change log

Change the name of classes with the arctic identifier
Change the name of variables and methods with the arctic identifier.
Change the comments with the arctic identifier.

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

👍


Remove dead node

Is it possible to remove dead node from the cluster?
RemoveMember seems to be just marking node as removed
Thanks

@shaj13 Please check this. The problem is that in my k8s deployment, I am using RemoveNode to scale down the pods running in the cluster but when I scale up again, sometime the pod is assigned the same IP as the removed node and this is where it fails saying that address already in use.

Fixed: We now allow reusing the address if a member has been removed. However, we do not allow the members to reuse IDs by design. Therefore, when scaling up and down, if member IDs are not changed, an error will be returned, and the leader will refuse to add the member to the cluster.


PyGaggle MS MARCO Passage Retrieval Replication

Platform: Google Colab
GPU: Tesla T4
Re-Ranking with monoBERT

Re-Ranking with monoT5

I have the same replication results as https://github.com/castorini/pygaggle/pull/184, which is different from the results shown in the documentation.

@larryli1999 please retry replicating on new master?

@ronakice I re-run the inference with the updated master and I am able to reproduce the documented results.
Re-ranking with monoBERT

Re-ranking with monoT5


fixed folder creation for mac and linux

On a mac or a Linux System the folders MNIST_Converted_Training/Testing were created but all the files were exported in cwd.
Fixed the error by detecting the system, and specifying file names appropriately.

You could you use os.path.sep, it will be better.


[FLINK-2576] Add Outer Join operator to Optimizer and APIs

This PR implements FLINK-2576 (Adding the outer join operator to the optimizer and Java/Scala APIs, previously part of FLINK-2106).
For reference, the revious pull requests for the outer join implementation were #907 and #1052.
First of all thanks for the help we received in person and on the mailing list.
I designed the API as per the consensus on the mailing list and tried reusing as much code from the join operator api as possible.
This PR contributes the following:

An OuterJoinNode to the optimizer, and 3 Sort Merge OuterJoinDescriptors for each type of outer join
One outer join base operator
left/righ/fullOuterJoin() methods to the Java and Scala APIs

Including some updates to the join javadocs in Java/Scala APIs

Refactorings where necessary (mostly concerned with being able to reuse inner join operator code)
Specifically refactoring of the JoinOperator in the Java API:

Added JoinType property, identifying inner/left-/right-/full outer join
Removed PlanXUnwrappingJoinOperator classes, instead promoting the TupleXUnwrappingJoiners to be able to reuse the existing unwrapping logic
Added inner class JoinOperatorBaseBuilder to be able to transparently construct a base operator for all types of joins, as well as tuple unwrapping of left and right inputs
Make sure the user can't compile a default join plan for outer joins, as well as make projection joins work with outer joins (see below)

End to end integration tests for the outer join operator using the Java and Scala APIs in flink-tests

Usage & Implementation:
In both APIs we prohibit using the default join functionality for outer joins. The user is required
to specify a custom join function that combines the (potentially null) left and right side tuples.
In the Java API we support the projection join functionality for outer joins. (Projection joins are not yet implemented in the Scala API for inner joins, therefore no changes there.)
Important to note is that when the user performs a projection join, the type information is lost.
This is also the case for the inner projection join. Additionally, we explicitly "downgrade" the result type information of an outer projection join to a Tuple of GenericTypeInfo<>(Object.class), in order to be able to serialize null values.
A nicer way to do this would be to use an Optional<T> type to represent nullable tuple values, but because we can't rely on Java 8 types, nor did I want to hardcode a dependency to a 3rd party Optional type (e.g. from guava) into the API, we went this route, for now.

@jkovacs and @r-pogalz, thank you very much for this PR and the detailed description!
It's quite a bit of code so it will take some time to be reviewed. I hope to give feedback soon.
Nonetheless, we can start a discussion about the handling of projection for outer joins. By changing the type information to GenericTypeInfo<TupleX> to support tuples with null values, a DataSet<TupleX> cannot be used (in a join, groupBy, reduce, ...) as before because the runtime will use completely different serializers and comparators. Therefore, I am more in favor of not supporting projection for outer joins.

Thanks @fhueske, that's a good point I haven't considered.
Another idea that occurred to me was to convert the result tuple types to GenericTypeInfo<T> (instead of GenericTypeInfo<Object>), where T is the original type of the tuple field (e.g. String or Integer). This would be null safe and would allow the user to group by those fields, assuming of course they are sure that the fields are non-null (e.g. on a left or right outer join).
Although I'm not sure of all the consequences of using, say, GenericTypeInfo<String> instead of BasicTypeInfo<String> for serialization and comparison.
I pushed this change as https://github.com/jkovacs/flink/commit/f682baa50137e0a54bae091ba60ba85fdb8f4c1b to a different branch to test it
Also rebased branch onto current master and resolved conflicts (Failing test is some YARN integration test).

To partly answer my own question: One big drawback of downgrading the tuple field types to GenericTypeInfo is that for (de)serialization and comparison the generic Kryo serializers will be used, which are significantly slower than the native flink serializers and comparators for basic types, such as Integer (according to this blog post).
One obvious way to work around this is to only downgrade the fields that are actually nullable, and keep the original types of the definitely non-null fields (i.e. the types from the outer side of a left or right outer join). This way the user can still group/join/sort efficiently on the non-null fields, while preserving null safety for the other fields.
I pushed another commit for this to my temporary branch for review, if this makes sense: https://github.com/jkovacs/flink/compare/feature/FLINK-2576...jkovacs:feature/FLINK-2576-projection-types
As you can see I was really hoping to make the projection joins work properly :-) but if you feel that the effort isn't worth it or I'm missing something else entirely, we can for sure simply scrap that and throw an InvalidProgramException when the user tries to do a project outer join instead of defining his own join udf. Opinions on that are welcome.

Hi @jkovacs, thanks for all your efforts to make the projection work. Going for a GenericeTypeInfo would work in many cases but unfortunately not in all. For example union operates in Flink on serialization level and requires that all data sets which are unioned use the same serializer. By transparently using a GenericTypeInfo users might be surprised why DataSet<Tuple2<String,Long>.union(DataSet<Tuple2<String,Long>) does not work. If we only support OuterJoins with an explicit JoinFunction, the user has full control how to deal with null values and can even use a custom Tuple type or Tuple serializer (via Operator.returns()) that supports null values. In my opinion, the best approach is to only support OuterJoins with JoinFunctions.

Agreed with Fabian. For now, let's require join functions.
Future work would be to use Tuples with Options in Scala. In Java, we should probably add an option type as well (and teach the TypeExtractor to use them). Java core adds an Option type only in Java 8, unfortunately.
We could add one for Java 7 and deprecate it later.

We have a couple of unit tests to check the correctness of the API, i.e., check that valid use is working and invalid use throws an early exceptions. See for example org.apache.flink.api.java.operator.JoinOperatorTest. It would be good to have such unit tests as well for outer joins.

As I said in my previous comments, I would prefer to support projection joins initially.
Instead, it would be good, if we could ensure by API design that an outer join is always completed with an with(JoinFunction) call. One way to do this would be to return a special OuterJoinOperatorSetsPredicate object when .where() is called. This OuterJoinOperatorSetsPredicate does not return a JoinOperator when equalTo() is called but an unfinished outer join that only allows to call with(). That way, the regular join API would remain stable. Or do you have a better idea to model the API in the right way?
If we don't allow DefaultJoin and ProjectJoin for outer joins, we can also revert the corresponding changes.

Hi @jkovacs and @r-pogalz,
really good work! I left a few comments inline but overall the PR is in a pretty good shape. Please let me know, if you have questions or would like to discuss some of the comments I made.
Have a good weekend, Fabian

Thanks @fhueske and @StephanEwen for the comprehensive review and additional details on Flink internals!, I agree that we should rather wait to implement the projection join correctly at a later point.
I'll append a few commits addressing the review comments and squash them later into the appropriate commits when you feel it's ready to merge.

Thanks for the update @jkovacs and @r-pogalz. Very good work!
I will go ahead, try this PR, and merge it :-)

Looks good. I added one commit to restore binary compatibility. The code is not super nice, but it allows to runt programs which have been previously compiled without the need to recompile. We can still clean up the code later if we decide to do so. Final tests are running, will merge after they passed.

Oh, just realized we did not update the documentation.
I will open a JIRA for that and add it later today.

Thank you very much @jkovacs and @r-pogalz for adding outer joins to Flink!


Implement 2FA with TOTP

Hi, thanks for the useful tool!
I recently enabled 2FA on my Firefox account, using TOTP codes.
This breaks the ffsyncclient login process with a You must verify the login attempt message, which might be fine when the verification can be performed out-of-band (email), but it's a blocker for TOTP.
This PR adds an optional step (1b) during login. If a second factor of type totp-2fa is required by the server, ffsyncclient will ask the user for an OTP and call the required verification endpoint.

Hi, thanks for the PR, looks good on quick look through.
I will probably look over it this weekend (mostly create a TOTP-enabled account for myself and test it), and then merge it 👍 (and create a new version...)

okay looks good, I made few smaller changes

I changed the response of FxAClient.Login to return an SessionVerification enum, because the other methods all use errors only for "fatal" errors, not for signalling purposes
I changed an errorx.Decorate to fferr.DirectOutput in VerifyWithOTP (a wrong TOTP token can just be displayed to the user without stacktrace)
I added the other possible values for verificationMethod to the login method and adjusted the outputted text a bit for each one (Proper support for anything other than email-2fa and totp-2fa is still missing)
I added an --otp parameter to supply the token via the commandline, because personally I'm ussing ffsclient mostly in non-interactive scripting environments

I will probably make a new version sometimes this week, I'm currently a bit busy in my dayjob...

Oh, also if you want to create more PR's:
It would be nice if you checked the option to allow me to commit to your PR-branch, the I can more easily do small changes before the merge and the final git history looks a bit cleaner (with all relevant changes contained in the single merge-commit)

Thanks! Looks great.


[Feature Request] Open diagram via button

It would be nice to have a button to open the preview (instead of doing that manually from the command palette).
Exactly like in this extension. It has an "eye" icon on the top right which opens the preview to the right (like we have when opening .md previews).
Thanks for this great extension!

Thanks for the suggestion!
This makes sense for stand alone .mmd files, but a markdown file can contain multiple diagrams. What should be the behaviour? Preview the diagram where the cursor is, if inside a fence?

Didn't think of that, good point!
I'm unsure. At first thought I'd say it should only be for .mmd files, but that may lead to poor usability (user expects that preview button even when it's not showing).
Showing a preview when the cursor is inside a fence is a good option, but wouldn't that lead to higher CPU usage? Because the extension would need to track the cursor. Then again lots of extensions do that already... Tough call.
The simplest option is to not implement this feature! :smile:


TaskManager does not handle properly disconnected state

Connection can be lost at any event, between any async operations.
More over, it can be lost after point in time where TaskManager was used, but before ops coming from such interactions had a chance to be sent. Because of that, there is no way to move responsibility to handle connectivity state to end users, each DDS (including TaskManager) should work correctly across such transitions and abstract it away from users:
Error: Attempted to lock in disconnected state: initSync
at TaskManager.lockTask (E:\FluidFramework\packages\dds\task-manager\dist\taskManager.js:212:19)
at Function.createRunnerInstance (E:\FluidFramework\packages\test\test-service-load\dist\loadTestDataStore.js:103:27)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async LoadTestDataStore.run (E:\FluidFramework\packages\test\test-service-load\dist\loadTestDataStore.js:227:27)
at async runnerProcess (E:\FluidFramework\packages\test\test-service-load\dist\runner.js:136:30)
Stress tests have a bunch of race conditions that result in deadlocks and failures, I found this bug by attempting to use TaskManager to address these issues. Also TaskManager is already used in the test itself, and it will fail through the long test with exactly same symptoms as result of being disconnected while waiting for a lock in main cycle (disconnections are injected into test run plus they happen on regular bases).

Chatted with Vlad to get some more info.  He pointed out this logic in the stress tests that is unpleasant for a customer to write as an example of a scenario that could be made easier:
https://github.com/microsoft/FluidFramework/blob/main/packages/test/test-service-load/src/loadTestDataStore.ts#L228
Note that TaskManager does not (at least currently) attempt to make any guarantees about the actions a client takes in response to acquiring a task (e.g. guaranteeing that ops from the task are not sent if/when a disconnect occurs).  Tasks can protect themselves somewhat with cautious haveTaskLock() checks between async operations but will always run the risk of ops going out inappropriately due to op-resubmit logic which cannot be controlled today.  This is another area where we should do better but doesn't have an immediate/local fix we can make.


Add derive macro crate that generates typename() and as_ conversions.

Extension to the idea in #163.
use trustfall_derive::TrustfallEnumVertex;

#[derive(Debug, Clone, TrustfallEnumVertex)]
enum Vertex {
    User(String),

    #[trustfall(skip_conversion)]
    Message { author: String, content: String },
}

The above enum effectively gets the following implementations:
impl Typename for Vertex {
    fn typename(&self) -> &'static str {
        match self {
            Self::User { .. } => "User",
            Self::Message { .. } => "Message",
        }
    }
}

impl Vertex {
    fn as_user(&self) -> Option<&String> {
        match self {
            Self::User(x) => Some(x),
            _ => None,
        }
    }
}

The as_message() conversion method was not generated since it was explicitly disabled with #[trustfall(skip_conversion)].

Currently works only for tuple and plain variants. Open work items:

[ ] UI tests for the error message when the derive macro is applied to a non-enum
[ ] Should we generate conversion functions for struct variants? Either need UI tests for the error, or tests to make sure it works.

As for structs/functions: I do see the point, but if so I think it should be another PR. Right now all the demos are made this way, so perhaps it is best to start and see if the need comes up?

As for structs/functions: I do see the point, but if so I think it should be another PR. Right now all the demos are made this way, so perhaps it is best to start and see if the need comes up?

Ah sorry, I think what I wrote was confusing: I meant struct variants of enums, like this:
enum Vertex {
    StructLike {
        a: usize,
        b: &'static str,
    }
}

In this case, typename() is easy but the return type of fn as_struct_like() is tricky — should it be Option<(&usize, &&'static str)> with a tuple of the fields in the same order, or something else?

I realized that sometimes users may want a different conversion method, so now the #[trustfall(skip_conversion)] attribute on a variant disables generating a conversion method for it — so that we don't hog the as_<variant>() method name and the user can implement it themselves.
Added docs and updated the PR headline to match.

Done tweaking, planning to merge if all looks good to you @ginger51011!

Oh I really like this! Especially making it skippable, that prevents possible headaches.
I can look closer at the actual implementation later, but from a design perspective this is great!

If we want to add a trait bound later for Typename for BasicAdapter, we might want to separate this into two macros. From a user point of view, it would be very easy to do two derives, but very annoying to ignore everything if you only want Typename functionality.
Also, when I see a derive, I usually think "Ah I add this trait!". Here we add a trait and also some methods. What do you think?

Adding a Typename bound for BasicAdapter is an excellent idea! I'll do that right now.
I'm conflicted on the two derives. I feel like two derives might be a bit too intimidating for new users ("double the new things to learn"), but it definitely does disadvantage slightly more advanced users as you point out.
Could we just add a new Typename derive macro that just implements Typename for those cases, while keeping the TrustfallEnumVertex macro as the "one stop shop" for the full functionality?

Yes that would give more control! If we just add docstrings with links between the macros, confusion would be kept at a minimum. As you say most users would probably just use TrustfallEnumVertex


Inconsistent documentation for "can_get_message_thread"

Consider next thread in a chat (using TDLib 1.6.9):
MSG1 (initiate the thread)
MSG2-1 (as reply to MSG1)
MSG3-2-1 (as reply to MSG2-1)

All of the messages will have can_get_message_thread property set to true, so according to the documentation (@can_get_message_thread True, if the message thread info is available) thread info is available for all the messages, however getMessageThread returns "PEER_ID_INVALID" error for MSG2-1 and MSG3-2-1.  Those messages will have message_thread_id property set, however there is no method to get MessageThreadInfo by thread_id
Should MSG2-1 and MSG3-2-1 have can_get_message_thread set to false or getMessageThread do not fail on these messages?  Or maybe TDLib should provide a way to get MessageThreadInfo directly by thread_id taken from message_thread_id property of a message?
Thanks

You seems to try to get information about a message thread in a supergroup, which isn't linked to a channel. The ability to get message threads in such supergroups has been enabled yesterday, but in such supergroups message threads can be received only from root messages. TDLib 1.6.9 had no chance to know about such behavior and returns can_get_message_thread == true for such messages, which was correct for discussion groups. So, the can_get_message_thread flag should be false.

You seems to try to get information about a message thread in a supergroup, which isn't linked to a channel. The ability to get message threads in such supergroups has been enabled yesterday, but in such supergroups message threads can be received only from root messages. TDLib 1.6.9 had no chance to know about such behavior and returns can_get_message_thread == true for such messages, which was correct for discussion groups. So, the can_get_message_thread flag should be false.

Noted!  Yeah, I'm talking about ordinary supergroup not linked to a channel.
I have another related question.  getMessageThreadHistory accepts message_id that starts a thread, so client needs to find that message in the chat to get a thread history, however thread might be too long to calculate first message in a thread.  On the other hand each message in a thread has message_thread_id that could be potentially used instead of message_id in the getMessageThreadHistory method
What do you think about substituting message_id to message_thread_id in the getMessageThreadHistory method?  So client could fetch a thread without traversing reply_to messages to hit the first message in a thread
Thanks!

This is not intended to work, despite currently message_thread_id and the ID of the top thread message coincide. In official clients there will be no way to open message threads from internal thread messages.

This was fixed in TDLib 1.6.10.


Switch to FomanticUI ?

Shouldn't we switch over to use FomanticUI as SUI development stopped?
They are at 2.7, API is exactly the same so far, they are adding components (loaders, calendar(!)) etc.
I think semantic-UI-react would really benefit from that?
https://github.com/fomantic/Fomantic-UI

I really believe that this should be reconsidered. I definitely agree that a repository with 700+ issues and 100+ PRs opened, with the last commit on 21 Oct, shouldn't be considered maintained.
Look at this PR for example:
https://github.com/Semantic-Org/Semantic-UI/pull/6689
Although it was a false-positive, as there wasn't a security breach because the version that SUI is using is very old, if it was the case though we'd be still almost half a year later waiting to it to be reviewed and merged.
We all appreciate the work that you're doing here @layershifter @levithomason, but seriously what's the point of keep maintaining an integration for something that is abandoned?

Please hear me, Fomantic UI has more features and it's not compatible with Semantic UI. I.e. we can't add Slider component from FUI because SUI doesn't have styles for it. If we will decide to switch to Fomantic UI it should be Fomantic UI React. Do you see the issue?
I don't have time to work it on Fomantic UI React, sorry.

I just want to add my 2 cents here.
Believe it or not I am all for keeping SUIR using SUI. @layershifter is right when he says that it would no longer be compatible if SUIR moved to FUI with the styles not being available etc when using SUI. As @layershifter has said he doesn't have time to maintain a FUI port and I think I can safely say no one on the SUIR team can either and I have said multiple times that we also over at FUI don't have the time to maintain a port also.
I do understand that this is a problem but for what it's worth SUIR will just need to say backed by SUI.
I do want to say that for FUI v3 we will be trying to address this issue as best we can but that won't be any time soon. So for anyone who wants to use FUI with React I would highly recommend coming over to the FUI repo to discuss this.

Things changed, at least for me. Semantic UI is obviously dead the last release happened in 2018:

We will continue to maintain compatibility with Semantic UI and Fomantic UI via compat layer, see issues with compat tag.
For now, I definitely recommend to switch to Fomantic UI. Our docs will be updated to have a notice about Fomantic UI.
/cc @hammy2899 @lubber-de

Hi! 🙋♂
I would like to start a new project, using FUI and React, what's the status of the FUI compatibility? it's something ready to use? I can start a project with React and FUI or it's not ready yet??
thanks!


Loop, not a table type, * not found,

I am getting LINT_0017 and LINT_0018 errormessages, that table type is not found.
Corresponding table types are defined in data dictionary.

yea, so this depends a lot on the errorNamespace in the configuration, plus the options for dependencies configured in configured in ZABAPLINT_CONFIG

LINT_0108
 Type of "gt_pathitems" contains unknown: Table Type, unknown

table type gt_pathitems in example is ZSWAGFWPATHITEMS_TAB
config is:
  "syntax": {
    "version": "v702",
    "errorNamespace": "^(Z|Y|LT?CL_|TY_|LIF_|.*SWAGFW)",

@larshp dependency depth is 12
what else can I check?

Reports ZABAPLINT_LIST_DEPS and ZABAPLINT_DEBUG can be used for debugging
first report will show which objects are found and sent to the server, second report will reproduce the files sent to the server and save to a local zip for debugging purposes


BouncingScrollPhysics does not work at the start of a list when using shrinkwrap

Steps to Reproduce

Creatre a new flutter application
Replace home with a ListView
Set shrinkwrap to true
Set physics to BouncingScrollPhysics(parent: AllwaysScrollablePhysics())
Fill the list with some content
Scroll down to the bottom and beyond => List bounces back
Scroll to the top and beyond => List stops without bouncing

Expected results:
The list should bounce the same in both like it does when shrinkwrap is false.
Actual results:
The list does not bounce at the start (top if reverse is false, bottom if reverse is true) like it does at the end. This happens even if setting the physics to AllwaysScrollablePhysics(). The problem is also there whether or not the list needs to be scrollable to show all the content.

Logs

The output of flutter run --verbose is to long to paste here, but it shouldn't be needed for this issue

No issues found! (ran in 1.7s)

[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.2 20D80 darwin-arm, locale sv-SE)
    • Flutter version 2.0.3 at /Users/hannes/development/flutter
    • Framework revision 4d7946a68d (3 weeks ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/hannes/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (2 available)
    • Hanness iPad (mobile) • 00008101-000171311A38001E • ios            • iOS 14.4
    • Chrome (web)          • chrome                    • web-javascript • Google Chrome 89.0.4389.114

• No issues found!

I can reproduce this issue on latest master channel. Notice that the scrollbar have the bouncing effect but the list doesn't.

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-13.0.pre.469, on macOS 11.2.3 20D91 darwin-x64, locale en-AO)
    • Flutter version 2.1.0-13.0.pre.469 at /Users/pedromassango/Code/flutter_master
    • Framework revision ccf83d1de9 (2 hours ago), 2021-04-06 12:39:01 +0800
    • Engine revision d5fdd57ce6
    • Dart version 2.13.0 (build 2.13.0-203.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/pedromassango/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 54.1.4
    • Dart plugin version 203.7759

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

same problem. Any solution?

Closing per my previous comment.


"Add to Homescreen" Button update for English page

Change the "Add to Homescreen" to "Install App"

Completed on 25th July 2023.


Object.freeze values when merging them into cache

Using envify, it would be possible to detect if process.env.NODE_ENV === 'production', and only perform the freeze in dev mode. This also works with browserify, and when further run through uglify the branch to check NODE_ENV will be eliminated completely since envify inlines the variable value.
The utility here is making sure people treat falcor values as immutable, and only use Model.set when changing things. This might seem excessive, but there are already real cases where value mutation has happened in prehistoric code which caused interesting bugs/leaks.
Also, should we freeze recursively?

Negative.  We will more than likely not do this.


First Apple Sign in: Share email address

I tried to sign in with Apple from https://WeVote.US It seemed to succeed.
It asked me if I wanted to share my email address. I said yes.
I was redirected to this page with this error.
https://api.wevoteusa.org/apis/v1/appleSignInOauthRedirectDestination
/webapps/wevoteserver/WeVoteServer/apis_v1/views/views_apple.py in sign_in_with_apple_oauth_redirect_view
line 159
first_name = user['name']['firstName']

Exception: string indices must be integers
I will share the API page printout via Slack.

@DaleMcGrew Does not reproduce.  Can you try again.
That error message seems familiar, I may have fixed it long ago.

@DaleMcGrew Does not reproduce.  Can you try again.
That error message seems familiar, I may have fixed it long ago.

Archiving for later.

Archiving for later.


Website typo

This GitHub page (and several referring links) refers to the switch as the "GS803EP" but it's actually a "GS308EP":
https://gilesknap.github.io/maaspower/main/how-to/web_ui.html
Just sayin 'cause I couldn't figure out where to buy that model of switch at first :)

Fixed in https://github.com/gilesknap/maaspower/commit/a57eb8e39ddcf67a06e9ebc4a072949cc8e7d5ab


UWP API

How does we setup with UWP project, not desktop app / desktop bridge.
Would great it can run Windows 10 Compact Overlay, or only subset of Winrt?

You can use WinRT with .NET Core:
https://stackoverflow.com/questions/35277359/how-to-use-windows-runtime-classes-in-net-core-libraries
But your Desktop Application have no cross-platform compatibility!


Build(deps-dev): Bump cypress from 13.1.0 to 13.6.3 (#5482)

Pull request opened by the merge tool on behalf of #5482

Merged in 4097f62daedd59e02fcd64a473bae8666d491761


emscripten: 2.0.1 -> 2.0.25

Motivation for this change
Taking advantage of latest SIMD spec in WASM requires a much newer version of emscripten as well as (yet unreleased) clang 13 and a newer binaryen.
This PR updates emscripten to v2.0.25 (latest tag release). Binaryen and llvm were updated to revisions specified in emscripten releases repo DEPS file. See emscripten-releases-tags for the mapping of tags in emscripten-releases to emscripten versions.
I imagine llvm_git could be updated any moment which could at some point break emscripten. Not sure what would be the best course of action, as llvm_git doesn't seem to allow overrides.
Starting with clang 12, one of LLVM's modules is miscompiled under gcc resulting in random segfaults when precompiling emscripten libraries cache. I added a workaround taken from the bug's page: https://bugs.llvm.org/show_bug.cgi?id=50611
As for testing, out of emscriptenPackages on current master only zlib appears to be building. libxml2, xmlmirror and json_c are already broken.
I made adjustments that keep zlib building as well as fix libxml2 and json_c. xmlmirror appears to be more deeply broken and I don't have time to fix it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Just realized llvmPackages_git is not supposed to be used for nixpkgs. Well, guess this is not going to work.

I have a seemingly working emscripten 2.0.26 on my local branch, should I push it to this PR or create a new one @khovansky-al ?

@yu-re-ka thanks for taking on this. Feel free to open a new PR, I'll close this one in favor of yours. A bit busy with other things these days and probably won't have time to sit down and properly finish this for another week or two.
P.S. appreciate the attribution in your branch's commits. For Github to pick it up though I think the trailer should be Co-authored-by: ....

https://github.com/NixOS/nixpkgs/pull/133217/commits


populateMaxItemCountOnOriginalRequestOptions

Issue:
MaxItemCount is not being populated for the following scenario:
CosmosQueryRequestOption option = new CosmosQueryRequestOption()
Step 1: query(option).byPage(pageSize)
Step 2: query(option).byPage() -> we are expecting it continues to use the pageSize from step 1, but it did not happen

API change check
API changes are not detected in this pull request.


Inverse Dynamics

I have looked through your notes and they are brilliant. I have skimmed through your notes and have a shallow grasp of some of the concepts. Lets say someone has smart shoes and other wearables that can record the ground contact time, strike angle, left/right foot balance, distance, heart rate, muscle impulses, flight time, stride length, pace, cadence and so on, but not the force applied to the ground nor the ground reaction forces. Can I use inverse dynamics to determine the forces given all the other parameters? If I apply body segmentation and calculate my centre of mass and centre of pressure, can that be converted into a time series ? Does the position of the centre of mass affect posture and form ? When accounting for drag, how big is the difference in the surfaces of a cyclist and a sprinter ? Another question I have would be, if say, someone was on a wind surfing board and could accurately locate their position on a body of water using gps and also using an accelerometer on the sail, how would one apply inverse dynamics to calculate bouyancy forces, forces on an individual, and the propulsion force ?

yes, in theory you can use wearable sensors to get the data and apply inverse dynamics. Google for inverse dynamics using wearable sensors you'll find some work on this. It should be possible to use wearable sensors to apply to windsurfing as well, but I bet there will be a lot of technical challenges to do that.


Implement credentials support for distBaseUrl

Closes #126.
I am new to Gradle/Groovy - please let me know if I've made any rookie mistakes. I would've liked to add an integration test for this, but I don't know of a public https://nodejs.org/dist mirror that requires authentication.

Coverage decreased (-2.7%) to 95.349% when pulling 1a224ccca2be1d9bb69d8e68c11339f91971bc77 on eppsilon:feature/dist-credentials into 567073105f52863eb8e6c738015bb9d11bb4cb73 on srs:master.

Thanks. Will check it out. Think we could create a "dummy"-server for the integration tests so it's possible to test it.

Any updates on this?
This is a bit of a blocker for us, since we need to proxy all dependencies via Artifactory.

What is the status on this issue?
Can I do anything to help this getting merged?

We've been using this PR in production for about a year now with no issues, is there any chance it could be merged into master? I don't think it'll be possible to ever have tests for this one though.


FIX Macosx mysql2 crash

Can you explain what problem this fixes?
Also I don't think you've created any migrations so these database changes would probably cause problems for existing users.

It does not change the migration file name and will not affect existing user upgrades.
MySQL 8.0.13
Ruby: 2.6.2
Rails: <IP_ADDRESS>
mysql2: 0.4.10
Macos: 10.15 Beta (19A512f)
mysql2 problem: https://github.com/brianmario/mysql2/issues/1036
Fix issues: https://github.com/brianmario/mysql2/issues/990#issuecomment-403095886
crash.log

The update might be useful for #757 because of MySQL 8 however Postal should definitely be run on a true server, not a MacOS Desktop.

Yes, but should you also consider using macosx to debug your friends?

This isn't a very clean merge just to update the mysql2 gem. On that basis, I'm going to close this. I'll handle an upgrade of this when I do the full Rails upgrade shortly.


Feature: error handling

Description
This PR will add proper error handling for any situations Gluco-Check may encounter while creating a response
Motivation and Context
When a user asks Gluco Check a question, they will always expect a proper response. Even if something went horribly wrong on the backend. The Action needs to properly handle all known (and possibly unknown) errors that may occur, and provide clear info in case something goes wrong.
How Has This Been Tested?
Current tests still need to pass. Additional test specs should be added for common failures.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I've made my changes in a separate fix/ or feature/ branch
[x] My change requires a change to the documentation/website
[ ] I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
[ ] I've written tests to cover my change
[ ] My change is passing new and existing tests

Common failures include:

[ ] Pointer not available
[ ] Nightscout site unavailable
[ ] Nightscout Unauthorized (wrong/missing API token)
[ ] Network errors while talking to Nightscout
[ ] ...

In its current state, this PR can gracefully handle all of the error situations mentioned in the commend above 🙌
Still to do:

[ ] fix code coverage reporting. something in this change broke it
[ ] update docs to reflect refactored architecture
[ ] add new tests (depending on coverage)
[ ] review the newly refactored architecture


cbBTC risk parameter update

Ratifying exec: https://vote.makerdao.com/executive/template-executive-vote-aave-lido-market-usds-ddm-parameters-adjustments-allocator-spark-a-dc-iam-changes-surplus-buffer-upper-limit-increase-stability-fee-changes-savings-rate-changes-gsm-delay-increase-addition-of-ilks-to-the-linemom-addition-of-standby-spells-to-the-chainlog-funding-disbursements-esm-minimum-threshold-increase-ad-and-atlas-core-development-compensation-spark-proxy-spell-november-28-2024
@boet1 , @VoteWizard

Looks good to me


Create working multistage Dockerfile

Description
Create a new Dockerfile that meets the expectations of both the docker-compose and k8s cluster setups.
This means that the entrypoint to the container is the binary itself (celestia-appd in this case) .
It is expected that the appropriate arguments are passed to the container as if one was running the binary locally. Configuration isn't baked into the image and is expected to be passed as flags or using volume mounts.
For examples see docker-compose and k8s.
This has been manually tested using the following instructions:
cd celestia-app && docker build -f docker/Dockerfile -t jbowen93/celestia-app:multi .
cd devops-test/devnet && sed -i 's/jbowen93\/celestia-app:devnet/jbowen93\/celestia-app:multi/g' docker/docker-compose.yml
docker-compose -f docker/docker-compose.yml up

as well as with the devops-test/devnet/k8s cluster
closes: #153

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Since this Dockerfile is multi-stage and meets the requirements of k8s/compose setup, can we name it something ____.Dockerfile to indicate that this is its main use?

My intention was that this would be the canonical and ideally only Dockerfile needed for this repository. As such I believe we should use the "top level" Dockerfile naming.


54 quickstart first light

first shot at https://github.com/Code-and-Response/ClusterDuck-Protocol/issues/54
this adds

a debugprint to CDP itself (which is a souped-up version of what i used as part of the ghost packet hunt).
a example TelemetryDuck (which is basicly just a zero-setup mama that quacks about how it feels every minute or so)
a minimal "no modules required" perl script that reads from a serial port and parses the LORA packets it sees.

so the minimal-quickstart setup for getting some quacks is

flash two or more heltecs with the telemetryduck sketch
keep one of them attached to a computer running the duckster.pl script
watch them quacking... done.

the script is perl, which is not ideal, but in general installed on anything that is vaguely unixoid from raspi to mac.
it currently does not require any additional modules to be installed.
adding more outputs (like a dms-lite compatible sqlite writer) is trivial though.

just added the optional sqlite payload.
to use: perl duckster.pl -i /dev/ttyUSB27 -s /path/to/data.db
(compatibility with the dms-lite web-app not actualy tested, but since the sql statements and strftime format are cut-n-paste from sqlwriter.py i am somewhat optimistic on that part. ;)

closing this, will file a new one with the parts that should actualy go into CDP.


Convert pair to tuple about ttlProps

What is the purpose of this PR?  In general, std::pair faster than std::tuple.

What is the purpose of this PR? In general, std::pair faster than std::tuple.

the nested structure std::pair<key, std::pair<>> is really faster than a flat structure？I don't know. But it's strange so I fix it.

What is the purpose of this PR? In general, std::pair faster than std::tuple.

the nested structure std::pair<key, std::pair<>> is really faster than a flat structure？I don't know. But it's strange so I fix it.

Emm, when the pair.first is false, the pair.second can be empty.

What is the purpose of this PR? In general, std::pair faster than std::tuple.

the nested structure std::pair<key, std::pair<>> is really faster than a flat structure？I don't know. But it's strange so I fix it.

Emm, when the pair.first is false, the pair.second can be empty.

non existent although !(duration <= 0 || col.empty()) is false,

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature Requests: Allow setting text color as rainbow / set text a number of times

Hello.
Recently bought an Ulanzi clock and glad to have EsphoMaTrix working on it.
While using awtrix, there are 2 things which I REALLY miss in EsphoMaTrix (and which I think that fits in its different purpose compared to awtrix), which is to:

allow to set text color as a rainbow, to allow the color to be set random and changing while the text is being displayed
allow to set a text to show on display only a specified number of times.

Would this be something potentially implementable in the future?
Thanks in advance.

You can get similar results with the color-actions
So i think, this does not belong to the component, instead you can do it yourself with epshome in your yaml.

You can get similar results with the color-actions

Fair enough, I'll consider that option.

allow to set a text to show on display only a specified number of times.

What about this? It would be useful, wouldn't it?

Hi, the "number of times" to display is a problem. Think of only one screen in the queue. If you then specify 2 times its gone after some seconds. So i think the duration is the best way to limit the display time.
For your color idea i tried this:
time:
  - platform: homeassistant
    on_time:
      # Every 5 minutes
      - seconds: /1
        then:
         # logger.log: Hallo
         lambda: |-
          id(rgb8x32)->set_text_color(rand() % 255, rand() % 255, rand() % 255);
          id(rgb8x32)->set_clock_color(rand() % 255, rand() % 255, rand() % 255);

it changes the color randomly each seconds.

hello, I just tested the color change, works fine, but it's a pity that he also takes the message in that color with him, is it possible to have this only on the clock?

@lubeda is this possible what i ask above?

From the above sample:
this line changes the text color on each tick
          id(rgb8x32)->set_text_color(rand() % 255, rand() % 255, rand() % 255);
this line changes the clock color on each tick
          id(rgb8x32)->set_clock_color(rand() % 255, rand() % 255, rand() % 255);
in the upcoming 2023.3.4
there are some other possibilities for the clock color:
this changes the clock color for a whole "show_screen" intervall.
ehmtx:
  ....
  on_next_clock:
    lambda: |-
      id(rgb8x32)->set_clock_color(rand() % 255, rand() % 255, rand() % 255);
      id(rgb8x32)->set_weekday_color(rand() % 255, rand() % 255, rand() % 255);
      id(rgb8x32)->set_today_color(rand() % 255, rand() % 255, rand() % 255);

For a rainbox like color change you have to create a lambda on your own, but the possibilies are there!

hello this works very nicely now i have it in my cofig like this
time:
  - platform: homeassistant
    on_time:
      # Every 1 second
      - seconds: /1
        then:
         # logger.log: Hallo
         lambda: |-
          id(rgb8x32)->set_clock_color(rand() % 255, rand() % 255, rand() % 255);
          id(rgb8x32)->set_weekday_color(rand() % 255, rand() % 255, rand() % 255);
          id(rgb8x32)->set_today_color(rand() % 255, rand() % 255, rand() % 255);


How to create thumbnail for image pulled from file_picker package

Hello,
Thank you for your package. I was wondering how we can display an image that is of the "File" type retrieved from using the file_picker package.
I see in your example that we can only do asset images, is this correct?
My images are accessed this way:
return Image.file(
	File(_productsPictures[index].path!),
	fit: BoxFit.cover,
);

Hello,
this should not be problem. In example we are using asset images just for simplicity.  Plugin works with data returned from "dataResolver" function. How will you implement is up to you. You just have to return Uint8List.
Just a quick example I wrote top of my head without testing. Take with a grain of salt. It may need a few adjustements but should show you general direction.
Thumbnail(
    dataResolver: () async {
           return File(_productsPictures[index].path!).readAsBytesSync();
    },
    mimeType: 'image/jpg',
    decoration: WidgetDecoration(
        wrapperBgColor: Colors.deepOrange,
        wrapperSize: 110,
    ),
    widgetSize: 100,
),

Ok thank you very much. Will test and revert back.

not working on web


Add quota limits for push command

Motivation:
Central Dogma is a read centric application which means
heavy writes could be a risk to the reliabilty of the system.
By limiting write requests, Central Dogma is able to respond flexibly to burst traffic.
Modifications:

Add QuotaConfig to CentralDogmaConfig for a global configration"writeQuotaPerRepository": {
  "requestQuota" : 10,
  "timeWindowSeconds": 1
}

Add QuotaConfig to RepositoryMetadata for a repoistory level configration
Use Guava's RateLimiter to limit requests for a standalone mode
Use InterProcessSemaphoreV2 to limit requests for a replication mode
Add a write qouta REST API to MetadataService

PATCH /metadata/{projectName}/repos/{repoName}/quota/write

Refactor test code to build Zookeeper cluster easily

Result:

You can now set API quotas to push requests for repositories.
Fixes #528

Could you also check the test failure?
https://travis-ci.com/github/line/centraldogma/builds/203727256#L912

Could you also check the test failure?
travis-ci.com/github/line/centraldogma/builds/203727256#L912

Oops...

the average QPS was 7~8 per repository.
This QPS test was executed including this lease mechanism, right?
Then, 200ms will be fine I guess. 😄

Yes. the benchmark code included quota limitation.

https://travis-ci.com/github/line/centraldogma/builds/206964876#L716
Is this related? 🤔

travis-ci.com/github/line/centraldogma/builds/206964876#L716
Is this related? 🤔

Hmm... I'm not sure, let me check it more.

BTW, how about adding a metric to get to know how frequently TooManyRequestException happens?

Can't we use Armeria's request metrics with status?

Great job, @ikhoon! Thanks a lot for working on this. 😄

Thanks for reviewing! 🙇♂

https://travis-ci.com/github/line/centraldogma/builds/207208682#L703
Could you check this NPE?

travis-ci.com/github/line/centraldogma/builds/207208682#L703
Could you check this NPE?

Oops... I missed this message. 😅

🎉 🎉 🎉

Thanks for reviewing!


Remove Redundant Netty Definition

5.4.x: https://github.com/confluentinc/common/blob/5.4.x/pom.xml#L83
5.5.x: https://github.com/confluentinc/common/blob/5.5.x/pom.xml#L84
6.0.x: https://github.com/confluentinc/common/blob/6.0.x/pom.xml#L88
6.1.x: https://github.com/confluentinc/common/blob/6.1.x/pom.xml#L88
6.2.x: https://github.com/confluentinc/common/blob/6.2.x/pom.xml#L88
7.0.x: https://github.com/confluentinc/common/blob/7.0.x/pom.xml#L88
7.1.x: https://github.com/confluentinc/common/blob/7.1.x/pom.xml#L89
master:https://github.com/confluentinc/common/blob/master/pom.xml#L89

Its version has already been defined in common, which is parent for rest-utils. This will save future work on fixing netty versions.

The only failure on ksql 5.4.x is spotbugs-maven-plugin. It is safe for merge.


Improve sampler documentation, use doctest

Description
Documentation improvement.
Type of change

[ ] Bug fix
[ ] New Tutorial
[x] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[x] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

Thanks @guillaumekln for fixing it. LGTM. Waiting for any additional inputs from @qlzh727


SLS: respect PutLogs schema

This PR updates the data structure for the SLS PutLogs API to align with the official API docs and includes test cases for validation.
While the API schema was recently added to the documentation, we are not building directly on it due to the following reasons:

The schema’s data compression options are incomplete, supporting only lz4, which is not functional. More importantly, I prefer not to implement a workaround.
Log data needs to be encoded in Protobuf before being appended to the HTTP request body. Currently, we lack a mechanism to handle this encoding, so we will monitor the situation to see if additional APIs require similar data mutation handling.

Closes #55.


remove redef

Addresses: https://github.com/Netflix/dynomite/issues/363 and some further cleanup.

LGTM


Fix sort in case of different numeric field types between indices

Description
There was a regression after merging #6424. Basically, we lost ability to merge different numeric types sort results.
i.e. if Index-1 has field mapping Int, but Index-2 has field mapping Long, earlier it was supported to sort across these two indices. That's the exact problem we tried to solve in #6424, but that worked only on single node cluster. For multi node clusters, since SortedNumericSortField is getting serialized as SortField only, while merging results from different shards, we are not able to determine correctly if wider numeric type should be applied or not.
This PR ixes that.
This issue is caught by @reta while adding integ tests for this scenario #6901 . Huge thanks to reta for it.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

skipChangeLog label is neede here.

Codecov Report

Merging #6926 (da465fa) into main (2e3f950) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6926      +/-   ##
============================================
- Coverage     70.84%   70.66%   -0.18%
+ Complexity    59299    59217      -82
============================================
  Files          4812     4812
  Lines        283763   283764       +1
  Branches      40916    40917       +1
============================================
- Hits         201025   200526     -499
- Misses        66163    66724     +561
+ Partials      16575    16514      -61

Impacted Files
Coverage Δ

...pensearch/action/search/SearchPhaseController.java
85.71% <100.00%> (+3.32%)
:arrow_up:

...earch/search/sort/SortedWiderNumericSortField.java
43.75% <100.00%> (+12.98%)
:arrow_up:

... and 502 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize LGTM?


Checksums are out of date for calico, etcd, weave, breaking uploads.yml playbook

Environment:

Cloud provider or hardware configuration: CentOS 7.3.1611

OS: Linux 3.10.0-514.26.2.el7.x86_64 x86_64

Version of Ansible: ansible <IP_ADDRESS>

Kubespray version (commit): 80a7ae9
Command used to invoke ansible: ansible-playbook uploads.yml --extra-vars '{download: {enabled: true, container: true, sha256: true}, download_localhost: true }'
Output of ansible run: https://gist.github.com/sampowers/8294ec0694676b9fee6ed9e57795753a

I wanted to use the uploads playbook as a way to mirror some of the base binaries and containers to a local server, because our production clusters cannot pull artifacts from the public internet at runtime.  But some of the checksums were out of date.


When leaving Holy Mountain, special effects will be triggered, but it will not cause stones to fall

intentional

oh


Minimum investment quantity (INVESTMENT.BASE.MIN) must be a positive number

I am trying to run this on a google cloud but I keep getting this error.
I am running this on a windows and it is running no problem but on a ubuntu 20.04 LTS seems to be coming up with this
WARNING! Order execution is enabled!
Checking configuration ...
/home/-/bot/src/main/Validation.js:38
                throw new Error(msg);
                ^
Error: Minimum investment quantity (INVESTMENT.BASE.MIN) must be a positive number
    at Object.keys.forEach.BASE (/home/-/bot/src/main/Validation.js:38:23)
    at Array.forEach (<anonymous>)
    at Object.configuration (/home/-/bot/src/main/Validation.js:19:40)
    at Object.<anonymous> (/home/-/bot/src/main/Main.js:26:12)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node src/main/Main.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/-/.npm/_logs/2021-07-03T15_19_36_699Z-debug.log

"INVESTMENT": {         "BASE": "USDT",         "MIN": 15,         "MAX": 50,         "STEP": 0.005     },

Please review the config readme file for usage of configuration. It appears you are using an outdated config format

Your a gem!! I was racking my brain what the issue was xD


SAM problem - v0.5.0

I have this kind of error with samtools :
[bam_header_read] EOF marker is absent. The input is probably truncated. [bam_header_read] invalid BAM binary header (this is not a BAM file). Erreur de segmentation (core dumped)
I try with an another tool for quality report of the SAM who give me only the 3 first line of the SAM.
Maybe you have a problem with your SAM file generator.
I am at your disposition for complementary information.

Resolved.

Hi,
I'm wondering how you resolved the issue? :-)
Best regards,
Ivan.

I just miss a line command in my script.


How can I change the port defined in DWX_ZeroMQ_Connector()

class DWX_ZeroMQ_Connector():
"""
Setup ZeroMQ -> MetaTrader Connector
"""
def __init__(self,
             _ClientID='dwx-zeromq',    # Unique ID for this client
             _host='localhost',         # Host to connect to
             _protocol='tcp',           # Connection protocol
             _PUSH_PORT=32778,          # Port for Sending commands
             _PULL_PORT=32779,          # Port for Receiving responses
             _SUB_PORT=32771,           # Port for Subscribing for prices
             _delimiter=';',
             _pulldata_handlers = [],   # Handlers to process data received through PULL port.
             _subdata_handlers = [],    # Handlers to process data received through SUB port.
             _verbose=True,             # String delimiter
             _poll_timeout=1000,        # ZMQ Poller Timeout (ms)
             _sleep_delay=0.001,        # 1 ms for time.sleep()
             _monitor=False):           # Experimental ZeroMQ Socket Monitoring

In class DWX_ZeroMQ_Connector(), can we change the _PUSH_PORT = 32778 to 32768?

Hi,
It should work if you also change the port number in the parameters of the MT4 EA so that both are referring to the same ports.

May I ask what the port number range I can use? a random number? like32555?

Hi,
It should work if you also change the port number in the parameters of the MT4 EA so that both are referring to the same ports.

May I ask what the port number range I can use? a random number? like32555?

You can use netstat -ab in windows powershell to see used ports. Most ports above 10,000 should be fine.

You can use netstat -ab in windows powershell to see used ports. Most ports above 10,000 should be fine.


Question on the backbone

Hi All,
Thanks for the wonderful work!
I just wanted to confirm one thing. Are the results (Table 1) shown based on when the ViT backbone is frozen throughout the training? And only the subsequent slot decoders are updated?
Thanks!

Hi,
thanks for the question! Yes, you are correct. In all experiments in the paper, the ViT remains frozen during training.
Let us know if you have more questions.


Label bubbles in chat panel

@ewoo suggested adding the Agent name to the agent's responses and You to what you type in the chat panel.
@broham89 we need some HTML/CSS.

Here's a sample:
https://cl.ly/1T0q1X1Q2j1B

@broham89 did you see this one too?

nlu-styles.zip
@dcalvom
I've added these:

index.html line 71 - 90
scss/components/_chat-bubble.scss

Closed by https://github.com/samtecspg/articulate/commit/dbfe745b5f4f70822af26ef50e870dbb3cc93740


Model overfitting when training with new data on pre-trained model

I am using darknet53 as the pre-trained model and I want to adapt it to work on our data, without losing its ability to segment properly the KITTI dataset. My data is also in the format of 64x2048 and the parameters for the training have not changed. I only reduced the batch size to fit the model in my GPU.
Even though the amount of new data that I provide is significantly smaller than the KITTI dataset, the model directly overfits on the new data. While training, its training accuracy my reach even 99%. As for the validation set, I am using one sequence of my data and one sequence of KITTI and the validation accuracy is around 25%, while the predictions show that the segmentation works better for the new data and not on KITTI.
How is this normal, even though that the nea data is only around 1/40 of LiDAR frames to the initial dataset? Are there any parameters affecting this?

Sorry, for the late reply. Just to understand your setup:
You train on SemanticKITTI and then you switch to your new data? Then the approach overfits on new data?
In general, my experience with fine-tuning: With a high learning rate, you will quickly lose the already learned representation. It is generally better to reduce the learning rate.
However, you will also see that the method will not handle well different sensor configurations. Training on one configuration does not transfer well to other sensor configurations. (Even though you are using the same number of beams.) This has something to do that the distribution of the LiDAR points changes and also the resulting range image. (Which is also a reason why people are interested in domain adaption or transfer for LiDAR data).

I am using the pre-trained model that you provide and then I train on my own data. Then, yes it overfits.
After some trials, I realized that the main issue was that my own data is really different than the KITTI data, due to the tilted sensor placement on the robot. If I un-tilt the data, even the pre-trained model works much better. So, I think that when the new data is totally different, it's normal to overfit in these and forget about the old data that it knew.
Right now, I am training on the downsampled KITTI dataset and my own data (un-tilted) together and the validation accuracy looks good until now.

Thanks for your insight on the problem. Does this resolve your issue?

Yes, I'm closing this issue!
Thank you @jbehley


Retroactive User Recognition at scale without redis

Problem
According to docs the current implementation stores all anonymous events in Redis
This has two significant downsides:

A single point of failure ( One redis writer has a limit of how much traffic it can handle )
huge ram cost

As you pointed out in the documentation:
REDIS RAM = 1 Event Size * Events per month

1 event ~= 2 Kbyte
10 000 000 events per month ~= 20GB RAM per month

10M events / month is really not that much.
its ~ 231 events per minute or 3.4 events per second.
Large scale tracking load is mesured in thousends of events per second.
At this point redis ram consumption will explode.
Solution
Implement Retroactive User Recognition is a background task, no need to store those events in a hot cache like redis.
Instead they can be stored in any cloud storage as files ( under a path containing the user anonymous id )
This solves the ram consumption problem.
And once a user is identified
a background process can update the records according with the identified user.
In this scenario redis will only contain the coordinating info ( and can be updated asyncronuesly )

The whole user recognition flow relies on the fact that we could pull user by anonymous_id relatively quickly. Besides redis following storages will work:

S3. Unlike regular file system, they can handle dirs with unlimited files
LevelDB (or similar)

Here are the caveats:

I'm not sure we can write to S3 in real-time
With any local DB, we need to deal with sharding/merging. If LB is sitting between user and Jitsu, events of same user might be coming to different machines

I believe that the best way to deal with that would be a) sending data to S3 with Jitsu b) writing a Spark job that processes the data and sends the updated events to Jitsu. The real-time aspect of Jitsu will be lost, but anyway it will do a better job comparing to writing an in-house merger

@vklimontovich
With a db Like clickhouse that does not support UPDATE queries I see your Point.
But with a db like redshift or snowflake this can be achieved by only storing anonymous user ids in redis.
And on user recognition:

finish loading all anonymous user events
run an update statement

Or do I miss something ?
I Believe that retroactive user recognition is inherently something that should not be real time
"retroactive" -> after the fact
That's my intuition.

It's time to revisit this given a new architecture of Jitsu Next and the fact that we use Mongo as an underlying storage for user recognition. Here's a preliminary design:

We still should use Mongo as Identity Graph store, and maybe list of <message id, timestamp>, but not whole event
Once match has been found, user-recognition function should send a specially formated event that instructs Bulker to update certain fields in a table
Bulker should support update operation by a certain criteria ob by a set of messages

We should think through design in details, generally speaking it's easy to do if the database allows to pull events by id


[Bug]: Session id should change post login

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Instead of generating and setting a new session id post login, we end up re-using the same session id. This behaviour should change.
Steps To Reproduce

Note the session id before login
Log into appsmith
Note the session id post login.

They match today.
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
All instances

@trishaanand Tried the same steps listed above but couldn't able to reproduce the issue. Few scenarios I tried to reproduce:
Scenario1:

Open app.appsmith.com and note session id from cookie (No active session)
Sign in and check if the session id is altered for the subsequent request header => Success

Scenario2:

Signup as a new user on app.appsmith.com
Note session id and Sign-out
Sign-in again in same browser check if the session ID is altered => Success

Scenario2:

Use the same user created in above scenario to test the flows for old users
Signin in existing browser to refresh the session id
Signin into another browser with same creds
Verify if the session id altered before and after the login => Success
Also check if session ids are different on separate browser => Success
Signout and signing again from second browser to check if the session id is refreshed => Success

This is a false alarm as the customer was trying to match SessionId from Cookie with X-MDC-SessionId. X-MDC-SessionId is not used in auth flows and only passed in request header for contextual logging. Closing this now as this is not a security concern.
Ref: https://github.com/appsmithorg/appsmith/blob/7b9b63ba0b6040da3d17c8a35260689b57706380/app/server/appsmith-server/src/main/java/com/appsmith/server/filters/MDCFilter.java#L67


Add CI job to detect possible problematic usage of trap

see for example this change:
https://github.com/osbuild/osbuild-composer/pull/3681/commits/13a3ca24ceef05164a77db1c71b929e262098f41
This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

@thozza , @mvo5 , @jrusz should I continue further in this direction and adjust the offending test scripts or do we want a different solution ?

@thozza , @mvo5 , @jrusz should I continue further in this direction and adjust the offending test scripts or do we want a different solution ?

I'm not sure if it makes sense to run this as a GH action for every PR, since we are hitting the runner limits a lot recently. Nevertheless, the general idea of this check is good. Maybe it would be better to add this as a separate script to tools/ directory and/or to the Makefile as a target.
Fixing all the test scripts as part of this effort is IMO desired.

I'm not sure if it makes sense to run this as a GH action for every PR, since we are hitting the runner limits a lot recently.

I will rework this into a step in one of the existing CI jobs (Shellcheck), instead of creating a new one. That will not increase the number of separate jobs being executed in GitHub.

As a follow up we can stagger some of the jobs, e.g. shellcheck/lint first and then the rest of the tests. WDYT ?

LGTM.
I was just wondering, in some of the scripts there are two functions for cleanup like a regular cleanup and then cleanup_on_exit I assume that's because your intention is to keep current behavior and just take care of killing the journal the proper way with just one trap so you added a cleanup_on_exit function for that. Is my assumption correct?

Yes. See commit log for some more context.


Upload files for timed out sessions

Whenever session is deleted on timeout or client disconnect respective logs should be also uploaded \ saved.

Currently we already upload all files for timed out sessions. The only case where selenoidXXX.log files are remaining on the disk is when respective service was already created and client disconnects during session startup. In that case we don't yet know session ID and thus can't rename \ upload respective files.


[Bug]: When creating index on non-existent table, the core dumped.

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
4f2170ff
Other environment information
No response
Actual behavior
When creating index on non-existent table, the core dumped. Related issue link #605 .
[18:34:01.889] [1416041] [critical] Error: SEGMENT FAULTS
[18:34:01.889] [1416041] [critical] 0, ./build/src/infinity(+0x504aa9) [0x5604af844aa9]
[18:34:01.889] [1416041] [critical] 1, ./build/src/infinity(+0x1051b1) [0x5604af4451b1]
[18:34:01.889] [1416041] [critical] 2, /lib/x86_64-linux-gnu/libc.so.6(+0x42990) [0x7fc3ef842990]
[18:34:01.889] [1416041] [critical] 3, ./build/src/infinity(+0x21b3ce) [0x5604af55b3ce]
[18:34:01.889] [1416041] [critical] 4, ./build/src/infinity(+0x1da66d) [0x5604af51a66d]
[18:34:01.889] [1416041] [critical] 5, ./build/src/infinity(+0x18332e) [0x5604af4c332e]
[18:34:01.889] [1416041] [critical] 6, ./build/src/infinity(+0x177a66) [0x5604af4b7a66]
[18:34:01.889] [1416041] [critical] 7, ./build/src/infinity(+0x191abd) [0x5604af4d1abd]
[18:34:01.889] [1416041] [critical] 8, ./build/src/infinity(+0x829716) [0x5604afb69716]
[18:34:01.889] [1416041] [critical] 9, ./build/src/infinity(+0x818a24) [0x5604afb58a24]
[18:34:01.889] [1416041] [critical] 10, ./build/src/infinity(+0x817d3a) [0x5604afb57d3a]
[18:34:01.889] [1416041] [critical] 11, ./build/src/infinity(+0x823f3b) [0x5604afb63f3b]
[18:34:01.889] [1416041] [critical] 12, ./build/src/infinity(+0x823dc5) [0x5604afb63dc5]
[18:34:01.889] [1416041] [critical] 13, ./build/src/infinity(+0xcf6b33) [0x5604b0036b33]
[18:34:01.889] [1416041] [critical] 14, /lib/x86_64-linux-gnu/libc.so.6(+0x97b5a) [0x7fc3ef897b5a]
[18:34:01.889] [1416041] [critical] 15, /lib/x86_64-linux-gnu/libc.so.6(+0x1285fc) [0x7fc3ef9285fc]
terminate called without an active exception
Aborted (core dumped)

Expected behavior
No response
Steps to reproduce
Function test case can be found in python/test/test_index.py `test_create_index_on_dropped_table`

Additional information
No response

It seems create non-existent table won't lead to core dump. But creating index on non-existent column or data type not supported column will introduce core dump. You may double check the test cases.


(PUP-3077) Handle cached catalog inconsistencies

Previously, it was possible to run an agent in noop mode in a canary environment, but during the next normal agent run, it could fall back to the previously cached catalog from the noop run, causing changes to be deployed into production there were never meant to be.
The short version for this PR is: Don't save cached catalogs when running in noop mode and only fallback to a cached catalog whose environment matches the agent's configured environment, either through the ENC or agent-specified environment.

I'll resolve conflicts

$ bundle exec puppet agent -t --environment dev
Info: Using configured environment 'dev'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Caching catalog for <host>
Info: Applying configuration version '1454529937'
Notice: Applied catalog in 0.01 seconds
$ cat  ~/.puppetlabs/opt/puppet/cache/client_data/catalog/<host> | jq .environment
"dev"
$ bundle exec puppet agent -t --environment production
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Caching catalog for <host>
Info: Applying configuration version '1454529949'
Notice: Applied catalog in 0.02 seconds
$ cat  ~/.puppetlabs/opt/puppet/cache/client_data/catalog/<host> | jq .environment
"production"
$ bundle exec puppet agent -t --environment dev --noop
Info: Using configured environment 'dev'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Applying configuration version '1454529962'
Notice: Applied catalog in 0.02 seconds
$ cat  ~/.puppetlabs/opt/puppet/cache/client_data/catalog/<host> | jq .environment
"production"

:+1: verified that noop runs don't result in a new cached catalog and that if the catalog fails to compile on a noop run, we never fall back to using a cached catalog.
Also verified that cached_catalog_status is set correctly in each of the three cases (not used, explicitly requested, and on failure). Checked that the status is not set to on_failure if the cached catalog is not used.


Cannot create a new service when another one already exists

I previously followed along with the quick start and ended up with a music service.
I decided to then change all the application files to test out my own data set and got this error when trying to deploy:
Invalid application package: default.default: Error loading model: content-cluster-removal: Content cluster 'music' is removed. This will cause loss of all data in this cluster
I then found this information: https://docs.vespa.ai/documentation/reference/vespa-cmdline-tools.html
That talks about vespa-remove-index, which I then used to remove the music index. Unfortunately it only removed the index on one the particular node it was run from, so I had to docker exec into each individual node's container and remove the index. That was quite a bit of work so I'm assuming there's a better way to do that?
Though, perhaps it wasn't even the correct thing to do since I still get the same error when trying to deploy my new package.
I then read through this information: https://docs.vespa.ai/documentation/operations/admin-procedures.html

Add or remove services on a node
If changing the services on a given host, stop Vespa on the given host before running vespa-deploy activate.

So I ran /opt/vespa/bin/vespa-stop-services and tried again to deploy my new application.
Again, the same error.
I must be completely missing something here.
Sure, I could wipe the docker volumes and start again from scratch, but this is pretty basic admin stuff here that I need to get sorted out before I ever put this thing into production.

This is exactly what you want to prevent disasters in production. http://docs.vespa.ai/documentation/reference/validation-overrides.html

In my opinion,It was caused for the reason that one node only can be allocated to one application,maybe you need to delete the application you deployed on the past before you deploy a new one:
DELETE /application/v2/tenant/[tenant name]/application/[application name]
Then vespa-stop-services-->vespa-start-services-->deploy the new application
I did it like above, I succeeded. I don't know it's right or wrong.So, @jobergum  how can I completely delete an application I ever deployed and which is now running?

The invalid application package deploy error can be workaround by adding a validation override as described in http://docs.vespa.ai/documentation/reference/validation-overrides.html. This is a mechanism to prevent removing a content cluster from a production cluster.
If you want to wipe all state from a playground type of installation you can wipe configuration server state on all configuration server instances by

vespa-configserver-remove-state described in http://docs.vespa.ai/documentation/cloudconfig/configuration-server.html. Run on all configuration instances
Wipe content node state by the vespa-remove-index utility described https://docs.vespa.ai/documentation/reference/vespa-cmdline-tools.html. Run on all content node instances.

On the documentation format and navigation, I agree that it's not super easy to navigate. Contributions on this would be appreciated. The 404 for the reference we could fix by adding a new toc through a index file but the left pane navigation issue would still be the same.
We try to add and update documentation as we get feedback, e.g we just added documentation on docker swarm based on recent feedback on multi-node docker installation issues.
https://github.com/vespa-engine/sample-apps/tree/master/basic-search-on-docker-swarm

It's not just the finding of this page, since I didn't even know I should be looking for such a concept. It might be worth mentioning somewhere in the first several introductory documents that the database has this protection mechanism and that there is a way to override it.

Contributions on this would be appreciated.

Probably a lot of people (myself included) would be happy to contribute eventually but we have to actually understand how things work first. I actually much prefer your documentation to most other databases I've used in the past. Everything is (or at least seems to be) reachable from the one docs page, and there is only one docs page. I know this is a new open source project and the community is small. I really like the ideas and experience that have gone into this database and I want to support it.

We try to add and update documentation as we get feedback, e.g we just added documentation on docker swarm based on recent feedback on multi-node docker installation issues.

Yes, your team is very responsive. Often feedback on open source projects is met with defensiveness, which discourages further feedback. I feel that even though your primary responsibility is to keep it working well for Yahoo, your team also genuinely wants to make this open source project work.

Good point about changing applications during development. I added section on that to the intro doc on application packages. It actually mentions validation-overrides already, but only in passing. https://github.com/vespa-engine/documentation/pull/285
Regarding having all the doc pages in the toc: We tend to go back and forth on that issue. A complete toc make it so long that it loses the property of providing an overview. On the other hand if we leave something out we have this issue.

Regarding having all the doc pages in the toc: We tend to go back and forth on that issue. A complete toc make it so long that it loses the property of providing an overview. On the other hand if we leave something out we have this issue.

Yes, it's already too long as it is. May I suggest using collapsible menu headers? You already have the headers there. Use them as toggles. It would immediately be easier to navigate plus you would be able to add more links to useful information.
The only downside I can think of is you would no longer be able to ctrl + f to find the topic you're looking for, but that can easily be fixed by adding an Expand All toggle up top.


Search show only published

Currently user created measures and quotas can be found before they have been published. This could potentially cause issues as a second user could build upon a measure/quota that has not yet been validated by HMRC and which could cause conflicts upon correction.
This PR addresses this issue by only allowing measures/quotas that have been published to be searchable.
Note: This PR deletes functionality and testing around searching by status because we will now only show published measures/quotas.

Lovely, nice clean up as well!


Get this error when starting

Are you running the latest version of totsugeki?

Had the same issue when I was running an old version of totsugeki. Works fine with the latest version for me.

Gonna close this out. This error shouldn't be possible on any of the recent versions of Totsugeki.


replaced ifs in AddConfigInput with switch

gotta merge base first tho

You can merge it now. Your other PR isn't too large.  This is just the boy scout rule: leave the place a little nicer than when you arrived. It's only an issue when the PR is already enormous ;-)


[TypeOrm] Having problems with One To Many relationship

Hello everyone !
Currently I am building an admin page based on adminjs platform. I'm using Typeorm and am having a One To Many relationship problem.
I have followed the instructions for One To Many relationship exactly, but the result is not showing in the UI. In contrast, the Many To One relationship displays very accurately. Currently, the One To Many relationship is not supported, right?

I have indeed the same issue

@thanhlm93 According to the documentation, only ManyToOne is currently supported. So, you seem to be right 👍.


redpanda: add rpk.additional_start_flags to values

There are occasions where extra command line arguments might be needed by rpk when starting redpanda. Add a value and use that value in the configmap template to add additional_start_flags to the rpk key.

duplicate of https://github.com/redpanda-data/helm-charts/issues/394


fix links to google group

had to escape the # in url to make it actually work.
/kind documentation

/ok-to-test

/kind documentation

thank you @maxandersen
/approve
/lgtm


Fixes #1079 Added new user:change-password command

1. Why is this change necessary?
This adds a new user:change-password command to change an admin users password.
2. What does this change do, exactly?
It adds the command.
3. Describe each step to reproduce the issue or behaviour.
A password can be changed using bin/console user:change-password username.
4. Please link to the relevant issues (if any).
#1079
5. Checklist

[X] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9472
Please use this issue to track the state of your pull request.

Thanks for this PR! I can see me using this soon :)


Fix notification issues

Disabled 'new' notifications
Disabled 'autograded' notifications
Fix 500 internal server error when students betcha assessments due to not belonging to group

Pull Request Test Coverage Report for Build 2633

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 91.865%

Totals

Change from base Build 2624:
-0.01%

Covered Lines:
1005

Relevant Lines:
1094

💛  - Coveralls


[Feature Request] Add tiled VAE and option to disable K/V cache

I guess GGUF is the real solution, but you should add a tiled VAE retry, like in the default VAE decoder of Comfy_UI. BTW: Can you just decouple the VAE decode and take advantage of the automatic tiled VAE? Is really annoying to waste 10 minutes to get a fail at the end because the VAE decode didn't have enough memory.
Another think that can help: https://github.com/chflame163/ComfyUI_OmniGen_Wrapper
Adds an option to disable the K/V cache, it is slower, but reduces the VRAM needed.

Currently, this model utilizes the SDXL VAE, and I'm unable to modify the underlying structure. Regarding the suggestion to disable the K/V cache, it’s worth noting that under low VRAM conditions, this model already operates slowly, and I'm not sure users would want to invest additional time for image generation.
However, if there’s significant interest in the option to disable the K/V cache, please let me know, and I’ll consider creating a branch for this feature. Your feedback is valuable!

Ok, I created a node with the VAE outside:
https://github.com/set-soft/ComfyUI_OmniGen_Nodes/