Possibly platform related tflite conversion issue

1. System information
(1) With issues in:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS Monterey 12.2.1 (m1)
TensorFlow installation (pip package or built from source):  following https://developer.apple.com/metal/tensorflow-plugin/
TensorFlow library (version, if pip package or github SHA, if built from source):

tensorflow-deps==2.8.0
tensorflow-graphics==2021.12.3
tensorflow-macos==2.8.0
tensorflow-metal==0.4.0

(2) Without issues in:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Arch Linux x86_64 (5.16.16-arch1-1)
TensorFlow installation (pip package or built from source):  pip
TensorFlow library (version, if pip package or github SHA, if built from source): 2.8.0

2. Code
Written to match this example as much as possible.
import os
os.environ['TF_CPP_MIN_LOG_LEVEL'] = '3'

import tensorflow as tf
from tensorflow_graphics.math.optimizer import levenberg_marquardt

def convert_to_tflite(
    model_path: str,
) -> bytes:
    converter = tf.lite.TFLiteConverter.from_saved_model(model_path)
    converter.optimizations = [tf.lite.Optimize.DEFAULT]
    converter.target_spec.supported_ops = [
        tf.lite.OpsSet.TFLITE_BUILTINS,  # enable TensorFlow Lite ops.
        tf.lite.OpsSet.SELECT_TF_OPS,  # enable TensorFlow ops.
    ]

    tflite_model = converter.convert()
    assert isinstance(tflite_model, bytes)

    return tflite_model

def tflite_inference(
    inputs: list[tf.Tensor],
    tflite_model: bytes,
) -> list:
    # create interpreter
    interpreter = tf.lite.Interpreter(model_content=tflite_model)
    interpreter.allocate_tensors()

    # set inputs
    input_details = interpreter.get_input_details()
    for input_tensor, input_placeholder in zip(inputs, input_details):
        interpreter.set_tensor(input_placeholder["index"], input_tensor)

    # invoke interpreter
    interpreter.invoke()

    # return outputs
    output_details = interpreter.get_output_details()
    return [interpreter.get_tensor(output["index"]) for output in output_details]

def create_lmo_model():
    def f1(x, y):
        return x + y

    def f2(x, y):
        return x * y

    class LMO(tf.keras.layers.Layer):
        def call(self, inputs):
            _, (r1, r2) = levenberg_marquardt.minimize(
                residuals=(f1, f2),
                variables=inputs,
                max_iterations=10,
            )
            return [r1, r2]

    input_x = tf.keras.Input(
        shape=(1, 2),
    )
    input_y = tf.keras.Input(
        shape=(3, 1),
    )
    output = LMO()([input_x, input_y])

    return tf.keras.Model(
        inputs=[input_x, input_y],
        outputs=output,
    )

def main():
    tf.random.set_seed(5)
    x = tf.random.uniform((1, 1, 2))
    y = tf.random.uniform((1, 3, 1))
    inputs = [x, y]

    model = create_lmo_model()
    print(model(inputs))

    tf.saved_model.save(
        model,
        "lmo_model",
    )

    tflite_model = convert_to_tflite("lmo_model")
    print(
        tflite_inference(
            tflite_model=tflite_model,
            inputs=inputs,
        )
    )

if __name__ == "__main__":
    main()

3. Failure after conversion
On platform 1 tflite interpreter fails to invoke with error:
RuntimeError: Input matrix is not invertible.
	 (while executing 'MatrixTriangularSolve' via Eager)Node number 15 (TfLiteFlexDelegate) failed to invoke.Node number 104 (IF) failed to invoke.Node number 10 (WHILE) failed to invoke.

On platform 2 everything works as expected.

Hi @sachinprasadhs ! Could you look at this issue? I modified the original code run in colab environment  . The issue is surfacing in 2nd inference (not in 1st inference). Attaching gist in 2.7, 2.8 and nightly. Thanks!

Hi @enaskopelja ,
I was able to resolve the issue by changing the order of inputs: gist
However this is not a guaranteed solution as the input ordering is not guaranteed either way after conversion and creating the interpreter, one can resolve this more generally by using input signatures and using names for your inputs. Please review the following documentation on how to add signatures: https://www.tensorflow.org/lite/guide/signatures
Once you have signatures for the model you can inspect the converted model's signature and map your inputs to the named inputs.
Let us know if you are satisfied with this solution.


[Hotfix Storybook] - Downgrade dependency that is causing issues

We have to downgrade @babel/preset-react cause it is causing issued transpiling for storybook and messing up with emotion css prop

took me a while to pinpoint what was causing this, had this issue before it is related to emotion css= prop in elements and the usage of @emotion/babel-preset-css-prop which was updated to latest here but still does not work

tried the next version to 7.0.0  (7.6.3) and that didnt work either so we need to lock to 7.0.0 https://www.npmjs.com/package/@babel/preset-react

tried some options passed to @babel/preset-react but didn't work in first attempts. May look into this in next cooldown or just analyze the migration to Storybookv6

I think it is best to release this fix now and start thinking on migrating to Storybook v6 which will fix all this old dependecies issues since it has more built integration and doesnt rely much on babel. See daylight which is in v6 I dont have to define a babel config file at all and TS integration is built in

@michaeljaltamirano ok here is more detail why I think we should keep this fix and the latest PR which incidentally was not only related to TS convert ProgressBar

the babel dependencies were not exactly ideal in the previous version, I think what we have now is more in sync (some were in 7.0 some in 7.1 some in 7.2)

The underlying issue updating @babel/preset-react to latest was a css prop issue But you can see in console right now in storybook prod that it says React is not defined. You can import React in preview.js like some pages says but then you see that css prop styles are not applied (you dont even get this an error you have to digg in the inspector). Then I tried to add the jsx pragma to preview.js at this point I knew this is just patch that solves nothing, You start realizing that you need the file as they were and try to fix elsewhere, thats when I detected it was dependecies thing.

The old PR needed to update babel and jest because there were some error when tryin to use this files as const. This syntax cannot be used with old dependecies

const PROGRESS_BAR_STATUS = {
  loading: 'loading',
  success: 'success',
  error: 'error',
} as const;

If we are rolling back, I would rather remove the as const syntax and revert all dependecies to what they were so the test can pass and we can release the version mantaining some refactor from old PR. But ultimately I dont think it matters much, also the babel-preset-css-prop upgrade was not necessary I just threw it in here in hope of fixing the bug because that is the preset that is not working because @babel/preset-react is doing something that the emotion preset cannot process or viceversa these 2 packages are clearly out of sync

@daigof I haven't dug into the internals of this as much as you have, but it looks like if we convert .storybook/preview.js to .storybook/preview.tsx, we fix the behavior. Can you double-check this is correct?

@michaeljaltamirano that has the same effect of adding import React from... you still have css prop issues in other pages like Checkbox

Which would be solvable by converting Checkbox story to TSX so on and so forth.
I propose 2 things: get this PR published or revert all package versions to what they were and remove as const syntax.
A third proposition would be convert now Checkbox story to TSX (or add the jsx pragma has the same effect) but I know even not noticeable there are css prop errors in all other pages. This has no effect to the library build.
Thanks to your finding it looks like converting all stories files to TSX would fix the issue with all latest babel packages, So taht can be a task for cooldown too.

@daigof I see. Thank you for pointing out that screenshot. My preference is to revert 6b295d67c3c4a53402c5fd5f7325cfb4a16c1e84 (#316) so that the repo is back in sync with the 10.3.0 release.

@michaeljaltamirano  Repo revert back to commit before merged PR. Closing this one and opening another ProgressBar PR that doesnt messup with dependecies


confusing documentation

I'm looking at the page at http://pylayers.github.io/pylayers/notebook/2-AP/Antenna.html
The text says, "An antenna object can not be loaded in specifying an existing antenna file name as argument of the constructor."  Do you mean "can" or "cannot" (no space)?  If you mean "cannot", this would appear to be immediately contradicted by the example that follows.

I was also confused by that sentence.


Real time search instead of highlighting

To search the activities page, admin must click the search button to highlight all occurrences of the word.

I think real time searching would give a better UX.

@llaske and @tarunsinghal92 What do you think ?!

The list of activities is very small. Plus, we choose to not have real time - for pagination reason - for other screens so I don't think we need this.


Unable to set mp_pose in my Apple Silicon Mac

MacOS Version
Sonoma 14.2.1
Software Version
python: 3.11.5
opencv-python  : 4.6.0
mediapip: 0.10.10

Problem
I am a newbie in computer vision and motion detector. I am building an motion detection app in Python and I have to set the pose using mediapipe
# Set up MediaPipe instance
mp_pose = mp.solutions.pose
pose = mp_pose.Pose(min_detection_confidence=0.5, min_tracking_confidence=0.5)

However, I got an error regarding initialising pose as below
RuntimeError                              Traceback (most recent call last)
Cell In[3], line 1
----> 1 pose = mp_pose.Pose(min_detection_confidence=0.5, min_tracking_confidence=0.5)

File /opt/homebrew/Caskroom/miniconda/base/lib/python3.11/site-packages/mediapipe/python/solutions/pose.py:146, in Pose.__init__(self, static_image_mode, model_complexity, smooth_landmarks, enable_segmentation, smooth_segmentation, min_detection_confidence, min_tracking_confidence)
    122 """Initializes a MediaPipe Pose object.
    123
    124 Args:
   (...)
    143     https://solutions.mediapipe.dev/pose#min_tracking_confidence.
    144 """
    145 _download_oss_pose_landmark_model(model_complexity)
--> 146 super().__init__(
    147     binary_graph_path=_BINARYPB_FILE_PATH,
    148     side_inputs={
    149         'model_complexity': model_complexity,
    150         'smooth_landmarks': smooth_landmarks and not static_image_mode,
    151         'enable_segmentation': enable_segmentation,
    152         'smooth_segmentation':
    153             smooth_segmentation and not static_image_mode,
    154         'use_prev_landmarks': not static_image_mode,
    155     },
    156     calculator_params={
    157         'posedetectioncpu__TensorsToDetectionsCalculator.min_score_thresh':
    158             min_detection_confidence,
    159         'poselandmarkbyroicpu__tensorstoposelandmarksandsegmentation__ThresholdingCalculator.threshold':
    160             min_tracking_confidence,
    161     },
    162     outputs=['pose_landmarks', 'pose_world_landmarks', 'segmentation_mask'])

File /opt/homebrew/Caskroom/miniconda/base/lib/python3.11/site-packages/mediapipe/python/solution_base.py:248, in SolutionBase.__init__(self, binary_graph_path, graph_config, calculator_params, graph_options, side_inputs, outputs, stream_type_hints)
    244 if graph_options:
    245   self._set_extension(canonical_graph_config_proto.graph_options,
    246                       graph_options)
--> 248 self._graph = calculator_graph.CalculatorGraph(
    249     graph_config=canonical_graph_config_proto)
    250 self._simulated_timestamp = 0
    251 self._graph_outputs = {}

RuntimeError: ValidatedGraphConfig Initialization failed.
ImageToTensorCalculator: ; RET_CHECK failure (mediapipe/calculators/tensor/image_to_tensor_calculator.cc:144) ValidateOptionOutputDims(options) returned INTERNAL: ; RET_CHECK failure (./mediapipe/calculators/tensor/image_to_tensor_utils.h:136) options.has_output_tensor_float_range() || options.has_output_tensor_int_range() || options.has_output_tensor_uint_range()Output tensor range is required.
InferenceCalculatorCpu: ; RET_CHECK failure (mediapipe/calculators/tensor/inference_calculator_cpu.cc:63) !options.model_path().empty() ^ kSideInModel(cc).IsConnected()Either model as side packet or model path in options is required.
SplitDetectionVectorCalculator: The number of output streams should match the number of ranges specified in the CalculatorOptions.
ImageToTensorCalculator: ; RET_CHECK failure (mediapipe/calculators/tensor/image_to_tensor_calculator.cc:144) ValidateOptionOutputDims(options) returned INTERNAL: ; RET_CHECK failure (./mediapipe/calculators/tensor/image_to_tensor_utils.h:136) options.has_output_tensor_float_range() || options.has_output_tensor_int_range() || options.has_output_tensor_uint_range()Output tensor range is required.
ConstantSidePacketCalculator: ; RET_CHECK failure (mediapipe/calculators/core/constant_side_packet_calculator.cc:64) (cc->OutputSidePackets().NumEntries(kPacketTag))==(options.packet_size())Number of output side packets has to be same as number of packets configured in options.
ConstantSidePacketCalculator: ; RET_CHECK failure (mediapipe/calculators/core/constant_side_packet_calculator.cc:64) (cc->OutputSidePackets().NumEntries(kPacketTag))==(options.packet_size())Number of output side packets has to be same as number of packets configured in options.
ConstantSidePacketCalculator: ; RET_CHECK failure (mediapipe/calculators/core/constant_side_packet_calculator.cc:64) (cc->OutputSidePackets().NumEntries(kPacketTag))==(options.packet_size())Number of output side packets has to be same as number of packets configured in options.
SplitTensorVectorCalculator: The number of output streams should match the number of ranges specified in the CalculatorOptions.
SplitNormalizedLandmarkListCalculator: The number of output streams should match the number of ranges specified in the CalculatorOptions.
SplitLandmarkListCalculator: The number of output streams should match the number of ranges specified in the CalculatorOptions.```

Hello @rickypang0219
From the code excerpt provided, it looks like you are using legacy/outdated version of mediapipe. We have released new MediaPipe Tasks APIs which are superset of the legacy version and much more stable. We will highly recommend you to use the newer APIs for pose landmarks since we have ended support for legacy solutions. Pose Landmarker documentation can be found here

@ayushgdev  Thank you for reminding me. You are right I am using legacy version of mediapipe as I am learning MediaPipe from Youtube tutorials uploaded several years ago.

Sure. Can we go ahead and close this issue ? If you encounter a new issue in new APIs, we would be happy to provide support for that. Just file a new issue with relevant details.


DEPS.xwalk: Roll v8-crosswalk (11bb7b4 -> 1a9e0ff).

1a9e0ff Merge pull request #76 from huningxin/xwalk-3371
044b02d [SIMD.js] Optimize Emscripten generated load and store API
f9f8dea Merge pull request #73 from huningxin/xwalk-3117
2fcc9f4 Merge pull request #74 from huningxin/xwalk-3116
964fd50 Merge pull request #75 from huningxin/xwalk-3370
34ba798 [SIMD.js] Add smi check in bounds check of SIMD load and store API
0633aa5 [SIMD.js] Implement swizzle and shuffle APIs
61c20fc [SIMD.js] Rename the shift operations to include "ByScalar"

To fix https://crosswalk-project.org/jira/browse/XWALK-3468 and https://crosswalk-project.org/jira/browse/XWALK-3469. @rakuco , please take a look. Thanks!

lgtm, can you please rebase? There's a merge conflict due to the other PR you sent rolling chromium-crosswalk.

Rebased. Please take another look. Thanks.


Include boundary points in subset_polygon

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes issue #99

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion minor has been called on this branch
[ ] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

Due to the difference in between rtree-based geopandas spatial operations and shapely's vectorized operations, create_mask is not producing the same results. @aulemahal identified that shapely was solely performing a grid-shape containing evaluation. This change introduces a second evaluation for shapes touching grid-points.

Does this PR introduce a breaking change?:

Yes, because the changes that were produced by switching the vectorized version introduced breaking changes. This should revert those changes.

Other information::

~This is presently untested. This should not be merged until tests establish that it is working.~ For more information, see: https://github.com/bird-house/finch/pull/133

I suggest we add a test here, instead of relying on external tests (finch).

I suggest we add a test here, instead of relying on external tests (finch).

Could we have a patch release after this merge?

Could we have a patch release after this merge?


Chrome-like focus recent recent editor after close

When I close my tabs, I'd like the behavior to be like in Chrome or Firefox. VSCode has a Focus Recent Editor After Close setting, but that behaves differently:

Chrome only remembers the most recent tab. After that, focus will move from left to right.
If you switch tabs, Chrome will not remember the last tab. Instead, focus moves from left to right.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


About "strength" in sd_ddim_pipeline function

Hello, I put a description about the parameter "strength" below. My understanding is that if we designate "strength = 0.0," it implies the denoising of a clean image. Conversely, by setting "strength = 1.0," it suggests denoising from pure noise. However, I observed that even when I varied this parameter as 0.1, 0.5, and 1.0 respectively, the resulting outputs were identical. I'm just wondering where I can generate an output image purely from noise. Thank you for your assistance!
https://github.com/ChenyangQiQi/FateZero/blob/08da87636f673dc5b0a130713a2f6ee4de872e44/video_diffusion/pipelines/p2p_ddim_spatial_temporal.py#L295-L300
https://github.com/ChenyangQiQi/FateZero/blob/08da87636f673dc5b0a130713a2f6ee4de872e44/video_diffusion/pipelines/p2p_ddim_spatial_temporal.py#L261-L281

If you want to generate the result from pure noise, you could modify the ddim inversion to pure noise  here. similar with original stable diffusion pipline.
If you have any question about the code, please let me know. I will try my best to help you.
remember to give us a star if you like our work.

@Jason-user Sorry that I do not implement the "SDEdit"-style code about the "strength" that you mentioned. Maybe this variable won't influence the result.
However, a simple equivalent way to modify the strength without modifying code is to use the "latent blending" feature. (https://github.com/ChenyangQiQi/FateZero/blob/36aff9366ced0e9c2c083e451ba8eb9ea8fd0aa5/config/teaser/jeep_posche_local_latent_blend.yaml#L38)
If you replace the latent in the "0.5T" timestep. The final image result is the same as the denoising strengh= 0.5.
I share some results of our ablation study.

But, if you want to save computation by smaller strengths, you may need to implement it by yourself.

@mayuelala @ChenyangQiQi Got it, thanks for you help!


Enable dbt run-operation

Hey,
I'd like to suggest adding support for the dbt run-operation command, that executes macros

Just saw that #68 does this. Any chances of a merge?


Don't fold short comments

It is silly to fold a single-line comment, as it doesn't shrink and just becomes unreadable. It would be nice to have the command not fold one-liners by default, and maybe allow an option in the preferences for minimum # of lines that a comment has to be in order to be folded.

Hi @madbarron
There is a configuration parameter you could override for not folding single line comments.
There is however some issues with "multi-line" single-line comments, i.e:
// a comment
// another comment
// all the comments

Sometimes being tagged by ST as a multi-line comment, and sometimes it's a single-line — seemingly depending on the scope.
Try the configuration parameter and get back to me. I'm also very open to PRs, the code should be fairly easy to figure out.

What is the configuration parameter I should use? I can't find anything about that.

@madbarron You should be able to see the specific configuration parameters by going to Preferences -> Package Settings -> Fold Comments -> Fold Comments Settings — User
Then you can either override those parameters, or change it in your User Setting file.

Ah, thanks! I wasn't aware of the package settings function of ST. That works pretty great for me.


High resolution scenes get cropped when saving to PNG

I'm not sure if this is a bug, but it's something I need to find a workaround for. I posted to discourse here but so far no responses.
Slight modification of the line demo in the docs to save to a high resolution PNG:
using Makie

x = range(0, stop = 2pi, length = 40)
f(x) = sin.(x)
y = f(x)
scene = lines(x, y, color = :blue; resolution=(5000,3000));
Makie.save("out.png", scene)

The resulting PNG is cropped to 3844x2124 (roughly my screen resolution) and shows just the lower left of the full scene. If I display the scene in a window I get the full scene rescaled to my screen resolution. Same result in 0.9.5 and master.
If this is a bug, can you suggest a workaround for how I can save scenes (actually produced using GeoMakie) to an image at very high resolution?

On what os is this?

Forgot to mention, sorry. Windows 10, Julia 1.3.1.

Can't reproduce on linux + REPL...Where are you executing this?

I've tried this example in the REPL and similar GeoMakie code inside a project of mine, same result.

Hm, I can test later on windows

OK, thanks. I just confirmed that saving large PNGs using Images.jl works fine, so the problem does appear to be in the Makie/Plotting ecosystem somewhere.
using Images
img = Gray.(rand(5000,3000))
save("gray.png", img)

can reproduce this on windows... Will try to take a look later!

https://discourse.glfw.org/t/can-i-create-a-window-larger-than-the-monitor-resolution/951/2
Hm, seems like the window manager is allowed to overwrite this... I'll need to figure out how the answer can be applied in Makie...

Try: https://github.com/JuliaPlots/GLMakie.jl/pull/70

Thanks for the quick bugfix work! To use it, do I just add GLMakie#master and sit back or are other steps needed?

Yep, that's all you have to do.

Let me know if that fixes it

It did, thank you again!


Publish a release that can be consumed from a package manager (e.g. npm)

Evaluate if current situation already supports that

Done: https://github.com/conductor-sdk/conductor-javascript/releases/tag/v0.0.5


PowerPoint found a problem with content PowerPoint can attempt to repair the presentation.

Hi All,
First of all I'd like to say that this library is awesome, truly amazing.
I'm running with an issue - PowerPoint found a problem with content.
What I've been doing is grab a pptx template and format it via {} with all the data the template needs.
The shapes I format are:

Text boxes
Tables
Pie Charts

The code runs fine but when I open the file I got that error.
PowerPoint found a problem with content.
PowerPoint can attempt to repair the presentation.
If you trust the source of this presentation, click Repair.

Can you help me?

Probably something went wrong with your templating. Maybe try it without the template-filling and see if it works.
python-pptx doesn't have any templating features as far as I know, so any problems with that are unlikely to be a mis-behavior of python-pptx (which is rare anyway). Since you haven't mentioned anything about the templating code we have no way of saying much more.

I would also look for the minimum example that shows the problem.

I founded what was causing the error, I'm replacing the data from a pie chart and that generates that need of repair.
I'm creating pie charts from scratch, but now i'm running into a new problem. How can I access X, Y, CX, CY from an existing chart? Just to create the new ones in the exact position.

This is the code:
`def add_pie_chart(self, slide_index, series_data):
slide = self.get_slide_by_index(slide_index)
x, y, cx, cy = Inches(2), Inches(3.25), Inches(3), Inches(2.5)
chart_data = ChartData()
chart_data.categories = ['Good', 'Average', 'Poor']
chart_data.add_series('Series 1', series_data)
    chart = slide.shapes.add_chart(
        XL_CHART_TYPE.PIE, x, y, cx, cy, chart_data).chart

    points = chart.plots[0].series[0].points

    for i in range(len(points)):
        colors = {'good': {'r': 76, 'g': 172, 'b': 162}, 'average': {
            'r': 245, 'g': 184, 'b': 56}, 'poor': {'r': 231, 'g': 91, 'b': 91}}
        if i == 0:
            color = colors['good']
        elif i == 1:
            color = colors['average']
        elif i == 2:
            color = colors['poor']

        fill = points[i].format.fill
        fill.solid()
        fill.fore_color.rgb = RGBColor(color['r'], color['g'], color['b'])

`
I implement it this way:
`def populate_cwv_slides(self):
metrics = ['a', 'b', 'c']
for metric in metrics:
self.name_cwv_metric(metric)
self.populate_cwv_slide(metric)
self.populate_cwv_ranking_table(metric)
    self.add_pie_chart(9, self.data['dc']['a'])
    self.add_pie_chart(10, self.data['dc']['b'])
    self.add_pie_chart(11, self.data['dc']['c'])
    return

`

Leave out the part starting with points = chart.plots[0].series[0].points and see if that works. I suspect the way you're using points on a pie chart is causing a problem and this test would narrow it down.


Variables in Kotlin: Android Basics with Compose

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Name of the video (String)
Name of the channel (String)
Number of views on the video (Int) <----- This one should be Double as a data type, NOT Int, since it has a decimal, yeah? Let me know! Thanks!
Number of likes on the video (Int)
Number of comments on the video (Int)
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@josephtheanalyst
Thank you for reaching out to us.
The reason Number of views is an Int not Double is, it could be stored as an Int of 6900 views, and it will be formatted in the UI as a decimal after using k for thousand.
Hop that answers your question.


Data cannot be downloaded

Hi, because I can't use Google search engine, you provide the url “https://drive.google.com/open? Id =1n4qQzSd_S6Isd6WjKD_sq6LKqn4tiQm9 ”cannot be used. Can you improve other ways of sharing?
Looking forward to your reply.

@guanrenxue Data are also available at Baidu Pan:
https://pan.baidu.com/s/165IXaA_JISCwGzTUCiuPig 提取码: gbp2

@guanrenxue Data are also available at Baidu Pan:
https://pan.baidu.com/s/165IXaA_JISCwGzTUCiuPig 提取码: gbp2

Thank you very much for your sharing. I will study it carefully. I wish you a happy life and good health

@guanrenxue Data are also available at Baidu Pan:
https://pan.baidu.com/s/165IXaA_JISCwGzTUCiuPig 提取码: gbp2

Thank you very much for your sharing. I will study it carefully. I wish you a happy life and good health

Can you share the model of this paper? I didn't find the model of this paper, and I had some problems running the program. Looking forward to your reply.

@guanrenxue hmm, the trained models and other intermediate results had been deleted many months ago, due to the server upgrade and the hard drive limitation. Sorry about it, but it's pretty easy to train it from scratch. You may also use the datasets from 3D-RecGAN++ for training/testing.

Ok, thank you for your detailed answer.


[Analyzer] Error when calculating upper bound of an extension type

The following tests failing in analyzer (works in CFE)
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Extension-types/upper_bound_A01_t01.dart
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Extension-types/upper_bound_A01_t04.dart
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Extension-types/upper_bound_A01_t05.dart
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Extension-types/upper_bound_A01_t06.dart
Example:
// SharedOptions=--enable-experiment=inline-class

import '../../Utils/static_type_helper.dart';

extension type ET1(Object? o) {}
extension type ET2(Object o) {}

extension type ET3(Object? o) implements ET1 {}
extension type ET4(Object o) implements ET2 {}

main() {
  var v1 = 2 > 1 ? ET1(Object()) : ET2(Object());
  v1.expectStaticType<Exactly<Object?>>(); // Fails, actual type Object in the analyzer

  var v2 = 2 > 1 ? ET1(null) : ET2("String");
  v2.expectStaticType<Exactly<Object?>>();  // Fails, actual type Object in the analyzer

  var v3 = 2 > 1 ? ET1(Object()) : ET3(Object());
  v3.expectStaticType<Exactly<ET1>>();

  var v4 = 2 > 1 ? ET1(Object()) : ET4(Object());
  v4.expectStaticType<Exactly<Object?>>();  // Fails, actual type Object in the analyzer

  var v5 = 2 > 1 ? ET2(Object()) : ET4(Object());
  v5.expectStaticType<Exactly<ET2>>();
}

Tested on Dart SDK version: 3.3.0-edge.e4bb5b608b42b97012e968866866922ccf175eba (be) (Tue Oct 17 10:28:23 2023 +0000) on "linux_x64"

https://dart-review.googlesource.com/c/sdk/+/330900


package.json start script is being ignored

Changing the start script to node dist/index.js and placing a index.js file there, even though the log after a push shows this:
remote: Using start-up script dist/index.js from package.json.

I get a a 502 error.
If I place a index.js file in the root folder of my app, it does work.

You need to just remove the starting 'node' in your start script. If we detect you are setting a start script (as opposed to a PM2 process config) we will prepend node for you. More info on https://github.com/Azure-App-Service/node/issues/10
HTH.

@nickwalkmsft Can this issue be closed now thanks to the updates you made to the Node images?

Yes, I will close this, but I'm still tracking it as we haven't deployed it yet. I believe our next deployment should include these enhancements.


[zh] sync device-plugins.md and dynamic-resource-allocation.md

Sync with en text:
content/zh-cn/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
content/zh-cn/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md

Thanks for your careful review 👍

/approve


Require Flask >= 2.2.0

Require Flask >= 2.2.0.
I'm comfortable going up to requiring 3.x, but when I grep'd for
places we use older Flask constructs, this was all I found.
So for now no need to jump further.
Fix https://github.com/pallets-eco/flask-debugtoolbar/issues/222
(not technically a full fix, but good enough for now).

If we're going to drop support for older versions of Flask I do prefer allowing 2.2+ vs 3.0+.
Based on doing a lot of contract work, it may be surprising at how many folks are using older versions of Flask. One of the biggest Flask apps I've worked with (client) is still running 1.1. It has around ~500k lines of Flask code. They use this extension but I think they would be fine sticking with the latest 0.14 release.
One of the orgs I worked with recently was running 2.0 for a long time and recently upgraded to 3.0.
For context:

Flask 2.0.0 was released on 2021-05-11
Flask 2.1.0 was released on 2022-03-28
Flask 2.2.0 was released on 2022-08-01
Flask 2.3.0 was released on 2023-04-25
Flask 3.0.0 was released on 2023-09-30

It doesn't surprise me. I've worked in the real world too. 😁
Agree it's a reasonable request, so I switched from 3.0 to 2.2.0 as the minimum.
As a consequence, 2.2.0 requires Python 3.7, so we also drop support for Python 2.7/3.6. IMO that's fine as both have been EOL'd for a while, so anyone still on that old version of Python is unlikely to be updating a small random Flask extension.

I dropped the Python 3.6 test from being required on the repo branch settings.

Just to give us some confidence, I pulled 0.14.1 into a real Flask 3.0 project and it's all good. There are deprecation warnings to address which should still work with Flask 2.2.0.

Nice, thanks for checking that!
From what I can tell, this PR actually removes all usage of flask.__version__, so merging this will also resolve that deprecation warning.


[REQUEST] Fail mode

Allow using plugin not in "No Fail" mode switching to "No Fail" only in last second automatically, but working with life counter before that.
So you can actually try if you are failing or not with speed increased.

v2.0 allows you to increase speed without No Fail.
https://github.com/xyonico/PracticePlugin/releases/


iOS allows too many characters

The following custom definition permits too many characters on iOS. Android correctly forbids the user from entering more than the specified mask. In the following example, Android restricts the text input from having more than 1 digit, but iOS does not.
 <TextInputMask
            type='custom'
            options={{mask: '9'}}
            value={this.state.inputVal}
            keyboardType='numeric'
            onChangeText={val => val.length <= 1 && this.setState({ inputVal: val })}
          />

Hi,
After a long investigation, I realize it can be a bug in react-native.
I tried with both TextInputMask and default TextInput.
The state remains correct but it does not update current text input value O.o.
This is the code:
export default class App extends React.Component {
  state = {
    inputVal: ''
  }

  _updateVal(val) {
    if (val.length <= 1) {
      this.setState({ inputVal: val }, () => {
        console.log(this.state)
      })
    }
  }

  render() {
    return (
      <View style={styles.container}>
        <Text>TextInputMask: </Text>

        <TextInputMask
          type='custom'
          options={{ mask: '9' }}
          value={this.state.inputVal}
          keyboardType='numeric'
          onChangeText={this._updateVal.bind(this)}
          style={styles.input}
        />

        <Text>Default TextInput: </Text>
        <TextInput
          value={this.state.inputVal}
          keyboardType='numeric'
          onChangeText={this._updateVal.bind(this)}
          style={styles.input}
        />
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
  input: {
    borderWidth: 1,
    borderColor: 'red',
    height: 50,
    width: '90%'
  }
});

And take a look when we input some values into input:

Now, take a look at the console.log to see the state:

This is absolutely bizarre and the same happen if we input values on MaskedTextInput.
I will open an issue on React-Native's repository.
Thanks for reporting.

This issue is opened on React-Native's github:
LINK To ISSUE

Any news?

Hey, I've found a "workaround" for now: just define maxLength on your TextInput.
That's the "solution" while there isn't an official bugfix... Example:
If you define the credit-card mask, just define the maxLength of your input to 19, so it will cover the 16 digits of the credit card plus the 3 spaces. :+1:

Guys! Good news!
This PR solves this problem!
To solve this problem without painful merge, just merge this PR in the ios project
OR
1 - Open this file:

2 - Add this code:

3 - And this code:

I will keep this issue opened until official fix.

Fixed in RN 0.57


Issues upgrading react-native

Description
Following the "Upgrading" documentation (https://facebook.github.io/react-native/docs/upgrading.html), I'm not able to upgrade react-native
Reproduction
Run npm install --save<EMAIL_ADDRESS>having installed version 0.37.0
You will see this log:
➜  xxx git:(master) ✗ npm install --save<EMAIL_ADDRESS> npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from react-native will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead

><EMAIL_ADDRESS>postinstall /Users/xxx/Personal/xxx/node_modules/react-native/node_modules/yeoman-generator/node_modules/cross-spawn/node_modules/spawn-sync
> node postinstall

npm ERR! Darwin 16.1.0
npm ERR! argv "/Users/xxx/.nvm/versions/node/v4.4.5/bin/node" "/Users/xxx/.nvm/versions/node/v4.4.5/bin/npm" "install" "--save"<EMAIL_ADDRESS>npm ERR! node v4.4.5
npm ERR! npm  v2.15.5
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/xxx/Personal/xxx/npm-debug.log

Solution
Add information about how to upgrade properly react-native
Additional Information

React Native version: 0.37.0
Platform: N/A
Operating System: MacOS

Have you installed react 15.4?
"react": "15.4.0",

This is really confusing, sorry! Here's a PR for the docs:
https://github.com/facebook/react-native/pull/11123
We'll release a new upgrade tool soon where we should fix this.

@mkonicek is there a PR related? Or is it something you are thinking right now?

I'm not sure I understand. Send a PR for what exactly?

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


Instructions on how to configure helm-config.yaml is not clear

Article says:
"The  is a property of the Microsoft Entra Workload ID you setup in the previous section. You can retrieve this information by running the following command: az identity show -g  -n , where  is the resource group hosting the infrastructure resources related to the AKS cluster, Application Gateway and managed identity."
However there is multiple properties of managed identity which are storing id:
"clientId"
"id"
"principalId"
Which one of them supposed to be used ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d3925c0f-2f3a-a53e-d558-c00cca37e961
Version Independent ID: 1a49146e-07a4-bb12-0a5b-0d07590fbcad
Content: Create an ingress controller with an existing Application Gateway
Content Source: articles/application-gateway/ingress-controller-install-existing.md
Service: application-gateway
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@Alexey-Zheltov
Thanks for your feedback! We will investigate and update as appropriate.

@Alexey-Zheltov
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Closing this request and moving to internal work item 91203
#please-close


One Plus 8T (Android 12 upgrade) black screen after reboot

Installed zip from storage v9.0.0, enabled module...rebooted...enabled module in lsposed...rebooted...black screen. Also before rebooting the preferences app used to freeze
any ideas on what might be going on

How did you get it back running? I'm in recovery or fastboot mode and want to remove it but don't know how.

Got it running by pressing volume up multiple times while booting

Did you guys manage to get this working? Currently having the same issue


Preliminary class resilience work

Mostly NFC refactoring so far.

@swift-ci Please smoke test

@rjmccall Does this look OK so far?

@swift-ci Please test

@swift-ci Please test source compatibility

@swift-ci Please test

@swift-ci Please test source compatibility

Source compatibility failure isn't me.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test macOS

Build failed
Swift Test Linux Platform
Git Sha - 7cb93ebc8830d60f3f169ee4e1228f09156f1a55

Build failed
Swift Test OS X Platform
Git Sha - 7cb93ebc8830d60f3f169ee4e1228f09156f1a55

Hi @rjmccall I'm splitting this up into smaller PRs to test things as thoroughly as possible in CI.


Component: Image with Caption changes needed for the Solutions page template

The changes to the image with caption component were overlooked when we changed the scope around the media component.  The Functional specs are up to date.  Dev and QA work is needed.
This work has to be finished in sprint 20-10.

Release complete.  All linked issues closed.  Closing this epic.


[BUG]: onConflictDoNothing doesn't handle WHERE clause correctly (for partial indexes/unique constraints)

What version of drizzle-orm are you using?
0.28.6
What version of drizzle-kit are you using?
No response
Describe the Bug
I have a users table with email and deleted_at columns. And I have a UNIQUE INDEX ON (email) WHERE deleted_at IS NULL, meaning there can only be one active/non-deleted user record per email at a time.
If I try to write a Drizzle query to try and insert while checking for this:
const [user] = await db
  .insert(users)
  .values({
    email,
    ...data,
  })
  .onConflictDoNothing({
    target: [users.email],
    where: isNull(users.deletedAt),
  })
  .returning();

Drizzle outputs/executes the following invalid SQL (e.g. Postgres rejects this query):
insert into "users" (...)
values (...)
on conflict ("email") do nothing
where "users"."deleted_at" is null

The correct SQL would be:
insert into "users" (...)
values (...)
on conflict ("email") where "users"."deleted_at" is null
do nothing

—
I see this change was made in pull #651 in response to issue #525, which was a valid request for "on conflict do update" queries. But this isn't valid for "on conflict do nothing" queries. No WHERE clause is allowed following DO NOTHING:
https://www.postgresql.org/docs/current/sql-insert.html
https://www.sqlite.org/images/syntax/upsert-clause.gif
I see that issue #1302 has been filed as a feature request to support partial indexes with "on conflict do update" queries. I wanted to file this bug report as I think #651 is both a regression for "on conflict do insert" queries, and clearly incorrect to offer a where clause in the onConflictDoNothing config and not use it to support partial indexes.
—
I think this is an easy fix/revert for onConflictDoInsert and I'd be happy to PR that. But how would you like to handle onConflictDoUpdate? I agree with #1302 that Drizzle probably needs to provide two separate where configs now, to support both partial indexes and selective updates. Maybe the following?
.onConflictDoUpdate({
  target: IndexColumn | IndexColumn[],
  targetWhere?: SQL,
  set: ...,
  setWhere?: SQL,
})

That'd be a breaking API change, so perhaps you continue to accept where as a proxy for setWhere for now.

I quickly made this change in a fork to unblock ourselves:
https://github.com/drizzle-team/drizzle-orm/compare/main...hiportola:drizzle-orm:portola/fix-on-conflict-do-nothing-where
It both fixes the bug for insert queries, and separates out targetWhere and setWhere for update queries (preserving but deprecating where as a proxy for setWhere for back-compat).
I haven't yet done all the work to submit a PR (will try to later), but wanted to share this quickly both if it helps anyone else and if you all have any immediate feedback. Thank you!


Remove the changelog

This is more bookkeeping then we need to do. Release notes should serve fine (which is what we do for many of our other repos).

We generate the changelog from these files, so this change would be a bit more involved.


use escapefromtarkov.fandom.com instead of mapgenie for links

Because mapgenie is not free

idea based on https://github.com/guillaumearm/PathToTarkov/pull/3


Max Hit & Fashionscape problem

So I'm not sure which plugin is causing the issue, or whether it's even that big of a deal, so I'm just going to post this for both plugins. Essentially the problem is that the Fashionscape plugin changes the max hit calculation to the gear shown with Fashionscape. Not sure why or how it's happening all I know is that when I turn off the Fashionscape plugin my max hit goes back to what it should be.

I don't think there's anything I can do about this, since the plugin changes player model ids, and if that plugin is using those, it'll mess with your max hit. Nothing I can change on my end


Evaluate arithmetic terms before storing ground atoms

Contributes to fixing of #159 together with #160, but does not fully fix it. See comment there.

Made obsolete by #163


Hints shows in strange place

https://github.com/folke/noice.nvim/issues/295
I did this:
local opts = {
  cmdline = {
    enabled = false,
  },
  messages = {
    enabled = false,
  },
}

noice.setup(opts)

and have this

answer its just disable popupmenu

solved


Allow Ctrl/Shift + insert to copy/paste on windows and linux

Many systems (including MS Windows and many linuxes) map Ctrl + Insert to copy and Shift + Insert to paste. That serves as a handy fallback when the more common Ctrl + C and Ctrl + V keybindings have their default prevented to send signals to the terminal.
Currently all keydown-events with the insert key send \x1b[2~ to the terminal. Instead this PR won’t send anything if either the shiftKey or the ctrlKey are present in the event. Also it will enable contentEditable when shiftKey is present to allow for pasting in Firefox and Edge.

Ideally this should be configurable, I'd like VS Code users to be able to use their preferred method (the default of which will probably be ctrl|cmd+shift+c/v). gnome-terminal has a settings dialog which allows customizing of a bunch of keybindings that aren't native

Perhaps allowing consumers to do more generic mappings would be a good idea?
Also shift+insert at least on gnome-terminal appears to be a shortcut for middle-click to paste selection, not from clipboard.

While I agree with @Tyriar that some kind of customization/extensibility considering key bindings, I do not believe that this is blocking at the moment.
This PR works 👍 . LGTM.


✖remove react-apollo and replace the usage with individual package. …

…We are already using this under the hook so functionality wise there is no change.
I would like to get this into master soon so it will be easier to do 🎩 when I actually bring in functionality from @apollo/react-hooks to be use in react-graphql
Description
Fixes (issue #)

Type of change

[x]  Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
[ ]  Minor: New feature (non-breaking change which adds functionality)
[ ]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above

@vsumner I do debate over minor or path as well.
officially, the change of dependency does mean a minor, but because the package & its version its using under the hook did not change, I opt for a minor for now.

I ended up doing minor dump for react-graphql and patch for jest-mock-apollo, thanks for the suggestion @vsumner !


Adding annotate_text() method in language and helper classes needed for it

This essentially finishes the Cloud Natural Language implementation. System test forthcoming (subsequent PR) and then a few TODO issues need to be resolved.

ISTM that token.py should be called something more general:  syntax.py, maybe, or analysis?

@tseaver Happy to change it to syntax.py. Any other issues with this PR?

I think token is actually a natural language term, possibly specific to what this is doing?

@dhermes I had no other issues than the module name.

OK. Added a new commit at the end with the rename to syntax. Will merge when Travis goes green.


perf: scale Expr.replace cache with input size

When the cache is much bigger than the traversed term, we're spending most of the time with allocating and deallocating it. This change speeds up mathlib4 cumulative CPU time by ~20% and type inference time by ~32%. In particular, instantiateLevelParams falls in one arbitrarily selected test case (Mathlib.Algebra.Order.Ring.Defs) from 12.7% cumulative time share to 3.4%.
Other approaches are conceivable such as doing no caching at all below a certain term depth, but this one does not introduce any new magic numbers and the potential for further savings in this part is unclear.

!bench

In particular, this should mostly obsolete the need for #2028


File attribute for TranslationUnitDeclaration null

The file attribute for the TranslationUnitDeclaration is never set. This was probably forgotten here https://github.com/Fraunhofer-AISEC/cpg/blob/16031b65a2c09d90bc0121af13f2d19eefbdb9d9/src/main/java/de/fraunhofer/aisec/cpg/passes/FilenameMapper.java#L39.

Wouldn't that be somehow redundant, as the name attribute of a TranslationUnitDeclaration is exactly what would be stored in the file attribute?

#702 closed this issue.


File.exists is removed from ruby 3.2 (was deprecated in 2.7).

/bundle_cache/ruby/3.2.0/gems/dawnscanner-1.6.9/lib/dawn/kb/pattern_match_check.rb:64:in block in vuln?: undefined method exists? for File:Class (NoMethodError)
matches = run(load_file(filename)) if File.exists?(filename) && File.file?(filename) && ! File.binary?(filename) && ! must_exclude?(filename)
Did you mean?  exist?

+1, getting the exact same issue trying to run Dawnscanner on one of the example repos.


Update APIs.guru description and links

Thanks mate!

No problem, I'm the APIs.guru openapi-directory maintainer, so if you've ever got any questions / want to collaborate on a blog post etc, just let me know!

I know who you are Mike and I follow your work - thanks for everything!

Oh yes! https://github.com/Mermade/swagger2openapi/issues/16 😺


Cannot Save the songs

Downloaded this script on Feb 6 . Everything works fine. However, after converting the file, the command prompt says "The system cannot find the path specified."
Help Please.

@Whacko23 You do not have avconv installed. Install it for your OS as mentioned in the README.

I downloaded the file and copied the contents of bin to C:\Python27\Scripts. Then I extracted the folder to desktop and moved the 'usr' directory to C:\Python27. I even copied the folders bin, include, lib and share ( the folders inside usr directory) to C:\Python27. However, this did not seem to help at all
P.S. I forgot to thank you for your super fast reply. And while I am into it, I must thank you for this script. NIce work.

Weird, it should work after you have done that step..
Can you post the full error message it gives out? That may help :D

Actually, it had two errors before that. The first one was on line 102. There is no parentheses after print statement. After correcting that I got inconsistent use of tab and spaces error on the line after that ( This was probably my fault but still I want you to check it out). I just joined GitHub today and only know basic programming. That being said, I don't know how to explain the error.
P.S. I use python 2.7.13. Is that any problem?
P.P.S. I even copied the contents of bin to C:\Python27 ( which was not mentioned in the readme.md). Do you think I need to specify the directory where the music file is to be saved in the script?

Hey, i just tested out and the error shows up when you don't have spotdl.py in your python folder. Put the script in your python folder and run it from there. It should work all good :+1:
Relative paths you know :(

Btw, there is no identation error at https://github.com/git/git/blob/master/README#L102 and no inconsistent spaces/tabs.. I just downloaded it on a windows pc and it worked straight fine..

Thanks! Works like a charm now. It was actually getting quite annoying. Tysm


We should refactor the array schema

Right now it doesn't allow us any kind of options, since it's an array:
someArray: [
   {
        ...
   }
]

Currently the best idea I have is to have something like:
someArray: {
    type: "array",
    item: {
       /* item schema */
    }
}

@silviubogan Any better ideas?

In the example/index.html file I see that the hobbies array schema looks like this:
hobbies: { label: "Hobbies",
    schema: {
        possible: [
            "piano",
            "blogging",
            "computers",
            "science",
            "music"
        ]
    }
}

The type property of the schema is in this example inferred from the data, so the final schema looks like this:
hobbies: { label: "Hobbies",
    type: "array",
    schema: {
        ...
    }
}

So, personally, I do not see any problem. :smiley:


Add support for specifying a mask id during the speech-to-speech pretraining task

This allows for masking variable-lengthed sequences with the correct distribution (e.g. p = 0.6) with respect to the sequence mask.
I had to branch the masking behavior when the mask id is provided, because the existing batch -> mask -> rearrange back to batch doesn't work for ragged sequences, since each sequence in the batch can have a variable number of tokens. @lucidrains let me know if you are ok with this approach or if you have a better idea 🙏
I also added an option to return logits along with the loss to allow computing downstream metrics (the metrics are not included in this PR), and put in some minor fixes for the decoder depth & cleaned up some issues with the logging from the original trainer work.

@lucasnewman yes this is exactly how i would have approached it! thank you Lucas! 💯 🚀

code is impeccable, but now i know why haha


edit user hat in code-server

See #98 and https://github.com/cdr/sail/pull/104/files#r280556409

Going to close as it has been a while and I'm not sure if this is relevant anymore.


Latest FFMPEG

Looks like the version of FFMPEG in the SMA container is 4.1.6.
I see there is a build tag, but how can we get this updated to the latest FFMPEG release?
I'm using the "latest" build as well

Please disregard, it is the latest version. Need to remove the truedhd-ignore settings

Just in case others stumble upon this issue
You can specify an alternate URL for your FFMPEG binaries
By default you can see in the dockerfile I use
ENV SMA_FFMPEG_URL https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-amd64-static.tar.xz

You can override this variable and use a different source of your choosing, buy more regular builds can be found here
https://www.johnvansickle.com/ffmpeg/
Additionally you can use the build tag and set your ARG ffmpeg_tag to build your own version of FFMPEG from source using any of the versions available on https://github.com/jrottenberg/ffmpeg


how to install?

I cannot install the matplotlib which's version is older than 3.5.0, how I install the proplot?.......
  Extracting /project/freetype/freetype2/2.6.1/freetype-2.6.1.tar.gz
  Building freetype in build\freetype-2.6.1
  msbuild build\freetype-2.6.1\builds\windows\vc2010\freetype.sln /t:Clean;Build /p:Configuration=Release;Platform=x64
  error: command 'msbuild' failed: None
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for matplotlib
Running setup.py clean for matplotlib
Failed to build matplotlib
ERROR: Could not build wheels for matplotlib, which is required to install pyproject.toml-based projects

python version is 3.11.8

more error information

try install python<=3.10, matplotlib=3.43

A solution is being worked on https://github.com/proplot-dev/proplot/pull/459

Fixed with https://github.com/proplot-dev/proplot/pull/459#issuecomment-2291293343

Please see https://github.com/proplot-dev/proplot/pull/459! Until this gets merged in and released as an official version, you can install proplot via the following command to have compatibility with modern python versions and modern versions of matplotlib, cartopy, etc.
pip install git+https://github.com/proplot-dev/proplot.git@refs/pull/459/head


Warning: Failed prop type on SingleDatePicker

Hello,
I got issue Warning: Failed prop type on SingleDatePicker when using SingleDatePicker on react-dates:

Here my code:
import 'react-dates/initialize'
import { SingleDatePicker } from 'react-dates'

// Styles
import 'react-dates/lib/css/_datepicker.css'
import '../../../assets/styles/custom_datepicker.css'

<SingleDatePicker
          isOutsideRange={
            isEnableDateRange
              ? day => handleGetOutsideRangeDates(day)
              : this.handleGetDefaultOutSideRange
          }
          date={calendarDate ? moment(calendarDate) : calendarDate}
          onDateChange={date => handleGetPeriod(id, date)}
          focused={this.state.focused}
          onFocusChange={({ focused }) => this.setState({ focused })}
          id={id}
          inputIconPosition={ICON_AFTER_POSITION}
          placeholder={placeholder}
          displayFormat={`DD/MM/YYYY`}
          numberOfMonths={1}
          showDefaultInputIcon={false}
          customInputIcon={
            <LinkIcon {...calendarIconStyles} disabled={disabled} />
          }
          disabled={disabled}
          daySize={22}
          monthFormat={'MMM, YYYY'}
          firstDayOfWeek={1}
          readOnly={readOnly}
        />

These errors happen on both react-dates v16.7.0 and v18.2.1.
I have research on issues but can't find solution for it. Anyone can help me?
Thanks,

Do you perhaps have a build process that’s inserting “self” and “source” props, perhaps something related to hot reloading?

Do you perhaps have a build process that’s inserting “self” and “source” props, perhaps something related to hot reloading?

@ljharb I don't have any special config on it. Currently I'm using react-dates with preact. Do you have any another suggestion to fix these warnings?

It’s possible that preact is doing it - this is react-dates, not preact-dates. You may want to file it on preact.

got it @ljharb . Thanks for the advice 👌

Closing, in favor of https://github.com/developit/preact/issues/762


Re-organize code for applications, DAS, imaging, etc...

Reorganize codes:

[ ] make new folder in src, src/noisepy/monitoring and move all monitoring scripts relevant there - test using a tutorial notebook to add to our tutorial collections. Namespace will be noisepy.monitoring.
[ ] make new folder in src, src/noisepy/imaging and move all monitoring scripts relevant there - test using a tutorial notebook to add to our tutorial collections. Namespace will be noisepy.imaging.
[ ] make a new repository for namespace noisepy.das, repository noisepy4das. test for compatibility with other noisepy packages, especially noisepy.io.

Great!
Let's create
noisepy.imaging and move dispersion_analysis.py in it. We may create another imaging_utils.py by adding a few functions that we moved away from noise_module.py. @niyiyu .

[ ] Develop a new ConfigMonitoringParameter class to read / store all parameters for dv/v and attenuation


Train Code

I want to follow your outstanding work, so I wonder if the training code and guideline will be released in the future?

ditto

I am sorry that I am not allowed to publish the training code of ALIKED, you can refer to the training code of ALIKE.

I am sorry that I am not allowed to publish the training code of ALIKED, you can refer to the training code of ALIKE.

This link only contains code and no explanation. I have some questions, can I contact you via email?

sure


fix: missing hook to sign darwin binaries

Was missing the hook to actually sign the darwin binaries.

:tada: This PR is included in version 3.0.0-beta.14 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to create a .dll file for already existing C++ file ??

Hello , I am newbie to C++ programming. I told to convert from C++ to Labview using .dll function. I already have the program written in C++ which calls the list of images in the main function. I wanted to call the list of images in Labview using C++ DLL,

Please sameone explain how to generate the .dll file for already existing C++ file.
Please someone explain how to call the list of images in labview using .dll c++ file.

Thanks
Baskaran

@BaskaranRajamanickam
This GitHub issues board is meant for raising issues about the documentation for the Microsoft C++ compiler and tools. Unfortunately, that means it isn't really the right forum to ask questions like yours. I expect questions about coding for LabVIEW would get more attention in their forums, instead.

Sorry and Thanks :)


System.InvalidOperationException: Application cannot have both a type with an [Application] attribute and an [assembly:Application] attribute.

Severity	Code	Description	Project	File	Line	Suppression State
Error		The "GenerateJavaStubs" task failed unexpectedly.
System.InvalidOperationException: Application cannot have both a type with an [Application] attribute and an [assembly:Application] attribute.
at Xamarin.Android.Tasks.ManifestDocument.CreateApplicationElement(XElement manifest, String applicationClass, List1 subclasses, List1 selectedWhitelistAssemblies)
at Xamarin.Android.Tasks.ManifestDocument.Merge(List1 subclasses, List1 selectedWhitelistAssemblies, String applicationClass, Boolean embed, String bundledWearApplicationName, IEnumerable`1 mergedManifestDocuments)
at Xamarin.Android.Tasks.GenerateJavaStubs.Run(DirectoryAssemblyResolver res)
at Xamarin.Android.Tasks.GenerateJavaStubs.Execute()
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.d__26.MoveNext()	TESTAPP.Android

It was due to below lines in Assembly.cs file, commenting the lines resolved the issue.
#if DEBUG
[Application(Debuggable = true)]
#else
[Application(Debuggable = false)]
#endif


Feature Request: Expose an Uint8List type for a private key

The library only takes a hex string for a private key and it requires to convert this string to an Uint8List whenever it calls a sign or recover.
Suggestion 1: Add a required named argument to all methods that takes a private key and change a string private key to optional. If an optional private key is set, then simply change this to bytes and call this method again.
Suggestion 2: Add a separate method that takes a private key as an Uint8List.

hi @njovy , i. added more optional params and guard by an missing exception, let's use it


workbench.action.navigate strange behaviour

VSCode Version: 1.12.1
OS Version: MacOs Sierra

Hi, I tried to bind this commands :
  {
    "key": "home",
    "command": "workbench.action.navigateLeft"
  },
  {
    "key": "end",
    "command": "workbench.action.navigateRight"
  },
  {
    "key": "pageup",
    "command": "workbench.action.navigateUp"
  },
  {
    "key": "pagedown",
    "command": "workbench.action.navigateDown"
  }

The two first (home & end) allow me to switch my active cursor to left and right panel.
But neither navigateUp or navigateDown seems to work correctly.
First: Here is a scenario, with following commands :

workbench.action.navigateRight (+some moves)
workbench.action.navigateRight (+some moves)
workbench.action.navigateRight (+some moves)
workbench.action.navigateTop, but i'm stuck in file explorer
but as you can see, i'm unable to switch to the top "opened editor" panel with navigateTop

Second: Another scenario, with following commands :

workbench.action.navigateRight (+some moves)
workbench.action.navigateLeft (+some moves)
workbench.action.navigateDown
now i'm stuck in the terminal, none workbench.action.navigateXXX works anymore

I don't find any other command allowing to go out of the terminal, or to switch between open editor and the explorer file list. Maybe i missed it and i can add command with conditions to allow me doing that.
My goal is to be able to work without touching my mouse. Which seems difficult without such functionality.
Thanks,
David

@DavidBabel you need to configure terminal.integrated.commandsToSkipShell in settings to enable workbench commands to run in the terminal.
We do not support navigation from explorer to opened editors with the commands you are using, but there are other commands to navigate to either the explorer or open editors view.
In the future, please post questions over at StackOverflow: http://stackoverflow.com/questions/tagged/vscode
Thanks for understanding.

For Information, here is a working solution. On MacOs it allow to switch between every pannels with fn+up/down/left/right :
  ////////////////////
  /// navigation clavier
  ////////////
  {
    "key": "home",
    "command": "workbench.action.navigateLeft"
  },
  {
    "key": "end",
    "command": "workbench.action.navigateRight"
  },
  // ordre important
  {
    "key": "pageup",
    "command": "workbench.action.navigateUp"
  },
  {
    "key": "pagedown",
    "command": "workbench.action.navigateDown"
  },
  {
    "key": "pageup",
    "command": "workbench.files.action.focusOpenEditorsView",
    "when": "explorerViewletFocus && explorerViewletVisible"
  },
  {
    "key": "pagedown",
    "command": "workbench.files.action.focusFilesExplorer",
    "when": "explorerViewletFocus && explorerViewletVisible"
  },
  // desactivés
  {
    "key": "pageup",
    "command": "-cursorPageUp",
    "when": "editorTextFocus"
  },
  {
    "key": "pagedown",
    "command": "-cursorPageDown",
    "when": "editorTextFocus"
  },
  ////////////
  /// fin navigation clavier
  ////////////////////


GET /clusters/{clusterId}/report returns 404

smart-proxy returns 404 on GET /clusters/{clusterId}/report. The log contains an error:
{"level":"info","time":"2020-06-26T13:10:22Z","message":"Request received - URI: /api/insights-results-aggregator/v1/organizations/11789772/clusters, Method: GET"}
{"level":"info","time":"2020-06-26T13:10:22Z","message":"Handling response as a proxy"}
{"level":"debug","time":"2020-06-26T13:10:22Z","message":"Connecting to http://insights-results-aggregator:8080/api/insights-results-aggregator/v1/organizations/11789772/clusters "}
{"level":"info","time":"2020-06-26T13:10:23Z","message":"Request received - URI: /api/insights-results-aggregator/v1/clusters/254633ef-bd50-4504-91f7-3acf8d2cc83b/report, Method: GET"}
{"level":"error","error":"Item with ID ccx_rules_ocp.external.rules.nodes_kubelet_version_check.report/NODE_KUBELET_VERSION was not found in the storage","time":"2020-06-26T13:10:23Z","message":"handleServerError()"}

insights-results-aggregator receives a proxied request and replies without errors:
{"level":"info","time":"2020-06-26T13:10:23Z","message":"Request received - URI: /api/insights-results-aggregator/v1/organizations/11789772/clusters/254633ef-bd50-4504-91f7-3acf8d2cc83b/users/6089719/report, Method: GET"}

Apparently the problem is related to the lack of static content for this specific rule (ccx_rules_ocp.external.rules.nodes_kubelet_version_check).
Are you OK closing this issue?

Sure


post and pre command execution not working with tmux commands

I am trying to execute tmux commands via the post and pre options in my yml config file for tmuxinator.  The actions of both the pre and post arguments are being executed (verified by adding echo test > /tmp/test.log and checking the log file for update) but the tmux commands are ineffective.
Here is a test config that consistently reproduces my issue:
# ~/.tmuxinator/cmgw.yml

name: test
root: ~/

# Optional tmux socket
# socket_name: foo

# Runs before everything. Use it to start daemons etc.
# pre: sudo /etc/rc.d/mysqld start

# Runs in each window and pane before window/pane specific commands. Useful for setting up interpreter versions.
# pre_window: rbenv shell 2.0.0-p247

# Pass command line options to tmux. Useful for specifying a different tmux.conf.
# tmux_options: -f ~/.tmux.mac.conf

# Change the command to call tmux.  This can be used by derivatives/wrappers like byobu.
# tmux_command: byobu

# Specifies (by name or index) which window will be selected on project startup. If not set, the first window is used.
# startup_window: logs

# Controls whether the tmux session should be attached to automatically. Defaults to true.
# attach: false

# Runs after everything. Use it to attach to tmux with custom options etc.
# post: tmux -CC attach -t cmgw

pre: tmux detach-client -s test
windows:
  - test01:
  - test02:
  - test03:
  - test04:
  - test05:
post: tmux move-window -s test:5 -t test:0

This should automatically detach any existing clients already using this session, create five windows and then move window 5 to window 0 (I have set -g base-index 1 and setw -g pane-base-index 1 in my .tux.conf which I prefer 99% of the time, but there are occasions I like to use window zero).
I tried adding tmux ls > /tmp/test.log and it does not display any running sessions even though I do have other sessions running.  It is almost as if tmux and tmuxinator are using different sockets, but sessions started with tmuxinator are being displayed with tmux ls in a shell, it is only blank when executed by tmuxinator.  I also tried adding -L default to the tmux commands and it made no difference.
I am currently running tmuxinator 0.8.1 but have also tried 0.9 with the same result.
Here is the output of tmuxinator debug test:
#!/bin/bash

# Clear rbenv variables before starting tmux
unset RBENV_VERSION
unset RBENV_DIR

tmux start-server;

  cd /home/agall

  # Run pre command.
  tmux detach-client -s test

  # Create the session and the first window. Manually switch to root
  # directory if required to support tmux < 1.9
  TMUX= tmux new-session -d -s test -n test01

  # Create other windows.
  tmux new-window  -t test:2 -n test02
  tmux new-window  -t test:3 -n test03
  tmux new-window  -t test:4 -n test04
  tmux new-window  -t test:5 -n test05

  # Window "test01"

  # Window "test02"

  # Window "test03"

  # Window "test04"

  # Window "test05"

  tmux select-window -t 1

  if [ -z "$TMUX" ]; then
    tmux -u attach-session -t test
  else
    tmux -u switch-client -t test
  fi

tmux move-window -s test:5 -t test:0

Any help resolving this is appreciated!

Hey @strang3r,
I think two different issues are at play here:

The pre command isn't run if there's an existing session with the same name as the project. See template.erb.
This may be a bug (I'll open a separate issue), but post doesn't seem to run on (at least on my machine) until the session is killed or detached from. When I run your sample, I see: can't move window: index in use: 0 output upon exit or detach. (I also added some debug statements which verified that the command is actually being run on exit/detach and this message isn't an artifact.)

Fortunately, I think the new project hooks which will be introduced in #486 will allow you to achieve what you're after.

Hi, @strang3r. Are you still seeing this behavior with the most recent version of tmuxinator (0.12.0) and the new hook API?

I'm going to close this for now. Please feel free to reopen if anyone is still seeing this issue.

The on_project_start hook works perfectly for detaching existing sessions as I had originally intended, thank you.
I was not able to determine how to use the project hooks to switch windows after they have been created (as per my original attempt using post).  I was able to work around this by creating a temporary window to issue a tmux command and then immediately closing the window.  It's a but kludgy but it works:
on_project_start: tmux detach-client -s test
windows:
  - test01: ssh test01
  - test02: ssh test02
  - test03: ssh test03
  - test04: ssh test04
  - test-master: ssh test-master
  - post: tmux move-window -s test:5 -t test:0; exit

This can remain closed, I just wanted to provide an update.


Missing Nominatim data

I've noticed for a while now that Nominatim data are often missing. Having returned from Portugal, out of ~1k photos only ~300 have any Nominatim data at all (country set to PRT), none of them have state or city information (while all of them have GPS data).
Now my 2 questions on this:

What can I do to improve that? Some kind of rescan?
Could I easily add at least country information to all apps in a given album, or even city information to multiple selected images?

A third question would of course be how this could be solved in a way not requiring manual editing. I've noticed a similar thing in Spain as well, where many photos just had ESP as country. Seems like I didn't have such issues with e.g. UK (where it even labeled "Scotland" as state and also had city information correct) or DE (cities set, though no states) or Cyprus (cities set).

Aves finds countries/addresses in 2 distinct steps:

first a quick pass, completely offline and autonomously, using rough topographic boundaries to find the country, but not the full address. Because of the nature of the data, this is imprecise and it can easily miss locations (close to a coastline for example). Also, this give unlocalized country codes (e.g. PRT).
then another pass, requiring mobile services installed on the device (typically GMS, but in your case I suppose you plugged Nominatim), to do reverse geocoding. This is more precise and yields a full address, including the city and the country name in your local (e.g. Portugal). As far as I know, the mobile services require internet access to do reverse geocoding.

What can I do to improve that? Some kind of rescan?

You could try to select the media items and in the top right menu select the Rescan action. But as I remember, I make Aves go through pass 2 on launch for media items that only got the country from pass 1, if mobile services are detected on the device.
Could you paste here the system info you get in About > Bug Report?

Could I easily add at least country information to all apps in a given album, or even city information to multiple selected images?

If you do have a country code but no city, then I suppose the mobile services are not installed or they fail to do reverse geocoding. You could look into that.
If with your current setup even the country is missing, the only option would be to change the GPS coordinates in the metadata (you can do that in Aves). Or you could forgo GPS coordinates and derived address, and simply use tags for the country and/or city.

Thanks for the details, Thibault!

first a quick pass … then another pass

That explains numbers having got up (seems like there's some "delayed event" performing those scans?); meanwhile PRT has 467 entries (with no new photos/videos added in the last 2 days).

You could try to select the media items and in the top right menu select the Rescan action.

Tried that with 2 example photos selected, details shown didn't change (just date, size and GPS displayed on top). Numbers in stats didn't change. Comparing with one of the photos from the PRT filter, it has PRT instead of the GPS coordinates.

if mobile services are detected on the device.

As you correctly remember, this is the device we've talked about in the past and where the vendor provided a quick fix to make Nominatim working a little over a year ago. Setup didn't change since then, so Nominatim per se should still be working. Funny thing is, too, that some media from Portugal correctly get the PRT while others do not, and that with some other countries it seems to even work fully (e.g. during my stay in Aberdeen 9 month ago I get the full country as "United Kingdom", the state as "Scotland" and even the cities as Aberdeen, Stonehaven etc; some places in Spain work as well, where I have 1k correctly marked "Spain" (plus 354 just ESP) with cities like Valencia, Segovia, Toledo – Spain I visited in March/April; Germany seems to work entirely fine).

Could you paste here the system info you get in About > Bug Report?

Sure: aves_report.zip contains the about.txt (copy-paste from step 2) and 2 log files (from step 1) where you'll be mostly interested in the second, which should cover the rescan run.

If you do have a country code but no city, then I suppose the mobile services are not installed or they fail to do reverse geocoding. You could look into that.

That's what puzzles me: I didn't change a thing with them for at least half a year, and they worked fine for the media from Spain 1.5 months ago – at least partly (some still have ESP instead of Spain). If you give me a hint / steps to follow to narrow that down, I'll of course do that and provide you with the details – be it via Aves directly, via some FOSS helper app, or via ADB.

Or you could forgo GPS coordinates and derived address, and simply use tags for the country and/or city.

You mean, select the media, then add the e.g. PRT tag to them? I couldn't find a related menu entry for that. And doing that for hundreds of media manually is quite cumbersome (tried that for one but couldn't find "existing labels" listed, just the option to create a new tag or use any of the 3 placeholders Country, State, Place – I must have missed something there).

I've checked with the FAQ (here in the wiki), but it is not clear how to use any of the existing tags one did not manually create oneself).

Lots to reply to, but I must go soon, so I'll just point out that in your system info I see Mobile services: not available.
From the point of view of Aves, there's no mobile services so it won't even try to do the reverse geocoding. Do you have MicroG installed? (Nominatim is just the reverse geocoder, right?)

actually mobile services are just checked for google map layers. Geocoding is separate.

Just to point out I'm running the "libre" variant here, that comes entirely without the Google Map layers even :wink: The device has microG installed, but all its Google connections (sign in, FCM etc) disabled.

Geocoders typically requires being connected to the internet, so Aves checks connectivity before calling the geocoder (otherwise unconnected users would see these attempts take a long time before timeouts kick in).
Do you think a lack of connectivity on Aves launch could explain things in your case?

couldn't find "existing labels" listed

This is strange. In the tag editor, you should see a "Top Tags" section showing your existing tags (found in your collection, as they are listed in the Tags page) ordered by usage.

If you go to the Tags page, is it empty?

Do you think a lack of connectivity on Aves launch could explain things in your case?

I don't think that's likely. The device Aves runs on here has a good data plan, and the rescan was done while on WiFi. Nor can I remember any connectivity issues on that device (my other one, an old FP2, needs a reboot every 2 weeks or so as it starts missing its SIM, or gets its WiFi "flaky" – but the SHIFT6mq runs stable as a rock).

In the tag editor, you should see a "Top Tags" section

That's the section I'm missing! Hm, maybe something specific with the flavor? I'm running the "libre" one from F-Droid. Oh, and the device is still on Android 10, in case that matters.
Lemme cross-check, I've got the "normal" version on the FP2 (rarely use it there as it seems too heavy for that 32bit device – but that's a different issue)… Nope, no "Top Tags" there either. Ugh, but that's missing some updates, wow – still on 1.7.1, why? What's more strange: Aves does not show up there in the F-Droid client as "installed app", now I'm baffled. Querying the FP2 via ADB:
$ adb shell "pm list packages -3" |grep aves
package:deckers.thibault.aves.profile

Oof. That looks like some test version where we might have tried things in the past…

If you go to the Tags page, is it empty?

Menu already says "Tags 0". So yes: "No tags".

The device Aves runs on here has a good data plan, and the rescan was done while on WiFi.

I see, thanks. I'll need to think of ways to debug this further.

deckers.thibault.aves.profile

Yes, this is a test package. You can remove it.

Menu already says "Tags 0". So yes: "No tags".

If you don't have existing tags, then it makes sense that you don't have the Top Tags section in the editor. I thought you were already using tags in your collection. In any case, tags are free text, you can add any text as a tag.

If you don't have existing tags

No manual ones, no. I was hoping to be able using the location tags there when they're missing, so they also show up in the stats. I make heavy use of albums, though, so this is less about finding images :wink:

Yes, this is a test package. You can remove it.

I just uninstalled that test version from the FP2 and installed the full version from my repo. Starts up fine, but stays empty as if there were no images to show (~200 photos on that device). Rebooted the device, ran `adb logcat |egrep '(aves|flutter)', started Aves again – this is the aves.log created by that. Screen says "Collection loading", nothing happens. So I unfortunately cannot cross-check there (I can make a separate issue for that if you want – but the FP2 isn't really suited to run large Flutter apps, and gets replaced here soon™ with a SHIFTphone8 as soon as that's ready.
But back to the issue at hand: Let me know if I can do anything to help finding the culprit. If you e.g. have a way I could try to manually query the system's Nominatim (e.g. via ADB, or a small sample app), or a version producing the relevant debug output, I could do that.

I was hoping to be able using the location tags there when they're missing

Ah, I see. This is actually a good idea. I'll try and think how I can make that possible in the future.

But back to the issue at hand: Let me know if I can do anything to help finding the culprit. If you e.g. have a way I could try to manually query the system's Nominatim (e.g. via ADB, or a small sample app), or a version producing the relevant debug output, I could do that.

Sure. I'll try when I find the time.

Yes please, with the additional info from the instructions in About > Bug Report.

Will do. A wish at that place: would be good if step 2 could also be saved directly to a file instead of just to the clipboard. If one doesn't have a text editor on the device, it's a bit tricky to get those details to the PC one does the "browser stuff" in (I don't use Github etc. from my mobile devices). On the FP2 I have no editor… OK, managed to install one (had to reboot for that for some reason, time my new device arrives). Created #1022 for this.
Thanks a lot!

@IzzySoft I've made a simple app to test the geocoder on your device:
https://drive.google.com/file/d/1g6SUIyPGrccTcgdhEzPh3F9xEccdYLgq/view?usp=sharing
Could you please try it?

open the app,
press "get address",
you should see 1 or 2 addresses, somewhere in Firenze.

Apologies again: I usually do not take that long to respond, but closing for "no response" after just 2 weeks is a bit … err … unlucky when the question was raised just in the 1st week of a 3 week vacation :see_no_evil:
Same as with the other issue: I probably can test next week if you still want me to. Just let me know.

No worries, I do not mind closing and reopening issues. When an issue like this is very much dependent on OP environment, I close it if OP is no longer available/responsive/interested.
Same as the other issue: if the issue is still a problem for you, we can push the investigation. Otherwise let's forget about it.


New utility: make_domsub_script.py

It is common for distribution package builds to start with a pristine (upstream) source tarball, and apply one or more patches to the source before compiling it. The u-c patches fit into this scheme nicely. However, the domain-substitution step requires not only the domain_substitution.py script, but also the various Python bits it depends on, a file with the list of files to operate on, and a file with the regexes. As a result, you need to include a non-trivial portion of the u-c tree with the rest of the distro build files/patches in order to perform that step.
My first thought on eliminating that dependency was to generate a patch that applies statically the same domain substitutions that the script applies dynamically. But as it happens, this patch is about 34 MB in size. No one will want to review that!
So instead, I put together this utility, which will generate a self-contained script that performs the domain substitution. (It also saves the original files in a .tar file, to allow easy reversion.) This script is only about 680 KB in size, and most of that is just the list of files. It can be easily integrated into a package build process, and reviewing it is a breeze.
The generated script uses Bourne shell and Perl, and looks like this:
#!/bin/sh -e
#
# This script performs domain substitution on the Chromium source files.
#
# Generated by make_domsub_script.py, part of the ungoogled-chromium project:
# https://github.com/ungoogled-software/ungoogled-chromium.git
#

# Check that we are inside the Chromium source tree
test -f build/config/compiler/BUILD.gn

# These filenames may contain spaces and/or other unusual characters
print_file_list() {
        cat <<'__END__'
BUILD.gn
PRESUBMIT.py
PRESUBMIT_test.py
ash/accelerators/accelerator_notifications.cc
ash/ambient/ambient_controller_unittest.cc
ash/ambient/backdrop/ambient_backend_controller_impl.cc
[... >10K-line-long list of files elided ...]
weblayer/browser/prefetch_browsertest.cc
weblayer/browser/weblayer_security_blocking_page_factory.cc
weblayer/browser/weblayer_variations_http_browsertest.cc
weblayer/public/prerender_controller.h
weblayer/shell/app/shell_main_params.cc
__END__
}

echo "Creating backup archive ..."

backup=domain-substitution.orig.tar
print_file_list | tar cf $backup --verbatim-files-from --files-from=-

echo "Applying ungoogled-chromium domain substitution to 11114 files ..."

print_file_list | xargs -d '\n' perl -0777 -C0 -pwi -e '
    s#fonts(\\*?)\.googleapis(\\*?)\.com#f0ntz${1}.9oo91e8p1${2}.qjz9zk#g;
    s#google([A-Za-z\-]*?\\*?)\.com(?!mon)#9oo91e${1}.qjz9zk#g;
    s#gstatic([A-Za-z\-]*?\\*?)\.com#95tat1c${1}.qjz9zk#g;
[... more regexes ...]
    s#(?<!http://schemas.)android(\\*?)\.com#8n6r01d${1}.qjz9zk#g;
    s#goo\.gl(e?)#goo.gl${1}.qjz9zk#g;
    s#privacysandbox([A-Za-z\-]*?\\*?)\.com#pr1v4cy54ndb0x${1}.qjz9zk#g;
'

# end

python3 -m yapf --style '.style.yapf' -e '*/third_party/*' -rpd utils
--- utils/make_domsub_script.py	(original)
+++ utils/make_domsub_script.py	(reformatted)
@@ -85,8 +85,7 @@
     parser = argparse.ArgumentParser()
     parser.set_defaults(callback=_callback)

-    parser.add_argument(
-        '-r', '--regex', type=Path, required=True, help='Path to domain_regex.list')
+    parser.add_argument('-r', '--regex', type=Path, required=True, help='Path to domain_regex.list')
     parser.add_argument(
         '-f', '--files', type=Path, required=True, help='Path to domain_substitution.list')
     parser.add_argument(

Uh... do you want me to make this edit? It'll make the line stick out like a sore thumb, IMO.

Tweaked the here-doc quoting, thanks to some third-party feedback.

Maybe mention this utility in /docs/building.md?

I'm happy to add some verbiage for the new script, but since the process described in building.md relies heavily on the various u-c scripts, introducing one with the goal of not needing said scripts seems at odds with the context. Is there a particular approach you have in mind for the mention?
(What I'm doing might motivate a new "Building ungoogled-chromium for packagers" section/document, since---at least in the Debian-package scenario---the process is necessarily different.)

Okay, I've applied that edit.
This script is aimed at a somewhat different audience from the one directly targeted by the u-c docs---more to those who want to prepare u-c packages for others, rather than for their own consumption, and thus need to follow an existing, established workflow for package preparation. The documented process for building u-c is an awkward fit at best in that context, given the bulk of the tooling required. The script generated by this script is intended to be equivalent to a patch (which most packaging workflows already handle natively), only being a script due to practical considerations.
As long as u-c remains in principle a modification of upstream Chromium rather than a project with its own independent codebase, as long as distribution-package builds follow a "start with original source, apply patches, compile" approach to managing their upstreams, I think this script will be broadly useful to that audience. My long-term hope is that ungoogled-chromium will eventually be accepted into the package repos of popular distributions, and giving love to packagers will help bring that about.

So is it acceptable for core repo or should it go into contrib? @Ahrotahn @networkException

I don't mind it being in here

Thanks @iskunk

Thanks everyone, I felt this was the right place for the new script. I have some further work that builds on this, and differs in being decidedly distro-specific, so not appropriate here. Please have a look at the new issue I've opened in the contrib repo.


[SCB-864] Add SQLTransport and JacksonSQLFormat

Add SQLTransport in saga-core and add JacksonSQLFormat in saga-format

Coverage decreased (-0.2%) to 93.708% when pulling 85341a149fa1425d5021142efe883e3d2be93470 on KomachiSion:SCB-864 into 6dee5988235181f3b0c90c99b0dc1a73d6b612f7 on apache:master.


NP v1.9.1 - Missing Netherite Trident Recipe

There doesn't appear to be a recipe (Smithing Table or otherwise) in NP v1.9.1 for the Netherite Trident.
Only tested in MC v1.16.1 (Fabric Loader 0.92, Fabric API v1.17.0).

Yes. I noticed this and it's already fixed for the next update.


BEWARE: current main may break

I've just refactored a lot of the code and things have been moved around. I have tested the core functionality, but there may be edge cases that break. The version tagged version-1.10 should be stable, and you should use that until full testing on main is complete.

For me "version-1.10" shows a strange error:
`* Initializing, be patient...
Traceback (most recent call last):
File "scripts\dream.py", line 428, in
main()
File "scripts\dream.py", line 55, in main
t2i = T2I(width=width,
TypeError: init() got an unexpected keyword argument 'embedding_path'
`
How do I properly "update" to the new version?

I'm having the exact same issue. "Embedding path."
Traceback (most recent call last):
File "scripts/dream.py", line 289, in
main()
File "scripts/dream.py", line 43, in main
t2i = T2I(width=width,
TypeError: init() got an unexpected keyword argument 'embedding_path'

@Ratinod @csunberry Besides updating the repo you might need to do a pip install -e .. This error occurs due to the version of ldm/simplet2i.py installed on your guys' systems being incompatible with the current version of scripts/dream.py.

@lstein Listing the repo itself as a dependency and installing (which the base repo introduced) it is not a great idea imo. Maybe doing sys.path.append("..") in dream.py could replace that? I didn't test whether that works though.

@lstein; Will you PTAL @ https://github.com/lstein/stable-diffusion/discussions/76 ?

Are you guys running "conda env update -f environment.yaml" ? It ends with a line that is supposed to run "pip install -e ."  This wasn't my design decision - it was like that in the base.
I've played with adding sys.path.append('.') and sys.path.append('..') in the main script, but this seems to have different effects on different platforms. I'm a novice python programmer (old time C, java and perl programmer) and it shows. So any advice on how to package this right will be taken with great gratitude.

@lstein For now I think it should be specified that you should update your conda env after updating the repo and that in a well visible place (like as a first section in the readme).

Ok. "conda env update -f environment.yaml" just stuck on "Installing pip dependencies: " (more than 40 minutes)
But "pip install -e ." solves the problem.

I was able to update the env, and I have used pip install -e previously, but now, when I use that, it just spits out some weird...error about requiring 1 argument.
Also, the dream web server works fine.
@lstein Thank you, too. I did update the environment and it downloaded something. Still the same error but hey, the web dream server works.

@csunberry it needs an argument. The . is important, it basically means "current directory". So pip install -e . installs the current directory as a package,

@csunberry it needs an argument. The . is important, it basically means "current directory". So pip install -e . installs the current directory as a package.

Omg. I knew I was missing something but my thick skull couldn't recall what I was missing.
Good heavens, I should stop while I'm ahead. I should be glad my head is even on!
Thank you!!

FTR: pip install -e . "installs" the current directory (assuming that it's something which 'pip' can understand) in "developer mode".
This means that the repo acts as though it were fully installed into the system (or virtual environment, or whatever), but it is actually still "live", so that any changes you make to any files in the repo are used immediately (obviously anything which is running must be restarted).
IOW, if you make local changes, or sync new changes from master, you shouldn't have to re-pip.
What's happened here recently was the business involving dependencies moving from being installed in the repo, to being submodules, to being normal pip-installed dependencies. THOSE kinds of changes will definitely break things 😁

What's happened here recently was the business involving dependencies moving from being installed in the repo, to being submodules, to being normal pip-installed dependencies. THOSE kinds of changes will definitely break things 😁

And broken, twas it. Makes sense.
"Requirement already satisfied: torch in c:\users\sun\anaconda3\envs\ldm\lib\site-packages (from latent-diffusion==0.0.1) (1.11.0)
Requirement already satisfied: numpy in c:\users\sun\anaconda3\envs\ldm\lib\site-packages (from latent-diffusion==0.0.1) (1.23.2)
Requirement already satisfied: tqdm in c:\users\sun\anaconda3\envs\ldm\lib\site-packages (from latent-diffusion==0.0.1) (4.64.0)
Requirement already satisfied: typing_extensions in c:\users\sun\anaconda3\envs\ldm\lib\site-packages (from torch->latent-diffusion==0.0.1) (4.3.0)
Requirement already satisfied: colorama in c:\users\sun\anaconda3\envs\ldm\lib\site-packages (from tqdm->latent-diffusion==0.0.1) (0.4.5)
Installing collected packages: latent-diffusion
Attempting uninstall: latent-diffusion
Found existing installation: latent-diffusion 0.0.1
Uninstalling latent-diffusion-0.0.1:
Successfully uninstalled latent-diffusion-0.0.1
Running setup.py develop for latent-diffusion
Successfully installed latent-diffusion"
And break. Broken. Not installed. So many things of randomly not installed somehow. It's like a game. A game of finding what didn't install.

I sure did!

@csunberry; If you're up for acting as a test subject, I have a gist with much simplified Windows installation instructions.
You will need to remove all conda environments, delete your existing repo clone, uninstall Miniconda/Anaconda (and possibly other things I can't think of right now...) - you want as much of a blank slate as you can get.


Update code owners for streaming_correlations.py

Description
Update code owners to reflect https://github.com/tensorflow/addons/pull/2741

@bhack I guess this PR will fix the CI error.
/cc @sorensenjs


About querying messages sent by itself.

In findMessages, enableConversationId must ensure that senderIds and targetIds are not empty, but when senderIds and targetIds are not empty, only the query with CONVERSATION_ID condition is added. Therefore, it is impossible to query the messages sent by itself.

Querying messages sent by oneself isn't supported currently. I will adapt the workflow for the feature this weekend and write docs for it.

@IT-Pianist The feature has been delivered, and you can use the feature via the config turms.service.message.use-conversation-id=true.
And you can query the messages (including the messages sent by oneself) in private conversations by turmsClient.messageService.queryMessages({areGroupMessages: false, fromIds: [10,11,12]}), for example.


vitest --ui throws error

Describe the bug
Running vitest --ui throws React error:
Uncaught SyntaxError: The requested module '/node_modules/react/index.js' does not provide an export named 'useState'
Reproduction

versions 0.22.1 of both libraries.
using Typescript
run vitest --ui

System Info
System:
    OS: macOS 12.3
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.02 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.16.0 - /usr/local/bin/node
    Yarn: 1.22.0 - ~/.yarn/bin/yarn
    npm: 8.11.0 - /usr/local/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 104.0.5112.101
    Safari: 15.4
  npmPackages:
    @vitejs/plugin-react: ^2.0.1 => 2.0.1
    vite: ^3.0.7 => 3.0.8
    vitest: 0.22.1 => 0.22.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi, can you please provide a code reproduction because i wasn't able to reproduce it.