Client Integration Tests don't run

Hello!
I am not sure if the problem is related to Velocity or Jasmine (or both), but I just can't solve it and look forward to your help.
I have a fresh installation of Ubuntu 14.04 LTS with node v0.10.25, npm 1.3.10 and PhantomJS 2.1.1.
To isolate the problem I simply try to run official velocity examples. This one to be exact: https://github.com/meteor-velocity/velocity-examples/tree/master/leaderboard-jasmine
I run JASMINE_BROWSER=PhantomJS DEBUG=1 JASMINE_DEBUG=1 VELOCITY_DEBUG=1 VELOCITY_DEBUG_MIRROR=1 meteor run --test --verbose, it goes through client unit tests, server unit tests, server integration tests and just hangs on client integration tests.
This is a log:
team@ubuntu:~/velocity-examples/leaderboard-jasmine$ JASMINE_BROWSER=PhantomJS DEBUG=1 JASMINE_DEBUG=1 VELOCITY_DEBUG=1 VELOCITY_DEBUG_MIRROR=1 meteor run --test --verbose
% Parsing the --port option
stream error Network error: ws://localhost:3000/websocket: connect ECONNREFUSED
=> Meteor 1.2.1 is available. Update this project with 'meteor update'.
Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>Local package version is up-to-date<EMAIL_ADDRESS>I20160327-00:54:14.818(3)? ** You've set up some data subscriptions with Meteor.publish(), but
I20160327-00:54:14.819(3)? ** you still have autopublish turned on. Because autopublish is still
I20160327-00:54:14.820(3)? ** on, your Meteor.publish() calls won't have much effect. All data
I20160327-00:54:14.820(3)? ** will still be sent to all clients.
I20160327-00:54:14.820(3)? **
I20160327-00:54:14.820(3)? ** Turn off autopublish by removing the autopublish package:
I20160327-00:54:14.820(3)? **
I20160327-00:54:14.820(3)? **   $ meteor remove autopublish
I20160327-00:54:14.821(3)? **
I20160327-00:54:14.821(3)? ** .. and make sure you have Meteor.publish() and Meteor.subscribe() calls
I20160327-00:54:14.821(3)? ** for each collection that you want clients to see.
I20160327-00:54:14.821(3)?
I20160327-00:54:14.822(3)? [velocity] adding velocity core
I20160327-00:54:14.822(3)? [velocity] Not adding mirror-registrar because NODE_ENV is development and IS_MIRROR is false
I20160327-00:54:14.904(3)? [velocity] Register framework jasmine-server-integration with regex ^tests/jasmine/server/integration/.+\.(js|coffee|litcoffee|coffee\.md)$
I20160327-00:54:14.905(3)? [sanjo:jasmine]: Starting mirror for jasmine-server-integration
I20160327-00:54:14.905(3)? [velocity] Register framework jasmine-client-integration with regex ^tests/jasmine/client/integration/.+\.(js|coffee|litcoffee|coffee\.md)$
I20160327-00:54:14.905(3)? [sanjo:jasmine]: Starting mirror for jasmine-client-integration
I20160327-00:54:14.905(3)? [velocity] Register framework jasmine-client-unit with regex ^tests/jasmine/client/unit/.+\.(js|coffee|litcoffee|coffee\.md)$
I20160327-00:54:14.905(3)? [velocity] Velocity not started. Queueing func
I20160327-00:54:14.905(3)? [velocity] Register framework jasmine-server-unit with regex ^tests/jasmine/server/unit/.+\.(js|coffee|litcoffee|coffee\.md)$
I20160327-00:54:14.906(3)? [velocity] Velocity not started. Queueing func
I20160327-00:54:14.906(3)? [velocity] Server startup
I20160327-00:54:14.906(3)? [velocity] app dir /home/team/velocity-examples/leaderboard-jasmine
I20160327-00:54:14.906(3)? [velocity] config = {
I20160327-00:54:14.906(3)?   "jasmine-server-integration": {
I20160327-00:54:14.906(3)?     "regex": "^tests/jasmine/server/integration/.+\\.(js|coffee|litcoffee|coffee\\.md)$",
I20160327-00:54:14.907(3)?     "name": "jasmine-server-integration",
I20160327-00:54:14.907(3)?     "_regexp": {}
I20160327-00:54:14.907(3)?   },
I20160327-00:54:14.907(3)?   "jasmine-client-integration": {
I20160327-00:54:14.907(3)?     "regex": "^tests/jasmine/client/integration/.+\\.(js|coffee|litcoffee|coffee\\.md)$",
I20160327-00:54:14.908(3)?     "name": "jasmine-client-integration",
I20160327-00:54:14.908(3)?     "_regexp": {}
I20160327-00:54:14.908(3)?   },
I20160327-00:54:14.908(3)?   "jasmine-client-unit": {
I20160327-00:54:14.908(3)?     "regex": "^tests/jasmine/client/unit/.+\\.(js|coffee|litcoffee|coffee\\.md)$",
I20160327-00:54:14.908(3)?     "name": "jasmine-client-unit",
I20160327-00:54:14.908(3)?     "_regexp": {}
I20160327-00:54:14.909(3)?   },
I20160327-00:54:14.909(3)?   "jasmine-server-unit": {
I20160327-00:54:14.909(3)?     "regex": "^tests/jasmine/server/unit/.+\\.(js|coffee|litcoffee|coffee\\.md)$",
I20160327-00:54:14.909(3)?     "name": "jasmine-server-unit",
I20160327-00:54:14.909(3)?     "_regexp": {}
I20160327-00:54:14.909(3)?   }
I20160327-00:54:14.910(3)? }
I20160327-00:54:14.990(3)? [velocity] resetting the world
I20160327-00:54:14.990(3)? [velocity] frameworks with disable auto reset: []
I20160327-00:54:14.990(3)? [velocity] Add paths to watcher [ '/home/team/velocity-examples/leaderboard-jasmine/tests' ]
I20160327-00:54:15.013(3)? [velocity] Search framework for path tests/jasmine/client/integration/LeaderboardSpec.js
I20160327-00:54:15.013(3)? [velocity] Target framework for tests/jasmine/client/integration/LeaderboardSpec.js is jasmine-client-integration
I20160327-00:54:15.013(3)? [velocity] Search framework for path tests/jasmine/client/unit/PlayersServiceSpec.js
I20160327-00:54:15.014(3)? [velocity] Target framework for tests/jasmine/client/unit/PlayersServiceSpec.js is jasmine-client-unit
I20160327-00:54:15.014(3)? [velocity] Search framework for path tests/jasmine/server/integration/PlayersSpec.js
I20160327-00:54:15.014(3)? [velocity] Target framework for tests/jasmine/server/integration/PlayersSpec.js is jasmine-server-integration
I20160327-00:54:15.014(3)? [velocity] Search framework for path tests/jasmine/server/unit/PlayersServiceSpec.js
I20160327-00:54:15.014(3)? [velocity] Target framework for tests/jasmine/server/unit/PlayersServiceSpec.js is jasmine-server-unit
I20160327-00:54:15.014(3)? [velocity] Search framework for path tests/jasmine/server/unit/package-stubs.js
I20160327-00:54:15.020(3)? [velocity] Target framework for tests/jasmine/server/unit/package-stubs.js is jasmine-server-unit
I20160327-00:54:15.020(3)? [velocity] Search framework for path tests/jasmine/server/unit/packageMocksSpec.js
I20160327-00:54:15.020(3)? [velocity] Target framework for tests/jasmine/server/unit/packageMocksSpec.js is jasmine-server-unit
I20160327-00:54:15.020(3)? [velocity] File scan complete, now watching /tests
I20160327-00:54:15.020(3)? [velocity] Triggering queued startup functions
I20160327-00:54:15.020(3)? [velocity] 1 mirror(s) requested
I20160327-00:54:15.021(3)? [velocity] 1 mirror(s) requested
I20160327-00:54:15.054(3)? [velocity] Mirror process forked with pid 1769
I20160327-00:54:15.054(3)? [velocity] jasmine-server-integration is starting a mirror at http://localhost:47660/.
I20160327-00:54:15.054(3)? [velocity] Mirror process forked with pid 1771
I20160327-00:54:15.055(3)? [velocity] jasmine-client-integration is starting a mirror at http://localhost:38000/.
I20160327-00:54:15.055(3)? [velocity] You can see the mirror logs at: tail -f /home/team/velocity-examples/leaderboard-jasmine/.meteor/local/log/jasmine-server-integration.log
I20160327-00:54:15.064(3)? [velocity] You can see the mirror logs at: tail -f /home/team/velocity-examples/leaderboard-jasmine/.meteor/local/log/jasmine-client-integration.log
W20160327-00:54:15.305(3)? (STDERR) connections property is deprecated. Use getConnections() method
W20160327-00:54:15.325(3)? (STDERR) Could not mock the export WebAppInternals of the package webapp. Will continue anyway.
I20160327-00:54:15.466(3)? [velocity] File changed: tests/jasmine/server/unit/package-stubs.js
I20160327-00:54:15.491(3)? [velocity] File changed: tests/jasmine/server/unit/packageMocksSpec.js
I20160327-00:54:15.525(3)? [sanjo:jasmine]: loading mock file: /home/team/velocity-examples/leaderboard-jasmine/tests/jasmine/server/unit/package-stubs.js
I20160327-00:54:15.525(3)? [sanjo:jasmine]: loading source file: /home/team/velocity-examples/leaderboard-jasmine/tests/jasmine/server/unit/package-stubs.js
I20160327-00:54:15.568(3)? [sanjo:jasmine]: getFiles has found the following files [ 'leaderboard.js' ]
I20160327-00:54:15.569(3)? [sanjo:jasmine]: loadFiles [ 'leaderboard.js' ]
I20160327-00:54:15.570(3)? [sanjo:jasmine]: loading source file: /home/team/velocity-examples/leaderboard-jasmine/leaderboard.js
I20160327-00:54:15.578(3)? [sanjo:jasmine]: loading source file: /home/team/velocity-examples/leaderboard-jasmine/tests/jasmine/server/unit/PlayersServiceSpec.js
I20160327-00:54:15.581(3)? [sanjo:jasmine]: loading source file: /home/team/velocity-examples/leaderboard-jasmine/tests/jasmine/server/unit/package-stubs.js
I20160327-00:54:15.604(3)? [sanjo:jasmine]: loading source file: /home/team/velocity-examples/leaderboard-jasmine/tests/jasmine/server/unit/packageMocksSpec.js
PASSED jasmine-server-unit : getPlayerList:PlayersService => PlayersService getPlayerList should ask for the players in primarily in descending score order, then in alphabetical order and return them
PASSED jasmine-server-unit : getPlayer:PlayersService => PlayersService getPlayer should ask for the player with the given id and return it
PASSED jasmine-server-unit : rewardPlayer:PlayersService => PlayersService rewardPlayer should add 5 points to the player score with the given id
PASSED jasmine-server-unit : playersExist:PlayersService => PlayersService playersExist should return true when players exist
PASSED jasmine-server-unit : playersExist:PlayersService => PlayersService playersExist should return false when no players exist
PASSED jasmine-client-unit : getPlayerList:PlayersService => PlayersService getPlayerList should ask for the players in primarily in descending score order, then in alphabetical order and return them
PASSED jasmine-client-unit : getPlayer:PlayersService => PlayersService getPlayer should ask for the player with the given id and return it
PASSED jasmine-client-unit : rewardPlayer:PlayersService => PlayersService rewardPlayer should add 5 points to the player score with the given id
PASSED jasmine-client-unit : playersExist:PlayersService => PlayersService playersExist should return true when players exist
PASSED jasmine-client-unit : playersExist:PlayersService => PlayersService playersExist should return false when no players exist
I20160327-00:54:25.365(3)? [velocity] Mirror registered. Handshaking with mirror...
I20160327-00:54:25.396(3)? [velocity] Connected to mirror, setting state to ready { framework: 'jasmine-client-integration',
I20160327-00:54:25.396(3)?   port: '38000',
I20160327-00:54:25.396(3)?   host: 'http://localhost:38000/' }
I20160327-00:54:26.082(3)? [velocity] Mirror registered. Handshaking with mirror...
I20160327-00:54:26.104(3)? [velocity] Connected to mirror, setting state to ready { framework: 'jasmine-server-integration',
I20160327-00:54:26.104(3)?   port: '47660',
I20160327-00:54:26.104(3)?   host: 'http://localhost:47660/' }
PASSED jasmine-server-integration : Collection: Players => Collection: Players some players are available in the collection

This is a log from client mirror:
team@ubuntu:~$ tail -f /home/team/velocity-examples/leaderboard-jasmine/.meteor/local/log/jasmine-client-integration.log
I20160327-00:54:25.283(3)?
I20160327-00:54:25.283(3)? [velocity] Mirror detected - Not adding velocity core
I20160327-00:54:25.283(3)? [velocity] Not adding mirror-registry because NODE_ENV is development  and IS_MIRROR is true
I20160327-00:54:25.283(3)? [velocity] Starting mirror on port 38000
=> Started your app.

=> App running at: http://localhost:38000/
I20160327-00:54:25.340(3)? [velocity] Mirror started. Connecting via DDP to parent
I20160327-00:54:25.360(3)? [velocity] Mirror connected to parent. Registering mirror...
I20160327-00:54:25.415(3)? [velocity] Established connection with Velocity.

By the way, on my laptop with MacOS (node v0.10.36, phantomjs 2.1.1) everything works like a charm.
This is just a part of typical log:
PASSED jasmine-client-unit : getPlayer:PlayersService => PlayersService getPlayer should ask for the player with the given id and return it
PASSED jasmine-client-unit : rewardPlayer:PlayersService => PlayersService rewardPlayer should add 5 points to the player score with the given id
PASSED jasmine-client-unit : playersExist:PlayersService => PlayersService playersExist should return true when players exist
PASSED jasmine-client-unit : playersExist:PlayersService => PlayersService playersExist should return false when no players exist
I20160327-01:00:35.778(3)? [velocity] Mirror registered. Handshaking with mirror...
I20160327-01:00:35.846(3)? [velocity] Connected to mirror, setting state to ready { framework: 'jasmine-server-integration',
I20160327-01:00:35.847(3)?   port: '59915',
I20160327-01:00:35.847(3)?   host: 'http://localhost:59915/' }
PASSED jasmine-server-integration : Collection: Players => Collection: Players some players are available in the collection
I20160327-01:00:36.756(3)? [velocity] Mirror registered. Handshaking with mirror...
I20160327-01:00:36.781(3)? [velocity] Connected to mirror, setting state to ready { framework: 'jasmine-client-integration',
I20160327-01:00:36.781(3)?   port: '59916',
I20160327-01:00:36.782(3)?   host: 'http://localhost:59916/' }
PASSED jasmine-client-integration : Selecting Grace Hopper => Selecting Grace Hopper should show Grace above the give points button
PASSED jasmine-client-integration : Selecting Grace Hopper => Selecting Grace Hopper should highlight Grace's name
PASSED jasmine-client-integration : Point Assignment => Point Assignment should give a player 5 points when he is selected and the button is pressed
PASSED jasmine-client-integration : Player Ordering => Player Ordering should result in a list where the first player has as many or more points than the second player
TESTS RAN SUCCESSFULLY

And for the mirror:
=> App running at: http://localhost:59916/
I20160327-01:00:36.735(3)? [velocity] Mirror started. Connecting via DDP to parent
I20160327-01:00:36.751(3)? [velocity] Mirror connected to parent. Registering mirror...
I20160327-01:00:36.798(3)? [velocity] Established connection with Velocity.
Parent process is dead! Exiting.

I've lost a lot of time trying to solve this and would appreciate any help.
Thanks in advance.

With Meteor 1.3 there will be a new version that will use the new testing API, so I won't look at this issue, because Meteor 1.3 will be release next week.

To run the client integration tests, you need to open the app page.


SVProgressHUD appearance not working in 2.0 beta version

So I was using version 1.3, and set background color with
[SVProgressHUD setBackgroundColor:[[UIColor blackColor] colorWithAlphaComponent:0.5]];
And everything worked fine.
After update to 2.0, I tried to set it with [SVProgressHUD appearance] and it is not working.
Actually, first method is not working either.

have you set SVProgressHUDStyleCustom?

Sorry. My bad. I haven't done this step

No problem, you are welcome. If you have any other questions keep me updated.


setOptions autoScroll to false scrolls to beginning

Bug description
When setting autoScroll to false with setOptions, the view scrolls to the beginning of the audio
Environment

Browser: Chrome

Minimal code snippet
Easy to test by just adding a checkbox for autoScroll in the zoom demo
Expected result
Auto scroll is disabled and the view does not scroll
Obtained result
Auto scroll is disabled and view scrolls to the beginning of the audio.
Screenshots

The same happens when zooming. When zooming with playback paused, the view scrolls to the beginning, even with autoCenter enabled. In my opinion, the intuitive behaviour would be to zoom into the current view position.

I agree. Please feel free to work on it, I'm there for any questions.

It seems that evertime reRender is called, the position is set to the beginning. However I'm lost on why this happens. The code in reRender looks good for adjusting the view back to the cursor assuming the view was at the cursor. This might not work, when we the view is not at the cursor to begin with, but does not explain why it jumps to the beginning. I could not find anything else where the scrollposition is changed during rerendering.
For now I just added
const { scrollLeft, scrollWidth, clientWidth } = wavesurfer.renderer.scrollContainer
const curentRelPos = (scrollLeft + clientWidth * 0.5) / scrollWidth
before zooming and
wavesurfer.renderer.scrollContainer.scrollLeft = curentRelPos * wavesurfer.renderer.scrollContainer.scrollWidth - clientWidth / 2
after zooming

However as I understand the renderChannel method, it starts rendering at the current scroll position. So with my quick fix on my side it still always starts rendering at the beginning. So when changing the scroll after rendering back to the previous position it takes quite some time to render at that position if that position is at a late position of a longer audio. This is related to #3193 and makes this feel very unresponsive.

I think it might be jumping because it deletes all the canvases, so there's no scroll until it renders new canvases? Not sure if the wrapper has a width.

Unfortunately this question is beyond my very limited Javascript skills


Pasting text takes a long time to appear in chat box.

My Setup

__My OS name and version : Fedora 25
My current app version: 2.2.2

[X] I have tested with the latest application version
[X] I can simulate the issue easily

Description

When text is pasted into the chat e.g. code greater than 5 lines it takes a long time for it to load and appear. This makes it look like the client has hung when in fact it hasn't. This was reported by many of my colleagues who can also replicate this issue.
Current Behavior
Takes a long time to paste text to chat.

Expected Behavior

Should not take the length of time it does, even with node being single threaded etc.

Same problem.
2.2.1

Same issue here on F25 with rocket chat 2.3

I have the same issue running version 2.2.0

+1

Same on Win7


UI: False alarm on limited node redundancy for failed replica

A failed replica was considered healthy somehow in the node redundancy calculation.
To reproduce

Create a volume and attach it to a node
Use kubectl -n longhorn-system delete pod <any volume replica pod>
The replica would become faulted and Longhorn started rebuilding to the same node failed replica is, but limited node redundancy icon would be shown for the volume.

Fixed.


Fixed a small typo that pointed to a broken link

There's a broken link in the weave-loadbalance guide, b is close to g in the keyboard :)

@jjperezaguinaga thank you very much!


User interface to build workflows

Right now you have to be a developer to describe an Orchestra workflow.  The Flash Teams work, and more specifically, Foundry show that it's possible for end-users to utilize a Gantt chart-like interface for describing workflows and step dependencies.  For this to work in Orchestra, I'd imagine a few phases:

Create a workflow description language that's not in Python, say in JSON or a DSL.
Move workflows out of code and into the database with versions, so that we don't have to commit new code to update workflows
Create a Gantt chart-like interface for describing workflows.  If we can team up with the Foundry team to do this, all the better!

YAML DSL for readability and simplicity. JSON is consumable, but hard on the eyes.
Version control in SCM, such as Git, and treat as a project "manifest" or configuration that can be continuously tested and integrated. Consideration for runtime instantiation, so that v2 doesn't clobber v1 inadvertantly
Gantt is interesting, due to the project use cases, and presumably to avoid BPMN notation (ala http://activiti.org/ et al)


Deleted primary bitstream still referenced in the bundle

Describe the bug
Primary Bitstreams are used for Access Status calculations, but when the that bitstream is deleted, the bundle primary bitstream reference isn't changed. So, Access Status calculations will return wrong status.
To Reproduce
Steps to reproduce the behavior:

Create a new item
Upload several files into the item and fill the required data
Deposit the item
As an admin, Edit that Item and promote one bitstream to be Primary Bitstream (this will reference that bitstream at the bundle level)
Please take note of that bitstream's UUID
Delete that bitstream that we promote to primary
Check the database (please consider your UUID here):

SELECT * FROM bundle WHERE primary_bitstream_id='814aefff-4874-4a97-a7aa-b654172e7a40'

Expected behavior
Apparently nothing changes, but the deleted bitstream is still referenced as that bundle primary bitstream. It's hoped that, when a bitstream is deleted, also that bundle's primary bitstream reference is also removed. This issue is also present in older DSpace versions (like 5.X).

This would require a database change imho as we should have a foreign key in the bundle table to force the primary_bitstream_id column to reference an existing row in the bitstream table. Moreover we need a sql script to cleanup inconsistent data before to apply to constraint. This seems to force us to target this fix for DSpace 8.
If we want to fix it in the 7.x maintenance branch we should avoid the database change and perform this extra step in the dspace 8 fix, do you agree @tdonohue ?

@abollini : If we made this fix via a database change, then I agree that would need to wait for 8.0.  We want to avoid DB changes in bug fix releases unless absolutely required.
However, I see that @paulo-graca has a draft PR that doesn't involve a database change.  Instead, he just unsets the primary bitstream if deleted: #9106   That seems like it could qualify for a bug fix release, as it's fixing code behavior (and it seems to be a possible one line fix -- although it's unclear if the proposed fix works yet)

Sorry, I'm still working on it. I've had mini vacations last week (it was a National holiday here). I didn't had the time to make more progresses.
I would do that (I was planning to do that). We are also interested in cleaning this issue from current records. I will create a migration script/sql to fix old referenced deleted bitstreams and we will also enforce the relation with that constraint.
Aside: @abollini Initially when I start reading your comment I was thinking you were suggesting a different thing, like to handle primary bitstream in another way. And that make me think that we could have primary bitstreams at  bundle2bitstream (boolean field) that could eliminate this issue, but it has some pros and cons and would require a lot more effort and that would definitely be marked as 8.0.

I want to mention that this issue is related to this long-standing issue: https://github.com/DSpace/DSpace/issues/7348
The foreign key in the bundle table already exists but when a bitstream is deleted it is actually a logical delete (they are marked as deleted). The table row is actually deleted afterwards, using the cleanup script and this could produce the exception reported in #7348
Fixing this bug will surely fix #7348
@paulo-graca In case it helps, investigating #7348 I have seen that there are two functions to mark the bitstreams as deleted, one in the BundleService and another in the BitstreamService. The primary bitstream relation is cleared if the BundleService implementation is used but calling directly the BitstreamService implementation the primary bitstream relation is not cleared. It could be the problem, I think that the API call uses directly the BistreamService implementation. Could be a good idea to clear this relation also in the BitstreamService implementation.
https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/java/org/dspace/content/BundleServiceImpl.java#L214-L254
https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/java/org/dspace/content/BitstreamServiceImpl.java#L261-L287
https://github.com/DSpace/DSpace/blob/main/dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/patch/operation/BitstreamRemoveOperation.java#L58

@toniprieto thank you for your feedback!
I can confirm that currently we already have that constrain:
ALTER TABLE "public"."bundle"
	ADD CONSTRAINT "bundle_primary_bitstream_id_fkey" FOREIGN KEY ( "primary_bitstream_id" )
	REFERENCES "public"."bitstream" ( "uuid" ) MATCH SIMPLE
	ON DELETE No Action
	ON UPDATE No Action;


Have a schedule to push text to Transifex

Following this non answered discussion in mailing-list, I wonder if it might not be a good thing to have a schedule to push website texts to transifex, so that when Transifex shows 100% translated, it's most of the time really 100%.

@DelazJ you are probably right... I'm a little behind. I often did that when I was busy pushing a new version of the docs (when we were still building for every release).
I also did it when there was a new QGIS release, so the visual changelog etc were translatable...
Will push within upcoming days again. And bug me if I'm too slow, if you want it to be done earlier.

Just updated the website strings to transifex. Will do after the next QGIS release, OR just ask me to do this.

Yes, I see your changes. Thank you.
Wonder if this issue report shouldn't be kept open. Its purpose is to have a schedule, something formalized as we have for QGIS release. This will help to keep a really fully clean and translated website for the communities that care about and have texts  to propose to translators and keep them focused/concerned.
Of course, I'm not expecting it to be done now as you are alone on this if i'm not wrong. But maybe, as you suggested in ML, it's time for you to have a Padawan...


Update IPEX-LLM LLMs integration docs based on comments

https://github.com/langchain-ai/langchain/pull/22458#pullrequestreview-2258141389
May later rebase ipex-llm-llm-gpu to master first after single tests.

Merge to the upstream PR branch based on comments

Please let me know for any comments. Thank you :) @jason-dai


Why I'm stuck on add credit card screen.

Hi @yatatsu,
Why I'm stuck on add credit card screen, why I don't get token after this process, using the latest version of the package and the version of<EMAIL_ADDRESS>
and the code is:----

PayjpCore.init({
publicKey: PAY_JP_PUBLIC_KEY_TEST,
}).then(() => {
console.log('Prod',PAY_JP_PUBLIC_KEY_TEST);
}).catch((error) => {
console.error('Error initializing PayjpCore:', error);
});

onPressAddCard = () => {
PayjpCardForm.startCardForm()
}

const unsubscribePayjpForm = PayjpCardForm.onCardFormUpdate({
onCardFormProducedToken: async token => {
console.log('onCardFormProducedToken', token);
   return PayjpCardForm.completeCardForm()
 } catch (exception) {
   return PayjpCardForm.showTokenProcessingError('An error has occured')
 }

}
})

PayjpCore.init() this is working fine but I'm stuck here onCardFormUpdate

Hi @ramangupta1602
I’ve looked at your code and screenshots. Please check the following points:

Since the card form is displayed, it seems that PayjpCardForm.startCardForm() is working properly.
In that case, there might be an issue with the listener not being subscribed when creating the token.
Please verify if the return value of PayjpCardForm.onCardFormUpdate is being properly handled with hooks.
Make sure to set up a listener for cancellation, such as onCardFormCanceled, and check if it gets called when the card form is canceled.

thanks


routing: assume TLV onion feature bit

In this PR, we start assuming that hops on a path all support TLV onion encoding.
This PR is the bare minimum. It does not completely remove the Hop.LegacyPayload member since we do still use this for deserialising persisted Hops for an HTLC attempt. So there is a chance that we have some on disk. And since we do have cases where we assume hops only support legacy encoding (either we did not receive their node announcement or we received chained hop hints in an invoice) the chances of this being the case are not that small. So some discussion/thought is perhaps needed around how we can handle this.
The other thing we could potentially add to this PR is the removal of --protocol.legacy.onion
We already no longer read the TlvPayload boolean in SendToRouteReq.Hop so we could potentially remove this or warn the user if they are setting this to false that it is being ignored.
related issue: https://github.com/lightningnetwork/lnd/issues/8785

@yyforyongyu: review reminder

Tested with the test setup described in https://github.com/lightningnetwork/lnd/issues/8785, it fixes the issue.

awesome - thanks for testing @JssDWt 🚀


Make func easy to install and evoke from within CLI

Description:
There should be a relatively simple "happy path" to installing the func plugin.

Story
As Perry the Platform Admin
I want to install the func plugin
So that I can assess whether it is right for my needs

Acceptance Criteria

[ ] Perry can install using a binary

GIVEN I have the downloaded the binary for the func plugin
WHEN I place the the binary in the ~/.config/kn/plugins directory
THEN I can run `kn func` and see a help message

[ ] Perry can install using homebrew

GIVEN I have typed "brew install knative-sandbox/kn-plugins/func" into my CLI
WHEN I hit enter
THEN the operation succeeds without error
AND I can run `kn func` and see a help message

Known Issues and Considerations:
This issue may be dependent on https://github.com/knative/client/issues/1399

/help

/label MVP

@omerbensaadon I think this can be closed and considered complete. WDYT?
See: https://github.com/knative-sandbox/homebrew-kn-plugins

If you /lgtm #539


Upgrade from v21.12 to v23.05 - Settings "Page Not Found"

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
After upgrading from v21.12 to v23.05 I receive a "Page Not Found" error message when accessing the "Settings" page. I have ready through dozens of Github and internet articles. None I've found seem to address this issue.

I have no issue accessing other pages

I've updated the composer (Composer version 2.5.8 2023-06-09 17:13:21)
I've completed the php and system update steps related to the "v23.02 and higher" post

I've verified that no other PHP version is enabled and running most current. (Module php8.2 already enabled)
All steps using the update instructions complete without error.

 I'm unsure if it was build using the script or the github manual steps.

I should add. I've tried this upgrade path multiple over the past several months moving from v21.12 to 22.03, 22.04, 22.05, 22.08, 22.10. Always have the same issue with the Settings Page not found.

Thanks for the details @dilonbuser.

In regards to the log content shared, can you confirm if this message is logged when you cause the reported issue to appear? The error log messages are time-stamped. Just because that particular error does not really relate to code I'd expect to be used in the settings.
Can you provide the output of git status from your install directory, after updating to the latest version?
Can you confirm what webserver you're using and, if possible, provide the server config (redacted if needed). The 20.04 install script would use apache and create a config at /etc/apache2/sites-available/bookstack.conf.

Thanks for the details @dilonbuser.

In regards to the log content shared, can you confirm if this message is logged when you cause the reported issue to appear? The error log messages are time-stamped. Just because that particular error does not really relate to code I'd expect to be used in the settings.

Doing a tail on the log file, does not appear to be changed when I click on the settings link. I didn't know where it would like that so I put the log info that I thought may be pertinent.

Can you provide the output of git status from your install directory, after updating to the latest version?

cd /var/www/bookstack/
git status
fatal: detected dubious ownership in repository at '/var/www/bookstack'
To add an exception for this directory, call:
        git config --global --add safe.directory /var/www/bookstack

Can you confirm what webserver you're using and, if possible, provide the server config (redacted if needed). The 20.04 install script would use apache and create a config at /etc/apache2/sites-available/bookstack.conf.

We are using apache
cat /etc/apache2/sites-available/bookstack.conf
<VirtualHost *:80>
        Redirect / https://<SERVER REDACTED>/
</VirtualHost>
<VirtualHost *:443>
        ServerName <SERVER REDACTED>

        ServerAdmin webmaster@localhost
        DocumentRoot /var/www/bookstack/public/

        SSLEngine on
        SSLCertificateKeyFile /etc/apache2/ssl/server.key
        SSLCertificateFile /etc/apache2/ssl/wildcard.pem
        SSLProtocol -all +TLSv1.2
        Protocols h2 http/1.1
    <Directory /var/www/bookstack/public/>
        Options Indexes FollowSymLinks
        AllowOverride None
        Require all granted
        <IfModule mod_rewrite.c>
            <IfModule mod_negotiation.c>
                Options -MultiViews -Indexes
            </IfModule>

            RewriteEngine On

            # Handle Authorization Header
            RewriteCond %{HTTP:Authorization} .
            RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

            # Redirect Trailing Slashes If Not A Folder...
            RewriteCond %{REQUEST_FILENAME} !-d
            RewriteCond %{REQUEST_URI} (.+)/$
            RewriteRule ^ %1 [L,R=301]

            # Handle Front Controller...
            RewriteCond %{REQUEST_FILENAME} !-d
            RewriteCond %{REQUEST_FILENAME} !-f
            RewriteRule ^ index.php [L]
        </IfModule>
    </Directory>

        ErrorLog ${APACHE_LOG_DIR}/error.log
        CustomLog ${APACHE_LOG_DIR}/access.log combined

</VirtualHost>

@ssddanbrown not sure if you saw my response to your questions. What other information can I provide to help diagnose this issue? Thanks for your help on this.

Sorry @dilonbuser,

Can you run the suggested command in the previous output (git config --global --add safe.directory /var/www/bookstack) then run git status again and provide the output?
Can you share the output of running ls -alh /var/www/bookstack/bootstrap/cache?
Cat you share the output for runnning cat /var/www/bookstack/version?

Thanks @dilonbuser, Looks like someone ran an optimization/cache command back in March of 2022. Please delete the /var/www/bookstack/bootstrap/cache/routes-v7.php file.

That did it! I think that routes file was created accidentally when we were first working through the upgrade process.
Thank so much @ssddanbrown for your help. We are very excited to check out changes and improvements you've made since the v21.12 release!
Please close this issue.

Good to hear it's sorted! Will therefore close.


Change send button icon

There is any way of change the send button icon using the styleOptions?

Hi @david-minaya
It looks like styleOptions does provide a way of changing the send button's color:
  sendBoxButtonColor: undefined, // defaults to subtle
  sendBoxButtonColorOnDisabled: '#CCC',
  sendBoxButtonColorOnFocus: '#333',
  sendBoxButtonColorOnHover: '#333',

Does this resolve your issue?

No, I need to change the icon for another

@david-minaya , thank you for opening this issue.  For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework


Improve spread helper emit

Since __assign defaults to Object.assign if present, our own helper will never be used in ES6 and higher, and getOwnPropertySymbols is not needed in ES5 and below because symbols don't exist there.

@rbuckton here's the __assign improvement you suggested.

@sandersn Can you merge master now that #11874 and #12250 are in master?

Sure. Done.

The premise is not strictly true. Object.assign and Object.getOwnPropertySymbols may be polyfilled (one of them or both).
It's safer to feature-detect each on separately, rather than rely on presence of one as a clue to another.


Gas cost for SLOAD in debug_trace[Transaction|Call] different from RPCDaemon

Executing the debug_traceTransaction cal` using the following input
{
  "jsonrpc":"2.0",
  "method":"debug_traceTransaction",
  "params":[
     "0x41d7ffbe4fea1aadb614c9462863fd0761de14f5d83574922c13c6cbb3bc22c1",
     {
       "disableStorage": false,
       "disableMemory": false,
       "disableStack": false
     }
  ],
  "id":1
}

the silkrpc result differs from the rpcdaemon one in gas cost for SLOAD opcode (and then the gas cost is wrong for the next opcodes).
The same difference is present in debug_traceCall.

Fix in  https://github.com/torquem-ch/silkrpc/commit/3adeeea79a2dab7e8df158fce5783679ab6031a4


Develop migrate shared slice

migrate shared slice
remove all dispatch calls
remove all useDipsatch state variables
add some comments

Hi, I have reviewed this pr and found some problems, here is it:

On the Landing page, before you click any states it will show "Welcome to thenull Species Selector Tool"
For the Selector, the informationBar seems not working now, if you click any button other than NEXT, it will have an error to show an unknow route.
issue about myCropListLocation

To note: 2) the back and restart buttons do seem to work for me, but the different tabs are not working.

Error when i select any flooding chip.  The soil conditions are no longer being populated this was a recent fix.  ? @mikah Is it possible that isnt in develop yet?

When updating average precipitation in the first frost tab only one of the 2 fields will save at a time.  If you change one the other will return blank but will show the previous value with the label overtop.  The field will be blank when you click update. (this may have been a persisting bug)

the labels aren't showing up


os: inconsistent cross-platform behavior: os.OpenFile/os.Write*

What version of Go are you using (go version)?
go version go1.8.3 windows/amd64
go version go1.8.3 linux/amd64
What operating system and processor architecture are you using (go env)?
Skipping as the details are covered below.
What did you do?
In Windows, the following program will happily end up writing to the file with no issues.
package main

import "os"
import "fmt"

func main() {
	flag := os.O_CREATE
	file, err := os.OpenFile("test.log", flag, os.FileMode(0644))
	if err != nil {
		fmt.Println(err)
	}
	defer file.Close()
	n, err := file.WriteString("Hello")
	if err != nil {
		fmt.Println(err)
	}
	fmt.Printf("Written: %v\r\n", n)
	fmt.Println("Good-bye.")
}

However, in linux this will fail to write with a bad file descriptor error, since there's no write permission that's given. The os.O_RDWR/WRONLY is required during OpenFile for the write to succeed.
Possible solutions

Document it.
Do run time checks to ensure consistent behavior.

Or use os.Create which deals with these cross platform issues.
On Sun, 6 Aug 2017, 11:54 Prasanna V. Loganathar<EMAIL_ADDRESS>wrote:

What version of Go are you using (go version)?
go version go1.8.3 windows/amd64
go version go1.8.3 linux/amd64
What operating system and processor architecture are you using (go env)?
Skipping as the details are covered below.
What did you do?
In Windows, the following program will happily end up writing to the file
with no issues.
package main
import "os"
import "fmt"
func main() {
flag := os.O_CREATE
file, err := os.OpenFile("test.log", flag, os.FileMode(0644))
if err != nil {
fmt.Println(err)
}
defer file.Close()
n, err := file.WriteString("Hello")
if err != nil {
fmt.Println(err)
}
fmt.Printf("Written: %v\r\n", n)
fmt.Println("Good-bye.")
}
However, in linux this will fail to write with a bad file descriptor
error, since there's no write permission that's given. The
os.O_RDWR/WRONLY is required during OpenFile for the write to succeed.
Possible solutions

Document it.
Do run time checks to ensure consistent behavior.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/21322, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA2qI6hP5wI5er7hO7kgis-Rl6a9Tks5sVRzIgaJpZM4OunKf
.

@davecheney, you can't, if you need to create the file it doesn't exist, or just append.

To save looking through the link, the issue is that on Windows syscall.Open sets the write flag for the Windows file when the mode includes the syscall.O_CREAT flag.  This does not happen for syscall.Open on other operating systems.
We could change Windows, which could potentially break existing working programs on Windows.
We could change other systems in the syscall package.  This would be annoying to code but would be unlikely to  break anybody.  It would remove a small and probably unimportant layer of protection from programs that use os.O_CREATE|os.O_EXCL, without os.O_WRONLY to get an unwriteable lock file.
We could make the similar change in the os package, which would be less annoying but have the same minor drawbacks.
We could simply document it.
We could ignore it.

I think a better way to handle this would be to take a page from how Rust does this. OpenFile doesn't take any arguments other than the name, with sensible defaults, and OpenOptions  - a builder pattern that handles the OS specific ways.
I think this is far superior design. I find myself using fileMode which is a completely useless parameter in Windows.

@ianlancetaylor I don't see anything sinister in any of your proposals.
I like your last suggestion (to ignore this issue) the best. Go on Windows does many things differently then on other OSes. And this is just one of them. I don't see why it is important for the program above to behave the same on different OSes. Last os.FileMode(0644) parameter is meaningless on Windows - why we should care about it?
Alex

I don't see why it is important for the program above to behave the same on different OSes

That's rather a saddening comment from a team member of a language which happens to have cross-platform as one of it's core values.

Last os.FileMode(0644) parameter is meaningless on Windows - why we should care about it?

Since it does nothing in windows, you can effectively ignore - and it's fairly common to develop on windows, and deploy on linux. (I have been doing this for as long as I can remember and now thanks to WSL - I barely ever use linux on desktops - and I suspect there would a lot of us)
Now, you write os.OpenFile("somefile", os.O_APPEND | os.O_CREATE, 0) - It works perfectly on Windows. Deploy it on Linux, everything falls over silently (that's worse) - You'll get a file that will NEVER be written to. Despite being a static language, the lack of static enums and no modes in the std lib doesn't help the case.

I prefer to simply document it. package os's purpose is not to hide every detail, just to provide a consistent interface.
https://groups.google.com/forum/#!msg/golang-dev/TlLZoZjJuCk/oQKXUkzGhoEJ

@mattn, I agree with the comment on the link and simply documenting it as an immediate resolution to the issue as well - I can take this up, and submit a CL in a few days when I get time.
That being said, I also wonder if chalking it we cannot deal with every detail, is the best strategy here especially when a language like Rust can clearly demonstrated a better (and simpler) design that covers both sides of the design. A builder pattern like that, will also end up removing a bunch of complicated flags case handling in windows and make the overall code nicer.
I wonder if fileMode being a complete dummy parameter on windows, can even be considered a "consistent interface" here.

That's rather a saddening comment from a team member of a language which happens to have cross-platform as one of it's core values.

Cross-platform is important, but there are other things that Go developers care about too.

Since it does nothing in windows, you can effectively ignore fileMode - and it's fairly common to develop on windows, and deploy on linux.

It would be nice if we could just deploy code on another OS and it will work. But I doubt it is possible without real testing on real OS.

I agree with the comment on the link and simply documenting it as an immediate resolution to the issue as well

I am not sure I like any new documentation here. What are you going to say? I don't see that documentation affecting many people, but everyone will have to read and comprehend new text.

I wonder if fileMode being a complete dummy parameter on windows, can even be considered a "consistent interface" here.
Besides, I wouldn't have a problem with this, if file handing was simply delegated to the OS on all the OS - which implies consistent and predictable behavior. But here, Go's std library doesn't do that as well. It tries to - neither here nor there - which makes things unpredictable and hard to determine.

You are talking about things that cannot be changed now. Maybe for Go2? Make suggestion for Go2, if you have some great ideas.
Alex

I do think that OpenFile and these flags are a bit too low-level, which is why we introduced os.Open and os.Create. It's possible we need another so that OpenFile is essentially never needed; that is, needed only when you really need low-level system flags. But that's not where we are today.
The current docs for the constants say:

Flags to OpenFile wrapping those of the underlying system. Not all flags may be implemented on a given system.

Let's add: "Each call to OpenFile should specify exactly one of O_RDONLY, O_WRONLY, or O_RDWR."


test case: support timeout

Worth mentioning that test suite's before/after calls also get that timeout (not customizable).


Create v0.5.1e

the create v0.5.1e update seems to have broken a few addon mods and this seems to be one is there a possibility of a version update to make it compatible with  v0.5.1e

crash-2023-10-04_15.58.08-fml.txt
latest.log

Yeah it's a known issue that will gen fixed in the next version


Fixes #200

Fixes #200 if working with exported_ressources like i am

Thank you for reporting and fixing the issue!


SSR Environments (.e.g Remix): window is not defined

Hello,
We were looking to use the Drop In client in order to offer our customers an alternative after failing finance. It would have been preferable to help limit the number of times our customers are redirected away from our site throughout the checkout process (having already failed finance checks with another partner to be eligible for our GC offer).
Unfortunately as we are running a Remix front end which uses SSR, we've found that as the GC useGoCardlessDropin function is trying to access window which doesnt exist on the SSR portion of remix it causes an error. We have attempted to use a ClientOnly utility to wrap the whole component but this is unable to assist in this scenario unfortunately.
An excerpt from a colleague who assisted with my prototyping:

Looks like the useGoCardlessDropin is trying to access the window object which isn't available in SSR environments, like Remix. And as it's a hook we can't conditionally render it on our end as that breaks the "rules of hooks". I think they would likely need to add some kind of check into the hook itself that would check for the window object

Remix docs describing the issue
In the short term we will just be using the APIs to obtain a Billing Request Flow URL and redirecting our customers. In the long term we may look to implement patch-package, if GC are unable to patch this.

+1 for Next apps too


Explore minimizing shipped TS Server

Problem
The typescript package with include to power VS Code's JS/TS support is around 30MB on disk. This is after we already strip out some unnecessary files, such as tsc.js.
Proposal
See if we can run the bundled TypeScript version through terser or some other minimizer. This would help reduce the VS Code download and install size.
The main concern I have with this is error stacks that users share with us. Error stacks from minified TypeScript processes would be impossible to decipher without source maps (which we would likely not want to include in the bundled typescript package due to their size)
See https://github.com/microsoft/TypeScript/issues/4844

Running basic terser on the three javascript files we consume from the TypeScript project—tsserver, typescript, and typingsInstaller—the results a quite promising:

tsserver.js: 8.9MB ->  2.7MB
Entire TS package: 31.7MB -> 15.3MB

@amcasey The typescript package currently seems to be over 10% of VS Code's on disk install size (31MB out of 250MB on MacOS) so I'm pretty interested to see what we can do here.
As I mentioned, my main question is how we would handle error stacks from users. Is this something that you have thought about? Is minifying the shipped TypeScript code something the TS team had considered?

Also @amcasey, can we safely remove the typescript/loc directory for VS Code? My understanding is that all the localized strings actually come from files such as typescript/lib/de/diagnosticMessages.generated.json

I recommend closure-compiler in simple mode https://developers.google.com/closure/compiler/docs/compilation_levels for minification. In my tests, it gives the best results.

@mjbvz I think it was discussed, but it was before my time.  I'm happy to run some experiments and get the conversation going again if it makes a big differences.
Side note 1: I wanted to minify .d.ts files, but that was shot down since their purpose is to be readable.
Side note 2: @weswigham's work to convert TS to modules should make it easier to strip out unnecessary code.

I'm not familiar with our loc story, but I think @sandersn touched it recently and might know what's strictly necessary.

Regarding source maps, I'm not too concerned - .NET can debug assemblies shipped without PDBs because it maintains a store of them indexed by assembly hash.  I assume the same would work for minified JS.

I may have the most knowledge about loc on the team, but I don't actually know that much. =) But I looked at /loc and it's full of VS-UI-specific items. I'm pretty sure it's for VS localisation only and you're safe to drop it. @minestarks could probably say for sure.

Looks like terser -c causes a ~1% regression in total compilation time, but the output is nearly as small without -c and that seems not to have a perf impact.

So I don't lose it, here's the command I used to end up with a composite source map, letting me step through the original .ts files:
npx --no-install terser tsc.js -o tsc2.js --source-map "content=tsc.js.map,url='tsc2.js.map'"

The content tells it where to find the input source map and the url tells it what to put in the source map comment at the bottom of the minified file.  Note the lack of -c, since that seemed to hurt runtime perf.

@amcasey Do you need to do any work for the TS telemetry tools before I merge this?

@mjbvz If VS Code isn't going to (un)map the positions in stack traces before sending them, then yes. cc @armanio123

Yes I'd prefer not shipping the source map and tools for processing them as that brings up the install size again
Here's branch I have that runs terser: https://github.com/mjbvz/vscode/commit/4b885ad45f1ddcb3e63a99cf320f09a1f38f0735

On the tools side, we could do the same minification but with source maps and map to the stack. I don't know much details about terser but a quick search on the documentation seems like we're able to do that.

@armanio123 Is that easier than just applying the source map and then working with the same JS file as the other stacks?

@amcasey, I'm not sure I understand your question. I'm assuming if minimization gets merged we're going to start getting stacks with positions on the minimized file. So the idea is to download the same tsserver version, get the source map, and start extracting the positions. Does it makes sense?

This has improved a lot by deduplicating the code that TS ships. We don't minify yet, but this makes stack tracks more useful out of the box. We do minify on web where file sizes are especially important
Closing as further work is out of scope for now


Official image and default project template broken

Official evidence-dev image does not work with default project template.
Steps to reproduce:

--init a new project
run the evidence-dev container
you'll see this error all over the rendered report:

Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /evidence-workspace/node_modules/duckdb/lib/binding/duckdb.node)
Reproduced in multiple environments, most recently Docker Compose running on Debian Buster.
Adding libc6-compat to the image didn't help.

Hey, I have the same problem, I'm running on linux/arm64.
Thanks for your responses. 😊

Thanks for reporting the issue @mgmorcos and @AmsellemJoseph!
We are still working on a holistic solution that works on all platforms without the image size being too large.
As a stop gap, we published a new image evidencedev/devenv:ubuntu that should let you get around the issue.
In order to use this image, simply replace where you were using devenv:latest in your command line with devenv:ubuntu
e.g if you were running the following to setup your dev env
docker run -v=$(pwd):/evidence-workspace -p=3000:3000 -it --rm evidencedev/devenv:latest
run it instead with
docker run -v=$(pwd):/evidence-workspace -p=3000:3000 -it --rm evidencedev/devenv:ubuntu

thanks @ud3sh now i see:
exec /usr/bin/bash: exec format error

Hey @ud3sh,
I confirm, in linux/and64 I have the same issue than @mgmorcos.
And when i'm running on linux/arm64, I have this issue:
✗ orders_by_month /evidence-workspace/node_modules/duckdb/lib/binding/duckdb.node: cannot open shared object file: No such file or directory.
Thanks a lot for your work and responses. 😊

Thanks @mgmorcos @AmsellemJoseph.  Really appreciate you looking into this.
Sorry, forgot to build the test image with a multi platform option.  In any case the amd64 image should be up

Pushed with this Dockerfile in case you still want to take a look.
RE:

✗ orders_by_month /evidence-workspace/node_modules/duckdb/lib/binding/duckdb.node: cannot open shared object file: No such file or directory.

@AmsellemJoseph did this work before with duckdb?  I am curious how you are referencing the duckdb file.   We had some setup instructions to access normal database running on a port your local instance on the main README.md file.  i.e something like the snippet one below to access a postgres instance running on the host machine.
## accessing postgres db running on host instance.
{
    "host": "host.docker.internal",
    "database": "yourDBname",
    "port": 5432,
    "user": "yourUsername"
}

This was from before we supported duck DB - haven't really given much thought about access a simple file on the host machine.  As you might suspect, this devenv preceeds our support for duckdb and we haven't quite kept it up to date until you mentioned the issue.

@ud3sh TY it's working for me now 🙏

hey @ud3sh,
my bad, I misconfigured something, maybe missclick 😅.
Thanks a lot for your work, seems to work now.

@mgmorcos @AmsellemJoseph

evidencedev/devenv is now based on ubuntu and supports all DBs including Duckdb
evidencedev/devenv-lite is alpine based and supports all the DBs excluding DuckDB.

We will leave evidencedev/devenv:ubuntu hanging around for now, but you should be able to use evidencedev/devenv:latest going forward after pulling the latest.


docs: update chart readme

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation
What this PR does / why we need it:
yurt-tunnel-agent and yurt-tunnel-server will be moved in raven.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


There is no "transaction comment" on Receive screen

Need to add "transaction comment" to Receive screen (advance tab)
https://zpl.io/2ZrGY7X
Now it is look like this:

Where this comment should be displayed?
Will it be possible to edit the comment?
How and when it can be edited? (if possible).On what screens?
Will the change affect past transactions or only future transactions?

This comment is for transaction only, not for address. So...

would be shown on transactions details screen https://zpl.io/bP9DErp
no, comment wouldn't be editable

no, only one transaction

checked


[WFLY-18880] Add missing org.wildfly.clustering.marshalling.spi dep t…

…o org.wildfly.clustering.ee.cache
https://issues.redhat.com/browse/WFLY-18880

@pferraro Please review. I'll put 31.x and Critical labels on this; please feel free to adjust if that's wrong.

Thanks @pferraro


Add arm64 support for iOS Simulators

The iOS framework now returns an .xcframework instead of a .framework, which now includes support for arm64 (Mac Silicon chips) for iOS Simulators.
Removed Ubuntu 1804 as it's no longer supported as a runner: https://github.com/actions/runner-images/issues/6002

move to https://github.com/nihui/opencv-mobile/pull/53


Fix doc.

Add more document for graphQL query. And remove out-of-date doc.

Coverage remained the same at 14.328% when pulling 595393b6a9f011af878d135fc799fe0ff69b5386 on doc into 2ed1e948f2a3ce32e26afd22750701c2c22a7778 on master.


Question about metaphase or metaphase/anaphase arrest

I might have asked about this before.
I noticed that there is no parent child relationship between these 2 terms
I expected
abnormal cell cycle arrest in mitotic metaphase
--abnormal cell cycle arrest at mitotic metaphase/anaphase transition
because when you arrest at the metaphase/anaphase transition, you are still in metaphase
(the same would apply to other transitions too)
abnormal cell cycle arrest in mitotic metaphase
Definition
A cellular process phenotype in which progression through the mitotic cell cycle is arrested in metaphase under conditions where arrest does not normally occur.
Comment
Metaphase is defined as the part of mitosis when chromosomes are aligned in the middle of the spindle. If no spindle is present, do not use this term, but consider 'abnormal cell cycle arrest in mitotic prophase' (FYPO:0003145). If you cannot tell whether a spindle is present, or if metaphase cannot be clearly detected, annotate to the more general term 'abnormal cell cycle arrest in mitotic M phase' (FYPO:0000608).
abnormal cell cycle arrest at mitotic metaphase/anaphase transition
Definition
A cellular process phenotype in which progression through the mitotic cell cycle is arrested at the metaphase/anaphase transition under conditions where arrest does not normally occur.

I don't think this exact question has come up before. I don't mind moving the metaphase/anaphase transition term and similar.

... and done. that was easy :)

edit file: fd602879fa65355870ae8d5088ae34201572015f
release: 181b3899dabcbb4162464ba5e7afb857bd6e6776


[tracking] Synthesize Ibex with Yosys

This is a tracking bug. This description will be updated to reflect the current state of affairs. Comment if you have suggestions or updates.
Yosys currently supports only a limited subset of SystemVerilog, which isn't sufficient to parse Ibex. This issue tracks the outstanding issues. We are generally open to find a common ground between tools, but only as long as it doesn't affect code quality and correctness. This means some issues will be resolved upstream in Yosys, while others might be worked around in Ibex.
Updated 2020-08-20. We're almost there, thanks to the work of @kgugala and others at Antmicro, and of course the Yosys reviewers!
We currently know of these issues which are still blocking us from synthesizing Ibex with Yosys:

[ ] https://github.com/YosysHQ/yosys/pull/2331
[x]  https://github.com/YosysHQ/yosys/pull/2330
[x]  https://github.com/YosysHQ/yosys/pull/2329
[ ]  https://github.com/YosysHQ/yosys/pull/2312
[ ]  https://github.com/YosysHQ/yosys/pull/2248

Looking at this list, we can most likely work around all Yosys problems except for the package parameters and the enum/typedefs. These need to be fixed upstream.
The package parameter problem doesn't seem to have an upstream bug report yet. @towoe since you've worked on this, would you mind filing one upstream?

@imphil regarding the package parameter I just did a very simple addition in https://github.com/towoe/yosys-sv/commit/88b1e84167f44ea6e375d162026ba06a424af319
I am however not sure if this is correct or breaks anything else, but it seemed to work at my end.
As this is so small, maybe a PR to yosys can quickly answer that?

Let's give it a try!

As I wanted to split out the commit I just realized that this has dependencies to the other commits, I have to check what effects this has.

Link to #342

@daveshah1 @clairexen for visibility.
Yosys and Ibex are extremely close to the finish line, thanks for all your work so far! Let us know if there's something we can help with. We'll certainly ensure we have full CI on Ibex with Yosys to ensure nothing breaks again once all remaining patches are merged into Yosys.

The PRs mentioned in this issued are not sufficient as far as I can see to support Ibex without any changes (the commits applied in one branch).
If we do not want to change our code support for

Int types for parameters and localparam
Packed multi-dim arrays

are still missing.
For ibex-yosys-build the branch ibex-wip is used and without an exhaustive comparison there is some more work which is not yet part of any PR.
But this branch is also not producing a correct result (mult-dim conversion incorrect, struct initialization not supported).
There is some work activity, maybe some contain already the enhancements required.


Publish for Scala 2.12.18 and 2.13.11, please?

@adpi2 your wheelhouse, I think?
as @tgodzik suggested, I am adding this repo to the release steps at https://github.com/scala/scala-dev/blob/scala-dev/.github/ISSUE_TEMPLATE/release.md
I intend to announce both releases first thing Wednesday (Seattle time zone). this isn't strictly a blocker for that, but it would be nice to have in place

Sure, adding the repo to the release steps would help, if it's not too much overhead for you.
Here are the corresponding artifacts:

https://repo1.maven.org/maven2/ch/epfl/scala/scala-expression-compiler_2.12.18/
https://repo1.maven.org/maven2/ch/epfl/scala/scala-expression-compiler_2.13.11/


Removal of the 'dead-code' for the binary protocol

Now that the HTTP protocol is used by both the tray implementations, we can remove the code of the binary protocol.

Dup of #2491


feat: added base of uat/test-iot-device-sdk-mqtt5-client as standalone maven project

Issue #, if available:
To test Nucleus MQTT5 compatibility we require a controlled MQTT5 clients.
One of them can be built on top of AWS IoT device SDK for java v2 and underlined Java CRT libraries.
Description of changes:

Added pom.xml as standalone maven project
Added Main.java with template main() method
Added proto file with gRPC protocol definition
Added usual LICENSE README and so one files
Added license check files
Added checkstyle files
Added PMD files
Added new github workflow file

Why is this change necessary:
These changes create maven/github infrastructure to develop the test client.
How was this change tested:
Currently manually, in phase 2 will be covered with unit tests.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please address the build failures.


feat: adds post on git hook date setting

After the comments on #207 I wrote it as a post instead.
Answers #199.
Also posted on my blog: https://smale.codes/posts/setting-dates-via-git-hooks/

I just updated some necessary adjustments and fixed typos.
Later I'll merge


Reland handle corrupt config file

Description
If the JSON file is corrupted don't crash when parsing

LGTM


close policy after processing the last payout

In processPayout
https://github.com/etherisc/gif-contracts/blob/b58fd27a34452e062d10b175f3bdd7ee16b9d1a7/contracts/modules/PolicyController.sol#L428-L431
There is no check to close the corresponding policy after processing the last payout of the last claim of expired policy

see comment in inssue #104


App crash when render

App crash when render
working fine in android
Here are the deatils:
"react-native-maps": "^0.26.1",
"react": "16.9.0",
"react-native": "^0.61.5",
Xcode: 10.3 version?
Before its working suddenly stopped working... any solution?

Can you please give more info? what do you mean by crash? Any error code? which platform? my first guess is that you are trying to use this on web and it is not supported for web.

I'm having same issue after updating RN to 0.63.3

MapView works fine on android and shuts down(crash without error) the app on IOS. Please help

Same problem here on android, but when adding markers, it starts to slow and show lot of log messages on android studio about garbage collector then crashes with no error


Add Contributor Covenant Code of Conduct with link in Readme.

While there are no major issues currently outstanding in the Laravel community, having an established Code of Conduct would allow the core team to have concrete guidelines to point to in the event that harassment, or other inappropriate behavior by contributors or commenters becomes an issue.
This code of conduct is a slight modification of the Contributor Covenant Code of Conduct which is used by many prominent open source communities including Ruby on Rails, Elixir, Vue.js, and Yarn.
Currently I have included the suggestion to email Taylor directly for abuse questions, but in the instance that Taylor doesn't want the drama, we could set up an<EMAIL_ADDRESS>or similar email address to forward to trusted community members.

Accidentally pulled in a commit from 5.4. I am ashamed.

Used the Ruby COC. Thanks.


Adding the title of the check in the alert

Hi
We have various checks in a single service , it would be nice to have the name of the check in the sms / email to actually know what failed.

I believe this does happen now


tabs do have too much left padding - waste of space

Description
Currently tabs do have too much left padding on them and they are wasting screen real-estate, displaying less of the filenames.

If there is no desire to change the default style to make it better use the space, please do at least provide information on how to tune the stylesheet in order to lower the amount of wasted space.

Base on the screenshot, this issue probably belongs to https://github.com/atom/one-dark-ui.
In Atom 1.17 the tabs of the One themes will be redesigned, see https://github.com/atom/one-light-ui/pull/96.
Here a gif with One Dark UI:

Any better? There is also the option to switch to a "minimum" size.

You are right about "one-dark-ui", can you move the ticket?  (i cannot).
Still, the issue is still valid and cannot be fixed by using the UI options. I tried: Minimum + Compact mode and still, there is plenty of wasted left-padding space. In fact in my case there is a little bit more than in the screencast.

@ssbarnea The redesign is only available in Atom 1.17. The screencast shows the new look with less padding.

@Ben3eeE Thanks for clarifying. In this case I would consider this issue sorted, even it the fix was not released yet.


CPU spikes cause 'server overload'

Whenever a user joins the server there is this CPU peak every ~30 seconds. The image is from the docker container where you can see when nobody is on the server and when somebody is. My system requirements should be good enough to run this flawless. What could be the issue in this case since I see nobody else having issues after the proton update.

I have an Intel Nuc with this processor i3-1220P running on an Ubuntu server. There are only a few containers running and besides the enshrouded one there is nothing that takes a lot of CPU power.

It's tough to test against all the different hardware configurations and software configurations. I test from workstation using Docker and Podman from inside WSL with a Ryzen 7 5800x3d and 64GB of RAM. I also test in my lab from an HP DL360 1U server with dual Xeon Haswells and somewhere north of 100GB of RAM on Debian 12... But that is the extent of my testing.
I just released a new version of the proton image today with the latest version of Proton-GE... you can try that and see if performance is better.

I have also tried the mornedhels setup but the same thing happens. I will try your new release this weekend and see if it helps :). Thanks for the comment. I will update you and otherwise close the ticket if there is not much to do about it.

I am also experiencing overload issues with just a few players. This was not the case previously. The devs have built their own game engine for Enshrouded and I am assuming they have either introduced some bugs in a recent update to their netcode or it simply needs more optimizations. Not much I can do about this outside of throwing faster hardware at it and hoping for the best.

Just chiming in with the same issue. Running on an Azure Virtual Machine Standard_D4a_v4 4vCPU and 16GB of Memory. I also had the same issue with another docker image from another author so I'm assuming it might be on the Enshrouded side of the house.

Yes it seems more likely a problem on the game developers side, So I will close this issue. :)


Restore issue

I am trying to restore my database but keep running into this error.
Missing: backupFile - Filename to store backup. (e.g. backups/full-backup.json). Usage: firestore-import [options]
Backing up works perfect. Here is the command line I am using
firestore-import --accountCredentials XXX —backupFile firestore-export.json
Note this is the backup command:
firestore-export --accountCredentials XXX  --backupFile firestore-export.json
The file is in the same place.

I found the issue. --


[ign -> gz] CMake functions

Part of https://github.com/gazebo-tooling/release-tools/issues/719

TODO

[x] Migrate ign_add_benchmarks on gz-cmake3: https://github.com/gazebosim/gz-cmake/pull/265

gz_add_benchmarks() is not tick-tocked yet from gz-cmake, so it causes the build to break

@osrf-jenkins run tests please!


Small changes which simplified my use of gojail in the buildah port

I ended up going in a different direction on this - sorry for the noise


NetCDF reader not initiated correctly

What happened?
ek-data is failing to initialise properly for some netCDF files. Uncertain what the conditions are to get to this code, but here is an example CDS request that causes it:
ek_ch4_cds = ek.data.from_source(
    "cds",
    "satellite-methane",
    {
        'processing_level': 'level_2',
        'sensor_and_algorithm': 'tanso2_fts2_srfp',
        'year': '2021',
        'month': '01',
        'day': '01',
        'version': '2.0.0',
        # 'format': 'zip',
    }
)
ek_ch4_cds

What are the steps to reproduce the bug?
Initialise NetCDFReader with path, not with self
Version
latest
Platform (OS and architecture)
MacOS + Linux
Relevant log output
No response
Accompanying data
No response
Organisation
No response

Hi @EddyCMWF, please can you provide some more details?


Constant curve motion time anim is smoothed out when using Combine MT Approx

I know it's approximation but it destroyed my constant curve!

Make the new global setting a big number and it should better approximate this curve.


NullPointerException on header parse

I'm running into the following issue client side: https://github.com/square/okhttp/issues/2099, where I tell OkHttp to use application/json;version=2, but then the OkHttp client library converts this to application/json;version=2; charset=utf-8.
This ends up throwing the following exception server-side:
07-Nov-2022 19:35:38.693 WARNING [https-jsse-nio-8443-exec-3] cwms.radar.ApiServlet.lambda$init$10 error on request[3357625609381316046]: /cwms-data/timeseries
	java.lang.NullPointerException
		at cwms.radar.api.TimeSeriesController.deserializeTimeSeries(TimeSeriesController.java:400)
		at cwms.radar.api.TimeSeriesController.deserializeTimeSeries(TimeSeriesController.java:395)
		at cwms.radar.api.TimeSeriesController.create(TimeSeriesController.java:127)
		at io.javalin.apibuilder.CrudFunction$3.invoke$lambda-0(CrudHandler.kt:32)
		at io.javalin.apibuilder.CrudFunctionHandler.handle(CrudHandler.kt)
		at cwms.radar.security.CwmsAccessManager.manage(CwmsAccessManager.java:42)
		at io.javalin.http.JavalinServlet.addHandler$lambda-0(JavalinServlet.kt:96)
		at io.javalin.http.JavalinServlet$lifecycle$2$1$1.invoke(JavalinServlet.kt:43)
		at io.javalin.http.JavalinServlet$lifecycle$2$1$1.invoke(JavalinServlet.kt:43)
		at io.javalin.http.JavalinServletHandler.executeNextTask(JavalinServletHandler.kt:99)
		at io.javalin.http.JavalinServletHandler.queueNextTaskOrFinish$lambda-1(JavalinServletHandler.kt:85)
		at java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:995)
		at java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2137)
		at io.javalin.http.JavalinServletHandler.queueNextTaskOrFinish$javalin(JavalinServletHandler.kt:85)
		at io.javalin.http.JavalinServletHandler.executeNextTask$lambda-11$lambda-10(JavalinServletHandler.kt:119)
		at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)
		at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:628)
		at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1996)
		at io.javalin.http.JavalinServletHandler.executeNextTask(JavalinServletHandler.kt:119)
		at io.javalin.http.JavalinServletHandler.queueNextTaskOrFinish$lambda-1(JavalinServletHandler.kt:85)
		at java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:995)
		at java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2137)
		at io.javalin.http.JavalinServletHandler.queueNextTaskOrFinish$javalin(JavalinServletHandler.kt:85)
		at io.javalin.http.JavalinServlet.service(JavalinServlet.kt:89)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:779)
		at cwms.radar.ApiServlet.service(ApiServlet.java:343)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:779)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
		at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
		at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
		at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
		at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:660)
		at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)
		at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
		at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:687)
		at org.apache.catalina.authenticator.SingleSignOn.invoke(SingleSignOn.java:312)
		at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)
		at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:360)
		at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:399)
		at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
		at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:893)
		at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1789)
		at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
		at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
		at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
		at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
		at java.lang.Thread.run(Thread.java:750)

Reading this post (though I'm far from knowledge on the subject to vet the answer) this format looks valid: https://stackoverflow.com/questions/29549299/how-to-split-header-values

The problem comes down to Formats.parseHeader.   That method is often used on the accept header but its also used on the ContentType for POST, PUT and UPDATE.
Maybe we shouldn't be reusing the method and should have a different method for ContentType ?  Not sure.
Maybe we should be looking for charset explicitly and handling it somehow and if its been handled removing it from the ContentType string?   Again, not sure.
Or, maybe Formats.parseHeader shouldn't be doing contentTypeList.contains(ct) but should be using some other method for finding a match in our list of supported ContentTypes.
It looks like our handling of asterisk in the ContentTypes isn't doing what I think asterisk is supposed to be doing.
Additional unit tests around Formats.parseHeader would probably help clarify what its doing and what it should be doing.

This will be fixed with #238, the same situation (but RestAssured instead of OkHttp) is happening. I've tweak the equals function to only care about the mimetype and version parameter.

I made a change to ContentType that may also have fixed this issue.  Charset now gets handled on its own so it doesn't end up in the list of ContentType parameters.

Okay, I think I picked that up along with what I was doing. though I just realize that may particular issue wasn't in the ContentType class, is was string comparisons in ClobController.
But there can be other parameters so isolating to just the one ones we truly care about is probably the better thing to do.


Most Oh-my-ZSH themes not working

If I try to source OHMYZSH's default theme with zplug "themes/robbyrussell", from:oh-my-zsh , this is what I get in my prompt:

This happens with most themes, but not with the one mentioned in the README, duellj.
I'm using Gnome Terminal on Linux, zsh 5.1.1

Thank you for your report. I found this bug now. I will fix it soon. Thank you

Awesome! :ok_hand:

I have similar issue in v2, but v1 is work. I am using the oh-my-zsh them blinks.

Thanks for reporting! I'll reproduce it

@stevenjlho I couldn't reproduce your problem. #95 may be related so please take a look at it.

i am having the same problem, #95 does not fix it
# Essential
if [[ ! -d ~/.zplug ]]; then
    git clone https://github.com/zplug/zplug ~/.zplug
    source ~/.zplug/init.zsh && zplug update --self
fi
source ~/.zplug/zplug

export PATH=${HOME}/bin:${HOME}/.local/bin:/usr/local/bin:${PATH}
export HOMEBREW_CASK_OPTS="--appdir=/Applications"
export ZSH=$HOME/.zplug/repos/robbyrussell/oh-my-zsh
export EDITOR=atom

# What does this do?
zplug "plugins/brew", from:oh-my-zsh, nice:10
zplug "plugins/brew-cask", from:oh-my-zsh, nice:10
zplug "plugins/git",   from:oh-my-zsh, nice:10
zplug "plugins/osx", from:oh-my-zsh, if:"[[ $OSTYPE == *darwin* ]]"
zplug "plugins/zsh_reload", from:oh-my-zsh
zplug "plugins/colorize", from:oh-my-zsh
zplug "zsh-users/zsh-completions"
zplug "zsh-users/zsh-history-substring-search"
zplug "zsh-users/zsh-syntax-highlighting", nice:19
zplug "b4b4r07/zplug"
zplug "robbyrussell/oh-my-zsh", use:"lib/*.zsh", nice:14
zplug "themes/robbyrussell", from:oh-my-zsh

if ! zplug check --verbose; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

# Then, source packages and add commands to $PATH
zplug load

source ~ / .zplug / zplug part of the "source ~ / .zplug / init.zsh" Please try to

source ~/.zplug/init.zshdoes not make a difference...

@nbara Haven't really tried it on my machine, but I think it's because you have "robbyrussell/oh-my-zsh" use:"lib/*" loaded after themes/robbyrussell. Try changing the nice value to say -1 and see if it fixes the issue.
@b4b4r07 Maybe we should automatically source lib/theme-and-appearance.zsh when a theme from omz is used? I feel like simply doing autoload -Uz colors && colors will also fix it, but I haven't looked into it.

nice:-1 does the trick ! Thanks @NigoroJr

Actually most themes turn out to be very buggy. See for sarin theme, the prompt is completely messed up...

Did I miss anything ?

Any idea?

@nbara I can't reproduce this. It seems to be working fine.
source ~/.zplug/init.zsh

autoload colors && colors
setopt prompt_subst

# zplug 'robbyrussell/oh-my-zsh', use:'lib/*'
zplug 'plugins/git', from:oh-my-zsh, nice:10
zplug 'themes/sorin', from:oh-my-zsh, nice:11

zplug check || zplug install

zplug load --verbose

Here is my .zshrc :
###############
# Zplug init
###############
if [[ ! -d ~/.zplug ]]; then
    git clone https://github.com/zplug/zplug ~/.zplug
    source ~/.zplug/init.zsh && zplug update --self
fi
source ~/.zplug/init.zsh

###############
# PATHS
###############
export PATH=${HOME}/bin:/usr/local/bin:${PATH}
export HOMEBREW_CASK_OPTS="--appdir=/Applications"
export ZSH=$HOME/.zplug/repos/robbyrussell/oh-my-zsh
export EDITOR=atom

###############
# Zplug plugins
###############

autoload colors && colors
setopt prompt_subst

zplug "junegunn/fzf-bin", \
    from:gh-r, \
    as:command, \
    rename-to:fzf, \
    use:"*darwin*amd64*"

zplug "plugins/brew", from:oh-my-zsh, nice:10
zplug "plugins/brew-cask", from:oh-my-zsh, nice:10
zplug "plugins/git",   from:oh-my-zsh, nice:10
zplug "plugins/osx", from:oh-my-zsh, if:"[[ $OSTYPE == *darwin* ]]"
zplug "plugins/colorize", from:oh-my-zsh
zplug "zsh-users/zsh-completions"
zplug "zsh-users/zsh-history-substring-search"
zplug "zsh-users/zsh-syntax-highlighting", nice:19
# zplug "b4b4r07/enhancd", of:enhancd.sh, nice:15
# zplug "robbyrussell/oh-my-zsh", use:"lib/*.zsh", nice:-1
zplug 'plugins/git', from:oh-my-zsh, nice:10
zplug 'themes/sorin', from:oh-my-zsh, nice:11

zplug check || zplug install

# Then, source packages and add commands to $PATH
zplug load

Uncommenting the OMZ lib* line does not make a difference for this theme.

I cannot reproduce your problem with that either. It's probably something related to your terminal emulator or your environment.

I am on mac (latest 10.11) terminal, using homebrew, on an almost fresh OSX install. No specific customization, besides zplug.

Hmmm, I cannot reproduce that, too.

I fixed it !
I have no idea why this caused the problem, but I simply switched the OSX terminal theme back to the Basic theme, then back to Solarized Dark, and the problem was gone...
The cursor does not appear behind the prompt arrow anymore. How weird.

Having the same problem with https://github.com/tylerreckart/Odin, sometimes I get the correct prompt and some others I get:
$(_user_host)$fg[magenta]~ $(git_prompt_status)$reset_color→
On my .zshrc:
zplug "tylerreckart/Odin/", nice:19
Any solutions?

@Arlefreak

You need to load "plugins/git" from:oh-my-zsh before loading that theme because the theme depends on it.
Are you using the latest zplug? c79655e612641584529ff65d4852c9f3df378797 fixes the bug where prompt substitution is not done when loading from cache.

Actually the issue has come back after updating to latest commit zplug update --self
The cursor appears before the prompt :

@NigoroJr Updated zplug and not it works fine thanks!

@nbara Like before, I can't reproduce your problem (I'm on 10.9.5). I don't have access to an El Capitan right now, so can you try it on other environments to see if it's zplug or your environment that's causing the problem?

Hi NigoroJr, what other environments are you referring to? I only have one machine to test this on, and it runs on El Capitan.
I am not surprised you are having problems replicating this, for me it was fixed for well over a month, and all of a sudden the bug reappeared...
BTW, I probably should have mentioned that the bug only occurs in some git folders. Non-git folders are fine. And strangely, not all git folders are affected...

I was wondering if you had any other systems/versions of OSX to run on since I can't replicate this on my machine that runs Mavericks. What if you use the default Terminal.app and not iTerm?

the bug only occurs in some git folders

Hmm... that makes me think it's something related to the git plugin but I can't say for sure.

Actually I switched to iTerm a few weeks ago in the hope that it would solve the problem. :)

I see... Do you think you can identify what kind of git folders that happens in?


Extra NuGet package

Trying to realise this for all Umbraco packages I'm touching :)
Would it be possible to provide an extra NuGet package which only contains your custom code DLL?
Using the current NuGet I get unwanted stuff like everything below App_Plugins, which is unwanted for usage in class libraries.

Thanks for raising this @kows! #h5yr
Can you give me an example of where you'd need to do this? I would traditionally just install the package into my "Web" project alongside Umbraco and everything else.

Our company has a very specific project structure coming from Sitecore, which means logically grouping stuff in separate web & class projects :).
One specific case:
we put our Modelsbuilder generating class in a separate class library (Customer.Foundation.Data), hence I am in need of the Cogworks.Meganav dll in order to support the generated properties of type "Cogworks.Meganav.Models.MeganavItem".

And please delete the Views\Partials\ExampleNavigation.cshtml file from the NuGet package! Having to delete it on every install/update is a minor annoyance.
Example code should be in the documentation/wiki and/or possibly shown by using a readme.txt that automatically opens after installing the package: https://docs.microsoft.com/en-us/nuget/create-packages/creating-a-package#adding-a-readme-and-other-files.

@kows The Cogworks.Meganav.Core package should indeed only contain the assembly and Cogworks.Meganav should only include the App_Plugins (and a dependecy on the core package).
Example code doesn't belong in the NuGet packages (if you ask me), that's all!

Hey all,
Thanks for all of your points. I can see the use case for a separate "Core" package and it's something I'll be looking to do as part of a v2.0.0 release.
While creating these abstractions in itself does not justify a major version release there are some other changes I'd like to bundle with it, some of which is part of the pathway to V8 support.
I'll post updates soon.
Cheers,
Callum

We have been using separate projects for a long time and I agree on this one as well.
This is not the only package with this “issue” so we use this little “hack” in our csproj:
<ItemGroup>
     <AppPluginsDir Include="$(ProjectDir)App_Plugins" />
 </ItemGroup>

<Message Text="Removing App_Plugins from Project" Importance="high" />
<RemoveDir Directories="@(AppPluginsDir)" />

And also exclude with .gitignore.
Far from optimal but keeps the library-project/repo clean. Not sure if this means that the need for a separate project decreases but maybe.
Anyway, I agree on the “general issue” maybe there could be some better general solution. Like a buildtaget in the Umbraco-project csproj-file shipped with the cms that is the “recommended target” for package-content but not runs when the package is included in a class library.

@callumbwhyte thoughts on converting this to a Razor class library? for v9+


DF User Logger: chime.mp3 Not Found

Module
DF User Logger 1.6.0
Describe the issue
404 error on /modules/df-logger/sounds/chime.mp3

I completely removed and reinstalled the module, just to be sure.
To Reproduce
Steps to reproduce the behavior:

Upgrade DF UL to 1.6.0
Log in, expecting sound.
Hear nothing.
Check console.

Expected behavior
The sound should be there.
Screenshots
The /sounds directory does not exist.

I also get the following error, but I suspect it's on account of the missing file.

Thanks for reporting this. I'll take a look asap 👍🏼

@flamewave000   Yeah it looks like this is due to the sounds directory not being included in the zip file.  I confirmed by uninstalling the module and reinstalling and sure enough, the directory is no longer part of it.

Yeah, it looks like I accidentally broke the sound directory bundling phase in my build script so it didn't include the file with the produced ZIP file. I'll push a bug fix release with the file included 👍🏽


Allow query and path parameters to omit Path and Query annotation

Following FastAPI, only headers and cookies would need to be annotated.
Path and query parameters could work without annotations, as determined by their name being present, or not, in the URL template.

Reconsider; does it still make sense with param models?


Build Order Updates

A long-needed overhaul of the build and build allocation system.
This PR adds a new build database model, the "BuildLine"

Represents an instance of a BOM item against a BuildOrder
Is generated once when a BuildOrder is created
If the BOM changes (after the build is created) the items required for the build order do not change
Will help with speed of API queries against build orders
Will allows users to "break out" subassemblies into a top-level flat build order
Other advantages will fall out too
Allows calculation of "overage"

Closes https://github.com/inventree/InvenTree/issues/340
Closes https://github.com/inventree/InvenTree/issues/3940

TODO

[x] Fill out description
[x] Data migration for existing adding BuildLine objects to build orders
[x] Add data migration for assigning existing BomItem objects
[x] Add migration for removing BuildItem.build column
[x] Add migration for removing BuildItem.bom_item column
[x] Unit testing for data migrations
[x] Refactor subtract_allocated_stock
[x] Refactor scrap_build_output
[x] Refactor complete_build_output
[x] Refactor trim_allocated_stock
[x] Annotate "available" quantity to BomLine serializer
[x] Annotate "allocated" quantity to BomLine serializer
[x] Perform "remaining quantity" calculation on each BuildLine instance
[x] Refactor "auto allocate" functionality
[x] Refactor "unallocate" functionality
[x] Refactor existing build reports
[x] Recalculate required quantities if the total build quantity is adjusted
[x] Update BuildLine objects when a BomItem is saved
[x] Refactor all references to has_untracked_bom_items
[x] Refactor all references to incomplete_bom_items
[x] Unit testing
[x] Documentation
[x] Check calculation of overage in build orders
[x] Fix "required for build orders" queryset annotation (should be a lot simpler now)
[x] UI updates
[x] API updates
[x] Data migration for demo dataset - https://github.com/inventree/demo-dataset/pull/48
[x] Ensure new API annotations on BuildLine model do not take O(n) time
[x] Remove build.required_quantity method
[x] Refactor build.has_overallocated_parts method
[x] Refactor build.required_parts_to_complete_build method
[x] Refactor build.unallocateStock method
[x] remove old loadBuildOutputAllocationTable javascript function

@matmair we are hitting the same migration issues in this PR also - plugin tests not running correctly etc.

@SchrodingersGat seems like a general migration error; bb37a97 seems fine except for 2 non-migration errors. Can you check the error is not in https://github.com/inventree/InvenTree/pull/4855/commits/a9d974bebd295d4ca11dc256f23fe76c82f3c4e5?

@matmair can you give your 2 cents on this issue?
https://github.com/inventree/InvenTree/actions/runs/5250684787/jobs/9484929933?pr=4855

For some reason, running the unit testing is generating a new migration file in the "InvenTree" app. IIRC you recently added some migration stuff here, maybe?

The interesting part is why the migration checks go through

If I run the full CI suite locally, I get a new migration file (under InvenTree/migrations) for each run through

Do you have the contents?

From: Oliver @.>
Sent: Tuesday, June 13, 2023 7:43:04 AM
To: inventree/InvenTree @.>
Cc: Matthias Mair @.>; Mention @.>
Subject: Re: [inventree/InvenTree] Build Order Updates (PR #4855)
If I run the full CI suite locally, I get a new migration file (under InvenTree/migrations) for each run through
—
Reply to this email directly, view it on GitHubhttps://github.com/inventree/InvenTree/pull/4855#issuecomment-1588582359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APXU7DCAYSQLVKNWEVSCHMLXK74WRANCNFSM6AAAAAAYHLO7HM.
You are receiving this because you were mentioned.Message ID: @.***>

@matmair for example
If I run the CI tests again, I get another migration each time, i.e. 0003, 0004, 0005


Name resolution in the simulator fails on builtin operators used at higher order

iadd is the builtin for addition:
>>> iadd(1,1)
2

But if we try to supply it to a 2nd order operator, name resolution fails:
>>> def f(g) = g(1, 1)

>>> f(iadd)
compile error: error: [QNT502] Name iadd not found
f(iadd)
  ^^^^

This occurs in both the REPL and when running tests, but parsing and typechecking works as expected.

After a quick investigation, I see that the problem is that we only define what do to with builtin operators in the evaluation process when visiting an operator application. In this case, the operator is a name expression.
I believe the solution will be to move the builtin operator definitions from the switch statement inside exitApp to the actual context, so it is retrieved in exitName like the user operators
https://github.com/informalsystems/quint/blob/b806f4081276867df4ce06b485ec51125e65678e/quint/src/runtime/impl/compilerImpl.ts#L429-L990


closeAllPanels doesn't work

Good day. closeAllPanels method doesn't work because no panels are found as a direct children inside menu.
The html structure that plugin produces is
<menu element>

</menu element>

https://github.com/BeSite/jQuery.mmenu/blob/master/src/core/js/jquery.mmenu.oncanvas.js#L211
So my fix is to use .find instead of .children.

Thank you for pointing out this issue, the fix would be to use this.$pnls instead of this.$menu. I'll fix this in the next version.

Should be fixed in version 5.5.3
Could you check?

Checked.
btw, you can reuse the '''$pnls''' you already got above.
https://github.com/BeSite/jQuery.mmenu/commit/1d2a985c2c7de56bcfb716221108bad1b1e0d142#diff-49a5625a0b73da15da28852aeecf965aL215
Functionality works, but the animation is a little weird. Because 'hidden' class applied to the opened panel right away, so there is animation only for first panel.
But what i did, i simply call '''this.openPanel( $frst );''' without this piece of code before
'''
this.$pnls.children( '.' + _c.panel )
.not( $frst )
.removeClass( _c.subopened )
.removeClass( _c.opened )
.removeClass( _c.current )
.removeClass( _c.highest )
.addClass( _c.hidden );
'''
So in this case 'this.openPanel' does all job and animation applies correctly.