coqPackages: fix + add multinomials 1.3 + coqeal 1.0.0

Motivation for this change
Fixing my buggy implementation of generation of additional packages for mathcomp and added multinomials release 1.3 and coqeal release 1.0.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@vbgl can you build the appropriate packages ?

Evaluation fails:

error: while querying the derivation named 'coq8.8-mathcomp-1.7.0-analysis-0.1.0':
undefined variable 'mathcomp' at …/nixpkgs/pkgs/development/coq-modules/mathcomp/extra.nix:138:13

Also (unrelated to this PR, I guess, but worth mentioning), the naming is wrong: this mathcomp-analysis package is named “coq8.8-mathcomp” and has version “1.7.0-analysis-0.1.0”.

Also (unrelated to this PR, I guess, but worth mentioning), the naming is wrong: this mathcomp-analysis package is named “coq8.8-mathcomp” and has version “1.7.0-analysis-0.1.0”.

I could not reproduce this,

nix-repl> with import ./. {}; coqPackages.mathcomp-analysis.name

and all the variants I could think of give the right versions.

Evaluation fails:

error: while querying the derivation named 'coq8.8-mathcomp-1.7.0-analysis-0.1.0':
undefined variable 'mathcomp' at …/nixpkgs/pkgs/development/coq-modules/mathcomp/extra.nix:138:13

This should be fixed now

nix-repl> lib.getVersion coqPackages.mathcomp-analysis.name
"1.9.0-analysis-0.2.2"

@vbgl what would be the recommended name instead of coq8.8-mathcomp-1.7.0-analysis-0.1.0 ?

@vbgl, would it be analysis-0.1.0+coq-8.8.1+mathcomp-1.7.0 ?

CoqEAL does not build with Coq 8.7 or 8.9, e.g.:
builder for '/nix/store/n57zd4031f9y3xkjfcxz122m938hhaha-coq8.8-mathcomp-1.9.0-coqeal-1.0.0.drv' failed with exit code 2; last 10 log lines:
COQC refinements/refinements.v
COQC refinements/pos.v
COQC refinements/binnat.v
File "./refinements/binnat.v", line 379, characters 0-4:
Error: Attempt to save an incomplete proof (in proof Rnat_ltE)
make[2]: *** [Makefile.coq:657: refinements/binnat.vo] Error 1
make[1]: *** [Makefile.coq:318: all] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile.common:67: this-build] Error 2
About naming, something looks wrong: it is OK to have different versions of a library for different versions of Coq. But for a given version of Coq, one version of the library should be enough. Otherwise you are bound to have to deal with an exponential mess.

About naming, something looks wrong: it is OK to have different versions of a library for different versions of Coq. But for a given version of Coq, one version of the library should be enough. Otherwise you are bound to have to deal with an exponential mess.

It's not, some libraries are compatible only with a restricted set of versions of the others...

CoqEAL does not build with Coq 8.7 or 8.9, e.g.:

This should be fixed now...

@vbgl is it okay to merge now?

mathcomp-analysis does not build with Coq 8.7.

@vbgl should be fixed now

@GrahamcOfBorg build coqPackages_8_9.coqeal


Add documentation for using authentication tokens to make authenticated requests to resource servers

We currently return the identity provider's auth_token and refresh_token as part of the PKCE payload, but we do not have any documentation about this feature or examples of how you might use these tokens in your application.

Closed in #7354


Feature/secret import fix

Please reference this dag as successful runs with containers using the new feature: https://github.com/colpal/dataEng-container-tools/pull/171/files


link services

A service should be able to declare a "parent" service. Eg led-button declares button as parent.
When announcing services, child services should follow the parent service immediately.
control
button
led-button
buzzer-button
button
led-button

decided to go for range, see #162

decided to go for range, see #162


Deckbuilder: search results linked to wrong card

This search result should link to Allie Hensman (WWE)

However, it links to Allie Hensman (Core)

This bug only manifests itself for cards that have multiples by title  - the first version (in this case, the Core version of Allie) is linked to by all cards with that title.
Fix this.

fixed by #10


Tags - Error when deleting dependent tags and unable to dismiss the error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

User is admin of Collect workspace
The Collect workspace has multilevel dependent tags

Go to staging.new.expensify.com
Go to Profile > Workspaces > Collect workspace
Go to Tags
Click on the first level tag (California)
Click 3-dot menu > Delete tag
Delete the tag

Expected Result:
User will be able to delete the tag
Actual Result:
Error shows up when deleting the first level tag. The error cannot be dimissed by clicking X
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/96dbe80c-40ba-4ff7-b154-948a1926605e
Bug6420680_1710950420154!Dependent_-_Multi_Level_tags_NEW.csv
View all open jobs on GitHub

We think that this bug might be related to #wave-control

@deetergp  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I can't reproduce this locally 🤔 Collect policies are beta / not available to the public, so I don't think this is a blocker.

Also not able to reproduce on staging (web)

This PR is the culprit https://github.com/Expensify/App/pull/38453

cc @allroundexperts

Not overdue. This PR should take care of it https://github.com/Expensify/App/pull/38759

Still waiting on that PR.

The PR was merged 2 hours ago. I'll ask for a retest once it's out on staging.

@lanitochka17 could you please retest this issue? We think this might have been fixed.

@luacmartins Issue is still reproducible
https://github.com/Expensify/App/assets/78819774/80b0e066-7fb0-49fe-9bc0-50806a628e95

@luacmartins @deetergp  This is the error that is being triggered: https://github.com/Expensify/Expensify/issues/391149

We don't support multi level tags in NewDot, so we shouldn't be calling removeTags on multiple tag lists

Should we even be displaying multi-level tags in NewDot if they are not supported?

Should we even be presenting users with the option to delete them then?

No, we shouldn't. We should just hide that option if we're viewing multi level tags

So then this sounds like it can be external after all 🎉

@allroundexperts Friendly bump to review proposals since I am still seeing this on the back-end 😄

Given we just want to hide the option for multi level tags, the proposal from @gijoe0295 looks good enough to me.
C+ reviewed 🎀 👀 🎀

Missed @allroundexperts's seal of approval ❤  Will review in the AM.

@gijoe0295's proposal looks good to me as well 🚀

Looks like we have a PR in review for this and it's ready for another look by @allroundexperts 🎉

Payment Summary:

Payment Summary:

Contributor: @gijoe0295 $250 paid in Upwork
Reviewer: @allroundexperts $250

@allroundexperts can you complete the checklist when you get a chance and request payment?

Checklist

https://github.com/Expensify/App/pull/38453
This was a deploy blocker and is clearly mentioned in the PR that caused it.
N/A
The steps given in OP look simple enough to me.

Already added payment summary - just need @allroundexperts to request payment in ND.

Just waiting on ND payment.

Still waiting on ND payments?

Yep!

Bump @allroundexperts for payment request! 🤑

Hi @luacmartins!
I have this noted down. Please feel free to close.

$250 approved for @allroundexperts


Settings screen is not completely localized

@James-Sangalli pending for your translation strings

translated, some strings missing in values-zh/strings.xml, I just add from values/strings.xml


fix: Validate Config Form Against Submit Null Values

Avoid submitting values that are not considered correct for the configuration validation scheme by disabling the Submit button when validation criteria are not met

Thanks, very good catch!


Fix linters error

In this milestone I built a fully functional mobile web app using ruby on rails.

This app allows users to have control over their spend

users can add a lot of categories of payments

users can manage each payment

users are able to create an account (login and sign in)

This Project was built with:

Ruby on rails
Tailwind css

Testing with:

Capybara
Rspec

Hello @MahmoudBakr23, I can record only 5 mins video on loom.
Kindly, you can tell me how it should equal to 5mins?

@MahmoudBakr23 the video is exactly 4mins
Kindly, where is the problem to approve the project?

Hi @stanleySimeon
As we discussed on Slack, Please attach the link to your video and the link to your live demo link in order to get the approval and avoid repeating the week! 🙏
Thank you for contacting me

Hi @stanleySimeon ,
Highlights ✨
Thanks for making the requested changes

Code base looks clean 👍
Pull request 👌
Git flow ✅

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Proceed to the next level 👏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


System's behavior when the input field is left empty

Description:
The test verifies how the system handles the validation of empty input.

Preconditions:
The website is up and running.

Step 1
Press Enter with the search input field empty.

Expected results
The system should display an error message indicating that the input field is required


Add ContributingGuidelines.md

The Contributing Guideline documentation will contain set of guidelines that will help contributors during the contribution process.
File type markdown.

@nawed2611 Could you please assign this issue to me under GSSOC 23
Thank you!

Sure!

@nawed2611 Could you please add GSSoC 23 label to this issue.

@nawed2611 Added PR #65
Please review it.


"Dockable Container Layout" resource type is available in all "new resource" dropdown menus

Fantastic plugin! Not urgent bug at all.
Now that I've added dockable containers to my project, every single menu where I can select a resource, "dockable container layouts" appears as one of the options, even when it would clearly break the object.
Here it is as an option for MeshInstance:

I don't think this needs a workaround or anything, it just looks like it may be a simple fix, so I brought it to your attention.
Thank you for the great tool!

Yeah, I've seen this before. Seems any custom type that inherits Resource just appears in every dropdown menu that accepts one... =/
In this case the custom inspector lets one edit the layout without ever needing to think about resources, I'll just remove the custom type.
Thank you very much for bringing this up! Glad you find it useful ^^


DO UI captions

Fixes https://github.com/CartoDB/bigmetadata/issues/207
It looks like this (@noguerol):

👌

@noguerol asked me to review this in case we were missing anything and I found two things missing (which weren't on the original ticket but also needs to be changed!):

Select a area to Select region and inside the dropdown, Search by area to Search by region. We gotta keep things consistent! :)

Lastly, ampersands (&) are not being rendered correctly on the dropdown. Althought to keep it consistent we should either always use and or always use &. I would go with and.

I'll add this, when there are no measures available:

I'm trying to make the requested changes, although they are a bit trickier than expected, as the texts you want to change are autogenerated. Also, regarding the tag naming (& vs and), it is a bit more convoluted, since it implies regenerating the entire DO dump https://github.com/CartoDB/bigmetadata/issues/231. It's something we will keep in mind for the future, but it's not something that can be changed instantly.

Regarding that one you added, can we not show the "Filters" link when there are no available ones?

Fixed the strings:

Hiding the "filters" element implies adding more logic, and it is an edge case. I only noticed this because I am testing in my local machine that has very little data loaded into the observatory. I think this is something that very few people will see so, IMHO, as long as the message is not clearly incorrect, we should not invest more work.
Yeah, I'm lazy 👉👈 (and also a backender writing javascript, my soul is slowly burning for this :P)

haha fine... yeah, I was confused with that state of not having any filter, there should always be at least SOMETHING, right?

So, we gave a 👍 thanks to @rjimenezda. Should we review anything else?

Yes, please 🙏 Lots of changes since the last review.

Deployed in ded01 for acceptance, thanks to @rubenmoya 💌


Validationmsg

Testing the validation failed because the test was comparing to the wrong message for an invalid e-mail address apparently (the shortest possible e-mail address seems to be 4 characters long, so the message returned by valitron seemed more correct then the one that was in the test)

This happened because the message was updated in Valitron itself in the latest release. Thanks for the fix. :+1:


azureml.core.Model.download is saving model to wrong place

azureml-core:
1.22.0:
Linux:
3.8:

Describe the bug
azureml.core.Model.download(temp_dir="/tmp/foo") gets the target file names wrongly.
For instance, I am trying to download the model to the temporary directory just created /tmp/tmpqw3hzm6u but actually, it gets saved at /tmp/home/salva/foo/g/bar/doz/tmp/chkpt_best_snapshot.h5 because the target name it uses internally is /tmp/tmpqw3hzm6u/../home/salva/foo/g/bar/doz/tmp/chkpt_best_snapshot.h5.
I know because as it is going outside the temporal folder, when I run the code a second time I get the error:
    "error": {
        "message": "File already exists. To overwrite, set exist_ok to True. /tmp/tmpqw3hzm6u/../home/salva/foo/g/bar/doz/tmp/chkpt_best_snapshot.h5"
    }

To Reproduce
Steps to reproduce the behavior:

Call model.download(target_dir="/tmp/foo")

Expected behavior
The model should be downloaded under /tmp/foo
Additional context
/home/salva/foo/g/bar/doz is the cwd from where I am launching the python script.

Thanks for the feedback, we’ll investigate asap.

MSFT internal ref.: https://msdata.visualstudio.com/Vienna/_workitems/edit/1120917

Closing legacy issue.
Please consider upgrading to AzureML CLI/SDK v2. https://learn.microsoft.com/en-us/azure/machine-learning/concept-v2


Core (TCP Layer): Added bytes-alignment field in TCP Header to 8-byte-align the TCP user payload.

This solves an issue with Capnproto. Capnproto requires the serialized data to be 8-bytes-aligned in memory. By already sending the payload 8-byte-aligned, this solves that issue.
Fixes #1017

This PR was untested and should not have been merged. I wanted to merge it after @chengguizi tested it, as mentioned in #1017.
I will re-open the issue that was closed by this PR.


Convert many uses of ClusterComm to Fuerte

Scope & Purpose

[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)

Converts all remaining uses of ClusterComm outside the Cluster folder to use the fuerte-based network methods APIs instead, and some inside the Cluster folder as well.
Between this PR and https://github.com/arangodb/arangodb/pull/10137, the only remaining uses should be in arangod/Cluster/v8-cluster.cpp, which exposes the ClusterComm API to JS, where it is used by a few different modules. This could be a somewhat annoying conversion, so it will be done in a separate branch.
Enterprise component: https://github.com/arangodb/enterprise/pull/339
Testing & Verification
This change is already covered by existing tests.
http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6602/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6671/


Update Grid Full VM Deployment Section

Now the manual will only point you on how to deploy the stack using the script, but I had some issues while using the script it would have been a lot easier to know what did the script do or manual steps to follow instead of the script; which would have helped me to catch the error.
Also, some more info is found here that is not found in the manual.
https://github.com/threefoldtech/grid_deployment/tree/development/docker-compose#deploy-a-full-stack

Can we also mention that the script is downloading 3 large files and extracting them? Download first, then extract it, and then the second, and so on.
And the extracting takes a long time, and its done after that line with no info about that happening (and it takes hours!).

Hey @A-Harby! Good point, we can definitely improve the manual concerning this. Can you give more info?
Are you talking about this? https://manual.grid.tf/documentation/developers/grid_deployment/grid_deployment_full_vm.html#launch-the-script
There is no link to the manual in your issue. Thanks!

OK good. What is the errors you encountered? Then we can document and the full_vm guide and explain how to troubleshoot.
Were you deploying with full vm on the grid?
I will check back the process and adjust the documentation in the manual and the script itself, e.g. we share the link to the script and we explain what it does briefly, and the script could print messages to the users with info on the progress.

There should be a step-by-step to deploy the stack (the only option now is the script) or at least a description for the script.
There should be a very clear note that the script will take hours to download and extract all the files (and showing the progress would be a lot better, but the note is still necessary).
The script downloaded and extracted all the files on the root no matter your pwd, which caused me a lot of issues until I figured it out and had to update the paths manual in the script to my current location (it would be nice to add a path option).
It would be nice to mention where the stacks environment version is coming from and how to update (it says we shouldn't in the file, idk why).
After a successful installation, we should mention how to see the logs of our stack.

That's it for now.

Amazing feedback. Will check this soon with @coesensbert
Thanks @A-Harby

Also found that there's a script for installing the prerequisites; it would also be great to mention those.

Completed when #659 is merged.

all but the script logic applied here: https://github.com/threefoldtech/grid_deployment/commit/0b4b279c15b11379db633b4fc91363d0f1bd5943

Still getting some error but gonna retry again.

Are you deploying on the grid with a Full VM with modern hardware?

I was able to finally deploy the stack after multiple failures in the downloads; I had to do each manually, and also, after finishing the script, it didn't work I had to wait for a while, and I don't why.
But it did work, and here is the link: dashboard.harby.gridtesting.xyz.
And I have also added both your keys, @coesensbert and @PeterNashaat to the VM if you want to check to make sure everything is fine.

The tfchain public node is fully operational and synced.

The processor is also successfully synced.

The dashboard is functioning as expected, listing contracts, available nodes, and farms.

Found some errors in gridproxy

Also found error messages in the relay.

Update

In the last week, Bert (and I to some extent) worked on the TFGrid Full Stack docs on the grid_deployment repo: https://github.com/threefoldtech/grid_deployment
The procedures and docs in that repo is now complete.
This makes some of the manual sections outdated.
I think it's better to just have a section on the manual explaining broadly the TFGrid Full Stack components and then to link from the manual to the grid_deployment repo's docs. This will make it easier for updates and improvements as we won't be needing to adjust 2 sets of independent docs.
Conclusion, I will create another simpler PR linking to the grid_deployment docs instead of having it all on the manual.

This means this PR won't be needed anymore: https://github.com/threefoldtech/info_grid/pull/659
We didn't lose any time as we could troubleshoot the process. I hope everyone understands. LMK if you want to proceed otherwise.

As explained above, closing in favor or #663

I opened an issue for the retry and update all the scripts, https://github.com/threefoldtech/grid_deployment/issues/91.

Thank you for this @A-Harby!

I had the same errors on the testnet proxy IDK why, but the relay didn't show any.

I had the same errors on the testnet proxy IDK why, but the relay didn't show any.

@PeterNashaat @coesensbert, Also the dashboard, working fine creating accounts or sending and receiving requests.

or the time on the server is not correct, or the tfchain node your running is not fully synced.
I'm guessing the latter since we can see it here: https://telemetry.tfchain.grid.tf/#list/0x0378abe88c21bd382106e7977902eef4f542bb2d3e67e8a318151e323b2d0660

Update

The manual now links to the grid_deployment docs: https://www.manual.grid.tf/documentation/developers/grid_deployment/tfgrid_full_stack.html
This means we can work on grid_deployment repo instead of info_grid for anything related to full stack deployment
Let's close this one and work on the grid_deployment issue: https://github.com/threefoldtech/grid_deployment/issues/91


Doesn't work for a website

I want to get the data from website, but cloudflare-scrape doesn't work for this website,
Can you help check cloudflare's verification update? Would be very grateful!

+1 they have changed their technique many websites are not working anymore (e.g. mc-market.org)

+1 they have changed their technique many websites are not working anymore (e.g. mc-market.org), btw it doesnt even work with selenium, not even with this one: ultrafunkamsterdam/undetected-chromedriver#33
Seems the maintainer of that one is working on a solution already.

That's a great news


Feature Request: Atom Feed Name Modification or Default

This is a small/unimportant feature request to allow the customization of the Atom feed name.
When you are viewing the Chocolatey Atom feed, it is named "Untitled" today.
It would be nice to be able to customize the name of this feed.
Alternatively, it could simply be named "Chocolatey" instead of "Untitled".

Thanks for adding that!


chore: release 1.2.0

:robot: I have created a release *beep* *boop*
1.2.0 (2021-11-24)
Features

:sparkles: 测试一下 (75828ee)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/shiheng-fe/test/releases/tag/v1.2.0 :sunflower:


atom-ide-purescript <> pscid imcompatibility: ECONNREFUSED

I always run pscid along atom
but I get a lot of errors:
case 1: atom errors
I get ths in atom

when I "ide purescript: restart psc ide", I then get

then it ends up working
case 2: pscid crash
 (o,o)   (o,o)   ,,,(o,o),,,   (o,o)   (o,o)
 {`"'}   {`"'}    ';:`-':;'    {`"'}   {`"'}
 -"-"-   -"-"-                 -"-"-   -"-"-

Press b to run a full build (tries "npm run build" then "pulp build")
Press t to test (tries "npm run test" then "pulp test")
Press r to reset
Press q to quit

/Users/rvion/dev/redittor/src/Main.purs
/usr/local/lib/node_modules/pscid/output/Control.Monad.Eff.Exception/foreign.js:25
    throw e;
    ^

Error: connect ECONNREFUSED <IP_ADDRESS>:15641
    at Object.exports._errnoException (util.js:1036:11)
    at exports._exceptionWithHostPort (util.js:1059:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)

/Users/rvion/.atom/packages:

├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
pscid --version
1.12.0

pulp --version
Pulp version 10.0.0
psc version 0.10.2 using /Users/rvion/.local/bin/psc

psc --version
0.10.2

/cc @kRITZCREEK

Do you ever close pscid? As I recall both attempt to connect to the same psc-ide-server but I think pscid maybe always closes the server on exit (while the atom plugin only closes it if it was the one who started it)

I usually do not, but I may be closing it from time to time. I'll pay more attention to check if I notice a correlation.
I wrote below a small scenario where the problem does not occurs, but It might also just be that it does not happens each time.

both attempt to connect to the same psc-ide-server but I think pscid maybe always closes the server on exit (while the atom plugin only closes it if it was the one who started it)

could psc-ide have  a close-if-no-consumers action instead that both pscid and atom-ide-purescript ?
also, I have the impression that atom notification and/or pscid message about "starting" a pscid-server are not quite correct:
example
1: start pscid
pscid
Starting psc-ide-server
Watching /Users/rvion/dev/poney-loving-website on port 15859

2: atom: ide purescript: restart psc ide

3: restart pscid
pscid
Starting psc-ide-server
Watching /Users/rvion/dev/poney-loving-website on port 15194

📝 here, pscid reuse the server started by atom-ide-server
4: I close pscid, atom-ide-purescript keeps working


Grab languages for GitHub repos

We should have an array of languages that a GitHub repo uses. This can be just an array or potentially an array of tuples that show the % of each language (like it appears in the web UI) Once this is in, I can create the models.

@ccerv1 as noted in the issue, we don't have all the languages related to a repo. The api call we were already making only returns the "primary" language that github detects. So if we want more languages than that we will need to call an additional API method.


Add cache_file_fixed_block as first piece of filesystem_cache

Commit Message: cache_file_fixed_block: part one of filesystem_cache
Additional Description: #23175 is the target end state of this.
Risk Level: None, it is dead-code until the API part is added.
Testing: Unit tested.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign-from @envoyproxy/envoy-maintainers

@toddmgreer would you be willing to do first pass?

fyi @jmarantz has the most context from looking at the larger PR already.

Windows CI failure seems real:
//test/extensions/http/cache/file_system_http_cache:cache_file_fixed_block_test FAILED in 2 out of 2 in 0.3s

/wait

/wait

@toddmgreer lmk if you are good with this and I'll merge.


No registered 'ResourceScatterNdUpdate' OpKernel for 'GPU'

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): CentOS 7
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4.0rc4
Python version: 3.7.4
Bazel version (if compiling from source): 3.4.1
GCC/Compiler version (if compiling from source): GCC 8.3.0
CUDA/cuDNN version: 10.1
GPU model and memory: V100

Describe the current behavior
A test shows that a GPU implementation for BOOL inputs of ResourceScatterNdUpdate is seemingly missing.
The test is //tensorflow/python/kernel_tests:batch_scatter_ops_test -> ScatterTest.testBooleanScatterUpdate
Standalone code to reproduce the issue
Run bazel test
Other info / logs
ERROR: testBooleanScatterUpdate (__main__.ScatterTest)
ScatterTest.testBooleanScatterUpdate
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/batch_scatter_ops_test.py", line 91, in testBooleanScatterUpdate
    update0 = state_ops.batch_scatter_update(var, [1], [True])
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/util/deprecation.py", line 340, in new_func
    return func(*args, **kwargs)
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/ops/state_ops.py", line 915, in batch_scatter_update
    ref, final_indices, updates, use_locking=use_locking)
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/ops/state_ops.py", line 368, in scatter_nd_update
    name=name))
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/ops/gen_state_ops.py", line 740, in resource_scatter_nd_update
    _ops.raise_from_not_ok_status(e, name)
  File "/tmp/bazel-tf/20db8ac50b74c328e6dea9b20829b459/execroot/org_tensorflow/bazel-out/ppc-opt/bin/tensorflow/python/kernel_tests/batch_scatter_ops_test.runfiles/org_tensorflow/tensorflow/python/framework/ops.py", line 6862, in raise_from_not_ok_status
    six.raise_from(core._status_to_exception(e.code, message), None)
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.NotFoundError: No registered 'ResourceScatterNdUpdate' OpKernel for 'GPU' devices compatible with node {{node ResourceScatterNdUpdate}}
	 (OpKernel was found, but attributes didn't match) Requested Attributes: T=DT_BOOL, Tindices=DT_INT32, use_locking=true
	.  Registered:  device='GPU'; T in [DT_COMPLEX128]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_COMPLEX128]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_COMPLEX64]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_COMPLEX64]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_DOUBLE]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_DOUBLE]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_FLOAT]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_FLOAT]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_HALF]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_HALF]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_INT64]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_INT64]; Tindices in [DT_INT32]
  device='GPU'; T in [DT_INT32]; Tindices in [DT_INT64]
  device='GPU'; T in [DT_INT32]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_BOOL]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_BOOL]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_STRING]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_STRING]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_COMPLEX128]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_COMPLEX128]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_COMPLEX64]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_COMPLEX64]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_DOUBLE]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_DOUBLE]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_FLOAT]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_FLOAT]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_BFLOAT16]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_BFLOAT16]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_HALF]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_HALF]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_INT32]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_INT32]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_INT8]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_INT8]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_UINT8]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_UINT8]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_INT16]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_INT16]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_UINT16]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_UINT16]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_UINT32]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_UINT32]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_INT64]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_INT64]; Tindices in [DT_INT32]
  device='CPU'; T in [DT_UINT64]; Tindices in [DT_INT64]
  device='CPU'; T in [DT_UINT64]; Tindices in [DT_INT32]
 [Op:ResourceScatterNdUpdate]

@Flamefire,
TensorFlow 2.4 is tested and built against CUDA 11 and cuDNN 8. For more information, please take a look at the tested build configurations.
Could you please check if you are facing the same error with CUDA 11 and cuDNN 8 as well? Thanks!

As I can't use CUDA 11 I retested that with TF 2.3 and python git/tensorflow/tensorflow/python/kernel_tests/batch_scatter_ops_test.py ScatterTest.testBooleanScatterUpdate and am seeing the same issue. So I'd assume that this is not related to the version.

The issue is fully expected looking at the source: The bool kernel is simply never declared for GPU, the relevant line is https://github.com/tensorflow/tensorflow/blob/b5c8d770f553c529165292c607bcda46ce370c08/tensorflow/core/kernels/scatter_nd_op_gpu.cu.cc#L201
That uses https://github.com/tensorflow/tensorflow/blob/b5c8d770f553c529165292c607bcda46ce370c08/tensorflow/core/framework/register_types.h#L195-L196
And as one can see the Bool type is missing. I guess using TF_CALL_GPU_ALL_TYPES would be the right choice here

Hi @Flamefire!
We are checking whether you still need any assistance in this issue.
Could you check the above test with Bazel 5.0.0 and TF 2.9 and let us know.
!bazel test //tensorflow/python/kernel_tests:batch_scatter_ops_test
Attached gist for reference.
Thank you!

Test has only moved here: https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/python/kernel_tests/array_ops/batch_scatter_ops_test.py#L86
And code looks still the same: https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/core/kernels/scatter_nd_op_gpu.cu.cc#L201
https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/core/framework/register_types.h#L195-L196
So yes the issue persists.

Hi @Flamefire !
Test seems to be passing in 2.9 , Bazel 5.0.0 and Gcc 7.3 . Attached gist for reference.
Thank you!

Sorry but your gist doesn't show the test passing. Last lines I see are
 [5,459 / 9,765] 2 actions running
    Compiling .../mlir/expansions/segmentation_spmd_expander.cc; 13s local
    Compiling llvm/lib/Target/X86/X86FastTileConfig.cpp; 1s local

As shown in the source there is simply no Boolean type registered for the "ResourceScatterNdUpdate".
So if you evaluate the last expression of
var = variables.Variable([True, False])
update0 = state_ops.batch_scatter_update(var, [1], [True])

on GPU it will try to find a GPU kernel for a bool tensor(see code at https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/python/ops/state_ops.py#L1041 ) and fail with the above error.
I'm not familiar enough with TF to know how to evaluate the above on GPU but if you do that should be enough to reproduce.
Again: This only fails when run on GPU as the CPU kernels is registered for bool: https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/core/kernels/scatter_nd_op.cc#L501-L502

Thanks @Flamefire for the update.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

The issue still persists: Only a CPU implementation is registered: https://github.com/tensorflow/tensorflow/blob/v2.17.0/tensorflow/core/kernels/scatter_nd_op.cc#L655-L657


Convert from Make to Mage

Convert from Make to Mage. Use SDK's Mage logic.

Dooh sorry did not see this PR... either use this or #68
the common stuff expects src/plugin.json so I moved it there

@ryantxu I will try to consolidate the two PRs :)

Thanks @kylebrandt :)

@kylebrandt Sure, but I'm getting feedback from @ryantxu on this one, so I think we're covered :)

@ryantxu Yep!!


fix: semantic-release esm syntax

What
fix: semantic-release esm syntax

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error Your Composer dependencies require a PHP version ">= 8.0.0". You are running 7.4.29.

Describe the bug
Magento 2.4.4
php 8.1
olegkoval/magento2-regenerate-url-rewrites 1.6.0
An error is showing when regenrating url key:
Reindexation...Composer detected issues in your platform:
Your Composer dependencies require a PHP version ">= 8.0.0". You are running 7.4.29.
PHP Fatal error:  Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.0.0". You are running 7.4.29. in /var/www/clients/client1/web37/web/magento/vendor/composer/platform_check.php on line 24
Done
Expected behavior
No error
To Reproduce
execute regenerate command without option "--no-regen-url-key"
Ex: php bin/magento ok:urlrewrites:regenerate --entity-type=category --store-id=4 --category-id=300
Screenshots

I think you are not running on php 8.1, but php 7.4 obviously.
what is the output of "php -v"?
imho this can be closed


Unhandled promise rejections in Secrets Manager

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
Check our Troubleshooting guide: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/troubleshooting
Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/faq

If you are still having issues, please be sure to include as much information as possible:
Environment details

which product (packages/*): google-cloud-secretmanager
OS: MacOS
Node.js version: v18.17.0
npm version: 9.6.7
google-cloud-node version:  ^5.0.1

Steps to reproduce
Please include any and all code and/or steps related to reproducing the bug.

revoke ADC permissions
call listSecrets in a try..catch
initialize is called under the hood (here) but not awaited which leads to an unhandled promise rejection

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
Note: I'm happy to put up a fix for this. Seems like the code is generated. Where is the template from which it is generated?

If my understanding of your issue is correct, it seems related to the following rejection conditions.
https://github.com/googleapis/google-cloud-node/blob/4ae169c9d2fc365e1d2b484f58fceaa88af95764/packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts#L287:L288
As I understand it, the SecretManagerClient flow can be briefly described as follows.
SecretManagerClient -> initialize()-> listSecrets() -> close() -> if (stub && !this._terminated) -> this._terminated = true -> async retry -> initialize() -> if (this._terminated) -> reject

Hi @ssundarraj, would you mind posting the behavior you're getting vs. expected behavior? Thanks!

Thanks for the response @k-oguma and @sofisl
In listSecrets (source) I see this code:
    // ...
    this.initialize();
    return this.innerApiCalls.listSecrets(request, options, callback);

I'm expecting this:
    // ...
    await this.initialize();  // <--------------------------------------------- add await here
    return this.innerApiCalls.listSecrets(request, options, callback);

Here's why I think the client should await the call to initialize:
In my code that uses the client, I do the following:
await client.initialize()
// something could happen here (see below)
const [output] = await client.listSecrets(...)

However, something could change between my call to initialize and my call to listSecrets in a way that the internal call to initialize from listSecrets fails (eg: revoking credentials). This will cause an unhandled promise rejection because the call to initialize is not awaited and there is no way to catch this in my code.

hey @sofisl any timeline for this?

I'll take a look next week!

Sorry this was closed incorrectly.


Calculate() panics when using addons on invoices with no lines

Hey! We are entertaining the use of addons on our side to catch early validation errors, and we spotted a change in behaviour in the (bill.Invoice) Calculate() method when using them.
Granted, an invoice with no items is not a valid invoice, but this is spotted in validation with a graceful error, as opposed to the panic we are getting now during calculation. Preventing this panic leads to cleaner code in library users, as they can avoid manually validating for empty invoices.
It can be reproduced by adding the following test in saft scenario_test, but it happens with any addon that defines scenarios and there's probably better spots for it.
func invoiceNoItems() *bill.Invoice {
	return &bill.Invoice{
		Regime: tax.WithRegime("PT"),
		Supplier: &org.Party{
			TaxID: &tax.Identity{
				Code:    "123456789",
				Country: "PT",
			},
			Name: "Test Supplier",
		},
		Customer: &org.Party{
			Name: "Test Customer",
		},
		Code:      "INV/1",
		Currency:  "EUR",
		IssueDate: cal.MakeDate(2023, 1, 1),
	}
}

func TestInvoiceNoItems(t *testing.T) {
	inv := invoiceNoItems()
	err := inv.Calculate()
	assert.NoError(t, err)
	// Passes
}

func TestInvoiceNoItemsAddon(t *testing.T) {
	inv := invoiceNoItems()
	inv.Addons = tax.WithAddons(saft.V1)
	err := inv.Calculate()
	// Panics here
	// on https://github.com/invopop/gobl/blob/5c886d5d2e70fc5899b205774dc19e5912bd7c43/bill/invoice_scenarios.go:22
	t.Fail()
}

This patch to invoice_scenarios.go:22 should fix it:
if inv.Totals != nil && inv.Totals.Taxes != nil {
	for _, cat := range inv.Totals.Taxes.Categories {
		for _, rate := range cat.Rates {
			exts = append(exts, rate.Ext)
		}
	}
}

I understand an invoice with no items is not a common use case and in fact does not pass validations, but I don't think this panic is desirable. We can open a PR for these, please let me know your thoughts.
Thanks!

Thanks @tomasguinzburg! So this sounds like a bug whereby the lack of lines is not taken into account. We're actually planning to make lines optional if either charges or discounts are present, so we do indeed need to fix this. We'll have a look 👍


Parallel executing of task on multiple server + different config per server?

Hello,
I am using multiple server to deploy app (DB,app, backend etc) and its executing tasks by task server by server, any change we can execute these tasks at the same time?
Also how about differnet .env for each server is that possible? (atm i am faking the DB host in /etc/hosts)
thanks

Definitely something I want to do, just haven't figured out how to do it yet. I did play around with it for a while but my solution didn't work correctly so I needed to go back to the drawing board.
Hmm, had not thought about different files for each server, could be useful. One way you could do it currently I guess is set up the file and then add a "After Install" command to replace the DB host in the file using sed and only run it on the server you need a different value.


Error category for unsupported kernelspec file arg

For #5492

Codecov Report

Merging #5735 (fd4856b) into main (c7d5fde) will increase coverage by 3%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #5735    +/-   ##
======================================
+ Coverage     69%     72%    +3%
======================================
  Files        403     403
  Lines      26851   26857     +6
  Branches    3910    3910
======================================
+ Hits       18595   19548   +953
+ Misses      6637    5656   -981
- Partials    1619    1653    +34

Impacted Files
Coverage Δ

src/client/common/errors/types.ts
52% <ø> (ø)

...atascience/kernel-launcher/kernelLauncherDaemon.ts
94% <100%> (+<1%)
:arrow_up:

.../datascience/notebook/notebookControllerManager.ts
84% <0%> (-1%)
:arrow_down:

src/client/datascience/notebook/helpers/helpers.ts
73% <0%> (ø)

...t/datascience/notebook/vscodeNotebookController.ts
77% <0%> (ø)

...ient/datascience/editor-integration/codewatcher.ts
69% <0%> (+<1%)
:arrow_up:

...atascience/jupyter/kernels/jupyterKernelService.ts
80% <0%> (+<1%)
:arrow_up:

src/client/common/configSettings.ts
90% <0%> (+<1%)
:arrow_up:

src/client/datascience/webviews/webviewHost.ts
87% <0%> (+<1%)
:arrow_up:

...rc/client/datascience/jupyter/jupyterConnection.ts
86% <0%> (+<1%)
:arrow_up:

... and 62 more


Need a simple backchannel sample

As of now, there appears to be a backchannel sample that piggybacks on channelData. Sending data this way is predicated on already sending a message, but there are several valid reasons for sending a custom event as a backchannel message instead. In a true "backchannel" the client shouldn't need to render anything.
This sample should demonstrate backchannel in both directions - the bot making changes to the client and the client sending events to the bot. There was a sample in the previous version of webchat that did this fairly well.

(For reference): I believe you're talking about this sample: 14.customization-piping-to-redux
We have another issue https://github.com/Microsoft/BotFramework-WebChat/issues/1516 filed, which will show users who don't know Redux how to use event listeners.
On top of that, we should add a new sample that shows users how to send activities of type event using a button click. Adding to 4.4 :)


GlobalMarineNet.9555UpgradeTool version 1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Automatic Validation ended with:

We need an emoji of a guy saying “dependencies” at this point.

/AzurePipelines run

Automatic Validation ended with:

(Automated response - build 516.)

@upintheairsheep it's been a while since this PR was raised. I don't know if the situation has changed with the driver requiring user interaction or not, and the schema should be updated to 1.9.


Remove rate methods require rate value

The following methods require a rating on removing a rating, which is not required according to the TMDB documentation.
theMovieDb.movies.removeRate
theMovieDb.movies.removeRateGuest
theMovieDb.tv.removeRate
theMovieDb.tv.removeRateGuest
theMovieDb.tvEpisodes.removeRate
theMovieDb.tvEpisodes.removeRateGuest

Great review, thanks for it! :)


bugfix for HITEMP/HITRAN HMC

When implementing api, I made a bug in MdbHitemp and MdbHitran:
I used jnp array for self.uniqiso, but this breaks JITtable feature.
I restored them to np.array.
I rewrote exojax/tests/endtoend/reverse/reverse_modit_hitemp.py using api.

Related to #253

Thanks!


Minor update to Struts 2.6 SecurityMemberAccess.

Minor update to Struts 2.6 SecurityMemberAccess.
Code changes:

updated SecurityMemberAccess constructor (minor parameter name cleanup, added comment).  Mirrors recent update to 2.5.x equivalent constructor.
added final modifier to a couple of local variable declarations (clearly constant within the given methods).

Coverage remained the same at 46.893% when pulling 54031d286f2716ffc7ffe8f233501c5bada10cfe on JCgH4164838Gh792C124B5:localS2Branch into 3ff6fd8f49fb9d1b23ebaf08d3080355a5d17633 on apache:master.

LGTM :+1:


ExipirationDate in PushChannel is incorrect

Describe the bug
var pushChannelCreateResult = await PushNotificationManager.Default.CreateChannelAsync
The request is succeeding and I’ve verified that I can send a push notification to the app with the returned URI, but the expiration time is coming back in a very weird fashion (or perhaps I don’t understand how the field is meant to be interpreted).
I’ve pasted the values from the debugger here.
Name	Value	Type

◢	pushChannelCreateResult.Channel.ExpirationTime	{1/1/1601 1:38:08 AM -05:00}	System.DateTimeOffset
▶ ClockDateTime	{1/1/1601 1:38:08 AM}	System.DateTime
▶ Date	{1/1/1601 12:00:00 AM}	System.DateTime
▶ DateTime	{1/1/1601 1:38:08 AM}	System.DateTime
Day	1	int
DayOfWeek	Monday	System.DayOfWeek
DayOfYear	1	int
Hour	1	int
▶ LocalDateTime	{1/1/1601 1:38:08 AM}	System.DateTime
Millisecond	553	int
Minute	38	int
Month	1	int
▶ Offset	{-05:00:00}	System.TimeSpan
Second	8	int
Ticks<PHONE_NUMBER>85532024	long
▶ TimeOfDay	{01:38:08.5532024}	System.TimeSpan
▶ UtcDateTime	{1/1/1601 6:38:08 AM}	System.DateTime
UtcTicks<PHONE_NUMBER>85532024	long
Year	1601	int
▶ _dateTime	{1/1/1601 6:38:08 AM}	System.DateTime
_offsetMinutes	-300	short
Steps to reproduce the bug
Register an Azure Application
Using WinAppSDK (latest version) to create an app that calls:
PushNotificationManager.Default.CreateChannelAsync
Expected behavior
No response
Screenshots
No response
NuGet package version
Windows App SDK 1.2.2: 1.2.221209.1
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

This issue has been fixed in 1.2.4.


Enable script and style block support

This switches Razor to html-delegation language server which supports CSS and JavaScript in HTML. I did a quick sanity test, and I'm not seeing any major blockers.

Spoke to @alexgav offline. This would break HTML formatting for now but @ToddGrun is already working on adding formatting support so it should only be temporary until that is merged.


Add wheelPreventDefault, min/max lat/lon options

@dmnsgn so i got merge error as i implemented the same thing with preventDefault but slightly different. I check if zoom happened (if it's enabled basically) and always cancel. So disabling zooming enables scrolling. Are there cases where you would like to zoom and scroll at the same time?

TBH i should probably invert return value to
if (scroll(e.deltaY) === true) {
  e.preventDefault()
  return false
}

published as 2.8.0 with wheelPreventDefault removed as i now call e.preventDefault automatically if zoom is enabled


Add a detailed guide on how to how contributing to this project in the Readme.md file

Hey I've worked on issue #4 . I've added detailed information regarding contribution and added necessary hyperlinks related to the same. I've also generated the list of contributors and added it in the end. I've created a folder called assets/images for all the images used in the readme.md file.
Thank you.

@Sohoxic Love your enthusiasm for this project but try to solve only the given issue. I see that you have made changes which are irrelevant the the actual issue. Thankyou anyways. Consider this from next time

I have made the necessary changes. Thank You

@Sohoxic LGTM 👍


Allow users to delete (hide) their own content

Right now we limit hiding articles to admins, but users should be able to remove their own content from view as well.
This does raise issues about ownership and transparency:

Can only the original author of an article delete it, and do contributing authors get notified?
Do we show this option as "Hide content" (true, but confusing) or "Delete content" (fits user expectations, but misleading).

Here's how Wikipedia deals with this: https://en.wikipedia.org/wiki/Wikipedia:How_to_delete_a_page
I agree with their method - no one except admins should be able to permanently hide or delete content, even if they are the author. Having some kind of 'tagging' or 'reporting' system is probably the best option.

We don't allow users to hide/delete content because of all the authorship/contributor issues.
We can add an FAQ item about requesting deletion. ie: "How do I delete content? Only admins can delete content on Participedia..." etc. (we can borrow some of the language from the wikipedia link that scott posted - good stuff).
Note that we still need to deal with version control (https://github.com/participedia/frontend/issues/587) before we can fully explain the system to users.

Added an FAQ item to the copy deck for @andreadelrio to add to the help sidebar.


Commercial Interest and Consulting

Our group would like to talk with you about using this project for commercial purposes. Please email if you are able to discuss.

OK:) I have sent a mail.

Sorry, my phone sent too soon. I emailed you at gmail yesterday, did you receive it?
Sent from my iPhone

On Nov 13, 2017, at 9:21 PM, Gerald Wiltse<EMAIL_ADDRESS>wrote:
Hello,
My name is Jerry. My team and I learned of you through NPCap. Your work is very interesting to us.  Your experience on each of these projects is related to our goals:
windows drivers in C, NDIS6
VeryFastVPN
Mets can
RBAC
Sent from my iPhone

On Nov 13, 2017, at 9:05 PM, Yang Luo<EMAIL_ADDRESS>wrote:
OK:) I have sent a mail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks Jerry! for being interested in my projects:) I saw the mail. But sorry that I already found a full-time job now:) I have updated the status at my GitHub profile:) But I'm still interested in pushing forward these open-source projects by cooperating with companies or organizations. So do you think it still works?


z.union has no _parseSync method with bare literals

I'm getting an error when trying to call parse on a union with primitive literals:
const schema = z.union(['a', 'b'])
schema.parse('a') // Throws Error: option._parseSync is not a function

Using numbers or booleans gives the same results.
Changing the union to an enum or wrapping the literals in z.literal fixes the issue.
Zod version 3.22.4

I understand how this API could be useful, but it's intentional and I'm not planning to add support for literal values in z.union. This exact use case is already covered by z.enum.


Update ember-cli-htmlbars dependency

To avoid this deprecation warning under Ember 2.6+:
DEPRECATION: Overriding init without calling this._super is deprecated.
Please call `this._super.init && this._super.init.apply(this, arguments);`
addon: `ember-cli-htmlbars`

All merged + published. Thanks!


[question] where is the checkout task? Is checkout a task?

Question, Bug, or Feature?
Type: Questions
Enter Task Name: checkout
Description
Like ~1.5 weeks ago we started started having some really weird checkout errors with lfs files, git just simply not replacing lfs pointer with their real contents.
I was hoping to be able to inspect the checkout task but I could not find it, could someone point me out where is it located

Hey @FrancescElies the checkout task is a little odd in that it lives as a plugin on the agent. I'd recommending asking any questions in that repo - https://github.com/microsoft/azure-pipelines-agent/tree/master/src/Agent.Plugins


Incorrect redirect for account activation

Bug Description

Using try.gogs.io (unsure if latest version of Gogs), creating a sample account and clicking Sign in to your e-mail button redirects to mail.8282.8282/. Used following values: username => test8282 and email =><EMAIL_ADDRESS>
Gogs Version

© 2015 Gogs · Version: <IP_ADDRESS>4 Beta

Git Version

N/a

System Type

Linux

Error Log

N/a

Other information

Thanks your feedback!
Gogs does not know what the URL of mail service you're using, so mail.* is just a good guess.
Do you have any other good suggestion on how to precisely get the correct URL on the fly? Thanks.

Hello~
I could think of couple (following) possible solutions:

keeping large table of known domains (i.e. gmail.com) and redirect to matching key:value set. However, I think this is suboptimal and inefficient method as the maintainer is required to keep track of growing population of email services.

just redirecting to the domain provided (i.e. outlook.com|yahoo.com) after @ (and without mail.*). If the email address was just a throwaway email and invalid (i.e. @8282.8282), then the expected result of "signing-in" would've been failed anyways. For example:

Test cases:

User Input
Redirect To
Should be Redirected?
Success/Fail

<EMAIL_ADDRESS>gmail.com
:white_check_mark:
:white_check_mark:

<EMAIL_ADDRESS>outlook.com
:white_check_mark:
:white_check_mark:

<EMAIL_ADDRESS>yahoo.com
:white_check_mark:
:white_check_mark:

<EMAIL_ADDRESS>1238.234
:white_check_mark:
:x:

<EMAIL_ADDRESS>1232.com
:white_check_mark:
:x:

<EMAIL_ADDRESS>(caught by initial regex filter)
:x:
:x:

<EMAIL_ADDRESS>(caught by initial regex filter)
:x:
:x:

test@!.!
(caught by initial regex filter)
:x:
:x:

test@@
(caught by initial regex filter)
:x:
:x:

As long as the email domain is alphanumeric, I think this could work.

@initbar thanks to your very nice table!

I've pushed some code to redirect to the domain without mail. prefix as you suggested to develop branch.

~(˘▾˘~)

Close as fixed :joy:


Clear Notifications on Android

Hi everyone,
I would like to clear notifications on android, even if my app is not in the background.
Is there a way to do that?
Use case: Chat.
My user receives a message, as a push, reads it on another device and I would like the push to be removed then.

Closing as duplicate of #346.


cargo nextest fails to archive for aarch64-apple-darwin when there is a windows-only dependency on windows-rs 0.40+

Reproducer:
[package]
name = "nextest-reproducer"
version = "0.1.0"
edition = "2021"

[target.'cfg(windows)'.dependencies]
# windows = "0.39.0" # Works
windows = "0.40.0" # This and below fails
# windows = "0.41.0"
# windows = "0.42.0"

fn main() {
    println!("Hello, world!");
}

Building works:
cargo clean; cargo build --all-targets --target aarch64-apple-darwin --release --workspace

   Compiling nextest-reproducer v0.1.0 ([CWD]/nextest-reproducer)
    Finished dev [unoptimized + debuginfo] target(s) in 0.40s

But cargo nextest archive doesn't:
cargo clean; cargo nextest archive --target aarch64-apple-darwin --release --workspace --archive-file "target/tests.tar.zst"

error: error parsing Cargo metadata

Caused by:
  failed to construct package graph: for package 'windows 0.40.0 (registry+https://github.com/rust-lang/crates.io-index)': for dependency 'windows_aarch64_gnullvm', parsing target 'aarch64-pc-windows-gnullvm' failed: unknown target triple

Meta

Fails on both a M1 Mac and a Linux CI
cargo nextest --version: 0.9.36

rustc -Vv

rustc 1.64.0 (a55dd71d5 2022-09-19)
binary: rustc
commit-hash: a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52
commit-date: 2022-09-19
host: aarch64-apple-darwin
release: 1.64.0
LLVM version: 14.0.6

cargo -Vv

cargo 1.64.0 (387270bc7 2022-09-16)
release: 1.64.0
commit-hash: 387270bc7f446d17869c7f208207c73231d6a252
commit-date: 2022-09-16
host: aarch64-apple-darwin
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.79.1 (sys:0.4.55+curl-7.83.1 system ssl:(SecureTransport) LibreSSL/3.3.6)
os: Mac OS 12.6.0 [64-bit]

Thanks! This was a dependency update that was needed and just happened. Going to get a new release out shortly.

cargo-nextest 0.9.37 is out with the fix. Thanks.


what and where is the "mask video"?

thank for great paper and source code. what and where is the "mask video"?

after reading code of add_bees_to_video.py, finally understand what is "--mask" mean. T think we should rename "--mask" to "--output_mask"


Change DeveloperGuide

Codecov Report

Merging #185 (9a9c5c4) into master (c4b692d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage     68.24%   68.24%
  Complexity      724      724
=========================================
  Files           116      116
  Lines          2485     2485
  Branches        292      292
=========================================
  Hits           1696     1696
  Misses          697      697
  Partials         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b692d...9a9c5c4. Read the comment docs.


Cluster docs are incorrect for providing a subscription

File: cluster/cluster-file.md
From reading the docs under https://docs.docker.com/cluster/cluster-file/#cluster, I would expect the syntax to be:
cluster:
  subscription: sub-<id>
  license: /path/to/docker_subscription.lic

but that doesn't work...it is:
cluster:
  subscription:
    id: sub-<id>
    license: /path/to/docker_subscription.lic

There appears to be a missing section of all of the values under subscription.  I am not sure if there is more than id and license.

Thx @mbentley


Update CLA allowlist

I have read the CLA Document and I hereby sign the CLA

Oops forgot about this. Thanks @gj !


[move-prover] model dynamic fields with built-in vec and map ops

PR in current status is for demonstration and discussion only. The code needs polishing before landing.
This PR is to demonstrate a proof-of-concept on how we might be able to model pre/post conditions on both key and value in dynamic fields / dynamic object fields using Vec (to emulate a set actually) and Map that is already supported in the Prover.
In particular, the Vec (or set) tracks a
struct NameShard<Name: copy + drop + store> has key {
    names: vector<Name>,
}

which hosts all keys of a particular type Name associated with an object ID
And the Map tracks a
struct PairShard<phantom Name: copy + drop + store, phantom Value: store> has key {
    entries: prover::Map<Name, Value>,
}

which holds the key-value pairs of a particular (Name, Value) type pair associated with an object ID.

This depends on the landing of https://github.com/move-language/move/pull/902

Now depending on the landing of https://github.com/move-language/move/pull/909


Feat: Supabase Storage Adapter

This is an adapter for Supabase Storage.
Locally it works correctly, so I look forward to the review of the code, to improve the parts of the code that are necessary.
Greetings @denolfe @jmikrut :wave:

Hi Fellas! This PR arises from a need, in search of solutions for a project that I am building for a NGO. It would be great if you could give me some feedback, because I think it's a good contribution. Supabase currently has 1gb of bucket storage in the free tier :ok_hand:
greetings @jmikrut :smile:

I tested this out and it was working as expected. Before merging, I was reviewing the extra dependency for fast-blob-stream. That pacakge was only calling 1 line of code and relies on a different dependency, streamx. I was trying to dig into it further to see if we can eliminate the need for any extra dependencies altogether when I ran out of time.
Can somebody investigate if we can handle the stream in the adapter code from supabase without introducing any extra dependencies?

I tested this out and it was working as expected. Before merging, I was reviewing the extra dependency for fast-blob-stream. That pacakge was only calling 1 line of code and relies on a different dependency, streamx. I was trying to dig into it further to see if we can eliminate the need for any extra dependencies altogether when I ran out of time.
Can somebody investigate if we can handle the stream in the adapter code from supabase without introducing any extra dependencies?

Hi @DanRibbens !! I tried without additional packages, but the format that comes from supabase did not let me parse it to Stream Write. If anyone has any suggestions i will adapt it.
You can check this PR about Streams in supabase, maybe it's helpful.
https://github.com/supabase/storage-js/pull/137

Just want to point out that this seems even more interesting since the support of postgres with payload 2.0

Would love a Supabase Storage Adapter as well! Very interesting now that Payload supports Postgres

I am currently setting up a payload cms instance with Supabase and this is the missing piece for me since the addition of the postgresAdapter in payload 2.0
@jorgeAgoiz thanks for your work so far! Are you still interested in getting this PR merged? I saw there are some merge conflicts at the moment.

This plugin is now being maintained in the Packages Directory of the Payload Monorepo. This repo will soon be archived and all open PRs including this one will be closed. Would you be willing to re-open this same PR but within the Payload monorepo?


XGBoost Implementation

Hi all,
I'm trying to implement XGBoost, using GradientBoostedTreesModel with use_hessian_gain. After some tweaking of the parameter, while working with different datasets on binary classification problem, I cannot replicate the trees and results of xgboost's XGBClassifier; but as far as I understand, it should produce the same algorithm.
Did somebody tried this, or is this even possible? If yes can you point me in the direction of how I need to configure GradientBoostedTreesModel and if not is there an implementation of XGBoost planned?
Thanks so much in advance,
Timo

Hi Timo3as,
I replies to your question in the Yggdrasil issue.
Cheers :),
M.


Refactor shop page card

Remove take me to cart button.
Fix width for + and - button
Picture of product should be fixed

.


Scrape name and thread count from incoming subjects

When we're making a plan or fuzzing a plan, we should read in the name of the test and scrape the number of threads in the test.  These can then be used later on (all over for the former, and for thread count filtering in the latter).

We now scrape the name, but need act-c to provide thread counts to be able to do the next bit.

Done (we now use act-c dump-stats).


Is there a way to load remote LUT?

Yes, there is.
As you can see from this documentation, you can load LUT from anywhere.
https://www.notion.so/muukii/Creating-your-own-filters-LUT-d1942f2f5bcc44d88481d0a0cc4aacb3#cd76a9a88bfe435bae83348b6ffcbbf2

Sorry, currently loading from bundle only.
But I will try to make it can load from anywhere.

I figured out to create filter from LUT that loaded from remote.

Load the image for LUT
Save it to anywhere you want
Get the path to that

let filter = FilterColorCube(
  name: /* name */,
  identifier: /* ensure get a unique identifier*/,
  lutImage: /* create an instance */,
  dimension: 64 /* it's depends on your LUT */
)

https://www.notion.so/muukii/Creating-your-own-filters-LUT-d1942f2f5bcc44d88481d0a0cc4aacb3#b676c5123a0246798c75614dcb5f9f34

ColorCubeStorage.default.filters = [filter]


Save KaplanMeierFitter model to disk

Hi,
Is there any way to persis the KMF model on disk like sklearn functionality?

Yes, try dill
from dill import dumps, loads
kmf = KaplanMeierFitter().fit([1,2,3])
s = dumps(kmf)
kmf_ = loads(s)
kmf_.plot()


SW-2946 Make modal bigger to avoid button text overflow

We could also change the text of the button, I don't know what is the preference here? @chudo76

We could also change the text of the button, I don't know what is the preference here? @chudo76

Yes, we can change to "Get Count".
(Ideally, all buttons have a minimum height instead of a fixed height so that even if we have unexpected long labels (with localization, or user's browser text settings, for example) the button grows taller. It will be a visual bug with the button looking weird, but it would be better than not being able to read the button text.)


HDDS-5362. [FSO] Support bucket layouts in OM

What changes were proposed in this pull request?
We are introducing 3 types of bucket layouts as of now in Ozone.

FSO (File System Optimized):- For this bucket, we need the configuration “ozone.om.enable.filesystem.paths” to be set to true.
Behavior:

Supports atomic rename and delete operations.
Files written to this bucket can be read via S3.
Keys written via S3 with a delimiter “/” will create intermediate directories.
This bucket will allow interoperability between S3 and FS APIs.

OBS (Object Store):- For this bucket, we need the configuration “ozone.om.enable.filesystem.paths” to be set to false.
Behavior:

Keys written to this bucket will behave as a pure object-store.
Keys written via S3 with a delimiter “/” will not create intermediate dirs.
This bucket will not allow interoperability between S3 and FS APIs.

LEGACY:- This bucket layout has been introduced to handle the case of upgrading an existing cluster with pre-created buckets.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5362
How was this patch tested?
Tested Manually

Good Work. Thanks a lot @aryangupta1998 for the continuous efforts in refining the patch.
Thank you @xiaoyuyao @mukul1987 @elek @bharatviswa504 for the useful comments and discussions.
I've merged it to master branch.


Netlist dsl

I've been playing around with a netlist dsl. I don't necessarily have a concrete use case for it. Since its PHOAS based it might be useful for netlist transforms, and proving things about netlist transforms.


Setting private_key_pw results in SSL Error

Environment

OS / version: Fedora 29
Processor architecture: X86_64
TPM Manufacturer: Intel
Keylime version: master

Description
When setting private_key_pw the keylime registrar exits with a stack trace.
# keylime_registrar
Using config file /etc/keylime.conf
2019-04-16 09:24:34.425 - keylime.cloudverifier_common - INFO - Setting up TLS...
Traceback (most recent call last):
  File "/usr/bin/keylime_registrar", line 11, in <module>
    load_entry_point('keylime==1.2', 'console_scripts', 'keylime_registrar')()
  File "/usr/lib/python2.7/site-packages/keylime-1.2-py2.7.egg/keylime/registrar.py", line 34, in main
    registrar_common.start(config.getint('general', 'registrar_tls_port'),config.getint('general', 'registrar_port'),config.get('registrar', 'db_filename'))
  File "/usr/lib/python2.7/site-packages/keylime-1.2-py2.7.egg/keylime/registrar_common.py", line 428, in start
    generatedir='reg_ca')
  File "/usr/lib/python2.7/site-packages/keylime-1.2-py2.7.egg/keylime/cloud_verifier_common.py", line 154, in init_mtls
    context.load_cert_chain(certfile=my_cert,keyfile=my_priv_key,password=my_key_pw)
ssl.SSLError: [SSL] PEM lib (_ssl.c:2798)

Reverting back to default results in the registrar starting without any issue.
Expected behavior vs. actual behavior
Steps to reproduce problem

Set private_key_pw = kjshd89y98hohfjhjhj in /etc/keylime.conf
Start the registrar

Hi @lukehinds , if you're using CV-generated keys then the password for the registrar and tenant must be the same as the password set for the verifier (since they all use the same keys).
See the notes under tenant and registrar:

https://github.com/keylime/python-keylime/blob/master/keylime.conf#L216
https://github.com/keylime/python-keylime/blob/master/keylime.conf#L385

Does it work if you update those passwords to match the one you set in the cloud_verifier section?

Hi @jetwhiz , my bad I missed that.
I will keep this open and we can perhaps validate this somehow so its captured. Will change to enhancement.

It could definitely use some clarification that this needs to be done.  Maybe all three sections can mention that the related passwords must all be updated if they are CV-generated and the pw is not set to "default"?

Keep


<issue #888 fixed>

issue #888 fixed.

@piyush-1234 Please don’t submit pull requests for an issue that someone else has already requested to work on. @krishguptadev had already asked to be assigned which means that either you or Krish end up doing work unnecessarily. Feel free to take an issue that’s not already taken.

@piyush-1234 I assigned #886 to you so please remove the snapchat icon from your PR as someone else is already working on that.
As @nathgoutam93 please also add a color for the icon the the links.json files and please also update the readme with the icon so that others know that it's available for use.

@piyush-1234 Please don’t submit pull requests for an issue that someone else has already requested to work on. @krishguptadev had already asked to be assigned which means that either you or Krish end up doing work unnecessarily. Feel free to take an issue that’s not already taken.

ok. thanks for the guidance as i am new to the opensource.

@piyush-1234 I assigned #886 to you so please remove the snapchat icon from your PR as someone else is already working on that.
As @nathgoutam93 please also add a color for the icon the the links.json files and please also update the readme with the icon so that others know that it's available for use.

yes.

ok. thanks for the guidance as i am new to the opensource.

Let us know if you need any help :)


Add MPI support to ParaGrid

Add MPI support to ParaGrid
closes #534
closes #454
closes #448

Task List

[x] modify make_init_para24x30.py to use new DG data layout and remove CG vars
[x] add MPI doctest support to ParaGrid_test.cpp
[x] move extent and start variables into ModelArray's DimensionSpec
[x] add special MPI test case to ParaGrid_test.cpp
[x] add MPI support to getModelState
[x] add MPI support to dumpModelState
[x] add MPI support to writeDiagnosticTime
[x] reinstate test ConfigOutput_test.cpp for MPI builds
[x] add MPI support to ERA5/TOPAZ tests

Change Description
After #331 added MPI parallelisation for thermodynamics on the RectGrid, this PR does the same for the Parametric grid. This should then check off the second task in #120 ("MPI parallelization of thermodynamics where all operations, except for I/O, are local to an MPI rank")

Test Description

ParaGrid_test.cpp tests core functionality of ParaGrid (serial and MPI)
./nextsim --config-file config_para24x30.cfg should provide an integration test (serial and MPI) (based on #506)

Further work (for a future PR)

add MPI to dynamics (to close PR #120)
implement halo comms
implement boundary conditions (as part of MPI)
tidy naming of variables in Domain Decomp tool

As stated in the README, we follow WebKit style
https://webkit.org/code-style-guidelines/#names-basic


How to export in smoke signal format?

I was told I could export my CV as smoke signals but I can't seem to figure out how. Can anybody help? Is this a bug?

Hi @nmai, yes. You'll need a campfire, a blanket, and lots of green wood. This should probably be added to the README. If you're near a park, you could also try our carrier pigeon format as a temporary workaround. Thanks for the report and I'll update when this has been addressed.

Thanks I really appreciate the help. The carrier pigeon workaround is a good suggestion, if a bit hacky. I'm fairly sure I'm up-to-date on my bird flu vaccinations so I'll give it a shot!


[branch2.0] disable some external hive case for complex type

Proposed changes
branch 2.0 does not support complex type in Nereids, disable these cases
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run external


Ligand Preparation / Result Issue with Docking V2

When running Uni-Mol Docking V2 via the demo.sh script on a custom protein-ligand, every part of the process seems to complete successfully, but the result file for the ligand is different than the input ligand. Do I need to prep the ligand in a certain way to resolve this?

I also have a similar issue, but not like that much of above image. Bond lengths are shortened with unfavorable angles. Can I find the docking v1 checkpoint file to compare with v2? Thanks for helps.

You can try turning on the --steric-clash-fix parameter in demo.py.

I also have a similar issue, but not like that much of above image. Bond lengths are shortened with unfavorable angles. Can I find the docking v1 checkpoint file? Thanks for helps.

docking v1 checkpoint is here.
The name is ‘Protein-ligand binding pose prediction’.

Although also have this issue when I run docking myself for some reasons, the result I got from the bohrium lab service is great. Any idea how to fix this?


[SMALLFIX] fix docs to show pages as .html

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/186/
Test PASSed.


upgrade.sh's image removal causes conflicts with existing third party containers sharing same dependency

I am just going through my first upgrade of the Dashboard.
I am running into problems as the removal of the images (docker rmi step) fails.
I am using some of the images also in different projects (in my case it is telegraf). So it is not simply possible to perform the docker image removal like the upgrade script tries to because of these dependencies.
I have worked around this, by removing (and recreating) my other projects, but this feels very invasive. In a nutshell the upgrade.sh in its current form assumes exclusivity, which it should not.
I would recommend a different approach for the upgrade, like for example using an explicit docker pull telegraf:latest instead.

Hi @GrimmiMeloni ! Thanks for opening this.   It would be good to make this change. Are you interested in submitting a PR to fix it?  I'll tag this as a bug.

Hey Jason, happy to help.
Before I start hacking away, let's agree on what the end result should look like.
I would suggest the following solution:

remove the image removal steps out of upgrade.sh. My rationale is both the problem stated in my initial report, but also after more thought, I think Powerwall-Dash even without such a problem, should not touch the local image registry and toss things away. I think it should be left to the system's operator to decide when a good time for pruning has come.

Change the compose file, to move away from using latest images, and use explicit versioning of the dependencies. It is anyways good style (repeatable builds/installs), and will also ensure that all users of Powerdash have the same experience. A good summary on all the shenanigans using latest bring can be found here.
This change removes the need for explicitly tossing the local images away to fetch something "fresh". Compose can take care of pulling the specified images.
I suggest the following explicit versions, based on what my local host pulled during yesterday's upgrade.

Telegraf: 1.26.1
pypowerwall: 0.6.2t25
weather411: 0.2.1

remove the image removal steps out of upgrade.sh

Agree!  Plus, the current upgrade is way too slow, mostly due to this image churn.

Change the compose file, to move away from using latest images

Agree!  This is brilliant. This makes the version of Powerwall-Dashboard consistent.  We should rev the project version (in files VERSION and upgrade.sh)  if we change any of the pins. As you pointed out so well, current state makes the project version meaningless and everyone is potentially using a different combination. That makes it difficult to troubleshoot and manage.
Thank you for your help @GrimmiMeloni !  🙏 This will be a great enhancement.

Thanks @GrimmiMeloni !  Merged and released as v2.9.0.
Please report any issues.


Add supports for recursively outputting generated array arguments

Discription of PR
Currently the parameterized junit4 branch only outputs an address for arrays, which is not helpful for debugging. This PR instead prints the content of an array. If the content of an array is also array, this PR also adds support for outputing them recursively. This PR also changes the output formats to recursive folders, i.e., $argFile/$indexOfArg/$indexInArray/...
For Code Changes:
A new function observeGeneratedArgs is added so as to 'decompress' the arrays and output the elements recursively. A maxRecurDepth is also added to prevent stack overflow caused by too many layers of recursion.
The change has been tested on small maven projects.

I am not sure about having each array element in its own file. For example, it seems awkward to need to go through 100 files to see the full contents of an array of length 100. I think that it makes the most sense to write each argument to its own file.
This will throw a NullPointerException if an element of args is null or is an array containing null. It will also recurse infinitely on an array containing a self reference.

The problem before was that for arrays, the content in its file is only some address of it (something like [@0xba52). This doesn't really help the debugging process. For having each array element in its own file, is putting all the elements in one file more acceptable?

I pushed a commit to your branch that should print arrays in the same format used by java/util/Arrays. Let me know if that format is works.
One alternative to printing the generated arguments is to set the property "-Dmeringue.debug" which will cause forked analysis JVMs to suspend and wait for a remote debugger to attach on port 5005.

I tried it on some small projects and it indeed works. Thanks for the fix!


revert to clean class definitions for event listeners

In order to fix #385 while keeping #347 fixed.
/cc @m-vo

Coverage decreased (-0.9%) to 97.572% when pulling ce3710b34bc7859b0bee073c0edc53801dc6c80e on fix-385 into a416ea040ed180e46b5cbc3d02d5c9f33dd5df3e on master.

Cool. Thank you, @m-vo.


[docs] Upgrading - mention peerDependency on React

Fixes issues with docs from https://github.com/facebook/react-native/issues/11104.
We should document people should update both react and react-native until we switch to the new upgrades.

cc @ncuillery

Looks good

If you run the commands you propose, the react-native package will be invalid.

What we should add to the documentation is something like:
If you see a Peer dependencie issue in the react version, ADD the react upgrade, doing for example:
npm install --save<EMAIL_ADDRESS><EMAIL_ADDRESS>or
npm install --save react-native@[version-you-want] react@[version-in-the-warning]

@mkonicek I'm not sure i's a good idea to explain the unmet dep problem in RN docs. Couldn't we assume that users know about maintaining a "NPM-handled" JavaScript project  ? NPM warning is already explicit about what to do in such a case.
As I mentioned above, it could happen because of the link between React & RN but it's a general problem.
Moreover it's hard to describe because NPM3 and NPM2 have different behaviors. The changes you've made concern NPM3 only. NPM3 merely shouts a warning but NPM2 exits the process with an error code.


Update add_missing_switch_cases code template

Updated code generation to 'throw UnimplementedError()' instead of returning 'null' and put the 'Handle this case' reminder message in the Error instead of an additional comment.
This fix addresses issue #53832.

[X] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

Ah, there is also Gerrit CL.
I will repeat my comments there :-)

Thanks for this contribution! Definitely makes sense :D


Added bitwise operations

Adds bitwise & and, ^ xor, | or, and ! not operators. This PR addresses #469 .

My system stats are
32GiB System Memory
384KiB L1 cache
1536KiB L2 cache
12MiB L3 cache
Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz

and here are the benchmarks for 2^20 for reference:
or 2^20                time:   [837.12 us 838.36 us 839.65 us]
                        change: [-6.8839% -5.8348% -4.8247%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

xor 2^20                time:   [837.43 us 838.90 us 840.51 us]
                        change: [-8.4754% -7.6579% -6.8264%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe

and 2^20                time:   [844.41 us 846.36 us 849.01 us]
                        change: [-17.143% -14.714% -12.417%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  7 (7.00%) high severe

not 2^20                time:   [547.10 us 548.25 us 549.55 us]
                        change: [-6.8615% -5.9387% -5.0605%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) low mild
  6 (6.00%) high mild
  4 (4.00%) high severe

One clippy and a conflict to go. Let me know if you would like me to address them for you.

Alright I believe I resolved those issues. Hopefully passes the merge checks this time around.


Make ML task

select test set globally
parameterize our model (eg stdv per continent/region)
train the model to perform best on the test set

We want to use a Gaussian Process to model it.


Lazy load site navigation in the project, reducing bundle size

What does this PR do and why?
todo - will add before and after
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2616

PR #2617

PR #2621   👈

This comment was auto-generated by Graphite.


python38Packages.portalocker: 2.3.0 -> 2.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.portalocker is: "A library to provide an easy API to file locking"
meta.homepage for python38Packages.portalocker is: "https://github.com/WoLpH/portalocker"
meta.changelog for python38Packages.portalocker is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.3.1 with grep in /nix/store/328i4hfkry33bl00h3n04pvy59zcfy3m-python3.8-portalocker-2.3.1

found 2.3.1 in filename of file in /nix/store/328i4hfkry33bl00h3n04pvy59zcfy3m-python3.8-portalocker-2.3.1

directory tree listing: https://gist.github.com/387a23a089c30d22466d1f211da28405

du listing: https://gist.github.com/81b7fcae392e0fc21ba221ed33a99796

Rebuild report (if merged into master) (click to expand)

88 total rebuild path(s)

22 package rebuild(s)

22 x86_64-linux rebuild(s)
22 i686-linux rebuild(s)
22 x86_64-darwin rebuild(s)
22 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
azure-cli
chia
deltachat-desktop
esbuild
git-filter-repo
netlify-cli
paperless-ng
postgresql11Packages.timescaledb
postgresql12Packages.timescaledb
postgresql13Packages.timescaledb
postgresqlPackages.timescaledb
python38Packages.applicationinsights
python38Packages.azure-identity
python38Packages.concurrent-log-handler
python38Packages.msal-extensions
python38Packages.portalocker
python39Packages.applicationinsights
python39Packages.azure-identity
python39Packages.concurrent-log-handler
python39Packages.msal-extensions
python39Packages.portalocker
vscode-extensions.matklad.rust-analyzer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/328i4hfkry33bl00h3n04pvy59zcfy3m-python3.8-portalocker-2.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.portalocker https://github.com/r-ryantm/nixpkgs/archive/977ee05375b98d4e2561a5846512e9ee08b4772f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/328i4hfkry33bl00h3n04pvy59zcfy3m-python3.8-portalocker-2.3.1
ls -la /nix/store/328i4hfkry33bl00h3n04pvy59zcfy3m-python3.8-portalocker-2.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

13 packages built:

azure-cli
chia
paperless (paperless-ng)
python38Packages.applicationinsights
python38Packages.azure-identity
python38Packages.concurrent-log-handler
python38Packages.msal-extensions
python38Packages.portalocker
python39Packages.applicationinsights
python39Packages.azure-identity
python39Packages.concurrent-log-handler
python39Packages.msal-extensions
python39Packages.portalocker

Maintainer pings
cc @jonringer for testing.

Result of nixpkgs-review pr 135229 at 977ee053 run on aarch64-linux 1

13 packages built successfully:

azure-cli
chia
paperless-ng
python38Packages.applicationinsights
python38Packages.azure-identity
python38Packages.concurrent-log-handler
python38Packages.msal-extensions
python38Packages.portalocker
python39Packages.applicationinsights
python39Packages.azure-identity
python39Packages.concurrent-log-handler
python39Packages.msal-extensions
python39Packages.portalocker


Direct messages not properly listed

Using this command:
slack-cleaner --token <TOKEN> --message --direct sherry --user johndoe
Only 6 messages were listed for deletion. This DM channel however contains 10 visible DMs when viewed in Slack. Using --perform only deleted the 6 listed messages and left the 4 remaining others.
The deleted messages were neither the most recent nor the oldest, they were in the middle.
Re-runing the same command still leaves the 4 remaining messages intact, with output 0 message(s) will be cleaned..

Sorry for the late reply. Are the remaining messages sent from sherry? I hope the syntax doesn't confuse you, the command you provided is going to delete messages from johndoe.


RTX-KG2 is returning subclasses without the appropriate query_id

I am sending this query:
{
  "workflow": [
    {
      "id": "lookup"
    }
  ],
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "ids": ["MONDO:0004979"],
          "categories": ["biolink:Disease"],
          "is_set": false,
          "constraints": []
        },
        "n2": {
          "ids": null,
          "categories": ["biolink:Gene", "biolink:Protein"],
          "is_set": false,
          "constraints": []
        }
      },
      "edges": {
        "e3": {
          "subject": "n2",
          "object": "n0",
          "knowledge_type": null,
          "predicates": [
            "biolink:contributes_to",
            "biolink:associated_with",
            "biolink:gene_associated_with_condition"
          ],
          "attribute_constraints": [],
          "qualifier_constraints": []
        }
      }
    }
  }
}

to https://arax.ncats.io/beta/api/rtxkg2/v1.4/query and I'm receiving some results like:
{
        "analyses": [
          {
            "edge_bindings": {
              "e3": [
                {
                  "id": "45522576"
                },
                {
                  "id": "44710546"
                }
              ]
            },
            "resource_id": "infores:rtx-kg2"
          }
        ],
        "description": "No description available",
        "essence": "PIK3CD",
        "essence_category": "['biolink:Gene', 'biolink:Protein']",
        "node_bindings": {
          "n0": [
            {
              "id": "MONDO:0004979"
            }
          ],
          "n2": [
            {
              "id": "NCBIGene:5293"
            }
          ]
        },
        "resource_id": "infores:arax"
      }

but I'm also getting results like:
{
        "analyses": [
          {
            "edge_bindings": {
              "e3": [
                {
                  "id": "44886886"
                }
              ]
            },
            "resource_id": "infores:rtx-kg2"
          }
        ],
        "description": "No description available",
        "essence": "IL31RA",
        "essence_category": "['biolink:Gene', 'biolink:Protein']",
        "node_bindings": {
          "n0": [
            {
              "id": "DOID:0080809"
            }
          ],
          "n2": [
            {
              "id": "NCBIGene:133396"
            }
          ]
        },
        "resource_id": "infores:arax"
      }

MONDO:0004979 is asthma, and DOID:0080809 is chronic asthma, which is a subclass of what I asked for. According to the TRAPI 1.4.0 spec right now, a query_id of MONDO:0004979 needs to be included in the corresponding node_bindings to link the subclass with the original query_graph curie.

you're right - for some reason when we implemented this I thought the TRAPI spec said that when the QNode only has one id specified, query_id isn't required to be provided (because it's implied that any Node fulfilling that QNode must be fulfilling that one curie, even if it has a different curie). but reading the spec now, it sounds like that's wrong. we'll update.


Move into ember-polyfills org?

I’ve been collecting the various polyfills that folks have made over in the ember-polyfills org. I’ve mostly been doing it as a way to increase bus factor, but it’s also super helpful to have a group of repo owners that are all conceptually familiar with the polyfill problem space.
Think this repo is a good candidate for ember-polyfills?

Whoops! This must have slipped my attention. Sorry.
Sure, let's move it! 🚚


60 not allowed as a value for seconds

Steps to reproduce
# parsing 59 as a second value works for the default formatter
Timex.parse("59", "{s}")
# {:ok, ~N[0000-01-01 00:00:59]}

# parsing 60 as a second value does not work for the default formatter
Timex.parse("60", "{s}")
# {:error, "Expected `second` at line 1, column 1."}

# parsing 59 as a second value works for the strftime formatter
Timex.parse("59", "%s", :strftime)
# {:ok, #DateTime<1970-01-01 00:00:59Z>}

# parsing 60 as a second value doesn't error with the strftime formatter but it does
# assume it is the beginning of the next minute
Timex.parse("60", "%s", :strftime)
# {:ok, #DateTime<1970-01-01 00:01:00Z>}

# This is compounded by Elixir itself not parsing leap seconds
~N[2016-12-31 23:59:59]
# ~N[2016-12-31 23:59:59]
~N[2016-12-31 23:59:60]
# ** (ArgumentError) cannot parse "2016-12-31 23:59:60" as naive datetime, reason: :invalid_time

Description of issue
I'm trying to allow for leap seconds in time strings but I can't see a way to. The docs for both the default formatter and the strftime formatter say the second value can go up to 60.
Thoughts on what's going on? Am I doing something wrong?

However you can manually build a DateTime with the right value, and convert it back to a string, but then it can't be parsed...
dt = %DateTime{year: 2016, month: 12, day: 31, hour: 23, minute: 59, second: 60, time_zone: "UTC", zone_abbr: "UTC", utc_offset: 0, std_offset: 0}
# #DateTime<2016-12-31 23:59:60+00:00 UTC UTC>
dt |> DateTime.to_iso8601()
# "2016-12-31T23:59:60+00:00"
dt |> DateTime.to_iso8601() |> DateTime.from_iso8601()
# {:error, :invalid_time}


Update python algorithm to integer arithmetic

This updates the python algorithm to use integer arithmetic, to solve issues #315 and #307 .
The tests are updated to include a benchmarking section, and enforce code formatting.

Hi @zongweil - could you take a look? I think this is ready to check in.


Re-enable awesome-lint as soon as it's fixed

Currently there is an error afecting the awesome-lint application we use in this repo to lint our awesome list.
Due to this I've temporarily disabled the linter (.github/workflows/awesome-lint.yml -> .github/workflows/awesome-lint.yml.disabled) as to not have :x: everywhere. #142
The issue with awesome-lint is tracked in sindresorhus/awesome-lint#166.

We're now back to normal operation of the linter.


Zip Code Filter

Add filtering by zip code (and multiple zip codes?)
This will need:

#255
A UI Component to add multiple things to a text field

The current mocks show a text field, so I'm going to first just use a simple comma separate list where the user would just enter everything. We can talk about adding a better component that validates and separates the values later.

Thanks for taking this!