Using Field(le) on integer fields is semi-broken

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
The attached sample code fails with
pydantic_core._pydantic_core.SchemaError: Error building "model" validator:
  SchemaError: Error building "model-fields" validator:
  SchemaError: Field "score":
  SchemaError: Error building "int" validator:
  TypeError: Expected int, got <class 'float'>

I believe that to be a mistake, as the type for le is float | None. Using an integer (ie setting le=10) works, but as the type annotation specifically calls for a float, this seems to be a bug.
Example Code
from __future__ import annotations

from pydantic import Field, BaseModel

class Test(BaseModel):
    score: int = Field(le=10.0)

Python, Pydantic & OS Version
pydantic version: 2.4.2
        pydantic-core version: 2.10.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/corni/projects/githubkit/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.5 (main, Sep  2 2023, 14:16:33) [GCC 13.2.1 20230801]
                     platform: Linux-6.5.9-arch2-1-x86_64-with-glibc2.38
             related packages: typing_extensions-4.8.0

Hi @criemen,
Thanks for reporting this. I'm working on a mac, but using the pydantic, pydantic-core, and python versions that you specified, I'm not able to reproduce this error.

Fascinating, I can't reproduce this myself anymore, either on Linux or on mac.
Sorry for bothering you! I'll come back if I have a whole lockfile with dependencies that shows this error :/


Querying Records with multiple conditional fields in a changeSelect2 dropdown event

Hello Volkan,
Below is my code.
namespace ppa.TenderCommitteeList {
@Serenity.Decorators.registerClass()
@Serenity.Decorators.responsive()
export class TenderCommitteeDialog extends Serenity.EntityDialog<TenderCommitteeRow, any> {
    protected getFormKey() { return TenderCommitteeForm.formKey; }
    protected getIdProperty() { return TenderCommitteeRow.idProperty; }
    protected getLocalTextPrefix() { return TenderCommitteeRow.localTextPrefix; }
    protected getNameProperty() { return TenderCommitteeRow.nameProperty; }
    protected getService() { return TenderCommitteeService.baseUrl; }

    protected form = new TenderCommitteeForm(this.idPrefix);

    agencyTypeId: number;

    /*
    constructor() {
        super();

        // Add change event to control field
        if (!Authorization.hasPermission("Administration:Security"))
        {
            // Set read only to true for a field
            Serenity.EditorUtils.setReadOnly(this.form.MemberPositionType, false);
            Serenity.EditorUtils.setReadOnly(this.form.Position, false);
        }
        else
        {
            // Set read only to true for a field
            Serenity.EditorUtils.setReadOnly(this.form.MemberPositionType, true);
            Serenity.EditorUtils.setReadOnly(this.form.Position, true);
        }

    }*/

    constructor() {
        super();

        // "changeSelect2" is only fired when user changes the selection
        // but "change" is fired when dialog sets customer on load too
        // so we prefer "changeSelect2", as initial customer details
        // will get populated by initial load, we don't want extra call

        this.form.PositionType.changeSelect2(e => {
            //var agencyId = parseInt(this.form.Agency.value);
            var positionTypeId = this.form.PositionType.value;
            //var agencyTypeId = String(this.form.AgencyAgType.value);
            if (Q.isEmptyOrNull(positionTypeId)) {
                this.setPositionDetails({});
                return;
            }

            // in northwind CustomerID is a string like "ALFKI",
            // while its actual integer ID value is 1.
            // so we need to convert customer ID to ID.
            // you won't have to do this conversion with your tables
            //var agencyTypeId = MasterData.AgencyRow.getLookup().itemById[agencyId].AgType;
            //var newEntityId = Id + " & " + agencyTypeId;

            console.log(this.form.AgencyAgType.value);
            console.log(positionTypeId);

            var positionId = Q.tryFirst(MasterData.PositionRow.getLookup().items, x => x.PositionType == parseInt(positionTypeId) && x.AgencyType == this.form.AgencyAgType.value).PositionId;
            //console.log(positionId);
            //Id = String(positionType);
            //console.log(this.form.AgencyAgType.value);
            //console.log(positionId);

            MasterData.PositionService.Retrieve({
                EntityId: positionId
            }, response => {
                this.setPositionDetails(response.Entity);
            });
        });

        this.form.Agency.changeSelect2(e => {
            //var agencyId = parseInt(this.form.Agency.value);
            var agencyId = this.form.Agency.value;
            //var positionTypeId = parseInt(this.form.MemberPositionType.value);
            if (Q.isEmptyOrNull(agencyId)) {
                this.setAgencyTypeDetails({});
                return;
            }

            // in northwind CustomerID is a string like "ALFKI",
            // while its actual integer ID value is 1.
            // so we need to convert customer ID to ID.
            // you won't have to do this conversion with your tables
            //var agencyTypeId = MasterData.AgencyRow.getLookup().itemById[agencyId].AgType;
            //var newEntityId = Id + " & " + agencyTypeId;
            //console.log(agencyTypeId);

            //var positionId = Q.first(MasterData.PositionRow.getLookup().items, x => x.AgencyType == agencyTypeId && x.PositionType == positionTypeId).PositionId;

            //Id = String(positionType);

            MasterData.AgencyService.Retrieve({
                EntityId: agencyId
            }, response => {
                this.setAgencyTypeDetails(response.Entity);
            });
        });
    }

    private setAgencyTypeDetails(details: MasterData.AgencyRow) {
        this.form.AgencyAgType.value = details.AgType;
        //console.log(this.agencyTypeId);
        //this.form.PositionName.value = details.PositionName;
    }

    private setPositionDetails(details: MasterData.PositionRow) {
        this.form.Position.value = details.PositionId;
        this.form.PositionName.value = details.PositionName;
    }

    /**
     * This method is a good place to update states of
     * interface elements. It is called after dialog
     * is initialized and an entity is loaded into dialog.
     * This is also called in new item mode.
     */
    protected updateInterface(): void {

        super.updateInterface();

        // Add change event to control field
        if (!Authorization.hasPermission("Administration:Security")) {
            // Set read only to true for a field
            Serenity.EditorUtils.setReadOnly(this.form.Agency, true);
            Serenity.EditorUtils.setReadOnly(this.form.PositionType, true);
            Serenity.EditorUtils.setReadOnly(this.form.PositionName, true);
        }
        else {
            // Set read only to true for a field
            Serenity.EditorUtils.setReadOnly(this.form.Agency, false);
            Serenity.EditorUtils.setReadOnly(this.form.PositionType, false);
            Serenity.EditorUtils.setReadOnly(this.form.PositionName, false);
        }

        // finding all editor elements and setting their readonly attribute
        // note that this helper method only works with basic inputs,
        // some editors require widget based set readonly overload (setReadOnly)
        //Serenity.EditorUtils.setReadonly(this.element.find('.editor'), true);

        // remove required asterisk (*)
        //this.element.find('sup').hide();

        // here is a way to locate a button by its css class
        // note that this method is not available in
        // getToolbarButtons() because buttons are not
        // created there yet!
        //
        // this.toolbar.findButton('delete-button').hide();

        // entity dialog also has reference variables to
        // its default buttons, lets use them to hide delete button
        //this.deleteButton.hide();

        // we could also hide save buttons just like delete button,
        // but they are null now as we removed them in getToolbarButtons()
        // if we didn't we could write like this:
        //
        // this.applyChangesButton.hide();
        // this.saveAndCloseButton.hide();

        // instead of hiding, we could disable a button
        //
        // this.deleteButton.toggleClass('disabled', true);
    }

}

}
In the Q.tryFirst query inside this.form.PositionType.changeSelect2, there are two conditions that need to be satisfied for PositionId to return a result

x.PositionType == parseInt(positionTypeId)
x.AgencyType == this.form.AgencyAgType.value

The PositionType dropdown is what triggers the changeSelect2 event. The value of the agencyType is gotten from the agency changeSelect2 dropdown.
The strange thing is that, though the agencyType value is being retrieved and printed correctly via console, when it is passed as part of the condition in the Q.tryFirst query, an error is thrown because the query doesn't see the retrieved agencyType value.
Please kindly help me know the best way to pass multiple field conditions into a Q.tryFirst query

Add [LookupInclude] to AgencyType field first. If you are using tryFirst, it might return null if none matches that criteria, so take result into a variable, and continue only if it is not null.

@gfo2007 Thanks for posting your code - the retrieve and update from xyzdialog/editor was what I was searching for how to do. Your code showed me how it was done!! Thanks for sharing.
I made a WIKI entry for that as well, so others that might not have all the details on typescript and the framework can learn from it .


Run FFmpeg silently

When using Python ffmpeg it is often nice to run it silently without any stdout to the terminal.
Solution:
Add flag that supports silent runtime

You can disable the output with
ffmpeg.input('yourinput.mp4').global_args('-loglevel', 'quiet')

Read about loglevel here

Thank you!

I am getting AttributeError: 'FilterableStream' object has no attribute 'global_args' when running: ffmpeg.input('yourinput.mp4').global_args('-loglevel', 'quiet')

I should have been more clear with my example, you need to call global_args() after you call .output(), so you should put this
.global_args('-loglevel', 'quiet')

after you call the output method.


Fixes: Hidden FAB's in Interactive Book are active when hidden. #173

Fixes #173
Describe the changes you have made in this PR -
Hidden FAB's are now inactive, i.e do not do anything when tapped.
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@manjotsidhu thanks for your insights, will try to remove the FAB button,

@manjotsidhu thanks for your insights, will try to remove the FAB button.

Just try, if nothing works out then we can use this change.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 73.483%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ui/views/ib/ib_page_view.dart
0
6
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
3852

Relevant Lines:
5242

💛  - Coveralls

@manjotsidhu I tried removing the FAB buttons, but in this case we don't have the nice fade in/out effect on the buttons.
In this case buttons appear/disappear suddenly instead of fading.


geojson: fix example and add warning

:heart: Thank you for your contribution!
Description
The coordinate order in the geojson example is wrong, and I added a warning about this.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[x] I'm aware of the code of conduct.
[x] I've created logical separate commits and followed the commit message format.
[x] I've added relevant test cases.
[x] I've added relevant documentation.
[x] I've marked translation strings (for relevant code).
[x] I've followed the CSS/JS and React guidelines (for relevant code).
[x] I've followed the web accessibility guidelines (for relevant code).
[x] I've followed the user interface guidelines (for relevant code).
[x] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[x] I've NOT included third-party code (copy/pasted source code or new dependencies).

Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

Thanks!


could saiku support clickhouse?

Is this a bug report?
(write your answer here)

Environment

java -version:
node -v (If you use Node.js proxy for Saiku):
npm -v (If you use Node.js proxy for Saiku):
yarn --version (If you use Node.js proxy for Saiku and if you use Yarn):

Then, specify:

Operating system:
Browser and version (if relevant):
Saiku plugin to Pentaho or Saiku Standalone:
Saiku CE or Saiku EE:
Saiku version:

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)

Hey @ART-jason we never tested... but i see that there is an official JDBC driver for ClickHouse here:

https://github.com/yandex/clickhouse-jdbc

... and JDBC drivers implemented by other organizations:

https://github.com/housepower/ClickHouse-Native-JDBC

Maybe you could test it :)


Protobuf blocks rules_cc Upgrade

We are still using Protobuf v3.21.7, which imports the cc_proto_library rule from rules_cc (0.0.6), while rules_cc removed this rule in 0.1.0.
Protobuf removed this reference here since v3.27.0. So if we want to upgrade to the latest rules_cc, we have the following options:

upgrade protobuf version to at least v3.27
Create a fork of protobuf and patch it to remove the reference

IIRC we are using 3.20.3

Beware of breaking change in protobuf 3.21, which turns it's py version to 4.21 and is not backward compatible.

Checked our major deps.

protobuf 3.21/4.21 released in mid 2022
onnx community moved in 1.14.0 in mid 2023

onnxruntime in 1.17.0 in Feb 2024, although it is not our direct dep.

torch started to move in 2023 but still have many pinning in their repo. Not sure about actual compatibility.

We probably don't need sharing as everything is re-serialized. So upgrade as long as deps are happy.

Looks like torch do not have much direct pb dependency these days, other than through onnx and the deprecated caffe2. So should be good to update.


[SPARK-33749][BUILD][PYTHON] Exclude more permissively in pycodestyle and flake8

What changes were proposed in this pull request?
Once you build and ran K8S tests, Python lint fails as below:
$ ./dev/lint-python

Before this PR:
starting python compilation test...
python compilation succeeded.

downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.6.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks failed:
./resource-managers/kubernetes/integration-tests/target/spark-dist-unpacked/python/pyspark/cloudpickle/cloudpickle.py:15:101: E501 line too long (105 > 100 characters)
./resource-managers/kubernetes/integration-tests/target/spark-dist-unpacked/python/docs/source/conf.py:60:101: E501 line too long (124 > 100 characters)
...

After this PR:
starting python compilation test...
python compilation succeeded.

downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.6.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks passed.

starting flake8 test...
flake8 checks passed.

starting mypy test...
mypy checks passed.

starting sphinx-build tests...
sphinx-build checks passed.

This PR adds the exclusion more permissively to avoid such cases in the future.
Why are the changes needed?
To make it easier to run linters
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually tested va running ./dev/lint-python.

cc @dongjoon-hyun and @zero323 FYI

Test build #132613 has started for PR 30718 at commit f883fce.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37217/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37217/

Hm .. yeah actually let me just take out the target directory only for now.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37217/

Test build #132620 has started for PR 30718 at commit fa7fff7.

Test build #132613 has finished for PR 30718 at commit f883fce.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132613/

Jenkins passed:

========================================================================
Running Python style checks
========================================================================
starting python compilation test...
python compilation succeeded.

downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.6.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks passed.

starting flake8 test...
flake8 checks passed.

The mypy command was not found. Skipping for now.
python3 has Sphinx 3.1+ installed but it requires lower then 3.1. Skipping Sphinx build for now.

all lint-python tests passed!

Merging it to master and branch-3.1.

I merged to branch-3.0 and branch-2.4 too.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37222/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37222/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37222/

Test build #132620 has finished for PR 30718 at commit fa7fff7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132620/


Fix for pagination count

Remove the pagination count logic causing the issue

Interesting, this unit test for '1-5 of 5' is passing if I revert your code change in pagination.coffee, I wonder why?

since the old condition was returning info.count as 5 because it was matching the existing condition, now the Math.min does the same since params to min are same

instead of redefining server responses, I think we need to add a top level var count and itemsList
and use this approach
injecting your tests starting from line 71

    it 'should render range string', ->
    expect(view.$ '.pagination-range').to.have.text '1-10 of 101'

    context 'when count is equal to maxItems', ->
       before ->
         count = 100
         itemsList = ({} for i in [0..100])

       it 'should render range string', ->
	 expect(view.$ '.pagination-range').to.have.text '1-10 of 100'

With this technic your reduce the amount of copy-pasted code and the tests are closer to BDD test model.

Modified

Do we still need maxItems?

Not required


[NOMRG] add xml reports

this branch is not meant to be merged but just try a few things and help
discussion around #352.
here reports are generated as XML, which makes it easy to store a lot of
information (this is just a toy prototype) that can be easily validated (e.g. in
tests) for example with schemas, and reused.
xslt is used to provide human-readable views of the reports.
in other projects I have found that the pattern (info stored in xml + views
generated with XSLT + css to make them pretty) can be very efficient.
things that can be reused in #352:

even if not using xml, lxml (which can work with html) can be useful to
construct the reports

store matplotlib figures as svg rather than binary formats such as png. note:
to generate valid xhtml make sure ids of elements generated by matplotlib are
actually unique in the document by changing them in the svg.

remove deprecated "border" attribute written by pandas in html tables

This is pretty neat Jerome, and a very nice work. Thanks! I'll run the example and see the report.

Might be worth having a look at NIDM-Results if you're going down this road.

Might be worth having a look at NIDM-Results if you're going down this road.

indeed if we decide to create xml reports we will be using nidm elements rather than those used in this toy example. the reports being reusable by tools that understand this language would be a very good thing


Vitis AI Quantization does NOT reduce Tensorflow model size

I use Vitis AI to quantize my tensorflow model (CNN+FC). However, it only has 0.1 MB reduce from 39.6MB to 39.5MB.
I have also checked with other people who use it, and they have the same result.
I am wondering if the algorithm only qunatize FC layers. Hope to get developers support!

To provide one complete information about sizes:
original keras model: 39.7MB
converted tensorflow model: 39.6MB
quantize_eval_model.pb: 39.5MB
deploy_model.pb: 39.5MB

Hi @FrankXinqi
The quantizer will quantize both Conv and FC layers, but the values in the output models are still float values, thus you will not see the size reduce. The quantizer will add some quantize operations in the Conv and FC layers to simulate the quantize error, which enables the post training quantization and quantize-aware training. In the compiler, the float values will be finally converted to INT8, and the size of the compiled model will reduce.

Thanks @qianglin-xlnx. I think the quantized model still has float32 and other points are important, please consider add them in the official documents. I also suggest you to add related reference if any xilinx developers published related papers. Please ignore if no publication.
I get the point that after compile the model will be reduced finally, and the quantize_eval_model.pb are added with some quantize operations to simulate the quantize error.
However, I the compiled model is not comparable with the pb model, so how I can know the reduced size of my model? In addition, I do not get the idea why xilinx simulate the quantization error, rather than directly providing a quantized model for us.

@FrankXinqi
Thank you for your advice.
After you use the AI compiler to compile the model, you will finally get the compiled model and know the reduced size of the model.
Xilinx also provided the compiled models for different platforms.
For zcu102, https://www.xilinx.com/bin/public/openDownload?filename=xilinx_model_zoo_zcu102-1.2.0-1.aarch64.rpm
For zcu104, https://www.xilinx.com/bin/public/openDownload?filename=xilinx_model_zoo_zcu104-1.2.0-1.aarch64.rpm
For alveo card, find the compiled models in the following link
https://github.com/Xilinx/Vitis-AI/tree/master/Vitis-AI-Library#setting-up-the-host-for-u50u50lvu280

Thanks @qianglin-xlnx
I can get the compile model, but with the compile model is ready for deployment with different file type. In my opininon, the comparison should make between the same file types.
What I need is to calculate the performance after quantization without a board. It seems quantize_eval_model.pb is able to do the job, by simulating quantization error.  Am I correct?  In addition, why Vitis AI does this complicated process to simulate the error, rather than provide the quantized model directly.

Hi @FrankXinqi
I think it's hard to calculate the performance after quantization without running it on the board. The performance of the model depends on many factors, including pre-processing and post-processing, DPU IP, hardware platform, memory, IO, etc. It is recommended to actually run the model to obtain accurate performance.
Maybe, you can refer to the published models for specific information and performance data, then get a rough performance evaluation of your model, as shown in the following.


Sandboxed loadstring

Currently, loadstring isn't sandboxed. It can mess with the environment in unpredictable ways and is risky. A sandboxed version would be good to have, and it'd better match Luau's safety goals.
A way to add this is to add a new argument, which can be 0, 1, or nil. 0 and nil would match the current behavior, whereas 1 would create a sandboxed function, which doesn't have the user-defined variables. Luau-using software could allow other numbers and make them hide the globals they add, to run pure Luau.
Currently, it's possible to do this with setfenv but setfenv can also be used for the exact opposite thing, and it'll probably get deprecated.
As far as I know, loadstring disables some optimizations. This would make it possible to optimize it when if it's sandboxed or not is known.

Right now you can use setfenv; loadstring is more deprecated than setfenv/getfenv if anything (neither is deprecated officially yet as far as Luau linter is concerned, but loadstring is severely restricted in terms of its execution on Roblox).
Since later versions of Lua remove loadstring in favor of load, I suspect at some point we'll just deprecate loadstring and either leave it in Roblox as is, or provide some Roblox specific replacement API - this is not really something that needs to be part of the core language, and any embedding environment can decide for itself whether it wants to provide it or not and how it should work.


Product repetitions in homepage featured products

On Home page FEATURED products, I'm getting multiple instances of the same product (number of instances seems to match the number of product variants). I think it is the issue with the backend because the Graphql query returns the same product multiple times.
Screenshots

System information
Saleor platform (docker)
storefront<PHONE_NUMBER>5f1fd495036c237fb3ddb57407aef8
api 053173ccc72c9d03d6f707fe78a8112940c1cf01

Hey, thanks for opening the issue, I've noticed this bug already a few days ago - I think it's related to data loaders which we added to optimize the homepage database queries. I suppose there is a missing distinct somewhere in the dataloader implementation that causes the issue.

example query presenting bug:
query FeaturedProducts {
    shop {
      homepageCollection {
        id
        products(first: 20) {
          edges {
            node {
              id
              name
              category {
                id
                name
              }
            }
          }
        }
      }
    }
  }

As you said @maarcingebala the bug was caused by missing distinct but not in the dataloader implementation. I found it in ProductsQueryset after some debugging (preceded by binary search in working and nonworking commits :smile:). Please take a look at PR  #5892


pandas: Incorrect parameter type for pandas.Index.get_level_values()

Environment

Language Server: v2020.12.2
OS: macOS v10.15.6
Python: v3.7.9
Pandas: v1.1.5 (latest)

Expected behavior
Recognize that the parameter level for pandas.Index.get_level_values(level) can be of type str or int.
Actual behavior
Pylance incorrectly reports that the parameter level for pandas.Index.get_level_values(level) must be a string:

Code Snippet
Should not return errors:
import pandas as pd

pd.Index(['ds']).get_level_values(0)

Please let me know how I can improve this bug report because many more will follow (all for typeshed issues). Is this the best repo for such bug reports? (I am following the precedent of Pandas type issues in the release notes.)

https://github.com/microsoft/python-type-stubs is the new canonical source for these stubs, for reference.

https://github.com/microsoft/python-type-stubs is the new canonical source for these stubs, for reference.

microsoft/python-type-stubs is the new canonical source for these stubs, for reference.

@jakebailey Thank you! Would it be more efficient for me to create these issues in that repo? Or, does that repo not receive the same degree of visibility? I'm happy to do whichever is easiest for you. 🙂

microsoft/python-type-stubs is the new canonical source for these stubs, for reference.

@jakebailey Thank you! Would it be more efficient for me to create these issues in that repo? Or, does that repo not receive the same degree of visibility? I'm happy to do whichever is easiest for you. 🙂

That's a great question, because on one hand we want to close issues here so people know we shipped the stubs in Pylance, but on the other, it'd be nice for them to be in the repo they are fixed in... I don't know if we have a solid answer yet, that repo is very new (and then we all went on break for the holidays).

That's a great question, because on one hand we want to close issues here so people know we shipped the stubs in Pylance, but on the other, it'd be nice for them to be in the repo they are fixed in... I don't know if we have a solid answer yet, that repo is very new (and then we all went on break for the holidays).

No harm in having these here at the moment, transferring is easy.

No harm in having these here at the moment, transferring is easy.

This issue has been fixed in version 2021.3.2, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202132-17-march-2021


[Suggestion] Add ability to hide seen items, not just change colors

There are some times it's nice to completely ignore anything that has been seen already.  Especially if there are MANY duplicate variants of the same item that I really don't want.
Can you add a button or switch to completely hide the items already marked as seen?  That would make it much easier on your eyes when scrolling through long results.
Thoughts:

I'd say the enable/disable button should live on the main pages, and not only in the settings tab, because I can see myself flipping it on/off quickly depending on the particular search.
For paginated results, you could encounter pages where all have been seen already, so maybe show a banner telling user full page was seen and then automatically continue onto the next result page (without user needing to click next).
Perhaps, if you want to get fancy, make the auto-advance-empty-pages a user controlled setting in the AVE setting tab?

Hey, thanks for the Feedback.
We will consider to add these Features.

Perhaps, if you want to get fancy, make the auto-advance-empty-pages a user controlled setting in the AVE setting tab?

Do I understand this correctly as follows
I am at page 1 and go to page 2, on page 2 I have already seen all products, so the script switches directly to page 3?

Do I understand this correctly as follows I am at page 1 and go to page 2, on page 2 I have already seen all products, so the script switches directly to page 3?

I think there are 2 ways to do it:

The method you described above.

Automatically skipping pages that are empty by advancing to first available page with unseen items.
I was guessing this would be a bit harder to implement
You'd need to watch your Amazon call rate so you don't quickly burn through a large number of pages too fast with the "auto-skip unseen items" and tip them off that there's automation being used.
This would, in my opinion be the superior implementation from a user's perspective. (no need to click through empty pages)

The "unsophisticated" method (my original thought)

If all items on a page have been hidden, just show a banner saying "All items on page have been seen"
It requires the user to click through empty pages, which could become annoying, despite it being a massive visual benefit of hiding seen items.
This 2nd method is workable, but probably not preferred unless Method 1 is too hard or time consuming to implement.

Here's a quick mock-up of Method 2:


Wrong value when number of entries changed

Hi,
For example, first time I have data set of 7 values. Then I change to 12 values. Finally, back to 7 values. The chart display perfectly 7 first values. The rest are consider as value 0.

Hello! This issue is resolved in Vico 1.3.0, which should be available within half an hour. Thanks for the bug report!


More informative cstmm normalization factor histogram

Currently, the histogram doesn't distinguish bioproject and curate_group but those info can be effectively visualized as by a stacked bar plot for each of them.

done, now cstmm produces these plots for QC.


Added browser check for opera mini

I have found there is no check for opera mini, and i have created pull request.

https://github.com/fnando/browser/pull/135

Available in ac1c35d151273a85253ac4ce31b9aa1e00cea65b.


ValueError: Number of samples not divisible by channels

with sd.Stream(samplerate=RATE, blocksize=CHUNK, dtype='int32', latency='low', callback=None) as s:
 ```wave = signal.square
    t =.002
    sps = 44100
    atten = .015```
 ```while True:

            freq=440
            waveform= wave(2*np.pi*(np.arange(t*sps))*freq/sps)
            waveform_quiet=waveform*atten
            wave_int = waveform_quiet *<PHONE_NUMBER>
            s.write(np.ascontiguousarray(wave_int, np.int32))```

So along the way I realized that I wanted to make a single period based sound sample and propagate that within a loop without using the limited play() stream.  I understand that you cannot hear a sound wave the same at (1/440) of a second for a concert A (440hz) note. But if you loop a single period of a sound many times you will still hear the sound because its concatenated. You can also put some of the waveforms parameters within the loop to change the amplitude and frequency almost in real time, that is the main goal im trying to accomplish. Unfortunately, stream write() wont allow me to have a small time period like the sd.play() can. Is there anyway to alleviate this problem, or is it just a problem with sounddevices limitations?

I took the liberty of fixing your example code, I hope I didn't mess it up.
In order to make your code actually work, I had to add a few things, and I switched to using the default data type 'float32' to avoid some calculations:

import numpy as np
from scipy import signal
import sounddevice as sd

sps = 44100
freq = 440

wave = signal.square
t = .002
atten = .015

waveform = wave(2 * np.pi * (np.arange(t * sps)) * freq / sps)
waveform_quiet = waveform * atten
waveform_32bit = waveform_quiet.astype('float32')

with sd.Stream(samplerate=sps, latency='low') as s:
    while True:
        s.write(waveform_32bit)

Running this, produces the error you were mentioning in the title:
ValueError: Number of samples not divisible by channels

How many channels do you want?
I guess you want one?
If yes, you should use channels=1:
with sd.Stream(samplerate=sps, channels=1, latency='low') as s:
    while True:
        s.write(waveform_32bit)

Now this produces some sound :slightly_smiling_face: but it's not quite 440 Hz :frowning_face:
Did you actually mean to use t = 1 / freq?

without using the limited play() stream

I agree that the sd.play() function is limited, but it can be used to get the same result as above:
import numpy as np
from scipy import signal
import sounddevice as sd

sps = 44100
freq = 440

wave = signal.square
#t = .002
t = 1 / freq
atten = .015

waveform = wave(2 * np.pi * (np.arange(t * sps)) * freq / sps)
waveform_quiet = waveform * atten
sd.play(waveform_quiet, samplerate=sps, latency='low', loop=True)
sd.wait()


Issue on page /effective-volto/addons/block-styling.html enableStyling was removed in volto 16.0.0.alpha.46

enableStyling is not working anymore starting with Volto 16.0.0-alpha.46

See also https://github.com/plone/volto/issues/3819


Reports ' 'npm run build' failed' error in Windows environment when mvn packages InLong

Expected behavior
It is OK in version 0.9.0, but the following error is reported in the windows environment with the master code:
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.0:npm (npm run build) on project inlong-website: Failed to run task: 'npm run build' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
Actual behavior
In cmd, execute "mvn clean package -Dmaven.test.skip=true", the reports error info:

I can't reproduce the problem. It may be a node environment problem, please check your node and npm version.

@leezng, it's my environmental problem, thanks!

windows
windows git clone code

https://segmentfault.com/a/1190000021803437

windows newline symbol is CRLF, not the same with linux newline symbol LR,
git clone code with property core.autocrlf=true will convert LR to CRLF

please  set
git config --global core.autocrlf false
and git clone ,then compile code
in git bash or wsl bash
sed -i 's/\r//'  *

reference：
https://segmentfault.com/a/1190000021803437

windows newline symbol is CRLF, not the same with linux newline symbol LR,
git clone code with property core.autocrlf=true will convert LR to CRLF
please set
git config --global core.autocrlf false
and git clone ,then recompile code
in git bash or wsl bash
sed -i 's/\r//' *
reference：
https://segmentfault.com/a/1190000021803437

windows newline symbol is CRLF, not the same with linux newline symbol LR, git clone code with property core.autocrlf=true will convert LR to CRLF
please set git config --global core.autocrlf false and git clone ,then recompile code in git bash or wsl bash sed -i 's/\r//' * reference： https://segmentfault.com/a/1190000021803437

new discussion: https://github.com/apache/inlong/discussions/4459

I 've encountered the same problem. Could you show more details about this ? I still have no idea how to handle it.兄弟，这个问题主要是什么？能否详细说一下？万分感谢


Kernel CI/CD pipeline should upload crash dumps + symbols as workflow artifacts.

Kernel CI/CD pipeline should cache pdb's for drivers.
Symbols are needed to debug kernel mode crashes.
The following command will create a local symcache on the CI/CD machine:
c:\debuggers\SymChk.exe -v *.sys -s cache*c:\symbols;.

Can you provide more information about how to use this to debug kernel mode crashes?

To use the symbol cache, you can do the following
windbg -z memory.dmp -y SRV*;cache*c:\symbols
What the symchk command does is to copy the PDB files to a sub-directory under the c:\symbols\image_name\GUID where the guid uniquely identifies the version of the PE file.
The debugger can then find the pdb file by searching that directory.
Long term, we might need to create  scavenger to remove older symbols from the symbol cache to conserve disk space.

To use the symbol cache, you can do the following
windbg -z memory.dmp -y SRV*;cache*c:\symbols
What the symchk command does is to copy the PDB files to a sub-directory under the c:\symbols\image_name\GUID where the guid uniquely identifies the version of the PE file.
The debugger can then find the pdb file by searching that directory.
Long term, we might need to create scavenger to remove older symbols from the symbol cache to conserve disk space.

I'd expect a markdown file with the relevant info to be in a PR

I think the right solution is to assume developers have no access to the kernel CI/CD machine.
At the conclusion of the Kernel CI/CD flow, it should upload the drivers + symbols + crash dump if the workflow failed, similar to what is done for user mode CI/CD pipeline.

@Alan-Jowett crash dumps are uploaded, and symbols are available in the artifacts consumed by the CI/CD test workflow.  Is there anything remaining before closing this issue?

Nope. We can close this.


ipa size become too big after adding this plugin

Anyone facing the same issue? previously my ipa size only 12MB, but after adding this plugin it's become 70MB.
Anyone know how to reduce the size again?

I have the same problem.


Sliders with exactly 3 bezier points

The only issue I can see with this bot currently is that it cannot follow these sliders with only three bezier points. it does the same with back and forth sliders aswell
Example of a slider the bot cannot follow
But other than that it can follow any other type of slider, even ones with more than 10 bezier points, perfectly fine.
Example of a perfect slider the bot can follow
The issue is most likely at Line #158 in main.pp which calls for every slider it attempts to follow.

hello.. may i ask how do you run this program.. please oh please help me >.<

@Kuppey maybe you shouldn't have the program if you don't even know how to run it.

can you tell me how to run it then? if its ok with you though.

First image is not bezier slider! The code only for education. I don't write it for play. It's very very bad source code.

No no, the points are called bezier points, but other than that it cannot follow those sliders, it's very good at following everything else but 3 point slider, it should be an easy fix possibly.

I think it's problem with  HitObject,h line 155
return { PCenter.x + PRadius * cosf(ang), PCenter.y + PRadius * sinf(ang) };
[HitObjects]
72,264,6236,6,0,P|256:264|472:264,1,385   //Bad
But sliders with B are good example:
104,184,8921,2,0,B|256:184|512:16|512:40,1,420

https://github.com/AndreySeVeN/osuAutoBot/commit/06baa2638eeb9ed6632db46c868e00c748357881


[Help]  Question Field validation

Hi :) first off thank you for keeping this package alive!
do you know if it is possible in the current state of the lib to somehow add field validations for the underlaying Textfields? or would I have to implement the feature myself?

HI @The-Mr-L
Please check the change event like this one:
https://github.com/bosskmk/pluto_grid/blob/3a2e74190d3d4bc85f82de2793f97d533aea7dbc/demo/lib/screen/feature/editing_state_screen.dart#L76
if it is just read-only, or you may be able to pass a result or cancel ...
Generally, I think the easiest way to achieve that is by adding a cancel boolean field to the event and checking the value before committing the change, you don't need to care about the validation rules, the developer will be responsible for the validation and telling the grid to commit or cancel.
I believe it would be very useful feature, thank you! 🙏🙏

Thanks for response, I will take a look and think a little more about it, it would just be really convenient if we had a way to add custom parameters to the underlaying inputfield builder, I might take on the challenge, if I end up needing it. then I will make a PR if that is the case.  thanks again :).

Great, I will be happy to review it.
Good luck !


Support matchers in response headers and request body, headers, query

🗣 Context
Currently Matchers are only supported in Response body. Matchers should also be available to set for other elements of requests and responses.
💬 Narrative
When preparing a Pact test
I want to use matchers in response header. request bodies, request headers and request query
So that I can write a better Pact test that can also handle random data.
📝 Notes
🎨 Design
✅ Acceptance Criteria
GIVEN a withResponse setup of the pact test
WHEN entering header values
THEN I can use any available Matcher
GIVEN a withRequest setup of the pact test
WHEN entering header values
THEN I can use any available Matcher
GIVEN a withRequest setup of the pact test
WHEN entering query values
THEN I can use any available Matcher
🚫 Out of Scope

Implemented and merged with #47


Enforce documentation/comments around the overriding values.

https://hivemq.kanbanize.com/ctrl_board/22/cards/20948/details/
We would like to reinforce and validate the different combinations of the values specially when using either the overrideHiveMQConfig or the overrideStatefulSet values, as some of other related values will be ignored.
Unfortunately, we are already setting default values in the values YAML file which are used as well for instance to configure some of the Statefuset specs. So for existing customer using the overrideStatefulSet throwing an error will make this a breaking change.
Another different approach I thought was to display a warning instead when installing or upgrading the charts, but again there is a problem here since we are already setting default values for some of these related values used in a Statefulset or HiveMQ ConfigMap. Even if we remove and omit these default values completely from our own custom values file, Helm will combine both values, the ones from our custom values file with the ones which are not present or set in the same and will use the default.
This will mean, that for a customer to actually avoid a warning message, would have to set all these default values to empty/null content. For example:
image:
  repository: ""
  name: ""
  tag: ""
  pullPolicy: ""
  pullSecretName: ""

Thanks for looking into this, even though we cannot provide an easy fail fast approach this time.

Yeah, problem is actually the way how Helm works, as it merges both values, the ones from our custom values files with the default ones defined in the chart, so when we don't define any particular value in our custom values file, it will apply the default ones... so not possible to implement unless we force customer to override some default values with empty values which is quite cumbersome.


How to analyze image with multiple face?

Hi serengil, thank you very much for the very helpful github page. I'm doing some exploration, I'm interested in doing analysis for a photo with multiple faces. How to do that using DeepFace?
Thank you so much

Hello, the following code snippet will help you
from deepface import DeepFace
from retinaface import RetinaFace
import matplotlib.pyplot as plt

faces = RetinaFace.extract_faces("2.jpeg")

print("There are ", len(faces), " faces in the image")

for face in faces:
    plt.imshow(face)
    plt.axis('off')
    plt.show()

    obj = DeepFace.analyze(face, detector_backend = 'skip')
    print(obj)
    print("------------------------")

Thank you so much!

Hello Serengil, just want to find out if there is a specific reason you used RetinaFace for the face extraction bit?

Hello @serengil
Thank you for sharing the code snippet.
It processes detected faces one by one, which means processing time will increase linearly with the number of faces. Is multi threading supported with this model?


Swift UI

Implemented first 5(+accessibility announcement) accessibility samples for SwiftUI for the review.

After making all changes, add NL Localized Pages: https://abra-nl.atlassian.net/wiki/spaces/ID/pages/edit-v2/8847386#4.-Add-localized-page


Fix: Escape glyph hex in xaml

Description
Escape glyph hex in xaml sample
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

->

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

I reconfigured the CI pipeline from Azure side. I'm unable to trigger a manual build as it's a forked branch, do you mind pushing a "whitespace" commit to see if it triggers a build?

@karkarl Done


Document code for pong

Add docstrings and comments in the code

Done. Code documented at the same time as creating the tests, as per commit cc9a398991bb19ef984eeea47067baad594abfc2.


Creating an extract fails on Tableau Professional Edition

Hi,
We have created a custom web data connector and it successfully pulls data from our data source to tableau. Using the same data source we can create an extract on tableau public edition but we get the following error when we try to create an extract - by clicking the Sheet 1 tab - on tableau professional edition.

We are using tableau version 10.2 and WDC version tableauwdc-2.2.0. The following is a screenshot of log.txt file after the error has been triggered.

Any form of help would be highly appreciated.

Changing the datatype of incrementColumnId from string to id for the table we were creating fixed this issue for us.


Outdated files in the dev-1.17-ko.4 branch.

This is a Bug Report
Problem
Outdated files in the dev-1.17-ko.4 branch.
40 files to be modified

[ ] content/en/docs/concepts/architecture/cloud-controller.md 1 file changed, 2 insertions(+)
[ ] content/en/docs/concepts/containers/images.md 1 file changed, 17 insertions(+), 9 deletions(-)
[ ] content/en/docs/concepts/containers/runtime-class.md 1 file changed, 7 insertions(+), 6 deletions(-)
[ ] content/en/docs/concepts/overview/components.md 1 file changed, 5 insertions(+), 6 deletions(-)
[ ] content/en/docs/concepts/overview/kubernetes-api.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/concepts/overview/working-with-objects/field-selectors.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/concepts/services-networking/connect-applications-service.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/concepts/services-networking/endpoint-slices.md 1 file changed, 104 insertions(+), 15 deletions(-)
[ ] content/en/docs/concepts/services-networking/ingress-controllers.md 1 file changed, 1 insertion(+)
[ ] content/en/docs/concepts/services-networking/service.md 1 file changed, 14 insertions(+), 19 deletions(-)
[ ] content/en/docs/concepts/workloads/controllers/replicaset.md 1 file changed, 4 insertions(+), 4 deletions(-)
[ ] content/en/docs/concepts/workloads/pods/ephemeral-containers.md 1 file changed, 5 insertions(+), 4 deletions(-)
[ ] content/en/docs/concepts/workloads/pods/pod-lifecycle.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/contribute/style/write-new-topic.md 1 file changed, 3 insertions(+), 2 deletions(-)
[ ] content/en/docs/reference/glossary/cluster.md 1 file changed, 3 insertions(+), 3 deletions(-)
[ ] content/en/docs/reference/glossary/container-runtime.md 1 file changed, 4 insertions(+), 4 deletions(-)
[ ] content/en/docs/reference/glossary/kube-controller-manager.md 1 file changed, 2 insertions(+), 2 deletions(-)
[ ] content/en/docs/reference/glossary/kube-scheduler.md 1 file changed, 3 insertions(+), 3 deletions(-)
[ ] content/en/docs/reference/glossary/pod-lifecycle.md 1 file changed, 3 insertions(+), 3 deletions(-)
[ ] content/en/docs/reference/glossary/service-account.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/reference/issues-security/security.md 1 file changed, 3 insertions(+), 1 deletion(-)
[ ] content/en/docs/reference/kubectl/cheatsheet.md 1 file changed, 3 insertions(+), 1 deletion(-)
[ ] content/en/docs/setup/_index.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/setup/best-practices/certificates.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/setup/best-practices/node-conformance.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/setup/learning-environment/minikube.md 1 file changed, 3 insertions(+), 6 deletions(-)
[ ] content/en/docs/setup/production-environment/container-runtimes.md 1 file changed, 9 insertions(+), 9 deletions(-)
[ ] content/en/docs/setup/production-environment/tools/kops.md 1 file changed, 28 insertions(+), 24 deletions(-)
[ ] content/en/docs/setup/production-environment/windows/user-guide-windows-nodes.md 1 file changed, 6 deletions(-)
[ ] content/en/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy.md 1 file changed, 21 insertions(+), 18 deletions(-)
[ ] content/en/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md 1 file changed, 10 insertions(+)
[ ] content/en/docs/tasks/manage-kubernetes-objects/declarative-config.md 1 file changed, 2 insertions(+), 2 deletions(-)
[ ] content/en/docs/tasks/manage-kubernetes-objects/imperative-config.md 1 file changed, 2 insertions(+), 2 deletions(-)
[ ] content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/tasks/run-application/horizontal-pod-autoscale.md 1 file changed, 164 insertions(+), 9 deletions(-)
[ ] content/en/docs/tutorials/hello-minikube.md 1 file changed, 9 insertions(+), 10 deletions(-)
[ ] content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md 1 file changed, 7 insertions(+), 7 deletions(-)
[ ] content/en/examples/minikube/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-)
[ ] content/en/includes/task-tutorial-prereqs.md 1 file changed, 1 insertion(+), 1 deletion(-)

0 files to be renamed
0 files to be deleted
Proposed Solution
Use git diff to check what is changed in the upstream. And apply the upstream changes manually
to the content/ko of dev-1.17-ko.4 branch.
For example:
# checkout `dev-1.17-ko.4`
...
# check what is updated in the upstream
git diff dev-1.17-ko.3 dev-1.17-ko.4 -- content/en/docs/concepts/architecture/cloud-controller.md
# apply changes to content/ko
vi content/ko/docs/concepts/architecture/cloud-controller.md
...
# commit and push
...
# make PR to `dev-1.17-ko.4`

Pages to Update
/language ko

/assign

/kind cleanup

/close


node.exe'' finished with non-zero exit value 1 (generateDebugApolloIR)

This has been mentioned before but the topics are closed.
Our GraphQL variables had to be changed on the server so I needed a new schema.json
Done by generating it from the node_modules/.bin/ directory:
apollo-codegen download-schema https://oursite/api/graphql --output schema.json
File get downloaded and moved to the app/src/main/graphql/com.myapp.something folder
So - The setup is the same like before but downloading this new schema is breaking everything. I have now gone back to square one. Deleted all my query files and just left with the schema.json file and the same error occours.
app\.gradle\nodejs\node-v6.7.0-win-x64\node.exe'' finished with non-zero exit value 1

Could you run gradle build with info and stack trace flags from command line. It should give more detail about the error

Does --info give any more detail? Tough to see from stack trace what is the problem

@digitalbuddha
Ah yes, I updated my reply above

Solved by removing apollo and installing the new one. Then using new command for downloading schema : apollo schema:download --endpoint=https://something.com


Feature/wishlist

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@cc42bd7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop       #4   +/-   ##
==========================================
  Coverage           ?   88.68%
==========================================
  Files              ?       65
  Lines              ?     1114
  Branches           ?      201
==========================================
  Hits               ?      988
  Misses             ?      113
  Partials           ?       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc42bd7...85d1aa9. Read the comment docs.


fix inverted score in hatOldTokenRank

hatOldTokenRank decides which token, if any, to steal a hat from.
The goal is to steal a hat from the token that is least important.
As written, the code steals the hat from the token that is most important,
but only when there are no completely free hats available.
Fix that.
This does not happen often in practice.
This commit will have minimal impact on user experience.
The main benefit is avoiding future confusion over the code,
and being more robust if surrounding parts of the code change.
Checklist

[/] I have added tests
[/] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet

See https://youtu.be/czsNj4lLagU for a little demo


32 Bit Payloads on 64 Bit Systems.

I have successfully made a build and used it to launch 64-Bit Payloads on x64. Is there any way to launch 32-Bit equivalents of these as well, using the 64-Bit version on x64?
Disclaimer: I am relatively new to C++, and would appreciate any help.

Hi, I guess you wish to use 32-bit payloads on 64 bit system? Currently it is not supported (it should be feasible to implement, but it is gonna be tedious, because it will require much more parameters to be filled in manually). Maybe one day I will add it.
For now I recommend you to try another loader that support such injections, which is very similar to Process Ghosting:
https://github.com/hasherezade/transacted_hollowing

Thank you for your response.

I'm uncertain, however, whether it's possible to use 32-bit payloads on 64-bit systems

Yes. 32 bit executables are supported on 64 bit Windows via WoW64.
The loader's description just says, that the target application where you inject must have the same bitness as the payload.

Thank you.

Can you share the exact scenario that resulted in a failure (OS, target, payload) so that I can reproduce it? Then I can help more.
You can attach your payloads here (zipped) or you can send to my e-mail (hasherezade-at-pm.me).


fix: skip workloads with parent in reconciliation flow

Overview
Bug description: In the reconciliation flow, the client decides to send workloads with parents since they are missing in the server (which is obvious since we never send them with the watchers).

nice catch 👍


Page not found (404)

I've been following the "From 0 to IEPY" tutorial. I've loaded the data, run preprocess, and now I'm trying to Open the web interface.
The first time I run python bin/manage.py runserver it says I need to run a migration first. I do.
Then, I try to runserver again, and I get some promising output:
System check identified no issues (0 silenced).
February 15, 2016 - 17:17:58
Django version 1.9.2, using settings 'my-project.settings'
Starting development server at http://<IP_ADDRESS>:8000/
Quit the server with CONTROL-C.

But as soon as I go to http://<IP_ADDRESS>:8000/ I get:
Page not found (404)
Request Method:	GET
Request URL:	http://localhost:8000/admin/login?next=/
Using the URLconf defined in webui.urls, Django tried these URL patterns, in this order:
^$ [name='home']
^admin/ ^$ [name='index']
^admin/ ^login/$ [name='login']
^admin/ ^logout/$ [name='logout']
^admin/ ^password_change/$ [name='password_change']
^admin/ ^password_change/done/$ [name='password_change_done']
^admin/ ^jsi18n/$ [name='jsi18n']
^admin/ ^r/(?P<content_type_id>\d+)/(?P<object_id>.+)/$ [name='view_on_site']
^admin/ ^corpus/relation/
^admin/ ^auth/user/
^admin/ ^corpus/entity/
^admin/ ^corpus/iedocument/
^admin/ ^corpus/gazetteitem/
^admin/ ^auth/group/
^admin/ ^corpus/entitykind/
^admin/ ^corpus/iedocumentmetadata/
^admin/ ^corpus/entityoccurrence/
^admin/ ^(?P<app_label>corpus|auth)/$ [name='app_list']
^corpus/
The current URL, admin/login, didn't match any of these.

What's going on?

Hi there.
I'm not sure whats going on.
I just made a try locally creating a new IEPY instance, and just after that starting the server, and I didnt have any problems.
When I went to such url (http://localhost:8000/) I was redirected to http://localhost:8000/admin/login?next=/ from where I logged in.
Two questions:

what iepy version are you using?
Can you make a try creating a new iepy instance, and without doing anything else start the server and attempt to log in?

Have the same problem but there wasn't a message about migration
IEPY 0.9.5

Hello People.
I still cant reproduce this, so I'm not completely sure what's happening to you.
Under what environment are you working on? Linux, Max? Version?
Question/Tip (just in case): did you try <IP_ADDRESS> instead of localhost?

Extra: can you paste in here the logging/output of the server after you attempt to access the website?

Ubuntu 15.04
Python 3.5.1
IEPY 0.9.5
Django 1.9.4
Sklearn 0.17.1
NLTK 3.2
With that configuration I can run the server.
Following installation guide from docs I ran "pip install iepy"
Running iepy command returns "can't set attribute" error in
.../python3.5/site-packages/nltk/internals.py
parsed_pattern.pattern.groups = 1
Upgrading NLTK to latest version solved that problem.
Then I modified imports in
.../python3.5/site-packages/iepy/preprocess/tagger.py
- from nltk.tag.stanford import POSTagger
+ from nltk.tag.stanford import StanfordPOSTagger as POSTagger

and in
.../python3.5/site-packages/iepy/preprocess/ner/stanford.py
- from nltk.tag.stanford import NERTagger
+ from nltk.tag.stanford import StanfordNERTagger as NERTagger

Now I can run iepy command but creating a project with "iepy --create test" return error after specifying database name
"module 'html.parser' has no attribute 'HTMLParseError'"
in .../python3.5/site-packages/django/utils/html_parser.py"
HTMLParseError = _html_parser.HTMLParseError
Upgrading Django to latest version solved that problem.
I did not need to run migration and started the server.
Going to http://<IP_ADDRESS>:8000/ redirects me to http://<IP_ADDRESS>:8000/admin/login?next=

Page not found (404)
Request Method:	GET
Request URL:	http://<IP_ADDRESS>:8000/admin/login?next=/
Using the URLconf defined in webui.urls, Django tried these URL patterns, in this order:
^$ [name='home']
^admin/ ^$ [name='index']
^admin/ ^login/$ [name='login']
^admin/ ^logout/$ [name='logout']
^admin/ ^password_change/$ [name='password_change']
^admin/ ^password_change/done/$ [name='password_change_done']
^admin/ ^jsi18n/$ [name='jsi18n']
^admin/ ^r/(?P<content_type_id>\d+)/(?P<object_id>.+)/$ [name='view_on_site']
^admin/ ^auth/user/
^admin/ ^corpus/entitykind/
^admin/ ^auth/group/
^admin/ ^corpus/entityoccurrence/
^admin/ ^corpus/iedocumentmetadata/
^admin/ ^corpus/relation/
^admin/ ^corpus/entity/
^admin/ ^corpus/gazetteitem/
^admin/ ^corpus/iedocument/
^admin/ ^(?P<app_label>auth|corpus)/$ [name='app_list']
^corpus/
The current URL, admin/login, didn't match any of these.

http://<IP_ADDRESS>:8000/admin/login/ returns "cannot import name 'import_by_path'" error which means upgrading django wasn't good idea.

Downgrading django to 1.8 is solution for me

Thanks for letting me know.
It's strange, because it's pinned to Django 1.7 (glad to see that it's at least working on 1.8)
I didn't realize yet that you people were using a higher Django version.  IEPY installation brought django 1.9, or you hand installed it?
Is there a special need for having it on such version?
Thanks for your reports

I am not sure about @zfrenchee's configuration.
IEPY installation brought me Django 1.7.x. I did manual upgrade of it to the latest version.

No further activity here. Closing for now.
For the record, iepy UI is working on Django 1.7 and there's no planned upgrade (although pull requests will be happily accepted)


gzip compression error

hello. the guys doing aws-serverless-express have added supported for gzip compression and have indicated how to enable it in the swagger yaml file (see https://github.com/awslabs/aws-serverless-express/pull/51/files/4d54a81b831eca97524f15b72fa8be379c80aedb).  However, I can't seem to find a way to tell claudia to enable the gzip compression option.  I've already added binaryMediaTypes in lambda.js but I see how to add binaryMediaTypes to the api gateway's binaryMediaTypes as specified in the link. any example with code on how to enable this in claudia. Thanks

please use github issues only to report bugs. see https://github.com/claudiajs/claudia/blob/master/contributing.md for info on where to ask questions


Feat/walletpassphrase

This implements the walletpassphrase rpc call as part of the RPCClient.Wallet. I'm not sure if my test is relevant/shows that the method works because I'm green to unit testing but I figured I'd try. I used this implementation in BreezeHub/BreezeServer and it worked unlocked an encrypted wallet.

Nice

Actually it does not compile, missing ';'.


feat:Add sign up compnents fixes #20

Create sign up form and update the sign up page
@alibvr

A new PR will be opened without SignUp.js


forward, rewind features?

Sometimes songs have a long intro, and I would like to forward (or rewind back) x seconds. How is it possible?
I searched a little bit, and found track.getPosition(); and track.setPosition();, but I am not sure if it serves my doubt.

I have done it:
Forward: track.setPosition(track.getPosition() + (seconds * 1000));
Rewind: track.setPosition(track.getPosition() - (seconds * 1000));
For forward, if the new position is after the end of the song, it will poll the next track.
For Rewind, if the new position is before the start of the song, it will play the same song again.


Automatically take URLs from clipboard

When you select a higher amount of links it gets very annoying to use ctrl+c/v all the time. It would be great if yt-dl had a modus that listens to the clipboards and automatically adds links.

Indeed, invoke yt-dl from a wrapper script.


Added enclave signer to Default Windows policy and cleaned up EKU rules

Issue
Edge now packages an enclaves DLL signed by the new enclaves signer (special EKU + Root 2011). This signature is not default trusted in our Windows template so customers are seeing blocks/audits when running edge.
Fix
Added the enclaves EKU + known root 07 (Root CA 2011) to the policy

Hi,
Any plans to add the updated templates to this directory as well? maybe in the 24H2 update or through Windows Update?
C:\Windows\schemas\CodeIntegrity\ExamplePolicies

@HotCakeX this won't make the bar for windows servicing, unfortunately. It will be added in future windows version


Jenkins two factor authentication plugin

Repository URL
https://github.com/miniOrangeDev/miniorange-two-factor
New Repository Name
miniorange-two-factor-plugin
Description
Two-Factor Authentication for Jenkins Plugin adds a layer of security to Jenkins authentication by requiring users to provide a second factor of authentication along with their username and password. It enhances the overall security of your Jenkins environment. Additionally, this plugin does not require you to extend the security realm, making it easier to implement and use.
GitHub users to have commit permission
Jenkins project users to have release permission
Issue tracker
Jira

/hosting re-check

/hosting re-check

/hosting re-check

/hosting re-check

@miniOrangeDev I have some comments on your repository

could you run mvn tidy:pom on your repository to ease the human reading of the pom.xml
it seems that you have configured the Maven build instruction to use CD process but you haven't included the .mvn files nor the GitHub Action description. Please see https://www.jenkins.io/doc/developer/publishing/releasing-cd/
you can simplify the help file location. They can be in src/main/resources/<path-to-class>/help-<field-name>.jelly. Please see https://www.jenkins.io/doc/developer/forms/jelly-form-controls/#add-an-inline-help-to-a-form-element
I see that you have a lot of CSS definition in your jelly files. Please see https://www.jenkins.io/doc/developer/views/exposing-bundled-resources/#exposing-bundled-resources to centralize that
I would suggest to add the license header on the Java classes
star imports on Java classes should be avoided (see https://github.com/miniOrangeDev/miniorange-two-factor/blob/65cbfa5c7edf095f1741d626002dff875f46a124/src/main/java/com/miniorange/twofactor/jenkins/MoFilter.java#L12 https://github.com/miniOrangeDev/miniorange-two-factor/blob/65cbfa5c7edf095f1741d626002dff875f46a124/src/main/java/com/miniorange/twofactor/jenkins/MoUserAuth.java#L6)
There are some code format issues across some Java classes. To ease the process, you could get some inspiration from https://groups.google.com/g/jenkinsci-dev/c/zUewd9LL5-g

What is the purpose of this plugin which is not yet covered by existing plugins, like the plenty of openId plugins we already host.

/hosting re-check

/hosting re-check

/hosting host

@alecharp Thanks for the suggestions. We will work on these suggestions and update the ticket as soon as possible.

@alecharp @NotMyFault
This is a 2fa plugin which enables the admin to enforce a second factor on the Jenkins side. Such a plugin is not yet available on the marketplace. We plan on adding other several methods as your second factor to secure your Jenkins instance. This plugin works with all security realms. We had received several requests for this plugin.

Thanks for the detailed answer. I don't believe the plugin is in a state yet, where I would expect it on the Jenkins plugins portal. Given, its name doesn't live up with its purpose (yet).
I'd keep this proposal on hold, until the TODO list in the README has been worked through.
Hosting half-baked plugins is not in our interest.

@NotMyFault
I appreciate your feedback regarding the Jenkins 2FA plugin and your concerns about its current state. The current version of the plugin supports complete flow for the security questions as the 2nd factor for authentication in Jenkins. This is not half-baked as the admin can enforce 2FA for their users thus improving the security for the Jenkins instance. Also, as mentioned earlier we had received requests for this plugin from some Jenkins users.
As far as the TODO list in README is concerned, we are going to prioritize and develop the other methods as per user requests. So many user-management-related features along with these methods will be rolled out in future timely releases by our team.
I kindly request you to reconsider putting it on hold. We are confident in our ability to address the remaining tasks promptly and would appreciate the opportunity to continue the approval process.

complete flow for the security questions as the 2nd factor for authentication
this is not half-baked as the admin can enforce 2FA

I sought sources backing these points up, but even OWASP recommends against it.
Therefore, I won't reconsider my previous comment, until the plugins adds at least one actual 2FA method.

@NotMyFault
Thanks for providing the insight. We would like to assure you that we have taken your feedback into account, and we are committed to implementing at least one unique and distinct 2FA method as per your demand. Our team will work diligently to ensure that the plugin meets your expectations and provides added value to the Jenkins community.
We value your support and engagement in this process, and we will keep you updated on the progress of the plugin's development. If you have any further suggestions or specific requirements, please feel free to share them with us.

/hosting re-check

@NotMyFault we have added OTP Over Email method for authentication as per your comment and OWASP guidelines.
Please let us know if you have any further suggestions.

/hosting re-check

@NotMyFault @alecharp We recently updated the plugin accordingly to your requirements. We understand that you may be busy, but we wanted to check on the status of our submission and see if there were any updates or feedback. If there are any changes or improvements required to meet the submission guidelines, we are more than willing to work on them promptly.
Please let us know if there's any additional information you need from our end to process the submission or if there's an
estimated timeline for review. Thank you for your time, and I'm looking forward to hearing back from you soon.

Thanks for adding the changes requested. I am short on time and haven't had the chance yet to take a look at the changes done, but I have some feedback for you:

Please create a .github within the repository root directory with the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
Please create a .mvn folder within the repository root directory with the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/Jenkinsfile#L1 Please update your Jenkinsfile according to https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile
Please update your README.md including updating screenshots reflecting the options this plugin offers.
The groupId io.jenkins.plugins doesn't match your actual groupId used: https://github.com/miniOrangeDev/miniorange-two-factor/tree/master/src/main/java/com/miniorange/
Please move classes and files from com.miniorange to io.jenkins.plugins matching the default groupId.
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/pom.xml#L44 should always match your jenkins.version used.
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/pom.xml#L52-L56 instead of shading jackson yourself, you can depend on the corresponding Jenkins plugin providing it for you: https://plugins.jenkins.io/jackson2-api/dependencies/
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/pom.xml#L60  Please use an up to date version, such as 20230618.
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/pom.xml#L62-L66 please update the plugin according to https://github.com/spotify/fmt-maven-plugin#fmt-maven-plugin and specify a lifecycle and goal. Currently, the maven plugin is shaded into the .hpi file, for no reason, given it's a development tool and doesn't need to be delivered at runtime.
https://github.com/miniOrangeDev/miniorange-two-factor/blob/577860b302b4f75141370f7a214d3a01389fbf65/pom.xml#L67-L71 instead of shading the javax mail api yourself, you can depend on the corresponding Jenkins plugin: https://plugins.jenkins.io/javax-mail-api/dependencies/
Please take a moment and address the open spotbugs issues, you can generate yourself a list with mvn clean verify package.
https://github.com/search?q=repo%3AminiOrangeDev%2Fminiorange-two-factor symbol-arrow-up&type=code is obsolete and should be removed. For navigation, you can use the breadcrumbs, a dedicated sidepanel is not needed.
Rather, use the one-column type, like in https://github.com/jenkinsci/jenkins/blob/d841f1d1f7bd3a164c00cdfa2048df0e2ed9746d/core/src/main/resources/jenkins/agents/CloudSet/new.jelly#L35
If no security method is defined, numerous empty descriptors are added to the user profile, for no reason, that shouldn't be done.
MoGlobalConfig shouldn't be stored in the controller's root directory, but rather in the plugin's directory.

@NotMyFault Thank you for pointing out the above issues. We appreciate you taking out the time and posting the response. We are actively working on the above suggestions and will update the once completed.

@NotMyFault We have diligently addressed the suggestions you highlighted and have taken every effort to ensure that the plugin meets the high standards set by the Jenkins Marketplace. We kindly request you to review the updated version of our plugin at your earliest convenience. We are ready and willing to provide any necessary information or make further modifications to expedite the review process as this is ongoing for a long time and few of our users are waiting for this plugin.

/request-security-scan

/request-security-scan

The Jenkins Security Scan discovered 2 finding(s) :mag:.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.
Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

Jenkins: Plaintext password storage
You can find detailed information about this finding here.
MoGlobalConfigConstant.java#7
Field should be reviewed whether it stores a password and is serialized to disk: key

MoGlobalConfigConstant.java#20
Field should be reviewed whether it stores a password and is serialized to disk: key

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

@NotMyFault We have fixed all the issues pointed out by the security scan. Kindly let us know the next steps required to publish the plugin on the Jenkins marketplace.

/hosting re-check

The first two bullet points in https://github.com/jenkins-infra/repository-permissions-updater/issues/3304#issuecomment-1657121775 remained unaddressed.

/hosting re-check

/hosting re-check

/hosting re-check

@NotMyFault we have added fixes for bot checks as well as the issues pointed out by you.
Please let us know if you need further changes.
Thanks,
Team miniOrange

@NotMyFault Just following up here. Did you get a chance to go through the updated code? Let us know if there are any further suggestions or next steps.

/hosting re-check

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting host


[Bug] copy as curl does not url encode "form url encoded parameters"

Describe the bug
If I copy as curl a regular GET request with query paramters, the query parameters are URL Encoded as expected:
curl --request GET \
  --url 'http://google.com/?asdf=asdf%20asdf'

However, if I copy as curl a POST request with form url encoded paramters, the form parameters are not url encoded:
curl --request POST \
  --url http://google.com/ \
  --header 'content-type: application/x-www-form-urlencoded' \
  --data 'asdf=asdf asdf'

This is inconsistent with the query parameter behavior and causes copy as curl to produce a different request than what Insomnia executes. When executing the request in Insomnia, the parameters are url encoded correctly as shown in the timeline.
The expected copy as curl output is:
curl --request POST \
  --url http://google.com/ \
  --header 'content-type: application/x-www-form-urlencoded' \
  --data 'asdf=asdf%20asdf'

To Reproduce
Steps to reproduce the behavior:

Create new request
Change method to "POST"
Change method to "Form URL Encoded"
Add a form paramter that requires encoding
View the timeline, Insomnia URL encodes correctly
Copy as curl, the URL encoding is absent

Expected behavior

Insomnia's behavior matches the behavior of the "copy as curl" request
Form URL paramters are URL Encoded in "copy as curl"

Screenshots
NA
Desktop (please complete the following information):

OS: macOS 10.14.6
Installation Method: App
App Version v7.0.1

Additional context
NA

Hi @timrs2998  thanks for reporting this issue, and apologies for not getting back sooner!
The root of this problem is in an underlying dependency, httpsnippet that we use - It had been reported in https://github.com/Kong/httpsnippet/issues/197 and there was a fix merged for it recently: https://github.com/Kong/httpsnippet/pull/198.
We'll update you here as soon as we update the dependency in Insomnia.
Heads up @dimitropoulos when we release a new version of httpsnippet and update Insomnia, we should be able to close this issue

HI @filfreire, Any further update/progress on this issue?


Media library UI

- Do you want to request a feature or report a bug?
feature
- What is the current behavior?
If you want to use an image that is already on the site, you must upload the image again when creating a new collection item. If the name of the image is the same, it overwrites the existing images (see #247)
- What is the expected behavior?
Users should be able to choose from images that have already been uploaded to the website. The UI could display images from the media_folder and allow for selecting them.

@chadfawcett agreed, this would be a great feature.

Great feature request, I mentioned a Media Library UI at their CMS redesign discussion as well (https://github.com/netlify/netlify-cms/issues/180#issuecomment-290483411). It's also worth noting, that the Media Library deserves its own link in the primary navigation of the CMS. :-)

If we were to do this, I am wondering if the entry creation implementation should create a separate commit for each file added to a post instead of committing them all in one. (A good side effect of this would be that it would also make the GitLab implementation (#57) easier.)

Just a question/thought: would it be better to upload all media to a separate folder (like we are doing now), or put it "beside" the post/page?

@tech4him1 that all depends on your build tool. If you have other implementation questions, feel free to hit us up on Gitter!

@carlflor this is a hot issue for the community, curious if you're up for kickstarting it? It's less about UI design and more about allowing images and assets to be managed directly, both on upload and when including an image/asset in an entry.
It's closely tied to #432, which is about allowing images and assets to be stored in third party services.
Thoughts?

@erquhart Okay. I'm still in the process of reviewing the code structure, but I can start working on this. :)

@carlflor awesome! I'll write up some high level considerations in a bit.

Below are some points on how the media library implementation could work.
Overview
CMS implementors should be able to create/read/delete assets (images and other files) through a dedicated UI. Starting with a media library overlay allows a basic initial implementation unencumbered by integration concerns with the current UI.
Configuration

Configuration should not be impacted.
Feature should be fully backwards compatible with existing configurations.

Points of Access

The overlay should be shown when clicking a file or image widget in the entry editor.
The overlay should be accessible through a simple button in the top navigation.

Implementation
Overlay

The Dialog component should be used for the overlay itself.
A simple text title such as "Assets" should be displayed in the lop left corner, with the same styling as collection titles in the Collections page.

Bottom Bar

The bottom bar in the Dialog component should contain the following buttons:

Delete: Positioned to far left, disabled when no asset is selected.
Add New: Positioned next to Delete, launches file picker on click.
Insert: Positioned to far right, disabled when no asset is selected.

Hidden unless media library was launched by clicking a file/image widget.

Cancel: Positioned next to Add New, closes the Media Library overlay.

Search

A search bar should be provided, centered in the top of the overlay.
The search bar should only query against filenames.
Displayed assets should update when the search field value changes.
Search results should begin updating after two characters are typed.
Search update should be debounced by ~500ms.

Assets List

The Table component should be used for the list of assets.
Columns should include: "Filename", "Extension", "Created", and "Updated".
Columns should be sortable by clicking a column header.
Clicking a row selects the asset in that row. The user can then insert or delete using the bottom bar buttons.
The data cells in the rows should not be interactive, clicking only selects the row.
Only one row may be selected at a time (multi-select should be a future improvement)

Drag and Drop

Images and files should be uploaded when dragged and dropped to the overlay.
The UI should update when an image/file is being dragged over the overlay.
See the current file/image widget dragging behavior for reference.
Only one file/image may be dragged and dropped at a time.

File/Image Widgets

Dragging images or files to the image/file widgets should still work.

Future improvements

Assets should be stored in collections, similar to the currently used content collections.
Asset collections should be visible on the main CMS UI, and searchable along with content through the primary search mechanism.

Feedback welcome! @carlflor is looking into this, but it's a big undertaking, so please speak up if you'd like to contribute!
cc/ @biilmann @Benaiah @neutyp

This is now underway, WIP PR coming shortly.

I've been poking around at some existing react media libraries and file managers. I've found the following which may be good for inspiration or may have components we can incorporate.
Prior Art

Eureka - full featured, but not very attractive. multiple media sources, search, folder navigation, multiple layouts.
Scotch.io Media Library - an okay example for a developer, but probably not a good fit.
React Keyed File Browser - looks really nice. The interface and components look easy to work with.
React File Explorer - there isn't a demo, but may be worth further investigation.

Alternatives
I've started some wires for an sidebar folder nav style interface as a possible alternative to the current modal centric approach, that may work better for drag and drop workflows, Netlify CMS -
Media Wires on Lucid Chart If you launch it in 'present' mode you should get the basic idea. If people like this as a possible next step I can flesh out the post workflows.
I'm going to try to touch up the existing UX a bit now to make it work sooner rather than later... I'm not sure I'm adept enough at React to start implementing UX from scratch.

I posted some thoughts and mockups on the media library UI over here.

@dopry although assets are obviously files, we want to try to abstract away from making this a folder tree interface as much as possible.
Your screengrab in Lucid is exactly what I meant in the Future Improvements section of my requirements comment above - having assets in collections, just like other content. I'm thinking we'll stay away from nesting collections, but otherwise it looks like we're on the same page.


Guzzle 6 adapter

Could you create a guzzle6-adapter repo? I’d be willing to work on the code.

I've created a repository  with some basic content, but please keep the following in mind:

The interfaces are not finished (yet). Guzzle 5 is the example implementation
Currently I am working on some separation logic, see the internal_separation branches in the relevant repositories

I've also added the package to packagist, travis and scrutinizer


Revert "Update meeting-app-extensibility.md"

Reverts MicrosoftDocs/msteams-docs#4336

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9bd99dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


"Confirm twice"

Idea
NCR could have a "confirm twice" option, described as

If the server requires signing, every chat message needs two Enter keypresses to be sent.

Reasoning
Just like it provided a privacy protection to chat preview, it would provide some "think twice"-esque protection for chat signing. This would not apply for commands that don't require signing (if possible to determine).
Other Information
The code could be directly taken from 1.19.2 chat preview's "when sending" option, even though chat preview itself was removed with 1.19.3.

It's my personal idea that it is disabled by default.


move datanode to internal/node

Clues has grown organically into a split between the api that places data in the right spot (clues) and the structure which contains the data (nodes).  As we move more behavior into subpackages, and as we look forward to future subpackage additions, it makes the most sense to move the node systems into an internal package so that they can be generically utilized across all clues subpackages without issues like import cycles.
This movement is 80% copy/paste, 19% renaming and reorganization, and 1% interface/import adaptation.  No logical changes were intended.

copy/paste: datanode.go has moved into /internal/node/node.go.  otel.go has moved into /internal/node/otel.go.
reorganization: datanode.go has been broken into multiple files.  Discrete concerns (comments, agents, otel) all exist as various files within /node.  Generic and basic functionality stays in /node/node.go.
adaptation: OTELConfig now has a user-facing config builder in /clues/otel.go, while the core otel config struct still lives in /internal/node/otel.go.

replaced by another PR


fix: docs generate support federated query catalogs

Description

Resolve #306
Updated _get_one_catalog to use Glue API only if catalog is of type GLUE, otherwise it runs the get_catalog macro which was changed back to query information_schema.
Models used to test - Optional

Checklist

[ ] You followed contributing section
[ ] You kept your Pull Request small and focused on a single feature or bug fix.
[ ] You added unit testing when necessary
[ ] You added functional testing when necessary

@svdimchenko can you also take a look as a second pair of eyes please ? 😇

hey @Jrmyy, any chance this one could be merged before 1.5.2 release? Not sure when that's planned for. I'm waiting for a second review since addressing this comment.

@maiarareinaldo sorry I totally missed that in the 1.5.2 release - we are planning 1.6.0 release.
@Jrmyy @svdimchenko you had a look already at this one - overall to me seems fine.
Let's see what's the results of the functional tests and eventually merge it.


Getting message "Robot framework installation not found" while running TC.

Hi,
I have installed:
pypubsub==3.3.0
robotframework==3.1.1
robotframework-ride==1.7.3
robotframework-seleniumlibrary===dev
urllib3==1.25.3
I am using selenium2library as i am not able to use seleniumlibrary. When I am running the test, I am getting Message : "Robot Framework installation not found. To run tests, you need to install Robot Framework separately. See http://robotframework.org for installation instructions".
On ride interface getting error:
command: "no pybot" --argumentfile c:\users\anil~1.raw\appdata\local\temp\RIDE_tbdp_.d\argfile.txt --listener C:\Python27\lib\site-packages\robotide\contrib\testrunner\TestRunnerAgent.py:5187:False D:\Robot\Demo
[Error 2] The system cannot find the file specified

Your installation is somehow messed up. Could be you have multiple user accounts and have installed Robot only on one of them. Anyway, this issue tracker is for bug reports and enhancement requests. Use support forums listed at http://robotframework.org for questions.


building a bundle app using electron-react-vite with loadFiles not webserver

I am trying to learn something new here. I am working on client app which uses Electron + react.
I used this github repo to start my project https://github.com/electron-vite/electron-vite-react
And since i am not ready yet to learn typescript, I added //@ts-nocheck to most of my .tsx files in order to avoid  ts warnings/errors till i become ready to learn TS.
My problem that I can not bundle my app to share with others.
in package.json :-
  "scripts": {
    "dev": "vite",
    "build": "tsc && vite build && electron-builder",
    "preview": "vite preview",
    "pree2e": "vite build --mode=test",
    "e2e": "playwright test"
  },

in my first landing electron window = electron/windows/win_landing.ts
I am loading the index.html
mainWindow.loadURL(indexHtml, { hash: arg })

Then i run npm run build
whenever i try to launch the bundeled app which generated under dist/, i get
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/plain". Strict MIME type checking is enforced for module scripts per HTML spec.

index.html:-
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <link rel="icon" type="image/x-icon" href="/favicon.ico" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline';" />
    <title>Orion</title>

This error never show up when i use mainWindow.loadURL('http://localhost:5173/app/landing') in my win_landing.
I tried to change  in my index.html file to main.js, I receive this error
caught TypeError: Failed to resolve module specifier "react/jsx-runtime". Relative references must start with either "/", "./", or "../".
I tried to change the name of my main react js script to index.js instead of index.tsx,
also tried to change to .mjs.
Also tried to add         mimeTypes: {           'ts': 'application/javascript',           'tsx': 'application/javascript',         }
to vite.config.ts
If you could help me to figure out what i am missing to build my app correctly i will be grateful.
Here is my github repo if you want to give a deeper look
GITHUB

Try to add this npm module "isDev" to check if its in dev-mode or prod-mode
If in dev mode, your function that loads the file should be like "window.loadURL("path/to/your/local/server")" and if in prod "window.loadFile("path/to/your/index-file")"

Try to add this npm module "isDev" to check if its in dev-mode or prod-mode
If in dev mode, your function that loads the file should be like "window.loadURL("path/to/your/local/server")" and if in prod "window.loadFile("path/to/your/index-file")"

Fixed this issue a long time ago, try if it works

i update my electron landing window with this :
process.env.DIST_ELECTRON = join(__dirname, '../')
process.env.DIST = join(process.env.DIST_ELECTRON, '../')
process.env.PUBLIC = process.env.VITE_DEV_SERVER_URL
  ? join(process.env.DIST_ELECTRON, '../public')
  : process.env.DIST

const indexHtml = join(process.env.DIST, 'index.html')

    var arg = ''
    if (process.env.VITE_DEV_SERVER_URL) {
      mainWindow.loadURL('http://localhost:5173/app/landing')
    } else {
      console.log(indexHtml)
      mainWindow.loadFile(indexHtml, { hash: arg })
    }

my index html

then i executed npm run build
this is the output :
PS E:\PC\orion ui ts\v2> npm run build

><EMAIL_ADDRESS>build
> tsc && vite build && electron-builder

vite v4.2.1 building for production...
✓ 2172 modules transformed.
dist/index.html                                                      0.56 kB
dist/assets/nokiapureheadline_regular-webfont-cf1eab8a.woff2        22.14 kB
dist/assets/nokiapureheadline_ultralight-webfont-477509db.woff2     23.00 kB
dist/assets/nokiapureheadline_light-webfont-97d5cfce.woff2          23.54 kB
dist/assets/nokiapureheadline_extrabold-webfont-1a52d383.woff2      23.68 kB
dist/assets/nokiapuretext-regular-webfont-d2713333.woff2            24.29 kB
dist/assets/nokiapuretext-light-webfont-82f8a3cc.woff2              24.45 kB
dist/assets/nokiapureheadline_bold-webfont-8b6e74a9.woff2           24.60 kB
dist/assets/nokiapuretext-bold-webfont-f4d52e6d.woff2               24.74 kB
dist/assets/nokiapuretext-medium-webfont-a785f03b.woff2             25.87 kB
dist/assets/nokiapureheadline_regular-webfont-c700330a.woff         28.28 kB
dist/assets/logo-top-bar-e2104280.png                               28.32 kB
dist/assets/nokiapuretext-regular-webfont-fc977afa.woff             29.86 kB
dist/assets/nokiapuretext-light-webfont-abae7846.woff               30.14 kB
dist/assets/nokiapureheadline_ultralight-webfont-95171def.woff      30.23 kB
dist/assets/nokiapuretext-bold-webfont-acc26026.woff                30.58 kB
dist/assets/nokiapureheadline_light-webfont-f431fe87.woff           30.72 kB
dist/assets/nokiapureheadline_extrabold-webfont-c2ab804c.woff       31.46 kB
dist/assets/orionlogo-01d00864.png                                  31.77 kB
dist/assets/nokiapureheadline_bold-webfont-8a5a5012.woff            32.34 kB
dist/assets/nokiapuretext-medium-webfont-750e5ef6.woff              33.13 kB
dist/assets/rolling-a1156b02.gif                                    80.29 kB
dist/assets/index-5c8829c9.css                                     416.66 kB │ gzip:  62.33 kB
dist/assets/index-247bbe46.js                                    2,770.84 kB │ gzip: 744.54 kB

(!) Some chunks are larger than 500 kBs after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 37.28s
vite v4.2.1 building for production...
✓ 5 modules transformed.
dist-electron/main/index.js  3.81 kB │ gzip: 1.32 kB
✓ built in 99ms
vite v4.2.1 building for production...
✓ 1 modules transformed.
dist-electron/preload/index.js  1.60 kB │ gzip: 0.77 kB
✓ built in 27ms
  • electron-builder  version=23.6.0 os=10.0.19042
  • writing effective config  file=dist\builder-effective-config.yaml
  • packaging       platform=win32 arch=x64 electron=24.1.2 appOutDir=dist\win-unpacked
  • building        target=nsis file=dist\Orion Setup 2.2.0.exe archs=x64 oneClick=true perMachine=false
  • building block map  blockMapFile=dist\Orion Setup 2.2.0.exe.blockmap
PS E:\PC\orion ui ts\v2>

then i go to dist/ and launch my electron app,
i see this error
Failed to load resource: net::ERR_FILE_NOT_FOUND main.ts:!1

i get this error:
Error: The following dependencies are imported but could not be resolved:

  ag-grid-community/styles/ag-grid.css (imported by E:/GitHubDesktop/orion-ui-client/src/components/dataTable.js)
  ag-grid-community/styles/ag-theme-alpine.css (imported by E:/GitHubDesktop/orion-ui-client/src/components/dataTable.js)
  prop-types (imported by E:/GitHubDesktop/orion-ui-client/src/components/sp_FormEdit.js)

Are they installed?
    at file:///E:/GitHubDesktop/orion-ui-client/node_modules/.store/vite@4.3.3/node_modules/vite/dist/node/chunks/dep-a178814b.js:44144:23
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///E:/GitHubDesktop/orion-ui-client/node_modules/.store/vite@4.3.3/node_modules/vite/dist/node/chunks/dep-a178814b.js:43553:38

E:\GitHubDesktop\orion-ui-client\index.html

maybe your src/components/** have some error?

Facing same problem can you tell what exactly could be the issue in components/ ?

{
  "scripts": {
    "dev": "vite"
  },
}

npm run dev does a lot of work behind the scenes, not just compiling .tsx, .ts into .jsx, .js.
For those just starting out with Electron, I recommend using electron-quick-start

I've been facing issue with blank page after compilation
I solved it with MemoryRouter
You can either use MemoryRouter or HashRouter whatever you want