ConversationalRetrievalQAChain factory method only supports QA stuff chain, fails on long inputs

Here is a snippet of my code:
const loader = new PDFLoader('./基于贝叶斯优化的无标签网络剪枝算法.pdf')
const pdf = await loader.load()
const textSplitter = new RecursiveCharacterTextSplitter({
  chunkSize: 1000,
  chunkOverlap: 0
})
const docs = await textSplitter.splitDocuments(pdf)
const vectorStore = await PineconeStore.fromDocuments(
  docs,
  new OpenAIEmbeddings({
    openAIApiKey: process.env.OPEN_API_KEY
  }),
  {
    pineconeIndex
  }
)`
`const vectorStore = await PineconeStore.fromExistingIndex(
  new OpenAIEmbeddings({
    openAIApiKey: process.env.OPEN_API_KEY
  }),
  { pineconeIndex }
)
/* Create the chain */
const chain = ConversationalRetrievalQAChain.fromLLM(
  model,
  vectorStore.asRetriever(),
  { verbose: true }
)
const question =
  '对于没有经过任何优化的高斯过程，n 个样本点时间复杂度大概是多少?'
try {
  // your async function here
  const res = await chain.call({ question, chat_history: [] })
  console.log(res.text)
} catch (error) {
  if (error.response) {
    console.log(error.response.status)
    console.log(error.response.data)
  } else {
    console.log(error.data.message)
  }
}

After adding the parameter verbose:true, I received the following error message in the terminal:

The error message you're seeing means that your prompt is too many tokens, and it looks like that's happening because the ConversationalRetrievalQAChain.fromLLM method is only letting you use a specific type of chain with no option to change it:
https://github.com/hwchase17/langchainjs/blob/main/langchain/src/chains/conversational_retrieval_chain.ts#L156
For now, can you try creating the conversation chain similarly to this?
import { loadQAMapReduceChain } from "langchain/chains/load";
const question_generator_template = `Given the following conversation and a follow up question, rephrase the follow up question to be a standalone question.

Chat History:
{chat_history}
Follow Up Input: {question}
Standalone question:`;

const qa_template = `Use the following pieces of context to answer the question at the end. If you don't know the answer, just say that you don't know, don't try to make up an answer.

{context}

Question: {question}
Helpful Answer:`;

const  chain = new ConversationalRetrievalQAChain({
      retriever: vectorStore.asRetriever(),
      combineDocumentsChain: loadQAMapReduceChain(model),
      questionGeneratorChain: new LLMChain({
        prompt: question_generator_prompt,
        llm: model,
        verbose: true,
      }),
      verbose: true,
    });

Basically, using the constructor manually with a map reduce chain instead of the default stuff chain: https://github.com/hwchase17/langchainjs/blob/main/langchain/src/chains/conversational_retrieval_chain.ts#L62

Thank you for your answer. The solution you provided is very helpful!

Awesome! I'm going to leave this open though because this should be configurable.

Indeed! However, I have another small question that I would like to ask you for advice on. My idea is, if the answer cannot be found from the PDF materials I provided, how can I make it turn to call an API to generate answers from OpenAI and also inform the user that the answer is not from the PDF database? I tried adjusting prompts but it never meets my expectations.

In that case,
qaChainOptions: {
  type: "refine",
  template: YOUR_CUSTOM_TEMPLATE
}

The template will need to have certain input variables filled in though.

我修改了template和question_generator_prompt，但是它并没有起效

I modified the template and question_generator_prompt, but it didn't take effect.

Ah, my mistake. You'll need to pass prompt into qaChainOptions:
{
  type: "refine",
  prompt: PromptTemplate.fromTemplate(qa_template)
}

You should remove the other qaTemplate. Are you using Typescript?

This is what it does internally:
https://github.com/hwchase17/langchainjs/blob/90f6cb05e380dc45b1ae3f4e0d4287f19da0b2ef/langchain/src/chains/conversational_retrieval_chain.ts#L178

I used JavaScript and modified the code according to the method you provided, but there was not much difference compared to last time.

Sorry, my mistake again. This is the object it takes:
https://github.com/hwchase17/langchainjs/blob/main/langchain/src/chains/question_answering/load.ts#L96
Since the refine chain works in two steps, there are two prompt options you can override. You can see the default values here: https://github.com/hwchase17/langchainjs/blob/main/langchain/src/chains/question_answering/refine_prompts.ts
{
  type: "refine",
  questionPrompt: PromptTemplate.fromTemplate(CUSTOM_QUESTION_TEMPLATE),
  refinePrompt: PromptTemplate.fromTemplate(CUSTOM_REFINE_TEMPLATE)
}

It's okay, I've got it covered. I really appreciate your help!

I have made multiple modifications to the prompt, but it did not return the expected results. Did I select the corresponding prompt incorrectly? Which part of the chain should I modify for the prompt? I hope that if it cannot find an answer in the knowledge base, it can directly call on a large model to provide an answer instead of relying on information from the knowledge base.


Add missing whitespace in the templating tag

Helm renders the chart fine but flux chokes on it for some reason so it is worth fixing.
Thank you for the helm chart!

In the end it turned out my problem with flux was caused by something else but I will leave this open to make things more consistent :)

thanks @Gregy ! I fixed it as part of f15e05a 🙇


Return all the qualifiers as well in the /metadata/datasets/{dataset_id}/variables API

Right now the api only returns, name, variable_id and dataset_id

@zmbq this is working , but we should change identity to identifier
{
    "name": "Total number of aid workers affected",
    "variable_id": "total_aid_workers_affected",
    "description": "The total number of aid workers affected by major security incidents.",
    "corresponds_to_property": "PAWSD-total_aid_workers_affected",
    "qualifier": [
      {
        "name": "stated in",
        "identify": "P248"
      },
      {
        "name": "point in time",
        "identify": "P585"
      }
}

Oops. that's a weird typo!


class binding with options?.fieldHtmlClass

PR Type
What changes does this PR include (check all that apply)?
[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build process changes
[ ] Documentation changes
[ ] Other... please describe:
Related issue / current behavior
#220
New behavior
Sets additionnal classes (especially useful for inputs/text)
Does this PR introduce a breaking change?
[ ] Yes
[ x ] No

Hi, @dschnelldavis , any plans to merge (or close) the pull requests, mine or others?


How to Recover Samsung Galaxy S7 Edge Messages?

For some reason you may deleted text messgaes from your Samsung Galaxy s7 edge, accidentally deleting, ROM flashing or other unknown reasons. Many Samsung users may ask is it possible to recover deleted text messages from Samsung Galaxy s7 edge? Any way to recover lost sms text messages Samsung s7 edge?
To recover your lost text messages on Samsung Galaxy s7 edge, you need to use Samsung Data Recovery-Android data recovery tool, which is a professional data recovery for Samsung galaxy to get back deleted data from Samsung Galaxy,you can use this Samsung Data Recovery to recover all lost or deleted contacts, messages, photos, videos, whatsapp chat history and audio files on Samsung phones.
Steps to Recover  text messages from Samsung s7/s7 edge:
Step 1: Connect your Samsung device to the computer
Step 2: Enable USB debugging on your Samsung Galaxy Device
Step 3: Analyze and Scan data from your Amdroid Samsung Galaxy s7/s7 edge
Step 4: Browse and recover lost messages from Samsung Galaxy s7
More details info:
Recover Deleted Text Messages from Galaxy S7/S7 Edge
How to Recover Deleted Contacts from Galaxy S7/S7 Edge

Samsung Galaxy Recovery and Samsung Recovery for Mac can helps to restore any lost and deleted files from almost any Samsung Galaxy devices in a click. So, you can recover deleted messages from Samsung S7 Edge/S7 by using this tool.
Read more:
Recover deleted call history from Samsung S7 Edge
Recover whatsapp messages from Samsung S7 edge

Android Phone Recovery supports to restore deleted and lost data from your computer. All the important information and media files stored on your smart phone can be recovered on one click.

Coolmuster Android SMS Contacts Recovery software supports recover data from 200Android device models .So using it to retrieve deleted messages at easy . Not only data saved internal memory,but also SD card ,you can get data back with help of it.
How to recover deleted text messages Samsung galaxy s7

To recover deleted or lost text messages from Samsung Galaxy S7 Edge, Android SMS Recovery can help us do that easily. Just connect the Samsung Galaxy S7 Edge with computer, start the program then we can directly recover them.

Samsung phone users can use Samsung Kies to transfer data to pc, and if the data were lost, there is a backup on pc.
But if you did not backup them before, you can still have the chance to get them back.
There are many data recovery methods, DiskDigger or Recuva, you can also try professional android recovery software, you can recover deleted SMS from Samsung Galaxy.

It's quite possible to recover deleted text messages from samsung if you use a data recovery app to help immediately. By the way, you need to root your phone to restore lost sms and contacts

As far as i know, an android sms recovery app could get lost text messages back in few steps, try this one, it supports every kind of android device.

Nice share! To Recover Deleted messages from Samsung Galaxy S7, we need stop using the Samsung phone first in case of data overwritten. Then find a Samsung data Recovery software to get them back. It's easy and safe.

Err... All of these posts are spams!!!

For those who want to recover messages on Android phone ,Messages Rescuer can help you.
It is able to recover lost Contacts, Messages,Photos, Videos, Camera Roll, Photo Library, Message Attachments, Call History and more back on Android .

see the best recovering method for Samsung Galaxy S7 or Samsung Galaxy S7 Edge

Coolmuster Android SMS + Contacts Recovery software is a  efficient tool, allowing you to scan, preview and recover deleted messages  what have been lost from your Android phone securely. You can retrieve lost contacts, text messages, call logs, photos, audios, videos and documents from your Samsung galaxy with three steps.


Copper support

Hello, I'd be great if you add copper support for your plugin.
I tried it in the config file like this: copper_ingot: 0.6
but it still adds 0.0 to the currency power, so I guess it's something about the core-side of the plugin.
Thank you.

Thank you for your feedback. I will try to fix it as soon as possible !

@kauf0 It should be fixed now on Version 1.1 Snapshot 1 !


[BUG] Docs link does not lead to docs website

Describe the bug

The docs link leads here:
https://github.com/harvester/harvester/tree/master/docs
To Reproduce
Steps to reproduce the behavior:

Click docs link in footer of UI

Expected behavior

Should lead to https://docs.harvesterhci.io/v0.2/  or https://docs.harvesterhci.io/v[$version]/
(Or there should at least be a readme in the docs directory with a current link to docs)
Environment:

Harvester ISO version:  v0.2
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Already fixed here:
https://github.com/harvester/harvester-ui/commit/5fa9286d01bfb6fb197c1d4e59bf5450734600c8#diff-428cf92b92e3618d37c4a8249e17583e9b1fc7982d529b9967073bdc1daa698d


Numeric value out of range with Postgres 12

Hi.

SQLSTATE[22003]: Numeric value out of range: 7 ERROR:  input is out of range (SQL: select *, acos(sin(1.0395159958754)*sin(radians(latitude)) + cos(1.0395159958754)*cos(radians(latitude))*cos(radians(longitude)-0.52601709333789)) * 6371 As distance from (select * from "cities" where "latitude" between 57.761236088163 and 61.358522511837 and "longitude" between 26.587818705252 and 33.689300094748) as "cities" where acos(sin(1.0395159958754)*sin(radians(latitude)) + cos(1.0395159958754)*cos(radians(latitude))*cos(radians(longitude)-0.52601709333789)) * 6371 < 200 and "size" >= 2 order by distance, "size" desc limit 50

Latitude: 59.5598793
Longitude: 30.1385594

Hi, please share your migration for the relevant table.


Watcher for GUI should not run on change in engine code

This task is automatically imported from the old Task Issue Board and it was originally created by Michał Urbańczyk.
Original issue is here.

No description provided.

No longer relevant with the old gui gone.


GetIamPolicy should be idempotent

The generator (at least in Go) marks it otherwise:
  GetIamPolicy:       retry[[2]string{"default", "non_idempotent"}],

Never mind, this is decided by config.


ServiceLayer.exe

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed0ad4c6-13f4-9fb3-e4e9-5d70a6cde5fc
Version Independent ID: 39ac04e7-703a-2e91-7272-4f3af2ba9a59
Content: ServiceLayer Class (Microsoft.CodeAnalysis.Host.Mef)
Content Source: dotnet/xml/Microsoft.CodeAnalysis.Host.Mef/ServiceLayer.xml
Product: dotnet-roslyn-api
Technology: microsoft.codeanalysis
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

@Angelo69767 Could you provide some more info on the issue at hand?

I was going to look for software for my Nokia 5800. That's it.
On Tue, 5 May 2020 at 01:00, Genevieve Warren<EMAIL_ADDRESS>wrote:

@Angelo69767 https://github.com/Angelo69767 Could you provide some more
info on the issue at hand?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/18254#issuecomment-623769510, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOHVCR6ZXY6RORWQWHINCG3RP5JH7ANCNFSM4MZBLDTA
.

Okay, I will close this issue since it sounds like you didn't mean to create an issue.


Tops 645 nig2 parent lookup update

TOPS-645
background
NIG2 and the wording surrounding it is a bit of a grey area, we have however observed data coming from the EU that gave us insights that the interpretation we have differs from the interpretation the EU has. This is causing issues when we are getting data from the EU.
The rule states: "The validity period of the goods nomenclature must be within the validity period of the product line above in the hierarchy."
currently
NIG2 will fail if the "current" parent does not encapsulate the valid between date period, so if a child good nomenclature is valid between 1/1/20202 and 1/2/2022 and the parent is valid between 1/1/2022 and 15/1/2022 (even if there is another parent that would be next in the chain with a valid period of 1/1/20202 and 1/2/2022 or more) the validation will fail (as of today) note : the rule is looking at historical dates!
proposed
a child is valid if it has valid parents (note plural) from today forward, not looking at the start date of the child but from todays date forward, looking at all valid parents (which we are defining as the grandparents children, where the item id is less than or equal to the child's item id, or where the item ids are equal but the suffix is less than the child's suffix). We then join all the parents valid between dates where they overlap to create a valid date range that the child valid range can be compared against - if the child's valid range falls within the joint parents range - the rule passes

@gabelton Would you mind having a look at this when you get a moment, sometime when you're back? You had some great points (e.g. about child dates using todays dates) in our last convo, do you think the latest updates here redress them? Thanks Gabe :)

Codecov Report
Base: 93.94% // Head: 93.75% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (8992533) compared to base (9ee31c6).
Patch coverage: 69.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   93.94%   93.75%   -0.19%
==========================================
  Files         343      343
  Lines       22387    22536     +149
  Branches     1705     1735      +30
==========================================
+ Hits        21031    21129      +98
- Misses       1044     1084      +40
- Partials      312      323      +11

Impacted Files
Coverage Δ

common/tests/util.py
89.11% <ø> (ø)

workbaskets/models.py
79.45% <21.73%> (-6.78%)
:arrow_down:

workbaskets/tests/test_admin.py
82.08% <27.27%> (-10.77%)
:arrow_down:

common/util.py
85.35% <59.25%> (-3.33%)
:arrow_down:

commodities/business_rules.py
88.80% <79.41%> (-6.99%)
:arrow_down:

commodities/models/dc.py
74.30% <81.81%> (+0.12%)
:arrow_up:

workbaskets/admin.py
82.71% <84.61%> (+0.10%)
:arrow_up:

commodities/tests/test_business_rules.py
99.37% <100.00%> (+0.11%)
:arrow_up:

quotas/business_rules.py
96.05% <100.00%> (+0.07%)
:arrow_up:

quotas/tests/test_business_rules.py
99.55% <100.00%> (+0.01%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


dl/internal/version: consider to unset GOTOOLCHAIN

I've updated my default go using go env -w GOTOOLCHAIN=go1.21.5+auto.
$ go env GOTOOLCHAIN
go1.21.5+auto

After that, the instruction in managing go installation does not work any more.
$ go install golang.org/dl/gotip@latest
$ gotip download
...
$ gotip version
go version go1.21.5 darwin/amd64

Same for other version wrappers.
The easiest fix may be to set GOTOOLCHAIN=local or GOTOOLCHAIN= when these wrapper binaries invoke go.
Alternatively, we can deprecate the current "managing go installation" doc, and recommend to use GOTOOLCHAIN to switch the version instead.

That's an interesting way for these behaviors to intersect. But also it seems unexpected to me that gotip, whose version is something like go1.22-b18b058816 (i.e., language version 1.22) ends up selecting go1.21.5 (i.e., language version 1.21) given that https://go.dev/doc/toolchain#version says:

Released Go toolchains such as Go 1.21.0 and Go 1.21rc1 report that specific version (for example, go1.21.0 or go1.21rc1) from go version and runtime.Version. Unreleased (still in development) Go toolchains built from the Go development repository instead report only the language version (for example, go1.21).
Any two Go versions can be compared to decide whether one is less than, greater than, or equal to the other. If the language versions are different, that decides the comparison: 1.21.9 < 1.22.

And https://go.dev/doc/toolchain#select says:

When GOTOOLCHAIN is set to +auto or +path (or the shorthands auto or path), the go command selects and runs a newer Go version as needed.

Maybe I'm overlooking something, but it seems like unexpected cmd/go behavior (with some similarity to #63357). CC @bcmills.

to set GOTOOLCHAIN=local

Note that doing this would get in the way of another aspect of how these goX.Y.Z commands work. This comment has more context.

It is expected that setting an explicit variable in the GOTOOLCHAIN variable results in a downgrade: the version set in the GOTOOLCHAIN variable, if any, indicates the minimum acceptable toolchain version.
(This is in contrast with, say, the toolchain or go line from the main module's go.mod file, which should only ever raise the selected version of the toolchain.)
It isn't obvious to me what the dl wrappers ought to do if GOTOOLCHAIN lists a specific version: in that case, we have two conflicting sources of user information (GOTOOLCHAIN and the name of the command itself), and I don't think I can confidently infer what the user intends to happen. (Clearly in this case @hyangah intends for the name of the command to win, but is that true for everyone in general? 🤔)

we have two conflicting sources of user information, and I don't think I can confidently infer what the user intends to happen.

A (lazy?) approach would be to error in this case and thus require the user to be more specific.

The interaction with gotip & GOTOOLCHAIN=go1.21.5+auto is quite surprising. It shoud've picked up go1.22 dev version.
For go1.X.Y wrappers, the issue here is user's GOTOOLCHAIN setting coming from go env -w, which is IMO often a footgun :-(.

Clearly in this case @hyangah intends for the name of the command to win, but is that true for everyone in general? 🤔)

Other than go command line tool developers, how often a go user would be interested in testing the toolchain switch behavior (how go1.X.Y interacts with GOTOOLCHAIN environment variables)? It's more likely that they reach out to this wrapper because they expect behavior similar to the old go version and they need to test their program compiled against a specific version of go (e.g. why is my program slow or test broken after I updated my docker container's go version??)

Today I faced the same issue, and +auto doesn't behave as I expected. (Isn't it a bug?)
$ GOTOOLCHAIN=go1.22.0+auto gotip version
go version go1.22.0 darwin/amd64

$ GOTOOLCHAIN=local gotip version
go version devel go1.23-daa58db486 Fri Feb 16 11:59:07 2024 +0000 darwin/amd64

@prattmic Can you tell me more about the approach you are suggesting? Most part of go commands is designed to work without human interaction and this wrapper is designed to be interchangeable with 'go', it's unclear to me how this should be surfaced.
Is there a way to tell whether GOTOOLCHAIN value was set from go env -w or coming form the environment variable? The intention when users run the wrapper with environment variable may be unclear, but go env -w + wrapper is most likely oversight.

see #34208 for identifying the source of settings

@hyangah My suggestion was to error on conflict. Something like:
$ GOTOOLCHAIN=go1.21.5 gotip version
error: dl version `tip` and GOTOOLCHAIN version `1.21.5` conflict
<exit code 1>

I don't know if this is a good idea, it just came to mind from Bryan's comment "I don't think I can confidently infer what the user intends to happen". Thus, we refuse to infer at all.

I think the vast majority of users will either leave GOTOOLCHAIN unset or use GOTOOLCHAIN=auto or GOTOOLCHAIN=local, and as far as I can tell the behavior for those two cases isn't surprising.
And GOTOOLCHAIN=go1.21.5 go version seems unambiguous, too: GOTOOLCHAIN=go1.21.5 means “use exactly go1.21.5”, so go version go1.21.5 is the only version that can reasonably report. I guess it follows from that that GOTOOLCHAIN=go1.22.0 gotip version ought to exec exactly go1.22.0 and report its version, because gotip is supposed to behave like go.
The confusing combination, I think, is GOTOOLCHAIN=go1.22.0+auto, where the exact version given is order than the toolchain being invoked. But (a) hardly anybody ought to be using a command like that, and (b) it does seem understandable if you reverse-engineer from what actually happens.
That said, maybe we should log something to stderr when we intentionally switch to an older toolchain? 🤔

Alternatively, we can deprecate the current "managing go installation" doc, and recommend to use GOTOOLCHAIN to switch the version instead.

FWIW, I think the instructions in that doc are still the best way to manage the minimum Go installation, and I don't think we should suggest setting something like GOTOOLCHAIN=go1.21.5+auto for that — we don't want users to become stuck on an old toolchain when their installed toolchain is newer.
But we also don't currently have a GOTOOLCHAIN setting that means “be sure to upgrade to at least go1.21.5, but newer is ok too.” Perhaps we should. 🤔

I think there's a good argument for gotip to force GOTOOLCHAIN=local as it runs the go binary it picks.
The versioned go commands cannot do this, because we expect a sequence of upgrades as execs happen in the most complex auto-upgrade cases.


multimaterial not working

 if(iMat == 0)
	node.material = matname;
else
{
	if(!node.materials)
		node.materials = [];
	node.materials.push(matname);
}

is that because this code only assign the first material to node material? how to fix this?

i just find that there's a sub materials attribute in litescene/meshrender component. would you please give me some tips about how to use this feature? or any doc?
https://github.com/jagenjo/litescene.js/blob/master/src/components/meshRenderer.js#L44

multimaterial is not fully supported yet, there has been some proof of work done but due to the way the engine is organized (every node has only one material) is not easy to solve.


ViroSampleApp Xcode Building issue

Hi viro friends!!
I have faced another error when building the xcode porject of virosampleapp.
mainly it was associated with  "OBJC_CLASS$_VRTBundleURLProvider", referenced from:
objc-class-ref in AppDelegate.o
here islog of what i am suffering now.

ld: warning: ignoring file /Users/KHC/ViroSample/node_modules/react-viro/ios/dist/lib/libViroReact.a, missing required architecture x86_64 in file /Users/KHC/ViroSample/node_modules/react-viro/ios/dist/lib/libViroReact.a (2 slices)
ld: warning: ignoring file /Users/KHC/ViroSample/node_modules/react-viro/ios/dist/ViroRenderer/ViroKit.framework/ViroKit, missing required architecture x86_64 in file /Users/KHC/ViroSample/node_modules/react-viro/ios/dist/ViroRenderer/ViroKit.framework/ViroKit (2 slices)
Undefined symbols for architecture x86_64:
"OBJC_CLASS$_VRTBundleURLProvider", referenced from:
objc-class-ref in AppDelegate.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

thanks in advance!!!

Hi @Polaris00418,
Below is a copy of the answer I gave you on this question: viromedia/viro#87 (comment)

It looks like you're trying to build your app for the iOS Simulator (x86_64), we don't support the iOS Simulator, so you'll need to run it on an actual iOS device (iPhone/iPad).
I downloaded your project and was able to run it on my iPhone 6S, except I had to change 1 setting in the project file, I had to set "Enable Bitcode" to "No", see the screenshot below for my project setup:

Let me know if that works for you!

i set enable bitcode "no" at that time..  and of course i am using iphone x

Hi @Polaris00418,
Make sure that your device is selected in the top left hand corner of Xcode:

Let me know if that doesn't work

hi sure i have connected correctly and it 's selected properly..

please check out
thanks

Hi @Polaris00418,
If you go into ViroSampleAR/ios make sure that you have run pod install and then ensure that you're opening the ViroSampleAR.xcworkspace not the ViroSampleAR.xcodeproj directory.
Thanks

Closing issue due to inactivity

Does this mean we can not run the app in the simulator anymore? We have an otherwise 2D app, that has an optional AR module. We definitely would like to test the non-AR related parts of the app with the simulator. Is that possible?

Hi @itchingpixels,
Yes, this is a limitation with our framework right now in that it is not compiled for x86 (Intel/AMD chipsets).
You can try the suggestions listed here:
https://stackoverflow.com/questions/31574430/optional-framework-not-working-coreaudiokit-not-on-simulator
Essentially using preprocessor macros to "hide" any references to Viro when compiling for the iOS Simulator. You may also need to change how you link against our framework(s).
We ourselves haven't tested this method yet, but do let us know if you do run into issues with it. We'll look into adding, at the very least, compiling support for the iOS simulator, if not full support.
Thanks,

Thank you, we'll give it a go!

Hi @itchingpixels ,
It looks like another one of our users were able to build their app for simulator by making our framework optional.
https://github.com/viromedia/viro/issues/175
Feel free to follow the instructions there and let us know if you run into any issues.
Thanks,


Reduce clown snore volume

About the PR

Reduced the volume of the Clown's snoring.
Why / Balance

Snoring was previously too loud. Mentioned in issue #26962.
Technical details

Reduced volume by 20dB.
Media

https://github.com/space-wizards/space-station-14/assets/63034378/78a3549d-5ebe-4605-a0c6-0d428a6a0467

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None
Changelog

:cl:

tweak: Made clown snoring quieter

Thank you


Clean up some C APIs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.93%. Comparing base (aaf4831) to head (e6d7422).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #445      +/-   ##
===========================================
- Coverage   100.00%   93.93%   -6.07%
===========================================
  Files           21       21
  Lines         2310     2308       -2
===========================================
- Hits          2310     2168     -142
- Misses           0      140     +140

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


VictoryLabels do not render

VictoryLabel was unintentionally broken as part of #56. It current does not throw an error, but also does not render anything.

Two theories from Lauren...

maybe something changed with the  tag in react-native-svg
maybe a change in victory-core caused this - try pinning versions

I think we can rule out #2. Running npm ls | grep victory on a copy of the repo before and after #56...
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>
├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>is also identical to the version in package.json.

alright, I think I found the issue in victory-native's VictoryLabel: https://github.com/FormidableLabs/victory-native/blob/master/lib/components/victory-label.js#L25
The current code no longer renders any content(where content is a 0- or 1-element array of strings):
     <Text {...baseProps} {...style} {...transform} {...props.events} dy={dy}>
       {content}
     </Text>

However, adding an empty string to the <Text/> container ahead of content renders properly:
     <Text {...baseProps} {...style} {...transform} {...props.events} dy={dy}>
       {""}{content}
     </Text>

@boygirl any idea why this might be?

I've reproduced this with just react-native-svg
does not work:
        <Svg height="300" width="300">
          <SvgText x={150} y={150}>
            {["test"]}
          </SvgText>
        </Svg>

works:
        <Svg height="300" width="300">
          <SvgText x={150} y={150}>
            {""}{["test"]}
          </SvgText>
        </Svg>

I've filed https://github.com/react-native-community/react-native-svg/issues/284

Is this getting fixed in the next release? PR?

@edo1493 yes! sorry, it was merged in https://github.com/FormidableLabs/victory-native/pull/59


Full screen modal

The modal should support full screen mode for smaller viewport widths.  This would entail adjusting the max-width style rule of calc(100% - 32px) that is currently in place.

The current thinking is to add a prop to represent that "gutter" (defaulting to 16px) and allow the caller to decide

@jes708  -- please try overriding the style from within your implementation
The className attribute is attached to the right component to allow this override:
https://github.com/pricelinelabs/design-system/blob/master/packages/modal/src/Modal.js#L170


Monster extends

Monsters and Characters share a lot of attributes, such as calculating ability scores from ability modifiers and being able to use weapons, armour, having senses and languages etc.
Everything shared between the two classes should be in a base class or in traits
Monster extends BaseCharacter
Character extends BaseCharacter

Sounds like JavaScript

Would suggest maybe something like:
class Character {}
class Player extends Character {}
class Monster extends Character {}
class Npc extends Character {}

Yeah I did think something like that, but I think Players and NPCs are probably going to be identical except that the Player character belongs to a Player user and an NPC belongs to the DM.
It does make the most sense though, so probably will go with that 👍


Fix errors that mobile users are experiencing on apply

Context
According to the logs we had hundreds errors that users are encountering.
The issue arises because mobile Safari reloads pages from cache after the browser is closed and reopened.
When this happens, the session cookie that stores the CSRF token is gone, but the form still contains the old token. This mismatch leads to an error when the user tries to submit the form.
Rails stores the authenticity token in a session cookie, which gets deleted when the browser is closed. On mobile Safari, when you reopen the browser, it reloads tabs from cache, but the session cookie is gone. As a result, the authenticity token in the form can't be verified when the form is submitted.
Solution

Add the user agent on the logs to help to understand the issue faster (it took me 3 days to understand the issue!)
Add custom headers

Instruct Safari (and other browsers) to request a fresh version of the page before resubmitting it

no-store: Prevents the response from being cached by the browser, ensuring it is fetched anew with every request.
no-cache: Requires caches to validate the resource before using it, ensuring that any changes are accounted for before serving the cached version.

 Fix errors that mobile users are experiencing on Apply

The assets cache control are left untouched (expected) and the new cache control added:

I recommend who review this PR to test in a mobile as well before approving.

I stumbled across this article on caching today and it got me thinking that we could set a max-age on the cache to slightly shorter than a CSRF token is valid for 🤔

I stumbled across this article on caching today and it got me thinking that we could set a max-age on the cache to slightly shorter than a CSRF token is valid for 🤔

Yes, that would be a good to experiment definetely. This will give flexibility as a whole. Future work or card?


Re-add wizden lobby music, and re-add some fire music wizden removed as well.

About the PR

See title, the music that I've re-added is monument and marhaba, some songs I really miss. Thus partially reverts https://github.com/space-wizards/space-station-14/pull/24480 though I didn't re-add vibe_ace because I agree it's forgettable and doesn't fit.
Why / Balance

Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

add: Re-added "wizden" lobby music (flip-flap, title3, singuloose, etc. (DID NOT REMOVE GOOB LOBBY MUSIC! JUST ADDED TO IT!)
add: Re-added marhaba and monument (lobby music removed from wizden in January)!

One sec, gotta add these to the Jukebox


docs are not loading

Bug, feature request, or proposal:
docs page is not working
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Same issue. I'd say about 75% of the time that I try to go to https://material.angular.io/ it doesn't load. I just see a white screen with console error that https://material.angular.io/main.af62af8dab0824d37bac.js could not load due to a 404.
Today I also got this warning:
DevTools failed to parse SourceMap: https://material.angular.io/ngsw_worker.es6.js.map

Try opening the dev tools in chrome, click on the application tab, then service workers, and check the bypass for network checkbox.

what about safari ?
error is :
Safari can’t open the page “https://material.angular.io/”. The error is: “FetchEvent.respondWith received an error: Error: Response not Ok (fetchAndCacheOnce): request for https://material.angular.io/index.html returned response 301 ” (WebKitServiceWorker:0)

Dup of https://github.com/angular/material2/issues/11745

It doesn't work on FireFox too.

Corrupted Content Error
The site at https://material.angular.io/components/checkbox/overview has experienced a network protocol violation that cannot be repaired.
The page you are trying to view cannot be shown because an error in the data transmission was detected.
Please contact the website owners to inform them of this problem.

i see a blank page 50% of the time, refresh does not help. then suddenly it starts working. then it starts returning again blank page
2main.af62af8dab0824d37bac.js:1 Failed to load resource: the server responded with a status of 404 ()
Xubuntu Linux Chrome Version 68.0.3440.106 (Official Build) (64-bit)

A new version has been deployed that should eliminate this problem.

The docs site has been unreachable for me now for a few days.
Here is the console output:
Uncaught (in promise) Error: Response not Ok (fetchAndCacheOnce): request for https://material.angular.io/index.html returned response 301
    at PrefetchAssetGroup.<anonymous> (ngsw-worker.js:576)
    at Generator.next (<anonymous>)
    at fulfilled (ngsw-worker.js:304)
(anonymous) @ ngsw-worker.js:576
fulfilled @ ngsw-worker.js:304
A bad HTTP response code (404) was received when fetching the script.
Failed to load resource: net::ERR_INVALID_RESPONSE

I can't clear the service worker or storage either because the site path is just ://

Still having the same issue as before. The page is just blank with the same 404 error.

You may have to clear the service worker one last time to get rid of your cached version.

how ? im using safari

@jelbourn I can't even do that. See these attached images of how it looks in chrome dev tools

Notice on the Clear Storage tab, the path is just "://"
I'm forced to use the incognito window to read the docs right now

Try using chrome://serviceworker-internals instead of the devtools

@jelbourn Thanks, that fixed it!

What PR fixed this? We have similar issues and looking for a solution..


Replace Moq with NSubstitute

I seems that Moq is now adware: https://github.com/moq/moq/issues/1372
It's necessary to move to NSubstitute.

Albert Monteiro has produced this repository with the required patterns to replace Moq with NSubstitute.
https://github.com/AlbertoMonteiro/moq-to-nsubstitute/tree/main
Bare in mind there are still some patterns missing (some of which have been raised as issues in the repo) so you may have to make adjustments depending on your usage of Moq.
I have also writtten the below tool which leverages these patterns to automatically replace instances of Moq with NSubstitute.
https://github.com/Creastoff/Moqstitute


add pagination to CLI tool

General Checkups

[ ] Have you checked that there aren't other open pull requests for the same issue/update/change?
[ ] If your code includes new features and not just bug fixes/copy editing: Did you include new tests?

Description

closes #97
Related Issue

Example

I removed pytest from the dev-requirements as this will be automatically added with pytest-cov. But for some reason Travis barfed on py3.6 when it was explicitly declared. This way the tests still run and pass :D

Fixed with #99


Port 80 in use

Hi there. Trying to install this on a Synology NAS and get the following error.
 Error response from daemon: driver failed programming external connectivity on endpoint magic_mirror (1f15ec0475348aa25175fa1c12f19e5306a2e6df810d37719574cc6fab0ae2bf): Error starting userland proxy: listen tcp <IP_ADDRESS>:80: bind: address already in use.
Very difficult to shift port 80 on the NAS. Is there a workaround?

Did you try changing --publish 80:8080 to some other port, like: --publish 3000:8080?

Thanks for the fast response. I did this --publish 9080:9080 \ and changed the .js file to this:
	var config = {
    address: "",
    port: 9080,
    ipWhitelist: []
}

if (typeof module !== "undefined") { module.exports = config; }

I use 8080 on my NAS for my UniFi controller.

I did test this myself and it worked on my end. Could you please compare your config files with mine?
// config.js

var config = {
  address: "",
  port: 9080,
  ipWhitelist: []
}

if (typeof module !== "undefined") { module.exports = config; }

# docker command

docker run  -d \
	--publish 9080:9080 \
	--restart always \
	--volume ~/Desktop/magic_mirror/config:/opt/magic_mirror/config \
	--volume ~/Desktop/magic_mirror/modules:/opt/magic_mirror/modules \
	--name magic_mirror \
	bastilimbach/docker-magicmirror

Could you try to adjust you config file and then remove the container with docker rm magic_mirror and run it again with the above command? Maybe somethings isn't working with docker restart.

Btw could you check, that port 9080 isn't used: netstat -an | grep 9080

Also please double check that you added the desired port to your Synology Firewall

Ah, didn't do the firewall as haven't needed to for any other container (MQTT, Home Assistant, UniFi). I tried your exact config and although there are no errors in the Docker log file, I can't access http://nasip:9080

tcp6       0      0 :::9080                 :::*                    LISTEN

NAS firewall is off

I stopped the container, removed it, modded the .js file with your code below then start a new container with port 9080 and still have no access.

With the Docker container removed, netstat reports no activity on 9080.

Midnight here in NZ so I'll pick this up tomorrow night. Thanks for your help. Very much appreciated, 👍

So the Error response from daemon [...] address already in use is gone right? I think I know where the issue comes from. Some users reported, that the ipWhitelist: [] option inside the config.js file doesn't allow all IPs. This is a bug with Magic Mirror. Could you please try adding this:
ipWhitelist: ["<IP_ADDRESS>", "::ffff:<IP_ADDRESS>", "::1", "<IP_ADDRESS>"]

This forum post might be interesting: ipWhitelist HowTo

Buggar. Was very hopeful that would work but sadly no.
var config = {
  address: "",
  port: 9080,
  ipWhitelist: ["<IP_ADDRESS>", "::ffff:<IP_ADDRESS>", "::1", "<IP_ADDRESS>"]
}

if (typeof module !== "undefined") { module.exports = config; }

	language: "en",
	timeFormat: 24,
	units: "metric",

This is the Synology Docker log which is odd as it's reporting the port as 8080.
018-07-23 11:53:58 | stdout | Ready to go! Please point your browser to: http://localhost:8080
-- | -- | --
2018-07-23 11:53:58 | stdout |
2018-07-23 11:53:58 | stdout | Sockets connected & modules started ...
2018-07-23 11:53:58 | stdout | Connecting socket for: updatenotification
2018-07-23 11:53:58 | stdout | Server started ...
2018-07-23 11:53:58 | stdout | Starting server on port 8080 ...
2018-07-23 11:53:58 | stdout | All module helpers loaded.
2018-07-23 11:53:58 | stdout | No helper found for module: helloworld.
2018-07-23 11:53:58 | stdout | Module helper loaded: updatenotification
2018-07-23 11:53:58 | stdout | Initializing new module helper ...
2018-07-23 11:53:58 | stdout | Loading module helpers ...
2018-07-23 11:53:58 | stderr | WARNING! Could not validate config file. Please correct syntax errors. Starting with default configuration.
2018-07-23 11:53:58 | stdout | Loading config ...
2018-07-23 11:53:58 | stdout | Starting MagicMirror: v2.4.1

Oh wait! Look:
2018-07-23 11:53:58 | stderr | WARNING! Could not validate config file. Please correct syntax errors. Starting with default configuration.

Could you post your whole config?

Just working on that now as just noticed that error too.

My apologies Sebastian, seems it was a syntax error. I did not notice that this code below was already at the bottom the of config file:
/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {module.exports = config;}

I now get this which is a step in the right direction.
This device is not allowed to access your mirror.
Please check your config.js or config.js.sample to change this.
Thank you!!

Changed ipWhitelist: [], // Set [] to allow all IP addresses and bam!

Thank you again for all your help. I think I'll pop up a blog post on that. Nite nite

😂 Nice. Unfortunately, I'm having to delay the blog post/YouTube video as I can't quite get the docker version of MM to play nicely with MMM-homeassistant-sensors or MMM-xiaomi. I had a similar issue with my Docker version of Hass.io when I installed the Node-Red add-on and the Xiaomi Node as the node could never 'see' my Xiaomi gateway.  The two aforementioned MM modules don't seem to be able to 'see' either my Xiaomi gateway or Home Assistant but MMM-HASS does work albeit intermittently and with not all sensor data being reported. As a lot of these modules have very limited success with posting issues, it is quite difficult to figure out where the problem lies.
I was hopeful that MM could become my ulimate HA wall mounted dashboard using a large tablet and a kiosk app to run the browser fullscreen but back to the drawing board. Without deep integration into either Xiaomi and/or Home Assistant, it is not that useful or wife friendly.
I'll spark up my 2yr old Pi based version of MM and update everything and see if that gives me more joy.
If you have any thoughts on my 'discovery' issue under Docker, let me know.

Are the services you try to connect with also running in Docker containers? If so you need to make sure, that you create a shared network which the desired containers use. https://docs.docker.com/network/bridge/#manage-a-user-defined-bridge

Thanks and apologies for the delay. I've built a Pi version and will try to get HA working in that first. I have the current container in bridge mode already.


Use of <IP_ADDRESS>/0

The default rules are listed with <IP_ADDRESS>/0 in the source or destination in some cases. The note says that this "represents all addresses", which is true, but it conflicts with the current display and behavior in the Portal. Looking at the default rules on an NSG I created, they all list "Any" in this location.
The major issue is that you cannot actually create rules by specifying the CIDR block <IP_ADDRESS>/0 in the current Portal - you get an error message stating that the block must be /1 to /32. Therefore, you need to choose "Any" as the source or destination instead of <IP_ADDRESS>/0.
This caused some confusion for a customer so I think it would be best to update the display here to fall in line with the GUI.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e905802-0b08-4b3b-25ec-0f88c023bc32
Version Independent ID: f31325e5-49ea-b28c-336e-10f2a3fc12b4
Content: Azure security groups overview
Content Source: articles/virtual-network/security-overview.md
Service: virtual-network
GitHub Login: @jimdial
Microsoft Alias: jdial

@malopMSFT Please address this one Mario and make any changes to the article, if necessary.  Thanks

Just created a PR including a note on this reference
https://github.com/MicrosoftDocs/azure-docs/pull/26113
#please-close


Performance degradation enabling shadowing in LWRP on Mac OS (Targeting Mac/Windows)

Describe the bug
Enabling shadowing in the LWRP asset, material and ocean renderer in editor, results in a framerate of between approximately 20-8 FPS on Mac OS.
Versions

Unity v2019.1.10f1
LWRP v5.16.1
Crest v1.8  - Jul 1 asset store release

To Reproduce

Create new LWRP project on Mac OS
Upgrade LWRP to v5.16.1
Import Crest from asset store
Open settings and navigation to graphics section. Set the render pipeline asset to the one found in the Crest/Crest-Examples/
Open Crest/Crest-Examples/Main/main scene
Add "Terrain" layer to user layers
Set the game object Island0 to use the "Terrain" layer
Enable shadowing in ocean-underwater material
In the ocean renderer game object, select: Create Shadow Data. This should already result in a performance drop in play mode (I got <20 FPS).
Enabling dynamic waves and flow simulations drops this even further.
Disabling shadowing and performing an editor restart even with the other features enabled results in a good frame rate at 1080p (~90FPS).

Platform

Editor
Platform:
- Mac OS Mojave (v10.14.5)
- RAM: 16 GB
- CPU: 2,6 GHz Intel Core i7
- Graphics: Metal, Radeon Pro 450 2 GB & Intel HD Graphics 530 1536 MB

Thanks, i think we were able to repro this. We'll update you with any progress.
It would be interesting to see the GPU profile from unity's profiler window to see where unity is attributing the time.

I have a Mac now, so will be looking into this at some point soon 😄

Thanks @moosichu! I unfortunately don't anymore, (it got stolen). I apologise that I wasn't able to provide more information.

Might be worth a retest with #464 merged in? NaNs coudl be generated without this fix which might make metal very unhappy.

Also, i'm hearing good things about 2019.3.9 and metal. Would be curious to know if that version improves this situation..

I quickly tested this and couldn't reproduce on my 2014 MacBook Pro. Shadows didn't appear to have noticeable performance cost. Adding Flow and Dynamic Waves did, but nowhere near as described here. Please reopen if you continue to experience this issue on latest Crest URP.


Create FAQ with most common questions in Industrial IoT

Anwering questions like:

•	cost and implementation timeline for retrofitting?
•	wireless sensors vs. wired sensors, why not using wireless?
•	which standards / protocols (e.g. OPC UA?) are recommended in terms of interoperability?
•	on premises vs. cloud vs. edge?
•	importance of scalability for production: number of machines (scalability in terms of data point of view and machine-machine communication) vs. number of people (not so important)?
•	how many industries are using MQTT and NodeRED?
•	influxDB vs. time scale DB? why using time scale DB?
•	trade-off use cases <> infrastructure: designing use cases <> collecting a lot of data… combination: think about important key use cases and data points and build architecture upfront, think about layout before full implementation

This should not be part of this repo


Mark forwarding parameters in the lexical scope

@kddnewton I need some help to push this over the line 🙇

FWIW I think this change is causing this failure:
https://github.com/ruby/prism/actions/runs/7718734483/job/21040616236
(given that the build in https://github.com/oracle/truffleruby/actions/runs/7717093994/job/21035403709 is fine)
I guess it's possible to workaround it (I haven't investigated yet), but just wanted to note it is kind of a breaking change (in case that part was not intended).
Before:
$ bin/parse -e 'def m(...); n(...); end'|grep locals
├── locals: []
            ├── locals: [:"..."]
            ├── locals_body_index: 1

After:
$ bin/parse -e 'def m(...); n(...); end'|grep locals
├── locals: []
            ├── locals: []
            ├── locals_body_index: 0


Calling the results callback multiple times resets keyboard selection

I have a use case where I want to return some data very fast, potentially from the network but not necessarily, and then do a more expensive query to return more data, or even progressively update the data over time. ie I want to be able to call the query.callback multiple times.
Another use case: say I have a chat selector for who is online, and the dropdown updates in real time as people come and go.
The callback works but if in the meantime I have made a keyboard selection, it is then reset when the new data comes in, even if the new data set still contains the result which was selected.
I've made a minimal test case here which just slowly updates the callback every 2 seconds with mostly overlapping data:
http://codepen.io/brendanheywood/pen/pvwZwK

[ ] What I'd expect is that if the current selected item is also present in the new result set then reselect it
[ ] Where the current item isn't in the new results set, a simple solution would be to reset the selection, but perhaps a slightly better process could be to walk 'up' through the old results until you find an item that is also in the new set, then select it

Also note that this bug crops up even in simpler user cases without multiple callbacks per query.
Lets say I type in a search for 'dog' slowly over a slow network and it does an ajax call after each keystroke. So we have 3 network requests in flight for '?q=d', '?q=do', and '?q=dog'.
Lets say the first 2 have arrived and I see the desired item 'dogmatic' a couple items down so I press down, down, down to select it, and then just before I press enter to choose it, the 3rd network request arrives, resets the dropdown and my selection, then I press enter and depending on what options were passed in I will have either chosen nothing, or some other random item instead of what I wanted.

Discussed more thoroughly in #4854.


added information about label sizes

Every carrier allows shipping labels to have different sizes. To make things even more complicated, the size can be different based on the service that's being used. Therefore we're now documenting,which label sizes are available for each carrier and the specific service.
We also added information and definitions about how you can define the label size when creating a shipping label through the shipcloud api.

ready to merge


[angle] Add CMake package with modules.

Please add an automatically generated CMake package with modules support to the ANGLE port.
Here is a fully functional example:
https://github.com/qis/angle-package/commit/d38c077495dd53b564d9fa94b5e67a127f3a0249
This allows users to include angle and link to it with only a few lines of code:
find_package(ANGLE REQUIRED)
target_link_libraries(${PROJECT_NAME} PRIVATE ANGLE::EGL ANGLE::GLESv2)
target_compile_definitions(${PROJECT_NAME} PRIVATE EGL_EGLEXT_PROTOTYPES=1 GL_GLEXT_PROTOTYPES=1)

It might be a good idea to add EGL_EGLEXT_PROTOTYPES and GL_GLEXT_PROTOTYPES to the ANGLE::EGL and ANGLE::GLESv2 targets as INTERFACE_COMPILE_DEFINITIONS entries.
Here is a repo I used to test it on x64-windows:
https://github.com/qis/angle-package-test

I've made a pull request for this issue. If anybody wishes me to change something, please comment either there, or here.
https://github.com/Microsoft/vcpkg/pull/2223

Thanks again!


Schema evolution error when denormalized and snake_case is enabled

I'm running into issues to load data with the denormalised parameter enabled.
Looking into the code, it seems that even when the table does not yet exists in BigQuery, we run into the following error:
google.api_core.exceptions.BadRequest: 400 PATCH https://bigquery.googleapis.com/bigquery/v2/projects/project-id/datasets/salesforce/tables/campaign?prettyPrint=false: Field id already exists in schema

The table schema is properly defined in BigQuery, but when it comes to load the actual data it looks like the table schema if not resolved correctly. The issue persists with both version 1 and 2 of the schema_resolver. Maybe there is an issue with the schema_translator?
If someone has Salesforce credentials, here is the corresponding Meltano configuration for reproducing the issue:
    plugins:

      extractors:
      - name: tap-salesforce
        config:
          api_type: REST
          start_date: '2023-06-01T00:00:00Z'
        select:
        - Campaign.*

      loaders:
      - name: target-bigquery
        variant: z3z1ma
        config:
          project: project-id
          dataset: salesforce
          method: batch_job
          location: us-west1
          batch_size: 500
          fail_fast: True
          append: False
          overwrite: True
          flattening_enabled: True
          denormalized: True
          schema_resolver_version: 2
          column_name_transforms:
            lower: True
            quote: False
            add_underscore_when_invalid: True
            snake_case: True

And the meltano commands:
meltano --log-level=debug invoke tap-salesforce > output.json
cat output.json | meltano --log-level=debug invoke target-bigquery

Alright so it looks like in my specific case the issue is caused because the [mut_schema](https://github.com/z3z1ma/target-bigquery/blob/faddcfc12be9e1929cdd4816869e229c56431dff/target_bigquery/core.py#L559) being a concatenation of non-transformed columns + metadata columns + transformed columns.
To generalise, that issue will happen when both denormalized = True and snake_case = True in situations where tap output contains any camel case single-world column name.
What happens is that we get the non transformed table schema, then check in the transformed table schema if any field is new: if input is camel case, all transformed fields are new.
For double word column names, an underscore is introduced so we'll just end up having a duplicated column (e.,g. StartDate -> start_date).
For any single world column though, BigQuery will consider the fields appears twice in the schema provided to update the table (e.g. Id -> id).
That's when we end up with the following error, regardless of the sink since the Denormalized.update_schema method overwrites the update_schema implementation of all of the 4 sinks:
google.api_core.exceptions.BadRequest: 400 PATCH https://bigquery.googleapis.com/bigquery/v2/projects/project/datasets/salesforce/tables/campaign?prettyPrint=false: Field id already exists in schema

I am experiencing the same issue.
The Denormlized class calls table.as_table(). Would a solution be to replace this line with:
table = self.table._table
Which is the actual schema in the BiqQuery table and retreived and returned by [create_table] method (https://github.com/z3z1ma/target-bigquery/blob/faddcfc12be9e1929cdd4816869e229c56431dff/target_bigquery/core.py#L195).
Or
table = self.table.as_table(self.apply_transforms)


Can't install library dependencies via npm

It looks like brix/grunt-jsxcs disappeared.
 $ npm install .
npm WARN deprecated<EMAIL_ADDRESS>react-tools is deprecated. For more information, visit https://fb.me/react-tools-deprecated
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004: Cloning into bare repository '/Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004'...
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004: fatal: remote error:
npm ERR! git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004:   Repository not found.
npm ERR! Darwin 15.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "."
npm ERR! node v0.12.7
npm ERR! npm  v2.12.1
npm ERR! code 128

npm ERR! Command failed: git clone --template=/Users/dragos/.npm/_git-remotes/_templates --mirror git://github.com/brix/grunt-jsxcs.git /Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004
npm ERR! Cloning into bare repository '/Users/dragos/.npm/_git-remotes/git-github-com-brix-grunt-jsxcs-git-4a077004'...
npm ERR! fatal: remote error:
npm ERR!   Repository not found.
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/dragos/workspace/Spark/spark-pr-dashboard/npm-debug.log

Looks like the build has been broken since January 28 due to this issue.

Maybe the package got moved here?

I think those are different packages. One is for jsx, the React.js dialect of XML, vs. jscs which is a stye checker for Javascript. I may be wrong though, I'm new to the js ecosystem.

Oh sorry, you're right.

I looked at this a few month ago when I checked out the code to play with and couldn't find any evidence of brix/grunt-jsxcs available, it seems it was just deleted and not replaced.
Based on some quick research just now though it seems that jscs added jsx support, so we should be able to switch.

I don't have time to fix this myself but will be happy to review any pull requests that port the build to newer JS tools.


[FIXED] Check for negative Offset and/or Limit when processing Connz

[X] Link to issue
[X] Documentation added (if applicable)
[X] Tests added
[X] Branch rebased on top of current master (git pull --rebase origin master)
[X] Changes squashed to a single commit (described here)
[X] Build is green in Travis CI
[X] You have certified that the contribution is your original work and that you license the work to the project under the MIT license

Resolves #491
Changes proposed in this pull request:
Ensure that if the offset is negative, it is set to 0. If the limit
is negative, it is set to the default value.
/cc @nats-io/core

Coverage decreased (-0.2%) to 90.944% when pulling a87050c5469516ca5680af200eb1e5fdffdd562d on fix_negative_offset_limit_panic into 01d2f1d12c4ca99270d95e3b65ac521273e49300 on master.

lgtm


Update auto-generated ApplicationUser.cs

Upgrading from ASP.NET Core 1.1.2 to 2.0, I followed this guide for migrating authentication and identity. One of the missing pieces that it does not cover is that the ApplicationUser model needs to use Microsoft.AspNetCore.Identity and not Microsoft.AspNetCore.Identity.EntityFrameworkCore - without this change, the project won't build.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f4b263b-e8f9-8b44-8c13-5bc0128fb1c9
Version Independent ID: 985774b6-a165-f22c-c354-6c12a6783063
Content: Migrate authentication and Identity to ASP.NET Core 2.0
Content Source: aspnetcore/migration/1x-to-2x/identity-2x.md
Product: aspnet-core
GitHub Login: @scottaddie
Microsoft Alias: scaddie

@karlbaker02  that sounds right.

@karlbaker02  any chance you could create a PR to address this?


Resource with specified id, name, or unique index already exists

Expected behavior
Collections are created without an error
Actual behavior
Initial creation of collections can cause the following error
Message: {"Errors":["Resource with specified id, name, or unique index already exists."]}
Steps to reproduce the problem
If the solution is already deployed then delete the Customers, SecureScore and Subscriptions collections. Then remove the LastProcessed timestamp from the environment. When the PullEnvironments function is invoked it will generate the error.
This is not a blocking issue because the messages are retried, and the collections are eventually created.

There was the possibility of a race condition when initializing the data repositories. This issue has been fixed with PR #14.


3dSprite invisible in editor/game if not rotated & billboard y still broken

3DSprites behave strangely . They seem to be invisible by default until you rotate it 90 degrees then they become visible. editor only!
Billboard fix y property still broken both in code and in the editor interface.
Also I get strange octant face null issues if  try to translate a 3DSprite (with billboard property on?).
When 2 or more 3DSprites with same dimensions and billboard on are at the same position (ye on top of one another) the draw Z order is based on the order in the node list. However! When the game begins the top most sprite is drawn then only after 2 second delay all other sprites are drawn as well. It seems like the visual engine rushes to draw the scene but forgets to draw ALL the billboard sprites save the top most one right away. it may be same without billboard.
See #1366 & #2061

not much more work will be done on 3D engine, as it will be rewritten this year

i understand for now i implemented my own billboard y is no biggie just making devs aware this is happening

also this is 2 issues in 1 probably needs to be split in 2 issues

billboard was rewritten so this is obsolete


graphql_subscription_with_data initializer errors are not logged by tracing extension

I just ran into an issue where a graphql_subscription_with_data initializer was resulting in an error but it was not visible in my tracing logs. It would be helpful in these scenarios to surface the initializer error to the logs.

Errors that occur during WebSocket initialization are currently returned through websocket. Because this is not a query, it is not possible to call Extension to output errors.

Hmm, ok. Yeah indescrimenently exposing errors through the websocket could give an attacker information. If I roll my own error filtering in the websocket this works. Longer term it would be nicer to have it handled with good defaults by some kind of integration (eg. Relay all errors to the user in development but only explicitly user facing errors in production - with logging for the errors that are hidden from users).

Maybe you can judge the role of the current user in the data_initializer function to decide whether to hide the real error message.

In my server it's less user-specific and more dev/production specific. I'd like to improve errors and logs out of the box but I don't have a concrete suggestion at the moment so I'll close this for now.


Render terrain skirts when casting shadows

I'm fine with this for now, I updated the roadmap with the issues we were facing with skirts.


Convert 2021-12-01-preview into stable version 2022-01-01 (no new API)

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

This pr is to add new version 2021-12-01 based on 2021-12-01-preview for Terraform release only

Hi @xiaoxuqi-ms, please fix the required CI failures following the comments: https://github.com/Azure/azure-rest-api-specs/pull/23426#issuecomment-1495496757

/azp run

Approving breaking changes as all are to address errors/omissions from the REST API definition and not service behavior changes.

Approved

@Azure/arm-api-review-board The service team has asked to expedite this PR. Could the on-call please review and approve or provide feedback?

Thanks for sharing and helping me with this. I'm approving these please.

TF release requires a stable version, so we convert 2021-12-01-preview to 2022-01-01 for TF release only. There are still some linter issues but we are not fixing these for the following reasons:

to update status codes need backend to support, but we will not touch 2021-12-01 backend, it will be a tremendous breaking change.
2021-12-01/2022-01-01 is an old version, we are working on new version for now. So these linter issues might be fixed in  a new version.

the prettier check fails due to new constraint pattern of Database name.

and Mysql supports both single server and flexible server, so we need multi default in readme. this Avocado error is not brought by this pr.

@josefree , this pr has CI failure, but the author provides reasons, mainly because they are changing an old preview version to stable, and they don't want to change the old version service, they will fix the failures in new version. Could you please advice if this is acceptable to merge? Thanks!

@josefree , this pr has CI failure, but the author provides reasons, mainly because they are changing an old preview version to stable, and they don't want to change the old version service, they will fix the failures in new version. Could you please advice if this is acceptable to merge? Thanks!

Based on Mike's approval on breaking change and Xiaoxu's statement, I think we can accept to merge this PR.  Thanks.