Regression for WPF projects in 2.0.24

Using Visual Studio 2019 RTM, .NET Core SDK 2.2.202.
WPF applications / libraries no longer build with the newly released 2.0.24.
I'm pretty sure this is because this line forces ExtrasUseWindowsDesktopApp to be true unconditionally when we opt-in to WPF stuff, even though true is exactly the value that turns off pretty much all the WPF setup that Extras does.
Here's a more-or-less minimal repro, note what happens when switching 1.6.68 to 2.0.24:
WpfApp.csproj
<Project Sdk="MSBuild.Sdk.Extras/1.6.68">

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net472</TargetFramework>
    <ExtrasEnableWpfProjectSetup>true</ExtrasEnableWpfProjectSetup>
  </PropertyGroup>

</Project>

App.xaml
<Application x:Class="WpfApp1.App"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             StartupUri="MainWindow.xaml" />

MainWindow.xaml
<Window x:Class="WpfApp1.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        Title="An Extra Special Title"
        Height="450"
        Width="800">
    <TextBlock HorizontalAlignment="Center"
               VerticalAlignment="Center"
               Text="Hello Extras!" />
</Window>

The error I get:
error CS5001: Program does not contain a static 'Main' method suitable for an entry point

With a less minimal repro, we get things like:
error CS1061: 'App' does not contain a definition for 'InitializeComponent' and no accessible extension method 'InitializeComponent' accepting a first argument of type 'App' could be found (are you missing a using directive or an assembly reference?)
And so on...

Can you share a binlog? compile with /binlog?
That line does not control things, it simply removes a FrameworkReference.
The decision on wether to use the .NET Core 3 version of the targets vs the built-in one is here:
https://github.com/onovotny/MSBuildSdkExtras/blob/master/Source/MSBuild.Sdk.Extras/Sdk/Sdk.props#L23

WpfApp1.zip includes msbuild.binlog, built from the below command-line:
C:\Projects\Generic\WpfApp1>msbuild WpfApp1.sln /t:Restore;Build /bl
Microsoft (R) Build Engine version 16.0.461+g6ff56ef63c for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\msbuild.exe /bl /t:Restore;Build WpfApp1.sln
Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
Build started 4/3/2019 12:02:14 PM.
Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" on node 1 (Restore;Build target(s)).
ValidateSolutionConfiguration:
  Building solution configuration "Debug|Any CPU".
Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" (1) is building "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (2) on node 1 (_IsProjectRestoreSupported target(s)).
C:\Users\jamenta\.nuget\packages\msbuild.sdk.extras\2.0.24\Build\ExtrasShim.targets(49,5): warning : The property 'ExtrasEnableWpfProjectSetup' is deprecated and will be removed in the future. Please use 'UseWpf'
 instead. [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]
Done Building Project "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (_IsProjectRestoreSupported target(s)).

Restore:
  Restoring packages for C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj...
  Committing restore...
  Generating MSBuild file C:\Projects\Generic\WpfApp1\WpfApp1\obj\WpfApp1.csproj.nuget.g.props.
  Generating MSBuild file C:\Projects\Generic\WpfApp1\WpfApp1\obj\WpfApp1.csproj.nuget.g.targets.
  Writing assets file to disk. Path: C:\Projects\Generic\WpfApp1\WpfApp1\obj\project.assets.json
  Restore completed in 235.55 ms for C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj.

  NuGet Config files used:
      C:\Users\jamenta\AppData\Roaming\NuGet\NuGet.Config
      C:\Program Files (x86)\NuGet\Config\Microsoft.VisualStudio.Offline.config

  Feeds used:
      https://api.nuget.org/v3/index.json
      C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\
Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" (1) is building "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (2:6) on node 1 (default targets).
C:\Users\jamenta\.nuget\packages\msbuild.sdk.extras\2.0.24\Build\ExtrasShim.targets(49,5): warning : The property 'ExtrasEnableWpfProjectSetup' is deprecated and will be removed in the future. Please use 'UseWpf'
 instead. [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]
PrepareForBuild:
  Creating directory "bin\Debug\net472\".
  Creating directory "obj\Debug\net472\".
GenerateBindingRedirects:
  No suggested binding redirects from ResolveAssemblyReferences.
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
  C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn\csc.exe /noconfig /unsafe- /checked- /nowarn:1701,1702,1701,1702 /nostdlib+ /platform:AnyCPU /errorreport:prompt /warn:4 /define:TRACE;
  DEBUG;NETFRAMEWORK;NET472 /highentropyva+ /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\M
  icrosoft\Framework\.NETFramework\v4.7.2\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Data.dll" /reference:"C:\Program Files (x86)\Refe
  rence Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Drawing.dll" /reference:"C:\Program
  Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.IO.Compression.FileSystem.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\S
  ystem.Numerics.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Runtime.Serialization.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Mic
  rosoft\Framework\.NETFramework\v4.7.2\System.Xml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Xml.Linq.dll" /debug+ /debug:portable /filealign:512
   /optimize- /out:obj\Debug\net472\WpfApp1.exe /ruleset:"C:\Apps\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\\Rule Sets\MinimumRecommendedRules.ruleset" /subsystemversion:6.00 /targe
  t:winexe /warnaserror- /utf8output /deterministic+ obj\Debug\net472\WpfApp1.AssemblyInfo.cs /warnaserror+:NU1605
  Using shared compilation with compiler from directory: C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn
CSC : error CS5001: Program does not contain a static 'Main' method suitable for an entry point [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]
Done Building Project "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (default targets) -- FAILED.

Done Building Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" (Restore;Build target(s)) -- FAILED.

Deferred Messages

  Detailed Build Summary
  ======================

  ============================== Build Hierarchy (IDs represent configurations) =====================================================
  Id                  : Exclusive Time   Total Time   Path (Targets)
  -----------------------------------------------------------------------------------------------------------------------------------
  0                   : 0.835s           1.935s       C:\Projects\Generic\WpfApp1\WpfApp1.sln (Restore, Build)
  | 1                 : 0.389s           0.389s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_IsProjectRestoreSupported)
  | 2                 : 0.012s           0.012s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateRestoreProjectPathWalk)
  | 3                 : 0.058s           0.058s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateRestoreGraphProjectEntry)
  | 4                 : 0.025s           0.025s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateProjectRestoreGraph)
  . 5                 : 0.614s           0.614s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj ()

  ============================== Node Utilization (IDs represent configurations) ====================================================
  Timestamp:            1        Duration   Cumulative
  -----------------------------------------------------------------------------------------------------------------------------------
<PHONE_NUMBER>47281249:   0        0.308s     0.308s ######
<PHONE_NUMBER>50361274:   1        0.389s     0.697s #######
<PHONE_NUMBER>54251302:   0        0.018s     0.715s
<PHONE_NUMBER>54431292:   2        0.012s     0.727s
<PHONE_NUMBER>54551285:   0        0.005s     0.732s
<PHONE_NUMBER>54601293:   3        0.058s     0.791s #
<PHONE_NUMBER>55186270:   0        0.002s     0.792s
<PHONE_NUMBER>55201288:   4        0.025s     0.817s
<PHONE_NUMBER>55451288:   0        0.503s     1.320s ##########
<PHONE_NUMBER>60476335:   5        0.614s     1.933s ############
<PHONE_NUMBER>66611433:   0        0.006s     1.940s
  -----------------------------------------------------------------------------------------------------------------------------------
  Utilization:          100.0    Average Utilization: 100.0

Build FAILED.

"C:\Projects\Generic\WpfApp1\WpfApp1.sln" (Restore;Build target) (1) ->
"C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (_IsProjectRestoreSupported target) (2) ->
(_WarnWhenUsingObsoleteProperties target) ->
  C:\Users\jamenta\.nuget\packages\msbuild.sdk.extras\2.0.24\Build\ExtrasShim.targets(49,5): warning : The property 'ExtrasEnableWpfProjectSetup' is deprecated and will be removed in the future. Please use 'UseWp
f' instead. [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]

"C:\Projects\Generic\WpfApp1\WpfApp1.sln" (Restore;Build target) (1) ->
"C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (default target) (2:6) ->
  C:\Users\jamenta\.nuget\packages\msbuild.sdk.extras\2.0.24\Build\ExtrasShim.targets(49,5): warning : The property 'ExtrasEnableWpfProjectSetup' is deprecated and will be removed in the future. Please use 'UseWp
f' instead. [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]

"C:\Projects\Generic\WpfApp1\WpfApp1.sln" (Restore;Build target) (1) ->
"C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (default target) (2:6) ->
(CoreCompile target) ->
  CSC : error CS5001: Program does not contain a static 'Main' method suitable for an entry point [C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj]

    2 Warning(s)
    1 Error(s)

Time Elapsed 00:00:02.39

For completeness, here it is on success with 1.6.68: WpfApp1.zip
C:\Projects\Generic\WpfApp1>msbuild WpfApp1.sln /t:Restore;Build /bl
Microsoft (R) Build Engine version 16.0.461+g6ff56ef63c for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\msbuild.exe /bl /t:Restore;Build WpfApp1.sln
Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
Build started 4/3/2019 12:12:16 PM.
Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" on node 1 (Restore;Build target(s)).
ValidateSolutionConfiguration:
  Building solution configuration "Debug|Any CPU".
Restore:
  Restoring packages for C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj...
  Committing restore...
  Generating MSBuild file C:\Projects\Generic\WpfApp1\WpfApp1\obj\WpfApp1.csproj.nuget.g.props.
  Generating MSBuild file C:\Projects\Generic\WpfApp1\WpfApp1\obj\WpfApp1.csproj.nuget.g.targets.
  Writing assets file to disk. Path: C:\Projects\Generic\WpfApp1\WpfApp1\obj\project.assets.json
  Restore completed in 279.33 ms for C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj.

  NuGet Config files used:
      C:\Users\jamenta\AppData\Roaming\NuGet\NuGet.Config
      C:\Program Files (x86)\NuGet\Config\Microsoft.VisualStudio.Offline.config

  Feeds used:
      https://api.nuget.org/v3/index.json
      C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\
Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" (1) is building "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (2:6) on node 1 (default targets).
PrepareForBuild:
  Creating directory "bin\Debug\net472\".
  Creating directory "obj\Debug\net472\".
GenerateBindingRedirects:
  No suggested binding redirects from ResolveAssemblyReferences.
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
  C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn\csc.exe /noconfig /unsafe- /checked- /nowarn:1701,1702,1701,1702 /nostdlib+ /platform:AnyCPU /errorreport:prompt /warn:4 /define:TRACE;
  DEBUG;NETFRAMEWORK;NET472 /highentropyva+ /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\M
  icrosoft\Framework\.NETFramework\v4.7.2\PresentationCore.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\PresentationFramework.dll" /reference:"C:\Program F
  iles (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Data.dll" /refer
  ence:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Dra
  wing.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.IO.Compression.FileSystem.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft
  \Framework\.NETFramework\v4.7.2\System.Numerics.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Runtime.Serialization.dll" /reference:"C:\Program Fil
  es (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Xaml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Xml.dll" /referenc
  e:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.Xml.Linq.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\Wind
  owsBase.dll" /debug+ /debug:portable /filealign:512 /optimize- /out:obj\Debug\net472\WpfApp1.exe /ruleset:"C:\Apps\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\\Rule Sets\MinimumReco
  mmendedRules.ruleset" /subsystemversion:6.00 /resource:obj\Debug\net472\WpfApp1.g.resources /target:winexe /warnaserror- /utf8output /deterministic+ C:\Projects\Generic\WpfApp1\WpfApp1\obj\Debug\net472\MainWind
  ow.g.cs C:\Projects\Generic\WpfApp1\WpfApp1\obj\Debug\net472\App.g.cs "C:\Projects\Temp\.NETFramework,Version=v4.7.2.AssemblyAttributes.cs" obj\Debug\net472\WpfApp1.AssemblyInfo.cs /warnaserror+:NU1605
  Using shared compilation with compiler from directory: C:\Apps\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn
_CopyAppConfigFile:
  Copying file from "C:\Projects\Generic\WpfApp1\WpfApp1\obj\Debug\net472\WpfApp1.exe.withSupportedRuntime.config" to "C:\Projects\Generic\WpfApp1\WpfApp1\bin\Debug\net472\WpfApp1.exe.config".
CopyFilesToOutputDirectory:
  Copying file from "C:\Projects\Generic\WpfApp1\WpfApp1\obj\Debug\net472\WpfApp1.exe" to "C:\Projects\Generic\WpfApp1\WpfApp1\bin\Debug\net472\WpfApp1.exe".
  WpfApp1 -> C:\Projects\Generic\WpfApp1\WpfApp1\bin\Debug\net472\WpfApp1.exe
  Copying file from "C:\Projects\Generic\WpfApp1\WpfApp1\obj\Debug\net472\WpfApp1.pdb" to "C:\Projects\Generic\WpfApp1\WpfApp1\bin\Debug\net472\WpfApp1.pdb".
Done Building Project "C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj" (default targets).

Done Building Project "C:\Projects\Generic\WpfApp1\WpfApp1.sln" (Restore;Build target(s)).

Deferred Messages

  Detailed Build Summary
  ======================

  ============================== Build Hierarchy (IDs represent configurations) =====================================================
  Id                  : Exclusive Time   Total Time   Path (Targets)
  -----------------------------------------------------------------------------------------------------------------------------------
  0                   : 0.859s           6.234s       C:\Projects\Generic\WpfApp1\WpfApp1.sln (Restore, Build)
  | 1                 : 0.393s           0.393s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_IsProjectRestoreSupported)
  | 2                 : 0.012s           0.012s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateRestoreProjectPathWalk)
  | 3                 : 0.052s           0.052s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateRestoreGraphProjectEntry)
  | 4                 : 0.026s           0.026s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj (_GenerateProjectRestoreGraph)
  . 5                 : 4.890s           4.890s       C:\Projects\Generic\WpfApp1\WpfApp1\WpfApp1.csproj ()

  ============================== Node Utilization (IDs represent configurations) ====================================================
  Timestamp:            1        Duration   Cumulative
  -----------------------------------------------------------------------------------------------------------------------------------
<PHONE_NUMBER>64569885:   0        0.295s     0.295s #####
<PHONE_NUMBER>67519676:   1        0.393s     0.688s #######
<PHONE_NUMBER>71449480:   0        0.017s     0.705s
<PHONE_NUMBER>71619329:   2        0.012s     0.717s
<PHONE_NUMBER>71739367:   0        0.005s     0.721s
<PHONE_NUMBER>71784369:   3        0.052s     0.773s #
<PHONE_NUMBER>72304737:   0        0.001s     0.775s
<PHONE_NUMBER>72319378:   4        0.026s     0.801s
<PHONE_NUMBER>72579329:   0        0.545s     1.345s ##########
<PHONE_NUMBER>78024365:   5        4.890s     6.236s #################################################################################################
<PHONE_NUMBER>26925466:   0        0.005s     6.240s
  -----------------------------------------------------------------------------------------------------------------------------------
  Utilization:          100.0    Average Utilization: 100.0

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.69

Thanks. I'll have a look and see what broke as this scenario is supposed to work.
As a workaround/better-scenario anyway, I'd suggest installing the .NET Core 3 SDK (currently at preview 3) and adding a global.json like this:
{
  "sdk": {
    "version": "3.0.100-preview3"
  },
  "msbuild-sdks": {
    "MSBuild.Sdk.Extras": "2.0.24"
  }
}

This will use the updated targets/tasks in the Core 3 SDK for building (you can still target .NET 4.x) and will unblock you.

FWIW, commenting-out the line that I linked in my local .nuget cache of that file is enough to make the minimal repro build and run just fine.

As a workaround/better-scenario anyway, I'd suggest installing the .NET Core 3 SDK (currently at preview 3, https://dotnet.microsoft.com/download/dotnet-core/3.0) and adding a global.json like this:

Thanks -- I've been waiting until General Availability to try it out because even GA releases have been a bit on the bumpy side.

Thanks -- I've been waiting until General Availability to try it out because even GA releases have been a bit on the bumpy side.

If you use the Visual Studio stable channel, it won't automatically pickup & use preview SDK's by default. It'll default to the latest stable one. That's why you need the global.json, to tell it to use the preview sdk.
The visual studio preview channel will use preview sdk's by default.

I made a manual patch for our projects via a Directory.Build.targets containing:
  <ItemGroup Condition=" '$(UseWpf)' == 'true' AND '$(VisualStudioVersion)' == '16.0'">
      <None Remove="**\*.xaml" />
      <Page Remove="**\*.xaml" />
      <Page Include="**\*.xaml">
          <Generator>MSBuild:Compile</Generator>
      </Page>
      <Page Remove="**\App.xaml" />
      <ApplicationDefinition Include="**\App.xaml" />
      <Reference Include="System.Xaml" />
  </ItemGroup>

It seems VS2019 has some fixes in place regarding the xaml -> cs generation that are now handled wrong/duplicated in the MSBuildSdkExtras compared to VS2017 where it was working fine. For us this works fine even if it might not be 100% correct for all setups. I hope this helps others until a real fix can be provided.

Thanks. I'll have a look and see what broke as this scenario is supposed to work.
As a workaround/better-scenario anyway, I'd suggest installing the .NET Core 3 SDK (currently at preview 3, https://dotnet.microsoft.com/download/dotnet-core/3.0) and adding a global.json like this:
{
  "sdk": {
    "version": "3.0.100-preview3"
  },
  "msbuild-sdks": {
    "MSBuild.Sdk.Extras": "2.0.24"
  }
}

This will use the updated targets/tasks in the Core 3 SDK for building (you can still target .NET 4.x) and will unblock you.

Is there any workaround for this issue that will allow some developers to adopt VS2019 and some to stay on VS2017? Some of us would like to test out VS2019 without forcing the whole team to move.

Is there any workaround for this issue that will allow some developers to adopt VS2019 and some to stay on VS2017? Some of us would like to test out VS2019 without forcing the whole team to move.

The solution from Danielku15 worked for me.
In the global.json upgrade to MSBuild.Sdk.Extras version 2.0.24
{
  "sdk": {
    "version": "2.2.104"
  },
  "msbuild-sdks": {
    "MSBuild.Sdk.Extras": "2.0.24"
  }
}

Now we gotta make some adjustments to the csproj file.
Change ExtrasEnableWpfProjectSetup to UseWpf and also set ExtrasEnableImplicitWpfReferences to false (I had errors that the WPF assemblies were not referenced)
<PropertyGroup>
  <UseWpf>true</UseWpf>
  <ExtrasEnableImplicitWpfReferences>false</ExtrasEnableImplicitWpfReferences>
</PropertyGroup>

Next step, add the WPF assembly references:
<ItemGroup>
  <Reference Include="PresentationCore" />
  <Reference Include="PresentationFramework" />
  <Reference Include="System.Xaml" />
  <Reference Include="WindowsBase" />
</ItemGroup>

And then, add Danielku15's fix (but without the Condition for the VisualStudioVersion)
<ItemGroup Condition=" '$(UseWpf)' == 'true' ">
    <None Remove="**\*.xaml" />
    <Page Remove="**\*.xaml" />
    <Page Include="**\*.xaml">
        <Generator>MSBuild:Compile</Generator>
    </Page>
    <Page Remove="**\App.xaml" />
    <ApplicationDefinition Include="**\App.xaml" />
    <Reference Include="System.Xaml" />
</ItemGroup>

Now my application builds fine in VS2017 and VS2019 :smile:

Closing due to age. If there's a concrete issue that needs to be addressed in VS 2019 with the .NET Core 3 sdk, please reopen.


Is there possibility to change value for helping bike during walking?

Bike walking support is really slow and i would like to double it. Is there parameter for it? I couldn't find info related to that.

Its not supported in release, but added in one of dev branches. I just have to test it and add to new release

Great work. Thank you

Hello. I published new release with parameter for walk mode speed

Thank you for letting me know. I will try soon.

Hi, i tested latest app. Even though it looks like it wrote parameters correctly into engine, the behavior is as before. When i read data i have the values i set. I didn't see option for walking assistant so i changed size of wheels from 29" to 14" and that doesn't have any impact for walking assistantce. After change i still see in display from bike that wheel size is 29"

Then i likely set 16" not 14"

Then i likely set 16" not 14"

Please show me screenshot

Hmm not possible right now. But it doesn't matter as behavior didn't change and set request passed all green

FYI: Today i was on bike. It looks the calculation staied with my original wheel size, but it was helping me whole time even i crossed the speed limit. Although i wanted achieve something else, today it helped me as i was lacking in time.


Run task after devcontainer is up and running

Currently in task definition it is possible to configure that task will start when folder is open("runOn": "folderOpen"). But the problem is if you have a dev container, it hadn't started yet. So you end up with task being executed locally, and not in container.
It will be great to have a run option for a task: "when dev container is up". Or in devcontainer.json have possibility to list tasks that needs to be started.

/verified


container crashes when TYPE=AUTO_CURSEFORGE

Describe the problem
Starting a container with TYPE=AUTO_CURSEFORGE crashes with the error message unable to find jarfile, setting SETUP_ONLY shows SETUP_ONLY: java -Xmx4G -Xms4G -jar (note the missing argument after -jar). Am I missing something or is this a bug?
After digging around a bit I think the problem is within mc-image-helper itself. If I understand correctly mc-image-helper install-curseforge "${args[@]}" should populate /data/.install-curseforge.env with the SERVER and TYPE variables, but the content is (
MODPACK_NAME="All the Mods 10"
MODPACK_VERSION="0.12"
... (these two lines are repeated like 50 times)

Unfortunately I currently cannot use docker on my mac because it crashes all the time after the last update so my ability to manually edit files in the container is limited, also repeatedly deleting all data and redownload it from curseforge quickly exhausts the rate limits, is there a known workaround for this, it would make debugging easier because I could always start from a clean state?
Container definition
apiVersion: v1
kind: Pod
metadata:
  name: atm-minecraft-0
spec:
  containers:
    - name: atm-minecraft
      image: itzg/minecraft-server:2024.6.1-java21-graalvm
      env:
        - name: EULA
          value: 'TRUE'
        - name: TYPE
          value: AUTO_CURSEFORGE
        - name: VERSION
          value: '1.21'
        - name: DIFFICULTY
          value: easy
        - name: MAX_PLAYERS
          value: '20'
        - name: MAX_WORLD_SIZE
          value: '10000'
        - name: MAX_BUILD_HEIGHT
          value: '256'
        - name: MAX_TICK_TIME
          value: '60000'
        - name: SPAWN_PROTECTION
          value: '16'
        - name: VIEW_DISTANCE
          value: '20'
        - name: MODE
          value: survival
        - name: MOTD
          value: Welcome to Minecraft on Kubernetes!
        - name: LEVEL_TYPE
          value: DEFAULT
        - name: LEVEL
          value: world
        - name: MODRINTH_ALLOWED_VERSION_TYPE
          value: release
        - name: MEMORY
          value: 4G
        - name: OVERRIDE_SERVER_PROPERTIES
          value: 'true'
        - name: CF_API_KEY
          valueFrom:
            secretKeyRef:
              name: cf-api-key
              key: cf-api-key
        - name: CF_SLUG
          value: all-the-mods-10
        - name: CF_PARALLEL_DOWNLOADS
          value: '4'
        - name: SETUP_ONLY
          value: 'true'

Container logs
[init] Running as uid=1000 gid=3000 with /data as 'drwxrwsr-x 9 0 2000 4096 Jul 14 17:14 /data'
[mc-image-helper] 17:14:19.445 INFO  : Requested CurseForge modpack All the Mods 10-0.12 is already installed for All the Mods 10 - ATM10
[init] Setting mode
[init] Setting initial memory to 4G and max to 4G
[init] Starting the Minecraft server...
SETUP_ONLY: java -Xmx4G -Xms4G -jar

You can debug the pod's content like any other container, change the entrypoint/command to something like the following
          command:
            - bash
            - -c
            - "sleep 999999"

and then you can exec a new shell inside the pod while the entrypoint is sleeping.

BTW, the .install-curseforge.env should contain the following:
SERVER="/data/./run.sh"
FAMILY="FORGE"
VERSION="1.21"
TYPE="NEOFORGE"
MODPACK_NAME="All the Mods 10"
MODPACK_VERSION="0.12"

As such, my setup line looks like:
mc-1  | [init] Using Forge supplied run.sh script...
mc-1  | SETUP_ONLY: bash /data/./run.sh

I'll cut a new fixed released tag since it looks like I haven't done that in a little while.

also repeatedly deleting all data and redownload it from curseforge quickly exhausts the rate limits

I don't see a persistent volume attached to /data. That would explain why data is getting "deleted" repeatedly. Under normal circumstances the CurseForge effectively caches the resulting jar files since they're already downloaded.

New image release is itzg/minecraft-server:2024.7.0-java21-graalvm

also repeatedly deleting all data and redownload it from curseforge quickly exhausts the rate limits

I don't see a persistent volume attached to /data. That would explain why data is getting "deleted" repeatedly. Under normal circumstances the CurseForge effectively caches the resulting jar files since they're already downloaded.

I ommitted the volume and volumeMounts for brevity, but the caching does indeed work.
Anyways, updating the image works, thank you very much for the fast fix.


Remove tuweni junit

PR Description
Remove tuweni-junit module and its usage
Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Seems reasonable. It appears that those BouncyCastleExtension is not actually needed. Maybe @rolfyone remembers the background...


[Proposal] make backup operator and restore operator controller like the operator

Currently, etcd-operator is structed differently with backup and restore operator.
Etcd-operator: Watch for etcdcluster CRD. And spin a control loop for each etcdCluster instance.
Backup/Restore operators: Watch for etcdbackup/etcdrestore CRD, Add the event to work queue. Process the work queue one by one.
The difference is, for each etcdCluster instance, there is a loop monitoring and reconciling for it. No loop for etcdbackup/etcdrestore instance.
We do have needs to have a control loop for every backup/restore instance. For example,

we need backup schedule loop up and running, to periodically take snapshot. #1841
we need restore control loop up and running, to detect disaster, and trigger restore operation.

cc: @khenidak @shrutir25

The current disaster design doc implies a restore operator maintains clusters which doesn't appear to be the case any longer. https://github.com/coreos/etcd-operator/blob/master/doc/design/disaster_recovery.md


Bug - Rounding needed for SQL index fragmentation table

The numeric values in the columns "Average Fragmentation (%)" and "Average Page Space used (%)" need to be rounded to 2 decimal places.

The bug is in the SQL statement nested in the cmhealthcheck.xml file.  This will be fixed in 1.0.4


Use Informers instead of Watcher in reload for fabric8

Currently, k8s-native client dependency uses informers for reload functionality, but fabric8 uses watches. We should use informers instead of watchers in fabric8 also.

already handled here. but there are other PRs that need to go first. Just dropping a note so that we do not forget

@ryanjbaxter since you merged the last PR, this can be closed also.


Vagrant e2e test should behave more like GCE e2e

Ensure that VMs are updated prior to running and tear them down at the end.

Is this still an issue?
cc @derekwaynecarr

I can make sure they are torn down.  Will get to this this week.  Assign to me.

I am closing this issue now.
The e2e scripts call test-teardown which for vagrant calls kube-down which ultimately does a vagrant destroy -f


Implementation of errors listed in error.h

Hi, I use FreeRDP with Remmina and I think this combination is much better than Windows RDP Client. So good job! :) However, there are som things I didn't like that much, so I decided to tell you about them, so FreeRDP and Remmina can improve.
I think that informing user about errors that happens can be improved. I have created this issue: https://github.com/FreeRDP/Remmina/issues/498 and giox069 (his comment: https://github.com/FreeRDP/Remmina/issues/498#issuecomment-75594933 ) discovered that FreeRDP returns the same error code for any type of error. Could you implement more error codes, so Remmina can inform user about type of error that happened?
Thank you!
Tomas

see also #4555

We're quite limited in finding out what exactly caused an error, but #4555 is a first step and has been integrated today.

this has improved, closing.


feat: three-way Text comparison

This adds a primitive textCompare of type
(Text, Text) -> Int8

representing the ordering relation on Text. -1 means the first text is smaller, 0 means they are equal, and 1 otherwise.
This is basically a backend wrapper around Rust text_compare.
Partly fixes #3150.

Good man - I guess all you need to do is convert to Order.t in base/Text.mo, right?

Me too.


Agent setting for only taking action without model update

Hi there,
I am wondering if there is any setting of the agent I can set so that after some iterations of training, then I can use the same agent to run some evaluation iterations to only take actions without model update?  My goal is to run  (training1, evaluation1), (training2, evaluation2), .... (trainingN, evaluationN) with the agent without recreating it in the middle.  Is that doable?
I tried in the evaluation phase,  only calling act(), skip calling observe(), but there will be exceptions raised.
Any comment is appreciated!

If you only want to call act in the evaluation, set independent=True in act()

@michaelschaarschmidt ,  it works,  thanks a lot!


User Login/Logout

Logins Include

Native Login (Email and Password)
Google Login

Ref the sprint doc for more information about the workflows: https://docs.google.com/document/d/1T9SyUpl273e6UIen7ZR5ln4d4HsrtLdRBEy9dJf1RQc/edit

/cib user login logout

Branch 3-user-login-logout created!


Create 0000-01-02-kvajay1.md

I just wrote that I have opened github after a long time and added a description.

I just wrote that I have opened github after a long time and added a description.

I just wrote that I have opened github after a long time and added a description.

I just wrote that I have opened github after a long time and added a description.


introduce actionlint

Coverage remained the same at 80.015% when pulling aa6c176580cfdd91670369ae99a668c4b587bb5b on introduce-actionlint into 84ac324b412e1a97ae956a21913c8a973ef0ee27 on main.


Feat issue 6 listing view

Summary
Individual Listing View.  Need to slightly update props passing.
Description
Individual Listing View
Related Issue
Issue #6
Motivation and Context
Working w/ redux-react.  Getting more comfortable with the syntax.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Automated Testing
[ ] Documentation

Testing Details
Run in app
Screenshots (if appropriate)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Looks good Shane, clean and module.
One note though -- we're not using crime rate at the moment. I'll go ahead and merge this request and then take it out.
Keep up the good work! ;)


Better SSL cert support

Adding feature to specify optional path to ssl cert file, or default to system certs and eventually falling back to unverified SSL context. Dell DRACs ship with a self signed SSL cert and will fail unless you can provide the cert, or default to unverified SSL context (preferred, until new cert can be uploaded).

@jbarnett1981  Thanks for this.


Captcha solve manually

Hi Guys,
I need help to understand how can i solve the captcha manually?
The only thing i was thinking is to wrap it around APK but it's a lot of work.
Can i get clear explanations on captcha solver for this new puzzle?
@szdc please help me, we are in production.

Open your MiTM application and log the requests. Look at the parameters being sent. Emulate those parameters and you're golden.

Open your MiTM application and log the requests. Look at the parameters being sent. Emulate those parameters and you're golden.

Please share with me your contact. i will pay for your time.
I am working on latest version and have done MiTM and have all dumps.
I still not able to solve/login

Please stop opening issues, this is not within the scope of this repository.


TLS-crypt broken (?)

When I create a new (or edit an existing) OpenVPN-Server with TLS-Crypt it does NOT work, because only TLS-auth is written to the corresponding config file (under /var/etc/openvpn)
written:
tls-auth /var/etc/openvpn/server3.tls-auth 0
should be:
tls-crypt /var/etc/openvpn/server3.tls-auth
I'm using OPNsense 21.7.3-amd64

https://github.com/opnsense/core/pull/4592#issuecomment-925525114


Write a TypeScript program to check lower case

Description
Write a TypeScript program to check lower case
Check if given character is lower case (a-z).
Input  : a
Output : Lower Case

How to contribute

Save the solution in program/CheckLowerCase.ts file
Add CheckLowerCase.ts file in check-lower-case folder

!assign


TFDS tests fail with tf-nightly

System information

TensorFlow version: - tf-nightly
Python version: - 3.6

Describe the current behavior
Tensorflow-dataset tests fail with tf-nightly while is works fine with TF 1.15 and TF 2.1
Describe the expected behavior
Tests should pass.
Standalone code to reproduce the issue
Colab Link
More Info: https://github.com/tensorflow/datasets/issues/1670

i have replicated mentioned issue it persist in nightly

@vijayphoenix This issue is already been discussed here. This issue is primarily due to tfds api itself itself and has already been posted there. Closing this issue as it belongs to tensrflow/datasets repo.

Our tests are back to green. Thank you: https://source.cloud.google.com/results/invocations/1f44cdab-ab19-4b5d-8cc7-1793fb51864a/targets/tensorflow_datasets%2Fgh_testing%2Fcontinuous/log


Rojo resturcure & updated the system

Ok didn't check if this works properly.
Also when I was testing it I discovered that your endpoint returned notscams and scams as null

hm. im investigating the problem with the system now

I think its a brain.js issue, since the old version is having the same problem, and that hasn't been touched since it was working

nevermind. we just need more training data, sometimes it doesn't have enough to run


Panic when making request, could not parse Url as Uri

I just came across a panic in the latest reqwest release (both 0.10 and master). This happens when making a request.
It seems that some input in Client.get(url) parses successfully as URL at first, and then panics when attempting to parse the URL as http::Uri (internally).
Example
Here's a very basic (abstracted) example that causes this panic:
#[tokio::main]
async fn main() -> Result<(), reqwest::Error> {
    reqwest::Client::new()
        .get("http://\"")
        .send()
        .await?;
    Ok(())
}

Which outputs:
thread 'main' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

I believe the Client.get(url) function should return an error in all cases where the URL is invalid. This actually happens when providing something like "http://a b" (InvalidDomainCharacter). However, "http://\"" succeeds and panics when making the request with .send().
The panic is located here.
Assumption
I have the following assumption on what is going on:
I think Url is used first to parse the provided URL (here). Then the assumption is made this URL is valid once parsing succeeds. Internally, when making a request through hyper, this URL is parsed to an Uri. Assuming the URL is valid this should always succeed, but it does not. That probably means that either implementation of Url or Uri is incorrect, or at least not compatible.
Al right. I'm not too familiar with the URL/URI specs, and don't want to go through it right now, to confirm either implementation is correct.
Fixing this
I see the following options:

Immediately parse to an Uri when creating the request (and check for validity).
Fix Url implementation (if invalid)
Fix Uri implementation (if invalid)
Use Uri throughout the crate.
Propagate this parsing issue up to the calling function, return as error in a Result.

I think the first is easiest to do on a short notice.
What would be the correct way of doing things? What are your thoughts, is the assumption I made right, and is this undesired behaviour?
I might be happy to implement a fix for this in code once I know what path I should take.

Repro'd on the Url side of things

Here are a few other random ones that came up in my logs, parseable as Url but not as Uri:
"http://‘nvme@nip2"
"http://-1@"
"https://a@b"
"https://€@qq"

As a non-ideal bandage, I'm using these in the short term: https://stackoverflow.com/questions/3809401/what-is-a-good-regular-expression-to-match-a-url
https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)

https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)

Thanks, as a workaround, I'm currently actually testing whether it will parse as Uri, to be 100% sure it works before providing it to reqwest.

I believe URI is more forgiving in terms of the spec right?

I believe URI is more forgiving in terms of the spec right?

Not sure, it might be. But the panic came up because an Url (successfully parsed) couldn't be parsed as Uri. Testing this exact transformation before giving the URL to reqwest allows you to test whether it would panic or not, that's why I'm using this approach.
But in the end I think this issue should be fixed no matter what, of course.

I don't think Uri can directly replace Url in the request struct, because Url is used to manage various URL parts. An explicit parse check to mitigate this panic upon creating the Url could be done, but this introduces overhead.
I believe https://github.com/seanmonstar/reqwest/issues/668#issuecomment-540310377 is correct, in that the Url implementation should be fixed.

I don't believe this is necessarily a bug in url, as the URL spec allows for parsing a lot of non-sensical URLs.
As you've mentioned, reqwest should likely check sooner that the URL can also be a valid URI.

My code panicked tonight and because the fix should be the same, I’m adding my example to this issue.
I am using a Telegram bot to inform me when something goes wrong. To send a message, you call a URL and pass the message in the query part of it. Unfortunately, because I included some logs in that message, the URL got too long and reqwest paniced at src/into_url.rs:44.
I’d expect that .send() returns a Result::Err instead.
Example to reproduce
use reqwest::blocking::Client; // reqwest 0.10.9
use url::Url; // url 2.2.0

fn main() {
    let text = "abcdefghijklmnopqrstuvwxyz".repeat(100_000);

    let mut url = Url::parse("https://www.example.com/").unwrap();
    url.query_pairs_mut().append_pair("text", &text);

    Client::new()
        .get(url)
        .send() // panics
        .expect("THIS IS NOT REACHED");
}

[package]
name = "bug"
version = "0.1.0"
edition = "2018"

[dependencies]
reqwest = { version = "0.10.9", features = [ "blocking" ] }
url = "2.2.0"

I'm pretty sure your issue here is because you have way to much char in your url due to the repeat(100_000).
I've not looked at the underlying URL lib being used to parse the Url, but it should be normal that they have hardcoded a maximum length.
Can you try without the repeat and check if it works?

@Martichou Yes, the intended issue is that the URL is too long. But it is reqwest‘s .send() that panics. It should return a Result::Err instead.

@gralpli Oh yeah I see what you mean.
Indeed it would be better, don't know if @seanmonstar have the same opinion.

Hitting a panic instead of a err'ed Result was quite a surprise to me and unfortunately hit me in production.
This bit me as well recently in a similar way to @gralpli above:
a parsed Url should always be a valid Uri: InvalidUri(TooLong)

I now convert the String to a URL via reqwest::Url::parse before passing in to the .get(url) call.
In reading the get docs during writing the code I somehow parsed "This method fails whenever the supplied Url cannot be parsed." as thinking I'd get a bad Result later.


You have to choose between them but i cant move the '*' to openvpn..
What am i doing wrong here? When i press enter when the red marker is on openvpn it starts installing wireguard :/

What am i doing wrong here? When i press enter when the red marker is on openvpn it starts installing wireguard :/

The dialog tells you to press space to select your choice: https://github.com/pivpn/pivpn/blob/e73f274fca692f40f7aa83d3931dc43257da5a54/auto_install/install.sh#L1027

Lets test it tonight but i'm pretty sure i did that

That gotta be something on your side ...
otherwise we would have noticed, and looooot more users would have complained about that ...
most likely somethin you are doing wrong, or something wrong with your setup.


Aethese is bad coder and bad is

the bad coder is and should nt be on the hub
blasen

commented from friend thinking they're funny :P


[Bug] Getting "TypeError Cannot read properties of undefined"

Version
5.2.1
Link to Minimal Reproduction
No response
Steps to Reproduce

On switching on "Pause on exception" in my dev tool in chrome
When I reload the app which is using the ECharts.
stops at echarts.min.js line 45.
gives error - "Cannot read properties of undefined (reading 'get')"

Current Behavior
gives error - "Cannot read properties of undefined (reading 'get')"
Expected Behavior
Resolution of the error
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

EchartsIssue.zip
Hi Team,
PFA the demo. just run the index.html file and in dev tool switch on the "Pause on exception".
reload the page. You will get the error.
Thanks

Hello @KundanJha123 , it seems that index.html you provided is an empty file except for a pair of <script></script> tag.

yes. We are testing the Js file I have provided with it. You can just run this html file and in developer tool of chrome you will get exception

Ok, I got this, too. I also ran the fresh-built echarts.min.js and got same result.
I have no idea...wait for someones who know the issue.

Sure Thank you

Hi Team, Any updates on this issue??

Hello. is there a way to fix this issue?

Hi All. Can have an update on this please. Because of this our project is failing.

Please be detailed on how it fails and how it affects your project.

Hi, You can see in above conversations. I have shared a demo as well.

I've seen your demo. It only runs the script of ECharts. But the exception will be caught internally, it won't affect your project theoretically.

Yes. But customers want and exception free app

So what can't work due to this exception? Please provide more information.

I just wanted to know if we can fix this issue by any chance? Or any future update can fix it?

No. It's by design. This exception may occur when initializing the script as ECharts needs to collect the required information when installing components. But it won't make something not work as it can be caught internally.

Hi, Can you help me out how can I handle this exception in my project?

We are having the same issue and it is causing no data to show up on the graph without refreshing the page.


ARROW-10038: [C++] Spawn thread pool threads lazily

Thread pool threads are not spawned until necessary to execute a pending task.

@pitrou looks like an ordering-of-dict-fields problem in test_parquet_nested_storage https://github.com/apache/arrow/pull/8240/checks?check_run_id=1154644456#step:8:2885

@bkietz Yes, this probably needs a quick fixup PR.

https://github.com/apache/arrow/pull/8248

So, there is still a crash with RTools 3.5 in Release builds:
https://github.com/apache/arrow/pull/8240/checks?check_run_id=1221808315
but not in RelWithDebugInfo builds:
https://github.com/apache/arrow/runs/1221597248

Interestingly, it seems the RTools 3.5 build now passes. It also did on my fork.

Interestingly, it seems the RTools 3.5 build now passes. It also did on my fork.

cc @westonpace

cc @westonpace

Sorry, I having trouble understanding what you are referencing.  There was an RTools 3.5 failure because of a gcc bug requiring you to std::move a unique_ptr but I don't think that would apply here.
The other compiler warning treated as error seemed to be unique to gcc 9.3 and tsan and I didn't know there was any failing job related to it.

Sorry, I having trouble understanding what you are referencing.  There was an RTools 3.5 failure because of a gcc bug requiring you to std::move a unique_ptr but I don't think that would apply here.
The other compiler warning treated as error seemed to be unique to gcc 9.3 and tsan and I didn't know there was any failing job related to it.

@westonpace Sorry, I wasn't clear. I was just cc'ing you for the PR itself, not for the CI failure.

@westonpace Sorry, I wasn't clear. I was just cc'ing you for the PR itself, not for the CI failure.

Ah, no problem.  Looks good.  We will have to keep this need in mind if we ever end up adopting the multi-queue approach.

Ah, no problem.  Looks good.  We will have to keep this need in mind if we ever end up adopting the multi-queue approach.

Okay, I'm gonna merge this since the RTools 3.5 CI failures haven't reappeared. Other CI failures are unrelated.

Okay, I'm gonna merge this since the RTools 3.5 CI failures haven't reappeared. Other CI failures are unrelated.


Unable to remove metric from realtime node

I just removed a metric from the config of our realtime nodes and restarted them. Now they fail to persist the segments around the time the node was restarted:
Failed to persist merged index[foo]: {class=io.druid.segment.realtime.plumber.RealtimePlumber, exceptionType=class io.druid.java.util.common.IAE, exceptionMessage=Indices to merge contained metric[bar], but requested metrics did not, interval=2017-11-14T04:00:00.000Z/2017-11-14T05:00:00.000Z}

Which is from here:
https://github.com/druid-io/druid/blob/3541b7544b90f4991673fb6f052615dfd825d721/processing/src/main/java/io/druid/segment/IndexMergerV9.java#L798
Shouldn't it just drop this metric during the merge instead?
How can this be fixed for these segments and what is the proper procedure to remove a metric?

I'm guessing this is only possible using Tranquility and not using the standalone realtime nodes?

I seem to recall seeing this issue before with realtime nodes. I think it shouldn't happen with tranquility or with the kafka indexing service. If you're interested in fixing it then a patch would be welcome. You're probably right that it should be a little more forgiving.


Fix XmlLoggingConfiguration reloading

Fixes #2279
In the XmlLoggingConfiguration :
In case the file contains an invalid xml, an exception is thrown in the Initialize method and the _originalFileName was never saved. Since Reload() uses the _originalFileName to read the xml file, it was impossible to reload the config.

As a side note, is it normal that we do not throw a NullArgumentException if fileName is null ?
https://github.com/NLog/NLog/blob/b209b344c331fb917cab25d42bc034ee73027431/src/NLog/Config/XmlLoggingConfiguration.cs#L126
We also allow to call Reload() if _originalFileName is null (this is possible when the config was initialized from a XmlReader)
https://github.com/NLog/NLog/blob/b209b344c331fb917cab25d42bc034ee73027431/src/NLog/Config/XmlLoggingConfiguration.cs#L304


can't use NSTextAttachment replace image

when I use NSMutableAttributedString,I can't use NSTextAttachment replace image

NSTextAttachment is not currently supported. You can try the 2.0.0 branch where it works but some other features are incomplete.

BTW, if you try it out, pull requests to 2.0.0 are welcome!


revdeps: new option to print a (direct) dep source

#1 should be merged first
This includes all the changes form #1 and shall be rebased before merging, after #1 is merged.

Add a new option to revdeps, -direct, in 79ca466.
That is useful e.g in case of -prefix github.com/src-d and would allow to show a direct dependency -- origin of the reverse one.
That allows to investigate the result of the query like "Histogram of everything that depends on this org":
$ go run ./tools/revdeps -prefix -direct -store ../_dep-graph-go-mod-41286 github.com/src-d | grep -v " github.com/src-d/.*$" | cut -d" " -f1 | sort | uniq -c | sort -nr

      2 github.com/src-d/enry/v2
      1 github.com/src-d/go-git/plumbing
      1 github.com/src-d/datasets/PublicGitArchive/pga/pga
      1 github.com/src-d/borges

and get the list of all packages, depending on github.com/src-d
$ go run ./tools/revdeps -prefix -direct -store ../_dep-graph-go-mod-41286 github.com/src-d | grep -v " github.com/src-d/.*$" | sort | less

github.com/src-d/borges github.com/jfontan/requeue
github.com/src-d/datasets/PublicGitArchive/pga/pga github.com/smola/language-dataset
github.com/src-d/enry/v2 github.com/bblfsh/bblfshd/daemon
github.com/src-d/enry/v2 github.com/hhatto/gocloc
github.com/src-d/go-git/plumbing github.com/posener/goreadme-server

Good suggestion. I attempted to address this in a somewhat different way in 35c1596e, does that meet your needs? Specifically, I don't like exposing indexes into the data structure to the outside API, so I plumbed in the target path instead.

35c1596 works like a charm :bowtie:


Remove hard-coded paths

Any files should either be passed in as arguments or built into the Docker images

All current files have been updated. Will keep issue live until MZ_step and PP_step are completed.

Going ahead and closing this - nothing is being tested hard-coded anymore


Verifies SSZ encoding with @chainsafe/ssz

At the moment, the signature is verified against the root provided by the deposit-cli. This is unsafe if the root is not correctly calculated, the message that is signed could be incorrect.
In addition to the above, the deposit data json checker was brittle.
This addresses the above by using @chainsafe/ssz to verify the root as well as implementing the signature verification methods from the eth2-spec.

Closes #61
Resolves ethereum/eth2.0-deposit-cli/issues/23 (Root re-verification)
Required for ethereum/eth2.0-deposit-cli/pull/32 (fork_version )

@hwwhww, I'd like your review for the root checking & signature verification
@Battenfield, Please can you check my typescript.

Thank for the review!

Field name inconsistent issue.

I agree this should be changed on the deposit-cli side. As we discussed the other day, keeping naming consistent with the spec is a good idea.

GENESIS_FORK_VERSION

This is addressed in #84 (which I made just after this PR). Ultimately, I'd like to redesign how network configuration is done, but I don't think my JS kung fu is up to snuff for this task. In much the same way we do in the CLI now, I'd like to have a config file with network, deposit amount, is_testnet, deposit contract address, fork version, etc built in.

GENESIS_FORK_VERSION

This is addressed in #84 (which I made just after this PR). Ultimately, I'd like to redesign how network configuration is done, but I don't think my JS kung fu is up to snuff for this task. In much the same way we do in the CLI now, I'd like to have a config file with network, deposit amount, is_testnet, deposit contract address, fork version, etc built in.

We could put all of these parameters in the .env and default them to their current envVars.ts values.


Enforce Appropriate "admonition" directive Usage

Up till now, my understanding was that as long as our sphinx run succeeds, any sphinx code comments MUST be good enough to power docs.microsoft.
Unfortunately, I have found one instance where this is not the case. We need to make certain that CI catches ANY errors that could halt CI.

@kristapratico I'm assigning this to you, given that I haven't done any of the work to implement this, my name shouldn't be on here when your PR closes.

Closing as #10844  merged.


Article Title Change Request

Most customers and internal FTEs at Microsoft know this as "Cross Cloud B2B".
Is it possible to change:
Configure Microsoft cloud settings for B2B collaboration (Preview)
to
Configure Microsoft Cross Cloud B2B (Preview)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23465c7c-cda1-ca2f-e958-cbf835a2ba93
Version Independent ID: 5f20559a-f258-bedf-786a-5b264bcfd6cf
Content: Configure B2B collaboration Microsoft cloud settings - Azure AD - Microsoft Entra
Content Source: articles/active-directory/external-identities/cross-cloud-settings.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@JCoreMS Thank you for your suggestion . We will check with the product group if they approve the change and make changes accordingly . .

@JCoreMS We are tracking this internally and will update accordingly .


ros-{DISTRO}-rmw-connextdds should be installed.

part of https://github.com/osrf/ros2_test_cases/issues/713

@clalancette do we backport all here?

follow-up issue https://github.com/ros2/ros2_documentation/issues/3573 created, i will go ahead to close this PR.


chore: remove --strictSSL flag

Pull Request Test Coverage Report for Build 585

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.313%

Totals

Change from base Build 584:
0.0%

Covered Lines:
93

Relevant Lines:
97

💛  - Coveralls


Add a page for SPA.

can i work on this @ArchismanKarmakar

can i work on this @ArchismanKarmakar

can i work on this @ArchismanKarmakar

go ahead

can i work on this @ArchismanKarmakar

go ahead


Credentials middleware should fail explicitly if session isn't available

Currently, if session isn't configured and added to middlewares before credentials is used, authentication can fail silently (i.e., if web-based OAuth2 authentication, authentication callback can fail with a 404 Not Found error). We should explicitly throw(?) an error if session isn't available.

Issue moved to IBM-Swift/Kitura #690 via ZenHub


Allow table widget to have a minimum and maximum of items

This PR adds the config variables minItems and maxItems for the Table widget and datatable field type. The impetus of this is to allow a table to have no items by setting the minItems to 0 - I have found in my travels that if you have any sort of validation on the table widget, then you must have at least one record, but in my case, I wanted the datatable field to be optional.
I then thought it might be useful to have the opposite, and allow an upper limit for the number of records.
Some rules on the above:

minItems must be 0 or above. By default, it is 1 to match the current functionality. If minItems is 2, then 2 records must be in the datatable at all times (the datatable will have 2 empty records added on load).
maxItems must be either 1 or above, or null to indicate no limit.
minItems must be less than or equal to maxItems, to allow a datatable to have a fixed number of records.

To allow this change to happen, I've decided to change the datasource objects (client and server-side data handling) to use promises - this way, we have a common way of reading the responses, and it will gracefully handle the server-side taking a little longer to make changes to the data.

@bennothommo what's the status of this?

I'm gonna say I think it is complete... Definitely haven't tested it quite some time though.

@bennothommo do we have a docs PR for it?

I will test it first, and then I'll put up a docs PR, in case anything needs to change.

@bennothommo what's the status on this?

Same as before. Still needs docs and testing. Haven't had a need for it yet - I think I did this for my old job.

@der-On or @WebVPF, either of you bored and looking for something to do 😉?

@LukeTowers Bored to the bones :joy_cat: . Sorry I'm currently out on this.


2.4 Release Triplets

Append -release to release triplets like upstream to have no name conflict

I tested this with a Mixxx 2.4 build. It works, but requires to adjust the CMAKE_PREFIX_PATH in windows_buildenv.bat, which contains the triplet name.

LGTM! Thank you!

The build of the 2.4-rel branch failed after merging this


added OIDCIgnoreAcceptHeader option and added -std=c99

Dear experts,
we forked your latest version and added OIDCIgnoreAcceptHeader to configuration.
This option is usefull, if a real client should be redirected to login page, but does not sent the accept-headers. For example: IBM Cognos for Microsoft office is an excel plugin that does not always send accept headers. In this case the client would receive 401 UnAuthorized, while it could easily be redirected to the login page.
Added -std=c99 because compilation error on SLES (4.12.14-95.24-default)
Error details:
src/jose.c:1480:3: error: 'for' loop initial declarations are only allowed in C99 mode
   for (int i = 0; i < oidc_jwk->x5c_count; i++) {`
   ^
src/jose.c:1480:3: note: use option -std=c99 or -std=gnu99 to compile your code
apxs:Error: Command failed with rc=65536
.
Makefile:68: recipe for target 'src/mod_auth_openidc.la' failed

Looking forward to your acceptance.
Regards,
Ralf + Arslan

it would be good to have a look at the request (headers) that is actually sent by IBM Cognos

Hi @zandbelt,
Here are the request headers sent by IBM Cognos Office Framework:
POST /crn1/cgi-bin/cognos.cgi HTTP/1.1
Accept-Language: en-US
User-Agent: Mozilla/4.0 (compatible; Cognos Office Framework)
Content-Type: text/xml;charset=utf-8
SOAPAction: http://www.ibm.com/xmlns/prod/cognos/contentManagerService/201301/
Host: test4.mif.app.corpintra.net
Content-Length: 2408
Expect: 100-continue
Connection: Keep-Alive

and the response headers with 401:
HTTP/1.1 401 Unauthorized
Date: Thu, 25 Jun 2020 15:51:47 GMT
x-powered-by: AMVARA_Monitoring_URL_for_ITG/B
Content-Length: 474
Connection: close
Content-Type: text/html; charset=iso-8859-1

apparently we are dealing with a SOAP request here and I think it is odd to expect that a SOAP client would be able to handle the redirect and authorization code flow to an OIDC Provider; I believe the module is doing the right thing and the client should act on the 401 by refreshing the "parent page" (if it were an SPA); if you still feel this one-off patch works for you I suggest to maintain it in a fork

Hello Hans,
Yes it is soap.
And no it does not refresh.
Getting ibm to fix their code has been rejected.
The client responds with an operating system pop up asking for credentials,
which is also correct, if receiving a 401.
Answering with 302 or 301 leads to the correct behavior of redirection.
From your point of view, sending a 401 is correct. BUT you are dealing with
a client that sent no accept headers and misleads the module code to the
assumption.
The client actually is capable of js and redirects and should be receiving
a 302 or 301.
But that is not possible with the actual implementation of mod_auth_openidc.
So, making the answer configurable is a straight forward approach.
Will it be of benefit to others. We do not know that, but it fixes an issue
that hits hundreds of users onsite where we use it.
Thank you for comments and arguments.
Ralf

.... sent from mobile ... excuse my brevity.
El jue., 25 jun. 2020 18:41, Hans Zandbelt<EMAIL_ADDRESS>escribió:

apparently we are dealing with a SOAP request here and I think it is odd
to expect that a SOAP client would be able to handle the redirect and
authorization code flow to an OIDC Provider; I believe the module is doing
the right thing and the client should act on the 401 by refreshing the
"parent page" (if it were an SPA); if you still feel this one-off patch
works for you I suggest to maintain it in a fork
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-649682551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7FL2JRVM3EP7UTIHKVJJLRYN43JANCNFSM4OFYOORA
.

it will resolve a problem for hundreds of your users but over the past 6 years the other millions of users of this module have not experienced it, that is why I'm reluctant to include it as is and add yet-another-primitive-that-will-confuse-people-and-that-will-make-them-abuse-it; been there, done that, I hope you understand :-\
after all, what you have now could easily be maintained in a separate fork by just commenting out the header checking in the code, with no configurability, just a one liner
if you could turn this into a primitive that makes the detection of an XML HTTP request really configurable with a lot more flexibility and options, it may be useful for more use cases and worth maintaining it though

how about making this into an option that spells out the Accept request header values that will be interpreted as non-browser requests?

The following headers should be customizable: Accept, Content-Type, Sec-Fetch-Dest.
So maybe a generic config allowing to define any header would be useful.
Also, parsing the URI (regex) would be useful.

Or referer url ....
The list is endless.
As Hans mentioned, making this really good is not easy.
I have been thinking about it hours. No conclusion yet.
For the moment: we are facing a very special issue and the solution is
straight forward.
But, I agree with Hans, that nobody had this issue before is strange.
So, solving something that is not broken, might not be the solution.
I would prefer ibm to fix their client. That's for sure. But they don't
move.
Appreciate your comments and will keep thinking about this.
Stay healthy and pls send any ideas even if they seem weird.
Ralf

.... sent from mobile ... excuse my brevity.
El mié., 8 jul. 2020 13:51, Marc Stern<EMAIL_ADDRESS>escribió:

The following headers should be customizable: Accept, Content-Type,
Sec-Fetch-Dest.
So maybe a generic config allowing to define any header would be useful.
Also, parsing the URI (regex) would be useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655470268,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7FL2J37FXN7JTUDIG75C3R2RMUTANCNFSM4OFYOORA
.

What about 2 generic directives OIDCBrowserHeader &
OIDCNotBrowserHeader taking a regex and used sequentially.

Example:
  # When content-type is XML, send 401

OIDCNotBrowserHeader "^Content-Type: .*xml"

# Exception for IBM Cognos Office Framework, send 302
  OIDCBrowserHeader "^User-Agent: .*Cognos Office Framework"
  # When content-type is JSON, send 401, even for IBM Cognos Office
Framework,

OIDCNotBrowserHeader "^Content-Type: .*json"
  <Location /admin>
    # In this location, When content-type is JSON, send 401, even
for IBM Cognos Office Framework,
    OIDCNotBrowserHeader "^Content-Type: .*json"
   </Location>

I think we can handle all generic cases and exceptions

And we could have the same for the URI (OIDCBrowserUri &
OIDCNotBrowserUri)

On 08-07-2020 23:29, raro42 wrote:

  Or referer url ....

  The list is endless.

  As Hans mentioned, making this really good is not easy.

  I have been thinking about it hours. No conclusion yet.

  For the moment: we are facing a very special issue and the
  solution is
  straight forward.

  But, I agree with Hans, that nobody had this issue before is
  strange.

  So, solving something that is not broken, might not be the
  solution.

  I would prefer ibm to fix their client. That's for sure. But they
  don't
  move.

  Appreciate your comments and will keep thinking about this.

  Stay healthy and pls send any ideas even if they seem weird.

  Ralf

  ---
  .... sent from mobile ... excuse my brevity.

  El mié., 8 jul. 2020 13:51, Marc Stern
<EMAIL_ADDRESS>escribió:

  > The following headers should be customizable: Accept,
  Content-Type,
  > Sec-Fetch-Dest.
  > So maybe a generic config allowing to define any header would
  be useful.
  > Also, parsing the URI (regex) would be useful.
  >
  > —
  > You are receiving this because you authored the thread.
  > Reply to this email directly, view it on GitHub
  >

https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655470268,
> or unsubscribe
>
https://github.com/notifications/unsubscribe-auth/AG7FL2J37FXN7JTUDIG75C3R2RMUTANCNFSM4OFYOORA
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655767747",
"url": "https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655767747",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Actually, OIDCBrowserUri & OIDCNotBrowserUri are not needed, as
we can use "OIDCUnAuthAction 401" in a  LocationMatch.
So, only 2 directives needed.
Or maybe only one: OIDCUnAuthActionHeader, taking a regex and
[auth|pass|401|410] as OIDCUnAuthAction.
This would be simpler to implement and more generic :-)
Or even adding the support for expr= to OIDCUnAuthAction; within an
ap_expr, we can access headers (and much more).

On 09-07-2020 12:13, Marc Stern wrote:

  What about 2 generic directives OIDCBrowserHeader &
  OIDCNotBrowserHeader taking a regex and used sequentially.

  Example:
    # When content-type is XML, send 401
     OIDCNotBrowserHeader "^Content-Type: .*xml"
     # Exception for IBM Cognos Office Framework, send 302
    OIDCBrowserHeader "^User-Agent: .*Cognos Office Framework"
    # When content-type is JSON, send 401, even for IBM Cognos
  Office Framework,
     OIDCNotBrowserHeader "^Content-Type: .*json"
    <Location /admin>
      # In this location, When content-type is JSON, send 401, even
  for IBM Cognos Office Framework,
      OIDCNotBrowserHeader "^Content-Type: .*json"
     </Location>

  I think we can handle all generic cases and exceptions

  And we could have the same for the URI (OIDCBrowserUri &
  OIDCNotBrowserUri)

  On 08-07-2020 23:29, raro42 wrote:

    Or referer url ....

    The list is endless.

    As Hans mentioned, making this really good is not easy.

    I have been thinking about it hours. No conclusion yet.

    For the moment: we are facing a very special issue and the
    solution is
    straight forward.

    But, I agree with Hans, that nobody had this issue before is
    strange.

    So, solving something that is not broken, might not be the
    solution.

    I would prefer ibm to fix their client. That's for sure. But
    they don't
    move.

    Appreciate your comments and will keep thinking about this.

    Stay healthy and pls send any ideas even if they seem weird.

    Ralf

    ---
    .... sent from mobile ... excuse my brevity.

    El mié., 8 jul. 2020 13:51, Marc Stern<EMAIL_ADDRESS>    escribió:

    > The following headers should be customizable: Accept,
    Content-Type,
    > Sec-Fetch-Dest.
    > So maybe a generic config allowing to define any header
    would be useful.
    > Also, parsing the URI (regex) would be useful.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    >
    <https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655470268>,
    > or unsubscribe
    >
    <https://github.com/notifications/unsubscribe-auth/AG7FL2J37FXN7JTUDIG75C3R2RMUTANCNFSM4OFYOORA>
    > .
    >
    —
      You are receiving this because you commented.
      Reply to this email directly, view it on GitHub, or unsubscribe.
    [

{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655767747",
"url": "https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-655767747",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Full flexibility could ba achieved by adding the support for expr= to OIDCUnAuthAction.
For the given example, we could use
OIDCUnAuthAction auth "expr=%{HTTP:User-Agent} =~ 'Cognos Office Framework'"

I like the suggested approach to add an expression as the 2nd parameter to OIDCUnAuthAction, overriding the auto-detection of non-browser requests when not defined and overriding the fixed behaviour when defined with a single parameter

@raro42 @marcstern can you take a look at 1461634? doc is here: https://github.com/zmartzone/mod_auth_openidc/commit/1461634f75141df6386223bba9446ddb7bbf9ab1#diff-9aa1af9536853a9ab137420dc9a279cdR766-R780

It passed all my automated tests. Good job.
For info, I only tested one directive at the global level depending on an environment variable (that is set, when needed, by ModSecurity). That does the job for me (better than creating a LocationMatch entry for each expression).

Have been thinking about it for a while. Without looking at the source
code I would not have understood the documentation.
Maybe adding below lines to the documentation this makes it easier to
understand

Since verson 2.4.4 a boolean Apache expression as the second parameter to
specify which requests
need to match to return the configured value in the first parameter to
override the default, e.g.:
OIDCUnAuthAction 401 "%{HTTP_USER_AGENT} =~ /curl/" # or:
OIDCUnAuthAction auth "%{HTTP_USER_AGENT} =~
/Client-Pretending-to-be-xml-http/"
Explanation: # If the client matches the expression it will receive the
default user_authentication behavior, redirect to authentication provider.
If the expression is false and it is and xhr request (no accept headers
set), then returns 401, else default user_authentication behavior # # or:
OIDCUnAuthAction auth true # #
See also: https://httpd.apache.org/docs/2.4/expr.html. Note that:
a. the default is "auth" with auto-detection of XML HTTP requests
(returning 401 for the latter)
b. only one such primitive can be configured per location, overriding the
default processing from a.
c. whenever an expression is configured, auto-detection of non-browser
requests will be disabled, so:
the 1st example will no longer auto-detect XML HTTP requests and non
"curl" user agents will fall through to the default "auth"
the 2nd example above overrides the auto-detection from a., redirecting
all requests
note that because of the above an "auth" value with any expression
("true", or "false"(!), or other)
will effectively merely disable auto-detection of non-browser requests
and render "auth"
When not defined the default is "auth" with auto-detection of XML HTTP
requests, returning "401".
#OIDCUnAuthAction [auth|pass|401|407|410] []
Anyhow it looks to me that the second testcase as example above does not
work with the code as is.
OIDCUnAuthAction auth "%{HTTP_USER_AGENT} =~
/Client-Pretending-to-be-XHR/"
static int oidc_handle_unauthenticated_user(request_rec *r, oidc_cfg *c) {
switch (oidc_dir_cfg_unauth_action(r)) {
// this function oidc_dir_cfg_unauth_action(r)   returns if (expression
matched) ? dir_cfg->unauth_action : OIDC_DEFAULT_UNAUTH_ACTION
//  Configuring auth ... we endup here
case OIDC_UNAUTH_AUTHENTICATE:
/*

exception handling: if this looks like a XMLHttpRequest call we
won't redirect the user and thus avoid creating a state cookie
for a non-browser (= Javascript) call that will never return from the OP
*/
if ((oidc_dir_cfg_unauth_expr_is_set(r) == FALSE)
&& (oidc_is_xml_http_request(r) == TRUE))
return HTTP_UNAUTHORIZED;
// oidc_dir_cfg_unauth_expr_is_set(r) --> will always be true .... so
request will neve be checked for xml_http_request

}
// return do_authentication_to user
}
I believe that  oidc_dir_cfg_unauth_expr_is_set() should test the
expression and return a true or false ("matched=>true" or
"unmatched=>false")
If I configure    OIDCUnAuthAction 401 "%{HTTP_USER_AGENT} =~
/Client-Pretending-to-be-XHR/" it ends up sending 401 to the client
matched. Which is not what we need.
Really took time looking through this :-)
Unfortunately I have very little time for this now. I hope that my 5 cents
are correct and help.
Stay healthy,
Ralf
El sáb., 1 ago. 2020 18:45, Hans Zandbelt<EMAIL_ADDRESS>escribió:

@raro42 https://github.com/raro42 @marcstern
https://github.com/marcstern can you take a look at 1461634
https://github.com/zmartzone/mod_auth_openidc/commit/1461634f75141df6386223bba9446ddb7bbf9ab1?
doc is here: 1461634#diff-9aa1af9536853a9ab137420dc9a279cdR766-R780
https://github.com/zmartzone/mod_auth_openidc/commit/1461634f75141df6386223bba9446ddb7bbf9ab1#diff-9aa1af9536853a9ab137420dc9a279cdR766-R780
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-667558040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7FL2MDL6G3JI3A7MIPNLTR6RBC3ANCNFSM4OFYOORA
.

you misunderstood the concept that was added, which was not meant to be exactly what you suggested earlier: the documentation matches the code and the code was not meant to handle what you want to do with OIDCUnAuthAction auth <expression; the new code allows you merely to use a OIDCUnAuthAction 401 <expression> (where 401 is anything other than "auth")
the reason for not exactly following your suggestion is that it still does not change the default/fallback - which is still "auth" - so both matching and not matching would result in the same outcome, I hope you see that

Exactly. So the conclusion that it does not fix the testcase #479 is
correct. Reading your note 3. closely, it says that.
What do you think about changing the if ( expr_is_set() = false) to if (
eval(exp) = false).
I believe this would meet the usecase.

.... sent from mobile ... excuse my brevity.
El jue., 6 ago. 2020 20:29, Hans Zandbelt<EMAIL_ADDRESS>escribió:

you misunderstood the concept that was added, which was not meant to be
exactly what you suggested earlier: the documentation matches the code and
the code was not meant to handle what you want to do with OIDCUnAuthAction
auth <expression; the new code allows you merely to use a OIDCUnAuthAction
401  (where 401 is anything other than "auth")
the reason for not exactly following your suggestion is that it still does
not change the default/fallback - which is still "auth" - so both matching
and not matching would result in the same outcome, I hope you see that
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmartzone/mod_auth_openidc/pull/479#issuecomment-670100428,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7FL2M45DWVCT2ZOYWYU63R7LZBPANCNFSM4OFYOORA
.

I must admit that the explanations are quite complex to understand ;-)

how about rephrasing into something like this:
this feature is a way to override the non-browser auto-detection algorithm/expression, so @raro42 's use case - which is ignoring Accept headers that the default algorithm tries to interpret - is exactly met by:
OIDCUnAuthAction 401 "%{HTTP:X_REQUESTED_WITH} == 'XMLHttpRequest'"

@raro42 your suggestion does not cater for a solution since non-matching clients will fallback to the default which is "auth"
you should think about "complementary" or "inverse" expressions for defining the non-browser clients

how about rephrasing into something like this:
this feature is a way to override the non-browser auto-detection
algorithm/expression, so @raro42 https://github.com/raro42 's use case

which is ignoring Accept headers that the default algorithm tries to
interpret - is exactly met by:

OIDCUnAuthAction 401 "%{HTTP:X_REQUESTED_WITH} == 'XMLHttpRequest'"
IMHO it is not. Because, we would need a 302 returncode with
default_auth_handling if expr is true

Usecase A: "normal xml_http requests" -> 401
Usecase B: "GoOffice Client" -> default authentication / 302

@raro42 https://github.com/raro42 your suggestion does not cater for a
solution since non-matching clients will fallback to the default which is
"auth"
you should think about "complementary" or "inverse" expressions for
defining the non-browser clients

As this is overriding, it would return the default handling to standard
auth. Negating does not help, as evaluation of expr is done before hand in
oidc_dir_cfg_unauth_action(r)
IMHO, evaluating the expr in function oidc_dir_cfg_unauth_action(r) should
also be done in oidc_handle_unauthenticated_user(request_rec *r, oidc_cfg
*c).
IMHO, this
if ((oidc_dir_cfg_unauth_expr_is_set(r) == FALSE) &&
(oidc_is_xml_http_request(r) == TRUE))
return HTTP_UNAUTHORIZED;
Should IMHO be oidc_dir_cfg_unauth_expr_check_is_true(r)
oidc_dir_cfg_unauth_expr_check_is_true(r) should check for matching. If it
only checks for is-set ... it will always return true and therefore return
302 with default_auth. Which is no good for real xml_http requests
If the expr fails to match, we would appreciate the default xml_http checks
and return 401. But this point is never reached, as check_if_set() always
returns true.

I was not talking about negating "auth", I was talking about adding the negating expression to "401".
I don't think you get what the feature does, I'm closing this now.
You solution is as I wrote.

Thank you Hans.
We will create a fork, as the proposed solution does not meet the usecase.
El vie., 7 ago. 2020 18:49, Hans Zandbelt<EMAIL_ADDRESS>escribió:

Closed #479 https://github.com/zmartzone/mod_auth_openidc/pull/479.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmartzone/mod_auth_openidc/pull/479#event-3633990940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7FL2LOA2KQEHGUAVPH2ITR7QWCXANCNFSM4OFYOORA
.

.... sent from mobile ... excuse my brevity.

it really does... just try it


[FEATURE] Improve code (through testing)

With regards to forthcoming from #65 and smile.py: (i.e. things I didn't cover not to cover) in #65

[x] Create test scenario (patch/mock full_update_device) towards L206' except XMLDataMissingError:
[x] Fix with async_io timeout not excepting to L246 asyncio.TimeoutError (either fix test or fix code)
[x] L252 with cornercase stretch responding 200 instead of 202 (should be in #65 before merging
[x] L966 dual rule_ids is None: should get an indication of how/why (left it for now as uncovered)

Evaluate

[x] full_update_device as commented https://github.com/plugwise/python-plugwise/pull/65#issuecomment-780136189

Things we might already have but need validation on userdata and then testing of:

[x] L772 Fix for Adam + Anna: heating_state also present under Anna, remove should be something for userdata testing (if we can generate such)
[x] L750 self.get_open_valves on city-heating, same thing
[ ] L1231 the uri on if stretch_v2:

Added link to the to evaluate out of #65 (https://github.com/plugwise/python-plugwise/pull/65#issuecomment-780136189)

Together with the rework of @bouwew that is all but former L1231 (now L394 in plugwise/smile.py) left

And final commits to #68 closed shop for this one!


spellcheck for input

Some form of grammarly integration might make this easier ¯_(ツ)_/¯

This repo might help https://github.com/manisandro/qtspell but it would be another dependency.

bump ppBounce

bump

Bump any updates

No updates.
24 lip 2021 18:27:36 CycloneTM @.***>:

Bump any updates
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub[https://github.com/Chatterino/chatterino2/issues/16#issuecomment-886076175], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MIR2ICW6JJ72QO6EWWTTZLSW7ANCNFSM4C7A4UXQ].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADkAAAA5CAYAAACMGIOFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U9tDQ+gAAAAAAAAAAAAAAAA4NQAMv0AAa3l6BAAAAAASUVORK5CYII=###24x24:true###][Obrazek śledzący][https://github.com/notifications/beacon/AF62MIWJI3HBQ6CQDLSWH6LTZLSW7A5CNFSM4C7A4UX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGTIHGDY.gif]

No updates. 24 lip 2021 18:27:36 CycloneTM @.***>:
…
Bump any updates — You are receiving this because you commented. Reply to this email directly, view it on GitHub[#16 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MIR2ICW6JJ72QO6EWWTTZLSW7ANCNFSM4C7A4UXQ]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADkAAAA5CAYAAACMGIOFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U9tDQ+gAAAAAAAAAAAAAAAA4NQAMv0AAa3l6BAAAAAASUVORK5CYII=###24x24:true###][Obrazek śledzący][https://github.com/notifications/beacon/AF62MIWJI3HBQ6CQDLSWH6LTZLSW7A5CNFSM4C7A4UX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGTIHGDY.gif]

Does this mean its not possible or are still investigating into it?

Does this mean its not possible or are still investigating into it?

Look into this yourself if you want this so badly, others are busy with other things or simply don't care.

I personally think its best if we wait until we have to ditch QMake until we add another dependency. It's possible but I don't think anyone is working actively working it.

As per recent research - there's either hunspell or qtspell we could use but that seems like adding another dependency; even Qt's example for adding spellcheker suggests using hunspell.
So, as per mm2pl's above comment this is going to stay as 'blocked' until we get rid of QMake or something changes.

I would like to reopen the discussion about this.
QtSpell
Pros:

Extremely easy to implement.
Automatic dictionary detection
Has "add to dictionary" and "ignore"

Cons:

GPL, How will it affect the project or the artifacts?
Dynamic linking is hard on windows, but if we do static linking, and since it uses enchant, we gotta add it as a dependency (and enchant needs glib as a dependency)

Hunspell
Pros:

can be linked with LGPL, no problems with that AFAIK.

Cons:

We need to provide the dictionary path, either let the user enter it or we find a way to detect it.
"Add to dictionary" and "ignore" should be done by us, so have a list of words in a text file that are added and are ignored and store it in the configs files.

what do you think?

For the record, there's also lib_spellcheck from Telegram (which can't be used because of the large dependency graph). It can integrate the system spellchecker. It supports:

cld3 for language detection
hunspell on all platforms
enchant on Linux
Natural Language and NSSpellChecker on macOS
elscore.h and spellcheck.h on Windows

I lean towards hunspell - licensing & simplicity of using cross-platform.
I imagine any of its drawbacks we can get around with some engineering

I like hunspell. We specifically need to ignore emotes from the spell checker anyway.


[Console]: Random bracket in Console UI

Hey, saw this random bracket on the bottom left of the console stack page, which looks like it's from a typo

Thanks @nabeelvalley! Nice catch.


Add Bitcoin bech32 address

support public key to bech32 p2wpkh address.

Codecov Report

Merging #61 into master will decrease coverage by 0.38%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   81.41%   81.02%   -0.39%
==========================================
  Files          75       77       +2
  Lines        2965     3073     +108
==========================================
+ Hits         2414     2490      +76
- Misses        551      583      +32

Impacted Files
Coverage Δ

Sources/Bitcoin/Bitcoin.swift
51.61% <100%> (+3.33%)
:arrow_up:

Tests/Bitcoin/BitcoinAddressTests.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/PublicKey+Bitcoin.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/BitcoinSegwitAddress.swift
58.46% <58.46%> (ø)

Sources/Slip.swift
75% <75%> (ø)

Sources/Crypto.m
94.56% <92.3%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6556709...7b2390f. Read the comment docs.

Codecov Report

Merging #61 into master will decrease coverage by 0.38%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   81.41%   81.02%   -0.39%
==========================================
  Files          75       77       +2
  Lines        2965     3073     +108
==========================================
+ Hits         2414     2490      +76
- Misses        551      583      +32

Impacted Files
Coverage Δ

Sources/Bitcoin/Bitcoin.swift
51.61% <100%> (+3.33%)
:arrow_up:

Tests/Bitcoin/BitcoinAddressTests.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/PublicKey+Bitcoin.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/BitcoinSegwitAddress.swift
58.46% <58.46%> (ø)

Sources/Slip.swift
75% <75%> (ø)

Sources/Crypto.m
94.56% <92.3%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6556709...7b2390f. Read the comment docs.

Codecov Report

Merging #61 into master will decrease coverage by 0.38%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   81.41%   81.02%   -0.39%
==========================================
  Files          75       77       +2
  Lines        2965     3073     +108
==========================================
+ Hits         2414     2490      +76
- Misses        551      583      +32

Impacted Files
Coverage Δ

Sources/Bitcoin/Bitcoin.swift
51.61% <100%> (+3.33%)
:arrow_up:

Tests/Bitcoin/BitcoinAddressTests.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/PublicKey+Bitcoin.swift
100% <100%> (ø)
:arrow_up:

Sources/Bitcoin/BitcoinSegwitAddress.swift
58.46% <58.46%> (ø)

Sources/Slip.swift
75% <75%> (ø)

Sources/Crypto.m
94.56% <92.3%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6556709...cfd3d28. Read the comment docs.

Codecov Report

Merging #61 into master will increase coverage by 0.05%.
The diff coverage is 79.26%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   81.41%   81.46%   +0.05%
==========================================
  Files          75       77       +2
  Lines        2965     3103     +138
==========================================
+ Hits         2414     2528     +114
- Misses        551      575      +24

Impacted Files
Coverage Δ

Sources/BlockchainFactory.swift
0% <0%> (ø)
:arrow_up:

Sources/Blockchain.swift
11.76% <0%> (ø)
:arrow_up:

Tests/SlipTests.swift
100% <100%> (ø)
:arrow_up:

Tests/Bitcoin/BitcoinAddressTests.swift
100% <100%> (ø)
:arrow_up:

Sources/Tron/Tron.swift
100% <100%> (ø)
:arrow_up:

Tests/CryptoTests.swift
100% <100%> (ø)
:arrow_up:

Sources/Crypto.m
95.6% <100%> (+0.66%)
:arrow_up:

Sources/Bitcoin/PublicKey+Bitcoin.swift
100% <100%> (ø)
:arrow_up:

Sources/Ethereum/Ethereum.swift
11.11% <14.28%> (ø)
:arrow_up:

Sources/Bitcoin/Bitcoin.swift
51.61% <60%> (+3.33%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6556709...cfd3d28. Read the comment docs.


Enhancement: Validate composer.json and composer.lock on Travis

This PR

[x] validates composer.json and composer.lock on Travis

💁♂ The advantage of doing this is that - since composer.lock is checked in - we can verify if it is up to date with composer.json.
For reference, see https://getcomposer.org/doc/03-cli.md#validate.

FYI: I just changed this PR against develop branch?

Thank you, @DjThossi!


Publish test

To be able to run the test prior to installation, as part of building a distro package.

Something like this may also be needed:
https://github.com/pexpect/ptyprocess/pull/22/commits/1fa2011142a200563a9b8fbf303a622ab643cff8

Will this include the examples?  Without them, the tests are broken.

Seems to work fine without.

Maybe so, but it wont test much.
https://github.com/myint/rstcheck/blob/master/test.bash#L9 is where the real tests are happening.


bug-fix-3.11/FE-374: Query UI - fix switching from table to JSON

Scope & Purpose
This happened due to a change in the version of the jsoneditor we are using. Only affects v3.11

[x] :hankey: Bugfix

Checklist

[x] Tests

[x] Manually tested

[x] :book: CHANGELOG entry made

Related Information

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/FE-374

[ ] https://jenkins01.arangodb.biz/job/arangodb-ANY-jslint/31107/


Let tensorNet have more than one input layer

Currently tensorNet only supports a single input  layer.  It should support multiple input layers.

up