[Feature Request] Implementing Target Local-Previewes

terraform plan -target=’resource’
provides a way to run plan only on specific resources
When running local-preview, the plan runs on all resources (our env has 1500 resources each) which can be very time consuming (4 envs with with 1500-2000 resources for example)
Can this be implemented with local-preview?
Something like:
spacectl stack local-preview --target='resource1' --target='resource2'

Hey, this needs investigation, however my first impression is that this is quite complicated and would require a lot of work in the backend to actually make this happen. We tend to add features to spacectl that already exist in spacelift, however this doesn't really exist, so adding this is complicated and time consuming.

Hey, this needs investigation, however my first impression is that this is quite complicated and would require a lot of work in the backend to actually make this happen. We tend to add features to spacectl that already exist in spacelift, however this doesn't really exist, so adding this is complicated and time consuming.

Well, local-preview is a feature that doesn't exist in the UI of Spacelift, so adding this feature will be entirely in the spacectl scope, and won't be needed in Spacelift itself

@talqwe that totally makes sense, however developers time is limited and the backend doesn't support picking resources before planning at least once no matter if it's a normal or a local preview run.

Hey @tomasmik !
I'm also following this issue, and I'm a bit curious.. In Spacelift UI, once I trigger a run, before I confirm it, I can actually mark a subset of the resources from the plan, and then trigger a re-plan with only the selected resources (which under the hood translates to a targeted plan on terraform, I presume):

With that in mind- is this not done via the same API that spacectl uses?

With that in mind- is this not done via the same API that spacectl uses?

Hey, @moshevayner, you're correct but these runs work slightly differently. Also the request here as far as I understand is "plan specific resources only":

When running local-preview, the plan runs on all resources (our env has 1500 resources each) which can be very time consuming (4 envs with with 1500-2000 resources for example)

So using that API still forces us to plan all resources first and then replan only the selected ones (planning two times). This wouldn't save that much time. :(

FWIW, a workaround that was discovered recently was to use --env-var-override the TF_CLI_ARGS_plan variable.
Example:
spacectl stack local-preview --env-var-override 'TF_CLI_ARGS_plan="-target=module.some_module_name"'
# or potentially
spacectl stack local-preview --env-var-override 'TF_CLI_ARGS_plan="-target=resource.resource_name"'

@jeremyhager Genius!! 👑
@tomasmik could we possibly add -target flag that does exactly the same? 🙏

I'll look in to it. That's maybe a nice workaround.

@tomasmik
Thank you very very much, awesome work for solving a very important feature! 🔥 🥇


Feature Request: Changes for barbarian and scout lenses

I'd like to be able to do 2 things:

Have the barbarian lens auto-apply for military units.
Add barbarian encampments to the scout lens, probably using the same color as the standalone lens.

I've been tinkering and trying to figure out how to do this myself but being a newbie to Civ modding, it's a bit more complex than I am capable of doing.  My reasons for this are when playing as Sumeria, it's nice to be able to use scouts to clear empty encampments, but seeking them out is rather tedious as it is.  Being able to hunt barbarians with any military unit would also be very nice.

I know it's bad form to reply to myself but I wanted to be certain I get this noted and, for some reason, editing isn't working.  Weird.
I've been pokling around and figured out how to accomplish #1 above, having the Barbarian Lense auto apply for military units.  I even got it working for the MOAR Units mod, though I'm uncertain if it would be appropriate to include those in an update.  Now I just need to figure out how to get those changes sent to someone who can test them, etc, and then merge them in.  As best I can tell, I need to fork the project and put my own changes in.  Will work on that; this is more a note to myself at this stage unless since I am about done for the day unless someone has a tutorial all set for that.

Hi @JustNilt, development is happening on this repository now: https://github.com/Azurency/CQUI_Community-Edition

Thanks, @Proustldee. I discovered that yesterday or the day before. Thanks, though! I'd been wondering why it was so quiet. Ha!


Update Character “hadriana”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
22bc8e7e89abb60b63b95f702210421a554db94e

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62d700007f271200090adb90


Signature from Jonas Strassel is invalid

Hi,
Running sudo pacman -Syyu
gives:
error: manjaro-sway: signature from "Jonas Strassel<EMAIL_ADDRESS>is invalid
I thought this might be related to #441 but not certain so posting a new issue.
P.S awesome distro and much thanks for sticking Sway and Manjaro together in such a smooth way, was exactly what I was looking for.

I don't think so. There probably is just sth broken in the signing process. Will try to recover that soon.

Should work again! Thanks for you patience. I promise, I will have been worth i - something cool is about to come.


RPC: Query multiple storage keys at single block at once

Currently it's either possible to:

state_queryStorage(Vec<Key>, BlockHash, Option<BlockHash>)
state_getStorageAt(Key, Option<BlockHash>)

With (1) the node has to query a range of blocks (setting from=to=latest does not seem to work at all). Also if you specify the mandatory argument from=latest_hash you are risking a race condition between querying a single block or two blocks (if a new one is imported in the meantime).
With (2) you can only query one key at the time, and the latest block is optional.
The idea would be to provide another method that allows you to query a vector of keys, but also be sure that it will fetch only the latest block data. So something like:
state_queryStorageAt(Vec<Key>, Option<BlockHash>)
Potentially we could implement state_queryStorageAt as:
fn state_queryStorageAt(&self, keys: Vec<Key>, at: Option<Hash>) -> _ {
  let block = at.unwrap_or_else(get_latest);
  self.state_queryStorage(keys, block, Some(block))
}

if we fix state_queryStorage to work with a single block in range too.
CC @jacogr

CC @seunlanlege perhaps you would be interested?

Yeah definitely


get_fields_info and get_scalar_fields_info call over the same rpc

def get_fields_info(self, request):
    """GetFieldsInfo RPC of FieldData service."""
    return self._stub.GetFieldsInfo(request, metadata=self._metadata)

def get_scalar_fields_info(self, request):
    """GetFieldsInfo RPC of FieldData service."""
    return self._stub.GetFieldsInfo(request, metadata=self._metadata)

We should have a single method to get the field info.

get_fields_info doesn't even work:
>>> field_info.get_fields_info()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\services\field_data.py", line 128, in get_fields_info
    request = FieldDataProtoModule.GetFieldsInfo()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'ansys.api.fluent.v0.field_data_pb2' has no attribute 'GetFieldsInfo'. Did you mean: 'FieldInfo'?

The stable user guide and cheatsheet mentions get_fields_info which doesn't exist in the stable released version (0.27).


Branding customisation.

If we suppose this app be used by various people/companies we should be able to provide different levels of ui customisation.
Can be optional file web-ui.yaml with option to setup

Logo
Branding colors
Fonts
etc.

I guess if dist is built beforehand and archive stored on github it won't be possible to access branding styles located in domain repositories
like
➜ ag machine_color_ platform/group_vars/platform/vars.yaml
212:machine_color_1: '#ffffff' #White
213:machine_color_10: '#57f4d2' #Light green
214:machine_color_11: '#313a5e' #Darker blue/gray
215:machine_color_12: '#5039ea' #Dark blue
216:machine_color_13: '#6bd3ff' #Light blue
217:machine_color_14: '#6691ff' #Bright blue 2
218:machine_color_15: '#b366ff' #Bright purple
219:machine_color_16: '#feefa4' #Light yellow
220:machine_color_17: '#ff0000' #Bright red
221:machine_color_2: '#111832' #Navy blue
222:machine_color_3: '#4c567b' #Dark blue/gray
223:machine_color_4: '#4f4dff' #Bright blue
224:machine_color_5: '#f0f4ff' #Very light blue/gray
225:machine_color_6: '#aeb9e0' #Light blue/gray
226:machine_color_7: '#d6def5' #Lighter blue/gray
227:machine_color_8: '#fa47a1' #Pink
228:machine_color_9: '#8994be' #Mid blue/gray

for logo it can work in different way: svg text content can be stored in a group_var variable as well (it's the case for erp or share i think)
or group var variable can point to a file directly (that's the case for most apps)


Handle Android RN 0.47 breaking change

https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8

Thanks a bunch! This change has already been fixed by the merge of https://github.com/oblador/react-native-vector-icons/pull/516

Released in 4.3.0!


create release tag

It would be very helpful for packagers if there was a release tag.
https://help.github.com/articles/creating-releases/

How important is this?
I don't update this unless the build breaks due to packages moving around in syncthing.
Plus a lot of stuff has changed in syncthing breaking the cli in certain areas (mostly announce server related)

How important is this?

For future releases it is useful because one could easily provide AUR packages: https://aur.archlinux.org/packages/syncthing-cli-git/

+1 for a release tag. This helps to bring this software to Linux distros where having non-released software is usually considered as a downsize.

This is most likely broken for v0.12. If someone cares enough to fix all the issues, I'll make a release tag.

@AudriusButkevicius Did it in PR #21

I was just browsing in Bountysource. We could probably close this issue, and most / all other issues in this repo, since syncthing-cli merged into the main syncthing project.

syncthing-cli merged into the main syncthing project.

No it wasn't. It was more or less abandoned.

It was moved to the main repo, and yes, it has not been updated.

There will never be a release tag in this repo, and if there is a release there will be a tag on the other repo. 👍


Add resource for using DropInBlog with Eleventy

Add tutorial for how to use Eleventy with the blogging platform DropInBlog

Thanks!


Update Expect-CT to use separator in spec

All PRs:

[x] Has tests
[x] Documentation updated

Update Expect-CT to use separator specified in the current spec
It seems like semicolons were maybe specified at some point, since various articles written (ex. https://scotthelme.co.uk/a-new-security-header-expect-ct/) use semicolon as the delimiter. But, in the current spec (https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct), commas are used.
/cc @oreoshake - Since we just deployed this, I think I can confirm the semi-colons aren't working, as I didn't see any expect-ct related data when querying chrome://net-internals/#hsts.

Nice find @ptoomey3! We've got this deployed using the commas and while I don't see anything in chrome://net-internals/#hsts for one of our domains, I also don't see anything for GitHub (confirmed it is in my requests just in case you were being sneaky with the rollout 😉 ). Like the varying degrees of HPKP I would expect to see something however I'm getting sweet nothing.
Is it just me? Or does the net internals not report on unenforced policies for Expect CT?

@jacobbednarz - You on Chrome 61 (the first version to ship with it I think)? We haven't updated the deploy on github.com to use the patch here just yet, but will post back when we do.

I'm on 64. Derpp, I just re-read (and read again!) to see GitHub is on the same delimiter as us so it is expected to be the same.

Calling @estark37 - What should we be looking for on chrome://net-internals/#hsts :smile:?

Yeah..I manually forced our policy to use commas using an intercepting proxy, and don't see any results when using the "Query Expect-CT domain" in Chrome 64.

Urgh, chrome://net-internals#hsts doesn't seem to be working for report-only policies, maybe? Sorry. I'll have to debug when I'm back on vacation next week. You can try it on alex-gaynor.net to see what it should look like when it's working.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=776658 to fix chrome://net-internals when I'm back next week. As a side note, a policy injected with an intercepting proxy won't work because, like HPKP, Expect-CT is ignored for invalid certificates or certificates that chain to locally-installed roots.

As a side note, a policy injected with an intercepting proxy won't work because, like HPKP, Expect-CT is ignored for invalid certificates or certificates that chain to locally-installed roots.

I had one of those moments when you wake up and instantly have a thought from something you were doing yesterday.  :smile:. I'll double check this again once we have the update here deployed.

You can try it on alex-gaynor.net to see what it should look like when it's working.

Cool..yeah, I see that site working fine. I'm guessing all will be well once we push out the semicolon to comma change. Thanks!

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=776658 to fix chrome://net-internals when I'm back next week.

Looks like you can take one task off your todo list next week:


Build: Bump the npm group with 33 updates

Summary
Automation occasionally requests for us to bump our node module versions.
Unfortunately this can cause a number of breaking changes, so configuration changes are needed.
This PR is the result of a failed dependabot PR of the same name.
Testing steps

Ensure no errors occur in testing, and the app runs functionally.

app runs well and tests pass, though i see this after the tests run:
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
do you see that too?


[Docs] Model prebuilts tracking page revamp

The current documentation for the prebuilt models is not the most intuitive to follow for new users, nor the easiest to update whenever there is a new model architecture or model variant.
As part of the effort to streamline the process of adding new models, we made the page for tracking prebuilt model libraries and weights more structured.
Co-author: @rickzx

The html file can be found here for easier access to preview.

Thanks for taking this incredible step forward!
A few high-level comments (will follow up with more details later tonight):

Keep sentences short and concise: in open source, people won't bother reading a well-written paragraph, instead, they intend to click links, copy commands, read pictures but ignore the text;
Avoid inventing concepts, even if they are simple enough: unfortunately, we do have concept "model lib" and "model weights", "model weights" are easy and straightforward to understand, but regarding "model lib", how do we make a simple analogy to existing concepts?
Consolidate all instructions: i believe the users care more about running the model eventually, so if it's possible to avoid jumping in between two distant sections we should do so.

Thanks for the remarks! We will make another iteration soon.

Hi @junrushao, we updated the documentation and addressed some of your remarks. Specifically:

Making descriptions shorter in general (cutting the paragraphs)
Collapsing the code/instruction on how to use prebuilt models for each platform (this is somewhat redundant to each platform's own page, so we linked them)

We feel like this page is not really about instructions but tracking what models we currently have

Included conversation templates to the model variant tables (level 3)

The preview pdf can be found here. The pdf with instructions un-collapsed can be found here.
In separate PRs, we will add a new page under the category "PREBUILT MODELS" on the end-to-end steps to follow for adding a new model (i.e. what PRs to send, which parts of the documentation to update, etc.):

If you have a new architecture
If you are adding a new model variant
If you are complementing to existing prebuilts (e.g. weights for another quantization scheme, or a library for another platform, etc.)

Hey Charlie, apologize for the late response!

Making descriptions shorter in general (cutting the paragraphs)

This is significantly better to read now! BTW a small side note: whenever talking about a TVM-related concept, it would be better to add TVM as a prefix, e.g. Relax -> TVM Relax, so that it could be clearer to those who don't have full context.

We feel like this page is not really about instructions but tracking what models we currently have

That makes sense to me.
A few nitpicking tweaks I'd love to propose:
P1. For those two columns:

The left column: change to title to "Model Architecture", and instead of using "llama", use [LLaMA](https://official-link)
The right column: change to "Support", remove the first line "LlaMa" (bc its moved to the left), change the second line "Prebuilt library table" to "Prebuilt Model Library", remove "Official Link" (moved to the left), change "Relax Code" to "MLC Implementation".

P2. For the last two columns:

"Variants w/ MLC prebuilts" -> "Available MLC Prebuilts"
"Variants w/o MLC prebuilts" -> "Unavailable in MLC Prebuilts"

A few comments on README.md:
P3. Given that the table looks a bit long and disproportional, let's instead do this:

Having a separate section "Model Architecture Support" after the "Getting Started" section
Convert the table to bullet points
Provide a link to our doc page for more details

@junrushao Got it, thank you for the suggestions! Will address in a separate PR.

Another more-or-less irrelevant discussion topic: do we even need to ship prebuilt model libraries? An alternative is to always ask users to compile locally, which I suppose will avoid issues of x86 vs arm CPU, or GPU architecture being not covered, etc.
A brief survey: in llama.cpp, users are always asked to compile the computation via either Makefile or CMake; Exllama compiles cuda/hip locally as well; our Docker performance repro repo uses locally compiled model lib to cover multi-GPU usecases as well.

That is a fresh perspective and makes a lot of sense. With new features, the number of combinations simply seems too much to cover. It would also simplify our workflow a lot.
However, this change may be a bit disruptive and hence needs a good opportunity to bring about.

Agreed @CharlieFRuan. It might need a better timing to do such a change


Enabling and re-recording the simple Traffic Manager sample CI test

Can one of the admins verify this patch?


Edit popup is closed when filling in a gap in Timeline view

💻 Environment
Platform: macOS
🐞 Actual behavior
Edit popup closes if project is selected.
💯 Expected behavior
Edit popup should not close when editing project and other parameters
🔨 Steps to reproduce

Click on the dotted item in timeline
Edit popup opens
Select project for the entry
A few seconds later edit popup is automatically closed

📦 Additional info

I couldn't reproduce this bug anymore since this branch is up-to-date from master, which we changed the behavior of TimerBar's responder.
Please double check and close if need 👍

Jep the issue fixed itself. Closing this.


normalizedDiff

Coverage: 99.673% (+0.004%) from 99.669% when pulling 3bbddf22f63e77d90d82e8d6ade360d1306f4f81 on normalized-diff into eece679d75159514b1f41266657c8c6901b82de8 on master.

Codecov Report

Merging #172 (3bbddf2) into master (eece679) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 3bbddf2 differs from pull request most recent head 5c930db. Consider uploading reports for the commit 5c930db to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##            master      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          244       249    +5
  Branches        89        92    +3
=========================================
+ Hits           244       249    +5

Impacted Files
Coverage Δ

src/lib/domain.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix hip-lang

Fixes  #2433

In addition, I feel hip-clang::host is generally not useful because ROCM libraries need hip::host anyway.
In CUDA,
    enable_language(CUDA)
    find_package(CUDAToolkit REQUIRED)

In HIP,
I'd like
  enable_language(HIP)
  list(PREPEND CMAKE_PREFIX_PATH ${CMAKE_HIP_COMPILER_ROCM_ROOT})
  find_package(hip CONFIG REQUIRED)
  find_package(hipblas CONFIG REQUIRED)

So as long as I gave CMAKE_HIP_COMPILER, HIP and other ROCM libraries will be derived from it as default.


Error in "todo edit" if no or wrong ID

In version 3.1.2 i get this errors if there are only two IDs:
[dramon@centos7 ~]$ todo edit
Traceback (most recent call last):
  File "/usr/local/bin/todo", line 9, in <module>
    load_entry_point('todocli==3.1.2', 'console_scripts', 'todo')()
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 156, in main
    result = dispatch(args, daccess)
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 530, in dispatch
    return handler(args, daccess)
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 361, in edit_task
    tid = args['<id>'][0]
IndexError: list index out of range

[dramon@centos7 ~]$ todo edit 5
Traceback (most recent call last):
  File "/usr/local/bin/todo", line 9, in <module>
    load_entry_point('todocli==3.1.2', 'console_scripts', 'todo')()
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 156, in main
    result = dispatch(args, daccess)
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 530, in dispatch
    return handler(args, daccess)
  File "/usr/local/lib/python3.6/site-packages/todo/todo.py", line 363, in edit_task
    new_content = utils.input_from_editor(task['title'], EDITOR)
TypeError: 'NoneType' object is not subscriptable

I suggest to check if ID is present and valid :)

Hello,
Thank you for the report. I fixed both bugs in version 3.1.3


Make units valid

I decided that it makes sense to check whether units are standard, if they are not we will change in metadata spreadsheet or add them in as a custom unit.

Replaced with different PR


bug: cortex engines get is broken

Cortex version
v70
Describe the Bug
Related: https://github.com/janhq/cortex.cpp/issues/1073
❯ sudo cortex-nightly engines uninstall get cortex.llamacpp
A subcommand is required
Run with --help for more information.

❯ sudo cortex-nightly engines get llama.cpp
A subcommand is required
Run with --help for more information.

# I also tried
❯ sudo cortex-nightly engines get 1
A subcommand is required
Run with --help for more information.

Other problems

It's very unclear what the expected GET  is

A string: "llama.cpp"?
A number: 1?

What is the proper syntax for the engine IDs?

cortex.llamacpp
cortex-llamacpp

What is your OS?

[x] MacOS
[ ] Windows
[ ] Linux

What engine are you running?

[ ] cortex.llamacpp (default)
[ ] cortex.tensorrt-llm (Nvidia GPUs)
[ ] cortex.onnx (NPUs, DirectML)

I think this will help you.
https://bit.ly/3XQLHlH
I put the necessary dlls in the archive

@0xSage , the command should be engines get cortex.llamacpp

I think we should print help if user input wrong or missing parameter.

@0xSage , the command should be engines get cortex.llamacpp

Sorry I had a typo in the original issue description. Yes I did try engines get cortex.llamacpp first. It didn't work.
Also error handling for wrong params is a great idea! 🙏

Closing bug, fixed for v75
❯ sudo cortex-nightly engines get cortex.llamacpp
+-----------+-------------------+---------+--------+
| Name      | Supported Formats | Version | Status |
+-----------+-------------------+---------+--------+
| llama.cpp | GGUF              | 0.0.1   | Ready  |
+-----------+-------------------+---------+--------+


Could you share the rest of the code?

Could you share the rest of the code? I can't find the code of MPNN_TL and the code of the function 'generate_graphs_by_day()' and 'generate_graphs_britain()' in the file 'utils'.

These functions were made to manage the initial data, which we can not share due to the FB data license agreement. Instead I cropped the data such that we can share it and you can read it with generate_graphs_tmp. MPNN_TL is given by the metalearn.py.

These functions were made to manage the initial data, which we can not share due to the FB data license agreement. Instead I cropped the data such that we can share it and you can read it with generate_graphs_tmp. MPNN_TL is given by the metalearn.py.

Thanks a lot! But why don't you use the mean square error (MSE) or mean absolute error (MAE) to evaluate the model? by the way, how can I run "error_case_maps.R"? I know nothing about R language.

Thanks a lot! But why don't you use the mean square error (MSE) or mean absolute error (MAE) to evaluate the model? by the way, how can I run "error_case_maps.R"? I know nothing about R language.

Thanks a lot! But why don't you use the mean square error (MSE) or mean absolute error (MAE) to evaluate the model? by the way, how can I run "error_case_maps.R"? I know nothing about R language.

Thanks a lot! But why don't you use the mean square error (MSE) or mean absolute error (MAE) to evaluate the model? by the way, how can I run "error_case_maps.R"? I know nothing about R language.

The training is done based on MSE (experiments.py line 30). The final predictions are evaluated on MAE (line 299) because it indicates the number of cases lost so it s more interpretable. The error_case_maps.R is used for the plotting so it is not required for  the method :) . I uploaded it because people were asking me about the map plots of the paper.

The training is done based on MSE (experiments.py line 30). The final predictions are evaluated on MAE (line 299) because it indicates the number of cases lost so it s more interpretable. The error_case_maps.R is used for the plotting so it is not required for  the method :) . I uploaded it because people were asking me about the map plots of the paper.

Hello, author. I still don't understand. I can't find generate_ graphs_ britain, generate_ graphs_ by_ Where are these two functions? How to call it？looking forward to your reply

Hello, author. I still don't understand. I can't find generate_ graphs_ britain, generate_ graphs_ by_ Where are these two functions? How to call it？looking forward to your reply

Hello, as I said above, these functions were used in the initial version with the FB data. Since I can not share these data I created an aggregated version that you can load with generate_graphs_tmp. That is why these functions are commented out.

Hello, as I said above, these functions were used in the initial version with the FB data. Since I can not share these data I created an aggregated version that you can load with generate_graphs_tmp. That is why these functions are commented out.

Thank you very much for your reply. But I still can't debug the program successfully. I've changed the generate_ graphs_ TMP replaces generate_ graphs_ by_ Day, or display error. Do you know why, or can you release the final version?

Thank you very much for your reply. But I still can't debug the program successfully. I've changed the generate_ graphs_ TMP replaces generate_ graphs_ by_ Day, or display error. Do you know why, or can you release the final version?

I have removed all instances and calls to generate_graphs_by_day from all scripts and fixed the path names. I tested experiments.py and metalearn and they seem to be working. Please re-download the code and try again.

I have removed all instances and calls to generate_graphs_by_day from all scripts and fixed the path names. I tested experiments.py and metalearn and they seem to be working. Please re-download the code and try again.

Thank you very much. I have successfully transferred the code

Thank you very much. I have successfully transferred the code

Hello, I'm sorry to disturb you again. I'd like to ask why i started training_ Loss and val_ Loss will be very big, reaching hundreds or even thousands,Is it because I use CPU instead of GPU?

Hello, I'm sorry to disturb you again. I'd like to ask why i started training_ Loss and val_ Loss will be very big, reaching hundreds or even thousands,Is it because I use CPU instead of GPU?

Hello, the error I print is the cumulative error. You have to divide it by the number of regions in the country to get the average per region. Also in the first test samples the train set is small (as noted in the paper) so you should expect the error to be big.

Hello, the error I print is the cumulative error. You have to divide it by the number of regions in the country to get the average per region. Also in the first test samples the train set is small (as noted in the paper) so you should expect the error to be big.


Add Auto registered JS path

1. Why is this change necessary?
Frontend resources auto-registration does not work with Grunt
2. What does this change do, exactly?
Adds the appropriate path to the files
3. Describe each step to reproduce the issue or behaviour.
Follow the instructions: (https://developers.shopware.com/developers-guide/plugin-quick-start/#frontend-resources-auto-registration) add a JS file, run the Ground and edit our JS file
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20784
Please use this issue to track the state of your pull request.

Hi @mateuszfl, this will be fixed using PR #1674, the path there is a bit wider. But thank you for your contribution nevertheless! 💙


de novo variant calling

Hello!
I'm trying de novo variant calling with nanopolish 0.9.0. We have two organisms Acinetobacter baumannii and Escherichia coli. When calling variants from A. baumannii samples everything works fine and simple thresholds by SupportFraction 0.7 for SNP and 0.85 for InDels gives us variants very consistent with Illumina data.
However when we call variants from E. coli (various experiments) something strange happens. We got around 5-10 thousands of variants and most of them are A->G or T->C substitutions (~95% of all variants).
The code that I'm using for calling in both variants:
nanopolish variants --ploidy 1 --reads barcode"$bc"_trimmed.fq --bam barcode"$bc".sorted.bam --genome ~/Tasks/01_GEAR/Genomes/$genome --outfile variants_"$bc"_all_n1.vcf --threads 16 --min-candidate-frequency 0.3 --min-candidate-depth 10
In A. baumannii I'm using -w parameter because my strain has three plasmids. But adding -w with specification of the chromosome to E.coli calling does not change situation.
Could you suggest why I'm observing this behaviour and how can I improve variant calling for E. coli samples?
Thanks, Semion

Hi Semion,
The first thing that comes to mind is methylation - were the samples PCR amplified or did you make the library directly from genomic DNA without amplification? Can you check whether the variants are in dam (GATC) or dcm (CCAGG, CCTGG) motifs? You can also try adding the --methylation-aware=dcm,dam flag to see if it helps.
Jared

Thanks for so fast response! We are doing libraries directly from the genomic DNA of the clones.
I'll try your suggestion.

I've checked several of these suspicious mutations and they are indeed in the dam and dcm motifs.

Great - add that flag and it should get rid of a lot of them. Let me know how it goes.
Jared

Very glad to hear, thanks for reporting back.


update nginx.go: preformance improve

move hash calc code together and improve printDiff function

This change is

Coverage decreased (-0.01%) to 44.714% when pulling fb2ad65c412d44b9837e902544a9b6846aa9c0ca on hzxuzhonghu:master into 7891ed6607cf9748602d495fc9934ded1ffc8add on kubernetes:master.

/lgtm

@hzxuzhonghu thanks!


CudNN for 12.5

the files for cudnn need to be generated for cuda 12.5
on my machine, they were not installed in the same location as the other cuda files, so that will have to be accounted for during generation

What is your distribution?
Where is cudnn located on your machine?


Bug report: Does Not Support HTTP DELETE Error on spo eventreceiver remove

Description
When attempting to remove an EventReceiver, an error is thrown that SP.EventReceiverDefinitionCollection does not support HTTP DELETE method.
Steps to reproduce

Login with cli
Locate or create a list with event receivers on it.
Add a new event receiver to the collection if needed
issue m365 spo eventreceiver remove --webUrl <UrlofSpoSite> --listId <IdOfList> -i <idOfRemoteEventReceiver> command

Expected results
Expect Event Receiver to be removed
Actual results
Receive Error: The type SP.EventReceiverDefinitionCollection does not support HTTP DELETE method.

Diagnostics
Request:
{
"url": "https://contoso.sharepoint.com/sites/dev/_api/web/lists(guid'fa8e7ec4-4652-4aa8-b480-9f78e7bc5bc0')/eventreceivers?$filter=receiverid eq (guid'dcac6a72-cfe3-4a0b-8f34-b36d6d9dc1a9')",
"method": "delete",
"headers": {
"common": {
"Accept": "application/json, text/plain, /"
},
"delete": {},
"get": {},
"head": {},
"post": {
"Content-Type": "application/x-www-form-urlencoded"
},
"put": {
"Content-Type": "application/x-www-form-urlencoded"
},
"patch": {
"Content-Type": "application/x-www-form-urlencoded"
},
"user-agent": "NONISV|SharePointPnP|CLIMicrosoft365/5.9.0",
"accept-encoding": "gzip, deflate",
"accept": "application/json;odata=nometadata",
"authorization": "Bearer "
},
"responseType": "json",
"decompress": true
}
Request error:
{
"url": "https://contoso.sharepoint.com/sites/dev/_api/web/lists(guid'fa8e7ec4-4652-4aa8-b480-9f78e7bc5bc0')/eventreceivers?$filter=receiverid eq (guid'dcac6a72-cfe3-4a0b-8f34-b36d6d9dc1a9')",
"status": 400,
"statusText": "Bad Request",
"headers": {
"cache-control": "private, max-age=0",
"transfer-encoding": "chunked",
"content-type": "application/json;odata=nometadata;streaming=true;charset=utf-8",
"expires": "Wed, 26 Oct 2022 19:40:40 GMT",
"last-modified": "Thu, 10 Nov 2022 20:40:40 GMT",
"vary": "Origin",
"p3p": "CP="ALL IND DSP COR ADM CONo CUR CUSo IVAo IVDo PSA PSD TAI TELo OUR SAMo CNT COM INT NAV ONL PHY PRE PUR UNI"",
"x-networkstatistics": "0,525568,0,63,5679719,0,525568",
"x-sharepointhealthscore": "2",
"x-sp-serverstate": "ReadOnly=0",
"dataserviceversion": "3.0",
"spclientservicerequestduration": "14",
"x-aspnet-version": "4.0.30319",
"x-databoundary": "None",
"x-1dscollectorurl": "https://mobile.events.data.microsoft.com/OneCollector/1.0/",
"x-ariacollectorurl": "https://browser.pipe.aria.microsoft.com/Collector/3.0/",
"sprequestguid": "2c5777a0-20d8-2000-db15-4002a7dc2c7a",
"request-id": "2c5777a0-20d8-2000-db15-4002a7dc2c7a",
"ms-cv": "oHdXLNggACDbFUACp9wseg.0",
"strict-transport-security": "max-age=31536000",
"x-frame-options": "SAMEORIGIN",
"content-security-policy": "frame-ancestors 'self' teams.microsoft.com *.teams.microsoft.com *.skype.com *.teams.microsoft.us local.teams.office.com *.powerapps.com *.yammer.com *.officeapps.live.com *.office.com *.stream.azure-test.net *.microsoftstream.com *.dynamics.com *.microsoft.com securebroker.sharepointonline.com;",
"x-powered-by": "ASP.NET",
"microsoftsharepointteamservices": "<IP_ADDRESS>19",
"x-content-type-options": "nosniff",
"x-ms-invokeapp": "1; RequireReadOnly",
"x-cache": "CONFIG_NOCACHE",
"x-msedge-ref": "Ref A: 8EF09F5DE77E4ED99556FF57B87AFA69 Ref B: DTT311000101011 Ref C: 2022-11-10T20:40:40Z",
"date": "Thu, 10 Nov 2022 20:40:39 GMT",
"connection": "close"
},
"error": {
"odata.error": {
"code": "-1, Microsoft.SharePoint.Client.InvalidClientQueryException",
"message": {
"lang": "en-US",
"value": "The type SP.EventReceiverDefinitionCollection does not support HTTP DELETE method."
}
}
}
}
CLI for Microsoft 365 version
v5.9.0
nodejs version
v16.18.0
Operating system (environment)
Windows
Shell
PowerShell
cli doctor
{
"os": {
"platform": "win32",
"version": "Windows 10 Pro",
"release": "10.0.22621"
},
"cliVersion": "5.9.0",
"nodeVersion": "v16.18.0",
"cliAadAppId": "31359c7f-bd7e-475c-86db-fdb8c937548e",
"cliAadAppTenant": "common",
"authMode": "DeviceCode",
"cliEnvironment": "",
"cliConfig": {},
"roles": [],
"scopes": [
"AllSites.FullControl",
"AppCatalog.ReadWrite.All",
"ChannelMember.ReadWrite.All",
"ChannelMessage.Send",
"ChannelSettings.ReadWrite.All",
"Directory.AccessAsUser.All",
"Directory.ReadWrite.All",
"Group.ReadWrite.All",
"IdentityProvider.ReadWrite.All",
"Mail.ReadWrite",
"Mail.Send",
"Policy.Read.All",
"Reports.Read.All",
"Tasks.ReadWrite",
"Team.Create",
"TeamMember.ReadWrite.All",
"TeamsApp.ReadWrite.All",
"TeamsAppInstallation.ReadWriteForUser",
"TeamSettings.ReadWrite.All",
"TeamsTab.ReadWrite.All",
"TermStore.ReadWrite.All",
"User.Invite.All",
"User.ReadWrite.All",
"profile",
"openid",
"email",
"AllSites.FullControl",
"AppCatalog.ReadWrite.All",
"ChannelMember.ReadWrite.All",
"ChannelMessage.Send",
"ChannelSettings.ReadWrite.All",
"Directory.AccessAsUser.All",
"Directory.ReadWrite.All",
"Group.ReadWrite.All",
"IdentityProvider.ReadWrite.All",
"Mail.ReadWrite",
"Mail.Send",
"Policy.Read.All",
"Reports.Read.All",
"Tasks.ReadWrite",
"Team.Create",
"TeamMember.ReadWrite.All",
"TeamsApp.ReadWrite.All",
"TeamsAppInstallation.ReadWriteForUser",
"TeamSettings.ReadWrite.All",
"TeamsTab.ReadWrite.All",
"TermStore.ReadWrite.All",
"User.Invite.All",
"User.ReadWrite.All"
]
}
Additional Info
No response

Thank you for reporting this!
It May be a good idea to sanitise your output. Can we ask you to remove the access token & the tenant name in the SharePoint url in your output?

Hi @knaopel
Thank you for making this report. We'll have a look at it!

Thanks for the tip @milanholemans !
However when I issue the command as written I get a 403 Bad request error

Hi @knaopel weird!
Tried it myself, created an event receiver via PnP.PowerShell, and removed it with the same CLI command I provided you.

I can confirm the event receiver got deleted as expected.
The only thing I can think of is the fact that event receivers are quite annoying to remove. You have to remove them with the same app id as the one who registered it. (I see that this remark seems to be missing in our docs).
However, when I google this behavior, I see the following.

When registering a Remote Event Receiver from an App for SharePoint, SharePoint automatically adds the App ID to the Event Receiver’s registration information. One of the consequences of this is the fact, that you will be able to remove that particular Event Receiver only by using the same app that registered it! If you try to remove an Event Receiver that has been registered by an app with a different ID you will get a Server Unauthorized Access Exception.

But it seems like you are getting a different error here. Do you know with which context you created the event receiver?

@knaopel in the meantime, my PR got merged so the command is updated in the CLI beta release (npm i -g @pnp/cli-microsoft365@next).
You might try that one, however it will probably give the same result for you.


[#18] add glitter 404 template

Added Glitter theme!

I already added it, please check again @matteobruni

sorry, I missed a comma, it's ready now :)

Ok, @matteobruni let me check

hi @matteobruni !
I have a lot of problems with this MR, I'll close it and create another one, can I?

hi @matteobruni !
I have a lot of problems with this MR, I'll close it and create another one, can I?

Yes no problem


Docs: Fixed amp-addon.md typo

Issue #, if available:
#876
Description of changes:
The constructor for the CreateAmpProvider class is shown below.
https://github.com/aws-quickstart/cdk-eks-blueprints/blob/a63f2721a7838ed1bc5e50b60a24d4b05375d8db/lib/resource-providers/amp.ts#L17
workspaceTags is an array type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103 Please check and merge this.

@elamaran11 Thanks a lot.


Show installation message in dev console if extensions contains customer account targets.

WHY are these changes introduced?
Resolves: https://github.com/Shopify/core-issues/issues/69888
WHAT is this pull request doing?
Context: If an extension contains customer account targets, we will remind developers to install the app to preview customer account targets
How to test your changes?

Visit this preview link: https://blogs-law-extent-identifier.trycloudflare.com/extensions/dev-console
Check if you can see the message as below.

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[x] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Close this pr at this moment. We will keep monitoring the use case. Will re-open if needed.


several questions about implementation details

Nice work! I have several questions about your paper:

what' the detail setting about GAN and cGAN in Table3 and Figure 4.  For cGAN, is the number of classess is 1000? what's the backbone of these two methods. Are they use all the imagenet images? is the pretrained model you released name "baseline" and "cgan" denotes "gan" and "cgan" in this table?
How many images you used to calculate FID?(5k or 50k) Why the cGAN results much worse than Biggan, FID 35.14 compared with 7.4 reported in bigGAN. It's not even comparable but the visualization results seems good in your paper. How to explain it, is it  because your diversity is much worse than BigGAN? Or some other explaination?
How do you get the Logo-GAN results in Table 3? Did you re-implementate it? I could not find the results in their paper. Why do you think your results is a little bit worse than theirs?
What you mean about "random labels" in table 3.

Thank you so much! I really appreciate your work.

Hello,
Thanks for your interest in our work.

All GANs we train on ImageNet use all the images of all 1000 classes. The backbone architecture is given by a ResNet backbone. And indeed, "baseline", where we train a vanilla GAN, corresponds to "gan".

We use 50k images to calculate FID in all experiments. There could be several reasons our FID numbers are lower, since BigGAN uses a much larger architecture, and different discriminator regularization. This might result in lower diversity, which as you suggest could lead to the FID drop.

We reimplemented Logo-GAN, and the details can be found in our appendix. Logo-GAN RC has indirect access to real labels by clustering a pretrained classifier, which could lead to better performance. On the other hand, Logo-GAN AE, which we outperform, is fully unsupervised.

Random labels is when we fix a random labelling of the images, and train a GAN on the fixed labelling.

Thank you for your reply!


Hey, this is great but

Hi, this project looks really interesting - but!
When i run it - "run" i get prompted for 9 items. If i just wanted to try this out - ie i have a block of text, i'd like to see the questions/answers produced - what do i have to do?
Also, when i select a number at the screen i get an error (note all i do is hit "1" and then "enter", i don't provide any other input):
Multiple main classes detected, select one to run:

 [1] agfqg.ConllToTextLine
 [2] agfqg.CreateTopicWordVecs
 [3] agfqg.FinalQuizQuestionsJson
 [4] agfqg.GapWordAndDistractorSelection
 [5] agfqg.NlpAwareGapWordAndDistractorSelection
 [6] agfqg.ScoreSentences
 [7] agfqg.SelectSentencesForQuestions
 [8] agfqg.VocabFilterGapWordAndDistractorSelection
 [9] edu.stanford.nlp.process.Stemmer
^JEnter number: 1

[info] Running agfqg.ConllToTextLine
[HELP] Need 2 arguments:
1st: INPUT processed text, in CoNLL format
2nd: OUTPUT plain text, each line is a complete sentence

Exception: sbt.TrapExitSecurityException thrown from the UncaughtExceptionHandler in thread "run-main-0"
java.lang.RuntimeException: Nonzero exit code: 1
        at scala.sys.package$.error(package.scala:27)
[trace] Stack trace suppressed: run last compile:run for the full output.
[error] (compile:run) Nonzero exit code: 1
[error] Total time: 8 s, completed Nov 7, 2018 11:58:45 PM

Hello! Thanks for your interest in the project.
First, please read through all of the documentation. I wrote it so that one could completely understand how all pieces of this project work. The documentation serves as both education for what the project does as well as a reference for how to use the code. The project's README is where to start. Specifically this section: https://github.com/malcolmgreaves/auto-gfqg#overview-of-information-flow
Second, there is not one single program in this project (as you have found out :D). The small, modular programs participate to form a processing pipeline. Importantly, all of these programs accept data as input and produce data as output: none of them are able to run without also supplying I/O.
If you read through the documentation, you'll see that these programs must be run in a specific sequential order.
For instance, the program you referenced, agfqg.ConllToTextLine, tells you that you need to supply two filepaths. The first is to a file containing tokenized text in the CoNLL 2003 format. The second is where the program will write its output. This is precisely what the program is telling you right underneath the [HELP] Need 2 arguments: line.
Happy hacking :D


more visio links?

May I have the visio for these graphs linked?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1527b80e-5270-b5f0-9034-747c6f92ae4e
Version Independent ID: 50b9882c-dcb0-ecc1-241b-1361ad2fff1e
Content: Organize your resources with Azure management groups - Azure Governance
Content Source: articles/governance/management-groups/index.md
Service: governance
GitHub Login: @rthorn17
Microsoft Alias: rithorn

@janemiceli I have passed your request along to the content author, @rthorn17

There is no visio for this but attached is the png of Management Groups icon that  you can use.  Thanks

Closing this as the PM has responded with available material and this isn't a docs issue.  Thanks for the feedback!
@MicrosoftDocs/azure-cxp-triage #please-close


feat: implement executing vote transaction after verify remote report

Implement executing vote transaction after verify remote report.
Executing Vote with makeOracleRegistrationVote, generateTx, and broadcastTx function in event/register_oracle_event.go.
This feature works well when this branch merged into master.

@inchori
I made some improvements to this PR. #45
If there is no problem, please merge. :)

This branch was approved, so I'll merge this to the base branch. And the validating the trusted block info will be implemented the another branch.


Add Ollama integration

Ensure that Janus can be used with an Ollama endpoint

Just came across this issue. This would be a great add!

A more generic version of this would be to expose OPENAI_BASE_URL to allow local inferencing from other OpenAI compatible endpoints (i.e. llama.cpp, lite_llm, local ai, etc)

Also, exposing OPENAI_BASE_URL and/or integrating with lite_llm lets you integrate non-Open AI inference engines without additional coding since it handles translation to the native APIs.


Upgrade github.com/miekg/dns

Attempt at upgrading github.com/miekg/dns to fix https://github.com/prometheus/prometheus/issues/5263
@stuartnelson3 @beorn7 I blame it and your name appeared around those lines so if you could review it it would be nice.

Duplicates https://github.com/prometheus/prometheus/pull/5020 which should be merged soon.

It looks like @simonpasquier is right. I'll close this and merge #5020 as delaying the latter has now caused @sylr to replicate work already done. If there are any concerns, we can still fix/undo before we release.


Pattern

This change fixes a spelling error in the diagnostic message enum variant. The word "Patteren" was incorrectly spelled and has been corrected to "Pattern". This improvement:

This change is


Stackoverflow when rendering OCurrent pipeline

Accessing the OCurrent pipeline on any page other than the main https://docs.ci.ocaml.org/ view, results in a stack overflow exception. For example visiting https://docs.ci.ocaml.org/?compile=& does not display the SVG and shows 500 error for pipeline.svg request.

The pipeline for docs-ci is so large that even when the graph renders successfully, it is not useful; for example on Safari I can't zoom in enough to even read the text.
It's doubtful that it's worth fixing this stackoverflow when a different visualisation could be more suitable.


feat(cart): added author to cart entity

:tada: This PR is included in version 4.41.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


:bug: - Add back ListItem.Title

Close #680

is not only this is need to be handled also the cases of tvshow/movie titles highlight

ah you changed the way I have to look better

Do I need to make any changes?

i preefer maintain untouched the _convert_dict_to_listitem method
your way affect not only directory but also items in the custom xml windows
the same thing and i think more cleaning is do the change in infolabels.py
by removing this:
https://github.com/CastagnaIT/plugin.video.netflix/blob/master/resources/lib/kodi/infolabels.py#L62-L63
and so add this line:
infos_copy['title'] = dict_item['label']
before this line:
https://github.com/CastagnaIT/plugin.video.netflix/blob/master/resources/lib/kodi/infolabels.py#L80
in this way are excluded the listitems in xml windows, and also directories that have not involved videoid data

you can also remove the argument include_title=False from get_info method and fix related calls to this method

I'll take a look at making those changes this evening.

because with some type of ListItem kodi replace Label value with Title of infolabel
and this will broken the highlight colors of listitem's
so at this point we remove the conditions so the code becomes less complex

I believe I've now made the requested changes 👌

go well, next time you can delete unuseful commits

I've squashed my newest commits.


upgrade to kernel 4.13.5

move to sunxi-next patches with kernel 4.13.5

Might be worth waiting for kernel 4.14


Save button is disabled in deployment center of app service/ function apps

The Save button present within the Deployment Center of any app service/ funciton apps.
As you can see within the below screenshot, although I have provided all the values for building app service (Source, Repository, Branch, Repository Type) correctly then too the Save button is disabled.

I tried enabling the Basic-Authentication to true but then also, the Save button is disabled only.
Other details are mentioned below -

Subscription Id: - 3bd59fd1-66d2-476f-bb16-3923b2dc01fd
Portal URL: https://ms.portal.azure.com/
Service: app-service
GitHub Login: @v-jaygupta
Microsoft Alias: v-jaygupta

@v-jaygupta
Thanks for your feedback! We will investigate and update as appropriate.

Hi @v-jaygupta, I wasn't able to reproduce your issue. Seeing that it's a portal issue, I advise reaching out to the portal team with a network trace file of this operation.
#please-close


No splash screen appears when opening the app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing #12334
Action Performed:

Open the application on web or desktop

Expected Result:
Verify that splash screen appears for 1.5s and no blank screen is visible
Actual Result:
No splash screen appears for 1.5s and blank screen is visible.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
Desktop App - Blocked with blocker issue, could not check
Mobile Web

Version Number: 1.2.28-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/202272111-39fb84d3-7260-4fed-a39a-db3bee7ae62d.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

I don't think this is a bug, the splash screen is there while things load, if in web/desktop things load so fast the splash screen is not needed, then that's great.
I think we should close this.

I agree with you, @iwiznia. It looks like the page loaded so quickly that the splash screen didn't have time to load.
I'm going to close the issue.


MSSQL: fetch 0 rows doesn't work: Invalid usage of the option NEXT in the FETCH statement.

What version of Go are you using (go version)?
go version go1.9 linux/amd64

Which database and its version are you using?
MSSQL 2012+
What did you do?
Please provide a complete runnable program to reproduce your issue.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/mssql"
)

var db *gorm.DB

func init() {
	var err error
	db, err = gorm.Open("mssql", "sqlserver://gorm:LoremIpsum86@localhost:1433?database=gorm")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}

type Result struct {
    TableCatalog string
    TableSchema string
    TableName string
    TableType string
}

// change this to 1 to see error go away
const nRows = 0

func main() {
     var result Result
     err := db.Raw(fmt.Sprintf("SELECT * FROM INFORMATION_SCHEMA.TABLES ORDER BY TABLE_NAME DESC OFFSET %d ROWS FETCH NEXT 0 ROWS ONLY", nRows)).Scan(&result).Error
	if err != nil {
		panic(err)
	} else {
		fmt.Println("success")
	}
}

Rationale
It is not possible to fetch 0 rows from what I can see with MSSQL 2012 and 2014. The fix to #1205 is not enough, apparently.
If you try to fetch 1 row, no error is returned.
The error is:
Invalid usage of the option NEXT in the FETCH statement.

If you try with MSSQL 2014+ instead:
The number of rows provided for a FETCH clause must be greater then zero.

(Test here: http://rextester.com/BSLOL96705)

Sorry for this, but only MSSQL 2017+ are officially supported, as this is the only version that supports docker image and could be tested with our CI https://app.wercker.com/Jinzhu/gorm/runs
Thank you for your report.

For the records, this error can also be caused by invalid escape sequences.


TOCSY or HSQC-TOCSY

Hello again,
I wonder (1) if it accepts HSQC-TOCSY data instead of TOCSY (or if there is a plan for it); and (2) would it run on peak lists as entrees?
Thanks

Hi Ricardo,
MADByTE's initial analysis pipeline is to use explicit HSQC and TOCSY experiments and not the combined HSQC-TOCSY. This was done for a few reasons:

HSQC spectra give explicit assignments of the proton to the carbon, whereas the combined pulse sequence does not do this. This means that although we would be able to extract features to compare, the confidence in their comparison would fall drastically and not take the carbon resonances  into account - instead relying on proton only derived features resolved along the carbon axis.
MADByTE requires resonances to be present in both the HSQC and the TOCSY as a noise filtration. This means that if we used the combined pulse sequence, there would be no secondary check to ensure that a resonance is valid and not a product of noise or reconstruction (in the case of NUS data).
The sensitivity overall of the HSQC-TOCSY combined pulse sequence is markedly lower than that of a standard TOCSY, so derived spin systems may only represent the strongest of signals.

However, the HSQC-TOCSY is a great experiment and may help to alleviate problems with data density in certain regions (such as the upfield regions). We had not previously planned on integrating this datatype into the analysis platform, but I would welcome some ideas as to how to do it. There is some great work on using HSQC-TOCSY features for fingerprinting (10.1021/acs.jnatprod.7b01063), but this was not the goal of MADByTE.


missing wega

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
no wega image
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
no

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
No
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
No

I’m assuming this is spam


move adjoint outside of loop

#240

Codecov Report

Merging #241 into master will increase coverage by 34.49%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #241       +/-   ##
===========================================
+ Coverage   56.03%   90.52%   +34.49%
===========================================
  Files          17       17
  Lines        1740     1077      -663
===========================================
  Hits          975      975
+ Misses        765      102      -663

Impacted Files
Coverage Δ

src/svdl.jl
92.64% <ø> (+33.49%)
:arrow_up:

src/lsqr.jl
97.67% <100%> (+61.77%)
:arrow_up:

src/lsmr.jl
100% <100%> (+67.37%)
:arrow_up:

src/stationary_sparse.jl
84.54% <0%> (+11.88%)
:arrow_up:

src/history.jl
92.42% <0%> (+17.11%)
:arrow_up:

src/simple.jl
85.71% <0%> (+20.84%)
:arrow_up:

src/gmres.jl
93.22% <0%> (+23.6%)
:arrow_up:

src/stationary.jl
87.09% <0%> (+25.02%)
:arrow_up:

src/cg.jl
95.34% <0%> (+30.26%)
:arrow_up:

src/orthogonalize.jl
100% <0%> (+31.25%)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91cac26...c23bbeb. Read the comment docs.


[SPARK-27815][SQL] Predicate pushdown in one pass for cascading joins

What changes were proposed in this pull request?
This PR makes the predicate pushdown logic in catalyst optimizer more efficient by unifying two existing rules PushdownPredicates and PushPredicateThroughJoin. Previously pushing down a predicate for queries such as Filter(Join(Join(Join))) requires n steps. This patch essentially reduces this to a single pass.
To make this actually work, we need to unify a few rules such as CombineFilters, PushDownPredicate and PushDownPrdicateThroughJoin. Otherwise cases such as Filter(Join(Filter(Join))) still requires several passes to fully push down predicates. This unification is done by composing several partial functions, which makes a minimal code change and can reuse existing UTs.
Results show that this optimization can improve the catalyst optimization time by 16.5%. For queries with more joins, the performance is even better. E.g., for TPC-DS q64, the performance boost is 49.2%.
How was this patch tested?
Existing UTs + new a UT for the new rule.

Test build #106853 has started for PR 24956 at commit 9b6fe2e.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12071/
Test PASSed.

Test build #106853 has finished for PR 24956 at commit 9b6fe2e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106853/
Test FAILed.

Test build #106904 has started for PR 24956 at commit d8b63e2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12111/
Test PASSed.

Test build #106904 has finished for PR 24956 at commit d8b63e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106904/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12147/
Test PASSed.

Test build #106946 has started for PR 24956 at commit b1eadb4.

Test build #106946 has finished for PR 24956 at commit b1eadb4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106946/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12149/
Test PASSed.

Test build #106948 has started for PR 24956 at commit f46c5c6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12151/
Test PASSed.

Test build #106948 has finished for PR 24956 at commit f46c5c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106948/
Test PASSed.

LGTM except one comment

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12310/
Test PASSed.

Test build #107136 has started for PR 24956 at commit dda6df3.

Test build #107136 has finished for PR 24956 at commit dda6df3.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107136/
Test FAILed.

retest this please

Test build #107151 has started for PR 24956 at commit dda6df3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12324/
Test PASSed.

Test build #107151 has finished for PR 24956 at commit dda6df3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107151/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12340/
Test PASSed.

Test build #107170 has started for PR 24956 at commit dda6df3.

Test build #107170 has finished for PR 24956 at commit dda6df3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107170/
Test PASSed.

Thanks! Merged to master.

What about updating the JIRA instead since the commit is permanant? @gatorsmile and @cloud-fan .
We can switch both JIRAs.

K. let me do that. I did this once before as well.

K. Let me do that.

Thanks!


Spawning and Forking Troubles

I describe the prob without code, since it's a bit involved, hopefully there's some obvious gotcha..
I've optimized the obj-gen part of the compiler so that devel compile of the entire compiler is about 4 times faster (on my machine), I'm trying to still improve its worst case performance (which is still always faster than current code), but I'm running in to trouble, and like to check if this is something deeper that I can't circumvent..
I began by making bc-code compares in memory instead of writing to tmp-file first, if diff: it writes out the mem-buffer. I removed the forking and simply ran all bc-o-gens in fibers - improved a lot.
This stage only in compiler takes about 40 - 120 sec on my (slow) machine (with HDD). After these changes this stage takes between 1 - 35 sec. The lower times are after a couple of compiles, hits about 2s most oftenly. I change some file each time (like parser.cr) to get a realistic use-case timed (code-compile-cycle).
Now, to the problem. I'm trying to incorporate forking again, but only fork once for each core and run fibers inside each fork. The list of units is split evenly over thread-count arrays prior to spawn->fork'ing, so they each get their own "work order list".
Now up till the call to fork_and_codegen_unit_group, integrity seems fine, but inside it there's first a spawn, then the fork inside that (then in the fork there's a loop and spawn_and_codegen_single_unit). The spawn seems to be executed more than once for some of the calls. Or is there some issue that cause loggings to repeat 1-4 times for some reason in multi-proc scenario?
If there's no way to solve it, I'll port over the current implementation from Onyx-compiler, where it has ran fine for about two weeks, in to a PR to Crystal, so some more folks can "realistic style benchmark" on their machines.

Wow, that's awesome!
But without code we won't be able to see what the problem is. You could maybe share the code, or send it as a PR, or try to reduce it.

I'll "port it over" this week and share it some suitable way (PoC first, with command line option to try the alternatives for benching without constantly recompiling release...).

I leave the forking (which should just be threading...) for now, the improvements on my machine are so great anyway, and the bonus of having the remaining cores to actually be able to use the machine while compiling is nice ;-)
I PR'ed the single version that has worked best at #2591.


Add focus inputs functionality

Input hinting example. See https://github.com/lusakasa/saka-key/issues/56.

Do you know if any other CSS selectors might be useful for this command, e.g. textarea, select, radio, button?

This was mostly intended as an example, but good point if we're rolling with this. textarea, select should probably be added. radio would be a type of input. I think buttons should be excluded.
Something like document.querySelectorAll("input, textarea, select) would be a good start then, but I think some more filtering would be needed to filter out any <input type="button"> and <input type="submit">.


VDK intro videos: 30s ingestion video

What is the feature request? What problem does it solve?
As part of https://github.com/vmware/versatile-data-kit/issues/2214 we need to create several 30s videos to introduce VDK
A video for the ingestion step needs to be created.
This video will show up in the Ingestion section of the README file.
This video also needs to be uploaded to YouTube and converted to GIF for the README file
For how to make a gif: https://github.com/vmware/versatile-data-kit/wiki/How-to-create-a-GIF
Plan:

Show the before and after (we have an image for that in the repo, but you can create your own example)
Zoom in on after and show the VDK components - and highlight the code that automates the ingestion and explain it in text - in the video

Additional context
Definition of done:
30s video is created
Uploaded to YT playlist
Uploaded to the repository

https://www.canva.com/design/DAFqgIoarmA/CRWXfLj7wlZqFGdtm2I2QA/edit?utm_content=DAFqgIoarmA&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton

Updated link: https://www.canva.com/design/DAFq7Tc2vNk/3Qfi7ge5nOkEAbAEohEzgw/edit?utm_content=DAFq7Tc2vNk&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton

Updates as per the feedback given


Can't open folder shown for media in the root SD card (/0)

Oops, accidentally logged on wrong project


Frequency ... including users who have not realized the trait (?)

Issue in help/using/features/segments/recency-and-frequency.md
I feel there is an issue with the wording in the Frequency Capping Examples (see below).

The expression frequency([1000T]) <= 5 includes all users that have realized the trait with the ID "1000" a maximum of five times, including users who have not realized the trait.

I understand the fact we are using Less than or equal which includes zero but to me and some customers I've had, if the trait is gathering population, I assume the trait has been realised 1 or up to 5 times so the assumption is that a trait needs to be realised to be counted. The documentation statement seems counter-intuitive and leads to confusion.
My 2 cents, hopefully we can improve this somehow - Thanks

Regarding what we understand to be 'Less than or equal which includes zero'
Customer replied:

If that was the case, every single segment with frequency <= X, being X any number from 1 to infinity, would be huge classifying every person within the DMP. Isn’t frequency and recency supposed to be a filter of some sort?
Looking at the examples in the doc, I see the point, but still find very unjustified to do something like that. Since it’s said in the beginning of it, that it is for traits that’s been realized only, and it’s doing the part of a “NOT” in the segment.

Hey @TofJossic - thanks for contributing. We've updated the Recency and Frequency page to clarify that the expression  frequency([1000T]) <= 5 is not valid and to advise which expression is valid for that use case.
We also updated the recency part in the article to clarify what each operator (<=, =>) does.


Refactoring parser tests

Towards #17. I have carved out an important piece of refactoring from #1221: Instead of testing error messages via the JSON output, test them directly in unit tests. This significantly improves our parser tests:

It is clear what code is being parsed. One does not have to look into a separate file.
The error message is clearly specified. Again, we do not have to look into a JSON file (nobody does that).
It's harder to ignore the failing tests, that is, there is no automatic way of agreeing with failing tests (as is happening with our current script).
We are testing the error messages, instead of testing the JSON format. There should be but a few tests that actually test the JSON output.

I have only refactored the tests of phase 1. We should understand whether we want to refactor the remaining phases the same way.

@bugarela, this test fails in a weird way. I guess, it is the result of recent refactoring. What shall we do about it?
     Error: Value is None
      at errorFactory (node_modules/@sweet-monads/maybe/cjs/index.js:105:33)
      at MaybeConstructor.unwrap (node_modules/@sweet-monads/maybe/cjs/index.js:108:15)
      at ToIrListener.exitConst (src/parsing/ToIrListener.ts:118:36)
      at ConstContext.exitRule (src/generated/QuintParser.ts:4074:13)
      at ParseTreeWalker.exitRule (src/tree/ParseTreeWalker.ts:105:7)
      at ParseTreeWalker.walk (src/tree/ParseTreeWalker.ts:57:11)
      at parsePhase1fromText (src/parsing/quintParserFrontend.ts:120:27)
      at parseErrorsFrom (test/parsing/quintParserFrontend.test.ts:36:29)
      at Context.<anonymous> (test/parsing/quintParserFrontend.test.ts:150:20)
      at processImmediate (node:internal/timers:478:21)

@bugarela, this test fails in a weird way. I guess, it is the result of recent refactoring. What shall we do about it?

This is the same problem I've been mentioning, that should be fixed by https://github.com/informalsystems/quint/pull/1228. I'm working on the debug error messages for that and then we can merge it (I believe), thus unblocking this. Alternatively, we can comment out the invalid const test and see if that's enough to make the error go away for now, and then I uncomment that test on my PR.

@konnov I merged my PR and updated this branch, and the error is gone. Now there is only a mismatch in the error message.

@konnov I merged my PR and updated this branch, and the error is gone. Now there is only a mismatch in the error message.

thanks @bugarela! I have fixed the remaining unit test. Could you have a look. Then I would be able to faster iterate on #1227.


Using a Test Setting to Specify Latency Target

Currently, there is a hardcoded setting in LoadGen that specifies that the latency target is 90% (line 694 of loadgen.cc).
PercentileEntry latency_target{.90};
There is a comment in the line above with a TODO that says to make "0.90" a test setting, which would be very helpful for testing across multiple benchmarks with different latency targets. I am filing this issue to follow up on the status of this fix.
Also, just for convenience, can we add 0.97 as one of the latency percentiles (found at line 695 of loadgen.cc) that LoadGen reports about in the "additional stats" section? It would be helpful to automatically report that information, considering that the GNMT target percentile is supposed to be 97%.

Folks from Alibaba have signed up to implement the TestSetting in this spreadsheet.
In the mean time, adding .97 would be great. @v4njur : Do you mind putting together a quick PR for that?

Ok sounds good. I have created PR #321 for adding 0.97 to the list of latency percentiles. Thanks!
@briandersn Would you like me to wait to close this issue until Alibaba is able to add the latency target as a test setting?

Thanks for the patch. Yeah, let's wait for Alibaba to upload their fix.

@frank-wei issued PR #326 , which has landed. We can close this now.
Thanks Frank!


Want to add a splash screen like Visual Studio

Because of aesthetics and because Visual Studio Code sometimes starts too slowly, I would like to request that Visual Studio Code add a Visual Studio-like splash screen as a transition.
This issue uses Google Translate

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Reduced quote font size

#777
Quote font size is reduced to 14px to match other body text.
I also renamed two classes to make more specific. I didn't like how confusing the selectors were.

Please don't merge any other pr's that affect CSS files until you merge #774
I would like to try and reduce merge conflicts.


Checking login state → double redirect when logged in. Race condition at server?

I've just deployed a Nuxt project to Vercel using the latest version of @nuxt-alt/auth (2.1.9)
The logic of my site is very simple: every single page is protected. When user is not logged in, it needs to be redirected to /login. Then, after successful login, it will be returned to home (/)
I've noticed something that didn't happen when developing locally: I'm logged in, but refreshing from any page will always result in the browser being redirected to /login and after a second, returning to home /.
Tried enabling and disabling globalMiddleware and the builtin middleware (enableMiddleware) in every combination, and/or relying on a global Nuxt 3 middleware.
This is the code of the middleware:
export default defineNuxtRouteMiddleware((to) => {
   const auth = useAuth()
   console.log(auth.loggedIn)

   if (!auth.loggedIn && to.path !== '/login') {
      console.log('going to login')
      return navigateTo('login')
   } else if (auth.loggedIn && to.path === '/login') {
      console.log('going to /')
      return navigateTo('/')
   }
})

Web is SSR. From what I'm able to debug, in the server console, the middleware will indeed hit "going to login" and redirect to /login because auth.loggedIn is false. In the client, however, auth.loggedIn is always true. Only after a second the server will properly check the JWT token from my auth user endpoint setup at nuxt.config.ts and then proceed to redirect the user correctly from the client.
Is there any chance to be a race condition in the server side that checks the validity of the JWT before processing the logic of redirects and middlewares? Am I doing something wrong?
This doesn't seem to happen when running the server locally, presumably because latency is super low and happens really fast to even notice.
EDIT: in local development, the server console returns auth.loggedIn = true. Hmmm
As extra info, I have a @nuxt-alt/proxy configured to point to another Vercel custom node.js app that handles the login. In local development, my nuxt project points to this Vercel login server as well. Everything seems to be working fine. Weird that not being local yields different results.

   auth: {
      globalMiddleware: false,
      enableMiddleware: false,
      strategies: {
         local: {
            token: {
               property: 'access_token',
               // global: true,
               // required: true,
               type: 'Bearer'
            },
            user: {
               property: 'content.username',
               autoFetch: true
            },
            endpoints: {
               login: { url: '/api/user/login', method: 'post' },
               user: { url: '/api/user/me', method: 'get' },
               logout: false,
            }
         }
      }
   },
   proxy: {
      enableProxy: true,
      proxies: {
         '/api': {
            target: 'https://custom-auth.vercel.app',
            changeOrigin: true,
         },

      },
   },

as a workaround I wrapped my middleware with if (process.client) but I don't think that's the proper way of doing it:
export default defineNuxtRouteMiddleware((to) => {

   if (process.client) {
   const auth = useAuth()
      if (!auth.loggedIn && to.path !== '/login') {
         return navigateTo('/login')
      } else if (auth.loggedIn && to.path === '/login') {
         return navigateTo('/')
      }
   }
})


Better Shortcut Key source declaration

Issue Type: Feature Request
It's a very small feature to request, but I want better information about which extensions or keymaps have implemented which shortcut keys in my VS Code Editor. Currently, when you want to see what was the source of the shortcut, it only shows it as "User" or  "Default".  But there are so many shortcuts that are created by extensions and keymaps that it tends to cause overlapping of functions. It would also make it easier to sort it out by precedence and would be a better quality of life feature
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: -

Looks likes a duplicate of https://github.com/microsoft/vscode/issues/37034 which should be addressed by the PR https://github.com/microsoft/vscode/pull/95713

/duplicate


Invalid Game Data

During editing it brings up this alert that blocks any editing, I believe it is due to incorrect handling of the action which is assigned to the individual game instead of being integrated to the addon
Example of other library addon:

Example of this addon:

I believe the issue here is that tracking mode is by default set to folder but it didn't detect your league of legends installation and fill in the folder information. This causes the action to be invalid. I will try to figure out a fix for this because unfortunately folder tracking seems to be the only way to properly track playtime

 During editing it brings up this alert that blocks any editing, I believe it is due to incorrect handling of the action which is assigned to the individual game instead of being integrated to the addon
Example of other library addon:
Example of this addon:

The fix seems to be creating an integrated play action as per your images. I have completed this on the branch IntegratedPlayActions and will release it soon once I have finished checking for any bugs.


Artifact.from_dict recursively interprets fields that it shouldn't

Artifact.from_dict will try to convert any dictionary to artifact even when the dictionary is a mapping of columns from datasets.
There cannot be a column named type:
import tempfile

import pandas as pd
from unitxt.artifact import Artifact

with tempfile.TemporaryDirectory() as tmpdir:
    filename = f"{tmpdir}/bug.csv"
    df = pd.DataFrame([{"type": f"test_{i}", "row": i} for i in range(10)])
    df.to_csv(filename, index=False)
    loader = Artifact.from_dict(
        {
            "type": "sequential_recipe",
            "steps": [
                {"type": "load_csv", "files": {"test": filename}},
                {"type": "rename_fields", "field_to_field": {"row": "myrow", "type": "bug_found"}},
            ],
        }
    )
    print(list(loader()["test"]))

This will result in the following exception:
  File "/Users/radek/Library/Caches/pypoetry/virtualenvs/fmaas-eval-_3vZ4Wue-py3.11/lib/python3.11/site-packages/unitxt/artifact.py", line 214, in _recursive_load
    cls.verify_artifact_dict(obj)
  File "/Users/radek/Library/Caches/pypoetry/virtualenvs/fmaas-eval-_3vZ4Wue-py3.11/lib/python3.11/site-packages/unitxt/artifact.py", line 149, in verify_artifact_dict
    raise UnrecognizedArtifactTypeError(d["type"])
unitxt.artifact.UnrecognizedArtifactTypeError: 'bug_found' is not a recognized artifact 'type'. Make sure a the class defined this type (Probably called 'BugFound' or similar) is defined and/or imported anywhere in the code executed.

The code works when you remove "type": "bug_found" from field_to_field.

Yes. Type is currently a  reserved name.  Maybe we need to change it to type ( @elronbandel )?

I thought we did it already. of course we should. We can also define in the recursion not to get into dictionary without __type__


Should connect accept configuration?

We often need to pre-configure statix at runtime before running the connect/0 function. Would it make sense to allow connect to accept a configuration? This would allow us to avoid mutating the application env. I can take a look at this if it's interesting to y'all.

We're having to do the same thing as our statsd servers are defined by ENV vars per data centre (a.la Consul). In general it makes sense to support runtime configuration especially for external services.
Regarding the discussions in #41, this might also be a solid feature to add to a Bleacher Report fork.

#50 should make this possible. Feel free to review the PR. :bowtie:


New SHA512_HMAC sample

Added new SHA512 + HMAC sample including:

Python code
Larky unit test
Ready-to-go YAML file

Ran tests and they passed successfully.


feat: add exponential and server-mediated backoff on retries

Fixes #43 and #44.
See #56 for previous discussion on this topic.

PTAL

PTAL

@ofrobots  -- any additional comments?

@ofrobots ping

PTAL

I have stopped using instanceof.
I have manually tested this PR. And I will be working on an e2e test (this is my next priority

PTAL


[z1_ctrl-6] process has died

[z1_ctrl-6] process has died [pid 26167, exit code -6, cmd /home/cqc/z1_ws/devel/lib/z1_controller/z1_ctrl __name:=z1_ctrl __log:=/home/cqc/.ros/log/3cac4086-433f-11ef-90e6-b7d7e508c404/z1_ctrl-6.log].

Thank you ！I solved this by installing Pinocchio for 2.6.19

Great! Glad that it worked!


NIFI-10608 Copying Process Group now includes non-processor referenced controller services

Summary
NIFI-10608
Copying a processor group used to miss controller services if controller service had not been referenced to a processor.
This resolves that.
To show fix:
create new PG -> right click -> Configure -> Controller Sevices -> Add any controller service (AvroReader for example)
copy PG
copied PG -> right click -> Configure -> Controller Services -> (new controller service is now listed/ i.e. AvroReader will be listed)
Prior to this the new controller service/Avro Reader would not be listed for the copied PG.
This same issue was also present when making templates (i.e. the template would miss controller service that had not been referenced to a processor).  This is now resolved for templates as well.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[x] JDK 11
[x] JDK 17

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

First, I was able to reproduce the problem with NiFi 1.18.0. I created a process group with an unreferenced controller service. Then, I copy/pasted the PG. The new PG did not contain the unreferenced controller service.
Next, I rebased this PR branch to current main because I was having build issues on my platform with source code from pre-1.19.0. Performed a full build with unit tests successfully.
I installed NiFi and attempted to reproduce the copy/paste problem. The pasted PG correctly contained the unreferenced controller service.
Also, I noted the same problem exists when creating a template in 1.18.0; an unreferenced CS is not in the template. Confirmed by usage and by inspecting exported template XML. With this bug fix, the template correctly includes the unreferenced CS.
Thanks for the fix @NissimShiman !
+1

Are there existing unit tests you could add to which would show the fix has the intended result?

@joewitt That is a fair point.  For some reason this area of code is lightly tested (i.e. there are no unit tests for the method this is called in.  And that goes for all the parent methods of this as well)

Huh - i just noticed @markobean did review this.  @markobean any reason you didn't merge it?
Got ya on tests @NissimShiman .  Do you think you could create a reasonable test with reasonable effort or is this code hard to test reliably?

Reminder @joewitt - I did not merge because I am not a committer.
As far as unit tests, it  may be reasonable to add, but this feels more like an integration testing option.  And might begin to go down the rabbit hole. If we add a test for this, do we also add a test to ensure all processors are copied with the process group? child process groups? funnels? etc.
@NissimShiman If you think adding a unit test for the copy operation is reasonable, is it also reasonable to have each component type tested?

@joewitt I think that could be done.  i.e. a unit test for this in SnippetUtilsTest ( https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/util/SnippetUtilsTest.java )
although as @markobean noted, this kind of gets into the more overarching question of testing in general for copying nifi components and if we want to address that.
(i.e. I am a little concerned this could lead to scope creep. I happened to come across this when testing/voting for apache nifi 1.18.0 RC4, so I wanted to close the loop with this, but this discussion is revealing that testing copying in general is an area that needs to be developed that I am hoping not to be led into at the moment :))
So to answer the question, yes, a unit test can be done for this, but we need to be OK with the general lack of copying related unit/integration tests that may now be more readily noticeable by having this one added.

sorry about that Mark - i have been thinking ever since I saw that note before you were.  My mistake.
I think if tests existed you should be able to add to them.  Creating tests where there are none and then having to deal with the existing untested bits is a bit much yeah.  I'm fine with this as is but I do think someone more familiar with this portion of the code should review/merge.  Mark's review from a functional point of view should make this super fast for someone more familiar.  If not...I'll merge it and call it good soon.

+1 LGTM, thanks for the review Mark! I too verified the expected behavior. Thanks for the fix! Merging to main

Thank you very much @mattyb149 and @markobean for looking at this!


Network Profiles: two profiles with the same name could be created

System information:

Operating system (distribution) and version win 10x64
DBeaver version 6.1.3

Describe the problem you're observing:
Two profiles with the same name could be created. After Saving lastly created profile replace previously created profile.

verified

Checked: Error message "wrong profile name" appears after attempt to create a new profile using existed profile name.


Direct links to CDN result in Error

When using the CDN references the webpage fails to open and produces a 'net::ERR_CONTENT_DECODING_FAILED' error.
Issues was tested using the Quick Start Script after failing to load my code - same issue resulted.
The links works individually, but a call is being made to
fast.fonts.net that is failing.

@rralbritton what domain are you using? You must be on a domain that is whitelisted to use the fonts as per our licensing agreement with monotype.
If you're developing locally, you should add an entry to your hosts file (private/etc/hosts on mac) for something like:
<IP_ADDRESS>       local.arcgis.com

That way you can develop your local site by visiting local.arcgis.com in your browser.

Thanks @paulcpederson . I am developing local in a windows environment. I haven't run into this issue with other ESRI/Calcite  packages in the past.

This issue should be fixed in the next release


Add Sass build tools and theming

Fixes #6, fixes #7
Some thoughts:

Readme should be modified to include build instructions (run npm build and look in the /dist/ folder)
You might want to manually review to make sure I didn't mistype or miss a color!
Might be worth reviewing the package.json file I created
Other variables could be added for things like border radius, animation time, etc.
Variables could probably be refactored a little better. Bootstrap might have some good inspiration for variable names - they have more generic variables like $primary that are a little more reusable across components. (https://github.com/twbs/bootstrap/blob/master/scss/_variables.scss)
npm build should be run before future merges so that /dist/ stays up to date. (It seems like git hooks will do this for you? Not sure - haven't set up before)

Let me know if you have any questions or concerns! I don't mind modifying what I've done here.

Thanks so much! I'll take a more in depth look at what you've done later today.
We now need to come up with a way to compile the stylesheets live during development.

It looks like node-sass has a watch flag that you could use during development.
Additionally, it looks like you could target the folder for the input/output instead of targeting the individual files. That might make the scripts look nicer.

I restructured most of it - here's how it looks now:
.
├── src/
│   ├── parts/
│   │   ├── _base.scss
│   │   ├── _forms.scss
│   │   ├── _links.scss
│   │   ├── _misc.scss
│   │   ├── _typography.scss
│   │   └── _core.scss
│   ├── dark.scss
│   └── light.scss
├── dist/
│   ├── dark.css
│   └── light.css
├── README.md
├── index.html
├── package.json
└── etc.

I wrote up a little dev server that has livereloading and compiles sass on the fly. Now all that has to be done for development is yarn dev. Are there too many dependencies, though?

Closes #8 and closes #1 (soon), because I don't want big conflicts.

I love the refactoring of the components into sass partials!
The server is a bit of code to maintain and does have dependencies, but if it works it works! If you wanted to make it easier on yourself, I've used something like gulp with livereload to avoid building my own build/webserver/watch tools. Learning gulp might be a bit overkill for something you already have working though.
If you were interested in trying it, this looks like a good guide.
(Might be worth it to just merge in these changes first and save it for a future pull request though!)

@kylejrp I remade the demo to showcase everything and added theming sections to the readme - do you think this is ready to merge?
Thanks so much for the help :)

I just pulled and ran it. Looks great! Awesome work, @kognise! Thanks for being so open to contributions. Looking forward to contributing again in the future.

Yayyy! Thanks again.

:shipit:


[SPARK-11201] [YARN] Make sure SPARK_YARN_MODE is set before SparkHad…

…oopUtil.get is called.
If StreamingContext.getOrCreate is used in yarn-client mode, a ClassCastException gets thrown when Client.scala is initialized and YarnSparkHadoopUtil.get is called. This fails because the SparkHadoopUtil.get method is called in the getOrCreate method default argument, before SPARK_YARN_MODE is set.

/cc @tdas @tgravescs @vanzin

Merged build triggered.

Merged build started.

Test build #43965 has started for PR 9174 at commit 4a48bf0.

Merged build triggered.

Merged build started.

Test build #43966 has started for PR 9174 at commit fbd4b8d.

Test build #43965 has finished for PR 9174 at commit 4a48bf0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43965/
Test PASSed.

Test build #43966 has finished for PR 9174 at commit fbd4b8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43966/
Test PASSed.

Is there anything that would break that doesn't go through SparkSubmit now?  I haven't looked at the newer launcher stuff. @vanzin   I know there were people using Client interface directly even though we say its not official api.

Merged build triggered.

Merged build started.

Test build #43993 has started for PR 9174 at commit 92aca7d.

I have a feeling this is not a problem in master, because of SPARK-10812.
In branch-1.5 and earlier, won't you get the same exception if you do not use spark-submit? e.g. if you directly call StreamingContext.getOrCreate for yarn-client mode from within your running app that was not launched by SparkSubmit.
I believe SPARK-10812 fixes both of those cases, so maybe we should just cherry-pick that into 1.5 instead.

Looks like SPARK-10812 would actually take care of this - since the check happens in run time.
+1 on backporting that to 1.5 branch. I will close this one.

Test build #43993 has finished for PR 9174 at commit 92aca7d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43993/
Test FAILed.