Labels are out of the default folder

Summary
for some reason, labels are out of the default folder
on a simple retrieve
sfdx force:source:retrieve -n W-001022 -u DEV
sfdx-cli/7.180.0 darwin-x64 node-v18.12.1
Steps To Reproduce:

This is step 1.
sfdx force:source:retrieve -n W-001022 -u DEV

Expected result
all  items are in project folder
Actual result
labels  folder is outside of  main project folder
System Information
MACOS

Which shell/terminal are you using? (e.g. bash, zsh, powershell 5, powershell 7, cmd.exe, etc.)
SHELL=/bin/zsh
If you are using sfdx

Run sfdx version --verbose --json
{
"cliVersion": "sfdx-cli/7.180.0",
"architecture": "darwin-x64",
"nodeVersion": "node-v18.12.1",
"pluginVersions": [
"@oclif/plugin-autocomplete 1.3.7 (user)",
"@oclif/plugin-commands 2.2.1 (user)",
"@oclif/plugin-help 5.1.20 (user)",
"@oclif/plugin-not-found 2.3.9 (user)",
"@oclif/plugin-plugins 2.1.8 (user)",
"@oclif/plugin-search 0.0.4 (user)",
"@oclif/plugin-update 3.0.8 (user)",
"@oclif/plugin-version 1.1.3 (user)",
"@oclif/plugin-warn-if-update-available 2.0.16 (user)",
"@oclif/plugin-which 2.2.3 (user)",
"@salesforce/cli 1.58.1 (user)",
"alias 2.1.10 (core)",
"apex 1.3.0 (core)",
"auth 2.3.0 (core)",
"community 2.0.18 (core)",
"config 1.4.22 (core)",
"custom-metadata 2.0.5 (core)",
"data 2.1.13 (core)",
"deploy-retrieve 1.6.16 (user)",
"env 1.5.14 (user)",
"functions 1.16.1 (user)",
"generate 1.0.33 (user)",
"generator 2.0.12 (core)",
"info 2.2.11 (user)",
"limits 2.1.2 (core)",
"login 1.1.12 (user)",
"org 2.2.15 (core)",
"packaging 1.10.9 (core)",
"schema 2.1.17 (core)",
"settings 1.1.10 (user)",
"signups 1.2.12 (core)",
"sobject 0.0.33 (user)",
"source 2.3.7 (core)",
"telemetry 2.0.5 (user)",
"templates 55.1.0 (core)",
"trust 2.1.0 (user)",
"user 2.1.21 (core)",
"@salesforce/sfdx-plugin-lwc-test 1.0.1 (core)",
"@salesforce/sfdx-scanner 3.7.1 (user)",
"salesforce-alm 54.8.4 (core)",
"sfdx-git-delta 5.8.0 (user)"
],
"osVersion": "Darwin 22.1.0",
"shell": "zsh",
"rootPath": "/Users/Anton_Satskyi/.local/share/sfdx/client/7.180.0-d902059"
}

If you are using sf

Run sf version --verbose --json

Paste the output here

Additional information
Feel free to attach a screenshot.

same in different project in different company/different SF instance.
for some reason command
sfdx force:source:retrieve -n testchangesetvs -u company--dev
user@COMPUTER company % sfdx force:source:retrieve -n testchangesetvs -u company--dev
Preparing retrieve request... done
=== Retrieved Source

 FULL NAME                              TYPE          PROJECT PATH
 ────────────────────────────────────── ───────────── ─────────────────────────────────────────────────────────────────────────────────────────────────
 Account.Broadband_Contract_End_Date__c CustomField   testchangesetvs/main/default/objects/Account/fields/Broadband_Contract_End_Date__c.field-meta.xml
 Account.Broadband_Current_Supplier__c  CustomField   testchangesetvs/main/default/objects/Account/fields/Broadband_Current_Supplier__c.field-meta.xml
 Account.Fibre_Current_Supplier__c      CustomField   testchangesetvs/main/default/objects/Account/fields/Fibre_Current_Supplier__c.field-meta.xml
 Account.Fibre_Interest__c              CustomField   testchangesetvs/main/default/objects/Account/fields/Fibre_Interest__c.field-meta.xml
 CustomLabels                           CustomLabels  testchangesetvs/testchangesetvs/main/default/labels/CustomLabels.labels-meta.xml
 VS_Admin                               PermissionSet testchangesetvs/main/default/permissionsets/Admin.permissionset-meta.xml

=== Retrieved Packages

testchangesetvs package converted and retrieved to: /Users/kamilentsua-mensah/Desktop/Repo/company/companyr--sfdx/companyr/testchangesetvs

user@COMPUTER company % tree testchangesetvs
testchangesetvs
├── main
│   └── default
│       ├── objects
│       │   └── Account
│       │       └── fields
│       │           ├── Broadband_Contract_End_Date__c.field-meta.xml
│       │           ├── Broadband_Current_Supplier__c.field-meta.xml
│       │           ├── Fibre_Current_Supplier__c.field-meta.xml
│       │           └── Fibre_Interest__c.field-meta.xml
│       └── permissionsets
│           └── Admin.permissionset-meta.xml
└── testchangesetvs
    └── main
        └── default
            └── labels
                └── CustomLabels.labels-meta.xml

10 directories, 6 files

Hey all, thanks for reporting the issue! Did this just start happening on a recent version of the CLI?

Hi,
Hello we 'discovered' it today in CICD scripted pipeline which is always updating sfdx to newest version.
it's appearing on version: sfdx-cli/7.180.0 i also tried In my local machine and on seconds project/client.
Thanks,
Kamil
From: Willhoit @.>
Sent: Wednesday, December 14, 2022 11:51 PM
To: forcedotcom/cli @.>
Cc: Enszula @.>; Comment @.>
Subject: Re: [forcedotcom/cli] Labels are out of the default folder (Issue #1845)
Hey all, thanks for reporting the issue! Did this just start happening on a recent version of the CLI?

Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fforcedotcom%2Fcli%2Fissues%2F1845%23issuecomment-1352324580&data=05|01||2aa4d23f53ac4d51037808dade25afd3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066550694008261|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2Bjh4yJFAo1a%2FWlFyOZODTqZqsU6fHpMXjLO13L47xxw%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIOCOEKNU6EZYORMOLOS2MDWNJFNVANCNFSM6AAAAAAS6RVSEI&data=05|01||2aa4d23f53ac4d51037808dade25afd3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066550694164927|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=aUHasOeJL01RL8lTp7h3GVxxUahiCIswAnAcm8KtXy4%3D&reserved=0.

Thank You.
From: Willhoit @.>
Sent: Thursday, December 15, 2022 12:08 AM
To: forcedotcom/cli @.>
Cc: Enszula @.>; Comment @.>
Subject: Re: [forcedotcom/cli] Labels are out of the default folder (Issue #1845)
Thanks for that info, I will try to replicate it and get back to you.

Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fforcedotcom%2Fcli%2Fissues%2F1845%23issuecomment-1352340777&data=05|01||60fddbcd2bb244f6300b08dade27fbed|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066560554304425|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zoMDw8ke%2B9VFSwVs0coO8eYU4yr41L3lU%2FdpktZa0Is%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIOCOEMRYGNAWFYQUTN4GWDWNJHLJANCNFSM6AAAAAAS6RVSEI&data=05|01||60fddbcd2bb244f6300b08dade27fbed|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066560554304425|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ilIeVNVrpihWs5uRLITbmoz5zdbiHeJfkd%2BAB6z3IFc%3D&reserved=0.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

I am not seeing this locally with 7.180.0. I notice that you are both retrieving with -n (--packagenames). I can do some testing with packages in the morning, but I am curious if either of you able to reproduce this using --sourcepath, --manifest, or --metadata? Thanks!

Hello,

Yes main issues is it is not working with changeSets (-n option) ((may be related to source format or something? Since this converts changeSet- 'package converted and retrieved' )). It is important because most of ours admins/consultans use change sets(they don't know how to use sfdx, git ...)
With manifest(package.xml) and -m metadata worked fine as far as I remember.

Thanks,
Kamil
From: Willhoit @.>
Sent: Thursday, December 15, 2022 12:45 AM
To: forcedotcom/cli @.>
Cc: Enszula @.>; Comment @.>
Subject: Re: [forcedotcom/cli] Labels are out of the default folder (Issue #1845)
I am not seeing this locally with 7.180.0. I notice that you are both retrieving with -n (--packagenames). I can do some testing with packages in the morning, but I am curious if either of you able to reproduce this using --sourcepath, --manifest, or --metadata? Thanks!

Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fforcedotcom%2Fcli%2Fissues%2F1845%23issuecomment-1352367474&data=05|01||c760b70cb0c346ddff0c08dade2d34f9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066582981462598|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MmPUl5PIFWJSYoT1aYf4zh3RgVb7%2BHGztRputohmrvU%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIOCOEKNDTPUM6YGXYRUMXLWNJLXRANCNFSM6AAAAAAS6RVSEI&data=05|01||c760b70cb0c346ddff0c08dade2d34f9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638066582981462598|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qAxpWkaHru4WmnGtxCMyzWiqDQzegaO0fjqlUQ4aIYM%3D&reserved=0.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

Thanks for that info, I will try to replicate it and get back to you.

no, it was on  7.17X ver  also

Followup: have been working a lot on SDR and how decomposition/recomposition happens.
I'm not confident that we can fix this bug without causing some other problems.  I'm going to use this as a test case for the custom-registry work--and you'd end up having each label in its own file like https://github.com/forcedotcom/cli/discussions/2635

Hi @antonsatskyi @Enszula -
I've just confirmed that this is fixed by adding   "registryPresets": ["decomposeCustomLabelsBeta"] to your sfdx-project.json.  This is using the custom registry presets we just released today. There is a bit of a transition to use them (delete your files locally, re-retrieve them) - but I hope you will do that 😄.
Proof:
using
@salesforce/cli/2.36.7 darwin-arm64 node-v18.18.2

without registry change
  ➜  sf project retrieve start --package-name CL
Retrieving v60.0 metadata from<EMAIL_ADDRESS>using the v60.0 SOAP API
Preparing retrieve request... Succeeded

Retrieved Source
========================================================================================================================================================================
| State   Name                                Type                     Path
| ─────── ─────────────────────────────────── ──────────────────────── ─────────────────────────────────────────────────────────────────────────────────────────────────
| Created CustomLabels                        CustomLabels             CL/CL/main/default/labels/CustomLabels.labels-meta.xml

Notice the CL/CL/main
and now
 ➜  sf project retrieve start --package-name CL
Retrieving v60.0 metadata from<EMAIL_ADDRESS>using the v60.0 SOAP API
Preparing retrieve request... Succeeded

Retrieved Source
========================================================================================================================================================================
| State   Name                                Type                     Path
| ─────── ─────────────────────────────────── ──────────────────────── ─────────────────────────────────────────────────────────────────────────────────────────────────

| Created CustomLabels                        CustomLabels             CL/main/default/labels/CustomLabels/CustomLabels.labels-meta.xml

it's placed in the correct package path


help: Document that groups can be DM addressees.

Current: https://zulip.com/help/starting-a-new-direct-message and other pages

Updated

Merged, thanks @alya!


Allow builder classes to be declared as abstract

It is useful if Builder classes can be declared as abstract, for then (for example) generic types can be discovered at runtime.
This commit ensures that no builder factory is registered for such a class. Current behaviour is to generate invalid Java, since such a class cannot be instantiated with its no-args constructor.

LGTM once you fix the test nit


refactor: the useHistoryStateReducer function using switch-case statement

This PR refactors the existing useHistoryStateReducer function by replacing the if-else statements with a more concise and readable switch-case statement. The new implementation enhances code clarity and maintainability, making it easier to understand and extend the logic for handling different action types.
Changes Made:

Replaced if-else statements with switch-case statement for action type handling.
Improved code structure and readability.
No significant impact on performance expected.

This refactor aims to streamline the codebase and align with best practices for code organization and readability.

I appreciate the effort, but I prefer if/else statements.


CORS policy error and temporary banned

Dear all,
I have some issues on this really useful library.
first of all I got the CORS Policy error:
Access to XMLHttpRequest at 'https://www.instagram.com/batman/' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
when I retried i got this other error:
InstagramFeed: It looks like YOUR network has been temporary banned because of too many requests. See https://github.com/jsanahuja/jquery.instagramFeed/issues/25
Following the link https://github.com/jsanahuja/jquery.instagramFeed/issues/25 i found the solution to other issues.
I have simply tested the application putting the following in my html:

is some error of my code? can I do something to solve this?
any suggestions?
Thank you very much
Cheers
R

This is usually because you've been banned. Should happen less times with the latest 2.0.1 release as of we have implemented client-side caching in #54.

thank you very much, I've updated my file with the latest release.
Is still valid the usage of the following for the CORS policies? I keep it in my code and go on
'https://images' + ~~(Math.random() * 3333) + '-focus-opensocial.googleusercontent.com/gadgets/proxy?container=none&url=https://www.instagram.com/'
thanks again
Cheers
R


Workshop tests except in the rarest situation should have only 1 assert or expect per test.

For Example:
Javascript Primer - Conditionals - Exercise 5 excerpt:
it("returns 'correct' for a valid combination", function() {
  expect(checkLock(3, 2, 5, 1)).to.eql("correct");
  expect(checkLock(5, 2, 55, 8)).to.eql("correct");
  expect(checkLock(7, 2, 100, 21)).to.eql("correct");
});

If this fails the student has very little means to figure out which of the expects that failed. All the student can see is:

Even if the student can effectively use console.log, we separate the console output from the spec output, so the student has no way to create a sequence where the console logs the combination and the test fails.
It is also considered best practice to only have 1 expect per test. IMO, we are teaching bad practice.
But the greater issue is that we are making it difficult to impossible for students to get the feedback they need or systematically pass tests. Idealy, the tests would work in a TDD style approach, leading the student in logical steps to working code.
This is one of those issues that I have brought up on GitHub for multiple years on Bloc problems. It keeps creeping back in as a problem. This IMO, needs to be a standard (1 expect per test), that is required for acceptance to the curriculum.
There are times, when 2 expects (ie. test before and after a condition) are useful, or even necessary. But we will not likely face that much in the coding problems we are writing.
For the exercise listed, we must make this change, as it is impossible, for a student to fully debug, with the given tools.

+100 to this, we definitely need to consider multi expects per test an anti-pattern.

Discussed before in:
https://github.com/Bloc/workshop-curriculum/issues/37

This has been a gripe of mine for a long time. It was really a pain point for the canIGet function, which no matter which of the ~15 tests failed, it would always say "Should return the correct value" or something to that effect.


Deploy documentation site/hook up to CI

I think this could end up being a github page, there may be some ng plugins to use here to make this as simple as possible

The approach for this task should overlap with https://github.com/azavea/raster-foundry/issues/1272.

For this, I think we want to take a similar approach to the one we took with Cicero Live. Terraform to manage the AWS resources and STRTA to help drive a Jenkins deployment pipeline. The target subdomain is docs. Probably make sense to setup within the current hosted zone vs. attempting more delegation.


SPICE-0001: Import Graph Analyzer API

This adds a SPICE for an API that analyzes the imports declared by Pkl modules.

I think there are some additional use cases that could be considered as part of the implementation here.
Use case: SBOMs
If you squint slightly when reading this SPICE, it should be possible to build an SBOM of all packages and files imported, and their version numbers from the point of view of an entrypoint. That would be useful to query out a known-bad package should you (as a user of Pkl, and not a machine or build tool) want to understand the required set of packages/imports.
Use case: visual representation
This is a nice-to-have. It would be nice to have a documented example of how to build something like a graphviz view of the dependency graph from the produced output. It would help to understand the graph in a different way than just for build tool consumption.

@KushalP:

If you squint slightly when reading this SPICE, it should be possible to build an SBOM of all packages and files imported, and their version numbers from the point of view of an entrypoint. That would be useful to query out a known-bad package should you (as a user of Pkl, and not a machine or build tool) want to understand the required set of packages/imports.

Yeah, that's a valid use-case that can be derived from this feature. But, I would say that building SBOMs is out-of-scope for this feature itself.

This is a nice-to-have. It would be nice to have a documented example of how to build something like a graphviz view of the dependency graph from the produced output. It would help to understand the graph in a different way than just for build tool consumption.

Yeah; good idea. --format=dot might be a good addition to the output formats.

@stackoverflow Ideally, Java bindings would work the same as all other language bindings, and Java libs such as pkl-config-java and pkl-doc would exclusively use these bindings. This architecture shift has enormous potential.

@translatenix We already discussed creating a traditional Java binding, like the Go binding. This will also help people who can't move to newer JDKs.


files.upload's file param doesn't accept bytes data

Description
Originally this is reported by @tplants  at https://github.com/slackapi/python-slackclient/issues/728#issuecomment-669279644
#730 resolved an issue with bytearray param but the change didn't support bytes properly.
# this is _bytes_ not a _bytearray_
file = io.BytesIO(bytes_like_object).getValue()

# This worked previously but does not work now.
res = client.files_upload(file=file, filename="test.xlsx", filetype="xlsx")

# This works now.
res = client.files_upload(file=io.BytesIO(file), filename="test.xlsx", filetype="xlsx")

What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

After #771 was merged, the files_upload function signature still does not accept a bytes type object: https://github.com/slackapi/python-slack-sdk/blob/main/slack_sdk/web/client.py#L1458-L1460
    def files_upload(
        self, *, file: Union[str, IOBase] = None, content: str = None, **kwargs
    ) -> SlackResponse:

So the OP example produces a mypy error: Argument "file" to "files_upload" of "WebClient" has incompatible type "bytes"; expected "Union[str, IOBase, None]"

@gburek-fastly Thanks - I just created a new issue #901 for this.


nifti mask to RT-struct dicom

I’ve recently designed a model which gives an output mask in nifti format. As I need to have rtstruct created as well, I am leveraging your rt_utils library.
Below is the code I wrote for the same. I am getting the rtstruct which seems to be rotated of flipped. The snapshot shows both nifti mask and generated Dicom rtstruct. Just wanted to check if you’ve happened to see such behavior? It would be great if you could share your thought/recommendations to address this issue.

I will add a function to solve this issue.

Hi Qurit could I ask what your solution was for this? I'm having the same problem...

Hi @qurit-frizi
I'm in a similar situation.
Any ideas to fix would be really helpful.

Hi @MattAWard
Thanks for the info.
I had thought of something in the similar lines,
but turns out it isn't a generalized solution (atleast didn't work for my images 😔)

I had to eventually do arr.swapaxes(0, 1) instead of rotation on the data returned by nibabel.
Still open for feedback.


typing is choppy/slow, except in comments or small files

I have code hints off, no line highlighting (i dont even see this feature, but the line doesn't highlight)
When typing in my index.html file, the typing is really slow; it takes about almost a full second for a letter to show up. If I type in a commented area it's instant.
It's apparent that some kind of parsing is slowing it down.
My computer is Windows 7 Ultimate with 6 core 3.2GHz 3930k, 32GB RAM. Lots of resources left. I also tried running it as Administrator which didn't help, but did finally allow me to install extensions with the Extension Manager.
Edit: The only extensions installed were Beautify extensions. I removed them and restarted app which also didn't fix it.

can you do some typing operations, project switches and general susage for some time in brackets and then comment hemp>health report here?

was still open from yesterday
{
"uuid": "52de8efc-a5be-4407-bdfc-6d8cf48d5abd",
"snapshotTime":<PHONE_NUMBER>833,
"os": "win",
"userAgent": "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Brackets/<IP_ADDRESS> Chrome/39.0.2171.36 Safari/537.36",
"osLanguage": "en-US",
"bracketsLanguage": "en-US",
"bracketsVersion": "1.5.0-16538",
"fileStats": {
"openedFileExt": {
"html": 11,
"xml": 3,
"php": 9
},
"workingSetFileExt": {
"html": 2,
"php": 3,
"xml": 1
}
},
"ProjectDetails": {
"prj113212267": {
"numFiles": 283,
"cacheSize": 5923414
}
},
"projectLoadTimes": ":128",
"fileOpenTimes": ":635:216",
"ModuleDepsResolved": 590,
"AppStartupTime": 1643,
"prefNodeSearchDisabled": false,
"prefInstantSearchDisabled": false,
"installedExtensions": [
{
"name": "adobe.brackets.extract",
"version": "0.8.0-1749-release"
}
],
"bracketsTheme": "light-theme"
}

Hello
I'm with the same problem. Even with all extensions disabled, the editor is too slow to position the cursor, enter the codes and navigating through it.
Here's the report with the extensions I use, the most important being the time the compiler less files
{
"uuid": "26699df0-9268-4eab-8c2e-ba78c1db4c91",
"snapshotTime":<PHONE_NUMBER>135,
"os": "win",
"userAgent": "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Brackets/<IP_ADDRESS> Chrome/39.0.2171.36 Safari/537.36",
"osLanguage": "pt-BR",
"bracketsLanguage": "pt-br",
"bracketsVersion": "1.5.0-16538",
"fileStats": {
"openedFileExt": {
"less": 1
},
"workingSetFileExt": {}
},
"ProjectDetails": {
"prj2050993437": {
"numFiles": 6,
"cacheSize": 69625
}
},
"projectLoadTimes": ":176",
"fileOpenTimes": ":637",
"ModuleDepsResolved": 564025,
"AppStartupTime": 565404,
"prefNodeSearchDisabled": false,
"prefInstantSearchDisabled": false,
"installedExtensions": [
{
"name": "0674272bac.tagrenamer",
"version": "0.0.2"
},
{
"name": "brackets-beautify",
"version": "1.2.0"
},
{
"name": "brackets-css-color-preview",
"version": "0.0.7"
},
{
"name": "brackets-html-wrapper",
"version": "1.2.0"
},
{
"name": "brackets-indent-guides",
"version": "1.3.5"
},
{
"name": "brackets-minimap",
"version": "3.2.5"
},
{
"name": "brackets-paste-and-indent",
"version": "0.2.0"
},
{
"name": "brackets-php-syntax-hint",
"version": "1.1.5"
},
{
"name": "brackets-special-html-chars",
"version": "1.2.4"
},
{
"name": "brackets-various-improvements",
"version": "2.2.1"
},
{
"name": "brackets-workspaces",
"version": "2.1.3"
},
{
"name": "brackets.swatcher",
"version": "1.2.2"
},
{
"name": "busykai.indent-right",
"version": "0.1.0"
},
{
"name": "camden.w3cvalidation",
"version": "2.2.2"
},
{
"name": "colorhints",
"version": "1.1.2"
},
{
"name": "delkos",
"version": "0.0.3"
},
{
"name": "dnbard.extensions-rating",
"version": "0.7.4"
},
{
"name": "drewkoch.icons",
"version": "1.3.1"
},
{
"name": "enturn.quick-search",
"version": "1.1.4"
},
{
"name": "fede91.brackets-preferences-ui",
"version": "1.4.0"
},
{
"name": "hirse.outline-list",
"version": "0.7.0"
},
{
"name": "insya.newdocument",
"version": "0.0.4"
},
{
"name": "insya.tools",
"version": "0.2.0"
},
{
"name": "ivanbarcia.material-light",
"version": "1.0.0"
},
{
"name": "le717.html-skeleton",
"version": "1.4.3"
},
{
"name": "mikaeljorhult.brackets-autoprefixer",
"version": "0.6.1"
},
{
"name": "mikaeljorhult.brackets-todo",
"version": "0.8.1"
},
{
"name": "mikailcolak.brackets-color-picker",
"version": "0.1.3"
},
{
"name": "mirorauhala.bootstrap-skeleton",
"version": "0.2.0"
},
{
"name": "ovk.brackets-simple-todo",
"version": "0.1.5"
},
{
"name": "pflynn.reasonable-comments",
"version": "1.3.0"
},
{
"name": "quickdocsphp",
"version": "1.4.7"
},
{
"name": "rain.monokai-dark-soda",
"version": "1.0.9"
},
{
"name": "scroll-arrows",
"version": "0.1.0"
},
{
"name": "ws-sanitizer",
"version": "1.2.1"
},
{
"name": "jdiehl.less-autocompile",
"version": "1.1.10"
}
],
"bracketsTheme": "delkos"
}

{
    "uuid": "a727db62-798c-4b2e-aa25-63686fb36f6f",
    "snapshotTime":<PHONE_NUMBER>546,
    "os": "win",
    "userAgent": "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Brackets/<IP_ADDRESS> Chrome/39.0.2171.36 Safari/537.36",
    "osLanguage": "en-US",
    "bracketsLanguage": "en-US",
    "bracketsVersion": "1.5.0-16538",
    "fileStats": {
        "openedFileExt": {
            "php": 4,
            "json": 5
        },
        "workingSetFileExt": {
            "php": 1
        }
    },
    "ProjectDetails": {
        "prj3059181": {
            "numFiles": 478,
            "cacheSize": 6255919
        }
    },
    "projectLoadTimes": ":180",
    "fileOpenTimes": ":676",
    "ModuleDepsResolved": 59899,
    "AppStartupTime": 61131,
    "prefNodeSearchDisabled": false,
    "prefInstantSearchDisabled": false,
    "installedExtensions": [],
    "bracketsTheme": "dark-theme"
}

I do have the same problem. Will edit this later with Health data.
Also, there is this other ticket with apparently the same issue. You may want to make it a single thing:
https://github.com/adobe/brackets/issues/12062

azinod, thanks for the suggestion, but running as Administrator did not solve the issue for me. I'm running Windows 7 Ultimate. I will open the same files on my Ubuntu laptop and see if I can replicate the problem.
Has anyone experienced this on Linux?

Hello @azinod
Did the procedure as described and seem to work for me in Windows 10, thank you.
Let's see if the solution remains stable over the course of the day.
@FLasH3r @caleb87

I must admit it did give a bit of a boost, I'm going to test it tomorrow a bit more on larger files (3k+ JS files).
FYI. the slowness happens on my laptop only. my desktop machine works without this "hack"

It also only happened on my Windows 10 personal Notebook, which is a Lenovo T450.
The notebook at my work is a previous version (a T430) with Windows 7 and did not have the problem.
I do think the problem should be related to some kind of permission that Brackets is not getting into the system, and that is making it performs very heavily. Running it in Admin mode is granting that permission, but for those that are still facing the problem maybe there is more to it.
Maybe reinstalling Brackets and making sure you are clicking on 'Allow' on all those 'Brackets is trying to do stuff to your system, will you allow it?' questions? Or even going to your User Account Control Settings and set it to Never notify, and then reinstall Brackets... and ultimatelly try the Run as Admin trick again.
Hopefully this problems get some attention and they find the issue and eventually a fix for it so we don't need to run Brackets as Admin... thankfully not the whole community is being impacted by it though.

I want to note again that the problem only happens in large files. I can even type fast in comments in those large files. The problem doesn't occur in small files. Since comments have no code parsing, it's easy to see the problem is related to code parsing.
I have an index.html web app that is heavy in JS. Files that are under 1000 lines are fast.
It seems that there may be two problems causing choppy typing.

Admin permissions are needed
Faulty code parsing

Has anyone not experienced this issue with 5000+ lines of code? 10k+? Those who solved their issue with permissions have any issues with files with 5k+ lines?

I loaded some heavy files to test and mine worked fine, as soon as the document was loaded. Using the admin permission of course.

I had analysed this issue sometime back. The actual problem is not related to permission rather extraction of js code from an html file slows it down. We use linear token parsing on the html doc to preserve location info of each and every js statement in script blocks. Parsing time is directly proportional to the number of lines in the html file.
As this linear parsing happens in the main thread itself , typing performance is affected. In a large html file you might find slugging cursor movement, key buffering while typing in a script block only.
One of the convenient way to fix this issue is to have the parsing out of the main thread. It can be in the web worker where we do tern analysis or in node ( a separate PR exists to move tern analysis on node ) .

Hello everyone
@ caleb87 not necessarily need to be a heavy file. Was working on a .less file with about 1700 lines and was impossible to work in the same way another .less of 340 lines and a pure html, with 51 lines. And I'm using a z200 workstation from HP.
So I think it's a bug same as in previous versions did not have this problem and theazinod tip of all is ok now.

@ozzyjr is correct IMO,
I'm also working on PHP files current one is about 1200~ lines.
@swmitra what about other languages then JS ?

same issue here in linuxmint.

There is definitely a lag problem, and I have pinpointed that it's directly related to the size of the file you are editing and codehint.JSHints flag set to true. If I start a new file or open one with just 10 lines, there is no lag whatsoever. But working with a file of 2500 lines, it's a horrific lag.
Obviously a workaround is breaking my project down into smaller files, however I think many users would choose to just use a editor that doesn't lag on a 102k text based file.
Let me know if you need more information, I am experiencing this on a Macbook Pro with OSX 10.11.4 (El Capitan) 16GB i5 SSD and version 1.6 of Brackets, no extensions running.
I also posted this on bug #9486 and #9980 because this is imo the same issue.

Big
No
But Bigger. The cursor is lagging like the tortoise that is making me cry. Sometimes I am throwing Brackets, my favorite code editor, out. Plz solve this problem.

#12408

same issue with a large complex HTML/JS/CSS file. Really slow

Still seeing the same issue here. I can't believe this is still an ongoing problem. 2 years later... I'd love to dump Brackets, but it has a few features that I love. But the lag is killing me!


:BundleClean removes vundle itself

I installed vundle following README, such as:
$ git clone http://github.com/gmarik/vundle.git ~/.vim/bundle/vundle

and wrote .vimrc, such as:
set nocompatible               " be iMproved
filetype off                   " required!

set rtp+=~/.vim/bundle/vundle/
call vundle#rc()

Bundle 'rails.vim'
Bundle 'quickrun.vim'
Bundle 'Shougo/unite.vim'
Bundle 'Shougo/neocomplcache'

filetype plugin indent on     " required

when I executed :BundleClean, and answered y to the confirmation, vundle itself was removed, such as:
:!rm -rf '/home/s-kuroki/.vim/bundle/vundle'

I think vundle itself should not be removable by :BundleClean. or did I something in the wrong way?

I still have this problem using the latest Vundle version, with the line `Bundle 'gmarik/Vundle.vim' present.
Output of BundleInstall (note that Vundle.vim is included):

Output of BundleClean:

Oops, there was a case difference--I had vundle.vim instead of Vundle.vim in my .vimrc.


"Error: ISO file not found or is empty. " when running ./run-local.sh to deploy the agent in the arena

xxx@DESKTOP-MOA1P57:/mnt/e/Project/WindowsAgentArena/scripts$ ./run-local.sh
Using configuration file: /mnt/e/Project/WindowsAgentArena/config.json
Using mode: azure
Using VM Setup Image path: /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/image
Using VM storage mount path: /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/storage
Using server mount path: /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/setup
Using client mount path: /mnt/e/Project/WindowsAgentArena/src/win-arena-container/client
Invoking Docker Container with the command:
docker run -it --rm -p 8006:8006 -p 3390:3389 --name winarena --platform linux/amd64 --device=/dev/kvm -e RAM_SIZE=8G --ipc=host -e CPU_CORES=8 -v /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/storage/.:/storage -v /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/setup/.:/shared -v /mnt/e/Project/WindowsAgentArena/src/win-arena-container/client/.:/client --cap-add NET_ADMIN --stop-timeout 120 --entrypoint /bin/bash -e OPENAI_API_KEY=xxx dockerpull.org/windowsarena/winarena:latest -c './entry.sh --prepare-image false --start-client true --agent navi --model gpt-4-vision-preview --som-origin oss --a11y-backend uia'
Starting WinArena...
Starting VM...
Starting WinArena VM...
❯ Starting Windows for Docker v0.0...
❯ For support visit https://github.com/dockur/windows
❯ CPU: 13th Gen Intel Core TM i5 13400F | RAM: 14/16 GB | DISK: 1808 GB (v9fs) | HOST: <IP_ADDRESS>-microsoft-standard-WSL2...
Error: ISO file not found or is empty.
Waiting for a response from the windows server. This might take a while...
Waiting for a response from the windows server. This might take a while...

I've been successfully completed the step "3.2 Automatic Setup of the Windows 11 golden image" and the Docker container gracefully shutted down as expected. However, when I was running the agent, it came a problem with the "missing" ISO file. I'm pretty sure that the ISO file is located correctly as shown below. I'm looking forward to your reply for the solution and thanks a lot!

xxx@DESKTOP-MOA1P57:/mnt/e/Project/WindowsAgentArena/scripts$ cd /mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/image/
xxx@DESKTOP-MOA1P57:/mnt/e/Project/WindowsAgentArena/src/win-arena-container/vm/image$ ls
README.md  setup.iso

You should use the --prepare-image flag only when preparing the image:
./run-local.sh --prepare-image true
If the issue occurs after the preparation phase, ensure that after preparation the storage folder contains all the files listed here:

If the windows.boot file is missing, it will likely result in the Error: ISO file not found or is empty. error.


E713  Cannot use empty key for Dictionary

Error detected while processing function cmake#augroup#on_vim_enter..cmake#targe
ts#cache:
line   13:
E713: Cannot use empty key for Dictionary
The function call cmake#targets#cache() throw this error.
I have been commented this call

What was the file path of the buffer that this occured under?

I see a potential problem in (cmake#targets#cache())[https://github.com/jalcine/cmake.vim/blob/develop/autoload/cmake/targets.vim#L204-L210] and I've patched it in #63. Do you mind getting the project at that tree and trying the code out? It'd help even more if you mentioned what you were doing when you got to this error.

@lilijreey: If you checkout the develop branch and try it out; it should work OK for you now. I'm still working on improving the test suite so I can check bugs like this in the future.

Going to close this issue since the visible problem was fixed in #64.

thanks


Reading from .netrc only gets the first word of a multi-word password

For example, if my password is "aaa bbb ccc", it will be read as "aaa".  The same is true of user names, but I've never seen a bb user name of more than one word.  Note that prompting for the user name/password does not have this issue.

Maybe we should quote unames/passwds?

It seems that some implementations of netrc will handle quoted strings: https://stackoverflow.com/questions/12674888/can-netrc-handle-passphrases-with-spaces
See also man 5 netrc
Other ways to handle this:

use more sophisticated parsing, e.g. greedily match the login or password token until you hit the next machine or password token
require spaces in the netrc file to be escaped, such as with %20, and then unescape them when reading the file

I think handling single-/double- quoted strings would be best. It will just require more complicated parsing to unquote literal quotes and backslashes.

http://stackoverflow.com/questions/12674888/can-netrc-handle-passphrases-with-spaces also suggests that quoting the password is the right answer. However, we shouldn't require single word passwords to be quoted, so I think the regex would be .*password \(".*"\|[^ ]*\) (not tested though).

Sounds good.  Should it also have support for escaped quotes (")?

So it looks like my implementation of ftp(1) supports double quoting and backslash escaping.  Is this what we should support for bb?

I guess it doesn't really matter in this case. I had thought it would be necessary if a password had spaces and a ", but something like password "123456" "654321" will correctly have the password be 123456" "654321 because of greedy matching.

True, but that conflicts with the behavior of ftp(1).  s/.password ("(([^"]|\.))"|(([^ ]|\.)))./\2\4/p handles escaped characters both in and out of double quotes (yes I know it's ugly), and as far as I can tell mimics ftp's behavior.  It does leave the backslashes in, but those can be removed by ${password/\/}

RocHack/fix-password-spaces@1bc7446: Does this look good?

We can't remove the backslashes in general, since the password could have a backslash in it. It's probably easiest to either

give up on regexes and use more sophisticated parsing, or
go with a non-conforming approach that will work for pretty much all practical purposes.
My regex (I believe) works for 2.

Good point.  Since the regex leaves backslashes, how about just something that would remove single backslashes and convert double backslashes to single backslashes?

I think that might work, but I'm not sure. I'll write a quick test script to try out a bunch of passwords.

Also, on a related note, I'm planning on changing read ... to read -r ... so that the prompt doesn't make backslashes special. Since read can handle spaces and such, I can't think of anything you'd need to escape.

#! /usr/bin/python3

import sys

def remove_backslashes (str):
    prev=False
    ret = ""
    for i in str:
        if i == "\\" and not prev:
            prev = True
        else:
            ret += i
            prev = False

    return ret

for i in sys.argv[1:]:
    print(remove_backslashes(i))

This seems to work for me

Also note that bb uses tabs for indentation - you did it right for a8595374daf5f07db68b5d608bb6049d325987a3 but not for 1bc74460cae133aced9aabfd5996ee0a744b9044.

Sorry, I have my Emacs set to not indent with tabs.  I didn't even notice, I'll fix that.

sed 's/\\[^\]//g;s/\\$//g;s/\\\\/\\/g' should work too.

And yeah I've messed up the spaces vs. tabs thing a bunch on bb, so now I have a script that will auto-set to tabs if that's what the file uses.

sed 's/\\\([^\\]\)/\1/g;s/\\$//g;s/\\\\/\\/g' Need to make sure we grab the character after the backslash so it gets left in.

colin@colins-computer:~/Documents/programming/bb$ password=$(sed 's/.*password \("\(\([^"\]\|\\.\)*\)"\|\(\([^ \]\|\\.\)*\)\).*/\2\4/;s/\\\([^\\]\)/\1/g;s/\\$//g;s/\\\\/\\/g' <<< 'machine my.rochester.edu login cpronovo password "aaa\\\\\\\\\\ \"\bbb\\" machine')
colin@colins-computer:~/Documents/programming/bb$ echo $password
aaa\\\\\ "bbb\

This seems to work, but I had to remove the -n option from sed and the p on the regex.  Is there a particular reason those were there?

Also, since newlines are removed as a side-effect of word splitting following command substitution, is the s/\\$//g term necessary?

Oops, yes, thanks for that correction.
Don't know, but it's probably for consistency with other regexes in bb. Removing them shouldn't break anything.
Perhaps not, but it won't hurt, and I'd rather be safe than sorry. If the regex gets used on a plain string like hello\ then it'll be necessary.

Is it OK if I use the $() form of command substitution?  The backquote form seems to break the sed expression, probably due to bash interpreting the backslashes specially in that form.

Yes, $() is good.
Consider factoring out the complicated part of the login/password regexes into a shell variable, to make things more DRY.

Double-escaping each backslash (find-and-replace from \ to \) works as well.  I think I'll leave it like that for consistancy.  And I'll make the pattern a variable as well.

Consistency is good. For the future, we may want to switch bb over to $() - as you've already seen, it nests better, and there's even been discussion about \`` being deprecated, although it technically haven't been (http://unix.stackexchange.com/questions/126927/have-backticks-i-e-cmd-in-sh-shells-been-deprecated).

I agree, we should switch to $().  Also, making the regex a variable removes the need for double backslashes.

I've created a password-tests branch for the test script and passwords that I used. It seems to work well. Feel free to add any other password tests you want - it's just the input password followed by the expected password on the next line. I've made it an orphan branch because it's testing the regex, not bb, and it helps keep master clean.

I've changed the regexs in bb to those in the password-test script, which worked for my test password as well.

I think this is ready for commit.

I've updated the test branch to match how bb's parse_netrc() works. 2 tests currently fail, but they're edge cases and I'm not going to bother fixing them.

I fixed one test; the test password had unescaped spaces.  The other looks to be escaping the newline/space/whatever that comes after the password, which I agree is a edge case.


[gdal] link failure

Host Environment

OS: Linux CentOS 7.8
Compiler: gcc8.2 / vcpkg latest(HEAD commit: 6e073f168652a551d8f29d19481ec67be3fccac8)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install gdal
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:142 (message):
    Command failed: /usr/bin/make V=1 -j 9 -f GNUmakefile all
    Working Directory: /home/user/vcpkg/buildtrees/gdal/x64-linux-dbg
    See logs for more information:
      /home/user/vcpkg/buildtrees/gdal/build-x64-linux-dbg-out.log
      /home/user/vcpkg/buildtrees/gdal/build-x64-linux-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_make.cmake:186 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_make.cmake:24 (vcpkg_build_make)
  ports/gdal/portfile.cmake:200 (vcpkg_install_make)
  scripts/ports.cmake:136 (include)

Error: Building package gdal:x64-linux failed with: BUILD_FAILED

Additional context
the buildtrees/gdal/build-x64-linux-dbg-err.log file says lots of this error:
/home/user/vcpkg/installed/x64-linux/debug/lib/libcrypto.a(threads_pthread.o): In function `fork_once_func':
threads_pthread.c:(.text+0x16): undefined reference to `pthread_atfork'
collect2: error: ld returned 1 exit status
(many same error below)
...

I have tried add -pthread at the GDALmake.opt line 665,like:
LIBS = (blah...) -pthread

and execute make manually at this folder:
/usr/bin/make V=1 -j 9 -f GNUmakefile all

gdal will compile and link without error

Could you provide the full log buildtrees/gdal/build-x64-linux-dbg-err.log and buildtrees/gdal/build-x64-linux-dbg-out.log?
Thanks.

config-x64-linux-dbg-err.log
config-x64-linux-dbg-out.log
build-x64-linux-dbg-err.log
build-x64-linux-dbg-out.log
👌

On my machine:
checking for cryptopp... no
checking for crypto... checking for EVP_sha256 in -lcrypto... yes
checking openssl/bio.h usability... yes
checking openssl/bio.h presence... yes
checking for openssl/bio.h... yes
...
  cryptopp support:          no
  crypto/openssl support:    yes

But it didn't link to gdal locally. Don't know why.

Related: #9068.

@Sjurk  In configure:
if $PKG_CONFIG --atleast-pkgconfig-version 0.20; then
        _pkg_short_errors_supported=yes
else
        _pkg_short_errors_supported=no
fi
        if test $_pkg_short_errors_supported = yes; then
	        OGDI_PKG_ERRORS=`$PKG_CONFIG --short-errors --errors-to-stdout --print-errors "ogdi"`
        else
	        OGDI_PKG_ERRORS=`$PKG_CONFIG --errors-to-stdout --print-errors "ogdi"`
        fi
	# Put the nasty error message in config.log where it belongs
	echo "$OGDI_PKG_ERRORS" >&5

	{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
$as_echo "no" >&6; }
                :
elif test $pkg_failed = untried; then
	:
else
	OGDI_CFLAGS=$pkg_cv_OGDI_CFLAGS
	OGDI_LIBS=$pkg_cv_OGDI_LIBS
        { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
$as_echo "yes" >&6; }
	HAVE_OGDI=yes
fi
  if test "$HAVE_OGDI" = yes; then
    OGDI_INCLUDE=$OGDI_CFLAGS
    LIBS="$OGDI_LIBS $LIBS"
  else
    for ac_header in ecs.h
do :
  ac_fn_c_check_header_mongrel "$LINENO" "ecs.h" "ac_cv_header_ecs_h" "$ac_includes_default"
if test "x$ac_cv_header_ecs_h" = xyes; then :
  cat >>confdefs.h <<_ACEOF
#define HAVE_ECS_H 1
_ACEOF

fi

done

Should add --with-ogdi=no or add --with-ogdi=${SYSTEM_OGDI_PATH}  to vcpkg_configure_make.

For my set of changes wrt #9068, I plan to use --with-ogdi=no (and many more --with-...=no) unless using feature "system-libraries". In fact, I picked up all --with-... from configure.ac a few hours ago.
To appear in #17698 in the next days.

#17698 was merged a while ago. Is this issue still valid?

Please reopen this issue if it still exist.


Target both Net5.0 and 3.1 for core compiler and runtime assemblies.

Cross-repo change to add limited support for users that only have .Net5 installed.

@ricardo-espinoza: Is this PR still needed given .NET 6, or should we bring the changes into a different feature branch? Thanks!

This work has been superseded by a different plan to move into .NET 6 instead later this year.


Replace var.s3_website_password_enabled with Bucket Policy and CloudFront OAI

Describe the Feature
For var.website_enabled we should be able to use a Bucket Policy and an CloudFront OAI to make the bucket private and allow access only to CloudFront, rather than be limited to var.s3_website_password_enabled.
Example bucket policy:
{
  "Version": "2012-10-17",
  "Id": "PolicyForCloudFrontPrivateContent",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": ${jsonencode(dependency.cloudfront.outputs.cloudfront_origin_access_identity_iam_arns)}
      },
      "Action": "s3:GetObject",
      "Resource": "arn:aws:s3:::${local.bucket_name}/*"
    }
  ]
}

+1

@sebastianmacarescu sorry for the delay on this.
I've taken the liberty to edit the description and title for this issue to make it a bit more thorough. If I've misunderstood or misrepresented anything, please edit it again.
If I understand correctly, the feature request is to allow the use of a CloudFront OAI when var.website_enabled is true?
According to the CloudFront documentation, this is not possible (see: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-restricting-access-to-s3.html):

If you use an Amazon S3 bucket configured as a website endpoint, you must set it up with CloudFront as a custom origin. You can’t use the origin access identity feature described in this topic. However, you can restrict access to content on a custom origin by setting up custom headers and configuring your origin to require them. For more information, see Restricting access to files on custom origins.

If one wishes to use the bucket policy and CloudFront OAI, they must set var.website_enabled to false. Then, the CF distribution will use an S3 origin rather than a custom origin (S3 website) with a bucket policy and CloudFront OAI in the said policy.

@sebastianmacarescu sorry for the delay on this.
I've taken the liberty to edit the description and title for this issue to make it a bit more thorough. If I've misunderstood or misrepresented anything, please edit it again.

If I understand correctly, the feature request is to allow the use of a CloudFront OAI when var.website_enabled is true.
According to the CloudFront documentation, this is not possible (see: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-restricting-access-to-s3.html):

If you use an Amazon S3 bucket configured as a website endpoint, you must set it up with CloudFront as a custom origin. You can’t use the origin access identity feature described in this topic. However, you can restrict access to content on a custom origin by setting up custom headers and configuring your origin to require them. For more information, see Restricting access to files on custom origins.

If one wishes to use the bucket policy and CloudFront OAI, they must set var.website_enabled to false. Then, the CF distribution will use an S3 origin rather than a custom origin (S3 website) with a bucket policy and CloudFront OAI in the said policy.
This is done in the following places:
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/64bd6d97d0d1a07e5bd354513856e031dccfe1d1/main.tf#L102-L106
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/64bd6d97d0d1a07e5bd354513856e031dccfe1d1/main.tf#L32-L43
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/64bd6d97d0d1a07e5bd354513856e031dccfe1d1/main.tf#L115-L143
If I've misunderstood anything please feel free to update the thread, edit the description, and/or reopen the issue.

Thank you very much @korenyoni for the explanation. I have missed that.


I Need to Highlight the current day in calender

Hello paul,

I need to highlight the current day of a year in the given calender when ever the page gets loaded.
Each day of the calender have an hyperlink upon click it should take the user to other jsp page.

Hi there,
1 - You can achieve this by using the customDayRenderer function lik this :
// before init calendar you should declare a variable with currentDate;
customDayRenderer: function(element, date) {
    var $element     = $(element);
    var $parent      = $element.parent();
    if(currentDate === date) {
        $parent.addClass('currentDay');
    }
}

2- You can achieve this by setting the option style:'custom' and using the customDataSourceRenderer function lik this :
// first you should add your URL as a property of your event
customDataSourceRenderer: function(element, date, events) {
      var $element = $(element);
      $element.wrap('');
}


Add More File Types?

As of right now, I won't be focusing on this. Need to focus on the already existing file types and makes sure they are all able to be downloaded before moving forward.


CSV Files not uploading

when trying to upload a csv file, it seems like it is only importing the headers and storing these as field values.  but does not import any other data aside from the headers.  Subsequent attempts produces this error message:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'email' for key 'email'

Hi @ippikio,
Thanks very much for reaching out!
At the moment, the CSV importer cannot allow more than 1 of the same email value.
It seems that you have either partially imported some data of your CSV or you have the same email address already containing in the database.

I’m now closing this one. Feel free to open a new issue if you get other questions.
Have a great day!


(Agenda Bug) State change on REPEATING TODO's doesn't work

Describe the bug
When a TODO item is set to a SCHEDULED REPEAT (ex. +1d | +1w), it does not visually update into a done state nor remove itself from that day's view.
WORKS if you re-open agenda view. Seems to be a visual-update type of bug.
Steps to reproduce

Create a REPEATING TODO item.
Open agenda view.
Change the status of it.

Expected behavior
WHAT WORKS:

The TODO item successfully adds a property to itself (state DONE from TODO)
When you reload agenda view, that item is no longer visible for the day you set it done for
The other items still successfully display for other days

WHAT DOESN'T WORK:

The reason I noticed this issue was because after I hotkeyed the daily task for being DONE
It didn't update the visual of TODO -> DONE
Another thing it could have done was remove itself from my view, which it didn't either
Only AFTER I re-open agenda view, is the item gone for the day I finished it from.

WHAT I THINK THE PROBLEM IS:

I think adding some form of visual refresh after changing a TODO item's state would be enough to fix this issue.

POTENTIAL FIX:

Either visually changing the item to DONE (the same way it works in Agenda Mode with a NON-REPEATING TODO)
...or removing that day's TODO item from the view

Emacs functionality
No response
Minimal init.lua
Minimal init.lua:
https://github.com/nvim-orgmode/orgmode/blob/master/scripts/minimal_init.lua
Screenshots and recordings
No response
OS / Distro
MacOS
Neovim version/commit
0.8
Additional context
No response

I've noticed this as well. You can also r to refresh the Agenda and the done repeat disappears.
It's nice to have it stay :slightly_smiling_face:

Actually "staying" is a feature, because it allows to to undo changes in case you want. That's how Emacs work.

Yeah it also helps with figuring out what you did that day :sweat_smile:

Understood. Thanks, gentlemen.

Why close? The bug is still there :thinking:

I misunderstood you guys saying that it's intended to work this way because it's a feature

It is a feature. Here's how emacs does it:

And how it's in Neovim:

Only difference is that Emacs shows the "Done" keyword, even though it's not "Done" in the org file.

Also, there are plenty of cases of items not removing themselves even after a refresh event

This should not be happening. Make sure to test with minimal_init.lua

But it doesn't make sense to remove it from the Agenda if it's done. It still should be there so you can see what you did that day/time like with any other task no?

This issue pertains to repeating tasks, meaning that if you complete a daily task (for example "brush teeth"), you want to complete it for today but still leave it in your agenda for all the following days.
Setting the DONE property with timings is what happens currently, and on agenda refresh, it properly disappears from today's agenda view while remaining for all the following ones.
The issue at hand is it doesn't do this automatically as shown in the Emacs comparison. You must refresh to see it gone.

But it doesn't make sense to remove it from the Agenda if it's done. It still should be there so you can see what you did that day/time like with any other task no?

I am a meticulous person, as I am sure many of you are (we're using individually customized consoles to practically run our entire lives).
Because of this, I create numerous events (with cronjobs/reminders/etc to keep me in check with my scheduled tasks, meetings, etc.)
My daily agenda view, without being filtered, shows upwards of 50+ items per day (most are repeating).
Finishing a task for the day, no matter what it is, should remove itself from that day's agenda after completion.
Sure, I think it showing a green "DONE" status after you mark it done for that day is just fine, but the reasoning behind removing it on agenda refresh is so that you don't clutter your view with "DONE" tasks all throughout.
Now, to play devil's advocate; a different approach would be to create a separate system for "dailies" (as I like to call them) where they act differently than other tasks. I totally understand the mental benefit and positive reinforcement of seeing "DONE" items on your agenda whenever you look at it. If only there was a way to separate these two types of agenda-view tasks...
What are everyone's thoughts on tackling this issue? Bandage the problem with a plugin, or add this functionality to main? I could potentially create the plugin given some special APIs to the agenda view and its functionality.

@stoladev I would love to see that functionality in nvim-orgmode as well. It looks like vanilla orgmode already has something similar that could be used for your use case. Not sure about the orgmode terminology here. They call it a 'module', but it is not in the contrib repository like e.g. orgmode-contacts. Seems to be core orgmode :man_shrugging: which in turn means, it should be part of this repository actually

@jgollenz As this is my first time truly using peg mode (thanks to this amazing port), it's also the first time I've seen the specifics you've provided. That's exactly what I would categorize them as - habits.
The question now is do we:

Integrate this to base
Or
Make it a plugin
Or
Begin a framework similar to how eMacs's orgmode uses these plug-and-play modules.

#3 would require much more time but it would open the floodgates to other orgmode modules available on eMacs. Development would be as easy as porting the code over (granted that the initialization/enabling of addons process is mostly similar).
I suggest a framework where instead of packing all nvim-orgmode plugins in (ex) Packer, they can instead be handled (including installation/removal) through an orgmode_modules.lua file (or orgmode.modules.setup).
Rough ideas with much to polish, but I am willing to put in the effort for improving this fantastic port. It has done nothing other than improve my organization in all aspects. There is so much more to explore regarding the utilization cases of nvim-orgmode.

@stoladev we actually discussed org-habit before. I don't know how orgmode actually does things under the hood, but it looks like those modules are just single .el files that are shipped with orgmode (i.e. are in the orgmode package) and are then enabled on-demand. So your third point with a separate repository is not really how its done in vanilla orgmode (to my knowledge, which is very limited). That does not mean, that we could not do something like that.
Making it a plugin (point 2) is feasible, but again, does not exactly mirror how org-habit is handled in orgmode. What I called 'contrib repository' in my earlier post is really just this folder. I'd consider those to be plugins and stuff like org-habit as modules (to stick with the terminology on the orgmode website). So now we have three categories:

modules (ship with orgmode)
contrib plugins (don't ship, but are 'well known™')
plugins (whatever floats around the interwebs)

Your proposed way would combine all those into one framework, just dividing it up into plugins that we provide and plugins that other people wrote (please correct me, if I misunderstood). It has the benefit of unifying what a plugin is, but it also means that all the stuff that is now modules, need their own repositories (== overhead). Additionally, we would need to build our own package manager within this repository. That is beyond the scope of what this port is about in my opinion (@kristijanhusak might disagree). Also, I know of no nvim plugin that did go down this route. nvim-cmp does have a multi-repo infrastructure, but those also are just pulled with packer.
This conversation is valuable and I think we should move to #26 from here on ;)

Opening up the flood gates for plugins does sound promising :+1:
@stoladev I see your point for not crowding the agenda with small tasks. I use repeater tasks for larger things - like 1h music classes twice a week. So if I go back in the Agenda view I'd like to see them there as any other tasks.
It seems that the habit styling @jgollenz suggested allows users to go both ways, i.e. have habits disappear (along with a consistency plot, which sounds cool :sunglasses: )
So do we close this issue and we open 2 new feature requests - one for having normal completed repeated tasks stick (even though emacs orgmode doesn't support it :sweat_smile: ), and one for porting habit?

I investigated habits a little bit. They have their own set of additional functionality (see screenshot https://i.imgur.com/VYDkoPY.png), but are very similar to the classic recurring task. When you complete a habit for today, it's gone from the agenda (Check 1st July in Emacs on screenshot), so functionality to always keep them visible seems to not be working also in Emacs orgmode. My guess is that it's possible to have them always visible only with the custom agenda commands (https://github.com/nvim-orgmode/orgmode/issues/135), but those are still not done.
Since this is not a bug, I'm closing it in favor of https://github.com/nvim-orgmode/orgmode/issues/359. Discussion can continue there if necessary.


Implement GET REST EP for listing VC status

Duplicate https://github.com/hypersign-protocol/hid-node/issues/165


[incubator/rundeck] - Fix issues

What this PR does / why we need it:
Not working currently
Which issue this PR fixes
type is not a correct field inside a Configmap
indentation was not good in deployment.yaml

/assign @dwardu89

@Eviato
Could you sign DCO and bump the chart version to latest please? Thank you.

@Eviato could looks good to me, however there are problems that need to be addressed before i can mark it as mergeable

/hold


Toy example to show the use of NN-smoothing

We should think of a  toy example that showcases the usefulness of smoothing the epxression data. Haven't found a good one yer

Now we can turn off smoothing with smooth_mode="off", and we can use the new method "geneset_overlap" to compare the overlap (or scoring) with and without smoothing.

This was addressed in the paper.


Bump kotlin-wallet-sdk version

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.

What
kotlin-wallet-sdk 0.8.0 is released, use the stable version instead.
Why
Shouldn't be using snapshot version forever.
Known limitations
N/A

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr947.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr947.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr947.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr947.previews.kube001.services.stellar-ops.com/


fix(java): Omit IT prefix from test that uses mocks

Renaming this test name to prevent it from being categorized as an integration test.
Currently, the use of Mockito causes problems when using native image testing (run mvn test -P native locally). Ideally we want to only include integration tests and unit tests in generated libraries for native image testing since they don't use Mockito. We filter on the presence of these test naming conventions. Renaming this test will allow us to skip it for native image testing.

Thank you for the review @anguillanneuf! Ah it looks like some tests in this class are talking to a GCLOUD_PROJECT which requires some additional configuration for the unit tests ci. Will try to look for a better way to handle this.


Relation to JSON Schema

Are there any plans to support JSON Schema? My impression is not, but either way the answer should be prominently stated in README. Otherwise the similarity of the library name gives false hopes to people like me.

No, it seems like that would be a whole project by itself.
You're welcome to submit a PR if you want. I would also be open to renaming this project entirely, although that might not be possible with it already being on Hackage under this name

i agree that this should be stated in the README, it's very confusing


segmentation fault

Hi @lijx10 Thank you so much for your sharing. I tried PCLKeypoint and installed it successly, but I always get segmentation fault whenever I tried to use keypointSift or other functions. I have tried on Ubuntu and Mac but neither works (for Mac, I got segmentation fault when I import it). I wonder have you ever met such problems?

Hi, have you solved the segfault? I haven't encounter such problem before.
One possible problem is whether the point cloud is Nx3 or 3xN? I am not
sure.
XuyangBai<EMAIL_ADDRESS>于 2019年10月29日周二 下午12:30写道：

Hi @lijx10 https://github.com/lijx10 Thank you so much for your
sharing. I tried PCLKeypoint and installed it successly, but I always get segmentation
fault whenever I tried to use keypointSift or other functions. I have
tried on Ubuntu and Mac but neither works (for Mac, I got segmentation
fault when I import it). I wonder have you ever met such problems?
[image: 屏幕快照 2019-10-29 上午11 29 36]
https://user-images.githubusercontent.com/15166089/67735536-68399a80-fa3f-11e9-9ed3-398082b9cd00.png
[image: 屏幕快照 2019-10-29 上午11 29 00]
https://user-images.githubusercontent.com/15166089/67735538-696ac780-fa3f-11e9-819d-0ae07642e8c2.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lijx10/PCLKeypoints/issues/1?email_source=notifications&email_token=AC5G72JPEFC33JGFWQYTFJLQQ6U67A5CNFSM4JGC6Z2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HU6ARJQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5G72M4TQNAAOCZQ3IOWH3QQ6U67ANCNFSM4JGC6Z2A
.

Hi @lijx10 It is a weird problem: I can't import both open3d and PCLKeypoint in the same file. Maybe it is a bug of open3d. When I do not use open3d and PCLKeypoint at the same time, everything works well. BTW, may I ask what's the parameter(like min_scale, min_contrast) you used for hand crafted methods(iss, sift, harris, sift) when evaluating repeatability on redwood dataset? I think the parameter in save_keypoints.py is for outdoor scenes.
Thank you so much.

This is a known issue of incompatibility between open3d and pytorch. You
have to import open3d before importing pytorch, otherwise there will be
segfault. Probably this is related to the cuda initialization done by both
open3d and pytorch.
Configurations of redwood:
Basically we do a param search for all methods to generate the best
possible repeatability for them.
ISS:
number of keypoints   |  parameters   |   repeatability at matching radius
r=0.05, average-min-max  |  repeatability at matching radius r=0.1,
average-min-max
4 0.6/0.6 0.0347-0-1 0.078-0-1
6 0.5/0.5 0.0294-0-1 0.069-0-1
9 0.4/0.4 0.0424-0-0.6667 0.092-0-1
17 0.3/0.3 0.0406-0-0.4545 0.1-0-0.5
41 0.2/0.2 0.0574-0-0.3333 0.142-0-0.5
77 0.15/0.15 0.0655-0-0.3148 0.19-0.02-0.56
125 0.12/0.12 0.0765-0-0.3065 0.23-0.03-0.581
180 0.1/0.1 0.097/0.074/0.2785 0.292-0.08-0.63
209 0.05/0.1 0.0883-0-0.3089 0.285-0.02-0.73
291 0.1/0.05 0.1137-0-0.488 0.278-0-0.82
434 0.05/0.05 0.1522-0-0.513 0.375-0.03-0.94
Harris3D
6 0.4/0.001 0.055-0-1 0.1152-0-1
8 0.3/0.001 0.1094-0-1 0.202-0-1
13 0.2/0.001 0.1314-0-0.75 0.2264-0-1
20 0.15/0.001 0.1453-0-0.8 0.2528-0-0.9286
45 0.1/0.001 0.1473-0-1 0.2713-0-1
131 0.05/0.001 0.0966-0-0.513 0.2301-0-0.8113
257 0.05/0.00001 0.1071-0-0.4508
0.2704-0.0124-0.7872
478 0.05/1e-8 0.0912-0.0017-0.3784
0.2568-0.0336-0.7387
SIFT3D
5 0.05-4-8-0.03 0.0046-0-1 0.016-0-1
7 0.05-4-8-0.025 0.0092-0-0.4 0.025-0-0.5
14 0.05-4-8-0.015 0.0253-0-0.4444 0.07-0-0.67
25 0.05-4-8-0.01 0.0353-0-0.4706 0.086-0-0.57
41 0.05-4-8-0.0075 0.0389-0-0.2692 0.105-0-0.54
87 0.05-4-8-0.005 0.0599-0-0.3889 0.155-0-0.6
128 0.05-4-8-0.004 0.0705-0-0.3333 0.191-0-0.5
238 0.05-4-8-0.0025 0.0899-0-0.315 0.263-0-0.6
468 0.05-4-8-1e-8 0.1253-0.0229-0.4114 0.364-0.09-0.81
XuyangBai<EMAIL_ADDRESS>于2019年11月1日周五 上午1:33写道：

Hi @lijx10 https://github.com/lijx10 It is a weird problem: I can't
import both open3d and PCLKeypoint in the same file. Maybe it is a bug of
open3d. When I do not use open3d and PCLKeypoint at the same time,
everything works well. BTW, may I ask what's the parameter(like min_scale,
min_contrast) you used for hand crafted methods(iss, sift, harris, sift)
when evaluating repeatability on redwood dataset? I think the parameter in
save_keypoints.py is for outdoor scenes.
Thank you so much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lijx10/PCLKeypoints/issues/1?email_source=notifications&email_token=AC5G72ITU4E67GBWNORSPYLQRMCHHA5CNFSM4JGC6Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECYNRGY#issuecomment-548460699,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5G72LEY7K62IP5PK4GBIDQRMCHHANCNFSM4JGC6Z2A
.

--
黎嘉信  Jiaxin LI
PhD, National University of Singapore
B.S., Tsinghua University
Mobile: 65-9094 1909 / 86-15201519053
Email<EMAIL_ADDRESS>/<EMAIL_ADDRESS><EMAIL_ADDRESS>

@lijx10  Thank you so much for your help !

Hi @lijx10 Could you please also share the configurations of KITTI or you just use the same parameter defined in save_keypoints .py for all number of keypoints situations ?


ContentCodingSpec failure

Huh?
[info] compare should
[error]   x be consistent with coding.compareToIgnoreCase for same quality (47 ms)
[error]    Falsified after 11 passed tests.
[error]    > ARG_0: ContentCoding(l, QValue(0.6900000000000001))
[error]    > ARG_1: ContentCoding(l, QValue(0.0))
[error]    > 690 is not less than 0 (ContentCodingSpec.scala:24)
[error] org.http4s.ContentCodingSpec.$anonfun$new$10(ContentCodingSpec.scala:24)

[error]   x be consistent with coding.compareToIgnoreCase for same quality (96 ms)
[error]    Falsified after 3 passed tests.
[error]    > ARG_0: ContentCoding(o, QValue(1.0))
[error]    > ARG_1: ContentCoding(o, QValue(1.0))
[error]    > 0 is not less than 0 (ContentCodingSpec.scala:24)


Florida statewide data has incorrect data

In the us/fl/statewide-addresses-state.geojson I see the following:
Notice the city is Saint Lucie County when the city is Fort Pierce. This is true from many entries.
{"type":"Feature","properties":{"id":"2324-141-0006-000-7","unit":"","number":"2481","street":"S JENKINS RD","city":"Saint Lucie County","district":"ST_LUCIE","region":"FL","postcode":"34950","hash":"7702e2037bbd9458"},"geometry":{"type":"Point","coordinates":[-80.383311,27.4203826]}}

Additionally from the us/fl/st-lucie-addresses-county.geojson I see the following where city & state is missing.
{"type":"Feature","properties":{"id":"","unit":"","number":"2481","street":"S JENKINS RD","city":"","district":"","region":"","postcode":"34947","hash":"87d1e718d87fde8b"},"geometry":{"type":"Point","coordinates":[-80.3831434,27.4203123]}}

As I mentioned in the other ticket (#5445), we aggregate data from other sources. It looks like both of these cases are present in the source data. At this point, we don't make changes to the source data that we fetch.
If you pull data from these sources and see that the data is correct, please let me know.

Where can I find the source data for this?  Since you have the lat/long this data could be enriched if data elements are missing.  I am looking to use this data as part of an expensive autocomplete replacement for all US addresses. Having accurate complete data will not only help me but this project too.

All of our sources are here: https://github.com/openaddresses/openaddresses/tree/master/sources
The first example you gave is this source file: https://github.com/openaddresses/openaddresses/blob/master/sources/us/fl/statewide.json and the second example is https://github.com/openaddresses/openaddresses/blob/master/sources/us/fl/st-lucie.json.
Look at the "data" attributes in there to see what we download.


Provide better error messages for invalid properties

Currently if someone typos a property name or just makes up a typo they get a pretty unhelpful error message:
Compiling Cookbooks...

       ================================================================================
       Recipe Compile Error in C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/test/recipes/kill.rb
       ================================================================================

       NoMethodError
       -------------
       undefined method `verison' for Custom resource chef_client_updater from cookbook chef_client_updater

       Platform:
       ---------
       x64-mingw32

It would be super helpful if we could rescue this and provide more context as to what the user probably did since this is probably a pretty common thing when you're getting started in chef or not using a IDE with chef extensions.

This is being handed by an RFC now

validation_message property partially helps here but we still need to improve the standard message

We might be able to improve typo detection with did you mean.


Land user back on the page they were on after voting for a proposal

Is your feature request related to a problem? Please describe.
Currently if a user is on the proposals page and votes on a proposal, after the TX, AstroDAO will land the user on the page of the proposal they just voted on, rather than on the proposals page where they previously were. This is confusing and makes it a pain to vote on multiple proposals at a time (such as approving weekly payouts).
Describe the solution you'd like
If a user is on the list of proposals page and they vote, land them back on that list of proposals page.

Implemented


Reduce irrelevant choices in account factory

Wrap account factory with UUID email aliases to delegated root email domain and call the "real" account factory.

descope from 1.0

I do not understand what's needed to solve this issue.
Do you want to build some custom UI to create new accounts?
Where do you want to have this? Some custom Service Catalog thingy?
I guess, this topic involves some detailed discussions. Descope from 1.1 ? ;)

Oh sorry, most def descope from 1.1 (it's not a bug). I think we have to discuss what exactly we really want here. Candidates include at least:

On every update of CT updating the SC product to wrap the original one and supplying root email aliases as addresses (making the email choices in the CT GUI irrelevant)
Creating a new SC product that calls the CT product with root email aliases and advertise this as the new standard via the dashboard

Maybe I miss something else?

A custom SC product sounds okay-ish. Or we can just decide not do this and create more awareness for the RootMail feature and how to make use of it when creating additional AWS accounts.

That would require the customers to call some lambda function to get an email address. Not really ideal IMHO ...

Why do you want to call a lambda function?

To get a new email address to put into the appropriate dialogue in the CT UI ...?

Since this has been descoped from 1.0 and now also 1.1 (I would rather have it in there), I'd like at least to re-add it to 1.2: We currently completely leave the user alone with workload account creation. They even don't know there is a mechanism to create root email addresses, so they also don't know they would need one. If they knew, they would not know how to create one without reverse-engineering superwerker (to find out that they need to call a Lambda). One of our recent users had the same struggle:

And is there a guide to adding a workload account + AWSPowerUser (say)? I've been through a bunch of pages, but get a bit lost on the SSO vs CT account terminology. I created an account, but not sure how to create a power user (to install / deploy an app env)

https://og-aws.slack.com/archives/C01CQ34TC93/p1616420425004600
@yawn @sbstjn since you descoped it from 1.1, what do you think? Shall we prioritize this again?

@yarn:
Can't I just use<EMAIL_ADDRESS>for a new account? Is it really needed to "generate" a new email address?
@s0enke:
If the solution to this is to create a custom UI, I don't think we can do this at the moment.

We descoped this initially from 1.1 to give priority to bugs. Now customers and users stumble upon the issue (or rather the lack of documentation) e.g. in #174. I think the issue mentioned in og-aws was actually about documentation ("what's next") and not so much about having an account vending machine that uses our root mail email solution but MMMV.
Regarding @sbstjn's comment: sure, we can use any email address following the plus / alias style that respects the length limit that the Control Tower Service Catalogue product imposes. Since we cannot "intercept" the call to the product we thought the cleanest solution would be to provision our own product, document it and call the official CT product from it (using generated e-mail addresses).
Such a product would later also enable features such as "pre-filled" products (e.g. creating accounts scoped to specific SSO groups or OUs) that we can then share with dedicated parts of the organisation (e.g. by OU). Creating a new SC product should not be that hard ...

If the solution to this is to create a custom UI, I don't think we can do this at the moment.

Nope, I would go for the proposed solution of creating a new SC product which in turn creates the workload accounts via  Account Factory. Most of the code for this can hopefully be re-used from the current pipeline fixture

So we agree - the fixture already covers quite some ground here. I'll have a go at it next ...

@sbstjn had the idea to use SSM Automation. This would also remove the need for a wrapper-CFN-stack:
description: Create AWS Account in Control Tower
schemaVersion: '0.3'
parameters:
  ProjectName:
    type: String
mainSteps:
  - name: GetCurrentVersion
    action: 'aws:executeAwsApi'
    inputs:
      Service: servicecatalog
      Api: DescribeProduct
      Name: AWS Control Tower Account Factory
    outputs:
      - Name: Version
        Selector: '$.ProvisioningArtifacts[0].Id'
        Type: String
  - name: ProvisionServiceCatalog
    action: 'aws:executeAwsApi'
    inputs:
      Api: ProvisionProduct
      Service: servicecatalog
      ProductName: AWS Control Tower Account Factory
      ProvisionedProductName: project-{{ProjectName}}
      ProvisioningArtifactId: '{{GetCurrentVersion.Version}}'
      ProvisioningParameters:
        - Key: ManagedOrganizationalUnit
          Value: "Project"
        - Key: AccountEmail
          Value<EMAIL_ADDRESS>        - Key: AccountName
          Value: "project-{{ProjectName}}"
        - Key: SSOUserEmail
          Value<EMAIL_ADDRESS>        - Key: SSOUserFirstName
          Value: "AWS Control Tower"
        - Key: SSOUserLastName
          Value: "Admin"

Additionally, we can easily enforce patterns for account names/emails and even have multiple automations for different account purposes/OUs/patterns. With granular restrictions to use ssm:StartAutomationExecution we can have a flexible account creation process. available in the cli as well:
$ > aws ssm start-automation-execution \
    --document-name "create-project" \
    --parameters "ProjectName=example"

AWS Chatbot supports running SSM documents/automations out-of-the-box. Nice addition to this approach, as we can easily create new AWS accounts from Slack then 😍


GPC-358: Add initial lambda

I've left a few comments around, I don't think these need to block merging, but might be easier to deal with now rather than later.


Use cache_tag in default build_platlib dir

Use sys.implementation.cache_tag instead of Python version to create
the default directory for build_platlib.  This guarantees that
the directories used by CPython and PyPy are distinct.  Prior to
the change, both CPython and PyPy would use e.g. lib.linux-x86_64-3.9.
With the change, they are going to use lib.linux-x86_64-cpython39
and lib.linux-x86_64-pypy39 respectively.

Hello, I'd like to advocate for a different name for these directories. There is a bit of a convention of using sysconfig.get_config_var("VERSION") for this purpose instead of sys.implementation.cache_tag, so these new cache directories will be named differently than most of the ecosystem expects.  For example

within distutils
how uwsgi does it

These directory names are used for significantly more than caching, so I believe VERSION is a bit more appropriate. See #107 for a bit of rationale and my proposed code change.


BUG: update Scorecard repo to use new error package

Update Scorecard repo to use the scorecarderrors.Create fns everywhere instead of fmt.Errorf

Closing this.


Added one DNS related lint. Fixed magic numbers in DNS related lints.

Fixed code according to request. Also, for the providence part, I don't really know of an efficient way to find real providence, nor do I know if such providence exists outside of awslabs certlint. I'd like to do this as the last step of the zlint project if possible.

Please run go fmt on this code. Can you please figure out how to have your environment do this? I've asked for this close to a dozen times now.

@kumarde once you've done a pass on this, I'll take a look,.

@zakird I've ran gofmt on all of them, which file in particular are you not happy with?

I haven't gone through in depth, but I can immediately tell you that that is false. To start, lints/lint_ext_san_dns_not_ia5_string.go has multiple indentation styles in the same file.

I'm sorry but I can neither see it by eyeballing, nor does "gofmt" or "go fmt" give me a different file.

Please add a test to this repository that runs go fmt on all of the files.

Merged in https://github.com/zmap/zlint/pull/71


Bumped branch alias

Bumping alias since there are now new features in master.

Any chance we could get a 9.8.0 release tagged too please?

@GrahamCampbell Tagged v9.8.0

👍


ConfigCube Projections for higher dimensions.

When dealing with more than three-dimensional HP-spaces, it may become spurious to look at 3d-slices. Maybe try some high-performing projection procedures? There is for instance UMAP and its successor. But be wary of transductive and inductive projections if you want to do it sequentially.

MDS


Support for developer.ibm.com videos

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running youtube-dl version 2021.05.16
[X] I've searched the bugtracker for similar feature requests including closed ones

Description

It would be great to gave support for videos from developer.ibm.com
Video example: https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/
youtube-dl output:
[debug] System config: ['--prefer-free-formats']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--ignore-errors', '--no-overwrites', '--add-metadata', '--keep-video', '-o', '%(title)s.%(ext)s', '--format', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best', 'https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.05.16
[debug] Python version 3.9.5 (CPython) - Linux-5.12.6-300.fc34.x86_64-x86_64-with-glibc2.33
[debug] exe versions: ffmpeg 4.4, ffprobe 4.4
[debug] Proxy map: {}
[generic] wd1_hopkins_emea_keynotes: Requesting header
WARNING: Falling back on generic information extractor.
[generic] wd1_hopkins_emea_keynotes: Downloading webpage
[generic] wd1_hopkins_emea_keynotes: Extracting information
ERROR: Unsupported URL: https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 814, in wrapper
return func(self, *args, **kwargs)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 835, in __extract_info
ie_result = ie.extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/generic.py", line 3520, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/

I am using youtube-dl version 2021-06-06, it is not working:
youtube-dl -v https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/ [debug] System config: ['--prefer-free-formats'] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'https://developer.ibm.com/conferences/aot-prevail/availability/wd1_hopkins_emea_keynotes/'] [debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8 [debug] youtube-dl version 2021.06.06 [debug] Python version 3.9.5 (CPython) - Linux-5.12.9-300.fc34.x86_64-x86_64-with-glibc2.33 [debug] exe versions: ffmpeg 4.4, ffprobe 4.4 [debug] Proxy map: {} [generic] wd1_hopkins_emea_keynotes: Requesting header WARNING: Falling back on generic information extractor. [generic] wd1_hopkins_emea_keynotes: Downloading webpage [generic] wd1_hopkins_emea_keynotes: Extracting information [ustream] 127810545: Downloading JSON metadata [ustream] 127810545: Downloading connection info [ustream] 127810545: Downloading stream info [ustream] 127810545: Downloading connection info (try 2) [ustream] 127810545: Downloading stream info (try 2) [ustream] 127810545: Downloading connection info (try 3) [ustream] 127810545: Downloading stream info (try 3) ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last):   File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 814, in wrapper     return func(self, *args, **kwargs)   File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 835, in __extract_info     ie_result = ie.extract(url)   File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 534, in extract     ie_result = self._real_extract(url)   File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/ustream.py", line 220, in _real_extract     self._sort_formats(formats)   File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1374, in _sort_formats     raise ExtractorError('No video formats found') youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.


i18n(pt-BR): Add astro-components.md & astro-pages.md translations

Translations for both astro-components.md and astro-pages.md.

@Yan-Thomas, those are just suggestions for improving.
Great work!

Thanks for the feedback @victor0x16!
Comment 'LGTM' when you think we are ready to merge 🚀

LGTM


Accept any number of exceptions

Hi,
It can be useful to catch multiple exception types.
Basic functionality is the same, but now you can also decorate like @retry(AttributeError, RuntimeError, ValueError), etc.
I added another test. Let me know if there's any issue with the PR and I'll fix it.

Yep, I can make more/better tests. Any thoughts on using a framework like unittest? Currently the tests seem somewhat fragile.

Yep, I can make more/better tests. Any thoughts on using a framework like unittest? Currently the tests seem somewhat fragile.

Definitely. You can also use pytest. I didn't realize it's not using a testing framework. If we use pytest, we can easily add a tox.ini similar to the timeout decorator: https://github.com/pnpnpn/timeout-decorator/blob/master/tox.ini

I am getting the following error:
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    from retry_decorator import __version__
  File "/home/travis/build/pnpnpn/retry-decorator/retry_decorator/__init__.py", line 8, in <module>
    from .retry_decorator import *
  File "/home/travis/build/pnpnpn/retry-decorator/retry_decorator/retry_decorator.py", line 14
    def retry(exception, *exceptions, tries=10, timeout_secs=1.0, logger=None, callback_by_exception=None):

I am going to revert the change. Feel free to resubmit

Can you post the error? It's not clear from the traceback alone what the problem is.


Proxies can be manually linked when still encoding

Problem
It seems that proxies can be linked when they haven't finished encoding yet. I don't know why this hasn't come up sooner.
Maybe the metadata is being written before encoding has finished and so passes Resolve's timecode/duration check when calling to link through the API?
Potential solution
Ideally linking would only be done automatically post-encode. Since the chance of a user performing a manual link before files are finished is high, we should prevent this files from being linkable. A simple solution would be to use a different filename while the file is encoding and rename it to its final name once finished. If ffmpeg will allow us to export the file to the same format with a modified extension, we could make this extension .part.
Otherwise we could add _part_ as a suffix to the filename just before the extension.
This will still be required once split and stitch encoding is implemented, pre/post joining segments.

This is likely to get reworked when chunking is implemented.


📖 Remove RTD and add Netlify

This removes our ReadTheDocs configuration and adds Netlify configuration, because this was much easier and more reliable in getting our docs previews running.
It also:

Move environment.yml to requirements.txt (since installing with pypi has less overhead than conda)
Adds an example of markdown-based computation

I believe that @rowanc1 has already added instructions on how to deploy to netlify here!
https://mystmd.org/guide/deployment-netlify

Indeed, but I think having badges and connecting the Github action for the main branch would also be important to document even if redundant. RTD is quite a common workflow for users of myst-parser and it would be nice to have it documented how they can get similar results in the other hosting providers that (currently) work well with mystmd


foreignObject Support inside SVG Elements

Expected behavior and actual behavior.
i need to use "foreignObject" Element to wrapping text inside svg elements.
This is currently not supported in plusnew.
Please integrate this feature ;)
Steps to reproduce the problem.
 {
            plusnew.createElement(
              'foreignObject',
              {
                x: 10,
                y: 0,
                width: 200,
                height: 200,
              }, null,

                Lorem ipsum dolor sit amed

,
            )
          }

Or as JSX:
  <svg>
          <rect cx="300" cy="200" r="100" fill="#FFFF33" width="250" height="100" />
          <foreignObject x="10" y="0" width="250" height="100">

              Lorem ipsum dolor sit amet, consectetur adipiscing elit.
              Sed mollis mollis mi ut ultricies. Nullam magna ipsum,
              porta vel dui convallis, rutrum imperdiet eros. Aliquam
              erat volutpat.

          </foreignObject>,
</svg>

Specifications like the version of the project or browser version
"plusnew": "0.6.46",

According to the specs, your given code shouldn't work. https://www.w3.org/TR/SVG11/extend.html
The specs say, that you have to give a xmlns attribute, to set the proper namespace.
<svg>
  <rect cx="300" cy="200" r="100" fill="#FFFF33" width="250" height="100" />
    <foreignObject x="10" y="0" width="250" height="100">

      Lorem ipsum dolor sit amet, consectetur adipiscing elit.
      Sed mollis mollis mi ut ultricies. Nullam magna ipsum,
      porta vel dui convallis, rutrum imperdiet eros. Aliquam
      erat volutpat.

  </foreignObject>
</svg>

But you are correct, that is currently not supported in plusnew.
I'll fix that.

is now fixed in https://github.com/plusnew/plusnew/pull/114


{Error} can help fixed

Hi.
can help fixed

not support domain?

Those appear to be live servers. Are you sure you have permission to exploit them?
Please read the help messages to fix your command.
You would want to run python3 exploit.py http://domain.xyz/owa/ <IP_ADDRESS> 8888 -c
Your message actually brings up a good point. No attacker IP or port would be necessary if you just want to check the vulnerability. Maybe I'll change that when I have time.


⚠ Bofrost.de has degraded performance

In b87912a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1084 ms

Resolved: Bofrost.de performance has improved in eae8a04.


undefined: config.DefaultSection in the develop branch

While running the example project chat with the develop branch of revel, I am getting this error
undefined: config.DefaultSection
which means a change that has been merged is breaking old projects.
Chat project works fine with the master branch.

This means you have not checked out the revel/config project on the develop branch

Oh sorry. My mistake. Is there a doc where i can know which all repos should be checked out for this to work? I ran into another undefined variable error after checking out config

What I do is look at my gopath and anything under src/github.com/revel I switch to develop


Figure out correct way to do AD callbacks for the logpdf in the custom adjoint

The MWE posted is
using Zygote, Distributions, DistributionsAD, LinearAlgebra, ChainRulesCore
function f(d, x)
    # Actually much more complicated...
    return logpdf(d, x)
end

d = MvNormal(zeros(2), Diagonal([0.1, 0.2]))
x = [0.1, 0.2]
f(d, x)
gradient(f, d, x)  # this works

with
function ChainRulesCore.rrule(config::RuleConfig{>:HasReverseMode}, ::typeof(f), d, x)
    print("In custom AD Rule")
    y = f(d, x)
    function pb(ȳ)

        # Is this it the way to do it? https://juliadiff.org/ChainRulesCore.jl/stable/rule_author/superpowers/ruleconfig.html#Writing-rules-that-call-back-into-AD
        x̄, d̄ = rrule_via_ad(config, logpdf, d, x) # ??? HOW TO USE ȳ

        return x̄, d̄
    end
    return y, pb
end

Solution from Michael Abbot along the lines of:
using Zygote, Distributions, DistributionsAD, LinearAlgebra, ChainRulesCore
function f(d, x)
    return logpdf(d, x)
end

d = MvNormal(zeros(2), Diagonal([0.1, 0.2]))
x = [0.1, 0.2]
f(d, x)

function ChainRulesCore.rrule(config::RuleConfig{>:HasReverseMode}, ::typeof(f), d, x)
    y = f(d, x)

    function pb(ȳ)
        _, pb_logpdf = rrule_via_ad(config, logpdf, d, x)
        _ignore, d̄, x̄ = pb_logpdf(ȳ)
        return NoTangent(), d̄, x̄
    end
    return y, pb
end

gradient(f, d, x)

Note that this is slightly wasteful in that it is evaluating the primal of the logpdf twice.  This can be fixed at some point by following the pattern in chainrules for mapreduce: https://github.com/JuliaDiff/ChainRules.jl/blob/a75193768775975fac5578c89d1e5f50d7f358c2/src/rulesets/Base/mapreduce.jl#L72
But probably not worth it in the short term.

Closing because we have the method for future extensions with general nonlinearity.