Performance degradation of StackFrameHelper that's shipped with 4.7.1

Run this code
public static void Main()
{
   for (int i = 0; i < 10000; i++)
   {
      new StackTrace(true).GetFrames();
   }
}

on Windows10 with .net 4.7.1 and it will take 5 seconds to complete.
Run this code on the same system without 4.7.1 and it will take 200ms
There is performance degradation in System.Diagnostrics.StackFrameHelper.InitializeSourceInfo

Looks like caching is broken and pdb files are loaded every time

It greatly affects unit test projects that use Moq framework. Internally, moq references the StackTrace class
https://github.com/moq/moq4/blob/master/Source/MethodCall.cs#L190

@lt72 do you know who we should get to take a look at this?

@batkaevruslan: when you are running without 4.7.1, which framework are you running against?
@chsienki @noahfalk FYI

@lt72  Actually, it doesn't matter. You may still target 4.6.1 for your projects. However, if you install net-471 on your machine, then you'll get the issue. BTW, Windows 10 creators update is shipped with 4.7.1 preinstalled.

as @StasPerekrestov said, it doesn't depend on target framework if 4.7.1 installed

@StasPerekrestov - regarding Moq's use of StackTrace in the code location you linked to (MethodCall.GetFileInfo): it's a nice to have feature, but nonessential, and I feel that it might eventually have to be dropped anyway--IIRC it's one of the bigger performance bottlenecks in Moq, right after expression tree compilation. (I checked a few months ago with perfview, I believe I didn't have .NET 4.7.1 installed then.)
Nevertheless, this regression should still be fixed IMHO.

@chsienki: Can you please give a look to this one as soon as you get a chance?

@chsienki is out so I've started taking a look a this instead. I believe I have reproed the behavior you are seeing, I agree the perf seems surprisingly slow and I'll be digging in to find out what happened and what we can do about it. Thanks for reporting the issue!

I just ran into this problem by our performance unit testing which suddenly became slower by a factor of 20+ due to calling StackTrace ctor for every EF6 query which trips through IDbCommandTreeInterceptor.*Executed in order to build per-callstack dictionaries of permance statistics.

@noahfalk Is there any more internal info about this performance decrease that might help us narrow down if this is the same issue we're seeing?
We have some reports about 4.7.1 greatly decreasing performance compared to 4.7.0.

I was hoping to validate some hypothesis first, but if its useful these are my unvalidated leads so far as to why the performance is slow:
In 4.7.1 we added support for parsing the Portable PDB format in the desktop framework. The code above that @batkaevruslan referenced in the images is attempting to do that parsing. However doing code review it appears the caching policy for the results of the portable PDB parse differ from the classic PDB format parse in two ways:
a) The cache only has a lifetime for a single stacktrace formatting operation. If multiple frames in a single stack trace use the same module the parse for the corresponding PDB will be reused, but it will not be used across different StackTraces.
b) The cache only saves positive results, the cases where it successfully parsed a portable PDB. In the example above there are 4 frames from mscorlib.dll which does not have a PDB adjacent to it or embedded inside of it. In each of these frames the parsing code will load parts of mscorlib.dll into memory and parse the PE format to check if there is an embedded portable PDB.
The differences in code are definitely there and I am reasonably convinced they will turn out to be the culprit, however I am working to setup a private build here at work with a different cache policy so that I can A/B test it. Its possible that there are further issues we haven't uncovered yet, or surprisingly these cache issues didn't contribute as severely to the performance as I'd expect.
@codecat - The easiest way to check if it is this particular issue affecting you is to collect an ETW trace using a profiler. Visual Studio has a profiler built-in or PerfView (https://www.microsoft.com/en-us/download/details.aspx?id=28567) is a standalone tool I often use. If you see a large amount of time spent inside the methods in the System.Diagnostics.StackTraceSymbols class then you are probably seeing the same issue.
For folks hitting this issue, if you have the option to stop collecting source line information you can call new StackTrace(false) instead of new StackTrace(true) and that should circumvent the problem. Definitely sorry, I know hitting these types of issues is aggravating and I am working on a better solution.

For folks hitting this issue, if you have the option to stop collecting source line information you can call new StackTrace(false) instead of new StackTrace(true) and that should circumvent the problem.

Seeing that @StasPerekrestov mentioned Moq (on which I've lately done some work), I'd just like to say that circumventing the problem this way is not really an option for Moq. We'd have to remove a fairly useful diagnostic feature.
I feel that this problem needs to be fixed (and soon) where it was caused: in the .NET framework.

In 4.7.1 we added support for parsing the Portable PDB format in the desktop framework.

Support for the new format is appreciated. I just hope it's possible to enable the new format without breaking old use cases...
@noahfalk: Thank you for looking into this problem. Your effort is much appreciated! Please keep us posted about a possible timeline for a fix.

I was able to verify that both of those caching issues mattered and changing them brings the benchmark down from ~6000ms -> ~350ms on my machine. After I get some sleep, tomorrow I'll see what I can learn about the remaining perf discrepancy.

I just hope it's possible to enable the new format without breaking old use cases...

That's certainly our goal as well. We strive for a high bar on back compat in the desktop .NET framework and we clearly fell short on this one. I'll do my best to make it right.

Further investigation showed that of the remaining 350ms, about 110ms comes from CAS asserts added to the implementation in 4.7.1, 40ms from one time costs jitting + once-per-module costs checking for portable PDB, and then the original 200ms are carried over from the 4.7 implementation. I'm optimistic the CAS costs can be significantly reduced and the jitting costs should go away once my test scenario is NGEN'ed (the framework is automatically NGEN'ed when you receive it via Windows update or MSI installer). The once-per-module cost checking for the portable PDB would be hard to reduce without getting rid of Portable PDB support.
At this point I think the performance issues are reasonably understood and focus is shifting to constructing the best fix and the logistics of distribution. Thanks for your patience and I'll continue to update the thread as I learn more.

@noahfalk you rock! Thank you for giving us a hand with the issue.

Nothing specific to report, just wanted to confirm that progress is very much ongoing.

Thank you!
7 нояб. 2017 г. 1:23 AM пользователь "Noah Falk"<EMAIL_ADDRESS>написал:

Nothing specific to report, just wanted to confirm that progress is very
much ongoing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/dotnet/issues/529#issuecomment-342307970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADxxvylitcNixiJGlVUUpxeFY3-xbapAks5sz4bigaJpZM4P_XWi
.

I just met with the servicing team, the fix for this was approved and it should be available in an upcoming release within a few months. I notice the friendly Moq devs also issued their own workaround (thanks!) so if you are in a pinch between now and the time that the .Net fix is available updating to the latest version of Moq should give you some relief.
I don't think I'll have anything else update-worthy while the gears of the testing/servicing/release process are running but if there are further questions I'll do my best to answer them or find someone else who can.

We may have a private version that folks can test to validate it. If you want in, contact me at rlander@ms.

We do have a fix for 4.7.1, and it will be available in a broad release soon. Likely in the January time frame.

We've also seen our test builds double in time after upgrading to .NET 4.7.1.  I tried emailing Rich to get the private version but haven't heard back (he's probably busy).  Can anyone else provide it?

Azure App Service in West US has rolled out Windows Server 2016 and .Net 4.7.1. Our production service has been dramatically slowed down! @lt72 when the fix is available in January, will that also be applied to Azure App Service?

I believe so, but @AlexGhiondea will know.
@noahfalk @chsienki FYI

Can anyone explain when to use them?

Hi @springy76! Some general information about them can be found here: https://github.com/dotnet/core/blob/master/Documentation/diagnostics/portable_pdb.md
Generally the situation where you need to use them is when you are doing .Net Core or Mono development on Linux or OSX and you want nice stack traces with source line information for your debugging. If you have an app that will only run on .Net Framework for Windows they are not necessary. We are trying to support them in .Net Framework so that eventually you could use one common format for everything rather than having to pick a different option on each OS.

Or why when using them, new StackTrace(true) does not provide any line numbers?

Apologies the messaging didn't get updated in a timely enough manner. You probably weren't doing anything wrong but unfortunately to fix the performance issue reported here in the short term we had to disable the portable PDB feature in 4.7.1. We aim to bring it back performantly in 4.7.2. This outcome wasn't our first choice and we were trying to fix the performance issue right away while leaving the portable pdb functionality intact. Sadly complications were discovered late in our patch testing process and we had to make a call to disable the portable pdb feature. Assuming you have the patch Alex refers to above then not seeing any source paths is now the expected behavior for Portable PDBs in 4.7.1.
Hopefully that makes sense and let me know if I can help with more questions.

Hi,

[09-Jan-2018] The fix for this issue is included in the Update for .NET Framework 4.7.1 - KB4054856 for all platforms except Windows 10 Fall Creators Update. This fix removes the Portable PDB functionality from 4.7.1. In 4.7.2 we anticipate having an improved fix available which both performs well and re-enables the portable PDB functionality.

When can we expect an update for Windows 10 1079 (Fall Creators Update)?
Thanks,
Nuno

@nmvgb the fix for Windows 10 Fall Creators Update is available now: https://support.microsoft.com/en-us/help/4058258/windows-10-update-kb4058258

Hi,
We've just tried 4.7.2 with portable PDB and line numbers still missing. Is the fix actually exists in 4.7.2?

In 4.7.2 we were more cautious with how the portable pdb stack trace functionality is enabled. To turn it on your application either needs to target 4.7.2 (aka set 4.7.2 as the framework target when you build) or you can opt-in to the functionality with an app config switch:
https://github.com/Microsoft/dotnet/blob/master/Documentation/compatibility/Stack-traces-obtained-when-using-portable-PDBs-now-include-source-file-and-line-information-if-requested.md
Hopefully one of those options gets it working for you, but if not please let us know.
HTH,
-Noah

Thanks, we've got it working.
VS GUI changes compilation targetFramework property and we have defined httpRuntime targetFramework in our project. Changing httpRuntime targetFramework manually did the trick. https://blogs.msdn.microsoft.com/webdev/2012/11/19/all-about-httpruntime-targetframework/

Last comment indicates this has been resolved.
This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

Last comment indicates this has been resolved.
This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


[Question] serverHttpRequest.getBody() takes a long time

Question
Occasional execution time is very long in production environment.

After adding the log, I found that this method was executed for a long time. The guess is that the later request was executed first, which led to the previous request being delayed for a long time.
How to solve

Through the test, it is found that it has something to do with the user's network speed, which is normal.


VS Code for the Web hangs in Safari

Open https://vscode.dev/github/microsoft/vscode
Open https://vscode.dev/github/microsoft/vscode-docs in the same tab
Click back/forward until you hit this

Back/Forward cache is the root cause of this - https://web.dev/bfcache/
There are some pending indexedDB transactions while the page is getting cached and this is causing the hang.
Closing the indexedDB connection as recommended fixes it.

@jrieken Please verify


Fix typo in the example

Just a trivial typo. :)

Hi, thanks! That's not a typo, see the description of NAMES in the config section. A / describes the split between subdomain and the domain managed by dnsimple you want to use to complete the challenge.
Maybe it goes too far but I wanted to be sure if you have, say, foo.org and sub.foo.org hosted at dnsimple and you wanted to authorize www.sub.foo.org you could list www/sub.foo.org in NAMES to work on the right domain via the api.
Suggestions welcome on how to make this better! Will close this for now.

Ops, sorry. I misinterpreted it.

No worries! Thanks to you and dnsimple for the tools to make this happen. :)


What is the alias for the server folder in Nuxt 4? “~/server” is not work

In Nuxt 4, particularly under the future: { compatibilityVersion: 4, } mode, I've tried using ~/server/... and<EMAIL_ADDRESS>as aliases to reference the server folder, but neither works. Currently, I'm using "~~/server/...", which seems to function.
Is this the correct alias for the server folder in Nuxt 4? If not, what is the proper alias I should be using?

~ and @
are aliases for the `srcDir` (in Nuxt 4 compatibility mode the default srcDir is /app), while ~~ and @@ are aliases for the `rootDir`, so yes if you want to reference to the /server dir, the way is

~~/server

Note that you should not import from the server/ directory in your Vue app. Instead, use the new shared directory (available in Nuxt v3.14+).

@danielroe You mentioned that I "should not import from the server/ directory" in my Vue app.
Here's a brief overview of my nuxt folder structure:
app/
server/
   api/
     test.get.ts
   email/
     types.ts

In my api/test.get.ts file, I'm attempting to import content from email/types.ts. Currently, I'm using the import path
import { someType } from "~~/server/email/types";
Could you please advise on the correct way to handle this import according to Nuxt's conventions?

move those files into a new shared/ directory parallel to server/ and app/

seems my previous example may have caused some confusion. The file I need to import is not one that needs to be shared between the /app and /server directories.
What I mean is, when I need to import another file that is also located within the server directory, for example, in server/api/todos.post.ts, I need to import ~~/server/email/somefun. I'm wondering if there should be an alias pointing to the server folder to replace ~~/server, such as importing #/email/somefun.
In Nuxt 4, app and server are completely separated, so just as we have the "~": "/<srcDir>",  alias, I think we should also have a "~": "/<serverDir>",   alias.


Update Crossfeed TXT records for acme

🗣 Description
We need to update the TXT record for the DNS to create a certificate for Let'sEncrypt. terraform-docs has been run.
Updated the existing api.staging.cyber.dhs.gov, but had to add the record for staging.crossfeed.cyber.dhs.gov (I believe this was deleted in a previous PR)
💭 Motivation and context
The original Crossfeed Staging Certs expired, and this will allow us to recreate them.
🧪 Testing
Ran terraform-docs to see if any changes were made to the docs
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

@dav3r This is a time sensitive push. If you can review at your earliest convenience that would be greatly appreciated.

@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.

Great thanks for the quick review. We will test now.

@aloftus23 - Please read the checkbox items carefully before clicking them.  You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.
I went ahead and made the necessary corrections for you.

@aloftus23 - Please read the checkbox items carefully before clicking them. You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.
I went ahead and made the necessary corrections for you.

My bad. Noted for next time.

@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.

Great thanks for the quick review. We will test now.

Let us know how the tests go.  If they are successful then I will merge this PR.

@aloftus23 - Any update on the results of your testing?

@aloftus - Any update on the testing results?

The certs were uploaded yesterday so just confirmed there are good and tested.

Huzzah!  I'll go ahead and merge then.


Update main.css

@rohitsen223 the css here is not proper, and make changes in the other PR I am closing this.


how to use require('node-request-interceptor')

I want to use the require method to load this module. I want to use this module in electronic. What can I do.

Hey, @zhaoxiaolei519109457.
You can use it according to the API docs.
const { RequestInterceptor } = require('node-request-interceptor')
const withDefaultInterceptors = require('node-request-interceptor/presets/default')

const interceptor = new RequestInterceptor(withDefaultInterceptors)
interceptor.use(req() => {
  // Provision your interception logic
})

Let me know if this helps.

Thank you for your reply, but it doesn't seem to be the correct answer. The following is the error reported in electro
[Window Title]
Error
[Main Instruction]
A JavaScript error occurred in the main process
[Content]
Uncaught Exception:
Error: Cannot find module 'node-request-interceptor/presets/default'
Require stack:

D:\project\electron-test\main.js
D:\project\electron-test\node_modules\electron\dist\resources\default_app.asar\main.js
at Module._resolveFilename (internal/modules/cjs/loader.js:972:15)
at Function.n._resolveFilename (electron/js2c/browser_init.js:249:921)
at Module._load (internal/modules/cjs/loader.js:848:27)
at Function.f._load (electron/js2c/asar_bundle.js:5:12694)
at Module.require (internal/modules/cjs/loader.js:1032:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object. (D:\project\electron-test\main.js:20:33)
at Module._compile (internal/modules/cjs/loader.js:1152:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:10)
at Module.load (internal/modules/cjs/loader.js:992:32)

My bad, that's a mistake in the import path.
-node-request-interceptor/presets/default
+node-request-interceptor/lib/presets/default

@kettanaito sorry to bother, but I'm having the same doubt here. I read the README file and saw that the presets are imported like:
import { interceptXMLHttpRequest } from 'node-request-interceptor/interceptors/XMLHttpRequest'

But the actual file is located at <node-modules>/node-request-interceptor/lib/interceptors/XMLHttpRequest.
I'm using babel to transpile my ES6+ codes, and I have to use:
import { interceptXMLHttpRequest } from 'node-request-interceptor/lib/interceptors/XMLHttpRequest'

to make it work. So is it a mistake of the README document?

Hey, @aprilandjan. Yes, that's a mistake in the README.
The presets are located at:
import withDefaultInterceptors from 'node-request-interceptor/lib/presets/default'
import { interceptClientRequest } from 'node-request-interceptor/lib/interceptors/ClientRequest'
import { interceptXMLHttpRequest } from 'node-request-interceptor/lib/interceptors/XMLHttpRequest'

Hey, @aprilandjan. Yes, that's a mistake in the README.
The presets are located at:
import withDefaultInterceptors from 'node-request-interceptor/lib/presets/default'
import { interceptClientRequest } from 'node-request-interceptor/lib/interceptors/ClientRequest'
import { interceptXMLHttpRequest } from 'node-request-interceptor/lib/interceptors/XMLHttpRequest'

Please, would you be interested to submit a pull request with the fix to the README?

Thanks for the reply! I just opened https://github.com/mswjs/node-request-interceptor/pull/91 for this, please review.


Add datasources for projects and global connections

Closes #288
Changes

Add a dbtcloud_projects (with an "s") datasource to return all the projects along with some information about the warehouse connections and repositories connected to those projects. Loops through the API in case there are more than 100 projects

Along with the check block, it can be used to check that there are no duplicate project names for example.

Add a datasource for dbtcloud_global_connection with the same information as the corresponding resource
Add a datasource for dbtcloud_global_connections (with an "s"), returning all the connections of an account along with details like the number of environments they are used in. This could be used to check that connections  don't have the same names or that connections are all used by projects.

CI passed 🚀


merge: test dst is a pointer

Maybe returning an error instead of panicking when func merge(dst, src interface{}, opts ...func(*Config)) error receives dst != pointer would be interesting?
In my case, it took me a good 30min to figure out that Merge expected a pointer as a first argument.
Reproducing the current isssue:
package main

import (
        "fmt"

        "github.com/imdario/mergo"
)

type A struct {
        B int
        C string
}

func main() {
        src := A{1, "s"}
        dst := A{B: 1}
        if err := mergo.Merge(dst, src); err != nil {
                fmt.Println(err)
        }
}

will panic:
panic: reflect: call of reflect.Value.Elem on struct Value

goroutine 1 [running]:
reflect.Value.Elem(0x4b4220, 0xc00000c080, 0x99, 0xc00007cd18, 0x203000, 0x0)
        /usr/lib/go/src/reflect/value.go:830 +0x1c3
github.com/imdario/mergo.resolveValues(0x4b4220, 0xc00000c080, 0x4b4220, 0xc00000c0a0, 0x3, 0x8, 0x8, 0x10, 0x203000, 0x58, ...)
        /tmp/Go/pkg/mod/github.com/imdario/mergo@v0.3.8/mergo.go:66 +0xb7
github.com/imdario/mergo.merge(0x4b4220, 0xc00000c080, 0x4b4220, 0xc00000c0a0, 0x0, 0x0, 0x0, 0xc00007cf20, 0x437e5a)
        /tmp/Go/pkg/mod/github.com/imdario/mergo@v0.3.8/merge.go:276 +0xc3
github.com/imdario/mergo.Merge(...)
        /tmp/Go/pkg/mod/github.com/imdario/mergo@v0.3.8/merge.go:227
main.main()
        /tmp/Lab/go/pointer-test/main.go:17 +0xec
exit status 2

With this PR
returns:
dst must be a pointer

Good contribution. Although in the method docs is clearly stated that dst must be a pointer to struct, it is an useful error.
We should probably add the same validation to Map, but let's merge this now.


Question: Why access_token is not updated with new scopes during refresh token request?

Hi Guys,
I have the following setup (for IdentityServer4 v1.5.2):
// Existing API resource
new ApiResource()
{
    Enabled = true,
    Name = "ExistingService",
    DisplayName = "ExistingService",
    Description = "Existing service API",
    ApiSecrets = new List<Secret>()
    {
        new Secret("secret".Sha256())
    },
    Scopes = new List<Scope>()
    {
        new Scope()
        {
            Name = "existingsrv",
            DisplayName = "ExistingService",
            Description = "Grants an access to the existing service"
        }
    },
    UserClaims = new List<string>()
    {
        JwtClaimTypes.Subject,
        JwtClaimTypes.Name,
        JwtClaimTypes.Role,
        "permission"
    }
}

// Client
new Client
{
    Enabled = true,
    ClientId = "ios.client",
    ClientName = "iOS application",
    AllowedGrantTypes = new List<string>()
    {
        "password",
        "activation_code"
    },
    ClientSecrets =
    {
        new Secret("secret".Sha256())
    },
    RequireClientSecret = true,
    AllowedScopes =
    {
        IdentityServerConstants.StandardScopes.OpenId,
        IdentityServerConstants.StandardScopes.Profile,
        IdentityServerConstants.StandardScopes.Email,
        IdentityServerConstants.StandardScopes.Phone,
        "existingsrv"
    },
    AlwaysSendClientClaims = true,
    AlwaysIncludeUserClaimsInIdToken = true,
    AccessTokenType = AccessTokenType.Reference,
    AccessTokenLifetime = 3600,
    AllowOfflineAccess = true,
    RefreshTokenExpiration = TokenExpiration.Sliding,
    RefreshTokenUsage = TokenUsage.OneTimeOnly,
    AbsoluteRefreshTokenLifetime = 2592000,
    SlidingRefreshTokenLifetime = 1296000,
    UpdateAccessTokenClaimsOnRefresh = true
}

Use case:

I would like to add new ApiResource:

// New API resource
new ApiResource()
{
    Enabled = true,
    Name = "NewService",
    DisplayName = "NewService",
    Description = "New service API",
    ApiSecrets = new List<Secret>()
    {
        new Secret("secret".Sha256())
    },
    Scopes = new List<Scope>()
    {
        new Scope()
        {
            Name = "newsrv",
            DisplayName = "NewService",
            Description = "Grants an access to the new service"
        }
    },
    UserClaims = new List<string>()
    {
        JwtClaimTypes.Subject,
        JwtClaimTypes.Name,
        JwtClaimTypes.Role,
        "permission"
    }
}

Then I update existing client with new scope:

// Existing client
new Client
{
    ClientId = "ios.client",
   ...
    AllowedScopes =
    {
        IdentityServerConstants.StandardScopes.OpenId,
        IdentityServerConstants.StandardScopes.Profile,
        IdentityServerConstants.StandardScopes.Email,
        IdentityServerConstants.StandardScopes.Phone,
        "existingsrv",
        "newsrv" // New scope
    },
    ...
}

The question is:
All existing reference tokens are not updated with new scopes during refresh token request (Please find info about updated reference token from Data column in PersistedGrants table):
{
	"Audiences": ["https://identityserve.azurewebsites.net/resources", "ExistingService"],
	"Issuer": "https://identityserver.azurewebsites.net",
	"CreationTime": "2018-02-08T07:20:23.5750403Z",
	"Lifetime": 3600,
	"Type": "access_token",
	"ClientId": "ios.client",
	"AccessTokenType": 1,
	"Claims": [{
		"Type": "client_id",
		"Value": "ios.client",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "email",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "openid",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "phone",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "profile",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "existingsrv",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "scope",
		"Value": "offline_access",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "sub",
		"Value": "760db5c0-0993-e711-80c2-000d3a223498",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "auth_time",
		"Value": "1518074423",
		"ValueType": "http://www.w3.org/2001/XMLSchema#integer"
	}, {
		"Type": "idp",
		"Value": "local",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "amr",
		"Value": "activation_code",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "role",
		"Value": "Member",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "name",
		"Value"<EMAIL_ADDRESS>		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "given_name",
		"Value": "Test",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}, {
		"Type": "family_name",
		"Value": "Test",
		"ValueType": "http://www.w3.org/2001/XMLSchema#string"
	}],
	"Version": 4
}

As a result I have to re login to have an access to new ApiResource. Is it correct?
I have checked the code and seems like only old scopes are taken into account during refresh: https://github.com/IdentityServer/IdentityServer4/blob/becb2206826b1039687b3ec895fad5e1b26ef0c5/src/IdentityServer4/ResponseHandling/TokenResponseGenerator.cs#L204
In addition I'm seeing the following messages in logs for all users which were authenticated before adding new ApiResource:

Failed token introspection: "API not authorized to introspect token", for API name: "NewService"
Expected scope ["newsrv"] is missing in token

Refresh tokens can't be used to gain access to scopes beyond those of the original grant. That's covered somewhere in the spec.... I don't recall where.

I understood, thanks. Looks like you are talking about RFC 6749:
"The requested scope MUST NOT include any scope not originally granted by the resource owner, and if omitted is treated as equal to the scope originally granted by the resource owner."

@Iamcerba So when the server is updated with new resource, how can client keep the login state to avoid invalid token scope?
Is it recommend to customize the refresh token flow?


Add support for Python issue tracker

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1384851-add-support-for-python-issue-tracker?utm_campaign=plugin&utm_content=tracker%2F47&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47&utm_medium=issues&utm_source=github).

Please describe what can be expected. Does this mean that https://bugs.python.org will be supported?


Fix architecture diagram

In the Rancher architecture diagram, the right-hand cluster shows to have EKS nodes and RKE master. It should show an EKS master instead.
https://rancher.com/docs/rancher/v2.x/en/overview/architecture/#rancher

Closing this issue because it is addressed by https://github.com/rancher/docs/pull/1960


⚠ Bofrost.at has degraded performance

In 6613fae, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2219 ms

Resolved: Bofrost.at performance has improved in 438c1c7 after 28 minutes.


Update to Python 3.12

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/bin/f2py-f90wrap", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/site-packages/f90wrap/scripts/f2py_f90wrap.py", line 214, in main
    numpy.f2py.main()
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/site-packages/numpy/f2py/f2py2e.py", line 766, in main
    run_compile()
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/site-packages/numpy/f2py/f2py2e.py", line 738, in run_compile
    builder.compile()
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/site-packages/numpy/f2py/_backends/_meson.py", line 176, in compile
    self.sources = _prepare_sources(self.modulename, self.sources, self.build_dir)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/site-packages/numpy/f2py/_backends/_meson.py", line 188, in _prepare_sources
    shutil.copy(source, bdir)
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/shutil.py", line 423, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/home/conda/feedstock_root/build_artifacts/quippy_1706031483915/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.12/shutil.py", line 240, in copyfile
    raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: 'f90wrap_Atoms_types.f90' and './f90wrap_Atoms_types.f90' are the same file
make[1]: Leaving directory '$SRC_DIR/build/linux_x86_64_gfortran'
make[1]: *** [Makefile:118: quippy/_quippy.cpython-312-x86_64-linux-gnu.so] Error 1
make: *** [Makefile:217: quippy] Error 2


Exported object with multiple materials has only one material assigned

Hi, I have an object exported from Unity in glTF format which has 2 material, each material with different textures. When imported into Blender one material is assigned to the whole object, while the other material is unused.
The same object loaded in three.js is loaded with the two materials assigned correctly.
Level.zip

I can't reproduce.
I have 24 faces assigned to HD_Wall_01_Norm_mod, and 48 faces assigned to HD_Wall_02_Norm_mod.
Can you please shared to .blend file ?
What version of blender do you use ?

(Seems that some TEXTCOORD are not well assigned in HD_Wall_01_Norm_mod). Will check it

Hi @julienduroure, I've attached the .blend file.
Level.blend.zip
This is the result I got in Blender after importing the model:

On your file, both materials are assigned. So I am not sure to anderstand your problem.
Do you have a screenshot from Unity?

This is the result loading .glb + textures on https://gltf-viewer.donmccurdy.com, and that's how the model looks in Unity.

Should be fixed now!


Can't change email address of John Doe admin user -> invalid signature

Hi,
So I just installed Helper from scratch. It is running behind a ssl terminating reverse proxy under a domain name like this https://helper.example.com.
When I try to change the John Doe admin user's email address, I get the verification email but when I click on the link, Helper displays "Invalid Signature".
What might be the problem?
Thanks!

The "Invalid Signature" error you're seeing when clicking the verification link in the email is typically related to a mismatch between the signature generated in the URL and the server's signature verification process. This can happen when the application is behind a reverse proxy, particularly when SSL is terminated at the proxy.
1. Session Configuration (Signed URLs and Session Handling):
Laravel uses signed URLs to ensure the integrity of the data. When you're behind a reverse proxy or load balancer, sometimes the session or signature verification may fail if the configuration isn’t set up to handle it properly.
Update the session domain in your config/session.php file:
'domain' => env('SESSION_DOMAIN', '.example.com'), // Set the correct domain here
Make sure that the session cookie is set to work across all subdomains (e.g., .example.com for helper.example.com).
Also, verify that your APP_URL in .env is set correctly:
APP_URL=https://helper.example.com
2. SSL and Trusted Proxies:
Laravel needs to be aware of the fact that it is behind a proxy and SSL is terminated outside the application. Without this, Laravel may not correctly identify the scheme (HTTP or HTTPS) or might incorrectly handle the proxy headers.
In app/Http/Middleware/TrustProxies.php, ensure that the middleware is correctly handling the proxy. You should have something like this:
use Illuminate\Http\Request;
use Fideloper\Proxy\TrustProxies as Middleware;

class TrustProxies extends Middleware
{
    /**
     * The trusted proxies for this application.
     *
     * @var array
     */
    protected $proxies = '*'; // You can limit this to your proxy's IP

    /**
     * The headers that should be used to detect proxies.
     *
     * @var int
     */
    protected $headers = Request::HEADER_X_FORWARDED_ALL;
}

3. Verify APP_KEY:
The "Invalid Signature" error can also occur if there’s an issue with your APP_KEY. The key used to generate the signed URLs may be incorrect or mismatched.
Ensure your .env file has the correct APP_KEY:
APP_KEY=your_base64_encoded_key
Or generate it :
php artisan key:generate
4. try cleaning the cache :
php artisan config:clear
php artisan cache:clear
php artisan session:clear

Hope it helps !


Gate the use of serde_urlencoded on a feature, use serde_qs otherwise

I'm willing to implement this and submit a PR if it would be accepted. Would the new feature gating serde_urlencoded be called serde_urlencoded or something else?

I forget what this issue is about. @jbr do you recall whether this was for compat purposes, or if there were other considerations?


Armstrong number in a given range

Proposal
i would like to add this tool, please assign it to me

@shonali2600 I had already added the issue and it was closed #1286


As a bank user, adding an item to a pre-existing request inserts it at the top of the item list rather than at the bottom where I have to be to click the Add another item button.

Summary
As a bank user, adding an item to a pre-existing request inserts it at the top of the item list rather than at the bottom where I have to be to click the Add another item button.
Screenshots
Here, I'm a bank user looking at a pre-existing request list:

And when I've clicked the button, the new item is second from the top:

Source
Lee Ann and Judi brought it up as a usability issue during our sync with them at RfG 2021.
Things to Consider

OPTIONAL If you happen to know that this particular issue will touch other parts of the application in non-obvious ways (maybe there are side effects, or there are other parts of the application that depend on the thing that needs to be changed), you can list them out here. This is an opportunity to share domain knowledge that you might have about the problemset.

Criteria for Completion

This should be a bulleted list of items that, if satisfied, would result in an acceptably complete Pull Request. Be as specific as you need to be. For example:

[ ] When a bank user adds another item to a pre-existing request, it shows up as the last item in the request list.

Bonus Round

OPTIONAL This can be additional work that is related to the work performed but might be more challenging or require a little extra effort to resolve. It's NOT required for the PR to be accepted and merged. Usually if this work isn't performed it would be created in a separate issue later. For example:

[ ] Stretch: drop-down is automatically opened for user to select which item they're adding.

Note: Rachel (and Megan, I think) also confirmed that this is an issue.

Editing an audit has the same issue when adding a new item to an existing audit. The form works as expected on the new view

Editing an audit has the same issue when adding a new item to an existing audit. The form works as expected on the new view

Ah, good find :+1:


[REQ] Move to yarn

##What makes this requirement necessary?

Will it add value?
Yes

What problem does it solve?
Takes care of some inefficiencies in npm

##What is needed to implement this requirement?

Will it require additional resources beyond the core system? (cloud, assets, etc)

No

Are extra contributors needed?

No

Are upgrades to existing packages and such needed?

Sort of, need to make sure yarn is installed and that lock files are properly dealt with

This was completed already, just not updated here


Add "All my preprints" as permanent collection to My Projects [OSF-7032]

Purpose
To support the preprint pages, add a section to MyProjects to show a system collection with user preprints and highlight preprints with separate color.
Changes

Add "All my preprints" as system collection
Add fa-file-text icon to indicate which projects are preprints wherever they are rendered in the project organizer
Add small box in information panel to denote a project is a preprint
Preprint links go to preprints/guid rather than project page.

See numbers shown in attached screenshot.
Ticket
https://openscience.atlassian.net/browse/OSF-7032
Screenshot

TODO

[x] No preprints empty message
Orphaned Preprints (No api endpoint for this yet)

🎉 🐧 🎉 This is good once it passes Travis.

@brianjgeiger I don't think this Travis fail is due to the code here but I'm not sure, can you check?
 ✗ creates new identifiers
	TypeError: Fake XHR onreadystatechange handler threw exception: 'undefined' is not an object (evaluating 'response.data.map') (/home/travis/build/CenterForOpenScience/osf.io/website/static/js/tests/tests.webpack.js:131124:0 <- webpack:///website/static/js/contribAdder.js:257:0)

It's not. I restarted https://travis-ci.org/CenterForOpenScience/osf.io/jobs/160243422

hey @brianjgeiger is this good to go?

Yup. If you need me to do merging etc, switch it to an OSF Ticket with a component of "improvement" and put it into the Passed CR column in the current sprint.

@brianjgeiger I updated the PR to show the correct ticket information for the ticket on OSF


Optional required params

Right now all propTypes declared are given return values. It's a good default but we should make the data realistic by allowing non-required fields to be randomly not included in the output.
When the required option is false, the data would only have a 50% chance of being emitted. Maybe it would be good to allow that percentage to be a config as well?

Initial work on this was completed. Open to more control over the randomness level if there's a good request for it.


Setter sets wrong value if precision: 0

.maskMoney('mask') apply the mask to your input. This method can work as a setter as well, if you pass a value to it, like this .maskMoney('mask', 1999.99)

If precision is set to 0, the setter writes a wrong value into the field (version 3.0.2).

jQuery( '.my-field' ).maskMoney({ precision: 0 }).maskMoney( 'mask', 1000 );

This writes 10,000 into the field, instead of 1,000
http://jsfiddle.net/fC5Ar/1/
PS. I can't select the value in the field with the mouse, or click in the middle of the value, why not?
Edit: Went back to 2.1.2 now, both problems are solved there.

sorry for taking so long to reply guys. I've fixed it in master, but I want to fix a few more problems that I've found and already created the test cases. If someone want to help, here's these two tests are failling https://travis-ci.org/plentz/jquery-maskmoney (they're related). Once I've fixed those two, I will do a release and notify you :)

Wondering when this is likely to be released?


Fixed number of stripes on US flag

This addresses issue 76.

Hi, unfortunately we will not change the size of the assets.
It is not ment to be an exact representation of the flags.


Bug - Mermaid gantt chart

I tried to create a more extensive template based on the template provided here.
But once I added a few additional checkboxes I get the following error:

System: Windows 10
Obsidian: Latest
Plugin 0.5.8
Error

```mermaid
gantt
    dateFormat  HH-mm
    axisFormat %H:%M
    %% Current Time: 21:54:38
    section Tasks
         :07-00, 180mm
    Reading     :12-00, 30mm
    Reading     :13-30, 60mm
    Review notes and update daily note [[20201103]]     :15-30, 30mm
         :16-00, 30mm
    Walk     :16-30, 0mm
    Reading     :16-30, 50mm
    Prep for tomorrow's meetings     :17-20, 340mm
    te     :23-00, 60mm
    END     :24-00, 0mm
    section Breaks
    BREAK     :10-00, 120mm
    BREAK     :12-30, 60mm
    BREAK     :14-30, 60mm

All tasks need a descriptive text. Task at 7:00 and 16:30 have no name and that makes mermaid crash.


.NET Core 3.0 support

Is this being worked on and is there any ETA?

Have you tried using config variables to point to 3.0 release?

Sorry, I am a bit green with Ansible. I see this is mentioned in the readme and my team confirmed this was an option as well. We'll give it a try. I'll try to leave feedback here with how it goes.

Sorry, I am a bit green with Ansible. I see this is mentioned in the readme and my team confirmed this was an option as well. We'll give it a try. I'll try to leave feedback here with how it goes.

Works flawlessly:
dotnet_package: "dotnet-sdk-3.0"

Thank you for this role!

Thank you @till for your comment. @dude0001 I hope that helps.


[WIP] Add sharding support for E2E test artifact generation

This adds sharding support by doing the following:

Create strided CMake targets that can be built individually
Add a matrix strategy to the artifact generation workflow
Change the glue code in build_e2e_test_artifacts.sh accordingly.

It seems like we try to shard the building steps here? I think what we want is to shard the execution steps. Currently we generate the strategy matrix here: https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_execution.yml#L54 to dispatch execution jobs on different target devices. It might be the right place to add the sharding mechanism.
That step parses an execution benchmark config exported in:
https://github.com/openxla/iree/blob/23666a604206fee145b5575f76d3a803f3448671/build_tools/cmake/build_e2e_test_artifacts.sh#L101C1-L104
The execution benchmark config describes a map of target_device -> list of benchmarks + artifacts to download. I'm thinking we can generate the benchmark config to have something like target_device -> [[benchmark shard1], [benchmark shard2], ...].

It seems like we are trying to shard the building step here? I think what we want is to shard the benchmark executions.

Yes. I'm aware. I started with that because Benchmark Large (example: https://github.com/openxla/iree/actions/runs/5226050090) is currently failing with a timeout in the artifact generation step and I wanted to find out if sharding would fix that. But I'm not sure if these compilations finish at all. They didn't on my machine while I was hacking this together. I assume @mariecwhite might know more.
Independently of that I will look into the sharding of the execution next. Thank you for the links.

It seems like we are trying to shard the building step here? I think what we want is to shard the benchmark executions.

Yes. I'm aware. I started with that because Benchmark Large (example: https://github.com/openxla/iree/actions/runs/5226050090) is currently failing with a timeout in the artifact generation step and I wanted to find out if sharding would fix that. But I'm not sure if these compilations finish at all. They didn't on my machine while I was hacking this together. I assume @mariecwhite might know more.
Independently of that I will look into the sharding of the execution next. Thank you for the links.

I also noticed the build timeouts on large benchmark set. I created this one https://github.com/openxla/iree/pull/14051 to fail any build target taking longer than 1hr and there are several:
FAILED: e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH24_module_129b48d3bbdad4b4333986b8a35fcafa8d4434fead6233154cecfbdab0ca23e6/module.vmfb /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH24_module_129b48d3bbdad4b4333986b8a35fcafa8d4434fead6233154cecfbdab0ca23e6/module.vmfb
cd /work/build-e2e-test-artifacts/tests/e2e/test_artifacts && timeout 1h /work/full-build-dir/install/bin/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80 /work/build-e2e-test-artifacts/e2e_test_artifacts/model_173c7180-bad4-4b91-8423-4beeb13d2b0a-MODEL_T5_LARGE-fp32-JAX-512xi32-batch24_T5_LARGE_FP32_JAX_512XI32_BATCH24.mlirbc -o /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH24_module_129b48d3bbdad4b4333986b8a35fcafa8d4434fead6233154cecfbdab0ca23e6/module.vmfb --iree-hal-executable-object-search-path=\"/work/build-e2e-test-artifacts\"
[445/448] Generating /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH32_module_3dcbc01e07ee34df7e5535dd0be85071685655d51331314b7a17517feb74ed3b/module.vmfb from T5_LARGE_FP32_JAX_512XI32_BATCH32(stablehlo) [cuda-sm_80-linux_gnu-cuda][default-flags]
FAILED: e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH32_module_3dcbc01e07ee34df7e5535dd0be85071685655d51331314b7a17517feb74ed3b/module.vmfb /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH32_module_3dcbc01e07ee34df7e5535dd0be85071685655d51331314b7a17517feb74ed3b/module.vmfb
cd /work/build-e2e-test-artifacts/tests/e2e/test_artifacts && timeout 1h /work/full-build-dir/install/bin/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80 /work/build-e2e-test-artifacts/e2e_test_artifacts/model_173c7180-bad4-4b91-8423-4beeb13d2b0a-MODEL_T5_LARGE-fp32-JAX-512xi32-batch32_T5_LARGE_FP32_JAX_512XI32_BATCH32.mlirbc -o /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH32_module_3dcbc01e07ee34df7e5535dd0be85071685655d51331314b7a17517feb74ed3b/module.vmfb --iree-hal-executable-object-search-path=\"/work/build-e2e-test-artifacts\"
[446/448] Generating /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH16_module_d7ff0ce530c700c18dc4704dfcb75ec14540bd0794faee823a3cc1cd62ea53df/module.vmfb from T5_LARGE_FP32_JAX_512XI32_BATCH16(stablehlo) [cuda-sm_80-linux_gnu-cuda][default-flags]
FAILED: e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH16_module_d7ff0ce530c700c18dc4704dfcb75ec14540bd0794faee823a3cc1cd62ea53df/module.vmfb /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH16_module_d7ff0ce530c700c18dc4704dfcb75ec14540bd0794faee823a3cc1cd62ea53df/module.vmfb
cd /work/build-e2e-test-artifacts/tests/e2e/test_artifacts && timeout 1h /work/full-build-dir/install/bin/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80 /work/build-e2e-test-artifacts/e2e_test_artifacts/model_173c7180-bad4-4b91-8423-4beeb13d2b0a-MODEL_T5_LARGE-fp32-JAX-512xi32-batch16_T5_LARGE_FP32_JAX_512XI32_BATCH16.mlirbc -o /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH16_module_d7ff0ce530c700c18dc4704dfcb75ec14540bd0794faee823a3cc1cd62ea53df/module.vmfb --iree-hal-executable-object-search-path=\"/work/build-e2e-test-artifacts\"
[447/448] Generating /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH48_module_e70546885f5488d986fffccc21a118d82aa7933b7dccfe47b0093591e081231f/module.vmfb from T5_LARGE_FP32_JAX_512XI32_BATCH48(stablehlo) [cuda-sm_80-linux_gnu-cuda][default-flags]
FAILED: e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH48_module_e70546885f5488d986fffccc21a118d82aa7933b7dccfe47b0093591e081231f/module.vmfb /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH48_module_e70546885f5488d986fffccc21a118d82aa7933b7dccfe47b0093591e081231f/module.vmfb
cd /work/build-e2e-test-artifacts/tests/e2e/test_artifacts && timeout 1h /work/full-build-dir/install/bin/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80 /work/build-e2e-test-artifacts/e2e_test_artifacts/model_173c7180-bad4-4b91-8423-4beeb13d2b0a-MODEL_T5_LARGE-fp32-JAX-512xi32-batch48_T5_LARGE_FP32_JAX_512XI32_BATCH48.mlirbc -o /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_T5_LARGE_FP32_JAX_512XI32_BATCH48_module_e70546885f5488d986fffccc21a118d82aa7933b7dccfe47b0093591e081231f/module.vmfb --iree-hal-executable-object-search-path=\"/work/build-e2e-test-artifacts\"
[448/448] Generating /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_BERT_LARGE_JAX_384XI32_BATCH512_module_9f4cafa63a150cabdf61a945dc6a04c9ddac88b75260bb4ce668199cdddbd581/module.vmfb from BERT_LARGE_JAX_384XI32_BATCH512(stablehlo) [cuda-sm_80-linux_gnu-cuda][default-flags]
FAILED: e2e_test_artifacts/iree_BERT_LARGE_JAX_384XI32_BATCH512_module_9f4cafa63a150cabdf61a945dc6a04c9ddac88b75260bb4ce668199cdddbd581/module.vmfb /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_BERT_LARGE_JAX_384XI32_BATCH512_module_9f4cafa63a150cabdf61a945dc6a04c9ddac88b75260bb4ce668199cdddbd581/module.vmfb
cd /work/build-e2e-test-artifacts/tests/e2e/test_artifacts && timeout 1h /work/full-build-dir/install/bin/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80 /work/build-e2e-test-artifacts/e2e_test_artifacts/model_47cb0d3a-5eb7-41c7-9d7c-97aae7023ecf-MODEL_BERT_LARGE-fp32-JAX-384xi32-batch512_BERT_LARGE_JAX_384XI32_BATCH512.mlirbc -o /work/build-e2e-test-artifacts/e2e_test_artifacts/iree_BERT_LARGE_JAX_384XI32_BATCH512_module_9f4cafa63a150cabdf61a945dc6a04c9ddac88b75260bb4ce668199cdddbd581/module.vmfb --iree-hal-executable-object-search-path=\"/work/build-e2e-test-artifacts\"
ninja: build stopped: cannot make progress due to previous errors.

Created https://github.com/openxla/iree/issues/14067

Thank you, @mariecwhite!
Assuming the issue can be fixed and we get back to normal non-timeout compilation times: Do we still want (need) sharding for the artifact generation at some point? I could finish this PR or drop it. Like I said it was just an experiment and I'm fine with either way. (@pzread @mariecwhite)


Add _GLFW_VULKAN_STATIC build flag

This allows clients to link GLFW with a staticly-built loader library.
This is useful in hermetic build systems that build the Khronos loader
from source, rather than depending on the LunarG SDK binaries.

Argh, that's right,  I forgot to add this. Thank you!

Thank you again! It has been merged as 8bdb105897d262c477dc12f8934419de7e6947d9 and additional cleanup was added with 7c3706763a14a548e5f8f0071b4211f8bab03556.


ci: use in built docker gha caching for build

caching is probably less relevant really for this now we're not waiting on ozw to compile, and with zwjs is changing so much, we probably never benefit from the cache, so you could remove this entirely but this might at least simplify the steps in the meantime

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 28.366%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3712

Relevant Lines:
13772

💛  - Coveralls


Please make imagePath accept dataURL.

Is your feature request related to a problem? Please describe.
I've been moving more and more of my map icons into code, making canvases and exporting to use as Google Map markers. I'd like to use a generated marker for a cluster as well.
Describe the solution you'd like
I'd like to be able to set the imagePath property to a dataURL, or provide an optional "icon" property that matches Google marker scheme.
Describe alternatives you've considered
Requesting a pull to do it myself ;)
Additional context
It just looks like you are using the imagePath to pack a style object, so I'm not sure how accessible dataURLs are to CSS, if that's what's going on. However, I would love this feature, as I'm sure would others!

Does something like https://github.com/googlemaps/v3-utility-library/issues/617#issuecomment-585444211 match your needs?

Perhaps! However, I've just discovered that it works fine simply adding a hash to the end of the URL, which ignores the iteration and additional file extension. In my case (for now) they are all the same image so it seems to work fine fine.
new MarkerClusterer(map, markers, { imagePath: icon + "#" });

I think this is a case where we have too many ways to do things and the interface becomes confusing. Glad you found a solution!


[QUESTION] How do I get request/response auto logging with Fastify and pinoHttp custom config?

[x] I've read the docs of nestjs-pino
[x] I've read the docs of pino
[x] I couldn't find the same question about nestjs-pino
**Question
I've configured nestjs-pino on my nestjs project and everything seems to be working correctly with all the default settings. Except when I want to configure pino to have more human-readable logs in development suddenly I no longer get request/response auto logging.
How do I get request/response auto logging with Fastify and pinoHttp custom config?
Here's my custom configuration in my root module
    LoggerModule.forRootAsync({
      imports: [ConfigModule.forFeature(nodeConfig)],
      inject: [nodeConfig.KEY],
      useFactory: async ({ environment }: ConfigType<typeof nodeConfig>) => {
        return {
          pinoHttp: {
            autoLogging: true,
            formatters: {
              level: (levelLabel, levelNumber) => ({
                log: levelLabel,
                level: levelNumber,
              }),
            },
            useLevel:
              environment === NodeEnvironment.PRODUCTION ? 'info' : 'debug',
            prettyPrint: environment !== NodeEnvironment.PRODUCTION && {
              colorize: true,
              translateTime: true,
            },
          },
        };
      },
    })

When I remove the pinohttp configuration object from the return statement in the useFactory method the auto-logging works.
And here's main.ts setup as well.
  const app = await NestFactory.create<NestFastifyApplication>(
    AppModule,
    new FastifyAdapter({ keepAliveTimeout: keepAliveTimeoutMS }),
    { logger: false },
  );
  const logger = app.get(Logger);
  app.useLogger(logger);

Side note the setup for Fastify isn't very clear to me from/after reading docs. Should I be passing the { logger: false } option to the Fastify adapter or to the nest factory like I currently have it?
Appreciate the help!
Please mention other relevant information such as Node.js version and Operating System.
Running within a docker container on a node 14.15.3 Image.

Hi, have you installed pino-pretty?

@drxwskx ?

no response, closing

Hi, have you installed pino-pretty?

Yes, pino-pretty was installed...
Apologies for the late reply it was a long weekend/holiday here in Canada

Also like I mentioned the pretty print works fine but once it's enabled I no longer get auto-request / response logging which works when the pretty print is disabled.

So passing logLevel "debug" disables the auto logging

Ok no problem, reopening, but can you please create small repo with bug reproduction for me to quick jump into it? Can not help with only code samples because there are some other not related things (for example formatters, node env, and could be something more?)


Update Makefile

The URL id now dead. Some info on why.
https://groups.google.com/g/isl-development/c/JGaMo2VUu_8

Just to add the sha1 matches:
wget -qO - https://libisl.sourceforge.io/isl-0.21.tar.bz2 | sha1sum
33e366d59d32330432b5c7f2d0c2fb6664eff224  -

https://github.com/richfelker/musl-cross-make/blob/master/hashes/isl-0.21.tar.bz2.sha1


Prepare for Android 10.3.0 release

This branch contains some backports...

@HarelM I am afraid yes, because @JannikGM does not have Push access.

@JannikGM OK to merge now?


Suggestion on documentation structure

Problem statement
As a newcomer to LimboAI, the documentation hosted at https://limboai.readthedocs.io/en/stable/ felt a bit hard to understand.
For example, after navigating away from the index page, it is hard to find the installation instructions. They are not linked in the navigation menu and one has to remember that it's possible to click the logo / the little home icon bread crumb and that the info might be there. Especially on mobile that took me some time to find the instructions.
The pages are a bit mixed. Some GDExtension info is on the index page, some on a sub page. Same for C# support. Also Behavior Tree and HSM pages are a bit mixed.
Proposed solution
Make the page structure cleaner. A proposal could be:

Getting Started

Installation
Using LimboAI with C#

Behavior Trees

Introduction to Behavior Trees
Creating a behavior tree
Custom Tasks
...

Hierarchical State Machines

Introduction to HSM
Creating a HSM
Using Behavior Trees in state machines
...

If you like this idea, I can create a PR :)
Alternatives
No alternatives to propose.

I do like the idea. We may lack some content for such a structure, though, but if you're willing to work on it, I'd always welcome such effort 🙂

@limbonaut So the PR was merged, but I cannot see the updated docs yet. Did anything go wrong? Is there a way for me to check e.g. the deployment?

Unfortunately, as documentation updates are fully automated, we'd have to wait until next version. I think I'll simply revert the README changes.

I was not familiar with the release strategy of read the docs. After reading about that, I agree, reverting the readme changes sounds most reasonable. Thank you for rolling back!

No worries, I also forgot about the links, thanks for bringing it up.

Yup, it works again :+1:
As far as I'm concerned, this suggestion is resolved. Feel free to close the issue or keep it open as a reminder to re-revert for the next release -- it's up to you! :)
And thanks for being open and accepting my suggestions! Highly appreciated :)


feat: allow building pongo image from specially tagged test image

This change adds the possibility to specify a temporary test image as KONG_IMAGE, similar to using the 'dev' and 'dev-ee' pseudo versions. The image name contains the git tag from which it was built.  The added logic will determine KONG_VERSION and whether we're dealing with CE or EE from the image name

@hanshuebner  i was working on running pongo with current commit of build and found this PR might be related. is this PR still we want to persue? if so could you describe what's left/what's not working so i can pick up?

@fffonion If I remember right, this was pretty much working but nobody except myself tested it and it was basically forgotten.  I have no plans working on it, but feel free to involve me if there is anything I can help with to get it merged.


feat(react): implement signature-pad

Description
Add the implementation of @zag-js/signature-pad in React.
as part of #2497
https://github.com/chakra-ui/ark/assets/30840709/45524971-1d96-4d8c-80b8-c19a96abf027

Please let us know when you finish :)
I'll wait for Chris's response since I don't know if we are merging components without implementations for other frameworks

Yeah I think it's going to be missing the documentation page and the svelte/vue/solid components, right?
I don't known if you guys usually implement all of them once, but I can try start the Vue one later if needed.

@jeferson-sb
Amazing job buddy 🥂


Call for ticker_book

Do you also support ticker_book API calls?
I'm missing data like ask and bidprice in just price_ticker data.
Binance:
https://github.com/binance/binance-spot-api-docs/blob/master/rest-api.md#symbol-order-book-ticker
Bitvavo:
https://docs.bitvavo.com/#tag/Market-Data/paths/~1ticker~1book/get
If OK I will add the Bitvavo call.

Hi,
for binance, it is available here: https://github.com/nardew/cryptoxlib-aio/blob/master/cryptoxlib/clients/binance/BinanceClient.py#L156
For bitvavo it is not present. If you can create a PR, it will be very much appreciated.

@nardew done ;-)
https://github.com/nardew/cryptoxlib-aio/pull/43
https://github.com/nardew/cryptoxlib-aio/pull/42

Tip top, thanks. I will close the issue.

@cyberjunky version 3.9.0 available in PyPi


No explanation of where to configure real email and password information for sending

I have read all the documentation that I can find and watched all the screencasts and they all stop at how to TEST sending an email but none of them say where to configure your ACTUAL email address and password!

Which Adaptor are you using?

I'll be honest, I have no idea which one to use. I have tried SMTPAdapter because I have a Gmail account that I can use, but that's as far as I've gotten.

I actually set up a service using the SMTPAdapter for Gmail this week.
You have to add {:bamboo_smtp, "~> 2.1.0"} as a separate dependency in your mix.exs file, then add :bamboo_smtp to the list inside your application/0 function in mix.exs as well.
Then in the config file for whatever env you're developing in , add this code snippet, where you can insert your username/password for gmail.
config :my_app, MyApp.Mailer,
  adapter: Bamboo.SMTPAdapter,
  server: "smtp.domain",
  hostname: "your.domain",
  port: 1025,
  username<EMAIL_ADDRESS># or {:system, "SMTP_USERNAME"}
  password: "pa55word", # or {:system, "SMTP_PASSWORD"}
  tls: :if_available, # can be `:always` or `:never`
  allowed_tls_versions: [:"tlsv1", :"tlsv1.1", :"tlsv1.2"], # or {:system, "ALLOWED_TLS_VERSIONS"} w/ comma seprated values (e.g. "tlsv1.1,tlsv1.2")
  ssl: false, # can be `true`
  retries: 1,
  no_mx_lookups: false, # can be `true`
  auth: :if_available # can be `:always`. If your smtp relay requires authentication set it to `:always`.

Google's SMTP server is called smtp.gmail.com and listens on port 587

The above snippet is found here in the bamboo_smtp docs.
One caveat - you have to enable less secure apps (LSA's) in your Gmail settings since the SMTPAdapter does not use OAuth for authentication.

A word of caution
According to this post on Google's GSuite Updates Blog, in about a year you will no longer be able to enable LSA's to interact with Google services.
I have brought this up in issue #507.  I am considering writing an OAuthAdapter or GMailAdapter over the holidays to address this, but am waiting to hear back from the bamboo community about their thoughts on this.
For now, as long as your enable LSA's in your gmail account, you can still use bamboo with Gmail.

Ok cool, I had gotten that exact setup and even went so far as to get an API key from my GSuites account. It looks like I won't need the API key, but I didn't know about the Less Secure Apps part of it.
Sorry for the frustrated wording in the heading, I am recovering from Stack Overflow's community still it seems...If you are able to write a more future proof version of this to connect to Gmail then I will be one of the first to use it.


Getting an error on (every?) monster import.

Describe the bug
Getting errors importing monsters....
To Reproduce
Import any monster from D&D Beyond via Monster Munch.
Expected behavior
No error.
Screenshots

Environment:
Foundry Virtual Tabletop: Version 10, 10.288
Game System: dnd5e, 2.0.3
Active Modules: 47
Performance Mode: 2
OS: Unknown
Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
GPU: ANGLE (NVIDIA, NVIDIA GeForce RTX 3080 Direct3D11 vs_5_0 ps_5_0, D3D11)
Max Texture Size: 16384
Scene: 2000 x 1124 | Grid Size: 100 | Padding Percentage: 0
Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 6
Actors: 46 | Items: 26 | Journal: 20 | Rollable Tables: 1 |
Playlists: 4 | Compendium Packs: 52 | Chat Messages: 56

There are two key elements that you didn't answer in the bug report template. Please provide:

Module Version [e.g 3.1.21]
Does this behaviour occur with other modules disabled: Yes/No (Find The Culprit module can help with this)

I ask because this does not occur here, and the most likely outcome is that one of the other modules is changing/adjusting the model data.
The other option is that the default token settings in your world have "Sense All" added as a default detection mode.

Version was 3.1.23
I did not have all other modules enabled... but I only enabled the one's specifically mentioned as required in the Muncher screen... as follows:

Active Modules
Active-Auras
Active Token Effects
Advanced Macros
D&D Beyond Importer
DFreds Convenient Effects
Dynamic effects using Active Effects
Item Macro
libWrapper
socketlib
Midi QOL
Module Management+
Sequencer
Automated Animations
Times Up
Token Magic FX
Working on "Find the Culprit"...

I did have Sense All set up in my default token.  That's probably the cause of the problem.  I would think that setting up a "Sense All" ontop of another would just overwrite the setting...

I can confirm it was the default token settings....

I have added a check for the next release so it won't add multiple senses

Resolved in v3.1.24


Instant crash with no indication of what to do about it

Self-service

[ ] I'd be willing to implement a fix

Describe the bug
 ERR amplify/backend/function/redacted/src/common/redacted.js Transformation error (Cannot read properties of undefined (reading 'type'))
TypeError: Cannot read properties of undefined (reading 'type')
    at getDynamoDBForDocClient (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/dist/transforms/v2-to-v3/client-instances/getDynamoDBForDocClient.js:33:25)
    at getDynamoDBDocClientArgs (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/dist/transforms/v2-to-v3/client-instances/getDynamoDBDocClientArgs.js:34:63)
    at NodePath.<anonymous> (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/dist/transforms/v2-to-v3/client-instances/replaceDocClientCreation.js:13:213)
    at NodePath.<anonymous> (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/node_modules/jscodeshift/dist/collections/Node.js:142:47)
    at /opt/homebrew/lib/node_modules/aws-sdk-js-codemod/node_modules/jscodeshift/dist/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/node_modules/jscodeshift/dist/Collection.js:74:18)
    at Collection.replaceWith (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/node_modules/jscodeshift/dist/collections/Node.js:140:17)
    at Collection.typedMethod [as replaceWith] (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/node_modules/jscodeshift/dist/Collection.js:413:43)
    at replaceDocClientCreation (/opt/homebrew/lib/node_modules/aws-sdk-js-codemod/dist/transforms/v2-to-v3/client-instances/replaceDocClientCreation.js:13:14)
All done.

Steps to reproduce
Client is being constructed as follows:
const AWS = require("aws-sdk");
const dynamoDB = new AWS.DynamoDB.DocumentClient();
Observed behavior
See above.
Expected behavior
I don't know since I've never seen this tool actually run successfully.
Environment
aws-sdk-js-codemod: 0.17.2
- jscodeshift: 0.15.0
- recast: 0.23.3

Additional context
No response

Seems to be a bug introduced in https://github.com/awslabs/aws-sdk-js-codemod/pull/536, which was released in https://github.com/awslabs/aws-sdk-js-codemod/releases/tag/v0.17.1
You can workaround by running v0.17.0 of codemod as follows while we prioritize a fix
$ cat test.js
const AWS = require("aws-sdk");
const dynamoDB = new AWS.DynamoDB.DocumentClient();

$ npx<EMAIL_ADDRESS>-t v2-to-v3 test.js
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
Processing 1 files...
Spawning 1 workers...
Sending 1 files to free worker...
All done.
Results:
0 errors
0 unmodified
0 skipped
1 ok
Time elapsed: 0.228seconds

$ cat test.js
const {
        DynamoDBDocument
      } = require("@aws-sdk/lib-dynamodb"),
      {
        DynamoDB
      } = require("@aws-sdk/client-dynamodb");
const dynamoDB = DynamoDBDocument.from(new DynamoDB());

Fix released in https://github.com/awslabs/aws-sdk-js-codemod/releases/tag/v0.17.3


nitwebcrawl: add a simple crawler for nitweb

I do not remember why I developed this, but it works so why not publish it.
This can be a base to bench IO-bound parallel problem, or something to test nitweb.
For information, if I crawl a nitweb server on lib/core. I get 5209 entities in 1m51s real time (0m50s user time)

oh yeah +1 need to test this with actors

+1


DI: Fix 'self.init' delegation to an imported factory initializer inherited from a base class [4.0]

Description: A user in the labs reported an issue when calling an NSButton initializer inherited by an NSButton subclass. The initializer is a static factory method in Objective-C and we weren't handling the superclass delegation correctly in DI, causing us to reject the self.init call as an escaping use of 'self'. However the constructor method in question is declared as returning instancetype, and a test shows that it is indeed covariant, so we should allow this call.

Scope of the issue: Affects anyone trying to subclass SDK classes that may define these constructors.

Origination: It looks like it was broken in 3.1 as well.

Risk: Low, makes DI recognize a new code pattern, treating a value_metatype_inst of an upcast_inst the same as a value_metatype_inst of self itself.

Tested: New test added.

Reviewed by: @DougGregor

Radar: Fixes rdar://problem/32697794.

@swift-ci Please test


Compare size of PLC and PIR ASTs to estimate savings from explicit datatypes/recursion

We could add datatypes/contstructors/recursion into PLC. This would save space, since we wouldn't have all the encoding artifacts.
We could get an estimate of the improvement by comparing the PIR sizes, since that has those features.

Doing this might also facilitate analysis of PLC code.  Usually the first thing you do if you want to do some static analysis is to construct a control flow graph, but that's not so easy when you don't have explicit branches or loops.
Presumably there was some rationale for not doing this when PLC was first designed, so we might end up rehashing old arguments that were never documented.


Scrapper doesn't close browser

Scrapper doesn't close browser on exception or successful scrapping. If there are 100 profiles to scrap, it initiates 100 browser instances which creates memory issues.

on ubuntu or centos ？did you  manage to scrape at least one profile yet?

that's true @ghulammurtaza , I just fixed that.
You can do a git pull from master, or update manually the fix with those changes: https://github.com/linkedtales/scrapedin-linkedin-crawler/pull/32/files
Please use isHeadless: false on config file, when it's true it can misbehave

closed due to lack of feedback


Update law

Check this repository to see if it is still up to date

Form is not available on Court Forms Online.

The name/location seems to be weird, but here's a link to the form: https://apps.suffolklitlab.org/start/vacatehome/


Reviewed Creating Useful Views for Lists & Libraries + updated CHANGELOG

Category

[x] Content fix
[ ] New article

Reviewed Creating Useful Views for Lists & Libraries + updated CHANGELOG - also see PR #914

In review.
The PR Review team is reviewing your PR. As part of this process, we might make minor changes.
Don't make any commits during this review. When we finish, we’ll tag the PR creator in a comment if we find issues we can't address.
#label:"review-in-progress"
#assign: @Stacyrch140


Cmkedit

cmkedit

Learn Build status updates of commit 4c5215e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/103346/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Support for tslint4 & tslint5

@Istar-Eldritch could you update dependencies for tslint inside package.json to support 5 and 4 both.
Thanks!

Do we know if using the version 5 would imply some breaking changes?

I have changed a little code to support tslint 4 & 5 both and it works with tslint 5.
When you install tslint-language-service and tslint5 is already installed, there is a warn with peer dependencies. It should be cool to update package.json


introduce chapters field(2)

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] I am the original author of this code and I am willing to release it under Unlicense
[x] New feature

continuation of #9409, it should work now in both unix and windows systems.

anything else?

BTW, thanks for help by testing and reviewing.

Can this affect video quality? I mean, it shouldn't, but you never know..


[Feature] ORM Integration

There are several ORMs that I know of, including:
SQL:

SQLModel
Tortoise
Pony
Peewee

NoSQL:

MongoEngine
Beanie
ODMantic

Honestly, I'm more interested in SQLModel.

Trying to add integration:

MongoEngine
Beanie


[KYUUBI #483] Add configEntry for zookeeper node timeout

Why are the changes needed?
Add configEntry for zookeeper node timeout instead of using constant value
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @yaooqinn


Forward key events for TextArea

I am missing keydown in particular. But keyup and keypress should probably be forwarded for consistency as well.
Other input fields appear to forward keydown but not the other two, is there a good reason not to forward those?

I agree – the TextArea is missing a forwarded keydown event.
keypress is deprecated

Fixed in v0.36.0


Add Arif Iqbal to contributors list

Please accept my pull request

@arifktk32, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Determine the content types and intended audience

Determine:

[x] What general themes will be covered in content
[x] What types of content will be published
[x] What pages are required
[ ] What are the requirements of the CMS

See docs/content-planning.txt for info on the content.


Improve updating props and reliability

Previously updating the “map” property was not supported, this PR fixes this issue.
In addition, React 16 deprecates componentWillMount, this updates the code to use componentDidUpdate, which suppresses the warning on the console.

why this isn't merged any problems ?


Mistral

Are the any plans for adding support for Mistral-training? What would be required for this?

I have forked the repository and added support for Mistral implementation in my forked branch. Most of the code in Llama implementation are reused since they have nearly the same architecture. The training code for Mistral will be made available soon. I hope this helps, and any discussion is welcome.

Hi @simonucl. Thanks for letting me know. Looked through your code, and it seems great.
Could you contact me regarding the status of the training script? Maybe we can to something together here.

Sent an email to you!

Any news on this?

@simonucl, @peregilk any luck with the training script?


In Planner, moving a workitem to Backlog replaces the workitem's assignee icon

To recreate:

In Planner backlog view, select a workitem's kebab, and select 'Move to Backlog'
Observe the workitem's assignee icon replaced with this icon:

This error is written to the console log in Chrome:
Mixed Content: The page at 'https://prod-preview.openshift.io/ldimaggi%2540redhat.com/spaceforalexey/plan/detail/245' was loaded over HTTPS, but requested an insecure image 'unsafe:null&s=23'. This content should also be served over HTTPS.
unsafe:null&s=23:1 GET unsafe:null&s=23 net::ERR_UNKNOWN_URL_SCHEME

Before:

After:

@ldimaggi - can you log any planner UI issues to the planner repo instead of UI repo moving forward?    https://github.com/fabric8io/fabric8-planner

Moved to - https://github.com/fabric8io/fabric8-planner/issues/1835


[gitlab] Send package metrics to org2

What does this PR do?

Follow-up of #24137: send package metrics to org2 instead of dddev.
Motivation

Most CI metrics we have are in org2, so it makes more sense to also have the package size metrics there.
Additional Notes

n/a
Possible Drawbacks / Trade-offs

n/a
Describe how to test/QA your changes

Check the presence of the metrics in org2 after the pipeline run: dashboard.

/merge


Fix issues in nuclei classification xml

Add dask scheduler_address parameter
Resolve typo in predict_nuclei_class_prob
Specify extension for model file

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #341   +/-   ##
======================================
  Coverage    49.4%   49.4%
======================================
  Files          99      99
  Lines        2751    2751
  Branches       99      99
======================================
  Hits         1359    1359
  Misses       1392    1392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fb73d...f87f6bc. Read the comment docs.


Add monthly pipeline schedule to coincide with pylance releases

Modify the PTVS yaml to perform a scheduled run every month, sometime after the pylance stable release, so it gets bundled up properly and in a timely manner.

[ ] update pipeline
[ ] update docs
[ ] hotfixs

Maybe consider keeping the same schedule, but adding logics to check if msft_consumption has a newer version of pylance available.

I've modified the pylance release yaml to include a step to launch the ptvs azdo pipeline after the release occurs. See https://github.com/microsoft/pyrx/pull/4339


RTC Automation with new interface

https://github.com/openbmc/openbmc/issues/668 - To implement real time close interfaces in new format.
Place holder in case if we get any change from 668.
@rahulmah could you pls take a look at it.

Development base code change available at https://gerrit.openbmc-project.xyz/#/c/1942/

Please check time loss perspective as well.


Update DenIVs.cs

Fix the problem.

Please put all changes in one PR. The problem with this specific change here is that you ignore the form of the pkmn and hence the ability might be loaded false. But thanks for the input, besides that everything worked fine!


Test in IE11+

@srallen Hate to dump this on you, but could you do the gamut of IE testing on the new Old Weather?
I only have a little bit of info on what to target, but here's a bit that Kevin Wood ran into:

I was able to annotate (mark) in IE but would not load the transcribe function, and then lost the path and previous work.

Will add other specific problems as soon as I learn about them.

@rogerhutchings, I'm not getting an console errors with the above reported bug in either IE or Edge. What's happening is that the annotation interface isn't getting its state updated to being loaded after the subject image source is loaded. What I'm seeing in F12 dev tools in Edge:

I'll keep working on this, but wanted to give you a heads up in case you know what to change and it's an easy fix in Angular. Maybe a polyfill is needed?

Just as a follow up, it looks like something is going on with ng-load calling the onload event on the svg image in IE/Edge.

I found this one as well. I found that in practice, calling the scope's subjectLoaded method in the promise chain just worked :/
I also found that there's an issue with drawing on the SVG - changing up the annotations directive to include replace: true fixed it.
I'm getting a whole IE + Angular + SVG doesn't mix vibe from this...

Hmm... I don't know too much about angular, but I've been playing around with using ng-init and also came across this discussion in the angular repo, but I dunno if it's helpful here yet: https://github.com/angular/angular.js/issues/12493
I agree. It generally seems unstable in IE/Edge.

Ah - I think I know why. ng-load is waiting for load, in IE it's called SVGload
https://msdn.microsoft.com/en-us/library/ff972236(v=vs.85).aspx

I've written up a separate issue for this now, so I'll close this one.


doc: fix miss install tools

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
see: https://github.com/risingwavelabs/risingwave/pull/19054
its confuse when building mbook report error like 'cannot find command binstall '. i think the RisingWave Developer guide  need to add install binstall command.
The command reference comes from here:  https://github.com/cargo-bins/cargo-binstall
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

cargo-binstall will be installed by risedev, so I don't think we need to mention it in developer guide
https://github.com/risingwavelabs/risingwave/blob/90d1fab06ddde07262ab883cf8eaf5f705446d5f/risedev#L3-L6
ok. now i know that i need to compile the project first before to do this


ZipLongest: moved differential behavior from remarks to summary

Currently, all zip methods have the same summary, what is a bad thing because user can get confused thinkg they all do the same thing.
The particular behavior of each opertator is being quoted on remarks sessions, but if the particular behaviors are important enough for morelinq have 3 different kinds of zip, then it should be discern on the summary session.

@atifaziz adjusts done!

This was merged via PR #595. Thanks!


Clear Crosswalk Cache when new profile picture?

Hi,
I have a problem om android, when the user is updating the profile picture, the image is cached and doesn't change, though it has been changed on the remote server.
Does anyone know if and how I can clear the cache and reload the picture? It doesn't even help to restart the app.

Hello! Thank you for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


Bug: World Editor snap to grid always snaps to object centroid

Always snapping to object centroid causes odd sized objects, e.g. 5 x 3, to not align to the grid properly. I.e. if the grid-snap is set to 1,  I expect the sides of a 5 x 3 shape to be aligned on the grid, but instead the shape is off the grid by 0.5 (5 / 2 = 2.5; 3 / 2 = 1.5).
I assumed that setting "Snap to Bounding Box" would fix the problem, but it appears to be ignored; it still snaps to the centroid whether that's set or not.
Fix: It needs to either snap to a corner of the object, or correctly use the "Snap to Bounding Box" setting.
(Note: This is with a basic imported Collada shape, no bounding box in the DAE; I assume T3D automagically creates a bounding box when importing.)

resolved via https://github.com/GarageGames/Torque3D/pull/1961 (flip use group center off)


fix: restrict block_number == current_block_number - 1 in BlockHashGadget (for scroll)

https://hackmd.io/@toghrulmaharram/ByO6HM6Oj

eh we plan to support both scroll l2 evm and original l1 evm in long term. So we need to add a feature flag call "scroll", when enabled, only restrict block_number == current_block_number - 1,  when disabled, original l1 evm logic

it is too complex...  what about this?

#[cfg(not(feature = "scroll"))]
const num_prev_block_allowed = 256;
#[cfg(feature = "scroll")]
const num_prev_block_allowed = 1;

let num_prev_block_allowed =
let diff_lt = LtGadget::construct(
            cb,
            current_block_number.expr(),
            num_prev_block_allowed.expr() + from_bytes::expr(&block_number.cells),
        );

it is too complex... what about this?

#[cfg(not(feature = "scroll"))]
const num_prev_block_allowed = 256;
#[cfg(feature = "scroll")]
const num_prev_block_allowed = 1;

let diff_lt = LtGadget::construct(
            cb,
            current_block_number.expr(),
            num_prev_block_allowed.expr() + from_bytes::expr(&block_number.cells),
        );

It seems that it doesn't satisfy current_block_number == block_number + 1 (this LTGadget constrains current_block_number < block_number + 1?).

#[cfg(feature = "scroll")]
const num_prev_block_allowed = 2

#[cfg(feature = "scroll")] const num_prev_block_allowed = 2

With block_lt == 1 and diff_lt == 1?

Updated according to @lispc 's method. Thanks.


Alpha on container affects children in unexpected way

When two sibling Graphics objects (or Sprites) are overlapping and their parent's (in this case a container) alpha is being manipulated, the results are not what I'm expecting. When setting the container alpha to 0.5, both the children will behave as if themselves had an alpha of 0.5 (even though they have an alpha of 1)
What's actually happening:

jsfiddle
What I was expecting:

Is this a bug or am I thinking wrong about the behavior? If so, how do I get the behavior I am looking for? I'm used to change opacity of groups/layers and I was hoping it would work the same in Pixi. I tried to search for it but no success.
Thanks in advance

Its not a bug. You need to do it in a separate layer, either using filter either renderTexture:
Filter
var voidFilter = new PIXI.filters.VoidFilter();
container.filters = [voidFilter];

but in current pixi version it doesnt work with alpha, so for now you need a filter that  treats alpha correctly:
var colorMatrix= new PIXI.filters.ColorMatrixFilter();
colorMatrix.alpha = 0.5;
container.filters = [colorMatrix];

@GoodBoyDigital @bigtimebuddy  we really need to add alpha or tint to VoidFilter!
RenderTexture
This one doesnt work in realtime :( Its just snapshotting the container and then applying alpha on that texture. Im posting clear solution, without "cacheAsBitmap" and "generateTexture", those things have not enough info to do the alpha fix.
var bounds = container.getBounds();
var x2 = Math.ceil(bounds.x + bounds.width);
var y2 = Math.ceil(bounds.y + bounds.height);
bounds.x = Math.floor(bounds.x);
bounds.y = Math.floor(bounds.y);

var trans = new PIXI.Matrix();
trans.tx = -bounds.x;
trans.ty = -bounds.y;

var renderTexture = PIXI.RenderTexture.create(bounds.width, bounds.height);
renderer.render(container, renderTexture, null, trans);

var sprite = new PIXI.Sprite(renderTexture);
sprite.position.x = bounds.x;
sprite.position.y = bounds.y;
sprite.alpha = 0.5;
stage.addChild(sprite);

@ivanpopelyshev Thanks  alot for your explanation and suggestions of approaches. I now have a better understanding of it.
I would be interested in running the approach with ColorMatrixFilter. However, I can't get it to work as it doesn't seem to have any effect at all. Could you please fork my provided fiddle with the solution?
Thanks in advance

Ugh, you are right!
Lets fix that.

`
varying vec2 vTextureCoord;

uniform sampler2D uSampler;
uniform float uAlpha;

var frag = `void main(void)
{
   gl_FragColor = texture2D(uSampler, vTextureCoord) * uAlpha;
}
`;

var vert = `
attribute vec2 aVertexPosition;
attribute vec2 aTextureCoord;

uniform mat3 projectionMatrix;

varying vec2 vTextureCoord;

void main(void)
{
    gl_Position = vec4((projectionMatrix * vec3(aVertexPosition, 1.0)).xy, 0.0, 1.0);
    vTextureCoord = aTextureCoord;
}
`;

function AlphaFilter() {
   PIXI.Filter.call(vert, frag);
   this.alpha = 1.0;
}

AlphaFilter.prototype = new PIXI.Filter();
AlphaFilter.prototype.constructr = AlphaFilter;

Object.defineProperties({
   alpha: {
       get: function() { return this.uniforms.uAlpha; }
       set: function(value) { this.uniforms.uAlpha = value; }
   }
});

I havent tested this yet, so you have to fix it if you see an error.

And, updated again.

It seems that I mixed ES5 and ES6 here.. please rewrite it that way it works for your case :)

Thank you so much for your time and effort and I'm glad to say it is working!
I now get the desired effect and you can spot it here: jsfiddle
I just had to fix some typos in your class example, so I'll post the working one here:
class AlphaFilter extends PIXI.Filter {
    constructor() { super(vert,frag); this.alpha = 1.0; }
    get alpha() { return this.uniforms.uAlpha; }
    set alpha(value) { this.uniforms.uAlpha = value; }
}

Perhaps this could be added in future releases?

I'll make PR to add alpha to the VoidFilter itself.

Can we rename VoidFilter to AlphaFilter? I think it should be named for the use-case.

I took that name from VirtualDub: filter that does nothing but allows to use all the features inside it. I agree, I'll rename it and put a deprecation notice.

Thanks 👍


How to add pagebreak

I try to add page break but not success. Can you help me ✌

Insert a page break in your template.
You can add a page break within a loop or a conditional block.
It might look a bit inelegant, but it works.
A syntax to insert a page break without relying on an actual page break in the template is planned for a future release.