Provide mechanism for streaming logs from modules

Proposal: Provide mechanism for streaming logs from modules
Author: Monty Taylor <@emonty> IRC: mordred
Date: 2018/01/04

Status: New
Proposal type: core design
Targeted Release: 2.6
Estimated time to implement: not too terribly long - agreeing on the design is the hard part

Motivation
Long running tasks can be a black hole of despair for a user, and waiting until one is complete to be able to see what happened can often be frustrating.
We have a hacked-in version of output streaming for command/shell modules in our ansible-playbook invocations in Zuul v3:
https://github.com/openstack-infra/zuul/blob/feature/zuulv3/zuul/ansible/library/command.py
https://github.com/openstack-infra/zuul/blob/feature/zuulv3/zuul/ansible/callback/zuul_stream.py#L118-L167
but it would be better if such a facility was available to all ansible users, and for a facility to exist for module authors to be able to do something similar.
Assuming we can agree on an overall approach, we can implement the majority of this as an update to the existing zuul streaming code and then forklift it over when it's working well. (most of the code is in standalone classes with minimal amounts of updates to the guts of existing Ansible objects)
Problems
What problems exist that this proposal will solve?

Output from long-running tasks is not available until the task is complete
Modules that use third-party libraries that have python stdlib logging based logging can't wire up those loggers in any way that causes output to return to ansible-playbook.
Some people hate python stdlib logging. Some people make extensive use of it. Both sets of people need to be happy.

Solution proposal
tl;dr - Emit structured log messages over a socket from AnsibleModule back to a port on the calling machine that is optionally forwarded to the remote machine over the Connection. When the messages are received on the calling machine, fire a Callback method to handle them.

Add main ansible.cfg option "realtime_streaming" that defaults to None
Add main ansible.cfg option "realtime_streaming_local_port" that defaults to None
Add main ansible.cfg option "realtime_streaming_remote_port" that defaults to None
Add main ansible.cfg option "realtime_streaming_host" that defaults to None

There is a 2x2 supportability matrix:

Port on calling machine is or is not reachable over the network from the remote machine
Connection plugin supports forwarding arbitrary ports (like ssh) or does not (like network_cli)

Detecting whether the local port is reachable from the remote machine without forwarding is not consistently and efficiently possible, so defaulting realtime_streaming to off is the safest thing. As a follow-on it could be possible to automatically enable streaming for Connection plugins that support it. Thus having the default for realtime_streaming be None rather than False so we can have None mean "on, defaulting to forwarding the port if the connection supports it, otherwise off"  and False being explicit disable and True being explicit enable.

Add flag to ConnectionBase "has_port_forwarding" defaulting to False
In ConnectionBase, something like the following:

  if C.REALTIME_STREAMING:
    # Get the LogStreamListener singleton instance
    listener = get_logstream_listener()
    listener.ensure_started()
    local_port = listener.get_local_port()
    if C.REALTIME_STREAMING_REMOTE_PORT:
      # We're going to do port forwarding
      self._forward_streaming_ports(local_port, C.REALTIME_STREAMING_REMOTE_PORT)
      self._play_context._log_streaming_port = C.REALTIME_STREAMING_REMOTE_PORT)
      self._play_context._log_streaming_host = 'localhost'
    else:
      # We're going to have the remote host connect directly
      self._play_context._log_streaming_port = local_port
      self._play_context._log_streaming_host = C.REALTIME_STREAMING_HOST or platform.node()

In the Task executor, pass _play_context._log_streaming_port and _play_context._log_streaming_host to the remote module invocation via _ansible private variables

In AnsibleModule, if _ansible_remote_stream_host and port are set, instantiate a StreamingLogHandler. If the are not set, instantiate a NullHandler.

In AnsibleModule, add methods to connect log stream to existing library logging

  def connect_logging_stream(self, name, level):
    """Configures a named python stdlib logger to emit messages across to the remote socket."""

  def connect_twiggy_stream(self, name, level, filters=None):
    """Configures a named twiggy logger to emit messages across to the remote socket."""

In AnsibleModule, add a ```stream_message`` method (or something with a better name) to allow for sending a single message back over the wire easily from module code.

in modules/command.py, watch stderr/stdout as it happens and call self.stream_message for each line. (Perhaps want to have C.REALTIME_STREAMING cause stdout and stderr to be combined - since it'll ultimately only be one stream - but leave the current split behavior for non-streaming cases so that people have the differentiation.)

Write StreamingLogHandler class either as a subclass of logging.handlers.SocketHandler or from scratch that sends each message and its data as JSON. subclassing would be easiest, but since we want to support richer structured data from twiggy as well, we need to assess whether the existing SockerHandler is robust enough and gets all of the data to the other side.

Add a Callback method that can be called for each log message received

Write LogStreamListener class to listen on the port for log messages, unpack them and call the Callback method with the expanded data.

 There will definitely need to be testing.

There is a relation with multiple stream support for Windows as Powershell has 5 output streams and preferably we may want to capture some of those streams on the master as well. (I couldn't find a reference to prior discussions about this)

@emonty The links in the description are 404 now. Are these the correct current urls?
https://github.com/openstack-infra/zuul/blob/master/zuul/ansible/library/command.py
https://github.com/openstack-infra/zuul/blob/master/zuul/ansible/callback/zuul_stream.py

I refreshed my https://github.com/bcoca/ansible/tree/update_json branch, almost there, got basics working, just need to hook into callbacks and make sure its always unbuffered.

@bcoca Is this going into Ansible 2.8?
I see you made updates into https://github.com/bcoca/ansible/tree/update_json during September.

idk yet, i have other priorities right now, its was 'done' at the beginning of 2.7 but i hit a huge performance hit when forcing all python to be unbuffered, there have been other users that have sent patches to it, but i have had other priorities and no time to check/confirm that fixes the issue.

Is this likely to make it into 2.8? This would be awesome for checking make and other long running operations.

Hey guys,
Any news on that?
what's the best workaround solution?

In the meantime, for anyone wanting a solution for this, I achieved a result that was satisfactory for me and created a repository with a minimal demonstration of what it does and the steps to reproduce it:
https://github.com/lucasbasquerotto/ansible-live-output-demo
Screenshot

This obviously didn't make 2.8, but I can't see it on the roadmap for 2.9 either (https://github.com/ansible/ansible/projects/34). @lucasbasquerotto made something that works in the meantime, but if the real fix is just a couple of months away, I'll just going to wait instead :)

I'm quite interested to see this, as well, as I run a lot of long-running tasks, and I get complaints that my playbooks are hanging.

Same, also I'd like this (for the same reasons + debugging long running commands).

I fully second this too, I have been using Ansible to migrate existing shell-based infrastructure scripts and the first step is to run them via command/shell. This takes forever and is pretty frustrating when it fails after a long time (not speaking about the ton of output I have to go through after that, esp if the script does not do a stellar job at error checking). Having the ability to stream stdout/stderr would greatly help with that.
This can also be an asset when introducing Ansible to shell-based workflows and how easy it is to run the existing scripts with Ansible. Without streaming output, this is a far less appealing proposal...

I have created a solution to start a simple socket server on controller node to receive realtime logs from managed node. It's not considering security issue and performance. I have used it for trigger and monitor long running scripts and it's working fine for the purpose.
https://github.com/allx/remote_logging

+1

+1 I'm using ansible to manage the backup of a database and a file system and ansible hides the progress that is logged to stdout.

It's necessary.  my custom module reports realtime status, but i can't see info at ansible stdout

+10

Hi all!
May be you will satisfied with daggy.
The main goal of daggy is data aggregation and streaming, as you want in this issue )

+1

++1
this is desperately needed.  I have a shell command that calls a shell script with some arguments. from the server command line, works fine, from ansible hangs forever.  I have no idea how to debug this and close to just giving up on it...

+1

+1

+1 this is very much needed, for long running operations we are flying blind with no output.

If ansible got this functionality, it could replace many existing tools and script you normally would need. This is one of the very few things I really, really want to see in ansible

It would be awesome to have this feature in Ansible, we have a lot of use cases for such feature in our company as we are mainly working with Windows OS's and having live output is sometimes critical for us to have. +1 from me 👍

I think it would be easier if not everybody adds a small +1 comment here, but instead would add a +1 (thumbs up) to this issue. That would decrease the flood of annoying messages which provide absolutely no new information, and only make me want to unsubscribe this proposal. (But then I'd also miss when some actual work is done on this issue - which I don't want to miss.)

I am fairly certain this streaming used to work in an earlier version of Ansible, I remember using it a couple years ago and then it stopped working after an Ansible upgrade and we could never get it working again (inside Jenkins).

2020 and still not implement?
It's time to look for other solutions.

I am fairly certain this streaming used to work in an earlier version of Ansible, I remember using it a couple years ago and then it stopped working after an Ansible upgrade and we could never get it working again (inside Jenkins).

To update this comment, I reached out to my old colleague and he updated my memory and it did not work before and was a different issue I was thinking about.

+1

Any updates in 2021?

Any updates in 2021?

Here's the MVP: my code just catches everything that's seen by Ansible on remote host, and sends it back via ssh reverse tunnel. Then simple nc can be used to catch all that stuff. Here's the screencast.
Items to add:

ssh arguments are hardcoded - I've chosen two custom ports that's free on my test box, and this may differ for any given couple of boxen
no incoming data processing support at the controller
no marks/delimitations yet that should split one command output from another
target box does not process the situation when nothing listnes to the  (error 32 - Broken pipe)

At the moment being this is just a private initiative implemented in half a night. However, any donates are happily welcome, and these will for sure motivate me to work this code out. For details please contact me on Telegram, profile can be seen in screencast.
Some in-depth details are in my article at Habr.com.

A very hacky workaround for those using shell plays:
- name: Do a thing
   shell: "{ my_command; } &>1 | tee -a /tmp/run.log"
 - name: delete run.log
   file:
     path: /tmp/run.log
     state: absent

Ansible will block on Do a thing. In another window; SSH into the machines in your inventory and tail -f /tmp/run.log.

Yeah that's doable with ssh. But the whole (or most of the) point to use ansible in the first place is to, well, avoid manually ssh into each machine. What if those actions run in a batch for multiple machines? Ssh-ing into all those machines is too much of a burden.

Hi,
This proposal is open for four years with issues from 2014 (at least) points to it. Is there any progress about it? Is just waiting for a programmer or need something else?
Thanks

See my PR/branch linked above, I hit a problem with python buffering and have not had time to revisit it.

I...guess I don't understand.  And this may be a massive oversimplification but...
When I "async"/poll 0 a command that prints output, there appears to already be a STDOUT captured with that command (I assume STDERR also).  When I then use "async_status" the output from the async'd job prints upon job completion.  That seems to me that there's a stdout/stderr for each of these executions and it's at some point accessible to whatever is running async/poll > 0 or async/poll = 0/async_status.
In a real language, each "poll" iteration you'd simply flush stdout and debug/print the resulting buffer for status.  The problem with ansible is that currently a command run async/poll > 0 or async_status sets up a loop that we can't interact with.  While "async/poll > 0" might be an issue to deal with since it's not really it's own module, I don't see why "async_status" couldn't be setup with a "show_stdout: yes" and "show_stderr: yes" argument that simply turns on a debug or flush/debug of the buffers each time the loop iterates the check.
I get the concept of the buffering problem, but ANY output, right now, would be better than what we have (which is absolutely nothing till a process completes).  Even if the buffer display is behind the actual output it's still better than having absolutely nothing till the end.    Users can control their own behavior by forcing their own commands (such as those run shell or command) to flush buffers periodically so that up to date status is acquired by Ansible.

@rgadwagner stdout/stderr in the case of async is just a proxy for the normal module response, it is not 'stdout/stderr' from commands run by the module (if any, many modules do not run system commands) . Async in that case just proxies the 'final result' while having an intermediate poll asking 'are you done yet?' which is not even a 'progress' but a binary state (finshed/not finished).
This could be part of a system to report 'current feedback' but modules would still need to be modified to actually provide that feedback.

@bcoca what's the performance issue with the unbuffered python ? I was wondering if we couldn't keep it buffered but flush the buffer at regular interval instead if somehow that would help with performance (?). I believe that would be an acceptable tradeoff (get an update each N millisecond or seconds is much better than at the command completion)

basically the issue was that starting python in an unbuffered state made everything take a lot longer, fact gathering was really painfully slow.
Yes setting up a flush timer would be a workaround, but it needs to affect everything, other options I was exploring was limiting teh 'unbuffered' state to stdout instead of all python file handles.

need it in 2023

i use screen -d -m for a detached screen, then i run the script, Ansible returns it is done, although it is still running, if i want to trace the progress, i will login to the server and attach to the screen and see the output, or tail -f the output log file. Here is my tasks.
`    - name: Do a thing
command: screen -d -m -S myoutput &
- name: Run command
  command: ./install.sh &>1 | tee -a /var/log/install_fusion_pbx.log
  args:
    chdir: /usr/src/fusionpbx-install.sh/debian`

Tip: if you've forgotten to run something in tmux or screen, it's not too late. Check out: https://github.com/nelhage/reptyr

Just wanted to chime in with a use case for this:
I have a fido2 device that I want to automate doing cryptenroll. However, it asks for user presence at some specific moments otherwise the command times out. Streaming these logs would be great for this automation.
+1

This feature can greatly improve developer experience when ansible used as universal build tool (like make).

I'm quite interested to see this, as well, as I run a lot of long-running tasks, and I get complaints that my playbooks are hanging.

agree

+1

Any updates on this?

+1

+1

+1

Please stop adding "+1" posts. This only annoys everyone subscribed to this issue, and won't do any good. Thanks.

Please stop adding "+1" posts. This only annoys everyone subscribed to this issue, and won't do any good. Thanks.

Nope, not every one, it does not annoy me, helps keep on the radar. Often issues are close because of "luck of interest", those +1 demostrate unceasing interest, so IMO it does lots of good: preventing the issue from closer, and preventing claims that this is something no one is interested in.
Keep them coming if this feature is something you are interested in. Do not spam, do not post them more than once.

I no longer use Ansible. Rather, I use pyinfra which has this feature built-in and has nicer syntax. No need to mess with YAML DSL anymore

Rather, I use pyinfra

@JakkuSakura thanks for sharing!! 🙂 Looks very promising, I will give it a try for sure

Any updates here? Still open in Aug. 2024.


gh repo clone open-telemetry/opentelemetry-dotnet-instrumentation

Desired feature or idea: What would you like to see happen?
Additional context: anything else you can think about that would be helpful.
Please delete paragraphs that you did not use before submitting.

@Mitrok-Bit can you provide some more details what you are trying to accomplish or where you might need help?


What polishing is necessary for release of 0.10.3?

0.10.3 is planned but delayed due to lack of time. sorry for the inconvenience and please consider assisting in polishing branch ref-0.10.3.

@ronmamo Since you didn't reply in the (already closed) issue:
What kind of polishing is needed?
The bugs (#395, #440 , #427) are really problematic - so maybe the community can step in and help releasing...

the classloader param #445  would be good and should be easy to fix

I yesterday forked the project and tried the suggested bugfix for issues (#395, #440, #427) However it did not help the error still occurs. Thus I completely removed the reflection lib and replaced the functionality with something else...


'com.google.samples.apps.sunflower.databinding' package is still missing

Same comment : https://github.com/googlesamples/android-sunflower/issues/243
Where can I get this missing package ?
Thanks 🙏

See the documentation on Data Binding to make sure your development environment is properly set up.
Closing as this is likely a configuration issue rather than with the Sunflower code itself.


gpioutil.Debounce not actually implemented

Apologies if I'm misreading. I have implemented manual debouncing and denoising for my own project, before realizing that gpioutil.Debounce exists. It would provide a cleaner API to do the same thing, so I looked into switching to using it. However, observing the current version of debounce.go, it appears that:

[ ] #9

No waiting nor time comparison occurs; the only use of the time package is for referencing the time.Duration type
The denoise and debounce properties are only ever compared to 0 or copied around
The file appears mostly unchanged since https://github.com/google/periph/commit/97f750ed7ab8172a140a35ce8dde418ce51555d2, which has the commit message explicitly saying "No algorithm yet."; it is nonetheless no longer in an experimental path, so:
[x] #8

[ ] #7

It's replaced with gpio.BothEdges

[ ] #6

It's unclear whether it should be running In on its own anyway.

(I've tried to keep the checkbox entries in actual tasks, so they can be used with Task lists).
Am I missing something? I think, at least, that the documentation should clarify the state of this code.
Side-note: While I was aware of the importance of debouncing, denoising was newer to me, and I found out about it the annoying way (I have phantom GPIO "button presses" about every 8 hours; super annoying to debug). Once Debounce is implemented correctly, it's probably worth mentioning in the documentation of WaitForEdge.

There's historical reasons for this. 2 years ago I started looking at options to recreate the conn package as I don't feel the current interfaces are optimal. Then go modules were forced and I spent all my free time on splitting the repositories into real go packages.
You can find a bit more at:

https://docs.google.com/document/d/1ltZHq1Az6kLH3vrPS3XFAxT2XOOStKgHqwtnT5o9j6k/edit
https://docs.google.com/document/d/1vQdZdoOMaIan7dKwcAzqHbfM_LCnnSMUQvqypRkjohM/edit
https://docs.google.com/spreadsheets/d/1BG4QDS6cWM0eIdYInjfoNccHI63w5BXAdwSeCYNbPu4/edit#gid=0

Because of the uncertainty with how the GPIO functions would look like, I didn't spend time to fix the Debounce code when I carried it over from experimental at https://github.com/google/periph/tree/main/experimental/conn/gpio/gpioutil when I removed experimental when I created the new repositories. There's more at https://periph.io/news/2020/a_new_start/.
So that was a lot of words and links to say that help would be very appreciated.

OK, at the very least I'll do the doc warning.

Could you please hit the "Convert to issue" button on those tasks? (That should make it link up nicely and I can reference that in the pull request)

#TIL

After #10:
So, to clarify, should the conn package be considered stable enough for it to be worth actually implementing this now (I mean, it's been 3 years)? Or is v4 right around the corner (...and then v4 needs an implementation of this)?

I started multiple changes for v4 but given my current work workload it's unlikely for me to have a v4 in the next year.

Understood. So after the docfix is in, I'll see if I can take a whack at implementing the logic for v3.

Looking at the current documentation, the Read method is also documented as being affected by debouncing: https://github.com/periph/conn/blob/9ee6d812a51e97b7bdbf8215670286b0f22d5f04/gpio/gpioutil/debounce.go#L59-L62
This is significantly more complicated to implement than the WaitForEdge variant, which would boil down to something like this:
func (d *debounced) WaitForEdge(timeout time.Duration) bool {
  prev := d.PinIO.Read()
  for {
    if !d.PinIO.WaitForEdge(timeout) {
      return false
    }
    time.Sleep(d.denoise)
    if d.PinIO.Read() != prev {
      return true
    }
  }
}

Looking around, there's a C library called pigpio which has a set_glitch_filter that seems to have similar functionality, and indeed only applies to their equivalent for WaitForEdge (although the implementation seems more complicated).
Getting this to work for Read as well is... tricky? I mean, I guess it could do this:
func (d *debounced) Read() gpio.Level {
  for {
    prev := d.PinIO.Read()
    time.Sleep(d.denoise)
    if d.PinIO.Read() == prev {
      return prev
    }
  }
}

Is that what you had in mind?

My thinking was to save one read if the last read occurred within d.denoise, but in hindsight I'm not sure it was a good idea.

I'm not sure how that would work... and I don't think it can work in the case of "user calls Read just once". Am I missing something?

hence my "I'm not sure it was a good idea" :)

Fair enough 😅
What do you think of my proposal?

lgtm

Alright, started on this in #12, LMK what you think.


Q: Allow to use createStaticHistory for ConnectedStaticRouter

Version: 4.1.1
The problem
I'm using ConnectedRouter on client and want to have isomorphic access to location and control over it.
The StaticRouter is really great!
And he keeps isomorphic code working over environments!

<StaticRouter keeps history freezed and unchanged  (this is very important for server-side rendering)
Keeps components like <Redirect working
Indicates possible requirement of redirects via context.url
(because server render tried to change static history, but we can change it only while handling new request)

Going deeper in application data-flow, depending on location
If we need to work with location from redux-store (e.g. is redux-saga) on server - there is no location in store
Also if we dispatch and push or redirect action - they will not be handled, because StaticRouter history cannot be provided into routerMiddleware
Philosophy of code architecture
I reviewed comment from @timdorr in #5475.
As i understand, he recommends to write our own actions to handle push/replace on server
But I do not agree with this comment.
We already have history and routing via Router and ConnectedRouter
So why we need to write different code for client-side and for server-side, if this code do the same things?
The only difference between client and server code is how it will be handled on top level of application in different environments
(e.g. window.history.replaceState vs response.redirect)
Proposition to improve server-side rendering support
I think this problems can be solved by writing modified ConnectedStaticRouter
This is how it may looks on server:
// staticHistory currently implemented inside `StaticRouter` and must be extracted
// https://git.io/vb97k
import createHistory from 'history/createStaticHistory'

// Some express.js middleware
function renderReactPage(req, res) {
  const routerContext = {}
  // static router context need to be provided into staticHistory (but now is hardcored inside StaticRouter)
  const history = createHistory(routerContext)

  // `react-router-redux` reducer and middleware declaration still same as currently implemented
  const middleware = routerMiddleware(history)
  const store = createStore(
    combineReducers({ router: routerReducer }),
    applyMiddleware(middleware)
  )

  const html = renderToString(
    <Provider store={store}>
      <ConnectedStaticRouter location={url} context={routerContext} staticHistory={history}>
        <App />
      </ConnectedStaticRouter>
    </Provider>
  )

  if (routerContext.url) return res.redirect(301, routerContext.url)
  res.send(html)
}

Even if routerContext is useless for ConnectedStaticRouter:

we still need staticHistory functionality because it guarantees that the match of some <Route can't  change its match to another <Route during server render
location in store must stay unchanged by actions.

Relates to #5475 #5333 #4892
P.S.

I'll be happy to make PR, if we find compromise way to improve router<->redux connection for SSR

If we need to work with location from redux-store (e.g. is redux-saga) on server - there is no location in store

Yes, there is. Traditionally, this is available at req.url in Express and similar servers. You would initialize your history with this location already provided. You can also dispatch this into the store so the two are in sync.
You should be using <StaticRouter> for this. A syncing router is not needed, as you can't re-render on the server side so there is no ability to react to a change in the location, other than handling that outside of the React renderToString context.

@timdorr Yep, its not so hard to dispatch LOCATION_CHANGE action to sync history state, but

we don't have access to static history that hard-coded in StaticRouterand we're forced to create second instance of history #4892

Also you probably forgot about <Redirect and dispatch(replace(…)) problem

StaticRouter does not support dispatch(replace(…))
ConnectedRouter on server-side-render does not support <Redirect and replace(…) and static history

This is the reason to improve SSR


Add release flow in README

Since some df-py scheduled actions are using the latest release  (see https://github.com/oceanprotocol/df-py/blob/main/.github/workflows/dispense_passive.yml#L23-L36), we need to document how a new release is done

Closed by #739


Nodes with different supported features can lead to invalid cluster states

Consider the following senario

A node with the batch metrics feature joins a cluster without the batch metrics feature.
Metrics and batch metrics is enabled across the cluster via the new node, resulting in a cluster state of 9.
Metrics is disabled via a node without the batch metrics feature, resulting in a cluster state of 8.

The above scenario is a bug -- the cluster state should be 0. But, the node is not aware of the batch metrics feature so it does not touch that part of the cluster state.

This issue can be remedied by disabling metrics or batch metrics via any node that supports the batch metrics feature.


Merge 2019.11.29-zane-rough_in_submission_checklist to master

Summary
rough in submission checklist
Submission Certifications
Has inline documentation been included with all newly added or significantly modified functions and/or tests?
Answer: confirmed
Have all new or modified functions dealing with access to sensitive material (user keys, passwords, etc.) been flagged as 'SENSITIVE' in the inline docs and inline at the head of the function or near the sensitive section of code?
Answer: confirmed
Issues

involved with https://github.com/Liquid-Labs/liq-cli/issues/109

OK, one more request improvement.


Java: Incorrect value is set by JAVA_HOME env

$ printenv JAVA_HOME
/usr/local/sdkman/candidates/java/current

This is still incorrect...

$ ls -l /usr/local/sdkman/candidates/java/
ls: cannot access '/usr/local/sdkman/candidates/java/': No such file or directory

$ which java
/usr/lib/jvm/msopenjdk-current/bin/java

Originally posted by @oalper in https://github.com/devcontainers/images/issues/339#issuecomment-1398740329

Opened https://github.com/devcontainers/cli/issues/381

$ printenv JAVA_HOME
/usr/local/sdkman/candidates/java/current

This is still incorrect...

$ ls -l /usr/local/sdkman/candidates/java/
ls: cannot access '/usr/local/sdkman/candidates/java/': No such file or directory

$ which java
/usr/lib/jvm/msopenjdk-current/bin/java

Originally posted by @oalper in #339 (comment)

$ printenv JAVA_HOME
/usr/local/sdkman/candidates/java/current

This is still incorrect...

$ ls -l /usr/local/sdkman/candidates/java/
ls: cannot access '/usr/local/sdkman/candidates/java/': No such file or directory

$ which java
/usr/lib/jvm/msopenjdk-current/bin/java

Originally posted by @oalper in https://github.com/devcontainers/images/issues/339#issuecomment-1398740329

dev tags are updated with the fix, waiting for a prod release.

Closing as fixed with the latest prod release 🚀


Add contributor @ebello

- Summary
Adding myself as contributor for #808.

- Test plan
n/a

- Description for the changelog
Adding @ebello as a contributor.

- A picture of a cute animal (not mandatory but encouraged)

@ebello Can you rebase this on master with just the one commit, please?

@tech4him1 I think I got it. Sorry for the trouble.

No big deal, thanks for the bug fix.


GitHub 2249 fix dynamic helper for classes with no methods

Fixes #2249
Did you remember to?

[x] Add test case(s)
[x] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@krmahadevan I'm sorry, i'm new to pr process on github, is there anything else i should do?

@sergejjkim - Can you please help respond to this question https://github.com/cbeust/testng/pull/2250#discussion_r383071320

@krmahadevan i thought i did, at least i see my answer below you question.. quoting it here
"they are going to be executed, however they just get dependent on a1 and a2 and would be executed (available by get free nodes) after a1 and a2 are executed. this is same behavior as if there was no PackageTestClassBAbstract at all."

@sergejjkim - Thanks for this PR. This now stands merged. Look forward to seeing more contributions from you :)

@juherr @krmahadevan thanks a lot for the review!


Pkg rename

Closing since we're now using https://github.com/OpenLiberty/application-stack-starters as our working repo for starters.


net/wireguard: replaced Tunnel Address with Allowed IPs for Endpoints

Replaced all tunnel address reference on Endpoints configuration page with Allowed IPs as per wireguard official documentation

So, can we agree you only change the Label Name and Helptext? My Initial request was that I do the code and you the update on docs, but I'm very happy see another person contributing also to plugins :)

Yes that would be great.
Yes you have requested to do the code but because, like I've said before, the code was well made and really easy to understand i just could do it easily. If i can do it, why not helping others especially when you guys did created such an astonishing OS.
About the docs i will try to edit them tomorrow.

Merged, thanks!


GDPR - User Profile delete / export

GDPR requires the possibility to:

delete your own profile

export your own data

How about adding buttons that:

For deletion
a) Triggers a workflow that, if approved by an administrator, deletes the user profile which has been requested to be deleted?

b) Triggers a deletion process right after the next logout?

For export
Triggers a CSV export OR shows all the user-related attribute data in a boy for easy copy&paste?

For people interested in exporting user data and the right to data portability, this feature is included in the GDPR package: https://www.concrete5.org/marketplace/addons/gdpr/data-transfer/

For deletion, a more secure process would be to send an email with a delete confirm message and link back. (b) is a little bit too instant.

We handle these types of requests manually on concrete5.org with a process very similar to what @JohntheFish is suggesting, using a simple contact form. Does it need to be more complicated/automated than that?

In theory, there is no "must have" for a user deletion process, if there is a explanation on how to get your profile deleted (send an email to delete-me@domain.tld)... But this relies on the site owner to actually define the way how to do it.
My thought is to have an easy, built-in process that is available from the beginning. But it could be as easy as a button that triggers a message for the admin.
GDPR-wise, it must be possible to and obvious how to delete your own profile.

I worked for a partnership community platform for many years and they had a button "Yes, delete my profile" ... many customers clicked at this button and later complained they wanted their profile back.
So they changed it to "Yes, delete my profile (this process cannot be undone)" ... but it didn't help.
They changed again and now you have to fill some captcha and you have a second step that asks "are you really really sure?", but still there are some customers that delete their profile and later want to have it back.
So they decided (it was before GDPR) to not delete user profiles, but just set them inactive, and only delete them after 2 months the user did not complain.
The bottom line of all this is: There is no automatic process that will work for all platforms or use cases.

If I throw something in a bin and later complain that I shouldn't have thrown it away, should the bin then be removed to prevent that situation?

It's up to you, but if you want to minimize the workload for your customer support, you WILL think about your processes.

That is a good point, thank you!


Add the ablitity to transform the event to array

This PR doesn't have a BC but it adds a public function to be able to serliaize an event as an array.
Context:
We are using the backend as a proxy and we decorate a few part of the payload (re-set the project ID for example).
In a previous version it was possible to re-use more logic but with the current code the method serialize returns a string which makes it not possible to re-use (except if we decode it again...).
We are currently forced to implements PayloadSerializerInterface and to copy/paste everything from PayloadSerializer just to be able to get the payload as an array and reconstruct the $record to decorate it and save it as a file, having a public method would make our implementation less fragile.

It looks like there is still something to rebase, as I see a commit that shouldn't be here 🤔

Thanks, hopefully it should be green now


[Infrastructure] Adds support for capturing process dumps for hanging builds on Windows

Downloads and installs ProcDump as part of the build.
Registers a scheduled job that wakes up in 160 minutes.
Upon waking up, the background job lists all the processes it
received as candidates.
For each process it captures a full memory dump.
At the end of the build, a separate step checks on whether the job
ran (the build hanged) or everything is correct and displays statistics.
If dumps are found, they are collected and made available as artifacts
under Windows(_Templates)_Tests_Dumps.

A future improvement is to use dotnet-dump instead of ProcDump to cover Linux too, but starting with ProcDump as it also allows capturing dumps on First Chance Exceptions, which is something I'm also looking to enable.

/azp run

@javiercn the general point is you seem to be writing this for yourself. Even then, displaying information about unrelated jobs and showing the script that's right in the .ps1 file don't help.
My point about artifact/log is we already have too many artifacts, making it hard to find anything and a non-required artifact containing only one or two files isn't enough to justify its existence.

the general point is you seem to be writing this for yourself

I'm not even sure how to answer this. I really don't know what you mean.

@javiercn the general point is you seem to be writing this for yourself. Even then, displaying information about unrelated jobs and showing the script that's right in the .ps1 file don't help.

I've narrowed it down to show just jobs that match the pattern CaptureDump*.

My point about artifact/log is we already have too many artifacts, making it hard to find anything and a non-required artifact containing only one or two files isn't enough to justify its existence.

I don't agree with this. Putting the artifact in Logs makes it harder to find, simply because it makes the artifact visible when you click in the artifacts tab. That said, I changed it because I care way more about us capturing this information than about us discussing where it goes.
I think I've addressed all your feedback at this point.


Remove padding override

This addresses #4 and removes the padding override while maintaining the margin resets.

Howdy—thanks for the pull request, @karelvuong!
Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute.
At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom.
Questions? Just holler—I'm here to help :).
<3

Oh actually we need to leave this as-is for now. Apologies while we work out those rather shitty global overrides that this addresses.


Use coveralls instead of CodeCov

🚀 Feature Proposal
Use coveralls instead of codecov for coverage reporting
Motivation

Coveralls is a great tool, and is even recommended by InstanbulJS itself (doc)
Coveralls is used by many popular JavaScript projects like Facebook's ReactJS, React-native, VueJS, Bootstrap etc
Codecov had an full-blown outage yesterday (status), coveralls also had outages but it's limited to job processing backlogs (status)

Coveralls is a great tool, and so is Codecov which is also used by many popular JS libs
Is there a compelling feature we would get from Coveralls we don't have with Codecov that justifies switching and losing all of the coverage history we have in Codecov?

The CodeCov unavailability from yesterday was a dealbreaker for me as a developer (tweet)
I couldn't find an easy way to export coverage history from CodeCov to CoverAlls, I've asked them on twitter (tweet)

Yeah that was pretty unfortunate
I'm not sure how the rest of the community feels but I'm personally pretty empathetic to the occasional downtime and since it can happen to everyone I'm not compelled to switch for just that reason

Guys, do you know anything about browser extensions? Why author has removed them?

Repository is archived https://github.com/codecov/browser-extension

(


Add Flair Overview Page

Hi,
this PR adds the first version of the Flair Overview page :hugs:

/cc @alanakbik for review :)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Related to #1015

PR is ready from Flair side, so I removed draft status :hugs:

very cool doc page: https://huggingface.co/docs/hub/flair


Pyte v0.7-dev

I understand that you might not want to upgrade pyte to its beta dev version now, but pyte 0.5.2 doesn't handle OSC sequence very well. This 1337 OSC sequence is very common for iTerm2 users on macOS.
This PR is more for future references or other potential users.
Before

After

By the way, it seems that the resize functionality is broken, what kind of optimization have you done to CustomHistoryScreen?

We are on 0.5.2 due some bugs I saw in 0.6 and forward. See ce1b6a096cb2604a74f4152b33bbfbe940f8483d for details.
Are you using newer Pyte when seeing the resize issues ? It works fine for me on devel.

Ya, I am talking the newer pyte v0.7-dev. I am trying to understand pyte in order to fix it.

If I recall correctly resizing isnt working in pyte 0.5.2 either. Thats why I have implemented my own (copied mostly from a previous version of pyte).
I am still considering looking further into the gateone terminal as well.

no point to keep this open

We can discuss then again after I've looked into gateone a little more. If gateone doesnt work out after all we definitely need to look into newer pyte version.

Sounds reasonable, good job btw :+1:


Parenthesis not visible in comments when matching brackets are highlighted

With onedark:

Without onedark:

This is happening because the color of the comments is the same as the matching parenthesis highlight color. This makes using brackets a little difficult in the comments.

Possible solution:
Set the 'MatchParen' highlight group's guibg to a lighter shade.
:h hl-MatchParen

You could change the colors to fix it. This is my config:
require('onedark').setup {
    style = 'dark',
    colors = {
        grey = '#868686', -- Comments
        light_grey = '#a3abbf',
        bg3 = '#1e1e2e'   -- Selection
    }
}
require('onedark').load()


Added exporting of rollingMaxConcurrentExecutionCount value.

Make exporting of newly added property to dropwizard. Original issue is https://github.com/Netflix/Hystrix/issues/54 and pull request adding given metrics is mentioned here https://github.com/Netflix/Hystrix/pull/667 .

Thanks @LuboVarga !


(Python) Incorrect Highlighting of string

Information

Language: Python
Plugins: None

The test page to generate the error:
Test Page
Description
In python, we can use a \ (backslash) to continue the string on another line
s = "first line \
second line"

But the syntax doesn't highlight the string.
This doesn't just end in string, but it is used for every line break where line continuation is required.
Reference: python-long-string

can i work on this issue ?

Sure go ahead.


fix Fix Jemalloc dirty page usage strategy and some memory management bugs

What problem does this PR solve?
Fix Jemalloc dirty page usage strategy:

Process memory and system available memory no longer consider Jemalloc dirty page memory.
Refactor jemallctl related methods to get_jemallctl_value, set_jemallctl_value and action_jemallctl.
Add je_reset_all_arena_dirty_decay_ms and je_decay_all_arena_dirty_pages
Modify je_purge_dirty_pages_thread to je_reset_dirty_decay_thread, disable Jemalloc dirty page when process memory exceeds soft mem limit, and re-enable it when memory is sufficient. (see the code comments for detailed strategies)
When Allocator memory check fails, try to decay or purge Jemalloc dirty page. (see the code comments for detailed strategies)

Fix some memory management bugs:

Fix label_to_queryid failure log. (need to synchronize branch-2.1)
Fix is_exceed_soft_mem_limit and is_exceed_hard_mem_limit are skipped when bytes is equal to 0.
3 Fix memory daemon thread waiting time from 1s to 100ms. (need to synchronize branch-2.1)
Fix memory daemon thread notify at the end of each loop execution. (need to synchronize branch-2.1)

Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?


Problem with add picture to category image

I trying add *.ico to category image and this is error.

That looks like you have no categories? Can you walk me through what you did so I can repro locally?

This should have been fixed now.


Implement PopUp Design

Description
I'd like to work upon implementing the design for the popups

Domain
UI/UX
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of Smart Home App.

/assign


Override arity for subscribe to not send end callback

Now the subscribe function needs to send the 3 functions (on-value, on-error, on-end) but the on-end is seldom needed.
Would be cool to support both arities (3 and 4)

Is that referenced commit is that you are expecting?

Yes :)

Deployed latest snapshot with the change! ;)


Support the community standard defer-hydration attribute

This will allow us to avoid the node renaming mechanism for lazy custom element hydration, which will be much faster.
via: https://github.com/11ty/is-land/issues/13#issuecomment-1312570393
Proposal: https://github.com/webcomponents-cg/community-protocols/pull/15
Currently this requires component authors to add support for this attribute to their component code. is-land takes the task of removing the attribute when the island is ready.

Sample component implementation here: https://github.com/11ty/is-land/blob/fafe092b551d2f741203e9e86858b71df4f0c76d/lib/chocolate-web-component.js

cc @dgp1130 this is shipping with is-land v3.0.0!
cross-linking to https://github.com/11ty/is-land/issues/13#issuecomment-1312570393

Awesome! Was planning to make a PR / file an issue about this after our discussion, but looks like you beat me to it. :grin:

@dgp1130 Nerd sniped 😅


Langlibs updates

Update Text_LanguageDetect and Intl libraries.
Use global composer autoloader to include them.

Can we merge this soon as long as we are still bit further from a new release to see if there are some regressions I haven't discovered. On my dev instances with current PHP7.1 warnings have disappeared. But there have also been some language names changed which I could even spot with my very few random sample tests.


loggedOn enhancement

I would like to have a feature to test if you are currently logged in or not since if you try to login it causes an error. I know i could use the LoggedOn event to save it but i cant log when it logs off.

If the steamID property is null, you're not logged on. Otherwise, you are.
There currently isn't any way to check if the SteamUser is in the process of (re)connecting, would you like something for that?


Update /ja/docs/tasks/tools/install-minikube/

This is a Feature Request

What would you like to be added
Update /ja/docs/tasks/tools/install-minikube/
Why is this needed
This document is outdated.
Comments
https://kubernetes.io/docs/tasks/tools/install-minikube/
https://kubernetes.io/ja/docs/tasks/tools/install-minikube/
/language ja
/assign
/kind feature
/priority backlog

This document has been moved here https://minikube.sigs.k8s.io/docs/start/linux/

Oh, thanks for information.

/milestone 1.16-ja.1

/close


[maistra-2.1] add backported fixes

Before this is reviewable:

[ ] Needs https://github.com/maistra/envoy/pull/173 to go in first
[ ] Needs to merge maistra-2.1 afterwards

Summary:

Backport 1.19/0003-oauth2-do-not-blindly-accept-requests-with-a-token-i.patch
Backport 1.19/0002-healthcheck-fix-grpc-inline-removal-crashes-749.patch
Backport 1.19/0001-decompressors-stop-decompressing-upon-excessive-comp.patch

This targeted to wrong branch, will re-open against the correct one


Code folding is not working properly

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T21:22:49.932Z)
OS Version: Windows_NT x64 6.3.9600
Extensions:

Extension
Author (truncated)
Version

unique-lines
bib
1.0.0

npm-intellisense
chr
1.3.0

jsrefactor
cms
1.5.3

jshint
dba
0.10.15

vscode-stylesheet-formatter
dba
0.2.0

githistory
don
0.2.3

jquerysnippets
don
0.0.1

xml
Dot
1.9.2

javac-linter
fau
1.2.6

JSDocTagComplete
Hoo
0.0.2

java-properties
ith
0.0.2

guid
kos
0.0.1

markdown-shortcuts
mdi
0.8.1

HTMLHint
mka
0.4.0

prettify-json
moh
0.0.3

vscode-scss
mrm
0.6.2

csharp
ms-
1.13.1

jscs
ms-
0.1.9

debugger-for-chrome
msj
3.5.0

vscode-sql-beautify
sen
0.0.4

markdown-preview-enhanced
shd
0.3.0

stylelint
shi
0.30.0

addDocComments
ste
0.0.8

sort-lines
Tyr
1.3.0

gitblame
wad
2.2.0

bootstrap-3-snippets
wcw
0.1.0

Steps to Reproduce:

Have this code:

function test1() {

}
    function test2() {

    }
        function test3() {

        }

Try and fold each function.
Results here:

Problems:

you cannot collapse functions test1,2,3
if you collaps the end of test1, it will contain test2 and test3
if you collapse the end of test2, it will contain test3

Reproduces without extensions: Yes/No

Appears to be a result of #3349

It was an example, the problem is with alignment, it's not the same problem. It ocurs even with functions that have code in them.

function test1() {
    'use strict';
    var x = 10;
    x++;
    if (x)
    x += 10;
}

function test2() {
    'use strict';
    var x = 10;
    x++;
    if (x)
        x += 10;
    }

    function test3() {
    'use strict';
    var x = 10;
    x++;
    if (x)
        x += 10;
}

You cannot fold the if from test1
If you fold test2, it will fold untill the end of test3!

That part of it is currently by design, since folding is only based on indentation. This issue is tracking smarter folding based on language syntax: https://github.com/Microsoft/vscode/issues/3422


Add CocoaPods podspec

I recently added KKGridView to the CocoaPods package manager.
Since KKGridView doesn't currently have a discreet version, I treated the current commit as the 0.0.1 release. Would it be possible to have your most recent commit tagged as 0.0.1 (or whatever version you feel comfortable with)? This will help greatly in dependency resolution.
Finally, this pull request adds the pod spec to the repo as well. Adding this will allow users to install an unreleased version directly from your repo. It also allows you to more easily keep the spec up-to-date with any possible changes, instead of having to remember it all when releasing a new version.
Thanks!

Awesome!


Installation problem on windows 10

Recently I was trying to install aurum on my computer for academic reasons.  However, when I was installing the python packages necessary  I got a lot of this log errors:
"error: this module is not meant to work on Windows"
And take off from requiremnts.txt some packages, I found practically all of them are python packages for MAC OS, like gnureadline, Uwmsi, etc...
Doing this way makes me feels that something will go wrong in the next steps. I have a little impression that this system just works on MAC OS
Am I right? Or it works in windows or Linux too?
Could you please give me what specific version of an OS you used to install and using Aurum Succefully?

The current software doesn't work on windows. Just on MAC or Linux debian distribution.


Add summary statistics to /stats page

At present, it can be hard to find basic statistics about a Zulip organization. They may be hidden deep in the menus, or require careful parsing of graphs.
To address this, we should display summary statistics at the top of the organization's /stats page that answer the most common questions an administrator might have about their organization. In particular, we should show:

Number of users: Current number of non-deactivated users
"Number of members and multi-stream guests" and "Number of single-stream guests", which should add up to the total in (1). This is relevant because of the details of how Zulip Cloud orgs are billed: https://zulip.com/help/roles-and-permissions#billing-and-guests.
Total number of messages
Number of messages in the last 30 days
Storage space in use (currently shown under Personal settings > Uploaded files, e.g. "Organization using 0.0% of 5 GB."

CZO discussion thread

@zulipbot claim

@zulipbot claim

Hi @mittal-parth , any progress on this one?

I am so sorry @alya, got caught up with college work. I had understood the existing code to some extent and was building the layout . Since I will be able to take it up only after a week, I'll leave it for someone else to take it up if interested. If not, I'll resume after a week.

@zulipbot abandon

Hi @alya! This seems like an interesting feature. Do you have any design for the summary stats in mind? It would be wonderful if you can suggest some CSS or existing templates from which we can get some ideas.

@oliver-pham Have you explored the code for the /stats page?
Once you have done so, you can post your thoughts and get feedback on chat.zulip.org (in #frontend for more technical discussion, or #design to discuss what it would look like).

Hi @oliver-pham! Since I had gotten some idea about the code around stats, it would be great if you can do the designing and I can fetch the data from the backend. Let me know if that sounds good! 😄

I'm not a designer myself, but I can try to help you with the design. I've created a topic for this in #frontend on (on chat.zulip.org) and suggested some ideas. Before claiming the issue, can we discuss your approaches in #frontend, @mittal-parth?


⚠ Bofrost.es has degraded performance

In aedea07, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1622 ms

Resolved: Bofrost.es performance has improved in 90225ea after 7 minutes.


grPC Requests not routing from parent space to selected space

We have several services, one of which is exposed publicly, which we will call the BFF. The BFF is a node/apollo server that makes calls to other services using gRPC (via grpc-caller). I know that in order to properly use services in the current dev space the azds-route-as header needs to be propagated, and my searches led me to believe grpc metadata was the way to do so. However, this does not seem to work: traffic routes from the parent space's BFF to the parent space's services instead of my current space.
Routing does work however if I use my own copy of the BFF in my current space. We would like to be able to have requests route correctly to parent space services and back to our own spaces if possible though, as that's the point of this whole thing.
Am I doing this incorrectly?

You are likely doing everything correctly. Unfortunately what you are running into is the fact that Dev Spaces doesn't currently support routing gRPC calls, only http/1.1. It is on the backlog to support additional protocols, but we don't have a timeline for that work yet.

+1 for gRPC support.


runtimes: Add nodejs20 image

Description
Changes proposed in this pull request:

Add nodejs20 image

Related issue(s)

#745

/retest

Waits for https://github.com/kyma-project/test-infra/pull/10010


Add Tests for Add, Remove Custom Device and Add, Remove Local Chassis

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Custom Device Source/Tests/Unit Tests/Scripting API/Custom Device/test_Add Custom Device.vi - Adds a custom device and verifies that the target properties change appropriately when sync to scan is selected.
Custom Device Source/Tests/Unit Tests/Scripting API/Custom Device/test_Remove Custom Device.vi - Adds a custom device, verifies it can be found, removes the custom devices, then verifies it cannot be found.
Custom Device Source/Tests/Unit Tests/Scripting API/Custom Device/test_Add Local Chassis.vi - Adds a custom device and local chassis, ensures the chassis has been added along with the appropriate number of slots.
Custom Device Source/Tests/Unit Tests/Scripting API/Custom Device/test_Remove Local Chassis.vi - Adds a custom device and local chassis, verifies the chassis can be found, removes the chassis, then verifies the chassis cannot be found.
Scan Engine Scripting.lvlib/Find Scan Engine Custom Device.vi - Addresses a bug where I was inappropriately closing a reference prematurely (found while executing previous mentioned tests).
Why should this Pull Request be merged?
Provides unit tests for the current scripting API.
What testing has been done?
Verified all the tests passed using the local JKI VI Tester tool.

I haven't had a chance to look at the rest of the changes closely, but I'd prefer if we cleaned up the reference closing a bit more. In particular:

[ ] There's no need to close the result of FindChildrenByGUID both inside and outside the case structure -- we can remove the close call circled in red.
[ ] I'd prefer if we branched the result of GetCustomDevices going in to the loop and passed it to close outside of the loop, rather than passing it through the loop (highlighted). Passing it through the loop makes it look like the reference could change, when it can't.

@rtzoeller

[x]  There's no need to close the result of FindChildrenByGUID both inside and outside the case structure -- we can remove the close call circled in red.
[x]  I'd prefer if we branched the result of GetCustomDevices going in to the loop and passed it to close outside of the loop, rather than passing it through the loop (highlighted). Passing it through the loop makes it look like the reference could change, when it can't.

[ ] It seems like all of the tests use the same setup logic.

Move that to the setUp.vi provided by the test class (the references can be bundled in the class data, and unbundled in the test), and close the references in tearDown.vi. I don't see these VIs in your test class (at least on GitHub), so you may need to copy them from another test class if they were deleted.
You'll need to run the tests through the interactive test runner to get setUp and tearDown to be called correctly. I'm guessing R+F has some examples of this shared setup/teardown logic.


Additional tweek to sink matcher docs

Made some additional changes here to try and clarify even more. Thoughts?

Whoops, seem to have mixed things up with the PRs. Sorry


Media Library: cannot edit or delete media items anymore

Bug Description
One can no longer edit or delete media items anymore in the media library.
When clicking on the three dots it inserts the media item instead of opening the a menu.
Expected Behaviour

Hover over media item in media library
Click on three dots
Be able to edit or delete media item

Steps to Reproduce

Hover over media item in media library
Click on three dots
Notice that media is inserted on page instead

Screenshots
https://user-images.githubusercontent.com/841956/104295874-47812780-54c1-11eb-83de-30f6b17ddbe0.mov
Additional Context

Plugin Version: 1.2.1 / current main
WordPress Version: 5.6
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA

Verified in QA


[WIP] Fix Compactor configuration issues

Remove unused jaeger-agent
Add PVC

It's draft because we haven't decided capacity of the PVC

Let's first investigate what is using disk space. Ability of execing into compactor would be nice

Overall the changes look good to me.

cc @aditya-konarde

Thanks @kakkoyun !


How to retain ip of vm when it stop or restart?

Is your feature request related to a problem? Please describe:
A clear and concise description of what the problem is.

i have created a vm which ip is assigned <IP_ADDRESS>
after i restarted the vm, it's ip has been occupied by other vm, it results in the orginal vm can not start up because ip is conflicted.

Describe the solution you'd like:
A clear and concise description of what you want to happen.
how can i retain ip to the origin vm?
Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.
Additional context:
Add any other context or screenshots about the feature request here.

/sig network
/reopen
/remove-lifecycle rotten
@EdDev this is repeating question(in all sort of flavors). Do we have some docs or general answers? (like this will most likely not work because of....)

@EdDev this is repeating question(in all sort of flavors). Do we have some docs or general answers? (like this will most likely not work because of....)

It is hard to generalize a note in the documentation about this.
IP reservation is up to the IP provider, which is in most cases is the network provider. When using a VM, an IP should be allocated from a reserved pool or a mechanism that can be controlled.
KubeVirt itself is not providing any such tooling for reserving network providers IP/s.
If we want to have VM/s reservations like this in a transparent manner, we will need to keep the pod (virt-launcher) as a placeholder (so the network provider will not release the IP for example). I guess it does not make sense and it will probably not work when there is a need to consider migrations.

KubeVirt is not managing IP addresses, it relies on other components to do so.
As there are no plans to invest in this, I'm closing this request.
/close


Tool doesn't respond to USB Midi

Tool does not respond to USB midi. It does work if I mouse a key on the tool.
I can confirm that my USB 1 Global Channel is sending messages on my Nord Stage 2-- I can see a Midi receive light in Ableton Live (as well as I can control the Nord from Live).
However, your tool does not respond when I press any keys on the Nord. I've done this in Chrome and Firefox as well as refreshed after the window is open.
Would love to know if it is user error (me) or something that you can fix on your end. Happy to help troubleshoot.
I'm really looking forward to using the tool and will contribute to Patreon.

Never mind. I restarted the whole system and it worked. Starting with just the PC. Case closed.

Hmm, glad it's working for you now, but feel free to reopen this if you see that issue come up again. A few people have reported some odd behavior along those lines. There may still be something going on.

Future request. To be able to mute the left or right hand. (I put the tempo of both to the same to practice one hand. Two hands is a whole other level. I didn't realize how far I am out of beat with the left. Complete muscle thing. Right hand worked pretty well. Great practice tool.) Well done.
  From: Michael New<EMAIL_ADDRESS>
To: michaelnew/web-piano<EMAIL_ADDRESS>Cc: jrgitsf<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Sent: Tuesday, March 7, 2017 11:45 AM
Subject: Re: [michaelnew/web-piano] Tool doesn't respond to USB Midi (#4)
Hmm, glad it's working for you now, but feel free to reopen this if you see that issue come up again. A few people have reported some odd behavior along those lines. There may still be something going on.—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

I spoke too soon. It would not respond to my usb midi input again since restarting from last night. Nothing has changed- hardware or software. I restarted the computer. It would respond to midi usb in Ableton so midi is being transmitted via USB.

Is there anything else that goes wrong, or does everything work except for the midi input? Like can you trigger notes with your computer keyboard or by clicking?

I can trigger notes via computer keyboard or by mouse. Everything else works fine.


Fix ImportError when no zarr module

It looks like this was intended to re-raise the ImportError thrown from from .zarr import write_zarr, but this exception object isn't part of the closure of the stub write_zarr function. This results in a rather confusing NameError:
Python 3.8.5 (default, Jul 28 2020, 12:59:40)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.19.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import anndata

In [2]: d = anndata.read_h5ad('test.h5ad')

In [3]: d.write_zarr('test.zarr')
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-3-c464adf1b7d1> in <module>
----> 1 d.write_zarr('test.zarr')

~/.opt/python3.8-venv/lib/python3.8/site-packages/anndata/_core/anndata.py in write_zarr(self, store, chunks)
   1906         from .._io.write import write_zarr
   1907
-> 1908         write_zarr(store, self, chunks=chunks)
   1909
   1910     def chunked_X(self, chunk_size: Optional[int] = None):

~/.opt/python3.8-venv/lib/python3.8/site-packages/anndata/_io/write.py in write_zarr(*_, **__)
     20
     21     def write_zarr(*_, **__):
---> 22         raise e
     23
     24

NameError: name 'e' is not defined

Replace this NameError with a more interpretable failure, suggesting that people install the zarr package as required. I don't have a strong opinion about the wording of the new ImportError message, but anything is better than what I pasted above.

Thanks for catching this!
I think the intent behind the previous version was to raise the correct import error in case a missing zarr dependency was causing the issue. How about something more like this:
from copy import copy

try:
    import zarr
except ImportError as e:
    ref = copy(e)
    def write_zarr(*_, **__):
        raise ref


Indexer type should be check when used as return value

In this case there is no warning but there should be:
function foo(): { [source: string]: string } {
  return undefined;
}

This was already working.


Org links and git hooks

Organization wide application of GitHooks https://github.com/ethereumjs/ethereumjs-account/pull/46 and organizational docs linking https://github.com/ethereumjs/ethereumjs-account/pull/49.

Coverage remained the same at 90.145% when pulling 46389cee8acede058dddfd7dcde6ad7a9e0c65ac on org-links-and-git-hooks into 572d4bafe08a8a231137e1f9daeb0f8a23f197d2 on master.


Invalid getLinkingEntities response

Hi
I am creating entities in a hierarchical view.
ValidValuesSet Root
	ValidValuesSet A in Root
		ValidValuesSet B in A
			ValidValuesSet C in B
				ValidValuesSet D in C
					ValidValueDefinition in D

Glossary
	Category Root in Glossary
		Category A in Root
			Term A in Category A

Then I create links between some of them
ValidValueDefinition in D -> Category A in Root
ValidValueDefinition in D -> Term A in Category A
ValidValuesSet B in A -> Term A in Category A
ValidValuesSet C in B -> Category A in Root
Then I request getLinkingEntities:
start = ValidValuesSet A in Root
end = ValidValueDefinition in D
The response is missing a relationship between "ValidValuesSet B in A" and "ValidValuesSet C in B".
Why?
Attached is the complete request log.
Rest.log

Hi, is there any news on this issue?

Hi @Inventoroz -- I haven't had the bandwidth to try to reproduce or resolve, as the graph queries are generally seen as less of a priority for repositories at this point (I believe most / all OMAS layers are implemented based on other methods anyway since very few repositories even attempt to support the graph queries today)...
If you'd like to make an attempt at resolving and submit a PR for the same, please feel free!


feat(GuildProfile/lang): add simplified chinese language

I am a little confused about the translation of "GUILD_PROFILE_RELAY_ENABLED". What does "Relay" mean?

Apparently, it means that shard connections transmit information between each other for that specific guild. I think that flag is never sent to a user client since sharding is only available for bots. I'll probably remove it in the future, so don't worry about it.

Apparently, it means that shard connections transmit information between each other for that specific guild. I think that flag is never sent to a user client since sharding is only available for bots. I'll probably remove it in the future, so don't worry about it.

Ok, thank you for your reply.


fix back button overriding

I think this will be fixed once we move to D3.js.

Actually this won't be fixed with D3.js, and the problem lies somewhere else. It's just a matter of tweaking this line window.history.pushState(null, null, url); on client/reducers/mapReducer.js so that the new url doesn't override the old one.

I checked more on this, that line was correct, and the problem was that window.history was conflicting with react-router-dom. This should be fixed after refactoring on v2 branch.


False positive: Configuration.php

Hello,
I would like to report ModSecurity is blocking access to programs containing Configuration.php in the URL for the RosarioSIS web-app.
It was reported various times on the forum:
https://www.rosariosis.org/forum/d/548-solved-configuration-screen-no-longer-accesible/
https://www.rosariosis.org/forum/d/123-ajax-error-406-not-acceptable/
Example URLs are:
http://localhost/rosariosis/Modules.php?modname=School_Setup/Configuration.php
http://localhost/rosariosis/Modules.php?modname=Grades/Configuration.php

This issue mostly happens with cPanel.
Deactivating ModSecurity solves the issue, but of course a solution involving ModSecurity regexes involved would be welcome.

Hello @francoisjacquet ,
The ModSecurity engine provides the toolkit for blocking requests, etc. The actual logic for when to take such action is handled by the rules that you are using.
You would need to identify which rule(s) are causing the issue. If it is not a custom rule that you have written yourself, you could opt to report the FP to the rule provider that you used for the rule.
Often, however, it simply up to each installation to write an exception to whatever the FP-causing rule is. For example, for a particular URL, you could exclude examination of a particular query argument for the rule in question.

Thank you for your answer.
I have installed ModSecurity on my machine, here is what I have in the Apache error log:
[Tue Sep 27 18:28:50.862622 2022] [:error] [pid 28233] [client <IP_ADDRESS>:40916] [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:anomaly_score. [file "/usr/share/modsecurity-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "93"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 5)"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "localhost"] [uri "/rosariosis/Modules.php"] [unique_id "YzMkwhwnDFau5ozRS3vncAAAAAA"], referer: http://localhost/rosariosis/Modules.php?modname=School_Setup/Configuration.php
[Tue Sep 27 18:28:50.863461 2022] [:error] [pid 28233] [client <IP_ADDRESS>:40916] [client <IP_ADDRESS>] ModSecurity: Warning. Operator GE matched 5 at TX:inbound_anomaly_score. [file "/usr/share/modsecurity-crs/rules/RESPONSE-980-CORRELATION.conf"] [line "91"] [id "980130"] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 5 - SQLI=0,XSS=0,RFI=0,LFI=5,RCE=0,PHPI=0,HTTP=0,SESS=0): individual paranoia level scores: 5, 0, 0, 0"] [ver "OWASP_CRS/3.3.0"] [tag "event-correlation"] [hostname "localhost"] [uri "/rosariosis/Modules.php"] [unique_id "YzMkwhwnDFau5ozRS3vncAAAAAA"], referer: http://localhost/rosariosis/Modules.php?modname=School_Setup/Configuration.php

Part of the OWASP ModSecurity Core Rule Set ver.3.3.0.
So will be opening an issue at https://github.com/coreruleset/coreruleset as suggested, right?

Yes, that's the right place for CRS.


To enable the pre-commit hooks simply make dev.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR

Also we should add something to the Contributing file so contributors know to expect this to fail during commits if they have issues

I'm guessing that this doesn't limit itself to the things that were just changes, so this should include a reformatting of the entire codebase, right?
In particular we have never event run flake8 on the test directories. I'm wondering if it might not be easier to skip the test/unit and test/integration directories for now, since they're going to change a lot soon.

@iknox-fa have you tried running this yet to see what we need to fix up in our code base? I'm guessing we don't abide by this perfectly right now 😄

Its... a lot.  306 of 332 files were reformatted when I did a test run locally.

Also we should add something to the Contributing file so contributors know to expect this to fail during commits if they have issues

Good call.  Updated

I'm guessing that this doesn't limit itself to the things that were just changes, so this should include a reformatting of the entire codebase, right?

Be default it just corrects files that you are currently trying to commit, but you can run it against everything of course.  We will want to run it against everything just to minimize the confusion that might come from a PR touching so many files, but I'd like to do it in a separate PR.

In particular we have never event run flake8 on the test directories. I'm wondering if it might not be easier to skip the test/unit and test/integration directories for now, since they're going to change a lot soon.
I think we should go ahead and do everything, in theory black makes the testing code easier to read so it would be useful to do before you go refactor a ton of it.

Love it! Can we please enforce these pre-commit hooks in CI and move the black config (line length) to a config file (pyproject.toml) so that IDEs, editors, and running black . directly on the cli can all use the same config?

pyproject.toml has further reaching implications than just linting stuff!  That said I'm all for it (and it's the only way if you want to escape the hellscape of setuptools some day).
I went ahead and put this in another ticket, as it may cause issues with some of the other tools that build/interact with dbt.

This will only run on git staged files. Is that what is intended here?
Nope.. fixed.

I think there are some references in CONTRIBUTING.md to tox and flake8/mypy, can you update this as well?
https://github.com/dbt-labs/dbt-core/blob/pre-commit-CT-105/CONTRIBUTING.md#tox

Whoops.  Missed this comment initially.  Fixed now!


Category headers still inaccurate for some case

So I saw this issue back in March on #1856 but an instance we have still has the category headers inaccurate in a site with the 11.2 version of GBNG (As of Nov 22nd) These are 2 categories

However for the item NUR 223 Exam 1 it's under the header "Collaborative Exams" even though it is assigned in the Category Exams. This is the same for Collaborative Exam 1 which is in the Collaborative Exam column but in the Quizzes category header.

It appears fine in other areas an in Gradebook Classic. I wonder if a merge was missed somewhere or if this could still be a bug?
Update when I went to the Settings and gave the Collaborative Exams category 1% and saved it put them under the right header. Changing it back to 0% after seems like it kept it correct. I tried to reproduce on nightly with a 0% category and didn't seem to be able to reproduce the problem. Not sure what the issue here is but it's the first time I've seen it.

Can you reliably reproduce this?

No, at the time I didn't see any way to reproduce this. I'm going to close for now, and if we get any more reports or a way to reproduce I'll re-open.


fix(style): fixed height of the bib #62

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #62
Summary:
Fixed height of the bib
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.2.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Windows local host PATH not appended when starting with zsh

Windows Version
Microsoft Windows [版本 10.0.26100.2161]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (root@941d701f84f1) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP Fri Mar 29 23:14:13 UTC 2024
Distro Version
24.04
Other Software
Docker Desktop(Windows), version 4.34.3 (170107)
zsh in WSL, version 5.9
tmux in WSL, version 3.4
windows terminal, version 1.20.11781.0
zsh4humans(https://github.com/romkatv/zsh4humans) with option 'always run zsh in a tmux session' enabled
Repro Steps

install zsh, tmux, and zsh4humans in the ubuntu 24.04 WSL distro
change login shell to zsh: chsh -s /usr/bin/zsh
quit docker desktop and wsl (wsl --shutdown).
restart docker desktop
launch a wsl ubuntu distro shell(open a ubuntu tab in windows terminal).
echo $PATH and see value of PATH doesn't contain paths that defined in windows local system.
and I note that if I didn't run docker desktop first, just open a ubuntu tab in windows terminal directly, the tab would crash and close automatically. Then I open a new tab and it runs well with PATH value well initialized.

Expected Behavior
$PATH variable should include paths that are defined in windows local host system.
Actual Behavior
$PATH variable didn't include paths that are defined in windows local host system.
Diagnostic Logs
WslLogs-2024-11-04_22-01-51.zip

I was unable to reproduce the issue in quick manner:
hayden@XPS15:~$ sudo apt install zsh -y
...
Unpacking zsh (5.8.1-1) ...
Setting up zsh-common (5.8.1-1) ...
Setting up zsh (5.8.1-1) ...
...
hayden@XPS15:~$ echo $PATH
/home/hayden/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/:....

Then:
hayden@XPS15:~$ chsh -s /usr/bin/zsh

PS C:\Users\hayden> wsl.exe --shutdown

Restarted Ubuntu. Went through zsh setup. Configured new completion system, but that was all.
Then:
XPS15% echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/

Could it be something in your zsh config?

@Wakotu: Do you see the same behavior with let's bash ? I wonder if you have something in your zshrc that override $PATH

Everything works well when login shell is bash
I think no. I just extended value of PATH variable like export PATH="/usr/local/go/bin:$PATH". And if I start with bash shell and then invoke zsh shell, PATH is also fine.

I was unable to reproduce the issue in quick manner:
hayden@XPS15:~$ sudo apt install zsh -y
...
Unpacking zsh (5.8.1-1) ...
Setting up zsh-common (5.8.1-1) ...
Setting up zsh (5.8.1-1) ...
...
hayden@XPS15:~$ echo $PATH
/home/hayden/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/:....

Then:
hayden@XPS15:~$ chsh -s /usr/bin/zsh

PS C:\Users\hayden> wsl.exe --shutdown

Restarted Ubuntu. Went through zsh setup. Configured new completion system, but that was all.
Then:
XPS15% echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/

Could it be something in your zsh config?

I guess your're right. WSL worked the same way in my machine in your manner.
My zsh config consists with zsh4humans and my custom config. It turns out that my custom config didn't lead to anything wrong. I guess there's some action inside zsh4humans framework that conflicts with wsl windows path initialization process.
But it's strange that zsh4huamns works well when I login with bash and run zsh.
Also, launch docker desktop before starting a wsl shell is needed for reproducing this bug.
screenshot below.

I was unable to reproduce the issue in quick manner:
hayden@XPS15:~$ sudo apt install zsh -y
...
Unpacking zsh (5.8.1-1) ...
Setting up zsh-common (5.8.1-1) ...
Setting up zsh (5.8.1-1) ...
...
hayden@XPS15:~$ echo $PATH
/home/hayden/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/:....

Then:
hayden@XPS15:~$ chsh -s /usr/bin/zsh

PS C:\Users\hayden> wsl.exe --shutdown

Restarted Ubuntu. Went through zsh setup. Configured new completion system, but that was all.
Then:
XPS15% echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files/usbipd-win/

Could it be something in your zsh config?

and I notice that only the first zsh session is broken. Exit first session and launch a new zsh session, the second one is fine.

I setup similar environment on a machine that runs windows 10 22H2. And that problem occured, too. but a third machine which runs windows 10 22H2, with ubuntu 22.04 wsl2 distro didn't seem to show that problem .
I guess that ubuntu 24.04 distro would be the key?

@Wakotu let's look at what's actually happening inside zsh. Could you share the out of:
wsl -d <distro> zsh -x

This should let us see if something happens to $PATH.

@Wakotu let's look at what's actually happening inside zsh. Could you share the out of:
wsl -d <distro> zsh -x

This should let us see if something happens to $PATH.

Preliminaries:

set distro login shell to zsh  chsh -s /usr/bin/zsh
zsh4humans zsh framework installed with 'always run in tmux' option enabled.

Run the command without launching docker desktop
command;

wsl --shutdown
wsl -d ubuntu zsh -x

stdout output:
no-docker-init.txt
phenomenon:
Enter a tmux session and crashed unexpectedly, with $PATH env var not well initialized.

Run the command after launching docker desktop
command;

wsl --shutdown
launch docker desktop
wsl -d ubuntu zsh -x

stdout output:
docker-init.txt
phenomenon:
Enter a tmux session with $PATH env var not well initialized. But no crash.

I don't see the "echo $PATH" commands in the output files. Could you run the entire shell session, include the "echo $path" under zsh -x ?

I don't see the "echo $PATH" commands in the output files. Could you run the entire shell session, include the "echo $path" under zsh -x ?

I think video would be more intuitive.
https://github.com/user-attachments/assets/cea5b591-7040-4556-b6c2-a5862dcb55c1


Scenarios

Haddock can be used in different scenarios like the examples and tutorials. It would be nice if the web application gave an overview of scenarios.
When an user picks a scenario it would be great to show the workflow builder with everything already filled in.
The scenario could include some instructions how to use it on the users own data, for example which files to upload.

Would be nice to have an scenario which was quick and gave multiple clusters to make the caprieval analyis report interesting.

In #87 the protein-protein and antibody-antigen scenario pages where added.

These pages should be made easier to use, for example by

Picking chains from PDBs
Make first molecule have chain A and second molecule have chain B

Could be done by calling the PDBtools webservice

Pick restraint residues from 3D viewer, 2D sequence and/or list of numbers.
The *.tbl files should be generated from selected residues similar to Haddock2.4 web site.

@rvhonorato can you help with this?

Picking chains from PDBs
The *.tbl files should be generated from selected residues similar to Haddock2.4 web site.

I'm using webassembly for this in wenmr

Could be done by calling the PDBtools webservice

I'd rather stay away from pdb-tools as much as possible, it's a great cli tool but in my experience using it for anything except that is very troublesome, since the operations it do are quite trivial its simpler to re-write the ones we need. Also its web-service is not a restapi and has a custom interface which is quite tricky to interact with.

Pick restraint residues from 3D viewer, 2D sequence and/or list of numbers.

The sequence render is useful, but not simple to do - in this case specifically people should already know what are the residues since they are one of the key information.

Make first molecule have chain A and second molecule have chain B

In the new interface i'm moving away from behind-the-scenes magic and providing a dialog with options, since this unseen data editing causes much more problems than it solves.

These steps seems to be related to data pre-processing, I'd say its best to do it in haddock3 instead of here. It could recieve a parameter that triggers a specific pre-processing based on the scenario, what you think @amjjbonvin  @mgiulini ?

my opinions here are that:

reading the chains is crucial. Borrowing the wenmr code could be the best solution.
I would stick to the lists of residues to define the restraints. Of course giving also the possibility to upload the tbl file.
I would indeed not care too much about chains A and B as long as they are read at upload time.
about generating the unambig and ambig restraints, the haddock3 codebase has now all the scripts necessary to do this. once the data are read we can launch a python subprocess to generate the necessary things. Of course borrowing the wenmr code here is a (faster) possibility.

I managed to generated ambig.tbl file with #91 and https://github.com/haddocking/haddock3/pull/841
This uses the new haddock3-restraints webservice command for the haddock3 specific tasks and ngl to parse the chains and residues.

With #120 we cover the most common scenarios. Other scenarios will be done in dedicated issues.


About code release

Hi, it is really an awesome work! Is it possible to release the data preprocessing pipeline?

https://github.com/lhc1224/PIAL-Net/blob/main/process_label.py

The human pose is extracted with mmpose


Foulkesjohn master

Coverage remained the same at 92.103% when pulling 2dbc29e96d99e8776e41fcffa555beae6dfa0389 on foulkesjohn-master into bfb823d32f5d392c579ae721ee7e690e15c6c8d1 on master.


Samples fail on Windows 10 RS5

Initially posted this in the Windows Dev MVP alias but surfacing it here for visibility.
Configuration
Windows 10 RS5, Build 17751
.NET Core 2.1 console app with simple sample
Behavior
On start, immediately throws an exception on factory.CreateSpeechRecognizer(). (Does this SDK work on RS5? Final RS5 bits are on the horizon so am a little shocked here.)
I do not get the same exception on RS4.
(85): 18ms SPX_THROW_HR_IF: (0x00e) = 0xe
(85): 166ms SPX_RETURN_ON_FAIL: hr = 0x47967820
SPX_THROW_ON_FAIL: ::SpeechFactory_CreateSpeechRecognizer_With_Defaults(m_hfactory, &hreco) = 0x47967820

System.ApplicationException: 'Exception with an error code: 0xe
[CALL STACK]

    > CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - Session_SetParameter_String

    - CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - CreateModuleObject

    - SpeechFactory_CreateSpeechRecognizer_With_Defaults

    - CSharp_MicrosoftfCognitiveServicesfSpeechfInternal_FactoryParameterCollectionBase_SWIGUpcast___

    - CSharp_MicrosoftfCognitiveServicesfSpeechfInternal_ICognitiveServicesSpeechFactory_CreateSpeechRecognizer__SWIG_0___

    - 00007FFCE42D6F8F (SymFromAddr() error: The specified module could not be found.)

0xe is an internal error code for no microphone being available. Could it be you're running in a VM, for example?
[We'll improve on the error message and their documentation]

@mahilleb-msft Wow, didn't realize that. Microphone device was disabled. Now I just need to get past the authentication issue (#41), thanks.


Wwise 'mark for add' dialogue is causing Waapi-Transfer to hang

Wwise 'mark for add' dialogue is causing Waapi-Transfer import progress bar to hang until the window is cleared/ok'd in Wwise.

(using Wwise Perforce integration)

That is actually expected, fixed behavior.
Read this:
https://github.com/karltechno/Reaper-Waapi-Transfer/issues/6


Add clusterCount expression

When data is aggregated we have the _cdb_feature_count column in the result with the count of features per cluster, but we cannot use it directly as a property (it would be interpreted as a column of the base query, which is not, and added to the aggregation dimensions). So we should add a clusterCount() to access it.

Included for the next (public) release


Ignore SSL certificate for hipchat

We have self-signed certificate for hipchat server. Is there any flag i can set insecure = true  to ignore the error or any workaround to solve this problem ?
Logs-
time="2018-12-10T10:37:06Z" level=info msg="Processing update to pod: default/nginx-deployment-75675f5897-d6zrn" pkg=kubewatch-pod
time="2018-12-10T10:37:06Z" level=info msg="Processing update to deployment: default/nginx-deployment" pkg=kubewatch-deployment
2018/12/10 10:37:06 Post https://hipchat.internal/room/425/notification: x509: certificate signed by unknown authority
2018/12/10 10:37:06 Post https://hipchat.internal/room/425/notification: x509: certificate signed by unknown authority

any luck to go around https?

use insecure_skip_verify: true under http_config.
See documentation.
https://prometheus.io/docs/alerting/configuration/#http_config

Something like this
apiVersion: v1
kind: ConfigMap
metadata:
  name: kubewatch
  namespace: kube-system
  labels:
    app: kubewatch
data:
  .kubewatch.yaml: |
    handler:
      hipchat:
        token: "asdasdasdasd"
        room: "42"
        url: "https://hipchat.internal/v2/"
    resource:
      deployment: true
      pod: true
      services: true
      ingress: true
      daemonset: false
      job: false
      persistentvolume: false
      replicaset: false
      replicationcontroller: false

i was missing the / after v2 :-)
thank you very much


Add option to hide Latest tab in Browse

Adds option to hide Latest in Browse
Should close #554
Images

Setting
Result

Ignore takoyomi type tabs*

Have you tested this with the extension update badge, that was the issue last time I tried this

Closing since don't want to deal with this


⚠ ClamAV has degraded performance

In 01724f9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in fd43cda.