Framework design guidelines and default interface methods

The article in design guidelines recommends using extension methods to add helper methods to the interface: https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/extension-methods

✔ CONSIDER using extension methods in any of the following scenarios:
To provide helper functionality relevant to every implementation of an interface, if said functionality can be written in terms of the core interface. This is because concrete implementations cannot otherwise be assigned to interfaces.

However, C# 8.0 introduced default interface methods for extending interfaces. So probably the new recommendation should be to use that instead of extension methods - at least for your own interfaces.

@BillWagner Could you take a look at this suggestion?

That content is copyrighted so unfortunately, we wouldn't be able to change this particular article.

@mairaw I see now that this content comes from the book published in 2008, so it only targets .NET 3.5 & C# 3.0 or so. Are there API design guidelines updated with new runtime/language features?

There's a new edition of the book now on pre order:
https://www.amazon.com/Framework-Design-Guidelines-Conventions-Addison-Wesley/dp/0135896460/ref=sr_1_2?keywords=Framework+Design+Guidelines&qid=1581295416&sr=8-2
We'll see if we can update the docs to use that when it's published.

The 3rd edition has no recommendations for, or against, Default Interface Methods.  (The implicit guideline is to not use them).  Mainly, it's because they're too new for us to understand when they work, and when they don't.


[Improve][SeaTunnel-Web] Change JobMode and EngineType to enum type to avoid hard coding

Purpose of this pull request

Change JobMode and EngineType to enum type to avoid hard coding
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs

@arshadmohammad @Hisoka-X PTAL, thanks


Decorators don't get parameter values

I thought I would look into writing a validation decorator. I was surprised to see that parameters end up as None.
from fasthtml.common import *

app = FastHTML()
messages = ["This is a message, which will get rendered as a paragraph"]

@app.get("/")
def home():
    return Main(H1('Messages'),
        *[P(msg) for msg in messages],
        A("Link to Page 2 (to add messages)", href="/page2"))

@app.get("/page2")
def page2():
    return Main(
        Form(
            Input(type="text", name="a"),
            Input(type="number", name="b"),
            Button("Submit"),
            action="/",
            method="post"
        )
    )

def validator(f):
    def wrapper(*args, **kwargs):
        print(*args, **kwargs)
        return f(*args, **kwargs)
    return wrapper

@app.post("/")
@validator
def post(a: str, b: int):  # doesn't validate these
    print(f"Received {a=} {b=}")
    return home()

serve()

This will print None, None then the post function print also prints None for both values.
I would expect to see the values posted from the form. Without the decorator, this works as expected. I haven't looked into the source of the .post decorator method, but it seems like it is doing something that prevents my decorator from getting these parameters.
For what it's worth, f.__annotations__ works as expected.

After seeing #188, I found that the parameters can take a dataclass or a Pydantic model, so my decorator function seems unnecessary. I am curious as to why this doesn't work though.

Hello @TomFaulkner ,
from functools import wraps # Added wraps imports

def validator(f):
    @wraps(f) # <-- I added a changed here
    def wrapper(*args, **kwargs):
        print(*args, **kwargs)
        return f(*args, **kwargs)
    return wrapper

hello -1
Received a='hello' b=-1
INFO:     <IP_ADDRESS>:46590 - "POST / HTTP/1.1" 200 OK

Thanks!
Viddesh

Thanks
It's interesting that the wraps decorator helps here. I would have added it later, but my understanding is it just replaces the name of the function so it doesn't show up as wrapper.
Do you know why this helps? The decorator worked on other functions without it. I'm guessing there is a lookup done somewhere and the unwrapped decorator breaks this?

Yeah fasthtml has to be able to see all the annotations in order to inject the params.


Improve accessibility by associating for with id instead of name

Closes #214. No rush on my part. I've tested it a bit myself to make sure basic behavior hasn't changed, though I don't think I have the tools I need to test the accessibility properly.
Not sure if we want to increment those package versions.

I think Bryce wanted to test some things before merging this

I think Bryce wanted to test some things before merging this

I meant merge the PR from actions/Black, but that doesn't exist. Looks like we need to point to Bryce's new action in ALActions for formatting; the one this repo points to is broken.

I'm not sure how much harder these [fieldset] changes would be; if you think they're a lot harder, we can merge this and take another shot at them later

I do believe the fieldset conversation is a more complex one and added to the discussion in #164. We should probably save it for a separate discussion and PR. Maybe a deep dive? I've added it to the list in the doc for whenever the next deep dive happens.


Update CAPI Chart to v1.5.0

It’s part of the main issue: [Feature] K8s 1.27 Support

I’m not sure we should be shipping the .0 release in our next patch release. I would prefer we let the minor soak for a bit before jumping to it.
@jakefhyde  @richardcase @furkatgofurov7 any thoughts on this?

I’m not sure we should be shipping the .0 release in our next patch release.

Agree with this, from the release best practices perspective, we could avoid bumping CAPI to minor version in patch release.

Agree with you @Oats87 & @furkatgofurov7 we should wait for a non x.x.1 release as a generally principle (unless there is something we really need)
We'd also need #42406 (or #42402 for v2.7) to merge when doing this, otherwise we'd get failures from when CAPI looks up the kubeconfig.

Closing this issue as per above comments.


fix: —out parameter now correctly changes the output file for the dar…

…t firebase configuration
Description
The --out parameter was not changing the output location of dart files. It seems this is a bug caused by recent changes as this has worked in the past.
Type of Change

[ ] ✨ feat -- New feature (non-breaking change which adds functionality)
[ x] 🛠 fix -- Bug fix (non-breaking change which fixes an issue)
[ ] ❌ ! -- Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 refactor -- Code refactor
[ ] ✅ ci -- Build configuration change
[ ] 📝 docs -- Documentation
[ ] 🗑 chore -- Chore

@josh-burton  Woops, I missed this.  I've already fixed here with test: https://github.com/invertase/flutterfire_cli/pull/197. Thank you for the PR though 👍


chore: add 2.1.3

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Having problems with Trigger calibration

It seems to have problems saving. I get the Trigger calibration done but when I test it after, the same trigger drift appears. I've changed the flex as well. Still the same.

I'm not quite sure about trigger calibration. It may not work.
Do you reset/disconnect the DS4 before testing it? In that case, if the flash-mirror status is not changed to "permanent" (using ds4-tool), the changes are gone.

In my case calibration of L2 and R2 triggers leads to 30% and 40% on a full press. Is there a way to debug the process to help you with a fix?

In my case calibration of L2 and R2 triggers leads to 30% and 40% on a full press. Is there a way to debug the process to help you with a fix?

I managed to workaround a similar issue I had where my JDM-055 L2/R2 would only go to 20% and the calibration Tool wasn't changing the values.

On the left is the original Rubber for both L2/R2 and on the right the one I replaced them with. They aren't the same size so I had to trim them to shape using scissors. These rubbers worked perfect and was able to regain 100% on both triggers. I guess they have different carbon conductivity which is also visible when looking at them side by side. I know it's not a perfect solution to proper calibration but it's a good enough workaround I guess.


Replace podcast icon with Amazon logo

As mentioned in #108.

@juliaferraioli @amcasari @perriefidelis
Could one of you take a look at my pull request? Thanks.

Let's try this again...
@all-contributors, please add @WebSnke for coding contributions!


VIM - addition to Visual mode

Selection to matching parenthesis
v% if the cursor is on the starting/ending parenthesis
Selection to matching curly brace
vi{
Select text between quotes:
vi" for double quotes
vi' for single quotes

Hello, do you have a moment to create a pull request for this?

I can't right now sorry :/

#70

@uncle9999 please stop spamming the issues


[IIIF-807] Add code style check to Travis CI

I figure we might as well try out black and see what we think.
I'd like to see the Travis build fail with the new build config, and then I'll add an additional commit with all Python files reformatted.

Black supports Python 3.6 and later, so I dropped the 3.5 check from our Travis build. I think this is fine, since our three primary users have confirmed to me that they're all on 3.7.


resampler: handle explicitly the case that in farmes less than out frames

Hmm are we running the tests on travis? I've just tried them locally and I am getting a failure.

Yeah, no testing in Windows, that can be deceiving ...

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7bed10d6a388605c4b47152aea21b4a6b1113fc


fine-tune code

Dear @adithya-s-k ,
Thanks for the great repo.
Do you have any plans to share a fine-tuning script on customized datasets?

Hey the project is built around Paligemma
Here are some refrences
https://ai.google.dev/gemma/docs/paligemma
https://huggingface.co/blog/paligemma
Finetuning guide:
https://github.com/NielsRogge/Transformers-Tutorials/blob/master/PaliGemma/Fine_tune_PaliGemma_for_image_>JSON.ipynb
Hope this helps

Hi @adithya-s-k ,
Thanks for your swift response!
I'll prepare my data as follows:

object detection dataset: https://huggingface.co/docs/datasets/en/image_dataset#object-detection
segmentation dataset: https://huggingface.co/docs/datasets/en/semantic_segmentation

Would you happen to have any suggested script to convert the bounding box and segmentation mask to tokens (that can be used in Paligemma)?


Stop testing on FreeBSD 12

FreeBSD 12.4 will be EoL at the end of the month.  Stop testing on it.  Also, update the 14.0 image to the official release.

There is a PR for it.

r+ once https://github.com/rust-lang/homu/pull/199 gets merged.

@bors r+

:pushpin: Commit 4e42b85b60a907a17e85148569bd52a4233245c2 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 4e42b85b60a907a17e85148569bd52a4233245c2 with merge add5f9becd87ba9df037375f38a698d3496860d9...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing add5f9becd87ba9df037375f38a698d3496860d9 to main...


corenlp.py CoreNLPServer throws TypeError exception

Hello,
Here's the code:
>>> s = nltk.parse.corenlp.CoreNLPServer(path_to_jar='/usr/local/share/stanford/stanford-corenlp-3.8.0.jar', path_to_models_jar='/usr/local/share/stanford/stanford-english-corenlp-2017-06-09-models.jar')
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    s = nltk.parse.corenlp.CoreNLPServer(path_to_jar='/usr/local/share/stanford/stanford-corenlp-3.8.0.jar', path_to_models_jar='/usr/local/share/stanford/stanford-english-corenlp-2017-06-09-models.jar')
  File "/Users/adiep/feedback-sentiment/.env/src/nltk/nltk/parse/corenlp.py", line 69, in __init__
    key=lambda model_name: re.match(self._JAR, model_name)
TypeError: '>' not supported between instances of 'NoneType' and 'NoneType'

The max function is throwing this exception.
I think what's happening is that key=lambda model_name: re.match(self._JAR, model_name) is returning NoneType because it didn't match anything. So it fills the list of NoneType and max fails to sort it. I found that self._JAR and model_name evaluated to the following:
>>> type(re.match(r'stanford-corenlp-(\d+)\.(\d+)\.(\d+)\.jar', '/usr/local/share/stanford/stanford-corenlp-3.8.0.jar'))
<class 'NoneType'>

Thanks,

Is the max function suppose to be feed filenames and not full paths?
I tried to pass CoreNLPServer the folder instead and nltk couldn't find it for some reason.

Hi,
i think so, what are jars?

Could you set the classpath env variable before starting the server:
os.environ['CLASSPATH'] = '/usr/local/share/stanford'

another solution could be:
os.environ['STANFORD_PARSER'] = '/usr/local/share/stanford'
os.environ['STANFORD_MODELS'] = '/usr/local/share/stanford'

in my local setup I set all three variables.

I added all three to my zsh and I am still running into the same issues.

Also, when I run tox tests, I see the same exact errors.

re.match is failing to match _JAR with the found jar files.
>>> import re
>>> s = nltk.parse.corenlp.CoreNLPServer()
['/usr/local/share/stanford/stanford-corenlp-3.8.0.jar', '/usr/local/share/stanford/stanford-corenlp-3.8.0.jar']
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    s = nltk.parse.corenlp.CoreNLPServer()
  File "/Users/adiep/feedback-sentiment/.env/src/nltk/nltk/parse/corenlp.py", line 70, in __init__
    key=lambda model_name: re.match(self._JAR, model_name)
TypeError: '>' not supported between instances of 'NoneType' and 'NoneType'
>>> jar = '/usr/local/share/stanford/stanford-corenlp-3.8.0.jar'
>>> r_jar = nltk.parse.corenlp.CoreNLPServer._JAR
>>> re.match(r_jar, jar)
>>>

Seems like what happening is that re.match is being feed the full path, it searches for the jar file at the beginning of the string, and always fails. I think it is suppose to be feed just the names of the jar files.

Alright the fix is pretty simple.
I changed re.match(...) to re.search(...).group() so instead of it only looking at the start of the string, it looks everywhere.

Ran into another issue.
I think this is connected to issue I had before with CoreNLPParse using the proxy server.
>>> s = nltk.parse.corenlp.CoreNLPServer()
>>> s.url
'http://localhost:9000'
>>> s.start()
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    s.start()
  File "/Users/adiep/feedback-sentiment/.env/src/nltk/nltk/parse/corenlp.py", line 149, in start
    'Could not connect to the server.'
nltk.parse.corenlp.CoreNLPServerError: Could not connect to the server.

Ok, so it was the proxy problem. I found that you can set NO_PROXY='localhost'.
Now I have the problem with the server refusing connects.
I am not sure why, but when I init the server object, it starts a server at port 9000.
>>> s = nltk.parse.corenlp.CoreNLPServer(verbose=True)
[Found stanford-corenlp-(\d+)\.(\d+)\.(\d+)\.jar: /usr/local/share/stanford/stanford-corenlp-3.8.0.jar]
[Found stanford-corenlp-(\d+)\.(\d+)\.(\d+)\.jar: /usr/local/share/stanford/stanford-corenlp-3.8.0.jar]
[Found stanford-corenlp-(\d+)\.(\d+)\.(\d+)-models\.jar: /usr/local/share/stanford/stanford-corenlp-3.8.0-models.jar]
>>> s.start()
[Found java: /usr/bin/java]
[Found java: /usr/bin/java]
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c812b0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c814a8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c9c160>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c9c2e8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10368f5f8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c30160>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c81908>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c81400>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab8d0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab6a0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c9c898>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105c9cd68>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cb34a8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cb3438>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cb3ba8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cabc50>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab400>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab8d0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab940>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105d00e48>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cb30b8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105caba58>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cabc50>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cfee10>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cfe828>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105d004a8>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105d00fd0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105d090f0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cfe7f0>: Failed to establish a new connection: [Errno 61] Connection refused',))
HTTPConnectionPool(host='localhost', port=59023): Max retries exceeded with url: /live (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x105cab780>: Failed to establish a new connection: [Errno 61] Connection refused',))
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    s.start()
  File "/Users/adiep/feedback-sentiment/.env/src/nltk/nltk/parse/corenlp.py", line 150, in start
    'Could not connect to the server.'
nltk.parse.corenlp.CoreNLPServerError: Could not connect to the server.

Good lord, now it's working.
So overall, I had to change re.match to re.search.group and kill a floating corenlpserver in the background.
Maybe there should be some code to detect if there is other corenlpservers running? Don't know if it's even worth doing.

Seems like if you don't use with clauses, create servers objects, and don't stop them, python deletes the object but not the actual server. What I was doing is that I was starting servers in my interpreter and forgetting to run s.stop().

Seems like if you don't use with clauses, create servers objects, and don't stop them, python deletes the object but not the actual server. What I was doing is that I was starting servers in my interpreter and forgetting to run s.stop().

We need to somehow document how the Stanford CoreNLP API works so that we tell people not to start the server inside Python.
Alternatively, I think if we use the __all__ trick, maybe we can allow limited access to what's inside the nltk.parse.corenlp and prevent users from access the CoreNLPServer. The lowest level object that a user should use is GenericCoreNLPParser.
BTW, @dimazest is the CoreNLPServer use only for the test environment?

Yes, it's used only in tests.

Hello - I think I am having an issue related to the one noted here.
I recently started using this package and am using the StanfordNERTagger, which returns a deprecation error.
/usr/local/lib/python2.7/dist-packages/nltk/tag/stanford.py:183: DeprecationWarning:
The StanfordTokenizer will be deprecated in version 3.2.5.
Please use nltk.tag.corenlp.CoreNLPPOSTagger or nltk.tag.corenlp.CoreNLPNERTagger instead.

Note that I think there is a typo in this warning. I had to import from nltk.tag.stanford to find the CoreNLPNERTagger.
So I've attempted to switch to the new function and I cannot seem to get it to work.
Previously I had:
    stanfordClassifier = '/root/stanford-ner-2017-06-09/classifiers/english.muc.7class.distsim.crf.ser.gz'
    stanfordNerPath = '/root/stanford-ner-2017-06-09/stanford-ner.jar'
    st = StanfordNERTagger(stanfordClassifier, stanfordNerPath, encoding='utf8')
    tokens = nltk.tokenize.word_tokenize(text)
    ner_tags = st.tag(tokens)

Which I have now changed to
    stanfordClassifier = '/root/stanford-ner-2017-06-09/classifiers/english.muc.7class.distsim.crf.ser.gz'
    stanfordNerPath = '/root/stanford-ner-2017-06-09/stanford-ner.jar'
    with CoreNLPServer(stanfordNerPath, stanfordClassifier) as server:
        st = CoreNLPNERTagger(url=server.url)
        tokens = nltk.tokenize.word_tokenize(text)
        ner_tags = st.tag(tokens)

However, this code returns this error: CoreNLPServerError: Could not connect to the server.
I can't find documentation anywhere for how I am supposed to call CoreNLPNERTagger and how that call differs from the deprecated StanfordNERTagger.
Any help is much appreciated. Thanks!

Hi, I'm sorry that there is no documentation. The API has changed, here are is what you need to do. Refer to #1510, it contains a long discussion on how to start a server.
The main change: NLTK does not start CoreNLP server, you need to start it.  Refer to https://stanfordnlp.github.io/CoreNLP/corenlp-server.html for a detailed explanation, but the command should be something like:
# Run the server using all jars in the current directory (e.g., the CoreNLP home directory)
java -mx4g -cp "*" edu.stanford.nlp.pipeline.StanfordCoreNLPServer -port 9000 -timeout 15000

Open http://localhost:9000/ to make sure that the server is running.
Now you are ready to use NLTK corenlp client:
tagger = CoreNLPNERTagger(url='http://localhost:9000')
tokens = tagger.tag(text)

Please let me know if it works.

Yes! This works. Thank you very much for the help.

Thanks @dimazest, @alvations

For some reason, I can't connect to the server. Can anyone help me out? Here's the code I'm running.
from nltk.parse.corenlp import CoreNLPServer
server = CoreNLPServer("stanford-corenlp-4.0.0.jar","stanford-corenlp-4.0.0-models.jar",verbose=True)
server.start()
from nltk.parse.corenlpnltk.pa import CoreNLPParser
parser = CoreNLPParser()
parse = next(parser.raw_parse("I put the book in the box on the table."))
server.stop()
I am running it in a file inside the folder that I downloaded for CoreNLP so that I don't have to worry about abs paths or anything.
Here's what it outputs:
[Found java: /usr/bin/java]
[Found java: /usr/bin/java]
Traceback (most recent call last):
File "/Users/benstevens/Desktop/Bernstein2/Ben/stanford-corenlp-4.0.0/BenTest.py", line 4, in
server.start()
File "/Users/benstevens/Library/Python/3.8/lib/python/site-packages/nltk/parse/corenlp.py", line 153, in start
raise CoreNLPServerError("Could not connect to the server.")
nltk.parse.corenlp.CoreNLPServerError: Could not connect to the server.
I would greatly appreciate any help.


deprioritize unreconcilable missingPvtData

Type of change

New feature

Description
When a private data associated with a transaction is missing (i.e, the peer could not fetch it from other members during the commit time), the missing data info is recorded in the pvtdata store rather than stalling the block commit. A pvtdata reconciler task is to periodically try to fetch these missing private data. When the reconciler is not able to fetch a particular private data, it is necessary to deprioritize that missing private data so that the reconciler can fetch other missing private data rather than stalling the whole process by continuously retrying the same missing data.
This PR enables differentiation of prioritized and deprioritized missing data.
Additional details
This feature is necessary for the peer that bootstraps a channel using a snapshot. As the private is not dumped to a file, the new peer will use a reconciler to fetch the required private data. If a certain set of missing data could not be fetched, then the reconciler will get into a loop and does not progress further in a rare situation.

I am yet to look at the test files. However, I have a few comments on the regular files.
In addition to the comments, I would like to mention that we should avoid major refactoring and adding new code together in a single PR. We discussed this before. In this PR, diffs hardly make any sense. Renaming/splitting into different functions/moving across files gets easier reviewed in isolation.. particularly, when it is desired to back port.

Sorry about that. I went through multiple iterations and it resulted in a lot of refactoring though it was not intentional. I also couldn't push only refactoring PR because only with the new feature and the name I had chosen made sense. Otherwise, it didn't. In other words, the existing code looked right to me without deprioritizedList and hence didn't require refactoring. Anyway, I should have added multiple commits for the ease of review. I will keep this in mind for the next time.

Thanks @cendhu for your patience on this one. Adding the Jira for reference - https://jira.hyperledger.org/browse/FAB-15810

Thanks, Manish, for the merge. As long as the code looks good at the end, no issue in iterating the code as many times as possible (even if we lose the patience in-between 😄).


Window (app) without dock icon not recognised

For image preview I use macfeh. I found annoying when app opens every time icon in dock like normal application (I wanted behaviour like terminal application). So I disable it via editing Info.plist :
	<key>LSUIElement</key>
	<true/>

I added this to Info.plist. However after opening image, chunwm ignores opened window.
This is definitely not critical issue, I just found it strange.

Same as #108


Introduce the ContainerdRegistryHostsDir feature gate

How to categorize this PR?

/area cost
/kind enhancement
What this PR does / why we need it:
Currently there are two configuration patterns for configuring containerd registries. As part of https://github.com/gardener/gardener-extension-registry-cache/issues/3, for the registry-cache extension we decided to use the new and recommended configuration pattern - hosts directory pattern.
Only one of the configuration patterns has to be followed strictly. In order to realise the hosts directory pattern in the registry-cache, we have to adapt registry config contributed by provider-local to be in hosts directory pattern.
We decided gardenlet (containerd-initializer unit's script) to take over to create the /etc/containerd/certs.d dir and to add the following config to containerd's config.toml:
[plugins."io.containerd.grpc.v1.cri".registry]
   config_path = "/etc/containerd/certs.d"

Providing such config should be okay for Shoots that don't want to configure containerd registries and should not have any side effects.
The motivation to introduce this handling in gardenlet (containerd-initializer unit's script):

Expose the containerd registry configuration as feature (similar to the containerd's import feature). End users need to created only dir and hosts.toml file under /etc/containerd/certs.d to configure containerd registries.
Make it easier for extensions (provider-local and gardener-extension-registry-cache) to contribute registry config. With this feature, such extensions only have to mutate the OperatingSystemConfig resource and add the corresponding config files there. And they don't need to add systemd units that append/remove containerd config.

Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener-extension-registry-cache/issues/3
Special notes for your reviewer:
N/A
Release note:

A new feature gate named `ContainerdRegistryHostsDir` is introduced to gardenlet. When enabled, the `/etc/containerd/certs.d` directory is created on the Node and containerd is configured to look up for registries/mirrors configuration in this directory (if there is any configuration applied). In future, the [registry-cache extension](https://github.com/gardener/gardener-extension-registry-cache/) will add such registries/mirrors configuration under this directory (via OperatingSystemConfig mutation).

For some reason, tide is executed on this PR. /cc @oliver-goetz

/hold
I noticed one issue

/unhold
the above-mentioned issue is now resolved

/lgtm
/retest

/lgtm

I updated the feature gate's version to v1.77.0 as https://github.com/gardener/gardener/pull/8267 got merged meanwhile.

/lgtm


Link in README.md is not available

Problem
I got a 404 error when I tried to visit to Manual page in Document from the README link.
And https://xorm.io/en/ is also unavailable, that loop redirecting.

It has been fixed. Thanks for your report.


5 day forecast is now 10 days

The 5 day forecast is now 10 days.
Anyway to change it back?

If you only want to display five days, you can either specifically display each day or on the loop just stop after five days.


build error on Ubuntu 16.04:

Dear flexcore developers,
I just noticed a build error on Ubuntu 16.04:

In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:8:
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/clock.hpp:11:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/atomic:185:7: error: exception specification of explicitly defaulted default constructor does not match the calculated one
      atomic() noexcept = default;
      ^
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:16:26: note: in instantiation of template class 'std::atomic > > >' requested here
                virtual_clock::system::current_time((
                                       ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:8:
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/clock.hpp:11:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/atomic:185:7: error: exception specification of explicitly defaulted default constructor does not match the calculated one
      atomic() noexcept = default;
      ^
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:20:26: note: in instantiation of template class 'std::atomic > > >' requested here
                virtual_clock::steady::current_time((
                                       ^
2 errors generated.

This is with clang-3.8, but using Ubuntu's gcc-5.4 yields a related problem:

/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp: In instantiation of ‘fc::thread::cycle_control::cycle_control(std::unique_ptr):: [with auto:1 = fc::thread::periodic_task]’:
/usr/include/c++/5/type_traits:2346:26:   required by substitution of ‘template static std::__success_type()((declval<_Args>)()...))> std::__result_of_other_impl::_S_test(int) [with _Fn = fc::thread::cycle_control::cycle_control(std::unique_ptr)::; _Args = {fc::thread::periodic_task&}]’
/usr/include/c++/5/type_traits:2357:55:   required from ‘struct std::__result_of_impl)::, fc::thread::periodic_task&>’
/usr/include/c++/5/type_traits:2361:12:   required from ‘class std::result_of)::(fc::thread::periodic_task&)>’
/usr/include/c++/5/functional:2053:9:   required by substitution of ‘template std::function<_Res(_ArgTypes ...)>::function(_Functor) [with _Functor = fc::thread::cycle_control::cycle_control(std::unique_ptr)::;  = void;  = ]’
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:179:70:   required from ‘fc::thread::cycle_control::cycle_control(std::unique_ptr, ErrorFun) [with ErrorFun = fc::thread::cycle_control::cycle_control(std::unique_ptr)::]’
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:22:   required from here
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:21: error: cannot call member function ‘bool fc::thread::cycle_control::store_exception(fc::thread::periodic_task&)’ without object
                     })
                     ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:1:0:
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp: In instantiation of ‘fc::thread::cycle_control::cycle_control(std::unique_ptr, ErrorFun) [with ErrorFun = fc::thread::cycle_control::cycle_control(std::unique_ptr)::]’:
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:22:   required from here
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:179:70: error: no matching function for call to ‘std::function::function(std::remove_reference)::&>::type)’
     : scheduler_(std::move(scheduler)), error_callback(std::move(err))
                                                                      ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/scheduler.hpp:4:0,
                 from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:5,
                 from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:1:
/usr/include/c++/5/functional:2054:2: note: candidate: template std::function<_Res(_ArgTypes ...)>::function(_Functor)
  function(_Functor);
  ^
/usr/include/c++/5/functional:2054:2: note:   template argument deduction/substitution failed:
/usr/include/c++/5/functional:2028:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function(std::function<_Res(_ArgTypes ...)>&&) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
       function(function&& __x) : _Function_base()
       ^
/usr/include/c++/5/functional:2028:7: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘std::function&&’
/usr/include/c++/5/functional:2232:5: note: candidate: std::function<_Res(_ArgTypes ...)>::function(const std::function<_Res(_ArgTypes ...)>&) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
     function<_Res(_ArgTypes...)>::
     ^
/usr/include/c++/5/functional:2232:5: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘const std::function&’
/usr/include/c++/5/functional:2008:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function(std::nullptr_t) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}; std::nullptr_t = std::nullptr_t]
       function(nullptr_t) noexcept
       ^
/usr/include/c++/5/functional:2008:7: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘std::nullptr_t’
/usr/include/c++/5/functional:2001:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function() [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
       function() noexcept
       ^
/usr/include/c++/5/functional:2001:7: note:   candidate expects 0 arguments, 1 provided

Can you reproduce it at your end?

These are known issues. The second one is (I believe) gcc bug 67274, to fix it cyclecontrol.cpp:21 should be changed to this->store_exception(...). The first one is fixed by building against libc++ (-stdlib=libc++) when compiling with clang.

We are currently preparing to push changes from a company internal repository to upstream.
These should fix the gcc issue as they include major improvements of the cyclecontrol code.


feat: Add support for AWS ECS Exec

Adds support for AWS ECS Exec allowing for interactive sessions and
command execution inside a container. Useful to support triage and
debug.
https://aws.amazon.com/blogs/containers/new-using-amazon-ecs-exec-access-your-containers-fargate-ec2/

Thanks!
v2.42.0 has been just released.


VariableLength Code transmitting but not receiving

Hi, I uploaded the example code for Simple RxTx on two transceivers for 915 MHz, one is connected to an Arduino nano and the other one to UNO using a logic level converter. Everything works properly with the fixed length example code, however when I try the variable length code, I am able to transmit from one transceiver but nothing is seen on the other end.
I also tried to activate the debug mode on one end but I don't receive any additional information regarding the receiving part.
I put a serial print right after the zeta.available() function, but it never goes past it. I'm not able to understand why there is such a difference from the fixed data package to the variable one.
P.S. I am testing the two transceivers without antennas as of now, it's not meant to but I just wanted to get everything right before soldering an antenna.

Hello,
What code are you using with the variable length config?

I’m using the example code for simplerxtx with variable length

You mean the example "SimpleRxTxVariableLength", not "SimpleRxTx" modified with a variable length config, right?
Did you make sure both Arduinos run the same example code, on the same channel?

Hi, yes I meant SimpleRxTxVariableLength. I didn't have my laptop with me so couldn't check straight away. But yeah I reuploaded the code to both devices again and can't see any data package received on the other end. The channel is number 4, the one present by default.

Ok, I found the issue. Inspecting the commit history, seems like I messed up a bit with the big update for the Si4463 and mixed up some code. I mainly use the Si4463 modules so I didn't caught that.
Before I commit and push a fix, please try this fix to confirm it's working:
In ezradio_si4455.hpp, line 312, replace the following method: (basically it's 'length+1' instead of 0)
    void startVariableLengthTx(uint8_t channel, uint16_t length, RadioState stateWhenTxComplete)
    {
        startTx(channel, length+1, stateWhenTxComplete);
    }

Definitely working on my side. I pushed corrections, please update your library with the current master branch and try again. If still not working, switch back to fixed-length with the SimpleRxTx example to confirm it's still working as before.

Got it!! I updated the library and noticed a mistake in my previous code. I was using
ZetaRf915<ZetaRf::nSEL<10>, ZetaRf::SDN<4>, ZetaRf::nIRQ<2>> zeta;
to initialize the Arduino Uno, but I didn't notice that the initialization for variable length was different. Now it works perfectly.
Thank you so much!

Great! :)


Viewport denoising support

It would be awesome to get denoising in blender viewport... Is it something doable ? Is the project is still in developement ?

The project is still being developed. Right now, I am doing a lot behind the scenes, like rendering to create a larger dataset and experimenting with neural network architectures, as well as learning about the Blender code base.
Denoising in the viewport is on my TODO list! I am closing the report as it is not an issue, but a feature request.


Decrypt exception when calling a model with $with

I am trying to eager load a certain model with encrypted fields, however it throws an error saying "Invalid Payload".
More information here :
http://stackoverflow.com/questions/38491694/decrypt-exception-when-calling-a-model-with-with

Can't replicate.


Tag split during indexing

Discuss and implement how tags are collected and added to splits during indexing.

@fulmicoton @guilload I am thinking this should be handled as we do for the timestamp field. That is in the index config, we specify fields that should be used to collect the tags during indexing the same way we keep track of split time range.
{
    "store_source": true,
    "default_search_fields": ["body", "severity_text"],
    "timestamp_field": "timestamp",
    "tag_fields": ["device", "city", "tenant"],
    "field_mappings": [ ]
}

somewhere in the split  update_metada during indexing, we fetch the tag values and add to a HashSet of tags.
I think this way we don't even need to store it in the index.

I am ok with the IndexConfig, but I think it might be easier to populate them in the packaging phase.
It will also be easier to recycle the function when we delete documents.
We would open the index, open the TermDictionary, and get the terms out of it.


improved error handling within admin application

Signed-off-by: barinek<EMAIL_ADDRESS>Fixes #135
Fixes #174

Codecov Report

Merging #200 (4cd0815) into main (8d8932b) will decrease coverage by 0.38%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   91.79%   91.41%   -0.39%
==========================================
  Files          38       38
  Lines        1658     1666       +8
==========================================
+ Hits         1522     1523       +1
- Misses         91       96       +5
- Partials       45       47       +2

Impacted Files
Coverage Δ

pkg/admin/orchestrator_client.go
87.91% <78.94%> (-7.70%)
:arrow_down:

pkg/admin/applications.go
100.00% <100.00%> (ø)

pkg/orchestrator/applications_gateway.go
94.11% <100.00%> (ø)

pkg/orchestrator/applications_handler.go
89.38% <100.00%> (ø)

pkg/orchestrator/integrations_gateway.go
92.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8932b...4cd0815. Read the comment docs.


How to handle imbalanced data?

What are the various ways to handle the imbalanced datasets?
One of them is multiplying rare classes, but are there other ways?

The main ideas are:

undersampling - discarding the excess dominating class instances,
ensembling - combining models trained on balanced subsamples of the dataset,
weighting classes - providing class weights to a model during learning (some scikit-learn models take parameter "balanced" as class_weight - it handles balancing by itself)
oversampling - adding extra instances of the minor class either by multiplying the instances or generating other with SMOTE or ADASYN algorithm.

The issue has been discussed in details during a team meeting with @poitrek and @marcpar141. Due to that fact, I am closing the issue.


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
What is "FlogNetwork" for? "value" what is the limit? Please explain!

It's for Bloxstrap Rich Presence related features

FLogNetwork is used to enable verbose logging for network stuff, since activity watching works by reading those logs.


Injective - Error while listening to transaction stream

Describe the bug
When testing a new feature on injective on a different pull request, we encounter this error that also happened on development branch.
2024-01-31 10:44:52,715 - 6250 - hummingbot.connector.derivative.injective_v2_perpetual.injective_v2_perpetual_derivative.InjectiveV2PerpetualDerivative - INFO - Leverage for INJ-USDT successfully set to 5.
2024-01-31 10:44:54,226 - 6250 - hummingbot.connector.derivative.injective_v2_perpetual.injective_v2_perpetual_derivative.InjectiveV2PerpetualDerivative - INFO - Network status has changed to NetworkStatus.CONNECTED. Starting networking...
2024-01-31 10:44:56,117 - 6250 - hummingbot.core.data_type.order_book_tracker - INFO - Initialized order book for INJ-USDT. 1/1 completed.
2024-01-31 10:44:57,921 - 6250 - hummingbot.connector.exchange.injective_v2.data_sources.injective_grantee_data_source.InjectiveGranteeDataSource - WARNING - Error while listening to transaction stream (<AioRpcError of RPC that terminated with:
	status = StatusCode.UNAVAILABLE
	details = "Received http2 header with status: 503"
	debug_error_string = "UNKNOWN:Error received from peer  {created_time:"2024-01-31T10:44:57.919275+08:00", grpc_status:14, grpc_message:"Received http2 header with status: 503"}"
>)

Tried to delegate the account to check if related but still same error
Tried to run tests on local and cloud server, getting same error

Steps to reproduce

Add injective_v2 spot and perpetual on mainnet
Setup simple perp-mm or pure-mm strategy
Start the strategy and observe connector behavior

Release version
dev-1.25.0
Type of installation
Source
Attach required files
logs_perp-inj-simulated.log

Hello @rapcmia. There is nothing in the code you can do to stop this "issue" (it is not an issue really) from happening, except stop logging the event.
The error is related to the public nodes not being able to accept requests because of the load they are under. This should not happen if the connector is used with a private node (that we encourage all users to run really)

Hi @aarmoa thanks for the info regarding the error. We shall close this issue ticket and note this related to public node limitation 🙏🏼


Double check "Spectroscopy" transit times from scanning law code

It turns out that the scanninglaw package does predict RVS times. Are these closer to rv_nb_transits than what I was seeing from GOST?

This doesn't actually work (it crashes scanninglaw) and looking closer at the source suggests that this won't actually do what we want.


reformat: ignore opam-switches [develop]

Counterpart of https://github.com/MinaProtocol/mina/pull/16115/. It will be to build the develop version of https://github.com/MinaProtocol/mina/pull/16117
Explain your changes:
*
Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me


[Feature Request] Support for black in Jupyter Notebooks

Hello 👋,
First of all thanks for your hard work for bringing black to VSCode. My autoformatting has become so much more seamless now that I don't need to worry about having it installed in all of my envs/projects.
I was wondering whether you have looked into (apologies if this has been asked before - I did a quick scan but didn't find anything) enabling the use of black in jupyter notebooks. The isort plugin for VSCode has done this and black do mention in their docs that it can be enabled by pip installing black[jupyter] (https://black.readthedocs.io/en/stable/getting_started.html). Perhaps this could be a user enabled feature if it is not desired to have this by default? :)

@vancromy We currently support formatting individual python cells in a notebook. Since the Language Server Protocol (v3.16) treats each cell as a document. To support the document as a whole, we will need to upgrade to LSP v3.17 which allows us to look at notebooks as a whole document. Currently there is a technical limitation because the library that we use (pygls) is still on v3.16 of LSP. Once that is upgraded this should be fairly easy to do and entirely in python. We are happy to take any PRs if the community wants to get to this before we do.

Apolgoes for the spam but I discovered the answer to my own question and thought it would help others to document it here. This can be achieved either via right-clicking on the cell and selecting "Format Cell" or by using the dedicated shortcut for that control (via the Control Palette or keyboard shortcut).

Sorry for spam; as the other issue was closed in the favour of this one, are there any progress with leaving the semi-colon in jupyter notebooks? It keeps to be removed

@danieltomasz pygls merged the notebook support last week. Waiting for a release to start work on this.

Maybe it psf/black#4025 it relevant about dealing with notebook syntax from hydrogen .py files.


Log cleaning

Feature Request
Is your feature request related to a problem? Please describe:
It will cause disk space not to be freed.
Describe the feature you'd like:
Add automatic log cleaning.
Describe alternatives you've considered:
Can configure crontab to clean up the logs.
Teachability, Documentation, Adoption, Migration Strategy:

/cc @Hoverbear

@liubo0127 Definitely a legitimate request. :)
Since we're not logging to something like the systemd journal we need to worry about this.

From @iamxy
It is better for the users themselves to decide when to clean the log, so I will close this issue.


Add possible disable Security & Compliance section

what

Add possible disable Security & Compliance section

why

Somebody want use this tool and don't required Security & Compliance secion

references

Don't create issue

@Nuru can we process this MR ?

@ByJacob Sorry about the delay in getting to this.
We have about 100 modules that rebuild their README's every night, and when the README's change, that triggers a new release. Eventually we will clean that up so that (a) changes in whitespace only do not trigger updates and (b) updates to the README do not trigger new releases, but until then, any changes to the templates/README.md.gotmpl must produce exactly the same output or else we get 100 releases of whitespace changes, which we really do not want.
Also, disabling our branding is not something we are keen on spending time on, so I am going to close this as "wontfix". Feel free to use your own fork for this if you want to.


x/tools/gopls: gopls fails to resolve definition

What version of Go, VS Code & VS Code Go extension are you using?

go version

1.16.6

gopls -v version

0.7.1

code -v

1.59.0

version of the VS Code Go extension

0.27.1

Describe the bug
VSCode fails to resolve some type definitions when gopls is enabled.
The following error is printed on the gopls console output:
[Error - 11:19:32 AM] Request textDocument/definition failed.
  Message: no package for given file position
  Code: 0

Steps to reproduce the behavior:

Download and open project go-perun in VSCode.
Ensure that gopls is enabled.
Open file client/client_role_test.go.
On line 31, right click ctest.RoleSetup.
Select Go to Definition.

Expected behavior: The editor opens the location of the definition.
Actual behavior: The editor shows No definition for 'RoleSetup'.
Note: The type definition is resolved correctly when gopls is disabled.

Thanks @matthiasgeihs for the report with the repro case.
This looks like a bug introduced in<EMAIL_ADDRESS>A temporary workaround will be to downgrade<EMAIL_ADDRESS>:-(

I added a little debug logging. It looks like a mismatch in parse modes; the check at https://cs.opensource.google/go/x/tools/+/master:internal/lsp/source/util.go;l=300;drc=f8cfadacc87adf3dd49cc1c165eb4f70931fc6fe is failing for both packages returned by PackagesForFile. I suspect https://golang.org/cl/333689 but didn't verify.

@matthiasgeihs thanks very much for the report, especially with the repro.

It looks like a mismatch in parse modes;

This problem was actually that this particular package is imported as an intermediate test variant, which we had started filtering out. As a result, we couldn't find a package for the object position. CL 347563 contains a fix.


Text being moved when converting into .py file

Some buttons, text not being converted how it supposed to, its just moving out from screen. (sorry for bad english)

Same issue

Why did this issue get closed? The problem still persists.


Migrate to React/Angular Web Framework

Looking into the work require to move to using a framework like React/Angular. These frameworks are single page applications in the sense that they have a root html page that is continuously modified.
Current web infrastructure:
We use Sinatra to serve static html web pages that have been generated through ERB. So every request we make to the current server will return a static html page that will be displayed to the user.
Work required:
Because Angular/React are single page frameworks, there needs to be 2 servers: one that hosts the web server and one that serves data to web server.
I would imagine that this would require us to have Sinatra only return json data and then having a simple web server to host the Angular/React web app.
Pros:

Separation of concern between Frontend and backend
Can re-use components made by others in the community
Frameworks help out a lot, productivity-wise
JS/TS ❤

Cons:

Some initial work required
Users might have to worry about scalability for their web and data servers instead of just one

Adding @taquitos to this also. Background information: In the beginning we decided to server HTML vs JSON to speed up the initial development process

I think we should continue to explore single page webapps, but still go full steam ahead with our current design for MVP. Remembering that the M in MVP is Minimum 😄
It would be trivial to migrate off ERBs and into a single-page webapp. I just don't want to do that right now because then we'd be committing to building a client on top of the server, and having to handle all the complexities that come along with that.

@taquitos I agree. Though I think developing in a single page webapp would be significantly faster than ERBs, probably biased here since I don't know much about ERBs.

ERBs are just server-side html templates. Sprinkle some variables here and there, then call a method to generate the html, and then viola!

Alright, we decided this is the direction we want to go in, so a result, let's create smaller PRs/Issues as a result for the specific features and views 👍


⚠ Bofrost.be has degraded performance

In 6c3a09c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1589 ms

Resolved: Bofrost.be performance has improved in 4bba2a1.


Change News Sitemap date to published_date

Describe the bug
For the Google News sitemap section, shouldn't date be published_date? Reference here: https://developers.google.com/search/docs/crawling-indexing/sitemaps/news-sitemap
Expected behavior
date for news sitemap should be published_date

I see in the code, date is then used to produce publication_date


portainer 无法打开呢

http://name:9080
显示
500 Internal Privoxy Error
Privoxy encountered an error while processing your request:
Could not load template file no-server-data or one of its included components.
Please contact your proxy administrator.
If you are the proxy administrator, please put the required file(s)in the (confdir)/templates directory. The location of the (confdir) directory is specified in the main Privoxy config file. (It's typically the Privoxy install directory).

http://name:9080
显示
500 Internal Privoxy Error
Privoxy encountered an error while processing your request:
Could not load template file no-server-data or one of its included components.
Please contact your proxy administrator.
If you are the proxy administrator, please put the required file(s)in the (confdir)/templates directory. The location of the (confdir) directory is specified in the main Privoxy config file. (It's typically the Privoxy install directory).

用#docker ps --all 看一下portainer容器的状态 是否正常

3.脚本版本就是今天装的最新，os是Debian10， gcp上面

3.脚本版本就是今天装的最新，os是Debian10， gcp上面
还是无法打开portainer

#systemctl stop firewalld
#lsof -i
#systemctl restart docker
然后再试试


Improve s:run_scene

Currently on Linux is not possible to run command async without plugins. xdg-open allows to open files or URL's. & is not works in Vim. So, I just removed this check.
I also reworked launch a bit. What do you think about it?
Also I added support for Asyncrun. This plugin is very neat, it allow to output everything in a quickfix like in IDE in live:

P.S. I thinking about autosave feature. It would be nice to save all files automatically before running. What do you think? Should I put an option for autosave in this file too or in plugin folder?

no autosave pls, if it is needed it could be turned on for vim by a user.

I meant as an option, not enabled by default. Sush as g:godot_save_before_run.

I reworded first message a bit to make it more clear :)

doesn't work in wsl tmux:

Sorry, could you try again?

What is your coding style for braces? I see that you sometimes use double quotes, sometime single quotes.
As I know it generally preferable to use single quotes for all places where you don't need to escape anything and double-quotes when you need to escape something.

thx!

Hey @Shatur95, I've just added AsyncRun but I'm not sure what I need to do in order to be able to see it working as my output instead of using Godot's one. Did I need to do any other setup-step? I'm currently on Ubuntu 20.04.

@coelhucas, hi! No, it just should work.


Added mao's scanning actions from FINOS security scanning

/easycla

/easycla

@robmoffat - apparently spring-web-5.3.26.jar is affected by CVE-2016-1000027 , which states:

Pivotal Spring Framework through 5.3.16 suffers from a potential remote code execution (RCE) issue if used for Java deserialization of untrusted data. Depending on how the library is implemented within a product, this issue may or not occur, and authentication may be required. NOTE: the vendor's position is that untrusted data is not an intended use case. The product's behavior will not be changed because some users rely on deserialization of trusted data.

If you don't use spring-web for deserialization of untrusted data (that is, data that is manually entered), I'd suggest to add this to allow-list.xml with a note that explains why the CVE can be safely ignored; see https://nvd.nist.gov/vuln/detail/cve-2016-1000027


Meeting Notes: 2020-08-24

Signed-off-by: JT Nelson<EMAIL_ADDRESS>

Okay, yes, a manual git like --signoff can be done via only the Github Web UI by putting a "Signed-off-by: " as the last line in the comment.  It just passed the DCO bot test.   It has to be the exact name and email from the Github account that has the fork and the PR originated from.  I'll make note of this for future documentation reference.  Thanks : )


[CARBONDATA-4303] Columns mismatch when insert into table with static partition

Why is this PR needed?
When insert into table with static partition, source projects should not contain static partition column, target table will have all columns, the columns number comparison between source table and target table is: source table column number = target table column number - static partition column number.
What changes were proposed in this PR?
Before do the column number comparison, remove the static partition column from target table.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6047/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6080/

retest this please


The elevation angle of test dataset

Hi,
The elevation angle for all 7 objects in the test dataset is 0 right?
Thanks

The camera elevation angle is indeed 0.
But it is possible that I rotate some objects to make sure they fit the camera view. So maybe the relative elevation angle is not 0.
Sorry I can't remember the details.

Thanks


Add a new spec to project_spec

This PR adds a new spec to project_spec confirms that there is a newline at end of CHANGELOG.md file.
For example, run the test when there is no newline as follows.
% git diff
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3303f22e2..744f681b2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3493,4 +3493,4 @@
 [@kenman345]: https://github.com/kenman345
 [@nijikon]: https://github.com/nijikon
 [@mikeyhew]: https://github.com/mikeyhew
-[@kenman345]: https://github.com/kenman345
+[@kenman345]: https://github.com/kenman345
\ No newline at end of file

The test fails.
% rspec spec/project_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 65019
.F................

Failures:

  1) RuboCop Project changelog has newline at end of file
     Failure/Error: expect(changelog.end_with?("\n")).to be true

       expected true
            got false
     # ./spec/project_spec.rb:100:in `block (3 levels) in
            <top (required)>'

Finished in 1.42 seconds (files took 2.65 seconds to load)
18 examples, 1 failure

Failed examples:

rspec ./spec/project_spec.rb:99 # RuboCop Project changelog has newline at end of file

With this change, newline of CHANGELOG.md will not be mixed with another commit, and the difference of the individual commit will be clarified.
Refer: https://github.com/rubocop-hq/rubocop/pull/6114/files

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

That is a good idea! Duplication was actually found by adding the following test. And I removed the duplication of the backwards discovered.
rubocop-hq/rubocop@9a0dfbf

There was one duplication about change history entry, but since it can not be clearly judged, it is not change this time. (e.g. * [#4241](https://github.com...)
So, only validation of the contributor name who obviously does not need duplication is targeted in this PR.

Nicely done!


Build fail on Xcode 12 beta 2

When trying to build I get the following error in Promise+Recover.swift:
Cannot convert value of type 'Promise<Void>' to closure result type()'

It works fine on Xcode 11.5.
Version 1.2.1

2.0.3 is now available with fixes. Thanks.

This problem still exists in version 2.0.5

This problem still exists in version 2.0.5


Add is_distributed

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d65432e) to head (7716353).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           65        67    +2
  Lines         1411      1419    +8
  Branches       151       151
=========================================
+ Hits          1411      1419    +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Coverage report not generated

Hi,
I just installed OpenCover and AxoCover in VS2017 Professional and I can not get the Coverage report to generate. The tests all execute successfully, but the coverage report never gets generated.
This is the output in the console:
<< Executor finished.
| File redirection rules are cleared.
< Test execution finished.
Shutting down...
Exiting...
Generating coverage report...
Committing...
No results, this could be for a number of reasons. The most common reasons are:
    1) missing PDBs for the assemblies that match the filter please review the
    output file and refer to the Usage guide (Usage.rtf) about filters.
    2) the profiler may not be registered correctly, please refer to the Usage
    guide and the -register switch.
Test execution finished.

The coverage reports are empty:
<?xml version="1.0" encoding="utf-8"?>
<CoverageSession xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Version="<IP_ADDRESS>">
  <Summary numSequencePoints="0" visitedSequencePoints="0" numBranchPoints="0" visitedBranchPoints="0" sequenceCoverage="0" branchCoverage="0" maxCyclomaticComplexity="0" minCyclomaticComplexity="0" maxCrapScore="0" minCrapScore="0" visitedClasses="0" numClasses="0" visitedMethods="0" numMethods="0" />
  <Modules />
</CoverageSession>

Project is built as x86 Debug mode.
Tests:

Coverage report page:

.settings file
{
  "TestRunner": "",
  "TestPlatform": "x86",
  "TestApartmentState": "STA",
  "TestAdapterMode": "Standard",
  "IsRedirectingFrameworkAssemblies": true,
  "TestSettings": "..\\AppOSTest\\default.runSettings",
  "ExcludeAttributes": "System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute",
  "ExcludeFiles": "",
  "ExcludeDirectories": "",
  "Filters": "+[*]*",
  "IsIncludingSolutionAssemblies": true,
  "IsExcludingTestAssemblies": false,
  "IsCoveringByTest": true,
  "IsMergingByHash": true,
  "IsSkippingAutoProps": true,
  "IsVisitorCountLimited": false,
  "VisitorCountLimit": 10
}

Is there something else I need to for this to work?
Edit: Added .settings file
Edit2: Successfully generated OpenCover report using the command line. I just need to specify -filter and -register. Where can I do this with AxoCover?

I have this exact same issue.
Any ideas?

I had same issue and below solution from the owner worked for me
https://github.com/axodox/AxoCover/issues/172#issuecomment-406562661
Go to the directory where AxoCover is installed. You can locate this by running a long test (e.g. thread sleep, and open the file location of the AxoCover.Host-*.exe from the task manager. For example for me it is: C:\Users\axodo\AppData\Local\Microsoft\VisualStudio\15.0_6d93d79f\Extensions\pfu3q5ow.kny
Then navigate to OpenCover\x86 or x64 depending on what platform your tests are running
Open CMD with admin right
Enter: regsvr32 /i OpenCover.Profiler.dll
You will get a dialog that DLL is registered.

I have the same issue but this solution doesn't work for me, what I have test is that passing -register to opencover works fine, ¿is there any way to pass this param to opencover.console.exe when it is called?:
https://github.com/axodox/AxoCover/issues/172#issuecomment-406562661
Go to the directory where AxoCover is installed. You can locate this by running a long test (e.g. thread sleep, and open the file location of the AxoCover.Host-*.exe from the task manager. For example for me it is: C:\Users\axodo\AppData\Local\Microsoft\VisualStudio\15.0_6d93d79f\Extensions\pfu3q5ow.kny
Then navigate to OpenCover\x86 or x64 depending on what platform your tests are running
Open CMD with admin right
Enter: regsvr32 /i OpenCover.Profiler.dll
You will get a dialog that DLL is registered

I have the same issue, and if apply the "registering dll solution" it works. But it works only if I don't change the configuration.
If I change from Debug to Release or vice-versa then I have to register the DLL again.
This is really odd.
Maybe it would be easier if I had the ability to pass the "-register" param to de opencover.console.exe when it is called.


Secure HTTP Proxy Server

I want to configure the proxy on one device and use it on another device in settings. How do I do this?
This is my code
`let ssAdapterFactory = SecureHTTPAdapterFactory(serverHost: "xxx.xxx", serverPort: 443, auth: HTTPAuthentication(username: username ?? "aaa", password: password ?? "aaa"))
    let directAdapterFactory = DirectAdapterFactory()

    var UserRules:[Rule] = []

    let chinaRule = CountryRule(countryCode: "CN", match: true, adapterFactory: directAdapterFactory)
    let unKnowLoc = CountryRule(countryCode: "--", match: true, adapterFactory: directAdapterFactory)
    let dnsFailRule = DNSFailRule(adapterFactory: ssAdapterFactory)
    let allRule = AllRule(adapterFactory: ssAdapterFactory)

    UserRules.append(contentsOf: [chinaRule,unKnowLoc,dnsFailRule,allRule])

    let manager = RuleManager(fromRules: UserRules, appendDirect: true)

    RuleManager.currentManager = manager

    let server = GCDHTTPProxyServer(address: IPAddress(fromString: "localhost"), port: Port(port: 8080))
    try! server.start()`

Hey,
Fixed by doing this:

Get local IP
Pass to Packet Tunnel
Create proxy server on Local IP instead on <IP_ADDRESS>
Add Local IP and Port on another device

Thanks


MSAL logout frame issue

After i do logout i get this screen saying frameloader null

@chinmayembedded Can you attach the fiddler trace for the above use case.

Sorry I cannot share the details with you.
Following are the methods used in my code -

The constructor called for B2C
clientApplication = new Msal.UserAgentApplication(
this.tenantConfig.clientID, this.authority,
function (errorDesc: any, token: any, error: any, tokenType: any) {
localStorage.setItem("accesstoken",token);
},
{
postLogoutRedirectUri: window.location.origin + '/login'
}
);
The B2C logout method
logout(): void {
this.clientApplication.logout();
};

Apart from this I am using MSAL 0.1.5 version.
The flow of the issue is -
Logout function called -> Frameloader numm issue -> login page as per the postLogoutRedirectUri

@chinmayembedded  Can you please confirm if this issue still exists?


fontspec is XeLaTeX and LuaLaTeX specific

The hint to add \usepackage{fontspec} to the LaTeX code is only recommented for XeLaTeX and LuaLaTeX

Current coverage is 93.82% (diff: 100%)

Merging #128 into master will not change coverage

@@             master       #128   diff @@
==========================================
  Files            11         11
  Lines           971        971
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            911        911
  Misses           60         60
  Partials          0          0

Powered by Codecov. Last update 54f64d4...064672b

With ,, this prints a tuple (complete with (, ,, )) and hence illegal LaTeX code. Better scratch the , or put it all in one line.

Now the code is correct and ends up looking like
\usepackage{fontspec}% This Line only for XeLaTeX and LuaLaTeX

I guess a space would be in order here.

Sorry for the error in the first commit, I have only tested it in python3.
Ok, now it should be correct.
You could also make this change in your code, this is maybe less work for you.
This PR was thought to be a suggestion (I forgot to write it)


Add new Jenkins workflow for build packer.

Description
Add new Jenkins workflow for packer build to create new ami.
Issues Resolved
https://github.com/opensearch-project/opensearch-ci/issues/258
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3368 (0318a84) into main (7cd2ad7) will decrease coverage by 0.29%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
- Coverage   91.74%   91.46%   -0.29%
==========================================
  Files         172      172
  Lines        4991     4991
==========================================
- Hits         4579     4565      -14
- Misses        412      426      +14

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Please add assertion test cases confirming what needs to be called.

Added the assertions for the commands being called.

We have confirmed all the amis can be built within 1 hr.


feat: add method to jsonx

Create a new method MarshalToString to jsonx

Don't use unsafe.

Can I use the string function directly


Pun line "nicht schlecht gespielt. ich sags wies Is." has issues

Wrong section
The punline is currently in section for meme constant "1" but describes a positive outcome. It should probably go in section "2".
Ends in period
This doesn't match with how the punlines are integrated into the message, as currently punlines are not supposed to be separate sentences.
Missing capitalization
Start of second sentence is not capitalized.

Line in quetsion


Skip corrupt image files correctly

Noticed that if I stop the capture process during the night that causes some empty files which then later crashed the keogram and startrail processes with OpenCV exception.  So skip those files and continue with the rest.

Good Timing Jarno! User Refrus came across this issue yesterday when his image #6 was corrupted and it stopped the keogram generation.

Yes, sorry about that, should have checked image loading in the first place. Could add some more sanity checks, but this probably covers the usual error situations.


Unable to use Jupyterlab Desktop with Alternative Python Installation

Request help on how to use Jupyterlab desktop v3.6.1-1 with Python10.5 and 3.11.1. I am using a Windows 10 laptop and have tried the direction in the installation guide without any success to get the app..

Does Jupyterlab Desktop bundle a python binary with it? So user don't need to install python.

@Imoh-mfon you can follow the instructions here to create a conda environment on your computer. After creating the environment, make sure to restart JupyterLab Desktop. If it was installed in common locations, the environment will be discovered otherwise you can select the environment (the path to python.exe in the environment directory) from the UI.
If you followed these steps, please share the error message you are receiving.
@linonetwo yes, JupyterLab Desktop bundles a Python environment and users are recommended to start with that environment.

Dear Mehmet,
Thank you so much for your time your guidance. It worked!
Many thanks,
Mark Idiong.
On Mon, Feb 13, 2023 at 4:39, Mehmet @.***> wrote:
@Imoh-mfon you can follow the instructions here to create a conda environment on your computer. After creating the environment, make sure to restart JupyterLab Desktop. If it was installed in common locations, the environment will be discovered otherwise you can select the environment (the path to python.exe in the environment directory) from the UI.
If you followed these steps, please share the error message you are receiving.
@linonetwo yes, JupyterLab Desktop bundles a Python environment and users are recommended to start with that environment.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Kirin Tor server is not listed when EU server is picked

(going through old bugs)
Probably an issue with server list from blizz being incorrect (server might have been offline at the time). If this recurs on updated versions of magicsim please reopen.


python310Packages.sensor-state-data: 2.1.2 -> 2.2.0

Description of changes
https://github.com/bluetooth-devices/sensor-state-data/blob/main/CHANGELOG.md#v220-2022-08-13

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 186700 run on x86_64-linux 1

21 packages built:

home-assistant-component-tests.govee_ble
home-assistant-component-tests.inkbird
home-assistant-component-tests.moat
home-assistant-component-tests.sensorpush
home-assistant-component-tests.xiaomi_ble
python310Packages.bluetooth-sensor-state-data
python310Packages.govee-ble
python310Packages.inkbird-ble
python310Packages.moat-ble
python310Packages.qingping-ble
python310Packages.sensor-state-data
python310Packages.sensorpush-ble
python310Packages.xiaomi-ble
python39Packages.bluetooth-sensor-state-data
python39Packages.govee-ble
python39Packages.inkbird-ble
python39Packages.moat-ble
python39Packages.qingping-ble
python39Packages.sensor-state-data
python39Packages.sensorpush-ble
python39Packages.xiaomi-ble


Add basic region_name validation

This PR will add some basic validation to the region_name parameter used to create new Session and BaseClient objects. The goal is to avoid accidentally setting up clients that will either never route, or lead to unexpected request routing. The change here will bubble up to boto3 in clients and resources, as well as the AWS CLI.

Codecov Report

Merging #2127 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2127      +/-   ##
===========================================
- Coverage    93.11%   93.10%   -0.02%
===========================================
  Files           60       60
  Lines        11104    11114      +10
===========================================
+ Hits         10340    10348       +8
- Misses         764      766       +2

Impacted Files
Coverage Δ

botocore/exceptions.py
99.45% <100.00%> (+<0.01%)
:arrow_up:

botocore/session.py
98.17% <100.00%> (+0.03%)
:arrow_up:

botocore/endpoint.py
98.03% <0.00%> (-0.66%)
:arrow_down:

botocore/credentials.py
98.54% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f425a...e15848c. Read the comment docs.

Seems fine, just had one small comment.


Bug-testing

I need to thoroughly run through the code to try to capture any malfunctions.

I have not been able to find any bugs, closing this tentatively until a bug arises.


Fix incorrect example link on Searching Commits

Why:

https://github.com/github/docs/issues/2318
What's being changed:

The example that says committer-date:>2016-01-01 matches commits committed after 2016-01-01. is having its URL match the description.
Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks so much for opening a PR! I'll get this triaged for review ✨


Document trajectory controller

trajectory modes: PAUSE, REWIND, ADD_SEGMENT, ROBOT_POSE

topics
all parameters:

sphere radius
look_ahead point
virtual point
virtual tracking point
position setpoint publisher
trajectory completion percentage

Completed


In Shell mode, cannot reset input language to "Detect Automatically"

using the shell option with trans -shell -brief, i cannot revert back to detecting languages automatically once i select 1 input language manually.
example (translating a dutch word):
nl: aardappel
potato

✅ correct translation
then if i want to translate another word from an unknown language, i would have to restart the shell completely or else it would incorrectly keep trying to translate only from NL:
:en 土豆
土豆

❌ can't translate; is still trying to use dutch as input instead of detecting chinese

Thanks for reporting the issue.
I've add a workaround for this. Now it should be possible to use the following command to explicitly set the source language back to auto:
:set sl auto


Switch to alloy-rpc-types-anvil types

Motivation
Closes: https://github.com/foundry-rs/foundry/issues/8084
TODO:

[x] Impl Default to NodeForkConfig: https://github.com/alloy-rs/alloy/pull/844
[ ] Bump alloy: https://github.com/foundry-rs/foundry/pull/8128
[ ] Format files

Solution

Hi @moricho, thanks for your PR! I've added you as a co-author here: https://github.com/foundry-rs/foundry/pull/8186
Closing this PR in favor for that one.

@zerosnacks Thanks for taking over this!


Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[ ] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Lisa Budzinski
On Thu, Jul 4, 2019, 8:50 AM Justin Kenyon<EMAIL_ADDRESS>wrote:

Closed #846 https://github.com/github/explore/pull/846.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/846?email_source=notifications&email_token=AHLLGCU4BC4JGDG4TNSBLNTP5XWZZA5CNFSM4H42AJ22YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSKUF3GQ#event-2460507546,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHLLGCRXBSZ5W3MGHMSBIIDP5XWZZANCNFSM4H42AJ2Q
.

Lisa Budzinski
On Wed, Jul 10, 2019, 9:36 PM Lisa Budzinski<EMAIL_ADDRESS>wrote:

Lisa Budzinski
On Thu, Jul 4, 2019, 8:50 AM Justin Kenyon<EMAIL_ADDRESS>wrote:

Closed #846 https://github.com/github/explore/pull/846.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/github/explore/pull/846?email_source=notifications&email_token=AHLLGCU4BC4JGDG4TNSBLNTP5XWZZA5CNFSM4H42AJ22YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSKUF3GQ#event-2460507546
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AHLLGCRXBSZ5W3MGHMSBIIDP5XWZZANCNFSM4H42AJ2Q
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/846?email_source=notifications&email_token=AHLLGCVGKXBVCED4R6G43XTP62FA3A5CNFSM4H42AJ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVG35Q#issuecomment-510291446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHLLGCV4D3CUNMU3ZG5FDKLP62FA3ANCNFSM4H42AJ2Q
.


Split invariant checks to hourly and daily

Context
Separate invariant checks to hourly and daily to avoid being flooded with sentry errors.
Moved outstanding references check and applications with course choices in the previous cycle to the daily check as they have been responsible for causing the most noise based on our sentry numbers.
Changes proposed in this pull request

Split up detect invariant check to hourly and daily
Update clock configuration

Link to Trello card
https://trello.com/c/j1yVJCpz/3871-split-invariant-checks-between-daily-and-hourly
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

I think we can move a few more of those out into the daily check, the ones related to applications maybe?


Render author avatar and settings menu

Render an author avatar (main codebase author with initials), which, when clicked, shows a settings pop over.
Without an author (on hub or a new codebase), a generic user icon should be displayed in place of the avatar.
The settings popover should include a theme setting for light/dark/system theming, which, when changed, is saved in localStorage.

This works on Share now. Would be cool to show this on Unison Local if logged in.


Save button disable

Disable button after it's being click to prevent user submit twice #38
Made changes in src/Modules/SimplCommerce.Module.Core/Areas/Core/Views/Manage/UserInfo.cshtml

If we want to accept this we need to do it in many places, right?


Our current fuzzysearch lib is a bit limiting, since the only result it gives is whether the string matches to the query.
Already mentioned Fuse.js lib is very promising and can help us improve both filtering and highlighting features (built-in matches indices in the result). However they have a PR that is vital for us. So we can make a fork (like with the react-treabeard).
Other alternative might be this small lib - https://github.com/mattyork/fuzzy/blob/master/lib/fuzzy.js.
It has no built in matches feature, but can be easily used as a source of truth for both - filtering and highlighting.
In other words I think this change is bigger than just PR to master..
What do you guys think ?

However they have a PR that is vital for us. So we can make a fork (like with the react-treabeard).

We can make a fork and send a new PR with tests =)

It has no built in matches feature, but can be easily used as a source of truth for both - filtering and highlighting.

How exactly would you use it for highlighting?

@igor-dv I think the current behavior is perfect for most real-world component libraries, which never grow particularly big/complex. You're always welcome to make it better, but if it was me I would just ship it as is.

@shilman please type '` in the filter and look into console

I've fixed the special characters issue.
@shilman regarding the highlighting, here is an example when it breaks..

I think if there are no strong objections we can merge this one (after I'll add few tests, probably tomorrow) And add the Fuse.js as a  separate PR (and maybe as part of the next release).

Great! The first issue is gone, the second one can be solved in a scope of another PR


Rename PODMAN_BIN to CONTAINER_TOOL with backward compatibility

This came up in https://github.com/konveyor/kantra/pull/165: now that kantra will automatically fall back to docker if podman isn't present, PODMAN_BIN doesn't make quite as much sense. Renaming it to CONTAINER_TOOL would help clarify what the override is actually overriding.
Keeping PODMAN_BIN handling that forwards to CONTAINER_TOOL means this doesn't need to be a breaking change.
A name other than CONTAINER_TOOL is fine with me, it does seem like an easy pick though. I also took a look in k8s and see that name being used: https://github.com/search?q=org%3Akubernetes-sigs+CONTAINER_TOOL&type=code

Hey, I issued a PR that might close this issue!!


Use uint32_t in wlr_renderer_begin signature

This matches the signature of wlr_renderer_impl.begin

This is technically a breaking change but I don't think it will cause any issues as the implicit cast from int to uint32_t is currently happening, presumably without issue, inside wlroots.

This is technically a breaking change but I don't think it will cause any issues as the implicit cast from int to uint32_t is currently happening, presumably without issue, inside wlroots.

The change LGTM, however, it is still a breaking change. For example, if some language uses auto-generated bindings and in that language the implicit conversion is not available.


Updating mbed-os to mbed-os-5.12.3

Please test this PR
If successful then merge, otherwise provide a known issue.
Once you get notification of the release being made public then tag the corresponding
release branch with mbed-os-5.12.3 .

the release candidate branch was changed, so I am closing this one and creating new one for 5.12.4