Dora-RS Autonomous System seems have some issue to deal the scenario in CARLA.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Dora start daemon: dora up
Start a new dataflow: dora start dataflow.yaml
Stop dataflow: dora stop
Destroy dataflow: dora destroy

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots or Video
If applicable, add screenshots to help explain your problem.
Environments (please complete the following information):

System info: [use uname --all on Linux]
Dora version: [use dora --version and pip show dora-rs]

Additional context
Add any other context about the problem here.
We have discovered some capability deficiencies in DORA. DORA seems to have difficulty handling some scenes in CARLA and often experiences behaviors such as collisions, permanent parking, and lane departure. We would like to confirm with the author whether these defects are known to exist.
https://caixxuan.github.io/Text2Scenario.GitHub.io/

@caixxuan you and your team's work is very interesting.
The Dora-RS, CARLA original authors will be presenting their work at GOSIM Beijing conference and workshop: https://china2024.gosim.org/ on Oct 17-18. Please register and attend the conference to engage with authors directly.
Also your team may join the GOSIM embodied AI hackathon, which are based on Dora-RS and fine tuned VLA models thru llama-factory open source project.

You have done great work. Dora-RS is very meaningful for autonomous driving, and we will further study and test it.  GOSIM is a very interesting conference and we are interested in learning about it.


json-directory: mark unbroken

As of 1.0.2 json-directory builds
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@luke-clifton Thanks!  Could you rebase this on the haskell-updates branch?  We generally ask that all Haskell-related changes go there.

@ofborg build haskellPackages.json-directory

@winterqt Asking ofborg to build this likely won't work until re-running maintainers/scripts/haskell/regenerate-hackage-packages.sh.  @luke-clifton could do that in this PR (which would be easier for us), or one of us would do it after merging into the haskell-updates branch (which is currently being tracked in https://github.com/NixOS/nixpkgs/pull/182019).
It is also possible this won't be possible to backport (depending on how much master has differed from 22.05 by now).

@cdepillabout Yeah, that makes sense, apologies.

It is also possible this won't be possible to automatically backport (depending on how much master has differed from 22.05 by now).

I removed the label since 22.05 does not have micro version 2 of this package.

Ah sorry, I didn't realize you immediately removed it!

Close in favour of https://github.com/NixOS/nixpkgs/pull/182207


[Errno 36] File name too long

when run the code
exp_manager.log_files_gen()
, I got this error:
[Errno 36] File name too long: './code/test_task/2022/11/10/08-47-50-601532_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-143559_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-143559_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-143559_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-143559_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-143559_<IP_ADDRESS>_&data_type=S_Mon_S_Period&seed=0/code/ccdc_cql_transformer_hc/2022/11/10/08-42-17-...'
could you help me to fix this question?

It is because the code  folder is recursively copied.
RLA will back up your projects (defined by BACKUP_CONFIG.backup_code_dir in rla_config.yaml) into the {data_root}/{task_table_name}/code folder when starting your main script.  However, currently, the code folder is also under BACKUP_CONFIG.backup_code_dir, so the code folder is recursively copied.
There are several solutions. I think the simplest way is using the ``ignore_file_path'' parameter. For example, you can config the exp_manager like this:
def get_package_path():
    return os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

exp_manager.configure(task_table_name='test_task',
                      rla_config=os.path.join(get_package_path(), 'rla_config.yaml'),
                      ignore_file_path=os.path.join(get_package_path(), '.gitignore'),
                      data_root=get_package_path())

where os.path.join(get_package_path(), '.gitignore') should at least include the following contents:
**/archive_tester/**
**/checkpoint/**
**/code/**
**/results/**
**/log/**
**/arc/**

Then the related contents will be ignored when backing up your project.
Please tell me if the solution cannot handle your problem. :)

Thanks so much. It seems that there is a folder named code, which is my 'BACKUP_CONFIG.backup_code_dir', under the data_root. Thus, the code folder is recursively copied. I fixed it by configuring the data_root with an empty directory.
One more thing, when I use the RLA, I am confused by which package I should import. For exmple:
from RLA.easy_log.tester import exp_manager  # in examples
or
from RLA import exp_manager # in README.md
Thanks again.

Cool! Both are ok. RLA.exp_manager is a reference to the exp_manager in RLA.easy_log.tester.exp_manager.  refer to https://github.com/polixir/RLAssistant/blob/f8f34e76a810916858815d8eef09fc237b368999/RLA/init.py#L1

O! I got it. Haha, thank you very much!


Wooting 2 Lekker Edition

Device Name: Wooting 2 Lekker Edition
Manufacture Page: https://wooting.io/wooting_two_lekker
The Layout is the same as the Wooting 2 but does not work

can you add the label Area: Hardware Support to your request?

I'd be happy to see this implemented as well.


Multi process sample

added sample to demonstrate why tray is so much better in multiprocess compared to the sharedpreferences

@garijp I added your sample

Current coverage is 100.00%

Merging #53 into develop will not affect coverage as of 3fd8974

@@            develop     #53   diff @@
=======================================
  Files            22      22
  Stmts           622     622
  Branches         82      82
  Methods           0       0
=======================================
  Hit             622     622
  Partial           0       0
  Missed            0       0

Review entire Coverage Diff as of 3fd8974

Powered by Codecov. Updated on successful CI builds.


Correct default-value for user-memory in Loadbalancer.

as per title
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[x] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #3993 into master will decrease coverage by 4.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
- Coverage   85.77%   81.18%   -4.59%
==========================================
  Files         146      146
  Lines        7084     7084
  Branches      440      440
==========================================
- Hits         6076     5751     -325
- Misses       1008     1333     +325

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.1%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-81.82%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
0% <0%> (-58.83%)
:arrow_down:

...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala
92% <0%> (-4%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
75.67% <0%> (+8.1%)
:arrow_up:

...rc/main/scala/whisk/common/ForcibleSemaphore.scala
96.15% <0%> (+11.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76537c5...6f3fc4e. Read the comment docs.


ddns with NetworkManager

Hi,
is there also a suggested way to handle NetworkManager configurations? I think /etc/dhcp/dhclient-exit-hooks.d/ only gets used with old-style networking.
Greetings
Klaas

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98de6798-2cd1-b76b-176f-81e502655d03
Version Independent ID: cfdb586f-e832-551a-40ae-c7c42d8f5798
Content: Using dynamic DNS to register hostnames in Azure
Content Source: articles/virtual-network/virtual-networks-name-resolution-ddns.md
Service: dns
GitHub Login: @subsarma
Microsoft Alias: subsarma

@Klaas- I do not believe we currently have NetworkMananger configurations documented.
I have assigned the issue to the content author to evaluate and update as appropriate.

https://www.cloudera.com/documentation/director/2-1-x/topics/director_get_started_azure_ddns.html I use a simpler version of the script provided here. As an additional suggestion: I roll this out as a custom script so the dns entry is already there when I first ssh into the machine.
cat dns-config.json
{
  "fileUris": ["https://mywebserver/azure/dns-update.sh"],
  "commandToExecute": "./dns-update.sh"
}

cat dns-update.sh
#!/bin/sh
cat > /etc/NetworkManager/dispatcher.d/12-register-dns <<"EOF"
#!/bin/bash
# NetworkManager Dispatch script
#
# Expected arguments:
#    $1 - interface
#    $2 - action
#
# See for info: http://linux.die.net/man/8/networkmanager

# Register A and PTR records when interface comes up
# only execute on the primary nic
if [ "$1" != "eth0" -o "$2" != "up" ]
then
    exit 0;
fi

# when we have a new IP, perform nsupdate
new_ip_address="$DHCP4_IP_ADDRESS"

dns_server="MYDNSSERVER"
host=$(hostname -s)
domain=$(hostname | cut -d'.' -f2- -s)
domain=${domain:='defaultsubdomain.domain.tld'}
nsupdatecmds=$(mktemp -t nsupdate.XXXXXXXXXX)
echo "Attempting to register $host.$domain"
{
    echo "server $dns_server"
    echo "update delete $host.$domain a"
    echo "update add $host.$domain 900 a $new_ip_address"
    echo "send"
} > "$nsupdatecmds"
nsupdate "$nsupdatecmds"
exit 0;
EOF
chmod 755 /etc/NetworkManager/dispatcher.d/12-register-dns
service network restart

and that can easily be deployed via arm template or az cli:
az vm extension set --resource-group "${ResourceGroup}" --vm-name "${VMName}" --name customScript --publisher Microsoft.Azure.Extensions --settings ./dns-config.json

Assigning to PM to review
@reassign:@rohinkoul

I am closing issues that have not been recently updated. I will cross reference and research them individually. I am recording each issue and compiling a list of articles to review. If you feel there is an urgent need to address something related to this GitHub issue, please open a new issue and I will reply in the new thread. Please also reference this GitHub issue number in the new issue. Thanks. #please-close


Pie chart in sheet 'Leads+Industries' contains no categories

The Excel created by the function 'ALL' creates a pie chart in the sheets 'Leads+Industries' and 'Industries_raw'.
The latter contains the chart as it should be.
The first sheet contains a pie chart with a numbered legend instead of the categories as intended and displayed in the raw sheet.

Fixed with version 2.5.1


Add script for creating siteConfig from frontmatter

@espenmn, i think i made it simple to generate the json necessary for the subpage-cards using a node script that gets the frontmatter of all .mdx files.
I think we can setup a githook to trigger the script before commiting.


[bug] C++ matching doesn't work on function declaration body

⏯ Playground link
💻 Code
void Foo(int x, int y)
{
	foo();
	bar();
}

void Foo(int x)
{
	foo();
	bar();
}

void Foo(int x)
{
	foo();
	bar();
	baz();
}

Pattern:
id: match-function-call
language: CPP
rule:
  kind: function_definition
  pattern: 'void Foo($$$ARGS){$$$EXPR}'

🙁 Actual behavior
Nothing is matched
🙂 Expected behavior
It should match all three functions. The problematic issue is that $$$EXPR doesn't match the function body.
'void Foo($$$ARGS){$A;$B;$C}'

matches the third version but it doesn't seem possible to match the whole body irrespective of the body contents. There are some variations that match some things see this link
Interesting the bug seems to go away when switching to C but the same code does not work when the parser is  c++
Maybe the problem is with treesitter itself
$RET $FUN($ARGS){$$$BODY} has the {$$$BODY} section parsed as initializer_list rather than compound_statement. You can force it to match as compound statement if you add in an extra semicolon as in
$RET $FUN($ARGS){$$$BODY;} but this causes other issues and the matching will still fail

Hi thanks for using ast-grep.

$RET $FUN($ARGS){$$$BODY} has the {$$$BODY} section parsed as initializer_list rather than compound_statement.

Yes, this is tree-sitter's parsing decision and C++ is famous for its ambiguity. To avoid ambiguity, you can use https://ast-grep.github.io/guide/rule-config/atomic-rule.html rule.

There are some variations that match some things

The limitation of tree-sitter can be circumvented by tricky patterns and yaml rules. See
https://ast-grep.github.io/playground.html#eyJtb2RlIjoiQ29uZmlnIiwibGFuZyI6ImNwcCIsInF1ZXJ5IjoiJFJFVCBGb28oaW50IHgsIGludCB5KXskJCRCT0RZfSIsInJld3JpdGUiOiIiLCJjb25maWciOiJpZDogbWF0Y2gtZnVuY3Rpb24tY2FsbFxubGFuZ3VhZ2U6IENQUFxucnVsZTpcbiAga2luZDogZnVuY3Rpb25fZGVmaW5pdGlvblxuICBhbnk6XG4gIC0gcGF0dGVybjogJ3ZvaWQgRm9vKCQkJEFSR1MpeyQkJEVYUFIwOyQkJEVYUFIxfSdcbiAgLSBwYXR0ZXJuOiAndm9pZCBGb28oJCQkQVJHUyl7fSdcbiIsInNvdXJjZSI6Ilxudm9pZCBGb28oKVxue1xufVxuXG52b2lkIEZvbyhpbnQgeCwgaW50IHkpXG57XG5cdGZvbygpO1xufVxuXG52b2lkIEZvbyhpbnQgeClcbntcblx0Zm9vKCk7XG5cdGJhcigpO1xufVxuXG52b2lkIEZvbyhkb3VibGUgeClcbntcblx0Zm9vKCk7XG5cdGJhcigpO1xuXHRiYXooKTtcbn1cblxuIn0=

May I propose adding a where operator by which it becomes possible to define the structure of match variables. For example
id: match-function-call
language: CPP
rule:
  kind: function_definition
  any:
  - pattern: '$RET $FN($$$ARGS){$BODY}'
    where:
      -
        BODY:
          any:
            -pattern: {$$$}
            -pattern: {$$$;$$$}
fix: |
  $RET $FN($$ARGS) {
    $BODY
  }

or
id: match-function-call
language: CPP
utils:
  patterns:
    function-body
      any:
        -pattern: {$$$}
        -pattern: {$$$;$$$}
rule:
  kind: function_definition
  any:
  - pattern: '$RET $FN($$$ARGS){$BODY}'
    where:
      BODY:
        matches: function-body

@bradphelan hi, we already have a constraints object in the rule.
https://ast-grep.github.io/reference/yaml.html#constraints


Update _config.yml to use mailto: link

This will make your email link open in a mail application (rather than a 404)

Sorry I missed this last month @rabernat , thanks for this!!


RFC: "Intellectual Property Law in Digital Age" link is broken

Problem:
Under Core Ethics section, the link of "Intellectual Property Law in Digital Age" course is broken.

Thanks for pointing out the problem!
Resolved by #1004


"A" variable being set when running T-MATS

It has been noticed that a workspace variable "A" is being generated when T-MATS is run.  Determine why this is being created and remove the workspace variable definition

It was found this variable is being set in the mask variable call back. Removed the problem A variable.
Completed 1/19/2015
b6930931105449459c953952416da54f47dc92e5


Find a smart way to validate the conf in the typedConfig of networkRBAC plugin

Description
No response
Use Scenes
See https://github.com/mosn/htnn/blob/f7ce8fed114dbcb6c45f316491492def55bbf973/types/plugins/networkrbac/config.go#L115.
The TypedConfig is a wrapper of protobuf Any so it's not validated by the generated validation.
Maybe we can use reflect to get all the TypedConfig and check them with the real proto message? Or using other solution. The solution should also work with other TypedConfig
Advice
No response

Relative: https://github.com/mosn/htnn/issues/629


Use std::os::unix::net::SocketAddr instead of mio::net::SocketAddr

It's the same type. It's only implemented by us because we can't create std::os::unix::net::SocketAddr.

We can do this in 1.61.

@Thomasdezeeuw is it confirmed to be stabilizing then?

@Noah-Kennedy it's stabilised in https://github.com/rust-lang/rust/pull/94356.

From #1605, I want to notice you that there may be a regression in the replacement: As you can see here, std::os::unix::net::SocketAddr doesn't support binding to a path with  \0 in it, which means it doesn't support abstract Unix socket.
Of course, there's no reason for std::os::unix::net::SocketAddr to support abstract Unix socket, since abstract Unix socket is a Linux feature, and not in the Unix spec.
But mio has already supported abstract Unix socket, though it's a little buggy, like there's no conditional compilation to make it only work on Linux.
So this replacement will possibly break the use of abstract Unix socket, I think we need to be careful on this.
(Sorry for my bad English)

I think the support is still unstable, but it's should come at some point: https://doc.rust-lang.org/std/os/unix/net/struct.SocketAddr.html#method.from_abstract_namespace. Maybe we can create a pr to stabilise it.

That's a good idea indeed.
On Tue, 30 Aug 2022 at 20:09, Thomas de Zeeuw @.***>
wrote:

I think the support is still unstable, but it's should come at some point:
https://doc.rust-lang.org/std/os/unix/net/struct.SocketAddr.html#method.from_abstract_namespace.
Maybe we can create a pr to stabilise it.
—
Reply to this email directly, view it on GitHub
https://github.com/tokio-rs/mio/issues/1527#issuecomment-1231998572, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABCY4MXA6BK2ZDAP4M3UPTV3ZE6VANCNFSM5HQUHSUQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


IdentityServer4.CorsPolicyProvider:Warning: CorsPolicyService did not allow origin

I am getting this error when trying to post from a javascript html to http://localhost:3400/connect/token
IdentityServer4.CorsPolicyProvider:Warning: CorsPolicyService did not allow origin: http://localhost:8080
Chrome is returning:
XMLHttpRequest cannot load http://localhost:3400/connect/token. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8080' is therefore not allowed access. The response had HTTP status code 400.
My client:
    public static IEnumerable<Client> GetClients()
        {
            return new List<Client>
        {
            new Client
            {
                ClientId = "XXXX",

                AllowedGrantTypes = GrantTypes.ResourceOwnerPassword,

                // secret for authentication
                ClientSecrets =
                {
                    new Secret("XXXX".Sha256())
                },

                // scopes that client has access to
                  AllowedScopes =
                {
                    "api1"
                },
                AccessTokenLifetime = 3600 ,
               AuthorizationCodeLifetime=600,
               AbsoluteRefreshTokenLifetime = 2592000,
               SlidingRefreshTokenLifetime = 1296000,
               RefreshTokenUsage = TokenUsage.OneTimeOnly,
               RefreshTokenExpiration = TokenExpiration.Sliding,
                    AllowedCorsOrigins = new List<string>
            {
                "http://<IP_ADDRESS>:8080",
                "http://localhost:8080",
                "*"

            }
            }
        };

        }

Startup.cs
  public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
        {
            app.UseCors(x => x.AllowAnyOrigin().AllowAnyHeader().AllowAnyMethod().AllowCredentials());

            loggerFactory.AddConsole(Configuration.GetSection("Logging"));
            loggerFactory.AddDebug();

            app.UseApplicationInsightsRequestTelemetry();

            app.UseApplicationInsightsExceptionTelemetry();

            // app.UseMiddleware<KestrelAuthenticationMiddleware>();
            app.UseIdentityServerAuthentication(new IdentityServerAuthenticationOptions
            {
                Authority = "http://localhost:3400",
                RequireHttpsMetadata = false,

                ApiName = "api1"
            });
            app.UseIdentityServer();

            app.UseMvc();

        }

Did you add services.AddCors(); to ConfigureServices ?

Check the IS logs for any relevant info.

Yes, here is my ConfigureServices
   public void ConfigureServices(IServiceCollection services)
        {
            // Add framework services.
            services.AddApplicationInsightsTelemetry(Configuration);

            var mongodbClient = new MongoClient(Configuration.GetSection("Database").GetSection("URL").Value);
            var database = mongodbClient.GetDatabase(Configuration.GetSection("Database").GetSection("Name").Value);
            services.AddSingleton<IMongoDatabase>(database);
            services.AddSingleton(typeof(IRepository<>), typeof(MongodbRepository<>));
            services.AddSingleton(typeof(IService<>), typeof(GenericService<>));
            services.AddSingleton(typeof(IQuestionService), typeof(QuestionService));
            services.AddSingleton(typeof(IUserService), typeof(UserService));
            services.AddSingleton(typeof(IPaymentService), typeof(PaymentService));
            services.AddSingleton(typeof(IMongodbRepository<>), typeof(MongodbRepository<>));
            services.AddSingleton<IMapper>(sp => _mapperConfiguration.CreateMapper());

            services.AddIdentityServer()
                .AddTemporarySigningCredential()
                .AddInMemoryApiResources(IdentityServer.GetApiResources())
                .AddInMemoryClients(IdentityServer.GetClients());

            services.AddTransient<IResourceOwnerPasswordValidator, MongoDbResourceOwnerPasswordValidator>();
            services.AddTransient<IProfileService, MongoDbProfileService>();

            services.AddCors();

            services.AddMvc();

        }

Omg, my problem was I have my project "On build error"=> "Launch Old Version".  I had a compile error but I ignored it because I thought it was just typescript error.  So whatever changed I made never took effect.
I wasted 2 days on this.


kubeapiserver: rename '--experimental-encryption-provider-config' to …

…'--encryption-provider-config'.
This change renames the '--experimental-encryption-provider-config' flag to '--encryption-provider-config'. The old flag is accepted but generates a warning.
In 1.12, we will drop support for '--experimental-encryption-provider-config' entirely.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

@php-coder

@marrrvin Thank you! Just a minor improvement: could you edit PR description and remove unrelated text that is part of the issue template?

This issue is related to https://github.com/kubernetes/kubernetes/pull/61592 and https://github.com/kubernetes/kubernetes/issues/61420
/lgtm

@ericchiang @liggitt PTAL

@php-coder Done.

@php-coder Done.

this should not merge until 1.11, correct?

this should not merge until 1.11, correct?

Yes,
/lgtm
/milestone v1.11
/hold

/lgtm cancel


Playback crash

On macOS Ventura, asak 0.3.3.
lm@neutrino Downloads % RUST_BACKTRACE=full asak play 12\ Isarflimmern.wav
thread 'main' panicked at src/playback.rs:300:45:
index out of bounds: the len is 8072128 but the index is 8101366
stack backtrace:
0:        0x10083996c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7fda799bfa435f0f
1:        0x100844934 - core::fmt::write::h149c43f8c649a127
2:        0x10082a82c - std::io::Write::write_fmt::hc658f220ee6401ee
3:        0x1008397c0 - std::sys_common::backtrace::print::hd320cb51e23d85e7
4:        0x100835760 - std::panicking::default_hook::{{closure}}::h2a019217d59e304e
5:        0x10083547c - std::panicking::default_hook::h7115745ac0da2b42
6:        0x100835afc - std::panicking::rust_panic_with_hook::hcaae50c6a8446a46
7:        0x100839d48 - std::panicking::begin_panic_handler::{{closure}}::h3511e01278c0eee1
8:        0x100839b98 - std::sys_common::backtrace::__rust_end_short_backtrace::hb40ac48f98b88c7f
9:        0x100835844 - _rust_begin_unwind
10:        0x10085acd4 - core::panicking::panic_fmt::hd81673e1b116ffee
11:        0x10085ae1c - core::panicking::panic_bounds_check::hc81bd72e43e4b29a
12:        0x10076c4e4 - ratatui::terminal::terminal::Terminal<B>::draw::hb8831a3bf92146a5
13:        0x10075c970 - asak::playback::play_audio::heb81761218f536ce
14:        0x100773d3c - asak::main::h20e2bf02a7677445
15:        0x100748c18 - std::sys_common::backtrace::__rust_begin_short_backtrace::h703d3d2757c553a3
16:        0x100777dfc - std::rt::lang_start::{{closure}}::hd475ac4a0ad9792e
17:        0x100835798 - std::panicking::try::hd72586cf9ddb09aa
18:        0x100823cc4 - std::rt::lang_start_internal::ha2b1bf612bcbfcfb
19:        0x100776cb0 - _main

This is a track that was not recorded using asak. Let me know if you need the file for testing and I will try uploading somewhere or sharing it by email… although I had issues with several files.
Recording seemed to work great, as well as playback of asak recordings, thank you for the development of this! :-)

do you mind sharing the wav via google drive or onedrive? or you can send it to my email<EMAIL_ADDRESS>


Portfolio Webiste Added

@RITEKROUNAK kindly review my PR.

Good work. I am merging your PR.
Do give us a star by hitting the star button of this repo!


BadElfBase base workflows in wrong app

BadElfBase and VaspBadElfBase are in warren_lab but should be moved to badelf

Fixed in PR #588


Fix handle empty body

nil body is different than body with len == 0.
for example - proto message with 1 field and false value also has body with len 0.

Coverage increased (+0.02%) to 76.047% when pulling f4fe1da2bc3fdfbf89b3b9e45f67a48f286725a8 on fix_handle_empty_body into f6d8b053afd5af1ff43d5781c2c63c5049b22e41 on v1.x.


Accelerate via @actions/cache

This change makes this Action truly useful: the first time we try to get a given build artifact, it will be downloaded from Azure Pipelines. But then it will be cached. And subsequent attempts will use the cached version and be a lot faster!

@dennisameling I would also love to have your 👀 over this PR...

I am currently testing this by running a full matrix here: https://github.com/dscho/setup-git-for-windows-sdk/runs/1925713769?check_suite_focus=true. Once that run is done (and so far, it looks pretty good, having cached 4 out of the 6 artifacts), I will push a new commit to the test branch that triggers another run: this one should use the cached artifacts and demonstrate just how much faster things become this way.

Wow, caching is not exactly cheap, either: the full 32-bit SDK takes ~2m45s to cache 914MB... in contrast, it only takes ~15s to cache the ~75MB of git-sdk-64-minimal (hit the gear on the upper right to "Show timestamps").

Whoa, it takes ~5m20s to cache the 64-bit full SDK as a 1300MB .tar.gz file....

Yes!!! The subsequent run manages to restore the minimal SDK in 10s instead of the 1m4s in the uncached case.
For the git-artifacts.yml workflow, the most interesting comparison is the build-installers one: 1m vs ~5m30s.
In contrast, the full SDKs seem not to benefit all that much. A run from yesterday (without caching the just-downloaded artifacts) clocked the 32-bit and 64-bit full SDK at ~6m and ~8m20s, respectively. When restoring them from cache, the numbers are ~5m and ~8m15s, respectively.
Given these findings, I think we will want to disable the cache for the full SDKs by default because it does not really seem to give us a big bang for the buck.

This PR is now based on #9, which should be merged first.

And here is a run that exercises the full supported flavor/architecture matrix with the default caching.
I think this is good to go now.

This looks great, but I'm not sure about one thing...

When restoring them from cache, the numbers are ~5m and ~8m15s, respectively.

For x86_64, the cache size looks rather large to me: Cache Size: ~1300 MB<PHONE_NUMBER> B), compared to the full download from Azure Pipelines (~500M):
100  497M    0  497M    0     0  14.1M      0 --:--:--  0:00:35 --:--:-- 15.8M
unzipping C:/git-sdk-64-full-sdk/tmpz0AltS/artifacts.zip

Are you sure that's correct?

When restoring them from cache, the numbers are ~5m and ~8m15s, respectively.

For x86_64, the cache size looks rather large to me: Cache Size: ~1300 MB<PHONE_NUMBER> B), compared to the full download from Azure Pipelines (~500M):
100  497M    0  497M    0     0  14.1M      0 --:--:--  0:00:35 --:--:-- 15.8M
unzipping C:/git-sdk-64-full-sdk/tmpz0AltS/artifacts.zip

Are you sure that's correct?

Yes, that's correct. The full SDK is actually not just a .zip file, it is a .tar.xz file within a .zip file. That's a deviation from all the other flavors, specifically so that the bandwidth is used more efficiently (I tried to strike a balance between download and extraction time).

Rebased (and regenerated dist/), to avoid the merge conflicts in dist/index.js.

This looks great, but I'm not sure about one thing...

With the question why 500MB are equivalent to 1,300MB out of the way, I interpret this as your :+1: to merging this ;-)


Install fails on OSX Mojave

pip install cantools results in this error:
    ERROR: Complete output from command python setup.py egg_info:
    ERROR: zip_safe flag not set; analyzing archive contents...

    Installed /private/var/folders/jl/8cmqmk2s5q39t472_br4xpqm0000gn/T/pip-install-_zU41_/python-can/.eggs/pytest_runner-5.1-py2.7.egg
    /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires'
      warnings.warn(msg)
    error in python-can setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected version spec in typing;python_version<"3.5" at ;python_version<"3.5"
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/jl/8cmqmk2s5q39t472_br4xpqm0000gn/T/pip-install-_zU41_/python-can/

It seems like there is a problem with the version of setuptools but I cannot figure out how to solve it.

It's the python-can dependency that fails to install. I might make that optional, as it's only used by the monitor subcommand I think.

Hmm, could you open an issue on the python-can project? I would like to keep the dependency to keep the installation simple.

For anyone else getting stuck with this problem, I worked around this by updating setup tools:
sudo pip install --upgrade setuptools --user python
And then installing cantools this way:
sudo pip install cantools --user python
cantools is now available:
WARNING: The script cantools is installed in '/Users/paul/Library/Python/2.7/bin' which is not on PATH.


Cors problems when using API

I tried to use the API and acces it by using Fetch (JavaScript). After a lot of searching and trying over and over again I wasn't able to fix this problem. There is always a problem with the cors. Keep having the issue Failed to load resource: Origin http://localhost:3000 is not allowed by Access-Control-Allow-Origin. Don't know if it's something on my end or not.
I'm developing from localhost. Maybe this is the problem?
The image shows the code.

Error in console.

Thanks for looking into this.

I think I had the same issue running local development. I then added a /etc/hosts entry pointing to the site (e.g. some.coin.com) and it worked.
This is not something MPOS is doing but something being enforced by your browser and web server. I don't remember adding CORS checks into MPOS so it's probably just supposed to fail for localhost ;-)


AttributeError: Can't pickle local object 'create_x3d_res_block..'

If you do not know the root cause of the problem / bug, and wish someone to help you, please
post according to this template:
🐛 Bugs / Unexpected behaviors

The hub contains model defined with lambda function. Those should be avoided as they can't be pickled.
NOTE: Please look at the existing list of Issues tagged with the label 'bug`. Only open a new issue if this bug has not already been reported. If an issue already exists, please comment there instead..
Instructions To Reproduce the Issue:
Please include the following (depending on what the issue is):

Any changes you made (git diff) or code you wrote

<put diff or code here>

The exact command(s) you ran:
What you observed (including the full logs):

<put logs here>

Please also simplify the steps as much as possible so they do not require additional resources to
run, such as a private dataset, models, etc.

try: remove self.save_hyper***()

Hi @tchaton , were you able to resolve this issue?

the problem only exists on windows, since the lambda model in pytorch transforms doesn't have a pickle implementation for windows(for some reason), just running the same script on linux resolves the problem.

@danikv @kalyanvasudev I'm having the same issue on the linux as well.

Running on Mac M1, Has anyone found a fix for this?


Why not officially support blob, date data type? And provide a before, after criterion for datetime and date?

Why not officially support blob, date data type? And provide a before, after criterion for datetime and date? I know it's easy with custom validator, but since it's easy, why not officially support them?

what are you referring to as blob?
i can also think of other commonly encountered validations, like for networking and posix-stuff.
for such purposes, i think the best would be to add a module with contributed custom validators in dumb classes that can be used as mix-ins for custom validators:
class UserValidator(cerberus.Validator, cerberus.contrib.EMail):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)  # don't try this at home if Python < 3
        self.schema = {'name': {'type': 'string', 'regex': '[a-z]{3,12}'},
                       'email': {'type': 'email address'}}

# or set the schema in your business logic:

class UserValidator(cerberus.Validator, cerberus.contrib.EMail):
    pass

concerning the before and after criteria: what about covering that by min and max? but that would be from / to criteria.

can this issue be closed? any types can be used with min and max in the master branch.


About box broken.

From<EMAIL_ADDRESS>on 2012-05-23T11:00:38Z
Spyder Version:  2.2.0dev
Python Version:  2.7.1
Qt Version:      4.7.4, PySide 1.1.0 on Windows
What steps will reproduce the problem?

Press the about item in the Help menu. What is the expected output? What do you see instead? The About box. Instead following traceback comes:

Traceback (most recent call last):
File "C:\Python27\lib\site-packages\spyderlib\spyder.py", line 1366, in about
full, short, branch = vcs.get_hg_revision(osp.dirname(spyderpath))
ValueError: need more than 0 values to unpack
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1043

From pierre.raybaut on 2012-05-23T10:17:20Z
This issue was closed by revision ce8c5309a6d1 .
Status: Fixed

From<EMAIL_ADDRESS>on 2012-05-23T12:34:25Z
Ahh, my fault. Root cause analysis:
In r6b160c0c6e78 vcs.get_hg_revision() function moved from bootstrap.py, which was never executed without hg for obvious reasons. =) After reading http://docs.python.org/library/subprocess.html#exceptions I assumed that subprocess should throw an exception if hg is not found. Hence the generic except clause. But it appears that exceptions are not thrown if shell=True. http://bugs.python.org/issue14879


TextZone too small for text in settings

Explain the bug
The language change confirmation popup displays unreadable text.
To reproduce
Open settings, tab Preferences
Choose a another lang
Expected behavior
Larger text box
Screenshots

This issue should be resolved in main.


Change socket URL

I need to change my socket's url in certain cases and I don't see a way to do it.
I am establishing the variable with :
var socket = WebSocket(url: URL(string: "First")!, protocols: ["chat", "superchat"])
socket.delegate = self
socket.voipEnabled = true
socket.disableSSLCertValidation = false
The socket is disconnected when I try to change the url and I try to change the url using the line below but the url doesn't change. If I try to change via socket.url, I am told that it is a read only value
socket = WebSocket(url: URL(string: "Second")!, protocols: ["chat", "superchat"])

Are you repeating all 4 lines or just the constructor? This code should work...
socket = WebSocket(url: URL(string: "Second")!, protocols: ["chat", "superchat"])
socket.delegate = self
socket.voipEnabled = true
socket.disableSSLCertValidation = false

Setting the delegate again when it switched was the answer for me, thanks. I was just setting the socket variable when it change.

 You can read up on classes and how they behave here https://docs.swift.org/swift-book/LanguageGuide/ClassesAndStructures.html.
You should also be able to close this issue.


Normalize and pil link fix

Update for a broken link to the PIL docs, and a more efficient version of the normalize transform.

thank you!

@kohr-h looks good, as you are on F.normalize, maybe it would be nice to add a notice in the documentation to cover #517 ?
cc @soumith

@vfdev-5 What would be the intention here, efficiency or keeping input intact? Looking at other transforms, they never explicitly copy, but probably most of them can't work in-place anyway.
I can add a notice in the docs, sure.

@kohr-h I would say that efficiency is better and among all other transforms F.normalize is the only transform working on torch.Tensor and returning torch.Tensor, so just add a notice that it works in-place can be enough.


Set custom selection rect from calling component

Any app using the grid can provide custom selection rect to highlight the range of cells in grid
programmatically
fix #49

:tada: This PR is included in version 5.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clarify the argument to expanding buffers

Currently docs suggest it expands dynamically to the limit provided, instead of its behavior which is to be initialized with a given size.

It might be a good idea to also reflect that in src/internal/buffers.js. Would you like to change it there as well?

Sure thing

Updated and rebased

Thanks!


Replace val_check_interval and check_val_every_n_epoch with val_steps  and val_epochs

🚀 Feature
Replace val_check_interval and check_val_every_n_epoch with val_steps  and val_epochs.
The logic also needs to be modified:
Currently:

val_check_interval=n: n epochs if float;  n steps if int
check_val_every_n_epoch=n n epochs, cannot be used with float

Proposed:

val_steps=n: n steps, cannot be used with float
val_epochs=n n epochs if float/int

Motivation
The argument names are confusing.
Additional context
See:
https://github.com/PyTorchLightning/pytorch-lightning/discussions/6253#discussioncomment-436962
#5413

Hi @cccntu

The argument names are confusing.

Could you add more details why the current names are confusing and why your proposed names would be less confusing?

@awaelchli @carmocca @tchaton It's slightly tangential to this issue, but for progress tracking we should clarify epochs/steps/batches across train/val/test/predict. e.g. is step the number of times training_step is called, or the number of times the optimizer is stepped?

Also related issue: https://github.com/PyTorchLightning/pytorch-lightning/issues/4409
That issue proposes that check_val_every_n_epoch should be completly removed, and instead val_check_interval=2.0 should instead mean "do validation every second epoch" (integers will refer to steps and floats will refer to epochs). IMO that is a better solution.

Hi @awaelchli I found it confusing because to specify n epoch, I would need to use val_check_interval if n is float and check_val_every_n_epoch if n is integer.
But I just realized you could specify val_check_interval=1.0.
Though I still think it would be more intuitive to use if we have alias like val_steps and val_epochs.


fix the spelling of comparison in notebook name

comparison was spelled wrong in the notebook title so needed to be fixed there and within _toc.yml

@facusapienza21 Do you want to have a look at this change before we merge it in?

@all-contributors please add @Swanson-Hysell for review and doc


Added Exception to for describe_container_instances to match aws api

Fixes #2473

Coverage increased (+0.2%) to 93.451% when pulling 017cbb52ca7230de20ab004387ad1bcaaed163e4 on jrstarke:2473 into 31198c75b8011f067e8ebdc97c604f555d2e7c04 on spulec:master.

LGTM


Add auto-completion for commands and long options (closes #124)

This PR adds auto-completion for bash :

auto install/uninstall completion for all commands if you type time2backup and global long options if you try time2backup -;
It honors $cmd_alias so it only completes on the alias;

What this PR doesn't do :

It doesn't assure completion on short one-character options and per-command options (but it could);
Obviously only works on linux (only tested on debian). It doesn't even test for the host compatibility before installing.

Sorry, don't merge now, I discovered a bug in the $cmd_alias handling when creating a new console.

Thank you so much for this contribution! I'll have a look and merge it soon for the upcoming 1.3 release.

Pull request merged for upcoming 1.3 release.
I made some significant changes to improve it, but it helped me a lot, thanks again! :fr:


Add a new workflow file

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 84.393%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/quantum_initializer/squ.py
2
79.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
59253

Relevant Lines:
70211

💛  - Coveralls

Ok


is it possible to make CRNN using SiaNet ?

Hi,
SiaNet is great !  thanks for your work.
is it possible to make CRNN currently ?
thanks!

Hello goodtogood, Yes I will plan to implement with next version 0.3 which I have planned in next 2 weeks with some bug fixes and improvement. Is that fine with you?

Great, Looking forward to new version !
I'll be watching SiaNet.
you can close this issue now.
thanks !

No problem at all. I will keep it open for tracking purpose and close it
once implemented.
Thanks,
Deepak
On Wed, Nov 15, 2017 at 4:06 PM, goodtogood<EMAIL_ADDRESS>wrote:

Great, Looking forward to new version !
I'll be watching SiaNet.
you can close this issue now.
thanks !
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/deepakkumar1984/SiaNet/issues/4#issuecomment-344491050,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGCQKUJBjvdscsWjEidrHj83jTqQrmRfks5s2nhRgaJpZM4QeaZv
.

--
Regards,
Deepak

I will plan to implement this paper(https://arxiv.org/pdf/1507.05717.pdf) as an example. It will not be implemented as part of the library because the SiaNet library has a generic set of functions to implement these models. If I build the model will you be able to train it and test it out? Do you have the dataset?

Closing it off as there is no activity is last 180 days


qt5: upgrade to 5.15.0

Updating Qt recipes for 5.15.0.  Not sure if it is planned for the warrior branch to support 5.15.0 or not.  This is also my first time contributing to open source

Oh - sorry - don't want to disappoint you on your first contribution but suggesting a huge version bump at an old stable branch won't be accepted.

Correct, warrior will stay on the same version of Qt, only minor upgrades are accepted.


Update Docs

some submodules still does not show up locally, like parameter.parameter and solvers.composite. need to check that later.

Hey @jizezhang is this ready to merge?


[metadata] group

I can only find examples of group being used in datatype files, not in any widget.

Since this is just used to group items in the PI (put them on the same row if possible), that is probably why it hasn't been used in public widget code.

Right. I just want to make sure we have it documented correctly. Where it has been used in a file, the contents of the column don't seem to refer to anything else in the file.

https://github.com/macMikey/LCB-missing-manual/wiki/Property-Editors

Need to test, update this page and close this issue


Install fails "Solving environment: failed"

The .yml is not quite ok.
conda env create -f environment.yml quits with
"ResolvePackageNotFound"
maybe the solution is under
https://github.com/ContinuumIO/anaconda-issues/issues/9480

Hm, right... I guess I got my environment working about 18 months ago and really have not touched it much since. It's possible some of these builds have gone away. I bet we can make another environment file which relaxes the specific builds.
IIRC the only tricky bit was VTK, hence the clinicalgraphics conda channel.


Set the CARGO_BIN_NAME environment variable also when building (binary) examples

Problem
The CARGO_BIN_NAME environment variable is useful when building command-line programs (see #8251). It lets the command know its binary name for printing out simple usage instructions.
Currently CARGO_BIN_NAME is only set when building a [[bin]] target, though. In my projects a lot of the examples are wrappers around functions of a library crate to allow testing with custom data, similar to small command-line programs. In those example binaries CARGO_BIN_NAME is not available during compilation.
Proposed Solution
It would be useful to also set the CARGO_BIN_NAME environment variable for (binary) examples.
Notes
No response

I think it should be feasible to make it happen here.
 fn fill_rustc_tool_env(mut cmd: ProcessBuilder, unit: &Unit) -> ProcessBuilder {
-    if unit.target.is_bin() {
+    if unit.target.is_executable() {

Let's do a quick poll whether to accept this feature: “Set the CARGO_BIN_NAME environment variable also when building (binary) examples”. I don't have any concern so far.
@rfcbot poll T-cargo "feature accept?"

@weihanglo: This was the line change that I stumbled over, too. From a quick check with a custom-built cargo it works.
Do you intend to write a PR in case the feature gets accepted? Otherwise I can do it.

Hi...
I have an issue that is related to this..
I need to know when the build target is a bin.
Scenario:
I have several sub-projects with their own build script.

app

-build.rs

libs

lib1

build.rs

lib2

build.rs
One of the build steps is generating a resource file(crate winres).
When app gets built, the build scripts for lib1 & lib2 runs and creates resource files.
Which creates duplicates and link fails.

So, I need to find a way to determine if the build is a lib/rlib/exe so I can do something like :
#[cfg(windows)]
pub fn build_resource () {

   #[cfg(bin)]
    if Ok("release".to_owned()) == std::env::var("PROFILE")  {
        let mut res = winres::WindowsResource::new();
        res.set_icon("../libs/myicon.ico")
            ;
        if let Err(e) = res.compile() {
            eprintln!("{}", e);
            std::process::exit(1);
        }
    }
}

Or is that possible some other way ?
Thanks
JR

Hi @JRAndreassen. This feels like a separate issue to me, and probably more like a user issue. I don't clearly understand the problem, but you may want to move resource generation to build.rs of app. Unfortunately we are not able to support you here. I'd suggest you try one of the user forums such as https://users.rust-lang.org/ to see if someone can help.
Alternatively, you can also create a new issue explaining the expectation with a reproducer and possible solutions and workarounds. Thank you.

@t-rapp, since the majority of the Cargo team voted for accepting this, we can move forward implementing this. Thank you!

I would also like to have a CARGO_CYDLIB_NAME and TARGET_DIR at build time and integration test time. This will help me consume dynamic libraries in integration tests and rename the files as needed (in the case of Nodejs, from {prefix}libname.{ext} to libname.node.

For target-dir, see #9661

Hadn't noticed this is a closed issue. If there isn't an open issue for that need, I'd recommend creating one


Safari 11.0 not getting media showing black screen

https://simpl.info/getusermedia/
Error: getUserMedia error:
TypeError: Type error
createObjectURL
handleSuccess — main.js:27
promiseReactionJob

Thanks for the heads up!
Fixed here.
Let me know if you're still experiencing problems.

@samdutton Hey, we still only see black boxes on ios 11.3

I've added playsinline — does this fix it for you? I don't have an iOS device with 11.3 to hand. (Works in Safari on Mac.)
Does webrtc.github.io/samples/src/content/getusermedia/gum work for you? That's the canonical demo. Do any other demos work?
If none of the examples work, this seems like an iOS/Safari bug.


Fix async validators capturing and overwriting validation results

I noticed that when there are two or more asyncValidators, the last one calling done() overwrote the results of all validators that finished before.
The reason was that fieldValue was captured when the validators were kicked off, and then merged at done(), even if they had changed.
This also resolves #1013.

Codepen that uses new version and shows shows that #1013 is fixed: https://codepen.io/ngbrown/pen/JwLrPe.  Reproduce steps from #1013 with both original and new codepen.

Published as 1.16.12


Progress bar stands still android chrome

Hi, I was testing the video player with embedded youtube video in a nexus tablet with chrome , I found that when you click the progress bar to advance vídeo playback, the progress marker moves to the position where I click and stands still and the vídeo continúe playing. If you press de play/pause button, the progress marker starts moving again from the position in which it is supposed to be.

Damn. I'll take a look. Thanks for reporting 👍

Which version of Chrome  + Android are you using? I'm struggling to replicate on Android 4.4 with latest Chrome.

Im using Android 6.0 with Chrome versión 51.0, not sure if other mobile devices present the same problem, I just taste it in a nexus 7.

Is this still an issue?

@SamPotts Hi, I'm implementing the audio player, I tested it on other mobile devices and it worked, on Nexus 5 LG Android 6.0.1 with Chrome version 54.0 the player does not work.

Closing this one as I think it's fixed but feel free to re-open if not solved in v3 👍


Infinite loop in troll room

If you step in and out of the Troll Room enough in Zork I, the Z-machine (not the interpreter itself) goes into an infinite loop.

In order to debug this, a debugger-level seed command would be very helpful.

Fixed in commit 483d2cc..e1676b8:

Implemented debugger seed (E) command
Bug fixed in implementation of instruction PUT_PROP when the property is 1 word in size


MWPW-138678 - Improve unit test coverage

Resolves: https://jira.corp.adobe.com/browse/MWPW-138678
https://app.codecov.io/github/adobecom/dc/tree/mwpw-138678-unit-test-coverage/

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd4cab6) 96.58% compared to head (a97f41b) 99.54%.
Report is 4 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #457      +/-   ##
==========================================
+ Coverage   96.58%   99.54%   +2.96%
==========================================
  Files          26       26
  Lines        2871     2873       +2
==========================================
+ Hits         2773     2860      +87
+ Misses         98       13      -85

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Merge Physics and Procedure for RWS and KMOD

While I like the setup of this more, it causes two problems:

when you click on the link in Procedures, it jumps to the Physics chapter
mkdocs serve complains:

WARNING  -  A relative path to 'measurements/physics/kmod/#measuring-beta-using-k-modulation-in-the-lhc' is included in the 'nav' configuration, which is not found in the documentation files
WARNING  -  A relative path to 'measurements/physics/rigid_waist_shift/#the-procedure' is included in the 'nav' configuration, which is not found in the documentation files

Not liked so much


Complex Elements

Define requirements of any complex elements (e.g. emission graphs, custom controls, etc.)

Let's rename this issue to handle graph specific complex elements because it can broken up in to two different issues.

Should display a graph when choosing and Author Reward Curve and Curation Reward Curve that changes when a particular curve is selected.
Should display a graph underneath token emissions illustrating what the token emission schedule will look like for the currently setup token.


integrations: huggingface datasets

Report
How to work with huggingface datasets. Related:

https://github.com/iterative/dvc/issues/9175
https://github.com/iterative/dvc/issues/9943

Let's also include making updates to the huggingface datasets docs to include info about DVC.

Let's also add fsspec integration as part of this to explain how to use fsspec with dvc

Another idea here from a discussion with @omesser: show how to reference huggingface datasets as pipeline dependencies.

Add a page here: https://dvc.org/doc/user-guide/integrations


chore: Use CSV writer serialize

Use csv's serialize method, which automatically adds a header corresponding to the struct and writes the relevant data.

Note: not merging for now as it looks like the latest commit would not print the header if the file does not exist.

@puma314 Yeah I will fix it.

Rebased and fixed.


Updating readme from branch example

Updates
I updated the readme file. Please review and accept.

Thoughts
I probably shouln't, but okay. 👍


Hotfix: Corrected typo in logdie call

Coverage remained the same at 100.0% when pulling e207aa1814e6e15bd5d009702410a75d3abec682 on hotfix/correct_typo_in_logdie into d6bea28ace7bb38791a07455e8332e7413b8eaf5 on develop.


initialize fields in constructor

Fixes #393.
Testing: I ran make test and got no different results between the output in this PR and the current state of develop. That said I do see these warnings in the output (these are also present in develop):
.Adding all elements (10000)
.Running pickle tests for <hnswlib.Index(space='cosine', dim=32)>
.Running pickle tests for <hnswlib.Index(space='ip', dim=16)>
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 ann distance values are different from brute-force values (total # of values=2500, dists_thresh=50)
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 labels are missing from ann results (k=25, err_thresh=5)
Warning: 1 ann distance values are different from brute-force values (total # of values=2500, dists_thresh=50)

I am not sure if this is an actual problem or not?
Also, I confirmed that the valgrind error disappears via testing through the R bindings I maintain.

Cool! Thanks!
Before merging, I wonder if the constructor initialization is the preferred way (compared to C++ 11 initialization at the variable declaration)?

Before merging, I wonder if the constructor initialization is the preferred way (compared to C++ 11 initialization at the variable declaration)?

I can do that. The body of the third constructor HierarchicalNSW(SpaceInterface<dist_t> *, size_t, size_t, size_t, size_t)  (not changed in this PR) sets some of those fields to other values (e.g. ef_construction and M_). Would you want those fields also changed to default member initializers (presumably paying the minimal price of setting them twice) or leave those ones alone?
If we are talking constructor improvements then that third constructor would gain the most from changes, as it is the least C++ idiomatic as it sets most of its fields in the constructor body rather than using initializer lists. This PR will leave the constructor styles a bit inconsistent which might be confusing for readers. But I wanted to keep the scope of this PR as small as I could, especially as clang-tidy has a lot to say about converting hnswlib to C++11 form and it's hard to know where to stop once you start down that path...
Anyway let me know if you would like me to go ahead and use the default initialization approach (I see that clang-tidy may have missed some fields that should be default initialized).

Thanks! I am not a C++ expert, so not sure what is the best.
From my experience with other languages (java mostly) it is convenient to have declaration and default initialization at the same point of code (e.g. adding the default values in the block https://github.com/nmslib/hnswlib/blob/master/hnswlib/hnswalg.h#L88-L125 and not touching the existing constructors - they would only override the default values), so it would be also visible if some of the variables are not initialized without cross-checking. I thought that was introduced in C++11 (which is already used in hnswlib), though not sure if that is the right thing to do.

@yurymalkov I have made the changes to use direct initialization for the non-class-type fields like ints and size_ts (I have also used braces for the initialization which seems to be preferred by the C++ Core Guidelines). I believe more complex member types like std::vector will be default initialized without having to do anything but I am happy to be corrected on that.
Valgrind (via R) is still happy and make test gives the same output.

Great! Thank you so much!


Implement color component transformation in images using Decode parameter

Image might have Decode array specified (<IP_ADDRESS>	Decode Arrays). The components must be interpolated using the linear transformation. Currently we are doing: Math.round(255 * ret / ((1 << bpc) - 1)). Shall we also check/use color space ranges here?

Fixed by #947


Fix crash on macOS when closing window with preview active

[x] If you are a maintainer (only @nyanpasu64 at the moment), make sure to edit the changelog if needed. Otherwise, a maintainer will edit the changelog.

Seems to only segfault on Mac Qt6. Does not crash on Linux Qt5 and Windows Qt5/6, due to a coincidence.

how do i install corrscope on mac


Add option to ignore time limits

When I added support for the time directive by mapping it to --timeLimit, that inadvertently caused some pipelines to fail because they had time limits that were previously ignored. In retrospect, I should have made this behavior opt-in.
Since then, a timeFactor option was added to increase time limits. But this is not an ideal solution because the user probably just wants to ignore the time limits altogether. To that end, I propose that you add a config option called float.ignoreTimeLimits and make it true by default. Then document the option to let users know if they want to use time limits. I think in most cases users don't care about the time limit in a cloud environment.

Change is available in nf-float 0.4.4


Support symlink on directories

Fix https://github.com/paulmillr/readdirp/issues/150

Any luck? :-)

Merged. Thank you. Required an adjustment to fix error when the result path doesn't exist.

@paulmillr Excellent! Thank you.


[7192] - Remove lead school UI from support console

Context
https://trello.com/c/VYZvyAli/7192-remove-lead-school-and-related-from-support-console
Changes proposed in this pull request
Trying to go to the lead schools UI, either through the support console navigation, or directly in the browser, will no longer work.
Guidance to review
Important business

[x] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[x] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[x] Do we need to send any updates to DQT as part of the work in this PR?
[x] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

We probably need to look into address this bit

Closing as it is superseded by https://github.com/DFE-Digital/register-trainee-teachers/pull/4498


102 review and change information architecture

Starter of what this could look like. 5 is a bit of an awkward number but in the absence of being able to implement the menu it's a good reference.

This isn't entirely ready as we need to make a lot of pages - and I'd still like to implement a proper menu so that the home page can just promote the benefits of the kit - but could work as a placeholder to work towards (separately, I'm not sure if we need more things in the footer like the OGL licence).

Alt with updates page in footer and pages changed to half - this might be more achievable for now

Option with button - though this has required some custom css since for some reason the button won't show properly

option with what's new

Page is continuing to iterate to have the button and what's new text
I'd still like the bottom part to be about the value of the kit #50  but that content is still waiting and I also wonder if we need to have a section entirely in white rather than grey with cards on it?

Not quite convinced of the tag component for "What’s new" (the tag component gets overused I think!) - however about a plain heading instead to match the other cards?
Could also list some other things in the box which aren’t just the most recent release?
Quick sketch:

Not quite convinced of the tag component for "What’s new" (the tag component gets overused I think!) - however about a plain heading instead to match the other cards?
Could also list some other things in the box which aren’t just the most recent release?
Quick sketch:

Yeah fair enough and tbh trying to get the tag to work involved some contorting of code which is probably never good!
Defo this could be a starting point while we build up the benefits (which I think is what should actually replace the sections underneath it)


classList + polyfill error

After  44e875c79059322821916ebaefaa43cd2d2c9c9a
i got errors in elem.classList.add(classes[i]); if i have already polifylled array.
See example (see console)
https://jsfiddle.net/Illiax/ad3quksn/9/
I don't know if i this is intended or not.

can anybody reproduce this issue?

IE Edge:
https://jsfiddle.net/ad3quksn/10/
SCRIPT5022: InvalidCharacterError
File: sweetalert2.min.js, Line: 1, Column: 9860

Fully reproducible on latest chrome (mac)

Something strange here, I just tested in all Windows browsers and still can't reproduce this :cry:
:beer: for anyone who can fix this invisible for me issue

Ok, so this issue appears to be user error, as seen here, you shouldn't be doing what you're doing: http://stackoverflow.com/a/948379/1375989
Fix:
if (!Array.prototype.contains) {
    Object.defineProperty(Array.prototype, 'contains', {
        enumerable: false,
        writable: true,
        value: function(element) {
            return !!~this.indexOf(element);
        }
    });
}
if (!Array.prototype.last){
    Object.defineProperty(Array.prototype, 'last', {
        enumerable: false,
        writable: true,
        value: function() {
            return this[this.length - 1];
        }
    })
};

Nice research @samturrell ! You're awesome, as always.

And thanks for also giving me advice :)


QueryTemplate in docs is incorrect

the docs incorrectly state
await new RAGApplicationBuilder()
.QueryTemplate('My own query template')
the correct setting is below
await new RAGApplicationBuilder()
.setQueryTemplate('My own query template')

Thank you for pointing this out. Updated documentation.


Update and fix errors in the asset request process

Fix : request from member to staff - update filter by category
Change the interface request asset of member, staff

Fixed : request from member to staff - updated filter by category ( done )

Change the interface request asset of member, staff (done)


Cannot be completely uninstalled

Hi,
I uninstalled watchman via HACS.
The watchman directory in custom_components has been deleted.
The sensors have been deleted.
I no longer have any reference to watchman in HA and yet I get this message when HA starts up:
2023-09-27 17:21:09.211 ERROR (MainThread) [homeassistant.helpers.event] Error while processing template: Template<template=(  Watchman report Missing Entities: {{ states.sensor.watchman_missing_entities.state }}  {%- for item in state_attr("sensor.watchman_missing_entities", "entities") %}    <ha-icon icon='mdi: {%- if item.state=="missing"-%}cloud-alert' {%- elif item.state=="unavail" -%}cloud-off-outline' {%- else-%}cloud-question' {%- endif -%} > {{ item.id }} [{{item.state}}]  {{item.occurrences.split('/')[-1].split(':')[0]}}  {%- endfor %}) renders=2>
So if you have an idea, I'll take it!
Thx

I even deleted the db of HA ... I'm going crazy ...

That looks like the template used in the UI markdown card example. Do you happen to have added that to your dashboard?

Yes, that's exactly it.
Yes, I've completely deleted it, that's what's so strange.
I don't unterstand to be honest ...

I even searched in .storage just in case ... and nothing.

Problem solved
In fact you have to reboot several times HA.
I don't know why or how but the error disappeared after a second reboot ...

Yes, I've completely deleted it, that's what's so strange.

Deleted what?
The markdown card was still in the Dashboard.
Since you have not deleted it - each time you opened the view some errors were logged. As expected.


pipelines: update image to use for standalone

N1 machine is costly and about to be deprecated. We are recommending to use new machine type.
Reference: https://cloud.google.com/compute/docs/general-purpose-machines#e2_machine_types

/lgtm
/hold
You can unhold when you think it's ready


[BUG] Fix bug of vis-cam

Motivation
Fix bug in #654 , support gram-cam==1.3.7.
Modification
Fix bug in #654
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[x] CLA has been signed and all committers have signed the CLA in this PR.

close due to #656


Shared library not found

Hey all,
I'm trying to run LLaMPPL in a Colab notebook and I'm getting the following error upon following the installation instructions and running an example.
Traceback (most recent call last):
  File "/content/LLaMPPL/examples/constraints.py", line 1, in <module>
    import llamppl as llp
  File "/content/LLaMPPL/llamppl/__init__.py", line 1, in <module>
    from .llama_cpp import *
  File "/content/LLaMPPL/llamppl/llama_cpp.py", line 67, in <module>
    _lib = _load_shared_library(_lib_base_name)
  File "/content/LLaMPPL/llamppl/llama_cpp.py", line 58, in _load_shared_library
    raise FileNotFoundError(
FileNotFoundError: Shared library with base name 'llama' not found

I suspect this is downstream of the -e flag in the pip install but I haven't been able to fix it.
Perhaps it's a scikit-build issue?
Any thoughts?

My guess based on what you have said is you need to install llama.cpp. Here: https://github.com/ggerganov/llama.cpp. I have not tried so your mile may vary.

It is, in fact a scikit-build issue, and the workaround described here does not work.
@alex-lew how have you been able to get this repo working on a new machine? Let's say, on a Google Colab instance.

Hi there, sorry I missed this! @postylem was able to get things set up using
conda create -n TEST python=3
conda activate TEST
git clone --recurse-submodules git@github.com:probcomp/LLaMPPL.git
cd LLaMPPL
pip install scikit-build
python setup.py develop

Does that work for you?

More specifically, on a new machine, the following is what worked for me

setup (assumes the machine has gcc installed, else might need conda install -c conda-forge gcc)

conda create -n TEST python=3 scikit-build
conda activate TEST
git clone --recurse-submodules git@github.com:probcomp/LLaMPPL.git
cd LLaMPPL
python setup.py develop

put LLaMA model weights in LLaMPPL/vendor/llama.cpp/models dir

convert weights as instructed here

# obtain the original LLaMA model weights and place them in ./models
ls ./models
65B 30B 13B 7B tokenizer_checklist.chk tokenizer.model

# install Python dependencies
python3 -m pip install -r requirements.txt

# convert the 7B model to ggml FP16 format
python3 convert.py models/7B/

# quantize the model to 4-bits (using q4_0 method)
./quantize ./models/7B/ggml-model-f16.bin ./models/7B/ggml-model-q4_0.bin q4_0

Then run an example (when prompted, enter model weights path vendor/llama.cpp/models/7B/ggml-model-q4_0.bin)
python examples/infilling.py

Confirming that the above method works! Thanks @alex-lew and @postylem, closing this issue.
For posterity, Colab specifically will throw an error attempting to clone submodules over ssh. If anyone is trying to run this from Colab, you'll need to change the .gitmodules file to clone over HTTPS instead.

@jagilley
you can also run ssh-keygen on the Colab machine and then add that key to you GitHub account. I've done that in the past to clone via ssh on Colab.  There's probably others who have written steps out for that ... e.g. found one here.

@postylem yeah I tried that, but ran into some other problems. Oh well, seems like there's workarounds either way


[AIRFLOW-1353] Standardizing string type in comments

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1353

Description

[X] Here are some details about my PR, including screenshots of any UI changes:
Within comments, str and string were being used to describe the same type. This PR changes all of those instance to be str to follow Python types. In addition a few functions were missing a :param or :type here and there, so those have been added.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
No need for testing, comment changes only.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2404 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2404      +/-   ##
=========================================
+ Coverage   69.27%   69.3%   +0.03%
=========================================
  Files         146     146
  Lines       11224   11224
=========================================
+ Hits         7775    7779       +4
+ Misses       3449    3445       -4

Impacted Files
Coverage Δ

airflow/operators/python_operator.py
98.11% <ø> (ø)
:arrow_up:

airflow/operators/postgres_operator.py
100% <ø> (ø)
:arrow_up:

airflow/operators/jdbc_operator.py
0% <ø> (ø)
:arrow_up:

airflow/operators/slack_operator.py
0% <ø> (ø)
:arrow_up:

airflow/operators/mysql_operator.py
100% <ø> (ø)
:arrow_up:

airflow/operators/presto_check_operator.py
0% <ø> (ø)
:arrow_up:

airflow/hooks/hdfs_hook.py
32.5% <ø> (ø)
:arrow_up:

airflow/macros/hive.py
38.7% <ø> (ø)
:arrow_up:

airflow/operators/http_operator.py
93.1% <ø> (ø)
:arrow_up:

airflow/operators/mssql_operator.py
0% <ø> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e414844...5257fd1. Read the comment docs.

@msumit @mistercrunch

@Derrreks this must be an arduous task to do :).
The diff lgtm, but I'll let a couple of more folks to review it. cc - @bolkedebruin @criccomini @r39132

@bolkedebruin @criccomini @r39132 can this get a second look?

Was fixed in https://github.com/apache/incubator-airflow/pull/3857, so this can be closed.

Indeed, thanks


HELP: Editing/running python code in docker jetson-inference contanier with VS code

Hi,
I am trying to open/create code in docker jetson-inference in VC code, but I am not ther taht I coudi edit/create and run python code contained in Docker.
I have installed Docker and Remote contanier extension VS Code, but I am really serching the propper way to do this.
Any advice?
Thank you.

Hi @mmatesic01 , it's recommended to put your Python code in a docker mounted directory, so your code persists outside of the container.  The docker/run.sh script takes a --volume argument that allows you to mount a directory from the host into the container.   For example:
$ mkdir ~/my_code
$ touch ~/my_code/my_script.py
$ docker/run.sh --volume ~/my_code:/my_code

Your code will then show up at /my_code inside the container, and you can edit it from outside the container.

Hi dusty,
I am getting closer to what I want. I corected the commands above to my environment.
And I can see the listed file in my container in my VS code. But when I open it it is shown as empty and read-only, altough file outside container has contents.


Fix display of 1-qubit initialize instruction in mpl drawer

Summary
This fixes incorrect formatting of the initialize instruction in the mpl drawer with 1 qubit.
Details and comments
This fixes an issue from the discussion for PR #4669 where the formatting for the display of the 1-qubit initialize instruction was incorrect. The reference test includes the 1 and 2 qubit initialize and the reset instruction.
Previous and New

Thanks!


Yank<EMAIL_ADDRESS>

This version had incorrect compat bounds specified for a dependency, so it usually doesn't work.
-> https://github.com/JuliaRegistries/General/pull/60944

There is a conflict


wasm-bindgen output missing an export for one method of two with the same name

Describe the Bug
wasm-bindgen generated javascript contained an export named '__wbg_buffer_24f0cc96e872e2fe' but not one named '__wbg_buffer_85e60d809f6cd4e8', and the generated wasm references both.
Steps to Reproduce
Check out this commit: https://github.com/kyren/gfx/commit/043fec9bd77f0cfdad430a823df29c1ab824e84e
If you have nix you can run ./web_test/build.sh, otherwise just do the steps in the script:
cd to 'examples' and run:
cargo build --release --target=wasm32-unknown-unknown --bin quad --features gl
then cd .. and run wasm-bindgen like so:
wasm-bindgen --target no-modules --no-typescript --out-dir ./web_test ./target/release/wasm32-unknown-unknown/release/quad.wasm
Serve the web_test folder (serve.py serves on port 4000 if you have nix) and load index.html, and you will see:
LinkError: import object field '__wbg_buffer_85e60d809f6cd4e8' is not a Function
Expected Behavior
Definitions for both __wbg_buffer_85e60d809f6cd4e8 and __wbg_buffer_24f0cc96e872e2fe should be included in the exported javascript, or the wasm should only reference the exported one.
Actual Behavior
When building in release, there is a missing function definition and a javascript "LinkError".  Also there is a somewhat misleading error message:
`WebAssembly.instantiateStreaming` failed. Assuming this is because your server does not serve wasm with `application/wasm` MIME type`

(It does say "Assuming", but it still threw me off for a bit).
Additional Context
This only happens in release, and according to IRC discussions with @alexcrichton it seems to be linker related and potentially a rustc bug?  Enabling LTO apparently is a workaround, as is compiling with the 'cdylib' crate type instead of 'bin'.

For some follow-up, this should be fixed upstream in rust-lang/rust at https://github.com/rust-lang/rust/pull/60526.
The bug here is sort of subtle but has to do with the linker. The problem is that the __wbindgen_describe_* symbol for the WebAssembly::Memory::buffer API was missing from the final wasm binary, so wasm-bindgen didn't generate bindings for that method. (this is the __wbg_buffer_85e60d809f6cd4e8 symbol, the __wbg_buffer_24f0cc96e872e2fe is a buffer property accessor for a differnet type).
The WebAssembly::Memory::buffer API is "special" because it's only called internally by js-sys and it's also in a different object file codegen-wise. Because of ThinLTO in release mode the code for the method itself is inlined into Uint8Array::view, which means that the object file containing the descriptor for the __wbg_buffer_85e60d809f6cd4e8 is never actually referenced directly.
Linkers don't actually include object files in archives unless a symbol is referenced, so the archive of js-sys didn't have its object file included which contained the descriptor for __wbg_buffer_85e60d809f6cd4e8. Typically this is handled by passing flags to the linker in the cdylib crate type to export more symbols than lld would otherwise, but these flags weren't passed for the binary crate type.
The fix in https://github.com/rust-lang/rust/pull/60526 is to pass the flags for all crate types, meaning that even for the binary crate type we'll forcibly export the descriptor symbols.

Just a heads up, the fix has just reached stable :tada:

Thanks for the heads up! I think this is fixed to the best of our ability so I'm gonna close this.


Upload Image to user craches app

Describe the bug
The project/solution Crashes When i try to upload a image to the profile
To Reproduce
Steps to reproduce the behavior:

Go to 'Accounts'
Click on 'Upload Image'
See error

Expected behavior
The image is uploaded if we restart the solution (RUN) but crashes on the process
Desktop (please complete the following information):

OS: W10
Browser Chrome
Version latest

Can you verify if the directory of the blazor application is not write protected?

https://user-images.githubusercontent.com/19993596/116515160-d6288180-a8c3-11eb-95b0-6776be979066.mp4
I'm running VS as Admin. I haven´t get the chance to debug, i can help you on the weekend probably...
I't seems like a bug, please check the video.
best

Could you check what is the exact error message you get in the browser console - developer tools?
Also, please try to logout and login again, there might be an issue of the expired or not available user. Try this first.

Hi,
Logout->login with full admin user.
Tried to upload an image.

I am really not sure of this issue. No one else have reported this. I tested it right now. Seems fine for me. Maybe try to update your mudblazor package in the project.
https://user-images.githubusercontent.com/31455818/116526521-4ef50100-a8f7-11eb-904e-4bf230a267d0.mp4

Yes, i've updated 3 packages, including mudblazor.
hum... so it could be and mudblazor issue?
i will try to downgrade.
thanks

I cannot say that it is a mudblazor issue, as it actually works for me. But mud components show up as errors in your console. Not very sure.
Please try to run the application on different browsers without caching it.
Also, you could try to clone this repository instead of using the nugget package, to check if it works. Let me know.

I've cloned the repo and run it and still crashes. I did not update anything.

I've never used blazor+webassembly and i'm not able to debug...
Using framework 5.0.4


show correct age & display time to next birthday

The "age" column does now show the correct age if it is a forthcoming birthday. I also changed the right column to display the time to the next birthday (also if it is in the next year).

Thanks @thomd! :sparkles:

The "age" column does now show the correct age if it is a forthcoming birthday.

Can you please give me an example where the current implementation fails? I cannot reproduce it.

if I add a birthday of 01.Oct and 31.Oct, then both have the same age as of today (which is 10.Oct).
birthday [master] > birthday -n "foo" -d "01/10/2000"
info  Inserted successfully

birthday [master] > birthday -n "bar" -d "31/10/2000"
info  Inserted successfully

birthday [master] > birthday
┌─┬────┬──────────┬──────────┬───────────┐
│#│Name│Birthday  │Age       │           │
├─┼────┼──────────┼──────────┼───────────┤
│1│foo │01 October│15        │10 days ago│
├─┼────┼──────────┼──────────┼───────────┤
│2│bar │31 October│15        │in 20 days │
└─┴────┴──────────┴──────────┴───────────┘

I'd like to have them showing their age of today.

Ah, got it! The current implementation only shows the age the person has after his birthday.
But your idea is good. I will test it out.
In the meantime, please add yourself as contributor in package.json.

Hey @thomd! :star:
I checked your changes. I'm not so happy with in a year snippets. It may happen that I forgot to tell Happy Birthday but I see it next day and it's better to see there a day ago instead of next year.
And for the age column, is it possible to show the age and the age after birthday too?
Something like this:
18 → 19

That means the person turns 19, but currently they are 18.
Thanks! :dizzy:

@thomd Sorry it took so long to merge this. I pushed some fixes and :ship: 1.1.0. :tada:


Check for equal exposures across channels

This PR fixes #110, and was split from #160 (started by @ieivanov).
This change checks for equality of exposure time across channels. If the exposures are not equal it uses the exposure associated with State0 and TODO: warns the user.
This initial implementation only applies to 3D birefringence acquisitions. TODO: the final implementation should apply to all birefringence acquisitions.

Codecov Report

Merging #162 (c6180d9) into main (ea102ac) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   11.08%   11.06%   -0.02%
==========================================
  Files          44       44
  Lines        5965     5972       +7
==========================================
  Hits          661      661
- Misses       5304     5311       +7

Impacted Files
Coverage Δ

recOrder/plugin/workers/acquisition_workers.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Hi @ziw-liu , I've peeled this PR off from Ivan's larger PR, and I think this will be a good first issue for you to tackle.
Reading #110 and #160 will be good places to start, and we can can work together on Monday to move this forward.
You'll be able to test almost all of this without microscope hardware, so I think this issue will be a good forcing function to help you get a local test environment setup.

Changes with last commit

Lifted the exposure check to the PolarizationAcquisitionWorker._check_exposure method.
Acquisition settings is now a property of PolarizationAcquisitionWorker.
Lifted the checking and acquiring actions to the PolarizationAcquisitionWorker._acquire method.

TODO
Flash warning in the Napari GUI.
Offer GUI interface for setting exposure?

Offer GUI interface for setting exposure?

To avoid in-the-weeds GUI stuff you could use a very simple input statement like this:
https://github.com/mehta-lab/recOrder/pull/160/commits/9792dc4433d1a95ffce3707a92da619ee4a531a4
Completely up to you.

To avoid in-the-weeds GUI stuff you could use a very simple input statement like this: 9792dc4

What I was concerned about was that the user may not pay attention to the command lines when operating in Napari. So I think a visual notice in the GUI is necessary, and we should then choose between notifying them to set in MM and offering an input box somewhere in the Napari window.

Yeah I see what you mean. I'm leaning towards just a warning message...no need to provide extra input options if MM already provides the interface IMO.

On second thought: If we make sure that the user sees a notification on the Napari window, then is it even safer to throw an error and exit the worker without proceeding with assumptions about the user's intentions?

I lean towards a warning instead of an error in this case. Presumably the user the user wants some sort of acquisition to happen if they've hit "Acquire"...and I think a sensible default (use State0's exposure) together with a warning is a good solution.

When the recOder-napari changes the MDA exposure times, the new exposures are updated in the Micro-manager MDA window, but in not updated where the recOrder-napari reads the acquisition settings from. A second acquisition worker after the first warning (and setting equal acquisition times) will still detect inconsistent exposures.

If we do not intend to fix the current MDA updating behavior, do we want to throw an error and abort the acquisition worker instead of sending a warning?

Branch that only sends a warning: exposure-check-warning-only

throw an error and abort the acquisition worker instead of sending a warning

I think this is a good plan. Thanks Ziwen.
Extra context for Ivan/Shalin in case they read this later:

setting MDA exposures from pycromanager created bugs that would be very confusing to the user (e.g. all of the exposures would be equal, but we would still get unequal exposure warnings because MM/MDA is caching the exposures somewhere).
since we're planning to remove acquisitions from recOrder in 1.0.0, we decided to simplify our solution and give an error if the user requests an MDA with non-equal exposures.

Looks great! Just tested locally, and everything is working as I would expect.
I made a small update the error message.
@ziw-liu I approve...you can let the tests pass then merge.


Update build and version numbers for recent patch.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.
Whenever possible python packages should use pip. See https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@decarlof, when you open a pull request, the template and bots give you a todo-list for updating the feedstock.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: python >= 3 should not contain a space between relational operator and the version, i.e. python >=3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@decarlof, this PR will publish the updated spefile. I guessed that the patched version requires python >=3. Please update if this is not the case.

@carterbox I see this only now. I closed mine. Yes we need python >= 3


[meta] Recline => Portal.JS

Recline.js will rename Portal.js, get upgraded and broaden to be a data portal framework (from being a "data explorer" framework).
Overview
What

Recline[.js] will rename to Portal.js
Be upgraded from ~2012 JS approach to datasets and visualization to a modern one (e.g. React, new graph libraries, frictionless for datasets).

A lot of this work has been done at Datopian over last 5y. So this will mainly involve integrating that existing work see e.g. https://tech.datopian.com/data-explorer/ https://tech.datopian.com/views/ etc

evolve from pure dataset visualization to being a frontend framework for data portals (i.e. "presenting" datasets either individually or a full catalog)

Why

Recline is (definitely) showing its age and is need of an upgrade. A lot of this work has been done (e.g. at Datopian) and we can now merge this in.

Recline was created in 2012-2014 as a library "for building data applications in pure Javascript and HTML". Its main use (and purpose of development) was use in CKAN. It has been great there but it's showing its age.
A lot of development has taken place in ecosystem since then that we can take advantage of e.g. React, Vue, lots of new charting libraries etc.
A lot of development done at Datopian to update Recline e.g.

Frictionless Views
"New" Recline-like stuff built around this see e.g. https://tech.datopian.com/views/ and e.g. https://tech.datopian.com/data-explorer/ (this latter is a direct Recline replacement)

https://github.com/datopian/datapackage-views-js
https://github.com/datopian/data-explorer

It's time to merge this work in. (This work proceeded in parallel at the time because we weren't managing Recline).

Broadening the focus: Recline as data explorer can now be done mainly with external libraries so core is small. This core data visualization is an essential part of a frontend data portal framework. ... And there is a need for data portal frontend framework (see e.g. https://tech.datopian.com/frontend). And finally

Recline was a data exploration and visualization toolkit. However, external developments mean a lot of the core of Recline is now existing elsewhere e.g.

Frictionless for the dataset library and model
Frictionless Views and Vega for declarative graph language
React for the render library.

This means what was old Recline is actually quite small.

Nevertheless this core is an essential part of any data portal system.

So why not expand it to be a full data portal frontend framework (instead of having e.g. a separate portal framework that uses Recline as a library.)

Meanwhile at Datopian we have been built at least three iterations of a frontend framework since 2016 and we can merge this work with Recline.

https://github.com/datopian/frontend (built for the datahub.io v2 launched in 2016/2017)
https://github.com/datopian/frontend-v2 (the evolution of this to converge with CKAN developed in 2019-2020)
https://github.com/datopian/portal.js (2020-2021). This is the third iteration (and likely what we directly merge with Recline)

In summary: let's broaden Recline to be a complete portal (frontend) framework

Rename? Portal.js is a clearer more descriptive name.

How

Merge https://github.com/datopian/portal.js with recline and rename recline to portal.js
(Medium term) merge other related repos e.g.

[ ] Merge https://github.com/datopian/datapackage-views-js

[ ] Merge https://github.com/frictionlessdata/datapackage-render-js

[ ] Merge (?) https://github.com/datopian/data-explorer

Acceptance

[x] Clear description of what we are doing and why. DONE. See this issue
[x] This repo is renamed to portal.js DONE. It is now named portal.js
[x] Existing recline codebase is preserved in a branch of similar so others can keep using DONE. see https://github.com/datopian/portal.js/tree/recline
[x] existing portal.js is merged in DONE. Merged in

Tasks

[x] Add an issue about what we are doing
[x] Rename current main/master to recline @risenW Done https://github.com/datopian/recline/tree/recline
[x] merge current portal.js (with history) into recline as main branch Done https://github.com/datopian/recline/pull/521

[x] configure github to serve main as default branch Done https://github.com/datopian/recline/branches

[x] move portal.js to portal.js.bak or similar @risenW Done https://github.com/datopian/portal.js.bak
[x] rename recline to portal.js @risenW
[x] Fix cypress test issue in merged repo @risenW Done See https://github.com/datopian/portal.js/pull/524
[x] Tidy up issues @rufuspollock

[x] Enable discussions
[x] Close all old issues (and/or move to disucssions) DONE

[x] Merge in portal.js issues @rufuspollock DONE. Don't think there are any important ones right now.

@risenW can you fix the cypress tests or should we just leave those?

@risenW can you fix the cypress tests or should we just leave those?

Sure, on it

FIXED. All done.


No support for delay, space or dividers in sequence charts

Being able to separate parts of a sequence is extremely valuable, plantuml has ... ==divider == and |||.
Is there any intention to support this sort of functionality in the future, lifelines would also be useful but I can live without those if there is some sort of spacer.
Thanks for the work on dataflow so far, I am liking the syntax and find its easier to do what I want than finding plantuml suddenly swaps from a sequence chart to a UML/graphviz style one!
cheers
kevin

Thanks for your suggestion and kind words! :)
I'll look into it, but at a quick glance it looks like something specific to sequence diagrams, which actually is just a "bonus output" for the DataFlow tool, which primarily focuses on DFDs. However, my colleague knows a lot more about DFDs and something like this might be useful there as well, so I'll ask.
/Oskar

Sorry, but this will not be included in DataFlow. I think the feature you're requesting belongs in a sequence diagram and that it's outside the DFD scope.
I guess you could do some hack with trust boundaries but that's probably not what you are looking for. Perhaps the best thing would be to create two separate diagrams and then group them in the document or wherever you are displaying them?
Thanks again!


Can we start contributing

Description
Wanna make it a fun thing,
So if you guys are open for contribution
Domain
Other
Type of Contribution
Others
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of bhai-lang.

Hey,
Yes, we are open for contribution. Looking forword for more creative PRs.

@ankitchouhan1020 Awesome initiative guys, I am sure this will go viral soon, I just shared it with 150+ devs

Hello sir,
I want to start contributing in this project
How can we start contributing?? As of now I'm not able to understand where can I help you? Can you pls help in making it clear?

Hi @GargDivanshu, look for help-wanted or good-first-issue tags.
You will need some compiler design knowledge for contribution in the language. Otherwise you can contribute in docs or web app.