Add light/Dark mode toggle button

Is your feature request related to a problem? Please describe.
I wanted to add Light / Dark mode toggle button
Describe the solution you'd like
Using javascript add dark and light mode toggler
@pranshugupta54 Kindly assign me this issue under SWOC S4 label.

Hey @raghav1482, we can surely go with making themes. Not directly with javascript but using themes from daisyui or tailwindcss directly.

okk i'll do it

Hey @raghav1482, any updates?

Kindly add SWOC S4 label on the issue sir

@pranshugupta54 please assign with me this issue

@annu933 | @Ahd-Kabeer-Hadi, did you guyz setup the project locally?
If yes, then you'll need to implement theme using either daisyui or MUI and add Theme for whole

@pranshugupta54 yes setup is done.

We have a new issue created for this.


Feature/COMM-2236  health check screen

@ivanzusko please add a screenshot of the app

If there are no problems:

If there are problems with some endpoints:


Conda env issue

Setting up Conda (Linux_GPU.yml) gives the error
ResolvePackageNotFound:
  - pyzmq==16.0.2=py35_1

Can you provide us additional information to investigate the issue?
Which environment are you trying to setup?
Which Linux_GPU.yml file are you using?

Closing this issue for now. We are going to add a new requirements.txt file for this ND. Thanks :)


how to edit image's property?  such as: quality, width, height

https://github.com/mooz/node-pdf-image/pull/21/commits/50ee40945cc25a7e47482d3030d5b65c1e52ac93

The quality flag doesn't seem to do much for me, the image contained in my test PDF is of very high quality but it comes out heavily pixilated even at medium sizes using the linked options.

We should be using the -size tag to specify an input size but it's ignoring it.

Many ImageMagick options must come after the filename, see this example http://stackoverflow.com/a/6605085
But the code currently lists them all before the source file.
(These are known as Image Operators
I will likely submit a PR for this shortly

The PDFImage 'class' takes a second options parameter.  You can use it like this:
const pdfImageOpts = {
  outputDirectory: path.join(__dirname, './wmReports/images'),
  convertExtension: 'jpg',
  convertOptions: {
    '-colorspace': 'RGB',
    '-interlace': 'none',
    '-density': '300',
    '-quality': '100'
  }
};

const pdfImage = new PDFImage(file, pdfImageOpts);

pdfImage.convertPage… // etc. etc..

The quality flag doesn't seem to do much for me, the image contained in my test PDF is of very high quality but it comes out heavily pixilated even at medium sizes using the linked options.

almost 3 years later but did you find any solution to avoid the pixilized output image?

The quality flag doesn't seem to do much for me, the image contained in my test PDF is of very high quality but it comes out heavily pixilated even at medium sizes using the linked options.

almost 3 years later but did you find any solution to avoid the pixilized output image?

Had the same problem, the -density parameter resolved my case


Add queryapi to goreleaser

Previously we created the queryapi component but we didn't add the relevant goreleaser config.  This PR corrects that.

@dejanzele @pavlovic-ivan can you have a look?

@Mo-Fatah i can take a look


Doesn't work with keycloak 20.03 and openID

I get the following error when authenticating on keycloak 20.03
error: "unauthorized_client"
error_description: "Invalid client or Invalid client credentials"
This is mainly because client Secret is not being passed in the /token URL

OK, I'll check first @pavs94

hi i suddenly cant use this, is eveything okay?

for version 1.1.1 changes, there are changes for keycloakOnClick only

npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! A complete log of this run can be found in:

try you do

delete node_modules
npm install

npm ERR! code ETARGET npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting npm ERR! notarget a package version that doesn't exist.
npm ERR! A complete log of this run can be found in:

try you do
delete node_modules
npm install
@AlmondMilk4242

in me it's ok, try to use the example of this realm

I get the following error when authenticating on keycloak 20.03 error: "unauthorized_client" error_description: "Invalid client or Invalid client credentials" This is mainly because client Secret is not being passed in the /token URL

in me it's fine, try to use the example of this realm


Prettify backported dataset names

Backported dataset names are naively transformed using underscore method. This can result in very long and unreadable names. For instance

Long-term wheat yields - FAO (2017) & Bayliss-Smith (1984) -> long_term_wheat_yields__fao__2017__and__bayliss_smith__1984
Life satisfaction – Eurobarometer (2017) -> life_satisfaction__eurobarometer__2017
Age-adjusted female suicide rates, 1950-2005 - WHO (2005) -> age_adjusted_female_suicide_rates__1950_2005__who__2005

Such names can hinder their discoverability in the catalog (and addressing in general). Dataset names are not standardized in grapher schema (e.g. source is appended to dataset name, but not always) which makes automatic transformation nearly impossible. Any transformation would therefore have to be manual. We have only about 800 backported datasets (those used in at least one chart) which is not that much, but new datasets could be problematic.
Possible solutions:

Don't bother with nice underscored names and instead make them discoverable by their original name from the catalog
Create manual mapping to dataset & table while trying to keep the name as short as possible (we might also group different datasets into a single one with multiple tables)
Create manual mapping, but only strip source name
Change grapher dataset model and split name into dataset_name and source_name

Solution 2 example:

Long-term wheat yields - FAO (2017) & Bayliss-Smith (1984) -> long_term_wheat_yields
Life satisfaction – Eurobarometer (2017) -> life_satisfaction
Age-adjusted female suicide rates, 1950-2005 - WHO (2005) -> age_adjusted_suicide_rates / table age_adjusted_female_suicide_rates

Solution 3 example:

...
Age-adjusted female suicide rates, 1950-2005 - WHO (2005) -> age_adjusted_female_suicide_rates_1950_2005

Who would benefit from nice names though? We don't show them anywhere besides catalog. Perhaps it makes sense to wait until we start using backported datasets and then decide.
(I've started renaming datasets to get a feel for it here)

This is probably worth its own whole discussion, maybe with a spreadsheet of examples and some popcorn 🍿
At the dataset level we could probably sort out short_names that work for 90% of the cases pretty well. At the variable level, it becomes a whole different ball game. We should discuss a different strategy than just mangling the name there.
This type of addressing should also be part of API discussions.

To discuss with @Marigold:

relevant for the API and addressing scheme
table per variable vs table per dataset

From short discussion with @danyx23:

The naming of historical backported data is less important than the naming of new data that goes through the grapher fast-track (uploaded via admin). Perhaps instead we should prioritise adding short_name and version fields to the MySQL model and the admin.

From chatting with @danyx23:

Backports could be left with "bad" names, as long as there aren't non-OWID consumers
Non-OWID consumers should get things via the browsable data catalog, when it's ready

For backports, we should probably not use short names for this data

We should still add short_name and version to the grapher MySQL model for datasets and variables, and set them at data upload time (and on ETL-to-grapher step)

Closing this issue, replacing with:

#314


aursync: don't check versions when only downloading (-w)

Version checks are mainly done for building, and serve little purpose when only build files are downloaded.

It's easier than having it there for those who want it, and disable it with -v when not. A nobuild switch should also only disable the actual build, not the rest of the script.


Multiple loads of the same bundled file

Hi, I have the following gulp task:
gulp.task('default', () => {
  return gulp.src(['./test.js'])
      .pipe(sourcemaps.init())
      .pipe(concat("bundle.js"))
      .pipe(sourcemaps.write('./'))
      .pipe(gulp.dest("./"));
});

and the following structure:

And the following situation:
Index.html includes script bundle.js and has 2 frames, bundle.js is included as well as in frame1.html and frame2.html.
You can see in the picture above that there is no source maps for bundle.js in frame1 and frame2, the problem is when debugging in Chromes dev tool, debugger breaks in bundle.js for frame1.html and frame2.html, for index.html it breaks in source map test.js..
test.js looks like:
(function(){
    var x = 10;
    console.log(x);
})();

I am not sure is this is a bug within dev tool or within gulp-sourcemaps plugin.

Your gulp task looks correct, but there are too many unknowns to how your project is setup. Please reproduce your issue in (integration.js)(./test/integration.js)

I have problem running that test, but project setup is simple. I have one html document which includes bundle.js (obtained with gulp) and in the body one iframe (src property is another html document which also includes bundle.js and have nothing more). I made this project just for testing purpose, to simplified situation and see if bug exists in that case.
index.html:

frame1.html:

that's all, i have tried to upload but error with supported type appeared.
Thanks

Closing until an actual full example is provided. Make a new repo or add a test to this project.

Link to the repo:
https://github.com/milanstamenkovic/gulp_sourcemaps_test

This is likely a chrome debugger problem.  Closing.


Update issue templates - Bug

Updating an issue template so that we can see it in Zenhub

Looks great!


HSEARCH-3406 Fix (and test) exceptions not being thrown because we call "log.someMethod();" instead of "throw log.someMethod();"

https://hibernate.atlassian.net//browse/HSEARCH-3406

Pull Request Test Coverage Report for Build 1

4 of 6 (66.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 86.665%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/model/impl/JavaBeanPropertyModel.java
0
2
0.0%

Totals

Change from base Build 58:
0.1%

Covered Lines:
11393

Relevant Lines:
13146

💛  - Coveralls


Editor 3D WASD Navigation often stops working

Godot version
4.0 (I believe after one of the latter betas; both RC 1 and RC 2 has this bug)
System information
Ubuntu 22.04
Issue description
When navigating using the WASD keys, sometimes the camera keeps moving after I unpress a key. After that, everytime I enter free-look (right mouse button), the camera will just keep moving, unless I press the key corresponding to the other side. The only way to restore the free-look behavior, as far as I know, is to restart Godot.
This bug started happening the same time as another annoying GDScript editor bug: sometimes when I press "CTRL+S", the editor inputs the letter "s" instead of saving. I'm not sure if those two bugs are related, but I thought it was important to note this, since both bugs started happening at the same time (on the later betas).
Steps to reproduce
Just navigate around a 3D scene with free-look until this happens.
Minimal reproduction project
Any project will do. I can't create a reproduction project for this because it happens randomly in any project, although it happens often.

What is your keyboard layout, I suspect it may be related to it?

English (US, alt. intl.)
I never had this problem before in any other Godot version, though; and my keyboard layout is pretty common.


Website updates MVP

Problem statement
We have a ton of content to roll out in the epic this issue is linked to, but we need to make some large, baseline changes first in order to make the rest happen.
What you need to know

The below AC will help us get the content/layout ready for the homepage and top three main sections in the new IA.
Let's try to reuse/remix as much existing content as possible. We can clean up and make the bigger improvements we have planned out in coming sprints.
Existing work has been done on /contact in #4913 in this branch
Working Figma File
IA Mural

Acceptance criteria
Homepage

Content that covers high-level information about the product and drives folks to learn more or contact us.

[x] Section that describes what ReportStream is (the current Hero may still work here)
[ ] Section that describes what we do for API senders + links to sender-focused overview under /product
[ ] Section that describes what we do for STLTs + links to receiver-focused overview under /product
[x] Section for "where we're live" map, links to /where-were-live
[x] Section for contacting us that links to /contact
[ ] Create a layout for above content sections

Product section

Content that helps a prospective user understand what RS does and how it can help them. The existing /how-it-works/overivew pages will most likely work here with minimal changes.

[x] Product index page (?)
[x] Overview page for API senders
[x] Overview page for CSV senders
[ ] Have solid ideas for nav dropdowns/sidebars/etc we may need for this content

Resources section

Content that helps a user understand the more technical aspects of the project (ex the programmer's guide). We can consolidate and edit existing guides from /how-it-works/* for the MVP.

[x] Resources index
[x] Existing guides are linked somewhere, including CSV guides/documentation
[x] Programmer's guide PDF is linked from somewhere
[x] Have solid ideas for nav dropdowns/sidebars/etc we may need for this content

Support

Content that helps a user understand common problems and reach out to get help.

[x] FAQ page (can use existing content from #4913)
[x] Support page (can use existing content from #4913)
[x] Have solid ideas for nav dropdowns/sidebars/etc we may need for this content

ETC

[x] Find something to do with the existing CSV user guides. If we launch this before we fully sunset that feature, that content needs to live somewhere.
[ ] Catalog necessary redirects from existing URLs + create follow-on engineering ticket

To do

[x] Put together a suuuuuper-basic wireframe (LIIIIIKE THE MOST BASIC EVER) to help visualize how this'll come together
[x] Draft content outline in this doc
[ ] ...

Content outline is done and ready for review over here and is also housed under Issue # 5856

FYI - #5826 (Engineering ticket) should be worked at the same time!

Content outline is saved in the above AC but for your convenience, I've also included the Shared Doc again here just in case.

@drew-usds @BerniXiongA6 Working branch can be seen by checking out git checkout experience/5826-IA-shuffle or in the browser by navigating to our repository and selecting experience/5826-IA-shuffle from the branches dropdown.
Here is a link to where our working nav changes will live; when using new-ia feature flag, we will overwrite the navigation with a whole new navigation so we can really tinker with things. This will only overwrite public pages since below it we are still conditionally adding pages for logged in members.

Updates for sprint review 7/5

Content is good for /resources and /help center

Pages are starting to be built out

Work still in progress on home page and /product section

Andrea working on image ideas for home page

Will need to carry this card over into the next sprint, but will be able to get this work published this coming sprint along with #5826 and #5859

Hey @drew-usds I've updated the PPT deck with links to the content outline -- for "Product overview" section and "Support" overview section, see Versions B for links to both shared docs. Happy to update any other pieces of content for the MVP if needed, LMK. Thanks! cc: @a-chappelear

Worked with @drew-usds to get the /resources page templated out so edits can be made in JSON rather than JSX

Am working on further cleanup on the templates for /resources and am duplicating some of that work over to /product and /support.
Also have moved copies of our existing content to these new directories and appended Ia to thier constants so we can use them/make any needed edits without altering anything currently in prod.

Todo for 7/14:

[ ] Get Andrea's local env fully set up to be able to push/pull (was blocked by Docker setup, signed commits)
[ ] Get Kevin's help with /product section with mixed tsx and md content
[ ] Kevin's help with redirects ex /contact to /support ... how can we make this work to future proof changes to paths as /support grows?
[ ] Kevin's help: page titles working across templates/tsx/md files
[ ] Kevin: set up tests for routes to new pages (so we can eventually make this PR)
[ ] Andrea: paste in content to /product, format as MD (but don't worry about template perfection yet)
[ ] Andrea: paste in content to /built-for you, and format as MD (and don't worry about template perfection yet)
[ ] Drew: Template work on /product, /support
Is responsive
Is valid HTML (right Hx, right nesting, labels, accessible, etc)
Steps towards Figma mockups but doesn't have to be pixel perfect

Follow-on work

[ ] Template work on /product content Andrea is working on


Discovering types stored in linked frameworks

I have following layout:

Proto.framework with public protocol, say, MyProtocol
Impl1.framework that has Proto.framework as pod dependency and presents public class Impl1 that conforms to MyProtocol
Binary build of Impl1.framework that stored somewhere else, called Impl1Binary.framework
iOS application project that has both Proto.framework and Impl1Binary.framework as pod dependencies; it has access to Impl1 class and has own implementation of MyProtocol called DefaultImpl

So, in the end I have two classes that conform to MyProtocol. I would like to observe them with Sourcery, for example, in next manner:
{% for type in types.based.MyProtocol %}
    {{ type.name }}
{% endfor %}

Not so much surprising, I can only see DefaultImpl mention in generated source. What I can see here is that Sourcery is aware of MyProtocol, but is not aware of any implementations aside of specified project (that is fully logical). So my question is if there is any way to specify compiled frameworks as definition sources?
NB: There was some discussion here, but I'm not sure what was the outcome.

There was no outcome of previous discussions. There were some tips of how this could be possibly done technically for iOS frameworks, not sure about 3rd party frameworks, but there were no progress on that. You'll have to use annotations or other ways to help Sourcery understand code that it does not scan.


Declare scripts through API

Hi
First of all, I'm sorry for putting here rather a question than an issue. Or, maybe a feature request.
We have a package.json file with following scripts:
  "scripts": {
    "start": "run-p grunt:serve js:watch",
    "grunt:serve": "grunt serve",
    "js:watch": "grunt shell:jspm_watch"
  },

Since grunt:serve and js:watch tasks do not have much value for the end user, we'd like to move them into the internal script and make package.json like so:
  "scripts": {
    "start": "node start.js",
  },

Where start.js will call needed tasks:
const runAll = require('npm-run-all')

runAll([
  'grunt:serve'
  'js:watch'
])

Now, of course, the script will complain about unknown grunt:serve and js:watch scripts.
And that's where I've stuck.
Is it possible to declare additional scripts through the API of npm-run-all, by not declaring them in package.json?
I assumed that options.packageConfig and options.taskList are for that:
runAll([
  'grunt:serve',
  'js:watch'
], {
  taskList: [
    'grunt:serve',
    'js:watch'
  ],
  packageConfig: {
    'grunt:serve': 'grunt serve',
    'js:watch': 'grunt shell:jspm_watch'
  }
})

But, as turned out, they are rather for something different, which I can't get even while looking into test files.
I wonder, is it possible to inject scripts values into npm-run-all somehow, to avoid putting them into package.json?
Thanks!

I have kind of the same scenario here...
My employer has around 20 websites in 20 repos.
In order to avoid to duplicate the "default/basic npm scripts", I made a private npm module which group the most common tasks with their default settings into a basic CLI...
In my private npm module's package.json I have few script that I'd like to call from my CLI source code...
But the only scripts found from within my CLI are the one located in the package.json of the current website, not from the package.json of my CLI utility...
Is there a way to do this ?
It would be great to be able to run tasks in parallel.
Thank you

I was able to make it work by performing a
process.chdir("./node_modules/company-private-tools/");
before calling
runAll(["clean:site", "clean:common"], {parallel: true, stdout: process.stdout});
Hope it helps others.

Well, that's hacky solution, and the solution itself only partially related to this issue.
Also, note that doing process.chdir() on occasion can break a lot of things if something runs in parallel and relies on it.


Global image for external

This PR is enabling any possible image to be fed to external tests.
User can set it via EXTERNAL_AQA_IMAGE variable. Eg EXTERNAL_AQA_IMAGE=my.local.repo/on/hdd/fedora:40. Any legal  subset -eg just fedora is allowed.
The properties model was  quite enhanced to work properly in multi distroenviroenment. This may be also good base for future localhost runs. I had tested all features on default ubuntu based temurin and on fedora:39. To tune it for centos/rhel will be quite a fun. But full tuning should not be part of this PR.
The build_all.sh is not affected by this change.
this is currently draft, becasue for some reasonnot yet found by me, the mounted jdk in fedora ... is not here. The default works. I wil continue to work on this, but any feedback appreciated.
Close #5555

@judovana thanks for the work on this PR. Those enhancements are nice. They are addressing two different issues would it be nice to separate the PR into two ( one for global image, one for common property)? Also as we talked recently to keep our workflow organized and ensure each change is properly  tracked and reviewed, could you please open two issues and reference them in the respective PRs?

The two parts can not go separtely in parallel. Maybe the properties part can go in first, but the geenric images depends on it. I would rather keep it togehther. They do not have sense one by one. (the btohering with first, if the second will not go in or if it will need major changes is not worthy)
Sure, I will create an issue. Thanx a lot for reminder.

Few external tests passes on few jdks on few images.... I will start to roll up some test matrix on this but tbh not sure how it is complete... Many external tests needs forking for newer jdks, also tuning up the depndencies will be fun....
What is required to double check to make this pass through?

What is required to double check to make this pass through?

Based on the changes, for  temurin default image I would suggest to run a build with tomcat tests. The test job doesn't need to pass. It should be good as long as the generated Dockerfile looks good. Running locally it should be good with default or EXTERNAL_AQA_IMAGE=my.local.repo/on/hdd/fedora:40. For openj9 external tests you may need @LongyuZhang help to run a few grinder to ensure it works for openj9.

What is required to double check to make this pass through?

Based on the changes, for temurin default image I would suggest to run a build with tomcat tests. The test job doesn't need to pass. It should be good as long as the generated Dockerfile looks good. Running locally it should be good with both default and EXTERNAL_AQA_IMAGE=my.local.repo/on/hdd/fedora:40. For openj9 external tests you may need @LongyuZhang help to run a few grinder to ensure it works for openj9.

The default image(s) were not changed, and generated docekrfile remains identical!-) tat was moreover primary goal during this PR. The only chnage which is affecting the defaults is the search in /opt first, but it did not have anmy siode effect as far as I was able to check.  I will try tomcat.

jacoco jdk21: fails coorectly (needs different jacaoco sources: https://ci.adoptium.net/view/Test_grinder/job/Grinder/10846/console
15:36:05  [ERROR] Source option 7 is no longer supported. Use 8 or later.
15:36:05  [ERROR] Target option 7 is no longer supported. Use 8 or later.

(todo, fix??)
jacoco jdk17:  https://ci.adoptium.net/view/Test_grinder/job/Grinder/10842/tapResults/
jacoco jdk11:  https://ci.adoptium.net/view/Test_grinder/job/Grinder/10845/tapResults/
jacoco jdk8:  https://ci.adoptium.net/view/Test_grinder/job/Grinder/10844/tapResults/

jacoco jdk21: fails coorectly (needs different jacaoco sources: https://ci.adoptium.net/view/Test_grinder/job/Grinder/10846/console
15:36:05  [ERROR] Source option 7 is no longer supported. Use 8 or later.
15:36:05  [ERROR] Target option 7 is no longer supported. Use 8 or later.

(todo, fix??)

https://github.com/adoptium/aqa-tests/issues/5575

Tests for CRIU failed, looks like the container os and package install was not aligned after the change. It tries to use apt-get install inside ubi image (hyc_grinder_43087).
16:44:37       [exec] STEP 1/23: FROM sys-rt-docker-local/ubi8-with-criu/linux_x86-64-ubi8-criu:latest
16:44:37       [exec] STEP 2/23: ENV RESULT_COMMENT="IN CONTAINER(not-as-root/podman)"
16:44:37       [exec] --> fb4b96608433
16:44:37       [exec] STEP 3/23: ARG CRIU-UBI-PORTABLE-CHECKPOINT_TAG=
16:44:37       [exec] --> b2cd85d4a861
16:44:37       [exec] STEP 4/23: RUN apt-get update 	&& apt-get install -qq -y --no-install-recommends software-properties-common 	&& apt-get install -qq -y --no-install-recommends gnupg 	&& add-apt-repository ppa:ubuntu-toolchain-r/test 	&& apt-get update 	&& apt-get install -y --no-install-recommends git wget unzip tar curl   	&& rm -rf /var/lib/apt/lists/*
16:44:39       [exec] /bin/sh: apt-get: command not found
16:44:39       [exec] Error: building at STEP "RUN apt-get update 	&& apt-get install -qq -y --no-install-recommends software-properties-common 	&& apt-get install -qq -y --no-install-recommends gnupg 	&& add-apt-repository ppa:ubuntu-toolchain-r/test 	&& apt-get update 	&& apt-get install -y --no-install-recommends git wget unzip tar curl   	&& rm -rf /var/lib/apt/lists/*": while running runtime: exit status 127
16:44:39
16:44:39  BUILD FAILED
``

Thanx! Will elaborate!   If I do not  resolve this  until your timezone,  can you please provide mre details how to reproduce it locally?

@LongyuZhang   I'm trying something like:
sh build_image.sh zookeeper 21 openj9 ubi jdk full linux_x86-64 default 0

And you seems to be right, it is ARG IMAGE=docker.io/library/eclipse-temurin:openj9-full and then of course the apt is called.   Do you also see wrong ARG_IMAGE  pelase?

it seems the parameters are wrongly passed:
+ print_image_args /home/jvanek/git/aqa-tests/external/criu-functional/dockerfile//jdk/ubi/Dockerfile.openj9.full criu-functional jdk openj9 ubi full linux_x86-64 0
+ local file=/home/jvanek/git/aqa-tests/external/criu-functional/dockerfile//jdk/ubi/Dockerfile.openj9.full
+ local test=criu-functional
+ local os=jdk
+ local version=openj9
+ local vm=ubi
+ local package=full
+ local build=linux_x86-64
+ local base_docker_registry_dir=0

Nope, that was correct. Already call to build_image.sh  is wrong:
+ generate_dockerfile /home/jvanek/git/aqa-tests/external/criu-functional/dockerfile//jdk/ubi/Dockerfile.openj9.full criu-functional openj9 ubi jdk full linux_x86-64 default 0

You can see, the version of jdk is missing, abnd that is shifting the args:
https://github.com/adoptium/aqa-tests/blob/2ee9988dedef51534a8afdb15827167e389443b6/external/build_all.sh#L41
It seems, that: https://github.com/adoptium/aqa-tests/pull/1601/files  was originally traversing also through versions, but that was reemoved, and the removal was incorrect

@LongyuZhang  now it behaves correctly. May you try please?

Tested with the updated commits, the ubi with apt-get issue got fixed. But got another failure:
13:09:20  /aqa-tests/TKG/scripts/getTestenvProperties.sh --repo_dir /aqa-tests/openj9 --output_file /aqa-tests/testenv/testenv.properties --repo_name OPENJ9
13:09:20  Check sha in /aqa-tests/openj9 and store the info in /aqa-tests/testenv/testenv.properties
13:09:21  OPENJ9_REPO=https://github.com/eclipse-openj9/openj9.git
13:09:21  OPENJ9_SHA=216f34562d5b1a7253f8dbb33773c5bb8adfde27
13:09:21  Generating criu checkpoint
13:09:21  /test.sh: line 42: make: command not found
13:09:22  -----------------------------------
13:09:22  criu-ubi-portable-checkpoint_test_0_FAILED

I suspect it is because the make install on ubi got affected with the changes somewhere.
We don't run criu test locally since it requires special host machine settings done by our infra team, so we mainly use internal jenkins for it.

Tested with the updated commits, the ubi with apt-get issue got fixed. But got another failure (hyc_grinder_43142):
13:09:20  /aqa-tests/TKG/scripts/getTestenvProperties.sh --repo_dir /aqa-tests/openj9 --output_file /aqa-tests/testenv/testenv.properties --repo_name OPENJ9
13:09:20  Check sha in /aqa-tests/openj9 and store the info in /aqa-tests/testenv/testenv.properties
13:09:21  OPENJ9_REPO=https://github.com/eclipse-openj9/openj9.git
13:09:21  OPENJ9_SHA=216f34562d5b1a7253f8dbb33773c5bb8adfde27
13:09:21  Generating criu checkpoint
13:09:21  /test.sh: line 42: make: command not found
13:09:22  -----------------------------------
13:09:22  criu-ubi-portable-checkpoint_test_0_FAILED

I suspect it is because the make install on ubi got affected with the changes somewhere. We don't run criu test locally since it requires special host machine settings done by our infra team, so we mainly use internal jenkins for it.

Hello! Thanx a lot! Which test (set of tests) is this?
https://github.com/adoptium/aqa-tests/pull/5553/commits/5f8891585f459882e8f8a9c7eea3c43771f1b2aa#diff-87fdb6d51b2e87bfa2c194fd3e8792a626657904ae658445c0739d27abece3f3   do not seem to be messing up with make. What is more important, I do not see make as depndence in any  criu tests, nor in generic packages in this PR, nor  before this PR.  So very likely I have overlooked some logic
cat   external/*criu*/test.properties | grep make
#nothing

However it is really obvious that criu tests are using make:
external/criu-functional/test.sh:make $1
external/criu-portable-checkpoint/test.sh:make $1
external/criu-ubi-portable-checkpoint/test.sh:make $1

Do you know wha(why it) was pulling it before? Does it now still work with ubuntu?
I had added the missing depndence. if you can try, it wouodl be awesome. TYVM!

The failed test is criu-ubi-portable-checkpoint_test. Rerun grinder to compare, results are shown in attached figure (left is master, right is this PR). It shows two problems here:

Originally the package for this test is git wget perl, and make installed automatically as a dependent. The perl got lost after this PR change.
This PR change added unzip tar curl which is not needed for this test. Considering each criu test runs on JDK_verisions&platforms&machine_os combos 90+ times for each build, I think the newly added generic_packages in this PR will not make our external tests more efficient. Take this case as an example, If one package in generic_packages is not need by a single CRIU test, it will take longer test time. @ShelleyLambert @llxia any suggestions? Thanks.

Thanx a lot for heads up!

The failed test is criu-ubi-portable-checkpoint_test. Rerun grinder to compare, results are shown in attached figure (left is master, right is this PR). It shows two problems here:

Originally the package for this test is git wget perl, and make installed automatically as a dependent package. Though we can add make in the list, the perl got lost after this PR change for some reason.

Both perl and make are now installed - https://github.com/adoptium/aqa-tests/pull/5553/commits/cecf32367af67f04556ea093ee4f0485d7913b54#diff-87fdb6d51b2e87bfa2c194fd3e8792a626657904ae658445c0739d27abece3f3 - so it is fixed and runs, ok?

This PR change added unzip tar curl which is not needed for this test. Considering each criu test runs on JDK_verisions&platforms&machine_os combos 90+ times for each build, I think the newly added generic_packages in this PR will not make our external tests more efficient. Take this case as an example, If one package in generic_packages is not need by a single CRIU test, it will take longer test time and increase test failure risk with extra packages. @ShelleyLambert @llxia any suggestions? Thanks.

I'm in absolutel same  situation. I'm running many tests in combinations and on many versions, s I know what you mean. And I agree that soemtimes very small change one place when may lead to huge impact in such multiplied run.
I quite disagree that installation of tar or curl may lower stability of tests.
However I have absolutly no strong prefference. If you, @sophia-guo  or well anybody in the team have issues with that, I will happily remove the https://github.com/adoptium/aqa-tests/pull/5553/commits/5f8891585f459882e8f8a9c7eea3c43771f1b2aa#diff-3e2f7b162bce7417355d4fe0f18e6366b69e6abe5e73356f863274d3a4f9c04b and will copypaste those to tests  where they originallyc come from.
I think it is quite a good idea to have some shared known enviroenment with some shared known  deps, but I'm also well aware that such feuture may  bloat.
Thanx again!

I'm not sure how long it takes for the utils installation( each util may take different time). It may be worth comparing with the whole test process time  to see if it costs. Considering tests are usually running parallel in building farm we might not need to take account in our combos. Speaking of efficiency, we might also need to think about the maintainability, flexibility and scalability.
Regarding stability, adding unnecessary installations could affect test due to network problem or server being down, which make test false negative.
I would prefer at least split this PR to two different ones as I mentioned before. Open an separate issue to discuss the generic_packages one.

Sure! Fair enough! I will keep the logic in, but will move the git wget unzip tar curl back to original owners.

ok, the shared deps dropped. I hope I had not missed any. If so, that it was not intentional. Will take second eye after some timeout. Looking to that commit (https://github.com/adoptium/aqa-tests/pull/5553/commits/4c6217e210b5f97e13cdae37cdf20e036a05aa2b) I really dont like that :)

ok, the shared deps dropped. I hope I had not missed any. If so, that it was not intentional. Will take second eye after some timeout. Looking to that commit (4c6217e) I really dont like that :)

ok, make double check and found miss in wycheproof and missed scala. Now it looks correct. Added few grinders:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10966/console
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10967/console
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10968/console
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10969/console
All looks good

The pacakges were moved to global scope. As you could have noticed, all - except your usecase - is passing.
Those two changes can not be separated - In the moment I'm want to support generic containers - thus at least fedora, rhel, centos and ubuntu, I need to specify packages for each of them, becasue the names and sets of packages are different.  Hand in hand with it,  I do not want to duplicate declarations of most common packages.
Hardcoded ubis are most terrible to adjust to the generic mages, because they were if-else-hardcoded to original code without much thinking.  @LongyuZhang  please provide reproducers  to your case. I would really love to fix it. It seems it is the only  failing one.

When I'm in maste the test you are pointing out dies:
export BUILD_LIST=external/criu-ubi-portable-checkpoint ; export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk" ;  export TEST_JDK_HOME=/usr/lib/jvm/java-11-openjdk-<IP_ADDRESS>.8-2.portable.jdk.el.x86_64/
make compile
...
    [exec] DOCKERIMAGE_TAG nightly has been recognized.
     [exec] No credential available for container registry, will proceed without login...
     [exec] sudo podman pull ${env.DOCKER_REGISTRY_URL}/ubi8-with-criu/linux_x86-64-ubi8-criu:latest
     [exec] Error: parsing reference "${env.DOCKER_REGISTRY_URL}/ubi8-with-criu/linux_x86-64-ubi8-criu:latest": invalid reference format

When it is in this pr then it dies absolutely the same.

From that I'm guessing that the issue will be in function getMatchingPackagesKeys() { and/or function getImageOs() { , because I'm reading OS here and it seems the os is linux_x86-64-ubi8-criu. The packages declaration is (fedora|ubi|rhel|centos)_packages="git wget perl make"  and if anything would go ok, the .*(fedora|ubi|rhel|centos).* matches  linux_x86-64-ubi8-criu so something went wrong in this particular usecase, where hardocded UBIs are present. Msot likely the EXTERNAL_AQA_IMAGE, which is workaround for that if-ubi-if-critu  unhappy blocks, was not set in time. But withotu reproducer od full verbose log, I can just guess
Actually the tes which you are unhappy with, have all packages installable on all tried OSes. I can mititgate now the issue by redeclaring it, but it is jsut moving the problem to criu-portable-checkpoint or to  improbable  future when criu will be tested on system with different package names

the
 sh build_image.sh  criu-functional 17 openj9 ubi jdk full linux_x86-64 linux_x86-64-ubi8-criu  0

correctly, although I dont know if it is at least close to reperoducer

Re: https://github.com/adoptium/aqa-tests/pull/5553#issuecomment-2380434107
With the new update, the test passed (hyc_grinder 43691).
Since the CRIU tests have passed, I will leave this PR for @sophia-guo @smlambert  to check on their side then. Thanks.

Thanx! I'm happy reading from crystal ball was successful!-) I 'm still very curious how to reproduce it locally, because I'm afraid hiding it behind "generic_packages" the issu is hidden. As the criu tests are heavily bounded to single container, the real issue maynever popup again, but still:(
@LongyuZhang  if you please can share, how can i run that particular tast, I t would be highly appreciated. TYVM!!

The reason we set this test differently is because our internal machines don't have access to packages needed by CRIU, so the infra team pre-built CRIU into the container. If you have access to packages to build CRIU in ubi, you can follow the CRIU instruction to build the ubi base image for this test. Thanks.

@smlambert  @sophia-guo  hello! Anything more is needed?

I have started reviewing this PR, but have stopped for now and will put a hold on it while I look at the current functionality versus what we used to have. I believe we had this functionality of using other images/OSes 'previously' but must have 'regressed'. (related: #3363).

Right you are, there was such a support, but it needed IFs for every distribution. I had made it as general as possible. There is only one real if left, which distinguish apt and dnf systems. I would like to get rid also of it no longer run (another property in test.properties I guess). But this PR is already too big, so not (yet)added.
In addition,   that support expected to pass each  part of container URI as it separated aprts, which - considering number of those parts - was  very uneasy to read, use or enhance.

decalred -> declared fixed. Any luxk with  build_all.sh ?

fixed waht seemed to be fixable...
@smlambert  Any news on "the hold" ? It keeps to be missing feature...
@sophia-guo  You are ok with it as it is, or any more hints?
Thanx a lot both!

Anybody alive around?

@judovana is it possible to run a grinder for the final check? All former grinders are obsolete.

https://ci.adoptium.net/view/Test_grinder/job/Grinder/11615/console

Is green... Locally I tried also with EXTERNAL_AQA_IMAGE=fedora:41 and EXTERNAL_AQA_IMAGE=centos:stream9 passed.
As part as https://github.com/adoptium/aqa-tests/issues/5575 I will be doing extensive 3D matrix of external_test/os/jdk
Do yuou think EXTERNAL_AQA_IMAGE woould be worthy to be used in grinder?

Do yuou think EXTERNAL_AQA_IMAGE woould be worthy to be used in grinder?

There is a strong desire to avoid bloating the already large set of Jenkins job parameters, which is why we have previously used EXTRA_DOCKER_ARGS to pass in alternate images.
I am presuming with some modification we could still utilize the EXTRA_DOCKER_ARGS parameter to either check for --image or support other build args via parse_docker_args, and set EXTERNAL_AQA_IMAGE from that.

Fair enough. I agree with bloating being undesired. Lets settle it down then for now, and if it works, then +1 for some --iamge like approach. TY!

https://ci.adoptium.net/view/Test_grinder/job/Grinder/11636/console


Robonect V1.1.0 only 35 entity; vacuum missing

Describe the bug
Today I installed this HACS-Integration for Gardena R40Li (2015) and the actual Robonect-Firmware V1.3b. I followed this guide/video:
meine-digitale-welt.de/robonect-integration
After restart the Integration has only 35 entity.
I tried different things: I deleted the Integration and the the HACS-Download. I restarted the system, not only HA. Then I folowed all the steps, nothing changed to before.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All entity - specially Vacuum - are generated.
Screenshots
Robonect

MQTT-Explorer

HA-Integration

Entity vacuum

Log information
If possible activate debug logging on the component as mentioned below.
https://www.home-assistant.io/integrations/logger/
logger:
  default: warning
  logs:
    custom_components.nexxtmove: debug

Additional context
System

Please let me know what additional information you need.
Thank you

Hi, normally the MQTT sensors are added when a new topic is published on the broker.
Could you provide me with the home-assistant log? or activate the debugging as described in the readme?
Thx

Problems always have a solution ;-)
Will let you know

MQTT Subscribing to automower/#
Can you confirm your robonect MQTT topic is "automower" ? :-) I think this is why it doesn't add any mqtt sensor... your configured topic will be named differently ;-)

Yes I think so
automover

And in MQTT-Explorer also

Are there enough messages?
And I think, there is no change from o to 0.
In my firtst try, I have changed the name in HA (maybe in Robonect). Then I deleted all, maked many restrarts and installed new.
Thanks

automower != automover :-)

I mean, when you have set up my integration, you have let the mqtt topic to the standard automower one, and your topic is called automover.
So you need to either change it in robonect, or in the HA setup...

I am so blind!!! 121 entity
Thank you very much for your help.


Shouldn't it be Time.hour, not Time.minute?

Nice project btw. Was just skimming the code to see how it worked, and saw that you were comparing the sunrise hours with the current minute... not sure that was quite what you intended ;)

Yes, thank you very much. I was just testing the function wasn't going to be waiting for hours :D


Missing modifier characters in YAML frontmatter

Using :heavy_check_mark: in YAML frontmatter should render (U+2714, U+FE0F), but seems to only be rendering the first character. Using it anywhere in the normal editor renders it correctly. If adding the emoji using another method both characters are rendered, and it appears correctly as ✔.

This doesn't seem to be the case with all emoji made from multiple characters :person_curly_hair: 🧑🦱 seems be added correctly.

Might be that your Font doesn't show the Emoji Correctly. The Plugin shouldn't differentiate in what type of block it's in.

I don't think it's a font thing:

Using it anywhere in the normal editor renders it correctly.

Are you sure?
For me it will always be the black and white, singe character, Version

However it seems to be an issue with obsidian - not your plugin. The same behavior happens when you copy and paste the emoji into the frontmatter. Feel free to close this.

Using it anywhere in the normal editor renders it correctly.

Are you sure?
For me it will always be the black and white, singe character, Version

Maybe it's a platform thing then? It definitely works in the editor for me. Tried with the default theme too.

You could try the new Editor in the latest Obsidian Version. It might fix some stuff.
I will close this for now.


Reverse JDB connection

Situation
In the current documentation the JDB connects to the VM listening for a debugger on the the Virtual Schema's side. This is a so called "forward connection". While that concept is easier to understand for users, it has multiple drawbacks -- all revolving around the fact that for this to be useful you need to be able to see the listening port from the outside.
And that means the port needs to be forwarded from the UDF container and through any virtual networks that might be involved.
This is definitely too much trouble for a simple task like debugging.
A better solution is to use a reverse connection, because UDFs are designed so that they can connect to the outside world.
Acceptance Criteria

Remote debugging documentation is rewritten to use reverse connections
An short introduction explains the concept of the reverse connection and why it is used here

Solved with 1.10.0.


Support GPT3.3 Completion Models

Add support for GPT3.5 completion models (davinci_002, davinci_003). It also supports 3, but the response parser fails so I have commented out those models in the models.py file.

LGTM. Merge when ready.


tests: clean imports and add search test at resource level

this test demonstrates that https://github.com/inveniosoftware/invenio-app-rdm/issues/284 goes to invenio-records-resources level

Agreeing with @fenekku and taking into account said test is already in invenio-records-resources I am closing this PR and porting the search alias fix to https://github.com/inveniosoftware/invenio-drafts-resources/pull/63


PostgreSQL psycopg2 error - duplicate key value

...when I run:
poetry run python tools/conv.py

I get this error:
Selected path:  ./data
Database versions OK, converting
Migrating core: ./data/database.sqlite3
Migrating table dbversions
Migrating table accounts
query:
INSERT INTO public.accounts("id", "email", "pass")
VALUES (%s, %s, %s);
data: ('####', None, None)
Traceback (most recent call last):
File "/home/###/lnbits/tools/conv.py", line 92, in insert_to_pg
cursor.execute(query, d)
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "accounts_pkey"
DETAIL:  Key (id)=(####) already exists.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/###/lnbits/tools/conv.py", line 221, in
migrate_core(file, exclude_tables)
File "/home/###/lnbits/tools/conv.py", line 109, in migrate_core
migrate_db(file, "public", exclude_tables)
File "/home/###/lnbits/tools/conv.py", line 150, in migrate_db
insert_to_pg(q, data)
File "/home/###/lnbits/tools/conv.py", line 100, in insert_to_pg
raise ValueError(f"Failed to insert {d}")
ValueError: Failed to insert ('####', None, None)

I'm following @AxelHamburch guide for migration to PostgreSQL, I have this issue when I am using the new LNbits version.

✅ Successfully migrated from SQL to PostgreSQL.
Here's what I did: I went ahead and deleted the old database using the command dropdb . Then, I created a new one withe createdb .

Finally, run these two commands:
poetry run lnbits
poetry run python tools/conv.py

You should see:
✅ Migrated


add support for unix:///var/run/docker.sock hosts

for full coverage of docker envs

feels good. fixed.


 Sort -u removed duplicates. ;)

@6CornerDefender , Good day.  for this week, we have reviewed some cases already, some of them you have linked in this PR, for those left, i made a new pr #6007, would you mind to combine #6007 to this pr for easy audit and process? Thanks.

https://github.com/helium/denylist/issues/3115


DO NOT MERGE (Draft): POC of using ethers.js in the send flow

Description
https://linear.app/valora/issue/ACT-710/timeboxed-poc-using-viem-to-replace-contractkit-in-send-flow
POC of using ethers.js to replace contractkit in the send flow and typechain to create types for the ECR20 contract
Note: chose to do ethers instead of viem after realizing how new viem is and how much functionality is still in beta: https://valora-app.slack.com/archives/C02KBT0DAHJ/p1680210298153949

@jh2oman just fyi the resolution for ethers was needed for a react native specific reason: https://github.com/ethers-io/ethers.js/issues/1316#issuecomment-788844738. This might be resolved in newer versions of ethers or react native, but it's something that's come up in the past here: https://github.com/celo-org/wallet/issues/2050

Hey! Author of viem here. Would definitely love if ya'll considered viem as an integration in the future – viem is a stable library, and is not in any beta. Happy to answer any questions.

@MuckT I actually tried doing a nomspace lookup locally while on this version of ethers and it worked!

Brief ping (from cLabs), would love to know how this is going and any problems you ran into.
Very happy to help you migrate and debug to learn more about Valora's specific dependency on contractkit!
cc @aaronmgdr @dckesler @nicholasguo (for future reference, no action required at this point :) )

+1 on viem the more I look at the happier i am

For example Viem already has support for formatting celo transactions https://github.com/wagmi-dev/viem/blob/e4be25103b84af426283cd2cd91ab3496c120ee9/src/chains.ts#L13

closing since I don't think we plan to merge this, was just a POC.


when using bundler plugin, ruby completion stop working

Hi,
When I active the bundler plugin, my ruby command completions stops working, also any other completions for bundled commands (as guard, cap...) stopped working with the bundle plugin.

@wilkerlucio Is this still an issue? If so, can you be more specific about what you're attempting to do and perhaps give as much information about your environment?


How do we create the [sales].[dbo].[web_clickstreams_hdfs_parquet] table?

In Step 1. of the "Load data" section, the INSERT INTO...SELECT statement fails with the following error message:
Msg 208, Level 16, State 1, Line 1
Invalid object name 'sales.dbo.web_clickstreams_hdfs_parquet'.

I don't see where this external table gets created.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf1b0e77-0f03-7b70-b2e3-26911e49dd47
Version Independent ID: 511793e4-b3c5-3d07-a8e9-bc10b8347985
Content: Ingest data into a SQL Server data pool - SQL Server big data clusters
Content Source: docs/big-data-cluster/tutorial-data-pool-ingest-sql.md
Product: sql
Technology: big-data-cluster
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@tnbarkhouse -- thank you Trevor for your feedback.
@MikeRayMSFT -- Mike, please process this Issue 2498.

@WilliamAntonRohm
Perhaps the earlier H2 section named "Create an external table in the data pool" is the answer?

https://docs.microsoft.com/en-us/sql/big-data-cluster/tutorial-data-pool-ingest-sql?view=sqlallproducts-allversions#create-an-external-table-in-the-data-pool

the error happens after creating the external table, this is when we load into the external table with this script
SELECT wcs_user_sk, i_category_id, COUNT_BIG() as clicks
FROM sales.dbo.web_clickstreams_hdfs_parquet
INNER JOIN sales.dbo.item it ON (wcs_item_sk = i_item_sk
AND wcs_user_sk IS NOT NULL)
GROUP BY wcs_user_sk, i_category_id
HAVING COUNT_BIG() > 100;
Msg 208, Level 16, State 1, Line 1
Invalid object name 'sales.dbo.web_clickstreams_hdfs_parquet'.
Total execution time: 00:00:00.001
to follow the article having Sales database alone seems not not enough, seems we also need one step before loading the data into external table is to create
"sales.dbo.web_clickstreams_hdfs_parquet"
which seems can be created by this sample
https://github.com/microsoft/sql-server-samples/tree/master/samples/features/sql-big-data-cluster/data-virtualization/storage-pool
we need to update the article to include how to create

@MikeRayMSFT -- Mike, please look into this issue 2498.  If you prefer, I will create an Azure Boards work item to track this (and I will then close this issue).

@WilliamAntonRohm if you could create the Azure Boards work item and close, that will be great. I will loop in some PG resources on this thread.

@MikeRayMSFT -- the work item is https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1579589
@tnbarkhouse -- Trevor, I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Portfolio: application deploy

General requirements

Make sure that there are no linter errors
Make sure that you used correct flow (Github flow)
Make sure that you documented your work

Project requirements

Deploy your website using GitHub Pages.
Check the online version of your portfolio and make sure that the page works properly.
Update the README of your repository to include a link to the online version.

Finally, the deployed applicaion of my portfolio is given here

Hi @dagmawiii03,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Prompt to install/launch wear app from mobile

Growth hacking...

https://github.com/joreilly/Confetti/pull/352


Use of Client Hints for Chrome-facilitated testing

Chrome is planning to use client hints to provide traffic labels for each of the testing modes. Do you have any concerns or feedback about using client hints for this purpose?
See https://developer.chrome.com/docs/privacy-sandbox/chrome-testing/ for context.

Some background on your motivation for proposing UA-CH for the traffic labels would be helpful.
Your proposed CH would be low entropy sent alongside the current defaults, yes? Servers should not be forced to opt in via Accept-CH.
sec-ch-ua: "Not/A)Brand";v="99", "Google Chrome";v="115", "Chromium";v="115"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"

sec-ch-ua-sandbox-mode-a: ?1

Probably shouldn't be reflected in NavigatorUAData since a server wouldn't be able to detect the presence/absence of its third-party cookie until processing a request.
Client Hints are only sent on secure requests versus a garden variety header that would be available on all traffic.

new APIs are restricted to secure environments

And just to complete the reference for anyone reading along, existing third-party cookies must already specify both SameSite=None and Secure so will not be present in insecure (e.g. non-HTTPS) contexts.

Would the labels be only accessible through CH?
If so, I understand that an HTTP response has to be sent first with the proper Accept-CH header.
From a header bidding perspective, a bidder may not have had the opportunity to do so before its bidding endpoint is called for a bid request.
Indeed, the header bidding wrapper scripts may be hosted on the publishers' servers. In that case, Adding the Accept-CH header to an HTTP response and accessing the label in subsequent HTTP queries would require changes on the publishers' web server, correct? If so, it looks unlikely for this change to happen at scale.
Would you consider adding the header to all HTTP requests (without the need for the previous HTTP response with Accept-CH header)?

The announcement indicated it would be a "low-entropy client hint." They are safe to send by default.

@rowan-m the initial responses and engagement were encouraging.
We inquired in the recent WICG call, but understandibly that team can't speak to a cross-cutting concern like the testing proposal.
A proposal and a forum in which to discuss it would be welcome.
It is approaching six weeks since you posted these three questions.

Appreciate the comments! We published https://developer.chrome.com/blog/privacy-sandbox-launch/#chrome-facilitated-testing-modes just recently and in there we're now on for providing an update on the testing modes in mid-August where I believe we will be able to provide more clarity on both the form and granularity of the labels.

Updating this issue with the implementation details available on https://developer.chrome.com/docs/privacy-sandbox/chrome-testing/#cookie-deprecation-value
We will not be using Client Hints to send the labels, but instead the current design relies on the presence of a specific cookie to opt-in to receiving the label in an HTTP header or calling a new JavaScript API.
We have also posted an initial Intent to Prototype to blink-dev: https://groups.google.com/a/chromium.org/g/blink-dev/c/8mlWTOcEzcA

Chrome is planning to use client hints to provide traffic labels for each of the testing modes. Do you have any concerns or feedback about using client hints for this purpose?
See https://developer.chrome.com/docs/privacy-sandbox/chrome-testing/ for context.

THATCHAPAN

MACBOOKPRO


How to change blog-name?

Where is the class blog-name specified in the markdown? I can't find it in any of the files, and the blog-name is showing up as "Basic Template". Thank you!

Hello @eigenvivek, welcome to Franklin!
The blog-name is in the layout: https://github.com/tlienart/FranklinTemplates.jl/blob/fed3d61a9f789096b3dae6778c39925dcebda879/src/templates/basic/_layout/header.html ; the CSS is in basic.css: https://github.com/tlienart/FranklinTemplates.jl/blob/fed3d61a9f789096b3dae6778c39925dcebda879/src/templates/basic/_css/basic.css#L45-L57
To change the blog name, you would edit the file _layout/header.html; I would suggest you have a look at this page in the docs to get a clearer idea of how pages are constructed (what's from the markdown and what's from the layout)

Thank you! I figured it out and have converted my website to a Franklin backend. Looks great!


New action, move assigned issues to column in GitHub projects

This action allows assigned issues to automatically move to a new column in GitHub projects.

@alex-page your changes have been merged, thanks for your contribution 👍


OnlineMIS doesn't seem to terminate on complete graphs

Currently OnlineMIS doesn't terminate when given complete graphs with 4 or more vertices. For example, the inputs
K4:
4 6
2 3 4
1 3 4
1 2 4
1 2 3

K5:
5 10
2 3 4 5
1 3 4 5
1 2 4 5
1 2 3 5
1 2 3 4

make the program get stuck in an infinite loop.

Hi, it is not in an infinite loop. The program has a time_limit which is set to 1000 by default.  If you set the time_limit smaller, i.e. --time_limit=0, then it directly converges.


Improve design in various ways and do lots of other stuff

This is unfortunately a large non-atomic PR. But this was the best way for me to get lots of stuff done. See commit messages for more information. A few main changes:

Change mobile navigation to a burger menu
Change right side of header completely
Make it possible to configure colors and other theme things in config.toml
Change routing to remove /r/ and have all internal routes start with /~

Fixes #193
Closes #147
CC #167 #160 #99 #75

We decided reviewing this would be too much work. I asked Julian to check two commits of particular interest. Everything else, eh. It's fine.


lamp-infrastructure fails on varnish due to timeout

Fails to install varnish with commands:
git clone https://github.com/geerlingguy/ansible-for-devops.git
cd ansible-for-devops/lamp-infrastructure
sudo ansible-galaxy install -r requirements.yml
vagrant up
when running the lamp-infrastructure on macOS 10.12 with Ansible <IP_ADDRESS> and vagrant 1.9.1 with "vagrant up" Ansible fails to install Rails:
TASK [geerlingguy.varnish : Install Varnish.] ********************************** fatal: [<IP_ADDRESS>]: FAILED! => {"changed": true, "failed": true, "msg": "https://repo.varnish-cache.org/redhat/varnish-4.1/el6/x86_64/varnish/varnish-4.1.4-1.el6.x86_64.rpm: [Errno 12] Timeout on https://repo.varnish-cache.org/redhat/varnish-4.1/el6/x86_64/varnish/varnish-4.1.4-1.el6.x86_64.rpm: (28, 'Operation too slow. Less than 1 bytes/sec transfered the last 30 seconds')\nTrying other mirror.\n\n\nError Downloading Packages:\n  varnish-4.1.4-1.el6.x86_64: failure: varnish/varnish-4.1.4-1.el6.x86_64.rpm from varnish-4.1: [Errno 256] No more mirrors to try.\n\n", "rc": 1, "results": ["Loaded plugins: fastestmirror\nSetting up Install Process\nLoading mirror speeds from cached hostfile\n * epel: mirror.steadfast.net\nResolving Dependencies\n--> Running transaction check\n---> Package varnish.x86_64 0:4.1.4-1.el6 will be installed\n--> Processing Dependency: jemalloc for package: varnish-4.1.4-1.el6.x86_64\n--> Processing Dependency: libjemalloc.so.1()(64bit) for package: varnish-4.1.4-1.el6.x86_64\n--> Running transaction check\n---> Package jemalloc.x86_64 0:3.6.0-1.el6 will be installed\n--> Finished Dependency Resolution\n\nDependencies Resolved\n\n================================================================================\n Package          Arch           Version              Repository           Size\n================================================================================\nInstalling:\n varnish          x86_64         4.1.4-1.el6          varnish-4.1         1.7 M\nInstalling for dependencies:\n jemalloc         x86_64         3.6.0-1.el6          epel                100 k\n\nTransaction Summary\n================================================================================\nInstall       2 Package(s)\n\nTotal download size: 1.8 M\nInstalled size: 6.6 M\nDownloading Packages:\n"]}
Looks like:  https://repo.varnish-cache.org/redhat/varnish-4.1/el6/x86_64/varnish/varnish-4.1.4-1.el6.x86_64.rpm is inaccessible and there's no mirrors for it to find an alt. Maybe this is just transient?

....and after being offline all day it's suddenly back.

@pgerhardt - Thanks for following up! Yeah, the Varnish repos are maintained by Varnish directly, and from time to time they seem to go unreachable for a little bit.


Remove pledgie.com

Reason: http://pledgie.com/
Alternative? https://www.patreon.com/

Thanks for the letting us know! We'll look for a new donation site, but I'm merging this now so people aren't misled.


Support physical transports via environment variable

Related:
https://github.com/Zondax/corp_wishlist/issues/17
https://github.com/Zondax/42/issues/13

Closing since this would require significant changes in the repo, and it's not useful IMO. The great part about Zemu is that clicks are automated and do not require user feedback. In the case of real transports, we could not click on behalf of the user.


Transparent color not working in background

I want to show toast every second in background. For that i do it's background color transparent. It works proper for redmi but not working for samsung. In samsung, it visible in black color.

Provide more info


Separate the docs more clearly between lower-level Metalium and ttnn

#6482 related issue
Will need to investigate whether this means separate domains, or just serve two sets of documentation under specific paths.
(ex. "two separate github ios")
cc: @TT-billteng @jvasilje

This is done in docs on latest main.


Add onChangeRange count property back

The payload argument was modified in the onChangeRange function and the count property was removed in #146
I can't seem to find a way to replace that property inside the onChangeRange function.

Hi, count is just the total length of items so you can get like this:
<VList
  onRangeChange={() => {
    const count = data.length;
  }}
  >
  {data.map(d => <Component key={d.key} {...d}/>)}
</VList>


ci: migrate from Travis to GitHub Actions

This PR is initiated by @sourcegraph's code change management.
Test

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e200791). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   97.67%
=========================================
  Files             ?        1
  Lines             ?       86
  Branches          ?        0
=========================================
  Hits              ?       84
  Misses            ?        2
  Partials          ?        0

Flag
Coverage Δ

#unittests
97.67% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e200791...eb0d83f. Read the comment docs.


time update applying for both from and to dates in range

When I tried to edit time after selecting both from and to dates, it is updating time for both dates where we expect to adjust time only for from/to date.  Is there a way to disable adjusting the time for both dates at a time? because it causes the confusion.

I just  realized that I was giving lesser date as 'To' date than 'From' date, Hence it was adjusting for both dates. This is cool and it works great.  Thanks


If I want to have a preselected item I need to provide a description

Tests #46587
So far the simple single picker allowed me to have a list of single labels. If I want to have a pre-selected item this is not possible anymore since the QuickPickItem item type forces me to provide a description. We should either make the description optional or make a more complicated OR type which allows to have the description optional if selected true.

Good catch. We should make QuickPickItem.description optional. /fyi @jrieken


Update qa-ui-workflow.yml

add install tcpdump on haproxy for network logs

Will be done as part of the test setup


reduce allocations in model pushing

This makes allocations dramatically slower with caching enabled. With cache disabled allocations are still a little fast but much less extreme than they were before. Both with/without cache see significant performance gains in heavy scenes from this.

I don't know that there's a simple way to further reduce allocations on the uncached side of the code. I think that's the tradeoff we have to make but it should be worth considering there is very little reason to disable the caching.

Uncached is a lot faster now. It was down before on Zen and M1, but this gave a near-30% speedup at my slayer task (Zen3 uncached) so it should be at least comparable to the prior code, maybe faster.

M1 numbers from user: testing
"- Pre-caching patch (I rolled back master to confirm this number is still valid): 64 fps

Current master: 56 fps (cached), 44 fps (uncached)
With new patch: 66 fps (cached), 55 fps (uncached)
so it's an improvement, but not the big one we were expecting"

That 64 to 55 hit without caching is still a bit painful but it's okay i think. Every other arch so far is doing a lot better

Holding steady for Mac users is a reasonable result if it means everybody else gets significant gains :)

Some concrete data:

live ~4381k allocated in a second
this branch ~6063k allocated in a second with caching enabled

Same scene after a minute or so to warm up. Memory usage is higher with the caching of course given that it's stored on the heap as well.

Testing with @keyosk and we found that the weakhashmap is a lot better in the worst cases. Also, it helps keep the heap size in check by collecting values that are cached but not actively used.

In fact, it's so much better at conserving the heap size that I almost think we should just do away with the cache disabling option. The allocations needed for that side of the code make any potential savings completely null.

Ah that's a good point. We could still have some edge cases where the cache needs to be disabled. It seems unlikely but we should keep it there just in case. :+1:

Did 6hr general gameplay on the last 3 commits, strong performance and no unexpected behaviors


chore: tweak initial banner render

Use css instead of JS to show/hide the EJI initialism in the banner. This makes it so we don't have to wait for all of the javascript to load before the page renders the correct content for the screen width.

bump @aledavila when you have a sec!


Add Triggers data in table aws_lambda_function

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

As of now, we are not getting any triggers info in any of the API.


Process swagger file cross reference when generating API review

Swagger file refers to a definition in another swagger file and sometimes this definition in second swagger file might have a schema reference to another definition within same file and this reference will be a local reference. API review parser incorrectly searches for this local reference in first swagger file instead of second file where it's defined.
PR has the fix to correctly refer the swagger file based on the parent reference if current reference path is local.
For e.g. data.json has a reference to 202response definition which is in common.json and 202response has a reference to longrunningoperationresult schema using local reference #LongRunningOperationResult and it's defined in common.json. We need to make sure parser refers common.json when processing #LongRunningOperationResult schema instead of data.json.

/azp run tools - swaggerapiparser

Are there any test we can add for this?


History of milestone changes not reflected

See https://gitlab.home.smart-cactus.org/ghc/ghc/issues/16004. The last comment clearly describes a milestone change but there is no indication of what the milestone was before the change.

We do process milestone changes just like any other change; if other changes create notes, but milestones don't, then that's probably a gitlab issue.
If it is a gitlab "feature" (i.e., the issue isn't going to be fixed), we can of course fabricate "Trac metadata" comments ourselves.


Add Apache JMeter and update Apache Ant

Description
JMeter is widely used in CI/CD to perform tests.
Binary size is roughly 62MB.
Apache Ant updated to 1.10.7 on Linux and Windows.
Pending Mac OS.

Hi @brunoborges, thanks for contribution!
Notes from my side: both Windows and Linux documentations are autogenerated, here is the way how to add them there:

for Windows: please, add JMeter here https://github.com/actions/virtual-environments/blob/master/images/win/scripts/Installers/Validate-JavaTools.ps1
for Linux: please, document JMeter at the bottom of the file https://github.com/actions/virtual-environments/blob/master/images/linux/scripts/installers/java-tools.sh.

    $ jmeter -version

This command doesn't give a nice output for parsing, so I did hardcoded for now.

@AlenaSviridenko changes made to the PR. Thanks for the tip on the regex with grep

Hi @brunoborges,
do you need any help with it? We can can finalize this PR by ourselves but please, file an issue for that.
Thanks!

Closing it up due to no updates in a long time.
Please, feel free to file new issue if JMeter is needed on image.
Thanks!


display datepicker at right side of the input element

Hi,
is their any configuration for display datepicker at right side? . now currenlty it is showing at left side.
i added bellow code
<md-input-container md-no-float ng-style="{'margin-top':'-5px', 'margin-bottom': '0px', 'width' : dp.customWidth, 'height':'20px'}">
    <input type="text" style="height:3px;" ng-keydown="keydownevent($event)">
        <i class="fa fa-calendar" aria-hidden="true" style="float: right;margin-top: -16px;color: #95a6a4;cursor:pointer;" change="selectYear()" moment-picker="dpValue" format="{{dp.dateFormat}}"></i>
</md-input-container>

for reference find the screen shot

Hi @sadashivm,
the picker is appended to the element that contains the moment-picker attribute.
Can you try to move the attribute to the md-input-container directive?
Thanks

I'm going to close this issue since no answer has been provided.


Introduce concept of projectiles

At the moment units deal direct damage without having anything 'flying over' to the enemy unit. (ie a bullet, missile, etc).
I want to have projectiles being spawned, fired to the enemy and on landing inflict the damage.
Acceptance criteria

[ ] Trikes and Quads spawn bullets
[ ] bullets travel at given speed directly (as if it is a line) to destination
[ ] upon arrival only then damage will be dealt
[ ] upon arrival a 'landed' animation is shown. Ie a missile would explode, a bullet will show a different sprite.

Will the damage be dealt to "whatever is in this cell" or the target unit directly?

Whatever is on the cell will receive damage.
On Sat, Apr 11, 2015 at 10:14 PM, Nino v.d. Mark<EMAIL_ADDRESS>wrote:

Will the damage be dealt to "whatever is in this cell" or the target unit directly?
Reply to this email directly or view it on GitHub:
https://github.com/stefanhendriks/dune2themaker4j/issues/70#issuecomment-91920887

Now with pull request merged to use absolute coordinates, we can continue working on this issue. Projectiles will be rendered on the map as expected.

progress so far: https://www.youtube.com/watch?v=o8JFidUmHUs

we can spawn bullets now and have explosions: https://www.youtube.com/watch?v=XglryMQEZjo&list=PLGJc4IZyoBW0rdEfpvgFH2sHiB3JIR-BN&index=2

[ ] facing is bugged
[ ] entityData should be used everywhere (consistently)


Is there a way to change a scene image and reload it?

Hi,
Is there a native way (without using dynamic=True), to change a scene config, changing it's image, and instruct panellum to reload that scene with the new image url? I need it because I am pixel editing some images with python given different factors and user input and I need to reload the scene with the new image that the user is in, at the moment. If the url must stay the same, it could work, but I wanted to change the url to append a dummy urlparams to force the cache reload.
Thanks,

You can use viewer.addScene('currentSceneId', {new config}); followed by viewer.loadScene('currentSceneId');. Using addScene with an existing scene ID will overwrite the previous configuration, and calling loadScene will then reload the scene with the new configuration.

Ahá.
Simple and direct. I didn't know this was the default behaviour. Thanks a lot, I will try it out!


tf.numpy_function in tf.data.Dataset.map causes CUDA_ERROR_OUT_OF_MEMORY after hundreds of epochs

Issue Type
Bug
Source
source
Tensorflow Version
2.10.0
Custom Code
No
OS Platform and Distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.10.6
Bazel version
5.3.2
GCC/Compiler version
gcc 9.3.0
CUDA/cuDNN version
11.8/8.6.0
GPU model and memory
Nvidia Quadro RTX 6000, 25.8G memory
Current Behaviour?
I use `tf.data.Dataset` for my input pipeline as follows:
  1. `from_generator`
  2. `cache`
  3. `shuffle`
  4. `repeat`
  5. `map`
  6. `batch`
  7. `prefetch`

The step 5 call a data-augmentation function where there is a call to `tf.numpy_function` which wraps `scipy.ndimage.rotate`.

After a variable number of epochs (in general more than 100), a `CUDA_OUT_OF_MEMORY` appears and the kernel crashed. If I remove the call to `tf.numpy_function` from the data-augmentation function, I don't have this problem. Note that I don't use `tf.py_function` as it looks much slower.

Standalone code to reproduce the issue
I haven't managed to create a simple reproducer for this bug.

Relevant log output
2022-12-01 02:26:32.244730: E tensorflow/stream_executor/cuda/cuda_driver.cc:796] failed to alloc<PHONE_NUMBER>4 bytes on host: CUDA_ERROR_OUT_OF_MEMORY: out of memory
2022-12-01 02:26:32.299769: W ./tensorflow/core/common_runtime/device/device_host_allocator.h:46] could not allocate pinned host memory of size:<PHONE_NUMBER>4

@RocaVincent,
Could you please try limiting GPU memory growth using any of the methods listed in this guide.
https://www.tensorflow.org/guide/gpu#limiting_gpu_memory_growth
Also tensorflow v2.10 is not compatible with CUDA/CudNN - 11.8/8.6.0. Please take a look at this official doc link for the reference. Thank you!

@RocaVincent,
In order to expedite the trouble-shooting process, could you please provide a complete code you are using. Thank you!

@tilakrayal The code is too complexe and I haven't managed to create a simple reproducer. But I tried the same code with the classical pip install and the error disappeared.


Rendering of poster images (or even the video?!) for Coverr videos not working properly.

The Coverr poster image isn't rendering in the  tag of MediaElement.
From media3p, the following url is returned for the poster image, without a file type:
https://storage.coverr.co/p/IP7iuEu01KxekTusS8zVyC01Z78JZdAzHa
Which is redirected to:
https://image.mux.com/mGiyxU5qOWcqkgntvl37tuUYDIlVwXCZ/thumbnail.jpg?token=eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6InQ5UHZucm9ZY0hQNjhYSmlRQnRHTEVVSkVSSXJ0UXhKIn0.eyJ0aW1lIjowLCJleHAiOjE1OTk3MTExMzAsImF1ZCI6InQiLCJzdWIiOiJtR2l5eFU1cU9XY3FrZ250dmwzN3R1VVlESWxWd1hDWiJ9.mkV0uMnI8NWSfzjZS9fFE9K7GYZqGpexMLszBvNFV6GOphWBCSB3I4VN45ZVB17rErhEz_L7Bijokms0x86xhL2cJ85qdh_5il9EObLsxogtXDW2ArmgCtPGSFITxRtwThBU1TqOd0JoF7CyyGW0NL-0sOg_7Jr6BRGcgPxx_GkzkLAB6nVRXy4ipR4J1tvKx2EN6rC-fg4Mg4Wzy5XIaTjPeS1RW4QW4FnshhYT2ArXYiTGJMf0ipP3gY9EzHrG7Eo80zNmBX23olz-Bgbm4VJSvxEv1G-fu3PKyXH1OmCNfwUmMezpOvsB8DiOPERq1vJwHoHSFUv-RvRAPekzvA

This was debugged and the following was found:
the  tag needs crossorigin='anonymous' and a valid mime type in the source.
The poster needs to be a url and not the poster "object".


Add dialog class names

This will allow you to do something like this:
{{bs-modal title="Hello World" dialogClassNames="foo bar"}}

and have a modal with foo and bar classes added to the dialog.

First, thanks for contributing!
You can already pass a class with the standard class property, see https://github.com/kaliber5/ember-bootstrap/blob/master/addon/templates/components/bs-modal.hbs#L11. This is passed to the .modal element (not the .modal-dialog as in your case). But for styling this would be sufficient I think?
Do you have a use case that really requires setting the class to the .modal-dialog element?

You're right, it makes more sense to put it on the .modal element.
It looks like the when I have a template like this:
{{#bs-modal
class="foo bar"}}
{{! some custom bs-modal-body and bs-modal-footer
{{/bs-modal}}

then foo bar is being added to the base component's DOM, not the wormhole. Confirming w/ jQuery, if I do $('.foo'), the result is div#ember3095.foo.bar.ember-view, and it should be adding the class on #ember-3095-modal.
Thanks for your help, I really appreciate it and love this addon! We're using v0.7.2, FWIW.

We're using v0.7.2, FWIW.

This will probably explain it. I am not sure when this was added, but probably later. It does work with the current 1.0 alpha release! Should also work with the latest pre-alpha version (0.11.3). I suggest you try that with a more recent version!

Ahh, upgrading to 1.0.0-alpha.3 fixed this. Thanks for your help!


Now what??

Thanks for your works, but I dont know what else to do, I have the app on the iphone and I also have the homebridge on the app, but I cannot learn any FR
[2017-9-8 16:27:22] Loaded plugin: homebridge-broadlink-rm
[2017-9-8 16:27:22] Registering platform 'homebridge-broadlink-rm.BroadlinkRM'
[2017-9-8 16:27:22] ---
[2017-9-8 16:27:22] config.json (/Users/danilomarin/.homebridge/config.json) not found.
Scan this code with your HomeKit App on your iOS device to pair with Homebridge:
┌────────────┐
│ 031-45-154 │
└────────────┘

[2017-9-8 16:27:22] Homebridge is running on port 63574.
Discovered Broadlink RM device at <IP_ADDRESS> (34:ea:34:e8:29:cd)
Discovered Broadlink RM device at <IP_ADDRESS> (0d:43:b4:c3:e0:c1)

Push button "Learn" on your iphone (in one of the room in Home app). In log watch data.

I have a problem like this。And I can't find the button “Learn” in the room in Home app。

@dmarinb your logs say "onfig.json (/Users/danilomarin/.homebridge/config.json) not found.". Make sure you setup your config.json
@bg4acd Can you send your config.json please if you're still facing this problem.

Closing, please re-open if you would like help


FrameIncrementPointer Tag Not Updating Correctly in Cine Mode Multiframe

Hi @PantelisGeorgiadis,
We are trying to pass these two tags for cine mode multiframe: FrameTimeVector and FrameIncrementPointer. While we can see the video and both tags in the DICOM viewer, the value for FrameIncrementPointer is always set to (0000,0000), even when we pass a specific value. Could you please guide us on what we might be doing wrong here?
Attaching a snapshot of the output for reference.

`const dcmjsDimse = require('dcmjs-dimse');
const { Client } = dcmjsDimse;
const { CStoreRequest } = dcmjsDimse.requests;
const host = '<IP_ADDRESS>';
const port = 4252;
const callingAeTitle = 'SCU';
const calledAeTitle = 'PACS_WITH_TLS';
const tags = {
...patientTags,
FrameTimeVector: [32, 37, 30, 33, 35, 65, 33, 36, 63, 34, 31, 67, 35, 32, 36, 63, 32, 34, 33, 32, 67, 36, 31, 65, 34, 64, 36, 67, 37, 29, 34, 66, 32, 35, 64, 33, 36, 30, 33, 34, 65, 34, 33, 32, 33, 31, 35, 66, 34, 66, 37, 32, 64, 34, 65, 35, 31, 67, 32, 65, 33, 70, 31, 33, 31, 34, 35, 32, 34, 33, 34],
FrameIncrementPointer: '(0018,1065)' OR  { vr: 'AT', Value: ['00181065'] } OR ['00181065'],
}
const client = new Client();
const request = new CStoreRequest(tags);  // Notes:- this is dcm file with tags
client.addRequest(request);
client.on('networkError', (e) => {
console.log('Network error: ', e);
});
client.send(host, port, callingAeTitle, calledAeTitle, {
securityOptions: {
rejectUnauthorized: false,
requestCert: true,
maxVersion: 'TLSv1.2'
}
});`

Hello @ctTushar!
I faced the exact same problem when I tried to create a gist that would generate Multiframe True Color Secondary Capture datasets. This is how I solved it: https://gist.github.com/PantelisGeorgiadis/476564c36b81a1698303c6309ad0cc58#file-dcmjs-sc-jpeg-gen-js-L154. Please check and let me know if this works for you.

Thanks @PantelisGeorgiadis  for quick let me try and get back to you.

You are awesome @PantelisGeorgiadis , it works thanks for quick response and solution.


feat: add starter code for storage node

As title.

Codecov Report
Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (ef1b4e3) 100.00% compared to head (d461689) 0.00%.

Files
Patch %
Lines

storage-node/src/server.rs
0.00%
10 Missing :warning:

storage-node/src/cache/lru.rs
0.00%
9 Missing :warning:

storage-node/src/storage_manager.rs
0.00%
8 Missing :warning:

storage-node/src/bin/storage_node.rs
0.00%
5 Missing :warning:

storage-node/src/storage_reader/disk.rs
0.00%
3 Missing :warning:

storage-node/src/storage_reader/s3.rs
0.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #3        +/-   ##
============================================
- Coverage   100.00%   0.00%   -100.00%
============================================
  Files            1       6         +5
  Lines            7      38        +31
  Branches         7      38        +31
============================================
- Hits             7       0         -7
- Misses           0      38        +38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I have some small suggestions, please feel free to correct me.

Maybe we should rename lru.rs  to cache.rs, and add a directory policy to include lru and other policies.
From the current design, the flow to find data is memory -> disk -> s3, so disk can become our main cache area. In this scenario, it is kinda weird if disk_reader is the same thing as the disk cache since disk should belong to cache maybe? (But if it's not, that's fine, also I think maybe we can add more starter codes to the cache, to display the logic of first memory second disk.)

Anyway, these are just small points that could be discussed and polished in the future. Thanks a lot for the starter codes! I can try to add more start codes to cache this weekend if needed.

I have some small suggestions, please feel free to correct me.

Maybe we should rename lru.rs  to cache.rs, and add a directory policy to include lru and other policies. Or cachedirectory is actually storing different cache policies? The main logic of cache is in StorageManager?
From the current design, the flow to find data is memory -> disk -> s3, so disk can become our main cache area. In this scenario, it is kinda weird if disk_reader is the same thing as the disk cache since disk should belong to cache maybe? (But if it's not, that's fine, also I think maybe we can add more starter codes to the cache, to display the logic of first memory second disk.)

Anyway, these are just small points that could be discussed and polished in the future. Thanks a lot for the starter codes! I can try to add more start codes to cache this weekend if needed.

Yes we should add a layer between StorageManager and the cache to make it easy for us to plug in various cache algorithms.
Maybe we can rename DiskReader to sth like LocalFsReader and put the logic of reading the disk somewhere in common, used by both LocalFsReader and the cache.

@unw9527 PTAL at the PulparseCache trait and the LruCache


Add documentation for eof_last attribute

Implement eof_last insertion feature
As I said in #56, I think it's a good to give ability to force insert empty line to body.
Also, I described eof_last attribute in documentation.

Thanks!


Remove unused dependencies on maven libraries

Description of Change
Processed the 'unused declared dependencies' mentioned for the maven plugin in response to my remarks of an obsolete maven-compat dependency.
org.hamcrest:hamcrest-core was listed as unused as it contains only deprecated classes and a note on the artifact itself being deprecated, with a transitive dependency on org.hamcrest:hamcrest, which is the up-to-date coordinate of hamcrest, so I've updated that coordinate to its future-proof coordinate and excluded the old artifactId from the transitive dependencies of JUnit.
Have test cases been added to cover the new functionality?
No, existing testcases have been used to validate the changes.

@jeremylong Codacy error is just because I decided to file a PR towards your branch rather than directly committing to it (target branch not configured for Codacy scan)


AlwaysSendClientClaims vs ProfileService

Setting AlwaysSendClientClaims to true allows the access_token to be enriched with the claims of the requesting clients.
During an introspection flow (WebAPI consumption) it turns out to be very convenient in order to make assumptions about the features of the requesting client alongside with the ones of the requesting user. Fine.
From the ProfileService perspective the client_claims inclusion mechanism is:

"transparent" when the system is building up the access_token and the IClaimsService is in charge (that is when the context.Caller equals "ClaimsProviderAccessToken").
"opaque" when the client is requesting for UserInfo (context.Caller equal to "UserInfoEndpoint"). I should then add the necessary logic to handle AlwaysSendClientClaims and eventually ClientClaimsPrefix :

public async Task GetProfileDataAsync(ProfileDataRequestContext context)
{
    var requestedClaimTypes = context.RequestedClaimTypes;
    var subjectId = context.Subject.GetSubjectId();
    User user = await _users.FindBySubjectIdAsync(subjectId);
    var issuedClaims = user.Claims.Where(c => requestedClaimTypes.Contains(c.Type)).ToList();

    // here's the custom logic needed to handle AlwaysSendClientClaims...
    if (context.Caller == "UserInfoEndpoint" && context.Client.AlwaysSendClientClaims && context.Client.Claims?.Count >0)
    {
        // ...together with the ClientClaimsPrefix manipulation.
        string prefix = context.Client.ClientClaimsPrefix ?? string.Empty;
        foreach (var clientClaim in context.Client.Claims)
        {
            string claimType = string.Concat(prefix, clientClaim.Type);
            issuedClaims.Add(new Claim(claimType, clientClaim.Value, clientClaim.ValueType, clientClaim.Issuer));
        }
    }

    context.IssuedClaims = issuedClaims;
}

Is there a way to (kind-of) synchronize the utilization of the AlwaysSendClientClaims flag among different contexts?

You are confusing client and user claims.
The profile service is for user claims. Client claims were originally meant to be static - but you can dynamically set them using a custom token request validator.

I was mainly searching for the perfect place to include the client_claims in a response from the UserInfo endpoint.
Tweaking the UserInfoResponseGenerator (by handling the client's AlwaysSendClientClaims in the ProcessAsync method) might be the case...
This way I'll let the ProfileService only manage the very user claims.
(The use case is a multi-tenant app with a CMS that filters content based on the ClaimsIdentity.)

Not seeing the point - userinfo endpoint is for user claims (it is part of OIDC) - the client claims are just part of the access token.

I was comparing /connect/introspect and /connect/userinfo expecting a similar/coherent behavior.
I can see that the introspection is meant to ...introspect the access token slavishly, thus providing client_claims (if any); while the userinfo endpoint just "returns Claims about the authenticated End-User" (given scope, etc...). It seems that my expectations weren't justified, even if the both responses still feed the claims of the authenticated user (in WebApi and ClientApp respectively).
Now I need to figure out how a good oidc citizen would include client_claims among the ClaimsIdentity ones, in the client app:

Parallel ClientCredentials flow while fetching the UserInfoEndpoint?
Introspection request directly from the Client?
...


Validity checks for Pays::No extrinsics should go into SignedExtension

Free extrinsics can not be able to fail, or else this provides an attack vector for filling up a block with bad transactions that cost nothing to the attacker.
Follow the pattern with retire_msa where any type of ensure! or other validation logic is moved to the CheckFreeExtrinsicUse SignedExtension.

[x] revoke_delegation_by_provider  (@shannonwells)

[x]  ensure_valid_msa_key

[x] revoke_delegation_by_delegator (@enddynayn )

[x]  ensure_valid_msa_key

[ ] delete_msa_public_key ( @enddynayn )

[ ]  ensure!(who != key, Error::::InvalidSelfRemoval);
[ ]  try_get_msa_from_account_id
[ ]  try_get_msa_from_account_id
[ ]  ensure!(who_msa_id == account_to_remove_msa_id, Error::::NotKeyOwner);

[x] retire_msa (@shannonwells )

[x]  try_get_msa_from_account_id
[x]  remove_delegator
[x]  delete_key_for_msa

Question: Can a malicious node ignore this signed extension and create a block with these free transactions?
If yes, should we limit the number or percentage of free transactions inside a block?


Issue 30: fixing the calculation of the maximum zoom level

as proposed by user pksorensen and adding tests

cc @pksorensen


Unexpectedly marking term with NotSimplified children as simplified

I get this error when the program in the attached bug report is run. I'm not entirely sure why this error is occurring. I'd be happy to try to fix it if someone could give me some feedback on what the appropriate steps to debug and fix it are.
kore-exec.tar.gz

This is the callstack:
    CallStack (from HasCallStack):
      error, called at src/Kore/Internal/Predicate.hs:1097:5 in kore-<IP_ADDRESS>-ZY6w1dzxVhGc9Fy2XxLI:Kore.Internal.Predicate
      cannotSimplifyNotSimplifiedError, called at src/Kore/Internal/Predicate.hs:1126:36 in kore-<IP_ADDRESS>-ZY6w1dzxVhGc9Fy2XxLI:Kore.Internal.Predicate
      checkedSimplifiedFromChildren, called at src/Kore/Internal/Predicate.hs:1136:14 in kore-<IP_ADDRESS>-ZY6w1dzxVhGc9Fy2XxLI:Kore.Internal.Predicate
      markSimplified, called at src/Kore/Simplify/Not.hs:150:17 in kore-<IP_ADDRESS>-ZY6w1dzxVhGc9Fy2XxLI:Kore.Simplify.Not

Notice that it's failing at that line in the Not simplifier, you'll need to look at the children of the Not and figure out why they're not being marked simplified. Which simplifier do the children come from? That's what should have marked them as simplified in some way or another.
Hope this helps, let me know if you have any questions.


[1458] Switch factories to use the JSONAPI renderer

Context
Using the jsonapi-rb gems to render JSONAPI responses based on our factories.
Changes proposed in this pull request
A few lines of metaprogramming magic to create serializers and make our models able to turn themselves into JSONAPI hashes.
Guidance to review
TODO:

Still need to do this for the rest of the factories (should be easy)
Relations (easy to add in)
Custom meta attributes (might be easier to declare the serializers manually for these)
Need to support the includes parameter (should be easy)
Need to figure out how to make this work with build_list (a bit of a pain)

 Fix tests in mc-fe


FirebaseMessagingService extended service class destroyed in android version 7.1.1 and lower

Step 1: Describe your environment

Android device: _____
Android OS version: 7.1.1 and lower_
Google Play Services version: _____
Firebase/Play Services SDK version: _____

Step 2: Describe the problem:
Steps to reproduce:
I have set the broadcast receiver for my notification action buttons and register the receivers in the FirebaseMessagingService extended class onCreate() method and unregistered in OnDestroy() method  this work fine in android version 8+ devices ,but in devices with 7.1.1 and lower version the onDestroy() method called quickly after the onMessageReceived() method
Observed Results:

What happened?  This could be a description, logcat output, etc.

Expected Results:

What did you expect to happen?

Relevant Code:
// TODO(you): code here to reproduce the problem

@RohiniRaman31 please use the issue template when filing issues.


Home app cant change colors. On/off and Dim working fine.

Hello,
I recently added a RGB led strip to homebridge (first one). Has the title says, colors do not change on Home App (iOS). Below, is my config.json:
{   "bridge": {     "name": "Homebridge",     "username": "CC:22:3D:E3:CE:30",     "port": 51830,     "pin": "012-34-567"   },   "description": "Acessories Configuration",   "accessories": [       {        "accessory": "MagicHome",        "name": "LED Strip - homebridge-magichome",        "ip": "<IP_ADDRESS>",        "setup": "RGB",        "purewhite": false    }   ] }
Did not find any solution, sorry if duplicated :/
Best regards

Solved. Just a configuration issue.
For those Magichome controllers, if they are only RGB, the configuration must be RGBW with "purewhite":false
Best regards


Always Receiving the "resume_download is deprecated error"

Describe the bug
For the last 2 months, in whichever python environment set up, if I have the huggingface-hub and I download a model, I receive the following error whenever I try to use a model from the hub (even if the same model is on device)
Reproduction
No response
Logs
python3.9/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.

System info
Copy-and-paste the text below in your GitHub issue.

- huggingface_hub version: 0.23.2
- Platform: macOS-14.5-arm64-arm-64bit
- Python version: 3.9.13
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: /Users/atakantekparmak/.cache/huggingface/token
- Has saved token ?: True
- Who am I ?: AtakanTekparmak
- Configured git credential helpers: osxkeychain
- FastAI: N/A
- Tensorflow: N/A
- Torch: 2.3.1
- Jinja2: 3.1.4
- Graphviz: N/A
- keras: N/A
- Pydot: N/A
- Pillow: 10.3.0
- hf_transfer: N/A
- gradio: N/A
- tensorboard: N/A
- numpy: 1.26.4
- pydantic: 2.7.1
- aiohttp: 3.9.5
- ENDPOINT: https://huggingface.co
- HF_HUB_CACHE: /Users/atakantekparmak/.cache/huggingface/hub
- HF_ASSETS_CACHE: /Users/atakantekparmak/.cache/huggingface/assets
- HF_TOKEN_PATH: /Users/atakantekparmak/.cache/huggingface/token
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: False
- HF_HUB_ETAG_TIMEOUT: 10
- HF_HUB_DOWNLOAD_TIMEOUT: 10

Hi @AtakanTekparmak, which versions of huggingface_hub / transformers are you using? This warning should not happen anymore on latest versions (see https://github.com/huggingface/transformers/pull/31007).

Please note that the fix:

https://github.com/huggingface/transformers/pull/31007

was just released yesterday in transformers-4.42.0: https://github.com/huggingface/transformers/releases/tag/v4.42.0
You need to update transformers:
pip install -U transformers

Thanks @albertvillanova for the context! My bad then, and happy to know it has been released! :smile:


[Frontend] UI components pass data

Define function signatures in controller
Figure out how to get UI to call function signature

Create a new folder called controllers and make files inside (decide however you want to split it up). Write function signatures in these files. Call these functions from UI components. Use the APIs I came up with in #38 to inform which function signatures you need. Use the data megan outlined in her doc to inform the types you need to create