Use Object.observe()

Make use of Object.observe() on the window global object listening to the 'add' change to detect when something is being added. Doing it so will have a better performance and code will be simpler since it will not be needed to poll the changes. Object.observe() is currently only available in Chrome, so it would be needed to use a polyfill like https://github.com/MaxArt2501/object-observe

Would be nice, but cannot be applied to window:
https://code.google.com/p/chromium/issues/detail?id=494574
:(

Security risk? Wtf?
What's the behaviour in Firefox? If it works there, maybe it could be used a polyfill on Chrome...

I did not test the polyfill.

If you have time it would be good to take it a look...


allow 'Run Farmware' step input

Coverage increased (+0.007%) to 32.914% when pulling d11e7d8e2a9ad372a99bbe5a95524ff0966e24a4 on gabrielburnworth:master into c1996a0896040b86b82d4030681eedf21990d8d1 on FarmBot:master.


Feature/jen actionplans

@jjbennett You'll also need to include the additions to the custom labels file; try retrievePackagedToSrc and see if it pulls them down correctly. If there are any label deletions in there, you won't want to commit those. Once the new labels file is correct, do another updatePackageXml, commit, and push. Let me know if you get stuck.

@jlantz any idea what this "limit exceeded" error in the deploy is about?


i3-gaps as a package/package option?

Basic info
Does it make sense to have i3-gaps as a package and/or windowManager option? If I understand the releases seem to match up (i3-4.11 and i3-gaps-4.11 are the same aside from the gaps additions).
ide from the gaps additions).
Maybe:
services.xserver = {
  windowManager = {
    i3 {
       enable = true;
       gaps = true;
    }
  }
}

cc i3wm maintainers @garbas @modulistic

@sheenobu you can already override existing i3 src via common nix ways
as another way we could add package option (which defaults to i3). this would follow how other nixos modules are done (eg. look at postgresql).
makes sense?


Unable to find resource in any resource loader

Hello, mi name is Igor. I saw that you good in Spark java.
I started to learn sparkjava with velocity template engine and faced with the problem, java can't find a template, which i put into public/templates/ folder. I say that staticFileLocation is ("/public"); So, java should find "templates" folder in "public" folder... But i have a wrong unable to find resource 'templates/layout.vm' in any resource loader And This is my tree structure
import java.util.HashMap;
import spark.ModelAndView;
import spark.template.velocity.VelocityTemplateEngine;
import static spark.Spark.*;
public class Main {
public static void main(String[] args) {
    port(4567);
    staticFileLocation("/public");

    get("/", (request, response) -> {
        return new ModelAndView(new HashMap(), "templates/layout.vm");
    }, new VelocityTemplateEngine());

}

}
I have not found how to use staticFileLocation! Plz, help, thx!

A template is not static, so you should put it in resources/templates/layout.vm

You can look at this project if you still have trouble: https://github.com/perwendel/spark-template-engines

Oh, thank you, thank you very much!
What is mean "is not static"?
Can you advice, what should I read about spark and where I can take a good information.

Среда, 19 октября 2016, 18:07 +03:00 от David<EMAIL_ADDRESS>A template is not static, so you should put it in resources/templates/layout.vm
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

Oh, thank you very much!
What is mean, template is not static?
In which case template is static

Среда, 19 октября 2016, 18:07 +03:00 от David<EMAIL_ADDRESS>A template is not static, so you should put it in resources/templates/layout.vm
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

Static resources are resources that do not change. The point of velocity files is that they are dynamic, you can define variables like $username and pass that from Java.

Hi Tipsy!
I'm facing the same issue with a Maven project, so I cloned the repository you provided. Im deploying to a local apache tomcat server 7.0 but no resources are found when I try to open it in the browser
Any idea?
Thanks in advance!
Pablo


confloat: TypeError: Interval() takes no arguments

Initial Checks

[X] I confirm that I'm using Pydantic V2 installed directly from the main branch, or equivalent

Description
Python 3.9.7, annotated_types==0.5.0
confloat with arguments (for example strict=True), show conflicts with annotated_types.Interval which does not take arguments.
Python 3.10.11, annotated_types==0.5.0
No error.
Python version incompatibility?
Example Code
from pydantic import BaseModel
from pydantic import confloat

class Model(BaseModel):
    a: confloat(strict=True)

m = Model(a=3.0)

Python, Pydantic & OS Version
pydantic version: 2.0
        pydantic-core version: 2.0.1 release build profile
                 install path: /home/hpa/anaconda3/envs/dinema_io/lib/python3.9/site-packages/pydantic
               python version: 3.9.7 (default, Sep 16 2021, 13:09:58)  [GCC 7.5.0]
                     platform: Linux-5.15.0-76-generic-x86_64-with-glibc2.31
     optional deps. installed: ['typing-extensions']

Selected Assignee: @lig

@EMalagolihpa I've tested your example on Python 3.9.17 and I get no error.
Could you, please, provide an example that fails and the full output. Thank you!

@lig The following code
from pydantic import confloat
confloat(strict=True)

gives me:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hpa/anaconda3/envs/test/lib/python3.9/site-packages/pydantic/types.py", line 213, in confloat
    annotated_types.Interval(gt=gt, ge=ge, lt=lt, le=le),
TypeError: Interval() takes no arguments

The error, seems to be in annotated_types.Interval. In fact, an even simpler example, if you create a python=3.9.7. env, and you install annotated_types==0.5.0 and try:
import annotated_types
annotated_types.Interval(gt=0)

gives same error:
TypeError: Interval() takes no arguments

If I install the same version of annotated_types in a Python=3.10.11 env, no errors.

Sorry, I still cannot reproduce this.
~/tmp/annotated-types-error
❯ virtualenv3.9 .venv3.9
created virtual environment CPython3.9.17.final.0-64 in 231ms
  creator CPython3Posix(dest=/home/lig/tmp/annotated-types-error/.venv3.9, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/lig/.local/share/virtualenv)
    added seed packages: pip==23.1.2, setuptools==67.8.0, wheel==0.40.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

~/tmp/annotated-types-error
❯ . ./.venv3.9/bin/activate.fish

~/tmp/annotated-types-error via 🐍 v3.9.17 (.venv3.9)
❯ pip install 'annotated_types==0.5.0'
Collecting annotated_types==0.5.0
  Using cached annotated_types-0.5.0-py3-none-any.whl (11 kB)
Installing collected packages: annotated_types
Successfully installed annotated_types-0.5.0

~/tmp/annotated-types-error via 🐍 v3.9.17 (.venv3.9)
❯ python
Python 3.9.17 (main, Jun  8 2023, 00:00:00)
[GCC 13.1.1 20230511 (Red Hat 13.1.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.

>>> import annotated_types
>>> annotated_types.Interval(gt=0)
Interval(gt=0, ge=None, lt=None, le=None)

Please, try creating an empty virtual environment and ensure that you are using it. Maybe, you've reused a directory containing files of another environment for creating a new one.

python -m venv venv
source venv/bin/activate
pip install annotated_types==0.5.0

and then
import annotated_types
annotated_types.Interval(gt=0)

Please try with python=3.9.7.

Thanks @Kludex for reproducing this. It turns out. The error could be reproduced on exactly Python 3.9.7. It doesn't reproduce on the latest Python 3.9.

@EMalagolihpa I ran into the same issue with python 3.9.7 and it is effectively gone in 3.9.8.
This is due the the fact that Interval inherits from a class that is a sub-type of typing.Protocol. I recall this from a previous issue couple months back, but can't seem to find it back anywhere.
For annotated-types I've noticed that version 0.4.0 didn't work with typing.Protocol so I tried to use that version which was successful.
So, as a workaround I fell back to annotated_types==0.4.0 which seems to work with python 3.9.7.

Our recommendation will be to update your Python version, not to use an older version of our dependencies.
3.9.7 was released on August 2021, and by the time of this writing we are already on 3.9.17.


Not correct baZi

The date 2001-07-07T08:45:00 must have a month of 甲午. Now the calculation produces 乙未. This is not correct, look in the Chinese calendar at what time in July 2001 the month of the horse changes to the month of the goat

After 2021-07-07 05:05:28 小暑, month change to 乙未.It's correct.


Support for XML comment "see"

I'm using XML comments for my controllers. If I add a <see cref="class" /> in my comment, it results in missing words.
/// <summary>
/// Cancels an <see cref="Order" />
/// </summary>
/// <param name="id">The order ID</param>
[DELETE("api/v1/orders/by_id/{id}")]
public void CancelOrder(int id, string reason) { }

The description in Swagger will be "Cancels an".
Using a code documentation generation tool like SandCastle or Doxygen results in displaying the "Order" word, with a link to the specified class. I expected Swashbuckle to at least display "Order".

I'd question the value of generating C# "style" documentation for WebApi controller actions? Outside of their own unit tests, they're rarely (if ever) going to be invoked by a developer. They're typically invoked by the framework itself. So, who would be the intended audience of such documentation???
Consumers of your application are not interested in C# style documentation because that's not how they will use it. HTTP/REST style documentation, as provided by Swashbuckle/Swagger, seems far more appropriate.
I'm going to close this issue as it's low on the list of priorities and as of now I'm failing to see the value. If it comes up again we can revisit.

It's not so much a matter of utility as a matter of habit and company policies (StyleCop rules for instance).
If you point me to the part of the code that parses the methods comments, I can make a PR.

Discussion on using inline code comments for swagger properties used by non-human consumers (e.g. swagger-codegen)  #164


getInstalledVoices() command isnt reporting all of the installed voices. Unable to change voice?

When I run the getInstalledVoices() command, it only lists three of the 13 voices I have installed on my computer. If I change the default voice in windows (even to one of the three listed in the console), it doesnt change the voice used.
I've tried changing both the narrator voice settings and text to speech voice settings (both of which list all 13 of my installed voices)
Windows 10.

The same exact thing here, furthermore one of the ones showing in my list returns an error when using. unsure if you tried to use all three of those or not


Channel Names / Logos

is it possible to have the channel names and logos instead of just e+tv or whatever?  just curious really lol
I know a lot can be done in xteve, however it seems like there are different networks shows on the same eplustv channel if that makes sense.
thanks!

It's not something super feasible with the way the app has been setup. Sorry


Compute the necessarry inversions of the witness in batch after it's creation

Follow-up of https://github.com/o1-labs/proof-systems/pull/2047
but we proceed differently.
The witness env now contains a set marking which element are to be inverted.
The Batch inversion is then done when creating the ProofInput.
We first create an intermediary type NotInversedProofInput, and implement a conversion to ProofInput which does the batch inversion

Can we close this @marcbeunardeau88?


[b/340754358] Update source file headers

b/340754358 - Update the licensing headers to match the current year

update the templates
apply spotless

Due to the specifics of the task, this PR changes almost 300 source files.
The recommended way to review is by reviewing the commit c86b5f044120dd8654d3e076145e56838126fef3 which contains all manual changes.
The changes for the second commit were all automatic and can be reproduced by running:
./gradlew spotlessA


Using emotes breaks spatial audio

Hello, when using emotes with the 'TooManyEmotes' mod, spatial audio breaks. I've been able to recreate this issue a few times now.
Steps to recreate...

Create a new game
Land
Order from the store (i.e. a flashlight)
Stand next to the drop pod, with it directly to your left or right (makes detecting the issue easier)
Do a random assortment of using emotes, spinning the camera around, stopping and starting emotes by moving your character (Not exactly sure at which part the mod breaks)
The music from the dropship is no longer playing from the correct spatial position

I've also recreated this issue when I do step 5, but right at the start of the game on the ship, then land and spatial audio of the drop pod is already broken.
Tested in a fresh r2modman profile with TooManyEmotes v1.7.18 and BepInExPack v5.4.2100
P.S. Thank you for fixing my previous issue with Neofetch <3

Sorry for the late reply. I want to say I fixed this audio issue. If not, could you please create another issue? Thanks!


Would it be better to have "reorder_modules" default to false?

Say I have the following modules:
mod utils;
mod api;

and I put some local macros (only to be use within my crate) to mod utils, in this case the reordering of the modules will change the meaning of the program/module.
Unless it is not too hard to detect that utils module contains macros that would be used in api module, I think the safe default would be not to reorder it. Am I right?
(FYI, I am experiencing this problem since I am using a real time formatter VS Code plugin)

Hmm, are you able to compile your code without #[macro_use] attribute on mod utils;? If the attribute is present, rustfmt will not reorder modules even when reorder_moduels is true.

Yes I can. I put a #![macro_use] as the first line on my mod utils, so I didn't use a #[macro_use] attribute.

I was hit by this issue today. Here's a MCVE, just to clarify the issue:
lib.rs
mod b;
mod a;

a.rs
my_macro!();

b.rs
#![macro_use]

#[macro_export]
macro_rules! my_macro {
    () => {};
}

This code compiles, but running rustfmt on it breaks the build because the macro is no longer visible in a module.


WFLY-4736 - Don't use MSC thread to start web components from within …

…UndertowDeploymentService

Linux with security manager Build 87 is now running using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80

Windows Build 94 is now running using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80

Linux Build 91 is now running using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80

Linux with security manager Build 87 outcome was SUCCESS using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80
Summary: Tests passed: 827, ignored: 317 Build time: 0:05:39

Windows Build 94 outcome was SUCCESS using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80
Summary: Tests passed: 2865, ignored: 372, muted: 1 Build time: 0:46:32

Linux Build 91 outcome was SUCCESS using a merge of 977350f0167b2e7e1f50a53613d9b9b8c4390b80
Summary: Tests passed: 2869, ignored: 372 Build time: 0:48:20


Optimizing currently included PNGs

Optimized with optipng -o7. Will rebase and add the PNGs from the currently open PRs (e.g. #179, #180, #181) once they are merged (if necessary). Happy to squash before merging this PR.
refs #195

I optimized the compatibility matrix screenshots and logos for both the merged and unmerged compatibility commits. This PR finishes the job.

add the PNGs from the currently open PRs

Can you clarify this for me?

Oh sorry, I did't know you had already optimized the PNGs in the open PRs (i.e. the ones mentioned above). Then all PNGs should be optimized.

It looks like there are some images in /img/sponsors/ that were not changed. Were those already optimized?

The images in  /img/sponsors/ are JPEGs and not PNGs. Not sure if we can really do lossless optimization on these. But I'll have a look.

#200 is merged. Can this be closed?

It looks like there are some images in /img/sponsors/ that were not changed. Were those already optimized?

The images in img/sponsors/ are JPEGs and not PNGs. Not sure if we can really do lossless optimization on these. But I'll have a look.

The three JPEGs in img/sponsors/, dong.jpg and newbery.jpg in img/team/ are already optimized according to the tool jpegoptim with default parameters.

#200 is merged. Can this be closed?

I think this PR should cover all PNGs. I'll mark it as ready for review.

ACK 773cd55692e0c6f1bef1a0710be167ac1bb43746 .  Lightly tested by looking at each modified image in my preferred image viewer (geeqie): geeqie $( git diff HEAD^^^^ --name-only ) .  I didn't look at the originals for comparison, but each image matched what I'd expect from its file name.
Interestingly, both the original and modified copies of img/posts/rbf-in-the-wild/rbf-green-multiple-bump-options.png gave me a Warning: Failed to decode Exif metadata..  The image decodes fine, otherwise.  Out of curiousity, @bitschmidty did you do something different for this image compared to the others you took for that blog post?

Thank you for the review @harding!

Thanks @0xB10C and @harding :framed_picture:


How to download the output model?

Please let me know how to download the output model

The model is stored in the intrinsic format: a set of edge lengths MatrixXd l and the face list MatrixXi F. You can explore these two matrices to obtain the output model.


Marathi language to be added to the app

Hello
I have almost completed (98% strings done) for Marathi language in the app on weblate.
Do these translations automatically get included and enabled in a future release or is there anything more that needs to be done from my side?
Thanks

Weblate periodically updates its own translations. As seen here, for example https://github.com/Zverik/every_door/pull/485

Ok got it. Thanks.


Support SSL client auth for elastic search

Clearly describe the problem and solution
This PR adds a capability to interface all Moloch components with an Elasticsearch cluster that leverages https client auth.
db.pl requires installing perl-LWP-Protocol-https and perl-Crypt-SSLeay if SSL is in use.
Relevant issue number(s) if applicable
https://github.com/aol/moloch/issues/1089
Did you run npm run lint from the viewer or parliament directory (whichever you are making changes to) and correct any errors
will not execute on my mac OSX installation
Did you Ensure that all tests still pass by navigating to the tests directory and running ./tests.pl --viewer
yes
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@awick Whenever you have a chance, I think this is ready for another round of reviews.

@awick I have made the requested changes (sorry for the merge issue).  I'm getting a failure on something related to API stuff that I don't think I touched...  Any tips on what to do to address?

That failure is a known race condition that we are still working on.    Thanks for the work!


New package: Simpson v1.0.0

UUID: 8e55fee6-e67b-4637-994c-810009a3f62d
Repo: https://codeberg.org/AdamWysokinski/Simpson.jl
Tree: b3596cb77ed8a48beafd93ba0a05926feff16ba3

This isn't correct, Dependency.toml is empty.  I'm not even sure why registry consistency check passed.


CategoryTeaser invalid href

When translating a page that has a categoryTeaser component configured with a href in the same language branch and then the page is translated, but the href location is not, it results in an invalid link on the component which creates:
<img src="/libs/cq/linkchecker/resources/linkcheck_o.gif" alt="invalid link: /content/we-retail/language-masters/es/products/women/shirts.html" title="invalid link: /content/we-retail/language-masters/es/products/women/shirts.html" border="0">
Which shows a huge image across the entire screen.
This can be easily replicated on a fresh instance of AEM. Translate the language-masters/en/women to language-masters/es/women. This will result in the error (large image overlaying entire page).
The easiest fix is simply to update the CategoryTeaser.java file with a better default value. Update line 47 to:
buttonLinkTo = properties.get(PROP_BUTTON_LINK_TO, "#");
This allows the default href to be "#" rather than "", fixing the issue.

I'd expect this to be solved with the fixes that we made to the broken link image and we also created a new teaser component. I'll close this issue for now, but please reopen in case the problem reappears.


listing 4.7

KeyError                                  Traceback (most recent call last)
Cell In[1], line 17
14 G = osmnx.graph_from_point(reference, dist=300, clean_periphery=True, simplify=True)
16 # First convert the source and destination nodes to Node
---> 17 origin = Node(graph=G, osmid=55808290)
18 destination = Node(graph=G, osmid=389677909)
File ~/miniconda3/lib/python3.10/site-packages/optalgotools/structures.py:12, in Node.init(self, graph, osmid, distance, parent)
10 def init(self ,graph , osmid, distance = 0, parent = None):
11     # the dictionary of each node as in networkx graph --- still needed for internal usage
---> 12     self.node = graph[osmid]
14     # the distance from the parent node --- edge length
15     self.distance = distance
File ~/miniconda3/lib/python3.10/site-packages/networkx/classes/graph.py:480, in Graph.getitem(self, n)
456 def getitem(self, n):
457     """Returns a dict of neighbors of node n.  Use: 'G[n]'.
458
459     Parameters
(...)
478     AtlasView({1: {}})
479     """
--> 480     return self.adj[n]
File ~/miniconda3/lib/python3.10/site-packages/networkx/classes/coreviews.py:104, in MultiAdjacencyView.getitem(self, name)
103 def getitem(self, name):
--> 104     return AdjacencyView(self._atlas[name])
KeyError: 55808290

Problem fixed. Thank you!


Code Completion and fixes don't correctly reflect state of files that have part/part-of removed

This was originally raised at https://github.com/Dart-Code/Dart-Code/issues/3752 by @witchdrash, but it seems like a server issue. Removing part and part of from files seems to cause classes to no longer show up in code completion, and for quick-fixes with stale entries to appear.

Create a multi-part file with several classes each separated out into their own files e.g.
a.dart
part "./b.dart";
part "./c.dart";

class AClass {}

b.dart
part of "./a.dart";

class BClass {
CClass? cReference;
}

c.dart
part of "./a.dart";

class CClass {
AClass? aReference;
}

someother.dart
import '/a.dart';

class SomeThing {
AClass? aReference;
BClass? bReference;
CClass? cReference;
}

Intellisense works just fine for importing into each file, remove the part and part of and intellisense wont see AClass, BClass or CClass anymore even if you restart VSCode, to import them you have to add it manually, renaming the files to a2.dart, b2.dart, c2.dart fixes it and intellisense once again shows them on the import menu, but naming them back to a.dart, b.dart and c.dart causes the problem to re-emerge.

I can repro the issue above (where the classes no longer show up in code completion after removing part/part of), but also the generated code actions also seem to think the classes are available through the original file:

Even after restarting VS Code and importing the files, some of the items are still missing from completion:

I cannot reproduce this, but it might be because I have e0752585f275ae90f45ea0475e10559ac873e116.

Ah, nice - I also don't seem to be able to reproduce using:
Dart SDK version: 2.16.0-edge.2766add19a274cef9eb0c763fa3627026fd9b923 (be) (Tue Jan 4 16:19:06 2022 +0000) on "macos_x64"
Thanks!


chore(deps): update dependency kharf/flux-k8s-stack to v23.12.1

This PR contains the following updates:

Package
Update
Change

kharf/flux-k8s-stack
patch
v23.12.0 -> v23.12.1

Release Notes

kharf/flux-k8s-stack (kharf/flux-k8s-stack)
v23.12.1
Compare Source
What's Changed
🚀 Minor

chore(deps): update dependency kharf/flux-k8s-stack to v23.12.0
chore(deps): update helm release kube-prometheus-stack to v58.5.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

superseded by

#897


MF-325 - Add SPDX license and copyright headers

Codecov Report

Merging #362 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   89.17%   89.17%
=======================================
  Files          43       43
  Lines        1469     1469
=======================================
  Hits         1310     1310
  Misses        110      110
  Partials       49       49

Impacted Files
Coverage Δ

readers/api/endpoint.go
100% <ø> (ø)
:arrow_up:

ws/api/transport.go
87.05% <ø> (ø)
:arrow_up:

things/api/http/requests.go
95.23% <ø> (ø)
:arrow_up:

users/service.go
100% <ø> (ø)
:arrow_up:

things/postgres/channels.go
69.38% <ø> (ø)
:arrow_up:

writers/influxdb/messages.go
88.57% <ø> (ø)
:arrow_up:

users/api/grpc/client.go
100% <ø> (ø)
:arrow_up:

users/api/http/responses.go
100% <ø> (ø)
:arrow_up:

users/postgres/init.go
83.33% <ø> (ø)
:arrow_up:

ws/adapter.go
93.75% <ø> (ø)
:arrow_up:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6461761...4c43a66. Read the comment docs.

@blokovi looks good, please add Scala files as well.

@blokovi please resolve conflicts and update branch.

Merged! Thanks @blokovi


C++ API

Thank you for resvg!  😃
I'm liking it very much and it renders SVG files so much better than QtSVG!
I'm opening this issue as a request for a C++ API.
I'd like to be able to use resvg in C++ applications without converting QString variables to char * for use with resvg_parse_rtree_from_file() and resvg_qt_render_to_image().
The reason for this is that filenames and paths in some languages and on some platforms do not behave well when converted to char *.
My immediate need is for use with a Qt backend, if that is easier to implement than a complete C++ API.
Thanks for your consideration in adding a C++ API.  If I were more familiar with doing this work, I would do it myself and contribute a PR.

Even with a C++ API you still have to convert QString to std::string. Or do you want a Qt API?

The reason for this is that filenames and paths in some languages and on some platforms do not behave well when converted to char *.

It's a known issue. resvg C-API requires that char * is a valid UTF-8 string, which is still not idea on Windows.
I will add a C++ and Qt-like API.

Sorry, I suppose you're right 😁   A Qt API would be awesome!
Thanks!

Added. It mimics QSvgRenderer and has the same behavior. You can check it via examples/resvg-vs-qtsvg.
It still an alpha and you have to use git version of the resvg.
Hope it what you wanted.


[WIP] Event-Hooks Logic Part and integration tests

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
This PR depends on PR https://github.com/Kong/kubernetes-ingress-controller/pull/1845
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Since event hooks will get a CRD on their own, closing this PR, but keeping it around for future reference.


fix deprecate! and disable! message

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

Follow up to #8530
Fixes an issue where the wrong message is displayed
Before this PR:
$ brew install tj
Error: tj has been disabled because it {:does_not_build=>"does not build", :no_license=>"has no license", :repo_archived=>"has an archived upstream repository", :repo_removed=>"has a removed upstream repository", :unmaintained=>"is not maintained upstream", :unsupported=>"is not supported upstream", :deprecated_upstream=>"is deprecated upstream", :versioned_formula=>"is a versioned formula"}!

After:
$ brew install tj
Error: tj has been disabled because it has no license!

CC: @SeekingMeaning

Nitpick: Why is “it” not part of the reason? That way it would also read like a sentence inside of formulae.

Nitpick: Why is “it” not part of the reason? That way it would also read like a sentence inside of formulae.

It turned out that almost all descriptions started with it so it was added to the message by default to remove the need for typing it every time. See https://github.com/Homebrew/homebrew-core/pull/60321#issuecomment-682642693
With the new symbols, most reasons should be something like disable! because: :unmaintained or similar which removes the need for it at all. It's only an issue when you need to provide a custom description. There is also a style check for it so it's not accidentally added twice.

Thanks again @Rylan12!


Failed to create pod sandbox: open /tmp/k3s-resolv.conf: no such file or directory

Environmental Info:
K3s Version: v1.22.4+k3s1 and v1.23.5+k3s1
Node(s) CPU architecture, OS, and Version: x86_64 on Arch Linux and ARM64 on Oracle Linux
Cluster Configuration: Single node master on Arch and 3 master using embedded etcd on Oracle
Describe the bug:
After around a week the /tmp/k3s-resolv.conf file disappears (I presume /tmp gets cleaned up by the OS...) and pods fail to start until k3s is restarted and the file is regenerated.
The error looks like this on the Pods events:
Warning  FailedCreatePodSandBox  11s (x10 over 2m6s)  kubelet            Failed to create pod sandbox: open /tmp/k3s-resolv.conf: no such file or directory

Steps To Reproduce:

Installed K3s:
I don't have the steps as the Arch box has been around for a while and I've just been restarting it weekly to resolve the issue. The oracle cluster was installed with the following command.

export INSTALL_K3S_EXEC="server --disable traefik --disable servicelb --disable-cloud-controller --cluster-init"
curl -sfL https://get.k3s.io | sh -

Expected behavior:
I'm not sure but why is this clearly critical file stored in tmp which is by definition ephemeral storage?
Actual behavior:
I have to keep restarting k3s :(
Additional context / logs:
Happy to provide some but I've not found any related logs to give a lead unfortunately.
Backporting

[x] Needs backporting to older releases
It does seem to exist in 1.22 and 1.23 from my experience.

For additional context, I found this discussion: https://github.com/k3s-io/k3s/discussions/3867
On Oracle Linux (on Oracle Cloud) I think k3s is creating the file because the default resolv.conf has nameserver <IP_ADDRESS>.
On Arch it's using systemd-resolved and the resolv.conf has nameserver <IP_ADDRESS>.
I can see how I may have been saved from problems in both of these cases. However I still think the the file being in /tmp and getting "tidied up", potentially by the systemd-tmpfiles-clean unit/timer on both Arch and Oracle Linux is probably a bug.

Having something cleaning up actively in use temp files seems like a problem. That's said, we could probably evaluate moving that file elsewhere.

Hi @brandond I agree, it was news to me when I discovered this was running on my systems. However it is there by default in Arch and Oracle Linux 8, so I assume it is there on many other systemd-based distros as well. I'm not sure how the file permissions work out, but maybe it should live in /var/lib/rancher/k3s/agent/etc/ with much of the other configuration.

Validated on release-1.23 branch using commitid 2f22703c9e2f3cee40709265de8676811d0aadff

File is not present in /tmp/ and is present now in $datadir/agent/etc/

$ sudo cat /var/lib/rancher/k3s/agent/etc/resolv.conf
nameserver <IP_ADDRESS>

There are no erroneous pod events
Also confirmed this same behavior is seen using v1.24.0-rc1+k3s1
This only happens when /etc/resolv.conf and /run/systemd/resolve/resolv.conf are not found to be valid resolv.conf files


XML Ampersand Problem

This is what happens if I try to edit comments inside XML... :(

I believe the first two commits were already merged??? Git plz?


#Add empty search

Coverage remained the same at 98.931% when pulling 552d2ee4a186e09c4251edf66c4b3477cf9176b8 on crop_searches_rspec into 49c095f2e90b94523cf93174773d967827543b03 on 874-search-page-empty-state.

Looks like you're merging into your own branch? Do you need me to review it?


Releases

Add example workflow for Azure container deployment

Deploy to Azure so there's example pages?

Whey all done


[17.06] Relabel config files.

back port of https://github.com/moby/moby/pull/34732
Without relabel these files, SELinux-enabled containers will show
"permission denied" errors for configuration files mounted with
docker server create ... --config ... ....
(cherry picked from commit 472c03a8c364090afb88258b3dd9748183c29d05)

ping @cpuguy83

Closing this PR because the docker-ce 17.06 code-line is EoL.


GMSH plugin and ports

Is your feature request related to a problem? Please describe.
The GMSH plugin is currently used by femwell, DEVSIM, Palace, and Elmer. These plugins rely on some automatic way to "tag" different parts of the Component to set boundary conditions.
A hack was implemented in the form of get_component_with_net_layers (now get_component_with_new_port_layers) to quickly enable this by converting polygons touching a list of ports into new layers, and hence new mesh entities. But this is not fully satisfactory as it results in a volume instead of a surface.
Describe the solution you'd like
We should leverage the new edgeports #135 instead. These could readily be extended to appear at the top/bottom of the simulation. Howeer, in their current form, edgeports would limit boundaries to be at the edge of the simulation.
This issue exists to discuss possible solutions.

Hey @simbilod, sorry for being ignorant about meshing details, but what prevents you from drawing a 2d rectangle that represents a port at arbitrary locations?

It's easy to draw it
It's not easy, in the GMSH API, to draw it, and then make its mesh conformal with the (possibly arbitrary) 3D CAD that represents your geometry, while simultaneously keeping track of the "physical names" of your entities

It might in fact be easier to define the 3D geometry, perform the meshing, and then tag mesh nodes in the 2D rectangle shape, where the port is to be defined. But then we lose control on the initial meshing parameters of the port (we could probably remesh it, however)

I see, thanks for the clarification! Yes, defining the geometry first is along the lines that I was thinking, because this is something that would also be compatible with a component base (#139, #142). And any additional logic required could then go on top of that. I don't know enough about meshing to judge whether this is a feasible approach, but just from a high-level view this would make things more uniform I guess.

Geometry definition should be left to the solvers right? The component base should only provide polygon vertices extracted from the Component and LayerStack, right?
Different solvers may have different volume representations, but they can all take in coordinates like this

Yes that's what I mean, sorry if that was ambiguous. I was mostly referring to what get_component_with_new_port_layers() in #140 is doing. It it takes a Component and a LayerStack and returns a modified LayerStack. If we move to a common interface, then no one except for the component base should come into contact with (and especially modify!) the raw LayerStack and Component, rather this should be handled (if really necessary) in its derived classes.
Some pseudocode for what I mean:
class MeshedComponent(SimulationComponentBase):
    @property
    def mesh(self):
        ...  # calculate mesh from port info and geometry vertices provided in base
        return mesh

c = MeshedComponent(component, layerstack)
my_mesh = c.mesh

Note however that probably we won't want a MeshedComponent class but rather components that relate to particular simulators, so something like ElmerComponent, MeepComponent etc., and the ones that require meshing would inherit from e.g. a GMSHComponent defined in the gmsh plugin (that itself derives from the SimulationComponentBase, for example.

Yes I agree with this.
The "net_layer" thing was a hack: the GMSH module works by creating GMSH CAD entities from LayerLevel attributes (GDS layer + zmin, zmax, sidewalls, etc.), and using the LayerStack key as the GMSH physical name.
The physical name is critical, because it allows the simulator to act on all the mesh nodes associated with a physical name. So you can easily assign material values, set boundary conditions, and extract solutions from different parts of the mesh without having to slice by position or something not generalizable like that.
So what's the filthiest thing to do if you want to independently access two different things on the same GDS Layer? You create a new GDS Layer, put the polygons you want on it, and make a new entry in the LayerStack with the new name you want, and then your meshing algorithm works the same :)


Prohibit defining some scope names that overrides existing methods, such as "private"

Problem: When you define a scope scope :private, -> {...}, it overrides
Module.private, so you won't be able to define private methods.

The same thing would happen for other dangerous names, such as
"private", "new", or "reload"

Solution: Like ActiveRecord, raise ArgumentError immediately when you define
a scope that matches with one in predefined some dangerous methods.

https://github.com/rails/rails/blob/600132afc17453019772d7065b0dde0ff408503a/activerecord/lib/active_record/scoping/named.rb#L159
https://github.com/rails/rails/blob/d04f74dd7271c477a6fb01c57bdc08eec48adc19/activerecord/lib/active_record/attribute_methods.rb#L125
Note that ActiveRecord::Base is a class whilst MongoMapper::Document is a
module, this commit look slightly different to ActiveRecord's solution.

Thanks!


Merged with my work

Hi
I've merged with my work.
I've tested all modules with pytest and I got no error.

Great, thanks!
You made a great work!


Add kluster spec migration

This is an attempt provide a fix for #97.
Specifically this PR provides a lightweight way of automatically migrating kluster specs to newer versions (e.g. add/rename fields with auto discovered values etc).
This is not intended to facilitate upgrades of klusters (helm upgrades) but update our internal representation of a kluster.
A little explanation:

The ordered list of migration steps is kept in a go slice in pkg/migration/register.go. The versioning is based on simply enumerating the migrations steps (4 migrations steps means the latest version is 4)
The spec/schema version of a Kluster is kept in Status.SpecVersion. New Klusters are created with the latest Version of the apiserver.
A migration step is defined by a reasonable simple function signature (see migration.Migration)
During operator startup before the controllers are started all existing klusters pending migrations are upgraded. I did it explicitly this way to avoid loosing the raw Data from a previous spec (e.g. a field was removed). Because as soon as a controller updates a kluster the internal json representation is completely replaced.

Open questions:

When upgrading a kluster fails it is not retried until the operator is restarted. Do we want to have a controller type logic that reconciles this continuously? If so we need to also think if we want to have controllers ignore klusters that are pending migrations. Otherwise we risk having them operate on incomplete data and destroy old information that would maybe be required for completing the migration.
Should be maybe call it SchemaVersion instead of SpecVersion to avoid confusion?

@BugRoger Care ro review? I consider this ready fo review.


Add option to set anchor for tiled windows

A commonly used example application that could use this is QuickTime Player, which when playing video has a fixed width/height ratio. kwm currently anchors windows to the top left of their tile, which is something I would love to be able to center.
For this I would suggest adding both a vertical and a horizontal anchor setting, which could be set to top/left, center or bottom/right.

Not entirely sure how to interpret this.
Do you mean anchor as in offsetting the window X,Y coordinate such that the window is centered (or whatever specified) in the created container?

Exactly what I was trying to do.

Sounds like a great idea, and should be simple enough to implement. Will give it a shot later tonight.

I don't think I'm gonna bother making this an option.
It always makes sense for me to make it be tiled in the center, if it cannot fill the container.

Sure thing, that's what I was intending to use anyways.
Thanks!

I believe this should be working now, only tested with mpv.
Would be nice if you can confirm.

Seems to be working just fine, except for container resizing, where windows get moved to the top and then back again. Maybe you can save the width/height ratio here and make it less flashy?

Does that issue happen in the latest commit? I've removed the buggy "do not resize tiled windows" code.

Seems to be fixed, thanks!

After a reboot I've had it happen again and managed to capture it on video.
https://gfycat.com/BewitchedFocusedBrownbutterfly

There appears to be no easy-to-implement way around the flickering for now. Will keep it in mind tho.

This stopped working in a recent commit (it worked yesterday), @koekeishiya?

Still works in the latest commit for me, which applications fail for you?

QuickTime Player fails

Still works for me for quicktime player as well. Although you may have to perform kwmc window -c refresh on it, or some kwmc command that causes the window to resize.
This is because the window itself is resized before Kwm is able to create an observer for it, and can not track the window-size changed event to re-apply the container.

I tried window -c refresh and window -c reduce|expand x, but they don't do the job for me.

Weird,I just tested and works perfectly on my end.
Could you post your kwmrc?

Sure, it's a bit all over the place, but there you go.
https://gist.github.com/dominiklohmann/f3103f2b8c3add1d39cc

I noticed you have kwmc config focus standby-on-float enable
Quicktime becomes treated as a floating window on my system, so I had  kwmc config focus standby-on-float disable just now when testing. I do not think this should matter on your end though, as it appears to have tiled.
I don't really understand why that happens tho.
On an unrelated note, I see you still have kwmc window -t mark bound, this command has been changed to kwmc mark -w focused.

kwmc config focus standby-on-float enable

Nothing changes when I set is to disable, it still doesn't center the window.

On an unrelated note, ...

Yeah, not been keeping up to date with the config changes recently, I really need to clean that config up.

Disabling the following setting in my kwmrc seems to have done the job for me, it's tiling now:
kwmc config float-non-resizable enable

Ah yeah that's the one I meant earlier, my bad, I got myself confused with the other one somehow..
If you'd like to undo that behaviour, you can move line 1471 in window.cpp to line 1473 (just above the line if(UpdateWindowInfow, that's the only change I've made that would affect that behaviour.
It's not something I'll do in Kwm because this behaviour is more correct per se.

I guess it makes sense for kwm to behave like that, I've just gotten used to it working the other way. I'll leave that setting disabled.
Thanks for the help!

Actually it's a mistake on my part now that i re-read the code. Will push a commit in a sec that could fix this. Thanks for noticing.


adding inline caching, inlining and peepholes to JIT-Compiler

As part of the VMs seminar, we implemented the following:

monomorphic inline cache
method inlining of primitives
peephole framework with the following peepholes:

push push numericOp
push popReturn
push push numericOp conditionalJumpIfTrue

disabled global method cache as it should now speedup only rare cases (inline cache should do the job)
moved primitives to a dictionary of functions
doing oldPrims featureswitch at launchtime
jit doesn't generate a switch if the compiled function has no labels
added some statistics about which {1, 2, 3}-grams are used by tinyBenchmarks (used to find promising peepholes)

Due to rewriting the history a lot for beautification, the commits authors got blurred a bit. We are @abstraktor, @hotzenklotz and @nilos.

Please put spaces outside the parentheses in control statements (if, for, etc): instead of if(...){ write if (...) {.

Also, make the generated code look nice. Proper spacing and line breaks help in seeing problems. If the debug flag is enabled, generate useful comments (e.g. which bytecodes were collapsed by peephle optimization).

Please debug the peephole optimizations with
Squeak.Compiler.comments = true

It will currently generate code like
// 4 <11> peephole-optimized push push numericop
if (typeof temp[7]  === 'number') {stack[++vm.sp] = temp[7] > 0 ? vm.trueObj : vm.falseObj;vm.pc = 7;continue;
}// 5 <> push

stack[++vm.sp] = temp[7];
// 5 <75> push
stack[++vm.sp] = 0;
// 6 <B3> numeric op >
var a = stack[vm.sp - 1], b = stack[vm.sp];
if (typeof a === 'number' && typeof b === 'number') {
   stack[--vm.sp] = a > b ? vm.trueObj : vm.falseObj;
} else { vm.pc = 7; vm.sendSpecial(3); if (context !== vm.activeContext || vm.breakOutOfInterpreter !== false) return bytecodes + 7}

But it does make no sense to check the type of temp[7] twice.
I would have expected it to generate something more like
// 4 <11 75 B3> push push numericop > (peephole optimized)
if (typeof temp[7] === 'number') {
    stack[++vm.sp] = temp[7] > 0 ? vm.trueObj : vm.falseObj;
} else {
    stack[++vm.sp] = temp[7];
    stack[++vm.sp] = 0;
    vm.pc = 7; vm.sendSpecial(3); if (context !== vm.activeContext || vm.breakOutOfInterpreter !== false) return bytecodes + 7}
}

Also, in this example (which is from this.vm.findMethod('Set>>findElementOrNil:').compiled), why isn't it optimizing push-push-op-jump? There is a jump immediately following this.

ok that was a poor try, next time, we'll do better. Thanks Bert for looking at it. I'm sorry for actually wasting your time here. I could easily have seen some of those on my own ^^

@bertfreudenberg I think all your issues should be resolved now. Thanks for your patience. Will you recheck this?

Will look at this asap, I'm just really busy at the moment.


🐛 Bug Report - default import doesn't work with Vite

Bug description
The package is using default import to supply the component https://github.com/ArtyomVancyan/antd-phone-input/blob/master/src/index.tsx#L43
Unfortunately, this approach doesn't work when vite is used https://github.com/vitejs/vite/issues/2139
So, Vite users have to use hacks like this https://github.com/beda-software/fhir-emr/commit/ce5425837089fa9a83bb18ebe0cf2f79ec8a0d1c :
import PhoneInput from 'antd-phone-input';
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const PhoneInputFixed: typeof PhoneInput = PI.default ? PI.default : PI;

I am not sure how to proceed with this bug, but it will inform Vite users and provide them with a workaround.
Reproduction URL
https://github.com/beda-software/fhir-emr/actions/runs/6348145345/job/17244243993
Reproduction steps

Use Vite to build the production version of the app

Hi @ir4y, thanks for the report. I tested with both yarn build and yarn build-storybook, and they succeeded when using antd-phone-input. The actual problem is in tests, especially at Test storybook step as we can see in the provided reproduction URL. When I suggested the #192 PR, I did not expect the tests will fail. I am not familiar with the test-storybook, but phone-related cases need to be updated (I am assuming the types need to be changed from 'string' to 'object').


Feature/1.5.0

Added Oracle driver for Scribe module.
Junk code deleted or refactored.

We need to find a way to specify installation of the Oracle instantclient dependency on travis.yml so the PR test can pass.


Only the cover and the download.db are downloaded

What happened ?
I run this on Fedora 37, on the stock Python3 package (version Python 3.11.2).
When trying to download a manga (so far I've tried Uzumaki and The Decagon House Murders, having similar results for both) I'm unable to download anything appart from the cover art and the download.db file.
I'm using the commands below:
https://mangadex.org/title/f4cfbb1c-766e-49db-ae80-1a5db3cbcc1b/uzumaki
https://mangadex.org/title/0c0b19c8-efde-4a65-b98a-9c7fc79fd173/the-decagon-house-murders

I am not able to do anything to get the full manga. Am I doing something wrong or is there an issue with the package? According to the docs, what I'm typing should work ok.
BTW thank you for this fantastic tool!
What did you expect to happen ?
To download the full manga.
OS version
Fedora 37, Python3 version 3.11.2
App version
mangadex-downloader v2.8.1 (https://github.com/mansuf/mangadex-downloader)
Python: 3.11.2
arch: x64
bundled executable: no
Installation origin
PyPI (Python Package Index)
Installation origin (other sources)
No response
Reproducible command
https://mangadex.org/title/f4cfbb1c-766e-49db-ae80-1a5db3cbcc1b/uzumaki
https://mangadex.org/title/0c0b19c8-efde-4a65-b98a-9c7fc79fd173/the-decagon-house-murders
Additional context
No response

The translated chapters in some language that you're looking for is not found on MangaDex. The application didn't show error chapters not found, maybe i will fix that later.
I tested in english language, it's empty
D:\>mangadex-dl "https://mangadex.org/title/f4cfbb1c-766e-49db-ae80-1a5db3cbcc1b/uzumaki"
[INFO] Checking url = https://mangadex.org/title/f4cfbb1c-766e-49db-ae80-1a5db3cbcc1b/uzumaki
[INFO] Using English language
[INFO] Fetching all chapters...
[INFO] Downloading cover manga Uzumaki
file_sizes: 100%|██████████████████████████| 1.64M/1.64M [00:00<00:00, 9.34MB/s]
[INFO] Download directory is set to "D:\Manga\test_manga\Uzumaki"
[INFO] Using pdf format
[INFO] Preparing to download...
[INFO] Waiting for chapter read marker to finish
[INFO] Download finished for manga "Uzumaki"
[INFO] Cleaning up...

Try using different language. By default, the application is configured using English language. You can use --language option to use another language
https://mangadex-dl.mansuf.link/en/stable/cli_usage/index.html#download-manga-chapter-or-list-in-different-translated-language

You're right, I didn't notice that. It's a shame and I'm surprised there are so many languages, but no English translation.


Keybobrd Manager in Settings: wrong UI elements

Microsoft PowerToys version
0.59.0
Running as admin

[X] Yes

Area(s) with issue?
Settings
Steps to reproduce

(A to B)
(Shift Delete 到 Delete)
The first "to" isn't translated.
Also, "All Apps" should be translated.
✔ Expected Behavior
like this one.

❌ Actual Behavior
No response
Other Software
No response

#18748

#18749

We released 0.60.1 and this is included in it! https://aka.ms/installpowertoys

The "All apps" part isn't solved. And it's hardcoded.

The fix for this issue has been released in 0.65. Please update PowerToys to the latest version:
https://github.com/microsoft/PowerToys/releases


Replace the inotifywait by shell script implementation

Description
Replace the inotifywait by shell script implementation
Motivation
Remove the need of the usage of inotify-tools since it is no longer provide in the rhel8
Closes: #2007

/hold


readline: drop not use min function

Since Go1.21 (go.mod), Go adds min builtin function.

Thanks for the PR!


Thy 22 instructions UI

Added new statuses with corresponding coloring based on new statuses, modified info modal to more fitting example guesses and widened the modal to fit longer examples.

CSS classes for animations have been changed and they all match. the keyframes are done in a similar syntax as the originals and then are named with the animation name.


⚠ Jenkins Plugins Artifactory has degraded performance

In 13b3e84, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1142 ms

Resolved: Jenkins Plugins Artifactory performance has improved in e50e9b2 after 21 minutes.


update master branch from 1.8 to 1.9

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ X ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@GregHanson: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ec4e189a91b4192afae1c13b63c2649f4db45401
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ec4e189a91b4192afae1c13b63c2649f4db45401
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
ec4e189a91b4192afae1c13b63c2649f4db45401
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Certificate Authenication vs IP Restrictions

Is there a reason why Microsoft is recommending certificate authentication over using IP restrictions?
When I setup my back-end service to have an IP restriction that only allowed requests from the API Management service's IP, the result was the same '403-Forbidden' response.  Setting up IP restriction is much, much easier than going through all the steps mentioned in this article, not to mention one doesn't have to deal with the cert expiring when using IP restriction.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9db9c9e-e856-8035-70f1-8c0b5608d55f
Version Independent ID: 3b800621-f33e-36b6-5ce9-a809dd227e52
Content: Secure back-end services using client certificate authentication - Azure API Management
Content Source: articles/api-management/api-management-howto-mutual-certificates.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@ToddTaylor Thank you for reaching out to us.  We will review the documentation on certification authentication and get back to you shortly.

@ToddTaylor Thank you again for your thoughtful feedback on our documentation.  One of the things we'd like to emphasize to anyone reading this is that we don't recommend one approach over the other.  In fact, you can use multiple authentication techniques to increase protection.
We've passed along your comments to the product group so they can add this to their backlog and these comments are public so that more immediately, this can be viewed by others.
We are going to close this thread as resolved but if there are any further questions regarding this matter, please tag me in your reply and we will be happy to continue the conversation.


west.yml: hal_stm32: revert ble_fw blobs

Since the mkbox board ble f/w upgrade method based on binary blobs that was proposed in #74255 has been turned down, all the work done in hal_stm32 module to host blobs is now reverted.
The application will be pushed as part of https://github.com/STMicroelectronics/stsw-mkbox-bleco.git package

Assuming it's intentional that this contains all of these changes as well (in addition to the blob revert one)

Actually, we have https://github.com/zephyrproject-rtos/zephyr/pull/76868 in the queue already, which is already the factorization of 3 changes. So I'd prefer this one is merged first as it has the merit of listing the including changes.


No "eye" icon in toolbar

After installing the plugin in logseq Version 0.7.9 (0.7.9) an eye icon does not appear in the toolbar, even after closing logseq and reopening it.

I am most likely going to retire this plugin.  I've written another, Style Carousel, which provides the same feature using a different mechanism.  Please give it a try for now.

I just pushed v2 of Wide Eyed today.  Internally it is Style Carousel.  So it is not identical in every way to what it was before.  Consider this a compromise to my not retiring the plugin.  I use Style Carousel daily and it works.  So it should get you what you want.
I am waiting on the manifest updates to get pulled.  It may take a couple days.  If you update your plugin version before that it won't be fixed.  Alternately, you can just switch to Style Carousel.  The only difference is the font set and icons used.  I kept the same icons you're familiar with in Wide Eyed, if you want to wait.

Please look to Style Carousel (it is successor of Wide Eyed) and direct any issue you might have there.  Thank you.


Add support for null oauth config in packager

Tacos with null OAuth config are packaged
min_tableau_version set to 2024.1 (can always update if we backport)
Adds a new test, confirmed all other tests pass

Change looks good, but should we target dev-2024.1 (doesn't exist yet) branch instead?

Think it's fine in the main branch since the resultant taco is already blocked on 2024.1. People won't be able to use the changes to make a taco that works on versions not supported by 2024.1. Plus, there was talk of backporting once release freeze is over.


mount: unknown filesystem type 'vboxsf' on Windows

On windows it might fail due to no vbox addons being installed with the error
Vagrant was unable to mount VirtualBox shared folders. This is usually
because the filesystem "vboxsf" is not available. This filesystem is
made available via the VirtualBox Guest Additions and kernel module.
Please verify that these guest additions are properly installed in the
guest. This is not a bug in Vagrant and is usually caused by a faulty
Vagrant box. For context, the command attempted was:

mount -t vboxsf -o uid=1000,gid=1000 var_www_ /var/www

The error output from the command was:

mount: unknown filesystem type 'vboxsf'

It can be fixed by installing vagrant-vbguest
vagrant plugin install vagrant-vbguest
vagrant destroy && vagrant up

Kindly add it to README.md, or I can do a PR if you want, above commands and this config worked for me.
config.vm.synced_folder "src/", "/var/www/", nfs: true

Hi @pareshchouhan,
Given that I can't test this (I don't have any Windows machines), could you do a pull request for it?
Thanks!

Fixed by #8

first rule witch works for me is that i closed chrome, players, any other program, installed guestadditions as pareshchouhan said before and everything works fine  for me.


Not tracking country data

I have umami running in docker behind nginx with the example configuration:
server {
  server_name umami.yourdomain.com;

  location / {
    proxy_pass http://localhost:3000;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header Host $host;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
  }
}

Here is the share link to my site:
https://umami.archit.us/share/QJYNnlV3/archit.us
everything seems to be working perfectly except country tracking.  I've tested accessing from other countries using Opera's built in VPN, but neither they nor my native country are showing up in the list.

The country lookup is entirely dependent on the IP address. Can you check your nginx logs and see if you are recording IPs? Another thing you can do is run the build-geo script to rebuild the IP lookup database.

I have the same issue. I can't run build-geo because I'm running it in docker and only have the public and node modules folders.
app is running as static page on netlify, havent done anything special on nginx.

yeah, I just spent the entire day debugging iptables and yes, I can confirm that umami is getting passed a local ip for every user, so I guess I'll close this. 😕 ty for the help


CI/CD setup auto publish to Firefox addons

Ref:

https://github.com/marketplace/actions/publish-firefox-add-on
https://github.com/marketplace/actions/firefox-addon-action
https://github.com/marketplace/actions/web-ext-action-for-firefox-add-ons
https://github.com/yayuyokitano/firefox-addon/

Another example:

https://github.com/apollographql/apollo-client-devtools/blob/main/.github/workflows/release.yml


http_inspector dynamic buffering

Changed the buffering behavior of HttpInspector. Previously, a static buffer of 8KB was inspected, and anything larger (e.g. a GET request with >8KB of params) would fail.  Now, there is a configurable initial_read_buffer_size in HttpInspector that, and if the HTTP version is not identified with that amount of request buffered, it will iteratively double up to 64KB.
Additional Description:
Risk Level: low
Testing: TBD
Fixes issue #36162

I'm curious: is it just the parser being too pedantic and trying to read until the newline? And do people really send >8kb one liners in the first line?

I'm curious: is it just the parser being too pedantic and trying to read until the newline? And do people really send >8kb one liners in the first line?

I don't think it's being pedantic, and I don't think it's unheard of.  The scenario is a large number of query params, which are all included in the request line before the version is indicated, so the parser has to get past them.

Right, the parser is just being pedantic trying to infer HTTP/1.1 vs HTTP/1.0 which is not that important down the line. IMO, it'd be just fine to cut the parser execution at 8kb and not try to read protocol

Right, the parser is just being pedantic trying to infer HTTP/1.1 vs HTTP/1.0 which is not that important down the line. IMO, it'd be just fine to cut the parser execution at 8kb and not try to read protocol

Perhaps there should be a field to allow a "fuzzy match", but I think this should identify the protocol as specifically as possible without that.  If we break execution and just return http_not_found that seems like a major failure of the parser.

Right, the parser is just being pedantic trying to infer HTTP/1.1 vs HTTP/1.0 which is not that important down the line. IMO, it'd be just fine to cut the parser execution at 8kb and not try to read protocol

Perhaps there should be a field to allow a "fuzzy match", but I think this should identify the protocol as specifically as possible without that. If we break execution and just return http_not_found on a large http request that seems like a major failure of the http_inspector.

I was suggesting something different. We could interrupt the parser at 8k and set the protocol as HTTP/(1.1 or 1.0) if parsing succeeded until that point. The goal of the inspector is to make the best guess, it cannot always be right.

I was suggesting something different. We could interrupt the parser at 8k and set the protocol as HTTP/(1.1 or 1.0) if parsing succeeded until that point. The goal of the inspector is to make the best guess, it cannot always be right.

Acutally sounds ok to me. If a requst's leading 8kb data is legay HTTP1.1/HTTP1.0 data, I think it's fine to assume its HTTP1.1/HTTP1.0

@briansonnenberg are you trying to increase the maximum number of bytes that inspector is willing to inspect?
If so I think the safest approach is to add the max_buffer_size (default to 8K) and change the algorithm to start at a low value, i.e. 512 bytes and up to maximum.
Or you can add a bool value to use fuzzy logic, although it may produce false positives with custom methods.

/wait-any

@yanavlasov @kyessenov @wbpcode
Took a stab at adding the fuzzy match parameter with max_buffer_size.  It works for http-parser, but there appears to be an issue with BalsaParser in the case of partial request lines. Tried sending malformed request lines, and until the buffer is configured such that it can hold the full request line (up \r\n), it didn't report any errors.  This means that the design of "assume http if parser doesn't report any errors up until the max buffer" doesn't work.

Looks like this needs a main merge and DC to be fixed. /wait

Yeah, I'll just remove the assumption of HTTP feature for now.  Looking into it further I found that this disparity in early error reporting between Balsa and http-parser is known, and not easy to fix.

/wait


fix overscroll spacer in safari

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23422
PROPOSAL: https://github.com/Expensify/App/issues/23422#issuecomment-1666890994
Tests

[x] Verify that no errors appear in the JS console

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

Offline tests

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

QA Steps

[x] Verify that no errors appear in the JS console

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web Safari
https://github.com/Expensify/App/assets/104348397/0d82caa4-9802-489f-89d5-5edb4388e4d6

Web Chrome
https://github.com/Expensify/App/assets/104348397/1576201b-93d4-43d8-8ddb-8f78515a9f31

Mobile Web - Chrome
https://github.com/Expensify/App/assets/104348397/018423e6-ddc7-41d2-af0c-b591712ea499

Mobile Web - Safari
https://github.com/Expensify/App/assets/104348397/e4ba8935-a319-40a8-93a3-717821db66af

Desktop
https://github.com/Expensify/App/assets/104348397/fd94b39a-580a-46cc-87ca-3f56dd564ea0

iOS
https://github.com/Expensify/App/assets/104348397/eec8b34b-dec9-47aa-b681-c4c9df8c7682

Android
https://github.com/Expensify/App/assets/104348397/f897072f-f7d6-4c60-a5d7-5b9a50d5b675

done

@roryabraham  Please Hold youre review I fould a bug, pushing fix in few minutes

@0xmiroslav @roryabraham Bumping for review

I apology i changed few things commit was not signed, reverted and forgot to push again, will made change again give me few mins.

This is not urgent, so I'd like to wait until after we do one more production release before merging this. Because of the merge freeze, if we're not careful we'll have a GIANT release checklist on our hands if we merge everything the first day the freeze is lifted.
This delay should not count against the #urgency bonus. I think the PR was made and approved by C+ within the time limit to get the #urgency bonus so unless something changes I think this PR should receive the #urgency bonus

Thanks for your patience here @ishpaul777. Can you please resolve conflicts so we can get this merged?

@0xmiroslav android app is build, tested on all other platforms, also How can i test lounge access page?

Lounge access page has BG same as appBG so fix has effect on the page. Android app is still building, sorrry for delay.
https://github.com/Expensify/App/assets/104348397/a6c9eeaa-401a-4118-b240-3399337ce193

Merge changes tests well on all platforms @0xmiroslav

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.71-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Find test image sets

Find 3-4 images that we can use as test data for deuteranopia (blindness to green).

apple

strawberry

scatterplot

wind vector map


[BUG] Volumes not able to attach or detach

Describe the bug
Longhorn had been running fine, but now some volumes are not able to detach or attach properly.
An overview of the status of some volumes:

An individual volume that is stuck in Detaching:

To Reproduce
Steps to reproduce the behavior:
I can create and attach a new volume, but I have several pre-existing volumes that are stuck in this state.  I'm not sure how these volumes got stuck in this state.
Expected behavior
Volumes should attach and detach properly.
Log
(I will submit a support bundle once this issue is created)
Environment:

Longhorn version: 1.1.0
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: EKS 1.17

Number of management node in the cluster: (n/a - EKS)
Number of worker node in the cluster: 21 total nodes.  3 nodes with Longhorn EBS volumes attached.

Node config

OS type and version: Ubuntu 18.04.5 LTS
CPU per node: 16
Memory per node: 64GB
Disk type(e.g. SSD/NVMe): 1TB EBS gp3
Network bandwidth between the nodes: 10GB

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): AWS EKS
Number of Longhorn volumes in the cluster: 495

Additional context
Today I increased the number of volumes in Longhorn from ~350 to 495.  I believe this problem started sometime during this process.

I just emailed a support bundle to<EMAIL_ADDRESS>

One thing we've noticed is that one of the replica nodes always reports a different state than the other two.  (3 replicas total). You can see in the screenshot in the original report that the ip-10-0-1-146.ec2.internal node reports Running while the other two report Stopped.  This is true for all volumes currently stuck in "Detaching" state.

To make clarify, for 3 nodes with Longhorn EBS volumes attached, is this mean that the Longhorn volume running on these 3 nodes only?
If yes, could you please check the CPU or I/O performance on these 3 nodes on AWS to check if the resource enough for running about 350 to 495 volumes?

To make clarify, for 3 nodes with Longhorn EBS volumes attached, is this mean that the Longhorn volume running on these 3 nodes only?
If yes, could you please check the CPU or I/O performance on these 3 nodes on AWS to check if the resource enough for running about 350 to 495 volumes?

@jenting Our cluster is 21 total nodes.  3 of these nodes we call our "storage nodes".  Each of these storage nodes has an additional 1TB EBS disk attached that is dedicated for Longhorn.  These storage nodes are tainted (like mentioned here) so that no general workloads get scheduled to these nodes.  So these storage nodes contain the "primary storage" and both replicas (3 replicas total).  The other 18 worker nodes have pods deployed that mount Longhorn volumes.
This is the disk io for each of the 3 EBS disks for 3/24 (the day we had the issue).  The spike between 9am and 10am was when I started creating more Longhorn volumes and is when the problem started.  (Times are in US MDT.)

This is the 1 min load and idle cpu for each of the storage nodes for the same time frame:

Once other thing to note: Although we had 495 volumes, only 15-20 of these were mounted at any given time.

I haven't find out the root cause yet but some observations are:
Some volumes are stuck in detaching because one of its replicas cannot be stopped. For example, the replica pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9 has
  spec:
    instancespec:
      volumename: pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30
      volumesize:<PHONE_NUMBER>
      nodeid: ip-10-0-1-146.ec2.internal
      engineimage: longhornio/longhorn-engine:v1.1.0
      desirestate: stopped
      logrequested: false
      salvagerequested: false

but the status of the replica is tucked in:
  status:
    instancestatus:
      ownerid: ip-10-0-1-146.ec2.internal
      instancemanagername: instance-manager-r-6710c7f6
      currentstate: running
      currentimage: longhornio/longhorn-engine:v1.1.0
      ip: <IP_ADDRESS>
      port: 10210
      started: false
      logfetched: false
      salvageexecuted: false
    evictionrequested: false

Looking into the instance manager of the replica, instance-manager-r-6710c7f6, it is running and it doesn't contain the replica pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9 in its status.instances map:
  spec:
    image: longhornio/longhorn-instance-manager:v1_20201216
    nodeid: ip-10-0-1-146.ec2.internal
    type: replica
    engineimage: ""
  status:
    ownerid: ip-10-0-1-146.ec2.internal
    currentstate: running
    instances:
      pvc-02a21535-9ab3-4cb0-8d0c-a3c524e5673a-r-e781594f:
        spec:
          name: pvc-02a21535-9ab3-4cb0-8d0c-a3c524e5673a-r-e781594f
        status:
          endpoint: ""
          errormsg: ""
          listen: ""
          portend: 10119
          portstart: 10105
          state: running
          type: ""
          resourceversion: 0
.......

This is weird because the replica should have been stopped according to the code
Futher more, it seems that all problematic replicas are on the node ip-10-0-1-146.ec2.internal in the instance manager instance-manager-r-6710c7f6
Will continue to investigate

Thanks @PhanLe1010 for digging into this -- please let us know if we can provide any other context.

hey @PhanLe1010 have you or the team found anything else here? we've been able to reproduce this in a variety of environments across multiple k8s versions (1.17, 1.18, 1.19). we're happy to provide more detail here if that is helpful.

@cmcarthur
We are busy wrapping up pending issues for the next release v1.1.1 so haven't had much time to look into this problem yet.
I will circle back to this issue as soon as the schedule allows.
In the mean time,

Can you provide us a support bundle and environment config for the Kubernetes 1.19 cluster which has the same issue?
If you remember the reproduce steps, it will greatly help

Continue from the the comment https://github.com/longhorn/longhorn/issues/2401#issuecomment-812257033, it is weird that the replica.status.currentstate is still running giving that the longhorn manager longhorn-manager-7grrv already send stop request:
2021-03-24T19:16:12.630587051Z time="2021-03-24T19:16:12Z" level=debug msg="Prepare to delete instance pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9"
2021-03-24T19:16:12.632518168Z time="2021-03-24T19:16:12Z" level=info msg="Event(v1.ObjectReference{Kind:\"Replica\", Namespace:\"longhorn-system\", Name:\"pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9\", UID:\"838fe6dd-d5b2-4ade-a4cd-ecacaea2f292\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"488552222\", FieldPath:\"\"}): type: 'Normal' reason: 'Stop' Stops pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9"

and the instance manager instance-manager-r-6710c7f6 already stopped it:
2021-03-24T19:16:12.635605660Z [longhorn-instance-manager] time="2021-03-24T19:16:12Z" level=info msg="Process Manager: process pvc-8c3d6914-a3e6-4d71-b139-e9428974eb30-r-bda29de9 stopped"

the communication between the instance manager and longhorn manager seems fine. 👀
This issue doesn't seem related to one of the known issues: https://github.com/longhorn/longhorn/issues/2697, https://github.com/longhorn/longhorn/issues/2309, https://github.com/longhorn/longhorn/issues/2329

we are running into the same issue with version 1.1.1
I just emailed a support bundle to<EMAIL_ADDRESS>unable to salvage volume pvc-932d1554-4440-4a68-8ecd-382537fcff0a: Disk with UUID be52601f-314f-469e-87ee-a4d5c94f68eb on node wllk8s4w4 is unschedulable for replica pvc-932d1554-4440-4a68-8ecd-382537fcff0a-r-fdb3dae3
kubectl -n longhorn-system describe replicas pvc-410f1eb8-f9fe-410f-8706-6f93783b4bb7-r-0b9ec4a4
Spec:
  Active:                     true
  Backing Image:
  Base Image:
  Data Directory Name:        pvc-410f1eb8-f9fe-410f-8706-6f93783b4bb7-2b2d5b45
  Data Path:
  Desire State:               stopped
  Disk ID:                    0aec07e1-6945-4113-baca-f8ae5c5f93a3
  Disk Path:                  /var/lib/longhorn/
  Engine Image:               rancher/mirrored-longhornio-longhorn-engine:v1.1.1
  Engine Name:                pvc-410f1eb8-f9fe-410f-8706-6f93783b4bb7-e-5c148edc
  Failed At:                  2021-07-29T08:18:04Z
  Hard Node Affinity:
  Healthy At:                 2021-07-27T14:57:55Z
  Log Requested:              false
  Node ID:                    wllk8s4w2
  Rebuild Retry Count:        0
  Revision Counter Disabled:  false
  Salvage Requested:          false
  Volume Name:                pvc-410f1eb8-f9fe-410f-8706-6f93783b4bb7
  Volume Size:<PHONE_NUMBER>0
Status:
  Current Image:
  Current State:          stopped
  Eviction Requested:     false
  Instance Manager Name:
  Ip:
  Log Fetched:            false
  Owner ID:               wllk8s4w2
  Port:                   0
  Salvage Executed:       false
  Started:                false
Events:                   <none>

Events:
  Type     Reason              Age                  From                     Message
  ----     ------              ----                 ----                     -------
  Warning  FailedAttachVolume  5m6s (x40 over 70m)  attachdetach-controller  AttachVolume.Attach failed for volume "pvc-932d1554-4440-4a68-8ecd-382537fcff0a" : rpc error: code = Aborted desc = The volume pvc-932d1554-4440-4a68-8ecd-382537fcff0a in state detached is not ready for workloads
  Warning  FailedMount         4m30s (x8 over 68m)  kubelet, wllk8s4w4       Unable to attach or mount volumes: unmounted volumes=[data], unattached volumes=[data rabbitmq-token-675rx configuration]: timed out waiting for the condition
  Warning  FailedMount         2m27s                kubelet, wllk8s4w4       Unable to attach or mount volumes: unmounted volumes=[data], unattached volumes=[rabbitmq-token-675rx configuration data]: timed out waiting for the condition
  Warning  FailedMount         23s (x25 over 64m)   kubelet, wllk8s4w4       Unable to attach or mount volumes: unmounted volumes=[data], unattached volumes=[configuration data rabbitmq-token-675rx]: timed out waiting for the condition

@es-sz,
From the support bundle, your replica CR disk ID spec.diskid is not match to one of the node's disk UUID status.diskstatus.diskuuid.
Had you removed one of the nodes from the Longhorn cluster?
Does the issue happen when you upgrade the Longhorn version?

We have rebuilded on oft he nodes
Mit freundlichen Grüßen aus Leonberg
Sascha Zimmer
Manager DevOps & R&D
Erik Sterck GmbH
Böblinger Straße 29
71229 Leonberg
T   07152 - 90130 - 61
F   07152 - 90130 - 99
M  0151 - 55130661
<EMAIL_ADDRESS>www.eriksterck.dehttp://www.eriksterck.de/
@.***
Ust-ID: DE293491156 | Amtsgericht Stuttgart HRB 756004
Geschäftsführer: Oliver Batz, Ralf Scharly, Erik Sterck
Von: JenTing Hsiao @.>
Gesendet: Montag, 2. August 2021 10:29
An: longhorn/longhorn @.>
Cc: Sascha Zimmer @.>; Mention @.>
Betreff: Re: [longhorn/longhorn] [BUG] Volumes not able to attach or detach (#2401)
@es-szhttps://github.com/es-sz,
From the support bundle, your replica CR disk ID spec.diskid is not match to one of the node's disk UUID status.diskstatus.diskuuid.
Had you removed one of the nodes from the Longhorn cluster?
Does the issue happen when you upgrade the Longhorn version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/longhorn/longhorn/issues/2401#issuecomment-890835299, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKMULUNX6EPSMPEXHQ6ZN73T2ZJOTANCNFSM4ZX7RDZQ.

We have rebuilded on oft he nodes

Sorry, I don't understand this wording :(

Ok we deleted one Node thereafter it was created new
Mit freundlichen Grüßen aus Leonberg
Sascha Zimmer
Manager DevOps & R&D
Erik Sterck GmbH
Böblinger Straße 29
71299 Leonberg
T   07152 - 90130 - 61tel:07152 - 90130 - 61
F   07152 - 90130 - 99tel:07152 - 90130 - 99
M  0151 - 55130661tel:0151 - 55130661
<EMAIL_ADDRESS>www.eriksterck.dehttp://www.eriksterck.de/
Ust-ID: DE293491156 | Amtsgericht Stuttgart HRB 756004
Geschäftsführender Gesellschafter: Erik Sterck | Prokurist: Oliver Batz
Am 03.08.2021 um 03:28 schrieb JenTing Hsiao @.***>:

We have rebuilded on oft he nodes
Sorry, I don't understand this wording :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/longhorn/longhorn/issues/2401#issuecomment-891439782, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKMULUNE3F6H5PURXJJRZADT25A2RANCNFSM4ZX7RDZQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

@es-sz are you replace the node with the same node, if yes, longhorn will treat it same the same node so would update the replica disk ID.

@jenting

So ,in this case we need to re-install the old node with  different name or ID ?
We face same issue ,we had a faulty node and few replicas in degraded state and its getting re-build again and again .
note: we fixed the faulty node  and re-added to cluster

Face same issue ,  I just edit the replicas

@es-sz, From the support bundle, your replica CR disk ID spec.diskid is not match to one of the node's disk UUID status.diskstatus.diskuuid.
Had you removed one of the nodes from the Longhorn cluster? Does the issue happen when you upgrade the Longhorn version?

Face same issue，just  change the replica diskid  as the node disk uuid  and the replica get healthy  and then


[Enhancement]: Update Old Google Analytics Connector, Add "(Legacy)" to Title

Is there an existing issue for this?

[X] I have searched the existing issues

Description of problem
With the addition in DNN 9.12.00 (RC1) of the GA4 connector, for some users, the list of Connectors could present confusion and mistakes in getting their analytics setup.
As we transition from the old "Google Analytics" Connector to both the new "Google Analytics 4" Connector and the option to use the "Google Tag Manager" to setup GA4, it seems likely many (some?) people might not be aware of which connector to choose to do things right or better.
Description of solution
As a very simple solution, it would be helpful and time-saving to many people to improve the title of the existing (old) connector to discourage people from accidentally doing new setups by adding "(LEGACY)" to the title. Example below.

Description of alternatives considered
Would a word beside "legacy" communicate better? Others that were discussed: "deprecated," "old," "not recommended," "Captain Dunsel" and others,. Another thought was to highlight it in the color red or maybe orange for warning? But just "(LEGACY)" at the end of the title seems like it would do the job well and be worthwhile.
Anything else?
This was discuss briefly in a recent "meetup" and the video is here, discussion starts at around 11:50 mins in.
Do you be plan to contribute code for this enhancement?

[ ] Yes

Would you be interested in sponsoring this enhancement?

[ ] Yes

Code of Conduct

[X] I agree to follow this project's Code of Conduct

According to google it will stop working in about 10 days, so we need to actually remove this connector from the codebase entirely. We just have to double-check that unused configs don't crash anything and if so plan accordingly.

Removing it seems to be inviting unexpected behavior(s). I don't claim to have any insight based in fact, but scheduling this for "removal" in DNN v10 seems more appropriate.

I would gladly welcome a PR to change the name (should be probably just a localization key). That being said, this configures an external service that was announced to no longer work on July 1st. My main concern (that needs to be tested) is if removing the implementation for a config that exists causes any errors or not. If not, then all is good, but if so, we need to act accordingly to not cause issues.


Cannot login in 1.X versions of storage explorer

Storage Explorer Version: 1.4
Platform/OS Version: apparently I can't copy from the about dialog any more either (also worked in 0.9) so here it is:

Architecture: see above
Regression From: 0.9.6, broken since any later updates (tried 1.0, 1.1, 1.2, 1.3, 1.4, worked on 0.9)
Steps to Reproduce:

open storage explorer
get the prompt to log in in some way "Connect to Azure Storage"
"add an azure account" -> [sign in]
fill in my email (redirecting me to my company's login)
fill in my password
get the authenticator pop-up on my phone and press approve

Expected Experience:
I shortly see "Waiting for authentication..." end then I get access to the subscriptions connected to my account, and the storage accounts and blobs under those subscriptions (this is also what happens when I need to re-enter my password in 0.9).
Actual Experience:
It keeps spinning on "Waiting for authentication...", presumably until some timeout happens, after which I go back to an empty storage explorer.

I've checked issues #579 and #578 but they don't seem to be real duplicates, and I'm not behind a proxy.
It seems to be a duplicate from #434 but unlike there I actually see an error in the console after I press F12:
error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt
error @ Debug.js:39
Debug.js:39 Unexpected end of JSON input
error @ Debug.js:39
and in the waiting for authentication box after pressing F12:
Uncaught (in promise) Object (followed by what I believe is a standard empty js object)

Running it from console shows no actual errors, same
...
Received message 'dialog-execute-operation'
Received message 'did-execute-operation'
Received message 'dialog-execute-operation'
Received message 'did-execute-operation'
Received message 'did-get-dialog-result'
Received message 'closed'

as in 434.

I have seen the same issue since Aug 15 2018. Hitting F12 I also see the "Unexpected end of JSON input" error.

The key here is the "bad decrypt" error. This is related to #535. We encountered the problem when generating new encryption keys when one isn't found. I experienced this exact same problem when trying to sign in. We have a fix for this coming very soon.
@JoranDox, @mcqueene, if you like, can you follow the suggestions in #535 to see if the "Microsoft_StorageExplorer" key is present?

@JoranDox, you said you're still having issues. Are you still getting the "bad decrypt" error? Have you verified that you have a "Microsoft_StorageExplorer" key in your credentials store?

in the pop-up: still the uncaught (in promise):

in the main window: still the bad decrypt:

I have the key:


Typescript ATA is broken in snippets Code editor (Regression)

All the new snippets when opened in the code editor window, is throwing type issues.

/bounty $50

/attempt #305


fixed an error for url_check function with axiom

There's an error in the url_check_passive with axiom integrated waymore

Thanks!


visualization

Hello, thank you very much for your code!
and...Is there any visual code for pictures or videos? thanks a lot

@Patickk This work is broken, they actually cannot produce 3d box, even the angle can not be correctly predict. I tried several implementations in this methods, just not work.


Broken link

"Using the az functionapp devops-pipeline create command, an Azure pipeline..."
The "command" link results in a 404.
https://docs.microsoft.com/en-us/cli/azure/functionapp/devops-pipeline#az-functionapp-devops-pipeline-create

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ab62930-d35d-d6d3-8bb7-2ed6b34636bb
Version Independent ID: 86725233-d4a5-a796-cd6e-c05c3675952b
Content: Continuously deliver function code updates using Azure DevOps
Content Source: articles/azure-functions/functions-how-to-azure-devops.md
Service: azure-functions
GitHub Login: @ahmedelnably
Microsoft Alias: aelnably

This is caused by this
https://github.com/Azure/azure-cli/issues/9343

@SimonClendon Thank you for your feedback! We will review and update as appropriate.

@ahmedelnably I can see the referenced issue has been closed by marking it as a duplicate of  #9336. Just checking if ther eis any ETA for this to be fixed?

As the new command is just a rename of az functionapp devops-build create one work around is to use the old name, though I prefer not to have the doc changed to the old command name
https://docs.microsoft.com/en-us/cli/azure/functionapp/devops-build?view=azure-cli-latest
the help is exactly the same

The link works now

@ahmedelnably Thank you for providing the fix.
@SimonClendon We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Initialize global.logisticsItems and global.normalItems to empty arrays.

There is no need to call getLogisticsItems()/getNormalItems() from
control.lua and it currently causes a crash.
Fixes #18

It's indeed not needed so i'm merging this, but the main issue had to do with the mod globals not being initialized for existing saves due to the removal of init in the on_load event, i think adding the init calls to on_configuration_changed for new mod installs should take care of any other lingering issues


add search engine optimization list

I've merged this with a few modifications in c2cfc76716bbefc97f490d09c89ac9c8772efca4, thanks for both PRs Marco!

You are welcome :)