Various improvements for PM query editor

Currently no Jira issue for this pull request, since I wasn't sure which Issue Type to select in the absence of Enhancement
This is a couple of minor commits to add what I hope will be considered as improvements to the query editor in the Performance Management datasource. The branch is based on the (currently) last commit in #43.

Some of these changes seem to conflict with HELM-71.

I probably broke some best practices when I submitted my pull request. It already includes all the commits from HELM-71, since I based my further changes on those fixes.
Sorry for the trouble! Let me know if I need to change something or create a new pull request.

In general this looks good to me.
However, @j-white did most of the work on this datasource. @j-white could you review this?! (-:

Thanks for the feedback so far! No worries about any delays; I know how it is. I'm glad to hear opennms-helm is still alive, though, because it's been extremely useful so far.
I do agree that this probably should never have been a single pull request. I just got a bit carried away during what was supposed to be a simple fix. :)
Due to working on other projects these days, I'm not sure when I'll be able to split it up into smaller PRs, but you're free to close this in the meantime. (Or cherry-pick / adapt the current commits as you see fit, for that matter.)

Now that HELM 2.0 is released, I'll close this pull request and focus on creating proper issues in JIRA for any bugs / features still relevant in the current release. Sorry about messing this one up. :)


Item confusion on repeated death can result in loss of an item

Playing with file DrCyanosLootableBodies_1.10.2-2.2.0 under Curse with Forge version <IP_ADDRESS>9.  No other mods installed.
I initially encountered this in survival on another pack and then verified it in a fresh Curse profile with no other mods present.  This is primarily an issue when someone is caught in a death loop.
Steps to reproduce issue

(optional) Launch Minecraft
(optional) Create a new world in Creative mode
Place an item in a hotbar slot (I used a shovel so I could dispose of the body) and make that slot the active hand and have at least one additional item in your inventory
/kill and respawn (or die from other causes)
loot the body, moving the item from the active hand to slot 1 by hovering the cursor over it and pressing the "1" key and shift-clicking the remaining items from the body to your inventory
(optional) dispose of the body
select a different hotbar slot with an item, without changing item in slot 1 or opening your inventory (opening or modifying your inventory at this point will reset things and prevent the glitch)
/kill and respawn
The item in the body's main hand will be the item from the active hotbar slot (correct) and the item that was in slot 1 will be missing

So how did you find this out 😕

I got both of my tinker's construct swords eaten by the bug while I was getting repeatedly eaten by a tough mob.  I was in a hurry to get my weapon out of my corpse, so I didn't want to do drag-and-drop, and shift-clicking starts filling in the hotbar from slot 9, so pressing '1' to get the item into my normal weapon slot seemed like a good idea at the time...


是否支持rn或者是否考虑支持rn

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

抱歉，由于工作量问题，近期没有考虑支持rn的计划😔


ArcDPS does not load properly when used with other add-ons

I installed ArcDPS, GW2 Radial and d912pxy with the add-on loader and when I started the game for the first time, all three of the add-ons worked properly. However, on subsequent tries, only GW2 Radial and d912pxy worked but not ArcDPS. I was able to resolve this issue briefly by doing a clean re-install, but after loading the game once, ArcDPS stops working again.
I found these lines in gw2al_log.txt:

[ERR] core | Unloading addon arcdps failed with error 1
[ERR] core | Some addons are not unloaded!

My config.yaml file:
application_version: v1.2.1
loader_version: v0.2
bin_folder: bin64
isupdate: true
launch_game: false
game_path: C:\Program Files\Guild Wars 2
exe_name: Gw2-64.exe
current_addon_list: 6a47cfc36ceb3030259d7b6d97cc321f6f4270e5
default_configuration:
d3d9_wrapper: false
version:
d3d9_wrapper: v1.1
arcdps: >
0dcfd96c3b511f45baf89e1b97f3df40  d3d9.dll
d912pxy: v2.2
gw2radial: v1.2.4_al
installed:
d3d9_wrapper: d3d9_wrapper
arcdps: arcdps
d912pxy: d912pxy
gw2radial: gw2radial
disabled:
d3d9_wrapper: false
arcdps: false
d912pxy: false
gw2radial: false"
Any idea how to fix this? Thanks.

Are you sure arcDPS isn't loading, or could it just be hidden and need to use the keybind to open it? (alt+shift+t or alt+shift+h)
I've gotten the same lines in my log file but arcDPS loads properly for me.


What is the rationale for changing button positioning wrt Studio plugin?

This version moves the buttons together. What is the rationale behind this change?
The original layout in the VPL and Blockly in the Studio plugin was carefully designed by Maria to make it easy to use and layout information visually efficiently. For example the important buttons (start, stop) were centred and 50 % larger than the others.
Moreover, changing the positioning will break the habit of users, is there a good reason to do so?

Order are not changed in respect of the blockly studio, the size perhaps more different in VPL but here it is also better responsive to the size of the screen.

Sorry for unclarity, I meant positioning. I see the point of responsiveness.
I suggest to keep the start and stop buttons centered, as users probably are used to click here. One solution to keep both this and have responsiveness is to move the text "Thymio blockly" on the right, so that the expanding space is at the same place as in the plugin version. Also the added text takes a lot of space and does not bring value to the user (Thymio blockly is already written in the window title). The small version of the Thymio logo would certainly do fine.

The layout is not the same there is less button and we want people to know whey are programming with Thymio Blockly (for the title).
We can add a space to separate the play and stop buttons. They will be visible enough this way.
We do not want to make the buttons bigger. We want to allow the users to have more space to program with a clean interface.
Users will start to program using the blockly interface in the left and then will go on the right to save or play. This is the logic behind this layout.

I understand the rationale of making the Thymio branding more visible, but in the new layout it takes as much place as all active buttons which I think is far too much, as it is a static element that just takes space, especially when you say that you want people to have more space to program.
Also note that in most GUI programs *for example any office suite) the active buttons are on the left.  This new layout is unnatural. The original one by Maria, Jiwon and I was designed to be consistent with the existing programs, with the "file" buttons on the left and the "accessories" buttons on the right, with key active buttons in the centre just on top of the editing area.
Also note that users will click a lot on stop and go, and do a lot of back and forth between these buttons and the main screen. In that sense having them centred is good. The load/save/new buttons as well as the information and language change buttons are used infrequently.

Also, as the Thymio logo already has the name Thymio, only the text "Blockly" could be written.

You want it like this ?

Yes, exactly. On desktop-size layout you would have the space on the right for the Thymio logo and the Blockly text, and on tight layouts you can have it on two lines as currently.

Like this ?

Yes, or if you prefer (might be more logical for the switch to tight layout) you can have the text on the right of the language. Also I would not repeat the word Thymio, maybe you can have a cute Thymio Blockly logo that combines the Thymio logo with the word blockly on a second line?

Also, when the layout is large enough you could have a little bit more space between the icons (like 8 pixels more), especially the two key ones in the center.

Thanks for caring :-) This is also important as on Linux we still have the integrated Blockly (for technical reasons), it is important we minimize the discrepancy for classrooms and schools having both Linux and macOS/Windows, or for children in Geneva who have Linux at school but maybe Windows at home.

Thinking of it I would rather put the logo in another corner (more like a signature). To me having it on the right is really not good at all.

I fully agree, it is much better on the lower-right!

Do you agree to change the layout for this one? (with a bit more spacing between icons for ex. 8 pixels)

This is not my decision. I make proposition based on your comments but it is not my role to decide the final layout. Please see with the person in charge of the project and give me the final decision.
For me, since we want a fast beta-release, the best would be to try the first version I did with the users and change it if we have negative feedback.
But I will follow and trust the final decision.

For me, since we want a fast beta-release, the best would be to try the first version I did with the users and change it if we have negative feedback.

Although we want to go fast, we should not create a situation that will generate unnecessary complaints and support in the future.
I'll see with @mbonani for the final layout.

As decide orally we implement the last layout

Done.


Fix the application morph_stats

Could we add tests in the applications in general?

Current coverage is 100.00%

Merging #92 into master will not affect coverage as of 89be9b4

@@            master     #92   diff @@
======================================
  Files           29      29
  Stmts          952     952
  Branches         0       0
  Methods
======================================
  Hit            952     952
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 89be9b4

Powered by Codecov. Updated on successful CI builds.


Register v0.1.0

@JuliaRegistrator register
Register the first release of FastGradientProjection.jl

Registration pull request created: JuliaRegistries/General/111574
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" f22c5129b657f5b493acc1f766153e4da1a11361
git push origin v0.1.0


Grant permission welcome dialog shows on every start

Describe the bug
Every time I launch the app, it shows the welcome dialogue with 'grant permission button'. I have to click the button to proceed to the app. However, nothing needs to be changed in settings. Permission has already been granted earlier. If I just close the settings window and proceed to the app, it works as expected. I tried resetting and reinstalling the app
Expected behavior
App launches without the dialogue mentioned
Desktop (please complete the following information):

OS Version: Windows 10 2004 19041.508
App version: v0.14.0

Log file
2020-09-17 19:30:43.3134|INFO|Files.App|App launched|
2020-09-17 19:30:43.5790|INFO|Files.Filesystem.DrivesManager|Drive added: C:, Fixed|
2020-09-17 19:30:43.6102|WARN|Files.Filesystem.DrivesManager|One or more errors occurred. (Access is denied. (Exception from HRESULT: 0x80070005))|System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
at Files.Filesystem.DrivesManager.<>c__DisplayClass20_0.<b__1>d.MoveNext() + 0xb7

Thanks for this report. This issue is fixed in version 0.14.1.


Enable only for .ts files

Hey guys,
I would like to know if there is a way to enable this capability with only .ts files. I use flow for other projects so I have installed coc-flow and work perfectly but now I installed coc-tsserver but there are issues on .js files with flow set as the static type checker.
Thanks in advance

Please read configuration in readme

I solved it, I added "tsserver.enableJavascript": false in the coc-settings.json file located at .config/nvim folder.
{
    "tsserver.enableJavascript": false
}


[New Lib] heic2any

Name of library: heic2any
Details

Link to package:

npm: https://www.npmjs.com/package/heic2any
github: github.com/alexcorvi/heic2any
docs: https://alexcorvi.github.io/heic2any/

Problem solved by using this package:
Issue: https://github.com/Expensify/App/issues/12531

We want to handle previews of image files, HEIC files included which are not fully supported yet.
Recently we have added expo-image to the project, this allows us to handle HEIC files on Android & iOS, but unfortunately web/desktop is still not supported (docs).
Now we have discussed a few possibilities (here's the Slack thread), but in the end settled on using expo-image we already have in the project for mobile and heic2any on web/desktop. This way we won't change the mobile bundle size and have all devices with working previews.

Number of stars in GH: 519
Number of monthly downloads: ~370k in the last month
Number of releases in the last year: 1
Level of activity in the repo: low - 17 open issues, 0 open PRs
Alternatives:

The main alternative (it's ~0.4MB bigger) we could consider using is libheif, but the problem is that it's written in C++ and it's not providing any easy-to-use JS bundle. To utilize it we would need to set up a custom way to include it in our project i.e. using web assembly.

Are security concerns brought up and addressed in the library's repo?
Not that I know of, but this is not the type of library that would raise any security concerns.
How many dependencies does this lib use that will be brought into our code?
0
What will the effect be on the bundle size of our code?
This library would add 1.3MB to web & desktop bundles, but since won't use it on mobile we want to make sure it doesn't affect iOS/android bundle sizes.

Reading through the discussion here it looks positive, but I'll need to share a brief overview comment and tag the internal team.

@Julesssss done 😄 https://github.com/Expensify/App/issues/12531#issuecomment-1926683973

Proposal for solution

Are all the answers in the main description filled out properly and make sense?

✅

Who maintains the library and how well is it maintained?

A popular Github user: https://github.com/alexcorvi

How viable are the alternatives?

Not viable. We'd have to ignore a major issue where we don't support images on certain platforms. Or we'd have to implement backend logic with unnecessarily complicated logic

Should we build it ourselves instead?

No. Lets save our time and rely on a widely used existing solution.

Here's the Slack vote

Tagging @Expensify/mobile-deployers again, as the final vote will be on this issue.

After a good discussion, we are aligned on not implementing the library and not trying to solve the problem with an alternative solution.
We'll do nothing for now as this is an edge case with solutions relying on workarounds, large libraries, and non-cross-platform solutions.
Closing this issue.

Reopening b/c we have a new request to use this library here: https://github.com/Expensify/App/issues/47078#issuecomment-2275891488
I am working on writing this up in Slack today 🙏

@Beamanator can you create a new issue for the updated conversation please

Surrreeeeeeeeeeeee nothingmoreintheworldthati'dratherdoooooooooooo


Subscriber supervision instantiation bypasses Action API

Describe the bug
Currently, the subscriber supervision instantiation bypasses the Action API when a Val element exists.
This means that undo/redo is lost and likely other side effects.
https://github.com/openscd/open-scd/blob/03632e21957a51b3ca6db6e7169ca88bb1e59a12/src/editors/subscription/foundation.ts#L356-L372
To Reproduce
Found during code examination.
Most likely can be reproduced by having an LGOS/LSVS LN with an existing Val element with an empty string being available for a subscription.
Additional context
This will be at least partially resolved for later binding in the oscd-subscriber-later-binding project but this will not fix  the message and data plugins
** Also **
See the linked issue below, the selection of the Val element is also incorrect, it needs to be qualified by the DOI and the DAI.

Still relevant and requires attention but addressed in my updated subscriber plugin.


 Keyboard navigation has a delay with 1.2 seconds in Chrome and in Firefox it hardly works at all due to the delay. Firefox creates a warning asking to abort the page due to slow javascript.
This is probably not a problem when using the overflowmenu like normal in a component since if we remove the storybook actions and knobs for this story then the performance is okay.
To Reproduce

Go to https://carbon-addons-iot-react.com/?path=/story/overflowmenu--basic
Click the button and use the keyboard to navigate the menu items

Expected behavior
A clear and concise description of what you expected to happen.
Environment/versions:

OS: MacOS 10.15.4
Browser: Chrome (81.0.4044.138), Firefox (76.0.1), Safari (13.1)

This might be related to how we import Carbon's stories and re-export them. One way to verify would be to run a profiler on this and look into the flame graph to see what's computationally expensive when the story is interacted with.


apk link in description box not working

The apk link given in the description box is not working
It is giving error 404.
Please check

Fixed. Thanks for notifying 😄


Some gifs display broken

Please take a look at this gif
http://katemobile.ru/tmp/sample3.gif
It's fine. But if you try to open it in GifImageView you can see some glitches at the bottom of the file.
It's not about this specific gif, I can get more samples like that.
Have no idea why it happens. But there's one hint I can provide:
GifImageView and Glide use the same GifDecoder implementations right? It's pretty much modified in both projects but still I guess it comes from the same place. But Glide implementation plays this git correctly. So if we can figure out the difference between two implementations we can tell where the problem is. Probably not that easy to do.

Fixed on https://github.com/felipecsl/GifImageView/commit/0fb200af9869ec66dca6edd296857c90778ef15b
Thanks for your report. I'll push a new version with the fix

Wow! Are you sure it's a good idea replacing the complete implementation?  Or you think your implementation was outdated and you replaced it with the better one?

yeah, it's pretty much the same implementation, just with some more classes and structure around it. and it's based on the same core, so it should be safe. your sample gif is running smoothly now

Yeah, can confirm that the new one works just fine.

Can see that new GifDecoder is about 30% slower than the previous one. On low-end devices playback was slower than expected. Now it's even more slower. Not sure if we can do anything about that.

For example averageColorsNear() method takes a lot of time. In previous implementation we didn't have it at all. Probably it's a required method and we'll have to live with it.


Update index.d.ts

add proper typings for app.hooks(), fix return typesof service hook setters

Thanks, as we depend on the community to maintain these.


Catalog Items Not Showing Full Information

Description
Currently, some catalog items, like the AWS RDS Controller, don't show all the details. Users can't see all the information about these items and also not able to return from the current catalog item because of that. The problem is more noticeable when the computer screen is zoomed in to 100%, which is the standard setting for most browsers. While reducing the zoom can temporarily fix the issue, it's not practical for users to constantly adjust their zoom levels
Expected Behavior
catalog item should have a maximum height. If the information for an item is taller than this height, a scrollbar should appear so users can see the rest of the details. This will prevent information from being cut off and make sure users can see everything about each catalog item.
Screenshots
https://github.com/user-attachments/assets/f0a6ccac-b2d5-48ee-822d-c85542bdb4ad
Step To Reproduce The Issue

Go to meshery home page
In the navigation bar, click or hover over the "Catalog" section.
Scroll down below and click on aws rds controller [deployment]

Environment:

OS: Windows
Browser: Chrome
Version:
Device: Desktop

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@Ashparshp, if you find this issue relevant, I would like to work on it


fix(icons): changed shopping-bag icon

What is the purpose of this pull request?

[x] Other: Icon update

Description
Arcified icon.
Before Submitting

[x] I've read the Contribution Guidelines.
[ ] I've checked if there was an existing PR that solves the same issue.

Throwing this complete redesign in here, tbh, I'm not a fan of our current shopping bag icon:
Open lucide studio

The current version is also a bit big, I don't like it when it is smaller tho.
Open lucide studio

The current version is also a bit big, I don't like it when it is smaller tho, I feel like it needs to be taller than it is wide.

I kind agree, which is exactly why the one I posted – while the base shape is almost square – I think has a kind of "illusion of narrowness" because of the extra handle.

Throwing this complete redesign in here, tbh, I'm not a fan of our current shopping bag icon:
Open lucide studio

I'm up for it, but maybe we should merge this and create a separate PR for it.


wifi greyed out

i wonder like on my iphone x (gsm) 15.2 beta 1 when i'm jailbroken with palera1n the wifi option is greyed out is that a bug or is it supposed to be like that

Did you replace the ipsw url in the code with the beta? Maybe something from 15.2 release is incompatible.

Same Problem here...
iPhone X (GSM), freshly restored with Futurerestore to iOS 15.3.1 with SEP+BB from 15.7
While Setting up the Phone there was no problem with the WiFi, but after installing palera1n my wifi icon got grey and in the settings tab I couldn't activate it as well, I tried to restore the Network Settings... didn't work... then I tried to restore the entire Settings of the Phone... didn't work as well.

Same issue, iPhone 8 15.2

Same issue, iPhone X 15.3.1


Change commit pattern to start with Jira Ticket

Currently, the Jira Ticket has to be included in the scope of a commit, which builds the links in the changelog.
But that means it does not support the Jira-Github integration that auto-links a commit directly to its respective ticket.
My understanding is, for that to work, the ticket identifier must be placed at the start of the commit message.
Here is an example:

Can the Jira Ticket be moved to the start of the commit message, then the action, then the scope? Something like the following:
<jira_ticket?><bump_pattern><(scope)?>: <commit_message>
Where:

jira_ticket: optional
bump_pattern: required, from a list of accepted values
scope: optional
commit_message: required

You can do that, but then you must fork this repo and rewrite the commit message parser. This plugin was created to work with exactly one commit message format and I can not change it since this format is now part of the commit history of several projects. If I was to change the format would break the workflow of everyone using this plugin.
If you are looking for inspiration you can find other customizations at:

https://commitizen-tools.github.io/commitizen/third-party-commitizen/
and the (currently 9) forks of this repository


Scheduling crawls

When using a bunch of crawlers (different configs) for 1 server you don't want to melt under crawl load. What is the best way to do this?
(I basically want to start all crawls in a collector installation and define a site delay in GenericDelayResolver)

If you have defined and running several Collectors with one or more crawlers each, no magic come to mind other than being careful when you run each.   If all delays together are not very aggressive, you should be fine.  Otherwise, here are a few ideas:

For small crawl durations are relatively small, specify different start time in a crontab for each (or Windows Scheduled Tasks).
For long-running crawls, specify different time of the day where each crawl is more aggressive (regardless of cronjob). For instance, let's say you have 24 crawlers, and you want each one to take turn in being more aggressive, you can give each a specific time for that.  Here is one that will run more aggressively between 1:00AM and 2:00AM:

  <delay class="com.norconex.collector.http.delay.impl.GenericDelayResolver"
          default="10000"
          ignoreRobotsCrawlDelay="true"
          scope="crawler">
      <schedule time="from 1:00 to 2:00" >1000</schedule>
  </delay>

I just realized the GenericDelayResolver Javadoc did not specify how to specify the delay for each schedule.  I updated it.

It would be a nice feature if you could regex a bunch of crawler configs as argument (-c site1*.xml) and they would run sequential.

I am assuming you mean "collector" configs (since we cannot pass crawler configs now)?
By design when using command-line we want that each collector is run in its own JVM to provide the desired isolation.  So the wildcard idea won't be built into the java app.
Command-line wildcards in arguments are typically resolved by the OS. So shell/batch scripting is what I would indicate here.
You simply need to wrap the collector-http.sh script with your own script that accepts wildcard arguments, and iterate through all those config files arguments, invoking collector-http.sh for each, sequentially.  I will do what you want, in addition to ensuring a new JVM is launched each time.

Thanx for tip. I can do this with shell script.


Remove dependency installation from make

The make should just check for dependencies exiting if they don't exist, but I'd rather not have installation of these dependencies done there. This causes a noticiable slowdown on the ./INSTALL_SUBMITTY.sh script (as it's doing apt-get dependency checks each time it's run).

I actually misunderstood how make was working. I'm fine with how it's structured with using ubuntudeps as the flag to make for installing dependencies, we just don't want to be running it within submitty repository (especially with install setup)


[iOS] Flatlist bug: update refreshing prop programmatically

When changing the "refreshing" property programmatically on iOS, the activity indicator doesn't show automatically, the user needs to move the list a little bit down in order to see the activity indicator spinning.
It works perfectly fine on Android.
React Native version:
System:
    OS: macOS 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 38.77 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 8.16.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.10.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 28
      Build Tools: 28.0.3
      System Images: android-28 | Google APIs Intel x86 Atom_64
  IDEs:
    Android Studio: 3.4 AI-183.6<IP_ADDRESS>92245
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.4 => 0.60.4
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-rename: 2.4.1

Steps To Reproduce

Render a FlatList with some content and a refreshing property
Programmatically set refreshing property to true

Describe what you expected to happen:
By updating the refreshing property programmatically, the list should automatically display the activity indicator.
Snack, code example, screenshot, or link to a repository:
render() {
	const {
		onPressJob,
		loading,
		jobs,
		onRefresh,
		onEndReached,
	} = this.props;

	return (
		<FlatList
			data={ jobs }
			refreshing={ loading }
			onRefresh={ onRefresh }
			onEndReached={ onEndReached }
			keyExtractor={ item => (item.Id) }
			renderItem={ ({ item, index }) => (
				<Grid container>
					<Grid
						item
						size={ 6 }
						spacingTop={ index === 0 ? 12 : 6 }
						spacingBottom={ index === (jobs.length - 1) ? 12 : 6 }
					>
						<JobAvailableCard
							item={ item }
							onPress={ onPressJob }
						/>
					</Grid>
				</Grid>
			) }
		/>
	);
}

Also having this issue

I'm still having this issue, I haven't been able to dig deeper.

still at 0.60

Still happening at 0.60.5
System:
    OS: macOS 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 57.15 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 8.16.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.10.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 28
      Build Tools: 28.0.3
      System Images: android-28 | Google APIs Intel x86 Atom_64
  IDEs:
    Android Studio: 3.4 AI-183.6<IP_ADDRESS>92245
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.5 => 0.60.5
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-rename: 2.4.1

Still happening on 0.61.1
System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 176.78 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 29
      Build Tools: 29.0.2
      System Images: android-29 | Google APIs Intel x86 Atom_64
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
    Xcode: 11.0/11A420a - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.1 => 0.61.1
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-rename: 2.4.1

Still happening on 0.61.2
System:
    OS: macOS 10.15
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 328.49 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 29
      Build Tools: 29.0.2
      System Images: android-29 | Google APIs Intel x86 Atom_64
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>00203
    Xcode: 11.0/11A420a - /usr/bin/xcodebuild
  npmPackages:
    react: 16.10.2 => 16.10.2
    react-native: 0.61.2 => 0.61.2
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-rename: 2.4.1

Has anybody found a solution for this problem?

Workaround: The first render refreshing prop should be false.
import React, { memo, useEffect, useMemo, useState } from 'react';
import { RefreshControl as RefreshControlCore, RefreshControlProps } from 'react-native';

const RefreshControl = memo(({ refreshing, ...props }: RefreshControlProps) => {
  const [firstRender, setFirstRender] = useState(true);

  useEffect(() => {
    const timeout = setTimeout(() => setFirstRender(false), 100);
    return () => clearTimeout(timeout);
  }, []);

  return (
    <RefreshControlCore
      refreshing={firstRender ? false : refreshing}
      {...props}
    />
  );
});

export default RefreshControl;

It seems like I've had to come up with some clugy workaround for this issue on iOS every couple of react-native releases and here I am again. None of the solutions above worked for me. You can set the contentInset={{ top: this.state.refreshing ? -60 : 0 }} on the FlatList and this works but there is no animation when the refresh control is hides.
The workaround that works for me is to (again, this is for iOS as android works fine out of the box):

Add the scrollToOverflowEnabled prop to the FlatList.

When the event to refresh fires call the following on a ref to the FlatList before setting refreshing to true:

this.flatListRef.scrollToOffset({ offset: -60, animated: false })
this.flatListRef.scrollToOffset({ offset: 0, animated: false })

This issue could be resolved on this PR https://github.com/facebook/react-native/pull/27236).

This issue could be resolved on this PR #27236).

In the case of a FlatList this issue still persists on iOS. Works perfectly on android when using the refreshing and onRefresh props in this way.
<FlatList style={styles.list}                 data={this.state.list}                 renderItem={this.renderItem}                 horizontal={false}                 numColumns={1}                 keyExtractor={item => item.id.toString()}                 refreshing={this.state.isRefreshing}                 onRefresh={ () => null }                 onScrollEndDrag={() => console.log("end")}                 onScrollBeginDrag={() => console.log("start")}                 onScrollToTop={() => console.log("top")}                 onEndReachedThreshold={5}                 onEndReached={() =>  console.log("onEndReached");}             />


Issue 1698: adding additional checks for internal class imports

What's changed?

This PR is attempting to address imports being removed by the RemoveUnusedImports recipe. It attempts to do this by creating a regex matcher to match against class paths that include both . and $ class delimiters. Since internal classes use the $, it causes them to not be recognized when checking if a variable is still referencing the class path.
What's your motivation?

My motivation is to fill this gap where RemoveUnusedImports causes an error in the resulting file by removing imports still in use.
Anything in particular you'd like reviewers to focus on?

I would like reviewing to scrutinize the regex approach I took. I think I have convinced myself that this approach will not be too generous as to result in false negatives.
Have you considered any alternatives or workarounds?

I currently cannot think of any.
Any additional context

Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've added the license header to any new files through ./gradlew licenseFormat
[x] I've used the IntelliJ auto-formatter on affected files
~[ ] I've updated the documentation (if applicable)~

Thank you @tclayton-newr !


stable hlo compare

Lower all compare ops to ttnn and add unit tests for each to tt-torch and tt-xla.

end-to-end implementation of compare ops (EQ, NE, GE, GT, LE, LT): https://github.com/tenstorrent/tt-mlir/pull/821
stableHLO conversion: https://github.com/tenstorrent/tt-mlir/pull/837

unit tests pending

tt-torch unit tests https://github.com/tenstorrent/tt-torch/pull/43
tt-xla unit tests https://github.com/tenstorrent/tt-xla/pull/92


some issues with the copy button

when i click on the copy button . this what I get copied
"# Install httpie
choco install httpie"
so I  think i will be be helpful if i can just copy the "choco install httpie"

This is more painful in REAMDE.md (commands get copied with $). From website the copied command at-least works (as the first line is consider as comment), but the commands copied form README.md fails straightaway..

Is anyone working on this??
@letmerecall can you please elaborate more?


Incorrect content-encoding for gzip when file is already available + compression-static

Search for duplicate issues

[X] I already searched, and this issue is not a duplicate.

Issue scope
Docker / Kubernetes
Describe the bug
If I run SWS with my "frontend" package, with both regular and pre-compressed files (.gzip), I see an unexpected content-encoding returned by SWS: content-encoding: gzip, gzip.
After verification, the content is packaged twice, aka a gzip inside a gzip.
This generates issues with Apple based browsers, because they don't process gzip twice and so can't parse js or css after the first "unpackaging".
How to reproduce it
Find attached files I have generated, with the unexpected result in SWS:
app-css.zip
If I run the SWS with docker run -it --rm -p 8080:8080 ui-for-testing, using the following configuration:
[general]

host = "::"
port = 8080
log-level = "info"

cache-control-headers = true
compression = true
compression-static = true
security-headers = true
directory-listing = false
redirect-trailing-slash = true
ignore-hidden-files = true

I get the following result when I run the following curl call:
curl 'http://localhost:8080/app.min.css' \
      -H 'Accept: */*' \
      -H 'Accept-Encoding: gzip' \
      -v -o nul &| grep content-encoding
< content-encoding: gzip, gzip

If I set compression-static = false, the result is "normal", but I suspect the compression is done by SWS and doesn't leverage the pre-built gzip file.
curl 'http://localhost:8080/app.min.css' \
      -H 'Accept: */*' \
      -H 'Accept-Encoding: gzip' \
      -v -o nul &| grep content-encoding
< content-encoding: gzip

Expected behavior
I expect the system to leverage the pre-build gzip and returns a content-type with only gzip once.
Complementary information
From the investigation I did, this bug has been introduced after 2.31.0.
If I change my Dockerfile to 2.32.0, I have the issue, but I don't have it with 2.31.0, of course with the same config and files.
Build target
Docker linux/amd64
Environment and specs

[x] static-web-server: [e.g. v2.32.0+]
[ ] Rust: [e.g. v1.78.0]
[x] OS: Distrolesss
[x] Arch: x86_64 (64-bit), ARM (32-bit), ARM64 (64-bit)
[x] Docker: 27.1.1
[x] Client: All (Safari, Chrome, Arc, curl)

Additional context
This issue has been found while developing on my application, Podcast-Server, and you can find the code used by the UI here

It's fixed by #471 and will be available in the next release.
I built those images using a production build containing the patch. So you can use it in the meantime.

joseluisq/static-web-server:devel
joseluisq/static-web-server:devel-alpine
joseluisq/static-web-server:devel-debian

Thanks for reporting!

Thank you for the fix, can't wait for it to be released!

Done v2.32.2.


Chat Polls

closes #56

handleSubmitPollOptionVote could debounce the broadcast with some 2 seconds delay, to have less traffic maybe.

Looks great and works as expected, good job! Just a few thoughts
Also, this happens on the admin interface when a student submits the poll (the poll options disappear, perhaps because the admin interface doesn't have some attribute that is accessed here?):

my fault i missed a activePoll. on pollOptions i guess, should be fixed now :)


Is it possible to start idle after last xhr request

My session will expire after 2 hours of http inactivity is it possible to listen to this?
And can I interrupt it on button click inside modal?

The module does not consider $http activity to determine idleness. The goal of this module is to look for user input/interaction.
Yes, you can manually interrupt by injecting $idle (or Idle in the upcoming v1.0.0 release) and calling watch().

I meant that my session will expire if user didn't do anything that will trigger API calls. Did I understand correctly that Keepalive service can help me with this?

Oh, sorry. Yes. By default, the idle service will use keepalive. keepalive will ping every 10 minutes (by default, configurable) while the user is active. It will stop pinging once the user enters the idle state. When the user returns to the active state after going idle, keepalive will immediately ping.
All you need to do is configure $keepaliveProvider.http() (or KeepaliveProvider.http() in v1.0.0) and it'll start sending HTTP requests for you using the options you specified. This works great for cookie-based session tokens because (in most cases) you just send a request to an HTTP endpoint and the browser will automatically include the session cookie for you. If that endpoint updates the session cookie and sends it back, the browser will take care of that for you, too.
However, if you need more control over sending and processing keepalive requests, you can leave http() option unset, listen for the $keepalive event (or KeepAlive in v1.0.0) and handle it yourself.

Thanks, now it is clear. When are you going to release v1.0.0?


Use % when dropping unique scene nodes into script

This expands upon #60708, using get_node("%NodeName") for nodes that have a unique scene name to avoid having to change the onready statements when the paths of the nodes change.
Preview:
@onready var login_screen: Control = $"%LoginScreen"

I think you just have to replace path here with "%" + node->get_name() when it's a unique name.
https://github.com/godotengine/godot/blob/26393cc0370bc4d7800ba29290e18367d256da67/editor/plugins/script_text_editor.cpp#L1571

That would result in paths like this: $%LoginScreen, but I think you're right, I can simplify this.

Thanks!

Tested locally. I think this PR is also good to cherrypick to 3.x.

Cherry-picked for 3.5.


Bumping asahi kernel to 6.9.12-2

Changing the kernel tag to the latest one (bundling the wifi driver fix)
Should fix #225.

Updated in the latest release, sorry for the delays.


Fixing issues with weird indent on raw string literals as arguments

closes #1169

I fixed the extra indent, but there is also the problem of the arguments not breaking properly. It looks like this problem also exists for multiline verbatim strings so it has been here for a while. I have the problem somewhat narrowed down, so hopefully can fix it within this PR
// input/expected output
CallMethod(
    """
    SomeRawString
    """.CallMethod().CallMethod()
);

CallMethod(
    @"
    SomeVerbatimString
    ".CallMethod().CallMethod()
);

// actual output
CallMethod("""
    SomeRawString
    """.CallMethod().CallMethod());

CallMethod(@"
    SomeVerbatimString
    ".CallMethod().CallMethod());

The problem is more apparent with multiple arguments
// input/expected output
CallMethod(
    """
    SomeRawString
    """.CallMethod().CallMethod(),
    []
);

// actual output
CallMethod("""
    SomeRawString
    """.CallMethod().CallMethod(), []);

I fixed the extra indent, but there is also the problem of the arguments not breaking properly. It looks like this problem also exists for multiline verbatim strings so it has been here for a while. I have the problem somewhat narrowed down, so hopefully can fix it within this PR
// input/expected output
CallMethod(
    """
    SomeRawString
    """.CallMethod().CallMethod()
);

CallMethod(
    @"
    SomeVerbatimString
    ".CallMethod().CallMethod()
);

// actual output
CallMethod("""
    SomeRawString
    """.CallMethod().CallMethod());

CallMethod(@"
    SomeVerbatimString
    ".CallMethod().CallMethod());

The problem is more apparent with multiple arguments
// input/expected output
CallMethod(
    """
    SomeRawString
    """.CallMethod().CallMethod(),
    []
);

// actual output
CallMethod("""
    SomeRawString
    """.CallMethod().CallMethod(), []);


Macro pattern matching with repeated terms

Unless I've missed some workaround, a macro-by-example definition is unable to check any of its inputs for equality. That means that such a macro cannot perform any reasoning about its inputs beyond their form and whether they are equal to the given constants. Most of the time, this restriction is not a problem, or at least can be worked around, but there are some cases where it forces the programmer to write a procedural macro instead. I've made an example of such a case on the playground, where the goal is to map an element from one list of tokens to the corresponding element in another list. Another example is a hypothetical if_eq!(a, b, c, d), which would return c if a and b were equal and d if not.
I propose allowing terms in the macro's pattern to be repeated as often as needed in order to specify that different parts of the pattern should be identical. It might look like this (taken from the playground example above, in case that ever changes):
($token:tt, ($token $(, $others_map1:tt)*), ($result:tt $(, $others_map2:tt)*)) => {
    $result
};

Notice that $token appears twice in the pattern. I would disallow adding another :tt after the first appearance, in order to avoid a conflict and to make sure the programmer actually meant to say that those tokens should be equal.
The same rules for lock-step evaluation of tokens would apply here as when the tokens appear on the right-hand side of the => operator. If $token:tt in the above example were replaced with $($token:tt)*, then the second $token would have to be some variation on $($token)*.
As for what exactly constitutes equality, I think it should be exact: numeric literals should be represented with the same strings (so 5, 5i32, and 5i64 would all be different), identifiers should have the same contexts as well as the same names, etc. But I may be missing something that could be a useful about inexact equality checking, so comments on this part are especially welcome.

You can check for equality, but not in the pattern itself: static-cond

Oh, thanks. My search for a workaround before posting this somehow didn't lead to that crate. It's functionally equivalent to what I proposed, so I find it acceptable if static-cond (or the technique it uses) is the only option.
I still like the syntax I've proposed: I think it would be cleaner for use cases like the map! macro in the playground example above, where the case in which the tokens are equal has a completely different right-hand side from the other case. If there are others who think the same, I'll be happy to make an RFC to add it to the language.
Alternatively, the syntax could mimic the guards in a match statement. I think I could implement it pretty easily now with a macro that replaces macro_rules!, and the consistency with the rest of Rust would be nice. I'll try it out--it might be the best solution to this issue.


Update work-with-change-data-sql-server.md

@MaraSteiu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @MaraSteiu - Would you make this update in the private repo? The change might be small enough to auto-merge. Thanks! We'll close this PR.


update nom to 2.0

https://unhandledexpression.com/2016/11/25/this-year-in-nom-2-0-is-here/

I have some of the chain! calls converted to do_parse! in another branch too.

Oh I oversaw this deprecation.
Rust does not warn about this. (Maybe it is not possible yet.)

No worries. I did it mainly to make sure I understood the new format.

I was just expected rustc to emits warning when compiling with deprecated functions.


hack: Add multi-node hack setup

This patch adds everything needed for a simple self-hosted multi-node
hack/dev cluster. It is opinionated to match the default vagrant VM
setup, but can be optionally configured.

LGTM. I like the helpers you've made for the config/render/start stuff -- we should try and do the same with single node too.


Prerequisites for exercises

I am a totally new to Go programming language and after learning on the python track I thought exercism would be the best and easiest way to learn Go.. But I have some issues with that.
After i joined the Go learning track just completing the hello world concept unlocked all the exercises. This was not the case with my python learning experience. It unlocked exercises as i completed the required prerequisites and it helped to try out what i learned by doing the exercise.
This is not a complain to the track maintainer to follow what the python track is like , it is my request as a new learner to make the learning experience more easier and more hands on.
so devs , track maintainers please consider adding prerequisites to the exercises it would make the learning much more easier and streamlined.
This is also my first time in GitHub , I am sorry for rant.

Thanks for reaching out. The reason the experience is different on the Go track is that we did not yet configure all the unlocking mechanism for the exercises. The open issue for this is here: https://github.com/exercism/go/issues/1396
This is a lot of work that nobody had time for yet. It also requires a lot of knowledge about the exercises and the concepts, so not something where we can easily ask the community for help.
Besides that, there are also some outstanding changes on the platform/website that we want to have implemented before adding this feature in Go.
Since we have that other issue to track the progress on this, I will close this one.


Better tests for stepping parameters

Use memory parameter and actually check the raw values in the step too
Move to the class where they belong.

The 3 test cases could be unified

@QCoDeS/core could anyone have a look at these?

@WilliamHPNielsen could you review this


fix unsubscribe is typing event if not focus on screen

Details

This PR is to fix the issue: When you join a room, you subscribe to various Pusher channels that should only be active while in that room. However, when you leave the room, sometimes it doesn't unsubscribe you from the channels. This "leak" will gradually slow down the app.

Fixed Issues

$ https://github.com/Expensify/App/issues/38905
PROPOSAL: https://github.com/Expensify/App/issues/38905#issuecomment-2027116863
Tests

Device A: Sign in with user A and open report with user B
Device B: Sign in with user B and open report with user A
Device A: Type anything in composer
Device B: Verify that there is a text "User A is typing..." appears below the composer for a while
Device B: Open another report
Device A: Type anything in composer
Device B: Open developer mode, choose "Console" tab. Verify that there is no [info] [Onyx] log in console. That message will be something like [info] [Onyx] merge() called for key: reportUserIsTyping_4555629044294735 properties: 15225462 - ""

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Device A: Sign in with user A and open report with user B
Device B: Sign in with user B and open report with user A
Device A: Type anything in composer
Device B: Verify that there is a text "User A is typing..." appears below the composer for a while
Device B: Open another report
Device A: Type anything in composer
Device B: Open developer mode, choose "Console" tab. Verify that there is no [info] [Onyx] log in console. That message will be something like [info] [Onyx] merge() called for key: reportUserIsTyping_4555629044294735 properties: 15225462 - ""

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/113963320/c6a42fb6-6fa4-410e-8b9e-68353d3aef51

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/74403c15-ea75-440c-9296-e271553b8610

iOS: Native

https://github.com/Expensify/App/assets/113963320/be54c42b-0479-4c2f-937c-f39bdc63e23e

iOS: mWeb Safari

https://github.com/Expensify/App/assets/113963320/7c028e18-23a8-40e3-811c-a7f364b489dc

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/604bcb55-fcfb-4496-b617-bed18ece0806

MacOS: Desktop

https://github.com/Expensify/App/assets/113963320/69dc23a1-b3c5-40cc-8f16-b4f975cc9a78

@tienifr There's a failing jest test, any ideas what might be causing that? Seems like it could be related to this PR.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

BUG: Switching to another report by searching and tapping on any report does not unsubscribe.
https://github.com/Expensify/App/assets/27287420/81d0f28b-5259-4c45-a869-cc75c7eb95a3

@tienifr The latest commit doesn't seem to fix the issue, e.g. following these repro steps:

Open any report A as user A
Tap the search icon and select any other report B
Open report A as User B and start typing
Observe that reportUserIsTyping is still showing in the console

The same happens if requesting money from another chat/workspace (which causes a switch to another report).

@tienifr Unfortunately I'm still seeing the same issue. Can you make sure to retest for that issue before asking for re-review? Thanks! :pray:

@Beamanator makes sense to me!

@tienifr please merge main 1 more time to hopefully fix the tests

Hmm I'm not seeing the Jest test (job3) failing on other, recently created PRs so I'm wondering if this is actually related to this PR -> I'm also seeing it fail locally in your fork & branch, @tienifr  🤔

@tienifr hmm that's interesting, that's a different error than I'm seeing, though in the same file 😅  Here's what I'm seeing in your PR & in github actions:
FAIL tests/ui/UnreadIndicatorsTest.tsx (44.075 s)
  ● Unread Indicators › Clear the new line indicator and bold when we navigate away from a chat that is now read

    TypeError: Cannot read properties of undefined (reading 'props')

      175 |     const hintText = Localize.translateLocal('accessibilityHints.navigatesToChat');
      176 |     const optionRows = screen.queryAllByAccessibilityHint(hintText);
    > 177 |     fireEvent(optionRows[index], 'press');
          |              ^
      178 |     await waitForBatchedUpdatesWithAct();
      179 | }
      180 |

FYI I started a slack thread cuz that may be easier to discuss there - https://expensify.slack.com/archives/C01GTK53T8Q/p1712745268351209

@tienifr please review the change I suggested - if it makes sense to you, can you please make the change & pull main & test hopefully 1 last time?

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix to identify unsuccessful Http response codes

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.49%. Comparing base (550e72f) to head (4373cbe).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##               main      #84   +/-   ##
=========================================
  Coverage     97.49%   97.49%
- Complexity      281      285    +4
=========================================
  Files            33       33
  Lines           797      798    +1
  Branches         74       74
=========================================
+ Hits            777      778    +1
  Misses            9        9
  Partials         11       11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Live Trains] Platform alteration announcements with live trains?

Is there a possibility, as a future enhancement to the live trains system, that live platform changes are featured? This would therefore ensure maximum realism when the system is active alongside the other enhancements already noted.
It would therefore also fill the gap between the intial announcement and any approaching/standing messages so there isn't any conflicting information between them.

Requires timetable ingestion


[2.8.1] FGC and throw NPE

Describe the bug
The phenomenon of our online problem is as follows:
1. NPE exception: (This is the same as the NPE exception in your PR, but only this type of NPE was found. I see two NPEs mentioned in your PR)
03:22:50.442 [BookKeeperClientWorker-OrderedExecutor-4-0] ERROR org.apache.bookkeeper.common.util.SafeRunnable - Unexpected throwable caught
java.lang.NullPointerException: null
at org.apache.bookkeeper.mledger.impl.OpAddEntry.addComplete(OpAddEntry.java:153) ~[org.apache.pulsar-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at
2. Frequent FGC, I dumped the memory and found that there are a lot of pendingAddOp objects (more than seven million), but the write traffic has dropped to the bottom:

3.Looking at the log, some thread pools take too long to execute tasks, even reaching the hour level:
03:23:47.838 [bookkeeper-ml-scheduler-OrderedScheduler-54-0] WARN  org.apache.bookkeeper.common.util.OrderedExecutor - Runnable org.apache.bookkeeper.mledger.impl.ManagedCursorImpl$$Lambda$1000/1597732433@2fc9a98e:class org.apache.bookkeeper.mledger.impl.ManagedCursorImpl$$Lambda$1000/1597732433 took too long 12721684 micros to execute.
03:24:53.508 [bookkeeper-ml-scheduler-OrderedScheduler-32-0] WARN  org.apache.bookkeeper.common.util.OrderedExecutor - Runnable org.apache.bookkeeper.common.util.OrderedExecutor$TimedRunnable@3f387130:class org.apache.bookkeeper.common.util.OrderedExecutor$TimedRunnable took too long 16594876 micros to execute.
03:26:02.079 [bookkeeper-ml-scheduler-OrderedScheduler-35-0] WARN  org.apache.bookkeeper.common.util.OrderedExecutor - Runnable org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$$Lambda$92/1773008684@4ddf5185:class org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$$Lambda$92/1773008684 took too long 17111879 micros to execute.
4. zookkepeer session timeout:
03:26:02.079 [bookkeeper-ml-scheduler-OrderedScheduler-35-0] WARN  org.apache.bookkeeper.common.util.OrderedExecutor - Runnable org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$$Lambda$92/1773008684@4ddf5185:class org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$$Lambda$92/1773008684 took too long 17111879 micros to execute.
I noticed there is this PR that may be related to this issue: https://github.com/apache/pulsar/pull/12993

@eolivelli @codelipenghui @michaeljmarshall PTAL,thanks!

Unexpected throwable caught
java.lang.NullPointerException: null
at org.apache.bookkeeper.mledger.impl.OpAddEntry.addComplete(OpAddEntry.java:153) ~[org.apache.pulsar-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]

This looks like a thread safety issue. There's #12606 which improves the situation slightly. The solution in #11387 would help address such issues in better way although that still has some gaps and possible issues.

Unexpected throwable caught
java.lang.NullPointerException: null
at org.apache.bookkeeper.mledger.impl.OpAddEntry.addComplete(OpAddEntry.java:153) ~[org.apache.pulsar-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]

This looks like a thread safety issue. There's #12606 which improves the situation slightly. The solution in #11387 would help address such issues in better way although that still has some gaps and possible issues.

The most confusing thing is why the FGC is triggered, and the thread pool execution time reaches the hour level：
04:35:46.571 [bookkeeper-ml-scheduler-OrderedScheduler-18-0] WARN  org.apache.bookkeeper.common.util.OrderedExecutor - Runnable org.apache.bookkeeper.mledger.util.SafeRun$1@89aa735:class org.apache.bookkeeper.mledger.util.SafeRun$1 took too long 13450016 micros to execute.
I even took an execution task to see and found that it is only reading and writing zk, and the timeout time of zk is only 30 seconds, so I can't understand why it reaches the hour level

I even took an execution task to see and found that it is only reading and writing zk, and the timeout time of zk is only 30 seconds, so I can't understand why it reaches the hour level:

What do you mean with "reaches the hour level"? 13450016 microseconds is 13,45 seconds .

The most confusing thing is why the FGC is triggered

With FGC, do you mean "Full GC"? The GC log tells the reason why Full GCs get triggered. GC logging was added by #7498 . Have you checked the GC log entries?

I noticed there is this PR that may be related to this issue: #12993

Yes, #12993 could help addressing the NPE. Have you the behavior with Pulsar 2.8.2 which includes #12993?

What do you mean with "reaches the hour level"? 13450016 microseconds is 13.45 seconds .

Aha,I was wrong, it was 13.45 seconds .

I didn't test 2.8.2, only found NPE in 2.8.1

I noticed there is this PR that may be related to this issue: #12993

Yes, #12993 could help addressing the NPE. Have you tested the behavior with Pulsar 2.8.2 which includes #12993?

I didn't test 2.8.2, only found NPE in 2.8.1

The most confusing thing is why the FGC is triggered

With FGC, do you mean "Full GC"? The GC log tells the reason why Full GCs get triggered. GC logging was added by #7498 . Have you checked the GC log entries?

The gc log of the node in question is not saved. I found some FULL GC logs from other FULL GC logs on the line, but these nodes are not continuously FULL GC:
2022-02-15T12:45:47.604+0800: 423715.809: [Full GC (Allocation Failure)  23G->10G(24G), 11.4667426 secs]
[Eden: 0.0B(12.0G)->0.0B(12.0G) Survivors: 0.0B->0.0B Heap: 23.9G(24.0G)->10.6G(24.0G)], [Metaspace: 65542K->65542K(1114112K)]
[Times: user=20.56 sys=0.00, real=11.47 secs]
The JVM monitoring of the problem broker is as follows:

I uploaded the dump file to Baidu Cloud Disk, which can be downloaded here:
https://pan.baidu.com/s/1qNMQFS5QtpkwcKpOlK5HiA
Extraction code: cvgr

close by #14515


What should happen when applying opacity less than 1 to a node with descendants?

Hello Julian,
I'd like your opinion:
If we have a node (in a 3D scene graph), and it has many descendants (a sub tree), what should happen when we apply opacity with a value less than 1 to it?

It, and all of it's children should become transparent, multiplying opacities down the scene graph.
It's content should become transparent but not that of its descendants.
Same as (1), but the whole object should be flattened into a plane.

The reason I want your opinion is because the new specs for CSS 3D (css-transforms) state here that the answer is (3).
To see what I mean, view these two examples in Chrome 53 or higher:

https://jsfiddle.net/trusktr/ymonmo70/16
https://jsfiddle.net/trusktr/ymonmo70/17

The second example has opacity applied to the node that contains all the sub-nodes which compose the car. The opacity, according to spec, flattens the car into a plane (turns it into paper!).
I'm asking various 3D engine authors for opinions of what the correct or most expected behavior should be.
All the best,
~ Joe

As a CSS dev, 3 seems to make sense. 1 would present some really interesting options, and ideally would also be available (for example if you explicitly set transform-style: preserve-3d), but as the default would make it much more complex to control the opacity of anything (and would have strange effects with occlusions changing on its children)- it's also a lot less taxing on the rendering engine.

1 makes more sense to me.
Applying opacity to an element should not change the way it looks, except of course the opacity of this node and his children.
To me 3 looks more like a workaround to avoid complex 3D opacity rendering.


Reading from PDF

This page does not tell me why Load button is greyed.  Only Cancel is enabled.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6ab70d2-6a8d-9457-9fe0-b7e5a11f7a23
Version Independent ID: 8d847641-59f8-8914-799d-0c1c7ccad9a6
Content: Connect to a PDF file in Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-connect-pdf.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @fauzisd.
I've assigned this issue to the doc author for review.
In the meantime, you might find an answer in the Power BI Community.

Hi @fauzisd ,
Thank you for your question.  Until you've made a selection from the left side of the screen (selected one or more tables), the Load button will remain grey.  If that doesn't answer your question, please let us know.
All the best,
The DOCS team


Fix search colors for PST 0.16.0

I just noticed the search bar colors are off with PST 0.16.0. This PR restores the correct outline color.
Before this PR:

After this PR:

Thanks @melissawm, merging now!


add audio message in jsqmessages

how to allow jsqmessages to send  audio messages ??

Hey @KhaledAld :smile:
I'm cleaning up old issues and trying to finish the next release of the library. I'm sorry I don't have time to respond to all questions.
I'm going to close this issue, but the community should feel free to continue the discussion.
Other ways to get help:

Ask on StackOverflow with the jsqmessagesviewcontroller tag
See the FAQ
Search previous questions


Unified API response format

Drop all jsonify (pallets/flask#3111)
Unified using after_request

Implemented in fb98138


[Update Snap] FIO Wallet

Checklist
All items in the list below needs to be satisfied.

[ ] Is the summary of the change documented in this ticket?
[ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
[ ] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
[ ] The corresponding pull request in this repo has been merged.

Updates:

https://github.com/fioprotocol/fio-wallet-snap/pull/26
https://github.com/fioprotocol/fio-wallet-snap/pull/27
https://github.com/fioprotocol/fio-wallet-snap/pull/28
https://github.com/fioprotocol/fio-wallet-snap/pull/29
https://github.com/fioprotocol/fio-wallet-snap/pull/30
https://github.com/fioprotocol/fio-wallet-snap/pull/31
https://github.com/fioprotocol/fio-wallet-snap/pull/32


Declare O_RSYNC for Android

Bionic defines it to be O_SYNC.
For context, this is where this option was necessary.

r? @JohnTitor
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 4f47a74be179f361e7f38f684cdd5efdc352aefb has been approved by JohnTitor

:hourglass: Testing commit 4f47a74be179f361e7f38f684cdd5efdc352aefb with merge 9d70c0668eaf5a17ca976567329b40f811dd589c...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 9d70c0668eaf5a17ca976567329b40f811dd589c to master...


Support duplicated key in KVStore when ingesting

What problem does this PR solve?
Issue Number: ref #7256
Problem Summary:
In raftstore-v2, snapshots are represented in the format of a rocksdb, which means duplicated keys can be find while reading from difference layers of a snapshot.
We will allow this when we find the value is also equal.
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/merge


⚠ Bofrost.be has degraded performance

In d5e1e70, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1218 ms

Resolved: Bofrost.be performance has improved in bbd262b after 6 minutes.


SortedColumnIndex BindingMode "TwoWay"

I´m using your control for my IOS Maui App.
I just want to set the sortOrder in the background as well. So I bind the sortorder to a viewmodel property and set the binding mode "Two way" in xaml file (SortedColumnIndex="{Binding SortIndex,Mode=TwoWay}"). But this leads to an NullReferenceException.
What am I doing wrong?
Furthermore I also have trouble with the SelectedItem property. I bind it two way in xaml: SelectedItem="{Binding SelectedDefect,Mode=TwoWay}, because I want to change the selection in the Background. But sometimes the datagrid don´t show the selection or it show 2 selected items, but I only have one selected item in the background.

The code is super simple, and doesn't rely on any platform-specific rendering. I recommend pulling the repository into your codebase, and then stepping through it with the debugger to find the problem. Then submit a PR.
Also MAUI has lots of bugs and you should keep an eye on whether any of them match what you are seeing, and keep an eye on when it is fixed.
If you want me or someone else to take a look at this, you should build a minimal reproducible test case using the included SampleApp as a starting point, and state which MAUI version (including the point release) you are using.
Also it would be best to break up the issues into individual issues, so that they can be addressed individually.

Thanks for your reply.
To find the error with the sorting issue I set  SortedColumnIndex="{Binding SortIndex,Mode=TwoWay}" and debugged the code. In the screenshot zu see the exception and the sourceposition where it occurs. Hope this helps.

So, I further debugged the datagrid and found that the error comes from the rotating icon function.
I am using .Net 8 Prev. 5.

In your sample code you use .Net7 and it works, so this seems to be a Maui bug?

I have found that being active on the official MAUI github is useful, because if you can build a minimal reproducible test case then they can try to fix the problem.
I would consider upgrading to .NET 8 Preview 7 before making a bug report, though.

Still a problem with .NET 8, and/or the latest master branch? Closing until I hear otherwise.


Now that all-repos can read from an env var, is there any reason to use this plugin anymore?

It looks like all-repos got support for reading from an env var last year: https://github.com/asottile/all-repos/commit/b3d2d9ef85b63284dc4e768cb5288ce36c222ee6.
Is there any reason for this project to still exist?

Oh I didn't realise it was added! Thanks for letting me know.
The only thing that this plugin does which the built in implementation doesn't do (I think) is the ability to read from a .env file. So if you need that, it would be reason. I recall Anthony was quite strongly against the idea back when I started this extension...

The only thing that this plugin does which the built in implementation doesn't do (I think) is the ability to read from a .env file

That makes sense! I personally prefer to use direnv for that sort of thing, so I'll stick with vanilla all-repos.

I recall Anthony was quite strongly against the idea back when I started this extension

Haha, yeah, he seemed pretty against it in https://github.com/asottile/all-repos/issues/79, but then merged up https://github.com/asottile/all-repos/pull/275 without much fanfare. :shrug:
I'll close this issue. You might want to update the part of your readme that says "I wanted this feature, but it looks like it won't be implemented in the main repo"

You might want to update the part of your readme that says "I wanted this feature, but it looks like it won't be implemented in the main repo\

Yes, I'll leave it open in the meantime 😊


Update installation instructions for latest Go version

go install is now required when not running from within a module, and the subcommand path is required as the root is not a main package.

That sounds good! Feel free to take merge or close this and do whichever you wish. I only submitted the change because the other instructions didn't work when I tried to install it for CLI usage. Thanks!


implement hot module reloading for CommonJS modules as well

Is it possible to implement this easily or is there maybe some simple workaround or something similar? Or maybe is there any existing loader or solution that would help with this?
This would be really nice to have. We could replace Nodemon with dynohot and have faster development experience.

CommonJS is a fundamentally different module system and would require a pretty hefty implementation to get hot reloading right. I'm a militant supporter of ESM over CommonJS and would go so far as saying that continued support of CommonJS is an act of violence against the JavaScript community. There's just no reason to continue using CommonJS.
I think nodemon's popularity over dynohot is just a problem of publicity. I think any team that learns about and tries dynohot would immediately switch over.

Yes, I agree.
I tried to find a codemod or something. The ones I tried were not working properly, but at least in the meantime, we can use both (nodemon and dynohot).
Would be nice to have some Node.js module customization based solution if that makes sense as an alternative to Create React App and similar tools, but I couldn't find anything like that so far.


what is the best way to cache a http request ?

if I want to cache the response for at least 2 minutes, so next client gets same response,
is there a built in feature ? or do I need to add something like reddis?

@medyagh chi is just a simple router, you can layer in any technique you'd like. I suggest doing some research on "http caching" and "cache-control"

for the record, I ended up using memached.


Only one icon is visible on Andriod 8.0

Hi,
First a big thank you for cpustats - it is a really good tool 👍
My OnePlus3T got Andriod 8.0 this weekend...
The cpustats application seems to work - but only shows one icon of the two possible in the notification bar.
The live graph is not visible anymore only the icon showing the core speed as a numver is shown.

Thanks, but we can't support Android 8.0 or later due to the Android system limitation.

Thanks for your reply
What does that mean ? is the problem/limitation impossible to solve ?
Does this mean that the project dead/stopped ?
And we should find another cpustat meter for Andriod 8 devices and forward ?

What does that mean ? is the problem/limitation impossible to solve ?

yes, impossible.

Does this mean that the project dead/stopped ?

unfortunately yes.

And we should find another cpustat meter for Andriod 8 devices and forward ?

yes, but may be nothing in the world of no-rooted devices.

What does that mean ? is the problem/limitation impossible to solve ?

yes, impossible.

Does this mean that the project dead/stopped ?

unfortunately yes.

And we should find another cpustat meter for Andriod 8 devices and forward ?

yes, but may be nothing in the world of no-rooted devices.
see https://issuetracker.google.com/issues/37140047

Ok, sad news - but thanks for your efforts - I really enjoyed your app the last years :-) 👍


api not found

{"message":"Not Found","stack":"Error: API not found\n    at APIError.ExtendableError (/home/syed/Documents/api/UserRole/dist/server/helpers/APIError.js:35:11)\n    at new APIError (/home/syed/Documents/api/UserRole/dist/server/helpers/APIError.js:63:101)\n    at /home/syed/Documents/api/UserRole/dist/config/express.js:122:13\n    at Layer.handle [as handle_request] (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/layer.js:95:5)\n    at trim_prefix (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:312:13)\n    at /home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:280:7\n    at Function.process_params (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:330:12)\n    at next (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:271:10)\n    at Layer.handle [as handle_request] (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/layer.js:91:12)\n    at trim_prefix (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:312:13)\n    at /home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:280:7\n    at Function.process_params (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:330:12)\n    at next (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:271:10)\n    at /home/syed/Documents/api/UserRole/node_modules/express-winston/index.js:306:9\n    at Layer.handle [as handle_request] (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/layer.js:95:5)\n    at trim_prefix (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:312:13)\n    at /home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:280:7\n    at Function.process_params (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:330:12)\n    at next (/home/syed/Documents/api/UserRole/node_modules/express/lib/router/index.js:271:10)\n    at cors (/home/syed/Documents/api/UserRole/node_modules/cors/lib/index.js:179:7)\n    at /home/syed/Documents/api/UserRole/node_modules/cors/lib/index.js:229:17\n    at originCallback (/home/syed/Documents/api/UserRole/node_modules/cors/lib/index.js:218:15)"}

What URL/endpoint are you trying to hit?

its working now i have to put api in front now its done
On Tue, Nov 21, 2017 at 6:44 AM, Dylan Bromby<EMAIL_ADDRESS>wrote:

What URL/endpoint are you trying to hit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KunalKapadia/express-mongoose-es6-rest-api/issues/428#issuecomment-345884373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AffUF7my4Q9O58aINT7U_hy9Fmi9lu-Lks5s4iQSgaJpZM4QdHKf
.

Same issue is coming for me. I am hitting localhost:port/user/

Same issue for me . I am hitting the endpoint /api/{routename}/path. It says api not found

@kartikwar how do fix this issue?


ARROW-13296: [C++] Provide a reflection compatible enum replacement

I recommend avoiding macros whenever possible, but for completeness I'll note that we could replace
// color.h
struct Color : EnumType<Color> {
  using EnumType::EnumType;
  static constexpr const char* kValues = R"(red green blue)";
};
// color.cc
constexpr const char* Color::kValues;

with
ARROW_ENUM(Color, red green blue);

Quick question, why did 'try replacing an enum' ultimately stay reverted? Did you just mean to leave it as a followup?

I can certainly replace one in this PR but I wasn't sure that'd be preferred. I was mostly using it as a test to ensure that the C++ builds could all pass with the replacement- if we want to include a replacement here then I'll need to repair the bindings as well

Ah nah just wanted to make sure of the intent. Let's merge this? I'll file a JIRA to adjust the bindings and definitions.

ARROW-13307

I want to provide one more tweak to make it easier to enable_if and provide a doccomment

but I can just append that to the follow up

If you wanna do that here that's no problem


added project accepting first time contribution

This seems to have some merge conflicts because we merged earlier pull request. If you have time to
solve the conflict we happily merge it :)

yup, sure.
On Sun, Oct 21, 2018 at 12:19 AM Benny Carlsson<EMAIL_ADDRESS>wrote:

This seems to have some merge conflicts because we merged earlier pull
request. If you have time to
solve the conflict we happily merge it :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lingonsaft/hacktoberfest/pull/2111#issuecomment-431608446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdNovRKZWDyl3h7u_hrht4EtCIr_iL4fks5um3BHgaJpZM4XwFnj
.


Add description and example uasge for Plugin.FromSources to reference.conf file

org.virtuslab.ideprobe.dependencies.Plugin.FromSources could be used in probe.intellij.plugins array. It looks like FromSources usage is dedicated to users, who interact with ide-probe rather by direct code calls (and not by the .conf file), because it requires the user to have a custom implementation of DependencyBuilder and register it by using org.virtuslab.ideprobe.dependencies.DependencyProvider#registerBuilder
For now, I did not manage to find it's real-life usage in ide-probe nor in known repositories, which use ide-probe.

TBD if it needs to be maintained at all!

It is useful in config. It requires adding code, yes, but it doesn't mean it should not be in the config.
There are existing builders for scala and pants plugin. It requires to add PantsPluginExtension in your code and then in the config you can put this as plugin:
{
      id = "pants",
      repository = { path = "https://github.com/tpasternak/intellij-pants-plugin.git", ref = "bump-203-pr-1.26.x" }
      env = { "PANTS_SHA" = "1.25.x-twtr" }
    }

So then it is easy to test your code agains prereleased plugin versions from custom branch/commit from fork or official repository.


Add spring-cloud-starter-config dependency to all generated applications

This will enable use of config server if it is available.

Is this adding the config server or the config client or both ?

Is this adding the config server or the config client or both ?

Ok, I can see that this is what is added when 'Config Client' is selected in initializr.


Fix CI

The CI is failing on Ubuntu because the version of odoc-parser in odoc.2.1.0 conflicts with the version of odoc-parser in ocamlformat.0.24.1. I suggest we merge this as is and upgrade to odoc.2.2.0 in another PR.


⚠ Bofrost.be has degraded performance

In 5ba288d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1567 ms

Resolved: Bofrost.be performance has improved in 94da8cf.


Improve include in templates

To include static file @[../static/index.html]@

Related issue https://github.com/tshemsedinov/impress/issues/363