Binding a function as a class method

I plan to write a header parser that automatically generates all my Lua binding code for sol2. Part of this will involve creating extra functions for any method that accepts a shared_ptr as an argument, as well as new functions to mimic default arguments. For example, this class method:
void Entity::SetParent( shared_ptr<Entity> parent, const bool global = true)

Would result in the following two auto-generated functions:
void ENTITY_SETPARENT(Entity& self, Entity& arg1)
void ENTITY_SETPARENT(Entity& self, Entity& arg1, const bool arg2);

Is there a way to trick sol into treating ENTITY_SETPARENT like it is a class method that can be called like this in Lua?:
entity:SetParent(parent,true)

I tried this and it actually works. Here's my original C++ method:
``class World
{
void Render(shared_ptr buffer);
}```
And here is my wrapper function:
{
	world.Render(dynamic_pointer_cast<Buffer>(buffer.Self()));
}```
Sol binding code:
```lua.new_usertype<World>("World", "Render", SOL_WORLD_RENDER);```

The lua code obj:func( arg1, arg2, ... ) is actually identical to obj.func( obj, arg1, arg2, ...). A free function which takes self& as its first member function is identical -- in Lua terms -- to a member function in C++.
So we don't force you to worry about it / care when bound.


Allow overriding unparser for KPrint/KRun/KProve

https://github.com/runtimeverification/pyk/pull/183 changes the way that we cache properties in the KPrint class (to use more standard Python features). But this breaks some functionality in KEVM where we were manually overriding the unparsing definition and unparsing symbol table.
Here is a proposed solution:

Thread optional arguments definition and patch_symbol_table into each constructor.
If these arguments are present, ignore the definition on disk and use these ones.

Here is where I adapt KEVM to this scheme: https://github.com/runtimeverification/evm-semantics/pull/1546
Some alternatives (perhaps better?)

Instead of allowing overriding the entire KDefinition, allow specifying extra_modules that should be included into the one read on disk. This should be compatible with all the uses in KEVM.
Instead of allowing to pass in patch_symbol_table as an argument, make it a method with default implementation the identity. Then subclases can override it as needed. This may be cleaner code-wise.

Instead of allowing to pass in patch_symbol_table as an argument, make it a method with default implementation the identity. Then subclases can override it as needed.

I think that's the idiomatic solution here. So something like
class KPrint
    @cached_property
    def symbol_table(self) -> SymbolTable:
        symbol_table = build_symbol_table(self.definition, opinionated=True)
        self._patch_symbol_table(symbol_table)
        return symbol_table

    @classmethod
    def _patch_symbol_table(cls, symbol_table: SymbolTable) -> None:
        pass

Instead of allowing overriding the entire KDefinition, allow specifying extra_modules that should be included into the one read on disk. This should be compatible with all the uses in KEVM.

That sounds good too. If we need a more flexible approach, we can add a method _patch_definition and deal with it in a similar way as we do with symbol_table.

I've tested this with KEVM, and it seems to behave as expected (in the linked pyk update: https://github.com/runtimeverification/evm-semantics/pull/1546).


Use Clang to build MJX

I got a compilation issue while compiling mujoco-mpc with GNU c++ compiler:
#10 912.6         /opt/mujoco-mpc/mjpc/../mjpc/spline/spline.h:106:9: error: expected unqualified-id before ‘const’
#10 912.6           106 |         const IteratorT<SplineType, NodeType>& other) = default;
#10 912.6               |         ^~~~~
#10 912.6         /opt/mujoco-mpc/mjpc/../mjpc/spline/spline.h:105:37: error: expected ‘)’ before ‘const’
#10 912.6           105 |     IteratorT<SplineType, NodeType>(
#10 912.6               |                                    ~^
#10 912.6               |                                     )
#10 912.6           106 |         const IteratorT<SplineType, NodeType>& other) = default;
#10 912.6               |         ~~~~~
#10 912.6         /opt/mujoco-mpc/mjpc/../mjpc/spline/spline.h:109:68: error: expected ‘)’ before ‘&&’ token
#10 912.6           109 |     IteratorT<SplineType, NodeType>(IteratorT<SplineType, NodeType>&& other) =
#10 912.6               |                                    ~                               ^~
#10 912.6               |                                                                    )

The developers of mujoco-mpc use Clang to compile (https://github.com/google-deepmind/mujoco_mpc/blob/main/.github/workflows/build.yml#L19).
From now on, the default compiler for MJX is Clang, but can be changed via docker arguments.

The plan from an offline discussion between @DwarKapex and me is to use multi-stage build to create the MPC wheel using clang and then bring it into the mealkit/final image to avoid interfering with the default compiler toolchain. This is similar to how we build the jaxlib wheel in the JAX core image and also how we build the tensorflow-text/lingvo packages in the T5X/Pax arm64 images.


homebrew formula

I don't think one exists yet, but it would be a nice touch to simplify installation on OSX at least.

Guess I'm reopening this one :-)
Merging #138 made it possible to change the install dir of homeshick and there are already packages out there for both openSUSE and archlinux. If anybody would like to create a homebrew formula for homeshick, I'd be happy to help.

As I am using homeshick now, I opened a PR for homeshick homebrew/homebrew-core#1758

The patch is needed because due to the fact that bin/homeshick is not simply
a binary you can execute. However, homebrew makes files in bin/ available in
PATH leading to strange results before the required export and sourcing
happens.

This doesn't sound particularly easy to package for Homebrew given the need for the not small patch that won't ever be accepted upstream in the current format. It seems like a good middle ground would be to work with upstream for better configurability.

Hey @andsens, ist there something that could be done to make packaging homeshick for homebrew easier? main issue is that files in /bin are treated as normal executables and thus added to $PATH. to prevent a situation where homeshick (the one in /bin) is available before the source'ing happens, I moved it out of the way for homebrew and adjusted the the scripts a user needs to source.

to prevent a situation where homeshick (the one in /bin) is available before the source'ing happens, I moved it out of the way for homebrew and adjusted the the scripts a user needs to source.

You don't need to. In all languages aliases or functions take precedence over executables on $PATH.
I just tested it for bash, zsh and csh myself (not fish though, but I'd be surprised if it was different).

yes, however homeshick (as binary) is immediately available and creates a strange looking error:
XXPM00355799A:homebrew-core d061778$ homeshick
/usr/local/bin/homeshick: Zeile 6: /Users/d061778/.homesick/repos/homeshick/lib/exit_status.sh: No such file or directory
/usr/local/bin/homeshick: Zeile 7: /Users/d061778/.homesick/repos/homeshick/lib/fs.sh: No such file or directory
/usr/local/bin/homeshick: Zeile 8: /Users/d061778/.homesick/repos/homeshick/lib/git.sh: No such file or directory
/usr/local/bin/homeshick: Zeile 9: /Users/d061778/.homesick/repos/homeshick/lib/log.sh: No such file or directory
/usr/local/bin/homeshick: Zeile 10: /Users/d061778/.homesick/repos/homeshick/lib/prompt.sh: No such file or directory
/usr/local/bin/homeshick: Zeile 127: /Users/d061778/.homesick/repos/homeshick/lib/commands/help.sh: No such file or directory
GNU bash, Version 4.3.42(1)-release (x86_64-apple-darwin14.5.0)
Die Shell Kommandos sind intern definiert.  Mit `help' kann eine Liste
angesehen werden.  Durch `help Name' wird eine Beschreibung der
Funktion `Name' angezeigt.  Die Dokumentation ist mit `info bash'
einsehbar.  Detaillierte Beschreibungen der Shellkommandos sind mit
`man -k' oder `info' abrufbar.

Ein Stern (*) neben dem Namen kennzeichnet deaktivierte Kommandos.

 Jobbezeichnung [&]                      history [-c] [-d Offset] [n] oder hi>
 (( Ausdruck ))                          if Kommandos; then Kommandos; [ elif>
 . Dateiname [Argumente]                 jobs [-lnprs] [Jobbez. ...] or jobs >
 :                                       kill [-s Signalname | -n Signalnumme>
 [ Argument... ]                         let Argument [Argument ...]
 [[ Ausdruck ]]                          local [Option] Name[=Wert] ...
 alias [-p] [Name[=Wert] ... ]           logout [n]
 bg [Jobbezeichnung ...]                 mapfile [-n Anzahl] [-O Quelle] [-s >
 bind [-lpsvPSVX] [-m Tastaturtabelle]>  popd [-n] [+N | -N]
 break [n]                               printf [-v var] Format [Argumente]
 builtin [Shellkommando [Argument ...]>  pushd [-n] [+N | -N | Verzeichnis]
 caller [Ausdruck]                       pwd [-LP]
 case Wort in [Muster [| Muster]...) K>  read [-ers] [-a Feld] [-d Begrenzer]>
 cd [-L|[-P [-e]] [-@]] [Verzeichnis]    readarray [-n Anzahl] [-O Quelle] [->
 command [-pVv] Kommando [Argument ...>  readonly [-aAf] [Name[=Wert] ...] od>
 compgen [-abcdefgjksuv] [-o Option]  >  return [n]
 complete [-abcdefgjksuv] [-pr] [-DE] >  select Name [in Wortliste ... ;] do >
 compopt [-o|+o Option] [-DE] [Name ..>  set [-abefhkmnptuvxBCHP] [-o Option]>
 continue [n]                            shift [n]
 coproc [Name] Kommando [Umleitungen]    shopt [-pqsu] [-o] [Optionsname ...]>
 declare [-aAfFgilrntux] [-p] Variable>  source Dateiname [Argumente]
 dirs [-clpv] [+N] [-N]                  suspend [-f]
 disown [-h] [-ar] [Jobbezeichnung ...>  test [Ausdruck]
 echo [-neE] [Argument ...]              time [-p] Pipeline
 enable [-a] [-dnps] [-f Dateiname] [N>  times
 eval [Argument ...]                     trap [-lp] [[Argument] Signalbezeich>
 exec [-cl] [-a Name] [Kommando [Argum>  true
 exit [n]                                type [-afptP] Name [Name ...]
 export [-fn] [Name[=Wert] ...] oder e>  typeset [-aAfFgilrtux] [-p] Name[=We>
 false                                   ulimit [-SHabcdefilmnpqrstuvxT] [Gre>
 fc [-e Editor] [-lnr] [Anfang] [Ende]>  umask [-p] [-S] [Modus]
 fg [Jobbezeichnung]                     unalias [-a] Name [Name ...]
 for Name [in Wortliste ... ] ; do Kom>  unset [-f] [-v] [-n] [NAME ...]
 for (( Ausdr1; Ausdr2; Ausdr3 )); do >  until Kommandos; do Kommandos; done
 function Name { Kommandos ; } oder Na>  variables - Namen und Bedeutung eini>
 getopts Optionen Variable [Argumente]>   wait [-n] [id ...]
 hash [-lr] [-p Pfadname] [-dt] [Name >  while Kommandos; do Kommandos; done
 help [-dms] [Muster ...]                { Kommandos ; }

While this is sort of expected (neither HOMESHICK_DIR was exported nor the relevant file sourced), I think we could avoid this kind of confusion easily.

Ah. OK, why then not simply patch this line. Doing that also ensures that the executable works. Meaning it's scriptable etc.

Wouldn't this mean homeshick cd would no longer work?
Currently I move & patch the source files for the different shells to keep the cd ability.

Wouldn't this mean homeshick cd would no longer work?

Well no. As soon as you source the proper function file writing homeshick in bash refers to the function rather than the executable, so it just overrides.
You can do one of two things:

Make sure that $HOMESHICK_DIR is set to the proper directory. This requires that users add that setting to their bashrc, which isn't really much to ask, since they need to add the source statement anyways (openSuse and archLinux do it this way I think).
Change the $HOMESHICK_DIR default to ${opt_prefix} in all the files. This would make sure that homeshick can be called without $HOMESHICK_DIR having to be set, which is better integration.

It's up to you really, I don't care either way. Still, keeping in line with other OSes seems like a good idea, not least because you can copypaste any fixes they make later on.

Ok, that sounds like a reasonable approach, as the patch would besome a simple one-liner. thanks for your help

Closing. Seems everything worked out great!
p.s.: https://github.com/andsens/homeshick/wiki/Installation#homebrew ;-)

:+1:


Update Documentation

The current Readme is aligned with the previous version of the code. We need to update Readme and message fabricators' names. The following change must happen:

[ ] Change Readme
[ ] Publish the new version
[ ] Update anchor documentation

Ok, where do I find the changes for the readme?

please have a look at the code snippets, if there is something that is not currently supported in anchor.js, change them to the new version. For example, fabricateDepositStableCoin is not supported anymore, it is fabricateMarketDepositStableCoin now. We need to make them correct. Thanks

It looks like the following have changed. Does this look correct so far?
fabricateRedeemStable changed to fabricateMarketRedeemStable
fabricateDepositStableCoin changed to fabricateMarketDepositStableCoin
The following don't seem to exist outside the readme and docs files. However, if they still exist, I cannot find their new names. Is there a way to search for their new names?
MnemonicKey
txResult
depositMsg


[RESTX] Verify Swagger docs

As a developer
I need API documentation
So that I can learn how to use the API
Details & Assumptions:

After all issues under #45 have been completed, please verify that all routes are reflected in the Swagger documentation with appropriate URL, parameters, and response.

Acceptance Criteria:
Given our current repo
When I go to `/apidocs` url
Then the Swagger docs should include all routes of our API and their input/output

Hey team! Please add your planning poker estimate with ZenHub @Fivetoes @jiuliwei @XinyuC97 @yx2512 @ZX-WANG

@jiuliwei I think the checklist should be List, Create, Read, Update, Delete both on products and wishlists, and then Action and Query. List for products equals to read a wishlist, so 11 routes in total, I believe. Feel free to modify Swagger model names to be more informative as part of this issue.


CodeNarc rule - detect when steps or other CPS-requiring code is used in a @NonCPS block

Closing as won't do


Expose Video attributes

The Video Function should expose the following attributes:

[x] Intensity (exported but not handled by QML UI yet)
[x] x rotation
[x] y rotation
[x] z rotation
[ ] (maybe) x position in percentage
[ ] (maybe) y position in percentage
[ ] (maybe) width in percentage
[ ] (maybe) height in percentage

Mostly addressed with 0d4cccf74acdbc204f296332184d93ba2b48a263

Closing for now. Will pick this up again if needed


[GEP-26] Configure gardener discovery server to serve the workload identity documents

How to categorize this PR?
/area security ipcei
/kind enhancement
/label ipcei/workload-identity
What this PR does / why we need it:
Gardener Operator configures the discovery server to serve the workload identity discovery documents.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/9586
Special notes for your reviewer:
Do not merge before the discovery server is updated to v0.2.0 with #10546
cc @dimityrmirchev
Release note:

/test all

/hold

Thank you for addressing the feedback!
/lgtm

/hold cancel

Nice catch Do not duplicate algorithms in openid configuration
/lgtm


Can't get vscode://open links to work

VSCode Version: 1.44.2
OS Version: macOS

Steps to Reproduce:

Run open 'vscode://open?url=file:///Users/felix/git/sourcegraph/README.md' (pointing to a file that exists on disk, while having VS Code open with the folder opened)
Observe how VS Code opens, but the file doesn't get opened

Does this issue occur when all extensions are disabled?: Yes

Where you get that URL format?
It has different format in docs Opening VS Code with URLs
See discussion https://github.com/microsoft/vscode/issues/4883#issuecomment-270073371

@bpasero vscode://open Are these the new URLs you introduced recently, for remote?

@felixfbecker Does Developer: Open URL do anything when you give it that URL?

Sorry, I googled around and didn't find the official documentation, but picked up that this should work somewhere. vscode://file/ works as expected.

@joaomoreno In my case it does nothing.
Tried to paste https://github.com/microsoft/vscode/issues/95850 and file:///C:/web/projects/vscode/README.md and not sure if I'm doing this correctly.
Pasting second into Windows Explorer address bar - opens MD file in VS Code 😄
@felixfbecker glad that this one works for you.

@joaomoreno remote URIs are: vscode://vscode-remote/<authority>/<path>


chore: include release-it config in tsconfig

to reduce IDE errors

#892  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Jest tests: Cannot find module '@blackbox-vision/ra-language-spanish'

It works perfect from the App build (create react app), but it cannot find the module when running jest tests.
I think it has something to do with
Jest looking for a file called index.js in the module root folder.
If i create and empty index.js file in the root folder Jest pass sucessfully.
This is the node_modules subfolder for the installed module:
└── ra-language-spanish
├── dist-src
│   └── index.js
├── dist-types
│   └── index.d.ts
├── dist-web
│   ├── index.js
│   └── index.js.map
├── package.json
└── README.md
This is the Jest run failing ouput:
FAIL  src/App.test.js
● Test suite failed to run
Cannot find module '@blackbox-vision/ra-language-spanish' from 'src/providers/i18nProvider.js'

Require stack:
  src/providers/i18nProvider.js
  src/App.js
  src/App.test.js

  2 | import polyglotI18nProvider from 'ra-i18n-polyglot'
  3 | import englishMessages from 'ra-language-english'
> 4 | import spanishMessages from '@blackbox-vision/ra-language-spanish'
    | ^
  5 | import frenchMessages from 'ra-language-french'
  6 | import italianMessages from 'ra-language-italian'
  7 | import merge from 'lodash/merge'

  at Resolver.resolveModule (node_modules/jest-runtime/node_modules/jest-resolve/build/index.js:306:11)
  at Object.<anonymous> (src/providers/i18nProvider.js:4:1)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        7.515 s, estimated 10 s
Ran all test suites.

I think there's an issue with your Jest configuration, as you've seen by the folder structure we distribute to NPM, the package is exported as an ESM module with it's typings.

Closing the issue because no comments left from the latest one!

Same issue here. I couldn't find any solution for this.

Maybe including node_modules in moduleDirectories config for jest?

Even without Create React App and using only jest (instead of react-scripts test)... moduleDirectories doesn't work. I'm so lost on this one.


Why does the use of AutoAugment lead to the failure of mixed accuracy training acceleration

Checklist
I have searched related issues but cannot get the expected help.
I have read related documents and don't know what to do.
Describe the question you meet
Hi mmcls team,
I did a series of experiments to improve the accuracy of the model.Under the existing datasets and training mode, fp16 can shorten the training time and improve the accuracy. However, when comparing the training results, it is found that the AutoAugment of data will invalidate fp16. Why does this happen?
The result of this experiment is pasted below.I would appreciate it if someone could provide any suggestions or solutions for implementation.
Thank you,

Thanks for your report, and I will check it later.

This issue will be closed as it is inactive, feel free to re-open it if necessary.


[TBD RSC] Dockerize the RH Stack

What?

Running our development environment is not a trivial task atm - we have reports of it taking an entire day. This is a big barrier of entry to the OS community and for future RH devs.
Important
Please keep in close loop with the RH team as you develop this feature. We strive for all assigned bounties to be merged successfully and want to avoid a scenario in which we do not do so due to poor quality or unacceptable implementation choices.
Acceptance Criteria

Docker compose code/docs should be added to newly created researchhub-dev repo
Use yarn to run docker commands.
yarn clone to clone researchhub-web and researchhub-backend repos which are necessary for local dev
Implement docker compose orchestration that spins up both FE/BE repost with a single yarn dev command
Preserve stdout output for both backend and frontend repos for the purpose of efficient development
Update our documentation to include updated instructions of running the dev env

Bounty Completion Requirements

Explicit approval by a member of the RH team is required before starting work
Verified and merged code is required in order to earn the assigned bounty

Assigned to @connerlambden


BUG - default dilution factor not working correctly

Describe the bug
On the plate/new page, if a plate creator does not have a valid_dilution_factors entry in the plate_creators table, the JS on app/views/plates/new.html.erb does not work as expected as (plate_creator_parameters[name] || defaultOption).valid_dilution_factors  returns undefined.
RT Ticket Number
689589
To Reproduce
Steps to reproduce the behaviour:

Go to page /plates/new
Select a new plate and ensure that the valid_options field in the plate_creators table for that plate is empty
See no options for dilutions factor

Additional context
@emrojo resolved this by creating the missing valid_options by running something like this:
Plate::Creator.all.each do |c|
    if c.valid_options.nil?
      # Any other valid option will be set to 1
      c.update!(valid_options: {
                  valid_dilution_factors: [1.0]
                })
    end
  end

Whoops, that'll be my fault. I was fixing an issue with older versions of chrome (The previous code was using some ES6 features)

From Slack

James(opens in new tab)  08:20
Hmm, just trying to work out why the code doesn’t work as intended
08:20
Especially as it did work in CI
Philip(opens in new tab):house_with_garden:  08:24
My understanding: plate_creator_parameters[name] returns {} which is true in JS world then {}.valid_dilution_factors is undefined.
James(opens in new tab)  08:25
Ahhh!
Philip(opens in new tab):house_with_garden:  08:25
We could check if is plate_creator_parameters[name] is empty.
James(opens in new tab)  08:25
Damnit, I was thinking it returned nil
08:25
That’s what the previous code did, but it used ?. which is ES6 stuff not supported in older browsers
08:26
And by nil I mean null of course
Philip(opens in new tab):house_with_garden:  08:26
Were we having trouble with older browsers?
James(opens in new tab)  08:27
On CI, but given the labs have XP machines I thought it worth fixing
08:28
It wasn’t even massively old, Chrome 70
James(opens in new tab)  08:34
Actually, thinking about it, we can probably just roll back to the old code, minus the safe navigation operator. I guess that’s what made me assume we were getting a null for plate creators without a specified dilution factor. As it is though, we’re only ever going to see a java-script object returned at that point.
08:35
Long term we should consider yanking out all our inline js to be in files, that way we can run it all past babel and not have to worry about what might be supported or not


Create separate command to generate arclix.config.json file to existing React project.

Description
If developer needs arclix config support  to the existing react project.
Suggested solution
Create a separate command like the following:
npx arclix init

Which should ideally generate arclix.config.json file to the existing project.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[ Triaged ] : Good to start the development 👍🏻


Migrate error handling to 'snafu'

It could have a better integration but we will see later.

This is an auto-generated message summarizing this pull request.
:pencil: — Rules

:speech_balloon: Title validation: valid! :heavy_check_mark:

Rule: ^[A-Z]

:twisted_rightwards_arrows: Merge strategy: squash

:speech_balloon: — Status comment

:construction: WIP? No :heavy_check_mark:
:checkered_flag: Checks: passed! :heavy_check_mark:
:mag: Code reviews: passed! (0 given / 0 required) :heavy_check_mark:
:test_tube: QA: waiting... :clock2:
:lock: Locked?: No :heavy_check_mark:
:twisted_rightwards_arrows: Mergeable?: Yes :heavy_check_mark:

:gear: — Configuration

:twisted_rightwards_arrows: Automerge: :x:

:scroll: — Current status

Pending: Waiting for QA

See checks output by clicking this link :triangular_flag_on_post:
Beep boop, i'm a bot! :robot: (github-scbot 0.21.1)

bot noqa+
bot automerge+

Pull request successfully auto-merged! (strategy: 'squash')
Beep boop, i'm a bot! :robot: (github-scbot 0.21.1)

bot noqa+

QA is marked as skipped by Srynetix.

bot automerge+

Automerge enabled by Srynetix
Beep boop, i'm a bot! :robot: (github-scbot 0.21.1)


Add "use" to lua language server globals if packer is found

sumneko_lua causes some unwanted noises when editing packer startup function, complaining that the identifier use is undefined

you may want to check out https://github.com/folke/lua-dev.nvim on how to setup lua env.
-- plugins = { "nvim-treesitter", "plenary.nvim", "telescope.nvim" },

As mentioned, you can use lua-dev to extend your sumneko setup. Close it for now. Feel free to comment if it still not working.


Add support for Processing

From @GoogleCodeExporter on May 31, 2015 11:25
See http://processing.org/

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Mar 2010 at 3:38
Copied from original issue: damonkohler/android-scripting#209

From @GoogleCodeExporter on May 31, 2015 11:25
Oh, how nice :)

Original comment by MeanEYE.rcf on 3 Mar 2010 at 3:46

From @GoogleCodeExporter on May 31, 2015 11:25
Processing is doing some work on this: http://android.processing.org/
It's just a way to compile processing sketches down to android apks for now -
it would definitely be nice to be able to actually write a sketch on the phone
while in the subway or whatnot.

Original comment by<EMAIL_ADDRESS>on 9 Jun 2010 at 12:40


standardize package repo information

Standardize how we reference our repo and package location in package.json files. A couple packages had incorrect urls. Now following npm monorepo guidance - https://docs.npmjs.com/cli/v9/configuring-npm/package-json#repository
Add repositoryDirectory field when extracting metadata for docs.

force merging since itll take weeks to get this reviewed by every codeowner

I feel like having the directory would have been a good idea, but I'm not sure how this translate to clicking on "repository" stuff...

@raplemie what do you mean? Like clicking on the repo link in npmjs?

@raplemie what do you mean? Like clicking on the repo link in npmjs?

Yes, but apparently even having that directory does not help someone figure where to look for the specific package code (core-react package is in /ui/core-react, which for a newcomers requires finding this information)
So, let's drop this comment, as what I was imagining is not helping anyway, and apparently these links are not for humans anyway.

Sounds liek the root reamde which they get linked to should probably list where the pkgs are, ie vcr repo readme


Persistence/acks question

I am trying to figure out how to implement following:

infinite persistable retransmission buffer

multicast publisher without any limitation by receivers
receivers "late join" handled  somehow (with unicast retransmits like on naks or smthing custom)
persistent means that i can stop/start publisher application and continue publish where I was finished. I agree to pay some price for that, in general I see custom buffer/term management where they not rotated but asynchronously written to disk.
Are there some extension points I can play with?

handle/manage receiver cumulative acks after message processing by app on subscriber side in consistent but more or less cheap way on publisher

use receiver status message?
separate channel for acks?

Could you please advice if it is achievable/reasonable/applicable to Aeron at all.
Or just point me direction/extension points where to dig.
Thanks in advance.

All of these points are being considered. We plan to add the necessary APIs to Aeron so that services such as replication, persistence, and historical query/replay can built on top without impacting the performance of the core.
Because of the core design decisions to have all the log buffer data structure as effectively immutable within a constrained range, plus the ability to uniquely identify an exact position in a stream across time these things can fall out relatively easily. @tmontgomery and I had this direction in mind right form the outset.
Watch this space as more will come in the not too distant future.


Enhance UCD packaging script to establish links to git commit url and ci pipeline url

Extend the CreateUCDComponentVersion sample script to

allow to establish a link to the ci pipeline build result
include the git commit information and establish links back to the git provider

Delivered via #79 . Please see PR for a sample.


mibase: Use 16 bits for thread id instead of 8

Unfortunately the application I'm currently working with spawns and closes large numbers of threads, so while only ~200 or so are running at once, it's not unreasonable for thread ids to get up into the 10,000's.
This should still support 15 bits of levels before signed-ness becomes an issue, but I can't foresee large frame numbers being as common as large numbers of threads.

Thank you!


Remove Config type.

Summary
Next diff in the sea of diffs to split up configs. This removes the Config type completely. I have follow-ups where I start to pull things apart properly and remove fields from either ProjectConfig or GlobalConfig.
Test plan
jest

Right now, the return value of normalize returns an "options" object which is GlobalConfig & ProjectConfig (basically what Config was). We should change this over time and we'll have to fix up many tests that rely on this (see the rename of .config to options). I made the minimal changes to make the tests work and it seems to be good enough for now.

Codecov Report

Merging #3366 into master will decrease coverage by 0.8%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   64.89%   64.09%   -0.81%
==========================================
  Files         176      176
  Lines        6521     6526       +5
  Branches        4        4
==========================================
- Hits         4232     4183      -49
- Misses       2288     2342      +54
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/constants.js
100% <ø> (ø)
:arrow_up:

packages/jest-environment-node/src/index.js
69.56% <ø> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
89.54% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/setup-jest-globals.js
0% <ø> (ø)
:arrow_up:

packages/jest-environment-jsdom/src/index.js
0% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/index.js
0% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/jest-expect.js
0% <0%> (ø)
:arrow_up:

packages/jest-config/src/index.js
26.08% <33.33%> (ø)
:arrow_up:

packages/jest-cli/src/runJest.js
0% <0%> (-59.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2a651...73bad6a. Read the comment docs.

In the interest of time, I'm gonna go forward with this. If there are any concerns with this direction, please let me know and I'll revert or fix.


Update deps for May 16, 2024

Updating most of our deps.  I'm not touching eslint, which just had a major breaking change I don't feel like fighting with atm.

This is great @rjwignar, really appreciate the review.  When you can test the other stuff you want, and are happy, I'll land.

This is great @rjwignar, really appreciate the review. When you can test the other stuff you want, and are happy, I'll land.

I just tested the iframes and they're not broken.
I'm not sure if there's anything else I should test, but everything I've tested still works.

OK, let's go with it and file follow ups if things break.


Comma Chameleon - Offline Validation Hyperlink Awry?

Currently the landing page for Comma Chameleon asserts
Not sure your data is ready for prime time? You can validate your CSV on the fly using [CSVlint](, so you can be sure your data is reuse ready before you publish it!
The link it to csvlint.io rather than csvlint.rb. This could give the false impression that

the validation requires an internet connection
that the validation will be publicly listed on CSVlint.io

This should be amended

My understanding of Comma Chameleon being offline first is correct, right @pezholio ?


Add option to toggle comm thread tracing

Original issue: https://charm.cs.illinois.edu/redmine/issues/886

Currently, users can enable and disable Projections tracing using traceBegin() and traceEnd().  However, these calls don't disable comm thread tracing.  Allowing them to do so will require some restructuring, since, as the name indicates, the comm thread is a different thread.
This should likely be a new call, something like traceCommBegin() and traceCommEnd().

Original date: 2016-02-15 18:37:37

For the sake of clarity, I'd like to note here that traceBegin and traceEnd do indeed enable and disable comm thread tracing.  This bug is meant to allow users to toggle comm thread tracing without modifying the trace status of the rest of the program.

Original date: 2016-02-17 01:44:59

~~https://charm.cs.illinois.edu/gerrit/#/c/1069/~~ https://github.com/UIUC-PPL/charm/commit/905f61a5bfa9a9ce48cd02bd312408e854db1f941


Is this a dead project?

Not seeing much activity since January, and issues raised about connecting to local nuget servers have gone unanswered.  Should I be looking elsewhere instead of trying to use this extension?

@jeremy-allocate
I was busy :D
I am now available to address any concerns or assist with troubleshooting.


Add eu/us endpoint alias & bump versions

Summary

Add eu/us endpoint alias & bump versions
Description

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Theses changes have been tested in:

[x] Local environment

Checklist

[x] Fill the description
[x] Declare the type of changes included in the pull request
[x] Describe how has this been tested
[x] Add categorical labels (feature/fix/chore/docs/skip-changelog)
[x] Add semver labels (patch/minor/major/skip-semver)

Closed in favor of: https://github.com/barracuda-cloudgen-access/access-cli/pull/69


Add CONTRIBUTING.md file

Motivation

Let people know how to contribute.
Description of the changes

Add CONTRIBUTING.md file.

Address #7

@hvy Can you take a look at this?


No hints on "show answer" questions

Hints are written on editor but do not seem to appear for "Show Answer" type questions
https://staging.isaacphysics.org/questions/Balancing_Forces_on_an_Electron

https://staging.isaacphysics.org/questions/oil_drop_multiple_fields_num

QuickQuestions were never supposed to have hints. This would be a new question type, which can go on the backlog if required.


Unicode 12.0 (61 new emojis!)

The Unicode standard version 12.0 has been around for about a month (official summary, emojipedia) and it introduced 61 new emojis.
Any release schedule/eta/info on supporting it? (I'd even help design them, but sadly I have no designing skills 😔)

Also looking forward to this update :)

Added in ac1703e9d7feebbf5443a986e08332b1e1c5afcf


Invalid nexthop for GRE interfaces

I have OpenBGPD 7.6 ported in FreeBSD 13.1. It seems be stable and working fine, however I noticed OpenBGPD does not redistributes GRE interfaces by default until OpenBGPD service is restart. It marks the nexthop as "invalid" for all routes learn via GRE interface.
Here is some of the logs captured:
Mar 17 09:38:33 R0 bgpd[69221]: if_change: gre45: rdomain 0 DOWN, unknown media, active, 0 bps
Mar 17 09:38:57 R0 bgpd[69221]: if_change: gre46: rdomain 0 DOWN, unknown media, active, 0 bps

Interface      rdomain  Nexthop  Flags  Link state
gre46          0        invalid         active
gre45          0        invalid         active
gre44          0        invalid         active
gre43          0        invalid         active
gre42          0        ok       UP     active
gre41          0        ok       UP     active
Here GRE43 to GRE46 are UP and running and able to reach other endpoint of GRE, but BGPD can't see it. All the Physical and vlan interfaces had no issues observed with bgp. It is only GRE is impacted.
It seems like interfaces does not give proper media type and due to that BGPD marked it down.
https://github.com/openbgpd-portable/openbgpd-portable/blob/175c93b6e833fa1a23fbe15ee15a64927bcf2053/src/bgpd/kroute-freebsd.c
Anybody observed such behavior or could be bug.
Any help would be much appreciated.

On my FreeBSD testbox running 14.0-current it seems to work fine.
Here some commands from my system when I tested this:
# bgpctl show int
Interface      rdomain  Nexthop  Flags  Link state
lo0            0        ok       UP     active
re1            0        ok       UP     Ethernet, active, 1000 MBit/s
re0            0        invalid         Ethernet, no network
# ifconfig gre0 create
# bgpctl show int
Interface      rdomain  Nexthop  Flags  Link state
gre0           0        invalid         unknown
lo0            0        ok       UP     active
re1            0        ok       UP     Ethernet, active, 1000 MBit/s
re0            0        invalid         Ethernet, no network
# ifconfig gre0 inet <IP_ADDRESS> <IP_ADDRESS>
# bgpctl show int
Interface      rdomain  Nexthop  Flags  Link state
gre0           0        invalid         unknown
lo0            0        ok       UP     active
re1            0        ok       UP     Ethernet, active, 1000 MBit/s
re0            0        invalid         Ethernet, no network
# ifconfig gre0 tunnel <IP_ADDRESS> <IP_ADDRESS>
>> bgpd log: if_change: gre0: rdomain 0 UP, unknown media, active, 0 bps
# bgpctl show int
Interface      rdomain  Nexthop  Flags  Link state
gre0           0        ok       UP     active
lo0            0        ok       UP     active
re1            0        ok       UP     Ethernet, active, 1000 MBit/s
re0            0        invalid         Ethernet, no network

So it seems to work. The moment the interface has its tunnel endpoints set the FreeBSD kernel sends a RTF_IFINFO message which alters the state to UP.
Please provide exact commands on how to get into that state.
Either this was fixed in14.0-current but not backported or my way to configure the interface is missing the crucial step.


add documentation on using aws sam

Issue #, if available:
#149
Description of changes:
Simple documentation outlining how AWS SAM can be used. I also made a repository with a small POC example HERE
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the PR. Can you make a SAM sample in /examples folder and reference that in the readme?
Something like this should get you started:
MyFunction:
    Type: AWS::Serverless::Function
    Properties:
      MemorySize: 128
      Runtime: provided.al2023
      Handler: index.handler
      CodeUri: ...
      #todo add reference to layer
      Layers: ...
    Metadata:
      BuildMethod: esbuild
      BuildProperties:
        External:
          - '@aws-sdk'
          - '@smithy'
          - uuid
        Minify: false
        Target: "es2020"
        Sourcemap: false
        Format: esm
        OutExtension:
          - .js=.mjs
        EntryPoints:
        - entrypoint.ts


feat: update service user bo function

Describe your changes
Ticket: https://pins-ds.atlassian.net/browse/ASB-2011
Update to https://github.com/Planning-Inspectorate/applications-service/pull/938 - updates the function to work correctly with new valid serviceTypeUser values.
Useful information to review or test

Follow the readme on the back-office subscribers function to set it up
Run azurite npx azurite and this function npm run start:dev nsip-service-user
Make a POST request to http://localhost:7071/admin/functions/nsip-service-user with this body:

{
    "input": "{\"serviceUserType\":\"Applicant\",\"id\":\"1234\",\"firstName\":\"John\",\"lastName\":\"Smith\",\"organisation\":\"ACME\",\"organisationType\":\"Sole Trader\",\"caseReference\":\"B123456\",\"emailAddress\":\"test@test.com\",\"webAddress\":\"www.test.com\",\"telephoneNumber\":\"0123456789\"}"
}

Note, the serviceUserType above can be changed to Applicant, RepresentationContact  which save different fields into the database.
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[x] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[x] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


http4s - support proxy handler from HttpApp

I think it's an AWS thing rather than an http4s thing? But I don't know, ApiGateWayProxyHandler was already there and it looks like you wrote it? 🤷

Ah 😂 I misunderstood your PR title there. I thought maybe there was an http4s "proxy" middleware that worked on HttpApp instead of HttpRouteslol. Ok thanks!


IOS Cancel connectio does not working

Prerequisites

[X] I checked the documentation and FAQ without finding a solution
[X] I checked to make sure that this issue has not already been filed
[X] I'm sure that question is related to the library itself and not Bluetooth Low Energy or Classic in general. If that so, please post your question on StackOverflow.
[X] I'm running the latest version

Question
In IoS i have toggle if i disable unpair the devices connection but cancelconnection does not working
so how to do unpair the device connection
Question related code
No response

Question
I too facing same issue on iOS, device disconnection was not successful.
Steps followed:

Connected with a BLE device.
Written some data to the device.
Disconnect from the BLE device.

Issue:
After disconnect method performed, I have checked the iOS app Bluetooth connection, it still connected with the same BLE device.

@AkashOptisol
But Cancelconnection does not working iam connected and react the value from device but how to disconnect
cancelconnection does not working


Add a refresh button to Resident List

Resident List could use a refresh button

This was added as an experiment but was not really useful so it was removed :toilet:


Add openssl/fuzz-corpora as submodule

Instead of carrying the fuzz corpora data in the source code repository we move it into a submodule pulled from  https://github.com/openssl/fuzz-corpora

Fixup was needed - we do not want submodules for check update and check docs CI runs.

@levitte @t-j-h please reconfirm

Reconfirmed.

Additional question - do we want to move the fuzz/corpora data to submodule also in 3.1 and 3.0 branches?

I would leave stable branches alone for this sort of stuff - but I won't put a hold if others think differently.

I would leave stable branches alone for this sort of stuff - but I won't put a hold if others think differently.

Yeah, unless we would like to add more testing data to older branches we can keep them as is.

I would actually do this same thing on the release branches too, simply to avoid all the duplication.  Stuff in new subdirectories will be ignored by them, as they won't have the corresponding fuzz testing driver.
But, I don't see a need to do this nownownow.

Just an observation, looking at some other builds this seems to add a few minutes of build time  to some of the builds (i.e. we are now always retrieving 10 submodules)

Any chance of limiting the submodules to just the fuzzer?
I don't see an option to do this in the checkout action :disappointed:

Any chance of limiting the submodules to just the fuzzer? I don't see an option to do this in the checkout action disappointed

Yeah, there is no such option. I assume we would have to call git explicitly.

Assuming the last change works grin

Yeah, it seems to.
@levitte, @t-j-h please reconfirm

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

This pull request is ready to merge


copy xformers attn from ooba since we removed dep on alpaca_lora_4bit

resolves #124

For duplicate code, it's preferable to just add
# pylint: disable=duplicate-code


Maven plugin returns 404 regardless of the nvdApiDelay value while the same request works in Postman, curl etc.

Describe the bug
Maven plugin can't retrieve results from NVD database, while the same HTTP request works in the HTTP clients.
Version of dependency-check used
The problem occurs using version 9.0.9 of the maven plugin
Log file
Here is the Maven output excerpt:
[INFO] Checking for updates [DEBUG] rate limited call delay: 60000 [DEBUG] rate limited call delay: 60000 [DEBUG] rate limited call delay: 60000 [DEBUG] rate limited call delay: 60000 [DEBUG] requesting URI: https://services.nvd.nist.gov/rest/json/cves/2.0?lastModStartDate=2024-02-01T14%3A55%3A46Z&lastModEndDate=2024-05-31T14%3A55 %3A46Z&resultsPerPage=2000&startIndex=0 [DEBUG] Ticket taken At: 14:40:25; count: 1; by 123 [DEBUG] Requested At: 14:40:25; URI: /rest/json/cves/2.0?lastModStartDate=2024-02-01T14%3A55%3A46Z&lastModEndDate=2024-05-31T14%3A55%3A46Z&resultsPe rPage=2000&startIndex=0 [DEBUG] Ticket returned At: 14:40:26; count: 2; by 123 [DEBUG] Status Code: 404 [DEBUG] Response:  [ERROR] Error updating the NVD Data; the NVD returned a 403 or 404 error
To Reproduce
Steps to reproduce the behavior:

Execute mvn clean verify in the root of the project
See error log above

Expected behavior
The plugin will do a scan and report discovered vulnerabilities.
Additional context
Here is my maven plugin configuration
<plugin>             <groupId>org.owasp</groupId>             <artifactId>dependency-check-maven</artifactId>             <inherited>false</inherited>             <executions>               <execution>                 <id>dependency-check-aggregate</id>                 <goals>                   <goal>aggregate</goal>                 </goals>                 <configuration>                   <nvdApiKey>64184416-250d-482e-b835-c9e56cd0d201</nvdApiKey>                   <nvdApiDelay>60000</nvdApiDelay>                   <nodeAnalyzerEnabled>false</nodeAnalyzerEnabled>                   <nodeAuditAnalyzerEnabled>false</nodeAuditAnalyzerEnabled>                   <!-- deactived due to https://github.com/jeremylong/DependencyCheck/issues/4527 -->                   <ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled>                   <retireJsAnalyzerEnabled>true</retireJsAnalyzerEnabled>                   <yarnAuditAnalyzerEnabled>false</yarnAuditAnalyzerEnabled>                 </configuration>               </execution>             </executions>           </plugin>

The issue was resolved by increasing the delay along with using newly generated API key.


fix(docs-dark-mode): workaround applied to reduce the switching themes delay

[docs]/[dark-mode-player-component]
TASK:  #177
Closes #177
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Only
[x] Refactor

Description, Motivation and Context
The scope of `Dark mode is effortless Switch was reduced in order to get a faster switching themes

Screenshots - Animations
https://user-images.githubusercontent.com/30373425/151646266-24120072-1e4b-46b4-aa81-23fa7b41a1d8.mov

Codecov Report

Merging #182 (6575f43) into main (7c9982c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   76.13%   76.13%
=======================================
  Files         140      140
  Lines        2275     2275
  Branches      681      681
=======================================
  Hits         1732     1732
  Misses        538      538
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9982c...6575f43. Read the comment docs.


Astro support

Clear and concise description of the problem
Would like to see Astro support.
Suggested solution
Create astro.ts file in the folder ./src
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Why this ehancement does not have an PR yet?

Astro has been getting quite a bit of traction so it might be worth it by now

any progress :)

:pleading_face:


Speed up template rendering by not using marshal load/dump

Speed up template rendering by using clone and not marshal load/dump.
In big environments with large numbers of vms with links. Marshal load/dump is quite slow.
In testing this is result with cf-deployment  with number of vms being diego vms on BOSH-lite
| VMS     | Baseline | Updated |
|---------|----------|---------|
| 250 vms | 5 mins   | 3 mins  |
| 500 vms | 14 mins  | 8 mins  |
| 750 vms | 30 mins  | 16 mins |
| 1000 vms | 52 mins | 27 mins |

Thanks @lnguyen totally missed those (was reviewing from my phone :) )


Use winget-releaser GitHub Action to automate new versions publishing to the Windows Package Manager

It seems that every Typst related PR in winget-pkgs was made manually.
Would it make sense to automate this process? I think it would be possible to create or use a GitHub Action like winget-releaser that would automatically create a PR in winget-pkgs repo for every new Typst release. This would make it easier to keep the Typst package up to date in winget.

Perhaps such an automation could live in a separate repository? Generally, we don't manage packages in package managers ourselves (and that's a good thing because I wouldn't know how to maintain such an action, etc.)

This is out of scope for the Typst project itself.


fix: fixing of typo

[ ] Are the audience and objective of the document clear? E.g. a document for developers that should teach them about transaction fees.
[ ] Is the writing:

[ ] Clear: No jargon.
[ ] Precise: No ambiguous meanings.
[ ] Concise: Free of superfluous detail.

[ ] Does it follow our style guide?
[ ] If this is a new page, does the PR include the appropriate infrastructure, e.g. adding the page to a sidebar?
[ ] Build the page ($ cd website && yarn start). Does it render properly? E.g. no funny lists or formatting.
[ ] Do links go to rustdocs or devhub articles rather than code?
[ ] If this PR addresses an issue in the queue, have you referenced it in the description?

I have deleted the branch, in Github's settings is an option for a repository to auto-delete branch after merge - it helps to maintain clean repository ;-)

Yup! AFAIK I cannot delete your branches though,only ones this repo hosts natively


Adding Decompounding for German.

See querqy.lucene.contrib.rewrite.wordbreak.SuffixGroup, Collector and GermanDecompoundingMorphologyfor the approach.


Build one library!

This sounds like a great idea @davidbeckingsale!  The builds are currently not passing so I will wait until after they are fixed before reviewing.

@mcfadden8 - builds are passing 😁


Multiple website issues

Where to find the issue
https://www.coronawarn.app/en/
https://www.coronawarn.app/en/blog/
https://www.coronawarn.app/en/analysis/
https://www.coronawarn.app/en/faq/
https://www.coronawarn.app/en/faq/results/
Describe the issue
Multiple issues are currently occurring on the CWA website

https://www.coronawarn.app/en/ menu button does not work in narrow mode,
https://www.coronawarn.app/en/blog/ the new blog search does not work
https://www.coronawarn.app/en/analysis/ no graphs are shown
https://www.coronawarn.app/en/faq/ search does not work
https://www.coronawarn.app/en/faq/ legacy links do not work
https://www.coronawarn.app/en/faq/results/ search does not work
https://www.coronawarn.app/en/faq/results/ duplicate articles are not shown

Sorry for "pre-release" of this issue! I accidently hit the Return button whilst I was still composing the issue.

@MikeMcC399 Thanks for reporting, we are having a look at the issues. See https://github.com/corona-warn-app/cwa-website/pull/2871

I just retested and all reported issues still occur. Please reopen the issue.

@MikeMcC399 Fixed.

@dsarkar

Fixed

I checked each item and I agree that the issues are resolved. Thank you!

The problem was related to s3cmd v2.0 which is the latest version available to ubuntu-latest.
There is a bug in guessing mime types and it caused all assets like css/js to be uploaded with content-type text/plain. Due to our content security policy, the script can only be executed with text/javascript.
Related issue:
https://github.com/s3tools/s3cmd/issues/643
The bug is fixed in s3cmd >= 2.2


Add Inhibited indicator to UI

From this comment thread: https://github.com/prometheus/alertmanager/pull/799#discussion_r116765232
Just add a inhibited tag if that's the alert's status.

I would like to extend this issue. In addition we should also tag silenced alerts with a silenced tag.
This was pointed out by Jack here:

There is a checkbox to show silenced alerts, but when they are shown there's no indication which of the shown alerts are silenced.


fix: Fix conform version in root package.json

copilot:all

Current dependencies on/for this PR:

main

PR #4279   👈

This comment was auto-generated by Graphite.


[Feature Request] Upgrade ingress-web to use new api version

Is your feature request related to a problem? Please describe.
According to https://kubernetes.io/blog/2021/07/26/update-with-ingress-nginx/ since kubernetes 1.22 Ingress object won't be accessible from networking.k8s.io/v1beta1  but only through networking.k8s.io/v1.
Running temporal-web with ingress enabled on minikube v1.23.2 (kubernetes v1.22.1) fails for this reason.
Describe the solution you'd like
Check in https://github.com/temporalio/helm-charts/blob/master/templates/web-ingress.yaml if it has api version of networking.k8s.io/v1 and fix yaml accordingly

Fixed by #278


Horizontal scrollbar

Hi, guys!
I have a problem.
Horizontal scrollbar appears on hover the slider.
http://adlinkonfet.ru/about/

I found, that it's "Pinterest" plugin adds it's buttons to all images...


[SPARK-40899] [CONNECT] Make UserContext extensible.

What changes were proposed in this pull request?
Different systems will need different metadata that is passed as the user context during the request. To be able to handle the different systems seamlessly, make the UserContext extensible with google.protobuf.Any.
Why are the changes needed?
Extensibility.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT

R: @cloud-fan @amaliujia @HyukjinKwon

Can one of the admins verify this patch?

thanks, merging to master!


Add a reboot test that works w/o reexecuting tmt

The /tests/execute/reboot/basic test works by re-executing tmt in its beakerlib test script in a subdirectory with specially crafted  TMT/FMF metadata that specify among others that the test is going to be executed in a container, and allow processing the tmt output to check for the actual reboots.
This is not how one usually runs a test in a CI system though: one does not usually recursively re-execute tmt from inside a test script. Therefore, add another reboot test (called simply reboot) which runs directly in the CI environment.
RFC: Maybe the new reboot test should be called basic, the full name name /tests/execute/reboot/reboot is not very good. And the current basic test should be renamed to recursive or container or something, because it is not so basic.
ToDo: This test can have a false negative result. It does not check whether the machine actually got rebooted (so if one replaces all the -reboot commands by /bin/true, the test still succeeds, as can be seen in https://github.com/pcahyna/tmt/pull/3). It can not check whether the machine has actually rebooted, because this assert belongs only to a branch that gets called after a reboot, but without a reboot we will not get there, so the assert can never fail. @psss has suggested to put rlJournalEnd into the "after reboot" branch, so that without a reboot the test would fail because the journal would not be terminated. I tried that in https://github.com/pcahyna/tmt/pull/4, let's see how it works.

@psss has suggested to put rlJournalEnd into the "after reboot" branch, so that without a reboot the test would fail because the journal would not be terminated. I tried that in pcahyna#4, let's see how it works.

Here's the result: http://artifacts.dev.testing-farm.io/d799fe9a-7a6f-4cf4-b7d1-e49e990278b9/ . It is not user friendly at all, because it says just
Test "/tests/execute/reboot/reboot" failed.

Found a bug? Please open an issue in the issue tracker: https://gitlab.com/testing-farm/general/-/issues

FAIL

and the reason why it failed is not given - but at least it fails as it should.

Too bad it fails also when the test is correct: https://github.com/pcahyna/tmt/pull/5

Good point to simplify test execution, could be inspiration for #1171
Just for future reference: This test can run on any provision except local.


[BugFix] fix refresh external table partition

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 0 / 2 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/hudi/HudiMetadata.java
0
1
00.00%
[156]

:large_blue_circle:
com/starrocks/connector/hive/HiveMetadata.java
0
1
00.00%
[156]

@Mergifyio backport branch-2.5


bug: training - can't set num_class_images=0

Describe the bug
training:
If you set num_class_images=0 it will throw a division by zero error
if you remove the attribute, it will generates new images
would be useful to have option to skip regularization images entirely (just putting 0 would be preferable)
thanks
Reproduction
--num_class_images=0
Logs
No response
System Info
latest colab

i realized you could remove --with_prior_preservation --prior_loss_weight=1.0
i'll close this


Run multiple MCMC chains with NumPyro without flags

See pyro-ppl/numpyro#364.

@fehiepsi - Do you mean setting it to 4 in brmp or in NumPyro? I think setting it to 4 for brmp makes sense (for CPU). In any case, I think we should also try to develop a better understanding of XLA's behavior when we change this environment flag. Even if it seems safe now, it is possible that XLA starts using this flag for some optimization in the future and users will be pushed into a regime of poor performance simply because the default value for the environment flag is different than the actual device count or how XLA expects this flag to be used.

I meant in both libraries. :D

we should also try to develop a better understanding of XLA's behavior when we change this environment flag

Agreed! We should talk about this when we meet its developers. For now, let's keep the default behavior.


EasyEngine V3 breaking when installing nginx package on Debian 8.

I believe nginx got updated on dotdeb and it is breaking the installation on Debian 8
Log:
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
nginx-custom : Depends: nginx-common (= 1.14.0-1ppa~stable) but 1.14.2-1~dotdeb+8.1 is to be installed
nginx-ee : Depends: nginx-common (= 1.14.0-1ppa~stable) but 1.14.2-1~dotdeb+8.1 is to be installed
E: Unable to correct problems, you have held broken packages.
If you could help, that would be very appreciated.

EasyEngine v3 issues are no longer being tracked here. WordOps is a good alternative of EEv3


GraphicalUncertainPairedData still uses independent X value sorting to address monotonicity errors

On line 151 of the GraphicalUncertainPairedData class, the SamplePairedData method will still sort values if monotonicity issues are detected on X values. As stated in a previous comment, i don't think paired data x or y vals should ever be sorted independently, in particular not to resolve monotonicity issues. Here I think it would be fine to probably just throw an error message, as the X values are fixed (not sampled) and should have already been subjected to at least one monotonicity test at this point. If this issue ever came up (which it shouldn't anymore if issue #204 and related are addressed) something pretty bad would have had to have happened, so rather than to attempt an automated fix it would probably be best to just throw an error.

what about changing the forcemonotonic method to handle both x and y, do away with sorting entirely?

you're right, the x values have already been validated for monotonicity.

there is no more sorting anywhere


Regression in DVR and Isosurface on Mac

A regression has been introduced on the Mac (and possibly elsewhere) in the regular grid algorithm for both DVR and Isosurface rendering. See attached image. The curvilinear grid algorithm works just fine.
Helpful additional information
(Please click check boxes AFTER submitting ticket)

[ ] Did VAPOR crash?
[x] Did you get wrong results?

Impact

[x] High - User productivity significantly degraded
[ ] Medium - User productivity partially degraded
[ ] Low - User productivity trivially degraded

To Reproduce

Load Katrina.
Create and enable the DVR or Iso renderer

Additionally, please attach a session file to this ticket to easily reproduce (use File->Save Session).
Desktop
Model Name:	MacBook Pro
Model Identifier:	MacBookPro14,2
Processor Name:	Intel Core i7
Processor Speed:	3.5 GHz
Number of Processors:	1
Total Number of Cores:	2
L2 Cache (per Core):	256 KB
L3 Cache:	4 MB
Hyper-Threading Technology:	Enabled
Memory:	16 GB
Boot ROM Version:	<IP_ADDRESS>.0
SMC Version (system):	2.44f1
Serial Number (system):	C02V8137HV2T
Hardware UUID:	F2EA4D07-2D45-5644-9B4B-3C33D11CF2F5
Mac OSX 10.14.6

@clyne I cannot reproduce this:

@StasJ any thoughts on how we can troubleshoot it? My system is only two years old and a pretty common platform. I don't think we can ignore it.

@clyne I agree. The first step may be to make sure we are using the same version/timestep of Katrina. Below are my md5 checksums.
b8a6c987868de78956493825478c321c  Katrina-3.1.0.nc
f29a42d04f7f1f35663fa69151f0d8c4  Katrina-3.1.0_data

Next maybe you could check to see if the same problem persists in vapor 3.0. The regular grid renderer has not changed much. If that helps we can try to figure out at which commit this was introduced.
From the artifacts and the fact that it is localized to your machine it is possible that this bug is occurring within the driver or hardware on your machine. So if the above does not help, we may need to schedule a screen share and we can look at it together on your machine.

@clyne I agree. The first step may be to make sure we are using the same version/timestep of Katrina. Below are my md5 checksums.
b8a6c987868de78956493825478c321c  Katrina-3.1.0.nc
f29a42d04f7f1f35663fa69151f0d8c4  Katrina-3.1.0_data

I should have been more clear. It happens with any data set.

Next maybe you could check to see if the same problem persists in vapor 3.0. The regular grid renderer has not changed much. If that helps we can try to figure out at which commit this was introduced.

Good idea. I ran the 3.2.0 release and it doesn't exhibit the same behavior, but there are artifacts that have always been present (see attachment). The difference now is that the current build is completely unusable.

From the artifacts and the fact that it is localized to your machine it is possible that this bug is occurring within the driver or hardware on your machine. So if the above does not help, we may need to schedule a screen share and we can look at it together on your machine.

How do we know that it is localized to my machine? We only have two data points as far as I know.

Ah now I remember there was always a problem with your machine. This is definitely a driver/hardware problem then. I am assuming it is localized to your machine since IIRC it has had these problems since 3.0 and we have not yet found any other machine (on any OS) that has such problems as far as I am aware.
I can debug this further but I need access to your machine. It may be practical if you created a new non-privileged user that I can use without having access any of your files. Then we can set up a time when you are not working and I can remote access your machine.
Otherwise you could try figuring out what commit worsened the problem and we can take it from there.

We're going to table this until we're back on the Mesa and no longer under stay at home orders for corona virus.

Re-opening this issue. It is also occurring on my new Mac OSX 11.4 system. The one significant common element between my old and new Mac is that they both have the same graphics adapter: Intel Iris Plus Graphics

Since mac is moving to M1 architecture, intel is being phased out, so our consensus is tot not fix it.


How to interpret model performance?

Is it possible for me to visualize feature importance, SHAP values, optimization history (similar to optuna), etc to explain the model's performance?
If possible, how should I do it?

feature importance and SHAP values: #193
SHAP values are not built-in. But it's frequently asked (also in #220). Suggestions/contributions are welcome.
optimization history. In this example only better configurations are logged. You can use log_type='all' in fit() to log all the trials.


Why do allocation clusters run out of free resources?

Hello, I'm just wondering if you can elaborate further on allocation failures. Why does a cluster run out of free resources? What kind of mitigations does Azure put in place to prevent it from happening? Why do those mitigations sometimes fail? Is there an alert we can configure to notify us when a cloud service allocation fails? Allocation failures are infrequent but they can be serious when they happen for a production cloud service. Thanks for your help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f41ed7c-c92f-68c7-96ef-a14bbd1529b5
Version Independent ID: e9c65d37-69a7-a269-17a4-98249217b4fe
Content: Troubleshooting Cloud Service (classic) allocation failure
Content Source: articles/cloud-services/cloud-services-allocation-failures.md
Service: cloud-services
GitHub Login: @tanmaygore
Microsoft Alias: tagore

@galehouse5 Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@tanmaygore Can you please check and add your comments on this doc update request as applicable

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing. We are closing this issue for now, but feel free to comment here as necessary. #please-close


WIP: STM32 USB Type-C/USB Power Delivery Interface (UCPD)

Draft until my hardware for testing arrives.

hope you don't mind the drive by comments :) had a go at implementing this in the past but got distracted and demotivated by the general cursedness of USB PD and UCPD, so good luck. feel free to pick my brain on this because i've thought a lot about it (some might say too much thinking and not enough coding :D)

Every comment is welcome! You have implemented a lot already, gonna take you code as reference going forward.

some thoughts (some might say overthinking :)) mostly about how dead battery could be handled in the driver I had while writing #2683:
g0 is weird: you need to write a strobe bit in SYSCFG every time you want the CC pin configuation to be applied. don't think this is a big issue but worth keeping in mind.
according to the non-g0 RM:

you should initialise UCPD before disabling DB. makes sense. (wonder if this means DB takes precedence over any other config?)
g0 only (reserved on others) has DBATTEN bit in UCPD CR:

worth noting that since it is in CR that means it can only be changed while UCPD is enabled, unlike the DBDIS bit hanging out in PWR on the other chips. that said, I this isn't much of a problem, since the strobe bit works while UCPD is disabled:

and if you need to re-enable DB, you can but you need to be careful to do it while UCPD is enabled. this is why I made ucpd_init it's own thing in my PR.
I can't think of many scenarios where you would want to re-enable DB: it isn't needed once UCPD is enabled (since you can set the sink pulldowns just fine with ANAMODE=1 and CCENABLE != 0, which is also required when the DBCC pins aren't wired up). maybe re-enabling DB if you disable UCPD (i.e drop the driver)?? probably keep a flag in the driver struct if DBCC pins are passed in. if they aren't, the user could be using them for something else (this is possible with some care: mentioned in this forum post and the linked AN5225, which I had forgotten about) which we should respect by not enabling them on drop.


Should use a recent version of setup-envtest

CAAPH should update setup-envtest to a commit on main that fetches envtest binaries from the GitHub release on the controller-tools repo. This is to move away from using GCP resource buckets.
See kubernetes-sigs/cluster-api-provider-azure#4888 for an example.
For context, see

kubernetes-sigs/cluster-api#10569
kubernetes-sigs/controller-runtime#2811

Oops wrong repo.


Re: 'Environments (AWS accounts) architecture'

Is this supposed to be public??
Problem with 'Environments (AWS accounts) architecture' (https://user-guide.modernisation-platform.service.justice.gov.uk/concepts/environments/architecture.html)

Hi @mikejwhat - yes it is! It follows our existing guidance on working in the open, and is further described in code in a separate public repository.

https://technical-guidance.service.justice.gov.uk/documentation/standards/storing-source-code.html
https://github.com/ministryofjustice/aws-root-account

Another good reference on why this repo (and lots of our others) are in the open is my blog post from 2017: Why we code in the open. Thanks for your question, @mikejwhat!


Adding transition guards?

Hello hello, thanks again for all your great work!
I've had one feature on my mind and I'm very keen to hear your thoughts. That is transition guards. This can partially be achieved with a SrConditional state reactor but I think adding guards to the transition table would be a much tidier, more efficient and more flexible solution...
Example syntax
  // TRANSITION TABLE
  typedef boost::mpl::list<
    Transition<EvSomeEvent<CbSomeClientBehavior, OrSomeOrthogonal>, State1, SUCCESS>
    >reactions;

  // TRANSITION TABLE WITH CLASS GUARD SYNTAX??
  typedef boost::mpl::list<
    Transition<EvSomeEvent<CbSomeClientBehavior, OrSomeOrthogonal>, GdSomeGuard, State1, SUCCESS>
    >reactions;

I'm unsure if passing a Gd (guard) class into the template is the best way to achieve this as it probably? doesn't need any lifecycle methods. Nonetheless, I can imagine some niche scenarios where a Gd class provides a convenient state-container for guard-related logic eg) if the guard prevents a transition > N times, do something such as trigger a Client Behavior.
It may might better if it is simple a function:

Takes in an Event. This is particularly useful for things like EvTopicMessage which may have msgData which is very useful to a guard.0

Some guarding logic - it should have easy access to any state stored in the smacc state, parent state(s) or the configured Orthogonals, Clients or Client Behaviors.  Maybe this would mean the guard would need to be added at runtime? This also provides a point to hook into any transition (as there is currently no onTransition hook on the smacc state. This is useful for doing things like sending notifications onto a ROS topic once a transition is triggered.

Returns a bool:

true - good to transition
false - don't transition

Thoughts and comments?

Hello.
We already talked about that idea many months ago. And that is not hard to implement.
Personally I like the proposal and follows the UML state machine standard.
The main argument why we did not implemented that is because it overlapps the funcionality and responsability of the StateReactors that potentially can receive events and generate other events.
Something related is another idea of making any element of SMACC, states, clientbehaviors, clients, and components be able to react to any event directly. That also would be very useful to implement fast reactions based on specific events.

Very fair. I'm currently working with the SrConditional approach. The main downsides are:

The SMACC RTA display does not work. From memory, it shows something like internal_event with no lines from the state reactor inputs. Better RTA support for State Reactors or Guards would help.

Verbosity. Here is a rather minimal example... I'm not sure if there is a better way to write this. I've had to write others where the state reactors depend on events from other state reactors - at this point, the code gets pretty tricky to follow.

// TRANSITION TABLE
typedef mpl::list<
    Transition<EvSomeInputEventWithGuard, StGuardedState, GUARDED_STATE>
> reactions;

...

void runtimeConfigure()
  {
    auto guard = [ = ](auto * ev) {
        (void)ev;

        // as an example, a behavior which contains some state used as a guard
        auto cbSomeBehaviorWithState =
          this->getOrthogonal<OrSomeOrthogonal>()->getClientBehavior<CbSomeBehavior>();

        // guard checks
        if (!cbSomeBehaviorWithState->value) {
          cbPublisher->publish("Cannot transition because the state stored in CbSomeBehavior says so");
          return false;
        }

        return true;
      };

    this->createStateReactor<
      SrConditional<EvSomeInputEvent>,
      EvSomeInputEventWithGuard,
      mpl::list<EvSomeInputEvent>
    >(guard);
 }

doing things like cbPublisher->publish (using the SmaccPublisherClient) does not work reliably - I'm not sure why.


use the --quiet flag for token generation

Tiny point I know, but I added --quiet for this very reason :-)

Nice! Very clever 😄


Add extension methods for IDomainResult that throw an exception when !result.IsSuccess

In some cases, an exception on failed execution is the desired outcome. To help out here, we can add a bunch of extension methods (like ThrowIfNoSuccess(this IDomainResult result)), like shown below
public static void ThrowIfNoSuccess(this IDomainResult result, string? errMsgPrefix = null)
{
	if (!result.IsSuccess)
		throw new Exception((messageOnError != null ? errMsgPrefix+". " : "") + string.Join(',', result.Errors));
}

public static async Task ThrowIfNoSuccess(this Task<IDomainResult> task, string? errMsgPrefix = null)
{
	var result = await task;
	result.ThrowIfNoSuccess(errMsgPrefix);
}

public static async Task<T> ThrowIfNoSuccess<T>(this Task<(T, IDomainResult)> task, string? errMsgPrefix = null)
{
	var (obj, result) = await task;
	result.ThrowIfNoSuccess(errMsgPrefix);
	return obj;
}

Though, gotta think on the most intuitive name for the methods

There was a similar request – #50


Tree doesn't work anymore for me

I've used the Tree extension for a while now and suddenly (since around August/September), for an unknown reason, I get this error :
  Tree listener was not found on your entity manager, it must be hooked into the event manager
I don't understand the error and so I can't figure out what the problem is.
I use doctrine orm, xml mapping.
Any change I didn't see which would cause this error ?
I'm not even sure if my problem should be posted here or on DoctrineExtensions
Thanks in advance.

It seems it was because of a conflict with the configurations I had in my bundles so I simply override them by putting all the confs needed in my project.


Add wrapping strategy to text widget

This exposes wrapping strategy for text widget. I have kept the default to Wrapping::Word which it was in cosmic_text,
There are other widgets which are using text, I am not sure if Wrapping should be exposed there.
Sample

Hi, will this be available for TextEditor widget too or only for Text widget #2291

Please consider adding this feature to TextEditor widget too

Added for text editor also

Rebased for latest theme changes


http server, before request, should start a new request context

Right now the server can use RequestContextManager to create a new context when it get a request. That way, the context's span will be used by the http clients it uses and the trace will be passed to the servers that it calls. But no reason it won't happen in http_server's before_request.
That way, when a server sends request to another server using an http client, the same trace of the incoming request will be used by the next servers, and the server doesn't need to create the context itself.

RequestContextManager is going to be deprecated once PR #54 is merged.
I am not sure what exactly you're proposing.


x/mobile/cmd/gomobile - init - GOROOT not writable, but writable

Running gomobile init -v:
building gomobile toolexec
gomobile: Cannot install android/arm in GOROOT.
Make GOROOT writable (possibly by becoming the super user, using sudo) and run:
	mv /home/etiennebruines/tmp/gomobile-690904600/android_arm /usr/local/src/go/pkg

Issuing this command does not help, but the problem I would like to address here, is:
The target directory is writable, but the Gomobile tool does not agree.
# ls -l /usr/local/src/go | grep pkg
drwxr-sr-x  8 root staff  4096 Jun  9 12:51 pkg

My assumption says that this is strongly related to #11124

Judging from the output of your ls, your GOROOT is only writable by root, and assuming you are running gomobile init as someone other than root, it means GOROOT is not writable.
The error has changed significantly int the current version of gomobile, as now the only time it writes to the GOROOT is with go install std, so the error you get now is from the Go tool. But ultimately you will need your GOROOT to be writable by gomobile init.


Upgrade stackage resolver to 5.1

The lts-3.3 resolver is 4 months old.

Do you have any concrete reasons for wanting to upgrade to a newer lts?  I don't see the value.

@tonyday567 said:

The main reason for moving to the current version of lts is to be able to include subhask in other projects. An example is ihaskell - I would like to be able to include subhask in an ipython notebook but it proved impossible to drop that ecosystem back to lts-3.3 (I tried).

I'd like to upgrade lts versions for a similar reason. Also, is there a reason why there are explicit package version numbers in subhask.cabal given that it already uses stack?

@mikeizbicki my reason is that I wanted to use HLearn.
I don't want to fiddle with cabal build problems, so I stick with stackage.
I generally use the latest nightly version of stackage, if possible, so I have the freshest possible set of libraries, without any build issues.

Fixed by #30.  Let me know if you run into problems.


Update README

to include new name and parameter

done https://github.com/Turfjs/turf-hex-grid/commit/54019bd25ad0838428e24cb9b1b4d7b8794862f3


Refactor pedersen generator initialisation

At the moment, the configuration for the number of generator indices (and sub indices) is done with two constexpr global variables. https://github.com/AztecProtocol/barretenberg/blob/c6b26c4edb350716257507bd7733eed95b58de16/cpp/src/barretenberg/crypto/generators/generator_data.cpp#L9
This has a few downsides:

Since they're global, they slow down initialisation of bberg; even if you don't need to use pedersen in your application. (@kevaundray I think you've stated this as a problem Noir has encountered in the past).
Configuration has to be done by tinkering with these constexpr variables, so can't be done programmatically, varying depending on the application.
For an example configuration of 16 generators and 32 sub-indices, we end up with a lot of wastage.

Many pedersen commits/hashes will only need a handful of sub-indices. E.g. Merkle membership hashing only needs two; not 32. So we end up 'using up' precious, scarce* generator points for no reason. *We're limited in the number of generators we can initialise, so careful instantiation would be better.

Suggestion for improvement:

Don't initialise generators as globals. Have an initialise_generators function which must be called (by the application using bberg as a library) to generate points. Give the option of holding these points in memory, or return the points to the application (more discussion needed here, please).
Allow the 'configuration' of the generators to be expressed more granularly, e.g.:

std::map<int, size_t> num_sub_indices; a mapping from some enum (whose underlying types are int by default) of generator indices to the number of sub indices required per index.
So if you had an enum:enum GeneratorIndices {
    MERKLE_TREE = 1,
    NULLIFIER,
    // etc...
};

You could specify the number of sub-indices needed per enum value. Sorry about the pseudo syntax here:std::map<int, size_t> num_sub_indices = {
    GeneratorIndices::MERKLE_TREE: 2,
    GeneratorIndices::NULLIFIER: 3,
    // etc...
};

Yeah I'd prefer to have a process to generate these points into a context and then I can feed the context to whatever function requires it. This would require a bigger refactor though if all functions are expecting a global

@iAmMichaelConnor This seems related to #338

@iAmMichaelConnor This seems related to #338

Yeah, this issue's proposal should reduce the memory footprint for both applications.
We can probably have a method for 'granular' initialisation of generators as I propose above (for aztec 3 where we know exactly how many we need for each domain separated pedersen hash), and a 'coarse' initialisation which matches what Noir is used to today (i.e. the constants that were previously being used).

Blocked - need to identify stakeholders and get them on a call to decide best approach.

To be closed by https://github.com/AztecProtocol/aztec-packages/pull/2592


fix(ui): different landing page visual

Thank you for your contribution to the KodaDot NFT gallery.
i found this issue, it's caused by the svg filter feGaussianBlur. it has different behavior in different browsers, here's the chrome/firefox/safari's screenshot and you can easily find the difference.
also provide a codepen for this, you can use different browser to check behavior: https://codepen.io/floyd-li/pen/abaYXGg

so the solution is, replace thesesvg imgs with png.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #4757
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

its looks much more transparent then before, not sure whether we want this tho. Is there any way to fix that?
after:

before:

tested in chrome

thanks for your feedback, seems the svg to png convert goes wrong. i'll update it soon.

its looks much more transparent then before, not sure whether we want this tho. Is there any way to fix that? after:  before:
tested in chrome

@exezbcz just updat bg imgs, pls check it again :)

@roiLeo yeah, I was thinking the same but cannot find the issue - so basically use the raw shapes and then apply layer blur?

@floyd-li yup, looks good now!

@roiLeo yeah, I was thinking the same but cannot find the issue - so basically use the raw shapes and then apply layer blur?

I think we already mention this in older issue.
IMO we need to rework exported svg from figma.
For example on Nuxt website, there is more or less the same thing in header.
They manage to export 3 different gradient size depending on screen size:

desktop
tablet
mobile

@exezbcz @roiLeo I tried this before and seems not working well.
here's the codepen based on the svg, i just commented the feGaussianBlur and use css filter: blur(185px) instead, also displayed differently in firefox as the svg does.
seemsblur effect has different behaviors in different broswers? 🤔
https://codepen.io/floyd-li/pen/abaYXGg

@floyd-li hmm, weird, so the blur filter rendering is based on browser as well

so then is the png the only viable option?

@floyd-li hmm, weird, so the blur filter rendering is based on browser as well

so then is the png the only viable option?

not sure but i think png or webp img is the low-coast solution currently

@floyd-li hmm, weird, so the blur filter rendering is based on browser as well

so then is the png the only viable option?

not sure but i think png or webp img is the low-coast solution currently

as i tested, if the css blur or the svg stdDeviation value > 100, firefox will render significantly different with chrome

Hmm.. not really convinced with this solution but let it roll 🎢
Next we might need to resize (& minimify) the png for better aspec ratio
(and use b-image or nuxt-image lazy loading)

yep i'll follow up this and try to find a better solution

@vikiival @exezbcz is this PR okay to merge?

@vikiival @exezbcz is this PR okay to merge?

let's see what will mr. design will say

@vikiival yes, its oki :D


Make the spec template use the new offense matchers

The rake task new_cop will generate templates for a cop and its spec file. This change replaces the old examples in the spec with the new #expect_offense and #expect_no_offenses matchers.

Before submitting the PR make sure the following are checked:

[X] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Used the same coding conventions as the rest of the project.
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[X] All tests are passing.
[X] The new code doesn't generate RuboCop offenses.
[X] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

👍


Disable test-npm-package job

Overview

test-npm-package job is not working correctly
This PR disables the job temporarily until we can fix it

How it was tested

Looked at github workflow run for this PR

Checklist

[x] The title contains a short meaningful summary
[x] I have added a link to this PR in the Jira issue
[x] I have described how this was tested
[ ] I have included screen shots for changes that affect the user interface
[ ] I have updated unit tests
[ ] I have run unit tests locally
[ ] I have updated documentation (including README)

No longer needed

It looks like the release of Angular 16 has broken this again


Create Tests for New Classes related to Login Feature

Write tests for the following additional classes:

Session [Model]
Username [Person Model]
Password [Person Model]
LoginCredentialsPredicate [Person Model]
LoginCommand [Command Logic]
LoginCommandParser [Parser Logic]

New classes requiring tests:

LogoutCommand [Command Logic]
SwapCommand [Command Logic]
LogicManager [Logic]


[FEA] spark_rapids user tools generates the wrong worker info to pass into java qual tool on databricks aws

Is your feature request related to a problem? Please describe.
spark_rapids qualification \
  --platform databricks-aws \
  --cluster 0606-193048-sgjfvx5 \
  --output_folder . \
  --verbose \
  --estimation_model xgboost \
  --tools_jar /home/tgraves/workspace/spark-rapids-tools2/core/target/rapids-4-spark-tools_2.12-24.04.1-SNAPSHOT.jar \
  --eventlogs /home/tgraves/runspace/qualEventLogs/dataproc-21/application_1716441747790_0001

2024-06-07 08:42:07,570 DEBUG rapids.tools.cmd: submitting system command: <aws ec2 describe-instance-types --region us-west-2 --instance-types r6id.xlarge>

the r6id.xlarge node has 32GB memory. but it generates worker_info file that is passed into java as:
system:
  numCores: 4
  memory: 16384MiB
  numWorkers: 4

nevermind, the issue is that i maps this ot a g5.xlarge node which has 16GB.


Allow interval greater than 60 seconds

Please allow the jiggling intervals greater than 60 seconds (for example I would like to set it to 1800 seconds). Please allow it at least from the command interface.

FYI, I've just created (another) fork that utilize GitHub Actions to generate ready-to-use exe file. No build tool chain or C# programming knowledge is required.
https://github.com/exzhawk/mousejiggler
I've extended the interval to 1800 seconds. If you need more, simply fork the repo, modify two files listed here https://github.com/exzhawk/mousejiggler/commit/c3f6da73849c24d22d3cdbc4b81058c79d377a7c (You can edit it directly on GitHub web page one by one, note they are on build branch)  , set the interval to your desired value, and let GitHub Actions build it for you. You can check and download the exe file from the Actions page of your fork, like this https://github.com/exzhawk/mousejiggler/actions/runs/9685381961 . Download the artifact archive and enjoy.
Adjust the interval value in the GUI might be a little tricky. You can use the mouse wheel, arrow keys, Page Up and Page Down keys to fine-tune it precisely.
Also related to #45


Option to skip extras requires

Currently we find ourselves needing to patch the setup.py file of setuptools as it has extras_require and dependency_links, which don't agree with our package manager. We can provide these during the build. However, we find that setuptools tries to download them anyways. It would be nice if we had an option to disable these settings during the install or at least recognize that they are already accounted for.
cc @msarahan @pelson @ocefpaf

See this PR ( https://github.com/pypa/setuptools/pull/721 ) for a potential solution to this problem.

Setuptools doesn't try to download these when I build/install it. Can you share more about what use case is triggering the undesirable behavior?

I'm not sure I follow. I understand you want to disable setuptools from doing any downloads or installs. I'm not sure you can achieve this goal in the general case, because many projects rely on features like setup_requires to load requirements at build time.
I still don't understand under what circumstances the extras_requires declared in setuptools are being invoked in the conda environment.

So, we actually don't find too many issues with our current strategy of disabling downloads (excepting this case with setuptools). As we are able to specify build requirements to conda, we can satisfy setup_requires before any build step has occurred. Again it would be nice if we can agree on some better way to suppress downloads by setuptools (perhaps some option provided in a config file). However, this is a separate discussion and probably merits its own issue.

I still don't understand under what circumstances the extras_requires declared in setuptools are being invoked in the conda environment.

When I started writing this, I was trying to demonstrate and thoroughly explore the problem. However, it is now clear that adding the arguments --single-version-externally-managed --record=record.txt makes this unnecessary. I decided to keep this in the post here as it may be of historic value.
Sure, let me provide an example. This PR ( https://github.com/conda-forge/setuptools-feedstock/pull/5 ) drops our setup.patch, which was used to remove extras_require and dependency_links from setup.py. As a result, that PR is not doing this removal. Taking the OS X Python 2.7 build as an example, we see that installation is blocked by our nodownload.patch.
Now I can see a couple possible causes. One nodownload.patch is disabling a download that is being attempted. Two nodownload.patch is blocking some other case that is not causing a download.
After trying to remove nodownload.patch in PR ( https://github.com/conda-forge/setuptools-feedstock/pull/6 ), it seems that we are running into the second case. This can be seen as certifi and, when relevant wincertstore, are not downloaded. While this raises some interesting questions about the code path and what nodownload.patch is actually doing here, it doesn't solve our problem.
In the end, it seems that providing the flags ( --single-version-externally-managed --record=record.txt ) as we do with other Python packages using setuptools will solve this problem. This can be seen in PR ( https://github.com/conda-forge/setuptools-feedstock/pull/7 ). It is a bit interesting that these flags are actually needed when no dependencies are (or should be) pulled in. Perhaps this is simply another way to look at some yet again unexpected behavior from the nodownload.patch. In any event, it is perfectly reasonable for us to add these flags (we probably should have done so a long time ago) and it does resolve this issue.

Thanks for the detailed writeup, and I'm glad you found a solution. The single-version-externally-managed flag was designed to essentially bypass the setuptools installer functionality, so that might in fact be the feature you were seeking.

So I'm not surprised that this feature works with install_requires or setup_requires. Though I'm a little surprised that was needed for extras_require. The fact that it is needed in this latter case when it shouldn't be downloading anything (and doesn't seem to be) is a little strange. Still it is totally reasonable for us to have these flags; so, am not terribly worried about it.


XP Orb (and XP tracker?) displaying wrong value for prayer after burying bone

Reported in Discord by Corzappy#5592:

i burried a bone in NMZ and my xp to level became like -2.4 million
https://gyazo.com/608ff931de023969ccc55e3c3a847d66

Based on reports on GitHub this is simply because the person had XP tracker plugin disabled.

So I guess I can close this because globes require that plugin to be enabled

Hey could this issue be reopened? It seems like xp globes requiring xp tracker (although pretty obvious) doesn't seem super clear to users within the client. Perhaps having an enhancement that allows for plugins to specify dependencies that are automatically enabled when it is flicked on (and allow for those plugins to be disabled automatically when their dependencies are disabled) would be useful in order to not see multiple similar bug reports surrounding this issue.
For example, right now even the wiki (https://github.com/runelite/runelite/wiki/XP-Globes) doe snot mention that globes requires the xp tracker to be enabled.

We have already bunch of plugins that depend on XP tracker and I dont think making one plugin enable other is good solution.

What about some kind of warning when a plugin's dependency is disabled. i.e. if I had globes on and then went to disable xp tracker we could fire a Java alert that the player would have to click through that would explain the dependency

Imo just updating wiki page for XP globes should be enough

@deathbeam do you know which plugins depend on the XP tracker? I updated the wiki to include that information for xp globes but it might be good to do the same for the others.

ctrl+click on XpTrackerService should tell you


fix(hydration): css vars should only be added to expected on component root dom

close #10317
Css vars are only added to root node, so when matches expect and actual on hydration phase, only the root node of the instance should set css vars.

Thanks for the PR and good job finding the cause - but there is an easier way of ensuring this condition: 995d2fdcc
I reused the test case from this PR.