HDFS-16975. FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.

Description of PR
FileWithSnapshotFeature.isCurrentFileDeleted is not serialized to FSImage.
If it is true for any files, it will becomes false after saving to a FSImage and loading it back.
We will fix it by checking isInCurrentState() when loading FSImage.
https://issues.apache.org/jira/browse/HDFS-16975
How was this patch tested?
Added "isCurrentFileDeleted" to FileWithSnapshotFeature.toString().  Then, TestFSImageWithSnapshot.testSaveLoadImage() will fail without the fix.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[NA] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[NA] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  9s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 33s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 35s

trunk passed

+1 :green_heart:
shadedclient
22m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 273 unchanged - 1 fixed = 282 total (was 274)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
22m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
208m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

317m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a0100fd134e8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0a0bf14fe9b5c1a7b41e3fbf1a70c07cd4336754

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/2/testReport/

Max. process+thread count
3263 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 18s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
22m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 273 unchanged - 1 fixed = 282 total (was 274)

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
19m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
216m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

320m 49s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 414667cdf682 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0a0bf14fe9b5c1a7b41e3fbf1a70c07cd4336754

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/1/testReport/

Max. process+thread count
3560 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m  2s

trunk passed

+1 :green_heart:
compile
2m  1s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 32s

trunk passed

+1 :green_heart:
shadedclient
23m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 273 unchanged - 1 fixed = 274 total (was 274)

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
20m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
211m 32s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

320m 54s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6e535f6d5cd6 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 84b21c12220234761b43a023f4550db8a94bd6c6

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/3/testReport/

Max. process+thread count
3203 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5546/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @szetszwo for fixing it. Overall changes looks good to me. There are unit tests failed. They seem to be not related. Could you comment on them? Thank you

FSImageFormat.java:801:      return fileDiffs == null ? file : file.loadSnapshotFeature(fileDiffs);: 'if' child has incorrect indentation level 6, expected level should be 8. [Indentation]

The change here does not changing indentation.  The checkstyle warning above is irrelevant.

-1 ❌	unit	211m 32s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

The test failures of TestMover and TestObserverNode are also irrelevant.

@umamaheswararao , thanks a lot for reviewing this!


[v2] add a way to exclude components from SSR within JSX

🚀 Feature
Add a way to exclude components from SSR in JSX. Maybe somethin like <NoSSR></NoSSR>.
Have you read the Contributing Guidelines on issues?
yes
Motivation
Right now, each time we use a react lib that doesn't support SSR we have to put this check {typeof window !== 'undefined' && .... } everywhere inside js and mdx files.
Pitch
Tools like Next js and nuxt provide a way to exclude components from the SSR within the markup. To avoid errors during the build phase we should be able to do se same in a better way than using {typeof window !== 'undefined' && .... } or {typeof document !== 'undefined' && .... }.

I created https://github.com/facebook/docusaurus/pull/2296 which can be used as a convenient API instead of a component. Do you have examples of the API in Next and Nuxt which I can take a look at?

New Nuxt version has these components to handle check the environment from the template:
https://nuxtjs.org/api/components-client-only/
<client-only placeholder="Loading...">
      <!-- this component will only be rendered on client-side -->
      <comments />
</client-only>

Nextjs has a ssr: false option to use with dynamic imports:
https://nextjs.org/docs/advanced-features/dynamic-import#with-no-ssr
import dynamic from 'next/dynamic'

const DynamicComponentWithNoSSR = dynamic(
  () => import('../components/hello3'),
  { ssr: false }
)

@yangshun I would add a similar component just because then we can insert code directly into JSX instead of using useEffect, for example, for our Feedback page, we could do this:
function Feedback() {
  return (
    <Layout
      permalink="/feedback"
      title="Feedback"
      description="Docusaurus 2 Feedback page">
      <div
        className={classnames(
          'container',
          'margin-vert--xl',
          styles.feedbackBackground,
        )}
        data-canny
      />

      <NoSSR>
        window.Canny('render', {
            boardToken: BOARD_TOKEN,
            basePath: '/feedback',
        });
      </NoSSR>
    </Layout>
  );
}

Ok I think we can add that, but it is better named <ClientOnly>/<ClientRenderedOnly>

Fine, I wrote it on my todo list :notebook_with_decorative_cover:

@equinusocio can you please give a specific example (or use case) when a similar component could be useful? Maybe the new API will help with this, could you look? https://github.com/facebook/docusaurus/pull/2296

@lex111 I don't have a public example available, but recently at @OvalMoney we used this react data table component  which don't works inside docusaurus v2 mdx files because it's client-only and when running the build process, docusaurus throw an error about missing window object during the server building.
We had to wrap it inside a custom <NoSRR> component to make the build working

@equinusocio but could you give me a piece of code? I ask this more for documentation purposes, it would be nice to give a real-world example. This tiny component, so no problem with adding it to the core, but I want to get more information on its possible using, as previously I had a wrong idea about in which cases it can be used.

I don't if this is what you need, but this our case:
data-table.mdx

Once you import it, you can use the `<DataTable>` element inside your JSX template.

<NoSSR>
    <DataTable
      columns={[{
        name: 'First column',
        selector: 'someKey',
        sortable: true,
      }, {
        name: 'Second column',
        selector: 'anotherKey',
        sortable: true,
      }]}
      data={[{
        id: 1,
        someKey: 'Some data to print',
        anotherKey: 'Another key data',
        anyOtherKey: 'Any other key data'
      }, {
        id: 2,
        someKey: 'Some data to print 2',
        anotherKey: 'Another key data 2',
        anyOtherKey: 'Any other key data 2'
      }]}
    />
</NoSSR>

We had to exclude the component from the build process because it search for the window object.

Sorry i forgot to mention that the table component is this one
https://www.npmjs.com/package/react-data-table-component

We had to exclude the component from the build process because it search for the window object.

@equinusocio oddly, I tried using the example above, and did not get any build errors. Are you sure that the error was in this component?
import DataTable from 'react-data-table-component';

<DataTable
  columns={[{
    name: 'First column',
    selector: 'someKey',
    sortable: true,
  }, {
    name: 'Second column',
    selector: 'anotherKey',
    sortable: true,
  }]}
  data={[{
    id: 1,
    someKey: 'Some data to print',
    anotherKey: 'Another key data',
    anyOtherKey: 'Any other key data'
  }, {
    id: 2,
    someKey: 'Some data to print 2',
    anotherKey: 'Another key data 2',
    anyOtherKey: 'Any other key data 2'
  }]}
/>

The componet listed for window resize when the hide props is used:
https://www.npmjs.com/package/react-data-table-component#columns

@equinusocio thanks, I added hide prop but still build is going to build successfully, what other options are there how to make build fail?
import DataTable from 'react-data-table-component';

<DataTable
  columns={[{
    name: 'First column',
    selector: 'someKey',
    sortable: true,
    hide: 'md',
  }, {
    name: 'Second column',
    selector: 'anotherKey',
    sortable: true,
    hide: 'md',
  }]}
  data={[{
    id: 1,
    someKey: 'Some data to print',
    anotherKey: 'Another key data',
    anyOtherKey: 'Any other key data'
  }, {
    id: 2,
    someKey: 'Some data to print 2',
    anotherKey: 'Another key data 2',
    anyOtherKey: 'Any other key data 2'
  }]}
/>

@lex111 Sorry for the late response, i've checked again and i can confirm that one of the data table component cause the issue. Here the error we get during building by removing our custom <NoSSR> that wrap the table inside the mdx file:
ReferenceError: document is not defined
(undefined) ReferenceError: document is not defined
    at index_es_Ee (main:2775:30551)
    at Ht (main:2775:60546)
    at d (main:29456:498)
    at Za (main:29459:16)
    at a.b.render (main:29464:476)
    at a.b.read (main:29464:18)
    at Object.renderToString (main:29474:364)
    at render (main:69344:252)

Here are the table props we're using:
columns
data
progressComponent
onRowClicked
subHeader
progressPending
expandableRowsComponent
pagination
highlightOnHover
pointerOnHover
responsive
fixedHeader
noHeader
paginationPerPage
striped
noDataComponent
theme
customStyles

A side note, we'are also using the component createTheme function to customize the table, and this may be the cause. Here the code of the theme, and we assign it to the table theme property like so theme: 'ODS'
import { createTheme } from 'react-data-table-component';

createTheme('ODS', {
  text: {
    primary: `hsl(${Tokens['secondary-80']})`,
    secondary: `hsl(${Tokens['primary-100']})`,
  },
  background: {
    default: 'transparent',
  },
  context: {
    background: 'transparent',
  },
  button: {
    default: `hsl(${Tokens['secondary-80']})`,
    hover: `hsl(${Tokens['secondary-40']})`,
    disabled: `hsl(${Tokens['secondary-70']})`,
  },
  selected: {
    default: `hsl(${Tokens['secondary-50']})`,
    text: `hsl(${Tokens['secondary-90']})`,
  },
  sortFocus: {
    default: `hsl(${Tokens['secondary-80']})`,
  },
  divider: {
    default: 'transparent',
  },
  highlightOnHover: {
    default: `hsl(${Tokens['secondary-50']})`,
    text: `hsl(${Tokens['secondary-80']})`,
  },
  striped: {
    default: `hsl(${Tokens['secondary-40']})`,
    text: `hsl(${Tokens['secondary-80']})`,
  },
});

export const customStyle = {
  subHeader: {
    style: {
      padding: 0,
      marginBottom: Tokens['space-24-px'],
    },
  },
  rows: {
    style: {
      minHeight: '64px', // override the row height
    },
  },
  headRow: {
    style: {
      borderBottom: `4px solid hsl(${Tokens['secondary-50']})`,
    },
  },
  headCells: {
    style: {
      fontWeight: Tokens['font-weight-bold'],
      textTransform: 'uppercase',
      fontSize: Tokens['font-size-16-rem'],
      color: `hsl(${Tokens['secondary-90']})`,
    },
    activeSortStyle: {
      color: `hsl(${Tokens['primary-100']})`,
    },
  },
  cells: {
    style: {
      fontSize: `${Tokens['font-size-16-rem']}`,
    },
  },
  pagination: {
    style: {
      color: `hsl(${Tokens['secondary-90']})`,
    },
  },
};


Manuscript uploaded to biorxiv

Target date: August 17

Update:
Draft has been reviewed by leadership and external partners. Final draft sent to all proposed authors, with confirmation of authorship requested by October 23. Preprint will be posted to biorxiv by October 26th.

@maniarathi - can this be closed?


Request to get a wails 2.8.x version of you image

This is a request more then an issue, are you planning to create a 2.8.x version of your image?
Thank you

https://github.com/abjrcode/cross-wails/pull/9


RepositoryVerificationException

hi there,
i just want to verify my assumption here, because i´m not 100% sure. while creating a repository of type "fs" i get this error:
RepositoryVerificationException[[where_my_snapshots_go] a file written by master to the store [/backup/repo] cannot be accessed on the node [{Nummer 2}{puTLI66RTRGO-HWRuxMoaw}{UAcdFOgmRpWlK7K6xboAkQ}{xxxxxxx}{xxxxxxxx:4300}{http_address=xxxxxx:4200}]. This might indicate that the store [/backup/repo] is not shared between this node and the master node or that permissions on the store don't allow reading files written by the master node];']]

so if i understand this correctly, the folder needs to be shared folder like a NAS where every node is able to write to ???
thanks!

so if i understand this correctly, the folder needs to be shared folder like a NAS where every node is able to write to

Yes.
From the docs

A repository storing its snapshots to a shared filesystem that must be accessible by all master and data nodes in the cluster.


file is not opening with Visual Studio

Type: Bug
when clicking on a file it's not opening with Visual Studio Code - neihter by default option, nor by "open with"
VS Code version: Code 1.85.1 (Universal) (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:06.308Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info

Item
Value

CPUs
Apple M2 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 3, 3

Memory (System)
8.00GB (0.10GB free)

Process Argv
--crash-reporter-id c2ebebe1-ac03-4b29-8dfa-a6b520ab4265

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

xml
Dot
2.5.1

cisco
jam
1.9.1

isort
ms-
2023.10.1

python
ms-
2023.22.1

vscode-pylance
ms-
2023.12.1

jupyter
ms-
2023.11.1100101639

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

subtitles-editor
pep
1.1.7

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
py29gd2263:30899288
vsclangdf:30486550
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30933248
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2cf:30928864
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019acf:30933242

Hi @ovidiy11, could you please provide more information regarding the issue. Does the editor freeze when you try to open a file? How do you try to open a file, through a menu or with a keybinding?
Could you please include a screen recording of the issue?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Use r8 code shrinker

Description
Added flutter automatic bump for r8 code shrinker.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

This is already fixed o #346


Add comments by employee and approver

Expected:
As an employee I can optionally enter a short comment why I request a leave (e.g. "Funeral grandma" or "Influenza" or "Hiking tour Norway"). The employee comment could then be displayed in the calendar team view feed of admins/approvers as well (which improves awareness for other team members in open minded teams).
As an approver I can optionally enter a short comment as well (e.g. "Enjoy your holiday!" or "Sorry, too much workload right now. Shift your leave by two weeks if possible.")
Currently:
Neither the employee nor the approver can add comments.
However the DB table Leaves already has the fields employee_comment and approver_comment and the reason param already gets fetched in the sourcecode. So it should be pretty straightforward to implement.

Yeah, the storage part is done.
The problem was in how to render that data thats why it stuck.
Good point about this feature though.

I plus this request. That would be very useful.

One more person asked for this

What about in the subject line of the email?

Hi @rody8808,
Can you please elaborate little bit more, as it is not very clear to me.
Thanks
Pavlo
Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808<EMAIL_ADDRESS>wrote:
What about in the subject line of the email?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

With the extra field such as (reason) you could assign it to the subject line of the email sent to the supervisor.
From: Pavlo<EMAIL_ADDRESS>Sent: Wednesday, April 26, 2017 11:24 AM
To: timeoff-management/application<EMAIL_ADDRESS>Cc: Darren G. Brown<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)
Hi @rody8808,
Can you please elaborate little bit more, as it is not very clear to me.
Thanks
Pavlo
Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808 <notifications<EMAIL_ADDRESS>wrote:
What about in the subject line of the email?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_timeoff-2Dmanagement_application_issues_133-23issuecomment-2D297482675&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Tx98tw_hHxymanY3Fin81XZzaKJs-FlG5oWIkjexPIw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AawrxjWS6n6z5JKknZv09MUyKUTS8SFHks5rz33AgaJpZM4Ms4Pl&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Zk8WJXSDWE8LpDlrpGMADtT8DqTqT7319aO5EurW3_8&e=.

Ah I see...
Absolutely!
Thank you @rody8808 for suggestion.
(we need to bare in mind that any free text could be exploited by spammers,
but in this case this is less likely to be an issue)
On 26 April 2017 at 18:27, rody8808<EMAIL_ADDRESS>wrote:

With the extra field such as (reason) you could assign it to the subject
line of the email sent to the supervisor.
From: Pavlo<EMAIL_ADDRESS>Sent: Wednesday, April 26, 2017 11:24 AM
To: timeoff-management/application<EMAIL_ADDRESS>Cc: Darren G. Brown<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [timeoff-management/application] Add comments by employee
and approver (#133)
Hi @rody8808,
Can you please elaborate little bit more, as it is not very clear to me.
Thanks
Pavlo
Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
What about in the subject line of the email?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.
proofpoint.com/v2/url?u=https-3A__github.com_timeoff-
2Dmanagement_application_issues_133-23issuecomment-2D297482675&d=DQMFaQ&c=
euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=
rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Tx98tw_
hHxymanY3Fin81XZzaKJs-FlG5oWIkjexPIw&e=>, or mute the thread<
https://urldefense.proofpoint.com/v2/url?u=https-
3A__github.com_notifications_unsubscribe-2Dauth_
AawrxjWS6n6z5JKknZv09MUyKUTS8SFHks5rz33AgaJpZM4Ms4Pl&d=DQMFaQ&c=
euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=
rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=
Zk8WJXSDWE8LpDlrpGMADtT8DqTqT7319aO5EurW3_8&e=>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/timeoff-management/application/issues/133#issuecomment-297483659,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbE5V1tkdC4WRGnCbZouftJ3g4-yCZks5rz36SgaJpZM4Ms4Pl
.

It looks like it may work better on our own server with all the tweaks we need. I will run it on hosted for the 30 days and get feedback from everyone.
Thanks Darren
From: Pavlo<EMAIL_ADDRESS>Sent: Wednesday, April 26, 2017 11:54 AM
To: timeoff-management/application<EMAIL_ADDRESS>Cc: Darren G. Brown<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)
Ah I see...
Absolutely!
Thank you @rody8808 for suggestion.
(we need to bare in mind that any free text could be exploited by spammers,
but in this case this is less likely to be an issue)
On 26 April 2017 at 18:27, rody8808 <notifications<EMAIL_ADDRESS>wrote:

With the extra field such as (reason) you could assign it to the subject
line of the email sent to the supervisor.
From: Pavlo<EMAIL_ADDRESS>Sent: Wednesday, April 26, 2017 11:24 AM
To: timeoff-management/application <application<EMAIL_ADDRESS>Cc: Darren G. Brown <darren<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [timeoff-management/application] Add comments by employee
and approver (#133)
Hi @rody8808,
Can you please elaborate little bit more, as it is not very clear to me.
Thanks
Pavlo
Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808<EMAIL_ADDRESS><EMAIL_ADDRESS>> notifications<EMAIL_ADDRESS>wrote:
What about in the subject line of the email?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.
https://urldefense.> proofpoint.com/v2/url?u=https-3A__github.com_timeoff-
2Dmanagement_application_issues_133-23issuecomment-2D297482675&d=DQMFaQ&c=
euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=
rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Tx98tw_
hHxymanY3Fin81XZzaKJs-FlG5oWIkjexPIw&e=>, or mute the thread<
https://urldefense.proofpoint.com/v2/url?u=https-
3A__github.com_notifications_unsubscribe-2Dauth_
AawrxjWS6n6z5JKknZv09MUyKUTS8SFHks5rz33AgaJpZM4Ms4Pl&d=DQMFaQ&c=
euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=
rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=
Zk8WJXSDWE8LpDlrpGMADtT8DqTqT7319aO5EurW3_8&e=>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/timeoff-management/application/issues/133#issuecomment-297483659,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbE5V1tkdC4WRGnCbZouftJ3g4-yCZks5rz36SgaJpZM4Ms4Pl
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_timeoff-2Dmanagement_application_issues_133-23issuecomment-2D297490879&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=4DDa4tyr8DaOohHEUni8ytp5rplKwI0Z-936-D2SQiY&s=9xfaoDkNW01Ff9tYFZ_dNRQzygtCnxY03Jq_W-3-Hk0&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Aawrxp2gdwVl2m9522I94GbCHn-5F91ccdks5rz4S2gaJpZM4Ms4Pl&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=4DDa4tyr8DaOohHEUni8ytp5rplKwI0Z-936-D2SQiY&s=ZS0X8nRyyA5yv_BbeGdXB9NX3aXYvRezT7zCLA4oZvA&e=.

I second this... please can you add the feature / will this be implemented soon?
Thanks
Mark

how is this one coming along? I am interested in being able to use this feature as well.

Hi, did not get any progress since last comment unfortunately.
Thank you for casting vote: it will bump priority up
Sent from my iPhone

On 1 Nov 2017, at 12:37, theapprover<EMAIL_ADDRESS>wrote:
how is this one coming along? I am interested in being able to use this feature as well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

+1

Badly needed feature.
+1

i second this: (requestor) comment on the mouseover hint in the team view would be good for me.

very interesting feature! :) just wondering if there is any update on this?


Will it support query builder like this

https://laravel.com/docs/9.x/queries

I don't understand your question. This library is a query builder. It relies on other frameworks to execute the SQL - either MyBatis or Spring JDBC.

sorry about that, I didn't express it in more detail.
For example I want to build a search query of table 'customer'
Now In mybatis-dynamic-sql  is like this
   fun search(id: String?, firstName: String?, lastName: String?) =         select(Customer.id, Customer.firstName, Customer.lastName) {             from(Customer)             where { Customer.active.isTrue() }             and { Customer.id (isEqualToWhenPresent(id).map{ it?.padStart(5, '0') }) }             and { Customer.firstName (isLikeCaseInsensitiveWhenPresent(firstName)                 .map{ "%" + it.trim() + "%" }) }             and { Customer.lastName (isLikeCaseInsensitiveWhenPresent(lastName)                 .map{ "%" + it.trim() + "%" }) }             orderBy(Customer.lastName, Customer.firstName)             limit(500)         }
In laravel it may like this
DB::table('customer')             ->select('id', 'first_name','last_name')            ->where('active',true)            ->orderBy('last_name', 'desc')             ->limit(500)
i hope mybatis-dynamic-sql query builder can support  like it in laravel .
For example from:  it can support  a tableName(String) : from("customer")

I don't know anything about Laravel, but from what I can tell there are two main differences:

This library must be used in combination with another framework that will execute the generated SQL. Currently we support MyBatis and Spring (as well as Java and Kotlin languages)
This library uses database model objects rather than accepting strings directly into the builders - this allows us to build type safe queries, and support multiple execution engines

The core MyBatis framework has some tools that will build SQL directly from string inputs (https://mybatis.org/mybatis-3/statement-builders.html). That method of query building is not type safe, but may be closer to what you are interested in.


Modernize examples

The examples were still using beta versions of graphql-cli and graphql-binding. Also the --generator flag was renamed to --language.
One question; in the minimal-example there are two files, prisma-usage.ts and prisma.graphql. I don't understand why these are here? The README doesn't even mention them so it's very confusing for a beginner. I didn't remove these yet because I think that's out-of-scope for this PR, but what do you think?

@SpaceK33z - Thanks for the PR. Looks awesome! 🙌


creating two sidemenu or drawers navigator

Hi There
its basically questions not issue.
i have two question

does the DrawerNavigator support two drawers at a time one from left and one from right?
when the drawer opens, can drawer push the content to left or right instead of overlaying it?

any help will be much appreciated.

Hi
I got this working firstly by creating a TabNavigator (which would trigger the drawers).  These would then invoke two StackNavigators which would in-turn trigger the DrawerNavigator.
A little convoluted so here's some example code (reading from bottom-up):
export const DrawerLeft = DrawerNavigator({
  Inbox:       { screen: InboxScreen,      },
  Calendar:    { screen: CalendarScreen,   },
});

export const DrawerRight = DrawerNavigator({
  Profile:     { screen: Profile,          },
  Settings:    { screen: Settings,         },
}, {
    drawerPosition: 'right',
});

export const EmailStack = StackNavigator({
  Email:       { screen: DrawerLeft,       },
});

export const OptionsStack = StackNavigator({
  Options:     { screen: DrawerRight,      },
});

// Tabs setup
export const TabStack = TabNavigator({
  tabEmail:    { screen: EmailStack,       },
  tabOptions:  { screen: OptionsStack,     },
});

i tried this, but swiping from left opens the left drawer then closes it then opens the right drawer.
so left drawer never stays open.
so not sure if this solution will work?

I setup a demo of the code above from @sigmazen in Expo Snack and I'm seeing the same issue with the drawers that @XeniousSoftware mentioned.
https://snack.expo.io/ry7lYempe

https://github.com/react-community/react-navigation/pull/1757

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!

Whoops! This shouldn't be closed. On my radar.

Any updates on multiple drawer implementation ? I do want two drawers in my app but i am stuck on the above referenced issue . I would be happy to implement a workaround if that is possible . Please check the above mentioned issue and tell me if this has been implemented in react navigation or if any kind of work around is possible.

There's actually a PR open waiting for a review, the #1803

Anyways, I implemented two drawers seperately. One with react navigation(or more specifically react-router-flux) and the other drawer (right drawer) on each page using seperate drawer component (eg, drawer from native base , react-native-drawer etc.).

PR got merged, we'll do a release soon-ish!
In the meantime, you can point to master.

for some people who hasn't found a solution for drawers on both sides.
I wasted so much time to get it working.
I hope some may get hints from it.
import RightSideMenu from '~/RightSideMenu';
import LeftSideMenu from '~/LeftSideMenu';
import { .. } '~/screens'

const MainStack = StackNavigator(
  {

    Main: {
      screen: Main,
      navigationOptions: { header: null },
    },
    Screen1: {
      screen:  Screen1,
      navigationOptions: { header: null },
    },
  },
  {
    initialRouteName: 'Main',
    navigationOptions: {
      gesturesEnabled: false,
      headerStyle: {
        backgroundColor: '#fff',
        elevation: 0,
        shadowOpacity: 0,
      },
    },
  },
);

const MainDrawer = DrawerNavigator(
  {
    MainStack,
  },
  {
    initialRouteName: 'MainStack',
    drawerWidth: Dimensions.get('window').width,
    drawerPosition: 'left',
    contentComponent: props => <LeftSideMenu {...props} />,
    drawerOpenRoute: 'LeftSideMenu',
    drawerCloseRoute: 'LeftSideMenuClose',
    drawerToggleRoute: 'LeftSideMenuToggle',
  },
);

const RootRoute = DrawerNavigator(
  {
    MainDrawer: {
      screen: MainDrawer,
    },
  },
  {
    navigationOptions: {
      drawerLockMode: 'locked-closed',
    },
    drawerPosition: 'right',
    drawerWidth: Dimensions.get('window').width,
    contentComponent: props => <RightSideMenu {...props} />,
    drawerOpenRoute: 'RightSideMenu',
    drawerCloseRoute: 'RightSideMenuClose',
    drawerToggleRoute: 'RightSideMenuToggle',
  },
);

export default AppRoute;

The structure is
but a problem is that I can't find how to pass props to contentComponent when
this.props.navigation.navigate('RightSideMenu');
anyone?

@oojikoo

but a problem is that I can't find how to pass props to contentComponent when

this.props.navigation.navigate('RightSideMenu');
anyone?
try this
        contentComponent: props => <GuildSlideBar {...props} />,


[frontend] Rust changes should trigger TS tests

Rust changes can have an impact on everything, so when considering tests that should run, we should have rust changes also trigger the frontend / sdk projects. Right now I opted for the SDK, Explorer, and Wallet which seemed like the most likely surfaces to have issues. Wallet Adapters should be relatively immune to these changes since they just interact with the wallet / SDK.
The only open question I have right now is the wallet comment PR. It might be confusing why it's showing up if you're only making rust changes. We can either disable it or leave it be.

@longbowlu It's a comment that is added to PRs that modify the wallet including a link to download the built wallet artifact associated with the PR: https://github.com/MystenLabs/sui/pull/4972#issuecomment-1267323480


GNU/Linux port

Neither desktop Linux nor GNU-based mobile Linux distributions have good map apps. A port would be nice.

You can build a desktop version: https://github.com/omapsapp/omapsapp/blob/master/docs/INSTALL.md#desktop

You can build a desktop version: https://github.com/omapsapp/omapsapp/blob/master/docs/INSTALL.md#desktop


Icon is HUGE

Compared with some of my other icons, this icon is larger than the others, feels crowded.

I used Pictogram to use this icon instead

I can easily replace the icon, but I think the app icon could be better.

Thanks for the app for replacing the icon @ludvigeriksson! Although I think the developer should fix the icon

I didn't notice this, Thanks for pointing it out @aubreypwd. I've been super busy with my day work, will fix and push a new version soon


Pipeline testing support and nuget targets for the newly released .NET 5.0

Library or service name.
All
Is your feature request related to a problem? Please describe.
.NET 5.0 just released and I was wondering if we think it is important to add testing support for it in our pipelines and nuget targets (if that makes sense).

@pakrym, we're suspicious this was already done previously with your .NET 5.0 pass through the repo.

Yep, we have .NET 5 testing


mockup-wizard-menu-actions

Triggered by @danyill I was thinking how to get rid of the buttons in the wizard content. @danyill rightly so pointed out that those buttons/actions should be allocated like the primary/secondary action not in the content of the wizard.
This mock puts the in a menu that can be open on icon-button click in the right upper corner of the wizard. You can test it working with EnumTypes in the template editor:

go to Template editor
go to EnumType list
click on any of the list items
see the more vert icon button on the right upper corner
click and try the behaviour
compare to e.g. DAType list -> wizard

@Sander3003 @Flurb @dlabordus @ca-d @danyill I would be curious about your take on it. If this is a viable option, I would get rid of the buttons in wizard content

As discussed today, the main concern is that users need to click an extra time and/or that new users don't know what can be changed. These are UI related things. However, form an architecture point of view, this gives more flexibility. I'm in favour, if needed we can change the UI later and/or build seperate plug-ins for functions are used a lot.

This is the cleaned up implementation for the menuActions in wizard-dialog. This is the feature branch where step by step all wizard-dialog using buttons in the content will be refactored. If you want to see an example, see ...


Rename Streams

Since #466 is not closed yet, here's the follow-up to PR #932.
This one focuses only on introducing new names for Streams, IOS and its derivatives were judged as confusing, so here's a proposition of names for the different Streams of the standard library.
Please let me know if some names are not very explicit, I'll change them if necessary.

I'm not confortable with Reader or Writer, I would suggest to replace it with StreamReader and StreamWriter.

Can we have a summary of the renaming in case of I miss one?
+1 for me, Reader and Writer are simple names so using them in signature of methods could be a improvement.
What about Streamable ? I suggest then to rename it Writable. A Writable is something than can efficiently written as a file, or as a string, or just given to any Writer to to the job.
Note: maybe also improve the documentation of the classes.

Sure !

IOS -> Stream
IStream -> Reader (or StreamReader if @Morriar's proposition is retained)
OStream -> Writer (or StreamWriter if @Morriar's proposition is retained)
IOStream -> ReaderWriter (Maybe a better name might be proposed, something like Duplex or other ?)
BufferedIStream -> BufferedReader
PollableIStream -> PollableReader
FStream -> FileStream
IFStream -> FileReader
OFStream -> FileWriter
IOFStream -> FileReaderWriter
StringIStream -> StringReader
StringOStream -> StringWriter
IProcess -> ProcessReader
OProcess -> ProcessWriter
IOProcess -> ProcessReaderWriter

Some names need to be discussed, mainly the ReaderWriter combos, I was thinking Duplex might be a better name, though this will need your approval.
And if anyone has a better idea for the Process*, I'm more than willing to hear your suggestions !

And +1 for Writable !

Great improvement!
ProcessReaderWriter is a bit heavy... Maybe we could use ProcessStreamer? Streamer, or something else, could be used as a shorter ReaderWriter... What do you think?
+1

I don't know, Streamer is a bit too close to Stream for my taste, kind of
like the old ambiguity between IOS and IOStream. I agree though, something
shorter can be thought of !
Since it can be used in two directions, RnRStream, as a reference to the
next big hit in gaming ? :)
On 8 Feb 2015 12:48, "Alexis Laferrière"<EMAIL_ADDRESS>wrote:

Great improvement!
ProcessReaderWriter is a bit heavy... Maybe we could use ProcessStreamer?
Streamer, or something else, could be used as a shorter ReaderWriter...
What do you think?
+1
—
Reply to this email directly or view it on GitHub
https://github.com/privat/nit/pull/1153#issuecomment-73422013.

Reroll:

Renamed Streamable to Writable
ReaderWriter and its derivatives are now named Duplex as they were too heavy

I proposed Duplex since it is quite self-explanatory (some do this too, like Node.js (I'd never thought I'd use them as example !))
Anyhow, this is still a proposition, comments are welcome !

+1 C'est pas parfait mais ça semble un progrès.

@R4PaSs j'ai des conflits de merge, tu peux rebaser?

@privat : Done ! If it passes tests, you'll be all ready to merge !


tools/wipe-linux: check for whitespace + 2.5GB

This previously detected my 402.5GB macos as a linux disk.
Let's make it slightly safer by checking for exactly 2.5GB
Note: if the macos disk is mounted it doesn't actually get deleted
Signed-off-by: Steffen Dirkwinkel<EMAIL_ADDRESS>

Should be fixed in d993fe9da2, sorry, hadn't pushed it yet!


[PDI-15922]-Missing data when using delimiters like "aa" in the CSV file

fix for regression BACKLOG-14781
fix case for multichars enclosure
fixed unittest

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/csvinput/CsvInput.java
  engine/src/org/pentaho/di/trans/steps/csvinput/CsvInputData.java
  engine/test-src/org/pentaho/di/trans/steps/csvinput/CsvInputEnclosureTest.java
  engine/test-src/org/pentaho/di/trans/steps/csvinput/CsvInputUnicodeTest.java
  engine/test-src/org/pentaho/di/trans/steps/csvinput/CsvProcessRowInParallelTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.csvinput.CsvInputData

Branch Change:  + 1.13%
Complexity Change:  + 1.75%
Instruction Change: -.51%:small_red_triangle_down:
Line Change: -.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change:  + .09%

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .31%
Instruction Change:  + .06%
Line Change: -.23%:small_red_triangle_down:
Method Change: -1.02%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.53%:small_red_triangle_down:
Complexity Change: -4.05%:small_red_triangle_down:
Instruction Change: -.35%:small_red_triangle_down:
Line Change: -.97%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change:  + 1.79%
Complexity Change:  + 1.19%
Instruction Change:  + .07%

@mbatchelor @mchen-len-son please review the changes


update chronological order of the React Miami conf

Moved React Miami 2023 to previous conferences since it just passed!

thanks!


Added VMSS samples

This PR adds samples for Virtual Machine Scale Sets (VMSS)

@vladbarosan @joshgav Can this be merged?

@tariq1890 , merged. Thanks for the PR!


Add horticultural engineering technology

Horticultural Engineering Technology is a free video series on horticultural engineering technology and controlled environment agriculture developed and presented by Ohio State University, Rutgers, and the University of Arizona, with support from the USDA and NIFA.
All the videos in the series are viewable on Youtube.

Thanks for your pull request. It looks like the channel is not active anymore that's why it does not fit the contribution guide. That's why I have to close the pull request without merging it.


Getting smart object properties

I know, athough incredibly surprising, that it's not possible to write inside SOs.
However would it be possible instead to retrieve the properties applied to the smart object (perspective change, warp, blend options, opacity, position, dimensions) and use those in a python script that would take those properties and create its own smart object placeholder mask, which in this case can be used to replaced overlaying an image applying the SO property?
EDIT: I've managed to pretty much make it but I'm not able to get/apply the warp and or perspective

?

?

@milqnomadu Did you get this working?

@spector700 can’t get warp properties in any way unfortunately

This is a smart layer and I opened with PIL. I get the transform_box chords from the smart object, and if I draw them it is incorrect. Why is this?
    base_image: Image = smart_layer.smart_object.topil()
    points = [
<PHONE_NUMBER>132139, 2178.74013434089),
        (3468.5239616613417, 1068.2773109243699),
        (4847.65092073659, 1584.6679765431352),
        (2068.7717049038592, 3137.0252100840335),
    ]
    draw = Draw(base_image)
    draw.line([points[0], points[1], points[2], points[3], points[0]], "blue", 10)

@spector700 have you managed to solve this?

Yeah, I did get it aligned. But I switched to using the Photopea API, which is in JavaScript. I needed to add the image into the smart object and not just replace over it, which didn't seem possible with psd-tools.

@spector700 would it be possible for you to share what you used with Photopea? I wanted to use it swell but I didn't manage to make it work. If so please we can get in touch via email at<EMAIL_ADDRESS>Thankss!


target wasm32 install stdweb

I opened same issue on printpdf but actualy it is time package it install stdweb target wasm32

stdweb has not been a dependency of time for the entirety of the 0.3 series. A quick check shows that printpdf relies on time 0.2. The issue is that they're relying on an old version.


New package: Marcus v0.0.1

Registering package: Marcus
Repository: https://github.com/chemicalfiend/Marcus.jl
Created by: @chemicalfiend
Version: v0.0.1
Commit: 78ffc9e51b2bf183efa0efb5ad6439fa306ef1d9
Reviewed by: @chemicalfiend
Reference: https://github.com/chemicalfiend/Marcus.jl/issues/1
Description: Mobility with Marcus model

This seems to be a test only, so I assume this can be closed @chemicalfiend?
For future, I would assume that a generic and non-intuitive name like Marcus will generate some pushback when attempting to register in the General registry, where we are usually looking for more descriptive names to aid discoverability.

Yes sure, it can be closed it was just a test..

MarcusMobility would be totally fine, though


Better error message for to_csv with distributed worker and non-local filesystem

I just ran into an issue when trying to use to_csv with distributed workers that don't share a file system. I shouldn't have been surprised that writing to a local file system from a distributed worker doesn't work. It shouldn't work. But the error I got was just a File Not Found error. That brought me to:https://github.com/dask/dask/issues/2656#issuecomment-343903868 - which was the answer.
I am wondering if dask might serve a more informative error in these (maybe) typical failure cases just to point people in the right direction. Does that seem reasonable?

I want to get assigned to this issue

I would like to work on this issue

Great! Just open a pull request when you have something written.

@jordi-crespo Are you still working on this?

@jordi-crespo Are you still working on this?

Hello .. Is this still open? Shall I work on this?

No PR is linked so you can assume that no one is working on this.

Is this issue about adding a meaningful error message for to_csv? I tried to look for File Not Found error message in ./dataframe/io/csv.py, which has the to_csv method, but I couldnt find the error message. Can you please help me if I am looking at the right place for this issue? If not, can you please provide direction? Thanks!

I randomly ran into a similar issue when I forgot the remote worker mounts were different than the local mounts.  I'm curious if there exists an efficient way to test for such a situation such that dask could provide a more helpful error message? I thought perhaps that the File Not Found exception could be caught and a comparison of /etc/fstab could be made between local and worker file systems, but that seems a bit complicated and *nix centric.  I would love to hear ideas about potential solutions.

I was imagining that we'd just look at the path before attempting computation and raise if it cannot work, but I didn't ever get around to trying that approach out.


Show a confirmation notification when installing/uninstalling shell commands

Testing #124841
While it's nice that this automatically works in the background, there was no confirmation in the tool that told me whether it succeeded or failed so I had to manually check. It would be nice if there was a toast that confirmed this. Similar to the settings editor that shows this on your first edit:

We are actually in the process of removing that notification: https://github.com/microsoft/vscode/pull/125083
I intentionally didn't want to show a notification, given this decision tree: https://github.com/microsoft/vscode/issues/119463#issuecomment-825663289

🤔  Hmm...I guess in the decision tree, Does the user really need to be alerted? you could make an argument for both sides. My issue is I ran an action and I don't know whether it worked or not and have to go check. So my confidence in it working is really low.

I restored the previous message we used to show for both commands but I am using a modal dialog instead of a notification given it originates from a user action.
I think the decision tree should account for this actually, imho being blocked or not should not be the only criteria for deciding on using notifications vs a dialog. I would add that a dialog should be used when triggered by a user action such as a command.


Allow to take XML snapshots of Strings

currently it is not possible to use XML structure compare for strings because they will be always run through a marshaller. If we receive a String as actual input to snapshot.assertThat(...) then we should just skip the serialization part and pass the string through

Released in 1.6.0


Configure separate disk for /var/lib/kubelet for worker nodes

How to categorize this issue?
/area os
/area storage
/kind enhancement
/priority 3
What would you like to be added:
At the moment, only the WHOLE /var/lib can be assigned to additional disks using for worker nodes:
https://github.com/gardener/gardener/blob/a6eda4d63195f9373c1c17055f1b18d3f962bfb9/example/90-shoot.yaml#L50-L55
This configuration description:

kubeletDataVolumeName
(Optional)KubeletDataVolumeName contains the name of a dataVolume that should be used for storing kubelet state.

The problem is that the OS and services (e.g. docker) would still create their own folder structure and use /var/lib.
And by this, there is no clear separation of the storage of kubelet working folder from others as the description indicates.
In my opinion, with the setting of kubeletDataVolumeName the point would be to:
Only the /var/lib/kubelet is mounted to different disk, and not the whole /var/lib.
I'd like to add an option to mount the additional disk to /var/lib/kubelet only.
Proof
# lsblk
NAME   MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sda      8:0    0   50G  0 disk               <======= OS FS
|-sda1   8:1    0    1M  0 part
|-sda2   8:2    0   16M  0 part /boot/efi
|-sda3   8:3    0    1G  0 part /usr
`-sda4   8:4    0   49G  0 part /
sdb      8:16   0   25G  0 disk /var/lib      <======= Additional disk
sdc      8:32   0  128G  0 disk
`-sdc1   8:33   0  128G  0 part /mnt/resource
sr0     11:0    1  652K  0 rom

These folder will be located on the additional disk besides the kubelet folder
/var/lib# ls -1
apt
calico
cloud-config-downloader
cni
dbus
dictionaries-common
docker
dockershim
dpkg
dracut
gardener-user
gardener-user-ssh.key
grub
kube-proxy
kubelet           <==== not separated on different storage
logrotate
lost+found
misc
nfs
pam
polkit-1
private
python
quota
sudo
systemd
ucf
vim
waagent

Why is this needed:
I believe that the point of  kubeletDataVolumeName is to separate kubelet workdir from OS filesystem. Even if it is configured;
once kubernetes workload impacts the storage behind the /var/lib/kubelet on a give host, it could effect the whole host and system since the OS is still using the very same disk for different services (through /var/lib).

Have you tried pure containerd+runc without docker?
It seems containerd is using /run/containerd/ in contrast to docker which is using /var/lib/docker and docker will be soon removed as part of #4110.

Hi @vpnachev,
Problem still exists with containerd CRI.
Containerd is storing the data/state under /var/lib/containerd.
Even if the API reference/documentation mention that the kubeletDataVolumeName the kubelet folder storage device is specified - the whole /var/lib is moved to the other storage device.
Mounting path should be /var/lib/kubelet instead of /var/lib:
https://github.com/gardener/gardener/blob/master/pkg/operation/botanist/component/extensions/operatingsystemconfig/executor/templates/scripts/execute-cloud-config.tpl.sh#L47-L58
Is it possible to make such a change, or create an extension, so really the 'kubelet' folder would end up on a different storage device?
Thanks,
mkska

This issue looks legit.
When gardener-node-agent is active the nodes cannot join the cluster on worker groups where kubeletDataVolumeName is set. GNA stores files in /var/lib/gardener-node-agent and it might not like if there is suddenly a new disk.
/reopen
/remove-lifecycle rotten
/assign


Support pass in absolute path, or just a bug?

When test failing, we can see a file path like this.

Then, we can copy it, and run it again with m.
m /home/zw963/Stocks/marketbet_crawler/test/stocks_test.rb:11
Failed loading test file:
cannot load such file -- .//home/zw963/Stocks/marketbet_crawler/test/stocks_test.rb
There were no tests found.

Yeah, this keeps tripping me up too. Would welcome a PR to fix this for anyone who has time. @blowmage, interested?

I'll take this.


Parent document completions are showing up in nested documents

Description
With the completion providers API we cannot suppress the completions from other kernel in transclusions, e.g. in magics like %%sql or %%R.
Reproduce

See that both r2table from R via LSP and range/repr/reversed from Python kernel are showing up.
Expected behavior
Only relevant completions are shown
Context

JupyterLab version: 4.0.5
5.0.0-a1

We can solve this by overriding isApplicable() in kernel/context provider (because we are overriding them anyways).

This is not pretty because isApplicable only gets context and not the request position. We can still get the editor position from editor.


File-tree crashes after filename interference problems

The title is a bit cryptic, but the steps are really simple:

Create a folder called foo/.
In the folder create a file called bar (without an extension)
Try to create a folder called bar, get error about the file/directory existing
Remove the file called bar
Try to create a folder called bar

Expected: Folder called bar is created.
Actual: Folder called Untitled-1 is shown on the filetree (but not created), error Uncaught TypeError: undefined is not a function is thrown at `ProjectModel#L187 and the folder is unusable until restart. After this many of the file tree functions in general don't work correctly.
Tested on: Latest master https://github.com/adobe/brackets/commit/8093791728cbff6f7734fbad41882481c82087f9, newest MacOS

ChainsawFist has found a solution to this as well. What needs to happen is that the file cache needs to be refreshed before the ProjectModel (project/ProjectModel.js) javascript goes into it's logic for the function doCreate(). Typing var fs = _getFSObject(path); as the line after var d = new $.Deferred(); in the doCreate() function seemed to have fixed the issue. However fs is never used, so while that is a solution it's not a great one. Looking at the contents of _getFSObject(path), it might actually make sense to use fs in place of both directory and file variables in the doCreate().

Using fs as the variable works in place of directory and file.

Wow, I wasn't even able to repro this on my machine...

Didn't work on your machine or you weren't seeing this bug? This worked on a Mac just to clarify what machine I'm using.

If this fixes the problem then I'll do the tests (I just have to do the smoke tests now) and create a PR.

I wasn't seeing the issue. Tried several things, but it didn't blow up.

@petetnt, are you still getting the issue?

@jamran7 couldn't replicate it anymore on my Windows 10 PC against latest master, I'll try later against my macOS too to see if this still occurs there.

Do not collaps foo/. That fixes the problem within foo because it refreshes the file index. Without collapsing the folder, say you create bar and bar/ in the work space, the problem exists.

It happens on my latest commit of Brackets

Is this still an issue @petetnt?


Track Disk Usage

Closes https://github.com/anarchy-ai/LLM-VM/issues/138
track disk usage, test results
Disk Usage:
|█████████████████---------------------------------| 33.86%

Hey... this is tracking disk usage for the entire computer, not just the caches and stuff that HF libraries etc write to under ~/.cache or wherever...

The other 7 files, could not be returned, the compiler could not compile them, the files did not exist.
Unresolved reference 'labels'
Unresolved reference 'keys'
Unresolved reference 'llm_vm.agents.FLAT.agent_helper.labels'
I'm using python 3.11.
Pycharm also sets up the sources root, but the project project does not have these files, so I've removed them for import

The disk.py file uses psutil.disk_partitions(), which scans all of the disk


Research fly.io for free postgreSQL / Migrate Ceramic dashbords

The following resources are available on free account:

1 core of shared CPU
256 Mb Ram for PG process
1Gb storage
up to 2 instances
single external IP
perhaps no TLS ?

Creds are pinned to #devs Slack channel.
I've configured bith secure & insecure connections, but TLS fails to connect with 'connection terminated unexpectedly' error. Maybe this because a) no SSL/TLS for external connections provided on free account b) the instance available only is called 'dev-configuration', they're suggesting to use own tool (like vpn client) to connect & work with it
I suppose the following resources could be enough for run ceramic dashboard. All we need is to store short texts and some strapi metadata. All images are uploaded to S3.
Next (possible) steps

[ ] backup dev & QA pgsql databases on Heroku
[ ] migrate dev and QA on Fly
[ ] test dev/QA on Fly
[ ] prepare migrate PROD to Fly
[ ] backup PROD
[ ] migrate PROD to Fly

# fly.toml file generated for ceramic-dashboard on 2022-09-01T13:31:32+03:00

app = "ceramic-dashboard"
kill_signal = "SIGTERM"
kill_timeout = 300
processes = []

[checks]
  [checks.pg]
    grace_period = "30s"
    headers = []
    interval = "15s"
    method = "get"
    path = "/flycheck/pg"
    port = 5500
    protocol = "http"
    restart_limit = 0
    timeout = "10s"
    tls_skip_verify = false
    type = "http"
  [checks.role]
    grace_period = "30s"
    headers = []
    interval = "15s"
    method = "get"
    path = "/flycheck/role"
    port = 5500
    protocol = "http"
    restart_limit = 0
    timeout = "10s"
    tls_skip_verify = false
    type = "http"
  [checks.vm]
    grace_period = "1s"
    headers = []
    interval = "1m"
    method = "get"
    path = "/flycheck/vm"
    port = 5500
    protocol = "http"
    restart_limit = 0
    timeout = "10s"
    tls_skip_verify = false
    type = "http"

[env]
  PRIMARY_REGION = "dfw"

[experimental]
  allowed_public_ports = []
  auto_rollback = false
  enable_consul = true
  private_network = true

[metrics]
  path = "/metrics"
  port = 9187

[[mounts]]
  destination = "/data"
  encrypted = false
  source = "pg_data"

[[services]]
  internal_port = 5432 # Postgres instance
  protocol = "tcp"

# Example of opening port 443 for secure connections
[[services.ports]]
  handlers = ["tls"]
  port = 443

# Example of opening port 10000 for insecure connections.
[[services.ports]]
  handlers = []
  port = 10000

@sirpy no, Heroku provides one database per app. We can choose type of instance (billing plan) when we're attaching it, but even if we would choose same type & region, Heroku may provide different instances. Also DATABASE_URL env var will be hard-coded and i suppose there won't be permissions to create another database using creds Heroku provided. So the trick to connect via pgsql client create separate databases for dev & qa then set config using env var with different name won't work.
Opposite to this, fly provides option to create many databases on a single node. If you're ready to pay i suggest you to compare pricing. What would be cheaper - dedicated-cpu-1x @ 2GB RAM (would be enough) or 3 heroku postgres instances


Porting Guidelines to different OS and baremetal Software

Hello Experts,
Is there any porting guidelines (APIs used for porting) to define the list of ports need to be made for various OS, Platform and interfaces?
Example: Folders like interfaces, arch, drivers has the porting APIs. Anything in addition I need to consider ?

That's pretty easy. You go into https://github.com/libcsp/libcsp/tree/develop/src/arch and implement those files for your architecture.
Bear in mind that CSP relies on queues. If your OS is bare-metal you will have to write your own queue implementation. Another thing it uses is the blocking queue reads, which you will have to implement in a polling interface instead. So baremetal is not completely simple.


Check failed in tf.image.crop_and_resize and tf.compat.v1.image.crop_and_resize when boxes and box_indices are empty.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.15
Custom code
No
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Check failed in tf.image.crop_and_resize when boxes and box_indices are empty, which causes the program to crash. See the colab link below for details.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1FDl2zKTLnCEA8aSIAjsOHg4B3CIPJNCn?usp=sharing

Relevant log output
Check failed: NDIMS == dims() (2 vs. 1)Asking for tensor of 2 dimensions from a tensor of 1 dimensions

can you assign this issue to me ? i am new bie this will be my first contribution for oepn source .

@JiteshSinghShekhawat  I'm sorry, I don't have permission to assign. You might need to wait for response of @Venkat6871.

Hi @xl1043237213 ,
I tried to run your code on colab using TF v2.15, 2.16.1, nightly and faced the same issue. Please find the gist here for reference.
Thank you!

Hi @JiteshSinghShekhawat ,
Please feel free to contribute.

@xl1043237213,
I tried to execute the mentioned code on tf-nightly(2.18.0-dev20240807) and observed that the code was executed without the crash. Kindly find the gist of it here. Thank you!


format: FileSystem changed to File_system (WIP - keep open)

retest please

test please

retest please

Previous test was aborted due to signal to clang for some reason.

Test timed out. retest please.

retest please
Added g++-multilib to all the pull request machines.


Allow byproducts if there is no other solution

The following should work:
!max fuel where crude-oil <= 240
This currently fails because all byproduct outputs are constrained to 0.
The user she be prompted to select which byproduct, or the solver can allow all byproducts as a fallback. Perhaps there should be a new way in the syntax to allow certain byproducts.

Some notes:
Modify the objective to penalize byproduct outputs that are not specified in the query.
Try -1000*byproduct in objective
Try to use makeElasticSubProblem again

Now the user is prompted if there is no solution without byproducts


It does not work with Intellij 2017.3

It works fine with Intellij 2016.2.
However in Intellij 2017.3, only component dependency graph is shown, but no any vulnerabilities displayed.

@goldyliang,
Thanks for reporting this issue, we have committed a fix that can be viewed here.
We have released version 1.0.1 of the plugin and it will be available in IntelliJ IDEA in a couple of days.
Manual download available here.

@goldyliang, I'm closing this issue for now.

Thank you!
On Mon, Sep 25, 2017 at 12:50 Eyal Ben Moshe<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/JFrogDev/jfrog-idea-plugin/issues/1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JFrogDev/jfrog-idea-plugin/issues/1#event-1264111462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALhCU77t88QSEtaW7yBM7aSumI84Tya1ks5sl9nPgaJpZM4PQBMc
.


How is the tagging of the subnets and security groups taken cared of

Hello There,
I was creating my own cdk stack which migrates my eks cluster from cluster autoscaler to karpenter. I did not find this cdk construct until now.
In my stack, I successfully create everything except, the tagging of the subnets and security groups. Somehow, I am finding it difficult to acheive that. I know an easy solution would be run a boto3 code after I have deployed everything. Instead I would like to see the tagging also done as part of the cdk.
Does this cdk construct take care of the tagging part if I just pass the eks cluster into the construct call?

Hi @ashishkurian, this construct is not responsible for tagging subnets, and probably shouldn't be so that it does not modify resources which it does not own. Instead, tagging should sit with the CDK code used for creating the VPC, EKS cluster, etc. As an example, you can see https://github.com/aws-samples/cdk-eks-karpenter/blob/main/test/integ.karpenter.ts, where the EC2NodeClass uses up tags from the VPC created in the same stack.


Update Set-SPOSite.md

Added missing parameter for -SharingCapability and updated parameter descriptions.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Distributed wrapper issue

The function getPipelineInputTypes is no longer functioning.
The error is always.
loc("-":1:1): error: Dialect `func' not found for custom op 'func.func.
The source of the error is the following line
mlir::OwningOpRefmlir::ModuleOp module(mlir::parseSourceStringmlir::ModuleOp(mlirCode, &ctx));
For example, I have printed the MLIR code that is passed to the function, it looks as follows
func.func @dist(%arg0: !daphne.Matrix<?x15xf64:sp[1.000000e+00]>, %arg1: f64) -> !daphne.Matrix<?x?xf64> {
%0 = "daphne.ewAdd"(%arg0, %arg1) : (!daphne.Matrix<?x15xf64:sp[1.000000e+00]>, f64) -> !daphne.Matrix<?x?xf64>
"daphne.return"(%0) : (!daphne.Matrix<?x?xf64>) -> ()
}
@pdamme @corepointer @aristotelis96  any ideas/suggestions?

I suspect that the MLIR func dialect is not registered correctly. This dialect was added with our recent MLIR upgrade. However, in src/runtime/distributed/coordinator/kernels/DistributedWrapper.h:getPipelineInputTypes(), unregistered dialects should be fine, since we say ctx.allowUnregisteredDialects();...
I need to have a closer look, but since all test cases pass successfully (on main): Can you please share some details on how to trigger this error? (How do you invoke daphne etc.)

Thanks @pdamme  I am not sure how you can reproduce it. I mean it only appears if you go through the DistributedWrapper.h, i.e., I am not sure what are the test cases that you rerun. do they include any distributed "e.g., gRPC" kernels?
The way I come to this error: I merged the main DAPHNE into my fork
https://github.com/AhmedEleliemy/daphne
You can clone it and run the following command
mpirun --allow-run-as-root -np 4 ./bin/daphne --distributed --vec scripts/examples/hello-world.daph
does it make sense?
I think the same thing should happen to the gRPC as well
@aristotelis96 can you confirm?

I just looked into it and yes the error appears with the gRPC as well. @pdamme you can reproduce it on the main branch if you run distributed daphne. The steps are:

Build and run a distributed worker: ./build.sh --target DistributedWorker; ./bin/DistributedWorker localhost:5000
On another terminal, set enviromental variable export DISTRIBUTED_WORKERS=localhost:5000
run distributed daphne ./bin/daphne --distributed example.daphne

The issue should also be present on the worker (src/runtime/distributed/worker/WorkerImpl.cpp) when parsing the MLIR fragment for execution (which now never happens since DistributedWrapper crashes before that step).

I think the issue is not loading FuncDialect on the MLIRContext object. I was able to fix this by adding:
ctx.getOrLoadDialect<mlir::func::FuncDialect>();, will open a PR shortly.
Tests use the Compute function from the WorkerImpl.cpp which creates a DaphneIrExecutor and get's the context object from there. DaphneIrExecutor's constructor correctly loads the FuncDialect which results in tests passing correctly and not causing any issues on the worker implementation.

Thanks, but you don't need to, I'm about to commit a fix :) .

For some background: Even though we allow unregistered dialects at that point by ctx.allowUnregisteredDialects();, we need to register the func dialect to make it work, most likely because the operation func.func has a custom assembly format, which cannot be parsed unless the dialect is registered. That's my explanation...

Thanks @pdamme for confirming the fix and providing the explanation. I'll push the fix soon. :)

Tests use the Compute function from the WorkerImpl.cpp which creates a DaphneIrExecutor and get's the context object from there. DaphneIrExecutor's constructor correctly loads the FuncDialect which results in tests passing correctly and not causing any issues on the worker implementation.

That is true for the unit tests in test/runtime/distributed/worker/WorkerTest.cpp. However, we also have script-level tests (which invoke daphne as a separate process, so we go through the entire parser/compiler/runtime -stack) for distributed execution in test/api/cli/distributed/DistributedTest.cpp. Line 60 in that file specifies only the --vec flag, which used to be sufficient to trigger distributed execution if the environment variable DISTRIBUTED_WORKERS is set. Meanwhile, this behavior was changed, now --distributed must be given. I've just fixed this in the test case in 20080d78f8278b678c70b6068cf53aff39f1a1ce.


Missing annotation and/or documentation for file attachments

The current documentation describes MessageContent.file.blob as unknown, which is absolutely useless. The website https://discordeno.mod.land/ also doesn't contain any documentation on how to add attachments to a message.
Including something like file: {blob: Deno.readFileSync("some_file.whatever"), name: "some_file.whatever"} in MessageContent causes a The request was improperly formatted, or the server couldn't understand it. error.
Since the option exists, I'm sure there's a particular type that this function accepts so that file attachments work, but, the lack of documentation means I have no way o figuring this argument out.
So, what should be the type of MessageContent.file.blob? And why isn't this type described in the MessageContent description?

Yup the type is weird - try using blob: new Blob([Deno.readFileSync("some_file.whatever")])

file: {blob: Deno.readFileSync("some_file.whatever"), name: "some_file.whatever"} does not work because you are doing it wrong. You are reading the file bot not converting it to a Blob.
Ayntees example:
const bytes = Deno.readFileSync("./jerry.jpeg"");
message.send({
  file: {
    blob: new Blob([bytes]),
    name: "some_file.whatever",
  }
});

So, what should be the type of MessageContent.file.blob? And why isn't this type described in the MessageContent description?
We already had better types but since it was breaking we reverted the change. Most likely this will be added in v11

Ok, cool, so then why isn't the type of MessageContent.file.blob set to Blob?


docs(plugins): add creating your own plugin guide

cc @machi1990 @wtrocki I did not get this fully finished. As I am away next week I have pushed it for you guys to take over.
The example plugin actually works, what is left is mainly to show an example query
import { GraphbackPlugin, GraphbackCoreMetadata, GraphbackContext, QueryFilter } from 'graphback';
import { GraphQLSchema, GraphQLList, GraphQLNonNull, GraphQLResolveInfo } from 'graphql';
import { SchemaComposer } from 'graphql-compose';
import { IResolvers, IObjectTypeResolver } from '@graphql-tools/utils';

export class MyGraphbackPlugin extends GraphbackPlugin {
  transformSchema(metadata: GraphbackCoreMetadata): GraphQLSchema {
    const schema = metadata.getSchema()
    const schemaComposer = new SchemaComposer(schema)
    const graphbackModels = metadata.getModelDefinitions()

    for (const model of graphbackModels) {
      schemaComposer.Query.addFields({
        [`getArchived${model.graphqlType.name}s`]: {
          type: GraphQLNonNull(GraphQLList(model.graphqlType))
        }
      })
    }

    return schemaComposer.buildSchema()
  }

  createResolvers(metadata: GraphbackCoreMetadata): IResolvers {
    const resolvers: IResolvers = {}
    const queryObj: IObjectTypeResolver = {}

    for (const model of metadata.getModelDefinitions()) {
      const modelName = model.graphqlType.name

      queryObj[`getArchived${modelName}s`] = async (_: any, args: any, context: GraphbackContext, info: GraphQLResolveInfo) => {
        const crudService = context.graphback.services[modelName]

        const filter: QueryFilter = {
          archived: {
            eq: true
          }
        }

        const results = await crudService.findBy(filter, context)

        return results.items
      }
    }

    resolvers.Query = queryObj

    return resolvers
  }

  createResources() {

  }

  getPluginName() {
    return 'MyGraphbackPlugin';
  }
}

@craicoverflow sure, I'll take over and drive this baby home ;-)

Going through the GraphbackPlugin#createResources and I feel like this method can be non-abstract, in a sense that a developer does not have to implement it. As maybe, they will be looking at adding resolvers or transforming the schema
/cc @wtrocki @craicoverflow WDYT?

Makes sense now


Try readding all inotify flags

Adds back some inotify flags that were once too new, but it appears the inexorable process of time has made the tests pass now.

Looks good, thank you! @bors r+

:pushpin: Commit ec6d846cec3174a602877b53522d7d2ad37749fc has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit ec6d846cec3174a602877b53522d7d2ad37749fc with merge 8ccb82892fa6d2ea6630ae19de419e61cebf7974...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 8ccb82892fa6d2ea6630ae19de419e61cebf7974 to master...


Regularlise coordinate system

Sorry about the very long explanation of a very simple fix.
In material::Evaluate and ::Sample, the light and eye rays are expressed in a coordinate system which is local to the polygon: to a first approximation the normal to the polygon is aligned along z. Where the polygon carries a u or v, u is aligned along x in the local frame, and v is aligned along y. So far, so good.
But if the poly doesn't provide u and v, then Frame calls Vector::CoordinateSystem to invent one. It uses the polygon normal to create an orthogonal basis. But: there are two bases it could make: one where u is located somewhere on the y=0 plane, and another where v is located on x=0. It chooses based on the direction of the normal.
That means, in turn, that inside ::Evaluate and ::Sample, the light and eye rays can appear in one of two frames, with no way to find out which. So long as the material is isotropic, this doesn't matter. But if the material is anisotropic, it matters very much, because the anisotropy "grain" switches across the face of polygon, creating very objectionable seams.
I was working with some highly anisotropic materials, but even with the stock materials you can see it. Create a glossy2 or a metal with uroughness=0.7 and vroughness = 0.1, and render a ball. You can see the streaky reflections quite clearly, but you'll also see the seams around it.
 (Incorrect - note seam to the right side of the ball.  Also note very slight seam on the left wall)
 (Correct: no seams)
This mod selects the frame where u is horizontal in world space, and v points as vertically as possible (no matter the orientation of the poly). Where the poly faces directly upwards, it adopts a standard frame, were v points along z. Inside ::Evaluate and ::Sample the local frame's x will always have z=0 in world space, and y will almost-always have z != 0.
The change should be invisible to isotropic materials, and should improve anisotropic ones.

It looks like this patch is mixed with the other one (https://github.com/LuxCoreRender/LuxCore/pull/519) so it is not usable in its current form.
I assume the "Fixes to glossy2 material" commit shouldn't be there.

That's right.  I noticed I'd checked the glossy2 changes into master (and not into the bracnh I thought I was on).  Do you want me to redo this?

Yes, please, we need separate PR for each feature.

Done

Thanks, merged.

Actually, there was an error in the OpenCL code of this patch. It was breaking volume rendering on GPUs ... bugs work in mysterious ways.

Ah - quite right.  Thanks for picking that one up.


Wrong type analysis when returning function from match or if-else block.

Let's write two function:
fn test1() -> i32 {
    0
}

fn test2() -> i32 {
    1
}

Then try to use it as return-value of match block or if-else block:
let func_ptr = match Some(5) {
    Some(5) => test1,
    _ => test2,
};

or
let func_ptr = if true {
    test1
} else {
    test2
};

RA will tell that the type of func_ptr is fn test2() -> i32, though it is fn test1() -> i32 actually in both of two cases.

We now correctly infer this as fn() -> i32.


Adding the Microsoft.Security NetworkData API

NetworkData is a new feature in Azure Security Center.
Security Center's Network Map displays a visualization of the various network elements such as VNets, Subnets, VM's etc. connectivity and traffic information. The network traffic REST API presents the underlying information upon which the map is constructed, including the allowed connections and actual traffic data for each VM.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

@chlahav , Review will be much appreciated :)

@snhaphil @yanivn3

@ravbhatnagar can someone from API review-board sign-off this?

Hi @DanaPeled  could you pls update to address comments? Or close the PR if you're not ready for reviewing and merging? Pls create new PR when you're ready for reviewing and merging

Hi @yungezz We addressed all issued and waiting to sign off.
Please note that this is private preview feature so we plan just to update ARM manifest.
Merge to master will be done only when we go to public.

@yanivn3 when will you go public?

@yungezz If all goes well, just before Ignite (end of OCT). In order to met deadlines need to have private preview around Mid Sep, which requires us to have the Rest API up and running (behind a feature flag off course).

A few questions for the ARM review. How is this data used? Are clients expected to poll it frequently? What is the refresh interval of the data?

A few questions for the ARM review. How is this data used? Are clients expected to poll it frequently? What is the refresh interval of the data?

Hi @KrisBash ,
he data is used as part of network map feature in Azure Security Center. The feature shows all possible vs allowed connections in Azure in order to recommend what connections can be closed (in security this is called segmentation). The backend process updates the data all the data but for this Rest API we keep it in hourly buckets (there is no importance to actual traffic just for the summary of it - if user wants to see the actual traffic, our UI redirect him to Azure Monitor blade).
Regards clients, The Ibize blade of network map will call the API upon blade initialization and upon refresh - we do not refresh the data regularly since this is not relevant for our scenario.

Closing this PR since another recent PR with similar content opened.


Add support for custom objects

You want to make a PR to Talos
Thanks so much :) First, please take a moment to carefully check through
the below items:
Sanity

[ ] I'm aware of the implications of the proposed changes
[ ] Code is PEP8
[ ] I'm making the PR to master
[ ] I've changed the version in setup.py based on Semantic Versioning

Docs

[ ] Docs are updated
[ ] Docs version is correct on (index.html and _coverpage.md)

Tests

[ ] Changes have gone through actual use testing
[ ] All local tests have passed (run ./test.sh in /talos)
[ ] Tests have been updated to reflect the changes

closes #421 #580

Hello @mikkokotila! Thanks for opening this PR.


[NEW] Swag Opportunity  🎉

Name Of Organization
LoginRadius
Description
At LoginRadius, we're excited to celebrate Hacktoberfest 2021. Contribute to our open-source projects and win cool LoginRadius branded swag to show off!
Swag Items
T-shirt
Link to proof
https://www.loginradius.com/blog/async/hacktoberfest-2021/

Please assign this issue to me to solve

Hi @CoderSaty please go ahead!

@CoderSaty are you still on this?

Sorry @monizb I won't be able to do this I am busy in something else please assign it to someone else.