agma: bugfixes

🔧 Type of changes

[x] bugfix

✨ What's the context?
Thanks @AntoxaAntoxic for the port of our adapter! During testing we found 2 minor bugs in the implementation-

9da4ca89af35efcf07b1e670563425da7b1dc3d4: prevents triggering a POST request when the buffer is empty. original
2271af3b6490ca1613cdbdd04d4cd32054e32730: respect the sitesApp config and allow empty strings as publisherId, when the sitesApp is set. This also allows a publisher to set multiple codes for multiple sites/apps for the same publisherId. original test

Thanks again for the port!

@Compile-Ninja When will be the next release?


Unable to connect dependency-check database

Describe the bug
Unable to connect to NVD database
Version of dependency-check used
The problem occurs using version X.X.X of the 5.3.2 (cli, gradle plugin, maven plugin, etc.)
Log file

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
If I connect to NVD database scan should become success
Additional context
Add any other context about the problem here.

Can you solve the issue as soon as possible?

Now I was getting these exception

You would need to provide the actual log file from ODC as opposed to just a stack trace. If you are using the command line you would just add --log odc.log.  Looking at what you have posted it appears to be a file permission issue.


Content is not set in WebMjmlCompiler

https://github.com/FriendsOfShopware/FroshTemplateMailMjml/blob/79a9fa6ae3adcd2ccb22a54ce2c487ed1fbb68a0/Components/WebMjmlCompiler.php#L62
I think:
$content = $response['html'];

is missing here

🙈


Fix unreleased changelog

What does this PR do?
The unreleased changes in the changelog were added in the wrong section, this PR fixes this.

does it also means we need to backport anything to 1.x branch ?

No, those entries were added after the release.


Update Composer dependencies (2021-05-20-00-07)

Visual regression test passed!
View the visual regression test report


geom_tile remaing square and not stretching when plot size is rectangular

Hi there,
When i have a rectangular canvas (using ggsize(500, 250), see below example code), the geom_tiles remain square.
However, I would like the tiles to stretch widthwise (see second heatmap), which is the behavior found in R's ggplot.
Is there a way to enable this / Will this be a planned feature?
Best regards,
Luan
import numpy as np
import pandas as pd
from lets_plot import *

matrix = pd.DataFrame(np.random.rand(10, 10))
matrix.columns.name = "col"
matrix.index.name = "row"

plot_data = matrix.reset_index().melt('row')

p = (
    ggplot(plot_data, aes(y="row", x="col")) +
    geom_tile(aes(fill="value")) +
    theme_bw() +
    ggsize(500, 250)
)
ggsave(p, "/Users/lnguyen/Desktop/plot.png")

Hi, by default we use coord_fixed for tiles. Try to + coord_cartesian() to override this default.

Thank you, that fixed the issue!


Maven generates an auto installable jar with C libraries embedded.

Only tested on Linux.
When jpy is invoked from the JVM, C libraries are extracted to the
temporal directory and jpy library is initialized.
Therefore there is not need to install JPY by compiling jpy sources.
It is enough to use the generated jar file.

@pabloa nice work! Could you meanwhile test on other platforms? (We urgently need Travis/AppVeyor support.)

Hello,
Loading c libraries from jar file works on MacOS. I do not have a windows box to test though.If it fails (in any operating system), the old mechanism to load binary files is used. Therefore it should not be intrusive.
Regarding to the jar generation with the compiled C modules embebbed, it should work in the 3 OS because maven is instructed to include .so and .dll files. But again, no windows box to test it.
Pablo


Android Gradle 8 namespace required

It's necesary to update namespace for compiling in android. Yoy only need to move it from manifest to build.gradle(app).
android {     namespace 'com.agora.iris_method_channel' }

Fixed https://github.com/AgoraIO-Extensions/iris_method_channel_flutter/pull/82


Sports Superbike 2 Europe (bikehax)

Ported tonyhax to Sports Superbike 2. Using the full bootloader because I don't have HW test and there's enough space.
Big thanks to AcidSnake for the help, he'll also test later on hw.
btw the tonyhax.mcs generated via make tonyhax.mcs doesn't seem valid, had to use one from the release.
EDIT: tonyhax.mcs works fine

Hello! Thanks for the commit. However I think there's been some mistake - GitHub reports that the .mcs file is empty.
Regarding the tonyhax.mcs file, can you send me the generated file to investigate why it's not being properly generated? Is it complaining about the integrity check?

I think it's some github shenanigans because it does show up on my remote git repo.
Regarding the tonyhax.mcs I don't know what happened, tried again and it worked. I was using MemCardRex and giving me "not a valid MCS" type of error.

I'm having issues running the exploit. Which emulator did you use? No$PSX crashes with a "full" error, and the only one that has a built in emulator seems to execute the ASCII string itself (note the illegal opcodes seem to be ASCII characters)

Merged. Tested and working perfectly! I'm gonna tweak it slightly so that both the single race and the championship menus trigger the exploit.


feat: add deploy information to app show subcommand

Fix #538. Added deploy information to app show subcommand.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Manual Test
Example 1:
archer app show
Looks like you are using a workspace that's registered to project my-project.
We'll use that as your project.

? Which application of my-project would you like to show? my-app
Environment         Is Production?      Memory              CPU                 Tasks               Port                Path                URL
-----------         --------------      ------              ---                 -----               ----                ----                ---------------------------------------------------------------
test                false               512                 256                 1                   5000                *                   my-pr-Publi-UX7AU6UI412C-1003834689.us-west-2.elb.amazonaws.com

Example 2:
archer app show --json | jq .
Looks like you are using a workspace that's registered to project my-project.
We'll use that as your project.

? Which application of my-project would you like to show? my-app
{
  "appName": "my-app",
  "type": "Load Balanced Web App",
  "project": "my-project",
  "account": "403971813171",
  "environments": [
    {
      "name": "test",
      "region": "us-west-2",
      "prod": false,
      "url": "my-pr-Publi-UX7AU6UI412C-1003834689.us-west-2.elb.amazonaws.com",
      "path": "*"
    }
  ],
  "service": [
    {
      "port": "5000",
      "tasks": "1",
      "cpu": "256",
      "memory": "512"
    }
  ]
}


Upload type for start run needs to allow multiple files to be uploaded

The upload input type only allow a single file to be uploaded. A number of pipelines need to allow multiple files to be uploaded.  The uploaded list of files should be space delimited.

Merged pull-request addressing this issue.


fix: revert release workflow to working version

Release fails https://github.com/asyncapi/generator/actions/runs/3591963645/jobs/6047212449
We cannot release https://github.com/asyncapi/generator/pull/869
CI got broken because of https://github.com/asyncapi/generator/pull/874 I let that happen, forgot to stop the bot for generator...
Eventually it will not be a problem once I fix https://github.com/asyncapi/.github/issues/172
fix:  because we need to trigger patch for https://github.com/asyncapi/generator/pull/869

/rtm


lock: Tweak timeouts for lock refresh test

What does this PR change? What problem does it solve?
The test which checks that lock refreshing works, for some reason fails from time to time, see e.g. https://github.com/restic/restic/pull/3997#issuecomment-1301336512 .
This PR increases the timeouts to hopefully avoid this issue.

Was the change previously discussed in an issue or on the forum?
Fixes #3990

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

Let's hope this fixes the (far too frequent) test failures.


ISPN-13532 Cache store properties shouldn't be changed

Make sure store properties case is not changed upon read or write

https://issues.redhat.com/browse/ISPN-13532

Rebased

@wburns the changes seem to cause some test failures:
https://ci.infinispan.org/job/Infinispan/job/PR-9695/3/testReport/junit/org.infinispan.configuration/XmlFileParsingTest/testDummyInMemoryStore/
https://ci.infinispan.org/job/Infinispan/job/PR-9695/3/testReport/junit/org.infinispan.configuration/XmlFileParsingTest/testStoreWithNoConfigureBy/
https://ci.infinispan.org/job/Infinispan/job/PR-9695/3/testReport/junit/org.infinispan.persistence.jdbc.configuration/ConfigurationTest/testTableProperties/

Checking failures.

Updated to add in dummy parser so it can update attributes as well as fixed test failures and updated upgrading since the attributes mapping with properties is only going to be in 14.

@wburns is ServerConfigurationSerializerTest.testConfigurationSerialization related?

@wburns is ServerConfigurationSerializerTest.testConfigurationSerialization related?

Checking..

@wburns is ServerConfigurationSerializerTest.testConfigurationSerialization related?

Checking..

No, it is unrelated

Merged, thanks


Redirect fails when using insert option to the 'Redirect Folder' template

Hi Andy,
I discovered an issue when using the Hi.UrlRewrite module.
I discovered that it is caused by the following code
var redirectFolderItems = db.GetItem(RedirectFolderItem.TemplateId).GetReferrers(); in RulesEngine.cs (line 148)
In my environment I added an insert option on my platform node in content to enable content managers to add a redirect folder, and this causes an additional referring item which does not have the field Site Name Restriction
It took me a while (I needed to download and debug your module) to find this. Simply removing the insert option solved my issue, but I think it might be wise that an additional check is being performed on templateName, before returning the redirectFolderItems?
Cheers,
Nico

What version?
On Thu, Nov 10, 2016, 4:46 AM nlubbers<EMAIL_ADDRESS>wrote:

Hi Andy,
I discovered an issue when using the Hi.UrlRewrite module.
I discovered that it is caused by the following code
var redirectFolderItems =
db.GetItem(RedirectFolderItem.TemplateId).GetReferrers(); in
RulesEngine.cs (line 148)
In my environment I added an insert option on my platform node in content
to enable content managers to add a redirect folder, and this causes an
additional referring item which does not have the field Site Name
Restriction
It took me a while (I needed to download and debug your module) to find
this. Simply removing the insert option solved my issue, but I think it
might be wise that an additional check is being performed on templateName,
before returning the redirectFolderItems?
Cheers,
Nico
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iamandycohen/UrlRewrite/issues/26, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAxmf7u243aQGHvvoLm_NxzHXZQ2yo4zks5q8vX9gaJpZM4KuhJQ
.

You shouldn't add the RedirectFolder.... Redirect Folder was meant for organizing redirects.
You should use the Url Rewrite Folder.  This is a top level folder that is meant to choose different sites.

What problem does this cause?  You are right, that it picks up the insert options as a referring item, however, it will have no rules as children and it is basically ignored.  Where is the problem?  Is there a specific exception you are getting?

fixed in release https://github.com/iamandycohen/UrlRewrite/releases/tag/v<IP_ADDRESS>

<IP_ADDRESS>
The one that you merged a few days ago :-)
Nico
Verstuurd vanaf mijn iPhone
Redhotminute
Nico Lubbers
Software Architect
T +31 418 510 068
Graaf Reinaldweg 22-26
NL-4176 LX Tuil
C.o.C. nr. 11051623
Redhotminute
#HJT#HMP#RHMR#
Op 10 nov. 2016 om 12:58 heeft Andy Cohen <notifications<EMAIL_ADDRESS>het volgende geschreven:
What version?
On Thu, Nov 10, 2016, 4:46 AM nlubbers <notifications<EMAIL_ADDRESS>wrote:

Hi Andy,
I discovered an issue when using the Hi.UrlRewrite module.
I discovered that it is caused by the following code
var redirectFolderItems =
db.GetItem(RedirectFolderItem.TemplateId).GetReferrers(); in
RulesEngine.cs (line 148)
In my environment I added an insert option on my platform node in content
to enable content managers to add a redirect folder, and this causes an
additional referring item which does not have the field Site Name
Restriction
It took me a while (I needed to download and debug your module) to find
this. Simply removing the insert option solved my issue, but I think it
might be wise that an additional check is being performed on templateName,
before returning the redirectFolderItems?
Cheers,
Nico

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iamandycohen/UrlRewrite/issues/26, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAxmf7u243aQGHvvoLm_NxzHXZQ2yo4zks5q8vX9gaJpZM4KuhJQ
.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/iamandycohen/UrlRewrite/issues/26#issuecomment-259672427, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABRqDkk97_rUR_73XMZVaxGCXeFmNLkFks5q8wbJgaJpZM4KuhJQ.

Ok.  That version has been fixed.
On Thu, Nov 10, 2016, 9:29 AM nlubbers<EMAIL_ADDRESS>wrote:

<IP_ADDRESS>
The one that you merged a few days ago :-)
Nico
Verstuurd vanaf mijn iPhone
Redhotminute
Nico Lubbers
Software Architect
T +31 418 510 068
Graaf Reinaldweg 22-26
NL-4176 LX Tuil
C.o.C. nr. 11051623
Redhotminute
#HJT#HMP#RHMR#
Op 10 nov. 2016 om 12:58 heeft Andy Cohen<EMAIL_ADDRESS><EMAIL_ADDRESS>het volgende geschreven:
What version?
On Thu, Nov 10, 2016, 4:46 AM nlubbers<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

Hi Andy,
I discovered an issue when using the Hi.UrlRewrite module.
I discovered that it is caused by the following code
var redirectFolderItems =
db.GetItem(RedirectFolderItem.TemplateId).GetReferrers(); in
RulesEngine.cs (line 148)
In my environment I added an insert option on my platform node in content
to enable content managers to add a redirect folder, and this causes an
additional referring item which does not have the field Site Name
Restriction
It took me a while (I needed to download and debug your module) to find
this. Simply removing the insert option solved my issue, but I think it
might be wise that an additional check is being performed on
templateName,
before returning the redirectFolderItems?
Cheers,
Nico

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iamandycohen/UrlRewrite/issues/26, or mute the
thread
<
https://github.com/notifications/unsubscribe-auth/AAxmf7u243aQGHvvoLm_NxzHXZQ2yo4zks5q8vX9gaJpZM4KuhJQ
.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<
https://github.com/iamandycohen/UrlRewrite/issues/26#issuecomment-259672427>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ABRqDkk97_rUR_73XMZVaxGCXeFmNLkFks5q8wbJgaJpZM4KuhJQ

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/iamandycohen/UrlRewrite/issues/26#issuecomment-259719698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAxmf3ZmGxhoLB-5YI59-fM3DlkJmVr_ks5q8zhhgaJpZM4KuhJQ
.


macOS: Use command "ls -al" Issue

OS version and name: MacOS Sierra 10.12.1(16B2555)
Hyper.app version: 1.0.0（<IP_ADDRESS>3）
Link of a Gist with the contents of your .hyper.js: PressMe
Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

Issue
Please see Gif file

type ls -al
sometimes you can see rm.sh, sometimes you can see go.sh. but actually it should show up both.

This is not an ls issue, it's a pane size issue, and likely due to your shell (which is what?).
Notice how when some output is hidden, the last line of stdout was clipped and your prompt ended up on the end.

I think i use the default shell.
this issue is not happened on default terminal (weird)
on hyper.app, i just need quick repeat ls -al command, and i can see lost some file list on the hyper.app.

Hey there, please try again with the new Hyper v2 release and open a new issue if the problem stills exists. Thank you!


Unix Sockets Chapter

Chapter on Unix sockets:

What are they
Why are they useful
How to implement
Things to keep in mind

moved to https://github.com/lawrenceadams/stage-2-curriculum/tree/6-unix-sockets


Importer can not handle some e-values for vertex positions.

Importer can't tolerate low values that are very close to 0, expressed as Euler-values. So for example instead of 0.00001 blender can give 1e-5 if the value is small enough, and some values break, like for example -1.9684875951497816e-10   To reproduce just use this value in any .dae and see how the vertex is going towards infinity.

I think i fixed this bug, this is quite interesting.


Consider other conditions while listing templates with id

Description

Many of the searching conditions are not considered when
template id is passed but they are considered only when
template id is not passed. Move other conditions out of else
part so that they will be considered when id is passed.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

Without changes
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor, id="45be18c7-c0fd-11ea-ba74-067606003392"
{
  "count": 1,
  "template": [
    {
      "hypervisor": "KVM",
      "id": "45be18c7-c0fd-11ea-ba74-067606003392"
    }
  ]
}
(local) mgt01 >
(local) mgt01 >
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor, id="45be18c7-c0fd-11ea-ba74-067606003392" hypervisor=XenServer
{
  "count": 1,
  "template": [
    {
      "hypervisor": "KVM",
      "id": "45be18c7-c0fd-11ea-ba74-067606003392"
    }
  ]
}

With changes
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor id="d9411172-3832-4fc9-a771-39514e0a9faa" hypervisor=KVM
{
  "count": 1,
  "template": [
    {
      "hypervisor": "KVM",
      "id": "d9411172-3832-4fc9-a771-39514e0a9faa"
    }
  ]
}
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor id="d9411172-3832-4fc9-a771-39514e0a9faa" hypervisor=XenServer
(local) mgt01 >

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2341

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3134)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32721 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4452-t3134-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@rhtyd simple fix for API usage quirk, can you review? cc @PaulAngus


Layouts (UX Review 3 feedback)

All:

[ ] title color #eee? should be white 87%

Fixed drawer with header and no header

[x] remove div line at bottom:

[ ] .wsk-layout__drawer .wsk-navigation__link  - add padding at top so it’s 48 pixels from title.

Multi-row layout

[x] remove “Multi-row layout demo” copy?
[x]  Web Starter Kit should be same as Web Starter Kit

Scrollable tabs

[ ] change background to white
[ ] change link underline select state white

Fixed tabs

[ ] remove this one? seems like an app UI

Content tabs

[ ] ensure margin on top of nax text is same as bottom (seems like bottom is more)

[ ] add margin top spacing before first li (48px?)

Layout will be split up into multiple components and reimplemented from scratch.


Test documentation fails

Description
I'm seeing an automated test fail in the documentation (https://github.com/google/jax/actions/runs/3055125249/jobs/4927830518).
The log of the failure is
Run pytest -n 1 --tb=short docs
============================= test session starts ==============================
platform linux -- Python 3.7.[13](https://github.com/google/jax/actions/runs/3055125249/jobs/4927830518#step:8:14), pytest-7.1.3, pluggy-1.0.0
rootdir: /home/runner/work/jax/jax, configfile: pytest.ini
plugins: xdist-2.5.0, forked-1.4.0
gw0 I
gw0 [8]

.F......                                                                 [100%]
=================================== FAILURES ===================================
______________________________ [doctest] faq.rst _______________________________
[gw0] linux -- Python 3.7.13 /opt/hostedtoolcache/Python/3.7.13/x64/bin/python
[24](https://github.com/google/jax/actions/runs/3055125249/jobs/4927830518#step:8:25)4 relevant class attributes, and we've also defined the ``__eq__`` method because it's
245 good practice to do so any time you override ``__hash__`` (see
246 `Python Data Model: __hash__ <https://docs.python.org/3/reference/datamodel.html#object.__hash__>`_
247 for more information on this). With this addition, the example works correctly::
248
249     >>> c = CustomClass(2, True)
[25](https://github.com/google/jax/actions/runs/3055125249/jobs/4927830518#step:8:26)0     >>> print(c.calc(3))
251     6
252     >>> c.mul = False
253     >>> print(c.calc(3))
Expected:
    3
Got:
    6

/home/runner/work/jax/jax/docs/faq.rst:253: DocTestFailure
=========================== short test summary info ============================
FAILED docs/faq.rst::faq.rst
========================= 1 failed, 7 passed in 2.10s ==========================
Error: Process completed with exit code 1.

What jax/jaxlib version are you using?
No response
Which accelerator(s) are you using?
No response
Additional System Info
No response

Thanks - echoing our conversation from elsewhere: this is a failure we've seen periodically before; it's a strange one that is hard to produce. It almost looks like there's some sort of race condition within doctest which causes out-of-order execution, but I can't imagine a mechanism that would produce that and not also show up elsewhere...

OK, I was able to reproduce it... it has something to do with jit cacheing:
from functools import partial
from jax import jit

class CustomClass:
  def __init__(self, x: int, mul: bool):
    self.x = x
    self.mul = mul

  @partial(jit, static_argnums=0)
  def calc(self, y):
    if self.mul:
      return self.x * y
    return y

  def __hash__(self):
    return hash((self.x, self.mul))

  def __eq__(self, other):
    return (isinstance(other, CustomClass) and
            (self.x, self.mul) == (other.x, other.mul))

for i in range(1000):
  c = CustomClass(2, True)
  assert c.calc(3) == 6
  c.mul = False
  assert c.calc(3) == 3, f"failed on iteration {i}"

Output:
Traceback (most recent call last):
  File "tmp.py", line 26, in <module>
    assert c.calc(3) == 3, f"failed on iteration {i}"
AssertionError: failed on iteration 27


Text box is too small in chat settings

The text box is too small in the chat settings.

Dan not 100% sure, but I made an issue that seems similar yours: https://github.com/Chainlit/chainlit/issues/507
I'm hoping a proper textarea comes to chainlit.

Hey there!, we were looking for the same fix with my coworker and found out there's a multiline argument that you give to the text input class.
Hope this helps somebody


Add build scripts for gpuCI

Adds the axis and build files to get gpuCI running on this repo; we should probably merge #1 first to make sure the tests added are passing

rerun tests


Private Server

We have a private, self hosted Hipchat-Server.
Please add a Parameter to set the base URL like
notify:
  hipchat:
    host: hipchat.company.com
    secured: true #default (SSL)
    auth_token: xxxxxxxxxx
    room_id_or_name: 42
    notify: false

the call is then: https://hipchat.company.com/v2/room/42/...

thanks @tboerger :+1:


Error on train 0 model

Hello,
I am trying to use the tool. I run "Make patches", but the next step fails with
ERROR: train_autoencoder (job 18) failed.

I have build with docker container.
Any help is appreciated.
Best Regards,
Omar

Hi @OmarAshkar, could you provide more information about your run environments such as the version of OS, python, and docker? what GPUs do you use?  It will help us to narrow down the issues. Thank you.


Quick open search bar overlay

[ ] Decide on a keyboard shortcut to use to evoke a quick open search bar.

Xcode: Cmd+Shift+O
VS Code, Atom, Sublime Text: Cmd+Opt+P

[ ] Build search bar similar to Apple Spotlight or Xcode quick open
[ ] Build file list of search results
[ ] Keyboard navigation to navigate list and select option, or escape

I like cmd + Shift + O more

Let's do it then since we are trying to steer closer to Xcode rather than VS Code. We can always develop an extension that provides VS Code key bindings.

Potentially relevant WWDC about creating child windows and sending events between windows.
https://developer.apple.com/devcenter/download.action?path=/videos/wwdc_2010__hd/session_145__key_event_handling_in_cocoa_applications.mov

I'll try to implement it

I've reopened this issue because keyboard navigation works for the list, but some changes should be done. Because at the moment I haven't figured out how to implement great keyboard navigation to switch between list and search field and open files (not just switch in the panel's NavigationView).

Padding, spacing, font-sizes and dimensions are slightly off, please refer to the figma concept for exact specifications.

Also, the bottom half of the overlay should be hidden if there is no characters in the input.

@austincondiff Maybe it would be better to close this issue and create new one for "The vertical separator in Open Quickly should be the same color as the horizontal separator"?


React 0.15.x support ?

Hi,
Your component seems great.Good work !
Does it support React 0.15 ?

I haven't tested, but it should.

I'm trying this now and one issue is peerDependencies in package.json:
"peerDependencies": {
"react": "^0.14.0"
},

ah, you might be able to just upgrade NPM and get away with ignoring it for
now, but I'll see if I can't get a proper test/update to 0.15 done this
week. PRs welcome!

Was anybody able to test if the component works well with 0.15.x?

Implemented this in my<EMAIL_ADDRESS>project but it doesn't appear to be working. Unsure if it's due to my unfamiliarity with this module, though:

warning.js:36 Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of QuizView.
invariant.js:38 Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. Check the render method of QuizView.

QuizView is the page-level component.
var sampleItems = [
  {key: 1, name: 'Test', sort: 0, filtered: 0},
  {key: 2, name: 'Test 1', sort: 1, filtered: 0}
];

<AbsoluteGrid items={sampleItems} displayObject={(<AbsoluteGridView />)} />

AbsoluteGridView was taken from the sample displayObject class (I've tried with and without props):
var React = window.React = require("react");

var AbsoluteGridView = React.createClass({
  getInitialState:function() {
    return {  };
  },

  componentDidMount:function() {
  },

  render:function() {
    const { item, index, itemsLength } = this.props;
    return
Item { index } of { itemsLength }: { item.name }
;
  }
});

module.exports = AbsoluteGridView;

@Gorb @el1f  @nethermead
I just pushed a new branch #35 of the component that supports 15.3.x and up but it's using PureComponent now so you must pass it immutable data.

version 3.0.0 is officially released to NPM and it works a little differently, but works great with 15.3 and up.


audit: extend cloudflare https audit exception regex

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Change extends the regex that ignores 503 errors when https audits hit Cloudflare protections.
Solves some specific instances re: #12185
Also related: https://github.com/Homebrew/homebrew-cask/pull/112093#issuecomment-939335907

Thanks @bevanjkay!


handle error when registered handler is undefined

Codecov Report

Merging #190 into develop will decrease coverage by 0.03%.
The diff coverage is 93.75%.

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
- Coverage    96.77%   96.73%   -0.04%
===========================================
  Files           49       49
  Lines         1614     1625      +11
===========================================
+ Hits          1562     1572      +10
- Misses          52       53       +1

Impacted Files
Coverage Δ

src/platforms/mp/runtime/instance/events.js
98.11% <93.75%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9b223...0893066. Read the comment docs.


Dashpages with no available metrics should not be shown in the navigation tree

The list of available dashpages in the Metrics UI is dynamic, depending on the selected resource.
A dashpage will only be shown if:

metrics are available for at least one chart, and
metrics are available for all "required" charts.

This was addressed in #5337.


[Build] Check C++ ABI and exception issues with Clang/GCC on Cygwin

Fixes  #167

Check whether compiler supports and successfully compiles with exceptions.
Check whether the provided stdlib has C++14 type traits fully implemented.
Perform some compiler version checks in cmake and give hints to the user.

Both errors occured on Cygwin using Clang 3.5.2 with libstdc++ from GCC
4.9.3. However, Clang may also use the GCC stdlib on other systems, like
Linux Mint.
The error with exceptions is also expected to occure on MSYS2 and maybe
Windows, since Clang seems to have general problems there.
Unfortunately, the incomplete stdlib is supposedly not detectable from within
the compilation. Thus a test is created which may fail during compilation.
If so, an additional symbol is defined to handle the issue:
BOOST_HANA_CXX_INCOMPLETE_STDLIB
Availability of exceptions is tested with the existance of __EXCEPTIONS, and
handled accordingly. Instead of throw, a assert(false) or abort() comes to mind.
Lastly, the cmake cygwin warning message is deactivated in CMakeLists.txt,
and the main include <boost/hana/hana.hpp> checks the C++ standard to be
at least C++14 or raises an error otherwise. Should give beginners a valuable
hint on what is going wrong...
A side note for other Cygwin/MinGW/MSYS2 users: Compile with Clang or
GCC with static binding of (both) standard libs using
-static-libgcc -static-libstdc++
Makes your life a lot easier.
Remaining issues are some non-compiling tests and examples. These have been
removed from the build on Cygwin. The reason may also be the incomplete stlib.
See test/CMakeLists.txt and example/CMakeLists.txt
Tested on

Cygwin/Clang 3.5.2/libstdc++ of gcc 4.9.3 w/o exceptions (success)
Cygwin/Clang 3.5.2/libstdc++ of gcc 4.9.3 w/ exceptions (failure, but captured)
Cygwin/GCC 4.9.3/libstdc++ of gcc 4.9.3 (failure, as expected)
Linux Mint/Clang 3.6.0/libstdc++ of gcc 4.8.4 (failure, as expected)
Linux Mint/Clang 3.6.0/libc++ of clang 3.6.0 w/ exceptions (success)
Linux Mint/gcc 4.8.4/libstdc++ of gcc 4.8.4 (uncaptured failure, as expected)

Concerning the build failure: I broke the develop branch, and you (correctly) based your pull request on that broken commit. Can you rebase your branch on top of the latest develop so the tests pass? Sorry about that, it wasn't my best shot. It's late now; I'll have a look at the PR tomorrow and will leave some comments, but it looks good so far.

I think I successfully rebased the pull request and added a contribution line. Sorry for the multiple commits, I'll squash it after your final code review. Good looking doesn't mean good behaving...

After looking at this PR quite extensively, here are my thoughts. There are actually three things we're trying to achieve here:

Add more user-friendly diagnostics for supported compilers during the CMake generation step. This is a great idea, and I like your take on it to have a separate file deal with it. One thing that worries me, however, is that some of these checks are already done in boost/hana/config.hpp. I'm slightly worried about duplicating these checks such that they eventually get out of sync. Do you think it is not sufficient to have these checks in hana/config.hpp?
Add support for incomplete C++14 standard libraries. I'm not sure about this one. Hana has a very strict policy regarding compiler/stdlib requirements, as documented in the README. I am chilly at the idea of maintaining workarounds for non-C++14 stuff. It simply isn't worth it, since there are literally hundreds of workarounds we could do for specific platforms just to have to library's tests compile, but each of these workarounds makes our life more difficult in the long term (especially since they can't all be tested all of the time). Instead, my preferred approach would be to have Cygwin users install a C++14 library (e.g. update their libstdc++ or install libc++, as documented in the README). Is this too difficult/impossible on Cygwin, or is this a reasonable requirement?
Ensure the examples and unit tests build without support for exceptions, and at the same time test that the library itself does not use exceptions internally. This is a superb idea, and it is quite important because some potential clients of the library might not allow exceptions in their code. Also, as a metaprogramming library, it seems natural that exceptions should not be used in the implementation, and hence having a test configuration without exceptions seems desirable.

Before modifying this PR further, let's resolve this and decide what we want/do not want.

Actually, regarding support for building without exceptions, I even wonder whether that shouldn't be the default? Clearly, we don't want to rely on exceptions anywhere in Hana, so it seems like it would be more stringent to put -fno-exceptions whenever the flag is supported.

Checks should be performed depending on the systems default, whether with of without exceptions. In the end, it is a library to be embedded in another application. Though, limiting hana itself to not rely on exceptions appears plausible.

@ldionne, although already closed, here my quick confirmation: Hana compiles well and succeeds with the tests as long as mentioned type traits and to_string are not required.
When including <boost/hana.hpp> and compiling some small dummy code, one receives the warning of C++14 not being provided. Luckily, this also is issued for gcc < 5.0 since then the __cplusplus equals 201300. Only clang pretends to fully comply with C++14 even when linking against libstdc++ < 5.0.
So, looks as expected, looks good. Thanks !

Here the summary of the test build:
$ cmake -DCMAKE_CXX_COMPILER=clang++ ..
$ make -i check after cmake

resulted in
99% tests passed, 13 tests failed out of 908
Total Test time (real) =  19.36 sec
The following tests FAILED:
          9 - example.any_of (Not Run)
         10 - example.ap (Not Run)
         57 - example.eval_if (Not Run)
        170 - example.overview (Not Run)
        215 - example.sequence.monad.types (Not Run)
        272 - example.tutorial.introspection.json (Not Run)
        274 - example.tutorial.quickstart (Not Run)
        277 - example.type.basic_type (Not Run)
        280 - example.type.integral (Not Run)
        295 - example.wandbox (Not Run)
        377 - test.header.boost.hana.ext.std.type_traits.hpp (Not Run)
        380 - test.header.boost.hana.ext.std.hpp (Not Run)
        776 - test.ext.std.type_traits (Not Run)
Errors while running CTest
[100%] Built target check

I checked all the failing tests/examples and I can understand why they would fail. However, I'm slightly surprised about example.type.basic_type. Is it because the <cxxabi.h> header is missing? I don't think this header is portable.
Also note that example.any_of and example.type.integral included <boost/hana/ext/std/type_traits.hpp>, without requiring it strictly speaking. I changed that and they should pass now.

The current status with the reason of non-compilation / missing symbol is as follows, your conclusions are correct, the last one is new however:
The following tests FAILED:
         10 - example.ap (Not Run)    =>    ap.cpp:20:9: error: static_assert expression is not an integral constant expression
         55 - example.eval_if (Not Run)    =>    std::is_trivially_copyable
        168 - example.overview (Not Run)    =>    std::is_trivially_copyable
        213 - example.sequence.monad.types (Not Run)    =>    std::is_trivially_copyable
        270 - example.tutorial.introspection.json (Not Run)    =>    std::to_string
        272 - example.tutorial.quickstart (Not Run)    =>    std::is_trivially_copyable
        275 - example.type.basic_type (Not Run)    =>     error: no member named 'free' in namespace 'std';  abi::__cxa_demangle(mangled, 0, 0, &status), std::free
        293 - example.wandbox (Not Run)    =>    std::to_string
        374 - test.header.boost.hana.ext.std.type_traits.hpp (Not Run)   =>   std::is_trivially_copyable
        377 - test.header.boost.hana.ext.std.hpp (Not Run)   =>   std::is_trivially_copyable
        750 - test.ext.std.type_traits (Not Run)   =>   std::is_trivially_copyable
        821 - test.pair.cnstr.copy (Not Run)    =>    std::is_trivially_copy_constructible
Errors while running CTest
[100%] Built target check

Anyway, I think it's fine, the important basic stuff is operational.

Ok, example.type.basic_type should be fixed for now, although it will have to be modified if we ever support MSVC (one can dream). Regarding test.pair.cnstr.copy, I just checked and it's also an expected failure (but the test was added just yesterday). Thanks a lot!


Implement glTF extension KHR_materials_clearcoat

Description
This PR implements the glTF extension KHR_materials_clearcoat in physically-based rendering of models.
How it works (and how it affects the code)
Parsing the extension at load time
When the glTF is loaded, GltfLoader reads factors and loads textures from the extension. See the new loadClearcoat method, which is very similar to the loadSpecular method from https://github.com/CesiumGS/cesium/pull/11970. The factors and textures are then attached to the material. See the updates to the Material class in ModelComponents.
Processing the extension properties in the pipeline
In MaterialPipelineStage, if material.clearcoat is defined, its properties are processed by the new method processClearcoatUniforms, which is very similar to processSpecularUniforms.
The clearcoat extension, if used, will extend the metallic roughness model. As a result, the check for the extension usually takes place inside the same code branch that handles metallic-roughness processing.
Using the extension in the shader
In MaterialStageFS, the clearcoat "factor" and roughness are retrieved from uniforms and/or textures. See the new setClearcoat function. The clearcoat surface normal defaults to the geometry normal, ignoring the normal map from the underlying surface. This makes the clearcoat smooth by default. If a user provides a normal map for the clearcoat itself, this is loaded in the new method getClearcoatNormalFromTexture. See also the changes to the czm_modelMaterial struct.
The clearcoat is rendered as a layer on top of the base layer. The clearcoat layer modifies the reflection from the base layer below due to transmission losses. It also adds its own specular reflection. See the rewritten computePbrLighting function in LightingStageFS, as well as the new addClearcoatReflection function in the same file.
Since the reflection from the clearcoat layer itself is specular only, the functions for direct and image-based lighting (in pbrLighting.glsl and ImageBasedLightingStageFS.glsl had to be significantly refactored to separate the diffuse and specular components. This refactoring makes for a messy code diff, but the end result is unchanged for materials without a clearcoat.
Other changes

Added docstrings throughout
Renamed some variables for clarity (v becomes viewDirection, l becomes lightDirection, etc).
Added glsl helper function czm_maximumComponent to find the largest component of a vector (this is used several times in PBR calculations).
Removed the struct czm_pbrParameters, since all information was simply copied from the czm_modelMaterial. Relevant functions now input the material directly. Constructor methods czm_defaultPbrMaterial, czm_pbrMetallicRoughnessMaterial and czm_pbrSpecularGlossinessMaterial were also removed.
A constant coordinate transform yUpToZUp for IBL texture lookups is now applied on the CPU, rather than constructing and applying it in the fragment shader.
Updated promise handling in MaterialPipelineStageSpec to use async/await.
Fixed bug in specular calculation for environment map IBL. See https://github.com/CesiumGS/cesium/issues/12008.

Issue number and link
Resolves https://github.com/CesiumGS/cesium/issues/11995. Resolves https://github.com/CesiumGS/cesium/issues/12008.
Testing plan
Load the development Sandcastle glTF PBR Clearcoat and toggle through the testing models, comparing to the rendering in the reference implementation.
Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[x] I have update the inline documentation, and included code examples where relevant
[x] I have performed a self-review of my code

@jjhembd The check-cla failure is unrelated. I'll open a separate PR to fix.

Fix over in https://github.com/CesiumGS/cesium/pull/12007

Thanks @ggetz for the quick feedback!
I tried to clarify what we are doing in pbrLighting to avoid divide-by-zero errors. I also opened https://github.com/CesiumGS/cesium/issues/12010 to discuss remaining questions about our geometric shadowing function.
I will open a follow-up PR to consolidate the new PBR Sandcastles.

Thanks @jjhembd! Thanks for explaining and writing up the additional issue.
When running locally, I'm seeing quite a few failing tests due to the error RuntimeError: Fragment shader failed to compile.  Compile log: ERROR: 0:786: 'iblColor' : undeclared identifier. Can you please take a look?

When running locally, I'm seeing quite a few failing tests due to the error RuntimeError: Fragment shader failed to compile. Compile log: ERROR: 0:786: 'iblColor' : undeclared identifier. Can you please take a look?

@ggetz sorry I missed that! I fixed both this and another shader compile error. All tests now run through locally for me.

All good! Thanks @jjhembd. This all looks good to me.


Remove unused Swift URL code

Removes old, unused Swift URL code so that only the new Swift implementation is left.

@swift-ci please test


Support for hack formats R16 & AL16

AC Revelation appears to need those. #154
Wine claims that Windows driver don't support those formats but the comment that says that was written 8 years ago. Either way, this should at least silence the warnings and its rather trivial.

Surely the swizzle for AL16 should be
        { VK_COMPONENT_SWIZZLE_R, VK_COMPONENT_SWIZZLE_R, VK_COMPONENT_SWIZZLE_R, VK_COMPONENT_SWIZZLE_G }};
and R16:
        { VK_COMPONENT_SWIZZLE_R,   VK_COMPONENT_SWIZZLE_ONE, VK_COMPONENT_SWIZZLE_ONE, VK_COMPONENT_SWIZZLE_ONE }};

Also... You're using UINT formats and not UNORMs. This too is incorrect.

Changed it.

So, should I rebase this?


Cool Arrow effects and Randomized menu song

What feature do you want to get added on the base engine?
Cool Arrow effects and Randomized menu song
Like Arrows moving or rotating and the Randomized menu song its like if you start again the game or beating a song the menu song will be different
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

You can already mess with strums

this idea is worthless


docs: add guide to integrate with 3rd party UI libraries

docs for integrating vuetify / bootstrap / element or just one of them
how to handle libraries that reference browser features

That'd be really helpful. Especially vuetify

Would appreciate some help 🙂

It seems the project was started with a very opiniated vision on the usage of "storybook generated components". I guess adding/replacing with other libs like vuetify (I had in mind here vuesax :) but it is the same question ) is not that trivila as thios mean completely cleaning the "src/shared/components" folder of its content in the boilerplate, am I right?

@glederer you shouldn't care about deleting stuff. If you do not reference any shared-components they will not be bundled. And if you need one of them for some reason you just reference it again.
One reason it is not built with UI libraries is mentioned in the introduction: https://vue-starter.herokuapp.com/docs/introduction.html#this-is-not-just-another-starter-project
TL;DR: I didn't find any UI lib that really fits our way of working.
I'll start writing the guide and reference the PR here, would be good if some of you could proofread it before I merge it.

@Heimathandel @glederer see #225

Hello,
I tested this locally on a fresh git clone, I did all steps as described in this page  except the "clean up" part, assuming that we change the main app.vue componenent so I guess this should work.
I still get this error when trying to run locally :

npm run dev

End of build says :
ERROR in ./src/app/app/App/App.vue?vue&type=style&index=0&lang=css& (./node_modules/vue-loader/lib??vue-loader-options!./src/app/app/App/App.vue?vue&type=style&index=0&lang=css&) 233:0 [1] Module parse failed: Unexpected character '@' (233:0) [1] You may need an appropriate loader to handle this file type. [1] | [1] | [1] > @import url('https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons'); [1] | @import "../../../../node_modules/vuetify/dist/vuetify.css"; [1] | [1]  @ ./src/app/app/App/App.vue?vue&type=style&index=0&lang=css& 1:0-132 1:148-151 1:153-282 1:153-282 [1]  @ ./src/app/app/App/App.vue [1]  @ ./src/app/app.ts [1]  @ ./src/client/index.ts [1]  @ multi webpack-hot-middleware/client ./src/client/index [1] Child html-webpack-plugin for "index.html": [1]          Asset      Size  Chunks  Chunk Names [1]     index.html  1.41 MiB       0 [1]     Entrypoint undefined = index.html [1]     [./node_modules/html-webpack-plugin/lib/loader.js!./src/index.template.html] 1.79 KiB {0} [built] [1]     [./node_modules/lodash/lodash.js] 527 KiB {0} [built] [1]     [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 509 bytes {0} [built] [1]     [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 519 bytes {0} [built] [1] i ｢wdm｣: Failed to compile. [1] debug: null
Am I am missing something? or is there some typo in the webpack config adaptations?

it seems that the css-loader doesn't work. can you provide some code?

I forgot a snippet, sorry
webpack.base.config.js:
...
      {
        test:   /\.css$/,
        loader: ['vue-style-loader', 'css-loader'],
      },
...

many thanks @devCrossNet, it does work now.


Add execution order test

This test currently has a different execution order in my adapter, so let's document the expected execution order.

@SimonFrings Done. 👍

@kelunik thanks for the update 👍
The test itself in its functionality and the overall design looks great. I talked with @clue about this and it looks like your testcase is already covered by other tests and didn't raise the overall code coverage.
I would argue that it wouldn't make sense to add a test just to show a specific example of what is possible.


postgresql expects integer for lock_timeout

Tested this live and with this patch, it works.

Tests passed, but getting some errors related to Coveralls
Trying submitting coverage with service_name: github...
cd .
Failed submitting coverage with service_name: github
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 259, in submit_report
    response.raise_for_status()
  File "/usr/local/lib/python3.9/site-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 405 Client Error: Not Allowed for url: https://coveralls.io/api/v1/jobs

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/src/entrypoint.py", line 82, in run_coveralls
    result = coveralls.wear()
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 226, in wear
    return self.submit_report(json_string)
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 262, in submit_report
    raise CoverallsException(
coveralls.exception.CoverallsException: Could not submit coverage: 405 Client Error: Not Allowed for url: https://coveralls.io/api/v1/jobs
cd /github/workspace
Trying submitting coverage with service_name: github-actions...
cd .
Failed submitting coverage with service_name: github-actions
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 259, in submit_report
    response.raise_for_status()
  File "/usr/local/lib/python3.9/site-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 405 Client Error: Not Allowed for url: https://coveralls.io/api/v1/jobs

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/src/entrypoint.py", line 82, in run_coveralls
    result = coveralls.wear()
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 226, in wear
    return self.submit_report(json_string)
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 262, in submit_report
    raise CoverallsException(
coveralls.exception.CoverallsException: Could not submit coverage: 405 Client Error: Not Allowed for url: https://coveralls.io/api/v1/jobs
cd /github/workspace
Failed to submit coverage
ExitCode.FAILURE

I was going to ask you to check this one too, but didn't want to trouble you. So thank you very much for taking the initiative!
Yes, coveralls's API has been a bit less than completely reliable in recent times. Re-running all the jobs normally helps...

Maybe I didn't look properly, but it seems i don't have permission to re-run the tests.

I reran them twice and got the same error twice, which is unusual. I think we are using the latest version of their tool so I don't know what else to do. Somebody keeps breaking their API and I don't understand it. It used to always just work. Maybe it will work tomorrow?

If you click through to the "details" there is a button top right.

Still not working today 😬

That's probably only visible to repo maintainers.

The same problem is for idle_in_transaction_session_timeout in the same class

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2277

Relevant Lines:
2277

💛  - Coveralls

Looks like coveralls fixed their stuff 👍


Error login

Discussed in https://github.com/adw0rd/instagrapi/discussions/96

Originally posted by NicolasSDuoc January 29, 2021
Hi, I'm trying to log in but i get this error:
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/accounts/login/
The account doesn't have 2 factor auth. im using this code to test:
from instagrapi import Client
from instagrapi.types import Location, StoryMention, StoryLocation, StoryLink, StoryHashtag

cl = Client()
cl.login('username', 'password')

media_path = cl.video_download(
    cl.media_pk_from_url('https://www.instagram.com/p/CGgDsi7JQdS/')
)

adw0rd = cl.user_info_by_username('adw0rd')
loc = cl.location_complete(Location(name='Test', lat=42.0, lng=42.0))
ht = cl.hashtag_info('dhbastards')

cl.video_upload_to_story(
    media_path,
    "Credits @adw0rd",
    mentions=[StoryMention(user=adw0rd, x=0.49892962, y=0.703125, width=0.8333333333333334, height=0.125)],
    locations=[StoryLocation(location=loc, x=0.33, y=0.22, width=0.4, height=0.7)],
    links=[StoryLink(webUri='https://github.com/adw0rd/instagrapi')],
    hashtags=[StoryHashtag(hashtag=ht, x=0.23, y=0.32, width=0.5, height=0.22)],
)

same here


Notification settings are not getting saved

Hi!
I was trying to apply different settings in Acrarium and found that if I open some App, go to Admin panel and check/uncheck something in Notifications panel, the value is not getting saved. When I reopen / reload the page, all the settings are unchecked.

Saw a related change in the latest change log :)

Saw a related change in the latest change log :)

Yeah, duplicate of #124


Spore uses DBPF version 3, not version 2

The documentation on DBPFs states that Spore uses version 2.
However, looking into Spore's packages with HxD, the version number instead appears to be 3.
This might've been changed after release (possibly in the March 2017 Patch), as the standalone Spore Creature Creator Demo still uses verison 2, but a fully updated copy of Spore certainly uses version 3 instead.
Sporemodder FX also creates packages with a version number of 3, too.
Darkspore used version 3 as well, though that game can no longer be played anymore due to its servers shutting down.

Good to know. I'll take a look at those when I get the chance

Ok, I've updated the docs, but I'm going to leave this open for now for me to revisit, as I have no documentation on DBPF v3 yet. I'll definitely want to look over SporeModder-FX's source code to see how it parses v3 differently.

Here's the change (not published yet): https://github.com/anonhostpi/DBPF.js/blob/main/docs/spec/DBPF.md#known-versions

(for me) see: https://github.com/Spore-Community/SporeTools/issues/1#issuecomment-2344660482


toolchain/zephyr: CMAKE_ARCHIVE* -D for deterministic .a

Unlike the previous and reverted attempt that redefined
CMAKE__CREATE_STATIC_LIBRARY<PHONE_NUMBER>f8, PR #17549), this one doesn't break incremental
builds.
Warning from: https://gitlab.kitware.com/cmake/cmake/issues/19474
The rule variables are actually pseudo-public as described here:
projects can set them but are responsible for keeping up with
changes to CMake.  The main variable(s) documentation could use
updates for this.

Quoting GNU man page:
'D'
Operate in deterministic mode.  When adding files and the archive
index use zero for UIDs, GIDs, timestamps, and use consistent file
modes for all files.  When this option is used, if ar is used with
identical options and identical input files, multiple runs will
create identical output files regardless of the input files' owners,
groups, file modes, or modification times.

If 'binutils' was configured with '--enable-deterministic-archives',
then this mode is on by default. It can be disabled with the 'U'
modifier, below.

Signed-off-by: Marc Herbert<EMAIL_ADDRESS>

stale for almost a year...


Is there a way to send batch client in python?

Seems that resend can send batch emails. Is this implemented in Python?

Seems that resend can send batch emails. Is this implemented in Python?

hey @argenisleo, this feature is currently wip and should be available on the python sdk soon.


being in evac brig should not count as unrestrained

Description
it means sec keeps prisoners cuffed just so no green, they should just fail if theyre in the brig on evac
implementation uhhh ss13 zones or something

everyone who is not in the shuttle brig is tator

🤓

everyone who is not in cuffs is tator

:trollface:

perhaps an alternative is you have to not be cuffed for past 5 or 10 minutes, similar to implementation of le impersonate objective, so you can be put in shuttle brig


Conditional types bug with scenario involving mapped types

TypeScript Version:  2.9.2
Found two bugs while creating some  conditional types using mapped types
Scenario 1
Code
Scenario 1
type Obj = {
  a: string;
  b: number;
};

type Obj2 = {
  c: boolean;
  d: number;
}

type Keys = keyof Obj | keyof Obj2;

function func<T extends Keys>(p: T extends keyof Obj ? Obj[T] : Obj2[T]);

Expected behavior:
function declaration is allowed
Actual behavior:
function declaration errors, saying that T cannot be used to index Obj2, even if it should be allowed.
There's a workaround for this by declaring the function like this:
function func<T extends Keys>(p: T extends keyof Obj ? Obj[T] : T extends keyof Obj2 ? Obj2[T] : never);
However this workaround causes the bug of scenario 2.
Scenario 2
Code
type TestType = "a" | "b";
type Obj = {
  a: string;
  b: number;
};

function func<T extends TestType>(value: T extends TestType ? Obj[T]: never) { };

function func2<T extends TestType>(value: T extends "a" ? string : number) { };

interface Prop1 {
  update<T extends TestType>(value: T extends "a" ? string : number) : void;
}

const x: Prop1 = { update: func }; //doesn't work
const y: Prop1 = { update: func2 }; //works

Actual behavior:
the line were x is declared is giving an error that func is not assignable to the update function of Prop1, even if it should.
Expected behavior:
x should be allowed to be defined.
I know that the type of func is a bit stupid (the conditional type is not necessary here), but in my use case  a similar type comes from the problem in scenario 1, forcing me to type it that way.
The problem is in the ": never" part of the conditional type, as another conditional type that doesn't have that :never part seems to work.

Generic types do not behave any differently if they are constrained to unit types. in general the compiler can not make assumptions about the generic type possible values being limited to one set or another in the presence of intersection types.
For the first example, func can be declared as:
declare function func<T extends Keys>(p: (Obj & Obj2)[T]): void;

For the second example, comparing conditional types really assumes they have to be identical. We are looking into updating some of these relationships, but so far we can not conclusively prove or disprove additional higher order relationships, see https://github.com/Microsoft/TypeScript/issues/24940 for related discussions.

Thank you for your answer. I understand that both scenarios are quite complicated and I expected it to be a current design limitation, but you guys have been made so many great advancements in what the compiler can actually do that I hope that sooner or later something similar will be possible


Endpoint /users/search: count parameter returns off-by-one set of results

Core points:

the count parameter for /users/search endpoint returns an additional / off-by-one set of results
any endpoint that uses SEARCH_ACCEPT_PARAMETERS might also have the same issue
note: issue is not with the Python API but with the actual REST endpoint (checked w/ browser)
note: does not happen if search query is insta; correct number of results returned (e.g. count=3)

Example Code:
# add standard InstagramAPI boilerplate here...
userlist = api.user_search(q="cat", count=1)
for user in userlist:
    print user

Actual Output:
User: catsofworld
User: cats_of_instagram

Expected Output:
User: catsofworld

Update: this still happens with the latest API changes.


Update integration test empty state based on new design

Fixes

https://issues.redhat.com/browse/HAC-3423

Description

Update the empty state description of integration tests based on new design recommendation.

Type of change

[x] Bugfix

Screen shots / Gifs for design review

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm

/retest


RisingWave: Selecting array of structs returns error

Description
The following query
select array[(1,2)]::struct<a integer, b integer>[] as measurements;

returns Cannot invoke "String.hashCode()" because "typeName" is null in DBeaver SQL console
DBeaver Version
Community Edition Version <IP_ADDRESS>410201725
Operating System
MacOS Sonoma 14.7 (23H124)
Database and driver

Database name and version: PostgreSQL 13.14.0-RisingWave-2.0.2 (3d308998c7e426049938e86d79aa575c93e88ac2)
Driver name and version: postgres-risingwave-jdbc (postgresql-42.7.2)

Steps to reproduce

Connect to a RisingWave database
Execute the following query in a SQL consoleselect array[(1,2)]::struct<a integer, b integer>[] as measurements;

Additional context
The same query works fine using psql

Thanks for the bug report. I reproduced the issue

This is a database-side issue.


Display fzf when provided with an invalid context

When provided with an invalid (non-existant) context kubectx currently just errors out.
This PR allows providing a substring instead of the whole context name, if there's only one match, it uses that.
Example:
Given the contexts ["production", "staging", "development", "development-load"]
Before:
kubectx pro
error: no context exists with the name: "pro"

After:
kubectx pro
error: no context exists with the name: "pro"
Switched to context "production"

Before
kubectx dev
error: no context exists with the name: "dev"

After:
kubectx dev
error: no context exists with the name: "dev"
# <opens fzf with --query dev which displays "development" and "development-load">

I'd love to have this feature, it's very convenient to use partial identifiers


Add notes for CUDA 12.2 on Windows support

https://github.com/cupy/cupy/pull/7758#issuecomment-1665202197

@emcastillo Failed to backport automatically.

Not cleanly cherry-picked


Page visibility util

Hi, sorry I know I've been spamming this repo a bit lately, but I've got just one more util if you're open to it. I'd like to add a util to detect if the window is active / minimized. This can be useful for things like auto-pausing media, updating the document title, etc...
// hidden and visibility would be reactive aliases of
// document.hidden and document.visibilityState

const { hidden, visibility } = usePageVisibility({
  onChange() {
    // ...
  },
  onHide() {
    // ...
  },
  onShow() {
    // ...
  }
});

Contributions are always welcome! Thanks for great work.
Your proposal is definitely good to have, however, I think the callback functions are kinda unnecessary. Users can simply use watch to do the job and I think it is most of the functions in this lib are for.
const visibility = usePageVisibility()

watch(visibility, () => { /*...*/ })

This may be a reference for your implementation: https://github.com/kripod/react-hooks/tree/master/packages/web-api-hooks#usedocumentvisibility
Thanks

Ok I've pushed up the utility function, let me know if there is anything else you need from me 🙂


Will it support Meta LLAMA？

Hi, I haven't found that how it works. As a beginner, I want to know that does this repo can support another LLMs, like Meta LLAMA or BLOOM

Hi @zhongtao93  we support different LLMs via langchain, please take a look at the documentation here for more information https://gpt-index.readthedocs.io/en/latest/reference/llm_predictor.html
Going to close since it's not an issue. Please join the discord community (https://discord.gg/dGcwcsnxhU) for better support!


The new way

What's the blocker here?

I'm not all the way through the repo migration doc yet, so... I don't know :) But I haven't merged those other PRs yet, which feed into this repo-migration branch.

@jmdobry I'm getting an error while running the samples test:
  × logs » should write a log entry
  √ sinks » should create a sink (2.8s)
  √ sinks » should get a sink (1.4s)
  √ sinks » should list sinks (1.5s)
  √ sinks » should update a sink (1.7s)
  √ quickstart » should log an entry (8.4s)
  √ logs » should write a simple log entry (8.2s)
  √ sinks » should delete a sink (1.6s)
  √ logs » should write using winston (8.7s)
  √ logs » should write using bunyan (8.7s)

  1 test failed [12:08:32]

  logs » should write a log entry
  C:\Users\sawch\dev\nodejs-logging\samples\system-test\logs.test.js:1

   1: 'use strict';
   2:

  Difference:

  - ''
  + 'Wrote to nodejs-docs-samples-test-c18b359e-7d40-4944-83bc-3d50f4eda3d9'

Any ideas?

Hmmm, the logs.test.js system test passes for me locally, so I'm not sure what's going on for you. You're on windows?

Yep, I'm on Windows. The cause of all problems with Node 😢

Another Windows/AppVeyor/gRPC problem:

Error: Cannot find module 'C:\projects\nodejs-logging\node_modules\grpc\src\node\extension_binary\node-v46-win32-ia32\grpc_node.node'

Node v4 errors with gRPC on Circle CI (https://circleci.com/gh/googleapis/nodejs-logging/3?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link):
npm install Log Output
><EMAIL_ADDRESS>install /root/project/node_modules/google-gax/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| linux | x64
node-pre-gyp info check checked for "/root/project/node_modules/google-gax/node_modules/grpc/src/node/extension_binary/node-v46-linux-x64/grpc_node.node" (not found)
node-pre-gyp http GET https://storage.googleapis.com/grpc-precompiled-binaries/node/grpc/v1.6.0/node-v46-linux-x64.tar.gz
node-pre-gyp http 200 https://storage.googleapis.com/grpc-precompiled-binaries/node/grpc/v1.6.0/node-v46-linux-x64.tar.gz
node-pre-gyp info install unpacking grpc_node.node
node-pre-gyp info tarball done parsing tarball
[grpc] Success: "/root/project/node_modules/google-gax/node_modules/grpc/src/node/extension_binary/node-v46-linux-x64/grpc_node.node" is installed via remote
node-pre-gyp info ok

Error
Error: Cannot find module<EMAIL_ADDRESS>

Fixed the issue above by forcing an npm rebuild in the Circle CI configuration.


Fixes for ghc 7.10

I've fixed issues that stop your package from building under ghc 7.10.

Thanks for your PR! but I can't merge it. please fix build error on ghc-7.8 & 7.6.

I totally forgot about older versions. Should I use CPP #defines to fix it?

Please use cabal-macro.
transformers-base source code maybe help you.

I cannot reproduce the travis ci errors locally. Can you?

It may be version dependent error.
Please use ghc-7.6/ghc-7.8 or see travis error and git commit --amend/git push -f to fix it.

I used ghc-7.6 and ghc-7.8 locally and could not reproduce the error. It appears to be a dependency tree issue. I'm not sure how this is possible because I only increased the upper bounds.

Hmm... sorry, I've gone and jumped to conclusions. I'll check it.

Okey, I fixed and merged it! thanks:smile:
Next version of haddocset is released when #20 fixed, but I'm in busy, so it may take some time.


Compile kernel modules on the fly

Adds dynamic module compilation to LISA.
The module is compiled on the fly and loaded/unloaded automatically by the FtraceCollector, when ftrace events provided by the module are requested. Compilation stages are cached as much as possible to minimize the overhead, but it might take a couple minutes on the first use depending on the setup.
When using this, please ensure that:

You are not using any other patch that adds the trace events (e.g. EAS integration branch). If you do, the module from lisa will either not be used, or be partially used and create duplicates events for the overlapping events.
Use the following kernel config. CONFIG_DEBUG_INFO_BTF=y will require a recent pahole, which is shipped in LISA, so just source init_env before building your kernel:

CONFIG_IKHEADERS=y
CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_INFO_BTF=y
CONFIG_DEBUG_INFO_REDUCED=n

You will probably need to point at the kernel sources that go with your kernel in the target_conf.yml file:

target-conf:
    kernel:
        src: /home/foobar/linux/

If you want a more reproducible setup, add that too. This will use an Alpine chroot and use clang by default:

target-conf:
    kernel:
        modules:
            build-env: alpine

TODO: add better doc for options required for the dynamic module and examples (attached
kmod_example.py.txt
)


WIP: Adds response headers

#15

Coverage decreased (-1.5%) to 96.923% when pulling accc03f449204232c697c0fd8bd4fb1f54a9f73c on securingsincity:add-response-headers into f5ab3ed6d52e98903154794fdea09459e29a3f07 on bernardolins:master.

Coverage decreased (-1.5%) to 96.923% when pulling accc03f449204232c697c0fd8bd4fb1f54a9f73c on securingsincity:add-response-headers into f5ab3ed6d52e98903154794fdea09459e29a3f07 on bernardolins:master.

closing as #18  solves the issue


welcome_message.py

Bot.followers as a property isn't working

please fix travis CI issues

Codecov Report

Merging #975 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #975   +/-   ##
======================================
  Coverage    44.2%   44.2%
======================================
  Files          28      28
  Lines        3070    3070
======================================
  Hits         1357    1357
  Misses       1713    1713

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7723afd...044397a. Read the comment docs.

Thanks for the update!
Can you please change the MESSAGE (19 line) to be more neutral, like: “hi, thanks for reaching me”.

Oka


Adding condition for R content

If the dataframe or object content is more than 10 (column OR row), the content will not be shown. Just small addition from the problem that I faced.

Hey, thanks for your submission.
I did a rework of the r script and also included a fix for this issue. See #83.


add missing enum types

Export some missing enum types to be used in the frontend clients:

TransactionInfoType
ConflictType
TransactionListItemType

You might want to bump the version too

You might want to bump the version too

bumped the patch version


Feat(ESmodule): provide an entry file compatible to module loaders

so that application developers can import Leaflet using any module loader (not just Rollup) and benefit from the latter's advantages, typically bundle optimization / tree shaking.
This is a follow-up from https://github.com/Leaflet/Leaflet/issues/5489#issuecomment-313845806
Here is the updated Plunkr demo, using the index.js entry file at https://rawgit.com/ghybs/Leaflet/8b7fba889368684c0066bbde151a5979033e4931/src/index.js instead of the inline one in the previous demo version:
https://plnkr.co/edit/987oafSDqBblon8gl0vD?p=info
In the case of SystemJS, this module loader automatically detects AMD usage.
Therefore plugins with such AMD wrapper can be used without issue, provided that the application developer imports the modified symbols from leaflet.
An easy way to achieve that is simply to import everything into the L namespace, in which case we re-create a similar situation as having L globally available:
import * as L from 'leaflet';
import 'leaflet.featuregroup.subgroup'; // or any AMD-wrapped Leaflet plugin.

// Use as if leaflet and the plugin were loaded through browser <script> tags…
L.featureGroup.subGroup();

Demo with plugin: https://plnkr.co/edit/Do6MdN0V8I3e1WFSMrXB?p=preview
Now we should very probably do a similar exercise for other module loaders?

Ok, so lets see if I understand these changes correctly.
For new modern build systems that understand modules, they will import from this new index.js, which just exports the Leaflet namespace as an object, but does not set any global, etc.
This will only work with plugins that are written using the same method, that also import Leaflet this way, and doesn't rely on the global window.L. However, they can still attach to Leaflet's namespace (since you use L.featureGroup.subGroup in your code).
A question regarding the last point, attaching to Leaflet's namespace, is if this is something we want to continue advocating as a "best practice" for plugins? I've really like the "attach to Leaflet's namespace" as long as we used a global (then there's at least only one global). With modules, it occurs to me this is starting to be a bit counter-intuitive rather than helpful. Any thoughts on this?
I think you're right we need to try this out with other module loaders as well, I'm adding those as a checklist here:

[ ] Webpack
[ ] Rollup
[ ] Browserify

I'd like to weigh on the Leaflet plugin/global namespace issue. I'm writing an ES6 Leaflet plugin now. I wanted both to expose my ES6 modules and follow the best practice of attaching to the global L. Here's a gist showing some code that should do that: https://gist.github.com/colbin8r/795c89433a6bc0098cd4df30ccac4e04
(It should probably also check for the existence of a global L now that I think about it... 🤔)
It's been well-established that global variables are a bad practice in general. Also, having Leaflet depend on globals has been a thorn in my side (see #5613). Probably the best solution is to only expose L if you know you're in a browser environment (e.g. check for window or something).

We should definitely do this, although keeping a separate index.js for this makes it harder to maintain. @ghybs want to explore if json2module-based solution looks nicer in Leaflet?

Hi @mourner,
As for the entry file, I would see a few possible options indeed:

Use json2module from d3, but needs to duplicate data from package.json during the build step. Therefore in some cases that data may be missing (directly importing the entry file from a cloned repo, instead of from a built copy like npm).
Import index.js in Leaflet.js, like a wrapper for Rollup build. A nice advantage is that the index.js could be as much lean and compliant with ES modules as possible (but the version issue from previous point could still be problematic), while we still provide some workarounds for the UMD build (global, noConflict…)

@perliedman,

With modules, it occurs to me [attaching to Leaflet's namespace] is starting to be a bit counter-intuitive rather than helpful.

I would even say that keeping the namespace by default totally defeats one of the main points of ES modules! :-) I think modules should delegate naming to consumer code.

However, they can still attach to Leaflet's namespace […]

Well I think this is actually specific to SystemJS, which automatically detects AMD-wrapped libraries and behaves accordingly. I think there is something similar with Rollup through rollup-plugin-commonjs plugin.
I am trying to come up with a scheme to do something similar as Leaflet for the plugins: having a clean ES module (that does not try to rely on global), with a Rollup build to UMD version, that would behave more or less like currently.
Will post when I have something working.

Here is already a new commit to demonstrate the re-use of index.js entry file for ES module in Leaflet.js for UMD Rollup build, so that all exports are managed in a single file.
The resulting build is exactly the same.

@ghybs

I would even say that keeping the namespace by default totally defeats one of the main points of ES modules! :-) I think modules should delegate naming to consumer code.

Making a plugin makes sense to do it inside L namespace, so it is a bit redundant. However, while making a webpage "using" Leaflet, I would prefer to know what is Leaflet and what is not. Then the namespace makes totally sense for me. Even Map or other modules can conflict with my webpage modules (or get mixed in an ugly way). How do I proceed in this case?

Hi @jjimenezshaw,
Thank you for your input!
Please can you kindly clarify the situation(s) you are referring to, so that we make sure we understand each other?

import {pluginClass} from 'leaflet-plugin' (ES6 module)
var plugin = require('leaflet-plugin') (CommonJS)
require(['leaflet', 'leaflet-plugin'], callback) (AMD)
<script src="leaflet-plugin.js"></script> (currently global)

@ghybs Sorry, I misunderstood something. I can import Leaflet and use it normally with import L from 'leaflet'; Later I can do L.map and other methods as usual (using L namespace I mean). Forget my previous post ;)

@jjimenezshaw Even better, you can import only the parts of Leaflet you actually need:
import { Map } from 'leaflet';
let myMap = new Map(...);
...

This allows for you to include in your final bundle or code only the parts of Leaflet you actually depend on through a technology called tree shaking. Since the Map module exported by Leaflet probably depends on other Leaflet components, those components are included as well, but you eliminate extraneous code from your final/production build.

@colbin8r Thanks. But if I want to 'keep' the L, how do I do "this"? (because "this" doesn't work)
import { Map as L.Map } from 'leaflet';
let myMap = new L.Map(...);
...

See that I want L not only on Map, but on every dependency it imports.

@jjimenezshaw I'm not sure why you would want to keep L other than for visual similarity to existing Leaflet code. If that's the case, then you may want to reconsider because I think Leaflet as a whole is moving away from namespacing everything under a global L anyway, so this style will likely change. One of the benefits of using ES6 modules is that you can use call the exports from other modules whatever you prefer.
With your last code example, you don't have direct access to any of the Map modules dependencies anyway because they aren't imported into your current scope. If you want access to them, you have to import them yourself.
But to answer your question, you have a few options.

Import everything like you were and forget about tree-shaking:

import L from 'leaflet';
let myMap = new L.Map(...);

Manually namespace it yourself.

import { Map } from 'leaflet';
// note the ES6 object literal here
// https://github.com/lukehoban/es6features#enhanced-object-literals
L = { Map };
let myMap = new L.Map(...);

Let me know if I missed something.

I like namespaces for libraries. I love it. All my life hearing 'Do not use global variables/functions', and as far as I see, when you import a module you create some stuff in the global scope. It was cleaner when there was only one, L.
On the other side, it is great including only what I use, and not everything.
But unfortunately I cannot have both things. It is a pity that I cannot import a module, and directly include it in a namespace I choose (and everything that imports it as well... like L).
Anyway, thanks for you help.


[core] Fix type definitions

I noticed some class names where normalized in beta36, resulting in some outdated type definitions.
This fixes the type definitions for the changed class names.

This pull request is a corollary of #10457.

@stefanorie Thanks a lot for cleaning that up!

@stefanorie @oliviertassinari I'm a little new to material-ui, so I'll ask first. Do you think the title was accidentally removed in GridListTileBar.d.ts? It's still in the code and docs

@ljani You are right, we miss subtitle and title. Do you want to submit a pull-request to fix it?


Locale ignored for UI generation

Description
The locale setting in my _config.yml seems to be ignored for generating the UI texts. They remain in English.
Environment

Minimal Mistakes version: 4.11.1
Ruby gem or remote theme version: remote
Jekyll version: 3.7.3
Git repository URL: https://www.github.com/carbeck/carbeck.github.io
Operating system: Ubuntu 16.04.4 LTS
GitHub Pages hosted (if yes provide URL to site): https://carbeck.github.io

Expected behavior
UI texts in German language as per setting in _config.yml.
Steps to reproduce the behavior

specify locale: "de-DE" in _config.yml
compile with bundle exec jekyll build (just jekyll build fails:

/var/lib/gems/2.3.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:313:in check_for_activated_spec!': You have already activated public_suffix 3.0.2, but your Gemfile requires public_suffix 2.0.5. Prepending bundle exec` to your command may solve this. (Gem::LoadError)

)

You don't have the UI text data file in your repo, that's why it's all defaulting to English.
Copy _data/ui-text.yml to your repo and it'll work. Since you're hosting with GH and using as a remote theme you need to do this as it can't pull it from the bundled gem.
The ruby gem version doesn't have that limitation...
The Jekyll build failure has nothing to do with the theme. You'll want to poke around jekyll/jekyll or ask for help through their approved channels.


Improper ListView row while changing orientation from Landscape to Portrait & vice-versa

Hi,
I observed that when you change orientation from Portrait to Landscape the ListView row sticks to the same width giving improper size of ListView row. Also, same is the case with changing orientation from Landscape to Portrait.
I am using

android:configChanges="orientation|keyboardHidden|screenSize"

in AndroidManifest.xml
Please provide the fix!
Thanks!

I found the issue to be caused by PR https://github.com/chthai64/SwipeRevealLayout/pull/33. If i skip the "width" calculation from this PR it works ok.

I tried to comment out

widthMeasureSpec = MeasureSpec.makeMeasureSpec(desiredWidth, widthMode);

But, it didn't work for me, it just centers the row, but doesn't full-screen its width

I commented desiredWidth = Math.max(child.getMeasuredWidth(), desiredWidth); as well.
Also, I don't have android:configChanges="orientation|keyboardHidden|screenSize" so my Activity is destroyed and re-created. There was an older issue about this and it is not implemented out of the box to handle configurationChange so you would probably need to do it yourself.

If I don't comment anything & re-create the Activity again its already working fine, then why would I post the issue?

Leaving asside your rude language, you would post this issue if you had the problem from this issue, even when re-creating the activity...
If this doesn't help you, maybe it will help someome else.

Ok, great! keep writing useless libraries & also don't dare to solve the bugs!
Best of Luck & Get Well Soon!

Erm...I hope you know I am not the one that wrote this library or even contributed to it. I am just someone who uses it for a project. If you look at the activity on this library, you are better off debugging the issue yourself.

I have save issue with recyclerview. android:configChanges not work.
Anyone have solution to resolve this issue

Any help with the issue. It exists still

If this problem is actual in 2018, here's the solution
private void changeLayout() {
           int pageWidth = ((WindowManager) mContext.getSystemService(Context.WINDOW_SERVICE)).getDefaultDisplay().getWidth();
           RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.MATCH_PARENT, RelativeLayout.LayoutParams.WRAP_CONTENT);
           params.width = pageWidth;
           mBinding.swipeLayout.setLayoutParams(params);
       }

If this problem is actual in 2018, here's the solution
private void changeLayout() {
           int pageWidth = ((WindowManager) mContext.getSystemService(Context.WINDOW_SERVICE)).getDefaultDisplay().getWidth();
           RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.MATCH_PARENT, RelativeLayout.LayoutParams.WRAP_CONTENT);
           params.width = pageWidth;
           mBinding.swipeLayout.setLayoutParams(params);
       }

where should i put that

where is a need for you)  I used that in the view holder

The problem is that the children loose there layoutparams when created. So just make sure to reset your child layoutparams.
  // first find the largest child
        for (int i = 0; i < getChildCount(); i++) {
            View child = getChildAt(i);
            if(i == 1){
                child.setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT));
            }
            child.invalidate();
            measureChild(child, widthMeasureSpec, heightMeasureSpec);
            desiredWidth = Math.max(child.getMeasuredWidth(), desiredWidth);
            desiredHeight = Math.max(child.getMeasuredHeight(), desiredHeight);
        }


documentation and minor changes

Attempt to document the code.
I used indenting in the comments to make it easier to distinguish the different code segments.
Note that I swapped XCHG<=>AND in the food generation to have AND AX, CX for a fairer comparison with AND AX, 0xF9C.
I also changed JA to JAE in the vertical boundary check since I think that's clearer (DI=0xFA0 => game over)
Feel free to adjust everything to your liking.
One additional thought, how about making an alternative version with AND AX, 0xF9C so the game cannot be ruined by food spawning off screen and HLT to slow it down a bit? It's still only 78 bytes and personally I find it surprisingly fun that way :)

One additional thought, how about making an alternative version with AND AX, 0xF9C so the game cannot be ruined by food spawning off screen and HLT to slow it down a bit? It's still only 78 bytes and personally I find it surprisingly fun that way :)

Actually thought about it but it feels weird to have a project aimed towards making something as small as I can but have a slightly bigger version which is just better at some other things... And actually not doing that is the only reason I'm not making a "super small version" and just allowing the snake to cross itself or food to spawn on it... But I don't know I might do it either way...

Sorry for the delay by the way

One additional thought, how about making an alternative version with AND AX, 0xF9C so the game cannot be ruined by food spawning off screen and HLT to slow it down a bit? It's still only 78 bytes and personally I find it surprisingly fun that way :)

Actually thought about it but it feels weird to have a project aimed towards making something as small as I can but have a slightly bigger version which is just better at some other things... And actually not doing that is the only reason I'm not making a "super small version" and just allowing the snake to cross itself or food to spawn on it... But I don't know I might do it either way...

Totally get your point. The food off screen is kind of a similar issue though...

Awesome work! Never even thought the comments could be so explanatory!

Thanks! It's much easier to be explanatory when not trying to strictly comment each line individually.


[FLINK-17875] [core] State TTL for remote functions

This PR is based on the refactoring work in #119, and completes the initial support for state TTL in remote functions. Only last 5 commits are relevant.
Users define state TTL in their YAML modules like so:
functions:
  - function:
     states:
       - name: xxxx
         expireAfter: 60000millisecond or 5sec / etc. # optional key

The current implementation has some limitations due to how we are multiplexing remote function's user state in a single PersistedTable (see FLINK-17954):

The actual TTL being set will be the longest duration across all registered state
The only supported expiration mode now is AFTER_READ_AND_WRITE. That can be added as a expireMode key in the YAML spec in the future.

Brief change log

1dbfa07 to 199d3fd Introduces a StateSpec class which captures the state name and configured expiration timeout.
435060f Updates the FunctionJsonEntity to recognize the new format (for version 2.0)
fb76fc5 Parameterize JsonModuleTest so that it runs tests for both v1.0 and v2.0 formats.

Verifying

The parameterized JsonModuleTest should cover this change.
Manually verified functionality by locally running a modified version of the Python greeter example, with state TTL enabled.

Thanks Gordon, the refactoring is already a nice improvement over the previous JsonModel, and exposing state expiration in the remote api is very helpful!
Thanks and LGTM

Thanks for the review!
Merging this now ...


Again very slow or it does not load at all

I just want to give a short feedback: the loading time is again very slow or it does not load at all. I have simply tried this with http://gutenberg.run/21121. But the same behaviour as back then... https://github.com/aduth/gutenberg.run/issues/4
Thx for this feature!

Hm, on first glance, it appears to load quite quickly for me. The initial build will take some few minutes, which has always been the case (and likely will always be). Were you observing absurdly long build times?
At least on checking the server processes, there's not the problem that led to #4. In the earlier problems, the Docker containers were not being cleaned up, which meant there were dozens of sites all running in the (very resource-limited) server. The number of containers active on the server at this current moment looks reasonable to me.

Hm, no idea, I've been waiting for 5 minutes and nothing is happening :-S

After your answer tested again, and now it works...
hm..

I don't see any errors in my Sentry dashboard either. Maybe there was some issue that the connection between your browser and the server? My expectation is that this too would be handled gracefully (source), but I may be missing something. There's some weird (and browser-specific) behavior in how these sorts of server-sent events handle disconnections.
I don't have much actionable here. If it happens again, could you check your browser's DevTools to see if any errors are logged? Or the network tab to see if there's any errors in the connections.


feat(client): add splitpanes for resizable columns

Hi :wave: ! Following https://github.com/nuxt/devtools/pull/82 , this PR adds splitpanes to the client for resizable columns.

I feel that the resize on the main layout is not good enough. We should let the responsiveness design react to the panel size to switch from (full tab/icon only). Maybe using container queries or a programmatic approach.

Reverted it for now, so we can move forward and improve later. Thanks a lot for the work.
A few TODOs I see:

Responsive main NavPanel
Persistent panel size (local storage + maybe a general component with key)


Spacing issue with contribution section and carousel

There are some more issues in the spacing in the home page. I am working on resolving those issues. Will send the PR soon.

Submitted PR at #265
@diptanshu-sopho have a look!


GLES2 3D view not showing correctly when batching on in IDE

Godot version:
3.2.2 beta
OS/device including version:
Linux Mint (Presumably all)
Issue description:
3D view camera is not working properly when using use_batching_in_editor. The camera matrix looks garbled and stretched on the y axis.
This is probably an OpenGL state that is not reset at the end of the 2d drawing, I'll see if I can fix it now.
It also suggests that the 3d view is relying on a particular GL state on entry, it might be worth fixing there too at the same time.

False alarm, this turned out to be due to local changes, it is not present on the merged version, yay! :grin:


ERROR: Reverting all changes

Running on a fresh install of Linux version 5.15.47-1-lts (linux-lts@archlinux) (gcc (GCC) 12.1.0, GNU ld (GNU Binutils) 2.38) gives the following error:
INFO: Adding user nobody to group nobody
INFO: Generating sudoers file /etc/sudoers.d/cyberghost-unrooted
INFO: Generating iproute file /etc/openvpn/client/ip-unrooted.sh
INFO: Adding device tun0-unrooted
./openvpn-unroot: line 397: `testing && echo "${comm[@]}" || "${comm[@]}" >/dev/null' returned 1
ERROR: Reverting all changes
./openvpn-unroot: line 499: `local ret; ret=("$("$@")"); readonly ret' returned 1
ERROR: Reverting all changes

@usersina Are you able to solve it? I got the same issue on Debian 11.

@potaesm nope. I simply enabled the VPN as a systemd service and got done with it. That said, internet goes down after a system suspend so I have to restart the service every time after I suspend the system.

@usersina Thank you for your reply! That means you are not using anything about openvpn-unroot but just run it as systemd service right?

@potaesm That is so.  I'll post it here!


Add Kyverno to default apps in preparation for 1.25

Parent https://github.com/giantswarm/roadmap/issues/3144

Kyverno w/o policies is not very useful. What policies should we ship together with the Kyverno app? In MC following are deployed:
giantswarm       kyverno-policies                                      0.20.1              16d          14d             deployed
giantswarm       kyverno-policies-connectivity                         0.5.3               16d          16d             deployed
giantswarm       kyverno-policies-dx                                   0.4.2               16d          16d             deployed
giantswarm       kyverno-policies-observability                        0.2.2               16d          16d             deployed
giantswarm       kyverno-policies-ux                                   0.7.0               16d          8d              deployed
giantswarm       kyverno-policy-operator                               0.0.1               14h          14h             deployed

imho the kyverno-policies would be good for start (https://github.com/giantswarm/kyverno-policies/tree/main/helm/kyverno-policies/charts/kyverno-policies/templates/restricted) perhaps running in the audit mode only.

We will need kyverno-policies-connectivity in case if proxy is needed.
Also those deprecatedAPI.x.yy (in here) can be super useful for customer to get an overall view on his workload cluster "updatability status".
The kyverno-policies-observability can be ignored atm (it's meant to be only for monitoring stack running in mc)
same for kyverno-policies-ux (mc stuff, cluster naming, organizations, etc)

kyverno-policy-operator according to readme, it watches on PolicyException from policy.giantswarm.io api group and translates it into PolicyException from kyverno.io api group. I am not sure how this can help here.

What policies should we ship together with the Kyverno app?
I think @giantswarm/team-shield should position one of the apps as WC policy apps. I am not sure.

Is there a parent issue with this? Do other teams move kyverno to default apps too?

We should do the same as we do now for vintage and ship the security bundle that includes both Kyverno and Kyverno Policies enabled.
Since this will be 1.25 then Kyverno should be enforcing, meaning it will block workloads without a proper exception.
cc/ @stone-z

ah, good to know @stone-z I'll check the security bundle

this will be part of aws release 19.3.0

Can we close this? Is everyone aligned on this now?

Nope. We haven't added it to CAPV yet.

CAPV to do - closing because superseded by https://github.com/giantswarm/giantswarm/issues/29849


我在使用 php api时遇到一些问题 如下图 返回了202 但是我没有收到邮件

https://user-images.githubusercontent.com/30595984/63987957-961c6480-cb0c-11e9-9891-207e6021f8de.png

Could you reproduce issue and use English writing?
And it will be fine for SendGrid suppport team to know where issue is.

Okay thank youI returned using php
But I didn't receive the mail.
202 Array ( [0] => HTTP/1.1 202 Accepted [1] => Server: nginx [2] => Date: Fri, 30 Aug 2019 01:57:02 GMT [3] => Content-Length: 0 [4] => Connection: keep-alive [5] => X-Message-Id: PbNwZ7sVT4ScPbABuuPA-w [6] => Access-Control-Allow-Origin: https://sendgrid.api-docs.io [7] => Access-Control-Allow-Methods: POST [8] => Access-Control-Allow-Headers: Authorization, Content-Type, On-behalf-of, x-sg-elas-acl [9] => Access-Control-Max-Age: 600 [10] => X-No-CORS-Reason: https://sendgrid.com/docs/Classroom/Basics/API/cors.html [11] => [12] => )
------------------ 原始邮件 ------------------
发件人: "Chun-Sheng<EMAIL_ADDRESS>发送时间: 2019年8月30日(星期五) 上午10:31
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [sendgrid/sendgrid-php] 我在使用 php api时遇到一些问题 如下图 返回了202 但是我没有收到邮件 (#877)
Could you reproduce issue and use English writing?
And it will be fine for SendGrid suppport team to know where issue is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, thanks for your reply. But I don't know how your codes execute.
If possible, could you provide your executed code?

Thank you for your reply, I have solved it, but I am happy to share my code.
202 has been successful, but my mailbox has no reminder
Need to be removed "getenv"

Hi @burt00, hopefully you've solved the issue.
This issue can be closed because you've solved :).