PHOENIX-5865 column that has default value can not be correctly indexed

LGTM +1 Do we have test passed for this PR?

I rebased the commit to trigger the test run.

Should I edit the lines which are not relevant to this change but checkstyle mentions as new errors?
The 2  failing tests are known as flaky.

If you haven't touched those lines, then fixing those checkstyle errors is optional.
If you fix it, then the code will be in a better shape, but the patch will be noisier.
If you don't fix it, then the patch will be easier to read, but the code will stay ugly.


Firefox support

Is it possible to make a firefox variant as well?
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Porting_a_Google_Chrome_extension

I'd like to +1 this issue, I run my sessions in Firefox!


Change EQ for calcified myocardium MP:0010534

Current EQ for calcified myocardium MP:0010534 is:
'has part' some
('increased amount' and ('inheres in' some
('calcium deposition' and ('part of' some myocardium))) and ('has modifier' some abnormal))
Change EQ to:
'has part' some
(calcified and ('inheres in' some myocardium) and ('has modifier' some abnormal))

EQ has been changed.


fix: misleading MissingCRDException exception

Fixes #552

We need to find a better way to check whether the 404 occurs because of a missing CRD or for some other reason. The MissingCRDException mechanism is central to how the Quarkus automatically applies missing CRD so we need that exception to be thrown there in this situation.

The check for the operator CRD is performed before (https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L165-L175) so I guess this is what Quarkus leverages.
The issue I'm facing is when an event source is registered and i.e. it may be that a CRD is missing but could be an external CRD so Quarkus won't be able to apply them (I guess)

The check for the presence of the controller CRD is performed before (https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L165-L175) so I guess this is what Quarkus leverages.

Unfortunately, this isn't enough, which is why I added that code in the first place. However, I agree that it's subpar… I'm working on an hopefully better solution.

The check for the presence of the controller CRD is performed before (https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L165-L175) so I guess this is what Quarkus leverages.

Unfortunately, this isn't enough, which is why I added that code in the first place. However, I agree that it's subpar… I'm working on an hopefully better solution.

Wonder if it would be simpler if Quarkus should just apply the CR if it is configured to do so without checking, what would be the downside ?

The check for the presence of the controller CRD is performed before (https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L165-L175) so I guess this is what Quarkus leverages.

Unfortunately, this isn't enough, which is why I added that code in the first place. However, I agree that it's subpar… I'm working on an hopefully better solution.

Wonder if it would be simpler if Quarkus should just apply the CR if it is configured to do so without checking, what would be the downside ?

That's a good point and I actually think that's the direction things are going now… The exception was introduced when the extension didn't have the ability to re-apply the CRD on changes but it now has that ability so we might indeed simplify things here… I will have to check. I've been working on improving the exceptions in the fabric8 client as well so will first finish on that path to validate the approach.
That said, the MissingCRDException should be interesting for more than just the Quarkus extension as a diagnostic tool for users as well (because that's quite a common occurrence for beginners with the SDK to forget to apply the CRD to the cluster and, previously, you used to get a cryptic 404 error without any details).

The check for the presence of the controller CRD is performed before (https://github.com/java-operator-sdk/java-operator-sdk/blob/master/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java#L165-L175) so I guess this is what Quarkus leverages.

Unfortunately, this isn't enough, which is why I added that code in the first place. However, I agree that it's subpar… I'm working on an hopefully better solution.

Wonder if it would be simpler if Quarkus should just apply the CR if it is configured to do so without checking, what would be the downside ?

I've been working on improving the exceptions in the fabric8 client as well so will first finish on that path to validate the approach.

+1

That said, the MissingCRDException should be interesting for more than just the Quarkus extension as a diagnostic tool for users as well (because that's quite a common occurrence for beginners with the SDK to forget to apply the CRD to the cluster and, previously, you used to get a cryptic 404 error without any details).

Agree, better exception from fabric8 client would be very useful.

I guess I can close this one then ?

I guess I can close this one then ?

I think so, yes. Just let me know if the fix in #558 works for you. :)

LGTM

Superseded by #558. Thanks for bringing this up!


Feature request: Disable frontmatter inclusion

Hello,
I love this addon, but don't have a need for the big block of gist-related frontmatter that appears when using it. If there could be an option to disable that, that would be incredible. Thank you!

To be fair, I can probably implement that a different way that doesn’t use messy front-matter 😊

Hi,
Thanks for the response!  I quickly just create a gist once and share it, similarly to Pastebin or something.  While I understand how editing the existing gist could be useful, it's not one of my use cases.  If it's a hassle to add this functionality, don't worry about it!  It's a bit of a nit-pick anyway :)  Thanks!

This is fixed in v1.1.0, which I've just released. You can turn off the "Enable updating gists after creation" option - which is disabled by default - to stop this from happening.


Scientific Calculator

Introduction
Hello sir,
I want to add my project of Scientific calculator in this repo.
Screenshots
https://github.com/apu52/Scientific-Calculator/assets/114172928/2cfa1956-4af8-4a90-aebf-4beff47fc4f0
Additional Context
Please assign me this issue under OSEN

@Shu12388y @avinash201199 Please assign me this issue.

@apu52 start working


cygwin and mingw installation still buggy on windows

After fresh setup of devon-ide (beta16) I did Open Devon Cygwin here:
hohwille@laptop /cygdrive/c/projects/cool-project/workspaces
$ mvn -v
bash: mvn: command not found

hohwille@laptop /cygdrive/c/projects/cool-project/workspaces
$ devon
bash: devon: command not found

This is trivial to fix, but the setup however does not install devon on cygwin. The reason is that cygwin has its own home directory that is isolated from the regular windows home directory used by MINGW (git bash) and CMD.
In MINGW there is another strange error. I did Git Bash here from WindowsExplorer:
devon-ide has environment variables have been set for /c/projects/cool-project (workspace main)

hohwille@laptop MINGW64 /c/projects/cool-project/workspaces
$ mvn -v
bash: mvn: command not found

hohwille@laptop MINGW64 /c/projects/cool-project/workspaces
$ devon
devon-ide has environment variables have been set for /c/projects/cool-project (workspace main)

hohwille@laptop MINGW64 /c/projects/cool-project/workspaces
$ mvn -v
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
Maven home: C:\projects\cool-project\software\maven
Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: C:\projects\cool-project\software\java
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

In MINGW I added some env statement for debugging:
PATH=/software/*:/c/Users/hohwille/bin:...

So still struggeling with DEVON_IDE_HOME not being set. This change was really a breaking one...

Further uninstall is not consistent as it leaves some leftovers:
/cygdrive/c/Users/hohwille/.bashrc: line 8: devon: command not found

Fixed with PR #210 (at least we hope all is fixed now, tests running...)


#134: Don't Use Disabled Launch Args and Env Variables

#134
Only add launch args and environment variables if they are enabled in the scheme

@oliverhu Updated the unit test to have disabled launch/env variables


Remove unnecessary main.d.ts file

Rationale
See rationale from the related PR
Related Pull Requests

https://github.com/LabKey/labkey-ui-components/pull/523

Changes

Remove main.d.ts file

Shouldn't this PR also bump the ui-components version in package.json?

I don't believe so. In develop, the pipeline/package.json is on 2.29.0, which is the version in labkey-ui-components where I replaced the LABKEY const with getServerContext().


EPIC: Node & key format

Currently IAVL does not take advantage of data locality on disk. The way IAVL store nodes on disk is with a hash that gets stored in a random location on disk and makes it so that IAVL needs to do a random search of disk in order to find the data. With the recent work from osmosis on fast node we saw a large performance improvement with a trade off on writes.
Secondly, there are two key formats, live keys and orphan keys referenced by node hash which also indexes the orphan nodes.
A next step would be to modify IAVL to structure data on disk in a logical manner to reduce random searches and reduce random compaction of disk data.
There are two things that can be done in order to take advantage of this.
Work Scope:
Phase 1:

[ ] modify the key format from a hash of the data to be write_version|node_path_in_tree.

Phase 2:

[ ] make every node store the version of its children.
[ ] remove orphan indexing and hashes

(Proposed by @ValarDragon)

Other steps:

To modify the key format, you have to update the node struct to add left_child_version and right_child_version in the nodes

Can be done later, but needed pre-integration for pruning:

Clarify versioning / historic delete API semantics from SDK
Make methods to prune (theres a couple approaches, if someones having trouble deriving them, can write up more)

modify the key format from a hash of the data to be write_version|node_path_in_tree.
where write_version is the left side and node_path_in_tree is the right side?
Or is it like, both sides have that?

NOTE: store/v2 solves that in a way similar to TurboGeth (erigon)

So this proposal will increase a node (and DB) size, right?
Few important questions

What is the definition of write_version?
Will that impact state proofs / merkle proofs? This change must be compatible with the existing merkle proof, otherwise we have trouble with IBC. My guess is that it won't, but want to double check.

NOTE: store/v2 solves that in a way similar to TurboGeth (erigon)

thank you, but as mentioned in a few places store/v2 work is unknown at this time for countless reasons.

@marbar3778
It looks like we couldn't modify the key format as write_version|node_path_in_tree. Because when rotating the tree, the path should be changed.

this is expected, do you see a problem with this?
cc @ValarDragon


Add Nullable version of uniqueidentifier

Why do you think this is the right way of adding new type support?

I didn't see anything in the readme about how you wished to have anything new added, so I added as new/dedicated files to keep it as simple as possible for me without touching the existing code.

You need to add a roundtrip test with the actual SQL server.  One test should set a value in the SQL and read it uniqueidentifier.  Another test should verify sending uniqueidentifier value into SQL server and then read it back and compare with original.  Each test should test actual value and NULL.


Polycode::Entity.getScale() returns Vector3 but doesn't accept it as argument for setScale()

We should be able to execute such
entityInheritedObj.setScale(entityInheritedObj.getScale() * 0.9);

also we should be able to execute this two lines:
entityInheritedObj->getScale() = entityInheritedObj->getScale() * 0.98;
entityInheritedObj->getScale() *=  0.98;

or execution of such code should be prohibited and produce an error. Now it does nothing, scale does not change and no error is produced.

Added setScale, among other things.
The
entityInheritedObj->getScale() = entityInheritedObj->getScale() * 0.98;
entityInheritedObj->getScale() *=  0.98;

thing doesn't make sense to me, as getScale() returns a Vector3 by copy, so I don't think this should work.


0.46 scheduled deprecations

Contains the scheduled deprecations for 0.46 in individual patches.

The changes looks good. Will merge once CI passes.

Great, thanks for the review.


Threads preventing stop_all from working completely

Using:

god 0.13.4
ruby 2.1.1
ubuntu 12.04

Trying to run god terminate usually fails to terminate all of the watches (currently only 3 watches are active on this server). It's inconsistent how many watches are successfully killed.
When I comment out these Thread lines, terminate works perfectly: https://github.com/mojombo/god/blob/df3bcfa5af6504b6a5858a02d37699c8c821fb2c/lib/god.rb#L491-L494
What could cause this?

I was the having the same problem. I started to trace it down to the Driver communication too (we send the message but the Driver never receives it). @carsonreinke 's solution seems to work for me! Ruby 1.9's end of life is less than two weeks -- February 23, 2015 -- it would be nice it god works correctly with a supported version of Ruby after then.
As for running 'stop' before 'terminate' -- when you do a terminate it makes it pretty clear it is trying to stopping all watches, wait for them to end, and then ending the god completely.

I am currently having the same problem: Terminating inconsistently fails to stop all watches (although I have already increased the timeout). Sending a TERM signal to the still running processes via kill is usually enough but it seems that they have not received a signal before that - so it got lost somewhere.
This is something I am regularly struggling with as I terminate and restart god on every deployment.
I this issue related to #9?

Any news on this?

no sorry
Date: Mon, 21 Sep 2015 10:16:43 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: Re: [god] Threads preventing stop_all from working completely (#189)
Any news on this?
—
Reply to this email directly or view it on GitHub.


Solution Dev - Other Dev (VBScript)

7/29/21 - Per LADOH, Precision will continue to work with them directly, as we are not ready to assist with reportables other than COVID at this present time.
Marking all additional tickets as "CLOSED."


[Validation] Validate single page publish for apps with SQL Lite

Create all templates with Individual auth and SQL Lite configuration.
Publish the template as a single file application.
Verify it runs

Working as expected. Validated:

Razor
Mvc
Blazor server
Angular
React


Property descriptions on 'any' objects

Is it possible to retain the property description from the specification when a property is marked as "any"? Right now, they get a description of "Any object" but it might be more helpful to pass on the original description. For example, the mainTemplate property on Microsoft.Resources/templateSpecs/versions would get "The main Azure Resource Manager template content."

This was fixed in https://github.com/Azure/bicep-types-az/pull/883.


App can not be closed if license expired

Before creating a new bug report
Please check if there isn't a similar issue on the issue tracker or in the discussions.
If you are having troubles connecting your project to Ray, please check our docs first, especially the configuration and environment specific configuration sections.
Describe the bug
If you start the app after your license expired, once the licensing window appears you can no longer quit the app except from the Activity Monitor.
Versions
Ray version (you can see this in "About Ray"): 2.5.1
You can use composer show to get the version numbers of:

spatie/ray package version: spatie/ray                                1.37.2
spatie/laravel-ray package version (if applicable): spatie/laravel-ray                        1.32.4

PHP version: 8.2.7
Laravel version (if applicable): Laravel Framework 10.13.5
To Reproduce
Steps to reproduce the behavior:

Open ray with an expired license.
Send something to the window until license window appears.
Try to exit ray.

Expected behavior
Can quit the app.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. macOS] macOS
Version [e.g. 22] 13.0.1 (22A400

Additional context
Add any other context about the problem here.

I can second this. Not with an expired license, but with a valid one that I can't activate. #812


SNOW-703372: Add indexer for StructType to be on par with pyspark beh…

…avior.
Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-703372

Please describe how your code solves the related issue.
Add getitem and setitem to StructType to handle by string, index or slice range for StructType.

I have read the CLA Document and I hereby sign the CLA

recheck


Fix BitmapLayer

Change List

Fix BitmapLayer instance count
Add render test

Coverage increased (+0.003%) to 62.904% when pulling 25b7fa34e38a60198fbfd6c4bdf3167d3b641b10 on x/bitmap-fix into b5fe0724f53b54c1d07d73adc5a2a1baa0144351 on master.


Upgrade to Tensorflow 0.9.0

Associated with #23

Tests with TF 0.9 seem to be fine. Should we merge this? We will lose compatibility with TF 0.8, do we have any reason to maintain it?

No we have not. Do we @jlibovicky ?

I would not say so.


How to use QuickConverter expression with multi language resource text ?

Hi All,
Is it possible to use QuickConverter expression with multi language resource text ?
My expression is like this
<TextBlock Text="{qc:MultiBinding '\'{x:Static resx:Resources.text_12} \' + $P0.ToString() + \' / trouvée(s) \' + $P1.ToString() + \')\'', P0={Binding PrintersCountExpected}, P1={Binding PrintersCountFound}}"/>
where {x:Static resx:Resources.text_12} comes from a resource langage file.
But it doesn't work. {x:Static resx:Resources.text_12} is displayed as text and is not interpreted by the parser.

You can pass the resource as an additional value
<TextBlock Text="{qc:MultiBinding '\'$V0\' + $P0.ToString() + \' / trouvée(s) \' + $P1.ToString() + \')\'',
P0={Binding PrintersCountExpected},
P1={Binding PrintersCountFound},
V0={x:Static resx:Resources.text_12}}" />

It's working with removing the ' and extra chars :
<TextBlock Text="{qc:MultiBinding '$V0 + $P0.ToString() + $P1.ToString()',
P0={Binding PrintersCountExpected},
P1={Binding PrintersCountFound},
V0={x:Static resx:Resources.text_12}}" />

Thank you,


crash when loading on 1.19.2 fabric

---- Minecraft Crash Report ----
// Don't do that.
Time: 2023-08-23 15:50:48
Description: Initializing game
java.lang.NullPointerException: Cannot read field "loaded" because "com.minenash.seamless_loading_screen.SeamlessLoadingScreen.BLUR_PROGRAM" is null
at net.minecraft.class_310.handler$ega000$seamless_loading_screen$captureResize(class_310.java:20506)
at net.minecraft.class_310.method_15993(class_310.java:1322)
at net.minecraft.class_310.(class_310.java:629)
at net.minecraft.client.main.Main.method_44604(Main.java:205)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.class_310.handler$ega000$seamless_loading_screen$captureResize(class_310.java:20506)
at net.minecraft.class_310.method_15993(class_310.java:1322)
at net.minecraft.class_310.(class_310.java:629)
-- Initialization --
Details:
Modules:
ADVAPI32.dll:Advanced Windows 32 Base API:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
COMCTL32.dll:User Experience Controls Library:6.10 (WinBuild.160101.0800):Microsoft Corporation
CRYPT32.dll:Crypto API32:10.0.22000.2295 (WinBuild.160101.0800):Microsoft Corporation
CRYPTBASE.dll:Base cryptographic API DLL:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
CRYPTSP.dll:Cryptographic Service Provider API:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
CoreMessaging.dll:Microsoft CoreMessaging Dll:10.0.22000.1042 (WinBuild.160101.0800):Microsoft Corporation
DBGHELP.DLL:Windows Image Helper:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
DEVOBJ.dll:Device Information Set DLL:10.0.22000.2124 (WinBuild.160101.0800):Microsoft Corporation
DNSAPI.dll:DNS Client API DLL:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
GDI32.dll:GDI Client DLL:10.0.22000.1880 (WinBuild.160101.0800):Microsoft Corporation
GLU32.dll:OpenGL Utility Library DLL:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
IMM32.DLL:Multi-User Windows IMM32 API Client DLL:10.0.22000.1641 (WinBuild.160101.0800):Microsoft Corporation
IPHLPAPI.DLL:IP Helper API:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
KERNEL32.DLL:Windows NT BASE API Client DLL:10.0.22000.2124 (WinBuild.160101.0800):Microsoft Corporation
KERNELBASE.dll:Windows NT BASE API Client DLL:10.0.22000.2124 (WinBuild.160101.0800):Microsoft Corporation
MMDevApi.dll:MMDevice API:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
MSCTF.dll:MSCTF Server DLL:10.0.22000.2295 (WinBuild.160101.0800):Microsoft Corporation
NSI.dll:NSI User-mode interface DLL:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
NTASN1.dll:Microsoft ASN.1 API:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
Ole32.dll:Microsoft OLE for Windows:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
OleAut32.dll:OLEAUT32.DLL:10.0.22000.2176 (WinBuild.160101.0800):Microsoft Corporation
OpenAL.dll:Main implementation library:1.21.1:
PSAPI.DLL:Process Status Helper:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
Pdh.dll:Windows Performance Data Helper DLL:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
RPCRT4.dll:Remote Procedure Call Runtime:10.0.22000.1761 (WinBuild.160101.0800):Microsoft Corporation
SHCORE.dll:SHCORE:10.0.22000.2295 (WinBuild.160101.0800):Microsoft Corporation
SHELL32.dll:Windows Shell Common Dll:10.0.22000.2295 (WinBuild.160101.0800):Microsoft Corporation
UMPDC.dll:User Mode Power Dependency Coordinator:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation
USER32.dll:Multi-User Windows USER API Client DLL:10.0.22000.2295 (WinBuild.160101.0800):Microsoft Corporation
USERENV.dll:Userenv:10.0.22000.1 (WinBuild.160101.0800):Microsoft Corporation

My bad, I made an assumption that led to the crash. Such will be fixed within the next update.

Could you try the latest release to confirm if this is still a issue: https://modrinth.com/mod/seamless-loading-screen/versions


feat(api): database schemas migration to new API

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10436 into master will decrease coverage by 6.22%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master   #10436      +/-   ##
==========================================
- Coverage   70.25%   64.03%   -6.23%
==========================================
  Files         605      544      -61
  Lines       32377    30612    -1765
  Branches     3271     2885     -386
==========================================
- Hits        22745    19601    -3144
- Misses       9522    10830    +1308
- Partials      110      181      +71

Flag
Coverage Δ

#cypress
54.48% <100.00%> (-0.10%)
:arrow_down:

#javascript
?

#python
69.78% <89.28%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/core.py
74.27% <0.00%> (-0.31%)
:arrow_down:

superset/databases/api.py
87.50% <91.66%> (+0.32%)
:arrow_up:

superset-frontend/src/components/TableSelector.jsx
52.94% <100.00%> (-31.93%)
:arrow_down:

superset/databases/schemas.py
100.00% <100.00%> (ø)

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...uperset-frontend/src/views/CRUD/dataset/Button.tsx
6.66% <0.00%> (-93.34%)
:arrow_down:

...uperset-frontend/src/utils/getClientErrorObject.ts
0.00% <0.00%> (-88.89%)
:arrow_down:

.../src/dashboard/components/FilterIndicatorGroup.jsx
11.76% <0.00%> (-88.24%)
:arrow_down:

... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...5a8ca23. Read the comment docs.

Thank you! @villebro


⚠ Bofrost.lu has degraded performance

In d0d68ff, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 934 ms

Resolved: Bofrost.lu performance has improved in 8deaf77 after 6 minutes.


Vague import error

Some more investigation is required, this may be either a lean or lake problem, but when a lean file imports a file that doesn't exist you get the following error:
$ lake build
error: no such file or directory (error code: 2)
  file: ./././Test/IDontExist.lean

This says the file that doesn't exist, which is useful, but it does not say the even more useful information of what file produced the import error.

This is https://github.com/leanprover/lake/issues/25


How can I use app.server?.publish from a plugin?

I have a plugin for handle all requests to /votes endpoint:
export const votes = new Elysia()
	.use(voteModel)
	.get('/votes', () => voteRepository.getVotes(), {
		response: 'votes',
		detail: {
			tags: ['votes'],
		},
	})
	.post(
		'/votes',
		({ body }) => {
			const result = votes.server?.publish('party', 'vote');
			console.log(result);
			return voteRepository.create(body);
		},
		{
			body: 'vote.create',
			response: 'vote',
			detail: {
				tags: ['votes'],
			},
		}
	)
	.delete('/votes/:id', ({ params }) => voteRepository.delete(params.id), {
		params: t.Object({
			id: t.String(),
		}),
		detail: {
			tags: ['votes'],
		},
	});

This is my ws plugin:
export const wsPlugin = new Elysia().ws('/ws', {
	open(ws) {
		ws.subscribe('party');
	},
	message(ws, message) {
		ws.send(message);
	},
});

The result from votes.server?.publish('party', 'vote'); is always undefined. How can I reference the app defined in index.ts from my plugin?

In our API we define the websocket plugin as the last thing before .listen() and it works correctly, do you have the latest version of Elysia? Also, I believe Discord would be a more appropriate channel to ask this kind of questions! 🙂

All right! I will try the very new version and, if it does not work, I will ask the question on Discord. Thank you


Adding Custom Buttons to the header

Im in need to adding fullscreen icon to the header , Is there any way I can add custom icons in the header , other than the refresh and column selector . Can anyone help me to resolve this ?

As far as I know, there's no way to add any custom buttons to the header in inside ornamentum functions. But you can always use angular (or whatever the framework you are using) to add custom buttons to any element inside ornamentum using selectors, and add needed implementation for that


Tokenizer class PhobertTokenizerFast does not exist or is not currently imported.

First, thank you for your contributions.
I followed your instruction but I got the error.
Could you help me fix this?
Thanks a lot!

See: https://github.com/VinAIResearch/PhoBERT/issues/21#issuecomment-695881512

It doesn't work

Ah right, PhobertTokenizerFast has not implemented yet. However, I have no idea why transformers now calls the this *Fast class instead of the original PhobertTokenizer. Each of two solutions should work:

Use PhobertTokenizer instead of AutoTokenizer:

from transformers import PhobertTokenizer
tokenizer = PhobertTokenizer.from_pretrained("vinai/phobert-base")

Or Install transformers version 3.2/3.3

Ah right, PhobertTokenizerFast has not been implemented yet. However, I have no idea why transformers now calls this *Fast class instead of the original PhobertTokenizer. Each of the two solutions should work:

Use PhobertTokenizer instead of AutoTokenizer:
from transformers import PhobertTokenizer
tokenizer = PhobertTokenizer.from_pretrained("vinai/phobert-base")

Or Install transformers version 3.2/3.3

I am trying to add Phobert to the JointBert model.
I got the error.
Could you explain why and help me fix it?
Thanks a lot!


Any specific read permissions needed on the CoC side?

So I've gotten my API token from the CoC website (made sure the IP was correct as my server).
For some reason, when I enter my clan tag (#YGJP9RGR), I am returned with a blank page (except the column headers, donation headers, etc) when I access the page. Is there anything on the CoC app that I need to enable to allow the API to access my clan's data? Do I need to the a (Co-)Leader in order for it to work?

Actually, I found the error I'm getting. It's giving me an
{"reason":"accessDenied","message":"Invalid authorization"}
error. I'm going to try to regenerate my API key and see if there was a bug there.

Found the issue. For some reason, my server is using one IP address (for the front end, what my domain resolves to) but using another IP to actually make the cURL api call. Strange....
Anyway, it works as promised!

Glad to see it works for you!
I should probably include a check for accessDenied, I ran into the same issue when I forgot to change my token.


xWebapppool will not compile using identitytype gMSA

ISSUE TITLE:
'xwebapppool: Short description of my issue'
ISSUE DESCRIPTION (this template):
I would like to create an App Pool for a DSC Pull server running on Server 2019 that's connecting to a SQL Server 2019 backend that's running on Server 2019 as well. I want to authenticate to the DB using a gMSA, not SQL Authentication. I don't see a way to compile a configuration with the xwebapppool resource using the gMSA username format. I keep getting the error below.
I can manually edit the LCM mof and set the identitytype to "mylab\SQLsvcAccount$", reapply the LCM config and everything works fine.
xWebAdministration\xWebAppPool : At least one of the values 'mylab\SQLsvcAccount$' is not supported or valid for property 'identityType' on class 'xWebAppPool'. Please
specify only supported values:
ApplicationPoolIdentity, LocalService, LocalSystem, NetworkService, SpecificUser.
At line:78 char:9
xWebAppPool DSCPool
CategoryInfo          : InvalidOperation: (:) [Write-Error], ParentContainsErrorRecordException
FullyQualifiedErrorId : UnsupportedValueForProperty,xWebAdministration\xWebAppPool
Details of the scenario you tried and the problem that is occurring
Verbose logs showing the problem
Suggested solution to the issue
The DSC configuration that is used to reproduce the issue (as detailed as possible)
Configuration SecureWebPullServerWithSQLDatabase {
    Param (
        [ValidateNotNullOrEmpty()]
        [ string ] $NodeName = 'localhost' ,

        [ValidateNotNullOrEmpty()]
        [ string ] $Thumbprint = " $( Throw "Provide a valid certificate thumbprint to continue" ) " ,

        [ValidateNotNullOrEmpty()]
        [ string ] $Guid = " $( Throw "Provide a valid GUID to continue" ) "
    )
    Import-DscResource -ModuleName PSDesiredStateConfiguration, xPSDesiredStateConfiguration, xWebAdministration

    Node $NodeName
    {
        LocalConfigurationManager
        {
            ActionAfterReboot       = 'ContinueConfiguration'
            ConfigurationMode       = 'ApplyandAutoCorrect'
            RebootNodeIfNeeded      = $false
            AllowModuleOverwrite    = $true
            CertificateID           = $ThumbPrint
        }
        # https://docs.microsoft.com/en-us/powershell/dsc/pull-server/secureserver
        # The next series of settings disable SSL and enable TLS, for environments where that is required by policy.
        Registry TLS1_2ServerEnabled
        {
            Ensure      = 'Present'
            Key         = 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server'
            ValueName   = 'Enabled'
            ValueData   = 1
            ValueType   = 'Dword'
        } # end resource

        Registry TLS1_2ServerDisabledByDefault
        {
            Ensure      = 'Present'
            Key         = 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server'
            ValueName   = 'DisabledByDefault'
            ValueData   = 0
            ValueType   = 'Dword'
        } # end resource

        Registry TLS1_2ClientEnabled
        {
            Ensure      = 'Present'
            Key         = 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client'
            ValueName   = 'Enabled'
            ValueData   = 1
            ValueType   = 'Dword'
        } # end resource

        Registry TLS1_2ClientDisabledByDefault
        {
            Ensure      = 'Present'
            Key         = 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client'
            ValueName   = 'DisabledByDefault'
            ValueData   = 0
            ValueType   = 'Dword'
        } # end resource

        Registry SSL2ServerDisabled
        {
            Ensure      = 'Present'
            Key         = 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\SSL 2.0\Server'
            ValueName   = 'Enabled'
            ValueData   = 0
            ValueType   = 'Dword'
        }

        Windowsfeature DSCServiceFeature
        {
            Ensure = 'Present'
            Name = 'DSC-Service'
        }

        xWebAppPool DSCPool
        {
            Ensure = 'Present'
            Name = 'DSCPool'
            identityType = "mylab\SQLSvcAccount$"
            startMode = 'OnDemand'
            State = 'Started'
            DependsOn = '[WindowsFeature]DSCServiceFeature'

        }

        xDscWebService SecureWebPullServer
        {
            Ensure = 'Present'
            EndpointName = 'PSDSCPullServer'
            Port = 443
            PhysicalPath = "$env:SystemDrive\inetpub\PSDSCPullServer"
            CertificateThumbPrint = $Thumbprint
            ModulePath = "$env:PROGRAMFILES\WindowsPowerShell\DscService\Modules"
            ConfigurationPath = "$env:PROGRAMFILES\WindowsPowerShell\DscService\Configuration"
            State = 'Started'
            DependsOn = '[xWebAppPool]DSCPool'
            RegistrationKeyPath = "$env:PROGRAMFILES\WindowsPowerShell\DscService"
            AcceptSelfSignedCertificates = $false
            UseSecurityBestPractices = $true
            ApplicationPoolName = 'DSCPool'
            SqlProvider = $true
            SqlConnectionString = 'Provider=MSOLEDBSQL;Server=sql.mylab.local;Database=dsc;Trusted_Connection=yes;Initial Catalog=master;Encrypt=yes;'
        }

        File RegistrationKeyFile
        {
            Ensure = 'Present'
            Type = 'File'
            DestinationPath = "$env:ProgramFiles\WindowsPowerShell\DscService\RegistrationKeys.txt"
            Contents = $Guid
            DependsOn = '[xDscWebService]SecureWebPullServer'
        }

        Windowsfeature IISMGMTConsole
        {
            Ensure = 'Present'
            Name = 'Web-Mgmt-Console'
            DependsOn = '[xDscWebService]SecureWebPullServer'
        }

        # Stop the default website
        xWebsite StopDefaultSite
        {
            Ensure         = 'Present'
            Name           = 'Default Web Site'
            State          = 'Stopped'
            PhysicalPath   = 'C:\inetpub\wwwroot'
            DependsOn      = '[WindowsFeature]DSCServiceFeature'
        } # end resource

        WindowsFeature IISScripting
         {
             Ensure         = 'Present'
             Name           = 'Web-Scripting-Tools'
             DependsOn      = '[xDSCWebService]SecureWebPullServer'
         } # end resource
    }
}

The operating system the target node is running

Version and build of PowerShell the target node is running

Version of the DSC module that was used
PSDesiredStateConfiguration 1.1
xPSDesiredStateConfiguration 9.1.0
xWebAdministration 3.1.1

For a resource to be able to support (g)MSA it needs to ignore the password part of the credential object (discussed and documented in the SqlServerDsc specific guidelines, credentials-that-does-not-have-password.
I see this resource do expect to set the password for the credential object so I suspect the resource need to be modified to handle (g)MSA.

This scenario is documented in another issue from a few years ago #80, the workaround discussed there of passing a random password as part of the credential object for the gMSA does work to get the config to compile and config the server. It's just a bit wonky.


why all react-native packages are obsolete it is harder to develop react-native than with java.

we wanted to see all the wonders of react-native talk here and there but seriously there are too many bugs due to this due to what I think you should review the way in which packages are updated

I'd like to casually point out that this is your first issue ever on Github and you have approximately 0 repositories.

You can move these discussions on reddit, and post any issues you are facing with react-native here

Not an issue. I believe this should be closed.

Closing as stale


dnsimple

It would be nice to be able to access the control and worker nodes like this:
control-01.mydatacenter.example.com
control-02.mydatacenter.example.com
control-03.mydatacenter.example.com
worker-001.mydatacenter.example.com
worker-002.mydatacenter.example.com
worker-003.mydatacenter.example.com
Is it possible to set up dnsimple with microservices-infrastructure, to work that way?

@eirslett You should be able to do it via terraform. It will require a little bit of modification on your behalf, but there is a dnsimple provider in terraform that should do the trick. (You'll have to use vars in the provider definition to match each IP to a hostname).
Please let me know if this works for you. It would be awesome if you could document an example.
https://www.terraform.io/docs/providers/dnsimple/index.html

I tried, and hit this bug: https://github.com/hashicorp/terraform/issues/2441
What worked in the end, was to put dnsimple inside terraform/digitalocean/hosts/main.tf, but that is a very tight coupling between digitalocean and dnsimple that we want to avoid. I hope we'll hear from the Terraform team soon, about the issue/bug.

hashicorp/terraform#2441 was closed as a dup, the live issue can be found at https://github.com/hashicorp/terraform/issues/2301.

I believe we have addressed this via #653.


[DNM] Test CHBLOCK codec format

Only a dummy PR that tests CHBLOCK codec format

/run-all-tests test-tiflash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

/run-all-tests test-flash=true

Test Result, following cases fail:
select col1 from t where col2 op val;

When col1 is BOOLEAN, BIT type, TiSpark's output is 0/1 rather than true/false.

When col1 is BLOB(PRIMARY KEY) type, throws getBinary not supported.

When col1 is DATE type, the result answer is INCORRECT.

When col2 is BOOLEAN, BIT type, the result answer is INCORRECT.

When col2 is BLOB type, throws getBinary not supported.

Test complete, closing.


Design a better UI

Improve the UI design, since right now it is pretty basic and only implemented for quick interactive testing.
Some things to consider in improvements:

[x] Model string methods
[x] What to display on templates
[x] What fields to include in tables
[ ] Ensure consistency between how different models are displayed
[x] Choose Icons for buttons, dropdowns, etc.
[ ] Add more information and instructions where necessary.
[x] Change "Add" to "Create" in the navbar (to differentiate from "import").
[x] Make sure buttons are consistent (save, create, add, import)
[x] Change group detail page to "View groups in this group" and "View accounts in this group". Also mention only direct members
[x] Show groups and members in alphabetical order
[x] in WorkspaceGroupAccessForm, Change "can compute" to be more informative - "Allow compute in this workspace"
[x] Use "share" instead of "access" when giving groups access to a workspace - eg "share a workspace with a group"

Partially addressed in #248

Typo on the “add group to workspace” page:
A “Reader” can see data int the workspace.


Cutsom response without ORM Model

Hello!
I've tried to make custom route with custom controller and I want to send to client some calculated data. But I couldnt wrap this data to API Response
Route
    JsonApi::register('default')->routes(function ($api) {         $api->get('/Food', 'FoodController@index');     });
Controller #1
`        $obj = new \stdClass();
$obj->name = "Foo";
    $data = json_api()->encoder()->serializeData($obj);
    return json_api()->encoder()->encodeData($data);`

Error
No JSON API resource type registered for PHP class stdClass.
or other way
Controller #2
`        $arr = ['foo' => 'bar'];
    $data = json_api()->encoder()->serializeData($arr);
    return json_api()->encoder()->encodeData($data);`

Error
get_class() expects parameter 1 to be object, string given
So, the questions

How I can return custom data from that controller?
How I can make Schema & Adaptor for Instance not based on Eloquent (because I want to have url for calculated object without DB table)?

Thank you.

When you use serializeData or encodeData, it's expecting the PHP classes that you register in the resources part of your API's config. I.e. passing in a \stdClass is not going to work, because there is no schema for it.
The encoder that this package uses expects a PHP class to have a registered schema. Therefore if you want to do a schema for non-Eloquent data, it needs to have a PHP class. We tend to use entity classes for this kind of thing... then you can run the generators, e.g. make:json-api:resource with the  flag to indicate you want the generated adapter/schema etc to not relate to an Eloquent model.

Closing this due to lack of activity.


Include logger name for java util log handler

Current behavior
I am using logback in my application and a bridge handler so that JUL (java.util.logging) messages are logged.
As is common in a java application, my logging pattern includes the logger name.  For log messages from asciidoc, I get unknown.jul.logger as the logger name for log messages from asciidoc.
Preferred behavior
After a look at the asciidoctorj code, I only one logger named asciidoctor.
It would be nice if I saw asciidoctor in my logs rather than unknown.jul.logger.
Action
I've tested a fix locally for this will be happy to submit a PR.

Hi Lee!
Thank you!
Interesting, I thought that logging a LogRecord would use its name like all other log methods do.
Just saw in the sources that this is apparently not the case.
It would be great if you could provide a PR.

You are most welcome, thanks for all the hard work on asciidoctor!


CQs plus offset in GROUP BY

Did some testing and we should probably document this behavior.
If a CQ is set up with an offset in the GROUP BY clause, the CQ will execute the query with the proper offset, but the query will be run at intervals that don't include the offset. For example, a CQ with the clause GROUP BY time(1d, 3h) will run at 00:00 UTC but the WHERE time clause will start at 03:00 UTC and end at 02:59 UTC the following day.
As a user, I would expect the CQ to execute at 03:00 if I have an offset in the GROUP BY. Probably should put this on the CQ page, or FEI, or maybe the GROUP BY offset section.

@jwilder @pauldix is this an intentional design decision, or just a consequence of the CQ scheduler not being aware of GROUP BY offsets? Ideally CQs would be delayed or accelerated by the offset if it exists.

Until https://github.com/influxdata/influxdb/issues/7025 is fixed, we should plan to document this on FEI and CQ pages.

Partially fixed by: https://github.com/influxdata/docs.influxdata.com/commit/4cf51cd7bd4e0295fe626959b3cae4f3aa807dbc. Still need to add to FEI.


Update Protocol Buffers to latest stable version

We're using 3.7.0 now, checklist:

tools/install-dependencies
Dockerfile
macOS / Linux CI

Latest version is 3.10.1 (from Oct 29; for 3.11 only RCs exist yet)

should we leverage some package manager to easily update dependency? Hunter, vcpkg etc

Update: protobuf 3.11.0 has been just released
https://github.com/protocolbuffers/protobuf/releases

https://github.com/grpc/grpc/issues/21334  (created by me).
Grpc-protobuf 1.25 brings in protobuf 3.10, which has a bug on Android.
Options:

wait for new grpc-protobuf
go with older protobuf 3.9.0, grpc-protobuf 1.24.

Changes merged, builds completed, docker image also completed.  Closing issue.


Update CONTRIBUTING.rst to include correct Makefile targets.

Hi, I'm just getting started with developing on HTTPie. I was going
through the contributing guide and noticed that a couple of the make
commands seem a little stale.

Coverage remained the same at 93.605% when pulling 8841b8bf4638417038929bf2c7828098bbce40ad on gtback:update-contributing-rst into 95c33e31a2f7d35fb8cae3b4a392bb640503c3de on jakubroztocil:master.

Thanks!


⚠ Bofrost.es has degraded performance

In 267fc33, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1525 ms

Resolved: Bofrost.es performance has improved in 63b14ce after 8 minutes.


Defer code execution and unblock the main thread while maintaining payload accuracy @snowplow/browser-tracker | core

We are currently optimizing our single page application towards faster visual feedback on user interactions.
Within our application, the browser has to do (a lot of) work when a user interacts with the page and e.g. performs a click. This includes capturing user behavior by running tracking events and blocking the main thread while doing so.
Currently, when we schedule an event to be tracked with trackSelfDescribingEvent() from the @snowplow/browser-tracker library, we provide information about the event to be tracked:
We pass event atomics and custom context data when calling the tracking event. But we are not able to build and provide the full payload when making this call. So later on the library will enhance the tracking payload with additional (contextual) information, for example the page_url the event was sent from (as of our current understanding).
The current implementation of this tracking function does not allow us to schedule a tracking event with all the necessary information collected upfront and thus become independent of any delays in its execution.

The solution we'd like
We would like to be able to defer event tracking executions while maintaining event payload accuracy, by providing the entire payload upfront when we schedule the call.
Alternatives we've considered
We have considered identifying parts of the payload that change between the scheduling and execution of events and possibly providing them additionally as custom properties or context. This would unnecessarily bloat the payload with duplicate and sometimes incorrect information, and also cause confusion when processing the data.
Additional context
We are open to contributing and/or supporting further by providing more specifics and/or resources.
We were also wondering if this is already possible and just not documented or has been overseen.
https://web.dev/articles/optimize-long-tasks

After analysing more performance profiles, it becomes clear what is "expensive" about the current tracking solution:
Every beforeTrack call will enrich the payload builder with so called browser properties. A few of them like viewport, documentSize and screenResolution are expensive calls.
Why are they expensive? Because they involve properties like innerWidth, innerHeight, clientWidth, clientHeight and scrollHeight. If you try to use one of these, the browser has to actually calculate the size and thus will execute recalculateStyles to determine the current pixel value - this has a certain cost and will be much more time in complex web applications.
It is clearly visible in a performance profile too:

-> The purple "Recalculate Style" block should not be there underneath beforeTrack
TLDR;
I'm currently working on a change that would improve this behavior by using a ResizeObserver and not grabbing these properties synchronously on every track() call

Here would be my PR to fix this behavior :)
https://github.com/snowplow/snowplow-javascript-tracker/pull/1294

@igneel64 Do you may have any other alternatives in mind which could help us mitigate on these performance issues we're facing currently? What do you think about the mentioned issue?
The changes suggested by @rvetere would drastically minimize the performance overhead; although they would not completely decouple e.g. click tracking from the handling of clicks in terms of ui updates.

First of all, thank you @dg-j7i for raising this issue and @rvetere for contributing the PR! Sorry for the delay, we will give this a deep review next week, discuss in the team and come back to you!

@dg-j7i @rvetere an update from our side – we have discussed the proposed approach (the one in the PR) in the team and we are in line with going in this direction! We're still testing this though, will add a review in the PR next week.

I see the javascript-tracker package is published and up to date. 🎉
Will the update fort the browser-tracker package also be available soon?
We look forward to seeing the performance improvements reflected in our web vitality metrics.
Thanks again

Hi @dg-j7i, the browser-tracker should already be updated on NPM, look for version 3.23.0.
The thanks goes to you! Thanks for raising this and contributing the solution! Happy to hear any feedback you might have about this.

Closing as this was released in version 3.23.0.


[Bug]: Database change execution error

ODC version
odc422
OB version
ob421
What happened?
odc422

odc413

What did you expect to happen?
Execution succeeded
How can we reproduce it (as minimally and precisely as possible)?
Execute within database changessql：show trace format='json'
Anything else we need to know?
No response
Cloud
No response

It works for me after re-deploying the test environment.

duplicated, #684


linking error multi definition of offload code

Use reproducer linking.zip
$ sh build.sh
error: Linking globals named '__omp_offloading_10304_1e81eac__ZN3fooIfEC1Ev_l7_exec_mode': symbol multiply defined!
clang-8: error: amdgcn-link command failed with exit code 1 (use -v to see invocation)

When the offload compiler flags are removed, the code links well.

Issue was replicated and code was added to use identifying information from the includer file instead of the includee (t.h) file so that the symbol name is unique. This fix will most likely be implemented in our next release of AOMP (0.7-1).

The fix can also be found in our latest release 0.7-2.

I confirm that the issue has been fixed in 0.7-2.


[NTV-94] Removal (most) of GraphSchema

📲 What
As the final step in our Apollo integration, here is a clean up of the model objects and query enums/structs that allowed us to use GQL without Apollo.
With this final PR, we no longer have any support for the GraphQL Schema and conclude the app's dependence on the schema. We are using Apollo in 100% of non-v1 calls in the app.
🤔 Why
Background in the JIRA Epic.
🛠 How
Started by removing all the Query related enums and structs from GraphSchema.
Built project found dependencies to the schema, removed those with Graph prefixes, including their tests and template files.
A really good sign that none of these changes effect the existing functionality of the app is that no application logic has changed. Only models, tests, and templates (which are almost exclusively used in tests). No view model, view controller, view, networking layer has been changed to support these changes.
So that gives us confidence these are are deprecated files.
GraphComment and GraphUser were left in only in name, as they are referenced in envelopes that get created by GraphAPI Data (PostCommentEnvelope and <UserEnvelope<GraphUser> respectively). These objects have no connections to GraphSchema properties.
✅ Acceptance criteria

[x] Run the app, back a project, leave a comment, manage a backing, select a new reward, see that it all works as expected.

Everything in the acceptance criteria is g2g!

GraphCategory, GraphCountry, GraphComment, GraphMutationPostCommentEnvelope and GraphUser should all be removed as well but they will be a bit gnarly to approach.

Good call, I know GraphCountry was not being used anymore, so I removed it, however the others:

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


to_pandas conversion doesn't always work and output numpy arrays instead of lists

For some complex nested types, the conversion from Arrow to python dict through pandas doesn't seem to be possible.
Here is an example using the official SQUAD v2 JSON file.
This example was found while investigating #373.
>>> squad = load_dataset('json', data_files={nlp.Split.TRAIN: ["./train-v2.0.json"]}, download_mode=nlp.GenerateMode.FORCE_REDOWNLOAD, version="1.0.0", field='data')
>>> squad['train']
Dataset(schema: {'title': 'string', 'paragraphs': 'list<item: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>>'}, num_rows: 442)
>>> squad['train'][0]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/thomwolf/Documents/GitHub/datasets/src/nlp/arrow_dataset.py", line 589, in __getitem__
    format_kwargs=self._format_kwargs,
  File "/Users/thomwolf/Documents/GitHub/datasets/src/nlp/arrow_dataset.py", line 529, in _getitem
    outputs = self._unnest(self._data.slice(key, 1).to_pandas().to_dict("list"))
  File "pyarrow/array.pxi", line 559, in pyarrow.lib._PandasConvertible.to_pandas
  File "pyarrow/table.pxi", line 1367, in pyarrow.lib.Table._to_pandas
  File "/Users/thomwolf/miniconda2/envs/datasets/lib/python3.7/site-packages/pyarrow/pandas_compat.py", line 766, in table_to_blockmanager
    blocks = _table_to_blocks(options, table, categories, ext_columns_dtypes)
  File "/Users/thomwolf/miniconda2/envs/datasets/lib/python3.7/site-packages/pyarrow/pandas_compat.py", line 1101, in _table_to_blocks
    list(extension_columns.keys()))
  File "pyarrow/table.pxi", line 881, in pyarrow.lib.table_to_blocks
  File "pyarrow/error.pxi", line 105, in pyarrow.lib.check_status
pyarrow.lib.ArrowNotImplementedError: Not implemented type for Arrow list to pandas: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>

cc @lhoestq would we have a way to detect this from the schema maybe?

Here is an example:
>>> dataset._data.slice(key, 1).to_pandas().to_dict("list")
{'sentence1': ['Amrozi accused his brother , whom he called " the witness " , of deliberately distorting his evidence .'], 'sentence2': ['Referring to him as only " the witness " , Amrozi accused his brother of deliberately distorting his evidence .'], 'label': [1], 'idx': [0], 'input_ids': [array([  101,  7277,  2180,  5303,  4806,  1117,  1711,   117,  2292,
        1119,  1270,   107,  1103,  7737,   107,   117,  1104,  9938,
        4267, 12223, 21811,  1117,  2554,   119,   102])], 'token_type_ids': [array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
       0, 0, 0])], 'attention_mask': [array([1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
       1, 1, 1])]}
>>> dataset._data.slice(key, 1).to_dict()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'pyarrow.lib.Table' object has no attribute 'to_dict'
>>> dataset._data.slice(key, 1).to_pydict()
{'sentence1': ['Amrozi accused his brother , whom he called " the witness " , of deliberately distorting his evidence .'], 'sentence2': ['Referring to him as only " the witness " , Amrozi accused his brother of deliberately distorting his evidence .'], 'label': [1], 'idx': [0], 'input_ids': [[101, 7277, 2180, 5303, 4806, 1117, 1711, 117, 2292, 1119, 1270, 107, 1103, 7737, 107, 117, 1104, 9938, 4267, 12223, 21811, 1117, 2554, 119, 102]], 'token_type_ids': [[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]], 'attention_mask': [[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]]}

Could you try to update pyarrow to >=0.17.0 ? It should fix the to_pandas bug
Also I'm not sure that structures like list are fully supported in the lib (none of the datasets use that).
It can cause issues when using dataset transforms like filter for example


Browser Extension

First of all, really cool!
For the last couple years I've always been thinking about a lot when it comes to "semantic" understanding of real world entities. I got that excitement from my first internship at now defunct company called Apture.
A little later, I've actually tried to create an extension of mine in https://github.com/nambrot/erutpa. However, I abandoned it quite shortly after due to a lack of reliable data sources as I used Freebase.
I really love the concept behind Reality as I see a lot of similar ideas and was wondering if there was any plan to make this into a user-product. I very often find myself wanting to understand an Entity when im reading something and having something like Reality power that something would be amazing

Thanks!
I think, reality-based extension can be really cool, though I'm not sure which approach could be possibly used:

either complete port of Reality (and underlying libraries) to JavaScript (this way potential extensio does everythin on itself: fetches data from Wikipedia/Wikidata/other sources, parses it and displays);
provide some reality-powered server proxy, so the extension could just do GET proxy?entity=France and receive pretty json.

The former solution requires a lot of coding (infoboxer library, which Reality relies on for Wikipedia parsing, is 3.5k code lines, several monthes of work and pretty complicated parsing logic).
The latter could be easier, but requires some free/paid server, devops and maintanance tasks.
So, I'm open for proposals but have not enough resource to do it myself :)

I can make a simple app which will eval input string. Also, it can work as API for browser extension. Should be easy and I can support it. Puma server can handle quite a lot of requests in parallel so we can stay on a free plan for a while.

bowser extension is kind of cool because there is a built-in way to store  a config. So when you want to use Extra you can add API tokens on plugin settings page

I think server/proxy route is probably the way to go.Caching this can go a long way.

I totally like the idea, but currently am not ready to do hosting/devops for this.
Have no objections if somebody will :)


Barcode scanner returns different strings in Android an iOS when scanning a UPC-A format code

What's happening?
I am trying to scan upc-a (12 digit) codes which are not directly supported by this library. However, this library does support ean-13 which is a superset standard with an extra digit (13 digit). You can convert any upc-a code to an ean-13 code by just adding a zero to the beginning of the string.
The problem is that, when scanning an upc-a code with the ean-13 codeType enabled, the scanner returns a 13 digit ean-13 code as expected for iOS (it is adding an extra zero to the start of the string). It seems that in Android it is not adding a zero to the start of the string and is returning the original 12 digit code, resulting string is different for each platform.
For example:
Scanning the following code:

returns<PHONE_NUMBER>16 in Android and<PHONE_NUMBER>916 in iOS
Reproduceable Code
import 'react-native-reanimated';
import React, { useEffect } from 'react';
import { StyleSheet, View } from 'react-native';
import { useIsFocused } from '@react-navigation/native';
import { Camera, useCameraDevice, useCodeScanner } from 'react-native-vision-camera';

const ScannerScreen = () => {
  const isFocused = useIsFocused();
  const device = useCameraDevice('back');

  const codeScanner = useCodeScanner({
    codeTypes: ['ean-13'],
    onCodeScanned: (codes) => {
      console.log(codes);
    },
  });

  useEffect(() => {
    void Camera.getCameraPermissionStatus();
  }, []);

  return (
    <>
      <View style={{ flex: 1 }}>
        {isFocused && device && (
          <Camera
            style={StyleSheet.absoluteFillObject}
            device={device}
            isActive={!!device}
            codeScanner={codeScanner}
          />
        )}
      </View>
    </>
  );
};

export default ScannerScreen;

Relevant log output
No logs

Camera Device
Any camera device

Device
Any iOS or Android smartphone
VisionCamera Version
3.3.1
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Yes, it would be nice if the lib supported upc-a especially since BarcodeScannerOptions supports it.

Same, I also need ability to scan upc_a, coming from vision-camera-code-scanner which was deprecated in favour of v3

Same issue. Seems clunky to need to remove the leading 0 in iOS.

I managed to get this working by modifying the android files to include upc-a and running patch-package.
iOS already has the ability to scan upc-a because of ean-13, I just do a check to include the extra digit.

@Gambitboy can you share your patch file please?

@marcshilling Here is the patch file. Its quite a big. Not sure why, as it wasn't a lot of changes.
I still have a type issue for upc-a which I haven't resolved yet.
https://gist.github.com/Gambitboy/0a2afa2485fd7c285a52b093de1c32b2

I have a similar issue. On android it can scan multiple barcodes an returns an array with all the barcodes scanned but on ios it returns only one item.

On iOS I use the native QR scanner from Apple, on Android I use Google's MLKit model. If there are differences, there's nothing I can do.
You can instead write a custom Frame Processor Plugin to use the same libs on both devices, or something like ZXing.

Hi ! MLKit actually provides support for upc-a ! "The following formats are supported: [...] UPC-A (FORMAT_UPC_A)". Sorry for tagging you @mrousavy, but do you consider in supporting it in your lib ? Thanks a lot !!

Hey @Couzix - Apple's Vision library doesn't support UPC-A though, so it would not be a cross-platform feature, which I like to avoid.

When I read through the apple docs it said it indirectly supported upc-a through ean. So once I added the missing code for android both devices types were able to scan a upc-a code.

Oh, interesting. Well I guess I could add those types and just mark them as @platform Android then..

I'll quickly try to find the docs mentioning it, also since its working on my project. I don't mind doing a pull request. The only bit I never got to finish was type checking the UPC-A for android


beta-reducing method applications?

(Sorry for asking this here, I can't find a mailing list for users)
After some number of repeated inlineR, betaReduceR and caseReduceUnfoldR Trues, HERMIT is transforming a program to:
(+ @ Int
   (D:Num
      @ Int
      (\ (ds_a1nJ [Occ=Once!] :: Int) (ds1_a1nK [Occ=Once!] :: Int) ->
         case ds_a1nJ of _ [Occ=Dead] { I# x_a1nN [Occ=Once] ->
         case ds1_a1nK of _ [Occ=Dead] { I# y_a1nR [Occ=Once] ->
         I# (+# x_a1nN y_a1nR)
         }
         })
      (\ (ds_a1nT [Occ=Once!] :: Int) (ds1_a1nU [Occ=Once!] :: Int) ->
         case ds_a1nT of _ [Occ=Dead] { I# x_a1nX [Occ=Once] ->
         case ds1_a1nU of _ [Occ=Dead] { I# y_a1o1 [Occ=Once] ->
         I# (-# x_a1nX y_a1o1)
         }
         })
      (\ (ds_a1o3 [Occ=Once!] :: Int) (ds1_a1o4 [Occ=Once!] :: Int) ->
         case ds_a1o3 of _ [Occ=Dead] { I# x_a1o7 [Occ=Once] ->
         case ds1_a1o4 of _ [Occ=Dead] { I# y_a1ob [Occ=Once] ->
         I# (*# x_a1o7 y_a1ob)
         }
         })
      (\ (ds_a1od [Occ=Once!] :: Int) ->
         case ds_a1od of _ [Occ=Dead] { I# x_a1og [Occ=Once] ->
         I# (negateInt# x_a1og)
         })
      (\ (n_a1oi [Occ=Once!] :: Int) ->
         case n_a1oi of _ [Occ=Dead] { I# x_a1ol ->
         case tagToEnum# @ Bool (>=# x_a1ol 0) of _ [Occ=Dead] {
           False -> I# (negateInt# x_a1ol);
           True -> I# x_a1ol
         }
         })
      (\ (n_a1os [Occ=Once!] :: Int) ->
         case n_a1os of _ [Occ=Dead] { I# x_a1ov ->
         case tagToEnum# @ Bool (<# x_a1ov 0) of _ [Occ=Dead] {
           False ->
             case x_a1ov of _ [Occ=Dead] {
               __DEFAULT -> I# 1;
               0 -> I# 0
             };
           True -> I# (-1)
         }
         })
      (\ (i_a1oG :: Integer) ->
         case integerToInt i_a1oG of _ [Occ=Dead] { __DEFAULT ->
         I# (integerToInt i_a1oG)
         }))
   (I# 1)
   (I# 2))

At this point it gets stuck, but I'd like to make some more progress here. Typeclass dictionary is already resolved, so it shouldn't be too hard to find method RHS and reduce generic + to:
(\ (ds_a1nJ [Occ=Once!] :: Int) (ds1_a1nK [Occ=Once!] :: Int) ->
         case ds_a1nJ of _ [Occ=Dead] { I# x_a1nN [Occ=Once] ->
         case ds1_a1nK of _ [Occ=Dead] { I# y_a1nR [Occ=Once] ->
         I# (+# x_a1nN y_a1nR)
         }
         })

Then betaReduceR and caseReduceUnfoldR could work further and reduce the whole thing to:
I# 3

Is there a way to do that?
Thanks.

(There isn't a mailing list... reporting here on Github issues is great. Or your can email me directly if you prefer.)
If you focus on the application of + and attempt to inline or unfold, does it give an error message about there not being an unfolding available? I would have expected the + to inline just fine.
If you have an example target program and script, I can try it out.

For instance, using the following target program:
main :: IO ()
main = print (2 + (3::Int))

I can:
$ hermit Math.hs
hermit<0> rhs-of 'main
print ▲ $fShowInt ((+) ▲ $fNumInt (I# 2) (I# 3))
hermit<1> app-arg
(+) ▲ $fNumInt (I# 2) (I# 3)
hermit<2> repeat (any-td (unfold <+ case-reduce-unfold))
case I# 2 of wild ▲
  I# x →
    case I# 3 of wild1 ▲
      I# y → I# ((+#) x y)

I just tried same commands but they produced different results:
➜  pe-plugin git:(master) ✗ cat hermit_test.hs
main :: IO ()
main = print (2 + (3 :: Int))
➜  pe-plugin git:(master) ✗ hermit hermit_test.hs
[starting HERMIT v<IP_ADDRESS> on hermit_test.hs]
% ghc hermit_test.hs -fforce-recomp -O2 -dcore-lint -fsimple-list-literals -fexpose-all-unfoldings -fplugin=HERMIT -fplugin-opt=HERMIT:*:
[1 of 1] Compiling Main             ( hermit_test.hs, hermit_test.o )
===================== Welcome to HERMIT ======================
HERMIT is a toolkit for the interactive transformation of GHC
core language programs. Documentation on HERMIT can be found
on the HERMIT web page at:
http://www.ittc.ku.edu/csdl/fpg/software/hermit.html

You have just loaded the interactive shell. To exit, type
"abort" or "resume" to abort or resume GHC compilation.

Type "help" for instructions on how to list or search the
available HERMIT commands.

To get started, you could try the following:
  - type "binding-of 'foo", where "foo" is a function
    defined in the module;
  - type "set-pp-type Show" to display full type information;
  - type "info" for more information about the current node;
  - to descend into a child node, type the name of the child
    ("info" includes a list of children of the current node);
  - to ascend, use the "up" command;
  - type "log" to display an activity log.
==============================================================

module Main where
  main ∷ IO ()
  main ∷ IO ()
hermit<0> rhs-of 'main
print ▲ $fShowInt ((+) ▲ $fNumInt (I# 2) (I# 3))
hermit<1> app-arg
(+) ▲ $fNumInt (I# 2) (I# 3)
hermit<2> repeat (any-td (unfold <+ case-reduce-unfold))
(+) ▲
    (D:Num ▲
           (λ ds ds1 →
              case ds of wild ▲
                I# x →
                  case ds1 of wild1 ▲
                    I# y → I# ((+#) x y))
           (λ ds ds1 →
              case ds of wild ▲
                I# x →
                  case ds1 of wild1 ▲
                    I# y → I# ((-#) x y))
           (λ ds ds1 →
              case ds of wild ▲
                I# x →
                  case ds1 of wild1 ▲
                    I# y → I# ((*#) x y))
           (λ ds →
              case ds of wild ▲
                I# x → I# (negateInt# x))
           (λ n →
              case n of wild ▲
                I# x →
                  case tagToEnum# ▲ ((>=#) x 0) of wild1 ▲
                    False → I# (negateInt# x)
                    True → I# x)
           (λ n →
              case n of wild ▲
                I# x →
                  case tagToEnum# ▲ ((<#) x 0) of wild1 ▲
                    False →
                      case x of wild2 ▲
                        _ → I# 1
                        0 → I# 0
                    True → I# (-1))
           (λ i →
              case integerToInt i of wild ▲
                _ → I# (integerToInt i)))
    (I# 2) (I# 3)
hermit<3>

HERMIT version:
[starting HERMIT v<IP_ADDRESS> on --version]
% ghc --version -fforce-recomp -O2 -dcore-lint -fsimple-list-literals -fexpose-all-unfoldings -fplugin=HERMIT -fplugin-opt=HERMIT:*:
The Glorious Glasgow Haskell Compilation System, version 7.10.1

I also tried HEAD version but got same results. Could it be related with GHC version?

Interesting... I'm guessing the version of base that ships with 7.10 provides different unfolding information than it did with 7.8 (what I'm using). I'll set up 7.10 tonight and try.
That is most unfortunate. If you unfold instead of the repeat ... line, what error is given?


Kubens help text shows wrong executable name

When running kubens -h, the output shows kubectx instead of kubens in the usage examples:
$ kubens -h
USAGE:
  kubectx                    : list the namespaces in the current context
  kubectx <NAME>             : change the active namespace of current context
  kubectx -                  : switch to the previous namespace in this context
  kubectx -c, --current      : show the current namespace
  kubectx -h,--help          : show this message

This is on version 0.9.0 running on Ubuntu 20.04, obtained from the kubens_v0.9.0_linux_x86_64.tar.gz asset in the releases page.

#210 fixed this but not released yet.


Role bug fixes

Correct regressions introduced by #5 and #6.
Ensure database access through psql -U postgres is possible before continuing
Fix mangled configuration file.

thx

Good spot @willthames. Sorry for not testing properly.

No worries @nbrl. I learned a valuable lesson in pinning my role versions (something you have to do by pointing at the github repo directly rather than using galaxy.ansible.com, as far as I can tell)

@willthames always a good lesson - I have been using a requirements.txt type thing with the -r switch to specify a role from galaxy, e.g. username.role_name,version in a text file. Looking back at the docs in Ansible >= 1.8, they have a yaml format config as well, so I am using something like:
---
- src: galaxy_user.galaxy_role
  path: path/to/roles
  version: commit hash

Then install with ansible-galaxy -r path/to/file/above.yml which is quite nice.

@willthames Good point
I have updated the galaxy role
i will try not to forget this every time there is a change

@nbrl, yeah I wrote the code behind that. Doesn't mean I always follow my
own best practices! Oops.
On 13 Mar 2015 6:59 pm, "nbrl"<EMAIL_ADDRESS>wrote:

@willthames https://github.com/willthames always a good lesson - I have
been using a requirements.txt type thing with the -r switch to specify a
role from galaxy, e.g. username.role_name,version in a text file. Looking
back at the docs http://docs.ansible.com/galaxy.html#id8 in Ansible >=
1.8, they have a yaml format config as well, so I am using something like:
---- src: galaxy_user.galaxy_role
path: path/to/roles
version: commit hash
Then install with ansible-galaxy -r path/to/file/above.yml which is quite
nice.
—
Reply to this email directly or view it on GitHub
https://github.com/Open-Future-Belgium/PostgreSQL/pull/7#issuecomment-78875507
.

That might be too strong a claim. But a lot of the 1.8 galaxy changes were
influenced by changes I made to use it with arbitrary repos
On 13 Mar 2015 7:15 pm, "Will Thames"<EMAIL_ADDRESS>wrote:

@nbrl, yeah I wrote the code behind that. Doesn't mean I always follow my
own best practices! Oops.
On 13 Mar 2015 6:59 pm, "nbrl"<EMAIL_ADDRESS>wrote:

@willthames https://github.com/willthames always a good lesson - I
have been using a requirements.txt type thing with the -r switch to
specify a role from galaxy, e.g. username.role_name,version in a text
file. Looking back at the docs http://docs.ansible.com/galaxy.html#id8
in Ansible >= 1.8, they have a yaml format config as well, so I am using
something like:
---- src: galaxy_user.galaxy_role
path: path/to/roles
version: commit hash
Then install with ansible-galaxy -r path/to/file/above.yml which is
quite nice.
—
Reply to this email directly or view it on GitHub
https://github.com/Open-Future-Belgium/PostgreSQL/pull/7#issuecomment-78875507
.

@willthames always the way! @willthames @Trikke76 - thanks all :)


 I'm really impressed by all the progress you've made, please make sure to clean up (most my comments are just reminders to remove or update comments). please fix and re-request my review, and remember to make any other changes (unrelated to the comments) in a new branch/PR

Great job! I'm really impressed by all the progress you've made, please make sure to clean up (most my comments are just reminders to remove or update comments). please fix and re-request my review, and remember to make any other changes (unrelated to the comments) in a new branch/PR

So many thanks for your feedback~. I have submitted a new PR

Merge week3's work to main


Broken link to language-babel

In the readme, there needs to be an https protocol prepended to the language-babel link, otherwise it is relative to the GitHub address, linking to https://github.com/blaqbern/eclectic-syntax/blob/master/atom.io/packages/language-babel instead of https://atom.io/packages/language-babel.

You are correct, Sir!
Thank you!