XMonad.Actions.Navigation2D issue with XMonad.Layout.Spacing

Problem Description
I use XMonad.Actions.Navigation2D to navigate between windows in an XMonad.Layout.BinarySpacePartition layout.
The problem arises when I have a window bordering an even amount n of other windows,
so that each of the other windows takes up an nth of the window border in question.
When I add XMonad.Layout.Spacing to my configuration,
I can't switch from the large window to any of the other windows, since it seems to try to focus an element in the middle of the border (where there is a gap due to the use of XMonad.Layout.Spacing).
Steps to Reproduce
Run XMonad with the config specified below.
Hit Super + Shift + Enter 3 times to get the most common scenario matching the problematic situation described above.
Use Super + [Arrow Keys] to navigate from the most recently opened small window to the large window.
Use Super + [Arrow Keys] to try to navigate back to either of the small windows.
Configuration File
import XMonad
import XMonad.Layout.BinarySpacePartition
import XMonad.Layout.BorderResize
import XMonad.Layout.Spacing
import qualified Data.Map as M

main = xmonad $ settings

layout = spacing 10 $ (borderResize (emptyBSP))

keybinds conf@(XConfig {XMonad.modMask = modm}) = M.fromList $
  [ ((modm, xK_q               ), spawn "xmonad --recompile; xmonad --restart"),
    ((modm, xK_Right                      ), windowGo R False                 ),
    ((modm, xK_Left                       ), windowGo L False                 ),
    ((modm, xK_Up                         ), windowGo U False                 ),
    ((modm, xK_Down                       ), windowGo D False                 ),
    ((modm .|. shiftMask, xK_Right        ), windowSwap R False               ),
    ((modm .|. shiftMask, xK_Left         ), windowSwap L False               ),
    ((modm .|. shiftMask, xK_Up           ), windowSwap U False               ),
    ((modm .|. shiftMask, xK_Down         ), windowSwap D False               ),
    ((modm .|. shiftMask, xK_q            ), io(exitWith ExitSuccess)         ),
    ((modm .|. shiftMask, xK_Return       ), spawn $ XMonad.terminal conf     ),
    ((modm .|. shiftMask, xK_c            ), kill                             )]

settings = def {
  layoutHook = layouts,
  modMask = mod4Mask,
  keys = keybinds
}

"Proposed Solution"
Switch to the rightmost/topmost window on the other side of the border,
instead of the one in the middle (where a gap might be).
"Proposed Solution" because I don't know what effects it would have or whether it's possible at all.

The documentation mentions sideNavigation as "probably the most intuitive strategy for the
-- tiled layer when using XMonad.Layout.Spacing"; does that fix your issue?
main :: IO ()
main = xmonad
     . withNavigation2DConfig def{ defaultTiledNavigation = sideNavigation }
     $ settings

Oh, I didn't see that - it fixed my problem excellently!
Also thanks for the help in interesting it!


fix(Dropdown): added role/aria attributes to Dropdown and DropdownItem

This will fail tests until #1005 lands, but I wanted to get feedback on what I've done and the problems I ran into making the Dropdown truly accessible.
Things accomplished in this pull request

adds a role="listbox" to the normal Dropdown component
adds a role="combobox" to the Dropdown component in search mode, with DropdownMenu getting role="listbox"
adds a role="menuitem" to the Dropdown component if rendered as a Menu.Item, with DropdownMenu getting role="menu"
adds a role="option" to the DropdownItem component
adds aria flags for disabled, busy, expanded on the Dropdown component
adds aria flags for disabled, checked, selected on DropdownItem component
adds aria flags for multiselectable on Dropdown normal component, and DropdownMenu search components
sets an aria-autocomplete="list" on the input field for search Dropdowns

So this mostly works in bringing it up to some basic accessibility standards.
So let me dump some thoughts here for discussion:
listbox/option vs menu/menuitem
So one thing that will probably jump out to you is how similar listbox/option is to menu/menuitem. I've been reading up a lot on them and menu's are truly used for desktop style menus, where you drop down an entry and trigger an action and it goes away. This is backed up by this article: https://www.marcozehe.de/2014/03/11/easy-aria-tip-7-use-listbox-and-option-roles-when-constructing-autocomplete-lists/ Dropdowns are really a fancy select vs a real menu. EXCEPT when Dropdowns are added to Menu components, then they really are menu/menuitems. So I added an if statement to check if the as prop === Menu.Item. Not 100% certain the best way to switch the dropdown item from role=option to role=menuitem (though menuitemcheckbox might be better, need to ponder that one), thoughts?
combobox and search dropdowns
So this is where things get a little weird. Dropdowns can act like combobox's in search mode. So the roles and markup changes under those circumstances. I'm taking a lot of this from here: https://www.w3.org/TR/wai-aria-1.1/#combobox which has a nice pretty example to follow that follows a similar stucture to this Dropdown. I had to add the type="text" to the input to get the role="textbox", and the listbox role and aria-multiselectable had to move to the DropdownMenu since aria-multiselectable isn't a valid option for combobox. Now this leads into the next problem.
problems with ids
Most accessibility attributes use page ids to link separate dom elements together. So for the combobox, it wants to have 2 ids:

aria-owns and aria-controls both need an id to identify the listbox the combobox is controlling
aria-activedescendant needs an id of the selected dropdown menu item

The first solution that comes to mind for me is to allow an id prop, with a default prop of some ComponentName + incrementingCounter. Thoughts?
sub dropdowns
Whenever support gets added for sub menus, the flag aria-haspopup=true needs to be set, thoughts on where to put that so it isn't forgotten?

This one will require a little more focus than I have ATM, marked it for review for later.

no rush, the dropdown is a really complicated module. I've gone through like 20 iterations of my implementation. I think I'm at a stopping point, I've been updating the description of this ticket as I refine my approach.

I've fixed the outage with CircleCI, rebased this branch, and force pushed to trigger a new build.

Current coverage is 99.74% (diff: 100%)

Merging #1006 into master will increase coverage by <.01%

@@             master      #1006   diff @@
==========================================
  Files           140        140
  Lines          2304       2323    +19
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2298       2317    +19
  Misses            6          6
  Partials          0          0

Powered by Codecov. Last update 9e61f88...9faae2d

So I was looking into how to do the Menu component and I feel like normall it's a listbox/option, unless it has a Dropdown as a Menu.Item AND is fixed top/bottom or attached top/bottom, at which point the entire menu becomes a menu/menuitem. So is it kosher to peer into your children to check their types and see if there's a Dropdown in there? Would love some ideas on how to detect that.

Unfortunately, I know of no good way to check your children.  This is problematic in React.  Perhaps we just wrap this up where it is for now and come back later if/when we split things up and refactor at that time?
If you agree on this, let's just pull the .skip() from the last commit.  If that test will not be applicable, let's comment it out with a TODO.  There is a lint rule that prevents only/skip in tests that should have actually failed this build.

I've removed all references of Menu from the Dropdown component, I also added in an aria-hidden to the hidden select menu to squash some errors I'm seeing in my project. This should be good to go for now

While I say this is good to go, there's still an outstanding issue regarding aria-activedescendant and aria-owns/controls for the search/combobox

Great, thanks for the work.  The attention to detail and correctness is much appreciated.  We'll get there with small steps :)

Released in<EMAIL_ADDRESS>


fix: Change person_generation filter from allow_all to allow_adult in imagen3_image_generation notebook

Description
The imagen3 model requires a person_generation filter. This is currently set to "allow_all" in the notebook which will not work unless one has specifically been given access to this. The most common filter that will work is "allow_adult". Hence this change sets the filter values to "allow_adult".
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Follow the CONTRIBUTING Guide.
[ ] You are listed as the author in your notebook or README file.

[ ] Your account is listed in CODEOWNERS for the file(s).

[X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[X] Appropriate docs were updated (if necessary)

Fixes #1018 🦕

What is this error that is showing up in the check-links task? Is this an issue with my PR or is this an issue with the github actions environment?
Does anyone know?
error log from the workflow ->
Run marocchino/sticky-pull-request-comment@v2
##[debug]followSymbolicLinks 'false'
##[debug]matchDirectories 'false'
##[debug]followSymbolicLinks 'false'
##[debug]implicitDescendants 'true'
##[debug]matchDirectories 'false'
##[debug]omitBrokenSymbolicLinks 'true'
##[debug]Search path '/home/runner/work/generative-ai/generative-ai/lychee/out.md'
Error: Resource not accessible by integration

What is this error that is showing up in the check-links task? Is this an issue with my PR or is this an issue with the github actions environment?
Does anyone know?
error log from the workflow ->
Run marocchino/sticky-pull-request-comment@v2 ##[debug]followSymbolicLinks 'false' ##[debug]matchDirectories 'false' ##[debug]followSymbolicLinks 'false' ##[debug]implicitDescendants 'true' ##[debug]matchDirectories 'false' ##[debug]omitBrokenSymbolicLinks 'true' ##[debug]Search path '/home/runner/work/generative-ai/generative-ai/lychee/out.md' Error: Resource not accessible by integration

Don't worry about this error. I just added this integration, but it doesn't seem to work from forks.


fix: Application is crashing when push config is missing

Motivation
Fix application crashing when push configuration is missing. This is even more critical than Auth as push is being initialized on start making application unusable.

Basic rule of thumb: We should never use ! in swift especially when handling json that can change format.


Add etcd-operator to CI

Fixes #5120
Depends on https://github.com/cilium/cilium/pull/5297

This change is

test-me-please

test-me-please

test-me-please

I tried running k8s cluster and got
level=fatal msg="Unable to setup kvstore" address= error="open /var/lib/etcd-secrets/etcd-client.crt: no such file or directory" kvstore=etcd subsys=daemon

even though etcd operator works fine.

test-me-please

test-me-please

depends on #5385

@aanm Is it intended that the pkg/identity: Wait For Initial Identities for endpoints without fixed identities commit is included in this PR?

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

@aanm I had to kill your build. The Jenkins node went offline and had no free disk. Sorry.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-missed-k8s

test-me-please

test-me-please

test-missed-k8s

test-me-please

test-missed-k8s

it seems the previous build failed because of connection error between kubectl and kube-apiserver

14:59:18 ==> runtime: Loading metadata for box 'cilium/ubuntu'
14:59:18     runtime: URL: https://vagrantcloud.com/cilium/ubuntu
14:59:51 The box 'cilium/ubuntu' could not be found or
14:59:51 could not be accessed in the remote catalog. If this is a private
14:59:51 box on HashiCorp's Vagrant Cloud, please verify you're logged in via
14:59:51 `vagrant login`. Also, please double-check the name. The expanded
14:59:51 URL and error message are shown below:

test-me-please

test-me-please

test-me-please

failed Tests Egress To World unlikely related with my changes https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6511/execution/node/92/log/

test-me-please

test-missed-k8s

run microscope failed https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/866/execution/node/98/log/

test-missed-k8s

test-missed-k8s

test-missed-k8s

test-me-please

test-me-please

prev https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6574/

test-me-please

test-me-please

test-me-please

test-me-please

@eloycoto I know you have left comments during the wip they might haven't been all addressed. Please take a look again. Once this PR is merged I'll revert c24daae and I'll put the tools in the VM

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Only f9399b9a4f8184c85cb86441a039aa0a707df0ea is being backported to v1.2


[FEAT]: expr simplifier

still todo:

[x] add a bunch of test cases.
[ ] add simplification for AND exprs

Note for reviewers:
This bypasses the expr simplifier rule if the source is SQLScanOperator it was simplifying the queries in a way that weren't working with connectorx. I haven't been able to debug exactly what was going on, but I think it's pretty ok to just skip this optimization for this source for now.
Also,  wanted to implement a const expr evaluator, but since our eval_expressions is associated with daft_table::Table, this kind of optimization is not currently possible, and some refactoring is needed.

I'm going to split out "add simplification for AND exprs" into a separate PR.


These examples not working for Tizen OS

The examples provided is not working for tizen os.

See #67. This lib isn't currently tested on Tizen and is unlikely to ever be tested on Tizen, I'm afraid!

lrud v0.0.23 works fine on Tizen TV across all models starting 2018
Tizen 2017 has works width lrud 0.0.18


Use full 4x4 matrix for mapRect operation in Transform layer

After fixing https://github.com/flutter/flutter/issues/82961, we drop down to a 3x3 matrix here: https://github.com/flutter/engine/blob/b9b1b63c2ba99c149f2846ac1c5430084f2ec346/flow/layers/transform_layer.cc#L49
We should do the rect mapping using the full 4x4 transform. Skia has an implementation for this in SkMatrixPriv.
@flar fyi

Ah, I had actually traced that through and found a call to turn it into an M33, but just realized that my IDE is forwarding me to the wrong code. I'll look for the real map rect and splice it in...

Looking at the code in SkMatrixPriv (implemented in SkM44.cpp), it isn't doing anything different from SkMatrix::mapRect except that it handles cases that break the Z plane of the camera more directly whereas SkMatrix uses path clipping instead.
This change would be an optimization, not a correctness fix. We should look at it if we don't implement our own, but there doesn't appear to be a bug here for now.

Would you mind adding a comment to that effect to our usage of it?

Would you mind adding a comment to that effect to our usage of it?

See https://github.com/flutter/engine/pull/43608

This issue will likely be fixed when we move the DisplayList to use the Impeller classes for basic geometry. That work is on the radar, but not yet in progress.


Python: Faulty context variable resolution in SequentialPlanner

Describe the bug
In certain plans, the mechanism for resolving variables is not being applied correctly with functions that take more than one parameter.
Consider a simple case using semantic_kernel.core_skills.MathSkill: "Calculate (10 + 2) - (8 + 7)". The resulting plan (from gpt-3.5-turbo-16k-0613) is:
Function: mathskill.Add
Input vars: {'input': '10', 'amount': '2'}
Output vars: ['SUM1']

Function: mathskill.Add
Input vars: {'input': '8', 'amount': '7'}
Output vars: ['SUM2']

Function: mathskill.Subtract
Input vars: {'input': '$SUM1', 'amount': '$SUM2'}
Output vars: ['RESULT__FINAL_ANSWER']

The plan is correct. But when it comes to evaluation, the last step fails because it doesn't resolve amount to the corresponding result, leaving the string value '$SUM2' unresolved.
To Reproduce
planner = SequentialPlanner(kernel=kernel)
kernel.import_skill(MathSkill(), "mathskill")
plan = asyncio.run(planner.create_plan_async("Calculate (10 + 2) - (8 + 7)"))
result = asyncio.run(kernel.run_async(plan))
for index, step in enumerate(plan._steps):
   print("\nFunction: " + step.skill_name + "." + step._function.name)
   print("Input vars: " + str(step.parameters.variables))
   print("Output vars: " + str(step._outputs))

print("Result: " + str(result))

The final output is:
Result: Error: (<ErrorCodes.FunctionInvokeError: 8>, 'Error occurred while running plan step: Context amount provided is not in numeric format: $SUM2', ValueError('Context amount provided is not in numeric format: $SUM2'))

Expected behavior
$SUM2 should resolve 15, leading to a final plan result of -3.
Platform

OS: Windows 10
IDE: VSCode
Language: Python
Source: 0.3.13.dev0

Additional context
I tried investigating this further by creating a plugin class with the following functions:
class MyMathPlugin:
    @sk_function(
        description="Adds two numbers together",
        name="add",
    )
    @sk_function_context_parameter(
        name="input",
        description="The first number to add",
    )
    @sk_function_context_parameter(
        name="number2",
        description="The second number to add",
    )
    def add(self, context: SKContext) -> str:
        return str(float(context["input"]) + float(context["number2"]))

    @sk_function(
        description="Subtract two numbers",
        name="subtract",
    )
    @sk_function_context_parameter(
        name="input",
        description="The first number to subtract from",
    )
    @sk_function_context_parameter(
        name="number2",
        description="The second number to subtract away",
    )
    def subtract(self, context: SKContext) -> str:
        print(str(context.dict()['variables']))
        input = float(context["input"])
        number2 = float(context["number2"])
        out = str(input - number2)
        print(f'{input} - {number2} => {out}')
        return out

The printed dictionary is as follows:
{'variables': {'input': '12.0', 'number2': '$SUM2', 'sum1': '12.0', 'sum2': '15.0'}}

Interestingly, input is resolved correctly and there is a sum2 variable with the actual result of what number2 should be.
### Tasks

I am also getting the same error

Also having the same issue, causing SequentialPlanner to be unusable.
The problems seems to be in the get_next_step_variables method of the Plan class:
https://github.com/microsoft/semantic-kernel/blob/b2bbd410c07739767b5aad48961a8ced5b4cf4a4/python/semantic_kernel/planning/plan.py#L403-L415
On line 407, the dictionary key (param_var) is incorrectly passed to the expand_from_variables method instead of the corresponding dictionary value. Thus, the value never gets expanded from the literal string "$SUM2" (for example).
Here is some a corrected version of the same code:
# At this stage,
# step.parameters.variable = {'amount': '$SUM2', ... }
# variables.variables = {'amount': '15', ... }
# self._state.variables = {'amount': '15', ... }

for param_name, param_val in step.parameters.variables.items():
    if param_name in step_variables:
        continue

    if param_name in variables:
        step_variables.set(param_name, param_val)
    elif param_name in self._state:
        step_variables.set(param_name, self._state[param_name])
    else:
        expanded_value = self.expand_from_variables(variables, param_val)
        # Prefer to use the original casing if the casefolded value is the same
        if expanded_value.casefold() != param_val.casefold():
            step_variables.set(param_name, expanded_value)

This fixes the bug for my use-case, with context variables now being correctly resolved (but I've not tested beyond that!).
@dluc , @matthewbolanos - I'm new to the codebase, would appreciate a review to see if this solves the bug here. :blush:

@amritpal-singh-98 thank you for the corrected version. I updated the Plan code and ran the original example code of this issue and it looks to fix it. I created a PR with your change and another fix required to make it all work and mentioned you in it for reference. Thanks!
This is the output now with my PR:
Function: mathskill.Add
Input vars: {'input': '10', 'amount': '2'}
Output vars: ['SUM1']

Function: mathskill.Add
Input vars: {'input': '8', 'amount': '7'}
Output vars: ['SUM2']

Function: mathskill.Subtract
Input vars: {'input': '$SUM1', 'amount': '$SUM2'}
Output vars: ['RESULT__FINAL_ANSWER']
Result: -3


SecItem for macOS and iOS

Implement SecItem
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   80.12%   80.05%   -0.07%
==========================================
  Files          28       28
  Lines        5967     5967
==========================================
- Hits         4781     4777       -4
- Misses       1186     1190       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Lezhin English/US url changed

The url for the english version of Lezhin seems to have been changed to: https://www.lezhinus.com/en

Nevermind, seems to be working now again. Downloading didn't work when I made this issue.


Some question about field params attribute

the example in the doc
Demo
it looks the field attribute is always a string type
is it should be dynamic?

You can use the binding syntax. (e.g. :field="field.name")


Peek & Go to definition don't work for things outside of current file

Hello,
I'm new to elm, and have been following along with the guides and documentation to learn the language. I had been using the online editor at first to run and tweak the examples, but recently I decided to install elm on my machine and integrate it with the rest of my tools, and vscode.
This may have something to do with the way I've installed elm so any help would be appreciated since I'm not getting errors or warnings about this in vscode. I'm using Ubuntu, and the (elm) Linux install instructions were rather lame. Windows/Mac get installers but Linux is left to pulling elm in with npm or building from source. One of the reasons I'm learning elm is to avoid javascript/npm/nodejs, so I don't have node installed on my system. I found an issue here https://github.com/elm-lang/elm-platform/issues/207 about pulling the Linux binaries separately, which I've done and placed them in my PATH.
All of the binaries seem to work except for repl since that requires nodejs. After installing this plugin for vscode, make on save seemed to start working automatically. If there is an error in my code it will display as it should. Peek & Go to definition also work if it is something I've already defined in my file, however nothing else works, and vscode gives me no warnings or errors, I only get the "No definition found for" tool tip. Same applies to hover, however that doesn't work even if it is something already defined in my file.
I looked at all the settings in vscode defined for elm, and while I haven't changed any from the defaults, they seem correct. I don't have elm-analyse, but I also didn't see that mentioned as needed for these features.
Thanks again for any help.

As I mentioned, I don't have elm installed through npm. node/npm is not on my system, I downloaded the binaries directly as mentioned in the issue I linked to.
I'm starting to think this is more of an issue with folder/project/workspace layout than how I've installed elm. In your screenshot you're looking up something in your "local" src directory. If it's something I've written and is in my src directory then the lookup works. However if I import elm-lang/html for example, I cannot peek the definition or anything I use from it. Futhermore if I import something like debois/elm-mdl (Material) and try to peek Material.Model, the peek shows my own Model, not Material.Model.
Is this extension hard coded to look for a literal "src" directory? My vscode workspace has hundreds of directories and most of them are under a parent "src". As an example, in vscode my workspace will have (at the top most level) src, bin and pkg directories. In src I may have a directory structure like github.com->iaburton->webapp. In webapp I would have a ui directory, and in that would be my elm files. Could this be the problem?

Yep!
I can reproduce this too: it constantly can’t jump to definitions outside the current file, although sometimes it shows the right location when hovering the symbol. 🤔
Here is the project: https://github.com/gurdiga/xo.elm.
And here is a screen recording:

Version info

VS Code Version 1.24.1 (1.24.1)
24f62626b222e9a8313213fb64b10d741a326288
2018-06-13T17:36:01.396Z
Elm and friends, installed with NPM:

    ~ ɀ  which elm
/Users/vlad/.nvm/versions/node/v9.11.1/bin/elm
    ~ ɀ  which elm-make
/Users/vlad/.nvm/versions/node/v9.11.1/bin/elm-make
    ~ ɀ  which elm-analyse
/Users/vlad/.nvm/versions/node/v9.11.1/bin/elm-analyse
    ~ ɀ

Questions

Does it matter how Elm is installed? I mean binary Mac vs. NPM. 🤔
Is there any other info I can provide to help debug this? 🤓

I can reproduce this a well. I can’t jump to definitions of the elm/core for instance, nor I can see the definitions in any elm package installed.

I would recommend switching to https://marketplace.visualstudio.com/items?itemName=Elmtooling.elm-ls-vscode


CASSANDRA-19199 Remove write option VALIDATE_SSTABLES to enforce validation

Closed via https://github.com/apache/cassandra-analytics/commit/672d66a64a21e23c4d81c089b426360c2bb708b7


Release Issue Cannot Find File

https://travis-ci.com/ChristopherDavenport/unique/jobs/232709673#L325
On 1.3.1 my code in unique failed to deploy saying it could not find the bundle.

Ok, I believe its an issue with having a publishTo that didn't get removed from the build.


Paramiko > 3.4.1 cause to SSH session not active

Type of change
Note: Fill x in []

[x] bug
[ ] enhancement
[ ] documentation
[ ] dependencies

Description

Paramiko 3.4.0 causes the following warning:
/root/benchmark-runner/venv/lib/python3.12/site-packages/paramiko/pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
After upgrading to Paramiko 3.4.1/3.5.0, the following error occurs when running a remote shell:
Got SSH session not active
When revert back to paramiko==3.4.0 all working properly.
Currently, I am using filterwarnings to temporarily suppress the warning and adding a TODO to follow up on the Paramiko fix.
For security reasons, all pull requests need to be approved first before running any automated CI

I suspect that you're using an old ssh key based on an outdated algorithm.  You should update the key.

@RobertKrawitz,
Our Test env was down for 2 weeks due to this issue.
After revert paramiko from 3.4.1 -> 3.4.0 issue was solved
Installation passed successfully
Do you think we should open an issue in paramiko project regarding it ?

You can try, but I suspect that the issue is that the ssh key you're using relies on an outdated algorithm and that it's behaving as intended.  Are you using a fixed ssh key from somewhere?

@RobertKrawitz,
Issue was solved when revert back to paramiko 3.4.0.
Open paramiko issue


AVS SDK 1.21 bootup crash

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:
When build pass and run the SampleApp in our platform, it will get error and crash
What is the expected behavior?
can run normally
What behavior are you observing?
When I bootup, I will get the LOG:
[AVS SDK] Create /data/alexa successful!!
[AVS SDK] sighandler Handler Init and reset
AVS_DEBUG success
[AVS SDK] create consolePrinter with logLevel!
Running app with log level: DEBUG9
[AVS SDK] read config file /data/AlexaClientSDKConfig.json
[AVS SDK] addPrimaryFactory 50 (13 442119077)
2020-11-01 12:34:47.987 [  1] I Cookbook:addPrimaryFactory:reason=std::function<std::shared_ptr>  ,type=[0x416f3794]
2020-11-01 12:34:47.989 [  1] I Cookbook:addFunctionRecipe Success:reason=Recipes type,type=[0x416f3789]
2020-11-01 12:34:47.991 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41d3a964]
2020-11-01 12:34:47.992 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3e94]
2020-11-01 12:34:47.992 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41d3a963]
2020-11-01 12:34:47.992 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x41d3a960]
2020-11-01 12:34:47.993 [  1] I Cookbook:addPrimaryFactory:reason=shared_ptr ,type=[0x41d3a961]
2020-11-01 12:34:47.993 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f377e]
2020-11-01 12:34:47.993 [  1] I Cookbook:addInstance Success:reason=instance type ,type=[0x416f377d]
2020-11-01 12:34:47.995 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378e]
2020-11-01 12:34:47.995 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3783]
2020-11-01 12:34:47.995 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378b]
2020-11-01 12:34:47.995 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3780]
2020-11-01 12:34:47.995 [  1] I Cookbook:addUniqueFactory:reason=unique_ptr ,type=[0x416f378d]
2020-11-01 12:34:47.996 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3782]
2020-11-01 12:34:47.996 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41eecb74]
2020-11-01 12:34:47.996 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x426b7ab2]
2020-11-01 12:34:47.996 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41eecb73]
2020-11-01 12:34:47.996 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x426b806d]
2020-11-01 12:34:47.996 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41eecb72]
2020-11-01 12:34:47.996 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x426b7aca]
2020-11-01 12:34:47.996 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x41eecb71]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x41eecb6a]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f3793]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3788]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f3792]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3787]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f3791]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3786]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f3790]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3785]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378f]
2020-11-01 12:34:47.997 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3784]
2020-11-01 12:34:47.997 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378e]
[AVS SDK] isEquivalent 606 (13 455707308)
2020-11-01 12:34:47.998 [  1] I Cookbook:addUniqueFactory:reason=unique_ptr ,type=[0x416f378d]
[AVS SDK] isEquivalent 518 (13 456283846)
2020-11-01 12:34:47.998 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378c]
2020-11-01 12:34:47.998 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3781]
2020-11-01 12:34:47.998 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378b]
[AVS SDK] isEquivalent 606 (13 456411000)
2020-11-01 12:34:47.998 [  1] E Cookbook:addFactoryRecipeFiled:reason=Recipes are not equivalent,type=[0x416f3780]
2020-11-01 12:34:47.998 [  1] I Cookbook:addRetainedFactory:reason=shared_ptr ,type=[0x416f378a]
2020-11-01 12:34:47.998 [  1] E Cookbook:checkIsValidFailed:function=addFactoryRecipe
[AVS SDK] Manufactory get cookbook start
[AVS SDK] Manufactory get cookbook middle
[AVS SDK] Manufactory get cookbook end
2020-11-01 12:34:47.999 [  1] E Cookbook:checkIsValidFailed:function=checkCompleteness
The error shows that
2020-11-01 12:34:47.995 [  1] I Cookbook:addFactoryRecipe Success:reason=Recipes type,type=[0x416f3780]
2020-11-01 12:34:47.998 [  1] E Cookbook:addFactoryRecipeFiled:reason=Recipes are not equivalent,type=[0x416f3780]
2020-11-01 12:34:47.998 [  1] E Cookbook:checkIsValidFailed:function=addFactoryRecipe
2020-11-01 12:34:47.999 [  1] E Cookbook:checkIsValidFailed:function=checkCompleteness
And I have also analyzed the coredump file generated by my platform:
it shows that when we do the Manufactory->get(), it will occur segmentation fault

But I have run it OK with the SDK Version 1.20.1, I just confused that what will cause this and why it will add two same Recipies? Can you give me some suggestions?
Provide the steps to reproduce the issue, if applicable:

Tell us about your environment:

What version of the AVS Device SDK are you using?
1.21
Tell us what hardware you're using:

[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux

Hi,
same issue.
./SampleApp -C  cfg/AlexaClientSDKConfig.json -L DEBUG9
configFile cfg/AlexaClientSDKConfig.json
Running app with log level: DEBUG9
2020-11-02 10:47:01.490 [  1] E Cookbook:addFactoryRecipeFiled:reason=Recipes are not equivalent,type=[0xffff93205970]
2020-11-02 10:47:01.490 [  1] E Cookbook:checkIsValidFailed:function=addFactoryRecipe
2020-11-02 10:47:01.490 [  1] E Cookbook:checkIsValidFailed:function=checkCompleteness
Segmentation fault

@angelobt , I have found the reason, but I am not sure whether my solution is OK. So can avs sdk team give some suggestions?

@tinypancake and @angelobt ,
The problem is likely due to different static member variable instances generated across invocations of the TypeIndex template with the same type.
Please try rebuilding with the ACSDK_USE_RTTI cmake parameter enabled (ON).
Best regards,
-SWH

ok , I will try it and feed back to you @scotthea-amazon

I have tried to rebuilding with the ACSDK_USE_RTTI cmake parameter enabled (ON). And it still occurs, so is there any potential issues?

Here is the LOGs:
[AVS SDK] sighandler Handler Init and reset
AVS_DEBUG success
2020-11-05 05:35:00.948 [  1] C SampleApplication:[AVS SDK] read config file:filename=/data/AlexaClientSDKConfig.json
[AVS SDK] ACSDK_USE_RTTI getTypeIndex <= stands for the cmake parameter enabled
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
[AVS SDK] ACSDK_USE_RTTI getTypeIndex
2020-11-05 05:35:00.963 [  1] E Cookbook:addFactoryRecipeFiled:reason=Recipes are not equivalent,type=St10shared_ptrIN14alexaClientSDK9avsCommon5utils6timing10MultiTimerEE
2020-11-05 05:35:00.963 [  1] E Cookbook:checkIsValidFailed:function=addFactoryRecipe
2020-11-05 05:35:00.963 [  1] E Cookbook:checkIsValidFailed:function=checkCompleteness

Hi @tinypancake, just want to make sure, could you first delete the build directory, and redo the cmake with -DACSDK_USE_RTTI=ON?

yes. I have  firstly deleted the build directory, and redo the cmake with -DACSDK_USE_RTTI=ON @kclchan

Hi @tinypancake, can you tell us what platform and compiler (including the version) you are using?  Thanks!

hi @kclchan, the platform is a DUT under linux and the compiler I used is the GCC 9.2 provided by ARM, the link is https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads

@tinypancake thanks for the information. Are you using any extra compiler flags, by any chance? If so, what are they?

hi @caleighatamazon , The log is added to make clear which part will cause this crash. As for the compiler flags, I do not set any extra flags, just the default ones

Hi @tinypancake , here are a couple ideas:

To temporarily unblock you, you can try removing this error-checking altogether by commenting out lines 364-368 and lines 385-389 in shared/acsdkManufactory/include/acsdkManufactory/CookBook_imp.h. That will hopefully unblock you so that the Sample App will run. Let me know if this works for you.

However, I am still interested in why this is not working. Also, the above check is valuable and I'd rather not turn it off for you if we can avoid it. I would appreciate your help with debugging this so we can understand what is going on. So even if #1 fixes the issue for you, I'd like to try to figure out the problem.

Can you add some additional logging to acsdkManufactory/include/acsdkManufactory/CookBook_imp.h? Specifically to the function template on line 568. Let's just confirm exactly where this is failing. Change it to something like this:
template <typename CacheType, typename Type, typename... Dependencies>
inline bool CookBook::SharedPointerFactoryRecipe<CacheType, Type, Dependencies...>::isEquivalent(
    const std::shared_ptr<AbstractRecipe>& recipe) const {
    if (!recipe) {
        std::cout << "DEBUG LOG - Null recipe\n";
        return false;
    }
    if (recipe->getRecipeType() != getRecipeType()) {
        std::cout << "DEBUG LOG - Recipe types are not equivalent\n";
        return false;
    }

    std::cout << "DEBUG LOG - Basic checks complete\n";
    auto factoryRecipe = reinterpret_cast<SharedPointerFactoryRecipe<CacheType, Type, Dependencies...>*>(recipe.get());

    return factoryRecipe->m_factory == m_factory;
}

Then re-build and re-run the app and let's see which logs get printed before the failure. Hopefully this will help us determine which of the three possible points of failure are being hit here.

Finally, out of curiosity, can you try modifying shared/acsdkShared/src/SharedComponent.cpp in the following two ways:
a. Remove line 39
b. Change line 44 to .addRetainedFactory(ConstructorAdapter<avsCommon::utils::timing::MultiTimer>::get())

Clear the build directory, re-build, re-run the app.
I have not been able to reproduce this problem myself, so my apologies for asking for your debug help here.
Thanks and looking forward to hearing from you.

@caleighatamazon, thanks for the indeed help, I will try this and feed back to you

@caleighatamazon, Hi, I have tried with the  method mentioned in idea 2, I add additional log and modifying shared/acsdkShared/src/SharedComponent.cpp, it still occurs crash.
Below is the log:
[AVS SDK] Create /data/alexa successful!!
[AVS SDK] sighandler Handler Init and reset
AVS_DEBUG success
2020-11-25 01:41:39.767 [  1] C SampleApplication:[AVS SDK] read config file:filename=/data/AlexaClientSDKConfig.json
DEBUG LOG - Basic checks complete
DEBUG LOG - Basic checks complete
2020-11-25 01:41:39.781 [  1] E Cookbook:addFactoryRecipeFiled:reason=Recipes are not equivalent,type=[0x41e347d8]
2020-11-25 01:41:39.781 [  1] E Cookbook:checkIsValidFailed:function=addFactoryRecipe
2020-11-25 01:41:39.781 [  1] E Cookbook:checkIsValidFailed:function=checkCompleteness
And I also try the method mentioned in idea 1, the Sample App will run successfully. Thanks for your help, what I had found to cause this crash is addRetainedFactory(ConstructorAdapteravsCommon::utils::timing::MultiTimer::get()) is done repeatedly, and I made some modification about this , it also resolve this crash

Hi @tinypancake , thanks for the information! The MultiTimer factory is added in two places:

SampleApplicationComponent.cpp adds it directly:         .addRetainedFactory(ConstructorAdapter<avsCommon::utils::timing::MultiTimer>::get())
SampleApplicationComponent also adds SampleApplicationOptionsComponent, which in turn adds the SharedComponent. The SharedComponent also adds the MultiTimer directly: .addRetainedFactory(ConstructorAdapter<MultiTimer>::get())

However, these two factories are actually the same (or should be the same) function. Since they're the same function, we wouldn't expect the manufactory to error out in this case. The error you're seeing is supposed to only happen when two different factories are added for the same type. Since the two factories being added are actually the same here, the error shouldn't happen. And indeed, in the testing we do internally on a variety of platforms, we haven't run into this problem before.
So, that's why this is an interesting puzzle!
The logs you added suggest that the problem is that the addresses of the two functions are actually different. This is unexpected (I'd expect them to be the same function!), but I wonder if it's some compiler detail of yours, especially because the factory method we pass is a function template.
Did you try out my third suggestion (which asked you to update the namespace being used in SharedComponent)?
What fix did you try that worked for you?
Thanks for your help on this.

Hi, @caleighatamazon, I have tried you second suggestion and third suggestion together, the log I provided is with these two suggestion.
What I have done is modified the SampleApplicationComponent.cpp init flow as the AVS SDK Version 1.20.1
The patch file is :
0008-fix-bootup-crash.txt

Hi @tinypancake , thanks for sharing your workaround.
My theory is that the problem is ConstructorAdapter<MultiTimer> is being used in two different libraries, leading to two different template instantiations -- even though they are functionally identical. There must be some compilation difference here since we haven't seen this problem in our internal testing yet.
Can you give this patch a try? All this patch does is modify SampleApplicationComponent.cpp to use the acsdkShared library directly (in order to access the MultiTimer type), rather than specify its own recipe for MultiTimer.
Since this does sound like a bug in the SDK, I've labelled this issue Under Investigation.
Thanks again for your help!
fix-runtime-failure.txt

Hi, @caleighatamazon, I have tried your patch and Sample App run successfully, thanks for your help, and I will add your patch to instead of my modifications

Amazing! Thanks for helping us hunt down the bug. I'll mark this as Resolved and try to get this fix into our next release.


Added run_responder functionality

Added the function "run_responder" to the file "api.py" that allows running a responder by its ID.

In order to start a responder by its name instead of using its ID, it is also possible to leverage the Cortex API through Cortex4py.
For instance, assuming that "api_cortex" is the object representing the Cortex API, it is possible to obtain the responder ID for the Mailer responder as follows:
mailer_responder_id = api_cortex.responders.get_by_name('Mailer_1_0').id
This ID can then be passed to the "run_responder()" function.

Closing this as this functionality is already present in 2.x and 1.x is not supported anymore


Transport postMessage for dimensions, spacing, typography...

Hi,
First of all I want to say that this plugin rocks. Amazing organization and structure!
I can't figure out if controls like dimensions, spacing, typography and probably some others do not support live feedback without page reload ( transport = postMessage )?

To be honest there's still some work to be done on these control types...
We just introduced them and postMessage is something I did not work on for those.
We'll get it fixed... I just had a lot of work on my day job so some things got left behind here. :)

postmessage for dimension controls works as expected using the js_vars argument.
dimensions and typography not yet, I'll see if I can build those now.

Thanks for quick answers to all my questions!

@aristath any news about this ?

Too many controls are not updating the live view when being used with theme_options.

@peazz could you please be a bit more specific?

typography fields now work when transport is set to auto.

Nice work.
Regarding the earlier issue. For some reason alot of fields were not working but I have since rebuilt the entire panel and use the latest documentation.
Everything is working as expected.


Modify Opportunity Stage to State Mapping to utilize a Custom Metadata Type

The Opportunity Stage to State Mapping needs to be updated to use a New Custom Metadata Type so that it is more flexible. This allows the users to pick which Opportunity stages will be mapped to which State.

**lurch: attach W-031903

Tracking W-031903

This issue was mistakenly created. It should not have been created in the first place.


In some of them the gradients are being stored in the wrong place (here):
double calculate_gradients_1storder(vector<double>& grad,
                                      fvar<double>& logprob, vector<var>& x) {
    x.push_back(logprob.d_);
    return logprob.val();
  }

This happens the tests for the lpmfs/lpmds, cdfs, lcdfs and lccdfs.
Current Version:
v3.3.0

This was fixed in #2042


Remove dependency on k8s.io/kubernetes/pkg/apis/extensions from kubectl

Remove dependencies from packages under k8s.io/kubernetes/pkg/kubectl/... on k8s.io/kubernetes/pkg/apis/extensions/v1beta1 by converting them to use the k8s.io/api/policy/v1beta1 package

@pwittrock I would like to let you know that I just successfully compiled the Kubernetes source  code and I am currently working on this issue for my initial contribution.

@pwittrock, I would like to inquire if you think it is better to solve all of this in one pull request or if I can do multiple pull requests given the number of modules that need to be updated such as scale, rollout_status, rollback etc.

More smaller PRs is best

https://github.com/kubernetes/kubernetes/pull/54493 doesn't solve all of them. Reopening.
@yland Don't close this issue in your PR until all of them are resolved.

@mengqiy Thanks, I did not realize it would automatically close this.

/reopen

/reopen


Better failure when given a directory (rather than a text file)

Fixed in https://github.com/sts10/tidy/commit/33efbdc0d7841bbf50e842887997460003edb0d6


Should task user input be shell escaped?

Testing #64214
Repo

On osx.
With tasks.json:

{
	"version": "2.0.0",
	"tasks": [
		{
			"label": "Echo input",
			"type": "shell",
			"command": "echo \"${input:echoPrompt}  ${input:echoPick} ${input:echoPrompt} ${command:extension.pickNodeProcess}\"",
			"problemMatcher": []
		}
	],
	"inputs":[
		{
			"label": "echoPrompt",
			"description": "Please enter a value",
			"default": "test echo",
			"type": "prompt",
		},
		{
			"label": "echoPick",
			"description": "Select one of the values",
			"default": "two",
			"type": "pick",
			"options": ["one", "two", "three"]
		}
	],
}

Run the task.
In the input box, enter:

`echo "hi"`

Run the task

bug
Special shell characters not escaped. Not sure if this is expected or how this could be handled better. Backticks probably aren't a real problem but quotes (or spaces) could be

@alexr00 we should escape them. There is code in the terminal runner that does the escaping.

Ok, moving to December.

Talked about this one a bit more. We will not escape user input in tasks. If you want user input to be escaped you can put it in an argument array:
{
    "label": "Echo input",
    "type": "shell",
    "command": "echo"
    "args": ["${input:echoPrompt}"],
    "problemMatcher": []
}


Error with sbt 0.11

With SBT 0.11 I get :
$ sbt11
C:\Users\Maxou.sbt\plugins\build.sbt:4: error: illegal start of simple expression
object MyPlugins extends Build {
^
[error] Error parsing expression.  Ensure that there are no blank lines within a setting.
Thanks

I named my file .sbt/plugins/project.sbt and got the same error

I got it working by putting the code in ~/.sbt/plugins/project/ShPlugin.scala.

Thanks, inkytonik. This worked for me as well.
But i would like to see a solution that let's me add this plugin with my other plugin definitions to project/plugins.sbt .


java-openliberty:  Pick up LMP V3.2 and delegate to liberty-maven-plugin to watch pom.xml changes

As commented here we are using the appsody watcher to watch pom.xml as a workaround to v3.1 liberty-maven-plugin limitations.
Once https://github.com/OpenLiberty/ci.maven/pull/676 is available in a release, we should move our appsody stack to that version of the plugin, and remove this special case exception from our appsody watcher.

https://github.com/OpenLiberty/open-liberty/issues/10674  is somewhat important to appsody java-openliberty.   I suggest we either wait until <IP_ADDRESS> is available and do together, or at least open a follow-up issue if we do the LMP upgrade alone.


Android Freeform mode conflicts with Flutter DecorCaption

External version of internal bug
https://b.corp.google.com/issues/322183798
Likely fix will be to make safe area aware of android 15 freeform features and their insets.

There is an open pull request that is waiting on reviews.

Fixed


docs: few tweaks to readme

Went through this process a bunch of times today, just noticed some small improvements that could help.

/approve
/lgtm
/retest

/retitle bug 1957012: docs: few tweaks to readme


Support cookies for websocket

Refs: https://github.com/metarhia/impress/issues/743

Landed in d62b569


⚠ Bofrost.be has degraded performance

In e75a0dd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1344 ms

Resolved: Bofrost.be performance has improved in 0f079bc.


[QUESTION] When will the other languages be avlaible?

This is a incredible adoption tool but according to Microsoft Docs https://docs.microsoft.com/en-us/office365/customlearning/faq the solution will be offered in other languages in 2020 Q1.  Do you have any idea on when the other languages will be released as we support different languages in our organization?
Thanks!

Unfortunately, that document is out of date and I do not have any more updated information that I can give you at this time.  I've tagged those that I think can answer it.

We are interested in this information as well. Thank you!

We are interested. Thank you!

I'm interested in this info as well, hopefully this will be available in other languages soon!

Any update on this topic please?

What languages is Microsoft 365 learning pathways available in?
Microsoft 365 learning pathways is currently available only in English. Automatic end-to-end provisioning only works with English tenants. We plan on rolling out multilingual support for these nine languages in the second quarter of 2020.
Chinese (Simplified)
Dutch (Netherlands)
French
German
Italian (Italy)
Japanese (Japan)
Portuguese (Brazilian)
Russian (Russian)
Spanish

The FAQ https://docs.microsoft.com/en-us/office365/customlearning/faq now states that 'We plan on rolling out multilingual support for the following languages in the second quarter of 2020'.
Are you confident we are in line with meeting this target ? Can I plan a UK customer project with the multi-lingual version available before end of June ? Thank you

@Rafou2  -- in the future, please do not comment on closed issues, rather open a new issue and reference the closed one. Please see comments on #267


Introduce (metadata) publish button [WIP]

Fixes #362.

This doesn't have the actual publishing implementing, but it depends on https://github.com/ethereum/go-ethereum/issues/3523.

Since this now displays a warning message ("Feature not implemented."), we might as well merge it.

I don't think we should add a button that is not working.

I don't think we should add a button that is not working.

Have you seen the Reddit button? 😉

Added publishing of metadata. Still need to include way to publish sources.
It should also verify that the published hash matches the pre-calculated hash.

What is missing for publishing the source?

I have improved version I need to push here, after that we should be able to merge it.

@yann300 @chriseth I think this can be merged


v0.2.4

Release for CONUS processing with SET and ionosphere correction

Enabling automerge @jhkennedy - please make sure we populated github metadata correctly.


error while creating oci_identity_user.nc-bucket-user

hi, thanks for all your work, I'm stuck on deploying :
oci_identity_user.nc-bucket-user: Creating...
╷
│ Error: 400-IdcsConversionError, Post request failed{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error","urn:ietf:params:scim:api:oracle:idcs:extension:messages:Error"],"detail":"The primary email must be specified.","status":"400","urn:ietf:params:scim:api:oracle:idcs:extension:messages:Error":{"messageId":"error.identity.user.primaryEmailNotSpecified"}}

That's an interesting error - it looks like the oracle (oci) provider documentation is out of date and the requirements for this resource have changed.
https://github.com/oracle/terraform-provider-oci/issues/1622
I believe I can set this to an aliased email address based on the caller's (your) email address, testing it now.

commit 3db73de adds a placeholder email address, please update your repository with git pull. If you've already customized oci.tfvars then move oci.tfvars to a different file, git pull, then move it back like this:
mv oci.tfvars custom.tfvars
git pull
mv custom.tfvars oci.tfvars


A few small issues are fixed

There were a few small issues.

Bulk Video download started message and offline access message were not present. This has been fixed
Updated functioning of Enrollment behind a flag
Change "Course handout" to "View course handout" in CourseInfo

@rohan-dhamal-clarice @aleffert - Please review

Looks good! I merge this.

:+1:


peterp/improve readme

Rename pg-browser to runtime
Rename title in README.
Stylize main repo.

@jgoux I rename "pg-browser" to "runtime" 😬
I'm guessing this makes the repo more expensive to clone, since we'll have a bunch of history that includes large files.


Doc strings1

Update documentation
Complete docstrings added to:
algos/backward_algorithm.py

Codecov Report

Merging #38 into master will increase coverage by 0.16%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   90.19%   90.36%   +0.16%
==========================================
  Files          53       53
  Lines        3153     3154       +1
  Branches      377      379       +2
==========================================
+ Hits         2844     2850       +6
+ Misses        196      190       -6
- Partials      113      114       +1

Impacted Files
Coverage Δ

src/ast_toolbox/algos/go_explore.py
89.78% <ø> (ø)

tests/validate_ge_ba.py
94.87% <ø> (ø)

src/ast_toolbox/algos/__init__.py
88.88% <75.00%> (-11.12%)
:arrow_down:

src/ast_toolbox/envs/__init__.py
80.00% <75.00%> (-20.00%)
:arrow_down:

src/ast_toolbox/algos/backward_algorithm.py
96.59% <100.00%> (-0.12%)
:arrow_down:

src/ast_toolbox/samplers/batch_sampler.py
76.27% <0.00%> (+11.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf8fef...3587b46. Read the comment docs.


Roll engine dc7b5eb89da3..21ac961df382 (4 commits)

https://github.com/flutter/engine/compare/dc7b5eb89da3...21ac961df382
git log dc7b5eb89da3..21ac961df382 --no-merges --oneline
21ac961df Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126)
e7767ae9b Add license file patching instructions to README (flutter/engine#6125)
51d4be774 Add a -[FlutterViewController splashScreenView] property (flutter/engine#6112)
a047fd20f Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


[Improvement][Resources Project] The details page does not return to the previous list page after returning to the list page

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
version 3.x
Current Problems

When you come to the task or workflow list interface(Figure 1), click the task edit button on the specified page to enter the task details page(Figure 2). When you return, you will jump to the first page instead of the page where the original task is located(Figure 3). Very unfriendly to the user's experience.

When you come to the list interface of the resource file, click the edit button of the resource file on the specified page to enter the details page of the resource file. When you return or save, you will jump to the first page instead of the page where the original resource file is located. It is also very unfriendly to the user's experience.
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Our company has been using dolphinscheduler. After such a long time of use, we found that if we optimize the resource paging part like me, the development efficiency will increase by an order of magnitude, because it saves a lot of repeated searches and page jumps, especially when modifying the same type of resource files in large quantities.

this improment is great for the user experience and greatly improves development efficiency

@pinkfloyds my submittd code is here https://github.com/apache/dolphinscheduler/pull/13731

this problem will reopen

I cannot reopen this issue, I already submit a new issue similarly like this issue


After installing pip

I am at this stage:
pip install LatLon
I am at the root of my Mac, but have this error:
running install_lib
creating /Library/Python/2.7/site-packages/pyproj
error: could not create '/Library/Python/2.7/site-packages/pyproj': Permission denied
with this in red:
Command "/usr/bin/python -c "import setuptools, tokenize;file='/private/var/folders/6g/rw62mz5j1r1dv82l32g8wfqc0000gn/T/pip-build-v_3wmd/pyproj/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /var/folders/6g/rw62mz5j1r1dv82l32g8wfqc0000gn/T/pip-esqOy3-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/6g/rw62mz5j1r1dv82l32g8wfqc0000gn/T/pip-build-v_3wmd/pyproj
Thanks for your help :)
Johan

I got the same but was because my brew installed Python incorrectly.
It was related to new security in the El Captain.
If that is the case, check how to fix brew on Mac OS El Captain.

Ok, I found it:
use this on your root mac
sudo chown -R $USER /Library/Python/2.7


Incorrect pnpm install

It is said one should use
# Using pnpm
pnpm add --dev @nuxtjs/mdc

But this does not work and throws this error:

Instead it should be
pnpm add -D @nuxtjs/mdc

Thanks for the issue, This is not related now since we suggest using nuxi module add command in docs.


Workshop Items Not Downloading

Followed directions exactly and workshops items won't download. Just show state of 0 then 8.

Yeah, TWI broke it AGAIN with the latest KF2 patch. I'm still trying to find a workaround, but the previous one causes a segfault, so it'll most likely require action on their part.
https://noobient.com/2019/05/12/fixing-killing-floor-2-linux-server-workshop-downloads/
TLDR they link to (and ship) wrong versions of steamclient.so which they shouldn't do at all in the first place, because Steam ships its own, but for whatever reason TWI sometimes randomly decides to ship their on version. Or 3 different versions of it. Don't ask me why, it's beyond comprehension.
In the meanwhile you can try nagging them about it... the errors messages can be found in Steam/logs/workshop_logs.txt or something like that, it clearly shows those issues about no connection to servers etc.

Ya I was reading about that and saw that you'd made the workaround. Was hoping it was just something I was doing wrong and not them creating the problem again. Thanks for the answer though.

Hey, I pushed a commit that may solve the issue. Could you please do
git pull
./install.sh -e "skip_kfgame=True"

in the killinuxfloor directory, then retry the workshop downloads?

Hey, I pushed a commit that may solve the issue. Could you please do
git pull
./install.sh -e "skip_kfgame=True"

in the killinuxfloor directory, then retry the workshop downloads?

Looks like it worked. You're awesome, thanks.

Awesome :) Closing the issue then.
For reference, the relevant commit is 161d2ee3af05e006ef004a59d507379186991ef1


COMET not working with python 3.8

🐛 Bug
COMET works with python 3.6 but not with python 3.8
Environment
OS: MacOS
Packaging: pip
Version 1.0.0rc6
To Reproduce
I pip installed comet on my python 3.8.12 virtual environment and then tested the example provided in the readme Scoring with Python
seg_scores, sys_score = model.predict(data, batch_size=8, gpus=0)

But I get the following error:
<EMAIL_ADDRESS>in _launch(self, process_obj)
     45         try:
     46             reduction.dump(prep_data, fp)
---> 47             reduction.dump(process_obj, fp)
     48         finally:
     49             set_spawning_popen(None)

<EMAIL_ADDRESS>in dump(obj, file, protocol)
     58 def dump(obj, file, protocol=None):
     59     '''Replacement for pickle.dump() using ForkingPickler.'''
---> 60     ForkingPickler(file, protocol).dump(obj)
     61
     62 #

AttributeError: Can't pickle local object 'CometModel.predict.<locals>.<lambda>'

I tested the same code on python 3.6 and it did work, so thanks a lot :)
I expected comet to work with >=python3.5
Is there any plan to make it work for python 3.8?
Thanks again.

Hi, I had the same issue. I switched to Python 3.7 and pandas==1.1.5 to make it work for me. (Installed from pip & running locally- no GPU)

I found the error.
I believe during Inference Pytorch Lightning will create model copies and it will complain about the fact that there is a lambda function defines locally: https://github.com/Unbabel/COMET/blob/master/comet/models/base.py#L445
After fixing that error it will complain about the local definition of PredictProgressBar.
I am just wondering why it works for some python versions and not for others.

Hi @mjpost can you test it using the pre-release version?
pip install unbabel-comet==1.0.0rc8
I fixed some of the problems reported on this thread already.

Thanks a lot @ricardorei . It works perfectly!

Hi @ricardorei
Any plan to make the official 1.0 available in standard 3.8 pip:
pip3.8 install unbabel-comet==1.0.0
ERROR: Could not find a version that satisfies the requirement unbabel-comet==1.0.0 (from versions: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.6, 0.0.6.post1, 0.0.6.post2, 0.0.7, 0.1.0, 1.0.0rc1, 1.0.0rc2, 1.0.0rc3, 1.0.0rc4, 1.0.0rc5, 1.0.0rc6, 1.0.0rc7, 1.0.0rc8, 1.0.0rc9)
ERROR: No matching distribution found for unbabel-comet==1.0.0

Best
W.

@WilliamTambellini I release version 1.0 a few hours ago and I tested it on python 3.8. As you can see your pip should return you 1.0.0 and 1.0.1 versions

have you tried to upgrade pip?

I am reopening this until its fixed.

@AnanyaCoder
the same error occours in my python3.7 env, have you figured it out?

I am getting the same error with Python 3.11.8:
Traceback (most recent call last):
  File "/home/souto/Repos/msoutopico/python-comet/code/main.py", line 2, in <module>
    from comet import download_model, load_from_checkpoint
ImportError: cannot import name 'download_model' from 'comet' (/home/souto/.cache/pypoetry/virtualenvs/python-comet-nDgw5fZj-py3.11/lib/python3.11/site-packages/comet/__init__.py)

I am getting the same error with Python 3.11.8:
Traceback (most recent call last):
  File "/home/souto/Repos/msoutopico/python-comet/code/main.py", line 2, in <module>
    from comet import download_model, load_from_checkpoint
ImportError: cannot import name 'download_model' from 'comet' (/home/souto/.cache/pypoetry/virtualenvs/python-comet-nDgw5fZj-py3.11/lib/python3.11/site-packages/comet/__init__.py)

I got this error 2 days ago and realized the PyPi package I had installed was https://pypi.org/project/Comet/ and not https://pypi.org/project/unbabel-comet/. Uninstalling the Comet and installing the unbabel-comet package solved it in my case, hope it does for yours as well !


Lootbeams & Inventory Tags

Added lootbeams and inventory tags for current rumours.

Fixes #2

Added configs for the lootbeam and inventory tag colors

The licensed code comes from:
https://github.com/runelite/runelite/tree/master/runelite-client/src/main/java/net/runelite/client/plugins/grounditems
and
https://github.com/runelite/runelite/tree/master/runelite-client/src/main/java/net/runelite/client/plugins/inventorytags
And whenever you inventory is full, the item drops to the ground.
For example with falconry, the game requires 2 free inventory slots whenever you grab the kebbit.
But the rumour item is a 3rd item, which would be dropped to the ground if you only have the 2 free slots.
I think it would be nice to have these things in the plugin as apposed to manually tagging the items yourself (both for inventory and ground items). It just makes it that much more obvious that you've completed the rumour.


incorrect font for u111EF generated for NotoSansSinhala-CondensedBold, -ExtraCondensedBold and -ExtraCondensedSemiBold

source https://github.com/googlei18n/noto-source/tree/master/src/NotoSansSinhala
u111EF in the source looks like

but the compiled result looks like in
NotoSansSinhala-CondensedBold

NotoSansSinhala-ExtraCondensedBold

NotoSansSinhala-ExtraCondensedSemiBold

ufo/u111E_F_.glif from NotoSansSinhala-ExtraCondensedBold
u111E_F_.glif.zip

still is happening with the current set of tools (don't know the VF font though)

it seems like a source issue.
The starting point of the vertical bar does not match across all the masters (specifically, Light and Bold):

sorry. thanks for pointing this out.

I modified the source, rebuilt the fonts and verified that it is fixed through source modification. @anthrotype : thank you

The  change to the font data may appear to fix the distortions, but not the cause of the distortions. In a bug free interpolation there is no way that any outline point is not within the common bounding box of the masters. If GlyphsApp interpolated the same way fontmake does, a distortion like this would not have gone unnoticed. I suggest to unfix, the font source and make sure fontmaker interpolated the same as GlyphsApp!

I'm not sure I understand.. You can clearly see from the picture that the starting point do not match in all the masters.
I don't know what you mean by "bug free interpolation". Also I don't know whether or how Glyphs.app manages to work around these mismatching starting points.
Can you elaborate?

Here's what Glyphs.app does with the ExtraBold instance, if you don't fix the starting points:

That is my point. In GlyphsApp all interpolated nodes are in between the points of the masters. They cannot be outside the bounding box of the masters. In the image of the font produced by fontmake there are nodes all over the place. Whatever is causing that, it is not interpolation.

fontmake uses MutatorMath for interpolation, Glyphs does its own thing. I don't know one compares to the other, as I can only look at the source code from the former.
The fact remains that the starting point issue needs fixing in the source file, whether one uses fontmake or Glyphs.app to interpolate. And after fixing the starting points, a valid input produces consistent output in both MutatorMath and Glyphs.app.

In the mean time we found out that fontmake has interpolated Noto Sans Tamil MM incorrectly (despite all start points in the right place)

please open a separate issue for that providing further details, thanks.

I reported the Tamil issue to Marek. The start point issue with the is one Sinhala character has been fixed in my source for quite a while. But I am still waiting for a review of the design. But the design cannot be reviewed when Google is using faulty software to produce the font files that are are send to reviewers. And that software is not going to be fixed, if obvious faults in interpolation algorithms are not important enough to investigate.

Sorry you feel that way. But again if the sources are not interpolation-compatible to begin with (in this case, the starting points), there is no correct "bug-free" way to interpolate and the result is undefined.

The wrong start point does not make the outline interpolation incompatible, it only produces an unappealing result. The wrong number of points or outlines, different types of points are what makes outlines incompatible. Within ANY interpolation, all interpolated points are between points on masters.  If they are not in between, it is not interpolation. I am afraid to say it is already 30 years ago that I wrote an editor for Icarus outlines, which included interpolation. The math is not complicated.
If we interpolate a large square with start point top left, with a small square with start point bottom right, we may get a shape that is smaller than the small square. But it is impossible to get a shape that is larger than the large square. But in this case of u111EF, we effectively get a "larger square". You would need to extrapolate for that.
If you get an interpolation where interpolated points are NOT between points on masters, where the result is quite different from that GlyphsApp, which is doing the right thing, then there is something going on that needs to be explained. What that something is, I don't know. I assume it has to do with not being able to manage 7 masters.  For fonts that have been designed with GlyphsApp and tested with fonts generated with GlyphsApp, you MUST get the same results using "fontmake". One of these two reasons alone justify a serious investigation into what exactly causes the "larger square". And I bet it is a bug.

Thanks for the explanation. I'll investigate further and make sure if there's the bug it is fixed.

You are probably not familiar with GlyphsApp to the extend daily users are:
If for a glyph the outlines in masters are incompatible with regards to
number of contours, order of contours, number of nodes, or the type of
nodes, then Glyphs will not interpolate between these masters at all. So
this makes it easy for designers to see where they get it wrong. There is
an exception: you can still have a start point in the wrong place. Imagine
a round or square period. The masters are considered compatible wherever
the start point is, because it passes all tests. And the designer has to
spot where it goes wrong.
In our case there are 6 nodes with straight lines: compatible wherever the
start point is.
I think it also means that the Glyphs interpolation/extrapolation
algorithm can be very simple. It doesn’t have to do any “smart”
interpolation, as for example FontLab tries to do, with sometimes
devastating results. So either fontmake tries to do something smart that
can go wrong, or  is somehow confused by the arrangement of masters and
ends up doing something strange and in this character it gets particularly
strange.
On 25-feb.-17 16:12, "Cosimo Lupo"<EMAIL_ADDRESS>wrote:

Thanks for the explanation. I'll investigate further and make sure if
there's the bug it is fixed.
—
You are receiving this because you commented.
Reply to this email directly,
view it on GitHub
https://github.com/googlei18n/fontmake/issues/225#issuecomment-282489987
, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AMI6swCHWER5w7YmLIs5eII
WOuuxxSaNks5rgETLgaJpZM4LU5Zr>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e
4bb","name":"GitHub"},"entity":{"external_key":"github/googlei18n/fontmake
","title":"googlei18n/fontmake","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/1
43418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url
":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0
b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/googlei18n/fontmake"}},"updates":{"snipp
ets":[{"icon":"PERSON","message":"@anthrotype in #225: Thanks for the
explanation. I'll investigate further and make sure if there's the bug it
is fixed."}],"action":{"name":"View
Issue","url":"https://github.com/googlei18n/fontmake/issues/225#issuecomme
nt-282489987"}}}

@anthrotype : @JelleBosmaMT makes a good point (pun unintended :-)) and this might make a good assertion: any point in the interpolated "construct" should NEVER be outside of "maximum of all masters" [I'm not sure what the right words are here]. If it is the there's something wrong and we should flag it as opposed to creating an interpolation with this. Just my 2c.


Neka-Create new branch with navbar component

What type of PR is this? (check all applicable)

[ ] Feature
[ ] Refactor
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[X] Other (please specify here: Create a component)

Description of what this Pull Request does

Creation of NavBar component including logo, search bar and navigation links
Very basic styling of NavBar component
Addition of stylesheet for NavBar component

logo was added as placeholder
search bar was not made functional since teammates need to meet again to find out exactly what terms we will have available for users to search through, find out appropriate search constraints
navigation links are not functional until I meet with teammates again to find out what pages/parts of the app we would like users/managers to be able to easy click through to

Related Tickets & Documents

Closes #35
Related Issues: #40

QA Instructions, Screenshots, Recordings
(In this section, describe how to QA/review your PR. Feel free to use screenshots and/or short videos)

Added/updated tests?

[ ] Yes
[ ] Not Yet, and here is why: explain here
[ ] I need help with tests
[x] No, and here is why: Have not started doing any tests.

Looks great @istoga ! The 'create listing' was in the manager's dashboard but this placement is much better in the navbar.

Thanks @TaylorDJones11 I wasn't sure which links to place in the navigation, but if that does look better there then cool!

The Navbar component looks good, but it looks more like a  navbar component for a signed in manager

@istoga your branch is some commits behind main branch, Kindly update your branch

@msarit can you merge this please, I'm scared!


Update VERSION to 1.0.5

The 1.0.5 release did not update the version displayed in the app footer.

Thanks @CGA1123


Move the triggerMethod('start'.. to an overrideable method

Partially resolves #76
@brentli1 I think I'd like to try and squeeze this into 0.2.0 I tried implementing this tonight for our factor pathways app and it cleans up a bunch of stuff.  Unfortunately I still can't add tests or docs on this commit since that stuff is not on develop yet.
This allows the user to add async functionality
triggerStart: function(options){
  //this.triggerMethod('start', options);
  this.on('sync:data', _.partial(this.triggerMethod, 'start', options));

  this._fetchData(options);
},
_fetchData: function(options){
  $.when(this.beforeStart(options)).then(_.bind(this.trigger, this, 'sync:data'));
},
beforeStart: function(options){
  return $.Deferred().resolve();
}

:+1: Awesome


[FEATURE REQUEST] Packaged app dumping

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This proposal is a completely new feature. If you want to suggest an improvement or an enhancement, please use this template

Describe the new feature
Add a feature in the all apps list to dump packaged apps to a .appx or .msix file.
See https://github.com/Wapitiii/WSAppBak and https://gist.github.com/FusRoDah061/01f2426ad6c379d93729c8ac67f84ba2
Describe how this new feature could help users.
As a package manager, as it has the ability to import packages, it should also export packages.

I don't think this feature would fit with all package managers

Correct, this would only be for UWP apps, and later Android (WSA) apps
(when implemented into WinGet).
On Tuesday, September 26, 2023, Martí Climent @.***>
wrote:

I don't think this feature would fit with all package managers
—
Reply to this email directly, view it on GitHub
https://github.com/marticliment/WingetUI/issues/1405#issuecomment-1736217273,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKNKRXBFDMK6N4S73HENEPDX4MZARANCNFSM6AAAAAA5GHNKGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello,
This feature won't be implemented due to incompatiblities with the Package Managers