Support geolocation in android webview

Makes sure request for geolocation use in the webview is handled.
This solves issue #7609
Currently use of geolocation in webview fails silently, as the permission request is never received by the native app.
Test plan (required)

Create new project with webview
Add javascript for geolocation:

navigator.geolocation.getCurrentPosition(function (position) {
  console.log('success', position)
}, function (error) {
  console.log('could not determine position', error)
})

Run code and assert geolocation permission is requested, resulting in success (or error) callback being called

By analyzing the blame information on this pull request, we identified @mkonicek and @nicklockwood to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

I just tested this PR and it worked right away 👍
I just followed the instructions to re-build React Native from source and my app which has a webview that loads an url which uses geolocation just worked!
@mkonicek @nicklockwood is there anything I can do to help with this PR?

@jvassbo a test failed, try to merge master and re-run?

@danielbraun not sure why the circleci build failed now, it looks like code-analysis-bot.js was unable to find the changed in this PR..

@jvassbo I suggest you try again, it sometimes fails for weird reasons.

@danielbraun Took a couple of tries, but now both CircleCI and Travis builds are green.

@jvassbo great. Mine also took a few times.

@facebook-github-bot shipit

Experience same issue while building app for my web-site. Is this PR already included into react-native v0.35.0 ?

@vadimeremeev this was included in the v0.31.0 release so it should also work on that version, altho I haven't tried that specific release.


Structure

covers most standards listed under Structure except for the Exception message strings should be concatenated using sprintf. one

Thanks for your contribution @wickedOne!
Kind regards,
David


Version 1.1.0

Added simulation and annealing functionality. Better readme. Fixed some testing bugs.

Codecov Report

Merging #14 into master will increase coverage by 0.04%.
The diff coverage is 97.6%.

@@            Coverage Diff            @@
##           master     #14      +/-   ##
=========================================
+ Coverage   97.66%   97.7%   +0.04%
=========================================
  Files          80      90      +10
  Lines        5213    5888     +675
  Branches      527     644     +117
=========================================
+ Hits         5091    5752     +661
- Misses         74      83       +9
- Partials       48      53       +5

Impacted Files
Coverage Δ

tests/utils/test_normalize.py
100% <ø> (ø)
:arrow_up:

qubovert/problems/np/cycles/__main__.py
0% <ø> (ø)
:arrow_up:

qubovert/problems/benchmarking/__init__.py
100% <ø> (ø)
:arrow_up:

tests/test_pubo.py
100% <ø> (ø)
:arrow_up:

qubovert/problems/np/packing/__init__.py
100% <ø> (ø)
:arrow_up:

qubovert/sat/__init__.py
100% <ø> (ø)
:arrow_up:

qubovert/utils/_subgraph.py
100% <ø> (ø)
:arrow_up:

tests/problems/np/test_vertexcover.py
100% <ø> (ø)
:arrow_up:

tests/utils/test_pubomatrix.py
100% <ø> (ø)
:arrow_up:

qubovert/problems/np/__main__.py
0% <ø> (ø)
:arrow_up:

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e720a0...a876209. Read the comment docs.


fix(meta): redundant consensus item handling in new Federations

This introduces a config-based errata, so that new Federations will use a new behavior, while old ones stay supported.
> cat /tmp/devimint-2070662-004/fedimintd-0/local.json | grep errata
      "errata_redundant_err": true

@elsirion @joschisan This is a PoC of fixing consensus behavior in a backward compatible way, that relies on all peers using the same version of Fedimint to do DKG. It seems relatively straightforward to employ, and we could possibly use it elsewhere in the future.
As per https://github.com/fedimint/fedimint/pull/4949#discussion_r1563260845 - I'm inclined not to change the clearing submission behavior, as IMO it's just one extra condition on both sides (propose + process) and it gets rid of needless values sticking around for no reason (storage + APIs returning them), but if you were both vehemently against keeping it, I guess it could be done in the same errata). I guess I'll just have to make whole process_consensus_item conditional to keep it sane.


Add raw HTTP body capability

Is your feature request related to a problem? Please describe.
We are unable to ingest telemetry from Telemetry Streaming because the HTTP body is JSON-formatted.
Describe the solution you'd like
We would like the ability to have a completely raw HTTP body, giving us total control of how the body is formatted. This will allow much greater flexibility than exists with mandatory JSON formatting.
Describe alternatives you've considered
The only alternative is to alter the ingestion system to accept JSON formatting however that is not always possible.
Additional context
By allowing raw HTTP body, you would give complete control of that aspect of the Telemetry Streaming output to users, ensuring maximum compatibility.
In our specific use case the BIG-IP sends data via Telemetry Streaming to the ingestion point however the ingestion point cannot accept JSON-formatted data. Consequently it discards all the traffic received from Telemetry Streaming, even when it is formatted properly, because that payload is then encapsulated in the JSON-formatted mandatory metadata.
We specifically use an Event Listener in TS to receive the data and then the HTTP consumer to transmit the data. It would be ideal if this raw option can be configured at the namespace level or lower (like per event listener or consumer).

We were able to achieve this functionality by modifying /var/config/rest/iapps/f5-telemetry/lib/consumers/shared/httpUtil.js and adding to the sendToConsumer function. Between the lines "let requestError;" and "return requestsUtil.makeRequest(host, config.uri, requestOptions)" add the following:
requestOptions.json = false;
requestOptions.body = requestOptions.body.data;

so it looks like:
let requestError;

requestOptions.json = false;
requestOptions.body = requestOptions.body.data;

return requestsUtil.makeRequest(host, config.uri, requestOptions)

This resulted in the HTTP body of consisting solely of the data sent to the Event Listener, meeting our requirement. This isn't an appropriate long-term solution as it affects all outbound data.
We would be looking for a per-consumer solution, ideally configurable in the consumer. Reviewing requests.js there is a rawResponseBody which defaults to false which might be useful?

Thank you for your feedback. I have added this to our internal product backlog as AUTOTOOL-3037.

This issue has been resolved with the 1.29.0 release.


haeder Problems

Hello,
first the Router is very good and easy to handle, but there is a Problem when I include a file and in this file I like to change the header to download or display a file this doesn't work, because you have to change the haeder before you output some code / HTML.
Are there any solutions for that problem?

could you please provide a code sample, coz I've tried to create some imaginative sample of what you say, and it works fine

clear,
`<?php
require_once './php/route.php';
define('BASEPATH','/');
Route::add('/open',function() {
include('./php/open.php');
}, 'post');
Route::pathNotFound(function($path) {
header('HTTP/1.0 404 Not Found');
echo 'Error 404 :-(';
echo 'The requested path "'.$path.'" was not found!';
});
Route::methodNotAllowed(function($path, $method) {
header('HTTP/1.0 405 Method Not Allowed');
echo 'Error 405 :-(';
echo 'The requested path "'.$path.'" exists. But the request method "'.$method.'" is not allowed on this path!';
});
Route::run(BASEPATH);
that was my index.php file  and there is my open.php
$filepath = "../".$_POST['path'];
$filename = $_POST['name'];
$mime = get_mime_type($filepath);
$file = file_get_contents($filepath);
header('Content-Type: text/plain');
header('Cache-Control: public, must-revalidate, max-age=0'); // HTTP/1.1
header('Pragma: public');
header('Expires: Sat, 26 Jul 1997 05:00:00 GMT'); // Date in the past
header('Last-Modified: '.gmdate('D, d M Y H:i:s').' GMT');
header('Content-Length: '.strlen($file));
header('Content-Disposition: inline; filename="'.basename($filepath).'";');
ob_clean();
flush();
echo $file;

`
I have a formular on an other page wich send the needed data and when I set the action directly on the open.php file everything worked fine. But when the direction points to the registered route there is only a white page.

Iis that all? coz it seems there are some files still missing but anyway have you tried ['get', 'post'] to your route as request methods

no thats not all but that are the important files from my test setup. I have just tested whether this works with ['get', 'post'] and unfortunately that doesn't work either.

look here $filename = $_POST['name'];
your code uses post constant for files, try $_FILES['name'] like $filename = $_FILES['name'];
if you're using an html form to post your data make sure you use multipart enctype

I don't understand what the current problem is. Is there a white page? Or is there an error message? Have you error logging or error messages enabled in PHP?
But there is a security issue inside your open.php.You should add
$filepath = str_replace('..','',$filepath);  (untested)
or something like that. An attacker could use a malicious request to download server files through your app using a path traversal attack. Keep in mind that path could be something like ../../../ and name could be .htpasswd or similar like this. So cut away double dots.

Please copy this to the top of your index.php to enable the complete error output:
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

Thanks for your help. Of course, I have fixed the security error. I also enabled the full error reporting in the files index.php and open.php, but there is no error output. In the Firefox developer tools, I can see the header and there is everything fine (for example, there you find the filename).
My problem is that I have a form (for downloading a file) on another page and when I set the action to the path of the open.php file everything works fine. But I like to use the Router and when I set the action to "/open" there's only a white page but with the right header.

Sorry, I have found the error. The error was not the header or the filename. The file open.php is stored in a subfolder, and I din'd specified the path correctly... I had forgotten that the file will be included.

Hey @thonajan ,
I'm glad you found the error.
You should consider using require() instead of include() since this is a critical part of your app. include() means the file will only be loaded if it exists but require() will throw an error if the file is missing or the path is wrong.

Hello @steampixel,
Thanks for that information. I will change that definitely.
Also thank you very much for your help!


Reorganize to Allow for ALL Backends and JS Frontends

Why not expand :P I'd love to learn more about FastAPI, Rails, Flask, etc.
Reorganize so that each backend is labeled by its backend name. The concepts of each framework is the same, but the steps are different. Thus I'm proposing each framework have their tutorial just inside their directory. I would still like to have in the README a high level of understanding via popular frameworks (i.e. React and Django) for users to immediately read how this works.

Need an opinion: do developers write in one IDE or multiple when it comes to SPA. + Backend development?

Need an opinion: do developers write in one IDE or multiple when it comes to SPA. + Backend development?


java.lang.NullPointerException

I was implementing a feature that required me to change the models on button click while using your package. However, I observed a strange behavior where we had to click the button to load the model and then click on the plane to make it visible in the application.
Can you suggest a solution to eliminate this double-clicking behavior?
I am attempting to avoid passing the disableInstantPlacement prop in ArViewerView.
However, when I tried to debug the code by adding a print statement in the ArViewerView.kt file, I received an error.

Could you please assist me in resolving this issue?

This might help https://www.youtube.com/watch?v=46rI2fTr_co


Potential ideas for additional prometheus metrics

This is more of an idea instead of specific work, but we have so many more locations to pull metrics from that are currently invisible.

[ ]  App server
[ ]  Postgres server
[ ]  Potential: Orchestrator Metrics?
[ ]  Potential: Janus Metrics?

[ ]  Are there existing plugins we could hook into? MQTT??? Websocket event plugins
[ ]  Accessible via the admin panel?

So, we can sort of cheat and get some of this via promtail and logs. For things using Caddy, we can easily get timings and categorise that.
I haven't yet poked at all at the Elixir or FTL bits to see how their logs are. JSON or at least mostly structured are sort of needed.
Basically though, anything matching a regex could increment a counter.
Ideally though a native solution in those services would be used.


cannot run with fish shell

metrics.sh git:(master)  ./metrics.sh -r udp
metrics.sh started with PID: 28032
Error: udp requires $UDP_PORT to be specified
Error: failed to start reporter 'udp'
Exit signal received, stopping...

Try env UDP_PORT=8888 ./metrics.sh -r udp


Using multiple backends from a single front end

The documentation at https://docs.amplify.aws/cli/teams/multi-frontend does a nice job of explaining how you can have multiple front-end apps share a common back-end. What's less clear is what is the best way to do the opposite - have a single Amplify app make use of multiple backends.
Imagine I was building a mobile app for a truck rental company to facilitate maintenance on their fleet. This company has one micro service for the trucks in the fleet and a separate micro service for the vendors capable of doing maintenance on those trucks. We want to build an app that allows someone to make use of both of those services.  That same company probably has many other services (e.g. one for customers, another for sales, another for discounts, etc.) that we don't care about for this particular app.
What's the best way to use Amplify goodness (e.g. GraphQL APIs, DataStore) in this kind of a situation? The examples I see seem designed to help an app talk to a single service (e.g. ToDo app). Having some documentation for this would be great but I'd also be happy to just get pointed to some good resources.

Hi Mike, yes I get your point about multiple backends to a single front end, but if you have been using Amplify for a while you would understand that the resources are limited to one aws-exports.js with each being a JSON object. Unless that is changed to an array list, hoping for multiple backends for the same frontend is a wish list. If needed, pretty rustic implementation would be having multiple API Gateway REST APIs which would do the job but for all the known reasons AppSync better than REST API any day.
However, if you are looking for multiple module based backends then you can build a micro-frontend that's possible over web apps where a container web app has multiple child app for each module and they can use the browser cookies for data communication but this is not possible on a native mobile app build on Android or iOS.
This is what helped me get into Micro-frontends, and resolve the problem of multiple backends for a single monolithic front-end.


Enable connecting to localhost:3000 from another computer

see http://stackoverflow.com/a/30712750/44080
This will enable easy testing on a LAN from another computer

Current coverage is 100% (diff: 100%)

Merging #90 into master will not change coverage

@@           master   #90   diff @@
===================================
  Files          10    10
  Lines         408   408
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits          408   408
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update f808892...6cf3146

Hi @CharlesOkwuagwu & thank you for the PR
Actually, we don't want nuxt to listen on all the configured network interfaces by default.
But you can configure the HOST with 2 different ways:

Via a env variable HOST

"scripts": {
  "dev": "HOST=<IP_ADDRESS> nuxt"
}

Via a nuxt config in the package.json:

"config": {
  "nuxt": {
    "host": "<IP_ADDRESS>"
  }
},
"scripts": {
  "dev": "nuxt"
}


Fix trailer error

added validation functions, missing fields

Codecov Report

Merging #104 (988a568) into master (369f1c9) will increase coverage by 0.08%.
The diff coverage is 95.00%.

:exclamation: Current head 988a568 differs from pull request most recent head d941de3. Consider uploading reports for the commit d941de3 to get more accurate results

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   81.15%   81.24%   +0.08%
==========================================
  Files          17       17
  Lines        2054     2074      +20
==========================================
+ Hits         1667     1685      +18
- Misses        240      241       +1
- Partials      147      148       +1


Collection branding doesn't work

Summary
Update re: collection branding. ref
Team, I know that the banners are broken on collection pages (or at least they have been in our instance from day one). Logos used to work on production, but in staging I tested and the logo will upload but then the page is frozen. It won't even save and update to show me if the logo renders properly. I just tested with the following collection, but it won't save my changes, so you won't see much if you go there I'm afraid: https://adl.s2.adventistdigitallibrary.org/dashboard/collections/ebbab001-fd0c-40f2-ab26-eebab8808392/edit?locale=en#branding
I tested all the branding options and none of them work on staging post-Valkyrie. We'd like the logos to work at least, if possible.
Acceptance Criteria

[ ] Uploading images on the branding tabs should display them on the collection public show page, for

[ ] logo
[ ] banner
[ ] thumbnail

[ ] alt text and url appear if entered for branding images

Screenshots or Video

Testing Instructions
On Staging, find this collection in admin dashboard > collections
Click on edit
go to the branding tab, upload an image for

banner

logo

thumbnail

alt text

url (must include http:// portion)
click save
click into the collection
click 'Public view of Collection'

[ ] your imported images should be all be viewable from this page

[ ] your alt text should be viewable via inspect in the generated html

[ ] clicking on the logo should open the url you entered

Notes

QA RESULTS: ⚠ PENDING
tested on STAGING

All features appear to function! https://adl.s2.adventistdigitallibrary.org/collections/9c5feb14-7c90-499f-aa4e-ea5cf40baf2d?locale=en


merge workflows

Pull Request Test Coverage Report for Build 340326880

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.603%

Totals

Change from base Build 340311558:
0.0%

Covered Lines:
220

Relevant Lines:
257

💛  - Coveralls


connman: enable support for Wireless daemon for Linux (iwd)

Motivation for this change
From the README:

--enable-iwd
  Enable support for Wireless daemon for Linux

  The IWD project does not have initial release so far,
  therefore by default IWD support is not enabled.

  It is safe to enable this option along WiFi support.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


[Feature request] String discriminator

Hello there,
First of all, great library!
At the moment library only understands enum as a discriminator.
In case of using EntityFramework we have a separate string Property inside a class which holds a discriminator value.
Is it possible to have string discriminator, additional to enum, which we have right now?
Thanks

Hi @toddams, thanks for peeking in;
Unfortunately the only way we can automagically match up the discriminator with a concrete type to deserialize to is by knowing an exhaustive list of options, which the enum helps us with. If it wasnt an enum, we would have to effectively do all the work of an enum anyway, with something like [JsonDiscriminator("string1", "string2", "string3")], which IMO would not be super beneficial.
HOWEVER, I think you should be able to store the enum value as a string in your database while still using an enum in code, if you know all the values the string can be.
With EF Core the code would look like this:
https://docs.microsoft.com/en-us/ef/core/modeling/value-conversions#the-valueconverter-class


Pandas concat incorrectly marks subsequent code as unreachable

When using the Pandas concat function to concatenate DataFrames, any code following the concat call is mistakenly marked as unreachable, even though it should be executed.
import pandas as pd
def concatenate_dfs(dfs):
final_df = pd.concat(dfs, ignore_index=True)
#Following line should be reachable, but it's marked as unreachable
final_df.reset_index(drop=True, inplace=True)
return final_df
Example usage
dfs = [pd.DataFrame({'A': [1, 2, 3]}), pd.DataFrame({'A': [4, 5, 6]})]
result_df = concatenate_dfs(dfs)
print(result_df)

Duplicate of #888 and fixed in #890


Network is unreachable

Hello:
I had deployed swift successfully,  pods and services has be start like this:
po/swift-1067258244-tcv43                  1/1       Running   0          15m       <IP_ADDRESS>    k8s-master1
po/tiller-deploy-12052176-k8jwb            1/1       Running   0          41m       <IP_ADDRESS>    k8s-master2

svc/swift                  <IP_ADDRESS>   <none>        9855/TCP,50055/TCP,56790/TCP   14m       app=swift
svc/tiller-deploy          <IP_ADDRESS>   <none>        44134/TCP                      40m       app=helm,name=tiller

and I visit
curl http://<IP_ADDRESS>:9855/tiller/v2/version/json
and it return like this :
{"code":2,"message":"Get https://<IP_ADDRESS>:443/api/v1/services?labelSelector=app%3Dhelm%2Cname%3Dtiller: dial tcp <IP_ADDRESS>:443: connect: network is unreachable"}
I think the swift can not connect tiller correctly?

Are you running in a RBAC enabled cluster? From the error message, it seems that Swift can't connect to the Kube api server.

https://github.com/appscode/swift/blob/03ac40272c0d2bead6483acaf96862be99f6b550/pkg/factory/incluster_connector.go#L37
This particular api call is failling.

I had created role and account service using with-rbac.yaml ,
[root@k8s-master2 ~]# k get sa
......
swift                        1         7h

How can I specify the tiller host and port?
thank you.

Your tiller host and port is auto detected in incluster mode. Swift finds the service that has label app=helm,name=tiller using Kubernetes api and connects to that service.

You can join our Slack https://slack.appscode.com/ . I am happy to help you debug this issue.

Thank you first.
I think this problem is because the swift proxy can not connect to kube api server too.
but here is a api server :
svc/kubernetes                   <IP_ADDRESS>             443/TCP    8d
and this kubernetes serivce is in the default namespace, but swift and tiller are all in kube-system namspace. is this reason?

I have a bug in the RBAC. https://github.com/appscode/swift/pull/47
If you can update the Swift Role and try that will help.

I have fixed another problem with installer in RBAC mode. I have pushed a release https://github.com/appscode/swift/releases/tag/0.3.1 with the fixes. I have checked these manually. Please retry should work.

Thank you very much,  I had retried it by upgrading to the newest release, and it can work now,
curl http://<IP_ADDRESS>:9855/tiller/v2/releases/json

{"releases":[{"name":"khaki-cricket","info":{"status":{"code":"DEPLOYED","notes":"1. Get the application URL by running these commands:\n  export POD_NAME=$(kubectl get pods --namespace default -l \"app=wolve-sample,release=khaki-cricket\" -o jsonpath=\"{.items[0].metadata.name}\")\n  echo \"Visit http://<IP_ADDRESS>:8080 to use your application\"\n  kubectl port-forward $POD_NAME 8080:8090\n"},"first_deployed":"2017-09-21T02:31:15.695250345Z","last_deployed":"2017-09-21T02:31:15.695250345Z","Description":"Install complete"},"chart_metadata":{"name":"wolve-sample","version":"0.1.4","description":"A wolve sample","apiVersion":"v1"},"config":{"raw":"{}\n"},"version":1,"namespace":"default"}]}

Perfect, Thank you again.


Comparing EditorState instances

Do you want to request a feature or report a bug?
Feature, I think.
What is the current behavior?
Creating EditorState instances, at least using createWithContent/createFromText, produces different keys in the block map.
It would be much easier to test my code if my tests could create EditorState instances the same way as the real code and get equal results. Failing that, do you have any guidance on how to test code that creates and modifies an EditorState?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.
https://jsfiddle.net/m6z0xn4r/286/ shows the problem.
What is the expected behavior?
I would like creation and modifications of EditorState to be deterministic, so that tests are easier to write.
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
This happens with Draft 0.7, 0.10 and 0.10.6.

hi @malcolmredheron , if you do need deterministically created contentState, you can get the same effect with convertFromRaw using a very basic rawDraftContentstate as in https://jsfiddle.net/9m3pqwnu/ (this was a ~0.10.1ish change to get ssr not throwing errors)

Good to know! Thank you.


Fix broken containers resulting from CRs in scripts

The Problem/Issue/Bug:
In https://github.com/drud/ddev/pull/902 I deliberately let slide test failures on Windows of the containers. This is to fix that. Hopefully getting buildkite to check out as-on-server, with linefeeds and no CRs will solve that problem.
How this PR Solves The Problem:
I think the largest part of the problem was that Windows agents have to check out at least the container stuff with autocrlf=false, so we have shell scripts that don't have CRs in them.
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

ddev-containers-windows was clean on this one, not sure why buidkite and thus github report it as a failure. Retrying ddev-containers-macos.


Remove hardcoded npm path

As I noticed, we are assuming that npm path will always be the same. This assumption is something we don't do for nodejs binary ($nodejs_bin), for example. Beside that is also hardcoded, so I exported as a parameter that can be overwritten in case of being necessary.

Thanks @bcfurtado!


Add a new section "More About Me" between "Ready Made Sections" and "That's about it!"

torvalds.dev is analyzing the ticket

Based on the provided information, it seems like you are working with a React.js application where the content is stored in JSON files. The task is to add a new section "More About Me" between "Ready Made Sections" and "That's about it!".
Here is a plan to achieve this:

Create a new JSON file in the src/content/ directory named MoreAboutMeContent.json. This file will hold the content for the new section.

In MoreAboutMeContent.json, add the title and text for the new section. The structure should be similar to the other JSON files. For example:

{
  "title": "More About Me",
  "text": "This is where you can add more information about yourself."
}

In the React component where these sections are rendered, import the new JSON file.

import moreAboutMeContent from './content/MoreAboutMeContent.json';

Render the new section at the appropriate place in the component, between the "Ready Made Sections" and "That's about it!" sections.

Relevant files for this task are:

The new JSON file src/content/MoreAboutMeContent.json that you will create.
The React component file where these sections are rendered. The exact file name is not provided, but it should be in the src/ directory. Look for a file where MiddleBlockContent.json, ProductContent.json, and MissionContent.json are imported and used.


Create Sprite for MP40

Please see CONTRIBUTING.md first.

I'll make it. No worries

Thanks @estim! :smiley:


Add several backports to 1.6

Fixes #10000

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

@jacobmarble there are bunch of other dependencies that need to go into Godeps I think. Mainly from klauspost. I think they were missed off of #9856. You can cherry pick https://github.com/influxdata/influxdb/pull/9983 in I think to sort it.

During a run of megacheck the following issues were discovered:

dep ensure makes no change to Gopkg.lock.

@e-dard PTAL


issue #88 Onboarding process of Ibrahim Kabir

Throughout Ibrahim Kabir's onboarding process, specific areas for improvement were noted:

Training Time Descriptions Missing: Backend training lacks adequate time descriptions.
Exercises Gap in Training: Backend training lacks PostgreSQL exercises.

Tasks:

[ ] Update time descriptions.
[ ] Incorporate new PostgreSQL exercises into the training.

Acceptance Criteria:

The training should equip the developer with the skills necessary to work within the AI LAB's framework.
The training should provide accurate time estimates for each module.

Closes PR:

Closes #88

@rngadam The URL for: Best Practices for Naming Git Branches is no longer accessible (404). It seems they have migrated to this new link. This is causing a check failure. Do you approve the modification to the new link?

@rngadam The URL for: Best Practices for Naming Git Branches is no longer accessible (404). It seems they have migrated to this new link. This is causing a check failure. Do you approve the modification to the new link?

No need to ask for approval for this kind of obviously broken, obvious fixes kind of problems, especially since I have the opportunity to give feedback in the code review process.

check fails so the priority is to make it pass.

@ibrahim-kabir please prioritize finishing up ongoing work.


crash on start of app

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Start app, pair with flipper or start app with already paired flipper
Crash

Expected behavior
A clear and concise description of what you expected to happen.
App works
Logs
eb965b42f14d4efd8382db45f3f71789 - from app
from serial:
145682 [I][BtGap] Connection parameters: Connection Interval: 39 (48 ms), Slave                                                                                Latency: 0, Supervision Timeout: 500
145685 [W][BtGap] Unsupported connection interval. Request connection parameters                                                                                update
146128 [I][BtGap] Connection parameters event complete
146130 [I][BtGap] Connection parameters: Connection Interval: 30 (37 ms), Slave                                                                                Latency: 0, Supervision Timeout: 500
146309 [I][BtGap] Pairing complete
146312 [I][BtSrv] Open RPC connection
146609 [I][BtGap] Connection parameters event complete
146611 [I][BtGap] Connection parameters: Connection Interval: 6 (7 ms), Slave La                                                                                tency: 0, Supervision Timeout: 500
146613 [W][BtGap] Unsupported connection interval. Request connection parameters                                                                                update
146795 [I][BtGap] Connection parameters event complete
146798 [I][BtGap] Connection parameters: Connection Interval: 30 (37 ms), Slave                                                                                Latency: 0, Supervision Timeout: 500
147458 [I][BtGap] Rx MTU size: 414
147758 [I][BtGap] Connection parameters event complete
147761 [I][BtGap] Connection parameters: Connection Interval: 12 (15 ms), Slave                                                                                Latency: 0, Supervision Timeout: 500
147763 [W][BtGap] Unsupported connection interval. Request connection parameters                                                                                update
147923 [I][BtGap] Connection parameters event complete
147926 [I][BtGap] Connection parameters: Connection Interval: 30 (37 ms), Slave                                                                                Latency: 0, Supervision Timeout: 500
153559 [I][BtGap] Disconnect from client. Reason: 13
153563 [I][BtSrv] Close RPC connection

Target
Specify the target
0.68.1-rc, hardware_ver: 12 (flipper)
<IP_ADDRESS>9 (app)
Additional context
Add any other context about the problem here.

logcat
time:<PHONE_NUMBER>010
msg: java.lang.NumberFormatException: For input string: "1,61"
stacktrace: java.lang.NumberFormatException: For input string: "1,61"
	at jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
	at jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
	at java.lang.Double.parseDouble(Double.java:543)
	at a2.b.l(PlaceholderExtensions.android.kt:5)
	at an.e.a(LazyJVM.kt:4)
	at a2.f.q(TtsAnnotationExtensions.android.kt:10)
	at bd.h.b(ComposableInfoCardContent.kt:32)
	at bd.h.a(ComposableInfoCardContent.kt:60)
	at bd.h$a.c0(ComposableInfoCardContent.kt:1)
	at f0.i.m0(Composer.kt:44)
	at f0.i$h.z(Composer.kt:20)
	at e.f.H(Unknown Source:8)
	at f0.i.X(Composer.kt:23)
	at f0.i.k0(Composer.kt:4)
	at f0.u.r(Composition.kt:7)
	at f0.p1.r(Recomposer.kt:9)
	at f0.v1$a.i0(Recomposer.kt:63)
	at androidx.compose.ui.platform.e0$c.doFrame(Unknown Source:8)
	at androidx.compose.ui.platform.d0$d.doFrame(AndroidUiDispatcher.android.kt:15)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
	at android.view.Choreographer.doCallbacks(Choreographer.java:899)
	at android.view.Choreographer.doFrame(Choreographer.java:827)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7893)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:550)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
	Suppressed: yn.p0: [f0.f1@8fefb7f, androidx.compose.ui.platform.h1@86bf74c, d2{Cancelling}@c19a395, d0@1003caa]

Additional information:
after tinkering with hardware, i managed to start app reliably with out installed sd card
at top of the screen will appear notification about FW update not possible until sd card will be installed
it is not going out even after card installement, and hitting syncronise
SD Card field shows Not Found
access to file system on SD is possible
but, when i hit Retry in Firmware update window, it thinks a second or two and crashes. Do ya wanna me reproduce and send you logs?

Yeah, thx for report, if fix that in #401

Try use next version <IP_ADDRESS>8 and give feedback

Couldn't find <IP_ADDRESS>8, so took <IP_ADDRESS>9, everything works now, no crash, update successful


Improving share option

Now when you share a single item, the item name will be mentioned.
Sharing multiple items will show how many items are being shared.
Share menu item is now disable on unsupported devices (e.g. Xbox). This is the first step in making Files UWP truly universal across Windows devices.
All strings related to the share dialog are localized.

@tsvietOK No space is required otherwise it will appear like 'Sharing 1items'.


add trailing slash redirect middleware to adapter-node

fixes #8755
Adds prerendered pages to the manifest so that a middleware can check if a counterpart route exists, and redirect to it.
I'm not too experienced with Express / Polka and writing middleware for them, so I'm sure this can be fixed up a bit.
Specifically, I'm sure there's a way to skip the middleware for serving prerendered routes and go straight to ssr.
We should do this since we already check if it's prerendered or not.
Also, I'm not sure if there are any penalties for including the prerendered routes list in the manifest.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Thanks Rich!

this is great. i guess we might decide this needs to be in the framework core somehow (e.g. the server has knowledge of all prerendered paths, and can redirect accordingly), but 👍 for the simple fix for now


Failing to install openai due to FileNotFoundError

Hi guys, first of all really good work so far!
It seems a file is missing here. I follow your steps to get going, but in the step of installing w poetry following happens
poetry install --no-root
(everything installs well exept openai)
Installing openai (1.58.1): Failed
FileNotFoundError
This is the file missing:
pypoetry\Cache\virtualenvs\zerepy-799_jFSa-py3.12\Lib\site-packages\openai\types\beta\realtime\conversation_item_input_audio_transcription_completed_event.py'

I just tried on windows now and it worked fine so your issue might be from a corrupted or incomplete download. Try clearing poetry cache and reinstalling.


Users from all userstores are not getting displayed when navigating to the Users tab

Describe the issue:
Navigating to Users tab from any other tab displays only the users from the PRIMARY userstore.
Reason
The SCIM API call made to retrieve users is being sent to specific userstores. (In this scenario, DEFAULT and PRIMARY). The request should be sent without the domain query parameter.
How to reproduce:

Create users in 2 different user stores. (PRIMARY and a secondary one.)
Navigate to Users tab from any other tab.
It only displays users from PRIMARY userstore.

Expected behavior:
Users page should display all the users if All user stores option is chosen in the dropdown.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS-7.0.0-alpha2

Screenshots

We are planning to remove the support for All user stores and with that you have to specify the exact user store.

Related issue https://github.com/wso2/product-is/issues/17761


[AnimationPlayer] Audio Playback Track does not work in the middle of playback

Godot version
v4.0.beta17.official [c40020513]
System information
Windows 11 Pro
Issue description
In AnimationPlayer, Audio Playback Track does not work in the middle of playback, as in v3.5.1.stable.official [6fed1ffa3]
Steps to reproduce
(Do on both versions)
Add root node -> Node
Add AnimationPlayer and AudioStreamPlayer

Add new animation, Add Audio Playback Track
Drag & Drop audio test.ogg on track with a time offset of 1

Play animation before the start of the track, at the beginning of the track and somewhere during the track (turn on the sound)
v 3.5.1
https://user-images.githubusercontent.com/91904840/216314742-80982bb9-23a3-4eb5-8e98-249c3531aa66.mp4
v 4.0.beta17
https://user-images.githubusercontent.com/91904840/216314798-23f212f2-c386-4dc1-8946-648e5f8f2467.mp4
You'll notice, that on version 4.0.beta17 Audio Playback Track does not work in the middle of playback!
Minimal reproduction project
Normal playback
godot_3.5.1.zip
Cracked playback
godot_4.0.beta17.zip

cc @TokageItLab

In addition to the above, if you change the animation length change to lower the length of the audio, the audio will still keep on playing & doesn't stop even if the animation length has been reached. See the sample video below:
https://user-images.githubusercontent.com/39092464/216781748-36da7a49-7a6e-45f7-bf57-ea22a8f3cc90.mp4


Disable recently problematic rules

This is to follow https://github.com/alphagov/rubocop-govuk/pull/124 it disables two rules that prove problematic as a result of the dependency updates. This build will fail until #124 is merged and this is rebased onto it. Further details in the commits.

This makes sense to me - I agree with both of the overrides and the attached explanations. Following the discussion in #124, I'm still concerned about a couple of Cops that we're leaving enabled:

Lint/MissingSuper - I think this will lead to unnecessary boilerplate, and is really a testing issue. I don't see the harm in disabling it, but I can see the irritation of applying it, especially if we continue reusing patterns like ApplicationService in other repos. Can you think of a benefit to applying it, that wouldn't be covered in testing?

Lint/UselessMethodDefinition - this one sounds beneficial on the surface, but is actually an issue for Rails controller actions: removing the "useless" method definition will lead to an error. A compromise here might be to disable it for app/controllers specifically, or maybe more specifically in the affected repos / controllers.

Thanks @benthorner for taking a look and for your help with this 👍  It's good that we're down to only a couple of divisive points in the world of linting.
For both the rules you referenced I don't have particularly strong opinions for or against them myself (like many rules can see the occasional benefits and then times of annoyance). I therefore find myself leaning slightly more towards allowing them and seeing if they cause problems as the divergence of disabling rules is something we carry for a long time.

Lint/MissingSuper - I think this will lead to unnecessary boilerplate, and is really a testing issue. I don't see the harm in disabling it, but I can see the irritation of applying it, especially if we continue reusing patterns like ApplicationService in other repos. Can you think of a benefit to applying it, that wouldn't be covered in testing?

From @theseanything's stats it seems like this isn't too widespread a problem - mostly one we've introduced relatively recently into Content Publisher and Email Alert API. I can certainly see why it'd be annoying for those. However since it's so low widespread there is a part of me that wonders: are we actually coding in a strange way to hit this problem? I guess what we're doing that is odd is using the subclass as the place to define an interface that isn't on the superclass - this seems a violation of Liskov substitution principle but then this isn't the most Rubyist of principles - similar things exist in Sidekiq workers for instance with the perform interface. Perhaps though, we've used direct inheritance when a mixin is more appropriate for the type of behaviour that is shared?

Lint/UselessMethodDefinition - this one sounds beneficial on the surface, but is actually an issue for Rails controller actions: removing the "useless" method definition will lead to an error. A compromise here might be to disable it for app/controllers specifically, or maybe more specifically in the affected repos / controllers.

Sure. I can't quite see why that'd cause a Rails error (could you explain?) however I can see that this causes an annoyance when considered with Rails/LexicallyScopedActionFilter (as per commits like https://github.com/alphagov/whitehall/commit/7fd5fa0151477e1c788e378578e9b190fcf04b7d) - so it seems, for Whitehall at least, that we can only have one of these enabled - I'm not sure the impact on other apps. The fact that this rule is auto-correctable isn't much help if it just triggers a different one in one place. I'm not sure the best course of action to take, I'm somewhat hopeful only Whitehall is particularly grim with the mix of inheritance with different before_action 😬  so might be able to dealt with in just that repo.
You also mentioned in your comment:

more generally how we're going to apply this update so repos don't get left behind.

Yup - this is a tricky problem. I see two aspects to it - the initial dropping of this change to see if any of the rules are really miserable and then the long tail of getting it everywhere. I'm wondering whether it might be worth doing a pre-release of this gem with the new rules and applying them to a bunch of our key repos first (with a little call for volunteers to help) to iron out the first step. Second step would probably involve needing a few volunteers again, I somewhat imagine that since I'm involved in the release I'll have a drive to make it happen everywhere.

Hmm...I'm in still in two minds with Lint/MissingSuper. It's not auto-correctable, so I'm leaning towards us pushing ourselves to question its value: what do we gain by having this rule? The Liskov principle isn't something I'm familiar with, and looking at it I agree it's not really for Ruby, which doesn't have a formal way to define "interfaces".

are we actually coding in a strange way to hit this problem?

This gave me some pause for thought. I think patterns like this (for anyone else reading) are OK, though:

It is true to say that ServiceX is a ApplicationService.
It is conventional to initialise state in the constructor.
(Precedent: everything inherits from Object, yet doesn't call super.)

I believe the pattern we have is the most minimal to achieve the desired, class-level interface, which I take as a sign that it's the "best" or "right" one for the job. So I'd only expect its usage to grow. Unless we can think of an advantage over testing, then it seems in our interest to disable the rule. Ruby isn't meant to be a boilerplate-y language, after all.

Sure. I can't quite see why that'd cause a Rails error (could you explain?)

Ahh, I misremembered this, sorry. It was actually that Rails/LexicallyScopedActionFilter encourages you to create empty methods that break the code unless they call the superclass method explicitly. So removing them isn't a problem. Both of them are quite circumstantial, so it's hard to choose between them.
I think it's important we promote a good experience with this repo. Even one instance of this conflict would be quite a poor experience for the developer trying to figure out how to resolve it. On that basis, I think we should scope Lint/UselessMethodDefinition to exclude app/controllers, where it's unlikely to apply anyway.
That was long. Here's a quick summary of my thoughts so far:

Lint/MissingSuper - will entail manual work for unclear benefit. I think we need a clear argument for it.
Lint/UselessMethodDefinition - restrict to exclude app/controllers, to avoid current and future conflicts.

I also like your idea of a pre-release, which nicely captures the potential compatibility issues that may crop up when applying all the changes. Perhaps @theseanything you'd like to comment here. What's your take on these Cops?

The Liskov principle isn't something I'm familiar with, and looking at it I agree it's not really for Ruby, which doesn't have a formal way to define "interfaces".

Ah sure, it's the L in SOLID. It's a principle applied to Ruby frequently so I may have mis-represented it as saying it's not the most Rubyists of rules, something to aspire too but not dogmatic.

are we actually coding in a strange way to hit this problem?

This gave me some pause for thought. I think patterns like this (for anyone else reading) are OK, though:

It is true to say that ServiceX is a ApplicationService.
It is conventional to initialise state in the constructor.
(Precedent: everything inherits from Object, yet doesn't call super.)

I believe the pattern we have is the most minimal to achieve the desired, class-level interface, which I take as a sign that it's the "best" or "right" one for the job. So I'd only expect its usage to grow. Unless we can think of an advantage over testing, then it seems in our interest to disable the rule. Ruby isn't meant to be a boilerplate-y language, after all.

Sure, I'd have thought it could be similarly minimal as a mixin? I guess the two parts that make me question what we've done here is 1) it seems to be a violation only affecting new(ish) code rather than a wider GOV.UK precedent? and 2) the question asked about this rule is (paraphrased) "what is a good reason to not call super?" and the only answer I've got for this example is that it's not really a class we're inheriting from it's more a behavioural pattern, as we'd not expected the class to actually do anything.
Happy to be led by others input into this - I know this has become a very specific discussion 😄

Sure. I can't quite see why that'd cause a Rails error (could you explain?)

Ahh, I misremembered this, sorry. It was actually that Rails/LexicallyScopedActionFilter encourages you to create empty methods that break the code unless they call the superclass method explicitly. So removing them isn't a problem. Both of them are quite circumstantial, so it's hard to choose between them.
I think it's important we promote a good experience with this repo. Even one instance of this conflict would be quite a poor experience for the developer trying to figure out how to resolve it. On that basis, I think we should scope Lint/UselessMethodDefinition to exclude app/controllers, where it's unlikely to apply anyway.

Ok great about the errors. I kind of feel if we wanted to have an exception it'd be better to disable Rails/LexicallyScopedActionFilter rather than conditionally disabling Lint/UselessMethodDefinition to a particular directory - that feels a little less surprising than a rule only applying to certain directories.
I'm worried though that this talk of disabling is almost entirely driven by Whitehall where the code affecting this is already pretty whacky - where it'd seem reasonable to do an inline ignore on the offending controllers. Do we know where the other cases of this are?

That was long. Here's a quick summary of my thoughts so far:

Lint/MissingSuper - will entail manual work for unclear benefit. I think we need a clear argument for it.
Lint/UselessMethodDefinition - restrict to exclude app/controllers, to avoid current and future conflicts.

I also like your idea of a pre-release, which nicely captures the potential compatibility issues that may crop up when applying all the changes. Perhaps @theseanything you'd like to comment here. What's your take on these Cops?

Great, thank you - I'll try plug some other people to take a look at this tomorrow too.

I kind of feel if we wanted to have an exception it'd be better to disable Rails/LexicallyScopedActionFilter [...] Do we know where the other cases of this are?

Yes, after writing this I realised I was biased towards Whitehall. Looking at it that way, I agree the inheritance structure in that repo is unusual and not something we'd want to replicate elsewhere. So it makes sense to do something specifically in Whitehall, as I'm not aware we have filtered, inherited controller actions anywhere else. Both of the rules are quite niche, but the lexical one has the benefit of being more directly related to the code, so easier to explain disabling it.
So I'd agree with you there, well argued!

it seems to be a violation only affecting new(ish) code rather than a wider GOV.UK precedent?

(Facetious, but the wider GOV.UK precedent here appears to be "a mess", so I'm not particularly swayed by this 😸.)

Sure, I'd have thought it could be similarly minimal as a mixin?

I think it would be slightly more verbose. The actual problem seems to be withinitialize, so with a mixin or with inheritance we'd end up having to define some other setup method to avoid the Cop. This is what I find pointless: it doesn't make sense to me to have to initialize a service with nothing, and then have to call another method to do the equivalent. Arguably the Cop is just unintelligent: the calls to super are pointless, but it doesn't do enough checking to see that.
I think this really comes down to a decision: do we want to put super in lots of places it's not needed, or rewrite the existing patterns more verbosely so the Cop arbitrarily doesn't notice them, or disable the Cop for those classes?

+1 on the idea about pre-releases. It'd be a good way to gauge the real impact of changes.
As for Lint/MissingSuper, I think it should be enabled. As Kevin said, for this particular example we might want to consider composition rather than inheritance. For me it's quite odd, there's only a partially shared interface (the call method) and no common behaviour between sibling classes. For that particular example, could we re-write it as the following without increase verbosity?:
module Service
  def call(*args, **kwargs)
    new(*args, **kwargs).call
  end
end

class DataLoader
  extend Service

  def call
    #do_something
  end
end

I think this type of rule would help us think about our code design, i.e. we are calling super, but we don't actually need it - is inheritance actually appropriate here?

@theseanything this is what discussion with @kevindew. What's difficult here is that this change affects quite a lot of files, which will need to be manually fixed. Apart from blindly adding super everywhere, which isn't really helping anyone, there doesn't seem to be a "better" alternative to what we have now. Your example is a bit too minimal:
module Service
  def call(*args, **kwargs)
    new(*args, **kwargs).call
  end

   # can't do "private_class_method :new" here :-(
end

class DataLoader
  extend Service

  def initialize(arg_i_need)
     @arg_i_need = arg_i_need
  end

  def call
    #do_something
  end
end

The use of initialize is really the crux of the pattern and the problem with this Cop: most services (or other classes using a similar pattern) need data to run. It makes sense to initialize them with this data, as this means we can avoid passing all the data around to any private methods used by call. So, if the service needs data to exist, it makes sense for it to be initialized with that data. Or, we could switch to a more verbose pattern, like this:
module Service
  def call(*args, **kwargs)
    new.setup(*args, **kwargs).call
  end
end

class DataLoader
  extend Service

  def setup(arg_i_need)
     @arg_i_need = arg_i_need
  end

  def call
    #do_something
  end
end

And this is what I'm against: setup is really just a synonym of initialize. They do the same thing, the only different is that with setup, RuboCop doesn't force us to write super in it.
My conclusion so far is that applying this Cop will be a net deterioration: genuine omissions of super should be caught in testing; we shouldn't rely on linting to spot bugs. So I'm keen to explore how we can configure this Cop so the end result is sensible. That seems to hinge on agreeing whether there's merit in the "Service" pattern we've got.
Can you see the tradeoff here?

@benthorner If I understand right you're theorising that with a mixin you'd still need to avoid initialize, however that wouldn't be the case (I actually cobbled together a rough implementation when chatting about this the other day here: https://github.com/alphagov/content-publisher/commit/7b117d7fd3b890d13b0c6e9472a744b159ecd976). Whereas the setup example you've defined there is how you would approach this with inheritance, as that would keep the initialize method free for the superclass to implement.
With a mixin - you tend to be adding an interface to a class rather defining the class' lifecycle. For example, using include Enumerable from stdlib you'd not expect that to be altering initialize. Whereas with a class approach from stdlib, SimpleDelegator, you'd fully expect to need to call super if you extended initialize.
I forgot the other day to shout to get other eyes on this, I'm thinking I could do that tomorrow but it might not be the most inviting of a conversations to get involved in 😆 .  It may be worth trying to summarise the concerns to see if they can be tested?

Sure, thanks for digging into it a bit more @kevindew. Here's a summary for anyone reading:

We're all agreed on disabling Naming/VariableNumber and RSpec/MultipleMemoizedHelpers.
We're all agreed on doing a pre-release of the overall v1 upgrade, so we can trial it on certain repos.
I'd like to also consider disabling Lint/MissingSuper, as it conflicts with a pattern we have in e.g. Content Publisher.

Latest thoughts from me on Lint/MissingSuper:

If we leave it enabled, we should have a plan to address it that's not adding super everywhere it's not necessary.
I've since learnt the Cop can be avoided with a use of extend, and @theseanything suggested an approach.
@kevindew refined the approach to match the current behaviour, and suggested a granular, trait-like naming for it.

That last one tips the balance for me, especially since it's clearly distinct from the current base classes ApplicationService, which are conventionally inherited from (e.g. ApplicationRecord, ApplicationController).
So, I'm for approving this PR, if we're comfortable with the new approach to avoid Lint/MissingSuper.

Great thanks for that summary @benthorner.
So a quick proposal on next step actions:

You (or someone else) approves this PR
I do a shout in #govuk-developers to say "Anyone have concerns on the linting rules that are coming" to see if this raises concerns for anyone
If there aren't concerns in a day I'll merge these PRs and create a PR to create the pre-release version of the gem. I'll accompany that with an issue with the pre-release for anyone to point out pain points (I'll include the concerns about Lint/MissingSuper and Lint/UselessMethodDefinition there)
I'll then encourage some people to try it, though it might be mostly me trying it. I'll plan to delay Content Publisher and Email Alert API a bit here

Does this sound ok? and are we happy for this to be the long foretold 4.0.0 release?


Display Azure AD tenant name in tenant picker

Is your feature request related to a problem? Please describe.
Currently, when using swa login, it displays a list of tenant id's in a picker. Can it also include the tenant name?

Closing this issue as it has been done in this commit: https://github.com/Azure/static-web-apps-cli/commit/a2ee6768bb6f8dcace5b0f99643e152580f68682
Running swa login using the latest version shows subscription names in the picker rather than id's. Please feel free to re-open or submit a new issue if I am mistaken!


DOCS-309: MinIO Hybrid Cloud User Management

Issue resolves #309
Summary
Document MinIO Console-based User, Group, and Policy management. Includes Service Account docs.
Key pages:

http://<IP_ADDRESS>:8000/tutorials/user-management.html
http://<IP_ADDRESS>:8000/tutorials/group-management.html
http://<IP_ADDRESS>:8000/tutorials/policy-management.html

Build Instructions
Clone, fetch, and checkout DOCS-309 branch.
python -m pip install --user virtualenv
python3 -m venv venv

source venv/bin/activate
pip install -r requirements.txt
make html
python -m http.server --directory build/DOCS-309/html

just a question on User Management:
3) Copy the Service Account Credentials

Should we also mention that if credentials are lost you will have to recreate the Service Account?

just a question on User Management:
3) Copy the Service Account Credentials

Should we also mention that if credentials are lost you will have to recreate the Service Account?

just a question on User Management:
3) Copy the Service Account Credentials

Should we also mention that if credentials are lost you will have to recreate the Service Account? Or is it implicit?

Oh, yes definitely. Also need to include that you cannot update the credentials or policy after creation. Will add that to next patch.

just a question on User Management:
3) Copy the Service Account Credentials

Should we also mention that if credentials are lost you will have to recreate the Service Account? Or is it implicit?

Oh, yes definitely. Also need to include that you cannot update the credentials or policy after creation. Will add that to next patch.

on Group Management:
Open the Group Management Interface: .... If the Admin navigation group is collapsed...

Should we mention that if the Admin page is not visible is because the user might not have enough permissions?

on Group Management:
Open the Group Management Interface: .... If the Admin navigation group is collapsed...

Should we mention that if the Admin page is not visible is because the user might not have enough permissions?

Apart from that everything looks neat!

Apart from that everything looks neat!

on Group Management:
Open the Group Management Interface: .... If the Admin navigation group is collapsed...

Should we mention that if the Admin page is not visible is because the user might not have enough permissions?

Yeah, I actually intend to go into a lot more detail in the security collapsible as far as the exact perms needed in a second pass. For now I will definitely make that explicit.

on Group Management:
Open the Group Management Interface: .... If the Admin navigation group is collapsed...

Should we mention that if the Admin page is not visible is because the user might not have enough permissions?

Yeah, I actually intend to go into a lot more detail in the security collapsible as far as the exact perms needed in a second pass. For now I will definitely make that explicit.


[META] ML Inference Processor Flexibility Enhancements II

Is your feature request related to a problem?

[x] Currently, search response processor can add prediction results to new fields to extensions. Try to enable option to save the model prediction to the extension part in the search response.
[x] For rerank use cases, we need to pass on the query_text to the model input dataset along with the documents in the search response. Try to enable reading value from query body in model config.
[x] For rerank use cases, we also need a rescore processor that can rank the search hit and update the new scores.

All META Issues for ML Inference Processor:
https://github.com/opensearch-project/ml-commons/issues/2839
What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

closing this issue as features are implemented in 2.18


Converting from anyhow::Error

Hi,
I am porting multiple crates from anyhow to eyre, so I have code that looks something like this:
fn foo() -> Result<(), anyhow::Error> {
  Ok(())
}

fn bar() -> Result<(), eyre::Report> {
  let f = foo().map_err(|e| eyre::Report::new(e))?;
  Ok(())
}

This, as expected, gives
error[E0277]: the trait bound `anyhow::Error: std::error::Error` is not satisfied
  --> src/lib.rs:6:49
   |
6  |     let f = foo().map_err(|e| eyre::Report::new(e))?;
   |                                                 ^ the trait `std::error::Error` is not implemented for `anyhow::Error`
   |
  ::: /home/akshayn/.cargo/registry/src/github.com-1ecc6299db9ec823/eyre-0.6.0/src/error.rs:21:12
   |
21 |         E: StdError + Send + Sync + 'static,
   |            -------- required by this bound in `eyre::error::<impl eyre::Report>::new`

error: aborting due to previous error

Since anyhow::Error and eyre::Report are so similar, is there a better way to construct an eyre::Report mid-stack than this, which is sad and throws out the context:
fn foo() -> Result<(), anyhow::Error> {
  Ok(())
}

fn bar() -> Result<(), eyre::Report> {
  let f = foo().map_err(|e| eyre::eyre!("{:?}", e))?;
  Ok(())
}

Thanks for the help!

the best way to convert between the two would be to first convert the anyhow::Error to a Box and then convert that to an Eyre report with the macro. that way you'll preserve the chain of sources at least, though you'll still loss the backtrace that anyhow captured originally.

that makes sense, thanks!

map_err(|err| eyre!(Box::new(err))

Alternatively you can wrap this inside a declarative macro
map_err!(foo());

#[macro_export]
macro_rules! map_err {
  ($fun:expr) => {
    $fun.map_err(|e| eyre!(Box::new(e)))?
  }
}

@yaahc Please let me know if you welcome a PR

@yaahc Please let me know if you welcome a PR

I've no objections to adding an anyhow_compat feature, PRs welcome

What's the status of this feature?
I would like to use ? on anyhow results on functions which return eyre::Result.

I would like to use ? on anyhow results on functions which return eyre::Result.

This is not permitted by Rust's orphan rules, unfortunately.

Just for future readers:
foo().map_err(|err| eyre!(Box::new(err))

Ah sadly this will lose the source information, because it will produce a Box<anyhow::Error>. (I really don't like auto-deref specialization...).
What you want to do is:
    foo().map_err(|err| {
        eyre!(Box::<dyn std::error::Error + Send + Sync + 'static>::from(
            err
        ))
    });

Very wordy unfortunately. eyre can help here by providing a new_boxed method which would let type inference work.

This is not permitted by Rust's orphan rules, unfortunately.

It is permitted. The From impls you would want are:
impl<E> From<E> for Report
where
    E: Into<anyhow::Error>,
    Result<(), E>: anyhow::Context<(), E>,
{
    fn from(error: E) -> Self {
        let anyhow_error: anyhow::Error = error.into();
        let boxed_error: Box<dyn StdError + Send + Sync + 'static> = anyhow_error.into();
        Report::from_boxed(boxed_error)
    }
}

impl From<Report> for anyhow::Error {
    fn from(report: Report) -> Self {
        let boxed_error: Box<dyn StdError + Send + Sync + 'static> = report.into();
        anyhow::Error::from_boxed(boxed_error)
    }
}

This would provide ? in both directions.

@dtolnay oooooh that looks like a clever approach. Would that be a breaking change? (Or if gated by a feature, would it be non-additive? I guess Into<anyhow::Error> covers everything.)

It is additive with the existing impl.
I discussed this impl with eyre maintainers in June as part of https://github.com/eyre-rs/eyre/issues/177; not sure whether there's since then come up a reason not to implement it.

I think the work has just been on hold for personal reasons mostly, tho I do recall a conversation about some issue w/ multiple layers of Box being introduced but I don't recall the details. I don't think we've abandoned the idea.


Update to Inquirer v3.0.6

This add support to the "Editor" type. The gruntfile was changed to check if everything works properly with new v3.0.6 of inquirer

Hi,
Have I to change something to see my pull accepted?
This pull request is related to #34 and may be used as a base for #11.
Thank you


Problems in quickstart instructions

I've created a hugo site. Followed the instructions to add the ananke theme. The instructions are incorrect. For example why in config.toml theme name is "gohugo-theme-ananke" where it should be just "ananke"? And the line themesDir = "../.." should be deleted but in instructions the wording was put in a way that it seems it is not necessary.

The quickstart instructions appear correct to me. Are you speaking of these: https://gohugo.io/getting-started/quick-start/ ?

@budparr no, I meant https://github.com/theNewDynamic/gohugo-theme-ananke/blob/master/README.md#the-config-file

I use "gohugo-theme-ananke" in the demo. Just make it whatever you name the folder.

Then shouldn't the instructions here be updated to :
$ git submodule add https://github.com/budparr/gohugo-theme-ananke.git themes/gohugo-theme-ananke

The demo is really just a demo, not part of the instructions, and shows that there are several ways to do it. But I see your point, and I'll consider changing it.


Automatic common/ update

This is part of an automatic process run by mbaldessari on Thu Jun  9 01:03:15 PM CEST 2022

Let's punt this until the acm 2.5 stuff is all cleared, no point in rushing this.


feat(snap): use updated environment variable injection

Signed-off-by: Mengyi Wang<EMAIL_ADDRESS>

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-gpio/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)https://github.com/canonical/edgex-snap-testing/pull/50
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

This PR will be ready for merge, once the new hook has been tagged and imported by this PR.


fix: limit connection pool to 1 when using external pool

What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Limit knex connection pool to 1 when using an external pool

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 19 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 84.18%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
7022

Relevant Lines:
8279

💛  - Coveralls


feat: create Json to xml policy

fix gravitee-io/issues#4561

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Check for new DLC-related messages 25 times more often

Fixes #1107.
I decided to not change anything in the internals of rust-dlc because the proposed change of replacing an std::sync::Mutex with an std::sync::RwLock is not so obvious to me. I reached out to Tibo to discuss it anyway.
I think this could be very, very helpful in preventing disconnection-related issues in production. In theory this could improve the speed of the worst-case scenario for the current version of the subchannel open/close protocol by ~25 seconds!

Hmm, maybe our e2e tests are catching the fact that we are starving the producers by checking so often! I'll take a look on Monday.


docs(readme): Add badges

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Using target url's result.

Hi.
Using this package, I developed simple project that send notification to client.
In other words, a user created a book, and then someone updated it.
Then origin user received notification "Someone changed your book.".
But in your doc, there is no way to receive data made by target url.
Help.

@sunmoon11 I am confused about your request. Can you give my an example of information you are trying to send?


Cannot run plabooks with short versions of arguments

ISSUE TYPE

Bug Report

SUMMARY
I read ansible-navigator run --help which says:
Note: 'ansible-navigator run' additionally supports the same parameters as the 'ansible-playbook' command. For more information about these, try 'ansible-navigator run --help-playbook --mode stdout'

okay lets try this:
ansible-navigator run -i tcdev -l tcmgmt1dev -t mgmt site.yml

yields this nice tui window:
INVENTORY AND/OR PLAYBOOK NOT FOUND, PLEASE CONFIRM THE FOLLOWING
────────────────────────────────────────────────────────────────────────────────────────
                  Path to playbook: /home/florian/dev/proj/tcmgmt1dev
                  Inventory source: /home/florian/dev/proj/tcdev
Additional command line parameters: -l -t mgmt site.yml
────────────────────────────────────────────────────────────────────────────────────────
                                                                        Submit   Cancel

So it seems as if cmd line argument parsing is broken for short arguments.
ANSIBLE-NAVIGATOR VERSION
ansible-navigator 1.1.0a1
Installed from latest master
CONFIGURATION

None
LOG FILE

Relevant parts:
211005082705.196 DEBUG 'ansible_navigator.main' Command provided: 'run --mode stdout --log-level debug -i tcdev -l tcmgmt1dev -t mgmt site.yml'
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.ansible-runner.artifact-dir not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.ansible-runner.rotate-artifacts-count not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.ansible-runner.timeout not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.app not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.ansible.cmdline not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.collection-doc-cache-path not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.ansible.config not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.execution-environment.container-options not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.color.enable not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.editor.command not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.editor.console not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.execution-environment.enabled not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.execution-environment.volume-mounts not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.help-config not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.help-doc not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.help-inventory not found in settings file
211005082705.196 DEBUG 'ansible_navigator.main' ansible-navigator.help-playbook not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.ansible.inventories not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.inventory-columns not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.logging.append not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.logging.file not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.logging.level not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.mode not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.color.osc4 not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.execution-environment.environment-variables.pass not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.ansible.playbook not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.playbook-artifact.enable not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.playbook-artifact.replay not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.playbook-artifact.save-as not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.documentation.plugin.name not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.documentation.plugin.type not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' ansible-navigator.execution-environment.environment-variables.set not found in settings file
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_artifact_dir. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_rotate_artifacts_count. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_timeout. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for cmdline. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for collection_doc_cache_path. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for container_engine. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for container_options. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for display_color. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for editor_console. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment_image. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment_volume_mounts. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for help_config. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for help_doc. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for help_inventory. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for help_playbook. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for inventory. (changed=True)
211005082705.197 DEBUG 'ansible_navigator.main'  before: '[['tcdev']]'
211005082705.197 DEBUG 'ansible_navigator.main'  after: '['/home/florian/dev/primesign/tc-infra/tcdev']'
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for inventory_column. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for log_append. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for log_file. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for mode. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for osc4. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for pass_environment_variable. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for playbook. (changed=True)
211005082705.197 DEBUG 'ansible_navigator.main'  before: 'tcmgmt1dev'
211005082705.197 DEBUG 'ansible_navigator.main'  after: '/home/florian/dev/primesign/tc-infra/tcmgmt1dev'
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_enable. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_replay. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for plugin_name. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Completed post processing for set_environment_variable. (changed=False)
211005082705.197 DEBUG 'ansible_navigator.main' Collection doc cache not mounted
211005082705.197 DEBUG 'ansible_navigator.main' Collection doc cache: 'path' is '/home/florian/.cache/ansible-navigator/collection_doc_cache.db'
211005082705.197 DEBUG 'ansible_navigator.main' Collection doc cache: 'current version' is '1.0'
211005082705.197 DEBUG 'ansible_navigator.main' Collection doc cache not attached to args.internals
211005082705.197 DEBUG 'ansible_navigator.main' Running with ansible_runner_artifact_dir as 'Constants.NOT_SET' (Constants/value has not been set)
211005082705.197 DEBUG 'ansible_navigator.main' Running with ansible_runner_rotate_artifacts_count as 'Constants.NOT_SET' (Constants/value has not been set)
211005082705.197 DEBUG 'ansible_navigator.main' Running with ansible_runner_timeout as 'Constants.NOT_SET' (Constants/value has not been set)
211005082705.197 DEBUG 'ansible_navigator.main' Running with app as 'run' (str/cli parameters)
211005082705.198 DEBUG 'ansible_navigator.main' Running with cmdline as '['-l', '-t', 'mgmt', 'site.yml']' (list/cli parameters)

STEPS TO REPRODUCE
Execute ansible-navigator run -i tcdev -l tcmgmt1dev -t mgmt site.yml and observe the final cmdline
EXPECTED RESULTS
Behavior like ansible-playbook
ACTUAL RESULTS
Failed to parse cmdline
ADDITIONAL INFORMATION

@apollo13 Try this for me?  The playbook name is a positional argument to run so navigator expects it to follow:
ansible-navigator run site.yml -i tcdev -l tcmgmt1dev -t mgmt
LMK, (ty for the issue btw)

I should note, the way navigator parses the params is to pull off it's own and pass the remainder (unrecognized) through to the ansible-playbook command that runner fires off.  Assuming this is the issue you are facing, I've added an new issue so this get explained better in the FAQ, ty again


Fixed build errors due to winit v0.23.

Winit 0.23 fixes a few run time errors when compiling with rustc 1.48. It may be a good idea to move to this version of winit.

Closing in favor of PR #179.


Modifier key up in code editor updates correctly.

Problem:
The wrong parameter was passed into updateKeysPressed for isKeyDown.
Fix:
Passed false instead of true.
Commit Details:

Treats a modifier keyup when the code editor is focused as a keyup
instead of a keydown.

well I guess one more datapoint to banish boolean parameters from factory functions!


Manuscript / notes on theory

Perhaps this is a good point to pull the overleaf document with theory notes into this repo?

+1, sounds like a good plan

How about we put these into a separate (private?) repo?

Private isn't needed. Not sure if a separate repo needed either unless we want to store large datasets/trajectories to go into the manuscript in the github repo for the manuscript.

It's in the repo now.


match_optimization: Add support for additional remapping (not enabled yet).

Stack:

#6337
#6339 ⬅
#6338
#6341

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

crates/cairo-lang-lowering/src/optimizations/match_optimizer.rs line 58 at r3 (raw file):

    // Track variable renaming that results from applying the fixes below.
    // For each match arm and variable that is remapped (prior to the match),

Suggestion:
  // For each (variable_id, arm_idx) pair that is remapped (prior to the match),

crates/cairo-lang-lowering/src/optimizations/match_optimizer.rs line 159 at r3 (raw file):

            let block = &mut lowered.blocks[block_id];
            *block = var_renamer.rebuild_block(block);
        }

The same block could be rebuilt multiple times this way.
Maybe we should rebuild all the blocks at the end?
Code quote:
        // Apply the variable renaming to the reachable blocks.
        for block_id in reachable_blocks {
            let block = &mut lowered.blocks[block_id];
            *block = var_renamer.rebuild_block(block);
        }


HAWQ-1627. Support setting the max protocol message size when talking

with HDFS
Fix what?
User can set the max protocol message size, e.g.
In etc/hdfs-client.xml:
	<property>
		<name>ipc.maximum.data.length</name>
		<value>67108864</value>
	</property>

How to fix?
Use CodedInputStream.SetTotalBytesLimit() set the max size.
Test?
No test, reason:
It can be covered by former tests.

+1

@amyrazz44 @wengyanqing help to review, thanks.

LGTM +1

Merged


Not getting all tweets from a specific user.

Hey, first of all, thanks for creating this!
Second, I'm trying to get all tweets from a single user, but can't seem to do it.
Here's my query:
twitterscraper tiankovbot -u -o tweets_tiankov.json
INFO: Got 819 tweets from username tiankovbot
The user currently has >3500 tweets.
Am I missing something?

Hi @rum-n
The number of tweets indicated on a profile (in this case 3522) is usually larger than the actual number of tweets. It does not get updated when (large number of) tweets are deleted.
The actual number of tweets by tiankovbot is 820...
You can check this by scrolling down on his profile page, and when you have reached the bottom hit CTRL + J to open developers console (in google chrome) and search (CTRL + F) in the "Elements" tab for " js-stream-item".

Got it! Thanks a lot for the quick response!


added Typist-keybaord manager

Added UI Keyboard manager written in Swift 3.
Project URL
https://github.com/totocaster/Typist
Description
Typist is small, drop-in Swift UIKit keyboard manager for iOS apps. It helps you manage keyboard's screen presence and behavior without notification center and Objective-C.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 8 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

  :no_entry_sign:
  Found 3 link issues

Link issues by awesome_bot

Line
Status
Link

1262
301
https://github.com/mrugrajsinh/MVMaterialView redirects tohttps://github.com/TheMrugraj/MVMaterialView

1779
301
https://github.com/mrugrajsinh/MVAutocompletePlaceSearchTextField redirects tohttps://github.com/TheMrugraj/MVAutocompletePlaceSearchTextField

1973
301
https://github.com/neonichu/fastlane-plugin-appicon redirects tohttps://github.com/KrauseFx/fastlane-plugin-appicon

  Generated by :no_entry_sign: danger

Hey @totocaster, nice library! 😉
I need you to fix this before I can merge your pull request.
Thanks for contributing! 🎉

Hi @lfarah, all fixed. Please review and merge if possible. Thanks for all your comments!

Perfect!
Thanks again for contributing 😄


[typo] fix typo of file settings.h

thanks for the cleanup, could you please also remove those not used functions?
otPlatSettingsBeginChange()
otPlatSettingsCommitChange()
otPlatSettingsAbandonChange()

@bukepo  Already submitted a PR #3971 to remove these useless functions.


Fix Published UMD

Changes

change module entry point to backbone adapter UMD
change eslint env to shared-node-browser
integrate with global module
update template precompiler to reference UMD
update dbmonster example app
change webpack-helper to ensure global is not bundled twice (Using solution found in 6a6eacc)
expose underscore in the top level tungsten api (eg: var _ = require('tungstenjs')._;)

Changes to eslint
This will fail:
window.alert('Alert!');

This will not:
var window = require('global/window');
window.alert('Alert!');

Can we also update the readme to note that underscore doesn't need to be imported externally?


chore: run a test on the deployed netlify url

WIP: experimenting with running Playwright on a PR's preview URL on Netlify

@lirantal can you please resolve conflicts?

@MichalPorag resolved but it is probably going to need to resolve another time after you merge #249

@MichalPorag what is the actual issue that needs fixing? can't tell much from this, these are all set to warn.

Also to note that when I run the linter check locally I get that everything's just fine:
npm run lint

><EMAIL_ADDRESS>lint
> next lint

info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
✔ No ESLint warnings or errors

@MichalPorag ready to merge 🙏🏼

Hi @lirantal, thank you so much. Unfortunately still can't merge, too many changes... Please open in new PR. Closing it for now.

I think it was ok but anyway I'll open a new PR one you merge the other one then :-)


Python: Allow source dists to install correctly

When a source distribution is installed, PEP 517 will cause pybind11 to be installed in a temporary location at build time.
https://martin-thoma.com/pyproject-toml/
Unfortunately when pybind11 is temporarily installled, it infers the wrong include path. This includes a workaround. Hopefully when that issue is fixed the workaround can be removed:
https://github.com/pybind/pybind11/issues/1067
I’ve also posted the workaround here:
https://github.com/pybind/python_example/issues/45
I've confirmed that this works with cibuildwheel in Azure Pipelines, which is a great way to produce wheels for distribution. I can contribute the config change in a separate PR.

Awesome!
@paulmelnikow is it ready to merge this PR? or better to wait a fix for pybind11 for example this issue? >  https://github.com/pybind/python_example/issues/45

I'd say it's ready to merge.
Since their generated include path is still being passed to setuptools.Extension, the sdists created with this script should be forward compatible if they fix the include path. Of course the wheels will keep working too, as they don't run this bit of code. When pybind/pybind11#1067 is fixed I'm happy to remove the workaround to tidy this up.
I'm eager to keep this moving forward – and especially to start shipping all the platform wheels!

I'd say it's ready to merge.

Thanks! merged!


Add Circular Linked List to our list of recognized data structures.

Objective:
Add Circular Linked List to our list of recognized data structures.
Proposal:
Circular Linked List should be added as a core data structure due to its unique functionalities and widespread applicability.
Reasoning:
Circular Iteration: Enables seamless circular iteration, valuable for cyclic data processing needs.
Efficient Queue Implementation: Forms the foundation for circular queues, allowing for efficient enqueue and dequeue operations without element shifting.
Memory Management: Simplifies cyclic reference handling in memory management tasks like garbage collection.
Circular Linked Lists extend the capabilities of linear data structures, making them a valuable addition to our toolkit.

We can all generate textbook examples of issues with ChatGPT, you know. It's not like it's a new thing anymore.


Allow users to choose template from list

Is it possible to have list of most common used templates?
For example:

Treble Clef only;
Treble Clef + Guitar Tab;
Bass Clef only;
Bass Clef + Bass Guitar Tab;
Treble and Bass Clefs combined;

P.S. I trying to help you with pull requests, but I haven't succeed to make development environment work on Windows... But I still keep trying.

This is a good idea, I'd like this too.

P.S. I trying to help you with pull requests, but I haven't succeed to make development environment work on Windows... But I still keep trying.

Yeah, the current code won't work locally unless you have AWS set up. #61 should fix that.

So far my problems are even more severe :) node-pre-gyp don't want to compile, and docker not able to start, since virtualbox is at daggers drawn with Hyper-V manager I use for other projects...
Trying to separate interface part and run it...

That's my point. We are not using Docker any more but we didn't update the
README yet.
El El vie, jul 10, 2015 a las 6:42 PM, Alexey Shytikov <
<EMAIL_ADDRESS>escribió:

So far my problems are even more severe :) node-pre-gyp don't want to
compile, and docker not able to start, since virtualbox is at daggers
drawn with Hyper-V manager I use for other projects...
Trying to separate interface part and run it...
—
Reply to this email directly or view it on GitHub
https://github.com/LilyBin/LilyBin/issues/59#issuecomment-120375664.

Ok. So should I wait a bit to codebase will be cleaned up, or I should try to do it myself and propose pull request?

Actually you don't need to do either. Because you will only be modifying the frontend, you don't need to worry about the backend at all. Beware that because of this you'll be seeing an error and no score on the right, but it shouldn't matter.

I'd like to work on this.  Would probably use and/or adapt the templates from the LilyPond manuals: http://lilypond.org/doc/v2.18/Documentation/learning/templates


fix: 🐛 Bump version

Description

Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


ComparingUnrelatedTypes: expand to cover parameterized types

Previously this check would fail with an exception on parameterized types because
the .asClass method will throw on parameterized types.
This patch fixes that and additionally expands the checks to cover parameterized types.

Actually don't merge this yet. There's something else I'm looking into.

@sksamuel ok, I think this is ok to look at now. Like I mentioned in the git commit message, this isn't perfect and will give some false positives on some parameterized types.

Thanks for merging this in. Can a new release be made with this change? Sorry about asking for yet another release.

Am on vacation until 2nd then I can.
On 30 Dec 2015 08:09, "henrymai"<EMAIL_ADDRESS>wrote:

Thanks for merging this in. Can a new release be made with this change?
Sorry about asking for yet another release.
—
Reply to this email directly or view it on GitHub
https://github.com/sksamuel/scapegoat/pull/132#issuecomment-167937889.

1.1.1 is on maven central now


Failure to handle nodes with certain non-alphanumeric characters

Describe the bug
Having this DOT file contents:
strict digraph  {
"a/foo"
"b/foo"
"a/foo" -> "b/foo";
}

skyscope fails to process the nodes

To Reproduce
skyscope import-graphviz < graph.dot

Expected behavior
In general purpose usage of the graph, it's likely for nodes to have characters such as / (e.g. file paths), so it may be important to have support for this character, and optionally a few other (e.g. : as it's often used in the build target address).
Environment
0.3.1

Thanks for reporting this issue @AlexTereshenkov.
The problem was not quoting the node names in the dynamically generated dot files. I've remedied this and created a new release with the fix. Let me know if you encounter further issues.

Thanks a lot @benradf! I am running 0.3.2 now.
It seems like the error persists now raising another error for the same input dot file:
       POST http://localhost:28581/a5b4dde8-b053-45c5-beb8-71ce50aaa4a8/render 500 (Internal Server Error)
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:563
__do4 @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:5345
runAsync @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4234
run3 @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4424
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4436
drain @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4254
enqueue @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4272
run @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4670
__do4 @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:5261
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1716
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1716
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1716
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1716
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1716
__do6 @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:10290
(anonymous) @ a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:9155

a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:8777 Error: There was a problem with the response body: Type mismatch: expected Document, found Null
    at error (a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:1857:12)
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:9677:19
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:9870:24
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:9887:14
    at run3 (a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4374:25)
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4436:25
    at drain (a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4254:11)
    at Object.enqueue (a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4272:13)
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:4430:33
    at a5b4dde8-b053-45c5-beb8-71ce50aaa4a8:5348:38

Hmm, it works for me now with that dot file. Could you check ~/.skyscope/server.log and see what the most recent error is? Hopefully that'll explain why the server is returning 500 on the /render endpoint.

It all works great now. Purging everything skyscope related and starting fresh did help.


Initial cms academic workstream commit

Hopefully fixed the "this commit wasn't signed" issue from previous attempt. Just sets up initial directory structure of the academic work stream folder in CMS and some readmes for how-to and what's up.

Friendly bump on this. Thanks!