Fixes #13

This cl fixes the hanging request problem.
This fix updates the get method of RequestHTML, adding logic to
retry 3 times before bailing.
The retry time I added was 5 seconds, which is a generous amount of
time... but its also a random number I pulled from hat.
This cl could be scaled down a bunch by removing the retry logic.

Seems to have fixed the problem. Now every request finishes and doesn't halt. However, the program still halts sometimes, but it is due to another unexpected behaviour. Going to do a deeper search.


Revisiting identity-related classes.

Moved AccessToken from sample-app to azure-core. and created its test class.,
Renamed storage.blob.credentials to storage.blob.credential.
Made slight corrections to the TokenRequest classes' Javadoc in sample-app.

@bsiegel @anuchandy PTAL :)

/check-enforcer reset

/check-enforcer evaluate

No problems with the changes so far, but I think ultimately we will want all of the TokenRequest* code to move into the "identity" library too. Basically anything we don't expect developers should have to write themselves, if we can provide it for them, we should. With MSAL that's unfortunately less than we would like, since there is a lot of glue needed to wire up MSAL to the actual application that's using it. But even there we can contribute some of that boilerplate and provide a good sample for the developers to follow in order to implement the remainder of it themselves.

I agree we will want to move this to an Identity library, do you think that is something we want to do for this preview?

I agree we will want to move this to an Identity library, do you think that is something we want to do for this preview?

I think we should just pull it into the identity library now. I was going to suggest that we can just pull it into core if identity hasn't been created yet, but honestly the process of making the identity library is pretty trivial, and there's not much extra code that needs to be pulled into it. Plus I think we would need to do this work for preview 1 anyway.

@bsiegel @anuchandy I moved our generic credential classes to azure-core as previously discussed and wrote unit tests for all of them. I has special trouble deciding how to approach testing the okenRequestObservableAuthInterceptor because TokenRequestObservable only exposes LiveData's observe(LifecycleOwner, TokenRequestObserver) and we cannot use classes from the Android API like LifecycleOwner in unit tests. I found three different ways to approach this:

Use Robolectric to access Android API classes in unit tests. This is specially slow and would not recommend pulling this dependency unless we had many cases where our unit tests benefited from this. Commit link.
Use Mockito to mock a LifecyceOwner object. This is way faster but still pulls a test dependency on Mockito. Commit link.
Add observeForever(TokenRequestObserver) and removeObserver(TokenRequestObserver) to TokenRequestObservable. This has the benefit of not using any additional test dependencies, however, do we want to expose such functionality to users? If not, I'm not sure it would be a good practice to add package private methods to only be used by unit tests. Commit link.

Good questions. I'm curious, since the type androidx.lifecycle.LifecycleOwner is in Jetpack rather than in the android OS, is it really true that we can only use this type in a connectedTest?
If that's the case, then arguably the "correct" thing would be to hide the type behind an interface, since the current state means our TokenRequestObservableAuthInterceptor is strongly coupled directly to the Android OS. However, I'm not clear how much noise that would end up generating.
For the third option you provided, is it possible to make those added methods package-private? If they are required to be fully public then I would say option three is not viable.

@bsiegel Thank you for taking the time to read, there are definitely more ways we could go about solving this problem like the ones you suggested.
I spent some time thinking about your question of LifecycleOwner being a part of Jetpack and not the Android OS itself and it turns out you are right, I must have been fixed on thinking only UI components such as Activity or Fragment could make use of Lifecycle and LifecycleOwner. With that being said, I think the solution of mocking the LifecycleOwner ourselves is both elegant and simple, so I will be suing it in this case, thanks a lot! :D

Does this complete #134?

:shipit:


added a new game

PR Description 📜
I have added a new game- Avax Gods which is a web3 based NFT battlecard game.
Fixes #641

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

@kunjgit do I need to make any other changes??

Thanks @kunjgit


terraform adding new disk, when such configuration of disks is used: scsi0, ide2, ide0

Hello
Faced strange behavior of terraform proxmox provider, and was able to reproduce on two different proxmox cluster.
With specific configuration of Hard Drive, CloudInit Drive and CD/DVD Drive - scsi0, ide0, ide2 accordingly - terraform proxmox provider want to add new disk.
This behavior not stable and flapping.
Also possible that terraform import not import disk at all.
ENV:

Proxmox: 7.4-17
Terraform: 1.5.4
Terraform Proxmox provider: 2.9.14
Hard Drive and Cloudinit Drive placed on ZFS

How to reproduce

create VM with such configuration of disks:

maybe it is important, make that CD/DVD Drive have "none" ISO, like this:

Make an import of this VM.
Modify Terraform State to prevent of recreating of the VM
Run few times terrafrom plan and check if terraform wants to create a disk

Activity
As I see, v3 is on the way to be ready to test.
When it will be release, I'll try to test it this case with new version


[GHSA-rp65-9cf3-cjxr] Inefficient Regular Expression Complexity in nth-check

Updates

Affected products

Comments
https://www.npmjs.com/package/nth-check

Hi @richardjanderson9 we appreciate your contribution to GitHub's Advisory Database, I see that you want to update the affected product listed as well as correct the fixed version. Do you have reference link for these changes?


Backport fixed ansi-regex module and add types

As much as nobody should be using node.js v0.10 anymore, the only versions of strip-ansi (and therefore ansi-regex) that had the vulnerability fix for this issue required Node.js 4.0+
I've added the latest ansi-regex code to this module directly and fixed it to work on any Node.js version, and migrated the tests to validate it works. Tested on node versions as old as v0.8 locally.
Also added an index.d.ts file
Closes #7 sort of (those audit messages are for the devDependencies I believe)

This is awesome work. Thanks a lot!

I'll issue a new release to npm in a bit

Deployed to npm as v2.1.0. Many thanks again!


BugFix: missing jpg content type breaks corrupts presentation for Office365

By default we add only "jpeg" into presentation's content types (see makeXmlContTypes function) but Office365 definitely expects to see "jpg" also and consider some presentations as corrupted depending on certain pictures inserted.

Thanks @antonandreyev !
I have not experienced problems with images on office.com, so thanks for the information and the patch.


--dry-run?

Is there a way to run this as a linter and not have it --write and/or --fix? My use case is that I want to have the linter run as an onchange event and I don't want it writing files and causing my editor to prompt me that the buffer has changed. Thanks!

Is this a duplicate of #17?

@thejohnfreeman Yep! Didn't see that issue. I'll close this and start following #17. Thanks for linking the issues.


Crash whilst initializing game

I hope that this issue will be fixed ASAP, because it is quite annoying.
Details:
MC version: 1.12 with Forge .2387
Crash: https://pastebin.com/jYxENy1c
-Jax

Yep all 1.12 mods are going to run into this.  forge 2347 is the last version compatible , after that forge broke the registry system and made it in a different way , so all mods have to update to fix it.  I hope to get this done today, but im  going away for the weekend so it might be a bit late.
References
https://github.com/PrinceOfAmber/Storage-Network/issues/11
https://twitter.com/lothrazar/status/879228787258408960
https://twitter.com/modmuss50/status/878387667678806017

Duplicate of this issue, not fixed yet but as i said i hope soon.
keep an eye out there for fixes.  https://github.com/PrinceOfAmber/Cyclic/issues/416

Fixed version is up https://minecraft.curseforge.com/projects/cyclic/files/2443647 .
There could be other little issues but at least my server starts up and all the stuff is there.


Issues with variables initialized with numpy.int64 dimensions

I was running into strange error messages from CVXPY and tracked it down to creating a Variable with a dimension of type numpy.int64. It will happily get created and some simple problems can actually be solved without issue. However, it throws errors when used in certain ways. These are two minimal programs I could find to test the issue. Both crash on problem.solve() with CVXPY 0.4.10.
import cvxpy as cvx
import numpy as np

q = cvx.Variable(np.int64(2))
objective = cvx.Minimize(cvx.norm(q, 1)) #but this works fine with np.identity(2) * q instead of q
problem = cvx.Problem(objective)
problem.solve()
print(q.value)

import cvxpy as cvx
import numpy as np

q = cvx.Variable(np.int64(2))
objective = cvx.Minimize(cvx.norm(np.identity(2) * q, 1))
constraints = []
for index in range(-2, 0): #issue doesn't occur with positive indices (i.e. range(2))
    constraints.append(0 <= q[index])
    constraints.append(q[index] <= 2)
problem = cvx.Problem(objective, constraints)
problem.solve()
print(q.value)

These are the errors I get:
1.
Traceback (most recent call last):
  File ".\cvx-error.py", line 7, in <module>
    problem.solve()
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem.py", line 209, in solve
    return self._solve(*args, **kwargs)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem.py", line 331, in _solve
    kwargs)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\solvers\ecos_intf.py", line 123, in solve
    **solver_opts)
  File "C:\Program Files\Python36\lib\site-packages\ecos.py", line 62, in solve
    return _ecos.csolve((m,n1,p), c, data, indices, colptr, h, dims, A.data, A.indices, A.indptr, b, **kwargs)
TypeError: dims['l'] ought to be a nonnegative integer

Traceback (most recent call last):
  File ".\cvx-error.py", line 11, in <module>
    problem.solve()
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem.py", line 209, in solve
    return self._solve(*args, **kwargs)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem.py", line 331, in _solve
    kwargs)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\solvers\ecos_intf.py", line 118, in solve
    data = self.get_problem_data(objective, constraints, cached_data)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\solvers\solver.py", line 248, in get_problem_data
    cached_data)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\solvers\solver.py", line 226, in get_matrix_data
    self.nonlin_constr())
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem_data\matrix_data.py", line 90, in __init__
    self._lin_matrix(self.ineq_cache, caching=True)
  File "C:\Program Files\Python36\lib\site-packages\cvxpy\problems\problem_data\matrix_data.py", line 181, in _lin_matrix
    constr_offsets
  File "C:\Program Files\Python36\lib\site-packages\canonInterface.py", line 52, in get_problem_matrix
    tree = build_lin_op_tree(lin, tmp)
  File "C:\Program Files\Python36\lib\site-packages\canonInterface.py", line 229, in build_lin_op_tree
    set_slice_data(linC, linPy)
  File "C:\Program Files\Python36\lib\site-packages\canonInterface.py", line 151, in set_slice_data
    vec.push_back(var)
  File "C:\Program Files\Python36\lib\site-packages\CVXcanon.py", line 426, in push_back
    return _CVXcanon.IntVector_push_back(self, x)
TypeError: in method 'IntVector_push_back', argument 2 of type 'std::vector< int >::value_type'

Maybe it would be easiest to just convert all variable dimensions into Python ints?


pkg_resources is deprecated as an API

It's time to update pkg_resources as it is deprecated.
=================================================== warnings summary ===================================================
../../../.pyenv/versions/3.9.7/envs/asreview-dev/lib/python3.9/site-packages/pkg_resources/__init__.py:121
  /Users/Bruin056/.pyenv/versions/3.9.7/envs/asreview-dev/lib/python3.9/site-packages/pkg_resources/__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
    warnings.warn("pkg_resources is deprecated as an API", DeprecationWarning)

This is an example implementation https://git.smhi.se/climix/climix/-/merge_requests/165/diffs

I don't mind taking a stab at this. While I'm at it, how would you like refactoring such that we are not loading our own functionality as if it is coming from a plugin. For example for balancers, it could look like this:
from asreview.models.balance import DoubleBalance
from asreview.models.balance import SimpleBalance
from asreview.models.balance import TripleBalance
from asreview.models.balance import UndersampleBalance
from importlib.metadata import entry_points

def list_balancers():
    my_balancers = {b.name: b for b in [
        DoubleBalancer,
        NoneBalancer,
        TripleBalancer,
        UndersampleBalancer
    ]}
    group_name = "asreview.models.balance"
    try:
        other_balancers = {e.name: e.load() for e in entry_points(group=group_name)}
    except Exception as e:
        print("Something went wrong loading a module from entrypoint group " +
              f"'{group_name}'. The error message was: {e}\nContinuing...")
        other_balancers = {}
    d = dict()
    d.update(my_balancers)
    d.update(other_balancers)
    return dict(sorted(d.items()))

Code that uses load_balancers would then do:
# need a class
Balancer = load_balancers()["double"]

# need an instance
balancer = load_balancers()["double"]()

# need a list of names
balancer_names = [k for k, v in load_balancers().items()]

# need a list of classes
balancer_classes = [v for k, v in load_balancers().items()]

This would obfuscate the need for the entrypoint groups in setup.py:
https://github.com/asreview/asreview/blob/d6062883c204651fd6ff719be69cc5df26fe7756/setup.py#L178-L183
Additionally it would obfuscate the need for some or all of the following functions:

asreview.data.base.get_entry_points
asreview.datasets.get_entry_points
asreview.entry_points.algorithms.list_balance_strategies
asreview.entry_points.algorithms.list_classifiers
asreview.entry_points.algorithms.list_feature_extraction
asreview.entry_points.algorithms.list_query_strategies
asreview.entry_points.simulate.get_balance_model
asreview.entry_points.simulate.get_classifier
asreview.entry_points.simulate.get_feature_model
asreview.entry_points.simulate.get_query_model
asreview.io.utils._reader_class_from_entry_point
asreview.io.utils._writer_class_from_entry_point
asreview.io.utils.get_reader_class
asreview.io.utils.get_writer_class
asreview.io.utils.list_reader_names
asreview.io.utils.list_readers
asreview.io.utils.list_writer_names
asreview.io.utils.list_writers
asreview.list_readers
asreview.list_writers
asreview.models._list_classifiers
asreview.models.balance.get_balance_class
asreview.models.balance.get_balance_model
asreview.models.balance.list_balance_strategies
asreview.models.balance.utils._model_class_from_entry_point
asreview.models.balance.utils.get_balance_class
asreview.models.balance.utils.get_balance_model
asreview.models.balance.utils.list_balance_strategies
asreview.models.balance.utils.list_model_names
asreview.models.classifiers.get_classifier_class
asreview.models.classifiers.get_classifier
asreview.models.classifiers.list_classifiers
asreview.models.classifiers.utils._model_class_from_entry_point
asreview.models.classifiers.utils.get_classifier_class
asreview.models.classifiers.utils.get_classifier
asreview.models.classifiers.utils.list_classifiers
asreview.models.classifiers.utils.list_model_names
asreview.models.feature_extraction.get_feature_class
asreview.models.feature_extraction.get_feature_model
asreview.models.feature_extraction.list_feature_extraction
asreview.models.feature_extraction.utils._model_class_from_entry_point
asreview.models.feature_extraction.utils.get_feature_class
asreview.models.feature_extraction.utils.get_feature_model
asreview.models.feature_extraction.utils.list_feature_extraction
asreview.models.feature_extraction.utils.list_model_names
asreview.models.get_classifier_class
asreview.models.get_classifier
asreview.models.query.get_query_class
asreview.models.query.get_query_model
asreview.models.query.list_query_strategies
asreview.models.query.mixed.get_query_model
asreview.models.query.utils._model_class_from_entry_point
asreview.models.query.utils.get_query_class
asreview.models.query.utils.get_query_model
asreview.models.query.utils.list_model_names
asreview.models.query.utils.list_query_strategies
asreview.settings.get_balance_model
asreview.settings.get_classifier
asreview.settings.get_feature_model
asreview.settings.get_query_model
asreview.utils._model_class_from_entry_point
asreview.utils._reader_class_from_entry_point
asreview.utils._writer_class_from_entry_point
asreview.utils.get_entry_points
asreview.utils.list_model_names
asreview.utils.list_reader_names
asreview.utils.list_writer_names

The entrypoints and the groups allow us to develop extensions such as different models. How this will be handled in the above modification?

Hi Rohit, thanks for the question. Plugins would define a class, let's say NewBalancer, and in the plugin's setup.py  /setup.cfg / pyproject.toml it would point to this class, with syntax like
"asreview.models.balance": [
     "new = asreview_plugin_balancer.models.balance:NewBalance"
],

Once the plugin is installed, list_balancers from the snippet above will pick up the new class when it gets to the line that says:
other_balancers = {e.name: e.load() for e in entry_points(group=group_name)}

PS: I updated the snippet above because in the usage examples I had mistakenly used load_balancers instead of list_balancers. Sorry for the confusion.

Thank you @jspaaks for the clarification. This means that the current way of creating extensions will not be affected by the modification you are proposing, it is how we are doing it now.

This means that the current way of creating extensions will not be affected by the modification you are proposing, it is how we are doing it now.

That is my understanding as well, although I find it difficult to judge if there is code out there that makes use of any of the functions that will disappear by this change, so maybe that will lead to people having to update their imports and a small part of their code.

I think @J535D165 is in a better position to comment on this. But I think the modification should not force users to change the code in the extensions or some personal scripts. That will be a breaking change.


Can't customize style

Expected Behavior
I'm trying to customize my table by this docs but it's no effect
I'm also doing research but can find examples of how to do custom style with older version material UI (v4) but I'm using v5
Is it work for material 5+?
Current Behavior
I use material v5 so I did their Theme import :
import { ThemeProvider } from "@mui/styles"; import { createTheme } from "@mui/material/styles";
and do my styling
    const getMuiTheme = () => createTheme({
      overrides: {
        MUIDataTableBodyCell: {
          root: {
            backgroundColor: "#FF0000",
          },
        },
        MUIDataTablePagination: {
          root: {
            backgroundColor: "#000",
            color: "#fff",
          },
        },
        MUIDataTableBodyCell: {
          root: {
            backgroundColor: "#000000"
          }
        }
      },
    });

My table style didn't change with no any errors
Steps to Reproduce (for bugs)
Please look at my codesandbox
https://codesandbox.io/s/mui-datatables-custom-style-o7v2s?file=/src/App.js

Your Environment

Tech
Version

Material-UI
5.2

MUI-datatables
4.0.0

React
17.2

browser
Chrome latest

etc

If I downgrade mui-datatables to 3.8.2 and install material-ui/core v.4.12.3 then styles start works
Please see
https://codesandbox.io/s/great-field-nwgqw?file=/src/App.js
It seems like changing styles don't work for mui-datatables v 4.0 ...
Can anyone confirm that?

I am also experiencing this issue, I used the style editing to add a custom button to the toolbar like this. I migrated to MUI 5 and this is the code I tried to use
export const darkTheme = createTheme({   palette: {     mode: 'dark',     primary: { main: '#7986cb', contrastText: '#212121' }   },   components: {     MuiLink: {       styleOverrides: {         root: {           color: '#7986cb'         }       }     },     MUIDataTableToolbar: {       styleOverrides: {         actions: {           display: 'flex',           flex: 'initial',           '& > span, & > button': {             order: 99           },           '& > span:last-child, & > button:last-child': {             order: 1           },           '& > span:nth-child(4), & > button:nth-child(4)': {             order: 2           }         }       }     }   } });

In MUI 5, the overrides option in createTheme has been switched to components option and rather than directly overriding the components, you need to have the styleOverrides in the component you want to override.
Before mui 5:
overrides: { MUIDataTableBodyCell:  {           root: {             backgroundColor: "#FF0000"           }         } }
After mui 5:
components: {  MUIDataTableBodyCell: {   styleOverrides:{           root: {             backgroundColor: "#FF0000"           }         } } }

I've converted to the new mui 5 syntax and it compiles, but I am unable to resolve the TypeScript error: Object literal may only specify known properties, and 'MUIDataTable' does not exist in type 'Components<BaseTheme>.
How do we extend the interface for the ThemeOptions for mui-datatables components?

Hey @jcgentr, take a look at this https://github.com/gregnb/mui-datatables/issues/1810. I think this is what you are looking for ?

I tryed styling the Mui dataTable like you suggested and it still isn't working
Here is my code
import MUIDataTable from "mui-datatables";
import { createTheme, ThemeProvider } from "@mui/material/styles";
function Customers() {
const columns = ["Name", "Company", "City", "State"];
const data = [
["Joe James", "Test Corp", "Yonkers", "NY"],
["John Walsh", "Test Corp", "Hartford", "CT"],
["Bob Herm", "Test Corp", "Tampa", "FL"],
["James Houston", "Test Corp", "Dallas", "TX"],
["James Houston", "Test Corp", "Dallas", "TX"],
];
const options = {
filterType: "multiselect",
responsive: "scroll",
};
return (
<ThemeProvider
theme={createTheme({
components: {
MUIDataTableBodyCell: {
styleOverrides: {
root: {
backgroundColor: "#FF0000",
},
},
},
},
})}
>
<MUIDataTable
sx={{ height: "100px" }}
title={"Customers"}
data={data}
columns={columns}
options={options}
/>

);
}
export default Customers;

I tryed styling the Mui dataTable like you suggested and it still isn't working
Here is my code
import MUIDataTable from "mui-datatables"; import { createTheme, ThemeProvider } from "@mui/material/styles";
function Customers() { const columns = ["Name", "Company", "City", "State"];
const data = [ ["Joe James", "Test Corp", "Yonkers", "NY"], ["John Walsh", "Test Corp", "Hartford", "CT"], ["Bob Herm", "Test Corp", "Tampa", "FL"], ["James Houston", "Test Corp", "Dallas", "TX"], ["James Houston", "Test Corp", "Dallas", "TX"], ];
const options = { filterType: "multiselect", responsive: "scroll", };
return ( <ThemeProvider theme={createTheme({ components: { MUIDataTableBodyCell: { styleOverrides: { root: { backgroundColor: "#FF0000", }, }, }, }, })} > <MUIDataTable sx={{ height: "100px" }} title={"Customers"} data={data} columns={columns} options={options} /> ); }
export default Customers;

I'm running into a similar problem.
It appears that I can override the Style of an existing mui Component, but the Style is not reflected in the mui-datatables.
[ style overrides ]
ok => MuiTableRow, MuiTableCell, ...etc (mui official className)
failed => MUIDataTableHeadCell, MUIDataTableHeadRow, ...etc (mui-datatable className)
styleOverrides
It was working fine until February 19.

I am having the same issue. When trying to upgrade to 4.1.2, the MUIDataTable styles are no longer being overridden by @mui, even after installing tss-react.
I noticed there is now a prefix on the overridden styles.tss-58la38-MUIDataTable-paper, but no styles show up in the chrome dev tools.

It's fixed in the PR #1882.  It just needs to get merged.

Seems like this project is no longer actively maintained...
A workaround that I can offer (to yarn users) is to pin tss-react to the newer version in your package.json like so:
"resolutions": {
    "tss-react": "3.6.0"
},
"dependencies": {
    "tss-react": "^3.6.0"
}

Once the PR get merged you will be able to remove tss-react from your dependencies.


Date parsing?

I didn't see any convenience helpers for date parsing in the library. Would you accept a pull request for that, or is it out of scope?

A pull request would be welcome! I don't personally think it's out of scope, but we didn't want to be too opinionated about it yet.
Further parsing can be built as a composition out of the string family of methods, for instance:
let formatter = ...
self.dateOfBirth = try json.string("some", "key", "path", ifNotFound: true).flatMap(formatter.dateFromString)

That obviously leaves something to be desired (error handling, for one). I envisioned a ValueTransformer<In, Out> as a case-by-case alternative to everything needing to be JSONDecodable.

I can open a PR for consideration. Any thoughts on special date formats we'd like to support? At a minimum, I think it'd be nice to support two common Ruby date formats ("yyyy-MM-dd'T'HH:mm:ss.SSSZZZZ" and "YYYY-MM-DD HH:mm:ss ZZZ")

I personally think magical support for a specific format would be more confusing than opt-in support, but I won't say we wouldn't consider it.

All the dates in our REST APIs conform to ISO8601. I feel like that's somewhat standard, but i wouldn't lose sleep if i had to pass in a format string to adopt it.

All the dates in our REST APIs conform to ISO8601. I feel like that's somewhat standard, but i wouldn't lose sleep if i had to pass in a format string to adopt it.

I would be sooooooo happy if I had that experience. Unfortunately we see all kinds of date formats in practice, including some that can't be parsed by NSDateFormatter (e.g., search for "DateTime Wire Format" for .NET 4.5). Given that, I'm not sure even a format string is an ideal solution. :-/ This is where the desire for value transformers is coming from, FWIW.

We just came up with the need to turn http://example.com/foo.jpg into an NSURL-typed property on our model object, and would also like either this special-cased or some kind of value transformer as mentioned above.

For URLs, there isn't much transformation needed. Can you make NSURL conform to JSONDecodable in your project?

We can without too much trouble, sure. I have a side-question on doing that though: when turning NSURL's failable initialiser into one that throws we thought using Freddy.JSON.Error. ValueNotConvertible would be the appropriate error but I wasn't sure what to give for the value parameter?

That's up to you and how you're handling/reporting errors. I'd put in the string that failed to convert. You could also define your own error case that doesn't have an associated value.

@ratkins were you able to conform NSURL to JSONDecodable by using its failable initializer? I couldn't get it done myself.

Closing due to inactivity. Given the advent of Codable, Freddy is in maintenance mode and only considering bug fixes at this time.


[FEATURE] "forgot password" functionality in login page

Is your feature request related to a problem? Please describe.
Currently, there is no option for resetting the password in case the user forgot it.
Add the "forgot password" functionality via sending mail at registered email-id to reset it.

@harsh-9in can I work on this issue?

yeah sure @Akshi149 :)


Rebuild linux checklist

https://pandemic-overview.readthedocs.io/en/latest/myGuides/General-computer-setup.html#setup-your-computer-we-will-cover-each-item

Enable Linux on your Chromebook

Handy aliases and abbreviations into .bashrc and .bash_aliases

Install Visual Studio Code

Connect with vscode in the cloud so your settings persist over devices and sessions

Create SSH keys to communicate securely with the cloud

Configure ssh keys and token for vscode

Configure ssh keys and token for DigitalOcean

Install DigitalOcean doctl

Install Docker

vscode extensions will appear after signing in via GitHub

https://linuxconfig.org/how-to-set-up-a-python-virtual-environment-on-debian-10-buster
sudo apt install python3 python3-venv
sudo apt install virtualenv python3-virtualenv


Fixed an issue which created broken base64 encoded strings.

Fixed an issue which created broken base64 encoded strings.  This lead to authentication issues while using basic authentication.

Need more details.  What characters cause invalid encoding, and what do you expect the encoding to be?  Is there something about this in a RFC?


Issue with Parcelable

file:///Users/shubham.garg/Downloads/Android-SDK-Sample-App-main/payu-sdk/src/commonMain/kotlin/com/payu/india/Model/Bnpl.kt:9:6 Class 'Bnpl' is not abstract and does not implement abstract member public abstract fun describeContents(): Int defined in android.os.Parcelable

Please make sure that you have applied the kotlin-parcelize Gradle plugin. See the corresponding Readme section.

yes, I follow all step mention in readme, do you have any sample app for same

Sure, you can check this one - https://github.com/arkivanov/Decompose/blob/master/sample/shared/shared/build.gradle.kts
The error you mentioned means that the Android Parcelable interface is not implemented for that class. Which happens if kotlin-parcelize plugin is not applied.

check this screenshot of my build.gradle.kts

Could you please also show the Bnpl class?

Closing this for now. Feel free to reopen if the issue is still relevant.


Able to update pyarrow supported versions again? (and possibly support pandas 2.x)

Once again pyarrow has advanced several versions beyond the maximum version supported by this package.  Would it be possible to support newer versions of pyarrow?
Also, since pandas 2.x has been out for a while now, would it be possible to verify and / or support it?

Versions have been unlocked for pyarrow and pandas, released as 2.2.0


Error Opening Serial Port

I had success getting my ReactorX up and running but then it stopped working. I seem to have an issue with ports. I though maybe someone could point me in the right direction? The error message is the same as the one from post at https://github.com/ROBOTIS-GIT/open_manipulator/issues/82 . I have walked step by step through the quickstart but can't seem to get the arm to move anymore

Can you verify the following?

You've done Steps 7 and 8 in the Quick start, and you can see 'ttyDXL' show up in the /dev directory

The microUSB cable connecting the U2D2 to your laptop is not loose but firmly connected

No other application on your computer is using the port. For example, if you are running the Dynamixel Wizard 2 tool, and then try to run the ROS packages, you will get this error since it's already being used. You may also have a previous ROS session still using the port. To get rid of it, do pkill ros in the terminal.

If you have another udev rule in the /etc/udev/rules.d directory with a higher number than 10, it may be restricting your user's port permissions somehow. In that case, change the interbotix udev rule to 99-interbotix-udev.rules instead of 10-interbotix-udev.rules. Unplug/replug and try again.

Thanks! It was the fourth one. Looks good now


Property page seems to be missing a lot of settings

The DEBUG tab listed in the page no longer exists in this way. Instead there is a single link that opens a launch profile configuration window where you can configure different launch options.
The BUILD tab shows 5 settings in the article, yet in Visual Studio there are 42 settings split between 6 sub sections.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70dc5ee9-90cf-6465-2cf5-3a8866d624de
Version Independent ID: 70dc5ee9-90cf-6465-2cf5-3a8866d624de
Content: Project Settings for a .NET C# debug config - Visual Studio (Windows)
Content Source: docs/debugger/project-settings-for-csharp-debug-configurations-dotnetcore.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@adegeo I do see the info on the Launch Profiles UI here; let me know if you were looking for something different. For Build tab, I believe the intent was to document the settings most relevant to debugging (the full Build tab ref is a link in the intro). I will clarify this in the doc though.

Ack @Mikejo5000 Yeah I added that debug in reediting my issue before submission. Sorry about that. I'm not seeing the full build tab reference link? I see a single link in the first paragraph that just navigates down, and the other links don't seem to go to a reference page.

Ah, OK, thanks. There should be a link to the Build tab UI ref doc. I'll add that.


WIP: revert for a working sriov lane check

Experimenting...
revert to 31acf81
/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov


Memory usage skyrockets when doing anything in Pinta

To Reproduce

In Pinta, select a brush/pencil tool and start drawing;
Keep drawing and watch as its memory usage goes up.

It's also possible to cause the memory usage to go up by just zooming in and out of the canvas, selecting random places in the canvas, etc. But drawing usually drives the RAM usage up the most.
Additional Info
https://github.com/user-attachments/assets/192012e4-259d-4437-a5a4-b4b2ae7c14f5
Commit that introduced this regression: #685

Can Confirm on Fedora 40.

Confirmed on macOS as well.
If I launch Pinta with the --debug flag, which forces the GC to run very frequently (https://github.com/PintaProject/Pinta/blob/master/Pinta/Main.cs#L107) then I didn't observe any major memory growth, so that might be a good starting point for investigation

Debug flag does seem to fix it from me (I had been seeing >10GB ram usage just adding text!), however it still experiences heavy >3GB ram spikes with accompanying lag spikes when zooming in extremely low.

That might be a somewhat separate issue - the canvas renderer isn't as efficient when zooming in after the port to GTK4 since we can't do partial redraws of only the visible area.
But it could also be related somewhat to the GC issue if the Cairo.ImageSurface used by the canvas isn't being collected quickly enough, since the Cairo.ImageSurface binding doesn't currently inform the GC about the native memory size it represents.

Just recording notes from my investigation:
Adding an explicit context.Dispose () at the end of PintaCanvas.Draw() https://github.com/PintaProject/Pinta/blob/ebf0335bd1da1721cacdbfd69572115c7a9240e5/Pinta.Gui.Widgets/Widgets/Canvas/PintaCanvas.cs#L148 fixes the vast majority of the memory usage increase
This particular Cairo.Context likely has a big effect on memory usage since it can be the last reference to a temporary Cairo surface from the GTK widget (https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gsk/gskrendernodeimpl.c#L3495)
We can make this fix in Pinta once there's a new gir.core release with the fixes for https://github.com/gircore/gir.core/issues/1109

Thank you!


docs(custom-properties): removed custome properties docs from components

removed custome properties docs from components

I think our manually maintained docs approach used in some components is a bad idea. Once v4 is released we can look into auto generating it during our build step.


Improvements in build process

Doesn't need to build the class libraries anymore
No need to install VS extension nor restore NuGet packages

Signed-off-by: José Simões<EMAIL_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Rss and Trigger agents combine

hey!
i have some rss events. i'm trying to use TriggerAgent
my TriggerAgent looks like:
{
  "expected_receive_period_in_days": "1",
  "keep_event": "true",
  "rules": [
    {
      "type": "regex",
      "value": ".*\\/Collateral\\/.*",
      "path": "$.title.*"
    }
  ],
  "message": "{{title}}"
}

and my event:
{
  "id": "https://www.planetdp.org/subtitle/collateral-sub253687",
  "url": "https://www.planetdp.org/subtitle/collateral-sub253687",
  "urls": [
    "https://www.planetdp.org/subtitle/collateral-sub253687"
  ],
  "links": [
    {
      "href": "https://www.planetdp.org/subtitle/collateral-sub253687",
      "rel": "alternate",
      "type": "text/html"
    }
  ],
  "title": "Collateral Sezon : 1,Bölüm : Paket Türkçe Altyazı",
  "description": "25 fps fps, SubRip",
  "content": "Collateral Türkçe Türkçe Altyazı",
  "image": null,
  "enclosure": null,
  "authors": [
    "Reşat Bir"
  ],
  "categories": [],
  "date_published": null,
  "last_updated": "2018-03-09T11:27:12+03:00"
}

my goal is captured a word from {{title}} or {{content}} in the event. and extra question is that how i'm gonna add another word in the regex value? like *\\/wordone | wordtwo\\/.*?

Do you mean "wordtwo in addition to wordone" or do you mean "wordone or wordtwo"?  You can do both with Trigger Agent but it's easier to explain the one you need first to keep it from getting confusing.

word1 or word2 what i'm trying here. actually, i wanna know [word1 and word2 or word3 and word4]

Okay.  With Trigger Agent, by default it will only fire if all of the configured rules match.  For the former case, just put your regex rules in a single Trigger Agent in separate rules, and that'll do what you want.  For the latter case I recommend two Trigger Agents in Parallel (word1 AND word2, word3 AND word4) with both feed into a Deduplication Agent so that you only get one copy of the event you want.

A simple OR can also be handled with must_match = 1, configure two rules for the words you are looking for and the Agent will trigger if either of the two rules matches. The AND has to be done in the two regular expressions though.

so, i couldn't figure my configuration out. I tried some but it didn't work. how should it be?

What did you try and what did not work? 😄


Support for reading legacy strings files and providing fallback strings

First off, I was about to write a similar plugin before I did a quick search and found yours. Glad I did because this looks great! 👏
I'm looking into replacing the use of SwiftGen in a project I'm working on with this plugin but there are two features I'd need before being able to do so. Before contributing I'd like to gauge interest to see whether you think the features are suitable additions to your plugin. These are:

The ability to parse legacy string files (for those who haven't migrated to string catalogs).
The ability to fall back to a base localization if translation isn't complete. So for example, going with the English string if the German counterpart is missing.

What do you think? To be clear, if these features are something you think would be valuable additions I'm more than happy to contribute.

Hi @simba909, thanks for reaching out! To go into details about your two suggestions:

The ability to parse legacy string files (for those who haven't migrated to string catalogs).

I initially started with on Strings Catalog support only for the following reasons:

I needed to keep the scope narrow to actually ship something
I wanted the tool to be a fresh take on Localization code generation following the modern best practices (Strings Catalogs and LocalizedStringResource)
SwiftGen and R.swift seemed to already be handling legacy formats for existing projects pretty well
There are some extra complexities involved with parsing .strings{dict} files, such as having to discover content across .lproj directories (instead of one single input file), parsing comments from .strings and processing the .stringsdict plist structure.
It was a bit too early to see how .strings and .xcstrings coexisting would look in reality for existing projects and my personal use-case for this tool was an iOS 17 only project

So that means that the tool today is pretty geared towards new projects rather than existing ones. With that said though, in my day-job, I have a much larger project using .strings and .stringsdict with an old version of R.swift and I do want to explore how I'd eventually migrate that to Strings Catalogs/XCStrings Tool so it's good to talk about this 🙂 It sounds like you are a bit further ahead of me in the process 👍
I'd like to understand a bit more from you though on why it is that you want to use XCStrings Tool to generate output for legacy .strings files? Is it because you don't want to use two different tools, or is it because you want a generated output that uses LocalizedStringResource like this plugin offers?

The ability to fall back to a base localization if translation isn't complete. So for example, going with the English string if the German counterpart is missing.

This should already happen when using XCStrings Tool I think. In my project, the source/development language is set to English, so if I define settingsTitle in my catalog with an English value of Settings, the tool will generate symbols that look something like this:
/// Title of the Settings screen
public var settingsTitle: LocalizedStringResource {
    LocalizedStringResource(
        "settingsTitle",
        defaultValue: #"Settings"#, // <-- this here is the important piece
        table: "Localizable",
        bundle: .current
    )
}

When Foundation does a lookup for settingsTitle in a different language, if it doesn't exist, then it'll fallback to using defaultValue instead of the key. Is that what you were after?
What isn't supported is if you wanted to be more intelligent with fallbacks between the user locale and the development language. For example, if you app supported es_MX, es-419 (Latin America), es and had a development language of en. If a user with es_MX locale wanted a string that didn't exist in es_MX but did in es-419 or es, Foundation wouldn't care and would only use the defaultValue which would be in English.
But supporting this lies in how Foundation does localized lookups from your LocalizedStringResource rather than anything particular about how we generate the symbols. We have all the information that we need in LocalizedStringResource to write your own custom localization lookup mechanism that supports this instead. It's what I had to do in our project so I can provide more tips separately if you wanted to dig into that more 🙂

I'd like to understand a bit more from you though on why it is that you want to use XCStrings Tool to generate output for legacy .strings files? Is it because you don't want to use two different tools, or is it because you want a generated output that uses LocalizedStringResource like this plugin offers?

The main reason we were looking at plain .strings parsing is because we haven't yet had the time to migrate to string catalogs but would like to get the LocalizedStringResource generation. We're also depending on a 3rd party to generate localizations that I don't think has support for string catalogs yet (although that's a different matter). Having looked closer at the differences between the formats though I'm not sure that building in support for parsing the legacy formats is a good direction to take for the plugin but maybe I'm overthinking things 🤔
(in the context of fallback strings)

This should already happen when using XCStrings Tool I think. In my project, the source/development language is set to English, so if I define settingsTitle in my catalog with an English value of Settings, the tool will generate symbols that look something like this:
/// Title of the Settings screen
public var settingsTitle: LocalizedStringResource {
    LocalizedStringResource(
        "settingsTitle",
        defaultValue: #"Settings"#, // <-- this here is the important piece
        table: "Localizable",
        bundle: .current
    )
}

When Foundation does a lookup for settingsTitle in a different language, if it doesn't exist, then it'll fallback to using defaultValue instead of the key. Is that what you were after?

Ah, this is excellent! Totally missed this when looking through the plugin initially. Will have to play around with this a bit because I think it covers all our needs! Thank you 👏🏻

because we haven't yet had the time to migrate to string catalogs but would like to get the LocalizedStringResource generation.

That's a great point, and something that I kind of overlooked before. This tool generates LocalizedStringResources which are a modern alternative to NSLocalizedString so there is still a benefit over what existing tools over having XCStrings Tool support the format in the interim 👍
Anyway, I was stuck at the airport yesterday with a 7h delay, so I took the opportunity to take a further dive into seeing if this is doable:

https://github.com/liamnichols/xcstrings-tool/pull/20

From the parsing side, it seems relatively straightforward. We can use PropertyListSerialization to read both file formats (at the expense of not being able to access comments, but I think that is fine) and the parsing logic for pulling out substitutions and plural rules from the .xcstrings format can mostly be reused with some light refactoring.
This gets us to a point where you can invoke the underlying CLI with either formats, but there are a couple of bits specific to the plugin integration that I need to think about still:

Merging Localizable.strings and Localizable.stringsdict into one generated output (since these two files would make up the same localization table)

This means that the CLI needs to accept multiple input files

Discovering the source/development language to know which .lproj directory to extract strings from

Maybe we could also just throw all discovered .strings/.stringsdict files into the CLI, but i'm not sure if this will work quite right

I think that we can do this in two steps though:

Finish up the basic .stringsdict support in #20
Support the use case for merging .strings and .stringsdict files
Update the plugin to support discovering the .strings{dict} files

If this turns out to not be easily possible, the first two steps are still useful if the xcstrings-tool cli is used directly, it's just that I initially tried to keep it hidden as an implementation detail but there is no harm exposing it for more advanced use cases like this.

Apologies for the late response.

Anyway, I was stuck at the airport yesterday with a 7h delay, so I took the opportunity to take a further dive into seeing if this is doable:

Support for legacy .strings and .stringsdict file formats #20

From a quick glance this looks great! Thank you 🙌🏻 I'll take a closer look at your PR and then come back to this thread when I've gathered my thoughts.

I think so!
I become less motivated to work on it once I found a bit of a blocker that I described at the end of my last comment, but I am still occasionally thinking about migration paths for projects that want to use Strings Catalogs/XCStrings Tool as a modern alternative to the strings generation tool that they used before and I think that this support would be good for that.
It's just that I haven't really found the time to focus on it as it hasn't been as much of a priority for me atm.

Hey, so I have made some progress on this today and am happy to say that the following will be supported as part of #20:

Generating source code for *.strings files
Generating source code for *.stringsdict files
Merging *.strings and *.stringsdict into a single generated ouput

i.e Localizable.strings ➕ Localizable.stringsdict ➡  Localizable.swift

I'm pretty happy with this as it unlocks a nice migration path into XCStrings Tool (and eventually for you to convert your .strings to .xcstrings), just I need some help to test the .stringsdict parsing some more since I haven't really used it much myself.
So far, I have the following fixture: https://github.com/liamnichols/xcstrings-tool/pull/20/files#diff-9b61fb72cfbd128cecc0be5bf6ba07257df78f2980ab774de382b1627c42db70
If you have .stringsdict files that are more complicated than this fixture, i'd love it if you could share any examples so that I am making sure to cover as many common edge cases as possible 🙏

I'm sorry I haven't been able to contribute to this effort. I am however very excited to see it merged, I will definitely try this out at the nearest opportunity! Thank you 🙏🏻

No worries @simba909, it’s released in 0.5.0 so check it out and if there are any issues we can solve them over time!


DCGAN model implementation

Fixes #811
Proposed Changes

model with full 2D and 3D support
architecture properties controlled in config file
in the future, need to take some additional look into the padding and kernel sizes in discriminator

Checklist

[X] CONTRIBUTING guide has been followed.
[X] PR is based on the current GaNDLF master .
[X] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
[X] Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
[X] Code has been blacked for style consistency and linting.
[X] If applicable, version information has been updated in GANDLF/version.py.
[ ] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
[X] Usage documentation has been updated, if appropriate.
[ ] Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
[ ] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Codecov Report
Attention: Patch coverage is 0% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 93.66%. Comparing base (64962a1) to head (d9c0396).

Files
Patch %
Lines

GANDLF/models/dcgan.py
0.00%
123 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   95.04%   93.66%   -1.38%
==========================================
  Files         119      120       +1
  Lines        8288     8411     +123
==========================================
+ Hits         7877     7878       +1
- Misses        411      533     +122

Flag
Coverage Δ

unittests
93.66% <0.00%> (-1.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update cupid.toml

https://github.com/anoma/namada-testnets/pull/2099
Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[x] Only one toml is added in this PR
[x] The file being added is indeed a .toml file
[x] The toml being added is to the correct folder, and only to the correct folder
[x] The eth_hot_key and eth_cold_key are present
[x] The email, discord, elements telegram, and twitter fields are present and valid

Whitespace found in filename. Found filename namada-public-testnet-15/Update cupid.toml


[BaseChinesePhonemizer] Use PinyinHelper instead of WordsHelper for hanzi conversion

For the record, I am aware of #897. However, I couldn't help but notice that the Base Chinese Phonemizer API uses WordsHelper rather than TinyPinyin's PinyinHelper (which the PinyinLyricsHelper uses). PinyinHelper tends to give the correct pinyin results, whereas WordsHelper gives plenty of errors. (For example, the common particle 么 gets romanized as "mo", when it is actually "me". PinyinHelper does not have this issue.)

I'll just close this, it's no longer needed.


[BUG] TypeLoadException

Version Information
KSP 2 Version
0.1.0
Space Warp Version
0.4.0

Bug Information
Describe the bug
TypeLoadException
To Reproduce
Install and launch the game. It only happens to me.
Expected behavior
Can play the game.
Link to crashlog [If Applicable]
[LOG 20:01:39.224] [System] ******* Log Initiated *******
OS: Windows 11  (10.0.22000) 64bit
CPU: AMD Ryzen 7 2700 Eight-Core Processor  (16)
RAM: 16336
GPU: AMD Radeon RX 6700 XT (12243MB)
SM: 50 (Direct3D 11.0 [level 11.1])
RT Formats: ARGB32, Depth, ARGBHalf, Shadowmap, RGB565, ARGB4444, ARGB1555, Default, ARGB2101010, DefaultHDR, ARGB64, ARGBFloat, RGFloat, RGHalf, RFloat, RHalf, R8, ARGBInt, RGInt, RInt, BGRA32, RGB111110Float, RG32, RGBAUShort, RG16, BGRA10101010_XR, BGR101010_XR, R16
Log started: lun., mar. 06, 2023 20:01:39
[LOG 20:01:39.764] Version Info: <IP_ADDRESS>.20892
[LOG 20:01:39.764] Command Line Args:C:\Program Files (x86)\Steam\steamapps\common\Kerbal Space Program 2\KSP2_x64.exe
[LOG 20:01:40.785] [UI] Primary EventSystem Selected: 'GameManager'(instance id: 205062)
[LOG 20:01:40.878] [UI] Localization sources updating
[LOG 20:01:41.094] [UI] Localization sources updating
[EXC 20:01:41.100] TypeLoadException: Could not resolve type with token 01000444 (from typeref, class/assembly SpaceWarp.StartupManager, SpaceWarp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)
KSP.Game.GameManager.Start () (at <8c5bdf369a8c45f68951f69eb825ef73>:0)

Solved reinstalling game


Modified Dense Layer @ Lines 36 & 71

name: b) New feature
about: Select this if you're adding a new feature to libra.
labels: feature

This pull request closes #issue_number_here .
- What I did
- How I did it
- How to verify it

[ ] I updated the docs.

This pull request adds a new feature to libra. @Palashio, could you please take a look at it?

Perfect.
On Sat, 18 Jul, 2020, 7:40 am Palash Shah<EMAIL_ADDRESS>wrote:

Merged #244 https://github.com/Palashio/libra/pull/244 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Palashio/libra/pull/244#event-3560423549, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2ROX4JCN4YZF2FGI25QOTR4EACZANCNFSM4O7GUZKQ
.


Is it possible to pipe the downloaded file to a write stream?

I'd love to have the option to return the downloaded file as a readable stream and pipe it to a write stream, similar to how it's done here. Is this difficult to implement? Thank you!

Thanks for this great suggestion!
I added the .raw method to make possibleto access stream objects at<EMAIL_ADDRESS>const youtubedl = require('youtube-dl-exec')
const fs = require('fs')

const subprocess = youtubedl.raw('https://example.com', { dumpJson: true })

console.log(`Running subprocess as ${subprocess.pid}`)

subprocess.stdout.pipe(fs.createWriteStream('stdout.txt'))
subprocess.stderr.pipe(fs.createWriteStream('stderr.txt'))

setTimeout(subprocess.cancel, 30000)

@Kikobeats This is great, thank you! I wrote a script to pipe the stream object to a stream passthrough in order to directly upload to S3, but the resulting video file is corrupt. Am I misunderstanding something here? I can successfully download the Twitter link in this code example using the normal youtubedl method.
const youtubedl = require('youtube-dl-exec')
const AWS = require('aws-sdk');
const stream = require('stream');

const s3 = new AWS.S3();
const uploadStream = ({ Bucket, Key, Metadata }) => {
  const pass = new stream.PassThrough();
  return {
    writeStream: pass,
    promise: s3.upload({ Bucket, Key, Body: pass }).promise(),
  };
}

const { videoId, filename } = {
  "videoId": "732194327145906176",
  "filename": "sample_video",
}
const url = `https://twitter.com/i/status/${videoId}`
const { writeStream, promise } = uploadStream({ Bucket: process.env.S3_BUCKET, Key: `${filename}.mp4`});

youtubedl.raw(url, {
  noCallHome: true,
  noCheckCertificate: true,
  preferFreeFormats: true,
  format: 'mp4',
  youtubeSkipDashManifest: true,
  output: '%(id)s.%(ext)s'
}).stdout.pipe(writeStream);

const data = await promise;
return {
  statusCode: 200,
  body: data,
};

The script looks nice to me but I can't say too much there since I didn't have a use case like that before.
What I can recommend you to do is get the streaming source video URL via Microlink API:
https://api.microlink.io/?url=https://twitter.com/eejohnnnn/status/732194327145906176&video
It uses youtube-dl (and this library) under the hood, then you can do a simple HTTP GET and pipe to your s3 bucket.

@Kikobeats amazing! Is there a rate limit for this api endpoint? I'd love to use it but I want to be respectful towards usage.


Issue when getting to the login screen for AlexaPi

I'm having the same issue, but i already have the device name set to my_device, as soon as i hit the ok button to get the key from the AlexaPi it shows up with
We're sorry!
An error occurred when we tried to process your request
Any ideas? Seems nobody else is having this now since the device name fixed it, I've tried moving the directory I launch it from, I've tried flashing and putting a new install on rasp on, I've also tried a new amazon account and nothing seems to work. The allowed URL's are correct for sure, I've got http://localhost:5000 and http://localhost:5000/code as a return so not sure what else it could be.

Are you doing this directly in the Raspberry Pi browser or by SSH?

Sorry, that's through the web browser, on both my computer and then the browser inside of the raspberry pi, I doubled check the allowed url's too and they were correct, I have both local host in there and the IP address of the pi so I could access it remotely and I get past all of the login part but as soon as I click ok for it to generate the secret key I get the error message (We're sorry etc...)

Try to create a new device, and in the Web Settings put again:
Allowed Origins
http://localhost:5000
http://raspberrypi:5000
Allowed Return URLs
http://localhost:5000/code
http://raspberrypi:5000/code
These addresses are working for me.

Tried that, no luck

Here's what's required to generate the refresh token:
1.) creds.py must have correct values for

ProductID
Security_Profile_Description
Security_Profile_ID
Client_ID
Client_Secret

...available under General at developer.amazon.com
2.) Web Settings at developer.amazon.com must be set correctly

Allowed Origins: http://xxx.xxx.xxx.xxx:5000 where the x's are your IP address
(This will be 5050 instead of 5000 if you're using versions that have shairport-sync)
Allowed Return URLs: http://xxx.xxx.xxx.xxx:5000/code
(again, might be 5050)

If you login via your Raspi browser, type the IP address into the browser, not localhost.  If you would rather type localhost into the browser, replace the x's above with localhost.  This only works from the browser within the raspberry pi.
It sounds like folks have had mixed success using raspberrypi.local instead of the IP address, but again, you should type into the browser what you have entered into your Web Settings.
3.) run auth_web.py as root, then go to port 5000 of your ip address from a browser on the local network.
I can't think of anything else that's necessary, and when I've had issues, I have made some mistake within one of the three items listed above.

Ok, thanks! I'll try it out soon

Does it work for you yet?

I have a little bash script that comes in handy. I thought I had posted it up here, but I can dig it up.

This project is now deprecated in favor of the new AlexaPi (https://github.com/alexa-pi/AlexaPi) which has all the features of this project and much more, such as:

support for a wide range of devices and platforms (Raspberry Pi, CHIP, Orange Pi, desktops, Magic Mirror and others)
voice activation (great PocketSphinx support and snowboy support soon to be released)
much more robust installation and configuration
better security
Arch Linux support
awesome documentation
and much, much more! You get it - it's just awesome.

Please switch over to the new project and if your issue persists there, file an issue in the new repo's issue tracker. Thank you.


CB-3762 Error when passing an extra '/' at end of cloud storage path

Maybe it is worth to create one trimBaseLocation method (somewhere, in an util class, or sthing like that) and using that everywhere.
Also please add unit test for this logic to avoid any other issue in the future.

@gergopapi2 pointed to a better solution, so I will change this function to that function


Fix #126 by using newUrl rather than modifyUrl.

Thanks a lot for investigating and fixing this @bentayloruk!


Vertical alignment fails if separator is a multibyte character

I changed the separator in ifetchrc from s=" >> " to s=" » ", and this is what I saw:

I assume strlen(3) thinks that ‘»’ is two characters wide, but “RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK” is a two-byte character with a width of 1.
I'm not an expert in these matters, but using wcslen(3) instead of strlen(3) could possibly solve this. However, it is not as simple as replacing all occurances of strlen() with wcslen() since some of the data structures are expecting a char * and wcslen(3) expects wchar_t *.
I don't really speak C, so I cannot provide a diff.

Multibyte characters should not cause issues now! Let me know if anything doesn't work as expected

That was way more changes than I had expected. No wonder it didn't work just by replacing strlen() with wcslen(). :wink:


AllowedCallers on hosts should be automatically inferred from configured skills

The runtime currently registers allowedCallers based on config settings (here).
This is OK for skills, but for hosts (i.e.: bots that call skills), this list should be automatically inferred from the configured skills in the host, see AllowedSkillsClaimsValidator that is different than AllowedCallersClaimsValidator

I think the broken logic is here: https://github.com/microsoft/botbuilder-dotnet/blob/82d0ad30d3943a5b72591f380086307aebc2c009/libraries/integration/Microsoft.Bot.Builder.Integration.Runtime/Extensions/ServiceCollectionExtensions.cs#L88-L94

@gabog to review requirements for R14.


Feature/openhelpd 139 more feedback

@rowanseymour Please review

@jpaidoussi looks fine besides the small matter of referencing model classes in the migration

@rowanseymour Fixed, ready for another look.


Request: add bottom padding to footer and remove chevrons

Thanks for your help again! I now have almost recreated what I had in CH.
CH version:

Card mod version (don't mind the colors)

Right now I need the icons to go a little higer, with bottom padding 30px and spread out to fit 6 icons and lose the chevrons, to it looks exactly like on CH. Is this possible? Thanks again!
I use this code btw:
  card-mod-root-yaml: |
    paper-tabs:
      $: |
        .not-visible {
          display: none;
        }
        #selectionBar {
          bottom: unset !important;
        }
    "ha-app-layout":
      $: |
        #contentContainer {
          padding-top: 0px !important;
        }
    .: |
      app-toolbar {
        display: none;
      }
      .edit-mode, app-header, app-toolbar {
        background-color: var(--ch-background) !important;
        color: var(--ch-all-tabs-color) !important;
      }
      app-header {
        top: calc(100vh - 48px) !important;
      }
      app-header.edit-mode {
        border-bottom: 2px var(--primary-color) solid;
        padding-bottom: 10px;
      }
      app-header[shadow] > ::before {
        box-shadow: inset 0px 5px 6px -3px rgba(0, 0, 0, 0.3);
      }
      #add-view ha-svg-icon {
        background-color: var(--primary-color) !important;
        color: #EEE !important;
        border-radius: 5px !important;
      }
      .edit-icon {
        color: var(--primary-color) !important;
      }
      mwc-icon-button[label="Start conversation"] {
        top: 0;
        right: calc(48px * 1);
        z-index: 2;
        position: absolute;
      }
      mwc-icon-button[title="Help"] {
        top: 0;
        right: calc(48px * 2);
        position: absolute;
        z-index: 2;
      }
      mwc-icon-button[title="Close"] {
        top: 0;
        left: 0;
        position: absolute;
        z-index: 2;
      }
      mwc-icon-button#add-view {
        position: fixed;
        right: calc(48px * 1);
      }
      ha-button-menu {
        top: 0;
        right: 0;
        z-index: 2;
        margin-left: 5px;
        position: absolute;
      }
      app-toolbar > [main-title] {
        display: none;
      }
      menu-button[style="visibility: hidden;"] {
        display: none;
      }
      ha-menu-button {
        z-index: 2;
        top: 24px;
      }
      paper-tabs {
        --paper-tabs-selection-bar-color: var(--text-color) !important;
        margin-left: 48px !important;
      }
      paper-tab[aria-selected="true"] > ha-icon {
        color: var(--text-color) !important;
      }
      paper-tab[aria-selected="true"] {
        color: var(--text-color) !important;
      }
      @media (orientation: portrait) {
        paper-tabs {
          margin-left: 64px !important;
          margin-right: 32px !important;
        }
        ch-header > paper-tabs,
        app-header.edit-mode > * > paper-tabs {
          margin-left: 10px !important;
          margin-right: 10px !important;
        }
      }
      ch-header > ha-button-menu {
        top: unset;
      }
      ch-header > paper-tabs,
      app-header.edit-mode > paper-tabs {
        margin-left: 0;
      }
      app-toolbar a {
        color: var(--primary-text-color) !important;
      }

Do a reinstall, choose main as the version, and see how it goes.

And what's a chevron again? 🤔

And what's a chevron again? 🤔

the little arrows at the sides when you have more than 5 icons.
Right now, the menu and option buttons (three stripes and three dot icons) are hidden, but the space is empty. Ideally the icons are spread across the width, showing 6 icons and losing the arrows (chevrons).

Does the overflow menu, voice button, and sidebar button matter to you?

Does the overflow menu, voice button, and sidebar button matter to you?

No, I strictly want icons on the header (footer in this case) :)

Asking the community's feedback, might make one user angry by making another one happy:
https://community.home-assistant.io/t/card-mod-super-charge-your-themes/212176/109?u=ktibow

Asking the community's feedback, might make one user angry by making another one happy:
https://community.home-assistant.io/t/card-mod-super-charge-your-themes/212176/109?u=ktibow

I tested your change btw, It was higher but not enough. I changed it myself and have achieved the ideal height with this code:
      app-header {
        top: calc(100vh - 80px) !important;
      }

One thing now: since it's a compact header, the area below the padding is transparant. Is it possible to increase the height of the header, while also setting the tabs higher to achieve the same result as I showed with CH?

So the part below the footer needs te be filled in as well.

You don't need to keep quoting me... Anyway looks like you haven't set var(--ch-background), so just set it back to primary-color. I'm commiting and making it further away again. A release should be out soon.

Sorry about quoting. I do have var(--ch-background) set though, that's why it's slighlty different then #000000 (mye primary-color). Setting that back to primary-color, makes it all black, but still shows empty area underneath.
Thanks, I will try the new release. I really appreciate all your help and work.

Resolved?

I still have the chevrons and the space below is still transparent (it is higher yes, but below is empty like in the screenshot). I don't see a new update, or am I misunderstanding you?

Can you install the dark soft UI theme with HACS, modify the YAML, and see if there's any problems?

I tried that, gives the exact same result as my screenshot. Menu button is still visible, also area below the header is transparent.
  # Header
  card-mod-root-yaml: |
    paper-tabs:
      $: |
        .not-visible {
          display: none;
        }
        #selectionBar {
          bottom: unset !important;
        }
    "ha-app-layout":
      $: |
        #contentContainer {
          padding-top: 0px !important; /*Change this to 0px if you want the header on the bottom*/
        }
    ha-button-menu$mwc-menu$mwc-menu-surface$: |
      .mdc-menu-surface {
        margin: 10px;
        box-shadow: var(--ha-card-box-shadow);
      }
    .: |
      app-toolbar {
        height: 0;
      }
      .edit-mode, app-header, app-toolbar {
        background-color: var(--ch-background) !important;
        color: var(--ch-all-tabs-color) !important;
      }
      app-header {
        top: calc(100vh - 72px) !important;
      }
      app-header.edit-mode {
        border-bottom: 2px var(--text-color) solid;
        padding-bottom: 10px;
      }
      app-header[shadow] > ::before {
        box-shadow: inset 0px 5px 6px -3px rgba(0, 0, 0, 0.3);
      }
      #add-view ha-svg-icon {
        background-color: var(--ch-background) !important;
        color: #EEE !important;
        border-radius: 5px !important;
      }
      .edit-icon {
        color: var(--ch-background) !important;
      }
      mwc-icon-button[label="Start conversation"] {
        top: 0;
        right: calc(48px * 1);
        z-index: 2;
        position: absolute;
      }
      mwc-icon-button[title="Help"] {
        top: 0;
        right: calc(48px * 2);
        position: absolute;
        z-index: 2;
      }
      mwc-icon-button[title="Close"] {
        top: 0;
        left: 0;
        position: absolute;
        z-index: 2;
      }
      mwc-icon-button#add-view {
        position: fixed;
        right: calc(48px * 1);
      }
      ha-button-menu {
        top: 0;
        right: 0;
        z-index: 2;
        margin-left: 5px;
        position: absolute;
        display: none;
      }
      app-toolbar > [main-title] {
        display: none;
      }
      menu-button[style="visibility: hidden;"] {
        display: none;
      }
      ha-menu-button {
        z-index: 2;
        top: 24px;
      }
      paper-tabs {
        --paper-tabs-selection-bar-color: var(--text-color) !important;
        margin-left: 48px !important;
      }
      app-toolbar:not(.edit-mode) > div > paper-tabs {
        margin-left: 6px !important;
      }
      paper-tab[aria-selected="true"] > ha-icon {
        color: var(--text-color) !important;
      }
      paper-tab[aria-selected="true"] {
        color: var(--text-color) !important;
      }
      @media (orientation: portrait) {
        paper-tabs {
          margin-left: 64px !important;
          margin-right: 32px !important;
        }
        ch-header > paper-tabs,
        app-header.edit-mode > * > paper-tabs {
          margin-left: 10px !important;
          margin-right: 10px !important;
        }
      }
      ch-header > ha-button-menu {
        top: unset;
      }
      ch-header > ha-menu-button,
      app-toolbar.edit-mode > ha-menu-button {
        top: unset;
        margin-left: unset;
      }
      ch-header > paper-tabs,
      app-header.edit-mode > paper-tabs {
        margin-left: 0;
      }
      app-toolbar a {
        color: var(--ch-all-tabs-color) !important;
      }

To clarify I have this setup (which works fine with your code)
ch-background: '#141414'
ch-all-tabs-color: "rgba(255, 255, 255, 0.30)"

I updated and edited the theme. It's very close now! The menu button and options are gone :) There still is space below the header though, just like on your screenshot as well. I think this cannot be set, because it's a compact header that is moved up a little. I think the only solution is to increase the size of the header itself, while moving the app-toolbar up (not sure it that's even possible).
I like the shadow to the header, though the selection stripe kinda ruins the rounded edges of the box (on your screenshot)

Do you mean making there be some padding below?
I know it does, I can fix that with some padding. It's hard to find other community feedback for it though, last time I tried to find a hue with a poll nobody responded.
The current code only hides invisible chevrons. If the header overflows, chevrons will be displayed anyway. I think having the ability to see all tabs is important.

Yes, I mean padding below the custom header, so it's like this:

Do you think it's at all possible to hide chevrons? I ask because I have button-cards represent rooms on my main tab as well (which go to hidden tabs, so that's why I don't need the chevrons).

Sure, I guess that would work.
Yeah, just change
https://github.com/KTibow/lovelace-light-soft-ui-theme/blob/6a9e0258472587b1e88401e851f5afb0cd7ff0bb/theme.yaml#L265-L267
to
        paper-icon-button {
          display: none;
        }

Thanks! Do you know how to increase the padding below the header?

Okay, still waiting until the percent for the overflow menu is not equal to 50%, but I'll go ahead.

Try reinstall from main.

Tried re-installing, which gave me the same code. I copied the code from the github (saw it was changed). Tried that, but the header moves when scrolling. I think because position is set to absolue? Tried sticky, but that lost the padding at the bottom again.

Try this patch:
-        bottom: 60px;
-        position: absolute;
+        transform: unset !important;

Install from main again and see if that fixes it.

Tried the patch first, then replaced all Header code with new one too. Gives same result: the area below the header simply is empty again. I'm guessing it's just not possisble to recreate this.. ?

I did notice, that when leaving bottom: 60px (in my case 80px) there was a padding but the background was completely transparent. For now, maybe just close this since I think it will break more then do actually good having the padding.

I thought that was what you wanted?

No? The whole point was to recreate that image above. That still has not worked unfortunately. Either the space below is empty (so you can actually see content under the footer when scrolling, which is what I keep trying to fix) or it’s completely transparent (you can see all content through the footer when scrolling).

Oh, thought the screenshot was of the current thing. Can you show a screenshot of the card-mod version?

See area with green arrow. That needs to be the same color as the app-toolbar. So the app-toolbar needs to be bigger, to cover the entire area since it’s moved up.

Oh, let me see....

One thing I also noticed with the footer. The content in lovelace doesn't actually respect the area of the footer. So when you have a full page, you can't see the bottom when you scroll to the end. Part of lovelace remains behind the footer. I suppose I can add a gap-card after the last card on each view, but just wanted to let you know.

Hi, did you find the time to see if it's possible to add the paddings / fix the space below? If it's not possible, then I suppose there is no point in keeping this issue open.

Sorry, kind of overloaded by notifications right now. The stale bot is just because it's hard for me to manually close issues, but I'll get back to this soon.

Can you please sum up your problem again? Sorry about that, but this is a long thread and I'm having trouble keeping up.

Ofcourse and totally understandable, take your time.
So right now I have the header in compact mode and as a footer. That works. However, it’s too close to the bottom. So I requested you to add paddings so it’s higher. That works too, but gives a problem at the same time:
I believe: because it’s in compact mode and is setup to be higher, the area below the header (in footer mode) is empty. So when you scroll, you actually see and can control content below the area under it. You can see that in this screenshot, see the area with green arrow.

The second problem is that the last content actually stays at the bottom of the display, behind ánd under the header. So you also cannot reach the final card completely.
So what needs to be solved: the final card needs to be ABOVE header (not behind and under it) when reaching the end of the page. And the header (app-toolbar) needs to be bigger when in compact mode, so the area below it is actually filled.


autoprefixer doesn't work on inline component styles

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
$ ng --version
Angular CLI: 6.1.5
Node: 8.11.4
OS: win32 x64
Angular: 6.1.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.5
@angular-devkit/build-angular     0.7.5
@angular-devkit/build-optimizer   0.7.5
@angular-devkit/build-webpack     0.7.5
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.5
@angular/cli                      6.1.5
@ngtools/webpack                  6.1.5
@schematics/angular               0.7.5
@schematics/update                0.7.5
rxjs                              6.3.1
typescript                        2.7.2
webpack                           4.9.2

Repro steps

ng new test-styles
Replace app.module.ts with:

import { BrowserModule } from '@angular/platform-browser';
import { NgModule, Component } from '@angular/core';

@Component({
  selector: 'app-root',
  template: '',
  styleUrls: ['./app.component.css']
})
export class AppComponent {}

@Component({
  template: '',
  styles: [`:host { display: grid; }`],
})
export class AppComponent2 {}

@NgModule({
  declarations: [
    AppComponent,
    AppComponent2
  ],
  imports: [BrowserModule],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

Add CSS to app.component.css:

:host { display: grid; }

ng build

In dist/test-styles/main.js you will see:
/***/ "./src/app/app.component.css":
/*!***********************************!*\
  !*** ./src/app/app.component.css ***!
  \***********************************/
/*! no static exports found */
/***/ (function(module, exports) {

module.exports = ":host { display: -ms-grid; display: grid; }"

/***/ }),

...
var AppComponent2 = /** @class */ (function () {
    function AppComponent2() {
    }
    AppComponent2 = __decorate([
        Object(_angular_core__WEBPACK_IMPORTED_MODULE_1__["Component"])({
            template: '',
            styles: [":host { display: grid; }"],
        })
    ], AppComponent2);
    return AppComponent2;
}());

CSS from app.component.css was processed by autoprefixer, but inline component styles were not.

Found this issue: https://github.com/angular/angular-cli/issues/8470#issuecomment-344099619

Inline styles will not be rendered with a special renderer, unfortunately. It is impossible for us to know which compiler you want your inline style to use, and even so we don't have control over how inline styles are compiled; we do not resolve their content like we do with external styles. This is a limitation of the angular compiler itself.

Inline component styles only support the native CSS, and SCSS/Less/Styles compilers are not planned to be supported. But what about autoprefixer? Is it still not possible because of "a limitation of the angular compiler"?

Closing as working as indented.
Inline styles cannot be processed via webpack. Basically it’s “what you write is what you get”.
If you want to use Autoprefixer use external styles.


pull request for e2e test at 02/06/2017 05:45:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[improve][cli] Expose updateLocalTopicOnly to UpdatePartitionedCmd

Motivation
We can set updateLocalTopicOnly when updating partitions by PulsarAdmin like
 admin.topics().updatePartitionedTopic(partitionedTopicName, newPartitions, false, false);

But updateLocalTopicOnly is not exposed to CLI command UpdatePartitionedCmd
$ bin/pulsar-admin topics update-partitioned-topic

  Options:
    -f, --force
      Update forcefully without validating existing partitioned topic
      Default: false
  * -p, --partitions
      Number of partitions for the topic
      Default: 0

Modifications
exposeupdateLocalTopicOnly  to CLI command UpdatePartitionedCmd by adding a new option "--update-local-only" or "-ulo".
Verifying this change

[ ] Make sure that the change passes the CI checks.

Documentation

[x] doc-not-needed

Matching PR in forked repository
PR in forked repository:  https://github.com/aloyszhang/pulsar/pull/12

Codecov Report

Merging #19162 (6d4ddcf) into master (c862356) will decrease coverage by 14.81%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #19162       +/-   ##
=============================================
- Coverage     46.50%   31.69%   -14.82%
+ Complexity    10297     6087     -4210
=============================================
  Files           687      633       -54
  Lines         67425    59889     -7536
  Branches       7237     6239      -998
=============================================
- Hits          31357    18980    -12377
- Misses        32544    38255     +5711
+ Partials       3524     2654      -870

Flag
Coverage Δ

unittests
31.69% <0.00%> (-14.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Used Host style URL to connect S3 server but still need a bucket param

Describe the bug
I tried to setup a endpointUrl using the new Endpoint spec and added bucket name to the url. But when do some operations(list/get/put/delete), it still requires a bucket param in the request object.
Expected behavior
It should parse the bucket (and region) from Url directly. No need extra setting in S3Client and request object.
Current behavior
Current it complains bucket is null.
Steps to Reproduce

use a host-style endpoint to connect localstack, eg. http://etip-files.s3.localhost.localstack.cloud:4566
when send request, I removed the original bucket in the request object.PutObjectRequest {
       // bucket = bucketName
        body = ...
        key = ...
        contentType = ...
    }

failed.

Possible Solution
Parse the bucket from url.
Context
No response
AWS Kotlin SDK version used
0.20.2-beta
Platform (JVM/JS/Native)
Java 17
Operating System and version
Windows 10

Hello @hantsy--
Unfortunately, bucket is a required parameter for S3 operations like PutObject. Even when manually specifying an endpoint, the request itself must still contain a valid bucket.
At this time, we do not support deriving request parameters from endpoints and, to our knowledge, no other AWS SDK does either. If this feature were to be implemented, it would likely require coordination across all SDKs. If that's important to you, please consider filing a request https://github.com/aws/aws-sdk/issues.

I do not know the meaning of the new host style url if it does not support parse bucket and region from the URL.
Wired API design.

From the project description, this project is written in Kotlin and wrap the AWS Service APIs for JVM and Android, not simply port Java version, right?

For example, if I connect to S3 bucket1 via URL, but I can pass a bucket2 to do some operations in the PutObjectRequest, do you think it is reasonable?


fix path parameter bug for integers

Hello,
According to Flask documentation, "int" in decorator means positive values. Current code is for the case "int(signed=True)".
So, I have fixed this issue with this PR.

Hello,
Coverage decreased due to uncovered lines, but they do not come from my pull request. This issue is there for some PR (for example https://github.com/flasgger/flasgger/pull/465).
@billyrrr @rochacbruno do you have an idea to fix this issue?
Have a good day,
Cédric.


Removed organization affiliations from website

Motivation
As pointed out, the ASF policy is to not indicate affiliations in team's page.

run java8 tests


error on npm start

I started today a new plugin and when i  "npm start" i get this errors
SyntaxError: Unexpected token ...
at createScript (vm.js:74:10)
at Object.runInThisContext (vm.js:116:10)
at Module._compile (module.js:533:28)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Module.require (module.js:513:17)
at require (internal/module.js:11:18)
at Object. (C:\xampp\htdocs\residence\wp-content\plugins\playground\node_modules\cgb-scripts\config\webpack.config.dev.js:24:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: cgb-scripts start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\cretu\AppData\Roaming\npm-cache_logs\2018-12-08T10_42_37_633Z-debug.log
My older plugin - works just fine on npm start. I did a version update on create-gutenberg-block before this so i don;t know if is a issue with a new version or something on my system.
Any ideea ?
Thank you

File a bug report and answer the questions in it.


Swipe to back issues in flutter

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
App Exist when we try swipe back or exit alert WillPopScope not working here it is conflict with new swipe actions on android in some devices with version Android 13
Expected results
Properly provide a exit pop up
Actual results
https://github.com/flutter/flutter/assets/102789684/b16fdd94-c2a7-4c1d-b1d8-8605e0f768c1
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/102789684/e24f69ef-4883-4720-bed6-d1c9e2cf12dc

Logs
Logs
No Issues Appear

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.2, on macOS 13.5.2 22G91 darwin-arm64, locale en-IN)
    • Flutter version 3.13.2 on channel stable at /Users/caddcentre/Documents/src/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ff5b5b5fa6 (3 weeks ago), 2023-08-24 08:12:28 -0500
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/caddcentre/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.82.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 05F65951-9BC2-47E5-86EC-36206C552609 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 13.5.2 22G91 darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 116.0.5845.179

[✓] Network resources
    • All expected network resources are available.

• No issues found!

You have to use PopScope for that, as the old WillPopScope does not handle Predictive Back on Android.
This has not yet been released to stable just yet.
https://docs.flutter.dev/release/breaking-changes/android-predictive-back

Thanks for your input @navaronbracke. Hi @VasuBhav. As in https://github.com/flutter/flutter/issues/134510#issuecomment-1715140744, are you able to switch to the latest master to check if PopScope works fine in your case?

Thanks for your input @navaronbracke. Hi @VasuBhav. As in #134510 (comment), are you able to switch to the latest master to check if PopScope works fine in your case?

Thank you for your guidelines, it will be helpful for me and the issues are now fixed


Serialization: Resolve type of CustomAttr before serializing

This fixing a crash during serialization when lazy typechecking is enabled.
Resolves rdar://117442955

@swift-ci please smoke test