MWPW-135103 add NL sitemap config for templates

Adds configuration so that NL sitemap for templates is also generated
Resolves: MWPW-135103
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/?lighthouse=on
After: https://MWPW-135103-nl-sitemap-templates--express--adobecom.hlx.page/express/?lighthouse=on

Codecov Report

Merging #188 (d242c62) into main (5e5f724) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   35.48%   35.48%
=======================================
  Files          27       27
  Lines        9463     9463
=======================================
  Hits         3358     3358
  Misses       6105     6105

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[5.6] Highlight the discovered package name

Highlight the discovered package name rather than the Discovered package string. This also maintains consistency with the composer output
Semi-related to this PR - https://github.com/laravel/laravel/pull/4635

Can you post screenshots of before and after?

Before:

After:

Example composer output for comparison:


Add support for callbacks

You can hook into some of the dashboard actions to run custom business logic.

Syntax
SplitWimduDashboard.configure do |config|
  config.observers.add(topic: :finish_experiment) do |experiment|
    # do something with `experiment`
  end
end

Supported callbacks

start_experiment
finish_experiment
reset_experiment
reopen_experiment
delete_experiment

@Deradon oh hai! :wave: :D

I like it

looks good!

@lukaszklis @paranoida @AlexParamonov
Looks like it's been approved. Will merge it tomorrow xD


Nested routes

How would one go about having nested routes, whereas the first stage route (e.g. /users) triggers a transition where a navigation component and some content is shown. But once the user clicks on the navigation to go to a nested route, merely the content is transitioning.
I've tried multiple things, but whatever I do; the upper route changes too and thus the entire page keeps transitioning while I only want the nested part to transition. I'm pretty sure this happens due to my router configuration, but I cannot seem to figure out why.

You're totally right. I was busy doing so by altering the Routing example, but it became a mess so I thought I just fired up the question first in quest for a clue.  Hang in there, I'll get back to you tomorrow. Thanks a lot for responding.

Ok. I've reproduced the behaviour in a minimal fashion, not fully optimized, but I think it's clear what I'm trying to do here:

When landing a main route (e.g. /red) the transition is triggered and it renders the main route component.
From within this main route a Link is rendered which gives access to the subroute (e.g. /red/ultra)
When navigating to this sub route the transition for the mainroute is triggered as well, while I just want the sub route to transition.

I do realize that this is more react-router behaviour (triggering the location change for the parent route as well) than it is behaviour of react-spring, but I think this ticket is still in the right place because I bet more people will run into it. RIght? 😃

Like you say, your issue is more a react-router issue; basically your top route is re-rendering when the child route is different, even though the parent should not re-render.
I've solved this (I believe) by changing what the parent switches on, basically, instead of keys={location.pathname} in the App component, I've done keys={location.pathname.split('/').slice(0, 2).join('/')} so that the parent only swaps out when that component does need to change.
https://codesandbox.io/s/2z0w19qk0j

@danielterwiel @dominicglenn
Here's a fixed version: https://codesandbox.io/s/mjnwrk1o3p
The problems were:

Make sure to use the native flag when your animated component contains complex subtrees. This lets React render only once, from then on the animation is done outside of React, mutating the dom directly. Previously it would render the whole route tree thousands of times, likely confusing react-router

The reason that everything would re-render on sub-route changes was the key you gave Transition:

<Transition keys={location.pathname} ...

The key would be different for /red and /red/ultra so it starts unmounting/mounting because it assumes theses are two components.
If you are more specific, like so:
<Transition keys={keys={location.pathname.split('/').filter(a => a)[0]}} ...

It would stay put if the main route is the same. I am not an expert when it comes to react-router, for certain they must have some api that does this more elegantly.

Thanks a whole lot to both of you. I clearly did not fully grasp some the keys concept while it's actually pretty straight-forward.
I already had the native flag set in my application, but did not migrate it to the example. Thank you for pointing it out the significance of its impact on performance, I was not fully aware.

It's basically the same as any generic React key, for instance in a list <li key={something}>. The only difference is that Transition sets these by itself, and needs them beforehand. It may seem weird that you need a key even if you have only one element, but it's actually two, as Transition will keep React from unmounting right away so that animations can be applied to it. At this point React would start screaming in your console if there weren't any keys.

Like you say, your issue is more a react-router issue; basically your top route is re-rendering when the child route is different, even though the parent should not re-render.
I've solved this (I believe) by changing what the parent switches on, basically, instead of keys={location.pathname} in the App component, I've done keys={location.pathname.split('/').slice(0, 2).join('/')} so that the parent only swaps out when that component does need to change.
https://codesandbox.io/s/2z0w19qk0j

This totally works! Thanks!


Added Romanian language

I've added Romanian language - ro. Left error messages in English because they make more sense.

@AlinGhitu I will get this added in today thanks.


kdl_parser: 2.4.1-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository kdl_parser to 2.4.1-1:

upstream repository: https://github.com/ros/kdl_parser.git
release repository: https://github.com/ros2-gbp/kdl_parser-release.git
distro file: foxy/distribution.yaml
bloom version: 0.9.7
previous version for package: 2.4.0-1

kdl_parser
* Remove unused find_library call (#40 <https://github.com/ros/kdl_parser/issues/40>)
* Contributors: Michael Carroll

This release should unblock Windows Debug builds for the upcoming Foxy path release.


[RFE] Update to RHV 4.2 using generic blueprint

Blueprint available here:
https://cloud.ravellosystems.com/#/0/library/blueprints/3125667268841/canvas

RHV 4.2 updated. Generic blueprint not used as hosted-engine access is still an issue.


[FEATURE]  Want to add Style on scrollbar

Description
The scrollbar of the website is missing style, I want to add styling on  it.
Screenshots

Additional information
No response

you can create official website for can do it now @HimanshuNarware

can i work on this under GSSOC23

you can create official website for can do it now @HimanshuNarware

@sazamansari  can i start working on this issue

@HimanshuNarware  yes you can start


Add awesome-cryptography

Link: https://github.com/sobolevn/awesome-cryptography

@jnv Any feedback, please?

Thanks Soboloev! I didn't have chance to look into this until now.


cannot include setup.h

I just pulled down the project and just tried to build under VS 2013 and it is complaining about not finding "wx/setup.h' in the platform.h when compiling.  Right above it gets the compiler.h, but there is no setup.h in the directory directly, but looks like there are ones in each of the platforms.  Figure there is simple I am missing.
Thanks

Did you build wxwidgets?

Yes, I was in error and didn't realize that needed to be build separately.  I then tried Debug DLL and was still getting some include errors even though I build both debug types in the wxwidgets solution, but I was able to build and run debug without any issues,
Thanks for the help.

So I need to build both \bin\mdb2sqlite.sln and \mdb2sqlite-master\wxwidgets\build\msw\wx_vc12.sln in Debug DLL mode?
Both of them failed.
(I just want to create a dll version of this application so I can convert file in my program.)

I built \wxwidgets\build\msw\wx_vc12.sln under VS 2017. Then it missed \lib\vc_lib.obj when building  \bin\mdb2sqlite.sln.
Is this a vc++ toolset version problem? Can you add a vc++2017 version 15 build file?
(I just want to create a dll version of this application to convert db in my program. ) Thanks.

I built \wxwidgets\build\msw\wx_vc12.sln under VS 2017. Then it missed \lib\vc_lib.obj when building \bin\mdb2sqlite.sln.
Is this a vc++ toolset version problem? Can you add a vc++2017 v14.16 build file?
(I just want to create a dll version of this application to convert db in my program. ) Thanks.

Project was using a very old version of wxWidgets, that was the main reason of your problem.
As of today mdb2sqlite project is built using CMake and wxWidgets version was updated to achieve all  current Visual Studio version support.
You can build mdb2sqlite for vc++ 2017 by firstly building wxWidgets with that toolset, which is wxwidgets\build\msw\wx_vc15.sln and then generating mdb2sqlite project using vc++ 2017 generator which is part of the CMake infrastructure. To create a dll version of the project you will have to modify the appropriate contents of the CMakeLists.txt file to achieve this, Best of luck.

Thank you very much. I finally managed to compile your project in VS 2013 and 2012.(but failed in VS 2010, the reason I don't think it supports C++11 auto)
And I manged to create a dll version which can be called externally to use the function bool CSettingsReader::Control(const char *Path, const char *dPath, CUIObs *pObs, bool bConvert)
;-) But I just mask CUIObs *pObs by NULL, and comment some statements. It still rests a lot of optimisation for me to do to get rid of  wxwidegets.
Regards.


Please unbundle dependencies

Hi, It is possible to unbundle all dependencies from this repo?
I mean all external libraries, including those ffi_* than have separate repos. All libraries should go into their place in system. This will ease package maintenance.
Also, json-lua could be replaced with cjson, which is available almost in every distro, even in RHEL ;).
I've added some of them in my gentoo overlay (https://github.com/Perlovka/portage-overlay/tree/master/dev-lua), but still using a "hack" to unbundle them from code (https://github.com/Perlovka/portage-overlay/blob/30641bcd9310ec0134f3a16f1d268ef99b29ca15/dev-lua/zigbee-lua/zigbee-lua-0.1_pre20190529.ebuild#L47)
Thanks.

Also, please consider to release ffi_* libraries, at least as 0.1 version, this will ease packaging too )

Hm, I can certainly release them, but I do not really see how this improves matters much - it's all just a submodules init / submodules update away? What exactly do you mean by "unbundle"?
json-lua is a pure Lua thingy, so why have another external dependency with cjson?
A bit more explanation: without using MQTT and/or HTTP (server), there's no external non-Lua dependencies aside from Lua(JIT) itself and a Linux kernel. I consider this a plus, actually.

By "unbundle" I mean that package should not provide external code as git submodule or just copy a piece of it. If dependency has its own repo, package manager should install it as a dependency, not bundle all deps in one package. This is how package management works.
Let's say you wrote one more app using libmosquitto.  And when you change libmosquitto itself, you should repackage both applications, instead of just update libmosquitto.
cjson - just because almost all distros already have it in their repos. So this is more easy just to install it and not find someone who will package it for you. Also it's usually faster than pure lua implementations (https://github.com/efelix/lua-cjson/blob/master/performance.txt)

I would not consider all the submodules being separate entity like packages on a linux distro. They are certainly separate entities, though - even if just for the organization of software I write. No, I'll leave it like this. If someone were to package zigbee-lua for some distribution, I leave it to that person to un-vendor the dependencies if that really was necessary, but I'm very much in doubt. If I were to package this, I would just package the code of this repo along with the submodules and not even try to make separate packages out of them. It's all just a bunch of Lua source code. E.g. the ffi_* submodules, they are not worth to be made packages. And why not make them submodules? I might be or already am using them in other software projects, so it's just a bit of deduplication to include them as submodules. Similar for the "external" chunks.
cjson: Here, too, I will stay with a pure Lua solution. As for the reasoning, it's the same: I'm fine with vendoring json-lua. This all boils down to chosing priorities - mine is to keep all the code tightly integrated.

If someone were to package zigbee-lua for some distribution, I leave it to that person to un-vendor the dependencies if that really was necessary

The problem is that for unbundle it properly, that person should patch sources, to change all require paths.
Anyway, it's your code, and your desicion. Thanks for the answer )

Yes, and in any case feel encouraged to ask and question the design decisions! I'm not that stubborn usually ;-)


react-native run-ios --simulator='' doesn't find simulator and instead uses default

Description
When upgrading to RN 70 our team noticed that the react-native run-ios --simulator='<any name> doesn't find simulator and instead uses the default simulator on your machine.
This seems to occur only with a combination of using RN 70 and also using the latest Xcode version (14.0.1)
Output
react-native run-ios --simulator='iPad mini (6th generation)'
info Found Xcode workspace "myproject.xcworkspace"
info Building (using "xcodebuild -workspace myproject.xcworkspace -configuration Debug -scheme myproject -destination id=ABB4816C-35D2-40C8-B328-DA2B0D447F34")
(node:13921) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 70. To debug build logs further, consider building your app with Xcode.app, by opening myproject.xcworkspace.
Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace myproject.xcworkspace -configuration Debug -scheme myproject -destination id=ABB4816C-35D2-40C8-B328-DA2B0D447F34

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

2022-10-04 14:54:56.582 xcodebuild[13931:1047299] Writing error result bundle to /var/folders/78/z97spd6n5dd3fvh7vcs1dlnh0000gn/T/ResultBundle_2022-04-10_14-54-0056.xcresult
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ id:ABB4816C-35D2-40C8-B328-DA2B0D447F34 }

	Available destinations for the "my project" scheme:
		{ platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00006001-0002302221F8801E }
		{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device }
		{ platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Any iOS Simulator Device }
		{ platform:iOS, id:00008027-0009259E0E87002E, name:Kody’s iPad Pro }
		{ platform:iOS, id:00008020-001E29823C45402E, name:UATH99FQ9Q5Q1GC }
		{ platform:iOS Simulator, id:41821153-E280-4F7D-B966-9D58E08C8032, OS:14.5, name:iPad (8th generation) }
		{ platform:iOS Simulator, id:8F99B1CA-F382-4BDB-88C8-CD080141F7EF, OS:15.5, name:iPad (9th generation) }
		{ platform:iOS Simulator, id:67D46FB5-F239-4C8B-9656-3DCB09490CEA, OS:16.0, name:iPad (9th generation) }
		{ platform:iOS Simulator, id:42725327-CF63-44A1-9055-6CAC13EEF401, OS:14.5, name:iPad Air (4th generation) }
		{ platform:iOS Simulator, id:BCC3C2B7-A428-4505-B3C3-F71B48395CCC, OS:15.5, name:iPad Air (5th generation) }
		{ platform:iOS Simulator, id:E967D281-CAB5-4D47-A909-6697780F0A66, OS:16.0, name:iPad Air (5th generation) }
		{ platform:iOS Simulator, id:DE802668-FA74-4E91-9847-ABCF26C299F9, OS:14.5, name:iPad Pro (9.7-inch) }
		{ platform:iOS Simulator, id:F3234D63-48E0-4608-BD1C-DA60A50DC48B, OS:15.5, name:iPad Pro (9.7-inch) }
		{ platform:iOS Simulator, id:1D925EB0-8984-4CB3-B54C-F6EBE1B895BB, OS:14.5, name:iPad Pro (11-inch) (3rd generation) }
		{ platform:iOS Simulator, id:3B6128BD-871C-4C11-A8DC-3AF02F4E3DE5, OS:15.5, name:iPad Pro (11-inch) (3rd generation) }
		{ platform:iOS Simulator, id:6CCE362B-5C1B-48C2-BF6C-EECB4AF323CC, OS:16.0, name:iPad Pro (11-inch) (3rd generation) }
		{ platform:iOS Simulator, id:533CF798-98FC-4ACB-9004-8BBACF83622A, OS:14.5, name:iPad Pro (12.9-inch) (5th generation) }
		{ platform:iOS Simulator, id:C6557531-48CC-4EE2-9760-9792E4D77EA0, OS:15.5, name:iPad Pro (12.9-inch) (5th generation) }
		{ platform:iOS Simulator, id:DC5D1F34-2499-4B12-8B98-7FD86AB027C1, OS:16.0, name:iPad Pro (12.9-inch) (5th generation) }
		{ platform:iOS Simulator, id:28D36DCF-0F95-4120-A3E0-79C117E9F559, OS:15.5, name:iPad mini (6th generation) }
		{ platform:iOS Simulator, id:26907D10-B1D8-407F-BF5F-C7DA4ED47126, OS:16.0, name:iPad mini (6th generation) }

Version
0.70.1
Output of npx react-native info
warn Package react-native-vector-icons contains invalid configuration: "dependency.assets" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
info Fetching system and libraries information...
System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Max
    Memory: 548.34 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.15.0/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.15.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK: Not Found
  IDEs:
    Android Studio: Chipmunk 2021.2.1 Patch 2 Chipmunk 2021.2.1 Patch 2
    Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
  Languages:
    Java: 17.0.2 - /Users/kodyfintak/.sdkman/candidates/java/current/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: 0.70.1 => 0.70.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
Use RN 0.70.1 and Xcode 14.0.1 and run the command react-native run-ios --simulator='iPad mini (6th generation)' on a new react-native project.
Snack, code example, screenshot, or link to a repository
bootstrap a RN project and it will have the issue

Hi @KodyFintak
Thanks for reporting this issue.
It seems like this is a duplicate of this: https://github.com/react-native-community/cli/issues/1707 which is already fixed.
As a rule of thumb, issues against the CLI should be opened here:
https://github.com/react-native-community/cli/issues


bug: Keyboard change from AZERTY to QWERTY after openning type="tel" input

Bug Report
Ionic version:
[x] 4.12.0
Current behavior:
On a Iphone Xr (iOS 13.1.2) default keyboard is in AZERTY mode.
But after opening an ion-input "type=tel" the keyboard is changed to QWERTY.
Here you can see a gif that explains the problem.

Expected behavior:
The keyboard doesn't change from AZERTY to QWERTY when we use an ion input with type="tel".
Steps to reproduce:
click a text input, the keyboard is in AZERTY. click on a type=tel input, click on a text input, the keyboard changed to QWERTY.
Related code:
<ion-item>
    <ion-label>FirstName</ion-label>
    <ion-input type="text"></ion-input>
</ion-item>

<ion-item>
    <ion-label>Phone</ion-label>
    <ion-input type="tel" maxlength="10"></ion-input>
</ion-item>

Thanks for the issue. Do you have multiple keyboards setup on your device? You can find this by going to the Settings app > General > Keyboard > Keyboards. The last screen you land on should show you all keyboards configured on your device as well as the button layout.

I have one language set up : Français(France) which contains 5 keyboards :

AZERTY accentué
AZERTY
QWERTY accentué
QWERTY
QWERTZ

Thanks for the follow up. I am unable to reproduce the behavior you are describing. Can you provide a repo with the code required to reproduce this issue?

We finally found out,
we've added defaultLocale="fr" in the config.xml.
It seems that the App is launched with the selected keyboard in  Settings app > General > Keyboard > Keyboards (AZERTY in our case), but when the keyboard change (to be a type tel in our example), the keyboard configuration follow app language (which was probably english and QWERTY in our app)

Glad to hear you were able to figure it out. I am going to close this as the original issue appears to be resolved. Thanks!

Hi,
Unfortunetly I'll reopen it as my issue is still present.
But, to reproduce it, we added an other keyboard into our app. (Anglais E-U).
When we enter a type=tel input, our app change from AZERTY french keyboard, to QWERTY US Keyboard.
The addition of defaultLocale variable did not repair anything, but in our test we certainly deleted a keyboard which repaired this issue by prevent app from changing to an other keyboard.


GPL-nnn As developers we need to modify the creation of samples to reflect the simplified scenario for creating ONT samples

User story
As developers we need to modify the creation of samples to reflect the simplified scenario for creating ONT samples
Who the primary contacts are for this story
Steve / Harry
Acceptance criteria
To be considered successful the solution must allow:

A plate will contain 96 wells
Each well will contain a single sample
Each sample must be pre-tagged with a pre existing PCR tag
A sample will only be sequenced once

Additional context
Add any other context or screenshots about the feature request here.

In order to support this in the most straightforward way possible, we will make the following changes:

remove sample request relationship
In the request factory validate that samples have a valid tag, and assign to them this tag
In the well factory ensure that each well only has a single sample (retaining flexibility to allow multiple samples in a single well)

Tag validation (that all tags are unique) will now be done on library creation.


functional-tester: skip for compact double-send

Fix https://github.com/coreos/etcd/issues/4907.
When compactKV request is halted before final acknowledgement,
it used to just continue on the next endpoint. But there could be
a case than compactKV is requested twice, and the first one is already
replicated and applied by the time the second request was to be
applied (returning compact revision error). This skips the case
by parsing the error message.

/cc @heyitsanthony @xiang90 So I think this fixes the compaction issue, but I just got another hash difference error running this branch.
2016-03-30 20:38:44.612767 I | etcd-tester: [round#5 case#0] checking current storage hashes failed (map[<IP_ADDRESS>:2379:418588413 <IP_ADDRESS>:2379:1358886971 <IP_ADDRESS>:2379:1913554223])

@heyitsanthony PTAL. Thanks!

lgtm

thanks. merging in greens.


Minimap fixes & bounding boxes

Issues with minimap:

Games Showcase West/East are reversed
A bunch of the bounding boxes are overlapping/off, making it really confusing to navigate

We should really get this fixed before conference start, it's making navigating super annoying. Also if possible it might be helpful to have the bounding boxes shaded differently so the clickable area is obvious and you don't have to watch your cursor.

Issue is unrelated to the refresh issue - did you mean #291 ?

D'oh, sorry, yep, saw "minimap fixes" and "high priority" and jumped to conclusions 😂

Ok, we've investigated and figure the bounding boxes are browser compatibility issues. The solution to that is to just make it bring up the full map when you click the minimap.


Raidboss module error

Hi!
The raidboss module suddenly doesn't work for me anymore. In ACT it says "Uncaught TypeError: Cannot read property 'SetDataFiles' of undefined (Source: file:///C:/Program%20Files%20(x86)/Advanced%20Combat%20Tracker/OverlayPlugin/cactbot/ui/raidboss/raidboss.html, Line: 47)".
I didn't use ACT for a few days but yesterday again. There were no updates or other changes during that time. Then I downloaded the latest Cactbot update thinking it would help, but I still get the same error. I removed the overlay plugin and added it again but this didn't work either.
I'm sorry, I don't know very much about programming and stuff, so I don't know how to solve this problem myself at all.
Thank you for helping!

Sounds like your forgot to unlock what you downloaded.

I don't think this is an unblocking issue.
Does selecting the raidboss overlay in ACT and hitting the "Reload Overlay" button make the problem go away, or does that happen 100% of the time?
Out of curiosity, what do you have set in your Custom User Config Directory? If you clear that, does it work properly?

Were you able to sort out what was going on here?

I'm going to close this old bug for now.  If this is still happening, please leave another comment.


[Feature Request] Remote API

It would be nice to have an API to extend the matter bridge without having to write a plugin in javascript. Maybe because bindings to whatever you want to add only exist in other languages or (in my case) for people who do not know Javascript.
Similar to the home assistant matter server there could be a JSON websocket API to add/remove devices, change their state and receive notifications from a matter controller. Or an MQTT plugin independent of zigbee2mqtt to add external devices.

I'm not sure if it makes sense to enhance matterbridge for something like this. I would more see this (and already planned mid-term) as a feature of matter.js.

It would be nice to have an API to extend the matter bridge without having to write a plugin in javascript. Maybe because bindings to whatever you want to add only exist in other languages or (in my case) for people who do not know Javascript.
Similar to the home assistant matter server there could be a JSON websocket API to add/remove devices, change their state and receive notifications from a matter controller. Or an MQTT plugin independent of zigbee2mqtt to add external devices.

Hi,
it would be interesting.
A friend already asked for a similar solution.
Right now is not planned but a pure MQTT plugin with simple API is certainly a manageable thing.
It would allow to connect from different systems and languages.

Sounds good. There could be a simple matterbridge/device/add and matterbridge/device/remove interface as well as one topic to report the current status and to set values (similar to zigbee2mqtt). The content could be a simple json with the same attribute names and values as the matter standard. If you find the time, I can be the beta tester :)

You know what?
Is interesting cause you are asking me the same features as my friend.


Missing frees in error return paths in MP4 parser code

          Shouldn't fa be freed here?

Originally posted by @SanaAnjaneyulu in https://github.com/ittiam-systems/libmpegh/pull/47#discussion_r1121561280

Free-ing of all allocated memories, associated with the node, happens during the file wrapper closing process.


chore: add conformance test coverage for typed function signature

Conformance tests passing.

nit(unrelated to your change): Can you update https://github.com/GoogleCloudPlatform/functions-framework-python/pull/254/files#diff-e5ed24bc2f5084a1664419e35473c15466f87e7552ef1fad4d13cdde0eaed400R2 to only do push when it is on branch master? It seems like it is being duplicated during pull requests.

@kenneth-rosario done, added a branch selector to the push trigger for our ci runs.


argo-server can not work with Kubernetes proxy api

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[X] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
I want to connect argo API Server to manage workflow, but I do not like to expose public endpoint in cluster as it required to order an additional LoadBalancer.
One option is using Kubernetes proxy api to proxy request to Argo Server, which can leverage existing Kubernetes API Server LB endpoint.

Install argo 3.4.0, I can not install latest 3.4.1 as anther error.
k get pod -n argo NAME                                   READY   STATUS    RESTARTS   AGE argo-server-59f9dd46fb-99x22           1/1     Running   0          30s workflow-controller-69b9cc5b5f-5hpwt   1/1     Running   0          29s
setup Kubernetes API credential and endpiont
 cat  $KUBECONFIG |grep client-certificate-data | awk -F ' ' '{print $2}' |base64 -d > ./client-cert.pem cat  $KUBECONFIG |grep client-key-data | awk -F ' ' '{print $2}' |base64 -d > ./client-key.pem APISERVER=cat  $KUBECONFIG |grep server | awk -F ' ' '{print $2}'
`
curl kube proxy api to proxy request to argo server, but 503 returned.
curl --cert ./client-cert.pem --key ./client-key.pem -k  "$APISERVER/api/v1/namespaces/argo/pods/argo-server-59f9dd46fb-99x22:2746/proxy/api/v1/archived-workflows" { "kind": "Status", "apiVersion": "v1", "metadata": {}, "status": "Failure", "message": "error trying to reach service: EOF", "reason": "ServiceUnavailable", "code": 503 }
Curl workflow-controller healthz success with same way
curl --cert ./client-cert.pem --key ./client-key.pem -k  "$APISERVER/api/v1/namespaces/argo/pods/workflow-controller-69b9cc5b5f-5hpwt:6060/proxy/healthz" ok

Please help to take a look. Thank you.
BTW, curl -k https://localhost:2746/api/v1/archived-workflows is good, when "kubectl -n argo port-forward deployment/argo-server 2746:2746". But port-forward is not option for me, as I have to write code to call api directly without setup a local proxy by port-forward.
Version
3.4.0
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
It is not workflow problem.

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

I think it is an enhancement.  can you make sure Argoserver is ready?

yes, Argo Server is ready.
I can do "curl https://localhost:2746/api/v1/workflows/default" successfully, when running "kubectl -n argo port-forward service/argo-server 2746:2746".


Port #14304 to the release-1.2 branch

See the following issue for more information.
https://github.com/istio/istio/issues/14983#issuecomment-511534980
/cc @rshriram

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: venilnoronha
To complete the pull request process, please assign rshriram
You can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test


incompatible python-requires between pypi and this repo

https://github.com/Python-SIP/sip -- the pyproject.toml states >=3.9 while pypi seems to indicate >=3.8 (but installing indicates >=3.9): https://pypi.org/project/PyQt5-sip/. Is there a way to clarify or harmonize this to remove the confusion?

See #56


Proguard Config

Is it possible to get the proguard config ?

Shouldn't need one. Are you noticing any issues?


Add support of pip

A possible approach would be extracting necessary code from
https://github.com/PyO3/setuptools-rust
without bring it as build requirements(It's hard to add new package setuptools-rust to RHEL).

https://pypi.org/project/nispor/


Cheerio update

I was using Cheerio with TypeScript and realized some functions were missing.
So I updated the tests to be pretty similar to the Cheerio docs and fixed the definitions accordingly, while checking that the generated cheerio-tests.js worked with the current library.

cheerio/cheerio.d.ts
to authors(@blittle @wmaurer). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

Hi @vvakame @wmaurer @blittle, don't wanna impose, but any update on this? :)

@Almouro the only comment I have is looking at the quantity of changes it seems as though the tests are a little lite.

Hey @blittle, thanks for commenting! :)
I added 230 lines of tests and added tests for a lot of functions I did not add.
So IMHO, the quality of tests has improved.
Do you have any suggestions on how I could improve it even more? :)

@Almouro fair enough. A casual look without doing an exhaustive check things look good :)

@blittle thanks!
@Almouro thanks mate!


remove passwd info from log

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6b40d9f) 31.79% compared to head (2333b7b) 31.79%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage     31.79%   31.79%
  Complexity       74       74
=========================================
  Files            31       31
  Lines          1494     1494
  Branches        226      226
=========================================
  Hits            475      475
  Misses          944      944
  Partials         75       75

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support CPU Shares as well as CFS

It turns out that, due to this Linux kernel bug, CFS CPU limits can cause weird behavior in some processes. Notably, we see this on Erlang/BEAM VMs running under almost no load. While CPU Shares are a MUCH cruder mechanism and not as fit for purpose they are perhaps currently a better choice in some scenarios. This patch allows the executor to support that mode via an env var setting.

:shipit: That's a really lame bug in the kernel...

Yeah @mihaitodor it's super bad. Seems not to affect the Go processes we have, but the Erlang BEAM is getting hammered :(


Sox recording resulting in wav file with text

macOS Sierra
Version of sox: SoX v
Node: v8.5.0
sw_vers -productVersion: 10.12.5
var record = require('node-record-lpcm16');
var fs = require('fs');
var file = fs.createWriteStream('test.wav', { encoding: 'binary' })
record.start({
    threshold: 0.5,
    recordProgram: 'sox',
}).pipe(file);

Results in the file test.wav that contains:
sox:      SoX v

Usage summary: [gopts] [[fopts] infile]... [fopts] outfile [effect [effopt]]...

SPECIAL FILENAMES (infile, outfile):
-                        Pipe/redirect input/output (stdin/stdout); may need -t
-d, --default-device     Use the default audio device (where available)
-n, --null               Use the `null' file handler; e.g. with synth effect
-p, --sox-pipe           Alias for `-t sox -'

SPECIAL FILENAMES (infile only):
"|program [options] ..." Pipe input from external program (where supported)
http://server/file       Use the given URL as input file (where supported)

GLOBAL OPTIONS (gopts) (can be specified at any point before the first effect):
--buffer BYTES           Set the size of all processing buffers (default 8192)
--clobber                Don't prompt to overwrite output file (default)
--combine concatenate    Concatenate all input files (default for sox, rec)
--combine sequence       Sequence all input files (default for play)
-D, --no-dither          Don't dither automatically
--dft-min NUM            Minimum size (log2) for DFT processing (default 10)
--effects-file FILENAME  File containing effects and options
-G, --guard              Use temporary files to guard against clipping
-h, --help               Display version number and usage information
--help-effect NAME       Show usage of effect NAME, or NAME=all for all
--help-format NAME       Show info on format NAME, or NAME=all for all
--i, --info              Behave as soxi(1)
--input-buffer BYTES     Override the input buffer size (default: as --buffer)
--no-clobber             Prompt to overwrite output file
-m, --combine mix        Mix multiple input files (instead of concatenating)
--combine mix-power      Mix to equal power (instead of concatenating)
-M, --combine merge      Merge multiple input files (instead of concatenating)
--norm                   Guard (see --guard) & normalise
--play-rate-arg ARG      Default `rate' argument for auto-resample with `play'
--plot gnuplot|octave    Generate script to plot response of filter effect
-q, --no-show-progress   Run in quiet mode; opposite of -S
--replay-gain track|album|off  Default: off (sox, rec), track (play)
-R                       Use default random numbers (same on each run of SoX)
-S, --show-progress      Display progress while processing audio data
--single-threaded        Disable parallel effects channels processing
--temp DIRECTORY         Specify the directory to use for temporary files
-T, --combine multiply   Multiply samples of corresponding channels from all
                         input files (instead of concatenating)
--version                Display version number of SoX and exit
-V[LEVEL]                Increment or set verbosity level (default 2); levels:
                           1: failure messages
                           2: warnings
                           3: details of processing
                           4-6: increasing levels of debug messages
FORMAT OPTIONS (fopts):
Input file format options need only be supplied for files that are headerless.
Output files will have the same format as the input file where possible and not
overridden by any of various means including providing output format options.

-v|--volume FACTOR       Input file volume adjustment factor (real number)
--ignore-length          Ignore input file length given in header; read to EOF
-t|--type FILETYPE       File type of audio
-e|--encoding ENCODING   Set encoding (ENCODING may be one of signed-integer,
                         unsigned-integer, floating-point, mu-law, a-law,
                         ima-adpcm, ms-adpcm, gsm-full-rate)
-b|--bits BITS           Encoded sample size in bits
-N|--reverse-nibbles     Encoded nibble-order
-X|--reverse-bits        Encoded bit-order
--endian little|big|swap Encoded byte-order; swap means opposite to default
-L/-B/-x                 Short options for the above
-c|--channels CHANNELS   Number of channels of audio data; e.g. 2 = stereo
-r|--rate RATE           Sample rate of audio
-C|--compression FACTOR  Compression factor for output format
--add-comment TEXT       Append output file comment
--comment TEXT           Specify comment text for the output file
--comment-file FILENAME  File containing comment text for the output file
--no-glob                Don't `glob' wildcard match the following filename

AUDIO FILE FORMATS: 8svx aif aifc aiff aiffc al amb au avr cdda cdr cvs cvsd cvu dat dvms f32 f4 f64 f8 fssd gsm gsrt hcom htk ima ircam la lpc lpc10 lu maud mp2 mp3 nist prc raw s1 s16 s2 s24 s3 s32 s4 s8 sb sf sl sln smp snd sndr sndt sou sox sph sw txw u1 u16 u2 u24 u3 u32 u4 u8 ub ul uw vms voc vox wav wavpcm wve xa
PLAYLIST FORMATS: m3u pls
AUDIO DEVICE DRIVERS: coreaudio

EFFECTS: allpass band bandpass bandreject bass bend biquad chorus channels compand contrast dcshift deemph delay dither divide+ downsample earwax echo echos equalizer fade fir firfit+ flanger gain highpass hilbert input# loudness lowpass mcompand noiseprof noisered norm oops output# overdrive pad phaser pitch rate remix repeat reverb reverse riaa silence sinc spectrogram speed splice stat stats stretch swap synth tempo treble tremolo trim upsample vad vol
  * Deprecated effect    + Experimental effect    # LibSoX-only effect
EFFECT OPTIONS (effopts): effect dependent; see --help-effect

see my comment in https://github.com/gillesdemey/node-record-lpcm16/issues/8#issuecomment-332175548

Can you verify if this bug still occurs with v0.3.1? :)


feat(helm): PDB is configurable when registry is in HA mode

:tada: This PR is included in version 1.2.0-beta.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


(GH-3349) Fix disable content of ToggleButton & Button when using circle style

Describe the changes you have made to improve this project

Added setter for the Foreground property to MahApps.Styles.ToggleButton.Circle when IsEnabled=False
Added setter for the Foreground property to MahApps.Styles.Button.Circle when IsEnabled=False
Updated demo with enabled/disabled version of MahApps.Styles.Button.Circle (current demo only display a custom derived style for Accent color)

Closed Issues
Closes #3349

Hi @mgnslndh for other controls MahApps uses an opaque overlay over the button /control.  I don't have a PC right now but I think I saw it at the
SquareButton. What do you think? I will show you the file as soon as my Internet is back. :smile:
Happy coding
Tim

@timunie thanks for the feedback!
This was just a quick fix using the same solution as found on other button styles:
https://github.com/MahApps/MahApps.Metro/blob/e59402cc054ab793d879417c9bdba1cc93ce08a7/src/MahApps.Metro/Styles/Controls.Buttons.xaml#L63-L65
https://github.com/MahApps/MahApps.Metro/blob/e59402cc054ab793d879417c9bdba1cc93ce08a7/src/MahApps.Metro/Styles/Controls.Buttons.xaml#L141-L143
https://github.com/MahApps/MahApps.Metro/blob/e59402cc054ab793d879417c9bdba1cc93ce08a7/src/MahApps.Metro/Styles/Controls.Buttons.xaml#L249-L251
I'm not aware of an easy way of doing an overlay of an elliptical control with transparent background.
Using an overlay like for the default button style probably works well because it is rectangular and the whole content area is covered by the disabled state.
https://github.com/MahApps/MahApps.Metro/blob/e59402cc054ab793d879417c9bdba1cc93ce08a7/src/MahApps.Metro/Styles/Controls.Buttons.xaml#L412-L417
Not sure that is how the circle variant is supposed to look. Disabled state covering the whole circle. This is the expected result from the original issue:

Do you have any suggestions?

@mgnslndh your changes have been merged, thanks for your contribution 👍
I added 2 more samples to the demo which shows the workaround for disabled Buttons with custom Foreground (and respect the changes from GH-3121, GH-3101).
            <StackPanel Margin="{StaticResource ControlMargin}"
                        HorizontalAlignment="Center"
                        Orientation="Horizontal">
                <ToggleButton Width="48"
                              Height="48"
                              Margin="4"
                              Foreground="{DynamicResource MahApps.Brushes.Accent}"
                              Style="{DynamicResource MahApps.Styles.ToggleButton.Circle}">
                    <ToggleButton.ContentTemplate>
                        <DataTemplate>
                            <iconPacks:PackIconModern Width="20"
                                                      Height="20"
                                                      Kind="City" />
                        </DataTemplate>
                    </ToggleButton.ContentTemplate>
                </ToggleButton>
                <ToggleButton Width="48"
                              Height="48"
                              Margin="4"
                              Foreground="{DynamicResource MahApps.Brushes.Accent}"
                              IsEnabled="False"
                              Style="{DynamicResource MahApps.Styles.ToggleButton.Circle}">
                    <ToggleButton.ContentTemplate>
                        <DataTemplate>
                            <iconPacks:PackIconModern Width="20"
                                                      Height="20"
                                                      Kind="City" />
                        </DataTemplate>
                    </ToggleButton.ContentTemplate>
                </ToggleButton>
            </StackPanel>

            <StackPanel Margin="{StaticResource ControlMargin}"
                        HorizontalAlignment="Center"
                        Orientation="Horizontal">
                <Button Width="48"
                        Height="48"
                        Margin="4"
                        Foreground="{DynamicResource MahApps.Brushes.Accent}"
                        Style="{StaticResource MahApps.Styles.Button.Circle}">
                    <Button.ContentTemplate>
                        <DataTemplate>
                            <iconPacks:PackIconModern Width="20"
                                                      Height="20"
                                                      Kind="City" />
                        </DataTemplate>
                    </Button.ContentTemplate>
                </Button>
                <Button Width="48"
                        Height="48"
                        Margin="4"
                        Foreground="{DynamicResource MahApps.Brushes.Accent}"
                        IsEnabled="False"
                        Style="{StaticResource MahApps.Styles.Button.Circle}">
                    <Button.ContentTemplate>
                        <DataTemplate>
                            <iconPacks:PackIconModern Width="20"
                                                      Height="20"
                                                      Kind="City" />
                        </DataTemplate>
                    </Button.ContentTemplate>
                </Button>
            </StackPanel>

Nice @punker76! Moving to 2.0.0 release one issue at a time :)

Hello @mgnslndh ,
just for information you can find my first idea below:

<Ellipse x:Name="PART_Overlay"
         Stroke="{DynamicResource MahApps.Brushes.White}"
         Fill="{DynamicResource MahApps.Brushes.White}"
         Opacity="0.8"
         Visibility="Collapsed"
         StrokeThickness="{Binding RelativeSource={x:Static RelativeSource.TemplatedParent}, Path=BorderThickness, Converter={StaticResource BorderThicknessToStrokeThicknessConverter}}" />

[...]

<Trigger Property="IsEnabled" Value="False">
    <Setter TargetName="PART_Overlay" Property="Visibility" Value="Visible" />
</Trigger>

I have to agree that your and @punker76 's solution looks much nicer! Thank you :+1:
Happy coding
Tim


[SPARK-18292][SQL] LogicalPlanToSQLSuite should not use resource dependent path for golden file generation

What changes were proposed in this pull request?
LogicalPlanToSQLSuite uses the following command to update the existing answer files.
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite"

However, after introducing getTestResourcePath, it fails to update the previous golden answer files in the predefined directory. This issue aims to fix that.
How was this patch tested?
It's a testsuite update. Manual.

Hi, @gatorsmile .
I create a PR for LogicalPlanToSQLSuite part from #15546 .

Test build #68233 has finished for PR 15789 at commit bd7258d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68233/
Test FAILed.

Test build #68232 has started for PR 15789 at commit 725cd45.

Oh, you mean the the following. I'll fix this PR again. Sorry, @gatorsmile .
  private val baseResourcePath = {
    // If regenerateGoldenFiles is true, we must be running this in SBT and we use hard-coded
    // relative path. Otherwise, we use classloader's getResource to find the location.
    if (regenerateGoldenFiles) {
      java.nio.file.Paths.get("src", "test", "resources", "sql-tests").toFile
    } else {
      val res = getClass.getClassLoader.getResource("sql-tests")
      new File(res.getFile)
    }
  }

Retest this please

Retest this please

It's fixed like SQLQueryTestSuite.

Test build #68233 has started for PR 15789 at commit bd7258d.

Retest this please.

Test build #68232 has finished for PR 15789 at commit 725cd45.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68232/
Test FAILed.

Merged build finished. Test FAILed.

There occurs four randomized aggregation tests failures due to OutOfMemoryError. But, it seems to be irrelevant. I'll wait the next test running currently.
[info] - randomized aggregation test - [typed, with partial + safe] - with grouping keys - with non-empty input *** FAILED *** (1 second, 512 milliseconds)
[info]   org.apache.spark.SparkException: Job aborted due to stage failure: Task 4 in stage 1897.0 failed 1 times, most recent failure: Lost task 4.0 in stage 1897.0 (TID 6408, localhost, executor driver): java.lang.OutOfMemoryError: Java heap space

Retest this please

Test build #68237 has started for PR 15789 at commit bd7258d.

Test build #68237 has finished for PR 15789 at commit bd7258d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68237/
Test PASSed.

LGTM except a comment.

Thank you, @srowen and @gatorsmile .
I replied those two comments.
For java.nio.file.Paths.get("src", "test", "resources", "sqlgen").toFile.getCanonicalPath, I was a little bit confused, so I didn't update so far.
Could you give me advice again how to finalize that?

Thank you, @srowen and @gatorsmile .
I replied the comment.
For java.nio.file.Paths.get("src", "test", "resources", "sqlgen").toFile.getCanonicalPath, could you give me advice again if I need to change that again?

Thank you, @srowen !

Can you explain what the actual issue is? I read the description and still have no idea.

Hi, @rxin .
Yep. The actual issue is the current code generates the new golden files in the following folder. So, we cannot identify which file is changed and cannot commit the newly generated files easily.
.../spark/sql/hive/target/scala-2.11/test-classes/sqlgen

When we added this module initially, we faced the exactly same issue and decided to use the absolute path and to assume the following command in the source tree root.
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite"

I'll merge if there are no further comments. To restate -- basically the test helper function returns a path that is perfectly fine for reading test data, and is flexible because it doesn't depend on what the current working dir is. However it won't work as a location to write to, which is only rarely ever needed like in cases like this.

Thank you, @srowen !

Merged to master/2.1

Thank you for review and merging, @srowen , @gatorsmile , and @rxin .


Performance issues

Unfortunately my igpu really struggles with blur and certain effects in WPF. My igpu is an intel HD4600.
I don't know what could be done about this, maybe allow to reduce or disable the blur or the more complicated option to implement a faster blur method.
If you don't care about being able to see certain details of the game background image and just want the colors, I use a custom background blur solution made by Fuene in a theme that doesn't cause any performance impact and is pretty fast: https://github.com/darklinkpower/Helium/blob/master/source/Views/DetailsViewGameOverview.xaml#L18-L82
It looks like this but could be tuned up to produce different results by changing the opacity or other properties

This is how it looks by changing the border opacity to 1.0

fixed via 1c798d7f3c42cd64414474fbb4791083e2cbc709


Add sql top queries spec

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Please don't merge until I get signoff from SQL DB query store team. Thx

The spec will be added to "schema-2014-04" tag when #1474 is merged, and will be added to "package-2015-05-preview" concurrently with .net sdk code and tests are submitted for review.

@jaredmoo thanks, added one more question inline. Waiting on review from @ravbhatnagar since it's a new file.
Please let us know when you get signoff from SQL DB query store team

@veronicagg no, schema-2014-04 is what I'm using for conveniently generating RP schema and running --azure-validator until https://github.com/Azure/autorest/issues/2470 is fixed.
@ravbhatnagar this is all good feedback, but it's an old API that I can't change. Just adding missing swagger.

@jaredmoo - ok :). One thing I would still like to point out - If a customer has defined a custom role where in NotActions he has explicitly added /servers/databases/topqueries/read, he will be able to still see all the top queries since you dont have ID in the response payload. Thus potentially breaking RBAC? Please ACK if you are fine with this.

ACK - this API is a little weird by modern ARM standards, if/when we make a new api-version of this API it will be differently designed.

@jaredmoo ok, let me know when you get sign off from SQL DB query store team, so I can approve & merge. thanks!

@jaredmoo do you want to update your example based on feedback from @sasapopo ?

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-python/pull/1342

 https://github.com/Azure/azure-sdk-for-ruby/pull/874


fix issue 171 make app usage logging more robust

Found an opportunity to wrap the mac app logger to prevent crashes from taking down the timer

If it helps, this just wraps the process exec for Applescript in a try/catch to prevent killing the Timer.


How to set authentication hubot?

Hello world,
I have a problem. I have two hubots: "devbot" and "adminbot". They connected to hipchat successfully, I deployed them to heroku. "adminbot" is host of room and "devbot" is member.
Now, I want to set role for this hubots, I used "hubot-auth"  and then I run hubot, I got a error message:
WARNING The HUBOT_AUTH_ADMIN environment variable not set
I also typed: heroku config and this is result:
HEROKU_URL:                 http://renewdevbot.herokuapp.com
HUBOT_ADAPTER_NAME:         hipchat
HUBOT_ADAPTER_USER:         273946_herokuhubot
HUBOT_AUTH_ADMIN<EMAIL_ADDRESS>HUBOT_HEROKU_KEEPALIVE_URL: https://renewdevbot.herokuapp.com/
HUBOT_HIPCHAT_JID<EMAIL_ADDRESS>HUBOT_HIPCHAT_PASSWORD:     *********
HUBOT_HIPCHAT_ROOMS:        273946_herokuhubot
HUBOT_XMPP_ROOMS:           273946_herokuhubot
HUBOT_AUTH_ADMIN is set, but still show warning?
And in Hubot, I typed:
Hubot> hubot who has admin role
And this is result:
Shell: Sorry, only admins can assign roles.
Hubot> Shell: There are no people that have the 'admin' role.
Please help me, thank you so much!

Try setting HUBOT_AUTH_ADMIN to "1746790"

Feel free to re-open if the proposed fix did not solve your issue.

I  am using hipchat as a hubot adapter. How can I set roles on hipchat UI? Thanks!


Better error handling for mis-entering api key

If you enter an incorrect key we don’t handle the error and let you retry. Needs better error handling instead of just throwing an error as reported by @gregcline

Download Exercism Manager
Run ExercismManager welcome.
Right click and select Fetch Exercise...
Enter invalid token when prompted for an API token (I put hello-world)
Enter exercise name (hello-world)

Results in KeyNotFound: key 'solution' not found in Dictionary

@gregcline Would you be interested in having another go?

Yeah I'm actually in the midst right now.

Looks like this issue is fixed. Closing.


push to pypi

The current github version is so much better than what's on PyPI.
Really should be pushed soon.

0.1.9 has been uploaded to pypi


Help please

getting this- i have done everything from the fixes but keep getting this even under a fresh install
Exception has occurred: PydanticUserError
If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator.
For further information visit https://errors.pydantic.dev/2.5/u/root-validator-pre-skip
File "C:\Users***\Desktop\Babagaboosh-main\eleven_labs.py", line 1, in
from elevenlabs import generate, stream, set_api_key, voices, play, save
File "C:\Users*****\Desktop\Babagaboosh-main\chatgpt_character.py", line 6, in
from eleven_labs import ElevenLabsManager
pydantic.errors.PydanticUserError: If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator.
For further information visit https://errors.pydantic.dev/2.5/u/root-validator-pre-skip

Install pydantic v1 not v2, should be fixed by #40 which just got merged.

If it's fixed please close, I think odds are very slim that someone will actually look at these and close them for you.


Refactor - Multiple Compression/Encoding Methods

Refactored CompressEncoder to support multiple methods in a single middleware, with backward compact

Single Middleware for compression, that out of the box configures itself based on what PHP extensions are available (zstd, or brotli)
Orderable based on compression preference if required
Individual compression methods can have their compression level adjusted where required.

To do:

[ ] Update Documentation
[ ] Setup testing with zstd and brotli extensions loaded
[ ] Write an upgrade guide going from version 2.x to 3.x
[ ] Fix/workaround PHP Stan warnings about brotli_compress
[ ] Add deprecation PHPDOC to GzipEncoder and Deflate Encoder classes

@oscarotero Could you let me know if this has the possibility of being merged (open to suggestions on structural changes).

Hi, @cseufert
Thanks, I really like your proposal :).

Due this is a breaking change, that will release a major version, maybe we don't need the shim to the old classes. The documentation from 2.x to 3.x is enough.
I see that you missed the Deflate class in the allAvailableCompressor: https://github.com/moddengine/encoder/blob/cs-multi-compressor/src/CompressEncoder.php#L110

Let me know when you have finished with this changes and I'll merge it.


Add support for 0.9.x

As a Developer
I want to install Kong 0.9.x
So that I can build awesome API gateway
NOTES: The config format changed from YAML to INI

Closed by #4


keyboard appears and pushes the bottom sheet to its top

MDCBottomSheetController with a contentViewController that contains an UITextField. When the textfield becomes first responder, the keyboard appears and pushes the bottom sheet to its top.

The expected behaviour is that the UIKeyboard slides over the BottomSheet and not push it up.

this issue still pending. I guess it should be raised on https://github.com/material-components/material-components-ios/issues


[Fix] Update credo and add note on Elixir versions compatibility

Dependencies changes

Update credo (and bamboo because of a shared dependency mime) because it was raising an error locally with the locked version

CI changes

Truncate supported elixir version to the currently supported versions (and 1.12)
Lint only the last version on the CI pipeline
Remove e2e tests from code checks step

Could we also update the other devs dependencies too? 🙏 Like bypass, dialyxir and ex_docs?
Also, are the tests failing for older versions of Elixir? I would prefer not to drop support on legacy versions of Elixir unless is really necessary

It seems only 1.9 version is failing on the CI so we could remove only that from the matrix
Also, I agree with removing the e2e during the check step but we still want to run this test in the latest version


Render all the colors

👷 Deploy Preview for distracted-bartik-49db62 processing.
🔨 Explore the source changes: dab2a82b21fe36fa2e2054bb7df1de856451721e
🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-bartik-49db62/deploys/622a65bf888c60000909b555

👷 Deploy Preview for bob-ross-colors processing.
🔨 Explore the source changes: dab2a82b21fe36fa2e2054bb7df1de856451721e
🔍 Inspect the deploy log: https://app.netlify.com/sites/bob-ross-colors/deploys/622a65bfe445cb0008bfe7e4


python3Packages.textual: init at 0.1.15

Motivation for this change
Add https://github.com/Textualize/textual
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
python -m textual.app
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 162320 run on x86_64-linux 1

2 packages built:

python310Packages.textual
python39Packages.textual


Add Code Conventions

Add a guide on code conventions for this project. This should only apply to the project itself and not the code content being displayed (which should follow their language specific conventions).

Will close, as this should be part of the CONTRIBUTION file.


Interaction constraints

Implement interaction constraints feature requested in #2884.

@btrotta is this ready to review?

@guolinke  Yes

@StrikerRUS Thanks, have updated according to your suggestions.

@btrotta: Simply fantastic, thank you so much for digging into this and the great implementation.
I made some tests in R and all make perfect sense:
library(lightgbm)
library(flashlight)

n <- 1000
m <- 4

set.seed(1)
X <- matrix(rnorm(n * m), ncol = m, dimnames = list(NULL, paste0("X", 1:m)))
cols <- colnames(X)
y <- X[, 1] * X[, 2] * X[, 3] + X[, 4] + rnorm(n)

train <- lgb.Dataset(X, label = y)

Example 1: Additive model with depth > 1
params <- list(
  learning_rate = 0.1,
  num_leaves = 15,
  objective = "regression",
  interaction_constraints = list(1, 2, 3, 4)
)

fit <- lgb.train(params, train, nrounds = 50)

fl <- flashlight(model = fit, data = data.frame(y, X), y = "y", label = "lgb",
                 predict_fun = function(m, X) predict(m, data.matrix(X[, cols])))
plot(imp <- light_interaction(fl, v = cols, pairwise = TRUE))

Okay -> pairwise H-statistic values are all 0. H measures the interaction strength in a model agnostic way based on bivariate partial dependence curves.
Some additive, some pairwise
params <- list(
  learning_rate = 0.1,
  num_leaves = 15,
  objective = "regression",
  interaction_constraints = list(c(1, 2), 3, 4)
)

fit <- lgb.train(params, train, nrounds = 50)

fl <- flashlight(model = fit, data = data.frame(y, X), y = "y", label = "lgb",
                 predict_fun = function(m, X) predict(m, data.matrix(X[, cols])))
plot(imp <- light_interaction(fl, v = cols, pairwise = TRUE))

Okay -> there is only one interacting variable pair.
Overlapping sets

params <- list(
  learning_rate = 0.1,
  num_leaves = 15,
  objective = "regression",
  interaction_constraints = list(c(1, 2), c(1, 3))
)

fit <- lgb.train(params, train, nrounds = 50)

fl <- flashlight(model = fit, data = data.frame(y, X), y = "y", label = "lgb",
                 predict_fun = function(m, X) predict(m, data.matrix(X[, cols])))
plot(imp <- light_interaction(fl, v = cols, pairwise = TRUE))

-> Okay as well! X2 and X3 are not interacting, as intended.
And note to myself: Unlisted variables are modelled without interaction.

@mayer79 Thanks for doing those additional tests, good to know it's working as expected!


Build a event scrapping API from BookMyShow based upon choice. See comments of this thread for details

Check ReadME for more. Option #2

List of APIs for respective topics are:

BookMyShow Tech events
BookMyShow Art event
BookMyShow Tavel event

Follow the format in the repo
Make a different folder if you find an existing API in one language and you want to code the same in a different language.
you can write code in PHP, nodejs or python.


Lots of missing fav icons that need changing:

[ ] Moderation Panels

@SYNTAG It looks like there was a lot of older fa stuff since moving away from the paid version, i'm not sure directly how it was build or made but could this be something you could resolve?  since its broken all the icons.

@MambaDev I can't seem to replicate the fonts not showing up. I thought maybe it was because my computer had the fonts installed locally. But I tried logging on to several computers/phones that never went to DevWars before and was able to see the icons.

Its not related to fonts but fontAwesome icons.

You can see it here with the icons next to the headers of the table.

@SYNTAG its also on the core site.

@MambaDev Yes, I was referring to FontAwesome icons as a font. Strange how I am able to see the font on multiple devices. I'll try to look into it again and circle back on this one.

@SYNTAG just to add, they don't render at all on Edge (just seems to render broken on chrome?)


[Languages] How to protect class objects from garbage collection in Java

Proposed title of the article
[Languages] How to protect class objects from garbage collection in Java
Proposed article introduction
A garbage collector is a component of software that manages memory. Its role is to remove unneeded memory and prevent memory from being freed while in use. In other programming languages like C/C++, the programmer creates and destroys objects. Useless objects are usually ignored by programmers Because of this while creating new objects, there may be insufficient memory and the application may crash due to OutOfMemoryErrors.
in Java's programming language, the garbage collector is automated, thus the user never has to manually free dynamically allocated memory. How does a trash collector pick what to delete? A lost reference causes an item to be deleted from the heap memory.
Key takeaways

An overview of garbage collection in java
In this key takeaway I will discuss:

In Java, what is garbage collection?
In Java, how do you dereference an object?
How Java Garbage Collection Works
java garbage collection roots

Understanding the terms used:

Unreachable objects
Collection eligibility

Methods for making an item garbage-collectible
Methods for invoking the Garbage Collector in the JVM
Finalization
We employ the notion of the garbage collector in a real-life scenario.

Article quality
By the end of this article, we will have covered an introduction of Garbage collection and also the ways to prevent class objects from garbage collection in java thus completing two tasks at once.
Also, I will use a real-life example for a better understanding for the beginner.
References
N/A

Thank you for your response and we thank you for submitting your topic. After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentations as previously mentioned on your topic form by our content moderator.
We typically refrain from publishing content that is covered widely on the net or other blogs. As we're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
We believe this is the best way for students to build a great portfolio (for potential employers) is by building what does not exist and what can provide the most value.
You are more than welcome to pursue another more in depth topic


Update API to version 5.1

Update to tba API version 5.1 (See it's changelog).
Fixes https://github.com/teloxide/teloxide/issues/342

Thank you very much! :heart:


Magnify zoomIn is too big

Hi,
I have a problem with Chrome and Firefox. In safari it works just fine.
I have a Magnifier in use and have a img-container with fixed height of 350px. In there is a img with max-width and max-height of 100%. Then I magnify this image. The problem is now for Chrome and Firefox that the magnify class is bigger than my 350px img-container. Than I tried to also give the magnify class a width and height of 100%. But than the Lenses work as the image would still be bigger so it does not really fit.
Can you help here? Not sure how to fix that but I love the lenses :)
Here you can watch in different browsers: https://hyphyweb-development.herokuapp.com/products/31/adidasxyz

Sorry I added width and height of magnify after I called magnifying. If I add it before it works like a charm :) maybe you should add this to your fork as well? (Or should I make a quick PR?)

No sorry does not work as expected. Magnify has now max width and height of 100% and outer div has fixed height and img has max width and height of 100% but img has bigger height than magnify.

#image_holder .img-container {
    height: 350px;
    text-align: center;
    img {
        vertical-align: middle;
        max-width: 100%;
        max-height: 100%;
    }
    .magnify {
      max-height:100%;
      max-width:100%;
    }
}

Not sure how to fix that. Is ugly with chrome and firefox does look as expected in safari. have a look at above link.

@Mojo90 Your demo looks fine in my Chrome (53.0.2785.57 beta-m).

Yes sorry I fixed that in the last days. Maybe you could adjust Magnifying Class that the img could definetely not be higher than magnifying. (To let you know: I only use original Size of image and not big and small image)
(SCSS-Code)
.image_holder .img-container {
    height: 350px;
    text-align: center;
    img {
        max-width: 100%;
        max-height: 350px;
    }
    .magnify {
        max-height: 100%;
        max-width: 100%;
    }
}

With this it works like a charm. Because magnify can maximal be at high of image holder and max-height should be set to height of imageHolder than I think it is perfect. And I suggest to add a option for this (Or if you know a more cleaner solution let me know..)
Nevertheless: great Library I do really love it 😊

Hey thanks for reporting this :). I will add some code to prevent this in the future. Do you mind reproducing the issue in a codepen or something so that I can verify my fix? Thanks again!

I prefer jsfiddle ;) there you go: https://jsfiddle.net/dm3vbxxw/2/ works for me like a charm in safari but in chrome and firefox img has immediately 100% height.
Yes a good point with the sizes, thank you! we already have several image sizes on our agenda cause we are currently building this platform from scratch but will come definetely! :)

@Mojo90 I made a slight change in your CSS to fix this :)
.imageHolder img{
max-height: 350px;
}
https://jsfiddle.net/thdoan/s9rb86o7/2/

Yep thx I fixed it exactly like this. But where does this come from? If  the outer div has a height of 350px and the inner img max-height of 100%. it should never ever be bigger or am I wrong?
It is okay for me now but I prefer a solution with percentage because sometimes I have to change those values with Javascript, not a problem but I always prefer pure css if possible :)
But one more time: really great magnifying class I really love it :D!!!

If the outer div has a height of 350px and the inner img max-height of 100%. it should never ever be bigger or am I wrong?

I think I found the answer to this question: "Some properties in CSS inherit the value of the parent automatically, some don't. Minimum height must be explicitly stated when you want it to inherit the parent's value." (Source)
The Magnify plugin inserts a div immediately below .imageHolder, so the final structure looks like this:
div.imageHolder > div.magnify > img
This is an easy fix then -- add the following to .magnify and it should fix the issue and you can keep your original CSS:
width: inherit;
max-width: inherit
height: inherit;
max-height: inherit

It is okay for me now but I prefer a solution with percentage because sometimes I have to change those values with Javascript, not a problem but I always prefer pure css if possible :)

Just curious, what's the difference between what your goal is (A) and what the alternative is (B)? In both cases you have to specify 350px somewhere; the only difference I can see is that you're specifying it as a value of max-height`` in instead of height`. The advantage of (B) is it uses less code.
(A)
#image_holder .img-container {
    height: 350px;
    text-align: center;
    img {
        vertical-align: middle;
        max-width: 100%;
        max-height: 100%;
    }
    .magnify {
      max-height:100%;
      max-width:100%;
    }
}

(B)
#image_holder .img-container {
    text-align: center;
    img {
        vertical-align: middle;
        max-height: 350px;
    }
}

Yes less code and change only one element instead of two. Always better, isn't it?


fix Grape helpers modified given helper module

fixes https://github.com/ruby-grape/grape/issues/1335

I am torn whether we want this. If you think "this is a Ruby module", then in Ruby if you write module MyHelperModule you'd expect it to reopen a previous one. On the other hand, we could consider modules namespaces, and maybe what you suggest has less of a surprise. Please add your :+1: or :-1:!


Request method now can be overload in config

it looks like the elastic search library uses lua socket directly, so it will block the nginx worker (using it in nginx) when it runs queries. This patch provides support for openresty, using openresty's co-socket api to do non-blocking requests to the elastic search server
An example can be found here:
https://github.com/CriztianiX/lapis-elasticsearch/blob/master/lapis/db/elasticsearch.lua#L16

Can you add an example to use this preferred_engine in examples? preferred_engine sounds too long, I guess just engine would do.
Also you will need to modify the tests so that they pass.


Update links to recent blog posts

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/db3b9f4b62421174d9e82bbcf2c29627def0d1d2/


Can't use method repo.getPathEntry and repo.getPathsEntries

My code
const repo = await createGitReader(
  path.join(REPO_PATH, GIT_SERVICE_FOLDER_NAME)
);
const fileList = await repo.listFiles();
const fileInfo = await repo.getPathsEntries(fileList.at(0));

Error:
file:///Users/zolotyh/sandbox/git-technical-dept/debug.js:12
const fileInfo = await repo.getPathsEntries(fileList.at(0));
TypeError: repo.getPathsEntries is not a function

It looks like the typescript wasn't built
NPM version

Github version

It was unpublished (marked as next in a change log). Just released as part of 0.1.2


Infrastructural update

Including:

fix miniconda prefix (that causes travis failures at the moment)
update helpers to 1.0.5
opt in to container based travis
customize test header
remove unused obsolete import

Now with a second look I realize that travis doesn't cause any problem, as it's not yet started. Anyway the changes will be needed whenever tests getting added.

Thanks @bsipocz -- turned on travis for the repository


Adding new project leads to git error

[2018-05-18 11:17:38] ERROR GitRepo:  Error commiting changes to ci-config repo
[2018-05-18 11:17:38] ERROR GitRepo:  git '--git-dir=/Users/nakhbari/.fastlane/ci/fastlane-ci-config/.git' '--work-tree=/Users/nakhbari/.fastlane/ci/fastlane-ci-config' push 'origin' '{:branch=>"master", :force=>true}'  2>&1:error: src refspec {:branch=>"master",  does not match any.
error: failed to push some refs to 'https://github.com/nakhbari/HelloWorldCiConfig'
Thread terminated with exception: git '--git-dir=/Users/nakhbari/.fastlane/ci/fastlane-ci-config/.git' '--work-tree=/Users/nakhbari/.fastlane/ci/fastlane-ci-config' push 'origin' '{:branch=>"master", :force=>true}'  2>&1:error: src refspec {:branch=>"master",  does not match any.
error: failed to push some refs to 'https://github.com/nakhbari/HelloWorldCiConfig'
  /Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/lib.rb:939:in `command'
  /Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/lib.rb:744:in `push'
  /Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/base.rb:329:in `push'
  /Users/nakhbari/Documents/fastlane/ci/app/shared/models/git_repo.rb:274:in `setup_repo'
  /Users/nakhbari/Documents/fastlane/ci/app/shared/models/git_repo.rb:152:in `block in initialize'
  /Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/TaskQueue-5b3f459be5c4/lib/queue_worker.rb:82:in `block in process'
2018-05-18 11:17:38 - Git::GitExecuteError - git '--git-dir=/Users/nakhbari/.fastlane/ci/fastlane-ci-config/.git' '--work-tree=/Users/nakhbari/.fastlane/ci/fastlane-ci-config' push 'origin' '{:branch=>"master", :force=>true}'  2>&1:error: src refspec {:branch=>"master",  does not match any.
error: failed to push some refs to 'https://github.com/nakhbari/HelloWorldCiConfig':
	/Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/lib.rb:939:in `command'
	/Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/lib.rb:744:in `push'
	/Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/ruby-git-166273eac44a/lib/git/base.rb:329:in `push'
	/Users/nakhbari/Documents/fastlane/ci/app/shared/models/git_repo.rb:274:in `setup_repo'
	/Users/nakhbari/Documents/fastlane/ci/app/shared/models/git_repo.rb:152:in `block in initialize'
	/Users/nakhbari/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/TaskQueue-5b3f459be5c4/lib/queue_worker.rb:82:in `block in process'
<IP_ADDRESS> - - [18/May/2018:11:17:38 -0700] "POST /data/projects HTTP/1.1" 500 330 3.2474

Looks like https://github.com/fastlane/ci/issues/727#issuecomment-383639058
and https://github.com/fastlane/ci/issues/677#issuecomment-382552168
Potentially having more output + repro steps might help in figuring out where the problem is coming from along with what the current state of you config repo looks like, as in git status

@snatchev and I are pairing on this right now.


High memory allocation when using longer AckTimeout

There seems to be a correlation between the ack timeout and memory allocation. The longer I set it, the more memory gets allocated.
Here you can see the allocations if the timeout is set to 100 days, but the problem is visible for smaller ack timeouts as well.

You can use the program bellow to reproduce the issue:
var client = await new PulsarClientBuilder()
    .ServiceUrl("pulsar://localhost:6650")
    .BuildAsync();

long memoryBefore = GC.GetTotalMemory(true);

await using var consumer = await client.NewConsumer()
    .Topic("test-topic")
    .SubscriptionName("test-subscription")
    .AckTimeout(TimeSpan.FromDays(100))
    .SubscribeAsync();

long memoryAfter = GC.GetTotalMemory(true);
Console.WriteLine($"Memory used: {(memoryAfter - memoryBefore) / 1_000_000} mb");

Btw, the reason why we discovered this issue is that if we have the consumer set as the default (Zero) it seems that the client library effectively sets the ack timeout to 30s (which is a discrepancy to the Java client that keeps it as infinite).

@adrianotr good notice! It indeed correlates well with the code which is totally correlates with Java code

we discovered this issue

Not sure I understand what is the issue though

Hi, thanks for the quick response. Sorry for not being very clear; let me explain that better.

Not sure I understand what is the issue though

It's a separate issue, but basically it's why we were using very long ack timeouts. If you don't set the ack timeout, then the lib sets the ack timeout to 30s instead of keeping it as zero. This is what I meant that is different from the Java client.

It indeed correlates well with the code

So the problem there is not the correlation but the immense amount of memory used.
For example, this is the memory allocation I get by using different ack timeouts:

AckTimeout
Memory Allocation

30 seconds
3 mb

24 hours
15 mb

2 days
27 mb

10 days
132 mb

100 days
750 mb

If you don't set the ack timeout, then the lib sets the ack timeout to 30s instead of keeping it as zero

That's incorrect, Pulsar.Client follows Java and sets timeout to zero

So the problem there is not the correlation but the immense amount of memory used.

I've provided the code reference so you could understand_why_ the amount of memory used.
let stepsCount = Math.Ceiling(ackTimeout.TotalMilliseconds / tickDuration.TotalMilliseconds) |> int
for _ in [1..stepsCount] do
    timePartitions.Enqueue(RedeliverSet())

According to the Math, if you increase ackTimeout, the timePartitionQueue will increase as well. You can reduce memory used by increasing AckTimeoutTickTime together with increasing AckTimeout


Improve documentation on Exchange Hybrid and Version requirements

Hello,
I suggest adding some clarifications for the Exchange on premises hybrid requirements.
Please include that an Exchange "full" hybrid is required.  Only full hybrid configures OAuth (minimal hybrid does not)
Also, regarding the dependency in version, it would be much clearer if we mention that the mailbox also needs to be on an > Exchange 2016 CU3 server.
As it is now written, the information in the article could be misinterpreted - that only the hybrid server needs to be on version > Exchange 2016 CU3.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8456689d-6f04-fa5e-4f51-f413cb0b9d89
Version Independent ID: e9b85126-0db7-4378-ad44-514e52f9fde1
Content: How Exchange and Microsoft Teams interact - Microsoft Teams
Content Source: Teams/Exchange-Teams-interact.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@scanum Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@gabsto-ms thank you for reaching out and helping improve MS Docs. I see the article was updated this week with important information. Please let me know if you still need assistance.

@gabsto-ms Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


OCR Feature for Table Format

Aim

I would like to upgrade the current OCR simple code into the updated version that works in Table format text.
First implementation - English language-focused.

Details

I want to use image processing(OpenCV) to detect lines and tables, then extract words from the table, pass them through pyTesseract.
Later, I hope to work on my local language(Burmese - especially for tesseract training with Python tools) to get more accuracy and also for the Indian language (if any others from India also interest to help.) But as far as I know, there're several supporters in Indian languages and also had strong training ground in Tesseract accuracy.

Tools

Python
PyTesseract
OpenCV

Further plan

Add UI for user input (maybe with python Kivy or Flask)
Easy tool for Tesseract training for local (Asian) languages

Sounds Great.. Assigned to you @GmGniap

Sounds Great.. Assigned to you @GmGniap

Thanks, @avinashkranjan  , I start working on it. May I know if I got any trouble while implementing, I just need to ask in the related slack channel or is there any mentors assigned to specific tasks?

Thanks, @avinashkranjan  , I start working on it. May I know if I got any trouble while implementing, I just need to ask in the related slack channel or is there any mentors assigned to specific tasks?

You can ask me or ask in slack channel mentors or I'll help you..

You can ask me or ask in slack channel mentors or I'll help you..

Hey @GmGniap Any Updates? Are you having any issues?

can you assign this to me?

@subhangi2731 Updates on this?

@kaustubhgupta @avinashkranjan can you please explain what is this about... im gssoc 21 participant and looking forward to contribute to this issue:)

The current OCR script is not very effective for tabular formats. Suppose an image has a table, then the script needs to extract the table contents and save it to CSV. You can use any approach for this

okay... can i work on this project.... i wish to learn more about it:)

@anandhu-eng sure, I am assigning this to you. If you are stuck anywhere just ping me here or in the discord channel

okay thanks:)

@kaustubhgupta i have installed tesseract using pip command in ubuntu but unable to find the path. I have surfed the web for the same, they say its in usr/bin/tesseract, but couldn't find it. Can you please assist me.

updates @anandhu-eng?

Im working on it....just figured how to execute it... we are having sem exam next week that's y im going little bit slow @kaustubhgupta

@anandhu-eng updates?

@anandhu-eng you need to make the PR today only else this issue will be assigned to someone else


How to setup custom channel

Hi! Can I ask on how you will make a custom channel for all the pages? so that I can see all the broadcaster, I have read your explanation on how you make it but I can't do it. Thank you!

Hi do you implement this now?

Hello, not yet. Do you know how?
On Fri, Aug 31, 2018, 3:28 PM phantom<EMAIL_ADDRESS>wrote:

Hi do you implement this now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/muaz-khan/WebRTC-Experiment/issues/598#issuecomment-417577781,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae4r13MN1s1ekwadObshjQIUb0qQ5tkqks5uWOWpgaJpZM4V_WRP
.

Not yet. What I need is a local version of "connection.socketURL = 'https://rtcmulticonnection.herokuapp.com:443/';   Do you know how?


Delete old changesets from develop branch

Description 📝
Remove changesets from the previous release (v1.95.0).

I'm going to close this since this can be done when merging master > develop. We should see a conflict with changesets that we'll just have to resolve. I'll update docs


Expand RV32 mstatus into mstatush

We anticipate the need to expand mstatus beyond 32 bits for RV32 systems, since future extensions, including the hypervisor extension, will increase mstatus pressure.  Current plan is to provide an mstatush CSR, such that mstatush[31:0] corresponds to mstatus[63:32].
We hope sstatus does not need to be expanded in the same way, but note the same pattern would be suitable in that case.
(See #79 for context)

It probably isn't worth adding sstatush just for this, but the UXL field is already inaccessible to RV32 code even though the spec defines how it would behave.


deleteDataForUserAccount not failing, but not deleting data

I'm updateData(forUserAccount:inService:) successfully , loadDataForUserAccount successfully, deleteDataForUserAccount seemingly successfully (doesnt catch/fail), but then loadDataForUserAccount still works/loads the data that should have been deleted.

Hmm strange. Which version of Locksmith and iOS? Also if you can reliably reproduce a sample project would be super helpful.
Thanks!

On 13 Apr 2016, at 12:27 AM, Mathew Huusko V<EMAIL_ADDRESS>wrote:
I'm updateData(forUserAccount:inService:) successfully , loadDataForUserAccount successfully, deleteDataForUserAccount seemingly successfully (doesnt catch/fail), but then loadDataForUserAccount still works/loads the data that should have been deleted.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

I have same problem. Locksmith (2.0.8), iOS 9.2

Hi  @matthewpalmer
Seems that I just run into the same problem.
In my case I am unable to read or write to the Keychain after I presentViewController UIImagePickerController. Strange...
Locksmith.loadDataForUserAccount() returns nil, deleteDataForUserAccount() and saveData() exits without throwing any error.
After restarting the app I can read from the Keychain, also data that supposed to be deleted still exists.
After some debugging and googling I think it may be related to a mysterious bug in the Keychain which manifests itself as the OSStatus -34018. https://forums.developer.apple.com/thread/4743
In the Locksmith this code is not handled and falls into if statement: https://github.com/matthewpalmer/Locksmith/blob/6b32c7ec68324f33f2b8fb0765213c74a6f86dd5/Source/Locksmith.swift#L87, probably why writing and reading exits without any error.
I am able to reproduce it but not in every iteration and only if the app is connected with Xcode (debug mode, iOS 9.2.1).
@JanBorowskiES @mhuusko5  Maybe setting breakpoints in the method linked above will help you verify if it is the same problem (not handled error code and/or bug in the iOS Keychain).

I'm having the same issue. Any one come up with a solution?

Same issue on this now and it's December 15th. How did this get solved?

Same issue! Still available the data, after using deleteData method with Locksmith...

I seem to be having this same problem.
But then, I found: https://github.com/matthewpalmer/Locksmith/issues/97#issuecomment-256115819
and I tried that. I wasn't sure why the entitlement was necessary (we don't use groups), but I added it, did a fresh rebuild, and then... no more problems.
Curious if that helps anyone else?


PHP 8.0.0 Installation failed

I did a fresh install of symfony using PHP 7.4.13 then the symfony/orm-pack without a problem, I replicated the same using PHP 8.0.0 but encountered an error:
# composer require symfony/orm-pack
Using version ^2.0 for symfony/orm-pack
./composer.json has been updated
Running composer update symfony/orm-pack
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "5.2.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - doctrine/doctrine-migrations-bundle[dev-2.2.x-merge-up-into-3.0.x_5f12ade8acaa06.99463690, v2.0.0-alpha1, ..., 2.2.x-dev] require php ^7.1 -> your php version (8.0.0) does not satisfy that requirement.
    - doctrine/doctrine-migrations-bundle[dev-manager-loader, dev-container-aware-migration-factory, 3.0.0-alpha.1, ..., 3.1.x-dev] require php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.
    - doctrine/doctrine-migrations-bundle[1.0.x-dev, ..., 1.3.x-dev] require symfony/framework-bundle ~2.7|~3.3|~4.0 -> found symfony/framework-bundle[v2.7.0-BETA1, ..., 2.8.x-dev, v3.3.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev] but it conflicts with your root composer.json require (5.2.*).
    - doctrine/doctrine-migrations-bundle[1.0.1, ..., 1.2.x-dev] require symfony/framework-bundle ~2.3|~3.0 -> found symfony/framework-bundle[v2.3.0, ..., 2.8.x-dev, v3.0.0-BETA1, ..., 3.4.x-dev] but it conflicts with your root composer.json require (5.2.*).
    - doctrine/doctrine-migrations-bundle[1.0.0-BETA2, ..., 1.0.0] require symfony/framework-bundle ~2.1 -> found symfony/framework-bundle[v2.1.0, ..., 2.8.x-dev] but it conflicts with your root composer.json require (5.2.*).
    - __root__ is present at version dev-master and cannot be modified by Composer
    - doctrine/doctrine-migrations-bundle v1.0.0-beta1 requires symfony/symfony >=2.0 -> satisfiable by symfony/symfony[v5.2.0-BETA1, ..., 5.2.x-dev].
    - symfony/orm-pack v2.0.0 requires doctrine/doctrine-migrations-bundle * -> satisfiable by doctrine/doctrine-migrations-bundle[dev-manager-loader, dev-container-aware-migration-factory, dev-2.2.x-merge-up-into-3.0.x_5f12ade8acaa06.99463690, v1.0.0-beta1, ..., 1.3.x-dev, v2.0.0-alpha1, ..., 2.2.x-dev, 3.0.0-alpha.1, ..., 3.1.x-dev].
    - __root__ dev-master conflicts with symfony/symfony v5.2.0.
    - __root__ dev-master conflicts with symfony/symfony v5.2.0-RC2.
    - __root__ dev-master conflicts with symfony/symfony v5.2.0-RC1.
    - __root__ dev-master conflicts with symfony/symfony v5.2.0-BETA3.
    - __root__ dev-master conflicts with symfony/symfony v5.2.0-BETA2.
    - __root__ dev-master conflicts with symfony/symfony v5.2.0-BETA1.
    - __root__ dev-master conflicts with symfony/symfony 5.2.x-dev.
    - Root composer.json requires symfony/orm-pack ^2.0 -> satisfiable by symfony/orm-pack[v2.0.0].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

 # symfony console about
 -------------------- ---------------------------------
  Symfony
 -------------------- ---------------------------------
  Version              5.2.0
  Long-Term Support    No
  End of maintenance   07/2021 (in +240 days)
  End of life          07/2021 (in +240 days)
 -------------------- ---------------------------------
  Kernel
 -------------------- ---------------------------------
  Type                 App\Kernel
  Environment          dev
  Debug                true
  Charset              UTF-8
  Cache directory      ./var/cache/dev (253 KiB)
  Build directory      ./var/cache/dev (253 KiB)
  Log directory        ./var/log (0 B)
 -------------------- ---------------------------------
  PHP
 -------------------- ---------------------------------
  Version              8.0.0
  Architecture         64 bits
  Intl locale          en_PH
  Timezone             UTC (2020-12-03T18:47:21+00:00)
  OPcache              true
  APCu                 false
  Xdebug               false
 -------------------- ---------------------------------

That's because Doctrine is not yet compatible with PHP 8.

Since doctrine got an update for PHP 8 support (https://github.com/doctrine/orm/releases/tag/2.8.0) is it possible to update this package too?

This package is already compatible with php8.
Btw, you should unpack it!

When I'm calling composer require symfony/orm-pack I still get the same error as racile here

Sure you do, because of doctrine/doctrine-migrations-bundle which is not yet compatible with php8.


upgrade minimatch explicitly

Coverage remained the same at 86.786% when pulling 71b7774ad4c05577122688e669346847631d28a4 on npm-patches-2 into 93d9c9a156dba8b11446b3f7590e38d1f00534f5 on master.


Check render call

router-view
going to remove myself from this issue since it will be taken care of according to e


Fixing tarball and testing page

@jodok and @joemoe Let me know if you're happy with this. The page uses the old method of setting versions (config.json) to load testing and stable releases.
It fixes this - https://trello.com/c/fv35aTkQ/122-website-tarball-link-is-missing-whole-site-is-a-template
Not sure if it fixes these:
https://trello.com/c/NEWq2JNz/123-website-usability-to-find-link-to-tarball-at-the-new-website-is-really-worse
https://trello.com/c/iVTEyGRl/124-website-no-way-to-figure-out-latest-crate-versions-on-new-website
As it's still extra steps to get to these pages, but they are there…

Not sure where that Ubuntu commit came from :/

with jodok's changes it is fine for me.

@jodok and @joemoe I think this is done. Moved script to footer, changed analytics call, it seemed to work, I can't confirm the analytics though as I have no access.

tracking is still not removed. please remove it. also the external js.

I'm unclear @jodok it is removed and the js has been removed, both in the last commit. Unless I am misunderstanding what you are saying.

if i look at the diff, i see them still there: https://github.com/crate/crate-web/pull/284/files

@jodok I think you're looking at a template file that we're not actually using, there are a couple of template folders in the website and I wasn't sure which one we were using.
I will remove it from that too, and a commented out line with the old analytics code (just in case) but it was already removed from the template file we're actually using.
Apart from that, everything in the current checkout is using an inline script and the function you asked to use.

OK @jodok this should be plain and simple for now. Would be nice to style the link, but at least it works for now :)

cool :) seems like master is ahead of that branch and you need to resolve conflicts first.

@jodok Yup, I have a lot of conflict resolving to do on several PRs now, Git fun beckons!