(Android) Repeated microphone notification 📵🎙🤓

Works perfectly on desktop.

When using Annyang on my my Android in Chrome, the microphone notification repeatedly goes off when accessing the site over HTTPS.
If I access it over HTTP, it allows me to complete a command, and then asks me to Block/Allow the use of the microphone again.
I would like to use HTTPS so it remembers my choice.
Expected Behavior

First time visiting site should ask for permission to use microphone and should remember my choice.
When loading the site should make microphone notification noise once.
Should then not make the notification noise again.

Current Behavior

First time visiting site, asks for permission to use microphone and remembers choice.
Then repeatedly (every 1-2 seconds) makes microphone notification noise.

Possible Solution
Maybe using the .start() options:
annyang.start({ autoRestart: false });
annyang.start({ autoRestart: false, continuous: false });

Steps to Reproduce (for bugs)
$(function() {
  if (annyang) {
    var commands = {
      'hello': function() {
        someFunction();
      },
      'light on': function() {
        someFunction();
      },
      'lights on': function() {
        someFunction();
      },
      'light off': function() {
        someFunction();
      },
      'lights off': function() {
        someFunction();
      }
    };

    annyang.addCommands(commands);
    annyang.start();
  }
});

Your Environment

Version: 2.3.0
Chrome: 49.0.2623.105
Operating System: Android 5.1.1

Thanks! ✌

Hi @revett
Out of preliminary curiosity, are you using a valid certificate on the server?

Hi @lmangani 👋
Thanks for the quick reply. Yep, its backed by the GlobalSign Root CA and is accepted in Chrome (green).

@TalAter any ideas?

Is this resource publicly available for others to try test/replicate for suggestions?

@lmangani - tested on two devices, using the same version of Annyang.

@lmangani - I could make a replica if 100% needed.

This is fixed and the behavior on mobile with respect to remembering the user's permission is the same as on desktop from M33 for Chrome on Android.
Ref:  https://code.google.com/p/chromium/issues/detail?id=274022&can=1&q=webrtc permission&colspec=ID Pri M Iteration ReleaseBlock Cr Status Owner Summary OS Modified

@atchyut-re nice spot! Do you know the Chrome version it was released on?

Sorry, @revett  I had no idea.

Thanks @atchyut-re 👍
Unfortunately, the issue of the microphone notification noise triggering over and over again is still a problem with Chrome for Android.

@TalAter - Eventually I switched to native webkitSpeechRecognition -  :(
when I use the native API I get almost no notification noises.

@namel so you stopped using annyang?

@namel Could you share your code? If I could see what you are doing different, we may find a hint for the problem.
Thanks :+1:

@TalAter
My code isn't neatly organized - but the jist of it is that I needed to start and stop and specific points in time.  And once it restarted, it had to remain continuous.
As I re-read the annyang API, it seems like I could have done this with start({continuous:true}),  pause() and resume().
The real problem is that I mistakenly thought I could do better than Annyang on android because I was seeing good results on my mac.  Maybe if the documentation was more explicit then I wouldn't have gone down that path?  For example if you mentioned that on Android+continuous there are notification noises, (because the underlying API implementation doesn't support true continuous) and one potential mitigation is to use pause/resume in relevant places.

@namel I had tried what you have mentioned in the above comment. But unfortunately the problem still occuring.
Can you please a code sample if it is working fine with you.
Thankyou :+1:

same problem here, doesnt works on android chrome

repeatedly (every 1-2 seconds) makes microphone notification noise.
i have chrome 53.0.2785.124
android 5.0.0

I'm seeing this same exact behavior and it seems to be related to #206

I got stuck on the same issue :(
Since annyang is a victim rather than the cause here, has anyone tried reaching out to google/chromium folks? The issue occurs on a combination of Google OS + Google API + Google browser. :) I used Android 6 with Chrome 50.
BTW - I wouldn't say that switching to webkitSpeechRecognition helps, I am getting exactly the same issue, I am not sure how others made it to work - if you succeeded, please kindly share how.

Same issue here (cordova / crosswalk). Workaround: make it event-driven but that's not an actual solution. Should be fixed in Chrome/Chromium.

mobile is not support it? why i use it no response！
`			$(document).ready(function(){
$(".tab_content").hide();
$(".tab_content:first").show();
$('ul.tabs li').last().addClass("tab_last");
			$("ul.tabs li").click(function() {

				$(".tab_content").hide();
				$(".tab_content").eq($(this).index()).show();

				$("ul.tabs li").removeClass("active");
				$(this).addClass("active");

			});

		  // first we make sure annyang started succesfully
		  if (annyang) {

		    // define the functions our commands will run.
		    var showNews=function(){
		    	$(".tab_content").hide();
				$(".tab_content").eq(0).show();

				$("ul.tabs li").removeClass("active");
				$("ul.tabs li").eq(0).addClass("active");
		    };
		    var showNotices=function(){
		    	$(".tab_content").hide();
				$(".tab_content").eq(1).show();

				$("ul.tabs li").removeClass("active");
				$("ul.tabs li").eq(1).addClass("active");
		    };
		    var showGonggao=function(){
		    	$(".tab_content").hide();
				$(".tab_content").eq(2).show();

				$("ul.tabs li").removeClass("active");
				$("ul.tabs li").eq(2).addClass("active");
		    };
		    var showNote=function(){
		    	$(".tab_content").hide();
				$(".tab_content").eq(3).show();

				$("ul.tabs li").removeClass("active");
				$("ul.tabs li").eq(3).addClass("active");
		    };

		    var getStarted = function() {
		      window.location.href = 'https://github.com/TalAter/annyang';
		    };

		    // define our commands.
		    // * The key is what you want your users to say say.
		    // * The value is the action to do.
		    //   You can pass a function, a function name (as a string), or write your function as part of the commands object.
		    var commands = {
		      '新闻':	showNews,
		      '通知':	showNotices,
		      '公告':	showGonggao,
		      '备注':	showNote,
		    };

		    // OPTIONAL: Set a language for speech recognition (defaults to English)
		    annyang.setLanguage('zh-cn');
		    // OPTIONAL: activate debug mode for detailed logging in the console
		    annyang.debug();
		    // Add voice commands to respond to
		    annyang.addCommands(commands);
		    // Start listening. You can call this here, or attach this call to an event, button, etc.
		    annyang.start();
		  }

		})	`

Same behaviour here with Annyang as well as with the SpeechRecognition API (chrome 54.0.2840.85 / Android 5.1.1). Tested with https://www.talater.com/annyang/ and https://davidwalsh.name/demo/speech-recognition-video.php

No chrome issue found.
Opened one https://bugs.chromium.org/p/chromium/issues/detail?id=679010
Please add a comment if something is missing
:star: this chrome issue - thanks

This happens for me as well.  It is only for Chrome on Android.  Does anyone know of an alternative browser that can work on Android?  I tried mobile Firefox but it must not support speech recognition.

Any news about this? The current non stop beeping makes it all completely unusable on android phones, crossing fingers for a solution eventually, thank you for this great library by the way, all best

maybe related to this 4 year android issue?
https://code.google.com/p/android/issues/detail?id=37862

I would encourage everyone to make comments in those Google forums so we can get this fixed once and for all.

Sorry for my "bad" english, it seems here https://syl22-00.github.io/pocketsphinx.js/live-demo.html the problem was not encountered with my android phone.
perhaps a way to find a solution @Talaler

got the same problem

I used the volumen control,  When the page is open  I put the volumen in 0, When leave the page I put the volumen in 1.

How did you work on Android. I could not run it on WebView. Can you help me?

@ardakazanci the Android WebView does not include the speech rec API IIRC.

@macdonst  What are the alternatives?

@ardakazanci you could use Cordova and then add my Speech Rec plugin into the app. YMMV with the plugin as I haven't had much time to work on it recently but it does add the speech rec api into the web view and you can run annyang on top of it.
https://github.com/macdonst/SpeechRecognitionPlugin

I live with this problem. How can I resolve

I cant' resolve it.
I down the volumen.

De: Arda Kazancı<EMAIL_ADDRESS>Enviado: domingo, 13 de agosto de 2017 02:45 a. m.
Para: TalAter/annyang
CC: rmd97; Comment
Asunto: Re: [TalAter/annyang] (Android) Repeated microphone notification 📵🎙🤓 (#194)
I live with this problem. How can I resolve
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/TalAter/annyang/issues/194#issuecomment-322027348, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFHr-2WnbaGBF32A1Rb9snA74Ve12olKks5sXql-gaJpZM4IMMUB.

The Chrome team have marked the issue as 'wontFix':

Yes, I have run the demo https://www.talater.com/annyang/ on an android mobile phone.
That web page is continually using speech recognition.
This API is not intended for continuous use in this manner.
This is working as intended.
--<EMAIL_ADDRESS>
This issue appears to be unresolvable. : /

Any progress?

No. As detailed in https://github.com/TalAter/annyang/issues/194#issuecomment-323775236 this appears to be a design choice by Google.

So, to be clear, this is still the case? I wish this were clearly stated in the library documentation around continuous, or anywhere. I was basing a design on this idea, and I finally got it working only to have this issue, google it, and read the thread all the way to the bottom.

@kylebakerio  It seems so. On the other hand, you're using the free speech from google chrome. If you don't mind paying for the speech rec, I've built a base for a node based speech rec that works on any device and cross browser:
https://github.com/vin-ni/Google-Cloud-Speech-Node-Socket-Playground


use (or contribute to) crc library?

I noticed that you re-implement crc. Would you be interested in using a library instead (or contributing to it if it doesn't work for your needs)?
I just opened a PR for no_std support in mrhooray/crc-rs#13

smoltcp does not implement any form of CRC. It implements an RFC 1071 checksum. In any case a dependency on crc-rs would be strictly a drawback, so no.


pass curr leaf object to customize component onClick and pass keypath to node component

resolve https://github.com/socialtables/react-infinity-menu/issues/39


Move "Press Enter to send" below Send button

In #20302, we will implement a number of buttons below the compose box, which will take up a significant amount of horizontal space.
To free up space for these buttons, we should try making "Press Enter to send" small and moving it below the Send button. We can try putting it into the gutter below the buttons under the compose box once all elements have been correctly aligned, as discussed here.

@zulipbot claim

@NerdyLucifer please pick an issue that has the "help wanted" and/or "good first issue" label. Thanks!

@alya i think i can solve this issue...may i please send the pull request?
https://user-images.githubusercontent.com/85362194/142818615-052c670d-6839-4904-8be6-0372645bc07b.mov

@NerdyLucifer it looks like your work is not on top of the latest pull requests merged in this area, so I would expect that it needs to be rebased before there's a possibility that it will be useful.

https://user-images.githubusercontent.com/85362194/142827533-2e6dde2b-dbee-4f3b-b40b-c33c65cef01b.mov
this is how it looks after i fetched the latest commits

Thanks!
The placement definitely isn't right. I think we want the text/checkbox to be smaller and just below the Send button.

@alya is this placement right?
https://user-images.githubusercontent.com/85362194/142918386-426c5bce-e95c-4fd9-a8b6-f3227a086d17.mov

Yes, that's the location I had in mind, so you could try submitting a PR.
Could you also include some static screenshots? It's hard to see what's going on in the video, especially since the video controls are overlapping with the most important part.

I wonder if we want to move up the "Press Enter to send" text when there is no "Send" button; it looks kind of funny to have a blank space above it.

Let's move the discussion to https://chat.zulip.org/#narrow/stream/101-design/topic/compose.20box.20formatting.20button

@alya is this issue still alive?

I think we should pause on this one, as we're likely to go with the approach in #20343.
Thanks for prototyping! It was helpful to see what it would look like if we went this route.

We will rethink this issue and come up with an alternative plan.


Is callback necessary?

I read the source code about hstore.stringify: https://github.com/scarney81/pg-hstore/blob/master/lib/index.js#L32
if (!callback || callback === null) return joined;
callback(joined);

It also works fine without passing callback  argument. Like this:
const hstore = require('pg-hstore')();
const dataParsed = hstore.parse(data);
const dataStringified = hstore.stringify(data);

Am I correct?

You are correct. This callback is not necessary. If I were re-writing this package I would not have constructed it with a callback signature.

@scarney81 Thanks for reply.  The documentation should be updated.

Its more than a year but would you like me to make an update to the README? @scarney81

That would be most welcome @SayakMukhopadhyay


Quantitative results on MAD-sim

Hi, @EricLee0224
Are the results of Table 2 in the paper evaluated on MAD-real? Since the MAD-real is still not available, could you please share the performance comparison (like Table 2 in the paper) on MAD-sim? Thanks~

Hi coordxyz,
The results in Table 2 of the paper were evaluated on MAD-Sim. In fact the default evaluation setting for the MAD dataset is to use the MAD-Sim set, as we wish to explore the model's ability to detect object-centric multi-pose anomalies without background's influence (Of course we also provided qualitative and quantitative results in MAD-Real in other experiments.). The Real dataset is generally used to generalize the model towards real application deployments.
If there are any other questions, feel free to reach out to me!


Unable to peer two VNET in different subscription and different Azure AD tenant

Hi,
Despite what is written in the documentation, I was unable to peer two vnets of two differents subscription with two different Azure AD Tenant:
The client has permission to perform action 'Microsoft.Network/virtualNetworks/peer/action' on scope '/subscriptions/XXXXXXX/resourceGroups/myResourceGroupA/providers/Microsoft.Network/virtualNetworks/myVnetA/virtualNetworkPeerings/myVnetAToMyVnetB', however the current tenant 'XXXXXXX' is not authorized to access linked subscription
I'm facing the same issue in CLI, PoSh or GUI.    I double checked everything, and tried on other couple of subscritption, but I'm facing this message anytime.
The documentation is confusing, a clarification would be appreciated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52fe18fe-efc5-3e63-8200-8e20e885b55e
Version Independent ID: 86a4f465-d676-e0e4-7367-2ed9f906340a
Content: Create an Azure virtual network peering - Resource Manager - different subscriptions
Content Source: articles/virtual-network/create-peering-different-subscriptions.md
Service: virtual-network
GitHub Login: @jimdial
Microsoft Alias: jdial;anavin

Thanks for the feedback! We are currently investigating and will update you shortly.

@charlesb87 The error message you are getting seems to lead that there is an issue with the destination subscription. Please make sure that you are logging out of one subscription & tenant and logging into the correct one when the doc specifies.
If you are still having issues, I would recommend you open a support request. If you do not have a support plan, please Email me at<EMAIL_ADDRESS>with your SubscriptionID and a link to this Post, and I will enable a one-time free support request for your subscription to troubleshoot this issue.

In fact I was able to do the peering at least using PowerShell or CLI desk version (I mean not using Cloud Shell).

Charles BORCKE
MailTo<EMAIL_ADDRESS>PhoneTo: +33 684 366 356
----- Original Message -----
From: "TravisCragg-MSFT"<EMAIL_ADDRESS>To: "MicrosoftDocs/azure-docs"<EMAIL_ADDRESS>Cc: "charlesb87"<EMAIL_ADDRESS>"Mention"<EMAIL_ADDRESS>Sent: Tuesday, October 16, 2018 9:18:20 PM
Subject: Re: [MicrosoftDocs/azure-docs] Unable to peer two VNET in different subscription and different Azure AD tenant (#16791)
@charlesb87 The error message you are getting seems to lead that there is an issue with the destination subscription. Please make sure that you are logging out of one subscription & tenant and logging into the correct one when the doc specifies.
If you are still having issues, I would recommend you open a support request. If you do not have a support plan, please Email me at<EMAIL_ADDRESS>with your SubscriptionID and a link to this Post, and I will enable a one-time free support request for your subscription to troubleshoot this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or mute the thread .

@charlesb87 Thank you for the update.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

I don’t agree about closing the case. I was not able to do the peeeing using Cloud Shell: Are you able to reproduce the issue? Are you going to clarify the documentation ?
Charles Borcke
Cell: +33 684 366 356
Mail<EMAIL_ADDRESS>Le 19 oct. 2018 à 20:15, TravisCragg-MSFT<EMAIL_ADDRESS>a écrit :
@charlesb87 Thank you for the update.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


seccomp: remove modify_ldt

re: https://github.com/docker/docker/pull/22579/files#diff-2441fc0087d867021a1308a30c5d00baR80
@justincormack let me know if this is a terrible mistake

hmm janky got a new font, but still hates me

For reference this was added because Go uses it on i386 binaries see https://github.com/docker/docker/pull/19218 https://github.com/docker/docker/issues/19201
However it has recently been removed from Go in https://github.com/golang/go/commit/0f86d1edfb87fddb2c7f50d177b67f48219151f3 with a note that it is not available on some newer kernels, and has to be explicitly made available on others, and replaced by the modern set_thread_area. Issue is https://github.com/golang/go/issues/14795. It does not seem this commit is in a release yet though.
There is also an unconfirmed suggestion that Wine uses it (allegedly even for 64 bit code) https://lkml.org/lkml/2015/7/21/759 would like to confirm if this the case because we have a lot of Steam users it seems based on other issues.
So a bit unsure, would like to block it, but I would be happier if there was a Go release that worked, as no 32 bit Go programs will run at all, and people do use 32 bit mode a bit.

Ah I have a wine container I can test, and that's super interesting about
go
On Sunday, May 8, 2016, Justin Cormack<EMAIL_ADDRESS>wrote:

For reference this was added because Go uses it on i386 binaries see
#19218 https://github.com/docker/docker/pull/19218 #19201
https://github.com/docker/docker/issues/19201
However it has recently been removed from Go in golang/go@0f86d1e
https://github.com/golang/go/commit/0f86d1edfb87fddb2c7f50d177b67f48219151f3
with a note that it is not available on some newer kernels, and has to be
explicitly made available on others, and replaced by the modern
set_thread_area. Issue is golang/go#14795
https://github.com/golang/go/issues/14795. It does not seem this commit
is in a release yet though.
There is also an unconfirmed suggestion that Wine uses it (allegedly even
for 64 bit code) https://lkml.org/lkml/2015/7/21/759 would like to
confirm if this the case because we have a lot of Steam users it seems
based on other issues.
So a bit unsure, would like to block it, but I would be happier if there
was a Go release that worked, as no 32 bit Go programs will run at all, and
people do use 32 bit mode a bit.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/22580#issuecomment-217705337

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

I think we can hold off for now, but just for future reference I will try some things, I have a steam container as well ;)

I'm going to close as it's not realistic at this point in time, but will give updates on this thread after further testing so we have it for the future :)

cool, it would be good to work out when we can reasonably remove it.


Iassd attn

add iassd_attention model

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

duplicate with PR #299


Fix/detailspage4

Jira issue link: link

check applicable boxes

[ ] I have made tests to match the user stories
[ ] This code does not require tests that match user stories
changed routing

Denne skulle vel gått til branch develop?

close


Object level Recovery Map for Litespeed variable to be added

Hi,
i use litespeed as a 3rd party backup tool and noticed OLRMAP is missing from the code which could be added easily and makes a huge difference for performance for Object level recovery in litespeed.
i would like to see this added permanent as to be able to enable or disable this feature.
for now on my script i have added manually as below:
WHEN @CurrentBackupType IN('DIFF','FULL') THEN 'DECLARE @ReturnCode int EXECUTE @ReturnCode = [master].dbo.xp_backup_database @olrmap = 1, @database = N''' + REPLACE(@CurrentDatabaseName,'''','''''') + ''''
WHEN @CurrentBackupType = 'LOG' THEN 'DECLARE @ReturnCode int EXECUTE @ReturnCode = [master].dbo.xp_backup_log @olrmap = 1, @database = N''' + REPLACE(@CurrentDatabaseName,'''','''''') + ''''
as stated by litespeed in the user guide
"LiteSpeed may take a long time to read the backup file for large databases, often with little response in the LiteSpeed UI Console. To prevent this, the Optimize Object Level Recovery speed option on the Backup wizard Options page is selected by default to create the index during the backup"
It is not selected by default when xp_backup_database is ran manually the paramter @OLRMAP = 1 must be added.
https://support.quest.com/litespeed-for-sql-server/kb/14507/what-is-the-lsm-file-that-gets-created-with-the-backup-file-and-can-it-be-deleted-
this explains a file which creates also as people will see a file added.
i used a 30GB database as an example and before OLRMAP 4 minutes 6 seconds to read the backup file. With OLRMAP enabled it took 3 seconds. :) imagine larger databases.
Thanks
Danny Kruge

I have added this now. Please try it out.
https://ola.hallengren.com/versions.html
https://ola.hallengren.com/sql-server-backup.html#ObjectLevelRecoveryMap


Revert "tbb: split output"

This reverts commit f386825fa23a7b1e67e0c93e82bcbd318da03c86.
broke various cmake builds
embree openimagedenoise
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@Artturin I don't think this is necessary, I already have a trivial fix for #216390 ready


feat: detect changes gift cards

What

Implements detect changes and show notification pattern in manage gift card
revamps domain to use same "form pattern" as used in the product domain

Note

Dependant on https://github.com/medusajs/admin/pull/362
Draft status until fixes to notification service has been made to all related PRs

Closing and reopening using new approach + cleanup of gift card domain


Support templ debug mode

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 127 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.9%) to 3.03%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

main.go
0
127
0.0%

Files with Coverage Reduction
New Missed Lines
%

main.go
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
9

Relevant Lines:
297

💛  - Coveralls


Revise strategy to support zero-copy on Linux and handle out-of-order zero-copy completion intervals

This PR significantly revises the implementation to support zero-copy on Linux, but retains the general structure of the original proposal.

ntsa::ZeroCopy::to() is renamed to ntsa::ZeroCopy::thru() to hopefully emphasize that it is inclusive (i.e. ntsa::ZeroCopy represents a closed range)
ntsa::ZeroCopy::code() has been changed to ntsa::ZeroCopy::type() that returns a new enumeration, ntsa::ZeroCopyType::Value, for readability and consistency with the rest of the library
The zero copy threshold is now configurable in per-socket options, as well as a default option in ntca::InterfaceConfig
ntsa::SendOptions already contains a new flag indicating that a zero-copy sendmsg should be tried, now ntsa::SendContext contains a flag that indicates whether it was actually performed
Handling ENOBUFS is pushed down into ntsu::SocketUtil::send. When a zero-copy sendmsg fails with ENOBUFS it is automatically retried as a traditional sendmsg. Whether or not a zero-copy was actually initiated is now indicated in the ntsa::SendContext output parameter.
Separate code paths for ntci::Sender::send with and without a callback have been merged into one code path
The send path of ntcr::DatagramSocket and ntcr::StreamSocket has been greatly simplified leveraging the previous changes
Timestamping and zero-copying can now all be changed during the operation of an ntci::DatagramSocket and ntci::StreamSocket, not just at the time of their construction
ntcq::SendCallbackQueueEntry has been removed and we now simply store ntci::SendCallback in a ntcq::SendQueueEntry.
The zero-copy data structure has been renamed from ntcq::ZeroCopyWaitList to ntcq::ZeroCopyQueue and had its interface modified to support the following necessary cases/requirements: a) Sending a bldbb::Blob may require multiple sendmsg calls (and often does), b) Some sendmsg calls for the same bdlbb::Blob may zero-copy and others may not, c) We need to know when no more zero copy counters for a send operation are expected to be forthcoming (see ntcq::ZeroCopyQueue::frame()), d) the send callback (if any) must be invoked exactly once, e) the ntsa::Data must be stored while all zero-copy operations that source it are pending in the Linux kernel.
Zero-copy counters may complete out-of-order so we need to handle complex splits of the expected zero-copy intervals  that reference an ntsa::Data (see ntcq_zerocopy.t.cpp test case 13)
To simplify the math computing zero-copy interval set intersection and difference, ntcq_zerocopy transforms the 32-bit zero copy counters in ntsa::ZeroCopy into a 64-bit range, detecting 32-bit wraparound as necessary
To cause the kernel to respect MSG_ZEROCOPY as a flag to sendmsg, we must first set a SO_ZEROCOPY socket option. But that option may only be set for TCP sockets that are in the default state (i.e., not after the socket is connected). To respect this ntsu::SocketUtil::create now sets the option automatically for IPv4 and IPv6 sockets.

Do not merge this PR to your PR until we have a conversation so I can walk you through this.

ntcr::StreamSocket
Let's remove d_receiveCount as it is unused. And let's remove
    void privateFail(const bsl::shared_ptr<StreamSocket>& self,
                     const ntca::ErrorEvent&              event);

as it is also only declared and not implemented (as we are trying to refactor the code within this PR)


updates mix lock

Hello, @ljcastroLemons! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.


Core dump when trying to download models

Issue: when I try to download the models on a jetson nano, it doesn't finish with an Illegal instruction (core dumped) as it's only output.

Hi! One possibility is that the nano is running out of memory. Could you please try downloading a single model instead of all of them, for example:
python3 utils/download_models.py --model_name inception_v4 --csv_file_path <path-to>/benchmark_csv/nx-benchmarks.csv --save_dir <absolute-path-to-downloaded-models>


Allow configuration for http client retry

Configuration of the number of retries that are tried should be configurable. Currently it is hard coded to 3.
https://github.com/cerner/beadledom/blob/master/client/resteasy-client/src/main/java/com/cerner/beadledom/client/resteasy/BeadledomResteasyClientBuilder.java#L345-L348

Closing since the client was deprecated in #177


fix: update terser and the plugin to fix perf regression

Fixes https://github.com/webpack/webpack/issues/17322
Summary

🤖 Generated by Copilot at 3c3fb09
This pull request improves code minification and optimization by upgrading terser and terser-webpack-plugin in package.json. This fixes some bugs and boosts performance.
Details

🤖 Generated by Copilot at 3c3fb09

Update the terser and terser-webpack-plugin dependencies to the latest versions (link, link)

Updated it to latest version in https://github.com/webpack/webpack/pull/17576

close in favor https://github.com/webpack/webpack/pull/17576


Cannot find module 'appdmg'

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.0.0-beta.63
Electron version
v17.4.0
Operating system
12.3.1
Last known working Electron Forge version
No response
Expected behavior
I am trying to build a dmg installer. I install the package and expected it to work since the documentation you provided is pretty limited.
Actual behavior
I installed  @electron-forge/maker-dmg then I installed appdmg and verified it was installed but now I still get this error.
`
An unhandled error has occurred inside Forge:
An error occured while making for target: dmg
Cannot find module 'appdmg'
Require stack:

/Users/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Error: Cannot find module 'appdmg'
Require stack:
/Users/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:999:19)
at require (node:internal/modules/cjs/helpers:102:18)
at build (/Users/user/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js:121:10)
at MakerDMG.make (/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/maker-dmg/src/MakerDMG.ts:32:18)
at /Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/src/api/make.ts:217:31`

Steps to reproduce
Project is Opensource and main is the lastest
https://github.com/jgunzelman88/PokeTrax
just run npm run make
Thanks for the help!!
Additional information
No response

Cannot find module 'appdmg'

I've faced with the same issue. It works without any problem for a while.

Same issue here. Any fix ? Adding appdmg as dev dependency result in node-gyp error.

My workaround is to specify python version for GitHub action:
- uses: actions/setup-python@v4
  with:
    python-version: '3.10'

Thanks to https://github.com/electron/forge/issues/2176#issuecomment-811450489 I removed package-lock.json to fix github build action. This is also related to #2176 .

My workaround is to specify python version for GitHub action:
- uses: actions/setup-python@v4
  with:
    python-version: '3.10'

Using Python 3.11 instead of the bundled Python 3.12 fixed it for me using the macos-11 runner with GitHub actions. (My relevant commit that fixed it for reference.)

This was driving me crazy today trying to track down. Thanks for posting this @dtcooper. Locking in Python 3.11 did the trick

Glad it helped! @blee-tetrascience :)

I've resolved this issue on macos-latest by adding python3 -m pip install setuptools at the first step.
    steps:
      # https://github.com/electron/forge/issues/2807
      - run: python3 -m pip install setuptools

      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          node-version: 20
      - run: npm ci


TypeError: Cannot read property 'start' of undefined

Hello fekt, I tried your giveaway command on my DiscordJS bot (in V12) and I have an error that I don't understand: "TypeError: Cannot read property 'start' of undefined". Thank you for answering me :)
Thanks, Spooky

Well that error could have only occurred if you hadn't installed the "discord-giveaways" package or if you changed the name of "GiveawayManager" in the index file/command file.

Closed due to inactivity.


TEAMNADO-3212 list activation keys in the red hat connector dashboard

This adds a activation keys table to the app. A generic error page is shown if the table fails to load.
For local testing the app can be run with PROXY=true npm run start:beta
and then visited at https://stage.foo.redhat.com:1337/beta/settings/connector/activation-keys

Codecov Report

Merging #34 (18b66c1) into master (2b2ef7d) will increase coverage by 5.96%.
The diff coverage is 36.61%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   11.86%   17.83%   +5.96%
==========================================
  Files          34       40       +6
  Lines         337      370      +33
  Branches       51       57       +6
==========================================
+ Hits           40       66      +26
- Misses        288      291       +3
- Partials        9       13       +4

Impacted Files
Coverage Δ

src/App.js
0.00% <0.00%> (ø)

src/Components/ActivationKeys/index.js
0.00% <0.00%> (ø)

src/Components/ActivationKeys/no-access.js
0.00% <ø> (ø)

src/Components/Authentication/Authentication.js
0.00% <0.00%> (ø)

src/Routes.js
0.00% <0.00%> (ø)

src/Routes/Dashboard/index.js
0.00% <ø> (ø)

src/hooks/useRbacPermissions.js
0.00% <0.00%> (ø)

src/hooks/useUser.js
0.00% <0.00%> (ø)

src/utils/platformServices.js
0.00% <0.00%> (ø)

...ponents/ActivationKeysTable/ActivationKeysTable.js
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2ef7d...18b66c1. Read the comment docs.


Fake bold in hero text

Fira Sans (and I’m so glad you used Fira instead of Open) looks hideous due to a missing weight call.

What exactly would you suggest? The current one is the same as font-weight: 700 would be.


Server crash trying to filter osmium ore with digital miner

Steps to reproduce:

Place Digital Miner in creative mode
Right click on machine
Hit Config button
New Filter
Material
Put Osmium Ore in both left and right slot
Hit Save
Server crashes and client disconnects!

Here is the stack trace.
I realize that's probably not the correct way to use it, but crashing the entire server which takes a minute to start up again is not optimal :)
Minecraft: 1.9.4
Mekanism: 1.9.4-<IP_ADDRESS>2
Forge: 1.9.4-<IP_ADDRESS>6
MCMultiPart: 1.3.0
No other mods

OK, first off, you are trying to replace the mined ore with itself. The left slot is what ore to mine, the right slot is the optional block to replace it with.
Looking at your log, my best guess is that the server is crashing trying to save an invalid filter config. Most likely the code is missing a check for this situation.

if you realized it was not the correct way to use the machine then why do it? If you are doing it for bug testing then fine.

I didn't realize the first time until it crashed the server. I reproduced and reported here because I figured others might have the same experience.

Should be fixed in latest release


Bugfix - roles error with global header enabled

Summary
in the last days we had some problems with our test-servers not showing a login screen because of a javascript error. In the global header we were accessing the currently logged in user (although there was none) and that resulted in breaking the application.
The root cause for this is that the global header is rendering regardless if a user is logged in pr not. Re-arranging the components in root.jsx did not really work out due to our current routing structure.
the solution for now is to prevent rendering of the global header inside the global header component, by utilizing a new hook useIsLoggedIn.
this PR also reverts changes made in #8781 and #8791
Ticket Link
NONE

Release Note
NONE

Cherry pick is scheduled.


How to retrieve simulation start time

I would like to retrieve the simulation start time for the case of cap_restart present at the start of the run. I notice ESMF_ClockGet returns BEG_DATE in CAP.rc rather than simulation start date. however, the start time in cap_restart should be available since it is stored in cap%cap_restart_time. Is there an easy way to access this from any gridded component in any timestep without reading CAP.rc again?
For reference I am trying to extract the start time here. I want to use to compute an accurate elapsed time.
This issue is somewhat related to https://github.com/GEOS-ESM/MAPL/issues/506.

Hmm.   I don't really like the idea of accessing the Cap or the CAP.rc file from other components; encapsulation and all that.
Better would be to attach this to the clock and then get it from there.
@bena-nasa  My knowledge of clocks and alarms is only large enough to be dangerous.  Does a solution suggest itself to you?

Thanks for the quick reply. In the meantime I have a work-around of setting a local saved ESMF_Clock variable equal to current time in the first timestep. Perhaps this is the best way to go?

@lizziel When Cap creates the clock, it creates the clock start/end based on the BEG_DATE and END_DATE in the CAP.rc
It then looks if there is a cap_restart and set the current time of the clock to the date in the cap_restart.
Unfortunately there's nothing special about this time nor do we to my knowledge do anything in the lock to store the fact this was the real model start time, the the clock start time.
If you want to access, the actual start time in any gridded component, at any time, you would have to query cap_restart or we need to add a decoration to the clock to record this.


Update KDFS links to v1.3.

v1.3 of KDFS has just been published and all previous versions deprecated. This version has full documentation for PVRTC2 so I figured you'd like to update your links.

Got it - thanks!


Doc: manage data table row selection style dynamically and enhance doc

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
In our designs, when a row is selected in a data table (with a checkbox), the line background changes:

Some js could be added in documentation to manage it dynamically (would be clearer) and documentation should be updated and completed, since it doesn't mention the .table-active class to add to have this style.
Motivation and context
The style exists but it does not work dynamically and the doc is not really helpful on this point...

Hi, how can i help with this issue?

Hi @Dojacom
Everything's in the description, you could try to create a PR to tackle it. Don't hesitate to ask some precisions before starting if needed.

@julien-deramond
Thanks for the opportunity.
If i may ask please, how do i get started?
Where to locate the file or am i to create another?

If i may ask please, how do i get started?

You have information to get started both in the README.md and in the CONTRIBUTING.md files.

Where to locate the file or am i to create another?

For this specific issue, as mentioned in the description, some JS should be added in the documentation (but probably not in the framework). Markdown files in the repository follow the same architecture/path as in the deployed documentation. The corresponding page is mentioned in the description.


fixes and improves plugin dragdropselected

Tighter and neater code
Removed weird selection during drag
Left-ctrl+drag works if gnome's "ctrl to show mouse" is turned off
Added sticky mode to help against finger fatigue
Copied selections can now be placed adjacent to the original selection
Press Esc to abort a begun action
Added toggles for settings GUI to enable/disable plugin and sticky mode during runtime

Edit:

Selects copied/moved portion after action
Updates manifest.json

Edit2:

Multiple selections are handled

I noticed two things while working on this:

sometimes when a lot of scrolling is involved, the dragged selection isn't dropped where user would expect. Sometimes many lines off. Happens both when dragging or using sticky mode.
Doc:get_selection_text() returns each part on its own line. Mostly that is fine. In below scenario, user might be a bit surprised:

to get:

instead of:

IDK what would break if Doc:get_selection_text() was changed to return items on same lines delimited with spaces instead of NL.

sometimes when a lot of scrolling is involved, the dragged selection isn't dropped where user would expect. Sometimes many lines off. Happens both when dragging or using sticky mode.

What do you mean? I can drag a word from the end of an 800 lines doc to the first page without issues.

Doc:get_selection_text() returns each part on its own line. Mostly that is fine. In below scenario, user might be a bit surprised:

You could either implement your own get_selection_text, or you could replace newlines with spaces in the returned string.

What do you mean?

I don't know how to explain it more clearly. Sometimes dragged text does not insert where mouse was released.

You could either implement your own get_selection_text

sure, I 'could', question is, would it break anything if that was default behaviour.

you could replace newlines with spaces

that won't work, users who have used this feature in other text editors expect items from different lines to appear on different lines and items from same lines to be separated by spaces. (At least that's what I remember some of my previous editors to do)

You could either implement your own get_selection_text

sure, I 'could', question is, would it break anything if that was default behaviour.

you could replace newlines with spaces

that won't work, users who have used this feature in other text editors expect items from different lines to appear on different lines and items from same lines to be separated by spaces. (At least that's what I remember some of my previous editors to do)

I mean, just create your custom function that has the enhanced functionality you want get_selection_text to have.

Would you merge the swapped commit too?

I don't intend to. Didn't have any effect and now the code scans all selections anyway.
Am I misunderstanding something?

Video del 2023-06-20 02-35-04.webm
Also seems like this now adds a caret when you release on the selection itself.

Unfortunately I can't get any screen-grabs to work on this machine.

disable dragdropselection plugin
select with mouse/keyboard from right to left -> at end of selection (on left) there is a caret
select from left to right -> at end of selection (on right) there is a caret

To me this seems reasonable and wanted behaviour. It lets user know which way they were selecting even if they were interrupted for a long period.
This plugin does not change any of that.
When dropping dragged text, caret is at the position where mouse was released -> top left of new selection. This also is wanted behaviour.
Picture this scenario:

User selects 42+ times his screen height worth of text
Drags it to the insertion point and releases

If the caret were to be placed at end of selection, this would trigger a massive scroll event or an abrubt jump to end of pasted text. This may be wanted when using keyboard ctrl-c & ctrl-v to paste text. Here user knows exactly where insertion point is.
With mouse however, user wants a confirmation that they didn't slip while releasing.
Having document stay put where user let go of mouse is better UX IMO.
User can then with one keystroke arrive at end of selection (right arrow), if that is what they want.
I'm not sure I understood your issue with this behaviour, so I'm trying to elaborate and figure it out. To me it feels natural and correct.
If I'm missing your point, be so kind and try to describe your issue in more detail.

Also seems like this now adds a caret when you release on the selection itself.

I have debugged that and confirmed that there is no extra caret added.
https://github.com/SwissalpS/liteXLplugins/tree/fixDragDropSelectedDebugCaret

Look at the video. I select left to right, but the instant I start the grab, the selection goes right to left.

I have debugged that and confirmed that there is no extra caret added.

I can't test again at the moment. Will test again later and post a video if I can still reproduce the issue.

Look at the video. I select left to right, but the instant I start the grab, the selection goes right to left.

Yes, I don't see anything wrong with that.
The user is made aware of what to expect selection to look like when they release.

Every other text editor I tested puts the caret at the end, but most importantly they don't change the orientation of the selection when the drag starts.
You're thinking about the user wanting to put the selection after something, but the whole discourse is valid also when the user wants to put the selection before something. That's why I think leaving the caret where the user left it is the better UX.
About the added selection bug:
Video del 2023-06-21 06-17-25.webm

Every other text editor I tested puts the caret at the end

Some do, yes and it is annoying but not as annoying as those that remove caret entirely.

You're thinking about the user wanting to put the selection after something,

nope, I'm thinking of inserting above, below or between selections. In particular how page scroll update can be confusing. Leaving carret at beginning of inserted portion is calmest.

About the added selection bug:

Thanks for clarifying, I'll look into that, maybe I didn't test non-sticky mode enough.

OK, stray caret is gone and carets of selections are preserved where user put them, but I'm not going to scroll to end of newly inserted selection. If user wants to jump there, he can do so with one keypress.

Last few things: should cancelling the drag with escape keep the original selection?
It might be a good idea to have the escape action a command, mostly to allow changing the keybind. I know keymaps are on keypress and not on release, but it should be fine for this use-case.
Also we should probably disallow writing while dragging, or we should cancel the drag on text input.

thanks

the escape idea is good will look into it
disabling text input during drag, yes. It'll have to allow keystrokes though or escape won't work
a friend told me to add setting as to where user wants the carret to be after insert. I'm not sure it's worth the extra code. I would add three options: a) at top-left (current) b) at bottom-right (like libre office) c) use the position of the dragged portion. What do you think about that?

disabling text input during drag, yes. It'll have to allow keystrokes though or escape won't work

Overriding DocView:on_text_input might be enough.

a friend told me to add setting as to where user wants the carret to be after insert. I'm not sure it's worth the extra code.

I'm fine with it. In the end it's your choice tho.

I've implemented the suggestions.
There is a side-effect though to having the abort procedure be a command: now user can't escape out of autocomplete suggestions :/
to test use this branch
There is one other quirk I want to try and fix in this PR
When clicking on the right side of a selection (multiline shows it best), way out in non-text area, the click is registered as in the selection.
This is only a problem with sticky mode enabled.

There is a side-effect though to having the abort procedure be a command: now user can't escape out of autocomplete suggestions :/ to test use this branch

Instead of using the predicate "'core.docview'", use a function that checks core.active_view.dnd_sText or something like that.

yes, thanks, I just figured that out too :)

offtopic: while tracking down the error, I noticed that disabling the contextmenu plugin does not seem to have any effect at all (after re-launching lite-xl)

just noticed something I want to tweak before merge

Is there already a mechanism implemented in lite-xl to allow system-wide drag events?
All I have seen is file-dropping into lite-xl.
In other projects it was easiest to implement inter-view dragging by using system events. Saves time maintaining code for the two distinct event types.
If there is no system-wide drag event built in or planed to be built in, I might find the time to refactor the code to work between views of the same lite-xl instance.

We plan to have an internal dnd system (I have a prototype already, next week I'll finally have time to dedicate to it), and eventually make it support system-wide events.
For the system-wide part, SDL only supports receiving file dropped events iirc, so I'll have to open a feature request/PR for SDL to implement the rest.
That'll be exclusive to SDL3, so to actually make use of it we'll have to first move to SDL3 (which is also planned).


Fix typo in README.md

Just a quick typo fix, 'deprecation' was spelled wrong on two lines.

Thanks for the spot. The readme has changed so type gone already


Integration fails with simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I've just upgraded to v1.5.6 and got my TV unavailable with this message in my logs:
Logger: homeassistant.helpers.entity
Source: custom_components/samsungtv_tizen/smartthings.py:40
First occurred: 1:02:06 (18 occurrences)
Last logged: 1:06:24

Update for media_player.samsung_tv fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/util/__init__.py", line 239, in wrapper
    result = method(*args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/util/__init__.py", line 239, in wrapper
    result = method(*args, **kwargs)
  File "/config/custom_components/samsungtv_tizen/media_player.py", line 424, in update
    smartthings.device_update(self)
  File "/config/custom_components/samsungtv_tizen/smartthings.py", line 40, in device_update
    data = resp.json()
  File "/usr/local/lib/python3.8/site-packages/requests/models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/simplejson/__init__.py", line 525, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.8/site-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/usr/local/lib/python3.8/site-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Trying to get it working by rolling back to previous versions. I will be grateful for any tip to get it back working.

@Screwdgeh oh boy, we broke it

@denysdovhan what version were u previously using?

@denysdovhan also, is there anything special about ur network setup? does HA have access to the internet?

UPD: I rolled back to v1.5.4 and it fails as well (I get the same error). It's strange because it seems to be working before.
I was using 1.5.4. Yes HA has access to the internet since all of my other integrations work perfectly. I mean those integrations that require access to the outer world.

we made an update that downloads the channel logo paths from an online source: https://jaruba.github.io/channel-logos/logo_paths.json
(where we keep the channel logo paths updated based on TMDB data + image post-processing)
before that we hardcoded the channel logo paths in a file with the component.
I think that v1.5.3 is pre-channel logos.. unless i'm wrong and this has nothing to do with channel logos.. did not check your logs thoroughly yet.

wait.. this has nothing to do with the channel logos, you're getting an error from smartthings.device_update(self)
there's something wrong with the smartthings API for you.. check your smartthings credentials

i think you can even update to the latest version again, but you need to try to reset your credentials from smartthings, there is a discussion here with various users that needed to reset smartthings due to different issues, maybe it can help you also: https://github.com/jaruba/ha-samsungtv-tizen/issues/77

Yeah, that was a problem on my side. My TV had DNS wrong settings. It used to point to my AdGuard Home DNS which was blocking access to the Smart Things services.

@denysdovhan I'm happy you got it working again, I'm also very happy that the channel logos feature wasn't to blame. 😅

Thanks for pointing me in the right direction!


Ian Campbell: Watch vk7-advertising.business

Ian Campbell requests the watch of the watch_keyword vk7-advertising\.business. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vk7-advertising\.business has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Rejected by Mast in Charcoal HQ. Reason: 'Duplicate of existing watch.'


Introduce ConnectClerk

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[x] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[x] @clerk/remix
[ ] @clerk/types
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

This PR introduces small but important changes to the setup process our users need to follow in order to integrate Clerk in a Remix project.
Before this PR, the recommended root.tsx file would look like:
import { ClerkProvider } from "@clerk/remix";
import { rootAuthLoader, WithClerkState } from<EMAIL_ADDRESS>
export const loader: LoaderFunction = (args) => rootAuthLoader(args, ({ auth }) => {
  const { userId } = auth;
  const posts: Posts[] = database.getPostsByUser(userId);
  return posts;
});

export default function App() {
  const { data: posts, clerkState } = useLoaderData<WithClerkState<Posts[]>>();

  return (
    <ClerkProvider frontendApi={"clerk.renewing.hermit-14.lcl.dev"} clerkState={clerkState}>
      <html lang="en">...</html>
    </ClerkProvider>
  );
}

This approach however, has 2 major drawbacks:

The user needs to explicitly pass clerkState to the ClerkProvider
In the specific edge cases where the interstitial page needs to be used, the user defined data returned from useLoaderData would be undefined. Since we cannot throw the interstitial from the loader directly, we use ClerkProvider instead. However, If the user used the undefined data before ClerkProvider handlers the interstitial, the app could break. Many thanks to @dvargas92495 who also reported this in #54

In order to solve both issues, we're introducing a ConnectClerk HOC that can be used as such:
export const loader: LoaderFunction = (args) => rootAuthLoader(args, ({ auth }) => {
  const { userId } = auth;
  const posts: Posts[] = database.getPostsByUser(userId);
  return { posts };
});

function App() {
  const { posts } = useLoaderData<{ posts: Posts[] }>();
  return (
    <html lang='en'>
      ....
    </html>
  );
}

export default ConnectClerk(App, { frontendApi: '...' });

Notice that the user no longer needs to manually use ClerkProvider or manually pass clerkState to ClerkProvider. Also, now we can handle the interstitial state before any user-defined code is run.
Lastly, rootAuthLoader now requires either a Response or an object to be returned from the callback, if one is provided . This greatly simplifies how useLoaderData is used in the root App component. We updated the types accordingly so we now throw but on compile and on runtime if this rule is not respected:

Fixes #54

this works for me!


chore: add verify script

Adds a very simple verify script that I recently added to my own project.
The Greeter example verifies automatically for some reason but the contract I built did not. I figured it might be something worth adding to the template since verifying is expected nowadays, right? :)

I agree that going for a separate bash file might have been too much. My project used a couple more constructor arguments which bloated the Makefile IMO. That's why I went with a separate file for that.
But, I do think that adding the verify command to the existing abstraction layer makes sense. Since currently, everything is abstracted. We don't access the dapp command anywhere directly. And, since we have to specify the ETH_RPC_URL env variable it's nice that we can use $call(network,name) for that. Makes it way easier than copy-pasting the URL from somewhere
# direct call
ETHERSCAN_API_KEY=<key> ETH_RPC_URL=<url> dapp verify-contract src/Greeter.sol:Greeter <contract-address>

# make call
contract_address=<address> network_name=<name> make verify

I've updated the PR to call dapp verify-contract in the Makefile instead of using a separate bash file.


find mem leak by valgrind

hi:
I have used the parser tool, and it is very cool. It help me very much.
I found a problem when I used valgrind to test it, and find mem leak. It is show in pic below:

I try to find it, but I am not good at it. So, I hope you and help me.
Yours
Thanks.

Thank you , I will have a try with valgrind !

I found a possible memory leak indicated by Xcode's static analysis but I haven't yet had time to examine the logic to make sure any fix would keep the expected behaviors.


Change "Application" to "Interface" in Readme.

WIthout this change the title in the readme reads suggests the acronym should be Clant, at first glance.

✨🍰✨


feat: store distance scores in scores dict

Signed-off-by: anna-charlotte<EMAIL_ADDRESS>Goals:
Milvus: Store distance scores in a Document's .scores dictionary, under the key 'score' to enable accessing those scores.

[ ] check and update documentation, if required. See guide

Codecov Report
Base: 86.36% // Head: 42.61% // Decreases project coverage by -43.75% :warning:

Coverage data is based on head (a79546f) compared to base (67209b8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #873       +/-   ##
===========================================
- Coverage   86.36%   42.61%   -43.76%
===========================================
  Files         138      138
  Lines        7116     7122        +6
===========================================
- Hits         6146     3035     -3111
- Misses        970     4087     +3117

Flag
Coverage Δ

docarray
42.61% <0.00%> (-43.76%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Docker image non-root UID doesn't match

Type of issue
Typo
Description
The doc doesn't match the actual port. Which is 1654. Please see PR #4715
Current it says:

NET 8 adds an environment variable for the UID for the non-root user, which is 64198

But it should say:

NET 8 adds an environment variable for the UID for the non-root user, which is 1654

Page:
https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8/containers#non-root-user
Thank you!
Page URL
https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8/containers#non-root-user
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/whats-new/dotnet-8/containers.md
Document Version Independent Id
e9820016-a64e-4f99-0c32-67c150075fa7
Article author
@gewarren
Metadata

ID: 0dbbb102-a5ba-7f0b-ca91-a4dc5bb6ebe1
Service: dotnet-fundamentals

@gewarren I will work on this.


Remove dependency on unordered-containers

This lightens the dependency footprint of
diagnose by dropping the dependency on
unordered-containers.

This dependency removal seems less clear than the others. Some sort of Map is what’s desired here, so implementing the relevant functions locally on top of [] seems like the wrong way to go.
Maybe an argument could be made to use a Map (probably lazy?) from containers instead, since it’s already in the dependency graph and included with GHC anyway?
But restricting existing [] to NonEmpty when possible seems like a good change.

If it's just groupOn, then I would prefer a local implementation (or one imported from a lightweight library like extra), to using unordered-containers, but that's very much a personal preference. You can close this issue if you prefer another side of the trade-off :)

Hello, sorry for the long silence.
I don't really know why I used unordered-containers in the first place, where it is used now. It most likely came with a bit more usage here and here, which I may have removed over the years.
Now the remaining uses of HashMaps do not really rely on the invariants of the structure itself: using Map instead of HashMap everywhere should not pose a problem. Not sure if those maps should be lazy or not though. It may perhaps be better for the map storing file contents, but not for those storing markers in the rendering.


NLog can not write File and window Event

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
For .NET Core users, please check the platform support: https://github.com/NLog/NLog/wiki/platform-support

Bug

NLog version: 4.2.3
Platform: ..NET Core
Current NLog config (xml or C#, if relevant)
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    autoReload="true"
    internalLogLevel="Warn"
    internalLogFile="C:\git\damienbod\AspNetCoreNlog\Logs\internal-nlog.txt">

  <targets>
    <!-- write logs to file -->
    <target xsi:type="File" name="allfile" fileName="D:\nlog-all-${shortdate}.log"
                layout="${longdate}|${event-properties:item=EventId.Id}|${logger}|${uppercase:${level}}|${message} ${exception}" />
    <target xsi:type="File" name="ownFile-web" fileName="D:\nlog-own-${shortdate}.log"
             layout="${longdate}|${event-properties:item=EventId.Id}|${logger}|${uppercase:${level}}|  ${message} ${exception}" />
    <target xsi:type="Null" name="blackhole" />
<target name="eventlog" xsi:type="EventLog" layout="${message}" log="Application" source="My Web API Application" />
  </targets>
  <rules>
    <!--All logs, including from Microsoft-->
    <logger name="*" minlevel="Trace" writeTo="allfile" />

    <!--Skip Microsoft logs and so log only own logs-->
    <logger name="Microsoft.*" minlevel="Trace" writeTo="blackhole" final="true" />
    <logger name="*" minlevel="Trace" writeTo="ownFile-web" />
    <logger name="*" minlevel="Trace" writeTo="eventlog" />
  </rules>
</nlog>

And here is my controller code,and i also change file permission, Still facing the issue
NLog.Logger _Logger= LogManager.GetCurrentClassLogger();
            _Logger.Info("Hello i m executing");

Though i am not getting file with written log

You need the NLog.Extensions.Logging package (NuGet link) for .NET Core and enable NLog in startup.cs:

public void Configure(IApplicationBuilder app,
                      IHostingEnvironment env,  ILoggerFactory loggerFactory)
{
  //add NLog to ASP.NET Core
  loggerFactory.AddNLog();

  //configure nlog.config in your project root
  env.ConfigureNLog("nlog.config");

  ...

For more information, see the GitHub page

Any luck with this?

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info.


English dictionary items is empty

The dictionary items is inserted in Umbraco on installation, but isn't translated into English

Sorry for delay.
English is the default language.
If you want to customize the text, you can do it modifing the English Translations.
In the next release I'll set also the english language items


FitToCoordinates not working on MapView.Animated

For an animated mapview, I was not able to call FitToCoordinates, the error says it is not a function. is that the expected behavior?

 this.refs._MapView.fitToElements(true);

It still does not work, or would you be more clear about where to call this or how to incorporate it with FitToCoordinates?
My ref is set to this.map and when I do this.map.fitToElements(true); or this.map.fitToCoordinates(), neither works.
The error says that this.map.fitToElements or this.map.FitToCoordinates is not a function.

it not this.map.fitToElements(true)
this.refs.map.fitToElements(true)

https://github.com/airbnb/react-native-maps/issues/896 These are possibly related

@LubinPark I'm not sure if thats how you access the ref sir.. As I said I assign the ref to this.map. Btw I tried it and still doesn't work.

this.refs._MapView.fitToElements(true);
it work,
![pasted graphic 1](https://cloud.githubusercontent.com/assets/18719819/23933822/1ca6a74a-097c-11e7-94da-a6198bcb2e5f.png)
![pasted graphic 2](https://cloud.githubusercontent.com/assets/18719819/23933939/de1c3804-097c-11e7-8c62-d03bf22a9419.png)
![1](https://cloud.githubusercontent.com/assets/18719819/23933940/e2503a74-097c-11e7-80ba-49302f64e41b.gif)
 if no mistake, may be other problems

MapView ref="MapView"
this.refs._MapView.fitToElements(true);
it work,
if no mistake, may be other problems

I also have a question,it only show user location button, how to get their current geographical position

@LubinPark Are you using  or <MapView.Animated>? Can you post your MapView code?

<MapView ref="_MapView"
mapType='standard'
style={styles.mapView}
rotateEnabled={true}
scrollEnabled={true}
zoomEnabled={true}
showsCompass={true}
showsBuildings={true}
showsUserLocation={true}
region={this.state.region}
loadingEnabled={false}
showsMyLocationButton={true}
followsUserLocation={this.state.followsUserLocation}
               onPress={(value)=>this._showLocation(value)}
               onRegionChangeComplete={(value)=>this.onRegionChangeComplete(value)}>

I see. It's MapView, this issue is related to MapView.Animated.
FitToCoordinates and fitToElements do work for the original one, this issue here concerns about the animated one. Thanks anyway! :)

Try with getNode() like this this._mapRef.getNode().fitToElements(true);

this._mapRef._component.fitToElements(true); will also work.


Conversation trouble when logout  flow was not ended then a login flow started with the same execution id

Hi,
I'm facing a issue about cas logout/login flow. I'm using CAS protocol 3 with cas version 4.0.
I got the following error :

2015/10/19 10:43:01.007 [http-bio-8082-exec-1351] ERROR c.b.p.c.l.MDCServletFilter - 9a7d418c026b46079ec53dcbd036ed45 - Exception thrown but not catched : Request processing failed; nested exception is org.springframework.webflow.definition.registry.NoSuchFlowDefinitionException: No flow definition 'logout' found org.springframework.webflow.definition.registry.NoSuchFlowDefinitionException: No flow definition 'logout' found
        at org.springframework.webflow.definition.registry.FlowDefinitionRegistryImpl.getFlowDefinitionHolder(FlowDefinitionRegistryImpl.java:126) ~[spring-webflow-2.3.2.RELEASE.jar:2.3.2.RELEASE]
        at org.springframework.webflow.definition.registry.FlowDefinitionRegistryImpl.getFlowDefinition(FlowDefinitionRegistryImpl.java:61) ~[spring-webflow-2.3.2.RELEASE.jar:2.3.2.RELEASE]
Wrapped by: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is org.springframework.webflow.definition.registry.NoSuchFlowDefinitionException: No flow definition 'logout' found
        at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:948) ~[spring-webmvc-3.2.6.RELEASE.jar:3.2.6.RELEASE]
        at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:838) ~[spring-webmvc-3.2.6.RELEASE.jar:3.2.6.RELEASE]

I can reproduce the bug with the following
I post my authentication form /cas/login. All is OK. I take the jsessionid
Then I post /cas/logout?service=XXXXX with the same jessionid. The logout-webflow was triggered The conversation with key e1s1 was started and stop at the logoutView state (so the conversation is not ended). The session is not destroyed.

2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.e.ViewState - 4763a78ecfcf408a89802d9b360b2254 - Entering state 'logoutView' of flow 'logout'

2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.c.i.SessionBindingConversationManager - 4763a78ecfcf408a89802d9b360b2254 - Putting conversation attribute 'name' with value logout
2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.c.i.SessionBindingConversationManager - 4763a78ecfcf408a89802d9b360b2254 - Putting conversation attribute 'caption' with value null
2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.c.i.SessionBindingConversationManager - 4763a78ecfcf408a89802d9b360b2254 - Putting conversation attribute 'description' with value null
2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.c.i.SessionBindingConversationManager - 4763a78ecfcf408a89802d9b360b2254 - Putting conversation attribute 'flowExecutionSnapshotGroup' with value org.springframework.webflow.execution.repository.impl.SimpleFlowExecutionSnapshotGroup@3fe47a6e
2015/10/25 07:29:08.077 [http-apr-8080-exec-3] DEBUG o.s.w.e.i.FlowExecutionImpl - 4763a78ecfcf408a89802d9b360b2254 - Assigned key e1s1

If I try to post a /cas/login with the same session and the execution parameter set to e1s1. I got the previous error.

2015/10/25 07:30:44.628 [http-apr-8080-exec-8] DEBUG o.s.w.s.DispatcherServlet - b9980e160d044742b4b60f88cd22a675 - Last-Modified value for [/cas/login] is: -1
2015/10/25 07:30:44.628 [http-apr-8080-exec-8] DEBUG o.s.w.e.FlowExecutorImpl - b9980e160d044742b4b60f88cd22a675 - Resuming flow execution with key 'e1s1
2015/10/25 07:30:44.628 [http-apr-8080-exec-8] DEBUG o.s.w.c.i.SessionBindingConversationManager - b9980e160d044742b4b60f88cd22a675 - Locking conversation 1
2015/10/25 07:30:44.628 [http-apr-8080-exec-8] DEBUG o.s.w.e.r.i.DefaultFlowExecutionRepository - b9980e160d044742b4b60f88cd22a675 - Getting flow execution with key 'e1s1'
2015/10/25 07:30:44.628 [http-apr-8080-exec-8] DEBUG o.s.w.d.r.FlowDefinitionRegistryImpl - b9980e160d044742b4b60f88cd22a675 - Getting FlowDefinition with id 'logout'
2015/10/25 07:30:44.631 [http-apr-8080-exec-8] DEBUG o.s.w.c.i.SessionBindingConversationManager - b9980e160d044742b4b60f88cd22a675 - Unlocking conversation 1

It seems that conversationContainer used for a single session doesn't split login-webflow-conversation and logout-webflow ones.
It would be more safe if conversations are splitted by flow and logout conversations are cleaned up when a login-flow conversation started on the same CAS session.
My workaround is to replace
<view-state id="logoutView" view="casLogoutView" />
by
<end-state id="logoutView" view="casLogoutView"/>

Could you submit a PR with the fix?

Hi,
I didn't work on a definitive fix yet because it could be some side effects. I'll provide a PR later. I think also, even if it's not the root cause, that the logoutView state is not properly defined and should be an end-state as the conversation is finished when we access to the logoutView.
Don't you want I firstly provide a pull-request with this modification only?

yes that would be fine.
is there a reason you are grabbing the jsessionid ? the behavior your describe is expected.

before I reproduce the issue I executed the logout POST with a chrome extension to test differents cases. Particularly to check if It was bound to a non thread-safe session issue.

Cool. Look fwd to your PR.


macro implementations cannot have implicit parameters other than WeakTypeTag evidences

Hi, I tried to use some examples in https://github.com/softwaremill/magnolia/tree/scala2/examples/src/main/scala/magnolia1/examples with scala 2.13 but I got the compilation error below:
macro implementations cannot have implicit parameters other than WeakTypeTag evidences
  implicit def gen[T]: Print[T] = macro Magnolia.gen[T]

Did I miss out something or the issue is real?
Thanks in advance for your help.
Best regards,
Vu Hai

Hm did you use the exact same examples? They are part of the build so should work jsut fine. Can you post the full code that causes the problem?

HI thanks for the feedback, I found this discussion https://gitter.im/propensive/magnolia?at=5e82194b49e7a8130cdaf16b, turns out I just need to add  "org.scala-lang" % "scala-reflect" % "2.13.8" into my build.sbt   for it to work with scala 2.13.
But my current project do cross compilation for both scala 2.13 and 3 and there's no scala reflect for scala 3. I noticed that the method Magnolia.gen is removed and we use the syntax given .. with for scala 3 as well.
Is there a way to make it work for both version of scala? (it's a bit out of the initial context of this thread, let me know if you want to close this one and open a new one instead 😅 )
trait RandomObjectDerivation {
  type Typeclass[A] = RandomObject[A]

  def join[A](caseClass: CaseClass[Typeclass, A]): Typeclass[A] = new Typeclass[A] {
    def generate(): A = caseClass.construct(_.typeclass.generate())
  }

  def split[A](sealedTrait: SealedTrait[Typeclass, A]): Typeclass[A] = new Typeclass[A] {
    def generate(): A = choice(sealedTrait.subtypes).typeclass.generate()
  }

  def split[T](ctx: SealedTrait[Typeclass, T]): Typeclass[T] =
    new Typeclass[T] {
      def generate(): T = choice(ctx.subtypes).typeclass.generate()
    }

  private def choice[A](xs: Seq[A]): A =
    xs.toIndexedSeq(Random.nextInt(xs.length))

  implicit def gen[A]: Typeclass[A] = macro Magnolia.gen[A]
}

Yes, in Scala 3 you can use implicits or .derived. Though I don't think you'll be able to compile the same codebase using both Scala 2 and Scala 3, there are some (not very significant, but still) differences.
I suppose you'll need to have some sources scala2 and some scala3 specific (see e.g. tapir's core module): https://github.com/softwaremill/tapir

Awesome, I followed this tutorial https://docs.scala-lang.org/scala3/guides/migration/tutorial-macro-cross-building.html
I can compile my project with both scala 2.13 and scala 3 now. Thanks a lot for your help :pray:


Setting app:name with a beginning backslash breaks the change

If you set app namespace via
php artisan app:name '\Some\Namespace\MyApp'

will incorrectly set the namespace (to exactly what you passed it). But afterwards app:name throws ReflectionExceptions and fails, meaning if you don't have a git history this is a very intensive problem to fix.
Since this is a common way to represent namespaces, the app:name command should strip preceding backslashes if they are present.

You must not use a leading slash.

Since this is a common way to represent namespaces

It is incorrect. Classes are defined without a leading slash. Using one is incorrect.


Add script to guide developers through setting up their environment to allow locally debugging the Kubernetes Agent

Background
Previously we haven't had a nice way of debugging the Kubernetes Agent, and we never had a way to debug it locally. Looking forward we might have more people using the Agent so it's a good idea to formalise the process of how to setup a developers environment to allow for local debugging.
Results
I've created a script, along with a few small changes to the Tentacle code base to help guide engineers through the process of setting up their environment to locally debug the agent.
Caveats: It has only been tested on MacOS - updates are probably required for Windows and Linux.
Video Walk Through
https://octopus.zoom.us/rec/share/Az-ugVGNR8Mg7_WWZa8FCwiqg4nJwgDkVx9N41EbzaHNPFn9EcygVZwG51sY_skE.Q913692PVXEdOXG3?startTime=1727326867000
Passcode: &429gPqU

The only trouble I had was the fact that Rider didn't immediately use the target framework specified in the launchsettings.

Ah yeah actually I don't think that framework variable in the launchsettings is valid. I was trying it to see if it would work but I don't think you can set it from the launch settings file unfortunately. I'll remove the line from the launchsettings. I do have a log line on the last line of the script which says to check the run configuration because I was also having trouble with it 🤷♂


Adding encryption flag in volume config API

Encryption flag will be used to identify whether volume needs to be
encrypted or not.

The plan was to keep the encrypted set to true in zedagent till controller start filling it but we can also change encrypted to clear_text.

The plan was to keep the encrypted set to true in zedagent till controller start filling it but we can also change encrypted to clear_text.

With protobuf it is impossible to tell whether the sender set something (a bool, a string, an int, or anything) to a default value or did not set it at all. False, "", and zero are all encoded as nothing.

Updated the PR. Please take a look.


Optimistic updates typescript example does not work locally

Describe the bug
Trying to run the optimistic updates typescript examples in the example folder on my local machine gives the following error: Argument of type 'UseQueryOptions<Todos, AxiosError<any>, TData, QueryKey> | undefined' is not assignable to parameter of type 'Omit<UseQueryOptions<Todos, AxiosError<any>, TData, "todos">, "queryKey" | "queryFn"> | undefined'.
Your minimal, reproducible example
The optimistic updates typescript example in the examples folder
Steps to reproduce

Clone repository
Run yarn in the examples\optimistic-updates-typescript folder
Run yarn dev, open the browser

Expected behavior
The app runs like it does in the example in the docs
How often does this bug happen?
Every time
Screenshots or Videos

Platform
Windows 11 Home 21H2
Edge 98.0.1108.56 (Official build) (64-bit)
Yarn v1.22.15
NPM 6.14.15
Node 14.18.2
react-query version
Commit eb4e863cf44d30ef8b936068fce09f9632def68a (latest at the moment)
TypeScript version
No response
Additional context
No response

The example was built with react-query 3.5.1, which is why it works in codesandbox.
for the latest version, the options need to omit queryKey and queryFn:
function useTodos<TData = Todos>(
  options?: Omit<
    UseQueryOptions<Todos, AxiosError, TData>,
    "queryKey" | "queryFn"
  >
) {
  return useQuery("todos", fetchTodos, options);
}

I wouldn't make such an abstraction anymore, as it's pretty wide. I'll adapt the example for v4. The whole TodoCounter thing is unnecessary in v4 when tracked queries are the new default.

I fixed and simplified the example for v4: 61fd5397


Support Iterable return type for easier usage with Spring Data

Currently only Collection return type seems to be supported.
When using Spring Data, the repositories return Iterable<T>. Though at the moment we must use some code like this:
return StreamSupport
	.stream(repository.findAll().spliterator(), false)
	.collect(Collectors.toList());

Would be much nicer if we could just use this:
return repository.findAll();

As long you're using Jackson (the default), it's trivial to add this yourself.
//Custom mapper that maps an Iterable as if it were a List of the same generic type
public class IterableMapper extends AbstractTypeSubstitutingMapper {

    @Override
    public AnnotatedType getSubstituteType(AnnotatedType original) {
        return TypeFactory.parameterizedAnnotatedClass(List.class, original.getAnnotations(), getElementType(original));
    }

    private AnnotatedType getElementType(AnnotatedType type) {
        return GenericTypeReflector.getTypeParameter(type, Iterable.class.getTypeParameters()[0]);
    }

    @Override
    public boolean supports(AnnotatedType type) {
        return GenericTypeReflector.isSuperType(Iterable.class, type.getType());
    }
}

Register it:
//Since Collection is Iterable, register the new mapper _after_ the existing one so it doesn't interfere
generator.withTypeMappers((conf, current) -> current.insertAfter(ListMapper.class, new IterableToCollectionTypeAdapter<>()))

Jackson should be able to handle deserialization to Iterable just fine, and graphql-java handles Iterable outputs just fine as well.
I'll figure out how to best add out-of-the-box support for Gson as well.

Thank you!
Out of the box support would be really nice :)


"Zabbix Problems Panel" display problems

Describe the bug
Zabbix problem panel" table collapses.
Expected behavior
It should display correctly like this:

Screenshots

Network data
Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

10.2.3
5.4
4.4.5

I tried to update the plugin to 4.4.6 and still got this issue, anyone can take a look? @alexanderzobnin

Bump, any feedback?

I'm having the same problem:
Grafana Version: Grafana v11.1.0-69950 (a4bb4c8400)
Zabbix Version: 6.4.0
Grafana-Zabbix-Version: 4.4.9

Sorry this is a problem in grafana. Please update your grafana. See https://github.com/grafana/grafana/pull/87211


nix | svclib:  provide a working default for the cardano-node arg

Small fix for svclib -- @denisshevchenko might need this.

bors r+


Test computeBaseline's withAncestors option

This PR tests the withAncestors option. There are two things in this PR:

A test that asserts that the results of the Baseline calculation api.Notification.body is different with and without ancestor features (i.e., the reported support for api.Notification.body is greater than the reported supported for api.Notification and api.Notification.body).
Why is this important? See the MDN page Notification: body property and compare it to what you see in Notification.
If you look at this gist of such features you'll see that there are dozens that are hypothetically like it—fewer than I expected! However, cases like api.Notification.body, where there's a standalone MDN page for the feature, represent the most-risky cases of this.

The script I used to find that feature (and several others like it): scripts/find-troublesome-ancestors.ts.

Also I'll note that the helper script only finds features where the Baseline status for a feature's ancestors is less than the feature itself. It doesn't find cases where the Baseline low date is earlier for ancestor features than the feature itself.


Return an error for schema with an unknown extension type

Description of changes
Fix #875.
The change as implemented is breaking because it adds a new variant of SchemaError. We could work around this if we felt this need to go out in a pre-4.0 patch. This is also breaking because some schema will stop parsing if they had a typo in an extension type name, but that's well within what we're ok making in a patch.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

[x] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

We can overload the Serde variant if we want to apply it to the release branches.

Heads up: I just merged #870 which will conflict with this PR since it also edits the CHANGELOG.


Implicit multiplication involving a suffix operator

I keep writing $n`? $v, which currently gives a "missing operator" error. I should write $n`? * $v.
The expression n!x also has this problem.
So, the parser should insert an implicit multiplication symbol following a suffix operator.

There is an ambiguity, because ! can be a prefix or postfix operator, so a!b could be either (a!)*b or a*(!b).

I've decided to go with preferring the postfix version.
The equivalent problem with prefix operators still exists, but I had a look at how they're produced, and I think there are lots more potential ambiguities if I dig any deeper. At the moment, a prefix op token can only be produced following punctuation or a non-postfix op. Adding in implicit multiplication would lead to loads of ambiguities. For example, does a-b represent (a)-(b), or a * (-b)?


Feat/cleansing

Some simple refactors to tidy up the repo and implement modern standards and best practice.

do we plan for private member variables to have the _ as a prefix or suffix? I might be wrong, but I thought that myVar_ is more of a standard practice than _myVar

do we plan for private member variables to have the _ as a prefix or suffix? I might be wrong, but I thought that myVar_ is more of a standard practice than _myVar

Swings and roundabouts there tbh, everyone has their own taste here. I guess when I went over the code I was automatically applying the standards I've used myself and in my professional life but there's no reason you have to adopt the same. If you prefer to stick with m_ then I can put it back. If you look at well known libraries you'll see a mixture of either _ or m_ and yes there a some that use postfix _ too. Entirely up to you tbh.

Personally, I prefer the m_ prefix, but open to suggestions. For consistency, if we go for _m, maybe we shoot for better consistency by changing type definitions to prefix t_ instead of postfixing _t. Or maybe we postfix member variables with _m. Thoughts?

I'm not a big fan of loads of unnecessary prefixes and suffixes, just reminds me of code from the 80s hahaha. I personally just name everything for what it is. PascalCase for classes, functions, enum members. myVar to denote private member variables. UPPER_CASE usually for anything in the global scope, I've never really found the c distinction that necessary to identify constexpr. I've worked that way for years and never found myself yearning for everything to have extra letters hanging off it. Conventions are great when they actually make your life easier, not so great when they're just for the sake of it, and imo all the google-style prefixing a_argument, m_member, c_constant are just superfluous and dont really aid in understanding the code. That stuff was useful back in the day before IDEs with intellisense. We dont code in notepad anymore haha.
That said, you chose what you'd like, I have plenty of codebases I work on daily and this is your baby so you decide what you're happy with and I'll conform.

Personally, I prefer the m_ prefix, but open to suggestions. For consistency, if we go for _m, maybe we shoot for better consistency by changing type definitions to prefix t_ instead of postfixing _t. Or maybe we postfix member variables with _m. Thoughts?

I believe all of the _t postfixing has already been removed (most by @danwillm and some in this PR). I'm assuming you guys started with that convention because openvr uses it. You certainly wont see that approach used very often though. The obvious desired starting position is to be able to name things the way you actually want to name them, if you're modelling a cat or a dog then you ideally want a Cat or a Dog, not a Cat_t and Dog_t etc. I'd only start adding in conventions if you can argue that they add value that outweighs the annoyance or yuck factor they introduce haha.
So for me, I think we just name everything naturally, and the only pertinent decision is how we want to denote class member variables because every dev I've ever worked with likes them to be immediately obvious at a glance.

Sorry about all the back and forth here:
I'm good with the _ postfix, but what do you think about keeping the _t for types?
Even though you can see if something is a type or not with intellisense, it still does seem like at first glance it's more cumbersome to tell whether something like Transform is a class or a type (even more so if you're just looking on github), without having to read further.

Unless you're trying to compile the code in your head (which would be impressive!) then I really can't imagine a scenario where _t helps with understanding the code. The only time most devs tend to need/desire such at-a-glance cues are to distinguish the scope of variables/members. Back to my previous comment, ideally you shouldn't have to worry about lots of conventions when you're writing your code. Especially on collaborative projects where many people have different conventions of their own, choosing a minimal approach makes a lot of sense. Less is best imo.

From: Lucas LucidVR @.>
Sent: Thursday, November 11, 2021 6:02:25 PM
To: LucidVR/opengloves-driver @.>
Cc: MasterOfShred @.>; Author @.>
Subject: Re: [LucidVR/opengloves-driver] Feat/cleansing (PR #156)
Sorry about all the back and forth here:
I'm good with the _ postfix, but what do you think about keeping the _t for types?
Even though you can see if something is a type or not with intellisense, it still does seem like at first glance it's more cumbersome to tell whether something like Transform is a class or a type (even more so if you're just looking on github), without having to read further.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LucidVR/opengloves-driver/pull/156#issuecomment-966509091, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBPEQRIVEUHP5NSR5TCCKLULQALDANCNFSM5HWH6PKQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Icon (font) size depending on position

This is a (multiple allowed):

[ ] bug
[x] enhancement
[ ] feature-discussion (RFC)

Framework7-Icons could be used in lists, on buttons, in text blocks ... but the size is currently always the same, to be adjusted with font-size or size property in Framework7-vue. I would appreciate if there are given font-sizes for the most used icon positions, so that the <i> elements are sized properly by default :-)

I think it's in the hand of devs to pick the right font-size for these icons. How is F7 supposed to know the right font size?

Depending on the icon font and the position (list media, buttons, text inline) there is a font range so that icons looks great. That could be defined as default, so that everything looks fine, even if the developer didn't define the font size additionally.


fix #397

I stayed on the side of more configurability rather than less. LMK about any issues

I should probably also modify this to use https://docs.obsidian.md/Reference/TypeScript+API/debounce I suppose

OK, now using the obsidian debounce function, storing previousContents with reference to the file it's referring to (oops), and using Vault#on("modify")


Update lunch crawler to work under Python 3

It still doesn't populate the database, but that can be an exercise for someone else.
Output from python update_lunch.py:
2022-03-18 Blackened Salmon Sandwich
   With Truffle Fries and Coleslaw
    Vegetarian Option: Vegan “Fish”

2022-03-21 Pesto Chicken Penne Pasta
   With Garlic Bread and Fresh Veggie
    Vegetarian Option: Gardein “Chik’n”

2022-03-22 Chicken Teriyaki
   With Garlic Bread and Fresh Veggie
    Vegetarian Option: Vegetarian “Chik’n” Penne

2022-03-23 BBQ Beef Loaded Baked Potato
   With Fresh Veggie
    Vegetarian Option: Vegetarian Baked Potato

2022-03-24 Lemon Chicken
   With Rice Pilaf and Fresh Veggie
    Vegetarian Option: Vegetarian Baked Potato

2022-03-25 Cheese Pizza
   With Fruit Cup
    Click here for meal account and food services details

2022-03-28 Chicken Fettuccini Alfredo
   With Garlic Bread and Fresh Veggie
    Vegetarian Option: Vegetarian “Chik’n” Penne

2022-03-29 Beef & Broccoli
   With Steamed Rice and Veggie Spring Roll
    Vegetarian Option: Vegetable Alfredo

2022-03-30 All Beef Hot Dogs
   With Tater Tots and Fresh Fruit
    Vegetarian Option: Veggie Dogs

2022-03-31 Chicken Parmigiana
   With Mashed Potato and Fresh Veggie
    Vegetarian Option: Eggplant Parmigiana

2022-04-01 Crispy Fish Sandwich
   With French Fries and Apple Slices
    Vegetarian Option: Vegan “Fish” Sandwich

Part of the fix for #391


Run Task: Use DevEnv

Run Task fails on Windows occasionally due to error 87 in creating process, this can be avoided, and manually entering env can be avoided by instead running the executable via meson's devenv

@xclaesse can you take a look at this and give it some thought? Seems like a good idea.

@tristan957 @xclaesse Just wanting to check in if any opinion on this change

I'm sorry for letting this sit, and I will try to get to it as soon as I can. Can you fix the CI while you're here?

@tristan957 Of course, i fixed the prettier issue and have rebased my fork. Thanks again for considering the PR

The intention is clearly to run those exe in devenv, I'm not sure why I haven't done it your way in the first place. Loading the generated env file into a dict seems weird in retrospect. LGTM.

@xclaesse I'll let you hit the merge button when you're happy.

Can you rebase this, and then I can merge it for the next release?

@tristan957 Thank you! Sorry for the delay, I have rebased the change


I am doing something wrong

I don't know what I'm doing wrong but I get the following error

2020.06.25 22:40:32.727	Script JiowclPublisherServer USDJPY,H4: removed
2020.06.25 22:40:32.726	JiowclPublisherServer USDJPY,H4: global initialization failed
2020.06.25 22:40:32.725	JiowclPublisherServer USDJPY,H4: unresolved import function call
2020.06.25 22:40:32.725	Cannot call 'libzmq.dll::zmq_ctx_new', 'libzmq.dll' is not loaded
2020.06.25 22:40:32.724	Cannot load 'C:\Users\VICTALEJO\AppData\Roaming\MetaQuotes\Terminal\CBAD7D1B35A2FBD485DA10342CF7119A\MQL4\Scripts\libzmq.dll' [126]
2020.06.25 22:40:32.604	JiowclPublisherServer USDJPY,H4 inputs: Server=tcp://*:5559; ServerDelayMilliseconds=300; ServerReal=false; AllowSymbols=;
2020.06.25 22:40:31.399	Script JiowclPublisherServer USDJPY,H4: loaded successfully
2020.06.25 22:26:37.525	Script JiowclSubscriberClient USDJPY,H4: removed
2020.06.25 22:26:37.523	JiowclSubscriberClient USDJPY,H4: global initialization failed
2020.06.25 22:26:37.522	JiowclSubscriberClient USDJPY,H4: unresolved import function call
2020.06.25 22:26:37.522	Cannot call 'libzmq.dll::zmq_ctx_new', 'libzmq.dll' is not loaded
2020.06.25 22:26:37.522	Cannot load 'C:\Users\VICTALEJO\AppData\Roaming\MetaQuotes\Terminal\CBAD7D1B35A2FBD485DA10342CF7119A\MQL4\Scripts\libzmq.dll' [126]
2020.06.25 22:26:37.499	JiowclSubscriberClient USDJPY,H4 inputs: Server=tcp://localhost:5559; ServerDelayMilliseconds=300; ServerReal=false; SignalAccount=; MinLots=0.0; MaxLots=0.0; PercentLots=100.0; Slippage=3; AllowOpenTrade=true; AllowCloseTrade=true; AllowModifyTrade=true; AllowSymbols=; InvertOrder=false; MinFreeMargin=0.0; SymbolPrefixAdjust=;
2020.06.25 22:26:34.589	Script JiowclSubscriberClient USDJPY,H4: loaded successfully

Hi,
Please extract the attach file into MQL4 folder, and make sure the option Allow DLL imports is checked.
Libraries.zip


Document minimum Python version requirements

This patch adds the minimum Python version to the readme and describes
the version requirements in the developer guide.
Already incorporates the bump to 3.9 in #237.

Thank you for correcting .rst formatting!