azure-agent: move runtime dependencies to pkgs.waagent

Description of changes
This PR is to address the comment https://github.com/NixOS/nixpkgs/pull/266310#issuecomment-1802513544. As discussed in #266310, I think we should put runtime dependencies into pkgs/applications/networking/cluster/waagent/default.nix, because udev also uses waagent here. The dependencies added to services.waagent should be avoided because they would not be visible to udev.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

There's some more confusion here.
udev rules don't inherit $PATH either set from the surrounding Environment in the systemd service, or from a --prefix PATH in the waagent binary on its own.
In addition, the udev rules were not picked up at all, because they were in the wrong output path.
I opened https://github.com/NixOS/nixpkgs/pull/274220 which should fix this, will undraft once I booted a VM with this.


Update Android dependencies

Wanted to include an update here so that RN users can benefit from the fixed Android ASR.

@space-pope just to clarify from yesterday, this has been verified with a project?

@noelweichbrodt Yep, built and run on at least a Pixel 1. Updated the readme to indicate a change in input class you'll need for different ASR providers.


Replace tip/internal node metadata structures in empress.js with arrays?

Since the keys in these Objects are the postorder position of a node, it should be feasible to just store these as Arrays (where the i-th entry holds data for the i-th node in the postorder position), analogous to @kwcantrell's comment at https://github.com/biocore/empress/issues/339#issuecomment-681159168.

...Actually not sure this is a good idea (at least in terms of saving space in the HTML output by the python code), because if the amount of feature metadata is sparse then there'll be a lot of undefineds scattered throughout the array. Would probably be easier to just stick with storing feature metadata as Objects, and IIRC these are represented the same? way as arrays internally in JS so it probably wouldn't make much of a difference for performance.


docs(guides): use tag next

webpack beta was published under tag next.
We would like users to install webpack under devDependencies instead of dependencies.

@chenxsan please elaborate on --save-dev

@EugeneHlushko Do you have question about using --save-dev here or do you want me to add some comments for it?

Yes either way it is not clear right now why we are suggesting --save-dev by default. There is obviously a use case for both setups but if you think we should default to being a dev dependency should probably explain why

@EugeneHlushko I've added a tip about --save-dev.
I think most people use webpack for app bundling although there're cases like next.js saving webpack under dependencies.
Also we already have --save-dev at the beginning of this page:

It would be better to keep consistent with that.

Thanks!


[Req]: Minimise lines of code

Contact Details
No response
Explain the proposed feature
In the theme setter file, i want to replace so many lines of if and else statement with two lines.
The page has been tageged below.
https://github.com/TechSpiritSS/Terminal-Portfolio/blob/main/scripts/themeSetter.js
Explain the possible use cases for the feature
No response
Any other details you would like to provide?
No response

Can you assign me this under SWOC 23

Sure, go for this


Dependency improvement

Opening a draft PR just to document the current failure with trying to make this a monorepo with both the plugin and the frontend dependencies. Most recent commit breaks this, current failure attached. My best guess is that somehow when the llm code is in a separate package it's pulling in a bad react version (or something), because the errors have absolutely nothing to do with the code changed and the versions of the dependencies are matched between the frontend code being imported and the frontend code already in the llm app.
ERROR in ./src/components/App/App.test.tsx:40:8
TS2786: 'BrowserRouter' cannot be used as a JSX component.
  Its instance type 'BrowserRouter' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'React.ReactNode' is not assignable to type 'import("/home/aaronsanders/code/grafana/grafana-llm-app/packages/grafana-llm-frontend/node_modules/@types/react/index").ReactNode'.
    38 |     setBackendSrv({ ...origBackendSrv, get: getMock });
    39 |     render(
  > 40 |       <BrowserRouter>
       |        ^^^^^^^^^^^^^
    41 |         <App {...props} />
    42 |       </BrowserRouter>
    43 |     );

ERROR in ./src/components/App/App.tsx:8:6
TS2786: 'Switch' cannot be used as a JSX component.
  Its instance type 'Switch' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'React.ReactNode' is not assignable to type 'import("/home/aaronsanders/code/grafana/grafana-llm-app/packages/grafana-llm-frontend/node_modules/@types/react/index").ReactNode'.
     6 | export function App(props: AppRootProps) {
     7 |   return (
  >  8 |     <Switch>
       |      ^^^^^^
     9 |       {/* Default page */}
    10 |       <Route component={Models} />
    11 |     </Switch>

ERROR in ./src/components/App/App.tsx:10:8
TS2786: 'Route' cannot be used as a JSX component.
  Its instance type 'Route<{}, string>' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'React.ReactNode' is not assignable to type 'import("/home/aaronsanders/code/grafana/grafana-llm-app/packages/grafana-llm-frontend/node_modules/@types/react/index").ReactNode'.
     8 |     <Switch>
     9 |       {/* Default page */}
  > 10 |       <Route component={Models} />
       |        ^^^^^
    11 |     </Switch>
    12 |   );
    13 | }

ERROR in ./src/pages/Models.tsx:30:6
TS2786: 'PluginPage' cannot be used as a JSX component.
  Its element type 'ReactElement<any, any> | Component<PluginPageProps, any, any> | null' is not a valid JSX element.
    Type 'Component<PluginPageProps, any, any>' is not assignable to type 'Element | ElementClass | null'.
      Type 'Component<PluginPageProps, any, any>' is not assignable to type 'ElementClass'.
        The types returned by 'render()' are incompatible between these types.
          Type 'React.ReactNode' is not assignable to type 'import("/home/aaronsanders/code/grafana/grafana-llm-app/packages/grafana-llm-frontend/node_modules/@types/react/index").ReactNode'.
            Type '{}' is not assignable to type 'ReactNode'.
    28 |
    29 |   return (
  > 30 |     <PluginPage>
       |      ^^^^^^^^^^
    31 |

    32 |
Available Models

    33 |
{JSON.stringify(value, null, 2)}

Found 4 errors in 2938 ms.```

Had to nigh-totally redo this to fix various problems, so this one is now defunct.


bug in sasjs build

To reproduce:
git clone https://github.com/sasjs/fileuploader
cd fileuploader
sasjs compile
sass build

:tada: This issue has been resolved in version 1.21.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: reduce unnecessary fetching of supercharge rewards

Description
Since the supercharge v2 backend computation is relatively intensive, it'd be nice to reduce the redundant calculations. This will save us some rpc calls quota. This PR aims to implement some kind of cache.
There are 2 places that fetch supercharge rewards:

home screen - specifically, the homecards. the rewards data is used to display the supercharge homecards.
supercharge screen

I think it is unnecessary to keep fetching supercharge rewards on the home screen. The worst case scenario that comes from this change, is that the "claim your rewards" homecard is displayed later.
This PR:

add a new redux variable / migration to track last reward fetch time
in the notifications, only fetch rewards if the previous fetch was more than 24 hours ago

Test plan
n/a
Related issues
n/a
Backwards compatibility
Y

I mean the normal HTTP cache headers that all well behaved HTTP clients respect.
Specifically, we could return something like Cache-Control: max-age=86400 in the supercharge response headers so the wallet would continue serving the cached response for 1 day.

I mean the normal HTTP cache headers that all well behaved HTTP clients respect.
Specifically, we could return something like Cache-Control: max-age=86400 in the supercharge response headers so the wallet would continue serving the cached response for 1 day.

ooooohhhhhh makes sense, well then if it doesn't need a client side change then i'll do it when i'm back :D


Sony a7r chokes LZ

Environment.  Win 7 64 bit OS,  16 MB of DRAM,  Stable 4.0.0 default download (which I think is 32 bit).
A saved 16 bit tiff from the Sony a7r,  which is a 36 MPixel camera, is opened and altered in LZ.  The file on the disk is just over 200 MB (could be related to the 200 MB tiff problem again?).  I then attempt to Convert File to a full size 16 bit tiff encompassing the new changes.   The Tiff file does save properly.  The problem is that LightZone throws up the following error when trying to go back to the Browser.   I can never make it back to the Browser and the only way to get to the next photo is to quit LightZone and restart it.
The dialog box reads as follows:
Confirm:
Couldn't save to C:...LZExport5995797841236785893.tmp
Couldn't read XML
	OK

=====
The "..." above appearing after the C: and before "LZExport" followed by the long number is the working path w/o slashes.  That is, the path appears redacted as if the slashes were swallowed.
The actual path was C:\Photos\Raw cb\Sony Pentax Canon raw
The dialog box actually showed this as the file name and path:
"C:PhotosRaw cbSony Pentax Canon rawLZExport5995797841236785893.tmp"

I confirm that LightZone 4.1.0RC2 amd64 has the same problem as the above.  One difference is that RC2 does show the backslashes.


set GO15VENDORECPIREMENT once in Makefile

cc @yarpc/golang

title / commit message have a typo, should be "GOVENDOR15EXPERIMENT". otherwise lgtm.

@prashantv good catch, fixed.


Make in_column the first argument in every transform

🚀 Feature Request
There are transforms where in_column is the second argument. We want him to be the first.
Motivation
Unified simantics
Proposal

Make in_column the first argument in every transform and set default values for past first arguments for these transforms

https://github.com/tinkoff-ai/etna-ts/blob/master/etna/transforms/add_constant.py
https://github.com/tinkoff-ai/etna-ts/blob/master/etna/transforms/lags.py
https://github.com/tinkoff-ai/etna-ts/blob/master/etna/transforms/statistics.py

Make sure there are no others
Check that the tests are working correctly

Test cases
No response
Alternatives
No response
Additional context
No response
Checklist

[X] Added feature request
[X] Added motivation
[X] Added proposal

lets discuss it first?

in_column as a first arg, no default value for in_column


dataset

Hi,Could you please provide the dataset in paper?
Thank you very much if possible.

Hi, you can get the dataset from the following link: https://www.dropbox.com/sh/2yaozw36im0q1q8/AADog1kApeXPEdjAWuy-NfVXa?dl=0
I will write a detailed Readme about the dataset later, but recently I am a little busy in other things. If you have other questions, feel free to let me know.

Thank you very much for your reply
Looking forward to the next readme


Only add line spacing when there are 1 or more lines.

If numberOfLines == 0 and lineSpacing != 0, the dimensions calculated in collectionViewContentSize were incorrect. numberOfLines - 1 would wrap around to a giant int which was causing size.height to become extremely large in my case. The grid layout partially broke down and autolayout complained with this log message:
This NSLayoutConstraint is being configured with a constant that exceeds internal limits.  A smaller value will be substituted, but this problem should be fixed. Break on void _NSLayoutConstraintNumberExceedsLimit() to debug.  This will be logged only once.  This may break in the future.
I was wondering if the guard checks should actually be self.numberOfLines > 1 since line spacing is really only needed if there are 2 or more lines but I didn't want to change any pre-existing behaviour other users may rely on.

Thanks for this fix!
Added tests for this case and merged in.
Cheers,
Rich


Kafka Error

Error while testing connection with Kafka
Error example:
test-connection-Kafka-my798FgW Failed to trigger workflow due to airflow API returned Internal Server Error and response {"error": "Error running automation workflow due to [KafkaError{code=_INVALID_ARG,val=-186,str="Failed to create admin client: No provider for SASL mechanism GSSAPI: recompile librdkafka with libsasl2 or openssl support. Current build options: PLAIN SASL_SCRAM OAUTHBEARER"}]] "}
Configuration example:

Scrin error:

Version:

OpenMetadata version: 1.3.3

related to https://github.com/confluentinc/confluent-kafka-dotnet/issues/567


client https support

Hello Zach,
I added basic ssl support to the http client.
All tests still pass and the twitter api works just fine when using the https url.
Let me know if you want me to change something or if it is not what you intended for client ssl support.
Max

This is merged in 0.2.1-SNAPSHOT.


Using token app / rewards - something went wrong

Connected an eth wallet and vega wallet
clicked rewards

Hi @vega-paul, could you provide some extra details please:
What network were you pointing at?
What version of the wallet were you using?
Thanks


[iOS] WebView nested in ListView glitches on scroll.

Steps to Reproduce

Execute flutter run with the code sample on a physical iPhone.
Scroll up or scroll down.

Expected results:
The AppBar should not glitch.
There should be no white line appearing in the AppBar on scroll.

Actual results:
The AppBar glitches.
There is a white line inside the AppBar

Code sample
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'iOS Glitch'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(title),
      ),
      body: ListView(
        children: const <Widget>[
          SizedBox(
            width: double.infinity,
            height: 500,
            child: WebView(
              initialUrl: 'https://flutter.dev',
            ),
          )
        ],
      ),
    );
  }
}

Pubspec:
name: ios_glitch
description: A new Flutter project.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

version: 1.0.0+1

environment:
  sdk: ">=2.16.2 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  webview_flutter: ^3.0.2

  cupertino_icons: ^1.0.2

dev_dependencies:
  flutter_test:
    sdk: flutter

  flutter_lints: ^1.0.0

flutter:
  uses-material-design: true

Logs
Flutter analyze:
Analyzing ios_platformeview_glitch...                                  ⣷
No issues found! (ran in 1.9s)

Flutter Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-x64, locale fr-FR)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.66.1)
[✓] VS Code (version 1.47.3)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.

https://user-images.githubusercontent.com/28344195/163033803-b6d9e116-835d-47f7-bbaa-b13620d39383.mov

Possibly the same issue as https://github.com/flutter/flutter/issues/98756
It was fixed and hopefully should be available in the next stable :)

@T-moz
I tried your code sample on latest master and stable using iPhone 6s (OS 15.3.1) but didn't observe the issue you reported.
https://user-images.githubusercontent.com/67046386/163115180-80c56743-26ca-44be-8698-cc483dd2d7b4.MP4

 stable, master flutter doctor -v

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 2.10.4 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (3 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.13.0-0.0.pre.523, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 2.13.0-0.0.pre.523 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 009688a99e (76 minutes ago), 2022-04-12 23:29:10 -0400
    • Engine revision e33c024d94
    • Dart version 2.18.0 (build 2.18.0-10.0.dev)
    • DevTools version 2.12.2

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Please try the same on latest master too and check if behavior still persists or not.

I tested on master branch and couldn't reproduce the issue 🎉
Flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 2.13.0-0.0.pre.526, on macOS 12.3 21E230 darwin-x64, locale fr-FR)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.66.2)
[✓] VS Code (version 1.47.3)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.

Thanks for your support @darshankawar.
Next time, I'll test on the master branch before submitting an issue 😉


[Impeller] Text flickering when CupertinoPicker is scrolling

Steps to reproduce

Happens only when the CupertinoPicker is scrolled. Test made on real device IOS (17.3.1) 14 PRO
Started after 3.19.2 and continues with 3.19.3. No issue when Impeller is not used.
Not solved in channel master 3.21.0-5.0.pre.23

Expected results
I expect my text to be static and not flicker
Actual results
All text sections in the view are flickering when the wheel is scrolling.
Code sample
Code sample
SizedBox(
      height: 120,
      width: wheelWidth,
      child: ClipRRect(
        borderRadius: kBORDER_RADIUS_6,
        child: CupertinoPicker(
          useMagnifier: true,
          magnification: 1.1,
          squeeze: 1.1,
          backgroundColor: backgroundColor,
          itemExtent: itemExtent!,
          onSelectedItemChanged: (val) {
            setLanguage(val);
          },
          scrollController: FixedExtentScrollController(
            initialItem: initialItem,
          ),
          children: List<Widget>.generate(languages.length, (int index) {
            return Center(
              child: Text(
                formatEmptySelection(languages[index].name),
                textAlign: TextAlign.left,
                style: Theme.of(context).textTheme.bodyMedium,
                semanticsLabel: formatEmptySelection(languages[index].name),
              ),
            );
          }),
        ),
      ),
    );

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/20269106/1a4da7af-2564-4406-8f95-488cd2c699b7

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.3, on macOS 14.3 23D56 darwin-arm64, locale en-SE)
    • Flutter version 3.19.3 on channel stable at /Users/richardscheffer/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ba39319843 (5 days ago), 2024-03-07 15:22:21 -0600
    • Engine revision 2e4ba9c6fb
    • Dart version 3.3.1
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/richardscheffer/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.87.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] VS Code (version 1.88.0-insider)
    • VS Code at /Applications/Visual Studio Code - Insiders.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (4 available)
    • Richard – iPhone (mobile) • 00008120-00165138263B401E            • ios            • iOS 17.3.1 21D61
    • iPhone 8 Plus (mobile)    • A5437983-0B03-4325-9114-33D519F2E5AD • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)           • macos                                • darwin-arm64   • macOS 14.3 23D56 darwin-arm64
    • Chrome (web)              • chrome                               • web-javascript • Google Chrome 122.0.6261.112

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@Schefferbird
I am unable to replicate using the official code sample.
Can you provide us complete runnable code that we can directly use to verify if further ?

Same here.

After traveling between flutter updates, I can no longer recreate this issue on 3.19.3.


Org- "Edit Organization Profile" Page (MVP v1 Desktop)

Build out two pages that lets you toggle between "Account Information" and "Profile Information" from the left menubar. Default is to have "Account Information" selected

"Save Changes" should confirm updates and write back to database

https://github.com/FightPandemics/FightPandemics/pull/455 may be helpful here


Images in Stocks drawer layout at crazy sizes

Now that we get sky.Image callbacks synchronously, we were actually figuring in
the width and height of images the second time the drawer opened in the Stocks
app. That exposed a bug in our RenderImage layout code whereby it would ignore
the _width and _height properties when the image was non-null.

lgtm
On Tuesday, August 11, 2015, Adam Barth<EMAIL_ADDRESS>wrote:

Now that we get sky.Image callbacks synchronously, we were actually
figuring in
the width and height of images the second time the drawer opened in the
Stocks
app. That exposed a bug in our RenderImage layout code whereby it would
ignore
the _width and _height properties when the image was non-null.
You can view, comment on, or merge this pull request online at:
https://github.com/domokit/sky_engine/pull/552
Commit Summary

Images in Stocks drawer layout at crazy sizes

File Changes

M sky/packages/sky/lib/rendering/box.dart
https://github.com/domokit/sky_engine/pull/552/files#diff-0 (57)

Patch Links:

https://github.com/domokit/sky_engine/pull/552.patch
https://github.com/domokit/sky_engine/pull/552.diff

—
Reply to this email directly or view it on GitHub
https://github.com/domokit/sky_engine/pull/552.

I wonder if this explains why the hotdog menu in the fitness app gets screwy after changing orientation and back again.


feat: Added number_of_ variables for iam-assumable-role submodules

fix for terraform error for assumable-role"number of resources cannot be determined during runtime" in iam-assumable-role

Thank you!
v2.26.0 has been just released.

Please revert this change. It is not backwards compatible.

v3.1.0 has been just released with this PR, while v2.25.0 is the latest in v2 where the behavior is the same as before this PR was merged.
Apologize for the confusion.

Wouldn't leveraging for_each be a better approach here ?
This is very error prone, especially with the default 0.

@horjulf for_each will act exactly like count in this case. There is no better workaround in Terraform 0.13 for computed values being used in meta-arguments like count and for_each.


fix(explore): Certified metric icons are various sizes

SUMMARY
Closes #12628
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:

AFTER:

TEST PLAN

Open Explore
Setup certified metrics with names of various lengths
Make sure the certified icon is of the same size for every metric

ADDITIONAL INFORMATION

[x] Has associated issue: #12628
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

tested manually looks fine 🟢

tested manually looks fine 🟢

LGTM, we may need to look at the label line break separately though.
Thanks for the PR, testing and merging!

LGTM, we may need to look at the label line break separately though.
Thanks for the PR, testing and merging!


arduino-cli lib install dependency strictness

Hey and thanks for the awesome project !
I'm getting an issue with a couple of libraries I'm importing using required-libraries, the installation of the required libraries fails although I know those are valid library names.
After a quick investigation, I found out those library have a poisonous depends entry in their library.properties file, sometimes listing a library name that isn't in the registry, sometimes listing an ambigous name, and deferring the failure even though the main library has been downloaded.
Here's a couple of examples: M5Stack and M5StickC.
Here's a screenshot of the failure for the M5StickC library:

I went looking for a way to trigger the --no-deps options of arduino-cli lib install using this github action and found none, so here I am writing this feature request :wink:
An action option like lib-dep-resolver: false would be neat to handle those situations.
be well

Thanks, I forgot one line.
Please rerun the action again.


Fatal Exception: java.lang.AssertionError Manager has already been closed.

Describe the bug
After updating to v3 the following fatal crash is being reported.
Fatal Exception: java.lang.AssertionError
Manager has already been closed.

Fatal Exception: java.lang.AssertionError: Manager has already been closed.
       at io.flutter.plugins.webviewflutter.InstanceManager.assertManagerIsNotClosed(InstanceManager.java:9)
       at io.flutter.plugins.webviewflutter.InstanceManager.getIdentifierForStrongReference(InstanceManager.java)
       at io.flutter.plugins.webviewflutter.JavaScriptChannelFlutterApiImpl.getIdentifierForJavaScriptChannel(JavaScriptChannelFlutterApiImpl.java:2)
       at io.flutter.plugins.webviewflutter.JavaScriptChannelFlutterApiImpl.postMessage(JavaScriptChannelFlutterApiImpl.java)
       at io.flutter.plugins.webviewflutter.JavaScriptChannel.lambda$postMessage$1(JavaScriptChannel.java:6)
       at io.flutter.plugins.webviewflutter.JavaScriptChannel.$r8$lambda$K7533Hqo0qg7ff56ym-eNCAOHa4(JavaScriptChannel.java)
       at io.flutter.plugins.webviewflutter.JavaScriptChannel$$InternalSyntheticLambda$2$942c86d1a51c05498444059a61e0d6ae7621f7cf7a614902a174f9ffedd43aed$0.run(JavaScriptChannel.java:4)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:210)
       at android.os.Looper.loop(Looper.java:299)
       at android.app.ActivityThread.main(ActivityThread.java:8302)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)

To Reproduce
Unable to reproduce.
Technical Details:
Device
Brand:Xiaomi
Model:Redmi Note 10
Orientation: Portrait
Operating System
Version:Android 12
Orientation: Portrait
Rooted:No
Crash
Dependency version
youtube_player_iframe: 3.0.4

Here are details of another device also:
Device
Brand:LGE
Model:LG Q6
Orientation: Portrait
Operating System
Version:Android 7.1.1
Orientation: Portrait
Rooted:No
Crash

any update on this issue?

This PR https://github.com/flutter/plugins/pull/6943 may fix this issue. webview_flutter_android: 3.1.3
This commit https://github.com/sarbagyastha/youtube_player_flutter/commit/a957a9499fe53414819bd415a94ec4c7446a3c44 uses the updated webview_flutter_android: 3.2.1 (previous version used in package was 3.1.1)


Microsoft Smooth Streaming downloader

Smooth Streaming (SSTR) is a protocol for media streaming over HTTP, created by Microsoft. It isn't terribly popular, but sometimes it's the only option available (see #1753, #7096).
SSTR is superficially similar to other manifest-based media streaming formats: there's an XML file which describes what streams are available and a URL pattern of media fragments. A single manifest may directly describe multiple versions of multiple audio streams and multiple video streams; this may make it a bit harder to support, given that youtube-dl seems to assume each stream has its own URL. Stream fragments are in the series-of-boxes format known from MP4 files; however mere concatenation doesn't yield a playable file, because certain crucial boxes are missing (including those containing codec parameters, which are stored in the manifest).
Since FFmpeg doesn't contain a SSTR (pseudo-)demuxer, a custom downloader will have to be written. The downloader should probably synthesise a single-stream media file and leave multiplexing to FFmpeg (like it's done with YouTube DASH).
Some documentation:

http://download.microsoft.com/download/9/5/E/95EF66AF-9026-4BB0-A41D-A4F81802D92C/[MS-SSTR].pdf
https://msdn.microsoft.com/en-us/library/ff728116(v=vs.90).aspx
https://msdn.microsoft.com/en-us/library/ff728116(v=vs.95).aspx

Example video: http://mediadl.microsoft.com/mediadl/iisnet/smoothmedia/Experience/BigBuckBunny_720p.ism/Manifest

I suspect http://research.microsoft.com/apps/tools/tuva also uses this and would be a worthwhile target for youtube-dl.

Here's smooth-dl written in Python. Haven't checked to see if it's actually working though.
https://git.ao2.it/smooth-dl.git/

It can't until released under unlicense.


ui-scroll with Jquery-1.11.2 not working

I am using jquery-1.11.2 and not using ui-scroll-jqlite, the problem what i am facing while implementing ui-scroll is,

if i use ui-scroll-jqlite along with jquery means also the same error exists, i can't remove jquery in my project. Why this error is happening?
See to the plunker link for the further details,
http://embed.plnkr.co/TjlzuAg5Pbmf8WVdN27V/preview
why this error is happening with ui-scroll with jquery?

With the demo you provided it is quite simple to fix a problem.
Here is my fixed fork of your plunker: http://plnkr.co/edit/c6BEFc?p=preview
The only change I did is transfering jQuery script tag to the first position.
As it follows from official doc: "To use jQuery, simply ensure it is loaded before the angular.js file."


check if commit author is blacklisted before checking if they are whitelisted

this PR is an implementation proposal to prevent cases like #831 by adding known users to the list of committers to skip (introduced in #488).
if the PR author is in the deny list, they will never be checked for org membership.
this will prevent the api call that returns 404 and will prevent rate limit.
internal reference: https://issues.redhat.com/browse/APPSRE-4423

i'm struggling a bit with 1 test failing:
No interactions wanted here:
-> at org.jenkinsci.plugins.ghprb.GhprbRepositoryTest.testCheckMethodWithOnlyExistingPRs(GhprbRepositoryTest.java:242)
But found this interaction on mock 'ghUser':
-> at org.jenkinsci.plugins.ghprb.GhprbRepositoryTest.testCheckMethodWithOnlyExistingPRs(GhprbRepositoryTest.java:212)
***
For your reference, here is the list of all invocations ([?] - means unverified).
1. -> at org.jenkinsci.plugins.ghprb.GhprbRepositoryTest.testCheckMethodWithOnlyExistingPRs(GhprbRepositoryTest.java:212)
2. [?]-> at org.jenkinsci.plugins.ghprb.GhprbRepositoryTest.testCheckMethodWithOnlyExistingPRs(GhprbRepositoryTest.java:212)

hints are appreciated!

@samrocketman @janinko any chance you can take a look? hope the approach makes sense!


For EU cookie compliance, we need to set the max expiry date of cookies to 2 years instead of 13 years

EU cookie laws say the any session/post-authentication cookie can have a max expiry of 2 years. Right now the app insights MicrosoftApplicationsTelemetryDeviceId and MicrosoftApplicationsTelemetryFirstLaunchTime cookies are set with 13 years expiry. This  violates EU privacy compliance. Therefore we need the ability to set cookie expiry date for app insights cookies.

Closing as all cookies expire after at most 1 year


Document deferred_encryption option

My small contribution. Great gem!

Any chance of a version bump for this?

Done.


[Bug]: ReferenceError: process is not defined

Version
System:
    OS: macOS 13.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 28.32 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Browsers:
    Chrome: 125.0.6422.176
    Safari: 16.3
  npmPackages:
    @modern-js/app-tools: ^2.53.0 => 2.53.0
    @modern-js/module-tools: ^2.53.0 => 2.53.0
    @modern-js/plugin-tailwindcss: 2.53.0 => 2.53.0

Details
Idk what's wrong here.
It complains when checking process.env.IS_REACT18.
If modern.config.js set disableNodePolyfill=false, then the error goes away, but process.env.IS_REACT18 is still not correctly set.
Reproduce link
https://github.com/yf-yang/modernjs-monorepo-example/tree/ts-bundler-bug
Reproduce Steps
cd apps/app
pnpm dev

Then open the browser.

The cause:
In a pnpm workspace, I install @modern-js/app-tools at the root folder. Therefore, its internal appDirectory is resolved the root folder. Then modernjs tries to read its package.json to find the react version.
If I execute the command in a workspace folder which installs React 18, then it could not be correctly resolved.


refactor(rust): use Attributes type on RequestEnrollmentToken

Replace Vec<TokenAttribute<'a>> by Attributes<'a> to define the attributes of the RequestEnrollmentToken request structure. It also removes the TokenAttribute type since it's no longer used.
This will need changes on the elixir side, so I'll keep it as a draft while @polvorin tests these changes against the elixir side.

@adrianbenavides  it's ok to merge :+1: .   Once we have identity channel working,  it would be simpler to pass  Attributes directly instead of a  RequestEnrollmentToken  containing an Attributes field  (right now that would be cumbersome and require more changes as authenticated and token creation commands use different ways to pass the identity, so your approach is a good compromise)


Exception in HostObject::get(propName:DemoJsiModule): java.lang.RuntimeException: Got unknown argument class: JavaScriptContextHolder

Can you please help me with this one
after trying a days i finally came into this issue and cant go further
Exception in HostObject::get(propName:DemoJsiModule): java.lang.RuntimeException: Got unknown argument class: JavaScriptContextHolder

I can not access the helloWord() function


macOS support

Support for building on macOS
Changes:

[x] Fix CMakeLists.txt to include the correct directories and link to the libraries it found.
[x] Documentation for Building on macOS

I don't know whether you want to mention macOS support in the README so I didn't.


Generate MSRV in Kotlin file

Currently, when generating Rust crates, the MSRV is read from
gradle.properties by determining the project root using git rev-parse. However, some build environments smithy-rs needs to build on
don't have git available.
This commit uses Gradle's rootDir to determine the project root, and
generates a Kotlin file exposing the MSRV as part of a Gradle build task
that is then published as part of codegen-core.jar. This also has the
benefit that consumers of smithy-rs can read the MSRV from there.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Related: https://github.com/smithy-lang/smithy-rs/pull/3841


Bump kubevirtci

What this PR does / why we need it:
Bump kubevirtci in order to align to CNAO kubevirtci
Special notes for your reviewer:
Release note:
None

/lgtm
/approve


What's next with the project

I do not know if he is writing in the right place, will you still develop the project? From what I can see you can even write a private server, you only need to have the right knowledge of how to do it

No, I have no more interest in this project or the game. If you want to build upon this, feel free to fork the it.


Catalytic activities that are missing 'enzyme type' parent

Hi @hdrabkin
For the MF refactoring @thomaspd and I noticed a number of terms that are directly under GO:0003824 catalytic activity and that could perhaps be integrated under one of the terms that represents the different types of enzymes.
Those are:

[ ]  GO:0032451 demethylase activity: because there are dozens of different demethylases that have very disparate substrates, this one is tricky (ie, ec classes 1.5, 1.14, 2.1, 3.3);  can't just go with EC:1

[x]  GO:0034061 DNA polymerase activity  >>. EC:2.7.7 nucleotidyltransferase activity ;
already present as parent GO:0016779
also has a ' catalytic activity acting on DNA'; not an ec class

[x]  GO:0003964 RNA-directed DNA polymerase activity
Child of above; no cat activity parent

[x]  GO:0004133 glycogen debranching enzyme activity >>  EC: 3.2.1.

[ ]  GO:0061783 peptidoglycan muralytic activity (removal of a muramyl group from a compound.)
GO Def "A catalytic activity that contributes to the degradation of peptidoglycan."
aka 'Muramidase'
So maybe EC 3.2.1: Glycosidases, i.e. enzymes hydrolysing O- and S-glycosyl compounds

[x]  GO:1990055 phenylacetaldehyde synthase activity; EC:4.1.1, because
it is  <IP_ADDRESS>    Phenylacetaldehyde synthase.   Done

[x]  GO:0046905 phytoene synthase activity   EC: 2.5.1; done

[x]  GO:0008987 quinolinate synthetase A activity EC 2.5.1 because this is related to <IP_ADDRESS> Done.

[x]  GO:0010280 UDP-L-rhamnose synthase activity; no EC assigned; working (Metacyc id not helpful)   However, since rhamnose is a 6 carbon sugar, I think 4.1 EC 2.4.1: Hexosyltransferases might suffice

[x]  GO:0046572 versicolorin B synthase activity Thisis  EC Number: <IP_ADDRESS>, so 4.2.1 parent; done

Can they be put under one of these:
GO:0009975 cyclase activity
GO:0016787 hydrolase activity
GO:0016853 isomerase activity
GO:0016874 ligase activity
GO:0016829 lyase activity
GO:0016491 oxidoreductase activity
GO:0016740 transferase activity
Thanks, Pascale

I will edit in line above

I was looking at enzymes which do not map to EC classes the other day.
I reported this one.
I looked into the demethylase one. This one can't be resolved because demethylases can work via  oxireductase or hydroalse mechanism.

Oh you say that in the ticket :)
For the synthases, if they are used to represent "compound" activities,  it would be better to remove them and represent only in process. We have discussed this before but I don't remember the outcome. It  does result in lots of annotation consistency though, so it would be better if "only one way to annotate".
@ukemi  or @deustp01  may remember previous discussions. Maybe they never concluded?

Can you give me an example?

I was  thinking of fatty acid synthase
or  ferrichrome synthetase and other such like. But maybe the ones above are not this type, or they fit neatly  under one EC....

GO:0061783 peptidoglycan muralytic activity (removal of a muramyl group from a compound.)
GO Def "A catalytic activity that contributes to the degradation of peptidoglycan."
this def sounds like a process? It's one of several enzymes that degrade peptidoglycan
A enzyme that has muralytic activity would be a muramidase, which is a type of
EC 3.2.1: Glycosidases, i.e. enzymes hydrolysing O- and S-glycosyl compounds
The def really needs work to include this, ie catalysis hydrolysis of 1,4-beta-linkages between N-acetylmuramic acid and N-acetyl-D-glucosamine residues in peptidoglycan
Lysozyme already has this def;
So maybe merge GO:0061783 into GO:0003796 lysozyme activity, which already has ec mapping.
?

[]  GO:0004133 glycogen debranching enzyme activity >> EC: 3.2.1.
-> moved under 'hydrolase activity'

[]  GO:0010280 UDP-L-rhamnose synthase activity
-> moved under 'transferase activity'

We did all we can for this ticket !
Thanks @hdrabkin @ValWood

Glycogen debranching enzyme is actually a transferase, EC <IP_ADDRESS>. The steps in glycogen catabolism are, first, a phosphorolysis reaction that removed individual glucose residues from the end of a linear polyglucose until only four are left. Then debranching enzyme transfers a three-residue oligosaccharide to the end of another branch, and, finally, a hydrolase (EC <IP_ADDRESS>) cleaves the 1,6 linkage attaching the first residue of the branch to the rest of the glycogen branched polymer.
The confusing part is that in E. coli and some bacteria, these two activities are expressed by two different gene products while in mammals, yeasts, and some other bacteria (phylogeny from Wikipedia), they are expressed by two separate domains of a single gene product, AGL in humans. But it's still two distinct activities with different EC numbers and different GO molecular function terms. PMID:11375985 describes targeted mutagenesis of a yeast enzyme to define and resolve the two catalytic sites.

Thanks @deustp01
I should remove this assertion.
'glycogen debranching enzyme activity' has 3 children in GO:

GO:0004134 4-alpha-glucanotransferase activity EC <IP_ADDRESS> that you describe
GO:0004135 amylo-alpha-1,6-glucosidase activity EC <IP_ADDRESS>
-GO:0019156 isoamylase activity EC <IP_ADDRESS>

Some enzymes annotated to 'glycogen debranching enzyme activity'
are bifunctional, see amigo.geneontology.org/amigo/gene_product/MGI:MGI:1924809
I think the safest is to obsolete 'glycogen debranching enzyme activity', recommend annotation to one of the children, and to the BP.
Thoughts @deustp01  @hdrabkin ?
Thanks, Pascale

Obsolete? Or, given all the history and ambiguity (to remove a four-residue branch completely, both transferase and hydrolase activities are needed), maybe keep 'glycogen debranching activity' as a grouping term with a strong recommendation not to use it for annotation, but to use the transferase or glucosidase child instead? @hdrabkin ? @ukemi ?

I would be more comfortable with @deustp01 's suggestion

We only have 3 enzymes that are directly under 'catalytic activity:

Demethylase is because there are many different mechanisms, but at least the reaction is always to remove a methyl group.
'glycogen debranching enzyme activity' and 'peptidoglycan muralytic activity' are different in that they group many functions to accomplish what seems to be a process. (see also @hdrabkin's comment from July 17th)

GO consistency matters too, and here it looks like a strong argument for getting rid of 'glycogen debranching enzyme activity'. Actually, that might also be an argument for breaking up demethylase activity as well, into one child for each mechanism. Where EC does cleanly classify enzyme activities by reaction mechanism, that classification is worth following for molecular function. Also, we have process terms available (or could make them) to group all the ways of removing a methyl group or all the steps of removing a glycogen branch. (Pretty much repeating @hdrabkin 's comment from July 17th)

...but if we are hoping to remove these "function" terms from the process ontology in the medium/long term (methylation, phosphorylation etc), then maybe for this case the grouping term is better under catalytic activity in function? It could be a do not annotate term, although do we always know the mechanism anyway.
It would not be good if you knew that something was a methylase but you did not know the mechanism, so you could only assign process term? (I never use MF in BP terms ...)

But we should group functions based on shared molecular mechanistic detail; different molecular mechanisms that yield the same outcome, as well as successive steps to an outcome seem like the sorts of things that should be grouped with process terms.

That ship sailed a recently though....
We now have  transcription regulator  activity, translation factor activity, general transcription iniitation factor activity, etc...lots of non-mechanistic (or even  true function) groupings.

..but if we are hoping to remove these "function" terms from the process ontology in the medium/long term (methylation, phosphorylation etc), then maybe for this case the grouping term is better under catalytic activity in function?

Right - but the other axis of classification that we did with @thomaspd was to do with the type of substrate (we have

'catalytic activity, acting on a protein'
'catalytic activity, acting on DNA'
'catalytic activity, acting on RNA'
we wanted to add some more classes, including 'acting on metabolite' and possibly 'acting on polysaccharide'

but the  'glycogen debranching enzyme activity' and 'peptidoglycan muralytic activity' branches are really reflecting a process, as far as I can tell; I think it's quite different from phosphorylation.
Pascale

We also now have a substrate axis of differentiation.

I have methyltransferases (5)  in "conserved unknowns" where all we know is that they are methyltransferases. I  don't know anything about the substrates (although I predict that some are ancient  tRNA methyltransferases).
I would like to continue to annotate to MF methytransferase, and not to "methylation"

It's OK if methyltransferases stay. The idea was to try to group things as much as possible - if this is the maximum, it's OK.
I am not sure the grouping terms are needed for 'glycogen debranching enzyme activity' and 'peptidoglycan muralytic activity' but if people feel they are needed they can also stay.

based on Peters comments do we really need
'glycogen debranching enzyme activity'?
in fact the children of this term don't even appear to be glycogen specific.
peptidoglycan muralytic activity also seems odd and has no direct annotations.
I agree they aren't needed

What is the action here?
at one point in the ticket  it says
"We did all we can for this ticket !"
than it goes into potential
obsoletion of  'glycogen debranching enzyme activity'?
If this is still an action should we put it in a new ticket so that nobody has to read all of this?
Please summarize action @hdrabkin

sure lets close


Fix for issue #5

Fix for issue w/ no codec description
More debug logs added

Please ignore, this was supposed to be applied to my fork of the project.


Weird snappy animations

I've written about this more in this issue: https://github.com/kmagiera/react-native-reanimated/issues/231
I'm not entirely sure what the cause could be, which library might be causing this or if it's my own code even. But I also don't know where to start looking.
Does react-navigation-animated-switch do anything that could cause my animations to go crazy right before transitioning out?

it'd be good to create a reproducible example of what you're seeing here, and also explain what platform you're seeing it on. i haven't seen such a thing in my brief experiments

I’ve experienced the same. Adding reanimated seems to affected other transitions other than the switch. For example all my modal screens inherit the same transition as the one specified for the switch navigator.
Also more related to this lib, my modal screens are doing the closing animation twice when dismissing via navigation.goBack

@brentvatne That's a fair request. I was hoping it was something known so I wouldn't have to make an example. I'll try to make a small example, but I do suspect it's reanimated at work, and not this plugin. But I might be wrong.

Long story short... I've implemented a hacky version of this repo that works better for me. After some investigation I got into all sorts of problems with reanimated and the switch unmounting before it's done transitioning, react-navigation's animated position being reset hard causing my interpolations to do funky things... etc.
So this library might not be for me. What I did instead is something that's also funky, but... Yeah.
const AppNavigator = createStackNavigator({
  Splash,
  App,
});

const prevGetStateForAction = AppNavigator.router.getStateForAction;

AppNavigator.router = {
  ...AppNavigator.router,
  getStateForAction(action, state) {
    const { type, key } = action;
    const actionName = 'Navigation/COMPLETE_TRANSITION';

    if (!state || state.routes.length < 2 || type !== actionName || key !== 'StackRouterRoot') {
      return prevGetStateForAction(action, state);
    }

    return {
      ...state,
      index: 0,
      isTransitioning: false,
      routes: [state.routes[1]],
    };
  }
};

Hey everyone.
Here's some gifs.
This is not a switch transition. It's just a normal navigation.
Here's the usage: https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/reanimated-switch/app/index.js#L173
With this lib:

Without it:

can someone please provide a minimal reproducible example? :)

Sure @brentvatne https://github.com/iRoachie/animated-switch-bug-example

thank you @iRoachie!

try 0.1.1, i made it so the transition is only animated when the index changes on the switch

@RWOverdijk - would be super useful to have a minimal reproducible example for your use case

@brentvatne I get that, but it's a bit of a pita to create right now. The icky code I wrote is icky, but works.
Feel free to close this when you feel it's a good idea to do so. I'll provide the example in the future, when I run into it again. You know deadlines :D

I'll leave this open and hopefully you'll have some time once your deadline comes up to share an example :)


Reusable workflows for starting/stopping self-hosted OracleCloud runners

Closing because matrix is not supported in reusable workflows, and filesystem is not shared between workflows


Documenation and broken links

Category

[ ] Question
[x] Bug
[ ] Enhancement

Link is broken

documentation of list seems to be incorrect

Thank you @Shamrh . I have created a PR to fix this issue. #124

#124 merged, so closing.

thx @bcameron1231  for the fix and @Shamrh for reporting the issue.


Chunked basebackup

Fixed all review comments.

Unittests pass in travis now with the tuning of a test timeout.


Allow customization of terminal commands

Hi,
Love the tool, thanks for all your hard work!
I have a small issue that over time is becoming more annoying.  Because of the pull request mechanism we use, the branches we create locally are never merged back into master, that always happens remotely.
This means that when we go to delete local branches using gitlens, we always have to rewrite the command that it puts into the terminal from "-d" to "-D" or add "--force" in order to suppress the warning that the branch has not been fully merged.
Is there any way to change this behavior to use the uppercase D when using git lens to delete a branch?  This is becoming an annoying repetitive task on our team.
Thanks!

Hi. Is there any chance that I take part of this issue? I was trying to do a merge enabling --no-ff but i couldn't.
Can I clone the develop branch, make the changes and create a pull request?

I believe these issues are now fixed in GitLens 11 -- since you can specify many of these flags in the quick pick menus for each of these commands.


E: Unable to locate package xserver-xorg-input-vmmouse

Please paste the output of the following command here: sudo edit-chroot -all

name: sid
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/sid...
crouton: version 1-20161129162558~master:5f2f11f9
release: sid
architecture: armhf
targets: lxde,keyboard,xorg
host: version 9150.0.0 (Official Build) dev-channel daisy
kernel: Linux localhost 3.8.11 #1 SMP Wed Jan 4 03:01:11 PST 2017 armv7l GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/sid...
Please describe your issue:
The chroot setup can't finish, because it's trying to do something with xserver-xorg-input-vmmouse, a package it can't find.
If known, describe the steps to reproduce the issue:
Just try to create a chroot:
sudo sh ~/Downloads/crouton -r sid -u -t lxde,keyboard,xorg

For others getting the same problem, until that is really fixed in crouton, you can force things by doing:
sudo enter-chroot -u 0 -n sid
this will get you a root shell, allow you to edit /setup.sh (or some such -- a shell script at the root) to remove the line mentioning the *vmmouse package (don't forget to remove the continuation backslash at the previous line too!) ; then get out and:
sudo enter-chroot
will ask to finish the setup, and answering 'yes' will actually work.

@SnarkBoojum,
Thanx for the workaround.
It looks like it's coming from xorg#L189, maybe it is not valid with the 'sid' / 'arm' combo ???
Perhaps some more conditionals will have to be added once the devs get a chance to look at it.
Hope this helps,
-DennisL

This also occurs with the stretch target, but the same work around applies (modify prepare.sh, etc).

As a reference https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831420 xserver-xorg-input-vmmouse package is obsolete. This will also affect newer ubuntu releases (need to check which). Checked Kali-rolling it is also missing the package.
Should be labelled as a crouton bug.

@SnarkBoojum @msturgill Can one of you please post the error messages you get with xserver-xorg-input-vmmouse . I can't replicate it on amd64 and I don't have an arm based chromebook. It will be trying to remove xserver-xorg-input-vmmouse, but maybe for some reason when doing that it errors out on arm.

Well, the error message is that the package doesn't exist anymore ; if you look here, you'll see it is gone from testing, unstable and experimental : it won't be in the next stable. My guess is that you can't replicate because you try to install the current stable, which is the last one to have it.

@SnarkBoojum On amd64 it works ok. It does see that the package doesn't exists and ignores uninstalling just fine and continues the install script. I need the exact error messages that it spits out on arm, so we can fix it in crouton. It should not error out on a non existing package trying to uninstall.

E: Unable to locate package xserver-xorg-input-vmmouse
Failed to complete chroot setup.
The armhf package for xserver-xorg-input-vmmouse doesn't exist.


Allow admin to set organization language at creation time

Commit-1: Adds a new dropdown, 'Organization language,' to the /new and /realm/register pages and utilizes it to set the default_language field of the Realm model.
Commit-2: Uses the Realm.default_language value, which is set by selecting the 'Organization language,' to internationalize the introductory messages of the initial streams.
Fixes: #25729.

Screenshots and screen captures
https://github.com/zulip/zulip/assets/87542880/f989f46d-2055-4fe3-90d5-860b476cb233

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@Ujjawal3, could you please take a look at this PR?
@zulipbot add "buddy review"

@HemantUmre12 I did review of some files. Till now the changes looks good to me. I will complete the review by today evening. Can you tell how to do the manual testing of the changes? I tried to test but there is no option for choosing default language while creating new realm in dev environment.

@Ujjawal3, you can use ./manage.py generate_realm_creation_link to simulate the onboarding process.

@Ujjawal3 you can also use the "New organization" link which is available in the footer when you log out in the dev server.

@HemantUmre12 I did the manual testing and reviewed the code changes. Almost everything looks good to me. Just a few minor points:

As mentioned in issue description add a ? button linking to /help/configure-organization-language.
I think it will be better to mention in second commit message that language for introductory message will be the default language chosen while creating realm.

@sahil839, this PR is ready for another round of review. The changes since your last review are listed below:

According to the discussion here, I have added a separate commit for Unicode normalization of language names when creating language_name_map.json. I think normalizing the rest of the message when pulling from transfix can be tackled in a separate PR, as we do not get language names particularly from transfix.

Also, one thing I noticed is that the dropdown in realm creation form has more options than we have in the Organization settings panel dropdown.

There we are allowing languages with a translation percentage >= 5% as an option. So, I have created get_filtered_language_list() to do the same.

Renamed the variables as you suggested.

Added a test for translation in the last commit.

@sahil839 made the changes. Ready for another round of review.

I noticed that the user's language would not be the same as that selected for the realm if the user selected a language other than the browser default for realm. I am not sure but I think this might confuse users. If we set the user's language also to the realm language, it will not be consistent with the other users who sign up after the realm is created, as for them we give preference to the browser language and then the realm default if needed.

Looks good to me.
Now reading the code again I am not sure how to handle the invalid language same. By reading your test, I was considering the case where invalid language can be passed when creating realm through API, but on reading the code again I am not sure that URL can be used as an API endpoint by clients, since the url returns template or a redirect as a response.
And since we use a dropdown in the UI, I think we can just remove the error message code from template and also probably the test for that case. I also checked the existing code for handling organization type and we do not test the invalid type case. We can also wait for Tim's feedback if you want or you can just remove the test and the error message code in template. Sorry for the inconvenience.

@sahil839, I have removed the error code for now to maintain consistency. We can add that separately along with the organization type if we want.

Other than the above point, the PR looks good to me. @timabbott I think this PR is ready for you to have a look and would be good to have your feedback on a couple of points discussed above.

Sorry for the long delay in integrating this! I rebased the migrations and other small tweaks, and added a couple commits on top designed to fix a weird focus experience problem noted while testing it.
Thanks for doing this @HemantUmre12!

I removed the get_filtered_language_list function, since the 5% filtering should be being done in what languages we commit to the codebase (we sync using tx pull -a -f --mode=translator --minimum-perc=5), and thus get_language_list already has that filtered.
https://github.com/zulip/zulip/pull/26102#discussion_r1242031069


Added modules and define_module macro

Adds modules which are just collections of providers that can be registered all at once in an InjectorBuilder
Adds a define_module! macro which can be used to easily create those modules

Need to update docs to bring attention to modules


Feature-request: Copy the link on pressing the meme with right button of the mouse

I'm glad you added the feature that displays the source of a meme.
In this request what I want?
Displaying the source of the meme is very cool, but there's some memes, that is unknown. Sometimes, I try to find info about source of unknown memes, but in amii-assets.unthrottled.io I can distinguish memes with unknown source from known source by clicking through all of them and checking if they have Unknown female. This is not very convenient.
Sometimes I see in the IDE a meme that I would like to watch its anime, but it has unknown source, so it's impossible. It would be cool if I can get direct link to its page in amii-assets.unthrottled.io by clicking right button of the mouse. By that it would be much easier to find infos of memes.

Or, if the meme has unknown source, put a text Copy link next to Stop Showing Info.

@Dragon-0609 If you ever go to a link directly does this happen to you?

Sample: https://amii-assets.unthrottled.io/assets/view/d9e6e0126e9cf8ca543a1ca26c9b176c

If you ever go to a link directly does this happen to you?

It happened when I had opened by Open in new tab. But if I open in main page just by clicking on it, it is opened immediately.
Can't you add script to redirect from main page?
For example:
`https://amii-assets.unthrottled.io/?redirect=<id of meme 'd9e6e0126e9cf8ca543a1ca26c9b176c' or 'assets/view/d9e6e0126e9cf8ca543a1ca26c9b176c'>
If you redirect from main page, I'm sure it will be opened properly.

Ah, the issue is in some of the rendering code. It is a single page application (eg the same index.html is used for all routes), I just didn't do enough of a good job to handle loading the app on that route. Will let you know when is fixed.

@Dragon-0609 Fairly confident that I fixed the white screen issue, let me know if it happens to you again. If it does, could you make sure that the browser hasn't cached an older version of the content?


iOS 17 Transparency rendering exception

⚠ Issues not using this template will be systematically closed.
Describe the bug
iOS 17 When filament renders a shadow material and the shadow image has transparency, an abnormal display occurs. But it did not happen before iOS17
To Reproduce
Steps to reproduce the behavior:

Custom shadow.inc with transparency

_mMaterial = Material::Builder()
.package((void*)SHADOW_COLOR_PACKAGE, sizeof(SHADOW_COLOR_PACKAGE))
.build(*engine);
_mMaterailInstance = _mMaterial->createInstance();
const TextureSampler &shadowSampler = TextureSampler();
_mMaterailInstance->setParameter("texture", _mCameraTexture, shadowSampler);

Expected behavior
Materials with transparency also display normally
Screenshots

shadow.mat.zip
Logs
If applicable, copy full logs from your console here. Please do not
use screenshots of logs, copy them as text, use gist or attach an uncompressed file.
Desktop (please complete the following information):

OS: [e.g. iOS]
GPU: [e.g. NVIDIA GTX 1080]
Backend: [OpenGL/Vulkan]

Smartphone (please complete the following information):

Device: [e.g. Pixel 2]
OS: [e.g. Android Pie 9.0]

Additional context
Add any other context about the problem here.

what does it mean "the shadow image has transparency" ? Can you provide a gltf file showing the problem?

Closing due to lack of information/inability to reproduce. If this is still a valid issue, please provide a patch we can apply to one of our iOS samples to reproduce the issue.


Sorting and ordering of queries

Is your feature request related to a problem? Please describe.
Currently, the queries are sorted in random order. In case of any queries, it is good to sort by likeliness

Describe the solution you'd like

Sort the queries by the next score of the likes & dislikes.
Or provide the sorting options i.e. By Update date time, By Likeness
Additional feature best to have to allow the Owner to PIN the query at the top

Describe alternatives you've considered
Non-alternative, users have to scroll down even the query that is most liked may end up at the bottom.

fixed with https://github.com/open-metadata/OpenMetadata/pull/15591

thanks for adding feature @ShaileshParmar11 . Filtering and sorting looks great in the video


use setuptools for demo python package

Can you say more about what needs to be added?

As in, instead of hatch: https://github.com/rstudio/package-manager-demo/blob/main/python-package-manager-demo/pyproject.toml#L1-L4
Adding hatch to the list of td dependencies does not result in being able to build the package.

After some experimentation, I do not think using setuptools will help. The issue was that the repo that contained the demo package did not have a hatchling (or any other Python packages available). The fix is to ensure that pip has access to the required packages needed to build the demo package (whether that be hatchling or setuptools).
pip config set global.index-url https://enchanted-axolotl.staging.eval.posit.co/pkg/pypi/latest/simple
pip config set global.extra-index-url https://enchanted-axolotl.staging.eval.posit.co/pkg/internal-python/latest/simple
pip config set global.trusted-host https://enchanted-axolotl.staging.eval.posit.co

pip install package-manager-demo


Prop to set class of list and list items

Problem description:
I'm unable to apply a class to the
 and
 when displaying suggestions.
This is problematic in my case, as I have some style selectors which check for direct descendants (I can't get away with applying the style to the container). I've also got some pre-existing styles which I'd like to apply to the
.
Suggested solution:
Add an equivalent component-attr-class-autosuggest-results-container for the list and list items.

@nickbetsworth sounds like a good improvement. I had wanted to make the
 and
 items composable, something like:
<vue-autosuggest v-slot="{listProps, listItemProps}">
  <input />

</vue-autosuggest>

but it turned out to not be easy since vue-autosuggest controls a good portion of the internals and would need a bigger rewrite. For now, I would probably want to add instead a listAttributes and listItemAttributes props, so that you could add more than simply class. For instance, you might want to to add arbitrary data-attr or otherwise.

Agreed I'm looking at integrating this into some work and we are using tailwindcss and just the way things work we can't use component styles so this would be a very nice addition.

Fixed in<EMAIL_ADDRESS>Will be in v2.1.0 eventually but want to test out some things before bumping minor version.


Publish status event when starting for SMPP transport

Similar to #983-#988, except for when we start connecting.

Publishing connecting events is going to require changing ReconnectingClientService to support hooks for when we connect. For now, I've renamed the ticket to be for publishing status events when the transport is starting. The plan is to add connect event publishing in a different PR once we are able to add hooks for when we are reconnecting.

Ready for review.

:+1:

But we must watch out for https://github.com/praekelt/vumi/pull/992 and this, we need to make sure that one lands before the other, and that the relevant changes are made in the other.

@rudigiesler thanks, merging in #992 and making the relevant changes. Will land once #992 lands.


Multiple engines requiring each other only show their own files in the reports

Hi!
First of all, thank you all for your work! Simplecov is an awesome gem <3
Now for the downsides, I'm having some trouble configuring it in our Project. I'm working in Decidim (https://github.com/decidim/decidim), a platform to empower participatory democracy.  We're using a mono-repo approach to organize the code, each folder is a different gem. I've seen @deivid-rodriguez around, he's worked on the project too in the past 😄
In our case, we have a set of gems that build upon a central one (decidim-core). This means each gem uses code from decidim-core. Each gem has its own spec_helper.rb, although they all look almost the same. We configure SimpleCov through the .simplecov file in our root folder. We run the test suites individually through Github Actions. Our current setup runs each gem test suite independently in different workflows (and thus in different file systems), so only one test suite is run at a time. This is effectively the same (for testing purposes) as running a single test run in your machine. We're not mergint the test suite manually. Instead, this merging is done by Codecov.
Now, whenever I run the tests for one of the gems I'd expect the report to include files from the module and from decidim-core. For example, running the tests from decidim-proposals should include decidim-core files, but it doesn't. I'm playing around SimpleCov configurations in https://github.com/decidim/decidim/pull/5934, but so far the reports only show files form the given module, no extra ones (even though I've set SimpleCov.root correctly). I've also tried the snippet in the README file to load files from engines, but without any luck.
Since we're exporting the coverage reports to Codecov, I'm using the simplecov-cobertura formatter, which is the one recommended in the Codecov docs. I've checked the internals of that gem and it doesn't seem to filter files, so I think the problem comes from a misconfiguration in our part.
If you'd like to check the test suite locally, these are the required steps:

Clone the repo and cd into it
bundle install
bin/rake test_app
CI=1 SIMPLECOV=true bin/rspec ./decidim-proposals/spec/system/proposals_spec.rb:50
Check the coverage/coverage.xml file

This step I'm using is a system spec that checks a #show page for a resource. This page uses code from decidim-proposals and decidim-core, but if you check the coverage file you'll see how it only shows code from decidim-proposals.
Technical details:

Ruby 2.5.3p105
SimpleCov 0.18.5 (latest)
simplecov-cobertura 1.3.1 (latest)

PD: Feel free to change the issue title if you can come up with a better explanation! Also, ping me if something's not clear enough!

After commit b08f14b in my repo, I see a couple of things, which I don't know if should be considered as issues or not:

SimpleCov.track_files doesn't seem to use SimpleCov.root. In our case, we moved SimpleCov.root to an upper folder, but SimpleCov.track_files doesn't take all files into account. Instead, we had to manually change it to include the files in the same folder.
Now that we're correctly tracking all the files, our coverage reports still don't show any hit in files from other folders. Should we manually require all Ruby files?

I feel I'm missing something in the definition of "tracked files". For what I see, you want to use "tracked files" in order to ensure you're not missing any files in the report. But this does not ensure hits will be counted.
I'll try manually requiring all Ruby files, see if that improves something.

Possibly related to #572, BTW

@mrcasals :wave: Hi there and thanks for the report! :wave: :green_heart:
Yes, tracked_files doesn't have the best of documentations - one of the things in the way of a 1.0 release :sweat_smile:
So track_files really just makes sure they are included even if they aren't required. The way the underlying coverage library works is to just add everything that you required to the report. Now, usually you don't want to see that for your gems hence the "root filter" was invented.
To me it sounds like a problem/combination of requiring files after simplecov starts and possibly the root filter. Otherwise files should be shown.
Not super helpful right now but maybe it already helps you figure this out. Depending on things I might also have time to investigate myself :)
Anyhow, thank you!

Hi @PragTob, thanks for the warm welcome! 👋
I tried what @nullvoxpopuli did on https://github.com/colszowka/simplecov/issues/572#issuecomment-294493115 and I get 3 calls for a given file. This is what made me point to #572 as a possibly related issue. Unfortunately, though, I'm not sure how to check whether this is really true, and how to fix it 😞
Decidim is complex, and maybe this complexiity is what's getting in our way. For example, we have to use a dummy Rails app to run the tests (at least some of them). This app requires the gems via a :path option in its Gemfile, and maybe this is making the files reload. So, from the top of my head, what I suspect is happening is:

When I run the tests from a gem it loads the files inside.
It loads the dependencies
Then it boots the test app
And loads its dependencies, thus reloading the files
At some point, files get reloaded again for some reason

That would explain why I'm getting 3 loads per file, but I'm just guessing here.
Anyway, I think I'll try to get my PR merged as is, and try to explore further in the next weeks. It'd be awesome if you could investigate a little, but I understand this would reequire time and we all have things to do, so no worries!
Thanks for the support! 😄

Hi @mrcasals!
Long time no see, I hope everyone in the decidim world is doing fine in these odd days :)
In case it rings any bells, I remember configuring simplecov for decidim and having trouble with:

SimpleCov.root getting a incorrect value. I think this was related to the PWD and using relative paths, so I tend to remember explicitly setting it to the absolute root path of the repo.
Coverage reports overwriting each other. I remember fixing this by explicitly setting a different SimpleCov.command_name for each subrepo, so that they are properly merged instead of overwritten.

Probably not related to your current issue, but just in case.
Also, I'll try to find time for this myself too!

Files shouldn't be reloaded unless someone is "evil". Evil in the sense of spring or something, or ActiveAdmin also used to hardcore load file. I mean, normally files should just be require'ed which shouldn't cause any duplicate loading as ruby checks that.
One of my favorite methods is good old puts debugging where I just put puts statements at the beginning of the files to see when/how they are loaded.

Mh, we don't use spring AFAIK, and we don't use ActiveAdmin... I'll try with the puts-based debugging, see if I get something, thanks! 😄

Hei @mrcasals!
This is probably not related, because I believe decidim is still on ruby 2.5, but I was also going nuts because of stuff being clearly misreported as uncovered on my library, and it ended up being a regression in ruby's coverage library.
I reported it here: https://bugs.ruby-lang.org/issues/16776.
Letting you know anyways just in case, because I remember using a newer ruby than I was supposed to while developing decidim locally :sweat_smile:.

So, after getting a reply in there, I'd say it's not related to your problem.
At first I thought it could because Rails 6 uses a new code loader, zeitwerk, which does use some TracePoint hooks (which is what the coverage library no longer supports). But decidim does not yet support Rails 6, so I'd say it's not it.

Wow that's some interesting interaction right there.

This is probably not related, because I believe decidim is still on ruby 2.5

@deivid-rodriguez exactly, it's still using a 2.5.x Ruby version, and no support for Rails 6 yet (it's on Rails 5.2.x)... I've double-checked, and both my dev machine and the CI use the correct Ruby version.
One solution is "add tests for each module so code is not tested through other modules", but that'd take quite a lot of time, and for specifics on how Decidim is organized we don't have much work-time to invest on this.
Is there any way I can help on debugging this? I'm pretty sure it might be an issue on our side, but I'd like to understand what's going on 😄

Hi @mrcasals!
I'd like to find some time to investigate myself, but... I'm not too positive that will happen :sweat_smile:.
My suggestion for debugging this is to try to progressively eliminate stuff from the picture. Reproduce it running a single spec, start removing requires, try to get a repro directly without using RSpec... and so on, until you can at least figure out a clear culprit and that will hopefully give more clues at least on where to report it.
That's how I isolated https://bugs.ruby-lang.org/issues/16776, which at first I thought it was a simplecov issue, but it ended up being a problem with ruby's coverage library.

Hey everyone,
I'm not too sure I'll get to it either although I recently decided I'll do more Open Source again. Albeit, this week I'm trying to run the first ever remote Ruby User Group Berlin so I might be biting off more than I can chew :)

@PragTob @deivid-rodriguez first, thanks for your time on this issue and open-source in general. It's always been a pleasure working with you, either directly or through your libs, so thank you very much!
I know this issue might be complicated, and maybe it's not even a problem with simplecov but a configuration issue on our repo, and due to Decidim's size it might be difficult to debug, so don't worry if you don't have time for this, I completely understand! 😄
Also, thanks for your ideas! I'll try to find some time to debug what's going on, maybe even try to replicate it on a smaller scale 😄

Sooo, I had a look at this today and this is a bug in simplecov. Fix should be simple, I'll create a PR tomorrow!

OMG @deivid-rodriguez thank you so much for taking the time to look at this! ❤

@mrcasals No problem! #894 should do the trick!

Thanks a bunch @deivid-rodriguez :green_heart:

@mrcasals if you could confirm whether this really fixes your problem, that'd be great! I might also consider cutting a release soon.

@PragTob I haven't tried it myself, but it seems like it's working properly! 😄 See https://github.com/decidim/decidim/issues/6230#issuecomment-649589074


Update plugin-publish-plugin

Hiya, I was doing a scan of the Gradle Plugin Portal and noticed you are using an old version of the plugin-publish-plugin.
There was a bug in versions prior to 0.9.7, where artifacts would silently not be pushed into the repo, which means the latest version of your plugin will not work properly when people apply it to their build.
Upgrading to the latest version of the plugin-publish-plugin will fix this, but this will require pushing a new version of your plugin.

apply the PR
publish a new version of your plugin
let us know if you want us to remove the broken version <IP_ADDRESS>

Thanks (and sorry about that).
Let us know here or in the forums if you need more assistance.

@timyates Thank you for this fix, I have been wondering why I was suddenly experiencing a few issues with the publish plugin.

👍  Let me know if you see any more issues!
Have fun!


[Feature] Java SDK adds EventMesh Workflow Client

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event orchestration  capabilities
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Yes I am willing to submit a PR!


Move jakarta.enterprise.inject.build.compatible.spi to another spec (jakarta.build.inject?)

Hi all,
jakarta.enterprise.inject.build.compatible.spi has no real link with CDI except a few annotation overlapping so it is really worth extracting it in a "build IoC" dedicated spec to benefit to the whole platform.
The drawbacks are obvious:

No way to use "CDI" but you can only use subpart os CDI (build is incompatible with runtime part and the opposite by design and API)
No way to use CDI lite with EE - EE design is runtime which makes it strength and enterprise readiness by enabling to work on already compiled code (frameworks, tooling, transversal concerns of companies .... Indeed, EE can become more build oriented but it is a totally different design as shown by CDI lite work and requires a rethinking of the framework so better to not mess up everything and keep API straight forward (and avoid the "oh, even if I put code it is ignored??" on user land)
User inconsistency: it is unlikely an user finds it natural until he checks the implementation(s) because the API is exposed as a while but is not used as such as explained
"Framework integration with CDI" means nothing since it is either at build time or at runtime (or 2 integrations) so will create a lot of noise
There is no technical limitation as of today to use CDI in lite mode without all the new annotations, it got proven by multiple impementations and it can even be already reflectionless technically if desired (not sure the gain is worth it but technically we know how to do it)

Indeed the advantage of this package is obvious: design closer to graalvm (which is a good thing)
So overall this task is about not polluting CDI which is a strong, core and widely used basis in the industry and enable users to start PoC-ing build time EE code through an incubating new specification which could connect to CDI by an appendix (proposal).
After 1-2 years we can review what was there and check it is relevant or not to include in CDI but as of today there is no real strong argument to do so but several to not do.

+1
I said it before and will say it again: killing backward compatibility just for supporting another edge case (Quarkus) is a move which I'm not in favour. Especially when there are other native frameworks and containers who managed to implement it without breaking backward compat already. sadpanda

+1 for extracting it

to be honest, i dont even understand why we call it "cdi-light"? Its not lighter, maybe better to call it something like "cdi-buildtime"

I am not sure the purpose of this APIs, hope it work as Micronaut, generate all essential descriptive classes instead of annotations and reflections at runtime, thus the codes are ready for native image building.

CDI 4.0 has been released some time ago with the BCE SPI as part of this specification meaning this issue is no longer relevant; closing it.


[DRAFT] Mrg32k3a offset

Fix for #234 for the mrg32k3a engine.
Do not merge this yet

Replaced by #239


Point ordering differs between runs

What steps will reproduce the problem?

Running any boolean operation. The simplest case was the difference between
two cubes.

What is the expected output? What do you see instead?

Visually, the result is OK and identical between runs. Structurally, the
ordering of the points is different between runs, i.e. a point with a given
position will not always have the same index in the vertices vector. The
ordering of points in a face loop also seems to differ.

What version of the product are you using? On what operating system?

Latest hg version (changeset 45070ee2dab0) on Ubuntu Karmic 32 bit.

Please provide any additional information below.

I am trying to integrate CARVE support into the K-3D modeler. A dashboard
test showing the effect can be found at:
http://www.k-3d.org/cdash/testDetails.php?test=634693&build=3043
In the diff, the points array should correspond exactly to the CARVE
polyhedron vertices vector.

A visual comparison can be seen on my blog:
http://k-3d.org/blogs/barche/2010/01/27/first-carve-boolean-results/

The ordering of components is important in K-3D, due to the pipelined
nature where subsequent steps may depend on the index of selected
components, i.e. "extrude face 3".

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 27 Jan 2010 at 9:28

Ah, many thanks, that is a big improvement. Only one test with intersecting
edges is
still failing, details are posted on
http://k-3d.org/blogs/barche/2010/01/27/first-carve-boolean-results/

The canonicalize operation does not seem to be a big performance hit, it is 32
times
faster than the boolean op itself, so if this can be used to guarantee
consistency,
that seems fine to me. See
http://www.k-3d.org/cdash/testDetails.php?test=637163&build=3063 for a
breakdown of
the timings.

I'll experiment some more, one optimization I still have to do is to only
triangulate
when necessary, i.e. on non-planar faces and faces with holes.

Original comment by<EMAIL_ADDRESS>on 28 Jan 2010 at 11:29

As an interim measure, You can call polyhedron->canonicalize() on the CSG to
ensure that the vertex and
face orderings are consistent between runs. This involves sorting, so it's not
an ideal solution, but it'll get you
further in your testing.

I agree that ideally the result from successive runs should be the same not
only spatially but in terms of
representation and ordering.

There are a number of places where Carve uses stl unordered maps and sets
containing pointers, and
obviously this means that the ordering of elements in the collection is
dependent on the heap environment,
making this a potentially hard problem to fix.

Original comment by<EMAIL_ADDRESS>on 27 Jan 2010 at 11:11

Changed state: Accepted

We use the GLU triangulator, the attached archive contains input A and B after
triangulation, as well as two different outputs from K-3D after doing A minus
B. I
can't reproduce the difference using the intersect command line tool, though.

The tests are part of our CDash dashboard, which is provided by the CMake build
system. It's open source, see http://www.cmake.org/

Original comment by<EMAIL_ADDRESS>on 29 Jan 2010 at 11:55
Attachments:

carve_cylinders.tar.gz

For faces with holes, you only need to link the holes to the face loop, which
is the first step of most triangulation
algorithms in any case. Are you using the GLU triangulator, or some other
method?

If you could, it would be useful if you could attach the objects (preferably in
.ply format, but anything will do)
that constitute the failing case, and I'll take a look at why canonicalize()
isn't returning a unique result.

I'm also curious as to what you're using for your testing for k3d. it looks
like a pretty nice system - is it open
source?

Original comment by<EMAIL_ADDRESS>on 29 Jan 2010 at 2:32

I've taken a further look, including adding some heap randomization code to the
intersect binary to try and
trigger differences between runs, and I'm not getting anywhere. The results
that you have show one of the
intersection points moving slightly, and I can't see how the determination of
the intersection points can be order
dependent.

If you can reliably reproduce a difference in successive runs, could you please
apply the attached changeset
(better debug output) and compile with -DCARVE_DEBUG, and send me the debug
logs for the two cases? The
changeset should apply cleanly against the current head.

Original comment by<EMAIL_ADDRESS>on 5 Feb 2010 at 5:16
Attachments:

changeset.debug

I've made an updated testcase, writing PLY files at different steps using the
CARVE
writePLY function, to exclude any K-3D influence. The file contains the inputs
and
outputs from two different runs. Inputs are identical, the results show the two
switched points.

Original comment by<EMAIL_ADDRESS>on 30 Jan 2010 at 9:47
Attachments:

ply.tar.gz

I just committed a patch that appears to correct the cube issue. Could you
please test it and see if it works for
you? There are also a bunch of changes which are partial commits of the debug
info changes, so the debug
changeset above is now invalid. I've attached a new patch that should be
applied against the current head, in
case you want to do that.

Original comment by<EMAIL_ADDRESS>on 10 Mar 2010 at 5:00
Attachments:

debug.patch

Thanks, the cube test passes all the time now! There is only an occasional
failure on
the cylinders case left.

Original comment by<EMAIL_ADDRESS>on 11 Mar 2010 at 8:49

OK, sorry for the delay, but attached is the output you requested. It contains
both
the cylinders testcase and a cubes testcase. In the cubes case, the edge
linking a
hole in one of the faces differs between runs (see the screenshots), and the
GLU
triangulator was not applied in K-3D before the boolean operation.

Original comment by<EMAIL_ADDRESS>on 6 Mar 2010 at 10:55
Attachments:

carve-tests.tar.gz

Could you please apply this new patch to the current repository tip? It gives
me a bit more information around
the site of the problem.

Original comment by<EMAIL_ADDRESS>on 12 Mar 2010 at 3:13
Attachments:

debug.patch

Ok, I've reproduced the cube issue. It occurs in the code that links holes back
into containing faces. I think this
should be fixable, once I've tracked down the code that causes the problem.

The cylinder problem is more interesting. From the logs, it occurs early on in
the process, when intersections are
being formed. It will involve more log delving to work out what exactly differs.

Original comment by<EMAIL_ADDRESS>on 9 Mar 2010 at 12:26

OK, the new output is attached!

Original comment by<EMAIL_ADDRESS>on 18 Mar 2010 at 10:23
Attachments:

carve_ply_test.tar.gz

Ok, I think this is what's happening:

I suspect you're doing two CSG operations, but only calling canonicalize() on
the result. If I'm right, then the
differing order of vertices in the intermediate result means that rounding
errors cause edge-edge intersections
to occur in slightly different places in the result, leading to the differences
you observe.

I will try to make the intersection code more robust to vertex ordering
changes, but if the above matches reality,
could you please try calling canonicalize() on intermediate results to see if
it fixes the problem?

Original comment by<EMAIL_ADDRESS>on 19 Mar 2010 at 5:37

int main(int argc, char **argv) {
TestScene *scene = new TestScene(argc, argv, 3);

   carve::input::PolyhedronData data;

   data.addVertex(carve::geom::VECTOR(1,1,1));
   data.addVertex(carve::geom::VECTOR(-1,1,1));
   data.addVertex(carve::geom::VECTOR(-1,-1,1));
   data.addVertex(carve::geom::VECTOR(1,-1,1));
   data.addVertex(carve::geom::VECTOR(1,1,-1));
   data.addVertex(carve::geom::VECTOR(-1,1,-1));
   data.addVertex(carve::geom::VECTOR(-1,-1,-1));
   data.addVertex(carve::geom::VECTOR(1,-1,-1));

   data.addFace(0,1,2,3);
   data.addFace(7,6,5,4);
   data.addFace(0,4,5,1);
   data.addFace(1,5,6,2);
   data.addFace(2,6,7,3);
   data.addFace(3,7,4,0);

   carve::poly::Polyhedron *p = data.create();
   glNewList(scene->draw_list_base + 1, GL_COMPILE);
   drawPolyhedron(p, .4, .6, .8, 1.0, false);
   glEndList();

   scene->run();
   delete scene;

return 0;

i can't get the cube,why?

Original comment by<EMAIL_ADDRESS>on 27 Aug 2013 at 6:52

The test is just a boolean between the files I sent with comment 5, so no
multiple
ops. If I canonicalize both inputs before the op, I get a segfault, strangely
enough.
See attached file for the log and the backtrace.

Original comment by<EMAIL_ADDRESS>on 19 Mar 2010 at 10:34
Attachments:

carve-k3d-segfault.txt


[SECURITY] Upgrade FBJS to avoid ua-parser-js exploit

Hello,
There was an exploit reported in a version of ua-parser-js:
https://github.com/faisalman/ua-parser-js/issues/536
FBJS v3 has updated to avoid the issue:
https://github.com/facebook/fbjs/commit/5893dd1ee1c784891df4cd2519c586a9da46c8a8
But this library is still on v2 of FBJS, so it could still be vulnerable.
Please advise if you are able to upgrade to v3 of FBJS.

is there any news on FBJS upgrade?

any update on this?

FWIW, the vulnerable version of us-parser-js has been yanked from npm and the range specified by fbjs v2 did allow for updating past the bad version what it was active. While it's still a good idea for us to update, it's not necessary to avoid the exploit.


correcting single_client parameter value from True -> False in the ca…

Simply made the change suggested in issue:#1702

Thank you very much!

nae bother! it is my pleasure :D


Memory leak while using go helm client

I have a simple application that only installs a simple helm chart and deletes it in the loop. It contains only the helm client implementation. I noticed that memory usage on this application is increasing from ~20Mi on start to ~100Mi and then it stays at this level. I tested it deployed on the k8s cluster with secrets driver to store releases' history.
In the above client, I even set the maxHistory to 1 to be sure that history is not consuming memory, but it still grows. The memory usage chart looks as follows:

Using pprof it looks as follows:

5min later:

20min later:

It looks like reflect.New percentage of memory usage is growing but I cannot find a root cause.
Output of helm version:
version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-21T14:51:23Z", GoVersion:"go1.14.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.13-gke.1", GitCommit:"688c6543aa4b285355723f100302d80431e411cc", GitTreeState:"clean", BuildDate:"2020-07-21T02:37:26Z", GoVersion:"go1.13.9b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): GKE

This looks like it's happening within protobuf handling. Helm doesn't directly deal with this. Instead, it's likely from an import of a Kubernetes package used for interactions with Kubernetes. I suspect something is happening in there.