Scully build fails immediately in new project

🐞 Bug report
Description
I have built a fresh angular application and followed the scully docs on how to add scully and build a static site.
However when running npm run scully I get the following error
> scully

using plugins from folder "./scully"
Typescript error while compiling plugins. the error is:
error TS5042: Option 'project' cannot be mixed with source files on a command line.

💻Your Environment
Windows
💻Minimal reproduction steps
ng new my-app
cd ./my-app
ng add @scullyio/init
npm run build
npm run scully

Angular Version:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 10.1.3
Node: 12.18.3
OS: win32 x64

Angular: 10.1.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1001.3
@angular-devkit/build-angular   0.1001.3
@angular-devkit/core            10.1.3
@angular-devkit/schematics      10.1.3
@angular/language-service       10.1.4
@schematics/angular             10.1.3
@schematics/update              0.1001.3
rxjs                            6.6.3
typescript                      4.0.3

Scully Version:

    "@scullyio/init": "^1.0.1",
    "@scullyio/ng-lib": "^1.0.0",
    "@scullyio/scully": "^1.0.0",

🔥 Exception or Error

> scully

using plugins from folder "./scully"
Typescript error while compiling plugins. the error is:
error TS5042: Option 'project' cannot be mixed with source files on a command line.

@BoshJeckerleg I  just test in my computer (Windows 10) And work perfect with the same angular node & scully version... Can you give me more info?
Windows Version:
Terminal:

@jorgeucano Sure, appreciate it might be a hard one to solve as the error isn't too helpful. I've created a repo where I can replicate the error here https://github.com/BoshJeckerleg/scully-demo. It's just a boilerplate app.

I test and work for me your project

what terminal are you using?

@jorgeucano  Interesting. I am using the integrated terminal in vscode so I guess powershell?

We have a strange error with PowerShell sometimes due to a folder path issue, can you copy me the full path to be able to do a test?
Thank you!

@jorgeucano Cool, I was thinking that had something to do with it as when I cloned this to my desktop it works fine.
The folder path where it is broken is D:\Code\Git\Red Maple\scully-demo

@jorgeucano  So I've got it working now.
Removing the whitespace in the folder path meant that the minimal reproduction that I sent you started working again.
I then moved onto the actual repo where I am trying to add Scully and tried again, this is in the same directory. I got a more helpful error message that scully couldn't find the angular project of name ... in angular.json.
In the Scully config, it had set the project name to something other than the default application name in angular.json causing it to break. I aligned these two and it works.
Thanks for your help.

Thanks you for test all of this... We will work for this "path problem" with PowerShell

@jorgeucano No worries, thanks for Scully, it's really cool.

@BoshJeckerleg your problem is: D:\Code\Git\Red Maple\scully-demo Powershell gets confused if you use upper-case nd more so if you use spaces.
Switch to cmd. or remove all spaces and uppercase ut of your path. This is a windows/PowerShell thing.
I'm still finalizing some code that will detect this and give an appropriate warning.

@SanderElias  That is what we figured out, but I agree, some error messaging would be helpful for others in future as I was completely stumped by this for a few hours.

reopened to hook to fix

Please note @SanderElias and/or @jorgeucano that this issue apparently is not related to Powershell: I'm having the same behavior with zsh (ohmyzsh) and with bash in elementaryOS 5.1 (Ubuntu 18 based).
If the project path has an space, Scully won't run. Or at least in my case? :thinking:

@AlexFBP I'm on Ubuntu 20. Spaces in pathnames is an issue in many tools.
What you are seeing is a similar yet different issue.
Perhaps just don't use spaces in path-names ;)
I took a quick look, and it seems to be something around typescript that goes haywire.
When you think this is important enough, please open a new ticket.

Honestly this was the first time I had to move a whole project to another folder, just by having a space in the path...
However, yes, it doesn't matter so much after all. What I'm saying is that I don't think that it is directly related to Scully, but to one of its dependencies, as that error appears not only with Scully but in other places, projects where Typescript is used...
Needless to say I'm a newbie on Angular :sweat_smile: , I tried (not so much TBH) to seek a way to fix this (for me it has no sense that a whole project gets "killed" by just having space(s) in its path, like as I were using old development tools) but I "successfully failed" :sweat_smile:


Notification mailer links

The links in the approved and published notifications were broken.
We fix the approved email to link to the guide in the publisher. We fix the published email to link to the published guide on the frontend.

lgtm. Deploy tomorrow?

Yeah :sunglasses:  - having this links working would probably be really useful.


#2 inited CGroupV2 support

Codecov Report
Patch coverage: 41.93% and project coverage change: +3.18 :tada:

Comparison is base (ba88920) 44.23% compared to head (41b5d28) 47.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   44.23%   47.41%   +3.18%
==========================================
  Files           5        6       +1
  Lines         208      329     +121
==========================================
+ Hits           92      156      +64
- Misses        112      162      +50
- Partials        4       11       +7

Impacted Files
Coverage Δ

pkg/resbeat/readers/system/factory.go
0.00% <0.00%> (ø)

pkg/resbeat/readers/system/cgroupv2.go
21.77% <21.77%> (+21.77%)
:arrow_up:

pkg/resbeat/readers/system/cgroupv1.go
41.07% <40.00%> (-0.67%)
:arrow_down:

pkg/resbeat/readers/system/dummy.go
53.33% <75.00%> (+53.33%)
:arrow_up:

pkg/resbeat/readers/system/mounts.go
90.00% <90.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unable to send email with NativeMailerHandler in Laravel 8

Monolog version 2
Laravel 8.x
Php 7.4
Hi, I'm trying to use a laravel logging channel to send an email with the error, but I can't get anything to be sent, I'm trying with monolog and NativeMailerHandler but I still can't send anything, Laravel 8 and php 7.4:
config/logging.php
'monolog' => [
            'driver' => 'monolog',
            'handler' =>\Monolog\Handler\NativeMailerHandler::class,
            'level' => 'debug',
            'with' => [
                'to' =><EMAIL_ADDRESS>                'from' =><EMAIL_ADDRESS>                'subject' => 'test',
                'level' => 'debug'
            ],
],

Call from a controller
 Log::channel('monologmail')->debug('test');

In the .env i have the mails settings:
MAIL_MAILER=smtp
MAIL_HOST=smtp.gmail.com
MAIL_PORT=465
<EMAIL_ADDRESS>MAIL_PASSWORD=password
MAIL_ENCRYPTION=ssl
<EMAIL_ADDRESS>
It simply does not send any message, nor does it give any error or anything...

I suspect the MAIL_* config from .env apply to the symfony/mailer.
You can try with https://github.com/Seldaek/monolog/pull/1663 see if it helps, by passing it the mailer transport..

Yes the new SymfonyMailerHandler is the way to go IMO.


Responsive not working when width is 100% and height fixed

Hi! Like the title pretty much describes, my slider isn't responsive when i set my width to '100%' and the height to a fixed value.
When the width is also a fixed value it is responsive.
Is this a bug or am i doing something wrong/missing something?
Hopefully someone can help me out, thanks!

Hi. When using a percentage width you will need to manually set the aspect ratio which needs to be maintained when the slider is scaled down. This can be done by using the aspectRatio option. For example, you could set it to 1.5 or 2.
Cheers.

Thanks!  I just have to figure out how it works:p
Btw, is there a way to change the distance between the images? So far i couldn't find how the distance is made (no padding or no margins).

You can use the slideDistance option for that.

Hи guys,
I'm trying to use a percentage width and put parameters such as:
$( '#example5' ).sliderPro({
width: '100%',
thumbnailWidth: '33%',
orientation: 'vertical'
.....
The problem: slider become width 100%, but the sp-thumbnails-container disappears.
In this case  "thumbnailWidth" working only with "px" and not with 33%
Can you help me, please?
Maya

Hi, Maya. You can set the thumbnailWidth to a percentage value like '20%' (it's important to put the value inside quotes), but you'll also need some additional CSS to set the width of the thumbnails' container:
.sp-thumbnails {
    width: 100% !important;
}

Thanks David for the fast answer, I did exactly that, but I thought there's a better way


Streamlit: A visualization tool for Caustics

I have created a beta version of the Caustics visualization tool in the "gui" folder. It was a lot of fun! There are a few things to note:

For some reason, I have to rotate the imshow plots 90 deg to get them to face the right way (as far as I can tell from playing with the parameters). It is worth checking this just to make sure.

The current lens+source configuration's redshift parameters don't change anything in the visualization, which I believe is what we expect from the reduced deflection angles and scale-invariant power laws, but I could be mistaken.

The shear components are interesting: they don't seem to be exactly orthogonal. One seems to be a vertical component, while the other seems to be a diagonal component.

However, these issues pertain more to the core code of Caustics than the visualization tool, so I anticipate some of them may become issues of their own. They should not impede the adoption of this simulator tool, since this tool should make debugging lens models easier.
The only additional software required to use this tool is streamlit, which is a simple pip/conda install away. The tool can be run using the following command: streamlit run "path_to/caustics/gui/streamlit_app.py"
Moving forward, we can add more models to the menu on the left below the Caustics logo, as well as hosting + adding to the website.

This is really amazing! There are a few simple changes that could be helpful:

No need to include the redshift sliders, they dont do anything
No need to include the x0 and y0 for the shear (we may even remove those parameters from caustics entirely)
No need to include the sersic intensity
The model can be evaluated at lower resolution, should help it run faster
The caustic should appear in the source plane image, but in the lens plane you should show the critical curve
Caustics should be computed in the same fov as the image so they don't get cut off near the edges
Rotations can go from 0 to pi instead of 0 to 2pi since everything is symmetric
Adding the rest of the lens models (but you knew that)!

Great stuff!

Also,

if you could use the inferno cmap, I just think it looks cool :P
There is an updated script to compute contours, that will probably work better. Check out the new "Visualize Caustics" tutorial
What is the streamlit_app_basic for? Should it be removed?

I also removed the "basic" app, that was mostly for my experimentation (to keep something stable while I messed around with the main simulator).


Adds support for FreeBSD

FreeBSD was disabled due to lack of testing. This works around the
compilation problems. Note: We can't currently test arm64 automatically!
Notes:

GitHub Actions doesn’t support FreeBSD, and may never.
We could use Travis to run FreeBSD, but it would split our CI config.
Using Vagrant directly is easier to debug than vmactions/freebsd-vm.
GitHub Actions only supports virtualization on MacOS.
GitHub Actions removed vagrant from the image starting with macos-11.
Since VirtualBox doesn't work on arm64, freebsd/arm64 is untestable.

Fixes #607

heh let's see.. I accidentally missed the build flags to actually use it with compiler 🤞

I can't currently reproduce the failure locally with vagrant even if deleting the VM and doing it again.
$ vagrant destroy
$ go version
go version go1.18.3 darwin/amd64
$ GOVERSION=$(go env GOVERSION) GOARCH=$(go env GOARCH) vagrant up --provision
--snip--
$ vagrant ssh -c "cd wazero && make spectest.v1"
ok  	github.com/tetratelabs/wazero/internal/integration_test/spectest/v1	1.854s
Connection to <IP_ADDRESS> closed.

can't try anymore because vagrant rate limits (via HTTP 429)
will park this meanwile

cool passed!


Unable to Detect Text Recognition (OCR) in sample app MLKit

The sample app to detect recognition (OCR) is not working right now it is failing with error failed to run text detector because self is nil

I've got the exact same error. Console says instantiated GMVTextDetector: xxxx  then, prints failed to run text detector because self is nil..
Is there a workaround to this?
Kind regards Chris

https://stackoverflow.com/questions/50246800/firebase-mlkit-text-recognition-error is the solution indeed.


Invalid head parameters

I am trying to use https://dataservice.iifl.in/openapi/prod/LoginRequestMobileForVendor api
On both postman and the sample code I am getting following error:
{
    "body": null,
    "head": {
        "responseCode": "IIFLMarRQLoginForVendor",
        "status": "2",
        "statusDescription": "Invalid head parameters."
    }
}

I am sending all the valid values and keys provided to me from my trading account's profile section in both request payload and request headers.
Please provide a resolution for this issue.

Resolved by updating the encryption key in the source code.


[PURCHASE-641] enable no-console lint rule

Addresses: PURCHASE-641
This enables the no-console lint rule to prevent console.logs from getting checked into production code.

This PR as is ensure we have the lint rule enabled and prevents future console.logs from getting committed. It doesn't fix the several uses of console.log that are already in place.
I see a handful of instances where we are using console.log in a catch error block. Do you think it would be okay to switch those our for console.error or should we disable the rule for those lines since we are intentionally wanting to console.log something?

Do you think it would be okay to switch those our for console.error

Yup! those should be console.error, as console.error will give us a stack trace.

Ahh looks like someone already beat me to fixing that failing mocha spec!

I like your recommendations @zephraph! This PR has been sitting a while so I'd like to at least get the lint rule out and then iterate in a follow up PR with your suggestions. I created a ticket to track that.


Open multiple folders in one instance

VSCode Version: 1.8.1
OS Version: Sierra 10.12.2

I would like to open several projects in only one instance of VScode. That would be of a great help.

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.

Duplicate of #396, btw


Moving more tests over to the v2 API

Risk Level: Low (test only)
Release Notes: (n/a)

@htuch hope I mailed this out in time to save you the work over on #2201 :-)

@alyssawilk thanks! This is helpful re: #2201.


cann't compile with opencv4.7.0

 thread 'main' panicked at C:\Users\zyzhang60\.cargo\registry\src\index.crates.io-6f17d22bba15001f\opencv-binding-generator-0.45.0\src\element.rs:75:21:
  internal error: entered unreachable code: Can't get kind of parent for cpp namespace: Entity {
      kind: NotImplemented,
      display_name: Some(
          "C:\\opencv\\build\\install\\include\\opencv2\\xobjdetect.hpp",
      ),
      location: None,

Isn't opencv-binding-generator-0.45.0 corresponding to opencv bindings v45 (https://github.com/twistedfall/opencv-rust/releases/tag/v0.45.0) which does not support OpenCV 4.7?

Closing due the idle


Fail the compatibility test if the docker execution fails

This PR fixes the 'compatiblity test' so that it doesn't hang in an infinite loop if starting the container fails.
See e.g. this hung test.

!ci-build-me

!approved-for-mainnet


std_msgs: 0.5.10-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository std_msgs to 0.5.10-0:

upstream repository: git@github.com:ros/std_msgs.git
release repository: https://github.com/ros-gbp/std_msgs-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.21
previous version for package: 0.5.9-0

Waiting for coordinated release.


Change version to v0.1.4 or v0.2.0 :)

Just a reminder, update your version. I can do a PR but that would be like taking credit for something I didn't do so you should do it. :)

Thank you for waiting. I released new version v0.2.0. please try it.
I'm worried about speed of processing because my parser is rough. I'll appreciate it if you tell me what you felt using new version.

I will. Thank you!


Lazy Load, as supported by IE11.   "Lowers the loading priority of a resource." Example: &...

Lazy Load, as supported by IE11.
http://msdn.microsoft.com/en-us/library/ie/dn369270(v=vs.85).aspx
"Lowers the loading priority of a resource."
Example: <img src="myImage.jpg" lazyload="1">

This issue was imported from Google Moderator
Moderator votes: +17
Issue added by TJ Fogarty on 2014-02-20
To vote this issue up or down, simply include +1 or -1 in your comment.

+1

+1

+1

+1

+1

Now available at http://caniuse.com/#feat=lazyload


Prevent Double Loaded Library

While working through integration tests, we found that when LD_PRELOAD was set globally to point to the library in /usr/local/scope/lib and we used ldscope to start a program, it ended up having two copies of the library loaded; one from /usr/local/scope/lib and another from /tmp/libscope-0.7.1. Our logic to prevent the library from being loaded twice needs to be adjusted.
PS: the resulting double-scoped java process behaved very strangely as we would expect. A double-interposed function perhaps.
Jul 29, 2021 3:10:23 PM org.apache.tomcat.util.net.NioEndpoint$SocketProcessor run
SEVERE:
java.lang.UnsatisfiedLinkError: sun.nio.ch.SocketChannelImpl.__read(Ljava/nio/ByteBuffer;)I
	at sun.nio.ch.SocketChannelImpl.__read(Native Method)
	at sun.nio.ch.SocketChannelImpl.read(Native Method)
	at org.apache.tomcat.util.net.SecureNioChannel.handshakeUnwrap(SecureNioChannel.java:316)
	at org.apache.tomcat.util.net.SecureNioChannel.handshake(SecureNioChannel.java:189)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1574)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

/proc/43/maps shows the double load
/proc/43/maps:7f7edf727000-7f7edfd66000 r-xp 00000000 103:03 5647244                   /opt/appscope/lib/linux/x86_64/libscope.so
/proc/43/maps:7f7edfd66000-7f7edff66000 ---p 0063f000 103:03 5647244                   /opt/appscope/lib/linux/x86_64/libscope.so
/proc/43/maps:7f7edff66000-7f7edffc6000 r--p 0063f000 103:03 5647244                   /opt/appscope/lib/linux/x86_64/libscope.so
/proc/43/maps:7f7edffc6000-7f7edfff8000 rw-p 0069f000 103:03 5647244                   /opt/appscope/lib/linux/x86_64/libscope.so
/proc/43/maps:7f7ee6bc5000-7f7ee7204000 r-xp 00000000 00:48 17047582                   /tmp/libscope-0.7.1/libscope.so
/proc/43/maps:7f7ee7204000-7f7ee7404000 ---p 0063f000 00:48 17047582                   /tmp/libscope-0.7.1/libscope.so
/proc/43/maps:7f7ee7404000-7f7ee7464000 r--p 0063f000 00:48 17047582                   /tmp/libscope-0.7.1/libscope.so
/proc/43/maps:7f7ee7464000-7f7ee7496000 rw-p 0069f000 00:48 17047582                   /tmp/libscope-0.7.1/libscope.so

This is a duplicate of 417. Closed.


added code to calculate the loss function over a randomly sample set …

…of time series for multiple time series models

Added code to calculate the loss function over subsets of the data for multiple time series models. Not sure how helpful this will be yet.


fix: Not here page opens when opening distance receipt from another workspace

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/50107
PROPOSAL: https://github.com/Expensify/App/issues/50107#issuecomment-2389662939
Tests

Create two workspaces.
Submit a distance expense in the first workspace chat.
Submit the same distance expense in the second workspace chat.
Submit another expense to the second workspace chat (as we cannot review duplicates when there is only one expense).
Go to transaction thread of the second expense in Step 4.
Click Review duplicates.
Click on the second distance expense preview (to make Keep this one button appear).
8 . Click on the receipt on the confirmation page.
Verify that: The receipt opens without issue.

[x] Verify that no errors appear in the JS console

Offline tests

same as above
QA Steps

same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/5919b5f8-4d3d-4dfb-9cd4-7af0e19aead9

Android: mWeb Chrome

https://github.com/user-attachments/assets/13375630-4f92-46b4-88dc-024259c493f1

iOS: Native

https://github.com/user-attachments/assets/cf2e09b7-ab50-441b-89c2-f84c53aabb47

iOS: mWeb Safari

https://github.com/user-attachments/assets/42a42c1d-a57c-49fe-9fec-e5077a5eadba

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/333b9715-58a0-4812-b2c1-b146b6bbd254

MacOS: Desktop

https://github.com/user-attachments/assets/6ead3bc1-5da2-4541-b2eb-31d90311af22

@rojiphil Thanks for your review, i updated, please check again

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/6fd09b55-c0e8-4ea9-8ec6-e65472d970c2

MacOS: Desktop
https://github.com/user-attachments/assets/72200295-0a9c-4360-b371-116ab9fe924a

iOS: mWeb Safari
https://github.com/user-attachments/assets/f6a89da3-8284-477a-bffe-d9054f4ad2be

Android: Native
https://github.com/user-attachments/assets/b2d8cf99-359d-4dc0-ad5f-3690fc40068e

Android: mWeb Chrome
https://github.com/user-attachments/assets/f5ea2332-5543-4cbd-b28f-15a707382bb1

iOS: Native
https://github.com/user-attachments/assets/049d4bf4-c3ed-428d-8102-bbaf2eefac46

@rojiphil i updated, please check again

i updated, please check again

LGTM. Thanks. I have already approved.
@pecanoro All yours. Thanks

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Added activity scope. Changed dagger implementation. Added subcomponents

@reisub can you please check out this pull request. I have added submodules and now you can add the module you need to application scope. Since @ActivityScope annotation is added everything that is injected will only live while activity is live.

This looks good. Do we also need to change anything for the robolectric tests to work?

Good question. We'll need to add "plus" methods to AppTestComponent but that can be done with BaseAppComponent interface.  I think that is all we need. @ikust can you confirm this? I know you added something to this on another project.

@ikocijan can you just add the plus methods and use them like we usually do? With a method to inject dependencies in the base activity?

@reisub Done.

Great!


I get this error when edit node client-ltp,can anyone hlep me with this?

It's a leafref of '/core-model:network-element/core-model:ltp/core-model:uuid'  in core-model.yang;
when i trying to commit to running database after edit it's value, the following error arising:

merge target=/network-element/ltp[uuid='LTP-MWPS-TTP-RADIO']/client-ltp value="LTP-MWS-RADIO"
RPC OK Reply 21 for session 1:

xget-config /network-element/ltp[uuid='LTP-MWPS-TTP-RADIO']/client-ltp source=candidate
RPC Data Reply 22 for session 1:
rpc-reply {
data {
network-element {
ltp LTP-MWPS-TTP-RADIO {
uuid LTP-MWPS-TTP-RADIO
client-ltp LTP-MWS-RADIO
}
}
}
}

xget-config /network-element/ltp[uuid='LTP-MWPS-TTP-RADIO']/client-ltp source=running
RPC Data Reply 23 for session 1:
rpc-reply {
data {
}
}

commit
RPC Error Reply 24 for session 1:
rpc-reply {
rpc-error {
error-type application
error-tag unknown-namespace
error-severity error
error-app-tag data-invalid
error-path /core-model:network-element/core-model:ltp[core-model:uuid='LTP-MWPS-TTP-RADIO']/core-model:client-ltp
error-message 'unknown namespace'
error-info {
error-number 266
}
}
}

I change the path in core-model.yang,
from:

I remove the prefix in the leafref path, and rebuild the core-model. then everything works fine.
Did I missed some configuration of netconf, or the leafref path prefix is superfluous?
before:

leaf-list client-ltp {
type leafref {
path '/core-model:network-element/core-model:ltp/core-model:uuid';
}
description "References contained LTPs representing client traffic of this LTP for normal cases of multiplexing.";
}

after:

leaf-list client-ltp {
type leafref {
path '/network-element/ltp/uuid';
}
description "References contained LTPs representing client traffic of this LTP for normal cases of multiplexing.";
}

@pezou Hi, this is very interesting information!!! ... but my require input from additional people form other projects (ONF Eagle, OpenYuma, ....). Could you please describ a bit about your use case and which NetConf-Server frame work is involved?
regarding your finding: The prefix is generated by the ONF/Eagle/UmlYangTools based on the ONF-UML-YANG-Mapping document. At this moment I cant tell you whether your solution may cause issues elsewhere...

It's openyuma with default config.
I am just initializing the container network-element.

Hello,
I've tried also what @pezou described and I get the same "unknown namespace" error on my OpenYuma installation as well. I assume it is not necessarily an OpenYuma bug, but some expected behavior.
I've tried another workaround as well: changing the namespace of the core-model.yang from CoreModel to core-model, but I get the same error.
Defining the path in the leafref types with the same prefix of the YANG module that we are already in seems to be the problem, as @pezou described, and for sure is redundant.
I don't know all the implications of changing this. The first that came to my mind (and I've already tested it, without having any issues) was to try and add a new layer-protocol in the microwave-model. Since layer-protocol is defined like this:
leaf-list logical-termination-point {
            type leafref {
                path '/core-model:network-element/core-model:ltp/core-model:uuid';
            }
            description "none";
        }

I thought we might have problems if we are referring the values from the core-model that I've changed. But there are no problems, I was able to add a new layer-protocol without any issues. And also, I was able to edit the values of client-ltp or server-ltp without any issues. It behaves exactly as expected, you are not able to put a value there without it to exist previously. So the checking of that leafref to exist is done correctly.
I'm guessing that, as @pezou pointed out, we could just discard the prefixes from the paths of the leafref types. Since they refer only to paths in the same YANG module, they seem redundant.

I'm going to remove the redundant prefixes ...

@pezou Please see modified YANGs
Could you please check - if possible please close the issue.

@demx8as6  thanks, it behaves as expected

@demx8as6 Except removing redundant prefix in core-model, grouping name in microwave-model.yang have been changed as well. It causes the SIL code changed and that may cost lots of time to synchronism.
I wonder which version of YANG files will be uesed in the TST, and which in POC4. Will the model change again?

@pezou The target is to use the same yang modules in TST and 4th PoC. Only Prio1 issues will because changes in the Yang modules. Both changes (grouping-names, prefixes) were Prio1 issues, because the limit the end-to-end functionality.

@demx8as6 OK,I get it.


Thank you (also email address)

Thank you so much for making MJML. The amount of real world knowledge encoded into this project is amazing. You've saved me such a huge amount of time!
Also, just so you know, the email address on this github profile doesn't work — I'd have sent this as private email if that had worked.

Thanks for the kind words and support @aredridel. We'll look in the email address but ironically, we don't really use email as a communication channel for email. Slack or Github is preferred.

Makes sense! Anyway, thanks for the fantastic tool!


 key broken when using tmux (regression introduced by patch 9.0.0791)

Steps to reproduce
Starting with Vim-9.0.0791, the <Home> key no longer works as expected when running Vim in tmux.
Pressing <Home> capitallzes the character under the cursor and does not move the cursor instead of moving the cursor to the beginning of the line.
Steps to reproduce:

Start tmux
In tmux, run vim with:  vim --clean -c 'norm iaaa'
press the Home key
Observe the character a under the cursor gets capitalized and the cursor does not move (bug!)

The bug does not happen without tmux.
The patch that introduces the regression is:
commit a353282c13287058fde95bb6eb914e342fd4253c (tag: v9.0.0791)
Author: Trygve Aaberge<EMAIL_ADDRESS>Date:   Tue Oct 18 19:22:25 2022 +0100

    patch 9.0.0791: at the hit-Enter prompt the End and Home keys may not work

    Problem:    At the hit-Enter prompt the End and Home keys may not work.
    Solution:   Use the special "@" code for End and Home, like it was done for
                the cursor keys in patch 8.2.2246. (Trygve Aaberge, closes #11396)

CC: trygveaa
Expected behaviour
Expected behavior: pressing <Home> key in normal mode should go to the first character of the line and should not alter the character under the cursor.
Version of Vim
vim-9.0.0814
Environment
Operating system: xubuntu-18.04.6 (x86_64) or macOS-12.6 (M1)
tmux: latest from git, SHA1 https://github.com/tmux/tmux/commit/5ce34add77fa3517a01e63b915c5f4e3241af470
terminal: xfce4-terminal-<IP_ADDRESS> on xubuntu or alacritty-0.11.0 on macOS
I don't think the OS, version of tmux or terminal really matter.
Logs and stack traces
No response

Steps to reproduce
Starting with Vim-9.0.0791, the  key no longer works as expected when running Vim in tmux.
Pressing <Home> capitallzes the character under the cursor and does not move the cursor instead of moving the cursor to the beginning of the line.
Steps to reproduce:

Start tmux
In tmux, run vim with:  vim --clean -c 'norm iaaa'
press the Home key
Observe the character a under the cursor gets capitalized and the cursor does not move (bug!)

The bug does not happen without tmux.
The patch that introduces the regression is:
commit a353282c13287058fde95bb6eb914e342fd4253c (tag: v9.0.0791)
Author: Trygve Aaberge<EMAIL_ADDRESS>Date:   Tue Oct 18 19:22:25 2022 +0100

    patch 9.0.0791: at the hit-Enter prompt the End and Home keys may not work

    Problem:    At the hit-Enter prompt the End and Home keys may not work.
    Solution:   Use the special "@" code for End and Home, like it was done for
                the cursor keys in patch 8.2.2246. (Trygve Aaberge, closes #11396)

CC: trygveaa
Expected behaviour
Expected behavior: pressing  key in normal mode should go to the first
character of the line and should not alter the character under the cursor.

Can you use the channel log to see what the raw key code is that causes a
problem?  I suppose it doesn't change with the patch, but the way it is
interpreted.  Perhaps Trygve can figure out why this happens with tmux only.
--
Lower life forms have more fun!
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

The happens not only happens with the tmux terminal multiplexer but also with the screen terminal multiplexer.
Pressing Home seems to behave as if ~ was pressed which changes case.
I'm not sure whether it's a bug with vim or with tmux & screen.
Somehow the End key works but the Home key does not after patch 9.0.0791.
For now, I've reverted patch 9.0.0791 locally because it was driving nuts to have the case change when pressing the Home key.

@brammool asked:

Can you use the channel log to see what the raw key code is that causes a
problem?

Maybe I misunderstand, but this bug is not related to the channel feature,
since the bug happens even if I built vim tiny i.e. without the channel feature.
If I do :call ch_log('ch_log.txt')  I don't see such a ch_log.txt
being created since channel is not involved reproducing the bug.
Anyway, the following one-line change, found by trial and error, reverts
one line of patch 9.0.0791 and fixes the bug somehow, but I admit
I don't understand it:
diff --git a/src/term.c b/src/term.c
index 77ad08bf1..ea08b839c 100644
--- a/src/term.c
+++ b/src/term.c
@@ -877,7 +877,7 @@ static struct builtin_term builtin_termcaps[] =
     {K_KHOME,          "\033[1;*~"},
     {K_XHOME,          "\033O*H"},     // other Home
     {K_ZHOME,          "\033[7;*~"},   // other Home
-    {K_END,            "\033[@;*F"},   // Esc [ F or Esc 1 ; F
+    {K_END,            "\033[1;*F"},
     // {K_S_END,               "\033O2F"},
     // {K_C_END,               "\033O5F"},
     {K_KEND,           "\033[4;*~"},

What is strange, is that I revert the line related to K_END
and it fixes the Home key. I don't understand, but it appears
to work.  Hopefully @trygveaa can figure it out.

@dpelle: I can't reproduce with the same tmux version without any tmux config (or with my normal tmux config), in xfce4-terminal 1.0.4 if it matters. Do you have any tmux config? Have you tried without it?
Can you check what vim receives for the Home and End keys? In insert mode in vim in tmux, press Ctrl-v (or Ctrl-q) and then Home and see what appears. Do the same for End.

@trygveaa wrote:

I can't reproduce with the same tmux version without any tmux config (or with my normal tmux config), in xfce4-terminal 1.0.4 if it matters. Do you have any tmux config? Have you tried without it?

I can reproduce the bug even without a ~/.tmux.conf, so it's not the cause of the bug.
For me, I can reproduce it on all systems I tried.

on Linux xubuntu-18.04.6. I tried xterm 330, xfce4-terminal-<IP_ADDRESS>, mate-terminal-1.20.0
on macOS 12.6. I tried with alacritty-0.11.0 and iTerm2-3.4.15.
I can also reproduce it with either the tmux or screen terminal multiplexer.

I used a USB keyboard (Keychron C1 mechanical keyboard) on both Linux and macOS.
On the macbook, I also tried with the keyboard of the laptop, by pressing Fn + Left Arrow
for the Home key (since the macbook does not have a Home key) and that reproduces the
bug as well.
I can reproduce with no .tmux.conf, no .vimrc.
It would be interesting to see whether anybody else can reproduce this issue.
I remind the steps to reproduce:

Start tmux (or screen) terminal multiplexer. The bug does not happen without either tmux or screen.
In tmux (or screen), run vim with: vim --clean -c 'norm iaaa'
press the Home key (on macbook without Home key, you can press Fn + Left Arrow instead)
Observe the character a under the cursor gets capitalized and the cursor does not move (bug!).
Pressing Home again, A becomes a.  So it's as if ~ was pressed instead of Home.
The bug happens in both normal and insert mode.

Changing this line which was modified by patch 9.0.791 fixes it (but my patch may not be correct):
diff --git a/src/term.c b/src/term.c
index 77ad08bf1..ea08b839c 100644
--- a/src/term.c
+++ b/src/term.c
@@ -877,7 +877,7 @@ static struct builtin_term builtin_termcaps[] =
     {K_KHOME,          "\033[1;*~"},
     {K_XHOME,          "\033O*H"},     // other Home
     {K_ZHOME,          "\033[7;*~"},   // other Home
-    {K_END,            "\033[@;*F"},   // Esc [ F or Esc 1 ; F
+    {K_END,            "\033[1;*F"},
     // {K_S_END,               "\033O2F"},
     // {K_C_END,               "\033O5F"},
     {K_KEND,           "\033[4;*~"},

on macOS (M1), I have:
$ screen --version
Screen version 4.00.03 (FAU) 23-Oct-06

$ tmux -V
tmux next-3.4

On xubuntu-18.04.6 (x86_64), I have:
$ screen --version
Screen version 4.06.02 (GNU) 23-Oct-17

$ tmux -V
tmux next-3.4

In all cases, I use the latest Vim 9.0.0820.
Bug happens with Vim huge as well as Vim tiny.

@dpelle: Please provide what vim received for Home and End as asked:

Can you check what vim receives for the Home and End keys? In insert mode in vim in tmux, press Ctrl-v (or Ctrl-q) and then Home and see what appears. Do the same for End.

@trygveaa wrote:

Can you check what vim receives for the Home and End keys?
In insert mode in vim in tmux, press Ctrl-v (or Ctrl-q) and
then Home and see what appears. Do the same for End.

Sorry I missed that earlier.  I enter tmux (or screen), start vim with
vim --clean then I press i to enter insert mode and press
ctrl-v Home and I see:
^[[1~

(the first 2 characters ^[ being the 0x1b character according to
the :ascii command.
Whereas the same steps without running with tmux or screen,
I get:
^[OH

I see the same escape key sequence whether I have my 1-line patch
or not (the patch I gave in previous message).

I just found a workaround for tmux by adding those lines
to my ~/.tmux.conf:
# Found at https://stackoverflow.com/questions/18600188/home-end-keys-do-not-work-in-tmux
# This fixes Vim bug https://github.com/vim/vim/issues/11429
bind-key -n Home send Escape "OH"
bind-key -n End send Escape "OF"

I'm not sure if there are side effects, but
so far it seems to be working fine.
But still, it's strange that since patch 9.0.0791,
those 2 lines are needed and were not needed earlier.
That does not fix the Home key when running Vim with
screen, but I normally don't use screen anyway (I use
tmux instead).

Hm, that's the same as I get. That the patch introduces this bug doesn't make any sense to me. I'll have to look into vim's key handling more in detail. However, I'm very busy the coming week, so it might take a while.

@dpelle: What is TERM set to inside tmux for you? Run :!echo $TERM in vim.

Sorry I missed that earlier. I enter tmux (or screen), start vim with vim --clean then I press i to enter insert mode and press ctrl-v Home and I see:
^[[1~

I can't reproduce with the latest vim (820) and tmux.

@trygveaa asked:

What is TERM set to inside tmux for you? Run :!echo $TERM in vim.

xterm-256color
Bug also happens when TERM is set to xterm  (prior to starting tmux) but then I don't have 256 colors, neither in tmux, nor in Vim, which does not looks nice.
I also tried with TERM being set to screen or screen-256color, Home then works, but Vim does not show colors (it's black and white) which is ugly.
I also tried with TERM being tmux (which behaves like screen).
With tmux-256color, I cannot even start tmux on macOS which says:
$ echo $TERM
tmux-256color

$ tmux
can't find terminfo database

... whereas on Linux, with tmux-256color I can start tmux, Home works in Vim, but vim does not show color (ugly).
All this was tried:

with an empty .tmux.conf
setting TERM in my ~/.bashrc before starting a new terminal and tmux

Shouldn't Vim support TERM being set to screen, screen-256color, tmux or tmux-256color?
What is the value of TERM for you and what is your OS?
The only setup that works well for me is TERM being set to xterm-256color
and with the workaround in .tmux.conf:
# Found at https://stackoverflow.com/questions/18600188/home-end-keys-do-not-work-in-tmux
# This fixes Vim bug https://github.com/vim/vim/issues/11429
bind-key -n Home send Escape "OH"
bind-key -n End send Escape "OF"

I just found https://github.com/vim/vim/issues/3630 which suggest to install
Ubuntu package ncurses-term but it's already installed.
Maybe xubuntu-18.04.6 is too old. I can later today try on xubuntu-20.04 later.
But macOS-12.6 is not old at least.

With tmux-256color, I cannot even start tmux on macOS which says:
$ echo $TERM
tmux-256color

$ tmux
can't find terminfo database

Have you tried to set it from within .tmux.conf:
set -g default-terminal "tmux-256color"

I don't have mac to test it and my linux distro is quite recent (fedora 36)
https://asciinema.org/a/W28c1N508W4R4rwN6mHt84JtI
Maybe tmux is old and/or terminfo is outdated

xterm-256color
Bug also happens when TERM is set to xterm (prior to starting tmux) but then I don't have 256 colors, neither in tmux, nor in Vim, which does not looks nice.

Using any value other than tmux, screen or derivatives of those in tmux is not supported and will break things like this (not just home/end keys in vim). From the man page of tmux:

The TERM environment variable must be set to ‘screen’ or ‘tmux’ for all programs running inside tmux.  New windows will automatically have ‘TERM=screen’ added to their environment, but care must be taken not to reset this in shell start-up files or by the -e option.
default-terminal terminal
Set the default terminal for new windows created in this session - the default value of the TERM environment variable. For tmux to work correctly, this must be set to ‘screen’, ‘tmux’ or a derivative of them.

I also tried with TERM being set to screen or screen-256color, Home then works, but Vim does not show colors (it's black and white) which is ugly.
I also tried with TERM being tmux (which behaves like screen).

If you don't get colors you have most likely enabled termguicolors in vim. This only works out of the box in xterm unfortunately.  See :help xterm-true-color and :help tmux-integration.
Note that screen does not support termguicolors, so you'll not get colors at all in screen with this option enabled. But in tmux it should work after setting t_8f and t_8b as mentioned in those help pages.

With tmux-256color, I cannot even start tmux on macOS which says:
$ echo $TERM
tmux-256color

$ tmux
can't find terminfo database

You should try without setting TERM at all, and see what happens on macOS. But if it can't find terminfo for tmux-256color, that sounds like a broken tmux installation. tmux-256color usually comes from ncurses, which tmux depends on.

setting TERM in my ~/.bashrc before starting a new terminal and tmux

You should never set TERM in ~/.bashrc or similar files, that will cause problems like this.

Shouldn't Vim support TERM being set to screen, screen-256color, tmux or tmux-256color?

It does, but there are unfortunately some things vim only enables by default for xterm terms, like RGB colors mentioned above.

What is the value of TERM for you and what is your OS?

I don't set TERM anywhere, so I have the defaults which is tmux-256color inside tmux, and screen inside screen. My OS is Arch Linux.

I'm closing the issue since it happens because I used xterm-256color and with tmux it should be tmux-256color.
My understanding is that my Linux box is too old to have a proper tmux-256color and macOS does not come with tmux-256color in termcap.  For macOS, I found https://gpanders.com/blog/the-definitive-guide-to-using-tmux-256color-on-macos/ but this looks ugly.
Anyway, my 2-line workaround in ~/.tmux.conf works fine so I'm happy enough.
And when I upgrade Linux, I hopefully don't need that workaround.

@brammool asked:

Can you use the channel log to see what the raw key code is that causes a
problem?

Maybe I misunderstand, but this bug is not related to the channel feature,
since the bug happens even if I built vim tiny i.e. without the channel feature.

The channel log shows the raw key codes.  It's only available with the
+channel feature, but useful also for figuring things out unrelated to
channels and jobs.

If I do :call ch_log('ch_log.txt')  I don't see such a ch_log.txt
being created since channel is not involved reproducing the bug.

The log is started with call ch_logfile('logfile, 'w').

Anyway, the following one-line change, found by trial and error, reverts
one line of patch 9.0.0791 and fixes the bug somehow, but I admit
I don't understand it:

I guess you don't have 'term' set to 'tmux', which will cause problems
like this.  If you care about colors, just set t_Co to 256 and it should
work.  You can also set 'ttymouse' to "sgr" for recent tmux versions.
I have this in my .vimrc:
" When running inside tmux.
if &term == "screen" || &term == "tmux"
  set term=tmux
  set <t_kb>=
  fixdel
  set t_Co=256
  set ttymouse=sgr
endif

diff --git a/src/term.c b/src/term.c
index 77ad08bf1..ea08b839c 100644
--- a/src/term.c
+++ b/src/term.c
@@ -877,7 +877,7 @@ static struct builtin_term builtin_termcaps[] =
     {K_KHOME,          "\033[1;*~"},
     {K_XHOME,          "\033O*H"},     // other Home
     {K_ZHOME,          "\033[7;*~"},   // other Home
-    {K_END,            "\033[@;*F"},   // Esc [ F or Esc 1 ; F
+    {K_END,            "\033[1;*F"},
     // {K_S_END,               "\033O2F"},
     // {K_C_END,               "\033O5F"},
     {K_KEND,           "\033[4;*~"},

What is strange, is that I revert the line related to K_END
and it fixes the Home key. I don't understand, but it appears
to work.  Hopefully @trygveaa can figure it out.

The "@" is supposed to catch "1" only if a modifier follows, perhaps it
also catches the "1" in the home key?  Above the arrow_modifiers help
there is a short explanation.  It does smell like a bug.
I'll make a patch to check for a following semicolon.  That appears to avoid
the problem.  Please check.  If it works, can you add a test case in
test_termcodes.vim for this?
--
hundred-and-one symptoms of being an internet addict:
2. You kiss your girlfriend's home page.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Fix incorrect restore location after Aero Snap

Fixes an odd side effect in calling GetWindowPlacement from WindowChromeWorker._HandleGetMinMaxInfo that caused the window to restore to the end of the drag instead of the beginning after doing an Aero Snap.
Steps to repro the bug that this PR fixes:

In the MahApps demo app, drag window to top of screen, which maximises the window.
Click Restore.
Window is restored to a location slightly off the top of the screen (which is, incorrectly, the location of the end of the previous drag).

Calling IsZoomed instead of GetWindowPlacement fixes this issue.

@tgjones thx, this works really better.

Thanks for merging :)
(I'm really curious what the history is behind the naming of that API - why is it IsZoomed, not IsMaximized...)


Allow run_shell_setup during Docker build

In reference to this issue
https://github.com/denoland/deno_install/issues/311
The idea is to use an ARG in the Dockerfile as a flag to indicate that we are in a build so that the install.sh will still execute run_shell_setup, and since we are in a Docker build pass the option to run_shell_setup so that the prompts are just answered with their defaults.
an example Dockerfile then would look something like
FROM debian:stable-slim

# Define a build argument to indicate the Docker build context
ARG DOCKER_BUILD=true

RUN apt-get update && \
  apt-get install -y \
  bash \
  curl \
  unzip

ENV SHELL="/bin/bash"

#RUN curl -fsSL https://deno.land/install.sh | sh
RUN curl -fsSL https://raw.githubusercontent.com/jabez007/deno_install/refs/heads/fix-docker/install.sh | sh

CMD ["/bin/bash"]

Hello, thanks for the PR!
I think instead of using an ARG and special casing docker builds, we should check if the user passed in -y or --yes, and if so run the shell setup regardless of whether it's an interactive terminal.
The steps for that would be roughly:

Update the arg parsing here to check for -y/--yes, and if it's present set some var (should_run_shell_setup or something)
Update the condition to be if { [ -z "$CI" ] && [ -t 1 ]; } || $should_run_shell_setup;

That way you could install deno in a dockerfile by just passing -y, so it would be consistent across environments instead of being dockerfile specific


Allow setting fs in WASI config

I noticed the use case where fs is passed in config is unhandled, and I assume it was because wasm-bound MemFS does not implement JsCast, making it hard to pass it to JS and then get it back in the WASI ctor.
I have adopted some common wisdom that I've found on github to get the wrapped instance from a JS object and pass it along. Are you interested?

Hey, thanks for the PR @corwin-of-amber . Could you also add tests to verify that the API works as expected? Thanks!

Did it :)

I think this fix has a bug: it seems that Rust takes ownership of the passed object making it invalid to use it from JS. This should probably not be the correct behavior. I am testing a modified version now.

I don't really know how to test for the buggy case, because the test passed even before the fix. Thing is, even if a dangling pointer exists the accesses will still succeed immediately after the call, because the memory has not been reclaimed/overwritten yet. This is what made it hard to see the problem in the first place.

wdyk I found the exact same function in Wasmer API:
https://github.com/wasmerio/wasmer/blob/f1a792e5fc7cd376fe11fafdbe8180e5b76add1e/lib/api/src/js/trap.rs#L254
probably from the same source.

Were you able to move forward with this @corwin-of-amber ?

I do not have a systematic approach to testing but I have used this branch for quite some time and tried different programs including ocamlrun and busybox, so I am pretty confident that it does not crash.

wdyk I found the exact same function in Wasmer API: https://github.com/wasmerio/wasmer/blob/f1a792e5fc7cd376fe11fafdbe8180e5b76add1e/lib/api/src/js/trap.rs#L254
probably from the same source.

If you are wondering about this, yes I assume wasmer-js can use the function from js/trap, but I do feel that my version provides better error reporting so perhaps you should merge them?


Refactored workflow for phabutil map

Creating a link on the host machine was a weak spot. Maris came out with
a different idea, so we could avoid that. phutil_map is moved to a
subdirectory and entire subdirectory is used as a volume in container.
Then the phabutil_map file on the container is linked to
/app/phabricator/src/__phutil_library_map__.php. It is safer and makes
the tasks.py cleaner.

I would like to get this merged first and base this change on top of that. There was quite a bit of effort required to getting circle+docker-compose to work together properly.

We've decided to redo this PR after @ckolos's PR will land


Customize Menu CSS in Refinery::Core configuration

Little patch to add the following to to Refinery::Core
config.menu_css = { :selected => "selected", :first => "forst", :last => "list" }
Sometimes css frameworks expect a different css selector for the menu. (eg. Twitter Bootstrap uses .active instead of .selected) This allows it to be easily configurable so that menu_helper.rb doesn't have to be overridden.

I don't understand why exactly this is required - is supplying the options to the partial undesirable?

The menu helper didn't check local_assigns for options. That could have been another way to go, but I thought since config.menu_hide_children already existed, similarly config.menu_css could be used to globally set your css selector preference for  menu elements.


Nightly GitHub Action failure

Our nightly GitHub Action for the container image fails since yesterday with:
#34 22.69 Applying patch patches/0001-Allow-overriding-default-user-and-file-locations.patch
#34 22.70 Applying patch patches/0002-Apply-placeholders-for-portability-shim.patch
#34 22.70 2 out of 5 hunks FAILED -- saving rejects to file rpki-client.8.rej

Fixed in 861c8fd04d3da1bda3a8c24ee55f3571731cd1f6


question: text instructions for install

Are there text instructions for installing this? not a video?
Can those instructions be linked to in the readme, and the documentation?

@unusualevent  I'm still trying to figure out how to install it. Where is the video?

NM. Figured out how to install it...
Dockerfile:
FROM caddy:2-builder AS builder

RUN xcaddy build \
    --with github.com/caddy-dns/cloudflare \
    --with github.com/greenpau/caddy-security
    #--with github.com/caddyserver/nginx-adapter \
    #--with<EMAIL_ADDRESS>
FROM caddy:2

COPY --from=builder /usr/bin/caddy /usr/bin/caddy

@greenpau did you add this to the docs?

did you add this to the docs?

@unusualevent , did not get to it. PRs are welcome in https://github.com/authp/authp.github.io/tree/main/docs


masked input erroring on init

When rendering the maskedInput component, an error message is displayed e.map is not a function, this can be seen/reproduced at
https://sumup.github.io/circuit-ui/?selectedKind=MaskedInput&selectedStory=Default MaskedInput&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

Hi @nicholas-b-carter, Thanks for reporting the issue. We'll look into it. Personally, I've seen this issue happen a lot during development, whenever the mask prop is missing on the MaskedInput component. While this prop is not directly used by MaskedInput, it is being forwarded directly to the underlying TextMaskInput from react-text-mask. That's where the error happens.
In this particular case, I can see the story does not set the mask property. I'm relatively confident this is the cause of the error you're seeing. We'll make a change to the story to document the usage of this component better.


Rubocop v0.48.1

This PR adds a TODO of Rubocop failures, a configuration file which points to the lowest version of Ruby that the project supports, and an exclusion of the spec files from the style rules.

Thx for keeping this project high quality @olleolleolle 🍻

@olleolleolle I've granted you commit bit, feel free to push tweaks like that directly to master (or open PR if you prefer to discuss of course) ;)


V6 RC2 - change prop is not bound to dispatch

The documentation states that the action creators are bound to the Redux dispatch but it doesn't seem to be the case with change function.
This does not work
this.props.change("fieldName", "new value");

But this works
this.props.dispatch(this.props.change("fieldName", "new value"));

I've updated to RC2 this morning and it seems this problem still exists.

In 6.0.0-alpha.6 even this.props.dispatch(this.props.change("fieldName", "new value")); doesn't work.
This is because change is incorrectly returning
{
   type: "redux-form/CHANGE",
   value: "fieldName",
   touch: false,
   form: "formName"
}

Instead of:
{
   type: "redux-form/CHANGE",
   field: "fieldName",
   value: "new_value",
   touch: false,
   form: "formName"
}

It's missing the field attribute and mis-assigning the value attribute.

Ok guys ! After spending to much time on my problem, I finally end-up with the same conclusion with v6.0.1:

The change is not bound to dispatch as written in the doc but instead returns the action.
However, the action has been fixed regarding the mis-assigning mentionned by @wesleycyu !

Would be nice if "change" was indeed a bound action creator as the documentation says.

Yep, focus appears to be missing in the actionsCreators passed to the form props.

It seems like this was fixed around v6.0.4.
Tested in the examples and it worked.


takes sourceDirs into account when resolving the method name, for the FilenameAndFunction log setting

note - this will only work for 1 source dir we should iterate over more but; 1. I don't have time right now and 2; not sure about performance ramifications of that. I'll raise an issue to capture this though.

@georgejecook There's a bunch of brighterscript changes in this PR. Those need to be taken out before I can approve this.

ha! yes. I thought I'd deleted this pr - sorry for wasting your time @TwitchBronBron I've not yet got a reasonable solution to this problem.


When uploadvideo type is ogv, importExternalTexture report error

In VideoUploading example, if I change video to an ogv video, it will throw an error. If the type is webm or mp4, it will work fine.

The following Chromium source code shows that GetCurrentFrameThenUpdate() returns null. I'm not sure why though that's the case for an ogv file...
ExternalTextureSource GetExternalTextureSourceFromVideoElement(
    HTMLVideoElement* video,
    ExceptionState& exception_state) {
  ...

  if (auto* wmp = video->GetWebMediaPlayer()) {
    source.media_video_frame = wmp->GetCurrentFrameThenUpdate();
    source.video_renderer = wmp->GetPaintCanvasVideoRenderer();
  }

  if (!source.media_video_frame) {
    exception_state.ThrowDOMException(DOMExceptionCode::kOperationError,
                                      "Failed to import texture from video "
                                      "element that doesn't have back "
                                      "resource.");

@Djuffin and @dalecurtis may be able to help us understand what is causing this issue.

Chrome bugs should probably be discussed on the chrome issue site?
https://crbug.com/

Only VP8 in ogg is now supported: https://chromestatus.com/feature/5158654475239424


[Refactor] rename work group to resource group

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio rebase

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 166 / 251 (66.14%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
7
00.00%
[216, 217, 964, 965, 966, 967, 1031]

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
1
00.00%
[509]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
1
5
20.00%
[281, 1612, 1613, 1614]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
5
17
29.41%
[505, 509, 510, 511, 512, 516, 518, 522, 523, 524, 527, 2724]

:large_blue_circle:
com/starrocks/qe/QueryDetail.java
1
3
33.33%
[224, 228]

:large_blue_circle:
com/starrocks/persist/EditLog.java
1
3
33.33%
[695, 696]

:large_blue_circle:
com/starrocks/master/ReportHandler.java
2
5
40.00%
[204, 207, 453]

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
2
50.00%
[918]

:large_blue_circle:
com/starrocks/persist/ResourceGroupOpEntry.java
3
6
50.00%
[31, 35, 39]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
2
4
50.00%
[1133, 1383]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
1
2
50.00%
[229]

:large_blue_circle:
com/starrocks/sql/ast/ShowResourceGroupStmt.java
2
3
66.67%
[32]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupMgr.java
67
101
66.34%
[180, 182, 191, 192, 193, 194, 202, 204, 215, 216, 217, 223, 224, 282, 340, 344, 347, 350, 351, 354, 369, 370, 371, 379, 380, 381, 382, 385, 386, 391, 392, 393, 396, 413]

:large_blue_circle:
com/starrocks/catalog/ResourceGroup.java
7
10
70.00%
[77, 250, 251]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupClassifier.java
3
4
75.00%
[49]

:large_blue_circle:
com/starrocks/sql/analyzer/ResourceGroupAnalyzer.java
26
32
81.25%
[29, 53, 60, 71, 87, 103]

:large_blue_circle:
com/starrocks/sql/ast/AlterResourceGroupStmt.java
8
9
88.89%
[60]

:large_blue_circle:
com/starrocks/sql/ast/CreateResourceGroupStmt.java
12
13
92.31%
[69]

:large_blue_circle:
com/starrocks/analysis/SetVar.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
8
8
100.00%
[]

:large_blue_circle:
com/starrocks/metric/ResourceGroupMetricMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/DropResourceGroupStmt.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DropResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/CreateResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/AlterResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DataDefinitionExecutorFactory.java
3
3
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 169 / 253 (66.80%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
7
00.00%
[216, 217, 964, 965, 966, 967, 1031]

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
1
00.00%
[510]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
1
5
20.00%
[283, 1619, 1620, 1621]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
5
17
29.41%
[502, 506, 507, 508, 509, 513, 515, 519, 520, 521, 524, 2720]

:large_blue_circle:
com/starrocks/qe/QueryDetail.java
1
3
33.33%
[224, 228]

:large_blue_circle:
com/starrocks/persist/EditLog.java
1
3
33.33%
[696, 697]

:large_blue_circle:
com/starrocks/master/ReportHandler.java
2
5
40.00%
[204, 207, 453]

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
2
50.00%
[918]

:large_blue_circle:
com/starrocks/persist/ResourceGroupOpEntry.java
3
6
50.00%
[31, 35, 39]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
2
4
50.00%
[1143, 1401]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
1
2
50.00%
[229]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupMgr.java
67
102
65.69%
[180, 182, 191, 192, 193, 194, 202, 204, 215, 216, 217, 223, 224, 282, 340, 344, 347, 350, 351, 354, 369, 370, 371, 379, 380, 381, 382, 385, 386, 391, 392, 393, 394, 397, 414]

:large_blue_circle:
com/starrocks/sql/ast/ShowResourceGroupStmt.java
2
3
66.67%
[32]

:large_blue_circle:
com/starrocks/catalog/ResourceGroup.java
7
10
70.00%
[77, 250, 251]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupClassifier.java
3
4
75.00%
[49]

:large_blue_circle:
com/starrocks/sql/analyzer/ResourceGroupAnalyzer.java
26
30
86.67%
[28, 52, 59, 70]

:large_blue_circle:
com/starrocks/sql/ast/AlterResourceGroupStmt.java
8
9
88.89%
[60]

:large_blue_circle:
com/starrocks/sql/ast/CreateResourceGroupStmt.java
12
13
92.31%
[69]

:large_blue_circle:
com/starrocks/analysis/SetVar.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
8
8
100.00%
[]

:large_blue_circle:
com/starrocks/metric/ResourceGroupMetricMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/DropResourceGroupStmt.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DropResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Column.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/execution/CreateResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/AlterResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DataDefinitionExecutorFactory.java
3
3
100.00%
[]

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 166 / 250 (66.40%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
7
00.00%
[216, 217, 964, 965, 966, 967, 1031]

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
1
00.00%
[510]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
1
5
20.00%
[283, 1619, 1620, 1621]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
5
17
29.41%
[503, 507, 508, 509, 510, 514, 516, 520, 521, 522, 525, 2721]

:large_blue_circle:
com/starrocks/qe/QueryDetail.java
1
3
33.33%
[224, 228]

:large_blue_circle:
com/starrocks/persist/EditLog.java
1
3
33.33%
[696, 697]

:large_blue_circle:
com/starrocks/master/ReportHandler.java
2
5
40.00%
[204, 207, 453]

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
1
2
50.00%
[918]

:large_blue_circle:
com/starrocks/persist/ResourceGroupOpEntry.java
3
6
50.00%
[31, 35, 39]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
2
4
50.00%
[1141, 1399]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
1
2
50.00%
[229]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupMgr.java
67
102
65.69%
[180, 182, 191, 192, 193, 194, 202, 204, 215, 216, 217, 223, 224, 282, 340, 344, 347, 350, 351, 354, 369, 370, 371, 379, 380, 381, 382, 385, 386, 391, 392, 393, 394, 397, 414]

:large_blue_circle:
com/starrocks/sql/ast/ShowResourceGroupStmt.java
2
3
66.67%
[32]

:large_blue_circle:
com/starrocks/catalog/ResourceGroup.java
7
10
70.00%
[77, 250, 251]

:large_blue_circle:
com/starrocks/catalog/ResourceGroupClassifier.java
3
4
75.00%
[49]

:large_blue_circle:
com/starrocks/sql/analyzer/ResourceGroupAnalyzer.java
26
30
86.67%
[28, 52, 59, 70]

:large_blue_circle:
com/starrocks/sql/ast/AlterResourceGroupStmt.java
8
9
88.89%
[60]

:large_blue_circle:
com/starrocks/sql/ast/CreateResourceGroupStmt.java
12
13
92.31%
[69]

:large_blue_circle:
com/starrocks/analysis/SetVar.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
8
8
100.00%
[]

:large_blue_circle:
com/starrocks/metric/ResourceGroupMetricMgr.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/DropResourceGroupStmt.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DropResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/CreateResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/AlterResourceGroupExecutor.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/execution/DataDefinitionExecutorFactory.java
3
3
100.00%
[]


[PE-D][Tester D] Example commands in quick start are wrong

Labels: severity.Medium type.DocumentationBug
original: tanveersingh10/ped#9

Not medium


Exclude files from being zipped

Hey,
I wanted to know if it's possible to exclude files from being zipped.
For example:
ZipFile#addFolder adds all files and it's subdirectories to the zip file.
But there are a few files which I just don't want being added. I tried getting all files manually and then using ZipFile#addFiles but now all files end up being in the root directory of the zip file. Is there a way to keep the folder structure in the zip file?

Hi all, I have this problem too, I tried to find workaround and I prepared all files which I want to zip as ArrayList and executed ZipFile#addFiles, but my structure of directories was broken inside the zip file. I believe we can save structure and we can exclude some files or directories too.

I'll try to add it to the src and create a pull request later

PR merged. Issue to add tests created #189 . I will add tests before I release this feature.

I have added tests. And also, I made some changes to the PR which was merged:

Renamed ExcludeFileHandler to ExcludeFileFilter
Moved ExcludeFileFilter from ZipParameters to method argument in ZipFile.addFolder(), as this feature is only available when adding a folder to the zip file

Actually, after some more thoughts, I moved the filter back to ZipParameters, because as part of an upcoming feature in #84, it will be possible to add folders also with ZipFile.addFiles() method. In this case, it will be useful to have this filter in ZipParameters.

Feature added in v2.6.0 released today


Want to make a issue template

Assign me under Aperture'24

The making of the issue template is the work of the project administrator. I'm working on it and will be done by tomorrow.
If you want to contribute to anything, create a new issue and submit with the proper screenshot.


Update and fix issues in VMAF implementation

Fix the format set for 10-bit 4:2:0
Update the default $VMAFOSSEXEC path
Update the VMAF command line
Fix VMAF extraction expecting garbage preceding the score
Parameterize the VMAF model name

This was tested on a fresh deploy of AWCY, so I think it's safe to merge.


"unit_of_measurement" incorrect (compared to unit system)

For some sensors the "unit_of_measurements" are missing which leads to Lovelace Graphing challenges when trying to combine with other sensors of the same "unit". This might be connected with the "metric" vs. "imperial" settings. For metric counters temp and tempin adding  the following entries to hass.py seem to make it work
from ecowitt2mqtt.const import (
...
    DATA_POINT_TEMP,
    DATA_POINT_TEMPIN,
...
)

DATA_POINTS = {
...
    DATA_POINT_TEMP: ("mdi:thermometer", "°C"),
    DATA_POINT_TEMPIN: ("mdi:thermometer", "°C"),
...
}

Checking the MQTT Broker the following sensors miss units

temp
tempin
baromabs
baromrel
dailyrain
hourlyrain
monthlyrain
rainrate
totalrain
weeklyrain
windspeed
windgust

Please paste some examples. When I look at the config topic for the temp sensor (homeassistant/sensor/ID/temp/config), I see a unit:
{
  "availability_topic": "homeassistant/sensor/ID/temp/availability",
  "icon": "mdi:thermometer",
  "name": "temp",
  "qos": 1,
  "state_topic": "homeassistant/sensor/ID/temp/state",
  "unique_id": "ID_temp",
  "unit_of_measurement": "°F"
}

Also, please share the version you are using.

Update to 1.0.4 and now Units are present but "metric" units are not working anymore. I do start with the following cmd line
/usr/local/bin/ecowitt2mqtt --mqtt-broker=homeassistant.fritz.box --mqtt-username=tasmota --mqtt-password=xxx --hass-discovery --unit-system metric

This is what is present in MQTT broker for example in the temperature sensor it uses Fahrenheit and not Celcius.
{"availability_topic": "homeassistant/sensor/641BC45267D8313205E7DC98CA552E6C/temp/availability", "icon": "mdi:thermometer", "name": "temp", "qos": 1, "state_topic": "homeassistant/sensor/641BC45267D8313205E7DC98CA552E6C/temp/state", "unique_id": "641BC45267D8313205E7DC98CA552E6C_temp", "unit_of_measurement": "\u00b0F"}

Ah, okay: the correct metric temperature is being calculated, but the unit isn't coming through in HASS Discovery. I'll look into it.

Yes that might be the case.
There is another thing in Home Assistant that I found :  Lovelace  might already do the calculation. Have a look at the screenshot below. You can see that when I updated the version the value suddenly dropped to a -14.x value but the value passed in the mqtt broker was still  +6.x but with "°F" as Unit and the graph itself is in "C°" ... interesting ;)

@MarkThielen FYI, this has been fixed in 1.0.5. The PyPI version is live, but the Docker image is still building, FYI.

Thanks @bachya I updated and it works. I checked the units in the MQTT broker and found the following with "null" as unit

windgust
windspeed
wh65batt

@MarkThielen Thanks! I'll get windgust and windspeed. wh65batt is 0 for me; what should the unit be?

@MarkThielen Thanks! I'll get windgust and windspeed added shortly.
wh65batt is 0 for me and I'm not sure what that unit should be. Let's move the battery-related discussion to #18

According to this Forum  https://www.wxforum.net/index.php?topic=38922.0 It seems like that 0=Battery OK and 1=Battery Low so we could say there is no unit.


Vertical cursor movement doesn't persist offset across shorter lines

Assuming the following document:
class MyType
   def method
   end
end

if the cursor is on the method token's d character, and it is moved up, and then down, it will then be on the o character. It should return to the d character.

Implemented via 447cb7c186f670dd0a921dac800e31be7bb63654.


Interface Builder Designables Error

Hello,
After integrating XLPagerTabStrip to my project, I'm getting interface builder errors.
error: IB Designables: Failed to render and update auto layout status for UserProfileViewController (7sb-El-gf8): dlopen(XLPagerTabStrip.framework, 1): no suitable image found. Did find: XLPagerTabStrip.framework: required code signature missing for 'XLPagerTabStrip.framework'
Do you have any solution ?

Hey @sehmus !
Can you provide a sample project to reproduce this issue ?

Closing due to lack of response.

Same problem here. I just updated my podfile and now have this issue.

@anthonyroani i got the same problem when i added a library in pod and did pod install. When i am Opening the Storyborad i am not able to see any elements. Did you got any solution ?

Just ran into this issue. Not sure what the problem was, but deleting my project's "Derived Data" folder and cleaning the project solved the issue for me.

Any solution or pr updates?

Facing Same issue

Any Solution for this?

Downgrade your cocoapod to version 1.4 and wait for the new update on the cocoapod.


Monitoring dashboards deployment

This PR creates a new monitoring module that can be deployed to Turbinia. The infrastructure consists of deploying Node Exporter to the Turbinia Worker(s) and Server in order to collect system metrics as well as spinning up individual prometheus and grafana instances to pull and display the metrics.

Monitoring ssh


[release-v1.2] Remove KafkaSource migration logic

Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>

/cherry-pick release-v1.3

/test 49-e2e-aws-ocp-49

/test 49-e2e-aws-ocp-49

/retest-required

@pierDipi hrm, looks like here we had (on 4.9) an TestKafkaSourceUpdate issue

That's a flake but I don't think it's related to this change.


keeperrl: init at alpha24

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Is the version name ok?
Does someone have a cleaner way to deal with a program that thinks it always runs with write permission on the compilation dir? https://github.com/miki151/keeperrl/issues/376
I think that you can just put the data folder for the paid version on ~/.keeperrl, in case someone can test this.

What is the status of this pull request?

I deleted my fork and recreated it so I don't think I can fix this PR, so I opened another: https://github.com/NixOS/nixpkgs/pull/43409


Missing Event failproof against Closure handler detaching

It's stated in the Guide:

Note that in general you should not try to detach an anonymous function unless you store it somewhere when it is attached to the event. In the above example, it is assumed that the anonymous function is stored as a variable $anonymousFunction.

BTW. It would be nice to add this as a comment for all off() methods.
Framework is failproofed against the mentioned only for non-global attaches. Simple wrapping this Event code with
if (isset(self::$_eventWildcards[$name][$class])) {
}

like in case of Component is enough.
What steps will reproduce the problem?

Attach an global event handler to event where handler is a Closure (not stored as a variable).
Try to detach this handler by providing Closure again.

What is the expected result?
false since Closures can not be compared (Event).
What do you get instead?
Undefined index: [...]

Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.1.9

Duplicate of #16377


Replace firstChild with firstElementChild

Issue:
In certain cases, firstChild returns a textNode due to whitespace or other content. This causes the resize functionality to break, as it expects an element node.
Solution:
To resolve this, I've replaced firstChild with firstElementChild. This ensures that the resize logic always interacts with a valid element node, preventing breaks in cases where firstChild returns a textNode.
issue in tiptap: ueberdosis/tiptap#5695

Could you provide a minimal reproduction for "In certain cases, firstChild returns a textNode due to whitespace or other content"?


Ensure list header titles are vertically aligned the same

We now show subheader text in a couple of places

home page
cluster list
others?

At the moment these are centrally aligned, meaning the headers appear above / below each other

These should be vertically algined
Something like

The screenshot shows how this might be done (adding vertical-align and padding-top to th) but has not been tested in other use cases of the table.

Only lists with sub-header labels should be top aligned

I'm seeing the vertical-align and padding-top are under top-aligned th, and not th itself. Should this suffice for the test to pass?

Tests pass on v2.9-16190ecee0aa3fb4aa570aa0fc932a36d9dcd082-head


[Tokens] Update colour light leboncoin

Some colours were no longer accessible
Impact:

Support container:  E6F2FD (Blueberry 100)

On Support Container: 152233 (Blueberry 900)

Support: 094171 (Blueberry 800)

Support Variant: #0C5291 (Blueberry 700)

Support hover: #0C5291

Basic: #094171 (Blueberry 800)

Basic container : #E6F2FD (Blueberry 100)

On Basic Container: #152233 (Blueberry 500)

Basic hover: #0C5291

Base:

On background / Variant/ On surface: #152233
Surface Inverse: #2B3441
Outline: #ACB8C7 (Nightshade 400)
Outline high:  #202730
Overlay: #202730 (72% opacity)

Feedback:

Neutral Container: #F0F2F5 (Nightshade 100)
On neutral container : #3A4757 (Nightshade 700)
Info: #C2E0FA (Blueberry 200)
On Info container : #0C5291 (Blueberry 700)

Bonus :

Twitter: #14171A

it can be closed as the theme has been updated on LBC 👍


Provides users/:uid/activity API endpoint

Fixes #4119 to access a given (or the current) user's activity for a specified nid.
GET http://dev.dosomething.org:8888/api/v1/users/8/activity.json?nid=1619
GET http://dev.dosomething.org:8888/api/v1/users/current/activity.json?nid=1619

:+1:

Minor discussion question -- this brings up https://github.com/DoSomething/dosomething/issues/2523 again. Note the response is not 2 separate properties for a Signup object and a Reportback object, but an object which contains relevant properties from both.
Any thoughts on whether or not this endpoint perhaps be renamed to Signups, e.g. users/current/signups?nid=23 ? And Reportbacks become properties of a Signup?  It feels weird to have an "Activity" class which is the combination of both, only because "Activity" feels very non-descriptive...
cc @sergii-tkachenko @jonuy @angaither @weerd

I think "activity" as a combo of the two is actually ok. It'd feel weirder for me if "reportbacks" were a property of "signups".

You should not be able to reportback without signing up, so it makes sense to me that reportbacks would exist as a property on a signup. it'd also mean we just archive one table (signups) vs two .
We do get the performance gain by having them as 2 separate tables tho.

I thought reportbacks and signups were on two different tables already and essentially acting as two different resources. That a reportback should only be created after a signup seems like logic that apps should be responsible for. Like with the current state of SMS, reportbacks are getting submitted without a corresponding signup.

@jonuy yes -- they are currently built out as two diff tables / entities.  https://github.com/DoSomething/dosomething/issues/2523 is more of a discussion point of: "Shouldn't it be a global / product rule that every Reportback have a corresponding Signup"


Add secrets-store-csi-driver.fullnameOverride to helm charts

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/671 adds option to set the fullnameOverride. When the helm charts with those changes for driver are available, we should set the secrets-store-csi-driver.fullnameOverride value in the values.yaml to secrets-store-csi-driver. This change will prevent the helm chart release name from being added as prefix to the subchart (driver) fullname.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
This will help with issues like #592

Closed with #608


browser.close hangs with beforeunload dialog

Puppeteer: v1.11.0
In headful mode, browser.close doesn't force-close browser, stalling the process in case of beforeunload dialogs. This is a little surprising to me - I'd expect beforeunloads to be ignored by default.
const puppeteer = require('puppeteer');

(async() => {
  const browser = await puppeteer.launch({
    headless: false,
    userDataDir: 'ppp',
  });
  const page = await browser.newPage();
  await page.goto('https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload');
  const frame = page.frames().find(frame => frame.name() === 'iframeResult');
  await Promise.all([
    // make sure beforeunload triggers once
    new Promise(resolve => page.once('dialog', resolve)).then(dialog => dialog.dismiss()),
    frame.click('a'),
  ]);
  // This will hang forever
  console.log('Exiting...');
  await browser.close();
  console.log('Done.');
})();

I made a PR to fix this.


add JSON-LD export

Apparently, JSON-LD is very popular right now, so we should support it in RickView as well, if possible.

Unassigning me until someone requests it.

Impact of the sophia/jsonld feature

jsonld
build time
binary size in b

no
430.38s user 15.34s system 358% cpu 2:04.31 total
11 537 488

yes (unused)
466.01s user 18.22s system 338% cpu 2:23.24 total
11 541 584

yes (used)
444.21s user 17.87s system 353% cpu 2:10.61 total
11 746 384

Measured with cargo clean && time cargo build --release && command ls -l target/release/rickview on a dual core Lenovo laptop with a i3-1115G4 @ 3.00GHz CPU.
So ~2% bigger binary and 6 seconds longer compile time for a feature nobody needs yet, mark as won't fix until someone has a clear need for it.


TagHelper allow hide/show/disable on tag

@andrebaltieri said:
Hey guys, do we have a feature on TagHelper to hide/show/enable/disable a piece of HTML based on a Razor condition? Something like:
<div show="User.IsAuthenticated">

Something that bothers me is to have a lot of ifs on HTML code.
Today we have such similar behavior on AngularJS with ng-show for example.
Is it (or will it be) possible with Razor?
Thanks!

Angular also uses ng-if to determine whether to actually output the element into the HTML at all. Is this something that is even possible with the Tag Helpers API? I haven't actually worked with it yet; can you use it to render other alternate output in a way that represents the current element?

Excuse me, I meant to say "in a way that replaces the current element".

In Razor you can use an @if() statement to control what gets rendered/run.


AVT-1145 [Spectron] Review and update the existing tests in closePopOutsOnReload.spectron

Description
Review and update the existing tests in closePopOutsOnReload.spectron AVT-1145
Run
https://jenkins2.symphony.com/job/electron-robot-playground/190/
https://jenkins2.symphony.com/job/electron-robot-playground/189/
https://jenkins2.symphony.com/job/electron-robot-playground/188/
https://jenkins2.symphony.com/job/electron-robot-playground/187/

@thaisym1912 Please resolve conflicts


Can't clone repo on Windows

The docs have files with a : colon in the filename (i.e. About:-Bsc-plugin.md)and because of this the repo can't be cloned on Windows computers.

FYI I was able to successfully clone the repo using WSL but Windows is still not happy about it

resolved


[textanalytics] decorator to validate multiapi

This decorator helps...

move some of the multiapi param validation out of the client methods
validate args/action type support between the TA service vs Language... since the input shaped has changed between API versions and many of the args went from query params -> body params, we validate so that users targeting an older API version don't pass unsupported params which get silently ignored. We plan to let the service validate between Language API versions in the future.

API change check for azure-ai-textanalytics
API changes have been detected in azure-ai-textanalytics. You can review API changes here


Visual update 1: Misalignment of Docs File viewer/editor on page

Steps to reproduce the issue
When opening or editing an excel file via Files the current positioning of the viewer/editor on the page causes the taskbar of Win 10/7 to overlap with the bottom of the displayed excel file, likely caused by the introduction of the new additional upper bar where one can select a new file. The additional height of this new bar looks not be accounted for in the page layout causing the OS taskbar to partly overlap the displayed excel file.

Browsers tested; FF/Chrome

Screen shots

Source
dWAnswers question: https://developer.ibm.com/answers/questions/461191/visual-update-1-misalignment-of-docs-file-viewered.html

Issue #1766 opened in IBM repo to fix this issue.
Fix in progress.


refactor: remove unused api in cluster manager

What's changed and what's your intention?

Removed deactivate_worker_node in  ClusterManager.
Removed get_cluster_core_guard to avoid exposing lock publicly.

get_cluster_core_guard is used for snapshot consistency when synced to frontend. Suggest to keep it. Cc @HuaHuaY