Windows binaries not working properly

Please, can you provide the latest windows binaries (both 32bit & 64bit)? Compiling working binaries for windows is unresolved puzzle for me.

Hello! Which binaries do you need? baresip-executable or compiled baresip lib?
You can use this instructions for compiling project for your need
https://github.com/alfredh/baresip/issues/731#issuecomment-501284999
https://github.com/creytiv/re/issues/150
https://github.com/alfredh/baresip/issues/711
There is ready solution (baresip/mk/win32/baresip.sln) for compilation, all what you need is to get right project structure and load solution

I guess I need baresip executable. I need exe files (both 32bit & 64bit) for Windows 10 that can call answer calls and interact with http (localhost:8000).

Please, can you provide windows binary files of any version which works properly on Windows 10?

@Encamy Any luck?

Actually I followed the folder structure (see https://github.com/alfredh/baresip/issues/731#issuecomment-501284999). It is even compiled without any errors either warning but the binary file is not working properly on Windows 10 (64 bit). The util can answer call but it cannot dial a number (change of FD_SETSIZE value see https://github.com/alfredh/baresip/issues/731#issuecomment-500957006 did fixed the issue). HTTP serer on <IP_ADDRESS>:8000 is not working as well. You can check
error log
open: ./httpd.dll LoadLibraryA() failed
open: ./sndfile.dll LoadLibraryA() failed
open: ./debug_cmd.dll LoadLibraryA() failed
All 1 useragent registered successfully! (170 ms)
>                             1111
fd_listen: fd=1056 flags=0x01 - Max 1024 fds
fd_listen: fd=1056 flags=0x01 - Max 1024 fds
fd_listen: fd=1056 flags=0x01 - Max 1024 fds
fd_listen: fd=1056 flags=0x01 - Max 1024 fds
fd_listen: fd=1056 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1112 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1116 flags=0x01 - Max 1024 fds
fd_listen: fd=1120 flags=0x01 - Max 1024 fds
fd_listen: fd=1120 flags=0x01 - Max 1024 fds
fd_listen: fd=1120 flags=0x01 - Max 1024 fds
fd_listen: fd=1120 flags=0x01 - Max 1024 fds
long async blocking: 291>100 ms (h=0x67d1d8a0 arg=0xd85003f0)

output log
baresip v0.6.1 Copyright (C) 2010 - 2019 Alfred E. Heggestad et al.
Local network address:  IPv4=:<IP_ADDRESS>
module httpd.dll: No such file or directory
aucodec: PCMU/8000/1
aucodec: PCMA/8000/1
aufilt: vumeter
module sndfile.dll: No such file or directory
winwave: output devices: 1, input devices: 1
ausrc: winwave
auplay: winwave
vidsrc: dshow
medianat: stun
medianat: turn
medianat: ice
Populated 1 account
Populated 3 contacts
module debug_cmd.dll: No such file or directory
Populated 2 audio codecs
Populated 1 audio filter
Populated 0 video codecs
Populated 0 video filters
baresip is ready.
<EMAIL_ADDRESS>{0/UDP/v4} 200 OK (Zadarma server) [1 binding]
stream: rtp_listen failed: af=AF_INET ports=1024-49152 (Too many open files)
stream: failed to create socket for media 'audio' (Too many open files)
menu: ua_connect failed: Too many open files
ua: stop all (forced=0)

It was reported (see https://github.com/alfredh/baresip/issues/654) with a reference to your profile that there was the release for Windows 10. Please, can you just provide the builds.

Hi. To be able to use getopt i have used vcpkg install getopt then vcpkg integrate install to get the headerfiles visible for vs2019. Then it's possible to use -n  to select interface to be used by baresip. I also change added HAVE_GETOPT in the projektfile
https://github.com/microsoft/vcpkg
I still have issues with
fd_listen: fd=1168 flags=0x01 - Max 1024 fds
even though i've set FD_SETSIZE=2048 in the same projectfile.

@Ola-Palm Do you have binaries which work properly in Windows 10?

@alexander-elgin
I need to fix the FD_SETSIZE, to get calls working.

After updating FD_SETSIZE in re projectfile to the same value as set in baresip projectfile, all is working.

@Ola-Palm Please, can you share the exe files?

there are some errors in the VC Project file.
it would be nice if someone can update the VC file, test it, and send
the changes as a PR.
@alexander-elgin if you want binaries you can also try to ask
on the re-devel mailinglist.

I can update with my project files.
But currently the release config doesn’t work. I will try to find time to fix this during the weekend or the next coming week.
I’ll push current state to my fork of baresip in a new branch. Then perhaps we could make a PR from that branch when everything’s working.
Skickat från min iPhone
21 mars 2020 kl. 13:14 skrev Alfred E. Heggestad<EMAIL_ADDRESS>
there are some errors in the VC Project file.
it would be nice if someone can update the VC file, test it, and send
the changes as a PR.
@alexander-elginhttps://github.com/alexander-elgin if you want binaries you can also try to ask
on the re-devel mailinglist.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/alfredh/baresip/issues/942#issuecomment-602035860, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZ36DNYC7FE3TUXRQG3IO3RISVR7ANCNFSM4LQDZAMQ.

Why can't you upload the binaries here or send them by email (you can find my email address on my profile page) to me?

@Ola-Palm Which patch did you use to fix the FD_SETSIZE issue https://github.com/alfredh/baresip/issues/731#issuecomment-500957006 or https://github.com/creytiv/re/commit/49834b7afd0fe31660108271ef7657a34caa6a6d?

@alexander-elgin
I didn't use any patch. I changed the FD_SETSIZE=2048 in re projectfile.
you will find this in re\mk\win32\re.vcxproj or by rightclick the re project and make the change in properties --> c/c++ -->preprocessor --> perprocessor definnitions. This is also set to the same value in baresip projectfile.
I still have som issues building a release version.

@Ola-Palm Please, can you share the binary files which work anyhow better?

Hi,
Here is an archive with the windows binaries (version: git master of the day , tested on Win10, cross compiled with mingw):
https://filesender.renater.fr/?s=download&token=b5035c23-17a0-b81c-eb8f-af8e074ec81d&lang=en
There is also a .bat to launch baresip and use it from an experimental (experimental => really dirty, please be aware of that) web interface (should work with others OS).
Hope this helps.

@nicotyze Many thanks for that. It works almost fine but the calls are not recorded. I think that's because you compiled the project without sndfile. I reported the issue (see https://github.com/alfredh/baresip/issues/672) and created a fix for that (see https://github.com/alexander-elgin/baresip-win32). I would be very thankful if you can include it into your build.
@nicotyze Please, can you share a guidance on how you compile the exe file (including the OS version, what compiler you used and where you got it, any fixes that you applied, versions of the re, rem, openssl, dirent and etc.)? Taking into account https://github.com/alfredh/baresip/issues/731, https://github.com/alfredh/baresip/issues/732, https://github.com/alfredh/baresip/issues/711, https://github.com/alfredh/baresip/issues/888, https://github.com/alfredh/baresip/issues/881, https://github.com/alfredh/baresip/issues/872, https://github.com/alfredh/baresip/issues/842, https://github.com/alfredh/baresip/issues/212 and even comments in this thread from the maintainers e.g. https://github.com/alfredh/baresip/issues/942#issuecomment-602035860 and https://github.com/alfredh/baresip/issues/942#issuecomment-602042767 I am not the only one who met issues with compilation for Windows

This is a detailed guide in order to generate/test windows binaries with sndfile support (among others):
https://github.com/nicotyze/Baresip-Win32

@nicotyze Many thanks for that


Measure-Keyword - Only match the keyword and not other words

Update the regex on Measure-Keyword to not match words containing the keyword.
This Pull Request (PR) fixes the following issues

Fixes #11

This change is

@johlju


🎉 Initial Commit: Let's push time to bring this back to life!

Changed naming, links etc
Updated Banner
Replaced Parcel with Vite as the main dev tool for example playground.

First steps so far.

@aladdin-add  Ready to merge!!

thanks for doing this! I've left a few naming suggestions, and seems the docs(readme) were updated?

Yup I am making the changes u told, and No I think the readme docs changes are mainly the same ones as before. Will have to go through it and let u know.

@aladdin-add  Done with all the changes

@aladdin-add Anything else that is left ? or should I merge this?

seems the PR mainly includes 4 things:

renaming package tsdx => dts
removing webiste
changing parcel to vite
reformatting some files

what do you think split it to several smaller PRs? (good to keep 1 PR for 1 thing)

Lol Sorry yes I know, I was trying to edit some things using the github web only. Although it committed every one of them.

closing as fixed.


Alloy prometheus.exporter.blackbox  no probe frequency

Alloy prometheus.exporter.blackbox has no Argument to specify a probe frequency , the default looks like 60 seconds.
I want to specify a probe frequency when using the TCP probe.
https://grafana.com/docs/alloy/latest/reference/components/prometheus.exporter.blackbox/
There also seems to be no debugging logging for this exporter.
Is there alternative to probe a remote server using a TCP probe ?

I think you're looking on the wrong component. It would be something like this
`prometheus.scrape "certs" {
scrape_interval = "30s"
targets = prometheus.exporter.blackbox.cert.targets,
forward_to = [ prometheus.remote_write.mytarget.receiver ]
}
prometheus.exporter.blackbox "certs" {
config = "{ modules: { http_2xx: { prober: http, timeout: 5s } } }"
target {
name      = "my_app"
address = "https://myurl"
module   = "http_2xx"
}
}
`


(fleet) env cleanup

Move env under installer
Extract the config => env mapping to the daemon (background goal is to remove all reference to the agent config in the installer CLI since it's hard to reason about wether it's available or not.)
Change the HTTP proxy impl to avoid relying on the config

Describe how to test/QA your changes
Covered by e2e

/merge


Add support for the JSON.MSET command

Please refer to https://github.com/apache/kvrocks/issues/1805.

Hi, I want to try this task~

Assigned.

Hi, this issue still working in progress.

OK, thank you!

Is anyone working on it? I'd like to submit a PR to close this issue.

@zjregee Thank you! I have reassigned this issue to you.


Upgrade dependencies to their latest versions

Thank you :) I have a question though, would there be implications if we drop patch numbers (make it 0.16 instead of 0.16.0)?

Sure thing. I'll do that (the initial title's verbosity owes its credits to the GH extension I use :D)

The only issue is that patches (according to semver), occasionally have the choice to break^1

Right, but I'd expect a user to pin a particular patch on their application level. E.g. if I add cookie = 0.16.1 into my application deps, I'd expect Cargo use to use this version for tower-cookies too. It's published, thank you :pray:

Agreed. Thanks for the quick release; will bump the dep now :)


yarn add @morpheme/ui-nuxt not found

Environment
here is my package.json
 "devDependencies": {     "@nuxtjs/eslint-module": "^4.0.2",     "@nuxtjs/tailwindcss": "^6.6.8",     "@tailwindcss/typography": "^0.5.9",     "@types/node": "^18",     "nuxt": "^3.4.3",     "prettier": "^2.8.8",     "tailwindcss": "^3.3.2",     "vitest": "^0.31.0"   },   "dependencies": {     "@pinia/nuxt": "^0.4.10",     "@vueuse/nuxt": "^10.1.2",     "pinia": "^2.0.36"   }
Reproduction
i just create from scratch then add package in Environment
Describe the bug
when i want to add morpheme/ui-nuxt
it print logs like below.

Additional context
No response
Logs
yarn add v1.22.19
warning ../../../../package.json: No license field
[1/4] 🔍  Resolving packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/@morpheme%2fui-nuxt: Not found".
info If you think this is a bug, please open a bug report with the information provided

Hi, it is renamed to @morpheme/nuxt since Beta 5. Check out migration guide here: https://gitsindonesia.github.io/ui-component/guide/migration.html#from-gits-ui-to-morpheme-ui-1-0-0-beta-5

hi @gravitano
yes..
i just found that the documentation need to be update..
thank you..


CMK Encryption support for resources in templates

Resolves #4145
What is being addressed
Added support for CMK encryption for resources in templates.
How is this addressed

Workspace services use the CMK and encryption identity of the workspace to enable encryption for supporting resources.
Shared services use the CMK and encryption identity of the core TRE to enable encryption for supporting resources.

@yuvalyaron do we know what the upgrade behaviour is here? Might be worth incrementing bundles by a major version to prevent easy upgrade?

/test-extended

@yuvalyaron do we know what the upgrade behaviour is here? Might be worth incrementing bundles by a major version to prevent easy upgrade?

Upgrading is not an issue as long as the enable_cmk_encryption variable remains unchanged, and we assume it will never change (though the exact approach to how to ensure this is yet to be determined):  https://github.com/microsoft/AzureTRE/issues/4172

/help

/test-destroy-env

/test-extended

/test-extended

/test-force-approve

The workspace tests fail because the Terraform code from the base workspace in the old release does not include the newly added variables. This issue should be resolved once a new release is created.


IstioCoreDNS is not resolving any domain other than *.global

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ x ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
service entry domain should resolve to an ip.
Steps to reproduce the bug
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: keycloak-dns
spec:
  hosts:
  - 'keycloak.sunbird.dev'
  addresses:
  - <IP_ADDRESS>
  ports:
  - number: 8080
    name: keycloak
    protocol: HTTP
  location: MESH_INTERNAL
  resolution: DNS
  endpoints:
  - address: <IP_ADDRESS>

Version (include the output of istioctl version --remote and kubectl version)
❮ istioctl version
client version: 1.2.4
citadel version: 1.3.2
galley version: 1.3.2
ingressgateway version: 1.3.2
nodeagent version:
pilot version: 1.3.2
policy version: 1.3.2
sidecar-injector version: 1.3.2
telemetry version: 1.3.2

How was Istio installed?
helm
Environment where bug was observed (cloud vendor, OS, etc)
auzre, local(with k3d)
Note:
I figured there is a hardcoded global entry in core file.
Is it by design not to allow custom domain resolution? Can you kindly tell me why is that?
  Corefile: |
    .:53 {
          errors
          health
          {{ if eq -1 (semver  .Values.coreDNSTag  | (semver "1.4.0").Compare) }}
          # Removed support for the proxy plugin: https://coredns.io/2019/03/03/coredns-1.4.0-release/
          grpc global <IP_ADDRESS>:8053
          forward . /etc/resolv.conf {
            except global
          }
          {{ else }}
          proxy global <IP_ADDRESS>:8053 {
            protocol grpc insecure
          }
          proxy . /etc/resolv.conf
          {{ end }}
          prometheus :9153
          cache 30
          reload
        }

Facing a similar problem but even *.global doesn't work for me. I followed the steps documented here: https://istio.io/docs/setup/install/multicluster/gateways/#setup-dns
CoreDNS is behaving in a very strange way for me. If the hostname is DNS resolvable for HTTP e.g. google.com, then it works for me even without making any changes to the corefile. However, if the hostname is not DNS resolvable e.g. myservice.internal, nothing works and on lookup I get an error with message: getaddrinfo ENOTFOUND myservice.internal.

for a simple example.

create config map like this

---
apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    addonmanager.kubernetes.io/mode: EnsureExists
    k8s-app: kube-dns
    kubernetes.io/cluster-service: "true"
  name: coredns-custom
  namespace: kube-system
data:
  Sunbird.server: |-
    global:53 {
       errors
       cache 30
       forward . <IP_ADDRESS> # istio core dns service ip
    }

I am using azure, and azure kube-system coredns will take this cornfig map as an additional serice entry. you might have to append this to your kube-system coredns config map if necessary.

Create serviceEntry

apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: keycloak-dns
spec:
  hosts:
  - 'keycloak.sunbird.global'
  addresses:
  - <IP_ADDRESS>
  ports:
  - number: 8080
    name: keycloak
    protocol: HTTP
  location: MESH_INTERNAL
  resolution: DNS
  endpoints:
  - address: <IP_ADDRESS>

now kubectl exec to any other pod and try to resolve keycloak.sunbird.global` will resolve the ip address.
@rahulrai-in this will help you out

My problem is a little different. The hostname sunbird.global can be resolved on internet and hence it works. If you replace it with a name whose lookup will fail on internet e.g. sunbird.local, then the resolution doesn't work.

oh no.
sunbird.global is in cluster scope. And the ip I get for keycloak.sunbird.global is the custom ip I give.
if you try to resolve the particular ip via internet, you won't get anything.

I found the solution to your problem while searching for my own issue. You can edit the corefile of coreDNS in istio-system namespace and change the hostname "global" to whatever, you want. I changed it to "internal" and it works just fine.

LOL, that's my question. Why global? why not forward everything which get forwards from kube dns?

Yeah fixed that too. Just need to replace global with a dot. I am going to raise a PR. Let's hope it makes it way through. It is a  very annoying bug.
Outlook for Android

From: Rajesh Rajendran<EMAIL_ADDRESS>Sent: Friday, October 25, 2019 5:28:24 PM
To: istio/istio<EMAIL_ADDRESS>Cc: Rahul Rai<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [istio/istio] IstioCoreDNS is not resolving any domain other than *.global (#18092)
LOL, that's my question. Why global? why not forward everything which get forwards from kube dns?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fistio%2Fistio%2Fissues%2F18092%3Femail_source%3Dnotifications%26email_token%3DAC2V7PEY5APVBBL5TJEEBELQQKGYRA5CNFSM4JCSFAKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHKRHA%23issuecomment-546220188&data=02|01||f6b2841c1b4c46ddfa5b08d759148a95|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637075817061363871&sdata=zjsM3v2rUZiGYcVyCAkLL5HG5zLTyezvoyevqd5vWeg%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC2V7PA6XMSCV4JTY2OY4BLQQKGYRANCNFSM4JCSFAKA&data=02|01||f6b2841c1b4c46ddfa5b08d759148a95|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637075817061373879&sdata=Fk7mOS4e1JBHQ2xwLECxonEeeQ77fElCx0O%2BzKVT%2BPA%3D&reserved=0.

The problem is that forwarding "everything" won't work as described here: https://github.com/istio/istio/pull/17291#issuecomment-533778576  (at least from my experience). You could try to set fallthrough to the forward plugin but at least from the docs I can't tell you if it will work.
IMHO instead of forwarding all the requests making the global domain as an input/variable of the helm charts should be preferred. I don't know your use case but from my point of view you probably have one (or a set) of domains that you will use for service entries with the istio coredns plugin (correct me if I'm wrong).

@rahulrai-in in order that the information is not spread across multiple threads: https://github.com/istio/istio/pull/17291#issuecomment-547670188
The grpc global <IP_ADDRESS>:8053 forwards all requests to *.global to the istio-coredns plugin which is listening on port 8053 and runs as another container inside of the istio coredns pod see: https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/istiocoredns/templates/deployment.yaml#L71 so there is no loop (otherwise the resolution wouldn't work).


Infopop attr filter

Coverage decreased (-0.02%) to 71.02% when pulling e485a9ca2595f4b5bd121897162fc86f202de83a on infopop_attr_filter into f9e7a220bd01f59671b3c693f4f990391cef91ba on master.

Coverage decreased (-0.02%) to 71.02% when pulling 549917f9fc5221a366188bdd24bac6149bbb2fc9 on infopop_attr_filter into f9e7a220bd01f59671b3c693f4f990391cef91ba on master.

Coverage decreased (-0.08%) to 70.965% when pulling d3b402ca8aa2fbce83a4f72a29837c0faaac6f32 on infopop_attr_filter into f9e7a220bd01f59671b3c693f4f990391cef91ba on master.

Coverage increased (+0.3%) to 71.304% when pulling d5d3986b8e4ed3d2a37ccaed3e77fad7767b5a91 on infopop_attr_filter into f9e7a220bd01f59671b3c693f4f990391cef91ba on master.

So if I understand the PR correctly, in addition to what we have for popupInfo:

string based template with [foo] for attribute foo
'#AllAttributes' to show all attributes

we are adding a third mode with an array of attributes to show right?

No the deletion breaks the basic example. Compare before and after:

thanks Bart. I've put the block back in that handles this type of popupInfo and changed where to use getGeometryName()

Coverage decreased (-0.01%) to 71.031% when pulling c46b7e5fa50efa9003e58dc23988a5d3d3d01928 on infopop_attr_filter into f9e7a220bd01f59671b3c693f4f990391cef91ba on master.

next step would be to document all the options somewhere but this can be done in a new PR


Update Composer dependencies (2021-07-05-00-02)

Visual regression test passed!
View the visual regression test report


[COMRPC] Allow reverting Administrator announcements

Add a new RPC::Administrator::UnAnnounce() method for reverting what is
done by RPC::Administrator::Announce().

Some of the proxy/stubs that are announced to the Administrator may be
gone before the Administrator singleton is deleted, where it is
currently looping through all announced proxy/stubs and deleting the
associated pointers. This happens for all proxy/stubs coming from
'libWPEFrameworkProxyStubs.so'. When an OOP plugin is exiting, this
library is unloaded before the Administrator singleton is destroyed. All
the proxy/plugins allocated by this library are now gone and outside the
process memory space, because the library has been unloaded. This leaves
the Administrator with stale pointers. When it's being destroyed and
trying to delete the stale pointers, it crashes with SIGSEGV.

The proxy/stubs generator can be changed to call a method in the
Administrator to revert the announcement when unloading. Provide and
implement such a method, named Recall(). It tries to find
proxy/stubs announced for the given interface and will "unregister" them
from the Administrator, by deleting the associated pointers and then the
entry itself from the maintained proxy/stubs maps.

Signed-off-by: Ricardo Silva<EMAIL_ADDRESS>[StubGen] Add Instantiation destructor implementation to Recall()

As the proxy/stubs announce themselves upon loading to the
RPC::Administrator using Announce(), they should symmetrically
recall them when unloading. Otherwise, the Administrator may keep
stale references to announced proxy/stubs that have been unloaded
already.

The RPC::Administrator now has an UnAnnounce() method for this purpose,
which should then be called when the proxy/stubs are unloaded, which
happens when Instantiation is destroyed.

This way, let the proxy/stubs generator provide a destructor for the
Instantiation class and call RPC::Administrator::UnAnnounce() for both
the proxies and stubs.

Signed-off-by: Ricardo Silva<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/590/ started


feat: add Blend helper

Based on https://github.com/charmbracelet/lipgloss/pull/154, this adds a simple helper for creating gradients between two colors, without changing anything about Render. I don't have strong opinions as to the API here, I'm just looking for an easy way to create nice gradients without having to import termenv separately.

Yeah, I think that makes sense. @lukechampine, want to open a PR over there?
I'd also suggest using go-colourful directly (termenv is just wrapping it) and blending with the HSLuv algorithm.

ah, thanks -- go-colorful has no dependencies, so that's perfect


Map accelerators to custom notebook images

Goal
Be able to visualize and configure images accelerators mappings from the custom notebook images page and table
Dependency issue

https://github.com/opendatahub-io/odh-dashboard/issues/1438
https://github.com/opendatahub-io/odh-dashboard/issues/1371

Itemized goals

add supported accelerators column
images with no accelerators should show None, while mapped accelerators are shown as pf labels
images can either have a Habana label or Nvidia label or no label depending on the images supported accelerators' identifiers

for OOTB images, this can will be either nvidia.com/gpu, hpu.com/gen1, or hpu.com/gen2 or none. nvidia.com/gpu and hpu.com/gen[1,2] are mapped to Nvidia GPU and Habana HBU respectively.
for custom notebooks, the same logic is applied, however custom identifiers or multiple different identifiers result in no label shown.

update manage notebook image to include accelerator select

show empty state and redirect if no accelerators are created
display all accelerators in checkbox select list
show accelerator group labels if they have a supported one (habana or Nvidia)
have a link to accelerator table page
the image gets a group label using the same logic as above

Aspects continued elsewhere
No response
Mocks
https://www.sketch.com/s/c8183f89-76f5-4a23-b885-a9e404a61414/a/g1ZEQya
https://www.sketch.com/s/c8183f89-76f5-4a23-b885-a9e404a61414/a/0A707qy

Needs UX
@yannnz
I believe this is where you last were working for the notebook image admin page

https://github.com/opendatahub-io/odh-dashboard/issues/1802#issuecomment-1723722566

This issue will be on hold until more solidified details on the use of group labels

Needs UX
@yannnz
I believe this is where you last were working for the notebook image admin page

Habana (accelerator) UX design for admins #1802 (comment)

This issue will be on hold until more solidified details on the use of group labels

Yes that link is the latest one.

latest https://www.sketch.com/s/c8183f89-76f5-4a23-b885-a9e404a61414/a/aMV90OP


Use .cjs and .mjs file extensions

ESM/CommonJS error under the following conditions:

Separate project
Uses @medplum/react
Uses a component that uses @tabler/icons
Uses vitest for testing
For some reason, the transient dependency is interpreted as CommonJS, and not ESM

There are a disturbing number of ways to say "this is an ESM module", and I thought we had already implemented the important ones:

Use exports in package.json
Set non-standard module in package.json for Webpack
Add supplemental {"type":"commonjs"} and {"type":"module"} package.json files in dist directories

But alas there were still problems.  So in this PR, the file outputs use .cjs and .mjs extensions, so each file is clearly identfiable.

Coverage increased (+0.003%) to 93.728% when pulling 075e90d58ad3bf2c3a93bb518f0b84858da976c7 on cody-cjs-mjs-file-extensions into efe93063ab0e62bd33754e3eb0e0fcd7b7a28892 on main.


Input - Uncontrolled

Is your feature request related to a problem? Please describe.
We want to manage uncontrolled input in our application.
It seems the definition of uncontrolled input is different from the CDK and REACT :
https://reactjs.org/docs/uncontrolled-components.html
For example, the uncontrolled CDK exemples for DXCTextField is based on onChange :

On each key press, onChange is trigged. In fact, this is a controlled component.
Controlled input component makes component re-render on each key press and can cause performance issue.
Describe the solution you'd like
We would like to set a ref to each CDK components.
The priority will be on Input component used in Form.
We want to use yup validation form.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
Add Labels
React HalStack V3

A couple of clarifications:

The example you shared doesn't trigger a re-render, and even if it did, in the vast majority of cases it wouldn't cause a performance issue.
If you choose not use controlled components, the reason shouldn't be this type of micro-optimization.

Our components are uncontrolled, because you don't need to pass a value for them to work. But I agree it would be nice to have the ability of setting a ref to the input, in order to facilitate the access to the value. We will incorporate this functionality.

The new input components took feedback from this issue and they already provide the ref property.
These components are already available in the @next release (https://developer.dxc.com/tools/react/3/#/components/newInputText) and will be part of 4.0.0 once we release it during the next couple of weeks.
Thanks for the feedback @NorbertPointu 😀


Prism Generator

Hi,
Is there any way to use Prism Generator in our project (like in demo)?

Hi,
Of course you can use anything in your project, including the prism generator, and the UI. If you would be more specific, maybe I could give you some tips.
Viktor

Yes, I'm interested in to listen your tips.
But I'm new in HTML5 Canvas!

Ok, so what would you like to do?

I'm going to create a pad for my user so they can draw a shape on it (Like pen tool in Photoshop or your prism generator in demo page). After that, I will create a 3D room from that shape.

hello, I'd like to know if it's posible to sculp a 3D object from zero, I mean starding from nothing and truning into a cup, a bottle, a glass of wine, can I do that with this pluging or this olny work for cubes and basic forms???

Hi! Sculpting is not possible, but JSModeler contains importer for 3ds, obj and stl files.

Dear mherg! Please take a look at the sandbox folder. There you can find a polygon editor, and examples on using the framework. If you created the polygon with any tool, I can help you to generate a prism from the points of the polygon.

I have created a fiddle, which generates a room from a polygon:
http://jsfiddle.net/Lnye1t1x/1/

Yes!
Thanks a lot for this snippet.


Implement ADB function through qemu pipe

Summary
Add qemu pipe support for microADB.
Please enable ADBD_QEMU_SERVER to experience this feature.
More details about Kconfig, please see https://github.com/apache/nuttx-apps/pull/2688 - a497eb954e69165aa785597fa50082f74a0f718a.
Impact
New feature, enabled by CONFIG_ADBD_QEMU_SERVER.
Testing
CI

should we add CONFIG_ADBD_QEMU_SERVER to CMakefile.txt too

should we add CONFIG_ADBD_QEMU_SERVER to CMakefile.txt too? @JianyuWang0623

Yes, and  @xuxin930 has added - https://github.com/apache/nuttx-apps/pull/2426/files#diff-ad8659093e701ea8aa2f27505b482c6346472d300b077032a9d418482e36ce86R69

@spiriou Could you reivew this PR please?


feat(dynamincpassword): removed password length

Codecov Report

Merging #275 (a71ca56) into master (c66041f) will increase coverage by 0.05%.
The diff coverage is 66.66%.

:exclamation: Current head a71ca56 differs from pull request most recent head cd30a75. Consider uploading reports for the commit cd30a75 to get more accurate results

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   49.53%   49.58%   +0.05%
==========================================
  Files          33       33
  Lines         852      851       -1
  Branches       89       89
==========================================
  Hits          422      422
+ Misses        396      395       -1
  Partials       34       34

Impacted Files
Coverage Δ

...p/configs/config-detail/config-detail.component.ts
25.60% <0.00%> (+0.30%)
:arrow_up:

...rofiles/profile-detail/profile-detail.component.ts
67.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66041f...cd30a75. Read the comment docs.


Cannot change the logo in the overlay

I tried few images to change the logo - i tried to renamed it but nothing happened. Can you please help me? I will add pictures which i tried

I can add the LMS logo without issue. (for what its worth, these aren't transparent pngs, I'm not sure if this is because of github or the logos themselves).
If you are using the europe layout, all you need to do is place your logo in \lol-pick-ban-ui\layouts\layout-volu-europe\src\assets and rename it to "Logo_Itemania_2019.png"


ErrorCode: NotFound Description: NOT FOUND Reason:

ErrorCode: NotFound Description: NOT FOUND Reason:

This issue was resolved. There was item in my pos that was not in the erp


python3Packages.dingz: init at 0.5.0

Motivation for this change
Python API for interacting with Dingz device
https://github.com/home-assistant-ecosystem/python-dingz
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 148698 run on x86_64-linux 1

2 packages built:

python38Packages.dingz
python39Packages.dingz


Can you clarify your position about Windows support?

Hello,
For now, everything i've read about running opendistro for elasticsearch on windows imply running it using a docker image.
So can you answer the following questions:

Do/will you support running your distribution directly on Windows platforms?
Do/will you support running all your custom plugins directly on Windows platforms?
Can i expect the same level of support/testing/tooling on Windows platforms?

PS: I know java is meant to run the same on Windows than on Linux but the real life is more crual than the start of this sentence.

Hi @treilhes - We do plan to support Windows environments for Open Distro with the same level of support as all other packages. Note that the Performance Analyzer plugin may not be available in a Window environment due to its system architecture. Stay tuned! If you'd like to contribute in testing an alpha build, let us know and will be great to have your feedback.

A Windows build is available for Open Distro as of version 1.4.0. See https://opendistro.github.io/for-elasticsearch-docs/docs/install/windows/

The 1.40 windows distribution contains a non-windows JDK.  Should either remove it or updated to contain java for windows.

Hi @j0hnth0m thanks for flagging - we'll take a look.


[GH Actions] Enable lock action

Description

We are working on a bot's code migration to GitHub Actions 👉 fastlane/github-actions#3.
This PR is about enabling locking closed, inactive issues and pull requests workflow.
Enabling this workflow will not conflict with an issue-bot processing flow.
Testing Steps

The workflow file used for testing the action 👇
name: Locking issues and pull requests
on:
  schedule:
  - cron: "0 0 * * *"

jobs:
  lock:
    runs-on: ubuntu-latest
    steps:
    - uses: fastlane/github-actions/lock@latest
      with:
        repo-token: ${{ secrets.GITHUB_TOKEN }}
        days-before-lock: 1

BOT_GITHUB_TOKEN is set to my personal access token, that's why you see my personal avatar and "Thanks for your contribution."  comment in a pull request comes from a different GH Action.

@mollyIV Heyyy 😊 I'm slightly torn about this one, TBH 🤔 I've seen quite a bit of backlash about locking issues and PR lately. Closing seems totally okay but I'm not sure if we should auto lock since it prohibits communication and than can frustrate some members of the community. Do you have any thoughts or experienced with locked issues in other communities?

Hello Josh 👋 Actually the current implementation of our active bot is locking the issues:
https://github.com/fastlane/issue-bot/blob/457348717d99e5ffde34ca1619e7253ed51ec172/bot.rb#L139
Thought that we want to keep that functionality - that's why we've created a lock GH Action 😊

Do you have any thoughts or experienced with locked issues in other communities?

TBH I am okay with locking the closed issues after a bit longer time, like 2 months or something. Opening new issues might be more appreciated than digging deep into old, already closed conversation, wdyt? 🤔

According to the source code of an existing bot - yes, it does. Here you can find an example of locked issue via the existing bot:

https://github.com/fastlane/fastlane/issues/15747


Hide endpoints based on yaml/spec

Hi,
I want to add some attribute to my yaml spec for example x-hide : true/false so that the swagger-ui will know to not show those endpoints.
i can't remove them completely from the yaml because im using swagger-node / swagger-express-mw so it's define the express mw based on this yaml, so if i remove them i can't use them at all.
i want them to be reachable but just not presented on the ui (because documentaion isn't ready yet / because they are mostly internally APIs that doesn't interest for the API users).
is there any way to do it?
maybe someone can help me to the best way to do it if there isn't out of the box?
I posted this issue in swagger-ui here - https://github.com/swagger-api/swagger-ui/issues/1743
but @fehguy told me to post it here for implementing something similar to x-inflector-hidden from swagger-inflector
Thanks.

+1

+1

what happened to this?

I also want this feature but I am not using any swagger-library like inflector or any other thing. I am creating my document by writing all the specification manually. So if anyone finds a solution please do tell. I am writing my document in OAS 3.0


Monte Carlo

[ ] Loading Screen
[ ] Button size
[ ] Start date is optional?
[ ] Test with other jira instances
[ ] Saving error handling

I keep getting notices from Bitovi in my Github.  If possible please stop including me.

@JasonGoldstein2 , I don't see a way to stop this.  However, you can unfollow all these repos yourself:


Range officer gets white screen on clicking plan date

User has tried:
Clearing cache, trying again
I have tried to reproduce:
Same browser version
Using same data
No dice
Going to try another browser next.

From the RO's chrome console on hitting inspect on the white screen:
@calebissharp this one mean much to ya?

RAN075154 @LisaMoore1

@micheal-w-wells Do you have any more info on this?

Nope just the one single user/RAN.

Going to be a bit tricky to narrow down the issue without being able to reproduce it locally. Info on what the contents of the plan are, what status it's in, and what it looks like in the database could be important.

When your ready next to pick up a task swing by my desk we'll get you whatever data you need from this RAN in prod @calebissharp

@micheal-w-wells Can you send me the results of
select * from plan where agreement_id = ?;

for this RAN?

Not Able to test this one so moving to closed for now.


Catch exceptions on file deleter to prevent against app crashes

Task/Issue URL: https://app.asana.com/0/488551667048375/1207230693471364/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4527  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


Add CLI option for disabling tls verification while connecting to s3.

Introduce a new CLI option for the kopia command.
"kopia repistory connect s3 --bucket=<bucket name> --disable-tls-verification".
This new option disables tls verification.
Testing:

Manual tests for connecting to an s3 bucket worked. Snapshot creates, snapshot list, snapshot content commands worked.
Updated unit tests.

 % kopia repository connect s3 --bucket=onkar-kopia-s3-bucket --disable-tls-verification
Enter password to open repository:

Connected to repository.

NOTICE: Kopia will check for updates on GitHub every 7 days, starting 24 hours after first use.
To disable this behavior, set environment variable KOPIA_CHECK_FOR_UPDATES=false
Alternatively you can remove the file "/Users/onkarbhat/Library/Application Support/kopia/repository.config.update-info.json".

% kopia snapshot list
onkarbhat@onkars-mbp:/Users/onkarbhat/kasten-workspace/kopia/kopia/kopia-test-dir
  2020-03-18 13:46:27 PDT k348ab6160c6b64d539c7499109802db5 284 B drwxr-xr-x files:3 dirs:1 (latest-4)
  + 1 identical snapshots until 2020-03-18 13:46:33 PDT
  2020-03-18 13:47:23 PDT k1ed9908f6e20c610f6ed24602ce8dda0 320 B drwxr-xr-x files:4 dirs:1 (latest-2)
  2020-03-18 13:50:06 PDT k385c308ea8023bb5e30569c6dd4a5b49 320 B drwxr-xr-x files:4 dirs:2 (latest-1,annual-1,monthly-1,weekly-1,daily-1,hourly-1)

% kopia snapshot create kopia-test-dir
Snapshotting onkarbhat@onkars-mbp:/Users/onkarbhat/kasten-workspace/kopia/kopia/kopia-test-dir ...
 * 0 hashing, 0 hashed (0 B), 4 cached (320 B), 2 uploaded (4.3 KB) 100.0%
Created snapshot with root k385c308ea8023bb5e30569c6dd4a5b49 and ID 10931ab1e0dd605bf95fed667aafdcba in 0s

How did you validate against places with incorrect certificates? I would validate connections at least (with and without the flag) against some of the servers listed on https://badssl.com/.

@ntolia - I updated the PR with tests for getCustomTransport(). This function is defined in s3_storage.go and used in that file too in New().
I added a unit test called TestCustomTransportNoSSLVerify to verify the behavior of InsecureSkipVerify .
I couldn't think of a way to making the existing minio based tests to test InsecureSkipVerify . If I set the Endpoint to one of the bad ssl links then multiple things will fail  for example createBucket that sets up the test. Even if I use the proper URL for createBucket, and use the bad SSL for testStorage(), then https://github.com/kastenhq/kopia/blob/becf08af8a41f87101c269a19319acf04f55d77f/repo/blob/s3/s3_storage_test.go#L217 will fail at https://github.com/kastenhq/kopia/blob/becf08af8a41f87101c269a19319acf04f55d77f/repo/blob/s3/s3_storage.go#L236  because NewCredentials tries to validate the URL.

@onkarbhat Totally get it about the failure but the failure error message should be different. Without disable-tls-verification, it should be a TLS issue and with, it should be a credentials issue. That should help this to not regress.

Addressed review comments.

One of the bad SSL URLs used in the test didn't meet the test's expectations. So the test failed.
--- FAIL: TestCustomTransportNoSSLVerify (0.47s)
    s3_storage_test.go:279: expected a TLS issue, but none found for url:https://incomplete-chain.badssl.com/

If you open this URL in a browser , you will see this message:
The certificate chain sent by this site is missing an intermediate certificate. This will cause a certificate error unless the browser already has the intermediate certificate in a cache or implements AIA fetching.

So there couple of possibilities where accessing this URL will not cause a TLS issue on the client side. So I am removing this URL from the list of URLs being tested in this PR.

@vkamra @ntolia  - I see this error:
The base branch restricts merging to authorized users

Maybe I have to be added as a contributor ?

@onkarbhat Don't worry about merging here. Just open this PR upstream.

@julio-lopez - I did squash all commits before opening the PR upstream. When I addressed Jarek's comments, it resulted in 2 more commits. This is why total number of commits in the upstream PR is 3. I can squash them too in the upstream PR if that is preferable.

And no need to update the upstream PR. The comment above was more of a guideline


add titlecase to build-constraints.yaml

Add titlecase to list of packages I maintain.

Please make titlecase buildable against the latest base.
base-<IP_ADDRESS> is out of bounds for:

[ ] titlecase-<IP_ADDRESS> (>=4.7 && < 4.9). Peter Simons<EMAIL_ADDRESS>@peti. @nkaretnikov

http://hackage.haskell.org/package/titlecase-<IP_ADDRESS> should compile fine with GHC 7.10.x and 8.0.x.


Removed the total count mode when selecting products during order creation in the administration.

Context:
The API response for fetching products during order creation in the admin panel is inefficient, especially when dealing with many products in the database.
Actual Behaviour:
The API response for fetching products during order creation in the admin panel takes too much time when there are many products.
Expected Behaviour:
The expected behaviour is for the response to be fast and optimised.
Reason:
The response time is significantly delayed due to the inclusion of the total count mode, resulting in an overly long and slow response. The total count mode is unnecessary in this scenario. By removing it, we aim to improve the API's performance, ensuring a quicker and smoother experience when selecting products during order creation.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-40175
[created from NEXT-40175, comment 530674]


[BUG] ClientContext.IsAppOnly() might fail when authenticated with ClientCredentials

Reporting an Issue or Missing Feature
There's an issue when you add ClientContext.IsAppOnly() and are using ClientCredentials. It seems to randomly throw an uncaught 403 and crash.
Expected behavior
When calling .IsAppOnly() it should return true or false, not throw (at least not if it is able to fetch the Access Token!)
Actual behavior
When debugging it, I noticed it doesn't happen on first execution of the handler for extracting the AccessToken, but rather on one of the subsequent ones. It's not even actually executing a real query (it's a dummy) but that still fails somehow.
Steps to reproduce behavior

Connect-PnPOnline with ClientCredentials
Call .IsAppOnly() in the commandlet's code
Observe

What is the version of the Cmdlet module you are running?
Latest dev (f3b8aeffdccc168355d8335ef17d884fd20235b1)
Which operating system/environment are you running PnP PowerShell on?

[X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Next steps
I'll have a fix proposed in a minute.

Ah, sorry - this is actually in the wrong repository, belongs under PnP.Framework. Sorry 😅

https://github.com/pnp/pnpframework/issues/1078


Anyone been able to switch directories with the fs?

I have tried using both openDirectory and setting the fs.cwd to the corresponding file descriptor for the new directory, but neither seem to be changing the current current directory.

I found a bug in my code.  I have a flag for when the fs is initialized and I didn't set it afterward.  I pushed to your PR and it's passing your test now.


Remove the tuition increase

Make it part of the increased enrollment as a side note (it was controversial)..

reduced this but did not remove it entirely


Stop the composer being re-initialised when customSuggestionPatterns change

customSuggestionPatterns changing was causing the composer to be re-initialised.
This was causing tests in the react-sdk to be flakey as the input happens right after initialisation, and some characters were being lost.
Moving the setting of customSuggestionPatterns to it's own effect.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.50%. Comparing base (270b70e) to head (b2cd216).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   90.14%   89.50%   -0.65%
==========================================
  Files         179       86      -93
  Lines       21627    15623    -6004
  Branches      292        0     -292
==========================================
- Hits        19496    13983    -5513
+ Misses       2128     1640     -488
+ Partials        3        0       -3

Flag
Coverage Δ

uitests
?

uitests-ios
?

unittests
89.50% <ø> (+0.26%)
:arrow_up:

unittests-ios
?

unittests-react
?

unittests-rust
89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Markdown support: Nested lists

Is your feature request related to a problem? Please describe.
Markdown documents often include lists, and sometimes nested lists.
It would be nice if the editor allowed creating/editing/deleting nested lists.
Describe the solution you'd like
The ability to create and edit a nested lists.
It would be nice to have a convenient way to switch between nesting levels.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

closing because duplicate of https://github.com/accordproject/markdown-editor/issues/195


Some jobs don't show in job history

Job history for some reason omits recent jobs from history list.

I think we may have a problem with the groom job pruning jobs it shouldn't big. Do you happen to have a log in C:\ProgramData\UniversalAutomation\logs?

logs.zip
Here is a copy of several days worth of logs with a screen shot of what i see in the jobs screen

Just kinda watching this for a few day, looks like its cleaning up jobs every hour instead of based on the number of jobs to keep.

Hey @pshellguruwannabe,
Just a heads up that I haven't been able to reproduce this myself but I've added more logging into the 1.3 version that we just released. I was hoping that you could do me a favor and upgrade to that and grab the logs once again for me to review.
Thanks so much for your help.

Hey @pshellguruwannabe,
Just a heads up that I haven't been able to reproduce this myself but I've added more logging into the 1.3 version that we just released. I was hoping that you could do me a favor and upgrade to that and grab the logs once again for me to review.
Thanks so much for your help.

Don't mind at all.  I don't see the upgrade yet, but when it pops up, i'll run in and put some logs out later.
Thanks

Here is a log for today.  It's still deleting all jobs hourly.  I have my job history set to 50.
I think i see what is going on.  I have jobs dated on Apr. 6 still showing up in history for some reason.  looks like it might be seeing those, and that is where it's getting the 50 jobs from, but it's deleting the most current jobs instead of the oldest.
log20200416.txt

@pshellguruwannabe - That's exactly what was happening. Thanks for the help! I've just committed a fix and this will be in v1.3.1


space between target and colon

Hi,
If the target has a space before the colon the outline is not detected.
This works:
all:
  .......
install:
  .......
clean:
  .......

This does not:
all :
  .......
install :
  .......
clean :
  .......

@brccabral Thanks for your feedback! It should be fixed with the released 0.2.0.


data should be function

Version
1.0.0-beta.20
Reproduction link
https://github.com/vuejs/vue-test-utils/blob/1ee03ac2d57eccd913027ecd51ac5777eeac5c84/test/specs/mounting-options/localVue.spec.js#L20
Steps to reproduce
Open this:
https://github.com/vuejs/vue-test-utils/blob/1ee03ac2d57eccd913027ecd51ac5777eeac5c84/test/specs/mounting-options/localVue.spec.js#L20
 data: { test: '' }

should be written as
data: () => ({ test: '' })

What is expected?
data: () => ({ test: '' })
What is actually happening?
data: { test: '' }

https://vuejs.org/v2/guide/components.html#data-Must-Be-a-Function

Would you like to open a PR to make the change?

Does it have to be a function?
https://vuejs.org/v2/examples/
new Vue({
  el: '#editor',
  data: {
    input: '# hello'
  },
  computed: {
    compiledMarkdown: function () {
      return marked(this.input, { sanitize: true })
    }
  },
  methods: {
    update: _.debounce(function (e) {
      this.input = e.target.value
    }, 300)
  }
})

It doesn't have to be, no. The test works correctly, although it will log a
warning in the latest vue version
On Wed, 4 Jul 2018, 12:54 Mardoxx<EMAIL_ADDRESS>wrote:

Does it have to be a function?
https://vuejs.org/v2/examples/
new Vue({
el: '#editor',
data: {
input: '# hello'
},
computed: {
compiledMarkdown: function () {
return marked(this.input, { sanitize: true })
}
},
methods: {
update: _.debounce(function (e) {
this.input = e.target.value
}, 300)
}
})
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-test-utils/issues/797#issuecomment-402456671,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMlbW7AcLdpxHXHH5h0PBF44EHXfB0TXks5uDKzqgaJpZM4VBBS5
.


Release version 4.7.0

This releases the change in https://github.com/alphagov/govuk_schemas/pull/90.
Required to allow us to upgrade json-schema in Publishing API: https://github.com/alphagov/publishing-api/pull/2507/files

Depends on https://github.com/alphagov/govuk_schemas/pull/91.

Did you choose a minor update to mirror that the dependency had a minor update?

It was mostly because we're not enforcing the upgrade of json-schema, as the versioning will still permit older versions of the gem to continue to be used, so there aren't any breaking changes.


Refactor to match rest of the gift cards flow

I want to merge this change because... it refactors gift cards settings code

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

Task linked: SALEOR-3908 Add Gift Card settings view


Class name of TypeParameter

@ftomassetti: While you're in refactoring mode, I'd like to bring up a naming issue I've seen in the SymbolSolver codebase: Type parameters.
Sometimes they are calles TypeParameter, sometimes just parameter, sometimes TypeVariable and I'm not totally sure but maybe I've also seen some code calling them actual and formal parameters.
I think we should consistently stick to one path and call it TypeParameter and TypeArgument or call it FormalTypeParameter and ActualTypeParameter.
I've been working with Clang a lot over the last three years and they call it parameter and argument and I think the Javaparser also uses this convention. What do you think?

Yes, this is a very good point. I get confused myself.
Looking at JLS 4.4:

A type variable is an unqualified identifier used as a type in class, interface, method, and constructor bodies.

A type variable is introduced by the declaration of a type parameter of a generic class, interface, method, or constructor (§8.1.2, §9.1.2, §8.4.4, §8.8.4).

Applying these to classes we could have:

me.tomassetti.symbolsolver.model.declarations.TypeParameterDeclaration (all these things are called declaration)
me.tomassetti.symbolsolver.model.usages.typesystem.TypeVariable (without the Type at the end because it would be too long)

Does it make sense?
If yes, we could start renaming these classes and then look at the specific names used fields and methods, around the code base.
What do you think?

So a TypeVariable is a TypeParameterUsage?
And what about TypeArguments? In my understanding a class declaration may have type parameters. But a type usage of that type has type arguments.
The same should be true for methods. A method has parameters but the method usage has arguments.
I'd strongly suggest that we use the terminology like that. Otherwise it's getting confusing quickly ;)

Ok, so you mean using parameter for the formal parameter (the declaration) and argument for the actual values (the usage). Ok, we could do that.

Exactly. Here some examples of how I'm understanding what we are planning to do:
public class Foo<T> {		// T is a type parameter
	public void bar1(int i) {	// i is parameter
		int k = i;			// i is an argument
	}

	private T t;			// T is a type parameter usage
}

public class Bar<T2>{		// T2 is a type parameter
	private Foo<T2> f;		// T2 is a type parameter usage used as a type argument
}

There is this interface:
public interface TypeParametrizable {

    List<TypeParameterDeclaration> getTypeParameters();

}

so if I have a class declaration I can call getTypeParameters and I get for example [T]
in private T t; T would be a TypeVariable (I am using the JLS terminology here.

MethodLikeDeclaration (an ancestor for ConstructorDeclaration and MethodDeclaration) has the following methods:
    int getNoParams();

    ParameterDeclaration getParam(int i);

    /**
     * The last parameter can be variadic and sometimes it needs to be handled in a special way.
     */
    default ParameterDeclaration getLastParam() {
        if (getNoParams() == 0) {
            throw new UnsupportedOperationException("This method has no typeParametersValues, therefore it has no a last parameter");
        }
        return getParam(getNoParams() - 1);
    }

Does it make sense?

However Context has these methods:
SymbolReference<MethodDeclaration> solveMethod(String name, List<Type> argumentsTypes, TypeSolver typeSolver);
Optional<MethodUsage> solveMethodAsUsage(String name, List<Type> argumentsTypes, TypeSolver typeSolver)

Here we use the term argumentsTypes because they would be the types of the actual values passed

That sounds great to me, I just have one or two small suggestion to make:

We should add a comment to the TypeVariable class that explains what that is (for people like me who only know the argument/parameter distinction)
We should use the term parameter in the context of a MethodDeclaration (so change the code in the example one comment above this one), and use the term argument when we refer to some MethodUsage. I think that would make sense :)

The first point is addressed. About the second one I renamed parametersTypes to argumentTypes in a bunch of places. Did I miss anything?

Just posted a comment on that pull request.
I think I just realized some of my earlier confusion: I thought a MethodUsage would be something like a call or a reference to a method. But in fact a MethodUsage is just a MethodDeclaration with TypeArguments replacing the TypeParameters! So I have to revert what I said before: Don't use the term "arguments" in the context of a MethodUsage. Sorry for the confusion.

Oh, and you renamed TypeUsage to Type (so it does not feel like a strange third thing (next to Declaration and Type) anymore) and TypeParameterUsage to TypeVariable. Awesome!, that's what I had in mind, too :)

Thanks for your help on this one!
Closed by #92 but I expect we will have to fix some names here and there. Please feel free to discuss naming because poor names do not help in this already complex project.


Color Statusbar

I’m using the android app, and I’m using themes, however if I open with the app, the statusbar keeps using a blue color. If I open it with chrome, it use the color of the theme. Is it possible to change it, so we can use the colors of themes?
In the app:

In Chrome:

Duplicates: https://github.com/home-assistant/home-assistant-android/issues/272


miga files -i should indicate the result

The miga files utility lists the files with json index when -i is used. It would be more useful if it listed the result name (instead or in addition).

This was implemented in the MiGA::Cli refactoring


wakanda README.md

this is my 1st pr

This file is already fine please make some good PR's this file already had good comments there is no use of doing "Whatsaap" to "WA" I went through your profile and i saw you joined this month which means you are here for #Hacktoberfest for that Shitty T-SHIRT please make some good contributions it's a pain in the ass for the maintainers


Fix Lo to Hi issue with total ratings

Fix sort by issue when doing Ratings -> Low to High. If the ratings were equals, the tie breaker would be the total # reviews (most would show up first). Now it should be the opposite (most total # reviews should show last).

Low to High sort order appears to be more in line with what's expected.
:+1:

Pulled branch
reviewed code
tested

most total # reviews should show last
L-H is the reverse order of H-L/MP :+1:

:+1:

@J-Fid - what do you mean by "when a change is made"? - thanks,

@rkenyon1969 Reviewing a listing causing its rating to change.  Michael just put in a fix for the the drop down bar, and I'll discuss it with him when he comes back from lunch.


Cannot find module

When calling my lambda i have :
    "errorMessage": "Cannot find module '/var/task/handler'",     "errorType": "Error",     "stackTrace": [         "Function.Module._load (module.js:276:25)",         "Module.require (module.js:353:17)",         "require (internal/module.js:12:17)"     ] }

The module is not found, so make sure your paths are correct and always use relative paths.
Besides that, you can disable minification, and go through stack trace debugging.

@goncaloneves
I have learned nothing new with "minify false"
Unable to import module 'handler': Error     at Function.Module._resolveFilename (module.js:325:15)     at Function.Module._load (module.js:276:25)     at Module.require (module.js:353:17)     at require (internal/module.js:12:17)
I think lambda doesn't find my handle.js
When i download the deployment package of my lambda in AWS console, i get zip with files achitecture like _optimiez/'my-labda-name/handler.js'
When i don't optimize i get my-labda-name/handler.js'
with all files.
Why does the plugin add the _optimize directory?

The prefix folder (_optimize) is where the plugin bundles the files together and then changes the handler path in the package object from SLS to zip and deploy the prefix instead. That's why you need relative paths inside your code. This is invisible to the user, so just follow SLS instructions and then follow the plugin instructions and you should be fine.
GL on that

Problem solved!
I had to make first a full deploy with sls deploy.
Instead of only  doing sls deploy function -f fct-name
Thx a lot.

Cool 👌 Keep it up.

I'm still getting this issue:
Unable to import module '_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler': Error
at /var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:745
at Function._load (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1899:18)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at s (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:554)
at /var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:745
at Object.instrument (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1909:5)
at Raven.install (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1370:18)
at installRaven (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:2956:4)
at Function.handler (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:3141:4)
at Object.1.../../../utils/logger (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:2:1613)
at s (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:694)
at e (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:865)
at /var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:894
at a (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:150)
at Object.<anonymous> (/var/task/_optimize/tsz-serverless-api-dev-jwt-authorizer/functions/authorizers/jwt/handler.js:1:385)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)

Any tips? I added the plugin to an existing serverless deployment.

any update?


useKeyboard property does not work

In version 3.0.26 useKeyboard options works.
In most recent versions (tried .34 and .37) it does not work.

Fix in v3.0.38.
Thanks .


Next Link on Photo Albums Block on Profile Page Doesn't Work

When you add the photo albums block to the profile page, the 'next' button just reloads the page. The pagination links work if the block is added to the profile photos page or the photos home page, but not when added to the profile main page.
The block is also not centered on the profile main page like it is on other pages.

How you've added photo albums block to homepage ? there is no such bock by default.

Not homepage, Profile page. I have a fresh install with no modifications. It's inserted with the code on line 194 of /modules/boonex/photos/install/sql/install.sql
('profile', '1140px', 'Photo Albums', '_[db_prefix]_albums', 0, 0, 'PHP', 'return BxDolService::call(''photos'', ''get_profile_albums_block'', array($this->oProfileGen->_iProfileID), ''Search'');', 1, 28.1, 'non,memb', 0),

Thank you for pointing this out, for some reason for me this block isn't navigating to the next page at all!


ZSO7300 ProductType and  ProductID is wrong

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
The device driver in https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/devices/0x0234/zso7300.json has the wrong productType and productId.
What do you observe?
When adding the device to Z-Wave it is not found and added as a generic switch.
What did you expect to happen?
I expected it to be reported as a Logic Group ZSO7300 Switch
The device is just acquired, and I only have 1, so I don't know if the current ProductType and ProductID worker for older version. I have added the correct Type and ID below. I did manually edit the file and with these ID's all is working as expected
Device information
Manufacturer:  Logic Group (0x0234)
Model name: ZSO7300
ProductType should be: 0x0004 (is currently 0x0003)
ProductID should be 0x002a (is currently 0x012a)
How are you using node-zwave-js?

[X] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[ ] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version: 8.3.2
node-zwave-js branch:
zwavejs2mqtt branch:
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
No, it never worked anywhere
If yes, where did it work?
No response
Attach Driver Logfile
There is no need for a log file. If the ProductType and ProductID are changed to what I wrote above ot works. I have attached a working zso7300.json file.
zso7300.json.zip

It's possible that there are two revisions of the device with different IDs. We generally don't remove ids unless they are proven wrong.
Could you provide a pull request adding your ids to the existing file?

Yes, there might be more than 1 revision. I only have 1 device and that is brand new. I have created a PR, where I added the ProductType and ProductID. Thanks


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/172 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit f0fd8c7:
Pending

Docs Build status updates of commit f0fd8c7:
Processing

Docs Build status updates of commit f0fd8c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


braft::rtb::remove_group

remove_group has not implement???

it's a mistake, we are dealing with it now, thanks

fixed by https://github.com/brpc/braft/commit/ca575514f410cbf7916192696918c9eb03279aa4


Replace parceljs with webpack

Parceljs is ok but sometimes it bugs.
Let's gieve it a try to replace it with webpack.

Questions :

[ ] module-aliases still needed ?


Improve cacheability of Docker layers and add ca-certs to scratch image

@marcofranssen Nice work Marco! I This sounds great! It would be nice to add here some benchmarks in terms of before/after build times and resulting image sizes.

Don't really have time to do that. But if you understand docker image layering you will understand there are fewer layers to rebuild as the ones that are most likely to change are the last layers, therefore allowing to reuse the layers before that are most likely not to change.


Question about files

Thanks for sharing, but I would like to know how to get these two files ( vecs.npy and vocab.npy). Regards,

You can refer to #1


clean up

This pull request removes unneeded files and folders.

Fixes: #13
@pedrohserrano @Alialsaeedi1 Can you please check the changes introduced in this pull request? Please let me know if you need help.


Error during SuperTux CPack packaging step since 20230803.1

Description
I noticed that the CPack step in our build script started failing after updating to the latest runner version.
You can find our build script here: https://github.com/SuperTux/supertux/blob/master/.github/workflows/macos.yml
The script that gets called is this: https://github.com/SuperTux/supertux/blob/master/.ci_scripts/package.sh
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[X] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
20230803.1
https://github.com/SuperTux/supertux/actions/runs/5840469967/job/15839754031
Is it regression?
20230709.1
https://github.com/SuperTux/supertux/actions/runs/5803629706/job/15732010068
Expected behavior
The packaging passes
Actual behavior
This is the error that I'm getting during the "package" step for SuperTux:
CPack: Create package using Bundle
CPack: Install projects
CPack: - Run preinstall target for: SUPERTUX
CPack: - Install project: SUPERTUX []
CMake Error at /usr/local/Cellar/cmake/3.27.1/share/cmake/Modules/BundleUtilities.cmake:458 (message):
  otool -l failed: 1

  error:
  /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool-classic:
  can't open file: @loader_path/../../../../opt/glib/lib/libglib-2.0.0.dylib
  (No such file or directory)

Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.27.1/share/cmake/Modules/BundleUtilities.cmake:527 (get_item_rpaths)
  /usr/local/Cellar/cmake/3.27.1/share/cmake/Modules/BundleUtilities.cmake:649 (set_bundle_key_values)
  /usr/local/Cellar/cmake/3.27.1/share/cmake/Modules/BundleUtilities.cmake:933 (get_bundle_keys)
  /Users/runner/work/supertux/supertux/build/cmake_install.cmake:123 (fixup_bundle)

CPack Error: Error when generating package: SuperTux
usage: mv [-f | -i | -n] [-v] source target
       mv [-f | -i | -n] [-v] source ... directory
Error: Process completed with exit code 64.

Repro steps

Run the macos workflow for SuperTux
See it fail during the package step.

Hello @tobbi.
Thanks for reporting, we will investigate the issue

Hey @tobbi. It's related with harfbuzz package. There was a major release recently and it seems to break your workflow. I succeeded fixing your workflow by rolling that update back: https://github.com/vpolikarpov-akvelon/supertux/actions/runs/5869174222

Thank you so much! Could we somehow raise this to the homebrew or harfbuzz guys?

@behdad Do you have any idea why this happens?

Where can I see the harfbuzz-related error. I couldn't find.
It's this a cmake issue or compile issue? I think we made some changes to our cmake setup. cc @khaledhosny

I feel like it might be a cmake or install issue.

@behdad, there is no harfbuzz error, but issue emerged as a result of the release of harfbuzz version 8. You can mitigate it by rolling it back to 7.3.

@tobbi, I think it would be more productive if you escalate this to harfbuzz repo yourself as you definitely have a lot more experience with this software then me.

@tobbi, I think it would be more productive if you escalate this to harfbuzz repo yourself as you definitely have a lot more experience with this software then me.

I'm a harfbuzz developer. I'm trying to figure out what's up here.

I don't know what I can do with the little information available here.

I don't know what I can do with the little information available here.

What more information do you need?

Hey @behdad. We would greatly appreciate your assistance in helping us resolve this issue. If you have any insights or suggestions, or if there are specific details you require from our end to diagnose the problem more effectively, please do not hesitate to let us know. Your expertise in Harfbuzz would be invaluable in getting to the bottom of this issue. Thanks.

Technically, git bisect could be used to find the offending commit. I just don't know how to best use it in the context of this issue

Local build works fine. I'm currently running a git bisect on the build machines with some homebrew trickery.

@vpolikarpov-akvelon Do you know if the download speed gets throttled after running a build multiple times?

What kind of download you are talking about?

Unfortunately, I don't know. I hope it will gone soon.

Hey @behdad. We would greatly appreciate your assistance in helping us resolve this issue. If you have any insights or suggestions, or if there are specific details you require from our end to diagnose the problem more effectively, please do not hesitate to let us know. Your expertise in Harfbuzz would be invaluable in getting to the bottom of this issue. Thanks.

I'm out of my depth here. The error I see:
  error:
  /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool-classic:
  can't open file: @loader_path/../../../../opt/glib/lib/libglib-2.0.0.dylib
  (No such file or directory)

is not HarfBuzz-specific per se. Just happens that HB links to glib. But that hasn't changed in a long time. Other than that I have no clue what's going on. Sorry.

https://github.com/SuperTux/supertux/pull/2601/files#diff-7b74d73de878e0e53f6768bbf3a3d4b50c3c6f1f16f9b64518690028b8206b1cR53-R54
I found out that removing the preinstalled version of harfbuzz from the build machines and then reinstalling them with --build-from-source will work.
If it also works without --build-from-source, we can be certain this is an issue with the way harfbuzz is preinstalled on the build machines (as opposed to an issue with the way brew installs it)

Alright! Apparently, it doesn't work without --build-from-source. I'm assuming the issue is therefore with the way homebrew installed harfbuzz.
@behdad Sorry for roping you in when this wasn't a harfbuzz issue after all.

@behdad Sorry for roping you in when this wasn't a harfbuzz issue after all.

No problem. I'm glad this is being figured out.

https://github.com/orgs/Homebrew/discussions/4735 for the homebrew discussion

I'm closing this issue as it doesn't seem to be caused by runner image. Feel free to reach out if you have other questions or need extra support. Thank you.

FYI: this should be addressed. See Homebrew/homebrew-core#140930 for more information.


Refactor type files

Refactor type files by separating and renaming various definitions.

Hi Reviewers,
Upon further inspection, there's more work needed for the const enum migration. I'll go ahead and merged the common file renaming commits first.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2425f34) 77.63% compared to head (5c0de39) 77.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   77.63%   77.63%
=======================================
  Files           4        4
  Lines         161      161
  Branches       21       21
=======================================
  Hits          125      125
  Misses         36       36

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Incorrect syntax highliting for C/C++

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:41:20.664Z)
OS Version: Linux x64 4.4.0-57-generic
Extensions:

Extension
Author
Version

output-colorizer
IBM
0.0.9

tortoise-svn
fantasytyx
0.1.1

cpptools
ms-vscode
0.9.3

vscode-icons
robertohuertasm
4.3.0

Color theme: Dark(Visual Studio)

Visual Studio Code does not generate .browse.VS.db in .vscode
Steps to Reproduce:

Open directory with Visual Studio Code
Open C or C++ file
Everything is in blue.

@Rn86 This issue should be filed on the Microsoft C/C++ extensions github page at https://github.com/Microsoft/vscode-cpptools .

They responded with a message that vscode-cpptool does not impact colorization.
I tested maybe a dozen color themes and in all cases colorization was terrible. Ether everything is in same color or colors make no sense at all for example same function calls right after each other were in different colors.
https://github.com/Microsoft/vscode-cpptools/issues/434#issuecomment-270899566

Please add the code snippet (as small as possible) that shows the problem. Additionally a screenshot...

I can not include any code, because its confidential. But it seems i tracked down where all that colorization failures are coming from.
If there is macro defined at the top like this:
#define MY_MACRO_1()
#define MY_MACRO_2()
#define MY_MACRO_3(foo)
((foo) ?
MY_MACRO_1() :
MY_MACRO_2())
everything bellow is in blue color.

#define MY_MACRO_1()
#define MY_MACRO_2()
#define MY_MACRO_3(foo) \
	((foo) ? \
		MY_MACRO_1() :\
		MY_MACRO_2())

Changing these kind of macro blocks to:
#define MY_MACRO_1()
#define MY_MACRO_2()
#define MY_MACRO_3(foo) ((foo) ? MY_MACRO_1() : MY_MACRO_2())

fixes the problem.

duplicate of https://github.com/atom/language-c/issues/160


improve position of the information icon, always right aligned?

See attachment:

I believe it would be better if it would be always on the right? As of now, I believe you will always see it in the right due to long texts, but for shorter texts it might be right at the end of such texts.

Was implemented by @vaqueraoscar0, if you find the time can you @AndersonCeci, @Kledis98 please test this and close this?

Was implemented by @vaqueraoscar0, if you find the time can you @AndersonCeci, @Kledis98 please test this and close this?

Looks good to me

@AndersonCeci please check this again and close this issue if all is well.


Test

Please provide us with the following information:

OS?

Windows 7

Versions.

angular-cli: 1.0.0-beta.19-3
node: 4.5.0
os: win32 x64

Repro steps.

Hi,
how can I run scripts from angular-cli.json when I using 'ng test'?
Thanks
Yair
The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

@yairtawil  You can ask the same in the below chat room to get a quick response.
https://gitter.im/angular/angular

Dupe of https://github.com/angular/angular-cli/issues/2897. It's broken at the moment.

@yairtawil This solved my issue: https://github.com/angular/angular-cli/pull/3120
In order to solve this locally, you can add the relevant files in the karma.conf.js:
...
files: [
      { pattern: './src/test.ts', watched: false },
      { pattern: './node_modules/cesium/Build/Cesium/*.js'}
],
...


Use bool type from stdbool.h

Defining bool ourselves can cause all sorts of problems. For example, if the implementation of the libraries we're using import another another definition of bool, HVM will not compile.
Or if a user tries to write FFI for HVM and includes a definition of bool.
One option was to #define bool _Bool, which is what stdbool does, but including the standard library is the more standard way of doing it.
Also, hvm.cuh tried to redefine bool in c++ which would cause an error.
Another effect is that we can now compile hvm with C23

Perf run for 3e26bc2:
compiled
========

file            runtime         main            (local)
==============================================================
sort_bitonic    c                        2.81s           3.15s
                cuda                     0.15s           0.15s
--------------------------------------------------------------
sum_rec         c                        1.48s           1.44s
                cuda                     0.06s           0.06s
--------------------------------------------------------------
sum_tree        c                        0.13s           0.13s
                cuda                     0.02s           0.02s
--------------------------------------------------------------
tuples          c                        4.50s           4.35s
                cuda                   timeout         timeout
--------------------------------------------------------------

interpreted
===========

file            runtime         main            (local)
==============================================================
sort_bitonic    c                        3.35s           3.72s
                cuda                     0.15s           0.15s
                rust                   timeout         timeout
--------------------------------------------------------------
sum_rec         c                        1.75s           1.75s
                cuda                     0.06s           0.06s
                rust                    14.08s          14.03s
--------------------------------------------------------------
sum_tree        c                        0.22s           0.18s
                cuda                     0.02s           0.02s
                rust                     0.84s           0.84s
--------------------------------------------------------------
tuples          c                        5.34s           5.41s
                cuda                   timeout         timeout
                rust                     3.83s           3.60s
--------------------------------------------------------------

Tested  this on my machine and worked
Macbook Pro M3. I was having trouble compiling HVM, now it is working smoothly