Declare requirement for zip extension

Testing file changes were not found.
I couldn't find a front-end developer to review this! Ask around the office.
Paging @juanmrad to review the back-end work in this pull request!
Paging @awesomeousPrime to review the testing work in this pull request!

@juanmrad I'm going to merge this because I'm getting blocked all over the place. If you have any changes, please let me know and I'll do a follow-up PR.


Can product the TypeScript instance default value accord c# entity empty constructor?

Yester day, I search .net export typescript on github and I found an very very new project.
(To my surprise,  i cannot find Nswag in the project list).
I download the latest program and apply an trial license,
It  produce aboutn 12,000 lines TypeScript code accord my project.
I don't modify any code  and only tell this program where is my assemblies directory.
Oh, that's is not important.

So, my question is,
Can NSwag product the typescript code initial code accord the c# empty constructor or property initial value ?
And If can, how should i do ?

I think yes, nswag will generate the default values in the ctor also for typescript - but probably it's best if you quickly just try out.


modded README

Awesome work Jaison! You have a clear understanding of HTML  mark up and CSS styling. Your code is well organized and efficient!

This looks great! Consider using unordered lists as well so you can minimize the amount of divs you are using

Thanks so much! I'll try out uls


File handles are not closed if an exception occurs (Mono)

Godot version:
3.1.1 (Mono)
OS/device including version:
Windows 10
Issue description:
Files opened with the File class are not closed if an exception occurs and the editor remains open. If you open a file in an exclusive mode (e.g. WriteRead), and an exception occurs later on in your Godot program, the program will exit, but the file will remain locked. It will continue to be locked until the editor is restarted. I think this is Mono only due to it requiring an exception to be thrown. Behaviour may be different on other OS's too.
The issue is exacerbated by #29039, as the failure message when open the file on the next run is generic.
Steps to reproduce:

Open a file using the File in exclusive mode (i.e. File.ModeFlags.WriteRead)
Throw an unhandled exception
Try to open the file externally - it will be locked.

Minimal reproduction project:
Testing-FileExceptionLocking.zip

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

@KoBeWi This no longer happens for me in 3.2.3. Closing.


ERROR: Out of memory: failed to allocate 148684800 bytes on device 0

DIGITS version: 6.0.0
Caffe version: 0.15.14
Caffe flavor: NVIDIA
Install and run digits with docker. Error happened while training image dataset.
ERROR: Out of memory: failed to allocate 148684800 bytes on device 0

Thats mainly a problem with batch size, you have to make lower batch sizes, just use 2 or something like this u can also u accumulate than both values will be multiplied for a total batch size.

Thanks, ZeroCool11000


Poor performance CKEditor large site

We have DNN platform 9.2.2. , a main site with 11 subsites, installed in our test environment.
The main site contains many hundreds of folders and thousands of files. To read an image from this structure with the CKEditor takes about 1 minute. The second time it goes much faster (15 seconds) with Chrome. In both cases it takes 5 seconds to select the file. The subsites are not affected because they contain far fewer folders and files. Previously with the Telerik editor never suffered. Are you familiar with this or do you know a solution to this problem?

Yes this is a known issue. But there are no solutions for this issue.

i think we can close this. Because its a duplicate from #10


EAGLE-100 Add hadoop jmx collector scripts

https://issues.apache.org/jira/browse/EAGLE-100

@qingwen220 Was this PR merged into master in another PR by @yonzhang in https://github.com/apache/incubator-eagle/commit/db2bbf91b30e8cc00adaadb64affb863dd41dc44?


(maint) Fix local_windows transport calling profile

Previous to this commit the local_windows transport would call the powershell
profile if the default value for the 'interpreter' variable was ever used. in
this scenario the default interpreter needs to include PS_ARGS defined in the
powershell transport.
This commit adds PS_ARGS to the default of interpreter

CLA signed by all contributors.

@McdonaldSeanp can you file a bolt ticket for this since it will result in a behavioral change.

https://tickets.puppetlabs.com/browse/BOLT-1358

CLA signed by all contributors.

This change looks good. Is there a reasonable way to test it? I fear that any way to test this very specific case would wind up being too implementation-specific...

I guess we could try to add something like the following to CI. This is how I tested locally.
PS C:\Users\Administrator\bolt> echo $profile
C:\Users\Administrator\Documents\WindowsPowerShell\Microsoft.PowerShell_profile.ps1
PS C:\Users\Administrator\bolt> type $profile
Write-Host 'hi from profile'
PS C:\Users\Administrator\bolt> type .\Boltdir\site-modules\test\tasks\init.ps1
Write-Host 'hi'
PS C:\Users\Administrator\bolt> bundle exec bolt task run test -t localhost
Started on localhost...
Finished on localhost:
  hi from profile
  hi
  {
  }
Successful on 1 node: localhost
Ran on 1 node in 0.77 seconds
PS C:\Users\Administrator\bolt> git branch
* (HEAD detached at origin/master)
  fix_loading_profile_windows_local
  master
PS C:\Users\Administrator\bolt> git checkout fix_loading_profile_windows_local
Previous HEAD position was 7350519b Merge pull request #1012 from nicklewis/BOLT-1341-support-terraform-version-4-statefiles
Switched to branch 'fix_loading_profile_windows_local'
PS C:\Users\Administrator\bolt> bundle exec bolt task run test -t localhost
Started on localhost...
Finished on localhost:
  hi
  {
  }
Successful on 1 node: localhost
Ran on 1 node in 0.58 seconds

@McdonaldSeanp run script also appears to load profiles on windows using local transport  to execute powershell scripts. I assume that is not the expected behavior? The template for that is https://github.com/puppetlabs/bolt/blob/7350519b0a28cf184a237c149cbfc5ee7013681c/lib/bolt/transport/powershell.rb#L94-L114 .
Also, I have been trying to replicate this using the winrm transport. By running something like
if (!(Test-Path -Path $PROFILE.AllUsersCurrentHost))
{ New-Item -Type File -Path $PROFILE.AllUsersCurrentHost -Force }
Set-Content -Path $PROFILE.AllUsersCurrentHost -value "Write-Host 'hi'"

I can test for profile being loaded using local transport based on hi being printed. For example
PS C:\Users\Administrator\bolt\Boltdir> bundle exec bolt script run test.ps1 -t localhost
Started on localhost...
Finished on localhost:
  STDOUT:
    hi
    powershell script
Successful on 1 node: localhost
Ran on 1 node in 0.41 seconds
PS C:\Users\Administrator\bolt\Boltdir> type test.ps1
Write-Host 'powershell script'

But the profile does not seem to be loaded (or at least I cant detect hi) using the winrm transport (with scripts or tasks even when I delete all of PS_ARGS). My guess is that the profile I am setting in that script is not picked up when executing remotely. Do you know of a profile that I could set that would be loaded for any powershell script invocation?

@donoghuc I don't know enough about the winrm transport in bolt to know how it interacts with powershell and how it would react to "Write-host".
My guess at your repro problem in winrm is the output of "write-host" could disappear regardless of whether or not powershell.exe was called with or without -NoProfile. I know there's alot of powershell logic and pipelining in what actually gets called on the host. "write-host" will not propagate any output down any pipelines, it sends the output directly to the console. Since there's not technically a "console" in winrm maybe the output from write-host in your profile just gets eaten.
I would try and see if using something other than "write-host" in the test profile as a test for if the profile was executed will work?
maybe write to a file with https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/out-file?view=powershell-6 in the test profile and then check if that file exists?

Also yes, we do not want to load the profile in run script

Got a clean beaker run locally with
cas@cas-ThinkPad-T460p:~/working_dir/bolt/acceptance$ bundle exec beaker-hostgenerator windows10ent-64bolt%2Cwinrm.-debian9-64ssh.-windows2016-64winrm. > hosts.yaml
cas@cas-ThinkPad-T460p:~/working_dir/bolt/acceptance$ bundle exec beaker init -h hosts.yaml -o config/git/options.rb
cas@cas-ThinkPad-T460p:~/working_dir/bolt/acceptance$ bundle exec beaker provision
cas@cas-ThinkPad-T460p:~/working_dir/bolt/acceptance$ GIT_FORK=McdonaldSeanp/bolt.git GIT_BRANCH=fix_loading_profile_windows_local bundle exec beaker exec -t ./tests

/tests/show/plan_show.rb passed in 35.05 seconds
      Test Suite: tests @ 2019-06-10 17:26:30 -0700

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 581.87 seconds
      Average Test Time: 30.62 seconds
              Attempted: 19
                 Passed: 16
                 Failed: 0
                Errored: 0
                Skipped: 3
                Pending: 0
                  Total: 19

      - Specific Test Case Status -

Failed Tests Cases:
Errored Tests Cases:
Skipped Tests Cases:
  Test Case ./tests/apply_plan_winrm.rb
  Test Case ./tests/command_local.rb
  Test Case ./tests/file_local.rb
Pending Tests Cases:

I gave up on fighting appveyor trying to set a profile that would be loaded. I don't fully understand why $Profile evaluates to null when executing powershell in appveyor. I started investigating writing profile code to the default location for Profile.AllUsersAllHosts but when I ran in to not easily being able to verify that the profile was being loaded I decided to just implement the tests at the acceptance level.
I spent some time trying to force loading profiles when running scripts or tasks over winrm (for example by removing -NoProfile etc from PS_ARGS. It kind of makes me think that something in the winrm library is effectively setting -NoProfile when using the :powershell session shell option (which is good).


Introduce limits on contributions on the platform

We need to put in place limits on all contributions, regardless of whether they're successful or not.
Proposal
In my opinion It's not normal to:

make more than two contributions to a collective in a short period (1 hour)
make more than five contributions to multiple collectives in a short period (1 hour)
make contributions from more than five different payment methods over a long period (1 month)

Alternatively, e can leave this to be configured in the payment processor's (in our case, Stripe's) anti-fraud product. An example ruleset might be

block if number of authorised charges against card is X per hour and/or day
block if number of authorised charges per 'customer' (or email address) is X per hour and/or day
block if number of authorised charges per IP address is X per hour and/or day

I'll take a look at what constitutes 'normal' behaviour for us by looking at payment methods in our DB.
Exclusions
We may need to implement an exclusion for recurring contributions, which are charged separately:

[ ] https://github.com/opencollective/opencollective/issues/4206
[ ] https://github.com/opencollective/opencollective/issues/1916

Specifications:

Add a new validation step when creating orders.
This new step will take into consideration:

The error rate of orders
The payment method creation rate (take into consideration deleted ones)

Throws if looks fishy (parameters to be defined and tuned through env variable)

Should we take into consideration the rate of successful order creation?

Should we take into consideration the rate of successful order creation?

Absolutely 100% yes, this was the thing that costs us thousands of dollars last month.


Fix plot legends in flux_dept_lits_dept_visu_4panels

The issue was that we are using the non default plot style (seaborn-whitegrid) which sets frameon=False for legends.

There is still an issue on subplot 2 the twinx plot and y grid can overlap with the legend. I haven't managed to solve it yet with set_zorder, and I don't want to spend more time on this (particularly since we may endup not including this subplot in the end).
I think we should merge as is, it's already an improvement.


Hitl dashboard - Managing Turk List Backend

Description

Update frontend ui for editing turk list

now there is a tab shows different turk list with different qualification name
a sync button for syncing local and s3 turk list
search box now supports case insensitive input

Added backend apis for accessing/managing turk list:

get_turk_list_by_pipeline

get turk list for the corresponding pipeline from the local mephisto db
input:

pipeline type

output:

a dict containing the turk allowlist, blocklist & softblock list

update_turk_qual_by_tid

update turk list to the corresponding qual in the local mephisto db

input:

turk id
qualification type (string)

output:

a status code indicating if update succeeds

update_local_turk_ls_to_sync

update turk list to be sync on both local methisto db and s3

output:

200 code to indicate update success

Updated droidlet/tools/crowdsourcing/sync_whitelists.py to support the backend api for managing turk lists.

Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[x] Refactor
[x] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[x] I want a thorough review of the implementation.
[ ] I want a high level review.
[ ] I want a deep design review.

Before and After
Demo:

Updating block/allow status

Syncing local and s3 turk lists

Update failed vs succeded behavior

Testing
Manually tested.
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[x] I have added Docstrings and comments to the code.
[x] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

If I'm interpreting the demo correctly, it seems like list membership is mutually exclusive, but it shouldn't be. We want everyone on the allowlist to also be on pilotblock. Likewise, though this decision is more debatable, my opinion is that everyone on the blocklist should also remain on the other two lists. This way we can track everyone who has ever been added and avoid re-adding them. The Mephisto task code already assumes this (it checks for yes allowlist membership AND no blocklist membership).

I updated it to show only 2 status with backend implementation maintains 3 lists:

"Allow" status:

turk in allowlist and blocklist, but not in softblocklist

"Block" status:

turk in allowlist, blocklist, and softblocklist


Fix setting HTTP transport factory for Datastore

This fixes #1138
@successhawk this should fix your issue, any chance you can give it a try?

Coverage increased (+0.006%) to 85.872% when pulling 259fca9067a6a6d72e217c24223b02d3803e36e1 on mziccard:fix-datastore-transport into 64115e4512e8a9bf0d465056d7fef2143b077523 on GoogleCloudPlatform:master.

/cc @lesv

LGTM


Update readme for all examples

Some of readmes are pretty outdated. They will be updated and refactored in this issue.
Other than that, I'm proposing some other changes. Since the examples for same-datatype-search(i.e. text/image search) is very similar and readme in them are highly overlapped, I believe it's a huge waste of time to read all the readmes. So I suggest to do the following:
We choose one example that has most features for one data type(i.e. flower for image search cuz it introduces the idea of container pea), leave a detailed readme for it, and delete other readmes.

I don't have time to work on this recently. Will reopen when continue


[Sketch] openat, fsync, and sync

This is close to being mergeable, but still has the global system call design question as https://github.com/apple/swift-system/pull/33

@milseman @lorentey Do we want this to be called open(_:at:...) or open(_:relativeTo:...). Whatever precedent is set here, should be followed by my fstatat functions

I'd be happy with either option! I like relativeTo:, too.

I much prefer relativeTo: personally as well, as I otherwise would do a double-take in the man page or docs to make sure at means what it means in openat(2).


Re-drawing elements

when trying to re-draw zui's elements that isn't a window element than it would not re-draw
eg:
buttonHandle.redraws = 2;//Does nothing
//But
windowHandleThatContainAboveButton.redraws = 2;//Re-draws now

Is it supposed to work like this?

Yes, redraws is only applicable to window handles as of now.


Add global_position and global_rotation to Node3D

Closes https://github.com/godotengine/godot-proposals/issues/3033
Adds a global_position and global_rotation property to Node3D. These properties already existed for Node2D, so it makes sense to have them for Node3D as well to lessen the differences between 2D and 3D.
Here's the project that I used for testing that they work properly:
testing_node3d_global_properties.zip

This could probably be cherry-picked/backported to 3.x since it doesn't break compatibility.

Also,global_scale?

Also,global_scale?

I looked into adding global_scale originally, but I couldn't figure out how it works when testing it in 2D, it seemed to have very odd behavior and wasn't very useful.

Needs a rebase, but otherwise @reduz approves

Thanks!


Allow the receive to log a short message if an event is received.

Also emit timing metrics.
Signed-off-by: Heiko W. Rupp<EMAIL_ADDRESS>

I am merging this, so that we can use it for debugging purposes. We can still change the way the logging is enabled later (or completely remove that again).


Change log for v3.0 as an md file

Based on the work I've done on my OpenAPI Specification Visual Documentation, I think I could manage to generate a md file containing a change log from version 2.0 (with links to the specifications).
Would that be of interest? If yes where could I put that file in the repo?

Thanks @arno-di-loreto - due to the length of time this has been open, I'm going to close it. I assume the release notes have been sufficient to communicate changes. Your OpenAPI Map is still a tremendous piece of work, and I hope to see a version for OAS 3.1


Font weight displayed wrong

Since the last update my editor font that used to be bold-ish looks like a medium or light font. I am using the font called 'Hack' from the braver/fonts package.
When I select a different theme, the font goes back to normal but when using your material UI, it's rather thin again.
Edit: removed typo

Same problem here, after the new update rendering of fonts is strange.

Fonts are antialiased by default. If you wish to not use antialiasing open your personal stylesheets located in ~/.atom/styles.less and paste the following:
:root {
    -webkit-font-smoothing: subpixel-antialiased;
}

This subpixel-antialiased mode is the default in webkit, but it renders fonts in an "incorrect" way as light fonts often look regular, and regular fonts look semi-bold (which, it seems to be the way you guys want it to be)

Thank you for the feedback.
So that means that all themes are doing it wrong at the moment?

No, not themes. Chrome is doing it wrong. Actually, it's not about being right or wrong, but fonts look closer to what they should look like if you antialias them using the antialiased value, like this:
:root {
    -webkit-font-smoothing: antialiased;
}


Why not use an exponential moving average to make it even faster?

First of all, thank you very much for providing this code free of charge!
In order to avoid a lot of overhead with OOP and also to avoid keeping a separate buffer, I suggest to simplify your code to use an exponential moving average, albeit the lower weighting of older samples. It is very easy to implement and runs faster than your current implementation.
Note: ALPHA_2K is the alpha value from Wikipedia chosen as a power of two in order to use bit-shifting instead of costly integer division.
#ifndef ALPHA_2K
#define ALPHA_2K 1
#endif
static uint32_t ema_x;
static uint32_t ema_y;
void filter(char* buf) {
const uint8_t type = (uint8_t)buf[8];
const uint16_t code = (
	(uint16_t)buf[10]      |
	(uint16_t)buf[11] << 8);
uint32_t value = (
	(uint32_t)buf[12]       |
	(uint32_t)buf[13] << 8  |
	(uint32_t)buf[14] << 16 |
	(uint32_t)buf[15] << 24);

if (type == 1 && ((code == 320 && value == 1) || (code == 321 && value == 1)))
    ema = value; // Reset EMA when pen/eraser is touching

if (type == 3 && code < 2) {
	if (code == 0) {
        ema_x += value;
        value = ema_x >> ALPHA_2K;
        ema_x -= value;
	} else if (code == 1) {
        ema_y += value;
        value = ema_y >> ALPHA_2K;
        ema_y -= value;
	}

	// copy value back to buffer
	buf[12] = (uint8_t)value;
	buf[13] = (uint8_t)(value >> 8);
	buf[14] = (uint8_t)(value >> 16);
	buf[15] = (uint8_t)(value >> 24);
}

}

Has anyone tried this in practice? I would be expecting more noisy lines, but also much less lag compared to the standard moving average.


MySQL connections are broken from the host

What happened (or feature request):
I was doing some testing today and discovered the MySQL connections from the host aren't working as we intended.
It turns out we made an incorrect assumption when doing the TCP stream proxying on the router, and failed to realize that TCP streams don't support traffic splitting via the host parameter. In hindsight, this is pretty obvious, since TCP streams lack the "host" header that HTTP traffic uses to split traffic based on hostnames. However, either no one tested using multiple servers, or they just failed to realize that all traffic was going to the same MySQL instance.
What you expected to happen:
The bad news is this is not fixable with the current architecture and is probably a bigger rework than we'd like. The entire reasoning for MySQL proxying was to keep the networking internals of docker-compose hidden from the user, and create a consistent environment both on the host and within the container for hostnames used to connect to services such as MySQL.
The good news is, even though this is a bigger rework than we'd like, it will allow us to reduce complexity all around. In the end, I'm optimistic that this will be a big win for reducing complexity and increasing maintainability.
The solution to fixing this likely requires a few pre-requisites:

[ ] Move to docker-compose v3. https://github.com/drud/ddev/issues/272
[ ] Remove the nginx-proxy completely. (yay).
[ ] Create a network per-application and assign an IPV4 address. We should no longer need a single shared network once the proxy is gone.
[ ] Update all hostname aliasing to use the IPV4 address assigned to the app.

There is the additional challenge of making sure this is portable across hosts. Thus far our strategy has been to encourage committing docker-compose files. However, if we assign IP addresses to these networks we run into the following issues:

The addresses need to be static so we can alias hostnames to them
They also need to either be portable across multiple machines or derived on the fly at start time.

How to reproduce it (as minimally and precisely as possible):

Create two ddev applications. Run installations on each (to get data).
Connect to the database from the host (i.e. using $appname.ddev.local)
Observe that both connections connect to the same database.

Related source links or issues:
https://docs.docker.com/compose/networking/

It would make sense to tag as v0.8 milestone and prioritize in the next sprint given that this is a bug. Not removing incubate yet because there probably needs to be some additional detail/thought in solving the IP issues before we can proceed.

We can convert this to actionable if we include one final AC:

[ ] Strategy + Implementation for sharing docker compose files with fixed IP addresses (e.g. detect and alert end-user, detect and suggest, detect and correct on the fly, etc).

However, this "bug" is just an indicator for a redesign task, so needs to be at a higher level. It needs to indicate the redesign, which affects all connections, not just mysql. I'd recommend we spend a bit of time experimenting with it. In the drupal-vm approach, it also required a specific ifconfig alias creation on macos which may not be available on Linux or may not be doable at all on Windows. (It's related to what we do for setting a localhost alias for xdebug debugging, which also needs some attention now that we've expanded platforms.)
So I'd say this definitely is not itself actionable unless it's just a call for a design. That's probably actionable.

Note that it is probably possible for us to circumvent the OP at this time by just not exposing the mysql port directly, perhaps encouraging people to use ddev exec drush sql-cli for example.

As noted in https://github.com/drud/ddev/issues/272#issuecomment-305016714, per-container IPs don't look to be a feasible approach for Docker for Mac. This unfortunately means we can't pursue the approach originally intended to resolve the OP. Given this, I am reverting the issue title to its original, and intend the following tasks to ensure users can reasonably interact with mysql and discover the port as needed:

add the exposed and internal ports to ddev describe, w/ documentation explaining the difference
remove the TCP_EXPOSE stuff since it doesn't accomplish what we're after
ensure both db and web containers have mysql client configurations so users can run mysql commands w/o having to define connection/credentials

While this is not the ideal solution we intended and hoped for, I believe it will be sufficient. We provide phpMyAdmin out of the box, and offer pre-config for SequelPro on mac. I think if we also ensure the mysql clients in the db and web containers can be easily used, that we've covered most of the common use cases where a user might want to determine how to connect to the database.

Technically, this should have been moved to v0.7. Updating milestone flag.

Small nitpick, but the helper text should provide a fully working command OR hint that more information is needed.
mysql --host <IP_ADDRESS> --port 32780
Needs to be extended:
mysql --host <IP_ADDRESS> --port 32780 --user db --password db --database db

https://github.com/drud/ddev/pull/316 improves the mysql example command.


Can't sort external window using menu action

When a file tab is in a separate window, the plugin cannot sort those tabs using the menu action.
Steps to reproduce:

Open two different files in tabs,
Drag one tab outside the main window,
When you have that external tab focused, go to menu (necessarily of the main window) Edit -> Sort lines.

Expected behavior:
It sorts the lines in the external tab.
Actual behavior:
As soon as the menu is clicked, the main window is focused, and the last focused tab in the main window is now focused too. It sorts that tab instead of the external tab.
Possible workaround:
Use a keyboard binding to sort the external document.

That is universal IntelliJ behaviour. Use a shortcut.

Thanks for the report, @MarkJeronimus, and thanks for the comment, @krasa. Closing this issue as I can't do anything easy to solve it.


Docker mongodb issue

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


MAINT: scipy.optimize, removing further anneal references

Remove some further anneal references.

Thanks @andyfaff, merged.


Squeeze metrics to actual results instead of column names

Merging, to see if I can get it to pass!

Ahhh, looks like we don't yet support deferreds in aggregation filters.
Fixing that now.

I'll revert to lambdas for now.


Separate raw data into separate nwb file

We need to separate the raw data into a separate file so that, if necessary, it could be archived following LFP extraction and spikesorting.

This is now working


[CELEBORN-661] Try avoid local blacklist when offer slots

What changes were proposed in this pull request?
In this PR, LifecycleManager passes local blacklist in RequestSlots, master will try to avoid the workers in the blacklist when offer slots, and ignore the blacklist if offer slots fails.
Why are the changes needed?
I was testing the case of three workers with replication on, and try to kill then start a worker without graceful shutdown, since master only considers a worker as lost after WORKER_HEARTBEAT_TIMEOUT, which is default 120s, master will blindly assign slots to the dead worker, which causes further more revivings.
Before this PR, test time is 245s, after this PR, time is 230s.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.

cc @RexXiong @AngersZhuuuu @pan3793

@RexXiong I've added config and refine the logic to ensure the at most 1/3 workers are filtered out, please take a look again.

Thanks for introducing this interesting design.
Some thoughts on the design aspect. This switch can either be a client-side or a master-side configuration.
client-side
pros

can be enabled/disabled in application granularity
when disabled, reduce the control message size

cons

ugly design, because it actually is part of a slot assignment algorithm

master-side
pros

unified design, centralized the logic of slot assignment on the master side

cons

can only be enabled/disabled in the cluster granularity
client also should send clientExcludedWork in the control message

Personally, I lean to make it a master-side configuration. Because I don't think we should disable it, and the control message fluid increasing is acceptable.

Hi @pan3793 , thanks for your feedback on the design!
Here is my thought. When make it a client-side config, it's like master will always consider the client-excluded workers, it's client's decision whether to send them. On the other hand, when make it a master-side config, it's like client will always send locally-excluded workers, it's master's decision whether to consider them. So IMHO, in the aspect of design unification, theses two seems at the same level.
In addition, https://github.com/apache/incubator-celeborn/pull/1575 reports worker unavailable as soon as it's closed(not for kill -9 for sure), so the delay of worker-lost to master has improved, and perhaps it's not that necessary to always turn this switch on.
Any further thoughts please let me know, thanks!
cc @RexXiong

If make it a client-side configuration, maybe the name can be
celeborn.client.registerShuffle.reportClientExcludedWorkers.enabled

"report" should be accurate than "avoid", because the decision is actually made by the master.

The gap here is that the master cannot know the unavailability of the worker in time, but the lifecycleManager can. I prefer configuration on the master side or both have. For the highest efficiency of the overall cluster the master needs to know the status of the workers from various channels, and this is can be considered as a strategy assigned by the master (whether to consider excluding workers on the client side, and besides the client blacklist also has a delay), as the current job needs to exclude this worker, can it be extended to another newly launched job?


add feature gate to collect and reward priority fee fully

Problem
Follow up #178 and #566; Rewarding full priority fee will break consensus.
Summary of Changes

add feature gate to new rewarding logic.

Fix Feature Gate Issue: #34731

Good call! something like this:
c4ea1fb962d61bafc050f437d7b30b852e4358d6


Add travis tests

I need someone with access to this repo to enable it on travis in https://travis-ci.org/profile/lampepfl. Thanks.

I don't have admin rights. @DarkDimius / @felixmulder : could you do it?

Щт ше

On it.

Done @nicolasstucki, please retry

Done


build(deps): update deps-prod

This PR contains the following updates:

Package
Type
Update
Change

importlib-metadata
dependencies
patch
1.6.0 -> ==1.6.1

wcwidth
dependencies
minor
0.1.9 -> ==0.2.4

Release Notes

jquast/wcwidth
v0.2.4
Compare Source

minor "bugfix" to avoid using pkg_resources module on import, 7918f58
may help xonsh xonsh/xonsh#3607

v0.2.3
Compare Source
PR #37/#38 @avylove
v0.2.2
PR #23: Support all versions of Unicode, using the UNICODE_VERSION environment variable, when defined, or, for non-shells, explicitly by passing argument unicode_version to the wcwidth family of functions.
A demonstration utility that determines the Terminal's Unicode Version is made available as a separate package, https://github.com/jquast/ucs-detect/ which contains a Problem and Solution statement.

Renovate configuration
📅 Schedule: "on the 1st day of the month,on the 2nd day of the month,on the 3rd day of the month" in timezone Asia/Shanghai.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you check the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: poetry.lock

/bin/sh: 1: poetry: not found

PR has been edited
👷♂ This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

PR has been edited
👷♂ This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.
If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.


Charging don't stop

Hello
I don't know what I am doing wrong.
I used litokala 18650 batteries and still have 3,7V on them after three days ups still charging.
Raspberry Pi power supply voltage: 5.084 V
Current current consumption of Raspberry Pi: 1791.590 mA
Current power consumption of Raspberry Pi: 8962.153 mW
Batteries Voltage: 3.736 V
Battery current (charging), rate: 360.000 mA
Current battery power supplement: 1253.659 mW
Current processor voltage: 3265 mV
Current Raspberry Pi report voltage: 5104 mV
Current battery port report voltage: 4211 mV
Current charging interface report voltage (Type C): 5010 mV
Current charging interface report voltage (Micro USB): 19 mV
Currently charging through Type C.
Current battery temperature (estimated): 48 degC
Full battery voltage: 4292 mV
Battery empty voltage: 3791 mV
Battery protection voltage: 3700 mV
Battery remaining capacity: 92 %
Sampling period: 2 Min
Current power state: normal
Shutdown countdown: 198 sec
Automatically turn on when there is external power supply!
Restart countdown: 198 sec
Accumulated running time: 3125 sec
Accumulated charged time: 3136 sec
This running time: 748 sec
Version number: 10

Hi, some problem here.
The only way to get a good measurement again is:
turn off the UPS(and RPI)
remove UPS power
remove the batteries
put the batteries
put the power to the UPS
and turn the UPS

Problem is that device have full battery voltage 100mA higher than maximum of full voltage on batteries I don't know why..
After two complete cycles charging and discharging my ups still charge batteries and shows 99% of capacity.

Problem is that device have full battery voltage 100mA higher than maximum of full voltage on batteries I don't know why..
After two complete cycles charging and discharging my ups still charge batteries and shows 99% of capacity.

@neresus , my batteries are 4.2V I'm feeding with info I got from the UPS Plus script:
Batteries Voltage: 4.216 V
Full battery voltage: 4293 mV

I think I may have the same issue as above.
I have tried a couple of different batteries, have done the firmware update, reset to factory defaults, tried different chargers and tried setting the parameters manually. Still the UPS does not charge to 100%, https://api.52pi.com/ says "It seems that your battery is still not fully charged."
The batteries I would like to be using are used LGDAME11865 (https://secondlifestorage.com/index.php?threads/lg-lgdame11865-cell-specifications.8332/)
Output from upsPlus_iot.py
'PiVccVolt': 4.98,
'PiIddAmps':<PHONE_NUMBER>081581,
'BatVccVolt': 0.0,
'BatIddAmps': 98.04878048780488,
'McuVccVolt': 3259,
'BatPinCVolt': 4237,
'ChargeTypeCVolt': 8929,
'ChargeMicroVolt': 44,
'BatTemperature': 41,
'BatFullVolt': 4295,
'BatEmptyVolt': 3700,
'BatProtectVolt': 3700,
'SampleTime': 2,
'AutoPowerOn': 1,
'OnlineTime': 157944,
'FullTime': 158232,
'OneshotTime': 5175,
'Version': 10,
Watching this thread with interest.

Reset UPS to factory defaults by writing 1 to register 0x1B. No need to do anything else like taking the batteries out.
Run the batteries down and recharge them (in the UPS) at least once to make the UPS learn the low and the high voltage limit.
Use a good quality charging cable and a good quality PD charger. It will deliver 9 V to the UPS and more than 3 A charging current to the batteries when they're empty.
Eventually the charge % will become 99 and even the last blue LED will stop blinking.

I have 65W usb-c charger. Second day of charging 11V 0,2A... still not charged :(

Unfortunately I, like many people here, have the exact same problem. I'm not sure what's up with the UPS, but it never stops charging, despite reaching 4.2V on the battery already. It won't go higher, of course.
$ upsPlus_iot.py
{
  "PiVccVolt": 5.148,
  "PiIddAmps":<PHONE_NUMBER>22624,
  "BatVccVolt": 4.204,
  "BatIddAmps": 80.0,
  "McuVccVolt": 3290,
  "BatPinCVolt": 4198,
  "ChargeTypeCVolt": 9081,
  "ChargeMicroVolt": 64,
  "BatTemperature": 40,
  "BatFullVolt": 4000,
  "BatEmptyVolt": 3600,
  "BatProtectVolt": 3700,
  "SampleTime": 2,
  "AutoPowerOn": 1,
  "OnlineTime": 161237,
  "FullTime": 161237,
  "OneshotTime": 161237,
  "Version": 10
}

You can even see I've set:
  "BatFullVolt": 4000,
  "BatEmptyVolt": 3600,
  "BatProtectVolt": 3700,

But unfortunately the UPS seems to ignore it? How do those settings work?
Oh and of course I've done bus.write_byte_data(DEVICE_ADDR, 42, 1):
FixedVbat register is: 1
Full Voltage register is: 4000
Empty Voltage register is: 3600

Could someone please explain how do those settings work? Firmware version is 10, as stated above. I would really wish to set the max voltage to some arbitrary number, to prolong the battery life (not to mention, I really want the UPS to stop constantly charging them when they are full already), probably at around 60-70% capacity, that's more than enough for my use case.
I've also tried two different battery types, they are both 4.2V.
Raspberry Pi power supply voltage: 5.140 V
Current current consumption of Raspberry Pi: 953.070 mA
Current power consumption of Raspberry Pi: 4911.690 mW
Batteries Voltage: 4.204 V
Battery current (charging), rate: 100.000 mA
Current battery power supplement: 336.585 mW
Current processor voltage: 3292 mV
Current Raspberry Pi report voltage: 5186 mV
Current battery port report voltage: 4199 mV
Current charging interface report voltage (Type C): 9068 mV
Current charging interface report voltage (Micro USB): 57 mV
Currently charging through Type C.
Current battery temperature (estimated): 41 degC
Full battery voltage: 4000 mV
Battery empty voltage: 3600 mV
Battery protection voltage: 3700 mV
Battery remaining capacity: 95 %

Makes me wonder what the "remaining capacity" is given that current bat voltage is above "max voltage" reported by Full-featured-demo-code.py as above...
Is there a firmware version that actually honours the max voltage setting?
Thank you.

Hello. Is someone who haven't this issue and charging stops? Can you write here your batteries manufacturer and type?

Currently on firmware version 14, seeing this issue as well.  Charging never stops, I suspect because the batteries aren't isolated once full and continue to contribute something to powering the pi.  As such the UPS is showing a charging current of like 40 mah.  Is this going to damage the batteries?  Or is this current low enough to be irrelevant for the battery lifespan?

Hello. I'm using two different UPS Plus EP-1036 (rev. 5.4 2020-01-05 PCB03a) and (rev. 5.0 2020/12/23 PCB01b) both on Firmware v14. Because I can not revert to Firmware v10. OTA_firmware_upgrade.py failed to download any other Firmware version ("File not found").
I tried to set the battery full voltage to 4100mV to prevent from constantly overloading the lipo cells.
This did not work. It's constantly charging the cells over 4200 mV.
So I'm realley concerned to use it 24/7.
I would like to know, if the setting of batt full voltage is controlling the charge settings in any way. I understand, that setting the full voltage higher than 4200mV for lipo cells could be really dangerous. But I want to set it lower for safety reasons.


can model  Qwen/Qwen-VL-Chat work well?

when i use Qwen/Qwen-VL-Chat  I do not know why!
throw a error
Traceback (most recent call last):   File "test.py", line 20, in <module>     model = LLM(model=model_path, tokenizer=model_path,tokenizer_mode='slow',tensor_parallel_size=1,trust_remote_code=True)   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/entrypoints/llm.py", line 66, in __init__     self.llm_engine = LLMEngine.from_engine_args(engine_args)   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/engine/llm_engine.py", line 220, in from_engine_args     engine = cls(*engine_configs,   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/engine/llm_engine.py", line 101, in __init__     self._init_workers(distributed_init_method)   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/engine/llm_engine.py", line 133, in _init_workers     self._run_workers(   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/engine/llm_engine.py", line 470, in _run_workers     output = executor(*args, **kwargs)   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/worker/worker.py", line 67, in init_model     self.model = get_model(self.model_config)   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/model_executor/model_loader.py", line 57, in get_model     model.load_weights(model_config.model, model_config.download_dir,   File "/usr/local/miniconda3/lib/python3.8/site-packages/vllm/model_executor/models/qwen.py", line 308, in load_weights     param = state_dict[name] KeyError: 'transformer.visual.positional_embedding'
the code is
`from vllm import LLM, SamplingParams
from transformers import AutoModelForCausalLM, AutoTokenizer,AutoConfig
import time
model_path="Qwen/Qwen-VL-Chat"
model = LLM(model=model_path, tokenizer=model_path,tokenizer_mode='slow',tensor_parallel_size=1,trust_remote_code=True)
tokenizer = AutoTokenizer.from_pretrained(model_path, legacy=True, trust_remote_code=True)
sampling_params = SamplingParams(temperature=0,max_tokens=8096)
start=time.time()
prompts = ["你好！"]
outputs = model.generate(prompts, sampling_params)
end = time.time()
for output in outputs:
prompt = output.prompt
generated_text = output.outputs[0].text
length = len(generated_text)
print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")
print(end-start)
cost = end-start
print(f"{length/cost}tokens/s")`

same question here

Same issue. I think this is because model_executor/models/qwen.py is only for Qwen-7B-Chat, not compatible with Qwen-VL.

same issue

有解决了没

same issue

Please stop saying same issue, just react to the original message to show your support

For text-only inputs, we can run the model with this patch https://github.com/vllm-project/vllm/pull/5710 .

I am looking into adding support for image inputs to Qwen-VL/Qwen-VL-Chat!

@alex-jw-brooks thanks for the upcoming contribution!
When you have updates, please post them here as I've closed the other issues as duplicates.

PR https://github.com/vllm-project/vllm/pull/8029 - it will add support for Qwen-VL/Qwen-VL Chat, but also keeps things intact for language only models like Qwen-7B-Chat.
It is in draft while I add a multimodal test and ensure the HF image format is supported in the input processor. I imagine people may have thoughts on the latter and added a comment here elaborating, if anyone wants to discuss! I plan to fix those things and move it out of draft in the next day or two


remove duplicated protos

remove duplicated protos

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.21%. Comparing base (675cfb5) to head (b4ac544).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2155       +/-   ##
===========================================
+ Coverage   27.93%   80.21%   +52.28%
===========================================
  Files         124        9      -115
  Lines       14597      551    -14046
  Branches     2681      246     -2435
===========================================
- Hits         4078      442     -3636
+ Misses      10388      109    -10279
+ Partials      131        0      -131

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
?

idp-domain-service
80.21% <ø> (ø)

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


:zap: perf: reduce initial bundle size with bal-nav

Description of this issue

[ ] - remove lodash
[ ] - reduce bal-web-app-utils
[ ] - load external apps after LCP

Code Reproduction URL
http://localhost:4000/test/seo/01-nav.html
Performance
87
Largest Contentful Paint
3.6
Speed Index
2.4
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

/cib


Implement: Sampling Function

pure_random_sampling
latin_hypercube_sampling
orthogonal_sampling

Finished the latin_hypedcube_sampling

Finished pure random sampling

Finished Ortho sampling, not 100% sure, better to be doubechecked by you guys.


hue 3.9 login error

Hi~
Sometimes I login hue, it will run very slow and then it will display server error 500
In error.log, it can see the error:

In hue.ini, I set the value:
app_blacklist = impala,spark,search,indexer,sqoop,zookeeper,security,rdbms,jobsub,help
does anyone knows the reason?
thanks.

I believe you have some older spark documents, when you go on the /home page it is trying to list them and fail as the spark app is disabled.
One way to fix it without fiddling with the DB would be to re-enable spark, then go to the app and delete them.
Or upgrade, that was fixed since :)


Add a few missing categories

I was inattentive when checking your PR. Although it would be nice if the the categories you added were existing, Crunchyroll doesn't list them.
The categories must match the categories found at https://www.crunchyroll.com/content/v2/discover/categories or in the Genres section of the website

They aren't listed in https://www.crunchyroll.com/content/v2/discover/categories but they're listed in https://www.crunchyroll.com/content/v2/discover/categories/<category>/sub_categories. If you use "adventure" you'll see "isekai" and if you use "romance" you'll see "historical" and "harem". They also work with the categories parameter for https://www.crunchyroll.com/content/v2/discover/browse.

Okay I see, my bad. I've re-added the categories and added a bit of abstraction to differ "normal" categories from sub-categories (although "normal" categories can also be sub-categories e.g. action), but better than nothing


Make all the links open in a new tab

I would like to be able to see the issue i'm forking at the same time as I am adjusting my params

Not possible cause github blocks it


Update first-app.md

I am exploring the amplication by going through the docs. I have updated the docs for line 36 and 207
Note : This is my first ever contribution on github. If there are any mistakes. I would request guidance.

Well done @SachinHatikankar100
Please join our discord channel so we can continue the engagement. I would be happy to help with any question you may have.
https://discord.gg/KSJCZ24vj2
thanks for the contribution

Thanks @yuval-hazaz  I have joined the discord channel yesterday!


chore: bdd-gh-1576837248 to 0.0.1

chore: Promote bdd-gh-1576837248 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add Banzai Cloud hpa-operator

This PR adds the Banzai Cloud sourced hpa-operator.
Please feel free to send us any feedback about this contribution.
You can read more about the Operator especially here:
https://banzaicloud.com/blog/k8s-hpa-operator/

Thanks @SamiSousa I've fixed those issues, it's not tested with OLM, I've only verified it with operator-courier.

Seems like operator-courier nest fails when there are no CRDs defined by an operator: https://travis-ci.com/operator-framework/community-operators/builds/108167507#L454
@kevinrizza Should I open an issue?

@SamiSousa yes please.

@sancyx Please address my comments. Pushing a new PR will also help in rerunning the CI, which should work now that the courier fix has merged and a new release has been made

Thanks @SamiSousa for your observations, I've fixed the package name, it seems to me that build is fine now.

@sancyx Seems that this operator successfully installs with OLM :slightly_smiling_face:
There's no CRDs to watch, but if this operator watches labels and has been tested in an AllNamespace case, it should be good to go

Hello @SamiSousa @kevinrizza - is there anything else we need to do to have this PR merged?

/lgtm

Hi @matyix It seems it's been a while since we looked at this, could you just double-check that your operator properly deploys with OLM and works as expected? Thanks!

Hi @gfbarros I can confirm we have successfully deployed it with OLM. One thing is to make sure that you use the latest courier operator which contains the fix to include operators with no CRD definitions. So if you build registry image with https://github.com/operator-framework/community-operators/blob/master/upstream.Dockerfile you had to use here the latest 2.1.0 version.

/test

/ok-to-test


Update communicate-with-users-from-other-organizations.md

Update screenshot from External Access TAC page to include the following screenshot: Your Teams users can add apps when they host meetings or chats with other organizations, and they can use apps shared by external users when your users join meetings or chats hosted by other organizations. The data policies of the hosting user's organization, as well as the data sharing practices of the third-party apps shared by that user's organization, will be applied.

Will update screenshot when ready via another PR.


autoValue: calling fields() and siblingFields() yields no results on insert

I'm using autoValue in combination with this.siblingFields(), like this:
autoValue(doc) {
      const residences = this.siblingField('residences');
      ...
}

It works perfectly on updates, but on inserts, the fields are always unset and the value is undefined. If I print out the doc that is passed to autoValue, the fields are there, even in the insert case.

Please post a full schema and full doc that reproduces this issue.

The Meteor SimpleSchema package is no longer maintained other than critical fixes to keep it running with each latest Meteor release. Closing non-critical issues in this repo. Anyone who cares about this may do one or more of the following:

Switch to the NPM package. Be sure to adjust for the breaking changes. There can be a lot of work involved in switching, but it is worth the effort.
If this issue still occurs in the NPM package, submit an issue there. Be sure to include a link to a reproduction repo or a PR that adds a failing test for the issue.
If you have more time than money, submit a pull request to resolve any issue labeled "help wanted" in the NPM package repo.
If you have more money than time, donate to help support development if you are able


Road to v3

[x] MIT License
[x] Introduce node type, to centralize prefixes and give user more flexibility

[x] Implementation
[x] Documentation
[x] Test

[ ] Introduce absolute and relative horizontal index for full control over diagram by user (otherwise strictly sort alphabetically)

[x] Refactor: 3 units: graph, render and layout
[ ] Document layouting algorithm

[ ] Optimise edges when they are crossing nodes or skip at least one rank
[x] Add new design goal for documentation: Full user control
[x] Amend history with v3

Simple rules for layout:

Nodes without parents center over their children
Nodes without children center under their parents
If you have children, you center over them, independent from whether your parents are

Children and parents here are: supportedBy and composite
Misc

[ ] Put complete, architecture and evidences immediately into output folder.
[ ] Add migration procedure from 2.x to documentation
[x] Rework create_group
[x] Make away node use path instead of rect
[x] Limit layout algorithm by detecting if left is empty space
[x] Make justifications aspect ratio better fitting.
[ ] Decrease word wrapping limit to make resulting graph more suitable for vertical page layouts.

Pre release checklist

[ ] No dbg!s
[ ] No commented code
[ ] All functions and structures documented
[ ] Suitable data structures (e.g. do we need a BTreeSet or is a HashSet better?)
[ ] Unwraps commented why they are not supposed to happen during normal operation
[ ] All to_owned, clone(d) really needed?
[ ] No unused parameters or variables (check for identifiers that are prefixed with _)

Ranking algorithm:

Starting from root nodes
get children (only hold back forced levels)
sort nodes on one rank alphabetically

How to limit forced levels?
Problematic example:
A supported by B
C supported by D
Levels:

A and D
C and B

Line wrapping
Do wrapping with quite a large number.
Provide a command line option set a global (smaller) number.
Apply global option when translating to SvgNodes. Remove finding optimal line wrapping algorithm.
User can already use the YAML mechanism with a pipe to introduce manual line breaks.


Crash on Rive Event

Defold: 1.7.1-alpha 80ffc1ac07a9845dfa09aaa6ba194fb282e8047d
Rive: 0.8.1268
Defold Rive-extension: main
Game crashes when Event is triggered in playing State Machine.
  rive.play_state_machine(config.rive_url, "State Machine 1", {},
    function(self, message_id, message)
	    pprint("Hit event", message_id, message)
    end)

2024-04-12 18_25_rrw.zip

Added Reproduction example.
Only including main and input folders with game.project, since zipping everything is over 350MB.

main.zip

In the above example, the crash on exit also appears sometimes - for this, please, remove timer callback from main.script that is triggering an animation with the event, so that you don't have this crash and then run and close the build and sometimes the crash is happening (at least on my and my colleague's setup)


Add folding!

Somewhat experimental but it seems to do the trick.

Codecov Report

Merging #51 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #51      +/-   ##
=========================================
+ Coverage   97.34%   97.4%   +0.06%
=========================================
  Files          26      27       +1
  Lines        1542    1578      +36
=========================================
+ Hits         1501    1537      +36
  Misses         36      36
  Partials        5       5

Flag
Coverage Δ

#dot
97.4% <100%> (+0.06%)
:arrow_up:

#dot_conv
100% <ø> (ø)
:arrow_up:

#dot_encoding
90.05% <ø> (ø)
:arrow_up:

#dot_encoding_counter
74.41% <ø> (ø)
:arrow_up:

#dot_encoding_richtext
100% <ø> (ø)
:arrow_up:

#dot_encoding_set
100% <ø> (ø)
:arrow_up:

#dot_encoding_sparse
100% <ø> (ø)
:arrow_up:

#dot_fold
100% <100%> (?)

Impacted Files
Coverage Δ

fold/fold.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c21e1...af80fd4. Read the comment docs.


Mcedit2 wont launch (alpha-907)

Steps to Reproduce: Double click the mcedit2.exe. The prompt comes up and closes very fast after that.
Nothing happens then. It did work before, but it suddenly stopped.
Might have been a system restore or new conflicting program, I dont know. Maybe I am missing some required programs.
MCEdit Version Number:
All (I tried like 10) of the development builds in the download section, but 907 gave me a log file for the first time. Both 64 and 32 bit do this.
Minecraft Version Number:
1.8.8, im using some shaders,
Operating System Version:
Windows 7 64bit.
Log file in the attachment.
logfile.txt

Does it work if you move the app to your C: drive instead of D: ?

It seems like your "Null" device is disabled. Open Device Manager, choose View -> Show hidden devices, and then look under "Non-Plug and Play Devices" for the Null device and make sure it is enabled and running:

Thanks for the fast response,
It doens't run on C: too and Null was already enabled.

Could you try stopping and starting the Null service?

Sorry for the late reaction,
I tried stopping it, but it wouldn't let me. it tells me that it is running and working correctly though.
Today I had some strange computer issues, alot of blue screens etc, dont know if it is related. But I did some registery fixes and checkdisks, removed temporary files etc. and now mcedit is working too again.
So problem is solved, but I dont know what caused it and how I eventually fixed it.
Thanks for your help.

Great news. For future reference, can you tell me what programs you used to check your disk and fix your registry?

I restarted my computer, and it died again :(. can't get it to work again too..
I used CCleaner to delete unused files and registery clean, checkdisk from windows to repair problems, if any on my harddisk. Ram checker utility from microsoft and run a complete virus scan AVG. After a few reboots it suddenly did work again.
But now it won't :(, same log and error as before.

Sounds like a system specific issue, besides this is the MCEdit 1 repo so if you find more info please post it on the mcedit 2 repository. Might want to look into a clean install, this is the kind of issue you could chase for a long time, also I advise against CCleaner, from my experience it has a tendency to break some of window's basic functions from time to time. Especially on non-default /upgrade installs.


About Release date of source code

I recently read your paper published in Nature machine Intelligence and was quite interested in the implementation. However, it looks like the source code has not been released yet. May I ask when it will be available?
Thanks!

@BlenderWang9487 : Thank you for your interest in our work. We have pushed our code a few days back - hope it helps!


Missing run object in some cases

Reported here
There is some edge case when the run ends with error.
Error:
TypeError: Cannot read property 'status' of null
at Object.waitUntilRunFinished (/usr/src/app/src/helpers/apify_helper.js:28:55)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async runActorTask (/usr/src/app/src/actions/run_task.js:53:34)
at async /usr/src/app/src/index.js:47:21"

Not sure what is causing this, but let's update https://github.com/apify/keboola-ex-apify/issues/26 apify-client and we will see.


[BUG]Update data with a failed result on used an uuid

bug 描述 [详细地描述 bug，让大家都能理解]
when i update a value, the page result an update error to me.
错误!
Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'descbe16502-be00-4f9c-aa93-b25e0291d826 LIMIT ? OFFSET ?' at line 1

i see the edit page's previous key the sort type displayed with a wrong value:
<input type="hidden" name="_previous_" value="/admin/info/globals?__page=1&__pageSize=10&__sort=id&__sort_type=descbe16502-be00-4f9c-aa93-b25e0291d826">

the data uuid is : 1be16502-be00-4f9c-aa93-b25e0291d826
it looks splited the uuid and insert it into the previous
finally the value was updated successed.

GoAdmin 版本: [e.g. 1.0.0]
1.1.6

Fixed. #92bd01


[SR-4107] Implement initializer-declaration in lib/Syntax

Previous ID
SR-4107

Radar
None

Original Reporter
@bitjammer

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, Syntax

Assignee
@bitjammer

Priority
Medium

md5: 16e416e73302bd04d431e92d9ec7f471

libSyntax was removed in #62145 and succeeded by swift-syntax.


Arcs rendered in attached gerber do not render properly.

The gerber in pcb.bor.txt renders correctly in gcpreview and gerbv.
It has issues when displaying the svn generated by gerber-to-svg.
The attached png file is a screenshot of the file being displayed in gerbv.
It looks like gerber-to-svg is having trouble with the tight arcs.

pcb.bor.txt

This has been fixed in mcous/gerber-plotter@f674c05. It will be fixed here at v1.0.0 when this library switches over to using the gerber-parser and gerber-plotter npm libraries.


An example how to use this library with viem.sh would be great.

The new kid on the block is viem.sh
It would be great to see an example with this library.

Here's how I solved it at the end:
import { DefenderRelayProvider } from "defender-relay-client/lib/web3";

const openZeppelinDefenderCredentials = {
  apiKey: process.env.OPENZEPPELIN_DEFENDER_API_KEY ?? "",
  apiSecret: process.env.OPENZEPPELIN_DEFENDER_SECRET ?? "",
};

const web3 = new DefenderRelayProvider(openZeppelinDefenderCredentials, {
  speed: "fast",
});

const client = createWalletClient({
  account: "0x79e084564564b4808559b17a9f6062342340", //  Your Defender Address goes here
  chain: getChain(),
  transport: custom({
    async request({ method, params }) {
      return await new Promise(function (resolve, reject) {
        web3.send({ method, params, jsonrpc: "2.0" }, (error, result) => {
          console.log("result", method, params, error, result);
          if (error != null || result?.error != null || result == null) {
            reject(error);
          } else {
            resolve(result.result);
          }
        });
      });
    },
  }),
});


Regressions in privacy policies

There's a regression in the latest update of the German privacy policy: "nach 14 Tagen" turned into "nach 14 Tage".

Android DE: https://github.com/corona-warn-app/cwa-app-android/blob/9ec222a431340917834e831cc60edd14fa062d27/Corona-Warn-App/src/main/assets/privacy_de.html#L188
iOS DE: https://github.com/corona-warn-app/cwa-app-ios/blob/864d7600553b70beb6de94d624d22abda16ed44b/src/xcode/ENA/ENA/Resources/Localization/de.lproj/privacy-policy.html#L321

In the English policy, the wrong parenthesis are now used:

a. Consent to “exposure logging”

turned into

a. Consent to "exposure logging"

Android EN: https://github.com/corona-warn-app/cwa-app-android/blob/b4bf87fc7f0229ae950532632cd33edfcd93255b/Corona-Warn-App/src/main/assets/privacy_en.html#L1120
iOS EN: https://github.com/corona-warn-app/cwa-app-ios/blob/864d7600553b70beb6de94d624d22abda16ed44b/src/xcode/ENA/ENA/Resources/Localization/en.lproj/privacy-policy.html#L936

Here's another, Android-specific regression that is worth its own ticket: https://github.com/corona-warn-app/cwa-app-android/issues/3166

Side note: there's a small inconsistency in the reference "5.g. und 6.g.". According to other occurrences, it should be "5 g. und 6 g.". The English version also sometimes, but rarely uses a non-breaking space  in between digit and letter:

(see Section 6 e.)

Android DE: https://github.com/corona-warn-app/cwa-app-android/blob/9ec222a431340917834e831cc60edd14fa062d27/Corona-Warn-App/src/main/assets/privacy_de.html#L271
iOS DE: https://github.com/corona-warn-app/cwa-app-ios/blob/864d7600553b70beb6de94d624d22abda16ed44b/src/xcode/ENA/ENA/Resources/Localization/de.lproj/privacy-policy.html#L376

If you would like my feedback on your privacy policy updates before you merge them in, feel free to ping me. Actually that would be much less work for me than to open new issues each time I find something. I need to manually review every change anyhow for CCTG
Previous: #601, https://github.com/corona-warn-app/cwa-app-android/issues/2841

Internal Tracking-ID: EXPOSUREAPP-7274

@fynngodau
Thanks. I've reported the issues to the developers.

If you would like my feedback on your privacy policy updates before you merge them in, feel free to ping me. Actually that would be much less work for me than to open new issues each time I find something. I need to manually review every change anyhow for CCTG

Regarding this, it might be worth to have a general discussion about involvement of the community and where and how we can improve outside contributions. Stay tuned.

Corona-Warn-App Open Source Team

FYI the second case mentioned will be fixed by https://github.com/corona-warn-app/cwa-app-ios/pull/2733 under iOS in version 2.3

FYI, second item, Android : PR https://github.com/corona-warn-app/cwa-app-android/pull/3221

I determined that all almost issues I highlighted are indeed going to be fixed with the 2.3 update, at least for Android.


Authentication allure

hello, can you add authentication before accessing the allure report, you have to log in first?

@fauzisunarya I'm not sure what are you talking about
This plugin doesn't have any authentication. It only helps to generate allure results, from which you can afterwards generate Allure Report

I mean, I request to add a login page, is that possible sir?

this plugin doesn't have any html generation or html pages. It generates only json files in a proper format for Allure Report to be able to read it. Allure Report is something that I cannot control - it is separate library. If you want something to be added there you should ask them about it.
I addition I want to say that your request is quite strange:  to have login page you need to have a server where login information will be stored, but Allure Report is html with some javascript, it doesn't have any server. If you want to login before accessing the report you need to have your own server for that and implement auth logic there. Or as other option you can use paid version of allure which is called Allure TestOps.

Thank you for the confirmation, I have read about Allure Test Ops, but there is no method or example of a project that uses Cypress, how to implement a Cypress project using Allure Test Ops

there is no difference which test framework you use - cypress, jest, mocha etc. Allure Testops will use generated json files by adapter (which is this plugin helps with). So it is enough for you read Allure TestOps documentation to understand how it should be setup. Also you can use chatGPT, it knows a lot about that.

OK, thank you sir.
You really helped me as a beginner, I hope your luck goes smoothly


get_output don't handle promises

Issue summary
If you echo promise and call get_output you get [object Promise]
Expected behavior
I should get the value the promise is resolved to
Actual behavior
It return string [object Promise]
Steps to reproduce
function render(text, delay) {
    return new Promise(resolve => {
        setTimeout(() => resolve(text), delay);
    });
}

term.echo(() => render('lorem', 10));
term.echo('foo');
term.echo(() => render('ipsum', 10));
term.echo('bar');
term.echo(() => render('dolor', 10));
term.echo('baz');
setTimeout(() => { term.echo(term.get_output()); }, 500);

Found while writing unit tests for async echo, was not able to use get_output() in 1415082dad0aa3a4f71679d6ab59e74c27554926

The code now works like this, if any of the lines resolve to a promise then get_output() will return a promise of a string.

Ther is still an issue, get_output() should not render the output, but get what is already printed on the terminal.


Unable to enter text on SWAL prompt when in fullscreen on Safari

I have the following code that I use to put a browser into fullscreen mode:
// Find vendor-specific function to call
if (!document.fullscreenElement && !document.mozFullScreenElement && !document.webkitFullscreenElement && !document.msFullscreenElement)
{
    // Enable full screen
    if (document.documentElement.requestFullscreen) { document.documentElement.requestFullscreen(); }
    else if (document.documentElement.msRequestFullscreen) { document.documentElement.msRequestFullscreen(); }
    else if (document.documentElement.mozRequestFullScreen) { document.documentElement.mozRequestFullScreen(); }
    else if (document.documentElement.webkitRequestFullscreen) { document.documentElement.webkitRequestFullscreen(Element.ALLOW_KEYBOARD_INPUT); }
}
else
{
    // Disable full screen
    if (document.exitFullscreen) { document.exitFullscreen(); }
    else if (document.msExitFullscreen) { document.msExitFullscreen(); }
    else if (document.mozCancelFullScreen) { document.mozCancelFullScreen(); }
    else if (document.webkitExitFullscreen) { document.webkitExitFullscreen(); }
}

However, when in full screen, SweetAlert doesn't allow anything to be typed into the input (text box). Using the regular full screen "green traffic light" button does not cause this problem, but something in the above JS does. Any ideas?
This issue seems to be limited to Safari.

Thank you @thepenguin1 for reporting this but it looks like we can't do anything with this Safari-related issue, http://stackoverflow.com/a/16676279/1331425


-Maxtime-job is not defined on the latest version

I cannot found the -maxtime-jobs option on the latests version releases.
but it was already on the readme.md.

Hi, that's right. --maxtime-jobs is currently only in the unreleased master branch, but will be included in the future release. To see the readme (and CHANGELOG) for the release version, please see: the v1.0.2 release tag.


Add unit tests for controller & service

Add unit tests for the existing controller & service methods (mural & tours)
Reference: https://dev.to/jackcaldwell/mocking-es6-class-methods-with-jest-bd7

Closed by #36 #35 #34


User should define what kind of packages can be installed / can be listed

Description of the new feature/enhancement
The tool should have a configuration that prevents specific kinds of installers. E.g. WinGet could configured to only install MSIX and not MSI packages.
The problem I have with currently existing package manages or precisly the managed packages under windows is that I don't trust there uninstall. While MSI can be correctly uninstalled and often will, in my experience it does not always works. Using a package manager hides the fact what install medium is used. (It is not that I never install software that uses MSI but I generally think twice about it)
If I could setup winget in a way that it lists only packages that are known to uninstall/update without problems I head much more confidence in using it.
This way MSIX (and maybe other formats that can be easily removed) can be promoted a little bit without loosing support for "older" software.

This looks loosely related to #154. I only mention it as we would likely use that work item to make sure we have the ability to manage the client. This would be a feature to allow or disallow a subset of installer types.

[Policy] Area-Settings

We've added support to specify the installer-type when installing packages. The remaining work would be to make a section in settings to specify required installer types.

We've added support to specify the installer-type when installing packages. The remaining work would be to make a section in settings to specify required installer types.

I do believe that the settings portion already exists - however, it only applies to the install command and does not affect winget search or winget list

@denelon - The functionality for specifying required installer type in settings was added in #3516 and has now been available since WinGet v1.6.2482


Refactoring the index.js file and updating the test file to reflect those changes

This could be one way to address Issue #5.

Excellent work! Thank you very much :)

Some things to note:
Most of these changes are in-line with the principles from Clean Code. One major changes is moving the file IO to a separate file. This (should) make it easier to refactor when #6 is resolved. Other than that, it's just some basic Clean Code stuff that you probably would have gotten to as you looked at it more.
Thanks for letting me contribute!


Update AAD Warning Link

🗣 Description

Updated the link within the AAD report, since the documentation was restructured
💭 Motivation and context

Closes #1169
🧪 Testing

Ran the ScubaGear on the AAD, and ensured the link in the report worked and correctly took the users to the link in documentation

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] Unit tests added/updated to cover PowerShell and Rego changes.
[x] Functional tests added/updated to cover PowerShell and Rego changes.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@nanda-katikaneni This PR is ready to merge.


CocoaPods could not find compatible versions for pod "Adapty"

Description
Hello! I cannot upgrade to any v2.X.X version on iOS. When I use the command pod install, it throws the error below. Everything works fine on Android or with v1.X.X versions. Even on a fresh RN project, it doesn't work. I do not use Expo.
I've tried: pod repo update, deleting podfile.lock, setting a higher minimum iOS version. Am I missing something obvious from the documentation?
[!] CocoaPods could not find compatible versions for pod "Adapty":
  In Podfile:
    react-native-adapty (from `../node_modules/react-native-adapty`) was resolved to 2.6.0, which depends on
      Adapty (= 2.6.3)

None of your spec sources contain a spec satisfying the dependency: `Adapty (= 2.6.3)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

My podfile if it helps.
# Resolve react_native_pods.rb with node to allow for hoisting
require Pod::Executable.execute_command('node', ['-p',
  'require.resolve(
    "react-native/scripts/react_native_pods.rb",
    {paths: [process.argv[1]]},
  )', __dir__]).strip

platform :ios, min_ios_version_supported
prepare_react_native_project!

# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
# because `react-native-flipper` depends on (FlipperKit,...) that will be excluded
#
# To fix this you can also exclude `react-native-flipper` using a `react-native.config.js`
# ```js
# module.exports = {
#   dependencies: {
#     ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# ```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled

linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
  Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
  use_frameworks! :linkage => linkage.to_sym
end

target 'AwesomeProject' do
  config = use_native_modules!

  # Flags change depending on the env values.
  flags = get_default_flags()

  use_react_native!(
    :path => config[:reactNativePath],
    # Hermes is now enabled by default. Disable by setting this flag to false.
    :hermes_enabled => flags[:hermes_enabled],
    :fabric_enabled => flags[:fabric_enabled],
    # Enables Flipper.
    #
    # Note that if you have use_frameworks! enabled, Flipper will not work and
    # you should disable the next line.
    # :flipper_configuration => flipper_config,
    # An absolute path to your application root.
    :app_path => "#{Pod::Config.instance.installation_root}/.."
  )

  target 'AwesomeProjectTests' do
    inherit! :complete
    # Pods for testing
  end

  # post_install do |installer|
  #   # https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
  #   react_native_post_install(
  #     installer,
  #     config[:reactNativePath],
  #     :mac_catalyst_enabled => false
  #   )
  #   __apply_Xcode_12_5_M1_post_install_workaround(installer)
  # end
end

Version
v2.6.0
What platforms are you seeing the problem on?
iOS
System info
System:
  OS: macOS 13.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 87.27 MB / 16.00 GB
  Shell:
    version: 5.8.1
    path: /bin/zsh
Binaries:
  Node:
    version: 16.13.0
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.19
    path: /usr/local/bin/yarn
  npm:
    version: 8.1.0
    path: /usr/local/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.11.3
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.2
      - iOS 16.2
      - macOS 13.1
      - tvOS 16.1
      - watchOS 9.1
  Android SDK: Not Found
IDEs:
  Android Studio: 2021.3 AI-213.7172.25.2113.9123335
  Xcode:
    version: 14.2/14C18
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.4
    wanted: 0.72.4
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

After 2 frustrating days, I've fixed it with this solution. I'm not sure why I've got this error only with this package and with v2 versions.
sudo arch -x86_64 gem install ffi
then
arch -x86_64 pod install

After 2 frustrating days, I've fixed it with this solution. I'm not sure why I've got this error only with this package and with v2 versions.
sudo arch -x86_64 gem install ffi
then
arch -x86_64 pod install


Spaces on the previous line are counted for the indentation

Describe the bug
When you place an accidental space on the previous line, it will be counted for the indentation of the current line
To Reproduce
bool:
    true = "true";
    false = "false";

Due to the extra space following bool: it will create an empty enum Bool, and two structs, True and False.
A different example
operator:
    plus = "+";
    minus = "-";
    times = "*";
    divide = "/";

Due to the extra space following minus = "-";, this will create an enum Operator with only the Plus and Minus variants, and two structs named Times and Divide.
Expected behavior
I would expect the extra space on the previous line to be ignored in the count.
Setup (please complete the following information):

OS: Linux
Commit hash f917f0d065e218f3b471247be4932a9f2d2af6b2

Version 0.1.3 solved the second of the two cases, but not the first one.


Multilevel Autocomplete Interface: Headers are not respected for web request

Extension
Something else
Describe the Bug
When you select "web request" as the "Source", the Headers are not respected during the url request
To Reproduce

Using the REST API generated by Directus in another project
Open read permission in a collection for authenticated users
Generate static token for a user within the permitted role in that specific collection
Use the static token as a bearer token in the Authorization header for "web request" in Multilevel Autocomplete Interface
No response at all during url request

Directus Version
v11.1.1
Hosting Strategy
Self-Hosted (Docker Image)

please review this pr #79


Watching on Ubuntu

feri -w returns to the command prompt immediately instead of waiting and watching the source directory.
Watching in general does not seem to notice changes to the source or dest folders. May be related to the failures of npm run test-watch.
Windows and Mac are unaffected by this issue.

Watching source and dest works now. Watch tests too. ^_^


how to create slide panel on slide panel (multiple level)?

for example i have slide 1, and in it have btnslide2.
when i click to show slide 2, but slide 1 is closed.
I would to create slide panel on slide panel (multiple level slide).
how?

Hi @yuomtheara . Currently this package only supports one visible slide panel at a time. The slide panel is only one main DOM element and the template you choose to show is dynamically inserted into that same element each time.
Let's say you had slide 1 open and you then opened slide 2. You can then show slide 1 automatically after slide 2 is closed to simulate having two panels on top of each other:
Right after calling slidePanel.showPanel('slide 2') just pass a function to slidePanel.closePanel which calls slidePanel.showPanel('slide 1').

Thanks for your reply, so it mean that when the  slide 2 closed the slide 1 is opened (it will reset data on slide 1). i don't want to do that, because i want to change any data on slide 1 atfer slide 2 closed.

Yes it will reset the state of the template when the panel is closed and
opened by default. One thing you could do is save the state of the slide 1 into a local or session variable when it closes, and then pass that as
the data value for the template when you reopen it again to set the state
as it was.
On Jan 30, 2015 10:35 PM, "Yuom Theara"<EMAIL_ADDRESS>wrote:

Thanks for your reply, so it mean that when the slide 2 closed the slide 1
is opened (it will reset data on slide 1). i don't want to do that,
because i want to change any data on slide 1 atfer slide 2 closed.
—
Reply to this email directly or view it on GitHub
https://github.com/rosh93/meteor-slide-panel/issues/2#issuecomment-72307083
.

thanks, but i would like to request the multiple level option.


Accept react-i18next TFunctionResult type

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

I'm using UI Kitten with Typescript and React-i18next. The problem is that the Text component doesn't accept the string resulted from the t() function because it can return a null or object if the namespace doesn't exist. This patch would fix this issue.
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 9496be9..13035f1 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -3,6 +3,7 @@
  * Copyright Akveo. All Rights Reserved.
  * Licensed under the MIT License. See License.txt in the project root for license information.
  */
+import { TFunctionResult } from 'i18next';
 import React from 'react';
 import { TextProps as RNTextProps } from 'react-native';
 import { EvaStatus, Overwrite, LiteralUnion } from '../../devsupport';
@@ -12,7 +13,7 @@ declare type TextStyledProps = Overwrite<StyledComponentProps, {
 }>;
 declare type ChildElement = React.ReactText | TextElement;
 export interface TextProps extends RNTextProps, TextStyledProps {
-    children?: ChildElement | ChildElement[];
+    children?: ChildElement | ChildElement[] | TFunctionResult;
     category?: LiteralUnion<'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | 's1' | 's2' | 'p1' | 'p2' | 'c1' | 'c2' | 'label'>;
     status?: EvaStatus;
 }

This issue body was partially generated by patch-package.

Hi, @gabrielmoncea! Personally, I don't think it's a good idea to add whole package in order to support type. Type we provide is matchable for i18next type. You could just go with:
<Text>{t<string>('smth')}</Text>

That's a good idea! Thanks!


[CBC] Fix test errors

Load also indirectly linked playlists (series -> season)
Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This PR fixes the following error:

======================================================================
ERROR: test_CBCWatch_1 (test.test_download.TestDownload):
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/extras/src/youtube-dl/test/test_download.py", line 159, in test_template
    force_generic_extractor=params.get('force_generic_extractor', False))
  File "/mnt/extras/src/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in extract_info
    self.report_error(compat_str(e), e.format_traceback())
  File "/mnt/extras/src/youtube-dl/youtube_dl/YoutubeDL.py", line 620, in report_error
    self.trouble(error_message, tb)
  File "/mnt/extras/src/youtube-dl/youtube_dl/YoutubeDL.py", line 590, in trouble
    raise DownloadError(message, exc_info)
DownloadError: ERROR: Could not find XML element {http://search.yahoo.com/mrss/}group; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
-------------------- >> begin captured stdout << ---------------------
[debug] Using fake IP <IP_ADDRESS> (CA) as X-Forwarded-For.
[cbc.ca:watch] 1ed4b385-cd84-49cf-95f0-80f004680057: Downloading XML
[cbc.ca:watch] 1ed4b385-cd84-49cf-95f0-80f004680057: Downloading XML
ERROR: Could not find XML element {http://search.yahoo.com/mrss/}group; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/mnt/extras/src/youtube-dl/youtube_dl/YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "/mnt/extras/src/youtube-dl/youtube_dl/extractor/common.py", line 500, in extract
    ie_result = self._real_extract(url)
  File "/mnt/extras/src/youtube-dl/youtube_dl/extractor/cbc.py", line 384, in _real_extract
    return self._parse_rss_feed(rss)
  File "/mnt/extras/src/youtube-dl/youtube_dl/extractor/cbc.py", line 266, in _parse_rss_feed
    media_group = xpath_element(item, _add_ns('media:group'), fatal=True)
  File "/mnt/extras/src/youtube-dl/youtube_dl/utils.py", line 306, in xpath_element
    raise ExtractorError('Could not find XML element %s' % name)
ExtractorError: Could not find XML element {http://search.yahoo.com/mrss/}group; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

It turns out, the Aardvark playlist actually refers to other playlists for individual seasons, not the videos. This patch just downloads and recurses to them if there is no media present.

Commit message must reflect changes made. This fixes extraction for all playlist not fixes test cases.


User tutorial has no documentation of debugging pipelines

Users moving to Toil will often have no experience debugging in a cloud environment.  There needs to be a chapter on how a user approaches debugging.  print and pydb don't exactly work.

See also #677 and #662.


Update client.cr

I mistakenly edited the html doc, but was redirected here to edit the comments used to generate the doc. The change was to comments
headers: HTTP::Headers{"User-agent": "AwesomeApp"}
to
headers: HTTP::Headers{"User-agent" => "AwesomeApp"}

Merged as 7074b2819379afab42aa67736de1d5e41083b314
Thanks!


Add GHAs to render/publish docs website

Up till now I've been publishing the site locally using quarto publish netlify. I'm imagining two GHA:

On PR to dev or main, renders the branch and pushes it to closeread-pr.netlify.app. The main use of this is to have an automated check before merging. Hopefully all major features will be documented as Gallery > Demos as a source of tests.
On merge into main, renders mainand pushes it to closeread.netlify.app. This is to keep the docs in sync with the version of the extension users will get when they runquarto add qmd-lab/closeread`.

This sounds good to me! Lmk if you need any help writing the actions!

Currently futzing in https://github.com/qmd-lab/closeread/blob/main/.github/workflows/publish-pr-site.yml . This is recycling the image and action that I use for another big quarto project. I don't really remember how I set that one up, though, so I'm just kinda prodding in the dark here. Feel free to tinker and suggest other images if you've got a better tailored one!

The current version seems to be running:
https://github.com/qmd-lab/closeread/actions/runs/11395061439
that publishes to closeread-pr.netlify.app. I'll change the on: so that it fulfills 1. above.

Here's an example of one of my actions creating a release using gh release create. That command has a -l flag for marking that release as the latest one, as well as -p flag for marking it as pre-release (not used in my example above but are documented).

and 2. are now in place (I think..).

I should have set this up with an accompanying branch to make clear what was happening. For some reason, my brain thinks that GHA files are properties of github and not the repo itself, so I have a bad habit of editing them at github.com and committing directly to main 😬

Oh, that publish release bit is great. I guess we can tack that onto the end of https://github.com/qmd-lab/closeread/blob/main/.github/workflows/publish-docs.yml ? (and probably want to rename to something like "document new release")

Haha, I tend to edit them in the browser too! It just means we need to merge the commit over to dev too, since actions need to be present on all branches involved in order to run (and I think on the default branch too, which wouldn't be a problem here).
Do we want on: push rather than on: pull_request for triggering builds? I think the latter runs by default as soon as a PR targeting dev or main is opened, which might not be what we want.

I think for 1) I was thinking of using on: pull_request so that it can serve as a check that runs after every additional commit is added so that we know if we're in the clear before merging into dev (or main for that matter). For 2) I was thinking of on: push, so that only after merging into main` will we go ahead and publish the official closeread docs and make the release.
Does that make sense?

Just to catch things up here, 1) and 2) were implemented and merged into dev in https://github.com/qmd-lab/closeread/pull/104 . I'm going to close this issue for now (knowing that we'll probably amend one of the actions in the future to make the release).


StructComparer ignores Config.CompareProperties

Hello,
Thank you for this library :)
I'm comparing with fields enabled and properties disabled, something like:
new ComparisonConfig()
        {
          CompareFields = true,
          ComparePrivateFields = true,

          CompareProperties = false,
          ComparePrivateProperties = false,

          CompareStaticFields = false,
          CompareStaticProperties = false,

          MaxStructDepth = int.MaxValue,
          ...

        }

but I'm still getting stack overflows due to cycles via struct properties, e.g.
struct Foo {
  Bar bar;
}

struct Bar {
  ...
  public Foo AsFoo => ...
}

I've had a quick look at the source and noticed that ClassComparer has:
                //Compare the properties
                if (parms.Config.CompareProperties)
                    _propertyComparer.PerformCompareProperties(parms);

                //Compare the fields
                if (parms.Config.CompareFields)
                    _fieldComparer.PerformCompareFields(parms);

but StructComparer is missing the ifs:
                _fieldComparer.PerformCompareFields(parms);
                _propertyComparer.PerformCompareProperties(parms);

I guess this is the problem?
Side note: The default of having MaxStructDepth set to 2 and silently considering more deeply nested values equal seems a little dangerous (since it can make tests falsely succeed). Maybe the default should be a bit higher and exceeding the max depth should throw an error by default or return an inconclusive result?

Please create a fix and check in with a corresponding unit test.

Fixed.  Now throws an exception when MaxStructDepth is higher than 5.


Updating FAQ

Modified the bit about account creation

@JoeMartis is this good to be merged?

Yes – thank you!
From: Tasawer Nawaz<EMAIL_ADDRESS>Reply-To: mitocw/openlearninglibrary-theme<EMAIL_ADDRESS>Date: Wednesday, August 26, 2020 at 2:28 AM
To: mitocw/openlearninglibrary-theme<EMAIL_ADDRESS>Cc: Joe Martis<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [mitocw/openlearninglibrary-theme] Updating FAQ (#72)
@JoeMartishttps://github.com/JoeMartis is this good to be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mitocw/openlearninglibrary-theme/pull/72#issuecomment-680685948, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAY54FY3L3I53FZYCYT7NHLSCSTRNANCNFSM4QJPB4XQ.


Diffusion Prior?

Does the diffusion prior need to come from the pretrained model in the README, or can we swap in any prior?
That is, assuming the prior works with whatever code is loading it.  So for instance if I wanted to swap in another Latent Diffusion model than DALLE-2-pytorch.

It currently supports the DALLE-2 prior whose parameters you can edit by changing the following lines in the config
# Text-Image Prior Related
prior_path:  weights/model.pth            # Path to weights for the prior network, not used if prior_path empty
# prior_path:                             # Leave empty like this to use only text prompt

## Parameters for diffusion prior network (code by lucidrains)
diffusion_prior_network_dim: 512
diffusion_prior_network_depth: 12
diffusion_prior_network_dim_head: 64
diffusion_prior_network_heads: 12
diffusion_prior_network_normformer: false

## Parameters for diffusion prior (code by lucidrains)
diffusion_prior_embed_dim: 512
diffusion_prior_timesteps: 1000
diffusion_prior_cond_drop_prob: 0.1
diffusion_prior_loss_type: l2
diffusion_prior_condition_on_text_encodings: false

For any other diffusion model you would need to update the loop.py file under the code commented with
# Setup Prior model & get image prior (text embed -> image embed) to load in the different diffusion model

@NasirKhalid24 I started looking into this and got it working with the huggingface transformers version of CLIP, but the output isn't very good.  It slightly deforms the starting sphere but never gets close to a table in the prompt.  I'm guessing this is an issue with the loss function?  Should I also change the loss function? Is cosine avg because you used DALLE-2-pytorch?

I think you will have to experiment quite a bit with the different parameters and overall methodology. The integration of Stable Diffusion will play a big role since our work does not support anything like it which uses a text -> image generator (instead we use a text embedding -> image embedding generator [DALLE2 prior])

@NasirKhalid24 Shouldn't the CLIP image and text embeddings/encodings used by Stable Diffusion work in the same way, though?

The embeddings may be from CLIP ViT-L/14 which is not a model size that was tested in this work so the parameters needed to make it work may be different

The different CLIP model sizes can lead to different results and I believe stable diffusion may use ViT-L/14 so you would need to adjust parameters to find best ones for this case