[$125]  Deeplink access of user notify me page and back opens wrong page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697014098088459
Action Performed:

Open the app
Open any user report
Click on header and click on notify me
Copy the URL and paste in any report
(For devices without access to URL like native app, we will need to perform step 1 to 4 in device with URL access) Click on the URL
Click on back and observe that instead of opening user details page, it opens room settings and displays user as room

Expected Result:
App should navigate back to user profile on back from notification preference page
Actual Result:
App navigates back to room settings instead of user profile on back from notification preference page when accessed by deep link
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/93399543/0e4ed89a-a4d0-4bf0-9a2f-cd3c836e5304

Android: mWeb Chrome

https://github.com/Expensify/App/assets/93399543/f346580c-f0df-4994-9c47-ffddfed31218

iOS: Native

https://github.com/Expensify/App/assets/93399543/1afdeb1a-4fea-4f9a-8508-94ef1d8ab166

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93399543/c0f89ef1-ce69-454f-af2a-0c8a091319e7

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/365552da-9ce6-47a9-9e5b-6f4ddbda54be
https://github.com/Expensify/App/assets/93399543/1a983d3e-1290-478a-ab63-2b246585cce7

MacOS: Desktop

https://github.com/Expensify/App/assets/93399543/8a9ba6d5-0cc5-46a6-8b90-98249428281b

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0169068d72e6fa963b
Upwork Job ID:<PHONE_NUMBER>598991872
Last Price Increase: 2023-11-07

isOneOnOneChat function seems more future-proof and robust for me. @ishpaul777 could you update tour original proposal with suggestions you form in later comment? After that I think the proposal will be ready to go 🚀

@ishpaul777 proposal has been updated - @robertKozik will review

Thank you @ishpaul777! Your proposal is ready to go.
🎀 👀 🎀 C+ reviewed

I see nobody confirmed this was a bug yet.
I almost wanted to say this is the expected behavior based on our navigation design.
https://github.com/Expensify/App/blob/main/contributingGuides/NAVIGATION.md#adding-rhp-flows
@mountiny what is your take?

This also makes it sound like the navigation code should already handle this - so I'm unsure why we are writing more custom logic.

I think I agree with @ishpaul777 in this case it seems like we use this page in two flows and we should update the fallback route accordingly.

Ok so the navigation code does handle it. And we just provided the wrong "fallback". Got it. Thanks guys!

@robertKozik @ishpaul777 I am going OOO this next week. If we need a new reviewer please ask in Slack! Otherwise I will look at this as soon as I return.  🤙

@ishpaul777 how is the PR going?

Payouts due:
Issue Reporter: $50 @dhanashree-sawant ( reporting bonus stopped on the 24th but this was reported on the 11th)
Contributor: $125 @ishpaul777
Upwork job is here.

@robertKozik any steps needed for the BZ checklist or can we close?

Sorry for delay on my end @adelekennedy  🙇🏼  I don't think we need regression test here

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It's not a regression rather the not handled properly navigation case
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. I don't think it's needed here
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A


USMs created with WannaCRI cannot be opened by official SDK

Using the official SDK found here, https://archive.org/details/new-criware-sdk you can't open the usms generated with WannaCRI in the USM viewer included in the SDK, might be an interesting thing to investigate.
You can also create official USMs with this tool, which could be useful for reverse engineering purposes.

It does not come with usm-break, the tool that encrypts the USMs, but I do know someone with access to that tool (they cannot share it as of now) and they have offered to supply USMs encrypted with the official encryption, if that's something you'd want

Hi, thanks for reporting the issue. I'm still thinking if I should look at the SDK. So for now let me ask you some questions.
Can you give more information about how you made the usm that was incompatible with viewer? Did you use vp9 or h264? Encrypted or not? Are there any helpful errors that the viewer showed?

I tried unencrypted and encrypted h264 at least, the error was "Unexpected end of file" if my memory serves me

Thanks for the info I think I know the problem. I'll try to investigate on the weekend.
As for your friend who has access to the official tool that encrypts usms. Can you ask them to produce both encrypted and non-encrypted versions of h264, vp9, and other codecs supported by usm. Same goes for usms with audio. I'm also interested in how usm encrypts other media types such as alpha channels, my hunch is that it's the same as normal videos. I'd greatly appreciate if you and your friend can produce and share those videos so I can analyze them.
There are also other usm stuff like subtitles that I'm not sure how it's stored. If those are not in the sdk above, can you and your friend assist on those too? Thanks again!

Of course!! I'll get right on that

https://cdn.discordapp.com/attachments/879231833366204429/1115471413248270406/LuckyStr1948_512kbVP9.usm
https://cdn.discordapp.com/attachments/879231833366204429/1115471413629956217/LuckyStr1948_512kbh264.usm
https://cdn.discordapp.com/attachments/879231833366204429/1115471413965488170/LuckyStr1948_512kbSofdec.usm
https://cdn.discordapp.com/attachments/879231833366204429/1115471546295779388/LuckyStr1948_512kbSofdec.enc
https://cdn.discordapp.com/attachments/879231833366204429/1115471546656497684/LuckyStr1948_512kbVP9.enc
https://cdn.discordapp.com/attachments/879231833366204429/1115471547075919902/LuckyStr1948_512kbh264.enc

These all have subtitles and alpha channels, so that should help! The .enc files are literally just the encrypted .usms.

Also the encryption key is<PHONE_NUMBER>823782 or 0x002341683D2FDBA6 in bytes

Thanks, I'll take a look at these. Apologies for the delay

Hey, any update on this? Just curious!

https://cdn.discordapp.com/attachments/879231833366204429/1185599541408440410/CRI_Sofdec2_Tools_Manual.7z
https://cdn.discordapp.com/attachments/879231833366204429/1185599541756579891/Wizz_File_Information_Viewer.7z
Hey here are some miscellaneous documentation and a small tool that just tells you details about USM files


 is broken

The documentation states that any components enclosed with a <scrollArea></scrollArea> element should become scrollable. However when including such an element in a component, nodejs complains with a UnhandledPromiseRejectionWarning: Error: No known component for element scrollArea. when starting the application.

Good catch. This is a simple fix; just need time to apply it.
Will involve updating the registry of components to include scrollView: https://github.com/nodegui/svelte-nodegui/blob/main/src/dom/nativescript-vue-next/runtime/registry.ts
... and updating the Svelte NodeGUI JSX intrinsic typings: https://github.com/nodegui/svelte-nodegui/blob/main/src/svelte-nodegui.ts
Looks like the component would be an RNScrollArea under-the-hood: https://github.com/nodegui/svelte-nodegui/blob/main/src/dom/react-nodegui/src/components/ScrollArea/RNScrollArea.ts

It might be a bit more subtle than this. I applied those changes on a fork of your code (with a few other adds to https://github.com/nodegui/svelte-nodegui/blob/main/src/index.ts and https://github.com/nodegui/svelte-nodegui/blob/main/src/dom/react-nodegui/src/index.ts).No more errors during execution, but... the scrollArea (and its child) do not appear :-(

After a bit more testing is seems that scrollArea is kind of working but there are some strange size issues with both scrollArea and its child. See PR #53 (added scrollArea and updated demo to highlight the current problem).

Agreed that there are size issues with both. I'm not immediately sure why. First https://github.com/nodegui/svelte-nodegui/issues/42 needs to be solved, to ensure that child nodes are being added correctly in the first place (which particularly impacts the<text> component). But it's odd that I was unable to get <scrollArea> to work properly even when simply adding a <view> child to it. This is going to be a tough one to get to the bottom of (though I do completely understand the necessity to get this component working!).

@johanalkstal is this what you were experiencing with regular NodeGUI? Does ScrollArea not work for you?
We're experiencing problems trying to get it to do anything sensible in Svelte NodeGUI and I'm wondering whether the problem stems from NodeGUI itself or not.

Some possibly relevant issues:

https://github.com/nodegui/react-nodegui/issues/341#issuecomment-792515899
https://github.com/nodegui/react-nodegui/issues/342
https://github.com/nodegui/nodegui/issues/592#issuecomment-792264782

@johanalkstal is this what you were experiencing with regular NodeGUI? Does ScrollArea not work for you?
We're experiencing problems trying to get it to do anything sensible in Svelte NodeGUI and I'm wondering whether the problem stems from NodeGUI itself or not.

The issue I have is similar to https://github.com/nodegui/react-nodegui/issues/342
That is, I try to use QScrollArea with a QWidget as its child, and the QWidget contains dynamically added QLabels, but the scroll bars don't appear.


Lazy loading and added entities

I assume this is a design decision rather than a real issue, but I'm curious as to the reasoning, and suggestions for handling it. In a DbContext with lazy loading enabled I can fetch an entity, then navigate from that entity to a related entity and the related entity will be loaded for me. If I create a new instance of the first entity, using the Create method to get a proxy, set the related entities foreign key field then add it to the context, the related entity will not be lazy loaded. We're running into this as an issue in a project we're migrating from ObjectContext. The issue is particularly a problem in library routines. For example, just hit one that takes an entity and transforms it, hitting a related entity in the process. When the client calls this with a created entity it fails if they set the related entity by foreign key, as opposed to by assigning the entity

@kev160967 Can you post a complete code listing or project that reproduces what you are seeing?

Not at my desk at the moment, but here is a quick example I have running in Linqpad. If it helps I'll post a sample project when I'm back in the office tomorrow. In this example, Booking entities have a relationship to Content items through the property ContentClass:
    Partial Public Class Booking
        Public Property ContentClassID As Integer  // FK property for ContentClass property
        Public Overridable Property ContentClass As Contents

This code lazy loads the Contents entity, and allows you to access the IsEmpty property:
var booking = BookingSet.First(x=> x.ContentClassID == 1);
(booking.ContentClass?.IsEmpty == null).Dump();

This code does not - ContentClass simply returns null:
var booking=BookingSet.Create();
BookingSet.Add(booking);
booking.ContentClassID=1;
(booking.ContentClass?.IsEmpty==null).Dump();

In the last example calling ChangeTracker.DetectChanges(); before examining the property will load the ContentClass entry. It makes no difference whether you include the BookingSet.Add() call or not

I have created a small test project that illustrates the issue.  In the first it creates some test entities. In the second it loads the parent then lazy loads the related entity. In the third it creates a parent, sets the FK property to a related entity, then tries to navigate to the related entity
LLTest.zip

@kev160967 Thanks for providing more details. EF6 and all earlier versions of EF do not do lazy loading for entities in the Added state. The main reason for this is that Added entities are tracked differently than other entities and don't have real keys. They also don't fixup in the same way. This means that the general case of lazy loading becomes inconsistent. In your case, where an Added entity is on the dependent end of a relationship and it's FK has been set, then it would be possible to do lazy loading correctly. However, even then, we haven't seen much demand for this, and given that it would make it inconsistent in ways that only make sense if you really understand what is going on under the covers, we decided to just not do lazy loading for Added entities.
If Create is used to create the instance and Attach is used to track it as Unmodified, then lazy loading should work as normal. So the workaround if you really need lazy loading for Added entities is to temporarily put the entity in the Unchanged state while doing the loading, then switch it back to Added.
Closing this because this behavior would be be a breaking change and would not necessarily make the experience better given that lazy loading for Added entities would still not work in many cases.

Understood Arthur. In our case though it does unfortunately mean we have to remain with ObjectContext. Alternatives would be to either make knowledge of the repository available in places where it is currently hidden, or to remove all exposed foreign key fields from the model. Neither of these are an option, so we're stuck.
One final thought - are there any hooks in place for intercepting this behaviour (I assume not), or would such hooks be an option at any point going forward?


Remove Google Drive URL in spider dataset

The spider dataset is distributed under the CC BY-SA 4.0 license.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Unable to create Postgresql trigger function using ResourceDatabasePopulator

ResourceDatabasePopulator resourceDatabasePopulator = new ResourceDatabasePopulator();
resourceDatabasePopulator.addScript(new ClassPathResource("init.sql"));
resourceDatabasePopulator.populate(connectionFactory).block();

fails when init.sql contains
create or replace function item_added_trigger() returns trigger as $psql$ begin perform pg_notify('item_added', NEW.id::text);return NULL;end;$psql$ language plpgsql;

because ScriptUtils splits the statement based on ; and tries to run
create or replace function item_added_trigger() returns trigger as $psql$ begin perform pg_notify('item_added', NEW.id::text)

which is not a valid statement

As far as I know this is exactly how the database populator is supposed to work.
If you still think there is a change required please create an issue at https://github.com/spring-projects/spring-framework/issues


Fix for issue #188, moved to Java 7

Demo run also works again with the visualisation

@villgust can you check that this also runs correctly on your machine?


Allow CurlTest to be executed by schedule using CronJob

let's add new field in spec, like
spec:
schedule: "*/1 * * * *"

on second thought it seems like CronJob is not the best approach. Let's try to implement similar logic via #17


Connect wallet to account

Feature: user can connect with MetaMask plugin. After that, fetch other information about this public address such as Balance, ...

Improve: add instruction to start the Appwrite backend and setup frontend in frontend/README.md
Change: move REACT_APP_ENDPOINT and REACT_APP_PROJECT to frontend/.env. Add the environment file to ignore list.
TODO: for future work: support more wallets: Coinbase, ... Add style.

Getting the ETH from the backend does not seem to work for me. I have run the database setup python script for the eth database collection, uploaded the function to appwrite, set the function ID, and the function is executed when I connected my address (can see that in the appwrite UI), but when I reload the page, the address is not autoloaded. The button says "Connect MetaMask wallet" and after clicking on it the info is retrieved from MetaMask again. Taking a look at the code in my debugger, I found that nothing is returned. After I added an entry to the collection manually for the user with that ID, I finally got a response, but nothing of use was displayed in the frontend, i.e. only the following
Did you have the set-wallet routine working?
Can you test if the set-wallet works for you? That function is not easy to work with. Remember to set the appwrite URL for that function as the actual IP address (not the public but the local one, i.e <IP_ADDRESS>) otherwise it will not work.

please merge the request, and create an improvement issue. I got enough with this issue.

Okay, you can merge it on your behalf. This took long already.


Vue transition-group not working with slots?

Version
2.6.7
Reproduction link
https://jsfiddle.net/gmanish/L3y8j57s/
Steps to reproduce
See that there's a  within an opening/closing transition-group tags in the tabs component template.
Click on the tab headers to switch between tabs.
What is expected?
Expected to see the transition between tabs happening with the specified transition out-left.
What is actually happening?
While the tab contents switch as expected, the transition-group seems to have no effect. The transitions are not rendered.

Similar flattened code, i.e. without the components and slots, works just fine.
I ran into this issue while trying to create a carousel slide component with transitions left-out/right-out transitions depending on whether we're moving to the next/previous slide.

transition-group are for lists of elements but you are displaying only one at a time. I imagine you saw a warning on the console upon initial render telling you to switch to transition-group and that's what you changed it to it but your use case needs a transition component as only one view is visible at a time.
The approach you are using is very hacky, relying on the $children is very fragile. Here is another approach using named slots: https://jsfiddle.net/er45s0ag/ (you can use transition-group too), you can automate more things like setting the key if you use render functions and have selected state in tab using inject/provide
Your issue reminded me of https://github.com/vuejs/vue/issues/5661#issuecomment-301078575 btw

The referenced comment above, seems to indicate that transition-group doesn't work with v-show. However, I have a working example here:
https://codesandbox.io/s/lp4yo72q39?fontsize=14
The structure is essentially the same, except there are no components and slots. This works just fine.
Btw, the $shildren logic was picked up from laracasts.com, which I thought was a reliable place to learn Vue through screencasts.


Change user in apps with login using email

Prestashop, Ghost and Odoo login using the email instead of the user, in these cases we should change the value of the current variable user to the email user @ example.com.
@prydonius @sameersbn

@carrodher thanks, would it be possible for you to split this into 3 different PRs? It's easier to test and avoid conflicts that way. Also, remember to bump the chart version as well.

Thanks, of course, I'm going to close this PR and send 3 separate ones


Adds parameter to chart directive, lets user access to DataTable

An idea to allow the user to define a function that will be given the response given on success as defined here
https://developers.google.com/analytics/devguides/reporting/embed/v1/component-reference?hl=en#datachart-events
Also the options they passed in to the chart to easily redraw the chart
I used this because I was using the ga:pageviewsPerSession metric and wanted to round the result to 2 decimal places.

for future pull requests --> please use develop branch (i am using gitflow)


Fixes #122: Apply filtering consistently

This change makes the following changes:

The list of FrameworkMethod returned from getChildren() is a flat list of subclasses of FrameworkMethod, one per test method. Parameterized methods return a ParameterisedFrameworkMethod, non-parameterized ones return a NonParameterisedFrameworkMethod, if an error occurs during analysis it returns a DeferredErrorFrameworkMethod.
The ParameterisedFrameworkMethod has a list of child InstanceFrameworkMethod and implements Filterable.

A lot of special code in JUnitParamsRunner has been removed to use the default behavior from ParentRunner/BlockJUnit4ClassRunner. I also removed ParameterisedTestClassRunner and ParameterisedTestMethodRunner which makes the flow a little simpler, it is still a little convoluted.
I added a test to check for consecutive application of Filter instances and fixed a minor issue with naming in TestMethodTest.
It passes all the tests but I do not know whether every aspect of its required behavior was covered by the tests. In particular I am concerned about JUnitParams.flat, ignored tests and changes in the ordering of error conditions.

Hello, thanks for your PR. We looked through it but we are not sure what goal you're trying to achieve.

filter some of generated params test for single method like

@Parameters("a|b|c")
@TestCaseName("{method}_{0}")
public void testMethod(String parameter)

and using filter matching exactly by testMethodName you would like to run only e.g. testMethod_a. So in the example JUnitParams will generate 3 methods
testMethod_a
testMethod_b
testMethod_c
and after filtering you would like to run only
testMethod_a

Or maybe you want to achieve something else and we are not on the same page.

Your code generates better description for each test (description contains also parameters) but it does not solve problem described in 1)

This fixes the issues described in #122. The main one being that currently filters are applied differently to getDescription() than to getFilteredChildren(). That means that the set of tests that getDescription() says will be run are not actually the set of tests that are actually run.
e.g. After applying the ShardFilter to your above example getDescription() might return:
testMethod
    testMethod_a
    testMethod_b
    testMethod_c

But getFilteredChildren() might return the following tests:
    testMethod_a
    testMethod_c

I will rebase, fix merge issues and upload a new fix soon.

I'm afraid you don't get exactly our point. We tested your PR and in fact it changes how Description objects are return from getFilteredChildren() but still you cannot achieve a goal that you would like to filter few parameters from one parametrized method (e.g. to rerun only those which failed). Please look once again in example @woprzech provided - filtering one method for single parameter (e.g. parameter a in testMethod) is not possible in master and neither your PR.
But maybe problem is that you are trying to achieve something else and from description in #122 we are not sure what - please correct us if we are doing wrong assumptions.

This looks suspiciously like what I would do to fix #52 (which is definitely not fixed).
Specifically, it overrides describeChild() in JUnitParamsRunner such that the test cases get named correctly so filters apply correctly, allowing test cases to be rerun.

I am still a little confused as to what it is that you think this is trying to do. It is possible that there's a bug in my code which means that it is not doing what I expect it to either.
Do you have a test, that fails with my change that you expected to work? Something that I can paste into my local repository, run, debug etc.


Added support for MacOS

Lowercase "arial" threw an error, and MacOS doesn't have a startfile function

Lowercase "arial" threw an error, and MacOS doesn't have a startfile function
Thanks for your contribution.
but this gives an error on windows: "OSError: cannot open resource"

I experienced the issues @Brithub  mentioned. I have tested with his branch and it works well. Thanks for the fix

Added a conditional to the font name, silly that it matters

Added a conditional to the font name, silly that it matters

it still returns error when generating word cloud
Generating Word Cloud.....
Traceback (most recent call last):
  File "C:/Users/Yifeng/Desktop/Personal-YouTube-PDF-Report-Generator-master/report.py", line 244, in <module>
    visual.wordCloud()
  File "C:/Users/Yifeng/Desktop/Personal-YouTube-PDF-Report-Generator-master/report.py", line 88, in wordCloud
    max_words=380,contour_width=2, prefer_horizontal=1).generate(unique_string)
  File "C:\Users\Yifeng\lib\site-packages\wordcloud\wordcloud.py", line 619, in generate
    return self.generate_from_text(text)
  File "C:\Users\Yifeng\lib\site-packages\wordcloud\wordcloud.py", line 601, in generate_from_text
    self.generate_from_frequencies(words)
  File "C:\Users\Yifeng\lib\site-packages\wordcloud\wordcloud.py", line 434, in generate_from_frequencies
    max_font_size=self.height)
  File "C:\Users\Yifeng\lib\site-packages\wordcloud\wordcloud.py", line 483, in generate_from_frequencies
    font = ImageFont.truetype(self.font_path, font_size)
  File "C:\Users\Yifeng\lib\site-packages\PIL\ImageFont.py", line 640, in truetype
    return freetype(font)
  File "C:\Users\Yifeng\lib\site-packages\PIL\ImageFont.py", line 637, in freetype
    return FreeTypeFont(font, size, index, encoding, layout_engine)
  File "C:\Users\Yifeng\lib\site-packages\PIL\ImageFont.py", line 186, in __init__
    font, size, index, encoding, layout_engine=layout_engine
OSError: cannot open resource

Same problem on linux

Apparently "arial" != "ariel"


feat: add omegaconf dict and list as input to DotDict

This PR adds support to cast omegaconf.DictConfig and omegaconf.ListConfig to DotDict

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (2837ecd) to head (e6ea4d6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #61   +/-   ##
========================================
  Coverage    71.86%   71.86%
========================================
  Files            7        7
  Lines          263      263
========================================
  Hits           189      189
  Misses          74       74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Provide labels in fcc

I think it would be better if we can provide custom labels as input in the fcc, which if not provided defaults to the usual 1, 2, 3, 4, etc

Sure, my initial thoughts were to keep this simple and have labels be equivalent to the number key input. Since the GUI now also features buttons for mouse input it’s more feasible to add this...
I use fcc actually for multiple purposes:

rate the quality/ suitability of an image that is already in the right class (I.e. 1 high quality, 2 ok, 3 kinda bad etc)
indicate different scopes (I.e. 1 full guitar, 2 only the headstock and neck, 3 only some details of the model)
one could also use it for plain classification (as I think you have in mind), however for me this is already achieved by giving multiple lines (each line for one class) to fcd

I wanted to see If I can contribute in any way. Like a quick change of few lines but then I see there's classes and class methods which I have little experience with ( I use functions normally ) and I was like "continue this maybe sometime later".
Also I have little experience with tkinter 😅

I was doing the fastaiv3 course on deep learning and there arose the need to to create a dataset

No worries. I like the idea... I might give it the shot this weekend actually. Not sure how hard it is to implement this with tk 🤔
I’m no expert either and it still feels pretty archaic to me...
However, as said you might be able to achieve this with fcd alone (if your search queries are for each individual class) and only use fcc to remove bad/ wrong images after the download...

One could simply read a small config file for naming the buttons, but I’d aim to have this as an interactive operation within the GUI itself...


Authorization_IdentityNotFound Error

Hi I keep getting the Authorization_IdentityNotFound Error when I try to run the application from Visual Studio. I registered my app on the azure portal, added in all the graph permissions (and got admin consent) and added a secrets file as stated on the readme? Do I have to do something with get the authentication token? I am using an office 365 developer account.
Thanks,
Ryan

What's the full error message? The Airline sample uses both application permissions and user delegated permissions, so it needs two consents -- I'm guessing one of those is missing. The first stack overflow hit  for Authorization_IdentityNotFound was for missing consent for application permissions.

Yea I saw that on stack overflow as well, but I think I have all the application permissions (unless if I am missing something):

Here is the error I get. I am able to log in once I run the app, and I get to the page where I can select different routes and air crew members, but once I click on 'Create Team', this is what shows up:

I'm not seeing anything obvious. I'm going to need to call in some AAD experts -- could you post this on stack overflow and send me the link? Thx.

Hi sorry for the delay. Here is the link to the stack overflow post I made.

did this ever got resolved? seeing the exact same thing...

Since the issue isn't specific to this sample this is best discussed on Stack overflow.


chore: Minor improvements to the task modals

This refactors the layout for task modals, adds missing icons, and also adds a quickstart button for the tasks that have a quickstart associated with it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.68%. Comparing base (2e6ea7d) to head (7514618).
 Consider uploading reports for the commit eef1249 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   81.63%   81.68%   +0.04%
==========================================
  Files          74       74
  Lines        1552     1556       +4
  Branches      483      487       +4
==========================================
+ Hits         1267     1271       +4
  Misses        248      248
  Partials       37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Taskize Connect tutorial doc to reflect change of Reply URL

The help.taskize.com domain now redirects to docs.taskize.com, please can we update the documentation to reflect the change in required Reply URL.
Evidence of the redirection:
$ curl -v https://help.taskize.com 2>&1 | grep location:
< location: https://docs.taskize.com/

@jeevansd
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jeevansd please could I ask you to review this change? Many thanks


Persist instances

Problem
Right now, if you restart the web application, all instances are reset. The Nomad jobs will keep running but they are not visible in Broccoli.
Solution
Persist instances.

I don't need to persist on each status change as the status gets updated automatically anyway.


Add whitelist label option.

This adds the Whitelist label option to ghprb's advanced options.

If both Whitelist and Blacklist label options are entered, it works in 'AND' mode. In other words, PR should not have Blacklist label and Whiltelist label should exist.

If nothing is entered in the Whitelist label option, this option is ignored.

I think adding the Whitelist label option can help solve the #210 issue in the future.

Bug Fix Included (#441)

LabelField's empty string check problem.

Https://github.com/sjstyle/ghprb-plugin/commit/c54a32cb01d897c207a1f531aa3873f8ab70e044#diff-4b618248c9f9a59094a30a1212e2d172R170
Previously this plug-in did not check for Empty on this line. As a result, when the user enters a setting value, a non-null space is input, so the empty collection is always returned and the Label Check part is activated.

pr.getLabels method problem.

Https://github.com/sjstyle/ghprb-plugin/commit/c54a32cb01d897c207a1f531aa3873f8ab70e044#diff-70706d3124e337b7f717ad901c08d53aL178
Previously this plugin called the pr.getLabels () method. It seems that we would expect only the labels to be returned because of the get prefix, but in fact this method is supposed to do something else.
Https://github.com/kohsuke/github-api/blob/github-api-1.80/src/main/java/org/kohsuke/github/GHPullRequest.java#L130-L133
This is where calling fetchIssue ().
https://github.com/kohsuke/github-api/blob/github-api-1.80/src/main/java/org/kohsuke/github/GHPullRequest.java#L297-L302
It changes this in this part. This changes the object from <api> / {user} / {repo} / pulls to <api> / {user} / {repo} / issues.
I think this is supposed to be the #441 problem.

Hi @sjstyle thanks a lot for the pull request!
Could you also add some tests that go over some of the different conditions/use cases? For example,

Whitelist is set and blacklist is not set (and vice versa)
Both whitelist and blacklist are set
And then various matches of the above for the pull request...

Our team is developing web applications in the company. The team is using the GitHub Pull Request builder for two purposes. (I have created two GitHub Pull Request Projects.)
First, run the test automatically for each pull request to ensure that the test did not fail. It is reasonable to run the test on every commit, and I think it is good because there is no need to leave a comment.
Second, when you open a pull request to get a quick result, Docker Container Build is executed and the URL that can check the result is left as a comment.
During this process, several Pull Requests were created, and Docker Build was executed for every commit, so the URL Comment that the Pull Request Builder left on success came as much as spam. (If we do not leave a URL in the comment, we will not know which URL will allow access to the Container, as there are multiple Docker Servers in our team.)
In most back-end development, there was a desire to have Docker Build run only in pull requests that the "team wants" because it can be checked to see if it was created correctly as a test. However, the function "AS-IS" in the plug-in was all "Blacklist Label", which was the conclusion that it was necessary to explicitly attach a specific label when creating most pull requests.
To improve this inconvenience, I developed "Triggering only whitelist labels" feature and labeled it "Docker Build" so that the Docker Build Trigger responded. This makes it possible for the team to attach a label to only the pull requests that they want to check for results, thereby reducing unnecessary builds and resource consumption.

Oh, I misunderstood. I'll add some test soon.

@benpatterson
I add whitelist label test, whitelist and blacklist label test.

CC @udisch
@sjstyle I suggest you rebase on top of #449. We can focus on getting that done, then we can look at adding a whitelist.

Oh, and instead of rebasing, it might be easier to create a new PR off of that branch. Whatever is easier for you and however comfortable you are with git.

@benpatterson
I just rebased re-implement-label-support-ignorelist branch. (I think it is easier than make new pull request) If you think it is better make new PR rather than rebase, I will make new PR tomorrow. (My local time now is 01:00AM..)
I'll back soon.

hi guys, I'm excited about that feature! Can we add it asap to the plugin and release new version? Looking forward to see it next days :+1:

@benpatterson
I removed check dirty pull request logic and upgrade github-api version.

Hi Sang -
Great. I'll plan to give it a look this week.

@sjstyle Ok this is coming along. Could you add job DSL support?
CC @udisch as well.
I'm planning on putting everything together in a PR like #455, but neither of you would have access to that branch, so you'd have to develop on one of your forks. Thanks again for the help.

@benpatterson
I have no write access on this repository, so I added some commit in this pull request.
And, I think GitHub is better than Github, So I made new casing commit instead of using yours.
I also added JobDsl support, but I didn't test it. (Our team using only webhook trigger...)

@sjstyle just pinging. I'm still working on this. I think we'd be better off if the job DSL for labels could accept a list, much like the other white/black lists. That's what I'm working on.

Merged as part of #464
Thanks again for the help.


Change ENJ crowdsale address to token address.

The address for the ENJ token was added incorrectly.
The user committed the crowdsale address: https://etherscan.io/address/0x9b73D1779C41DcA36314fB7c4D3309838e20C4E7
Instead of the token address: https://etherscan.io/token/0xf629cbd94d3791c9250152bd8dfbdf380e2a3b9c

Already fixed & live. Thanks!


fix: use documented Platform.version for backwards compat

Overview
The Platform.constants added in #871 is not available in RN versions before 0.61 as reported in #879. Platform.Version is still there, and it's documented so I've switched to that instead.
Test Plan
Going to ask @alemarra89 if they can install this branch and test that it resolve the issue.

Btw this'll affect both platforms @MateusAndrade I think

Btw this'll affect both platforms @MateusAndrade I think

Sure, since it's in JS code even iOS will get this error. :/

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add InvisibleSymbols Fixer

fixer for #2601

Hi !
Thanks for raising it that fast !
It's a great start for a fixer !
IMO, we should make it configurable, allowing to fix any of 3 types:

comments (remove odd whitespaces inside comments)
whitespaces (remove odd whitespaces from other whitespaces)
strings (so case you found initial issue)

that way one may want to fix only whitespaces or whitespaces+comments, but not strings (he could desire odd chars in them in edge cases)
also, be aware that if token would be empty after dropping odd spaces - we should remove whole token (could happen only for T_WHITESPACE token)

@keradus IMO does not need to configure it - if we found this symbols in the code it's a copy-paste mistake or we do some real strange.

Nice fixer idea, love to see this in.
I was thinking about proposed configuration and just thinking out loud here, maybe we could make generic 'NonPrintableCharacterFixer' (name can change of course) ?
We could than merge the 'line_ending' fixer in this as well.
Than we could add configuration of character mapping, for example:

\r\n => \n
\r => ''
0xe2 => ' '

We allow configuration for 'T_ENCAPSED_AND_WHITESPACE, T_END_HEREDOC, T_OPEN_TAG, T_WHITESPACE, T_COMMENT, T_DOC_COMMENT, T_START_HEREDOC, any thing else' to give control about what should be fixed (making the fixer risky by configuration).
WDYT?

@SpacePossum change name, about tokens - a good solution would be to process all text in one strtr, but I do not know how to do it.

a good solution would be to process all text in one strtr, but I do not know how to do it.

it's not a good solution. it's slow solution that will have to revisit all content even if we don't want to modify most of it.

@SpacePossum , about your idea - it may indeed be nice to have next General*** fixer that could be used inside different fixers, like we already do eg with GeneralPhpdocAnnotationRemoveFixer.
Then, this one, tabs to spaces, line endings, could be rewritten to use that General***.
But let us keep it outside of scope of this PR.

added remove empty tokens
added isAnyTokenKindsFound
I not sure about type tokens list in isAnyTokenKindsFound, please check it and if it wrong tell me correct list for fix

please fix deprecations

broken only in php 7.2 because <7.2 in composer

That's not true. Read the error log.
Failing because of trailing whitespaces in:

./tests/Fixer/Basic/NonPrintableCharacterFixerTest.php:62: ./tests/Fixer/Basic/NonPrintableCharacterFixerTest.php:66: function f(string $p) ./tests/Fixer/Basic/NonPrintableCharacterFixerTest.php:71: ./tests/Fixer/Basic/NonPrintableCharacterFixerTest.php:75: function f(string $p)

@ivan1986 Actually Travis build fails because there are trailing whitespaces like here (quite ironic 😁)

Thank you @ivan1986.


Menu improvement

First commit removes the idea folder from git.
The other commits makes the menu nicer and less buggy, then with the current timer based solution. Please check it out ;)!

Next time please do pullrequests to development or master. Gh pages is the "production branch"

I didn't know, I will do next time :+1: !


update_a_custom_field_value_for_contact incomplete

Hey there, just an FYI, the endpoint update_a_custom_field_value_for_contact is not complete in the tool. The fields that are in active campaign are very basic and do not even include the address, so this is something that will commonly be used if updating a custom field for a user.

Here is the working code for the function. Please update if you could:
def update_a_custom_field_value_for_contact(self, data):
    return self.client._post("/fieldValues",json=data)


Fixes for the Launch system tutorial.

Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

@Mergifyio backport galactic


make compute[Picking]Colors fast

reduce code duplication, reduce memory allocations, update a Uint8Array directly rather than creating tons of JS arrays and calling flatten() each time. since these functions must run every single frame when picking is enabled and the user is moving their mouse quickly, this makes a big difference.
fixes #301
see that bug for details on how i measured the following frame rates:
before: 3 FPS in debug mode

CPU bound, with most of the time spent in isFlattenable and baseFlatten, which are both called from flatten.
after: 20 FPS in debug mode

flatten is gone, and most of the time is now spent in getError, which goes away once we disable debug mode. (i left it on to get an apples to apples comparison.)
tldr; mousing over my choropleth map with 1600 regions and 200k total vertices is smooth now

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@shaojingli @ibgreen

https://dcpos.ch/yimby/zoning/

@dcposch The possible concerns with merging this PR into main would be that:

this is already being addressed in a more comprehensive way in the next deck.gl version (the new PolygonLayer with the PolygonTesselator class that minimizes unnecessary copying and array creation).
there are several ChoroplethLayers (32 bit, 64 bit, extruded, enhanced) - doing this for one of them will bring them further from each other.
There has been work done on dev on making ChoroplethLayers work with Immutable.js data - which requires care when iterating over polys and verts. This will likely interfere with that.

However, since the next release is some time out, it might still be reasonable to merge this in as a temporary fix on master. For now please look at the review comments.

Closing.

ChoroplethLayers are deprecated in v4 and will likely be removed in v5 so we don't want to change them unless for a critical bugfix.
Instead we are trying to incorporate the idea here into the v4 documentation and a sample layer to show how layers can be subclassed to do things like this.


KV listing with a limit parameter reads too many items

kv.Store.Scan does not take a limit parameter "hint".  So it reads some
fairly large number of items from the underlying store.  For DynamoDB KV
this is apparently whatever number of items it takes to fill 1 MiB; for
PostgreSQL this is 1000 items.
So whenever the listObjects API is called with a small limit it fetches many
more objects than it should.  A very typical use-case in lakeFSFS is to call
listObjects for just 1 object!  This triggers the worst case, and is slow.

The listObjects api endpoint takes amount argument and actually returns the desired amount. The problem is with the query.
For the postgress case example:
I see that in the code it calls s.Pool.Query(..., $LIMIT) which value of s.Params.ScanPageSize which is 1000, then it returns an iterator of type EntriesIterator.
Instead we should propagate that amount param to the Scan function that calls the query and $LIMIT should be:
min(s.Params.ScanPageSize, userInput.Amount).
Will passing this parameter via ctx is reasonable to the Scan(ctx context.Context, partitionKey, start []byte) function?

@Isan-Rivkin sounds good, one slight change, min(s.Params.ScanPageSize, userInput.Amount+1) some scanners go one step further in order to return the hasMore value


feat: add owenrumney/squealer

owenrumney/squealer: Telling tales on you for leaking secrets
$ aqua g -i owenrumney/squealer

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ squealer --help
Telling tales on your secret leaking

Usage:
  squealer [flags]

Flags:
      --commits-file string    Provide a file with the commits to check per line (git rev-list master..HEAD)
      --concise                Reduced output.
      --config-file string     Path to the config file with the rules.
      --debug                  Include debug output.
      --everything             Scan all commits.... everywhere.
      --from-hash string       The hash to work back to from the starting hash.
  -h, --help                   help for squealer
      --no-git                 Scan as a directory rather than a git history.
  -f, --output-format string   The format that the output should come in (default, json, sarif.
      --redacted               Display the results redacted.
      --to-hash string         The most recent hash to start with.

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.130.0

out of curiosity: how do you identify old versions where a correction is needed?

I mainly check the number of assets of each release.
If the number of assets is changed, probably the setting is changed.
And I check release pages by the binary search method.

aqua gr supports specifying the version. This is useful to support old versions.
$ aqua gr<EMAIL_ADDRESS>packages:
  - type: github_release
    repo_owner: owenrumney
    repo_name: squealer
    asset: squealer.{{.OS}}.{{.Arch}}
    format: raw
    description: Telling tales on you for leaking secrets
    supported_envs:
      - darwin
      - amd64
    rosetta2: true
    checksum:
      type: github_release
      asset: squealer_checksums.txt
      file_format: regexp
      algorithm: sha256
      pattern:
        checksum: "^(\\b[A-Fa-f0-9]{64}\\b)"
        file: "^\\b[A-Fa-f0-9]{64}\\b\\s+(\\S+)$"


iTunes or Spotify starts occasionally when pressing ESC

Sometimes iTunes or Spotify start when pressing ESC within IntelliJ IDEA if are not started

Seems this is related to the in-Java execution using the ScriptEngine. Should be fixed with #5 allowing users to choose the preferred AppleScript execution method.


Update project structure to account for growing needs

This is the pull request to #22
There are still some bugs in the GCloud implementation, i.e.

F821 Undefined name shecreds :28
F821 Undefined name Request :29

Now, to further progress with this project, the different uploading mecanisms should be implemented. Also, some type hinting might be useful.

Thanks @HomerusJa! Your PR is under review. It may take a while as it is the weekend. 😎


Add DC to simple progression with attached stat.

Hi,
I have a player who found a book of knowledge that she can unlock in stages. This would be the perfect thing to do with your module.
What I would like to do is the following.
Set number of checks (not rolled stats like 16 int check until 200 or so) in my case she has to do 6 checks with changing DCs to successfully unlock the tome.
stage 1 2 DC 10 Int checks
stage 2 2 DC 15 Int checks
stage 3 2 DC 20 Int checks
I would love to track successes and failures of the check in the training tabs.
So I would know what she successfully unlocked.
Thanks for your hard work. Keep going!

This is really interesting! I can probably implement the DC's without too much difficulty, but stages will require a bit of an overhaul, so that'll come a little later. I'll shoot for v0.4.0 with the DC's (hopefully this weekend or next, depending on how much time I have) and try to figure out the best way to implement stages once I have some time to think about the best way to accomplish it. Stages with different progression types is something I was looking at a while back, so I'll definitely get to it at some point.
If you need a way to track this in the meantime, you can set up a series of Simple progression activities like this:
Name: Stage 1, Attempts: 2
Name: Stage 2, Attempts: 2
Name: Stage 3, Attempts: 2
Then have her roll the checks manually and if they succeed, have her add a success to the appropriate stage.
Thanks for the suggestion!

Cool that it will come in the future and I will use the workaround you suggested for the moment.


WIP: re-introduce ARM build

The ARM build has been failing due to build performance issues.
DO NOT MERGE
This work-in-progress PR is temporarily used for testing to attempt the ARM64 build.

What's going on with the arm build? I understand there were some performance issues but can somebody provide more info? Perhaps I can help (personal interest on getting this running as arm cloud servers are becoming more popular as cheaper alternatives).


HV-1828 ContributorValidationMessages compatible with UTF-8 properties

fix proposal from https://hibernate.atlassian.net/browse/HV-1828

Sorry it took me so long to have a closer look at this.
I pushed an additional commit to your branch but it doesn't appear in the PR. I created https://github.com/hibernate/hibernate-validator/pull/1154 , let's continue the discussion there.


Move classes from spark-accumulo-library that are not specific to Accumulo to spark-library

There are some classes in spark-accumulo-library which are not specific to Accumulo. These should be moved to spark-library. The unit test FilterToOperationConverterTest should be changed so that it tests that the correct operations are created, rather than testing that those operations give the correct results when applied to an AccumuloStore. This will allow that unit test to also be moved to spark-library.
There should be unit tests for the various converters, e.g. FreqMapConverter. We should also create converters for the Union sketch from DataSketches.

Merged into develop.


update latest datafusion.

Which issue does this PR close?

Closes #176 .
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

You'll need to update to the same version in the new python crate as well

I would like to go straight to arrow-rs 21.0.0 now that is is released if that's okay with everyone. I have a working version here: https://github.com/spaceandtimelabs/arrow-datafusion/tree/bg_arrow_21 I'd be happy to PR.

I would like to go straight to arrow-rs 21.0.0 now that is is released if that's okay with everyone. I have a working version here: https://github.com/spaceandtimelabs/arrow-datafusion/tree/bg_arrow_21 I'd be happy to PR.

Thanks for your advice, I think ballista should follow the datafusion realease version, all there will be two version arrow-rs in repo. The main reason i want to upgrade is to update tonic, for get some new feature test in ballista.

LGTM overall.

Have fixed the wrong github yml file

@andygrove  when change the return type of
 fn state(&self) -> Result<Vec<AggregateState>> {

got
^^^^^^^ the trait `pyo3::FromPyObject<'_>` is not implemented for `std::vec::Vec<datafusion::datafusion_expr::AggregateState>`

Could you give me some info about this 🤔


⚠ Processors has degraded performance

In 8b0c838, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 46 ms

Resolved: Processors performance has improved in 61b6c56.


Replace optparse with argparse

optparse is deprecated since python 2.7

I don't really mind either way, but the reason I never changed this was because Click is based on optparse. It also looks like optparse is deprecated but won't be removed, only no longer developed.

Alternatively, maybe we deprecate Werkzeug's CLI? I'm not sure anyone even knows about it. I was certainly surprised when I discovered it while doing some other work on that file. It doesn't appear to be documented in any version of the docs currently hosted.


Flushing stdout in the end of signal handling

Hi,
When I'm using the SignalHandling to print stack traces on signals, I sometimes get only a few lines out of the trace, and the app crashes before the whole trace is printed.
I think it might be because there is no stdout flush in the end of the prints, and the app crashes with lines in his print buffer.
Does that make sense? Is it possible to flush it?
Thanks,
Tom

It prints to stderr. That's usually not buffered, so it should print directly. And even in the case of buffered output, it any \n character should cause the buffer to be flushed. It's very possible that the program is crashing before everything is printed. It could also hang. A lot of the code allocates dynamic memory which could fail in various ways if you had a raised signal (e.g. segmentation fault) in one of the memory allocation routines.
If you want reliable error reporting, you'll have to code it yourself using one of the unwind libraries and only use async-signal-safe functions (see: https://man7.org/linux/man-pages/man7/signal-safety.7.html). Apparently, Boost also has boost::stacktrace::safe_dump_to(), so that could work here.

And even in the case of buffered output, any \n character should cause the buffer to be flushed.

This assumption is reasonable for an interactive terminal. But for any other output it depends on the size of the buffer. With that said, when the program terminates, everything should be flushed anyways.
But std::cerr is supposed to flush out everything all the time (https://en.cppreference.com/w/cpp/io/cerr). Making this point moot.
@Tomotz I suggest you add some flush operations to the Printer in "backward.hpp". And see if it helps in your situation. Somebody else proposed to add flushing too in #259 as an example.
It is more likely that you have a bug/memory corruption somewhere.
And as @oold said, if you want a much more reliable error reporting in face of threads, async and signal safety in general, you should write/find/use code that respect this all the way.


faster hmac initialization on sbcl

Provide more type info so SBCL can compile MAKE-ARRAY more efficiently.

Thanks!


Create VS Code snippet for new sorting box 190 x 130

Create uses and Box190() and Box130()
Idea: Create from part list a uses list - for the future

scad.json in VS Code Snippets


[Feature] Confirm msg on Feedback

Description
To Create a styled alert box for the confirmation message.
Use JavaScript to display the message, add a class for the alert styles, and set a timeout to remove it after 3 seconds.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done

I want to take this up this issue if you are not solving...please assign me this issue

@swaraj-das I've already submitted the PR


Update old lighthouse comment instead of posting a new one on every commit

Codecov Report

Merging #148 (fa19614) into main (f6671cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   77.72%   77.72%
=======================================
  Files          21       21
  Lines         202      202
  Branches       33       33
=======================================
  Hits          157      157
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6671cf...fa19614. Read the comment docs.


add MIST token

Project official website: https://alchemist.farm/

Project official social: https://twitter.com/_alchemistcoin

@guo I already made the changes to the extraction request, you can verify it. Thank you

All works!


question

trie must be loaded all in the memory? is not possible to load a part of the trie in memory  and a way to flush the trie motification in the file without to write all the trie ?

Yes, all tries in trie4j keep all data on memory. You have to divide parts of TRIE tree manually to support partial loading.


Visual

Pull Request Test Coverage Report for Build 171

28 of 85 (32.94%) changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 59.829%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pdftotree/TreeExtract.py
6
11
54.55%

pdftotree/visual/visual_utils.py
13
65
20.0%

Files with Coverage Reduction
New Missed Lines
%

pdftotree/TreeExtract.py
1
84.89%

Totals

Change from base Build 158:
-1.2%

Covered Lines:
1470

Relevant Lines:
2457

💛  - Coveralls


how can i use rancherOS in aws china as an ami image

hi rancher team, do you think to support china aws, so i found the ami image in global aws except china. so when can china use, so how can i using rancher iso file to create a ami image??

China region is not formal public accessible, so I recommend you can make it by yourself
http://aws.amazon.com/ec2/vm-import/

@wenzizone It sounds as if @SydOps has provided a valid solution.
Let me know if you have further questions.


Clarify whether Java is a supported language

From the README.md:

Multiple languages: Odo supports Node.JS, Ruby, .Net Core, Perl, PHP and Python.

Is it true, that Java isn't supported by odo? If it actually is, it should be added to the list of supported languages, given our huge portfolio of Java-based middleware software (WildFly/EAP, Vert.x, ...).

@gunnarmorling You're right. We should add Java but in quotations / brackets add that it supports Wildfly,EAP, etc.)

Why is the commit not yet merged on master ?


namespace updated to kubescape(default) for kubescape-host-scanner ds

Overview

Removed the manifest to create namespace from file charts/kubescape-cloud-operator/assets/host-scanner-definition.yaml and updated the manifest of kubescape-host-scanner DaemonSet for namespace.
How to Test
Deploy the kubescape-cloud-operator.
Related issues/PRs:

Resolved #61

Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
[x] New and existing unit tests pass locally with my changes

Merged in #149


Modified hours layout

When adding several modified hours, it wraps and the delete icon doesnt line up well.
Can we make this a single column of modified hour entries, and fix the delete icon alignment?

Hey @jdbranham
Here is PR, please have a look.
https://github.com/savantly-net/franchise-manager/pull/72


added  api

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

Hi @alestor123 😄
Thank you for your contribution. ✋
I noticed that there is a conflict in your pull request and you deleted the fork from this repository, so it will not be possible to resolve it. Consider creating a new pull request if you still want to add this API to be reviewed and added to our listing.

Ok ive opened another one with no conflict you may please check it


Support for Dataflows

Hi Chris,
Any chance of adding support for Dataflows to the library?
Thanks,
Michael Stone

Hi Michael,
Absolutely - feel free to make the contribution if you would like.
Here is the documentation for the Dataflows REST API, which has a very similar pattern to the existing APIs the library supports.
https://docs.microsoft.com/en-us/rest/api/power-bi/dataflows

Hi Chris,
Unfortunately my Python skills are not good enough, especially in terms of the classes stuff.
Cheers,
Michael


Added: youtube-dl-downloader-app

add sample application for download youtube video or audio file with use ytdl module
how to use this program : https://github.com/dydgns2017/emulator-file-test

@Chhekur
node_modules remove and then modify readme.md file
Thank You for your review!

@Chhekur
node_modules remove and then modify readme.md file
Thank You for your review!


Need to run npm install after create-react-app has run when using npm

When trying to do what the README says using npm:
$ npm install -g bs-platform
$ npx create-react-app <app-name> --scripts-version reason-scripts
$ cd <app-name>
$ npm start

I got the following error:
Failed to compile
./node_modules/reason-react/src/ReactDOMRe.js
Module not found: Can't resolve 'bs-platform/lib/es6/caml_builtin_exceptions.js' in '/home/frederik/projects/reason-test/node_modules/reason-react/src'
This error occurred during the build time and cannot be dismissed.

This seems to be due to the fact that create-react-app does not install all required dependencies as the following will work as expected:
$ npm install -g bs-platform
$ npx create-react-app <app-name> --scripts-version reason-scripts
$ cd <app-name>
$ npm install
$ npm start

Is this a bug in the project setup or is it expected to be done like this and the missing npm install needs to be added to the README?
For the record this is my setup:
➜  reason-test npm -v
6.1.0
➜  reason-test node -v
v8.11.3
➜  reason-test npm list -g bs-platform
/home/frederik/.npm-global/lib
└──<EMAIL_ADDRESS>

Hi @m90, thanks for filing this issue! We're hard at work on a new version of reason-scripts trying to fix this issue once and for all, and in the meantime you can try out the beta version that fixes this by creating your app with
npm create-react-app <app-name> --scripts-version reason-scripts@next

In the meantime, we recommend you check out the Help, Tips, and Tricks, where we have a guide on what to do if your app isn't building right after creating it.

Using reason-scripts@next works as expected, thanks. Looking forward to 1.0.0 :tada:


Update single-cell topic layout and content

Include news
Make into columns
Improve workflow formatting

@nomadscientist since it looks like you tried to include an agenda, how does this look?

@nomadscientist feel free to hit merge if the agenda/toc looks good to you, or let me know if you'd like adjustments


Columns missing

Details
Since about two days my Homepage is all in one column.
I tried different settings all with the same result.

Steps to reproduce
Open my home page
Debug information
{"version":3,"homepages":{"Main Homepage":{"value":"Admin/Home","kind":"File","openOnStartup":true,"hasRibbonIcon":true,"openMode":"Replace all open notes","manualOpenMode":"Keep open notes","view":"Reading view","revertView":true,"refreshDataview":true,"autoCreate":true,"autoScroll":false,"pin":false,"commands":[],"openWhenEmpty":true,"alwaysApply":true}},"separateMobile":false,"_defaultViewMode":"default","_livePreview":"default","_focusNewTab":"default","_plugins":["table-editor-obsidian","obsidian-bible-reference","obsidian-book-search-plugin","calendar","dataview","obsidian-file-color","file-explorer-note-count","obsidian-footnotes","obsidian-icon-folder","obsidian-kanban","obsidian-languagetool-plugin","media-extended","nldates-obsidian","periodic-notes","obsidian-tasks-plugin","templater-obsidian","obsidian-tracker","homepage","obsidian-banners"],"_internalPlugins":["file-explorer","global-search","switcher","graph","backlink","canvas","outgoing-link","tag-pane","properties","page-preview","daily-notes","templates","note-composer","command-palette","editor-status","bookmarks","outline","word-count","file-recovery","sync"],"_obsidianVersion":"1.4.16"}

Checklist

[X] I updated to the latest version of the plugin.

What are you using to create the columns? I’d guess it’s probably an issue with that instead of Homepage unless it’s stopping the plugin from loading or something…

Thank you for your response. I found the error. One style file was missing.
Sorry, my mistake.


chore(main): release blog 0.3.0

:robot: I have created a release beep boop
0.3.0 (2024-09-23)
Features

added more labels in the Dockerfile - this is helpful for dependabot (230e327)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

blog-v0.3.0
:sunflower:


Route Rules need to be sorted in priority order in module net-lb-app-ext

Describe the bug
In the urlmap_config variable, the route_rules nested under path_matchers are being used as an iterator for a dynamic block here: link.
We are having problems with this approach. When defining priority, the order of the elements is important as the GCP API requires rules be sorted in increasing-priority order. Using toset() does not allow us to pass the list in any particular order, so Terraform sorts it. In our case, it kept sorting a rule with priority 120 above a rule with 119, breaking it.
Environment
Terraform v1.7.1
on darwin_arm64
+ provider registry.terraform.io/hashicorp/archive v2.4.0
+ provider registry.terraform.io/hashicorp/google v4.84.0
+ provider registry.terraform.io/hashicorp/google-beta v4.84.0
+ provider registry.terraform.io/hashicorp/random v3.5.1
+ provider registry.terraform.io/hashicorp/tfe v0.50.0

output from `git rev-parse --short HEAD`

9f5bf954

module source = "github.com/GoogleCloudPlatform/cloud-foundation-fabric//modules/net-lb-app-ext?ref=v28.0.0"

To Reproduce
Define a URL Map Config and create multiple route rules of varying priorities under a single path_matcher.
Expected behavior
Route Rules are defined in the supplied order/priority
Result
Error: Error updating UrlMap "projects/my-project/global/urlMaps/my-lb": googleapi: Error 400: Invalid value for field 'resource.pathMatchers[0].routeRules[1].priority': '119'. Within a pathMatcher, a route rule must have a priority that's higher than the previous route rule's priority, invalid

Additional context
I was able to work around the problem by converting the route_rules variable type from list(object) to map(object) and removing toset() from the the module in a fork and set the priority as the key but this is also a flawed approach as maps are sorted in lexicographical order so a map of {1: "test", 3: "test", 120: "test" is sorted
"1" = "test"
"120" = "test"
"3" = "test"

I'm not sure what the right solution to this is, hence this issue.

Full repro, using examples:
module "compute-vm-group-b" {
  source     = "./fabric/modules/compute-vm"
  project_id = var.project_id
  zone       = "${var.region}-b"
  name       = "my-ig-b"
  network_interfaces = [{
    network    = var.vpc.self_link
    subnetwork = var.subnet.self_link
  }]
  boot_disk = {
    initialize_params = {
      image = "cos-cloud/cos-stable"
    }
  }
  group = { named_ports = {} }
}

module "compute-vm-group-c" {
  source     = "./fabric/modules/compute-vm"
  project_id = var.project_id
  zone       = "${var.region}-c"
  name       = "my-ig-c"
  network_interfaces = [{
    network    = var.vpc.self_link
    subnetwork = var.subnet.self_link
  }]
  boot_disk = {
    initialize_params = {
      image = "cos-cloud/cos-stable"
    }
  }
  group = { named_ports = {} }
}

module "glb-0" {
  source     = "./fabric/modules/net-lb-app-ext"
  project_id = var.project_id
  name       = "glb-test-0"
  backend_service_configs = {
    default = {
      backends = [{
        backend = module.compute-vm-group-b.group.id
      }]
    }
    other = {
      backends = [{
        backend = module.compute-vm-group-c.group.id
      }]
    }
  }
  urlmap_config = {
    default_service = "default"
    host_rules = [{
      hosts        = ["*"]
      path_matcher = "pathmap"
    }]
    path_matchers = {
      pathmap = {
        default_service = "default"
        route_rules = [
          {
            priority = 3
            service = "default"
            header_action = {
              request_add = {
                test-priority-3 = {
                  value = "prio-3"
                }
              }
            }
          },
          {
            priority = 10
            service = "default"
            header_action = {
              request_add = {
                test-priority-1 = {
                  value = "prio-1"
                }
              }
            }
          },
          {
            priority = 2
            service = "default"
            header_action = {
              request_add = {
                test-priority-2 = {
                  value = "prio-2"
                }
              }
            }
          }
        ]
      }
    }
  }
}

Fails with expected:
│ Error: Error updating UrlMap "projects/*/global/urlMaps/glb-test-0": googleapi: Error 400: Invalid value for field 'resource.pathMatchers[0].routeRules[1].priority': '2'. Within a pathMatcher, a route rule must have a priority that's higher than the previous route rule's priority, invalid

@cavila-evoliq
My idea how to solve this, is to replace the problematic for_each with:
        for_each = { for value in m.value.route_rules : format("%010d", value.priority) => value }

This way, the keys when sorted in lexicographical are still in the same order as numerical order. Can you confirm that this solves your issue?

Wouldn't it be easier to just use the list in the for_each?
This seems to work:
locals {
  rules = [
    { priority = 2 },
    { priority = 3 },
    { priority = 10 },
    { priority = 150 },
  ]
}

resource "google_compute_url_map" "urlmap" {
  name            = "urlmap"
  default_service = "service"
  project         = "myproject"

  path_matcher {
    name = "name"
    dynamic "route_rules" {
      for_each = local.rules
      content {
        priority = route_rules.value.priority
      }
    }
  }
}

Terraform will perform the following actions:

  # google_compute_url_map.urlmap will be created
  + resource "google_compute_url_map" "urlmap" {
      + creation_timestamp = (known after apply)
      + default_service    = "service"
      + fingerprint        = (known after apply)
      + id                 = (known after apply)
      + map_id             = (known after apply)
      + name               = "urlmap"
      + project            = "myproject"
      + self_link          = (known after apply)

      + path_matcher {
          + name = "name"

          + route_rules {
              + priority = 2
            }
          + route_rules {
              + priority = 3
            }
          + route_rules {
              + priority = 10
            }
          + route_rules {
              + priority = 150
            }
        }
    }

For some reason I thought dynamic blocks had the same for_each restriction as resources and would require being converted to a set, I assumed that's why it was done in the first place. But yeah, lists maintain their order so since the dynamic block accepts a list, that would be the ideal solution.

@cavila-evoliq can try #2096 and confirm if it works for you?

For some reason I thought dynamic blocks had the same for_each restriction as resources and would require being converted to a set, I assumed that's why it was done in the first place. But yeah, lists maintain their order so since the dynamic block accepts a list, that would be the ideal solution.

I was under that impression too but the docs say The for_each value must be a collection with one element per desired nested block. So a list is fine.
@wiktorn We should probably check if we have the same issue in other dynamic blocks elsewhere

Just tested the changes in our dev environment and it works great!

Awesome. It's merged into main now so I'm closing this.
Thanks for the report @cavila-evoliq!


Standardize the description of icon-vector-cog at navbar.

Automated message from Dropbox CLA bot
@rht, it looks like you've already signed the Dropbox CLA. Thanks!

Nice, merged, thanks @rht!


Introduce Resque_Job_PID so a process PID can be obtained.

echo Resque_Job_PID::get($token);

Thanks for prompt review - all fixed, good to review again.

Ha, missed that. Thanks for catching :-) How about now?

It's an interesting feature for sure.  Everything looks good from here, though it'd be nice to have some way to detect whether the PID belongs to the worker itself or not, and modify the return value accordingly...
All said, :+1:

Pray, what happens next? :-)

Now we wait for @chrisboulton to have enough time free to properly review the PR himself, give any feedback he might have (if any), and decide whether to merge.  This is the part that requires patience, I'm afraid.

Allright. /pulls out his cigar, cognac, and settles on the armchair by the fireplace.

Hi! Thanks for the contribution and working through the things @danhunsaker mentioned.
To be honest, this seems to fit a very specific use case, and would be the kind of thing I'd suggest is something that's implemented as a plugin using the appropriate hooks (if there aren't the right ones there, lets fix that), rather than something that should be supported in core functionality?


Get reliable body response on error.

Certain responses (pretty JSON) cause issues when you try to explode the raw response. This affects the Google provider in my experience. Using the getBody method should be more reliable.
Might be related to #193.

Any thoughts on this @ramsey or @alexbilbie? This is causing breaking issues for me when using the Google+ provider.

Sorry, @dolfelt. I was traveling when you submitted this and haven't been able to look yet. This fixing the breaking issues you were seeing?

@ramsey Yep. The problem is that the error response coming back from Google is formatted JSON. The JSON itself has line breaks in it.
When using this:
$raw_response = explode("\n", $e->getResponse());
$response = end($raw_response);

It causes the $response object to come back as }, rather than the whole JSON object.

Thanks, @dolfelt!


Missing PHP 8 in matrix

Hi, I checked https://github.com/shivammathur/setup-php#cloud-osplatform-support and would propose to add PHP 8.0
WDYT?

Those are PHP versions which are pre-installed on the runners, PHP 8 is not.

But I can use PHP 8.0 even if its not pre-installed on the runner? Same for 5.6?

Yes, you can currently use from PHP 5.3 to PHP 8.1. If the version is not pre-installed setup-php installs it.
https://github.com/shivammathur/setup-php#tada-php-support

Thank you!


Near ideal barrel rolling checks

Only consider comment lines as barrel rollable, make sure "barrel" and "roll" are written one after another, and convert line to lower case before using it to allow Capitalized or ALL CAPS lines to roll too.
Also addresses #1 since lines with code are excluded.

That should do it. Thank you.

Why only comment lines? I think splitting line by first "#" character would allow for lines with code to work too
Would be a cool improvement


Support for local calendars

Feature Request
The calendars of many people in different parts of the world are local and specific to that place. Is it possible to personalize the calendar (for courses) and change it to Chinese/Hijri(Lunar)/etc? For a functional localization, it is necessary to convert all dates to the local/national calendar used by the user:

@perpi We are using Django's tempate formatters for dates so this should be handled correctly by Django. Have you tried setting the date to arabic in the settings?

by 'setting', you mean the openedX settings, for example here: https://edxapp.demo.richie.education/account/settings ?

No I meant in the Django settings of your Richie instance e.g. here for our sandbox: https://github.com/openfun/richie/blob/master/sandbox/settings.py


The command should fail if post-success fails

To reproduce try running with --post-success "gibberish".
This is important, because otherwise your ci builds will succeed even if, for example, npm publish fails.

Hi Michal, Fyi this is the PR which introduced the post-success as normal script, not necessarily npm script.
https://github.com/leonardoanalista/corp-semantic-release/pull/36/files


Add basic HEIR website

It's a hugo site with the docsy theme, some basic placeholder content, and a github workflow that publishes to the gh-pages branch when main is touched.

Tested at https://j2kun.github.io/heir/


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: matheusmartino sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


PWN-4806  - Country name minor fix

Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-4806
Description of Work
[ what work was done in this ticket ]
Screenshots (Optional)

Screenshot #1
Screenshot #2
Screenshot #3

[Paste Pic 1]
[Paste Pic 2]
[Paste Pic 3]

This bug was not closed in this MR cause problem was not in xml file) @1sakov


Clarify error message when merkel dag is not found

Fixes https://github.com/ipfs/website/issues/85

There's a typo, it's "merkledag", not "merkeldag".

This PR is also not going to the parent project, you're trying to merge to your fork.

Thanks. New try here https://github.com/ipfs/go-ipfs/pull/4099
Good greif git is a PITA when you can't fast forward. It would've been faster for me to just nuke my entire repo and clone everything again.


Could Not Load Module Error

I have an existing ASP.NET Web Forms app which I'm trying to add Glimpse to. I ran the following NuGet package command as it says in the Quick Start on the website.
"Install-Package Glimpse -Pre"
And all it did was add a reference to my project references, but did not make any modifications to my web.config. I manually added the appropriate Module and Handler methods, but I now get the following error:
Could not load type 'Glimpse.Core.Module' from assembly 'Glimpse.Core'.
When I look at the Object Browser and look at the Glimpse.Core namespace, there is no Module or Handler class.
I was able to uninstall the RC of Glimpse, and install the .87 version, and that worked as advertised. Unfortunately, I want the Timing functions, which seem to only be in the RC. I uninstalled the 0.87 version and tried the RC again and am getting the same issues.

I am experiencing this problem as well. I did run install-package Glimpse.MVC5, and also Glimpse.AspNet and Glimpse.EF6. The web.config is updated with <system.webServer> with add module and add handler for glimpse. The assembly references include Glimpse.Ado, Glimpse.AspNet, Glimpse.Core, Glimpse.EF6, and Glimpse.Mvc5.


Getting current user for a given FileSystem?

I'm building a custom FileSystem provider using cloud storage, and I need to be able to pull the current FtpUser authenticated by the membership provider. I can't seem to find any way the file system is able to know anything about the current user (or connection) except the username, which isn't very useful for my purposes. Is this possible or do I just need to re-create the FtpUser within the FileSystem class?

This is indeed something I didn't need yet, but it would be a very useful addition.
You have two options here:

You can fork this project, create your custom IFtpUser implementation, change the IFileSystemClassFactory, etc., etc.
You can create your own singleton service that allows storing additional user information and the mapping from a user name to this information.

Option 2 might work, but has limitations that you can live with. Option 1 is the better (clean) solution.


Sort dependencies in metadata

This patch sorts the dependencies in the metadata of Cython extensions. This is mostly useful when looking at the JSON dump of the metadata in the generated C file: the dependencies are no longer in arbitrary order (making diffs less useful).

Looks fine; thanks.


How to load a hasMany relationship?

I have a route that loads a primary model and displays one of its hasMany relationships. I want to use ember-infinity to paginate the hasMany relationship. Currently, my template simply calls {{#each model.children as |child|}}. What do I need to modify in order to make this work with ember-infinity?

Hi @andrewhavens !
Currently we can't do that out of the box - Ember Infinity has a hard dependency on there being an paginated endpoint for the model you're actually displaying.
There's various ways to get around this, but the path of least resistance is to add/modify an API endpoint for your child model, like so:
host.com/api/child_models?parent_model_id=231&per_page=5&page=1

That way you can use a param (or bound param, if it's dynamic) for parent_model_id and paginate that relationship.
Please reopen if this doesn't solve your issue!

I think part of my question was simply how to change from a single model route to a route that returns multiple. I ended up with something like this. Posting it here in case it helps anyone else in the future.
# in coffeescript:

  model: (params) ->
    Ember.RSVP.hash
      parent: @store.findRecord('parent', params.parent_id)
      children: @infinityModel 'child', parent_id: params.parent_id, modelPath: 'controller.model.children', perPage: 20, startingPage: 1

perfect!

Above solution is not working for me. API request is still going to:
host.com/api/children?per_page=5&page=1&parent_id=1