chrono feature to allow library users to either use time or chrono dependency

The chrono feature brings in the chrono crate as a dependency & uses it to reimplement all date & time functionality. In essence, it uses chrono::DateTime<chrono::FixedOffset> in Expiration::DateTime rather than time::OffsetDateTime (FixedOffset seems to best match OffsetDateTime’s offset field), and chrono::Duration rather than time::Duration.
The time feature (which becomes a default feature) represents the library’s previous behavior, implementing date & time functionality using the time crate. Gating it behind a feature lets users opt out of using that crate, and into using the chrono crate instead.
In order to let the library continue working with default-features = false, all date & time functionality is gated behind either of these features. So too is some other functionality that relies on date & time functionality, such as “removal“ cookies. In order to avoid adding a lot of noise to doctests those too are gated behind the time feature.
This is a breaking change, given that it effectively removes all date & time functionality when neither feature is enabled, e.g. when default-features = false. Given that the cookies crate did not previously have default features, it seems plausible that few were actually disabling those. When time is enabled (which in many cases it will be as a default feature), none of the changes are breaking.
All regular tests pass, but I have not had the opportunity to run the fuzzers yet.

I went ahead an implemented this as I understood that it might be welcome from a comment by @SergioBenitez in #109. In another comment, @jhpratt express concern that the features wouldn’t be additive, but IIUC strictly either feature on its own is additive — they’re just mutually exclusive, for which the Cargo Book carves out an exception.
On a final note, also discussed in #109, removing the use of time::Duration (or chrono::Duration for that matter) in favor of std::time::Duration would clean this PR up a bit: the max_age stuff wouldn’t need to be feature-gated.

There's no way this can work. The features need to be truly additive - there is no exception for crates that are used as transitive dependencies. Imagine a crate Foo that depends on crates A and B where A depends on Cookie with chrono and B depends on cookie with time. Foo will fail to compile, and there's no recourse.
The only way to add support for chrono and/or time is to create independent cookie time types that wrap either of the types and allow conversions to/from the types. When a feature is enabled, the respective conversions are implemented. Thus you can use both features at the same time.
I'm not sure if a T: Into<cookie::Duration> bound would work, however. I'd be worried about the impls that appear based on features messing up inference. But we can try and test.

Understood and agreed.
I could try and see if I can make your suggestion work. However, if we’re already going the way of independent cookie time types, I think we should go all the way and remove all types from time crate from the public API. We’d still need either the time or chrono crate for parsing†, and we could gate conversions behind time & chrono features (modulo your concerns about inference).
†As long as we have it handy we can and should use one of those crates for formatting as well, but we wouldn’t strictly need the crate, since cookie only ever formats string using parsing::FMT1 which we could could conceivably do ourselves. Moot point, though.

I could try and see if I can make your suggestion work. However, if we’re already going the way of independent cookie time types, I think we should go all the way and remove all types from time crate from the public API. We’d still need either the time or chrono crate for parsing†, and we could gate conversions behind time & chrono features (modulo your concerns about inference).

I agree, though I still think we need to provide conversion impls and pick a crate, any crate (could even be std::time) to do the parsing for us. I don't think we want to get into the business of maintaining (and debugging...) time parsing or manipulation.
In short:

If we could back our internal types on std::time, that'd be great (though we might not be able to due to limitation of those types). And then by default we'd introduce no new dependencies.
Provide two features: time and chrono, which enable conversions from the relevant types to our internal type.
Test whether we can safely have polymorphic functions like fn max_age<T: Into<Duration>>(self, value: T), where Duration is the internal type and any of time::Duration and crono::Duration and cookie::Duration work as a value. Here, "safely" means that enabling a feature cannot prevent existing code from working. The danger is that enabling a feature enables a new impl which might mess with inference. We need to test/read.

For what it's worth, I did offer to have a shared Duration type between time and chrono specifically for cases like this. The offer was rejected.

It's not just Duration, unfortunately. We also need proper dates for expirations, and parsing of said dates.

Closing in favor of moving forward with #217.


bug: wagmi says account is connected when metamask is locked

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.4.6
Current Behavior
Looks like a regression of #444 (changing the methods with the current ones in version 1.x ofc).
Expected Behavior
To not have a connected status if metamask is locked, or show the metamask prompt to the user so they know it's currently locked and they need to unlock.
Steps To Reproduce

Go to https://wagmi.sh/examples/connect-wallet and connect using metamask
Restart your browser
Accessing the connect page again will show your wallet connected, but no network available (since metamask is locked).
If you navigate to a page where a transaction can be done, everything is just disabled, and metamask does not prompt asking for password.

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://wagmi.sh/examples/connect-wallet
Anything else?
This is how it looks when metamask is locked:

Fixed in Wagmi v2 https://github.com/wevm/wagmi/issues/3080#issuecomment-1761972262

Considering version 2 is not yet published and it'll be breaking, wouldn't you release a fix for version 1...?

or at least a workaround @tmm ?


role-binding-id: unable to find in Confluent Cloud

Hi,
We have configured resources manually through the Confluent cloud console so far. Now we would like to use terraform. In order to import the existing role-bindings into the tf state, the command line requires role-binding IDs in the format "rb-abc123". I could not find the existing role-binding IDs from the Confluent cloud console or through the CLI. Could you please clarify?
Thanks,
Hari

Thanks for asking @hari-rad!
It's a temporary limitation that you can't see role binding IDs on both Confluent Cloud Console and CLI.
The easiest solution could be to send a curl using Role Bindings API that would lists them all:
curl --request GET \
  --url "https://api.confluent.cloud/iam/v2/role-bindings?crn_pattern=crn://confluent.cloud/organization={YOUR_ORG_ID}" \
  --header 'Authorization: Basic {TOKEN}'

where

YOUR_ORG_ID is Cloud Organization ID from this page
TOKEN is

(find more details here)
Let me know if that helps.

Wow, that helps! Thank you @linouk23


Fixes for iOS plugin (& ensure consistency w/Android implementation)

Issues addressed in this PR:
Android:

getFirstReferringParams() and getLatestReferringParams() will now return boolean false when no params are available (trying to serialize a null will throw an exception) or when the received object is null. The behavior now matches iOS.

iOS:

initSession will now resolve a promise with the latest param data
logout now resolves a promise
userCompletedAction now resolves a promise, but like the Android equivalent, it is too early (e.g. before we receive confirmation from the server) but I didn’t see a method s.t. I could use a listener to wait for the response.
loadRewards() will now return just an int value instead of a JSON string; it is now consistent with Java
getCreditsHistory() will now return a straight array of entries instead of a JSON string; it is now consistent with Java
generateShortUrl() now returns an object with property “url” instead of a JSON string; it is now consistent with Java
getFirstReferringParams() and getLatestReferringParams() return an object instead of a string, and returns false if no params were available (matches Android)

Outstanding (unaddressed) issues can be found here: https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/issues/80

Thanks so much for the cleanup @pragunvohra


automatic backup doesn't work

i have checked the autonomic backup to remote and also to local but it doesn't seem to work, what is the frequency for it to happen?!

Hi @paymanz,
for me it works. When you hit the save button, a backup is created. It works locally and remotely.
I use gdrive as remote storage.
Best regards,
MauroG86

Very old issue, maybe already fixed. => closed.


Migrate Engine Python scripts to Python 3.

To reproduce: follow instructions at Compiling the engine
A lot of the scripts have code that is incompatible with Python3 and will cause crashes on systems that use Python3 by default when following the engine build process. These are files I came across and fixed when using:
./flutter/tools/gn --android --unoptimized

src/build/config/linux/sysroot_ld_path.py

invalid syntax for print() function
final print() call attempts to concatenate byte string (returned by subprocess.check_output()) and string, causing a crash.

src/build/config/linux/pkg-config.py

invalid syntax for print() function
split() method is being called on byte string (returned by subprocess.check_output()) causing the script to return invalid result from exec_script()

src/build/ls.py

invalid syntax for print() function

src/flutter/tools/gn

compile_commands.write() is being passed byte string (output of subprocess.check_output()). It expects str.

src/build/android/gyp/util/build_utils.py

invalid syntax for print() function

Hi @krishnakeshan
could you please provide the error logs for the cases you described
thank you

Hi @krishnakeshan
could you please provide the error logs for the cases you described
thank you

Hi @iapicca. On my local repo I have made the required changes since they were simple enough so I don't have access to the logs right now (unless I revert my commit and walk through the process again). However, these are pretty straightforward errors given the use of Python3 so if you look at the source files I've mentioned you should be able to see the invalid Python3 lines.
Do let me know if there's anything else I can do.

$ ./flutter/tools/gn --unoptimized
Generating GN files in: out/host_debug_unopt
ERROR at //build/config/linux/BUILD.gn:16:18: Script returned non-zero exit code.
    ldflags += [ exec_script("sysroot_ld_path.py",
                 ^----------
Current dir: /.../src/flutter/engine/src/out/host_debug_unopt/
Command: python /.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py ../../build/linux/sysroot_ld_path.sh /.../src/flutter/engine/src/build/linux/debian_sid_amd64-sysroot
Returned 1.
stderr:

  File "/.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py", line 15
    print "Need two arguments"
          ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Need two arguments")?

See //build/config/BUILDCONFIG.gn:357:33: which caused the file to be included.
  _native_compiler_configs += [ "//build/config/linux:sdk" ]
                                ^-------------------------

Do not.
On Tue, Jun 1, 2564 BE at 6:40 AM Clement Skau @.***>
wrote:

$ ./flutter/tools/gn --unoptimized
Generating GN files in: out/host_debug_unopt
ERROR at //build/config/linux/BUILD.gn:16:18: Script returned non-zero exit code.
ldflags += [ exec_script("sysroot_ld_path.py",
^----------
Current dir: /.../src/flutter/engine/src/out/host_debug_unopt/
Command: python /.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py ../../build/linux/sysroot_ld_path.sh /.../src/flutter/engine/src/build/linux/debian_sid_amd64-sysroot
Returned 1.
stderr:
File "/.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py", line 15
print "Need two arguments"
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Need two arguments")?
See //build/config/BUILDCONFIG.gn:357:33: which caused the file to be included.
_native_compiler_configs += [ "//build/config/linux:sdk" ]
^-------------------------
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/53002#issuecomment-852054939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASP3QW7MG7HSBC4DGAE2P2TTQTBMBANCNFSM4LQ3UFSQ
.

On Tue, Jun 1, 2564 BE at 6:40 AM Clement Skau @.***>
wrote:

$ ./flutter/tools/gn --unoptimized
Generating GN files in: out/host_debug_unopt
ERROR at //build/config/linux/BUILD.gn:16:18: Script returned non-zero exit code.
ldflags += [ exec_script("sysroot_ld_path.py",
^----------
Current dir: /.../src/flutter/engine/src/out/host_debug_unopt/
Command: python /.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py ../../build/linux/sysroot_ld_path.sh /.../src/flutter/engine/src/build/linux/debian_sid_amd64-sysroot
Returned 1.
stderr:
File "/.../src/flutter/engine/src/build/config/linux/sysroot_ld_path.py", line 15
print "Need two arguments"
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Need two arguments")?
See //build/config/BUILDCONFIG.gn:357:33: which caused the file to be included.
_native_compiler_configs += [ "//build/config/linux:sdk" ]
^-------------------------
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/53002#issuecomment-852054939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASP3QW7MG7HSBC4DGAE2P2TTQTBMBANCNFSM4LQ3UFSQ
.

 Apologies missed that this one existed when I filed the migration bug a few months ago.


Insert failed when inserted sql columns contains “system” (missing prepared paramters)

Which version of ShardingSphere did you use?
4.0.0-RC3
Which project did you use? Sharding-JDBC or Sharding-Proxy?
sharding-jdbc
Expected behavior
Insert successfully when inserted sql columns contains “system”
Actual behavior
sharding parse SQL error:
line 2:7 no viable alternative at input '(system'
Reason analyze (If you can)
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
SQL:
insert into template (system, code, name ) values ( ?, ?, ? )
Example codes for reproduce this issue (such as a github link).

@xiyelife I will fix this currently.

@SteNicholas  but sharding parse the insert sql error.   The sql is generated by mybatis automi and it's used in many scenes.   I think it need to fix .

@xiyelife Can you provide all exception info?

Parameters: null, a86b78670b214c1c90daf12c764fae86(String), 樊前(String),<PHONE_NUMBER>06208194(String),<PHONE_NUMBER>9(String), jpaxsdsewrwe123123f(String), null, 111111(String), 11(String), null, 测试地址(String), null, 1(String), null, 2019-12-31 19:56:16.785(Timestamp), null, 111(String)
line 6:29 no viable alternative at input '(cust_id,unique_id,name,ident,mobile,password,reg_time,modify_time,reg_source,reg_app_channel,reg_device_info,status,is_mobile_authed,complate_cust_info,time_inst,time_upd,has_checked,system'

org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException:
### Error updating database.
### Cause: java.lang.IllegalStateException
	at org.apache.ibatis.exceptions.ExceptionFactory.wrapException(ExceptionFactory.java:30)
	at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:200)
	at org.apache.ibatis.session.defaults.DefaultSqlSession.insert(DefaultSqlSession.java:185)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:433)
	... 13 common frames omitted
Caused by: java.lang.IllegalStateException: null
	at com.google.common.base.Preconditions.checkState(Preconditions.java:485)
	at org.apache.shardingsphere.core.rewrite.feature.encrypt.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateNewSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:84)
	at org.apache.shardingsphere.core.rewrite.feature.encrypt.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:62)
	at org.apache.shardingsphere.core.rewrite.feature.encrypt.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:44)
	at org.apache.shardingsphere.core.rewrite.sql.token.generator.SQLTokenGenerators.generateSQLTokens(SQLTokenGenerators.java:78)
	at org.apache.shardingsphere.core.rewrite.context.SQLRewriteContext.generateSQLTokens(SQLRewriteContext.java:85)
	at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.EncryptPreparedStatement.getSQLUnit(EncryptPreparedStatement.java:158)
	at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.EncryptPreparedStatement.execute(EncryptPreparedStatement.java:127)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.ibatis.logging.jdbc.PreparedStatementLogger.invoke(PreparedStatementLogger.java:59)
	at com.sun.proxy.$Proxy120.execute(Unknown Source)
	at org.apache.ibatis.executor.statement.PreparedStatementHandler.update(PreparedStatementHandler.java:46)
	at org.apache.ibatis.executor.statement.RoutingStatementHandler.update(RoutingStatementHandler.java:74)
	at org.apache.ibatis.executor.SimpleExecutor.doUpdate(SimpleExecutor.java:50)
	at org.apache.ibatis.executor.BaseExecutor.update(BaseExecutor.java:117)
	at org.apache.ibatis.executor.CachingExecutor.update(CachingExecutor.java:76)
	at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:198)
	... 19 common frames omitted

@terrymanu
org.apache.shardingsphere.core.parse.SQLParseEngine#parse0
The parsed sql do not has the columns、values and so on. Only has the table name.

I modify locally for adding SYSTEM in the BaseRule.g4(unreservedWord_)  and the sql work well.

@terrymanu
Here is the parse exception, I think that we need to print the parse exception to the logger rather than system out.
line 6:29 no viable alternative at input '(cust_id,unique_id,name,ident,mobile,password,reg_time,modify_time,reg_source,reg_app_channel,reg_device_info,status,is_mobile_authed,complate_cust_info,time_inst,time_upd,has_checked,system'

The keyword SYSTEM is not defined in the lexer file Keyword.g4, I don't think it can be worked fine if you just add it into BaseRule.g4

But my unit test(the above sql) really pased for added.

The keyword SYSTEM is not defined in the lexer file Keyword.g4, I don't think it can be worked fine if you just add it into BaseRule.g4

SYSTEM   has bean defined in the lever file MySQLKeyword.g4(in line 1395), so it works fine.

@xiyelife In MySQL reserved keywords, SYSTEM is regarded as reserved keyword. Therefore, you couldn't use SYSTEM in InsertStatement.

Reserverd keywords can be used in the sql's columns for mysql, such as id/name and so on.

@SteNicholas

@xiyelife In MySQL reserved keywords, SYSTEM is regarded as reserved keyword. Therefore, you couldn't use SYSTEM in InsertStatement.

Reserverd keywords can be used in the sql's columns for mysql, such as id/name and so on.

MySQLKeyword.g4 includes SYSTEM keyword, but unreservedWord_ doesn't include SYSTEM. Do you see the  MySQL reserved keywords? In MySQL 8.0, SYSTEM is reserved keyword. Therefore, the SYSTEM doesn't put into unreservedWord_. I have already questioned @terrymanu yesterday for this keyword. Out decision is that SYSTEM isn't put into unreservedWord_. Thanks.

@SteNicholas

@xiyelife In MySQL reserved keywords, SYSTEM is regarded as reserved keyword. Therefore, you couldn't use SYSTEM in InsertStatement.

Reserverd keywords can be used in the sql's columns for mysql, such as id/name and so on.

Unreserved keywords can be used in the SQL‘s columns for MySQL, not reserved keywords. You put SYSTEM keyword to unreservedWord_ then works well. Please understand this again.

So，how can we do with this issue？ The most popular mysql’s version is 5.x and I have many busi  tables has been used this column，you known that change is hard to the busi technical units.

You just named this column name as
`system`

Not only one SQL，there are many applications whose used the mybatis generator auto created.

Not only one SQL，there are many applications whose used the mybatis generator tools auto created.

Please upgrade the version of MySQL to 8.x, and check the SYSTEM keyword. Currently, MySQLParser is based on 8.x version of MySQL. About adapter to different version of MySQL, it doesn't support. If you indeed need, you could add SYSTEM keyword to unreservedWord_  and compile a version by yourself to use.


Don't assume lodash is globally available in the host

As described in https://github.com/empress/empress-blog/issues/51, bringing a full copy of lodash into the built app adds a fair amount of weight to the published assets. However, before empress-blog itself can be updated to only pull in the lodash functions it uses, empress-blog-casper-template needs to stop assuming import _ from 'lodash'; will work without declaring any such dependency itself 🙂
This change uses ember-auto-import and finer-grained lodash imports to ensure that only the functions it needs are included in the final assets. Once this lands, a similar change can be made in empress-blog itself, since this package will no longer be reliant on it implicitly exposing the lodash module.

It doesn't look like PRs to this repo have gotten much attention in the last year, so I'm going to close this to clear out my personal backlog.

oh hey sorry I actually missed this entirely 🙈 sometimes it's pretty difficult to keep track of all the notifications
There has actually been quite a lot of discussion about empress-blog and issues like this (just not on the Github issues or PRs) and we have a plan on how to move forward with this. Are you still interested in getting this change landed? Would you like me to go into the details of the plan?


Cross-Cutting Concerns via Message Headers

I have a similar project that has some support for cross-cutting concerns (date-time stamp, current user, current user's roles) which you can check out here.
Any interest in rolling those capabilities into MediatR?  I'm aware my implementation for users/roles is for old crappy Membership, but I could create an implementation for Membership and ASP.NET Identity.
As far as I know, it would require some concrete classes in order to add headers to the messages.  If there's some other way to do it, let me know (assuming you're into it).

No - not because I don't do this on every project, but because I'd personally rather document how you can build your own pipeline rather than I supply it myself.
I could go that route, and I thought about it, but those thing are hard, and I wanted to try to keep MediatR's scope as small as possible, does that make sense?

Sorry for the slow reply.  That's cool.  I might consider doing it as an extension package, especially if I adopt MediatR on my own project (assuming that's cool with you).


Wrong host record in CloudXNS

When I use Caddy as an HTTP server in DNS challenge mode, it cannot get certificate of my domain hosted by CloudXNS.
It seems that there is something wrong with record name generated by Lego.
The host record is set to _acme-challenge.example.com.

But CloudXNS will resolve it to _acme-challenge.example.com.example.com.

According to the document of CloudXNS (Chinese version only, sad...), the key host SHOULD NOT contain the domain again.
For example _acme-challenge means _acme-challenge.example.com and _acme-challenge.foo means _acme-challenge.foo.example.com.
Since I don't know GO, I cannot bring a PR. But I think the problem is here:
https://github.com/xenolf/lego/blob/master/providers/dns/cloudxns/cloudxns.go#L139
Hoping you can fix it. Thanks a lot.

Hello, thanks for reporting :+1:
I fixed the bug, you see the tests related to your bug here

domain
host

foo.bar.com
_acme-challenge.foo

bar.com
_acme-challenge


Question - What was changed since 8.1.1?

I've been using github.repos.getByOrg() with basic auth and an internal Github Enterprise platform for about a year now. I recently upgraded this package to 9.2.0 and now getting an empty array for my repos. But if I revert to 8.1.1 it works fine. Any idea what was changed or if I could get the code to work with the latest package?

Do you have some sample code using a public org for me to test?

Closing due to inactivity.


Future projects without next actions should not appear in 'No Next Action' list

I think for "Future" projects it's okay to not have a current next action, so they shouldn't be included in the list of projects displayed by plugins/gsd5/core/ui/no-next-action.tid.

I agree Simon.  I have a commit queued up.

:+1:

Just noticed completed projects were also include. Should be fixed by PR #56.

Thanks Simon... I must have had my eyes closed when I wrote that.


Error handling when html.convert() is used

I'm using code based on direct/tex2svg sample:
    //  Create DOM adaptor and register it for HTML documents
    const adaptor = liteAdaptor();
    RegisterHTMLHandler(adaptor);
    //  Create input and output jax and a document using them on the content from the HTML file
    const tex = new TeX({packages: options.packages.split(/\s*,\s*/)});
    const svg = new SVG({fontCache: (options.fontCache ? 'local' : 'none')});
    const html = MathJax.document('', {InputJax: tex, OutputJax: svg});

    //  Typeset the required TeX equation
    const node = html.convert(texEquation, {
        display: !options.inline,
        em: options.em,
        ex: options.ex,
        cwidth: options.width
    });
    // FIXME: how to get error message
    if (tex._parseOptions.error)
        return '';
    var svgOutput = adaptor.outerHTML(node);
    // FIXME: Isn't it possible to suppress mjx-container tag using some option?
    svgOutput = svgOutput.replace(/<(mjx-container|\/mjx-container).*?>/g, '');
    return svgOutput;

Unfortunately I didn't find out how to obtain errors (including error description) from html.convert() call. I would like to return meaningful message, like I see in speech/tex2svg sample. Is it possible when html.convert() is used?

The error handling in speech/tex2svg is because that example is promise-based, and promises require that you have a catch() clause as they will fail badly if there is an error during the code that is run by the promise.  The errors that that code will catch are internal errors with MathJax, like if a file fails to load, not errors in the TeX code provided by the user, which will now throw an error (they simply produce a math expression that is the error message as would be displayed in the browser).
So assuming you want to trap the actual TeX errors (which none of the examples do), there are a number of ways to do that, which I describe below.
Quick and Dirty
This is the easiest, but least elegant way to do it.  Here, we check for the error indicator and look up the error message (which is stored as an attribute of the merror element generated by the error).
    const node = html.convert(texEquation, {
        display: !options.inline,
        em: options.em,
        ex: options.ex,
        cwidth: options.width
    });
    if (tex.parseOptions.error) {
        const merror = tex.mathItem.root.childNodes[0].childNodes[0];
        console.log(merror.attributes.get('data-mjx-error'));
    } else {
       console.log(adaptor.innerHTML(node));
    }

Because we know the location of the merror element that the TeX input jax will produce, we can look into the MathML tree at the right location and grab the error message and return it (though I'm not sure how you are going to tell an error message from the SVG output, since you return strings in both cases).
More Robust
It is a bit fragile to reply on the position of the merror element, so a better way would be to search the tree for it.  This can be done via the build-in tree walker.  Also, rather than simply return the error, we throw an error instead that can be trapped by an error-checking mechanism.  In this example, we use a TeX input jax post-filter to post-process the MathML before it is returned by convert().
const tex = new TeX({packages: argv.packages.split(/\s*,\s*/)});
const svg = new SVG({fontCache: (argv.fontCache ? 'local' : 'none')});
const html = MathJax.document('', {InputJax: tex, OutputJax: svg});

tex.postFilters.add(({math, data}) => {
    if (!data.error) return;
    data.root.walkTree((node) => {
        if (node.isKind('merror')) {
            throw Error('TeX error: ' + node.attributes.get('data-mjx-error'));
        }
    });
});

Now we can use a try-catch command to detect and process the error:
try {
    const node = html.convert(texEquation, {
        display: !options.inline,
        em: options.em,
        ex: options.ex,
        cwidth: options.width
    });
    console.log(adaptor.innerHTML(node));
} catch (error) {
    console.log(error.message);
}

Most Elegant
Perhaps the best way to handle the situation is to subclass the TeX input jax and override its formatError() function.  For example:
class MyTeX extends TeX {
    formatError(error) {
        throw Error('TeX error: ' + error.message);
    }
}

const tex = new MyTeX({options.packages.split(/\s*,\s*/)});

This will cause any TeX error to throw a javascript error, which you can trap using try-catch as above.  Alternatively, you could use promises, which I illustrate here:
MathJax.handleRetriesFor(() => {
    return html.convert(texEquation, {
        display: !options.inline,
        em: options.em,
        ex: options.ex,
        cwidth: options.width
    });
}).then(node => console.log(adaptor.innerHTML(node)))
  .catch(error => console.log(error.message));

The catch functions in both the  last two examples will trap both TeX errors and internal MathJax errors for processing.  Of course, you can use try-catch or promises in either one, depending on whether you need synchronous or asynchronous handling of the typesetting.

Isn't it possible to suppress mjx-container tag using some option?

Yes, use adaptor.innerHTML() rather than adaptor.outerHTML() so that only the contents of the container are serialized.  I have used this in my examples above.

Davide, the "most elegant" MyTeX solution is EXACTLY what I was looking for, thank you. Works like a charm!
Thank you also for adaptor.innerHTML() hint.


[SMALLFIX] Update outdated javadoc comments for params

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7633/
Test PASSed.

LGTM


[BugFix] Fix broker load crash since merge code problem

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Fix bug introduced by https://github.com/StarRocks/starrocks/pull/12159/files#diff-1728e7da674782d9020a430ee633c1d8ad5fbe9cdb58efbaf5dcb3bdf2ee32d8
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@mergify backport branch-2.5


Add support for ROB_200-004-0

Add support for ROB_200-004-0 a ZigBee AC phase-cut dimmer, it is the same form factor as the Sunricher - ZG9101SAC-HP.  But then sold under a different name/vendor here in The Netherlands.
The same config as Sunricher does work (extend: generic.light_onoff_brightness,) but the state does not change when a button is pressed / dimmed. That's why I changed it.
The only thing I found strange is, that I had too define fz.ignore_light_brightness_report otherwise I got the following "error"
No converter available for 'ROB_200-004-0' with cid 'genLevelCtrl', type 'attReport' and data '{"cid":"genLevelCtrl","data":{"currentLevel":16}}'

But the brightness Is reporting a correct value.
PM MQTT publish: topic 'zigbee2mqtt/light_switch_1', payload '{"state":"OFF","brightness":33,"linkquality":15,"last_seen":1562880834536}'
PM MQTT publish: topic 'zigbee2mqtt/light_switch_1', payload '{"state":"ON","brightness":33,"linkquality":15,"last_seen":1562880836040}'
PM MQTT publish: topic 'zigbee2mqtt/light_switch_1', payload '{"state":"ON","brightness":46,"linkquality":15,"last_seen":1562880841750}'
PM MQTT publish: topic 'zigbee2mqtt/light_switch_1', payload '{"state":"ON","brightness":88,"linkquality":15,"last_seen":1562880842753}'

Thanks!


OM149 - secret agent dashboard

this is the initial version of secret-agent dashboard

The secret-agent alert requested by @hev is addressed in a different pull request.
We decided to keep the folder naming the same for now.
Accepting this pull request.


Get valid extension ID for Firefox

Used in manifest.json:

"applications": {
  "gecko": {
    "id"<EMAIL_ADDRESS>
    "strict_min_version": "57.0"
  }
}

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/applications
https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#id
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/WebExtensions_and_the_Add-on_ID

I"m happy to help with this but figured you'd want to decide on an ID. If you have one or don't have a preference I can help out.


Unhandled error if cookies disabled

What happened:
User attempted to log in with ad block. Error message in log is as follows:
User isn't authenticated: TypeError: Cannot read properties of undefined (reading 'flatMap')

What did you expect to have happen:
Error message in log indicating that no cookies were found rather than null reference exception.
How to reproduce this (as precisely and succinctly as possible):
Attempt to access protected content using an ad blocker that prevents cookies from being sent.
Anything else you think we should know?
N/A
Environment:

version of cognito-at-edge being used: 1.3.1
node version of code base which uses cognito-at-edge: 16.x
other:

Looks like the actual issue is a timeout. I will extend the timeout to see if that resolves the issue.

Fixed by #53 .


herwig: 7.1.4 -> 7.1.5

thepeg: 2.1.4 -> 2.1.5

Motivation for this change

Herwig 7.1.5 release: 2019-04-04

** Add option of producing partons on physically mass shell after the parton shower
to allow the string model to be used to hadronize events
** Fixes for template issues and compiler warnings for gcc8,9, icc and clang
** Various minor fixes

ThePEG-2.1.5 release: 2019-04-04

** Improvements to template instantiation with gcc9 and icc T23
** Changes for compilation with gcc8,9, icc and clang
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build herwig

Builds fine on my machine, and I tried running the commands, but I don't know how to actually use this thing, so I couldn't do a real test run.


Multiple Routes with one secret fail to update

When two or more routes are annotated with the same secret only one is updated when the secret is updated unless you restart the operator.

Going to try to come up with a step by step duplication procedure but saw this happen numerous times now

Going to try to come up with a step by step duplication procedure but saw this happen numerous times now

@raffaelespazzoli  Found the issue, it was created by the addition of a break in the loop to match secrets to their routes

@raffaelespazzoli  Found the issue, it was created by the addition of a break in the loop to match secrets to their routes

found here
https://github.com/redhat-cop/cert-utils-operator/blob/a160c6b9a20d3146034061229a2ff2d89be2fef6/controllers/route/route_controller.go#L236
and
https://github.com/redhat-cop/cert-utils-operator/blob/a160c6b9a20d3146034061229a2ff2d89be2fef6/controllers/route/route_controller.go#L240

found here
https://github.com/redhat-cop/cert-utils-operator/blob/a160c6b9a20d3146034061229a2ff2d89be2fef6/controllers/route/route_controller.go#L236
and
https://github.com/redhat-cop/cert-utils-operator/blob/a160c6b9a20d3146034061229a2ff2d89be2fef6/controllers/route/route_controller.go#L240


many golint and go vet warnings in fabric/membersrvc/ca

fabric/membersrvc/ca contains two pages of golint and vet warnings. I'm willing to do a PR to address them but concerned that there may be active work on this package and that whomever is working it should address this in their PR.

While we're at it, can somebody please assign this to me? Will do it one file at a time.

Is it possible to run golint and vet in the CI pipeline? Sometimes they give false positives, but a list of warnings would help with review.

@srderson yes, it is possible... agree that there can be false positives. I wonder if it can be done as informative (eg not fail the build). I'll investigate.

@JonathanLevi it's yours!

As discussed, we waited with these until the end of Sprint 5 of last week. Currently there are 349 lint errors, for the interested/avid reader, we enclose the output here 2016-05-16_membersrvc_lint_errors.txt
To minimize intervention, will work to tackle them a file at a time adopting @christo4ferris's approach.

Following
vagrant@hyperledger-devenv:v0.0.9-048fc48:/opt/gopath/src/github.com/hyperledger/fabric/membersrvc/ca$ git log -1
commit cb011329cd3ef5715d36eb0dff96ffad59de642c
Merge: 35e7f3e 55c9175
Author: Sheehan Anderson<EMAIL_ADDRESS>Date:   Tue May 31 20:37:09 2016 -0400

    Merge pull request #1669 from JonathanLevi/issue-1558-go-vet

    Issue 1558 Fix go vet issues in fabric/membersrvc/ca```

Executing:
vagrant@hyperledger-devenv:v0.0.9-048fc48:/opt/gopath/src/github.com/hyperledger$ golint ./fabric/membersrvc/ca/... | wc -l
0
vagrant@hyperledger-devenv:v0.0.9-048fc48:/opt/gopath/src/github.com/hyperledger$ go vet ./fabric/membersrvc/ca/... | wc -l
0

@christo4ferris, given the above, please let me know if you are OK with me closing this issue, as I believe that membersrvc does not have any golint or go vet issues anymore.

closing, thanks everyone for pitching in to clean this up!

Thank you @christo4ferris. Yup, especially thanks to @srderson and @ghaskins for the quick turnarounds and lengthy discussions regarding the various golint and go vet fixing approaches, making sure that membersrvcs is not anymore the worst offender.


feature(#32)

fxied #32 json parsing issue fixed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


CASMPET-6398: kyverno prevents weave-net daemonset from creating pods

Summary and Scope
The daemonset-controller is not able to create the weave pod because it cannot get to kyverno to call the webhook.
Testing
Before Change
pit:~ # kubectl get pods -o wide -A | grep weave
kube-system      weave-net-45np9                                                   2/2     Running            0          2m21s   <IP_ADDRESS>    ncn-w003   <none>           <none>
kube-system      weave-net-67ttc                                                   2/2     Running            1          2d16h   <IP_ADDRESS>    ncn-w002   <none>           <none>
kube-system      weave-net-92tls                                                   0/2     Terminating        1          2d16h   <IP_ADDRESS>   ncn-m002   <none>           <none>
kube-system      weave-net-g9d5f                                                   2/2     Running            0          77s     <IP_ADDRESS>    ncn-w001   <none>           <none>
kube-system      weave-net-nfwxb                                                   2/2     Running            0          3m13s   <IP_ADDRESS>   ncn-m003   <none>           <none>
pit:~ # journalctl -u kubelet | grep webhook
.
.
.
Mar 15 07:45:12 ncn-m002 kubelet[14609]: I0315 07:45:12.693060   14609 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-9r5x2" err="Internal error occurred: failed calling webhook \"mutate.kyverno.svc-fail\": Post \"https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 15 07:45:22 ncn-m002 kubelet[14609]: I0315 07:45:22.704503   14609 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-9r5x2" err="Internal error occurred: failed calling webhook \"mutate.kyverno.svc-fail\": Post \"https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 15 07:45:32 ncn-m002 kubelet[14609]: I0315 07:45:32.688340   14609 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-9r5x2" err="Internal error occurred: failed calling webhook \"mutate.kyverno.svc-fail\": Post \"https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 15 07:45:42 ncn-m002 kubelet[14609]: I0315 07:45:42.708703   14609 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-9r5x2" err="Internal error occurred: failed calling webhook \"mutate.kyverno.svc-fail\": Post \"https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 15 07:45:52 ncn-m002 kubelet[14609]: I0315 07:45:52.692738   14609 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-9r5x2" err="Internal error occurred: failed calling webhook \"mutate.kyverno.svc-fail\": Post \"https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
ncn-m002:~ # kubectl get pods -o wide -A | grep weave
kube-system      weave-net-6dqds                                                   2/2     Running            0          45m     <IP_ADDRESS>    ncn-w002   <none>           <none>
kube-system      weave-net-9r5x2                                                   0/2     Terminating        0          44m     <IP_ADDRESS>   ncn-m002   <none>           <none>
kube-system      weave-net-ct5mg                                                   2/2     Running            0          37m     <IP_ADDRESS>   ncn-m003   <none>           <none>
kube-system      weave-net-sbh22                                                   2/2     Running            0          38m     <IP_ADDRESS>    ncn-w001   <none>           <none>
kube-system      weave-net-vdnk8                                                   2/2     Running            0          46m     <IP_ADDRESS>    ncn-w003   <none>           <none>
ncn-m002:~ #

After change
pit:~ # kubectl edit configmap cray-kyverno -n kyverno
# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: v1
data:
  generateSuccessEvents: "false"
  resourceFilters: '[Event,*,*][*,kube-system,*][*,kube-public,*][*,kube-node-lease,*][Node,*,*][APIService,*,*][TokenReview,*,*][SubjectAccessReview,*,*][SelfSubjectAccessReview,*,*][*,kyverno,kyverno*][Binding,*,*][ReplicaSet,*,*][ReportChangeRequest,*,*][ClusterReportChangeRequest,*,*]'
  webhooks: '[{"namespaceSelector":{"matchExpressions":[{"key":"kubernetes.io/metadata.name","operator":"NotIn","values":["kube-system"]}]}}]'
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: cray-kyverno
    meta.helm.sh/release-namespace: kyverno
  creationTimestamp: "2023-03-12T11:37:44Z"
  labels:
    app: kyverno
    app.kubernetes.io/component: kyverno
    app.kubernetes.io/instance: cray-kyverno
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: kyverno
    app.kubernetes.io/part-of: kyverno
    app.kubernetes.io/version: v2.3.3
    helm.sh/chart: kyverno-v2.3.3
  name: cray-kyverno
  namespace: kyverno
  resourceVersion: "3968894"
  uid: 96549bfb-fbe1-4781-a25f-a39b69dfe0b0
pit:~ # kubectl get cm cray-kyverno -n kyverno -o yaml
apiVersion: v1
data:
  generateSuccessEvents: "false"
  resourceFilters: '[Event,*,*][*,kube-system,*][*,kube-public,*][*,kube-node-lease,*][Node,*,*][APIService,*,*][TokenReview,*,*][SubjectAccessReview,*,*][SelfSubjectAccessReview,*,*][*,kyverno,kyverno*][Binding,*,*][ReplicaSet,*,*][ReportChangeRequest,*,*][ClusterReportChangeRequest,*,*]'
  webhooks: '[{"namespaceSelector":{"matchExpressions":[{"key":"kubernetes.io/metadata.name","operator":"NotIn","values":["kube-system"]}]}}]'
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: cray-kyverno
    meta.helm.sh/release-namespace: kyverno
  creationTimestamp: "2023-03-12T11:37:44Z"
  labels:
    app: kyverno
    app.kubernetes.io/component: kyverno
    app.kubernetes.io/instance: cray-kyverno
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: kyverno
    app.kubernetes.io/part-of: kyverno
    app.kubernetes.io/version: v2.3.3
    helm.sh/chart: kyverno-v2.3.3
  name: cray-kyverno
  namespace: kyverno
  resourceVersion: "4011782"
  uid: 96549bfb-fbe1-4781-a25f-a39b69dfe0b0
pit:~ #
pit:~ # kubectl rollout restart daemonset weave-net -n kube-system
daemonset.apps/weave-net restarted
pit:~ #
pit:~ # kubectl get pods -o wide -A | grep weave
kube-system      weave-net-4m8nx                                                   2/2     Running            0          100s    <IP_ADDRESS>   ncn-m002   <none>           <none>
kube-system      weave-net-58mqr                                                   2/2     Running            0          2m25s   <IP_ADDRESS>    ncn-w001   <none>           <none>
kube-system      weave-net-874bd                                                   2/2     Running            0          3m7s    <IP_ADDRESS>    ncn-w002   <none>           <none>
kube-system      weave-net-8stwz                                                   2/2     Running            0          3m53s   <IP_ADDRESS>    ncn-w003   <none>           <none>
kube-system      weave-net-knxcq                                                   2/2     Running            0          53s     <IP_ADDRESS>   ncn-m003   <none>           <none>
pit:~ # journalctl -u kubelet | grep webhook
pit:~ #

Tested on:
Dorian

I'll also note that this repo currently doesn't require any reviews to merge.   Is that expected?

It looks like this repo also doesn't have an action to build the chart.   That would help to check that there are no build issues before merging and it would also provide a chart that could be tested.

I'm guessing the actions are not building the chart because this PR is from a branch on a fork.

Manual chart creation and installation logs we collected before raising the PR will attach those logs for the reference.

Package creation and installation logs
pit:/tmp/pradeep/cray-kyverno # vi values.yaml
pit:/tmp/pradeep/cray-kyverno # cd ..
pit:/tmp/pradeep # helm package cray-kyverno
Successfully packaged chart and saved it to: /tmp/pradeep/cray-kyverno-1.4.0.tgz
pit:/tmp/pradeep # ls -ltr
total 44
-rw-r--r-- 1 root root   156 Mar 15 17:56 nginx.yaml
drwxr-xr-x 4 root root   128 Mar 15 23:44 cray-kyverno
-rw-r--r-- 1 root root 38769 Mar 15 23:44 cray-kyverno-1.4.0.tgz
pit:/tmp/pradeep # helm upgrade -n kyverno cray-kyverno /tmp/pradeep/cray-kyverno-1.4.0.tgz
Release "cray-kyverno" has been upgraded. Happy Helming!
NAME: cray-kyverno
LAST DEPLOYED: Wed Mar 15 23:45:11 2023
NAMESPACE: kyverno
STATUS: deployed
REVISION: 6
NOTES:
The official kyverno chart installed with some cray-specific overrides and defaults
pit:/tmp/pradeep #
pit:/tmp/pradeep # kubectl get cm cray-kyverno -n kyverno -o yaml
apiVersion: v1
data:
generateSuccessEvents: "false"
resourceFilters: '[Event,,][,kube-system,][,kube-public,][,kube-node-lease,][Node,,][APIService,,][TokenReview,,][SubjectAccessReview,,][SelfSubjectAccessReview,,][,kyverno,kyverno][Binding,,][ReplicaSet,,][ReportChangeRequest,,][ClusterReportChangeRequest,,]'
webhooks: '[{"namespaceSelector":{"matchExpressions":[{"key":"kubernetes.io/metadata.name","operator":"NotIn","values":["kyverno","kube-system"]}]}}]'
kind: ConfigMap
metadata:
annotations:
meta.helm.sh/release-name: cray-kyverno
meta.helm.sh/release-namespace: kyverno
creationTimestamp: "2023-03-12T11:37:44Z"
labels:
app: kyverno
app.kubernetes.io/component: kyverno
app.kubernetes.io/instance: cray-kyverno
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: kyverno
app.kubernetes.io/part-of: kyverno
app.kubernetes.io/version: v2.3.3
helm.sh/chart: kyverno-v2.3.3
name: cray-kyverno
namespace: kyverno
resourceVersion: "4938066"
uid: 96549bfb-fbe1-4781-a25f-a39b69dfe0b0
pit:/tmp/pradeep #
pit:/tmp/pradeep # kubectl get pods -o wide -A | grep weave
kube-system      weave-net-j9bzl                                                   1/2     Running     0          5s      <IP_ADDRESS>    ncn-w002
kube-system      weave-net-rlg4k                                                   2/2     Running     0          58s     <IP_ADDRESS>   ncn-m003
kube-system      weave-net-s45bh                                                   2/2     Running     0          105s    <IP_ADDRESS>    ncn-w003
kube-system      weave-net-vsjn9                                                   2/2     Running     0          3m14s   <IP_ADDRESS>   ncn-m002
kube-system      weave-net-xhgsx                                                   2/2     Running     0          2m27s   <IP_ADDRESS>    ncn-w001
pit:/tmp/pradeep # date
Wed Mar 15 23:56:21 UTC 2023
pit:/tmp/pradeep #

I'll also note that this repo currently doesn't require any reviews to merge. Is that expected?

No. @yarlagadda-srinivasa-rao please require at least one approved reviewer from PET or SEC. If you need help setting policy, please advise but you should be authorized to make this change.


Adds / Fixes Various Stuff

Fixes issue #214.
Fixes issue #198 (sort of).

Ready to merge.

Nice!! Thank you for fixing the stuff I pointed out. It's now much better overall :)
There are still some things I'd like to polish before merging. For the sake of completeness, I'll add them to this pull request over the next few days, instead of merging right away. (I need to acquire the habit of using one pull request per feature anyway, haha!)

I really like how the changes are looking so far! Here's a few additional improvements I'd suggest:

[ ] I see you added a 'Back' arrow on the Preferences. We should keep the OK button at the bottom though. Themes should (mostly) only change the appearance and not where you must click to perform a certain action.
[ ] I like the idea you're trying to convey with the layer lock icon; however, I'd still rather go with a padlock since the feature is called 'layer lock'. Also, it looks too similar to the volume icon and is not consistent with the existing themes.
[ ] Having duplicate code for the Preferences window is very cumbersome, making it difficult to maintain. In one instance, specifically the 'Check for updates' toggle, there are now eight similar but slightly different lines responsible for drawing it — when a simple rearrangement in the code layout could keep it to a single one. I'll rework the Preferences a bit and try to fix this.
[ ] The border surrounding the note block area is a bit off — there's a 1px gap between both the marker head and the bottom scrollbar. (Perhaps it could also use a softer color?)
[ ] Bold font is missing in some places, like the titles in each released version's list of changes.
[ ] When hovering web links, the font becomes gray. A lighter shade of blue would probably look better.
[ ] The tempo edit window could be opened by clicking the tempo box instead of from the Edit menu. The menu option could also be removed.
[ ] Entering a non-numeric value on the tempo causes an issue.
[ ] Edge scrolling when dragging a selection is faster depending on FPS.
[ ] Sound count is updated far too often on higher FPS.

I'd really like to ship a dark version of the Fluent theme as well. Let me know if you'd be able to work on it; otherwise, I'll give it a shot. :)

It's better to test working and useable before committing to avoid conflicts

About the url text, the Fluent design format shows that when hovering on URL or hyperlinks, the text becomes gray.

merged my experimental branch into this because why not and also no more conflicts

Alt + Enter to fullscreen like most games
Can be useful for recording on 1080p screens

I must say, I'm delighted by what you have done so far. Particularly, the whole Fluent theme(s!), the music player mode, and the accent color picker must've been REALLY tricky to implement, given the piles and piles of spaghetti code that this program consists of. :P
It's never much to say, thank you for your efforts! :)
While I'd love to keep seeing further improvements, we've already got a rich set of features ready for the next version. So I think it'd be wise to withhold from adding new features, at least for a while, and focus on polishing the existing ones so we can wrap up the next version.
I'm compiling a (hopefully) final list of changes that would improve code readability, integration of new features, and stability. Some of those you fixed in the meantime as I reviewed the changes; some I've been working on myself; and some can (should) be further discussed prior to release. For completeness, I'll post the full list and check the stuff that's out of the way. In any case, we should be closer than ever to 3.9 now!

My original list was 90% fixed by now, so there's no point in putting it here lol. There's just a couple of easy fixes to do before we release! Would be great if you could work on some of these; if not, I can work on it over the next few days :)

Allow closing Preferences with Ctrl + P as well
Layer names are slightly higher than the hint text (Layer 1, 2, etc.). Try to make them aligned if possible!
When Ctrl is pressed, the mouse cursor could be changed to something else to indicate that note blocks may be selected.
Add a toggle for the Acrylic effect, for performance on lower-end machines. (Maybe for the window rising animation/fade/dark as well)
In the light Fluent theme, is the window shadow supposed to be white? (It looks sort of like a glow xD, perhaps it could be darker as in the dark mode)
Remove the Dialog extension from the project, since we are no longer using it. (Reduces the executable size)
Make the Discord ping less often (once every ~5 seconds), instead of every frame, to avoid excessive pings?
When editing a text box (for example in Song properties), the mouse flashes between an arrow and cursor very fast
Popups from dark mode, interface sound & blackout mode appear when hovering options in the theme dropdown
Consider changing the unlimited FPS option to 240? Reasons: 1) it's not really "unlimited", it's just set to a really high value; 2) it forces GameMaker to draw thousands of frames, which it will never be able to reach, and 3) it causes a big impact on performance anyway, which is unnecessary, considering a value like 240 would have the same effect.

Let me know what you think!

Hi! I see an immediate issue with the code for writing UTF-8 strings: the value you're writing before the string is the length of the string itself, not of the encoded data. This makes it more difficult to parse the NBS file, as parsers won't be able to read the string contents in advance.
I see three ways of fixing this:

precalculate the length of the data based on the characters (more expensive and requires more code);
after writing the string, seek the buffer to the position of the length value and rewrite it ("dirty");
write the data to a temporary variable, and only write it to the buffer at the end -- at this point you'll know the length of the encoded data, so you can write it to the actual buffer, then write the data itself (cleanest option).

Since changing the fundamental structure of an NBS file is such a risky change, I'd like to postpone the format change to a later version, until we can both: 1) make sure that the code is absolutely, 100% fail-proof and reliable, and 2) make the format as future-proof as we can.
Changing a widely-adopted format has numerous consequences. Getting anything wrong implies generating broken NBS files, which means every NBS parser in existence will have to be updated to deal with wrong data. Since this has a lot of potential to go wrong, I'd like to make sure we get it absolutely right.
Additionally, the NBS format has been very unstable since the beginning of OpenNBS -- to this day, many parsers haven't been able to catch up with the latest changes, or have even given up on staying up-to-date. Hypixel, for example, is still stuck on version 3. Every file structure change breaks the format for existing parsers, and I'd like to do something to change this -- this way, NBS version 6 may be the last one that breaks compatibility in a major way.
Finally, postponing the format change will allow us to focus on bugs that may arise from all the additions in that version, making our workload a bit easier. Despite UTF-8 support being a long due change, I don't see the need to rush this feature. :)

@Bentroen (Is this why pynbs not properly reading NBS files)

@Bentroen (Is this why pynbs not properly reading NBS files)

@miclol Not really! This format hasn't launched officially yet, however, it aims to fix exactly the problem you're encountering in pynbs (special characters not being encoded properly).
Since it's a delicate change, we'll release those changes later so we have more time to properly develop and test them.
(context: vberlier/pynbs#3)

Since Realtime Blur, the extension used for the Acrylic and Mica effects, is a paid extension, it wouldn't be ethical to publish its source code on the repository, as this would enable anyone who cloned the project to obtain the extension for free.
In order to remove its source code from the repository, I did an interactive rebase editing commit 89f3da4656dc7ee78941db5ee61cade838515080 (new hash) to remove the affected files. During development, these files were added to .gitignore (d08a9cd11540a2c5020861403c6cb6b9952548b0) and eventually deleted (cdd401774c64397b575042dc5d07a8a57a4e67f7 -- of course this commit no longer removes any files because they're now gone, so the commit message no longer makes sense). However, without the cleanup, the files would remain in the repository history, which would still allow access to the source code.
To allow the project to work even with the extension files missing, commit 634b3835e9e3f3446a5cddc52c333f520e176ed2 introduced a script, blur_scripts_alt.gml, which acts as a wrapper to the functions defined in the extension. This way, when the files are absent they just return placeholder values that allow the program to run without the blur effect, but still showing transparency. Simply deleting the files would cause the program to crash otherwise.
This way, anyone who clones the repository will be able to run the program as normal. However, in order for the blur effect to work, a copy of the extension must be placed in the correct spot. For production releases, whoever builds the version must make sure to load the files correctly (this will likely be me, so consider this a note to self :D). For record, a list of the affected files is kept below:

Affected files:
shaders/blur_realtime/blur_realtime.fsh
shaders/blur_realtime/blur_realtime.vsh
shaders/blur_realtime/blur_realtime.yy
shaders/blur_static/blur_static.fsh
shaders/blur_static/blur_static.vsh
shaders/blur_static/blur_static.yy
scripts/blur_scripts/blur_scripts.gml
scripts/blur_scripts/blur_scripts.yy

One consequence of rebasing is that it rewrites the branch's history, which requires a force push. So if anyone besides me and @chenxi050402 has based work off this branch, make sure to clone it again!
With that, this PR should be (finally) ready to merge into the project! 🥳


Debug CI failures

cc @nkolev92

lol, now I can't get it to fail. Maybe updating to the latest SDK (in #14984) fixed it. It hasn't failed since.

@bricelam From the issue thread, I was under the impression that the failures (or a version of, hard to confirm all have the same root cause), have been occurring for at least ~8-9 year.
I'd imagine we are just lucky(unlucky).

We've been failing about every five builds on macOS for the past few weeks. But none have failed with the error since I updated the SDK.

Could have been an unrelated issue that has been fixed.

I don't think it's going to fail. Closing PR. I'll keep an eye on the builds...

Still failing. Going to push https://github.com/aspnet/EntityFrameworkCore/pull/15062/commits/4e5f7aa1d80305c605dc5ac3782e5f001ba874ee to ignore failures and collect binlogs.


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-06-22)
Features

buffer/lsp: implement handler for 'point (9d7917f)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.0
:sunflower:


Adds pandas is_custom()

Closes #360
cuallee

[ ] pyspark
[ ] snowpark
[x] pandas
[ ] duckdb
[ ] polars
[ ] unit test
[ ] docs
[ ] other

Thank you @jkkronk for the issue, and the quick turnaround for its solution. Appreciated.


CRAYSAT-1857:bootsys stage to wait for kyverno before job recreation

IM:CRAYSAT-1857
Reviewer:Ryan
Summary and Scope
Updating sat boot platform-services stage to wait for kyverno availability before going to recreate cronjob stage to avoid the warnings.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CRAYSAT-1857

Testing
List the environments in which these changes were tested.
Tested on:

yet to be tested

Test description:
Will perform the shutdown and boot activity to verify the platform-services output to validate the changes effectiveness.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
low
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

testing output: https://gist.github.com/shivaprasad-metimath/6e23fa61d53e677271485de60d086587


Release v1.16.0

Are there already plans when AWS Otel Agent will be available based on new opentelemetry release 1.16.0 which was released 8 days ago (https://github.com/open-telemetry/opentelemetry-java/releases)?
Version 1.16.0 contains an important bugfix, which I can not retest atm, because the agent from opentelemetry, does not generate valid trace IDs for XRay

It also contains dropwizard-metrics module which we need.

v1.16.0 released


Add ability to set custom value_class on StructBlock

Let me know if this needs any revisions.
Closes #2204

Added tests for value_class setting
Linting done
Documentation added

Thanks @lb-! Merged in 4ea836520365aa84219e8fe7257a6b66b771a196.

@gasman thanks 👍


Add more tests for diff highlighting

Adding some more tests for different cases to make sure they keep working

Codecov Report

Merging #12467 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12467      +/-   ##
==========================================
- Coverage   43.80%   43.76%   -0.04%
==========================================
  Files         630      630
  Lines       69821    69821
==========================================
- Hits        30583    30558      -25
- Misses      34299    34318      +19
- Partials     4939     4945       +6

Impacted Files
Coverage Δ

services/gitdiff/gitdiff.go
73.88% <ø> (+0.66%)
:arrow_up:

services/pull/temp_repo.go
26.59% <0.00%> (-6.39%)
:arrow_down:

modules/sync/unique_queue.go
38.77% <0.00%> (-6.13%)
:arrow_down:

services/pull/update.go
51.92% <0.00%> (-5.77%)
:arrow_down:

modules/git/repo_language_stats.go
52.83% <0.00%> (-3.78%)
:arrow_down:

services/pull/check.go
50.78% <0.00%> (-3.13%)
:arrow_down:

services/pull/patch.go
66.37% <0.00%> (-2.59%)
:arrow_down:

modules/git/repo.go
49.74% <0.00%> (-2.04%)
:arrow_down:

modules/log/event.go
57.54% <0.00%> (-0.95%)
:arrow_down:

services/pull/pull.go
42.03% <0.00%> (-0.24%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ba1ad...114ba1d. Read the comment docs.


UI enhancements for engine (druid) monitoring

Describe the bug
UI enhancements for engine (druid) monitoring (in Overview Screen)

Add sync selection button
General tooltip
Segment Count tile

Look at pink rectangles!

@AnnieHwang In the Ingestion tab, there is an item I want to add in the supervisor details.
There is a list of tasks that depend on Supervisor. How about displaying them together as below image?

@kyungtaak @minhyun2 If we really need the content, i'll be fine in that location. But I have not yet heard the need for the content. Let's discuss it with the druid engineer @seoeun25 .

@koeun222 We have changed the 'Task' and 'Supervisor' tab details UI in the 'ingestion' menu. Please design that UIs.

@koeun222 We have changed the time filter widget UI. Please design that UI.


Add support for QNX Neutrino to master branch

CC @gh-tr

Clippy issues should vanish with #365.

LGTM.
Any way to setup CI? Even running cargo check is good enough.

I'm afraid this is not yet possible because of the missing standard library: https://github.com/rust-lang/rust/pull/106673
This will take some months to arrive in stable.

I'm afraid this is not yet possible because of the missing standard library: rust-lang/rust#106673 This will take some months to arrive in stable.

We used have Redox on a nightly-only CI, so if that's possible it's fine to. In the mean time I'll merge this.

Thank you very much, @Thomasdezeeuw . I would appreciate if you would also merge it to the 0.4 branch.

Done in https://github.com/rust-lang/socket2/pull/382.


Impossible to open last-opened folder in Zedd

(Zedd on a Mac, 10.10, Zed client on a Chromebook)
When I try to open a folder through Zedd, the last option is selected by default. Unfortunately, this means that I can't actually select it, and any time I try to click something else to lose focus, it opens that folder instead.
Example:

(Let's work on this project today!)

(But when I click, it just expands the folder!)

(And when I click on cover-letter to lose focus, it just opens that folder instead!)

Yeah I noticed this at some point, then forgot about it again. Thanks for reporting, I'll look into it.

Fixed on master branch.


Remove bounded contexts, Replace UML diagram (4.)

Remove redundant bounded contexts under 4. because it is in 3.
Replace UML diagram with a webp file, so the resolution is sharper
Is that ok like so?

Thanks for the updates @SvetlanaIvanovic. Could you kindly also update the pdf and add it to the pr? Then it can be merged from my view.

Well done

I have updated the file according to your change request @Emma. If ok, please feel free to merge @Emma, @futurefounder, @Orock237.

Good work, thank you! As the overall changes were approved, I am now merging this PR.


translation to Spanish

Thanks a lot for this translation! It looks to me like the months are abbreviations of the month names, is that something that's commonly used in Spain? The Dutch months have their full names translated, that's something I would like to keep consistent, but of course I don't know what's common in other countries. :)

I agree: consistency is important. In this scenario is a little tricky though, let me explain:

28-feb-2018: OK
28 de febrero de 2018: also OK (nicest option but longer though, I suggest you pick this one and made a new commit with full names for months)
28-febrero-2018: understandable, but not really the way we display dates in Spanish.

Awesome, sounds good to me! Could you change the translation of publishdate in es.toml to reflect "28 de febrero de 2018"? Then I'll merge this pull request.

Thanks a lot, looks good to me! I'll merge this into master


fix(ghost_text): generate it using chars instead of bytes

Previously if the completion entry text had a multibyte character the
ghostly text renderd improperly, for example:
The cursor position is "|"
1. Example
In this case the ghost text was spliting a multibyte character.

2. Example
In this case the multibyte had passed messing up the indexing therefore presentin the last character of the entry as ghost text.

@hrsh7th Changed the implementation to only use vim.str_{utf,byte}index.
Also heads up on the following just merged functions in neovim that will be very helpful for more features in cmp.

https://github.com/neovim/neovim/pull/16129
https://github.com/neovim/neovim/pull/16124

LGTM. Thank you~!


gromacs: 4.6.5 -> 4.6.7 + MPI support

Things done:

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
[X] Built on platform(s): Linux
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

More
Fixes issue #
cc @
The MPI version needs to be launched with openmpi (mpirun command) so it's in a specific package.
Please note, that points are not mandatory, but rather desired.

:+1:


The summary window should show when the summary was created with which provider

[ ] Timestamp should use the current localization. I think, the hints at https://stackoverflow.com/a/59707272/873282 are good. Try to use Instant for representing date and time.

One could also store/log/output the setting used to generated. At least the model maybe?

Follow up work could be to switch between the generated summaries (meaning: I can switch between OpenAI, Misral, ...) but this is much requirements work, because the summaries also depend on the model etc...

Okay, I tried to implement this feature.
Should work. And timestamp should use current locale.
Do you like the look? (Also, clear all JabRef AI related cache before that, because the underlying format is changed)

Works!

First try - when an existing summary before the upgrade is loaded:

We do not need to implement functionality for that.
vagrant@lm21vgntbx:~/.local/share/jabref/ai/1$ rm ai.mv
(Also important for @ThiloteE when trying out a recent build)

I have not encountered your error message when running JabRef with a recent build, which is a good thing.


Docs: jupyter example notebooks fix

Steps to reproduce the problem
In docs we suggest to use docker compose with jupyter examples. When you run docker compose it is failing with
manifest for [icr.io/quantum-public/quantum-serverless-notebook:0.8.2-py39](http://icr.io/quantum-public/quantum-serverless-notebook:0.8.2-py39) not found

What is the current behavior?
Docker compose fails
What is the expected behavior?
Docs and compose should not point to non-existing jupyter notebook example anymore

Is this because we don't build the image any longer?

yes, we should remove any mention about jupyter notebooks from docs and docker compose

And eventually we'll sunset the docker compose entirely as the docs move to IQP (:crossed_fingers: :smile: )

I can go ahead and clean this up in our existing docs

Thank you!

@psschwei @IceKhan13 et al, the repo readme still recommends jupyter notebooks as standard path. Worth a separate cleanup?

@psschwei @IceKhan13 in https://qiskit-extensions.github.io/quantum-serverless/deployment/local.html in Step 4, is the recommendation to use Jupyter Lab obsolete?

To create and run programs in this simulated cluster, we recommend using Jupyter Lab.

@psschwei @IceKhan13 et al, the repo readme still recommends jupyter notebooks as standard path. Worth a separate cleanup?

Yes, the main readme also needs an update (missed it on the PR).

@psschwei @IceKhan13 in https://qiskit-extensions.github.io/quantum-serverless/deployment/local.html in Step 4, is the recommendation to use Jupyter Lab obsolete?

To create and run programs in this simulated cluster, we recommend using Jupyter Lab.

Jupyter Lab is still recommended, we just aren't providing a containerized environment. Instead, folks should manage their own (we probably should also include something about using a virtual environment a la venv in that section too...)


threefold/gridproxy v1.0.0

branch development_gridproxy

this is only a client to the proxy, to fetch information from the grid
requirements

good examples
get all relevant information from gridproxy

WIP: I just had an overview of that project and fixed some imports and build warnings.
I will create the examples next week isA

WIP:

update some imports and filters

I added examples for

Nodes

get all nodes

get nodes with some prop of NodeFilter

get node iteration

get node status by id

get node by available resources

gateway :

get all gateway nodes

get gateway with some prop of GatewayFilter

get gateway by node id

get gateway iteration

Farm :

get all farms

get farm with some  prop FarmFilter

get farm iteration

twin :

get all twins

get twin with some  prop TwinFilter

get twin iteration

stats :

get grid stats for online nodes and all nodes

contracts:

get all contracts
get contracts with some prop of ContractsFilter
get contracts iteration

Will add node statistics, ping, pgu , and will try to update the readme

all mentioned examples are ready and i create a pr #266 but got a comment, working on it

WIP: applied the required changes on most of example files, the remaining one is node examples.

https://github.com/freeflowuniverse/crystallib/pull/266/files


Split provider kubeconfigs into separate files

standup-kubeconfig secret now contains 3 files: aws, azure and kvm, each containing the kubeconfig for the corresponding installation

Looking magnificent - I assume this was tested?

It was, everything except the aws task.

Looking magnificent - I assume this was tested?

It was, everything except the aws task.

Let's go with this and then @xh3b4sd can retest from his side?


Bug in Merging Map Data with Trajectory Data(no predicted_map)

when i ran adaptor.py,it just couldn't generate the predicted_map,which is   needed in the training of HiVT,and this really confused me. I wonder if you once encounter the problem like this. Really hope i can get some help from you.

When running HiVT, I encountered an error indicating that predicted_map was missing. Therefore, I added two lines of code in adaptor.py to check if this component exists in the generated map, and the result showed that it does not.

Thanks for pointing this out!
The first thing I noticed is that the MapTR GT file should also be on the full val set, so the two progress bars should have the same counts.
Can I take a look at the command you run? I wonder if there are any file mismatches here. Just FYI, there are indeed some missing frame infos since trajdata cannot fully capture all the frames. This is why there is a try except block there. However the missing data should not be too much. After filtering out this missing info, and the frames that do not have future and history (which is the majority of filtering), the # of scenes in full_val should be 4519 -> so 4519 valid scenarios out of 6019 frames.

thank you so much for helping me,this is the code i ran
python adaptor.py
--version mini
--split mini_train
--map_model MapTR
--dataroot ../nuscenes
--index_file ../adaptor_files/traj_scene_frame_mini_train.pkl
--map_file ../mapping_results.pickle
--gt_map_file ../adaptor_files/gt_mini_val.pickle
--save_path ../trj_data/maptrv2

It should be --gt_map_file ../adaptor_files/gt_mini_train.pickle. Also, from your progress bar it seems that your mapping_results.pickle contains the estimated map of full val set, which does not match what you specified here (mini train).

I'm sorry, but there is no gt_mini_train.pkl file in your cloud drive, so we chose to use val instead.

and if i run the command like this, the same problem occur
python adaptor.py
--version trainval
--split train
--map_model MapTR
--dataroot ../nuscenes
--index_file ../adaptor_files/traj_scene_frame_full_val.pkl
--map_file ../mapping_results.pickle
--gt_map_file ../adaptor_files/gt_full_val.pickle
--save_path ../trj_data/maptrv2

Uh I see, sorry for the oversight. I probably thought mini train is not as important so did not put it up.
As for your second command, the split should be val I guess (instead of train)?

I'm very sorry to bother you multiple times. Actually, we are running the correct code, but we made a mistake in the comments section. Here is the part I re-ran, and you can see that this time I have used the complete dataset, but the issue of missing predicted_map still occurs.
tags: f'nusc trainval-boston-train''singapore-nusc trainval-tra].
Calculating Agent Data(serially): 100%500 scenes in the scene index.Creating scene Data Index(4 CPUs): 100%Index: 100%Structuring scene Data#

Moreover, in the training of HiVT, we are also unable to proceed due to this issue.

No problem at all! The command looks good to me. I just tried re-running on my side but it seems to be fine. To debug, can you maybe try running this on val only, and see whether val has this problem? or maybe on the mini_val set.

Thank you very much for your perfect work and your patient responses. This has been very helpful for us, and we have almost successfully replicated some of your results. However, I would like to point out that not all data in adaptor.py can generate predicted_map. I suggest adding a filtering feature before saving the processed data, otherwise there will be errors during the subsequent HiVT model training.

Thank you very much for your perfect work and your patient responses. This has been very helpful for us, and we have almost successfully replicated some of your results. However, I would like to point out that not all data in adaptor.py can generate predicted_map. I suggest adding a filtering feature before saving the processed data, otherwise there will be errors during the subsequent HiVT model training.

Hello, I have the same problem with you. How did you solve it and successfully train HiVT?

Thank you very much for your perfect work and your patient responses. This has been very helpful for us, and we have almost successfully replicated some of your results. However, I would like to point out that not all data in adaptor.py can generate predicted_map. I suggest adding a filtering feature before saving the processed data, otherwise there will be errors during the subsequent HiVT model training.

Hello, I have the same problem with you. How did you solve it and successfully train HiVT?

As I said before, add a filter before saving the ultimate data to make sure predicted_map exist may help you.

For debugging, can you maybe retrieve a sample token that corresponds to a pissing 'predicted_map', and then go back to mapping_results.pkl to see if there is any predicted map information corresponding to that sample token? As a reference, if things go smoothly this will generate a total of 15191 scenario files for full train.

Please refer to https://github.com/alfredgu001324/MapUncertaintyPrediction/issues/4 and https://github.com/alfredgu001324/MapUncertaintyPrediction/issues/13


Unable to run mtc_sample launch file

Hi, I am working on your package for using it with our project.
I tried launching the mtc_samples launch file but was unable to load the bt plugins.
I am getting the following symbol error.
Could you please provide me with the fix or solution for that.
I am using ubuntu 22.04 and moveit_task_constructor stable release for humble from source.
I have also attached the error screenshot.
Error:-
[INFO] [launch]: All log files can be found below /home/tcs/.ros/log/2024-09-10-12-22-35-661935-tcs-Precision-7710-100741
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [sample_bt_executor-1]: process started with pid [100742]
[sample_bt_executor-1] /home/tcs/Workspace/projects/3rdparty/BehaviorTree.ROS2/install/btcpp_ros2_samples/lib/btcpp_ros2_samples/sample_bt_executor: symbol lookup error: /home/tcs/Workspace/projects/3rdparty/BehaviorTree.ROS2/install/btcpp_ros2_samples/lib/btcpp_ros2_samples/sample_bt_executor: undefined symbol: _ZN2BT10Blackboard14rootBlackboardEv
[ERROR] [sample_bt_executor-1]: process has died [pid 100742, exit code 127, cmd '/home/tcs/Workspace/projects/3rdparty/BehaviorTree.ROS2/install/btcpp_ros2_samples/lib/btcpp_ros2_samples/sample_bt_executor --ros-args --params-file /home/tcs/Workspace/projects/3rdparty/MoveIt.BT/install/mtc_samples/share/mtc_samples/config/sample_mtc_executor.yaml'].

Sorry this library is highly subject to change, includes limited support, and assumes you know how to setup a colcon workspace. You appear to have a non-standard workspace that is missing dependencies from source.
You should have the following folder structure and rosdep should return success when ran in the root of your workspace.

colcon_ws/src/MoveIt.BT
colcon_ws/src/all packages listed here [you get these from running vcs import]

Hi @MarqRazz , Thanks for the response.


Save "How can we help you?" input and display while waiting

(context: at Hack@Brown)
It would potentially be a nicer user experience for the requestee to be able to view the form submission while waiting for a mentor – just to have a reference to what he/she requested help on.
If you agree, I could implement it if you don't want to.

(Also: can you enable issues in the lab6 repo?)

This would be a good feature!

Closing, added to #9


[db] [tx] Support :db.type/{instant,uuid,uri}

Over in #170, I simplified things by not including placeholders for Mentat value types I wasn't going to support at the start: :db.type/instant, :db.type/uuid, and :db.type/uri.  (We might consider supporting JSON and a binary blob type like :db.type/bytes as well.)
This ticket tracks supporting these types.  Off the top, this will mean:

Adding new DB_TYPE_* values to the bootstrapper;
Bumping the SQL schema to accommodate the new idents;
Adding new ValueType cases;
Adding corresponding TypedValue cases;
Implementing the conversions to and from SQL;
testing the new types in the transactor and potentially in the query engine as well.

There are some fledgling tests for SQL conversion (step 5. above) of other TypedValue instances around https://github.com/ncalexan/mentat/commit/3e3d74023fc0ed4c045f2f3a5f4abf5c8af8941b.  (They haven't landed quite yet.)
I expect the following encoding:

:db.type/instant <-> (SQLite INTEGER, tag 4)
:db.type/uuid <-> (SQLite TEXT, tag 11)
:db.type/uri <-> (SQLite TEXT, tag 12)

The value type tags above agree with those in the Clojure implementation: see https://github.com/mozilla/mentat/blob/master/src/common/datomish/sqlite_schema.cljc#L246.
Writing real tests isn't really possible until #214 and some follow-ups land, so step 6. above might need a follow-up ticket.

Filed #426, #427, #431 for this.


[WIP] BFP: Port read/write examples to bfp.js library

Opening the PR to be able to assign it to the issue.

I tagged this PR with [WIF] to signal a Work In Progress. When this PR is ready for code review, remove the [WIF] tag from the title.

@christroutner still work in progress, but I would strongly recommend that we have a short chat about the sections marked as //TODO inside the code base (or you can check the code and comment inline next to the //TODO tags)
Several questions came up about the specification of the implementation
I am also running into some error messages that I do not understand, would probably help a lot if you would look at these for just a few minutes.

You can also just run npm test and then you will see an error message coming up as the first log output (while all the tests are running green anyway) I do not understand why the tests are running green even as the compiler throws some error.

:tada: This PR is included in version 1.0.1 :tada:
Your semantic-release bot :package::rocket:

303 PSF tokens awarded. TXID:
c5a471ae4ec7976fc5d082cf9c4982e7393fb59c80235ff93755944890bb1e4a


[fix][sec] Fix transitive critical CVEs in file-system tiered storage

Motivation
Currently the file-system tiered storages brings in the following CVEs:

CVE-2023-1436 (from jettison)
CVE-2023-1370 (from json-smart)
sonatype-2022-5820 (from hadoop 3.3.3)

Modifications
All the above are depending from hadoop.

Upgraded hadoop from 3.3.3 to 3.3.5 - removed the jersey-json override since the dependency has changed (https://issues.apache.org/jira/browse/HADOOP-15983)
Upgraded jettison from 1.5.3 to 1.5.4
Upgraded json-smart from 2.4.7 to 2.4.10

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19957 (7f86e70) into master (7a99e74) will increase coverage by 40.93%.
The diff coverage is 79.41%.

@@              Coverage Diff              @@
##             master   #19957       +/-   ##
=============================================
+ Coverage     31.88%   72.81%   +40.93%
- Complexity     6421    31484    +25063
=============================================
  Files          1682     1859      +177
  Lines        127354   136851     +9497
  Branches      13892    15050     +1158
=============================================
+ Hits          40601    99653    +59052
+ Misses        80714    29275    -51439
- Partials       6039     7923     +1884

Flag
Coverage Δ

inttests
24.39% <0.63%> (-0.12%)
:arrow_down:

systests
25.10% <2.54%> (+0.01%)
:arrow_up:

unittests
72.08% <79.41%> (+54.81%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...dbalance/extensions/ExtensibleLoadManagerImpl.java
80.33% <0.00%> (+77.63%)
:arrow_up:

.../loadbalance/extensions/data/BrokerLookupData.java
88.88% <0.00%> (+88.88%)
:arrow_up:

...sar/common/policies/data/stats/TopicStatsImpl.java
93.87% <50.00%> (+59.39%)
:arrow_up:

...ache/pulsar/broker/namespace/NamespaceService.java
69.53% <62.50%> (+33.16%)
:arrow_up:

...r/delayed/bucket/BucketDelayedDeliveryTracker.java
82.40% <77.90%> (+82.40%)
:arrow_up:

...ache/pulsar/io/kafka/connect/KafkaConnectSink.java
74.01% <90.90%> (ø)

...che/bookkeeper/mledger/impl/ManagedCursorImpl.java
79.04% <100.00%> (+39.22%)
:arrow_up:

...pache/pulsar/broker/admin/impl/NamespacesBase.java
71.80% <100.00%> (+47.29%)
:arrow_up:

...layed/bucket/CombinedSegmentDelayedIndexQueue.java
100.00% <100.00%> (+100.00%)
:arrow_up:

...ommon/policies/data/stats/ReplicatorStatsImpl.java
95.83% <100.00%> (+95.83%)
:arrow_up:

... and 1 more

... and 1455 files with indirect coverage changes

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label


Config doesn't load automatically in Lunarvim

I am using lunarvim based on the lastest version of Neovim and every time I open a file, my config doesn't work and I get no indent lines. I have to write and source my config.lua and wait quite a few seconds to get it working.
My config
--Indent Line Configuration
require("indent_blankline").setup({
char = "┃",
space_char_blankline = " ",
char_highlight_list = {
"IndentBlanklineIndent1",
"IndentBlanklineIndent2",
"IndentBlanklineIndent3",
"IndentBlanklineIndent4",
"IndentBlanklineIndent5",
"IndentBlanklineIndent6",
},
})
vim.opt.termguicolors = true
vim.cmd([[highlight IndentBlanklineIndent1 guifg=#E06C75 gui=nocombine]])
vim.cmd([[highlight IndentBlanklineIndent2 guifg=#E5C07B gui=nocombine]])
vim.cmd([[highlight IndentBlanklineIndent3 guifg=#98C379 gui=nocombine]])
vim.cmd([[highlight IndentBlanklineIndent4 guifg=#56B6C2 gui=nocombine]])
vim.cmd([[highlight IndentBlanklineIndent5 guifg=#61AFEF gui=nocombine]])
vim.cmd([[highlight IndentBlanklineIndent6 guifg=#C678DD gui=nocombine]])
It's from here, I have only removed the three lines in the middle that add additional characters.

This config looks fine, it should work.
The problem is probably somewhere else.


Doorway FE Component Audit

https://www.notion.so/exygy/Doorway-Engineering-Component-Audit-b657c6ca0ab74559afbc292d3a9b4898
In Notion, create an audit of Doorway implementation of UIC. This audit should contain the following:

List components that were edited by DW
Generate Recommendations for where the theming and/or uptake takes place (local, UIC or Seeds)

closed, transferred to other repo