fix: prevent callback from being called twice

Details

Previously, pressing CMD+Enter (or a different key and a modifier) would trigger a listener twice due to a missing check for the correct modifier flags.
Fixed Issues

$ https://github.com/Expensify/App/issues/23395
PROPOSAL: https://github.com/Expensify/App/issues/23395#issuecomment-1646602158
Tests

Click on the FAB
Go to Request money
Click on the currency symbol to open the currency selector
Press CMD+Enter
Verify that the currency selector is closed, returning the user to the enter money amount page

[X] Verify that no errors appear in the JS console

Offline tests

Click on the FAB
Go to Request money
Click on the currency symbol to open the currency selector
Press CMD+Enter
Verify that the currency selector is closed, returning the user to the enter money amount page

QA Steps

Click on the FAB
Go to Request money
Click on the currency symbol to open the currency selector
Press CMD+Enter
Verify that the currency selector is closed, returning the user to the enter money amount page

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/react-native-key-command/assets/137707942/6365d564-f145-44e1-a270-df8e93598c69

Mobile Web - Chrome

https://github.com/Expensify/react-native-key-command/assets/137707942/90ae6b36-7461-4152-acc0-b1ad815c1253

Mobile Web - Safari

https://github.com/Expensify/react-native-key-command/assets/137707942/31d9aac9-cf0f-456f-83b7-6921145376b9

Desktop

https://github.com/Expensify/react-native-key-command/assets/137707942/34170610-10e6-4592-b7e6-17c424dbf796

iOS

https://github.com/Expensify/react-native-key-command/assets/137707942/6f56aad8-32a5-4af9-b273-4adbdba5bdee

Android

https://github.com/Expensify/react-native-key-command/assets/137707942/32188ce5-b7d5-4a27-a445-0917f3f4ab1c

Sorry for the delay. I'm in some sort of time, so I'll review this PR in the morning 🙏

Sorry for the delay. I got sick last week 🙏
It tests well on Web, mWeb, and Desktop. For iOS, I only test it with a macbook on-screen keyboard.
For Android, the result is different. Test on the emulator and on-screen keyboard is working well on the CMD+Enter for selecting the currency option. Another test I do is build the app on an Android physical device and connect an external keyboard, but CTRL+Enter results dismiss the page instead of selecting the currency.
https://github.com/Expensify/react-native-key-command/assets/25520267/b1c0bb96-db75-4378-8581-c3d37f6a39cd

On android perhaps it's caching the package and needs npm run clean before building

Thanks @samh-nl this might be it. I'll try to clear the catch first.

@samh-nl I cleared the cache when running the Android build, but the issue still persists on the physical device.

I'm not really sure, The issue you mention above seems specific to Safari, but that only dismisses the page on Tab then Enter. Works fine on Tab, then CMD+Enter.
My issue here is related to the CTRL+Enter, on the highlighted item. Meanwhile, Safari with Tab doesn't highlight the item, and pressing CMD+Enter doesn't select the focused item (it seems different between focused and highlighted items).
I'll do another test in the morning.

I just did another test on Android with the latest main. I couldn't reproduce the issue here, so I think we are good to go.

Hey @mollfpr would you mind doing a quick faux-checklist? I know its not required in these repos but it would be nice to capture your testing there

@samh-nl I tested again on Android with the latest main. Apparently, the arrow key is not working in this PR.

Main
This PR

Thanks @samh-nl for the update, and the investigation. I'll retest the PR soon.

Android tested on Samsung device.
Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/react-native-key-command/assets/25520267/3708b0a4-af86-45d6-9b8b-746d5519e912

Mobile Web - Chrome

https://github.com/Expensify/react-native-key-command/assets/25520267/f7f5841e-1074-4ad5-bd45-b6cf428a7e62

Mobile Web - Safari

https://github.com/Expensify/react-native-key-command/assets/25520267/de108ce9-8926-4346-80a8-160c2863f5b4

Desktop

https://github.com/Expensify/react-native-key-command/assets/25520267/708f21ce-cfe9-4d1f-a9d2-95061a0b1954

iOS

https://github.com/Expensify/react-native-key-command/assets/25520267/6990f428-ef9b-43cd-a591-e098c84c3e55

Android

https://github.com/Expensify/react-native-key-command/assets/25520267/5c6f064f-9f5e-40ea-90f9-abec6803626c

Friendly bump @johnmlee101 for final review.


[APTT-430] should not collects measurements that do not have a metric when enableNonMetricMeasurement = false

Codecov Report

Merging #45 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%
==========================================
  Files          25       25
  Lines        1290     1292       +2
==========================================
+ Hits         1142     1144       +2
  Misses        148      148

Impacted Files
Coverage Δ

RPerformanceTracking/Private/_RPTSender.m
85.71% <100%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8635c08...4618eae. Read the comment docs.


reset only works on fields where initialValue is set

When using reset with controlled fields, it works only for fields which are created with initialValues in the form options.

Thank you for reaching out! What framework are you using?

I am using Solidjs.

It works for me without initial values: https://stackblitz.com/edit/modular-forms-solid?file=src%2Froutes%2Flogin.tsx

Thank you, I will investigate further.

Make sure your fields are controlled: https://modularforms.dev/solid/guides/controlled-fields


Godot is unable to switch processes when Windows Terminal is the default console host

Godot version
3.4
System information
Windows 11 Insider Preview build 22489
Issue description
Godot is unable to switch processes from the Project Manager to the Editor be it by creating a new project or loading an existing one as long as Windows Terminal is the console host rather than cmd.exe.
Launching Godot through Powershell in Windows Terminal works fine, however.
I'm not sure what the cause is, I don't see any sign of an error message, Godot just silently fails to open the editor and closes.
This bug may be important in the future as it's quite possible Windows Terminal will eventually completely replace cmd.exe. Though this might be an issue with Windows Terminal and not Godot.
Steps to reproduce
Install Windows Terminal from the Microsoft Store, open Windows Terminal, open settings (Ctrl + ,), change the default terminal from Windows Console Host to Windows Terminal.
Minimal reproduction project
No response

Duplicate of #54076


Improvements

Codecov Report
Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (205cf10) 2.27% compared to head (d4bd0f5) 2.10%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #30      +/-   ##
========================================
- Coverage   2.27%   2.10%   -0.18%
========================================
  Files         10      10
  Lines       1404    1519     +115
  Branches     243     270      +27
========================================
  Hits          32      32
- Misses      1367    1482     +115
  Partials       5       5

Files
Coverage Δ

etpclient/utils.py
20.51% <0.00%> (-0.41%)
:arrow_down:

etpclient/websocket_manager.py
0.00% <0.00%> (ø)

etpclient/etp/serverprotocols.py
0.00% <0.00%> (ø)

etpclient/etp/requester.py
0.00% <0.00%> (ø)

etpclient/main.py
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make quiet even more quiet

I'm running Arch Linux, Deno 1.15.1, and Lume v1.1.1:
[x80486@uplink:~/lume-template]$ uname -a
Linux uplink 5.10.72-1-lts #1 SMP Sat, 09 Oct 2021 17:34:39 +0000 x86_64 GNU/Linux
[x80486@uplink:~/lume-template]$ deno --version
deno 1.15.1 (release, x86_64-unknown-linux-gnu)
v8 <IP_ADDRESS>
typescript 4.4.2
[x80486@uplink:~/lume-template]$ lume --version
v1.1.1

I'm building a sample project with lume --quiet, but still, there is a lot of output in the console:
[x80486@uplink:~/lume-template]$ lume --quiet
Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>... many many more!

I'm assuming that with --quiet Lume will only show warnings and/or errors, which is what I'm expecting with this. So is it possible to make --quiet to remove those Download ... statements as well?

This one is more towards CI/CD workflows, where all that output is not really needed...but if they come Deno, it's going to be tricky to "mute" them. Not sure if Deno has anything for that 🤔

I just made a commit to this. It will be available in the next version.


Does electron enable drag-and-drop uploads

Does electron enable drag-and-drop uploads

Not yet. trzsz.js will support the feature.
It should be an api of TrzszFilter and TrzszAddon. I may name it uploadFiles.
The client of trzsz.js can listen on the drag event, and call trzsz.js api to upload the dragging files.
See also:
https://www.electronjs.org/docs/latest/tutorial/native-file-drag-drop
https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API/File_drag_and_drop

I'm looking forward to this feature being developed

v0.4.0 supports dragging files and directories to upload.

Drag and drop uploads work fine, the display is just a little unfriendly.

I've try to hide the trz. Sounds like it's not working.
https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L130-L139
Could you try to figure out why?

What's the type of the server output? Blob, or Uint8Array, or ArrayBuffer?

https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L233
Although the complete command is sent here, "processServerOutput" may receive split characters.

Maybe. Could you print some log in here?
https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L130-L139

I've tested it many times. Sometimes it's a different result.

Is it Uint8Array? It may has some characters unprintable. Could you print the char codes too?

I've tested it many times. Sometimes it's a different result.

Collect all the cases, we can do it. We need to print each ascii code.

If no breakpoint is set, the returned data is the same, but after setting a breakpoint, the automatic upload will be disabled and a file selection dialog will be prompted.

Could you print the printable log and char codes together? It would be easy to analyze. Thanks very much.

https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L130-L139
If no breakpoint is set, the returned data is the same, but after setting a breakpoint, the automatic upload will be disabled and a file selection dialog will be prompted.

The reason is:
https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L235-L245

I think "trz" can be displayed in "xterm", but it needs the correct line break.

I think "trz" can be displayed in "xterm", but it needs the correct line break.

But we need to figure out the server output first. Could you print the printable log and ascii codes together?

Is that right?

That's it. Thanks.
Looks like I have to learn more about vt100.

@wenbingzhang If just remove these code, What will it show?
https://github.com/trzsz/trzsz.js/blob/7f43fe43f63a8271ec36107765e50426b555d583/src/filter.ts#L130-L139

It looks not bad.
Type some garbage into the command line without a carriage return, what will it show after dragging files to upload?
And If move the cursor to the middle of the garbage, what will it show after dragging files to upload?

All right. I want to keep the garbage unchanged.
Since it doesn't work in some environments ( e.g., yours ), I'm going to remove it.

It has been updated and tested, and it works fine.

@wenbingzhang
Thanks for your feedback.


[occm] Add error message in RegisterCloudProvider()

What this PR does / why we need it:
RegisterCloudProvider() calls NewOpenStack() but we cannot see the root cause if an error happens due to lack of actual error message.
This adds the error message in log output.
Special notes for reviewers:
Now I am facing an issue failed to deploy occm from Kubespray and it is hard to debug it because of this lack of the error message.
Release note:

NONE

/test pull-cloud-provider-openstack-check

I guess I am facing the issue of https://github.com/kubernetes-sigs/kubespray/pull/6262 on Kubespray.
This PR will be helpful to investigate this kind of issues.

/test pull-cloud-provider-openstack-check

/test pull-cloud-provider-openstack-check

/test pull-cloud-provider-openstack-check

/retest

The conformance test failure(s) we see here have reported: https://github.com/kubernetes/kubernetes/issues/91739

/lgtm
seems such change don't need wait conformance test but better to have

/test pull-cloud-provider-openstack-check

/cc @dims
Please take a look :-)

/approve
next time please ping @ramineni :)

@dims Thanks!
OK, I will do it next time.

seems https://github.com/kubernetes/kubernetes/issues/91739 still under discussion
so maybe need wait more time on it..

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

/lgtm
/approve


Adding spectra tests back into carthage friendly base.

You will need to merge the other pull request first.
This request adds the spectra tests into the new carthage project.
I added the tests and dependencies in. Without PCH files, I added missing headers. Which resulted in duplicate symbol issues with the test support headers which declared global blocks. Converting the blocks to C functions. I've not seen blocks used or declare like this before. They appeared to act pretty much like C functions, however I found that there where problems when they where imported in more than one test class.
Anyway, results are all green now.
Not sure if you want to go this direction or not.

Thanks for this - I'll take a look at it tomorrow :+1:


Excel load read the result only of the last column

I have a Excel file with 6 columns. When i use
$excel=Excel::load($destinationPath.'/'.$filename,function ($reader) {
    $reader->each(function($sheet) {
        // Loop through all rows
        $sheet->each(function($row) {
            // Here i supposed to get the values of 6 columns
            // But i got only the value of the last column
            dump($row);
        });
    });
})

Can someone tell me what i did wrong or this is a bug ?

If you have only 1 sheets, the first loop will be the rows. You can disable this behaviour in the config.

even if i do only import like this
$excel = Excel::load($destinationPath . $filename)->all()->toArray();
dd($excel);

I still got the result only of the last column. Im working on laravel 4.2 now.
The project on laravel 5.1 has the same plugin and import the same file properly.
So i dont even know what the problem is.

in the end , i have to use  PHPExcel functions to get all information. For those who have the same problem like me
			$excel = [];

			Excel::load($destinationPath . $filename, function($reader) use (&$excel) {
                $objExcel = $reader->getExcel();
                $sheet = $objExcel->getSheet(0);
                $highestRow = $sheet->getHighestRow();
                $highestColumn = $sheet->getHighestColumn();

                //  Loop through each row of the worksheet in turn
                for ($row = 1; $row <= $highestRow; $row++)
                {
                    //  Read a row of data into an array
                    $rowData = $sheet->rangeToArray('A' . $row . ':' . $highestColumn . $row,
                        NULL, TRUE, FALSE);

                    $excel[] = $rowData[0];
                }
            });

Thanks rpg999

Still re-occuring in Laravel 5.2.
Excel::load('file.xls', function($reader) {
// Getting all results
$results = $reader->get();
});
After pulling this the '$results' variable only returns a collection of the last column.

wish I came here sooner.. been trying to understand wth is going on for over an hour. I am too getting the same result.. trying to iterate through rows and only getting the last column.
I will try rpg999's code now

Will respond the same thing I responded last October:
"If you have only 1 sheets, the first loop will be the rows. You can disable this behaviour in the config."
Link to config: https://github.com/Maatwebsite/Laravel-Excel/blob/2.1/src/config/excel.php#L458
From the docs:
The ->get() and ->all() methods will return a sheet or row collection, depending on the amount of sheets the file has. You can disable this feature inside the import.php config by setting 'force_sheets_collection' to true. When set to true it will always return a sheet collection.

No need to change the package or mess with PHPExcel native methods. Just change the config setting ;)

Thank you rpg999,
I've tried set the config to force sheets collection, and get absolutely no help.

I see no change by making force_sheets_collection true over false, other than the result is wrapped by another object.

Because the reader use the first row as the attributes name of the result array. So you have to make  the first row column names valid, eg valid variable name.

i try to import data from excel sheet put reader->all() function retrieve empty value
$data = Excel::load($path, function ($reader) {
        $results  = $reader->all();
        $firstrow = $reader->first();
        dd($results);

    });

get the same problem, Everything is empty and still don't know why. My excel file has 3 sheets and 68 columns each sheet, maatwebsite load exactly 3 sheets and 68 columns, but all content is empty. I will try PHPExcel instead.

Excel::load($file)->noHeading()->all()->toArray();
noHeading() works


Remove deprecated mesh expansion settings

This is no longer the recommended or documented
It has been deprecated for a while, with warnings, etc
It is broken (https://github.com/istio/istio/issues/27645)

fixes https://github.com/istio/istio/issues/27645
fixes https://github.com/istio/istio/issues/25933
The PR is bigger than it needs since this required updating the snapshots. View only the first commit if you want to ignore the noise.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
4bcd507f45dcdec13b3b5caba454ad2cc4677f97
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest


Line number cannot be highlighted

When I click to modify the row style, the row numbers are not highlighted like in Codesnap Plus
Is it possible to add a line number highlighting effect similar to mouse hovering to the rows with style, just like the mouse hovering on the fifth row?

I think I will add an option to enable or disable line number highlight, so we can have both behaviors

CodeSnap Plus has some bugs like this, I unhighlighted the line and the hover effect persists. I need to think how to update hover effect to work with hightlight too

CodeSnap Plus has some bugs like this, I unhighlighted the line and the hover effect persists. I need to think how to update hover effect to work with hightlight too

Yes, I also encountered this problem while using CodeSnap Plus

In some minutes, the version 1.15 will be available fixing this. I added a new option to highlight the line number, it's false by default to keep the default behavior, but it can be activated easily by one time config menu!

Problem solved perfectly
Thank you for your efforts
Easy CodeSnap is the best screenshot extension I have ever used


[WIP] deps: bump kubernetes-sigs/karpenter

Fixes #N/A
Description
Bumps kubernetes-sigs/karpenter to v0.32.4. Also renames the create-cluster composite action to setup-cluster to enable E2E testing for release.
How was this change tested?
/karpenter snapshot
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.355%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6175

Relevant Lines:
7498

💛  - Coveralls

Ran E2E tests with a workflow dispatch, all good 🎉 The upgrade test failed do to a miss in the repo update for the v0.32.x branch but all the suites passed. link


Ui deploy

Actually, this is still a WIP.
I'm testing / validating it works w the dash images that we've pushed. And we probably want to include the pachctl --dash-image flag as part of this PR as well

I did not include any of the new features (dash images flag, or portforwarding), but just fixed a bug in the grpc image name and merged in / resolved master. Could probably use another review.


Sorting of array using stack in c++

I want to  add technique of sorting of array using stack in c++.Please assign this issue to me

Need to add a description and your approach. Thanks, Closing as of now.


Is text supported?

Can I add text somehow through this library? i.e.
Plane.addText({position..., content: 'example'});

Hi dmr07, text is supported now. You can use it through this.arkit.addText. Please see readme for more details.


npm installs fail if hardlinks not supported on file system

What happened?
I'm running this on AKS using Azure Files for persistence, which doesn't support hard links. If I enable persistence on /data, I start getting errors when I try to run npm install (either through the manage palette page or running npm i manually).
Error log
2023-01-03T21:46:21.478Z npm install --no-audit --no-update-notifier --no-fund --save --save-prefix=~ --production --engine-strict<EMAIL_ADDRESS>2023-01-03T21:46:22.189Z [err] npm
2023-01-03T21:46:22.189Z [err]  WARN
2023-01-03T21:46:22.189Z [err]  config production Use `--omit=dev` instead.
2023-01-03T21:46:22.644Z [err] npm
2023-01-03T21:46:22.644Z [err]  ERR! code ENOTSUP
2023-01-03T21:46:22.644Z [err] npm
2023-01-03T21:46:22.644Z [err]  ERR!
2023-01-03T21:46:22.644Z [err]  syscall link
2023-01-03T21:46:22.644Z [err] npm ERR!
2023-01-03T21:46:22.644Z [err]
2023-01-03T21:46:22.645Z [err] path /data/.npm/_cacache/tmp/78da15c8
2023-01-03T21:46:22.645Z [err] npm ERR! dest /data/.npm/_cacache/content-v2/sha512/71/6f/d7852a119e0ba4879feb7f584dc48ed54bd579c78f809b3af2188d89a3fc5fd14a421e419c3fa720905d8b7b5f2f42c76816907b0a160a50c78c3d57825b
2023-01-03T21:46:22.645Z [err] npm ERR! errno ENOTSUP
2023-01-03T21:46:22.647Z [err] npm ERR! Invalid response body while trying to fetch https://registry.npmjs.org/node-red-contrib-postgresql: ENOTSUP: operation not supported on socket, link '/data/.npm/_cacache/tmp/78da15c8' -> '/data/.npm/_cacache/content-v2/sha512/71/6f/d7852a119e0ba4879feb7f584dc48ed54bd579c78f809b3af2188d89a3fc5fd14a421e419c3fa720905d8b7b5f2f42c76816907b0a160a50c78c3d57825b'
2023-01-03T21:46:22.648Z [err]
2023-01-03T21:46:22.648Z [err] npm ERR!
2023-01-03T21:46:22.648Z [err]  A complete log of this run can be found in:
2023-01-03T21:46:22.648Z [err] npm ERR!     /data/.npm/_logs/2023-01-03T21_46_22_092Z-debug-0.log
2023-01-03T21:46:22.674Z rc=1

How can we reproduce this?
Here's my configuration
aks storage class (terraform config) and helm chart
resource "kubernetes_storage_class" "nodered" {
  metadata {
    name = "nodered"
  }
  storage_provisioner = "file.csi.azure.com"
  reclaim_policy      = "Retain"
  parameters = {
    skuName = "Standard_LRS"
  }

  mount_options = ["dir_mode=0777", "file_mode=0777", "uid=10003", "gid=10003", "serverino", "mfsymlinks"]
}

resource "helm_release" "nodered" {
  chart      = "node-red"
  name       = "nodered"
  repository = "https://schwarzit.github.io/node-red-chart/"
  namespace  = var.namespace

  values = [
    replace(templatefile("${path.module}/values/nodered.values.yml", {
      domain             = "${var.nodered_subdomain}.${var.domain}"
      settings_config    = kubernetes_config_map.nodered_settings.metadata[0].name
      storage_class_name = kubernetes_storage_class.nodered.metadata[0].name
    }), "/^\\s*#.*\\n?/", "") # removes comment lines :)
  ]
}

values.yaml
metrics:
  enabled: true
persistence:
  enabled: true
  storageClass: "${storage_class_name}"
ingress:
  enabled: true
  annotations: # {}
    kubernetes.io/ingress.class: traefik
    traefik.ingress.kubernetes.io/router.entrypoints: websecure,web
  hosts:
    - host: ${domain}
      paths:
        - path: /
          pathType: ImplementationSpecific
settings:
  name: nodered-settings-config
  configMapName: ${settings_config}

Helm Chart version
0.21.3

Search

[X] I did search for other open and closed issues before opening this.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Additional context
Solution
I was able to solve it by:

allowing the user to write to /usr/src/node-red

securityContext:
  readOnlyRootFilesystem: false
  runAsGroup: 1000
  runAsUser: 1000

writing this to /usr/src/node-red/.npmrc

cache="/usr/src/node-red/.cache"

But it would be great if your npmrc: config field accepted a free-text field (e.g. npmrc.contents) to insert values like this from the values.yaml file.

Hi @beasteers,
Thanks for creating the issue!
I added now a new value nmprc.content, where you can set all your custom npmrc config.
npmrc:
  # -- Enable custom npmrc config
  enabled: false
  # -- Configuration to use any compatible registry
  registry: "https://registry.npmjs.org"
  # -- Configuration to add custom npmrc config
  content: |
    # Custom npmrc config

This feature is now available in the chart version > 0.22.0

thanks so much! that was fast ✨


feat(CsrfResponseFilterMiddleware): use response filter instead of re…

…sponse filter strategy
This seems to be more intuitive and the library users can swap strategies.  This also allows for removing filter strategies in the future if it is determined to be simpler.
BREAKING CHANGE: Use a response filter to create CsrfResponseFilterMiddleware instead of a response filter strategy.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.591%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
85

Relevant Lines:
88

💛  - Coveralls


Adding Achievement badges

Adding Achievement badges for pull requests to the repo. e.g. https://github.com/opensearch-project/opensearch-build/pull/3305 using github-merit-badger.

Merged :)


Support for additional projects in artist channel

Please add support in my (Eric De Giuli)'s channel for my projects Glass (344) & Mazinaw (288), and for my ArtBlocks Engine project (with PROOF) 'cathedral study'. Thanks

Passing your way for triage @grantoesterling @Asupkay


[AMD] OptimizeLDSUsage pass

This PR inroduces OptimizeLDSUsage pass which generalizes LDS optimization, which was part of DecomposeUnsupportedLayouts pass.

To clarify, what this PR is doing:
At the moment we have an optimization in DecomposeUnsupportedLayouts pass, which is looking for convert_layout operations that requires more shared memory, than we have. Optimization tries to decompose such convert_layouts in two converts with some intermediate layout, In many cases this helps to reduce LDS usage.
Current approach can not optimize convert_layout in hopper flash attention test, so LDS overflows.
This PR introduces two things:

adding more intermediate layouts variants
doing global analysis, to catch convert_layout operation which do not overflow LDS on its own, but overflows memory if there are some shared tensors.

First item is needed, because old set of intermediate layouts was not able to optimize conversions found int hopper FA.
Second item is needed to generalize optimization. For example, take a look at this example:
 %1 = triton_gpu.local_alloc %arg0 : (tensor<128x128xf16, #blocked>) -> !tt.memdesc<128x128xf16, #shared>
 %2 = triton_gpu.convert_layout %arg1 : tensor<128x128xf32, #blocked> -> tensor<128x128xf32, #mma>
 %3 = triton_gpu.local_load %1 : !tt.memdesc<128x128xf16, #shared> -> tensor<128x128xf16, #triton_gpu.dot_op<{opIdx = 0, parent = #mma}>>

%1 consumes 16 KB of LDS, %2 requires ~64KB of lds for a scratch buffer.
If there are no padding, %2 can be exactly 64KB, which fits into LDS, but %1 and %2 together do not.
P.s. I had some concerns that new optimization can affect existing benchmarks. I had an offline conversation with author of original optimization (@oplavsic) and we decided that best to leave old optimization functionally same, but move some functions in common place and make them parameterizable.

@binarman I have a question regarding tryMinimizeLDS.

%1 consumes 16 KB of LDS, %2 requires ~64KB of lds for a scratch buffer.
If there are no padding, %2 can be exactly 64KB, which fits into LDS, but %1 and %2 together do not.

In this example, %2 will be a candidate from findLDSBottleneck, and tryMinimizeLDS is called on it. However, tryMinimizeLDS will early return since currLDSUsage <= LDSSize. I think the problem is that tryMinimizeLDS should not take LDSSize as target, instead it should take LDSSize - offset as target, where offset can be kept when we look for candidates in findLDSBottleneck.

@zhanglx13 about tryMinimizeLDS
Condition is filters out cases which will definitely overflow LDS and there are no early exit.
We can actually remove this condition at all, because we are looking for the smallest LDS usage anyway.

the early return condition needs to be removed

Now I see, I've missed this early return, thank you!
At first I thought you were talking about early exit from loop.

(coverting to draft as we chatted--need to first get all issues addressed from AMD side before making it as open)

@antiagainst @zhanglx13
This PR is ready for review, PTAL :slightly_smiling_face:

@zhanglx13 @antiagainst  PTAL

what's the status on this pull request? Do we still need it?

I don't think we should focus on this at the moment, because it is not blocking anything and no test/kernel requires this change.
But I still want to have this change at some point.
I have used this change few times during debug: adding device prints increases LDS consumption and normally working test can overflow LDS.

I've moved refactoring of DecomposeUnsupportedConversions.cpp to separate PR #4262 so now here we have only changes related to new pass. Hope this will make review slightly easier.


Reorganize tests and add SameNameRecipe tests.

Several objectives in this PR:

Move the existing test project into a Tests subdirectory (we should have a whole bunch of test projects, so let's tuck them away from normal view).
Moved the JSON-builder helper classes into a TestsHelpers project.
Added a project Procurement.Tests with tests for classes in the Procurement project.
Added a RecipesTest class with tests (as an initial version) for the SameNameRecipe class.  These cover the changes in #815.

As I referenced in one of the commit messages, there are a lot of classes or methods which are private or internal.  I don't see a reason for them to not be public, so I have been changing them to public, as needed, to write tests.

Nice work!


Repo sync for protected CLA branch

The pull request is created from public637915990062143528 to public to fix git push error for protected CLA branch

  Caution: Large pull request
This public repo applies limits on the number of files that can be merged in a single pull request (PR):

Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
Block Block message and PR is blocked - 100

This pull request will change 71 files, which exceeds the warning limit of 71.
Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.
The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.
To merge this pull request
If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

To reject this pull request
If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.
* You must have write or triage access to this repo to add labels.


implement show only preview feature using toggle button

I implement a show only preview toggle button
On small screens, the toggle button below disappears.
On larger screens, it should look like the video below.

https://github.com/user-attachments/assets/d0fa24fc-e82c-4fe3-81f9-11ea2eb3c956
close #290

Feedback
I'm not sure what to do with the provider / inject key name.
I'm not sure if the button text 'show preview' is correct from the user's point of view.
Please let us know what you think and we'll take it into account.


How can I evaluate on test data without annotation(metainfo)?

I followed all the instructions to train the model, and I validate the performance using validation video data.
I wanted to make submission file by evaluating on test video data, but I found out there is no det_2d.json file for test data.
I checked the dataset downlaoding url (https://dl.cv.ethz.ch/shift/continuous/videos/1x/test/front/) but there is no annotation file for test data.
Your sciprts use annotation data for validation and testing .
Without the annotation file, the error occurs and fail to load dataset.
Where can I get det_2d.json file for test data?
It seems I need annotation json file that at least contains meta information of test data to load on dataset.
Or How can I run test evaluation without annotation file?
Please help me.
Thank you.

Hi @ta3h30nk1m, thank you very much for reaching out and reporting the problem. It was a problem on our side. We just fixed it, and the json file should now be available.
Good luck!


More accurately - removing router component (instead of unloading)

Summary:

Component csPageRouter removed
New component csWizardComponent

contains cs-wizard directive
It is needed because ui-router cannot call directives
It aligns the cs-wizard into the middle of the page

cs-settings-provider contains the csWizardComponent for the url paths
cs-wizard loads the needed data on its own if no csWizardOptions input data has been defined
New factory: csLog

A directive's or component's scope is extended with the 'log' function
The log msg is extended with the component name and the time elapsed from the last log

cs-form css update for the submit and cancel buttons

Wasn't it possible to 'convert' the current cs-wizard directive into a component? As far as I remember there is an ongoing effort to make everything a component so that we can upgrade to higher versions of angular, this change could make the transition easier.
Now we have a new component which is basically empty, contains some alignment related divs and a cs-wizard with all bindings simply wired through it - no code at all. Seems a bit redundant.

Clicking on 'New' for any resource causes a blank modal popup, without any content.


AMD GPU Arch - Deprecated

gcnArch was deprecated in ROCm 3.7. Instead, gcnArchName was introduced. gcnArch was never removed but announced that it will be done in ROCm 5.5 via https://rocm.docs.amd.com/en/docs-5.5.1/CHANGELOG.html#future-changes. So now it is intended to be done in ROCm 6.0.
gcnArch present in RPP source code at below places:
Can you please review the below lines of code and stop using gcnArch if still used:
src/modules/hip/handlehip.cpp:    std::string n("gfx" + std::to_string(props.gcnArch));
src/modules/hip/hipoc_program.cpp:      std::string gfxName = "gfx" + std::to_string(props.gcnArch);

fixed in PR#199

#199

Fix on TOT


@MyBatisResourcesScan occurred error on windows about mapperLocationPatterns

My code is like this below:
@MyBatisResourcesScan(mapperLocationPatterns = "classpath*:**/mapper/*Mapper.xml")
The error log :(Removed private information)
java.io.UncheckedIOException: org.springframework.core.NestedIOException: Invalid URI [jar:file:G:.m2\repository\net\xxxxx\user-base\1.0.0\user-base-1.0.0.jar!/base/mapper/SysUserMapper.xml]; nested exception is java.net.URISyntaxException: Illegal character in opaque part at index xx: jar:file:G:.m2\repository\net\xxxxx\user-base\1.0.0\user-base-1.0.0.jar!/base/mapper/SysUserMapper.xml
This error should be caused by windows backslashes, I don't know how to fix it.

I wrote a demo, the link is below
https://github.com/iygnol/mybatis-springnative-demo
------------------ 原始邮件 ------------------
发件人:                                                                                "mybatis/spring-native"                                                                                @.>;
发送时间: 2022年6月5日(星期天) 上午10:25
@.>;
<EMAIL_ADDRESS>主题: Re: [mybatis/spring-native] @MyBatisResourcesScan occurred error on windows about mapperLocationPatterns (Issue #22)
@iygnol Cloud your provide a small reproduce project via GitHub?
—
Reply to this email directly, view it on GitHub, or unsubscribe.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@iygnol Thx for providing reproduce project!! I can reproduce this issue my local environment.

@iygnol I've fixed this issue and published SNAPSHOT version on Sonatype OSS repository.

Thank you!
------------------ 原始邮件 ------------------
发件人:                                                                                "mybatis/spring-native"                                                                                @.>;
发送时间: 2022年6月6日(星期一) 凌晨0:14
@.>;
<EMAIL_ADDRESS>主题: Re: [mybatis/spring-native] @MyBatisResourcesScan occurred error on windows about mapperLocationPatterns (Issue #22)
@iygnol I've fixed this issue and published SNAPSHOT version on Sonatype OSS repository.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Dataset metadata changes not reflected in zip download

Tested using docker from the latest pulls.
After changing the dataset metadata:

The dataset-metadata.json file in the zip file download still shows the default values:
"name": "World_Education_Index_by_Country_PI_Meeting", "dataset_id": "World_Education_Index_by_Country_PI_Meeting", "description": "", "url": ""}

Looks like this has been fixed.


is it safe to open a file multiple times?

i have a use case to open a file multiple times.
eg. keep two lfs_file_t opened for a file.
is it a safe operation for littlefs?

Ah. Yes, this is well defined, though the behavior may be unintuitive coming from POSIX filesystems.
The way this works right now is that every open file handle gets a "snapshot" of the file.
So if you open a file twice, say with lfs_file_t A and B, and then wrote to B, A would still contain the original contents.
If you open a file twice and write to both A and B, the last handle to be synced or closed will be what ends up on disk.

The reason for this behavior is because it derives naturally from files in littlefs being copy-on-write. But users have noted it's unintuitive and initially confusing.
There are some changes in the works to make littlefs behave a bit more like POSIX here (by broadcasting file changes to other open file handles on sync/close), but these changes will need to wait for a major release with API changes, so it will take some time before they land.

thank you for explanation. it makes sense. is it documented in some places?
does directory work is a similar way?
i vaguely remember that some traditional applications, which modify a directory (create/remove entries) while readdir'ing it, have some assumptions on what readdir contents can contain/can not contain.

thank you for explanation. it makes sense. is it documented in some places?

It's not documented very well currently. Eventually it should be. But with changes in the works it's been hard to prioritize soon-to-be-deprecated behavior when that time could be spent getting to the better behavior sooner. Some hard decisions time-management-wise here.

does directory work is a similar way?

Ah this is a good question.
It would be quite nice if directories worked this way, since it would solve the modify-while-readdir issue you mentioned. Unfortunately because of technical limitations littlefs can't really snapshot directories. Files in littlefs are copy-on-write, but directories are not***.
The modify-while-readdir issue is a really interesting one, and I've read it has caused quite a bit of headache for other filesystems.
According to POSIX:

If a file is removed from or added to the directory after the most recent call to opendir() or rewinddir(), whether a subsequent call to readdir() returns an entry for that file is unspecified.

It doesn't really seem to comment on if modifying a directory is allowed to effect readdir in other ways. My understanding is the expectation is that readdir should at minimum return all files in the directory at the time of opendir. littlefs should be doing this, though it may not have the best test coverage.
At the very least we do have tests over some common modify-while-readdir patterns: test_dirs_recursive_remove

***:
Ok, so technically you could snapshot a directory by marking its mdirs as "frozen", and forcing any modifications to the mdir to copy first. This may be interesting in the future for full filesystem-level snapshots, which is a feature in other copy-on-write filesystems, but not currently possible in littlefs. But this would be too heavy-handed/expensive for readdir operations.

thank you for explanation. it makes sense. is it documented in some places?

It's not documented very well currently. Eventually it should be. But with changes in the works it's been hard to prioritize soon-to-be-deprecated behavior when that time could be spent getting to the better behavior sooner. Some hard decisions time-management-wise here.

does directory work is a similar way?

Ah this is a good question.
It would be quite nice if directories worked this way, since it would solve the modify-while-readdir issue you mentioned. Unfortunately because of technical limitations littlefs can't really snapshot directories. Files in littlefs are copy-on-write, but directories are not***.
The modify-while-readdir issue is a really interesting one, and I've read it has caused quite a bit of headache for other filesystems.
According to POSIX:

If a file is removed from or added to the directory after the most recent call to opendir() or rewinddir(), whether a subsequent call to readdir() returns an entry for that file is unspecified.

It doesn't really seem to comment on if modifying a directory is allowed to effect readdir in other ways. My understanding is the expectation is that readdir should at minimum return all files in the directory at the time of opendir. littlefs should be doing this, though it may not have the best test coverage.
At the very least we do have tests over some common modify-while-readdir patterns: test_dirs_recursive_remove
***:
Ok, so technically you could snapshot a directory by marking its mdirs as "frozen", and forcing any modifications to the mdir to copy first. This may be interesting in the future for full filesystem-level snapshots, which is a feature in other copy-on-write filesystems, but not currently possible in littlefs. But this would be too heavy-handed/expensive for readdir operations.

when i was working on some filesystems decades ago, the access pattern of cvs caused a lot of trouble
wrt readdir. i don't remember details though.
hopefully there are less applications assuming UFS-like behaviors these days.
(snapshoting a directory might make the situation worse for those apps.)


docker-compose build  fails for me

$ docker-compose build
...
<s> [webpack.Progress] 94% after asset optimization
<s> [webpack.Progress] 94% after seal
<s> [webpack.Progress] 95% emitting
<s> [webpack.Progress] 95% emitting HtmlWebpackPlugin
<s> [webpack.Progress] 95% emitting CopyPlugin
<s> [webpack.Progress] 98% after emitting
<s> [webpack.Progress] 98% after emitting CopyPlugin
 ERROR  Failed to compile with 6 errors7:06:12 PM

These dependencies were not found:

* @girder/components/src/components/DataDetails.vue in ./node_modules/vuetify-loader/lib/loader.js!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/views/Home.vue?vue&type=script&lang=js&
* @sentry/browser in ./src/main.js
* @sentry/integrations in ./src/main.js
* vue-json-pretty in ./node_modules/vuetify-loader/lib/loader.js!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/components/MetaEditor.vue?vue&type=script&lang=js&, ./node_modules/vuetify-loader/lib/loader.js!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/views/DandiMetaViewer.vue?vue&type=script&lang=js&
* vuex-router-sync in ./src/main.js

To install them, you can run: npm install --save @girder/components/src/components/DataDetails.vue @sentry/browser @sentry/integrations vue-json-pretty vuex-router-sync
<s> [webpack.Progress] 100%

 ERROR  Build failed with errors.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: Service 'client' failed to build: The command '/bin/sh -c yarn run build --mode docker' returned a non-zero code: 1
docker-compose build  8.49s user 1.96s system 3% cpu 5:01.85 total

what could I do to resolve it? (sorry -- have no clue in JS/npm/yarn/...)

Fixed by #112.


Adaptive card interaction

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/cards-reference.md
90
43
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Microscopic issue in a comment causes tons of warnings when using document builder

This is in the comments only, hence does not affect code at all.  There is a missing right paren in the comments for source/raylib/rlgl.d - this missing paren causes dozens of warnings whenever one uses the document generator.  E.g.
dub build --build=docs
The solution?  Line 78 of source/raylib/rlgl.d needs a trailing closing paren.
#define RL_DEFAULT_SHADER_UNIFORM_NAME_NORMAL      "matNormal"         // normal matrix (transpose(inverse(matModelView)))

Please file in raylib upstream as well (if not already fixed) -- rlgl is mechanically translated using dstep.

Oh - okay.  Didn't know that, I'll do so now.   I need to do some kind of mechanical translation of the raylib comments to ddoc comments.
See also #13

Please let me know if that works -- https://github.com/schveiguy/raylib-d/commit/9906279494f1f83b2c4c9550779d46962af7c342
I may not do a release unless you really need it, as this affects nothing normally used.

I'm actually only interested in my own documentation, and was mildly surprised that the doc builder builds library stuff as well.
Having said that, I might some spare cycles helping out with DDOC at some point in the near future.

OK, I'll do a release so it doesn't affect your project, sorry.

I edited my own version by hand.  Not to worry about the release, it's not an issue at all.  I just thought you'd like to know since it looks horrible when generating docs, and has such a simple resolution.

Well, I already did it ;) Not a huge deal.

Having said that, I might some spare cycles helping out with DDOC at some point in the near future.

That would be really great!


problem with prediction consistency

Hi, I notice the input of teacher and student model are different (unsup_strong for student and unsup_weak for teacher). And there are some crop and flip operation in data augmentation.
So will there be some problem with the prediction consistency when directly computing the loss with teacher's ans student's predictions (logits, deltas and quality) ? Or is there any extra transform operations to the predictions in this project?

Please notice that the StrongAug is applied on the results of WeakAug, and the StrongAug it self contains no geometric transformation. In that case, the student and teacher model should be consistent

okay，thank you！


JDBC

Any plan for JDBC support?
noria-mysql said;
Jul 28 03:58:09.153 ERRO query can't be parsed: "set autocommit=1, sql_mode = concat(@@sql_mode,',STRICT_TRANS_TABLES')"
Jul 28 03:58:09.158 ERRO query can't be parsed: "SHOW VARIABLES WHERE Variable_name in ('max_allowed_packet','system_time_zone','time_zone','auto_increment_increment')"

Java said;
java.lang.NullPointerException
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.requestSessionDataWithShow(AbstractConnectProtocol.java:642)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.readPipelineAdditionalData(AbstractConnectProtocol.java:623)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.connect(AbstractConnectProtocol.java:476)
	at org.mariadb.jdbc.internal.protocol.AbstractConnectProtocol.connectWithoutProxy(AbstractConnectProtocol.java:1084)
	at org.mariadb.jdbc.internal.util.Utils.retrieveProxy(Utils.java:493)
	at org.mariadb.jdbc.MariaDbConnection.newConnection(MariaDbConnection.java:156)
	at org.mariadb.jdbc.Driver.connect(Driver.java:90)
	at java.sql/java.sql.DriverManager.getConnection(Unknown Source)
	at java.sql/java.sql.DriverManager.getConnection(Unknown Source)
...

We don't currently have any plans (or, unfortunately, the cycles) to develop and comprehensively test JDBC interaction.
That said, the error you're seeing is likely a result of an unexpected empty result from SHOW VARIABLES. noria-mysql returns an empty result for unrecognized queries, which surprisingly often works just fine. Here, however, the client expects to get the variables (I'm guessing). You could possibly fix this by adding code that returns hard-coded results for the variables (similar to this). If you try this out and it works, please send a PR!


[Compose] support for running with container's network namespace

  app:
     ....
  tcpdump:
    image: nicolaka/netshoot:latest
    restart: always
    network_mode: "container:app"
    command: [ "tcpdump" ]

Running the above compose app throws the following error
FATA[0000] unsupported network_mode: "container:app"
Container networking is very useful for running debugging sidecars (eg: tcpdump or other networking tools)

Duplicate of https://github.com/containerd/nerdctl/issues/421 (Pull requests are welcome)


Reimplement grape-swagger on top of swagger-rb.

I would like to start a discussion about this gem's structure. At this stage this gem consist of a single file   with a single method add_swagger_documentation. This methods creates a documentation class and adds all api documentation endpoints to it. At this stage all methods on api declaration, endpoints,  parameters, models are in one single file now.
What is suggest is to divide logic a bit more into classes or modules with structure corresponding to the swagger spec. This has the advantage that you can separate logic into places where it belongs.
It improves readability and testability of your code. When editing the parameter module you are sure you are not accidentally editing api information. Since you have a little bit more methods defined, you might also be able to add an unit test for your method instead of only integration tests.
Last point is that variables are on their local scope, currently you can declare a variable somewhere on top and use it on line nr 200.
What do you all think of this?

+1 for swagger 2.0 support

+1

@maxlinc I would love to put in a helping hand but it isn't clear to me where you are in the project. Is the library 100% Swagger 2.0 complaint? If so, does that mean the next step is to integrate it into grape-swagger? cc: @dblock

Whether swagger-rb is 2.0 compliant or not is something that can be resolved on its own. Gutting the implementation of grape-swagger would be a huge step forward, and having all tests here pass, and then we can deal with making swagger-rb whatever we want it to be.

Great!

Any roadmap, how I can contribute? What's done here and undone?

Nothing has been done! I say rip out the guts of this gem and keep the tests, make a PR.

+1

think this issue can be closed …
something has changed over the time
feel always welcome to improve it


Upgrade to Go 1.18

Closes https://github.com/celestiaorg/rsmt2d/issues/105
Draft PR until I verify that it's safe to consume a Go 1.18 module from a 1.17 app See https://github.com/celestiaorg/rsmt2d/issues/105#issuecomment-1183957521

Sorry but I don't have merge permissions @liamsi


Make Twipsys CSS only with JavaScript Fallback

In browser which supports CSS3 show twipsys without the help of javascript. This could be done this way: http://t3n.de/news/css3-individuelle-tooltips-ohne-356353/ maybe with animations added from animate.css (http://daneden.me/animate/) also without any help of javascript.
In Browsers which do not support that fall back to javascript or use a javascript version of twipsy explicitly

Falling back from Javascript to just CSS is one thing, but falling back to just CSS3 right now isn't an option. Too many browser support issues.


[Bug] Bug title Class Message can not be serialized by json

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
ubuntu
RocketMQ version
5.1.5
JDK Version
11
Describe the Bug
The Message class lacks some getter and setter methods, which causes an error during the JSON serialization of Message and its subclasses. This is because the JSON serialization framework relies on getter and setter methods to infer properties.
Steps to Reproduce
add getter and setter method
What Did You Expect to See?
class  Message can be serialized
What Did You See Instead?
class  Message can not be serialized
Additional Context
The Message class lacks some getter and setter methods, which causes an error during the JSON serialization of Message and its subclasses. This is because the JSON serialization framework relies on getter and setter methods to infer properties.

pr  #7439


Updating DNNRegressor module directory

The model is now located at tf.contrib.learn.DNNRegressor and the code will not run without this change.
Documentation of the module is available here: https://www.tensorflow.org/api_docs/python/tf/contrib/learn/DNNRegressor

Can one of the admins verify this patch?


Minor edits to reflect actual values

Minor edits to correct some inaccuracies on the page.
Android Studio typically generates an 'app-debug.apk' filename, removed the space Other updated properties are taken from the current preview releases of Windows Subsystem for Android

Learn Build status updates of commit e34b12a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

hub/android/wsa/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Thank you @philnach! Merging. :)

Learn Build status updates of commit c37245d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

hub/android/wsa/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Is it possible to add Google analytics to facilitate viewing of page usage

Can't you just add your GA script to the <head> yourself?

Thanks for the reply, I'm a rookie, I've only reached the level of application deployment, I don't know how to make changes on that page, let me try it, forget about it


beyla is unable to resolve dns of internal kubernetes service

I deployed Beyla using the below values.yaml file. in Beyla logs it shows 2024/05/30 14:25:34 failed to upload metrics: Post "http://monitoring-alloy:4318/v1/metrics": dial tcp: lookup monitoring-alloy on <IP_ADDRESS>:53: no such host
service:
  enabled: true

env:
  BEYLA_KUBE_CLUSTER_NAME: test

## More configuration options available at https://grafana.com/docs/beyla/latest/configure/options/
config:
  create: true
  name: ""
  data:
    log_level: info
    print_traces: false

    network:
      enable: true
      allowed_attributes:
        - src.port
        - dst.port
        - k8s.src.name
        - k8s.dst.name
        - k8s.src.namespace
        - k8s.dst.namespace
        - k8s.src.type
        - k8s.dst.type
        - k8s.src.node.name
        - k8s.dst.node.name
        - k8s.cluster.name

    routes:
      patterns: []
        # - /user/{id}
        # - /user/{id}/basket/{product}
      ignored_patterns:
        - /auth/health
        - /auth/live
        - /auth/ready
        - /auth/metrics
        - /metrics
        - /health
        - /live
        - /readyz
        - /minio/v2/metrics/*
      ignore_mode: all
      # unmatched: heuristic

    otel_traces_export:
      endpoint: "http://monitoring-alloy:4318"
      protocol: http/protobuf
      insecure_skip_verify: false
      sampler:
        name: "parentbased_always_on"
        # arg: "0.1"

    otel_metrics_export:
      endpoint: "http://monitoring-alloy:4318"
      protocol: http/protobuf
      insecure_skip_verify: false
      interval: 5s
      report_target: true
      report_peer: true
      features: ["application", "network", "application_span", "application_service_graph"]

    attributes:
      select:
        beyla_network_flow_bytes:
          include: ["*"]
          exclude:
            - dst.cidr
            - src.cidr
            - k8s.cluster.name
            - k8s.dst.owner.name
            - k8s.src.owner.name
      kubernetes:
        enable: true
      instance_id:
        dns: false

    ebpf:
      track_request_headers: false
      http_request_timeout: 0s

    discovery:
      skip_go_specific_tracers: false
      services:
        - open_ports: 80,443,3000,4000,5000,6379,8070,8080,8443,9000,9200
          namespace: test

    filter:
      application: {}
      network: {}

    internal_metrics:
      prometheus:
        port: 6060
        path: /internal/metrics

    prometheus_export:
      port: 9090
      path: /metrics

preset: application

serviceMonitor:
  enabled: false

but the DNS resolution for k8s svc endpoints is just fine. other services have no issue in resolving only Beyla is not able to

Hi @kirankumar-grootan, it looks like the DNS that beyla is connecting too is an external DNS, e.g. <IP_ADDRESS> looks like Google's DNS and it makes sense that monitoring-alloy won't be resolved.
From k8s standpoint, Beyla runs with the setting of hostNetwork:true, in which case the DNS will need something like this:
    spec:
      serviceAccount: beyla
      hostPID: true           # <-- Important. Required in Daemonset mode so Beyla can discover all monitored processes
      hostNetwork: true
      dnsPolicy: ClusterFirstWithHostNet # <-- Important for DNS to work.
      containers:
      ...

thanks @grcevski  for looking into this. but chart doesnt adding dnsPolicy. I need to patch it manually.

Yes please, it would be awesome if you can make a PR for this! Thanks @kirankumar-grootan!

Hi @grcevski I don't have access to push the code to a new branch and which target branch should I branch out from?

https://github.com/grafana/beyla/pull/898

https://github.com/grafana/beyla/pull/898 merged. Thanks for accepting the PR for this fix.


Support validating and requiring signed binaries

The APM should probably support uploading signed binaries and validating them on the import side.

This should apply to both the source binary and any upgrades.


Roadmap Ideas

What do you think about:

pause/resume downloads
possibility to download files using an ios 7 background task? helpful for very large files when you don't want to have the app open all the time

possibility to download files using an ios 7 background task? helpful for very large files when you don't want to have the app open all the time

If you are still interested, I am currently developing TCBlobDownloadSwift which is using NSURLSession for iOS 7+

Hey @thibaultCha  feel free to PR here once finished the swift version!
https://github.com/matteocrippa/awesome-swift

@matteocrippa Thanks! Will do!

Closing this since it is now implemented in TCBlobDownloadSwift, thanks for the suggestions which made me start the new project @albertschulz!


28 june pr fixes

fixes for past few PRs

replacing with https://github.com/Snowfork/polkadot-ethereum/pull/443


combine package information

I'm thinking it may be appropriate to also combine information about installed packages into a single data structure since it's the really the same type of information anway:
create a structure called "packages" and fill it as follows:
packages{
    @system{}       # packages in the system set
    @world{}          # packages in world set
    custom-sets     # packages that are in a custom made set
    additional{}       # packages not found in any set (deps?)
}

let me know if this makes sense... and I need to know from palica if this is a structure you can make sense of using ES

This could eliminate the call to eqeury potentially also, which would significantly shorten the time it takes to generate the report. I know speed is not a high priority but it is a bonus side effect.

I didn't notice the existing equery call when I was working on the get_version_info sub that finds installed versions of software. Given that it's retrieving the entire list of packages installed, that code could definitely be consolidated.
What would we do instead of the equery --list call to get the package list? Crawl through the ebuild dirs?

As I look over this and the output presently reported from the tool, I kind of wonder if we're overdoing it just a bit here.
Right now, it seems that we're reporting on both the packages in general as well as the packages marked as world (with no de-duplication presently), and it is proposed that we further break it down into other categories (potentially with de-duplication in this case, I assume). My question is simply "why"?
If the overall idea of the project is a statistical report, I'm not certain I see the value of such at present. While I could very easily be overlooking something, it seems that if we merely want this data for a popularity contest, a single canonical list ought to be sufficient. We could even determine version information of select packages from this list as easily as we could from the file system. The only use of a more complex system that comes to mind is perhaps assuming that anything not in world was not installed "purposefully", but that isn't a very safe assumption for a number of reasons, and I don't think it's a good idea to second-guess user intent based off of it.
My idea, assuming the above is true, is to get a list of installed packages, and then integrate them into the "get specific program versions" work, and not worry overmuch about overall categorisation.
Thoughts?

I agree here with @ShadowM00n. I think for the statistics of this tool it is good to get the installed packages and probably the versions so the testing of the most used packages/versions would take place for example before a major branch (1.0-prime => 1.2-prime) switch or something along these lines.
It would be probably good to get the packages in @custom-sets (doesn't have to be separate category, but can). Going to think about it little bit more.

I'll leave this issue up pending further thoughts for a while. My thinking was that packages that are in a set have unique importance to the user. For instance the @system set which if modified, would be a deviation from the standard funtoo tool chain correct? Also there seemed to be some value in knowing packages that commonly are put in a custom set. It has bugged me that we are double reporting packages by not comparing the 3 data structures we have already. It is redundant to have a section that reports gcc versions but also have gcc and version info reported in the list of all installed packages. This was the root of my thinking. However, the purpose is to create a data structure that is easily usable in ES.. that is the first and highest priority. Anything else is just entertainment for bored programmers..lol

This is probably best decided by people using Funtoo as a "daily driver" and know what would and wouldn't be valuable in the report. I'm happy to help implement whatever you gents decide.

@haxmeister I asked around in IRC and found something interesting: the @system set is derived from a handful of files, and it's not strictly meant to be user-modifiable -- it's a toolset for the developers more than anything else. Anyone modifying that would need to create their own special profile and know what they're doing. Something to think about in light of all this.
According to one, you can find most or all of the packages by running "find /var/git/meta-repo/kits/*/profiles -name packages".

Output from ShadoM00n's code showing a data structure for packages that does not use arrays. The structure contains slot number as a key and version number as a value.
{
'x11-libs/gksu' => {
                              0 => '2.0.2-r2'
                           },
'x11-libs/gtk+' => {
                             2 => '2.24.31',
                             3 => '3.20.10'
                           }
}

in ES table this would look like:
'x11-libs/gksu'.0.'2.0.2-r2'
'x11-libs/gtk+'.2.'2.24.31'
'x11-libs/gtk+'.3.'3.20.10'

This eliminates the array of package names that is evidently hard to search in ES perl Palica. However after some discussion I'm wondering if it might be easier to search through in ES if the slot number was last since the natural inclination is to search for package-version not package-slot-version.
{
'x11-libs/gksu' => {
                              '2.0.2-r2' =>0
                           },
'x11-libs/gtk+' => {
                             '2.24.31' => 2,
                             '3.20.10' => 3
                           }
}

Looking at Palica for input on this one. ShadowM00n can easily tweak the code to produce either structure as the difficult part is really done.

I like the slot at the end better. Can we just test it, I don't know how ES will behave with this one.

here is some reference from ES about Arrays, maybe a good read for you guys?
https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html

@palica That documentation suggests to me that using a different datatype on the ES side would fix the issue, but I'm not entirely sure.
That said, I have the slots at the end now and can make a pull request whenever.
However, I have one last concern with this for the moment: do we still want/need get_version_info()? I re-wrote it while I was doing all of this to make use of an array containing all the ebuilds so it wouldn't have to gather it from the filesystem again, and it's still using its old format. If all that's fine, I'm content to leave it as-is, and if it is now rendered effectively obsolete by the new formatting, @tejr has mentioned he's fine seeing it removed. Just need to come to a decision one way or another.

Yes, I have the same feeling array => nested
https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html
If the new all_packages_installed_with_versions() function works as expected with ES, then I could just search for the core/system packages and it would also be more dynamic (I can change the packages without need to change the get_version_info code) and independent of the code. If that makes sense.
I would say, lets abandon the get_version_info and try with the new code, if it works good, if not ... bad, I suppose.

Made a pull request. Let's see what happens.

we will stall this work, as we want to make a new release that does not contain this new structure for pkgs but the old structure from previous release

I think we can now go back and add this change to the develop branch. @ShadowM00n if you want to take the reigns on this one since you have most recently thought it through. Let's get that package data structure unified again :dancing_women:

please add this change to a separate feature branch @ShadowM00n

Pushed to alternative-getall branch; review at your leisure.

merged = closing


Upgrade Go to 1.17

Follow-up on Client go version upgrade.
Changes

:broom: Upgrade Go to 1.17

/cc @maximilien @rhuss @vyasgun

Any chance to rebase @dsimansk ?

@maximilien done, sorry for the delay.

@maximilien or @vyasgun if you could take a look please. I've put auto-update PR on hold to avoid conflicts this time. :)

/lgtm


404 -  Update the route pattern for compendia file downloads

Issue Number
Closes #404
Purpose/Implementation Notes
I've created the dynamic route compendia/[type]/download/[organism_name]  to handles user-selected compendia computed file downloads and adjusted the codebase accordingly.
Changes include:

Added the route: compendia/[type]/download/[organism_name], with the user-selected compendia ID as a query
Updated the following methods in useCompendia:

goToDownloadPage (formerly navigateToFileDownload)
downloadCompendia

Updated the compendia tracking methods in gtag

Additional update:

Added CompendiaContext and for useCompendiaContext (previously useCompendia)
Added a new hook useDownloadCompedium for the compedium file download
Utilized getServerSideProps for the dynamic routes ([type] and [organism_name])

Types of changes

New feature (non-breaking change which adds functionality)
Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests
N/A
Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots
N/A

I've applied the feedback and made the necessary changes. This PR is now ready for your review. Thank you, David!

I've applied your feedback and this PR is ready for another look. Thank you David!

Based on our 1:1 discussion, I've update the filteredOptions state to be a constant and updated the filtering logic with the fuzzyFilterOnKey helper. Additionally, I've removed the DropDown and adjusted the codebase accordingly.
This PR is ready for your review. Thank you David!


Prettify md/scss and update dependencies

I ran npm i && npm run format and npm run upgrade to fix linting and update a few deps.

@rtsisyk did it break po4a?
@meenbeese did you test po4a localization tool? What caused so many format changes? Is it possible to avoid replacement somehow?

did you test po4a localization tool? What caused so many format changes? Is it possible to avoid replacement somehow?

No, how can I test that? I just did the prettify as suggested.
I don't see why we should try to avoid the replacements.

I tried with the latest version from master but it still produces the same result. And I didn't set up any different config for the formatter either, just using the default one.
As this is not especially important, I can just close the PR and focus on more important issues that need to be resolved. The only formatting critical for me is this in the main.css:
@media (width <= 768) {

As zola serve refuses to compile for me when it is as such. I have to change it to:
@media (max-width: 768) {

Which I had previously did in my last merged PR but it was reverted when you ran your formatter. How can we solve this?

Please avoid merge commits and always use rebase. You may need to practice a bit to better understand it. It is required in our git workflows.
I don't have any build issues with zola related to scss. What is your zola version? Could it be that you have some conflicting global npm packages installed that influence the behavior of the formatter and scss transpiler?

Please avoid merge commits and always use rebase. You may need to practice a bit to better understand it. It is required in our git workflows.

Thanks, I will try to explore rebase a bit more.

I don't have any build issues with zola related to scss. What is your zola version?

My zola version is 0.16.1

Could it be that you have some conflicting global npm packages installed that influence the behavior of the formatter and scss transpiler?

I do have Prettier installed which may be the culprit behind the formatting changes but that doesn't explain the scss compiling error.

✗ zola --version
zola 0.17.2

Please install the latest zola version.

I can confirm that updating the zola version to 0.17.2 solved the error completely. Maybe we should document this in the README? I was planning on improving the README anyway sometime.

You can clarify there that we're using the latest zola.


Update Plotly.vue for resizing

refs #3

Sorry, this doesn't work..

Fixed in 0.2.0, see https://github.com/statnett/vue-plotly/issues/6#issuecomment-399090119


Is this maintained?

I see some open issues and last update from nov 2018. I am wondering if the repo is updated or shall we search for alternatives? Or help to maintain it?

@hugomosh @gianpaj @kdbcinco-cs @levgenRagulin -- I'm happy to say this library is still maintained. We just lost track of Github Notifications / Pull Requests
Is this something you're still interested in discussing? I'm going to close this for now, as it's over a year old, but if this is still interesting to discuss, we can reopen the ticket.
If you find a bug or have a PR, I'm working on a new release in #79


GEODE-7685: Backward compatibility tests for PR clear

Added distributed tests to make sure PartitionRegion.clear() operation
nicely handles scenarios on which there are older members on the
system; that is, members that don't have any code to handle the clear
operation for this type of region yet.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[X] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[X] Is your initial contribution a single, squashed commit?

[X] Does gradlew build run cleanly?

[X] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

last activity was some while ago, please close this PR if no longer needed

@onichols-pivotal : thanks for the heads up but no, this PR can't be closed yet.

Closing this pull request as it's been idle for too long.
@jinmeiliao @agingade @gesterzhou: I won't delete my private branch, so feel free to check it out and use it if you think is worthy. Cheers.


4.9 regression: unexpected error using in operator on generic object intersected with {}

Bug Report

🔎 Search Terms

in operator
generic
object

🕗 Version & Regression Information

This changed between versions 4.8 and 4.9

⏯ Playground Link

Playground link with relevant code
💻 Code

const f = <P extends object>(a: P & {}) => {
    // Unexpected error:
    // Type 'P & {}' may represent a primitive value, which is not permitted as the right operand of the 'in' operator.ts(2638)
    "foo" in a;
};

🙁 Actual behavior
See code comment above.
🙂 Expected behavior
See code comment above.

Likely a duplicate of #51501

I can confirm that my PR fixes this issue. I've pushed out this repro case as an additional test case: https://github.com/microsoft/TypeScript/pull/51502/commits/42ac98e7c4e72280213ad10c74bd4f4f80d9c335


i dont have a insider updates

i checked all reinstalled this and restarted pc
windows update downloads only default updates
screenshots is google translated because my windows using russian language

Edited:
im enabled diagnostics and feedback to full

If your machine is not compatible with Windows 11, offlineinsiderenroll can't help

my pc is compactible with windows 11

Hello, i don't think cmd is broken. I just ran the cmd and works fine for me.

Use VPN in Russia

@Ramazik i need vpn to use windows update with insider? Microsoft blocked all from windows in Russia

Ok i try if problem not solves im say there and sorry for bad english

how can fix this ?