Pagination stops working, when using custom setFilteringFunc()

I try to create like filter on 2 fields:
        $grid = new Grid(
            (new GridConfig)
                ->setName('file_grid')
                ->setPageSize(10)
                ->setTemplate('nayjest.grids.default')
                ->setDataProvider(new EloquentDataProvider($query))
                ->setColumns([
                    (new FieldConfig)
                        ->setName('name')
                        ->setLabel(Lang::get('models/file.name'))
                        ->setSortable(true)
                        ->addFilter(
                            (new FilterConfig)
                                ->setName('name')
                                ->setFilteringFunc(function ($val, EloquentDataProvider $dp) {
                                    $builder = $dp->getBuilder();
                                    $builder->where('name', 'LIKE', '%'.$val.'%')
                                        ->orWhere('description', 'LIKE', '%'.$val.'%');
                                })
                        )
                ])
                ->setComponents([
                    (new THead)
                        ->setComponents([
                            (new ColumnHeadersRow),
                            (new FiltersRow)
                        ])
                    ,
                    (new TFoot)
                        ->setComponents([
                            (new OneCellRow)
                                ->setComponents([
                                    new Pager,
                                    (new HtmlTag)
                                        ->setAttributes(['class' => 'pull-right'])
                                        ->addComponent(new ShowingRecords)
                                    ,
                                ]),
                        ])
                ])
        );

First result page displays valid results, second page lose my search string and return results without filter.
Any ideas?

Hi!
Starnge, in demo (without setFilteringFunc()) it works fine:
http://grids-demo.herokuapp.com/demo/example4?example_grid4[filters][email-like]=.com&example_grid4[page]=2
Code also looks fine and I use this functionality same way too.

Is GET-parameter file_grid[name] preserved when you navigating to next page? If it's not preserved, problem is somewhere in grids code.

Check your SQL query modified by grid filters: (var_dump(\DB::getQueryLog()) & die() after $grid->render() or use barryvdh/laravel-debugbar package to always see DB queries in debug panel). If you use some kind of complex queries (grouping or sub-queries), there is possibility that "where" conditions will be added not to proper place.

Check that you use proper pagination component: \Nayjest\Grids\Components\Laravel5\Pager for L5 and \Nayjest\Grids\Components\Pager for L4

First result page is fine, page number and item count looks also fine.
Pagination links on first result page contain search string as GET parameter.
http://host.tld/categories?file_grid[filters][name-=]=as&file_grid[page]=2
When I navigate to the next page, the filter field does not contain my search string anymore.
I get unfiltered results from second page, page count is equal to unfiltered page count.
But the next-page links still contains my search string:
http://host.tld/categories/?file_grid[filters]=]=as&file_grid[page]=3
As soon as i change the filter from:
(new FilterConfig)
   ->setName('name')
   ->setFilteringFunc(function ($val, EloquentDataProvider $dp) {
    $builder = $dp->getBuilder();
    $builder->where('name', 'LIKE', '%'.$val.'%')
      ->orWhere('description', 'LIKE', '%'.$val.'%');
   })

to
(new FilterConfig)
   ->setName('login')
   ->setOperator(FilterConfig::OPERATOR_LIKE)

everything works fine.
DB Queries
Query on the first page looks fine:
select * from `files` where `category_id` in ('11', '166') and `name` LIKE '%as%' or `description` LIKE '%as%' order by `updated_at` desc limit 10 offset 0

Query on the second page does not contain my search string anymore:
select * from `files` where `category_id` in ('11', '166') order by `updated_at` desc limit 10 offset 10

Pager class use Nayjest\Grids\Components\Laravel5\Pager; should also be fine for Laravel 5.1
URLs
Urls seems to be broken?
First page (on Filter Post):
http://host.tld/categories?file_grid%5Bfilters%5D%5Bname-%3D%5D=as
Page 2:
http://host.tld/categories?file_grid[filters][name-=]=as&file_grid[page]=2
Page 1 link on Page 2:
http://host.tld/categories?file_grid[filters]=]=as&file_grid[page]=1

Looks like problem is somewhere in filter name. Operator name used in name of get-parameter, so try to specify both filteringFunc and operator (filteringFunc always has higher priority when modifying query).
(new FilterConfig)
   ->setName('name')
   ->setOperator(FilterConfig::OPERATOR_LIKE)
   ->setFilteringFunc(function ($val, EloquentDataProvider $dp) {
    $builder = $dp->getBuilder();
    $builder->where('name', 'LIKE', '%'.$val.'%')
      ->orWhere('description', 'LIKE', '%'.$val.'%');
   })

Of course it's a dirty hack, but I'm not sure that I can solve this problem soon (currently I even have no time to reproduce it), so better to try something like that.
Please give me know if specifying both  filteringFunc and operator helped.

@Nayjest thx for your suggestion, works like a charm for this filter!
seems to be generic problem, now i have same problem when I add other filters, but this trick does not work anymore:
->addFilter(
    (new SelectFilterConfig)
        ->setName('type')
        ->setOperator(FilterConfig::OPERATOR_EQ)
        ->setSubmittedOnChange(true)
        ->setOptions(array_combine(FileType::keys(), FileType::values())))

As soon I add this filter, all filters loosing their values when I navigating to next page.

Hi!
Currently I still have no time to researh deeper. But I have another suggestion: try to use custom filter names ('type_filter') that's not equeal to column names (It's not used when you use custom filtering function, but looks like bug is related to filter name) + custom filtering function.
Also, please, check this bug in different browsers. I had problems with multidimensional arrays in HTTP GET & specific GET parameter names in Google Chrome before.

Hi! Had similar issue and after removing all filters except 'LIKE' pagination works.
Again after adding OPERATOR_EQ or OPERATOR_GTE / OPERATOR_LSE
pagination stops working. Looks like problem with pager href values being not urlencoded
as grid expecting. Checked in Chrome/Firefox.

i've  the same problem using operator OPERATOR_EQ
this works
pa[park_id-%3D]=34

on the next page the filter is not encoded and this will not work
pa[park_id-=]=34&pa[page]=2

Looks like problem is in special characters in GET parameter names? (GET parameter name = $filter_name . $operator). But in this case it's strange -- why it doesn't reproduces in demo app: http://grids-demo.herokuapp.com/demo/example4

all filters in demo are
FilterConfig::OPERATOR_LIKE

try to change one in
FilterConfig::OPERATOR_EQ

the issue is raised by all but LIKE i think

Hey,
Looks like the equal sign (=) mess up with URL parameters.
Is there any solution for that?
Thanks

Hi!

You can rename constants in FilterConfig (FilterConfig::OPERATOR_EQ = 'eq' instead of '=', etc.) & make pull request, I will accept it and community will say you many thanx.
If i'm not mistaken, setting filter name via setName() method changes URL parameter name too, check  it

Hey!
I've tried to create a pull request but failed due to StyleCI rejects :/.
I will very thankfull if you can update the file with those changes directly to the repo..
https://github.com/asaf050/Grids/commit/91af85577584d3b6b5488ba13c1d21ff62b70dd7
Please let me know
Thanks
Asaf

This constants is used inside DataProviders to build SQL, so you need to fix that in filter() methods of DataProvider classes.
StyleCI rejects isn't very important. There is too strict rules so just don't pay attention.

Hey @Nayjest
I've created a new pull request
https://github.com/Nayjest/Grids/pull/90

Thanks to @asaf050 for contribution!
Released in v0.9.8
I will appreciate any feedback regarding this issue fix becouse unfortunately I had no time to add tests.
@TUNER88, @AndreiGapejev, @wdog  please give me know if v0.9.8 works fine.

Upd: some my reports has broken after this fix, trying to locate the problem now.

Upd: custom operations functionality was broken by this fix in v0.9.8, fixed in v 0.9.10

Hi @Nayjest,
We have implemented Nayjest grid, having issue on pagination URL for it throw params in query string
?shop_forms_listing%255Bpage%255D=3
but it should be:
?shop_forms_listing%5Bpage%5D=2
let me know what is the issue with the pagination urls


feat(typescript): Force no code quality compiler options

Fixes #391

This can be merged if the build is green and if you agree with my documentation changes 👍

👍 looks good


Support previous titles at the same company (#515)

I ended up removing the calendar icon. @colinhemphill let me know if you have any thoughts on that. I just figured it looked funny for all of the previous titles.

@rachelslurs This is a great idea! I'll take a look at it more closely this weekend and might fiddle with the design of it a little.
In the meantime, my goal with this generator is to have 100% parity between the web version and the PDF. Can you potentially get the previous titles in the PDF layout?

@colinhemphill great! I will work on this in the coming few days.

@colinhemphill I had to take off a bit of the lorem ipsum to keep it to the single page, but I did it. 🙂

@rachelslurs Just got back from vacation, but looks good to me! I might toy with the design a bit after landing this, but thanks for adding a really helpful feature.


fixing the negative_samples notebook

[x] added recordcollection add operator (+)
[x] add slicing (slice indexing) for RecordCollection to return a new object of the same class
[x] fix the negative samples notebook
[ ] add tests for the new operator
[x] fix failing tests

A couple of tests are not passing apparently.

why are the changes to RecordCollection needed?

These changes allow more intuitive use of the old records list, a bit like regular lists. This slicing and adding is used in the negative samples notebook, but I also came across this use case and already had these commits in my own branch done some time before.
The idea is to be able to

do RecordCollection + RecordCollection
and make sure that RecordCollection[:n] returns a new RecordCollection instance (and not List[BaseRecord]), cause then we cannot do RecordCollection + RecordCollection[:10] (Operator + not defined for RC and List)

TODO;
You;re right I hurried too much with the PR. I will add tests to the new operator and fix the ones failing.

the failing tests are the known efficientdet metric values

Looks good to me. @FraPochetti  I think we can merge.

Looks good to me. @FraPochetti I think we can merge.

Yes! Let's merge!


Add trait MutableKeys

Remove get_pair, and rename get_pair_index to get_full. Same with the
mutable variant.

Move mutable key methods to MutableKeys -- we want this feature to be
out of the way, but opt-in. The trait has mutable key-versions of
get_full and retain

Fixes #7

cc @garro95 github code search found you as a user of mutable keys. As a head's up, ordermap is preparing some small remodeling to put mutable key methods on a trait, so that users opt in to a "nonstandard" interface.


Concatenating Two Integer Lists

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Concatenating Two Integer Lists
Problem Link: https://edabit.com/challenge/cCWMeiJCP9Ef8XMq8

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

please assign this to me

I have completed python recently please assign me.

Please assign this to me , i am willing to work on this issue.

can i do this

https://github.com/Himith/Python-Thunder/blob/newpro/concatinateTwoIntList.py
#182 done

I have better solution . Can I work on that?
Thank You


Could you provide the codes about visualization？

I am grateful for your excellent job！I am so interested in visualization. So could you provide the codes about visualization？

I am grateful for your excellent job！I am so interested in visualization. So could you provide the codes about visualization？

Hi, I'm also working on drawing， do you know how to visualize attention maps now？

Still looking for it .... Any help?

Hi, guys.
Thank you for interesting in our work. It's sorry to upload the code for ploting attention map so late, as I'm busying in other project. I just uppload it in this project.
Please refer to here
Best!

Still looking for it .... Any help?
Have you solved this problem? The provided heatmap code seems to have an issue.

Still looking for it .... Any help?
Have you solved this problem? The provided heatmap code seems to have an issue.

Hello,I meet the same problem, may I ask how you solved it


Checkpoint Binary Hosting seems too slow

Hi, I was deeply impressed by your work POINTER.
So I tried to finetune your wiki-pretrained checkpoint on my custom dataset.
But downloading from your provided link seems too slow or not working. Can I get this checkpoint from other route? Thanks in advance.

Now works well. Never mind!


Accessing the IMU data using the Python interface

I have the latest firmware for the D455 and the latest version of librealsense installed. I am using the latest version of Windows 10. I am successfully running the example3 that is provided in the wrappers/TensorFlow directory. I tried to add capturing the IMU data by enabling the gyro and accel with the following statements:
config.enable_stream(rs.stream.gyro)
config.enable_stream(rs.stream.accel)
I wanted to read the gyro and accel data with the following:
gyroVal = frames.first_or_default(rs.stream.gyro, rs.format.xyz32f)
accelVal = frames.first_or_default(rs.stream.accel, rs.format.xyz32f)
However, these statements made the Python script fail. Remove them and everything is working fine. What should I have done? Is the IMU accessible in the Python interface?  Are there an examples of using the IMU interface from Python?  It is working fine in my Windows interface.
Bob Davies

Hi @bobdavies2000   Yes, the IMU is accessible from Python.  A script in the link below for accessing and printing the gyro and accel values may be a useful reference for you.
https://github.com/IntelRealSense/librealsense/issues/3409#issuecomment-471673994

Thanks for the link!  I will give that a try...


We might want to rename this project to align more with what the broader community is doing. Looking at other projects, and think towards the future, we might want to rename this project to just charts and then layer this a directory or 2 deep. This would allow us a single place to store other charts that we may want to create in the future. Take a look at the below projects to get an idea of what I'm thinking about.
https://github.com/helm/charts
https://github.com/bitnami/charts

@cdancy Both of those examples include a number of charts - and we only have one for the time being.  I was looking more to application examples than chart libraries (but I am flexible!).
I was also thinking that this repo would also hold the 'example yaml' files generated from these Helm charts.  I don't see that as a common pattern in other repos but it seems to have been well received so far by those who have had early access.  Maybe using a release is a better mechanism for that.

hmmm ... if the templates were well received than I wonder if it makes more sense to just port the entire build process over to github to allow folks to generate those templates themselves?
Or, and within the build process in mind, once we do a release we could absolutely wrap up the templates and publish them somewhere.


Normalize some keystrokes

Changes reset from Ctrl+D (usually for exiting a CLI program) -> Ctrl+R (for "reset"). Also, makes the output after a reset a little more clear.

This PR goes with one for kaluma-cli at https://github.com/kaluma-project/kaluma-cli/pull/36

@shreeve The REPL command is compatible to the Node.js. So I want to keep the previous key.

Ctrl+D exits the node REPL, no?

$ node -v
v20.1.0

@shreeve Yes, it's exit the node in Node.js.
For the reset, Kaluma provide .reset command and it's recommended for soft reset. The reason we add CTRL+D is it's like a exit in Kaluma.
Node.js runs on top of the shell and it goes to the shell when user want to exit from Node.js. Different from Node, Kaluma does not have any shell to go back. So when user want to exit it, Kaluma have to go back to Kaluma REPL. So it's the same as reset.


Recursively import markdown files from docs/ folders

Previously, we only imported top-level markdown files, of the form docs/*.md. Nested files - docs/**/*.md - were ignored. This is somewhat surprising behaviour and leads to an inconsistent mental model of how the dev docs importing works.
This was particularly problematic for apps like Smart Answers, which make heavy use of nested documentation: https://github.com/alphagov/smart-answers/tree/9e8366b4cb989fe2567d1fb3439261ee56749f39/docs
This PR now imports markdown files recursively. It also includes some necessary design changes as a result. Note: I did consider using the Contents list component for the design changes, but there was no way of creating non-clickable 'headings' for each subdirectory of links (other than passing active: true to the element, which would break accessibility).
Trello: https://trello.com/c/lJzIkFYP/218-import-subfolders-of-docs
Performance impact
Importing more documents naturally has a performance impact. The new search.json is 9.1 MB in size, uncompressed. This is compared to 7.3 MB on production (which is 1.7 MB gzipped), so approximately a 20% increase.
The build time has increased too, from just over 3m 30s to between 4 and 5 minutes. This is an unavoidable consequence of making many more HTTP requests to the GitHub API. Locally, such requests are cached for an hour, so this has no noticeable effect on local development, but pull requests will be slower to receive an automated ✅. We should explore whether it's possible for GitHub Actions to make use of a shared cache, to have parity with the local dev experience. This is an optimisation we can look at in a future PR.
Screenshots
These screenshots are from the govuk-docker app page:
Imported documents list

Before
After

Breadcrumbs
This also shows the new application_layout after removal of api_layout:

Thanks for going over it again @ChrisBAshton, that's much simpler without the nested hash recursion ⛰. I've now had a look at the whole PR, and have noticed one more major thing that's worth fixing. I also found a couple of things that you marked as resolved, but appear to be unchanged; I've made fresh comments for those, so it's clear.
Beyond that, I'm still interested in your thoughts on a couple of follow-up suggestions:

I'm wondering if we could introduce a more useful layout for external docs, that shows the list of them for the repo

Could we move the README into the list of imported docs?

Neither are blocking this PR, but it's a relevant opportunity to discuss them. I still haven't had a chance to try this out locally, but otherwise, I think it's pretty much ready to go ⚡.

Thanks @benthorner - this should be ready for re-review now. As to your two other points:

I'm wondering if we could introduce a more useful layout for external docs, that shows the list of them for the repo

Yes, I think you suggested a page like https://docs.publishing.service.gov.uk/manual.html but for external docs? Interesting idea, which we could consider for a follow-up PR, probably after the introduction of analytics where we can measure the usefulness of 'discovery' oriented pages like the Manual page.

Could we move the README into the list of imported docs?

That's a good idea - someone actually reached out and said the View Source doesn't match up with what they're seeing, so I think the page currently looks a bit like a README page when really the README is just one part of the page. Having it as an imported link instead would make that clearer. Again, may be worth considering splitting that out after we have analytics, so that we can measure the usefulness of having it on one page vs having it separate.

I've had a quick chance to try this locally, and I'm seeing something strange for Content Store: the full path is being shown for nested docs without a title. Not a showstopper, so could be addressed in a follow-up PR.

(I've got the latest version, but it's worth someone else corroborating this too.)

I've had a quick chance to try this locally, and I'm seeing something strange for Content Store: the full path is being shown for nested docs without a title.

I was seeing that, then I ran rm -rf .cache and ran the startup script again, where it worked fine 🤔

I was seeing that, then I ran rm -rf .cache and ran the startup script again, where it worked fine

So it does. Thanks for the pointer - still good to go then 👍.


Inlines pt2

This PR removes some unused inline macro definitions.
Draft until #4196 is merged.

looks as if this PR actually contains your previous one. and I do no see what would be gained by removing a handful of defines just because they are currently not used ?

Rebase done, ready for merge unless there is an objection.


Save channel closure info and bumping event to VSS

Considering that VSS key requires version to determine the data status, a timestamp is added to the closure event.

No changes to write_data in persist_channel_closure in pr:
self.storage.write_data(key.clone(), &closure, None)?

If the third parameter, version None, then the CHANNEL_CLOSURE_PREFIX data will not be stored in VSS.
CHANNEL_CLOSURE_BUMP_PREFIX also requires the above.

Updated in https://github.com/utxostack/mutiny-node/pull/59/commits/64d89e833d5df83221fb78549e9d17815838a16c


[ART-3108] Add release:gen-assembly verb

Example invocation to build a "standard" assembly:
./doozer --group openshift-4.7 --user jupierce --assembly stream release:gen-assembly --name art123 from-releases --nightly 4.7.0-0.nightly-2021-07-15-180731 --nightly 4.7.0-0.nightly-s390x-2021-07-15-181430 --nightly 4.7.0-0.nightly-ppc64le-2021-07-15-181317
stdout:
Suggested assembly definition
=====================================================
releases:
  art123:
    basis:
      brew_event: 39987701
      reference_releases:
        ppc64le: 4.7.0-0.nightly-ppc64le-2021-07-15-181317
        s390x: 4.7.0-0.nightly-s390x-2021-07-15-181430
        x86_64: 4.7.0-0.nightly-2021-07-15-180731
    members:
      images: []
      rpms: []
    rhcos:
      machine-os-content:
        ppc64le: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2202d05bd07168b2995cbba111b3576f324e5fb818e6bc443e782bb99f72abc2
        s390x: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:44dc69c88b187007ccd12a2658af2746bc207c6021be8cab54ee23d78ec18117
        x86_64: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6f13f9164129c3cbb89bcba63459e88c178f0fb8aa1fe58106cb49e3e265a7af
    type: standard

300 lines of code that works very hard to do almost nothing during expected scenarios :)
The main business logic here is to:

Estimate a basis brew event for a new assembly based on the nightlies specified
Carefully verify that the basis brew event reflects the content of those nightlies
If it does, a barebones assembly definition will be output.
If it does not, then is overrides will be included in the definition to ensure the assembly definition perfectly reflects the nightly contents

Codecov Report

Merging #476 (0cd1ffe) into master (4f35b98) will increase coverage by 31.47%.
The diff coverage is 13.91%.

@@             Coverage Diff             @@
##           master     #476       +/-   ##
===========================================
+ Coverage        0   31.47%   +31.47%
===========================================
  Files           0       41       +41
  Lines           0     9738     +9738
  Branches        0     2007     +2007
===========================================
+ Hits            0     3065     +3065
- Misses          0     6491     +6491
- Partials        0      182      +182

Impacted Files
Coverage Δ

doozerlib/cli/__main__.py
0.00% <0.00%> (ø)

doozerlib/cli/release_gen_assembly.py
0.00% <0.00%> (ø)

doozerlib/metadata.py
36.17% <40.00%> (ø)

doozerlib/util.py
55.59% <81.81%> (ø)

doozerlib/runtime.py
26.69% <100.00%> (ø)

doozerlib/assertion.py
100.00% <0.00%> (ø)

doozerlib/build_status_detector.py
92.10% <0.00%> (ø)

doozerlib/image.py
15.58% <0.00%> (ø)

doozerlib/coverity.py
11.81% <0.00%> (ø)

doozerlib/source_modifications.py
65.16% <0.00%> (ø)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f35b98...0cd1ffe. Read the comment docs.


Provide an universal, reusable dialog component

This component should be

[ ]  as universal as possible
[ ]  used as confirmation dialog
[ ]  used as modal
[ ]  allow a "fullscreen" mode
[ ] be compatible to the  API calls of Material UI
[ ] able to handle scrollable main content depending on viewport height

Checklist:

[ ] Test added / Snapshots updated
[ ] Documentation added / updated

Closed due inactivity, we can reopen any time!


doc: update news of OpenAnolis: ANCK 5.10 ublk support

OpenAnolis has said that ANCK 5.10 has supported ublk, please update the link, Thanks!

Put the entry at the top of news section, and  merge the change manually, see 9bf330554f0b6f08afd3fa085a2388c23e71f985


Pipeline for GPU target simulations

Pipeline for GPU target simulations

[x] I have read and checked the items on the review checklist.

bors r+


[DX] Add more options descriptions to the docs

To keep the PR atomic I only modified the documentation this time around ;)

Just one issue, everything other is great ;)

Why is this closed @SpacePossum ? change itself was great, just two minor questions from me ;)

@keradus sorry for getting back so late about this PR. I closed it because I didn't have time to finish this any time soon (same reason I reply after so long).
I wonder if this PR will ever make it because I feel like I might not have enough indept knowledge about the Fixer to write good documentation. I happily take on the requested changes about the files vs file and the one about the linter and do a rebase.
However; I think you have a valid point about the proposed change of me to split the documention based on commandline arguments only and the configuration file, but I don't find a way to formulate a better solution.


The random problem against split learning.

In handle_data()(location: secretflow.ml.nn.sl_model.py), the buffer size should be equal or greater than the dataset size rather batch_size * 8, because tensorflow shuffle the buffered instances.
In build_dataset_from_numeric()(location: secretflow.ml.nn.backend.tensorflow.sl_base.py), the call sequence should be shuffle() first and then batch(), or in each batch the instances are sequential.

Hi ZeroWalker10,
Thank you for reporting this issue, we will fix it in the future release. If you are interested, you can also submit a pull request to fix it.
Thank you.


added hash to bundled app's js file.

also the cleaning plugin to clean dist folder when building.

Thanks and sorry that I never merged this. Kinda forgot it!
The app is now rewritten from ground up using create react app, so this is not needed anymore.


[SMALLFIX] Update file docs/cn/Accessing-Alluxio-from-Zeppelin.md

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/939/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/940/
Test PASSed.

@jixiaozhong Please fix the conflicting files.
After you solve the merge conflicts, you can use git add/commit/push origin commands you did before to push changes to this PR. Thanks!

alluxio-bot, check this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/942/
Test PASSed.


fix channel_force_closure anchor itest flake

Another flake I observe fairly often (taken from neutrino itests):
=== RUN   TestLightningNetworkDaemon/channel_force_closure/committype=anchors
    lnd_test.go:115: Error outside of test: *errors.errorString failed to find commitment in miner mempool: wanted 2, found 1 txs in mempool: [aab923198895a4393bf2912332e44809b3c8f43f56a8528917b99ca042de2d54]
        /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:3646 (0xdf4469)
        	channelForceClosureTest: t.Fatalf("failed to find commitment in miner mempool: %v", err)
        /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:3441 (0xe47838)
        	testChannelForceClosure.func1: channelForceClosureTest(
        /home/travis/.gimme/versions/go1.14.7.linux.amd64/src/testing/testing.go:1039 (0x50b9bc)
        	tRunner: fn(t)
        /home/travis/.gimme/versions/go1.14.7.linux.amd64/src/runtime/asm_amd64.s:1373 (0x469401)
        	goexit: BYTE	$0x90	// NOP

Here again, could be a missing WaitPredicate

Does this still occur?

Does this still occur?

A newer instance:
=== RUN   TestLightningNetworkDaemon/06-of-82/neutrino/unconfirmed_channel_funding
    test_harness.go:91: Error outside of test: *errors.errorString unable to find Carol's force close tx in mempool: wanted 2, found 1 txs in mempool: [eb083d362731f2c1afe855930d1bfaa8a69688496cf2c66b347634b3b556cfbe]
        /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:7940 (0xf57b8c)
        	assertDLPExecuted: t.Fatalf("unable to find Carol's force close tx in mempool: %v",
        /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_channel_backup_test.go:1090 (0xef0b27)
        	testChanRestoreScenario: assertDLPExecuted(
        /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_channel_backup_test.go:408 (0xf78abb)
        	testChannelBackupRestore.func10: testChanRestoreScenario(h, net, &testCase, password)
        /home/travis/.gimme/versions/go1.16.3.linux.amd64/src/testing/testing.go:1193 (0x51c72f)
        	tRunner: fn(t)
        /home/travis/.gimme/versions/go1.16.3.linux.amd64/src/runtime/asm_amd64.s:1371 (0x471c01)
        	goexit: BYTE	$0x90	// NOP
=== CONT  TestLightningNetworkDaemon
    lnd_test.go:11710: Failure time: 2021-07-07 06:09:23.372
--- FAIL: TestLightningNetworkDaemon (949.37s)
    --- PASS: TestLightningNetworkDaemon/41-of-82/neutrino/switch_offline_delivery_persistence (40.45s)
    --- PASS: TestLightningNetworkDaemon/42-of-82/neutrino/switch_offline_delivery_outgoing_offline (29.12s)
    --- PASS: TestLightningNetworkDaemon/43-of-82/neutrino/revoked_uncooperative_close_retribution (17.85s)
    --- PASS: TestLightningNetworkDaemon/44-of-82/neutrino/failing_link (18.52s)
    --- PASS: TestLightningNetworkDaemon/45-of-82/neutrino/garbage_collect_link_nodes (78.41s)
    --- PASS: TestLightningNetworkDaemon/46-of-82/neutrino/abandonchannel (17.06s)
    --- PASS: TestLightningNetworkDaemon/47-of-82/neutrino/revoked_uncooperative_close_retribution_zero_value_remote_output (18.90s)
    --- PASS: TestLightningNetworkDaemon/48-of-82/neutrino/revoked_uncooperative_close_retribution_remote_hodl (20.48s)
    --- PASS: TestLightningNetworkDaemon/49-of-82/neutrino/revoked_uncooperative_close_retribution_altruist_watchtower (56.00s)
        --- PASS: TestLightningNetworkDaemon/49-of-82/neutrino/revoked_uncooperative_close_retribution_altruist_watchtower/anchors (26.33s)
        --- PASS: TestLightningNetworkDaemon/49-of-82/neutrino/revoked_uncooperative_close_retribution_altruist_watchtower/legacy (26.33s)
    --- PASS: TestLightningNetworkDaemon/50-of-82/neutrino/data_loss_protection (66.44s)
    --- PASS: TestLightningNetworkDaemon/51-of-82/neutrino/query_routes (25.91s)
    --- PASS: TestLightningNetworkDaemon/52-of-82/neutrino/route_fee_cutoff (45.28s)
    --- PASS: TestLightningNetworkDaemon/53-of-82/neutrino/send_update_disable_channel (77.72s)
    --- PASS: TestLightningNetworkDaemon/54-of-82/neutrino/streaming_channel_backup_update (45.33s)
    --- PASS: TestLightningNetworkDaemon/55-of-82/neutrino/export_channel_backup (25.77s)
    --- FAIL: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore (362.25s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_from_RPC_backup (40.17s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_from_backup_file (38.49s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_during_creation (38.43s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_during_unlock (40.16s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_from_backup_file_twice (38.47s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_unconfirmed_channel_file (38.54s)
        --- PASS: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_unconfirmed_channel_RPC (38.48s)
        --- FAIL: TestLightningNetworkDaemon/56-of-82/neutrino/channel_backup_restore/restore_from_backup_file_anchors (80.06s)

Fixed by #5509 ?

Fixed by https://github.com/lightningnetwork/lnd/pull/5509


SAP GUI for Windows: Issues with chromium-based browser control (WebView/Edge)

Collection of issues as discussed in the slack channel and PR  #4840
These errors only occur with SAPGUI 7.70 for windows PL2 and chromium based browser control. None of the occur with IE control or with previous patch level.

[x] "Unknown action: SELECT" -> #4840

[x] Back navigation doesn't work -> https://github.com/abapGit/abapGit/pull/4840#issuecomment-860035017

[ ] Patch doesn't work - add file and click 'Patch'

[x] Diff doesn't work -> Shortdump

Filename is UPPERCASE

[ ] Stage page: 'Change by (me)' doesn't work

[x] Bad performance. Every navigation step/action takes ~2 seconds

I just test the PL03 and it seems that all the problems (or at least almost) are fixed.
@christianguenter2 can you test it with the last PL03?

Thanks for the info. I just did a quick test and some issues are fixed (marked above). Few still exist.
@jrodriguez-rc Is your OCC call still open? If yes can forward that to SAP? Many thanks for your effort.

The issue reported to SAP was closed by inactivity, I was waiting for this patch to test and report feedback.

Small update: Staginging issue/filtering issue is still there in 7.70 PL5 as well.

Further delays: Looks like Sept 2022 + 3 months.

SAP Note 2901278 was updated regarding SAPEVENT and new note 3228419 was created.

Though not yet released.

More delays:

I've just updated Edge to:
Version 109.0.1518.55 (Official build) (64-bit)
and I can confirm that this issue still does exist. Will watch SAP Note 3228419 now.

Good news I guess
3331099 - SAP GUI for Windows Edge HTML control: Custom URI scheme support is now available

Note was updated

SAP GUI 800 PL03 seems to break actions in abapgit:
https://github.com/abapGit/abapGit/assets/6908247/5d9c78dc-75ff-4b14-a509-e6aa65899c9f
Probably related to notes 3331099, 3335007, 3334529

I think I see the issue: The actions are in upper case but AG expects them lower case. @WegnerDan can you test the following fix, please?
https://github.com/abapGit/abapGit/blob/main/src/ui/core/zcl_abapgit_gui_event.clas.abap#L47
    zif_abapgit_gui_event~mv_action       = to_lower( iv_action ).

Yep, this works!

Yep, "Patch" and "Staging" also works

Excellent. Thanks!

What is the solution for this issue?   i found only note 331099 here. his note is not relevant on my system. Still have SAPGUI 770  patchlevel 5
is it fixed in https://github.com/abapGit/abapGit/pull/6336 ?   and also gui patch needed?
Using the last ABAPgit Standalone and SAPGUI 770  patchlevel 5   i still have this issue

#6339 is still open and tracking the overall status. We will need to adjust AG to handle the uppercase SAPEVENT and wait for the next SAP GUI patch that fixes encoding of URL parameters including slashes.


Typo in the type of the alternate link.

The type in the alternate link should be "appliication/rss+xml" not "appliation". Obviously a typo.

Thank you for finding this bug! It is amazing that this typo never seemed to cause any trouble.


Add maxflow

I will add tests and an example code that is submittable to D - Maxflow, but I will open the PR now.  Waiting everyone for review!

@MiSawa Sorry to be late.  I think I added all the assertions you mentioned and fixed all the mistakes.  Now I'm going to add some tests.  Do you have any good idea of test graphs?

@MiSawa Sorry to be late. I think I added all the assertions you mentioned and fixed all the mistakes. Now I'm going to add some tests. Do you have any good idea of test graphs?

Thank you for being patient about all my nitpicks!

This example in Wikipedia has unique optimal solution and very simple. Maybe good as the first test.
Here's unit tests for the original library.
Here's a test case for a common mistake of Dinic algorithm's implementations, although I know the current version is fine.

About the tests:

Graphs from Wikipedia is licensed under CC-BY-SA 3.0, so we may use them as long as we mention the reference.
The license for test cases of original libraries is still yet to be determined, so I'll ask the author if I can use it.
@MiSawa Under which license can I use your test case?

(I'm not a lawyer, I'm not confident at all..   After all, do I even have to consider the licenses about those small graphs?)

* Graphs from Wikipedia is licensed under CC-BY-SA 3.0, so we may use them as long as we mention the reference.

I think CC-BY-SA 3.0 applies to the picture itself, not to the graph instance that is represented by the picture. Though not really sure, and it's safer to mention the origin anyway.

* @MiSawa Under which license can I use your test case?

NYSL! Added a comment in the gist :)

Why does clippy emit warnings in some platforms but not all??

@qryxip Maybe we can merge this already.


[WIP] BracesFixer: Add position_after_return_type_hint option

Add option to determine whether the opening brace following a return type hint should be placed on "next" or "same" line.
See text in latter part of this comment for what this implements: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2684#issuecomment-297846431

Travis is sad

Travis is sad

hehe, my fault on not flagging the 7.0 tests – one sec

please rebase :)
Could you add a view more test cases for each configuration option with code containing "messy" comments?
I would like to see how the fixer would behave, something like;
<?php
        function foo(
            $bar,
            $boo
        ): void# A
# B
{# C
# D
}# E
# F

please rebase :)

Onto current master I assume? Or where? ;p

Could you add a view more test cases for each configuration option with code containing "messy" comments?

Sure! I wont get a chance until later today, but I'll add a few when I get some time!

on master indeed ;)
(btw. we should check priority with the ReturnTypeDeclarationFixer)

This PR didn't get much activity in several years, closing.


Sample notes for issuance of temp creds for S3

@satra @kabilar @yarikoptic
See README.md and scripts -- very brief proof-of-concept for async issuance of temp creds -- could package it into a CLI option for a user to bypass minting of presigned URLs and access data as fast as possible.

Is my understanding correct?

such functionality for minting temp cred would reside in dandi-archive which  has main AWS  IAM credentials
dandi-archive, through API (which endpoint?) would produce a full bundle of 4 fields and share with dandi-cli for an authorized session :

            return {
                "AccessKeyId": credentials['AccessKeyId'],
                "SecretAccessKey": credentials['SecretAccessKey'],
                "SessionToken": credentials['SessionToken'],
                "Expiration": credentials['Expiration']
            }

that AccessKeyId and SecretAccessKey would not be the same as the "main AWS IAM", and would be short lived, client would need to re-request them upon Expiration.

Would be nice to complement example with some use of those credentials for download

Is my understanding correct?

such functionality for minting temp cred would reside in dandi-archive which  has main AWS  IAM credentials
dandi-archive, through API (which endpoint?) would produce a full bundle of 4 fields and share with dandi-cli for an authorized session :

            return {
                "AccessKeyId": credentials['AccessKeyId'],
                "SecretAccessKey": credentials['SecretAccessKey'],
                "SessionToken": credentials['SessionToken'],
                "Expiration": credentials['Expiration']
            }

that AccessKeyId and SecretAccessKey would not be the same as the "main AWS IAM", and would be short lived, client would need to re-request them upon Expiration.

Would be nice to complement example with some use of those credentials for download

Yep, your understand is correct! Theoretically, you could tie the endpoint for providing the temp creds to be linked to a user's DANDI_API_KEY, etc.
The example already has "download" operations provided, as s3:GetObject is included in the IAM policy

Such approach would provide "blanket" access to the resource (well -- as wide as iam policy prescribes), so would work for LINC or any other deployment where overall access to the archive should be "gated" but would not be applicable to any aspect of current DANDI access permission schemes (public and embargoed), correct?

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

I could derive the S3 sub-directory value from the dandiset's assetSummary outputs

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

I could derive the S3 sub-directory value from the dandiset's assetSummary outputs

sorry, I am not following how assetSummary could be used here. What I meant is that actual content is spread across all the folders
❯ dandi ls -f json_pp --metadata assets -r DANDI:000029 2>/dev/null | grep 'blobs/'
        "https://dandiarchive.s3.amazonaws.com/blobs/8e5/a7b/8e5a7b66-7608-421c-8f2a-bbb2f5a2cc5a"
        "https://dandiarchive.s3.amazonaws.com/blobs/031/7cf/0317cf5a-4047-4e19-aae1-4f7b7434d2d7"
        "https://dandiarchive.s3.amazonaws.com/blobs/56f/5b8/56f5b879-e5fa-476c-9893-dab482f66b3d"
        "https://dandiarchive.s3.amazonaws.com/blobs/031/7cf/0317cf5a-4047-4e19-aae1-4f7b7434d2d7"
        "https://dandiarchive.s3.amazonaws.com/blobs/e72/88a/e7288a2c-444c-42c5-b7bb-9a58c728992b"
        "https://dandiarchive.s3.amazonaws.com/blobs/c40/57c/c4057c5e-7af5-4370-878f-ccfc971aeba4"
        "https://dandiarchive.s3.amazonaws.com/blobs/180/9f5/1809f541-1cb1-48b8-b916-9a696bab488d"
        "https://dandiarchive.s3.amazonaws.com/blobs/2db/af0/2dbaf0fd-5003-4a0a-b4c0-bc8cdbdb3826"
        "https://dandiarchive.s3.amazonaws.com/blobs/2fd/746/2fd7464f-5459-4c96-a938-27cf13f4d330"

and this is tiny one -- try for 000026 ;)

Ah good point -- I see what you are saying (I'm watching 0000026 stream the output right now 😂 ) -- in that case (to the point of your output here), we would have to loop and gather the blobs/<values-here> and then construct the IAM Policy, unless there is some form of tagging mechanism we could include to contain those sub-directories in singular place
I guess this solution would work well for zarr....non-zarr might be tricky....will have to think more...

I guess this solution would work well for zarr....non-zarr might be tricky....will have to think more...

it works well for a "single zarr". For a dandiset with lots of zarrs (and @satra aims all nwbs to become zarrs ;) ) -- you get to the same issue as with 000026. Even now 000108 has already thousands of zarrs.
Tagging -- I thought about that too but would be tricky as well since blobs are shared across dandisets. Ensuring aligned tagging would be non-trivial.


Changing ID field using isId not working for admin-bro-mongoose

It is a common pattern to replace the "_id" field of mongoose by the given "id" virtual when calling toObject or toJSON on a mongoose model instance to have a clean and concise API output. Using admin-bro with admin-bro-mongoose, I tried to change the id field accordingly using isId:
const adminBro = new AdminBro({
  resources: [
    {
      resource: User,
      options: {
        listProperties: ['name', 'email', 'id', 'role'],
        properties: {
          id: {
            isId: true, // <--- expect this to force adminBro to use this as the actual identifier
          },
        },
      },
    },
...

But it does not have an effect. I can not access any resource in show or edit mode or delete it via the action buttons as it fails finding the id field. It produces links like http://localhost:3000/admin/resources/User/records/show missing the id path param. After further investigation, it seems like the "_id" attribute is a hard coded constant and I could not find out if using PropertyOptions will successfully overwrite it or not: https://github.com/SoftwareBrothers/admin-bro-mongoose/blob/master/src/property.ts
Please someone fix this issue or tell me how I can change the ID field using mongoose, as I don't want to output the "_id" field in my json outputs.
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected behavior
When setting isId: true, I expect the field to be used as the identifier for accessing the show, edit and delete actions.

I am having this same issue

Any solution we found for this ?


Modbus mappings for S100 power meter 'history'

So for my Sungrow SG5K-D + S100 energy meter when the solar is low enough, the inverter shuts off and the modbus cannot be scraped anymore (Wifi dongle shuts off with it).
But when the inverter turns back on every morning when the sun rises the iSolarcloud app magically has all the history of the overnight power usage of the house.
So that means (most likely?) that there's possibly more modbus read registers that contain this? Or would this be some other sort of proprietary storage/replay of the overnight data?
Wondering if there's some sort of way to read this data out and 'replay' it to any of our other external integrations (mqtt/pvoutput/etc)

Worth mentioning is that the SG5K-D is a non-hybrid inverter so there's no battery, as I'd assume inverters integrated with a battery won't ever shut off? And be online 24/7 for querying?

See my (now defunct) Herculis project which scraped iSolarcloud for a downloadable csv file, before they redesigned it. Although it doesn't work anymore, it might give you some useful pointers.

Sorry for the off-topic question, but you guys seem to know what you're talking about.
I have a Sungrow SH5K-30 that I'm trying my darndest to get talking with a DTSU666 meter. My current guess is that the DTSU666's communication settings aren't configured properly - you can change parameters for the baud rate (4800 or 9600), communication stop bit and parity bits (none parity, 2 stop bits; none parity, 1 stop bit; even parity, 1 stop bit; odd parity, 1 stop bit), and communication address.
Knowing that the inverter was happily talking with a S100 just before, I wondered if I can just set the DTSU666 to be the same. Would you happen to know what that might be? 😅 Thanks a ton for your help!

I did find this https://s3-ap-southeast-2.amazonaws.com/solarbrain/uploads/attachment/file/410/0dcc24414d19835010a890679d50c468.pdf that seems to mention a few things like baud rate/etc, not sure if that helps, but good luck!

Thanks a ton for replying! I appreciate you looking into it enough to even find that manual 😃 Yeah, I had come across that one before - One of the non-Sungrow DTSU666 manuals out there kept mentioning "ModBus RTU," so earching Google for "S100 modbus" brought me to your forum 😅.
I know fairly confidently that the baud rate should be 9600, and if I knew one of the other two parameters, I might be able to just trail-and-error cycle through settings for the last parameter.
I did come across someone who took readings off a S100, and they got this:
Modbus Response (COM3)
Address: 32
Function: 3 (0x03) – Read Holding Registers
Byte Count: 4
Values: 00 00 1f b4
Register0: 0
Register1: 8116
Checksum: 50038(OK)
That "Address: 32" looked hopeful, but I'm not all that sure if that's what I'm looking for 😅.


Allow security token config

Hello,
Here is the PR that follows the conversation in https://github.com/CargoSense/ex_aws/issues/140
Thanks again for spending your time on this

Hello there! Any update on this?

Hey sorry! This looks good, merging :)

Hurg, I should have run the tests locally first. I hate that CI doesn't work on ExAws Branches. In any case, we gotta make sure that the security token isn't added to requests if it isn't actually set to anything. I take it you didn't run the tests locally?

Reverted so we can discuss.
I think the solution may actually be as simple as removing the default. Most people don't need it to default to checking the system environment for this value; anyone who does can add it to their mix config.
How does that sound?

I thought that the security_token needed to be part of the defaults in order to work, but now that I look at the code again, I think you are right and removing it from the defaults should be enough. I will test it and create another PR shortly.
And no, I didn't run the test locally (sorry :( I saw that I need to setup a dynamo DB in order to do that and I was hoping there was an automatic CI testing the PRs :S

No worries, it's my fault it got in master w/o proper testing. Updated version at: https://github.com/CargoSense/ex_aws/pull/144

Great, thank you! :-)

It's in master now and all is green, thanks again for bringing this to my attention! :)


Oauth

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@oauth#subdirectory=src/$EXT&egg=$EXT"


Transfer Percentage of Hotspot

Submitting this PR early as I believe the current version is satisfactory.
Ed: rendered view of latest revision https://github.com/ericmheilman/HIP/blob/master/0024-transfer-percentage-of-hotspot.md

Looks great to me. Merging for discussion.

Looks great to me. Merging for discussion.


CLI stuck after build successful

Description
my app is using pre-rendered mode, but when I run build, it stuck after pre-rendering html successful, in dist folder, I see all files are genereted, no error happend.

Error Message + Error Stack
No response

I've found the problem and fixed it

I've found the problem and fixed it

What was the problem?

(Re-opening as the pre-rendering process should show a warning instead of silently hanging.)

ah, my code use RelayProvider to open websocket connect, in pre-rendering process, it open too and get stuck, so I've updated my code to make sure it only run on client

Hi, it appears that this change makes that some plugins (in my case vite-plugin-pwa) doesn't execute anymore. Can
we check this @brillout ?
vite-plugin-ssr < 0.4.116

vite-plugin-ssr >= 0.4.117

Can you publish a reproduction?
On Wed 26. Apr 2023 at 04:24, Sebastian Tabares Amaya <
@.***> wrote:

Hi, it appears that this change makes that some plugins (in my case
vite-plugin-pwa) doesn't execute anymore. Can
we check this @brillout https://github.com/brillout ?
vite-plugin-ssr < 0.4.116
[image: Screenshot from 2023-04-25 21-22-12]
https://user-images.githubusercontent.com/2219914/234449980-1d83fb79-9813-4594-9533-8e1e8c2ec47f.png
vite-plugin-ssr >= 0.4.117
[image: Screenshot from 2023-04-25 21-22-27]
https://user-images.githubusercontent.com/2219914/234449975-94adcbe8-fb91-4c63-b4fe-ce69c62ff660.png
—
Reply to this email directly, view it on GitHub
https://github.com/brillout/vite-plugin-ssr/issues/807#issuecomment-1522670665,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHVQRSZQ4L3GLM46CCX773XDCBN5ANCNFSM6AAAAAAXIGSERU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sytabaresa Try 0.4.117-draft.42785 and if that doesn't work then I'll need a reproduction.

@sytabaresa Try 0.4.117-draft.92725 instead.

No, It's not working with that version :(
I will prepare an example project to reproduce this

All right. Here we can see that. Is a raw project created with yarn create vite-plugin-ssr but with vite-plugin-pwa installed and configured.
If you use 0.4.115 you can see that in the output log the PWA plugin was used and a sw.js file is generated in dist.
But with a recent version (including 0.4.118) the plugin isn't executed and the sw.js file is not generated.
It appears that only occurs in prerender mode (prerender: true option in ssr function ).

Fix released in 0.4.118-draft.88304.
Btw. in case you think you can convince your employer: https://github.com/sponsors/brillout.


reactiveui 7

Can you please update DynamicData.ReactiveUI so that I can use the latest DynamicData 5 and ReactiveUI 7 versions?

Rxui 7 still uses Rx 2. 25 so will not work with DD 5 as that uses Rx 3.x
However I recently refreshed 4.10 with all the code in v5 but it still targets Rx 2.25 so should work with rxui7.
When Rx 8 is released I will make it compatible with DD 5

Thanks for the fast reply! I assumed because Rxui 7 is relative new they used  the latest Rx versions. I was wrong. I think I'll just use DD 4.10 then until Rxui 8 arrives.

Cool.  Let me know if you come across any issues


Upload Readme version of admob_flutter for AndroidX

I was trying generate apk of my app and i used the version admob_flutter: "^0.1.2", but this version don't support androidx, so i upload to  admob_flutter: "^0.2.0" and thats work ! i see this alteration in issuie #17, it would be interesting alter readme ?

Hi @TeuryBazzo, I agree this should be added to the README. Really the whole package should have been bumped to 1.0.0 since its a major, breaking, change.
Would you be willing to make the PR to update the README with this info?


bug fix:merge from develop

(1 ) Fix private key length

Create a hotfix branch off of v1.3.2, and submit this PR into that branch. @shineabel


Inventory UC01.04.01 - EditService

[Link to use case] (https://github.com/CMPUT301F15T02/Xperts/wiki/Use-Case:-Inventory#inventory)

As an owner, I want to remove, edit, or add an item to my inventory that I want to share. It will have a name, quantity, quality, category, if I want to share it with others, and comments.

The action bar back button disappears when you view a service


added a beginner friendly project

After digging deeper. This is NOT a search engine. I wonder whether you checked the README.md content?


style(tslint): enable TSLint stylistic config and fix linting errors

:tada: This PR is included in version 0.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Web]TextField is unusable within a dialog on Samsung devices

Hi,
Still facing this issue on 3.3.10.  Bug presents itself exactly as described / recorded in the original post and here with steps to reproduce.
This seems to affect a wide range of Samsung devices - currently we are encountering this issue on four different Samsung models (S9, A52, Note 20 and A12) - all of them running the PWA on Android Chrome (not Samsung browser) with canvaskit. The bug not only makes the keyboard entry impossible but in some cases crashes the app (keyboard becomes non-reactive).
Is there a fix for this in the beta or master channel that we can try?
Originally posted by @GaryQian in https://github.com/flutter/flutter/issues/107786#issuecomment-1267310033
](https://github.com/flutter/flutter/issues/107786#issue-1306883913)

Is there a fix for this in the beta or master channel that we can try?

@Boma123
As mentioned in last 2 comments of original issue, the reported issue seem to have been fixed on latest master, so I suggest you to switch to it and try the same case again to see if you still get the same behavior or expected one. If it indeed fixed on master, then the fix will most likely be rolled in next release of stable.
flutter channel master
flutter upgrade
I'll close this issue for now, as it seems to have been fixed and available on master. If you still see the same behavior on latest master too, please write in comments and I'll reopen it.


Fix copy to match copywriting guidelines

I've noticed a few areas of our copy (in our templates) that do not meet our copywriting guidelines
Specifically:

Refer users to the labels on UI elements, not the type of element (such as menu or button).
Use sentence-style caps
Skip periods and unnecessary punctuation

@minho42 would this be something that you'd be interested in taking a look at?

Closing as duplicate.


5.0 broken when using demand import

Version
5.0.0
Steps to reproduce
import echarts from 'echarts/lib/echarts'
import 'echarts/lib/component/dataset'
import 'echarts/lib/chart/line'
import 'echarts/lib/component/axis'
import 'echarts/lib/component/title'

const ins = echarts.init(document.getElementById('chart'))
ins.setOption({
  title: {
    text: 123
  },
  yAxis: [{}],
  xAxis: [{type: 'category'}],
  dataset: {
    dimensions: ['date', 'pv'],
    source: [
      { date: '1', pv: 123 }
    ]
  },
  series: [{
    type: 'line'
  }]
})

What is expected?
work
What is actually happening?
broken

reproduce demo:
https://codesandbox.io/s/objective-architecture-p36kq?file=/src/index.js

After some test. Seems the demo works after importing bar chart
import "echarts/lib/chart/bar";

Going to find out why.

After some test. Seems the demo works after importing bar chart
import "echarts/lib/chart/bar";

Going to find out why.

worked for me
import 'echarts/lib/coord/cartesian/Grid';
import 'echarts/lib/coord/cartesian/Axis2D';


Feature request : Full backup of the app

Hi,
I will change my phone soon and I would like to backup my apps to restore them on my new phone.
I checked the backup feature implemented in #505 and #513, but I have two issues :

I can't find a way to get the JSON generated by each backup to restore it via the paste option
There is the warning about the Android 11 storage limitations that seems to prevent what I try to do anyway. Why is it that way ?

(btw this is a very nice app, thx a lot for this <3)

Could you provide the JSON you are trying to restore?
Due to android storage limitations the backup feature is really bad right now. Therefor I made the quick solution to just paste the json

The problem is that I can't find the JSON. Where is it generated when doing a backup?

Internal storage / Documents / drinkable / backups

Let me know if you find it or not

Okay, I found it (thanks for the path)
But now I have another problem, being that the JSON is too big to fit into the clipboard. (~3MB)
I don't think it can easily be fixed (without editing the JSON) so I will have a look to the code and try to implement the restore directly from file storage...


Use Cirrus to run CI on more platforms

With this, we run the tests also on aarch64-darwin :slightly_smiling_face:

I didn't realize that Cirrus had Apple Silicon Macs now!


TEST issue

What would you like to be added:
Why is this needed:

/backport

/backport

/backport

test


Update bootstrap.sh

fix url path of snappy

Thanks @neilss
Yes, the old go get -u github.com/google/go-snappy/snappy has been removed,  usually we use godep tool(https://github.com/tools/godep) which is an useful tool to help build packages reproducibly.
So we also need update godep package dependency, u can see above godep url for more information.
Look forward to your pull request update.


any methods to start a new window when running program under cmdline?

When running a program on terminal with command line, such as google-chrome-stable, found that chrome opened on the terminal window directly. Is there any method to open the chrome(or others) on a new window, thus able to see the output of the command when running?
(Sorry for loose language :(

do you have window swallowing enabled? that'd be expected behavior then.

do you have window swallowing enabled? that'd be expected behavior then.

thanks. sorry for my careless. :smile: i will close this issue soon


Extending without a type in the extending schema

If I do:
const schema = new SimpleSchema({
  name: {
    type: String,
    min: 5,
  },
});
schema.extend({
  name: {
    max: 15
  },
});

My extended values are not applied to the schema, because I did not set a type on the extending schema.
As far as I can tell this seems to be due to this code in standardizeDefinition:
  if (def.type && !(def.type instanceof SimpleSchemaGroup)) {
    def.type = new SimpleSchemaGroup(pick(def, oneOfProps));
  }

Changing to this fixes it:
  if (!def.type || !(def.type instanceof SimpleSchemaGroup)) {
    def.type = new SimpleSchemaGroup(pick(def, oneOfProps));
  }

It seems like it makes more sense since we are going to overwrite type anyway, why check that it is already there?  Happy to do a PR for you if you agree.
Thanks for this package I have used it in many projects in and out of Meteor :)

Thanks @nicocrm, your fix is in 1.1.2 now. I would have been happy to accept a PR, but I wanted to work through it and make sure that's the appropriate fix (which it is).


Test potential FPS/lag issues caused from crosshairs/font definitions

omnibombulator discovered that having a ton of font definitions likely causes slow downs in the matchmaking dashboard and slower game load times in general. I'm curious how bad it actually is.

A good way to test potential performance gain from this would be to rename the crosshairs folder located here: https://github.com/rbjaxter/budhud/tree/master/resource/clientscheme/crosshairs

definitely are some noticeable performance gains by reducing font entry count. dev build currently has reduced font entries to demonstrate: https://github.com/rbjaxter/budhud/tree/development


Apply shellcheck

Pull Request Label:

[ ] Bug
[ ] New feature
[x] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same fix or component?
[x] Have you ran the tests locally with bats tests?

I ran shellcheck and fixed all the warnings!

Thanks for the contribution :smile:


time,runtime: too many concurrent timer firings for short, fast-resetting time.Timer

This issue is the same as #69880 but for regular a time.Timer. The difference between a regular time.Timer and a time.Ticker is that it is much harder to reproduce the problem for a time.Timer. The timer must be getting reset at just the right time, with a very low duration, so that it fires again. And this needs to happen 8 times.
The probability of this is very low, but it is possible to write code that causes this (though it's unclear if the code is useful). Slightly more concerning, however, is that there is an incredibly low chance of this just happening due to sheer luck.
I was basically only able to create a test for this that involves a timer that basically fires immediately (nanoseconds-long timer). Still, it is one additional possible problem.
Given that #69880 is fixed, fixing this isn't quite so important, but it turns out we can do so easily, to just close the door on this entirely.
It turns out that due to size class bumping from allocation headers, it costs us no extra memory to represent isSending as an atomic.Int32 instead, so we can make the maximal number of concurrent timer firings something so absurdly large (2^31-1) that it will actually never happen.

Related Issues and Documentation

time,runtime: too many concurrent timer firings for short `time.Ticker` #69880 (closed)
time,runtime: too many concurrent timer firings for short `time.Ticker` [1.22 backport] #69881 (closed)
runtime: avoid scary crash from concurrent calls to time.Timer.Reset #25686 (closed)
time,runtime: too many concurrent timer firings for short `time.Ticker` [1.23 backport] #69882

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot Please open backport to 1.23
Parts of the change that this fixes have been backported to 1.23.  We should complete the backport so that 1.23 includes all the fixes.


More core integrations

Was able to remove the package.json in the core integration by moving all the scripts to the main package.json. Fixed the scripts and tests. Also fixed travis.

Lots of updates in this, will do my best to address

Moving away from Babel
travis.yml was pulled in from Raneto Core (with Gilbert's help/guidance) before I looked at PRs. Didn't see this until it was imported

So if we strip that out, it end up being an npm lint and a dir rename. will merge if you do, up to you

Don't we need babel to transpile the core? I wasn't able to transpile until I moved that file from the other repo.
I'll pull out the travis.yml, I was just getting annoyed with it failing, lol.

Yes on babel, but with minimal edits, I was planning to find/replace yamljs with js-yaml and the one other method on the already transpiled code. That's the simple/hard way.
But, hold off on babel coming into the main package.json for the moment

side note on travis, we state in package.json that node must be 4+, but in travis, we're testing on .10 and .12. The tests would go quicker if those two were removed.

OK, I'm pleased with this PR, let me know if you want me to change anything.

Good, thank you

Also, I added a dev branch just now so let's go future PRs against that to keep master for releases
Will release tonight

Yep, I saw. Thanks!


Adjacent schedules conflict when over DST

I have two weekly recurring schedules that are adjacent. One ends on the end of the day (eg. every Tuesday from 00:00 till 24:00) and the seconds starts at the beginning of the next day(eg. every Wednesday from 00:00 till 24:00). So far, schedule#conflicts_with?(second_schedule, 6.months.from_now) works fine and returns false.
But when the testing period is over a DST switch the method returns true.
  it "does not conflict with another bordering schedule over DST" do
    # February 16th in 2010 is a Tuesday
    start_time = Time.utc(2010, 2, 16, 0, 0, 0)
    end_time   = Time.utc(2010, 2, 17, 0, 0, 0)
    schedule1 = IceCube::Schedule.new(start_time, end_time: end_time)
    schedule1.add_recurrence_rule IceCube::Rule.weekly.day(:tuesday)

    schedule2 = IceCube::Schedule.new(start_time, end_time: end_time)
    schedule1.add_recurrence_rule IceCube::Rule.weekly.day(:wednesday)

    expect(schedule1).to_not be_conflicts_with(schedule2, Time.utc(2010, 7, 23, 0, 0, 0))
  end

Am I using the start and end time wrongfully? Or is there a bug in IceCube?
I've tried to understand the behaviour in detecting conflicting occurrences but it is really hard to comprehend stuff in there - respect and props for this super helpful gem!

I'm unable to reproduce this, maybe I'm missing something?

Your example adds a rule twice to schedule1, I assume both are meant to repeat with 1 rule
Your example uses UTC time so there is no DST. I tried it with a DST time zone as well

Let us know if you can still reproduce this.


Fix error messages for require_flatten argument

Replace include_top with require_flatten in error message

This is deliberate: we want the error message to reflect the API that the user is actually using (the applications API), not that of private & hidden utility functions.


Meaning, if I originally signed up using Facebook, then connect G+, the view displays that I have G+ connected. I think it should also show Facebook.
// Check if there are additional accounts
    $scope.hasConnectedAdditionalSocialAccounts = function (provider) {
      for (var i in $scope.user.additionalProvidersData) {
        return true;
      }

      return false;
    };

@ervine13 this is using the latest master branch?

@lirantal yes.

@ervine13 so it's always showing the last social account?
What happens if you sign-up with FB, then G+, then LI? what will it show?

@lirantal I'm sorry I wan't clear. It will only show the subsequent social accounts, not the original.
Scenario 1

Sign up with Fb
Connect G+
Connect Twitter
I only see G+ and Twitter as my connected accounts

Scenario 2

Sign up with G+
Connect GH
Connect LinkedIn
I only see GH and LinkedIn as my connected accounts

Maybe the question is was this intentional that you only see the subsequent providers and not the original? What I was going to try is check the user.provider, not just user.additionalProvidersData
    // Check if there are additional accounts
    $scope.hasConnectedAdditionalSocialAccounts = function (provider) {
      for (var i in $scope.user.additionalProvidersData) {
        return true;
      }
      //check original
      if ($scope.user.provider === provider) {
        return true;
      }

      return false;
    };

@ervine13 I'm going to look into this. One quick question, in Senario 1 are you still logged into the FB provider & then in Scenario 2, you're still logged in with G+?
I'm wondering if it's just not listing the provider that you're logged in with. IIRC, the listed providers are there for removal. It might not allow you to remove the one you're logged in with; or the fact that it may be considered the primary.
Most of that is speculation, but I wanted to throw that out there as I dive into this.

@mleanos  just tested the following
Test 1

Sign up w FB
Connect with G+
Go to manage social accounts and only see G+
Sign out
Sign in with G+
Go to manage social accounts and only G+ still

Test 2

Sign up local
Connect with FB
Go to manage social accounts and only see FB
Connect G+
Now connected accounts show FB & G+

@ervine13 Thanks for the very detailed test results!

I've confirmed this behavior. Although, I only have tested this with one social account (Facebook).
Whichever provider is used to created the account, even local, is set to the user's provider field. If the account was created with a provider other than local, the providerData field is populated with data specific to that provider.
The Manage Social Accounts view is only listing additional providers that can be removed, and any other providers that have not been connected. Any providers other than the primary are stored in the additionalProvidersData field.
It won't be difficult to display the primary provider when it's not local. However, some extra consideration must be taken into account. What happens if the user tries to remove their primary provider? We would need to decide on how to handle that from a logical perspective. The implementation probably wouldn't be too difficult; we just need to figure out what we want to do.
With all that said, I think this is behaving as designed. There must have been a lack of direction on how to handle the above mentioned scenario.
The following HTML is an example of what we could add to the view, with no remove button. Just to signify what the primary provider is.
Primary Provider:

I think that should suffice. As the user, I want to see all the social accounts that I have connected. When I didn't, I thought that maybe I didn't connect it* after all but it* also didn't show up as an option that I could connect it.
*The original social account.
@mleanos - if that's how you guys want to resolve the issue, if at all, would you like me to attempt to PR?

@ervine13 I don't think we'd be resolving the issue, per se. But by at least displaying the primary provider, we'd be making it clear to the user's as to what's going on. Less confusion.
By all means, submit a PR. We may be able to get it merged in for 0.4.2. For the bigger issue of actually managing the primary, and switching the primary, it will be something we'd have to address for 0.5.0.

Seems like a big fix which we should tackle as part of 0.5.0.
Whose up for it? :)

@lirantal I'd be more than happy to take on the providers management aspect of this :)
@ervine13 You still want to handle the displaying of the primary as a start to resolving this?

Thanks Michael!

@lirantal @codydaig @rhutchison @ervine13
How do we want to handle allowing switching/removing a user's primary provider? I see a few different aspects of this requirement..

When the user wants to change their primary provider, and their provider is set to local
a) I guess we just overwrite this to whatever provider their switching to? Thus, "forgetting" about the local provider, since it's not needed for anything.
b) There's no need to display the fact that their primary provider is set to local.

When the user wants to remove their primary provider, and they have no other provider setup
a) Should we switch their account to use local as their provider? And pull over their provider's data?
b) Should we delete their account?

When the user wants to remove their primary provider, and has additional providers setup
a) We should provide a UI to choose which provider they would like to switch to as their primary
b) remove provider

When the user wants to just switch their primary provider (not removing), and has additional providers
a) Provide same UI as (3) and do not remove provider

Any thoughts on these? Anything else?
I'd like to get moving on this. These considerations are more like business rules. I'm not 100% convinced that we need to add this type of thing out of the box, in the framework.
At the very least, we need to display every provider that has been setup for their account, and provide a clean way for them to remove each one. The feature of switching may not really be needed, but we will face similar logic considerations when removing providers.

I started working on a solution for this, but it was closed in favor of "CleanMean"
https://github.com/meanjs/mean/pull/752
What ever happened to that?  Personally, I was not a fan of the design of cleanmean's user module, which is why I was working on something different.

@rhutchison can you sync with @melanos about this to come up with a PR that solves this problem?

@rhutchison You want to work on this together? What in particular have you done so far?


[ENH] add labels taken from the ecobidas / reproschema checklists

discussed briefly with @jeromedockes
Mainly this adds the content of the different ecobidas checklists turned into labelbuddy labels.
Those checklist can be used to plan experiments, when writing a paper, when reviewing a paper and can be useful to provide a template to evaluate papers when conducting a metaanalysis.
Having them as labbelbuddies labels could prove useful.
Currently covered:

fMRI (neurovault metadata used by Carp for his 2012 paper)
MRI (cobidas 1.1 - 2.0: this is work in in progress)
PET (checklist was adapted from https://doi.org/10.1177/0271678X20905433 that was also used for the BIDS PET extension)
eyetracking (based on this paper) that is also being used in the BIDS extension for eyetracking

In each folder I have added each sub section of the checklist as an independent set of labels, in case this is easier to navigate rather than a single flat list of labels

Well I got an idea for the neurovault / COBIDAS one but I cannot say it is small.


Add a function to reset the programs variables in GizmoGeometry

Calling this function avoids problems when creating a new gizmo in a new glContext. The problem is that when a gizmo is created the programs in GizmoGeometry (which are global) are instantiated. After that if a new gizmo is created in a new glContext, the Gizmo Geometry tries to use the programs variables because they aren't undefined but it doesn't work since these programs are associated to the first glContext,

Hi @rtortajada,
Thanks for your first contribution.
I feel you are adding a fix that is more a workaround than a fix. From my point of view the gizmo should not use global programs so the correct fix would be to avoid this.
I suspect these global programs are there for cache, so one idea could be create a registry [context, programs] as when the NodeGizmo is created you have access to the context. If this becomes a problem other idea could be to cache these programs in the NodeGizmo, instead of doing it globally.
So basically the point would be to avoid global programs.
Thoughts?
@cedricpinson @stephomi

@jtorresfabra Yeah caching in NodeGizmo could do the trick. But in the overall this questions is the same for other shape.


Microk8s dies after installing microstack

I am experiencing an issue with microk8s and microstack. When I install microk8s after installing microstack, there are no problems. But, if I have already installed microk8s with a few pods deployed; and later I install microstack, microk8s and all the pods die.
I'm using juju to deploy the kubernetes pods. And I completely lose connection with the juju k8s controller after installing microstack. None of the pods report any error, BUT I cannot log into any one.
These are the logs I'm getting from all the pods, when doing a kubectl describe pods
Events:
  Type     Reason      Age                  From               Message
  ----     ------      ----                 ----               -------
  Warning  Unhealthy   20m                  kubelet, microosm  Readiness probe errored: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial unix /var/snap/microk8s/common/run/containerd.sock: connect: no such file or directory"
  Warning  Unhealthy   20m                  kubelet, microosm  Liveness probe errored: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial unix /var/snap/microk8s/common/run/containerd.sock: connect: no such file or directory"
  Warning  FailedSync  4m4s (x47 over 14m)  kubelet, microosm  error determining status: rpc error: code = Unknown desc = failed to get sandbox ip: check network namespace closed: remove netns: remove /var/run/netns/cni-ab4886e9-bab0-cd33-7994-f9a91fc5364c: device or resource busy

Also I tried restarting microk8s and rebooting the machine. It didn't work. But after rebooting, all pods went into Unknown state, and from that state to CreateContainerError.
inspection-report-20190814_155911.tar.gz

@petevg any ideas?

@ktsakalozos I'd guess that microstack is doing one of three things:

microstack might be grabbing a port that microk8s uses to communicate with the world. microstack grabs port :80, for example. (One of the tasks on our roadmap is to make those ports configurable.)
microstack might be messing with microk8s' bridge. Microstack creates and controls br-ex via Openvswitch. If microk8s is also using the name br-ex, then they probably wind up arguing over that bridge's configuration.
microstack creates and populates the <IP_ADDRESS>/24. If microk8s is also using this cidr, they may be arguing over gateways and addresses.

Do any of those sound plausible?

Thanks @petevg. Port 80 will be an issue in setups where microk8s.enable ingress is used. In the issue https://github.com/ubuntu/microk8s/issues/602 we show how to change the port ingress is used.
The bridge microk8s is using is cbr0 so we are safe there.
The subnets used for pods is the <IP_ADDRESS>/16. So that should be ok too. Something else must be wrong.

Adding a bit more info, as I've been testing this scenario myself.
Setup: I'm watching juju status and kubectl get pods -n osm. When microstack's configure hook is running, I first receive the error from juju status: ERROR connection is shut down.
I've seen that error before, usually when the Juju API server is down.
Output of kubectl describe pod/controller-0 -n controller-osm-on-k8s:
https://pastebin.ubuntu.com/p/PCWH6h3cKb/
Based on that log, it seems like the mongodb container isn't starting. I don't see anything in microstack's configure hook that seems like it would obviously conflict.
A restart of microk8s doesn't restore the controller pod to a functional state. Neither has removing microstack and both restarting microk8s and rebooting the machine.
Testing was done with the candidate channel of microstack, but I'll retry with candidate.

It looks as if there is a clash in the confinement but I am not sure why:
Aug 14 15:42:17 microosm microk8s.daemon-kubelet[5873]: E0814 15:42:17.046606    5873 kuberuntime_manager.go:903] PodSandboxStatus of sandbox "deecc12d92f67411020a2c928cc2edc847fc2f1de4de19b65d79f7c8e9a2f1d7" for pod "ui-k8s-5bb45b9b8-7bgmn_osm(c3a7bd5a-be9f-11e9-b51d-fa163ead2629)" error: rpc error: code = Unknown desc = failed to get sandbox ip: check network namespace closed: remove netns: remove /var/run/netns/cni-8b87d453-70d4-c38b-73a3-2da54ca6a77b: device or resource busy

@ktsakalozos @petevg Hello guys!
I have tested the new microstack version with the ''sudo microstack.init --auto` function. (edge/rocky channel).
Now, this issue is not happening. I mean that when the microstack is installed, the microk8s pods are not going down.
BUT, when rebooting the machine, I'm getting the same issue.  remove /var/run/netns/cni-8b87d453-70d4-c38b-73a3-2da54ca6a77b: device or resource busy on all the pods.
It's important to mention that if I reboot without microstack installed, the pods inside microk8s raise up successfully.
Let me know if there's news on this

@davigar15 the behavior you're seeing is expected. After you run .init, microstack basically behaves in the same way that it was behaving before. It's grabbing a port, or doing something else that is interfering w/ k8s.
The next steps w/ the init script are to make it accept a config flie, which can set ports and the like.
If you have some insight into which ports need to be configurable, please drop that here, and I'll make sure that they are!

That’s great, but do you think the ports are the ones responsible of this
conflict? It seems like that is happening because some networking conflict
(according to the output).
Thanks
David
On Wed, 18 Sep 2019 at 09:17, Pete Vander Giessen<EMAIL_ADDRESS>wrote:

@davigar15 https://github.com/davigar15 the behavior you're seeing is
expected. After you run .init, microstack basically behaves in the same way
that it was behaving before. It's grabbing a port, or doing something else
that is interfering w/ k8s.
The next steps w/ the init script are to make it accept a config flie,
which can set ports and the like.
If you have some insight into which ports need to be configurable, please
drop that here, and I'll make sure that they are!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/microk8s/issues/596?email_source=notifications&email_token=ADRVAFDSVSY72UWJQRJSCZLQKHIZHA5CNFSM4ILWX46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67CEJA#issuecomment-532554276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADRVAFF6QLWAQLRUVQEQUUTQKHIZHANCNFSM4ILWX46A
.

@davigar15 Just re-reviewed the conversation. Yes, I think that you at @ktsakalozos are correct, in that it's not a port issue.
Unfortunately, I don't know what the issue is. k8s and microstack are arguing over some resource, but I'm not clear why they're respective virtualization layers aren't keeping them separate ...

Hi,
I bumped into this thread while trying to install microstack on a box with microk8s installed.
In my case this is on Ubuntu 19.10.
The problem is similar but not the same but not sure if the info below may help so posting in case it does.
I am playing with microk8s.  microk8s has been working fine and I just tried installing microstack following the link here and see that the install fails at this point:
$ sudo snap install microstack --classic --edge
...
$ sudo microstack.init
Do you want to setup clustering? (yes/no) [default=no] >
2019-12-05 19:17:49,681 - microstack_init - INFO - Configuring networking ...
2019-12-05 19:17:50,276 - microstack_init - INFO - Setting up ipv4 forwarding...
2019-12-05 19:17:50,832 - microstack_init - INFO - Opening horizon dashboard up to *
2019-12-05 19:17:51,341 - microstack_init - INFO - Waiting for RabbitMQ to start ...
Waiting for <IP_ADDRESS>:5672
[ gets stuck here ]

The box is idle (as even microk8s is not very busy) but I do notice when checking for the port 5672 the following:
$ netstat -an | grep 5672
tcp        0      0 <IP_ADDRESS>:25672           <IP_ADDRESS>:*               LISTEN
tcp        0      1 A.B.C.D:55562           <IP_ADDRESS>:5672         SYN_SENT
tcp6       0      0 :::5672                 :::*                    LISTEN
$

So what looks wrong here is that the init script is trying to connect on IPv4 and the RabbitMQ listener is only listening on IPv6.
The primary IPv4 interface shows:
eno1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet A.B.C.D  netmask <IP_ADDRESS>  broadcast A.B.C.255
        inet6 fe80::c928:80e8:1b2a:d7b3  prefixlen 64  scopeid 0x20<link>
        ether 94:c6:91:a7:a1:2b  txqueuelen 1000  (Ethernet)
        RX packets 397129  bytes 534951857 (534.9 MB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 86418  bytes 8015033 (8.0 MB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
        device interrupt 16  memory 0xaec00000-aec20000

So IPv6 is configured but not with anything other than link local addresses.
So looks to me like a misconfiguration or expectation of networking setups etc.
Hope this helps.
Regards,
Simon


remove UI elements in ngOnDestroy

Locally I've started adding functionality to remove markers when the component is removed. Needed it for making the map work dynamically with a web socket system. I wasn't sure if this was something on the road map.

To be honest, I haven't planned such scenario, my goal was mostly to make every component updatable. But I'll definitely add this on my road map. The bad thing about this project is that I made it for myself, as part of a larger project that I am currently working on so generally its features depends on other needs. But I am trying on my free time to make it as generic and usable as possible.


Common but non-standard JS function implementations in jerry-ext

This PR splits out the implementation of "common but non-standard" functions
from PR #1749. The goal is to save various targets from re-implementing external
function handlers for print, gc, or assert. The idea is to provide these
handlers as a module of the now-forming jerry-ext library.
The PR is still Work in Progress, because

there is a debate whether all function handlers should be in one module (i.e.,
source sub-directory) of jerry-ext, or each should go into its own subdir,

there is no consensus what would be a good name for the module(s),

I'm not sure how print could be implemented in the most portable but also
efficient way (because a reusable implementation cannot rely on libc's
printf -- but then each port/app must somehow provide its own C-level
printing routine, which we are just getting rid of in #1749...), and

jerry-ext is not in master yet, so there is no build system, CMakeLists,
etc. in this PR.

Note: we can also conclude that such an approach as presented here actually does not add much to reusability, because ports will not share these implementations, e.g., because they have seriously different needs for assert or print. Please, give your feedback, maintainers of targets are especially summoned.

From all extensions, this should land first because it is simple, and we can define the extension format here.

I've updated the PR. The "extfunc" module name got replaced by "external" all over the code.
The PR still does not contain the "infrastructure" (build system) of jerry-ext. IMHO, It would not be fair to rip it off from #1740.

@zherczeg and @akosthekiss I think these two comments are kinds of conflicting:

From all extensions, this should land first because it is simple, and we can define the extension format here.

The PR still does not contain the "infrastructure" (build system) of jerry-ext. IMHO, It would not be fair to rip it off from #1740.

I think @jiangzidong 's PR (#1740) is very close to being done + it includes the build system stuff for jerry-ext. @zherczeg OK to land that first?

Ok land that first.

Now that #1740 has landed, I've rebased this PR on latest master and made use of the jerry-ext infrastructure. On top of the previous commit, there is now also the adaptation of jerry-main to use the implementation of the common JS functions from jerry-ext.

New idea: what about esfunc-assert.h? So we emphasize that it is an ECMAScript function.

I just noticed that there is no documentation for the new API.

@zherczeg To me, esfunc is no better than extfunc that was downvoted originally. And I still don't see why we would need separate headers for each external function handler (we don't have multiple headers for all the argument validation and transform functions).

I've added documentation for the extension.

The difference is that external is a generic term, which does not specifiy the nature of these functions at all. This is the same problem with extfunc. The name should emphiasize that these are JS callback functions. In jerry core these are external callbacks which has some meaning although not the best one.

What about jerryx_print_handler. handler is a popular term for callback functions

For the sake of accuracy, these functions are called "external function handler"s in jerry-core, and their type is jerry_external_handler_t (I haven't seen "callback" in their terminology, neither in API nor internally). The extensions we provide should be consistent with the core in their naming, IMO. That's why "external" was always in the names I proposed, because that's the public API terminology associated with these "things".
As for "jerryx_print_handler": I'll strongly resist against anything unprefixed. Right now, we have arg in jerry-ext, then we have this PR, and contexts are also coming, and who knows what's next. I'll keep insisting to have each "module" within its own "identifier namespace" (+ directory, + header).
Would jerryx_handler_print, jerryx_handler_gc, jerryx_handler_assert, jerryx_handler_register_global, jerryscript-ext/handler.h be better / more favoured / acceptable?

Probably handler implies callback, since handlers are subset of callbacks. jerryx_handler_print is ok for me. What about plural here: jerryscript-ext/handlers.h ?

I'll rename everything to jerryx_handler_ then, if noone objects. Not sure about the plural in the header name. Argument handling extension uses singular, context extension likewise.

I've applied the name change, it's in a commit on top of the rest (will squash if everyone is happy with it)


cellxgene-schema must download and process pinned ontologies

Details
The following pinned ontologies MUST be refreshed:

Ontology
OBO Prefix
Release
Download

Cell Ontology
CL
2023-08-24
cl.owl

Experimental Factor Ontology
EFO
2023-08-15 EFO 3.57.0
efo.owl

Human Ancestry Ontology
HANCESTRO
3.0
hancestro-base.owl

Mondo Disease Ontology
MONDO
2023-08-02
mondo.owl

Uberon multi-species anatomy ontology
UBERON
2023-09-05
uberon.owl

The following ontologies will not be updated in 4.0:
Sept 6: Jason has pinged the development stage ontologists for an update on their formal release plans.

Ontology
OBO Prefix
Release
Download

Human Developmental Stages
HsapDv
2020-03-10
hsapdv.owl

Mouse Developmental Stages
MmusDv
2020-03-10
mmusdv.owl

NCBI organismal classification
NCBITaxon
2023-06-20
ncbitaxon.owl

Phenotype And Trait Ontology
PATO
2023-05-18
pato.owl

@brianraymor @jahilton apologies if this was already mentioned and I forgot, but 2 weeks ago HsapDv and MmusDv made their first github release
Because we pin their owls in http://purl.obolibrary.org/obo/, we are actually going to pull this latest release when we upgrade. Now that there is an official github release, if we are ok with upgrading, we should actually pin to the OWL files in that release rather than pulling from http://purl.obolibrary.org/obo/. If we are not, we should find a way to pin to the previous version.

@brianraymor @jahilton apologies if this was already mentioned and I forgot, but 2 weeks ago HsapDv and MmusDv made their first github release

Yes. See single-cell-four.

@jahilton not sure if this has QA associated with it, but its ready if so!


Dependency list to use the script on windows is not clear

While trying to build / run the  duckypad_autoprofile.py script on Windows I ran into some troubles regarding dependencies / requirements.
the requirements.txt file currently only contains 2 packages, one of which seems to be for MacOS only (pyobjc).
In order to run the  duckypad_autoprofile.py script I had to install the following packages via pip:
hidapi
pygetwindow
wmi
appdirs

thanks for the info, also psutil is need at last on my system
$ pip freeze

appdirs==1.4.4
ewmh==0.1.6
hidapi==0.11.0.post2
psutil==5.9.0
PyGetWindow==0.0.9
PyRect==0.1.4
python-xlib==0.31
six==1.16.0
WMI==1.4.9


Is it allowed to create a pull requests for NFT's ? (Assuming there might be millions)

I'm submitting a ...
[ ] bug report
[ ] feature request
[x] question about the decisions made in the repository
[x] question about how to use this project

Summary
Is it allowed to create a pull requests for NFT's ? (Assuming there might be millions)

No, the token list does not track NFTs


Orbit always crash when open

Hi, I used to open Orbit in the past and had no issue, but today I opened Orbit and it always crashed, does anyone have any idea?

Can you elaborate a bit more?
Which version are you using? Do you build by your own?
Maybe, can you share the crash dump in the specified path?

I am using the latest release: ORBIT_PROFILER_1.0.2
I just download the release package here: https://github.com/google/orbit/releases
then extract it and open orbit.exe.
The weird part is it is working today, I don't know why it crashed in the past.

If the crashes happen again, you might be able to share a crash dump with us. However, as this is the old and unfortunately unsupported Windows version, we won't be able to provide a hotfix for this.

Hi @florian-kuebler! I have same problem.
I run V1.0.2 version in windows 10(V19044.1766) with i5-10400 and 16GB RAM.
There is crash dump file.
cbca48f6-6678-483c-87df-e8e55cd00a6e.zip


fix: use to_additive (attr := _) here and there

See also #1819 and #1885

Thanks!
bors merge


Add gulp serve task

When doing development every time I make a change I have to build the project in order to verify the changes I made.
Now using the gulp serve command it starts a webserver and automatically rebuilds the project. I just have to refresh the page on the browser to see my changes.

Sorry for the delay here - I took an unplanned hiatus from this project and am just now getting back to work and working through my backlog of PRs and things.
This is extremely useful for development, thank you very much for the contribution!