fix the readonly attribute of textarea break the vscode.workspace.onDidChangeTextDocument API #117755

This PR fixes #117755
The readonly attribute is used to disable keyboard popping in mobile devices, but it break the vscode.workspace.onDidChangeTextDocument event.
The extensions who use onDidChangeTextDocument API are breaked on browser version vscode. (For example: Vim)
I think if there an option named platform.isMobile would be better

Thank you!
--
The CLA is not needed, as the original commit from @conwnet only touched 2 lines.


Replace i tags with vue-fontawesome

#244

@Hasnayeen before you review and merge can you try and build the assets for production? It is taking an insane amount of time on my machine.

Codecov Report

Merging #272 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #272   +/-   ##
=========================================
  Coverage     79.06%   79.06%
  Complexity      223      223
=========================================
  Files            81       81
  Lines           731      731
=========================================
  Hits            578      578
  Misses          153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b63999...932afea. Read the comment docs.


Provide better way of documenting non-flag/switch arguments

Currently, you can document a command's arguments via arg_name.  This is OK for simple commands, but for commands that have and ordering of arguments, it's difficult.  A syntax might be:
arg_name 1,"the filename"
arg_name 2,:optional,"output file (stdout if omitted)"

Unify this and whatever methadone uses

Closing as old


Docker & Docker-Compose

It's finally here! Long awaited.
This pull request will allow pajbot to be run in docker containers.
There are multiple new files.
Two main docker files, one for pajbot and one for the postgres database.
The pajbot dockerfile, mainly move ALL the files into the container and installs all the dependencies.
The postgres dockerfile, adds a new entry file to the postgres instance, this allows for creation of multiple users/database, however this is a SIMPLE implementation.
In my example it adds a user db1 with password db1 and database db1 and a user db2 with password db2 and database db2.
This should be secure enough, since it is all encapsulated in the docker network.
Like the other PR i made, the docker-file does almost the same, however the mysql have been replaced by postgres (took me some time to figure out why i got all those mysql errors).
And the "api-v3" has been removed.
The .env file has as well since the redis connection has been moved to the file where the following  have to be added for it to connect to the redis server.
[redis]

host=redis

The modification to the user.py is because i kept getting the error that self.time_in_chat_offline was None, might only be me.
Ohh yeah
To build and run docker-compose up -d --build

I can try to run this afternoon. Am I filling out the config file as per normal?

As it currently is, it is build to run on linux, this can be seen since it links internal /opt/www/configs to the folder on the host machine in /opt/pajbots/, this is seen in the docker-compose file.
in the /opt/pajbots the bot looks for the file called config.ini this can be changed to whatever you want.

Are you saying that /opt/pajbot is an internal folder within the container? What if I want to run multiple bots?
Perhaps I'm missing something?

The folder /opt/pajbot is not directly within the container, but linked as a shared folder with the container, like symlink'ish. Meaning if you want to have multiple bots running, you would have to have multiple config files in the /opt/pajbot folder.
Then in the docker-compose.yml file make sure that each of the bots loads the right config file, like pajlada.ini.

Working on this now; the name pajbot_pajbot_bot_1 is a little ugly, can we change that? Perhaps to pajbot1_streamername? Secondly, how do I go about changing the container name to the name of the streamer? Thirdly, what template config should I be using? I used the standard one, but get an error when I run docker compose; claiming that cliendid is blank despite it not being blank.

How does you docker-compose.yml file look?

version: '3.2'
services:
  pajbot_web:
    build:
      context: .
      dockerfile: configuration/PajbotDockerfile
    ports:
      - "7070:2325" # Forward container port 2325 to host port 7070
    volumes:
      - /opt/pajbots/:/opt/www/configs # /opt/pajbots/ is the host folder, /opt/www/configs is the folder in the container
      - sockets:/srv/pajbot # Remember the sockets should be unique between bot and web, unless multiple bots/web should share
    depends_on:
      - postgres
      - redis
    command: ["python3", "app.py", "--config", "/opt/configs/alazymeme.ini"]

  pajbot_bot:
    build:
      context: .
      dockerfile: configuration/PajbotDockerfile
    restart: unless-stopped # Enabled auto restart, since the bot is gonna crash until redis has token
    volumes:
      - /opt/pajbots/:/opt/www/configs # /opt/pajbots/ is the host folder, /opt/www/configs is the folder in the container
      - sockets:/srv/pajbot # Remember the sockets should be unique between bot and web, unless multiple bots/web should share
    depends_on:
      - postgres
      - redis
    command: ["python3", "main.py", "--config", "/opt/configs/alazymeme.ini"]

  redis:
    image: redis:latest
    restart: always
    volumes:
      - redis:/data
    command: ["redis-server", "--appendonly", "yes"]

  postgres:
    build:
      context: .
      dockerfile: configuration/PostgresDockerfile
    restart: always
    volumes:
      - postgres:/var/lib/postgresql/data
    environment:
      - POSTGRES_MULTIPLE_DATABASES=db1,db2
      - POSTGRES_USER=postgres
      - POSTGRES_PASSWORD=omegalul

volumes:
  sockets:
    driver: local
  postgres:
    driver: local
  redis:
    driver: local

Try this:
version: '3.2'
services:
  pajbot_web:
    build:
      context: .
      dockerfile: configuration/PajbotDockerfile
    ports:
      - "7070:2325" # Forward container port 2325 to host port 7070
    volumes:
      - /opt/pajbots/:/opt/www/configs # /opt/pajbots/ is the host folder, /opt/www/configs is the folder in the container
      - sockets:/srv/pajbot # Remember the sockets should be unique between bot and web, unless multiple bots/web should share
    depends_on:
      - postgres
      - redis
    command: ["python3", "app.py", "--config", "configs/alazymeme.ini"]

  pajbot_bot:
    build:
      context: .
      dockerfile: configuration/PajbotDockerfile
    restart: unless-stopped # Enabled auto restart, since the bot is gonna crash until redis has token
    volumes:
      - /opt/pajbots/:/opt/www/configs # /opt/pajbots/ is the host folder, /opt/www/configs is the folder in the container
      - sockets:/srv/pajbot # Remember the sockets should be unique between bot and web, unless multiple bots/web should share
    depends_on:
      - postgres
      - redis
    command: ["python3", "main.py", "--config", "configs/alazymeme.ini"]

  redis:
    image: redis:latest
    restart: always
    volumes:
      - redis:/data
    command: ["redis-server", "--appendonly", "yes"]

  postgres:
    build:
      context: .
      dockerfile: configuration/PostgresDockerfile
    restart: always
    volumes:
      - postgres:/var/lib/postgresql/data
    environment:
      - POSTGRES_MULTIPLE_DATABASES=db1,db2
      - POSTGRES_USER=postgres
      - POSTGRES_PASSWORD=omegalul

volumes:
  sockets:
    driver: local
  postgres:
    driver: local
  redis:
    driver: local

Ok now how do I go about renaming the container? Should I be changing something in the scenario that I want to run more than one bot?

Your config also didnt work:

Just tested it on my machines, and looks like it's working.
So.... you need on your "host" machine have your .ini files in the /opt/pajbots folder, since that is going to be mounted to the containers, as a volume.
You need to update some things as well.
db = postgresql+psycopg2://db1:db1@postgres/db1?options=-c%%20search_path%%3Dpajbot1_kkonatestbroadcaster
That is for the database, and
[redis]
host=redis

Is for the redis server setup.

Do I have to use pajbot1_kkonatestbroadcaster as the db name?

Also still not working:

The name for the database is db1.
And the try and run ls /opt/pajbots

Try and do mv ./confics ./, that should do the trick.

[2019-11-30 07:45:05,907] [DEBUG  ] Loaded config
[2019-11-30 07:45:05,909] [DEBUG  ] Cache Miss: api:twitch:helix:user:by-login:alazydroid
[2019-11-30 07:45:05,909] [DEBUG  ] No app access token present, trying to fetch new OAuth token
[2019-11-30 07:45:06,548] [DEBUG  ] Cache Miss: api:twitch:helix:user:by-login:alazymeme
[2019-11-30 07:45:06,651] [ERROR  ] Logging an uncaught exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2275, in _wrap_pool_connect
    return fn()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 303, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 760, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 492, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/impl.py", line 139, in _do_get
    self._dec_overflow()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/langhelpers.py", line 68, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 153, in reraise
    raise value
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/impl.py", line 136, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 308, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 437, in __init__
    self.__connect(first_connect_check=True)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 639, in __connect
    connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 453, in connect
    return self.dbapi.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.7/site-packages/psycopg2/__init__.py", line 126, in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
psycopg2.OperationalError: could not connect to server: No such file or directory
        Is the server running locally and accepting
        connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "main.py", line 74, in <module>
    run(args)
  File "main.py", line 40, in run
    pajbot = Bot(config, args)
  File "/opt/www/pajbot/bot.py", line 144, in __init__
    sql_conn = DBManager.engine.connect().connection.connection
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2206, in connect
    return self._connection_cls(self, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 103, in __init__
    else engine.raw_connection()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2306, in raw_connection
    self.pool.unique_connection, _connection
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2279, in _wrap_pool_connect
    e, dialect, self
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1544, in _handle_dbapi_exception_noconnection
    util.raise_from_cause(sqlalchemy_exception, exc_info)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 398, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 152, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2275, in _wrap_pool_connect
    return fn()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 303, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 760, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 492, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/impl.py", line 139, in _do_get
    self._dec_overflow()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/langhelpers.py", line 68, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 153, in reraise
    raise value
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/impl.py", line 136, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 308, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 437, in __init__
    self.__connect(first_connect_check=True)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 639, in __connect
    connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 453, in connect
    return self.dbapi.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.7/site-packages/psycopg2/__init__.py", line 126, in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) could not connect to server: No such file or directory
        Is the server running locally and accepting
        connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

(Background on this error at: http://sqlalche.me/e/e3q8)
[2019-11-30 07:46:09,443] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:47:12,244] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:48:14,765] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:49:17,694] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:50:20,405] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:51:22,973] [ERROR  ] configs/alazymeme.ini missing. Check out the example config file.
[2019-11-30 07:52:25,530] [ERROR  ] Logging an uncaught exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 538, in connect
    sock = self._connect()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 595, in _connect
    raise err
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 583, in _connect
    sock.connect(socket_address)
OSError: [Errno 99] Cannot assign requested address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 74, in <module>
    run(args)
  File "main.py", line 40, in run
    pajbot = Bot(config, args)
  File "/opt/www/pajbot/bot.py", line 83, in __init__
    wait_for_redis_data_loaded(RedisManager.get())
  File "/opt/www/pajbot/utils/wait_for_redis_data_loaded.py", line 12, in wait_for_redis_data_loaded
    redis.ping()
  File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 1106, in ping
    return self.execute_command('PING')
  File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 836, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 1071, in get_connection
    connection.connect()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 543, in connect
    raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 99 connecting to localhost:6379. Cannot assign requested address.

[2019-11-30 07:54:30,546] [DEBUG  ] Loaded config
[2019-11-30 07:54:30,548] [DEBUG  ] Cache Miss: api:twitch:helix:user:by-login:alazydroid
[2019-11-30 07:54:30,548] [DEBUG  ] Successfully loaded OAuth token from storage
[2019-11-30 07:54:30,684] [DEBUG  ] Cache Miss: api:twitch:helix:user:by-login:alazymeme
[2019-11-30 07:54:30,896] [ERROR  ] Logging an uncaught exception
Traceback (most recent call last):
  File "main.py", line 74, in <module>
    run(args)
  File "main.py", line 40, in run
    pajbot = Bot(config, args)
  File "/opt/www/pajbot/bot.py", line 147, in __init__
    sql_migration.run()
  File "/opt/www/pajbot/migration/migrate.py", line 23, in run
    with self.migratable.create_resource() as resource:
  File "/usr/local/lib/python3.7/contextlib.py", line 112, in __enter__
    return next(self.gen)
  File "/opt/www/pajbot/migration/db.py", line 13, in create_resource
    cursor.execute("CREATE TABLE IF NOT EXISTS schema_version(revision_id INT NOT NULL)")
psycopg2.errors.InvalidSchemaName: no schema has been selected to create in
LINE 1: CREATE TABLE IF NOT EXISTS schema_version(revision_id INT NO...
                                   ^```

which of the containers is that?

that's the main bot one, after running sudo docker logs

One of the containers should create the databases, and restarting the bots should fix the last things.

Still not working

Looking at this PR now, few points that I might remedy myself:

We should be utilizing schemas in postgresql instead of multiple databases
There should be instructions for how to set this up, like:
You need to set your redis host in the config to be redis (make actual howdo)
You need to set up your database url to point to postgresql as the host (make actual howto)

Things pajlada, said i should remember:

How should "postgres users" be created upon new bot instance, without disturbing the old bots?
The whold utilizing schemas.

Is this being actively worked on anymore? @Leppunen already has a functioning docker branch that can be used: https://github.com/pajbot/pajbot/tree/docker


IOU - USD instead of non-USD currency in report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Prerequisites: User A and B both have USD as report currency in OldDot, currently logged in on 2 devices

As userA, FAB > Request Money to userB in a non-US currency, f.e EUR20

Expected Result:
UserB should receive a report action like Requested $20
Actual Result:
UserB receives a report action like Requested EUR20
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/236073382-702d16c5-9d77-4c8b-bf1c-ffaa54f84458.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Is the issue here that for some reason we default to EUR for the original user? I think this is actually governed by your location, not the policy currency:

I don't think we want to change this.

I don't think we want to change this. cc @trjExpensify who has worked more on manual requests than any other.

Yup, from the OP issue..
The request is in EUR, the report total is in USD. That's because the personal policy currency of the person that's owed is USD, so the EUR request converts to USD on the report.


Handover Views

Handover Views (WIP)
The Handover App needs to migrate from Fusion Dataproxy using ProCoSys Views to FAM Views. Below is a proposal for the different data the App will need to consume.
Handover main app

[x] projectIdentifier
[x] projectDescription
[x]  commpkgNo
[x] commpkgId
[x] system
[x] progress
[x] area
[x] commpkgStatus
[x] mcStatus
[x] priority1
[x] priority2
[x] priority3
[x] plannedStartDate
[x] actualStartDate
[x] plannedFinishDate
[x] ActualFinishDate
[x] phase
[x] responsible
[x] hasUnsignedActions
[x] forecastFinishDate
[x] volume
[x] forecastTacDate
[x] mcPkgsCount
[x] mcPkgsRFCCShippedCount
[x] mcPkgsRFCCSigned
[x] mcPkgsRFOCShipped
[x] mcPkgsRFOCSigned
[x] tacIsAccepted
[x] tacIsShipped
[x] tacIsRejected
[x] plannedTacDate
[x] forecastStartDate
[x] mcDisciplineCodes
[x] mcDisciplines
[x] IsDemolition
[x] demolitionPlannedStartDate
[x] demolitionForecastStartDate
[x] demolitionActualStartDate
[x] demolitionPlannedFinishDate
[x] demolitionForecastFinishDate
[x] demolitionActualFinishDate
[x] remark
[x] rfocIsShipped
[x] rfocIsRejected
[x] rfccIsShipped
[x] rfccIsAccepted
[x] rfccIsRejected
[x] demolitionDCCAcceptedDate
[x] demolitionRFRCShippedDate
[x] tacIsActualDate
[x] rfccShippedDate
[x] rfocPlannedDate
[x] rfocForecastDate
[x] rfocActualDate
[x] rfocShippedDate

Handover/Details

[ ] nextToSign

Handover/MCPackages

[x] commpkgId
[x] mcPkgNo
[x] mcPkgId
[x] mcStatus
[x] rfccShippedActualDate
[x] rfccIsAccepted
[x] rfccIsRejected
[x] rfccIsShipped
[x] rfocIsAccepted
[x] rfocIsRejected
[x] rfocIsShipped

Handover/NCR

[ ] documentNumber
[ ] documentId (?)
[ ] title

Handover/Workorders

[x] workOrderNumber
[x] workOrderId
[x] description
[x] projectProgress
[x] workOrderStatus
[x] materialStatus

Handover/Unsigned Tasks

[x] taskNumber
[x] title
[ ] documentId?
[x] taskId?

I need to be able to generate this URL: [...]/Documents/Document#id=114212839&content=TASK!aa7e60c4-2d6d-424a-a83d-6a2ee8f209d9&tab=content
Handover/Unsigned Actions

[x] actionNumber
[x] title
[x] description
[x] commPkgId
[x] actionId?

I need to be able to generate this URL: [...]/Completion#CommPkg|112647990?bf=1&content=MAINACTION!2fc767f3-7421-15e3-3a66-316e2d3a21fc
Handover/Punch

[x] tagNumber
[x] status
[x] description
[x] toBeClearedBy
[x] sorting
[x] punchId?
[x] tagId?

I need to be able to generate this URL: [...]/Completion#PunchList|23674669?itemId=3743342
Handover/SWCR

[x] swcrNumber
[x] status
[x] description
[x] priority
[x] swcrId

Handover/Query

[x] queryNumber
[x] queryId?
[x] title
[x] status
[x] nextToSign
[x] type

I need to be able to generate this URL: [...]/Documents/Document/#id=114890226
New fields that have been requested and not yet implemented in current solution

[x] open PA
[x] open PB
[x] not signed MCCRs
[ ] open work orders (< 100%)
[x] not signed CPCLs
[ ] open SWCRs
[ ] not signed tasks
[ ] not signed actions
[ ] open queries
[ ] remaining mhrs on open work orders

Suggested changes to Handover/MCPackages
At the moment we need to resolve each MC packages' RFOC and RFCC status based on the fields

rfccIsAccepted -> "RFCC Accepted"

rfccIsRejected -> "RFCC Rejected"

rfccIsShipped -> "RFCC Sent"
If none of the above -> "OS"

rfocIsAccepted -> "RFOC Accepted"

rfocIsRejected -> "RFOC Rejected"

rfocIsShipped -> "RFOC Sent"
If none of the above -> "OS"

The frontend should be served with these two properties:

rfccStatus: string with value either "RFCC Accepted", "RFCC Rejected", "RFCC Sent" or "OS"
rfocStatus: string with value either "RFOC Accepted", "RFOC Rejected", RFOC Sent" or "OS".

Since the frontend should go via dataproxy, it should probably be resolved in dataproxy so FAM view doesn't contain this logic?
Resulting in this:

mcPkgNo
mcPkgId
Description
mcStatus
rfccStatus
rfocStatus

Suggested change to Handover/Workorders
At the moment we need to resolve each workorder's status based on

projectProgress = 100 -> "WO Finished"
materialStatus containing m12, m13, mn & workOrderStatus containing w04-w10 -> "Material and Workorder OK"
materialStatus containing m7, m9, m10, m11, mn & workOrderStatus containing w03-w10 -> "Material and Workorder Available"
if none of above -> "Material and/or Workorder not Available"

The frontend should be served with this property:

woStatus: string with value either "WO Finished", "Material and Workorder OK", "Material and Workorder Available" or "Material and/or Workorder not Available"

Resulting in this:

workOrderNumber
workOrderId
description
projectProgress
status

Is the entire history here up-to date? Or can we trust the OP?

Is the entire history here up-to date? Or can we trust the OP?

The data that is missing (not the DB views) should be: NCR, DocumentID for Tasks, NextToSign

@jaysencpp documentID for URL to PCS is now in PROD according to FAM.

Closing this - the nextToSign is considered a nice-to-have - but put on hold. See comment


Enable Travis testing on Go 1.5

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

1.5 hasn't been tagged yet, closing.


Add support for fetching profile images

Telegram supports fetching an user's avatars history. botogram should be able to get them from an User object.

Just landed on master!


Add bench-fibo example as proper benchmark

Also move sources to src/ so there are no accidental rebuilding.

Motivation is to have some benchmark in this repository itself, so it's easier to test out stuff.

Please update https://github.com/Bodigrim/tasty-bench/blob/1fb79b5d0a237cf32e088598e4fd9c64c6fd627a/.github/workflows/other.yml#L68

Thanks!


Use typescript for global hooks

What is your Scenario?
We have hook code written in typescript that we currently have to copy and paste to all our tests, it would be nice to be able to define our global fixture/test hook code once but because it's written in typescript we would have to pre-compile it in order to use it in the JavaScript config file
What are you suggesting?
Some mechanism for defining a file where you hooks can live instead of the code being directly in the config file. For example if you could specify a path to your hooks file instead of the functions directly this code could be written in typescript and compiled by testcafe
What alternatives have you considered?
Compiling the code before using it, this would be a little awkward as it would require two typescript builds one before testcafe starts and the one by testcafe.
I had the thought that we could maybe do this as a work around:
module.exports = {
    hooks: {
        fixture: {
            before: async (ctx) => {
                const {before} = require("./ts-compiled/hooks")
                await before(ctx);
            },
            after: async (ctx) => {
                const {after} = require("./ts-compiled/hooks")
                await after(ctx);
            }
        },
        test: {
            before: async (t) => {
                const {beforeTest} = require("./ts-compiled/hooks")
                await beforeTest(ctx);
            },
            after: async (t) => {
                const {afterTest} = require("./ts-compiled/hooks")
                await afterTest(ctx);
            }
        }
    }
};

but there does not seem to be a way to find out where the TS is compiled to by testcafe or not clear if testcafe would know to compile these files at all
Additional context
No response

Thank you for your suggestion. We'll take it into account.

This would be really handy to have.


Can't open /home/xxx/IMPACT_central.log (No such file or directory)

When I run this script that returned an exception to me.

Can't open /home/xxx/IMPACT_central.log (No such file or directory) at /IMPACT-Pipeline-1.0.1/sofeware/localperl/lib/site_perl/5.20.2/Log/Log4perl/Appender/File.pm line 151.
BEGIN failed--compilation aborted at /data/PRO/pro_cancer/pipeline/IMPACT-Pipeline-1.0.1/bin/RunIlluminaProcess.pl line 111.

As you know, a part of Linux systems set $HOME not equal '/home/yourname/'. I found the bug in the below script.
https://github.com/rhshah/IMPACT-Pipeline/blob/7b34bffb4761f67b19583746b296e5ce381f59e2/custom_perl_module/MSKCC_DMP_Logger.pm#L156
fix below:
my $uName = `echo \$HOME`;

Thanks for reporting


Explorer no longer recognizes key combination "option+command+delete" - no longer permanently deletes file on Mac OS

Issue Type: Bug
On Mac OS select a file in the explorer and enter "option+command+delete" to permanently delete the selected file.
VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM)2 Duo CPU     P7550  @ 2.26GHz (2 x 2260)

GPU Status
2d_canvas: unavailable_softwarechecker_imaging: disabled_offflash_3d: unavailable_offflash_stage3d: unavailable_offflash_stage3d_baseline: unavailable_offgpu_compositing: unavailable_offmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: enabledrasterization: unavailable_offsurface_synchronization: enabled_onvideo_decode: unavailable_offwebgl: unavailable_offwebgl2: unavailable_off

Load (avg)
2, 2, 4

Memory (System)
8.00GB (0.23GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

markdown-preview-github-styles
bie
0.1.4

vscode-eslint
dba
1.8.0

code-beautifier
mic
2.1.0

debugger-for-chrome
msj
4.11.1

advanced-new-file
pat
1.2.0

material-icon-theme
PKi
3.6.3

code-settings-sync
Sha
3.2.4

code-spell-checker
str
1.6.10

open-in-browser
tec
2.0.0

es6-string-html
Tob
1.8.6

lorem-ipsum
Tyr
1.2.0

append-comma
vco
0.0.1

highlight-matching-tag
vin
0.8.6

colonize
vms
2.2.2

vim
vsc
1.0.8

(8 theme extensions excluded)

I don't believe this is a duplicate of #66989 because that is reporting an issue with key combination "command+delete" whereas mine is for key combination "command+delete+option".

It appears that v1.31.1 corrected this issue and therefore I am closing this out. Thank you for addressing this :).


Use latest errata-tool package with fix

We need https://github.com/red-hat-storage/errata-tool/pull/231
for elliott working correctly.
The official errata-tool package release isn't cut yet,
I don't think we need to wait for that.

/lgtm


Nested scroll bars due to limited cell height make for really poor experience

https://github.com/microsoft/vscode-jupyter/issues/1792
This is an exac duplicate of this bug, but 4 years later, I STILL CAN'T GET RID OF Nested Scroll Bars.
I've tried setting the     "python.dataScience.maxOutputSize": -1  doesnt do anything now.
and I've set "notebook.output.textLineLimit": 30000,
To no avail. As the original author points out, having double scroll bars onto a small viewport  when you have a huge window you could be scrolling through is far less than optimal. Google Colab lets you override this with a simple piece of Javascript that doesn't work in here.

Just let me have a near infinite length output cell, that is scrolled with the main window scroll bar (moving my code cell out of view).

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Cannot find module 'OnScreen'

Hi,
I installed onScreen using below command successfully:
npm install onscreen --save

But I failed to bundle onScreen with babel.
The error is:
Error: Cannot find module 'OnScreen'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.Module._load (module.js:386:25)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (gulpfile.babel.js:23:1)
    at Module._compile (module.js:541:32)
    at loader (/Users/zhenyu/Development/nodetest/frontend/node_modules/babel-register/lib/node.js:158:5)

and below is my usage, the same as the README:
import OnScreen from 'OnScreen';

module name is onscreen. all lowercase. the README is wrong about it, I'll update it ASAP.

Hi silvestreh,
Thank you for the prompt reply.  But change to onscreen doesn't help.

That's odd… which module bundler are you using? I see that you're using Babel, right?

Yes, I'm using babel and gulp.

And which module bundler? Browserify, Webpack?

I'm using browserify. Do you need I create a demo project?

Nah, I'll setup one for me. Thanks

Thank you so much for looking into this.

I'm afraid I was unable to reproduce it. But I added a Browserify demo that uses Gulp and Babelify. check it out.

It is so strange. I cloned the project and run run gulp, the error is:
{ [Error: Couldn't find preset "es2015" relative to directory "/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp" while parsing file: /Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/src/main.js]
  filename: '/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/src/main.js',

So I added babel-preset-es2015 to package.json and run gulp again but still failed with below log:
{ Error: Cannot find module 'onscreen' from '/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/src'
    at /Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:46:17
    at process (/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:92:31)
    at /Users/zhenyu/temp/screen/demos/browserify-with-babel-and-gulp/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:117:15)
  stream:
   Labeled {
     _readableState:
      ReadableState {
        objectMode: true,
        highWaterMark: 16,
        buffer: [],
        length: 0,
        pipes: [Object],
        pipesCount: 1,
        flowing: true,
        ended: false,
        endEmitted: false,
        reading: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: false,
        resumeScheduled: false,
        defaultEncoding: 'utf8',
        ranOut: false,
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null },
     readable: true,
     domain: null,
     _events:
      { end: [Object],
        error: [Object],
        data: [Function: ondata],
        _mutate: [Object] },
     _eventsCount: 4,
     _maxListeners: undefined,
     _writableState:
      WritableState {
        objectMode: true,
        highWaterMark: 16,
        needDrain: false,
        ending: true,
        ended: true,
        finished: true,
        decodeStrings: true,
        defaultEncoding: 'utf8',
        length: 0,
        writing: false,
        corked: 0,
        sync: false,
        bufferProcessing: false,
        onwrite: [Function],
        writecb: null,
        writelen: 0,
        bufferedRequest: null,
        lastBufferedRequest: null,
        pendingcb: 0,
        prefinished: true,
        errorEmitted: false,
        bufferedRequestCount: 0,
        corkedRequestsFree: [Object] },
     writable: false,
     allowHalfOpen: true,
     _options: { objectMode: true },
     _wrapOptions: { objectMode: true },
     _streams: [ [Object] ],
     length: 1,
     label: 'deps' } }

My node version is v5.11.1, I also tested with 6.1.0.

Hmmm… strange… could you share your package.json and gulpfile.js with me?

just a quick headsup: I moved the demo project to their own repository.

I found the problem now. This issue is caused by below lines in your package.json:
"main": "dist/onScreen.umd.js",
"jsnext:main": "dist/onScreen.es6.js",

Actually, in dist directory, the file is OnScreen.umd.js. Linux and my mac are both case-sensitive, that is why I encountered the problem.
So please fix the case and republish it. Thank you!

Will do! I'll use lisp-case… I actually fixed this very same issue with the source files but I absolutely forgot to do the same for the built library. Silly me.
BTW, I'm also using a mac. Mine's running Yosemite 10.10.5.

@steveluo done! just pushed 1.1.3.

@silvestreh  I can confirm that the issue is fixed and you can close this issue now! Thank you so much for the help! 👍 👍 👍

No problem! Thank you for pointing it out!


ENYO-1125: Add "accessibilityHint" to enyo control

AccessibilityHint is used for additional information of control. If
accessibilityHint is set and content exists, screen reader reads
accessibilityHint with content when control is focused.
For example there is a button and if button clicked, image or video will
be played. In this case blind needs to know what will happen after
clicking button.
AccessibilityHint can explain the result of action and describe
something need to more information.
https://jira2.lgsvl.com/browse/ENYO-1125
Enyo-DCO-1.1-Signed-off-by: Jaewon Jang<EMAIL_ADDRESS>

This PR has dependency on https://github.com/enyojs/enyo/pull/1078

I'll make another PR, so close this.


order changes

-removed trial_court_name
combine late fee and other fee question?

https://github.com/nonprofittechy/docassemble-MOHUDEvictionProject/issues/61

https://github.com/nonprofittechy/docassemble-MOHUDEvictionProject/issues/76

https://github.com/nonprofittechy/docassemble-MOHUDEvictionProject/issues/67

https://github.com/nonprofittechy/docassemble-MOHUDEvictionProject/issues/65


Consider njobs variable

Look into whether the data for this variable should even be included at all in the dataset. Consider:

coverage in rounds and years
correlation with industry occupation lstatus and other labor variables

conclusion:

only years 2008 and beyond have an njobs variable
the variable doesn't seem to correlate with wave, but is present in about 15% - 20% of observations in each year only after 2008
the number of jobs doesn't seem to correspond with information in other labor variables, so for now I will not include in the code


Removed obsolete rpm-related install code.

See this thread and especially the last posts: https://discuss.python.org/t/tool-to-build-a-rpm-package-backed-by-pep-517/4020/4

@claudep Thanks :+1:


Outdated documentation about $$ around math expression

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://github.com/github/docs/blob/main/content/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions.md
What part(s) of the article would you like to see updated?
Something has changed recently, $$ symbols around math expression are now ignored and do not force to show the expression as a block. Not sure if it's a feature or a bug, however the documentation doesn't reflect real state anymore, so it either should be fixed or documentation updated.
See paragraph Writing expressions as blocks:
On the PNG image the expression is shown as a block centered under the heading, but it doesn't look like it anymore.
Additional information
No response

@gashtaan Thank you for opening an issue! I'll get this triaged for review ✨

Hi @gashtaan! Thanks for opening this. Where are you seeing this behaviour? Taking the example from the article, it appears to be working:
The Cauchy-Schwarz Inequality
$$\left( \sum_{k=1}^n a_k b_k \right)^2 \leq \left( \sum_{k=1}^n a_k^2 \right) \left( \sum_{k=1}^n b_k^2 \right)$$
If this is a bug, the best route would be via GitHub Support so they can escalate it to our engineering team, but let's first figure out what's working and isn't working! 😄

@stevecat Hi, weird, I see the expression ok in your post, but not in README.md in one of my repositories in github viewer. It's not about the block is not centered, equations in my document are not displayed in blocks at all, so it becomes quite unreadable.
Please, see: https://github.com/gashtaan/buderus-rc35-internals/blob/main/Equations/README.md
I've tried the exact example code (you posted here) in github's editor and it's not displayed in block as it should.

Thanks @gashtaan, I can see that! ✨
I think the issue might be whitespace, many markdown features don't render unless they have some space around them. I added some space around your math expressions in a fork and they're rendering as expected now (I think, please confirm 😄):
https://github.com/stevecat/buderus-rc35-internals/blob/patch-1/Equations/README.md
You can see what I changed in this commit: https://github.com/stevecat/buderus-rc35-internals/commit/98899000c2f80dc73552242c6db1946ac7008874
I think we could still make a change to the docs here as the following isn't very helpful:

To add a math expression as a block, start a new line and delimit the expression with two dollar symbols $$.

Can you let me know if the markdown file in my fork is rendering as you expected? If so, I'll confirm what we can change in the docs to help other folks.

@stevecat Yes, hacking another newline between expressions fixes it, but it definitely worked without it until something changed on your side. IMHO markdown features should work the same in the documents and also in the posts... and as you already found out, it does not.

Thanks @gashtaan, you're right, this is only affecting rendered markdown documents.
If this had always been the case, I'd be in favour of documenting this. As something has actually changed, I think it's worth escalating. I can't find any internal issues open about this so I'd suggest speaking to our support team so they can investigate, work with our engineering team, and look into fixing this.
I'll close this docs issue for now. If the end result of escalating to support is discovering that this can't be fixed, ping me here and I'll re-open the issue and find a way to document this for others ✨

We've also seen some regression regarding math expressions in markdown without us changing anything. In our case they are in Pull Request comments where we, creatively, use them to color text like this:
$\textsf{Plan:{\color{green} 1 to add}, 0 to change, 0 to destroy.}$
What I've noticed:

The font has changed
Sometimes whitespace and colors are missing on first render and needs a refresh of the site

Hey @gazab! That's a neat use of math expressions 😮
As there's been a change, and things aren't rendering on first load, I'd suggest speaking to support too. This sounds like something our engineering team might want to look at.

@stevecat What does this "speaking to support" mean? The only option I've found to speak seems to be creating a discussion and hope that somebody will care.

@nguyenalex836 Yes, I already did that a week ago. I created new discussion in community forum referenced from that page under topic "Repositories".
https://github.com/orgs/community/discussions/135637
It just seems weird to me that there is no github's way to report an issue (like here).

No response at all. Is there really no way how to report a bug?

@gashtaan Hi 👋 Like we mentioned previously, this link (https://support.github.com/request) that @guntrip previously provided is a link to our Support team, not to open a discussion. Just wanted to make sure there wasn't any confusion between the two 💛
After clicking the link to contact our Support team (https://support.github.com/request), you may a choose a topic and submit a support ticket for the related issue.

No, I don't see any option to create the ticket on provided link.
But I just noticed that according the documentation only paid accounts have option to create support ticket. I have only GitHub Free account, so all I can do is "discuss" about it and that option is useless :(
https://docs.github.com/en/support/contacting-github-support/creating-a-support-ticket
"If your account uses GitHub Free, you can speak to GitHub users and staff on the GitHub Community discussions for most issues, and you can contact GitHub Support to report account, security, and abuse issues."

@gashtaan Thank you for providing context regarding your account! Rest assured, given the circumstances, raising a discussion is the best course of action to surfacing your feedback 💛

I'll close this docs issue for now. If the end result of escalating to support is discovering that this can't be fixed, ping me here and I'll re-open the issue and find a way to document this for others ✨
It seems this bug will never be fixed, so I'm pinging you... I guess if it doesn't work correctly, it should be documented at least.

@guntrip Ping

@gashtaan Hello! 👋 We've inquired about this internally, and found that the responsible team is aware of this bug. They have opened an issue to investigate this bug further.
While we cannot provide information regarding timeline for next steps, the owning team is aware and will investigate this bug in the future 💛


Article Flow

I find articles like this very easy to get lost following, links to other articles when you are trying to follow and copy, mean I just get lost and totally confused. I prefer articles that I can just follow top to bottom, and have something that works when I have reached the bottom.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 369aefa6-74da-3001-f835-15abdfffd5d6
Version Independent ID: 2cc2a2db-d059-3252-7a1a-4261b7d3c37c
Content: Develop Azure Functions using Visual Studio
Content Source: articles/azure-functions/functions-develop-vs.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @GBPhilip Thank you for your valuable feedback! We have assigned this issue to the author to review and take the right course of action.

@GBPhilip did you happen to come across the Visual Studio quickstart article? I will add a link at the top to that article.


Species Talents do not stack correctly with purchased Talents

Example - Species Aleena gets 1 rank of Durable.
If you purchase durable from a specialisation (example - ace/gunner) then instead of showing 2 ranks in durable, it shows 3.
If you purchase the 2nd durable from that specialisation, it then jumps to 5 ranks:

Done, will be released in 1.901. Thanks for the report and images.

I forgot to write the migration from 1.900 to automatically fix this for existing actors, so I'm reopening the issue.

Okay, NOW it's done.


Synapse SQL Connectivity failing with below error ( MFA Authentication)

Description
Failed to load MSAL4J Java library for performing ActiveDirectoryInteractive authentication.
DBeaver Version
<IP_ADDRESS>303040621
Operating System
No response
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Please try to do this:
Go to "Edit Driver Settings," click the "Libraries" tab, then click "Add Artifact," then add the Maven dependency declaration:

<!-- https://mvnrepository.com/artifact/com.microsoft.azure/msal4j --> <dependency> <groupId>com.microsoft.azure</groupId> <artifactId>msal4j</artifactId> <version>1.11.3</version> </dependency>

https://github.com/dbeaver/dbeaver/issues/15446#issuecomment-1097140996

i did and i got something else now
Login failed for user ''. ClientConnectionId:c8830a53-8d24-405a-b39a-813927bcb290

Reference to database and/or server name in 'synapsedb.sys.schemas' is not supported in this version of SQL Server.

This is a knowing issue. Described here: https://github.com/dbeaver/dbeaver/issues/5258
Azure does not support cross-database queries, and for this reason, our advice is - to use separate connections for the separate databases.
https://github.com/dbeaver/dbeaver/issues/5258#issuecomment-1205089619


revert newtype

Initial go at reverting the new type.  Still familiarizing myself with the lifecycle of a contract, but I'm going to attempt to point wasmatic at this to fix the main branch.  I was pretty aggressive in reverting as I just wanted to get something to point to quickly, and had a meeting about the plan for comprehensive docs on the vercel app at the same time.  Can reduce the number of changes if we're opinionated about using the newtype where we can, or finding a way around reverting, but again, just wanted to fix main branch of wasmatic for the time being so it's stable to write docs against.

Pointed wasmatic at this and it works.  I think there is probably a longer conversation here to be had about how to make contracts more dynamic.  Would be great if we could didn't need to update code in wasmatic when contracts change.  I'm probably missing some context too, but seems like a good thing to think about.

Added more details on Slack, but commenting here just in case this is the "first stop" - it turns out the issue is not with the newtype but rather with a mismatch between types in layer-contracts and this repo.
Deploying contracts from this repo works perfectly (i.e. wasmatic is able to parse the query response with the newtype just fine)


added endpoint_type; renamed blaze_url to endpoint_url

IIRC, there were some changes on the cross-platform CI/CD runner pipeline that should be integrated. @Threated will know more :)

This was fixed in #37. Merging the changes from there will fix the CI


syncthing: create default group if not overridden

Motivation for this change
The following configuration generates a systemd unit that doesn't start.
{
  services.syncthing = {
    enable = true;
    user = "my-user";
  };
}

It fails with
systemd[1]: Started Syncthing service.
systemd[6745]: syncthing.service: Failed to determine group credentials: No such process
systemd[6745]: syncthing.service: Failed at step GROUP spawning /nix/store/n1ydz3i08nqp1ajc50ycy1zribmphqc9-syncthing-1.1.4-bin/bin/syncthing: No such process
systemd[1]: syncthing.service: Main process exited, code=exited, status=216/GROUP
systemd[1]: syncthing.service: Failed with result 'exit-code'.

This is due to the fact that syncthing group (default) is not created if the user is overridden.
Add a separate check for setting up the default group, so that user/group are created independently.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This became an issue after https://github.com/NixOS/nixpkgs/pull/65078
/cc @peterhoeg @aanderse

@rasendubi I'm not entirely convinced the solution you have proposed is the correct one. I think the real problem here is that you didn't specify a group. A better solution might entail warning the sysadmin they specified a user but not a group... but I'll need to think about this some more. I'm guessing @peterhoeg will have some valuable feedback.

Sorry about being late to the game, but is this really a supported workflow? The current syncthing module (and most other modules) are actually system-level modules where the user variable is used to set the system-level user that something runs as, which is not a regular interactive user.

@peterhoeg yeah I get what you're saying and I think that's a high level conversation that needs to happen so we can establish written guidelines and stop using regular desktop users with system level modules... but this PR fixed an existing logic bug so it made sense to me that it was merged.
Is that a reasonable answer?

Is that a reasonable answer?

Absolutely.

My use case is the following:
I use syncthing to sync a bunch of directories from my home directory (most notably, org-mode files). I need these to be owned by my user.
I think of user option in a similar way as of services.locate.localuser (which is used to set a user to search local directories as). I understand they are very different from the implementation point of view, but from the usage perspective they are not.

I understand your use case - but that still isn't how a system-level module is supposed to be used. The "proper" way would be using something like home-manager to configure it for your user only.
There is of course no harm doing what you do if you're the only person using that machine.


[DO NOT MERGE] test to show deserialization failure of ConvertSegmentTask

relates to  #1355
https://github.com/druid-io/druid/pull/1355#issuecomment-101098184
showing you can't have two different names for the same class in json subtype.

@himanshug @drcrallen one way to handle aliases would be to create a jackson mixin with the old name for the class in question. It would not convert from the old name to the new name on serialization, but I think that's acceptable.

https://github.com/himanshug/druid/commit/bf5c784c45749b5d7a06150169eb558750cd2184 is one way of setting up alias that is working fine. how does that look?

@xvrl @drcrallen closing this PR , it was just to show the issue.


Profile - Waiting results

We should check designs and actual statement this.
If the page run properly, this issue move to test and done.
Zeplin

I think it's comleted


Introduce Glide for vendor package management

The purpose for doing this is to:

remove a fairly large number of unimported packages in vendor/

$ git status | grep "new file" | wc -l
     631
$ git status | grep "modified" | wc -l
     543
$ git status | grep "deleted:" | wc -l
    3583

provide developers a unified way to update packages
(3) update vendor with latest packages

I've chosen glide over trash, godep, govendor, etc., because glide seemed well-maintained, used in other coreos products like clair and etcd, prune enough files(e.g. glide only vendors packages imported from non-test go sources, but not too aggressive according to the fast it doesn't flatten nested vendor/ directories or remove *_test.go)

build passed as can be seen in https://travis-ci.org/mumoshu/kube-aws/builds/169145557


Logging for Distributed Computing

We need to investigate whether we should

Modify our logging for distributed computing
Adapt pytorch-lightning logger module.

This can be done via W&B

https://pytorch-lightning.readthedocs.io/en/stable/api/pytorch_lightning.loggers.wandb.html
https://wandb.ai/site/articles/pytorch-lightning-with-weights-biases


feat: add Upstash Vector Store

This PR adds Upstash Vector as a storage
Previously, it was opened as https://github.com/run-llama/LlamaIndexTS/pull/1151 but that PR was closed.
I handled the pending reviews in the previous PR.

Hi @himself65,
Can we go ahead with this PR?


removed a sentence break and connected

Pull Request Test Coverage Report for Build 346

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.867%

Totals

Change from base Build 342:
0.0%

Covered Lines:
1497

Relevant Lines:
1578

💛  - Coveralls


updateQueries when deleting, how?

Hello!
If have trouble finding documentation on this. On a Posts collection, i can easily make a addPost mutation, return the newly created post and have the updateQueries reflect the changes to the store.
But what if i have a mutation that is deletePost. I will not get anything useful back from graphqlserver since the item is removed. How do i make so the store updates that the entry is deleted and that the ui is in sync?

You can use the ID of the deleted item when updating the queries.

Just loop through the array and delete the one and return the new array? Is it that simple? :)

Yep!

Ok thanks alot for the help and your awesome work with apollo!  :)

If you have a moment to sent a PR to the docs that would be much appreciated!


Async compressions don't work

Version of Waterdog

Latest
Expected Behavior

Asny compressions should go without problems
Actual Behavior

If Async Compressions are enabled, not all chunks load.
Crashdump, Backtrace or Other Files

Describe the bug

If Async compressions are enabled, the chunks will not load.
To Reproduce

Enable Asnyc compression in your pocketmine.yml or nukkit.yml
Screenshots

Server software used:

Nukkit
Additional context

Have you verified that this is not a Downstream ( Pocketmine / Nukkit ) Issue?

Nope, Waterdog. @Alemiz112 know about that issue too.

I use async compressions and it works completely fine

It appears only with Nukkit. I currently do not know what it causes. But I can confirm it.


Fixes issues with building the sample project and with the readme.

JTSImageViewControllerBackgroundStyle_ScaledDimmedBlurred and JTSImageViewControllerBackgroundStyle_ScaledDimmed do not exist. Replaced with JTSImageViewControllerBackgroundOption_Scaled

Thanks.

No problem. You might also be interested in this that I whipped up this morning - https://github.com/OTGApps/motion-imager


Sync handler

Description
Changes proposed in this pull request.
Test plan
Outline the test plan used to test this change before merging it.

Fixes #.

Codecov Report

Merging #417 into master will increase coverage by 1.55%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   56.35%   57.91%   +1.55%
==========================================
  Files          45       45
  Lines        6106     5638     -468
==========================================
- Hits         3441     3265     -176
+ Misses       2356     2071     -285
+ Partials      309      302       -7

Impacted Files
Coverage Δ

enforcer/datapath/datapath_tcp.go
54.27% <ø> (ø)
:arrow_up:

cgnetcls/cgnetcls.go
16.4% <ø> (ø)

policy/types.go
24.19% <ø> (ø)
:arrow_up:

supervisor/iptablesctrl/acls.go
52.8% <ø> (ø)
:arrow_up:

cgnetcls/netcls.go
0% <0%> (ø)

monitor/instance/docker/extractor.go
27.27% <100%> (ø)

internal/contextstore/contextstore.go
66.66% <100%> (+2.38%)
:arrow_up:

monitor/instance/linux/monitor.go
45.61% <45.61%> (ø)

monitor/instance/linux/processor.go
47.9% <47.9%> (ø)

monitor/instance/docker/monitor.go
55.23% <61.84%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5503337...73abc12. Read the comment docs.


Terminal flowControl setting default should check for the existence of ~/.oh-my-zsh

This would handle the main edge case better, right now flow control is disabled completely by default on all zsh shells.
Context: https://github.com/Microsoft/vscode/issues/18833

Closing in favor of https://github.com/Microsoft/vscode/issues/20132


Website to increase typing speed

Summary of your changes
Added website to Increase your typing speed while racing
Description

Checklist

[x] My change follows the Contributing Guidelines
[ ] I have added only one new link to the list.
[x] I have checked that the link that I added does NOT exist in the project already.
[x] I have sorted the link alphabetically under the related section.

@sdmg15 can u please review


HDF corrupts data when using complib='blosc:zlib'

I'm not sure if this is supported or not -- it isn't in the doc string for HDFStore, but it seems to be allowed by the HDFStore (nothing is raised).
Unfortunately so far I can only get it to show the bad behavior on a proprietary dataset, which is storing a pd.Panel which contains items of of mixed types.
Some of the float values are be changed from small (|x|<1.0) to very large (3.xe+308).
Is the compressor just passed through to pytables?


Cleanup script

The boilerplate comes with a small example app in it. Ideally, we could have a script that removes the example app and leaves only the structure and the patterns in a clean state to develop a new app. The v2 of this boilerplate had something similar to that https://github.com/talyssonoc/node-api-boilerplate/blob/v2.1/package.json#L23.

Hey, can I take this issue? I would like to do it.

Go for it!


Poloniex error 422: Nonce must be greater than .....

Today I started to get the error:
Poloniex error 422: Nonce must be greater than *****. You provided *****.
(I have hidden the actual nonce values for security reasons). I also started to frequently get the error:
Poloniex error 429: Please do not make more than 8 API calls per second.
With poloLender 0.7.1, I usually only get error 429 about every 90 minutes or less, which doesn't seem to be problematic. But for some reason I got error 429 multiple times today within a couple of seconds. Sorry if I should have kept error 429 as a separate issue but I don't know if it's related. I also received this error message:
Poloniex error 429: This IP has been temporarily throttled. Please ensure your requests are valid and try again.
I've attached a small portion of the log in an excel file. I assume this may be an issue with poloniex server but perhaps there is a way poloLender can handle these situations?
Kind regards,
log3.xlsx

Please generate and use a new API key

Thanks, I'm now using a fresh API key. It's been an hour and no error messages so far. I'll report back in a few days.
Kind regards,

Hello,
I haven't received the error since using a new API key. It seems to have solved the problem.

İ couuldnt it. Similar error but again same error after new created API

@tayareci sometimes the statusCode 422 can happen for other reasons as well, check the object returned by Poloniex API in order to see what is happening, sometimes it's just an invalid parameter you are sending

I have: "Poloniex error 422: . Nonce must be greater than<PHONE_NUMBER>160165. You provided<PHONE_NUMBER>02400."
1573038171160165 - is 16 digits
157719741402400 - is 15 digits
What this????


Fix typo in quickstart install doc

Signed-off-by: Lucas Ramage<EMAIL_ADDRESS>

@mudler can you label this with hacktoberfest-accepted?

sure thing!


[IOS] - Clear Cookies

Hi,
I've a problem with method "clearCookies" on iOS if executed from the second time.
I've this error:
Error: *** __boundsFail: index 3 beyond bounds [0 .. 1]
I had to use a try/catch to intercept the error.
Do you know how to fix?
Thanks

Hi! Are you possibly executing clearCookies 2 times at the same time? It might be some race condition, I will test this today!

No, I've seen that deleteCookie remove from array so count is different on every delete.
This should be ok:
export function clearCookies() {
    if (sessionConfig.HTTPCookieStorage && sessionConfig.HTTPCookieStorage.cookies) {
        const cookieSize = sessionConfig.HTTPCookieStorage.cookies.count;
        if (cookieSize <= 0) {
            return;
        }

        for (let i = cookieSize - 1; i >= 0; i--) {
            const cookie = sessionConfig.HTTPCookieStorage.cookies.objectAtIndex(i);
            sessionConfig.HTTPCookieStorage.deleteCookie(cookie);
        }

    }
}

Ah yeah, that makes sense! I will create a new release soon, thanks!

I hope you'll create a new version soon.
Thanks very much for everything!

If you want I can make a pull request. Let me know.

@mapo80 I just pushed 1.3.1 to npm!


Improve the github CI workflow to give clearer information

Now there is only one build. We can't see the which stage of the building fails, such as code styling or blackbox tests. This is uninformative.
Can we split the workflow to multiple builds that allows clearer message in github email and also PR webpage?

Just like this.

Just like this.

Can we create work flow for each job?

Can we create work flow for each job?

Closed by #228

Closed by #228


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
System.InvalidOperationException: 'ContentControl' TargetType does not match type of element 'DataGridColumnFloatingHeader'.

Duplicate of #1231


add REVA_LDAP_IDP to docker compose

Following https://github.com/owncloud/ocis/pull/465

three test failures, probably unrelated or random ? :frowning:
@individual-it

seem to be random, passed now


False no space left on device error

I have plenty of space on hard drive but keybase reports:
ERROR Cannot commit Merkle root to local DB: write /home/jascha/.local/share/keybase/keybase.leveldb/000430.log: no space left on device

Are you sure?  What does df show?

$df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            5.9G  4.0K  5.9G   1% /dev
tmpfs           1.2G  3.5M  1.2G   1% /run
/dev/sda4        92G   28G   60G  32% /
none            4.0K     0  4.0K   0% /sys/fs/cgroup
none            5.0M     0  5.0M   0% /run/lock
none            5.9G  309M  5.6G   6% /run/shm
none            100M   28K  100M   1% /run/user
/dev/sdc1       2.7T  713G  1.9T  28% /mnt/sdc1
/dev/sda5        89G   74G   11G  88% /home
/dev/sda1       197M   23M  175M  12% /boot/efi
I had to kill keybase and restart for it for it to work once again.

just had the same problem
▶ ERROR Cannot commit Merkle root to local DB: write /home/simon/.local/share/keybase/keybase.leveldb/003453.log: no space left on device
/dev/mapper/main-root         205G  193G  1,5G 100% /
keybase version 1.0.37-20171208170249+025062c3a (arch linux)
killing and restartin keybase worked for me, thx

Saw this today. df looks normal, plenty of space on my drive.
ERROR Cannot commit Merkle root to local DB: write /home/ubuntu/.local/share/keybase/keybase.leveldb/000008.log: no space left on device ▶ WARNING Error in writing UPAK for 10af161581627b002ff34b4d3ef7d619: write /home/ubuntu/.local/share/keybase/keybase.leveldb/000008.log: no space left on device [tags:SELF=kv5V8d-Ma8Ea]

Hm, how about df -i?

Most usage I see on anything is 11% which is on /. There's plenty of space on my drive.

Same here and it is frustrating... cannot chat, post, receive information or even change a password or install a second device. I have 160GB left and should be moooooooore than enough


maintain orientation flag

Please provide a flag to preserve image orientation exif data. I am unable to use portrait orientation photos in a site I am working on after they were reduced using guetzli.

@JonCaris - You may find ExifTool helpful for now. It will only write the Exif:Orientation metadata and would not re-encode the image.

Thanks! I have been experimenting with ExifTool, it seems that even setting
the orientation flag does not cause my images to display properly as
background images. Do you know of another flag I can set in those images?
On Fri, Apr 21, 2017, 2:27 AM Saurabh Khanduja<EMAIL_ADDRESS>wrote:

@JonCaris https://github.com/JonCaris - You may find ExifTool helpful
for now. It will only write the Exif:Orientation metadata and would not
re-encode the image.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/guetzli/issues/192#issuecomment-296106742, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADQeYmdIanJutWeXbX1qwAKvmcOG6dekks5ryFpGgaJpZM4ND2s-
.

Could you upload a piece of project on how to reproduce issue at my end? Note css orientation metadata is not respected in chrome.

I’m using grunt guetzli and minimizing with a quality value of the minimum 84.
I have an AngularJS application which sets the bound image url as the background image of an item in a gallery:

I found it odd that "portrait oriented" images were interpreted by the browser as "landscape" until I browsed them in my file system post guetzli and noticed it interpreted them the same way. Opening them in bridge and changing the orientation made them display correctly everywhere but the browser. Upon attempting to update the orientation with ExifTool, I found that the metadata had been set when rotating them with bridge, but the browser still interprets them as landscape. I didn't think the browser used that information anyway, so how DOES the browser interpret orientation? The images have the correct height and width upon inspection, with the height being greater than the width.

@JonCaris - Hi, I don't think I understood fully what you mean. I think you meant to say that only browser is ignoring the orientation metadata. If that's what you meant, you can try auto-orienting the image before running guetzli on it. You can try imagemagick for that:-
convert -synchronize <inputfilepath> -auto-orient <outputfilepath>
Note that decoding the image and re-encoding causes small loss in quality(Not significant unless you do this like a hundred times) - Generation Loss.

@saurabheights Thanks again for taking the time. Yes, that is correct, the browser seems to ignore the orientation. Would running auto-orient on it before guetzli help? Wouldn't guetzli just remove the metadata that is added? The images were taken on an iPhone which I understand can make a difference as to how the metadata is written.

Maybe rotate with jpegtran, which is supposed to be lossless?: https://en.wikipedia.org/wiki/Libjpeg#jpegtran
This is available from these projects: libjpeg, mozjpeg, and maybe also libjpeg-turbo.


How to exec on pod

It would be a nice example how to exec on a existing pod and run a curl from within it
Something like the following command :
kubectl exec -n nice_namespace nice_pod-8447f7cc77-jxz7d  -it -- /bin/bash

Yeah, it's been on my list for a while :) I should definitely come up with a minimal possible example of kubect exec-like functionality. Meanwhile, you can check this piece of code - it's doing pretty much that https://github.com/iximiuz/cdebug/blob/main/cmd/exec/exec_kubernetes.go.


Typo

[Enter feedback here]
Typo Here: Ability to build Teams personsal apps usings Adaptive cards
Assuming should say personal

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1d50c2e0-d6d3-ec3f-5e99-acaa2a6868d5
Version Independent ID: 1d50c2e0-d6d3-ec3f-5e99-acaa2a6868d5
Content: The new Microsoft Teams desktop client - Microsoft Teams
Content Source: Teams/new-teams-desktop-admin.md
Service: msteams
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Thank you!
Fixed in https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/commit/3bab2cfec45ccc09b40bf40976a229e06da441e8


WIP DO NOT MERGE

Closing as it does not seem possible to partially link object files for a module or in-tree sources.


Improve error message for unwrapped Collections

Currently the error message for a Class having a collection as a field which is initialized in constructor is: "Attempts to wrap mutable collection type using a non-whitelisted unmodifiable wrapper method". This is misleading, since in this case nothing is getting wrapped at all.
The goal of this issue is to improve this error message to something like "Not wrapped collection type". This mutability reason is detected by MutableTypeToFieldChecker.
Here a test which asserts the current error message
   public final static class ClassNotWrappingCollection {
        private final Collection<String> collection;

        public ClassNotWrappingCollection(Collection<String> collection) {
            this.collection = collection;
        }
    }

    @Test
    public void isImmutableMutableTypeToField_ClassNotWrappingCollection() throws Exception {
        try {
            assertImmutable(ClassNotWrappingCollection.class);
            fail("Error should be thrown");
        } catch (MutabilityAssertionError e) {
            assertThat(e.getMessage(), is("\n"+
                    "Expected: org.mutabilitydetector.ErrorLocationTest$ClassNotWrappingCollection to be IMMUTABLE\n" +
                    "     but: org.mutabilitydetector.ErrorLocationTest$ClassNotWrappingCollection is actually NOT_IMMUTABLE\n" +
                    "    Reasons:\n" +
                    "        Attempts to wrap mutable collection type using a non-whitelisted unmodifiable wrapper method. [Field: collection, Class: org.mutabilitydetector.ErrorLocationTest$ClassNotWrappingCollection]\n" +
                    "    Allowed reasons:\n" +
                    "        None."));
        }
    }

Now not so misleading, thanks @kwahsog!


Dependency pygtk is unmantained

Hi,
Forwarding a Debian bug report:

pygtk is unmaintained upstream. It has not had a release since GNOME 3
was released in 2011.
The way forward is to port your app to use GObject Introspection
bindings (and gtk3).
For more information on GObject Introspection see [1] and [2].
Please try to do this before the Buster release as we're going to
try to remove pygtk this cycle.
If you have any question don't hesitate to ask.
[1] https://wiki.gnome.org/Projects/GObjectIntrospection
[2] https://wiki.gnome.org/Projects/PyGObject
On behalf of the Debian GNOME team,
Jeremy Bicha

Thanks for your work,
cheers,
Georg

Good to know. I'm planning on switching from pygtk to PyQt5 (#321).


Multi-user support

It would be really nice if keybase apps allowed easy and effortless user switching.

@Avamander Sorry I don't see use in it what is the scenario?
Keep in mind that main keybase use is identity verification so you should have one account.

@5h4d0ww0lf Why should one be limited to only one identity?

Plus should I add that everyone as multiple faces.
You can be a genius in astrophysics and want to be contacted privately through your specific pgp key to that effect or exchange files privately from that field of expertise.
And at the same time you could be a recovered addicted or having an uncurable sickness but you want to share thought, speak groups about it, having a mastodon instance talking about it etc and don't want other people to know it about.
So yes everyone is entitled to have multiples identities to actually channel informations according to specific criteria. So a multi-user support for the mobile, desktop and the web version is essential!

I think this is a duplicate of #8586

Closing as a duplicate of #8586


remove keyvault read requirement

fixes https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues/13
TODO: Once the PR is merged and a new release is made with the change included, docs and examples need to be updated.
🏆 Shoutout to @timja for the original PR: https://github.com/Azure/kubernetes-keyvault-flexvol/pull/128

(nice work github, button was broken but it kept adding comments, apparently I can't delete them here, feel free to cleanup 😄 )

@timja docs and deployment updates will come after we cut a new release, new image tag.

Good to see this project moving forward,
I saw a roadmap item somewhere that you're looking at deprecating flexvolume, I assume this is part of that work, getting it ready for that 👍

@ritazh Added the unit tests and moved the files into diff packages, PTAL!


soundd/micd: retry getting stream

this seems like the best solution to capture and recover from the random alsa errors
ran 150 times across release (skip build, faster launch) and dev devices, and checked that it recovers from these errors:
/home/batman/soundd/tmux-justin-tici2-2023-12-12--13:05:42.txt

sounddevice.PortAudioError: Error opening InputStream: Illegal combination of I/
O devices [PaErrorCode -9993]

--------------------------------------------------------------------------------------------

/home/batman/soundd/tmux-justin-tizi2-2023-12-12--12:57:31.txt

sounddevice.PortAudioError: Error opening InputStream: Unanticipated host error
[PaErrorCode -9999]: 'Invalid argument' [ALSA error -22]

--------------------------------------------------------------------------------------------

/home/batman/soundd/tmux-justin-tizi2-2023-12-12--12:57:31.txt

sounddevice.PortAudioError: Error opening InputStream: Unanticipated host error
[PaErrorCode -9999]: 'Operation already in progress' [ALSA error -114]

--------------------------------------------------------------------------------------------

/home/batman/soundd/tmux-justin-tizi-2023-12-12--11:59:08.txt

sounddevice.PortAudioError: Error opening InputStream: Illegal combination of I/
O devices [PaErrorCode -9993]

these errors seem to happen about 1/40 restarts

Does this fix all crashing?

Does this fix all crashing?

going to leave this running for a few hours, but it has caught and recovered all the errors that we've seen so far


Small last minute improvements for the demo

it mostly concerns the refinement at the end of the off-line camera tracking. The pose and the intrinsics, if refined, are now directly updated inside the LocalizationResult structure.
It also include some cleaning and documentation here and there.
Now it also contains PR poparteu/openMVG#95

merged in popart_develop

@fabiencastan why?

@fabiencastan Ah ok it has been merged in popart_develop... I guess we can delete the branch then?


can't install golang.org/x/tools/gopls@latest

What version of Go are you using (go version)?

$ go version
go version go1.12.6 darwin/amd64

Does this issue reproduce with the latest release?
Yes. (I need clarity on the question, latest release of what?)
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
Setting GO111MODULE to on
Using go version go1.12.6 darwin/amd64...
Running command "go env"...
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/shivatejeshrachamadugu/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/shivatejeshrachamadugu/go-code"
GOPROXY=""
GORACE=""
GOROOT="/private/var/tmp/_bazel_shivatejeshrachamadugu/2c13d2577b0574449ad6dc3a0a75269b/external/go_sdk"
GOTMPDIR=""
GOTOOLDIR="/private/var/tmp/_bazel_shivatejeshrachamadugu/2c13d2577b0574449ad6dc3a0a75269b/external/go_sdk/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/shivatejeshrachamadugu/go-code/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jj/k1xw77pd6knd3tyw2qgpwdjh0000gn/T/go-build648584742=/tmp/go-build -gno-record-gcc-switches -fno-common"
Skipping gazelle run due to no changes to go.mod or go.sum

What did you do?
go get golang.org/x/tools/gopls@latest
What did you expect to see?
Get gopls installed
What did you see instead?
shivatejeshrachamadugu-C02X74ABJGH6:go-code shivatejeshrachamadugu$ go get golang.org/x/tools/gopls@latest
Setting GO111MODULE to on
Using go version go1.12.6 darwin/amd64...
Running command "go get<EMAIL_ADDRESS>golang.org/x/tools/gopls
../../pkg/mod/golang.org/x/tools/gopls@v0.1.3/main.go:20:41: not enough arguments in call to cmd.New
have (string, nil)
want (string, string, []string)
I have followed the steps over here https://github.com/golang/go/issues/33464, but didn't succeed.

Oh, dear. gopls/main.go is importing an internal package from another module.
That's only ok if the internal package has a stable API: otherwise, a user's go.mod file might upgrade the internal package to a version newer than what gopls expects, as seems to have happened here.
@shivatejesh, as a workaround you can either downgrade the golang.org/x/tools module to v0.0.0-20190710153321-831012c29e42, or you can upgrade golang.org/x/tools/gopls to commit 625c92e46d0e or newer.
CC @ianthehat @hyangah @stamblerre

We don't support building gopls with any version of x/tools (or any other module we depend on) other than the versions we specify in the go.mod
On the install instructions we say

If you do want to get the latest stable version of gopls, change to any directory that is not in either your GOPATH or a module (a temp directory is fine), and use
go get golang.org/x/tools/gopls@latest

specifically to avoid triggering this case.

I did followed your instructions and changed go.mod file got changed like this
	golang.org/x/tools v0.0.0-20190710153321-831012c29e42
	golang.org/x/tools/gopls v0.1.3 // indirect

and in terminal when I get for gopls version
shivatejeshrachamadugu-C02X74ABJGH6:go-code shivatejeshrachamadugu$ gopls version
golang.org/x/tools/gopls v0.1.2
<EMAIL_ADDRESS>h1:CB5ECiPysqZrwxcyRjN+exyZpY0gODTZvNiqQi3lpeo=

I do not understand why 0.1.2 is being installed. And no autocomplete and no other features are working in visual studio code. Set of instructions for a function are like this.

And the settings.json in visual code are
settings.json Output
$ settings.json
{
    "go.gopath": "/Users/shivatejeshrachamadugu/go-code",
    "go.coverOnSingleTest": true,
    "debug.showSubSessionsInToolBar": true,
    "go.languageServerExperimentalFeatures": {
        "diagnostics": true, // for diagnostics as you type
        "format": true,
        "autoComplete": true,
        "rename": true,
        "goToDefinition": true,
        "hover": true,
        "signatureHelp": true,
        "goToTypeDefinition": true,
        "goToImplementation": true,
        "documentSymbols": true,
        "workspaceSymbols": true,
        "findReferences": true,
        "documentLink": true,
        "incrementalSync": true,
    },
    "go.toolsEnvVars": {
        "GO111MODULE": "on"
    },
    "gopls": {
        "usePlaceholders": true,
        "enhancedHover": true,
    },
    "[go]": {
        "editor.snippetSuggestions": "none",
        "editor.formatOnSave": false,
        "editor.codeActionsOnSave": {
            "source.organizeImports": false
        }
    },
    "go.languageServerFlags": [
        "-rpc.trace",
        "serve",
    ],
    "go.autocompleteUnimportedPackages": false,
    "go.formatTool": "gofmt",
    "go.useLanguageServer": true,
    "go.alternateTools": {
        "go-langserver": "gopls",
      },
    "go.inferGopath": false,
    "go.gocodePackageLookupMode": "bzl",
    "workbench.editor.enablePreview": false,
    "workbench.editor.enablePreviewFromQuickOpen": false,
    "go.buildOnSave": "package",
    "go.lintOnSave": "off",
    "go.vetOnSave": "off",
    "workbench.colorTheme": "Visual Studio Dark",
    "editor.fontSize": 11,
    "terminal.integrated.fontSize": 11,
    "editor.wordWrap": "on",
    "go.toolsGopath": "~/go-code/bin"
}

@ianthehat, if the assumption is that golang.org/x/tools and golang.org/x/tools/gopls are upgraded in lock-step, then versions of golang.org/x/tools that make breaking changes in dependencies used by […]/gopls should explicitly require a version of […]/gopls that is compatible with the new API.
That would avoid this sort of skew regardless of which main module gopls is built from.

No, the whole point of having a separate gopls module is to allow it to have dependencies that x/tools does not.

@shivatejesh dont worry about the 1.2 thing, that is a hard coded string from a mis-configured release, and not really a problem.
Did you restart VSCode after installing?
Did you get a gopls log in your output window?

I did a restart, by using Cmd+Q and then started visual code.
There is no log of gopls. Here is the screenshot of output window.

My vscode version:
Version: 1.37.1
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

@shivatejesh: Looks like gopls is not running at all. Do you definitely have it on your $PATH or $GOPATH? Can you run gopls -rpc.trace -v check path/to/file.go from the command line?

We don't support building gopls with any version of x/tools (or any other module we depend on) other than the versions we specify in the go.mod
On the install instructions we say

If you do want to get the latest stable version of gopls, change to any directory that is not in either your GOPATH or a module (a temp directory is fine), and use
go get golang.org/x/tools/gopls@latest

specifically to avoid triggering this case.

This works for me!

how to check gopls done installed?

@rifaimartin check your PATH and see if one of the listed directories in the PATH contains gopls binary.


Combine GPU multiprocess tests

Single file multiprocess_gpu_test.py for all gpu distributed tests.
Use pytest --forked ... to launch each test in a separate subprocess
to workaround conflicting multiple jax.distributed.init within a single
file/process.

@yashk2810 curious if there's anything I could do on my side to help?

Looks like the CPU tests are failing. It says that it can't find the target. You need to change this too: https://github.com/google/jax/blob/main/tests/BUILD#L102
I couldn't pull it in because of failing tests.

Ah right, makes sense. Let me fix that

It looks like there's a merge conflict too. Should I rebase and raise another PR?

Trying again in https://github.com/google/jax/pull/12113

Just FYI: You don't have to create a new PR whenever there is a merge conflict. You can just rebase this PR on top of main.

Thanks! I'll keep that in mind the next time


osdsctl issue

Is this a BUG REPORT or FEATURE REQUEST?:
root@SDS:~/opensds-installer/ansible# osdsctl pool list
ERROR: parse http://{<IP_ADDRESS>}:50040/v1beta/2555954dc87746fbbfe9674ba9da5769/pools?offset=0&sortKey=id&limit=50&sortDir=desc: invalid character "{" in host name
root@SDS:~/opensds-installer/ansible#

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Hotpot(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Hi @bfliujinlong , it seems that there is something wrong with host_ip configuration, can you show how you configure it? Thanks!

@bfliujinlong I'll close this issue, please be free to reopen it.


remove elasticloadbalancingv2 LoadBalancer Validation

This change removes the validation step from the LoadBalancer class to allow for conditionally setting one of these properties, while setting the other to AWS_NO_VALUE
Fixes cloudtools/troposphere#933

PR now change as follows:
elasticloadbalancingv2 LoadBalancer validation now checks if all mutually exclusive conditions are instances of the If class, and if so returns.  Then proceeds to verifying only a single property is configured.

Thanks for the fix and reworking the PR.


Support HTTP request cycle Evidence (HAR viewer)

This PR adds  the abiilty for users to upload and view HAR files (other  formats can be supported via transformation  processes in the backend).
Changes:

Minor backend changes to add a new content type
New frontend component to render a series of http request/responses (similar to what you would get inside chrome or firefox)
Added the ability for tables to have selected rows (via implementing a onKeyDown  function and providing a ref for the table)

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

In general, it looks like this design is going to require approximately 950ish pixels for the page content in order to look okay. The easiest change to expand this limit is going to be to change the maximum height for the table, and adjust it downward to only 4 rows (including the header) are shown at any one time -- that'll net about 40ish pixels.
We might also need to consider a different layout -- either completely different in how this is laid out, or some structural changes to make the component render better in the timeline view.

In general, it looks like this design is going to require approximately 950ish pixels for the page content in order to look okay. The easiest change to expand this limit is going to be to change the maximum height for the table, and adjust it downward to only 4 rows (including the header) are shown at any one time -- that'll net about 40ish pixels.
We might also need to consider a different layout -- either completely different in how this is laid out, or some structural changes to make the component render better in the timeline view.

@JoelAtDeluxe can you get this rebased? Where are we at in terms of re-design? Is this related to the min-width or min-height needed currently for this to work?

@JoelAtDeluxe can you get this rebased? Where are we at in terms of re-design? Is this related to the min-width or min-height needed currently for this to work?

I'll rebase this tomorrow. Currently, the design "wants" about 950 pixels, but it can grow a bit. If you've got a 4k screen, it might not look great.
However, I don't think I ever looked at the add evidence view (from within a finding). This view is very small, and so this design is probably going to be completely broken there. I'll need to think on that, in addition to just trying to make it scale with page height better. I'll look around a bit more to see how others implement this sort of thing.

I'll rebase this tomorrow. Currently, the design "wants" about 950 pixels, but it can grow a bit. If you've got a 4k screen, it might not look great.
However, I don't think I ever looked at the add evidence view (from within a finding). This view is very small, and so this design is probably going to be completely broken there. I'll need to think on that, in addition to just trying to make it scale with page height better. I'll look around a bit more to see how others implement this sort of thing.

Are we still waiting on anything here or are we good to go after we fix the conflict? I think we'll probably need to take another pass at some point at some of the and hotkeys but I think in general we probably need to do that for the whole app around hotkeys, modals, and some of the ui elements.

This is ready, it just needs to be rebased.

Sorry, I didn't know this got stuck with a conflict. I can resolve that momentarily


Editor is deadlocked if I click on resource tab

STR:

Have scene with unsaved changes
Double click on another scene in Resource Tab
When prompt is active, double click on another scene again

@rokups

Make sure dialog asking to save scene does not spawn behind editor window.

@rokups I just checked. It is behind, in worst possible way:

I literally had to minimize all other windows to see it, it's hidden otherwise.


XCode 11.4 - ITMSTransporter Fail to upload

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Let me start off with saying the build server has not been updated in a year or so and finally we're forced to which kicked off all the updates. The big changes was updating the OS to Catalina otherwise xcode 11 wouldn't be installed. Unfortunately it appeared XCode 11 does not come with ITMSTransporter. I found the official standalone package from apple and installed that which is now getting me the following errors.
At the last step once everything has finished and fastlane attempts to upload the binary  the following output is what I get. Is there way to get verbose logs on that specific step to see exactly what arguments are executed?
[✔] Uploading metadata to App Store Connect
[13:33:24]: Successfully uploaded set of metadata to App Store Connect
[13:33:25]: Starting with the upload of screenshots...
[✔] Activating language en-US...
[13:33:27]: Uploading 4 screenshots for language en-US
[13:33:27]: Uploading './fastlane/screenshots/en-US/iPhone 8 Plus - home.png'...
[13:33:29]: Uploading './fastlane/screenshots/en-US/iPhone 8 Plus - rewards.png'...
[13:33:31]: Uploading './fastlane/screenshots/en-US/iPhone XS Max - home.png'...
[13:33:39]: Uploading './fastlane/screenshots/en-US/iPhone XS Max - rewards.png'...
[✔] Saving changes
[13:33:42]: Successfully uploaded screenshots to App Store Connect
[13:33:42]: Price Tier unchanged (tier 0)
[13:33:43]: Uploading app icon...
[13:33:45]: Uploading binary to App Store Connect
[13:33:45]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[13:33:45]: Going to upload updated app to App Store Connect
[13:33:45]: This might take a few minutes. Please don't interrupt the script.
[iTMSTransporter] -Djava.ext.dirs=/usr/local/itms/java/lib/ext is not supported.  Use -classpath instead.
[iTMSTransporter] Error: Could not create the Java Virtual Machine.
[iTMSTransporter] Error: A fatal exception has occurred. Program will exit.

Command executed

this happen during fastlane deliver
Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.4

Ruby
2.4.0

Bundler?
false

Git
git version 2.24.1 (Apple Git-126)

Installation Source
~/.rvm/gems/ruby-2.4.0/bin/fastlane

Host
Mac OS X 10.15.4 (19E266)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.4.0/lib

OpenSSL Version
OpenSSL 1.1.0f  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.4

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.144.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-cordova
2.2.1
✅ Up-To-Date

Loaded gems

Gem
Version

slack-notifier
2.3.2

atomos
0.1.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.15.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

colored
1.2

commander-fastlane
4.4.6

excon
0.73.0

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday
0.17.3

faraday_middleware
0.13.1

gh_inspector
1.1.3

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

bundler
2.1.4

jwt
2.1.0

uber
0.1.0

declarative-option
0.1.0

representable
3.0.4

mini_mime
1.0.2

signet
0.13.2

googleauth
0.11.0

httpclient
2.8.3

google-api-client
0.36.4

jmespath
1.4.0

aws-partitions
1.291.0

aws-eventstream
1.0.3

aws-sigv4
1.1.1

aws-sdk-core
3.92.0

aws-sdk-kms
1.30.0

aws-sdk-s3
1.61.1

CFPropertyList
3.0.2

claide
1.0.3

unicode-display_width
1.7.0

plist
3.5.0

addressable
2.7.0

tty-screen
0.7.1

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

highline
1.7.10

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

fastimage
2.1.7

json
2.3.0

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

naturally
2.2.0

simctl
1.6.8

declarative
0.0.10

retriable
3.1.2

multi_json
1.14.1

memoist
0.16.2

os
1.1.0

digest-crc
0.5.1

google-cloud-errors
1.0.0

google-cloud-env
1.3.1

google-cloud-core
1.5.0

google-cloud-storage
1.25.1

emoji_regex
1.0.1

openssl
2.0.2

io-console
0.4.6

psych
2.2.2

fastlane-plugin-cordova
2.2.1

generated on: 2020-03-31

After running with --verbose this is the executed call for ITMSTransport
/usr/local/itms/java/bin/java -Djava.ext.dirs=/usr/local/itms/java/lib/ext -XX:NewSize=2m -Xms32m -Xmx1024m -Xms1024m -Djava.awt.headless=true -Dsun.net.http.retryPost=false -jar /usr/local/itms/lib/itmstransporter-launcher.jar -m upload -u YourDeveloperEmail -p YourPassword -f /tmp/1505584335.itmsp -t DAV,Signiant -k 100000 -itc_provider LL29KA9PSV 2>&1

Other appear to have a similar issue it was a configuration issue on the computer itself https://github.com/fastlane/fastlane/issues/15323#issuecomment-557455805
I just renamed the /usr/local/itms to old.itms and it picked up the correct java version from xcode.


Fixes/data pipeline

cuts the unique center (less the 300px buffer) out of each NAIP
defaults to analyze 10 images and achieves 60% accuracy
separates render results into a file,
add Dropout back to the working analysis (which seems to help),
various cleanup of my old comments and such,
center tile analysis instead of just anywhere on tile analysis

lgtm, merge away! have some questions i'll ask you in slack


Add children into Modal to show custom elements

Hi, can you show the example to use children?

@emjeard you can see the issue I posted https://github.com/frontend-collective/react-image-lightbox/issues/146


[Bug] [Windows] Webview errors out on calling new Webview()

Took the example code
import { Webview } from "webview-bun";

const html = `

Hello from bun v${Bun.version} !

`;

const webview = new Webview();

webview.setHTML(html);
webview.run();

And it threw an error
PS C:\Users\euro\projects\crud> bun .
1 | MZ����@��   �!�L�!This
      ^
error: Expected ";" but found "�"
    at C:\Users\euro\projects\crud\node_modules\webview-bun\build\libwebview.dll:1:3

1 | MZ����@��   �!�L�!This p
       ^
error: Unexpected
    at C:\Users\euro\projects\crud\node_modules\webview-bun\build\libwebview.dll:1:4

Bun v1.1.38 (Windows x64)

Naturally I assumed the DLL was outdated, so I cloned this repo locally, and rebuilt the DLL, and installed the local project as a module, and no changes just different path name in the error.

Use the filename to execute instead of the dot.