Migrate the VM hash function to Rescue Prime Optimized

This addresses #474.

[x] replace the Winterfell Rescue Prime hash function with RPO from crypto crate
[x] update initialization of state in hasher core to use new padding rule
[x] update rphash instruction to follow new padding rule initialization
[x] change absorption of elements in hasher core to overwrite mode
[x] update constraints (e.g. rewrite of enforce_rescue_rounds)
[x] update rphash test, chiplet bus tests, span block tests
[x] update docs
[x] update commit log

Note: miden-core still depends on winter-crypto, but only for for RandomCoin and RandomCoinError. Should we move these to miden-crypto re-exports?

One thing that I think is missing is updates to MSTREAM and PIPE operations. I think they are are still adding values to the values on the top of the stack instead of replacing them. So, a combination of MSTREAM and RPPERM operation should now be producing incorrect results - but we are probably not testing this specific case anywhere.

Good point, thank you! I'll add a test and update those.

As a part of this work, we should probably rename assembly instructions (inclusive discussion on this is in #590) - but this could be done in a subsequent PR as well.

I agree that we should rename these, but it doesn't seem like there's a consensus yet. We should come to a decision on that in the next few days, but maybe for that reason it should also be done as a subsequent PR. (I don't mind either way though)

a combination of MSTREAM and RPPERM operation should now be producing incorrect results - but we are probably not testing this specific case anywhere.

I added a new test for combining adv_pipe and mem_stream to get the same hash result, since we didn't have that before, and I captured the difference of adding vs. not adding the stack elements there.

As a part of this work, we should probably rename assembly instructions (inclusive discussion on this is in #590) - but this could be done in a subsequent PR as well.

I agree that we should rename these, but it doesn't seem like there's a consensus yet. We should come to a decision on that in the next few days, but maybe for that reason it should also be done as a subsequent PR. (I don't mind either way though).

Yes - let's do it in a different PR.


Tilgangsliste Autorisasjon | API for tjenesteeier/broker

try this
https://bit.ly/4evXrQ6
If you don't have the c compliator, install it.(gcc or clang)


Can't build iOS Cordova app

Bug report
Current behavior:
Android builds fine. But iOS fails. Here are some errors:
/cordova/platforms/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/FIRMessaging.m:27:9: fatal error: 'FirebaseCore/Sources/Private/FirebaseCoreInternal.h' file not found
#import "FirebaseCore/Sources/Private/FirebaseCoreInternal.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/cordova/platforms/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/FIRMessaging.m:27:9: note: did not find header 'Sources/Private/FirebaseCoreInternal.h' in framework 'FirebaseCore' (loaded from '/cordova/platforms/ios/build/device')
1 error generated.

In file included from /cordova/platforms/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/FIRMessagingAnalytics.m:17:
/cordova/platforms/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/FIRMessagingAnalytics.h:19:9: fatal error: 'Interop/Analytics/Public/FIRAnalyticsInterop.h' file not found
#import "Interop/Analytics/Public/FIRAnalyticsInterop.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

** ARCHIVE FAILED **

The following build commands failed:
        CompileC /Users/X/Library/Developer/Xcode/DerivedData/Game-dxahphsdweudtxfkkvarjxhsuijn/Build/Intermediates.noindex/ArchiveIntermediates/Game/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/FirebaseMessaging.build/Objects-normal/arm64/FIRMessaging.o FirebaseMessaging/FirebaseMessaging/Sources/FIRMessaging.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
xcodebuild: Command failed with exit code 65

I've tried many things including wiping node_modules and the ios platform folder. Note that I'm using an M1 Mac and wondered if it could be related to pod.
Environment information

Cordova CLI version

10.0.0

Cordova platform version

6.0.0
Installed platforms:
  android 9.1.0
  browser
  ios 6.2.0
  osx 6.0.0
Available platforms:
  browser ^6.0.0
  electron ^1.0.0

Plugins & versions installed in project (including this plugin)

cordova-launch-review 4.0.0 "Launch Review"
cordova-plugin-add-swift-support 2.0.2 "AddSwiftSupport"
cordova-plugin-deeplinks 1.1.1 "Cordova Deeplinks Plugin"
cordova-plugin-device 2.0.3 "Device"
cordova-plugin-firebasex 12.1.0 "Google Firebase Plugin"
cordova-plugin-insomnia 4.3.0 "Insomnia (prevent screen sleep)"
cordova-plugin-localization-strings 3.2.1 "Localization"
cordova-plugin-proguard 2.2.0 "Cordova plugin ProGuard"
cordova-plugin-splashscreen 6.0.0 "Splashscreen"
cordova-plugin-statusbar 2.4.3 "StatusBar"
cordova-plugin-theme-detection 1.2.1 "ThemeDetection"
cordova-plugin-whitelist 1.3.4 "Whitelist"

Dev machine OS and version, e.g.

OSX

ProductName:	macOS
ProductVersion:	11.1
BuildVersion:	20C69

iOS build issue:

Node JS version

v14.15.1

XCode version

12.4

I've finally been able to get it to build (although test push notifications aren't received in the TestFlight version of the app).

I've finally been able to get it to build (although test push notifications aren't received in the TestFlight version of the app).

How did you do that? I have tried building the ionic 4 ios Cordova app but it always fails. right now I am compiling the code and building the project via xcode.


Fix java.lang.VerifyError: Bad type on operand stack

When ReadsDataflowSource.getReadPCollection calls Google Dataflow's ReadBAMTransform.getReadsFromBAMFilesSharded we get a java.lang.VerifyError. The full error looks like this:
Exception in thread "main" java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    com/google/cloud/genomics/dataflow/readers/bam/ReadBAMTransform.getReadsFromBAMFilesSharded(Lcom/google/cloud/dataflow/sdk/Pipeline;Lcom/google/cloud/genomics/utils/GenomicsFactory$OfflineAuth;Ljava/lang/Iterable;Lcom/google/cloud/genomics/dataflow/readers/bam/ReaderOptions;Ljava/util/List;)Lcom/google/cloud/dataflow/sdk/values/PCollection; @25: invokevirtual
  Reason:
    Type 'com/google/cloud/dataflow/sdk/transforms/Create' (current frame, stack[2]) is not assignable to 'com/google/cloud/dataflow/sdk/transforms/PTransform'
  Current Frame:
    bci: @25
    flags: { }
    locals: { 'com/google/cloud/dataflow/sdk/Pipeline', 'com/google/cloud/genomics/utils/GenomicsFactory$OfflineAuth', 'java/lang/Iterable', 'com/google/cloud/genomics/dataflow/readers/bam/ReaderOptions', 'java/util/List', 'com/google/cloud/genomics/dataflow/readers/bam/ReadBAMTransform' }
    stack: { 'com/google/cloud/dataflow/sdk/values/TupleTag', 'com/google/cloud/dataflow/sdk/Pipeline', 'com/google/cloud/dataflow/sdk/transforms/Create' }
  Bytecode:
    0x0000000: bb00 0159 2db7 0002 3a05 1905 2bb6 0003
    0x0000010: b200 042a 1904 b800 05b6 0006 c000 07b8
    0x0000020: 0008 b600 09b8 000a b200 0b2a 2cb8 0005
    0x0000030: b600 06c0 0007 120c b800 0db6 0009 b600
    0x0000040: 0e3a 0619 0519 06b6 000f b0

	at org.broadinstitute.hellbender.engine.dataflow.datasources.ReadsDataflowSource.getReadPCollection(ReadsDataflowSource.java:130)
	at org.broadinstitute.hellbender.dev.tools.walkers.bqsr.BadTypeRepro.ingestReadsAndGrabHeader(BadTypeRepro.java:100)
	at org.broadinstitute.hellbender.dev.tools.walkers.bqsr.BadTypeRepro.setupPipeline(BadTypeRepro.java:74)

This is the same error I saw when upgrading to google-cloud-dataflow-java-sdk-all:0.4.150710 (#754), so perhaps this is caused by a version mismatch somewhere.
I wrote a small bug-reproducing class, BadTypeRepro, in its eponymous branch.

Thanks for looking into this, JP -- would you be able to continue investigating this error?

Sure, I can look into it.

Part of https://github.com/broadinstitute/hellbender/issues/751

It appears that increasing the version of dataflow-sdk that genomics-dataflow uses fixes the problem. I'm going to cut a new version of genomics-dataflow soon.

So is it fair to say that this is a dataflow bug rather than a regression in hellbender itself?

It appears this is a Java bug. Or perhaps this is working as intended and were we more informed we'd have known that using two different versions of dataflow-sdk together wouldn't work.
Arguably, we should not have updated Hellbender without noticing that this broke the BAM reader. Doing so transitioned us from a working BAM reader to a broken one - a regression. This is why I think we're all eager to have the cloud regression tests enforced.

This issue was moved to broadinstitute/hellbender-dataflow#36


Compile error: Invalid operands to binary expression

I know this repo hasn't been updated since couple years but I was curious and wanted to compile it on mac. After fixing bunch of compile errors, this last one is remaining! Any idea what's causing it?
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/functional:678:21: error: invalid
      operands to binary expression ('const VDBVolumeSpec' and 'const VDBVolumeSpec')
        {return __x == __y;}
                ~~~ ^  ~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:513:17: note: in
      instantiation of member function 'std::__1::equal_to<VDBVolumeSpec>::operator()' requested here
        {return static_cast<const _Pred&>(*this)(__x.__get_value().first, __y);}
                ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:2119:21: note: in
      instantiation of member function 'std::__1::__unordered_map_equal<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>::operator()' requested here
                if (key_eq()(__nd->__upcast()->__value_, __k))
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:1130:14: note: in
      instantiation of function template specialization 'std::__1::__hash_table<std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::__unordered_map_hasher<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::hash<VDBVolumeSpec>, true>, std::__1::__unordered_map_equal<VDBVolumeSpec,
      std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>,
      std::__1::allocator<std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange> > >::__emplace_unique_key_args<VDBVolumeSpec,
      std::__1::pair<const VDBVolumeSpec, VolumeCache::BufferRange> >' requested here
      return __emplace_unique_key_args(_NodeTypes::__get_key(__x), _VSTD::move(__x));
             ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:1043:26: note: in
      instantiation of member function 'std::__1::__hash_table<std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>,
      std::__1::__unordered_map_hasher<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>,
      std::__1::hash<VDBVolumeSpec>, true>, std::__1::__unordered_map_equal<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>, std::__1::allocator<std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange> > >::__insert_unique' requested here
        {return __table_.__insert_unique(_VSTD::move(__x));}
                         ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:626:18: note: in instantiation of member function
      'std::__1::unordered_map<VDBVolumeSpec, VolumeCache::BufferRange, std::__1::hash<VDBVolumeSpec>, std::__1::equal_to<VDBVolumeSpec>,
      std::__1::allocator<std::__1::pair<const VDBVolumeSpec, VolumeCache::BufferRange> > >::insert' requested here
    m_buffer_map.insert({spec, buffer_range}).first;
                 ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:519:24: note: in instantiation of function template specialization
      'VolumeCache::allocate<half>' requested here
    void* buffer_ptr = allocate<RealType>(spec);
                       ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:483:9: note: in instantiation of function template specialization
      'VolumeCache::getVolume<half>' requested here
        getVolume<half>(spec, output);
        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/utility:580:1: note: candidate
      template ignored: could not match 'pair<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const pair<_T1,_T2>& __x, const pair<_T1,_T2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:712:1: note: candidate
      template ignored: could not match 'reverse_iterator<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:941:1: note: candidate
      template ignored: could not match 'istream_iterator<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2, type-parameter-0-3>'
      against 'const VDBVolumeSpec'
operator==(const istream_iterator<_Tp, _CharT, _Traits, _Distance>& __x,
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1045:6: note: candidate
      template ignored: could not match 'istreambuf_iterator<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
bool operator==(const istreambuf_iterator<_CharT,_Traits>& __a,
     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1153:1: note: candidate
      template ignored: could not match 'move_iterator<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const move_iterator<_Iter1>& __x, const move_iterator<_Iter2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1525:1: note: candidate
      template ignored: could not match '__wrap_iter<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT_DEBUG
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/tuple:1122:1: note: candidate
      template ignored: could not match 'tuple<type-parameter-0-0...>' against 'const VDBVolumeSpec'
operator==(const tuple<_Tp...>& __x, const tuple<_Up...>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:1987:6: note: candidate
      template ignored: could not match 'allocator<type-parameter-0-0>' against 'const VDBVolumeSpec'
bool operator==(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return true;}
     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2964:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const unique_ptr<_T1, _D1>& __x, const unique_ptr<_T2, _D2>& __y) {return __x.get() == __y.get();}
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3000:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const unique_ptr<_T1, _D1>& __x, nullptr_t) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3008:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(nullptr_t, const unique_ptr<_T1, _D1>& __x) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4796:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const shared_ptr<_Tp>& __x, const shared_ptr<_Up>& __y) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4850:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const shared_ptr<_Tp>& __x, nullptr_t) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4858:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(nullptr_t, const shared_ptr<_Tp>& __x) _NOEXCEPT
^
1 error generated.
make[2]: *** [plugin/CMakeFiles/openvdb_render.dir/vdb_sliced_display.cpp.o] Error 1
make[1]: *** [plugin/CMakeFiles/openvdb_render.dir/all] Error 2
make: *** [all] Error 2

I updated the repo with some small updates we had over time, could you please try again with the latest commit on master, and get back to me with the results?
I also need some more information about your issue. Which version of MacOS/XCode/Maya/OpenVDB are you using?

Hey Pal. Nice to hear from you!
I managed to compiled it actually, i forgot to update this ticket. I had to tweak the cmake files quite a bit for it to work. For example adding -DOSMac_ to CMAKE_CXX_FLAGS . I'll test out this new update that you pushed in too.
An off-topic question. What does it take to replicate the sliced representation in legacy viewport? Is it possible? It can be very rough and approximate.  I've been looking for a way to simulate that type of look with legacy viewport but haven't had much luck and it seems like this tool only supports viewport 2.

Would you mind creating a PR with the change?
Regarding VP1, yes, it is possible. With VP1, you get direct access to the OpenGL viewport, so you can do whatever you want to do. Porting the sliced display would be straightforward (as the glsl code required for drawing is just simple alpha blending). The difficulty comes from properly blending your sliced volumes with the rest of the scene. VP2 offers some tools to deal with this (depth peeling based), while you are on your own with VP1.
Since we decided early on not to support VP1 (it's already hidden by default from newer Maya releases), I can't be much help. I think the long term solution would be to look into writing a Hydra Viewport plugin and an HdStorm/UsdImaging adapter. HdStorm already supports OIT, so blending would work correctly with a few slices.

Sure, I'll test it on the latest update, make the changes and create the PR.
That's great if it can be ported to VP1, even if it's rough! This would be just a short-term workaround until we switch to VP2. I'm guessing I have to adjust all the functions under "Unique pointers to VP2.0 objects" and changing VolumeShader::loadShader(), right?
One more question, how is the licensing on this? There doesn't seem to be any on this repo.

Yeah, that sounds about right. Sorry, I don't have the time right now to dig into this.
Licensing: updated the licensing about 3 minutes before your comment, Apache 2 should cover all use cases.

I have the changes ready and locally checked them out to a compile-fix branch. How would you like me to do the PR? If I do git push origin compile-fixes , I get error remote: Permission to LumaPictures/openvdb-render.git denied to YasinH.

No, you can't directly push to this repository. You need to fork, and create a pull request from your fork.

Yeah, already did that a few days ago. Let me know if something was odd in it

From: Pal Mezei<EMAIL_ADDRESS>Sent: Monday, November 11, 2019 3:07:50 PM
To: LumaPictures/openvdb-render<EMAIL_ADDRESS>Cc: YasinH<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [LumaPictures/openvdb-render] Compile error: Invalid operands to binary expression (#3)
No, you can't directly push to this repository. You need to fork, and create a pull request from your fork.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LumaPictures/openvdb-render/issues/3?email_source=notifications&email_token=AEGMTKCXBGBF4UH7X7IVSJLQTHQUNA5CNFSM4JFQW3N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDYOKFI#issuecomment-552658197, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEGMTKBQANA22QXBMCVQKCLQTHQUNANCNFSM4JFQW3NQ.

Ah! Sorry, I didn't notice it in my notifications. Thanks!


⚠ Bofrost.de has degraded performance

In dafa3b1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1515 ms

Resolved: Bofrost.de performance has improved in 6d75bd7 after 6 minutes.


UX validation and recommendations surrounding pause/cancel effects

As a user, I would like to understand how a pause/cancel affects the robot (instant stop versus stop when current task is complete)
Story
As a user, I would like to pause the robot so I can manipulate things on the deck
As a user, I would like to halt the robot if something is happening that shouldn't be happening.
As a user, I don't want to mix up pausing and halting.
Building on top of recommendations here
Acceptance
Completed short survey sent to existing HTTP api cohort. Survey to walk through scenarios.
$20 compensation per completed survey up to 5 respondants.
Deliverable
Revised UX recommendations for #531 re: Pause/Play

Survey is in flight w/ 15 participants, however we've yet to get any responses. Will be sending out reminders on the 26th.

Quick copy-paste of a comment that I left on PR #8161:

I don't have a strong use case for this yet, but I've been thinking we should have three separate actions:

A "pause from the outside" action. Issued by HTTP clients, and by pressing the OT-2's front button.
A resume action that undoes (1).
A resume action that undoes pauses that are built into the protocol.

Because I think an HTTP client should be able to naively undo its own pause and be confident that the robot will be left exactly how it was before, without knowing anything deep about the protocol.
For example, say you're writing a client to issue HTTP commands to the OT-2 to coordinate it with other equipment. You want to implement a "stop everything" button. You also want to implement a button that resumes from the "stop everything."
If the OT-2 was in a protocol-issued pause state when the user clicked "stop everything," you probably wouldn't want the OT-2 to start moving on its own when they click resume. You'd expect the OT-2 to go back to doing exactly what it was before—and what it was doing was waiting.
Currently, to work around this, you'd have to know that the robot is currently on a protocol-issued pause, and, as a special case, avoid resuming it.
Edit: And I haven't thought about how this interacts with the door opening and closing.

@readywater Let me know if you want to talk through this. It's still kind of fuzzy in my head, so I'm probably not explaining it well.

A "pause from the outside" action. Issued by HTTP clients, and by pressing the OT-2's front button.

A resume action that undoes (1).
A resume action that undoes pauses that are built into the protocol.
Because I think an HTTP client should be able to naively undo its own pause and be confident that the robot will be left exactly how it was before, without knowing anything deep about the protocol.
For example, say you're writing a client to issue HTTP commands to the OT-2 to coordinate it with other equipment. You want to implement a "stop everything" button. You also want to implement a button that resumes from the "stop everything."

I think in this situation, you'd want to be able to pass some arguments to the API that could modify that behaviour, but the default pause behaviour should be consistent across interaction modes — api, button, app, door.

If the OT-2 was in a protocol-issued pause state when the user clicked "stop everything," you probably wouldn't want the OT-2 to start moving on its own when they click resume. You'd expect the OT-2 to go back to doing exactly what it was before—and what it was doing was waiting.

If you have an API issued pause and open the door, then the door interaction wouldn't affect anything.
I think though that like, if you think of being paused as being a state that the robot is in (and I know using the word state here is probably fraught), then any action to modify that state would apply. So if you pause the robot with the button but then resume it from the app, or pause the robot with an API call then press the button to unpause — that should be consistent.

Currently, to work around this, you'd have to know that the robot is currently on a protocol-issued pause, and, as a special case, avoid resuming it.
Edit: And I haven't thought about how this interacts with the door opening and closing.

This ticket is awaiting survey results, if they exist. Will post and close accordingly

Closing as stale.


Bug fix 3.4/little weekend fix

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7368/

@obiwahn: Wrong branch names used in Jenkins build... Please restart with correct branches

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7391/

ports:

[ ] 3.3 -- https://github.com/arangodb/arangodb/pull/10525
[ ] 3.4 -- https://github.com/arangodb/arangodb/pull/10526
[x] 3.5 -- https://github.com/arangodb/arangodb/pull/10527
[x] devel -- https://github.com/arangodb/arangodb/pull/10518

Tests blue except one test failure on Windows, which looks totally unrelated.

Tests blue except one test failure on Windows, which looks totally unrelated.

ssl_server had false positive. Status of collection for RocksDB makes no sense.


Zoomed vision on tablet, and normal on my laptop

Hey  there, im trying your integration but i cant make it look good on my tablet. it is like zoomed in.
I tried the WIKI mobile configurations, but i just didn't fix that.
canyou help me sort out why it is not responsive?

It may be worth looking into adding some extra code into custom.css
You may be able to change the views depending on screen size

We can't help you since you haven't even provided a screenshot of how it looks and what do you expect.


chore: update Deno version to 1.14.1

Haven't tried using 1.14.2 because it looks like it isn't supported yet: https://github.com/hayd/deno-lambda/releases
This PR also removes some trailing whitespace - not intentionally, just deno fmt being deno fmt :P

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've reverted this to a draft while it's still blocked on deno doc

deno-lambda supports 1.16 now!
Ready to pick this up again, won't have much time tonight (currently Sunday afternoon in Australia) but hopefully over the next few days I can spare some time to work on it :)


Clean up console app

Or determine it should be removed?

The console app was never really designed, so it is being removed in favor of developing a proper app (with UI, etc.).


Build and Deploy for Kubernetes

Build containers for backend and frontend
Script to deploy to Kubernetes Cluster, locally
Video

https://github.com/kyledinh/zio-blogapp/pull/19
https://github.com/kyledinh/zio-blogapp/blob/main/docs/guides/build-kubernetes-guide.md
Video: https://youtu.be/9PXKby6QMjw


Configure Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

.github/workflows/auto-pr.yml (github-actions)
package.json (npm)

Configuration Summary
Based on the default config's presets, Renovate will:

Start dependency updates only once this onboarding PR is merged
Enable Renovate Dependency Dashboard creation.
If Renovate detects semantic commits, it will use semantic commit type fix for dependencies and chore for all others.
Ignore node_modules, bower_components, vendor and various test/tests directories.
Automatically detect the best rangeStrategy to use.
Rate limit PR creation to a maximum of two per hour.
Limit to maximum 10 open PRs at any time.
Group known monorepo packages together.
Use curated list of recommended non-monorepo package groupings.
A collection of workarounds for known problems with packages.

🔡 Would you like to change the way Renovate is upgrading your dependencies? Simply edit the renovate.json in this branch with your custom config and the list of Pull Requests in the "What to Expect" section below will be updated the next time Renovate runs.

What to Expect
With your current configuration, Renovate will create 2 Pull Requests:

chore(deps): update dependency vitest to ^0.31.0

Schedule: ["at any time"]
Branch name: renovate/vitest-monorepo
Merge into: main
Upgrade vitest to ^0.31.0

chore(deps): update actions/checkout action to v3

Schedule: ["at any time"]
Branch name: renovate/all
Merge into: main
Upgrade actions/checkout to v3

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Renovate Bot.

Renovate is disabled
Renovate is disabled due to lack of config. If you wish to reenable it, you can either (a) commit a config file to your base branch, or (b) rename this closed PR to trigger a replacement onboarding PR.


App does not run on Firefox and Safari in development mode

Works fine on Firefox after bundling but not in development mode.

Fixed by https://github.com/CitizensFoundation/your-priorities-app/pull/12


CHEBI:90039 wrong CAS

The CAS from CHEBI:90039 has a 6/5 ring system while the entry has a 6/6 system.

Thanks for letting us know. This has now been corrected.


Doesn't rip with the config.ini file.

Hi, RiffyDiffy speaking! I like your tool, and has great potential, but there's just one issue I'd like to respond.

When I first drag in the spritesheet and the .plist file (without the config.ini file), it separates the sprites.
However, it doesn't exactly separate that well comparing to one-pill's texture unpacker script.
The config.ini file appears, I edit out this line from this:
# Crops sprites to their edges, set to false for original animation size
crop_sprites = true
To this:
# Crops sprites to their edges, set to false for original animation size
crop_sprites = false
When I saved it, delete the outputted folder, and tried it again. Well, the image above explain.
Can you figure out a way to fix this bug? It would be extremely appreciated, and I plan on to use this tool for future uses!
Thanks for reading this!
-RiffyDiffy

Oh, wait a minute, I found out how to separate the sprites like I wanted.

So, I changed the "sourceSize" strings to "spriteSourceSize", in order for the script to separate with the "spriteSourceSize" component.
Sorry if I did some modifications. Is it okay if I can fork your project to feature my change, or no?

Wait, again. It doesn't work with the "ani_cookie0000" files.
It displays the same error.


Support links execute vscode commands in output panels

Feature
Currently, I'm using the output panel and can use file paths in order to create links to files on my system. At the moment, this includes input and output files from the extension running. I want to also be able to diff compare the output to the correct output on just a click from the terminal.
In order to use vscode's awesome diff editor, I have to launch it programmatically. So that's where this feature idea came from. If I was able to create links in the output panel that run a vscode command, I could then launch the diff editor on the appropriate files.
I can also see why you wouldn't want someone to launch commands from the output panel as a fear of unknown code execution.
Background
I'm working on an extension for personal use designed as a test runner for competitive programming. The gist of it is that I create test cases from input and output files and can run on multiple languages with the output to the output panel. There are other features specific for the extension that aren't relevant here.
Any input on whether this is already supported, any good alternatives, or whether this is a bad idea?
Note: that just selecting files and doing a diff isn't an applicable solution, because the files are runtime generated and stored in temporary locations.

Currently, I'm using the output panel and can use file paths in order to create links to files on my system. At the moment, this includes input and output files from the extension running. I want to also be able to diff compare the output to the correct output on just a click from the terminal.

You say both Output Panel and Terminal, which thing are you talking about?
Do you have a proposal for how this would work?

I was specifically talking about the Output Panel, sorry for the confusion.
Currently the output panel deals with link rendering, so maybe a specific syntax that when parsed by the code that manages output panel rendering. The idea is to create hyperlinks that really just execute vscode commands.


Fix: Fixed crash caused by adding the same key

Resolved / Related Issues

[ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #issue...

Validation
How did you test these changes?

[X] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Thank you for your contribution.
I'm a bit confused about what this PR is trying to resolve, can you elaborate so we can continue to review the work you have done?

@hez2010
This is a fix for the following crash reported by App Center.

I don't know when this crash happens, but this is one of the frequently reported crashes.