2i2c-aws-us/itcoocean: help to setup s3 bucket

In https://2i2c.freshdesk.com/a/tickets/906 Eli asks for help to setup a s3 bucket for the itcoocean.2i2c.cloud hub part of the 2i2c-aws-us cluster.
The goals are:

Admin users should have read/write permissions
non-admin users should just have read access
Allowing anyone access the data, but to not need to pay for users accessing the data.

Goal is to not have egress charges from our S3 bucket (in us-west-2). The data are not "private". We'd make the S3 bucket public but the egress charges would rack up.

Related

Looking at s3 pricing, I see they mention you don't have to pay for:

Data transferred from an Amazon S3 bucket to any AWS service(s) within the same AWS Region as the S3 bucket (including to a different account in the same AWS Region).

2i2c infrastructure docs about buckets: https://infrastructure.2i2c.org/howto/features/cloud-access/
Notes from Eli about setting up a bucket and declaring permissions: https://2i2c.freshdesk.com/a/tickets/906

Todo

Distinguishing admin users from non-admin users access to buckets

[ ] Enable us to configure admin users to have different k8s ServiceAccounts (that should be associated with AWS credentials in s3 buckets) than normal users
#3039
Enable creation of another set of cloud credentials to access buckets with

[ ] For AWS
[ ] For GCP

[ ] Enable creation of another k8s ServiceAccount that we can annotate as well

[ ] Allowing anyone access the data, but to not need to pay for users accessing the data

Comment from Freshdesk:

Freshdesk: 906  linked successfully.

                  Freshdesk: #906
By: James Munroe<EMAIL_ADDRESS>

We received an update that this wasn't required to have setup by september 11, so I've updated the title to reflect that now.

The freshdesk ticket was closed following no response, but on AWS this is now very doable.


Run accessibility insights for PT Run

Run accessibility insights for PT Run and file / fix bugs subsequently

On Running Accessibility insights on PT Run, two types of accessibility issues have been identified -

Code Related Accessibility Issues #5366
2, UI Contrast Related Accessibility Issues #5367


Feature request: "Error downloading file": do something about it

Sometimes, files are not fully downloaded. The download ends with "Error downloading file" and a partially downloaded file is saved. It would be nice if there was a way to
a) distinguish between fully and partially downloaded files (for instance by file name), so that users can decide if they want listen to incomplete episodes.
b) an option to retry download of partially downloaded files without overwriting fully downloaded files.
Example: LibsynDL https://chinahistorypodcast.libsyn.com/rss /tmp/
(less than half of the episodes where fully downloaded)

Thanks, will look into it

Commit a80a4e7142f2fea1ac89c1e46675f53f1dc89e23 hopefully solves the issue. Saves incomplete files in a temp directory + skips fully downloaded files


Empty multiscales/multiscaleTransformations metadata field

Expected Behavior
Under the ome-ngff 0.4 schema, any NGFF multiscaleTransformations entry must have at least one transformation sub-item.
https://github.com/ome/ngff/blob/main/0.4/schemas/image.schema#L169
Observed Behavior
ngff-zarr outputs a multiscales/coordinateTransformations entry with zero transformations in .zattrs and .zmetadata.
Sample .zattrs:
{
    "multiscales": [
        {
            "@type": "ngff:Image",
            "axes": [
                ...
            ],
            "coordinateTransformations": [],          # <---------- here
            "datasets": [
                {
                    "coordinateTransformations": [
                        {
                            "scale": [
                                0.01600000075995922,
                                0.014399999752640724,
                                0.014399999752640724
                            ],
                            "type": "scale"
                        },
                        {
                            "translation": [
                                7.4079999923706055,
                                18.417600631713867,
                                13.3056001663208
                            ],
                            "type": "translation"
                        }
                    ],
                    "path": "scale0/image"
                },
               ...

Steps to Reproduce
> ngff-zarr -i "image.nii.gz" -o "image.zarr" -u "x" "millimeter" "y" "millimeter" "z" "millimeter" -m itk_gaussian

Additional Notes
Out-of-spec multiscaleTransformations entry currently results in failure to read image with https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF . Can be worked around by manually deleting the multiscales/multiscaleTransformations entry in .zattrs.

xref clearer ITKIOOMEZarrNGFF error messages to aid in debugging: https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/pull/34


qtbase: fix xkbcommon-evdev packageconfig for 5.12

Patch that made meta-qt5 use this feature has been reverted for 5.12,
which is used by thud layer of meta-qt5 with commit 33c578729e721ac80e.
Signed-off-by: Oleksandr Kravchuk<EMAIL_ADDRESS>

Can one of the admins verify this patch?

I am not sure where this was reverted. Can you add few links ?

https://github.com/meta-qt5/meta-qt5/blob/master/recipes-qt/qt5/qtwayland/0001-Revert-use-new-feature-name-xkbcommon_evdev-xkbcommo.patch

I think the qt patch should be backported to thud for better can you please submit a backport request to meta-qt5

I'm not sure I understand what is going on here. Can someone explain?

I'm not sure I understand what is going on here. Can someone explain?

this fix wont be needed on thud if a patch in thud can be backported from master in meta-qt5 itself.
so I am asking for backporting the needed patch in meta-qt5 itself instead of adjust meta-rpi bbappend.


Fix TestSolrCLIRunExample Nightly Thread Leak

TestSolrCLIRunExample has been failing thread leak in nightly since the Http2SolrClient has not been closed in RunExampleTool

Thanks @epugh for the review and @HoustonPutman makes sense to make and for the commit.


feat(share/p2p/shrex): add recovery middleware to shrex-nd and shrex-eds servers

Add recovery middleware to shrex-eds and shrex-nd server implementation

Codecov Report
Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.65%. Comparing base (2469e7a) to head (4f869a6).
Report is 30 commits behind head on main.

Files
Patch %
Lines

share/p2p/recovery.go
62.50%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
- Coverage   44.83%   44.65%   -0.19%
==========================================
  Files         265      273       +8
  Lines       14620    15137     +517
==========================================
+ Hits         6555     6759     +204
- Misses       7313     7607     +294
- Partials      752      771      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New contributing.md

PR brings the CONTRIBUTING.MD document in line with the updated, HTML-formatted contribution guidelines from the /docs site. Also adds a hyperlink to said HTML content.

Looking good! I would add a paragraph about testing maybe? Should cover:

adding positive tests
adding negative tests
be consistent using headers (do we have a template for this one? 🤔 )
when to use encoded_request (and deprecate using raw_request)
Sounds reasonable?

@RedXanadu Hey! Do you need help here?

@fzipi I'm not 100% clear about the 'writing tests' part.
"adding positive tests, adding negative tests"
Definitely, two bullet points to add. This part makes sense.
"be consistent using headers (do we have a template for this one?)"
I'm not sure about this. I know we have positivetest.yaml.skeleton but I definitely think that's more confusing than helpful… Do we have a simple example test to document?
"when to use encoded_request (and deprecate using raw_request)"
I'm not sure what this means.

How about using these as example tests, as I think they're relatively easy to understand:
Positive Test Example
 - test_title: 932100-21
    desc: "Unix command injection"
    stages:
      - stage:
          input:
            dest_addr: <IP_ADDRESS>
            headers:
              Host: localhost
              User-Agent: OWASP ModSecurity Core Rule Set
              Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
            method: POST
            port: 80
            uri: "/"
            data: "var=` /bin/cat /etc/passwd`"
            version: HTTP/1.0
          output:
            log_contains: id "932100"

Negative Test Example
 - test_title: 932150-5
    stages:
      - stage:
          input:
            dest_addr: "<IP_ADDRESS>"
            method: "POST"
            port: 80
            headers:
              User-Agent: OWASP ModSecurity Core Rule Set
              Host: "localhost"
              Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
            data: 'foo=ping pong tables'
            protocol: "http"
          output:
            no_log_contains: "id \"932150\""

One of the things I've realised long before doing the change is... we should use Accept: */*. Shorter. Easier. 🤷
Other than that, I think the description (desc field) is also important. Because that is where you refer to why this is negative test.
Regarding encoded_request and raw_request, those are possible ways of encoding requests. They allow you to encapsulate everything, so you don't declar headers for example. The test will send exactly what is inside that field. But using raw is difficult to maintain. You might be using weird bytes that might break yaml or parsers. So we should recommend to use encoded_request only, because it will do exactly the same, but it more portable.

Okay, great, that makes sense. Thanks.
I'll take a look at writing this up tomorrow.

Content agreed and merged in the documentation repo.
Now updating this PR to include the agreed-upon changes.


Add Property Slowness

I have a table with ~800K records. I am using Java API OClass#createProperty to add a new property. The API is taking long time (> 30 mins) to execute. It feels like OrientDB is trying to add property to each document of table (or validating each record). Is there any easy way to optimize this operation?

Added +4 new test cases.


Adding Organization User Invitation Email Template to Existing Organizations/Tenants

Is your suggestion related to an experience ? Please describe.
Add the email template [1] for existing organizations.
[1] https://github.com/wso2-extensions/identity-event-handler-notification/pull/204
Describe the improvement

Additional context

Will be captured from the migration docs. It is asked to copy the email-admin-config.xml file from the new IS

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Update README.md for Conan installation instructions

This PR adds the necessary instructions for installing and using xsimd with the Conan package manager. I have also added some CMake instructions to create a new project.

Thanks for the PR!
Nitpicking remark: could you change the order of how to install the library? We prefer to have the package managers section first, then the installation from sources.
The example of cmake should go in the Building and Running the Tests section rather than Usage, what do you think?

I agree with everything. I am making the changes as we speak.

Thanks! I'll merge this PR, feel free to open a new one if you want to add a section with an example of CMake, I will be happy to review and merge!


Clarify filenames in README.md

The current documentation is confusing when calling write_NIRS or write_SNIRF functions in examples in README.md. The variable filename is given for both a .lumo/.lufr file and the output of write_NIRS/write_SNIRF function. Thus, this can lead to overwrite of LUMO files if the code is taken directly from the example.
The update clarifies filenames for write_NIRS and write_SNIRF functions calls:
write_NIRS(filename) -> write_NIRS(nirs_filename)
write_SNIRF(filename) -> write_SNIRF(snirf_filename)

@samuelpowell could you approve this if it looks ok?


Docker: Linux Spec Capabilities

I'm trying to run this command.
docker run -v $OVPN_DATA:/etc/openvpn -d -p 1194:1194/udp --cap-add=NET_ADMIN kylemanna/openvpn
However, every time I try to run this I get:
docker: Error response from daemon: linux spec capabilities: Unknown capability to add "CAP_NET_ADMIN
I'm running a precompiled binary on Vultr's platform (the storage node), and I'm wondering what the issue might be. Any help?
Specs:
Docker Version: 1.11.2
CentOS 7

Perhaps it's a CentOS 7 bug.  I'm running Ubuntu 16.04.01 on a VULTR storage node and works.  Tested with:
docker run -v $OVPN_DATA:/etc/openvpn -p 1194:1194/udp --cap-add=NET_ADMIN kylemanna/openvpn openvpn --version

Docker: 1.12.1
Kernel 4.4.0-36
Another option might be to replace --cap-add=NET_ADMIN with --privileged but it offers less granular control.

The workaround works. Is it related to the kernel? I'm kernel 3.10

In addition, I also get bash: CLIENTNAME.txt: permission denied when running the command:
docker run -v $OVPN_DATA:/etc/openvpn --rm kylemanna/openvpn ovpn_getclient CLIENTNAME > CLIENTNAME.ovpn
IS it related?

The workaround works. Is it related to the kernel? I'm kernel 3.10

Could be, earlier versions of docker didn't have --cap-add and perhaps your kernel which seems ancient didn't have the underlying support.  Workaround is probably just fine, proper fix is to run a newer kernel or distribution, but if you're attached to CentOS I'd stick with the workaround.

In addition, I also get bash: CLIENTNAME.txt: permission denied when running the command:
docker run -v $OVPN_DATA:/etc/openvpn --rm kylemanna/openvpn ovpn_getclient CLIENTNAME > CLIENTNAME.ovpn

This actually has nothing to do with docker.  The > redirects stdout from the executable (in this case docker) to a file instead of displaying it on the screen.  In you invocation it's attempting to write to CLIENTNAME.ovpn in the working directory that your current user doesn't have sufficient file permissions to write to.  Change the file path to somewhere you have permissions to, like your $HOME directory.
Search Google for shell  input and output redirection to learn more.


Added chaos acceptance tests in plugin sdk

pushed with https://github.com/turbot/steampipe-plugin-sdk/pull/76


cdk-virtual-scroll-viewport should allow setting styles on nested wrapper

Please describe the feature you would like to request.
Documentation on virtual scrolling says that cdk-virtual-scroll-viewport can have orientation="horizontal" but we need to ensure that the items are laid out horizontally via CSS. We cannot do that if our components have encapsulated styles. It should expose a transparent way to set styles to the wrapper without use ::ng-deep hacks. Besides, the wrapper is an internal realization and ideally we shouldn't know/care about it at all.
What is the use-case or motivation for this proposal?
Horizontal virtual scrolling inside view encapsulated components

Sorry guys, I just figured that I can add another nested wrapping DIV myself. Would be better to use this as an example in documentation though, since documentation now suggests no view encapsulation and reaching into internal class which can easily get changed in the future.


allow isDefault to have optional value

In my SVD file an enumerated value of a field is labeled with <isDefault>true</isDefault>, which seems okay as per the spec. When this is parsed I get an error like:
[ERROR svd2rust] Error parsing SVD XML file

    Caused by:
        0: In device `PAC52XX`
        1: In peripheral `SYSCLK`
        2: In register `SCCTL`
        3: In field `CLKIN`
        4: Parsing enumeratedValue `ROSC` at 57:17
        5: `EnumeratedValue error: EnumeratedValue must contain one of `value` (passed Some(0)) or `is_default` (passed Some(true)) tags

Changing the value from true to 1 gives the error:
[ERROR svd2rust] Error parsing SVD XML file

    Caused by:
        0: In device `PAC52XX`
        1: In peripheral `SYSCLK`
        2: In register `SCCTL`
        3: In field `CLKIN`
        4: Parsing enumeratedValue `ROSC` at 57:17
        5: `EnumeratedValue error: EnumeratedValue must contain one of `value` (passed Some(0)) or `is_default` (passed Some(true)) tags

However, changing the value to 1.0 does work. Seems to be an issue where something expects an integer.
Here is the SVD file in question: pac22140.svd.txt

moved to svd repo

enumeratedValue should contain <value> OR <isDefault>. Not the both.

as @burrbull points out, spec says
<xs:choice>
  <xs:element name="value" type="enumeratedValueDataType"/>
  <xs:element name="isDefault" type="xs:boolean"/>
</xs:choice>

I see. Thanks @burrbull and @Emilgardis.
Doesn't surprise me with the myriad of other problems with this SVD.

@Emilgardis svd2rust still not support isDefault: https://github.com/rust-embedded/svd2rust/issues/172

@Emilgardis after some thinking choice restriction looks strange as it would be helpful if default EnumeratedValue has value too to use it in field writers in svd2rust.
Should we move this check in strict mode?

isDefault | Defines the name and description for all other values that are not listed explicitly.

Looking over the spec, I'm not even sure what <isDefault> is supposed to be used for, I don't see the value for it, not even in a debugger.
svdconv doesn't handle isDefault, with or without a value it just removes the enums that don't specify a name

Added example there: https://github.com/rust-embedded/svd2rust/pull/767#issue-2004728412

I see, so it's if no matched enum value, use this. What does <isDefault> with a value mean then? If not matched or is <value>

What does <isDefault> with a value mean then?

It's could be used to manually specify what exact value to use for writer. Technically it is not needed if it can be found automatically. See minimal_evs_hole in PR.


Quick update (flatpak) downloads to wrong directory

Using the quick update option with flatpak steam downloads the file to the normal steam directory not the flatpak directory.
I believe this line is the issue: https://github.com/auyer/Protonup-rs/blob/1e8c07e10121818efca3996e5785346942f473bd/protonup-rs/src/main.rs#L235

Thank you for pointing this out!
I just fixed it, and will make a new release on the next minutes.


Cant start fishy

PS C:\Users\xxx> python -m fishy
Traceback (most recent call last):
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\fishy_main.py", line 10, in
from fishy.gui import GUI, splash, update_dialog, check_eula
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\fishy\gui_init.py", line 1, in
from .gui import GUI
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\fishy\gui\gui.py", line 8, in
from ttkthemes import ThemedTk
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\ttkthemes_init_.py", line 6, in
from ttkthemes.themed_tk import ThemedTk
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\ttkthemes\themed_tk.py", line 8, in
from ._widget import ThemedWidget
File "C:\Users\xxx\AppData\Local\Programs\Python\Python37\lib\site-packages\ttkthemes_widget.py", line 10, in
from PIL import Image, ImageEnhance
File "C:\Users\xxx\AppData\Roaming\Python\Python37\site-packages\PIL\Image.py", line 93, in
from . import _imaging as core
ImportError: cannot import name 'imaging' from 'PIL' (C:\Users\xxx\AppData\Roaming\Python\Python37\site-packages\PIL_init.py)

can u please send the result of this command
pip freeze

no response


Brainstorming session for Owner Personas

Deliverables

[ ] Conduct brainstorm session
[ ] Document personas

Brainstorming session booked for 25 May.

See https://github.com/apinf/api-umbrella-dashboard/blob/master/docs/UX/APINF owner persona.pdf


(PUP-5109) Supress warning if there is either IPv4 or IPv6 network

CLA signed by all contributors.


Fix multiple waits for same future issue

When there are multiple waits for a single future, only the last one was continued.
This is fixed by this PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a0c7f75). Click here to learn what that means.
The diff coverage is 79.31%.

@@            Coverage Diff            @@
##             master   #12893   +/-   ##
=========================================
  Coverage          ?   59.99%
  Complexity        ?      659
=========================================
  Files             ?     2073
  Lines             ?   102164
  Branches          ?    13001
=========================================
  Hits              ?    61298
  Misses            ?    35682
  Partials          ?     5184

Impacted Files
Coverage Δ
Complexity Δ

.../org/ballerinalang/bre/bvm/SafeStrandCallback.java
89.28% <79.31%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c7f75...35fc08b. Read the comment docs.


A function to change parent

A function to change parent could be useful
Node.change_parent(ParentNode)
There is a workaround to Node.add_child(Node) then Node.quee_free() the old one, but it will loose all its instanced values.

parent_node1.remove_child(child_node)
parent_node2.add_child(child_node)

:)

Also to some extent a duplicate of #1905, so closing.

@akien-mga Ahh.. I knew it there was a dupe :smile:

See also #1943, #1949, #2657 and #3290..

Bottom line, yes adding a helper function to reparent a node would be cool, but it wouldn't automagically solve the above-mentioned issues (just see how many commits the other guys did in their PRs that did not get merged).

Haha. I think the gotcha is most people forget that if you remove the child node you can still access it and move it wherever.  What I first thought was if we do remove_child that node is poofed permanently, which isn't the case. We are free to re-parent that sucker wherever we want :D

Maybe something like detach_child would be more informative?


update go.mod dependencies

For unknown reasons it seems that dependabot does not seem to
update all dependencies specified in a go.mod file. Thus, this commit
updates all of those dependencies manually.
Signed-off-by: André Martins<EMAIL_ADDRESS>

/test

/test


feat(CosmosFullNode): Allow configuring the chain home directory

Closes https://github.com/strangelove-ventures/cosmos-operator/issues/341
There's been too many instances where chains still persist data outside of the --home flag.
Notably: Osmosis, DYDX, and now DVPN/Sentinel.
So we can't rely on chains to respect the user's intentions.
This feature allows the user to optionally configure the chain home.
Unfortunately, we can't reliably derive the home path because no chains use a common convention.

FYI, I did extensive testing on a testnet cluster and it looked good.


readAmount was broken (too small)

Actually all packets were decoded with error
1st was null after decoding
2nd was reported too small (decoded packet size == 7302766) which most probably caused by broken header
will try to run something and catch packets myself to find the reason of broken headers

I'm trying http://localhost:5080/vod/ and can see no errors
Just got disconnect :((


Implemented things by branch name, also:

Created setContentDescription modifier that allows to set contentDescription on any used Modifier - as accessibility feature, suppossing that it may help to understand the UI architecture more

To understand how it looks like, attach few screenshots:
When start a game:

when user mark more than max of the mines:

@arkivanov Hello, please, check how it looks like!

@arkivanov Hello, I'm made recommended changes, please, check how it looks like!

Let's rock it!

Thank you!

Thank you!

Thank you too, for reviewing my code and making it better together!
Hope I will start implementing the stopwatch soon, I don't want to use additional dependencies (for educational purposes for me and project, if someone wants to research it)
Also I tried to go to wasm site from this repo, I also got amazed that you create a pipeline that automatically creates a build and publishes it to the site (you did a great work with this CI/CD)
I visit it from mobile android chrome browser, and can't click anything. is this wasm restriction for now? Or it just doesn't work because in the project clicks are used instead of touches?

Yeah, Wasm on Android chrome is pretty much broken currently. Also on any browser, all mouse clicks are recognised as left clicks.


corporate: Move setup_upgrade_checkout_session_and_payment_intent to BillingSession class.

Refactors setup_upgrade_checkout_session_and_payment_intent to be part of the BillingSystem abstract class.
Notes:

Prep commit to replace compute_plan_parameters with get_price_per_license since that's the only information that setup_upgrade_checkout_session_and_payment_intent was using.
Second commit moves the logic for creating stripe.checkout.Session and Session object to the BillingSession abstract class. This happens in three code paths: the initial upgrade for the 'charge automatically' path, if the initial card added to the account fails to charge, changing an existing card on account to a new card.
Third commit moves the logic for creating stripe.PaymentIntent and PaymentIntent object to the BillingSession abstract class, which only happens in the initial upgrade for the  'charge automatically' path.
No changes need to existing automated tests. Manually tested the three flows for creating checkout sessions (initial upgrade working card, initial upgrade non-working card, change existing card on account) with varying inputs (monthly/annual, automanage licenses/manual license management) for the initial upgrade with payment.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @laurynmm! This seemed like another good checkpoint to continue work from.


feat: devtools

Codecov Report
Base: 64.64% // Head: 64.64% // No change to project coverage :thumbsup:

Coverage data is based on head (fb23644) compared to base (430d67b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   64.64%   64.64%
=======================================
  Files          44       44
  Lines        4135     4135
  Branches      195      195
=======================================
  Hits         2673     2673
  Misses       1462     1462

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Parent products on shopping list

Let's say I have a parent product in a shopping list for "paper towel"
I think if I purchase any of its child-products, it should remove the parent products from the shopping list.
Actually any item that is purchased should be removed from the shopping list if it's on there

Are you talking about the products below minimum stock (https://pantryparty.app/docs/basic_usage/current-stock.html)?
PantryParty hasn't integrated with the Grocy shopping list yet.
If you are saying that Grocy's normal purchase flow in the web ui will take items off the shopping list, then you are correct I did not know that was a feature and did not implement that.


MangaUpdates tracker

Describe your suggested feature
Add MangaUpdates website as tracker
Other details
already in 'Tachiyomi'
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.8.5.
[X] I will fill out all of the requested information in this form.

Already in the preview build

Already in the preview build

Is there a way to return the customization of everything to the previous version? this new version has too much lag

Nope

Nope

And any way to add MangaUpdates as a tracker to the previous version?

I'm not doing it, so unless you fork SY and do it, nope.

I'm not doing it, so unless you fork SY and do it, nope.

Uh... I understand, sorry, one more thing, the app closes in the middle of the library update, this doesn't happen to me in Tachiyomi 🤔

I would suggest joining the https://discord.gg/Tachiyomi discord for help with that


Refactor API tests

This PR refactors the tests for the API endpoints in preparation for using them to test the MatrixStore.
The main change is to remove the fixture values for the vw__ tables and replace them with queries which populate those tables from the prescribing fixtures. Previously, the data was inconsistent between the views and the other tables which made testing difficult. We also fix some inconsistencies in CCG membership in the prescribing fixture, and an inconsistency with the ImportLog dates.
As a bonus, a bit of fiddling with the db_timeout decorator allows us to use the standard TestCase in place of TransactionTestCase which brings the run time for the API tests from 6 minutes down to 4 seconds.

This makes me very happy, and I think both the extra consistency and the test speedup are worthy of some very cheap prosecco for the dev team.
The SQL in api_test_data.sql isn't quite correct though (but I'm not sure whether it matters) because it doesn't take into account a practice's current CCG.  The BQ SQL selects from normalised_prescribing_standard, which is a view that includes a join on the practice table, so that its pct column always refers to the prescription's practice's current CCG.
You have two options here:

fix the fixtures so that practices don't change CCGs (as you've done)
fix the SQL so that the vw__*_by_ccg tables only include a practice's current CCG

I'd prefer fixing the SQL, but would completely understand if you felt that it wasn't worth it!
(For reference, we test that the vw__*_by_ccg calculations handle a practice moving CCG using fixtures generated in https://github.com/ebmdatalab/openprescribing/commit/bb3251d568956cb18ef47deb67f70cc9e44bf271#diff-2cceee09b4ab8c8570b64222f4384d9d.)

Ah, I see. I think I prefer fixing the SQL too. I don't think it will be loads of work (it's just an extra join, right?) and it means we don't have to worry about consistency issues in future. I'll have a look at this tomorrow.

@inglesp Have now updated the SQL so it does a join to get the current CCG membership for each practice

Splendid :+1:


Fee endpoint

Change route to /tokens/:address/fee in api implementation and openapi.
Make sure it accepts address with 0x prefix. Probably make a local wrapper type around H160 and implement FromStr in a similar way as OrderUid using hex crate.

Dang it, I never read this. It contained already the solution for my problem. Nice. Thanks!


Tracer.startSpan, api.isInstrumentationSuppressed is not a function, example/tracer-web

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
opentelemetry-js
What version of Node are you using?
Tried with both 12 & 14, threw same error.
Please provide the code you used to setup the OpenTelemetry SDK
What did you do?
I cloned opentelemetry-js repo and follow the README under example/tracer-web, but error was threw after npm start, also the browser console complains about Tracer.startSpan, api.isInstrumentationSuppressed is not a function.
If possible, provide a recipe for reproducing the error.
What did you expect to see?
The screenshot shown in the README.
What did you see instead?
Error.
Additional context
Add any other context about the problem here.

Please include the versions of components you are using.

I can corroborate this experience with package versions:
  "dependencies": {
    "@opentelemetry/api": "0.20.0",
    "@opentelemetry/api-metrics": "0.19.0",
    "@opentelemetry/context-zone": "0.19.0",
    "@opentelemetry/core": "0.19.0",
    "@opentelemetry/exporter-collector": "0.19.0",
    "@opentelemetry/instrumentation": "0.19.0",
    "@opentelemetry/instrumentation-document-load": "0.16.0",
    "@opentelemetry/metrics": "0.19.0",
    "@opentelemetry/web": "0.19.0"
  }

API 0.20.0 will be compatible with the SDK components 0.20.0 when they are released later today. For now, SDK components should use API 1.0.0-rc.3.
For full context on why the API version was "downgraded" from 1.x to 0.x, take a look at https://github.com/open-telemetry/opentelemetry-js-api/issues/74

You can track the release of the SDK which will be compatible with API 0.20.0 at #2246 but keep in mind that the document load instrumentation you're using will also need to be updated and released.

Thank you, @dyladan!!
Using this version scheme, I'm able to work with spans as expected.
  "dependencies": {
    "@opentelemetry/api": "1.0.0-rc.3",
    "@opentelemetry/api-metrics": "0.19.0",
    "@opentelemetry/context-zone": "0.19.0",
    "@opentelemetry/core": "0.19.0",
    "@opentelemetry/exporter-collector": "0.19.0",
    "@opentelemetry/instrumentation": "0.19.0",
    "@opentelemetry/instrumentation-document-load": "0.16.0",
    "@opentelemetry/metrics": "0.19.0",
    "@opentelemetry/web": "0.19.0"
  }

Thank you guys!


No detect the external library (Phpoffice)

2 computer is working on the SAME repository but first computer detect the library and work well but second computer not detect it and show "Error 'PhpOffice\Phpspreadsheet\Reader\Xlsx' not found".
In vendor, the library also exist
composer.json and composer.lock also the same on both computer
| ---------------- | ---
| Yii version | 2.0.12?
| PHP version | 7.14
| Operating system | Mac

One thing is that by git ignore, I use yii's composer mechanism at 1st computer but at sec computer(err computer), I add library manually


[DO NOT MERGE] Upgrade Docker Baseimage to Node.js 8.10.0

As we move towards support for Node.js 8, one of the biggest steps is changing the version in the Dockerfiles. This is all it will take in this repo, but we'll want to test things out before merging. Additionally, we don't currently have a great way to enable this for only master/staging branches. However, rebuilding the baseimages manually and testing API and PIP (so far) on my machine has worked well.
Before we can merge this, we have to ensure that all our code up to the production branch is ready for Node.js. As far as I know the only thing that requires is merging https://github.com/pelias/whosonfirst/pull/310, and then ensuring all our services in production are using at least whosonfirst 2.21.1 and wof-admin-lookup 4.3.2

Replaced by https://github.com/pelias/baseimage/pull/1


Version tree doesn't select latest upgrade if it doesn't reach current version

If there is an action, and that action has an upgrade to a version that is not the current one, selecting the action will not select the upgrade instead of the action.
This means that when the upgrading happens, it happens from the original action completely ignoring the previous upgrade, and the new upgrade also appears as sibling of the previous one (instead of child).
This is unrelated to #1046 since it also happens before.

Of course after #1046 you don't see that unless you uncheck "don't show upgrade nodes" in preferences/advanced.

This is more serious than I thought, since with the way the __upgrade__ annotation works, we can only store a link to one upgrade from each version. They have to be chained, they can't be sibling; VisTrails would forget about them.

Relevant code: do_version_switch()

Should be fixed by #901


Lesser game frame rate after using

Somehow this Debloater reduced the average frames I get in a game(Roblox), I used to be getting 130+ but now its 90< What could have caused it? The only visible thing it did was give me is a much much more responsive OS, but the bad side is the lower frames, so it's a double sided blade. Even in a game called Osu I used to get 240 fps but now it dropped to a sad number of 170.
Could it have deleted some helpful files that are incorporated with game performance?

Probably some drivers.


Switching branch on a solution being migrated to the new project system leaves dirty behind (even after clean)

From @valeriob on August 28, 2017 9:21
Hi,
we are migrating many solutions to the new project system, but the tool is not helping us.
We create a branch where we migrate the project formats (not every one is yet on vs 2017).
When we switch back to the master (old prj system), we get an error for every project complaining about  :

Create a solution with .net framework and old project system (master branch)
Create a branch and migrate projects to the new prj format (new branch)
Switch back to the master branch, clean and compile

you get many errors depending on the project like :
Your project.json doesn't have a runtimes section. You should add '"runtimes": { "win": { } }' to your project.json and then re-run NuGet restore.
Your project is not referencing the ".NETFramework,Version=v4.6.1" framework. Add a reference to ".NETFramework,Version=v4.6.1" in the "frameworks" section of your project.json, and then re-run NuGet restore.
Looking inside ./obj folder i see 4 files :
projectName.nuget.cache
projectName.nuget.g.props
projectName.nuget.g.targets
project.assets.json
if i manually delete the /obj folder of the project and compile it works.
Thanks
UPDATED:
i must add that this is very annoying on the dev machine, but particularly annoying on the CI server.
Copied from original issue: dotnet/project-system#2742

I'm going to move to MSBuild - but I suspect there's really nothing we can do here to do a "real" clean. MSBuild would have to keep a history of all produced outputs over time, and remove them when you ran Clean.


Custom alarms

what

The type conversion is a bit finicky and if the map does not have the same number of keys there could an error related to the locals not being the same type.

why

BugFix

references

#43

/test all

/test all

@lorengordon Thanks again

@lorengordon Thanks again


Macron should default to non-macron character not hyphen

Characters with a marcron (e.g. ō) should default to the non-macron version of that letter, not a hyphen.
Example: Pōneke

Expected result: poneke
Current result: p-neke

I'm interested in making a contribution to the repo if maintainers agree on the intent of this issue!

Hello, yes I agree, we should definitely support this.
The current character map we use is https://github.com/pid/speakingurl/blob/master/lib/speakingurl.js but it looks like that dependency is no longer maintained so submitting it upstream won't help.
A possible alternative character map is https://github.com/sindresorhus/transliterate/blob/main/replacements.js but this has gone ESM-only, which I don't intend to do here.
Perhaps it's time to either fork or directly add the speakingurl logic as part of this repo and make the changes we need? Suggestions welcome.

Thanks again for the PR, v4.0.0 now available.


Installing loki fails because of ingress value seemingly incorrect

I have tried to let teks create loki via the the terraform-kubernetes-addons repo.
However i do get this error:
╷
│ Error: failed to create resource: Ingress.extensions "loki" is invalid: spec.rules[0].host: Invalid value: "map[host:logz.my.domain.tld paths:[/]]": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
│
│   with helm_release.loki-stack[0],
│   on loki-stack.tf line 136, in resource "helm_release" "loki-stack":
│  136: resource "helm_release" "loki-stack" {
│
╵

The hostname can properly be matched against the given regex, so i don't see why it should fail.
What i noticed however was that it seemed to render a go object as the hostname (which doesn't make sense to me when looking at the manifests that are templated).
Or do i interpret this incorrectly?
I am a little confused anyway about this, as when i am rendering the loki-stack chart in the given version (2.8.2) with the values given it would not create an ingress resource.
That is due to the helm chart loki-stack having the loki helm chart as a dependency and thus expecting its configuration in loki.*.
When i do change that in the extra_values it doesn't create an ingress resource at all though, so it seems that terraforms helm vs. my local one (v3.10.0) is behaving differently?
I only removed the annotations, from the terragrunt.hcl for the loki stack, as i don't want to use the nginx ingress class.
So my extra_values look like this:
    extra_values         = <<-VALUES
      resources:
        requests:
          cpu: 1
          memory: 2Gi
        limits:
          cpu: 2
          memory: 4Gi
      config:
        limits_config:
          ingestion_rate_mb: 320
          ingestion_burst_size_mb: 512
          max_streams_per_user: 100000
        chunk_store_config:
          max_look_back_period: 2160h
        table_manager:
          retention_deletes_enabled: true
          retention_period: 2160h
      ingress:
        enabled: true
        hosts:
          - host: logz.${include.root.locals.merged.default_domain_name}
            paths: ["/"]
        tls:
          - secretName: logz.${include.root.locals.merged.default_domain_name}
            hosts:
              - logz.${include.root.locals.merged.default_domain_name}
        VALUES

I'd be really glad for some hints on where to look at.

OK this is wild, while loki-stack is stated, actually the real chart that's used is the loki chart.
This chart has changed how it handles the ingress hosts variable with version 3.0.0 (loki repo git commit hash c6f7a4122574752a95423075f9fdd5922db60ff9)

I will prepare a small changeset to fix the current extra values, however it might be wise to add an e2e test here to ensure all resources can be properly created and removed afterwards.

https://github.com/particuleio/terraform-kubernetes-addons/issues/1379


MQTT Naming fixes

Thanks for you contribution!
I did not have time to do this myself and since its not that of a big issue i have not prioritized it.
Im gonna merge this soon and create a new release!


Star music plays over regular music

When the player gets a star (with the built-in star or otherwise), the star music plays on top of the regular level theme. This bug only occurs in v13e.

Could you provide more details? Can't seem to get this to happen on smb 1-1.
I've had this happen with animations and music changers in the past but I want to know if this is something seperate.

No idea if this still happens

It plays over intermission music, idk if that is what sky was on about but i've had zero problems with normal music


[CARBONDATA-1263]Single pass load does not take default value false for blank or inval…

Issue :- When Single pass value is given wrong (other than true/false) along with External Dictionary, Error is logged but Load is continue with Single pass=false . Which is not correct as for external  dictionary single pass must be true.
Solution :- Load is interrupted and  Error is thrown with proper error message.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2913/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/327/

Can one of the admins verify this patch?

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/38/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1216/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/585/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3083/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4327/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4005/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4369/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5793/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5926/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/78/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8826/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/759/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/581/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/888/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9155/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1089/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9158/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9159/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1090/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9160/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9161/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9163/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1102/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1104/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1105/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9184/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9198/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2029/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10281/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3417/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/103/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/102/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/99/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/8/


remove magnum from travis-ci.com link

We're no longer using magnum.travis-ci.com. It redirects do travis-ci.com anyway and the magnum might just confuse people.

Thanks for the PR @lislis, you rock!


ISPN-12481 lock-free SyncProcessingQueue

https://issues.redhat.com/browse/ISPN-12481

Some preliminary numbers
master
Benchmark                                  (consumerDelay)  (producerDelay)   Mode  Cnt       Score      Error  Units
SyncProcessingQueueBenchmark.pushAndWait2                0                0  thrpt   16  195281.813 ± 2161.177  ops/s
SyncProcessingQueueBenchmark.pushAndWait2                0               10  thrpt   16  197914.959 ± 2506.130  ops/s
SyncProcessingQueueBenchmark.pushAndWait2                0              100  thrpt   16  187467.698 ± 1885.793  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10                0  thrpt   16  197724.733 ± 3139.547  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10               10  thrpt   16  197446.585 ± 3106.995  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10              100  thrpt   16  189787.057 ± 3239.134  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100                0  thrpt   16  193570.843 ± 2456.758  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100               10  thrpt   16  189653.444 ± 2551.090  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100              100  thrpt   16  183585.022 ± 4243.454  ops/s

This pr:
Benchmark                                  (consumerDelay)  (producerDelay)   Mode  Cnt        Score        Error  Units
SyncProcessingQueueBenchmark.pushAndWait2                0                0  thrpt   16  1995885.544 ±  55103.406  ops/s
SyncProcessingQueueBenchmark.pushAndWait2                0               10  thrpt   16  2104246.160 ±  77654.840  ops/s
SyncProcessingQueueBenchmark.pushAndWait2                0              100  thrpt   16  2041778.864 ± 190395.636  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10                0  thrpt   16  2046269.439 ±  60839.916  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10               10  thrpt   16  1969678.808 ±  39858.488  ops/s
SyncProcessingQueueBenchmark.pushAndWait2               10              100  thrpt   16  1945230.866 ± 228512.231  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100                0  thrpt   16  1397323.381 ±  19609.587  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100               10  thrpt   16  1372057.392 ±  27760.970  ops/s
SyncProcessingQueueBenchmark.pushAndWait2              100              100  thrpt   16  1060660.459 ± 241542.295  ops/s

Would be interesting to see how this queue behave with a proper super fast pmem disk instead, but I don't have any ;)
The main difference with the original queue is that this one is a bit more memory hungry (but we can blame RxJava mpsc linked q for that, https://github.com/JCTools/JCTools has few gc-free alternatives nudge nudge), but I'm sure this could be improve if necessary.

Would be interesting to see how this queue behave with a proper super fast pmem disk instead, but I don't have any ;)

@jhalliday Might be able to help!

Thanks @ryanemerson I have already spoken with @jhalliday about it but I don't know if we would have any chance to try this on a real hw, @jhalliday wdyt? It's feasible to have a round of bench with this in?

@franz1981 I still haven't managed to delve into this yet, but I have a question.
We also use a SynchronousQueue for executors, e.g. in JGroups' TP.init() and for our expiration executor (the only one that still has 0 queue length). Should we look into changing all of them to a better queue impl?

@danberindei consider that this queue isn't a full fat blocking queue as synchronous queue nor allow (yet) to fire and and forget tasks as a thread pool impl need.
In general I would say "yes" about having better queue impls (disclaimer: I am one of the devs of https://github.com/JCTools/JCTools) especially if used on AOT given that bad reputation of the jdk ones related to garbage produced.
In term of pure performance, it means of the underlying tasks is expensive in term of time or not, because it means that enqueue/dequeue time start to became a factor.

Integrated into master, thanks @franz1981 !

Thanks @wburns !
@jhalliday
Let me know if you got any chance to test it with both a slow and super fast storage so I can provide some sane default (or adaptive, even better) for spin/yield configurations.
On user code instead I believe batching writes before fdatasync/fsynx is a must-have with FileChannels (while pmem won't benefit from it) and should give a nice boost amortizing both syscall pwrite/write and sync cost.


VSCode terminal shows wrong conda environment on interpreter change

Type: Bug

Behaviour
Expected vs. Actual
I am switching between different conda environments to test my code with different libraries / library versions.
I change the interpreter at workspace level to a different conda environment. The code seems to work fine the only issue is:
The terminal in which the code is executed still uses the old conda environment (showing the "(oldenv) user@pc:" prompt).
But the code runs fine in the new environment.
This is particular annoying because at first my thought was that the environment didn't change.
It also weird when checking in which environment the code was run.
Killing the terminal and executing the script again activates the correct environment.
It seems the solution could be running "conda activate currentenv" everytime when running/debugging another program, or on switching the current interpreter.
Steps to reproduce:

Create two conda environments. (eg install different versions of the same package)
Start the code with one environment. (eg just output the package version)
Change the interpreter to the second environment.
Start the code again. The terminal still shows the old environment, despite executing with the new environment.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.6
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Experiment 'pythonSurveyNotification' is active
LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
> conda info --json
Python interpreter path: ~/miniconda3/envs/ma/bin/python
> /bin/python3 ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
> /usr/bin/python3 ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
> ~/miniconda3/bin/python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
> ~/miniconda3/envs/ma/bin/python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
Starting Pylance language server.
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Starting Pylance language server.
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
> conda info --json
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
> conda info --json
> conda info --json
> ~/miniconda3/envs/tvconda/bin/python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
> conda info --json
> ~/miniconda3/envs/tvpip/bin/python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/interpreterInfo.py
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
DAP Server launched with command: /home/leon/miniconda3/envs/ma/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
> conda info --json
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
> conda run -n ma --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
Python interpreter path: /usr/bin/python3
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
Python interpreter path: ~/miniconda3/envs/tvconda/bin/python
> conda run -n tvconda --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
> conda info --json
DAP Server launched with command: /home/leon/miniconda3/envs/tvconda/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
> conda info --json
DAP Server launched with command: /home/leon/miniconda3/envs/tvconda/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/tvconda/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
Python interpreter path: ~/miniconda3/envs/tvpip/bin/python
> conda run -n tvpip --no-capture-output python ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/printEnvVariables.py
Jupyter provided interpreter path override: /home/leon/miniconda3/envs/ma/bin/python
> conda info --json
DAP Server launched with command: /home/leon/miniconda3/envs/tvpip/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
DAP Server launched with command: /home/leon/miniconda3/envs/tvpip/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter
> conda info --json
DAP Server launched with command: /home/leon/miniconda3/envs/tvpip/bin/python /home/leon/.vscode/extensions/ms-python.python-2022.16.1/pythonFiles/lib/python/debugpy/adapter

User Settings

Multiroot scenario, following user settings may not apply:

languageServer: "Pylance"

Extension version: 2022.16.1
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:16:26.920Z)
OS version: Linux x64 5.15.0-50-generic
Modes:
Sandboxed: No

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
i497e931:30553904
pyindex848:30577860
nodejswelcome1cf:30587006
40g7c324:30573242

@Leon5x Try setting"python.terminal.activateEnvInCurrentTerminal" to true, we do not auto-activate the terminal in focus right now. Feel free leave your feedback here: https://github.com/microsoft/vscode-python/discussions/19610.

This unfortunately doesn't solve the problem.
It seems I didn't explain it properly, sorry:
When I run my code using the default Run->Start Debugging / Run Without Debugging
VS Code opens a "Python Cebug Console" under the Terminal in the Panel. And in this debug console the conda environment is not changed.

Thanks I see the issue. With https://github.com/microsoft/vscode-python/issues/11039 we'll do a better job of highlighting that a user needs to open a new terminal when environment changes.
Particularly in case of executing or debugging, I'll leave this issue to open to investigate if we can open a new Python Debug Console when an environment changes.


outdated yslow addon info on /en-US/docs/Web/Performance/Fundamentals

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

URL https://wiki.developer.mozilla.org/en-US/docs/Web/Performance/Fundamentals
yslow addon seems to be no longer maintained. yslow github repo commit was in 2014.

I've removed the reference. Thanks for reporting this!


update to 0.7.4

[ ] upstream repo https://github.com/dylan-profiler/visions
[ ] run tests on dependent packages
[ ] go through [changelog] - couldn't find
[x] diff https://github.com/dylan-profiler/visions/compare/v0.7.1...v0.7.4
[ ] look for any open issues for new versions
[x] dev_url, doc_url valid
[ ] setuptools/wheel/pip/pip check included
[ ] compare pinned versions from upstream

meta.yaml
setup.py
setup.cfg
tox.ini

building for pandas-profiling update

failing on ppc64le due to missing docker

failing on ppc64le due to missing docker

Yeah, we should raise this in our team meeting


Feature Request: Windows and Mac support

I have just discovered this and I must say this is SO MUCH BETTER than the original. Kudos to you, my (wo)man.
But I can't build it for Windows and/or Mac... So, could you create a Windows port? I'd even donate to see it happen :)

As far as Windows is concerned, Windows do not allowing grabbing of device by an Application. For USB device, there is a workaround (see libusb/libusb#335 );  however for bluetooth device, I do not know any workaround.
To overcome this issue the official Logitech Software configure the device to send all of its signal on HID++ interface. For more details, please see Resetting Logitech Spotlight device section in Logitech Spotlight HID++ documenation. Hence, on Windows or Mac official software get all the device events on HID++ interface.
However, Projecteur do not configure the device in same manner, because in that case Input Mapper feature will not work. Without Input Mapper feature, Projecteur will simply provide similar feature as Official software.

Well, at least not in the short to medium term - maybe in the long term.
(Maybe (and only maybe) a version 2.0 in the future)
I personally don't see the appeal in having a Windows version - first and foremost because it is a private project where I like to develop on and for a platform that I personally prefer.
Nevertheless, the following repo https://github.com/cvuchener/hidpp could help with realizing a Windows version in the future.

Logitech seems to have discontinued the Spotlight remote, so if the software stops getting support in the future, we will probably need to make this app cross-platform. I’m getting a remote later today, so I’ll start playing around with the HID capture in Windows. Max might be easier, I’ll also take a look at that

Just for documentation this might be useful at some point in the future regarding Windows:

https://learn.microsoft.com/en-us/windows-hardware/drivers/hid/virtual-hid-framework--vhf-
https://learn.microsoft.com/en-us/windows-hardware/drivers/usbcon/using-winusb-api-to-communicate-with-a-usb-device

And Mac? would it be possible to capture alle events just via Qt?

And Mac? would it be possible to capture alle events just via Qt?

Don't know never owned or used a Mac 😀 - capturing all those events just via Qt it is not possible to my knowledge


Dynamic configuration

Enable developers to dynamically change the configuration at runtime.
Includes documentation and a test.
Todo

[x] Complete test suite (make sure dynamic config overrides defaults, file and environment)
[x] Type definition file update

Fixes #67

This should now be ready to go.

Added proper support for custom config to this PR.


NIFI-3497 ScanAttribute Tagging

NIFI-3497 Adding tagging option to ScanAttribute

@joetrite left a series of comments and highlighted a thread safety issue.  Some refactoring will be needed to overcome that.  Also, can you please add a unit test that covers multi hit scenarios?  Thanks

@joewitt thx for the feedback.  will work on it.

no problem and thank you - really appreciate your attitude on this.  It is not fun going through the review process the first time.  Definitely takes courage to take the first jump!

@joewitt i'm made most of these changes, still testings things but one thing i want to note/raise (maybe by design?) in the original code is that if the ff does not contain any attributes that match the attribute pattern regex, then the ff is automatically going to the matched relationship.  I would think that if I specify an attribute pattern and none of the attributes match the pattern then the ff would go to unmatched.  I'm not planning to change this functionality as it would def break existing flows, just want to note it in case it is a bug/not working as expected.

@joetrite that sounds like a good catch then and it should be fixed.  The docs say "at least one must match" or "all must match" so there is no cause for 'none matched (even if no attributes)' going to matched.  It should go to unmatched.  That is probably good for another JIRA/PR but if you want to do that in here I'm ok with that too personally.  Or if you just want to raise the JIRA/PR but not tackle that this is ok too.

@joetrite actually looks like the logic bug causing things to route to success when no attributes match at all would only apply to the 'allMatch' case and it is because it returns true if it never returns false.  If line 228 took into account that the attribute matcher had more than one hit it would do the job.  something like 'return howeverManyHitsWeSaw > 0'

@joewitt fixed routing, simplified code + thread safety issue and spelling of tomato :)

@joetrite my apologies for the big delay.  Been hard to get back to this.  I of course remember very little of this now which makes it harder to get back into it.  have you been using this?

Closing due to inactivity.


pypodman logs: option --since, -f and -t/--timestamps are not implemented

Is this a BUG REPORT or FEATURE REQUEST?:
kind feature
Description
As the title, below options are not implemented:

--follow, -f
Follow log output. Default is false
--since=TIMESTAMP
Show logs since TIMESTAMP. The --since option can be Unix timestamps, date formatted timestamps, or Go duration strings (e.g. 10m, 1h30m) computed relative to the client machine's time. Supported formats for date formatted time stamps include RFC3339Nano, RFC3339, 2006-01-02T15:04:05, 2006-01-02T15:04:05.999999999, 2006-01-02Z07:00, and 2006-01-02.
--timestamps, -t
Show timestamps in the log outputs. The default is false

The implementation of --follow might be difficult/impossible, but --since and --timestamps are possible.

@Edward5hen --since and --timestamps were not supported as the API return is an array of strings.  If the API is enhanced to return (timestamp, message) the client could then support these options.  Otherwise the overhead is too great. /cc @baude


requestBody: required: true doesn't work

Description
Connexion 2.2.0
OpenAPI 3
requestBody:
  required: true

Connexion doesn't validate that a requestBody was provided.
Expected behaviour
400 Bad request -> requestBody is required
Actual behaviour
request is passed through to controller; KeyErrors abound because no requestBody was provided
Steps to reproduce
Submit a POST with no requestBody
Additional info:
Output of the commands:
Python 3.6.8
Version: 2.2.0

Hey @mbalaa-spring
Thanks for filing the issue. That does indeed look like a bug.
Connexion validates the individual schemas, so if you want a workaround, you should be able to mark the schema as required.

Any updates when will this be merged ? I need to create an endpoint that can receive an empty body and without this change connexion says None is not of type 'object'.

@dtkav @ioggstream Can this be merged in? I'm running into issues due to this bug as well.

I don't know if the workaround I wrote is good enough to cover all cases: iirc delving deeper in the subject that was more complex than it seemed (that's why I didn't create a PR).
Ask @dtkav for further infos.

Try setting type property for schema
i.e.
requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object

I worked for my case though.


ci: add Azure Static Web Apps workflow file

on-behalf-of: @Azure<EMAIL_ADDRESS>

Sorry created by mistake, thought was creating PR the other way round


Testable Constraint Output

See https://github.com/personalrobotics/aikido/issues/237.
Summary of changes:

New TestableOutcome class and corresponding CollisionFreeOutcome derivative class for CollisionFree (NonColliding was renamed to CollisionFree in #256).

Change base constraint class (Testable) to add TestableOutcome (base constraint outcome class) as parameter to isSatisfied.

CollisionFree constraint now populates this field on a collision (self or otherwise).

TODO:
@mkoval, l I had a question about https://github.com/personalrobotics/aikido/pull/235, item 4. This is something I'd be happy to implement before merging, but I was curious what sort of use case this scenario would pop up in.
Test Plan
Also checked CollisionFreeOutcome's toString and isSatisfied methods in test_CollisionFree unit tests. Printed the return value of toString separately, and result seemed sane.

Before creating a pull request

[x] Document new methods and classes
[x] Format code with make format

Before merging a pull request

[x] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[x] Add unit test(s) for this change

I added the checklist that is for our PRs.

@mkoval I also have a similar question about item 4 in the comment.
In the case that we don't know the type of Testable at compile time, I think we also have a problem of not knowing what the outcome type should be. For this, I would suggest adding a virtual function std::unique_ptr<Outcome> createOutcome() to Testable so that we could create a right type of outcome from the testable like:
auto outcome = testable->createOutcome();
testable->isSatisfied(state, outcome);
std::cout << outcome->toString() << std::endl;

(sorry for not reviewing in multiple comments)
Also, I'm not sure if we really want to put Outcome class in a nested directory. Do we have a reason for putting the class in the nested directory?

Awesome feedback! Working through this now.

As of the latest commit, there are two big changes:

As per the suggestion of @brianhou, I have made CollisionFreeOutcome operate on Contact objects instead of just BodyNode names (for all of the advantages Brian gave, including seeing the exact collision pairs). This involved writing a method getCollisionObjectName to go from CollisionObject to a name. I'd appreciate feedback on this function in particular, since I'm not 100% sure this is the best way to implement that functionality.

CollisionFree will now barf and throw an exception when the TestableOutcome pointer passed to isSatisfied doesn't point to a CollisionFreeOutcome object.

I will go through soon and update the tests as @brianhou mentioned, but I'd like to have these changes rubber stamped before then.

Updated tests to take advantage of programmatic access to data.

Implemented the testable->createOutcome() functionality as requested by @jslee02. This invovled writing a default implementation in Testable and an overriding one in CollisionFreeOutcome. Also created a DummyOutcome object (not intended to actually be used) that is used by the default createOutcome method in Testable.
Note: DummyOutcome throws an exception if isSatisfied is called to make it very clear to the user that the returned object is not meant for use. We can remove this if people would like to.

Pretty much there. Two biggest changes:

Made helper method to cast between types of TestableOutcome.

Make every Testable derivative class populate the isSatisfied output. Made every Testable derivative also implement createOutcome.

Various other tweaks as well (see comments). I think this should be ready to merge soon, so @jslee02 @brianhou @mkoval, let me know if you have any other thoughts.


A small necessary change in Extension.

A small change to get the owner name changes to couchbase in extension.

I am not able to access here. this link.


Add state option to login query string

hey @andyrichardson I want to leverage the state parameter so I added the variable to the login req.query and am passing it into getAuthorizationURL. Let me know if this looks ok

Hey dwilt, does the following work for your use case?
app.use("/workos/authenticate", (req, res, next) => {
  const state = { redirect: req.query.redirect, timeOfInvocation: Date.now() };
  return passport.authenticate("workos", { state: btoa(JSON.stringify(state)) })
})

This should work similar to other OAuth strategies (github, gitlab, etc)

@andyrichardson unfortunately, I don't think so. I'm using NextJS and don't have access to the req object when I call passport.authenticate. Here is my class which instantiaties a new PassportStrategy with workos:
import { Injectable } from '@nestjs/common';
import { ConfigService } from '@nestjs/config';
import { PassportStrategy } from '@nestjs/passport';
import { WorkOSSSOStrategy as Strategy } from 'passport-workos';

@Injectable()
export class WorkOSSSOStrategy extends PassportStrategy(Strategy, 'workos') {
  constructor(configService: ConfigService) {
    super(
      {
        clientID: configService.get('WORKOS_CLIENT_ID'),
        clientSecret: configService.get('WORKOS_API_KEY'),
        callbackURL: 'http://localhost:4001/api/v1/auth/workos/callback',
      },
      // TODO: get typings put in so this can be properly typed
      (_req, _accessToken, _refreshToken, profile, done) => {
        return done(undefined, profile);
      },
    );
  }
}

Thanks for clarifying, I see what you mean.
It looks like you might need to go the inheritance route in this case (example here).

Yea, I think this will work. Thanks for calling out.

@andyrichardson yep this worked! Thanks!!!


Enderchest

Portable enderchest

BlockHorizons/InvSee is probably a more suitable place for this. Using that plugin, you can already grant players invsee.enderinventory.view.self permission to allow them to run /enderinvsee <their name>, but feel free to open a feature request issue there.

Added a way to configure /echest in InvSee: https://github.com/BlockHorizons/InvSee/blob/a7cccae0803454c0756aa122b02931cbeb504c46/resources/modules.yml#L10-L12


Unhandled exception in CFE at spurious type parameter list

Consider the following program:
class A<T> {
  final List<T> xs;
  A<T>(List<T> this.xs);
}

This program causes the CFE (35bc17a0fa3a347089dfcd7a1c4f781b37c32db7) to stop with an unhandled exception as follows:
type 'Constructor' is not a subtype of type 'GenericDeclaration' in type cast
#0      TypeParameter.declaration (package:kernel/ast.dart:13090:28)
#1      TypeParameter.isStructuralParameter (package:kernel/ast.dart:13176:37)
#2      TypeParameterType.hashCode (package:kernel/ast.dart:12639:26)
#3      InterfaceType.hashCode (package:kernel/ast.dart:11531:65)
#4      _OperatorEqualsAndHashCode._hashCode (dart:collection-patch/compact_hash.dart:254:33)
#5      _LinkedHashMapMixin._getValueOrData (dart:collection-patch/compact_hash.dart:587:26)
#6      _LinkedHashMapMixin.[] (dart:collection-patch/compact_hash.dart:610:13)
#7      BinaryPrinter._writeNodeMetadataImpl (package:kernel/binary/ast_to_binary.dart:664:47)
#8      BinaryPrinter._writeNodeMetadata (package:kernel/binary/ast_to_binary.dart:658:5)
#9      BinaryPrinter.writeNode (package:kernel/binary/ast_to_binary.dart:439:7)
#10     BinaryPrinter.writeVariableDeclaration (package:kernel/binary/ast_to_binary.dart:2423:5)
#11     BinaryPrinter.writeList (package:kernel/binary/ast_to_binary.dart:342:16)
#12     BinaryPrinter.writeVariableDeclarationList (package:kernel/binary/ast_to_binary.dart:2431:5)
#13     BinaryPrinter.visitFunctionNode (package:kernel/binary/ast_to_binary.dart:1526:5)
#14     FunctionNode.accept (package:kernel/ast.dart:3877:38)
#15     BinaryPrinter.writeFunctionNode (package:kernel/binary/ast_to_binary.dart:448:10)
#16     BinaryPrinter.visitConstructor (package:kernel/binary/ast_to_binary.dart:1315:5)
#17     Constructor.accept (package:kernel/ast.dart:2676:40)
#18     BinaryPrinter.writeConstructorNode (package:kernel/binary/ast_to_binary.dart:504:10)
#19     BinaryPrinter.writeConstructorNodeList (package:kernel/binary/ast_to_binary.dart:406:7)
#20     BinaryPrinter.visitClass (package:kernel/binary/ast_to_binary.dart:1280:5)
#21     Class.accept (package:kernel/ast.dart:1476:38)
#22     BinaryPrinter.writeClassNode (package:kernel/binary/ast_to_binary.dart:483:10)
#23     BinaryPrinter.writeClassNodeList (package:kernel/binary/ast_to_binary.dart:378:7)
#24     BinaryPrinter.visitLibrary (package:kernel/binary/ast_to_binary.dart:1118:5)
#25     Library.accept (package:kernel/ast.dart:590:38)
#26     BinaryPrinter.writeLibraryNode (package:kernel/binary/ast_to_binary.dart:462:10)
#27     BinaryPrinter.writeLibraries (package:kernel/binary/ast_to_binary.dart:797:9)
#28     BinaryPrinter.writeComponentFile.<anonymous closure> (package:kernel/binary/ast_to_binary.dart:607:7)
#29     Timeline.timeSync (dart:developer/timeline.dart:173:22)
#30     BinaryPrinter.writeComponentFile (package:kernel/binary/ast_to_binary.dart:588:14)
#31     serializeComponent (file:///b/f/w/pkg/vm/bin/kernel_service.dart:1031:11)
#32     _processLoadRequest (file:///b/f/w/pkg/vm/bin/kernel_service.dart:931:13)
<asynchronous suspension>

@johnniwinther, I think this issue has been resolved. I see error messages (as expected), not unhandled exceptions in the CFE. I'll close it, please reopen if you disagree.


Downloading FASTA Records with GI Number via efetch?

Is there a way to tell efetch to download FASTA records such that record headers include the GI number? For example, a given header would look like this
>gi|2248537881|ref|NM_001407571.1| Homo sapiens BRCA1 DNA repair associated (BRCA1), transcript variant 6, mRNA
instead of like this
>NM_001407571.1 Homo sapiens BRCA1 DNA repair associated (BRCA1), transcript variant 6, mRNA
The command I'm using is efetch -db nuccore -input accNosRandom.txt -format fasta > seq.fna where accNosRandom.txt contains a list of accession numbers. It results in the non-GI number format.

GIs were phased out by NCBI a few years ago. While they still remain in the ASN1 records and can be fetched using efetch with the option -format gi they are not exposed in the FASTA files and it does not have an option to include the gi number in FASTA output.

Thanks for letting me know.


Update README

Please update the usage information in the program and the README, especially the --target option.

Readme and --help option updated.
Thanks.


work in progress #21

This is work in progress. The commits will be rebased with appropriate commit messages and documentation later.

@nathanstilwell I know why you got stuck now, it’s complicated :tm: I'll fix it up and we can discuss changes then

The problem was that we used a promise in check.js that we could not mock. We could mock the nets call, but then the reject() / resolve() calls wouldn’t happen in its callback, and the Promise returned by .check() would remain pending.
So what I did is to move the nets call into a utils module, so we could mock it entirely. And then add some magic to add the .abort method to the promise. So state.request is now the promise returned by our lib/utils/request.js, and we set promise.abort in there.
Does that all make sense?

I finished this up, hope you don’t mind @nathanstilwell. We got more starter issues if you’d like contribute again :)
http://go.hood.ie/hoodie-starter-issues

Hey @gr2m. Not worries. Life got in the way and I timed out on this issue. Once things settle, I'm looking forward to digging back in to contributing.

Looking forward to hear back from you, whenever you feel like it :)


Improve boot

takes warm boot of stress-app babel from (2108ms - 2600ms) -> 1400ms
Some more perf for warm and cold boots: https://github.com/stefanpenner/async-disk-cache/issues/4 coming soon.

LGTM

this also improves cold boot abit

:+1:

released at v1.0.5


login with an e-mail address and password possible?

Hello,
I run several Ubuntu 16.04 computers with pbis open against an AD authetify. Login with username and password is also running.
Is a login with an e-mail address and password possible? Since I have found nothing in the documentation, I ask the question here.

I don't believe it's possible to use the email address (mail attribute) to perform logon.
You can use either the NT4 style <sam account name> or the UPN @
It may be possible to make your UPN match your email address.


GQL button should redirect to 3007 port and /api/gql route, so it will be more compatible with all platforms/environments

For example in Codespaces it would be possible only to access /api/gql, not 3006 port.

@ivansglazunov any objections?


add alert and avatar components

Added following components :
Simple alert

Alerts with icons

Different types of Avatars

Preview Link :-
https://shuttle-ui-testing.netlify.app/docs.html
Feedbacks appreciated. And thanks for reviewing my work 🙂.

LGTM👍

LGTM👍

Thanks for reviewing.


useSubscription does not respond to reactive variables

I am using graphql-code-gen with urql and I am trying to use a subscription to subscribe to events in a room. I don't know the value of roomId during script setup so it needs to be a reactive variable (see code below). I have tried a number of different ways to pass the roomId to useSubscription but none of them seem to respect reactivity. No matter what, the query is only executed once with a roomId of empty string.
I can confirm that roomId.value is undefined on initial page load but is set to a correct value immediately after the first query completes. I can see the id in the template on the app.
<script setup lang="ts">
import {
OnNewMessageDocument,
  useGetRoomByCodeQuery,
  useOnNewMessageSubscription,
} from "@/generated/graphql";
import { useSubscription } from "@urql/vue";
import { computed, ref, watch } from "vue";
import { useRoute } from "vue-router";
import PageWrapper from "../../components/PageWrapper.vue";

const route = useRoute();
const code = route.params["code"] as string;
const shouldPause = ref(true);

const {
  data: roomData,
  error: roomError,
  fetching: roomLoading,
} = useGetRoomByCodeQuery({ variables: { code } });

const room = computed(() => roomData.value?.roomByCode);
const roomId = computed(() => room.value?.id)

const sub1 = useSubscription({
  query: OnNewMessageDocument,
  variables: {
    roomId: roomId.value ?? ""
  }
})
</script>

I even tried to add this but it triggers once when roomId.value updates and just resubscribes with empty string as roomId:
const execute = () => {
  sub1.executeSubscription()
}

watch(roomId, () => {
  console.log('executing')
  execute()
})

I'm just guessing here, but looking at the place where you actually use the reactive variable you're not actually using a reactive variable, i.e.
const sub1 = useSubscription({
  query: OnNewMessageDocument,
  variables: {
    roomId: roomId.value ?? ""
  }
})

This unwraps roomId.value and hence expects this to be reading out the value just once rather than:
const sub1 = useSubscription({
  query: OnNewMessageDocument,
  variables: {
    roomId: computed(() => roomId.value ?? ""),
  }
})

However, I'm just guessing here... it's also possible you'd rather want to block the request from happening when the variable isn't present, right?
const sub1 = useSubscription({
  query: OnNewMessageDocument,
  variables: {
    roomId,
  },
  isPaused: computed(() => !roomId.value),
})

Closing due to inactivity


tbwchange doesn't fire on mobile devices

The event tbwchange doesn´t fire while type in a mobile device, only when I click in a button at the toolbar or hit enter.
Informations
Browser + version: Chrome 54.0.2840.85
OS: Android 4.4.4 - Xaiomi Redmi 2
How to reproduce the bug?
http://codepen.io/danieloprado/details/ObbXdv/
Open this link on mobile

See #290

Pull Request #445

I closed this to keep only one issue, I take a look at your PR ASAP :)
Thanks!


Feature request: manually set vertical vent angle on midea ac / midea ac duo

设备类型及型号 (或SN)
midea ac duo
新功能的描述
This is a continuation of this issue from last year: https://github.com/georgezhao2010/midea_ac_lan/issues/243
in the midea app, it is possible to manually set the angle of the vertical vent on the midea 12k btu ac unit and the midea duo (i have both). I would love it if it was possible to manually set the vent direction in home assistant, as I am currently having to do it maually using the midea app.
happy to help troubleshoot or debug or run test code!

Can you please provide the device serial number?
midealocal discover should show that number.

I need the serial number to get the lua protocol file. This can be archived with midealocal discover -d command


feat: added yocto post

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Teach the SILPrinter to be more resilient to null operands.

Previously, when in the debugger and dumping out SIL code, the
printer would crash if it encountered a null operand.  If you
are dumping a basic block, this means that the dump stops at
that instruction instead of showing you the whole block.  Null
operands can happen when you call dropAllReferences() but have
yet to delete the instruction.
Now the printer is a bit more resilient.  We probably don't catch
all the cases, but we handle a lot of them, e.g.:
%116 = apply <>(<>, <>) : <>
debug_value <>, let, name "c", argno 1 // id: %120
retain_value <>                   // id: %138
Since this is only relevant to invalid IR, this is just
a debugging aid, so no testcase.

@swift-ci please test and merge


Fine-tuned model?

Hi,
Could you make your fine-tuned model available, as you did in 6DRepNet? please.
I would like to test my own datasets on your own fine-tuned model  for the comparison for narrow and full-range datasets.
Thank you in advance!

Hello,
you will find a link to the main model here: https://github.com/thohemp/6DRepNet360/blob/master/sixdrepnet360/test.py#L140
The other ones will be added soon.

@thohemp, thank you so much for your reply. This fine-tuned model for narrow range ("https://cloud.ovgu.de/s/2sP3yLrEwyfSmqC/download/6DRepNet360_300W_LP_AFLW2000.pth").
Really, I am interested in the fine-tuned model for the full range for CMU datasets.
Thanks.

I think the notation of the file is misleading. I updated the readme with both models.

Thank you so much for you updating, I got this result for CMU dataset for my own dataset:
Yaw: 7.0174, Pitch: 10.5485, Roll: 7.6579, MAE: 8.4079
Vec1: 11.5907, Vec2: 8.3935, Vec3: 11.6801, VMAE: 10.5548


Latest Master is Experimental, Use 0.18.0 for Stability

If you don't want to deal with the issues that Babel 6 introduces, please stay on https://github.com/davezuko/react-redux-starter-kit/tree/v0.18.0 until these are resolved. I'll be making a note in the README for this soon.

Closing this since there is currently a notice in the README.


Add Stack Data Structure

Implement a Stack with Common Operations, along with  documentation.

I would like to contribute, you can assign this to me. Thanks!


Size vs. components for Tucker decomposition

We can discuss this in person, but it'd be nice to have an R2X vs. size for Tucker. It's a little more complicated than for CP.

#261


Question about QuestionAnswer and SemanticSearch

Hey! Love the library, after testing it out i can really say it will save me a lot of time.
Anyways, i am not sure im posting this in the correct place, i am sorry, if so, feel free to remove the issue.
I am trying out the QuestionAnswer class, i did try to scim it a bit to understand it better, the only thing that i am uncertain of, is the actuall fetching of the files, does the AI always fetch file and look for something?
I mean, lets say i start a conversation saying "hello!", all i need from the AI is a simply reply "hey there!", but if i am using QuestionAnswer, does the AI always load the files? The files in the future will be large and have a lot of text, i would want to avoid checking the file untill its neccesary.
If the answer is yes, QuestionAnswer always reads file, should i give the Ai a function instead to use the QuestionAnswer when it needs to find something in file? Because its not always going to have to look into the file.
Also, i switched from the openai client php assistans api to this library, in my code, i save the assistant thread id in the session, so if the user goes to another page the conversation is still saved as it is still in the thread.  To achieve this with this library, im guessing i have to save the conversation to a database to continue the conversation?
Whats the best way for approaching this? Thanks!

Hey @samuelgjekic, thanks for the kind words!
The first big step is :

Read the text from your file
create smaller chunks of texts
send these chunks of text to an embedding model (like openai embedding model)
store each vectors in a vectorstore like postgresql or Qdrant

Then for each question LLPhant will :

take the question from the user,
create a vector using the same model (it's important otherwise it makes no sense)
search the 4 closest vectors in the vectorstore
use the texte from theses vectore to generate the answer

So you will need to vectorize only once all your file and it is not usually very expensive.
I hope it answers your question?
For the thread assistant, yes I haven't coded anything in LLPhant to use it directly yet. So you need to keep the thread id somewhere like in the session or a database as you have correctly guess.

Thank you @MaximeThoonsen for the quick reply!
I got a clear picture of how it works now, appriciated!
Have a nice week 🙂

If you have any suggestion on how to improve the doc, they are very welcome!