fix(influxdb): throw an error when precision has a data overflow

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
https://github.com/GreptimeTeam/greptimedb/issues/3739
What's changed and what's your intention?
update the RowInsertRequests handling logic to throw an error when data overflows the precision param value.
Checklist

[ ]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

Not needed


Zero GUID when unknwn.h is not included

Before #1180, this code successfully prints the GUID of ICompositorInterop. After #1180 it prints {00000000-0000-0000-0000-000000000000}:
#include <winrt/Windows.UI.Composition.h>
#include <windows.ui.composition.interop.h>

int main()
{
    printf("GUID for ICompositorInterop: %ls\n", winrt::to_hstring(winrt::guid_of<ABI::Windows::UI::Composition::ICompositorInterop>()).c_str());
}

C++/WinRT should just work in this case, or tell me that I need to include unknwn.h before including winrt/base.h.
Maybe the MSVC part of #1180 should be reverted, since it might not be needed? Maybe the fallback definition of guid_v should trigger an error when it's used?

Yes, this looks like a regression which would be hard to catch. I think that #1180 didn't need to "fix" MSVC behavior even if it was questionable. @oldnewthing

I had a look but couldn't find a way to get the fallback to produce an error.

How about:
template <typename T>
struct com_guid
{
#if defined(_MSC_VER) && defined(WINRT_IMPL_IUNKNOWN_DEFINED)
    static constexpr guid value{ __uuidof(T) };
#endif
};

template <typename T>
inline constexpr guid guid_v = com_guid<T>::value;

This should error because value wouldn't exist.
While the compiler error may not be the easiest to understand, it definitely beats a strange runtime error.

Sounds good! Want to send me a PR?

I can take a look sometime this weekend


Refactor proposal: replace schema.go with libvirtxml types

Is your feature request related to a problem? Please describe:
The libvirt-go-xml-module (or libvirtxml for short) provides 100% coverage to Libvirt XML schemas. We should be using that instead of incrementally duplicating that module into schema.go.
Describe the solution you'd like:
If agreed, we should stop introducing new types to schema.go and start using libvirtxml whenever possible. We should also start moving existing types to libvirtxml one. This is a considerable amount of work but should remove the need of XML parsing as it'll all be covered by libvirtxml
Additional context:
There are real technical issues related to this request. See the migratableDomXML function, which makes us parse the XML all over.

The function migratableDomXML is hard to extend for new fields that needs to be added or modified for the migrate XML. An example, where this is needed is for storage migration where we need to add the slices section (see this RFE for more details)

/cc @andreabolognani

/assign @victortoso

The libvirt-go-xml-module (or libvirtxml for short) provides 100% coverage to Libvirt XML schemas.

And this is validated by testing that the libvirtxml structs can losslessly roundtrip  xml -> obj -> xml, on all 3500 XML files in libvirt.git, so we have pretty high confidence in its behaviour.

Moving here the discussion raised by @vladikr in https://github.com/kubevirt/kubevirt/pull/10847#issuecomment-1860792379.
At the moment, I wanted to understand how much memory more would it be in comparison to KubeVirt's schema.go. The simplest way to do the comparison is to load the same XML to both data structs and do a comparison.
I created a small program to read xml from a folder and compute using go's testing.benchmark and also runtime.ReadMemStats (to see if there is a difference between both).
I've fetched all xmls from libvirt git repo, removed all the ones that were not complete (e.g: did not start with ) and ran the program with them. The resulting file is a bit big as there was 2335 xmls.
The average says that libvirtxml is 20% bigger than KubeVirt's schema.go.
I've also tested with fewer (5) but more close to real KubeVirt's use case. 4 files from virtwrap's test and one obtained by virsh dumpxml after booting the VMI.
The average says libvirtxml is 17% bigger than KubeVirt's schema.go.
Taking a single example, the domain_x86_64, libvirtxml is 19% bigger, that is, libvirtxml uses 119KiB compared to schema.go's 93KiB.

Taking a single example, the domain_x86_64, libvirtxml is 19% bigger, that is, libvirtxml uses 119KiB compared to schema.go's 93KiB.

Looking at the size of these in isolation gives an unhelpful impression of the impact.
Lets say kubevirt was managing a tiny VM where QEMU's RAM was a mere 100 MB (realistically VMs are more likely to be 1GB in size or greater), and we'll ignore everything like like EDK2 RAM, and other random QEMU memory usage.
A difference of 119kb-93kb == 26 kb. In context of the 100 MB QEMU guest RAM, this is an overhead of 0.02%, or 0.002%  for a 1 GB VM.  QEMU's RAM usage can vary by more than 26kb from minute-to-minute as it responds to guest actions.
IOW, this difference is completely lost in the background in the big picture.

@berrange I believe the idea is that this data is frequently sent back and forth between the various KubeVirt / Kubernetes components, so the additional traffic could be problematic. I don't know if 20% is enough to make a significant difference.
@victortoso thanks a lot for looking into this! I am confused by the results though. The example you have in the README, which I have replicated locally, is:
$ go run main.go --xml testdata/real-use-cases/vmi-pvc-clipboard.xml

unsafe.Sizeof() of each domain struct
 * libvirtxml: 520 bytes
 * kubevirt  : 920 bytes

compared:bytes is the percentage of libvirtxml in comparison to KubeVirt
e.g: Value: 111, means livirtxml's domain struct is 11% bigger than KubeVirt domain struct

                                         |                     | <------- libvirtxml ----> | <-------- kubevirt -----> |
                                         | compared: bytes (%) |  benchmark  |   runtime   |  benchmark  |   runtime   |
                                filename | benchmark | runtime | KiB | alloc | KiB | alloc | KiB | alloc | KiB | alloc |
                   vmi-pvc-clipboard.xml |       111 |     111 | 113 |  2970 | 113 |  2970 | 101 |  2867 | 101 |  2867 |
                                         |                     | <------- libvirtxml ----> | <-------- kubevirt -----> |
                                         | compared: bytes (%) |  benchmark  |   runtime   |  benchmark  |   runtime   |
                                filename | benchmark | runtime | KiB | alloc | KiB | alloc | KiB | alloc | KiB | alloc |

The average size of Libvirt : 113 KiB
The average size of Kubevirt: 101 KiB
In average, libvirtxml is 111 % compared to Kubevirt

If I'm reading that correctly, the actual struct size for libvirtxml is 57% the size, but somehow the amount of memory allocated while producing it is 111%? The first number intuitively doesn't make sense to me, as we surely are storing more information in the libvirtxml case, not half of it... So maybe we're just not implementing parsing as efficiently as possible, and there's room to improve that in a way that would benefit not just KubeVirt as potential consumer of the API, but other existing consumers as well?

If I'm reading that correctly, the actual struct size for libvirtxml is 57% the size,

Yes. libvirtxml uses a lot of pointers, while schema.go doesn't. For an empty struct, that means libvirtxml is lighter.

but somehow the amount of memory allocated while producing it is 111%?

After loading the Domain XML, libvirtxml uses a little bit of memory, which makes sense if they don't discard anything while schema.go does.
The 111% is computed based on schema.go memory. So, in reality it is 11% more than schema.go

@berrange I believe the idea is that this data is frequently sent back and forth between the various KubeVirt / Kubernetes components, so the additional traffic could be problematic. I don't know if 20% is enough to make a significant difference.

For data transfer, surely the serialized document size is what matters, not the in memory structs for the parsed doc.

Yes. libvirtxml uses a lot of pointers, while schema.go doesn't. For an empty struct, that means libvirtxml is lighter.

This seems to indicate that the value you're reporting only considers the "shallow" memory usage. If we want to make a fair comparison, we need to know the "deep" memory usage is, that is, including all data pointed to through however many levels of indirection.

For data transfer, surely the serialized document size is what matters, not the in memory structs for the parsed doc.

Right. But if libvirtxml deserializes/serializes the original document more accurately, that ought to increase the amount of data that ultimately travels on the wire.
I think we really need @vladikr to clarify what numbers are relevant to his concerns in order to make a useful assessment of the impact switching to libvirtxml would have.

We could improve the data transferred by removing the data that aren't interesting for KubeVirt (by setting to null the pointer).
Today, the filtering is achieved implicitly because KubeVirt structs don't define all the fields. IMO, it would be better to have this done in an explicit way rather then loosing data with the marshaling.

We could improve the data transferred by removing the data that aren't interesting for KubeVirt before the serialization (by setting to null the pointers).

That could be a neat idea! I would however make sure that unnecessary fields are emptied right after deserialization instead. This would ensure that the KubeVirt logic only ever deals with structs where fields have been emptied; doing it the other way around might result in accidental loss of information.
Of course we should only really consider doing this if the additional overhead is really found to be unbearable. If that's not the case, simplicity beats raw performance IMO.

We could improve the data transferred by removing the data that aren't interesting for KubeVirt before the serialization (by setting to null the pointers).

That could be a neat idea! I would however make sure that unnecessary fields are emptied right after deserialization instead. This would ensure that the KubeVirt logic only ever deals with structs where fields have been emptied; doing it the other way around might result in accidental loss of information.
Of course we should only really consider doing this if the additional overhead is really found to be unbearable. If that's not the case, simplicity beats raw performance IMO.

Sure, my point is that we can solve the memory overhead if this is really a concern.

I have not seen evidence that we are optimizing for memory usage too much, nor that we got feedback of it from the field. If there is such feedback, please do share it.
The traffic that carries this information is in-node. Could you please clarify how a few 10 kilobytes will have any effect?
I find the option to offload maintenance of the schema to a dedicated project valuable for the long run.
This suggestion will benefit both projects.

I had a quick offline discussion with @vladikr about this yesterday and he raised another concern. Vladik, please correct me if I misunderstood.
At the moment, by relying on a subset of libvirt fields, this gives to KubeVirt some control over what features we are using from libvirt. It makes easier to check and supervise. It would be easy to see a patch adding/changing libvirt domain.
By moving to libvirtxml, there would be less control, it makes it a little harder to tell which features are being used.
Overall, schema.go is used internally and we set it based on KubeVirt's API.
I think this concern is still solvable if really needed, just not sure on how to tackle it yet.

How about this: We use both.

Target the custom one we use today to be used for virt-launcher <--> virt-handler communication.
Target the libvirtxml one to direct communication with libvirt.

virt-handler will not know about the full libvirt schema, only on the current custom one.
virt-launcher will know about both, using the custom one to send information to virt-handler.
I think this will solve both concerns and will allow us to reduce the size of the custom spec we use today. Something that was discussed in the past as well. Reducing memory, decoupling from libvirt config...

@victortoso , do you think we can proceed to implement this? Was there a blocker?

/remove-lifecycle stale

@victortoso , do you think we can proceed to implement this? Was there a blocker?

Not really a blocker but deciding on how to achieve that in a non disruptive way. I'd like to start with the usage of libvirtxml when calling the hook sidecars so we can solve a known problem of dropping user's settings on subsequent hook calls (what was described here https://github.com/kubevirt/kubevirt/pull/11324). I plan to come back to this now.
My expectation is that this issue is not a small one and will lead to several PRs.

/lifecycle frozen


code centralization: update accordion, feature card, card grid components

The accordion, feature card, card grid components are currently used in both headless cannabis and drought sites. The code required to render it should be published to npm with a readme describing the module and the required package files. The code for the component should be checked into the design-system repository and deleted from the cannabis and drought repositories. The feature should be used in both sites via npm install. All sass variables not defined inside this component should be replaced with css variables. These variables should be defined in the site code that installs this component
This is a first step towards making this component a member of the design system. We are publishing it in a central location now to prevent code drift.

The hero component in the design system has been renamed feature-card and the styles are updated based on latest headless cannabis css
The card grid styles are updated based on headless cannabis and published to npm.
A sass compilation bug where it complains when we use css min function because that is also a sass function solved by adding calc
Open PR for these changes which deletes this code from cannabis: https://github.com/cagov/cannabis.ca.gov/pull/294
Open PR for changes to add these updated components to design system: https://github.com/cagov/design-system/pull/38


add testing framework

This PR brings a testing framework for unittests, inclunding CI. More tests to come. These tests work as expected locally on my machine. Lets see what the CI does.

Explanation on testing framework:

Tests are automatically performed for each pull request and for each push to a branch.
Tests can be performed locally using py.test GCMtools (when you are in the folder that contains GCMtools)

The setup of the tests is defined in tests/test_gcmtools_common.py where the handling of the test datasets is done. This can be easily extended to more experiments, for example, when we support more gcms.
The actual tests are then performed in the individual test_* files. Currently there is only a very limited test in test_gcmt.py. We can of course always add on top of that.
Credits: The people from xmitgcm. This framework is basically just adapting theirs.

The changes looks good and I'm happy to see that testing seems to work. I agree with the codecov that we should aim to have a coverage of 95%, especially since this will be the basis of (maybe) a much larger framework. Let me know if you need help setting up the tests!

Yes that would be the goal. However, some stuff is difficult to test. One example being the plotting routines. It needs to be decided if those can be excluded from testing coverage.

Furthermore, it might be useful to also think about style guides like pylint and pycodestyle. I find them often helpful even if they are not fully enforced. I know you can set them up similar to codecov but never did it myself before.

I agree! Its easy to add them. We just need to find a repo, where someone did this already :D

Yes that would be the goal. However, some stuff is difficult to test. One example being the plotting routines. It needs to be decided if those can be excluded from testing coverage.

Understandable and its definitely not our top priority. I still think it is worth putting in the effort but we can also add this at a later time when we have time.

I agree! Its easy to add them. We just need to find a repo, where someone did this already :D

I know them from here: https://github.com/PynPoint/PynPoint

Understandable and its definitely not our top priority. I still think it is worth putting in the effort but we can also add this at a later time when we have time.

I totally agree! If you have good ideas for tests, please fell free to extend the tests! I will certainly add some more, when I have a good idea for a test.
Should we get this PR merged first, to have a testing base?
Should I exclude the plotting from cov?

Should we get this PR merged first, to have a testing base?

I think that's a good idea.

Should I exclude the plotting from cov?

No, we should only exclude it if we don't want it to be tested, otherwise I'm gonna forget to add tests for it.


table functions to work with empty tables

I have this utility function for the moment:
emptyTable <- function(type) {
  x <- dplyr::tibble(`Table has no data` = character())
  switch (type,
    "tibble" = x,
    "gt" = gt::gt(x),
    "flextable" = flextable::flextable(x)
  )
}


Update BatteryHealth.json

Fix for battery_level at 0 for a long time.

Hope will improve behaviour for some users.

Related with issue

Great catch! Thank you.


Fix fields that take a null value in OSS yaml files

In this commit I made the following changes:

I replaced fields that contain null values with valid data
I fixed some admincodes in the federal.yaml file
change the started field with created field
The projects where I dont find contact email I remove them
the project where the created field is empty, I set the date of the metadataLastUpdated fields and I updated the metadataLastUpdated date to today's date

Related #170

Where we have a contact email and we're only missing name, description and started date, I would like to keep them and try to get the information.  I don't want to delete things that we know about and use (like RocketChat), just to add them back later.  Also if someone took the time to add data I'd like to keep it and try to get it updated.
Most of the APM data will be removed and that's good!

Also fixes #175


[Suggestion] QoL feature - static enchantment XP cost.

I propose to make enchanting at enchantment table cost for level X fixed at value XP(level X) - XP(level X-3)
Example:
if I enchant item at lvl200 and have xp exactly for level 200, enchanting would substract that much xp so I'll left with 197 level.
But if I do same enchant at level 1000, I will end up at level 997 (and lose a lot of xp - difference between 1000 and 997 level).
Because it's very easy to place some king of experience obelisk and dump extra levels before enchanting, I'm suggesting this quality of life feature to only substract experience equal to level of enchanting, regardless of player's current level.
Same can be done with reforging table

Shouldn't this be already the case?
(When you enchant sth. you get displayed the actual (raw) experience cost)
This also applies to the reforging table
(It doesn't show the actual (raw) cost but you don't lose x levels)
Cost is independent from player level:
https://github.com/Shadows-of-Fire/Apotheosis/blob/bb5c866fdf03bcddea130dff56df6f1fd73df437/src/main/java/dev/shadowsoffire/apotheosis/ench/table/RealEnchantmentHelper.java#L28-L47
The calculated cost is then passed as level for this part:
https://github.com/Shadows-of-Fire/Apotheosis/blob/bb5c866fdf03bcddea130dff56df6f1fd73df437/src/main/java/dev/shadowsoffire/apotheosis/util/ApothMiscUtil.java#L8-L28
And charged here:
https://github.com/Shadows-of-Fire/Placebo/blob/eb42ba8e88a83f66c1c4413c9f1e4eb61214dca4/src/main/java/dev/shadowsoffire/placebo/util/EnchantmentUtils.java#L18-L29
    public static boolean chargeExperience(Player player, int cost) {
        final int playerExperience = getExperience(player);

        if (playerExperience >= cost) {
            player.giveExperiencePoints(-cost);

            // Due to rounding errors, the bar can get stuck displaying nothing when it should be empty.
            if (getExperience(player) <= 0) player.experienceProgress = 0F;
            return true;
        }
        return false;
    }

Yeah this is already a thing (and has been so for a while now).


Add license

It would be good to add a license! @ewanbarr and @pravirkr any opinion on this? I would suggest MIT/BSD license.
Related: https://github.com/telegraphic/numbits/issues/3

yeah, I think MIT is the simplest one.
@ewanbarr I could not find any license in the original repo. What do you suggest?

Ok, going ahead with the MIT license.


Conflict with Sophisticated Storage

Hello, I created a modpack (PXC Cobblemon) and have a server running. I have a user reporting an issue and possible conflict with the Sophisticated Storage mod. They hooked up a Tom's Simple Storage interface on a Sophisticated Storage Controller which caused all of the items they put it to delete. Not sure who's mod it could be so sending to both githubs :)
Modpack: PXC Cobblemon
Fabric 1.20.1
Fabric 0.16.5
TSS 1.6.8

This was on Sophisticated Storages end. Dev reported a fix will come out in next update. Closing this now.


Set up dvc

Copy data to CPPM
Initialize DVC
Set up multiple remotes:

local (to be used on the CPPM machine)
ssh (to write to the remote storage, but requires an account on CPPM)
http (read only but no restriction)

Sorry, I missed your question.
Apparently dvc creates a .gitignore in all target directories and this behavior is not configurable... (you may prefer to have all ignored files in the main .gitignore).
So for the .dvc/.gitignore these are simply working files/directories of dvc that you do not want to track with git.


ui: use executable template filter for users

Problem: When reinstalling a VM, the UI only shows featured templates and not all possible list of allowed templates.
Root Cause: The list of templates for reinstall used featured as filter in ‘listTemplates’ API which did not include all available options.
Solution: The issue is fixed by using the executable template filter of the ‘listTemplates’ API to list all
possible templates that a user is allowed to use to deploy a VM.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

@blueorangutan test

@PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan package

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2633

@rhtyd can you please confirm this has been merged in master (4.13) as well ?

Yes @borisstoyanov

LGTM


sudo -i in run-as-user breaks WORKDIR for containers

Your recent change to this:
https://github.com/mkenney/docker-scripts/blob/5e79644a8170c062be773f8c1a9679e70193bdba/container/run-as-user#L55
broke some of our builds as we are using the npm containers. The sudo -i changes the directory to be /home/dev/. Before it used to be /src/

Hi @smelchior,
That's correct. There is an issue with yarn (and possibly other tools) in the debian images, in order to get a recent version of yarn installed in debian you need to use the installer from yarnpkg.com which places the executables and associated metadata in the user's home directory (instead of /usr/local/bin) and adds the path to the .bashrc file.
Without the -i flag, sudo will not source the .bashrc file so yarn isn't available in the dev user's path. The fix is to add the -i flag and move the logic for dropping into /src into the user's profile.
All of the images have been updated, though there was a short gap last night where a build could have been produced without the extra logic, but I thought I had caught them before they went out.
Regardless, all the Dockerfiles have been updated and all tests are passing with the updated run-as-user script. I've kicked off new builds in Docker Hub to make sure any "bad" images get updated. When those are finished, you should be able to just pull the updated image and things should work normally.
Please let me know if you still have any trouble, thanks!

Oh, and this is how that problem is solved if you're building your own images:
https://github.com/mkenney/docker-npm/blob/master/node-debian/Dockerfile#L79

Hi @mkenney!  Thanks for your detailed explanation 👍! I pulled the image again and that fixed it, so i guess i was just a bit unlucky to pull during the transition time.


Cause a transaction to roll back

I've been trying to force a transaction to rollback given a certain condition. I noticed there isn't an equivalent function to condemn from hasql-transaction, so I tried to just issue a ROLLBACK from within TransactionIO. It actually worked just fine, but I've been getting a there is no transaction in progress warning, which is a little perplexing since it definitely did rollback a transaction. So I guess I was just wondering if there's a recommended way to do this with the library. Thanks for publishing this package!

Hello! Thanks for trying out the library and filing my first issue! If I had to guess what is happening, I think that you are ending the transaction with your ROLLBACK, but then the library is ready to end the transaction it doesn't know that you already ended it, so it tries to end it again, giving that warning. The recommended way to rollback (right now) would to throw an exception from inside your TransactionIO. This triggers completion of the transaction via a rollback here https://github.com/andremarianiello/hasql-transaction-io/blob/e5a289f2a3283e620a571dc0b2c15d7b5983a54c/library/Hasql/Private/TransactionIO.hs#L74. Do you like this approach? If not I may be able to add a condemn function.

Oh, that makes a lot of sense. Throwing an exception works just fine for my purposes, so I can definitely take that approach!
A condemn function might be a nice addition, but I imagine that wouldn't be trivial to implement. I suppose you'd need something like a StateT to track whether the transaction was rolled back?

Glad to hear it! I will keep this ticket open to remind me to look into condemn or in case throwing an exception doesn't work for you.

As I can see ReleaseException is deprecated and it's recommended to use ReleaseExceptionWith SomeException

it would be nice to have a function in package, instead of manually defining:
-- | Aborts 'TransactionIO'
condemn :: TransactionIO a
condemn = throwIO ReleaseException

instance Exception ReleaseType

@andremarianiello I can see you've created a PR. Many thanks!
while implementing my own version, I've noticed a strange behaviour.
-- | Runs 'Sql.Transaction'. In case of error in any step of execution - it will rollback.
runTransaction :: With env m => Sql.Transaction e a -> m (Either e a)
runTransaction (Sql.runTransaction -> tx) =
  withFrozenCallStack
    ( runDb
        . transactionIO Serializable ReadWrite Deferrable
        $ runExceptT tx
          >>= either (\e -> Sql.condemn >> pure (Left e)) (pure . Right)
    )
{-# INLINE runTransaction #-}

It runs ExceptT and in case there was some domain level errors - it will rollback transaction and return an error.
Note, that Sql.Transaction defined like this:
newtype Transaction error result = Transaction
  {runTransaction :: ExceptT error TransactionIO result}
  deriving newtype (Functor, Applicative, Monad, MonadIO, MonadError error)

Later - I'm checking that Either in return type, log that error and return appropriate http response.
So, when I'm using condemn - my logs is like this.
[Info]    [18 May 2023 10:44:36.909 +00:00] [Context.Domain.Security.Logic.RequestCode.requestCode#59] [ThreadId 17] ... requested Otp to sign in
ReleaseException

and without condemn
[Info]    [18 May 2023 10:52:07.283 +00:00] [Context.Domain.Security.Logic.RequestCode.requestCode#59] [ThreadId 17] ... requested Otp to sign in
[Info]    [18 May 2023 10:52:07.291 +00:00] [Context.Domain.Security.Logic.RequestCode.requestCode#66] [ThreadId 17] ToManyRequests 177
POST /signIn/request
  Request Body: {
  "email": "..."
}
  Accept: application/json;charset=utf-8
  Status: 429 Too Many Requests 0.009413s

I understand that here some specific implementation involved, but I suspect that TransactionIO do not catch exception properly, or I might be doing something wrong...

I solved it like this:
runTransaction :: With env m => Sql.Transaction e a -> m (Either e a)
runTransaction (Sql.runTransaction -> tx) =
  withFrozenCallStack
    ( runDb
        . transactionIO Serializable ReadWrite Deferrable
        $ runExceptT tx
          >>= either (\e -> Sql.condemn `catch` \(_ :: SomeException) -> pure $ Left e) (pure . Right)
    )
{-# INLINE runTransaction #-}

But it would be at least export CondemnTransactionException so I can use instead of SomeException.

the best I can do here is define my internal errors as exceptions, in runTransaction just throw internal error as exception and at another layer - catch that exception and turn back to either...

Thanks for the feedback @worm2fed ! According to this comment you wanted a condemn function that simply throws an exception, but I sounds like that behavior is not exactly what you want. Could you summarize how you think condemn should behave?

Sounds like you have the best solution for your use case! Thanks for sharing :+1:


Added terms needed for RHEA import

New terms start at line 22 with 'narbomycin'.  Generated the term list by querying RHEA RDF for any chebi term referenced in a reaction (found 9180) and then removing (1082) any chebi terms already in GOPlus (got list from ELK request for subclasses of 'chemical entity'.  By my count, GOPlus currently contains 5727 CHEBI terms.  This import would add 8098 new CHEBI terms.

Sweet. @hdrabkin will run the import on Monday. Progress!!!!

So what Ben had me do was make a new branch (harold_import) and copy the three files into it. It appears that this branch was about 300 commits behind the master. We did a run locally on my machine and the make appeared to have worked. So I then committed and pushed the 3 new files from the new branch (harold_import)

see #16651


Code variables updates

Closes #98
Fixes #100

Adds always present variables to the UI
Fixes some of the odd and unnecessary scrollbars on pages with code
Standardizes the display for variables and always puts them on the right side of the code
Prevents users from naming variables CurTime, RunIdx, ExePath, or ExeExitCode

If I try to make a new variable I get this.

line 26 of VariableEditor.js


Latest version on Cocoa pods incorrect?

Why is the latest version on github 1.0.2 but the latest version available on cocoa pods 0.9.15?

I got this question to.
The cocoa is not updated ?

In addition, we see a compile error when building with cocoapods -
 The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.4.99.

I believe this can be fixed by just adding to the podspec -
s.platform = :ios, '13.0'

-Thanks!

it's because the podspec file is invalid
[!] Failed to load 'libPhoneNumber-iOS' podspec:
[!] Invalid `libPhoneNumber-iOS.podspec` file: syntax error, unexpected '<'
<!DOCTYPE html>
^

you can directly point to the git in the meantime till somebody fixes it
pod 'libPhoneNumber-iOS', :git => 'https://github.com/iziz/libPhoneNumber-iOS'

This won't work if you are using spec.dependency unfortunately. It only works in a Podfile, not a podspec 😞

Any progress about this? All users of this great library would love to see the latest changes available through CocoaPods.

HI! Is this abandoned?


[Event Request] codeunit 5812 "Calculate Standard Cost" - OnCalcProdBOMCostOnBeforeCalcCompItemQtyBase

Describe the request
local procedure CalcProdBOMCost(MfgItem: Record Item; ProdBOMNo: Code[20]; RtngNo: Code[20]; MfgItemQtyBase: Decimal; IsTypeItem: Boolean; Level: Integer; var SLMat: Decimal; var RUMat: Decimal; var RUCap: Decimal; var RUSub: Decimal; var RUCapOvhd: Decimal; var RUMfgOvhd: Decimal; var ParentItem: Record Item)
....
    with ProdBOMLine do
        if Find('-') then
            repeat
                OnCalcProdBOMCostOnBeforeCalcCompItemQtyBase(
                  ProdBOMLine, ParentItem, CalculationDate, MfgItem, MfgItemQtyBase, IsTypeItem, CompItemQtyBase, RtngNo, UOMFactor);

                CompItemQtyBase :=
                  UOMMgt.RoundQty(
                    CostCalcMgt.CalcCompItemQtyBase(ProdBOMLine, CalculationDate, MfgItemQtyBase, RtngNo, IsTypeItem) / UOMFactor);

....

end;
[IntegrationEvent(false, false)]
local procedure OnCalcProdBOMCostOnBeforeCalcCompItemQtyBase(var ProdBOMLine: Record "Production BOM Line"; var ParentItem: Record Item; CalculationDate: Date; MfgItem: Record Item; MfgItemQtyBase: Decimal; IsTypeItem: Boolean; var CompItemQtyBase: Decimal; RtngNo: Code[20]; UOMFactor: Decimal)
begin
end;

Additional context
Parameter ParentItem is from a previous request https://github.com/microsoft/ALAppExtensions/issues/25597Internal work item: AB#494741

Hello @Duizy1971
Please review request as ParentItem does not exist as a variable.
Be aware that new publishers we add just in the latest version BC23.

Request https://github.com/microsoft/ALAppExtensions/issues/25597 is required first. That will give the ParentItem. I tried not to put everything in one issue, but issues must be done in order of request ID please.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15085.


SAK-41362: Checkmark assignments only works on English language

This is another version of #6570, only merge one of them.

@ern This is a new version


[9.x] UUID and ULID support for Eloquent

This PR brings UUID & ULID support for Eloquent as primary keys. By simply applying a trait, any Eloquent model will have a UUID or ULID generated as their primary key.
For ULID support, an optional symfony/uid dependency will need to be pulled in.

@driesvints Awesome PR - I was just thinking about using ULIDs in my next project.
Yesterday Symfony added UUID v7 (which is similar to ULID) support (https://github.com/symfony/symfony/pull/47525) to symfony/uid. Would it be possible to add an option to choose whether we want UUID v4 or v7 (as currently Str::orderedUuid() always returns a v4 UUID) ?

HasUlidPrimaryKey and HasUuidPrimaryKey might be better names than HasPrimaryUlid and HasPrimaryUuid.

Yesterday Symfony added UUID v7 (which is similar to ULID) support (https://github.com/symfony/symfony/pull/47525) to symfony/uid. Would it be possible to add an option to choose whether we want UUID v4 or v7 (as currently Str::orderedUuid() always returns a v4 UUID) ?

I'm not sure. We don't use symfony/uid for UUID's but ramsey/uuid. It does not seem that library has support for v7 yet. It also does not seem Str::orderedUuid() has support for specifying the type of UUID so I don't think this is possible?

HasUlidPrimaryKey and HasUuidPrimaryKey might be better names than HasPrimaryUlid and HasPrimaryUuid.

Done

Just came here to say that ULID will be saved into the database as a 26 character string, which occupies 208 bits, almost double than an UUID (128 bit).
If the column is an UUID, most database engines will return an error.
What it could work is setting the key type to "uuid", so then the primary key is detected as an ULID, it will change to RFC4122.

Yesterday Symfony added UUID v7 (which is similar to ULID) support (symfony/symfony#47525) to symfony/uid. Would it be possible to add an option to choose whether we want UUID v4 or v7 (as currently Str::orderedUuid() always returns a v4 UUID) ?

I'm not sure. We don't use symfony/uid for UUID's but ramsey/uuid. It does not seem that library has support for v7 yet. It also does not seem Str::orderedUuid() has support for specifying the type of UUID so I don't think this is possible?

It seems like ramsey/uuid now has support for v7: https://github.com/ramsey/uuid/releases/tag/4.5.0

I'll look into it 👍

Maybe creating a ulid() macro for the migrations would be nice too.
Currently I'm adding the following macro to the AppServiceProvicer:
Blueprint::macro('ulid', function (string $column = 'ulid') {
    return $this->addColumn('char', $column, ['length' => 26]);
});

Which enables me to do this in my migrations:
Schema::create('users', function (Blueprint $table) {
    $table->ulid('id')->primary();
    ...
});

Awesome! Just this week i'd created a trait that used Str::orderedUuid() exactly like this. Great to have this officially supported inside Laravel

@larskoole I'll also check into that.

@driesvints  Could we have an option to set which column to be the uuid?
For example, we could keep the default behaviour of looking at the primary key but it would be nice to have something like getUuidColumn function or something like that inside each Model to override that default behaviour.
Potential usage:
table: users
id (auto increment to be used for relations) | uuid

@driesvints Could we have an option to set which column to be the uuid?
For example, we could keep the default behaviour of looking at the primary key but it would be nice to have something like getUuidColumn function or something like that inside each Model to override that default behaviour.
Potential usage:
table: users id (auto increment to be used for relations) | uuid

Already there, you can override the uniqueIds() method from the trait inside of your model.
https://github.com/laravel/framework/pull/44074/files#diff-0dbc036e590312e780e3fac6936e57aa9628b31679dd979e098cd73fc34d85cfR35-R43

If someone wanted to use this for columns other than the primary id and updates uniqueIds() to not contain the primary key, the getKeyType() and getIncrementing() shouldn't be overriding. We'll need to PR a fix for that.

If someone wanted to use this for columns other than the primary id and updates uniqueIds() to not contain the primary key, the getKeyType() and getIncrementing() shouldn't be overriding $this->keyType and $this->incrementing. We'll need to PR a fix for that.

I'll think about that a bit more as well.

Worked on some of the above stuff here: https://github.com/laravel/framework/pull/44146. I'll check into UUID v7 support later.

@driesvints @taylorotwell I added missing morphs methods for ULID support :point_right: PR 44364 :blush:


Column offset 1 to 0 correct calculation.

Correctly calculate the offset from a 1 to 0 column offset for setting the aura icons in the correct position.

Rainrider also mentioned this.


Personal token validation in options page doesn't work for GHE

Description
A minor issue, validation of personal token in options page doesn't work for GitHub Enterprise, even if a valid token is inputed and features do actually work, it still shows as "Bad credentials":

The cause seems to be the validation still (mistakenly) being done via api.github.com on GHE:

How to replicate the issue + URL
chrome://extensions/?options=hlepfoohegkhhmjieoechaddaejaokhf 🤷
Extension version
24.6.2
Browser(s) used
Chrome

Should be fixed by https://github.com/refined-github/refined-github/pull/7388 in the next release

Should be fixed by https://github.com/refined-github/refined-github/pull/7388 in the next release

Ah yes, was just looking at related code and wondering how could this bug exist. Guess I was absent from developing RGH for too long and forgot to test on main first 😂
I will close this and link the PR.


Update gcp_k8s_cron_job_created_or_modified.yml

Background
RuleID: "GCP.GKE.Kubernetes.Cron.Job.Created.Or.Modified"
I believe there's an issue with the value of the field MITRE ATT&CK:
MITRE ATT&CK:
- T1053.003
It should instead be:
MITRE ATT&CK:
- T1053:003
This is the customer ticket where this behavior was reported (Sigma): https://app.intercom.com/a/inbox/pgh5h4rf/inbox/view/95792/conversation/186787800017876?view=List
Changes
I believe there's an issue with the value of the field MITRE ATT&CK:
MITRE ATT&CK:
- T1053.003
It should instead be:
MITRE ATT&CK:
- T1053:003
Testing
Steps to reproduce:

Created a clone of our original rule "GCP.GKE.Kubernetes.Cron.Job.Created.Or.Modified" , with ID GCP.GKE.Kubernetes.Cron.Job.Created.Or.Modified.Cloned.By.Christina in illustrious-seagull (Panther TSE Instance).
Ingested via an S3 log source an event I created, in order to trigger an alert for this rule. I am attaching it here.
The alert that was created has an issue, as shown in the attached screenshot. It says "the associated rule has been deleted" and shows None in the MITRE ATT&CK technique, even though the rule had a value there.
Then, I changed the field MITRE ATT&CK to MITRE ATT&CK:T1053:003  , using : instead of ..
The alert was then corrected and showed valid information and no error messages, as you'll see in the second screenshot.
gcp_kubernetes_event.json

This is the standard format we use for all MITRE ATT&CK tags in the repo (here is another example).  The standard format is TACTIC:TECHNIQUE.subtechnique.  It looks like the UI does not properly handle sub-techniques.  This should be logged as a FR.


Error NPM Installing when using Docusaurus 2.4.1

Description
The package.json has all docusaurus components hardcoded to 2.4.0, not allowing to upgrade to the recent release of 2.4.1
Steps to reproduce

In any package that uses typesense/docusaurus-theme-search-typesense, upgrade docusaurus to 2.4.1
run npm install or yarn install

Expected Behavior
npm/yarn install works
Actual Behavior
npm/yarn install throws error
example npm error
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@docusaurus/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
Metadata
Typesense Version: 0.11.0
OS: MacOS 13.3.1

I just published v0.12.0-0. Could you upgrade to this version and let me know if that fixes the issue?

@jasonbosco That solved it, thanks!

Great, thank you for confirming!


⚠ Bofrost.lu has degraded performance

In e1ccba0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2047 ms

Resolved: Bofrost.lu performance has improved in 5e915c8 after 6 minutes.


Stopped working after upgrade to Safari 14.0 and iOS 14

Hi,
Our implementation has been stable and working for years.
But after upgrading to latest Safari on Mac and latest iOS on iPhone the plugin does not work correctly anymore.
This is how it looks in our app and when we visit the demo page:
https://serratus.github.io/quaggaJS/examples/live_w_locator.html

Beta1 works fine...

Found the problem:
aspectRatio: {min: 1, max: 100},
If I remove that line, everything works... Why is this now broken?

This is making me think that iOS 14 is responding unexpectedly, and quite possibly incorrectly, to the constraints requests passed in by getUserMedia.  @Tezting do you have any other constraints in your config?


Setup firebase for the application

What happened?

Setup firebase application using singleton pattern
Add firebase context to be used in application

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add assessment

Added assessment to the patient view. In order to see it you need to download the 2017 bundle, use CMS 2v7 and select the patient that is Z5 BH Adult. You will see the assessment tab populated.

Just needs to get rebased with merge conflicts resolved @laclark22


Callback in hand tracking when no hands are in the input frame

OS Platform and Distribution Android 10
Solution : Hand tracking solution from mediapipe
Programming Language and version: Java

Callback in hand tracking when no hands are in the input frame
How to identify when there are no hands in the input frames.
When the hands are in input frame the "hand_landmarks" callback is called with the proper data, but when the hand moves away from input frame there is no call back or any sort of information. Should some timer be implemented when there are no callbacks and assume no hands are in input frame or does mp has anything inbuilt?
Tried "palm_detection" callback, but when there is no hand in the input frame, there is no way to know.
Seem such thing is possible in the python, but this is being tried in Java.
Any inputs is appreciated.
Thanks in advance.

Hi @ravikumar-ramamurthy, You can try this similar approach for hands.

@sgowroji Thanks for this link. I tried the same approach and it worked..
Thanks again


[22.11] Backport trackma: 0.8.5 -> 0.8.6

Description of changes

Backport of #253623
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

22.11 is EOL, so no new commits are allowed, sorry...

So sad, I'm still using it for some reason!


Normalize release version

I'm not sure how the text release version got into the following line
https://github.com/DIDEO/DIDEO/blob/87b68e7408ff4ef6af6ec8fd62e0b5c8dbff7c2e/dideo.owl#L38
but it is irrelevant and means that the version, currently interpreted as release version 2022-06-14 does not match with the release IRI
https://github.com/DIDEO/DIDEO/blob/87b68e7408ff4ef6af6ec8fd62e0b5c8dbff7c2e/dideo.owl#L18
which would have to read <owl:Ontology rdf:about="http://purl.obolibrary.org/obo/dideo/release/release version 2022-06-14/dideo.owl"> to be consistent.
This pull request removes the extraneous text release version from the text in the <owl:versionInfo> of the release file to address the issue..
Further, I wondered how the text within the <owl:versionInfo> tag gets there from the development version - is it manually synced, or is there a build scrip that updates the release file from the development file?

I am not entirely sure I understand what you mean. To be precise what the "This" in the first line refers to and what the "it" in the second line refers to. I am sure we can work it out.

Hi @mbrochhausen, thanks for getting back so soon. I updated the text for this PR to better answer those questions

Thanks, that is much clearer.
The files are curated manually and that ontology metadata annotation is updated manually whenever a new release version is created from development. I am not sure how the IRI got messed up, part of that is an automatic process where the IRI is created when the GitRepo gets tagged. I am in contact with my programmers (one of which set up the process) to find out what happened.

Thanks for checking in @jmwhorton. I took a look at the link and I don't think the changes will have a big effect. I didn't touch the development ontology file.

It appears the release version string has been fixed somewhere else, this PR is now not needed


[Qt] [macOS] Mute button's 'M' character was partially hidden

commit: https://github.com/zhang-ray/easy-voice-call/commit/d293868ef33c213a2322ebe89eb1f9e7bf1736f5
Mute button's 'M' character was partially hidden in macOS 10.14:

In mainwindow.ui file, "toggleButton_micMute" (QPushButton) didn't describe the font size of "text".
App's looks and feels didn't consistent acrros different Operating System.  Maybe the inner margin of this QPushButton is platform-dependent...

Keeping the same looks and feels across all platforms is not an easy work by Qt framework.
Won't fix.


OG-USA logo proposals

@jdebacker. I wanted to start a discussion about OG-USA logo proposals. Here is my first offering.
The short version

The long version

Took me a second to get the OG reference in there, but I like the short version!  Don't think we need that longer version with subtitle.  Thanks @rickecon for taking a stab at this.

Do you want me to put some color in the circles, change any sizes or proportions or fonts? I want this logo for C/S as well as any other marketing that we do with it.

@jdebacker Here are two variations with red circles.

@rickecon Go Dawgs!
While I am partial to those colors given my undergrad alma mater, Maybe we need some red-white-blue scheme for OG-USA?

@jdebacker Here are two options with red white and blue. I like this first one with the flag in a top circle, surrounded by five neutral-color circles that would be the same for any country.

This second option is a little bit over-the-top with red, white, and blue circles. I don't like this second one very much.

I like the flag ones, but I don't know how that detail will show up on different sized versions of this.  If we can retain more detail than in the images above, I'd feel better about it.  Here's a version without the colored dots that I like:

I also don't mind the red/white/blue dots with white background that you have above.

@jdebacker . Alright, finalists. So the two logos in the right column were your favorite and the two logos in the left column were my favorite. In truth, I could be happy with any of these four logos.

Now, seeing them all together, if I had to rank order my preferences for those four (1=favorite, 4=least favorite), I would choose the following.

(upper left) Flag circle with neutral blue fill in the other five circles with white background. I like the neutral blue color. I think it would be good to have some color that can be constant across models.  I like this one. My only complaint is the white background in the five non-flag circles.
(lower left) Flag circle with neutral blue fill in the other five circles with black background. I kind of like the black background, but really only as an alternative to the white background.
(lower right) I don't love the red/white/blue dots logo. It looks a little too colorful to me. The colors seem too prominent.

For different economy versions of the model (country and state), we would change the three-letter country code (or two-letter state code) at the end of the model name and add either a circular version of that country's (state's) flag in the three flag option logos or the colors of that state's flag inside the circles of the lower left logo.
I am happy to go with whatever logo is @jdebacker's top choice, but I would like to see @jdebacker's preference ordering and compare it with my preference ordering and try to choose the one that maximizes the sum of our welfare.

Agree about potential for too much color.  Here's one that tones it down a bit:

OK. In discussion with @jdebacker, we have agreed for now to use the logo below for OG-USA. We decided to remove the border. We can replace this logo in the future, but for now we are moving ahead with this.

One note and question for @jdebacker. The GitHub suggested template for a logo (called "social preview") is the following. For our GitHub logo that gets shown for any social media links do we want to include the descriptive text below the logo as we tried in the second image in the first post of this issue?

Also, this suggests that we should have a GitHub version of our logo with a 40pt border around it so that nothing gets cropped--regardless of whether or not we include descriptive text.
This is what it currently looks like in Twitter when we provide the link to the repository (link to tweet).

This logo with text underneath would be the following.

I think I prefer this long version with text underneath only for the GitHub social preview, then the stand-alone logo that we already decided on as the logo. Let me know what you think.

@jdebacker Nevermind my previous comment. I tested the social preview with text below, and it gets cutoff in the preview, even if I leave space around all the edges. Let's stick with the simple logo for GitHub and for everywhere else.

The method and steps for creating the logo was the following.

Create the logo in Google Draw
Download the logo as scalable vector graphics .svg
Open the .svg file of the logo in Photoshop
Make edits in Photoshop and save as both Photoshop file .psd and as portable network graphics file .png.

@jdebacker . @kerkphil gave an interesting suggestion on Twitter that we should put the flag in one of the middle two circles. Below are two examples with each option. I think I like the first option best with the flag closest to the country abbreviation. And I think I like this better than what we had with the flag in the upper-right-most circle. Thoughts?

Ok - I do like the flag in the middle bar better.  Kind of indifferent between those two options though - it's nice when it comes first, reading left to right, but also makes sense by the country abbreviation.

OK. I think I am now leaning toward the flag closer to "OG" in the first circle. Done. Thanks @kerkphil.


Cheaper Python and Hristov bundle

About the PR
 just TC price changes + removing ammo from the bundle. (5 tc Hristov bundle + 1 tc ammo = 6 tc). Not doing any stat changes because of the freeze
fixes #27968
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Hmeister

tweak Hristov bundle and python are now cheaper

Not doing any stat changes because of the freeze

it's still TC balance changes and it is still frozen

thats fine, il re-open after freeze. just didn't think it would be impactful enough to be part of it

Re-open please

so, merge? Or maybe some suggestions?

Hristov no touch until weapon attachments which I say to every hristov PR.
I think there's no point touching weapon TCs without attachments.

fair


Editor crashes when adding C# script from path with non-ascii characters

Godot version:
v3.1.rc1.mono.official
OS/device including version:
Operating System: Manjaro Linux
KDE Plasma Version: 5.15.1
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Kernel Version: 4.19.24-1-MANJARO
OS Type: 64-bit
Processors: 4 × Intel® Core™ i7-6500U CPU @ 2.50GHz
Memory: 7,7 GiB
Issue description:
If the editor executable is in a path with special (accented -- á, é, ó, etc.) characters (double-checked and this is relative to the binary path, not the godot project itself) the editor crashes when automatically creating the C# project upon adding the first C# script.
Steps to reproduce:
Download the Mono RC1 linux binaries, install msbuild, etc. Extract the editor into a folder with special characters in the name (such as '/home//á'), create a new project and add a C# script to the root node.
Related Issues
I noticed that some similar issues have been fixed by updating mono or godot; however, I still get the crash with Mono 5.18 and latest mono RC1. With that said, this might be related to the mysterious crashes in open issues such as #24361 and #23493
Minimal reproduction project:
N/A

I can reproduce it on Linux too (for the reference, with fr_FR.UTF-8 locale) with 3.1 RC1.
Creating a project at a path with an accented character is fine, but if the Godot binary itself is in such a path (as described above), then it fails. I don't get a crash though, only errors and the project doesn't run:
Unhandled Exception:
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
ERROR: add_item: Method/Function Failed.
   At: modules/mono/editor/csharp_project.cpp:127.

Unhandled Exception:
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
ERROR: add_item: Method/Function Failed.
   At: modules/mono/editor/csharp_project.cpp:127.

Unhandled Exception:
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
ERROR: generate_scripts_metadata: Method/Function Failed, returning: FAILED
   At: modules/mono/editor/csharp_project.cpp:155.
ERROR: editor_build_callback: Condition ' metadata_err != OK ' is true. returned: false
   At: modules/mono/editor/godotsharp_builds.cpp:383.
ERROR: call_build: A Godot Engine build callback failed.
   At: editor/editor_node.cpp:4638.

Mine just crashes, and the output I get is a bit different. I poked around a bit, going as far as naming the script file itself 'à.cs', but nothing else seems to trigger the crash. The output I get is as follows (pt_BR.UTF-8 locale, the specific path can be seen in the dump):
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x37e00) [0x7f03390a7e00] (??:0)
[2] GDMonoAssembly::get_class(StringName const&, StringName const&) (??:?)
[3] CSharpProject::generate_game_project(String const&, String const&, Vector<String> const&) (??:?)
[4] GodotSharpEditor::_create_project_solution() (??:?)
[5] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0xeb6bf1] (:?)
[6] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (??:?)
[7] Object::call(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (??:?)
[8] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0x116836b] (<artificial>:?)
[9] ResourceFormatSaverCSharpScript::save(String const&, Ref<Resource> const&, unsigned int) (??:?)
[10] ResourceSaver::save(String const&, Ref<Resource> const&, unsigned int) (??:?)
[11] ScriptCreateDialog::_create_new() (??:?)
[12] ScriptCreateDialog::ok_pressed() (??:?)
[13] AcceptDialog::_ok_pressed() (??:?)
[14] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0x184aae9] (:?)
[15] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (??:?)
[16] Object::emit_signal(StringName const&, Variant const**, int) (??:?)
[17] Object::emit_signal(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (??:?)
[18] BaseButton::_gui_input(Ref<InputEvent>) (??:?)
[19] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0x1680ed6] (:?)
[20] Object::call_multilevel(StringName const&, Variant const**, int) (??:?)
[21] Object::call_multilevel(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (??:?)
[22] Viewport::_gui_call_input(Control*, Ref<InputEvent> const&) (??:?)
[23] Viewport::_gui_input_event(Ref<InputEvent>) (??:?)
[24] Viewport::input(Ref<InputEvent> const&) (??:?)
[25] Viewport::_vp_input(Ref<InputEvent> const&) (??:?)
[26] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0xfe1866] (:?)
[27] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (??:?)
[28] Object::call(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (??:?)
[29] SceneTree::call_group_flags(unsigned int, StringName const&, StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (??:?)
[30] SceneTree::input_event(Ref<InputEvent> const&) (??:?)
[31] InputDefault::_parse_input_event_impl(Ref<InputEvent> const&, bool) (??:?)
[32] InputDefault::flush_accumulated_events() (??:?)
[33] OS_X11::process_xevents() (??:?)
[34] OS_X11::run() (??:?)
[35] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64(main+0xac) [0xb4946c] (??:?)
[36] /usr/lib/libc.so.6(__libc_start_main+0xf3) [0x7f0339094223] (??:0)
[37] /home/pedroraimundo/á/Godot_v3.1-rc1_mono_x11_64/Godot_v3.1-rc1_mono_x11.64() [0xb4ac1e] (??:?)
-- END OF BACKTRACE --```

I can reproduce the crash too actually, it happens when the solution does not exist yet (in my first test I created the solution while using a Godot binary which was not in a problematic path).

This is probably also reproducible in Windows. I just wasn't following the correct steps when I tested it there.


Missing Sortable.min.js in recent v1.10.0-rc3

Recently was released Sortable v1.10.0-rc3 https://github.com/SortableJS/Sortable/releases and it is missing updated Sortable.min.js

@laukstein It is there in the root directory

@owen-m1, my mistake. Closing this issue.


resize space between paragraphs in editor

Will need to change inline toolbar positioning functioning if I change this as well

Hahaha just realized this is the wrong repo, closing this


[Bug]: Banners component accessibility issues

Prerequisites

[X] I have searched the backlog for duplicate or closed feature requests

Your test device
iPhone 14 Plus
OS Version
17.1.1
App version
v0.16.0
Describe the issue
This list is about "Banners" component and variant only. Other common issues are described in dedicated issues.

[ ] Image in banner should have a description as it's a part of customization ?

Expected Behavior
Banners pages 100% accessible (current status 21/12/23 : 75%)

not an issuer


read_multi 50x slower when one of the keys is not found

If all keys are present, the read_multi call is very fast. But surprisingly, when one of the requested keys is missing, it becomes more than 50x slower, see example below. The memcache-client gem does not have that problem.
I found that the time is spend in memcached itself, so I upgraded to the latest version (1.4.6) but that does not help.
I think the problem is in the way Dalli communicates with memcached.
The following example assumes Rails is loaded in the IRB
> mstore = ActiveSupport::Cache.lookup_store(:mem_cache_store, '<IP_ADDRESS>:11211', {:namespace => 'mtest'})
 => #<ActiveSupport::Cache::MemCacheStore:0xcab46fc @options={:namespace=>"mtest"}, dataMemCache: 1 servers, ns: nil, ro: false
> dstore = ActiveSupport::Cache.lookup_store(:dalli_store, '<IP_ADDRESS>:11211', {:namespace => 'dtest'})
 => #<ActiveSupport::Cache::DalliStore:0xca9bd00 @options={:namespace=>"dtest"}, data#<Dalli::Client:0xca910f8 @options={:expires_in=>0}, ringnil, servers["<IP_ADDRESS>:11211"]

> mstore.write('key1', 'value'); mstore.write('key2', 'value');
> dstore.write('key1', 'value'); dstore.write('key2', 'value');

> # MemCacheStore.read_multi with all known keys
> t=Time.now; 1000.times{ mstore.read_multi('key1', 'key2') }; Time.now - t
 => 0.662803

> # DalliStore.read_multi with all known keys
> t=Time.now; 1000.times{ dstore.read_multi('key1', 'key2') }; Time.now - t
 => 0.320749

> # MemCacheStore.read_multi with one missing key
> t=Time.now; 1000.times{ mstore.read_multi('key1', 'key3') }; Time.now - t
 => 0.605206

> # Dalli.read_multi with one missing key
> t=Time.now; 1000.times{ dstore.read_multi('key1', 'key3') }; Time.now - t
 => 32.166594

It's looking more and more like this is an issue with older memcached server versions.  1.4.8 has a bug fix for multi-get processing and I can't reproduce this on newer versions of memcached.
It probably works with memcache-client because it uses the text protocol, not binary.

I have reproduced this on Memcached 1.4.13 with Libevent 2.0.17.  Using REE and Ubuntu 10.04.3

@timhaines Does it happen on 1.9.3?

Just tried it - no.  The problem goes away on 1.9.3.


Removed build stages, cleaned things up, presto!

[ch674]

@djspiewak do you know what work needs to be done to land this? Or are there still some things to figure out?

@alissapajer Travis is being inexplicably weird. It's like it's timing out while the build is running and I don't get it. One possibility is that the log buffer is too large, which I've seen cause issues with Travis in the past. Not sure exactly though.

@djspiewak travis just failed for a totally different reason.

@djspiewak we made it further. This time
Unable to send webhook.

when we were trying to send the webhook to discord.


configure: add -Wstrict-prototypes

fix #1320

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/251/

There's this failure in one of the windows bots that looks unrelated but don't remember seeing it before
not ok 242 - fs_utime
# exit code 3
# Output from process `fs_utime`: (no output)

New CI to see what happens with fs_utime: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/257/

Landed in: https://github.com/libuv/libuv/commit/fd39cec4b848b27be6bf3f8a3e0bce29474366bb. Thanks!

CI was green BTW


great work 👏

This plugin is great and works very well, you should put some donation way so people can recognize your hard work. I bet there're many companies making lots of money using this.
Thank you 🙏

I appreciate your comments. 😄


How to send Ctrl+A to the client to start session

I'm writing a program to monitor tank monitors and there is a handshake that's needed. It's a RAW socket that needs the key combination (Ctrl+A) to initiate the session.
How is that done with your library?
Thanks!

private void Form1_KeyDown(object sender, KeyEventArgs e)
{
if (e.Control && e.KeyCode == Keys.A)
{
SimpleTcpClient client = new SimpleTcpClient().Connect("<IP_ADDRESS>", 8910);
}
}

Thanks for the response but the command needs to be send via code. There's no user interaction for this program so I would be unable to capture the KeyDown event.
Thanks again!


feat: load all zone names during initialization

During the work to support all valves and all controllers we lost some of the nice-to-haves like dynamic zone names.
Given the oddities with scraping the Melnor app I've currently elected to scrape names only during initialization. We have to hit the app N*valve_count before scraping each page. In the future I may look for a way to update this with a less aggressive scraping method. But currently I haven't found anything more useful in the html.

Coverage decreased (-1.4%) to 92.627% when pulling c4facada81ed6887cd3b763da0878ed9c00b9384 on feature/zone-names into 1352f958edb13eccadf55e7fd6e3dfb31dbce016 on master.


vmbus_client: eliminate extra text in inspect output

Before:
    interface_name: "host relay channel - vpci",

After:
    interface_name: "vpci",

This is not ambiguous, so I'm not sure why we had the extra text to begin with.

you can blame me - I think i thought having the extra text that it was a relay channel was useful, but clearly not?


Yo-Kai Watch

Game Name (and version if necessary)
Yo-Kai Watch
Hardware Specs (If necessary)
No response
Operating System
Windows
Game State
Boots but crashes right after loading screen
[FATAL] WaitSynchronizationN: Bad object handle FFFF8008
Screenshots

Additional information

Any updates on this? I wanna make Lua scripts for the game lol


Move from Completion[] to CompletionList

To accommodate css-languageserver, which returns incomplete lists.

No need, until we have a use case for incomplete completion lists.


kernel modules for Ubuntu Xenial 16.04 kernel 4.4.90-mainline-rev1 x86_64

After install image Ubuntu Xenial from Scaleway, i can't find kernel modules from
/lib/modules/4.4.90-mainline-rev1/kernel/crypto - af_alg* (need for ipsec)
lib/modules/4.4.90-mainline-rev1/kernel/net/l2tp * ?
Where can I find those other modules ?

I also tried to install original kernel of Ubuntu 16.04 , c https://github.com/stuffo/scaleway-ubuntukernel but it is not working. Original Kernel was crashed...(((

After install image Ubuntu Trusty from Scaleway, also problems ...  i can't find kernel modules from

@masterb0, try to use advice from https://github.com/scaleway/image-ubuntu/issues/125 to boot your distro's Linux kernel.


fixed a typo as per issue 1473

@djordjelacmanovic Thanks! In the future please add closes #1473 to body so github will auto close that specific issue. Thanks for your help!


Catering to all possible routes for Post Request

Signed-off-by: deepanshuagarwal<EMAIL_ADDRESS>Description
A topic is getting subscribed to in Dapr with a truncated path, in case a class level RequestMapping is also provided with PostMapping path. This change aims at fixing this by taking into account all paths possible for POST.
Issue reference
Please reference the issue this PR will close: #694
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@DeepanshuA Please see to the indentation ... Viewing via GitHub is hard ... please check if the checkstyle passes locally ...

@DeepanshuA Please see to the indentation ... Viewing via GitHub is hard ... please check if the checkstyle passes locally ...

@DeepanshuA
Can you fix DCO ? Also is the PR complete or WIP ?

@DeepanshuA Please see to the indentation ... Viewing via GitHub is hard ... please check if the checkstyle passes locally ...

yeah @mukundansundar, fixed indentation

@DeepanshuA Please see to the indentation ... Viewing via GitHub is hard ... please check if the checkstyle passes locally ...

fixed indentation

lgtm. @DeepanshuA Can you look into adding Unit Tests for the same?

yups, added, was in WIP actually before this

@DeepanshuA Can you fix DCO ? Also is the PR complete or WIP ?

yeah @mukundansundar, missed out on sign-off part, let me fix it; yeah, will change the title - it will be PR complete after DCO change.

cc @artursouza

@DeepanshuA Do you know why codecov is giving potentially incorrect results ?


ts: Migrate stream_data.js module to TypeScript.

Migrates stream_data module to TypeScript and also refines the existing types for stream and subscription objects present in sub_store module.
The main crux of this module is create_sub_from_server_data which generates sub objects which we use in web client from the data we get from the server.
The type for it's parameter attrs which I called StreamAttrs is defined as union of three types:-

NeverSubscribedStream & Pick<ExtraStreamAttrs, "subscribed" | "previously_subscribed">
ApiStreamSubscription & Pick<ExtraStreamAttrs, "subscribed" | "previously_subscribed">

Both of these types are inferred by me by looking at the populate_subscriptions method which calls this function with attrs confirming to the types mentioned above.

Stream & {stream_weekly_traffic: number | null; subscribers: number[]; subscribed: boolean}

This type is inferred from the create_streams function which calls this function with attrs having the above type.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "mentor review" "buddy review"

Thanks for the reviews on this one @andersk and @PIG208 I have addressed almost every comment and left some questions.
Also, I have updated the description of the PR with some important information about some types involved in this PR just so that we all are on same page.
This is ready for another look from you guys now :)

I did a pass of the types to check with the ones returned from the server. They seem fine to me.

I posted a few comments; overall looks pretty close and I'd like us to avoid getting this blocked on fiddling with my ideas like https://github.com/zulip/zulip/pull/26381#discussion_r1287816985 and https://github.com/zulip/zulip/pull/26381#discussion_r1287816369; those sorts of naming things can easily be follow-ups.

@zulipbot add "integration review"

Squashed the commits tagged to be squashed and merged, thanks for all the work on this @Lalit3716!


The checkCompoundAssignments property is not supported by @typescript-eslint/restrict-plus-operands

What version of this package are you using?
36.1.0
What operating system, Node.js, and npm version?
v18.16.1 pnpm 8.61
What happened?
Error: .eslintrc.cjs#overrides[0] » eslint-config-standard-with-typescript:
        Configuration for rule "@typescript-eslint/restrict-plus-operands" is invalid:
        Value {"checkCompoundAssignments":true} should NOT have additional properties.

https://typescript-eslint.io/rules/restrict-plus-operands/
https://github.com/typescript-eslint/typescript-eslint/pull/7027

What did you expect to happen?
Change to a value that can be supported
Are you willing to submit a pull request to fix this bug?
Yes, can I change it to?
    "@typescript-eslint/restrict-plus-operands": {
    skipCompoundAssignments :false;

}

@mightyiam 6.1.0

Sorry, that's not supported yet.
https://github.com/standard/eslint-config-standard-with-typescript/blob/722d2b550a5090231db691e8f1421d4e78d29285/package.json#L60

@mightyiam Hi!
What about @typescript-eslint/eslint-plugin 6.1.0 ?


Training of VGG model

Which dataset are you use for training VGG architecture??
Give me a answer as soon as possible
thank you for your efforts.

您解决这个问题了吗

预训练权重的百度网盘不存在，可否重新给一个链接呀，谢谢啦

预训练权重的百度网盘不存在，可否重新给一个链接呀，谢谢啦

可以在这里下载：http://www.mediafire.com/file/qlzzr20mpocnpa3/graph_opt.pb


(PUP-8231) Domain prefix Windows group members

When retrieiving a groups members, Puppet has historically returned
the "Name" property of each IAdsUser COM component instance when
enumerating the members of a group.
For instance, given a group with members:
NT AUTHORITY\SYSTEM (Well known SID S-1-5-18)
%HOSTNAME%\Adminstrator
Everyone (well known SID S-1-1-0)
IIS APPPOOL\DefaultAppPool
The list of members that the ADSI provider would return is:
SYSTEM
Administrator
Everyone
DefaultAppPool
This is a problem. The first three accounts will properly resolve
via Puppet::Util::Windows::ADSI::Group.name_sid_hash, which uses
Puppet::Util::Windows::SID.name_to_sid_object to translate names to
canonical SIDs. The last account DefaultAppPool, which is a
:SidTypeWellKnownGroup, has lost a vital piece of information to be
able to lookup that account name. With "IIS APPPOOL", the account
information cannot be retrieved.
This is remedied by instead using the objectSID from IAdsUser to
return a SID object, which can be returned in a domain prefixed
form. This changes the above resolution of members to:
NT AUTHORITY\SYSTEM
%HOSTNAME%\Administrator
Everyone
IIS APPPOOL\DefaultAppPool

Puppet already properly handles resolving all of the above string
formats with Puppet::Util::Windows::SID.name_to_sid_object and
therefore no longer fails when an existing group contains virtual
accounts like those from IIS APPPOOL

An alternative implementation could have parsed the AdsPath
property from IAdsUser - which is represented as WinNT://GROUP/USER
but it wasn't clear if it will always be returned in such a manner.
Given the SID class already understands which GROUP names require
special treatment, it seemed prudent to leverage existing work to
create and use string representations for accounts that Puppet will
understand.

CLA signed by all contributors.

Odd appveyor failure
Finished in 8 minutes 32 seconds
21519 examples, 0 failures, 62 pending
Spec run exited with 1
Command exited with code 1
appveyor PushArtifact .\spec_order.txt
Uploading artifact spec_order.txt (71 byte

The AppV fail is intermittent @glennsarti

jenkins please test this,puppet-agent on windows2012r2-64a,windows2012r2_ja-64a{locale=ja} with agent 1.10.x


firewall: Only accept messages from Validators

Add new functionality to firewall to only accept messages from validators.
We can check the initiator address to check if the message is initiated from a validator.
User can on/off this setting in firewall config file.

how can we find out if a message bundle is from a validator?

@kehiy About the firewall we need to have a DEV-meeting to discuss about its internal behavior. It's good to postpone this issue until then

@b00f that's ok
I wrote two functions, I will send a draft PR

@b00f Should we work on this issue or close it?
Old issue....


Configurable Dynamic Provisioning aka StorageClass

Description
The current dynamic provisioning feature supports only a single provisioner per cluster.  This feature will allow multiple provisioners to be configured in a single cluster.
Progress Tracker

[x] Before Alpha

[x] Design Proposal.
[x] Initial API review (if API).  Maybe same PR as design doc. PR-NUMBER

Any code that changes an API (/pkg/apis/...)
cc @kubernetes/api

[x] Identify shepherd (your SIG lead and/or<EMAIL_ADDRESS>will be able to help you). My Shepherd is: @childsb for now.

A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.

[x] Identify secondary/backup contact point. My Secondary Contact Point is: @saad-ali

[x] Write (code + tests + docs) then get them merged.  #29006

[x] Code needs to be disabled by default.   Verified by code OWNERS
[x] Minimal testing
[x] Minimal docs

cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io

[x] Update release notes

[x] Before Beta

[x] Testing is sufficient for beta
[x] User docs with tutorials

Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

[x] Thorough API review

cc @kubernetes/api

[ ] Before Stable

[ ] docs/proposals/volume-provisioning.md moved to docs/design/volume-provisioning.md

cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

[ ] Completely removed alpha behavior (annotation volume.alpha.kubernetes.io/storage-class).
[ ] Updated e2e tests
[ ] Soak, load testing
[ ] detailed user docs and examples

[ ] updated existing docs at http://kubernetes.io/docs/user-guide/persistent-volumes/ with real attributes instead of annotations
[ ] updated existing examples in https://github.com/kubernetes/kubernetes/tree/master/examples/experimental/persistent-volume-provisioning with real attributes instead of annotations
cc @kubernetes/docs
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need.  Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs.  Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing.  They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

[ ] Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

@childsb @thockin I saw the docs box is checked, please update docs PR numbers also

@janetkuo we added examples showing the storageClass feature in action, are there additional doc requirements?

In addition to examples, adding a user doc in https://github.com/kubernetes/kubernetes.github.io would be good too.

@janetkuo ack.. i'll get add a doc

@kubernetes/docs @janetkuo I knew we had a PR someplace.  We can add more if needed: https://github.com/kubernetes/kubernetes.github.io/pull/1064

Updated "Before stable" section with more detailed TODO list

@jsafrane are you a person, responsible for the feature?

Yes, I am the responsible one.

Removal of alpha annotation: https://github.com/kubernetes/kubernetes/pull/40000

New stable PV/PVC attributes: https://github.com/kubernetes/kubernetes/pull/40013

Issues to update of vSphere, Azure and Photon installation scripts to deploy a default storage class: https://github.com/kubernetes/kubernetes/issues/40070, https://github.com/kubernetes/kubernetes/issues/40071 and https://github.com/kubernetes/kubernetes/issues/40072
GCE, AWS and OpenStack should already deploy one and no other platform had alpha provisioning enabled.

storage.k8s.io/v1 API: https://github.com/kubernetes/kubernetes/pull/40088
Now I have two PRs (kubernetes/kubernetes#40013 and kubernetes/kubernetes#40088) that need to get in before I actually start writing code to use v1 API in Kubernetes (controllers, examples, tests, ...) Please review.

Is dashboard support part of this effort (if it has not already been addressed)

cc @lpabon

"alpha" provisioning has been removed, updating documentation at https://github.com/kubernetes/kubernetes.github.io/pull/2557

@childsb @jsafrane @thockin please, provide us with the release notes and documentation PR or link at https://docs.google.com/spreadsheets/d/1nspIeRVNjAQHRslHQD1-6gPv99OcYZLMezrBe3Pfhhg/edit#gid=0
Also, please, select the valid checkpoints at the Progress Tracker.

For the reference, alpha dynamic provisioning is not removed in 1.6, I did not want to rush it in one day before freeze. It will be removed in 1.7.

documentation: https://github.com/kubernetes/kubernetes.github.io/pull/2686

examples: https://github.com/kubernetes/kubernetes/pull/42637 (please review)

Is this an oversight to enable this bot on feature repository?  A feature easily takes more than one release for implementation... @fejta

Not an oversight. Please provide quarterly updates if this feature is still wanted

This went beta in v1.6, let's close it.


WIP: New Abilities Syntax

Addresses #5377. The goal is to fully implement the new syntax.

roc_parse tests all pass.
I noticed that the compiler seemed to be trying to parse implements as a type variable here:
    0       │-── INCOMPLETE ABILITY IMPLEMENTATION ───────────────────── /code/proj/Main.roc ─␊
          0 │+── TOO MANY TYPE ARGUMENTS ─────────────────────────────── /code/proj/Main.roc ─␊
    1     1 │ ␊
    2       │-I can't derive an implementation of the `Hash` ability for `F`:␊
          2 │+The `U8` alias expects 0 type arguments, but it got 2 instead:␊
    3     3 │ ␊
    4     4 │ 3│  F := U8 -> U8 implements [Hash, Eq, Encoding]␊
    5       │-                              ^^^^␊
          5 │+               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^␊

That lead me to discover a couple places in roc_parse::expr and roc_parse::pattern where "has" was still hardcoded.
Is there any reason not to add "implements" and "where" in roc_parse::keywords and reference them everywhere else?

Thanks so much for all the hard work on this @sandprickle - a few resolved merge conflicts and updated tests later, this is now on main!!! 🎉


Provide an option to skip particular directories.

may be add another flag to skip directories or files ending with particular extensions. --skip

@rishubhjain see https://github.com/client9/misspell/issues/115


Optimize repartition away after head

pre-cursor for #382

#382  is where this comes up. Compute should inject a repartition layer that reduces to 1 so that we can optimise our way through other ops (sort values for example)