Refactored update of PnRDB after placement and snapped the placement …

…locations to the next largest grid point.
@Lastdayends @desmonddak
This is a simple change to align placements the m1 and m2 grids of the mock pdk.
There should be a better way to do this (probably by setting different coordinates for the HGraph and VGraph nodes.)
@Lastdayends Can you fix this so it snaps the placement in the correct place and using the the actual DRCinfo structure? It is hardcoded for the mock pdk now.
A driving testcase is in the examples directory "cascode_current_mirror_ota". Several leaf cells are off grid resulting in off grid wiring and drc errors (unless you using this hack.)

@parijatm
You'll want to use this PR for a more complicated test case. The "cascode_current_mirror_ota" is good one because it have intermediate hierarchy.
You'll need to use this PR but I hacked a fix to the placer to make sure in aligns cells to the grid.

@stevenmburns
Sorry for the late reply. Sure, I will fix it.
Yaguang

@stevenmburns
Fixed. Please check the updates.
Yaguang

@parijatm
You'll want to use this PR for a more complicated test case. The "cascode_current_mirror_ota" is good one because it has intermediate hierarchy.
You'll need to use this PR but I hacked a fix to the placer to make sure in aligns cells to the grid.

Thank you @stevenmburns ! I will work on this once I have the telescopic OTA fully working in #191.

@Lastdayends I make one little fix.
This doesn't address the root cause of the problem does it.
Is that something you are willing to looking? This is not the right place to snap to the grid. It should be done probably during VGrid and HGrid construction. Why are things off grid in the first place?

@Burns, Steven M<EMAIL_ADDRESS>Without this part of code (roundup), placer is actually adding a v_bias and
h_bias in VGrid and HGrid to make sure the distance between each blocks is
multiple m1 pitches and multiple m2 piitches. This strategy should make
sure all M1/M2 metals are on grid. (Assumption here is, width and height of
blocks is multiple m1 pitches and multiple M2 pitches, respectively.)
If there are still M1/M2 off grid metals, please check if the weight and
height meets the assumption.
Or do you think this assumption is too strong?
Yaguang
On Mon, Oct 7, 2019 at 12:02 PM Steve Burns<EMAIL_ADDRESS>wrote:

@Lastdayends
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Lastdayends&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=WI5S2cMOKf97PPHMYo3eD7EtkotUKQNTNXc8VnFd3Zw&e=
I make one little fix.
This doesn't address the root cause of the problem does it.
Is that something you are willing to looking? This is not the right place
to snap to the grid. It should be done probably during VGrid and HGrid
construction. Why are things off grid in the first place?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZXXP5ZKTFZET6JPIJ3QNNTRNA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARCNWQ-23issuecomment-2D539109082&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=Vy9TMBPPSVaVSu0iIMa6hIMNKcsfFxPJwEPEtDws8uo&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZVHSK3KRFFX4AP2ONLQNNTRNANCNFSM4I5UJNPA&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=4ac9CEapvneSF4xnvsqpwBzCHswtZ3OwX8hGg-fyh24&e=
.

It does not do that.
The example is “cascade_current_mirror_ota”.
All the subblock boundaries are on grid.
From: Yaguang Li<EMAIL_ADDRESS>Sent: Monday, October 7, 2019 12:51 PM
To: ALIGN-analoglayout/ALIGN-public<EMAIL_ADDRESS>Cc: Burns, Steven M<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [ALIGN-analoglayout/ALIGN-public] Refactored update of PnRDB after placement and snapped the placement … (#196)
@Burns, Steven M <steven.m.burns<EMAIL_ADDRESS>Without this part of code (roundup), placer is actually adding a v_bias and
h_bias in VGrid and HGrid to make sure the distance between each blocks is
multiple m1 pitches and multiple m2 piitches. This strategy should make
sure all M1/M2 metals are on grid. (Assumption here is, width and height of
blocks is multiple m1 pitches and multiple M2 pitches, respectively.)
If there are still M1/M2 off grid metals, please check if the weight and
height meets the assumption.
Or do you think this assumption is too strong?
Yaguang
On Mon, Oct 7, 2019 at 12:02 PM Steve Burns <notifications<EMAIL_ADDRESS>wrote:

@Lastdayends
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Lastdayends&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=WI5S2cMOKf97PPHMYo3eD7EtkotUKQNTNXc8VnFd3Zw&e=
I make one little fix.
This doesn't address the root cause of the problem does it.
Is that something you are willing to looking? This is not the right place
to snap to the grid. It should be done probably during VGrid and HGrid
construction. Why are things off grid in the first place?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZXXP5ZKTFZET6JPIJ3QNNTRNA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARCNWQ-23issuecomment-2D539109082&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=Vy9TMBPPSVaVSu0iIMa6hIMNKcsfFxPJwEPEtDws8uo&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZVHSK3KRFFX4AP2ONLQNNTRNANCNFSM4I5UJNPA&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=4ac9CEapvneSF4xnvsqpwBzCHswtZ3OwX8hGg-fyh24&e=
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ALIGN-analoglayout/ALIGN-public/pull/196?email_source=notifications&email_token=AALRI7RHUPNJ275G3REQY6LQNOHKRA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARSUQQ#issuecomment-539175490, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALRI7TVGXCXBTNH2AW4CHDQNOHKRANCNFSM4I5UJNPA.

Can you show me the testcase? I think someone may add a bias const in const
file, which is not multiple m1/m2 pitches, just delete that constraint.
Yaguang
On Mon, Oct 7, 2019 at 2:53 PM Steve Burns<EMAIL_ADDRESS>wrote:

It does not do that.
The example is “cascade_current_mirror_ota”.
All the subblock boundaries are on grid.
From: Yaguang Li<EMAIL_ADDRESS>Sent: Monday, October 7, 2019 12:51 PM
To: ALIGN-analoglayout/ALIGN-public<EMAIL_ADDRESS>Cc: Burns, Steven M<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [ALIGN-analoglayout/ALIGN-public] Refactored update of PnRDB
after placement and snapped the placement … (#196)
@Burns, Steven M <steven.m.burns<EMAIL_ADDRESS>Without this part of code (roundup), placer is actually adding a v_bias
and
h_bias in VGrid and HGrid to make sure the distance between each blocks is
multiple m1 pitches and multiple m2 piitches. This strategy should make
sure all M1/M2 metals are on grid. (Assumption here is, width and height
of
blocks is multiple m1 pitches and multiple M2 pitches, respectively.)
If there are still M1/M2 off grid metals, please check if the weight and
height meets the assumption.
Or do you think this assumption is too strong?
Yaguang
On Mon, Oct 7, 2019 at 12:02 PM Steve Burns<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

@Lastdayends
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Lastdayends&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=WI5S2cMOKf97PPHMYo3eD7EtkotUKQNTNXc8VnFd3Zw&e=>

I make one little fix.
This doesn't address the root cause of the problem does it.
Is that something you are willing to looking? This is not the right
place
to snap to the grid. It should be done probably during VGrid and HGrid
construction. Why are things off grid in the first place?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZXXP5ZKTFZET6JPIJ3QNNTRNA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARCNWQ-23issuecomment-2D539109082&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=Vy9TMBPPSVaVSu0iIMa6hIMNKcsfFxPJwEPEtDws8uo&e=>,

or mute the thread
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZVHSK3KRFFX4AP2ONLQNNTRNANCNFSM4I5UJNPA&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=4ac9CEapvneSF4xnvsqpwBzCHswtZ3OwX8hGg-fyh24&e=>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/ALIGN-analoglayout/ALIGN-public/pull/196?email_source=notifications&email_token=AALRI7RHUPNJ275G3REQY6LQNOHKRA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARSUQQ#issuecomment-539175490>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AALRI7TVGXCXBTNH2AW4CHDQNOHKRANCNFSM4I5UJNPA>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZS356VVPUU7V5LGR53QNOHS7A5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARS3SI-23issuecomment-2D539176393&d=DwMFaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=pJppo3thVP-_KLYQmCpkx2mEQsxk4VkgLSyiec5Ifa0&s=m8CkwvTAfNWFP59yJAk2iZmhYLV19P3mJhAkxIM0RYM&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZUXDQSQZ4EJQ26UDT3QNOHS7ANCNFSM4I5UJNPA&d=DwMFaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=pJppo3thVP-_KLYQmCpkx2mEQsxk4VkgLSyiec5Ifa0&s=FwuG4lEZQ1rZ5tvXPpBzWltLYX-OjlPBW0tHVSM9qi8&e=
.

@Burns, Steven M<EMAIL_ADDRESS>Is the testcase under example, named cascode_current_mirror_ota? Could you
generate a reproduce case to see what happens.
Thanks.
Yaguang
On Mon, Oct 7, 2019 at 2:53 PM Steve Burns<EMAIL_ADDRESS>wrote:

It does not do that.
The example is “cascade_current_mirror_ota”.
All the subblock boundaries are on grid.
From: Yaguang Li<EMAIL_ADDRESS>Sent: Monday, October 7, 2019 12:51 PM
To: ALIGN-analoglayout/ALIGN-public<EMAIL_ADDRESS>Cc: Burns, Steven M<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [ALIGN-analoglayout/ALIGN-public] Refactored update of PnRDB
after placement and snapped the placement … (#196)
@Burns, Steven M <steven.m.burns<EMAIL_ADDRESS>Without this part of code (roundup), placer is actually adding a v_bias
and
h_bias in VGrid and HGrid to make sure the distance between each blocks is
multiple m1 pitches and multiple m2 piitches. This strategy should make
sure all M1/M2 metals are on grid. (Assumption here is, width and height
of
blocks is multiple m1 pitches and multiple M2 pitches, respectively.)
If there are still M1/M2 off grid metals, please check if the weight and
height meets the assumption.
Or do you think this assumption is too strong?
Yaguang
On Mon, Oct 7, 2019 at 12:02 PM Steve Burns<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

@Lastdayends
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Lastdayends&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=WI5S2cMOKf97PPHMYo3eD7EtkotUKQNTNXc8VnFd3Zw&e=>

I make one little fix.
This doesn't address the root cause of the problem does it.
Is that something you are willing to looking? This is not the right
place
to snap to the grid. It should be done probably during VGrid and HGrid
construction. Why are things off grid in the first place?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZXXP5ZKTFZET6JPIJ3QNNTRNA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARCNWQ-23issuecomment-2D539109082&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=Vy9TMBPPSVaVSu0iIMa6hIMNKcsfFxPJwEPEtDws8uo&e=>,

or mute the thread
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZVHSK3KRFFX4AP2ONLQNNTRNANCNFSM4I5UJNPA&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=BllRnxqoHIDoXwvgR90heM4oIfm-QG3-xduMaNgW9Ew&s=4ac9CEapvneSF4xnvsqpwBzCHswtZ3OwX8hGg-fyh24&e=>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/ALIGN-analoglayout/ALIGN-public/pull/196?email_source=notifications&email_token=AALRI7RHUPNJ275G3REQY6LQNOHKRA5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARSUQQ#issuecomment-539175490>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AALRI7TVGXCXBTNH2AW4CHDQNOHKRANCNFSM4I5UJNPA>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ALIGN-2Danaloglayout_ALIGN-2Dpublic_pull_196-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKIMLZS356VVPUU7V5LGR53QNOHS7A5CNFSM4I5UJNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARS3SI-23issuecomment-2D539176393&d=DwMFaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=pJppo3thVP-_KLYQmCpkx2mEQsxk4VkgLSyiec5Ifa0&s=m8CkwvTAfNWFP59yJAk2iZmhYLV19P3mJhAkxIM0RYM&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIMLZUXDQSQZ4EJQ26UDT3QNOHS7ANCNFSM4I5UJNPA&d=DwMFaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=ZMUCBc0sWFUe5MzbQ3jL6w&m=pJppo3thVP-_KLYQmCpkx2mEQsxk4VkgLSyiec5Ifa0&s=FwuG4lEZQ1rZ5tvXPpBzWltLYX-OjlPBW0tHVSM9qi8&e=
.


TypeError: Cannot read properties of undefined (reading 'toBuffer')

I'm getting this error while trying to call the getBuyInstructions function:

Its Javascript, I believe you must call the function like this:

(async () => {
  console.log("Creating a wallet");

  let buyInstructions = await pumpFunSDK.getBuyInstructions(
    _wallet.publicKey,
    new PublicKey(token_mint),
    new PublicKey(PUMP_FUN_FEE_RECIPIENT),
    100, //tokenAmount you wish to spend so 100 tokens for example
    BigInt(sol_amount*10**9), //Max SOL amount in LAMPORTs you wish to spend.
  );

  console.log("buyInstructions", buyInstructions);
})();

The way your calling it is passing in that object as a the first param and thus mint is null and throwing an exception.
Second the amount field is a Token Amount you wish to buy and second Param is the maxSolAmount you're willing to pay to purchase that amount of tokens.  Next getBuyInstructions is async, so you need to await it.
Curious, why not just use the buy function?

Hey, going to try that right now. To answer your question, the reason i'm not using the buy function is because I want to generate a new transaction that I can sign and use in a jito bundle, therefore I only require the signed transaction as a base58 string, Do you have any idea of how I can do this using the sdk in a more efficient way? Thank you!

Check out this PR: https://github.com/rckprtr/pumpdotfun-sdk/pull/6
I think this helper might make it easier. LMK


Missing documentation on change/impact types

There is currently no documentation on the types of changes/impacts

The types of changes/impacts are now described in the following page: http://at-diff.ariatemplates.com/impacts.html


Mode: paired short read (Bowtie2) fails when index is provided as reference fasta file

Thanks for providing us with hassle-free and fast dehosting tool.
I am however running into an issue when using PE fastq files and providing the custom reference fasta file of Bos taurus.
For ONT fastq files, hostile automatically indexes the fasta file but the same is not true for PE bowtie mode. Can this be implemented?
hostile clean --fastq1 SRR27845761_1.fastq.gz --fastq2 SRR27845761_2.fastq.gz --threads 10     --index Bos_taurus.ARS-UCD1.3.dna.toplevel.fa

10:37:37 INFO: Hostile version 1.1.0. Mode: paired short read (Bowtie2)
Traceback (most recent call last):
  File "/home/subudhak/miniconda3/envs/serotyper/bin/hostile", line 10, in <module>
    sys.exit(main())
  File "/home/subudhak/miniconda3/envs/serotyper/lib/python3.10/site-packages/hostile/cli.py", line 154, in main
    defopt.run(
  File "/home/subudhak/miniconda3/envs/serotyper/lib/python3.10/site-packages/defopt.py", line 356, in run
    return call()
  File "/home/subudhak/miniconda3/envs/serotyper/lib/python3.10/site-packages/hostile/cli.py", line 68, in clean
    stats = lib.clean_paired_fastqs(
  File "/home/subudhak/miniconda3/envs/serotyper/lib/python3.10/site-packages/hostile/lib.py", line 225, in clean_paired_fastqs
    index_path = aligner.value.check_index(index, offline=offline)
  File "/home/subudhak/miniconda3/envs/serotyper/lib/python3.10/site-packages/hostile/aligner.py", line 61, in check_index
    raise FileNotFoundError(message)
FileNotFoundError: Bos_taurus.ARS-UCD1.3.dna.toplevel.fa is neither a valid custom index path nor a valid standard index name

Hi! Thanks for drawing attention to this, which works today but should be better documented.
Whereas the index parameter accepts a path to a genome in Minimap2 (long read) mode, in Bowtie2 (short read) mode it accepts a path to a precomputed Bowtie2 index, minus the .x.bt2 extension.
So you'll need to build a bowtie2 index (beware, human genome takes 30 mins or so)
bowtie2-build Bos_taurus.ARS-UCD1.3.dna.toplevel.fa bostaurus

And then
hostile clean --fastq1 SRR27845761_1.fastq.gz --fastq2 SRR27845761_2.fastq.gz --threads 10     --index bostaurus

This annoying implementation detail is normally hidden when using standard indexes.
I've updated the readme to make this behaviour clearer.


Remove default { field: null } from WebsiteScheduledContentQueryInput.sort

I'm not sure where in the resolving this causes the results to be limited to 1 but removing it resolves the issue documented in https://github.com/parameter1/base-cms/issues/185

Resolves #185


Unable to run EFA jobs on EKS Ubuntu nodes

We have an EKS cluster where we are trying to run EFA enabled jobs on ubuntu nodes, but unable to get this running due to networking issues on pods running on EFA enabled nodes. The error we see are usually related to pods communication , pods scheduled on EFA nodes are unable to communicate with each other.
We have observed that we are facing the issues only with EFA enabled ubuntu nodes , the setup is working fine for amazon linux nodes. We have been able to use EFA in non EKS EC2 ubuntu machines in the past but for some reason this is not working with EKS ubuntu nodes.
As for our use case we need to use ubuntu nodes only , We would like to understand if there are any differences in how vpc cni / EFA networking works for ubuntu and amazon linux. Also are there any similar use cases with successful implementation of EFA on Ubuntu nodes in EKS. This is a major blocker for us, any recommendations/references on this would be highly appreciated.

We have been able to use EFA in non EKS EC2 ubuntu machines in the past but for some reason this is not working with EKS ubuntu nodes.
@suruchissingh What CNI were you using for non EKS EC2 ubuntu machines?


[nrf temphack] ci: enable windows "sanitycheck --build-only"

Small tweaks to fix paths/memory allocation
Uses make from chocolatey
upstream PR is in review. https://github.com/zephyrproject-rtos/zephyr/pull/16619

Signed-off-by: Thomas Stilwell<EMAIL_ADDRESS>

Found the following issues, please fix and resubmit:
Gitlint issues
Commit 24489db6d5:
1: UC6 Body has no content, should at least have 1 line.


feat: add sst level config for benchmark

Rationale
Add sst level configuration for the benchmark test.
Detailed Changes
Add sst level configuration for the benchmark test.
Test Plan
Manual test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chenmian.cm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[CodePush] Cancel release for failed bundle

Issue: appcenter-cli creates release when React Native bundling is failed
Related issue: #911
Solution: Reject release process when React Native bundling is failed

I'm going to close PR because it doesn`t fully fix this error. For now, please feel free to reopen it if you have any questions.

I'm going to close PR because it doesn`t fully fix this error. For now, please feel free to reopen it if you have any questions.


Review README.md for any clarifications or additions needed

Review the Installation and send me errors you encountered, at which step you encountered them and how it was resolved on your machine.
In general, any step that is not clear enough (i.e. you would have/had questions about during installation), let me know.

I've added a few things for MacOS and spark


Use C ABI instead of SCALE codec for wasm serialization

Remove the statically linked SCALE codec from inside the WASM binary.
Relates to the following part of #1887

While this is an interesting idea, it's not without some inherent problems. What I wanted initially was to have Instruction and QueryBox laid out in memory in a deterministic way that would be portable between rust compiler versions but across different languages so as to avoid the need for serialization (we could say that memory layout of the structures coincides with their serialization format - essentially ABI). There are ways to achieve stable ABI when doing Rust to Rust FFI.

For stable ABI across different programming languages 1st there is an option to use C ABI. This sounds like a tempting solution, but the issue are structures like Vec, String and BTreeMap which are not controlled by us and don't have repr(C) representation. Also, there is an issue that we sometimes use smallvec and smallstr which also don't have repr(C). This indicates that some form of serialization is due. Some serialization possibilities:

force memory layout of Instruction/QueryBox to adhere to C ABI. This means to make our own repr(C) versions of BTreeMap and alike(safer-ffi). I don't consider this a viable solution

using opaque pointers - client can never access elements of structures directly, only through functions receiving opaque pointers to structures. Layout of structures is irrelevant in this case. Also, we can make some sort of facade around exported functions. This is often the approach taken when doing FFI

separate FFI structs - every structure that will participate in FFI, even though it doesn't have stable ABI, should be able to transform itself into C ABI representation

Another possibility for stable ABI across languages is using flatbuffers which should have a very small code size footprint and may be even more portable than C ABI.

As of #1826, smallvec and smallstr are encoded and decoded as Vec and String. So we only need to worry about the standard library types.

I'm closing this issue in favor of #2062


Gmail - Calendar invitation - details on top missing

Describe the bug
When receiving a calendar invitation mail in Gmail there normally is a block with all the invitation details on top including date, time and the possibility to respond to the invite. This block is missing in Franz, it just shows the mail content below. It's the same for all "Accepted" or "Declined" notifications you receive, when you send out a meeting invite.
Tried to clear the cache, delete the Cache and Partitions folder, remove and re-add the service, all didn't work.
To Reproduce
Steps to reproduce the behavior:

Go to Gmail - Inbox
Open an invitation to a meeting
The part with date/time and response possibilities is not visible.

Expected behavior
The block with the date/time/response information is shown.
Screenshots
This is how it looks like in Franz:

This is how it should look like (e.g. in Chrome browser):

Desktop (please complete the following information):

OS: Windows 10
Browser: Franz
Version 5.7.0

Confirm same issue
OS: Ubuntu 21.10
Versione: 5.7.0
If I debug correctly all call seems the call to https://clients6.google.com/gmail to download "batchListCalendarEvents" (the same for some other call to the same url) reply with 401 http error code and body:
{
  "error": {
    "code": 401,
    "message": "Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",
    "errors": [
      {
        "message": "Invalid Credentials",
        "domain": "global",
        "reason": "authError",
        "location": "Authorization",
        "locationType": "header"
      }
    ],
    "status": "UNAUTHENTICATED"
  }
}

after some search I found all that calls miss this header:
origin: https://hangouts.google.com

If I add this header to the wrapper curl call, server reply correctly!


Add basic cross-compile code

Describe in detail the problem you had and how this PR fixes it
Build script now should be able to cross compile. I most likely missed some places.
The binary builds but I did not yet test functionality.
Is there an open issue you can link to?
#35
BTW this is my first real js contribution.

The arm target still won't work with this, correct?

IIRC the pulled nexe binary is wrong.

This may have been solved by moving to nbin. If not I imagine this will need a few changes(or moved entirely to nbin.)

Fixed by moving to nbin :confetti_ball:


Double clicking a symbol starting/ending a string highlights the adjacent quotes

When writing JavaScript, double clicking symbols that start a string highlights both the symbols and the single or double quote to the left of it. If there's a left parenthesis to the left of the quote, that is highlighted too. The reverse happens for symbols ending a string, except the highlight also extends to a line-terminating semicolon if it's to the right of the right parenthesis.
If the first or last word are only letters, the selection is only of the words themselves, as expected.

VSCode Version: Version 1.10.2 (1.10.2), 8076a19fdcab7e1fc1707952d652f0bb6c6db331
OS Version: MacOS 10.12.3 (16D32)

Steps to Reproduce:

Enter line: console.log('### ###');
Double click either the first ### or the second to observe.
Also try console.log('######'); and console.log('###abc###');

Probably related: If the cursor is positioned in one of those leading or trailing string symbols and you use Option-Left/Right to skip to the end of that word at the string boundary, it will also skip over the string quote, parenthesis, and semicolon, unlike if it was letters only.

This is as designed.
Double clicking and word navigation respects the user configurable setting:
  "editor.wordSeparators": "`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?",

These are programming language agnostic features that simply use the word separators list. i.e. double clicking does not analyze the underlying language and determine it to be JavaScript, and implement a different strategy than under C++ for example, where ' can only contain a single character, while in JavaScript ' can contain more than one character.
In other words, this operation on this text works the same, regardless of file extension. Would you like for double clicking and word navigation to be language dependentant?

If apostrophe is already in wordSeparators, then why does the selection include it?
Either way, I think it should be smart about editing code versus English or some human language. Whether that involves per-language word separator configuration, I'm sure you know better than me! :)

In this case, the explanation is easy, # is also a word separator.
Double clicking works by classifying characters in one of three classes: regular (highlighted in green below), word separators (highlighted in blue below) and whitespace (highlighted in red below).

Then, it will select contiguous characters of the same class in both directions starting from the double click location.
That's why double clicking on # will select adjacent word separator characters.
I have also double checked in Visual Studio and I believe what we do is correct and consistent with other editors. I will close this for now, since it works as designed.

Makes sense. Thanks for the explanation (and graphic!).
Perhaps something to consider changing in the future?
On Thu, Mar 30, 2017 at 12:24 AM Alexandru Dima<EMAIL_ADDRESS>wrote:

Closed #22685 https://github.com/Microsoft/vscode/issues/22685.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/22685#event-1021776894, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD5Vr6MxDopQJjPNOhOt5lmukQJDBJpks5rq1jEgaJpZM4MeXpZ
.


[Backport release-24.05] lxc/incus LTS upgrades: 6.0.1 -> 6.0.2

Description of changes

lxc: 6.0.1 -> 6.0.2
lxcfs: 6.0.1 -> 6.0.2
incus-lts: 6.0.1 -> 6.0.2

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

x86
/nix/store/8aplfcihhyb5ipbjdapx0wchx4c4qp9w-vm-test-run-container-legacy-init
/nix/store/47k7zzsz7mj3mnsjbz7y74l8gr7pfvcj-vm-test-run-container-systemd-init
/nix/store/hgqxbrr21y5dpayigck84748qpyv4sc1-vm-test-run-incusd-options
/nix/store/qnmxcx49hncvcg8gvcp60d5da8p5dcag-vm-test-run-lxd-to-incus
/nix/store/8xcain2h9pm7q0kv9k4xi8yz446aclg6-vm-test-run-incus-openvswitch
/nix/store/08c2ah4raqh76af3nvsh0x2diybn9nsb-vm-test-run-incus-socket-activated
/nix/store/4v7jq4415dbr0r7xr8k1m491w7vsw4xk-vm-test-run-incus-storage
/nix/store/yhjq76g0mpwn29ifcxkkyan1px6dd6w1-vm-test-run-incus-ui
/nix/store/8yp49vhfp5vyvg0pcs88pnnnkg3z878n-vm-test-run-incus-virtual-machine

aarch64 incus-lts.passthru.tests
/nix/store/nncnbacnvgjigmwql6mq96nr38r1qmn4-vm-test-run-container-legacy-init
/nix/store/dsh96bxhmqf1s8932n2aj8fcfb74a6bv-vm-test-run-container-systemd-init
/nix/store/iqjmy58q27m9xc1gnffrald41l72ra40-vm-test-run-incusd-options
/nix/store/n191yclh7h4z9n0qfm2fwldnah2fif9f-vm-test-run-lxd-to-incus
/nix/store/fwv5g71rckjc1ml5qsczh3k2cvwb064y-vm-test-run-incus-openvswitch
/nix/store/hf74166bqhl4fzh37lc6yl3syavjd52a-vm-test-run-incus-socket-activated
/nix/store/gi2y15hw3dy43kbjhrwdnshrj4ha7dhg-vm-test-run-incus-storage
/nix/store/614prcsrhfj2mjd9dlvf88vqx5rqh8yl-vm-test-run-incus-ui


Add an XGBoost script mode example

Issue #, if available:
Description of changes:

Add a new notebook describing script mode for new XGBoost framework container
Add a new accompanying script file for above notebook

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iyerr3 Only comment is that typically notebooks have a cell (either !cat or !pygmentize) to display the training script.

@eslesar-aws Added the training script in the notebook

Introduction needs an intro to xgboost, for people not familiar with xgboost, as well as a more detailed introduction to what script mode training is
Introduction should also probably reference the older xgboost algorithm mode notebooks as 'alternative ways of running training', for customers who are new to SageMaker
We use this same dataset in other notebooks right? If not this will require approval from data hosts
The script we use will benefit from an explanation of rabit is, since it is referenced in the script.
We want notebooks to be end to end, in other words, include inference to prove to customers correctness.

I would sync with a PM about this notebook and the script. How urgent is this?


image analysis fails

The image analysis fails at this particular point... I have debug turned on... here's the specific error....
.2018-01-19 12:53:55+0000 [-] [Thread-74] [anchore_engine.services.analyzer/process_analyzer_job()] [DEBUG] policy engine request: {'fetch_url': 'catalog://admin/analysis_data/sha256:b5611db8560bb3a95294191613c4ea428342ae857ecf02e9b670194e795c636a', 	 'image_id': u'b0dbdee9315add8d7b2ee9730a6a9d5f6f0f4cfdbae5a0c0863cc6064cf27761', 	 'user_id': u'admin'} 2018-01-19 12:53:55+0000 [-] Traceback (most recent call last): 2018-01-19 12:53:55+0000 [-]   File "/usr/lib/python2.7/site-packages/anchore_engine/services/analyzer/__init__.py", line 325, in process_analyzer_job 2018-01-19 12:53:55+0000 [-]     raise Exception("adding image to policy-engine failed - exception: " + str(err)) 2018-01-19 12:53:55+0000 [-] Exception: adding image to policy-engine failed - exception: HTTPConnectionPool(host=u'localhost', port=8087): Max retries exceeded with url: /v1/images (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb888368cd0>: Failed to establish a new connection: [Errno 111] Connection refused',)) 2018-01-19 12:53:55+0000 [-] [Thread-74] [anchore_engine.services.analyzer/process_analyzer_job()] [ERROR] problem analyzing image - exception: adding image to policy-engine failed - exception: HTTPConnectionPool(host=u'localhost', port=8087): Max retries exceeded with url: /v1/images (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb888368cd0>: Failed to establish a new connection: [Errno 111] Connection refused',))

Hello, I face this problem, too. I wish you can help me to solve this. My problem are as follows:
[root@localhost anchore-engine]# anchore-cli image list
Full Tag                               Image ID                                                                Analysis Status
docker.io/library/debian:latest        8626492fecd368469e92258dfcafe055f636cb9cbc321a5865a98a0a6c99b8dd        analyzed
docker.io/nginx:latest                 ae513a47849c895a155ddfb868d6ba247f60240ec8495482eca74c4a2c13a881        analysis_failed
As you can see that one image has been analyzed but another one can not be analyzed.
I try to check if policy engine is up and it shows:
[root@localhost anchore-engine]# anchore-cli system status
Service simplequeue (dockerhostid-anchore-engine, http://anchore-engine:8083): up
Service catalog (dockerhostid-anchore-engine, http://anchore-engine:8082): up
Service policy_engine (dockerhostid-anchore-engine, http://anchore-engine:8087): up
Service kubernetes_webhook (dockerhostid-anchore-engine, http://anchore-engine:8338): up
Service apiext (dockerhostid-anchore-engine, http://anchore-engine:8228): up
Service analyzer (dockerhostid-anchore-engine, http://anchore-engine:8084): up
It seems ok. So, I try to use the command:
docker exec -t -i <your_anchore_container> curl -u admin:<pw> http://localhost:8087/v1/status

And it returns:
{
  "available": true,
  "busy": false,
  "db_version": "0.0.6",
  "detail": {
    "service_state": "available"
  },
  "message": "all good",
  "up": true,
  "version": "0.2.1"
}

It still seems ok. So then, I try this:
docker logs <anchore_container> | grep -v 'service:' | grep -v 'checking'

This time, it returns:
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
/1.1" 200 143 "-" "python-requests/2.17.3"
service process exited at (Sat May 12 09:56:05 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
service process exited at (Sat May 12 09:56:07 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
e:simplequeue] 2018-05-12 09:56:08+0000 [-] "<IP_ADDRESS>" - - [12/May/2018:09:56:07 +0000] "GET /v1/leases/analyzer_queue HTTP/1.1" 200 89 "-" "python-requests/2.17.3"
service process exited at (Sat May 12 09:56:10 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config

[12/May/2018:09:56:11 +0000] "GET /v1/leases/analyzer_queue/acquire/?client_id=9924cbb3cdaa:17:140490428364544:&ttl=60 HTTP/1.1" 200 143 "-" "python-requests/2.17.3"
service process exited at (Sat May 12 09:56:13 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
service process exited at (Sat May 12 09:56:15 2018): process exited: 1
exiting service thread
asks/?wait_max_seconds=30&visibility_timeout=0 HTTP/1.1" 200 465 "-" "python-requests/2.17.3"
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
service process exited at (Sat May 12 09:56:18 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
2018:09:56:19 +0000] "GET /v1/queues/watcher_tasks/?wait_max_seconds=30&visibility_timeout=0 HTTP/1.1" 200 465 "-" "python-requests/2.17.3"
service process exited at (Sat May 12 09:56:22 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
+0000] "GET /v1/queues/watcher_tasks/?wait_max_seconds=30&visibility_timeout=0 HTTP/1.1" 200 465 "-" "python-requests/2.17.3"
equests/2.17.3"
service process exited at (Sat May 12 09:56:26 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
service process exited at (Sat May 12 09:56:29 2018): process exited: 1
exiting service thread
.1" 200 465 "-" "python-requests/2.17.3"
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
service process exited at (Sat May 12 09:56:32 2018): process exited: 1
exiting service thread
restarting service anchore-policy-engine
/bin/twistd --logger=anchore_engine.subsys.twistd_logger.logger --pidfile /var/run/anchore-policy-engine.pid -n anchore-policy-engine --config /config
18:09:56:33 +0000] "POST /v1/queues/watcher_tasks/?qcount=0&forcefirst=False HTTP/1.1" 200 5 "-" "python-requests/2.17.3"
service process exited at (Sat May 12 09:56:35 2018): process exited: 1
exiting service thread
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/anchore_manager/cli/service.py", line 140, in startup_service
raise Exception("process exited: " + str(rc))
Exception: process exited: 1

I think problem might be here but I can not explain it. Can you help me? Thanks a lot!

hi @mkloveyy ,
I wanted to check in to see if there are still any pending issues/questions on this topic, or if the issues have been resolved in your setup?


do not require Status as a property in iam.AccessKey

Greetings,
Thank you for this excellent software. Per the following documentation:
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-accesskey.html
'Status' is not a required property of IAM::AccessKey. I do not know what examples the OP was referring to, but IAM::AccessKey does actually default to 'Active'
Thanks!
Niko

Thanks!


Settings are not restored after restart

I noticed something rather odd, even though the clickopener.properties file is getting written correctly and there is no exception when loading the file either, the settings aren't properly restored. I have to manually add the allowed items back after every restart.
Looking into the code, is it possible that loadFromProperties() is missing a call to readBlocks()? I might be missing something, but it looks like loading the config from file is only reading the key and the default value, but not the manually defined blocks.

That was totally the case. I don't know how I messed that up. Try https://modrinth.com/mod/clickopener/version/2.0.3+1.19.3

Dang you're quick! :D Works like a charm, thanks! 👍


Merge acl_dict and acl_groups

acl_dict and acl_groups share the same namespace. Let's merge them.

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #133   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9     10    +1
  Lines        1050   1086   +36
=====================================
+ Hits         1050   1086   +36

Impacted Files
Coverage Δ

ldap2pg/validators.py
100% <100%> (ø)

ldap2pg/config.py
100% <100%> (ø)
:arrow_up:

ldap2pg/acl.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a84212...923b7b0. Read the comment docs.


.coveragerc is being treated as a Python file

Type: Bug
pylance reports 28 problems with .coveragerc with the following contents:
# .coveragerc to control coverage.py
[run]
branch = True
source = fipt
# omit = bad_file.py

[paths]
source =
    src/
    */site-packages/

[report]
# Regexes for lines to exclude from consideration
exclude_lines =
    # Have to re-enable the standard pragma
    pragma: no cover

    # Don't complain about missing debug-only code:
    def __repr__
    if self\.debug

    # Don't complain if tests don't hit defensive assertion code:
    raise AssertionError
    raise NotImplementedError

    # Don't complain if non-runnable code isn't run:
    if 0:
    if __name__ == .__main__.:

It would be nice if I didn't have to see those 28 problems listed in my PROBLEMS pane.
Extension version: 2024.8.1
VS Code version: Code 1.91.1 (f1e16e1e6214d7c44d078b1f0607b2388f29d729, 2024-07-09T22:07:54.982Z)
OS version: Darwin x64 22.6.0
Modes:
Connection to 'ssh-remote+p910' could not be established

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
10, 10, 8

Memory (System)
16.00GB (0.65GB free)

Process Argv
. --crash-reporter-id 3f07fb8a-5ad9-42c5-8adc-b356ee746809

Screen Reader
no

VM
0%

Connection to 'ssh-remote+p910' could not be established

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
9c06g630:31013171
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
impr_priority:31102340
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-c:31111717
wkspc-ranged-t:31111713

This can be reproduced with no extensions installed/enabled, so transferred to the VS Code repo.
VS Code seems to be treating .coveragerc as a Python file:

I can see why our model guesses Python, good example to track in our meta issue. Thanks for opening.
https://github.com/microsoft/vscode/issues/131450


convert model failed: ValueError: Unknown loss function:quad_loss

Hi,
I'm trying to convert my .h5 model to .json file on Ubuntu16.04 with keras==2.2.4
tensorflow-gpu==1.12.0.
My .h5 model file can be download here: https://drive.google.com/open?id=1QVQiS4rsCuHFoQw-tarYLw6EqegIzMfD
I get this error:
Traceback (most recent call last):
File "keras_to_tensorflow.py", line 183, in
app.run(main)
File "/usr/local/lib/python3.5/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.5/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "keras_to_tensorflow.py", line 129, in main
model = load_model(FLAGS.input_model, FLAGS.input_model_json, FLAGS.input_model_yaml)
File "keras_to_tensorflow.py", line 106, in load_model
raise wrong_file_err
File "keras_to_tensorflow.py", line 63, in load_model
model = keras.models.load_model(input_model_path)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/saving.py", line 419, in load_model
model = _deserialize_model(f, custom_objects, compile)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/saving.py", line 312, in _deserialize_model
sample_weight_mode=sample_weight_mode)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/training.py", line 139, in compile
loss_function = losses.get(loss)
File "/usr/local/lib/python3.5/dist-packages/keras/losses.py", line 133, in get
return deserialize(identifier)
File "/usr/local/lib/python3.5/dist-packages/keras/losses.py", line 114, in deserialize
printable_module_name='loss function')
File "/usr/local/lib/python3.5/dist-packages/keras/utils/generic_utils.py", line 165, in deserialize_keras_object
':' + function_name)
ValueError: Unknown loss function:quad_loss
How can I fix this error? Can you help me?

Check this thread: https://github.com/amir-abdi/keras_to_tensorflow/issues/46


docs: first draft governance proposal

I think this is a good start, we should really take time to consider the agreement model. Consensus seeking can be difficult, especially when it comes to the rules we choose which might be highly contentious. I am not saying I strongly oppose it, but I think it might cause problems to take this approach so we should be sure we understand the tradeoffs before adopting it. After we get a general direction set I will probably have more detailed feedback on the wording.

Closing as it is stale. Suggestion to look at neostandard.


get score commit

Not sure where the player and the gems/rocks will get contact to add or drop points, but heres my idea for the first part of the scoring

Looks good. I'll merge this with my branch. :)


Prepare pinger and availcreator for Metrics 0.3.5

@jmazzitelli could you please review?

don't forget that we need to rebase this on current master since some changes (in assembly build and in agent) are needed there

we need to rebase this on current master

This ATM is on top of the current master.

Well, it says "into hawkular:metrics-next" at the top.


Reusable DataAccessModule

Currently, the DataAccessModule can handle only one DataAccessModuleListener. Thus, each DataAccessModule can only be used for one dereference request or you would have to implement a DataAccessModuleListener that implements the listener pattern again.
A better design decision would be to add the following methods to the DataAccessModule:
addListener(DataAccessModuleListener listener)
removeListener(DataAccessModuleListener listener)
The questions remains, how can you identify, which DerefResponse or ErrorResponse belongs to which deref request. There fore the response classes might provide a method:
isResponseForDeref(long encodedIRI)

Done.
I changed single object listener to list.
For the second part: you can identify which response message belongs to which request by comparing the encoded IRIs of them.


Update system text json to version 9.0.0

@pauldendulk I was asking https://github.com/Mapsui/Mapsui/discussions/2808

@IldarKhayrutdinov And why do you need that? Is that the only thing blocking the use of .net9?

If I add a direct dependency in my app, it seems to work fine with net9, as far as I have tested by now.

Yes, I have direct dependency. System.Text.Json v9.0.0 supports .net8, there are no obstacles to using v9.0.0 in mapsui (on .net8).


nested type arguments is derived to List type,actually not List

exception message:
Exception in thread "main" com.alibaba.fastjson.JSONException: exepct '[', but {, pos 21,
this is the demo to reproduce the problem:
https://github.com/drgnchan/fastjsonbugdemo.git
i dont know if i am using the wrong style.

now this can close.
@drgnchan

Has this problem been resolved? I found that using generics in List seems to cause problems.

https://github.com/drgnchan/fastjsonbugdemo/pull/1
@Certseeds provides another way to resolve the problem.

https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/parser/deserializer/ArrayListTypeFieldDeserializer.java#L163-L185
In ArrayListTypeFieldDeserializer.java, determine that the current character is [ in line 164, get the next character in line 170, and then go to line 184, ready to parse an array.

https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/parser/deserializer/ArrayListTypeFieldDeserializer.java#L184

It jump to CollectionCodec.java;
https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/serializer/CollectionCodec.java#L110-L129

https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/serializer/CollectionCodec.java#L126

Then, jump to DefaultJSONParser.java.
https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/parser/DefaultJSONParser.java#L733-L742

In DefaultJSONParser.java, it again judges whether the current character is[, but the character position has been moved to the next of [ above.
I don't quite understand this place.

In DefaultJSONParser.java, it again judges whether the current character is[, but the character position has been moved to the next of [ above.

actually when deserialize the list item,the itemTypeDeser is derived to be CollectionCodec.so it again judges whether the current character is [.
https://github.com/alibaba/fastjson/blob/14a95cc5b07e76ab8c0c72192c1e739cb157c7fc/src/main/java/com/alibaba/fastjson/parser/deserializer/ArrayListTypeFieldDeserializer.java#L106-L111
in my opinion,it is odd.

PS:
in fact,

this can also solve the problem

问题不是出在解析上,而是typereference不带参数的初始化只针对单层泛型有效,多层嵌套就得像上图一样加参数

问题不是出在解析上,而是typereference不带参数的初始化只针对单层泛型有效,多层嵌套就得像上图一样加参数

OK, Thanks.


Fix Pipeline

Fix emit transaction failed: error_class=NameError error="uninitialized constant Fluent::ReemitOutput::V12EventRouter::Pipeline"

can you remove the increment version commit?

Done

Thanks!

Released v0.2.1!


Vertical mode not discoverable

I read numerous feedback that people can not find the vertical mode in merge editor. For example: https://twitter.com/ACSoko/status/1566814542646185986?s=20&t=GtES_eoS52ESMCCOADr3AQ
Opening this issue so we consider if this deserves to be a primary action and not behind .... The problem with the ... menu is that there are multiple of those and they are not very discoverable.
I would also suggest we remove the "Split Editor Right" action. I think it just takes up space and it could be used by a merge editor specific action. I know @bpasero is against this. Would it help if I find numbers how many users click on this?
I am not sure if putting it in the primary action is the way to go, but would like to hear your thoughts.
fyi @daviddossett

How about changing the default mode?

Agreed. This was on my list for this iteration too. I'll find an icon that would be suitable if promoted to the main toolbar.
Would be very curious on how other's feel about the vertical mode being the default. IMO that would be an easier case to make if we used the IntelliJ-style arrow buttons instead of checkboxes. But curious to hear more thoughts.

What about bringing back the toolbar button with the current state represented by the icon?

Also all-in for having this as a top-level submenu.

Yeah! Looks great as a top-level submenu.
Let's not change the default layout yet. There are a lot of moving pieces and would like to minimise those if possible.


Esteban/integrate users with categories

Dev Summary

This PR proposes to store the users' interests in an interests field of type JSONB instead of adding a new many-to-many table. The trade-off is that if a specific categories record changes, the list of interests won't change automatically. The assumption is that the user will be able to update their interests in their profiles as they wish. In that case, a new interest list can be stored in the interests  field.
The PR also includes

a working service method to query the users based on a list of interests
a new method in the categories service to validate a list of categories
2 new custom dto validators to validate the correct shape of the JSONB interests object

Test Plan

repro steps:

run the app.
register a new user

curl --location 'http://localhost:3001/api/auth/register' \
--header 'Content-Type: application/json' \
--data-raw '{
    "firstName": "Billie",
    "last_name": "Eilish",
    "email"<EMAIL_ADDRESS>    "password": "Secret1234%",
    "email_notification_opt_out": true,
    "city": "seattle",
    "state": "wa",
    "interests": {
        "names": [
            "furniture"
        ]
    }
}'

log in and expect to see a response that includes the the interests field:

.....
        "interests": {
            "names": [
                "furniture"
            ]
        }
.....

validate categories endpoint should return true when the categories are valid, otherwise, false

curl --location 'http://localhost:3001/api/categories/validate' \
--header 'Content-Type: application/json' \
--header 'Cookie: NEH_is_cool={your_cookie}' \
--data '[
    "paper products",
    "furniture"
]'

Resources

postgres JSONB with typeorm

Is anyone going to review this ? @jd2rogers2  @brodylosh @rmwerner18 @EtoKruto

Is anyone going to review this ? @jd2rogers2 @brodylosh @rmwerner18 @EtoKruto

Thanks for checking in @garimacha , I tagged the engineers here for visibility, mostly.


Automated cherry pick of #2487: huawei & aws bugfix

Cherry pick of #2487 on release/2.11.
#2487: huawei & aws bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@295a6ac). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2489   +/-   ##
==============================================
  Coverage                ?   7.06%
==============================================
  Files                   ?     454
  Lines                   ?   71810
  Branches                ?       0
==============================================
  Hits                    ?    5075
  Misses                  ?   66317
  Partials                ?     418

Flag
Coverage Δ

#aFlag
7.06% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295a6ac...c83988b. Read the comment docs.

/lgtm

/approve


Key management scenarios

This reopens #23 on the new branch.

In general I have one question.
Do we need to document some steps in the scenarios regarding the following?

If I used my compromised key to sign any releases in any target collection that means I will have to resign those releases with a new key (notary v1) before I can remove that compromised key.
Should we include that step in the scenario? I think that could be automated server side when swapping out a key.

What if that delegation key was added on multiple targets? shouldn't we have a scenario where a end-user can easily swap out that key with a new one on all the given targets (or server side recursively find those targets it was used). Also here the automation to resigning/rotating releases using that key could/should be automated for convenience of the end-user.
Should we include this kind of scenario as well? Currently in notary v1 I think the focus on end-user is lacking. E.g. the IT support user managing that for a group of people in the organization or the junior developer who just wants to make a release and has no deep knowledge on the topic of encryption and TUF.

Why not speaking about the best practice in term of key management which is to use a physical or virtual HSM device ?
As an exemple Azure KeyVault is certified HSM fips 140-2 level 2, so it allows to generate signing key, associate a cert to it and let you sign with an API call without never being able to retrieve the key. No one can read the key, including Azure admins.
On AWS a lot more expensive solution is AWS CloudHSM, and after there is other options.
But for information, if you want to buy an Extended Validation (EV) Signing cert, you have to store the key on a fips 140-2 level 2 to be able to buy your cert. That means, you certify that no one, including you, can retrieve the key.
After that... Obviously you have to secure your HSM API access ^^

@mnm678 Would you mind closing this PR since no activities for more than 6 months? You can create a new issue to describe the problem if needed. Thanks.


BrightAmbience

Hello,
BrightAmbience seems useful for a specific (but musically-relevant) use case, gated reverbs. Could you please port it? Thank you!

BrightAmbience: 32376458
BrightAmbience2: b1ae1d5f
BrightAmbience3: 3cd54975


How do I use the --tags option with CFNCluster?

Copied from customer issue
Use-case: I had a customer case where the customer tried to add tags to their CfnCluster. The customer and myself attempted to use the --tags parameter like so ($ cfncluster create mycluster --tags Key=string,Value=string). Unfortunately this and many of the other examples on how to add tags in our public documentation result in returning an error.
Solution: To correctly use the --tags parameter you will need to input a specially formatted JSON list encapsulated by single quotes: '{"Keystr":"Valuestr"}'
Issue: There are no mentions of the usage of --tags parameter in the CfnCluster documentation. In the CfnCluster CLI there is only proof that --tags/-g is a parameter. To my knowledge there is no public information on the usage of --tags. I had to examine the source code of the CfnCluster tool and bruteforce different JSON formats for the tool to accept my list. Overall I can see how this would be a negative experience for a customer, as I experienced this myself.
Proposed Action(s): In the public documentation note the usage of --tags and give an example. Possibly expand this to the other parameters like --extra-parameters and --norollback.
Please let me know if you have any additional questions. Thanks!

@mohanasudhan, we can push doc updates without doing a release, so this doesn't have to wait for 1.3.3....

fix https://github.com/awslabs/cfncluster/pull/205

Merged the fix. closing


Realm generator rejects const values saying initialization must be const

What happened?
Using constant classes or negative numbers used to work for initialization.  When upgrading from 1.6 to 2.0, this no longer works:

Field initializers must be constant

in: package:sustain/model/data/picture.dart:19:14
    ╷
16  │ @RealmModel()
17  │ class _Example {
    │       ━━━━━━━━ in realm model for 'Example'
... │
19  │   double y = -1;
    │              ^^ Must be const
    ╵
Ensure the default value for field "y" is const

Repro steps
Create a class with integer or float field and try to initialize it to a constant negative value.
Presumably this would work (or rather fail to work) with any other class that provides a const constructor.
Version
2.0.0
What Atlas Services are you using?
Local Database only
What type of application is this?
Flutter Application
Client OS and version
Linux
Code snippets
@RealmModel()
class _Example {
  double x = 0;
  double y = -1;
  int z = -1;
}

Stacktrace of the exception/crash you're getting
No response
Relevant log output
[SEVERE] realm:realm_generator on lib/model/data/picture.dart:

Field initializers must be constant

in: package:sustain/model/data/picture.dart:19:14
    ╷
16  │ @RealmModel()
17  │ class _Example {
    │       ━━━━━━━━ in realm model for 'Example'
... │
19  │   double y = -1;
    │              ^^ Must be const
    ╵
Ensure the default value for field "y" is const

Hi,
Same issue here, any workaround?

We're aware of this and will address it with a future release. Currently, the only known mitigation is to downgrade to 1.6. I'm sorry for the regression.

Apparently -1 is not a literal to the Dart analyzer

True, but even if it was, checking for literals is not a good solution.
Const variables are legal initializers, but are not literals.
On Wed, Mar 27, 2024, 04:51 Kasper Overgård Nielsen <
@.***> wrote:

Apparently -1 is not a literal to the Dart analyzer
—
Reply to this email directly, view it on GitHub
https://github.com/realm/realm-dart/issues/1606#issuecomment-2022462090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGJZQCOKM3EMHJKIIPTR4Q3Y2KJALAVCNFSM6AAAAABFHRN6JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGQ3DEMBZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

That looks like a great improvement.  Unfortunately there are still some cases that cause false errors.  Here is an example:
import 'package:dart_numerics/dart_numerics.dart' as numerics;
const int myconst = 1;
@RealmModel(ObjectType.embeddedObject)
class $Test {
  ObjectId id = ObjectId();
  int value1 = myconst;
  int value2 = numerics.int64MinValue;
}

If I comment out the new const test, this generates legal dart.

@derrickgw Thank you for your observation. I have created #1612 to handle value1 and value2.
But this const check was added explicitly to disallow ObjectId id = ObjectId(), so that is still not allowed.
Consider:
@RealmModel()
class _Stuff {
  ObjectId id = ObjectId();
}

Which is legal with realm_generator 1.9.0.  If you look at the generated class, you will find that is illegal because it lifts the initializer expression and uses it as the default value of the optional parameter id on the generated constructor.
Stuff({
    ObjectId id = ObjectId(), // <-- this is not valid Dart, as default values must be const
  }) {


Accept resolve alias in custom webpack config

React native web project requires aliasing it to react-native to keep it like React native.

Now we've enabled this. Use version 1.5.0.
See: #64 for more information.

@arunoda ,
I'm having some trouble resolving an alias. storybook version: 1.28.1
./storybook/webpack.config.js resolve block:
  resolve: {
    alias: {
      foo: path.resolve(__dirname, 'bar.js')
    },
    extensions: ['', '.js']
  }

import foo from 'foo'; just doesn't seem to get resolved (undefined). I've verified the file path gets resolved. What am I doing wrong?

@dziamid We had a bug in the latest storybook release. We patched and released a new version. Could you try the latest version (v2.15.1)

I'm using react-native-web and I want to share stories between web and native, so I have 2 separate configurations for storybook but 1 stories folder.
In stories I need to import storiesOf but import it from either @storybook/react or @storybook/react-native
So I came up with this:
const defaultConfig =<EMAIL_ADDRESS>  .default

module.exports = Object.assign(defaultConfig, {
  resolve: Object.assign(defaultConfig.resolve || {}, {
    alias: Object.assign(
      (defaultConfig.resolve && defaultConfig.resolve.alias) || {},
      {
        '@storybook/react': '@storybook/react-native',
      },
    ),
  }),
})

and I'm using import { storiesOf } from '@storybook/react'
But it still outputs the error, Can't find variable: document which means alias is not working


Feat/attempts

fix #16

Coverage increased (+0.5%) to 80.181% when pulling e559d7764e23710d40f55c46705f3d918b2fa696 on feat/attempts into 8c4bb35f9b8160d29b33ea31542c1ef0026447cb on master.


iOS: Scroll broken if map is moved up

I'm submitting a ...  (check one with "x")

[ ] question
[X] any problem or bug report

OS:  (check one with "x")

[ ] Android
[X] iOS
[ ] Browser

cordova information:  (run $> cordova plugin list)
cordova-plugin-googlemaps 2.6.2 "cordova-plugin-googlemaps"
cordova-plugin-whitelist 1.3.4 "Whitelist"
If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
@ionic-native/core :
@ionic-native/google-maps :

Current behavior:

There is a scroll problem when the app doesn't fit in one page. For instance if you add text below the map.
If you scroll down hidding part of the map. The map continues detecting touches on the text that occupies the position where the map was before. Broking this way the scroll
In the following video, after scrolling up I am touching in the text not in the map:
Video with Problem
Expected behavior:

When the map dissapears from screen, if you touch in the position were the map was,  the map shouldn't respond to this touches
Screen capture or video record:

Related code, data or error log (please format your code or data):
You only need to follow the installation guide and replace index.html by this one https://github.com/fsvilas/html-bug-cordova-google-maps/blob/master/index.html
Support this plugin activity
I appreicate if you give me a beer :beer: from here

I don't open any zip file. Please upload video to YouTube (unlisted)

Video: https://vimeo.com/371462655

Thanks, but I couldn't understand where you touch on.
But this plugin displays a map under HTML

Before scrolling the area that occupies the map and that receives the events is:

After scrolling, the map's position is properly updated but the touch events over the red area are being received by the map, so if you try to scroll in the "Lorem ipsum..." text part, instead of scrolling the webview, you move the map:

Could be a problem due to the transparency area are not being properly updated?
You can reproduce the problem simple by following the installation guide and replace index.html by this one https://github.com/fsvilas/html-bug-cordova-google-maps/blob/master/index.html. In it I added some text after the map
Thanks

Please try to wrap with a
 for a map_canvas and text.

    <meta name="viewport" content="width=device-width">

Hello, World!

          Lor... tortor.

Yes, this way it works properly, if you surround both divs with

If the id is different to  container it seems that it doesn't work
Thank you very much


GoogleAppMeasurementOnDeviceConversion.xcframework possibly not including Mac Catalyst

GoogleAppMeasurementOnDeviceConversion.xcframework:1:1: error: While building for Mac Catalyst, no library for this platform was found in '.....GoogleAppMeasurementOnDeviceConversion.xcframework'. (in target 'GoogleAppMeasurementOnDeviceConversion' from project 'GoogleAppMeasurement')

OnDeviceConversion is currently only supported for iOS.

is this occurring because of architecture difference of apple silicon and the framework?

This is likely appearing because the FirebaseAnalyticsOnDeviceConversion.xcframework is being used in a scheme building for macCatalyst. As Paul said, the FirebaseAnalyticsOnDeviceConversion SDK is only supported for iOS, and should be excluded in Catalyst builds.


feat: add Konamimojisplosion package

Overview

Adds a @codecademy/konamimojisplosion package exporting a React component that hooks up the Konami Code to trigger emojisplosion.

We already have this on codecademy.com/about/careers. This package will make it easier to put it everywhere.
PR Checklist

~[ ] Related to designs:~
[x] Related to JIRA ticket: WEB-1356
[x] I have run this code to verify it works
~[ ] This PR includes unit tests for the code change~ (lots of external dependencies, not a lot of logic)

🚀 Styleguide deploy preview ready!https://605c89ab392c561bd05402fc--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605c8d4abb9bf31c58363345--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.2.35-alpha.83e00c.0@codecademy/gamut-labs@13.1.5-alpha.83e00c.0@codecademy/gamut@29.4.3-alpha.83e00c.0@codecademy/konamimojisplosion@0.1.1-alpha.83e00c.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605c96b47204d925fd8b4420--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.2.35-alpha.e5242d.0@codecademy/gamut-labs@13.1.5-alpha.e5242d.0@codecademy/gamut@29.4.3-alpha.e5242d.0@codecademy/konamimojisplosion@0.1.1-alpha.e5242d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605c9919bb9bf3283e3634eb--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605c9d845a958a33e0ad28dd--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605ca3453946a247125c2dd4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://605ca9c9ed9ffd4c7866200e--gamut-preview.netlify.appDeploy Logs


SolidParticleSystem is not empty when addShape() is used with nb parameter of 0

Use Github issues ONLY for bugs validated on the forum first!
I could not find this issue discussed on the forum.
When creating a SolidParticleSystem, calling addShape() with an nb param of 0 does not result in an empty mesh - there's a single particle in there as also reflected by the nbParticles attribute of the SPS.
Repro
https://playground.babylonjs.com/#W6PNJ7#1
Screenshots
See "Repro" above.
Desktop (please complete the following information):

OS: windows, macOS, probably others.
Browser: Safari, probably others.

Additional context
Calling addShape() with This may seem like a strange thing to do, but I'd like to always have a "valid" SPS / mesh in my data even when the number of particles contained in the SPS is zero.

We only use the forum for validated issue on the forum first. it would be great if you could move the conversation there first: https://forum.babylonjs.com/
The system has unfortunately not been build like this mostly for perf reasons I believe. Basically every meshes has an extra cost associated to it and if you have no particles, the shape would not even be stored and therefor buildMesh() does "create" a triangle to  return a none empty mesh I guess.
Let s discuss it more on the forum to better understand the use case. Closing for now.


TaskCanceledException with SendMessageAsync

This is an intermittent problem that I'm having when trying to send a message.
Stacktrace 1: https://hastebin.com/vigocomafa.pas
Line: https://github.com/SubZero0/DiscordNet-Docs/blob/master/src/DiscordNet/Handlers/CommandHandler.cs#L68
Stacktrace 2: https://hastebin.com/noyozisenu.cs
Line: https://github.com/SubZero0/DiscordNet-Docs/blob/master/src/DiscordNet/Modules/Commands.cs#L173
In the first stacktrace I'm just sending one message, there's no reason to trigger the ratelimit, so I guess Discord.Net is trying to send it (and failing) a lot of times and triggering it itself (?).
Additional infomation:
The bot is hosted on a Ubuntu 14.04 server with .NET Core 1.1.
I couldnt reproduce on Windows 10.
I will probably try running the bot on another OS, like Ubuntu 16.04/CentOS/Debian, with a fresh install.
I accept suggestions as well for what should be causing it or which OS should I try. =p

I suggest turning on debug logging which will show all outgoing requests and if there are any clustered together before the ratelimit is triggered.

Couldnt get the ratelimit again. But the error is still there.
Log with debug (the log starts when I sent the message):
Async command handler:
1- https://hastebin.com/akexewinag.cs
2- https://hastebin.com/dirovuxide.cs
Sync command handler:
1- https://hastebin.com/afeyasodab.sql
As it's possible to see, it receives the message but freezes the handler since the POST log only appears shortly before the exception.
The Sync approach makes the bot lose connection since it freezes the heartbeat. It's possible to see there's no long running method inside the "info" command (https://github.com/SubZero0/DiscordNet-Docs/blob/master/src/DiscordNet/Modules/Commands.cs#L173).

Tried changing the OS to CentOS 7.1 and Ubuntu 16.04 but the error still persists.
No idea what could be causing it :S

There's only two things that should be able to cause a TaskCanceledException: logging out of the client (or disposing of it), or canceling the CancellationToken passed via RequestOptions, if any.

I think it was related to where it was hosted.
I don't know what was causing it but I changed my host and it looks like it's working fine.
I'll close this since it doens't look like an API-related issue.
Thanks Voltana.


Graphics model

Including Debug will not include Collage or Element
Public types are re-exported from the same module as before.
Private types which were exposed before are now hidden: BasicForm, ShapeStyle, FillStyle, ElementPrim, ImageStyle, Three.
Since no one should have been using the private types, I don't expect any breaking changes from the Graphics.Model refactor.

Big question: why is it important and valuable to do this instead of focusing on dead code elimination? Long term, that will be implemented, and it seems like these changes are not desirable in that world.

Yes. I've said before: dead code elimination enables good API design.
So let's drop this, but remember to keep DCE on the roadmap.

Sounds good, it should be really fun to work on that :)


Update Readme.md

Seems to be outdated

yeah.. feel free to fix it up - i feel this issue is not needed for it.


Question about cash()

Hello,
I would like to ask what's the idea behind the cash() of the HedgeLoss ABC? Currently, the Hedger.price() ends up producing the output adjusted for the 'loss' measure, not really the derivative price itself.
e.g. the following example returns the invalid price of the instrument:
torch.manual_seed(42)

# Prepare a derivative to hedge
deriv = EuropeanOption(BrownianStock(), strike = 100.0)

# Create your hedger
model = MultiLayerPerceptron()
hedger = Hedger(model, ["log_moneyness", "expiry_time", "volatility", "prev_hedge"])

# Fit and price
hedger.fit(deriv, n_paths=10000, n_epochs=200, init_price = 100.0)
price = hedger.price(deriv, n_paths=10000, init_price = 100.0)
print(f"Price={price:.5e}")

Can you please elaborate on this idea? I guess I am missing something

Thank you for your interest.
The idea behind HedgeLoss.cash is the assumption that HedgeLoss is a normalized cash equivalent (\rho with the notation of the Deep Hedging paper; we use this notation henceforth) and stock price follows the Martingale process.
The output of HedgeLoss.cash, denoted cash, satisfies \pi(-Z) = \rho(cash) provided that the profit-loss is optimized. Then the RHS is shown to be \rho(cash) = -cash + \rho(0) = -cash + \pi(0) by the cash-equivalence of \pi and Proposition 3.10 in the Deep Hedging paper. A short algebra gives \pi(-Z - cash) = \pi(0), which implies that -cash is the derivative price (i.e., the solution to \pi(-Z + price) = \pi(0)).
I hope it makes sense.

As to the example you provided: Hedger by default uses EntropicRiskMeasure whose cash is overridden by the direct definition of exponential utility indifference price and should be correct.

Sorry for the delay. I think I didn't make my question clear. The output of the code that I have provided is incorrect. It shows the price of 3.7 while it should be around 2.3.

Thank you for clarifying.
I think that may be because MultiLayerPerceptron has not learned yet to hedge.
In my experience usual feed-forward neural network takes a quite long time to learn.
We can make sure that Hedger.price() is correct as follows: In the absence of transaction cost (and at the limit dt -> 0), Black-Scholes' continuous hedging is the optimal hedging strategy. The price corresponding to this strategy is 2.28313e+00 which is around 2.3.
import torch
import pfhedge
from pfhedge import Hedger
from pfhedge.instruments import BrownianStock
from pfhedge.instruments import EuropeanOption
from pfhedge.nn import BlackScholes

torch.manual_seed(42)

deriv = EuropeanOption(BrownianStock(), strike=100.0)

model = BlackScholes(deriv)
hedger = Hedger(model, model.features())

price = hedger.price(deriv, n_paths=10000, init_price=100.0)
print(f"Price={price:.5e}")

Thank you for your message. I guess this is a bug because I see that the price is not converging to 2.3 with more epochs/paths.

You may want to increase the number of units per layer. Also, prev_hedge is not necessary for this case. I got Price=2.32866e+00. Sorry that the example in README.md is misleading.
import pfhedge
import torch
from pfhedge import Hedger
from pfhedge.instruments import BrownianStock
from pfhedge.instruments import EuropeanOption
from pfhedge.nn import BlackScholes
from pfhedge.nn import MultiLayerPerceptron

torch.manual_seed(42)

deriv = EuropeanOption(BrownianStock(), strike=100.0)

model = MultiLayerPerceptron(n_units=128)
hedger = Hedger(model, ["log_moneyness", "expiry_time", "volatility"])

hedger.fit(deriv, n_paths=10000, n_epochs=200, init_price=100.0)
price = hedger.price(deriv, n_paths=10000, init_price=100.0)
print(f"Price={price:.5e}")


Darkroom trouble shooting

Hello @jameshegarty  @jbrunhaver ,
DARKROOM_troubleshoot.pdf
My names is Olivier and I'm a current Master student at Carleton University. I'm working on a project which would use Darkroom if possible.
I am however facing issues with Darkroom so far. I'm using Ubuntu 18-04, the gitHub Darkroom as well as Terra 1.00 beta-1.zip
from the release as the 2015-08-03 won't compile it's hello world and returns a higher failure rate when using its run tests  (453-70 vs 523-0).
Attached is a pdf with the key steps of both darkroom and terra setup. Any help would be greatly appreciated.
Have a good day,
Olivier

Hi Olivier,
I'll take a look next week when I'm my work computer to see if I've got a working installation of Darkroom left on the machine, and I'll let you know how it's configured.
  After Darkroom, we moved on to some other projects (Rigel and Halide-HLS), both of which are more capable and better-supported than Darkroom at this point.  It might be that one of these is a better fit for what you're trying to do.
Steven

Hey Olivier, thanks for your interest. As Steven mentioned, this repo is super old, I think the last real commit was in 2015, and it almost certainly doesn’t work with the latest version of terra. Depending on what you want to do with it, Halide may be a better platform if you want to benchmark for cpu, or Rigel or halide-hls If you want to compare to something for hardware. Unfortunately, the hardware backend for darkroom was never released. Happy to discuss more.
If you really want to get darkroom working, prob finding a version of terra from that era that runs and using that will be the easiest thing. Ie, that old terra with the broken tests may actually run darkroom fine? (Iirc some of the tests may have been cuda related and may have failed for unimportant reasons)

I was going to use darkroom for FPGA circuit design to compare to vivado's capabilities. Ive since seen in a previous issue that the export function wasnt released.
Thanks a lot. Ill take a look at HLS and Rigel.


terminal.external.windowsExec opened pwsh with title \\

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.2 (user setup)
OS Version: Windows_NT x64 10.0.22631

Steps to Reproduce:

create pure windows sandbox with powershell 7.x and vscode installed
update user settings to set "terminal.external.windowsExec": "C:\\Program Files\\PowerShell\\7\\pwsh.exe"
use Ctrl+Shift+C to invoke an external pwsh terminal
the terminal title showing \\

we have no control over the external terminal / what directory it opens to by default


New Website Logo: qmBase

Please fill the following out:

Name: qmBase
Homepage url: http://www.qmbase.com
Brand Guidelines/Licensing: http://www.qmbase.com/en/logo-usage/
Logo: (svg if possible, pngs over 500x200px with transparent backgrounds are also acceptable)

Example:
Name: Microsoft
Homepage url: https://microsoft.com
Brand Guidelines/Licensing: https://www.microsoft.com/en-us/legal/intellectualproperty/trademarks/usage/logo.aspx
Logo: https://news.microsoft.com/microsoft-news-center-photos/msft_logo_rgb_c-gray/

Thanks. Added to the site. Should be live next week.


bump version of scrivener

I've bumped version of scrivener to 1.0, because 0.10 was dependent on ecto < 1.0.0.
This was causing deps conflict such as:
Dependencies have diverged:
* ecto (Hex package)
  the dependency ecto

  > In deps/sqlite_ecto/mix.exs:
    {:ecto, "~> 1.0", [optional: false, hex: :ecto, manager: :mix]}

  does not match the requirement specified

  > In deps/scrivener/mix.exs:
    {:ecto, "~> 0.13.0", [optional: false, hex: :ecto]}

  Ensure they match or specify one of the above in your deps and set "override: true"
** (Mix) Can't continue due to errors on dependencies

And solving this problem by overriding, is not good for user experience with ex_admin it self.

Thanks for the contribution!!


Changed maxHpForNpcHitdice to HpForNPCHd

Changed maxHpForNpcHitdice to HpForNPCHd which can now be set to several options.  The old parameter will still work.  Added functions to override some configuration items.

One thing worth discussing would be which configuration items to expose through python.  Also, this average works a bit differently than the one for PCs which randomly uses either floor or ceiling when rounding off.  This one rounds up as is D&D standard.

Could the option be added back into the game to allow you to select downed opponents as attack targets? I was getting some really annoying restrictions regarding this when I last played through the game, where it wouldn't let me perform attacks when clicking on opponents sometimes.

Could the option be added back into the game to allow you to select downed opponents as attack targets? I was getting some really annoying restrictions regarding this when I last played through the game, where it wouldn't let me perform attacks when clicking on opponents sometimes.

You can attack downed opponents, but you have to explicitly select attack from the radial menu, not as part of the default action click. It often happens that you click by accident and waste your attack.
That said, I guess it should be an option.

Since all comments have been good I am going to go ahead and merge it so anatoliy can test this out in his module.


2D and 3D input normalization with mean and std.

I noticed in data/data_h36m.py, you normalized the input 2D and 3D with mean and std with specific axes. Can I ask why this effect is too much to the results when I do not use this normalized function? Furthermore, why you would use invert y,z axes by multiplying them with -1?

Since the network is trained with this type of normalization, it expects all data to be normalized this way.
I believe I inverted the y-axis and z-axis just for visualization purposes.
You could retrain the model with different type of normalization, it shouldn't make much difference.


Show Qiskit depreciation logs in report

Summary
Adding the Qiskit depreciation logs in report issue
Details and comments
See #81

Closes #81
Epic #9

😄

😄 just to be 100% sure you merged it

I don't know why my fork always keeping those commit ^^'

So @IceKhan13 what do you thing of that :)


Feature led matrix

Webpage:
Where is the page for the led matrix?
reference the led matrix page in the led strip page


403 : auth refused even after signup

create app via generator
use app in android mode
signup
Boom : 403

resolved


No core x frequency

I have installed zen monitor and zen power but I don't see the core x frequency. Any suggestions would be appreciated along with any questions to help me further figure out why.

I' m just passing by, but as I see that you havent got an answer in a few days maybe this can help you:
is your module zenpower correclly installed and working? (DKMS or otherwise). This happened to me once because of that . Reinstalled the module, started again zenmonitor, problem solved.

I' m just passing by, but as I see that you havent got an answer in a few days maybe this can help you:
is your module zenpower correclly installed and working? (DKMS or otherwise). This happened to me once because of that . Reinstalled the module, started again zenmonitor, problem solved.

Thank you for the suggestions I did the zenpower module and even set it up to not need to be edited if rebooted. I followed all of the directions and have since even switched distros (ubuntu budgie to kde neon) and the issue is EXACTLY THE SAME. Everything seems perfectly function expect core x freq doesn't show anything. It's there its just like the picture above.

Did you load the msr module?


Capistrano can't find rake, but same command works over SSH

First off, I have to admit: I've been spamming this problem all over the place, including the rbenv repo, serverfault, and reddit. Due to the wide variety of responses, and the number of pieces involved, I'm not sure which component is misbehaving.
Basically, my issue is that the deploy:assets:precompile is failing. Capistrano output:
00:10 deploy:assets:precompile
      01 /home/deploy/.rbenv/bin/rbenv exec bundle exec rake assets:precompile
      01 bundler: failed to load command: rake (/var/www/framelinker/shared/bundle/ruby/2.6.0/bin/rake)

I've confirmed that I can execute this step manually over SSH, so this appears to be some environment-related issue where Capistrano is unable to find rake but an interactive login shell is able to find it.
Can someone walk me through how to diagnose this?
This issue came up after upgrading my server from Ubuntu 18.04 to Ubuntu 20.04. I am using ruby 2.6.1, my Gemfile.lock has bundler 2.2.6, config/deploy.rb has:
lock '~> 3.15.0'

https://capistranorb.com/documentation/faq/why-does-something-work-in-my-ssh-session-but-not-in-capistrano/
This is the standard place to look for information on this. Of course you know at least a bit about interactive and login shells, from what you wrote, but Capistrano doesn't use either interactive or (usually) login shells.
Some Linux distros give you a login shell even when they maybe shoulnd't. I suggest you follow the troubleshooting steps there.
RVM (or rbenv) are similarly require an interactive login shell (usually), unless you have tooling support such as https://github.com/capistrano/rbenv
In the end, the problem is probably that you're using the wrong ruby, and thus the wrong gems, and nothing is executing in the environment you expect.
Closing this, but if you suspect a bug please, let us know, I strongly suspect however that it's just incomplete configuration on your side.

No, I don't suspect a bug, but I am using capistrano/rbenv. I will try asking the same question in the 'capistrano/rbenv' repo.

Logging into the server and manually executing the following fixed/gave me a workaround for this issue:
/home/deploy/.rbenv/bin/rbenv exec gem update --system

@leehambley We've been using Capistrano for years with the same config and just updated to 3.15.0 and had this exact same issue with rake not being found. Tried gem update --system as @asfarley recommended and had no luck. Reverting to 3.14.1 fixes this problem.

@claptimes5 Thanks for being a long-time cap user! I don't doubt that you are running into this problem but I cannot determine any way that purely upgrading only capistrano from 3.14.1 to 3.15.0 could cause this. Here is the exact diff for those two versions that were published to rubygems:
https://my.diffend.io/gems/capistrano/3.14.1/3.15.0
I don't see anything that could be related? All 3.15.0 does is an extremely minor change to the git tasks. No other code was touched. Unless require "securerandom" has a side effect I am not aware of? (It would not be the first time Ruby surprised me!)
Did something else change in your setup beside just the capistrano version bump?
There have been some recent bugs in bundler that could cause the error, see:
https://github.com/search?q=bundler+"failed+to+load+command"+repo%3Arubygems%2Frubygems+created%3A>2021-01-01+state%3Aopen&type=Issues&ref=advsearch&l=&l=
And since bundler is now included with rubygems and with ruby installations in addition to be installable separately, it can be hard to know exactly what version(s) of bundler you have installed.
Bundler has a very surprising feature where it will automatically re-execute a different version of itself to match the BUNDLED WITH version in your Gemfile.lock. So if you changed the BUNDLED WITH line when you upgraded capistrano, you could have inadvertently caused a different version of bundler to execute at deploy as a result. That could explain the change in behavior.

@mattbrictson Thank you for your reply! I'll look into this more tomorrow. I don't think anything else changed, but you're right that there shouldn't be a difference (looking at the diff). Curious to hear if anyone else has this issue.

@mattbrictson just following up, looks like it was a config issue on our end. Related to a merge conflict in our Gemfile.lock.
Thanks again for your help!


[WIP] Dice coefficient class metric and unification

Add DiceCoefficient class
unify dice coefficient functional metric to use the same code

Hey @teddykoker, unless I am mistaken, the Dice coefficient metric is acutally equivalent to F1 metric (see here) - so wouldn't it make more sense to simply wrap F1?

Hey @teddykoker, unless I am mistaken, the Dice coefficient metric is acutally equivalent to F1 metric (see here) - so wouldn't it make more sense to simply wrap F1?

@tadejsv  Thats a great point! I'll do that

@tadejsv  Thats a great point! I'll do that

Hello @teddykoker! Thanks for updating this PR.

In the file pytorch_lightning/metrics/classification/dice.py:

Line 25:1: E302 expected 2 blank lines, found 1

In the file pytorch_lightning/metrics/functional/dice.py:

Line 19:1: E302 expected 2 blank lines, found 1

Hello @teddykoker! Thanks for updating this PR.

In the file pytorch_lightning/metrics/classification/dice.py:

Line 25:1: E302 expected 2 blank lines, found 1

In the file pytorch_lightning/metrics/functional/dice.py:

Line 19:1: E302 expected 2 blank lines, found 1

@teddykoker @tadejsv But if we simply wrap L1 here, we should probably change the default for averaging to macro since with micro you can get a value above 1, which does not make sense at all (for macro it should be fine if I'm not mistaken).

@teddykoker @tadejsv But if we simply wrap L1 here, we should probably change the default for averaging to macro since with micro you can get a value above 1, which does not make sense at all (for macro it should be fine if I'm not mistaken).

Hi @teddykoker, we are very happy that you decided to improve PL and opened this PR.
Never the less we have moved the metric package outside PT, to a separate repository - torchmetrics, and unfortunately, there is not GH option to transfer your opened PR there to finish the job there. So I would like to kindly ask you if you are able to finish this PR by end of this week and then we can transfer your merged commit to the new repo or please open the very same PR in the new repository... 🐰
Anyway thank you very much for being with us ⚡


COMPRESS-652: Support converting an existing ZIP file to a ZipArchiveOutputStream for appending

Description and rationale in a JIRA ticket: https://issues.apache.org/jira/projects/COMPRESS/issues/COMPRESS-652.
In addition to adding a test, I’ve verified manually that this works both for small (non-zip64) files and zip64 files with >64K entries in them. While it works, instantiating a ZIPFile on the latter seems to have a significant memory overhead. I intend to improve it, perhaps in another PR.

This seems to me like too much of a niche use case.
Let's see what others think.

Closing.


WIP: OpenAPI Annotations

@fre-pe What do you think? :) Also, I noticed that we had more endpoints in the openapi.yml than in the code. Do you think we need to add those methods just as "to-do"s?

@gsampaio-rh is this still applicable? ... or can it be closed out?


fix #489

Ⅰ. Describe what this PR did
Fix #489
Ⅱ. Does this pull request fix one issue?

fixes #489
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
A, B two processes, perform the following steps:

A initiates a global transaction
B registration branch transaction succeeded
B service processing time is greater than the RPC timeout period.
A receives the RPC timeout and initiates a global transaction rollback.
After the global transaction is rolled back, the business of B is processed.

Ⅴ. Special notes for reviews

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #572 into develop will decrease coverage by 0.13%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #572      +/-   ##
=============================================
- Coverage      31.65%   31.52%   -0.14%
  Complexity       765      765
=============================================
  Files            200      200
  Lines           7916     7949      +33
  Branches         937      939       +2
=============================================
  Hits            2506     2506
- Misses          5153     5186      +33
  Partials         257      257

Impacted Files
Coverage Δ
Complexity Δ

...baba/fescar/rm/datasource/undo/UndoLogManager.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790a3ce...c2a14be. Read the comment docs.

does this solution handles the situation

TC invoke rollback
and RM undo executed and log clean,
and TC receive RM return timeout
and TC call again

LGTM

does this solution handles the situation

TC invoke rollback
and RM undo executed and log clean,
and TC receive RM return timeout
and TC call again

TC invoke rollback but report timeout
when log clean ，just insert undolog to prevent local transactions from continuing
timeout->retry
when insert fake undolog and execute real undo-> success

does this solution handles the situation

TC invoke rollback
and RM undo executed and log clean,
and TC receive RM return timeout
and TC call again

TC invoke rollback but report timeout
when log clean ，just insert undolog to prevent local transactions from continuing
timeout->retry
when insert fake undolog and execute real undo-> success

You are right


section editor cannot edit article

if user is managar on any article workflow. user must be have edit privileges on article

It's obvious that if user has the right of alter article at wf, the one(s) can.