Feature Request: Custom AC Temperature

Describe the idea or improvement
I have a number of Mi/Aqara AC companions. These work great for control, but in the Home app the reported temperature is just the current set temperature of the AC, not the actual temperature. On Homebridge MIoT, I have a number of devices in the same room which are capable of reporting the temperature of the room. Primarily Mi Air Purifiers.
Describe the solution you'd like
It would be great if within miot setting pages I could select the temperature property of another device to replace the room temperature for the AC device within Home. This would significantly improve how the AC controller works in the Home app as it would correctly show ‘TEMP, cooling to SET TEMP’.
An example of this would be within the miot settings, I could easily select an air purifier already in the same room and already set up with miot to have this device be the temperature reading for the AC, instead of just the ‘set temperature’.
Additional context
For the relatively recent Aqara AC Companion device, they achieve a similar thing natively with a linked zigbee temperature and humidity monitor. It would be nice if we could replicate something similar to this with devices already connected and reporting temperature within miot.

Thanks for the request.
So do I understand it correctly that you want to use the temperature value from another device to show it on the ac companion?
If not could you describe the use case more detailed?

You've got it exactly right. If you see in the picture below it seems within HomeKit that there are two temperatures involved - the room temp and the 'set to' temp. So when the AC is on the thermostat (AC device) will show as say '27deg, cooling to 22deg'.
This way it would mimic how an actual AC/thermostat device works natively with HomeKit, plus mimic the significantly more expensive functionality of the native Aqara AC controller. Plus the temperature value of other devices in the same room is already right there within homekit-miot so it seems like it would be a great feature addition.

Well currently that is unfortunately not easily possible as the devices run independently and do not about their existence. That would require some architectural adjustments. Would need to think about that first.


Apply recursive mapped type to nested literal object types

Suggestion
🔍 Search Terms

alias
recursive mapped type
resolve mapped type

✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Given the following code:
type DeepReadonly<T> = {
  readonly [K in keyof T]: DeepReadonly<T[K]>;
}

type A = {
  num: number
  array: A[]
  object: {
    inner: A
  }
}

type B = DeepReadonly

If I request the shape of B to the LSP, I get the following shape:
{
  readonly num: number
  readonly array: readonly DeepReadonly[]
  readonly object: DeepReadonly<{
    inner: number
  }>
}

I suggest applying any mapped type to nested literal object types to get the following shape instead:
{
  readonly num: number
  readonly array: readonly DeepReadonly[]
  readonly object: {
    readonly inner: number
  }
}

This greatly improve readability and this is consistent with other non-named types: DeepReadonly<number> -> number, DeepReadonly -> readonly DeepReadonly[], ...

A one-level expansion is safe in all cases, but the problem here is that we don't really know that a recursive expansion of this type won't go on forever. You might have written this, for example:
type DeepBoxify<T> = {
  readonly [K in keyof T]: { value: DeepBoxify<T[K]>; self: DeepBoxify<T> };
}

type A = {
  num: number
  array: A[]
  object: {
    inner: A
  }
}

type B = DeepBoxify
declare let b: B;
// Legal; the type does not end
b.array.self.array.self.array.self.array.self.array.self;

We might have means to statically detect if this provably won't happen and do the full expansion only in those cases, but it might be tricky.


Add install documentation

and...

Update initial readme to reflect recover and relocate
Add other under construction doc titles

Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

@vdeenadh Went through this again, I am ok with the content. In case it is fine, we can merge this PR. Thanks!


fix(readme): add an import of TEXT

Add an import code of TEXT from itchat.content in section "Multi instance"

@jtr109 My fault :frowning:


Block.getNumPins broken for C5G7 model :: multiple cladding components per lattice site

If you load the C5G7 test reactor and grab an assembly, you get a hilariously large number of pins
>>> r = armi.init(fName="armi/tests/c5g7/c5g7-settings.yaml").r
>>> fuelBlock = r.core[0][0]
>>> fuelBlock.getNumPins()
528

In that model, there are two clad components per lattice site
https://github.com/terrapower/armi/blob/c6f46e5d04dc265e7a8e470fdd1977c9a4e16e3e/armi/tests/c5g7/c5g7-blueprints.yaml#L86-L114
So you double count the sites. There are 17x17 total lattice sites, some of which are empty, so the upper bound on "real" pins is 289
Originally posted by @drewj-tp in https://github.com/terrapower/armi/discussions/1900#discussioncomment-10908081

A great place for to start would be to write a unit test that can go with the existing C5G7 unit test for this exact thing:
https://github.com/terrapower/armi/blob/c6f46e5d04dc265e7a8e470fdd1977c9a4e16e3e/armi/tests/test_lwrInputs.py#L26-L29


Add calculator call

I think the way it is implemented now the exceedance probability per object is not saved in the csv file, but only potentially used in the infometrics calculations.
Therefore, a small part should be added that replaces the Impacts_detailed_{scenario_name}.csv in output/Scenarios/{scenario_name}/Impacts with the one including the exceedance probability.


How to send SMS ?

Hello,
First thank you for such nice project it is really great,
before I was using Skype4Py for sending SMS for Pethospital appointment, I was hopping there is same feature in SkPy
I have tried the web.skype.com and it allows it, so should be possible
I see in doc chat.rst there is SMS capability
"properties": {"capabilities": ["AddMember",
                                         "ChangeTopic",
                                         "ChangePicture",
                                         "EditMsg",
                                         "CallP2P",
                                         "SendText",
                                         "SendSms",
                                         "SendFileP2P",
                                         "SendContacts",
                                         "SendVideoMsg",
                                         "SendMediaMsg",
                                         "ChangeModerated"],

but I do not see in code the function allowing doing it .
Is this feature available ? If not, how to add it ?
Thanks,

Not at present -- I don't have Skype SMS set up on my account, so I'm unsure what any of the API calls look like.
If you're able to do it from Skype for Web and track the HTTP requests it makes, we can look into reproducing it here, though it may be tricky to test locally.

When you have skype credit you can call or sms a phone number.  same windows as chat.
Ok. For what can see in google developer tools in network tab there are several exchanges . I will try to isolate the communication process and understand how skpy works

Any news about this demand?

My request above still stands, as I've not touched Skype since then, let alone the SMS parts.

Meu pedido acima ainda está de pé, já que não toquei no Skype desde então, muito menos nas partes do SMS.

I can even create the chat and send an sms but after a few seconds it appears in the sms above the delivery failed, I don't know what it can be.

I can even create the chat and send an sms

With SkPy, or in Skype for Web?
If you can successfully send a message with the latter but not the former, please get a sample HTTP request from your browser so we can tell what it's doing differently.  Without that I don't know what needs to change.

I checked the request on the web and tried to reproduce it on SkyPy the request creates the chat with the number and sends the sms but after a few seconds it gets the message as in the photo above you want it to send as is the headers, body and which endpoint make the requisition?

Posso até criar o chat e enviar um sms

Com o SkPy ou no Skype para Web?
Se você conseguir enviar uma mensagem com o último, mas não com o primeiro, obtenha um exemplo de solicitação HTTP de seu navegador para que possamos saber o que está fazendo de diferente. Sem isso, não sei o que precisa mudar.

I checked the request on the web and tried to reproduce it on SkyPy the request creates the chat with the number and sends the sms but after a few seconds it gets the message as in the photo above you want it to send as is the headers, body and which endpoint make the requisition?

headers, body and which endpoint

All of the above, same as what you'd get using SKPY_DEBUG_HTTP=1 with SkPy.

headers, body and which endpoint

All of the above, same as what you'd get using SKPY_DEBUG_HTTP=1 with SkPy.

**HEADERS**
Accept: application/json
Accept-Encoding: gzip, deflate, br
Accept-Language: pt-BR,pt;q=0.9,en-US;q=0.8,en;q=0.7,es;q=0.6
Authentication: skypetoken=eyJhbGciOiJSUzI1NiIsImtpZCI6IjEwMiIsIng1dCI6IjNNSnZRYzhrWVNLd1hqbEIySmx6NTRQVzNBYyIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE2MTQyOTI0NzMsImV4cCI6MTYxNDM3ODg2OSwic2t5cGVpZCI6ImxpdmU6bmVnb2Npb3NhcHBsZSIsInNjcCI6OTU4LCJjc2kiOiIxNjE0MjkyNDY5IiwiY2lkIjoiZDYzZDRmM2MxN2VlNGZhMiIsImFhdCI6MTYxNDI2ODc5Nn0.d-WH5Y1kDw3uPOW0CX1YfPqBJdICZ_Ov0FTQvnsMtv9B00ulhK_w9ckc18-8t69-F-NiQ84DhSvgOYZ0fNwtilOJgp7SU6tjG0F1mSlGv8dDhMRhHJZUI2LHBO8x-Nb3bemKyqqpiJUEg5M_NFz3NWzjdXoSlSKEjSfcHeq2JrIAD3aJSVrX7rrtNUu0xzjIjJyNrySwltcC_7xvHYvxmGs2QZfmEAxpwLU5o1HqI7qncduW0hpUDcvjt2SSTPfgoI8twMnxEITsQivC1K7xjJBoP4kjEtMiU11R7bIGKPk2lyr92LKvaF0sT3fJG1p5uI0WtaC4wNIgohUbFU8SLg
BehaviorOverride: redirectAs404
ClientInfo: os=Windows; osVer=10; proc=x86; lcid=pt-BR; deviceType=1; country=US; clientName=skype4life; clientVer=1418/<IP_ADDRESS>//skype4life; timezone=America/Sao_Paulo
Connection: keep-alive
Content-Length: 759
Content-Type: application/json
Host: azeus1-client-s.gateway.messenger.live.com
Origin: https://web.skype.com
Referer: https://web.skype.com/
RegistrationToken: registrationToken=U2lnbmF0dXJlOjI6Mjg6QVFRQUFBQVkwYThDWDJYUmFCUE9yNUJ6cERQQTtWZXJzaW9uOjY6MToxO0lzc3VlVGltZTo0OjE5OjUyNDkxODQ5MTEyMzk1NjQ4ODk7RXAuSWRUeXBlOjc6MTo4O0VwLklkOjI6MTg6bGl2ZTpuZWdvY2lvc2FwcGxlO0VwLkVwaWQ6NTozNjo2YmM2NDExZS00MWE3LTQ4NDEtYTg1Yi0zNmMyMGQ3MjJhM2U7RXAuTG9naW5UaW1lOjc6MTowO0VwLkF1dGhUaW1lOjQ6MTk6NTI0OTE4NDkxMTIzOTQwODY3NTtFcC5BdXRoVHlwZTo3OjI6MTU7RXAuRXhwVGltZTo0OjE5OjUyNDkxODU3NzUxMTczODc5MDQ7VXNyLk5ldE1hc2s6MTE6MToyO1Vzci5YZnJDbnQ6NjoxOjA7VXNyLlJkcmN0RmxnOjI6MDo7VXNyLkV4cElkOjk6MTowO1Vzci5FeHBJZExhc3RMb2c6NDoxOjA7VXNlci5BdGhDdHh0OjI6NDE2OkNsTnJlWEJsVkc5clpXNFNiR2wyWlRwdVpXZHZZMmx2YzJGd2NHeGxBUU5WYVdNVU1TOHhMekF3TURFZ01USTZNREE2TURBZ1FVME1UbTkwVTNCbFkybG1hV1Zrb2svdUZ6eFBQZFlBQUFBQUFBQkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFbXhwZG1VNmJtVm5iMk5wYjNOaGNIQnNaUUFBQUFBQUFBQUFBQWRPYjFOamIzSmxBQUFBQUFRQUFBQUFBQUFBQUFBQUFLSlA3aGM4VHozV0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkVteHBkbVU2Ym1WbmIyTnBiM05oY0hCc1pRQUFBQUFBOVNVNFlBZ0FBQUFEVldsakNFbGtaVzUwYVhSNURrbGtaVzUwYVhSNVZYQmtZWFJsQ0VOdmJuUmhZM1J6RGtOdmJuUmhZM1J6VlhCa1lYUmxDRU52YlcxbGNtTmxEVU52YlcxMWJtbGpZWFJwYjI0VlEyOXRiWFZ1YVdOaGRHbHZibEpsWVdSUGJteDVBQUE9Ow==; expires=1614378869; endpointId={6bc6411e-41a7-4841-a85b-36c20d722a3e}
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.190 Safari/537.36
X-ECS-Etag: "W08y7ExnU3KljSMB1R8XXkZOu3GBOVpI+vLNr6FS6Xk="

**ENDPOINT**
https://azeus1-client-s.gateway.messenger.live.com/v1/users/ME/conversations/4:+5531993818360/messages?x-ecs-etag="W08y7ExnU3KljSMB1R8XXkZOu3GBOVpI+vLNr6FS6Xk="

**BODY**
clientmessageid: "7155319416505915828"
composetime: "2021-02-25T23:11:49.190Z"
content: "<sms alt="Hello test"><restApiVersion>2</restApiVersion><encoded_body>Hello test</encoded_body><defaults><skype><deliveryReportVersion>chatservice</deliveryReportVersion><uiVersion>1418/<IP_ADDRESS></uiVersion></skype><control><flowId>skype.S4L.client.sms.1way</flowId><deliveryMethod>reliable</deliveryMethod></control><content>Hello test</content></defaults><bulkItems><bulkItem><requestId>c88a1865-8ab6-4f51-ba37-96b8e2807c70</requestId><recipient><address>+5531993818360</address></recipient></bulkItem></bulkItems></sms>"
contenttype: "text"
imdisplayname: "negociosapple apple"
messagetype: "RichText/Sms"
receiverdisplayname: "+5531993818360"

headers, body and which endpoint

All of the above, same as what you'd get using SKPY_DEBUG_HTTP=1 with SkPy.

The parameter requestId is a str(uuid4()).
**HEADERS**

Accept: application/json
Accept-Encoding: gzip, deflate, br
Accept-Language: pt-BR,pt;q=0.9,en-US;q=0.8,en;q=0.7,es;q=0.6
Authentication: skypetoken=eyJhbGciOiJSUzI1NiIsImtpZCI6IjEwMiIsIng1dCI6IjNNSnZRYzhrWVNLd1hqbEIySmx6NTRQVzNBYyIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE2MTQyOTI0NzMsImV4cCI6MTYxNDM3ODg2OSwic2t5cGVpZCI6ImxpdmU6bmVnb2Npb3NhcHBsZSIsInNjcCI6OTU4LCJjc2kiOiIxNjE0MjkyNDY5IiwiY2lkIjoiZDYzZDRmM2MxN2VlNGZhMiIsImFhdCI6MTYxNDI2ODc5Nn0.d-WH5Y1kDw3uPOW0CX1YfPqBJdICZ_Ov0FTQvnsMtv9B00ulhK_w9ckc18-8t69-F-NiQ84DhSvgOYZ0fNwtilOJgp7SU6tjG0F1mSlGv8dDhMRhHJZUI2LHBO8x-Nb3bemKyqqpiJUEg5M_NFz3NWzjdXoSlSKEjSfcHeq2JrIAD3aJSVrX7rrtNUu0xzjIjJyNrySwltcC_7xvHYvxmGs2QZfmEAxpwLU5o1HqI7qncduW0hpUDcvjt2SSTPfgoI8twMnxEITsQivC1K7xjJBoP4kjEtMiU11R7bIGKPk2lyr92LKvaF0sT3fJG1p5uI0WtaC4wNIgohUbFU8SLg
BehaviorOverride: redirectAs404
ClientInfo: os=Windows; osVer=10; proc=x86; lcid=pt-BR; deviceType=1; country=US; clientName=skype4life; clientVer=1418/<IP_ADDRESS>//skype4life; timezone=America/Sao_Paulo
Connection: keep-alive
Content-Length: 759
Content-Type: application/json
Host: azeus1-client-s.gateway.messenger.live.com
Origin: https://web.skype.com
Referer: https://web.skype.com/
RegistrationToken: registrationToken=U2lnbmF0dXJlOjI6Mjg6QVFRQUFBQVkwYThDWDJYUmFCUE9yNUJ6cERQQTtWZXJzaW9uOjY6MToxO0lzc3VlVGltZTo0OjE5OjUyNDkxODQ5MTEyMzk1NjQ4ODk7RXAuSWRUeXBlOjc6MTo4O0VwLklkOjI6MTg6bGl2ZTpuZWdvY2lvc2FwcGxlO0VwLkVwaWQ6NTozNjo2YmM2NDExZS00MWE3LTQ4NDEtYTg1Yi0zNmMyMGQ3MjJhM2U7RXAuTG9naW5UaW1lOjc6MTowO0VwLkF1dGhUaW1lOjQ6MTk6NTI0OTE4NDkxMTIzOTQwODY3NTtFcC5BdXRoVHlwZTo3OjI6MTU7RXAuRXhwVGltZTo0OjE5OjUyNDkxODU3NzUxMTczODc5MDQ7VXNyLk5ldE1hc2s6MTE6MToyO1Vzci5YZnJDbnQ6NjoxOjA7VXNyLlJkcmN0RmxnOjI6MDo7VXNyLkV4cElkOjk6MTowO1Vzci5FeHBJZExhc3RMb2c6NDoxOjA7VXNlci5BdGhDdHh0OjI6NDE2OkNsTnJlWEJsVkc5clpXNFNiR2wyWlRwdVpXZHZZMmx2YzJGd2NHeGxBUU5WYVdNVU1TOHhMekF3TURFZ01USTZNREE2TURBZ1FVME1UbTkwVTNCbFkybG1hV1Zrb2svdUZ6eFBQZFlBQUFBQUFBQkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFbXhwZG1VNmJtVm5iMk5wYjNOaGNIQnNaUUFBQUFBQUFBQUFBQWRPYjFOamIzSmxBQUFBQUFRQUFBQUFBQUFBQUFBQUFLSlA3aGM4VHozV0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkVteHBkbVU2Ym1WbmIyTnBiM05oY0hCc1pRQUFBQUFBOVNVNFlBZ0FBQUFEVldsakNFbGtaVzUwYVhSNURrbGtaVzUwYVhSNVZYQmtZWFJsQ0VOdmJuUmhZM1J6RGtOdmJuUmhZM1J6VlhCa1lYUmxDRU52YlcxbGNtTmxEVU52YlcxMWJtbGpZWFJwYjI0VlEyOXRiWFZ1YVdOaGRHbHZibEpsWVdSUGJteDVBQUE9Ow==; expires=1614378869; endpointId={6bc6411e-41a7-4841-a85b-36c20d722a3e}
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.190 Safari/537.36
X-ECS-Etag: "W08y7ExnU3KljSMB1R8XXkZOu3GBOVpI+vLNr6FS6Xk="

**ENDPOINT**
https://azeus1-client-s.gateway.messenger.live.com/v1/users/ME/conversations/4:+5531993818360/messages?x-ecs-etag="W08y7ExnU3KljSMB1R8XXkZOu3GBOVpI+vLNr6FS6Xk="

**BODY**
clientmessageid: "7155319416505915828"
composetime: "2021-02-25T23:11:49.190Z"
content: "<sms alt="Hello test"><restApiVersion>2</restApiVersion><encoded_body>Hello test</encoded_body><defaults><skype><deliveryReportVersion>chatservice</deliveryReportVersion><uiVersion>1418/<IP_ADDRESS></uiVersion></skype><control><flowId>skype.S4L.client.sms.1way</flowId><deliveryMethod>reliable</deliveryMethod></control><content>Hello test</content></defaults><bulkItems><bulkItem><requestId>c88a1865-8ab6-4f51-ba37-96b8e2807c70</requestId><recipient><address>+5531993818360</address></recipient></bulkItem></bulkItems></sms>"
contenttype: "text"
imdisplayname: "negociosapple apple"
messagetype: "RichText/Sms"
receiverdisplayname: "+5531993818360"

You've leaked your tokens in there, best logout that session ASAP.

So there's a few things going on here that probably want handling:

phone contacts are type 4
SMSes have their own message type RichText/Sms along with a specific HTML structure

Does this work?  (replacing +441234567890 with an actual contact's number)
chat = sk.chats["4:+441234567890"]
chat.sendRaw(
    messagetype="RichText/Sms",
    content="""<sms alt="Message text"><encoded_body>Message text</encoded_body></sms>""",
    imdisplayname="{0}".format(sk.user.name),
)

If not, does it work with the entire content line you quoted above?

The test created the message just like in my tests here but the sms is not sent for some reason.

Even with the full HTML message content?

Even with the full HTML message content?

Yes, i try with the full HTML message content and not worked

I don't have the Skype credit or a subscription to test this with, so this won't go anywhere unless someone can reliably reproduce a working Skype for Web request for sending an SMS using SkPy, like the one I proposed above.
It's a request to client-s.gateway.messenger.live.com and they're fairly standardised, so hopefully it doesn't depend on unusual parameters to work.  SkypeChat.sendRaw() will do a POST request to the right URL (sending an SMS appears to use the same endpoint as a regular Skype message), with kwargs becoming the message body, so it should just be a case of finding the right combination of parameters.

I was able to send SMS using sendRaw and this template below once I already had a chat for a given phone number. In case the chat's ID is something like 4:+1123456789 and the phone number is +1123456789 this request worked for with a random UUID as the request_id:
<sms alt="{message}">
<restApiVersion>2</restApiVersion>
<encoded_body>{message}</encoded_body>
<defaults>
    <skype>
        <deliveryReportVersion>chatservice</deliveryReportVersion>
        <uiVersion>1418/<IP_ADDRESS></uiVersion>
    </skype>
    <control>
        <flowId>skype.S4L.client.sms.1way</flowId>
        <deliveryMethod>reliable</deliveryMethod>
    </control>
    <content>
        {message}
    </content>
</defaults>
<bulkItems>
    <bulkItem>
        <requestId>{request_id}</requestId>
        <recipient>
            <address>{phone_number}</address>
        </recipient>
    </bulkItem>
</bulkItems>
</sms>

I actually have this in code:
                        # Extract phone number from chat ID (format: 4:+11123456789)
                        phone_number = chat_id.split(':')[1]
                        request_id = str(uuid.uuid4())

                        # Construct SMS XML content
                        sms_content = f"""<sms alt="{message}">
<restApiVersion>2</restApiVersion>
<encoded_body>{message}</encoded_body>
<defaults>
    <skype>
        <deliveryReportVersion>chatservice</deliveryReportVersion>
        <uiVersion>1418/<IP_ADDRESS></uiVersion>
    </skype>
    <control>
        <flowId>skype.S4L.client.sms.1way</flowId>
        <deliveryMethod>reliable</deliveryMethod>
    </control>
    <content>
        {message}
    </content>
</defaults>
<bulkItems>
    <bulkItem>
        <requestId>{request_id}</requestId>
        <recipient>
            <address>{phone_number}</address>
        </recipient>
    </bulkItem>
</bulkItems>
</sms>"""

                        logging.info(f"Sending as SMS message to {phone_number}")
                        chat.sendRaw(
                            messagetype="RichText/Sms",
                            content=sms_content,
                            imdisplayname="{0}".format(sk.user.name),
                        )


Refactoring in frontend_tests/node_tests/reactions.js

Coverage before:

Statements   : 53.77% ( 913/1698 )
Branches     : 23.13% ( 111/480 )
Functions    : 40.81% ( 162/397 )
Lines        : 53.76% ( 909/1691 )

After:

Statements   : 53.82% ( 915/1700 )
Branches     : 23.13% ( 111/480 )
Functions    : 39.43% ( 153/388 )
Lines        : 53.7% ( 907/1689 )


TimeZone toggle is not working, there's an error when trying to use the 'TimeZone-UTC2PST' flow

When investigating this issue on Monitor mode, this is the error provided:
TimeZone-UTC2PST.Run failed: Connection not configured for this service.

This error only happens in PROD

Fixed, but need to test it in production to be sure


[#6] [Backend] As a user, I can register a new account with email and password

Closes #6
What happened 👀
Create Authentication with:

User and UserToken schemas
Accounts query

Insight 📝

Use mix phx.gen.auth Accounts User users to see how an authentication module generates.
Add unit test for Accounts.
Create UserFactory to support testing.
Install chromedriver. Since I install via asdf so I specify its version into .tool-verssions.

Proof Of Work 📹
Register new user

Get user by id

Get user by email

Register existing user -> failed

The CI is fail @vnntsu

The CI is fail @vnntsu

@andyduong1920 I'm not sure I understand this falling clearly. it's about Wallaby, I have to set its version to .tool-version and it works well locally. Do we have to also set Wallaby's version to dockerfile for CI/CD?

@andyduong1920 I just found out the cause. It's fixed, all passed ✅

@andyduong1920 I just found out the cause. It's fixed, all passed ✅

In the end, do we need to add chromedriver into .tool-versions @vnntsu  Install chromedriver. Since I install via asdf so I specify its version into .tool-verssions.


Handle empty new character set in EnvChangeTokenHandler

Proposed fix for #110

@c-j-hughes Thanks for the review.  I have added some unit tests for the EnvChangeTokenHandler class, and in the process of doing so realised that I had missed that the existing encoding lookup should be done with the resolved new charset, not the change value from the token, so have amended the code to address that.
If you are happy with this - would it possible to get a NuGet release of the driver with this fix and the PR  for #108, as we are currently dependent on a local build with these changes in them?  Many thanks.

@c-j-hughes , @senseibaka - Many thanks for the release - that has helped us a lot (we were running a significant project risk with the local driver build)!


nixos/oci-containers: improve description of imageFile

Description of changes
As a novice to using this module, I found the existing description to be
quite misleading. It does not at all disable pulling from the registry,
it just loads some image archive that may or may not be related to the
container you're specifying. I had thought there was extra magic behind
this option, but it's just a docker load. You need foreknowledge of
the contents of the archive so that whatever it contained is actually
used to run the container.
I've reworded the description to hopefully make this behavior clearer.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc @bjornfor as you reviewed the last doc change in this area and @mkaito as you introduced the option.  Thanks!

@bjornfor I'm not sure how merging works in general in this repo, but I see you've merged things in the past.  Can you help?

@isker: Thanks!


[wip] Xrcb datasource

kind of working not ready yet, but at least you can add the datasource to a repro and ingest some posts (podcasts)

I think everything should be ok so far. I still have to revise the comments and clean up the types. The one or the other can certainly be made more beautiful but for a first test it should be enough.


[5.7] Explicitly copy defsIDependUpon into an appropriately sized array when initializing SourceFileDependencyGraph.Node

5.7 cherry pick of https://github.com/apple/swift-driver/pull/1119

@swift-ci please test

This is now updated with the additional type annotation needed to compile in regular swift CI

@swift-ci please test

@swift-ci please test


Add two papers about planning

We hope you can add our paper to this repo. If you can agree to our pr, we would be very honored and grateful.

These two works are great！ But I notice that you close the PR.
Ke Tang @.***> 于2024年5月20日周一 09:28写道：

Closed #6
https://github.com/zchoi/Awesome-Embodied-Agent-with-LLMs/pull/6.
—
Reply to this email directly, view it on GitHub
https://github.com/zchoi/Awesome-Embodied-Agent-with-LLMs/pull/6#event-12859863274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHIV26GM56RNUDZQL3RBPLLZDFGSNAVCNFSM6AAAAABH62IXTOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA2TSOBWGMZDONA
.
You are receiving this because you are subscribed to this thread.Message
ID: <zchoi/Awesome-Embodied-Agent-with-LLMs/pull/6/issue_event/12859863274
@github.com>


Add a mechanism to label vertices and edges from Triangle

In-order to help align a Triangle to an of its vertices is should be possible to access each of the three vertices and edges by label.
tri = Triangle(a=3, b=4, c=5, align=Align.MIN)
tri.edge_a
tri.edge_b
tri.edge_c
tri.vertex_A
tri.vertex_B
tri.vertex_C

Complete with commit f3fa230c521c6f7c7724aa4864f6a25e85fd4eee


[bug] issue connecting with Compass Wallet

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.1.4
wagmi Version
2.12.0
Current Behavior
When I connect using compass wallet on Gitcoin. The connection fails cause it's unable to do getAccounts.
I then tried using the compass wallet on https://www.rainbowkit.com/ and the connection fails there as well

Expected Behavior
Compass Wallet Should connect like Metamask
Steps To Reproduce
Head over to https://www.rainbowkit.com/  and try connecting to the compass wallet
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://www.rainbowkit.com/
Anything else?
This original issue was reported on gitcoin https://github.com/gitcoinco/grants-stack/issues/3581 and i wasn't able to debug the issue

@thelostone-mc This is a compass wallet issue rather than RainbowKit issue. Their extension is not able to connect and i think the best thing to do for now is to reach out to their support team and report this bug.


Fix CS errors.

Codecov Report

Merging #1268 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   74.63%   74.63%
=======================================
  Files          35       35
  Lines        4739     4739
=======================================
  Hits         3537     3537
  Misses       1202     1202

Impacted Files
Coverage Δ

src/Phinx/Console/Command/Status.php
100% <100%> (ø)
:arrow_up:

src/Phinx/Console/Command/Breakpoint.php
36% <100%> (ø)
:arrow_up:

src/Phinx/Console/Command/SeedRun.php
92.5% <100%> (ø)
:arrow_up:

src/Phinx/Console/Command/Migrate.php
88.37% <100%> (ø)
:arrow_up:

src/Phinx/Console/Command/Rollback.php
95% <100%> (ø)
:arrow_up:

src/Phinx/Console/Command/Test.php
24.13% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e497f3b...21b77ab. Read the comment docs.


Function activateSignatureRequest write curl response in stdout

Hi,
Your function activateSignatureRequest() miss CURLOPT_RETURNTRANSFER curl option. The response is return when curl get response contrary to the return function.
https://github.com/oliviernival/yousign-client-api-V3-2024/blob/9f86a216739bf3d8ba732f3129b48691aabccfa4/src/NvlYousignClientV3.php#L461-L481

On success, this function flushes the result directly to the stdout and returns true, or false on failure. However, if the CURLOPT_RETURNTRANSFER option is set, it will return the result on success, false on failure.

cf  : https://www.php.net/manual/en/function.curl-exec.php
curl_setopt_array($curl, [
  CURLOPT_URL => sprintf('%s/signature_requests/%s/activate', $this->apiBaseUrlWslash, $this->signatureRequestId),
  CURLOPT_RETURNTRANSFER => 'true',
  CURLOPT_CUSTOMREQUEST => 'POST',
  CURLOPT_HTTPHEADER => [
    sprintf('Authorization: Bearer %s', $this->apikey),
    'Content-Type: application/json'
  ],
]);

Same here, without this param, impossible to use the iframe delivery mode


add signal for when contents of cell are changed

Rebased version of old PR to add signal emitted when grid map cells change
Bugsquad edit: Fixes #11855.

@iatenine For future reference, you absolutely can rebase without creating a new PR, you just needed to force-push.
@akien-mga This change is pretty simple and has been waiting a long time in #34475, probably best to just merge this right away once the CI checks finish.

There's also #33832 for the same feature.
But I'm not clear on the use case - when can GridMap cells change without the developer knowing it? Signals in Godot are meant to notify of changes that happened automatically so that the developer can react to them, but in this case changing the contents of a cell is (AFAIK) something that the developer would do themselves, and they can thus react to their own change directly (or emit a signal when changing cells).
TileMap doesn't seem to have this kind of signal either.

Signals in Godot are meant to notify of changes that happened automatically so that the developer can react to them

Guess I never realized the pattern for built-in signals and always thought of them more as shortcuts for things I could (but would rather not) code by hand and, as Aaron mentioned, this is a pretty old PR so I don't fully recall my thought process at the time
Still, if I'm not the only one asking for the feature, surely there's a discussion to be had about balancing requested features and avoiding bloat
I await the council's decision and will close the PR if appropriate

@akien-mga I thought signals were general-purpose tools for communicating around the scene tree?
For example, here is a chart from @TheDuriel showing the way he recommends communicating between nodes:

If this chart is to be followed, a signal that could be connected to notify a parent node would make sense.

@aaronfranke Sure, but that's why you can emit you own signal when you modify the GridMap yourself.
Built-in signals are meant to be emitted to notify you of relevant events that happen without you having triggered them directly. If you call set_name("New Name"), we won't emit node_changed_name as you did this change yourself, so this signal would be clutter (and we would then add signals for every action that can impact a node, i.e. any method in the API).

I agree there should be a signal for this for editor tools, but it also needs the gridmap object being changed and new item to be useful. As I've done here:  #33832  It is rather useless if the gridmap being changed isn't sent along with the cell information. Having the gridmap in question passed in the signal allows a single script to work on multiple copies of the gripmap. (I am using gridmaps to create pushable blocks of multiple shapes in a project). Having the new item ID allows you to set 1 specific item ID to be the "auto" block so it does not get stuck in an infinite loop of changing itself AND allows you to have items that are NOT changed with you place them.
Making any kind of complex gridmap without a signal like this takes forever. For example, in my project I have over a 21 blocks that all need specific rotations depending on which blocks they are surrounded by. This signal allows automatic change of the item and rotation depending on the situation.
Example: https://imgur.com/a/nyHrH0N

I'm willing to accept #33832 as the superior implementation. Closing this PR


Feature Request: Option to disable for diff comparison

Blockman can be bit busy when viewing side by side comparisons such that distracts from the actual differences. I would like to request a option to automatically disable blockman for diff views.

Thank. I hope I will have time soon to try implementing this feature request.
Right now you can toggle disable/enable Blockman with F1 command:
>Blockman Toggle Enable/Disable
or
>Blockman Toggle Enable/Disable And Force Show/Hide Indent Guides

So far I found these solutions:
if (editor.document.uri.scheme === "git") {
    // this editor is the left side of the diff
}

const theUri = editor.document.uri.toString();

const trueOrFalse = window.tabGroups.all.some((tabGroup) =>
    tabGroup.tabs.some((tab) => {
        const tabInp: any = tab.input;

        return (
            tabInp?.modified?.toString() === theUri ||
            tabInp?.original?.toString() === theUri
        );
    }),
);

if (trueOrFalse) {
    // this editor has the document which is open in at least one diff editor
    // but this editor may not be the diff editor.
    // For example, maybe this editor is just a normal editor and this document is open in another editor which is diff editor.
}

Sources:
https://github.com/microsoft/vscode/issues/36019
https://github.com/microsoft/vscode/issues/15513
So, for now, we can detect the left side of diff editor, but I could not find a solution to detect the right side of diff editor. I mean, as you can see in the above code samples, we can detect that the editor has the document which is open in at least one diff editor, but we cannot be sure that this editor is the diff editor itself.
If you or anyone finds a solution for it, please let me know.


ProjectTracker WinForms RolesEdit is broken

Steps to reproduce:

Login as admin
Admin => Edit Roles
Click on a new (empty) line
Click Cancel button

RolesEdit uses a BO RoleEditList : BusinessListBase<RoleEditList, RoleEdit> that is a WPF list.
WinForms needs a RoleEditList : BusinessBindingListBase<RoleEditList, RoleEdit>
We could make a ProjectTracker.BusinessLibrary.WinForms project/assembly but the problem is the AppServer that won't know which DLL to use,
So I propose to keep the project simple and make a new class
RoleEditBindingList : BusinessBindingListBase<RoleEditBindingList, RoleEdit>

See https://github.com/MarimerLLC/csla/issues/863


integrations: Add webhook payloads for solano.

Automated message from Dropbox CLA bot
@anirudhjain75, it looks like you've already signed the Dropbox CLA. Thanks!

@anirudhjain75, lgtm. @timabbott, ready for a final review.

@umairwaheed Made the changes you requested, Thanks

This looks great.  It looks like https://github.com/zulip/zulip/pull/3034 seems basically done, but it'd be awesome @anirudhjain75 if you can test whether that implementation works with your payloads...

@timabbott Okay

I merged #3034, so I think you should be able to just rebase this onto master and then test it.

Cool

The middle one is duplicated sorry for that @timabbott

@fazerlicourice7 it looks like one thing these extra fixtures show is you don't handle the "running" status; maybe we should merge these fixtures and then update the code to provide a better emoji for that?  Maybe some sort of wheel?
@anirudhjain75 if you'd like to just add some commits to this PR to the integration to do the implementation plan I suggested above, we can merge this.

Yeah totally. How about  :arrows_counterclockwise: , or one of the clocks? I'll create a pull for it and link it here. Let me know which emoji is better, please.

Yeah I think that symbol looks good for running.

Alright.

@timabbott #3110

New fixture added in #3110.  Thanks @anirudhjain75 and @fazerlicourice7!

It wasn't a new one, I just downloaded one of these to test, since this branch hadn't been merged. I gave it the same name, so there won't be a duplicate.

Yep, I understood it was one of the ones @anirudhjain75 wrote; I don't think we need the others since they don't have features not present in the 3 we have now.

Ah. ok. :)


chore(deps): use esno to replace ts-node

You might want to remove ts-node from devDeps and renovate.json5.

need to remove:

https://github.com/vitejs/vite/blob/dcc8ea43d079c9bc3f49f758a80a3a74189f333a/package.json#L82
https://github.com/vitejs/vite/blob/dcc8ea43d079c9bc3f49f758a80a3a74189f333a/.github/renovate.json5#L19
https://github.com/vitejs/vite/blob/dcc8ea43d079c9bc3f49f758a80a3a74189f333a/packages/vite/rollup.config.js#L175 ?

Looks like this error is happening frequently.
Error: ENOENT: no such file or directory, open '/tmp/esbuild-kit/16524-74c8df34597ce71639eb861c859a7174e79e54b9'
https://github.com/vitejs/vite/actions/runs/2317845205/attempts/1
https://github.com/vitejs/vite/actions/runs/2317959186

Revert for now. /cc @privatenumber any clue on the cause of this?

Fixed in https://github.com/esbuild-kit/core-utils/pull/1

Hi, any chance someone could explain the reason for this change, or link to an issue/discussion where this was talked about?  I always find it very useful when the context/reasoning behind a change are included in the PR.  I'm not saying the change shouldn't have been made, I'm just trying to learn / follow along.


Clarify differences between multiplication and conversion

If it comes with API breaking changes, then it has to be addressed before the RC.

This does not need any further explanation. Exchanging is well documented. I think it is pretty clear: multiply use the same currency whereas conversion use a different currency. I am going to close it.


TestCafe Banner makes elements appear invisible

Banner makes elements appear invisible
Test cafe banner is covering up elements and as a result, those elements are "not visible". This can be verified by a test where an element is covered up by the banner and needs to be visible to succeed, here's an example:
.click(myElementCoveredByBanner)
which then gives the error:
"The element that matches the specified selector is not visible."
Observing the test, I have noticed that the element is scrolled to and visible on the screen, however, the test-cafe banner covers the element completely.
By running the test again, wait for the timeout and then by manually scrolling such that the banner partially does not cover the element, fixes the problem.
What is the Current behavior?
The banner when layered over an element makes it "not visible"
What is the Expected behavior?
There either should not be a banner, or the banner should not be making elements "not visible".

Code that is breaking:

   1) The element that matches the specified selector is not visible.

export async function drilDown() {
 await scrollToBottom()
await t
   .expect(benefitsIconMobileOnly.exists).ok()
    .click(benefitsIconMobileOnly)

testcafe version:  1.2.1
node.js version:    8.12.0
browser name and version: Chrome 75
platform and version:  macOS 10.13.6

Hello @AllSidesCreative,
The issue you are facing looks similar to this one. We have fixed it recently. Can you check that the problematic behavior is reproducible on the<EMAIL_ADDRESS>version? If so, please provide us with a link to your Web application or a simple project in which we can reproduce the issue. Also, the code of your test would be very helpful for us.

I have provided code, its under .the "Code that is breaking" banner. I'll try and find an example project to illustrate my example better.

@aleks-pro  after upgrading to<EMAIL_ADDRESS>, can confirm that the issue is not fixed.

@AllSidesCreative

can confirm that the issue is not fixed.

Ok. This means that you found another problem. I am afraid, the information you provided is not sufficient to find the cause of the issue.
Could you please send us a page or a small example so that we can reproduce the problem on our side?

@aleks-pro  why was this issue closed? The problem hasn't been fixed.
@miherlosev The issue is even easier to reproduce on the alpha version than version 1.2.1.
It's going to be difficult to provide an example project, I'll investigate more my end and if I can find some more information, I'll let you know.

This is still happening consistently. It should be re-opened

I'll reopen this issue. Please share a simple working sample according to the following instruction: https://testcafe.io/402636/faq#how-to-create-a-minimal-working-example-when-you-submit-an-issue.
Otherwise, I won't be able to reproduce this problem, and the issue will be closed again.


Can we change the progress-bar Interval from 1000ms to 200ms?

Currently progress-bar update after 1000ms and i want to update progress-bar after 200ms, so that progress-bar run as a smooth way.

Sorry, not support.
the player use timeupdate api to update progress bar , default 1000ms.
if want set to 200ms, maybe use setInterval to mock.

We are using this to play small audio files and recordings. It is very important to have a smooth progress bar for small duration. Can you please guide in bit detail where to add the setInterval to mock this.
Thank you for your assistance and help.


Expand limit to job inputs to a larger number

Currently, there is a limit of 10 placed for newly inputted jobs, so rather, this can be modified to a larger number like 20.
This enhancement can be done now, and then later increased as I integrate gpt4free
Side note: Make sure it fits in the embed message char limitations.

Done with most recent commit. Will go ahead and close PR.


New version crash crafting combinator

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[X] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[X] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?

Steps to reproduce
No response
Additional context
No response
Log file
No response

Try this: https://mods.factorio.com/mod/crafting_combinator_xeraph/downloads

same error


copr: remove nullable arithmetic_with_ctx

What problem does this PR solve?
copr: remove nullable arithmetic_with_ctx
Problem Summary:
What is changed and how it works?
What's Changed:

Replace arithmetic_with_ctx with arithmetic_with_ctx_nonnull
Rewrite int_divide_decimal

Related changes
Check List
Tests

Unit test

PTAL @TennyZhuang @breeswish , thanks!

/run-all-tests

/merge


Adding Snyk to third-party software options

Adding Snyk (which is free for open-source development) as a third-party vulnerability scanning option.

Synk seems to be a great tool.
Thanks for your contribution.

And thank you for such a great resource. Nice work, sir! :)


Update stateful_apps.md

Update stateful_apps.md
This PR addresses issue #147
I have formatted and edited the definitions using the style guide reference.

Thanks, @sudhxnva. We have a few maintainers out of office, so please allow us some time to review as we have quite a few PR waiting for approval as well. Really appreciate your support!

@sudhxnva really great edits! Right now the problem with this definition is that it is kubernetes specific. In order to consider publishing it will need to be broad enough to encompass the whole concept without diving into Kubernetes. We can likely accept it as is and leave it as feedback appreciated. Alternatively if you're willing to rewrite the definition with a broader perspective we could get this published in the next iteration of the glossary. Let me know what you think.

Gone stale, going to close on Tuesday if we don't have any feedback from the author.

Hi @JasonMorgan! Sorry for the late response, I have been busy with my semester exams. Thank you for your feedback! I like the idea of possibly merging it for now. I will try making the definitions a not Kubernetes specific at a later time if that's okay with you!


Transform needs to be able to set the application-name of the task via option

Currently triggertask supports the ability to set application name of the task via its options.  This feature needs to be supported by the tasklaunchrequest-transform.

Isn't this a duplicate of spring-cloud-stream-app-starters/tasklaunchrequest-transform#4?

Duplicate of #4   Closing


I have a question about deep neural network on tracking

Before that, I read a paper on deep learning in target tracking called MDnet. MDnet seems to track only specific categories. I don't know if the same is true of Siamese, who is trained to track only certain categories of objects.

You can evaluate this performance based on  the their results on GOT10k


[Feature-6417][UI] add ‘view log' in the task instance context menu

#6417

Codecov Report

Merging #6421 (363098a) into dev (1843e98) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #6421      +/-   ##
============================================
+ Coverage     38.79%   38.81%   +0.01%
+ Complexity     3214     3211       -3
============================================
  Files           645      645
  Lines         25684    25684
  Branches       2783     2783
============================================
+ Hits           9964     9968       +4
+ Misses        14802    14792      -10
- Partials        918      924       +6

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/thread/ThreadPoolExecutors.java
19.23% <0.00%> (-1.93%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
44.68% <0.00%> (+5.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1843e98...363098a. Read the comment docs.


Issue to upload README files

This is not a true Issue, please ignore it.

This is the preview of The Classic Readme File

This is the preview od the basic branch readme file


Question regarding the pooling in QR trick

When attempting to use the QR trick, I have noticed that the implementation differs from what is described in the original paper. In the paper, the embedding of a token is obtained by applying operations such as 'add', 'mult', or 'concat' to two separate embedding tables, after which sum or mean pooling is applied. However, the implementation https://github.com/facebookresearch/dlrm/blob/c848e837580cbcfe6b49149658e4c8a3c1576f48/tricks/qr_embedding_bag.py#L189   first applies pooling to the embeddings from the separate tables and then applies 'add', 'mult', or 'concat' to obtain the embedding feature. I am unsure whether this difference is by design or if the two methods are equivalent.

Hi @fangleigit, good question! Since Criteo only supports one-hot encodings, we've implemented QR here this way. In this case, these two approaches are equivalent.
However, you are correct that ideally the implementation should perform the operation before the sum or mean pooling - this would require a more involved implementation that requires changing the underlying embedding bag implementation. We have not implemented this here.


xui not working on wp7

apparently the IE build doesnt work on windows phone 7. run test suite on that fker!

The 2.3.2 tag of xui works fine with both IE mobile and WebKit builds on Windows Phone 7 Mango. Wewt!


Azure Dogfood subscription for AZConfig testing

We need to create a dogfood subscription for AZConfig testing.

this is a duplicate of: https://github.com/Azure/azure-sdk/issues/123


[Webpack config] stage 3 for koa-send

Is this a know issues?
./node_modules/koa-send/index.js:37
async function send (ctx, path, opts = {}) {
^^^^^^^^
SyntaxError: Unexpected token function
I got this in every blank installation. Browser Build work fine.

Upgrade to the latest version of Node, where async/await is available.

@leebenson oh... realy... sorry my mistake


[BABEL] /usr/src/app/src/index.js: Cannot find module '@babel/plugin-proposal-private-property-in-object' (0:undefined)

Describe the bug
When building a react app getting babel error. Syntax error: [BABEL] /usr/src/app/src/index.js: Cannot find module '@babel/plugin-proposal-private-property-in-object' (0:undefined)
Did you try recovering your dependencies?

Not applicable
Which terms did you search for in User Guide?

N/A
Environment

N/A
Steps to reproduce

npm istall --legacy-peer-deps
npm run build

Expected behavior

Actual behavior

Reproducible demo

Not applicable

A possible workaround given here is adding the following to the list of dependencies in the package.json file:
"@babel/plugin-proposal-private-property-in-object": "^7.21.0"

Adding "@babel/plugin-proposal-private-property-in-object": "^7.21.0" in package.json file is not working for me. I also see on Azure server when i creating build with NODE_ENV=production then i am getting this issue but if i build with development then it's working fine without any error.

did yall figure it out yet?

I didn’t find any solution. Just one solution working is for me is NODE_ENV=development I have use this value in my .env file and on Azure server i also set configuration value as above and it's working fine for me. if you use production as environment it will not work.

How do you mess up this bad is my question.  Unfortunately adding "@babel/plugin-proposal-private-property-in-object": "^7.21.0" to my dependencies and or installing doesnt work.

To make adding @babel/plugin-proposal-private-property-in-object": "^7.21.0" to my package.json work with the build command, I had to add the package to the babel config as a plugin also:
// babel.config.js

plugins: [
  ...
  require('@babel/plugin-proposal-private-property-in-object').default,
];

the solution is to install it using 'yarn add @babel/plugin-proposal-private-methods --dev'

Possible workaround:

Install @babel/plugin-proposal-private-property-in-object
Deletenode_modules/ & package-lock.json
Run npm i again

Just make sure that @babel/plugin-proposal-private-property-in-object is listed under dependencies and not devDependencies.
This is the reason you're getting errors only when bundling for production and not development.

After selecting these versions (normal dependencies, not dev), normal production build worked for me:
    "@babel/core": "^7.22.5",
    "@babel/plugin-proposal-private-property-in-object": "^7.21.11",

PS: It is still throwing this warning:
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.
babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

Just make sure that @babel/plugin-proposal-private-property-in-object is listed under dependencies and not devDependencies.
This is the reason you're getting errors only when bundling for production and not development.

This worked for me and removed the warning

"@babel/plugin-proposal-private-property-in-object": "^7.21.11",

Thank you.
When referencing "@babel/plugin-proposal-private-property-in-object", I got the warning

[1/4] 🔍  Resolving packages...
warning<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.

So, following the warning, I installed "@babel/plugin-transform-private-property-in-object instead.

It's work for me

Просто убедитесь, что @babel/plugin-proposal-private-property-in-objectэто указано в разделе , dependenciesа не devDependencies.
Именно по этой причине вы получаете ошибки только при сборке для производства, а не для разработки.

Unfortunately, this action did not help, the problem remained
although @babel/plugin-proposal-private-property-in-object": "^7.21.0" is only contained in the "dependencies" section

I had the same issue, and what was causing it was the fact that the plugin-proposal-private-property-in-object package in the node_modules/@babel dir ain't exist, the thing I figured out after tracing the error.
So the simple solution 'That worked for me' was to run the command :  npm install --save-dev @babel/plugin-proposal-private-methods or  yarn add @babel/plugin-proposal-private-methods --dev in your terminal, and that will add the missing package and solve the issue!

Make sure that the package exists in the @bable dir inside of your node_modules.
I had the exact issue though with plugin-proposal-private-methods, and after tracing the error back it turned out that the package is missing in the directory, so running the the install command updated the dir and solve the issue.
You can run the one of the following commands to install the package if missing :
npm install --save-dev @babel/plugin-proposal-private-property-in-object
yarn add @babel/plugin-proposal-private-property-in-object --dev

Make sure that the package exists in the @bable dir inside of your node_modules.
I had the exact issue though with plugin-proposal-private-methods, and after tracing the error back it turned out that the package is missing in the directory, so running the the install command updated the dir and solve the issue.
You can run the one of the following commands to install the package if missing :
npm install --save-dev @babel/plugin-proposal-private-property-in-object
yarn add @babel/plugin-proposal-private-property-in-object --dev

@babel/plugin-proposal-private-property-in-object
Thank you very much, this solution helped.
Please note @babel/plugin-proposal-private-property-in-object was set to dependencies and not to devDependencies

Возможный обходной путь:

Управо@babel/plugin-proposal-private-property-in-object
Удалить node_modules/&package-lock.json
Беги npm iснова

Thank you very much, this solution helped.
Please note @babel/plugin-proposal-private-property-in-object was set to dependencies and not to devDependencies

"@babel/plugin-transform-private-property-in-object": "^7.24.6"  is the current version

"@babel/plugin-transform-private-property-in-object": "^7.24.6" is the current version

In my current project, if I use @babel/plugin-transform-private-property-in-object instead of @babel/plugin-proposal-private-property-in-object, I still receive the following error on build:
Error: Cannot find package '@babel/plugin-proposal-private-property-in-object' imported from /Users/redacted/Development/BlueBubbles/bluebubbles-server/packages/server/babel-virtual-resolve-base.js
[1]     at new NodeError (/Users/redacted/Development/BlueBubbles/bluebubbles-server/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:195:5)
[1]     at packageResolve (/Users/redacted/Development/BlueBubbles/bluebubbles-server/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:899:9)
[1]     at moduleResolve (/Users/redacted/Development/BlueBubbles/bluebubbles-server/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:939:18)

The only fix is to install @babel/plugin-proposal-private-property-in-object, even if my webpack configuration uses the "official" (non-proposal) package. I'm not entirely sure what is using the proposal package rather than the official

Just make sure that @babel/plugin-proposal-private-property-in-object is listed under dependencies and not devDependencies.
This is the reason you're getting errors only when bundling for production and not development.

Yes! thnq very much...it worked for me


perf: build up more instances before Polynomial.semiring

The benchmark should be tested after #7518 is merged.

[x] depends on: #7518

!bench

!bench

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.


Unified Markdown Preview

User Story
As a vscode note-taker, I'm not beholden to our legacy plugin for previewing my markdown notes. Leads to faster, more feature-rich preview in the long run.
Tasks/Related Issues

#269

RFC/Design

I can't find a bug report for it, but there's an issue in enhanced preview (and the project it was forked from) where web links with query strings only include the first param, cutting off at the first "&", which in most cases renders the link broken


Refactor the Get-Content tests to use -TestCases

This came up during the code review for PR #3808 regarding this test:
It "should throw 'PSNotSupportedException' when you set-content to an unsupported provider" -Skip:($IsLinux -Or $IsOSX) {
It should be refactored to use the -TestCases feature of Pester.
Environment data
6.0.0-beta.2

Fixed in PR #6082


Adding skip-pre or skip-post do not do anyhing

posts scripts are still there even adding --skip-post flag

Wrong version installed.


Extend error states

Description
Enhance the error handling mechanism for the orchestrator and gate components by extending the list of available error codes. This will improve the visibility and detail of error information, particularly beneficial for the customer dashboard to understand why a data set could not be processed.
Currently, the orchestrator and gate components have a limited set of error codes. Extending these error codes will provide more granular information on processing failures, aiding in quicker diagnosis and resolution. This feature will update both the orchestrator and gate components to support a more comprehensive list of error codes.
Benefits

Improved Transparency: Customers can view detailed error reasons on the dashboard, enhancing trust and user experience.
Enhanced Debugging: Developers and support teams can identify and resolve issues more efficiently with detailed error information.
Better Monitoring: Allows for more precise monitoring and logging of errors, leading to improved system reliability.

Camel case:
naturalPersonError,
bpnErrorMissingParent,
bpnErrorNotFound,
bpnErrorTooManyOptions,
mandatoryFieldValidationFailed,
blacklistCountryPresent,
invalidSpecialCharacters,
mandatoryFieldMissing,
mandatoryIdentifierMissing,
identifierTypeUnknown,
bpnlChanged,
unclearEntity,
unknownSpecialCharacters,
matchBasedOnProvidedNameOrIdentifier,

By extending the list of available error codes for the orchestrator and gate components, we enhance the system's transparency, debugging capabilities, and overall reliability. This feature will provide significant value to both customers and the development team by offering more detailed insights into processing errors.
Dependency:
This feature could be relevant for every product or user who is integrating the gate.
FYI: @evegufy / @MaximilianHauer
Additional information

[ ]  I'm willing to contribute to this
Contribution will be done by @kunyao-cofinity-x
Committer to support are: @nicoprow / @maximilianong

Standard adaption might need to be done:
0076 / 0074
Will be taken to a deep dive session with this one:
https://github.com/eclipse-tractusx/sig-release/issues/726

Description
Enhance the error handling mechanism for the orchestrator and gate components by extending the list of available error codes. This will improve the visibility and detail of error information, particularly beneficial for the customer dashboard to understand why a data set could not be processed.
Currently, the orchestrator and gate components have a limited set of error codes. Extending these error codes will provide more granular information on processing failures, aiding in quicker diagnosis and resolution. This feature will update both the orchestrator and gate components to support a more comprehensive list of error codes.
Benefits
* Improved Transparency: Customers can view detailed error reasons on the dashboard, enhancing trust and user experience.

* Enhanced Debugging: Developers and support teams can identify and resolve issues more efficiently with detailed error information.

* Better Monitoring: Allows for more precise monitoring and logging of errors, leading to improved system reliability.

Camel case:
//GR Error Code
naturalPersonError,
bpnErrorMissingParent,
bpnErrorNotFound,
bpnErrorTooManyOptions,
mandatoryFieldValidationFailed,
blacklistCountryPresent,
invalidSpecialCharacters,
mandatoryFieldMissing,
bpnlChanged

//Gate Error Code
unclearEntity,
unknownSpecialCharacters,
mandatoryFieldMissing,
matchBasedOnProvidedNameOrIdentifier,
none

By extending the list of available error codes for the orchestrator and gate components, we enhance the system's transparency, debugging capabilities, and overall reliability. This feature will provide significant value to both customers and the development team by offering more detailed insights into processing errors.
Additional information
* [ ]   I'm willing to contribute to this
  Contribution will be done by @kunyao-cofinity-x
  Committer to support are: @nicoprow / @maximilianong

The BpnlChanged code is not an error code as far as I can see. It is a comment or success code that the orchestrator currently does not support. We should remove it from this list.
Also 'None' is  not necessary to include, as no error is indicated by a NULL value of the error type field.
Is there a reason why we divide the error codes into Gate and Orchestrator? I would assume at least all errors of the Orchestrator should be visible in the Gate (maybe not all errors of the Gate in the Orchestrator though)

After a brief consultation with Sebastian, the feature is set to 'backlog' status. Associated committer is also fine with it.

In a last refinement call we added the following to attributes:
identifierTypeUnknown,
mandatoryIdentifierMissing,
need to be discussed: will both be added finally to the reference implementation?!

put the open decision label cause there is discussion needed

Hey,
if you write the testcases for this topic please ensure to have also an E2E testcase for the portal in scope.

As long as the SharingStateType is not changed the portal does not need to do any adjustments, we take the error codes just as string and use them. Our current implementation of the SharingStateTypes are the following:
Pending = 1,
Success = 2,
Error = 3,
Initial = 4,
Ready = 5
@nicoprow can you please confirm that the SharingStateType will stay the same?

As long as the SharingStateType is not changed the portal does not need to do any adjustments, we take the error codes just as string and use them. Our current implementation of the SharingStateTypes are the following:
Pending = 1, Success = 2, Error = 3, Initial = 4, Ready = 5
@nicoprow can you please confirm that the SharingStateType will stay the same?

The error states affect the SharingStateErrorType and TaskErrorType. The sharing state type is unaffected by this.
Note that the BPDM API does not adhere to a specific order of the Enum values like associating Pending with 1 for example. But I assume that the order here refers to your internal Enum definition, correct?

@nicoprow thanks for confirming.
Yes correct, the order of the enum values is just for our internal usage

Some hints from Release Management (@ther3sa) and Tractus-X Project Lead (@stephanbcbauer)

Please add missing sections from feature template

@MaximilianHauer mentioned to trigger the portal team after this is implemented

https://github.com/eclipse-tractusx/bpdm/pull/1003


tooltips: Hide scroll button tooltip under transition.

This PR fixes the bug where the scroll button tooltip does not hide even after the button is dissapeared. This is because the fading animation confuses the data-referrence-hidden property of tippy.
This issue has been resolved in #29253. But presently the jquery wraps the native event object in it's own event object as a wrapper. Hence we would need to bypass the jquery wrapper to access a specific property.
This PR uses the originalEvent key to bypass the jquery wrapper and directly access the propertyName property from the jquery event object.
Fixes: #28656

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @shashank-23002!


opencv3: Fix pkg-config lib path

Fixes #35886
Motivation for this change
The library path pkg-config supplies for an OpenCV built from the opencv3 definition in nixpkgs is wrong: it appends the absolute path of the lib directory to the $out directory.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Thanks! If possible look into upstreaming (if that makes sense).

Also has merge conflicts currently

This patch applied to OpenCV 3.3 when that was in nixpkgs, but is no longer needed in 3.4.

Thanks!


Update azure-resource-groups-limits.md

Maximum number of tags for each resource or resource group has been increased to 50 from 15.
Documentation was updated in this commit
Documentation from azure-resource-groups-limits.md should be updated as well. It says that maximum "Number of tags per resource or resource group" is 15 and not 50.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cd57b6d-3c6f-e546-b3ea-f83892f4c23d
Version Independent ID: 27aecc7b-f107-96d4-b044-ae026bca2727
Content: Azure subscription limits and quotas
Content Source: articles/azure-subscription-service-limits.md
Service: billing
GitHub Login: @rothja
Microsoft Alias: byvinyal

@Vojkan-Cvijovic  Thanks for your feedback! We will investigate and update as appropriate.

@rothja FYI.

@rothja Could you verify the limit change from the concerned team and update the doc?

@Vojkan-Cvijovic Thank you for this feedback and sincere apologies for the delay. This feedback is also being addressed in another git issue and the update should happen very soon in the documentation. I am going to close this git issue, but please reopen if you do not see the change in the documentation soon, and I will investigate. Thank you! #please-close


Macro and header names are too plain and conflict easily

A macro named ENUM is a prime candidate for easy symbol ambiguity. And in my code base, I am seeing this. This requires me to do silly inclusion trickery like so:
// All normal includes at the top

#undef ENUM
#include <enum.h> // This one must be last in the list of include directives

ENUM(Fubar, int, One, Two, Three);

The best solution to this would be to make a more generic name for your macros. Boost does this by prefixing macros consistently. This makes them a bit more verbose, but it's a necessary annoyance when dealing with macros. I think maybe a name like BETTER_ENUM() would work just fine.
The include is odd as well. I am free to nest your header file in any directory I want, so I can resolve the issue that way. But "out of the box" your solution implies you include enum.h directly. Instead, I think you should nest your includes to avoid ambiguous includes:
#include <better/enum.h>

This might require restructuring your repository a bit, to make it obvious to people that the include is supposed to be done in a relative way like I've shown above.

The first change seems reasonable to do now. It would be nice to get the opinions of more users first, but I am not sure how to solicit them.
I'll probably hold off on the second. Users are still free to put enum.h in a subdirectory of their choosing, as you mentioned. I may nest enum.h in a better-enums subdirectory later, if the header gets split into multiple files, or if there are a lot of "extras" to distribute. I do already have such a better-enums directory – it's just not first-class, since the only thing there is the C++17 demo.

The file nesting isn't that important, it was a side-suggestion. Let's drop that off the plate for now to keep the discussion more focused.
Concerning the macro name, I'd argue that doesn't require feedback at all. Simple macro names are notorious for conflicting with symbols. It's a non-decision to rename it. I think if you expect your library to be used in professional, production code which has millions of lines of code and numerous incoming dependencies, the rename will be an absolute requirement.
Again, I'd like to refer you to the Boost.Preprocessor library. You'll notice they prefix all macros with BOOST_PP. This is akin to a namespace in the macro world, as you know. The verbosity and "extra characters to type" tradeoff is well worth the guarantee that your library will work out-of-the-box in most (if not all) code bases regardless of size and number of dependencies.

As I said, I am in favor of changing the macro name. I merely added that it would be nice to get additional feedback, since a large number of people seem to have been fine with ENUM, and also for good ideas for a replacement name that only 2 people (us) might not come up with. However, I won't be waiting for feedback, since I don't have an efficient way of getting it at this point. I will do this change together with the other changes we are currently discussing.

I like the name ENUM too, honestly if there was no conflict the name is perfect. But scattering the #undef's all over our code base would quickly land me lots of ugly looks from my coworkers in my code reviews :-)
Thanks for welcoming my feedback, you've done a great job.


Escaped Double Quotes In SSML

At present if outputting speech that contains SSML which contains double quotes for example:
<speak>I said hello. <break time="2s"/>Did you hear me?</speak>
the resulting SSML will be:
<speak>I said hello. <break time=\"2s\"/>Did you hear me?</speak>
This causes the JSON passed to Amazon to be invalid and causes an error.

Currently determining the best solution to resolve. Possibilities are:

Change all " to ' on the fly.
Return an exception so the error can be logged.
Identify if this can be disabled in JSON_ENCODE however this may cause an issue where quotes are not nested correctly.

Currenlty open to suggestions.


Integrated Terminal: Option to unwrap

It would be useful if we have an option to unwrap the output on the integrated terminal, for those programs that have lots of huge outputs.

https://github.com/Microsoft/vscode/issues/23688


Referencing patch files instead of copying them

Sometimes developers don't want to copy the files into the patch but reference them in the patch only.
Using
@../packages/my_package.sql

is an approach to install a file that resides in the source tree and not in the patch tree.
One option to implement that would be to use the PatchFiles.txt file not only for copying the files but also to reference them while running the installer.
The file listing from PatchFiles.txt could be merged with the actual files from the patch files ... and installed depending on their combined sort order.
This could either be implemented for the whole file by providing a copy/reference mode to either copy or only reference the files.
Or it could be done on a folder or individual file level. Then we would need a specific syntax for the files, e.g. :
C:xlib*.pks

to copy files and
R:xlib*.pks

to only reference files.

I like this enhancement, but I would argue that, when using version control, this should be the default behavior. Copying sources to the patch only makes sense when you don’t use version control.

I agree. At the same time more people will use the copy approach and not use more sophisticated methods. This is just my experience.
Anyhow, when I implement both approaches you can easily choose your approach. Only once you have to modify the patch template (and only delete what you don't need) and you are good to go.
I deal with the reference files in the following manner:

I look at the SourceFilesReference.txt file and virtually make a list of the files ... and the target locations (as if I would copy them to the target directory). This is important for sorting because the referenced files should also adhere to the sort order ... just as if they were copied. Tables before views before packages, etc.
I display the list of files as if they were copied. In brackets you can see which file is referenced)
I execute the referenced file together with the other files in the patch folder (as if both were in the patch folder).

This is the result when you run the 2.validate.sh or 3.install.sh:

You can pass the file SourceFilesReference.txt and the source directory on the command line. You just have to fill in the files you want to reference in the patch. This file is automatically picked up by the generated shell scripts:

Then 1.copy-patch-files.sh will pick up a different file with the same contents. It used to be PatchFiles.txt and now we have two files instead:

SourceFilesCopy.txt (picked up by 1.copy-patch-files)
SourceFilesReference.txt (picked up by 2.validate and 3.install)

Whatever you fill in ... will get picked up.

I like that feature ... great feedback 👍

The virtual merging of files works great. In this sample I have a script to alter table add column in the patch subdirectory:

The rest of the files come from the file SourceFilesReference.txt:

Here is the log of which files are installed in which order:

The alter-table-statements.sql fits nicely into the sorted (virtual list) of the files from both directories.
Now we have a clean separation between purely patch-specific files and the source files from the source tree.
And if you so choose to, you can use the contents of the SourceFilesReference.txt for the copy command. The different approach remain possible, you can pick and choose.


Fix RUBY_VERSION to be set to current version used

Overview
When using Frum, I'm not seeing RUBY_VERSION set within the environment.
Screencast
https://user-images.githubusercontent.com/50245/128615599-247d8534-759a-4a4e-ad84-962bb6a80f23.mp4
Steps to Recreate

Install Frum.
Configure Frum for your shell (in my case, I'm using Bash).
Run ENV | grep RUBY, notice that RUBY_VERSION doesn't display in the list.

Desired Behavior
As one switches between different Ruby versions, it'd be nice to see RUBY_VERSION reflect the current version being used. This would match behavior of similar Ruby version managers.
Environment

macOS: macOS 11.5.1
Frum: 0.1.1
Ruby: 3.0.2p107 (2021-07-07 revision 0db68f0233) [arm64-darwin20.5.0]

Can we bump this up the priority list a bit?
When testing code against multiple version of ruby on a regular basis, being able to display the current ruby version in the shell prompt would be great.
If an environmental variable is too tricky, perhaps a shell command similar to RVM's approach might be simper.

@TaKO8Ki this should have more importance than just an enhancement. Many gems use RUBY_VERSION to add dependencies that are required only on ruby 3.0, like net-smtp, net-protocol etc.

Using 11.6 and frum 0.1.2, the RUBY_VERSION variable is displayed (on my machine) but contains the wrong value.


Add Semantic hub chart in E2E testing chart

tbd

PR was merged and available now:
https://github.com/eclipse-tractusx/tractus-x-umbrella


UI - results - Labels for concept classifying columns not depicted?

When I run Odalic agains ADEQUATe KB, in case of disambiguation, UI properly shows labels (see below, URI contains UUID, but there is nice label). But in case of classificiation, label is not obtained and UUID is used. Why?

Solution: It should also take the label of the concept being suggested for classification.
@KataBoku did you encounter that as well?

So it seems that the problem is that the header column is not able to display labels contained within skos:prefLabel property (although such property may be defined in the config file for the KB - in the enums, but probably applies only to disambiguated entities?)
For disambiguated entities it works correctly.

This issue was moved to odalic/sti#254


Update Transit service to include new Prefix Filter APIs.

PR summary
Transit service update to include the new Prefix Filter APIs.
This includes unit and integration tests as well as related help documentation
Fixes: new feature
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
Current Transit Gateway Connection APIs do not support new prefix filter feature.
What is the new behavior?
Prefix filters are now supported by Transit Gateway Connection APIs
Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

:tada: This PR is included in version 0.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updating charts.md file

If you wouldn't mind signing the DCO as mentioned in #4998 that'd be great. Thanks.

Closed by #5011


factor-lang: Restructure package for easier extension

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3438

I have also added a forgotten feature buildFactorApplication and added proper documentation in the Nixpkgs manual.

Regarding the change in CODEOWNERS. I would like to take the responsibility but, obviously, need some kind of higher-up approval. I can also revert the change again.

Regarding the change in CODEOWNERS. I would like to take the responsibility but, obviously, need some kind of higher-up approval. I can also revert the change again.

The problem with codeowners is, that it doesn't properly work if you do not have merge permissions :(

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3696

@Aleksanaa and @inclyc nixf-tidy mis-detects the use of factor-lang and factor-no-ui in mk-factor-application.nix. It marks them both as unused, while they are use to construct the default parameter value in the following function definition.

It marks them both as unused, while they are use to construct the default parameter value in the following function definition.

See https://github.com/NixOS/nixpkgs/issues/331085 and similar discussion in https://github.com/NixOS/nixpkgs/pull/330589. TL.DR it may not work as you wish.

Also it can be ignored this time. The @args syntax may need some fine-grained logic to judge. If you don't want to see the CI failure, add [skip treewide] to your PR title, but this will also skip formatting check so you should have your PR formatted first

I kindly suggest do not write code confusing the CI, if you do so, likely your code also confuses homo sapiens.

It marks them both as unused, while they are use to construct the default parameter value in the following function definition.

See #331085 and similar discussion in #330589. TL.DR it may not work as you wish.

If you are talking about the pattern in this example may not work, then that example is also not relevant here, in a different way it is not relevant in https://github.com/NixOS/nixpkgs/pull/330589#issuecomment-2254523553.  The "unused" parameters factor-lang and factor-no-gui, detected by nixf-tidy, do not have default values and they are always passed in by callPackage.
If what you are talking about is not that example, then I would like to know what it is since that example seems to be the only confusing thing that you provide.

I kindly suggest do not write code confusing the CI, if you do so, likely your code also confuses homo sapiens.

An honest question: do you think the usage of factor-lang and factor-no-gui here is confusing to you, as a human being instead of a tool, and why?

BTW, I suggest putting discussion about nixf-tidy into threads.

Hi @jian-lin,
I don't have a strong opinion on the linter's styling in this PR. Perhaps we should move the discussion to https://github.com/NixOS/nixpkgs/issues/331085 to decide how to handle unused lambda formal arguments and see if we can reach a consensus.

@ShamrockLee Thanks! I added the missing attributes. I must confess, it is not entirely clear to me when and with which arguments the inner function (mapping its arguments to attrs) is actually called.

@ShamrockLee Thanks for all your help and comments so far. I made the adaptations.

Most build helpers would respect user-specified phases. For example, this is how buildGoModule provides its buildPhase:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/go/module.nix#L202
Are there solid reasons to prohibit users from specifying the buildPhase and the installPhase?

This is reolved.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4919


isolators: include isolator enforcement requirements in manifest

An isolator MAY include a field named "required". If the "required" field is present and has value "true" then an executor MUST either enforce the isolator or refuse to execute the container and return an error. A missing "required" field is treated as a value of "false".

Pull request #225


Reduce the time horizon from 2 days to 30 minutes

... to avoid overwhelming of freyja
Cron job is currently configured to run every 15 minutes. No updates on freyja needed after merging, the code will be picked directly from GH.

Makes sense to me.

Thanks, then merging.


[FLINK-19867][table-common] Validation fails for UDF that accepts var…

…-args

What is the purpose of the change
Fix the failure to extract eval method for functions with var-arg parameter.
Brief change log

Check var-arg parameter first in ExtractionUtils.isInvokable
Add test case

Verifying this change
Added test case
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

Hi @twalthr , could you please take a look at the proposed changes here? Thanks!

Sure, will assign this to me.

Thanks Timo for the review


Broken Input ElementComponents in 1.58.1

It appears that Element components with ‘Use Input’ enabled have been negatively affected by changes in 1.58.1. This issue is true for elements with and without a ButtonComponent. When clicking on an input element, the following error is thrown:
Uncaught TypeError: this._clickedEntities is undefined
Provide as much information as possible. Include (where applicable):

URL to a simple, reproducible test case that illustrates the problem clearly: https://playcanvas.com/editor/scene/1596864
Screenshots:

Steps to Reproduce

Create a new blank project

Add a screen element and a button element

Launch App and click the button

Repeat steps 1-3 with 1.58.0

I can't reproduce the issue here: https://playcanvas.com/editor/scene/1596875

Uploading Kapture 2022-11-23 at 16.56.35.mp4…

That's strange. I get the error on my end with your project:

Firefox only issue perhaps? .... I can confirm it works in Chrome for me.

Seems to be firefox only 🤔

Safari desktop is breaks :(


TypeError: grad3(...) is undefined while using Perlin3.

I am using this library from npm and when I run the perlin3 function with -1 as the z parameter, I keep getting this error.
const perlin = new tumult.Perlin3(Math.random());
console.log(perlin.get(0,0,-1));

TypeError: grad3(...) is undefined

I'm kinda low on bandwidth at the moment; it's currently exam season for me.
I might be able to fix the bug after this weekend.
This particular issue is caused by Math.trunc(x) % 256 returning a negative number if x is negative. I use the result to deference a lookup array, which then returns undefined. I'll use x & 255 instead.
I've experimented and noticed other odd bugs, such as perlin.gen(0, 0, 512) returning numbers outside the [-1, 1] bound. This is why I'm holding back on a "hot fix"; I want to fix it properly when I get around to it.
Dunno what you're using the library for, but I know the library works well for positive fractional input
Eg.
const tumult = require('tumult')
const perlin = new tumult.Perlin3(Math.random())

for (let i = 0; i < 255; i++) {
  for (let j = 0; j < 255; j++) {
    for (let k = 0; k < 255; k++) {
      console.log(perlin.gen(i / 255, j / 255, k / 255))
    }
  }
}

I've created NodeJS bindings for a C++ noise library which you may want to use as an alternative: https://www.npmjs.com/package/fastnoisejs

Perlin 3 is still broken, it actually doesn't work at all for me. Throws an error Cannot read properties of undefined (reading 'dot'). grad3 is supposed to return an object that has a dot function and it returns undefined. All the noise is actually broken in this library sadly, it just returns 1 past a certain fairly low input (not sure the exact value). I'm not passing any negative numbers in.


Unable to find the association target class of "equipment__translations" in EntityBundle\Entity\Etablissement\EquipmentLightVersion.

Hi Everyone,
I am using A2lix Translatable within sonata and it works perfectly. However, when I try access translatable of OneToOne related entity, I have the following error message:

Unable to find the association target class of "equipment__translations" in EntityBundle\Entity\Etablissement\EquipmentLightVersion.

Here is the code used within sonata admin class:
->add('equipment.translations', TranslationsType::class)
And here is the join (from EntityBundle\Entity\Equipment\EquipmentLightVersion entity):
/**
     * @ORM\OneToOne(targetEntity="EntityBundle\Entity\Equipment\Equipment")
     * @ORM\JoinColumn(nullable=false)
     */
    private $equipment;

I am not sure if this is a bug or misusage.
Any clues on how to fix this?
Thanks in advance,
Jon

I don't think this issue belong here, since SonataAdmin handles forms in a tricky way.
Please, if you still have this issue, maybe try posting it to Sonata, where we can help if it is really a bug on our end, or post it to stackoverflow (as Sonata recommends for questions).
Closing.

I have same issue where I don't have SonataAdmin installed,  but is only symfony. after upgrade from symfony 3 to 4 this error appears.
REQUES Uncaught PHP Exception RuntimeException: "Unable to find the association target class of "translations" in AppBundle\Entity\User." at /home/.../vendor/a2lix/auto-form-bundle/src/ObjectInfo/DoctrineORMInfo.php line 54

I'm having the same issue but in EasyAdmin. Did anyone found a solution for that?


Reading a layer having multiple properties with the same name

Expected behavior and actual behavior.
When trying to read a layer for which multiple properties have the same name, only the last one is loaded in the returned Collection.
This is definitely bad data format, but GDAL correctly displays all the properties even if they have the same name.
QGIS does append a suffix ("prop", "prop_1", "prop_2", ...).
I think the issue comes from python dictionary with constraints on uniqueness of the keys.
I would have expected to at least get a warning, or better to have the same behavior than in QGIS.
Steps to reproduce the problem.
The data comes from the AIRBUS GeoStore.
wget "https://datadoors.intelligence-airbusds.com/export/v1/static/export/export-20230106-11165137.zip"
unzip -o "export-20230106-11165137.zip" -d "geostore_products"

With GDAL I can see all the properties:
$ ogrinfo geostore_products Export
...
geometry: String (254.0)
geometry: Integer64 (18.0)
geometry: Integer64 (18.0)
geometry: Integer64 (18.0)
geometry: Integer64 (18.0)
...

With fiona I can only see one:
import fiona

fpath = "geostore_products"
c = fiona.open(fpath, layer="Export")

# Only one geometry property
print([p for p in c.schema["properties"].keys() if p.startswith("geo")])  # ['geometry']

# And this is not the interesting one
print(c.schema["properties"]["geometry"])  # int:18

Attempt at tracking down the issue
I suspect that the other "geometry" properties were overridden during translation as a python dictionary, since keys must be unique.
I can trace back that this is true starting from the following line in fiona/collection.py::Collection.__init__#L236:
self.session.start(self, **kwargs)

which leads to the issue being located in one of the two following lines in fiona/ogrext.pyx::Session.start (#L572 or #L577)
self.cogr_ds = gdal_open_vector(path_c, 0, drivers, kwargs)        #L572
self.cogr_layer = GDALDatasetGetLayerByName(self.cogr_ds, name_c)  #L577

if #L572 this further comes down to fiona/ogrtext.pyx::gdal_open_vector#L134 with the following call:
cogr_ds = exc_wrap_pointer(
    GDALOpenEx(path_c, flags, <const char *const *>drvs, <const char *const *>open_opts, NULL)
)

So this is either GDALOpenEx or GDALDatasetGetLayerByName, which come from include "gdal.pxi".
I can find them there, but my understanding of the code stops here:

gcore/gdaldataset.cpp::GDALOpenEx#L3231
gcore/gdaldataset.cpp::GDALDatasetGetLayerByName#L4380

Operating system
Ubuntu 20.04.5 LTS x86_64
Fiona and GDAL version and provenance
$ conda list
# Name                    Version                   Build  Channel
fiona                     1.8.22          py311h3f14cef_5    conda-forge
gdal                      3.6.1           py311hadb6153_2    conda-forge
libgdal                   3.6.1                he31f7c0_2    conda-forge

@Paul-Aime thanks for the report! Indeed Fiona doesn't know what to do with properties that have the same name. What format does Airbus use for export and why are they doing this terrible thing?
It would be pragmatic to do what QGIS does.

It is .shp file format.
I think the link I provided to get a sample to reproduce the error still works: https://datadoors.intelligence-airbusds.com/export/v1/static/export/export-20230106-11165137.zip
It seems like terrible file format indeed, and there is more since the feature in question is also called "geometry", see above cross referenced issue #2752 in geopandas, but that's another topic.
I agree that QGIS behavior might be pragmatic, it reminds me of the mangle_dupe_cols in pandas.read_csv function.

Looks like Pandas is leaning towards standardizing on "name", "name.1", "name.2", etc.

Looks like it is deprecated in pandas though, and leaning towards letting the user choose the pattern in the future.
QGIS does "prop", "prop_1", "prop_2" etc., might be more relevant to follow QGIS if the choice is not let to the user (since GIS related).
A quick first step could be to issue a warning when there are multiple features named the same, specifying that only the last one is kept (current behavior).
Then it is to be considered if "mangling" should be automatic, optional but the default, optional but not the default, and if current behavior ("clobbering") is kept in the case where mangling is not done, or if an error is raised.
Considering discussion in geopandas #2752, it seems like pyogrio prefers no mangling at all and let an error arise in geopandas.

Warning as the first step is a great idea! We'll do that for 1.9.1 and then proceed from there.

@Paul-Aime with the changes in #1201 this is what I now see:
fio info --layer Export --indent 2 geostore_products/ | xclip -i -selection clipboard
WARNING:fiona.ogrext:Field name collision detected, field is skipped: i=2, key='geometry'
WARNING:fiona.ogrext:Field name collision detected, field is skipped: i=3, key='geometry'
WARNING:fiona.ogrext:Field name collision detected, field is skipped: i=4, key='geometry'
WARNING:fiona.ogrext:Field name collision detected, field is skipped: i=5, key='geometry'
{
  "driver": "ESRI Shapefile",
  "schema": {
    "properties": {
      "date": "str:254",
      "geometry": "str:254",
      "indexDat": "str:254",
      "uid": "str:254",
      "xuid": "str:254",
      "XZIncide": "int:18",
      "YZIncide": "int:18",
      "acrossTr": "int:18",
      "alongTra": "int:18",
      "viewingA": "int:18",
      "browseLa": "str:254",
      "browseMe": "str:254",
      "browseSm": "str:254",
      "overlayG": "str:254",
      "overlayM": "str:254",
      "resoluti": "int:18",
      "id": "str:254",
      "provider": "str:254",
      "sunAzimu": "int:18",
      "sunEleva": "int:18",
      "vehicle": "str:254",
      "cloudCov": "int:18",
      "constell": "str:254",
      "groundSt": "str:254",
      "incidenc": "int:18",
      "name": "str:254",
      "orientat": "int:18",
      "snowCove": "int:18",
      "remoteRa": "str:254",
      "archiveN": "str:254",
      "archiveU": "str:254",
      "category": "str:254",
      "productN": "str:254",
      "productU": "str:254",
      "pin": "str:1",
      "browse": "str:1"
    },
    "geometry": "Polygon"
  },
  "crs": "EPSG:4326",
  "crs_wkt": "GEOGCS[\"WGS 84\",DATUM[\"WGS_1984\",SPHEROID[\"WGS 84\",6378137,298.257223563,AUTHORITY[\"EPSG\",\"7030\"]],AUTHORITY[\"EPSG\",\"6326\"]],PRIMEM[\"Greenwich\",0,AUTHORITY[\"EPSG\",\"8901\"]],UNIT[\"degree\",0.0174532925199433,AUTHORITY[\"EPSG\",\"9122\"]],AXIS[\"Latitude\",NORTH],AXIS[\"Longitude\",EAST],AUTHORITY[\"EPSG\",\"4326\"]]",
  "name": "Export",
  "bounds": [
    -1.611233172732394,
    43.38495043561227,
    -1.345365602139011,
    43.57314289987615
  ],
  "count": 2
}

Seems great!


Transitions not getting oldView/newView as arguments

http://ef4.github.io/liquid-fire/#/transitions/defining
The doc says transitions gets oldView/newView as argument, but I'm not seeing this being passed in.
https://github.com/ef4/liquid-fire/blob/master/app/transitions/move-over.js
Is the doc wrong?

The doc is correct for the latest liquid-fire release, but not for master. There are undocumented changes on master, which is why it hasn't been released yet.
I have simplified this API so that instead of receiving oldView and a function that inserts and returns a promise for newView, you have direct access to this.oldElement, this.newElement, plus a bunch of other related state.
The built-in transitions illustrate this new style, and the available fields come from here in the source: https://github.com/ef4/liquid-fire/blob/14752e71d3685c3890a1a9642cbc7c3818567b70/addon/running-transition.js#L42-L79

Ah ok, good to know.
Thanks!