[Cluster-refactor] About refine classes name

Background: we're working together with @jixuan1989 to refactor cluster module. The dev branch is cluster-

Why
When I first looked at the codes of IoTDB, I lost in the kinds of  ***Services, I want to make it clear to let more dev can hand on codes a bit easier by the opportunity.
After reviewing the code, I think the request process flow could be divided into 3 layers as show in the image. The structure is clear but not classes name. So, I think we can refine the class names in Transport layer and RPC interface layer to make codes clearer.

Suggestions
I don't align the suggestion changes with the class names in the server module because I don't think sever module is clear enough according to my understanding. And let's go through these layers.
Cluster Instance
ClusterIoTDB is the server instance which control the sub servers lifecycle.
Transport Layer
I call this layer as transport layer because the instances in the layer take charge of setup port listening,  setup TCP work threads, establish connection, hand over requests... via thrift APIs.
Right now the class in this layer are called ***Service which I don't think is clear. An idea is rename the classes as ***SubServer.
RPC interface Layer
The classes in this layer are the implementation of thrift RPC interfaces which handle the RPC call from thrift client.
Right now the class in this layer are called ***Service. If we can change the classes name in the transport port layer, I think ***Service here is acceptable. A suggestion is ***RPCHandler which is better than ***Service in current implementation IMO. ***Service could be used to hide the concrete RPC framework like thrift but right now we don't have that layer.
Executor Layer
The classes in the layer encapsulate the concrete execution logic. Won' analysis here.
Finally, welcome join the discussion and every idea is import for us.

The naming of class in RPC interface layer should contain ThriftServerImpl or RPCServerImpl, and place them in a separate package called xxx.thrift.impl or xxx.rpc.impl. These names clearly indicate that they are implementations of thrift interface. Now they are placed in the org.apache.iotdb.cluster.server package.

I could't agree more.
Whether it's a service that handles client requests, or a service that communicates internally, it should like a module in server.we should not nest too deeply in the server.

The naming of class in RPC interface layer should contain ThriftServerImpl or RPCServerImpl, and place them in a separate package called xxx.thrift.impl or xxx.rpc.impl. These names clearly indicate that they are implementations of thrift interface. Now they are placed in the org.apache.iotdb.cluster.server package.

I could't agree more.
Whether it's a service that handles client requests, or a service that communicates internally, it should like a module in server.we should not nest too deeply in the server.

Yes, their package relationships are more likely siblings, logically. Not parent-children ones.

Hi, I am almost free now and can find some time back to the development.

Agree to use *Server.
Agree to move the Thrift interface implementation to  xx.thrift.impl,  either using *Impl or *Service is fine, but considering the server module, I think *Impl is more moderate.
I hope to rename MetaGroupMember to MetaGroupEngine and DataGroupMember to DataGroupEngine.

Hi, I am almost free now and can find some time back to the development.

Agree to use *Server.
Agree to move the Thrift interface implementation to  xx.thrift.impl,  either using *Impl or *Service is fine, but considering the server module, I think *Impl is more moderate.
I hope to rename MetaGroupMember to MetaGroupEngine and DataGroupMember to DataGroupEngine.

Welcome back, lol! As I'm working on the refactor client pool part(code compile passed, working on UT fix, latest progress see https://github.com/apache/iotdb/pull/3886), anyone who can help rename the class would be appreciate. But we'd better let the change happens when the refactor almost done to make conflict resolve easier for other contributors.


PR: Render report in a thread.

Fixes #27.
See https://github.com/spyder-ide/spyder-reports/issues/27#issuecomment-315773535

How is the worker working? any suggestions on the worker manager model @rlaverde?

@rlaverde, first we need to merge #26 and then rebase this one because utils.workers was introduced in 3.2

How is the worker working? any suggestions on the worker manager model

It's working well, maybe a way to capture the progress of the thread (I don't if is is possible right now)

maybe a way to capture the progress of the thread

@rlaverde impossible at the moment

I left a couple of simple comments, then I'd say this is ready.


Vehicle summary

This is my last piece for SolutionPrinter refactor:
I added another table to print. It is called VehicleSummary and calculates some statistics per route level:

static info, such as vehicle and driver data
number of activities (total, by type)
durations:

total route
shift
break
travel
operation
idle

each duration could be displayed as

numeric
human readable
percentage of route time
percentage of shift time

It uses the ConfigurableTablePrinter structure, so the user can define what to see and supports excel export.
I kept the old print() functions in SolutionPrinter, but introduced new ones: I broke the output into segments (summary, routeDetails and vehicleSummary as for now) and each gets its own printXXX methods. It is much cleaner and requires not too much more lines of code from user:
    SolutionPrinter.printSummary(vrProblem, solution);
    SolutionPrinter.printRouteDetails(vrProblem, solution, SolutionPrintColumnLists.getNumeric(PredefinedList.VERBOSE));
    SolutionPrinter.printVehicleSummary(vrProblem, solution, VehicleSummaryColumnLists.getMultiple(VehicleSummaryColumnLists.PredefinedList.VERBOSE,
            Mode.HUMAN_READABLE, Mode.PERCENT_ROUTE));

Hope you'll find it useful.
(The SolutionPrinter class is a little mess, might clean it up a bit, sometimes.)

BTW, The synthetic tests works on my original problem, but I'll receive real life data soon.

@balage1551 It is indeed useful. Looking forward to use it :).

Thanks a lot!!


HW: Node / Hub data collection 06/12-06/15

Nodes gather data during "wake-ups" and transfer data to the hub.
06/12/16-06/15/16

[ ] Nodes gather data
[ ] Nodes transfer data to hub
[ ] Nodes return to sleep

Blocked, waiting on sensors for data collection.

Moving to plantalytics-hardware.


tlsconfig: drop support for go1.17 and older

Let me rebase to get rid of the first commit; I'll bring this one in once CI finishes


When to use --ambient and when not to

Hi,
I’m just getting into TypeScript and I found that TSD was no longer in vogue, and got pointed to Typings instead. Having read a little and experimented with my code, I’m still not sure what the differences are between using --ambient and not using it. Perhaps I’m being thick, but having read the explanation of ambient modules in the TypeScript handbook I came away not really understanding what an ambient module was and feeling more confused than before I read it.
Sometimes I find that there are only results if I include the --ambient flag, for example when I do typings search react and typings search --ambient react I only get a result for the latter. This makes the choice for me as there’s only one possible way to install it.
Other times there are results with the --ambient flag and also without it. For example, if I do typings search --ambient react-router and typings search react-router I get results from both. In this case, which do I use? What factors would govern the decision?

I'd always use non-ambient definitions. Non-ambient means it's created using external modules. These are much more portable, and realistically the future of TypeScript typings.
The difference is minute, it really only comes down to (usually) whether everything is wrapped in declare module "...". When it is, that definition is no longer portable and can't be used as a sub-dependency. Hence, I separated the definitions to avoid conflicts in larger projects. However, since ambient definitions have been written for more than two years as part of DefinitelyTyped, that's what you're seeing when you enabled --ambient.

I concur with @blakeembrey, use ambient whenever you can and if you bump into an issue with a non-ambient typings then try and contact the maintainer to see if it can be solved :p

Thanks. I think I understand now. In general, I was using the non-ambient whenever they were available, so looks like I was doing the right thing already :)


[Bug] Favourites

If I go into the doujin's page and unfavourite it, I can't favourite it again. I must open other doujins and go back to favourite it successfully.

Sorry, I can't reproduce it.


OpenSSF Self Certification

Registering Juno with OpenSSF, and addressing any issues found during the audit.

https://github.com/CosmosContracts/juno/pull/618

not doing per close of codacy x3


Classifier accuracy early stopping

Previously, the accuracy metric couldn't be used for early stopping of training because the parent class Posterior of AnnotationPosterior didn't recognize the attribute accuracy:
AttributeError: type object 'Posterior' has no attribute 'accuracy' scvi/inference/trainer.py:279: AttributeError
These modifications enable early stopping with the accuracy metric and demonstrate that it works with a test.

Codecov Report

Merging #277 into master will increase coverage by 0.11%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   91.04%   91.16%   +0.11%
==========================================
  Files          30       30
  Lines        2324     2331       +7
==========================================
+ Hits         2116     2125       +9
+ Misses        208      206       -2

Impacted Files
Coverage Δ

scvi/inference/annotation.py
91.09% <100%> (+0.09%)
:arrow_up:

scvi/inference/posterior.py
94% <80%> (-0.16%)
:arrow_down:

scvi/inference/trainer.py
88.47% <0%> (+1.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05237c...0516804. Read the comment docs.

Looks good to me. Thanks David!
@romain-lopez Should we merge this PR?

Looks good to me too, thanks David!


Use --no-install-recommends when installing apt packages.

Summary

This PR adds --no-install-recommends to the apt install arguments. We observe that this reduces the size of the image with no loss in functionality. This experience is echoed in the official ubuntu blog.
We do not add this argument to the Dockerfile for the run image, as it uses dpkg directly rather than apt.
‼ Important ‼
Merging this PR will probably result in some packages being removed, which means that the automation to create a release will fail. We should have a plan to support removing packages - either as a one-off, or as an ongoing automation option - before merging this PR!
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Blocking on the automation supporting package removal

@robdimsdale should we take this into account for the base stack immediately?
cc @phil9909

@loewenstein if you mean the change itself (using --no-install-recommends) then @phil9909 already made that change.
If you mean the automation change to support removing packages - i don't think it'll be a problem as we haven't shipped a base stack yet, so we won't be removing packages relative to an existing release.


jobcode: uppercase/lowercase

It may be inconvenient for users if uppercase and lowercase is differentiated. If a company has swe2024 as a jobcode, it's very unlikely that SWE2024 is another jobcode

Jobcode will be saved as all capital (just like name)


Add macOS support

I'm about to sign up for adapty or revenue cat in a day or too.  But I need macOS.

Hi, @sgehrman! Thank you for bringing up this issue. Currently, we do not support macOS, and there haven't been any plans to do so. However, I will conduct some research, and perhaps we will consider adding support for it in the near future.

@x401om can we at least use the API to check wheather there's any active subscription for user/customer-id?


Suggestion: Ability to bind to the View Model object, not a property of it.

Occasionally you need to specify a bind expression that references the entirety of the view-model itself, and not one of its properties.
At present you need to workaround by either having a "self" kind of property and referring to that (initialised in the View Model constructor), or doing a similar thing with view-model.ref.
Be nice to simply have a well defined name like $this or $self or $viewmodel to take care of this binding circumstance.

This week's release has the ability to bind to $this!


feat: add commands to run tests depending on changed files

Don't know how to write tests for this :S
Maybe by mocking exec? But all it does is call it, so what would be the point 🤔


feat: replace dashboard scatterplot chart with repositories table

Description
This PR replaces the dashboard scatterplot chart in the tools page to repo table and removes the repositories tab from the tab list

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
closes #1813

Mobile & Desktop Screenshots/Recordings
Before

After

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@OgDev-01  @bdougie 100% for this PR let's add an Activity tab and move the contribution chart there so we start adding more insights to this new tab in future releases.
I'll open a new Issue for this, but we can port some of the charts from the list feature, like the most active contributors chart, and integrate some of the info we get on the pizza-cli.

@OgDev-01 @bdougie 100% for this PR let's add an Activity tab and move the contribution chart there so we start adding more insights to this new tab in future releases.

Ok... i'll make a new activity tab to house the chart and add other charts in a seperate PR

@bdougie  and @isabensusan, here we have it ✨


[PF-666] Add common exceptions to the common lib.

Mostly copied from the WSM common exception directory, with a few comments cleaned up.

That is fair. Will - when you say non-ErrorReport, do you mean those that don't derive directly from ErrorReport? Most of them derive from something that derives from ErrorReport. I do not have great context on these, was mostly just going off the common directory. Given this comment, I think I will revert InconsistentFieldsException. MDCHandlingException, and StairwayInitializationException. The others added seem more clearly common - MissingRequiredFieldException, NotImplementedException, SerializationException, ValidationException.
Thoughts before I go do that?

That is fair. Will - when you say non-ErrorReport, do you mean those that don't derive directly from ErrorReport? Most of them derive from something that derives from ErrorReport. I do not have great context on these, was mostly just going off the common directory. Given this comment, I think I will revert InconsistentFieldsException. MDCHandlingException, and StairwayInitializationException. The others added seem more clearly common - MissingRequiredFieldException, NotImplementedException, SerializationException, ValidationException.
Thoughts before I go do that?

Reverting MDCHandlingException and StairwayInitializationException seem good to me.
I think InconsistentFieldsException is fairly analogous to MissingRequiredFieldException. (the fields are conflicting in a way that means the request is bad, but the fields aren't "missing" per se.) So that probably comes along.

SGTM. Confident enough in that assessment for me to put it in a comment? :)

SGTM. Confident enough in that assessment for me to put it in a comment? :)
Sure.

Some of the non-ErrorReportException exceptions don't seem especially common, or particularly important to make common.
I think it'd be fine to leave them out and keep having exceptions defined in WM for its particular usage.
Unlike Dan, I think the time to add documentation is now :) If we can't explain the exception's use well, maybe a good signal to not include it.

I cannot disagree with that: If we don't know what it means, we shouldn't put it in common


Missing link / steps for Monitoring Metadata Operations

The last sentence under the Performance Checklist states:
API operation distribution: Is the workload metadata heavy with file open/close operations? This is common for workloads that are performing read operations against a large volume of files. See Monitoring metadata operations.
There is no link to "monitoring metadata operations". There is no section in this article named that.
This seems like an error that should be corrected.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40633bba-3831-8635-2526-64fbd93817f2
Version Independent ID: 34f6f4ce-c86b-906e-d031-419a7ea20d96
Content: Understand Azure Files performance
Content Source: articles/storage/files/understand-performance.md
Service: storage
Sub-service: files
GitHub Login: @khdownie
Microsoft Alias: kendownie

@Xoere
Thanks for your feedback! We will investigate and update as appropriate.

I'll take care of this today. Thanks for reporting it.

I added the appropriate text and link
#please-close


Update DSN 2024

Which conference does this PR update?

DSN 2024

Related URL

https://dsn2024uq.github.io/dates.html

@ViGeng Fixed.


Add JS tests for sharing button

Adds tests for the sharing button JS.
Part of https://www.pivotaltracker.com/story/show/177597156. This should complete the 'test the JavaScript works' task because we are not testing GOVUK Frontend code.
To run these tests only, use this command:
npx jest --config tests/javascripts/jest.config.js tests/javascripts/sharing-button.test.js
This pull request also includes:

adding checks for copy-to-clipboard support instead of assuming it exists if the Web Share API doesn't
updates the RegExp used to trim the URL string to use the String.prototype.trim polyfill from MDN

Thanks for looking at my comments @tombye!
I think this is good to go, if you'd like to merge it now.


template sensor has no entity

Hi,
As indicated in issue #1054, there is no entity for a template sensor.
Can you investigate ?
Regards.

tag @pavoni

What problem are you having? Looking at the code - I did create an entity.
Also just tried and groups work ok for me.
group:
    sensor_templates:
        - sensor.sun_angle
        - sensor.sun_angle_2
        - sensor.sun_angle_3
        - sensor.sun_angle_4

sensor:
    - platform: template
      sensors:
          solar_angle:
            value_template: '{{ "%+.1f"|format(states.sun.sun.attributes.elevation) }}'
            friendly_name: 'Sun Angle'
            unit_of_measurement: '°'
          solar_angle2:
            value_template: '{{ "%+.1f"|format(states.sun.sun.attributes.elevation) }}'
            friendly_name: 'Sun Angle'
            unit_of_measurement: '°'
          solar_angle3:
            value_template: '{{ "%+.1f"|format(states.sun.sun.attributes.elevation) }}'
            friendly_name: 'Sun Angle'
            unit_of_measurement: '°'
          solar_angle4:
            value_template: '{{ "%+.1f"|format(states.sun.sun.attributes.elevation) }}'
            friendly_name: 'Sun Angle'
            unit_of_measurement: '°'

Ok,
Now it works with this configuration :
sensor:

platform: template
sensors:
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_2:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_2")|float - 0.4)|round(1)}}'
friendly_name: 'Salon'
unit_of_measurement: '°C'
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_3:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_3")|float - 0.4)|round(1)}}'
friendly_name: 'Chambre Matteo'
unit_of_measurement: '°C'
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_4:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_4")|float - 0.4)|round(1)}}'
friendly_name: 'Chambre Parents'
unit_of_measurement: '°C'
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_5:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_5")|float - 0.4)|round(1)}}'
friendly_name: 'Bureau'
unit_of_measurement: '°C'
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_6:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_6")|float - 0.4)|round(1)}}'
friendly_name: 'Cave'
unit_of_measurement: '°C'
fibaro_system_fgsd002_smoke_sensor_temperature_with_offset_7:
value_template: '{{(states("sensor.fibaro_system_fgsd002_smoke_sensor_temperature_7")|float - 0.4)|round(1)}}'
friendly_name: 'Dressing'
unit_of_measurement: '°C'

group:
Températures:
- sensor.salon
- sensor.chambre_parents
- sensor.chambre_matteo
- sensor.bureau
- sensor.cave
- sensor.dressing
Entity takes the friendly_name attributes as name. Normal ?

@balloob I think there is a bug in my code. The sensor is taking it's name from the friendly name - rather than the config device. My 'demo' above should have solar_anglex as the entity name (I think).

+1

@pavoni you are correct.
You should hold on to the key in the hash that held the config of the sensor, make sure it is valid for an entity id and set entity id on your sensor manually. See this example
Since you are implementing a platform, you should make sure that the entity id is not being used by other platforms, like this

Thanks for spotting @BornTKill


Updating windows installer for 0.17

Summary

Use the KA Lite static .whl file.
Update the Python version from 2.7.9 to 2.7.11.
Set KALITE_PYTHON environment variable after the installation.

Issues encountered.
Having multiprocessing issue when using the python version 2.7.10

Issues addressed
Fixes #424

Hi @radinamatic can you test this windows installer for 0.17 release? I built it in my local for now because the build server is still down. Here's the installer.

/cc @cpauya @benjaoming

Downloading!
I'll try it on Windows 7, unless you have other preferences...?  @mrpau-richard

@mrpau-richard Your installer worked perfectly on W7, no errors or issues whatsoever during the installation, nor in major functions.
All caveats regarding the contentpacks still the same as for the deb installer I tested yesterday.

@mrpau-richard great work! Does it mean we have to add Python 2.7.11 as a requirement for Windows environments? We could add it as a release note with an instruction on how to find your python version...

@benjaoming Yeah, We need to add it in the release notes.

@mrpau-richard I managed to identify the upstream Python issue, it's true that multiprocessing is broken in < 2.7.11
https://bugs.python.org/issue10128

Allow me to rant :)
Python 2.7.11 is only 11 months old.
For starters, if someone is already deploying a new version of KA Lite, they should also have access to an updated version of Python. It's within reach of anyone installing KA Lite on Windows to also install Python.
Requiring users to run a newer version of Python also shouldn't do harm, but could come with other benefits as lots of bugs are fixed in each of the 2.7 patch releases.
We may be making our own work much more difficult if we decide to allow users to stay with old versions of Python. Supporting old OS'es is one thing that's already quite a load :)
So in that sense, I would say that we should stick to the changes you've made.. keep on building the Windows installer with wheels and instead require users to read the release notes, where we'll mention that Windows requires a Python update.

@mrpau-richard - why not bundle Python 2.7.12 since it's the latest release?

I haven't tested it within python 2.7.12. I will test it tomorrow if I have no issue encountered then we will use it.

Hi @benjaoming & @radinamatic we are now using the python version 2.7.12 in KA Lite windows installer. Here's the installer for testing.

@mrpau-richard Tested the installer on Windows XP this morning, and everything seems a-OK! 👍
One thing I would suggest is to rephrase the wording, since it seems to imply that the Python installation is somehow optional, and not compulsory - users cannot simply skip installation of Python and expect KA Lite to work:

Suggested text for the above alert:
KA Lite requires Python to be installed on your system.
This wizard will proceed to install Python 2.7.12, and then continue with KA Lite installation.

The proper buttons should be Continue and Cancel, and if Cancel is selected, there should be another alert with the following:
Are you sure you want to cancel the installation of Python 2.7.12?
If you select "Yes", this installer will close and KA Lite will not be installed on your system.

Hi @radinamatic done fixing the text for the alert box. Here's the installer

@mrpau-richard Text looks OK, thanks! Two new issues however:
Issue 1:
When user decides not to install Python/KA Lite, and chooses Yes here:

then this Runtime error appears on XP:

Same on Windows 7:

Issue 2:
If the user selects No on the alert step/screenshot above, I think the installer should go back to the previous logical step, namely this one, and wait for the user to select OK:

Instead, the process remains running in the back and eventually starts the Python installer without the user's explicit acceptance.

Hi @radinamatic I fix the issue you commented above. Here's the installer for another testing.

@mrpau-richard Awesome, no more runtime errors! 👍
I'll give it another cursory glance, and see if I can debug the contentpacks a bit more!

Hi @radina Can you do a final testing on KA Lite windows installer for 0.17? To merge this PR.
You can download the latest installer at the dungeon server.
I already tested it, on these operating systems Windows 7 32 bit and Windows 8.1 64 bit.

@mrpau-richard Tested the build 59 on both W7 & W8.1 64bits and  as far as the fixes in this PR are concerned, merge away! 👍

Hi @benjaoming can you take a look on this PR it seems it is ready for merging.

Skimmed through the code, still looks good, thanks for the tip @mrpau-eduard :)


How to deal with ETIMEDOUT error and pending forever?

Hello,
Thanks for the nice robust crawler. But I got ETIMEDOUT error sometimes. Besides, some http request may stay in pending state and the request died after 5 minutes.
Thanks
fanzijian

Please refer to my modification over js-crawler from https://github.com/tibetty/ya-js-crawler/blob/master/crawler.js, line#406 & line#450

Thanks @tibetty We may need to include the modifications from  https://github.com/tibetty/ya-js-crawler/blob/master/crawler.js into the default branch of https://github.com/antivanov/js-crawler/ and then we can publish them to NPM. I will take a look

And thanks to @fanzijian for reporting the issue. Will try to get the fix published soon

@antivanov I had customized it too much to fit into my own purpose.  I will try to figure out some useful but not so disruptive features and integrate into this project.

Thanks @tibetty, please create a pull request if there is time and some changes to contribute to the default branch of the project


How to change the depth of the UNet

The default depth of the UNet is 5, which is too deep for images with low resolution.
My question is how can I change the depth of the UNet? I have tried the n_upsample_blocks parameter, it did not work.
Thanks!

I also want to know.

How low is low resolution? It looks like you'd need to adjust n_upsample_blocks manually in the unet.py script as it is hardcoded. Then you'd need to adjust decoder_filters accordingly.
Why is it set to 5 in the first place?

Did anyone get a unet with depth of 4 to work?


added example and docs to describe operator deployment

What is this PR About?
as $subject
cc: @redhat-cop/rego-policies

/approve

/lgtm


Fix RCS1102: Make class static

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1102.md
Follow-up to #13897.

WIP until #13897 is merged.

@iSazonov Could you please review?

@xtqqczze Can you add more information why we need this? What are the benefits we get?
This looks like a formal cosmetic change.

Closed in favour of #14483.


Models from mapped repo instance are not reactive under certain conditions

Environment
Pinia ORM 1.5.1 in the playground
Reproduction
https://pinia-orm-play.codedredd.de/#N4IgDghgxg1hDmBTAziAXAbVAOwgW0XRADcBXRAWgBNE8BLEAGhGQHtSAnKQtEU7MDHhMQNZFA50wAFzqtsRAGrkABABFadFQAoAFhAA2AMxV1sKgGIdE2KLoCUp5CogqaxRAdZgz8FaVkDOmkATxcDLwB3ZxD2FWlWFUjJaUQVAFVsOg8OZEMVZTSAGToAIw4ISRQVI1YOAtUAJhUAMhUAZhFOAyJdaWkwZDQAemH+QXgAOihWPGGyShp6YaDS4bMaAA9JvAArVABfRhx8HhAAAQXSZERh5H1rKhE2Tm4icaERMQkpWXkiADKD0QVAaiHSN38gWCdBQky6HB6vD6AyGow+Uxmc0u5Gut3ulRB5wArJMAAyTACM62wW0mKDwk32ICOJwIRBxiDxwxm1me7C4ZwxXxQPxkcgUvAAwqwIogoH9zKwTCgbthZPlCioZXgwKxkDD5BlobIUAikSAUYMRmMBEJprNhpzubzECTyVSaXSGUzDscQLh2bxOcN3AlZcgKBAfPzXkK7cJmN9JOL-rwAJLqxAVBVJYK6eK6NJasOsCM1DizQtpSBIc29frW9EJh3YhahxDEcMGSPRujnABsk0antWwwZXsQ22ZrIDpyIPiyEFjgveCZF4hTiqIAAUzHRl8xug3UTaMa3houD+cRxTGgBOUN0ZDSS-7iD05B4CjlVjRbO+iy-qBmc5xXhAFB1HM2BQYYdAAF4cCuby8MKSailuEq7u+KgAPIAEoALIqDBHB4HBiH1sijZoraEwXmB76QWRwykeRQSIeclJUuST4vpO2x7H6bJnLgMF0FQrHyBQNxQJwhDMC8q6oeu6Gbr8WG8AAchA4lPEeiInk2dH2lirG6awEnnAALB6ZJSdgMnyvJAmAbOIELkxUHIfGEwbmK268HuS54URVGWjRZ4tmZ4HMXgXGTKS1JUM+r4bFOOwzgAuswRh0AYZpoKAACCYBgJMCzoKAqS6gYECpEQAA8KXEAAOuYKjwJIVAALytSAAB+NRRBQMwGJ10YUNZ-XtSoKhgHV3B9SAMxZuqo02Kk9TBLQkbcFmHAzR1ujLZuiA2Edc21Oqy14PIrCXSoAB8s0qM12QqFAdXIMgt1mBQkQUBg7RkmSYCbFl-UvR1c2NaQBjQ3NSNvUET14vUIEVlW5FlSCKjWHqTgkaw0j+GAVD1b4aAqMAwD+DcHDcXluTSDpBAqAcBw03T6Pcd9rOnBzByNSsdCI8jKNi+jJGC0YlZ4CRiCRAYYQSIg9V4wTiTPmTFOyNg8DU7T9PZiOzMvmzaSc9zJscCO-OW0LIuo69sNjAjr0iy10Ne9kT3PAFRB0LqdSk3TWJgAEeNc3LVYAOQLHH7XB3qHBhyb+GIHqjAqDjmd6s4MfyyocexVBSdZCHacZAzWMK3HkzDBCAH7BXKeh249WuLH9eN3rH6t+17WrS+tv54kPW59G4-INowDo+P1PNxwBz2JMC9Z6w2j2O1G96pMeQeNo-frwzyA79gw-yKPvMqJPEdR1Q2jb3fT1j5vkyREW1jaHHElxznSka9zbSG3hfEepN0bNHvrMSOqQn4vx6m-PE49tDLzXl-bMiBf7-0AcAugLMwFD2wDcaQAAVYOiB2CgMQdDYAr1RiFh1nYXSSAib6FxlkA2phzAWWkN-FQCxPqwPkJtV6edN6z3ngzReNdsyr1PtmVBa9D7YOABJamlIc4O1ONTOOpByYayoHHVe7UjgqGJKDMkF92qkIoQQahz9HBIPavQjqjD+HMP0AbNIHCwA2F8CoI0rgogqAKh4capQwjRgWiEQJ-C0jQEVK9CBts76d2kB+dGyAMBkkhh1dGkwdHs0nvowx8CVCNArnNCRBc5571YEvBmCiGnb0mOBAECQf4qIgEfYAlJqbo1MdgcxlIrHWPakBUQXdAJFRADVBaGsiABy3EQKcqdSY0CMBAeGYdXrZOphgV2NNjlzQ0SoLRpyZYED0QAKVYLobAABpABVzeldw4OmPA8B0iIj0VaWidB2kVGIB86YUBhggzJAAfmDvAHqxIADsryYZIxAZbO5DzsAoolmEiAFtdElxeYwY5RxjluNxecxoJLUVzRAnc3SiA1A4olu8zJnzvm-IMP8yKowgVgBBWCqAEKoWwu+T1ayxIWXI3RYSuOtzGXSqRsUxAei1CsEQEqg4r18kHCmcvWZ1VaCLIarwFZvwg5V3ToRVgNBxpF3jmXMiFd2rrI7lsnZBhSZfXxc4ZeKgpypFpM4G1dqTkdRfJTKAAb1TBDCKU7JLqI2ZNkNGvKngqCz0cBSpG1hpCcHMDm5G5zPHIHXhJbeNLcX0qYWWl8kgDa-zjvYKtrLQXsq+T8v5taD7SAbfAJtLarmypuT2+tvhB2tuRiq6mpbe39sHaS162qRksk5kAA
Describe the bug
(1) We have a component with a mapped repo instance and a model queried with that instance in a computed variable (user1 in the example).
(2) We have another component or part off the app with its own repo instance (first timeout in the example).
(3) We update data with this other instance.
(4) The data change is not reflected in user1.
For me, that use case is perfectly possible: I can change data from everywhere in the app and this data change should be reflected in every model. The same goes for the low level actions of the store, see second timeout.
I have found a workaround by using the useRepo method in the computed function (see user2) . But I want to be able to use the mapRepos helper.
Additional context
I assume the problem comes from the hydratedDataCache of the repo - every instance creates a new cache. Shouldn't the cache be shared between repo instances of the same model?
Logs
No response

@CodeDredd I just wanted to illustrate the problem. I use the options API in my real applications and have the same problems.
If you would ask me the shared cache should be managed / updated in your low level action methods of the store.

@benwick hmmm... i don't know yet if this is a good idea. Because then i have to pass the hydrated model to the actions or using revive to update the hydrstion cache. But if i use revive, u would hydrate the same data twice if not the action is used directly which would impact on performance.

Also there is the thing with the hooks. Right now there are not triggered on the low level actions. So this would be also needed to change.

@CodeDredd It was just an idea. I  have only a superficial view of your  code. I have an app, where the store is shared between websockets. This sharing is done with store actions, because these are "replayable".  But when a model is not updated after direct action calls that too can be problematic.

@benwick dont get me wrong. I appreciate your input a lot 😉. I still don't know yet how to proceed with this.
The shared cache is pretty clear. But the rest I have no idea yet. Going to think about it.
Anyway thanks a lot for this.

Also there is the thing with the hooks. Right now there are not triggered on the low level actions. So this would be also needed to change.

Mh, just my 2 cents: I don't see a reason why low level actions should trigger hooks. They should change state and this changed state should be picked up by all repos and models.

Mh, just my 2 cents: I don't see a reason why low level actions should trigger hooks. They should change state and this changed state should be picked up by all repos and models.

I think you are right....i am thinking right now that both is valid. Using repo actions or store action. Both triggering an update of cache & hooks. I am thinking just loud.
The one thing which is clear is, taht the first thing is always making a model out the new data so the magic of the model is used. I either create a new one or one from the cache. After that it lands to the store.
So the only solution i see is enhancing the actions...

I've started #1066 to handle all what we discuessed here. @benwick If you got time you can look at the PR and tell me you thoughts.

I have looked over your changes - but I have to admit I am more puzzled than before. But that stems from my very superficial knowledge of the code and typescript in general. So this new function SharedHydratedDataCache will always return a new map? Surely not - but it is not obvious to me, how it will generate one map per model. Is this achieved through the typings?
One other (general) thing I don't understand: Why is the database always created anew when a repo is contructed? Shouldn't the database be a singleton once created?

@benwick
The shared hydration cache is now shared between repositories. Before it was more like one hydration cache each repo instance.
So far that i understood it, the database is always created to new to reflect the needed models for the query. Honostly i don't know what impact it has if the databases are registered completly for every repo only once. My guess is that it will screw up the queries with their relations if the database isn't regesitered always new.
The database isn't the same like in the backend.


Add Sqlite to basic-cli

This is basically a direct port of what was in basic-webserver. Just converted to purity inference and separated into it's own crate. The example will not work correctly until https://github.com/roc-lang/roc/pull/7427 lands in the roc repo.
I'm hoping that switching to libsqlite3-sys will fix our bundling issues. If not, we can switch back to the linked version of sqlite3-sys. They both have 100% compatible apis.

I think this is good to merge!

I'd like to builds this on arm64 linux before we merge this

I caught up on the zulip conversation and the successful test :+1:


Added support for non-AWS hosted domains

Like your SES provider!
But, I try to get this working for domain names that are not hosted by AWS. For that I made the following proposal, what do you think?

Hi Mark,
Thank you for the feedback!
This PR supports domain names that are not hosted by AWS (Route53). Instead of a reference to the HostedZoneId you specify the DomainName directly and no DKIM records are created in Route53. The DKIM records will then only be generated and then have to be entered manually at your own DNS provider.
It seemed more logical to look at SES from the Domain perspective rather than from the 'DKIM' perspective. Hence the changes to the resource name. However, this (Custom::DKIM) still works because it simply falls into the else of the ResourceType condition in src/ses.py. However, I have not fully tested the Custom::DKIM.
Lastly, support for identity policies have been added, so that you can add policies in SES that enable cross-account mailing.
  SesDomain:
    Type: Custom::Domain
    Properties:
      DomainName: foobar.nl
      DKIM: True
      ServiceToken: !Sub 'arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:cfn-ses-provider'
  SesPolicy:
    Type: Custom::IdentityPolicy
    Properties:
      Identity: !Ref SesDomain
      PolicyName: cross-account-allow
      PolicyDocument:
        Version: '2012-10-17'
        Statement:
          - Effect: Allow
            Principal:
              AWS:
                - 'arn:aws:iam::1234:root'
                - 'arn:aws:iam::4321:root'
            Action:
              - ses:SendEmail
              - ses:SendRawEmail
            Resource: !Sub 'arn:aws:ses:${AWS::Region}:${AWS::AccountId}:identity/${SesDomain}'
      ServiceToken: !Sub 'arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:cfn-ses-provider'

Hi @basschipper, my apologies for not merging your changes more than 1 year ago, Since v0.6.4 I have modified the provider to deprecate the Custom::DKIM  in favor of the Custom::DomainIdentity.
the original DKIM resource was one of the first I ever created and it violates the principle of CloudFormation that a custom::resource should manage exactly one  resource.  It becomes brittle when a custom resource manages multiple resources as Custom::DKIM did.
Anyway, thank you for using the provider and putting in the work for this PR.
Cheers,
Mark


sqlalchemy fails to initialize with KeyError "EmbeddingStore"

Why do I care about this issue?
MLflow also uses sqlalchemy to handle sqlite-based storage, and calls sqlalchemy.orm.configure_mappers() during initialization. With langchain>=0.0.228, MLflow fails to start. All MLflow users who choose sqlite-based storage cannot use it with langchain.
System Info
langchain>=0.0.228
Who can help?
@hwchase17
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Executing the following command fails with langchain >= 0.0.228, and no error occurs for langchain <= 0.0.227:
import langchain
import sqlalchemy
sqlalchemy.orm.configure_mappers()

Error:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/clsregistry.py:515, in _class_resolver._resolve_name(self)
    514 if rval is None:
--> 515     rval = d[token]
    516 else:

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/util/_collections.py:346, in PopulateDict.__missing__(self, key)
    345 def __missing__(self, key: Any) -> Any:
--> 346     self[key] = val = self.creator(key)
    347     return val

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/clsregistry.py:483, in _class_resolver._access_cls(self, key)
    481             return value
--> 483 return self.fallback[key]

KeyError: 'EmbeddingStore'

The above exception was the direct cause of the following exception:

InvalidRequestError                       Traceback (most recent call last)
Cell In[3], line 1
----> 1 sqlalchemy.orm.configure_mappers()

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/mapper.py:4167, in configure_mappers()
   4099 def configure_mappers():
   4100     """Initialize the inter-mapper relationships of all mappers that
   4101     have been constructed thus far across all :class:`_orm.registry`
   4102     collections.
   (...)
   4164
   4165     """
-> 4167     _configure_registries(_all_registries(), cascade=True)

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/mapper.py:4198, in _configure_registries(registries, cascade)
   4192     Mapper.dispatch._for_class(Mapper).before_configured()  # type: ignore # noqa: E501
   4193     # initialize properties on all mappers
   4194     # note that _mapper_registry is unordered, which
   4195     # may randomly conceal/reveal issues related to
   4196     # the order of mapper compilation
-> 4198     _do_configure_registries(registries, cascade)
   4199 finally:
   4200     _already_compiling = False

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/mapper.py:4239, in _do_configure_registries(registries, cascade)
   4237 if not mapper.configured:
   4238     try:
-> 4239         mapper._post_configure_properties()
   4240         mapper._expire_memoizations()
   4241         mapper.dispatch.mapper_configured(mapper, mapper.class_)

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/mapper.py:2403, in Mapper._post_configure_properties(self)
   2400 self._log("initialize prop %s", key)
   2402 if prop.parent is self and not prop._configure_started:
-> 2403     prop.init()
   2405 if prop._configure_finished:
   2406     prop.post_instrument_class(self)

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/interfaces.py:578, in MapperProperty.init(self)
    571 """Called after all mappers are created to assemble
    572 relationships between mappers and perform other post-mapper-creation
    573 initialization steps.
    574
    575
    576 """
    577 self._configure_started = True
--> 578 self.do_init()
    579 self._configure_finished = True

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/relationships.py:1632, in RelationshipProperty.do_init(self)
   1630 self._check_conflicts()
   1631 self._process_dependent_arguments()
-> 1632 self._setup_entity()
   1633 self._setup_registry_dependencies()
   1634 self._setup_join_conditions()

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/relationships.py:1849, in RelationshipProperty._setup_entity(self, _RelationshipProperty__argument)
   1842 resolved_argument: _ExternalEntityType[Any]
   1844 if isinstance(argument, str):
   1845     # we might want to cleanup clsregistry API to make this
   1846     # more straightforward
   1847     resolved_argument = cast(
   1848         "_ExternalEntityType[Any]",
-> 1849         self._clsregistry_resolve_name(argument)(),
   1850     )
   1851 elif callable(argument) and not isinstance(
   1852     argument, (type, mapperlib.Mapper)
   1853 ):
   1854     resolved_argument = argument()

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/clsregistry.py:519, in _class_resolver._resolve_name(self)
    517             rval = getattr(rval, token)
    518 except KeyError as err:
--> 519     self._raise_for_name(name, err)
    520 except NameError as n:
    521     self._raise_for_name(n.args[0], n)

File ~/miniconda3/envs/mlflow-dev-env/lib/python3.8/site-packages/sqlalchemy/orm/clsregistry.py:500, in _class_resolver._raise_for_name(self, name, err)
    490     raise exc.InvalidRequestError(
    491         f"When initializing mapper {self.prop.parent}, "
    492         f'expression "relationship({self.arg!r})" seems to be '
   (...)
    497         f"['{clsarg}']] = relationship()\""
    498     ) from err
    499 else:
--> 500     raise exc.InvalidRequestError(
    501         "When initializing mapper %s, expression %r failed to "
    502         "locate a name (%r). If this is a class name, consider "
    503         "adding this relationship() to the %r class after "
    504         "both dependent classes have been defined."
    505         % (self.prop.parent, self.arg, name, self.cls)
    506     ) from err

InvalidRequestError: When initializing mapper Mapper[CollectionStore(langchain_pg_collection)], expression 'EmbeddingStore' failed to locate a name ('EmbeddingStore'). If this is a class name, consider adding this relationship() to the <class 'langchain.vectorstores.pgvector.CollectionStore'> class after both dependent classes have been defined.

It's likely to be introduced by this PR https://github.com/hwchase17/langchain/pull/7370.
Expected behavior
No error should occur.

should be resolved by #7580, let us know if you still see it @liangz1!


Support pivot-view mode setting for Graph widgets

Now all graph widgets are shown as graph, even in table mode.
Here is the reproduced example.
DSZ:

DSW:

done in 3.1.46

Works


Display project ID and module version during cloud debug session

The user should be able to identify which project and version they are 'connected' to during a debug session.

Good idea. Where should we display this information? Maybe we can add a JLabel to the title bar of the debugger tab since we've removed almost everything else that used ton live there.

SGTM.
On Mon, Dec 7, 2015 at 5:04 PM, Elliotte Rusty Harold <
<EMAIL_ADDRESS>wrote:

Good idea. Where should we display this information? Maybe we can add a
JLabel to the title bar of the debugger tab since we've removed almost
everything else that used ton live there.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/234#issuecomment-162680269
.

decided to limit IDEA to running a single CDB session at a time, which makes this low priority.
If we do pick it up, it would be nice to figure out how to add this to the tab title for the run/debug configuration tab.


Routing/Redirection should be changes on Dashboard

Show Dashboard\AllPosts when accessed to Dashboard\Index
Show Dashboard\AllPosts after a post is created
Show Dashboard\AllPosts after a post is deleted

This is fixed by https://github.com/ymita/Lifelog/commit/f3979b380972651a26100a83b73f20db97074fc2.


As a player I want to see my wares and the cities' wares

[ ] show my wares
[ ] show cities' wares

duplicate of #22


Bot did not post a new iteration for addressbook-level4#173

I clicked the 'Submit New Iteration' in @CanIHasReview for https://github.com/se-edu/addressbook-level4/pull/273, but it did not post anything on my PR. Tried it a couple of times.
Works on my other PRs though.

@yamgent Thanks for the report. Interdiff generation is failing for some reason.
Relevant logs:
From https://github.com/se-edu/addressbook-level4
Note: checking out '941d0afebe52dc6bd86b60bd4a11861f48273900'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may

do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 941d0af... [#230] checkstyle: ensure consistent ordering of imports (#257)
[detached HEAD 2c8e8e6] Make DuplicatePersonException public
 Author: Tan Wang Leng<EMAIL_ADDRESS> 1 file changed, 1 insertion(+), 1 deletion(-)
[detached HEAD 45cc33a] Add unit test for AddCommand
 Author: Tan Wang Leng<EMAIL_ADDRESS> 1 file changed, 170 insertions(+)
error: could not apply 81b357c... Remove integrated test for AddCommand
 create mode 100644 src/test/java/seedu/address/logic/commands/AddCommandTest.java
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Error: Command failed: git cherry-pick -X theirs 9321a79e2fc882fbfce56d31d2f8df32f11bd16c..81b357c9e6b04949f9f395c8529982e4905f7189
    at ChildProcess.<anonymous> (/app/lib/shell.js:52:16)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:192:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

I guess a hotfix would be to just continue on if interdiff generation fails, although I won't get bug reports if that happens though :-P

@yamgent Alright, I just pushed a fix. Hopefully it works now.


Bug/782 ux error handling

Closes #782

We shouldn't be putting error handling into the Authorization service. That is a mixing of concerns.

Removed error handling from the authorization service and into it's own.
Fixes #782

This is so out of date, I'm just going to close it.


Updates planner roster docs response. Closes #5910

Updates planner roster docs response by updating the roster ID as GUID. Closes #5910

Thank you @nanddeepn! We'll try to have a look at it ASAP!

Merged manually, thank you for this fix!


[DO NOT MERGE] Automatically log users in based on environment

If REMOTE_USER is set in the environment, django will trust it and
login the account with that userid (creating it if necessary).

👍


Added Yandex S3 output

Signed-off-by: Narek Tatevosyan<EMAIL_ADDRESS>
What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:
Which issue(s) this PR fixes:
https://github.com/falcosecurity/falcosidekick/issues/258   ( First part - also has plans to add Yandex Cloud Logging)

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nar3k
To complete the pull request process, please assign fjogeleit after the PR has been reviewed.
You can assign the PR to them by writing /assign @fjogeleit in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nar3k: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/kind feature

/area outputs

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

6aeccbd Update yandex.go

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

6aeccbd Update yandex.go

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add check imports workflow

This will ensure that there is not wrong or extra unused imports in your code.

Hey, thanks for the contribution, but I don't like an extra dependency for such task. I'd rather just check this with Laravel Pint...


PipelineSummary title doesn't display description when on error

The title display needs to be changed so it doesn't display "Error - " when no error is available.

In above example/screenshot there is actually another issue which is also visible in the VMStatusTable showing the step details. In this case, the first step is still running (blue half full circle icon) while the second and last step is shown as terminated (full circle icon) and on error (red). This is because current data provided from the backend has missing data.
Finding the current (active) step (findCurrentStep) is based on looking at each step to find if has started but not finished.
In this case the first step as no start or completed field while the second step does.

I think once the backend is fixed the case of an incomplete step before a complete one would never appear and the current logic works.


fix invalid type 🐞

Why
commit message is "", it's panic。

Thank you, I'll take a look tonight!


Updating properties should support LATEST and RELEASE values

versions-maven-plugin:1.3
The following gives a clear intent, which is to set LATEST which is a valid dependency version.
mvn versions:update-property -Dproperty=api -DnewValue=[LATEST]

Currently does not work
[DEBUG] Property ${api}: Set of valid available versions is [5, 6, 7, 8, 10, 11, 14, 15, 17, 18, 19, 22, 23, 24, 25, 28, 29, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125]
[DEBUG] Property ${api}: Restricting results to [LATEST,LATEST]
[DEBUG] Property ${api}: Current winner is: null
[DEBUG] Property ${api}: Searching reactor for a valid version...
[DEBUG] Property ${api}: Set of valid available versions from the reactor is []
[INFO] Property ${api}: Leaving unchanged as 125

Are you aware that Maven discourages  the use of these metaversions?

You're welcome, @khmarbaise ;-)

But the PR associated with this enables a project to have reproducible builds whilst using LATEST/RELEASE. Crux of it is the following:
      <plugin>
        <artifactId>maven-release-plugin</artifactId>
        <configuration>
          <preparationGoals>versions:update-property@lock-bom</preparationGoals>
          <completionGoals>versions:update-property@unlock-bom</completionGoals>
        </configuration>
`
which updates a property in the leaf pom making it concrete for the release (just the same as is done automatically for `<version>`) then reverting it back to [LATEST].


windows_downdate.py can't be download, copied or executed on any Windows device at all

Now I tried to get around the issue of Windows Defender potentially recognizing the python installer included in .exe binary you provided by downloading the source code "windows_downdate.py" individually to run it within a legitimate Windows python runtime: https://www.python.org/downloads/release/python-3125/ (which installs just fine, btw)
Result: I am utterly unable to download or copy the file "windows_downdate.py" to ANY Windows device I tried.
Defender (even the free version) blocks any access to or any attempt to download it.
If you want folks to test your hack, you should provide other instructions on how to actually make it work.

I could not repro this -

Regardless, please see my last comment on the other issue you opened regarding static detections.
And again, If you encounter any issues with the tool's functionality, please feel free to open additional issues.


Update D:\Git\winget-pkgs\manifests\k\Kaitai\StructCompiler\0.9

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/114413&drop=dogfoodAlpha

@wingetbot run

Manual Validation failed with:

A Java JDK is not installed or can't be found.
Please go to   http://www.oracle.com/technetwork/java/javase/downloads/index.html and download a valid Java JDK and install before running kaitai-struct-compiler.
If you think this message is in error, please check your environment variables to see if "java.exe" and "javac.exe" are available via JAVA_HOME or PATH.
Press any key to continue . . .


Feat: Dark mode to scroll bar

Describe the feature
The scroll bar do not have a dark modedoes
Add ScreenShots
add when done
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I want to work on this issue please assign me this issue.


container drops disk I/O dramatically

Required information

Distribution: Ubuntu
Distribution version: Xenial

config:
 core.https_address: '[::]:8443'
 core.trust_password: true
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_stop_priority
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
- resources
- kernel_limits
- storage_api_volume_rename
- macaroon_authentication
- network_sriov
- console
- restrict_devlxd
- migration_pre_copy
- infiniband
- maas_network
- devlxd_events
- proxy
- network_dhcp_gateway
- file_get_symlink
- network_leases
- unix_device_hotplug
- storage_api_local_volume_handling
- operation_description
- clustering
- event_lifecycle
- storage_api_remote_volume_handling
- nvidia_runtime
- container_mount_propagation
- container_backup
- devlxd_images
- container_local_cross_pool_handling
- proxy_unix
- proxy_udp
- clustering_join
- proxy_tcp_udp_multi_port_handling
- network_state
- proxy_unix_dac_properties
- container_protection_delete
- unix_priv_drop
- pprof_http
- proxy_haproxy_protocol
- network_hwaddr
- proxy_nat
- network_nat_order
- container_full
- candid_authentication
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
environment:
 addresses:
 -
 - <IP_ADDRESS>:8443
 - '[fd42:78cd:fa35:157d::1]:8443'
 architectures:
 - x86_64
 - i686
 certificate: |
   -----BEGIN CERTIFICATE-----

   -----END CERTIFICATE-----
 certificate_fingerprint:
 driver: lxc
 driver_version: 3.0.2
 kernel: Linux
 kernel_architecture: x86_64
 kernel_version: 4.15.10-041510-generic
 server: lxd
 server_pid: 1599
 server_version: "3.4"
 storage: btrfs
 storage_version: "4.4"
 server_clustered: false
 server_name: nas-10-media

Issue description
I have 4x8TB BTRFS raid 5 (running  4.15.10-041510-generic kernel) private NAS system were I run a couple of containers. I´ve noticed that when one of those containers is running, the disk i/o drops to 45MB/s where its usually 350. The latest gitlab on  xenial is running in this container. Thats why I´m not quite sure if this is a lxd or a gitlab issue.
lxc info of the container:
Name: ugitlab
Remote: unix://
Architecture: x86_64
Created: 2018/07/07 21:57 UTC
Status: Running
Type: persistent
Profiles: default, proxy
Pid: 9782
Ips:
  eth0:	inet	<IP_ADDRESS>	vethPLKQQG
  eth0:	inet6	fd42:78cd:fa35:157d:216:3eff:fe41:700e	vethPLKQQG
  eth0:	inet6	fe80::216:3eff:fe41:700e	vethPLKQQG
  lo:	inet	<IP_ADDRESS>
  lo:	inet6	::1
Resources:
  Processes: 287
  CPU usage:
    CPU usage (in seconds): 246
  Memory usage:
    Memory (current): 2.17GB
    Memory (peak): 2.20GB
    Swap (current): 16.38kB
    Swap (peak): 16.38kB
  Network usage:
    eth0:
      Bytes received: 441.13kB
      Bytes sent: 1.08MB
      Packets received: 2276
      Packets sent: 2108
    lo:
      Bytes received: 16.01MB
      Bytes sent: 16.01MB
      Packets received: 11270
      Packets sent: 11270

write speed before start of the container:
sync; dd if=/dev/zero of=tempfile bs=1M count=1024; sync
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 2.88688 s, 372 MB/s

after:
sync; dd if=/dev/zero of=tempfile bs=1M count=1024; sync
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 19.7261 s, 54.4 MB/s

Steps to reproduce
hard to reproduce. maybe isolate gitlab?
Maybe someone has a clue? Thanks

So depending on the system, it could be two things. One is that you're indeed getting a lot more I/O than before and the constant seeking is harming throughput. The other would be that the CPU use is slowing down your system enough to affect I/O.
I'd recommend running both "iotop" and "htop" on the host and see if you can spot what's the top user of CPU and I/O.
I'd be surprised if LXD was the actual cause of this, it seems more likely that Gitlab is performing a bunch of I/O activity (database would be my guess) and harming your throughput.

It turned out it was related sabnzbd and par2 killing the hdds. Closing.
Thx.

klick


Fix populate_default_values

Bug:  Set field value to null when specifying server_default_value and bool (value) == False (empty string, False or 0).
class ExampleModel(Model):
  some_field = Integer(server_default_value=sa.text('0'), default=0, nullable=False)

await ExampleModel.objects.create(some_field=0)

Awesome, thank you! 😁
Can you add a test (in test model definitions) for this case so it won't happen again?

Codecov Report

Merging #429 (b198b70) into master (2065a7d) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head b198b70 differs from pull request most recent head a720ab9. Consider uploading reports for the commit a720ab9 to get more accurate results

@@            Coverage Diff            @@
##            master      #429   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          181       181
  Lines        15032     15032
=========================================
  Hits         15032     15032

Impacted Files
Coverage Δ

ormar/models/mixins/save_mixin.py
100.00% <100.00%> (ø)

Thanks a lot! 😊


ERROR: Cannot choose between the following variants of project :ble-interface:

BUILD FAILED in 1s
ERROR: Cannot choose between the following variants of project :ble-interface:
  - debugApiElements
  - debugRuntimeElements
  - releaseApiElements
  - releaseRuntimeElements
All of them match the consumer attributes:
  - Variant 'debugApiElements':
      - Found com.android.build.api.attributes.BuildTypeAttr 'debug' but wasn't required.
      - Found com.android.build.api.attributes.VariantAttr 'debug' but wasn't required.
      - Found com.android.build.gradle.internal.dependency.AndroidTypeAttr 'Aar' but wasn't required.
      - Found org.gradle.usage 'java-api' but wasn't required.
  - Variant 'debugRuntimeElements':
      - Found com.android.build.api.attributes.BuildTypeAttr 'debug' but wasn't required.
      - Found com.android.build.api.attributes.VariantAttr 'debug' but wasn't required.
      - Found com.android.build.gradle.internal.dependency.AndroidTypeAttr 'Aar' but wasn't required.
      - Found org.gradle.usage 'java-runtime' but wasn't required.
  - Variant 'releaseApiElements':
      - Found com.android.build.api.attributes.BuildTypeAttr 'release' but wasn't required.
      - Found com.android.build.api.attributes.VariantAttr 'release' but wasn't required.
      - Found com.android.build.gradle.internal.dependency.AndroidTypeAttr 'Aar' but wasn't required.
      - Found org.gradle.usage 'java-api' but wasn't required.
  - Variant 'releaseRuntimeElements':
      - Found com.android.build.api.attributes.BuildTypeAttr 'release' but wasn't required.
      - Found com.android.build.api.attributes.VariantAttr 'release' but wasn't required.
      - Found com.android.build.gradle.internal.dependency.AndroidTypeAttr 'Aar' but wasn't required.
      - Found org.gradle.usage 'java-runtime' but wasn't required.

I have the same problem

Maybe you can try this plugin, support android gradle plugin 3.0.0-3.4.2 and gradle 4.6-5.1.1.
https://github.com/cpdroid/fat-aar


GDScript 2.0: Button signal "pressed" cannot be connected because it is seen as bool property pressed (name conflict)

Godot version:
v4.0.dev.custom_build.41e902886
hash:41e9028868e49669de83c82ba20fd9dcef0d1b8b
OS/device including version:
Windows 10
Issue description:
When I try to connect a Button's "pressed" signal, it gives an error.
Example:
$Button.pressed.connect(b_pressed)
Error:
"Invalid call. Nonexistent function 'connect' in base 'bool'"
I am fairly certain this is because buttons have signal "pressed" and also a bool "pressed"
The way connect works may have to be tweaked a bit so it doesn't look at bools/variables, but only signals.
Steps to reproduce
Load up 4.0, create root node, add a button, add a script with this:
func _ready():
    $Button.pressed.connect(b_pressed)

func b_pressed():
    print("Hello")

I can confirm this on commit f1cb475d9.
Minimal reproduction project: gdscript_connect_button.zip

I can confirm this on commit f1cb475d9.
Minimal reproduction project: gdscript_connect_button.zip

Related to #38937.

Related to #38937.

#38937 mentions this issue already and it should be solved by renaming either the property or signal, so this can be closed probably.

#38937 mentions this issue already and it should be solved by renaming either the property or signal, so this can be closed probably.


Don't fail if codecov if run from a branch

Codecov Report

Merging #3782 (e3d9fb6) into main (10bf572) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3782   +/-   ##
=======================================
  Coverage   61.80%   61.80%
=======================================
  Files         513      513
  Lines        9925     9925
  Branches     2168     2168
=======================================
  Hits         6134     6134
  Misses       3788     3788
  Partials        3        3

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10bf572...e3d9fb6. Read the comment docs.


Get-Credential Ability to Override Username

Summary of the new feature/enhancement
Back in Powershell 5, I could write a script which contained:
> $cred = Get-Credential -UserName "$first.$last"

A dialog would then appear, asking for the password, but it also gave the option of changing what the username was. This was useful as you could implement a naming standard, but when there was an edge case allowed the end user to be able to easily override it.
This workflow could be built into many scripts wanting to upgrade from Windows Powershell to Powershell 7.
Proposed technical implementation details (optional)
Reading #10625 I thought a -ConfirmUserName switch would be consistent, but a -DefaultUserName Username string would work just as well.
The below is how I saw it being used, being consistent with other command line tools
> $cred = Get-Credential -UserName "john.smith" -ConfirmUserName
> $cred = Get-Credential -DefaultUserName "john.smith"
PowerShell credential request
Enter your credentials.
User [john.smith]:

The User can just press enter without typing anything and it will use the default value.
It would be nice if the value was presented as pre-typed - as this would allow the user to manipulate the value instead of either choose the default, or write it again from scratch.

I like DefaultUserName .
@cpmcgrath Do you want to implement this proposal and #10625?

hello people ,
i'm new to github so i didn't know where to post this ... but i would like to talk about something regarding the new ternary operators and other operators ...
Well the reason that made me and many others like me to love powershell is because of its English-Like cmdlets ... like jeffery said " you think about something you type it and you get it " and that really works ... the newly added operators are more like other programming languages and i hope that powershell team are not going that road ... please keep powershell cmdlets simple as they were English-Like ...
again sorry i know im posting in the wrong thread im just new here.

@oumolayna You can new issue with feedback for discussion.

I'd be happy to look at implementing this, but it will probably be a few weeks before I get the chance

Just reading through the code to this MshHostUserInterface has an overload which takes options through an enum PSCredentialUIOptions. The implementation in ConsoleHostUserInterfaceSecurity doesn't bother to do anything with these options.
There's 4 different enum values:

None - "Performs no validation"
ValidateUsernameSyntax - the default: "Validates the username, but not its existence"
AlwaysPrompt - "Always prompt, even if a persisted credential was available"
ReadOnlyUsername - "Username is read-only, and the user may not modify it."

This seems like the mechanism that should be used, and these values imply to me that the default behaviour should be give the user a chance to override the Username

I think we can use the enum.
Changing the default behavior and changing the default enum value is two breaking changes. We will need approval from PowerShell Committee. I thing we can postpone the request until PR will be pulled.

As mentioned in my original comment, having it prompt for the Username regardless would make it more consistent with Windows Powershell.
But yes, potential breaking change if you had redirected Standard In. I'd think that would be very low risk though

Proposed change in https://github.com/cpmcgrath/PowerShell/commit/0a12184ca4985d6ba4f6b1c863d0fca33a5e79c5
I'll hold off making a pull request until I get feedback if this is the solution we're after.

I'll hold off making a pull request until I get feedback if this is the solution we're after.

Please make PR - we can discuss there and get progress step by step.
My first comment is if now we use the enum we should think to address all scenarios - it would be great to have for SDK scenarios.

Security working group see's not security implications for the feature request.  We should still review the design.
From a feature standpoint, I think the Cmdlet, should prompt to confirm the username, unless there is an extra switch to say that you can't change the username.  This would allow for compatibility with PowerShell 5.1

Security working group see's not security implications for the feature request.  We should still review the design.
From a feature standpoint, I think the Cmdlet, should prompt to confirm the username, unless there is an extra switch to say that you can't change the username.  This would allow for compatibility with PowerShell 5.1

Security working group see's not security implications for the feature request.

Here is a conflict between "security" and "Microsoft.PowerShell.Security" module :-) What is labels we should use?

Security working group see's not security implications for the feature request.

Here is a conflict between "security" and "Microsoft.PowerShell.Security" module :-) What is labels we should use?

Here is a conflict between "security" and "Microsoft.PowerShell.Security" module :-) What is labels we should use?

The label is appropriate.  Our first goal will always to be to assess if there is a security implication.  Then move one to design.

Here is a conflict between "security" and "Microsoft.PowerShell.Security" module :-) What is labels we should use?

The label is appropriate.  Our first goal will always to be to assess if there is a security implication.  Then move one to design.


Turn off registration of implicit entities

Current behaviour in OGM is that also classes without @NodeEntity annotations are registered implicitly as entities in the context.
Can you provide a flag to turn this behaviour off?

Hi Janne,
it is indeed intended behavior. We are tracking this internally and are discussing to change that in 4.0 to a more reluctant behavior like most other OxM do (taking only annotated or otherwise marked things into consideration).

We have decided to close this ticket:
While it is straight forward to find only classes annotated with @NodeEntity and @RelationshipEntity and use them, what happens with relations between those classes towards other classes that are not annotated?
The user need not use @Relationship for defining them, so in that case, we would have to look recursively at every field of the classes found in the initial step.
The effort required to do this is not justified by the overhead of scanning all classes. The overhead can be mitigated by choosing the "right" package and have only domain classes in it.


Always show 404 error when connect default database.

Description
When open default domain for access default database its always show 404.php and no routes working. I have setup [tenant] database setting in database.php . But when open tenancy hostname its working fine.
maindomain.com -> 404.php
-dev.tenant_1 -> working good
-dev.tenant_2 -> working good
..

Actual behavior
maindomain.com -> 404.php  for default connection!
..
Expected behavior
maindomain.com  need to be work prefect for default database connection.
..

Information

hyn/multi-tenant version:
laravel version:
database driver and version:
webserver software and version:
php version:

tenancy.php config
As default!

webserver.php config
As Default

Error log
No error log!

InvalidArgumentException Database [tenant] not configured.
        'system' => [             'driver' => 'mysql',             'host' => env('DB_HOST', '<IP_ADDRESS>'),             'port' => env('DB_PORT', '3306'),             'database' => env('DB_DATABASE', 'forge'),             'username' => env('DB_USERNAME', 'forge'),             'password' => env('DB_PASSWORD', ''),             'unix_socket' => env('DB_SOCKET', ''),             'charset' => 'utf8mb4',             'collation' => 'utf8mb4_unicode_ci',             'prefix' => '',             'strict' => true,             'engine' => null,         ],
`APP_NAME=Laravel
APP_ENV=local
APP_KEY=base64:0UFyNXefjtqWt60thnxrtE7yN4k7QH0rLTI4e1HfE4Y=
APP_DEBUG=true
APP_LOG_LEVEL=debug
APP_URL_BASE=localhost:8000
APP_URL=http://${APP_URL_BASE}
DB_CONNECTION=system
DB_HOST=<IP_ADDRESS>
DB_PORT=3306
DB_DATABASE=tenancy
DB_USERNAME=root
DB_PASSWORD=
BROADCAST_DRIVER=log
CACHE_DRIVER=file
SESSION_DRIVER=file
QUEUE_DRIVER=sync
REDIS_HOST=<IP_ADDRESS>
REDIS_PASSWORD=null
REDIS_PORT=6379
MAIL_DRIVER=smtp
MAIL_HOST=smtp.mailtrap.io
MAIL_PORT=2525
MAIL_USERNAME=null
MAIL_PASSWORD=null
MAIL_ENCRYPTION=null
PUSHER_APP_ID=
PUSHER_APP_KEY=
PUSHER_APP_SECRET=
LIMIT_UUID_LENGTH_32=true
AUTO_DELETE_TENANT_DIRECTORY=true
AUTO_DELETE_TENANT_DATABASE=true
`
Can you help me to resolve this problelm?

@pcfjojo next time please create an issue of your own.
You might need to enable early identification which will enable a middleware to identify tenants early in the Laravel ecosystem.

Now I pass the error what i had.. but now i have another error
Target [Hyn\Tenancy\Contracts\CurrentHostname] is not instantiable.   I changed   'abort-without-identified-hostname' => false, in tenancy.php.
stil i have this error.. i am new to github.. sorry for creating issue inside.

@pcfjojo create a new issue or join us on discord, see https://laravel-tenancy.com


Add Windows InitOnceBeginInitialize and InitOnceComplete shims

Fixes #2595

In the interest of having our CI fixed, I plan to take over this PR later today so that it can land ASAP. I hope that's okay.

@bors r+

:pushpin: Commit c9b32cca668cca76fe2b5a728861eac6e39238a6 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit c9b32cca668cca76fe2b5a728861eac6e39238a6 with merge 64757ed9acdfd6e020d391f46412963a3fcaf1e5...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 64757ed9acdfd6e020d391f46412963a3fcaf1e5 to master...


Brew tap failes. Custom fork with all 7.1 formulas deleted works

So after a long time trying to get this installed and many errors:
samir ~ % brew install<EMAIL_ADDRESS>==> Tapping kabel/php-ext Cloning into '/usr/local/Homebrew/Library/Taps/kabel/homebrew-php-ext'... remote: Enumerating objects: 41, done. remote: Counting objects: 100% (41/41), done. remote: Compressing objects: 100% (28/28), done. remote: Total 41 (delta 20), reused 18 (delta 7), pack-reused 0 Unpacking objects: 100% (41/41), done. Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Invalid formula<EMAIL_ADDRESS>No available formula with the name<EMAIL_ADDRESS>Error: Cannot tap kabel/php-ext: invalid syntax in tap!
I tried many commands but the output was always the same.
So i made my own fork and removed all 7.1 formulas and tried to install it via my fork:
samir@~ % brew install<EMAIL_ADDRESS>==> Tapping samirmokiem/php-ext Cloning into '/usr/local/Homebrew/Library/Taps/samirmokiem/homebrew-php-ext'... remote: Enumerating objects: 35, done. remote: Counting objects: 100% (35/35), done. remote: Compressing objects: 100% (25/25), done. remote: Total 35 (delta 14), reused 13 (delta 4), pack-reused 0 Unpacking objects: 100% (35/35), done. Tapped 18 formulae (89 files, 59.2KB). ==> Installing php-imap from samirmokiem/php-ext ==> Installing dependencies for samirmokiem/php-ext/php-imap: pkg-config and imap-uw ==> Installing samirmokiem/php-ext/php-imap dependency: pkg-config ==> Downloading https://homebrew.bintray.com/bottles/pkg-config-0.29.2.catalina.bottle.1.tar.gz ==> Downloading from https://akamai.bintray.com/c0/c0a6927c8e404f6db8b14d6644a218b22ddb0d27be1fa0a69d15bf0d9a6875ae?__gda__=exp=1575573813~hmac=ebff359fd80339d6781fa326bff5b33d97a7c53c1fad6952d58048d2ebbd1ee6&response-content-dispos ######################################################################## 100.0% ==> Pouring pkg-config-0.29.2.catalina.bottle.1.tar.gz 🍺  /usr/local/Cellar/pkg-config/0.29.2: 11 files, 623KB ==> Installing samirmokiem/php-ext/php-imap dependency: imap-uw ==> Downloading https://homebrew.bintray.com/bottles/imap-uw-2007f_1.catalina.bottle.tar.gz ==> Downloading from https://akamai.bintray.com/df/df3de76ba2934218f8f484f2d7e6c760956ba52eecacdb1b623d0b54d872165f?__gda__=exp=1575573816~hmac=3035f73ed23d19b1f75983da7bae852e3f7f5aac8b17cad36a7328f1a92a4eb2&response-content-dispos ######################################################################## 100.0% ==> Pouring imap-uw-2007f_1.catalina.bottle.tar.gz 🍺  /usr/local/Cellar/imap-uw/2007f_1: 152 files, 8.9MB ==> Installing samirmokiem/php-ext/php-imap ==> Downloading https://www.php.net/distributions/php-7.4.0.tar.xz         # -=#=- #     #                                                        ==> /usr/local/opt/php/bin/phpize ==> ./configure --with-php-config=/usr/local/opt/php/bin/php-config --with-imap=/usr/local/opt/imap-uw<EMAIL_ADDRESS>--with-kerberos ==> make 🍺  /usr/local/Cellar/php-imap/7.4.0: 7 files, 1MB, built in 35 seconds
And that worked. So whats wrong with the repo/master?
https://github.com/SamirMokiem/homebrew-php-ext repo
https://github.com/SamirMokiem/homebrew-php-ext/commits/master
https://i.ibb.co/xXswYGS/image.png

Fixed at 499218c167c93b6553053205a4a1b31abe6141ae


Possible Bug in Calibration and Visualizer counter

We should maybe switch to one single counter for both, calibration and visualization. Otherwise it might lead to weird bugs. See attached log, where the calibration is at step 1758 and the visualizer at 1760 which leads to errors.
30.08.2021-11:57:23 INFO Calibrator:      1757   1500.000000    750.000000      2.000000      0.300000      0.559923        -          = 1.0*0.5599
30.08.2021-11:57:29 INFO Calibrator:      1758   1500.000000    750.000000      2.000000      0.300000      0.559923        -          = 1.0*0.5599
30.08.2021-11:57:31 INFO Calibrator:
Results for calibration of model: dhc_models_hassel.GroundHeatExchange.GoundAndPipe.Verification.EmbeddedPipeCalibration
Number of iterations: 1758
Final parameter values:
Iteration   rho           c             ...s_ground   lambda          NRMSE      penaltyfactor   Unweighted NRMSE
     1760   1500.000000    750.000000      2.000000      0.300000      0.559923        -          = 1.0*0.5599

Calibrator.log

An error caused by the different counters:
The counter of the iterations actually performed: 25
The counter that counts each iteration started: 48
In the end, the graph of the iteration with the best result should probably be accessed. The graph is searched for with the counter of the started iteration. However, the graphics are saved with the counter of the iterations performed. The result is an error message and a termination of AixCaliBuHA.

11.10.2021-11:43:08 INFO MultipleClassCalibrator:        25   0.000002   79.930178        -          = 1.079.93
11.10.2021-11:43:09 INFO MultipleClassCalibrator:
Results for calibration of model: BasicModel_CaliAixCalibration.BasicModel_CaliSimulator
Number of iterations: 25
Final parameter values:
Iteration   ...Fixed     NRMSE   penaltyfactor   Unweighted NRMSE
48   0.000002   3.688188        -          = 1.03.688
Traceback (most recent call last):
File "C:/Users/sgo-tfi/sciebo2/MA/06_Simulationsmodell/Kalibrierung/main.py", line 28, in
main()
File "C:/Users/sgo-tfi/sciebo2/MA/06_Simulationsmodell/Kalibrierung/main.py", line 24, in main
run_calibration.run_calibration(sim_api=sim_api, cal_classes=calibration_classes, validation_class=validation_class)
File "C:\Users\sgo-tfi\sciebo2\MA\06_Simulationsmodell\Kalibrierung\run_calibration.py", line 100, in run_calibration
result = modelica_calibrator.calibrate(
File "e:\sgotfi\git\aix\aixcalibuha\aixcalibuha\calibration\multi_class_calibrator.py", line 165, in calibrate
super().calibrate(framework=framework, method=method, **kwargs)
File "e:\sgotfi\git\aix\aixcalibuha\aixcalibuha\calibration\calibrator.py", line 318, in calibrate
_res = self.optimize(framework, method, **kwargs)
File "e:\sgotfi\git\ebcpy\ebcpy\optimization.py", line 139, in optimize
res = minimize_func(method, **kwargs)
File "e:\sgotfi\git\ebcpy\ebcpy\optimization.py", line 298, in _scipy_differential_evolution
self._handle_error(error)
File "e:\sgotfi\git\aix\aixcalibuha\aixcalibuha\calibration\calibrator.py", line 437, in _handle_error
self.logger.save_calibration_result(best_iterate=self._current_best_iterate,
File "e:\sgotfi\git\aix\aixcalibuha\aixcalibuha\utils\visualizer.py", line 500, in save_calibration_result
copyfile(bestgoal, f'{iterpath}\best_goals.%s' % self.file_type)
File "C:\Users\sgo-tfi.conda\envs\py38_ebcpyNew\lib\shutil.py", line 264, in copyfile
with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
> FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\sgo-tfi\sciebo2\MA\06_Simulationsmodell\Kalibrierung\results_p_IT50\Constant1_20_30_2_100_550_650\TimeSeriesPlot\48_goals.png'
11.10.2021-11:43:09 INFO DymolaAPI: Closing Dymola
11.10.2021-11:43:10 INFO DymolaAPI: Successfully closed Dymola
Process finished with exit code 1


Since there's a  wrapperClassName to set className on the parent wrapper. why not something like innerWrapperClassName to set className on the inner wrapper?

<svg class="react-datepicker__calendar-icon " xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512">
<path d="M96 32V64H48C21.5 64 0 85.5
 0 112v48H448V112c0-26.5-21.5-48-48-48H352V32c0-17.7-14.3-32-32-32s-32
 14.3-32 32V64H160V32c0-17.7-14.3-32-32-32S96 14.3 96 32zM448 192H0V464c0 26.5 21.5 48 48
 48H400c26.5 0 48-21.5 48-48V192z"></path></svg>
<input placeholder="select date" class="rounded-xl text-black focus:outline-none placeholder-[#000000]
 placeholder-opacity-70 bg-[#D9D9D9]  w-full" type="text" value="">

I could add extra className to the parent wrapper ( i did added "outer" className ) thanks to the wrapperClassName property.
What if i want something similar on the inner wrapper ( the inner div holding svg and input element ) ? A similar property name to wrapperClassName would be cool.

Currently, there is no functionality to set the Custom class name for react-datepicker__input-container.
It seems to me that you should request additional functionality for inputContainerClassName Props or use a descendant selector of the outer class for styling. (e.g. .outer .react-datepicker__input-container)


remove support for node 10 and 12

update github action
add engine prop to package.json

Done! Please, let know if you need any more changes related to this. 👍🏾


Actblue migration to v2 destination

This is running successfully locally for me, and I think makes a few changes that aren't in the older PR (#251 )
Jira ticket: https://techallies.atlassian.net/browse/DE-687
dbt updates PR: https://github.com/community-tech-alliance/dbt-cta/pull/339
airbyte configs PR: https://github.com/community-tech-alliance/airbyte-configs/pull/124
airflow dags PR: https://github.com/community-tech-alliance/airflow-dags/pull/694

As discussed in Slack, while we're making this change could you please swap out the suffix _stream for _base so that these models are consistent with our other syncs? 🙏 yay 🙏

@emily-flambe I think I got everything but still learning the ropes around here so would love someone to double check!


CDPS-956: Flyway migration for distinguishing marks doc type corrected.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.46%. Comparing base (2a84273) to head (f633732).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #87   +/-   ##
=========================================
  Coverage     92.46%   92.46%
  Complexity      249      249
=========================================
  Files            48       48
  Lines           929      929
  Branches         62       62
=========================================
  Hits            859      859
  Misses           58       58
  Partials         12       12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[web] Application cannot access .env

Hi,
Flutter web application needs access to the servers' .env.
The application is being served 'statically' from build/.
Dart IO is not supported for web and throws a platform._environment exception.
Any workarounds?

Am I the only one who notices information is limited or filtered. To keep people from maximum potential.

Questions like these are better suited for Q&A sites like StackOverflow or on one of the flutter community sites at https://flutter.dev/community

This is an enquiry into using JWT with Flutter Web.
I have developed a JWT solution (will want to make an open source library for others to use) for my application (flutter web).
My solution has been to create a config.json that holds the secret to issue a new Jwt token. The config.json is not committed to source control, but is found under assets in the pubspec.yaml in order to use it in the app.
The token is stored in browser local storage as usual.
The main issue is whether or not the config.json is discoverable from the browser (i.e exposing the secret token, would allow bad actors to login to other user accounts), using CMD + P in Chrome Dev Tools I could not find the config.json but can see all of the raw Dart source code from my app (another minor issue).
Concerns
Is or could the config.json be found in the app either by sucking the site, or in dev tools or via some arbitrary url exposing public assets?
What would be a better way of using assets in a flutter app so that they are not exposed from the get go?
Errata
Happy to provide source code or answer any questions.
Flutter Web is Beta, I think its best to catch these kinds of issues as early as possible. It would also give me peace of mind that another future release wouldn't effect this implementation.


[Bug]: contentType header is missing in response headers

Describe the bug
content type header is missng in response headers. And I didn't see anything mentioned this kind of removal in the release notes of 0.57.0
here's what the route.response shows in version 0.56.0

here's what the route.response shows in version 0.57.0

From what TypeGraph shows, the returnType of operation getSchemaById has this contentType header, but it's missing from getHttpOperation.
Reproduction
Playground link
Checklist

[X] Follow our Code of Conduct
[X] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

For languages that would include headers in the response model like JS & GO, this is likely to be a breaking change for the SDK.
@allenjzhang, @markcowl, could you help to confirm whether this behavior is by design? This would impact our emitters to move to TypeSpec 0.57.
cc @lmazuel for awareness.

No impact for Java emitter, so far. The response in Java is Response<T> where headers is a dict (so it is runtime).

This is by design.  Response content-type is express via Produce in Swagger  and content in OAS 3.0. See respective linked specs.
This is correctly expressed in swagger playground and OAS3.0 playground.

Sorry, the above was commented as for the autorest/OAS3 emitter and not exactly you are referring to. For the getHttpOperation function result , there was some refactoring around httpProperty  that explicitly separated contentType into a new contentType HttpProperty.  This actually fixed a casing bug originally existed.
Now that is fixed, please switch the logic to access the body.contentTypes. If you still want it as part of headers, additional logic will be needed to filter them out in autorest and openapi3 emitters, as I mentioned above. So that would be far less ideal.

Worth noting explicitly that the presence of "Content-Type" in the headers list is a bug, if it were called "content-type" instead it would have been excluded properly, so the previous code relying on this was still incorrect. This playground shows the bug that existed previously.
FWIW I definitely prefer to just fix the bug and change how emitters are accessing content type. Adding the content type headers to the header collection seems likely to have a lot of downstream impact beyond our own openapi3 and autorest emitters.

Thanks @allenjzhang and @bterlson  for the investigation and suggestions, I will use body.contentTypeProperty to make it work.


"Players Played With" section inaccuracy

https://www.opendota.com/players/77314199
For my profile it shows wrong numbers. For example if I take a look at "Teammates" section in dota profile will see that I've played about 500 (not 83) games with "Mamsel LS".

If the player was anonymous during that match they will not be counted.  The in-game client does not have this restriction.  If they enable public match history and then their match history is refreshed (via link on their OpenDota profile) it should correct itself.


Indices with "." in names cause exception but error is never raised.

After attempting to query some date based index names and no results except a 500 from the back-end being returned I found this error in the logs.
c2904330-9c90-4306-96e6-d4335dd6c917 Client side error during query execution com.amazon.opendistroforelasticsearch.sql.legacy.antlr.syntax.SyntaxAnalysisException: Failed to parse query due to offending symbol [.10] at: 'select count(*) from logstash-2020.10' <--- HERE... More details: Expecting tokens in {<EOF>, ';'} 	at com.amazon.opendistroforelasticsearch.sql.legacy.antlr.syntax.SyntaxAnalysisErrorListener.syntaxError(SyntaxAnalysisErrorListener.java:41) ~[legacy-<IP_ADDRESS>.jar:?]
Did not see any warnings about this in the documentation section so I figured I would post this here. I totally get why this is not valid from the dot perspective.
As a side note, the following query works:
select count(*) from .kibana_1;
Similar issues happen with the PPL.

Hi @jasonrojas
Thank you for reporting this. In our current syntax rule, dot(.) would be recognized as a special character or say a delimiter for nested fields, except when it turns up at the starting place like the system index .kibana_1. We would suggest you quote the index name (or any other identifier i.e. field name etc.) using backticks if it contains special characters (., $,  ,...) to skip the analysis of the chars in it. Take the query you provided as an example:
select count(*) from `logstash-2020.10`

Please let us know if there's any other question/issue, thanks!


attrs tag formatting breaks the code

Version: head
With the exception that the marko compiler version was updated as in PR #11.
Details
Expected Behavior
If you try to format the following code:
<attrs/{
    greeting = "Hello",
    firstName,
    lastName,
    ...otherAttrs
}/>

${greeting}, my name is

${firstName} ${lastName}

you get the following result:
<attrs/{/>

${greeting}, my name is

${firstName} ${lastName}

Instead, I'd expect the formatted code to still be syntactically correct.
Possible Fix
My guess is that the root cause is similar to #7 since the issue looks very similar. That issue was fixed by updating the marko compiler. However, I've ensured that this issue is distinctly different by ensuring the compiler was updated to the latest version.
Additional Info
Your Environment

Environment name and version (e.g. Chrome 39, node.js 5.4): NodeJS v18.1.0
Operating System and version (desktop or mobile): macOS 12.4
Link to your project: this repo

Steps to Reproduce

Update this repo to the latest version of the marko compiler npm i @marko/compiler@latest
Add the above code as a new text fixture
Run npm run test:update to create the new snapshots
View the created snapshots

After more experimentation, this does not happen all the time. It only seems to happen occassionly on certain, long attributes. For instance, all the following error:
<attrs/{
    greeting = "Hello",
    firstName,
    lastName,
    ...otherAttrs
}/>

<attrs/{
    greeting = "Hello",
    firstName,
    ...otherAttrs
}/>

<attrs/{
    greeting = "Hello",
    firstName,
    lastName
}/>

Yet the following work correctly:
<attrs/{
    greeting = "Hello",
    firstName,
}/>

<attrs/{
    greeting = "Hello",
    ...otherAttrs
}/>

<attrs/{
    firstName,
    ...otherAttrs
}/>

<attrs/{
    item1,
    item2,
    item3,
    item4,
    item5,
    item6,
    item7,
    item8,
    item9,
}/>


Should consider moving GetValue extensions from Binder into Configuration base

These seem to be generically useful extension methods, if picking up TypeConverter is an ok dependency, we should move this to the base implementation instead of Binder

Yay


Swag should not generate document of private fields

Describe the bug
Swag should not generate document of private fields
Steps to reproduce the behavior
With input struct
type NextTradeServer struct {
	IP    string                `gorm:"column:ip;primary_key" json:"ip"`
	Extra json.RawMessage       `gorm:"column:extra" json:"extra"`
	cache *NextTradeServerExtra // private field
}

Got result:
  model.NextTradeServer:
    properties:
      cache:
        $ref: '#/definitions/model.NextTradeServerExtra'
        type: object
      extra:
        type: string
      ip:
        type: string
    type: object
  model.NextTradeServerExtra:
    properties:
      start_times:
        items:
          type: string
        type: array
      stop_times:
        items:
          type: string
        type: array
      trader_ids:
        items:
          type: integer
        type: array
    type: object

Expected behavior
Private fields should not be document generated.
Your swag version
swag version v1.6.5
Your go version
go version go1.14 linux/amd64
Workground
Add json:"-" to private field will stop swag generate documents.
Side effect: go lint reports struct field cache has json tag but is not exported
Replace json:"-" with `swaggerignore:"true" does not work, lint warning gone but swagger document generated.

Having the exact same problem. swaggerignore:"true" does not seem to be working

Feature of swaggerignore was merged into master branch just a few days ago, after v1.6.5.
Try master,please.

@sdghchj For private field, swaggerignore is not needed

I really appreciate your unconstrained idea to constrain that private fields shouldn't be generated.
But, compatibility needs to be considered for those who already using it in that way, and how if someone in future come and ask why not generate private fields?
I still think 'private' is a concept in golang's respect, and tag is a better way for this case, more flexible.

@sdghchj Agree with you. Then swaggerignore in next version after v1.6.5 will fixed this issue.

@comphilip  Given that json in golang sdk indeed excludes private fields, I think you're right.
I'm not sure about Gin's unmarshaling params in query

Have fixed by #675