must epoch error on full ghost

After the versioning branch has been merged into the master branch, I'm occasionally seeing a failed constraint from the must epoch launch in the full ghost example. There has been a known issue with must epoch launches in the versioning branch and I think this is the same issue that still hasn't got fixed. I got this error more frequently when I oversubscribe the physical cores in the system (for example, run ./ghost -b 16 -ll:cpu 16 on only four processors). Here is the stacktrace and the error message:
(lldb) target create "./ghost"
Current executable set to './ghost' (x86_64).
(lldb) settings set -- target.run-args  "-b" "16" "-l" "10" "-ll:cpu" "16"
(lldb) run
Process 59746 launched: './ghost' (x86_64)
[0 - 7fff79f4b000] {4}{threads}: reservation ('CPU proc 80000002') cannot be satisfied
Running stencil computation for 1024 elements for 10 steps...
Partitioning data into 16 sub-regions...
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 2 of operation spmd (UID 4) is using uninitialized data for field(s) 2 of logical region (49,1,32)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 4) is using uninitialized data for field(s) 2 of logical region (20,1,3)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 5) is using uninitialized data for field(s) 2 of logical region (22,1,5)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 6) is using uninitialized data for field(s) 2 of logical region (24,1,7)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 7) is using uninitialized data for field(s) 2 of logical region (26,1,9)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 8) is using uninitialized data for field(s) 2 of logical region (28,1,11)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 9) is using uninitialized data for field(s) 2 of logical region (30,1,13)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 10) is using uninitialized data for field(s) 2 of logical region (32,1,15)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 11) is using uninitialized data for field(s) 2 of logical region (34,1,17)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 12) is using uninitialized data for field(s) 2 of logical region (36,1,19)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 13) is using uninitialized data for field(s) 2 of logical region (38,1,21)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 14) is using uninitialized data for field(s) 2 of logical region (40,1,23)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 15) is using uninitialized data for field(s) 2 of logical region (42,1,25)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 16) is using uninitialized data for field(s) 2 of logical region (44,1,27)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 17) is using uninitialized data for field(s) 2 of logical region (46,1,29)
[0 -<PHONE_NUMBER>00] {4}{runtime}: WARNING: Region requirement 3 of operation spmd (UID 18) is using uninitialized data for field(s) 2 of logical region (48,1,31)
[0 -<PHONE_NUMBER>00] {5}{runtime}: MUST EPOCH ERROR: failed constraint! Task spmd (ID 5) mapped region 0 to instance e0000000 in memory 60000000 , but task spmd (ID 4) mapped region 3 to instance e0000007 in memory 60000000.
Assertion failed: (false), function trigger_execution, file /Users/wclee/Workspace/stanford/projects/legion//runtime/legion/legion_ops.cc, line 7084.
Process 59746 stopped

thread #2: tid = 0x80a101, 0x00007fff8e84f0ae libsystem_kernel.dylib__pthread_kill + 10, stop reason = signal SIGABRT   frame #0: 0x00007fff8e84f0ae libsystem_kernel.dylib__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:

->  0x7fff8e84f0ae <+10>: jae    0x7fff8e84f0b8            ; <+20>
0x7fff8e84f0b0 <+12>: movq   %rax, %rdi

0x7fff8e84f0b3 <+15>: jmp    0x7fff8e84a3ef            ; cerror_nocancel

0x7fff8e84f0b8 <+20>: retq

(lldb) bt

thread #2: tid = 0x80a101, 0x00007fff8e84f0ae libsystem_kernel.dylib`__pthread_kill + 10, stop reason = signal SIGABRT

frame #0: 0x00007fff8e84f0ae libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x00007fff8e654500 libsystem_pthread.dylib`pthread_kill + 90
frame #2: 0x00007fff9813937b libsystem_c.dylib`abort + 129
frame #3: 0x00007fff981009c4 libsystem_c.dylib`__assert_rtn + 321
frame #4: 0x000000010008a8da ghost`LegionRuntime::HighLevel::MustEpochOp::trigger_execution(this=0x00000001018233d0) + 7930 at legion_ops.cc:7084
frame #5: 0x00000001005f18b3 ghost`LegionRuntime::HighLevel::Runtime::high_level_runtime_task(args=0x0000000100f342c0, arglen=20, p=(id =<PHONE_NUMBER>)) + 1123 at runtime.cc:15895
frame #6: 0x00000001008247e9 ghost`Realm::Task::execute_on_processor(this=0x0000000100f31bf0, p=(id =<PHONE_NUMBER>)) + 297 at tasks.cc:80
frame #7: 0x0000000100829089 ghost`Realm::UserThreadTaskScheduler::execute_task(this=0x0000000101801610, task=0x0000000100f31bf0) + 41 at tasks.cc:884
frame #8: 0x00000001008267a4 ghost`Realm::ThreadedTaskScheduler::scheduler_loop(this=0x0000000101801610) + 1668 at tasks.cc:448
frame #9: 0x0000000100846641 ghost`void Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &(Realm::ThreadedTaskScheduler::scheduler_loop())>(obj=0x0000000101801610) + 97 at threads.inl:127
frame #10: 0x00000001007feb16 ghost`Realm::UserThread::uthread_entry() + 358 at threads.cc:740
frame #11: 0x00007fff8929c33b libsystem_platform.dylib`_ctx_start + 11

It's not going to be able to be fixed until there is a new mapping interface that allows mappers to name explicit physical instances.  You can make it a little bit better by marking the instances that are being made persistent.

Commit f549191 and a8597f3 seem to fix this issue. Reopen this if someone still finds this issue.


update azure-core-management changelog

Maybe we should publish the beta.1 rather than beta.8, since the last version is preview.4


Flutterbum CalEvents: Edit event dialogue

Clicking on an event brings the modal dialogue up, but doesn't populate it with the information you may have already saved, so if you save it, you lose everything for that event.

I've added the ability to load the calendar event into the dialog when it opens.


Reset connecting flag when using DNS resolve

Fixes #200

Also, should checking/setting connecting be moved to after calling shared_from_this in BeginConnect?
https://github.com/sidhoda/dnp3/blob/a3043acecce30a3ebbf5e10974c0a3d81d6fa94c/cpp/libs/src/asiopal/TCPClient.cpp#L62

What's your thoughts on adding a "Connecting to: %s" log message in here?
https://github.com/automatak/dnp3/blob/2.0.x/cpp/libs/src/asiodnp3/TCPClientIOHandler.cpp#L70
It would have made this easier to spot the issue in this case, although it could potentially bloat logs if lots of connection attempts are happening.

I think adding the log message is fine. We already have a log message for connection failures so it doesn't appreciably change the number of messages. Also, connection failures "back-off" so fewer and fewer on dead endpoints.
I will take a peek at fix and flag issue when time permits.

Okay, I'll add the log message and update the PR.
I have a feeling I've misunderstood the use of shared_from_this, was thinking calling that method is like entering a critical section.

Thanks Sid. shared_from_this() is just used to grab a shared_ptr that points back to the object. This ensures that the object is not deleted while an asynchronous callback is pending. It isn't a critical section. The run-time cost is the same as  shared_ptr, e.g. atomic increment/decrement.

All makes sense now, thanks.

Thanks @jadamcrain, would we be a position to tag a new RC?

Done. 2.2.0-RC5 building on appveyor and update in changelog.

Thanks! Happy to give the master multi-drop a test when it's ready, we use this in a few places.


No module named 'ConfigSpace'

I use the python 3.5.2 and when i run the entropy_search. It shows that No Module named 'ConfigSpace'. And i put my traceback below.
File "./experiments/fabolas/run_entropy_search.py", line 11, in
from hpolib.benchmarks.ml.svm_benchmark import SvmOnMnist, SvmonVehicle, SvmOnCovertype
File "/usr/local/lib/python3.5/dist-packages/hpolib/benchmarks/ml/svm_benchmark.py", line 4, in
import ConfigSpace as CS
ImportError: No module named 'ConfigSpace'

Hi if you want to use the SVM benchmark you have to install HPOlib2 and the ConfigSpace first.

I meet another problem after that. "No module named openml". And i use pip3 to install. It shows that could not find a version that satisfies the requirement openml(from versions:) and no matching distribution found for openml.

You have to follow this instructions here to install openml:
https://openml.github.io/openml-python/stable/

I meet many problems when running the experiments. But i can run the examples in the example folder. The problems when running experiments were "ImportError: No module named 'hpolib.benchmarks.ml.residual_networks' ". I have installed the hpolib2 early.
When i annotated the residual_networks lines, it shows that "from theano.tensor.signal import downsample, cannot import name 'downsample' "


fix(core): handle atomic block removal edge cases

PR Description
To fix issue https://github.com/mirror-media/Lilith/issues/222.
Implementation Details
DraftJS does not remove atomic block beautifully when

cursor selection is not collapsed
cursor selection only includes partial text of atomic block

DraftJS will delete the entity data of that atomic block, but still remain that block as atomic type.
When block-redender-fn tries to render that atomic block without entity data, the unexpected error happens.
In this PR, we detect the above situations, and perform the range deletion by ourselves.
If the cursor selection starts or ends at an atomic block, we force the selection covering all texts of atomic block by changing

selection.anchorKey
selection.anchorOffset
selection.focusKey
selection.focusOffset

In addition, when we enter Backspace to merge two blocks into one block, like removing the newline, the bottom block will be merged into the top block. Therefore, the bottom block style will disappear.
Hence, after performing blocks removal, we also need to change the type of block which is after the removed blocks back to the original type.

@caesarWHLee 有空請幫忙看一下，感謝

LGTM 👍 👍 👍 ，the comments are super clear to follow!


SS-3010 Support context-aware http requests.

This PR adds support for using golang.org/x/net/context with HTTP requests. It can be used to cancel requests after certain period.

Code Coverage is 82.2%, details at https://s3.amazonaws.com/rs-code-coverage/rsc/2015-12-17_510_Coverage-82.2.txt (sometimes the URL can take a few minutes to be available)

LGTM


Undeclared class from PECL extension

I'm using Memcached and phan is complaining:
PhanUndeclaredTypeProperty Property of undeclared type \memcached
PhanUndeclaredClassMethod Call to method get from undeclared class \memcached

and so on.
Is there any way I can provide some stub file (like a .h in C) for analysis?

Hi @tybulewicz.
I use this stub for working with Memcache; https://gist.github.com/morria/63e6f502c60eed18a015
I usually make a directory like .phan/stubs to put such things in and then add that directory to the analysis such as in phan --directory src --directory .phan/stubs.
You can also create a file .phan/config.php such as with https://github.com/etsy/phan/blob/master/.phan/config.php#L67-L72 and add a directory_list parameter that includes .phan/stubs.
Let me know if that doesn't work for you.

Hi @morria,
It works now, thanks a lot!


Deprecate unnecessarily partial functions

We should deprecate replace and splitOn, and create alternatives for them that take a NonEmpty instead of crashing at runtime when their first parameter is empty.

While it is would be nice if they were pure, syntactically writing a NonEmpty, especially for a String is cumbersome - often the first arg is a constant. Perhaps safe variants should go in the List.NonEmpty.Extra, then people can pick their poison.


give a timstamp to orphan order cancellation, it is screwing up with …

…the sort order
https://app.clubhouse.io/augur/story/14584/messaging-in-information-bell-out-of-sequence

Pull Request Test Coverage Report for Build 1079

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 66.949%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/modules/orphaned-orders/actions/index.js
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

src/modules/orphaned-orders/actions/index.js
1
50.0%

Totals

Change from base Build 1075:
-0.004%

Covered Lines:
3605

Relevant Lines:
4902

💛  - Coveralls


Zeno Radio Version Here.

DEMO : https://boxradio.net/player/zeno/
Source Code : https://boxradio.net/player/zeno.zip
to set up your station for it edit the script.js file with your credentials
you will see a var named 'zenoid' and replace it with your stream link mount example 'cfqla0proqwtv' --> this can
be found here https://stream.zeno.fm/cfqla0proqwtv
and change the rest of the info to fit your needs, next edit the style.css and replace urls that starts with https://ucarecdn.com/ to your station logo.
Improvements.
Artwork Finder Built In House. Uses Both Deezer & Itunes API.
Artwork API Endpoint : https://api.streamafrica.net/search.php?query=song-title
No PHP Files to host so you can use netlify, vercel or any other serverless hosting services.

i think i did like everything you explain but the page doesn't update the background,cover,song title and page title
but the audio stream does work
https://www.syndicatedhiphop.com/zeno
https://www.syndicatedhiphop.com/zeno.zip
thank you for any help you can provide

Thanks alot finally my original player do play the zeno strream finally needed to clear my cache on cloudflare
https://www.syndicatedhiphop.com/player/
https://www.syndicatedhiphop.com/zeno


mjpegtools: fix build with clang 16

Description of changes
Clang 17 defaults to C++17, causing the build to fail because the following has been removed from C++17:

std::auto_ptr; and
The register type class specifier.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Clang 17

Did you mean clang 16? That's what the comment says.

Clang 17

Did you mean clang 16? That's what the comment says.

Yeah, that’s a typo. I’ll fix the commit message.


TypeError when event is captured on a request with file uploads

How do you use Sentry?
Sentry Saas (sentry.io)
Version
3.17.0
Steps to Reproduce
Sentry SDK is throwing a TypeError when I capture an event during a request that has file uploads.
In my case, the $filename passed to Http\Discovery\Psr17Factory::createStreamFromFile() is an array such as  [0 => '/tmp/phpPzNFTx'] rather than a string.
The file upload field is using nested array syntax for doing multiple file uploads, e.g. <input multiple="multiple" type="file" name="files[upload_0][]">
Expected Result
Event is captured by Sentry.
Actual Result
TypeError: Http\Discovery\Psr17Factory::createStreamFromFile(): Argument #1 ($filename) must be of type string, array given, called in /vendor/php-http/discovery/src/Psr17Factory.php on line 271 in Http\Discovery\Psr17Factory->createStreamFromFile() (line 120 of /vendor/php-http/discovery/src/Psr17Factory.php)
#0 /vendor/php-http/discovery/src/Psr17Factory.php(271): Http\Discovery\Psr17Factory->createStreamFromFile(Array, '...')
#1 /vendor/php-http/discovery/src/Psr17Factory.php(184): Http\Discovery\Psr17Factory->normalizeFiles(Array)
#2 /vendor/php-http/discovery/src/Psr17Factory.php(106): Http\Discovery\Psr17Factory->buildServerRequestFromGlobals(Object(GuzzleHttp\Psr7\ServerRequest), Array, Array)
#3 /vendor/sentry/sentry/src/Integration/RequestFetcher.php(25): Http\Discovery\Psr17Factory->createServerRequestFromGlobals()
#4 /vendor/sentry/sentry/src/Integration/RequestIntegration.php(125): Sentry\Integration\RequestFetcher->fetchRequest()
#5 /vendor/sentry/sentry/src/Integration/RequestIntegration.php(117): Sentry\Integration\RequestIntegration->processEvent(Object(Sentry\Event), Object(Sentry\Options))
#6 /vendor/sentry/sentry/src/State/Scope.php(378): Sentry\Integration\RequestIntegration->Sentry\Integration{closure}(Object(Sentry\Event), Object(Sentry\EventHint))
#7 /vendor/sentry/sentry/src/Client.php(292): Sentry\State\Scope->applyToEvent(Object(Sentry\Event), Object(Sentry\EventHint))
#8 /vendor/sentry/sentry/src/Client.php(169): Sentry\Client->prepareEvent(Object(Sentry\Event), Object(Sentry\EventHint), Object(Sentry\State\Scope))
#9 /vendor/sentry/sentry/src/State/Hub.php(152): Sentry\Client->captureEvent(Object(Sentry\Event), Object(Sentry\EventHint), Object(Sentry\State\Scope))
#10 /vendor/sentry/sentry/src/functions.php(55): Sentry\State\Hub->captureEvent(Object(Sentry\Event), Object(Sentry\EventHint))

Looking at your stack trace, the issue seems to stem from https://github.com/php-http/discovery.

yes, seems to have started happening with the upgrade of that dependency and the change from ServerRequest::fromGlobals() to (new Psr17Factory())->createServerRequestFromGlobals()

A new version of php-http/discovery was released and should fix this issue.


faster frog

frog go brrrrrr
transparency was lost due to ffmpeg, but i think it's fine

It looks bad without transparency on dark theme. Can you fix it?

I tried apng this time, transparency should be good now

Eh, there's something broken with frames and it's not that important. Sorry


Start implementing layout engine

Starts work towards #6.
I've opened this to get some feedback.
Currently, it only computes sizes (not offsets), and it only works for the top-level window.

I've updated the PR. It is now able to recurse through the layout for window:main without crashing.
It seems to compute main axis sizes (i.e. heights) correctly. The cross axis sizes aren't really implemented yet.

I've updated this earlier, but it seems GitHub didn't display the changes :thinking:
The changes are as follows:

rebased on top of the latest master, fixing what changed.
switched to using the euclid crate for 2D geometry. This is the same one used by the Servo browser's layout engine, so it's right on target.

I've rebased the PR, and incorporated the latest changes from master. The code now compiles and runs, and produces mostly the same output as before.
The code is still messy in my opinion and I'll look into breaking it up into multiple PRs or refactors over the following days.

Shelved on account of switching to a web app frontend for the short term.


Fix tightlist in pandoc 1.14

pandoc 1.14 introduced \tightlist
Related links:
https://github.com/tompollard/phd_thesis_markdown/pull/5
https://github.com/jgm/pandoc/pull/1571#issuecomment-106298268
https://github.com/osener/markup.rocks/issues/4
https://github.com/rstudio/rmarkdown/issues/439

Added to source/template.tex:
% fix for pandoc 1.14
\providecommand{\tightlist}{%
  \setlength{\itemsep}{0pt}\setlength{\parskip}{0pt}}


bug:  Avante Won't Generate Responses

Describe the bug
Avante never responds with a generated response. It just hangs forever.
I nvim index.js and <leader>aa to open Avante. I enter a prompt, eg. Write a Javascript function that takes in two arguments and returns their sum. then Ctrl-S and I see Generating response ... forever.
It never outputs anything. It just hangs here forever
I copied the standard avante install with lazy to ~/.config/nvim/lua/plugins/avante' as shown below.
I pay for Claude. I created my anthropic api key by going to: https://console.anthropic.com/settings/keys and creating a new key.
I tried setting this key three ways:

in ~/.config/fish/config.fish I added set -gx ANTHROPIC_API_KEY <MY-API-KEY>. I verified it was set by running source ~/.config/fish/config.fish then echo $ANTHROPIC_API_KEY.
With no env var. I execute <leader>aa in neovim. I am prompted to enter ANTHROPIC_API_KEY by Avante and I enter my real api key.
With no env var. I execute <leader>aa in neovim. I am prompted to enter ANTHROPIC_API_KEY by Avante and I enter my something random like: asdfasdfjkl.

Then I nvim index.js and <leader>aa to open Avante. I enter a prompt, eg. Write a Javascript function that takes in two arguments and returns their sum. then Ctrl-S and I see Generating response ... forever.
It never outputs anything. It just hangs here forever:
---

- Datetime: 2024-12-03 09:43:21

- Model: claude/claude-3-5-sonnet-20241022

- Selected file: index.js

> Write a Javascript function that takes in two arguments and returns their sum.

**Generating response ...**

All three produce the same result. It seems that my API key is incorrect because it behaves the same as when I give something random for the API keys.
To reproduce
No response
Expected behavior
Avante completes a response of a JS function that sums two numbers.
Installation method
I copied the standard avante install with lazy to ~/.config/nvim/lua/plugins/avante' as shown below.
I pay for Claude. I created my anthropic api key by going to: https://console.anthropic.com/settings/keys and creating a new key.
I tried setting this key three ways:

in ~/.config/fish/config.fish I added set -gx ANTHROPIC_API_KEY <MY-API-KEY>. I verified it was set by running source ~/.config/fish/config.fish then echo $ANTHROPIC_API_KEY.
With no env var. I execute <leader>aa in neovim. I am prompted to enter ANTHROPIC_API_KEY by Avante and I enter my real api key.
With no env var. I execute <leader>aa in neovim. I am prompted to enter ANTHROPIC_API_KEY by Avante and I enter my something random like: asdfasdfjkl.

return {
   "yetone/avante.nvim",
   event = "VeryLazy",
   lazy = false,
   version = false, -- set this if you want to always pull the latest change
   opts = {
   	-- add any opts here
   },
   -- if you want to build from source then do `make BUILD_FROM_SOURCE=true`
   build = "make",
   -- build = "powershell -ExecutionPolicy Bypass -File Build.ps1 -BuildFromSource false" -- for windows
   dependencies = {
   	"stevearc/dressing.nvim",
   	"nvim-lua/plenary.nvim",
   	"MunifTanjim/nui.nvim",
   	--- The below dependencies are optional,
   	"hrsh7th/nvim-cmp", -- autocompletion for avante commands and mentions
   	"nvim-tree/nvim-web-devicons", -- or echasnovski/mini.icons
   	"zbirenbaum/copilot.lua", -- for providers='copilot'
   	{
   		-- support for image pasting
   		"HakonHarnes/img-clip.nvim",
   		event = "VeryLazy",
   		opts = {
   			-- recommended settings
   			default = {
   				embed_image_as_base64 = false,
   				prompt_for_file_name = false,
   				drag_and_drop = {
   					insert_mode = true,
   				},
   				-- required for Windows users
   				use_absolute_path = true,
   			},
   		},
   	},
   	{
   		-- Make sure to set this up properly if you have lazy=true
   		"MeanderingProgrammer/render-markdown.nvim",
   		opts = {
   			file_types = { "markdown", "Avante" },
   		},
   		ft = { "markdown", "Avante" },
   	},
   }
}

Environment
NVIM v0.10.2
Build type: Release
LuaJIT 2.1.1727870382
Run "nvim -V1 -v" for more info
Darwin Caseys-MacBook-Pro.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000 arm64
Fish shell
Repro
- Open nvim
- <leader>aa
- * Set API Key if not set by env
- Propmt Avante
- Ctrl + s

Do I need to pay for "Anthropic" in addition to paying for "Claude"?

I needed to add billing to Anthropic. It is not sufficient to be a "Professional" customer of Claude.ai.


How can I fine tune sqlcoder-7b 2 model over my onw query?

Hi there, you can use any of the fine-tuning approaches made available by open-source libraries. For instance, using TRL or axolotl
Please remember to open-source any fine-tunes you make, to comply with the model's cc-by-sa-4.0 license

Thank you very much for the open source work and models. I dont know it well. Should I use the Llama finetuning script and instructions for defog/sqlcoder-7b-2? I see "llama" tag on the huggingface :)

Yup - the Llama finetuning script should work well!

@kasldsaknf  did you have a chance to establish a new finetuning on top of sqlcoder model using your own dataset? if yes please share your script/code.
Thank you.

@mellahysf I haven't fine tune sqlcoder over my own dataset. I think Llama's fine tune code should work. Did you meet some probelms now?

Yup - the Llama finetuning script should work well!

Thank you. I will try.


bair dataset error

I would like to ask about the version of tensorflow

I have the same problem, did you find a solution?

I haven't used the code in a while, but I found this in my old code. Please let me know if you find a way to make it work.
Version
Name: tensorflow
Version: 2.9.0+computecanada
Installation
pip install --upgrade pip setuptools wheel
cd /home/${user}/my_projects/mcvd-pytorch
pip install -r requirements.txt
pip install --no-index progressbar
pip install --no-index tensorflow ninja
pip install --no-index torch torchvision torchaudio
pip install --no-index imageio opencv-python
pip install --no-index psutil numpy
pip install gdown
pip install -U setuptools pip


fix: PodAntiAffinity rule

Summary
This PR fix an issue withPodAntiAffinity which is missing a podRole LabelSelector, therefore if other components such as Pooler saturates the Node availability and the PodAntiAffinity is set to required the cluster cannot be scaled/created.
Furthermore some tests have been added.
Additional Info
This PR fix #4293

This is basically a duplicate of #3346 (although this one includes some testing).
I'm happy though that this one gets some attention, as the issue is already stale for a few months, with an easy fix readily available. I'm not sure why the other one has not been merged yet.

Sorry, we didn't notice the PR at all 🤗 We found the bug report closed therefore we implemented a fix and referenced the PR in that issue.
I think the best course of action is to wait the maintainer 😊

Hello, any feedback on this?

Interested for this one to be merged as well :-)
And it looks pretty clean and simple ?
As of today we are forced to use some on the fly kyverno black-magic to alter yaml and deploy "safe" (as in: pods are placed on the correct workers) clusters with poolers.
Cheers

Interested for this one to be merged as well :-) And it looks pretty clean and simple ? As of today we are forced to use some on the fly kyverno black-magic to alter yaml and deploy "safe" (as in: pods are placed on the correct workers) clusters with poolers.
Cheers

Hum except that our initial kyverno idea is not applicable in this case...
So we are stuck with this situation where it's not possible to user poolers safely with cnpg clusters 😢

Superseeded by https://github.com/cloudnative-pg/cloudnative-pg/pull/5156


[apply_predicted_obj_type] adapt to autoware auto msgs

Description
fix PR
Review Procedure
check CI pass
Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Read pull request guidelines
[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@purewater0901 @tkimura4
can you review this PR ?


Add cusom range input control

Can you add custom <input type="range"> to v4.2?

Was just added yesterday! https://getbootstrap.com/docs/4.1/components/forms/#range :)

Hi @mdo, are you considering adding multi-range support? I think it's a super useful feature and key to many use cases. Maybe this tiny polyfill will do the trick.


Add missing configure dependency for SCC tasks

Recently added display_scc_* tasks are missing dependency on configure, and will fail when called without authentication previously done by another task.
This PR adds the missing dependency.
Steps to reproduce:

run rake clobber do discard temporary volumes
run rake display_scc_findings

The task will fail with auth error:
$ RAKE_REALLY_RUN_IN_PRD=true rake display_scc_findings
docker-compose run --rm xk rake display_scc_findings
Creating volume "gpii-common-prd-stepan-secrets" with default driver
Creating volume "gpii-common-prd-stepan-helm" with default driver
Creating volume "gpii-common-prd-stepan-gcloud" with default driver
Creating volume "gpii-common-prd-stepan-kube" with default driver
gcloud alpha scc findings list<PHONE_NUMBER>74 --filter 'state = "ACTIVE"'
ERROR: (gcloud.alpha.scc.findings.list) You do not currently have an active account selected.
Please run:

  $ gcloud auth login

to obtain new credentials, or if you have already logged in with a
different account:

  $ gcloud config set account ACCOUNT

to select an already authenticated account to use.
rake aborted!
...

@stepanstipl Nice catch!


Fix descriptor initialization

Hello!
I want to fix a typo in C code that leads to @descriptor is not initialized if calling WMQ::Message.new(...) with parameters.

Excellent catch, Thank you


init.groovy.d scripts not replaced/updated with changes

Jenkins is running happily, with jenkins home mounted outside the container on a network share.
When upgrading the docker image to a new version with some changes to the init.groovy.d scripts, the scripts do not get updated in the jenkins home.
Actual result
Old scripts are run.
Expected outcome
The scripts should have been replaced in the jenkins home folder, so the updated scripts runs.

Not relevant. Scripts work fine when creating a new container with a blank jenkins home
// Edit someone with the same issue:
https://stackoverflow.com/questions/45818327/jenkins-updating-init-groovy-d-files-in-a-docker-container

files that already exist are explicitly not overwritten to avoid overwritting UI changed configuration
https://github.com/jenkinsci/docker/blob/master/jenkins-support#L110

Ahh, I see now.  I also noticed that *.override condition.  If you look at the README, that appears to be the workaround.

In case you do want to override, append '.override' to the name of the reference file. E.g. a file named /usr/share/jenkins/ref/config.xml.override will overwrite an existing config.xml file in JENKINS_HOME.

solution provided

also see: https://github.com/jenkinsci/docker/issues/618


The dataset images in Break-A-Scene.

Hi, Thanks for your great work.
Could you release the dataset images or selection scripts from CoCO in our paper ?
As I heard in the paper, there are 5400 imges per baseline.

Hello,
I am also interested on this dataset. Is there someone publicly available? Can you provide me with a link?
Thanks a lot!!!

No, I don't get any dataset.

Hi,
I'm sorry but I have no longer access to the extracted COCO dataset.
Omri

Hello Omri,
Thanks for getting back so quickly.
Okay, I understand. Thanks for letting know!


Corretto 17 and 21 updates

Hi, thanks for maintaining Corretto. We just released new JDKs and see the updates in this auto update commit: https://github.com/ajshastri/chocolatey-packages/commit/c9bac3aa4570e3ec748e7d79cc5b9ba33b1d74da#diff-7c67e8c78e5d570de0628b739766492e8f4a57d11474c61726d7c22b73e42c00L4
However, for 17 and 21, it doesn't seem their versions are updated as 8 & 11 do (e.g.: missing changes to update the version number to <IP_ADDRESS>.1 in https://github.com/ajshastri/chocolatey-packages/blob/c9bac3aa4570e3ec748e7d79cc5b9ba33b1d74da/corretto-jdk-17/corretto17jdk.nuspec#L5 and https://github.com/ajshastri/chocolatey-packages/blob/c9bac3aa4570e3ec748e7d79cc5b9ba33b1d74da/corretto-jdk-17/tools/chocolateyinstall.ps1#L4)
This makes users not able to have the latest JDKs. What's more, the checksum for 17 & 21 updated while the urls haven't been updated. It's possible to make the checksum check to fail.
Could the team help check? Thanks.

@rgithubli There seems to be something weird about the feed. I'll have to redo how I do it, I am pulling data from two different sources which is not the best idea.
I've fixed the repo and pushed out the latest.
Thank you for catching this!


add logic to check for array in CardService.Where and to join using o…

…r if it is

Codecov Report

Merging #2 into master will decrease coverage by 0.97%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage      99%   98.03%   -0.98%
==========================================
  Files          21       21
  Lines         402      407       +5
  Branches       54       55       +1
==========================================
+ Hits          398      399       +1
- Misses          2        5       +3
- Partials        2        3       +1

Impacted Files
Coverage Δ

MtgApiManager.Lib/Service/CardService.cs
95.4% <33.33%> (-4.6%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc62baa...75e65a3. Read the comment docs.


Version 0.4.2 can't load in Windows x64

Fixed in https://github.com/damian-m-g/xlsx_drone_rb/commit/12d0e1df35d9fb86086fd908dc1ba1334c06a178.


include generated files

Some projects require the generated files to be present in a tree-sitter repository to use them. Noteably the helix editor is currently refferencing a fork of this grammar and therefore can not be updated to the newest version.
Please can we include the built files in the repo.
I've not included a Github Actions check to ensure the generated files are up-to-date, but am happy to add one if you'd like.
Thanks :)

nvim-treesitter would also like this to get merged! :)

I didn't want to add 94bdab2, but without it corepack was installing yarn v4

Our motivation for keeping generated files out of the repo is aligned with this explanation from the swift parser's maintainer.
Neovim doesn't need generated files at all; it can generate them itself. Please look at the installation instructions on the readme.
Regarding helix, I personally much prefer what the Swift parser did, which is to have a branch that is automatically updated with the generated files whenever the main branch changes. (via a GH action.)
Is anyone interested in implementing copying that here?

Neovim doesn't need generated files at all; it can generate them itself.

Well, that's not strictly true. The nvim-treesitter plugin can call tree-sitter to generate the parser before compiling it, but only if the user has the tree-sitter CLI installed (which is not a hard requirement since the vast majority of grammars do commit the parser).
And it is true that upstream recommends not committing the parser iff you make versioned releases which do contain all generated files. I (and upstream) strongly recommend against having a separate branch for that; that just creates confusion and additional work. (The swift parser is not a good model to follow in general; they have very specific needs and workflows.)
Even if you don't keep the parser in the repo, though, you should update and fix the files you do track (bindings, headers, an in particular the scanner includes).

Ok so we'll probably merge this, but we would like a GH action to ensure generated files are up to date. @aspeddro Pointed me to this example on the rescript-core repo. @FreddieGilbraith I'd like to take you up on your offer of adding the action, if you're still interested.
Just one question: Is it necessary to include the bindings? AFACT from looking at @ribru17's PR in nvim-treesitter, neovim doesn't need them. Is that the case for Helix too?
If not, we can generate the files with  --no-bindings and end up with smaller diffs.

nvim-treesitter needs no bindings (Helix might need the Rust ones, I don't know), but these of course are not the only consumers. I can't speak for any of them, though.

I've added a CI check, and a git hook script to make sure generation is as part of commits.
Looks like no one needs the bindings, helix seems to work without them :)

Thank you @FreddieGilbraith!!!


Vulkan testing

Latest commit added hooks that should let Vulkan titles work with it (eg. RDR2), I don't currently have any VK games to try with myself though, would appreciate anyone trying it out.
Build can be found here:
dlsstweaks-0.123.8.zip
If you try it out let me know how it goes, either here or on the reddit post: https://www.reddit.com/r/nvidia/comments/111e0xi/dlsstweaks_dll_hook_that_can_force_dlaa_onto/

Can confirm it works.

Nice, I've pushed that as a release then.
Not really sure how complete the VK hooks are though, could still be some VK titles that have issues, if anyone finds one feel free to shout at me here.

Also works in Doom Eternal for me.

Seems to be stable enough, I'll close this now then, if anyone does run into any issues with a vulkan game feel free to make a post about it.


Fix missing support for generic method implementation in GuardClauseAssertion

When trying to implement generic methods, GuardClauseAssertion was not adding generic parameters and their contraints.
For example, the following interface:
public interface ISomeInterface
{
    ...

    TResult GenericMethod<TValue, TResult>(TValue argument)
        where TValue : ICloneable
        where TResult : class, ICloneable;
}

... was throwing the following error: Method 'GenericMethod' in type 'ValueType5638d03332334b2b9d3caa1b60c1bf67' from assembly 'AutoFixture.DynamicProxyAssembly, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
The reason was that the emitted method did not have the same signature as the implemented interface.
This pull request intends to emit the same signature.

@frblondin Thanks for the fix!

@frblondin Yes, the MyGet feed is no longer in use, as we are not working on next major version ATM. I've just released a new version of AutoFixture, so feel free to take it from the NuGet feed 😉
Thanks again for your contribution!

Neat, thank you @zvirja


Adds rawMode to disable serializing localStorage values

We've been integrating cross-storage with a localStorage ecosystem that does not serialize its values; thus, we needed a way to use cross-storage that did not depend on serialization. This PR adds a configuration option to the client init called rawMode that will make getting/setting values not rely on serialization.
Another way to do this would be to use native ES6 classes and create a rawCrossStorageClient subclass.
See #21 for more.

+1

Bump! Just wanted to check on this. NPR Visuals has been using it in production for several months now.

+1 for this, fyi you left a console.log floating in there :)

Thanks for the PR! I've replied to https://github.com/zendesk/cross-storage/issues/21 I think what I'd rather see is the removal of serialization from cross-storage altogether

Thanks again! :)


several tests fail for openssl

To run an individual test (e.g. 01-test_sanity) with verbose, try:
make test TESTS=01-test_sanity V=1

Once built, you can also directly execute tests from the test directory, such as:
./sanitytest

This particular one is failing because the enums are of size 1 while int is of size 4.
[1] compared to [4]

@ejratl so - progress! I should have put down the list of failures here so we know how things are progressing... What do you think is the way to track these bugs? Just one issue that we update as fixes come in or should we spin off a few issues for the different problems?


Pub/Sub documentation improvements

I'm finding the documentation to be not the best (I didn't see anything about RetryPolicyOption on the web page that discusses error handling) and the only sample code I could find is a single file that executes all the functions.

There is an example on how to set the RetryPolicy and BackoffPolicy here:
https://googleapis.dev/cpp/google-cloud-pubsub/latest/classgoogle_1_1cloud_1_1pubsub_1_1Subscriber.html#details
Your comment does point out that this is not well motivated, it does not say why you may want to set it, or what it controls. And you are correct that this example is not surfaced in cloud.google.com/pubsub/docs.  It is very specific to C++, but we should figure out a way to put it out there.
There is also some missing documentation on the internals of the C++ Pub/Sub client library, something that gives you a sense of what resources are created by a pubsub::Publisher and/or pubsub::Subscriber.
Originally posted by @coryan in https://github.com/googleapis/google-cloud-cpp/issues/9171#issuecomment-1151627304

I will try to schedule this for 2023-Q1.

Duplicate of the Pub/Sub stuff in #10131.


[Parse] Separate compilation condition validation and evaluation

Fixes:
https://bugs.swift.org/browse/SR-3455
https://bugs.swift.org/browse/SR-3663
https://bugs.swift.org/browse/SR-4032
https://bugs.swift.org/browse/SR-4031
Now, compilation conditions are validated at first, then evaluated. Also, in non-Swift3 mode, && now has higher precedence than ||. (i.e. A || B && C || D are evaluated as A || (B && C) || D.)
Swift3 source breaking changes:

[SR-3663] This used to be accepted and evaluate to true because of short circuit without any validation.
#if true || true * 12 = try Anything is OK?
print("foo")
#endif

In this change, remaining expressions are properly validated and diagnosed if it's invalid.

Swift3 compatibility:

[SR-4031] Compound names are diagnosed as warnings in Swift3 mode.
Previously all of these are silently accepted:
#if BAR(_:)
#elseif os(x:)(macOS)
#elseif os(Linux(foo:bar:))
#endif

Now it's diagnosed with fix-it:
warning: ignoring parentheses in compound name, which will be rejected in future version of Swift
#if BAR(_:)
       ^~~~

In Swift4 mode, it's rejected.

[SR-3663] The precedence of '||' and '&&' are still the same, and keep the short-circuit rule of Swift3. The following code evaluates to 'true'.
#if false || true && false
print("foo")
#endif

@swift-ci Please smoke test

@swift-ci  Please smoke test

@swift-ci Please smoke test

Do we have tests that Swift 3 mode is unaffected by this change? If so, LGTM.

@bitjammer Thank you!
Since this PR contains source breaking change even in Swift3 mode,
I inserted a commit adding test cases in -swift-version 3 mode.
It passes with the current master.
You can see how this PR breaks Swift3 mode here
https://github.com/apple/swift/pull/7955/commits/ce6d7f1661e2694517f0ac81c5c614d4f7125955#diff-2ff9e652924c0aaf763b9ffdf4fabd94
If these breakage are unacceptable, please let me know.

@swift-ci Please smoke test

You might email swift-dev about it.

Thanks! @CodaFi
I renamed getNameStr to getDeclRefStr, and make it to return Optional<StringRef>.

@swift-ci Please smoke test

@rjmccall Please take a look

The Core Team believes this is a bug fix and it is acceptable to break strict source compatibility as long as the practical impact is low.
It would be nice to recognize improper precedence in Swift 3 mode and emit an a error with a fixit to add the proper parentheses.
Some people on the Core Team felt that you should add a warning about compound names.  I don't think this is actually necessary.

Today's core team meeting must've been pretty contentious, it went way over time until 11pm PST :-)

Thanks for discussing this!

It would be nice to recognize improper precedence in Swift 3 mode and emit an a error with a fixit to add the proper parentheses.

Sadly, parentheses can't help  😢
// test.swift
#if FOO || BAR && BAZ
  print("OK1")
#end
#if (FOO || BAR) && BAZ
  print("OK2")
#end
#if FOO || (BAR && BAZ)
  print("OK3")
#end

$ swift -D BAR test.swift
OK1

We can emit a warning without fix-it, but I didn't come up with a good message for that.

May the fix-it change the behavior in Swift3? If so, how about
warning: future version of have different rule for evaluating condition; add parentheses to make the condition compatible with Swift4
#if FOO || BAR && BAZ
    ~~~~~~~~~~~~~~~~~
           (         )

For || and &&, added warning with fix-it in Swift3 mode.
@swift-ci  Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

Implemented warnings for compound names in compilation condition in Swift3 mode.
Now,
#if FOO(_:)
#endif

is accepted with a warning.
test.swift:1:8: warning: ignoring parentheses in compound name, which will be rejected in future version of Swift
#if FOO(_:)
       ^~~~

@swift-ci Please smoke test

@rjmccall Any suggestion for warning messages?

@swift-ci Please smoke test

@rjmccall Friendly ping :)

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test source compatibility

Please anyone can review this?
I want to get this in Swift4 because this is source breaking change.

@DougGregor Can I ask you to approve this, as the code owner of Parse?

@bitjammer approved the early version, and @rjmccall said it's okay for Swift 4. @bitjammer, maybe you can look it over once more, and then @rintaro can land this?

Sure thing.

LGTM.

Thank you for this patch, @rintaro, and thanks for your patience in landing it.

Thank you! test again
@swift-ci Please smoke test


Containerization

Fixes #2.

docker run -p <IP_ADDRESS>:3000:3000 -v $HOME/tinkering/tuf-explorer-demo/repos:/etc/tuf-explorer/data/repos -v $HOME/tinkering/tuf-explorer-demo/helper:/etc/tuf-explorer/data/keyinfo tuf-explorer works except the "diff" tool because the .git is at $HOME/tinkering/tuf-explorer-demo/ and it doesn't end up mounted.

This works:
$ docker run -p <IP_ADDRESS>:3000:3000 --env TUF_EXPLORER_REPOS_KEY_INFO_DIR_SUFFIX=helper -v $HOME
/tinkering/tuf-explorer-demo:/etc/tuf-explorer/data tuf-explorer

The env is only required here because my tuf-explorer-demo data stores the key info data in a helper directory, not a keyinfo one.


How To Add Custom Helper / Library in App

Just Like Codeigniter or any other php framework, they have Helper / Library for custom function & library
function allowTags($text) {
    $tags = '

';
    return strip_tags(html_entity_decode(trim($text)), $tags);
}

for example I create multiple Controller and want to call the function allowTags() in any controller

@walkor , @passwalls , please I really need this feature. I would definitely donate this project soon

Webman currently does not strictly specify the location of custom function & library.
You can put your helper functions into for example app/functions.php.
And add line "./app/functions.php" in composer.json like this.
"autoload": {
    "files": [
      "./support/helpers.php",
      "./app/functions.php"
    ]
  },

Run command composer dump-autoload then the ./app/functions.php will be loaded automatically .
Make your class file conform to psr4 rules, and it will be loaded automatically.
For example app/common/User.php.
namespace app\common;
class User
{
}

It will be loaded automatically when it used.

Oh, Ok i got it. For temporary I will using composer psr4


Add SEI-Builder in the app-store

This is the SEI Builder pre-release app developed by prof. Chivazzo team (PTD)

wrong logo url


Create simple ArduinoBleOTA library

Thanks for Your fullstack solution (from esp32 to android app)! I have forked this repository in order to create PlatformIO Arduino library:
https://github.com/vovagorodok/ArduinoBleOTA
At the and will be nice to move it to: https://github.com/arduino-libraries
I'm trying to make it as simple as possible with reusing of NimBLE-Arduino and ArduinoOTA(support only WIFI) libraries. Proposed interface will be similar to ArduinoOTA:
#include <ArduinoBleOTA.h>
void setup() {
  ArduinoBleOTA.begin("ArduinoBleOTA", InternalStorage);  // or SDStorage or SerialFlashStorage
}

Or if bluetooth is used not only for OTA:
#include <ArduinoBleOTA.h>
void setup() {
    BLEDevice::init("MyBleDevice");
    auto* server = BLEDevice::createServer();
    ArduinoBleOTA.begin(server, InternalStorage);
    // add your BLE services here
    server->startAdvertising();
}

Additionally I have plan to add support of Atmel based boards using ArduinoBLE library.
I see that @Vincent-Stragier begin with that. Lets connect our forces and create easy library with simple/lightweight protocol.
Draft protocol proposal will have small number of commands (names and numbers can be another like 0x01 or 0xFE):
SIZE 1
PACKAGE 2
INSTALL 3
OK 4
NOK 5

Designations for examples:
-> - recived from phone
<- - send to phone
Sunny day scenario:
-> SIZE <size>
<- OK % open ota storage
-> PACKAGE <data>
<- OK
...
-> PACKAGE <data>
<- OK
-> INSTALL % full <data> size == <size>, apply binary
<- OK

Size to big:
-> SIZE <size>
<- NOK % do nothing

Connection terminated:
-> SIZE <size>
<- OK
-> PACKAGE <data>
<- OK
...
% termination
-> SIZE <size>
<- OK % reopen ota storage and write from scratch
...

Unexpected package:
...
-> PACKAGE <data> % full <data> size > <size>, close ota storage
<- NOK

Instalation error:
...
-> INSTALL % full <data> size < <size>
<- NOK

I thing that most/all corner cases are covered or something is missed?
@fbiego can you describe scenarios(corner cases) that  are currently covered with command names (because from code I see some magic numbers 0xFB, 0xFC, 0xFD, FE ..)?
What do you think generally about this idea?
Thanks!

@vovagorodok,
If you take a look at: https://github.com/fbiego/ESP32_BLE_OTA_Arduino/blob/fa90638f2997d7965880c2cd6aca1e9b05c83ba2/esp32_ble_ota_lib_compact/ota_updater.py#L26-L175
Reading the above, you will have a rough idea of how the process works (I'm using a slightly different method compared to the main code).
As you can see, no security mechanism has been implemented in the code. No pin code for the pairing, no checksum at the end of the upload, no version number hard-coded—sometimes, I had a version date and git version hash at compilation time, but not here —, etc. That could also be something to implement in your library.
I do not have much time to help you at the moment, but I like your idea, even if there are still some mechanisms to be thought.
Regards,
Vincent

Ok, just let me know if you find corner case or bug in my considerations. Will be nice to implement minimal working version and than extend it. For example checksum can be added in future by optional command:
-> CHECKSUM <checksum>
<- OK

before INSTALL command. And developer of mobile app will decide if send it or no. But lets consider it after basic implementation.
I am also interested in @fbiego's point of view

Hi,
New library created:
https://github.com/vovagorodok/ArduinoBleOTA
It has build in checksum integrity protection and software/hardware type/version protection.
Security/Authorization protection decided to not implement here, because it can be implemented as separate library (for whole bluetooth connection, not for one OTA service).
Library can be simply added to any project like this:
https://github.com/vovagorodok/ArduinoBleOTA/blob/main/examples/basic/main.ino
Or if there is any additional service:
https://github.com/vovagorodok/ArduinoBleOTA/blob/main/examples/multiservice/main.ino
Next steps:

Add new not ESP32 platforms (will be easy to add samd and other using ArduinoBLE library)
Increase upload speed. Now I have ~3kB/s. How You achieve ~12kB/s ?
Mobile application. Cirrently it updates only by 'updater.py' script. I'm not a mobile developer, some help/integration here will be nice

According to step 2.
Added to platformio.ini board_build.partitions = default_ffat.csv
and changed:
https://github.com/vovagorodok/ArduinoBleOTA/blob/061a7ed92c3d64daaddcc865f58a87c455e50823/src/ArduinoBleOTA.cpp#L159
to:
if (storage == nullptr or not storage->open(firmwareLength, 1)) // second parametr 1

it calls with U_SPIFFS:
https://github.com/JAndrassy/ArduinoOTA/blob/ebc6b6299d56813f8565434a10f6d6b978109043/src/InternalStorageESP.cpp#L39
And it should call esp_partition_find_first(...ESP_PARTITION_SUBTYPE_DATA_FAT...):
https://github.com/espressif/arduino-esp32/blob/2d6ca351a3b35fe0ce5d427a469e49ed7892c25a/libraries/Update/src/Updater.cpp#L139 \
But update speed is the same (3kB/s).
From:
https://github.com/espressif/arduino-esp32/blob/master/tools/partitions/default_ffat.csv
app0 and app1 (ota_0 nad ota_1 SubType) are another partitions, are they fat?
Are you doing special trick to make it works? Writing to ffat and copy to app0/1 ?

Step 1. Done. Added new (not esp32/NimBLE-Arduino lib) platforms like samd,megaavr,mbed,apollo3,mbed_nano,mbed_portenta,mbed_nicla based on ArduinoBLE library. Plans to add stm32 and other
Step 2. Done. Works fine with BLE_OTA_ATTRIBUTE_SIZE=512 and BLE_OTA_BUFFER_SIZE~=512 * 10. Can be tuned or buffer can be completely disabled in order to save static memory: https://github.com/vovagorodok/ArduinoBleOTA/blob/main/doc/ADVANCED.md
Step3.  Still open

I was referred  to this URL on BLE performance..
https://punchthrough.com/ble-throughput-part-4/
one reported 50k/sec thruput..


TypeScript: extendRoutes parameter routes possibly should be of type RouteConfig[]

Version
v2.6.2
Reproduction link
https://codesandbox.io/s/github/nuxt/nuxt.js/tree/dev/examples/named-views
Steps to reproduce
Te reproduction link is actually the example from the documentation as I really don't find the time to setup a TypeScript project for this. It's also not necessary to reproduce it. Looking at the types of vue-router and the non-TypeScript example should make things clear.
The code example for Nested Views shown in the Nuxt documentation shows how to use extendRoutes in the nuxt.config.js to access the children attribute of the parameter routes.
The parameter routes is of type Route[]. The type Route actually doesn't have a property children per typing definition. But the type RouteConfig.
https://router.vuejs.org/api/#router-construction-options
My assumption is, the parameter routes should be of the type RouteConfig.
What is expected ?
No TypeScript error when accessing routes[index].children in the nuxt configuration.
What is actually happening?
TypeScript error Property 'children' does not exist on type 'Route'.

This bug report is available on Nuxt community (#c9183)

@renestalder Thanks for finding this, it should be RouteConfig[] instead of Route[] here : , right ? https://github.com/nuxt/nuxt.js/blob/dev/packages/config/types/router.d.ts#L12

Yes, that's correct. But now I also found out that you probably extend the route here even further. chunkNames also seems missing and this is not an attribute of RouteConfig so it might even be a better solution to extend RouteConfig with a new type and add chunkNames (maybe there are also other additional properties I don't know about).
Example:
import { RouterOptions, Route } from 'vue-router'

interface NuxtRoute extends RouteConfig {
  chunkNames: {[key: string]: string};
}

export interface NuxtConfigurationRouter extends RouterOptions {
  routeNameSplitter?: string
  extendRoutes?: (routes: NuxtRoute[], resolve: (...pathSegments: string[]) => string) => void
  linkPrefetchedClass?: string
  middleware?: string | string[]
  prefetchLinks?: boolean
}

Maybe one would even find a way to property match chunkNames and components in TypeScript, excluding the components.default property, as I assume from the example they require to have matching properties to work.

@renestalder You're right for chunkNames (https://github.com/nuxt/nuxt.js/blob/dev/examples/named-views/nuxt.config.js#L12)
Could you open a PR with the changes from your snippet ? (You'll need to replace Route by RouteConfig in import statement and remove extra semicolon in NuxtRoute interface, furthermore I'd suggest NuxtRouteConfig instead of NuxtRoute). We should be able to bring this for next release (https://github.com/nuxt/nuxt.js/pull/5678)

@kevinmarrec Thank you very much for the quick fix. And also for the co-authoring credit. Very kind. I appreciate that.
Keep up the great work.


P4RT-3.1 PacketIn

This is PR for P4RT-3.1 PacketIn for GDP #73. For the P4RT client library, it will be moved to a new location later. Also it's using the wbb wrapper code which is still in PR and we will update this PR after wbb PR is in main.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.374%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1314

Relevant Lines:
1841

💛  - Coveralls

Hi @hariramnat , this is the PR for P4RT-3.1 PacketIn for GDP. The testcase is done with go-p4 client library which will be moved to new location later.

@hariramnat and @marcushines , thanks for helping check this PR. I have addressed the existing comments. could you please help check if other changes are required?

Hey Mingyang,
Could you also additionally post test run logs that we could access in some way to this PR?

Hey Mingyang,
Could you also additionally post test run logs that we could access in some way to this PR?

Hi @hariramnat , following is the logs for this testcase run.
=== RUN   TestPacketIn
    google_discovery_protocol_packetin_test.go:245:
        *** Pushing topology to <IP_ADDRESS>...

    google_discovery_protocol_packetin_test.go:245:
        *** Starting protocols on <IP_ADDRESS>...

    google_discovery_protocol_packetin_test.go:252:
        *** Creating P4RT client for DUT...

    google_discovery_protocol_packetin_test.go:257:
        *** Creating P4RT client for DUT...

    packetin_test.go:133:
        *** Starting traffic on <IP_ADDRESS>...

    packetin_test.go:133:
        *** Stopping traffic on <IP_ADDRESS>...

=== RUN   TestPacketIn/PacketIn_to_Primary_Controller
    packetin_test.go:162: Start to decode packet and compare with expected packets.
=== RUN   TestPacketIn/PacketIn_to_Secondary_Controller
--- PASS: TestPacketIn (175.05s)
    --- PASS: TestPacketIn/PacketIn_to_Primary_Controller (0.00s)
    --- PASS: TestPacketIn/PacketIn_to_Secondary_Controller (0.00s)
PASS

Hi @hariramnat @marcushines , could you please help check if additional changes required?

Hi @sezhang2 , thanks for helping check the PR and approving the PR. I don't have permission to merge PR or trigger gcbrun. could you please help on that?

Hi @sezhang2 , thanks for helping check the PR and approving the PR. I don't have permission to merge PR or trigger gcbrun. could you please help on that?

Merged

/gcbrun


fix: catching exceptions in process method

One exception (AttributeError) wasn't catched and the entire process was blocked. Now we catch all exceptions.

Actually this is still not solved. I think the issue has been introduced with PR #274. The problem is that trying to process ~100k queries (on Snellius), at a certain point the process get stuck, and no more data points are appended to the hdf5 files.
The error I was getting before modifying the code as in this PR was AttributeError: 'Chain' object has no attribute '_model'. Now I'm catching all the exceptions but this didn't fix the problem. My guess is that one of the threads used during the processing of the queries get stuck for some unknown reason, and the script never ends. It stops only when the time allocated on Snellius times out.
To reproduce: run 3D-Vac/src/3_build_db4/GNN/1_generate_features.py changing run_day variable. Note that with a sample dataset (1k data points) everything works perfectly and in the past I run the same script for 140k datapoints successfully. Either the pdb models have been corrupted for some reason, or the code is not handling anymore some kind of exception that was handled in the past. I'd really need your help here @cbaakman.

The error I was getting before modifying the code as in this PR was AttributeError: 'Chain' object has no attribute '_model'.

In the deeprank code, the 'Chain' class does have an attribute '_model'. So I really don't understand where this error comes from.
I cannot reproduce this error, since I don't have the data file 'BA_pMHCI_human_quantitative_only_eq.csv'. Possibly I need other files to reproduce the error too.
Where can I find these?

The error I was getting before modifying the code as in this PR was AttributeError: 'Chain' object has no attribute '_model'.

In the deeprank code, the 'Chain' class does have an attribute '_model'. So I really don't understand where this error comes from.
I cannot reproduce this error, since I don't have the data file 'BA_pMHCI_human_quantitative_only_eq.csv'. Possibly I need other files to reproduce the error too. Where can I find these?

sent via slack

sent via slack

Thanks! But it seems I also need pdb files and other files. Right now it prints:
Script running has started ...
Loaded CSV file containing clusters and targets data. Total number of data points is 100315.
0 PDBs found.
Selected 0 PDBs using CSV IDs (intersection).
Aligning clusters and targets data with selected PDBs IDs ...
Clusters for 0 data points loaded.
Targets for 0 data points loaded.
0 MHC PSSMs found.
Selected 0 MHC PSSMs using CSV IDs.
0 peptides PSSMs found.
Selected 0 peptides PSSMs using CSV IDs.
Verifying data consistency...
Adding 0 queries to the query collection ...
Queries ready to be processed.

sent via slack

Thanks! But it seems I also need pdb files and other files. Right now it prints:
Script running has started ...
Loaded CSV file containing clusters and targets data. Total number of data points is 100315.
0 PDBs found.
Selected 0 PDBs using CSV IDs (intersection).
Aligning clusters and targets data with selected PDBs IDs ...
Clusters for 0 data points loaded.
Targets for 0 data points loaded.
0 MHC PSSMs found.
Selected 0 MHC PSSMs using CSV IDs.
0 peptides PSSMs found.
Selected 0 peptides PSSMs using CSV IDs.
Verifying data consistency...
Adding 0 queries to the query collection ...
Queries ready to be processed.

OK, probably be best to wait for @gcroci2 then. She'll be back in office tomorrow.

sent via slack

Thanks! But it seems I also need pdb files and other files. Right now it prints:
Script running has started ...
Loaded CSV file containing clusters and targets data. Total number of data points is 100315.
0 PDBs found.
Selected 0 PDBs using CSV IDs (intersection).
Aligning clusters and targets data with selected PDBs IDs ...
Clusters for 0 data points loaded.
Targets for 0 data points loaded.
0 MHC PSSMs found.
Selected 0 MHC PSSMs using CSV IDs.
0 peptides PSSMs found.
Selected 0 peptides PSSMs using CSV IDs.
Verifying data consistency...
Adding 0 queries to the query collection ...
Queries ready to be processed.

You need to run the script on Snellius, then all the files are already in there.

The issue was one single data point (BA-248433) that was causing get_surface function from Bio.PDB.ResidueDepth (in deeprankcore.features.exposure, surface = get_surface(bio_model)) to run for indefinite time, likely because of an inner infinite loop.
I've handled it by using signal module, and raising a TimeoutError after 20 seconds if get_surface() doesn't come to an end. It isn't of course the cleanest solution, but I am already very happy to have understood the origin of this hellish bug that was causing the entire data generation to run forever.


support for external containers in network-mode

supersedes #966
Hi @steiler
what do you think about this approach, where a single container:<cont-name> instruction is used both for clab and non-clab managed containers.
Mainly I didn't want to introduce another string-based config param (external-container), and proposing to use a single container:<cont-name> instead, as it makes (I hope) things simplier for users.
One thing I changed here is the way we use container ID in filter string, before it was just cID, but Docker does not use exact matches for that value, instead it uses substring matches. To fix that I used a regexp-based string value to make sure that when we use GetContainer we are able to have exact match by the provided name

@hellt what would happen if a user has a container named "lab-1" in a clab topology & as an external entity at the same time?
It seems that the latter will take precedence, but this might not be intended or desired?

@LimeHat good call. I have changed the logic to check for internal containers first.
the mandatory prereq for making clab-scheduled container to be picked up is to use a startup-delay for a donor container, e.g.
topology:
  nodes:
    donor:
      kind: linux
      image: alpine:3
    node1:
      kind: linux
      network-mode: container:donor
      startup-delay: 2
      image: alpine:3

as otherwise donor might not have enough time to deploy

What if we would provide, as a pre-step to any deploy action some struct to the runtime, that it knows which containers are part of the topology. This struct also holds a status, which is managed by the runtime itself. And it could go and do dependency checking itself, start the container when all the internal dependencies are finally started and therby you'd get rid of the sleep timer / start delay foo.
first thought about injecting that list into the container start, but there we are too deep already in the deployment of just a single container, but finally pushing that into the runtime seems to even make more sense to me.
Thought?

@steiler I like the idea, and had a thought about it when looking at this PR. But I am not so sure it is runtime business.
I think maybe it is better to look at scheduling function that we have rudimentary support for.
For instance, right now we have two queues - static IP and dynamic IP nodes which are scheduled one after another to guarantee, that nodes with static IPs are created first, and then dyn IP nodes go in.
https://github.com/srl-labs/containerlab/blob/main/clab/clab.go#L165-L192
and it looks like it would be great to have a more feature rich scheduler package that will take care of all the dependencies. Maybe even creating a graph of nodes that we can use for deployments...
But we got carried away here :D
@steiler If you don't have objections to this current impl, I am willing to merge it and carve out a release.

Interesting, first time I hear of that scheduler.
Yes, it sounds like it belongs even there.
Anyways this PR seems fine so far.


Grafana alerts

Adding alert rules to grafana dashboard for server/worker restart, task error rate and task hanging.

resolves #815

LGTM


opentelemetrytracer: Allow sampler to set variant type span attribute…

Commit Message: Allow sampler to set variant type span attributes
Additional Description: The opentelemetry sampler interface allows a sampler to add span attributes. The current Envoy implementation has the limitation that only string attributes are allowed.
In https://github.com/envoyproxy/envoy/pull/32333 a dependency to Otel C++ API was added. This enables us to use the same type for attributes as Otel C++ SDK does.
Risk Level:
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes: Allow sampler to set variant type span attributes
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

CC @wbpcode some quality of life improvement :)


Falcon routes

I'm wondering how do I implement routes like theses

Do I have to create object for each routes?

I miss the ability to use @route('/resource/{x}') decorator.

Seems like you are looking for something like https://github.com/stratoscale/hammock.

Hi @davidtavarez, it looks like you have the following REST resources:

Park collection
Park item
Trail collection
Trail item
Map
Reservation collection
Reservation item

etc.
Each of these resources would be represented by a class and implement the HTTP methods that it supports. There's an open issue for implementing a way to combine the "collection" and "item" resources into a single class, if desired. Everyone's feedback is welcome: #584


Batch requests

Nice !
Could you please add a spec for when 2 requests are batched, because here you only have 1 or 2 in 2 requests, no 2+ in 1 requests.

Yes, I thought about doing that but never actually did it, good point.

Seems great otherwise. Promise all the things !

I just added this new spec

Cool :)

This has been merged


Add affiliations to joss paper

Related to issue #223

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   73.46%   73.46%
=======================================
  Files          14       14
  Lines        3652     3652
=======================================
  Hits         2683     2683
  Misses        969      969

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aad16...866b8e2. Read the comment docs.

@raphaeltimbo is your affiliation as 'Petrobras - Petróleo Brasileiro S.A.' okay?

@raphaeltimbo is your affiliation as 'Petrobras - Petróleo Brasileiro S.A.' okay?

:+1:


drivers: ethernet: stm32: Enable multicast address filter

Use the MAC's hash table to filter incoming multicast frames that are
targeted to subscribed multicast groups and discard all others.
Signed-off-by: Markus Fuchs<EMAIL_ADDRESS>

Please wait until today evening, I'll do the review. There are many places, needed to be changed.

@mrfuchs Do you plan to continue this PR ?

Hi @mrfuchs, @erwango, @jukkar, @Nukersson,
We're interested in ensuring that this PR gets merged in and we're more than happy to continue the work that @mrfuchs left off and address review comments and also do testing etc.
Our current priority is to integrate https://github.com/zephyrproject-rtos/zephyr/pull/45770. With time we will look into getting the multicast hash filter going for the STM32H7 since its an absolute must for our application because we rely on a lot of multicast. Our devices have to be robust on networks without a managed switch and with large amounts of multicast (e.g. 60% of total available bandwidth).
What I wasn't sure was given that the work was started by @mrfuchs, what is involved in for us to come in and continue the work. If it was within an organisation (e.g. company) then the process is quite clear. In the case of opensource I wasn't sure. I also wanted to ensure that handover happens quite cleanly and transparently.

@cperera-aud you can take the code and enhance it where needed, then just re-submit it. Just remember to leave any existing copyright notices and signoff-by to existing code, and add your own copyrights/signoffs where applicable.

For reference: https://docs.zephyrproject.org/latest/contribute/guidelines.html#notes

@cperera-aud, happy to hear you want to help getting this PR merged.
As @jukkar suggests, just take my code and enhance it where needed.
As for the remaining change requests, six of them suggest to introduce a new option CONFIG_ETH_MULTICAST_FILTER which - from my point of view - would classify this patch as an enhancement.
I always looked at these changes as a fix, see the message of the driver's second commit ad8f837 and the corresponding discussion in PR #538).
The two requests to remove the loops over the multicast addresses in the net_if_mcast_cb() callback can't be right. Changing the code as suggested would mean multicast addresses can only be added, but never removed.
If you've more questions, I'm happy to help.

Thanks @jukkar and @erwango for getting back and providing the information and links. Sorry it seems like I missed the info on contributing to existing PRs.

Thanks @mrfuchs for replying and providing your thoughts. I will humbly mention that I will be unbiased in providing my thoughts while also acknowledging your hard work.
For starters regarding the kconfig option CONFIG_ETH_MULTICAST_FILTER I don't have a strong opinion and I do see advantages on disadvantages on both sides of the argument. Looking at other equivalent ethernet drivers in zephyr/drivers/ethernet they don't seem to use this config option. Also having the multicast hash filter on all the time is certainly a good thing.
On the other hand by having this config option allows the flexibility to turn off and turn on the feature at compile time. While I was working on our application, when the device was receiving low rate multicast e.g. mDNS, UDP/IP PTPV1 not having the multicast hash filter was not an issue. When our application started to support multicast at higher rates e.g. networked audio the need for the multicast hash filter was more apparent. Sorry I'm not sure in this instance who should have the final say on this matter any help to move this forward would be greatly appreciated. I understand that you mentioned then this PR should be an enhancement as opposed to a bug fix, then is there anything that has to be done to turn the PR into an enhancement?
In the case of the loop, again without being biased, I tend to agree with @jukkar on this one, because normally we should be adding one address at a time to the hash. Also I think we need to add some additional code for the case of removing entries from the multicast hash filter. We have a similar implementation for the STM32F4 series (proprietary implementation) but on a FreeRTOS/LWIP platform and in that case we add one multicast address at a time and remove one address at a time. e.g (just a guess).
hash_table[hash_index / 32] &= ~(1 << (hash_index % 32));
Please let me know how to best move forward with the PR.

we add one multicast address at a time and remove one address at a time. e.g (just a guess).
hash_table[hash_index / 32] &= ~(1 << (hash_index % 32));

Wouldn't this remove multiple addresses from the hardware filter in case of a hash collision?

we add one multicast address at a time and remove one address at a time. e.g (just a guess).
hash_table[hash_index / 32] &= ~(1 << (hash_index % 32));

Wouldn't this remove multiple addresses from the hardware filter in case of a hash collision?

Thanks @mrfuchs for getting back. So in your change by looping through all the multicast addresses regardless of them being IGMP joined or not was to avoid this scenario?

Hi @mrfuchs I take back my comment regarding the method for updating the multicast hash filter for removing multicast addresses. It certainly is better to build the entire hash table by looping through the addresses that have joined. For adding a multicast address it really isn't necessary to rebuild the hash table.


Move SonarLint line from JetBrains.patch to JetBrains.gitignore

This makes the SonarLint ignore also appear in derived templates.
Pull Request

[X] Template - Update existing .gitignore template

If you want to move this, you need to commit it to the github/gitignore repository.

After reading your blog post on why this repository exists (BTW: The SSL certificate is broken) I get you. However, if I was to edit the github gitignore file, I would have to be able to explain why this is sensible and I can't. I just noticed that the "IntelliJ" and "IntelliJ+iml" templates differ for no obvious reason and fixed that. Someone who knows about SonarLint should probably take the "JetBrains.patch" from dvcs/gitignore to github/gitignore.

It appears that it is not included in all JetBrains derived templates.


error with train_network

hello mates , first of all thanks alot dev for this awesome work,i was getting this error when running train_network.py if anyone could help me with this

thanks alot it worked


Added maidenhead readout

I wrote a new function specifically to calculate extended maidenhead squares on Bangle.js, and added it here because I like the functionality of this app better than hamloc.
Most maidenhead calculators use only 6 characters of precision, which is only enough accuracy to determine a rough neighbourhood. That's fine for HF comms, but VHF can make use of extended accuracy. Eight characters brings that down to about a block, which is enough to meet someone when driving or on foot and sharing locators over radio. Ten would point at one building, and I may expand to that in the future.

Nice - thanks!


Invert colors in tearsheet container

closes #1259
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Few comments after testing -

Still showing both Cancel button and X icon in tearsheet

Primary tabs need to be sticky (condition_paramDef.json "Selects" tab scroll down to the end, primary tabs don't show)

When clicked on "Edit" icon in table row, modal opens up with no left padding

When I change value in dropdown in table row, it shows different background for newly selected value ("date" has different background) -

After filtering all columns in fieldpicker table, it shows some white background -

When I hover over table row, hover color looks same as table header -

In DisplayRows_paramDef.json subpanel, there's grey background behind Add and remove rows buttons -

Expression control in subpanel has white background same as subpanel background -

Still showing both Cancel button and X icon in tearsheet
Primary tabs need to be sticky (condition_paramDef.json "Selects" tab scroll down to the end, primary tabs don't show)

These will be done in a separate issue: https://github.com/elyra-ai/canvas/issues/1278

When clicked on "Edit" icon in table row, modal opens up with no left padding

This is the same behavior for container type Modal. Separate issue opened to fix this: https://github.com/elyra-ai/canvas/issues/1280

When I hover over table row, hover color looks same as table header

These are using the Carbon tokens, those are actually different colors. I will double check if the correct tokens are applied here

After filtering all columns in fieldpicker table, it shows some white background
In DisplayRows_paramDef.json subpanel, there's grey background behind Add and remove rows buttons
Expression control in subpanel has white background same as subpanel background
List control doesn't have left and right borders

Thanks for catching these, will fix in this PR

Nested Summary panel isn't showing up correctly. Since tearsheet doesn't show summary panels, maybe this is expected?

Yes this is expected

Truncated Sub tabs don't show tooltip

I see there is a tooltip for this, is this what you were referring to?

Truncated Sub tabs don't show tooltip

@nmgokhale

After filtering all columns in fieldpicker table, it shows some white background
Expression control in subpanel has white background same as subpanel background

These were previously fixed, can you try again after rebuilding common-canvas?

In DisplayRows_paramDef.json subpanel, there's grey background behind Add and remove rows buttons
List control doesn't have left and right borders

I just pushed a fix for these

Truncated Sub tabs don't show tooltip

You can ignore these as this problem existed before. Since we are moving to use left nav, this will change completely


feature: handle actions with conditions

The current version of action (0.2.7) ignores the conditions in external actions.
It is better to add the new feature to handle conditions.
An example of action with condition in file action.yml. Action<EMAIL_ADDRESS>runs:
  using: 'node12'
  main: 'dist/setup/index.js'
  post: 'dist/cache-save/index.js'
  post-if: success()

Done


enable hpa-values.yaml test in helm charts e2e test in CI

@daisy-ycguo CI needs Prometheus for testing hpa-values.yaml:  https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#prometheus
Otherwise Helm install fails due to missing serviceMonitor and custom metrics Kubernetes APIs.
As to testing that the HPA rules actually work, there's a manual step needed for installing the required custom metric config.  That part can be scripted in few lines, shown here: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#post-install
TGI and TEI services enabled their metrics enpoints only after processing their first request.  I.e. verifying that that HPA can access the relevant custom metrics, requires uploading doc(s) with data-prep so that reranking is used, and doing at least one ChatQnA query.  Then HPA can be verified to be working:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#verify


[Backport 1.3] Preserve URL Hash for SAML based login with Tests

Signed-off-by: Stephen Crawford<EMAIL_ADDRESS>Description
Manually backports SAML tests and updates from recent commits into 1.3.
Why these changes are required?
Resolves requests in #1219 discussion.
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@scrawfor99 Could you look into the build/integration test failures?

Update on the test failures: So looking at the errors, it seems that there is a versioning issue with the Cyprus tests that are called since the changes from the tests come from 2.4. I am looking through the different dependencies to try to find what needs to be switched. The error you get is ```
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=12". Got "10.24.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: /opt/hostedtoolcache/node/10.24.1/x64/lib/node_modules/yarn/bin/yarn.js install --non-interactive
at makeError (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:25139:11)
at handlePromise (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:24074:26)
at process._tickCallback (internal/process/next_tick.js:68:7)
error Command failed with exit code 1.

During the run yarn step.

Right now there is not a direct dependency on samlp. It is only on the saml-idp library which is dependent on a forked version of samlp: https://github.com/mcguinness/node-samlp/commits/master. I think we could maybe fork the saml-idp library and then swap the dependencies of it to the normal samlp and move it back (it is referencing an almost identical fork of samlp) but want to check and see what you think first.

Closing in favor of #1226


[RUMM-3449] Add sample rate to reported RUM events

What does this PR do?
Adds the configured RUM sample rate to all reported RUM events.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1566 (72ec105) into develop (08ec188) will increase coverage by 0.11%.
The diff coverage is 98.00%.

@@             Coverage Diff             @@
##           develop    #1566      +/-   ##
===========================================
+ Coverage    83.19%   83.30%   +0.11%
===========================================
  Files          437      437
  Lines        14750    14777      +27
  Branches      2223     2224       +1
===========================================
+ Hits         12271    12309      +38
+ Misses        1889     1885       -4
+ Partials       590      583       -7

Files Changed
Coverage Δ

...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt
80.19% <83.33%> (-8.05%)
:arrow_down:

...ndroid/rum/internal/domain/scope/RumActionScope.kt
97.48% <100.00%> (+0.05%)
:arrow_up:

...roid/rum/internal/domain/scope/RumResourceScope.kt
95.54% <100.00%> (+0.10%)
:arrow_up:

...droid/rum/internal/domain/scope/RumSessionScope.kt
95.45% <100.00%> (+0.05%)
:arrow_up:

...d/rum/internal/domain/scope/RumViewManagerScope.kt
96.97% <100.00%> (+0.09%)
:arrow_up:

.../android/rum/internal/domain/scope/RumViewScope.kt
95.40% <100.00%> (+0.08%)
:arrow_up:

... and 16 files with indirect coverage changes


[chore] general code imporvements

do some imports formatting
remove unnecessary passes
remove unnecessary parentheses in if conditions
remove if __name__ == "__main__" block since even if the user run the inner script directly, they will get nothing, but this deletion depends on you. It's just my personal opinion.

Perhaps you mean else instead of finally? Since finally means whether it succeeds or not, it will print the message.

Yes, I should use else here originally, it might be me when testing something else with finally and I remove the wrong code eventually


POC: Handle std names and aliases (#5257)

🚀 Pull Request
Description
This is a "proof-of-concept" PR to address how to better handle standard name aliases. It consists of the following elements:

Reorganising the iris.std_names.py a bit to have a separate dict for aliases (via updated tools/generate_std_names.py).
It now includes some table version information (mentioned in  #5255), and a separate dict for the standard name descriptions (optional when generated).
Adding a new std_name_table.py containing the following functions:

get_convention -- return a tentative Conventions string
set_alias_processing -- define how to handle aliases:
"keep" - current behaviour, treat aliases in the same way as currently valid standard names,
"warn" - issue a warning (default), otherwise as "keep",
"replace" - silently update aliases to current standard names.
get_description -- return the standard name description if available
check_valid_standard_name -- check if a name is a standard name or an alias, and do the translation if requested as defined by set_alias_processing

std_name_table is [naively] imported in iris.__init__
common/mixin._get_valid_standard_name is modified to use check_valid_std_name

No units test have been added (would be good to first get some feedback whether this POC is a reasonable approach .... )

Consult Iris pull request check list

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@SciTools/peloton is this still alive issue, and if so could you sign the CLA @larsbarring ?

I thought I had already signed the CLA because of one or two previous minor contributions. Anyway, now done. Whether it is alive or not I am not sure. I have not made any further effort since back then as I am not sure whether it is a reasonable approach in the context of Iris.

I thought I had already signed the CLA because of one or two previous minor contributions. Anyway, now done. Whether it is alive or not I am not sure. I have not made any further effort since back then ...

Ok thanks!

I am not sure whether it is a reasonable approach in the context of Iris.

Well, I guess we'll take a look + see about it
@larsbarring are you at least clear that something like this would still be useful ?

Yes, I think that this would still be useful. In the context of CF an aliased standard name is typically regarded as deprecated. Software should be able to read data having an aliased standard name, but new data should use the replacement name. Obviously, there are judgements to be made here regarding how to deal with this in practice. But and aliased standard name should not be considered just as an alternative at the same level as standard name.
Also, note that there will likely be some minor changes to the standard name xml file format as of next version, possibly also backported to all previous versions.

A proper way to handle standard name aliases would also be useful for ESMValTool, see https://github.com/ESMValGroup/ESMValCore/issues/1985.

@LisaBock this may be of interest to you.

@SciTools/peloton  We are planning to talk about this on the 3rd July.


Regenerate certs

They're already expired and tests fail because of that. I generated them with the same parameters except for 10 years expiration date
openssl x509 -in tests/jest_test_client_cert.pem -text -noout
Certificate:
    Data:
        Version: 1 (0x0)
        Serial Number:
            f4:8f:eb:41:0c:9c:5b:27
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=AU, ST=Some-State, O=Internet Widgits Pty Ltd, CN=localhost
        Validity
            Not Before: Oct  7 04:32:23 2019 GMT
            Not After : Oct  4 04:32:23 2029 GMT
        Subject: C=AU, ST=Some-State, O=Internet Widgits Pty Ltd, CN=localhost
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (4096 bit)
                Modulus:
                    00:c0:b7:4b:e2:8e:11:fe:f3:33:64:02:93:b3:90:
                    ....

Pull Request Test Coverage Report for Build 20

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 17:
0.0%

Covered Lines:
678

Relevant Lines:
678

💛  - Coveralls


Not updating the binded data

I have a code in my template:
<markdown>{{ text }}</markdown>
And when the text is changed in the model it is not updated in the view.
If I do not put <markdown> there then everything works fine.
Am I doing something wrong or this is just not supported?
Is there any other way to achieve what I want to do using this library?

@kp-visla Maybe I don't understand what you need. But if you looking for using expressions with markdown it should work fine.
https://plnkr.co/edit/haatIMLjfA0VbGeN4lGm?p=preview
update
app.model.ts
//our root app component
import {Component, NgModule} from '@angular/core'
import { BrowserModule } from '@angular/platform-browser'

// import angular2-markdown module
import { MarkdownModule } from 'angular2-markdown';

@Component({
  selector: 'my-app',
  template: `
    <markdown>
      {{md}}
    </markdown>
  `,
})
export class AppComponent {
  constructor() {
    this.md = `## Marked content`
  }
}

@NgModule({
  imports: [BrowserModule,MarkdownModule.forRoot()],
  declarations: [AppComponent],
  bootstrap: [AppComponent]
})
export class AppModule {}

@dimpu Thank you for the answer. But if the value of the md is changed later (after the view is rendered) would it be updated? It's not working for me.

@kp-visla It's against angular architecture We can't do that instead of that you can do data binding with data attribute.
//our root app component
import {Component, NgModule} from '@angular/core'
import { BrowserModule } from '@angular/platform-browser'

// import angular2-markdown module
import { MarkdownModule } from 'angular2-markdown';

@Component({
  selector: 'my-app',
  template: `
    <markdown [data]="this.md">

    </markdown>
  `,
})
export class AppComponent {
  constructor() {
    this.md = `## Marked content`;

    setTimeout(()=>{
      this.md = `aravind`
    },2000);

  }
}

@NgModule({
  imports: [BrowserModule,MarkdownModule.forRoot()],
  declarations: [AppComponent],
  bootstrap: [AppComponent]
})
export class AppModule {}


Feature/enable molecule ansible linting

This PR follows in the steps of https://github.com/sensu/sensu-ansible/pull/159 and enables yamllinting for all files across all test suites. I've gone ahead and fixed up the huge pile of spacing issues in this repo and locally everything is looking good.

Woohoo, all tests pass! \o/