GitHub Action Not Publishing Release to PyPi

The problem
After a successful Pull Request, the GitHub Action triggers python-semantic-release as expected. A new release is created with the correct version number, however it is not published to PyPi.  At the beginning of the Github Action, a warning appears which did not show up before:
Warning: Unexpected input(s) 'repository_username', 'repository_password', valid inputs are ['entryPoint', 'args', 'root_options', 'directory', 'github_token', 'git_committer_name', 'git_committer_email', 'ssh_public_signing_key', 'ssh_private_signing_key', 'prerelease', 'prerelease_token', 'force', 'commit', 'push', 'changelog', 'vcs_release', 'build_metadata']

Expected behavior
New release should be automatically published to PyPi.

# Basic workflow for building and testing the pip installation

name: CI

on:
  push:
    branches: [ main, develop ]
  pull_request:
    branches: [ main, develop ]

  workflow_dispatch: # Allows you to run this workflow manually from the Actions tab

jobs:

  Quality:

    runs-on: ubuntu-latest
    strategy:
      matrix:
        python-version: ['3.10', 3.11]
    steps:
      - uses: actions/checkout@v3
      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v3
        with:
          python-version: ${{ matrix.python-version }}
      - name: Install Python poetry
        uses<EMAIL_ADDRESS>        with:
          poetry-version: 1.5.1
      - name: Configure poetry
        shell: bash
        run: python -m poetry config virtualenvs.in-project true
      - name: View poetry version
        run: poetry --version
      - name: Install dependencies
        run: |
          python -m poetry install
      - name: Lint with flake8
        run: |
          # stop the build if there are Python syntax errors or undefined names
          python -m poetry run flake8 . --exclude .venv --count --select=E9,F63,F7,F82 --show-source --statistics
          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
          python -m poetry run flake8 . --exclude .venv --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
      - name: Test with pytest
        run: |
          python -m poetry run coverage run -m pytest
          python -m poetry run coverage report -m
          python -m poetry run coverage xml
      - name: Upload coverage report
        uses: codecov/codecov-action@v3
        with:
          files: ./coverage.xml

  Release:

    needs: Quality
    # https://github.community/t/how-do-i-specify-job-dependency-running-in-another-workflow/16482
    # if: github.event_name == 'push' && github.ref == 'refs/heads/main' && !contains(github.event.head_commit.message, 'chore(release):')
    if: github.ref == 'refs/heads/main'
    runs-on: ubuntu-latest
    concurrency: release

    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - name: Python semantic release
        uses: relekang/python-semantic-release@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          repository_username: __token__
          repository_password: ${{ secrets.PYPI_TOKEN }}

Additional context
Project: xeofs
Action without publishing: https://github.com/nicrie/xeofs/actions/runs/5632961260/job/15261422367
Note the last release before the most recent one was successfully published to PyPi. You can find the corresponding action here

Hi @nicrie - it looks as though that last release was a couple of weeks ago, and you're still using master for workflow - we've released a new major version which has some significant changes. To get your existing workflow running, you should change:
      - name: Python semantic release
        uses: relekang/python-semantic-release@master

to
      - name: Python semantic release
        uses<EMAIL_ADDRESS>
When you're ready to upgrade your project to use the new version, you can relax your version constraint to:
      - name: Python semantic release
        uses: relekang/python-semantic-release@v8

Thank you for the prompt response! I'll delve into this by the week's end and keep you posted on the result

A quick follow-up question: is there any difference between
uses: relekang/python-semantic-release@v8

versus
uses: python-semantic-release/python-semantic-release@v8

?

No worries - the repo's moved to the python-semantic-release GitHub org, so the former redirects to the latter

I tried migrating to v8 following the documentation but python semantic release workflow fails with the following error
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push ***github.com/nicrie/xeofs.git main
  stderr: 'remote: Permission to nicrie/xeofs.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/nicrie/xeofs.git/': The requested URL returned error: 403'

There are a lot of hits in Google related to that, but I admit it is a bit confusing to me. From what I understand it is related to writing restrictions, but - as shown in the 'how to migrate to v8' section of the documentation - I added
    permissions:
      id-token: write

to the Github Action workflow.
The Action permission within the repository are the following

Any ideas what goes wrong here?

I had the same problem that the bot could not push to the repository.
I figured that the solution is to set the permissions like this:
permissions:
      id-token: write
      contents: write

This is described in the documentation Automatic release -> Setting up python-semantic-release on GitHub Actions but not in the migration guide there the contents: write is missing.


combination doesn't work

Hi great setup,
everything works great except for the send of shortcuts, e.g.:

D;42\n D;58\n D;38\n U;42\n U;58\n U;38\n

is not registered from the host as [Shift] + [Caps_Lock] + [l]
Any suggestion how to solve that problem ?
Tested under Windows, ChromeOS and with direct serial communication to the ESP32 with ArduinoIE

Hi. I think there is a problem with the arduino serial monitor (and line breaks).
The easiest solution for you is change
message = Serial.readStringUntil('\n'); to message = Serial.readStringUntil('#');
then you can use:
D;42#D;58#D;38#U;42#U;5#U;38#
Tell me if it works for you! I tested here and it worked


forkproxy: prevent zombies

When I originally introduced forkproxy we pretty quickly ran into a zombie
problem because of interactions between the C "runtime" and the Go runtime,
quote:

Usually we should wait for the child process somewhere here.
But we cannot really do this. The listener file descriptors
are retrieved in the go runtime but at that point we have
already double-fork()ed to daemonize ourselves and so we
can't wait on the child anymore after we received the
listener fds. On the other hand, if we wait on the child
here we wait on the child before the receive. However, if we
do this then we can end up in a situation where the socket
send buffer is full and we need to retrieve some file
descriptors first before we can go on sending more. But this
won't be possible because we're waiting before the call to
receive the file descriptor in the go runtime. Luckily, we
can just rely on init doing it's job and reaping the zombie
process. So, technically unsatisfying but pragmatically
correct.

Removing the double-fork in 8e461e015c24 ("lxd/forkproxy: Switch to using
subprocess") meant that the child process didn't get reparented to init which
means it doesn't get cleaned up and hangs around as a zombie.
There are multiple solutions to this:

Ignore SIGCHLD in some form e.g. via signal() or sigaction().
Create a go routine in the parent process that waits.
Create a detached pthread() that waits.

Solution number 1. likely won't work because I expected Go to mess with signals
once the runtime kicks in; especially with SIGCHLD. Even if it didn't I
wouldn't want to rely on it not changing in the future.
Solution number 2. is doable but means more code and we'd need to transfer the
child PID to the go runtime which is fine but seems conceptually odd since the
process got created in pure C.
So solutioon 3. it is.
Link: https://discuss.linuxcontainers.org/t/forkproxy-child-process-hangs-after-adding-proxy-device-to-a-container
Fixes: 8e461e015c24 ("lxd/forkproxy: Switch to using subprocess")
Cc: stable-4.0
Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

This solution actually has a glaring flaw related to namespaces.

This solution actually has a glaring flaw related to namespaces.

This solution actually has a glaring flaw related to namespaces.

Fixed.

This solution actually has a glaring flaw related to namespaces.

Fixed.


--ini error conditions

This change raises exceptions on these conditions:
- an explicitly defined (non-default) ini file
does not exist
- a config option found in a loaded ini file
does not correspond to a config.Option
Add SimplConfigException and SimplConfigUnusedIniOption
SimplConfigUnusedIniOption will be thrown if an ini file is
explicitly specified, but there are options in it that have
no match, i.e. no corresponding config.Option
Previously, if these conditions occurred, nothing would happen. @Gifflen spent quite a long time trying to figure out why the options defined in his ini file were not getting picked up by simpl.

Thanks for the thorough review @ziadsawalha. I think I've addressed all comments, let me know.

:+1: - last two comments are minor.


Videos generated are not playing second time in FireFox untill refresh

Description
Videos generated are not playing second time in FireFox untill refresh
Steps to reproduce
Record a video and save in some path, now in added the src for video tag and tried to play the video. For the very first time the video played good and when we try to replay clicking the play button it does not play and buffer circle was shown.
Results
Expected
Please describe what you expected to see.
Actual
Please describe what actually happened.
Error output
If there are any errors at all, please include them here.
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
what version of videojs does this occur with?
browsers
FireFox
OSes
Mac OS

@achyuth8121 can you show me an example that reproduces this issue? Also include the Firefox and OSX versions please.

Fireofx version : 47.0.1
Mac OSX Version 10.9.5
Attached is the sample audio-video recorded file.
SampleGeneratedVideo.zip
Below is the code i am using for playing the recorded video. (We need to specify the path of the video saved in src).

I have attached a screen shot of the buffering circle.

Thanks in Advance.

Yes I have this problem too. Once webm is saved and then served in src of video tag, Firefox for some reason cannot replay it. I tried same setup with another webm sample and it was working, so something is wrong with recorded webm. This is reproducible on https://www.webrtc-experiment.com/RecordRTC/ (once recorded and in another tab video will play only once), so this is RecordRTC problem and not videojs-record related.

Created ticket in recordrtc, I think this ticket can be closed: https://github.com/muaz-khan/RecordRTC/issues/145

This issue is now solved on Firefox 48

Thanks for update. Any reference to ticket,/changeset for that?

This one I think:
https://bugzilla.mozilla.org/show_bug.cgi?id=657791

@ignl would be good to have a table in the documentation describing known and fixed issues per browser like this one.. ;)

Maybe it's better to move documentation to the wiki as it's easier for anyone to add notes etc?

@ignl with github you can edit repository files just as editing a wiki page.

Yeah I don't have much experience with that but as I understand I fork whole repo then need to create pull request or smth like that? Too complex for a few lines of documentation change. Wiki is better for that :)

@ignl no, you browse to the file you want to edit and then press the 'edit' button and inside the browser you can make edit the document. Press save and it will make a fork and PR for you.

OK


[NextPluggableDevice] Enable pjrt tensor buffer for npd

This PR is enabling PjRtTensorBuffer feature for NextPluggableDevice

@jyingl3, Can you help to have a review? thanks

@jyingl3, Can you help to have a review? thanks

Thanks so much for making this change! LGTM. I will be taking time off, so will let other reviewer(s) to take a look as well.

Hi @jzhoulon Can you please check @swachhandl's comments and keep us posted ? Thank you!

@gbaned can you reopen this pr？ I am missing the reopen button. thanks

@gbaned can you reopen this pr？ I am missing the reopen button. thanks

Hi @jzhoulon I have reopened the PR. Thank you!

Could you please add relevant unit tests where possible for the changes added?

Hi @jzhoulon, could you please add unit tests for the changes where possible? Thanks!

Hi @jzhoulon Can you please check @swachhandl's comments and resolve conflicts?. Thank you!

Could you please add relevant unit tests where possible for the changes added?

Hi @jzhoulon, could you please add unit tests for the changes where possible? Thanks!

sure, I will take it

Hi @jzhoulon Can you please rebase your branch and resolve the conflicts? Thank you!


[BEAM-10670] Make Read use SDF by default. Override in runners.

We add a PTransform override which converts to a new primitive read transform updating the existing read translation logic to only apply to this new primitive read and not to Read.Bounded/Read.Unbounded.
A good chunk of this change is fixing up test expectations since the expansion is always using SDF now.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @TheNeuralBit

CC: @kennknowles This pushes the logic down from Read into each runner to override with a primitive read.
@TheNeuralBit This is the other half of the change which exposed the issue with Samza and SDF.

Run Java PreCommit

I did a first pass. I think big picture there are two things:

Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads.

BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the *BoundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience.

I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that.

I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior".
After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override).

 I think big picture there are two things:

Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads.

BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the BoundedSource/UnboundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience in batch and would break pipeline update in streaming. This was a focus of mine over the past ~6 weeks.

Do they have equivalent performance? My architectural idea is that we can have expansion that looks like:
Read(BoundedSource) {
  Impulse -> SDF
}

preserving all the bounded/unbounded source data but having a portable expansion. "Portable" meaning that all non-primitives (like Read) are expanded to primitives (SDF). But there is no reason a runner has to support SDF at all, if they can recognize the composite and implement it directly.
So my basic idea would be to have all such runners continue to use their existing execution paths, unless the runner authors/maintainers believe whatever SDF support they have is good enough. FWIW I don't think this is my invention. I thought this was the plan to seamlessly support Read and SDF in the same portable pipeline, with runners picking and choosing what they can execute CC @xinyuiscool @iemejia @mxm

I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that.

I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior".

There should not be behavior differences. The expansion above should have identical PCollection contents whether the runner implements Read or SDF. And the runner should make sure that pipeline maintain their performance by using the best translation they can. Users should not need to be aware of this, except perhaps via debugging interfaces that expose the expansion.

After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override).

My position on runners-core and runners-core-construction is that these are just libraries with collections of useful functionality for implementing a runner. Neither one should ever be user-visible. Deleting dead code from either library is nice-to-have cleanup. If any runner wants to keep the code it can be copied into the runner.

*note that "recognize the composite and implement it directly" means they both recognize the URN and recognize that they can execute the Java-based BoundedSource/UnboundedSource directly. There may be some complexity around the portable process boundary providing diamond-dep protection, but that may be worth it for more direct translation to the underlying system, and that is a decision for runner authors/maintainers/users.

@kennknowles

I did a first pass. I think big picture there are two things:

Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads.

BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the BoundedSource/UnboundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience in batch and would break pipeline update in streaming. This was a focus of mine over the past ~6 weeks.

Do they have equivalent performance? My architectural idea is that we can have expansion that looks like:

Nexmark did show improvements (#12519 (comment))

Read(BoundedSource) {
  Impulse -> SDF
}

preserving all the bounded/unbounded source data but having a portable expansion. "Portable" meaning that all non-primitives (like Read) are expanded to primitives (SDF). But there is no reason a runner has to support SDF at all, if they can recognize the composite and implement it directly.
So my basic idea would be to have all such runners continue to use their existing execution paths, unless the runner authors/maintainers believe whatever SDF support they have is good enough. FWIW I don't think this is my invention. I thought this was the plan to seamlessly support Read and SDF in the same portable pipeline, with runners picking and choosing what they can execute CC @xinyuiscool @iemejia @mxm

I brought up the migration to using SDF to power BoundedSource/UnboundedSource on<EMAIL_ADDRESS>If you would like to reconsider the migration path it would make sense to continue this discussion on the original thread.

I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that.

I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior".

There should not be behavior differences. The expansion above should have identical PCollection contents whether the runner implements Read or SDF. And the runner should make sure that pipeline maintain their performance by using the best translation they can. Users should not need to be aware of this, except perhaps via debugging interfaces that expose the expansion.

The purpose of having the fallback is to give users an opt-out mechanism during the migration should they hit issues. I don't believe our runners have comprehensive testing of pipelines at scale enough to state that the migration will be perfect.

After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override).

My position on runners-core and runners-core-construction is that these are just libraries with collections of useful functionality for implementing a runner. Neither one should ever be user-visible. Deleting dead code from either library is nice-to-have cleanup. If any runner wants to keep the code it can be copied into the runner.

I disagree. As someone who went through all our runners changing a core piece, dead code would only make Apache Beam harder to maintain.

"core" is just a name because I/we didn't have a clever name for it. Both libraries were created for this purpose and really shouldn't be seen as more than a utility library. They are not the definition of any part of the Beam model, just helpers.

@kennknowles

I did a first pass. I think big picture there are two things:

Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads.

BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the BoundedSource/UnboundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience in batch and would break pipeline update in streaming. This was a focus of mine over the past ~6 weeks.

Do they have equivalent performance? My architectural idea is that we can have expansion that looks like:

Nexmark did show improvements (#12519 (comment))

Read(BoundedSource) {
  Impulse -> SDF
}

preserving all the bounded/unbounded source data but having a portable expansion. "Portable" meaning that all non-primitives (like Read) are expanded to primitives (SDF). But there is no reason a runner has to support SDF at all, if they can recognize the composite and implement it directly.
So my basic idea would be to have all such runners continue to use their existing execution paths, unless the runner authors/maintainers believe whatever SDF support they have is good enough. FWIW I don't think this is my invention. I thought this was the plan to seamlessly support Read and SDF in the same portable pipeline, with runners picking and choosing what they can execute CC @xinyuiscool @iemejia @mxm

I brought up the migration to using SDF to power BoundedSource/UnboundedSource on<EMAIL_ADDRESS>If you would like to reconsider the migration path it would make sense to continue this discussion on the original thread.

I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that.

I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior".

There should not be behavior differences. The expansion above should have identical PCollection contents whether the runner implements Read or SDF. And the runner should make sure that pipeline maintain their performance by using the best translation they can. Users should not need to be aware of this, except perhaps via debugging interfaces that expose the expansion.

The purpose of having the fallback is to give users an opt-out mechanism during the migration should they hit issues. I don't believe our runners have comprehensive testing of pipelines at scale enough to state that the migration will be perfect.

After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override).

My position on runners-core and runners-core-construction is that these are just libraries with collections of useful functionality for implementing a runner. Neither one should ever be user-visible. Deleting dead code from either library is nice-to-have cleanup. If any runner wants to keep the code it can be copied into the runner.

I disagree. As someone who went through all our runners changing a core piece, dead code would only make Apache Beam harder to maintain.

"core" is just a name because I/we didn't have a clever name for it. Both libraries were created for this purpose and really shouldn't be seen as more than a utility library. They are not the definition of any part of the Beam model, just helpers.

I didn't mean "core" as in the modules with the name "core" in them but the "core" concept of how data is ingested into a pipeline by a runner.

#12519 (comment)

@kennknowles

I did a first pass. I think big picture there are two things:

Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads.

BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the BoundedSource/UnboundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience in batch and would break pipeline update in streaming. This was a focus of mine over the past ~6 weeks.

Do they have equivalent performance? My architectural idea is that we can have expansion that looks like:

Nexmark did show improvements (#12519 (comment))

Read(BoundedSource) {
  Impulse -> SDF
}

preserving all the bounded/unbounded source data but having a portable expansion. "Portable" meaning that all non-primitives (like Read) are expanded to primitives (SDF). But there is no reason a runner has to support SDF at all, if they can recognize the composite and implement it directly.
So my basic idea would be to have all such runners continue to use their existing execution paths, unless the runner authors/maintainers believe whatever SDF support they have is good enough. FWIW I don't think this is my invention. I thought this was the plan to seamlessly support Read and SDF in the same portable pipeline, with runners picking and choosing what they can execute CC @xinyuiscool @iemejia @mxm

I brought up the migration to using SDF to power BoundedSource/UnboundedSource on<EMAIL_ADDRESS>If you would like to reconsider the migration path it would make sense to continue this discussion on the original thread.

I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that.

I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior".

There should not be behavior differences. The expansion above should have identical PCollection contents whether the runner implements Read or SDF. And the runner should make sure that pipeline maintain their performance by using the best translation they can. Users should not need to be aware of this, except perhaps via debugging interfaces that expose the expansion.

The purpose of having the fallback is to give users an opt-out mechanism during the migration should they hit issues. I don't believe our runners have comprehensive testing of pipelines at scale enough to state that the migration will be perfect.

After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override).

My position on runners-core and runners-core-construction is that these are just libraries with collections of useful functionality for implementing a runner. Neither one should ever be user-visible. Deleting dead code from either library is nice-to-have cleanup. If any runner wants to keep the code it can be copied into the runner.

I disagree. As someone who went through all our runners changing a core piece, dead code would only make Apache Beam harder to maintain.

"core" is just a name because I/we didn't have a clever name for it. Both libraries were created for this purpose and really shouldn't be seen as more than a utility library. They are not the definition of any part of the Beam model, just helpers.

I didn't mean "core" as in the modules with the name "core" in them but the "core" concept of how data is ingested into a pipeline by a runner.

OK. I am only referring to the module name. The modules are just piles of functionality that a runner can use as they please. The thing I don't like is having a global user-controlled flag that tweaks runner behavior when the runner may not even be aware. Basically moving a flag from the SDK to the runner is better but still not great.


applyMiddleware type does not allow heterogeneously-typed middleware

Do you want to request a feature or report a bug?
Report a bug.
What is the current behavior?
Consider the following TypeScript program, minimized from a production use case:
import {Middleware, Reducer, applyMiddleware, createStore} from "redux";

type A = { a: string }
type B = { b: string }

const middlewareA: Middleware<{}, A> = (store) => (next) => (action) => next(action);
const middlewareB: Middleware<{}, B> = (store) => (next) => (action) => next(action);

const reducer: Reducer<A & B> = (state) => state;

createStore(reducer, applyMiddleware(middlewareA, middlewareB));

In practice middlewareA and middlewareB deal with two separate domains and are defined in separate modules. They declare themselves as receiving only the state they know about.
I should be able to use both middleware simultaneously in a larger program whose aggregate state extends A & B, as shown. However, this produces a type error:
index.ts:11:51 - error TS2345: Argument of type 'Middleware<{}, B, Dispatch<AnyAction>>' is not assignable to parameter of type 'Middleware<{}, A, any>'.
  Property 'a' is missing in type 'B' but required in type 'A'.

11 createStore(reducer, applyMiddleware(middlewareA, middlewareB));
                                                     ~~~~~~~~~~~

  index.ts:3:12
    3 type A = { a: string }
                 ~
    'a' is declared here.

Which versions of Redux?
4.0.1
Did this work in previous versions of Redux?
Yes. The following works in 3.7.2:
import {Middleware, Reducer, applyMiddleware, createStore} from "redux";

type A = { a: string }
type B = { b: string }

const middlewareA: Middleware = (store) => (next) => (action) => next(action);
const middlewareB: Middleware = (store) => (next) => (action) => next(action);

const reducer: Reducer<A & B> = (state) => state;

createStore(reducer, applyMiddleware(middlewareA, middlewareB));

You can just do what we do in our tests with a small implementation of Thunks and create a State type argument for your middleware: https://github.com/reduxjs/redux/blob/74233481ab3a10611861dc34106819f203f82477/test/typescript/middleware.ts#L71-L82
Because at the call site of createStore/applyMiddleware, you should know your State type, that should be passable at that point.

Hmm, I don't think I understand the relevancy of that code. The problem is not that I don't know the state types involved, or that they need to be made generic. It's that the type definition for applyMiddleware doesn't support the composition of middleware that deal with different pieces of state.
export function applyMiddleware<Ext1, Ext2, S>(
  middleware1: Middleware<Ext1, S, any>,
  middleware2: Middleware<Ext2, S, any>
): StoreEnhancer<{ dispatch: Ext1 & Ext2 }>

This definition requires that middleware1 and middleware2 both be typed as accepting the same state S. That's more restrictive than it should be.


Fix time zone issues, optimize date for db query

fix https://github.com/antoniolg/Kotlin-for-Android-Developers/issues/6

Thanks for this! Give me some time to try it and I'll merge.

I'm redoing this repo with some book updates, so I won't be able to merge this PR.  But I'll add your fix, so what I've thought is that I'm going to add a collaborators section in the readme.
I can't do it anything else, because people who get the book need the right fixes at the right commit. An extra commit at the head of the branch won't help. So I need to push -f this branch.
Thanks again for finding a solution!

Tried this, but it wasn't working either. The dates this API return are rather random for some strange reason. The approach I took in the end is the same I saw other people use with this API: as I know that the first forecast I receive is for today, I iterate and generate the dates manually.
This will land master in the following day, but you can already see it here.
I'm closing this PR in favour of the other solution. Thanks for your help!

get it.


HDDS-10267. Add PR template for the new website.

What changes were proposed in this pull request?
Add a PR template for new website PRs. This is based on the PR template for the main Ozone repo, but adjusted a bit for the website.
What is the link to the Apache Jira?
HDDS-10267
How was this patch tested?
N/A

Thanks @dombizita for the review.

Thanks @adoroszlai and @dombizita


Add payload field to SubMsg

Closes #1909

[x] Implementation
[ ] CHENGELOG entry

@hashedone @jawoznia @DariuszDepta this is the Reply payload I mentioned today. The pair (id, payload) is just copied 1:1 from the SubMsg emitted by the contract into the reply entry point. This allows the contract to add data needed for processing the reply.


Rewrite Format-Hex on C#

As approved in #2718 Format-Hex should be rewritten on C#.

/cc @rkeithhill

Where should this cmdlet go? I was thinking it would go in PowerShell\src\Microsoft.PowerShell.Commands.Utility\commands\utility\FormatAndOutput\format-hex\format-hex.cs?  Is that the right place?

Yes. Looks good.


feat: make total_gas_cost i64 so it won't panic

Description
The total_gas_cost results in an overflow in case of -ve value.

Any update

I am not sure we want this at the moment. The values there should never get to a negative number and we are ok crashing. To be honest in the face of big number going from u64 to i64 seems as risky of a move.
We are in the process of reviewing some of those arithmetic operations but I do not believe a cast to 'signed' is the answer in all cases.
Thoughts?

The values there should never get to a negative number

When the storage rebate is more than the rest, wouldn't the gas fee will be -ve?

we are ok crashing

It stops indexing other things as well in that case.

The values there should never get to a negative number

When the storage rebate is more than the rest, wouldn't the gas fee will be -ve?

we are ok crashing

It stops indexing other things as well in that case.
@dariorussi

let me see if I can come up with a scenario where that may happen. You have a fair point that it may actually happen.
The point I was trying to make is not that we are ok crashing in general ;) but rather that we are ok when we believe there is an invariant.
Let me try to come up with a scenario for that. Thanks!

actually this change is in line with things we do elsewhere too so it seems a good thing to have. Thanks!

adding few more people to take a look as well.
Thanks!

Adding @gegaowp since it's an indexer change


Product images dropzone doesn't work if there are no images

When I'm trying to add some images to a product that currently doesn't have one, the dropzone doesn't work, because it is just opened in a new tab, instead of getting uploaded. When there is already any image in the list, the dropzone works correctly.

Duplicated #514

+1, any update on this?


Filename vs Process ID Conflicts

When you save multiple versions of the same Process using the File Names such as Process123_v1.bpmn and Process123_v2.bpmn, but the Process ID are the same in the xml/files, a conflict is created and the user cannot open both of the BPMN files at the same time.
You have to change the Process ID field.
Why is the Process ID field used as the UID between open files rather than the file name?

Based on your description we cannot reproduce your bug report.
Could you please provide

your platform
the Camunda Modeler
detailed steps to reproduce

Mac, 10.11.4
Camunda: Version 0.6.0<PHONE_NUMBER>)
Did some further testing, and I see this is a problem with Google Drive rather than Camunda directly.
Seems that Google Drive and Camunda do not get along 😄
Get the following error often when opening BPMN files in google drive:

Does not happen every time, but it is often.
Open a BPMN file on Google Drive.  Save.  Close.  Reopen.
Repeat if it does not happen the first time.

Google drive seems to constantly update the last edit flag of the files. There is nothing we can do about it, unless we do an actual hashsum check on the file contents.


Add support to unlock pre-release content with PIN

There is some early preview content that requires 4 PIN numeric code before they can be played. Currently, the addon gives the error "content not available for instant playback." It would be of much help if you can add the option to input the code.

Something from the kodi log reads: Pre-release content authorization requires a user-initiated request.

i need you provide a pratical example on how test this otherwise no idea what to do

I didn't know how to create a HAR log, but I've tried it. Take a look. I input the wrong pin while recording the session and I hope it's enough.
Log.zip

yeah the log is perfect seem website its using only encrypted way then i cannot see nothing, but at least i have excluded something
i will try prepare a test hoping it works, then i will need you to provide me Kodi logs
I will let you know later with instructions

Can you explain me how you get account enabled for pre-release?
is there a special website section for pre-release content?
This a the test build: plugin.video.netflix_1.20.0+matrix.1_20221027_t1_pin.zip
just update and play,
if works please also test with a wrong pin
so see if it show to you the right error message and allow you to try put PIN again at same time

Pre-lease content is privileged for tv journalists. For said content, it appears in its own section and also appears in search.
I have updated the test build and tested it with the wrong pin; it didn't work and gave me the option to input the PIN again.
Unfortunately, when I entered the correct one, it gave me the same error it did before.

i tried change data type,
try this: plugin.video.netflix_1.20.0+matrix.1_20221028_t2_pin.zip

Still gives the same error after inputting correct pin.

From: Stefano Gottardo @.>
Sent: Friday, October 28, 2022 9:11:25 AM
To: CastagnaIT/plugin.video.netflix @.>
Cc: misterkoat @.>; Author @.>
Subject: Re: [CastagnaIT/plugin.video.netflix] Option to input PIN to unlock content (Issue #1472)
i tried change data type,
try this: plugin.video.netflix_1.20.0+matrix.1_20221028_t2_pin.ziphttps://github.com/CastagnaIT/plugin.video.netflix/files/9885696/plugin.video.netflix_1.20.0%2Bmatrix.1_20221028_t2_pin.zip
—
Reply to this email directly, view it on GitHubhttps://github.com/CastagnaIT/plugin.video.netflix/issues/1472#issuecomment-1294508784, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7DCQRXWX2V6STJHYK3HQDWFNVA3ANCNFSM6AAAAAARMQJKMI.
You are receiving this because you authored the thread.Message ID: @.***>

unfortunately there is nothing more i can do
since my account is not enabled to prerelease content
i cannot analize browser network with mitmproxy to try understand what is missing or what change is needed
otherwise you should try analize network yourself if you are experienced enough

Well, thanks for trying.
I'm not experienced enough to do that. I'll stick with the browsers as they
seem to be doing the job though I'd have preferred watching everything on
kodi for a few reasons.
Again, thank you for your efforts.
On Fri, 28 Oct 2022, 13:56 Stefano Gottardo, @.***>
wrote:

unfortunately there is nothing more i can do
since my account is not enabled to prerelease content
i cannot analize browser network with mitmproxy to try understand what is
missing or what change is needed
otherwise you should try analize network yourself if you are experienced
enough
—
Reply to this email directly, view it on GitHub
https://github.com/CastagnaIT/plugin.video.netflix/issues/1472#issuecomment-1294853355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU7DCQSB3NN64HEHC3VBFFTWFOWPLANCNFSM6AAAAAARMQJKMI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I add a note if in the future someone else with pre-release content enabled account want investigate
i have add a branch with the changes needed: https://github.com/CastagnaIT/plugin.video.netflix/tree/prerelease_content
but OFC need to be fixed how PIN data is added in manifest

Do you think that if you had access to an account with pre-release content, you might be able to figure it out?

yes it will allow me to analyse the network flow of the website more in depth,
ofc its an attempt then i cannot guarantee that it will work

I don't mean to trivialise what you do, I don't think it's really complicated.
I used this basic app that can actually decrypt the content. A log in page would show up and after inputting the pin, it would work.

From: Stefano Gottardo @.>
Sent: Saturday, October 29, 2022 3:21:38 PM
To: CastagnaIT/plugin.video.netflix @.>
Cc: misterkoat @.>; Author @.>
Subject: Re: [CastagnaIT/plugin.video.netflix] Add support to unlock pre-release content with PIN (Issue #1472)
yes it will allow me to analyse the network flow of the website more in depth,
ofc its an attempt then i cannot guarantee that it will work
—
Reply to this email directly, view it on GitHubhttps://github.com/CastagnaIT/plugin.video.netflix/issues/1472#issuecomment-1295820778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7DCQTL7PSNHZIPULJKDIDWFUJFFANCNFSM6AAAAAARMQJKMI.
You are receiving this because you authored the thread.Message ID: @.***>

I used this basic app that can actually decrypt the content. A log in page would show up and after inputting the pin, it would work

i am not able to full understand what you mean in your last comment,
maybe you have attached to the message something? if no, please explain better
if you use emails to reply to comments on github website you are limited to plain-text only

i have add this to Project section,
so for now i close the Issue


Running locally

Hi all,
Hoping someone can help.
To get the latest version, I tried to run the app from the code.
Following the run instructions here:
https://github.com/tomlandia/fuckr
cd fuckr/
nw .
The nw . isn't recognised.
I assume this is:
nodewebkit .
That gave a window

Looked at the code & googled for help..but had no joy.
Any help please...thanks!!
Windows 7, 64bit OS

Probably an old Node-Webkit version, you'd need at least 0.12 to support HTTP requests handler that have become necessary since Grindr implemented Captchas


Ender Dragon RFToolsDimensions problem.

Trying to create a mob dimlet for an Ender Dragon dimension. I have all the necessary components (base part, rarity 6 control circuit, advanced energy module, advanced memory unit, mob type controller, Syringe of 100% Ender Dragon essence) but nothing appears in the output box of the workbench. I am concerned it's something to do with the syringe of essence.. but I can't be certain.

I'm having this same issue.

Versions?

rftools-1.12-7.00alpha1.jar
rftoolsctrl-1.12-1.6.8.jar
rftoolsdim-1.12-5.05.jar
Sorry about that. I wasnt thinking. :-) Its the ALL THE MODS 3 4.1 modpack.

What? Is all the mods using the alpha of rftools? Now that's a bad idea...

any fix to this

I have this same issue in All The Mods 3 (1.12.2).  RFTools versions:
RFTools: 1.12-7.23
RFTDim: 1.12-5.50
McJtyLib: 1.12-2.6.2

@scotty9090 I can't reproduce this in a clean instance with those versions. (I tried with Forge 2587, which I assume is what you're on.) Can you see if you can do so? If not, can you try to identify what other mod in the pack is triggering this bug?
@JarlWolfe @mrdeadlocked @tluc0411 Can any of you do the same?

Update: I discovered that this is ATM3's fault: AllTheMods/ATM-3#319. I assume that all of you having this problem are on ATM3. If it happens to you in a different pack, please open a new issue about it.

If you are on ATM3, as a workaround, go into config/rftools/dimensions.cfg, and change I:maxMobInjections from 64 to 10.


fix(rebranding): radio shadow and facet button line-height

Proposed Changes
Fixed facet checkbox button line-height and radio shadow on focus, more adjustments will be done in the admin.
Potential Breaking Changes
Before:

After:

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

@sallainCoveo Yes! Also for the background color of single select filter


Unfortunately app has been stopped after installing firebase plugin

when i uninstalled firebase plugin, everything work fine but after installing firebase plugin it get crashed.
and when app going to launch on android device it get failed and show an error "Unfortunately App has been stopped". Please suggest me the best approach to get rid off.
Thanks in advanced.


[New Feature]:  Template completion support for compiler plugins

Description
Story: Compiler plugins for standardlibs such as http, grpc, and graphql should be able to provide their own completion items in different completion contexts.
Constraints: The completion items should only be provided when the compiler plugins are activated or when there is an import statement in a particular module.
Example
http

Provide custom resource function snippets in service body context

eg: get, post, delete, etc.

Provide completion items for new expressions with different arguments inside function body block context
eg:  new expression for a secure client, a client with JWT authentication

Provide completion items in the module part context
listeners, clients, custom service snippets, etc.

udp

Provide onDatagram(), onByte() completion items inside the service body context
More information: https://docs.google.com/document/d/1lwfYLjyjtXjHc8-2F3hcgsLjmcKHAXTOKo99mR08Fas/edit?usp=sharing
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

AFAIU, in the current implementation, the completions provided are context-sensitive. Hence, the plugins should be able to inject completion items into the relevant context. What's the approach to achieving that? Are we going to publish the completion extension jar along with the lib itself?

Just out of curiosity, AFAIU in the current implementation, the completions provided are context-sensitive. Hence, the plugins should be able to inject completion items into the relevant context. What's the approach to achieving that? Are we going to publish the completion extension jar along with the lib itself?

We will allow the plugins to provide the completions items based on the context. For this, we intend to use a completion context with limited number of properties such as nodeAtCusror, cursorPosition, currentSyntaxTree, etc.
Each compiler plugin(lib) will add a CompletionProvider object  to it's context at the initialization of the plugin. Therefore the completion extension(provider) will be in the lib it self as depicted in the following class diagram.
classDiagram
    LangExtensionDelegator <-- TextDocumentService:completions()
    CompletionExtension <|-- CompilerPluginCompletionExtension
    PositionedActionContext <|-- CompletionContext
    CompletionContext <|-- CompletionContextImpl
    CompletionProvider <|-- AbstractCompletionProvider

    CompilerPluginCompletionExtension <-- LangExtensionDelegator:completions()
    CompletionContextImpl <-- CompilerPluginCompletionExtension:create()
    CompletionProvider <-- CompilerPlugin : create()
    CompilerPlugin <-- CompilerPluginManager:init()
    CompletionItem <-- CompletionProvider:create()
    CompletionUtil <-- CompletionProvider:uses
    CompletionContext <-- CompletionManager:uses
    CompletionContext <-- CompletionProvider:uses

    LangExtensionDelegator *-- CompletionExtension
    CompletionManager <-- CompilerPluginCompletionExtension:completions()
    PackageCompilation *-- CompilerPluginManager
    CompilerPluginManager *-- CompletionManager
    CompletionProvider <-- CompletionManager:getCompletions()
    CompilerPluginManager *-- CompilerPluginContext
    CompilerPluginContext *-- CompletionProvider


Unify Logger Config for Tasks

Feature or Bugfix

Refactoring

Detail

Unify Logger Config in Backend (focused on /tasks)
Fix Log Level setting

Relates

https://github.com/data-dot-all/dataall/issues/1680

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing:

[x] Pipeline Succeeds

Run ECS Tasks and Verify Proper Logs + Formatting w/ Log Level - DEBUG

[x] Env stack updater
[x] Cdkproxy
[x] Omics Workflow Fetcher
[x] Table Syncer
[x] Dataset Subscription Task
[x] Share Manager

Run ECS Tasks and Verify Proper Logs + Formatting w/ Log Level - Info

[x] Cdkproxy
[x] Catalog Indexer
[x] Table Syncer
[x] Share Manager


Make JSX Menu links open in new tab

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
When the new React navbar was built, the functionality of bug reporting and documentation links opening in a new tab wasn't ported over. This fixes it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
looks like this before and after:

TEST PLAN
Set the config value for the DOCUMENTATION_URL, click the link, see it open in another tab
See other links open in the current tab as before
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
to: @willbarrett @graceguo-supercat @john-bodley

Codecov Report

Merging #9191 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #9191   +/-   ##
=======================================
  Coverage   59.13%   59.13%
=======================================
  Files         372      372
  Lines       11938    11938
  Branches     2925     2925
=======================================
  Hits         7059     7059
  Misses       4699     4699
  Partials      180      180

Impacted Files
Coverage Δ

superset-frontend/src/components/Menu/Menu.jsx
87.5% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efdfc5...5e1755b. Read the comment docs.


@refetchable directive?

Hi, when I try to use the @refetchable directive, Relay compiler complains with:
Error: ✖ Invalid use of @refetchable on fragment 'deliveryChannelSelector', only supported are fragments on:
[web-client]: [relay]  - the Viewer type
[web-client]: [relay]  - the Query type
[web-client]: [relay]  - the Node interface, object types that implement the Node interface, interfaces whose implementing objects all implement Node, and unions whose members all implement Node
[web-client]: [relay]  - server objects and interfaces with the @fetchable directive
[web-client]: [relay]

I'm defining my fragment with:
const [deliveryChannels, refetchDeliveryChannels] = useRefetchableFragment(
    graphql`
      fragment deliveryChannelSelector on CreatorNode
      @refetchable(queryName: "deliveryChannelSelectorRefetchQuery") {
        id
       deliveryChannels {
          __id
          edges {
            node {
              id
              name
            }
          }
        }
      }
    `,
    deliveryChannelsKey,
  );

And the schema is using something along the examples provided in this repository.
What am I missing?

Hey sorry, when you first posted this I was trying to go through the process of creating a minimum reproducible example of this for you, and help you see the solution to the problem from there. Truth is I ran out of time and got busy. I feel bad I neglected this issue. I will instead just explain what you need to do and as long as you still need help I will help you if you have further questions.  Now this issue isn't too that specific to this library, but I'm glad to try and help you here with the time I do have. What you need to do is setup your type returned from deliveryChannels' node to be a Node interface. The Node interface was described in your error message as one of the supported fragment types:
Invalid use of @refetchable on fragment 'deliveryChannelSelector', only supported are fragments on:
...
- the Node interface, object types that implement the Node interface, interfaces whose implementing objects all implement Node, and unions whose members all implement Node
...

Unspecific to this library what you are after is implementing the GraphQL Global Object Identification specification.
The first step is to setup a Node interface Which is detailed there as:

Node Interface
The server must provide an interface called Node. That interface must include exactly one field, called id that returns a non-null ID.
This id should be a globally unique identifier for this object, and given just this id, the server should be able to refetch the object.

In TypeGraphql that means you need to use TypeGraphQL's interface
So, if we implement the Node interface as described above it would look like:
/** This is the Node interface from the Global Object Identification spec https://relay.dev/graphql/objectidentification.htm#sec-Node-Interface */
@InterfaceType()
abstract class Node {
  @Field(type => ID)
  id: string;
}

Then you must also add the node(id: ID) query resolver to the root Query.
// Don't forget to include the below resolver in your list of resolvers when building your graphql schema.
@Resolver()
export class NodeResolvers {
  /** https://relay.dev/graphql/objectidentification.htm#sec-Node-root-field */
  @Query(returns => Node)
  async node(
    @Arg("id") id: string,
  ): Promise<Node> {
    return // you must do this yourself, because it will depend completely on what database you are using...
  }
}

Specific to this library you need to make sure that if you want @refetchable support and you do the following:
// This is the EdgeType:
@ObjectType()
export class DeliveryChannelEdge extends EdgeType(DeliveryChannel) {}

then you must make sure your DeliveryChannel implements the Node Interface as shown previously which in TypeGraphQL would look something like:
@ObjectType({ implements: Node })
class DeliveryChannel implements Node {
  id: string;
  // the rest of your class....
}

All this has not been tested so I may have messed something up, but feel free to at tag me if you need further help and are still stuck. Thanks!

@FezVrasta sorry forgot to at tag you in the last message just wanted to make sure you saw it though, so I'm at tagging you here. :D

Thanks, this worked, I did manage to make it work but forgot to update you here :-( I'm sorry about that.

No worries!! Glad you got it to work, sorry I wasn't able to help you earlier :)


request - revise jiggle_version to only use python3 stdlib

This is a interesting project, but portability and usage is restricted since it requires more than stdlib.  Please consider revising jiggle_version to only use python3 stdlib.

I probably could vendorize most things, I'd have to check license compatibility.


Visual Block mode incorrect

Out of the three above standard VIM modes, the

characterwise mode, marked as Visual in vim status line, started with v - works correctly
linewise mode, marked as Visual Line vim status line, triggered with 'SHIFT-v` works correctly
blockwise mode, marked as Visual Block, triggered with CTRL-v works exactly like characterwise mode, i.e. incorrectly. It should select a block, not a sequence of characters

looks like this is a duplicate of #468

Thanks @rkmarks.


Warn if story with a given name already exists

Right now if you add another story with the same name, the first one is
lost. For example:
// …

storiesOf('Button', module)
  .add('with text', () => ( // this story will be lost
    <Button onClick={action('clicked')}>Hello Button</Button>
  ))
  .add('with some emoji', () => (
    <Button onClick={action('clicked')}>😀 😎 👍 💯</Button>
  ))
  .add('with text', () => (
    <p>
      this will silently overwrite the first story
    </p>
  ));

Thank you so much!

Doesn't it break any existing projects or addons which works with stories dynamically?

Do you have examples of this? If this is indeed a common thing addons do, We need to think of something else.

@UsulPro Do you think this is a real issue?


Query for mz_is_landuse=TRUE to use existing index

Refs https://github.com/mapzen/vector-datasource/issues/408
This adds a filter condition to the low zoom landuse queries to allow an existing index to be used.
It seems like the mz_is_landuse condition is redundant with mz_landuse_min_zoom though, at least in the landuse queries. If so, we could consider removing the mz_is_landuse condition from both the queries and the index.
@zerebubuth: could you review please?

:+1: nice catch!
(And yes, we might want to think about removing mz_is_landuse if it's always the same as mz_landuse_min_zoom IS NOT NULL)


update clamav ingress servicePort to reflect the port name in clamav

the servicePort in ingress should match the name specified in the service.yaml

@desaintmartin @machine424 @francoisminaud - please review

Thanks for the contribution!


New Numbers API

Tested on staging and it works. NFT contract stuff is not finalized by Numbers, so it's not implemented yet.

[x] Update reregister.py

Server URLs for config:

Numbers: https://eo883tj75azolos.m.pipedream.net/
Avalanche: https://eox7ryteolf6eh2.m.pipedream.net/
Near: https://eof6acukpt2bka5.m.pipedream.net/


Fix usage test after README.md code fence change

Fixes the test failure introduced by 2d724c2d38d22741f2da56f3c6bf6e5c7f95b96c

Hehe, I really should stop merging changes right into master — even if they look harmless. Thanks a lot for fixing @TimoFreiberg. 🐬


Can't run migrations in Python 3

This project seems to indicate support for Python 3. However, after installing into a Python 3 project, I'm not able to run the migrations successfully.
To reproduce:

Create virtualenv with Python3 (3.4 specifically) and pip install django 1.7.X and django-background-tasks (latest).
Create a Django project, add 'background_task' to the installed apps.
Run migrations

File ".../.virtualenvs/tmp-e3f3ffba6e5aedf/lib/python3.4/site-packages/background_task/admin.py", line 2, in
from models_completed import CompletedTask
ImportError: No module named 'models_completed'

Am I doing something wrong, or is Python 3 not supported?

See pull request #29
It fixes the issue I'm seeing.

I merged @chadgh's #29 Thanks for reporting and fixing this issue.


Fix DEPRECATION WARNING for Rails5

Hi, there. I found deprecation warning.
please, fix it.

DEPRECATION WARNING: #reset_changes is deprecated and will be removed on
Rails 5. Please use #clear_changes_information instead.

:+1:

Coverage remained the same at 98.28% when pulling fb71f066cec90d8300239a2a609c974333748c85 on ukstudio:fix_deprecation_warning into 318dadfab95c437fde72619ef4250de714351975 on dashofcode:master.

Coverage remained the same at 98.28% when pulling fb71f066cec90d8300239a2a609c974333748c85 on ukstudio:fix_deprecation_warning into 318dadfab95c437fde72619ef4250de714351975 on dashofcode:master.

Thanks!


"slave" -> "worker" for xdist compat

Closes #34.

This change is

Coverage decreased (-0.4%) to 72.088% when pulling 0b331ce41fd3163c277ee4dc9eb8936e39b0e0fc on emancipate into 9a085e79d509c6f1497dc447c0688429174a8946 on master.

@RonnyPfannschmidt done :slightly_smiling_face:

@jaraco - if this looks good to you, could you cut a new release?

What kind of version bump does this change require?

Nevermind; I see it in the changelog. Released 8798e03 as 2.1.0.


SWA CLI and Visual Studio debugger does not connect in Visual Studio 17.8.6

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.
Are you accessing the CLI from the default port :4280 ?

[x] Yes, I am accessing the CLI from port :4280

Make sure you are accessing the URL printed in the console when running swa start!

ℹ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly
Describe the bug
A clear and concise description of what the bug is.
The swa cli and Visual Studio debugger no longer connect to the Blazor static web app under Visual Studio 17.8.6.
Under Visual Studio 17.8.5 the swa cli will correctly launch and attach to the browser (in my case Microsoft Edge), however under Visual Studio 17.8.6 the browser launches however the swa cli fails to connect with a 'Failed to launch debug adapter' error (see screenshot below).
Note:  When running with --verbose=silly the last message is [swa] Connected to tcp:localhost:5000 successfully with no further debug messages.
To Reproduce
Steps to reproduce the behavior:

Clone the Blazor-Basic SWA from the Microsoft Quickstart: Build your first static web app instructions.
Update the BlazorBasic\Properties\launchSettings.json file by adding "launchUrl": "http://localhost:4280" and changing applicationUrl to be "applicationUrl": "http://localhost:5000".

 Start the swa cli with the command swa start http://localhost:5000.
4. Launch the application in Visual Studio with debugging using the BlazorBasic profile.
Expected behavior
A clear and concise description of what you expected to happen.
The swa cli and Visual Studio debugger should connect and launch the Blazor static web app correctly as it did with Visual Studio 17.8.5.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Windows 11 Pro
Version 23H2

Additional context
Add any other context about the problem here.

I confirmed this behavior is also present in Visual Studio 17.9.

Just an update, this issue is still present in Visual Studio 17.9.7 when following the steps above.
However, the good news is that this problem does not happen when running the SWA CLI within docker (with a Windows 11 host).
I launch the docker container using the command:
docker run --rm -p 4280:4280 -it swacli/static-web-apps-cli:latest
and once it is started, I start SWA within the docker container using the command:
swa start http://host.docker.internal:5000 --api-location http://host.docker.internal:7071
Using this I was able to run Visual Studio 17.9.7, with the nuget packages fully updated in the solution.


ARCMWDT: Fix cbprintf issue with omitted function prototype

MWDT compiler (LLVM 16.0.6 based) requires function to be declared with argument types and produce warnings otherwise. This PR provides explicitly type cast for out() routine inside z_cbvprintf_impl().
This fixes https://github.com/zephyrproject-rtos/zephyr/issues/74562

??? cbprint_cb is a type. CI has been building with LLVM for quite a while and there has been no report of such warnings. Does the MWDT enable more warnings than default LLVM build?

Hi @dcpleung,

??? cbprint_cb is a type.

Yes, however the waning is about how the cbprint_cb is defined. Currently it's declared as a pointer to function (without the parameters specified).
https://github.com/zephyrproject-rtos/zephyr/blob/012520d2d7e8d2bbc914bb5735bf1563abd0e4ea/include/zephyr/sys/cbprintf.h#L302
And the warning is exactly about it:

warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x

Unfortunately it's done intentionally as per cbprint_cb description
https://github.com/zephyrproject-rtos/zephyr/blob/012520d2d7e8d2bbc914bb5735bf1563abd0e4ea/include/zephyr/sys/cbprintf.h#L291-L293
Currently it's indeed a hack in the PR, and it would be nice to have a clean fix. So if you have any ideas about it - please share!

Hi @dcpleung,
Compilation branch with __CHECKER__ cause errors with type cast:
/home/user/sandbox/zephyrproject/zephyr/lib/os/printk.c:260:12: error: incompatible function pointer types passing 'int (int, struct str_context *)' to parameter of type 'cbprintf_cb' (aka 'int (*)(int, void *)') [-Wincompatible-function-pointer-types]
  260 |         cbvprintf(str_out, &ctx, fmt, ap);
      |                   ^~~~~~~
/home/user/sandbox/zephyrproject/zephyr/include/zephyr/sys/cbprintf.h:744:27: note: passing argument to parameter 'out' here
  744 | int cbvprintf(cbprintf_cb out, void *ctx, const char *format, va_list ap)
      |                           ^
1 error generated.

??? cbprint_cb is a type. CI has been building with LLVM for quite a while and there has been no report of such warnings. Does the MWDT enable more warnings than default LLVM build?

Clang generates similar warnings with Wincompatible-function-pointer-types-strict flag turned on

Could you try typedef another one and use that instead of using int (*out)(int, void *) = __out;? Also document that both must be in sync? I am worried that if the signature is changed in the future, the forced typecasting inside those functions will result in mysterious broken code.


Add more details to metadata proposal for condition mapping

This PR captures the discussions had around how condition filtering should impact metadata and searching.
Test Steps:
n/a
Changes

Updates the proposal

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues
To Be Done
Specific Security-related subjects a reviewer should pay specific attention to

The added details to metadata proposal for condition mapping looks good to me.
Just want to borrow this place to pop some thoughts on the proposed metadata search approaches:
Instead of tracking the relationship among reports, such as keep track of parent_report, child_report, and later on leveraging some graph traversal algorithm to extract metadata (recursive SQLs?), event logging can be used to generate auditable trace of test (report = set of tests) while it is going through the pipeline, the logged event include attributes such as:
Each STLT and CDC is a node on the pipeline, a node can be a report sender, a report receiver, or both.
A report is like an envelop containing tests (1..n), tests are enveloped when sent, the receiver upon receiving an envelop, it can de-envelop and repack tests into new reports - enveloping again - and send the new reports out...
At each node, when enveloping / de-enveloping / transforming / filtering / routing tests, an audit event is logged, the event includes the following info:

de-identified test record
sender of the test + sent_at (timestamp)
receiver of the test + received_at (timestamp)
transformations applied
filters applied
.............

The audit events (contains metadata we need) will be in the RS server log, and in turn be injected by analytical tools such as Splunk, and AWS, Azure, GCP all have BI solutions that can query streaming data from Splunk: e.g. AWS has Kinesis Data Firehose, Athena, Quicksight to build BI insights from RS UP audit events logging -> Splunk -> Firehose (Data Streaming) -> Athena (SQL Queries on streaming data) -> Quicksight (visualization).
Leveraging event logging to tap the metadata bearing events from RS server the following advantages:

Events with rich metadata logged are immutable and is a snap shot of what happened at the moment the test lineage is processed (at a node)
Events at the moment being logged, are separated from  RS UP runtime (and its database), hence metadata queries going forward will happen outside of the RS UP runtime, that means less impact on RS UP SLO (Service Level Objects, e.g. response time to report senders, receivers, processors)
We can leverage best of the breed analytical and BI tools which might be already in use among the clients, less burden for CDC and STLTs

References:
CMS Blue Button API adopted above approach and providing BI insights to CMS management.
https://github.com/CMSgov/bluebutton-web-server

@JFU-NAVA-PBC Great insights here.  I do think we're ultimately going to need build something from scratch here, but the initial lean was to try to build on top of the existing stuff built rather than greenfield something new.  I really like the idea of treating it as an event stream.
Ultimately though, before we can proceed on considering what the ideal implementation is, there is the larger consideration that needs to be solved of what exactly is the unit we're operating on (i.e. test result, specific conditions (which is the known example, diagnostic reports,) since that has major down stream implications if we were to build something from scratch.


Dyno-queues are no longer maintained

Hi,
I noticed this on dyno-queue's README.md;

DISCLAIMER: THIS PROJECT IS NO LONGER ACTIVELY MAINTAINED

Which is used with the Dynomite persistence layer, which is the default.
How does this affect deployment recommendations?
Will the Dynomite persistence layer become obsolete?

@TwoUnderscorez We were working on a transition plan from dyno-queues to another default Queue implementation.
For the short term, We'll mark the dyno-queues implementation in Conductor as deprecated as well, and add a disclaimer for the same in read me. Please explore other Queueing implementations like MySQL or Postgres.
For the long term, most likely in Conductor v3, we'll port over the default queueing implementation in Conductor away from dyno-queues.

Thanks

Is there any alternate for this project?


Allow disable tls for migrations in case getting the last bits of performance matters

What this PR does / why we need it:
Sometimes getting the best performance is more important than encrypted migrations. For these rare cases, allow disabling migrations by setting spec.migrations.disableTLS to true to do migrations without TLS encryption.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
Add `spec.migrations.disableTLS` to the KubeVirt CR to allow disabling encrypted migrations. They stay secure by default.

/retest

/cc @davidvossel
/cc @vladikr

/retest

It looks good, all I have are some really minor nits.

@maiqueb thanks for the review. Would be great if you can have another look.

/retest

/retest

/approve

Sometimes getting the best performance is more important than encrypted migrations. For these rare cases, allow disabling migrations by setting spec.migrations.disableTLS to true to do migrations without TLS encryption.

out of curiosity, do we have any data around how much of a performance increase disabling tls provides?

out of curiosity, do we have any data around how much of a performance increase disabling tls provides?

Not for CNV, since it is not possible to disable TLS completely in CNV without this patch. I will ask for some measurements for other platforms where this proved to be effective.

Not for CNV, since it is not possible to disable TLS completely in CNV without this patch. I will ask for some measurements for other platforms where this proved to be effective.

According to performance engineering, with TLS some upper bounds with libvirt are to expect around ~5-6Mbps (no hard limit may vary), while without TLS it goes up to 3-4 times that speed. The numbers are not exact, but seems like the performance can be significant. With this change we can get numbers for CNV.

According to performance engineering, with TLS some upper bounds with libvirt are to expect around ~5-6Mbps (no hard limit may vary), while without TLS it goes up to 3-4 times that speed. The numbers are not exact, but seems like the performance can be significant. With this change we can get numbers for CNV.

whoa, yeah any increase more than 1x is significant. seems like this could indeed be very useful in some use cases.

/retest

/lgtm

@rmohr would you propagate this new knob to HCO so people who use it to deploy KubeVirt can easily utilize this new functionality?


fix: route runfiles of js_library/JsInfo 1p linked dep through npm_package_store and npm_link_package_store

Solves the following case: https://github.com/jfirebaugh/rules_ts/commit/d0e852284305102e43b3e5818f83ab265df43bc1.
Failure in that minimal repro is:
$ bazel test //examples/js_lib_pkg/b:test
INFO: Analyzed target //examples/js_lib_pkg/b:test (0 packages loaded, 0 targets configured).
FAIL: //examples/js_lib_pkg/b:test (see /private/var/tmp/_bazel_john/21a27cee0c79a1509a094219b285fcfa/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/examples/js_lib_pkg/b/test/test.log)
INFO: From Testing //examples/js_lib_pkg/b:test:
==================== Test output for //examples/js_lib_pkg/b:test:
node:internal/fs/utils:356
    throw err;
    ^

Error: ENOENT: no such file or directory, open '/private/var/tmp/_bazel_john/21a27cee0c79a1509a094219b285fcfa/sandbox/darwin-sandbox/26/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/examples/js_lib_pkg/b/test_/test.runfiles/_main/examples/js_lib_pkg/a/test.txt'
    at Object.openSync (node:fs:596:3)
    at readFileSync (node:fs:464:35)
    at Object.<anonymous> (/private/var/tmp/_bazel_john/21a27cee0c79a1509a094219b285fcfa/sandbox/darwin-sandbox/26/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/examples/js_lib_pkg/b/test_/test.runfiles/_main/examples/js_lib_pkg/a/index.js:5:43)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/private/var/tmp/_bazel_john/21a27cee0c79a1509a094219b285fcfa/sandbox/darwin-sandbox/26/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/examples/js_lib_pkg/b/test_/test.runfiles/_main/examples/js_lib_pkg/b/test.js:2:18) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/private/var/tmp/_bazel_john/21a27cee0c79a1509a094219b285fcfa/sandbox/darwin-sandbox/26/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/examples/js_lib_pkg/b/test_/test.runfiles/_main/examples/js_lib_pkg/a/test.txt'
}

The fix is to pipe runfiles through npm_package_store and npm_link_package_store so they make it down the chain of js_library -> npm_package_store -> npm_link_package_store to binaries depending on the npm_link_package_store (the :node_modules/foo target).
For reference, the rules in the minimal repro look like this:
//examples/js_lib_pkg/b:node_modules/js_lib_pkg_a is a npm_link_package_store who's src is<EMAIL_ADDRESS>$ bazel query //examples/js_lib_pkg/b:node_modules/js_lib_pkg_a --output=build
# /Users/greg/aspect/rules/js/rules_ts/examples/js_lib_pkg/b/BUILD.bazel:4:22
npm_link_package_store(
  name = "node_modules/js_lib_pkg_a",
  visibility = ["//visibility:public"],
  tags = ["manual"],
  generator_name = "node_modules",
  generator_function = "npm_link_all_packages",
  generator_location = "examples/js_lib_pkg/b/BUILD.bazel:4:22",
  src =<EMAIL_ADDRESS>)

<EMAIL_ADDRESS>is an npm_link_package_store who's src is //examples/js_lib_pkg/a:pkg:
$ bazel query<EMAIL_ADDRESS>--output=build
# /Users/greg/aspect/rules/js/rules_ts/examples/BUILD.bazel:52:22
npm_package_store(
  name =<EMAIL_ADDRESS>  visibility = ["//visibility:public"],
  tags = ["manual"],
  generator_name = "node_modules",
  generator_function = "npm_link_all_packages",
  generator_location = "examples/BUILD.bazel:52:22",
  src = "//examples/js_lib_pkg/a:pkg",
  deps = {"//examples:.aspect_rules_js/node_modules/<EMAIL_ADDRESS>"@types/node"},
  package = "js_lib_pkg_a",
  version = "0.0.0",
)

and finally //examples/js_lib_pkg/a:pkg is the js_library being linked to node_modules/js_lib_pkg_a:
$ bazel query //examples/js_lib_pkg/a:pkg --output=build
# /Users/greg/aspect/rules/js/rules_ts/examples/js_lib_pkg/a/BUILD.bazel:19:11
js_library(
  name = "pkg",
  visibility = ["//visibility:public"],
  generator_name = "pkg",
  generator_function = "js_library",
  generator_location = "examples/js_lib_pkg/a/BUILD.bazel:19:11",
  srcs = ["//examples/js_lib_pkg/a:ts"],
  types = [],
)

Can we also add that test?


HDF5 issue for ccsd_t_lambda?

Dear developers,
Hi, I'm trying to generate uccsd(t) density matrix with the ccsd_t_lambda module but seems like a bigger-sized eri with HDF5 doesn't have .conj().
I think this issue is very similar to this one >> https://github.com/pyscf/pyscf/issues/113.
My full input is like below.
from pyscf import gto, scf, dft, mp, ao2mo, cc, lib
from pyscf.tools import molden, cubegen
from pyscf.cc import uccsd_t_lambda as ccsd_t_lambda
from pyscf.cc import uccsd_t_rdm    as ccsd_t_rdm
from pyscf.cc import uccsd_t
lib.num_threads(40)
0.911, 2.100 Angs.
mol = gto.M(
verbose = 0,
atom = '''
Si      0.0000  0.0000  0.0000
H       0.0000  0.0000  -1.5141
H       0.0000  1.5132  0.0528
''',
charge     = 0,
spin       = 2,
basis      = 'aug-cc-pvqz',
max_memory = 10000,
)
myhf = scf.UHF(mol)
myhf.conv_tol = 1e-8
Ehf = myhf.kernel()
Dhf = myhf.make_rdm1()
mycc = cc.UCCSD(myhf)
mycc.kernel()
eris = mycc.ao2mo()
conv, l1, l2 = ccsd_t_lambda.kernel(mycc, eris, mycc.t1, mycc.t2)
Dccsdt_mo = ccsd_t_rdm.make_rdm1(mycc, mycc.t1, mycc.t2, l1, l2, eris=eris)

Fixed in PR #1269


Change default bins in add_histogram from 'tensorflow' to 'auto'

The default bins of  'tensorflow' in add_histogram results in weird hist plots. The calculated range usually doesn't fit the data and extends from -1e20 to 1e20. As add_histogram is implemented by using numpy.histogram, changing to 'auto' can calculate the optimal bin width, which brings better experience by default.

It was originally set to auto. see #1, https://github.com/numpy/numpy/issues/10297
I think there is another problem. If auto is used, the bin size might not be the same for each add_histogram() call, I am not sure whether tensorboard handles this.

auto reliably crashes on my system due to running out of memory. For me doane works and the shapes look ok.

@rotx I recently fixed the problem for the default tensorflow setting. You can try it with pip install git+https://github.com/lanpa/tensorboard-pytorch


Ionic Issued when Start a new project

Hi I have problem when I try to start a new project , Before I cut create a easy new project but not now.
this is ionic info
global packages:

    @ionic/cli-utils : 1.4.0
    Ionic CLI        : 3.4.0

System:

    Node       : v8.1.2
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.0.3

this is the error
C:\Users\Alfredo\Desktop>ionic start appstore sidemenu
? The directory appstore contains file(s) that could conflict. Would you like to overwrite the directory with this new
project? Yes
✔ Creating directory .\appstore - done!
[INFO] Fetching app base (https://github.com/ionic-team/ionic2-app-base/archive/master.tar.gz)
✔ Downloading - done!
[INFO] Fetching starter template sidemenu (https://github.com/ionic-team/ionic2-starter-sidemenu/archive/master.tar.gz)
✔ Downloading - done!
✔ Updating package.json with app details - done!
✔ Creating configuration file ionic.config.json - done!
[INFO] Installing dependencies may take several minutes!
> npm install
✖ Running command - failed!
[ERROR] An error occurred while running npm install (exit code 1):

        npm WARN deprecated<EMAIL_ADDRESS>Please update to the latest object-keys
        npm ERR! code 1
        npm ERR! Command failed: C:\Program Files\Git\cmd\git.EXE submodule update -q --init --recursive
        npm ERR! C:\Program Files\Git\mingw64/libexec/git-core\git-submodule: line 7: basename: command not found
        npm ERR! C:\Program Files\Git\mingw64/libexec/git-core\git-submodule: line 7: sed: command not found
        npm ERR! C:\Program Files\Git\mingw64/libexec/git-core\git-submodule: line 19: .: git-sh-setup: file not found
        npm ERR!

        npm ERR!      C:\Users\Alfredo\AppData\Roaming\npm-cache\_logs\2017-06-27T13_24_41_639Z-debug.log

some one can help me I am not only one with this problem
https://forum.ionicframework.com/t/error-when-start-new-project/95878

Hello all! We are actively looking into this issue. I am setting up the oldest similar issue as a tracking issue and therefore and closing this issue as a duplicate of https://github.com/ionic-team/ionic/issues/12158. Thanks!

@jgw96 : Can you please confirm in which thread this issue is resolved ? its keep navigating to different issues ant resolution is not available !!!


Show the rest of the menu on mobile

Right now, only the language dropdown shows up on mobile screens. We should show the rest of the menu on mobile, maybe by creating a button one can click to view a "settings" screen.

Agreed 100%, and a settings button either linking to a new page or showing a modal is the right solution. Ideally the screen should show the impact of each setting for the user with an example, e.g. switching to Bengali in the settings screen should show Bengali script.


gene.iobio should be link to gene.iobio landing page

When data has been entered and you're in the main gene window, it says gene.iobio in the top left corner. This should be a link back to the gene.iobio landing page.

This works, but there is a problem in that it makes no sense to go to the landing page when this has been launched from Nebula, myGene2, and maybe even from Mosaic. I think it makes sense for standalone gene, but not when launched from elsewhere, and it is more effort to have conditionals here, so can be just revert this back? I.e. just make it so gene.iobio is not clickable.

Fixed


Override configuration if table matches multiple regex's

I would like to specify a general configuration for all tables but override that configuration for specific tables.  For example:
[table: ^testing-]
-- config 1--
[table: ^testing-foo$]
-- config 2--
I want all testing tables to get config 1 but the specific testing-foo table to get config 2.  Is this currently possible? What do people think of this idea?

The default_options section should do what you want https://github.com/sebdah/dynamic-dynamodb/blob/master/docs/configuration_options.rst#default-configuration

No, default_options doesn't handle this.
You still have to mention all the tables so they'll be monitored.  When a tables matches more than one regular expression, which set of settings is used?

The first match is used afaik, others ignored.


Arduino Uno - volume problems

I can't seem to set the volume on Arduino Uno. Whatever value I set it to there is no sound output. If I leave it unchanged the sound is fine (but too loud :) )
// 2 channel polyphony
MusicWithoutDelay buzzer(song);
MusicWithoutDelay buzzer2(song2);

void setup() {

 // buzzer2.setVolume(75); // doesn't work
 // buzzer2.setVolume(100); // doesn't work

  buzzer.begin(CHB, TRIANGLE, ENVELOPE0, 0);   //CHB means pin 3 on Arduino UNO, CHA means pin 11
  buzzer2.begin(CHB,SAW, ENVELOPE0, 0);
}

void loop() {
  buzzer.update();
  buzzer2.update();
  .....
}

Try putting setVolume inside the loop() after each buzzer's update().

That worked!


Fix incorrect description of Web PubSub authentication docs

Fix the incorrect description of the contents of the JWT's audience. It is in
fact the exact same URL as the request URL - the query and the trailing slash
is kept, as can be seen in the official JS SDK [1].
Further, the example is wrong. The broadcast URL ends with /:send and also
requires the api-version query parameter to be set [2].
[1] https://github.com/Azure/azure-sdk-for-js/blob/3bdcd0818f48f94764d2dd76285189e9a1cc2952/sdk/web-pubsub/web-pubsub/src/webPubSubCredentialPolicy.ts#L29
[2] https://learn.microsoft.com/en-us/rest/api/webpubsub/dataplane/web-pub-sub/send-to-all?tabs=HTTP

Side note: I've set the API version in the example to the version documented elsewhere, but that version is not accepted by Azure Web PubSub services (at least not the once I created in eu-north the other day) and the published version of the JS SDK seems to use 2022-11-01, which works.

@vicancy
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Thanks for the contribution! the new version should be working now

Thanks for the contribution and pointing the version issue out, yes PROD now only supports 2022-11-01, could you also update the version to 2022-11-01? Thanks!

@alexg-axis - Can you respond to the requested changes?
@vicancy - After the changes are made, please add a #sign-off command to signal that the PR is ready to merge.
#hold-off

@vicancy I've resolved your comments.

#sign-off


[Bug]: OpenSearch integ tests should run in docker

Describe the bug
Current implementation: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/integ-test.jenkinsfile#L37
To reproduce
n/a
Expected behavior
Should use
docker {
....
}

Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

@kavilla Can you please update this issue with the current status?

Hey @bbarani, looking at the OpenSearch integ test run it looks like each component is ran in it's own docker container. But for verification a maintainer to confirm would be good and then this issue can be closed I believe.
Thanks!

Hey @kavilla the OpenSearch integ tests for CI, yes they do run in docker agents, but when executed locally its not, we can close this issue, wdyth @kavilla ?

@kavilla @prudhvigodithi @gaiksaya Can we close this issue?

Hi, team, I am gonna close this issue for now as it has been a while without further dialog. Please feel free to reopen it if needed... thanks!!


Possibility to override get_client_ip method

Hi,
First of all, thank you for this package and your work !
My problem is that I cannot find a proper configuration for django_ipware that fits my case.
My server is behind a load balancer and a reverse proxy.
The load balancer is configured in append mode and so appends the client ip address to the X-Forwarded-For header existing values or create the header with the client ip address if it does not exist in the request.
The reverse proxy does nothing in particular with this header, just passes it to the server.
So, I get something like this on the server: X-Forwarded-For = <original_data_from_client> -- ...   -- <client_ip_set_by_load_balancer>.
I configure django-axes with AXES_PROXY_ORDER = 'right-most' as I want django-axes to get the last ip address contained in the header, even if other values are invalid.
django_ipware does not enable that. It skips the whole header if the first or the last ip address is not a valid one.
https://github.com/un33k/django-ipware/blob/master/ipware/ip.py#L27
https://github.com/un33k/django-ipware/blob/930f3293eb11b2bfc221959434e8501c165a2b61/ipware/utils.py#L94
If I try to spoof my ip address using a valid ip address, all works good, django_axes gets the most-right ones but if I set an invalid ip address in the header, the whole header is skipped.
I don't know what would be the best way to fix that, if I should open an issue in django_ipware  or update django-axes to add the possibility to define a custom  and simple get_client_ip method in this case ?
Thank you !

Hey @PaulM5406!
Sure, it should be easy to implement a customization that enables overriding the get_client_ip implementation by supplying a different callable or a path to calling a different function, for example, similarly to AXES_USERNAME_CALLABLE etc:
https://django-axes.readthedocs.io/en/latest/4_configuration.html#configuring-project-settings
The current implementation for fetching the IP is:
https://github.com/jazzband/django-axes/blob/master/axes/helpers.py#L151
The same helpers.py module has different examples of using a callable for fetching different parameters as well.
Would you be interested in opening a PR for this? The feature should include at least the implementation and unit tests for it, and preferably documentation as well.

Hey @aleksihakli, i just opened a PR for this)

Hey @aleksihakli , @hirotasoshu,
Thank you for your quick response and implementation ! I couldn't believe it this has been done when I woke up this morning^^
When do you expect a new pypi release of django-axes ?
Now that it is possible to implement a custom get_client_ip, it would be nice to make the django_ipware an optional dependency. Unfortunately, I think it is not possible to specify an optional dependency that would be installed by default without adding a custom post-install script to the setup.py.

Hey @PaulM5406! This has been released as 5.41.0 on 2023-04-02.
If you figure out a good way for making the deps optional do let us know :)

Hey @aleksihakli ! Thank you, I am using this new feature and all works great !
In regards to making the deps optional, there is only one correct way to do that. It would be to exclude django-ipware from the list of the default requirements and add it as a extra_requires. People could still install it using django-axes[ipware] for example. As it would be a breaking change, may it be considered for next major version ?

Well, that would be a good way to implement the optional deps, assuming there would be a good baseline implementation for fetching the client IP address in this package.
The reason django-ipware was adopted as a baseline IP calculation solution is that it abstracts the IP management and lets a specialized package handle that part of the HTTP requests. If you think there's a good alternative solution we could use as a stock implementation I'd personally be open to improvements on that part.
There's a bunch of other "small" breaking changes that would be a good fit for a version 6.x release. I'm all for opening up e.g. a new branch for that development or alternatively freezing 5.x into a maintenance release and branch :)
See the proposed 6.x changes in:
https://github.com/jazzband/django-axes/issues?q=is%3Aissue+is%3Aopen+label%3A6.x


Search in source categories

Describe your suggested feature
Currently it's possible to group sources into categories (created in Settings » Browse » [Sources] Edit categories). My first thought was that they will be used in global search (along Pinned - that is default search scope - and All) but it seems it is only utilized in organizing sources.

Adding it here would allow for the generation of less traffic for the sources. Example: when you are searching for western comics you don't need to invoke extensions that offers manga, hentai or longstrips
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 1.11.0.
[X] I will fill out all of the requested information in this form.

Ups, it's probably a duplicate of #959 nvm


Support MySQL 8

MySQL 8.x drops mysql_install_db in favor of mysqld --initialize:
https://dev.mysql.com/doc/refman/5.7/en/mysql-install-db.html
https://dev.mysql.com/doc/refman/5.7/en/data-directory-initialization-mysqld.html

AFAIK, this package has already used mysqld --initialize.  Are you saying it does not working?

Yes, if self.mysql_install_db is None, then on line 52 find_program() will raise a RuntimeError.
Additionally, on line 123, the os.path.islink() will try to check against None.

I can :+1: this.  I think the move is to try/except/shrug in the first part, and use mysqld instead of mysql_install_db as the base file.
I'll try to PR this over the next few days!

@tk0miya / @jfhbrook - any updates? It's almost 2 years later - any chance we could get the PR that @jfhbrook has through and a new version released?

I personally have no updates.


Not possible to create datasource using Grafana 8.2.7

Attempting to create a database results in the error:
Object(...) is not a function Evaluating https://<<REMOVED>>>/public/plugins/grafana-bigquery-datasource/module.js Loading plugins/grafana-bigquery-datasource/module
Grafana:  8.2.7
Plugin: grafana-bigquery-datasource @ 1.1.0

Thanks for letting us know @michael-sawczuk looks like that the plugin is not working with 8.2.7 but works with 8.3.x and higher versions.