Add engine to Jekyll example

I get the following error when testing the Jekyll example:
Error: Templates#render cannot find an engine for: .md

great! thanks!

I just added some code comments as well, really appreciate it!

@avr btw, how do you like the new API so far? any feedback or things you would like improved?

Thanks.
I haven't gotten too far with the new stuff - just exploring.  I've bumped into a few things lately that I think this new stuff will just fix.  Specifically some context stuff.  I think the ability to define context differently for various partials could be great.  At least I think that's how I'm understanding new templates.  Ha!

At least I think that's how I'm understanding new templates. Ha!

correct! you can easily do that. You can also do fun things like apply layouts to partials :)

Actually - quick question.
I'm trying to figure out when/where I can override merging context in partials.  I would like to use Handlebars' inline attributes with a fallback to a partial's front matter if nothing is defined.
Here's an example if you have a minute to look:
https://github.com/avr/assemble-playground

Sorry - just realized that doesn't give you much.  I'm trying to use a page template:
---
title: Home Page
---
{{> image }}

This is the home page content.

With a partial template:
---
img_size: 768x512
---

I've tried image.img_size (which works in v0.6.0) and have some other examples in the repo of using inline attributes (which works) and front matter from the page (which works).
Thoughts?

sure, give me a minute to put something together

few minutes lol. I hit a bug on something in templates and ended up spending a few hours fixing it. Good news is that it's fixed. I'll be pushing up those changes - and I have an example for you. Let me get all this updated and I'll put something up here today

Great - thanks.  Hopefully, finding a bug makes things better?
Thanks for taking time to look.  After playing around with assemble-core some more last night, I should be able to move our whole framework/workflow pretty easily.  Great work.

Hopefully, finding a bug makes things better?

usually yes, and in this case it did lol. I noticed that we could easily do something with a small change while I was fixing a bug.
You can now do this with any collection:
app.on('page', function(page) {
   //=> do stuff with page
});
app.on('partial', function(partial) {
   //=> do stuff with page
});

Or this:
app.on('view', function(view, type, collection) {
   //=> "type" would be page, partial, layout etc
   //=> collection is the actual collection instance for the emitted `view`
});

I'll be pushing some stuff up in a bit. I have a pr for the assemble-playground project you created


Added support for k8s 1.16 to cloudwatch

When using the following version of kubectl:
➜ mk version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:30:10Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:22:30Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}

You get the following error when trying to create fluentd-daemonset-cloudwatch-rbac.yaml :
➜ mk create -f fluentd-daemonset-cloudwatch-rbac.yaml
...
error validating "fluentd-daemonset-cloudwatch-rbac.yaml": error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false

Similar to: https://github.com/fluent/fluentd-kubernetes-daemonset/pull/402

Thanks!


[Feature Request] Add --workspace option

Is it possible to add a --workspace option, which forces workspace = true, similar to --no-workspace, which forces workspace = false?

by default, if a workspace is detected, its running as a workspace flow meaning each task is invoked for each member.

I know, however would it be possible to overwrite workspace = false?
I'd like to expose only a minimum of tasks and use the desired task twice, once on all members and once for the root.
On Mar 1, 2019, 22:19, at 22:19, Sagie Gur-Ari<EMAIL_ADDRESS>wrote:

by default, if a workspace is detected, its running as a workspace flow
meaning each task is invoked for each member.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/sagiegurari/cargo-make/issues/199#issuecomment-468815264

the scenario is to run same task on both workspace level and member in a single run?
i'm not sure what task is relevant for both, but maybe you could do the following in your workspace level makefile (in case members do not have a makefile and automatically extend the workspace level one)
[tasks.common-task]
# whatever....

[tasks.workspace]
workspace = false
env = { "CARGO_MAKE_MEMBER_TASK" = "member" }
dependencies = ["common-task", "do-on-members"]

[tasks.member]
run_task = "common-task"

than you can run it
cargo make workspace

Since workspace task is defined as workspace=false, it will ignore the fact that its a workspace and not invoked this task on the members and instead invoke it on the workspace level.
It will first invoke common (wihch is the common task you want to run both for each member and for workspace level), than it will invoke "do-on-members" which will invoke each member with the task defined in the env CARGO_MAKE_MEMBER_TASK which is "member"
Than each member is invoked with task "member" which runs the common task (you can actually skip this extra "member" task and invoke common directly)

Thanks, your solution works!


More-recent versions of Python

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0b1dd53). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1040   +/-   ##
=========================================
  Coverage          ?   94.07%
=========================================
  Files             ?       86
  Lines             ?    12227
  Branches          ?     1228
=========================================
  Hits              ?    11503
  Misses            ?      584
  Partials          ?      140

Impacted Files
Coverage Δ

coverage/env.py
100.00% <100.00%> (ø)

tests/test_parser.py
100.00% <100.00%> (ø)

tests/modules/pkg1/__main__.py
100.00% <0.00%> (ø)

tests/test_coverage.py
99.63% <0.00%> (ø)

tests/modules/pkg1/sub/__main__.py
100.00% <0.00%> (ø)

tests/test_data.py
100.00% <0.00%> (ø)

coverage/report.py
98.00% <0.00%> (ø)

coverage/data.py
86.79% <0.00%> (ø)

tests/test_phystokens.py
100.00% <0.00%> (ø)

coverage/jsonreport.py
100.00% <0.00%> (ø)

... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1dd53...f2598ce. Read the comment docs.


App crashing after ping

When I start scanning the network, at some random time(not every time), the app crashes and I get this error. Can you please help me to fix it.

I have the same issue often.

I am also facing the same issue.

Can you please reproduce the error or give me some details? How many devices they are in the network? subnet etc?

Can you please create a project that reproduces this error? I will download it and I will try to find the issue. I did more than 20 scans in a row and the app is running fine.

https://gitlab.com/elisgjana/lan-scan-test
This is a simple app just implementing your library and by refreshing I produced these types of errors (These errors are really random: some of them I faced by refreshing more than 30 times. So, sometimes the app looks like it is working fine, but if you test it for 10 to 15 minutes it will crash at some point):

@elisgjana is exactly pointing the issues, which I also experience, out with the provided screenshots.
It isn't reproducible by code changes, it just happens after intensive testing. The problem is that app users could experience this issue directly during the first usage, so they got directly a negative app experience.
It would be really great if you can fix the issues anytime.

@mavris I am really thankful for publishing your work, not only for this library but also the others and I really understand that your time is limited, that's why I will do my best to help you in order to find a mutual solution. The only barrier for me is the lack of knowledge in Objective C that's why everything looked so abstract to me. For me this is a main feature for the application (smart home app) and this is why I am testing all the possible options. I tested the commit that @jpalten did and it fixes a lot of problems even-though the app still crashes (but not so often). I think by reviewing his commit would be a good headstart. Thanks again for your support.

@elisgjana I used your project and I added a timer for a scan every 10 seconds. It ran 106 times without a crash.  I understand that the bug is there. I will try to reproduce it on another network.
@elisgjana can you please point me to exact commit?

@mavris please refer to these changes https://github.com/mavris/MMLanScan/pull/22
@jpalten has updated the SimplePing class based on the Apple Documentation because I just opened the Apple Documentation and they haven't updated the code since 2016.
Also sometimes the app crashes as soon as it scans for the first time.

Hey @mavris ... hope you are doing well... Did you have time to test again in another network the app and could you fix the bug that is reproducing the error? If not, please tell me how can I help you in order to fix this issue.

@mavris I think I fixed one of the bugs by adding an "if condition" and checking if the socket is valid before stoping it:

The scanning looks better now, but still crashes after some time in two different points:

Can you please have a look when you have time and check what can we do to fix it.

This might be related 🤷♂
https://github.com/mavris/MMLanScan/pull/53


SublimeText lock up when selecting text on OS X

When selecting Go source code and dragging the mouse into the file list, SublimeText begins using 100% cpu and goes unresponsive, requiring a force quit as demonstrated here:
http://cl.ly/071F3m3c170n303d2L1f
I have narrowed it down to this package. When removing this package the problem goes away. I am using the latest developer build of SublimeText (2169) and the latest checkout of GoSublime.
Thoughts? I'll be happy to give you any more information I can.

Specifically, I have narrowed it down to the GsLint on_selection_modified function.

Upon further investigation, this could be a problem with ST.
Changing the on_selection_modified function to be:
def on_selection_modified(self, view):
    if gs.is_go_source_view(view):
        #set_timeout(describe_errors, 0)
        set_timeout(lambda: None, 0)

still causes the lock up for me.
I know next to nothing about developing plugins for ST, so is this is a bug with ST or GS?

confirmed, that happens to me as well. Also ST can't find a cross.png on load.

I don't have OS X and can't reproduce that one Linux. However I pushed a pending change before seeing the other comments here and I can't say if it's a ST issue but it's possible that GS could be triggering it if it was as on_selection_modified is triggered when the cursor moves.
the new change doesn't use on_selection_modified at all so hopefully that's why it hung.

It appears to be fixed with the latest commit.
Thanks for fast response.

Great, thanks for the detailed report


Tracking Link

I'm hosting ghosler and mailserver in intranet, so newsletters are being sent using the server's internal IP instead. (the tracking url ends up with http://<IP_ADDRESS> instead of the public url. Shall I edit the config file manually using external IP or you suggest something else?
Originally posted by @emanborg in https://github.com/ItzNotABug/ghosler/issues/8#issuecomment-2131404085

Hey @emanborg 👋,
The tracking link's host is the url from config file: ghosler.url.
So if your ghosler instance is reachable on the IP Address and the Public Domain too and while there isn't a setting for this in the dashboard, you can change this by editing the config file directly and restarting the instance.

Refer the source.

Hey @emanborg 👋,
The tracking link's host is the url from config file: ghosler.url.
So if your ghosler instance is reachable on the IP Address and the Public Domain too and while there isn't a setting for this in the dashboard, you can change this by editing the config file directly and restarting the instance.

Refer the source.

Alternatively, visit the ghosler instance via the public url, go to settings & simply save the settings. That should update the url.
Source - https://github.com/ItzNotABug/ghosler/blob/244575e44287af50af273bd5362cdc9cd7ac93fb/routes/settings.js#L42

Hey @emanborg,
Is your issue resolved?


Support read query hints

https://github.com/prometheus/prometheus/issues/2580

Do you anticipate any dramatic non-backward compatible changes to storage layer on this stage?

Maybe


Revert library name change

Libraries are locked to the name value specified by the library.properties metadata file in the release at the time of
the Library Manager submission.
Any release with a different name is rejected by the Arduino Library Manager indexer.
References:

https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#why-arent-releases-of-my-library-being-picked-up-by-library-manager
https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-change-my-librarys-name

Hi @per1234.
I am not aware I changed the name and it seems the Arduino Library Manager picks up the library.

Could you explain what the problem is?

Hello.

I am not aware I changed the name

Here it is:

MoonPhase -> moonPhase-esp32: https://github.com/CelliesProjects/moonPhase-esp32/commit/8f706e20a76d5bb672eaae86a16bfb399a6e9084
moonPhase-esp32 -> moonPhase: https://github.com/CelliesProjects/moonPhase-esp32/commit/4209d74d00f4430d46f52e5aa92ac158ceb68352

it seems the Arduino Library Manager picks up the library.

It picked up the releases up until the name was changed. Note that the current 1.0.2 is not available.

Hi @per1234 .
First of all thanks for pointing this out.
I do have some questions.
The PR has been merged and  I believe everything checks out as per the links you provided but still the latest version is not visible in the library manager.
Something else I should fix? Or just be patient?

The fix is not retroactive. The 1.0.2 tag remains non-compliant, and so will continue to be rejected by the indexer:
https://github.com/CelliesProjects/moonPhase-esp32/blob/1.0.2/library.properties#L1
However, any new tags/releases that are made will be compliant and will be added automatically to the Library Manager index.

@per1234
Thanks for the answers and the fix.
Everything works again like it should.


Inconsistencies between documentation/annotations and behavior

naturaltime() supports timedelta.
It is not documented, but humanize.naturaltime() accepts timedelta. I used it for years until type annotations were added, and MyPy started to complain. timedelta is still accepted at runtime.
>>> import datetime, humanize
>>> humanize.naturaltime(datetime.timedelta(days=5, hours=3))
'5 days ago'
>>> humanize.naturaltime(datetime.timedelta(hours=123))
'5 days ago'

I expect one of two things:

Document that humanize.naturaltime() accepts timedelta, not only datetime | int and update type annotation.
Make humanize.naturaltime() rejecting timedelta (of course, after some deprecation period).

Option 1 is more compatible, but option 2 looks more logical.
naturaltime() and naturaldelta() accept not only int, but float too.
>>> humanize.naturaltime(23.5)
'23 seconds ago'
>>> humanize.naturaldelta(23.5)
'23 seconds'

It is expected, since timestamp in Python is float, but it should be documented, and annotations should be updated.
naturaltime(), naturaldelta() , naturaldate() and naturalday() accept arbitrary object without error.
>>> humanize.naturaltime([1, 2, 3])
'[1, 2, 3]'
>>> humanize.naturaldelta([1, 2, 3])
'[1, 2, 3]'
>>> humanize.naturaldate([1, 2, 3])
'[1, 2, 3]'
>>> humanize.naturalday([1, 2, 3])
'[1, 2, 3]'

It is unsafe, because allows programming errors to slip unnoticed. humanize.naturalsize() raises an error, as expected.
Humanize 4.2.1

naturaltime() supports timedelta.

...

I expect one of two things:

Document that humanize.naturaltime() accepts timedelta, not only datetime | int and update type annotation.
Make humanize.naturaltime() rejecting timedelta (of course, after some deprecation period).

Option 1 is more compatible, but option 2 looks more logical.

Let's do option 1, possibly with some tests.
Option 2 with deprecation could be sensible too, let's also check what the Django naturaltime does.
Feedback from others welcome!

naturaltime() and naturaldelta() accept not only int, but float too.

...

It is expected, since timestamp in Python is float, but it should be documented, and annotations should be updated.

Yep, let's update those.

naturaltime(), naturaldelta() , naturaldate() and naturalday() accept arbitrary object without error.

...

It is unsafe, because allows programming errors to slip unnoticed. humanize.naturalsize() raises an error, as expected.

Yeah, I do find it a little odd to catch things like ValueError, TypeError, AttributeError and then just return str(value), but it's done that for a long time and I didn't want to break backwards compatibility.
Maybe we should also check what the Django ones do and consider deprecating and removing in a major bump.
Feedback from others also welcome here!

naturaltime() and naturaldelta() accept not only int, but float too.

If I'm not mistaken, this looks like the issue that was fixed in 4.2.2. (And thank you for that!)

naturaltime() supports timedelta.

Document that humanize.naturaltime() accepts timedelta, not only datetime | int and update type annotation.
Make humanize.naturaltime() rejecting timedelta (of course, after some deprecation period).

Let's do option 1, possibly with some tests.

This issue, however, seems to still be open as of 4.2.2. If option 1 is still on the table, that would (in my opinion) be ideal!
Here's an example of how I'm using naturaltime() with a timedelta, along with # noinspection PyTypeChecker as a workaround for now. 😅 As far as I can tell, naturaltime() seems to be the most intuitive function for my desired output (e.g. "1 year, 10 months ago").
Please let me know if I'm misunderstanding something, or if that sounds reasonable! I'm happy to try to put together a PR to add documentation/annotations for timedelta, if that's the direction you want to take.

naturaltime() and naturaldelta() accept not only int, but float too.

If I'm not mistaken, this looks like the issue that was fixed in 4.2.2. (And thank you for that!)

Ah, correct, it was indeed the float issue fixed in 4.2.2, sorry for the mixup :)

naturaltime() supports timedelta.

Document that humanize.naturaltime() accepts timedelta, not only datetime | int and update type annotation.
Make humanize.naturaltime() rejecting timedelta (of course, after some deprecation period).

Let's do option 1, possibly with some tests.

This issue, however, seems to still be open as of 4.2.2. If option 1 is still on the table, that would (in my opinion) be ideal!
Here's an example of how I'm using naturaltime() with a timedelta, along with # noinspection PyTypeChecker as a workaround for now. 😅 As far as I can tell, naturaltime() seems to be the most intuitive function for my desired output (e.g. "1 year, 10 months ago").
Please let me know if I'm misunderstanding something, or if that sounds reasonable! I'm happy to try to put together a PR to add documentation/annotations for timedelta, if that's the direction you want to take.

Yes, option 1 is still on the table, PR welcome! Please include a test case passing a timedelta to naturaltime(), if there's not already.

And the naturaldelta() + timedelta fix has been released in 4.2.3. Thanks!

@sodul In which function? And what version of Humanize are you using?


object_store: retry on response decoding errors

Closes https://github.com/apache/arrow-rs/issues/6287
This PR includes reqwest::Error::Decode as an error case to retry on, which can occur when a server drops a connection in the middle of sending the response body.

Have you tested this, I ask as the retry logic is occurs before the response body processing

Have you tested this, I ask as the retry logic occurs before the response body processing

I haven't. My assumption was that this error originates from within the reqwest client, so we should be able to catch it here. Even in the streaming case I thought we should still be polling data from the RetryClient, but I will look more closely at the dataflow here to see what I've missed.
Testing this is a bit annoying without mocking the inner client, which isn't exactly a real world scenario. I am not very familiar with the existing testing harness so if you have any recommendations on where to start I would appreciate it.

I thought we should still be polling data from the RetryClient

Unfortunately, more broadly speaking this is not generally possible, as discussed on the ticket. Once response streaming has started, a retry would need to somehow resume from where it left off, the semantics of which will depend on the method in question. I do not know of a good way to handle this.

Testing this is a bit annoying without mocking the inner client, which isn't exactly a real world scenario. I am not very familiar with the existing testing harness so if you have any recommendations on where to start I would appreciate it.

We already have a mock HTTP server harness for running these sorts of tests

Unfortunately, more broadly speaking this is not generally possible, as discussed on the ticket.

Could you link me to where this is discussed? I'm afraid there's been a lot of comments around this spread across various issues, so it is hard to find specific discussions.

Once response streaming has started, a retry would need to somehow resume from where it left off, the semantics of which will depend on the method in question. I do not know of a good way to handle this.

Is "method" in this context referring to the HTTP method?
Perhaps we need a RetryStream to wrap the response stream in? I am not sure how that would hook up to the existing trait methods exactly, but it seems necessary if we want to transparently re-initiate response streaming.
https://github.com/apache/arrow-rs/issues/6287 suggests having a manual way to re-initiate the request, but I'm not sure what that would look like either.

Could you link me to where this is discussed?

https://github.com/apache/arrow-rs/issues/6287#issuecomment-2302902577

Perhaps we need a RetryStream to wrap the response stream in? I am not sure how that would hook up to the existing trait methods exactly, but it seems necessary if we want to transparently re-initiate response streaming.

I think we could add a method to RetryableRequest to return a Result<Bytes> that can be used by non-idempotent, non-streaming requests, such as ObjectStore::list, and which will retry errors during response streaming by retrying the entire request.
However, ObjectStore::get will require retrying at a higher level, as not only will it need to keep track of the current offset, but compute a new range for the retry, and re-sign the resulting request. Perhaps something in GetClientExt might work :thinking:


Update to latest common to make CI work again

RHEL CI tests seem to be failing because some of the other PRs updating images (that are being built part of s2i-{core,base} CI) to latest common are not yet merged into master. This will be fixed once everything else is merged so we can just re-run the tests later.

[test]

[test]

Could this be please updated to the latest commons hash first?  I think it is worth it, as the (not)squashing logic is in better shape now.

Ah yes, I forgot this PR existed.
Rebased to master and pulled in latest common scripts again.

Tests passing, so I will merge this.


chore: update to snake_case + placeholder test files

Changes

updated all files/folders to snake_case
added placeholder test files

UI

No visible changes

I was looking online at different flutter app projects and googled its naming conventions. The conclusion I came to was that snake_case is the standard/convention for naming dart files/folders. I think we should follow this convention as we want to maintain industry standards.


improved the connectivity indicator for a/b testing and codeless.

improved the connectivity indicator for a/b testing and codeless. Removed automatic connection to a/b testing on launch for debug mode.

In the future for UI changes, we should attach screenshots to the PR.

The fundamental approach of animation is incorrect in this pull request. There are 3 problems with the current approach.

The resolution of NSTimer is not guaranteed.
You are performing the animation code on the CPU, animation belongs on the GPU.
Since you are animating based on a counter and not based on a time delta this animation will run at different speeds on different hardware.

Let's investigate animating the layers with Core Animation to achieve a hardware accelerated approach.


Fixed Product image is missing on PDP

Related issues

closes #3483
Short description and why it's useful

Fixed function call scope
Screenshots of visual changes before/after (if there are any)

Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[x] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[x] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

@przspa can you please share the credits for this issue in the changelog with https://github.com/DivanteLtd/vue-storefront/pull/3484

@pkarw done :)


chore: add build target to refresh lockfile, and refreshing lockfile

Description of changes
Add a build target to refresh our lockfile, and updating our current lockfile.
Issue #, if available
N/A
Description of how you validated changes
Ran the target
Checklist

[x] PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #608 (b29b9cf) into main (27b1298) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   62.95%   62.95%
=======================================
  Files         278      278
  Lines       18017    18017
  Branches     4330     4330
=======================================
  Hits        11342    11342
  Misses       6092     6092
  Partials      583      583

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


GCP provision failure: Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally.

TASK [openshift_gcp : Provision GCP resources] *********************************
Monday 21 May 2018  09:25:08 +0000 (0:00:03.093)       0:09:12.381 ************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["/tmp/openshift_gcp_provision.sh"], "delta": "0:00:37.244839", "end": "2018-05-21 09:25:45.788165", "msg": "non-zero return code", "rc": 1, "start": "2018-05-21 09:25:08.543326", "stderr": "WARNING: mode is deprecated. Please use subnet-mode instead.\nERROR: (gcloud.compute.networks.create) Could not fetch resource:\n - Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally.", "stderr_lines": ["WARNING: mode is deprecated. Please use subnet-mode instead.", "ERROR: (gcloud.compute.networks.create) Could not fetch resource:", " - Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally."], "stdout": "", "stdout_lines": []}

https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_gce/3067
@smarterclayton

https://ci.openshift.redhat.com/jenkins/job/test_branch_openshift_ansible_extended_conformance_gce/776

Seems like a GCP jobs are stuck on this right now.

The Jenkins upgrade caused clusters not to get torn down.  I cleaned up
manually yesterday - possible still not being cleaned up, or garbage left
behind.
On May 21, 2018, at 6:37 AM, Michalis Kargakis<EMAIL_ADDRESS>wrote:
TASK [openshift_gcp : Provision GCP resources] *********************************
Monday 21 May 2018  09:25:08 +0000 (0:00:03.093)       0:09:12.381 ************
fatal: [localhost]: FAILED! => {"changed": true, "cmd":
["/tmp/openshift_gcp_provision.sh"], "delta": "0:00:37.244839", "end":
"2018-05-21 09:25:45.788165", "msg": "non-zero return code", "rc": 1,
"start": "2018-05-21 09:25:08.543326", "stderr": "WARNING: mode is
deprecated. Please use subnet-mode instead.\nERROR:
(gcloud.compute.networks.create) Could not fetch resource:\n - Quota
'SUBNETWORKS' exceeded.  Limit: 450.0 globally.", "stderr_lines":
["WARNING: mode is deprecated. Please use subnet-mode instead.",
"ERROR: (gcloud.compute.networks.create) Could not fetch resource:", "

Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally."], "stdout":
"", "stdout_lines": []}

https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_gce/3067
@smarterclayton https://github.com/smarterclayton
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/aos-cd-jobs/issues/1393, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p2LzuxLFuFofZRSwLwEkhBQMv4HGks5t0pjRgaJpZM4UGyF8
.

I'm seeing this on the 3.9 branch, are there separate queues for each branch?
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_gce_39/288/consoleFull#5070562758b6e51eb7608a5981914356


feat(acvm)!: switch to accepting public inputs as a map

Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
verify_from_cs and verify_with_vk now accept a BTreeMap<Witness, FieldElement>. This is used in combination with the explicit ABI->Witness map in https://github.com/noir-lang/noir/pull/851 to handle multiple ABI fields (params + return value) being mapped to the same witness index semantically.
I've reverted the change to verify_from_cs as we should leave it unchanged until we remove it.
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[ ] I have linked this PR to the issue(s) that it resolves.
[ ] I have reviewed the changes on GitHub, line by line.
[ ] I have ensured all changes are covered in the description.

Additional context
(If applicable.)

Approved by @kevaundray in person (also a reminder to set up branch protection!)


PartialMax/MinBy that return some count of extrema

Since #328 changes MaxBy and MinBy to return a list, I propose to add PartialMaxBy and PartialMinBy that take an extra parameter indicating the maximum count of extrema elements to return. It avoids wastage building a list of all extrema elements ~and scanning the entire source sequence~ when one may be satisfied with, for example, any of the first ones.

It does not make sense, because we always have to Scan The entire source, since the extreme element may be the last one.

@leandromoh Of course 🤦♂ and thanks for setting me straight. However, it is still useful to not have to waste building a list of all extrema if one is happy with less.

@atifaziz How common is this cenario (source with great number of extrema elements)?
Does it justify a new operator?

@leandromoh I can't speak for the world so it's hard for me to say whether it's common or not. The one time I did need MinBy and MaxBy, I know I needed a list as a result. Asking for a single item (as they've been implemented up to now) means you'll get any one of the extrema and that's rarely useful.
The real reason for proposing partial versions is to provide an option for those people who have been relying on MinBy and MaxBy returning a single item as we've made a breaking change and both methods have been part of MoreLINQ's history for an exceptionally long time; in fact, since as early as the second commit! They have even been mentioned in the book Thinking in LINQ!
PartialMinBy and PartialMaxBy with an upper limit are interesting if you're want some sample of an extremum, like 10 files of the largest files size in a directory. For small samples, I agree you can compose MinBy or MaxBy with Take.


Allow nodes to be draggable when layout is set to none, or keep nodes fixed when dragged in force-layout graph

Version
5.0.2
Steps to reproduce
Create any graph diagram with layout set to none or force. When draggable is set to true on force layout, all of the nodes shuffle and its not good to control. When layout is set to none and positions are fixed, draggable cannot be set
What is expected?
I expect to be able to set draggable on 'layout: none' or have some setting on force layout to keep other nodes static while one is being dragged
What is actually happening?
All nodes move or no nodes move at all

I am trying to create a directional node graph which represents software architectures, the user should be able to customise the layout of their architecture by dragging and dropping nodes

This old issue is on the same topic: https://github.com/apache/echarts/issues/6467

This is not a bug because the document states:

Only available when using force-directed layout.

I will mark this as a new feature.

An suggestion of circular layout dragging:


audio services: use mkEnableOption

Motivation for this change
Many, many services use the following snippet:
      enable = mkOption {
        default = false;
        type = types.bool;
        description = ''
          Whether to enable Mopidy, a music player daemon.
        '';
      };

That's why mkEnableOption was created!
  mkEnableOption = name: mkOption {
    default = false;
    example = true;
    description = "Whether to enable ${name}.";
    type = lib.types.bool;
  };

KISS, DRY, etc. I wrote the following (unreadable) script:
#!/usr/bin/env nix-shell
#! nix-shell -i bash -p ag

cd "$1"

for file in $(IFS=\n ag -l "enable = mkOption"); do
  perl -0777 -p -i -e 's/(.+?)enable\s+=\s+mkOption\s+\{.+?to enable (.+?)\..+?};/\1enable = mkEnableOption "\2";/igs' "$file"
done

which I propose we use on everything in nixos/modules. I wanted to create this small PR first to discuss the possible implications of that massive change before actually implementing it.
We'd definitely need to be cautious about only using this function on services that are disabled by default.
What do y'all think?
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

We should definitely skim the diff, but that script should be very useful, thanks! :+1:
Merging this as it won't be controversial. :wink:


Does not support multiple currency conversion

Example:
The order is 100 USD,
but the client is browsing using Japanese yen prices ( aprox 11,171 JPY)
Bitpay opencart plugin will ask for 100 JPY worth of BTC
:(

BitPay invoice should be created use the amount & currency of the store (100 USD), just like is done in Magento.


Return a proof that a message has been included in a block

The app's client currently returns a timeout error when broadcasting a WirePayForMessage in "block" mode, as the app has no way of actually knowing when a WirePayForMessage was successfully processed into a block.
This is due to the malleation of WirePayForMessages into MsgPayForMessages, which causes us to not properly register or prove that a given message has been included in a block, even though it is.
We need to investigate what needs to be done from an implementation perspective to fix this.

This also impacts users if they submit such a tx on the command line. Users can't query if the tx inclusion was successful or not via celestia-appd q tx <txhash>. Another thing I've noticed is that the payformessage txs also do not show up in the block explorer. Which might also be related.
I'll add this to the testnet project and I think we should prioritize fixing this.

This also impacts users if they submit such a tx on the command line. Users can't query if the tx inclusion was successful or not via celestia-appd q tx <txhash>. Another thing I've noticed is that the payformessage txs also do not show up in the block explorer. Which might also be related.
I'll add this to the testnet project and I think we should prioritize fixing this.

closed with #615


Use new collection card on profile as we have on explorer

replace it with new collection card - same as on explore

👋

We need to write resolvers for that
indexer side:
snek: https://github.com/kodadot/snek/issues/142
rubick: https://github.com/kodadot/rubick/issues/184
frontend side:
update collectionListWithSearch.graphql for collection search
update collectionListByAccount.graphql for collection in the user profile page
refactor components/collection/CollectionCard.vue and components/collection/CollectionDetail.vue

Let's wait for someone could write the resolver on the indexer side.

actually there is series resolver which was added by @roiLeo and that can help :)

sorry for dumb question

There is no dumb question

loligo repo is empty

Loligo is repo for tasks that should be implemented on both rubick and snek

where should these resolvers reside?

They usually chill in src/server-extension

Any update on this? Would help me create a transition profile page

Any update on this? Would help me create a transition profile page

seems blocked on the indexer side. Maybe we can continue on the collection tab later?
I already initiated a placeholder to use a similar design to the collection page https://canary.kodadot.xyz/ahk/u/CtkRtkQkkShfDxG4craGJnqb6oMQfjK5aF6gKoSrN1uTsuh?page=1&redesign=true.
But if that is drastically different from your design, we can drop that

@preschian Actually, I will make an issue for a transitional profile soon till we figure out multichain, follow, verification, edit of the profile, etc. I am reusing as much layout as possible so it will be fast and not complicated.
So more than this pr is needed in order for the collection cards to work?

https://github.com/kodadot/snek/pull/170


Pixmap.getPixels() doesn't return the pixel data for GWT

Platform: GWT
Expected: Pixmap.getPixels() returns a "native" nio buffer backed by the canvas pixel array.
Actual: An int buffer of size 1 containing the image id is returned.

See: https://github.com/libgdx/libgdx/pull/3665

Well I guess that explains to some extent why the method doesn't do what one would expect.
It doesn't explain why it does something completely different, making debugging more tricky than necessary (opposed to an exception).
Shouldn't there be at least a warning in the JavaDoc that the method doesn't work for the web platform?
While it would certainly be possible to implement a ByteBuffer that behaves as expected (e.g. accessing pixels via the Pixmap instance with a null check), it would probably be relatively inefficient, in particular for writing... Is there any chance of adding bulk data read / write methods that can actually work efficiently on all platforms?

We have a readme in the backend that discusses issues https://github.com/libgdx/libgdx/blob/master/backends/gdx-backends-gwt/issues.txt
I'll link to that in the respective places in the wiki.


Removes grey square that appears in the corner of some pages

Fixes #92
The small grey square is due to the scrollviews in Ionic. As far as I was aware, this occurred on the Contacts, Settings and Network Status pages, so I fixed it there by adding overflow-y: auto;. Since it seems to be creating "momentum"  on iOS devices, we should have it set to overflow-y: scroll in that case. This can be achieved by using .content-ios according to this comment, but I don't have an iOS device to properly test this.

Do you have a screenshot of that grey square?

Lucio, check #92.


[Alphaserver] 8 LUNs reported for one drive

As reported by pacjunk on Discord using recent develop code:
On an Alphaserver workstation, an attached hard drive image gets reported as 8 separate LUNs, all pointing at the same volume. So data written to one appears in all 8.
"Another issue, on the Alphaserver each drive is listed 8 times. So instead of seeing DKA200, it seems DKA200, 201, 202, 203, 204 etc. Now the drives do work and don't cause any problems, they just appear mutiple times. "

AXP.TXT
So far they shared this analysis on the workstation side.

@Pacjunk The code location where rascsi currently reports an unsupported LUN was not executed. I updated the logging code, but would need a new log (debug level should be sufficient). Can you provide a new logfile based on the code in the lun_handling_update branch?

OK, I'll do another rebuild (takes a long time!) and get back to you...

Here you go...
rascsi.log

It looks like if I just do a "show device" at the console (no OS running), then it just sends multiple enquiries - no other traffic. The above log shows this plus the OS booting and using the drive, so harder to see the information.
 RAscsi does not check the LUN number and just responds with the ID2 information 8 times!

OK. I will update. Are there fields present for sublun? My devices appear as 200-207, so maybe the lun is always 0 and the sublun is the one changing.

As you can tell, I don't know a lot about the internals of SCSI. I'm just looking around for things that might be an issue. Unfortunately some of these vintage systems don't want to conform to current SCSI standards...

lun_trace.log

OK. Let me know when you need more testing/logs. I assume @rdmark needs to close this ticket as he opened it?

Just re-read everything and it all makes sense now. Thanks for tracking it down and educating me as well!


Web UI instructions and port mapping

The readme should include instructions on how to access the webui. It's buried in the docker instructions but not explicitly called out anywhere.
The web port should be configureable. It defaults to 5000 I think but could that be changed in case people are running other workloads on the same host with the same port?

Awesome. If you add something about this to the readme that should be enough. I'm not sure the nabu community are all that familiar with asp.net. I know I'm not.


[Bug] The manually added detail explanation of rollout trait is overriden

Describe the bug

The generated ref doc is great, though it will override the manually added detail explanation of rollout trait, i.e.: https://github.com/oam-dev/kubevela/blob/efb76ee5ee16a09aaba4b4e612b3165436852e0e/docs/en/developers/references/traits/rollout.md#how-rollout-works
We need to improve the doc gen, or move that section to somewhere else (for example, the user doc of rollout).

I moved the special part of rollout Conflicts With and how-rollout-works to the design section https://github.com/oam-dev/kubevela/blob/master/design/vela-core/rollout.md.

I moved the special part of rollout Conflicts With and how-rollout-works to the design section https://github.com/oam-dev/kubevela/blob/master/design/vela-core/rollout.md.

@zzxwill It's not correct to me, all those information are not design doc, especially the conflictsWith section. They are part of user facing doc.
Doc gen should come from the whole definition object. For example, including description, conflictsWith, appliesTo etc. The how-to section could be a link to a separate file under same dir.
Please revise this issue or handle them manually for now.

@zzxwill It's not correct to me, all those information are not design doc, especially the conflictsWith section. They are part of user facing doc.
Doc gen should come from the whole definition object. For example, including description, conflictsWith, appliesTo etc. The how-to section could be a link to a separate file under same dir.
Please revise this issue or handle them manually for now.


Alicloud DNS support

What this PR does / why we need it:
Support Alicloud DNS
Which issue(s) this PR fixes:
Fixes #367
Special notes for your reviewer:
Please be noted that the terraform DSN record resource structure for Alicloud is quite different with other providers like AWS. No hosted zone id needed.

Hi @jia-jerry, you have been invited now.

Surprising, but I couldn't look deeper, please contact @ccwienk.

Hi @vlerenc
Log in issue solved. I need to accept your invitation. I thought I joined automatically after I received your mail.
Will follow up the build error.

The concouse failure of original PR seemed caused by github server issue:
Identity added: /tmp/git-resource-private-key (/tmp/git-resource-private-key)
/usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/gardener/gardener/statuses/22c596fef03bf8b302e69f1a667429f4ceee76a9: 502 - Server Error (Octokit::BadGateway)
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:9:in `block in call'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:61:in `on_complete'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:8:in `call'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:146:in `call!'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:115:in `call'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/rack_builder.rb:143:in `build_response'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/connection.rb:387:in `run_request'
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/connection.rb:175:in `post'
	from /usr/lib/ruby/gems/2.4.0/gems/sawyer-0.8.1/lib/sawyer/agent.rb:94:in `call'
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/connection.rb:156:in `request'
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/connection.rb:28:in `post'
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/client/statuses.rb:43:in `create_status'
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit.rb:46:in `method_missing'
	from /opt/resource/lib/status.rb:15:in `create!'
	from /opt/resource/lib/commands/out.rb:59:in `block in output'
	from /opt/resource/lib/commands/out.rb:52:in `each'
	from /opt/resource/lib/commands/out.rb:52:in `output'
	from /opt/resource/lib/commands/out.rb:117:in `<main>'

I just rebased the master branch of the sourse and push it to this PR.

@jia-jerry can we review again? Or do you need to change more?

@rfranzke , yes,  please help review it. Or do I need a squash?

Thanks @jia-jerry, will do on Monday! Yes, if no other things need to be changed/addressed I'd kindly ask you to squash. But you can wait with that until after my review.
Have a nice weekend!

@rfranzke , I squashed all the commit based on your and @timuthy 's review. Any other comments?


Docker rmi fails if there are no images to remove

Overview
The root ./Makefile has a docker rmi command to remove any local docker images as a part of the clean up. docker rmi fails if there are no images to remove (which happened to me on a newly setup dev machine).
Solution
Will use docker inspect to check if the image exists and then will delete it if so. This is preferred over using docker images since there can be performance issues using docker images on machines with a lot of docker images.

Closing as code was removed


allow partially specified type arguments

Currently when it comes to using generics a developer has 2 options:

to specify all type arguments
to omit all of them altogether

I am a big fan of the latter but it doesn't always work because of inference failure. Quite often it only takes  one explicitly specified type argument to help the inference algorithm to deduce the rest of the types, but there is no such option to specify just one.
function fold<Values, Value, Cursor, Direction, Hint, Result>(
   values: Values,
   result: Result,
   start: (values: Values) => Cursor | void,
   advance: (cursor: Cursor) => Cursor | void,
   valueAt: (cursor: Cursor) => Value & Direction,
   hintAt: (cursor: Cursor) => Hint
   folding: (result: Result, value: Value & Direction, hint: Hint) => Result
) : Result {
return undefined;
}

Example. Almost everything is inferred but the Direction type parameter, which is specified explicitly via hypothetical syntax:
let result = fold<,,, AsTowardsLatest,,>(values, result, start, advance, valueAt, hintAt, folding);

Alternatively named arguments might be considered (hypothetical syntax)
let result = fold<Direction = AsTowardsLatest>(values, result, start, advance, valueAt, hintAt, folding);

This looks confusing, with little value. https://github.com/Microsoft/TypeScript/issues/2175 should be the way to go.


feat: Add on-call policy

add  on call policy

@stevenj Thank you for your feedback. I added Resolution Times section.


Error when running manage start

for controller-db  Cannot start service controller-db: driver failed programming external connectivity on endpoint vc-authn-oidc_controller-db_1 (bce5da213f86718b0eacbcf17e45adf404a2de31562cb416e6587be9f688a287): Error starting userland proxy: listen tcp <IP_ADDRESS>:5432: bind: address already in use
The above error is thrown and I am unable to proceed, i dont have any other ports occupied outside of what is in the script and VON network.

I think 5432 is a Postgres port usually.  Do you have another postgres Docker container running?

No, only a local VON network and this repo.

Found it, sorry my bad, there was another non dockerized instance of postgres running.

Not sure what it is, but something is using the port normally used by Postgres.  Looks like in running the script you can set the database port to something else by doing:
DATABASE_PORT=5432 ./manage ...

Where you pick some other port than 5432 since it is in use.


ListWheelScrollView doesn't work

I saw this article and wanna implement ListWheelScrollView in my application.
But I couldn't implement for 2 days.... item doesn't move and only wrapping container move. What is the problem? I also asked stackoverflow
Here is my code and gif of problem
@override
Widget build(BuildContext context) {

  return BlocBuilder<SearchEvent,SearchState>(
    bloc: widget.searchBloc,
    builder: (context,state){
      if(state.isKeyboardOn){
        return SearchProcessingMessage(message: '영화를 검색해주세요.');
      }
      if(state.isMovieAPICallLoading) {
        return SearchProcessingMessage(message: '영화를 찾고 있습니다...');
      }
      if(state.isMovieAPICallSucceeded && widget.movieList.isEmpty) {
        return SearchProcessingMessage(message: '찾으시는 영화가 없습니다.');
      }
      return Expanded(
        child: ListWheelScrollView(
          controller: _controller,
          physics: FixedExtentScrollPhysics(),
          clipToSize: true,
          itemExtent: 200.0,
          children: widget.movieList.map((movie) =>
            Container(
              color: Colors.red,
              child:SearchMovieForm(
              movie: movie,
              searchBloc: widget.searchBloc,
            ))).toList()
        )
      );
    }
  );
}

Thanks for your reading...

Exact same problem. Only some child widgets seem to be supported.

I saw there is an answer on the SO question.
Have you solved the problem?

Hi @baeharam
Are you still experiencing the issue with the latest stable version of Flutter?
If so, can you please provide your flutter doctor -v
and  a reproducible minimal code sample?
Thank you


Add the ability to assume a role for ec2 discovery

Adds the option to assume a role during ec2 discovery.  Unlike using a profile this does not require a static set of credentials.
Add the following to your ec2 discovery config if you would like use the feature.
rolearn: 'arn:aws:iam::account-id:role/role-name'
@brian-brazil Please let me know if you would like any more information or require any changes.

👍

@grobie are you happy with the changes?

Thanks, looks good! Please open a PR against the next_release branch in prometheus/docs, document the new field and mention me. I'll merge both PRs afterwards.


Use a InheritableThreadLocal for WireMock

After upgrading from 1.x to 2.x I saw an issue where tests that used a timeout were failing due to the configuration set in a before class being lost. This change moves the WireMock from a ThreadLocal to an InheritableThreadLocal so that configuration is preserved but can still be overriden by new threads.

Well, I never knew that even existed. Thanks!


Fix for a changed gamedata folder for both D1 and D2 on Steam.

Common Code Submissions

[y] Have you verified that the changes are isolated to the features or fixes you are wanting to do?
[y] Have you tested at least one of the engines to ensure that your changes do not break existing workflow?
[y] Have you described what your changes are accomplishing?

More context: both Descent games got an update lately (among other things it seems to introduce a native DOSBox executable for Linux, you can see it on SteamDB in detail) that broke both launchers for DXX-Rebirth engine since .hog files got moved to '/descent/' and '/descent2/' directories along with other gamedata files. This PR fixes it by pointing engines to the corresponding new directory.

Looks good thanks, I also committed this https://github.com/luxtorpeda-dev/packages/commit/03b89aea281d1035818c5c8e18da4ff25f79b383 to fix the music being in the wrong path as well.

Yeah, works like charm, thanks.


TypeError: 'NoneType' object is not callable

TypeError                                 Traceback (most recent call last)
 in
12                                         output_attentions=True)
13     input_ids = torch.tensor([tokenizer.encode("Let's see all hidden-states and attentions on this text")])
---> 14     all_hidden_states, all_attentions = model(input_ids)[-2:]
TypeError: 'NoneType' object is not callable

What is the code you are running to get this error?

I assume it is when trying to run the "quick tour" from the readme. I'm getting the same error and found the same issue in #712 where the feedback was "usually, this comes from the library not being able to reach AWS S3 servers to download the pretrained weights". However, I also tried running it on Google Colab (with 1Gbit connection) with the same result.
ERROR:pytorch_transformers.modeling_utils:Model name 'xlm-mlm-enfr-1024' was not found in model name list (bert-base-uncased, bert-large-uncased, bert-base-cased, bert-large-cased, bert-base-multilingual-uncased, bert-base-multilingual-cased, bert-base-chinese, bert-base-german-cased, bert-large-uncased-whole-word-masking, bert-large-cased-whole-word-masking, bert-large-uncased-whole-word-masking-finetuned-squad, bert-large-cased-whole-word-masking-finetuned-squad, bert-base-cased-finetuned-mrpc). We assumed 'xlm-mlm-enfr-1024' was a path or url but couldn't find any file associated to this path or url.
ERROR:pytorch_transformers.modeling_utils:Model name 'xlm-mlm-enfr-1024' was not found in model name list (bert-base-uncased, bert-large-uncased, bert-base-cased, bert-large-cased, bert-base-multilingual-uncased, bert-base-multilingual-cased, bert-base-chinese, bert-base-german-cased, bert-large-uncased-whole-word-masking, bert-large-cased-whole-word-masking, bert-large-uncased-whole-word-masking-finetuned-squad, bert-large-cased-whole-word-masking-finetuned-squad, bert-base-cased-finetuned-mrpc). We assumed 'xlm-mlm-enfr-1024' was a path or url but couldn't find any file associated to this path or url.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-11-3ed6cc19ece0> in <module>()
     41                                     output_attentions=True)
     42 input_ids = torch.tensor([tokenizer.encode("Let's see all hidden-states and attentions on this text")])
---> 43 all_hidden_states, all_attentions = model(input_ids)[-2:]
     44
     45 # Models are compatible with Torchscript

TypeError: 'NoneType' object is not callable

Yes  I have same error. I ran the same "quick tour".

I got the same issue in both Google Colab and my PC. Any idea how to solve it?

As I understand, in the loop
`for model_class, tokenizer_class, pretrained_weights in MODELS:
# Load pretrained model/tokenizer
tokenizer = tokenizer_class.from_pretrained(pretrained_weights)
model = model_class.from_pretrained(pretrained_weights)
# Encode text
input_ids = torch.tensor([tokenizer.encode("Here is some text to encode")])
with torch.no_grad():
    last_hidden_states = model(input_ids)[0]  # Models outputs are now tuples`

the value of variable pretrained_weights is 'xlm-mlm-enfr-1024', not 'bert-base-uncased'. That's why we got error when running
model = model_class.from_pretrained('bert-base-uncased',                                     output_hidden_states=True,                                     output_attentions=True) input_ids = torch.tensor([tokenizer.encode("Let's see all hidden-states and attentions on this text")]) all_hidden_states, all_attentions = model(input_ids)[-2:]

I got the same issue. How to fix the problem??

@Susan19900316 just change pretrained_weights into bert-base-uncased

Done Let me try. Thanks all for help.

I'm not sure if this issue should be closed before the readme is updated? @rodgzilla @sw-ot-ashishpatel


TilingSprite does not support spritesheet

I want to use

var sprite = new PIXI.TilingSprite(PIXI.Texture.fromFrame(options.image));

with a framename in options.image like "tilingimageabc"
I have a spritesheet which includes the tiling image, but instead of the frame image I will get the whole spritesheet image as tiling image.
If I have a non-power-of-2 tiling image frame, I will get the first frame (another image) of the spritesheet instead, as full-size sprite.
The only solution so far is to change options.image from e.g. "tilingimageabc" to "fullpath/singleimages/tilingimageabc.png" and to add the single file in the assets loader too.

@GoodBoyDigital it seems this is broken in version 2.1.0. I have a sprite that is 32x32 (complies with power-of-2) and I can use it as a TilingSprite fine if I  use it as a standalone image
e.g.
TilingSprite(Texture.fromImage("image.png"))

If I include the image in my spritesheet and try:
TilingSprite(Texture.fromFrame("image.png"))

I get the following error:
WebGL: drawElements: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering or is not 'texture complete'. Or the texture is Float or Half Float type with linear filtering while OES_float_linear or OES_half_float_linear extension is not enabled.
All of my other sprites render correctly from the spritesheet using:
Sprite.fromFrame("sprite.png")

So I don't think that it is a problem with the spritesheet.

Is your spritesheet a power of two? Because that is what is bound as the texture in webgl, and for tiling sprite it expects it to be power of two.

Putting the sprite into it's own spritesheet of 32x32 px worked, where adding padding to it (36x36) didn't, so it was a problem with the size of the spritesheet.
It seems like there's no good reason to try and create a TilingSprite from a spritesheet then?

Its fine to create it from a spritesheet, as long as the sheet is a power-of-two texture.


Backport pseudolocalization to 3.x

(cherry picked from commit e79dde1cbb0e9a97c17bb5d535809efbcee1d965)

Backport of pseudolocalization to 3.x. See #49361

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested:
Editor

Game's main menu

Game's options menu

Game's first level

fake_bidi can be removed, 3.x do not have any BiDi support, so it won't do anything.

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested.

@Calinou  I think the font doesn't support the extra glyphs. Even droid sans doesn't. This is the output on Noto Sans.

Also, this is unrelated to the backport, but shouldn't the default pseudolocalization prefixes and suffixes be changed to [!!! and !!!] to match the editor's pseudolocalization debug feature?

Yup. I'll make that change.

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested.

I think the font doesn't support the extra glyphs. This is the output on Noto Sans.

Note that in master, missing glyphs should properly be identified as such. But indeed in 3.x they're simply invisible. That's not a priority to fix unless someone is really interested, since it's fixed in 4.0 already.

I think the font doesn't support the extra glyphs. This is the output on Noto Sans.

3.x might also fail to compose these characters, in case font only have separate base glyph and combining diacritic glyph.


Update tfjs to latest version

Updates tfjs to the latest version. This was a bit of a pain and involved:

fixing a bunch of TypeScript errors.
adding a p dubious tf.disableDeprecationWarnings(); to the tests, to supress a warning that says "Tensor.get() is deprecated. Use Tensor.array() and native array indexing instead.". I'd love to fix it, but I don't understand who is generating that warning. I've added it to a test file that has two .get() calls, but if I comment out those tests then the errors still get generated. 🤷♀

I've also changed the demos to import tfjs instead of tfjs-core, for consistency. I don't know if it makes a difference, and I can revert this change if there was a good reason to have it there.
I've also cleaned up the package.json a bit while I was there:

we were depending on a fs package that doesn't exist
we were depending on an old tfjs package that didn't seem to be used

@adarob fixed the deprecation warnings and removed the TODO, ptal? 🙏

thanks!


Build - add a cleanup step to js-compile

add a cleanup step to js-compile to prevent unbuilded files in js/dist as today there's an inde.js wich is not generated by the build tasks
Let me know if i'm wrong

@Johann-S For this PR, it's up to you whether we keep it open and apply it to v5. If you want it for v5, please add the v5 label and change the base branch to master. Otherwise, let's close.

Closed after a quick chat with @Lausselloic


Accessibility view not opened on Linux

Testing #213342
On Linux there is accessibility help, but no view. Not sure this is expected or not. 🤔

It's bound to Shift + Alt + F2 and that works in other parts of the UI. Running the command from the command palette also doesn't show the view. Also tried with binding it to Ctrl + Shift + A.

can you run toggle keyboard shortcuts troubleshooting to see if it's attempting to run the command or something else?

and does the accessible view open for other features, just not for notebooks?

It opens for others. It doesn't seem to be an issue with the keybinding as the command in the command palette also doesn't work.

@amunger do you have access to Linux?

only through ssh, and it works for me with that.
To clarify, the accessibility view is for notebook cell output and only .ipynb (not github issues). There is no view for the cells input.
@chrmarti - are you focused on a cell output when trying to open the view?

only through ssh, and it works for me with that. To clarify, the accessibility view is for notebook cell output and only .ipynb (not github issues). There is no view for the cells input. @chrmarti - are you focused on a cell output when trying to open the view?

That works with the keybinding (not the command palette). 👍


Implements requesting and processing compressed responses

I have this running on my phone for quite some time now. I expect faster page and JSON downloads, especially on mobile network.
All tests green (with exception of #1242)

I'm not sure what you mean by "expect". You surely tested this and saw in a debugger that the compression is used, right?

The compression is used, but I did not measure the performance. The transfer time is of course shorter, but the server and the client have to compress/decompress the data, therefore I expect it to be faster, but I do not know for sure.

Today I came around to test it in a rough way. I tested the download of a cache and the live map. I tested on my device with mobile network. I did several runs for each measurement. The time measured is the overall time, including parsing and (in the case of the cache) storing.
Cache download: 7-10 sec uncompressed, 5-6 sec compressed
Live map (fastest/faster, no difference): 8-10 sec uncompressed, 7-8 sec compressed.
So, while it is not so much overall, it is still enough to make it useful.

Can't we use the compressed download everywhere ? Images, complete cache descriptions ? Most of the smartphones have powerful cpu nowadays but if you are on a tour in the middle of nowwhere you very often have only a 2G connection...

Compression is now always offerred. The server decides what to send and of course only text stuff ( html, json) is sent compressed.


Validate that dependency graph for dynamic schemas is (weakly) connected

For the time being it is validated that dependency graph has no cycles. Adding this extra validation would make the component more robust

Giving it a second thought, it has no sense. What it is needed is that all dependent properties eventually depend on non dependent properties, and by construction (since graph is acyclic) this is true


Fix not existing variable error

...and make exception admin agnostic over how many errors
there could possibly be.

/lgtm


Removed duplicate getSignalName and getTopicName

Julien, I agree. However, the methods are not public API so it will be low on my list ;-)


[stdlib] Split LibraSystem into three different modules

Motivation
Splitting out the functionalities of LibraSystem into three different modules:

LibraSystem, which contains the validator set, discovery set, and reconfiguration functionality.
LibraBlock, which contains the logic for the block prologue transaction.
TransactionFee, which contains the logic for distributing transaction fees to the validators.

This will be a breaking change as the handle for block prologue will be changed.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

:umbrella: The latest upstream changes (presumably 5ada39a94d36faabb41dc3a346b8f55ae0a9638e) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=tzakian

:pushpin: Commit 33a6664 has been approved by tzakian

:hourglass: Testing commit 33a6664010f96d0908a90c3921491ae1be335b91 with merge 9efe107344bb21fed10781362b85b8fba664fc5a...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2790

:pushpin: Commit 33a6664 has been approved by tzakian

:hourglass: Testing commit 33a6664010f96d0908a90c3921491ae1be335b91 with merge 71b535536fb3ee9754914f7ac22c47f85fe8a653...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=tzakian

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 33a6664 has been approved by tzakian

:hourglass: Testing commit 33a6664010f96d0908a90c3921491ae1be335b91 with merge b507887c5d46b10911a2998ff957e572752a0234...

Would this changes the fields in some of the events? If so this is an breaking change.

Would this changes the fields in some of the events? If so this is an breaking change.

It is indeed a breaking change and needs devnet to be flushed out immediately as the block prologue handler gets changed already.

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit 33a6664010f96d0908a90c3921491ae1be335b91 with merge 10c728460e6154cbfb11293cacd2505013343bdc...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing 10c728460e6154cbfb11293cacd2505013343bdc to master...


gnerate all mask spend 20s, it is too long

Thanks for your interest in our work. Note that MobileSAM makes the image encoder lightweight without changing the decoder (like 8ms on the encoder and 4ms on the decoder). Since we mainly target the anything mode (1 times image encoder and 1 times decoder) instead of everything mode (1 times image encoder and 32x32 times decoder), see the paper for definition difference (Anything mode is the foundation task while everything mode is just a downstream task as indicated in the original SAM paper). "gnerate all mask" seems to suggest that you are using everything mode. For everything mode, even though our encoder is much faster than that of the original SAM(roughly 8ms vs 450ms), it cannot save too much time for the whole pipeline since most of the time is spent on the 32x32 times decoder. One way to mitigate this is to use smaller number of grids (like 10x10 or 5x5) to make the decoder consume less time, since many redundant masks are generated in the case of 32x32 grids. I hope this addresses your issues, otherwise, please kindly let us know. We are also currently trying to make the image decoder more lightweight by distilling it with smaller one as we did for image encoder. Stayed tuned for our progress. If you have more issues, please kindly let us know and we might not be able to respond in a timely manner, but will try our best.

same to me on my mac.
much longer than original sam on my mac.
any tips here?

same to me on my mac. much longer than original sam on my mac. any tips here?

It seems that there is either bug in the code or you have not used it properly. At this moment, we cannot help debug in a timely manner. If you provide more details, we will try to help as soon as possible. See the demo here for checking the speed https://huggingface.co/spaces/dhkim2810/MobileSAM

same to me on my mac. much longer than original sam on my mac. any tips here?

Thanks for your interest in our work. It seems that there is either bug in the code or you have not used it improperly. At this moment, we cannot help debug in a timely manner. If you provide more details, we will try to help as soon as possible. See the demo of running MobileSAM on CPU is available here for checking the speed: https://huggingface.co/spaces/dhkim2810/MobileSAM

ok
thank u.

same to me on my mac. much longer than original sam on my mac. any tips here?

Thanks for your interest in our work. It seems that there is either bug in the code or you have not used it improperly. At this moment, we cannot help debug in a timely manner. If you provide more details, we will try to help as soon as possible. See the demo of running MobileSAM on CPU is available here for checking the speed: https://huggingface.co/spaces/dhkim2810/MobileSAM

ok thank u.

Yet another demo is available at https://mobilesam.glitch.me/ to run everything on your own browser. Enjoy it~~

sorry i had to take action and remove some stuff and put on pause because
they suspended system issues
El sáb., 1 de julio de 2023 10:17 a. m., Chaoning Zhang <
@.***> escribió:

Closed #25 https://github.com/ChaoningZhang/MobileSAM/issues/25 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/ChaoningZhang/MobileSAM/issues/25#event-9696680254,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAZ5WPKESXHODPL6LU74EM3XOA5RDANCNFSM6AAAAAAZYIAN7U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

问题先关闭吧，我在3090测试和还是原始的sam差不多，我再多了解一下原理就，多谢你们辛苦的付出
Vanessaaui @.***> 于2023年7月2日周日 00:31写道：

sorry i had to take action and remove some stuff and put on pause because
they suspended system issues
El sáb., 1 de julio de 2023 10:17 a. m., Chaoning Zhang <
@.***> escribió:

Closed #25 https://github.com/ChaoningZhang/MobileSAM/issues/25 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/ChaoningZhang/MobileSAM/issues/25#event-9696680254,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BAZ5WPKESXHODPL6LU74EM3XOA5RDANCNFSM6AAAAAAZYIAN7U>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/ChaoningZhang/MobileSAM/issues/25#issuecomment-1615987430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2X6OTXPVDR5RRAOEONAM3XOBGGRANCNFSM6AAAAAAZYIAN7U
.
You are receiving this because you authored the thread.Message ID:
@.***>


WIP:Initial release workflow

This adds some initial functionality to create releases and promote changes between environments via chat ops in an issue comment. This set of workflows does the following:

Adds the release and promote actions
When a release branch is created via the /release command, a release branch is created with an appropriate name, a label with that name is created and the label is then applied to that issue
When you promote that release from the release branch to an environment branch, a PR is created, the label for that version is applied to that PR and then the PR is auto-merged

Not ready for merge quite yet. Need to update the values.yml path and add a README

Ready for review


Add polyglot tests for equals and hashcode

Add polyglot tests to runtime-with-polyglot project. Currently, EqualsTests and HashCodeTests run with a ValueGenerator that generates only Enso and Java values. We should add EqualsPolyglotTests that use a ValueGenerator with all the other languages.
Mentioned in https://github.com/enso-org/enso/pull/6820#discussion_r1203820389
For the inspiration, see https://github.com/enso-org/enso/pull/6820

We are living without them for a long time. Let's add them when bugs are found.


Consider adding cornerHarris

Consider adding functionality for the cornerHarris edge detection function from opencv.
Reference: https://docs.opencv.org/2.4/modules/imgproc/doc/feature_detection.html#cornerharris
On that note, is there a list of functions which are/aren’t implemented yet?

Thank you for your report.
There is no list of not implemented functions.


/en-US/docs/Web/API/HTML_Drag_and_Drop_API note error

Request type

[x] Correction or update

Details
The note on https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API is plain wrong.
Note: Neither dragstart nor dragend events are not fired when dragging a file into the browser from the OS.

It should say:
Note: Neither dragstart nor dragend events are fired when dragging a file into the browser from the OS.

Changed - thanks for reporting! The double negative did seem very strange...


Add LED support

We'll call this the pre-Derick designing crazy LED fanciness stage.
Simple use of LEDs.
Default - off.
Wake word detected and listening - blue ring
Skill crunchin' some numbers and solving problems - blue/green rotating ring.

@forslund Can you take a second look?
I added LED indication for speaking per Derick's request, added some of his initial Mycroft color palette recommendations, and made it so that when volume is set or get that instead of the speak() LED indicator we display the volume on the LED ring. This volume feature requires another PR to work: https://github.com/MycroftAI/skill-volume/pull/44.

Works fine. Merging


feat: index.d.ts

Support app.bull and app.bull.get(name).

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines          14     14
=====================================
  Hits           14     14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9eecc...2b61db8. Read the comment docs.


Fix folders on staging for GCSTs without sumstats

✅ There seem to be folders being created on staging for GCSTs which do not have sumstats. Previously, folders were only created on staging for those GCSTs with full p-value set ticked (i.e. have sumstats) - eg. GCST90321079, GCST90310292, GCST90397904

Couldn't reproduce the issue on sandbox. Perhaps it was fixed by https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1292

Test with GCST90428125-GCST90428269 and GCST90428282-GCST90428285

Should be fixed now.

Please clean te empty folders created by the bug. @karatugo

Can't find empty dirs other than GCST90102485. Perhaps my script at /hps/nobackup/parkinso/spot/gwas/scratch/goci1306 is wrong?

@earlEBI Could you please verify that the folders without sumstats are deleted?

@earlEBI please confirm when you are back, thanks

The three directories I gave as examples still exist on staging, empty. These studies do not have sumstats.

Okay, my script was wrong: https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1306#issuecomment-2091113483
For some weird reason, I was checking the public ftp.

Now submitted a new SLURM job that checks the staging FTP.

I confirm the original empty directories I listed are now removed from staging.


Support translations

Add translations in 1.1 instead.

I can help translate in Russian and Greek.

Me too translate in English-Brazillian Portuguese only


Default javascript database strategy should be truncation

See #166
Right now the default is to use a shared connection, but since this isn't thread safe and causes hard-to-understand errors it's probably better to default to truncation instead. However, when I tried that, it made features fail. This ticket will remind us to change the defaults and fix the features.

AFAICT the default is truncation: https://github.com/cucumber/cucumber-rails/commit/fe083869b76bc5c0f2d7871e280b0f43be30879d

Ah OK, you set it in the generator. That's probably clearer.
I also set it here, you see:
https://github.com/cucumber/cucumber-rails/blob/master/lib/cucumber/rails/database.rb#L64

Yeah - let's remove that. You fix?

This has been fixed


bot is not working for me anymore

It was working few weeks ago but today i started it and it is not working. Is it a problem on my side or everyone got it?

Can you be more specific?

Same here,
i found that the MidJourney token had changed (i'm on a monthly subscription), but i still get an error, while the bot now proxies properly:
Ignoring exception in command mj_imagine:
Traceback (most recent call last):
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/commands/core.py", line 124, in wrapped
    ret = await coro(arg)
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/commands/core.py", line 980, in _invoke
    await self.callback(ctx, **kwargs)
  File "/Users/.../Documents/_DEVELOPER/discord/MidJourney-Wrapper/main.py", line 31, in mj_imagine
    await ctx.respond(
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/commands/context.py", line 282, in respond
    return await self.interaction.response.send_message(
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/interactions.py", line 825, in send_message
    await self._locked_response(
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/interactions.py", line 1090, in _locked_response
    await coro
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/webhook/async_.py", line 217, in request
    raise HTTPException(response, data)
discord.errors.HTTPException: 400 Bad Request (error code: 40060): Interaction has already been acknowledged.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/bot.py", line 1114, in invoke_application_command
    await ctx.command.invoke(ctx)
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/commands/core.py", line 375, in invoke
    await injected(ctx)
  File "/Users/.../.pyenv/versions/3.10.9/lib/python3.10/site-packages/discord/commands/core.py", line 132, in wrapped
    raise ApplicationCommandInvokeError(exc) from exc
discord.errors.ApplicationCommandInvokeError: Application Command raised an exception: HTTPException: 400 Bad Request (error code: 40060): Interaction has already been acknowledged.

so is there a solution?


September 2018 YouTube update

Category

[X] Content fix
[ ] New article
Related issues: YouTube embeds to the new YouTube Tutorials as of September 2018

What's in this Pull Request?
I've updated the YouTube Embeds so that the Documentation is updated with the latest YouTube video's

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/extensions/get-started/hosting-extension-from-office365-cdn.md
:white_check_mark:Succeeded
View

docs/spfx/extensions/get-started/serving-your-extension-from-sharepoint.md
:white_check_mark:Succeeded
View

docs/spfx/set-up-your-development-environment.md
:white_check_mark:Succeeded
View

docs/spfx/web-parts/get-started/add-jqueryui-accordion-to-web-part.md
:white_check_mark:Succeeded
View

docs/spfx/web-parts/get-started/build-a-hello-world-web-part.md
:white_check_mark:Succeeded
View

docs/spfx/web-parts/get-started/connect-to-sharepoint.md
:white_check_mark:Succeeded
View

docs/spfx/web-parts/get-started/provision-sp-assets-from-package.md
:white_check_mark:Succeeded
View

docs/spfx/web-parts/get-started/use-fabric-react-components.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx @paulwillen  - we were in progress on getting these in, but help is always welcome. Did also slightly adjust what you provided as there were few video URLs getting crossed between extensions and web parts. All good now.

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Event Request] Table 7334 Whse Internal Pick Line - OnBeforeCheckIncreaseBin

Hi Team,
In table 7334 we need possibility to replace and avoid using standard code with our own. Having event with handling in the end of procedure CheckBin, would be perfect solution:

    [IntegrationEvent(false, false)]
    local procedure OnBeforeCheckIncreaseBin(var Rec: Record "Whse. Internal Pick Line"; var Bin: Record Bin; WhseInternalPickLine: Record "Whse. Internal Pick Line"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Revisit metadata sections order and content

Describe the improvement
To make clear what metadata can be provided in the "Additional information" section, an alternative name could be preferred.
@sdebodt to check content of "Additional information" section and check with Anniek for alternative.

A complete revisit of the different metadata sections (content, naming, order) is useful according to Nicolas as this has not been done in the past. @sdebodt to check with Myriam and Anniek.

@sdebodt this issue is too vague, close and replace with more concrete issues?

After discussion with Anniek, we propose the following metadata sections and order (based on the metadata for publication type "Journal Article").
Publication details
Publication type
Article type
DOI
Classification (of UGent-classification?)
Title
Alternative title
Journal title
Short journal title
Language
Publishing status
Published while none of the authors are employed at UGent
Publication year
Place of publication
Publisher
Volume
Issue
Pages
Number of pages
Article number
Special issue title
Web of Science type
Web of Science ID
ISSN
ISBN
PubMed ID
Arxiv ID
ESCI ID
Projects
as is
Departments
as is
Conference details
as is
Abstract and Keywords
Abstract
Keywords
Research field
Links
Additional information
free text field only

@sdebodt in the tab "abstract" I cannot add subdivisions for keywords or other fields. It is restricted to one type only, as that is already structured..

@sdebodt and what about the other types? For some I can suspect what to do, but some like dissertation have special fields.

I did not have the time yet to check for the other publication types. @nicolasfranck, do you only need input on dissertation or also on other publication types?

@nicolasfranck can we move keywords and disciplines to the second section, below the titles?

I had a look at the order of the metadata for dissertations and that looks fine to me. There are a few fields for which I wonder whether they are needed, but we can revisit this at a later stage.
Also the order of the metadata for the other publication types are ok.
So I would only move the keywords and research field for all publication types as mentioned above.

@sdebodt isn't the tab not big already? We are moving too much in a cramped space..

Keywords and research field are a bit lost right now while they are important to complete as they give information on the content of the publication.
Maybe we can play with the spacing between lines of text of a section a bit and then have more sections... let's leave as it is for now and give it some more thought at a later stage.

@nicolasfranck @sdebodt seems like this can be closed?

yes, closing


Add '.flatMap' and '.unique' methods

View rendered readme.md

Сlosed due to separation into two separate pull requests: #64 and #65

Сlosed due to separation into two separate pull requests: #64 and #65


Possible to combine extra header with tabs?

Is it possible to use this to have an extra header with a collapsing image/component above it?

Pretty much the image on the left, but instead of just a title, it would be a full component. I have tried many approaches but cannot seem to get it right.

Can you explain, what could be improved or you expected more and it didn't on ImageHeader(the one on the left) of this module?

@benevbright  - When I apply a header, following the image example, that header will always sit on top of the tab navigator. The tab navigator is hidden behind the image, until I scroll all the way down and then it will display.
For more clarification of what I am looking for, the functionality is similar to what you would find on a Facebook group page. Collapsing header with a tab navigator below it.

Great. It's a good one.
Thanks for your information.
Let me see what I can do :)

@benevbright thank you!

Hi, I updated the module. I appreciate your issue :)
Please look example/src/AdvancedScreen.js for your desired screen.
Or, you can also try Expo Snack.
NOTE: please update react-navigation-collapsible to 0.3.1.

@benevbright  - Thank you! I appreciate your time on this.

Hello! Where did this example go? This is exactly what I need for: https://github.com/benevbright/react-navigation-collapsible/issues/72


[RVT-2620] Implement API parsing for turnstile version config

backend is already implemented, need to add a turnstile key here and hook it up
From SyncLinear.com | RVT-2620

Out of sync with Linear


Improve event readability for generic scheduler

Fixes #8531

Spamming in output the entire contents of the pod is a usability nightmare when trying to present the events.  The pod is known from the involvedObject.  This make kubectl describe pod ... much easier to follow when there is a failed to fit scenario.

LGTM. There is a merge freeze though (#8534)


Kaia overview introduced the abbreviation BFT which breaks the rule of Ambiguity and Professionalism

Describe the issues and typos
Depending on the user reading the over view, BFT might mean different thing to them.

please proceed with this issue @youngancient


Bump NPD versions to v0.8.17

Also ran make gomod and make fmt in the repo for cleanup.

/lgtm

/retest


Update primer.md

Small grammatical edits

Thanks for your contribution @extemporaneousb, I have taken over this PR in an attempt to get it merged.

@balena-ci retest


[fix] some statement can be simplified

What is the purpose of the change
make some 'if' statement be simplified and format code
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10525 (7656871) into 3.1 (db210e0) will decrease coverage by 0.38%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                3.1   #10525      +/-   ##
============================================
- Coverage     64.57%   64.19%   -0.39%
+ Complexity      396      394       -2
============================================
  Files          1331     1331
  Lines         56548    56506      -42
  Branches       8370     8339      -31
============================================
- Hits          36517    36273     -244
- Misses        16084    16260     +176
- Partials       3947     3973      +26

Impacted Files
Coverage Δ

...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java
74.19% <75.00%> (+8.47%)
:arrow_up:

...mmon/serialize/fastjson2/FastJson2ObjectInput.java
0.00% <0.00%> (-62.50%)
:arrow_down:

...mon/serialize/fastjson2/FastJson2ObjectOutput.java
0.00% <0.00%> (-56.25%)
:arrow_down:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...on/serialize/fastjson2/FastJson2Serialization.java
57.14% <0.00%> (-28.58%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
43.86% <0.00%> (-26.42%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-25.00%)
:arrow_down:

...he/dubbo/rpc/listener/ListenerExporterWrapper.java
68.00% <0.00%> (-20.00%)
:arrow_down:

...n/serialize/fastjson2/Fastjson2CreatorManager.java
46.66% <0.00%> (-20.00%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

... and 66 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more