Navbar looks crude and unrefined

Description:
The navbar of the website looks very plain and not properly spaced.
Reason for Change:
[Explain the reasons behind the requested style change, such as usability, branding, or user experience.]
Current Styling:
[Describe the current styling that needs to be changed.]
Proposed Styling:
I will like to center the elements of the navbar also change the main color of the site to suit the conceipt of spirituality.
Please assign me.
Screenshots or Design Mockups (optional):
[If available, include relevant screenshots or design mockups illustrating the requested style changes.]
Additional Information (optional):
[Provide any additional information that may help in understanding or implementing the style change. This can include any specific requirements or constraints.]

Priority Level (optional):
Medium
Timeline (optional):
[Specify any preferred or required timeline for implementing the style change.]
Possible Implementation Approach (optional):
[If you have any suggestions or ideas on how the style change could be implemented, feel free to provide them here.]

Please assign this issue to me

do a new fetch , there are changes with regards to the navbar.


kubectl misconfiguration

It used to work fine, but recently after running
dind-cluster-1.10 up
kubectl get nodes

I started to get an error
The connection to the server localhost:8080 was refused - did you specify the right host or port?

The cluster seems to be starting correctly, but correct kubectl configuration has gone missing

Seems like the latest commit by robot breaks this

Alright, this works. Thanks you!


chore(master): release spark-delta 1.5.0

:robot: I have created a release beep boop
1.5.0 (2024-04-06)
Features

more changes (7cb4f20)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/chgl/util-images/releases/tag/spark-delta-v1.5.0 :sunflower:


6.2.x

Adding WebIdentityTokenFileCredentialsProvider to the AWS credentials chain

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 6 committers have signed the CLA.:white_check_mark: dima767:white_check_mark: julienhuon:white_check_mark: mmoayyed:white_check_mark: rafiek:x: travis-ci:x: CorbanRtravis-ci seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


State charset explicitly.

Not sure why, but Firefox Quantum (v58.0.2) seems to garble the encoding for resumable.js and insists that the character Â appears within the javascript source, which prevents loading the module. Explicitly including UTF-8 as the charset appears to fix that issue.

Error also observed in Chrome v64.0.3282.167 - isolated to an apparent extra space on line 378.

Closin'


Clean up Swedish README a bit

Thanks for taking the time to contribute this localization pull request. However, we are not able to accept contributions to this historical reference repository at this time.


GetInterpreterList does not pick up newly added virtual environments (when called from Jupyter)

Environment data

VS Code version: Insiders latest
Extension version 2021.10.1258668113-dev
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Value of the python.languageServer setting: XXX

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Virtual environments just created will end up in list of kernels.
Actual behaviour
Virtual environments do not appear as kernels
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Create virtual env outside of vs code
Open VS code in same root folder
Open notebook
New venv is not selectable as a kernel.
Open python file
New venv is selectable as a python interpreter.

This test run is failing for the same reason:
https://github.com/microsoft/vscode-jupyter/runs/3669744903?check_suite_focus=true

Logs
Here's the logs from jupyter. Notice how the venv 'testDummyVenv' is not listed.
jupyterlog.txt
Here's the logs from python. venv 'testDummyVenv' is listed.
pythonlog.txt
We (Jupyter) are not getting the new venv when calling getInterpreterList. This seems like a recent regression.

Related: https://github.com/microsoft/vscode-jupyter/issues/5319

I'm going to look at this. It's blocking development in the jupyter extension.

@rchiodo If resource is passed as undefined, workspace envs are not reported as the VSCode API needs a URI: vscode.workspace.getWorkspaceFolder(uri), I think that's what is happening.
In the extension we get the resource using https://github.com/microsoft/vscode-python/blob/c383e81e66a220f509dc38821700160e38784d55/src/client/interpreter/configuration/interpreterSelector/commands/base.ts#L33-L81

We should probably use this if no resource is set instead of calling vscode api to get workspace folder directly

Not sure this fixed it. I can still repro it after rebuilding the bits locally.

Looks like the first call to getInterpreters can be out of date.

Looks like the first call to getInterpreters can be out of date.

Wasn't that always the case though? When a new workspace is opened, first call to getInterpreters always relied on the existing cache first, which won't have the latest environments unless discovery is finished.
I can reproduce this issue with the stable version of the extension as well, so it doesn't seem like this is a regression.

Maybe the timing is different then. With stable our tests pass. With insiders our tests fail. Let me try on my machine

Using this version it doesn't repro for me.
Version: 2021.8.1159798656
Using this version it also doesn't repro for me:
Version: 2021.9.1246542782

But with insiders it does.

What version of the jupyter extension do you have? The jupyter cache is a recent thing that Don added.

Actually does it really matter? It's broken either way. Until the event is in the API it makes sense for it to force a refresh.

I am able to reproduce it with stable as well. The first query doesn't contain the envs if we click fast enough.

If we click the second time, it's in the list.
I was using v2021.8.2041215044 Jupyter always.

Actually does it really matter? It's broken either way. Until the event is in the API it makes sense for it to force a refresh.

Yeah, it just seems like it was never supposed to work.

Tests seem to be reproing this. I believe there's still a problem with untitled files. At least during our tests running.


I can't switch versions of ruby midstream (different processes)

Using Bundler 1.6.2
I have two versions of ruby installed, 1.9.3 and 2.1.5.  master.rb is started with bundle exec, and it declares "ruby '2.1.5'" in its gemfile, and has a .ruby-version file with contents '2.1.5'.
master.rb switches to the dir that houses slave.rb, which is still running 1.9.3(p-484).  It has
a gemfile entry of "ruby '1.9.3'" and .ruby-version file with contents '1.9.3'.
If I try running bundle exec ruby --version from master.rb in slave.rb's dir, it complains that the Gemfile specifies 1.9.3, but it's running 2.1.5.  I reproduced this with this small two-file example:
master.sh:
#!/bin/bash

export RBENV_VERSION=2.1.5
echo "Ruby in shell script: `ruby --version`"
echo "Now shell out, hoping for 1.9.3:"
ruby slave.rb

and slave.rb:
 system("bundle exec ruby --version")

The output is:
 Ruby in shell script: ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-linux]
 Now shell out, hoping for 1.9.3:
 ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-linux]

While in my system I launch the master under bundle exec, I don't have to here to reproduce
the problem. It seems that just setting RBENV_VERSION and then running rbenv/libexec pushes
the 2.1.5 path to the top of the PATH as a sort of optimization, and I'm stuck with it when I try
to spawn children. I even passed a cleaned path as the first arg to system in slave.rb, but it didn't have an effect.
Is there a way to do this, or should we migrate all our components to the same version?

I think I just ran into this bug. I think this is because the $RBENV_DIR env var is being set from the top-level ruby and leaking down into the subcommands, even if $RBENV_VERSION is being changed.
Can you try prepending RBENV_DIR= to the subcommand?
 system("RBENV_DIR= bundle exec ruby --version")

I've also been bitten by this. This seems to be because rbenv works to keep the Ruby version the same. This is done by prepending the path of the selected Ruby to PATH as seen here.

This is unfortunately a known issue: #121


3.1.0

Bumps up to 3.1.0
Adds

shield

This thickens stroke widths slightly on the following icons:

circle-slash
clock
cloud-upload
cloud-download
dashboard
info
issue-closed
issue
issue-reopened
history
question
search

Fills comment-discussion
Thickens x to match checkmark

When I download the octicons.zip files from the releases page for v3.0.0 and v3.1.0 there's no files in them, only folders with the file names. I'm on Windows and used both the built-in zip viewer and 7zip with the same results.

@xt0rted How about for older versions? @cameronmcefee Thoughts?

Versions 3.0.0, 3.0.1, and 3.1.0 do this, the rest contain the files. I tried downloading with IE, FF, and Chrome.

@xt0rted Try downloading those again, will ya? I may have found a bug :smile: Lemme know.

Strange… will investigate.

@aaronshekey they're working now

This addresses most of the issues I had with the new designs that I didn't share with anyone yet. :+1:

@djch It's tough balancing style / legibility / crisp rendering across every device. Gettin' closer!

@aaronshekey I'll bet! How much more feedback are you getting now they're shipped to GitHub.com?


make distcheck is busted

make distcheck is failing in ovn
cd ovn
./boot.sh && ./configure --with-ovs-source=${PWD}/../ovs && time make distcheck
...
checking for OVS source directory... configure: error: OVS source dir path needs to be specified (use --with-ovs-source)
Makefile:2928: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1

full log:
https://gist.github.com/flavio-fernandes/17d55d6663f9b77fa9a0189d04afc532

I guess we'd need some way to pass the OVS source directory to make distcheck automatically if we wanted to fix this. I wonder what a reasonable way would be.

This is how it is passed in the travis CI - https://github.com/ovn-org/ovn/blob/master/.travis/linux-build.sh#L44
I am not sure if there is any other way.


US10936TeachFlotNewTricks: Make it possible for 'fillColor' to be a func...

...tion that takes some series' context.

looks good to me


Add support for RedisInsight Client

The new Redis Insight GUI client developed by redis is unable to connect to the proxy.
The errors I see in the proxy logs are for missing commands that the client issues at connection, and I tried to pass them using command.conf:
CustomCommand {
  client {
    Mode write
    MinArgs 2
    MaxArgs 6
  }

  module {
    Mode write
    MinArgs 2
    MaxArgs 6
  }

  cluster {
    Mode write
    MinArgs 2
    MaxArgs 6
  }

  sentinel {
    Mode write
    MinArgs 2
    MaxArgs 6
  }

}

But does not seem enough.

Update, the new version 2.14 of Redis Insight can load UI, however cannot display the keys because it requires commands memory and dbsize that even if added manually to command.conf, don't work because command.conf does not accept MinArgs 1 commands.

I am using a custom fork to support some of the commands directly in Command.cpp


The page is still cached (by django) for anonymous user after publishing new content on the page

Description
The page is still cached for anonymous user after publishing new content on the page. Everything works good for logged-in users (because caching is not active for logged-in users as far as I understand). I've investigated the cache DB and cache middlewares (django.middleware.cache.UpdateCacheMiddleware and django.middleware.cache.FetchFromCacheMiddleware) source code and found that basically it uses views.decorators.cache.cache_header... and views.decorators.cache.cache_page... cache keys to get/set the page cache, but django CMS is not updating them on publishing. Django CMS is setting its own cache keys which are not related to the ones mentioned above.
The issue can be avoided by setting CMS_PLUGIN_CACHE=False in the settings. I still want to use the cache, so I've implemented a signal receiver for the page publishing signal for removing the related cache key (see additional info).
Steps to reproduce

Configure cache (add required middlewares and set CMS_CACHE_DURATIONS)
Configure database cache using:

CACHES = {'default': {'BACKEND': 'django.core.cache.backends.db.DatabaseCache', 'LOCATION': 'django_dbcache'}}

Run server
As logged-in user: create a page with simple content (like Text Plugin)
As anonymous user: open the page and check that content is valid
As logged-in user: update the content and publish the page
As anonymous user: reload the page

Expected behaviour
The updated content should be displayed for the anonymous user.
Actual behaviour
The cached (old) content is displayed for the anonymous user.
Additional information
django-cms: 3.8.0
Django: 3.1.6
OS: OS X 11.1 (but also reproducible on Windows 10)
Browsers: Google Chrome 88.0.4324.146, Firefox 85.0.2
Also I've attached the example project where you can see the issue: django_cms_caching_issue.zip
The workaround which I used to keep cache working:
Add a signal receiver to any of the existing apps or create a new app.
The receiver code:
import logging

from cms.admin.pageadmin import PageAdmin
from django.core.cache import cache
from cms import signals
from django.utils.cache import _generate_cache_header_key

logger = logging.getLogger(__name__)

def delete_cache_key(sender, obj, operation, request,  **kwargs):
    try:
        if operation == 'publish_page_translation':
            # In order to get the same cache_key as the user would receive we need to create a WSGIRequest
            # object with empty query string and with page path
            request_custom = request
            request_custom.path = obj.get_absolute_url(kwargs['translation'].language)
            request_custom.META['QUERY_STRING'] = ''
            cache_key = _generate_cache_header_key('', request_custom)
            cache.delete(cache_key)
    except Exception as e:
        logger.error(f'Error in page publish receiver: {e}')

signals.post_obj_operation.connect(delete_cache_key, PageAdmin)

Is this still an issue in django-cms 3.11?

@PeterW-LWL I have not checked this, but I am not aware of a fix. Want to give it a go?

@PeterW-LWL I have not checked this, but I am not aware of a fix. Want to give it a go?

No. I was asking because we recently upgraded to 3.11 (from 3.7) and use a thirdparty library that solves this issue. But I wanted to make sure if we still need to depend on that library.
But it looks like we do.

https://gitlab.com/what-digital/djangocms-helpers


Failed to deploy after built with VS2015 CTP 6 & Win10 Preview

The alljoynsecureserver sample solution built with VS2015 latest CTP6 running on the latest  win10 Preview (10041) for x86 or Any CPU  - fixing multiples compiler error - missing png (delete reference), App.XAML (change to Application Definition).
when deploy the solution, got 19 errors:
Severity	Code	Description	Project	File	Line
Error		Error : DEP0700 : Registration of the app failed. C:\Windows-universal-samples-master\alljoynsecureserver\cs\bin\x86\Debug\AppX\AppxManifest.xml(26,27): error 0x80070003: Cannot install or update package Microsoft.SDKSamples.AllJoynSecureServer.CS_8wekyb3d8bbwe because the splash screen image [C:\Windows-universal-samples-master\alljoynsecureserver\cs\bin\x86\Debug\AppX\Assets\Splash-sdk.png] cannot be located. Verify that the package contains an image that can be used as a splash screen for the application, and that the package manifest points to the correct location in the package where this splash screen image can be found. (0x80073cf6)	AllJoynSecureServer
Severity	Code	Description	Project	File	Line
Error	CS0103	The name 'StatusBorder' does not exist in the current context	AllJoynSecureServer	C:\Windows-universal-samples-master\alljoynsecureserver\cs\MainPage.xaml.cs	74

This has recently been updated to the tools matching VS2015RC.


Add Coveralls CI workflow for test coverage reporting

Description
This Pull Request introduces a new GitHub Actions workflow to integrate Coveralls for automated test coverage reporting. The workflow is added under .github/workflows/coveralls.yml. It is designed to provide detailed code coverage metrics for pull requests and the main branches.
Benefit to End Users
The inclusion of Coveralls enhances the development workflow by providing:

Transparent Code Coverage Metrics: Developers and contributors gain insights into the impact of their changes on the overall code coverage.
Improved Code Quality: Encourages maintaining and improving code coverage across the framework.
Better Collaboration: Simplifies identifying areas of insufficient test coverage during code reviews.

These benefits ensure a more robust and reliable Laravel framework for developers and end users alike.
Implementation Details

Workflow Name: coveralls
Triggers: The workflow runs on:

Push events to the master branch and branches matching the *.x pattern.
All pull requests.

Jobs Configuration:

Runs on ubuntu-24.04 with a matrix of PHP versions (8.2, 8.3, 8.4) and PHPUnit versions (10.5.12, 11.3.2).
Executes tests with phpunit and generates a Clover coverage report.
Uploads the coverage data to Coveralls using the php-coveralls library.

The workflow does not interfere with existing configurations and complements the current CI/CD processes.
Why It Doesn't Break Existing Features

The workflow operates independently of existing testing and deployment pipelines.
No changes were made to the core functionality or APIs of the Laravel framework.
The coveralls.yml file is isolated and only concerns reporting test coverage metrics.

How It Makes Building Web Applications Easier
By integrating Coveralls, contributors can:

Ensure that new code is properly tested and covered.
Quickly identify areas in the framework that need more rigorous testing.
Enhance trust and confidence in the stability of the framework with every new change.

Tests
No additional feature tests are required for this change since it pertains to CI workflow. However:

The workflow has been tested locally and on other repositories to ensure compatibility with the defined configurations and tools (PHP, PHPUnit, Coveralls).
Verified that coverage reports are generated and uploaded successfully to Coveralls.

This is redundant since any PR to 11.x will be merged to 12.


Implement voicefixer for audio enhancement

Is there any way to implement voicefixer to speaker diarization pipeline?
The package takes a wav file as input and gives a upsampled 44100kHz wav file as output, but that could be easily modified to taking and giving audio numpy array.
Since the speaker embeddings depend greatly on the quality of the input audio and in the real world environment, there are a lot of factor that can affect the quality of the audio such as the quality of the recording device, speaker voice change overtime,... so I think having some audio quality enhancement is a must.

Hi @thieugiactu, that's an interesting idea.
To do this in a streaming way we would need access to a pre-trained model for the enhancement task, then implement a SpeechEnhancementModel and SpeechEnhancement block. This would allow you to build a pipeline where you call SpeechEnhancement before sending it to SpeakerSegmentation and SpeakerEmbedding.
In order to make this compatible with SpeakerDiarization (or any pipeline for that matter), we could implement a method like add_audio_preprocessors() to prepend any audio transformations (e.g. enhancement, resampling, volume change, etc.)

I will give it a try. If I have any questions regarding to diart, can I directly ask them under this issue?

This is what I've been doing so far. I re-used your code but replaced whisper model with wav2vec2 model for speech recognition since my pc couldn't handle whisper.

The code worked but there are some adjustment could be made:

The process takes a really long time since the voicefixer model has to also process either the silence data with no speaker or in a same batch, there would be little to no differences between data.
The silence parts at the start and the end of the speech should be trimmed.
project.zip

closed because voicefixer is so unstable.

@thieugiactu something you could also do to reduce the inference time is to directly record audio at 44.1 khz. This way you avoid having to upsample in the first place

@juanmc2005 thank you for your reply. Unfortunately the voicefixer is so unstable. More often than not it would degrade the audio quality even more.


Add invoke tx

Related to this GH issue: https://github.com/NethermindEth/juno/issues/683

closing in favour of #791


Problem update V1 to V2

Describe the bug
Hello,
I have a problem updating to the API V2.
I use the command
pkg-static -C /dev/null add https://github.com/jaredhendrickson13/pfsense-api/releases/download/v2.0.0/pfSense-2.7.2-pkg-RESTAPI.pkg
output :
Fetching pfSense-2.7.2-pkg-RESTAPI.pkg: .......... done     Installing pfSense-pkg-RESTAPI-2.0...     the most recent version of pfSense-pkg-RESTAPI-2.2_2 is already installed
When I go to System -> API -> Update the current version is v1.7.1 - Update available
When I click on the Update button on this page I have this message :
The changes have been applied successfully. The API update process has started and is running in the background. Check in a few minutes.
I wait about 15min, refresh the page and it still on V1.7.1
Did I miss a step?
Thanks
PFSense Version : 2.7.2-RELEASE (amd64)
`
pfsense-restapi version
pfSense-pkg-RESTAPI-2.2_2
Name           : pfSense-pkg-RESTAPI
Version        : 2.2_2
Installed on   : Thu Dec  5 10:50:48 2024 EST
Origin         : sysutils/pfSense-pkg-RESTAPI
Architecture   : FreeBSD:14:*
Prefix         : /usr/local
Categories     : sysutils
Licenses       : APACHE20
Maintainer<EMAIL_ADDRESS>WWW            : UNKNOWN
Comment        : pfSense REST API package
Annotations    :
Flat size      : 6.89MiB
Description    :
The missing REST API package for pfSense.
`

v1 and v2 are released as separate packages so they can be installed concurrently on the same system. v1 will be under System > API and use the pfsense-api command line tool, whereas v2 is under System > REST API and uses the pfsense-restapi tool.
There was a bug in v1 that allowed it to see v2 releases as valid upgrade candidates, but in reality it just installed the v2 package alongside v1. That was fixed in v1.7.5. Now v1 only sees v1 releases as upgrade candidates, and v2 only sees v2 releases as upgrade candidates.
Let me know if you have any further issues.


Current git HEAD won't work with pure "grep"

If neither git-grep nor ack are being used, a result list gets displayed (but still called [No Name], with status line --No lines in buffer--), but trying to save changes results in E32: No file name.
full_command gets to be egrep <pattern> . -R -I -n -H -C3; the filenames are detected and highlighted; only saving changes won't work.
This is with Debian vim=2:7.4.430-1.
Thanks for any help!

Sorry for taking so long to respond.
This is an odd problem. Seems to work fine for me, and I'm not sure how to debug it. For starters, could you run the :messages command and paste the output? It might be that there's an error or warning before that, but it's not seen or something.

Hmmm, with the current 2:7.4.712-3 I can't reproduce either.
Thanks for replying.

I love issues that solve themselves :D. Well, maybe it reallly was a bug with that particular Vim version. Let me know if it happens again.


Enable coreclr debugger to lunch dotnet commands

Today to configure the lunch command for coreclr, users can only specify an assembly. dotnet command like dotnet test is not configurable.
This blocks the scenario of run and debugging a dotnet xunit test.

dotnet test will not work no matter what - the code you want to debug is in a child process
If you had another app that would work you can do it -- set the 'program' to be what you want to debug (ex: dotnet your case), set args to be any arguments to it.

got it. thanks.

Does this mean that there is a way to debug xunit tests in VsCode?
Could you elaborate on the following
"If you had another app that would work you can do it -- set the 'program' to be what you want to debug (ex: dotnet your case), set args to be any arguments to it."

@seesharper : You can debug any .NET Core RC2+ program you want in VS Code. However, there is no child process debugging. So if the program spawns the code in a child process (like 'dotnet test' does) - it isn't going to work. If you run xunit directly through - yes, that will work.

Which would mean invoking the xunit.runner.console.exe directly?

If xunit.runner.console.exe is a native CoreCLR host (ex: it is just corehost.exe renamed) then yes.
Otherwise - no, you would need to launch some sort of CoreCLR host. I am not a super expert on this subject, but the two hosts that come with the .NET CLI are -- 'dotnet.exe <path-to-entrypoint-module>' and corehost.exe. CoreHost.exe works like this - you copy it next to a managed entry point dll (ex: if you want to run c:\example\bin\debug\example.dll, copy it to c:\example\bin\debug\example.exe) it will then look for a dll next to itself. The CLI uses a 'deps' file to use these.

Thanks a lot for valuable information. I managed to get it working with a native CoreCLR console app where I simply new up the test classes and manually invoke the test method.
using System;
using Microsoft.Extensions.DependencyInjection.Tests;
namespace ConsoleApplication
{
    public class Program
    {
        public static void Main(string[] args)
        {
            ServiceProviderContainerTests t = new ServiceProviderContainerTests();
            t.ClosedServicesPreferredOverOpenGenericServices();
        }
    }
}

This approach is a little cumbersome, but it allows me to "pick"  the test method to be executed and I can actually debug the test using vs code. It would be great however, if there was a way to determine the "current" method in the editor. If I knew the name of the test method currently under the cursor I could feed that to the args of my little test wrapper console app (e.g debug current test).
If this is not possible I will at least I have a way to debug tests now. Thanks a lot for your help.

We have a feature request (#311) to add proper support for 'dotnet test' which I think will solve your problem. If not, the technique we employ when implementing it, you could probably use in your own VS Code extension if you want. But as of now, I think your solution is the best I can think of.


[BUG] V4 SDK hangs if Log level is set to DEBUG

v4 4.1.0 SDK hangs with default configuration if Log level is set to DEBUG.
just run the following code against an existing database and container. container.createItem(.) will never succeed.
CosmosAsyncClient client = new CosmosClientBuilder()
        .endpoint(TestConfigurations.HOST)
        .key(TestConfigurations.MASTER_KEY)
        .consistencyLevel(ConsistencyLevel.EVENTUAL)
        .buildAsyncClient();

// let's assume database and container already exist
CosmosAsyncContainer container = client.getDatabase(dbName).getContainer(containerName);

POJO pojo = new POJO();
pojo.id = UUID.randomUUID().toString();
pojo.prop = UUID.randomUUID().toString();

container.createItem(pojo).block();

@xinlian12 is this backported to version 4.1?

@mayank-magoyal This fix is available >= 4.3, we did not backported to version 4.1


Additional Props

add BorderRadius to Box
add textAlign to Text
consider adding wrapping props to Text

Can you add LAYOUT system props to Flex? In one case, I can't set the height to 50%, even with a parent Box setting the height, the Flex component is not taking the height of the Box (when flex-direction: column) but the height of the content.

BorderRadius should stay in Border Box
textAlign now exists in Text
Flex now has the LAYOUT props, (it's extending Box)

Going to add the whiteSpace prop to Text

Addressed in #504


Implement scikit-learn-intelex for random forest and logistic regression

The intelex patch could make the random forest and logistic regression computations several times faster.
For reference: https://github.com/intel/scikit-learn-intelex
Example implementation:
https://github.com/theislab/ehrapy/blob/development/ehrapy/preprocessing/_data_imputation.py#L217

It's gotten a bit unreliable and I'll put this into the backlog.


Change windows cert chain processing to act like other platforms

Change windows certificate chain processing to work the same way as all other platforms.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sounds good to me. Will add the unit of certificate chain TLS as a part of the ticket =D


How to run Cypress headless & other questions.

I am not sure where I should go for intershop related technical questions so i'm sorry in advance if this is the wrong place.
Q1. How can i run cypress headless?
Knowing there is a custom implementation with node open-cypress
Is there a node run-cypress equivalent?
I know there is cypress run --headless but not sure if this breaks intershop's custom code
Q2. Why is there a custom implementation of cypress?
Why not utilize their architecture and implement it as a plugin instead of a plain script.
Q3. More related to components. Some components dont have a component.css, why not?
Currently we are running into issues of deadcode, mixed styling and not knowing where the styling is for a specific component.

Hi @ismail-codinglab,
As you can see in the script itself (https://github.com/intershop/intershop-pwa/blob/develop/e2e/open-cypress.js) it does nothing more than figure out the value for the environment variable ICM_BASE_URL.
Our cypress tests need the ICM backend URL, because some of them are creating users and baskets for testing via REST API and hereby speed-up the testing.
You can skip this step entirely and rely on the standard CLI for cypress as long as you properly set the ICM_BASE_URL yourself. Nothing should break, everything should be working.
Running cypress with --headless might not be what you want if Electron is chosen as the browser. Some of the tests will fail if you do. Consider setting up a proper environment with Xvfb.
This should answer Q1 and Q2, right?

Hi @ismail-codinglab,
regarding question Q3 "Some components don't have a component.css, why not?"
I would say the question is more "Why do almost all components not have a *.component.scss?" There are currently only 7 components with component styles out of over 300 components.
So basically all styling in the Intershop PWA is coming from the global styles in the SCSS files in the /src/styles folder plus the imported styles of Bootstrap, Font Awesome, Toastr and Swiper (see https://github.com/intershop/intershop-pwa/blob/develop/src/styles/main.scss).
There are currently two reasons why we are using global styles instead of component styles.
The main reason is documented here  stating

The visual design (styling) [...] of the Intershop Progressive Web App is derived from the Responsive Starter Store [Intershops classic HTML based storefront] [...].

So this was a basic decision at the beginning of the Intershop PWA project to inherit the styling of our previous storefront and with that the implementation as a global styling. Something we and our customers and partners were used to and something that still works without any issue in a Single Page Application based on the Angular framework.
During our work on the PWA we also got to know component styling better and some of their advantages and disadvantages but up til now we did not do a general rethinking and rework of our styling approach.
A second reason (that came into the project during development), that makes it harder now to work more with component styles, is our theming concept. The dynamic approach of being able to switch our storefront theme based on a PWA run configuration makes it currently impossible to work with global SCSS variables in component styles. The inability to use global variables like $space-default or colors or fonts is very limiting to the component styling and therefore we did not use it more up til now.
We are currently thinking about changing our theming approach and with that also the component styling will get more focus but we are not there yet. I hope this answers all your current questions?


Workflow templates recommending checkout@v2

The workflows in this course us checkout@v1, but I noticed the templates in the Actions tab now default to checkout@v2. We should probably update the recommendations in this course to follow suit.

Agreed.
We may also want to think of ways to handle this when further changes get made to actions we aren't in control of.  I can see this getting out of hand as we maintain courses down the line.
One idea is to have a repo of our own actions and use those instead of "public" ones unless there is a reason to do so.


Using player inside a custom TableViewCell

Hey Patrick. First things first, thanks for an awesome library, really =)
Basically, I am trying to implement a Vine-like app which will have a video player inside each cell and other buttons for likes, sharing et cetera. What is your opinion about this and do you think that is this possible with the current design of the library itself?

hey @uguryavas thanks for the interest in the library. player can be used in "Vine-like" table view cells.
if you're not already familiar, you just need to think about supporting cell re-use, i recommend reallocating the player controller and resetting the cell back to the original thumbnail.
it's possible for you to try using the same player controller instances and "resetting" them when re-use occurs, as oppose to reallocating the controller, but i can't remember if there were any bugs in doing so. by reset, i just mean that you're moving the time back to zero and providing the asset URL over again. I recommend probably just re-allocating.
i've had friends ask me about some type of stream caching, so that the videos play faster but i haven't had a need to get into that optimization.

Hi @piemonte , what do you mean by " moving the time back to zero " ?
Which method should i called ?

@ingouackaz hi there. in your prepareCellForReuse or similar method, just set the URL again and it should reset the player

@piemonte i'm actually implementing this now, it's working actually quite well without having to instantiate the controller every load. The only problem is it's a little bit tricky properly cleaning up the cell.  I think it would be nice either add a convenience method, or allow for a path to be passed nil which indicates a reset state.
Maybe a convenience method like prepareForReuse() that

Stops playback
Rewinds playback
Hides the preview

Right now i'm reaching into the class to do all of these cleanup methods.
But just a note for others trying to do this, prepareForReuse is just for resetting the cell, but it's up to the implement  cells that may be long living. When a cell goes off screen you need to utilize techniques like tableView(_:didEndDisplayingCell:forRowAtIndexPath:)   I also wouldn't recommend setting any data in prepareForReuse as it's  tableView(_:cellForRowAtIndexPath:) responsibility, you may be working with stale data.

Hi @rromanchuk  !
I've just realised that many people have the same issue as me.
http://stackoverflow.com/questions/17617066/avplayer-plays-on-simulator-but-doesnt-on-a-real-device
It works perfectly on the simulator, but it doesnt on the device.
@piemonte  any idea ?

@rromanchuk awesome ideas. we can put a little extension on there that provides that func. i can probably add it this evening or sometime tomorrow. :v:

@ingouackaz not sure what you're encountering, if you can reproduce that problem with the Player sample project, please create an issue with a gist of the changes that trigger it. thanks for the proj interest.

@piemonte i can submit a UITable/CollectionView example too. I had to hack a bit of the player to add this 'reset' method  because a lot of things are are managed in init/deinit so a bit tricky to keep it DRY
    public func sharedSetup() {
        self.playerView.playerLayer.hidden = true
        self.playerView.playerLayer.addObserver(self, forKeyPath: PlayerReadyForDisplay, options: (NSKeyValueObservingOptions.New | NSKeyValueObservingOptions.Old), context: &PlayerLayerObserverContext)

        NSNotificationCenter.defaultCenter().addObserver(self, selector: "applicationWillResignActive:", name: UIApplicationWillResignActiveNotification, object: UIApplication.sharedApplication())
        NSNotificationCenter.defaultCenter().addObserver(self, selector: "applicationDidEnterBackground:", name: UIApplicationDidEnterBackgroundNotification, object: UIApplication.sharedApplication())
    }

    private func sharedDeinit() {
        NSNotificationCenter.defaultCenter().removeObserver(self)
        self.playerView.layer.removeObserver(self, forKeyPath: PlayerReadyForDisplay, context: &PlayerLayerObserverContext)
        self.player.pause()
        self.setupPlayerItem(nil)
    }

    public func reset() {

        sharedDeinit()
        sharedSetup()
    }

I have almost fixed it !
@rromanchuk , @piemonte , do you know , how i can add or remove the bottom layer in AVPLayerViewController wich contains the play controls,  the progress bar,and the fullscreen button ?

Thank you !

Hi @rromanchuk, if you made Player work for the TableViews, can you please write a mini-guide on how to achieve that? Should I put the code you shared above in my Player.swift, and then call reset() on TableViewController's cellForRowAtIndexPath? How should I exactly apply this approach in the TableViewController and TableViewCell? I'd be very happy if you can help. Thanks


[JENKINS-54375] Permissions for jenkinsfile-runner.

Description
jenkinsfile-runner/
@oleg-nenashev
Submitter checklist for changing permissions

Always

[X] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[X] Make sure the file is created in permissions/ directory
[X] artifactId (pom.xml) is used for name (permissions YAML file).
[X] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[X] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[X] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[X] All newly added users have logged in to Artifactory at least once

@daniel-beck sounds like something sensible to me.
@oleg-nenashev is it something that has been debated?

Would it perhaps make sense to use a more specific group ID and perhaps even reduce the redundancy in the individual artifact IDs?

+1 for adding jenkinsfile-runner to the groupId

@daniel-beck @oleg-nenashev changed the coordinates accordingly to the changes done in PR #43


Not working div bg-image class_loaded: "loaded"

It's not a bug, it's like that by design.

OK

Sorry about the brevity of my latest reply, I was in a hurry.
If you search in the closed issues you can find plenty of answers and explanations of the reasons why it's designed like that.
Thank you for your patience.

Thanks for the explanation!


Support Spring 2018 protocol

It looks like with the new firmware:

certificates have been reissued
the bridge sends some unsolicited messages on connection
the names of devices have been prefixed with the names of rooms? My Home Assistant was not happy after patching this code in, but it could have been something I did in the Lutron app when I installed new switches a couple weeks ago.

The existing script to get the certificates should still get the certificates, despite printing an error at the end. I've put an updated copy of the script directly in the repository.
Unexpected messages are now ignored during the connection phase. If you're somehow still running the old firmware this shouldn't be a problem.
Fixes #22

The Travis cache may have bad data in it. I don't think I can do anything to make that 3.4 test run succeed.

New script pulls down certs without error, but cannot control
I downloaded new smartbridge.py, replaced file in cloned git zip, then did pip install. Am I missing something?

works perfectly, my non pro lutron hub works again now.
I simply modified "smartbridge.py"

For the home assistant integration, it might be a good opportunity to use the entity registry, and avoid future renames.

I am up and working with this PR on non-pro.

I'm up now too. thanks mdonoughe. I just did a wget into the /srv/..../pylutron-caseta/ directory

@mdonoughe
Many, many, many thanks.
Back up and running on non pro hub :+1:

Working for me as well on non pro! 👍

Hey guys, I'd like to fix my lights as well.  I'm not sure what I need to download

Where can I find this directory on hassio?

This does work.  Couple notes for others.  I had to delete the certs I had already in the directory, otherwise the script wouldn't fetch the new certs.  The name prefixing is annoying (had to update all my automations).  If you're looking for where to replace the smartbridge.py file and using a docker install, it's here: /usr/local/lib/python3.6/site-packages/pylutron_caseta

Ill get this merged today and push out a new version to pip today - probably this evening.

@gurumitts
@Tim91084
FYI: On Hassbian, all I did was update smartbridge,py in /srv/homeassistant/lib/python3.5/site-packages/pylutron_caseta

@brettzie did you get this working on hassio?  If so how? thanks

I'm not using hassio but I am using the docker container.  I fixed it by mounting the smartbridge.py file in docker:
/path/to/smartbridge.py:/usr/local/lib/python3.6/site-packages/pylutron_caseta/smartbridge.py

@jchong Thanks I ended up doing something similar after I posted.

I am having the same issue and have tried to upgrade as follows:
(homeassistant) homeassistant@hassbian:/srv/homeassistant/lib/python3.5/site-packages $ pip3 install --upgrade pylutron_caseta
Looking in indexes: https://pypi.python.org/simple, https://www.piwheels.org/simple
Collecting pylutron_caseta
  Downloading https://www.piwheels.org/simple/pylutron-caseta/pylutron_caseta-0.5.0-py3-none-any.whl
myusps 1.3.2 has requirement requests==2.12.4, but you'll have requests 2.18.4 which is incompatible.
netdisco 1.2.4 has requirement zeroconf==0.19.1, but you'll have zeroconf 0.20.0 which is incompatible.
Installing collected packages: pylutron-caseta
  Found existing installation: pylutron-caseta 0.3.0
    Uninstalling pylutron-caseta-0.3.0:
      Successfully uninstalled pylutron-caseta-0.3.0
Successfully installed pylutron-caseta-0.5.0

Did this pick up the fix?  When I restart, I still get the configuration failure.

Home assistant will reinstall the old version of pylutron-caseta when you restart it. You need to edit this file:
./homeassistant/components/lutron_caseta.py
and change this:
REQUIREMENTS = ['pylutron-caseta==0.3.0']
to this:
REQUIREMENTS = ['pylutron-caseta==0.5.0']
Then restart home assistant and it should pick up the change. This worked for me.

Thanks.  That worked.

Hoping someone can assist as I only started using HA a couple weeks ago; Hassio install.  When using the Web UI to navigate through the system files/folders, I can get to /usr/lib/python3.6/sitepackages.  When in sitepackages, I don't have a pylutron_caseta folder.
The folders I have are: git, gtdb, ditdb2-2.0.3.dist-info, GitPython-2.1.9.dist-info, pip, pip-9.0.1.dist-info, pkg_resources, setuptools, setuptools-28.8.0.dist-info, smmap, smmap2-2.0.3.dist-info.
I put all three of the caseta files in /config.  Anything apparent that I'm doing wrong?
Log:
2018-04-20 00:22:43 ERROR (MainThread) [homeassistant.setup] Error during setup of component lutron_caseta
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/setup.py", line 142, in _async_setup_component
    result = await component.async_setup(hass, processed_config)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/lutron_caseta.py", line 57, in async_setup
    yield from bridge.connect()
  File "/usr/lib/python3.6/site-packages/pylutron_caseta/smartbridge.py", line 40, in connect
    yield from self._login()
  File "/usr/lib/python3.6/site-packages/pylutron_caseta/smartbridge.py", line 284, in _login
    yield from self._load_devices()
  File "/usr/lib/python3.6/site-packages/pylutron_caseta/smartbridge.py", line 314, in _load_devices
    for device in device_json['Body']['Devices']:
KeyError: 'Body'


feat: zapper read-only opportunities staking rewards

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4491

PR #4504

PR #4553   👈

This comment was auto-generated by Graphite.


Remove wildcard dependencies and version bump to 0.2.3

r? @dirvine
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @Viv-Rajkumar


Costs more than 'get'
5 glyphs?

Sounds good. Should you get a Y?

I'm thinking no, because it's not that helpful when your hand is full of G,
C, M, R
I'd want a vowel that's more versatile.


Multiline label on the edge

Greetings!
As for the logic of my application, I can have multiple edges, from one node to another.
Although they have different labels, they all follow the same path, overlapping each other.
I decided to combine these edges into one, simply increasing the label, using a line break.
But after some time, I realized that this was impossible and decided to use (tspan).
But their use leads to strong visual bugs:
Through y

Through dy

Any suggestions, on how could I fix this?

Since v11.2.0 it is possible to use a div based edge label renderer that should make this way easier https://reactflow.dev/docs/api/edges/edge-label-renderer/


ROE-16 Add makefile with sonar configuration

Added a make file to the application it has in it:
A build command that runs ci
and a clean command that removes the build and dist directory and the zip file as well as the log
and a lint and sonarqube command
and it also runs coverage
It then packages and builds the app

I don't think the .idea directory should be added to source control.

One more IDEA file to delete @mattch1 .


Add typing support for Python bindings

Description
Seems like none of the methods, classes and sub-packages show up in the IDE type hints.

Fixed in 66791ade412817d27917a2bb77a1e5d7cdcdfae9


add svd jvp; fixes #508 for low-rank case

Fixes #508

It appears some tests are failing due to a printing error for complex dtypes:
    def __call__(self, x):
>       r = self.real_format(x.real)
E       AttributeError: 'DeviceArray' object has no attribute 'real'

Should I just remove the JVP tests when the dtype is complex?

Woo thanks!
The test failure is an error on our end. Maybe I can make the fix and then you can rebase on a new master (or merge it)...

Actually, that failure is only coming up because it's failing an assert, then trying to print the mismatched values:
assert tree_all(tree_multimap(close, xs, ys)), '\n{} != \n{}'.format(xs, ys)

So there are two bugs here: one is that a numerical check for this JVP is failing (do the tests pass locally?), and the other is that apparently DeviceArray repr isn't working for complex types (which is a bug I will fix on master).
Does that make sense?

Just noticed that this bug has an auspicious number :)
#667 should fix the repr issue.

No, I fail those tests locally though they only happen with complex numbers. Let me look into it a bit further.


Feature/block 6

Apart from previous review comments, we can take this block as an opportunity to create a generic pipeline generator script instead of needing one script per pipeline type. So, we can provide a config file as parameter containing all the variables that make a test (or QA, or Deploy... any type) different from a build pipeline, like the paths, filenames and such. That way, we can reuse the script for the next blocks.

Change the YAML template and the test script to the path: ./scripts/pipelines/azure-devops/templates/test

The -a option should store the logs generated by the test and not the target folder generated when doing a mvn test, please review the YAML file

All the above review comments are updated.


iptables: Remove unneeded cell.Health param

The cell.Health reporter is not needed anymore, since one it is already provided to the job registered in the manager by the JobGroup.

/test

CI triage:

Conformance Ginkgo hit https://github.com/cilium/cilium/issues/32404
Conformance Runtime hit https://github.com/cilium/cilium/issues/32933

/test

ci-integration failure tracked here, rerunning.


can't start tozo app with psql (v 15.1).

can't start tozo app with psql (v 15.1).
Error message:
raise LifespanFailureError("startup", message["message"])
hypercorn.utils.LifespanFailureError: Lifespan failure in startup. 'permission denied for schema public'
According Article PostgreSQL v15 change permission rules
Had to downgrade PostgreSQL to v14.6 (server run succeed)
Any suggestion on how to modify migration (or model) files to run on PostgreSQL v 15.1?

The book was written before Postgres 15, so I'll need to investigate this. I'd recommend staying on Postgres 14 for now.

Sounds good! Thank you.

To resolve this I added the following to the end of recreate_db(), in backend/src/backend/run.py :
    call(  # nosec
        ["psql", "-U", "postgres", "-d", f"{db_url.path.removeprefix('/')}", "-c", f"GRANT ALL ON SCHEMA public TO {db_url.username}"],
    )

Thank you.

I've added this to the example code with 45a24681f955907a2437db151fa38e06857fe0c6


Make socketURL an environment var

Enable socketURL to be set as an environment var by a cloud platform,
such as Heroku. This would prevent unnecessary merge conflicts once we start working on the Client in the forked repo model. Each dev has their own app

@spascience  Just checking on this if you want to keep this open.


Cant type Anything Updated with logs

Type
Incorrect behavior
Operating System
Windows
OS Version
10
Bug description
Cant type anything all a sudden and have to reload client, happens consistently everyday at random intervals. Lose all keyboard input in terms of typing including sending input for World hopping etc. Keeps getting me pked as I cant use World Finder plugin to hop worlds quickly when i see a pker. Also cant buy quest items in ge etc. Providing pictures wouldnt help because theres nothing to show, I just cant type.
Screenshots or videos
No response
RuneLite version
1.10.24
Logs
client.log

Fix the issue and I will subscribe to the $5 a month patreon, my word.

What was preventing you from just posting the logs and RuneLite version in the existing issue? It's just some numbers and a file

Then you should properly fill in the issue template by providing the RuneLite version, plus your logs when this happens in safe mode, and get us a video of it happening in safe mode with the title bar visible and you hitting alt briefly to try to fix the issue.

I don't see any issues other than spam filter. Did you install and other plugins that can be preventing you from typing? Do the logs include the moment when the issue occurred?

I don't see any issues other than spam filter. Did you install and other plugins that can be preventing you from typing? Do the logs include the moment when the issue occurred?

does it show all the plugins I have installed in the log? because I dont have any others that I run at all besides what is being shown in it. Yes I took the log after the issue occurred and I believe it was updated. ok ill run my clients in safe mode and record it then

I don't see any issues other than spam filter. Did you install or have other plugins that can be preventing you from typing? Do the logs include the moment when the issue occurred?

hey man I figured out whats wrong. Its World Hopper/World Finder. I use Shift+z and Shift+x to world hop. After doing it, I have to send Shift+z again to be able to type again. lmk if you have any luck fixing it thanks


Active XSS filters don't like the buttons.

There's a problem with the way the buttons are implemented in that active XSS filters (that compare requests and results) will trip over the buttons -- specifically because the iframe contents include a base tag which has a URL exactly equal to the URL passed (URLEncoded) in the iframe's src.
From a filter's perspective this would be a reflected XSS attack by having a base statement injected (a common redirection tactic). You may be able to easily work around this by:

using absolute paths and dropping the base tag, or
changing the way the iframe content is constructed so it no longer includes the base URL in the src of it

Presuming these commits have all gone live, the issue is still not fix or is back again:

I believe that is a false alert. Following is how javascript filtering works currently:

The button renders on the same origin to calculate its size.
In this time, <base> is not used. No href attribute is written.
Then, the button reloads in different origin (buttons.github.io).
Set <base> attribute href to button link.
1. If a javascript protocol is detected, reset href to #.
Set button href.
1. If a javascript protocol is detected, reset href to #.
Set count href.
1. If a javascript protocol is detected, reset href to #.
2. Use <base href> and a.cloneNode().href to get an absolute url for count.
Remove attribute href on <base>

I think the false alert is triggered in this step 2.i., which is required for step 2.iii.b.. The reason to filter javascript after set href is that href normalizes url (remove whitespace, etc.), so javascript protocol can be detected reliably.
<base href> or any href won't be executed without clicking on any link, and JavaScript should have been removed before a user can interact with the page.
For example, the following code will result in a link with href="#".

Please correct me, if I am wrong.

It really doesn't matter whether this is a false positive or not. No-one in their right mind will choose to use a script which triggers this warning as it will reflect badly on the perception of their website and brand... which is of course why I'm informing you of it.

I just committed a workaround that does not use <base>. It uses URL API (WhatWG, MDN), which is currently supported by Chrome, Firefox, and Safari. On other browsers that lack of URL API support, it will fallback to current solution.
Unfortunately, the workaround won't suppress the warning until Pale Moon implements URL API. Considering Pale Moon has only about 0.02% of market share, I'd wait its developer for implementing the URL API, rather than shipping a polyfill that may increase the script size by 5x.

For the record, implementing the constructor method for the URL API is on our roadmap (likely for the next major update). If you're looking to use the API for the current location, then the data is already available via URLUtils' window.URL which is supported by all browsers.


♻  NICE-49 getPropertyDataType refactor => segments + types

[x] ♻ NICE-49 getPropertyDataType + select + segments
[x] ♻  NICE-49 getPropertyTypeData rollup
[x] 🏷  NICE-49 from notion hack
[x] ♻  NICE-49 slowly but surely
[x] ♻  NICE-49 rollup overcomplication
[x] ♻  NICE-49 better [0] return on rollup for events
[x] ♻  NICE-49 i have wasted my life

This is where I rue the day I ever saw Notion.

This pull request has been deployed to Vercel.

Latest commit:
da05a5b

✅ Preview:
https://jeromefitzgerald-kw4sgud5d-jerome5.vercel.app

🔍 Inspect:
https://vercel.com/jerome/jeromefitzgerald/4J6ELsgk1mqRZxZPnpiF7bDWCfkp

View Workflow Logs


Multiple @stream fields block each other

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
If a query requests several @streams, I expected items being produced by the IAsyncEnumerable<>s to appear in the response in the order they are produced and as soon as they can be produced. I.e. in Unix terms, that multiple @streams would be independent and behave as if they were select()ed. Instead, HC execution engine awaits the enumerables in reverse query order, and therefore items appear in the response in groups corresponding to the query. If one enumerable cannot produce additional items for an interval of time while others can still produce additional items, the latter enumerables will not even be asked for new items until the slow enumerable produces an item. In the attached example, the fast enumerable produces two items with a latency of 100ms and the slow one with a latency of 1s. The fast and slow items are interleaved in the response rather than fast items arriving before slow ones:
$ curl -g 'http://localhost:11111/gql?query={container{fast@stream{value},slow@stream{value}}}'

---
Content-Type: application/json; charset=utf-8

{"data":{"container":{"fast":[],"slow":[]}},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"path":["container","slow",0],"data":{"value":"slow 0"},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"path":["container","fast",0],"data":{"value":"fast 0"},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"path":["container","slow",1],"data":{"value":"slow 1"},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"path":["container","fast",1],"data":{"value":"fast 1"},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"hasNext":false}
-----

Steps to reproduce
The attached complete minimal repro project demonstrates this behavior.
Relevant log output
No response
Additional Context?
No response
Product
Hot Chocolate
Version
12.15.2, 13 preview

In 13 this is no longer the case. In 12 you are right. The response you have posted is an older one. The new response uses the incremental prop and everything is done in parallel

But we still are refining things

Closing this issue as this is no longer the case.


[WIP] feat(csp): add reportOnly option

This PR adds a reportOnly option to the render.csp object that's enabled when in dev mode by default.
It will change the header from the usual Content-Security-Policy header to the Content-Security-Policy-Report-Only header. When this header is set, the CSP isn't fully enabled but provides information about violations of the CSP and how to fix them.

Tests are failing, but not bc of the code change :thinking:
FAIL test/fixtures/with-config/with-config.test.js (81.903s)
  ● Build with-config
    Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.
      2 |
      3 | export const buildFixture = function buildFixture(fixture) {
    > 4 |   test(`Build ${fixture}`, async () => {
        |   ^
      5 |     const config = loadFixture(fixture, {
      6 |       test: true,
      7 |       build: {
      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)
      at buildFixture (test/utils/build.js:4:3)
      at Object.<anonymous> (test/fixtures/with-config/with-config.test.js:3:1)

Codecov Report

Merging #3559 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #3559      +/-   ##
==========================================
+ Coverage   99.19%   99.19%   +<.01%
==========================================
  Files          18       18
  Lines        1116     1117       +1
  Branches      300      301       +1
==========================================
+ Hits         1107     1108       +1
  Misses          9        9

Impacted Files
Coverage Δ

lib/common/options.js
100% <ø> (ø)
:arrow_up:

lib/core/middleware/nuxt.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfef525...b6a9ad4. Read the comment docs.

Sounds good to me, do you mind resolving the actual conflicts @manniL ?

@Atinux I've resolved the conflicts and adapted the tests a little. Should be fine now :)


cmd/compile: "escapes to heap" for arrays with capacity from variable regression

Consider this simple example:
$ cat 1.go
package main

func main() {
	l := 123

	buf := make([]byte, 0, l)
	_ = buf

	buf2 := make([]byte, 0, 123)
	_ = buf2
}

http://play.golang.org/p/mGfIERaXRL
$ go version
go version go1.4.3 linux/amd64
$ go build -gcflags=-m 1.go
# command-line-arguments
./1.go:3: can inline main
./1.go:6: main make([]byte, 0, l) does not escape
./1.go:9: main make([]byte, 0, 123) does not escape

$ go version
go version go1.5 linux/amd64
$ go build -gcflags=-m 1.go
# command-line-arguments
./1.go:3: can inline main
./1.go:6: make([]byte, 0, l) escapes to heap
./1.go:9: main make([]byte, 0, 123) does not escape

array escapes to heap in 1.5, but does not escape in 1.4

Evidence (assembly language, and s/123/32000000) suggests that go 1.4 was in fact performing a heap allocation and not being entirely honest about it.  So, not a bug.
	0x0022 00034 (.../eth.go:4)	MOVQ	$123,AX
	0x0029 00041 (.../eth.go:6)	MOVQ	$type.[]uint8+0(SB),BX
	0x0030 00048 (.../eth.go:6)	MOVQ	BX,(SP)
	0x0034 00052 (.../eth.go:6)	MOVQ	$0,8(SP)
	0x003d 00061 (.../eth.go:6)	MOVQ	AX,16(SP)
	0x0042 00066 (.../eth.go:6)	PCDATA	$0,$0
	0x0042 00066 (.../eth.go:6)	CALL	,runtime.makeslice(SB)
	0x0047 00071 (.../eth.go:6)	NOP	,

makeslice calls newarray calls mallocgc.

I think there is some conflation of concerns here.  We must heap allocate if the value either escapes or is variable sized.  go1.4 is correct in saying buf does not escape.
Does escape analysis in 1.5 mark variable-sized allocations as escaping?  That's not technically correct, but it's academic at this point because it will get heap allocated either way.  But it may matter at some point in the future (per-goroutine private heaps?  Function-local alias analysis?)

For purposes of not losing our minds in the escape analysis code, "escapes" and "heap allocated" are one and the same.  There are some latent bugs in the 1.4 escape-analysis code, some related to constant-but-very-large allocations being late-escaped to the heap -- and potentially dragging pointers to the stack with them because the allocation was moved after escape analysis ran.
I think most people who care about this flag care about the "heap allocated" part, so perhaps we should change the message to be clearer?

I see now, heap->stack pointers bad.  Changing the message sounds good, although it might not be worth the big CL that would entail.


Add SwiftUI

I added a folder containing a README, a folder with the source, and the .xcproj. You will need to download the contents of the SwiftUI folder to build the project. There are three targets, one for iPadOS and iOS 16.1 , one for tvOS 16.1  and one for macOS 13 Ventura.

I don't think all of this is needed sorry!


Gravity 7.0.23 does not install when invoked outside the unpacked tarball

Description
What happened:
I tried to run a 7.0.23 gravity install from a directory that wasn't the unpacked installer tarball directory.
What you expected to happen:
I expected gravity to install, as it does in 7.0.16.
How to reproduce it (as minimally and precisely as possible):
Download & unpack 7.0.16 and 7.0.23 tarballs. Move to a directory that isn't an unpacked installer tarball.
-bash-4.2$ ls ~/
7.0.16  7.0.23  test
-bash-4.2$ pwd
/home/centos/test

Try to install 7.0.16:
-bash-4.2$ sudo /home/centos/7.0.16/install --cloud-provider=generic
[ERROR]: unknown long flag '--cloud-provider'
-bash-4.2$ sudo /home/centos/7.0.16/gravity install --cloud-provider=generic
Thu Oct 29 00:21:04 UTC Starting enterprise installer

To abort the installation and clean up the system,
press Ctrl+C two times in a row.

If you get disconnected from the terminal, you can reconnect to the installer
agent by issuing 'gravity resume' command.

If the installation fails, use 'gravity plan' to inspect the state and
'gravity resume' to continue the operation.
See https://gravitational.com/gravity/docs/cluster/#managing-an-ongoing-operation for details.

Thu Oct 29 00:21:04 UTC Connecting to installer
Thu Oct 29 00:21:18 UTC Connected to installer
Thu Oct 29 00:21:18 UTC Successfully added "node" node on <IP_ADDRESS>
Thu Oct 29 00:21:18 UTC All agents have connected!
^CPress Ctrl+C again to abort the installation.
^CReceived interrupt signal. Aborting the installer gracefully, please wait.
[ERROR]: operation aborted

Try to install 7.0.23 the same way:
-bash-4.2$ sudo /home/centos/7.0.23/gravity install --cloud-provider=generic
Thu Oct 29 00:21:48 UTC Starting enterprise installer
[ERROR]: failed to validate installer directory. Make sure you're running the installer from the directory with the contents of the installer tarball
        specified state directory /home/centos/test does not contain application data, please provide a path to the unpacked installer tarball or specify an application package via --app flag

Environment

Gravity version [e.g. 7.0.11]: 7.0.23
OS [e.g. Redhat 7.4]: CentOS 7.8
Platform [e.g. Vmware, AWS]: GCP

Workaround, supply the installer directory as a positional argument:
-bash-4.2$ sudo /home/centos/7.0.23/gravity install --cloud-provider=generic /home/centos/7.0.23
Thu Oct 29 00:29:38 UTC Starting enterprise installer

To abort the installation and clean up the system,
press Ctrl+C two times in a row.

If you get disconnected from the terminal, you can reconnect to the installer
agent by issuing 'gravity resume' command.

If the installation fails, use 'gravity plan' to inspect the state and
'gravity resume' to continue the operation.
See https://gravitational.com/gravity/docs/cluster/#managing-an-ongoing-operation for details.

Thu Oct 29 00:29:38 UTC Connecting to installer
Thu Oct 29 00:29:45 UTC Connected to installer
Thu Oct 29 00:29:46 UTC Successfully added "node" node on <IP_ADDRESS>
Thu Oct 29 00:29:46 UTC All agents have connected!
^CPress Ctrl+C again to abort the installation.
^CReceived interrupt signal. Aborting the installer gracefully, please wait.
[ERROR]: operation aborted

A bisect shows this was introduced in 7.0.22.  Likely via https://github.com/gravitational/gravity/pull/2240.
It is not present in master (7.1 alpha):
-bash-4.2$ sudo /home/centos/7.1.0-alpha.1.250/gravity install --cloud-provider=generic
Thu Oct 29 00:50:34 UTC Starting enterprise installer

To abort the installation and clean up the system,
press Ctrl+C two times in a row.

If you get disconnected from the terminal, you can reconnect to the installer
agent by issuing 'gravity resume' command.

If the installation fails, use 'gravity plan' to inspect the state and
'gravity resume' to continue the operation.
See https://gravitational.com/gravity/docs/cluster/#managing-operations for details.

Thu Oct 29 00:50:35 UTC Connecting to installer
Thu Oct 29 00:50:43 UTC Connected to installer
Thu Oct 29 00:50:44 UTC Successfully added "node" node on <IP_ADDRESS>
Thu Oct 29 00:50:44 UTC All agents have connected!
Thu Oct 29 00:50:44 UTC Operation has been created
Thu Oct 29 00:50:46 UTC Executing "/init/walt-70-upgrade-node-0" locally
Thu Oct 29 00:50:46 UTC Initialize operation on node walt-70-upgrade-node-0

cc @a-palchikov

Fixed in 7.0.24 by https://github.com/gravitational/gravity/pull/2295.


Impl self methods not checking impl self constraints

As found by @bitzoic in https://github.com/FuelLabs/sway/pull/5045
This compiles:
struct MyStruct {
    val: u64
}

abi MyContract {
    #[storage(read, write)]
    fn test_function();
}

storage {
    my_map: StorageMap<MyStruct, u64> = StorageMap {},
}

impl MyContract for Contract {
    #[storage(read, write)]
    fn test_function() {
        let my_struct = MyStruct { val: 1 };
        storage.my_map.insert(my_struct, 2)
    }
}

When this does not, even though the insert() function uses the same sha256<T>() function:
use std::hash::sha256;

struct MyStruct {
    val: u64
}

abi MyContract {
    fn test_function();
}

impl MyContract for Contract {
    fn test_function() {
        let my_struct = MyStruct { val: 1 };
        let result = sha256(my_struct);
    }
}

Originally posted by @bitzoic in https://github.com/FuelLabs/sway/issues/5045#issuecomment-1695668178
Seems like storage.my_map.insert(my_struct, 2)should not compile because my_struct does not implement the Hash trait, the insert should inherit the constraints from the impl self but somehow it does not detect the missing constraint.

Contrary to what is reported the following code does not compile and gives the expected error:
struct MyStruct {
    val: u64
}

abi MyContract {
    #[storage(read, write)]
    fn test_function();
}

storage {
    my_map: StorageMap<MyStruct, u64> = StorageMap::<MyStruct, u64> {},
}

impl MyContract for Contract {
    #[storage(read, write)]
    fn test_function() {
        let my_struct = MyStruct { val: 1 };
        storage.my_map.insert(my_struct, 2)
    }
}

11 |
12 | storage {
13 |     my_map: StorageMap<MyStruct, u64> = StorageMap::<MyStruct, u64> {},
   |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Trait "Hash" is not implemented for type "MyStruct".
14 | }

The following code is also throwing the expected error:
trait Hash {
    fn hash(self) -> u64;
}

struct Struct<T> {
}

struct Struct2<T> {
}

struct StructHashable {
}

/*
impl Hash for StructHashable {
    fn hash(self) -> u64 {
        42
    }
}
*/

impl<T> Struct<Struct2<T>> where T: Hash {
    fn call_hash(self, hashable: T) -> u64 {
        hashable.hash()
    }
}

fn main() {
    let a = Struct::<Struct2<StructHashable>> {};
    let b = StructHashable {};
    a.call_hash(b);
}

32 |     let b = StructHashable {};
33 |     a.call_hash(b);
   |       ^^^^^^^^^ Trait "Hash" is not implemented for type "StructHashable".
34 | }


Get rid of Immutable

Immutable is only used as a way to stock data inside store.
We can use native Map, et have a freeze function based on Object.freeze
That way, we could get rid of a useless dependency and have smaller bundle.

For deep freeze, see an example there : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze


Duplication of hull and perks

If you add more than six vehicles and scroll to the bottom and to the top again, the first listed vehicles hull and perks gets duplicated create issues for large can games or teams using warden or beverly as sponsor

Thank you for the issue. I have some clue what is going wrong but the fix, on the first look is pretty laborious so it will take some time.

I believe that the problem is now gone. Please update the app.


Improve/fix tree-shaking

Even though we added sideEffects: false to all packages, tree shaking still seems to be an issue.

I've done a couple of days of heavy digging on this…
Given we've all already (or about to) wind up for the end of the year, I thought I'd summarise where we're at with this here, given that I'd rather pick it back up in Jan as it's a decent task with lots of impacts on build tooling, etc
So here goes…

As far I can tell, we have 3 main culprits preventing us from having tree-shaking work for us:

the way our builds are setup
Xxx.displayName = "Xxx"; statements
forwardRefWithAs calls

build setup issues
Firstly, our default build is a production build with minification turned on. This means that although, parcel adds /*#__PURE__*/ annotations on react calls, etc (via babel), it also actually removes the comments using terser (because it minifies…)
displayName
It seems static properties on functions are basically a no go for tree-shaking. This article sums it up nicely. It has to do with how optimizers like terser compress code with statics.
We can resolve this easily using a babel plugin to:

wrap our displayName statements in if(process.env.NODE_ENV !=== "production") checks
or manually wrap them in if (__DEV__) checks and have a babel plugin to replace that to the above check

I have tested both approaches and they both work well.
forwardRefWithAs
The same way babel-plugin-transform-react-pure-annotations adds /*#__PURE__*/ annotations to certain react calls (including forwardRef) we also need to do the same with our own custom forwardRefWithAs.
Again, this is fairly easy to do with a custom babel plugin. I have done it and tested it and it works great.

Now, I also think we have other issues with our build which prevent us from having this all work nicely, it's all a bit intermingled. For example parcel seems to eagerly replace process.env.NODE_ENV which means its value ends up being hardcoded in the dist files.
That means this is actually forcing us to create development and production builds of each package, which we started looking into but brought a bunch of other surprises/issues.

NOTE: I have tested all of the above only with @radix-ui/react-avatar package so it was easier to identify the issues. I don't think we're guaranteed that these are the only issues. I am pretty sure for examples at least a few other calls will need to be annotated but at this point then it's pretty simple to do once we have the whole infra in place (ie. the custom babel plugin working, etc).

I have pushed my current WIP to a branch called tree-shaking-experimentation

This is excellent, thank you! We had issues with custom babel plugins early on when we switched over to Parcel (we specifically used the dev expressions plugin in the old build and removed it because of this). I'll take a look at your branch, but have you already tried running the full build script when using the Babel plugins you mentioned here, or were you just building the individual avatar package?

Interesting, do you remember what issues those were?

I don't specifically, but @jjenzz set it up initially and I know she said she was struggling with the __DEV__ expressions, so we opted to just remove them for the time. She might have more insight. I can also take a peek at this branch to see if I can't replicate the issue later this week.

@chaance I just wasn't sure how to add babel plugins to Parcel at the time and didn't want to spend too much time on it but @benoitgrelard has figured out that just adding .babelrc works fine 🙂

Closed via #577


#517 master detail more abstracted with flexible master width

#517

Ok, so then the question will be whats next ?
DO we get all pages to start to use Master Detail abstracted code now ?
Does it work with all our pages like in mod-main where we have dynamic forms being built from the data for Your Needs, etc

It's currently only used in mod-main dashboard and mod-writer.
Yes we can use it for all master-detail views we have as you said also for dynamic forms as the input has to be a List (master) and a Details View (e.g. generated form, depending on the item selected of the list)


chore(git): add pre-commit and config

Proposed changes
Add config for pre-commits. This will run black, isort and flake8 automatically when committing.
Issue number: No issue
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Pull request title follows conventional commits (type(scope): description)
[x] Build (make PR) was run locally without failures

Further comments
Updated Pipfile to make use of dev-dependencies.
Steps to take in order to use pre-commits locally:
Install pre-commit:  pip install pre-commit
Install the  git-hooks script: pre-commit install
I will create a more detailed how to on slab 😄

Does it run the test before commiting aswell. I dont know if we want that but it will remove some of the commits that fail because of failed test.

No it does not run the tests on commit. I don't think that is desirable as it would take a long time to create a commit :/


feat: add content_reference link parsing

See #259 for more detail.
Adds the interface for content_reference json section and replaces the following Unicode markers in html and markdown exporters.
\uE203: Marks the start of a block of text. -- removed
\uE204: Marks the end of the block of text. -- removed
Citation format: -- substituted
\uE200cite\uE202turn0search3\uE201
The html exporter also includes the snippet on hover:

Found a case where the content_reference is defined in the text and then hidden.


DSI | applying_statistical_concepts | Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
added solutions to assignment_1.ipynb, worked through exercises 1 2 and 3
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

alternative hypothesis is still missing for A1 Q2

alternative hypothesis is still missing for A1 Q2
Sorry you couldn't find it, the commit in question is here:
https://github.com/gordonmod8/applying_statistical_concepts/pull/1/commits/245ff4099574a0bb9b3690266cb17881c1bbb2d1


Decorated functions ignored

This is similar to a topic documented in your troubleshooting guide, but not precisely. In this case, I'm using the Python builtin @[property_name].setter decorator to set a property, but this docstring is ignored by mkdocstrings. In fact, that property of the class I am documenting is not registered at all, even when explicitly selected with
    selection:
      members:
        - property_name

EDIT: This property will show up like
property_name property writable
with no docstring if I set       show_if_no_docstring: true
I would be happy to try to fix this, if you can point me in the right direction.
Thanks!

Argh, scratch that, I had the docstring set on the setter, not the getter

I was thinking, maybe we could merge the setter docstring into the getter one. I'll people comment on this or upvote.


Consider moving away from assert for code that runs in the browser

The assert library is a native node API that has a client side equivalent that Fluid has been taking a dependency on:
https://github.com/browserify/commonjs-assert
The library itself is quite small, but it does pull in a lot of dependencies. Specifically it pulls in these dependencies:
    "es6-object-assign": "^1.1.0",
    "is-nan": "^1.2.1",
    "object-is": "^1.0.1",
    "util": "^0.12.0"

I did a demo where I modified the webpack config in examples/collaborative-textarea
        resolve: {
            extensions: [".ts", ".tsx", ".js"],
            alias: {
                "assert": path.resolve(__dirname, 'assert.js')
            }
        },

Where assert.js is a js file in the root of the package with this definition
export function strict() {
}

This took the bundle down by 7KB gzipped and 24KB uncompressed.
Can we instead write a lightweight isomorphic library that provides the same functionality?

The bundle size impact appears even worse in Webpack 5, since it ends up pulling in assert v2 (respecting the package.json of FF), where v4 was including assert 1.5
Webpack bundle analyzer isn't fully compatible with WP5, so it is hard to get exact numbers, but it seems the impact of assert is about 55KB uncompressed

This isn't an immediate priority. We're using assert pretty widely. The assert package is pretty commonly used.

@SamBroner  - I think we should make it a priority since it is about >15% of Fluid's bundle size. I don't think it's that commonly used in browser code.
I'll take this on myself.

Oh, great. If you do it, that'd be awesome!
Is there a better OSS assert package? I'd rather not be on the hook for maintenance or code complexity. Reimplementing assert is probably not the hard part.

We only really need a very simple thing, which I've already proposed in #4108. No need to pull in a dependency for our use case here


Sort by Genre Before Scraping

I have 1200 movies in one library called Films. I want to filter this down to just the best. I tried doing this by adding a Genre "Favorites" to posterr, And adding that to movies I want, but now only about 5 are popping up in the cycle.
I'm guessing what's happening is it's picking up 300 (the maximum) movies out of that library and then filtering those out by genre. Is it possible to genre sort first so that I can make sure more come through?
I considered using custom images instead, but couldn't get anything to come through that method. Mapped a share to /docker/posterr/custom/ and added them there but still nothing?

Custom pictures sit in the posterr/custom/pictures/default folder. Alternatively you can create any folder name under pictures, then select this from the settings page.

Genres are a bit trickier. This is a limitation i found in the plex api where not everything is always returned. Until that is resolved, i cant do much.


Add option for user to choose which module logic to use

My logic for modularized json files is different compared to what is shown in the examples directory :

In example : locale = directory, module = file

— res
—  — locale-de
— — —moduleA.json
— — — moduleB.json
— — locale-en
— — — moduleA.json
— — — moduleB.json

In my project : locale = file, module = directory

— res
— —moduleA
— — —de.json
— — —en.json
— —moduleB
— — —de.json
— — —en.json

It could be nice to have a toggle in the plugin settings, so then we can choose which module logic we want to use.

I will use this ticket to reengineer the IO system.
New IO configuration
Folder-Strategy:

flat (single-layer)
modularized: namespace - locale
modularized: locale - namespace

Parser-Strategy

json
yaml
properties

File-Pattern-Strategy: (adjusts automatically when changing parser)

.
*.json and so on...

New flow: DataStore -> FolderStrategy -> ParserStrategy -> TranslationData
IOHandler
Constructor: FolderStrategy, ParserStrategy

read: whole read process using configured strategies
write: whole write process using configured strategies

FolderStrategy
Responsible for managing the local project structure for translation files (namespace, file-pattern)

read: Locales Path -> Locales / Modules -> VirtualFile -> ParserStrategy -> TranslationData
write: TranslationData -> Modules / Locales -> ParserStrategy -> VirtualFile

ParserStrategy
Parses the actual translation files

read: VirtualFile -> locale & (namespace) -> TranslationData
write: TranslationData -> locale & (namespace) -> VirtualFile

You can configure your preferred folder structure with the next release. Don't forget to star this repository 👍

Thank you for quickness ! 😎 ❤


Display Logout instead of Login in the FOOTER if authenticated user.

Whenever using RTV, the footer displays login even though I'm already logged in.
Suggestion: Add a second FOOTER definition in the docs.py and add the logic in the init for the page.

👍 Sounds like a minor and reasonable addition if somebody wants to open a PR

I'm taking a shot at this one.


I love it.

;-)

awesome! i love cznic/ql already and waiting this sqlite package!
would be helpful to get somewhere missing features list.
Thnks!


Auth guard driver [api] is not defined

On setting using lucadegasperi/oauth2-server-laravel, I get Auth guard driver [api] is not defined any help?

I'm going on a whim here, but I'm 99% sure you're missing an api entry in your config/auth.php file.
Something like this:
        ...
        'api' => [
            'driver' => 'token',
            'provider' => 'users',
        ]

Hope that helps @drosendo

I was missing a file. :/ lololol


Create release artifact

A brimcap release artifact should be created and include these dependencies:

The suricata runner
The zeek runner

The brimcap default config for analyzer should assume the zeekrunner and suricatarunner are adjacent to the brimcap executable path.

@mattnibs: I'm sure you'll bump into this, but keep in mind the role of the "suricata updater" as well.


How to watch a movie list at once

Many movies in the movie guide are arranged with movie posters. As a result, only four movie lists can be viewed on the smartphone screen. So I suggest a feature that allows you to view a list of movies at once for the Movie guide.

@tjalsrb97 thanks for the suggestion. I'm redesigning the app and will consider this as well.


Incorporate Constructive Solid Geometry Example

Create an example to showcase constructive solid geometry
https://evanw.github.io/csg.js
https://en.wikipedia.org/wiki/Constructive_solid_geometry

I added a very basic example to JSFiddle relating to constructive solid geometry. This example is still using GameObject and has not yet been updated to XEO.Entity.
https://jsfiddle.net/philmaker/0e3hw1d4/

I've added your CSG example to the core examples collection, thanks: http://xeoengine.org/examples/#geometry_csg_example1


Add company name to Account Overview page (#157)

Adds company name to Account Overview page and makes it editable (#157).

thanks @lukewaring! 🎉

Happy to help @reichert621! 😀


vWii Content Decryption is Broken

Currently, trying to decrypt a vWii title will leave you with garbage data in each of the contents. The correct key is being detected and used, so I'm not sure where the issue is currently.
Needs investigation. Korean titles should be checked too since they also use a different key.

This seems to be an offset issue, where it's not reading the start of the content region correctly, resulting in garbage data.

This was an issue caused by having a poorly made WAD of the vWii System Menu. Don't trust weird dumps from Wii homebrew on the vWii apparently, as it left me with key 2 in the Ticket but content encrypted with key 0 lol.


Update check

Update check added for macOS, Issue #1087

@Rockindash can we please do a automatically update check when app start , if there is update , then let's show a banner to prompt user update their app


download/installation info on the website?

I couldn't easily find any info regarding recommended way(s) to download and/or install Pony on the website (i.e. are there nightly/release builds? do most people build from source? should I grab it from a package manager? etc). Maybe I didn't look hard enough... but a link to something like that should jump off the landing page for Pony, IMHO. It would make it a lot easier for newcomers to quickly saddle up =)
Here are a few examples of programming languages whose sites have a download link fairly visible on the main page:

https://www.haskell.org
https://ocaml.org
https://www.rust-lang.org/
https://racket-lang.org

Thanks for the suggestion. We aren't going to go in that direction but I am leaving this open as a reminder that the first page needs more, go here for X type info as its still the placeholders I put in a while ago.

I'm going to work on this this weekend. Thanks for the inspiration @pnwamk.

I just had the same experience. I heard about Pony via various channels, and Pony sounded interesting to me so I wanted to try it. To me, the natural thing to do was to go to the website.
I have two suggestions:

Name pages and links after their content, rather than their target audience.
Link the tutorial from the frontpage. “New to Pony? Start here” should really link to the tutorial. Getting help and opening issues are not things to start with, they are for when you get stuck after you’ve started.

I’ll write down my thought process below, in the hope that it will be useful for improving the user experience of the website.

We’ve set up the website to be based on who you are.

Okay, that is a bit weird ... who I am will probably not change a lot over time, but I imagine I might be looking for different things (a download link now, likely API documentation later).

New to Pony?
Learning Pony?
Existing Pony User looking for stuff?

I am new to Pony. Hopefully that page will contain a download link.
*clicks New to Pony*

What is Pony?
Pony is an open-source, object-oriented, actor-model, capabilities-secure, high-performance programming language.

Hmm, no, this page tells me what Pony is, but I already knew that.
*hits the back button*

New to Pony?
Learning Pony?
Existing Pony User looking for stuff?

Well, I do want to learn Pony. Probably that page will link to a tutorial or some introductory documentation, and the first thing it is going to do is explain how to obtain Pony.
*clicks Learning Pony*

Getting help
...
Mailing list, IRC
...
Open an issue
...
Reference capabilities
...
A note about code samples
...

Ok, so there is a mailing list and an IRC channel, but hopefully I don’t have to go there to ask for a download link. There is some stuff about reference capabilities, that is probably the thing that I am going to struggle with. And there is a warning of some kind.
To be fair, I should have noticed the “Tutorial” link here, which does indeed point to the installation instructions early on. Unfortunately I missed it.
Maybe I am an existing user then? Existing users occasionally need to download the toolchain, don’t they?
*clicks Existing User in the menu on the left*

Pony LLDB Cheatsheet
Pony Performance Cheatsheet

Nope, that’s not it either. Let’s check the homepage one more time.
*clicks the logo in the top left corner*
And that is how I accidentally ended up on the GitHub page, which does contain installation instructions pretty early on in the readme.

Pushing a change to make this more obvious this afternoon.


0.10.3

Would appreciate it if you could either include https://github.com/rustwasm/wasm-pack/pull/1117 with this release or make a feature release for it :)
Now that https://github.com/rustwasm/wasm-pack/pull/1119 was merged this should be ready.

Would appreciate it if you could either include #1117 with this release or make a feature release for it :) Now that #1119 was merged this should be ready.

Will do it in a new release.


cargo deny mutliple-fields ban

using https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html#the-multiple-versions-field-optional
to try to prevent issues like https://github.com/kube-rs/kube-rs/issues/709 in the future
i had issues originally, but deleted my local Cargo.lock and on a rebuild all the duplicates had gone away.
will add and remove a duplicate dependency here to ensure that this setup works.
(there are ways to temporarily whitelist from the duplicate ban list, so this shouldn't be a big inconvenience)

Test failed as it does locally:
error[B004]: found 2 duplicate entries for crate 'tungstenite'
    ┌─ /github/workspace/Cargo.lock:220:1
    │
220 │ ╭ tungstenite 0.13.0 registry+https://github.com/rust-lang/crates.io-index
221 │ │ tungstenite 0.14.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰────────────────────────────────────────────────────────────────────────^ lock entries

There's a warning
warning[S006]: allowed 'github.com' organization  was not encountered
   ┌─ /github/workspace/deny.toml:64:11
   │
64 │ github = ["kube-rs"]
   │           ^^^^^^^^^ no crate source fell under this organization

Is this necessary for something?
https://github.com/kube-rs/kube-rs/blob/519cc7b6332b059cf0c487d81f6d32e5579272a7/deny.toml#L63-L64

Is this necessary for something?

Technically no. i think Lars put it there as a convenience to allow things in a big org with private repos, but we don't have that stuff. I'll remove it.

Warning gone. Merging.


blind tree integration with team loader

Thanks for the comments @maxtaco. I addressed most of them. PTAL

@AMarcedone there are legit CI failures, be sure to address them

What ever come of the performance issues around tests?


Support PowerShell package on Server 2008 R2

Package doesn't work on Server 2008 R2. I was able to run powershell.exe after adding the following files to the package:
API-MS-Win-Eventing-Provider-L1-1-0.dll
api-ms-win-core-version-l1-1-0.dll
api-ms-win-core-registry-l1-1-0.dll
api-ms-win-core-console-l2-1-0.dll
api-ms-win-core-shlwapi-legacy-l1-1-0.dll

Are you installing the Windows 8.1 package on Windows 7? If so, that is not a supported scenario.
I've run the Windows 7 MSI on a fully patched Win 7 SP1 system without issue. You can build it using Start-PSBuild and Start-PSPackage by specifying the Win7-x64 Runtime.

So we did support this (and we plan to continue to support it), but it's blocked on #3747. Given that that's basically the same issue, closing this one as a duplicate.


ast: fix Restore for INL_HASH_JOIN / INL_MERGE_JOIN hints (#1091)

cherry-pick https://github.com/pingcap/parser/pull/1091

LGTM


Oh hey i had no idea that i was actually trying to merge into your repo I'm extremely sorry.


feat: Add artwork search to "My Collection" artwork form

The type of this PR is: Feature

This PR resolves CX-2167
Description
This PR splits the "My Collection" artwork form into three different screens and adds artwork search.
Tracking is not included here and will be added in a later PR once I've found out which events to track.
https://user-images.githubusercontent.com/4691889/147474355-3febde73-b0f9-4b27-8181-ca9410b9cdc2.mp4

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[x] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Update "My Collection" artwork form (add artwork search) - ole

iOS user-facing changes

Android user-facing changes

Dev changes

@brainbicycle I've resolved the merge conflict and brought back the missing tests about the image upload. Let's merge as soon as possible (if all questions are answered and everything is working as expected) to avoid additional merge conflicts.


Not detecting true nodes as true ... always false

After a frustrating afternoon trying to understand why my Json true's were always reading as false I have identified the following change that may help others:
gason.txt
The diff shows that the payload is being checked for true and false JsonValue structures when their value can simply be got from the tag.
Many Thanks
Maurice Castro

Thank you very much for this! You saved me quite the headache.


[KafkaIO] Share size and offset estimators among ReadFromKafkaDoFn instances per PTransform

This change adds shared caches among unique instances of ReadFromKafkaDoFn, identified by a static AtomicLong which is stored as an instance field and incremented during construction of the DoFn. The constructor is bypassed during deserialization at execution time, thus providing a shared identifier for all instances of ReadFromKafkaDoFn for a single transform.
Note: this PR is stacked on top of #32921, #32920 and #32889

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

assign set of reviewers

LGTM, please fix the conflicts and this should be good to go

Done, should be good to go once #32921 is merged.

@johnjcasey rebased and updated where required. PreCommit Spotless is failing, so I ran its action (./gradlew spotlessCheck checkStyleMain checkStyleTest :buildSrc:spotlessCheck) locally and that passed.
@Abacn any thoughts?

Run Spotless PreCommit

PreCommit Spotless passed: https://github.com/apache/beam/actions/runs/11817154535
Not sure why the check overview doesn't update.

Done, should be good to go once #32921 is merged.

#32921 is merged, need to rebase this PR onto the current master branch

Run Spotless PreCommit


support handling large time series with high sampling rates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dongyu Liu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.