Pf v df

Add notebook and rst file for PF tutorial (MAG)
Need to be on pf\dev to run

I have put the data and mesh files on google app engine:

https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/GravData.obs
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/Initm.den
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/Initm.sus
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/MagData.obs
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/Mesh.msh
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/SimPEG_Grav_Input.inp
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/SimPEG_MAG_l2l2.sus
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/SimPEG_MAG_lplq.sus
https://storage.googleapis.com/simpeg/tkc_synthetic/potential_fields/SimPEG_PF_Input.inp

These can be downloaded there instead of having them stored in the repo. Here is an example of downloading files using python.
http://stackoverflow.com/questions/22676/how-do-i-download-a-file-over-http-using-python
Would you mind using the download call instead of storing the data / mesh files here? Let me know if you run into any issue (or if I forgot any files!)

That will be interesting. Maybe I can add a Remote switch in the Driver?

That will be interesting. Maybe I can add a Remote switch in the Driver?


Android 5.0 blocks third party cookies, needs setAcceptThirdPartyCookies()

Lollipop makes some security changes to the default webview. One of these is blocking cross-domain cookies.
So if your app logs in from localhost to example.com and then uses a cookie to authenticate subsequent requests, the webview will no longer be able to use that cookie.
I've tested this and indeed cookies received from the server are no longer sent if being used for cross-domain requests (which is the only way hybrid apps can use them).
Would it be possible to give us a setting which allows us to enable third-party cookies? The runtime would need to then call setAcceptThirdPartyCookies() when creating the webview, as in this example..

API 21 is now included in the list of min sdk levels.

great..!

Delivered in Android 4.0.4-edge6


CONFLUENT: Skip publishing for kafka-streams-upgrade-system-tests

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Four test failures but otherwise the build looks good:
kafka.api.PlaintextEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe(String).quorum=zk
kafka.api.SaslPlainSslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe(String).quorum=zk
kafka.api.SaslPlainSslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe(String).quorum=zk
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

Given that this PR only changes build.gradle, I think it's safe to say that these test failures are flaky.

Thanks for the PR. If we don't need to publish these, should we submit this change upstream?

Sure, happy to do that if it's preferable. I targeted this repo since I had thought there was urgency to unblocking these builds, while AK is not impacted.
@mjsax can you confirm whether we want this change in AK as well? If so I'll switch to targeting AK directly.

@vcrfxia We can go ahead with this repo first, if necessary. But good to upstream the change if it makes sense. If we don't need these projects published, it's a win all around to remove them. :)

I merged this to master. It probably needs to be cherry-picked to older branches too.

I thought we wanted to stop publishing javadocs and test jars? -- Does the system test Jenkins job not need to access those artifacts?


Intellisense, typehints, and subclasses

Consider the following code:
class Base:
    def base_method(self):
        pass

class Sub(Base):
    def sub_method(self):
        pass

If I declare an instance of Sub, Intellisense will properly pick up that it has a base_method:

Now consider we write some function that should accept Base or any subclass thereof. My understanding is that some_function has the correct typehint:
def some_function(p: Base) -> Base:
    return p

Calling some_function with a Sub instance results in Intellisense not seeing that its return value should have a method called sub_method:

MyPy is not giving me an error so I believe the typehint is correct. Forgive my crude description of what's actually happening, but it seems to me that PyLance sees the typehint and just stops inspecting what the actual parameter p is. Thus my typehint actually breaks intellisense because it will never see any of the members of the subclasses.
Let's also write the same function, but without typehints:
def untyped_function(p):
    return p

PyLance is now forced to figure out types on its own, so the Intellisense is correct.
This can get hairy as the typehints "trickle down":
class PartiallyTypedContainer:
    def __init__(self, p: Base):
        self._p = p

    @property
    def p(self):
        return self._p

I have this exact situation (in much more complicated code) - I tried to remove typehints so that the Intellisense was correct, but I failed to follow the whole trail. This is, of course, just a work-around and not a proper solution.
If I'm correct that PyLance is "feeding" this information to Intellisense, then I believe the behavior is wrong. Typehints should be ignored by Intellisense as far as showing members while typing is concerned.
Version info:
Version: 1.62.3 (user setup)
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T08:11:14.551Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043
Pylance: v2021.11.2
Python: 3.8.10

The problem here is with your type annotations for some_function. The annotations you have provided indicate that the function always returns a value of type Base. The type checker therefore cannot assume that it's the same type as the input parameter. For example, this is a legal implementation for that same function:
def some_function(p: Base) -> Base:
    return Base()

If your intent is for some_function to return a value that is the same type as the input parameter, the correct way to annotate it is as follows:
_T = TypeVar("_T", bound=Base)
def some_function(p: _T) -> _T:
    return p

For more details about generic functions and type variables, refer to PEP 484.
When type annotations are provided, pylance honors them according to the typing specs. When annotations are not provided, pylance does its best to infer the intent. That's why you're seeing the desired behavior with the untyped function.

It seems to get this to work with classes, it's one step more complicated:
class FullyTypedContainer(Generic[_T]):
    def __init__(self, p: _T):
        self._p = p

    @property
    def p(self) -> _T:
        return self._p

This is the only way I've found to get the Intellisense to show properly when doing:
c = FullyTypedContainer(Sub())
# c.d. <-- Intellisense shows the `sub_method` as desired

This seems like a whole lot of work to just say "this or a subclass thereof". Is this correct?

Yes, you got it! Generic type support was added to the language specifically to handle cases like this.

Thanks @erictraut for the help!


[v0.2] Large memory overhead in cutout.pv

Different topic:
I failed to run cutout.pv(...) for the last days and found the problem to be insufficient memory (the script ran slowly and crashed at one point in time without a tractable error).
I solved it with windows="D", which requires less data to be loaded into memory at the same time.
@coroa : What do you think about making windows="D" default for the convert operations?
Originally posted by @euronion in https://github.com/PyPSA/atlite/pull/20#issuecomment-617057624

For heat_demand windows="D" will be problematic since you want daylight adjusted windows.
Also atlite v0.0.1 works fine with monthly windows, so we should fix the bug where we introduced it. It's more likely to be a problem of not letting go of caches early enough.
Can you make your setup reproducible, ie. what cutout are you using?

For heat_demand windows="D" will be problematic since you want daylight adjusted windows.

Can you elaborate why?

Also atlite v0.0.1 works fine with monthly windows, so we should fix the bug where we introduced it. It's more likely to be a problem of not letting go of caches early enough.
Can you make your setup reproducible, ie. what cutout are you using?

europe-2013-sarah as used in PyPSA-EUR, i.e.
> cutout
<Cutout europe-2013-sarah x=-12.00-41.80 y=33.00-64.80 time=2013-01-01-2013-12-31 prepared_features=['temperature', 'influx'] is_view=False>

tackled in #20

Can you elaborate why?

Sorry for the long delay, the answer is in my comment to #79 .


Conflicting typescript definition files

Importing the typescript types from https://github.com/Tonejs/TypeScript conflict with the tone.d.ts definition file that is created during the package build process.
The types in tone.d.ts are incorrect and cause compile errors. Can we remove these from the Tone repo and use https://github.com/Tonejs/TypeScript instead?

Thanks for letting me know. those definitions are very WIP, just put that in there to be able to test some things out. I didn't realize they would cause conflicts. For now, I would definitely defer to the Tonejs/TypeScript until i can get it automatically generated.
I can remove it from the build until the automatically generated ones are able to pass compilation


chore: add trace logs for each constituent API call in consolidated API

Description

Add OTLP trace log for each piece of data that the consolidated API fetches to measure the root cause of any latency regarding the consolidated API.

PR fixes following issue(s)
Fixes #29836
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual testing in progress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Introduced telemetry enhancements for better tracking of user interactions and API calls.

Refactor

Improved error handling and tracing logic within the application.

Documentation

Updated internal documentation to reflect new telemetry constants and methods.

Closing this because this PR has became too old causing many merge conflicts. It is easier to raise new one.


netutil: use "context" and ctx-ize TCP addr resolution

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8bad78c). Click here to learn what that means.
The diff coverage is 5.55%.

@@            Coverage Diff            @@
##             master    #7799   +/-   ##
=========================================
  Coverage          ?   75.79%
=========================================
  Files             ?      331
  Lines             ?    26122
  Branches          ?        0
=========================================
  Hits              ?    19799
  Misses            ?     4892
  Partials          ?     1431

Impacted Files
Coverage Δ

pkg/netutil/netutil.go
64.7% <5.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bad78c...85e87e8. Read the comment docs.

does this fix any known issue? or it is just an improvement?
lgtm.

Just an improvement; was looking over the netutil code earlier this morning and noticed that the network path can take a ctx as of 1.8. The "context" import is part of the ongoing 1.8-ization, though.

ok. thanks for the explanation.


[mempool] rebroadcast unACK'ed txn broadcasts

Motivation
Originally, mempool relied on TCP for reliable broadcast delivery/rebroadcasting dropped broadcasts. However, experiments showed that it is possible that some mempool broadcasts get dropped within the node (e.g. due to mempool libra-channel overflow), so we cannot rely on TCP to rebroadcast those internally-dropped messages.
This PR addresses this reliability-related gap in mempool's broadcast strategy by adding active checks for unACK'ed broadcasts and rebroadcasting them if a broadcast does not receive an ACK back for a configurable amount of time.
Supplementary changes

made some simplifications to the mempool broadcasting strategy for improved debuggability: now ensure that there is no timeline range overlap b/w broadcasted batches, and we rebroadcast entire batches, not parts of batches. This batch consistency is simpler to maintain and easier to debug.
some refactoring of peer manager for better code organization/readability

Test Plan
New/updated rebroadcasting tests, existing tests
From locally simulating internally dropped mempool broadcasts on libra-swarm, checked they eventually get rebroadcasted as expected

moving to #6331


serve executor process sometimes leaks

Occasionally the dev server executor doesn't get stopped correctly, leading to issues when it's restarted:
Running Vite Dev server: http://localhost:8080
  mode = development
Port 8080 is in use, trying another one...
Port 8081 is in use, trying another one...

It seems more common if the server did a full refresh, maybe something changed in the Vite3 update. The current workaround is to find and kill the node process manually.

This may be an Nx bug: https://github.com/nrwl/nx/issues/12708

This is unrelated to the linked Nx issue, as the Nx daemon doesn't use a port.

That makes sense, but the linked issue indicates that an executor child process is kept alive, not just the daemon. Is that intended behavior?
I will try to pinpoint what's happening tomorrow, so far I'm only certain that:

Usually when the serve executor is killed manually, only the daemon stays alive
Occasionally when the serve executor is killed, the daemon/executor/child processes stay alive

It could be related to Vite, but looks pretty similar to the linked issue.

Executors are responsible for handling cleanup of any child processes they spawn, this would be unrelated to Nx's side.

Oh, I misread the linked issue, I thought the executor process was alive after the user ctrl-c'd. This is probably a change in behavior between Vite2 and Vite3. Thanks for following up!

After major version bumps in Vite & Nx, I'm not noticing this problem anymore.


Moved test fixtures from v2 to v3

[#168701507]
Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

An explanation of the use cases your change solves

[ ] I have viewed signed and have submitted the Contributor License Agreement

[ ] I have made this pull request to the develop branch

[ ] I have added an integration test

Hey there @sreenivasmrpivot this self contained test actually belongs in dotnet-core-conf-cnb. I am going to reject this PR and will move this test to that cnb. Thanks!


Enhancements for feature macros

This PR does two things:

Create more granular macros for specific non-strict features
Enable strict mode and parent links by default

Details
More granular macros
This PR builds on the changes from PR #194. With PR #194, there are three specific ways in which non-strict mode diverges from RFC 8259:

Primitives may contain any character except whitespace and those with special meaning in JSON ({}[],:").
Strings may contain control characters (\x01 - \x1F) and invalid escape sequences
Primitives may be used as object keys

Some projects using jsmn might want some of these features, but not all. For example, a project might want to enable (1) to improve performance or shrink code size, but leave (3) disabled to help catch bugs.
For this purpose, this PR creates three new macros: JSMN_PERMISSIVE_PRIMITIVES for (1), JSMN_PERMISSIVE_STRINGS for (2), and JSMN_PRIMITIVE_KEYS for (3). These can be defined individually, or defining JSMN_NON_STRICT will cause all to be defined.
Enable strict mode and parent links by default
With this PR, strict RFC 8259 compliance and parent links become the default behavior. New macros JSMN_LOW_MEMORY and JSMN_NON_STRICT disable these behaviors.
JSMN_PARENT_LINKS still exists, but is defined by default unless JSMN_LOW_MEMORY is defined.
JSMN_NON_STRICT replaces JSMN_STRICT. When defined, all non-strict features are enabled.

Apologize for the history rewriting. Rebased onto the latest commits from PR #194.


Replace deprecated spin_until_future_complete

Replace deprecated spin_until_future_complete with spin_until_complete
Signed-off-by: Hubert Liberacki<EMAIL_ADDRESS>

Due to RCLCPP API change https://github.com/ros2/rclcpp/pull/1874. Has to be together with all altered repos

New CI run.
Changed rqt_configure to use correct repo.

Linux
Linux-aarch64
Windows

https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.

This PR is not required anymore due to changes in #126.


embrace the new API for the nightly build

:palm_tree: :palm_tree: :palm_tree:

Sorry, I can't easily accept contributions for the time being - this repository is being published as part of an in-progress university dissertation. Once the dissertation is over (May 2015) I'll be accepting contributions. Sorry for the inconvenience.

Cool, good luck!

Thanks :)


BZ#1440966 correctly handle action errors

https://bugzilla.redhat.com/show_bug.cgi?id=1440966
https://www.pivotaltracker.com/story/show/143492819
This work adds ActionNotificationsFactory for handling action responses. Action responses are always returned as a 200 (except in the case of a malformed url, or a validation error) with a staus and results array, this  factory iterates and displays those results with the correct eventnotification type
In the event ActionNotifications.add( is only passed the response object, only server feedback will be displayed
The followup to this work be to ensure (pre 🐝 :zzz:) that all action notifications are correctly displayed.
No new visuals to see here, but....

No UX review needed.


Support configuring DeleteInactiveTopic setting in namespace policy

Motivation
We should support configuring the DeleteInactiveTopic setting in namespace policy.

mark


Using decorator doesn't count as usage by eslint

Have the following code:
import autobind from 'autobind-decorator';

class TextareaAutosize {
  ...

  @autobind
  _onChange(e) { ... }
}

which results into:
   7:7   error    autobind is defined but never used                                                no-unused-vars

+1

Related: Using in decorator's parameters doesn't count as usage either
import DataManager from 'DataManager'
@inject(DataManager)

This is currently the biggest blocker for using decorators. Would love to see this fixed!

+1

+1

+1

There is also no-shadow hint for such situation with decorator
function blabla() {}

@blabla(() => 1)
export class Test {
}

gives
Test is already declared i the upper scope. (no-shadow)

Just ran into this as well.

:+1:

I guess you can contribute: https://github.com/alexkuz/eslint-plugin-decorator

I think it should be fixed by "fixing" estraverse to visit decorator AST
nodes so escope can find identifiers within.
On Sat, May 16, 2015, 16:35 Dan Abramov<EMAIL_ADDRESS>wrote:

I guess you can contribute:
https://github.com/alexkuz/eslint-plugin-decorator
—
Reply to this email directly or view it on GitHub
https://github.com/babel/babel-eslint/issues/72#issuecomment-102613528.

Can work on this - I guess I'l be using the examples from https://github.com/wycats/javascript-decorators for tests?

Did a PR: #105 (although failing on travis) - can someone else test to see if it fixes the issue for them? I tested locally and it's good.

Should be fixed in 3.1.6!

Thank you!
On Thu, May 21, 2015, 04:12 Henry Zhu<EMAIL_ADDRESS>wrote:

Should be fixed in 3.1.6!
—
Reply to this email directly or view it on GitHub
https://github.com/babel/babel-eslint/issues/72#issuecomment-104068509.

@hzoo You are awesome. Thank you so much.

Thanks @hzoo !

This feature apparently was broken sometime between releases v3.1.25 and v3.1.28, and still doesn't work as of v4.0.5.

Nothing was changed related to decorators in the last few releases - most likely an issue with babel. I would either wait for the next release or pin your babel version (or actually maybe we should pin the babel version?).

You were right about it being an issue in babel, it seems; as noted in https://github.com/babel/babel/issues/2098 (and other issues that it is a duplicate of), some bug crept into babel, making decorators not working properly. After preventing the issue (by not using parens in decorators), babel-eslint once again recognizes uses within decorators as uses of variables.

Still not working + 1
  @service({foo:'bar'}})
  async myFunc() {
    //balabala
  }

Can you make a new issue, and post with your config, and eslint, babel-eslint, babel version? Thanks

Sorry, that's a typo. It's working perfectly.
On Wed, Sep 16, 2015 at 7:29 PM, Henry Zhu<EMAIL_ADDRESS>wrote:

Can you make a new issue, and post with your config, and eslint,
babel-eslint, babel version? Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/babel/babel-eslint/issues/72#issuecomment-140713045.

still not working
eslint -v
3.10.2

Hi,
I'm running into the exact same symptoms on a version of eslint that should have this fix (4.4.1). I'm using mobx with mobx-react and trying to use the @observer decorators. E.g., if I run the linter on this class:
import React from 'react'

import {observer} from 'mobx-react'

export default @observer class Test extends React.Component {
  render () {
    return (

hello

    )
  }
}

I get
  3:9  error  'observer' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

This is my .eslintrc:
{
  "parser": "babel-eslint",
  "plugins": ["react"],
  "extends": ["standard", "standard-jsx", "plugin:react/recommended"],
  "rules": {
    "comma-dangle": ["off", "always-multiline"],
  },
  "env": {
    "browser": true,
  },
}

And this is my .babelrc in case that's relevant:
{
  "presets": ["es2015", "stage-0", "react"],
  "plugins": ["transform-decorators-legacy"]
}

Any ideas? This actually seems to work fine, but the @observable stuff trips up eslint.

So if anyone else runs into the above: I had babel-eslint configured as the parser, but did not actually have the module installed. I don't know why I was getting this error instead of something more sane, but clearly that's an eslint issue an not a babel-eslint one. Sorry for the noise. Hopefully my post can help others.

Ran into this issue using version
[
"babel-eslint": "8.2.2",
](url)
upgraded to

"babel-eslint": "8.2.3",

Ran a "scorched earth install" and it did the trick.


non ascii characters on stdin in cooked mode are not rendered correctly

A brief description

non ascii characters on stdin in cooked mode are not rendered correctly

Expected results

Actual results (with terminal output if applicable)

Your Windows build number

pb exists at least on 14393.51 and 14905.1000

Steps / commands required to reproduce the error

launch hd
press é, press enter, press Ctrl-D 2 times.

Note: fixed in 14946

Thanks for the discussion.
Closing this issue since:

This issue is very old and has likely been fixed in recent Win10 builds
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


F* crashes on missing universe annotation

module Hacl.Bla

open FStar.Buffer
module L = FStar.List.Tot

unfold let l : list Int8.t  = [0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y]

unfold let p1 (#a:Type) (init:list a) : GTot Type0 =
  normalize (0 < L.length (init))

let test (u:unit) : Tot unit =
  assert(p1 l)

crashes with
Unexpected error
Failure("Universe variable not found")

With
unfold let p1 (#a:Type0) (init:list a) : GTot Type0 =
  normalize (0 < L.length (init))

it works just fine

Also putting the normalize outside of p1 makes it go through :
module L = FStar.List.Tot

unfold let l : list Int8.t  = [0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y; 0y]

unfold let p1 (#a:Type) (init:list a) : GTot Type0 =
  0 < L.length (init)

let test (u:unit) : Tot unit =
  assert(normalize(p1 l))

This works in master, closing the issue.


Fix fullscreen after maximize

Summary of the Pull Request
Fixes the sides disappearing when entering full screen mode when the window is maximized.
However, now, a Vista-style frame briefly appears when entering/exiting full screen.

References

PR Checklist

[x] Closes #3709
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[x] Requires documentation to be updated (no)
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
When the non-client island window is maximized and has the WS_OVERLAPPEDWINDOW style, SetWindowPos is "lying": the position ends up being offset compared to the one we gave it (found by debugging). So I changed it to use WS_POPUP like the client island window was already doing. But now it has the Vista frame that appears briefly when entering/exiting full screen like the client island window.

Validation Steps Performed

@greg904 Is there any way to not get that vista-style window frame to appear for a brief second, and fix this bug?
Overall, I'm happy that this works better, but that frame felt really jarring in my own testing :/

I don't know how to do it. Chromium's code https://github.com/chromium/chromium/blob/master/ui/views/win/fullscreen_handler.cc is pretty much the same as here and yet Chromium doesn't have the issue. I'm missing something somewhere.

I don't really have time now unfortunately so I would prefer that you submit your own PR.

@greg904 No problem. Thanks for the initial fix 😄


Why set CONFIG_LOCALVERSION to ""?

Hello again,
I would really like to set CONFIG_LOCALVERSION to something meaningful. But the meta-raspberrypi layer is making it really hard, because it's set inconveniently to ""  here:
https://github.com/agherzan/meta-raspberrypi/blob/3ae288aa38e3a1609c6e861918a874416d3f0f13/recipes-kernel/linux/linux-raspberrypi.inc#L102
Can someone tell me if there is a really good reason to do this, or if we can maybe get rid of this line? It also voids the use of LINUX_VERSION_EXTENSION.
Greetings,
Michael

I can't remember why we did that but I think we should remove it now. I don't see any use of it anymore. And I agree, it renders LINUX_VERSION_EXTENSION useless. Do you mind pushing a PR?

@kraj @pbrkr Do you remmeber why we reset that config?

We did it after switching to linux-yocto include files which sets it to "-yocto-${LINUX_KERNEL_TYPE}" in do_kernel_configme
but ideally we should not be emptying out CONFIG_LOCALVERSION we should have a weak assignment to set LINUX_VERSION_EXTENSION
so something like below(untested) might be the way to go.
diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index ea7f778..6a7df4c 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -99,7 +99,7 @@ do_configure_prepend() {
CONF_SED_SCRIPT=""

# Localversion
-    kernel_configure_variable LOCALVERSION "\"\""
+    kernel_configure_variable LOCALVERSION "\"${LINUX_VERSION_EXTENSION}\""

if [ "${INITRAMFS_IMAGE_BUNDLE}" = "1" ]; then
kernel_configure_variable OVERLAY_FS y

You can see in meta/recipes-kernel/linux/linux-yocto.inc:58:
LINUX_VERSION_EXTENSION ??= "-yocto-${LINUX_KERNEL_TYPE}"

For completeness in meta/classes/kernel-yocto.bbclass:339, in do_kernel_configme(), it's where the value is acutally set:
echo "# Global settings from linux recipe" >> ${B}/.config
echo "CONFIG_LOCALVERSION="\"${LINUX_VERSION_EXTENSION}\" >> ${B}/.config

So I still think removing is the best solution. Nothing won by setting it manually.

@michaelbaisch does it append yocto-xxx string if its not set here ? if so then its wrong.

Not sure why this would be a problem? But I guess also setting
LINUX_VERSION_EXTENSION ?= ""

would help. Should I also add this in the pull request?

because we are not building linux-yocto, so it will not be correct to append default string from linux-yocto. but if thats not happening then i am fine to punt it.

@michaelbaisch I think this looks alright so I've kicked the builders.


Add taproot using bip86

See BIP86 - https://github.com/bitcoin/bips/blob/master/bip-0086.mediawiki

This document suggests a derivation scheme for HD wallets whose keys are involved in single key P2TR (BIP 341) outputs as the Taproot internal key.
...
To derive a public key from the root account, this BIP uses the same account-structure as defined in BIPs 44, 49, and 84, but with a different purpose value for the script type.

Note especially the test vectors

how can we help?

https://github.com/Anderson-Juhasc/bip86

Hi,
Any news/projects about that?
Thanks,

@iancoleman
I've created Android app with taproot support. I can help you with theory.
This app can derivate Bitcoin and Ethereum absolutely offline. Select "Restore seed" and "Seed to addresses"
BIP-39 Coin-flip for crypto

Hi
Do you have any updates or ETA?


Determine if currently opened workspace contains a Quarkus project

Case 1
For the wizard that helps add Quarkus extensions (launched with the "Quarkus: Add extensions to current project" command), the wizard tries to add Quarkus extensions even if the currently opened project is not a Quarkus project. It only checks if a pom.xml file exists under the currently opened workspace folder(s).
Case 2
In addition, when calling the "Quarkus: Debug current Quarkus project" VS Code command, it only checks if a pom.xml file exists under the current workspace folder.
In both cases, the code does not confirm that the pom.xml is a part of a Quarkus project. It would be great if it did, so that an error message like "Current maven project is not a Quarkus project" could appear in these cases.

Perhaps quarkus ls should provide this méthode isquarkusproject and vscode-quarkus client Will consume this new ls services?


Problems with the search and special characters like ‘#’

The URL encoding is likely breaking the search.
When searching for something that has the pound symbol ‘#’, the URL being rendered in the browsers URL bar does not work. If this URL gets copied or the page gets reloaded, a 400 error is presented. Removing the “%23” (the encoded variation of the pound symbol ‘#’) from the ‘value’ field in the URL results in a working page.
Everything search seems fine.  But searching for Title like so provides no result (the example here uses parentheses):
https://library.tamu.edu/discovery/discovery-context/time-of-resolve?field=title&value=Map Showing Proposed Roads Between New Road (Rear) of Administration Building (New) and Highway 6&direction=ASC&sort=title
Ideally, this should be handled at the Solr core, but we need to ensure that SAGE is not mangling the URL somewhere in the pipeline.

Created the following issues due to investigation.

#502
#497
#501
#500

The first two are more ore less directly related.
The second two are other issues that popped up in the process.


Add BufReader wrapper with performance enhancements

Do you like fast reads? Well then you’ll like this new thing probably.

Could you add some examples of how to sprinkle this magic on top of a struct.
If there's a huge binary file that has known 'record' sizes, and I can set the size of that buffer to the record size.

Could you add some examples of how to sprinkle this magic on top of a struct. If there's a huge binary file that has known 'record' sizes, and I can set the size of that buffer to the record size.

The API is nearly identical to std::io::BufReader, so you can just follow those examples. However, it would probably be a bad idea to set the buffer size to the size of a single record (unless the records are very large). If you are going to try tuning the buffer size, you’d typically want to do that based on the I/O and memory characteristics of the hardware you are planning to run on, not the content being buffered.

If you are going to try tuning the buffer size, you’d typically want to do that based on the I/O and memory characteristics of the hardware you are planning to run on, not the content being buffered.

Thank you, makes sense. For my platform, that's an exercise on its own!


Add Modifier options to reset a macro

Target=true used to be able to reset a macro.  Now need to use a mod combination.  This is the follow on from #235 and #231 Available options are

IsRightAltKeyDown(), IsLeftAltKeyDown(), IsAltKeyDown() : return 1 if the relevant key is held down.
IsRightControlKeyDown(), IsLeftControlKeyDown(), IsControlKeyDown() : return 1 if the relevant key is held down.
IsRightShiftKeyDown(), IsLeftShiftKeyDown(), IsShiftKeyDown() : return 1 if the relevant key is held down.
IsModifierKeyDown() : returns 1 if any alt, control or shift key is held down.
IsModifiedClick(“modifierType”) : returns 1 if the associated modifier is held down.
GetMouseButtonClicked() : returns the mouse button responsible for the hardware click.

Ok with the coded added and the menu option turned on, I can see the button pressed if I use the following macro:
#showtooltip
/click [button:2] SAM_Ret RightButton ; [button:3] SAM_Ret MiddleButton; [button:4] SAM_Ret Button4;[button:5] SAM_Ret Button5; SAM_Ret

https://cdn.discordapp.com/attachments/208019977717022721/278050538439049217/unknown.png


Require Node.js 12 and move to ESM

Require Node.js 12 and move to ESM

Why close?

I accidentally sent a duplicate or, one of this has already been accepted :)

Oh, LOL. Right.

if you have any other project i can help you out with converting to ESM then let me know
give me 1-4 options (repos) so i can choose the one i feel comfortable working in and i will send you a PR :)


Modify int.from_bytes occurrences

Modifying int.from_bytes occurrence to int_from_Scalar according to the new library version.
Actually the modified occurrence seems (at least to me) to be the only for whom the update is needed as other occurrences' handling is meant to be dealt differently.

Pull Request Test Coverage Report for Build 53

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.438%

Totals

Change from base Build 50:
0.0%

Covered Lines:
1039

Relevant Lines:
1124

💛  - Coveralls


Removed ff checks

Implements #11847
Acceptance
Be sure that neither the user nor the whole system has the feature flag static-maps.
The user should be able to export an image of the map both in editor pane and settings pane.

Acceptance 👍
Only found a little bug (unrelated to the FF), but I think we can deploy this before waiting for that fix:
https://github.com/CartoDB/cartodb/issues/12029
@xavijam: Ok to deploy?

deploy it! If only affects Firefox, let's go on and fix it later.

Going out like there is no tomorrow. I'll delete the FF after the deploy is complete.


User Guide install instructions do not produce working cft CLI.

Following install steps of user guide produces the following error when executing "cft --help":
/usr/bin/python: No module named cloud_foundation_toolkit
Found article saying install instructions from developer's guide to work:
https://serverfault.com/questions/1004646/cft-cloud-foundation-toolkit-error
With this work-around, I was able to move forward, but instructions need to be changed or need a fix to make instructions work as stated.

Following this workaround I was able to install the CLI but I still get some errors , one of them being:
AttributeError: module 'googlecloudsdk.core.credentials.store' has no attribute 'DevShellCredentialProvider'
I'm not sure what to enter on line 15 of dm/src/cloud_foundation_toolkit/init.py to make it work.
Any ideas?


block time ranges overlap

Bug Report
What did you do?
Found prom in a crashloop
What did you expect to see?
Not that
What did you see instead? Under which circumstances?
level=error ts=2018-06-22T07:54:13.895344831Z caller=main.go:597 err="Opening storage failed invalid block sequence: block time ranges overlap: [mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJ2B565RBWABAM80KJ9N2CW, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>, <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>\n[mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>, <ulid: 01CGJ96WDY85B5RXBNHGTZY9TH, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>\n[mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>, <ulid: 01CGJG7NSPZKGGVJ53W3SMXRDR, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>"
In addition server fails to start.
Environment

System information:
insert output of uname -srm here

Prometheus version:

2.3.1

This was the contents of the data directory when startup failed
01C72NDRM6B723ZRR8AQ4B5BTQ.tmp  01CFS0RBXQWXGTZ6ZM2SFMG6Y3.tmp
01C826QH3WCJT8EY4YBTXRYRKH.tmp  01CFS15TYJCWEV5EB50W6XJXQF.tmp
01C8CGADR4KF4CY4AH5NXNJXXA.tmp  01CFS1GD279M9J1KTE31WYQAR4.tmp
01CBWY56CGETRSZXBXAGY5K4S5.tmp  01CFT8BC8ME6Y7FE8DNE5X5WA5.tmp
01CE4TPXT9GD07NXHVKYJFZB2P      01CFY3RJWQMFCPZE00M0XXS32S.tmp
01CEAM7WDFKKGZ8A552GW6SD96      01CFY41BXSYNENZ5FFZDHMTN0B.tmp
01CEGDSEEZKWGAS7GKZ87G56S4      01CFYS9GNWPM6JG29W3690CH4N
01CEP6XG3Q7D4V5V8JG9MKR4K1.tmp  01CFZCYYCYFRKWRZ1TSBGC859Q.tmp
01CEP7K9K7AMHHV6Y0KVS533FS      01CFZTPCW4YMKPHA4XGPQN0C2T.tmp
01CEW0MNCAZWJN56H3HXE9G13A      01CG13WRC8GSEBW3ZF6BTWZ07W.tmp
01CF1T3PM77G0K38K7SVZ4Y1HG      01CG1ARFN195RN7KCR3M7M3XPC.tmp
01CF39ERN488YKJY1WEG6Q53YZ.tmp  01CG1RFY5S85KZZRQ2AX9H9C85.tmp
01CF62Q6W7GX71ZBG403FRC4MA.tmp  01CG267CN4EQD5S5DE48NE3HVE.tmp
01CF7KMT8CCRE6KHW6JDXXTX8T      01CG2KYV5TB2AT880QDPE6MWV3.tmp
01CF8N3XXP1T97XQ2H0GSN4KJH.tmp  01CG38YSHRVAZR475F7WYSH20S.tmp
01CF8W74A3MZVQ22ABEKY054X3.tmp  01CG4JWA9GGF8KPAXJF9TSY1FZ.tmp
01CFBEPJT5AQ65NCR8D553QB6A.tmp  01CG4K3YPHE9ZB49V8NEZK9Y9E
01CFDD1KK7VK73KMWVWBSHV2WM      01CGABSX821EG9SCZ5CFW47CSK
01CFENK94CMGGPEPD24P90QY45.tmp  01CGAZWEWPSXPZZ09VT1M8T379.tmp
01CFJH5WZACQEGVWG8ENGP3ASW.tmp  01CGC8YHCWT8A046E3EJPBZ8SC.tmp
01CFJYPSWBQF4JANXSRXSH35M4.tmp  01CGCPNZXHWPQMAC38KJ6PS343.tmp
01CFK5JH46K0MGG1X81E1P4P9N.tmp  01CGDJ4WZTXBJX61JKS7RPMRD6.tmp
01CFK6KEXVKC3Q78THSQ1M2BT6      01CGG57DNT3YXWFGZHWQMDAM09.tmp
01CFN3Q2A5YRNPVVPT6QYTVAZT      01CGG68PZRVWYJTWP2RHTT3P1S.tmp
01CFQ1AD8EEYT1S7V60G1J6B6F      01CGG7HYX5A8T55PQBNS21ZMMW
01CFQ81X3YWTN808RM91XJYQZJ.tmp  01CGJ2B565RBWABAM80KJ9N2CW
01CFQEX2756BT4RSYSFHWHRNBV.tmp  01CGJ2X7FJKVTVBE30ZK3S4TYA
01CFQF26WESA2CX9SRP74KW4R3.tmp  01CGJ96WDY85B5RXBNHGTZY9TH
01CFRYZ506VVXYF5DB8SWS06DQ.tmp  01CGJG7NSPZKGGVJ53W3SMXRDR
01CFRZ5H56VBK5BS7FRFTT9CN7.tmp  01CGJPYAXWDWP3CAGV0HVHVDXA
01CFRZHF6C213PD4YXAHPTBSVJ      01CGJQDTK2PE8ZCTK5XN2FDMEZ
01CFRZQQM4RPNWD27X5RGTNW4W.tmp  lock
01CFS02NT52ZAPV96BD103W174.tmp  wal
01CFS081ADFKRRFQV5BBPJ9MED.tmp

I killed off the 01CGJQDTK2PE8ZCTK5XN2FDMEZ directory, I think things are starting now.
Are all the .tmp dirs wasted disk?

I've hit startup failure on this, and on missing metadata json files (which I think may have happened after running out of disk space at one time).
Would it make more sense to skip broken data shards rather than bailing?

Can you share the logs of the first failure?

Would it make more sense to skip broken data shards rather than bailing?

Continuing to work with a broken database seems unwise to me.

This sounds like https://github.com/prometheus/tsdb/issues/347

@brian-brazil can the .tmp files be cleaned at startup?

I'm not sure it's wise to delete information useful to debug issues like this.

@brian-brazil I meant more generally.

It is safe for you to delete these files while Prometheus is shutdown.

@brian-brazil prometheus/tsdb#347 is different and it will not cause overlapping blocks.
I think this one is  similar to https://github.com/prometheus/prometheus/issues/4200
The fix is already merged, but @tcolgate did you try to delete any timeseries at any point before the crash?
I think this one happened at failed compaction - a new 6h block was created as a result of a compaction , but it failed somewhere in the middle leaving the original 2h block behind  so at next startup these 2 overlapped.
@tcolgate .tmp are created during compaction and when the compaction is complete the old block will be deleted and the .tmp will be renamed by removing the .tmp extension.  In theory these are safe to delete as the original block will not be deleted at failure.

@krasi-georgiev we've not deleted any TS for a while, though I did have to delete a shard a while back that had lost the metadata file (I think failed to write during a situation with a full disk).
We've also have quite a very OOM's during compaction.

it seems you are hitting https://github.com/prometheus/prometheus/issues/4108 which has exactly the same behaviour as what you have described.
did you try to lower the storage.tsdb.max-block-duration?
as per your own comment in https://github.com/prometheus/prometheus/issues/4110#issuecomment-397605044
I think when the compaction runs it expands all series from all compacted blocks in RAM and than writes a new merged block so lowering the storage.tsdb.max-block-duration should in theory limit the compaction to smaller block sizes.

@krasi-georgiev I need to understand if that can be changed on a pre-existing tsdb. However, since the nil dedupe bug was fixed, our compactions have been completing without problems (though that is only a couple of days ago)

just double checked and I  don't see any problem on reducing the storage.tsdb.max-block-duration on an existing db.
The logic is that at all blocks outside the storage.tsdb.max-block-duration won't be touched at compaction

We've also have quite a very OOM's during compaction.

did I misunderstand that you are still seeing  OOM during compaction?

The block size settings should not be changed, those flags are only there for load testing.

@brian-brazil would you also note why not and an alternative to help @tcolgate's issue?
the only downside I see is that reducing the storage.tsdb.max-block-duration would leave more smaller blocks which will result in longer query times.

That's just what they're for, and no user should ever have a need to adjust them. Changing them is likely to only cause more problems, and frustrate debugging.

I also note that changing that setting would get us no closer to solving the actual issue. Let's debug the problem rather than changing random unrelated settings.

@tcolgate can confirm, but I think the problem is identical to #4108  - oom-ing at compaction due to unsuficient RAM to complete the compaction for the large blocks

Crashing shouldn't break the tsdb though, we should recover gracefully.

I think I discussed this with Fabian or Goutham and decided to leave any recovery decisions out of tsdb and put them in the tsdb scan cmd.

I guess Prometheus can use the new tsdb.Scan method when it fails to open the DB and prompt the user for some recovery decisions - Delete overlapping blocks etc.

A crash at any point shouldn't put us into a situation that requires manual action. Only bugs and data corruption should get us into such a state.

@tcolgate Could you give us the logs from the prometheus until the point of it errors with overlapping blocks?

did I misunderstand that you are still seeing OOM during compaction?
We are not seeing OOMs during compaction under 2.3.1, (this isn't because compaction is taking less ram, but because our OOMs were largely due to other issues, compaction memory usage is still too high, but that is being dealt with elsewhere).

The logs are not terribly exciting, except for highlight a few exits and OOMs prior to the crash. (We had an issue with our sidecar that was causing more frequest relstart than it should have,  The OOMs in this case were caused by a runaway exported (stackdriver-exporter exposing LB latencies), that decide to add an extra 500k timeseries.
log.gz

These logs show that the overlap was caused exactly by the OOMing
2018/06/22 03:11:06 Unsolicited response received on idle HTTP channel starting with "\x00\x00\x00\x04\x00\x00\x00\x00\x00"; err=<nil>
level=info ts=2018-06-22T03:13:41.711884064Z caller=compact.go:347 component=tsdb msg="compact blocks" count=3 mint=1529604000000 maxt=1529625600000 ulid=01CGJQDTK2PE8ZCTK5XN2FDMEZ sources="[01CGJ2B565RBWABAM80KJ9N2CW 01CGJ96WDY85B5RXBNHGTZY9TH 01CGJG7NSPZKGGVJ53W3SMXRDR]"
Container exitted: error = "", exitcode = 137
Container died due to OOM

since it didn't complete it created overlapping blocks which was caight at the next start up.
level=error ts=2018-06-22T03:14:10.823993497Z caller=main.go:597 err="Opening storage failed invalid block sequence: block time ranges overlap: [mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJ2B565RBWABAM80KJ9N2CW, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>, <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>\n[mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>, <ulid: 01CGJ96WDY85B5RXBNHGTZY9TH, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>\n[mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s, blocks: 2]: <ulid: 01CGJQDTK2PE8ZCTK5XN2FDMEZ, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 6h0m0s>, <ulid: 01CGJG7NSPZKGGVJ53W3SMXRDR, mint:<PHONE_NUMBER>000, maxt:<PHONE_NUMBER>000, range: 2h0m0s>"
level=info ts=2018-06-22T03:14:10.824081682Z caller=main.go:599 msg="See you next time!"

we need to think how would this be best handled, but in the meanwhile you can use the tsdb scan tool to delete the overlapping blocks.
Still WIP but if you need it now  let me know and I will compile and attach to a comment.

I infered the block from the message and just blatted it by hand.
From my PoV, these things should be taken care of at startup if at all possible. We're running all our prom instance in kube so prompting isn't really a viable option. We could run TSDB fixups at startup every time (assuming there's a -y or -f).
In general we prise availability over long term retention (I believe prom does generally), so I'd much rather prom came up and lost some data than staid down (and left us without monitoring for a weekend, as has happened more than 3 times since moving to 2.0).

The tsdb tool is only as a POC , but at some point we can add it to Prom itself and  automate it, maybe add some explicit flag at startup  how to handle such cases - auto delete conflicts, prompt before deleting etc.
We are still discussing and considering different options and your input would be useful.

We should never automatically throw away user data, we should avoid getting into that situation in the first place.

@brian-brazil you could ignore bad data at start though. By not starting you are defacto ignoring the data I most care about, the data you could be collecting. Clearly there is a fine line to tread. Certainly we shouldn't be getting into these situations in the first place. But refusing to start (thus not collecting data), is just as bad as ignoring data.
Running two prom instances resulted in a pretty confusing query situation for users in these situations (especially if we round robin queries to different proms). I did consider thanos, but the instability of the on disk format around 2.[12] put me off. Having two things shifting the on-disk data around feels wrong.

Should this be fixed via https://github.com/prometheus/tsdb/pull/354?

That's the presumption, so closing for now.


Update and Add Diffusion Components

Summary: This diff brings in a number of updates as well as new features built since the last release to diffsuion_labs
Reviewed By: abhinavarora
Differential Revision: D50285167

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1fd96dc) 74.01% compared to head (816710e) 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   74.01%   74.32%   +0.31%
==========================================
  Files         207      210       +3
  Lines       14203    14383     +180
==========================================
+ Hits        10512    10690     +178
- Misses       3691     3693       +2

Files
Coverage Δ

tests/diffusion_labs/test_adapter_cfguidance.py
100.00% <100.00%> (ø)

tests/diffusion_labs/test_dalle2.py
100.00% <100.00%> (ø)

tests/diffusion_labs/test_predictors.py
100.00% <100.00%> (ø)

tests/diffusion_labs/test_v_transform.py
100.00% <100.00%> (ø)

...usion_labs/modules/losses/diffusion_hybrid_loss.py
100.00% <100.00%> (ø)

...ltimodal/diffusion_labs/modules/losses/vlb_loss.py
97.36% <100.00%> (+0.07%)
:arrow_up:

...modal/diffusion_labs/predictors/noise_predictor.py
94.44% <100.00%> (-1.39%)
:arrow_down:

torchmultimodal/diffusion_labs/samplers/ddim.py
76.92% <100.00%> (+0.45%)
:arrow_up:

torchmultimodal/diffusion_labs/samplers/ddpm.py
90.27% <100.00%> (+0.13%)
:arrow_up:

...ultimodal/diffusion_labs/transforms/v_transform.py
100.00% <100.00%> (ø)

... and 7 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create label.yml

Trying this out

I haven't used it but it looks useful!

seems to not be working and the docs are confusing me.
closing this for now to avoid the distraction.


Updates to make Pep8 compatible.

There are some problems with the imports.

Coverage decreased (-0.06%) to 76.954% when pulling 9692b0129336e4e78ac0431474a60e15c7ac6605 on ref/pep8 into 85971d771b74e2f826c0291bf0cb93eed06f42cd on dev.

A few questions @rowanc1 -

ok to get rid of formType?
ok to remove unused vmath for now (everything except vector is incomplete/broken/bad dependencies)?

Coverage increased (+2.4%) to 79.437% when pulling 7286021b67eb7b376066884496f62f9646599b74 on ref/pep8 into 85971d771b74e2f826c0291bf0cb93eed06f42cd on dev.

Coverage increased (+2.5%) to 79.487% when pulling 21f0dd4647781afffc44bee52852435bb7ac04c4 on ref/pep8 into 85971d771b74e2f826c0291bf0cb93eed06f42cd on dev.

Coverage increased (+2.5%) to 79.487% when pulling 2b88b2e0ec32ab66636ca1e3e072aa4f980bd7d8 on ref/pep8 into 85971d771b74e2f826c0291bf0cb93eed06f42cd on dev.

Yes, remove these things!

Coverage increased (+9.7%) to 86.731% when pulling 90e3a19559e1742d47abee3e34fa474638152dd2 on ref/pep8 into 85971d771b74e2f826c0291bf0cb93eed06f42cd on dev.


Update ButtonMonitors only when detecting a keyboard event

Done in https://github.com/Sygmei/ObEngine/commit/db409718f859ca4a683447e8ae413d2a5f9028da


Possibility to use athena via CalledVia option - no glue api calls/ no s3 calls

In order to support the CalledVia option for athena, we need to introduce new flags that allow a native behavior to create/insert data into tables.
In order to do so we need to have additional flags:

native_drop: table is dropped via "drop" DML in athena, in case of iceberg we use the native s3 path dropping, as iceber tables are managed
~- use_information_schema: allow to fetch glue tables details via information schema, pretty much means merging what was done in https://github.com/dbt-athena/dbt-athena/pull/174 with 2 behaviours~
allow seeds without s3 upload -> https://github.com/dbt-athena/dbt-athena/pull/283, flag name to agree

Regarding the usage of information schema, after discussing with @brabste we agreed that we use of information schema is not necessary, as we can use glue apis - and we avoid still direct access to S3 data.

Mentioned in athena infra, closing.


This makes manually aligning strings easy

If I already manually am plopping newlines in my string, you probably can't help me much at this point.

I am using this for this https://github.com/Hoverbear/raft-rs/pull/108

I realized this actually breaks tests because we want this capability. If we want it to remain, should we provide a way to ignore this string?

You can add a #[rustfmt_skip] attribute to a function or other item, although not to individual strings. I think there is also an option to not reformat strings (if not, there should be). And we don't reformat raw strings (iirc).


Version 3

add command check-marathon
rename command deploy to deploy-marathon
rename main package deploytool to marathon_deploy
add CLI args: --user, --password,  --https-verify
add Travis CI with pylint & CHANGELOG.md

No need to keep this one since https://github.com/nicovillanueva/marathon-deploy/pull/3 was approved


Run tests against Node

The current test setup runs against a number of real browsers via BrowserStack, which is fantastic, but we currently don't test specifically against Node at all.
It would be good to explicitly test against Node, just to have explicit verification that SSR will continue to work.

The tests currently need a large refactoring so they are smarter about
which environment they are running in. We couldn't run the existing tests
in mode without resorting to some hacks solution like phantom or jsdom,
neither of which I will use.
If you're interested in taking on this work, you may want to check out the
tests for the history library which are much smarter about the environment
they are running in and skip certain tests when they aren't actually able
to run.
On Thu, Nov 12, 2015 at 12:59 PM Jimmy Jia<EMAIL_ADDRESS>wrote:

The current test setup runs against a number of real browsers via
BrowserStack, which is fantastic, but we currently don't test specifically
against Node at all.
It would be good to explicitly test against Node, just to have explicit
verification that SSR will continue to work.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/react-router/issues/2538.

I agree with you in principle - in practical terms though I think it makes the most sense to just start with a different entry point for Mocha and e.g. only run the server rendering test (and maybe a couple of others).

What I'm trying to say is I'd like to see a more comprehensive plan for refactoring our test suite than just a new entry point for node. If we split the test suite into two entry points, it will probably stay that way for a long, long time. Unless someone follows through and brings it all back together.

I agree with the feature sniffing approach in general - we should use it to e.g. support IE9 tests on this repo. However, I think there are two important caveats here.

Since we'd use Mocha directly for Node testing, we'd need a separate entrypoint anyway; there has to be a tests.node.js or equivalent, since tests.webpack.js would not be applicable.
There's a difference between the IE9/&c. case on history where the tests in this repo for things like <Link> are not unsupported in that sense; they're actually just irrelevant. The sense in which we skip tests for <Link> on Node is not the same sense in which we skip the HTML5 history tests on IE9.

@mjackson Does that work for you? I think it actively makes sense for Node v browser usage to be actual separate entry points, because the context of usage differs between the two environments.


Integrate testing (playwright) + documentation

Blocking:
https://github.com/dawnwages/wagtail-indymeet/issues/3
This issue must be done first. This may be a good place to ask Ed Rivas or Zan Anderle for their opinion on Django + Playwright.

or Andrew Knight or Debbie O'Brien

Doesn't have to be playwright

https://youtu.be/_tAhD-OCuN8

https://github.com/RachellCalhoun/blog-posts


Add curl command to pull karpenter cloudformation from remote repo

Issue #, if available:
Description of changes:
Currently, the cloudformation deploy expects the karpenter cf template to be local. This change will pull the template from the remote repository, without needing to clone the full project.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for this docs improvement!


Add iOS walkthrough for Tangram

Blocks https://github.com/mapzen/website/pull/1591

hey @karimnaaji if you could add alt text going forward, that'll make these a lot faster to update :)


[localization] Add better support for Chinese languages (fix #877)

This PR aims to add better support for Chinese languages in localization plugin. With this change the plugin can support more types of Android system Chinese Locales and has better support for mapbox-streets-v8's new name_zh_Hant Traditional Chinese labels.

@LukasPaczos Hi. I think your suggestion is reasonable and have made the changes you requested. Also rebased this PR to current master.


Add ansible linting to Jenkins

Fix ansible lint errors
Add ansible lint checking to Jenkins

Fixes #827

@joejulian I believe you need to rebase this onto master to get etcd stability fixes and e2e notifications messages.

Regarding args, I agree it should be consistent. It's already inconsistent throughout the entire project. Fixing that and adding that custom lint rule is outside the scope of this change but I'll create an issue.

I would prefer this be a "rebase and merge" to retain the individual commits. I think they're useful history.


[Bug]: Modded leaves don't drop anything

Minecraft Version
1.21
Mod Loader
NeoForge
Mod Loader Version
21.0.140
Mod Version
<IP_ADDRESS>
Modpack or other Mod
Mods used:
Just Enough Items
Wooden Shears
Biomes O' Plenty
Regions Unexplored
Describe the Issue
Basically the wooden shear doesn't act like the normal vanilla shear.
While using the wooden shear on modded leaves nothing it's dropped.
Logs
Not needed.
Do you use any performance-enhancing mods (e.g. OptiFine)?
No optimization mods we're used.

Thanks for your report! These twoo mods are not using the common tag "c:tools/shear" in their leaves loot tables. that should be used by all shears and loot tables that should be compatibile with other mods. I will open PRs for these mods when I have time :)

@dopa2077 I have opened PRs for the two mods:

https://github.com/Glitchfiend/BiomesOPlenty/pull/2244
https://github.com/UHQ-GAMES-MODS/RegionsUnexplored/pull/11

I leave with issue open until they are merged and released in a new mod version.

Biomes O Plenty has already merged and released the changes int the version 1.21-<IP_ADDRESS>

RegionsUnexplored had merged the changes for Fabric & NeoForge. I opened another PR for the Forge version of the mod: https://github.com/UHQ-GAMES-MODS/REGIONS_UNEXPLORED_FORGE/pull/177

RegionsUnexplored 1.21 v<IP_ADDRESS> released the changes for NeoForge and Fabric. The Forge PR is not merged yet, but this issue was related to NeoForge. Therefore this issue is fixed and closed.
@dopa2077 Thanks again for your report. If you find any other compatibility issues, feel free to open a new issue. :)

totally forgot to check forge PR's, my bad. Will include in the next patch


Convert NUnit 3 ID filter to V2

Fixes #29

@ChrisMaddock I literally forgot that this project was part of NUnit as I was jumping back and forth between nunit-legacy and TestCentric. Anyway, I merged it without review. Can you take a look and tell me whether you'd like leave it, back it out or make further forward changes?

@ChrisMaddock I noticed that this is still building as 3.7.0-dev-xxxx rather than 3.7.1. I'll do another PR just for that.

@ChrisMaddock If you aren't the person to decide about this, please let me know. I actually don't know who is these days and we can have a core-team discussion about it if necessary. See my comment on #27.

I can probably review it tonight, but I don't know who is responsible for this project (I have only followed this repo for a couple of months)

@mikkelbu That would help in any case. But of course the change is of no use without a release, so that's why I'd like to know who's responsible.

Hi @CharliePoole. I have no intention in being responsible for these projects I'm afraid, I lack the v2 knowledge to do so.
You'll remember this was something we discussed a while ago. I re-started the wider discussion on that here: https://github.com/orgs/nunit/teams/core-team/discussions/18

Hi @ChrisMaddock. Thanks for the clarification.
I do remember the discussion. I thought we ended up with the decision that all extensions, except for TeamCity, would be treated as part of the engine project. That's why I was bugging you about it.
Somewhere in the discussion you started, I hope you'll state what you do feel responsible for. For example, what about the other (non-V2) extensions?
I'll continue in that discussion.

As for this merged PR, since there is nobody currently responsible to ask me to back it out or to specify the rules of engagement for merges, I'm going to move ahead and leave it in. :smiley_cat:


OpenVPN not applying CSO settings in some server modes (with workaround)

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I'm configuring an OpenVPN Server (legacy settings) in Remote Access ( SSL/TLS + User Auth ) mode. I have clients successfully connecting to the server and receiving traffic. But whatever CSO configuration I create for the clients, it is ignored. I have a need to match certificate common names to fixed IP addresses. If looks as if the generated OpenVPN config file is missing a client-connect stanza.
To Reproduce
An OpenVPN Server is configured with these settings (some defaults omitted):

Description: server2
Server Mode: Remote Access ( SSL/TLS + User Auth )
Backend for authentication: Local Database
TLS Authentication: Enabled - Authentication only
Peer Certificate Authority: set
Peer Revocation List: None
Server Certificate: set
Strict User/CN Matching: no
IPv4 Tunnel Network: set to /27
IPv4 Local Network: set to /32
Inter-client communication: yes
Duplicate connections: no
Dynamic IP: yes
Topology: yes
Use common name: yes
Force CSO Login Matching: no

Clients are set up to be identified by the certificate common name (not the login user), and the objective is to assign each CN a pre-determined IP address (each client will be BGP router of its dedicated AS),
For each CN, a CSO entry is configured, e.g.:

Server: server2
Common name: rou-fw-01
IPv4 Tunnel Network: /32

Describe alternatives you considered
From the source code it seems that /usr/local/opnsense/scripts/openvpn/ovpn_event.py is in charge of creating the necessary CSO configuration snippet during connection. But no configuration stanza in /var/etc/openvpn/server2.conf directs openvpn into running this script any earlier than upon client disconnection: i.e. the configuration contains a client-disconnect stanza but no client-connect stanza, as I would have naively expected.
Wondering if adding a client-connect stanza would fix the problem, I added the line client-connect "/usr/local/opnsense/scripts/openvpn/ovpn_event.py '2'" into the "Advanced" custom configuration of my server, and I can confirm that the CSO settings have become effective immediately.
Some of the code I suspect is buggy seems to be in /etc/inc/plugins.inc.d/openvpn.inc:
https://github.com/opnsense/core/blob/70d6dc03b8ef2f6177bf071b9bec5015a593c0cf/src/etc/inc/plugins.inc.d/openvpn.inc#L553-L575
I can see why this code is not generating a client-connect stanza in my case. And I think there are other configurations where ovpn_event.py is expected to be called both at connection and disconnection time, but isn't.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 23.7.12-amd64
AMD Ryzen Threadripper 3970X 32-Core Processor

Related issues:

#6768 (probably very similar issue)
#5296 ("solution" was to evade the bug by changing configuration)
#2624 (hacked the same code)

Also note that things sometimes "start to work", e.g. after the client disconnects (under certain circumstances an equivalent file is generated under /var/etc/openvpn-csc, in other occasions this file seems to be temporarily generated in /tmp).

https://github.com/opnsense/core/blob/70d6dc03b8ef2f6177bf071b9bec5015a593c0cf/src/etc/inc/plugins.inc.d/openvpn.inc#L672
Is probably what you’re looking for, it’s unlikely cso’s don’t work at all, but the logs will tell you what the server did (auth sequence and cso matching). Usually these are other misconfigurations, such as non compatible netblock choices, which for us is out of community support scope. OpenVPN can be picky and doesn’t always communicate very clearly about non supported options in cso’s.

Thanks to your hint, I looked at ovpn_event.py once more. I have a theory why I observe a "fix" when manually adding a call to client-connect in my config. What we have here, is, likely, a concurrency bug, and I guess it was introduced when support for deferred authentication was added.
The script ovpn_event.py branches off into different code sections according to what script_type it is called for. For our types user-pass-verify and client-connect it will exec either user_pass_verify.php or client_connect.php, and both call openvpn_csc_conf_write() to create the temporary CSO file, so at first sight it feels right to skip the client-connect call when a call to user-pass-verify call is configured too.
But while ovpn_event.py execs into user_pass_verify.php synchronously for the client-connect type, it instead forks into background and immediately returns to OpenVPN signalling deferred authentication, and only then, in background, client_connect.php gets eventually exec'd, likely too late for OpenVPN to pick it up.

I don’t expect that, haven’t seen it either. If I’m not mistaken the (official) radius auth uses the same spot. When using authentication, you can’t know the full picture unit authenticated (networks maybe provisioned).

I don't have the testbench anymore, just the logs. There is a recurring pattern:
<37>1 2024-01-19T05:21:13+01:00 [..] TEST FILE '/var/etc/openvpn-csc/2/vpnclient.example.com' [0]
<37>1 2024-01-19T05:21:13+01:00 [..] TEST FILE '/var/etc/openvpn-csc/2/DEFAULT' [0]
<37>1 2024-01-19T05:21:13+01:00 [..] TEST FILE '/tmp/openvpn_cc_5cf7c3237dbe531a12cf56d86a994dee.tmp' [0]
<37>1 2024-01-19T05:21:13+01:00 [..] MULTI: problem deleting temporary file: /tmp/openvpn_cc_5680d8d0d87657e4403ecaae6b70959.tmp

OpenVPN is reporting that none of the CSC files exist when it is looking for them.
Another similar section:
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="7"] <IP_ADDRESS>:64289 VERIFY SCRIPT OK: depth=1, C=**, ST=****, L=****, O=****<EMAIL_ADDRESS>CN=****
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="8"] <IP_ADDRESS>:64289 VERIFY OK: depth=1, C=**, ST=****, L=****, O=****<EMAIL_ADDRESS>CN=****
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="9"] <IP_ADDRESS>:64289 VERIFY SCRIPT OK: depth=0, C=**, ST=****, L=****, O=****<EMAIL_ADDRESS>CN=****
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="10"] <IP_ADDRESS>:64289 VERIFY OK: depth=0, C=**, ST=****, L=****, O=****<EMAIL_ADDRESS>CN=****
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="11"] <IP_ADDRESS>:64289 peer info: IV_VER=2.6.8
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="12"] <IP_ADDRESS>:64289 peer info: IV_PLAT=freebsd
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="13"] <IP_ADDRESS>:64289 peer info: IV_TCPNL=1
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="14"] <IP_ADDRESS>:64289 peer info: IV_MTU=1600
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="15"] <IP_ADDRESS>:64289 peer info: IV_NCP=2
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="16"] <IP_ADDRESS>:64289 peer info: IV_CIPHERS=AES-256-GCM:AES-128-GCM:**A**A20-POLY1305
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="17"] <IP_ADDRESS>:64289 peer info: IV_PROTO=990
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="18"] <IP_ADDRESS>:64289 peer info: IV_LZO_STUB=1
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="19"] <IP_ADDRESS>:64289 peer info: IV_COMP_STUB=1
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="20"] <IP_ADDRESS>:64289 peer info: IV_COMP_STUBv2=1
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="21"] <IP_ADDRESS>:64289 TLS: Username/Password authentication deferred for username 'vpnuser'
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="22"] <IP_ADDRESS>:64289 TLS: move_session: dest=TM_ACTIVE src=TM_INITIAL reinit_src=1
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="23"] <IP_ADDRESS>:64289 TLS: tls_multi_process: initial untrusted session promoted to semi-trusted
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="24"] <IP_ADDRESS>:64289 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 2048 bits RSA, signature: RSA-SHA256, peer temporary key: 253 bits X25519
<29>1 2024-01-19T04:04:59+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="25"] <IP_ADDRESS>:64289 [****] Peer Connection Initiated with [AF_INET6]::ffff:****:64289 (via ::ffff:****%vtnet0)
<37>1 2024-01-19T04:05:00+01:00 vpn.example.com openvpn 54933 - [meta sequenceId="26"] Locate overwrite for 'vpnuser' using server '1' (vpnid: 1)
<37>1 2024-01-19T04:05:00+01:00 vpn.example.com openvpn 54933 - [meta sequenceId="27"] user 'vpnuser' authenticated using 'Local Database'
<29>1 2024-01-19T04:05:00+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="28"] ****/<IP_ADDRESS>:64289 MULTI_sva: pool returned IPv4=****, IPv6=(Not enabled)
<27>1 2024-01-19T04:05:01+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="29"] ****/<IP_ADDRESS>:64289 MULTI: problem deleting temporary file: /tmp/openvpn_cc_7f6b4b6a4048e39645da90e5a006de40.tmp
<29>1 2024-01-19T04:05:01+01:00 vpn.example.com openvpn_server1 79556 - [meta sequenceId="30"] ****/<IP_ADDRESS>:64289 MULTI: Learn: <IP_ADDRESS> -> ****/<IP_ADDRESS>:64289

I also observed that the directory /var/etc/openvpn-csc/2 usually remained empty (if files ever landed there, they were short-lived and I didn't see them). In one instance, though, I disabled user authentication on the server (going to just peer-to-peer) and then edited the CSO of client with CN vpnclient.example.com, which resulted in /var/etc/openvpn-csc/2/vpnclient.example.com being generated. This file survived when I switched user authentication back on again. I basically had one client that worked with the given static IP, while all others continued to pick random IPs from the pool.

When properly matched, the log should contain:
https://github.com/opnsense/core/blob/98878a9eb90c1150b232bfbc7e9a012a3e3462a0/src/opnsense/scripts/openvpn/user_pass_verify.php#L137

Exactly. I get such lines when I change the server mode. That's the bug (see title).

My point as well, these lines do not depend on synchronicity, which point to some configuration issue… (mismatch between common name and username being the most common)


Example code for Color Wheel with Saturation and Lightness?

Hello,
Is there any example about the Color wheel with Saturation and Lightness? I see only examples for the color picker with fields. Thanks!

Not sure what you mean by examples. There are 2 booleans exposed - enable enableLightness and enableSaturation
They should show additional sliders in the modal. The Dialog itself also has these properties exposed
https://pub.dev/documentation/color_picker_field/latest/color_picker_field/ColorPickerDialog-class.html


 Is it possible to stop the commit if there's an issue?

Don't think is needed make things more slower and we already have CI in place to prevent this.

Probably it can be a personal preference but I'm not 100% sure of use it on my own development process. We can add it as optional if you like.

It was just a thought so we don't forget to run CI locally, I know sometimes I do. Do you have a personal process in place to help with this @mitogh ?

Ok…well yes I know that sometimes happen to me too but it can become more ugly if we force to run CI before every commit, I think the way we can avoid that is just to prevent directly write on master and develop and use PR to merge code on those branches so in that way we force to run the CI before moving something to those branches.  We can work to send a notification instead I think it would be more friendly.

I think we should close this, since this is more like a personal preference.

ok


Fixed current user func.

Description
The context object is now a dict. This pull request fixes an exception when using the auth.current_user field.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

The strawberry django context is actually a dataclass: https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/django/context.py#L11
What code are you using that you are getting this issue?

Sorry, I guess this is for Channels only.
https://github.com/strawberry-graphql/strawberry/releases/tag/0.180.0


why you use patch_config_as_nothrow function to convert ?

Our config system is based on data class. The default behavior of referencing missing attribute is throwing AttributeError. This makes adding new config option painful because you need to wrap the new option in a try-catch block to provide a default value of the newly added option. After patching the config, now referencing a missing attribute returns None which can be chained as None or default_value. This is far more elegent compared with the original behevior.


[sil-combine] When simplifying convert functions, base whether or not…

… an apply has nothrow on the actual function_ref.
Previously, we based it off of whether or not the original apply had a nothrow
bit. This is incorrect in the case where we added an error result to a function
without an error result. In such a case, we need to /not/ put on the nothrow
bit. This commit generalizes this idea slightly by assuming that if we are asked
to perform this transformation we should just match what the underlying
function_ref (i.e. setting nothrow if the underlying function type has an error
result and not setting nothrow if the underlying function type does not have an
error result).
rdar://47828439

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test linux platform


Angular 6 is not compatible with  v0.35.3

What Angular MDC version are you using?
0.35.3
What browser(s) is this bug affecting?
angular cli
What OS are you using?
Mac OS High Sierra
What are the steps to reproduce the bug?
node 8 and npm 5
Instal angular cli v6
ng new dummy
npm i @angular-mdc/web
What is the expected behavior?
compiled successfully
What is the actual behavior?
Failed to compile
Any other information you believe would be useful?
using npm view @angular-mdc/web i saw that the peer dependency on npm registry is still on 5+... might help

@edjeezy Angular v6 compatible build is due today 😄

Later than expected today, but build is underway. Fixing #987 took a bit to get just right.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/69847

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/70133

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/79931


Increasing rate limits for hydrateUtxos()

:tada: This PR is included in version 1.18.5 :tada:
Your semantic-release bot :package::rocket:


Description not rendered for radio input

Thank you so much for working on this project, it's truly awesome and saves me a lot of time. Keep up the good work.
I can't get the description from the templateOptions on radio input to show up. Works fine on all other input types though. Here's an example: http://jsbin.com/tayucopahu/2/edit?js,output (I just extended one of your examples).
I guess I could make a PR but someone has to point me in the right direction as I'm not that js savvy :). Here's a screenshot of a checkbox- and radio list that both have a description in their templateOptions:

Hmm, after digging a bit I see that descriptions are actively not rendered for checkbox and radio input:
if (angular.isDefined(options.templateOptions.description) &&
        options.type !== 'radio' && options.type !== 'checkbox') {
        var el = document.createElement('div');
        el.appendChild(angular.element(template)[0]);
        var modelEls = angular.element(el.querySelectorAll('[ng-model]'));
        if (modelEls) {
          el.appendChild(angular.element(
            '
' +
            '{{to.description}}' +
            '
'
          )[0]);
...

Copied from description.js
Why are descriptions omitted on checkbox and radio inputs?

You know what, I think there shouldn't be a problem to allow them for all fields. I'll push an update soon.

Your example now works with 4.0.9 :-)

Truly epic Kent. I get a fix on the issue the same day it is reported. Even though it was not a complicated issue, I'm still amazed about the speedy fix. I'm happily upgrading to 4.0.9!

:+1: :-)


0 Y axis line

Hi, Thanks for the plugin, helped me a lot. Not so much an issue, but a question:
Is it possible to get the 0 axis line to show, I have a chart similar to your example "At least one y-axis with both -ve and +ve values: extended chart" and like your example there's no 0 baseline.  I've tried playing with the ticks but not having much luck.
Any advice would be great, thanks.

Hi, glad you find it useful :-)
The ticks, and hence the lines, are handled by the "createArrayFromRange" function - which gets the min & max tick values, and number of ticks as arguments. This is what handles the intervals between each tick on the y axes. Unless there is some other highcharts option, then this is what you would need to rewrite to always have a zero in one of those ticks. Since you are referring to very specific chart type, I've rewritten the function slightly to do what you ask, albeit in a rather rough manner (the intervals are not equal now, so you'll need to tweak it further): http://plnkr.co/edit/MGrmJ1sqxUq1z8CY7Nx2?p=preview Hopefully you get the idea and try and work around that maybe?

Thanks again! The chart looks good, I'll have a read through your updates a bit later.
If you have a donate/beer fund button, I'd happily contribute ;)

Thanks - I hope it helps you out. Feel free to extend if you devise a generic way for that.
Cheers! :-)


How to solve the "boost.python.argumenterror" problem?

python demo.py --debug --cpu
0.042 Traceback (most recent call last):
File "demo.py", line 219, in
main()
File "demo.py", line 116, in main
right=facebox[2], bottom=facebox[3])
Boost.Python.ArgumentError: Python argument types in
rectangle.init(rectangle)
did not match C++ signature:
init(struct _object * __ptr64, long left, long top, long right, long bottom)
init(struct _object * __ptr64)
I tried to reload my boost but it dosn't work .can you help me ? I 'm so eager to paly with it .

I finally solve the problem by load another type of dlib


Tests for kallenbach divertor

In GitLab by @timothy-nunn on May 30, 2022, 14:16
For some rigorous UQ work, tests would be ideal to test Julia versions of this model.

Kallenbach model does not exist anymore


Is string formatting possible ?

Hi again,
is string formatting possible with the SDK?
Lets say we have such a string in weblate: app_greeting: "Hi {name}!"
Is it possible to format it like context.localizedValueOf('app_greeting', 'Robert'); which will replace the name with Robert ?

Hi.
Currently not. Planning too add in new version.

This would be a crucial feature. Looking forward to it. Thanks mate.

Wow mate! That was fast! Thanks, looking forward to trying this out! Does it work with multiple strings as well ?
Like,
Usage:
context.localizedValueOf('app_greeting', format: ['Robert', 'John']);
Result:
Hi Robert and John!

Yes. You can use multiple formatting.
Just set string as Hi {name1} and {name2}!

Just tried it and it works perfectly. Thanks mate!

I'm working on a blog post about your package. Do you have a mastodon or twitter account ?

Thanks!
No, I don't have those accounts

Ok, I'll just mention your git profile than. Thanks.


Chapter computational performance/multiple gpus

Job d2l-zh/PR-840/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-840/

Job d2l-zh/PR-840/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-840/

Job d2l-zh/PR-840/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-840/


fix: avoid false positives due to gathering diagnostics from different buffer

As I was trying out this plugin, I noticed that code actions kept being shown on lines even when actions weren't available:

I dug into this and it seems like the reason is because vim.lsp.diagnostic.get_line_diagnostics() without any arguments seems to get diagnostics across the entire workspace:

I opened this PR as a fix to this by including just the bufnr in the call in case it was on purpose to try and include diagnostics not just on that line. By just adding the buffer it'll include diagnostics across the whole buffer. If we wanted to tighten this more we could add the line number as well but I wanted to open this up for discussion.

Thanks for the report! This should be fixed in 34aa174 for 0.9.x and 0.10.x

Sounds good. Thanks for the plugin! @kosayoda


multi-selection is not consistent

What platform were you using when you found the bug?

React Flow / Svelte Flow version: "@xyflow/react": "^12.0.3",
Browser and version:
OS and version:

Live code example
https://codesandbox.io/s/7kn7kv?file=/App.js&utm_medium=sandpack
Describe the Bug
clicking node while Meta key pressed (multi-selection mode) inconsistent behavior. While multi-selection mode is on, clicking after moving mouse subtly, it's unselection or selection gets jammed.
Steps to reproduce the bug or issue
in codesandbox
click node multiple times in multi selection mode.
Expected behavior
has to be consistent
Screenshots or Videos
https://github.com/user-attachments/assets/29bfcd67-ae3b-4767-9cf2-38e38e41ecb3
Additional context
No response

That is the new nodeDragThreshold at work. A click is not registered while moving the mouse. I suppose you are moving the mouse slightly while clicking.
However, fiddling around with your demo, especially with a higher threshold like 5, it is clear that a click is prevented even though the threshold has not been reached yet. We will investigate this!

Ok, I found out what's happening. The CSS for a focused node is the same as for a selected node. We might fix this in a default styling revamp in the future. I will leave this open for now.

I agree that it is a bit confusing that focused and selected nodes look the same but it was always like this and we won't change it (because it would be breaking). You can adjust the focused styles by overwriting:
.react-flow .react-flow__node:focus {
  box-shadow: none;
}


try pinning to a nightly of two weeks ago

This passed CI over here and should get the 32-bit windows cross compiling tests passing until someone figures out why rustc is broken for that purpose
r? @alexcrichton
cc https://github.com/rust-lang/rust/issues/45500

@bors: r+ p=10

:pushpin: Commit 4f3795b has been approved by alexcrichton

:hourglass: Testing commit 4f3795b4a87bcb52254567fe1343a124b449d5c8 with merge 55442e8922ae7ad51545576a4f1326ab131a333a...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 55442e8922ae7ad51545576a4f1326ab131a333a to master...


Add mailgun email send service

to implements two factory login , or other email service.
http://www.mailgun.com/
mail gun is free for less then 1000 a month.
provided http/smtp api to send email. and can also recieve email.

close due to this project no long develop


add cellranger vdj test data

added FASTQs to test cellranger vdj for immune profiling
the original data are from the 10X Genomics tutorial for immune profiling (see here)
data here are subsampled from the original FASTQs
included a README.md with details

Do you need two lanes of this data?
You'll need R1 and R2, but do you need both lanes, or would the tools work with just one lane? That'd still give you your 10000 reads you need.

"need" is a strong word 😅 in my mind the test as arranged (successfully) checks for multilane samples which are an important real-world phenomenon with cellranger runs
that caveat aside, I will arrange a single lane test instead 👍🏼

cellranger vdj test data now uses only 1 lane of data


Ensure bbox is correct for negative voxel dimensions

For certain atlases (e.g. Paxinos) there is a convention of initializing the VoxelData with a negative z dimension.
When the bbox is calculated in that case the min and max point are swapped. This change ensures that under all cases the min an max points are correctly ordered.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e0347dc). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   94.23%
=======================================
  Files           ?       13
  Lines           ?      989
  Branches        ?        0
=======================================
  Hits            ?      932
  Misses          ?       57
  Partials        ?        0

Flag
Coverage Δ

pytest
94.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Master

Add new example to Durian

This PR is in bad shape. First, there is not only a new durian example, but also an ogl_tutorials example. Second, there are ogl_tutorials/common files in here which are already in examples/common. Third, you still carry all those old commits with you. Before submitting a PR, please do something like this on your working copy:
# if you do not already have my repo as remote
git remote add upstream https://github.com/flyx/OpenGLAda.git
# switching git branches will remove commited files that do not exist
# in the other branch. to carry over the files you want to commit from
# your current branch, save them somewhere else
mkdir tmp && cp -r examples/durian/hello tmp
# now make a new branch based on my master. It will not have all
# your old commits in the history
git checkout -b hello-example upstream/master
# copy back the things you want to commit
cp -r tmp/hello examples/durian
# commit them (you may want to change `.gitignore` before this)
git add examples/durian
# push the branch to your GitHub to be able to make a PR
git push origin hello-example

I hope this helps.

Yes, I have been quite bothered by all this.
I really do not understand how git works and have not been able to find a comprehensive reference that I understand.
Also, I have been trying to use GitHub desktop which should help but seems not to be very intuitive and doesn't seem to act how I expect it to.
I am wondering if GitHub Desktop is more trouble than its worth.
If possible, can you please give me instructions on how to fix things using GitHub Desktop.
However, I will put some more effort into understanding your comments tomorrow and try your recommended git commands on a new PR.
Sorry for the mess!
Regards,
Roger

On 2 Mar 2017, at 6:58 PM, flyx<EMAIL_ADDRESS>wrote:
This PR is in bad shape. First, there is not only a new durian example, but also an ogl_tutorials example.
Not intended. Should have been separate PRs.
Second, there are ogl_tutorials/common files in here which are already in examples/common.
I thought i'd deleted that directory.
Third, you still carry all those old commits with you.
And this is one thing I really don't understand. Why are they still there?

Before submitting a PR, please do something like this on your working copy:
if you do not already have my repo as remote
git remote add upstream https://github.com/flyx/OpenGLAda.git
switching git branches will remove commited files that do not exist
in the other branch. to carry over the files you want to commit from
your current branch, save them somewhere else
mkdir tmp
&&
cp -r examples/durian/hello tmp
now make a new branch based on my master. It will not have all
your old commits in the history
git checkout -b hello-example upstream/master
copy back the things you want to commit
cp -r tmp/hello examples/durian
commit them (you may want to change .gitignore before this)
git add examples/durian
push the branch to your GitHub to be able to make a PR
git push origin hello-example
I hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Late night thoughts.
Tomorrow my plan is:

Forget GitHub Desktop!
Delete my local OpenGLAda directory.
Clone your https://github.com/flyx/OpenGLAda.git
Follow your steps below for another PR.

On 2 Mar 2017, at 6:58 PM, flyx<EMAIL_ADDRESS>wrote:
This PR is in bad shape. First, there is not only a new durian example, but also an ogl_tutorials example. Second, there are ogl_tutorials/common files in here which are already in examples/common. Third, you still carry all those old commits with you. Before submitting a PR, please do something like this on your working copy:
if you do not already have my repo as remote
git remote add upstream https://github.com/flyx/OpenGLAda.git
switching git branches will remove commited files that do not exist
in the other branch. to carry over the files you want to commit from
your current branch, save them somewhere else
mkdir tmp
&&
cp -r examples/durian/hello tmp
now make a new branch based on my master. It will not have all
your old commits in the history
git checkout -b hello-example upstream/master
copy back the things you want to commit
cp -r tmp/hello examples/durian
commit them (you may want to change .gitignore before this)
git add examples/durian
push the branch to your GitHub to be able to make a PR
git push origin hello-example
I hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.