re-write this package to react native reanimated v2

At the moment performance is not great when animating with multiple shared values. I'll probably publish another package that uses reanimated 2 in the future, this one will stick with Animated though.

At the moment performance is not great when animating using multiple shared values. I'll probably publish another package that uses reanimated 2 in the future, this one will stick with Animated though.

At the moment performance is not great when animating with multiple shared values. I'll probably publish another package that uses reanimated 2 in the future, this one will stick with Animated though.


[FLINK-27690][python][connector/pulsar] Add Python documentation and examples for Pulsar connector

What is the purpose of the change
Add Python documentation and examples for Pulsar connector
Brief change log

Add a pulsar example in examples/datastream/connectors
Add pulsar source documents

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializer: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

When https://github.com/apache/flink/pull/19774 and https://github.com/apache/flink/pull/19771 merged, I will continue this PR.


format of type guid gives a warning.

https://raw.githubusercontent.com/creditsafe/connect-docs/master/cs_connectv1-15.json
warn: Kiota.Builder.KiotaBuilder[0]
      OpenAPI warning: #/components/schemas/IdvRequestDto/properties/id - The format guid is not supported by Kiota for the type string and the string type will be used.

that's because according to the registry the proper format is uuid, not guid. Do we want to add tolerance for that as well?

Ok, so warning is good. API producers should fix their OpenAPI to be uuid.


SoundCloud V2 API

This would solve a lot of problems that we've been having with Cumulus.
It looks this might be happening sooner rather than later: https://twitter.com/SoundCloudDev/status/639017606264016896

The library is being work on here: https://github.com/gillesdemey/soundcloud-v2

Nice!
Looking forward to this :)
On Sun, Sep 6, 2015 at 2:18 AM Gilles De Mey<EMAIL_ADDRESS>wrote:

The library is being work on here:
https://github.com/gillesdemey/soundcloud-v2
—
Reply to this email directly or view it on GitHub
https://github.com/gillesdemey/Cumulus/issues/12#issuecomment-138013012.


Move post tags input into PSM

Tags input got nuked in #5384 - this needs to be moved into the post settings menu (under publish date). This should be mostly moving ember things around, with some minor CSS edits to make it look right in the new location.

Could this potentially go with #3800, or should they be two separate things?

There is an issue for doing this (with much discussion) here: https://github.com/TryGhost/Ghost/issues/3800. Might be an idea to move that issue into zelda instead of this one?
It does involve rebuilding the component, but we need to do that anyway because if we move the component into the PSM I think we should change the way it is saved so that we can (hopefully) resolve #4999.

I've moved #3800 into Zelda in favour of this.


Figure out way to show an autocomplete popup in the Interactive Window

Monaco has a way to do this, CodeMirror does too. Start with CodeMirror and futz with the styles to see if can make it look like Monaco.
If that doesn't work, move onto investigating consuming monaco instead.

Monaco styling thoughts:
monaco.editor.defineTheme('myCustomTheme', {
	base: 'vs', // can also be vs-dark or hc-black
	inherit: true, // can also be false to completely replace the builtin rules
	rules: [
		{ token: 'comment', foreground: 'ffa500', fontStyle: 'italic underline' },
		{ token: 'comment.js', foreground: '008800', fontStyle: 'bold' },
		{ token: 'comment.css', foreground: '0000ff' } // will inherit fontStyle from `comment` above
	]
});

Generate these rules dynamically at run time. Might even be able to just get all of the scope values? How does it do it's tokenization though?

CodeMirror has a hintOptions value that specifies a function that returns a list.
  var comp = [
    ["here", "hither"],
    ["asynchronous", "nonsynchronous"],
    ["completion", "achievement", "conclusion", "culmination", "expirations"],
    ["hinting", "advive", "broach", "imply"],
    ["function","action"],
    ["provide", "add", "bring", "give"],
    ["synonyms", "equivalents"],
    ["words", "token"],
    ["each", "every"],
  ]

  function synonyms(cm, option) {
    return new Promise(function(accept) {
      setTimeout(function() {
        var cursor = cm.getCursor(), line = cm.getLine(cursor.line)
        var start = cursor.ch, end = cursor.ch
        while (start && /\w/.test(line.charAt(start - 1))) --start
        while (end < line.length && /\w/.test(line.charAt(end))) ++end
        var word = line.slice(start, end).toLowerCase()
        for (var i = 0; i < comp.length; i++) if (comp[i].indexOf(word) != -1)
          return accept({list: comp[i],
                         from: CodeMirror.Pos(cursor.line, start),
                         to: CodeMirror.Pos(cursor.line, end)})
        return accept(null)
      }, 100)
    })
  }

  var editor2 = CodeMirror.fromTextArea(document.getElementById("synonyms"), {
    extraKeys: {"Ctrl-Space": "autocomplete"},
    lineNumbers: true,
    lineWrapping: true,
    mode: "text/x-markdown",
    hintOptions: {hint: synonyms}
  })

Should try that in ours and see if the popup shows up or not.


[hw,dma,rtl] Only set error code when entering the error state

Previously, the error code is written when entering the error state AND while being in there. Since the error code value is only availble in the transition into the error state, and further update overwrites the error code again with zero.
This change ensures that the error code only gets update in the transition into the error state, where the correct value is available

CHANGE AUTHORIZED: hw/ip/dma/rtl/dma.sv


Document Vanilla Interruption bug

closes https://github.com/PaperMC/docs/issues/413

Not sure it needs to be, just because this is just stating that if you change this there will be a vanilla visual bug or whatever.


6th week lab report

@ozturkMirac created lab_report_6.md. I only created PR #389 to merge the report into the main branch. This PR is duplicate and closed since I already merged the report.


Better underpromotion tagging

The problem: Stockfish sometimes get flashy and suggests underpromotions to rook/bishop for mate even if promotion to queen does the job. These puzzles are unnecessarily tagged with underpromotions. Example: https://lichess.org/training/1nFrQ
The use case: Some of these puzzles have had the puzzle tag removed (I assume through voting) but a lot of them (46/552=8.3% of underpromotion puzzles) still exist in the puzzledb. If I'm sifting through the db (or even lichess) looking for underpromotion problems, I presume that underpromotion is the only solution as opposed to being one of the possible solutions.
The solution: Therefore, I've modified the code to only tag promotions to knight with mate as underpromotions (Queen promotions can do the job of the rook or bishop but not the knight). If it's not a mate then the logic remains as it was before. I've also added some tests for the function.

Hi,
There are cases where underpromotion will avoid a slatemate.

only tag promotions to knight with mate as underpromotions

f8=N# will be appropriately tagged
f8=R# is no longer valid. It'll still be a puzzle but it won't be tagged with "underpromotion"

If it's not a mate then the logic remains as it was before

f8=N is still valid

There are cases where underpromotion will avoid a slatemate.

While not stalemate, here is a puzzle that uses underpromotion to avoid a perpetual https://lichess.org/training/RbB4U


Snackbar RTL text support.

Bug, feature request, or proposal:
No sure.
What is the expected behavior?
Allow control over snackbar direction.
What is the current behavior?
Can't control snackbar direction
What are the steps to reproduce?
Any snackbar with RTL text:

What is the use-case or motivation for changing an existing behavior?
RTL sites with a snackabr.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular 4.0 material 2.0.3.beta
Is there anything else we should know?
Documentation does not tell about a method I should use, maybe this is a documentation issue rather than a missing implementation, not sure.
I'm sure there are workarounds, but I would like not to use them if possible.

Wow! Amazing turnaround time! Thanks!
When is this fix planned to be released?


Make all feature methods asynchronous

Methods returning ChannelReader were previously synchronous. This has been changed so that all feature methods return Task instead of T.

The rationale behind this change is to allow adapters to perform actions required to create a channel (such as invoking a SignalR streaming call) asynchronously.


Can there be network collisions because of PCs' similar names?

I don't know how it is handled in the JmDNS implementation but the specification has a description how such collisions should be handled.
See e.g.
https://tools.ietf.org/html/rfc6762#page-31 "9.  Conflict Resolution" and the linked "8.  Probing and Announcing on Startup" section


Publish 7.3-20211110050136+0000

Publish 7.3-20211110050136+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


Quickstart: Rooms JavaScript Code Snippet (Object names) are not matching with Actual Code in gitHub.

[Enter feedback here]

Open Quickstart - Create and manage a room resource - An Azure Communication Services quickstart | Microsoft Docs
2)Navigate to "Create a room ,Update the lifetime of a room , Add new participants and  Remove participants "sections in the document
Java Script snippet is having Mismatch between JavaScript actual code in gitHub(communication-services-javascript-quickstarts/client.js at main · Azure-Samples/communication-services-javascript-quickstarts · GitHub)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c165904-6efb-df66-7c88-bc9e0b43d836
Version Independent ID: 784f22cb-1724-abba-a4a9-8e6f183e3621
Content: Quickstart - Create and manage a room resource - An Azure Communication Services quickstart
Content Source: articles/communication-services/quickstarts/rooms/get-started-rooms.md
Service: azure-communication-services
GitHub Login: @radubulboaca
Microsoft Alias: radubulboaca

@v-pradda Thank you for your feedback! We will review and update as appropriate.

@v-pradda  I have assigned to the content author @radubulboaca to share his valuable insights on this

Thank you for highlighting this, inconsistency. Docs updated: https://docs.microsoft.com/en-us/azure/communication-services/quickstarts/rooms/get-started-rooms?pivots=programming-language-javascript

@v-pradda can you please review and update this issue as needed? Thank you!

@v-pradda Thank for your feedback! Requested Documentation changes were done.


Access token after logged in

I am trying to build a Facebook login function with native Facebook sdk.
I call the api with Facebook token and user id to verify and login identity server account but I cannot get the token after logged in.
Here is my step for verification:

Get Facebook email using Facebook access token and user id;

Verify email with Database;

Sign in Identity server;

Here is my code for verification
    [HttpPost]
    [AllowAnonymous]
    public async Task<string> GetTokenForIOS(FacebookUserModel model)
    {
        model.email = await GetEmail(model);
        var user = await _userManager.FindByNameAsync(model.email);
        if (user != null)
        {
            // sign in identityServer
            await _signInManager.SignInAsync(user, isPersistent: false);

            var externalAccessToken = await _userManager.GetAuthenticationTokenAsync(user, "IDV4", "access_token");

            string token = await GetAccessToken();
            return token;
        } else {
            FacebookUserInfoModel infoModel = await GetFacebookUserInfo(model);
            ...
            // sign in Identity Account after registration

            // return token;
        }
        return "";
    }

Here is my code for getting token
    public async Task<string> GetAccessToken()
    {

        // discover endpoints from metadata
        var disco = await DiscoveryClient.GetAsync("https://localhost:44355");

        // request token
        var tokenClient = new TokenClient(disco.TokenEndpoint, "client.ios");
        var tokenResponse = await tokenClient.RequestClientCredentialsAsync("api");

        if (tokenResponse.IsError)
        {
            Console.WriteLine(tokenResponse.Error);
            return "";
        }
        else
        {
            Console.WriteLine(tokenResponse.Json);
            JToken jObject = tokenResponse.Json;
            return tokenResponse.Json.ToString();
        }
    }

Here is my client config:
    new Client
           {
               ClientId = "client.ios",
               RequireClientSecret = false,
               ClientName = "iOS app client",
               AllowedGrantTypes = GrantTypes.Code,
               RequirePkce = true,
               //AllowAccessTokensViaBrowser = true,
               RequireConsent = false,

               RedirectUris = { "net.openid.appauthdemo:/oauth2redirect" },
               PostLogoutRedirectUris = { "net.openid.appauthdemo:/oauth2redirect" },

               AllowedScopes =
               {
                   IdentityServerConstants.StandardScopes.OpenId,
                   IdentityServerConstants.StandardScopes.Profile,
                   IdentityServerConstants.StandardScopes.Email,
                   IdentityServerConstants.StandardScopes.Phone,
                   "api"
               },
               AllowOfflineAccess = true
           }

The token response for access_token always is null. How can I get or generate the user access token with the user information for response or it's impossible to get token here?

I'm confused -- how does the FaceBook API have anything to do with IdentityServer?

I use the token to get the FaceBook user information such email to verify the email with email in DB.
If the email is existed then use the userManager sign in method. If not then to use the FaceBook user information to register a new account via userManager sign up method.
The major reason is I want to use native FB sdk to do FB login and then sign in IdentityServer to get tokenResponse to login my back-end service account through AppAuth. In your view, is it possible?

did you put "email" in the "scope"?
I know on Google you need to add to registration to get email.

I passed the FB access_token and userId as model to be parameter.
I can call the in FB api https://.../me?fields=email&access_token the GetMail method to get the user email for verification.
In this case, I want to get the user token response after logged in IdentityServer .

The below steps are my Facebook Login flow:
In Mobile:

iOS native Facebook login;

retrieve Facebook response then call api with Facebook access_token and userID

In IdentityServer:
3. retrieve Facebook access_token and userID then call Facebook user email via Facebook API with access_token;

retrieve Facebook user email then verify the email.

if email is existed, sign in the email's owner account of IdentityServer;

get token response then return to mobile app;

In Mobile:
7. retrieve the IdentityServer token response and then save to stateAuth of AppAuth;

use AppAuth login back-end server;

This flow only shows the normal Facebook login successfully. Some checking such as local login/Facebook login, login/registration and get Facebook information is success or not are not considering.

All set on this issue? Can we close?


whamwich has 5-0 run but doesn't have the badge - bug in achievements query changes or w/d/l denormalization

Is it possible this has the same cause as #5434 but hasn't cleared up because of redis caching? Probably not.

Funnily enough this seems unaffected by changing to preaggregating achievements. Weird.

Despite the 5-0 run of https://pennydreadfulmagic.com/decks/22801/ whamwich does not have the season 9 perfect league run achievement – https://pennydreadfulmagic.com/seasons/9/people/whamwich/

MariaDB [decksite]> SELECT * FROM person WHERE mtgo_username = 'whamwich';
+-----+------+--------------------+---------------+----------------------+--------------------+--------+------+
| id  | name | tappedout_username | mtgo_username | mtggoldfish_username | discord_id         | banned | elo  |
+-----+------+--------------------+---------------+----------------------+--------------------+--------+------+
| 108 | NULL | NULL               | WHAMwich      | NULL                 |<PHONE_NUMBER>06134528 |      0 | 1546 |
+-----+------+--------------------+---------------+----------------------+--------------------+--------+------+
1 row in set (0.00 sec)

MariaDB [decksite]> SELECT * FROM deck AS d INNER JOIN deck_cache AS dc ON d.id = dc.deck_id WHERE person_id = 108 AND wins = 5 AND losses = 0;
+-------+-----------+-----------+---------------------------------+-----------+--------------+--------------+----------------+-----------------------------------+--------------+--------------+---------------+-------+---------------+---------------------+--------+------------------------------------------+---------+----------+---------+---------+------------+----------------------------------------------------------------------------------+---------------------------------------------+-----------------+------+------+--------+-------+-------------+
| id    | person_id | source_id | identifier                      | name      | created_date | updated_date | competition_id | url                               | archetype_id | resource_uri | featured_card | score | thumbnail_url | small_thumbnail_url | finish | decklist_hash                            | retired | reviewed | id      | deck_id | colors     | colored_symbols                                                                  | legal_formats                               | normalized_name | omw  | wins | losses | draws | active_date |
+-------+-----------+-----------+---------------------------------+-----------+--------------+--------------+----------------+-----------------------------------+--------------+--------------+---------------+-------+---------------+---------------------+--------+------------------------------------------+---------+----------+---------+---------+------------+----------------------------------------------------------------------------------+---------------------------------------------+-----------------+------+------+--------+-------+-------------+
| 22801 |       108 |         3 | ["whamwich", 628, "1535439385"] | BW Tokens |<PHONE_NUMBER> |<PHONE_NUMBER> |            628 | /competitions/?competition_id=628 |           30 | NULL         | NULL          |  NULL | NULL          | NULL                |   NULL | 0d5cbb852d1ac2bedfa17e916f5df05f7c503a2b |       0 |        1 | 4479500 |   22801 | ["W", "B"] | ["W", "W", "W", "W", "B", "W", "B", "W", "W", "B", "B", "B", "W", "B", "W", "W"] | ["Penny Dreadful M19", "Legacy", "Vintage"] | Orzhov Tokens   | 0.27 |    5 |      0 |     0 |<PHONE_NUMBER> |
+-------+-----------+-----------+---------------------------------+-----------+--------------+--------------+----------------+-----------------------------------+--------------+--------------+---------------+-------+---------------+---------------------+--------+------------------------------------------+---------+----------+---------+---------+------------+----------------------------------------------------------------------------------+---------------------------------------------+-----------------+------+------+--------+-------+-------------+
1 row in set (0.00 sec)

MariaDB [decksite]> SELECT * FROM _achievements WHERE person_id = 108 AND season_id = 9;
+-----------+-----------+--------------------+-----------------+----------------+---------------+--------------+---------------------+
| person_id | season_id | tournament_entries | tournament_wins | league_entries | completionist | perfect_runs | perfect_run_crushes |
+-----------+-----------+--------------------+-----------------+----------------+---------------+--------------+---------------------+
|       108 |         9 |                  0 |               0 |             17 |             0 |            0 |                   0 |
+-----------+-----------+--------------------+-----------------+----------------+---------------+--------------+---------------------+
1 row in set (0.00 sec)

MariaDB [decksite]> SELECT * FROM deck_match WHERE deck_id = 22801;
+-------+----------+---------+-------+
| id    | match_id | deck_id | games |
+-------+----------+---------+-------+
| 78731 |    39751 |   22801 |     2 |
| 78889 |    39830 |   22801 |     2 |
| 79139 |    39956 |   22801 |     2 |
| 79147 |    39960 |   22801 |     2 |
| 79175 |    39974 |   22801 |     2 |
+-------+----------+---------+-------+
5 rows in set (0.00 sec)

SUM(CASE WHEN ct.name = 'League' AND dc.wins >= 5 AND dc.losses THEN 1 ELSE 0 END) AS perfect_runs
has a typo. Should be:
SUM(CASE WHEN ct.name = 'League' AND dc.wins >= 5 AND dc.losses = 0 THEN 1 ELSE 0 END) AS perfect_runs
0c952c7f


Fix funcaptcha asap

Please fix so that funcaptcha works properly (the one where you have to compare images and rotate until its the correct direction)
AFAIK there is no working solvers for this right now so please guys

same my isue


Header has a 1 pixel difference between night mode and day mode

Tbh I think the night mode being the same image but darker looks like shit too.

The entire repo is a botched patch up since they can’t into git. I’ll do a proper reverse to the push when I get home.

fine i'll change it back ;_;

don't touch my hat on light theme

well i brought back maid as well


addr:housenumber is glitchy during typing

URL
https://www.openstreetmap.org/edit#map=19/51.74659/20.77788
How to reproduce the issue?

Select an address
Clear the house number field
Start typing at least 2 char long number: 123
Result is 231

Screenshot(s) or anything else?
No response
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.26.1
Which browsers are you seeing this problem on?
Chrome

Same issue here.

This issue appears to be caused by code located at this specific location: https://github.com/openstreetmap/iD/blob/cc740be721bbc48c872a0ab67b18e7575cbe4547/modules/ui/fields/address.js#L284
When a user inputs a value, the cursor moves forward, but the update logic seems to reevaluate all the fields, often using outdated tags. This results in the temporary replacement of a value like "12" with "1" (since the tags are not updated at this point), followed by another call shortly after, which correctly replaces the value with "12".
In my opinion, the best approach to address this issue would be for the change event to update only the currently edited field, or at the very least prioritize updating those fields first to prevent overwriting them with outdated values.


[EDMTP-157] Add Alert widget annotation

@YanaBr, it looks like we also need to think about dependson support for alert for the future.
It looks like we need an action to set type/title and text depending on query, but we need to think of design first, this will be a tricky question.


Add a CLI version of Parrot

It would be nice to have a CLI tool that starts a server running parrot-middleware.  This would reduce the setup work needed to start using Parrot.

Closed with 7f0becb after internal PR and review.


What should I add in config to get metrics with tags

I have used config from 1 of the examples provided but I want something like:
##Info helper with tags
aws_elb_info{name="arn:aws:elasticloadbalancing:eu-west-1:472724724:loadbalancer/a815b16g3417211e7738a02fcc13bbf9",tag_KubernetesCluster="production-19",tag_Name="",tag_kubernetes_io_cluster_production_19="owned",tag_kubernetes_io_service_name="nginx-ingress/private-ext",region="eu-west-1"} 0
aws_ec2_info{name="arn:aws:ec2:eu-west-1:472724724:instance/i-someid",tag_Name="jenkins"} 0
in metrics. What shall I add in config.yaml to get something like tag_kubernetes/tag_name.
I did try options given in document such as custom_ta, search_tag, exportedtagonmetrics
But here I have to provide the tags, I want it to fetch tags automatically from AWS resource.
Is this possible?

I have used config from 1 of the examples provided but I want something like:
Info helper with tags
aws_elb_info{name="arn:aws:elasticloadbalancing:eu-west-1:472724724:loadbalancer/a815b16g3417211e7738a02fcc13bbf9",tag_KubernetesCluster="production-19",tag_Name="",tag_kubernetes_io_cluster_production_19="owned",tag_kubernetes_io_service_name="nginx-ingress/private-ext",region="eu-west-1"} 0
aws_ec2_info{name="arn:aws:ec2:eu-west-1:472724724:instance/i-someid",tag_Name="jenkins"} 0
in metrics. What shall I add in config.yaml to get something like tag_kubernetes/tag_name.
I did try options given in document such as custom_ta, search_tag, exportedtagonmetrics
But here I have to provide the tags, I want it to fetch tags automatically from AWS resource.
Is this possible?

Are you asking how to add static data yourself? The Tags YACE pulls are straight from your AWS resources and it doesn't offer control over it. You can use prometheus relabeling to normalize inconsistent tags but it's all based on what your resources have.

Hi @Preeti011987 , to get tags in your metrics I suggest adding the exportedTagsOnMetrics section to your config file. This is what a sample looks like:
apiVersion: v1alpha1
  discovery:
    exportedTagsOnMetrics:
      AWS/RDS:
        - MP_Engine
        - MP_MONITORING
        - MP_APPLICATION
        - MP_SERVICE    jobs:
      - type: AWS/RDS
        regions:
          - ap-south-1
        period: 300
        length: 300
        searchTags:
        - key: MP_MONITORING
          value: TRUE
        dimensionNameRequirements: [DBInstanceIdentifier]
        metrics:
          - name: CPUUtilization
            statistics: [Average]
          - name: MemoryUtilization
            statistics: [Average]
          - name: DatabaseConnections
            statistics: [Average]
          - name: FreeStorageSpace
            statistics: [Average]
          - name: DiskQueueDepth
            statistics: [Average]
          - name: SwapUsage
            statistics: [Average]
          - name: FreeableMemory
            statistics: [Average]

I have used the exportedTagsOnMetrics to get tags as labels in my metrics and I have also used searchTags to get the metrics only for those RDS which have the specific Tag Key and Value(in my case:  MP_MONITORING is the Key and TRUE is the Value).

Is there a way to export all tags? Does AWS/RDS: ["*"] work?


English translation is not shown nor an option

...also how do i place arcs when it says "please insert a chart first"?

Hello, it does say that english translation is not available for this version of arcade.

When you say that it's not available on THIS version what do you mean?(is there another version with the translation?)

It's written on README.md (literally the main page).
https://github.com/yojohanshinwataikei/Arcade-plus#why-this-version-do-not-have-localisation-feature

Yes but I wasn't aware of the meaning of this
On Thu, May 4, 2023, 7:40 PM Fryndazs @.***> wrote:

It's written on README.md (literally the main page).
https://github.com/yojohanshinwataikei/Arcade-plus#why-this-version-do-not-have-localisation-feature
—
Reply to this email directly, view it on GitHub
https://github.com/yojohanshinwataikei/Arcade-plus/issues/12#issuecomment-1535531179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7TYOCBCPRPTYB6JX43SNOTXEQ46NANCNFSM6AAAAAAXWHDFVU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Back to my other question...how do you place arcs when the pop up "insert a chart first" shows (I thought I was making the chart in arcade)

Open a chart file by clicking on "?" jacket box, you can select a ready chart folder or adding a new chart file by creating a new folder that includes blank 0.aff (New item > Text document > change the name & extension to 0.aff), a music file named with base.ogg (you can use .mp3 or .wav but I prefer .ogg), and a illust/jacket cover named base.jpg.

Thanks, I'll check it out
On Thu, May 4, 2023, 7:58 PM Fryndazs @.***> wrote:

Open a chart file by clicking on "?" jacket box, you can select a ready
chart folder or adding a new chart file by creating a new folder that
includes blank 0.aff (New item > Text document > change the name &
extension to 0.aff), a music file named with base.ogg (you can use .mp3 or
.wav but I prefer .ogg), and a illust/jacket cover named base.jpg.
—
Reply to this email directly, view it on GitHub
https://github.com/yojohanshinwataikei/Arcade-plus/issues/12#issuecomment-1535539330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7TYOCBUYLFDJF47OYO5MVTXEQ7APANCNFSM6AAAAAAXWHDFVU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Run spell check against all of the documentation

I thought codespell was handling that for me in https://github.com/simonw/datasette/blob/d32176c5b8283fbcc5c8a1f8e6d39339d73013c4/.github/workflows/spellcheck.yml but then I spotted this typo: https://github.com/simonw/datasette/commit/d32176c5b8283fbcc5c8a1f8e6d39339d73013c4
So I'm going to have a go at running everything through Gemini Pro 1.5.

files-to-prompt docs/*.rst | llm -m pro15 --system \
  'identify and list any possible spelling mistakes, for each one show the file and the surrounding text'

Possible Spelling Mistakes:
File: docs/authentication.rst

"anaynomous":

Surrounding Text: "You can specify that only unauthenticated actors (from anaynomous HTTP requests) should be allowed access using the special"
Suggested Correction: "anonymous"

File: docs/binary_data.rst

"infulunce":

Surrounding Text: "... It lets Datasette know if the current SQL query can be represented by the plugin - and hence infulunce if a link to this output format is displayed in the user interface."
Suggested Correction: "influence"

File: docs/changelog.rst

"collides":

Surrounding Text: "... setting rules for what should happen if a primary key collides with an existing row."
Suggested Correction: "collides" is likely spelled correctly, but consider alternatives like "conflicts" depending on the intended meaning.

"datsette":

Surrounding Text: "The **datsette** --get command-line mechanism now ensures any plugins using the startup() hook are correctly executed."
Suggested Correction: "datasette"

"frist":

Surrounding Text: "Datasette will only return the first 100 rows - the 101st is used purely to detect if there should be another page. Since the where clause acts against the index on the primary key, the query is extremely frist even for records that are a long way into the overall pagination set."
Suggested Correction: "fast"

File: docs/configuration.rst

"correct":

Surrounding Text: "... Some plugins can be configured at the database or table level. These should use a plugins key nested under the appropriate place within the databases object:\n...\n\n          my_other_database:\n            tables:\n              my_table:\n                # plugin configuration for the my_table table inside the my_other_database database\n                plugins:\n                  datasette-my-plugin:\n                    key: my_value"
Suggested Correction: "correct" is likely spelled correctly, but consider alternatives like "relevant" depending on the intended meaning.

File: docs/json_api.rst

"correct":

Surrounding Text: "... The "rows" key is a list of objects, each one representing a row. \n\nThe "truncated" key lets you know if the query was truncated."
Suggested Correction: "truncated" is likely spelled correctly, but consider alternatives like "limited" depending on the intended meaning.

"correct":

Surrounding Text: "... The JSON array option is useful if one of your matching values itself contains a comma:\n\n    ?column__in=[""value"",""value,with,commas""]"
Suggested Correction: "correct" is likely spelled correctly, but consider alternatives like "provided" or "specified" depending on the intended meaning.

"correct":

Surrounding Text: "... you may decide that a specific query can be cached for a longer time, or maybe you need to set ?_ttl=0 for some requests for example if you are running a SQL order by random() query."
Suggested Correction: "correct" is likely spelled correctly, but consider alternatives like "appropriate" or "desired" depending on the intended meaning.

File: docs/metadata.rst

"correct":

Surrounding Text: "... If your table has more than two columns you can specify which column should be used for the link label with the label_column property:"
Suggested Correction: "correct" is likely spelled correctly, but consider alternatives like "intended" or "desired" depending on the intended meaning.

File: docs/testing_plugins.rst

"than":

Surrounding Text: "... Datasette will search for this file first in the --template-dir= location, if it was specified - than in the plugin's bundled templates and finally in Datasette's set of default templates."
Suggested Correction: "then"

"than":

Surrounding Text: "... This method registers any :ref:plugin_hook_startup or :ref:plugin_hook_prepare_jinja2_environment plugins that might themselves need to make async calls.\n\nIf you are using await datasette.client.get() and similar methods than you don't need to worry about this - Datasette automatically calls invoke_startup() the first time it handles a request."
Suggested Correction: "then"

"or":

Surrounding Text: "If an exception occurs within Datasette itself during a test, the response returned to your plugin will have a response.status_code value of 500.\n\nYou can add pdb=True to the Datasette constructor to drop into a Python debugger session inside your test run instead of getting back a 500 response code. This is equivalent to running the datasette command-line tool with the --pdb option.\n\nHere's what that looks like in a test function:\n\n.. code-block:: python\n\n    def test_that_opens_the_debugger_or errors():\n        ds = Datasette([db_path], pdb=True)\n        response = await ds.client.get("/")"
Suggested Correction: "on"

File: docs/writing_plugins.rst

"thang":

Surrounding Text: "The exception to this rule is anythang that is documented here. If you find a need for an undocumented utility function in your own work, consider opening an issue <https://github.com/simonw/datasette/issues/new>__ requesting that the function you are using be upgraded to documented and supported status."
Suggested Correction: "thing"

Hah, that's amusing. It hallucinated the incorrect spellings a bit:

"anaynomous":

Surrounding Text: "You can specify that only unauthenticated actors (from anaynomous HTTP requests) should be allowed access using the special"

The misspelling is actually anynomous: https://github.com/simonw/datasette/blob/d32176c5b8283fbcc5c8a1f8e6d39339d73013c4/docs/authentication.rst#L315

Hah, yeah Gemini Pro 1.5 (and maybe LLMs in general) Isn't great for spellcheck.
It pointed to "the query is extremely frist even for records that"  but the sentence was actually "the query is extremely fast even for records that".

Also lots of suggestions like this, I can probably fix those with a prompt that says not to do this:

"correct" is likely spelled correctly, but consider alternatives like "appropriate" or "desired" depending on the intended meaning.

I'm done with this experiment for now.


Remove usage of async/await from code until the library switches over entirely

I found that there is still some code that use the async/await coding style in your base code (https://github.com/manfredsteyer/angular-oauth2-oidc/blob/286366939ed4ad02050d0c2d0f6a4b63f2dcc7ff/projects/lib/src/token-validation/validation-handler.ts#L45)
This is related to #329

I've slightly reworded the title (hope that's appropriate!), as you seem to suggest (correctly, IMHO) that until the guidance from #329 gets changed we should not include any async/await - and remove this occurence (not in the least to prevent dragging along polyfills just for one instance of these keywords)...


Support for PointZ? (x,y,z)

Hi there, any chance of implementing PointZ support?

I keeping this library as a 2d.  However, feel free to fork it and make the changes you need.


Issue705 image processing c2d example

Fixes #705 .
This PR contains changes that were missing from the previous PR #737.  (I had them in my local repo but forgot to push them before merging)
Changes proposed in this PR:

Renamed DATA_nft_token to erc721_nft
Fixed path when installing ocean.py directory
Added FACTORY_DEPLOYER_PRIVATE_KEY, required for mint_fake_OCEAN()
Changed TEST_PRIVATE_KEY1 to be different than FACTORY_DEPLOYER_PRIVATE_KEY

Since this PR contains just a few extra bug fixes that I forgot to include in the previous PR #737 and because my other task #744 is a much higher priority, I'm merging it without review.


[Pulsar Functions] Support config admin CLI in funtions runtime

Signed-off-by: xiaolong.ran<EMAIL_ADDRESS>Motivation
Sometimes, users want to use a customized admin CLI tool. Currently, in the k8s runtime, hardcode is used in getdownloadcommands(). This change will support users to configure the CLI tool they want. The default value is: /bin/pulsar-admin.
Modifications

Support config admin CLI

/pulsarbot run-failure-checks


Implement a store that uses Moka

This implements a SessionStore that that uses Moka, a high-quality in-process concurrent memory cache. The store takes another SessionStore as an argument when created, which it acts as a wrapper for. It will act as a write-trough cache: when loading a session it will read from the cache and only reach out to the wrapped SessionStore if there is a cache miss. When saving it will put the value both into the cache and push out to the wrapped SessionStore. So essentially it saves a database roundtrip when you load a session, since typically the value will be in the cache. It also intentionally caches negative lookups, to avoid having to hit the database if the same non-existant session id is checked multiple times.
I also made it possible to use it as a pure memory store, since it only took a couple of extra lines of code to do so.

This is fantastic! Thank you. 🙏

I wonder if there's a way of generalizing this pattern? For instance, I could see using Redis for a similar purpose, a la the caching database backend Django provides.

Codecov Report

Merging #6 (d645872) into main (c78add1) will decrease coverage by 8.21%.
The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   66.30%   58.09%   -8.21%
==========================================
  Files           6        7       +1
  Lines         184      210      +26
==========================================
  Hits          122      122
- Misses         62       88      +26

Files
Coverage Δ

src/lib.rs
0.00% <0.00%> (ø)

src/moka_store.rs
0.00% <0.00%> (ø)

Sorry about the failing doc test, I should have checked it locally, that was lazy of me.
I don't know about how you'd generalize. But I was wondering if implementing as a SessionStore was the most appropriate, or if it'd be better to make it a part of the service somehow. In the end I did it this way because I was unfamiliar with the code base and this way didn't require touching any internals.

One idea I had was a kind of "store of stores" pattern. I think that would require changing SessionStore tho. For instance perhaps it's there's optional associated type which is also SessionStore that implementors can opt to use in their implementations. (I'm actually not sure if this kind of recursion is allowed by the type system, since this might be self referential.) But that would allow any SessionStore to be used as a cache for another SessionStore.

It seems it didn't run the integration tests for the new store. I'm not super familiar with github checks. What did I miss to get that to work?

Oh I see it. It would require refactoring your workflow file, since your file assumes the name of the test file and the feature to enable is the same. But I added two test files, one testing using the MokaStore as a memory only backend, and one testing it wrapping sqlite, and they can't both have the same name. And also for the second one it'd need both the sqlite and moka features, but since you use the same variable for both the name of the test and the feature to enable that won't work.
How do you want to handle this?

Sorry about that--it may not be the best assumption that the test file names will always match in this way. Perhaps we could treat it as a glob or prefix instead?

It looks like this is passing now (I'm not too worried about codecov, since these integration tests aren't currently tracking coverage).
If you agree this looks good, I'm happy to merge it. I'm still mulling over a more generalized pattern which would allow any SessionStore to be used as a caching layer for another SessionStore but if you're okay with this implementation perhaps changing a bit in a future release we can leave that for another time.

Sure. There are things you could improve, but it works as a basic implementation I think. I haven't done extensive testing, but when running the counting example against a remote postgres database over the internet the page load is reduced from ~60ms to ~30ms with the cache, so it seems useful.
It would probably be possible to get that close to 0ms by having the store to the remote db happen in the background and returning early. But you'd give up being able to report back any database errors to the caller. Still, I wonder if having that as an option would be desirable. Not as crucial though, as in a real life scenario reads are probably much more common than writes.

page load is reduced from ~60ms to ~30ms with the cache

50% improvement is nothing to shake a stick at.

Still, I wonder if having that as an option would be desirable.

I'm certainly not opposed to this.

Nevermind, it did not pan out.

Here's a diff of a sketch I think could work:
diff --git a/src/session_store.rs b/src/session_store.rs
index 45cfa87..ce2e7ec 100644
--- a/src/session_store.rs
+++ b/src/session_store.rs
@@ -1,4 +1,5 @@
 //! An arbitrary store which houses the session data.
+
 use async_trait::async_trait;

 use crate::session::{Session, SessionId, SessionRecord};
@@ -18,3 +19,77 @@ pub trait SessionStore: Clone + Send + Sync + 'static {
     /// A method for deleting a session from a store.
     async fn delete(&self, session_id: &SessionId) -> Result<(), Self::Error>;
 }
+
+#[derive(Debug, Clone)]
+struct CachingSessionStore<C: SessionStore, S: SessionStore> {
+    cache: C,
+    store: S,
+}
+
+#[derive(thiserror::Error, Debug)]
+enum CachingStoreError<Cache: SessionStore, Store: SessionStore> {
+    #[error(transparent)]
+    Cache(Cache::Error),
+
+    #[error(transparent)]
+    Store(Store::Error),
+}
+
+#[async_trait]
+impl<Cache, Store> SessionStore for CachingSessionStore<Cache, Store>
+where
+    Cache: SessionStore + std::fmt::Debug, // TODO: Why is this required to be Debug?
+    Store: SessionStore + std::fmt::Debug,
+{
+    type Error = CachingStoreError<Cache, Store>;
+
+    async fn save(&self, session_record: &SessionRecord) -> Result<(), Self::Error> {
+        self.store
+            .save(session_record)
+            .await
+            .map_err(Self::Error::Store)?;
+        self.cache
+            .save(session_record)
+            .await
+            .map_err(Self::Error::Cache)?;
+        Ok(())
+    }
+
+    async fn load(&self, session_id: &SessionId) -> Result<Option<Session>, Self::Error> {
+        let session = match self.cache.load(session_id).await {
+            Ok(Some(session)) => Some(session),
+
+            Ok(None) => {
+                let session = self
+                    .store
+                    .load(session_id)
+                    .await
+                    .map_err(Self::Error::Store)?;
+                if let Some(session) = session.clone() {
+                    let session_record = (&session).into();
+                    self.cache
+                        .save(&session_record)
+                        .await
+                        .map_err(Self::Error::Cache)?;
+                }
+                session
+            }
+
+            Err(err) => return Err(Self::Error::Cache(err)),
+        };
+
+        Ok(session)
+    }
+
+    async fn delete(&self, session_id: &SessionId) -> Result<(), Self::Error> {
+        self.store
+            .delete(session_id)
+            .await
+            .map_err(Self::Error::Store)?;
+        self.cache
+            .delete(session_id)
+            .await
+            .map_err(Self::Error::Cache)?;
+        Ok(())
+    }
+}

Looks reasonable to me. And if you wanted more than two for some reason you could chain them together cons-list style.


Changed to v0.2.5

Pull Request Test Coverage Report for Build 8

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.327%

Totals

Change from base Build 7:
0.0%

Covered Lines:
73

Relevant Lines:
76

💛  - Coveralls


Is there any plan to port the IntelliJ plugin to Visual Studio Code?

Hi,
First of all thank you for the great work on this template engine, looks very promissing and I want to use in a new project.
I wonder if there is any plan to have a support extension for Visual Studio Code just like there is for IntelliJ Idea.
I would like to help towards the extention but not sure where to start.
Best regards,
maj2c

Thanks for the heads up!
There are no plans to write a VSCode plugin on my side. I'm a heavy IntelliJ user, so that plugin is enough for my needs.
The IntelliJ plugin is on GitHub and may be a starting point for a VSCode plugin: https://github.com/casid/jte-intellij
However, I've spent more time on the IntelliJ plugin than on jte itself. Writing that plugin was really a pain :-D
I fear there isn't much code to be reused either, since everything is custom Jetbrains APIs.

I've never developed a plugin for IntelliJ, but if it supports the language server protocol you might have the chance to kill two flies with one clap.
That being said... I'd still say that using VSCode for Java development is a bit of a niche still.

Right now there's no plan / resources to do so.


Cannot move compressed files due to permission errors

PermissionError: [WinError 5] Access is denied: 'C:/Users/tyler/Downloads/24922-Corrected Normal<EMAIL_ADDRESS>Normal Maps\\effects\\decals\\blood_splatter'

I've only been able to retrace the bug through installing this mod:
https://modworkshop.net/mod/24922
Here's how I trigger the bug:

Download and open the archive with winrar
Drag the folder from within winrar and drop it into Myth Mod Manager

This bug shouldn't be fixed in earlier versions, but I tested this on the 1.0.0-release branch
The traceback is called when shutil.rmtree() or shutil.move() is called because they both involve file deletion.
I'm really confused as of why this is happening, the folders when viewing with winrar have blue text meaning that they are compressed which might have something to do with it.
Deleting manually does work.
This is a really strange bug that might make some bumps for a lot of users, so please let me know if you know anything about this topic.

There were sub directories in the folder that had every permission except writing permissions. I am writing a fix now so this doesn't happen in the 1.0 release


Feature/dcat2

This PR is not to be merged at the moment. It will serve as a code-review technique using GitHub features with @skodapetr being the reviewer and @eghuro writing the code.

 Code-review formulářového řešení


Create registration logic to create various flavors/variants of volume provisioners as well orchestration providers

Maya api server needs to create registration points that can create instances of below combinations:

jiva provisioner with default properties talking to nomad orchestrator with default properties
jiva provisioner with X profile (i.e. a set of properties) talking to nomad orchestrator with Y profile (i.e. a set of properties)
similarly, various other combinations

It should be possible to get above instances & set them with specific profile at runtime.
  jiva := fetchVolumeProvisioner("jiva")
  jiva.WithProfile("one of the registered jiva profile")
  jiva.WithOrch("nomad", "one of Nomad's registered profile name")

In addition, these profiles should be operable in a CRUD format & searchable via their names.
Profiles should be stored in a distributed database.
Also refer to https://github.com/openebs/mayaserver/issues/23 & https://github.com/openebs/mayaserver/issues/22.

Maya api server's volume provider based profiles

maya api server will read its configuration from etcd.
By default, it will read the nomad configuration from below etcd prefix

/openebs.io/mapiserver/volumeprovider/jiva

maya api server's binary i.e. m-apiserver will introduce a option to accept this config.
Alternatively, you can use etcdctl utility to set values in etcd.
The value of the config is a JSON dictionary with the following keys:

{
  "type": "jiva",
    "profiles": [{
      "name": "fast",
      "default": "true",
      "fe-image-version": "openebs:latest",
      "fe-count": "1",
      "be-image-version": "openebs:latest",
      "be-count": "2",
      "be-persistence-location": "/tmp/",
      "orchprovider-name": "nomad",
      "orchprovider-profile": "abc"
    }]
}

Maya api server's orchestrator based profiles

maya api server will read its configuration from etcd.
By default, it will read the nomad configuration from below etcd prefix

/openebs.io/mapiserver/orchprovider/nomad

maya api server's binary i.e. m-apiserver will introduce a option to accept this config.
Alternatively, you can use etcdctl utility to set values in etcd.
The value of the config is a JSON dictionary with the following keys:

{
  "type": "nomad",
    "profiles": [{
      "name": "abc",
      "default": "true",
      "address": "http://<IP_ADDRESS>:4646",
      "region": "us-west-1",
      "datacenter": "xyz",
      "cn-type": "host",
      "cn-network-cidr": "<IP_ADDRESS>/24",
      "cn-interface": "enp0s8"
    }]
}


Configure GitHub Actions to run tests

This starts a PostgreSQL service (using this pattern) and runs the tests against it.
I had to mark one of the tests as xfail because it's exercising a URL which I don't think has been implemented yet (/@test@example.com/actor/).
Refs:

#11

Hilariously this is because I moved the actor URLs to be just @username yesterday and forgot to run the tests, so that's actually a valid fail!


Alternating the task of Merging into Project master

I am beginning to feel that alternating the merging of pull requests into the project root is becoming a hustle.
What I am now proposing is that we do it over milestones. So for each milestone only one person has the responsibility of merging changes into master.
Thoughts ?

OK, that may be more practical. It seems reasonable to appoint a merge master for each milestone.
Just out of interest, what do you find a hassle thought? I want us to have it for the record, so that we can remind ourselves later why we took certain decisions.

That way, due diligence can be enforced but does not become an impediment to development after every push.

Since we have agreed I am marking the issue as closed.
@lcabrini Cool ?

That's fine. You can close.


Change documentation to markdown

That way we can get real diffs!

Large amounts of documentation were moved to Markdown. Closing this issue and instead we can create an issue in the specific repos that still require porting.


Special case single 'oneOf' requirement error message to be singular

Work for this issue will begin begin on branch work-liquid-labs/string-input/27.


"Bring Your Own Compute" using authenticated webgme workers

Users should be able to connect their own worker machines for running their own jobs. (Currently, there is no authentication in the workers.)
This depends on https://github.com/webgme/webgme-engine/pull/181

This is currently waiting for a new release of webgme including the beforementioned feature that has been added to webgme.


The new icon sets website's search bar is hard to click

This is the best repo I could find. It might be the wrong one, because i couldn't find one dedicated to icon-sets.iconify.design.
In the "filter icons" bar, the search input is hard to click. You can't click on it from the edges of the search bar or by clicking on the icon (funnily the icon has a hover state even though you can't click on it to enter the text input), instead there's a very narrow area to click (<24px tall). I should be able to click anywhere in the search bar and focus the input.

Thanks for reporting!
Fixed and deployed.

Also fixing for other inputs, but that needs a bit more testing, so fix is not deployed yet

All inputs I've tested still have this problem. What's going on?

I don't see any problems. Clicking container element focuses icon.
For some small inputs container is a bit inside of input, so clicking border area doesn't work, but its just few pixels difference.

I would submit a PR that gives the intended behavior but I'm not sure where the source is.

Can you make a quick demo to show what exactly is not working? Screen recording or a screenshot with arrow pointing to location you are trying to click that doesn't work.

Gave you access to repo. Run build to build all packages (2 packages need building before it can be used: public/utils and private/utils, other packages don't require building). Website is in iconify-ui/website, run dev to run it in dev mode.


geojson parser fails

Describe the bug
Am trying to use the geojson syntax from the example. Parsing fails.
To Reproduce
<IP_ADDRESS>:9851> SET city tempe OBJECT {"type":"Polygon","coordinates":[[[-111.9787,33.4411],[-111.8902,33.4377],[-111.8950,33.2892],[-111.9739,33.2932],[-111.9787,33.4411]]]}
Invalid argument(s)
same for a simple example:
<IP_ADDRESS>:9851> SET cities x OBJECT {"type": "Point", "coordinates": [1.2, 2.1]}
Invalid argument(s)
Operating System (please complete the following information):

OS: amd64/linux on docker
Version 1.19.5

uh, my fault: forgot the enclosing quotes:
<IP_ADDRESS>:9851> SET city tempe OBJECT '{"type":"Polygon","coordinates":[[[-111.9787,33.4411],[-111.8902,33.4377],[-111.8950,33.2892],[-111.9739,33.2932],[-111.9787,33.4411]]]}'
OK
that said, i am a total copy-paste fan when it comes to learning from tutorials... maybe the docs need an update? ;)

Thanks for point that out. I filed a bug on the docs repo.

I updated the documentation with the added ticks around the geojson.


Remove --allow-privileged as it is deprecated in latest 1.15.0

I meet the issue below after I upgrade my cluster to 1.15.0

server.go:156] unknown flag: --allow-privileged

And the document here in https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/#options whose top bars show 1.15 document. However this is not updated. So I remove it.

/lgtm
/approve


Support auto-correction for Style/IfUnlessModifierOfIfUnless

This PR supports auto-correction for Style/IfUnlessModifierOfIfUnless.
From:
condition ? then_part : else_part unless external_condition

To:
unless external_condition
condition ? then_part : else_part
end

Branch indentation is left to Layout/IndentationWidth cop to keep the code simple.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


Fix session files handling when there are cookies and other headers following

Fixes #1126.

Codecov Report

Merging #1127 (b35ebf7) into master (54c8612) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   97.16%   97.17%
=======================================
  Files          65       65
  Lines        4162     4170    +8
=======================================
+ Hits         4044     4052    +8
  Misses        118      118

Impacted Files
Coverage Δ

httpie/sessions.py
96.77% <100.00%> (ø)

tests/test_sessions.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c8612...b35ebf7. Read the comment docs.

The exact issue happens when there is another header to handled after we do the del request_headers[name].
Here is a reproduction case to ease understanding:
# file: test.py
from requests.structures import CaseInsensitiveDict

d = CaseInsensitiveDict({
    "a": 1,
    "b": 2,
})

def a():
    print("a start")
    r = d.copy()
    for k, v in r.items():
        if k == "a":
            del r[k]
    print("a end")

def b():
    print("b start")
    r = d.copy()
    for k, v in r.items():
        if k == "b":
            del r[k]
    print("b end")

b()
a()

Output:
b start
b end
a start
Traceback (most recent call last):
  File "/home/tiger-222/projects/httpie/r.py", line 28, in <module>
    a()
  File test.py", line 12, in a
    for k, v in r.items():
  File "/.../Lib/_collections_abc.py", line 850, in __iter__
    for key in self._mapping:
  File "/.../requests/structures.py", line 60, in <genexpr>
    return (casedkey for casedkey, mappedvalue in self._store.values())
RuntimeError: OrderedDict mutated during iteration

We can see that we can alter the dict if the del happens last, and that's why we did not encounter the problem sooner. Maybe the situation is not so frequent.

🥧


Improve code for getting column name from expression

This improves PyExpr::_column_name to delegate to DataFusion to build a name for an expression. This code does not appear to be widely used in the tests though so it is hard to tell if this change meets all requirements.

Codecov Report

:exclamation: No coverage uploaded for pull request base (datafusion-sql-planner@5932f35). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             datafusion-sql-planner     #509   +/-   ##
=========================================================
  Coverage                          ?   53.01%
=========================================================
  Files                             ?       69
  Lines                             ?     3461
  Branches                          ?      692
=========================================================
  Hits                              ?     1835
  Misses                            ?     1506
  Partials                          ?      120

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


chore(pre-commit): # update to latest GGShield

Codecov Report

Merging #655 (1171066) into main (63b3c31) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   93.57%   93.57%
=======================================
  Files         108      108
  Lines        4915     4915
=======================================
  Hits         4599     4599
  Misses        316      316

Flag
Coverage Δ

unittests
93.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


feat: support rocketmq sink

Proposed Changes:
Which issue(s) this PR fixes:

The main purpose of this PR is to support the RocketMQ Sink.
In some scenarios, RocketMQ has higher write performance than Kafka when there are a large number of topics. Our company's internal MQ mainly uses RocketMQ.
I have used and verified the rocketmq Sink function in my K8s cluster, and it works properly. I am looking forward to adding this Sink into Loggie (so that I don't need to maintain a separate version of Loggie within the company).
Regarding unit testing, I noticed that there aren't many examples for other Sinks in this area. If needed, I am happy to supplement them but may require some examples and assistance. Thank you very much!
Additional documentation:
I don't know where to add the document 😓, please tell me.

Welcome! Please submit your document PR to this link: https://github.com/loggie-io/docs. I will merge it when we release a new version.

@hansedong The CI build has failed. Please run the 'make fmt' command locally and resubmit your changes.

@hansedong The CI build has failed. Please run the 'make fmt' command locally and resubmit your changes.

It has been resolved.

@ethfoo  I've been committing code for quite some time now, and up to this point, the code is working fine. However, my branch differs a lot from the main branch. Just now, I've committed again to resolve some code conflicts. Please approve the workflow. I wanted to ask, is there a plan to merge this into the mainline?

@ethfoo

Welcome! Please submit your document PR to this link: https://github.com/loggie-io/docs. I will merge it when we release a new version.

I've already submitted a PR for loggie/docs.

The CI build has failed. Please run the 'make fmt' command locally and resubmit your changes.

In addition, I've followed your instructions, executed the make fmt command and resubmitted the PR (to avoid introducing too many meaningless commits, I force pushed the commit).
I'm sorry, could you clarify which one you're referring to?

@ethfoo

Welcome! Please submit your document PR to this link: https://github.com/loggie-io/docs. I will merge it when we release a new version.

I've already submitted a PR for loggie/docs.

The CI build has failed. Please run the 'make fmt' command locally and resubmit your changes.

In addition, I've followed your instructions, executed the make fmt command and resubmitted the PR (to avoid introducing too many meaningless commits, I force pushed the commit).

Please take a look at reivew comments above.

I'm sorry, could you clarify which one you're referring to?

@hansedong

@ethfoo  I'm very sorry that I didn't see the code suggestion you mentioned before. I am currently working on the two points you mentioned and thank you for bringing them to my attention.

@ethfoo
The support for RocketMQ sink has been developed and basiclly completed. The commits mainly includes the following aspects:

Support for RocketMQ sink.
Dynamic rendering of tags in addition to topics in RocketMQ sink.
RocketMQ client SDK has its own default logging component. I have made an adaptation so that RocketMQ client can use Loggie's logger, in order to maintain consistency in the way logs are outputted, log formats, and log levels of Loggie.

I have already deployed and conducted functional testing in my own two sets of K8s environments, everything is working fine. Also, the PR https://github.com/loggie-io/docs/pull/160  is updated.
Please kindly review it again and if possible, provide some constructive feedback. Thank you.


feat: evaluation using peft models with CLM

Closes #413.
I added an optional install for sentencepiece as it was required for me to use the tokenizer for the LLaMa models. Not sure if that's something that you'd like in here but can remove if it's not!

I was looking for peft compatibility. Glad you are working on this. I'm curious. How would you run this from the main.py script to output a result for a peft model?

@kishb87 I ran it by adding an arg to --model_args like
--model_args pretrained=EleutherAI/gpt-j-6b,peft=<peft id in huggingface>

I was looking for peft compatibility. Glad you are working on this. I'm curious. How would you run this from the main.py script to output a result for a peft model?

I haven’t had a chance to test this yet, but it looks like you should use either hf-causal or hf-seq2seq, whichever matches the base model.

yes! the full command I used looked like
python main.py --model hf-causal --model_args pretrained=EleutherAI/gpt-j-6b,peft=<peft_model_id> --tasks openbookqa,arc_easy,winogrande,hellaswag,arc_challenge,piqa,bool --device cuda:0 --batch_size 128 --output_path results

yes! the full command I used looked like
python main.py --model hf-causal --model_args pretrained=EleutherAI/gpt-j-6b,peft=<peft_model_id> --tasks openbookqa,arc_easy,winogrande,hellaswag,arc_challenge,piqa,bool --device cuda:0 --batch_size 128 --output_path results

Can you add this to the README, along with stating that we support PEFT?

@StellaAthena done! let me know if you'd like me to reword at all

@zanussbaum Great work! I'm having issues however running with hf-seq2seq models For example, when running:
python main.py     --model hf-seq2seq    --model_args pretrained=google/flan-t5-large,peft=declare-lab/flan-alpaca-large --tasks openbookqa,arc_easy,winogrande,hellaswag,arc_challenge,piqa,boolq --device cuda:0
I get the following error:
Traceback (most recent call last):   File "/home/paperspace/tinyChat/lm-evaluation-harness/main.py", line 108, in <module>     main()   File "/home/paperspace/tinyChat/lm-evaluation-harness/main.py", line 79, in main     results = evaluator.simple_evaluate(   File "/home/paperspace/tinyChat/lm-evaluation-harness/lm_eval/utils.py", line 160, in _wrapper     return fn(*args, **kwargs)   File "/home/paperspace/tinyChat/lm-evaluation-harness/lm_eval/evaluator.py", line 64, in simple_evaluate     lm = lm_eval.models.get_model(model).create_from_arg_string(   File "/home/paperspace/tinyChat/lm-evaluation-harness/lm_eval/base.py", line 114, in create_from_arg_string     return cls(**args, **args2)   File "/home/paperspace/tinyChat/lm-evaluation-harness/lm_eval/models/huggingface.py", line 187, in __init__     self.model = self._create_auto_model_peft(   File "/home/paperspace/tinyChat/lm-evaluation-harness/lm_eval/models/huggingface.py", line 241, in _create_auto_model_peft     model = self.AUTO_PEFT_CLASS.from_pretrained( AttributeError: 'NoneType' object has no attribute 'from_pretrained'

I didn't add it for sequence to sequence models but it should be pretty easy to do (just adding this line to AutoSeq2SeqLM: https://github.com/EleutherAI/lm-evaluation-harness/blob/master/lm_eval/models/huggingface.py#L405)
I can do this in the next few days

That gets it working. Thanks!


⚠ Bofrost.lu has degraded performance

In 691b5cf, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1407 ms

Resolved: Bofrost.lu performance has improved in b7c74b6 after 6 minutes.


swap ... bench: 29 ns/iter (not 6?)

$ cargo bench
...
swap ... bench:          29 ns/iter (+/- 0)
I'm curious what CPU was used (and perhaps Rust version?).
I'm using Rust 1.13 nightly
machine: Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz
Any ideas why I'm 5x slower?
Thanks!

The benchmark performs 10 context switches in a loop. So it's actually 2.9ns per switch.

Cool.
Ty for responding.

Well, we should celebrate that we're now twice as fast as stated :).

@Ericson2314 No, we already state we're at 3ns/switch. The benchmark necessarily measures switches back and forth, however.


WSL profile is not showing up

Windows Terminal version (or Windows build number)
Microsoft Windows [Version 10.0.19041.985]
Other Software
WSL
C:\>wsl -l -v
  NAME                   STATE           VERSION
* docker-desktop         Running         2
  docker-desktop-data    Stopped         2

Steps to reproduce
Add such entry for WSL in profile
            {
                "guid": "{9acb9455-ca41-5af7-950f-6bca1bc9722f}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl"
            }

Expected Behavior
See the profile showing up.
As far as I know WSL should be detected and created automatically, meaning that the entry above should be always there (see https://github.com/microsoft/terminal/issues/3231#issuecomment-542966078), but this doesn't happen for some reason
Actual Behavior
Nothing happens

This instance was created by docker-desktop.
I changed my default WSL instance to Ubuntu and now it's working just fine

I don't know the detail of this but I think docker-desktop related distros are not intended for usage outside docker.

Correct. These distributions are an internal implementation detail of the Docker Desktop service. They are not intended to be used.

Please any one reading this email please I beg you with the name of any
thing you worship please help me out with $200 am dieing but you can save a
life by helping me out I will really appreciate if my request are granted
am the one innocent, you can send me the money through Bitcoin, this my
Bitcoin wallet address 3HUj5eE3DApm6tW68aDVJMfrAUij2oTXD2 God bless you
On Mon, Jun 7, 2021, 3:40 AM Chester Liu @.***> wrote:

I don't know the detail of this but I think docker-desktop related distros
are not intended for usage outside docker.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/10348#issuecomment-855535267,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVXUWYMBCNVO6BO77X47G3TRQWQHANCNFSM46EXKIGA
.

https://github.com/microsoft/terminal/issues/3556 was the request to hide the docker-desktop distros.


tools: skip cleaning volumes in-use

Signed-off-by: Kyr Shatskyy<EMAIL_ADDRESS>

@jhesketh I have no right to add anyone as a reviewer, so asking in comments please review.


Permission for autoaction step plugin

Description

Submitter checklist for changing permissions

Always

[ ] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] All newly added users have logged in to Artifactory at least once

Git repository link:
https://github.com/jenkinsci/autoaction-step-plugin
HOSTING issue:
https://issues.jenkins-ci.org/browse/HOSTING-790

Review all the checks.


Decide on a versioning and branching strategy for this project

Options include:

Keep it agile - no versioning
Commits and PRs straight to master
A development branch and feature branches
Git tagging

Commits straight to master would not be a good idea. There needs to be at least 2 branches. One dev/working branch and one master.
Could use volunteers to review threats submitted before adding it to the master branch.

Yup, makes sense. Would feature branches be off of the dev branch or master? Do you think it would be worth trying to version things at all (e.g. tagging master)?

I think that having the master branch protected and only accepting changes by reviewed PRs should do the trick. The timeline would then be tagged at given milestones. This would allow the features to be available as soon as they are reviewed.

Cool cool. What about versioning? I'm thinking it makes to use something like SemVer as major changes to something like the structure of the threat model YAML files could break compatibility. Should threats and BDD be versioned separately in some way? I'm thinking a major change to either would just bump the major version for the project as a whole.

In the meantime, I have turned on protected branches for master.

I'm struggling to see a reason to version. I've time boxed this issue to 2017-10-29, so if there is no particular reason use tagging etc. by then we can just close the issue and revisit later if needed.

Closing now, as per above, we can revisit if required.


Provide source distribution as a zip package in addition to tar.gz

We currently only create source distributions in the tar.gz format. These packages work fine with pip regardless the platform, but are problematic on Windows if needing to install from source manually. Windows can extract zip packages by default, but extracting tar.gz packages requires an external program.
Required changes to our packaging scripts ought to be trivial. I also expect everything to work just fine if we upload both zip and tar.gz packages to PyPI, but that needs to be tested once 3.0.2 is out. If there are problems, we can always just remote the zip package.
We plan to support wheels in the future (#1734), but providing zip packages shouldn't harm then either.

 It turned out that it isn't anymore possible to upload more than on sdist to PyPI. Need to revert changes to installation instructions.
Once we get wheels (#1734), we can consider changing sdists to use zip instead of tar.gz. That cannot be done in a minor release, though.

Unfortunately this cannot be done unless we stop creating tar.gz distros. Added a note about considering that once we got wheels to #1734.


360° Smartphone Panorama shown as 270° Panorama

Hy,
when I load this 360° Smartphone Panorma (Link to the Picture) it is just shown as a 270° panorama. Continuous scrolling is not possible like on the example picture on the Smartphone Panorma example page.
Why? And how can I change ist?
Thanks
Holger

Hello, @HolgerSchulz!
By its definition, the image should have a width at least six times larger than its height to have 360° panorama enabled. (See this code)
As your image's height is 300, resizing your image width to 1800 will show 360° panorama with a slight visual defect.
Here's your resized image I've tested & test result.

Hi WoodNeck,
thanks for your fast response!
It would be great if there would be an option to tell if it is a 360° panorama or not - regardless of the resolution.
I would use automatic detection by imageAspectRatio just as a fallback if no explicit definition was made.
Thanks
Holger

Thanks for the suggestion 👍
I think it's good to have that option.
Like your case, it can be quite confusing without it.
But our panorama renderer can't handle that option at the moment, it'll show space above image aspect as black(clear color).
If you think that's just okay, you can override yawRange to 360 at ready event with the current version.
Anyway, I'll close this issue for now. Please feel free to reopen whenever it's needed.

Hi WoodNeck,
I tried this:
panoViewer.on("ready", function() {
panoViewer.setYawRange([-180, 180]);
});
But then there is a big white gap between (not above) the left and right border of the picture:-(
Any idea to fix it?
Thanks
Holger
P.S. Do you know an android app like Google Street View to create 360°x180° panoramas, but it doesn't create a panorama picture itself, but exports the taken single pictures to process them in other programs to a panorama picture?
Otherwise it is difficult to take all pictures for a 360°x180° panorama without gaps.
Some software tips to create panoramas would be great!

Well like I said, there will be a blank space between the image border.
That can't be handled on the current version, that why our panorama renderer should be updated.
I should work on it later, but I can't guarantee when it will be done.
So for now, I think the best you can do is simply modifying your image like I've done it above.
And, sorry but I don't really much know about Android apps for panorama.
I don't know which image format Google street view uses, but we support lots of projection types like you can see it on https://naver.github.io/egjs-view360/panoviewer.html#projections
So if they use one of our supported formats, I think you can choose that projection type than panorama projection type.
For our demo, we've used our 360 camera, so if you can afford it can be an option for you.

I should work on it later, but I can't guarantee when it will be done.

Hello WoodNeck,
Have you worked on this change yet?
I'm having the same problem, My image width is not 6 times of height, it's actually just 3.5 times of height, i.e., 10141 x 2741
How can I display the image without any white gap with continuous scrolling?
thanks,


Handle error.message() exception in getErrorMessage

Purpose
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/38609
https://github.com/ballerina-platform/ballerina-lang/issues/38609#issuecomment-1311312774
Approach
Trap the error coming from error:message() and return a string "No content" as the error message.
Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing since this is not an error that needs to be handled from the testerina side, rather a bug in the BError

Intended to solve https://github.com/ballerina-platform/ballerina-lang/issues/38609


CI: Add support for Python 3.11

Python 3.11 will be released in about a month, on 2022-10-24.

Problem
Code coverage report upload to Codecov intermittently fails. Example: https://github.com/crate/crate-python/actions/runs/3177244114/jobs/5177463683
[2022-10-03T20:30:53.977Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/Users/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Run codecov/codecov-action@v3
==> macos OS detected
https://uploader.codecov.io/latest/macos/codecov.SHA256SUM
==> SHASUM file signed by key id 806bb28aed779869
==> Uploader SHASUM verified (ccc032e70958ea3eca9bd15c7fdad5bbacc279c3bab22f227417573356569666  codecov)
==> Running version latest
==> Running version v0.3.2
/Users/runner/work/_actions/codecov/codecov-action/v3/dist/codecov -n  -Q github-action-3.1.1 -Z -C 6492325de0ce91500fa435a9f7e6afb27a579b2b
[2022-10-03T20:30:52.747Z] ['info']
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.3.2
[2022-10-03T20:30:52.772Z] ['info'] => Project root located at: /Users/runner/work/crate-python/crate-python
[2022-10-03T20:30:52.778Z] ['info'] -> No token specified or token is empty
[2022-10-03T20:30:52.830Z] ['info'] Searching for coverage files...
[2022-10-03T20:30:53.501Z] ['info'] Warning: Some files located via search were excluded from upload.
[2022-10-03T20:30:53.501Z] ['info'] If Codecov did not locate your files, please review https://docs.codecov.com/docs/supported-report-formats
[2022-10-03T20:30:53.502Z] ['info'] => Found 2 possible coverage files:
  coverage.xml
  .venv/bin/coverage-3.11
[2022-10-03T20:30:53.502Z] ['info'] Processing /Users/runner/work/crate-python/crate-python/coverage.xml...
[2022-10-03T20:30:53.540Z] ['info'] Processing /Users/runner/work/crate-python/crate-python/.venv/bin/coverage-3.11...
[2022-10-03T20:30:53.572Z] ['info'] Detected GitHub Actions as the CI provider.
[2022-10-03T20:30:53.574Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.1-uploader-0.3.2&token=*******&branch=amo%2Fpython311&build=3177244114&build_url=https%3A%2F%2Fgithub.com%2Fcrate%2Fcrate-python%2Factions%2Fruns%2F3177244114&commit=6492325de0ce91500fa435a9f7e6afb27a579b2b&job=Tests&pr=450&service=github-actions&slug=crate%2Fcrate-python&name=&tag=&flags=&parent=
[2022-10-03T20:30:53.977Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/Users/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Research
Others are observing the same issue. Apparently, https://codecov.io occasionally responds with 404 Not Found.

https://github.com/codecov/codecov-action/issues/557
https://github.com/codecov/codecov-action/issues/595
https://github.com/codecov/codecov-action/issues/598

Debugging
Trying different approaches like 67d63cc3f or 835f4bdab.


Request features

I know there are already issues created for these but they haven't seen any action for awhile and I want to make sure there is something recent about this. I know you are busy with real life things and you have no idea how much I appreciate your hard work on this plugin. This plugin alone is a major part of the server I assist in running and we are lacking several features just because we don't have multi world inventory support.
Can you make it so your plugin will save the players inventory to the worlds corresponding inventory on first world change. Right now, after loading your plugin the first time the player changes worlds (when your plugin begins to track the player) it will clear the players inventory for both worlds instead of importing the players inventory to the database for the world they are coming from.
Can you also add support for enderchest inventories, I cant create a creative or sky block inventory if the players can just add items to an enderchest to take them back to another world/inventory.

I think this may be bug. It's intended to act like that. I've made quite a few changes to the 6.0.0 branch that should have this fixed I think.
EnderChests are a planned feature, but would suggest disabling them for the time being using an item ban plugin. StackBan is a plugin of mine that can provide that.

6.0.0 branch? do you mean sponge api 6? If so will there be a release for api 5?
There are no errors in console for this either.

I have played with this multiple times, I can't seem to get the inventories to stay. They get wiped everything on first world change. I may be doing something wrong, I don't know. Any suggestions or do we want to call this a bug?

My players' inventories (and my own) do the same thing on initial world change but no issues after that. I have had a permanent warning to clear inventories before the first trip in my MOTD since I discovered it and lost a few things myself.

Should be resolved in latest release. EnderChests added as well


docs: license format and contributors

The license file differed enough that licensed did not recognize it.
The link to the contributors was also outdated.

Thank you.


Tests breaks after commits

If you run cargo test on your local mostro environment it passes all tests, but after each commit on github we always have this errors related with the sqlite database.
 error: error returned from database: (code: 14) unable to open database file
   --> src/db.rs:98:25
    |
98  |       let rows_affected = sqlx::query!(
    |  _________________________^
99  | |         r#"
100 | |     UPDATE orders
101 | |     SET
...   |
114 | |         order_id
115 | |     )
    | |_____^
    |
    = note: this error originates in the macro `$crate::sqlx_macros::expand_query` which comes from the expansion of the macro `sqlx::query` (in Nightly builds, run with -Z macro-backtrace for more info)

Hi @grunch ,
lookin quickly I think we need to use .env also in the repo. Look here:
https://docs.rs/sqlx/latest/sqlx/macro.query.html#requirements

Closing it via #37


Return correct querySelector/All value for falsies

Looks good to me :) would you be able to add a short test that checks for the empty array response? I think I already have tests around this so it shouldn't be hard to add an extra one.
Thanks!

The PR thinks there's a conflict for some reason, so I'm merging it manually and writing some tests. Thanks :)

Writing tests for this, it isn't required. The query selector implementation I use already returns an empty array if it doesn't match anything. Is this some edge case you found? Can you try out my master branch and let me know if it's okay? I made it so the querySelector function returns null when nothing is found though.

IIRC, this was for when selector === undefined || null. Might be better to fix this upstream?

Yep, realised that after the fact, I've tried it out in the browser and
replicated that functionality with tests now.
When nothing is found for querySelectorAll, it returns an empty array, as
you'd expect. If you do not pass a selector it throws an error, as per the
browser spec.
So if the selector is null or undefined it should throw. I thought that was
kind of weird, but still.
Also made querySelector return null if it doesn't match anything, not
undefined.
On 28 February 2016 at 14:27, Pedram Emrouznejad<EMAIL_ADDRESS>wrote:

IIRC, this was for when selector === undefined || null. Might be better
to fix this upstream?
—
Reply to this email directly or view it on GitHub
https://github.com/Olical/react-faux-dom/pull/39#issuecomment-189883499.


Remove documentation tag

The parameter does not exist.

Pull request checklist

[x] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[x] My changes should not be added to the release notes for the next release

[ ] Otherwise: I've added my notes to release_notes.md

[x] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[ ] I have added all required tests (Unit tests, E2E tests)

@vanillajonathan can you merge main into your branch? This change needs to be present to run the pipeline correctly. Thanks for the contribution!

@satvu done

/azp run extensions.storage.blobs.public

/azp run dotnet-worker.public

Thank you, @vanillajonathan


[Feature Request] Signals or Events on Shake completion

Hi there! Great plugin!
I was searching the code of the plugin for signals or events to determine when shake is finished. It seems there is none.
Could you add a signal for completion of the shake?

@Loregret Done!
// second optional parameter for onComplete callback
shakeDirector.Shake(yourNoisePreset, OnCompleteCallback);

I've updated the explosion demo too you can check it out.

@Hyrdaboo Fast as lightning! ⚡
Thanks!


Expose docker schema 1 image usage by adding a new label

What is the problem you're trying to solve
Containerd 2.0 will remove the support for docker schema 1 images. To facilitate the transition, I am looking for ways to better expose its usage. One idea I have is to add a new label to docker schema 1 image in containerd v1.X.
Describe the solution you'd like
Here is my proposed implementation.

We append a new label converted=dockerV1 if the image gets converted in https://github.com/containerd/containerd/blob/v1.7.2/pull.go#L276. In the fetch function, this can be easily determined.
Then, when the image metadata is stored, it will have that label so that ctr images can query it. https://github.com/containerd/containerd/blob/v1.7.2/pull.go#L285
CRI image pull calls client.Pull in https://github.com/containerd/containerd/blob/v1.7.2/pkg/cri/server/image_pull.go#L183

Additional context
The label name can be further discussed. I am open to suggestion.
If people think this is a good solution, I will create a PR.

cc @samuelkarp @SergeyKanzhelev @dmcgowan

I think such a label is reasonable if it can be added without too much intrusion. I'd suggest making the label something like containerd.io/converted-schema1=<schema 1 digest> or something like that.

I think such a label is reasonable if it can be added without too much intrusion. I'd suggest making the label something like containerd.io/converted-schema1=<schema 1 digest> or something like that.

@dmcgowan Thank you. I think the digest shouldn't be necessary as ctr images already outputs it.
The current label is io.cri-containerd.image=managed (if this is pulled by CRI plugin).  So how about io.containerd.image/original-schema=docker-schema-1 ?
I will create a PR soon.

@qiutongs where is the schema 1 digest shown today? I thought we only showed the converted manifest digest rather than the original.

@qiutongs where is the schema 1 digest shown today? I thought we only showed the converted manifest digest rather than the original.

Sorry, you were right. I talked about the post-conversion digest. I agree we can add the pre-conversion digest here. Maybe the label key containerd.io/converted-docker-schema1.
Say users do crictl pull. The output of ctr images ls will look like
REF: docker.io/progrium/stress:latest
TYPE: application/vnd.oci.image.manifest.v1+json
DIGEST: sha256:fe33932960bfb41cab97a147e7c38e0c787424dd374deba976dd6e9803fb3666
SIZE: 86.5 MiB
PLATFORMS: linux/amd64
LABELS: containerd.io/converted-docker-schema1=sha256:e34d56d60f5caae79333cee395aae93b74791d50e3841986420d23c2ee4697bf,io.cri-containerd.image=managed

Please take a look at the PR. It is pretty lightweight.


trouble in pmag_gui

What command was run:
pmag_gui.py -WD .
then clicked on 1. Convert magnetometer files....
What happened:
nothing!
What I expected to happen:
I expected the dialog gui to come up with options for file conversion
Data file(s):
Screenshot(s):
(base) ltauxe:$ pmag_gui.py -WD .
-I- Importing Pmag GUI dependencies
-I- Starting Pmag GUI - please be patient
-I- Read in any available data from working directory
-I- Using online data model
-I- Getting method codes from earthref.org
-I- Importing controlled vocabularies from https://earthref.org
then - nothing!
PmagPy version:
pmagpy-4.2.71

The current master of pmag_gui.py works for me. Just pulled and then ran pmag_gui.py
Here is a screen shot of the terminal and the pop-up after converting one of Ken's files.

I think that I fixed this issue with commit 177b4f8
In that commit, I commented out the last line of on_convert_file() function which had a self.hide() command  for some reason.
 def on_convert_file(self, event):
        pmag_dialogs_dia = pmag_gui_dialogs.import_magnetometer_data(self, wx.ID_ANY, '', self.WD)
        pmag_dialogs_dia.Show()
        pmag_dialogs_dia.Center()
#        self.Hide()

I will close the issue for now, but do reopen if issues are persisting.


initial attempt at top events component

Issue #11

@suvasan19 I think I'm confused where this one is at (based on the conflicts). Is this PR still relevant?

Don't worry, I'll take a look. Definitely a component worth keeping. I'll deal with the conflicts and merge 👍


how to start apscheduler in django

I want to start apscheduler when django start

See this issue.
https://github.com/jarekwg/django-apscheduler/issues/3


16 import git bob

Is git-bob working now?
git-bob comment

@lea-33 git-bob may only respond if the workflow is configured on the main branch of the repository

git-bob comment if this is working now


Create folder structure and file hierarchy

Ideas:

helper functions need their own file/library
index that is actually an index that maps to...
a viewer page or
a editor page both
with their own directories

I feel like this is kind of self explanatory. See javascript and html standards.

Currently there the scripts are named after the html pages, but the styles are just all in one. This may get more abstracted as time goes on, but for the time being it works and the codebase is actually shrinking.


Typo on Manifesto page

The manifesto page heading contains a typo:  Mainfesto instead of Manifesto.

See https://github.com/usebruno/bruno-website/blob/a592ed0caf62c5f3c7b8e20836ba7f941ce97c66/src/pages/manifesto.js#L20 for the line that needs to be corrected

Fixed in https://github.com/dcoomber/bruno-website/commit/f86fe14a4724798149ba74e86d0f766cc626bebf

Thank you, @helloanoop


Fix: ensure correct handling of mtable in LaTeX output

The original code may mistranslate the  tag. I fixed the issue by using array{ccc} to express the final output, and it should be able to translate to Latex correctly now. I also add a few tests to prove that.

Although it can translate correctly, the new update code fails to pass a few tests involving the  tag, which may have already been removed from the relevant web standards. So, any comment or recommended approach to fix the issue?

Hi, @yuxuan-wei118. Thanks for your contribution! However, the issue is not clear to me. Besides the test you added, could you provide some examples of input, the expected result, and the result before the changes, highlighting the broken/missing part? I would like to understand the problem a little better.

Hi @asnunes. Thank you for your reply! One mistranslating example is the code below.
<math display="block">
  <mfrac>
    <mi>A</mi>
    <mn>2</mn>
  </mfrac>
  <mo>=</mo>
  <mrow>
    <mo>(</mo>
    <mtable>
      <mtr>
        <mtd><mn>1</mn></mtd>
        <mtd><mn>2</mn></mtd>
        <mtd><mn>3</mn></mtd>
      </mtr>
      <mtr>
        <mtd><mn>4</mn></mtd>
        <mtd><mn>5</mn></mtd>
        <mtd><mn>6</mn></mtd>
      </mtr>
      <mtr>
        <mtd><mn>7</mn></mtd>
        <mtd><mn>8</mn></mtd>
        <mtd><mn>9</mn></mtd>
      </mtr>
    </mtable>
    <mo>)</mo>
  </mrow>
</math>

The expected result should be that:

However, the original code will translate the input into the following:

which is an illegal syntax missing \begin{array} {ccc} and end {array}.
Please feel free to give more comments!

Hi @asnunes.

For the first concern, I think we should change code to make these tests pass.

For the second issue, the addition of hspace aims to address any possible additional formatting syntax that may appeared in mtable tag.

Here is an example mathml code that you can see mtable may include additional formatting syntax:
 <math xmlns="http://www.w3.org/1998/Math/MathML"><mtable columnwidth="3em 0.05em 3em 3em 3em 3em" columnspacing="0.0em" rowspacing="0.05ex" rowlines="solid" columnlines="solid" frame="solid" framespacing="0.0em 0ex"><mtr><mtd><mi>x</mi></mtd><mtd><mspace width="0.0em" height="2.5ex" depth="1.0ex"/></mtd><mtd><mo>−</mo><mn>1</mn></mtd><mtd><mn>0</mn></mtd><mtd><mn>1</mn></mtd><mtd><mn>2</mn></mtd></mtr><mtr><mtd><mi>g</mi><mrow><mo>(</mo><mi>x</mi><mo>)</mo></mrow></mtd><mtd><mspace width="0.0em" height="2.5ex" depth="1.0ex"/></mtd><mtd><mn>6</mn></mtd><mtd><mn>4</mn></mtd><mtd><mn>2</mn></mtd><mtd><mo>−</mo><mn>1</mn></mtd></mtr><mtr><mtd><msup><mi>g</mi><mo>'</mo></msup><mrow><mo>(</mo><mi>x</mi><mo>)</mo></mrow></mtd><mtd><mspace width="0.0em" height="2.5ex" depth="1.0ex"/></mtd><mtd><mo>−</mo><mn>1</mn></mtd><mtd><mo>−</mo><mn>7</mn></mtd><mtd><mo>−</mo><mn>2</mn></mtd><mtd><mo>−</mo><mn>3</mn></mtd></mtr></mtable></math>
Adding hspace makes the output Latex code closer to the intended format given by mathml. But it is also true that it may be redundant in some cases.

For the third issue, we can do this after resolving all issues above.

Please feel free to give more comments!


Distribute prebuilt arm macos dora-rs

Adding ARM64  macOS distribution as it is an easy platform for developing arm based application.
This feature was requested by @bobd988

@bobd988 , I have precompiled a macOS Aarch64 version available in pre-release here: https://github.com/dora-rs/dora/releases/download/v0.2.4-rc2/dora-v0.2.4-rc2-aarch64-macOS.zip, can you look if there is any issue?

This has been tested on Mac M1 thanks to @bobd988


what does the array [0, -0.005, 0.16] mean?

I want apply MujocoController with kinova jaco2, then got trouble in open_griper(). robot run wrong.In the function move_group_to_joint_target() in MujocoController,  there is temp = self.sim.data.body_xpos[self.model.body_name2id('ee_link')] - [0, -0.005, 0.16]. so i want to know what does  [0, -0.005, 0.16]  mean to UR5?

Hi,
I just used this temp variable to calculate the rough position where the grippers fingers would touch each other when the gripper closes. I then used this to display a marker in the rendering. It is purely for visualization purposes, the idea was that I can see which height above the table the agents are "targeting".


Fix linting errors in templates.

This fixes all the lint issues in templates (demos).

Closing this PR since now we are taking a whole different approach.