BlockHeading not displaying introduction

The BlockHeading.cshtml partial view does not display the introduction if set.
This is because the view is calling HasValue  instead of Value method to display the content
@if (hasIntroduction)
{
        @content.HasValue("introduction");
}

Hi @PeeDeeWhite,
Many thanks for your PR!
This has been merged and will be published to NuGet soon in version 1.1.5

HI Aaron,
You're more than welcome and thank you for a great starter kit and UmbCheckout.
Regards
Paul

From: Aaron @.>
Sent: Tuesday, December 17, 2024 4:50 PM
To: UmbHost/UmbCheckout.StarterKit.Stripe @.>
Cc: Paul D White @.>; Mention @.>
Subject: Re: [UmbHost/UmbCheckout.StarterKit.Stripe] BlockHeading not displaying introduction (Issue #15)
Hi @PeeDeeWhitehttps://github.com/PeeDeeWhite,
Many thanks for your PR!
This has been merged and will be published to NuGet soon in version 1.1.5
—
Reply to this email directly, view it on GitHubhttps://github.com/UmbHost/UmbCheckout.StarterKit.Stripe/issues/15#issuecomment-2549013220, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFQLGER576ARGOI56XE7XVD2GBI65AVCNFSM6AAAAABTYQ2FJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGAYTGMRSGA.
You are receiving this because you were mentioned.Message ID: @.***>


test(validation): add GovernedByOptimismTest

Description
This PR adds the GovernedByOptimismTest test to the validation package, which ensures that any chain which has the governed_by_optimism field set to true in its config also has its ProxyAdmin address set to the Optimism multisig.
This change was broken out into a separate PR from #718 to allow for the validation/go.mod file to reference the new superchain module version.
Metadata

In service of: #676
Depends on:

#717
#718

This change was broken out into a separate PR from #718 to allow for the validation/go.mod file to reference the new superchain module version.

I'm not sure I follow you. IIRC because this repo uses a go.work file, all the modules should reference the local files anyway.

See my comment here https://github.com/ethereum-optimism/superchain-registry/pull/718#issuecomment-2505848103 we already have a "key handover test"  and I would like to understand how this new test relates to that one.

This change was broken out into a separate PR from #718 to allow for the validation/go.mod file to reference the new superchain module version.

I'm not sure I follow you. IIRC because this repo uses a go.work file, all the modules should reference the local files anyway.

good point, I wasn't familiar with go.work, I'll merge the PRs to reflect this.


spelling

just a note that I think we'll have to use American spelling...

I've changed spelling to American English


organism.delete_features does not work: Can not find organism for null to remove features of

Hi,
Thank you for the nice Apollo client.  Most features work as expected.
I am having trouble to delete all genes/transcript features from an organism from the relational database:
connection.organisms.get_organisms()
{'annotationCount': 22979,
  'blatdb': None,
  'commonName': 'unit_test_organism',
  'currentOrganism': True,
  'directory': '/data/qa/Tools/apollo/2.0.6/unit_test_organism/data',
  'genus': None,
  'id': 40,
  'publicMode': False,
  'sequences': 7,
  'species': None,
  'valid': True}

See my commands to try to delete all genes/transcript features for
>>> connection.organisms.delete_features(40)
{'error': 'problem removing organism features for organism: java.lang.Exception: Can not find organism for null to remove features of'}
>>> connection.organisms.delete_features('40')
{'error': 'problem removing organism features for organism: java.lang.Exception: Can not find organism for null to remove features of'}
>>> connection.organisms.delete_features("unit_test_organism")
{'error': 'problem removing organism features for organism: java.lang.Exception: Can not find organism for null to remove features of'}

The code in the apollo client posts a json where a value is set for the ID field.
https://github.com/galaxy-genome-annotation/python-apollo/blob/master/apollo/organisms/__init__.py#L152
The server side code seems to expect the a json where a value is set for the Organism (common name) field.
https://github.com/GMOD/Apollo/blob/master/grails-app/controllers/org/bbop/apollo/OrganismController.groovy#L177
I guess this is where it might go wrong. The client and server side code don't use the same field in the json object?
Is it by the way correct that deleting an organism (using the API method deleteOrganism ) includes the deletion of all features from the relational database?
Thank you.

yep, you're absolutely right, that should be corrected to 'organism' instead of 'id'.
I'll get a patch out when I'm back from holiday.
I am under the impression that you cannot delete an organism without deleting all of the features first. (If my memory of the UI popup is correct.)

Ok thank you. I look forward to the patch.

I don't have a test server running at this minute, I hope this fixes it for you though!

Ok thank you. I will let you know if it works. Might take a few days.
I need to upgrade our pypi installed python-apollo client via github I guess?

A new tag has been pushed which should appear on pypi shortly.


expose highest chip temperature

Is your feature request related to a problem? Please describe.
On the BraiinsOS UI there is a "Temperature (Chip)" which takes the highest chip temperature, pyasic only exposes the individual chip temperatures, making it a bit hard to easily get the highest chip temperature
Describe the solution you'd like
it would be great if pyasic returns the highest chip temperature
Describe alternatives you've considered
I could do this also in HomeAssistant but I feel it's easier in pyasic as the way that temperature is reported could be different per miner type

I could do this as part of miner data, but it seems possibly redundant?
Would it be better to just use max + a list comp (max([hb.chip_temp for hb in data.hashboards]))?


Hide actionbar checkbox in Base class

The Action bar check box for deleting videos had to be hidden in each activity where not required. This has been moved to the base class.
@nasthagiri @rohan-dhamal-clarice - Please review.

:+1:

I merge this.


Slider Improvements

Respect label_precision also on the tick labels
Allow updating min, max and value

This looks great. I will go ahead and merge it. I might do some testing today, so maybe you can add an example for this ticks stuff into the https://github.com/ctron/patternfly-yew-quickstart repository. That would make it easier to test and showcase the new feature.

Ok, i will put it on my tasklist, but next weekend I will have no spare
time.
In between you can find a working example here:
https://github.com/koa/feeds-and-speeds/blob/main/src/main.rs
It is deployed here: https://speed.berg-turbenthal.ch/
Am Mo., 6. März 2023 um 10:06 Uhr schrieb Jens Reimann <
@.***>:

This looks great. I will go ahead and merge it. I might do some testing
today, so maybe you can add an example for this ticks stuff into the
https://github.com/ctron/patternfly-yew-quickstart repository. That would
make it easier to test and showcase the new feature.
—
Reply to this email directly, view it on GitHub
https://github.com/ctron/patternfly-yew/pull/33#issuecomment-1455745987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGA3CSHIU3YTAA3YAI6DLW2WSLHANCNFSM6AAAAAAVPMA5MY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Cool, no worries, maybe I will try it out in the meantime :)
Thanks for sharing the demo!


Remove MediaPicker from iOS code

It would be nice to add a handful of songs to test the player with.

I can find some Creative Commons songs in various formats for testing if you want !

It'd be wonderful


API key is invalid

Getting This error, what API key is it saying is invalid?
I copied the API keys for sonarr and radarr so they can not be wrong?
2021/03/24 15:52:41 Unpackerr v0.9.0 Starting! (PID: 1) 2021-03-24 15:52:41.518630699 +1000 AEST m=+0.000403423
2021/03/24 15:52:41 [ERROR] provided application API Key is invalid, must be 32 characters:
2021/03/24 15:52:41 Unpackerr v0.9.0 Starting! (PID: 1) 2021-03-24 15:52:41.518630699 +1000 AEST m=+0.000403423
2021/03/24 15:52:41 [ERROR] provided application API Key is invalid, must be 32 characters:

Does it show the API key after the : or is it blank? If it's blank, it means you have extra configuration without a key defined. Can you share your config? xxxx out your api keys

i am using unraid
[image: image.png]
On Wed, Mar 24, 2021 at 3:58 PM David Newhall @.***>
wrote:

Does it show the API key after the : or is it blank? If it's blank, it
means you have extra configuration without a key defined. Can you share
your config? xxxx out your api keys
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davidnewhall/unpackerr/issues/110#issuecomment-805524114,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2TS42FDI3ZJBVJT2TOWQLTFF5Q5ANCNFSM4ZWSPJZQ
.

Hi, I have the same issue and I only have Lidarr not set up, meaning the API key field is empty.

i am using unraid

Try removing the unused URLs. WOrst case, delete those values entirely, but I think blanking them out should work too.

I removed the lidarr url and got this error

Remove the download path too. Anything that starts with UN_LIDARR needs to be blank if you're not using it.

Didn't realize this change would cause so much trouble. Previously there was no validation on these fields and the errors would pop up after a minute or two. I wanted the errors to surface sooner. and here we are.

I also use unraid, but I've customized my template, and I have all four starr apps configured, so I never hit this...

there is not a download path for lidarr

If I leave it as is

it goes back to this error

Yeah I'm reproducing this. There are two fixes: change your tag back to an earlier version or delete the sections you do not use. I'm working on a fix now and I'll publish a new release shortly.

what is the earlier version tag?
how do i change that?
I've never had to before

Change the repository from golift/unapckerr to golift/unpackerr:0.8.0-beta3

also thank you for your quick response

Please test the golift/unpackerr:apifix tag. Once I get confirmation this fixes it, I'll make a 0.9.1 release.

the apifix seems to work no errors.

Thank you!

you are welcome, please let me know when I can change my repository back please.

Give it about 10-20 minutes for Docker to build the latest tag. I'm drafting the release now.

is this correct? golift/unapckerr:latest

In docker word, these two things are equal:  golift/unapckerr:latest and golift/unapckerr - either one gets the same thing.

ok, thank you again for your quick fix


Add ISSUE_TEMPLATE.md

Let's see if this issue template helps.  If not, we can change or remove it in a few weeks.
There's lots more it could say, but I want to keep it concise.
Fixes #4443

:+1:  thanks @pjcozzi!  I think this will make a difference

@pjcozzi please add a separate pull request that ignores this file from both the release zip and adds it to npmignore.  Thanks.

Looks like it is not part of the zip, but it does need to be in npmignore.

See #4478 for npmignore


fix: LEAP-381: Remove excess regexp from BEM module monorepo

Hi @hlomzik!
This PR was created in a response to PRs in upstream repos:

https://github.com/HumanSignal/label-studio-frontend/pull/1648

closing this as monorepo was merged to develop branch


Feature/jenkins example

Phase 1 and phase 2 of the tool tester which runs on Jenkins server.

Coverage increased (+42.6%) to 82.306% when pulling 611e74bee3bc76c28d289ec756eed986f896a4c8 on feature/jenkins_example into 610106971caaf9560fc45688bc2c5bd2017efbed on develop.

Coverage increased (+29.1%) to 68.794% when pulling 32f7da30447f0e1e119c69117f5d61ae67e0e76c on feature/jenkins_example into 610106971caaf9560fc45688bc2c5bd2017efbed on develop.

Coverage increased (+29.09%) to 68.777% when pulling f71b0e58d97807039809a2f65230d59740b7d2fe on feature/jenkins_example into 610106971caaf9560fc45688bc2c5bd2017efbed on develop.

Coverage increased (+29.2%) to 68.921% when pulling c2215ccba4927a3a8d2a11a31a233ae63ce4a080 on feature/jenkins_example into 610106971caaf9560fc45688bc2c5bd2017efbed on develop.

Coverage increased (+30.1%) to 69.784% when pulling f9e3ef5242dcb7e8df02d6f200473ceeae423861 on feature/jenkins_example into 610106971caaf9560fc45688bc2c5bd2017efbed on develop.

Once this pull request is complete, I'll create another pull request for the Blue Ocean update.


Add a category for polygonid VC in mywallet

Polygon credentials
Discover : (initialisé mais vide et donc non montré)
Title: Get Polygon ID credentials
Subtitle: Prove your access rights in the Polygon ecosystem
My wallet :
Title: My Polygon ID credentials
Subtitle: Prove your access rights in the Polygon ecosystem


test custom attributes for route must be available in request attributes

I think this test may actually fail. I'm not a able to retrieve route attributes $router->map(...)->setVars(['a'=>'b']) in middlewares

Sorry. I found my fault


snowflake_table_column_masking_policy_application id has extra escape characters

Hello 👋
terraform version: 1.1.5
snowflake provider version: 0.63.0
The snowflake_table_column_masking_policy_application resource has added extra escape characters.
We have a resource that looks like this:
resource "snowflake_table_column_masking_policy_application" "application" {
  table          = "DATABASE.SCHEMA.TABLE"
  column         = "COLUMN"
  masking_policy = "DATABASE.SCHEMA.POLICY"
}

And without any relevant changes, we're seeing this show up in all our plans now.
-/+ resource "snowflake_table_column_masking_policy_application" "application" {
      ~ id             = "\"DATABASE\".\"SCHEMA\".\"TABLE\".\"COLUMN\"" -> (known after apply)
      ~ masking_policy = "DATABASE.SCHEMA.POLICY" -> "\"DATABASE\".\"SCHEMA\".\"POLICY\"" # forces replacement
      ~ table          = "\"DATABASE\".\"SCHEMA\".\"TABLE\"" -> "DATABASE.SCHEMA.TABLE" # forces replacement
        # (1 unchanged attribute hidden)
    }

@liamjamesfoley Hitting the same issue with 0.66.1.

@jrobison-sb Is this the same issue as yours?
https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1677

@liamjamesfoley probably? mine was for a different resource type, but under the hood they might both be passing through the same code paths. They look similar, at least.
FWIW we have since upgraded to 0.67.0 and whatever problem we had with weird string escaping kind of just resolved itself.

🤦 Didn't even notice it was a different reouce. Whoops! Thanks for the quick reply.

Same issue in the latest version 0.73.0 :(. This forces the re-creation of the policy_application resource every time we apply

Same here, on v0.96.0. See also #2236.

Hi all 👋
This is caused by the legacy parsing of object identifiers in this resource. We'll address this during table rework, which will happen before v1.

Hi @sfc-gh-jmichalak this is still hanging around on V1.0.0, even using fully_qualified_name from the Masking policy resource.
Module:
resource "snowflake_masking_policy" "masking_policy" {
  name     = var.name
  database = var.database
  schema   = var.schema
  argument {
    name = "VAL"
    type = var.value_data_type
  }
  comment               = var.comment
  body                  = var.masking_expression
  return_data_type      = var.return_data_type
  exempt_other_policies = "false"
}

resource "snowflake_table_column_masking_policy_application" "application" {
  for_each = { for each in var.columns :
    # Make sure resource name is unique
  join("_", [replace(each.qualified_table_name, ".", "_"), each.column_name]) => each }
  table          = each.value.qualified_table_name
  column         = each.value.column_name
  masking_policy = snowflake_masking_policy.masking_policy.fully_qualified_name
}

Example resources:
module "example_masking_policy_3" {
  source             = "./stack/snowflake/masking-policy"
  name               = "EXAMPLE_MASKING_POLICY_3"
  database           = "OPERATION_DB"
  schema             = "SECURITY"
  value_data_type    = "VARCHAR"
  return_data_type   = "VARCHAR"
  masking_expression = "case when current_role() in ('ACCOUNTADMIN') then val else sha2(val, 512) end"
  columns = [
    {
      qualified_table_name = "\"DROP_ME\".\"FAKE_SCHEMA\".\"TEST\""
      column_name          = "TEST"
    }
  ]
}

TF Plan:
Terraform will perform the following actions:

  # module.example_masking_policy_3.snowflake_table_column_masking_policy_application.application["\"DROP_ME\"_\"FAKE_SCHEMA\"_\"TEST\"_TEST"] must be replaced
-/+ resource "snowflake_table_column_masking_policy_application" "application" {
      ~ id             = "\"DROP_ME\".\"FAKE_SCHEMA\".\"TEST\".\"TEST\"" -> (known after apply)
      ~ masking_policy = "OPERATION_DB.SECURITY.EXAMPLE_MASKING_POLICY_3" -> "\"OPERATION_DB\".\"SECURITY\".\"EXAMPLE_MASKING_POLICY_3\"" # forces replacement
        # (2 unchanged attributes hidden)
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Hi all, reworked tables and masking policy applications are not a part of v1 (they are still available as preview resources). We are sorry about that. Reworking tables and related resources is high on our priority list and will be done early next year.
For now, please use one of the following workarounds:

(Recommended) Use ignore_changes meta argument. Note that no changes in this field will be detected (including external).
Adjust the quoting manually in your configurations. This means using the value on the right side of the diff in your configuration files.


'random mutagenesis evidence' vs. 'induced mutation evidence'

This issue stems from #174.
Hi @ivanerill and @pgaudet,
In reviewing the 'experimental phenotypic evidence' branch I have questions about a two similar terms that I am hoping you might be able to answer.  The terms are 'random mutagenesis evidence' and 'induced mutation evidence'.
'random mutagenesis evidence':
A type of experimental phenotypic evidence where radiation or a DNA-damaging agent in vivo, or PCR with degenerate primers in vitro, are used for non-targeted mutagenesis.
'induced mutation evidence':
A type of genetic transformation evidence resulting from a mutation induced by a mutagenic compounds or irradiation.
Are these terms really meant to be distinct?

Both terms imply or state an intentional attempt to cause/induce mutations.  Is this a correct assumption?

'random mutagenesis evidence' implies that the position of the mutation within the genome is random (as opposed to specifically targeting a region), while 'induced mutation evidence' does not state whether the mutations are random or targeted.  Is there supposed to be a difference?

As a child of 'genetic transformation evidence', 'induced mutation evidence' inherits from the parent definition "...resulting from the conversion of one genotype into another by the introduction of exogenous DNA.", i.e. in addition to a mutagenic compound or radiation, exogenous DNA is involved.
-- Is 'induced mutation evidence' supposed to imply the introduction of exogenous DNA?
Is this the original intent of the term that DNA originating from outside the organism is introduced?
-- If not, shouldn't this term be a child of 'mutant phenotype evidence'?

Is there perhaps a better term for 'random mutagenesis evidence'?
To me it sounds very much like "random mutation" which conveys the idea that the mutations (point mutation, nonsynonymous mutation, etc.) occur at any random position in the genome and that such mutations are not intentional or "guided" - mutations occur "naturally". As noted above, 'random mutagenesis evidence' seems to intentionally induce mutations.

Should 'random mutagenesis evidence' be moved from 'experimental phenotypic evidence' to 'mutant phenotype evidence'?  Currently there is no mention of observing the phenotypic expression of a mutation but am I correct in assuming that this was the intent?

Thanks.
James

Hi James,
I think the two terms are indeed the same. I would merge.

Should 'random mutagenesis evidence' be moved from 'experimental phenotypic evidence' to 'mutant phenotype evidence'? Currently there is no mention of observing the phenotypic expression of a mutation but am I correct in assuming that this was the intent?

Yes I think so. I wanted to add more structure to the terms we had requested a few years back, but we never got to it.
Thanks, Pascale

Hi @jbmunro ,
I would probably opt to keep them separate, but with a re-write.
I agree that given its inheritance from "genetic transformation evidence" ECO:0005027, the current wording of "induced mutation evidence" ECO:0001056 does not make a lot of sense. But there are techniques wherein researchers do introduce exogenous DNA to induce mutations, such as transposon mutagenesis and the derived Transposon sequencing (Tn-seq). These techniques, beyond causing knockouts, often incorporate markers or reporters, so they are bona fide "genetic transformation". I believe ECO:0005027 should capture these. Alternatively, you can merge the two existing terms as proposed (for compatibility with existing annotations) and add a new branch for the transposon mutagenesis-like terms.
I would also split 'random mutagenesis evidence' ECO:0005529 to differentiate between in vivo (e.g. radiation) and in vitro (e.g. PCR) protocols. Several reasons for this. The in vitro protocol requires that the mutated fragment be cloned back into the target organism. It also targets a specific DNA fragment, so it is not "random" in the same sense than irradiating a cell and hitting any segment of DNA.
Cheers,
Ivan

Right, I was thinking that after I wrote the comment. I think random mutagenesis is done by PCR, with an inbalanced pool of nucleotides. The definition is confusing, we should remove ' radiation or a DNA-damaging agent in vivo'.
Thanks, Pascale

Hi @pgaudet and @ivanerill
Thank you both for the advice!  I'll get to work on this and touch base with everyone.
James

Hi @ivanerill and @pgaudet
Here is an update from our discussions.  Your thoughts and suggestions are welcome.
James
Obsolete term: induced mutation evidence
This term will be made obsolete for a couple of reasons: the def doesn’t make sense as the suggested means of mutagenesis fail to introduce exogenous DNA (it is a child of genetic transformation evidence) and the def. is too much like random mutagenesis evidence.
Update term: random mutagenesis evidence -> random mutagenesis phenotypic evidence
old def.: A type of experimental phenotypic evidence where radiation or a DNA-damaging agent in vivo, or PCR with degenerate primers in vitro, are used for non-targeted mutagenesis.
new def.: A type of mutant phenotype evidence where a mutagenic product or process is used to alter the nucleotide sequence and thus induce genetic mutation.  Examples include, but are not limited to mutagenic compounds, irradiation, PCR w/ degenerate primers, etc.
narrow syn.: random mutagenesis evidence
New term: random mutagenesis of specific target DNA evidence
new def.: A type of random mutagenesis evidence resulting from the random mutation of a specifically targeted region of DNA.
Ivan’s point about transposon sequencing and especially transposon mutagenesis, sparked a lot of discussion: it can be random or site-specific, it is indeed a type of ‘genetic transformation evidence’ as exogenous DNA is introduced, yet a second (inferred) parent could be ‘random mutagenesis evidence’ or ‘random mutagenesis of specific target DNA evidence’, etc.  However, after much deliberation, we decided that transposon mutagenesis and Tn-seq are more of a protocol/technique and the actual type of evidence - that upon which an assertion is based - can vary greatly. (Additionally, we are striving to focus on evidence rather than protocol.)
For now, we have decided not to add any transposon-related terms and to address this issue in the future should a request for such terms arise.

Sounds good to me.

Sounds good to me too, thanks !

Thank you!
Proposed changes made and pushed to GitHub.  Closing this ticket.
James


[VS Code] Live Share extension failed to initialize, try to reload the VSCode window and try again.

<!--
For Visual Studio problems/feedback, please use the Report

Thanks for reporting the issue. Can you please run the command "Live Share: Export Logs" and drag-and-drop the zip here or send it to<EMAIL_ADDRESS>

I'm going to resolve this bug as a dupe of #873.
Anyway, if you can get the log, please post it either here or to #873. Your issue may have a different root cause.


doc: write release notes for Go 1.21

This is the tracking issue for writing the Go 1.21 Release Notes. The version at tip can be viewed at https://tip.golang.org/doc/go1.21.
When the Go 1.21 Release Notes are complete, this should be closed, and a similar issue should be made for the next release. Previous issues are https://github.com/golang/go/issues/54202, https://github.com/golang/go/issues/51400, https://github.com/golang/go/issues/47694, https://github.com/golang/go/issues/44513, etc.

Reopening (due to #29599).

Reopening a second time (due to #21312). 😮💨

Writing down a few of the known remaining tasks needed to close out this release-blocking issue:

[ ] resolve a go/types TODO still visible at https://tip.golang.org/doc/go1.21#go/types

https://go.dev/cl/513475 resolves it and needs to be submitted

[ ] review any open CLs that are updating doc/go1.21.html (https://go-review.googlesource.com/q/path:doc/go1.21.html+status:open+-label:Hold%3D%252B1)
[ ] move doc/go1.21.html from main Go repo to x/website/_content/doc (like CL 464075 and CL 464055 did it for 1.20 release notes)
[ ] run relnote for the last time to find out whether any additional changes have been flagged for release notes
[ ] on release day itself, delete the "Go 1.21 is not yet released. These are work-in-progress release notes. Go 1.21 is expected to be released in August 2023." notice (this is in scope of the go1.21.0 release process itself)

The CL removing that draft notice will also mark this issue closed.

Backlink to TODO list at https://github.com/golang/go/issues/58645#issuecomment-1662611308 since otherwise it gets lost in the "hidden items".


ci: add filename linter

Adds Github workflow to lint filenames. Testing if Action will post results to this PR.

Force commit = Rebase integrating latest main branch commits


Additional scene component is created if C# script doesn't have a default scene root

I believe this commit (https://github.com/UnrealSharp/UnrealSharp/commit/00fd3d09593a38d03129fabe284bab0b17887144) is causing the behavior. Create a BP and inherit from character. Create a C# script as a child of ACharacter. Don't have the root component set in the script and then reparent the BP to the new C# parent. A new DefaultSceneRoot component is created (although, not at the root)

fixed with 3b96972ddf63f6a7c7c8b47c134680c88d3370b3


upgraded lodash version 4.17.15 to 4.17.20 to fix reported issue

What:
Looking to update lodash from version 4.17.15 to 4.17.20 to fix https://snyk.io/test/npm/lodash/4.17.15
Why:
Upgrade to a version without the know vulnerability

Thanks, we don't lock the dependency so the existing version range will already install this version. Rebuild your local lockfile if you're getting warnings with your security tool


Make the navbar for mobile

The Navbar responsiveness on mobile

@landry when you touch on section to be redirected it fails and reload the website


[Do Not Merge / Proposal ] Enable Search With lunr.js

Lunr.js allows us to power a client-side search.

No ads from google
Runs completely on the client side
Allows your users to quickly search for blog articles based on keyword search

@jph00 what do you think?  If this is too much feature bloat, let me know as well.  Maybe getting too excited / carried away.  Edit: see the preview link to preview the search preview

/preview

@jph00 incase you are reading this via email the search can be previewed via this link: https://5e52e678fa14ebe98cc91602--fastpages.netlify.com/search/

It looks amazing. @sgugger I suspect we should use this in nbdev (not urgent though) - what do you think?
@hamelsmu is the index built automatically on push?

Yes the index is built on jekyll build so it will happen automatically on push

@xnutsive thanks for the feedback.  I am a total js/html/ruby etc. noob so I will give it my best shot and see if I can move things around etc.  I will admit I found this solution on the internet and just mindlessly followed the instructions :), so bear with me as a fumble through this - good suggestions

@xnutsive actually have another question
I was looking at this Jekyll site called Just The Docs, and they also build their search on lunr.js.  However their search is really, really fancy looking with keyword highlighting etc.
Here is the Just The Docs repo.  I have been too dumb to try to replicate their functionality despite hacking on it for about an hour, perhaps you can take a look and let me know if you see an easy path to borrow what they have?
Thanks for your help

Summary of changes made

moved lunr js file into /assets/js/vendor
bumped version of lunr from 2.1 to 2.3 and using a minified file instead
moved css from search page into main css file
removed seperate includes page for search since there is only one search page

/preview

/preview

I made all the requested changes since everyone has approved this PR I'll go ahead and merge.

Almost missed it! Thanks for the link — there are a few interesting things with Just the Docs, I'll go ahead and do another issue with those.


Incorrect print color

I have a asp Label with class "text-success".
When I am trying to print this page, all text just comes in black. There are no other classes I added to this label.

Duplicate of #14313.


Integration with conda-forge

Just wondering is there any plans to optionally run conda-press as part of conda-forge CI?
The issue is that as long as a separate CI needs to be setup for each platform (#40) the effort to build wheels (e.g. with the setup from https://github.com/MacPython) is not that much higher than setting up CI for conda-press (well at least for not too complicated projects).
To run it as part of conda-forge I imagine it would be necessary to change the CI scripts and add some optional flag to meta.yaml.
Then wheels need to be uploaded somewhere: maybe an S3 bucket or possibly we could use the same account (different bucket) that is provided for free by Rackspace for the wheels built in MacPython org.
Another point is that conda-press might need to be adapted to work for locally built packages that are not yet uploaded to a conda channel.

Hi @rth ,
We do have some plans do integrate it with conda-forge.
I was working with it, I stopped a bit just to work on pytest-replay and to add some infra in conda-build which I saw more urgency let's say.
But I will get it right before it. It is on my to-do list. I just need to add one more functionality to conda-press to recursively get the conda packages and after that, the integration with conda-smithy will be easy and we can optionally add it.
The original idea was to add a conda-press.yaml on the feedstock root, if it is present it will run conda-press with the options in there, we can also develop some features to upload it somewhere (I didn't think that careful yet).
I just did some very simple tests in this PR (that is just for Linux):
https://github.com/conda-forge/conda-press-feedstock/pull/7

Just regarding the last part

Another point is that conda-press might need to be adapted to work for locally built packages that are not yet uploaded to a conda channel.

What do you mean?
The dependencies? Because you can convert it locally, you just have to pass the path to the conda package

Great, good to know @marcelotrevisani !

Just regarding the last part

It was a guess, I am not too familiar with conda-press internals, ignore it if you think it's not relevant :)

Also, @rth, anyone is welcome to help out with this :wink: @marcelotrevisani has done an amazing job of helping get us going on the feedstocks CI, but more hands are always welcome!


Export scenario support

PR Summary
Fix #73
This adds support for enumeration of all resource instances.
Export support is declared in a resource manifest similar to Get/Set/Test methods:
    "export": {
      "executable": "process",
      "args": [
        "list"
      ]
    },

In response to this call a resource is expected to return JSONLINES - one per resource instance.
Not implemented yet:

Export for provider-based resources
Export for classic PS DSC resources

PR Context
Following scenarios supported:

Export of a single resource type. e.g.:

PS C:\DSCv3> dsc -f pretty-json resource export -r Microsoft/Process
{
  "pid": 15520,
  "name": "AppVShNotify.exe",
  "cmdline": "[\"C:\\\\Program Files\\\\Common Files\\\\Microsoft Shared\\\\ClickToRun\\\\AppVShNotify.exe\"]"
}{
  "pid": 7208,
  "name": "WmiPrvSE.exe",
  "cmdline": "[]"
}{
...

Export of all types in a configuration. e.g.:

PS C:\DSCv3> Get-Content -raw C:\DSCv3\process\ExportTest.dsc.yaml | dsc.exe -f pretty-json config export
{
  "$schema": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/08/config/document.json",
  "resources":[
    {
      "type": "Microsoft/Process",
      "name": "Microsoft/Process-359",
      "properties": {
        "name": "WmiPrvSE.exe",
        "cmdline": "[]",
        "pid": 2140
      }
    },
    {
      "type": "Microsoft/Process",
      "name": "Microsoft/Process-360",
      "properties": {
        "pid": 5904,
        "name": "nvcontainer.exe",
        "cmdline": "[]"
      }
    }
...

Piping Configuration export to Configuration Set. e.g.:

PS C:\DSCv3> $config = Get-Content -raw C:\DSCv3\process\ExportTest.dsc.yaml | dsc config export
PS C:\DSCv3> $config | dsc config set
results:
- name: Microsoft/Process-0
  type: Microsoft/Process
  result:
    beforeState:
      result: Ok
    afterState:
      result: Ok
    changedProperties: []
- name: Microsoft/Process-1
  type: Microsoft/Process
  result:
    beforeState:
      result: Ok
    afterState:
      result: Ok
    changedProperties: []
...

To clarify my understanding of the behavior here:

The dsc resource export command is for returning the full list of instances for a resource without any special handling from dsc - just returning the JSONLINES the resource emits. No formatting or result object.
The dsc config export command is for returning an immediately usable configuration document, where the resources key is a flat array of the instances returned by every defined instance in the input configuration.

Assuming that's correct, a few thoughts:
Regarding the semantics/output of dsc resource export
The dsc resource export output breaks from the way all other dsc commands behave, where they have a result schema that handles some behaviors/collection for you. I would expect a result that mirrors the output from dsc resource get to some degree. I think the resource should definitely return the list of instances as JSONLINES, but I'm not sure that's the right contract for the dsc resource export command. It would make this output unique for dsc in that it just passes the resource output back through to the caller.
I think the semantic UX of the dsc resource export command is confusing. If I was a naive user, I would expect to be able to call dsc resource export -r foo/bar to get a configuration document that only includes instances of that resource. Functionally, a shorter way for me to get the functionality of dsc config export when I only care about a single resource.
As discussed in #73 (comment link), the current functionality of dsc resource export more closely mirrors the proposal for dsc resource get --all, which is a definitively distinct operation from dsc resource export. There's valid reasons both to say "I want the current state of all instances of this resource" (dsc resource get --all) and "I want a configuration based on every defined instance of this resource" (dsc resource export). The underlying code for what the resource does to return the values is the same, but how DSC presents the operation option in UX and processes the output are different.
Regarding the schema/data model
In #166, I mentioned that we might want to have a better DevX for defining the manifest entry to indicate whether a resource supports the dsc resource get --all/dsc resource export/dsc config export commands. I suspect the most common model for implementing support for this will be one of the following:

When you call the command defined for get without passing it any input JSON or argument flags, it returns every instance of the resouce.
When you call the command defined for get with a single boolean flag, like --all, it ignores other filtering options and input JSON, and returns every instance of the resource.

I think a fully separate command structure is less likely, but should be enabled. However, it would be good DevX to allow manifest authors to opt-in for these operations without having to redefine the setting if the case is 1. It's also potentially less intuitive to define get and export separately than to define an all property in get to indicate alternate arguments. What the author is defining is whether their resource supports returning every instance of itself.
// 'process get --all' expects no input, returns all instances
{
    "get": {
        "executable": "process",
        "args": ["get"],
        "all": {
          // executable is optional
          "args": ["get", "--all"]
        }
    }
}

// 'process get' returns all instances when called without input
{
    "get": {
        "executable": "process",
        "args": ["get"],
        "all": true // indicates that calling without input returns all
    }
}

// 'process get' returns null/error when called without input
{
    "get": {
        "executable": "process",
        "args": ["get"],
        "all": false // indicates that the resource doesn't support this op
    }
}

// 'osinfo' always and only returns one instance
{
    // this doesn't exist yet, but worth noting we can't tell the difference now
    "isSingleInstance": true,
    "get": {
        "executable": "osinfo",
        "args": [],
        "all": true
    }
}

The dsc resource export command is for returning the full list of instances for a resource without any special handling from dsc - just returning the JSONLINES the resource emits. No formatting or result object.

"No formatting" part is not correct. Internally there is deserialization from json, emitted by resource, into internal representation and then serialization into output format. This means that dsc will catch errors like invalid json, issues by resource, and can report back json as well as yaml based on dsc --format flag.

I would expect to be able to call dsc resource export -r foo/bar to get a configuration document that only includes instances of that resource. Functionally, a shorter way for me to get the functionality of dsc config export when I only care about a single resource.

I tend to agree with this. This would make it consistent so that export command always (whether resource export or config export) returns a configuration document that can be used in config set.


RefreshBook Reporting Object api seems to be missing from doc

sample should be otherwise identical to ClearBook and UnlinkBook

https://ibm.github.io/paxapi/#refreshbook


PdfRenderer of Android does not render some fonts present in the PDF document in Android API 23 (Android 6.0)

Attached PDF document cannot render the text properly
We have used Android.Graphics.Pdf.PdfRenderer Class to render pages from PDF document. It does not render some text present in the PDF document and it seems to be a break in native PdfRenderer API with the Android API 23 (Android 6.0) - Marshmallow as we do not face same issue in Android API 21 (Android 5.0) – Lollipop.
Can someone please help us to resolve this problem and render the PDF documents properly using PdfRenderer API with the Android API 23 (Android 6.0) - Marshmallow?
Please find the PDF document for your reference in the attachment
SimplePdfRenderer (1).zip
S2005686010.pdf

Hi, this is an issue tracker for a command-line tool called "hub". It has nothing to do with Android nor PDFs, sorry. I think you should find a more appropriate place to ask this question; perhaps on Stack Overflow.


Add expression support array

support list

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d5d94e) 96.82% compared to head (afd8181) 92.95%.

:exclamation: Current head afd8181 differs from pull request most recent head 6c5d2cb. Consider uploading reports for the commit 6c5d2cb to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   96.82%   92.95%   -3.88%
==========================================
  Files          21       22       +1
  Lines         410      426      +16
  Branches        0       74      +74
==========================================
- Hits          397      396       -1
  Misses         13       13
- Partials        0       17      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Custom path for .dockerignore

Sometimes it's very convenient to have different files in the same context for different services, that would not add the unnecessary files to the context

This would require support from Docker (as per https://github.com/moby/moby/issues/12886 it's not available yet and there is a lengthy discusson on that).
We certainly can try and copy the entire context over to a new place and have our own convention to specify the .dockerignore file that's going to be selected for any specific build, but that would break one of the main design principles of Habitus which is it doesn't have to exist for a single step build to work.


services/horizon: Add txsub integration test

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
Adds sanity integration test for txsub. Add a test (submit_transaction_test.go) I forgot to include in https://github.com/stellar/go/pull/3653.
Why
While we have some unit tests for txsub we don't test the transaction submission endpoint during mirroring test. A simple integration test should at least catch the most obvious bugs.
Known limitations
[TODO or N/A]

Don't all the existing integration tests exercise txsub because they all submit transactions to horizon?

Correct but they all do it synchronously and submit only one tx per account at a time. I'm worried that changes like #3563 can introduce subtle bugs we won't catch using unit tests and simple testing.


add handling of (expression)[indexing] in addMissingIndexingRecurse

FRO-DNM
This looks for cases like (x[1:2]%*%y[1:2])[1,1] based on ( and [ and if found, checks no missing indices and then runs addMissingIndexingRecurse on the parenthesized expression being indexed.
Before finalizing this I would also like to resolve the question raised in NCT issue 141 regarding whether the stanza beginning line 562 of BUGS_modelDef.R that checks for $ is needed.
Will need to add testing, including testing for correct trapping of missing indexing and vector version of this situation, namely something like (y[1:2]*x[1:2])[2]

One further note here - because of checking I added, this PR errors out for missing indexes of expressions, e.g.,
code = nimbleCode({
    mn[1:2] <- (X[1:2,1:2] %*% beta[1:2,1:2])[,1]
    y[1:2] ~ dmnorm( mn[1:2], pr[1:2,1:2])
})
m = nimbleModel(code, data = list(y = rnorm(2)),
                inits = list(X = matrix(1, 2,2), beta = matrix(2,2,2), pr = diag(2)))
cm <- compileNimble(m)
cm$calculate('y')

However, if I take that check out, compilation goes through and calculations are fine. So we may well not want to check for missing indexes, unless we think there are cases where missing indexing will cause problems.  Need input from @perrydv on what happens in terms of translation to Eigen code when indexes are missing.

Fixed erroneous commenting of the check for missing indexes in ()[,].
Recurse into the indexes of [,] when have things like k[,1]: [k[,1],]
Added testing

Waiting on Travis.

Apparently here's the use case for needing to check $ (see line 1284 of test-nimbleLIst.R)
    modelCode1 <- nimbleCode({
        meanVec[1:5] <- eigen(constMat[,])$values[1:5]
        covMat[1:5,1:5] <- eigen(constMat[1:5,])$vectors[1:5,1:5]%*%t(eigen(constMat[1:5,1:5])$vectors[,])
        y[] ~ dmnorm(meanVec[], cov = covMat[1:5,1:5])
    })

Adding this back in and rerunning tests.


Typo Fix

Line 35 "souce" to "source"

@JNorris96 : Thanks for your contribution! The author, @maggiesMSFT, has been notified to review your proposed change.

Thanks, @JNorris96! #sign-off


Criteria for PBI to Decide Whether to Increase Read Only Replica

The document lacks information regarding the criteria based on which Power BI is scaling up the number of read-only replicas. We've activated this feature in our BI space and observed that even during periods of overloads, Power BI does not initiate the creation of additional read-only replicas (I can confirm that background operations are not responsible for the overloads). Therefore, it would be beneficial to understand the conditions under which a new replica is intended to be generated.
Alternatively, is there a method available to manually increase the number of replicas as needed? If not, are there any plans to add this functionality?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b3d4befd-cdb9-2add-1b27-114166b21526
Version Independent ID: b3d4befd-cdb9-2add-1b27-114166b21526
Content: Power BI dataset scale-out - Power BI
Content Source: powerbi-docs/enterprise/service-premium-scale-out.md
Service: powerbi
Sub-service: powerbi-premium
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @JCREW-AnshulPurohit. This issue has been assigned to the doc author for review.

Thanks for your comment, @JCREW-AnshulPurohit .
This looks like product feedback or a product question, rather than documentation feedback. You can submit product feedback or feature ideas by going to Power BI Ideas.
You can also engage with the Power BI engineering team by being active in the Power BI Community.


Create separate venv for yt-dlp, marker, and ?

Ran into issues regarding dep conflicts with marker and existing packages. I also expect this to occur more down the line, when updating certain packages (gradio...) and want to avoid that headache.

Tying this in with the poetry issue. Issue #99

Poetry is not the solution and multiple venvs is.

Marker breaks on install on windows. Going to rethink the PDF pipeline. (and by direct result, a separate venv...)


Robot stalls when using python SDK and wheel speeds

Discussed in https://github.com/iRobotEducation/create3_docs/discussions/405

Originally posted by TAC0C4T June 14, 2023
How are you connecting to your Create 3?
Bluetooth (Python SDK)
Computer(s) Model(s) and Operating System(s)
Thinkpad P43s Windows 11
Which version of ROS 2 is installed on your computer?
None
Which firmware version is installed on your robot?
G.4.3
Which RMW is your robot running?
I don't know
Does your robot have an assigned namespace? If so, please share.
No response
Is the robot connected to a network? If so, what is the network type?
No response
Are there multiple Create 3 robots connected to your network?
None
Is multicast enabled?
None
What is the Adapter Board's USB/BLE Toggle currently switched to?
None
Describe your question.
certain values cause a stall when using robot.set_wheel_speeds(left, right). See attached image. Why do these ones cause this behavior?

Edit: I believe this to most likely be a firmware issue (correct me if I am wrong) as this error persists when the robot is held upside down and there is no resistance on the wheels. This still happens for the green values and the red values do not stall in the same manner.

I have also found sometime while turning the robot via /cmd_vel it can turn quickly then it gets locked out, preventing further robot movement. Turning on and off the e-stop (ros service) allows it to move again. Running Galactic + FW5.2, also happened with previous versions

Might this have to do with reflexes being enabled, and conflicting with commands sent? What is the status of the reflexes_enabled parameter?


Descriptive table declarations

This is a small thing, but it affects what is displayed in some of the views.
@ravinepal is this change beneficial? If not, that's fine. Please let me know.
Examples
Before the change:

After the change:

thanks, @cliftonmcintosh


Making binary paths configurable with defaults

Exposing binary paths (phpcs, phpmd, drush, behat) as configuration options in Gruntconfig.json.
Adding default values for Composer-installed dependencies.

Resolves #102. Also relates to #169 and #30.

Shouldn't phpcs and the tools using path be switched to cmd as well?

@grayside Not sure if I understand. I tried to make all of the tools consistent in using path.

Ah, my brain flipped those changes. Looks good. Something we'll want to add is some clearer docs on how to turn off things by setting them to false or removing from the Gruntconfig. That's not a blocker here though.


Allow network manager features for tenant administrator

Allow network manager features for tenant administrator
Steps for Testing/QA [Optional]
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1390164

👍 LGTM. Will merge once green

Euwe backport details:
$ git log -1
commit 73ebe0bd98e3ea6afd5c5efb3eac34eb559292a6
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Fri Nov 18 11:20:26 2016 -0500

    Merge pull request #12383 from Ladas/allow_network_manager_features_for_tenant_administrator

    Allow network manager features for tenant administrator
    (cherry picked from commit 3ad0ff569874fc7eacb7e0f59c34d175fcd6e4a4)

    https://bugzilla.redhat.com/show_bug.cgi?id=1401030


Pinned tabs: align them to the right

Another idea about pinned tabs - align pinned tabs to the right:

I am not sure if this is a completely logical idea, but maybe?

/duplicate of #99091


feat: usage period filter

Thanks for submitting a PR! Please check the boxes below:

[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes

For paid projects, add a usage filter.
Add ability to select api call types

How did you test this code?
As above

We should get rid of / update this alert too

Since each of these requests triggers a request to influx (that we pay for), we should also optimise this:

We're making a request to the root endpoint, and then with the period=current_billing_period query parameter set when we first load the page (where the default is current_billing_period).


find place to put buttons (own and by others)

one place is the landing page, but that's not enough. My own buttons can go to the left of the hub/home, and/or into the about-me section. idk

it would be fun to have buttons of friends float randomly through the sky in the hub/home, but thos are just a random collection. in the dragons den i need to have a special space for buttons of friends


expire without deletion

hi, i want to ask if it would be possible to introduce a flag that prevents a value from being deleted by expiration? i would like to handle it manually whether i should delete or update the value or just refresh the ttl upon the "expire" event.

see pull #90


replace assertRedirects with assert3xx (bug 1025277)

r+. When Django 1.7 comes out we can rewrite assert3xx to just call assertRedirects(..., fetch_redirect_response=False).

Thats good to know!


Change Virtualbox 5.0.6 t0 5.0.0 for windows

Couldn't get any other combination to work on my machine.
VirtualBox-5.0.0-101573-Win.exe
Is the correct build.

Interesting, because I had to update it because on Fedora, the docker-machine was hanging during the "create" with this version.

It's exactly the other way around for Windows.
They have some issues to sort out with that ;-)


Primal should include NIP-92 imeta tags on uploaded images and videos

Here is an example problem post: https://njump.me/nevent1qvzqqqqqqypzqpxfzhdwlm3cx9l6wdzyft8w8y9gy607tqgtyfq7tekaxs7lhmxfqydhwumn8ghj7emvv4shxmmwv96x7u3wv3jhvtmjv4kxz7gqypdmw8nljtms8wqqn29y6s8skdq0van6t88swa9ktz905xccua9m668s9je
It includes an image URL in the post content, but it does not include any NIP-92 imeta tags.
It's very difficult for clients to parse media attachments in Nostr events. With imeta tags it's much easier. But the most popular clients like Primal should support them, otherwise we're stuck writing complicated code in all clients.
For example, the same post bridged to Bluesky does not have an image preview because the original event doesn't have imeta tags: https://bsky.app/profile/odell-primal-net.eclipse.pub/post/3lef3tnwlxk2b
Meanwhile, posts I make from Ditto do have previews because they have imeta tags: https://bsky.app/profile/alex-gleasonator-dev.eclipse.pub/post/3ledokkx2cs2s
I can add more complicated code to the bridge to fix this in my bridge. But I think Primal should include imeta tags.
Even if there is no metadata except the URL, it would still be immensely helpful. For example, odell's post could have:
{
  "tags": [
    ["imeta", "url https://m.primal.net/NJbD.jpg"]
  ]
}

That alone would be a big improvement.

Pinging agent @alltheseas!


refactor: refactor the supernode daemon dir

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
As mentioned in the pull request #461, each interface of ......mgr has a corresponding implementation, we should put the implementation as a separate folder. In addition, extract the filter and store as the common util for daemon of supernode.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #482 into master will increase coverage by 0.06%.
The diff coverage is 72.14%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage    55.8%   55.86%   +0.06%
==========================================
  Files          81       80       -1
  Lines        3946     3938       -8
==========================================
- Hits         2202     2200       -2
+ Misses       1600     1593       -7
- Partials      144      145       +1

Impacted Files
Coverage Δ

supernode/daemon/util/store.go
91.3% <ø> (ø)

supernode/daemon/mgr/dfgettask/manager.go
60.41% <60.41%> (ø)

supernode/daemon/mgr/peer/manager.go
77.92% <77.92%> (ø)

supernode/daemon/util/filter.go
69.49% <80%> (ø)

supernode/daemon/mgr/cdn_mgr.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4807388...d627112. Read the comment docs.

lgtm


Missing dependencies: scikit-learn, pytorch

Hi! I think the setup.py install_requires is missing scikit-learn and pytorch.

scikit-learn version needs to be >= 0.22 (sklearn.neighbors. KNeighborsTransformer added in version 0.22)


Change popup title behavior

Don't use ellipses unless the title exceeds 70 chars. Use line breaks instead.

https://github.com/otacke/h5p-game-map/commit/fc7f69339e39e8865aeff16b04c3b1ee3ab1e5fb


Errors while configuring Azure CNI with DC/OS

Hi,
I tried to setup the CNI plugin for Azure using Mesosphere DC/OS. For that I adapted the example from the following guide: https://github.com/Azure/azure-container-networking/blob/master/docs/cni.md
The binaries used are from this package: https://github.com/Azure/azure-container-networking/releases/download/v0.91/azure-vnet-cni-linux-amd64-v0.91.tgz

The files azure-vnet and azure-vnet-ipam are placed in the directory /opt/mesosphere/active/cni/
The configuration azure-vnet.cni is placed under /opt/mesosphere/etc/dcos/network/cni/ and has the following content:

{
  "cniVersion": "0.2.0",
  "name": "azure",
  "type": "azure-vnet",
  "master": "eth0",
  "bridge": "azure0",
  "logLevel": "debug",
  "ipam": {
    "type": "azure-vnet-ipam",
    "environment": "azure"
  }
}

The CNI plugins gets loaded, but it seems like, it's not able to allocate IP addresses from the local/private interface eth0:
/var/log/azure-vnet.log:
2017/12/04 15:45:53 [cni] Calling plugin azure-vnet-ipam ADD nwCfg:&{CNIVersion:0.2.0 Name:azure Type:azure-vnet Mode: Master:eth0 Bridge:azure0 LogLevel:debug LogTarget: Ipam:{Type:azure-vnet-ipam Environment:azure AddrSpace: Subnet: Address: QueryInterval:}}.
2017/12/04 15:45:54 [cni] Plugin azure-vnet-ipam returned result:<nil>, err:Failed to allocate address: No available addresses.
2017/12/04 15:45:54 [azure-vnet] Failed to allocate pool: Failed to delegate: Failed to allocate address: No available addresses.
2017/12/04 15:45:54 [cni-net] ADD command completed with result:<nil> err:Failed to allocate pool: Failed to delegate: Failed to allocate address: No available addresses.
2017/12/04 15:45:54 [cni-net] Plugin stopped.

/var/log/azure-vnet-ipam.log:
2017/12/04 15:45:54 [ipam] Refreshing address source.
2017/12/04 15:45:54 [ipam] Requesting address with address: options:map[azure.address.id:efd73ce3-eth0].
2017/12/04 15:45:54 [ipam] Address request completed with address:<nil> err:<nil>.
2017/12/04 15:45:54 [azure-vnet-ipam] Failed to allocate address: No available addresses.

Full logs attached to this issue:

azure-vnet-ipam.log
azure-vnet.log

I'm running CentOS 7.4 machines with DC/OS 1.10.2 on Azure. Is there anything else, I need to configure either directly on the nodes or within the Azure Portal to get this running? Any hints appreciated.
Regards,
Jan

@jrx you need to add more than one ip addresses to the interface on the VM from the Vnet address space.
Please see how to do that here:
https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-network-interface-addresses
powershell: https://docs.microsoft.com/en-us/powershell/module/azurerm.network/add-azurermnetworkinterfaceipconfig?toc=%2Fazure%2Fvirtual-network%2Ftoc.json&view=azurermps-5.0.0
You can also add more private ip-addresses to an interface from portal.

@sharmasushant Many thanks! Yes, now it works perfectly fine. Having more than one IP address on the interface, fixed it. :)

@sharmasushant Is it possible to get IP addresses without pre-allocataing them?

@guhuajun That is not possible today. If you can make calls to azure from your VM, then you can allocate more IPs as needed, but that will require you to create a service principal that you can use from within the VM.

@sharadagarwal Thanks for updating! This solution works fine in Azure Global.
By the way, is azure-vnet compatible with Azure China (code name, mooncake) or Azure Stack?

This works in mooncake and all other national clouds.

@sharmasushant can we increase ip addresses using mas environment, after node is already a part of cluster?


Improve filename visibility in error messages

Closes #6378

Changes the header formatting to comply with what's described in the issue.
Makes all broken tests conform.
Adds an additional test for the case where the file path gets truncated.

I think the commits aren't verified. Well, at least the first 2. @rtfeldman what is are process here, do you just want to force merge?

@heytherewill you could use something like git rebase --exec 'git commit --amend --no-edit -n -S' -i HEAD~3 to sign these commits


[BUG] fix bug when receive embedding from vertex api

fix the way to parse response using list-parsing instead of dict-parsing.
see issue here.

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

fix the way to parse response from vertex api using list-parsing instead of dict-parsing

@tazarov These weird changes were fixed when I rebase the previous commit. Formatting tool leads to these changes. Thank you for your reminder.

@pig7788, this looks better. Thank you. Do you think we can also add maybe some sort of error if we don't find the response we expect? I think it would make for a good developer experience instead of returning an empty embeddings list.

@tazarov It is a good idea. I will add this in my code. Thanks!

@tazarov I add test cases that you advised and I could think of. Thank you for your suggestions. Thank @beggers too.

@tazarov I commit changes that you suggested, please confirm it, thx.

Our underlying impl has changed and so this PR is not landable as is.
That being said - we'd still like to add this functionality and that is now tracked in this issue.


Plotting multiple metrics in a single graph

🚀 Feature

Can we have multiple metrics plotted on the same graph in Tensorboard logging done by lightning?
That is plotting the dictionary values returned in log_dict in the same graph.
Motivation

Pitch

Alternatives

Additional context

You can already do this in lightning, by calling the tensorboard logger yourself, using the add_scalars method.
If you insert this into your code (artificial example)
        self.logger.experiment.add_scalars('main_tag',
                                           {'metric1': loss,
                                            'metric2': loss+1},
                                           global_step=self.global_step)

it will produce this in tensorboard

where the metrics are shown in the same plot.

Thank you so much!


Google镜像收集 - NuyoaH-L

https://blog.nuyoah-l.tk/2021/06/13/google镜像/
Write an awesome description for your new site here. You can edit this line in _config.yml. It will appear in your document head meta (for Google search results) and in your feed.xml site description.

截止到2021年6月13日，镜像全部可用


The file arguments account for deleted files as well

When using the argument {matchedFiles} for instance in a hook, it will list changed file of the package as expected, but it will also list deleted files, leading to errors sometimes.
Here, the file `` was deleted which breaks my pre-commit hook and made me do a commit --no-verify.

I happened across this bug as well with renamed python files in mookme version 2.3.0.

Fixed by https://github.com/Escape-Technologies/mookme/pull/132


GroupConsumer startingOffset should be set to what?

Say I have a topic with 10 partitions and have a total of about 3M messages and I want to start at around 2.5M, what do I set the startingOffset to?
Docs mentions something about the value being a time.  I'm not quite sure how to set this. Getting error from Long.low() when trying with offset as the index (i.e. Number(2500000)). When I try to set the value as a time value (new Date).getTime(), the final starting either resets to 0 or sets itself to the end of the queue.
I also can't find any Kafka docs regarding a time based offset anywhere. Any help will be great. Thanks.

Does anyone have any ideas or is startingOffset option not supported in GroupConsumer?

I'm running into similar issues. Even setting startingOffset to a fixed and valid offset, the group consumer never starts at that number.

GroupConsumers always start and continue from a last committed offset. If there is no committed offset for topic/partition then it starts from startingOffset.

Ah, only if no committed offset. And yes indeed the docs state that clearly.

Must this be so?

GroupConsumers are meant to be used in (almost) fully automatic way. Starting from committed offset is the natural way to do so. I can't imagine a real life use case with multiple group consumers running on a cluster (re)starting from a hard coded offsets. Looks like nightmare to manage. If I ever need to rollback and re-process some messages I think I would make a script that starts single GroupConsumer with empty handler, commits desired offsets to all topics and partitions and exits. Then I restart the consumers cluster. Not sure if there is a console tool bundled with Kafka that can commit offsets.

Interesting, the code I was just refactoring did exactly what you said -- created a dummy consumer, set the offsets, then created the real consumer. I thought that was some kind of mistake.
Our use case is this: We have a stream processor working over date from manufacturing date (IIoT if you will). Some of that data is sampled, but some is stateful. The processor need to be primed with the stateful data before going forward. So when the processor restarts it needs to go back just a bit in stream from where it left off to get the previously emitted stateful data. It can't just start where it left off because it will then be missing the non-sampled/stateful data.
All the stateful data is emitted to topic at fixed periods. So we would always like the consumer to go back to just that point and start from there.
But in this case, there is really no "group" of consumers -- just a single consumer processing a single topic in a single node app. But there are multiple are multiple partitions for the topic, so the high level consumer is much more convenient.
Does the above make sense?

there is really no "group" of consumers -- just a single consumer

Why don't use SimpleConsumer then?

there is really no "group" of consumers -- just a single consumer

Why don't use SimpleConsumer then?

Unless I misunderstand, with simple I have to manage partitions and rebalancing manually, no?

There is no rebalancing if there is a single consumer. You just subscribe to specified topics and partitions and receive data. Its just a perfect match for your scenario.

Bad wording. What I meant by rebalancing was if partitions are added to topic. Have not looked closely at the admin interface. I assume I must register for events like that and add any new partitions to the subscription.

partitions are added to topic

Thats quite a rare case. And if you just want to follow all partitions you can just subscribe only with a topic name parameter and no-kafka will select all topic partitions. It means that if you add new topics you will just have to restart the consumer without any re-configuration.

Yes adding partitions is rare for us, but we do it enough for it be handled. Our consumer apps are stateful stream processors so restarting is always a last resort. But if there is no way to detect new partitions internally (not topics because we run one process per topic for node apps) we can have the ansible playbook ping it via an API.
I didn't open this issue, but I personally am quite satisfied to have it closed. Thanks much.


staking research

should evaluate what fits our needs and if we can add it later if we launch mainnet in 3 weeks maybe, or we will have to do it from the beginning of the deployment
https://circles.threefold.me/project/despiegk-product_tfgrid3_roadmap/us/189

wip: https://github.com/threefoldtech/tfchain/blob/development/research/pos/pos.md

Can we transition from aura/grandpa to POS?

Impossible to transition from AURA to BABE. The block import pipeline is completely different, many changes had to be made to the Node which are not applicable on a running instance with a runtime upgrade. Since this involves more than just the runtime.

I thought it might have been possible since polkadot did it too and in the substrate docs for pow, there is some code to import the existing blocks for a transition although I do believe it is no default functionality.

I don't see a scenario where it is possible to actually upgrade the node with a runtime upgrade. AFAIK the runtime is a seperate module in substrate and you can only update that part with runtime upgrades.


python::pip ensure latest is broken for packages with mixed case name when using devpi/devpi as PyPi mirror/own repo

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.5.2
Ruby: included in Puppet 5
Distribution: Centos 7
Module version: 2.1.0

How to reproduce (e.g Puppet code you use)
Try to use python::pip with ensure => 'latest' using https://github.com/devpi/devpi as PyPi mirror/own repo for packages that contain mixed case letters in their names.
What are you seeing
Package is reinstalled on every puppet run and refresh is triggered, which causes unnecessary changes in reports and, what is worse, services restarts.
What behaviour did you expect instead
Package should not be updated if it's already in the latest version. No change should be reported for the resource and no refresh should be triggered.
Any additional information you'd like to impart
Please see https://github.com/devpi/devpi/issues/592 for info how I tried to fix it on devpi side. Apart from getting to conclusion that this is hard to fix it there I realized that as pip team is considering to remove pip search altogether (see https://github.com/pypa/pip/issues/5216), perhaps even better solution for this problem would be to stop using pip search on puppet-python side. This could also fix issues like #350.

I created a rough, work in progress PR here https://github.com/voxpupuli/puppet-python/pull/434 to discuss if I should go in this direction and if this has a change of getting merged.

Actually, as test that is failing here https://github.com/voxpupuli/puppet-python/pull/445 shows, python::pip with ensure => 'latest' using regular PyPi repo for a package with uppercase letter and "_" in its name also triggers refresh with every puppet run.


Adding a grip handle to list box item as a drag source

There are couple of issues and questions:

When using gong dd wpf library it mixes click and drag/drop events. My listboxitem comprises of complex data template in which there are checkbox, combobox, textbox etc. How to prevent this click, mouse down and drag/drop event from being captured on all controls in listboxitem datatemplate?

How to confine only to a grip handle instead of making whole listboxitem as drag source?

Thanks in advance.
Any help and suggestion is greatly appreciated.

Various controls are ignored when the drag starts over them - for instance any sort of button, etc. However some complex controls such as Expander are built on a ButtonBase, so cannot be dragged because
HitTestUtilities.HitTest4Type<ButtonBase>(sender, elementPosition)
returns true in DragSource_PreviewMouseLeftButtonDown.
This commit - https://github.com/rwg0/gong-wpf-dragdrop/commit/d9e561972c4e06c558f865aa37718b3c9cfffe28 - adds a very simple DragHandle that can be used to wrap any XAML control. If the initial drag point hits a DragHandle then the change makes the drag start regardless of the result of the other HitTestUtilities.HitTest4Type<T> calls.
Not sure whether this solves the general problem but it certainly makes it easy for me to put a DragHandle into the UI of an Expander and then drag the whole expander.

@folksmotion This should now work as expected (see https://github.com/punker76/gong-wpf-dragdrop/issues/187). Please take a look to the latest source and the Cloning sample.


[FEATURE] Rebuild sqldb-* contracts and implementations

Affected project(s)

[X] documentation
[ ] examples
[ ] wasmCloud host
[ ] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[X] capability providers
[X] provider bindgen
[ ] control interface client
[ ] other / not sure

Is your feature request related to a problem? Please describe.
In order to refactor and convert the sqldb-* providers (and get them using provider bindgen), we need to recreate the actual contracts they use because they are currently not secure enough.
Describe the solution you'd like
In general we need to:

[ ] Recreate/change the contracts that power sqldb-* providers
[ ] Convert the sqldb-* providers to use provider bindgen

Describe alternatives you've considered
N/A
Additional context
See https://github.com/wasmCloud/wasmCloud/issues/470

This is captured in the RFC #1914 right?

Yup! Let's close this in favor of that RFC -- and for any work we'll track it via that RFC.


Segfault on Fedora 36 due to vendored openssl

New crev user here. I was following the "Getting started" guide and instantly got a segfault on cargo crev verify as soon as it started to download any crate. Strangely downloading the trust data worked fine like in
cargo crev trust --level high https://github.com/dpc/crev-proofs
cargo crev repo fetch all

Platform is Fedora 36 Linux.
$ rpm -q rust openssl openssl-devel
rust-1.63.0-1.fc36.x86_64
openssl-3.0.5-1.fc36.x86_64
openssl-devel-3.0.5-1.fc36.x86_64

So I went down the rabbit hole and got this nice backtrace (skip to the end for a solution):
Thread 1 "cargo-crev" received signal SIGSEGV, Segmentation fault.
0x00007ffff781c5f8 in OPENSSL_sk_value (st=0x5555575bfa50 <ssl_session_hash>, i=0) at crypto/stack/stack.c:427
427         return (void *)st->data[i];
(gdb) bt
#0  0x00007ffff781c5f8 in OPENSSL_sk_value (st=0x5555575bfa50 <ssl_session_hash>, i=0) at crypto/stack/stack.c:427
#1  0x00007ffff783ea1a in X509_STORE_add_lookup (v=v@entry=0x55555beec4e0, m=0x7ffff7a414a0 <x509_file_lookup>) at crypto/x509/x509_lu.c:272
#2  0x00007ffff78452ff in X509_STORE_load_file_ex (ctx=0x55555beec4e0, file=file@entry=0x555559a81de0 "/etc/pki/tls/certs/ca-bundle.crt",
    libctx=0x555558655c00 <TLS_client_method_data.14>, propq=0x555559152f70 "alloc\177") at crypto/x509/x509_d2.c:51
#3  0x00007ffff7a7a397 in SSL_CTX_load_verify_file (ctx=<optimized out>, CAfile=CAfile@entry=0x555559a81de0 "/etc/pki/tls/certs/ca-bundle.crt")
    at ssl/ssl_lib.c:4411
#4  0x00007ffff7f463b7 in ossl_connect_step1 (data=data@entry=0x55555c036c90, conn=conn@entry=0x55555a6e7ba0, sockindex=sockindex@entry=0)
    at ../../lib/vtls/openssl.c:3085
#5  0x00007ffff7f4c1c7 in ossl_connect_common (data=0x55555c036c90, conn=0x55555a6e7ba0, sockindex=0, nonblocking=true, done=0x7ffffffdeb52)
    at ../../lib/vtls/openssl.c:4118
#6  0x00007ffff7f48bd9 in Curl_ssl_connect_nonblocking (done=0x7ffffffdeb52, sockindex=0, isproxy=false, conn=0x55555a6e7ba0, data=0x55555c036c90)
    at ../../lib/vtls/vtls.c:375
#7  Curl_ssl_connect_nonblocking (data=0x55555c036c90, conn=0x55555a6e7ba0, isproxy=<optimized out>, sockindex=0, done=0x7ffffffdeb52)
    at ../../lib/vtls/vtls.c:358
#8  0x00007ffff7eff6d6 in https_connecting (done=<optimized out>, data=<optimized out>) at ../../lib/http.c:1595
#9  Curl_http_connect (data=0x55555c036c90, done=0x7ffffffdeb52) at ../../lib/http.c:1521
#10 0x00007ffff7f1f006 in protocol_connect (protocol_done=0x7ffffffdeb52, data=0x55555c036c90) at ../../lib/multi.c:1728
#11 multi_runsingle (multi=multi@entry=0x55555a84ec80, nowp=nowp@entry=0x7ffffffdec10, data=data@entry=0x55555c036c90) at ../../lib/multi.c:2044
#12 0x00007ffff7f2157e in curl_multi_perform (multi=0x55555a84ec80, running_handles=0x7ffffffded34) at ../../lib/multi.c:2637
#13 0x0000555556d2d5af in curl::multi::Multi::perform (self=0x7ffffffe27c8) at src/multi.rs:728
#14 0x00005555564fad6a in cargo::core::package::{impl#9}::wait_for_curl::{closure#0} () at src/cargo/core/package.rs:974
#15 0x00005555566df1ac in cargo::core::package::tls::set::{closure#0}<core::result::Result<u32, anyhow::Error>, cargo::core::package::{impl#9}::wait_for_curl::{closure_env#0}> (p=0x7ffff70b5a78) at src/cargo/core/package.rs:1184
#16 0x000055555694e28f in std::thread::local::LocalKey<core::cell::Cell<usize>>::try_with<core::cell::Cell<usize>, cargo::core::package::tls::set::{closure_env#0}<core::result::Result<u32, anyhow::Error>, cargo::core::package::{impl#9}::wait_for_curl::{closure_env#0}>, core::result::Result<u32, anyhow::Error>> (
    self=0x5555585f8a58, f=...) at /builddir/build/BUILD/rustc-1.63.0-src/library/std/src/thread/local.rs:445
#17 0x000055555694ded7 in std::thread::local::LocalKey<core::cell::Cell<usize>>::with<core::cell::Cell<usize>, cargo::core::package::tls::set::{closure_env#0}<core::result::Result<u32, anyhow::Error>, cargo::core::package::{impl#9}::wait_for_curl::{closure_env#0}>, core::result::Result<u32, anyhow::Error>> (
    self=0x5555585f8a58, f=...) at /builddir/build/BUILD/rustc-1.63.0-src/library/std/src/thread/local.rs:421
#18 0x00005555566df0c6 in cargo::core::package::tls::set<core::result::Result<u32, anyhow::Error>, cargo::core::package::{impl#9}::wait_for_curl::{closure_env#0}> (dl=0x7ffffffe0010, f=...) at src/cargo/core/package.rs:1181
#19 0x00005555564fa863 in cargo::core::package::Downloads::wait_for_curl (self=0x7ffffffe0010) at src/cargo/core/package.rs:973
#20 0x00005555564f8017 in cargo::core::package::Downloads::wait (self=0x7ffffffe0010) at src/cargo/core/package.rs:825
#21 0x00005555564f5205 in cargo::core::package::PackageSet::get_many<core::option::Option<cargo::core::package_id::PackageId>> (self=0x7ffffffe2758,
    ids=...) at src/cargo/core/package.rs:479
#22 0x00005555564f4cd5 in cargo::core::package::PackageSet::get_one (self=0x7ffffffe2758, id=...) at src/cargo/core/package.rs:469
#23 0x0000555555a7ea08 in cargo_crev::repo::build_graph<alloc::vec::into_iter::IntoIter<cargo::core::package_id::PackageId, alloc::alloc::Global>> (
    resolve=0x7ffffffe27e0, packages=0x7ffffffe2758, roots=..., target=..., cfgs=...) at cargo-crev/src/repo.rs:215
#24 0x0000555555938913 in cargo_crev::repo::Repo::get_dependency_graph (self=0x7ffffffe5180, roots=...) at cargo-crev/src/repo.rs:395
#25 0x000055555595afe0 in cargo_crev::deps::scan::Scanner::new (root_crate=..., args=0x7fffffffb8a8) at cargo-crev/src/deps/scan.rs:128
#26 0x0000555555a6063e in cargo_crev::deps::verify_deps (crate_=..., args=...) at cargo-crev/src/deps.rs:321
#27 0x0000555555a25b61 in cargo_crev::run_command (command=...) at cargo-crev/src/main.rs:670
#28 0x0000555555a1406e in cargo_crev::main::{closure#1} () at cargo-crev/src/main.rs:989
#29 0x0000555555a14668 in cargo_crev::handle_command_result_and_panics::{closure#1}<cargo_crev::main::{closure_env#1}> () at cargo-crev/src/main.rs:1017
#30 0x00005555559f2be0 in std::panicking::try::do_call<cargo_crev::handle_command_result_and_panics::{closure_env#1}<cargo_crev::main::{closure_env#1}>, ()>
    (data=0x7fffffffc408) at /builddir/build/BUILD/rustc-1.63.0-src/library/std/src/panicking.rs:492
#31 0x00005555559f345b in __rust_try ()
#32 0x00005555559f1fe7 in std::panicking::try<(), cargo_crev::handle_command_result_and_panics::{closure_env#1}<cargo_crev::main::{closure_env#1}>> (f=...)
    at /builddir/build/BUILD/rustc-1.63.0-src/library/std/src/panicking.rs:456
#33 0x0000555555a37a03 in std::panic::catch_unwind<cargo_crev::handle_command_result_and_panics::{closure_env#1}<cargo_crev::main::{closure_env#1}>, ()> (
    f=...) at /builddir/build/BUILD/rustc-1.63.0-src/library/std/src/panic.rs:137
#34 0x0000555555a14216 in cargo_crev::handle_command_result_and_panics<cargo_crev::main::{closure_env#1}> (f=...) at cargo-crev/src/main.rs:1017
#35 0x0000555555a3618d in cargo_crev::main () at cargo-crev/src/main.rs:989

It looks like this in valgrind:
==112589== Invalid read of size 8
==112589==    at 0x4D60384: SSL_CTX_load_verify_file (ssl_lib.c:4411)
==112589==    by 0x490F3B6: ossl_connect_step1 (openssl.c:3085)
==112589==    by 0x49151C6: ossl_connect_common (openssl.c:4118)
==112589==    by 0x4911BD8: UnknownInlinedFun (vtls.c:375)
==112589==    by 0x4911BD8: Curl_ssl_connect_nonblocking (vtls.c:358)
==112589==    by 0x48C86D5: UnknownInlinedFun (http.c:1595)
==112589==    by 0x48C86D5: Curl_http_connect (http.c:1521)
==112589==    by 0x48E8005: UnknownInlinedFun (multi.c:1728)
==112589==    by 0x48E8005: multi_runsingle (multi.c:2044)
==112589==    by 0x48EA57D: curl_multi_perform (multi.c:2637)
==112589==    by 0x18E15AE: curl::multi::Multi::perform (multi.rs:728)
==112589==    by 0x10AED69: cargo::core::package::Downloads::wait_for_curl::{{closure}} (package.rs:974)
==112589==    by 0x12931AB: cargo::core::package::tls::set::{{closure}} (package.rs:1184)
==112589==    by 0x150228E: std::thread::local::LocalKey<T>::try_with (local.rs:445)
==112589==    by 0x1501ED6: std::thread::local::LocalKey<T>::with (local.rs:421)
==112589==  Address 0x815e130 is 0 bytes inside an unallocated block of size 1,008 in arena "client"
==112589==
==112589== Invalid read of size 8
==112589==    at 0x4FCD5F8: OPENSSL_sk_value (stack.c:427)
==112589==    by 0x4FEFA19: X509_STORE_add_lookup (x509_lu.c:272)
==112589==    by 0x4FF62FE: X509_STORE_load_file_ex (x509_d2.c:51)
==112589==    by 0x490F3B6: ossl_connect_step1 (openssl.c:3085)
==112589==    by 0x49151C6: ossl_connect_common (openssl.c:4118)
==112589==    by 0x4911BD8: UnknownInlinedFun (vtls.c:375)
==112589==    by 0x4911BD8: Curl_ssl_connect_nonblocking (vtls.c:358)
==112589==    by 0x48C86D5: UnknownInlinedFun (http.c:1595)
==112589==    by 0x48C86D5: Curl_http_connect (http.c:1521)
==112589==    by 0x48E8005: UnknownInlinedFun (multi.c:1728)
==112589==    by 0x48E8005: multi_runsingle (multi.c:2044)
==112589==    by 0x48EA57D: curl_multi_perform (multi.c:2637)
==112589==    by 0x18E15AE: curl::multi::Multi::perform (multi.rs:728)
==112589==    by 0x10AED69: cargo::core::package::Downloads::wait_for_curl::{{closure}} (package.rs:974)
==112589==    by 0x12931AB: cargo::core::package::tls::set::{{closure}} (package.rs:1184)
==112589==  Address 0x834800000158b78d is not stack'd, malloc'd or (recently) free'd
==112589==
==112589==
==112589== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==112589==  Access not within mapped region at address 0x50978B48
==112589==    at 0x4FCD5F8: OPENSSL_sk_value (stack.c:427)
==112589==    by 0x4FEFA19: X509_STORE_add_lookup (x509_lu.c:272)
==112589==    by 0x4FF62FE: X509_STORE_load_file_ex (x509_d2.c:51)
==112589==    by 0x490F3B6: ossl_connect_step1 (openssl.c:3085)
==112589==    by 0x49151C6: ossl_connect_common (openssl.c:4118)
==112589==    by 0x4911BD8: UnknownInlinedFun (vtls.c:375)
==112589==    by 0x4911BD8: Curl_ssl_connect_nonblocking (vtls.c:358)
==112589==    by 0x48C86D5: UnknownInlinedFun (http.c:1595)
==112589==    by 0x48C86D5: Curl_http_connect (http.c:1521)
==112589==    by 0x48E8005: UnknownInlinedFun (multi.c:1728)
==112589==    by 0x48E8005: multi_runsingle (multi.c:2044)
==112589==    by 0x48EA57D: curl_multi_perform (multi.c:2637)
==112589==    by 0x18E15AE: curl::multi::Multi::perform (multi.rs:728)
==112589==    by 0x10AED69: cargo::core::package::Downloads::wait_for_curl::{{closure}} (package.rs:974)
==112589==    by 0x12931AB: cargo::core::package::tls::set::{{closure}} (package.rs:1184)

This made me dig into the openssl code (I'm familiar with it a bit), but nothing obviously suspicious turned up.
While inspecting Cargo.toml I noticed it includes a vendored openssl build. Oh my.
So I disabled that one and voila, crev verify finally works by magic several hours later.
The problem is that the vendored openssl is version 1.1.1 while F36 ships openssl 3.0.0. This doesn't mix well at all if other crates link the system wide openssl. Openssl loads further "engines" shared libraries dynamically at runtime.
Compiled with the vendored openssl feature:
$ strings target/debug/cargo-crev |grep -i openssl |grep 1.1.1
OpenSSL 1.1.1q  5 Jul 2022

Proposal: Disable the vendored openssl builds on Linux platforms by default. Security updates from the distro will come for free, too.

Fine with me. Can we do the default per platform? Relevant: #401

According to https://github.com/rust-lang/cargo/issues/1197 it seems possible now:
Example:
[target."cfg(target_os=linux)".dependencies]
dep1 = {version = x, optional = true}

A quick grep shows it's in use by the Rust compiler itself f.e. in rustc/src/tools/miri/Cargo.toml:
[target."cfg(unix)".dependencies]
libc = "0.2"

I'll experiment with it tomorrow. Might need Rust 2021 edition to enable "cargo resolver v2" by default.

Unfortunately cargo will merge all features from target specific dependencies into one big graph.
I tried two different approaches:
@@ -51,7 +51,6 @@ structopt = "0.3.25"
 time = "0.3.6"
 tokei = "12.1.2"
 walkdir = "2.3.2"
-openssl-sys = "0.9.65"
 git2 = ">=0.13, <15"
 tempfile = "3.3.0"
 rprompt = "1.0.5"
@@ -61,8 +60,14 @@ term = "0.7.0"
 syn-inline-mod = "0.5.0"
 quote = "1.0.20"

+[target."cfg(windows)".dependencies.openssl-sys]
+version = "0.9.65"
+features = ["vendored"]
+
+[target."cfg(unix)".dependencies.openssl-sys]
+version = "0.9.65"
+
 [features]
-default = ["openssl-sys/vendored"]

As this didn't work, I thought may be I can outsmart it by moving the "vendored" feature flag into an own dependency inside cargo-crev:
--- a/cargo-crev/Cargo.toml
+++ b/cargo-crev/Cargo.toml
@@ -61,8 +61,10 @@ term = "0.7.0"
 syn-inline-mod = "0.5.0"
 quote = "1.0.20"

+[target.'cfg(target_os = "windows")'.dependencies]
+vendorize-openssl = { version = "0.0.1", path = "vendorize-openssl" }
+
 [features]
-default = ["openssl-sys/vendored"]

$ cat vendorize-openssl/Cargo.toml
[package]
name = "vendorize-openssl"
version = "0.0.1"
edition = "2021"

[lib]

[dependencies]
openssl-sys = { version = "0.9.65", features = ["vendored"] }

One can see in the cargo tree output that as soon as the vendorize-openssl is mentioned, the openssl-src crate gets included in all dependencies using openssl-sys:
│   │   ├── crypto-hash v0.3.4
│   │   │   ├── hex v0.3.2
│   │   │   └── openssl v0.10.41
│   │   │       ├── bitflags v1.3.2
│   │   │       ├── cfg-if v1.0.0
│   │   │       ├── foreign-types v0.3.2
│   │   │       │   └── foreign-types-shared v0.1.1
│   │   │       ├── libc v0.2.131
│   │   │       ├── once_cell v1.13.0
│   │   │       ├── openssl-macros v0.1.0 (proc-macro)
│   │   │       │   ├── proc-macro2 v1.0.43 (*)
│   │   │       │   ├── quote v1.0.21 (*)
│   │   │       │   └── syn v1.0.99 (*)
│   │   │       └── openssl-sys v0.9.75
│   │   │           └── libc v0.2.131
│   │   │           [build-dependencies]
│   │   │           ├── autocfg v1.1.0
│   │   │           ├── cc v1.0.73
│   │   │           │   └── jobserver v0.1.24
│   │   │           │       └── libc v0.2.131
│   │   │           ├── openssl-src v111.22.0+1.1.1q
..

With the current cargo feature set this seems unsolvable. There are hacks using build.rs and stuff, but that's rather unclean.
The solution I can think of right now is to disable openssl vendoring by default and enable it for the official Windows builds explicitly.
Other ideas?

Oh, so it turns out my suggestion in #488 is already implemented. :thinking:

This doesn't mix well at all if other crates link the system wide openssl.

How could this happen? Cargo doesn't allow linking same library multiple times and if multiple crates depend on openssl-sys then turning on vendored should turn it on for all of them so all should link statically.


Level2 git reset prompt is too vague

Version: 0.3.34
Platform: All
Publisher: All
Non-Chinese players may not understand the git reset prompts.

add git reset tip


Make submission result/error consistent for initFromFlash

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Currently, when an error is thrown from the server function, the client-side submission logic and server-side init from flash logic behave differently:
const MyComponent = () => {
  const sumission = useSubmision(myAction)

  // SSR
  console.log(getRequestEvent()?.router?.submission.result) // Error
  console.log(getRequestEvent()?.router?.submission.error) // undefined

  createEffect(() => {
    if (sumission.pending === false) {
      // CSR
      console.log(sumission.result) // null
      console.log(sumission.error) // Error
    }
  })

  // ...
}

Error appears in submission.error when not relying on flash.
What is the new behavior?
Consistent behavior of submission.error for the init from flash case. Error is in submission.error when an error is thrown from the server function.
Other information
Link to the thread in Discord with additional details

Oh right.. I missed moving this all the way across when i added .error

Ok I have a new fix for this issue. I do want to remind you though that throwing errors in actions is not a recommended approach in general because you lose typescript support. But now at least it works properly.


Fix the config node role name in utils.rb

Updated get_config_nodes() function to use the correct config node role
name.
Resolves Juniper/contrail-chef#1

+2 For this change!
Contrail people, please merge this request!