Vendoring is not able to provide offline test env

Problem
When using cargo vendor, test --offline fails.
Steps

cargo vendor
cargo test --offline

CARGO_TARGET_DIR=/home/william/build/ds/rs  \
	cargo test --offline --manifest-path=/home/william/development/389ds/ds/src/librslapd/Cargo.toml
warning: unused manifest key: source
error: unable to fetch registry `https://github.com/rust-lang/crates.io-index` in offline mode

Possible Solution(s)
Test/dev dependencies should be fetched in vendoring to allow test --offline to operate.
Notes
Output of cargo version:
1.37

It looks like you may have configured vendoring in the wrong location? the warning: unused manifest key: source looks like the configuration was placed in the manifest (Cargo.toml) instead of .cargo/config

Ahhh all the communication in cargo vendor has been super unclear and dense to read. I've really been struggling to understand this process.
I have had values in .cargo/config, and these messages keep appearing so it appears like they are doing nothing. When you have no dependencies it gives you an incomplete configuration and doesn't prompt to say it did nothing. (I already opened that issue I think). Cargo vendor always shows absolute paths too, which is really worrying for something that should be getting vendored and shipped to other hosts too.
I think that perhaps the overall experience is cargo vendors gives a lot of 'false warnings' which meant that I switched off reading the warnings because it kinda-i-guess worked until it didn't.
Anyway, vendoring worked with this change, so I'll leave it up to you if you want to close this, or if you think there is something here communication wise that can be improved :) Thanks heaps!

Ah ok, in that case I'm gonna go ahead and close this.
It'd be great if you could be more concrete about the false warnings though! It sounds like you didn't have a great experience with cargo vendor and we'd love to help fix that! I'm not really sure what you mean about false warnings though, so having detailed instructions to reproduce would be quite helpful. (and opening a new issue should be fine)

See this issue here https://github.com/rust-lang/cargo/issues/7473 :)

Hey, @alexcrichton can you re-open this - just yesterday I did this again and with "cargo test --locked --offline" the test failed with "unable to fetch metadata". I think that perhaps the issue here is that the workflow for cargo vendor and getting --offline to work is not really documented on  https://doc.rust-lang.org/nightly/cargo/commands/cargo-vendor.html . It talks about the commands in isolation, but not what the workflow should be. What I have come up with I have no idea if it's correct but the only way I got it to work was:
cargo vendor
cargo fetch
cargo build --offline --locked

Even with fetch+vendor, cargo test --offline --locked is still failing for me claiming it needs to update. So I think there is some really missing process guides here about how to tie it all together to a working offline build system.

Sorry for the delay in getting back here, @Firstyear can you open a new issue for that perhaps? This issue as-is is not correct because vendoring does handle the test environment, so having a detailed workflow of what went wrong would be helpful to figure out where the documentation is wrong or where it went awry.

Thanks @alexcrichton, see #7520


Increase addmatches efficiency

Currently the addmatches command (via util/management/commands/addmatches.py) is inefficient and slow. This is due to multiple reasons:

Extra calls to model.save() throughout the function
Writing a lot of JSON data (that we no longer need) in TBAW.models.scoring.ScoringModel - roughly 2.6KB per scoring model which likely is not necessary.

Really could use a high-level description of what it is doing...

It's on my todo list.

The optimizations we have done so far are good enough for low-frequency tasks. See #19 for a low priority continuation.


Use pooch and update data

@Mikejmnez I've done a bunch of things:

Move data to zenodo
Add hycom_test.{yaml,nc}
Use pooch under the hood so data are only downloaded if they don't exist or they changed (i.e., use cache)

Please merge if it looks OK so you can make use of this changes in you PR.
BTW, Happy New Year!
Did you get snow chains for your bike?

@Mikejmnez I've done a bunch of things:
* Move data to [zenodo](https://zenodo.org/record/5825166#.YdbvCnXMKV4)

* Add `hycom_test.{yaml,nc}`

* Use [pooch](https://www.fatiando.org/pooch/latest/) under the hood so data are only downloaded if they don't exist or they changed (i.e., use cache)

Please merge if it looks OK so you can make use of this changes in you PR.

Cool! So the test data will live in zenodo? What will be the procedure if there is new test data (e.g. other simulation, although unlikely at this point) ? Send it to you and you upload it to zenodo?

BTW, Happy New Year! Did you get snow chains for your bike?

Happy New year! How's the UK, or are you traveling anywhere fun? BTW I thought 'snow chains for your bike' was a joke, but it turns out its real! hahaha not yet (there is not enough snow) but will consider it in the future!

Cool! So the test data will live in zenodo? What will be the procedure if there is new test data (e.g. other simulation, although unlikely at this point) ? Send it to you and you upload it to zenodo?

Not sure if I can add contributors. We'll figure it out when we need it. But at least it's easier to find/more accessible, and we can also keep track of different versions.

Happy New year! How's the UK, or are you traveling anywhere fun? BTW I thought 'snow chains for your bike' was a joke, but it turns out its real! hahaha not yet (there is not enough snow) but will consider it in the future!

Ahahaha, it was a joke! I'm in Italy right now, I should be back in the UK next week. It got pretty cold yesterday, but the weather has been amazing!


OCPBUGS-5537: USHIFT-601 rebase: entrypoint and create_pr.py

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

/bugzilla refresh

/jira refresh

/jira refresh

/jira refresh

/lgtm

/cherry-pick release-4.12

/lgtm


feat: Pagination Component

This pr includes the full functionality of the pagination component with the unit tests and documentation.
The attributes,events and the general usage of the pagination are mentioned in:
Closes https://github.com/Trendyol/baklava/issues/139.

Should there be a close button when there is a selection in the number of items select input? How many items will it show on the page when the selection is removed?
Can the width of the number of items select input be adjusted according to the item that takes up the most space? the default width looks too wide @olkeoguz


FileRead in tutorial can intercept the event, but not block it

i'm playing with EasyHook tutorial and kernel32 FileRead
the tutorial can intercept the event and log it, but the hook can't block it by removing out the original function
how is possible?
somthing like:
bool ReadFile_Hook( IntPtr hFile,IntPtr lpBuffer, uint nNumberOfBytesToRead,  out uint lpNumberOfBytesRead, IntPtr lpOverlapped)
        {
            bool result = false;

            // Retrieve filename from the file handle
            StringBuilder filename = new StringBuilder(255);
            GetFinalPathNameByHandle(hFile, filename, 255, 0);

            // don't call the original function
            //result = ReadFile(hFile, lpBuffer, nNumberOfBytesToRead, out lpNumberOfBytesRead, lpOverlapped);

            return result;
        }

I know its old but, if you want to block the function, just return a access denied code, which will be presented to the ReadFile caller function. That function will be informed that ReadFile didn't succeeded.

I know its old but, if you want to block the function, just return a access denied code, which will be presented to the ReadFile caller function. That function will be informed that ReadFile didn't succeeded.

What is the access denied code?


Add Support for secp256k1 algorithms (AKA ES256K)

Changes
This replaces #428 to add support for the secp256k1 algorithm. The only changes from that original PR are the ones requested on the review:

Remove the addition of a deprecated method
Whitespace fixes

It also removes the README txt file.
For review purposes, see the commits for this PR; the changes to the original PR have been captured as separate commits.
References
#428
Testing

[X] This change adds test coverage
[ ] This change has been tested on the latest version of Java or why not

How to create a secp256k1 key to be used with ES256K algorithm:
Generate the key
openssl ecparam -genkey -name secp256k1 -out KEY.pem -text

The file is split into 2 parts a curve specification (EC PARAMETERS) and the key value
This format is not suitable to be read by the PermUtils PEM reader so we have to convert it into PCKS8 format:

openssl pkcs8 -topk8 -inform PEM -outform PEM -nocrypt -in KEY.pem -out ec256k-key.private.pem
The public key is then calculated as follows:
openssl ec -pubout -in KEY.pem -out ec256k-key-public.pem
How to get DER signature:
ECDSAAlgorithm algorithm256 = (ECDSAAlgorithm) Algorithm.ECDSA256((ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"), (ECPrivateKey) readPrivateKeyFromFile(PRIVATE_KEY_FILE_256K, "EC"));
String[] parts = ES256K_JWT.split("\\.");

byte[] derSignature = algorithm256.JOSEToDER(Base64.decodeBase64(parts[2]));
String jwt=parts[0]+"."+parts[1]+"."+Base64.encodeBase64URLSafeString(derSignature);

Checklist

[X] I have read the Auth0 general contribution guidelines
[X] I have read the Auth0 Code of Conduct
[X] All existing and new tests complete without errors

Good to merge 👍


[Concurrent Segment Search][Meta] GA readiness items

This is a place holder issue for tracking all the GA readiness work items needed for concurrent search:

Remove the experimental feature flag opensearch.experimental.feature.concurrent_segment_search.enabled
Update the default value of cluster setting search.concurrent_segment_search.enabled to false after above is done
Update tests using feature flag to use cluster setting instead. This will get addressed to large extent by https://github.com/opensearch-project/OpenSearch/issues/7440
Doc updates: a) Profile APIs, b) Cluster/Index Settings, c) New stats that will be added
Remove the log in QueryPhaseSearcherWrapper

@Pallavi-AWS Fyi

Maybe a dumb question, why not enable it by default? We have enabled the feature and never saw any disadvantages, even in the experimental stage. Just a decent performance improvement. 👍

@sandervandegeijn We definitely want to explore making concurrent segment search the default case but in the first release we want to minimize any potential disruptions to users. We already know that in cases of very high resource usage concurrent search may see some performance regressions. I'm thinking after the GA release of concurrent search we can start a more detailed discussion on the pros/cons of making concurrent search default.

Okay cool :) Caution is almost always a good thing!

@sohami @jed326 this is targeting at least 2.13.0 right? (I believe it is super risky for 2.12.0)

@sohami @jed326 this is targeting at least 2.13.0 right? (I believe it is super risky for 2.12.0)

@reta We were planning on targetting 2.12.0 still. We haven't made any correctness related changes for a while and haven't uncovered any new issues -- removing the feature flag is all that remains. Did you have any other concerns or risks that you see?

We still have a number of test failing [1] for concurrent search path and we don't know the cause of these failure yet, personally I feel this change is risky for 2.12.0 to graduate out of experimental, @CEHENKLE @dblock @nknize @andrross what do you think folks?
[1] https://github.com/opensearch-project/OpenSearch/issues?q=is%3Aissue+is%3Aopen+"search.concurrent_segment_search.enabled"%3A"true"

@jed326 Let's go through the search that @reta linked and try to get a resolution to all issues. We shouldn't GA this feature if there are truly unknown test failures remaining, but I'm optimistic that we can address everything by the end of the week.
/cc @yigithub

Thanks @reta. I did a quick review of the tests in that search link:

https://github.com/opensearch-project/OpenSearch/issues/11875 - There's already a PR open for this #12110
https://github.com/opensearch-project/OpenSearch/issues/11347 - The reported failures here are for both concurrent and non-concurrent search paths
https://github.com/opensearch-project/OpenSearch/issues/10231 - This is a dupe of https://github.com/opensearch-project/OpenSearch/issues/11187 and has already been resolved. Will close this issue shortly.
https://github.com/opensearch-project/OpenSearch/issues/9401 - The reported failures here are for both concurrent and non-concurrent search paths

We have been tracking the failing tests related to concurrent search in the project view here, and as you can see there is only the single test remaining (#11875):
https://github.com/orgs/opensearch-project/projects/117/views/4

I did a deeper crawl through all of the open flaky test issues as well and I didn't find any other open issues that are related to concurrent search either.
@reta @andrross  Let me know if you think there's anything else we can verify to de-risk a 2.12.0 launch. Thanks!

I did a deeper crawl through all of the open flaky test issues as well and I didn't find any other open issues that are related to concurrent search either.

Thanks @jed326 , indeed I see only https://github.com/opensearch-project/OpenSearch/issues/11875 to be really related (hopefully we'll get it in soon). Another pending fix is here https://github.com/opensearch-project/OpenSearch/pull/10836 but that for tests only.
That definitely makes this change less risky  :-) thanks again.

That definitely makes this change less risky :-) thanks again.

Thanks @reta! I'll move this issue back to 2.12.0 for now then. As for the GA PR, I will also poke around and see if there are any other maintainers who can take a crack at if while you are busy.

I've put together an "operational readiness" issue that compiles all the work and artifacts that went into getting this feature ready for release: #12118
Would love to get feedback on that issue, on both the operational readiness template/process as well as the specific content for the concurrent search release. FYI @reta

Going to leave this open until 2.12 is launched


Fix image deformation when using fluid or size classes

Currently, images which have height and width attributes set in the HTML don't resize correctly with the size and fluid classes (ui small image, ui fluid image, etc.). Those attributes are frequently used to avoid the content jumping around in case images take some time to load, which is why I figured this simple fix might be useful.
What happens in the actual version: the images get squeezed horizontally but not vertically, not preserving their aspect ratio.
What happens after my changes: the image gets resized both horizontally and vertically, keeping their aspect ratio intact.

Images default to height auto, why would we need to specify?

I guess the height and width attributes override that behaviour, since it's causing problems for me without external CSS loaded.

Can you create a JSFiddle that demonstrates the issues you're seeing?

There you go: http://jsfiddle.net/cs93hfp3/

Are you working with backend tools that automatically add inline width and height? Its a bit quirky to specify a different height as an attribute than what you want it to appear as.
Nevertheless there's no harm in adding. And it does solve this case.

Those are indeed added by my backend tools. Now that you point it out, it's indeed a bit quirky...


Remove resources that are not needed to run cluster capacity analysis.

@derekwaynecarr
I have reduced resource further to only pods and nodes. With this and RBAC, the only role that is needed to run cluster capacity is:
kind: ClusterRole
apiVersion: v1
metadata:
  name: cc-role
rules:
- apiGroups: [""]
  resources: ["pods", "nodes",  "persistentvolumeclaims", "persistentvolumes", "services"]
  verbs: ["get", "watch", "list"]

@derekwaynecarr as per our discussion, I have updated this PR to only remove replication controllers and replica sets.
The 2nd commit is just to fix gofmt error found in the downstream openshift/cluster-capacity code.


Implement Custom Tasks

See TEP-0002

Allow TaskRefs in PipelineTasks that specify an apiVersion and  kind
Create Runs for those Refs owned by the PipelineRun
Collect RunStatuses in the status of the owning PipelineRun
Simple end-to-end test demonstrating a Run being created from a PipelineRun
Document Custom Task controller protocol and best practices
Provide a sample Custom Task controller (based on knative/pkg? kubebuilder?)

/assign @ImJasonH

Moving to 0.18 as there's still some work being made towards this goal.

Ref: https://github.com/tektoncd/pipeline/pull/3463

#3463 has been merged, should we close this ?

Closing this as it has been implemented. Follow up work can be treated separately.


Display forest at 1:1,000,000 scale

What stamen does excellent is abstracting land cover.
An option to let it do it for forest at a a scale of 1:1,000,000 (or any other reasonable) would be nice!

Hi @benjaminweb, can you explain a bit more what you mean? Right now we "abstract" the land cover by blurring it, which is partly done so that we can mix the small-scale MODIS landcover with the high-resolution OpenStreetMap landcover, without having obvious differences in resolution.
To see more about how we do the land cover, check out the repo for the Terrain style here: https://github.com/stamen/terrain-classic

Hi @almccon,
I should have been more precise from the beginning =) :
http://maps.stamen.com/watercolor/#10/37.8927/-122.5882 does show where forest is (green), http://maps.stamen.com/watercolor/#9/37.8933/-122.5882 no more.
My use case is in QGIS wherein I want to display the forest (green) for an higher administrative area (where it currently is not displayed).
I refer to watercolor, not terrain-classic.

Oh, I just realise that terrain-classic displays forests at the scale I want.
However, I would appreciate a similar behaviour for Watercolor.


maybe a bug

Thanks for your great work.
When I start training by "--resume_from some_chepoints.pth", I encounter following error. Is this a bug?
  File "/code/drivestudio/tools/train.py", line 376, in <module>
    final_step = main(args)
  File "/code/drivestudio/tools/train.py", line 260, in main
    loss_dict = trainer.compute_losses(
  File "/code/drivestudio/models/trainers/scene_graph.py", line 285, in compute_losses
    loss_dict = super().compute_losses(outputs, image_infos, cam_infos)
  File "/code/drivestudio/models/trainers/base.py", line 625, in compute_losses
    class_reg_loss = self.models[class_name].compute_reg_loss()
  File "/code/drivestudio/models/nodes/smpl.py", line 466, in compute_reg_loss
    nn_ind = self.nn_ind[instances_mask] # (num_instances, smpl_points_num, knn_neighbors)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1265, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'SMPLNodes' object has no attribute 'nn_ind'

Training from scratch is ok.

Hi @lcc815,
Can you provide the details of experimental setting used? The dataset, scene id, start end frame index, and the camera settings ect. I'll try if I can reproduce this error from my end.

Sure. my trainning command is:
python train.py  --config_file configs/omnire.yaml --output_root output --project omnire --resume_from omnire/exp2/checkpoint_15000.pth --run_name exp2 dataset=waymo/1cams data.scene_idx=114 data.start_timestep=0 data.end_timestep=100
Others remain the same as the repo.

changing the state_dict and load_state_dict in models/nodes/smpl.py as following solves this problem:
    def state_dict(self) -> Dict:
        state_dict = VanillaGaussians.state_dict(self)
        state_dict.update({
            "points_ids": self.point_ids,
            "instances_size": self.instances_size,
            "instances_fv": self.instances_fv,
            "nn_ind": self.nn_ind
        })
        return state_dict

    def load_state_dict(self, state_dict: Dict, **kwargs) -> str:
        self.point_ids = state_dict.pop("points_ids")
        self.instances_size = state_dict.pop("instances_size")
        self.instances_fv = state_dict.pop("instances_fv")
        self.nn_ind = state_dict.pop("nn_ind")   # add this line
        ...

Great! I'll merge this update, thank you for pointing out!


1833 - Check For $bids Before Checking Count

Resolves #1833

:tada: This PR is included in version 5.8.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Align the width of Properties to fetch field to be the same as the other fields

The width of the Properties to fetch field is smaller than the other fields
Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/shesha/forms-designer?id=4de5b167-8f56-493f-a85a-1805e8c2f442'
Click on 'dataTable'
Click on 'customize Columns'
Click on the last column 'Residential Subform'
Check properties to fetch field
Actual Results: The size of the width is smaller than the other fields

Expected behavior
Be consistent, increase the size of the field to align with the other fields

There is "+" button


test framework and e2e utilities usage

What type of PR is this?
Use common utilities between integration and e2e tests.
Use these utilites to fix a flaky e2e test.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #482
Special notes for your reviewer:

/retest

@alculquicondor one thing I think we should do is maybe stress test this a bit before we merge.  I'm not sure if the checks I added into e2e tests will cause it to fail more so do you have any suggestions for running this a bunch in prow?
I can ask in sig-testing but maybe we should hold on the PR until we can do that?  WDYT?

Just manually:
/test pull-kueue-test-e2e-main-1-23
/test pull-kueue-test-e2e-main-1-24
/test pull-kueue-test-e2e-main-1-25
/test pull-kueue-test-integration-main

/hold

/retest pull-kueue-test-e2e-main-1-23
/retest pull-kueue-test-e2e-main-1-24
/retest pull-kueue-test-e2e-main-1-25
/retest pull-kueue-test-integration-main

/test all

/test all

/hold

/test all

/test all

/test all

The flaky integration test is already reported
/retest
/hold cancel

@alculquicondor when you get a chance do we want to merge?
I also have https://github.com/kubernetes/test-infra/pull/28304 to mark these as required jobs.


JW version

What language are you looking for? English

What version is it? JW at https://www.jw.org/en/library/bible/nwt/books/

Do you know, is there a public bible API for it? I don't think so

Sorry to say so,
I have to
but there is no Public API for this, it would be not be easy to implement this, I would close this for now.


Remove --stats when we upgrade to Snakemake v8

Follow up to https://github.com/nextstrain/ncov-ingest/pull/451.
We are using the Snakemake --stats flag to get workflow stats for GISAID and GenBank ingest to help with #446. If/when we ever upgrade Snakemake to v8, the --stats flag is no longer supported and will need to be removed.
Upgrading Snakemake is dependent on updating the nextstrain docker-base image and then running the update-image workflow in this repo since the workflows are using the nextstrain/ncov-ingest Docker image.
Alternatively, we can pin Snakemake <8 in this repo, but we can make that decision later.

I don't see why we shouldn't support snakemake 8. I think it's bad we get stuck at old versions and can't use new features.
It's good that we are updating now but I agree that pinning should be easy workaround in case we don't have time to change the worklow immediately


Upgrade plugin to use Eleventy v2 (beta)

Upgrading to v2 of Eleventy enables a number of simplifications:

pathPrefix no longer needs to be set in both plugin and Eleventy configurations. And as a result of this, you don’t need to set assetsPath in the plugin options if you are hosting the site on a subpath.
dir.output value (or it’s default) can now be provided to the generate assets event
Can use a less troublesome, less likely to be get hidden eleventy.config.js file name for configuration, instead of .eleventy.js. Both names are supported, but now recommend the former.

Plus all the other benefits of using v2 of 11ty.

This would be a breaking change right, so a v5 release of the plugin?

Yep, very much a breaking change. Also thinking of also incorporating more blocks in layouts, meaning the design history layouts need less adaption. This would mean v5 would include:

Eleventy 2.0 features (faster builds etc.)
Simpler configuration
Tagging
Post and page layout regions

Should we keep this in a branch, out of main, until v2 of Eleventy is out of beta?

I guess we could maintain a separate branch, with instructions on how to install the plugin for Eleventy 1.x from a GitHub branch directly.


feat: use Uuid as mint and melt quote ids

Description
This PR changes the type of mint and melt quote Ids to Uuid rather than String.
It required changes in some field types along with some trait signatures.
It will improve the code security by manipulating check Uuid, instead of string that can be anything.
It will also improve performances as Uuid fit on less memory [u8; 16] than its string representation. Same for database.
It also avoids some memory allocation by being Copy. So no need to clone.
It also avoids mixing different types into String. Eg. In nut17 there was a part where both PublicKeys and Uuid were represented as the same type String and fed to the same method. This is really error prone and should be avoided.

Notes to the reviewers
I did not write the migration to modify the Ids of the tables in the different database from string to uuid/bytes or whatever is the underlying representation.
Can you do it as you are more familiar with the multiple database supported and the way to write and test those migrations.

Suggested CHANGELOG Updates

CHANGED: use uuid as identifier for mint and melt quotes

Checklist

[x] I followed the code style guidelines
[x] I ran just final-check before committing

Thanks for the PR.
Since the quote id being a uuid is an implementation choice and not something that is defined in the NUTs we cannot enforce or expect a mint to return and a uuid in the wallet. However, maybe for some of the reasons you stated above it would be worth using the uuid type internally for the Mint and enforcing it there. Internal types like MintQuote, MeltQuote could use the uuid type and then types like MeltQuoteBolt11Response would have to stay string.
What do you think?

@thesimplekid can you find time to review this this week?

Yes sorry for the slow review. Will be done tomorrow.

@thesimplekid thanks for the review! I will get back to it on Monday

@thesimplekid ready for another review

ACK f101a0ab10d77953f3051b6d3f86066dab86de41


fix readme broken links

Pull Request
What does this PR do?

fix some links in the readme

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

@guimachiavelli can you review the PR?
Especially

check that broken links are expected
the removed section should indeed be removed


Update Pandas tutorial

Updated the links to pandas' documentation,
Corrected typos,
Unified code styling by removing/adding spaces in some code blocks,
Deleted a section on the append() method, because of deprecation warning (FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.),
Sorted people frame by body_mass_index before plotting the line,
Removed unnecessary %matplotlib inline and changed np.object to object to hide deprecation warning,
Reversed an article in the matplotlib tutorial (#9) :)

Woohoo, another day with an awesome @vi3itor PR! Thanks so much. 👍


feat(zones): Add PurgeCacheContext method

Description
Support context for purging cache.  Adds a *Context method as suggested in #324, and used in ListZonesContext.
Has your change been tested?
No. There are no tests for the PurgeCache method currently, which makes it difficult to add tests for such a small change.
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation. (I think?)
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks Sebastian!


[ROS2] "no such command" for using "colcon build --merge-install" on Windows 10

Hi guys,
I am learning about ROS2 on Windows 10 today.
I tried using the command "colcon build --merge-install", as the tutorial said

But the terminal showed "no such command" for colcon.
Any answer or idea will be appreciated!

Please ask these kinds of questions on https://answers.ros.org.  That way they are all in one place and are easily searchable later.  Thanks.  I'll close this out for now.

Hi @clalancette , I have asked this question in https://answers.ros.org, but until now, there has been no one who answered my question.

@songyuc you have to wait more than two hours most of the time.

@christianrauch , thanks for your tip.
I will check the ROS Answers tomorrow.

I have asked this question in https://answers.ros.org

@songyuc If you make a statement like this then also use a link to point to your question and don't expect readers to go and search for your question.


Refactored away CurrentUserSettings mixin

no issue
Mixins are deprecated in Ember so we want to remove their usage. The CurrentUserSettings mixin was used in Route files to provide transitionAuthor() (that also transitions contributors) and transitionEditor() methods so the the consuming route could use them to prevent access to authors/editors. In practice the only reason this was used was to prevent access to admin-only routes.

added an AdminRoute class that inherits from our AuthenticatedRoute class

when any route inherits from this class it will only allow access to admins and owners, any other user will be redirected to the home screen (dashboard or site depending on permissions)

updated all of our admin-only routes to use the new AdminRoute

allowed for removal of CurrentUserSettings mixin usage
allowed for beforeModel() hooks to be removed from consuming routes in many cases
some admin-only routes were extending/inheriting directly from Ember's Route based on the assumption that the router hierarchy would have a parent route perform the redirect. Those have also been switched to AdminRoute for consistency and to prevent accidentally making them available if the router hierarchy changes
/#/settings does not use the AdminRoute so that it can redirect to the current user's setting page for non-admin users

removed CurrentUserSettings mixin file
cleaned up unnecessary computed property and function used for redirect-when-disabled in the Zapier route

Codecov Report

Merging #2200 (dfc39f9) into main (8f4c133) will decrease coverage by 0.19%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
- Coverage   37.43%   37.24%   -0.20%
==========================================
  Files         535      533       -2
  Lines       21219    21134      -85
  Branches     3857     3849       -8
==========================================
- Hits         7944     7872      -72
+ Misses      13275    13262      -13

Impacted Files
Coverage Δ

app/routes/member.js
75.00% <ø> (ø)

app/routes/members.js
100.00% <ø> (ø)

app/routes/offer.js
65.62% <ø> (-1.05%)
:arrow_down:

app/routes/offers.js
100.00% <ø> (ø)

app/routes/settings/code-injection.js
83.33% <ø> (-3.04%)
:arrow_down:

app/routes/settings/design.js
100.00% <ø> (+7.69%)
:arrow_up:

app/routes/settings/design/change-theme.js
100.00% <ø> (ø)

app/routes/settings/design/change-theme/install.js
0.00% <ø> (ø)

app/routes/settings/design/change-theme/view.js
85.71% <ø> (ø)

app/routes/settings/general.js
90.00% <ø> (-1.67%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c133...dfc39f9. Read the comment docs.


Keep max range values in native units

Fixes leeyuentuen/polestar_api#109

this can be closed? normally fixed in 1.6.6 or 1.6.7?

Yep.  This was fixed.


Use key event schema to synchronize PK changes

Key schema change events:
https://debezium.io/documentation/reference/connectors/postgresql.html#postgresql-delete-events

it seems like best way to support schema evolution is using event schema itself which enables broader full schema evolution options including PK. closing this one. #49 should cover PK changes too


Image:when create image ,the input  image name the show message is not friendly

In GitLab by @tmon546596046 on Mar 16, 2018, 16:28

In GitLab by @yhua123 on Nov 8, 2019, 07:47
duplicate #982 #1718
using #1718 follow this issue.

In GitLab by @sokril on Nov 8, 2019, 08:19
closed


prevent chatbot from learning curse words & replying with them

is it possible to prevent a bot from either learning fowl language or avoid learning it entirely?
i let other people test my chatbot and they immediately taught it how to swear

you should write an adapter for it and on that adapter check if that has the course word, then leave it. it can be based on ml/dl techniques

you should write an adapter for it and on that adapter check if that has the course word, then leave it. it can be based on ml/dl techniques

Yeah, that's correct.
You can also just create a list that will contain all the words you term curse word and when a client sends a message, if the content of the message is contained in the list of cursed words then you can replace the word or something you decide!
Example
Cursed_words = [{"stupid":"stp**d"}, {"fool":"***"}]
#I want t


Exports by ordinal shall not have hint

If some DLL exports a function by ordinal only (not by string name) it shall not have a hint. Hint is for name exports. It is a hint index into name pointer table to kick off binary search for that name. I'm not sure why would you subtract one from the ordinal and tread it as hint. Note that ordinal base is not always equal to one. Please see attached screenshots. Note that you have similar issue when all exports are ordinals and none of them is name, this issue manifests itself even if there is some exports by ordinal and some exports by name.

Oh I forgot: I tested this on v1.9.312 downloaded from https://ci.appveyor.com/project/lucasg/dependencies/builds/30521285.

Okay fixed it : 994ba58790f88e381f9fc0ac2c8d635106225f01
(wtf, now github automagically fix issues based on commit title ?)

Hi Lucas, I think you meant commit 1d6f1a07e3123fc19150a4f95bef98f80844247f but you mentioned commit 994ba58790f88e381f9fc0ac2c8d635106225f01 instead.
I tested build version 1.9.321 downloaded from https://ci.appveyor.com/project/lucasg/dependencies/builds/31478826 and I confirm that there is no longer an invalid hint for ordinal-only exports. Good job. Thank you.
Unfortunately, in the original comment I mentioned that I don't understand that you how you compute the hint. You just subtract one from ordinal and declare it as hint. This is wrong, I created issue #130 for you to fix this bug.


Problems building

I'm having real trouble building a caddy image, both locally (on Ubuntu) and using dockerhub.
I'm getting to the "building caddy" stage and then I'm randomly getting:
go: finding [module name]
go: error loading module requirements
error at 'building caddy'
It randomly stops on different modules, you see a noticable pause on finding and then the error appears, so it's like it's timed out trying to find the module and doesn't retry, just fails.
I cannot for the life of me get caddy to build.
Help!

This only seems to affect version 1.0.0, if I change the Dockerfile to use 0.11.5 then it builds correctly with the cloudflare plugin, switching back to 1.0.0 breaks it.

It's similar to this https://github.com/abiosoft/caddy-docker/issues/185. Not all plugins support Go modules yet, which is a requirement for caddy 1.0.0.


[REEF-193] serialize http header info with HttpRequest

This PR is to add http header data cross the bridge

Update http request schema to add header entry
Update AvroHttpSerializer at java side for the change
Updated ParsedHttpRequest to return the header info
Update test java cases
Updated AvroHttpSerializer as C# side
Added test  project for Common.Tests
Added unit tests cases for http serializer in C#

JIRA: Reef-193. (https://issues.apache.org/jira/browse/REEF-193)
Author: Julia Wang  Email<EMAIL_ADDRESS>

PR merged.


[Monitor]:sparkles: remove useless tag 'namespace' in metric meta

The namespace tag is useless and duplicated with the metric name, and remove it.

done in https://github.com/TuGraph-family/tugraph-analytics/pull/221


Integrate the FSA and other location services

This patch series, provided mostly by Matthias Bloch<EMAIL_ADDRESS>integrates the Fuel Stop Advisor and other location-based services to a greater degree than is currently in the GDP.
The integration is to the extent that you can run the script launch_gdp_fsa.sh and an app will appear that lets you plot a route, display it on a navit mapview and be notified that fuel is low, with a prompt to search for the nearest fuel station.
If things get messed-up, run the script kill_gdp_fsa.sh to clear it, and run the launch script again.
Note that this is not integrated in the GDP HMI, or in systemd.
For more details on how it should be run, see https://at.projects.genivi.org/wiki/display/NAV/IVI+FuelStopAdvisor
I have tested it myself, and while it's unstable in its current form, it's a good starting point for further integration work.

I can't fully comment on all of the commits (nicer if they were broken up but not the end of the world), if possible I'd expect to see questions here answered by PSA

Having received confirmation via E-mail from Matthias Bloch that this pull request is as he expected, I am happy to merge this.


Add new Beef Icon

Type
Icon request
Info
Ref:
https://github.com/beefproject/beef
https://beefproject.com/
Icon(s)

All issues are temporarily on hold. Please refer to #316 for more info.

Hey, this icon has been added in the new-standards branch and will be merged once it is done!
https://github.com/walkxcode/dashboard-icons/blob/new-standards/png/beef.png
https://github.com/walkxcode/dashboard-icons/blob/new-standards/png/beef-light.png
https://github.com/walkxcode/dashboard-icons/blob/new-standards/svg/beef.svg

Thanks for this @walkxcode!! Just curious which tool you use for easily creating/converting the images?

I used https://deeditor.com to change the colors. And https://ezgif.com/svg-to-png to convert from SVG to PNG. (Deeditor also has a conversion option available, but I avoid using it as it gives massive file sizes compared to ezgif).

thanks, which tool do you use to resize the image?
Going forward I'll start creating PRs and submitting new icons 🙂


Use of Instant::now() does not work on wasm32-unknown-unknown

The underlying sys_call is not implemented for Instant::now() for the wasm32-unknown-unknown target (unless recompiling rust with xargo and enabling wasm_syscall):
panicked at 'Time system call is not implemented by WebAssembly host', src/libstd/sys/wasm/mod.rs:302:13

Stack:

Error
    at Module.__wbg_new_59cb74e423758ede (webpack:///../pkg/spawn_chain.js?:181:26)
    at __wbg_new_59cb74e423758ede (http://localhost:8080/bootstrap.js:65:102)
    at console_error_panic_hook::hook::h8df71f3722ab18fc (wasm-function[194]:292)
    at core::ops::function::Fn::call::h42e98a3c026ddf0b (wasm-function[776]:3)
    at std::panicking::rust_panic_with_hook::h3f94f83752aaaaa5 (wasm-function[314]:265)
    at std::panicking::begin_panic::h6beec07bc67d7532 (wasm-function[613]:40)
    at std::sys::wasm::TimeSysCall::perform::h27f1627f17fac1d9 (wasm-function[721]:13)
    at std::sys::wasm::time::Instant::now::h34de02a8c4aa47a2 (wasm-function[770]:3)
    at std::time::Instant::now::h70048c3feeca6e27 (wasm-function[791]:1)
    at parking_lot_core::parking_lot::HashTable::new::h1383e3e985aa35d8 (wasm-function[208]:53)

Finding a way to substitute the use of Instant in configuration or using a hooks system would be helpful to make this work for wasm32-unknown-unknown to allow plugging in a time source that works for Web vs WASI, etc.

@KronicDeth I created a PR for this which was merged today. It will soon be published and it makes the RwLock operable on wasm32.

@Amanieu I suppose we can close this one then, right?


Full dex solution

DO NOT MERGE
This PR is to show the diff of the dex against what is already on master.

Closing because this content is now a proper tutorial at https://github.com/Off-Narrative-Labs/Tuxedo-Order-Book-Dex-Tutorial/


Upgrade Xcode to 10.3 for all device lab macs

It seems that the iOS CPU/GPU measurement only works on Xcode 10.3 (and 10.2). Currently, mac3-7 are using Xcode 10.1, while mac1, mac2, mac8-10 are using Xcode 10.3 (or 10.2).
Can we please upgrade all Xcode to the same version 10.3 so the test could pass on any mac? This would allow us to unblock https://github.com/flutter/flutter/issues/33899
@digiter

This is a duplicate of #39921


React Class Component Deprecation

Design Doc:
https://docs.google.com/document/d/1yVqzirMLdLTaoB68IYUJ0vNArj80IaFs9-5CVUFht9o/edit
Proposal
Problem: React class components are being deprecated and our code has various complex higher order components, complex classes with many single-use methods, and render props patterns that are fairly confusing. Additionally, many modern React developers are no longer using these patterns nor are they typically being promoted or taught to new developers which presents a barrier to entry for our codebase. Basically, we have a New Expensify, but an Old React.
Solution: Let’s switch to writing function components by default in Expensify/App and disallow writing any new class components moving forward. We will discuss how this might look and if we want to do this and which hooks we would use, best practices for using them, and how we can migrate our codebase.
Tasks

[x] Post Proposal (full Problem/Solution statement) in #expensify-open-source
[x] Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
[x] Paste Proposal in the space above with a link to the Slack thread
[x] Email<EMAIL_ADDRESS>and paste in the Proposal
[x] Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
[x] Email<EMAIL_ADDRESS>(continue the same email chain as before) with the link to your Design Doc
[x] Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
[x] Fill out the High-level of proposed solution section
[x] Email<EMAIL_ADDRESS>again with links to the doc and pre-design conversation in Slack
[x] ~Add the DesignDocReview label to get the High-level of proposed solution section reviewed~
[ ] Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
[x] ~Confirm that the doc has the minimum necessary number of reviews before proceeding~
[x] ~Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.~
[x] Fill out the Detailed implementation of the solution and related sections.
[x] ~Re-add the DesignDocReview label to this issue~
[x] ~Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary~
[x] ~Confirm that the doc has the minimum necessary number of reviews before proceeding~
[X] ~Email<EMAIL_ADDRESS>one last time to let them know the Design Doc is moving into the implementation phase~
[ ] Implement the changes
[ ] Send out a follow up email to<EMAIL_ADDRESS>once everything has been implemented and do a Project Wrap-Up retrospective that provides:

Summary of what we accomplished with this project
What went well?
What could we have done better?
What did we learn?

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

Sorry this is not a "new feature"

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

The latest on this is that we have taken some issues off HOLD and continue to develop our best practices before opening up to external contributors. There has also been some conversation (aided by @puneetlath) to drop the job offer price for these issues to $250 as they are significantly easier than our usual bug fixes. Once we are done with the internal migration we'll make a general announcement in #expensify-open-source and open things up to the community to finish up the majority of the work.

I have read and reviewed this Design Doc!

Took a few more issues off hold recently and made them Weekly. I'd estimate we are about 1/3 of the way done with the "internal" part of this implementation and it's moving slow since we deprioritized this project.
As most of the available roadmap issues are assigned out I'm going to start pinging people to get these done (they are not super complex) and we will then offload it to the community to take us to the finish line.

Pretty cool regardless! Great work.

Got a bit caught up with App deployer duties this week. Will try to put together an update on this tomorrow and share in #engineering-chat so we can figure out the next steps.

I think everyone is focused on EC3 right now. Once we are on the other side - we'll pick up the pace on this project or pass it to contributors. I'm reluctant to force either right now since I don't want to create a deluge of PRs that need to be reviewed internally and everyone is a bit pressed at the moment.

Just a heads up, I'm going to be OOO from May 23rd to May 30th.
I'm going to stay assigned since I think I have the most context on where things are at. But if someone wants to proceed without me or try to figure out how to start passing issues to contributors I am OK with that. I still feel like there are more urgent priorities for us to get to before we tackle these issues.

Is it worth posting this update in open source as well?

Considering that we've remained largely silent about this project WRT contributors and only vaguely hinted at possibly needing their help on it eventually - I feel OK with not updating the public channel for now.

I have read and reviewed this Design Doc!

It sounds like maybe I need to sync up with @neil-marcellini and @hayata-suenaga on how to best combine efforts with the TypeScript initiative.
Honestly, the internal response to doing these refactors has been... meh. lol.
It makes sense as we've all got more visible and higher value tasks to work on.
Given that we are still "busy", but not nearly as pressed as we were pre-EC3. I think we should offload the entire project at this point to contributors and keep building out our set of "best practices" on the fly.
Here's my proposal:

Merge the best practices we've landed on and FAQ guidance in it's current state (there's one bit about useMemo() and useCallback() that needs to be updated as per Tim's feedback)
Starting next week, anyone who is still assigned an internal issue I'm going to ask them to unassign and apply the External label.
We'll offer those issues to contributors at the reduced rate (as previously discussed)
Any new conversations that pop up related to best practices we will hash out in realtime. I feel pretty good about that since there really haven't been a ton of controversial discussions so I don't even think this needs much "management" from anyone and we should just pull out all the stops. I am good to take on the role of manager and moderate any conversations and update our docs until we are done.

@puneetlath thoughts on that approach?

That sounds like a good plan to me!
The only feedback from me is maybe let's open the issues up in waves. Just so we don't have 200 new issues/PRs to manage all at once.

It sounds like maybe I need to sync up with @neil-marcellini and @hayata-suenaga on how to best combine efforts with the TypeScript initiative.

I believe what we decided on was that we won't migrate a component to Typescript until it's already migrated to a functional component to avoid merge conflicts. I think it's a good idea to make these issues external and get the functional migration moving faster. If a component wasn't migrated by the time we get to it for TS, we're planning to tackle the functional migration for that component too. So ideally it's migrated before we get to it. We're planning to start migrating simple "leaf node" files first so there should be enough time to migrate most components to functional first. cc @hayata-suenaga to confirm.

Ok thanks for the thoughts everyone. I left an update here in Slack that lays out the rules of engagement for this one and bumped all the internal engineers holding open assigned issues.
I'm going to check back in on the project at a weekly cadence and do the following:

Check to see how many issues are open and unassigned
Post in #expensify-open-source to update everyone on the progress
List any open unassigned issues looking for a contributor to take on

Making slow and steady progress here so I will keep leaving weekly updates on where stuff is at.
As far as I can tell, progress has been great and we haven't run into a ton of conversations that needed any serious discussion. There was one thread here about function signatures getting inconsistently applied raised and @roryabraham came up with a quick solution to help enforce the best practices 🙇
Issues done: 40
Issues in progress: 28
Issues assigned on hold: 9
Issues on HOLD: 134
I'll take another set of issues off HOLD once we are down to 10-15 in progress.

Alright spoke with @puneetlath in this thread and looks like we are going to take some more issues off HOLD. We are still on a "merge freeze" so there is less of a concern about burdening people too much with these reviews.
I will post an update in #expensify-open-source today with the next round of issues.

Issues done: 57
Issues in progress: 40
Issues on HOLD: 112

Issues done: 63
Issues in progress: 34
Issues on HOLD: 112
I'll wait to see how many we finished by Friday and then take some issues off HOLD on Monday. Merge freeze is over so it feels like we will have some capacity to do some more of these.

Issues done: 75
Issues in progress: 28
Issues on HOLD: 106
Going to take another 10 issues or so off hold.

Issues done: 94
Issues in progress: 24
Issues on HOLD: 91
Looks like we are nearly at about the 50% mark for this project 🎉
Will take another 10 issues off hold tomorrow.

Done (or closed): 113
In progress: 22
On Hold: 74
Will take some more off HOLD on Monday. Expert contributors have been steadily picking this off as well as precursors to various other projects so this hasn't required too much management on my side.

Done: 135
In Progress: 27
On Hold: 47
We're down to less than 50 issues on hold 😱 🎉
Maybe we can pull out the stops here and take them all off HOLD next week.
Feels like everyone has a pretty good understanding of the best practices at this point.

There are only 37 issues on HOLD left. They are slowly getting picked off by expert contributors. But I think we should be done here before offshore so gonna put a Monthly on this for now.

There are only 18 issues left that are still on HOLD. Since there are a lot of projects under tight deadlines during Offshore I am not going to push too hard to get them done so that we can sustain maximum focus on those goals. That said, if any expert contributor groups want to pick them up I am happy to assign them.

177 issues completed.
32 issues in progress.
0 issues on HOLD 😮
👏 al 👏 most 👏 there

19 components left. All in progress. 😮 🪝

There are 12 open issues. I think we can wrap it up by the EOY. Will go around and bump the remaining issues.

Last 4 issues are in review. Not sure if we will finish finish by EOW, but since the remaining work is in active review I'm just going to close this tracking issue and consider this DONE.
Any new components should be functions. Any remaining class components can get refactored as time permits. We did a ton of work here, but should remove this as a distraction for 2024 and move the focus to Wave/VIP issues.

Thanks for leading the charge here @marcaaron! I think it had a very good impact in modernizing our codebase and making a lot of the components simpler.


Use my own component inside dx-form

To help us process the issue more efficiently, please provide the following information:

Specify the version of the devextreme-angular and devextreme packages you are using.
devexteme version: 17.1.3
devextreme-angular version: 17.1.3

Specify the type of the issue (check one with "x"):
[ ] bug Report
[ ] feature request
[x ] support inquiry

Actually I do this and it's work. But when I used my datasource "questions" in dx-tree-view the old selection of tree change with the value of my new selection.
<dx-form [formData]="questions[selectedIndex]" (onFieldDataChanged)="onFormUpdated('form',$event)">         <dxi-item [label]="{text: 'title' | translate}" dataField="title">           <app-multilang [value]="questions[selectedIndex].title" (onValueChanged)="onFormUpdated('title',$event);"></app-multilang>         </dxi-item> </dx-form>
Can I use the "dataField" of dxi-item directly with my component ?

If you need to provide a dxForm item with a custom editor, it's correct to use the item template. Since you use a custom template, you need to manually synchronize the template content with the dxForm bound form data. So, setting only the item dataField option is not sufficient to create a custom editor in the item template display and edit the correct value.

But, you mentioned that the issue occurs with dx-tree-view. I don't see dxTreeView in your code snippet. Provide me with a sample project that reproduces the issue so that I can give you a precise answer. You can create it from the sample Plunker.

This is my plunker with my problem

You can select one question
Modify the "description"
Select a new question

When you select the second question the description of the first question on tree-view change to be the same of the second one.

The cause of the issue is that you are assigning the entire _value object coming from the MultilangComponent to the description field of the selected question in the onFormUpdated event handler. But, when a user selects another question, you don't re-create the _value object and you are changing fields of the existing options. So, new changes are applied everywhere the _value object is assigned. To resolve the issue, create a new ``_valueobject in thevalue` property setter method:
set value(val: object) {
this._value = {};
//
}

See the updated Plunker.

This issue is closed because of being inactive. If you need further assistance, leave a comment here.


GenerateResources incrementality for netcore

Closes #1197.
This implementation is sufficient for current .NET Core--see #1247 for
details. If we start supporting linked resources, this will produce false
up-to-date results and must be changed.
cc @danmosemsft @eerhardt

LGTM thanks @rainersigwald . How do we get the dotnet/buildtools updated (which I guess updates the msbuild for dotnet/coreclr and dotnet/corefx)

:shipit:

Confirmed that this fixes the scenario from https://github.com/dotnet/sdk/issues/284 (on Windows). I'll look at the OS X failure shortly.
@danmosemsft To get this through to corefx/coreclr, we'll need to a) update buildtools and b) update the version reference in those repos. Unfortunately the current MSBuild version is pretty stale so part a) may be nontrivial. @joperezr has done those steps in the past.

Once you have this change in a package, I'm happy to help getting it into buildtools and then to corefx/coreclr.

@dotnet-bot test OSX Build for CoreCLR please
(checking for stability since there's a race condition in a lot of the incrementality tests on HFS+)

@rainersigwald perhaps consider using #ifdef or XUnit attributes if possible so that the increased timeout is only for OSX. Otherwise all runs slow down unnecessarily.

@danmosemsft Good point. Made it conditional on OS.

@joperezr MSBuild packages versioned 15.1.0-preview-000358-00 should have this change. Ping me if there's trouble and we'll work through it.


Update dimensions in profile._data['PR_STN']['FXD'] for new variables

This is the result of heavy confusion on my part documented in #24. Adding variables, to either PR_PROFILE or SURF_CODES, then saving the new file, reading in that file is then not done properly. I suspect this is due to some spillover due to these dimensions not being iterated at the time of adding the variable.

Ok I wrote a function iterate_dimension which seems to work internally but is getting squashed somewhere, because printing out the new dimension in the function shows it is clearly making its way into profile._data but when I try to look at it after running the full script, the dimension hasn't changed at all.

Did it a simpler way and not squashed anymore. Better

Thank goodness


Laravel 9 support

Adds Laravel 9 support, which is in beta right now.
Because of Laravel 9 switching to symfony/mailer from swift_mailer, I added a new createLaravel9Mailer() method to the service provider that binds Laravel Mailer.

Awesome, thank you!


V

What is your question?
Misses is a 'songmisses'
what about bpm, beat and step?

In order of listing, their names are:

bpm or curBpm;
curBeat;
curStep.

In order of listing, their names are:

bpm or curBpm;
curBeat;
curStep.

Thanks


curl or wget

Hello,
In case curl is not available, would it be possible to use wget instead?
Thanks,
F.

Yes.  Any chance you want to write the patch?

OK, I give it a try.

Done in commit f421ea08013d9545eed2c19a3b30c0b20efd2f44


[enhancement]: Log output to console and file at the same time

Describe your feature request here
Is it possible to output the log to console and file at the same time? We have requirements where we want to still see the live output from the agent but want to upload the log to our own observability stack at the end of a pipeline run. I see the agent has -- disableloguploads but this would only get use the file part and we would lose the live stream to the service.

https://github.com/srkidd/azure-pipelines-agent/tree/users/srkidd/enable-stream-and-file-output
I have created a fork and got it working. I have tested locally.

Hi @srkidd thanks for reporting!
We are working on more prioritized issues at the moment, but will get back to this one soon.

Created a PR for it
https://github.com/microsoft/azure-pipelines-agent/pull/4829

Closing the issue, since the related changes were merged in this PR: https://github.com/microsoft/azure-pipelines-agent/pull/4920
Thank you for your contribution!


Clair server fails to start as error in database migrations

When start Clair server, it fails while running database migrations. CREATE TYPE modification AS ENUM ('add', 'del') has error, as the type "modification" already exists. Whether the type needs to be created only if it not exists, like the solution?
Error log
2017-01-05 00:23:43.624421 I | pgsql: running database migrations goose: migrating db environment '', current version: 0, target:<PHONE_NUMBER>3213
2017-01-05 00:23:43.863164 I | FAIL<PHONE_NUMBER>3213_Initial.sql (pq: type "modification" already exists), quitting migration.

PostgreSQL Version
root@fe6e87323938:/# postgres -V
postgres (PostgreSQL) 9.5.4

Last commit
commit 051564facd852ef5bbb62db9625631a21f2199d5
Author: Jimmy Zelinskie<EMAIL_ADDRESS>Date:   Wed Aug 24 14:03:50 2016 -0400

    Merge pull request #236 from robszumski/doc-link

    readme: add link to docs dir

Have tested the latest code in master branch, not found this error.
Still not clear about the root cause, but temporarily close this issue.


Add / Edit Table or Sp from GUI

SQL Operations Studio Version:
0.23.6
Steps to Reproduce:
Right Click on Tables.

Add new menu item to add/edit table and store procedures from GUI.

I'm going to close this as a duplicate of https://github.com/microsoft/azuredatastudio/issues/282 since that issue has a bit more context.  Please add any related comments in that issue.  Thanks!


fix: dotnet JSON Serializer preset does not access accessors

Description
Use pascalCase in JSON Serializer preset
Related issue(s)
Fixes #1448
Test Run Output
test.txt

@all-contributors please add @jamesmoey for code and test


After enhancer installation Notion-app isn't working

The app doesn't start, can't find nothing related to notion exept for this in journald log.
22/10/20 10:49	systemd	app-notion\x2dapp-7aaeef7a0e584d52a5905146723bc23a.scope: Succeeded.
22/10/20 10:48	kwin_x11	qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 65246, resource id: 33555389, major code: 18 (ChangeProperty), minor code: 0
Already tried to remove and re-apply the mod with no success.
If i remove the mod works without issues
platform
Arch Linux, notion-app 1:2.0.8-4, notion-enhancer 0.9.1-1, both installed via AUR.

the notion-app package launch script has changed a bit, enhancer support is still catching up. it'll be fixed in the next release. for now, go into /usr/bin/notion-app and/or /opt/notion-app/notion-app and replace app.asar with app.

I met the same problem on Mac!

@Astatine-213-Tian no, you didn't. This problem was caused by changes specifically to the version of the app for Linux. You've had a similar outcome for a different reason.
Can you provide a screenshot of what it says when you try install the enhancer?


Frontmatter field for adding classes to preview

Sometimes we may want to add a class like u-spaceChildren or u-rhythm to the example output w/o adding additional markup to the source preview. Other times, it's better to keep things simple. It would be nice if we could specify classes via pattern frontmatter and have them appended to the pattern container.

A good idea 👍


chore: updated readme

Created this pull request to test workflows

Verified that Action Tester Workflow does pass and work as expected when the author of the PR is a maintainer. Likely will need to use a GitHub app token with limited permissions for testing


Adds ribbon

Icon Request

Icon name: ribbon
Use case: raising awareness (e.g. breast cancer)
Screenshots of similar icons:

Hmm on 100% the icon is a bit dense. Maybe adding a small gap to the ribbon ends where they overlap?

@ericfennis: I couldn't fit in large enough gaps that still left the design recognisable, it would be something like this:

What do you think about this one instead?

The loop could also go back like this, feels a bit better to me.

Not bad, although also a bit too dense, we could also mix and match the two versions (left and right ones)?

@karsa-mistmere That looks better!


Ability to toggle depths from remote input

I have filters associated with different levels of the tree, as the user toggles which level they are on, I'd like the tree to respond to be open to that level.
I tried passing different values to initialDepth as props, however there is no rerender.
Is this possible?

I've faced a similar issue which required me to pass different values to the initialDepth prop and force a re-mount in order for the Tree to display at the desired depth. What worked for me is, pass a React key prop to the Tree component and toggle that key between true/false whenever a re-render is desired. See the following (very rough) pseudocode:
const dynamicDepth = __;
const forceRemount = true;
const handler = () => {
  // Do stuff
  dynamicDepth = dynamicDepth + 1; // or whatever you want it to be
  forceRemount = !forceRemount;
}
<Tree data={myData}
      initialDepth={dynamicDepth}
      key={forceRemount}
      onClick={handler}
      collapsible={false} />

Changing the value of the key prop passed to Tree will force the component to re-mount (see this stackoverflow response). Of course, this is a very hacky way of accomplishing the desired functionality, and you lose the slick animation when navigating through levels in the tree. Interested to see if there are any better solutions. I think it would be better if we could specify the render depth at any point in the component's lifecycle.

Yeah the initialDepth functionality is pretty rudimentary as it stands currently. It also doesn't do what you expect with async loaded data via treeUtil, i.e. it won't apply initialDepth once the new data set is passed in.
Nice workaround with the key prop @alexlamasBV, hadn't considered that.
Going to prioritise this if it's getting in the way of getting expected behaviour.
Would happily accept a PR from you guys in the meantime since I don't know when I can address this, hopefully before the weekend is over.
Essentially what needs to happen is that the initialRender boolean in the Tree component should reset to true if a "fresh" data set is passed into the component. Then generateTree() + setInitialTreeDepth() should take care of the rest if all goes well :)

@alexlamasBV great workaround - I'm passing key={dynamicDepth} to trigger the change
@bkrem thanks for adding.  I may eventually need the ability to close all nodes at a certain depth as a new one at that depth is opened, so I'm not showing too many nodes.  Right now setting separation={{siblings: .5}} to reduce the space between nodes, the nodes overlap if more than one node on that depth is open.
That being said, I also plan on contributing as I can, right now I'm new to and learning d3.

Hmm I think that's expected behaviour for setting siblings: 0.5, since the number represents a factor of node width. As in siblings: 1, nonSiblings: 2 would mean "separate sibling nodes by 1x node width and nonSiblings by 2x node width" (https://github.com/d3/d3-3.x-api-reference/blob/master/Tree-Layout.md#tree).
What you probably want to do is change nodeSize on the y-axis, that should move the nodes closer together.
Could you add a feature request issue for "collapsing all nodes except the clicked one at depth x"? I'll start thinking about that since it's a good point.

@bkrem good call nodeSize is what I was looking for
I added issue https://github.com/bkrem/react-d3-tree/issues/46, same as mentioned above, for collapsing nodes as a new one opens.
I also added https://github.com/bkrem/react-d3-tree/issues/47 - this is related to reading initialDepth as the data set changes.  The idea for this one is to be able to smoothly use the tree with a set of filters for the data.
Thanks again and please let me know if you need more info.  Hoping this is more helpful than headache!

@bkrem Any updates here? This is a very old issue and this is still troubling us. Can you please take this on priority?


doc: Add new warning when to use KVM

When using KVM, you may encounter issues even if your system appears to be okay. In such cases, using sudo can often resolve the problem.

Yes, I checked, my user and the docker group are part of sudo, I know it's not a good practice to use sudo but this was the way it worked, I can perform other tests here but to simulate the error and even debug the image better...

Same 660

Yes, it works. Do you want decline the pull request, or would you like me to change it and add this warning?


Unify & redirect "How to create a bidder" things

Specifically:

Move 'How to add a Prebid 1.0 Bidder Adapter' content to 'How to Add a New Bidder Adapter'

Copy edits to 'How to Add a New Bidder Adapter', including removing all of the "something something 1.0" language, since we are no longer accepting pre-1.0-format adapters

Redirect 'How to add a Prebid 1.0 Bidder Adapter' to 'How to Add a New Bidder Adapter', and hide from nav

Redirect 'How to add a new video adapter' to 'How to Add a New Bidder Adapter', and hide from nav

Redirect 'Add video support to an existing adapter' to 'How to Add a New Bidder Adapter', and hide from nav

Hey @mjacobsonny would appreciate any feedback on this change (details listed above).  Basically cleans up the adapter docs situation for a post-1.0 world.

I think I've addressed all the feedback, @mjacobsonny  - hoping to merge ASAP, let me know if you would like any additional changes.  Thanks for the thorough review!


10.12.4 beta support?

AppleALC is not being injected by Clover no matter what I set for Inject Kexts/Layout ID.

It's not the problem with AppleALC. This is clover problem. In 10.12.4 old kext injection didn't work. Update clover to 3985 or higher. https://sourceforge.net/p/cloverefiboot/code/3985/
Clover_v2.3k_r3985.pkg.zip


feat: [#23] implemented prefix config

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Documentation
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

The PR fulfills these requirements:

[x] It's submitted to the develop branch (or v[X] branch)
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: [#xxx], where "xxx" is the issue number)
[x] Any necessary documentation has been added or updated in the docs  or explained in the PR's description.

Other information:
https://github.com/digitalfortress-tech/localstorage-slim/discussions/23

Closing, because this is more appropriate to be implemented at the application level (where you define localStorage constants as per your needs)
Or you can also have a helper function, something like this -
const prefixLS = (str, prefix = 'ls_') => `${prefix}${str}`.trim();

// usage
ls.set(prefixLS("hello"), "world");


ARTEMIS-2245 Implement Docker images

It provides both CentOS and Ubuntu Docker images for the Artemis broker.

this looks good, but I think we should add docs.

I will sent a doc commit today :+1: thanks for the review mate!

This looks very cool @franz1981!
A few suggestions:

I'd probably arrange the ARTEMIS_VERSION so that it can be both a variable and an argument to the dockerfile. That way, you are not forced to change the Dockerfile for every release.

ARG ARTEMIS_VERSION
ENV ARTEMIS_VERSION ${ARTEMIS_VERSION:-2.7.0-SNAPSHOT}
LABEL ARTEMIS_VERSION=${ARTEMIS_VERSION}

I think it would be good to label the Centos and Ubuntu images accordingly.
LABEL ARTEMIS_BASE_SYSTEM=ubuntu

Another thing you could do is consolidate the 2 files in one, so you could possibly reuse the container build code post the part that you setup the initial system. But I consider that a matter of personal taste and nothing that could give immediate gains to the image IMHO.

What if we moved the whole docker under the binary distribution? it would be a lot cleaner instead of requiring a new distribution just for docker.
That way users would just be able to turn their binary into docker at any point.
I just sent a PR to your branch: https://github.com/franz1981/activemq-artemis/pull/11

Do we need that label? Can't we just remove it?

Yes, you could remove it altogether. There's no harm in having it there, though. One benefit, IMHO, is that if you are pulling the images by a different tag other than the version (ie.: docker pull apache/artemis:latest), it makes it very easy to find the actual version that maps to 'latest' by just inspecting the container (with docker inspect).

on a second though.. having the docker as part of the binary distribution is not such a good idea.
I have updated the PR on your Branch Franz.

I quite like the idea of a ready to run docker image that we distribute. Much more than an example

Let me take some time to think about the best approach here: I see that the current PR is very dev-friendly (given that a compiled distribution IS the base to create a running docker image), but I would prefer something more user-friendly and self contained eg that download or receive from an argument the URL/zip to be used to build the image.
That would allow the docker file to be self-contained and somehow indipendent from the compiled code...

For me the ultimate would be an image in docker hub, just as we push java artifacts to maven central. Its about making things as easy to consume as possible

That part is a bit more complex as Apache infra is still in early days for this.
What we are trying to do here is to provide the docker files so this could be built anywhere else.

Even if we decided to deploy it as part of apache account, we still need the docker files.. which is this step here.

Another option then maybe like what occurs for some other apache projects (e.g. tomcat and httpd,
), is host it under docker-library and maintain it there, as "official"
https://github.com/docker-library/tomcat
https://github.com/docker-library/httpd

Another option is to have a dedicated submodule specifically for kubernetes, e.g. like Apache Ignite.
https://github.com/apache/ignite/tree/master/modules/kubernetes

For me, docker/kubernetes support is becoming quite a defacto, so think it warrants being a bit more top level thing for us to have, than just being some example.
Just to iterate I think what @franz1981 has done is really great.

@michaelandrepearce looks like there an image available here https://github.com/vromero/activemq-artemis-docker


st-packet-test: thread 'main' panicked at examples/sudt-transfer.rs:789:39

Steps to Reproduce
See https://github.com/synapseweb3/forcerelay/actions/runs/6760631288/job/18374632265#step:13:25

Attach logs here if you have them
sent transaction 6a5c8f48dd1e121d8dbcbef7ace2d075b5d53c036cdc8aed05e34e403adbc822
thread 'main' panicked at examples/sudt-transfer.rs:789:39:
rejected

For Admin Use

[x] Appropriate labels applied
[x] Appropriate contributors tagged

The transaction seems to be confirmed later: https://pudge.explorer.nervos.org/transaction/0x6a5c8f48dd1e121d8dbcbef7ace2d075b5d53c036cdc8aed05e34e403adbc822
It's more likely a ckb mempool issue and not a bug in sudt-transfer cli.
I'll improve the error reporting a bit.

https://github.com/synapseweb3/forcerelay-ckb-sdk/pull/29


BINANCE exchange: many markets not working

When configuring the .yml, if I want to get TA alerts from Binance market NEO or BNB, although they exist I get message that those markets don't exist on Binance (but they're there). BTC/NEO or BTC/BNB for example both trigger this error, also inverting the order NEO/BTC or BNB/BTC, while others (most notable the USDT markets and ETH/BTC and LTC/BTC work.
Not sure what I'm doing wrong to be honest...it makes not much sense to me.

Was an error in formatting, it works calling them BTC/NEO etc.

Actually still having problems with lots of pairs that should be there and the script says they're not..anyone experiencing similar issues?


[DRAFT] Refactor updateFromHTTP func

Description
Refactoring the updateFromHTTP func from updates.
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 35.26% // Head: 35.23% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (3f5dde3) compared to base (ebcd791).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1527      +/-   ##
==========================================
- Coverage   35.26%   35.23%   -0.04%
==========================================
  Files          63       63
  Lines        8739     8739
==========================================
- Hits         3082     3079       -3
- Misses       5255     5257       +2
- Partials      402      403       +1

Impacted Files
Coverage Δ

pkg/routes/updates.go
31.88% <100.00%> (ø)

pkg/services/devices.go
49.54% <0.00%> (-0.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@Saurabh-Thakre why is this a draft?


Public function for creating task filters using all available information in TaskProvider without realization

Expected Behavior
Currently we can add task dependencies like so:
dependsOn(project.tasks.withType<Test>.matching { name == "test" } )

The first function called, withType, according to the docs does not instantiate the Task if they were registered without creating them. This makes sense, given that registration produces a TaskProvider that contains a type and a name.
However, the second filter here will instantiate the tasks. A call to matching instantiates the tasks before they are provided inside of the predicate.
This doesn't take advantage of the availability of task names before they are realized. There should be a way to do the above without realizing all the tasks, since all task registrations know the task name beforehand.
Under the hood, there must be a filter that passed TaskProvider inside the predictate instead of Task. Let's call this internalMatching.
    internal fun <T: Task> TaskCollection<T>.internalMatching(predicate: (TaskProvider<T> -> Boolean)): TaskCollection<T>

Then, assuming the existence of the above function, The withType function above seems to basically be doing some variation of the following:
    inline fun <reified S: T, T: Task> TaskCollection<T>.withType(): TaskCollection<S> {
        return internalMatching {
            it.type.isSubclassOf(S::class)
        } as TaskCollection<S>
    }

This however is not providing users with an important ability to be able to create non-realizing task filters with predicates other than a subclass filter. For example, we may want to include or exclude specific names. Or, we may want to include or exclude specific type hierarchies. Maybe we want to get tasks which are an instance of Test but excluding any that are an instance of KotlinJvmTest.
We don't need more shortcut functions like withType. Users should be able to make any filter they need given the information provided in TaskProvider and not be constrained to a set of shortcut functions. All we need is to make public the ability to filter a task collection based on non-realizing TaskProvider elements.
Current Behavior (optional)
It seems like there is no supported way to create a non-realizing task filter aside from withType.
Context
I have many tasks that depend on a set of tasks created by a matching filter, but where the only information used inside of the matching filter is the name and the class. Therefore, these tasks never needed to be realized in the first place.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team and is prioritized by them.

Relates to:

https://github.com/gradle/gradle/issues/16543
https://github.com/gradle/gradle/issues/8057


Written pur Notes Don't Retain Parent/Link Connection

In Pureref, when you're selecting an image/note then you add a note, it will be attached to the selected item or the selected item's parent. Then when you move the item/parent, the not will always follow it, and if you delete the item, the note will be deleted too.
When you save (write) a pur file with PurFile, the locations/sizes will be retained but the texts will be disconnected from their original parent/link.

Thanks for finding this, it will be fixed after #2 , probably at the same time in over a week.
May be harder since image items and text items are mixed in standard files but files generated with this tool do all images first and all text after. I hope this parenting functionality just works with IDs and doesn't require a specific order in the file requiring a write() restructure.

Fixed in #bfb842e
If you read and write a PureRef file, text items now stay parented to their parent image or parent text. You can create parented text from scratch by creating a PurGraphicsTextItem and putting it in either another PurGraphicsTextItem or a PurGraphicsImageItem which now share the same Item superclass. Be careful not to add children to text that is already a child since the software PureRef does not support recursive parenting (yet, probably never).
Thank you very much for pointing out this missing feature. I'd love to hear any suggestions, requests and complaints (maybe about purformat.py having become too big haha). And I'd love to see what you make with this tool (: you could tag or DM me on Twitter with @FyorDev.
The way text parenting works, is that some of the bytes at the end of a text/image transform indicates how many of the following text items should be parented to it, and these text children are not counted in the header.

Be careful not to add children to text that is already a child since the software PureRef does not support recursive parenting (yet, probably never).

It DOES do children of children, it's just a bypass/glitch is needed to get it to work.
What you first do is create a text, while selecting it: add a new text, creating the link. Next, you copy and paste them to something they're NOT linked to.
They will then keep their original attachment, whilst also linking to the new parent.
I was expecting the update to just detach the notes but Pureref offset at least one of my texts (still attached) but detached and sent the rest to the center.

Thank you very much for pointing out this missing feature. I'd love to hear any suggestions, requests and complaints (maybe about purformat.py having become too big haha). And I'd love to see what you make with this tool (: you could tag or DM me on Twitter with @FyorDev.

Suggestions, Requests and Complaints:

PurFile.read() does not seem to reset the items loaded, just append them, creating jumbled data. I assume this is to allow merging files but I don't know the results of such a file, and it's just an inconvenience for me, requiring a new PurFile() instance for every file.
The classes could have helper functions, to allow usage without needing to make new code for basic tasks.

For example: image.load()/image.save()

.add_note(text="Note")

arrange/align/normalize functions from pureref

re-arrange image order (I assume images )

set the pureref_gen_script.py to use input(), maybe with a notes printed as explanations, so that if someone runs it, they can specify where they want it to run
~setup a __init__.py to place this in the modules folder~

Merge the export scripts to one file and maybe move it away from purformat.py.
It's not obvious that neither is needed and is just a usage example.
pureref_gen_script.py can go in a if __name__ == "__main__":

Obvious: Have the formatter write so that pureref doesn't see them as corrupted.

I assume you meant for me to tell you this stuff here on github (or as a new issue), and then message you on twitter if ever I finished a script/tool using this access into .pur.
I don't mind messaging you, just all I'm doing inside pureref is updating numbers/links in notes attached to images (and adding new images), as per my usage of pureref.
The way I use pureref is I add an image, then add notes centered above/below it: if it's named (for example a tv series), the above contains the relevant titles for the series, and below contains url links, the episode number  [seen / available-total], summary/description, watched date, etc.
If it's not named, for example a screenshot of a webpage, the I just attach the url above, and MAYBE a description somewhere.
(I also normalize their sizes relative to a certain image that I duplicated a few hundred times)
And so I can use python to log which series have been updated but with this, I don't have to manually update the numbers, I can have the updater also update the notes.

Thanks for the guide to create recursive children, I'll add that. I will try to replicate notes returning to center so I can fix that too. It's weird because even if transforms can be relative this shouldn't matter since it just copies whatever is in the original transform.
If I get to it, I'll keep helper functions that are likely needed in mind. I think I should pull apart purformat.py first. And I'll merge the gen scripts or hide one part in a subfolder. The problem is that there is a huge number of operations you may want to perform, if I make functions for every way you may want to manipulate the data I'll have made the entire backend for my own reference software. I'd rather supply the raw data which is now in an easy to use shape, so that you can make functions for the specific things you need, but I will think about it.

set the pureref_gen_script.py to use input(), maybe with a notes printed as explanations, so that if someone runs it, they can specify where they want it to run

You can give the script commandline arguments since b486b67, and I'd like to avoid having to press enter twice for defaults because that's the only thing I use.

Have the formatter write so that pureref doesn't see them as corrupted.

I looked into this when I finished reverse engineering all the contents, which I wasn't even sure I would do for text too since I only need it for images. But I gave up on figuring out the checksum, I don't know what algorithm they use with what parameters on which part of the file.
If I wanted non-corrupt files, I'd make a script that opens it in PureRef, waits for it to load and hits CTRL+S (:
But I decided to accept that this should be done by hand, the project already got this far and I wasn't sure everything that this tool can now do would even be possible at first.

I assume you meant for me to tell you this stuff here on github (or as a new issue), and then message you on twitter if ever I finished a script/tool using this access into .pur.

Yes, I appreciate it!
It's fun to hear how you use PureRef as a kind of database, it's such a versatile software.

I couldn't find the time for a while, but it's all fixed now.
 All thanks to your description of the bypass that's needed.

Cool beans yo.
I assume 14c8230 is why the file also doesn't give any warnings on load either.
If that is the case, I'm curious as to what would happen without the child-fix.
Would pureref load the files with and just break the links with no warning?
I'm curious because from what I can see so far, it's a standard pur file but what if there was something else that get's lost from the files?
And if pureref would tell you if there was, then what if you could store things pureref can "use" but doesn't "do/save", like linking images to other images.  I'm sure it could do this but just doesn't in order to retain images (as it's goal) unlike texts, and choose not to give the option to users.

I assume 14c8230 is why the file also doesn't give any warnings on load either.

Yes, it was quite a challenge but I figured out that they use md5 for the checksum on al bytes after 0x6C, I didn't think I would ever figure out how to fix this issue but I just gave it another try while I was working on the repo again.
Without the child fix the same would happen as before and it would just forget links, child text is the same as any other text except that the previous text item indicates the next N items are their children ( apparently recursively, so the next N that aren't already children of its children ). the checksum should have no effect on that.
There are probably many things you could get the software to do, maybe parented images is possible if PureRef expects a number of generic items as children instead of text specifically.
There are definitely a lot of things you could do with the cropping points, such as generate a circle or give an image round corners.


Smarter optimizer

Instead of merely looping optimizations around the optimizer should be smarter about selecting different optimizations to run.
For instance, it could run a gradient descent-like search in the space of optimized programs. Then the compiler optimizations can be guided with a specially crafted score function - either to minimize code size, or maximize performance.

Some things still to try:

[ ] Add a third "complexity" measure so that it prefers less complex code.
[ ] Add a fourth "further optimization potential" measure.
[ ] Run optimizations lazily and incrementally, so that there's no need to inline functions in a branch that is dead.
[ ] Perform a better reachabillity and escape analysis for better treatment of recursive functions.
[ ] Maintain free variable & usage counts incrementally, instead of recomputing them all the time.


Not available through Mod Assistant

The README.md file suggests installing through Mod Assistant, but this plugin isn't available through the Mod Assistant.

Either update the README.md or add it to the Mod Assistant

Use the manuals install instructions.


Unify ProjectRegistrationFormComponent and ProjectFormComponent

The two forms share very similar functionality and should be refactored to unify them. As of #204, the /projects/new route has been removed so that we only have projects/register. This makes it so that ProjectFormComponent is only used for editing existing projects and ProjectRegistrationFormComponent is used for creating new projects. The logic and UI between the two components could be unified so that we only have one component for both creating and editing projects.
This will require a bit of UX work so that we can make the "edit" view more similar to the "create" view. This will have the added advantage of removing the empty tabs in ProjectRegistrationFormComponent that are just there as dummy tabs to keep the UI between the registration and project detail pages consistent. This will also make the "edit" view consistent with the project detail page.

Hey, everyone
I think generally I am fine if you make it so there's just one form, and depending on the occasion - we show or hide fields.
I think a couple of points need addressing - the ones I noticed when going through the forms this morning. I am not sure if there are more fields that need attention? Let's list them in this ticket.

When in 'Edit' view for a wrangler, there's an option for
Lab/Street/Address for every Contributor. My suggestion is to not have these fields for any of the forms (Claire?) - neither for New or Edit

Accession fields - let's make this one and the same for all forms. My suggestion is to just have it as one field that the user fills, and the extra information whether it is GEO, or INSDC, or Arrayexpress, is stored somewhere in the JSON/backend, but we don't need to show 4 different fields to a user. (open for comments). Or, we make it possible to choose through a dropdown what type of accession the user has.

When I revisit the design, I will suggest:

all fields which deal with the triaging, to appear in one block
the help texts to be available as 'i' icons
the fields for the forms to be in line with VF, and review the patterns for multiple selects, error handling
(will see what else)

Gabs

Testing procedure:

[ ] Can navigate to the register project page when clicking the button on the home page
[ ] Can navigate to the register project page when clicking the button on the all projects page
[ ] Can create a project by using the autofill DOI feature
[ ] Can load a previously cached project that had not been finished
[ ] Can register a project

[ ] When registering a project, any missing fields or validation errors are highlighted with red and a message

[ ] The register project form has the same functionality as before (check against prod)
[ ] Can edit a project
[ ] The edit project form has the same functionality as before (check against prod)
[ ] When navigating tabs in the create/edit project form, the URL updates, refreshing the page returns you to the same tab
[ ] When navigating tabs in the view project page and then clicking "edit", you are taken to the corresponding tab in the edit form

I'll pick this up - will try and do it today, but if not might wait until tomorrow!

Have completed the testing, and made a couple observations! Apart from that it all looks great.

'Restore project' could be made to be slightly more noticeable (I almost missed it!)

For the Publication DOI (New Project - start), it might be a good idea to add
an example text for the doi prompt. E.g. 0.1038/s41577-021-00564-5

This is because some people might enter https://doi.org/10.1038/s41577-021-00564-5 instead of 10.1038/s41577-021-00564-5

When registering a project, missing fields / validation errors are highlighted with red and do have a message - but the error message appearing is not very helpful. Will be fine for wranglers, but for project contributors, it could be very helpful to have a list of errors accompanying the error message.

Current error message is:
Some fields in the form are invalid. Please go back through the form to check the errors and resolve them.'

Thanks @Wkt8 !
Since these comments are not directly related to this work, I will leave this for @gabsie and get this in production

Hey @jacobwindsor
I entered as a wrangler in prod and saw the Contributor doesn't have a name, we must have lost it along the way.
Gabs

moved the contributor name to be the top field in the form:
PR: https://github.com/ebi-ait/ingest-ui/pull/114
Screenshot of project creation form -- contributors tab

awesome, thank you!!


[dv] Added keymgr_sideload_agent and integrated it with otbn and kmac TB

Following additions/ modifications have been made in this commit:

Added key_sideload_agent and related files.
Integrated key_sideload_agent with OTBN and KMAC TB.
Added key_sideload_set_seq to set keymgr interface.
In OTBN TB, key_sideload_set_seq runs forever changing keymgr
interface values every few (randomized between 10 to 100)
clock cycles.
In kmac_smoke_vseq, key_sideload_set_seq is called to generate keymgr
interface values.

Signed-off-by: Prajwala Puttappa<EMAIL_ADDRESS>

We have a discussion a few months ago about if we need an agent for sideload interface at #8944, then we decided to create a common interface https://github.com/lowRISC/opentitan/blob/master/hw/dv/sv/key_sideload_if/key_sideload_if.sv.
Not sure if an agent is better since it's pretty simple - it only has key and valid without any handshaking.

I think I changed my mind :-) And OTBN and AES want the same thing (which seems to be different from what KMAC's testing is using). This should be a bit cleaner than a mess of different tasks that interact with a common interface (which would be essentially the same thing, but not using the UVM formalism properly).
@rasmus-madsen: I think you want this for AES?

I think I changed my mind :-) And OTBN and AES want the same thing (which seems to be different from what KMAC's testing is using). This should be a bit cleaner than a mess of different tasks that interact with a common interface (which would be essentially the same thing, but not using the UVM formalism properly).
@rasmus-madsen: I think you want this for AES?

this is a 10+ files agent vs 10+ lines interface. So far we only have the seq-driver part in the PR and we also need to implement the monitor as well as connecting with scb. It indeed doesn't improve stimulus/coverage, but add more complexity.
We have some other similar interface (valid with data) in the other blocks as well. Maybe we can think further, how should we handle them properly?
https://github.com/lowRISC/opentitan/blob/b9a1d3134a5095536e6f4c5159dc1bb0b56a6331/hw/ip/rom_ctrl/rtl/rom_ctrl_pkg.sv#L21-L24
perhaps @sriyerg @rasmus-madsen can chime in.

I'm not sure about the increase in complexity. At the moment, the KMAC environment has a monitor-in-all-but-name implemented in the scoreboard. If we don't write an agent for this interface, we'll need to duplicate this monitor in AES and OTBN.
Personally, I favour the approach here which splits things into drivers and monitors and avoids the sequence or the scoreboard messing around with the interface directly.

@weicaiyang I think the sideload agent is needed for several reasons.

when I started implementing this in the AES I realized I was basically replicating code already in KMAC,
we can of cause copy/paste - but who makes sure any fixes are propagated to the other implementations?
the current implementation does facilitate the random behavior of sideload - it just drives the wires.
a driver could be programmed to resemble the real thing better. As an example there could be a pretty big delay from request to the key being provided, and the duration of the key being valid of the interface is also not being modeled.
it is just "valid"
such things are easier to handle in an agent
IMO it is generally bad practice to drive and read pins directly from sequence and scoreboard.
as it should be able to run in 0 time and independent from the bus timings

It indeed doesn't improve stimulus/coverage, but add more complexity.
I am convinced this is not the case.
randomizing delays from req->rsp will indeed improve the stimulus and coverage.
in fact the coverage should have holes currently if written properly.
randomizing how long a key is valid is also a potential problem.

I know it is possible to implement this with just the interface and some sequences - but with an agent, this will come for free for anyone using sideload.
so I do believe both stimulus and coverage will be significantly improved by this agent!