Toast notification alert message pop up

Features

Toast message should include prefix icon, text, button and close icon.
Toast message should be able to show background color state variations based on scenario (green, red, yellow, blue).
Toast message should have a time out.

Design URL for specs : https://xd.adobe.com/view/809c4f44-9861-4f57-978a-e2d3515a426e-d5cf/screen/63ee7e10-a6aa-48a7-b9d9-fb78539eaf77/
Toast notification pop up (success state)

@shanaka-rajitha We support native browser notifications which are superior to custom UI notifications since they show up even if user has not the tab / browser focused. Is there any hidden benefit in implementing these that I don't see maybe?

Hi @mturoci the browser native notifications are good but it does not visually present the status of a message at glance. The proposed alert notifications provide contextual feedback for typical user actions. Something similar to how Bootstrap use the alert component.

The example provided in description is not the best UX for the outlined scenario. If the model creation is immediate, then user should be taken directly to the project / models page where the new model can be viewed which implies a successful operation. However, if the model creation takes longer the user is very likely to switch tab (since it is better than mindlessly stare at the app, just for the sake of waiting) which may result in missing the in-app notification, thus not getting the info about created the model. In this case native notification is superior as it can be seen even when the tab with the app is not focused currently. Either way, in-app notification is not a good fit.
However, I agree there might be some usecases when in-app notification can be useful. Confirming settings were changed for example. The only thing that worries me is that this can be easily misunderstood / misused resulting in not that great UX of the apps.
@lo5 proposed API for review:
/**
 * Snackbars are temporary in-app low importance notifications that inform user about
 * a particular app state change and disappear on their own.
 * Make sure you don't overuse them too much so as not to downgrade the UX of your app.
 */
interface Snackbar {
  /** Snackbar's text. */
  label: S
  /** Snackbar's type based on scenario. Defaults to 'info'. */
  type?: 'success' | 'info' | 'warning' | 'error'
  /** If specified, renders a button next to the snackbar label. */
  button?: Button
  /** When should the snackbar disappear in 'ms'. Defaults to '5000'. */
  timeout?: U
  /** Specify where should the snackbar be. Defaults to 'top-right'. */
  position?: 'top-right' | 'bottom-right' | 'bottom-center' | 'bottom-left' | 'top-left' | 'top-center'
  /** The events to capture on this snackbar. */
  events?: S[]
}

Hi @mturoci, there is no issue as to what type of notification component is used. What is raised as a concern here is if browser native notifications can visually represent the information with a theme that implies the context of the message shown.
By allowing the notification UI to be app-specific, provides a seamless experience to the user. To provide better UX we do not show all states of warning, information, alert, and success states in the same themeing. Hence why it is more important to show the notifications more visually related to the context than the type of notification used.

What is raised as a concern here is if browser native notifications can visually represent the information with a theme that implies the context of the message shown.

I understand, what you are saying, but if the user doesn't see notification at all, there is no UX at all thus colors / theming is less important since it is just a cosmetic detail. It doesn't matter what color is the notification of if the user will not see it, right? I propose to give a deeper thought on general UX (how the user will actually use the feature) and less on UI (what colors he will (or will not) see).

@mturoci  - Re: API

Snackbar: Why not call this a Notification?
label: Rename to text, consistent with MessageBar.
type: Make consistent with MessageBar.type
timeout: Change units to seconds.
Not clear from the API design: How do I specify a label for the button if the notification contains a button?
If the notification displays a button, does it timeout?
button/events: If the intention is to allow handling button clicks, then better to have a name instead of a button like we do with other components.

Snackbar: Why not call this a Notification?

We already have a meta_card.notification. Although it is a string, the attr name is notification so we need to distinguish between native vs in-app notifications somehow.

label: Rename to text, consistent with MessageBar.

Sure

type: Make consistent with MessageBar.type

Sure

timeout: Change units to seconds.

Sure

Not clear from the API design: How do I specify a label for the button if the notification contains a button?

The initial intention was to use existing Button API which contains label. Other alternative would be to split this into 2 new attrs - name and button_label.

If the notification displays a button, does it timeout?

I would think yes if the routing achievable via button is considered optional, otherwise should be redirected right away after the action that triggered the notification and the notification will be used for decorative purposes without button. Wdyt @shanaka-rajitha ?

button/events: If the intention is to allow handling button clicks, then better to have a name instead of a button like we do with other components. Remove events unless we anticipate this component raising other events.

The reason I didn't propose a simple name was that I couldn't come up with any clean way of specifying button label.
The events attr is there to support dismissed event, similar to dialog and side panel. Can be removed if not needed though.

Sure, @shanaka-rajitha can you additionally design notifications for danger and blocked types please?

Hi, @mturoci I have updated the rest of the designs for all other color variations, icons used are picked from Fluent icons.

Design URL: https://xd.adobe.com/view/0790f950-abbd-41fa-b372-332295fd876f-52c3/screen/8e728e9a-cab7-42cd-8dc4-061a3ca65235/

@mturoci So we have updated new toast layout as you can see and here if we are including an action button it better not to keep the toast as auto timeout. For the normal toast messages (ex:- project uploaded, saved successfully) we can have auto timeout.
cc: @shanaka-rajitha

@shihan007 got it, thanks

We already have a meta_card.notification. Although it is a string, the attr name is notification so we need to distinguish between native vs in-app notifications somehow.

Let's name this notification_bar, consistent with message_bar.

The initial intention was to use existing Button API which contains label. Other alternative would be to split this into 2 new attrs - name and label_button

What about adding a buttons: Component[] so that ..., buttons=[ui.button(...), ui.button(...), ...] can be rendered as 1/more buttons. The button's caption, primary, link, icon, etc. properties can be ignored.
For consistency, would be good to also add buttons to the current MessageBar component as well (mapped to Fluent's actions and MessageBarButton).

Sounds good @lo5, I would just replace buttons: Component[] with buttons: Button[] to prevent people from rendering other form components, not just buttons.

I would just replace buttons: Component[] with buttons: Button[]

This will run into issues with the Python driver. ui.button() returns the union type Component.

Oh I see, thought it will only need a bit of frontend tweaks. Will explicitly point out that only buttons are supported unless there is a better solution, e.g. introducing ui.notification_bar_button.
Another question: Do we also want to support loading as described in the designs? If so, one option could be renaming buttons to items and leverage the generic nature of form components - let user pick which components and order they are rendered in. This flexibility can also cause a lot of trouble though.
@shanaka-rajitha @shihan007 where can I find the designs for danger and blocked types? Cannot find them within
https://xd.adobe.com/view/0790f950-abbd-41fa-b372-332295fd876f-52c3/screen/8e728e9a-cab7-42cd-8dc4-061a3ca65235/
Also what is the usecase for the default notification in designs? I thought the notification should always carry a message and sentiment (success / error). So far, I went with info as default.
Warning and error notifications use the same icon which is odd. Let's go with ErrorBadge icon for error instead.

Progress so far:
https://user-images.githubusercontent.com/64769322/135072859-31e84c6b-a11d-41ff-aab2-4b2a196ab0df.mov

styled buttons according to design if link=True specified
handled mobile viewport - only 2 positions available - top / bottom
auto close after 5s when no buttons included with optional manual close
if buttons present, manual close is required

@mturoci this looks great

looks great @mturoci

@dulajra  @VijithaEkanayake  These components are already built in the sdk and they will probably merge this soon. and will let you know once its done.

@mturoci When can we get this ready in the Wave SDK? Can we use this toast as a floating component and form component as well?
cc: @iamabhishekmathur

When can we get this ready in the Wave SDK?

Probably by the end of January.

Can we use this toast as a floating component and form component as well?

Toasts are floating components in general. For form, you can use existing ui.message_bar.


Feature/prl 3161

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-3161
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Merged into c100 base branch as part of other PR https://github.com/hmcts/prl-citizen-frontend/pull/848
Closing this PR.


Feature: Support for GitHub Enterprise Server

Security policies require we keep all code and CI/CD onprem. To that end, we use GitHub Enterprise Server behind our firewall. While I can use HTTPS Basic Auth (ref: https://docs.mergestat.com/mergestat/setup/http-and-ssh-authentication) for basic repo stats, I'm also looking for the Issue and PR stats associated with our repos that come with using GitHub.
Would it be possible to provide support for GitHub Enterprise Server instances?

Hi @jeffstoner-scilo,
I've shared a workaround in issue #1161 that enables you to use your custom domain and token with Mergestat’s GitLab plugin, specifically designed for on-prem GitLab setups. This is a temporary solution to ensure you can access all of Mergestat's features in your environment right away, until the developers can integrate a more permanent fix.
Thanks,
matnav


doc: Improve the docstring from the code source so that the documentation API will be clear

Which part of the documentation needs improvement?
Which part of the documentation needs improvement? Documentation API (so enhance the code source docstring). Indeed:
The skore documentation will soon be launched (https://github.com/probabl-ai/skore/issues/412). Same as in scikit-learn, there will be an API tab. Actually, what is done in Sphinx documentation is that all the content of the documentation on our classes is automatically built from the docstring of the code source.
Example with scikit-learn's logistic regression
The documentation API looks like this:

...

while the corresponding docstring in the code base looks like this:
class LogisticRegression(LinearClassifierMixin, SparseCoefMixin, BaseEstimator):
    """
    Logistic Regression (aka logit, MaxEnt) classifier.

    In the multiclass case, the training algorithm uses the one-vs-rest (OvR)
    scheme if the 'multi_class' option is set to 'ovr', and uses the
    cross-entropy loss if the 'multi_class' option is set to 'multinomial'.
    (Currently the 'multinomial' option is supported only by the 'lbfgs',
    'sag', 'saga' and 'newton-cg' solvers.)

...
   Read more in the :ref:`User Guide <logistic_regression>`.

   Parameters
   ----------
   penalty : {'l1', 'l2', 'elasticnet', None}, default='l2'
       Specify the norm of the penalty:

       - `None`: no penalty is added;
       - `'l2'`: add a L2 penalty term and it is the default choice;
       - `'l1'`: add a L1 penalty term;
       - `'elasticnet'`: both L1 and L2 penalty terms are added.

Describe the problem found in the documentation
Currently, our docstring is quite poor:

Especially, for machine learning stuff such as skore.cross_validate, it will have to be properly documented cc @augustebaum, @MarieS-WiMLDS.
Suggested improvement
Please write docstring everywhere! For each class, describe its attributes, etc. For each method of each class, document it.
Additional context
No response

Hmm I think we're aiming at DS users that will probably ignore the front end and back end API to focus on ML API such as cross validation and train test splits
But having a minimal clean docstring everywhere is nice to have I think
And very thorough docstring for pure ML stuff

Should we close this issue now that the documentation has been improved by a lot + there are epics more precise to keep improving?

Yes!

Yes!


signals at long & short intervals together

Hi,
I noticed that TNCscope can read signals of long intervals (e.g., position and velocity: 3 ms) & signals of short intervals (e.g., current: 0.6 ms) together with considering the frequency of each one (like position is updated only one time when the current can be updated 5 times at interval = 600 us chosen for both of them. As shown in the attached picture (current & velocity at x-axis):

I could change the code to behave like as following:
1- Cancelling these two lines:

2- Cancelling these lines:

3- Adding this if condition (special for interval = 600 us):

while this (count_high_freq) increases by one at the end of each for-inner loop.
It gives the same exact behavior, but this is very specific for interval = 600 us (as mentioned above) because of the very soft code while TNCscope has fewer choices with more codes of conditions.
I wonder if you have a better solution for it.

I suggest modifying the code to be:

What do you think?

@Md-aliy7 sorry for the late reply.
I tried to follow your suggestions but to be honest I am not certain I understand all of it :-)
Nevertheless your changes look good to me, I see no problem to integrate them as they are.
Can you create a pull request? Would be easier for me to integrate.

Your changes have been integrated and a new release should be available shortly, thanks for the code!


Code Review - Home page and login components

Requesting a review of the home page and login components.
The home page sits within the main router at pages/index.ts. It has state typings inline and renders two different divs dependent on whether the user is logged in or not (will later be built out with components). I've created a test user that can login with userrname and password both matching<EMAIL_ADDRESS>The login component sits inside a container which has bindings to get/set global state. Together they handle a number of things including communicating with the auth service, reflecting changes back to the global redux state as well as notifying up to parent component (in this case home page) - this might seem counter-design as standard model would be to read down from the global state and wrap the home page in a container to pass the property (currently feels overkill, but likely useful in future when more state read).
Could you check if the code seems organised logically and is reasonable to follow/maintain?

Nice!
First off a question: have you looked at using MobX? Redux can be very tempting because it is used so much, but every project I've ever seen turns into a mess because of the insane amount of boilerplate. And then there's the performance argument; MobX only re-renders when something actually changes in a component. This is slightly off-topic tho.
But anyway;

In src/containers/, why is the Login container called Login.container? It's already in the containers directory, so that seems a bit redundant. Same thing with models.
In src/models/models.tsx; I don't understand why this naming scheme is used. I'd either rename it to index.tsx so you can just do import {...} from 'models', or maybe remove this altogether; importing a specific model is easy enough without this file altogether, plus in a large team it can introduce merge conflicts.
I see you're not using internationalization tools. If you're sure the intention is to never translate the site into multiple languages this is fine, but if there is even some doubt I'd use i18n tools. In my experience converting an app from no i18n to using i18n is very time consuming.
The strategy used to override Material UI styles here by using inline styles is not really sustainable I think. I'd create separate components like for <Form /> and override the styles in there by using class names.
Clarify somewhere in the README what browsers you intend to support.
I have never really used Firebase for a project so can't say anything about that.
The container/component structure is a good idea.
Good job on the contributing guide!

Hope this is useful!

Really useful thanks!
I looked into MobX, seemed general consensus was it was easier but doesn't scale as well. I ended up going with the advice from article and stuck to redux as it's something I've used a lot before (although I really hate how much boilerplate there is, angular-redux is much simpler).
Login.container is because quite often you will be working with both the container and child login components simultaneously, and I hate tabs named 'Login' and 'Login' - currently components and pages reserve simplest naming conventions and then anything else like models, sagas, containers, apis etc. will have additional naming. I'd like to avoid the same situation with index.tsx files (I once saw @BenGamma with around 10 'index.tsx' tabs open at the same time and felt close to mental breakdown) so think a sensible compromise would be to have index.ts files in each folder which only import and export other components (i.e. pages/index.ts will contain references from pages/home/home.tsx and pages/docs/docs.tsx, so you can still import from 'pages' but if refactoring both pages you would have have home.tsx and docs.tsx open), created #46.
We had internationalisation suggested and generally agreed upon (just with different senses of priority). I saw there were some good packages already for this and seeing as I've just spent the past 3 days backdating translations in another app I'm working on agree we should get this in place sooner. added as #45
Agree on unsustainable styling. Was suggested using: https://www.styled-components.com. I haven't tried but @BenGamma said he will try to do so and see how it goes.
IE11? will add support right after I get round to netscape (bringing  back). Readme updated
Thanks again!


Outlook Logic App Stripping Email Custom Headers

Hi, I am using custom headers via the office js library here https://docs.microsoft.com/en-us/javascript/api/outlook/office.internetheaders?view=outlook-js-preview to pass meta data in the email headers.
I can see that the header is added but when it is received via the logic app, the custom headers have been removed.
Is this a known issue? Is there a way to prevent the stripping of custom headers?
thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5756a11c-f84b-b363-de0a-a1640307cee7
Version Independent ID: bd5143a2-6f72-130c-ffed-d134ec3ec2b9
Content: Office.InternetHeaders interface - Office Add-ins
Content Source: docs/docs-ref-autogen/outlook/outlook/office.internetheaders.yml
Product: outlook
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

@ifflanb Thanks for the question. The Azure docs repo addresses issues related to documentation of Azure services, this issue seems to be referenced to the docs repo of office, the appropriate issues page is here. Could you please raise a new issue in this repo so the right team could help?


Problem when publishing to IIS (IDX10803)

I developed an asp.net project with some asp.net core 2.0 apps which integrated IDS4 for authentication, and authorization successfully on my dev machine.
When I published it to IIS hosting, I created a self-signed certificate from IIS Manager. The app that host IDS worked, but other clients which connect to it for authentication, and authorization didn't work.
I used asp.net core 2.0.5
IdentityServer4 2.1.2
IdentityServer4.AccessTokenValidation 2.4.0
I could directly browse to the metadata address, but the clients couldn't.
I opened all the ports require for my apps in Windows Firewall.
This is the log content from stdout file.
warn: Microsoft.AspNetCore.DataProtection.Repositories.EphemeralXmlRepository[50]
      Using an in-memory repository. Keys will not be persisted to storage.
warn: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[59]
      Neither user profile nor HKLM registry available. Using an ephemeral key repository. Protected data will be unavailable when application exits.
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[58]
      Creating key {5b207fab-f8fa-42ed-b189-960c20e5185c} with creation date 2018-03-07 02:11:33Z, activation date 2018-03-07 02:11:33Z, and expiration date 2018-06-05 02:11:33Z.
warn: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[35]
      No XML encryptor configured. Key {5b207fab-f8fa-42ed-b189-960c20e5185c} may be persisted to storage in unencrypted form.
Hosting environment: Production
Content root path: C:\inetpub\wwwroot\ticket_portal
Now listening on: http://localhost:24734
Application started. Press Ctrl+C to shut down.
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://<IP_ADDRESS>:8884/
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://<IP_ADDRESS>:8884/
info: Microsoft.AspNetCore.Authorization.DefaultAuthorizationService[2]
      Authorization failed for user: (null).
info: Microsoft.AspNetCore.Authorization.DefaultAuthorizationService[2]
      Authorization failed for user: (null).
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
      Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter'.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
      Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter'.
info: Microsoft.AspNetCore.Mvc.ChallengeResult[1]
      Executing ChallengeResult with authentication schemes ().
info: Microsoft.AspNetCore.Mvc.ChallengeResult[1]
      Executing ChallengeResult with authentication schemes ().
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action Ventech.Ticket.Web.Controllers.HomeController.Index (Ventech.Ticket.Web) in 426.7161ms
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action Ventech.Ticket.Web.Controllers.HomeController.Index (Ventech.Ticket.Web) in 426.7161ms
fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]
      An unhandled exception has occurred: IDX10803: Unable to obtain configuration from: 'https://<IP_ADDRESS>:8888/.well-known/openid-configuration'.
System.InvalidOperationException: IDX10803: Unable to obtain configuration from: 'https://<IP_ADDRESS>:8888/.well-known/openid-configuration'. ---> System.IO.IOException: IDX10804: Unable to retrieve document from: 'https://<IP_ADDRESS>:8888/.well-known/openid-configuration'. ---> System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.Http.WinHttpException: A security error occurred
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Threading.Tasks.RendezvousAwaitable`1.GetResult()
   at System.Net.Http.WinHttpHandler.<StartRequest>d__105.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at System.Net.Http.DiagnosticsHandler.<SendAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at System.Net.Http.HttpClient.<FinishSendAsyncBuffered>d__58.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.IdentityModel.Protocols.HttpDocumentRetriever.<GetDocumentAsync>d__8.MoveNext()
   --- End of inner exception stack trace ---
   at Microsoft.IdentityModel.Protocols.HttpDocumentRetriever.<GetDocumentAsync>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.IdentityModel.Protocols.OpenIdConnect.OpenIdConnectConfigurationRetriever.<GetAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.IdentityModel.Protocols.ConfigurationManager`1.<GetConfigurationAsync>d__24.MoveNext()
   --- End of inner exception stack trace ---
   at Microsoft.IdentityModel.Protocols.ConfigurationManager`1.<GetConfigurationAsync>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectHandler.<HandleChallengeAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<ChallengeAsync>d__53.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationService.<ChallengeAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.ChallengeResult.<ExecuteResultAsync>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeResultAsync>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeFilterPipelineAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.<Invoke>d__6.MoveNext()
fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 38.9708ms 404
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 38.9708ms 404
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 POST http://<IP_ADDRESS>:24734/iisintegration  0
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 0.4731ms 202
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 POST http://<IP_ADDRESS>:24734/iisintegration  0
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 0.4731ms 202
Application is shutting down...

Thank you, and hope to have some direction to solve this problem.

When I browse to
https://<IP_ADDRESS>:8888/.well-known/openid-configuration
I see an invalid cert warning in the browser. You need to fix your HTTPS first.


Create OpenAPI specs for rest API

I wish

to have an openapi spec for geoportal-server
the openapi.yaml represents in a usable way the informations in https://github.com/Esri/geoportal-server/wiki/REST-API-Syntax

I have a client that explicitly asked for an OpenAPI spec; it's a public authority and the reason is to provide a common API to query all their services.

having a standardized interface:

clarifies usage pattern with multiple examples
can be validated via a linter
allows api to be viewable from a catalog (eg. https://api.gouv.fr/api/le-taxi.html)


Could not find LongQA.json

Hi Team,
Could you please share the LongQA.json mentioned in the finetune script.
Thanks
Mano

Hi,
Thanks for your question. We are preparing to release this dataset next week. There will be more data, question types and more general format compared with the original mentioned one. Thanks for your patience.
Regards,
Yukang Chen

Hi,
We have release our dataset, LongAlpaca-12k, and the update models, LongAlpaca-7B/13B/70B. We are available in the following links. These models should be much better than the original SFT models.
https://huggingface.co/datasets/Yukang/LongAlpaca-12k
https://huggingface.co/Yukang/LongAlpaca-7B
https://huggingface.co/Yukang/LongAlpaca-13B
https://huggingface.co/Yukang/LongAlpaca-70B-lora
Regards,
Yukang Chen

I will close this issue as it has been solved. Please feel free to reopen it if there are any others to discuss.


[feature]: Convert Test run cards to Table with Filters

Is there an existing feature request for this?

[X] I have searched the existing issues

Summary
Currently, test runs can't be filtered by timestamp/app name etc. The goal here will be to convert test run cards to a table with pagination and filters.
Why should this be worked on?
The current cards structure is not scalable and filterable. Adding a table would bring consistency to the overall UI as well.

I can take this up if still pending :)

Sure @mahaveer0496 . Please feel free to assign it to yourself and take it up 👍
Also, please reach out to me on Slack if you have any questions.


Added infraction search menu from user embed

Addresses point 1 in #654. I planned to wait with this one, but we use this combination of commands so often I decided it's worth adding it even if gets partially rewritten by a future PR.
As explained in the issue, we use !user and !infr search so often we might as well have a reaction leading from one to another.
Implementation

The main issue here was to make the information on whether a user has infractions accessible from the user_info function.

I wasn't a fan of propagating a boolean value through the helper functions just to that end.
I attempted to rework how the command is divided into its helper function, for example by dividing the part fetching information from the db, and the part that is creating the embed, but the end result was awkward.
Eventually I ended up with accessing the embed fields and checking if the appropriate field has the "No infractions" string. I don't like looking for information I already had access to in one of the inner functions, and it's also volatile to format changes, so I'm open to suggestions.

I wrote the menu function with extensibility in mind, so that it'll be easy to add more reactions if we want.
I didn't address the part of the issue that says it shouldn't add the reaction for user embeds of moderators. We do make infractions searches on moderators sometimes for whatever reasons, so I don't see the harm in having it there as well.

@lemonsaurus has made some points on whether this PR is necessary, so we'll await his views here on that.

I think this feature is very useful, as we often do use the combo of "user -> infr search". However, my main issue with that combo is the sheer space it takes up. My personal preference would be to have the infraction search embed replace the user info embed with the infraction search embed.
That would make the "infraction embed" a menu option of the information embed, instead of an additional embed.

@SebastiaanZ that would be a fairly simple change, the issue is that information from the user embed can still be helpful even after pulling up the user's infractions to see the whole picture, and this behavior might cause mods to avoid using the feature.
Keep in mind that @scragly is currently working on making the infractions embed a lot more compact, so this issue won't be that severe in the long term. In terms of vertical space this feature already makes a slight improvement.
As I see it, the main gain from this feature is that we won't have to type in the search command every time, and by extension making it more convenient to use on phone.

I think that the value of user information command mostly goes away after the initial "who is this user" turns into "what are the details of that infractions they have listed in the user embed". If we're not replacing it, I don't think we really need the emoji reaction.

I don't see it, but if that's what the majority thinks then alright. In fact, I think it's the opposite - if we only want such a feature if it replaces the user embed, then there is no point in having it, as I think we will often find ourselves bringing up the user embed afterwards.
We could make it a paginator where the first page is the user embed and the other pages is the list of infractions, but I'm not sure if that's a good feature.

This feature will be part of a bigger overhaul of our infraction management system.

This feature will be part of a bigger overhaul of our infraction management system.


fix bigquery hook bugs

There two mainly two bugs in the bigquery hook's next():

endless loop. when buffer is exhausted, next() would start to query service again, causing an endless loop of data loading.

bugs in parsing rows from bigquery response. 'row' is not in response if no rows are returned; and the bq_cast is buggy as well.

Coverage remained the same at 63.532% when pulling e63b2cf3d823144ffd208da407096b5e9495c045 on xiaoliangsc:fix-bigquery-hook into 4c73677bf1e5bb2bbf07dd95f23c747645d4d91a on airbnb:master.


user_profile: Update stream dropdown option value to be of "number" type.

It is better to have stream dropdown option value, which is the ID of the stream, to be of "number" type.
Also, fixes the assertion error which occurred due to dropdown option having "string" type.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @sahil839!


[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [Wave 6: Categories] An empty string is added to recently used categories on Money Request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps

Create a money request with a workspace chat. Do not add a category.
Create a money request with a regular user.

Expected Result:

The app does not save an empty string to policyRecentlyUsedCategories_POLICY_ID.
The app does not create a new policyRecentlyUsedCategories_undefined with an empty string.

Actual Result:

The app saves an empty string to policyRecentlyUsedCategories_POLICY_ID.
The app creates a new policyRecentlyUsedCategories_undefined with an empty string.

Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: v1.3.75-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/57314631/2917feee-6d61-466e-80c0-5060cf72e20b
Expensify/Expensify Issue URL: N/A
Issue reported by: @rezkiy37
Slack conversation: N/A
View all open jobs on GitHub

@rushatgabhane is the C+ on this one.

bump @rushatgabhane

Payment summary:

$500 - @rushatgabhane - C+ PR review (to be paid via NewDot)

@rushatgabhane bump on finishing the checklist!

$500 payment approved for @rushatgabhane based on summary above.


Allow creation of full manifest for any selection, as we do for compact ones

I'm using the new names for manifest formats in the description below. Compact is the manifest primarily used for downloading with the CLI. The full manifest is the one that is currently only available per-project. Azul already has the ability to generate a full manifest for any subset of data files, not just all data files in a given project.
Can we add a button to the Export data dialog

The button should appear under a heading containing

Request full manifest for the current selection. A full manifest contains one row per data file. Each row contains all metadata properties from all entities associated with that data file. It can be large. It can also be used with the HCA Command Line Interface (HCA CLI) to download the selected data files.

For consistency, we may also reword the section for the compact manifest to say

Request a compact ~file~ manifest for the currently ~query~ selection for use with the HCA Command Line Interface (HCA CLI) to download the selected data (e.g. fastqs, BAMs) and metadata.

This was inspired by second paragraph in @mshadbolt's comment on Humancellatlas/dcp-cli#450

If the full manifest works with the CLI so we need to have a compact manifest at all?
It seems confusing to have both...

The full manifest is expensive to create and very unwieldy to use. I think we should still support both. Why is it confusing to have more than one flavor of the a thing?
Maybe the new heading should just read:

Request full manifest for the current selection. A full manifest contains one row per data file. Each row contains all metadata properties from all entities associated with that data file. It can be large.

Dup of #841?

@hannes-ucsc : The UI should always offer both flavors (full and compact) in close proximity to each other, and display a description explaining the difference between them when the user hovers over each alternative.

Is this still valid in the 2.0 world? Perhaps we can figure out a way to have a single format or list the metadata in a separate file type from the manifest.

Is there a plan for how we will be presenting metadata to consumers in the 2.0 world?
I thought I had heard that all downloads will happen via the browser rather than a cli so not sure if there will still be a manifest generated by consumers that want to download?

Also see #954.

Obsolete, as the full manifest is depricated.


Support for SQL Server

I am using SQL Server as my DBMS. When I tried to migrate, I got error

Exception 'RuntimeException' with message 'Your database is not supported!'
And I found that yii2-user only support MySQL and PgSQL
migration.php
    public function init()     {         parent::init();         switch (Yii::$app->db->driverName) {             case 'mysql':                 $this->tableOptions = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE=InnoDB';                 break;             case 'pgsql':                 $this->tableOptions = null;                 break;             default:                 throw new \RuntimeException('Your database is not supported!');         }     }
I hope I didn't misunderstood the problem.

Yes, you understood corectly. Yii2-user does not support SQL server.
Actually, it may work well with SQL server, but I didn't test it. You can try using it with SQL server (you can update migration code and check if it works well), then you can send a pull-request if everything is ok.

Already tried a simple modification to migration.php so I add this line
`//migration.php
public function init()
{
parent::init();
    switch (Yii::$app->db->driverName) {
        case 'mysql':
            $this->tableOptions = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE=InnoDB';
            break;
        case 'pgsql':
            $this->tableOptions = null;
            break;
        case 'sqlsrv':
            $this->tableOptions = null;
            break;
        default:
            throw new \RuntimeException('Your database is not supported!');
    }
}`

But after that migration get some error. SQL Server didn't recognize "RESTRICT" as UPDATE/DELETE  action. In SQL Server restrict are applied by default. So I uncommented the "RESTRICT from migration. But got this error again, still not sure what this mean,
    > alter column username in table {{%user}} to string(255) NOT NULL ...Exception 'yii\db\Exception' with message 'SQLSTATE[42000]: [Microsoft][ODBC Driver 11 for SQL Server][SQL Server]The index 'user_unique_username' is dependent on column 'username'. The SQL being executed was: ALTER TABLE [user] ALTER COLUMN [username] nvarchar(255) NOT NULL'
I'll keep you posted. I'll send pull-request after migration success without error.
Thanks @dmeroff

The index 'user_unique_username' is dependent on column 'username'
I'm not sure, but I think this error means that you cannot alter column that is used within index.


licode support h264 ?

as i know  Chrome M50 has supported h264,   when will licode support that?

licode doesn't support h264 ? I think licode already support h264
see http://lynckia.com/licode/client-api.html

i do not see any  h264 code in this repo

I see multiple response when I search h264 in this repo

It does not currently support h.264.  That'd be a great feature to add though, since I think there are inklings that MSFT and Apple will add webrtc support, but my guess is it'll be h.264

We currently don't support h.264 in the browser.
There's nothing preventing us from supporting both h.264 and VP9 and will do in the near future

wow very good news ! thank you !

Now that Safari 11 is released and Safari 11 only supports H264, is there any timeline on implementing H264 in licode?
Similar discussion here : https://github.com/lynckia/licode/issues/915

I am also curious to know when support for Safari would be added, and if it is far then I have to think of an iOS app.
IMO a project road map would be very helpful.

We'll add support to Safari in the next weeks, it's definitively in our roadmap. These are the tasks to

h264 is not fully support in Licode. We still need to make slideshow compatible (work in progress), propagate fmtp lines (and possibly other info) from publisher to subscriber's SDP
we want to make video/audio codecs configurable per room.
Adapterjs does not currently support all safari features. This Pull Request has recently improve things a lot, but we need to investigate other cases too.

I've been waiting for this feature for 2 years now, your post made my day, what a relief.

Great!
Does Simulcast is compatible with h264?

there isn't a simulcast option for h264 in Google's webrtc library yet. There's an open PR, but it seems like it's stuck at some point: https://chromium-review.googlesource.com/c/external/webrtc/+/514351

Too bad :(

I've found really hard issues that prevent Safari to work in all cases. it seems like it is still buggy and we can't provide a solution that would be production ready yet. Anyway, we'll update adapterjs, which improves support to Safari, and we'll be able to do some demo with it ;)


Process: development during stabilization

This tracks discussion around creating alternative development processes during stabilization phases.
Previous discussion:
https://docs.google.com/document/d/1VPDfXGEK_sOOIQYHK-95ROZUt0_BHgb7U-YiGz1YUqk/edit#heading=h.z0jfzofogctf

@mbolivar-nordic  you probably want to add Process label in here:  https://github.com/zephyrproject-rtos/zephyr/blob/a30e71a7dec910111853e2ae057bd3089c2abc1a/.github/workflows/stale_issue.yml#L22

Process WG closed as no one is currently willing to champion this issue.


support jsDelivr to speedup static files

Hi, after https://github.com/apache/apisix-website/pull/260 is merged, we have all logos inside our repository, and now when users visit apisix.apache.org , all logos will serve from GitHub, we need to speedup those files.
Solution

visit https://www.jsdelivr.com/?docs=gh to know what jsDelivr does;
update https://github.com/apache/apisix-website/blob/master/website/src/pages/index.js#L123 src prop with jsDelivr . All files are under https://github.com/apache/apisix-website/tree/master/website/static/img/showcase this folder.

I would like to try this :)

not hard AFAIK, but it will speedup the website 😄

I think we need to change the static image to<EMAIL_ADDRESS>right?

ya

that's right

How about doing something like src={"https://xxx/" + "163.png"}, no need to update json file

Sure, I will do it later

Also, Could I define the global variables to store the https://cdn.jsdelivr.net/gh/apache/apisix-website@master/, What do you think?

sure, and you could use docusarus.config.js to do that? would better if possiable


Calling close() on a Database manually causes API errors

import std.conv;
import std.stdio;

import d2sqlite3.database;
import d2sqlite3.library;
import d2sqlite3.sqlite3;

static extern(C) void loggerCallback (void *arg, int code,
    const(char)* msg) nothrow
{
    try
    {
        writefln("SQLite error: (%s) %s", code, msg.to!string);
    }
    catch (Exception ex)
    {
    }
}

unittest
{
    shutdown();
    config(SQLITE_CONFIG_MULTITHREAD);
    config(SQLITE_CONFIG_LOG, &loggerCallback, null);
    initialize();

    auto db = Database(":memory:");
    db.close();
}

Result:
SQLite error: (21) API call with invalid database connection pointer
SQLite error: (21) misuse at line 152877 of [89e099fbe5]

One other thing I don't understand. Why is the shutdown call necessary before SQLITE_CONFIG_LOG is configured? If I don't call shutdown first, I get this error:
d2sqlite3.database.SqliteException@source/d2sqlite3/library.d(88): Configuration: error 21

And according to the d2sqlite3 unittests, it also calls shutdown before any initialization. Is this a workaround for something?

Forgot to mention I'm testing this on OSX.

Without the explicit db.close call, I will eventually get this:
Error: clean-up of Database incorrectly depends on destructors called by the GC.

Thanks for reporting!
There's a (stupid) bug that causes the database connection to be closed twice when calling Database.close() explicitly, leading to the 21 'misuse' error. Should be fixed soon.
The SQLite documentation says all configuration must be done before sqlite3_initialize and after sqlite3_shutdown has been called. That's why the unit test was written this way.

Error: clean-up of Database incorrectly depends on destructors called by the GC.

I think this is an independent bug in your code: a Database connection cannot be closed by a destructor called by the GC.

Should be fixed soon.

Ah, thank you so much! Very fast fix. :)

I think this is an independent bug in your code: a Database connection cannot be closed by a destructor called by the GC.

Indeed, it was.


feat: gh actions improvements

This PR is a work in progress.

Improve test suite action readability
Ensure formatted code by running cargo fmt and checking for diffs

Closing because this PR is unnecessary


[SKiDL BUG]incompatable with latest  KiCad v7

Describe the bug
KiCad released new version "KiCad 7.0.0" on Feb/12/2023,  skidl's part method call on KiCad-7.0.0 would result in KeyError: "F0"
To Reproduce
Steps to reproduce the behavior:

Install KiCad version 7, news here
Set environment variable "$KICAD_SYMBOL_DIR" to "/Applications/KiCad/KiCad.app/Contents/SharedSupport/symbols/"
Run example code on skidl's readme
See error
Traceback (most recent call last): File "skidl101.py", line 7, in <module>  r1, r2 = 2 * Part("Device", 'R', TEMPLATE, footprint='Resistor_SMD.pretty:R_0805_2012Metric') File "/Users/zhuoli/.pyenv/versions/3.6.15/lib/python3.6/site-packages/skidl/part.py", line 194, in __init__  part = lib[name].copy(dest=TEMPLATE) File "/Users/zhuoli/.pyenv/versions/3.6.15/lib/python3.6/site-packages/skidl/schlib.py", line 192, in get_part_by_name  parts.parse(get_name_only) File "/Users/zhuoli/.pyenv/versions/3.6.15/lib/python3.6/site-packages/skidl/part.py", line 373, in parse  parse_func(get_name_only) File "/Users/zhuoli/.pyenv/versions/3.6.15/lib/python3.6/site-packages/skidl/tools/kicad/kicad.py", line 297, in parse_lib_part  _parse_lib_part_kicad_v6(self, get_name_only) File "/Users/zhuoli/.pyenv/versions/3.6.15/lib/python3.6/site-packages/skidl/tools/kicad/kicad.py", line 817, in _parse_lib_part_kicad_v6  self.ref_prefix = self.fields["F0"]  # Part ref prefix (e.g., 'R'). KeyError: 'F0'

Expected behavior
No error should raised from skidl's official example.
Screenshots

Desktop (please complete the following information):

OS : Mac os
Python version: 3.10.4
SKiDL version: unknown

Additional context
The failure is brought by this merge with a hardcode logic to search part in kicad v6

A workaround to this F0 error is to manually download v6 Schematic symbols here, and set $KICAD_SYMBOL_DIR to location of this v6 Schematic symbols

Proposed FIX: Change "F0" to "Reference"
I believe the field lookup for KiCAD v7 libraries has changed the field name for the reference designator to "Reference"

Proposed FIX: Change "F0" to "Reference"

That worked here. skidl latest with kicad-7.0.2

I am trying to check #182, most things seems to be handled there, just not sure.
Even when changing "F0" to "Reference" will allow parts to load, there is more error/s in 'getattr'.
when debugging self.__getattribute__("fields") is empty.
@export_to_all
class SkidlBaseObject(object):

    # These are fallback lists so every object will have them to reference.
    erc_list = list()
    erc_assertion_list = list()

    def __init__(self):
        self.fields = {}

    def __getattr__(self, key):
        try:
            # Don't use super()!! It leads to long run times on Python 2.7.
            return self.__getattribute__("fields")[key]
        except KeyError:
            raise AttributeError

Which version of SKiDL are you using? Is it 1.2.1 from PyPi? I would suggest trying the development version:
pip install git+https://github.com/devbisme/skidl@development

The development version includes some new code for handling KiCad 6 and 7. It's not quite ready for release. For one thing, it needs documentation. You have to use KICAD6 or KICAD7 as follows:
set_default_tool(KICAD7)

Send me the code causing the problem and I'll try it out.

Hello, I have installed the development version of SKiDL as described above but the KICAD7 name is not defined.
I cannot see this symbol anywhere in the development branch of the repo.
What am I missing?

My apologies! When I finally got around to checking this, I found I'd failed to push the development branch to Github! I've done that, so give it a try and we can move on to whatever problem comes next...

I installed the development version, set KICAD7_SYMBOL_DIR, called set_default_tool(KICAD7) but there is still an issue:
Python 3.11.3 | packaged by conda-forge | (main, Apr  6 2023, 08:57:19) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from skidl import *
WARNING: KICAD6_SYMBOL_DIR environment variable is missing, so the default KiCad symbol libraries won't be searched. @ [/home/john/<frozen importlib._bootstrap_external>:940=>/home/john/<frozen importlib._bootstrap>:241]
>>> set_default_tool(KICAD7)
>>> search('ESP32')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/part_query.py", line 130, in search_parts
    for part in search_parts_iter(terms, tool):
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/part_query.py", line 106, in search_parts_iter
    lib = SchLib(
          ^^^^^^^
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/schlib.py", line 88, in __init__
    tool_modules[tool].load_sch_lib(
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/tools/kicad7/lib.py", line 140, in load_sch_lib
    parent_part = lib[item[1]]
                  ~~~^^^^^^^^^
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/schlib.py", line 209, in __getitem__
    return list_or_scalar(self.get_parts_by_name(id))
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/schlib.py", line 203, in get_parts_by_name
    part.parse(partial_parse)
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/part.py", line 388, in parse
    tool_modules[self.tool].parse_lib_part(self, partial_parse)
  File "/home/john/.conda/envs/doe/lib/python3.11/site-packages/skidl/tools/kicad6/lib.py", line 331, in parse_lib_part
    pin_func = pin_io_type_translation[pin[1].value().lower()]
               ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'free'

This problem occurred because I erroneously referenced KICAD6 in the KICAD7 library parser. I fixed it in the development branch. Give it a try and see if it works for you.

Hi @devbisme! I tried the updated version and the error is the same, although it is in the kicad7/lib.py now 😅
Python 3.11.3 | packaged by conda-forge | (main, Apr  6 2023, 08:57:19) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from skidl import *
WARNING: KICAD_SYMBOL_DIR environment variable is missing, so the default KiCad symbol libraries won't be searched. @ [/home/raman/<frozen importlib._bootstrap_external>:940=>/home/raman/<frozen importlib._bootstrap>:241]
WARNING: KICAD6_SYMBOL_DIR environment variable is missing, so the default KiCad symbol libraries won't be searched. @ [/home/raman/<frozen importlib._bootstrap_external>:940=>/home/raman/<frozen importlib._bootstrap>:241]
>>> set_default_tool(KICAD7)
>>> search('opamp')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/part_query.py", line 130, in search_parts
    for part in search_parts_iter(terms, tool):
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/part_query.py", line 106, in search_parts_iter
    lib = SchLib(
          ^^^^^^^
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/schlib.py", line 88, in __init__
    tool_modules[tool].load_sch_lib(
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/tools/kicad7/lib.py", line 140, in load_sch_lib
    parent_part = lib[item[1]]
                  ~~~^^^^^^^^^
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/schlib.py", line 209, in __getitem__
    return list_or_scalar(self.get_parts_by_name(id))
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/schlib.py", line 203, in get_parts_by_name
    part.parse(partial_parse)
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/part.py", line 388, in parse
    tool_modules[self.tool].parse_lib_part(self, partial_parse)
  File "/home/raman/.conda/envs/cadquery/lib/python3.11/site-packages/skidl/tools/kicad7/lib.py", line 331, in parse_lib_part
    pin_func = pin_io_type_translation[pin[1].value().lower()]
               ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'free'

KiCad 7 introduced a new pin type: free. I added that to the development branch. Should clear this error.

@devbisme that helped, thank you!

I'm not sure if i'm running into the exact same issue.
I'm on Ubuntu, Kicad7

import os
os.environ["KICAD7_SYMBOL_DIR"] = "/usr/share/kicad/symbols/"

from skidl import *

set_default_tool(KICAD7)

# Create part templates.
q = Part("Device", "Q_PNP_CBE", dest=TEMPLATE)
r = Part("Device", "R", dest=TEMPLATE)

# Create nets.
gnd, vcc = Net("GND"), Net("VCC")
a, b, a_and_b = Net("A"), Net("B"), Net("A_AND_B")

# Instantiate parts.
gndt = Part("power", "GND")             # Ground terminal.
vcct = Part("power", "VCC")             # Power terminal.
q1, q2 = q(2)                           # Two transistors.
r1, r2, r3, r4, r5 = r(5, value="10K")  # Five 10K resistors.

# Make connections between parts.
a & r1 & q1["B C"] & r4 & q2["B C"] & a_and_b & r5 & gnd
b & r2 & q1["B"]
q1["C"] & r3 & gnd
vcc += q1["E"], q2["E"], vcct
gnd += gndt

generate_netlist()

Results in errors:

WARNING: Could not load KiCad schematic library "Device", falling back to backup library. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:11]
WARNING: Could not load KiCad schematic library "Device", falling back to backup library. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:12]
WARNING: Could not load KiCad schematic library "power", falling back to backup library. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:19]
WARNING: Could not load KiCad schematic library "power", falling back to backup library. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:20]
ERROR: No footprint for GND/#PWR1. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for VCC/#PWR2. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for Q_PNP_CBE/Q1. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for Q_PNP_CBE/Q2. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for R/R1. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for R/R2. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for R/R3. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for R/R4. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
ERROR: No footprint for R/R5. @ [/home/jubei/Documents/Work-Syncthing/python/skidl-test/skidl_tb.py:31]
INFO: 0 warnings found while generating netlist.
INFO: 9 errors found while generating netlist.

I am using the development version. My environment variable for KICAD7_SYMBOL_DIR was never set. However when I open Kicad7, I can go to the symbols and they work fine over there.

Tested on KiCad v8, same issue with the missing footprints.
# eix-installed all | grep kicad
sci-electronics/kicad-8.0.0
sci-electronics/kicad-footprints-8.0.0
sci-electronics/kicad-meta-8.0.0
sci-electronics/kicad-packages3d-8.0.0
sci-electronics/kicad-symbols-8.0.0
sci-electronics/kicad-templates-8.0.0

# ls
total 3.5K
 512 drwxr-xr-x 2 user user    3 2024-03-15 16:09:00 .
1.5K drwxr-xr-x 3 user user   10 2024-03-15 16:01:01 ..
1.5K -rwxr-xr-x 1 user user 1.2K 2024-03-15 16:08:34 example_from_readme_bug_179.py

# cat example_from_readme_bug_179.py
#!/usr/bin/env python3

import os
os.environ["KICAD_SYMBOL_DIR"] = "/usr/share/kicad/symbols/"
os.environ["KICAD_3DMODEL_DIR"] = "/usr/share/kicad/3dmodels/"
os.environ["KICAD_FOOTPRINT_DIR"] = "/usr/share/kicad/footprints/"
os.environ["KICAD_TEMPLATE_DIR"] = "/usr/share/kicad/template/"

from skidl import *

set_default_tool(KICAD)
# uncommenting these makes no difference
#lib_search_paths[KICAD].append('/usr/share/kicad/symbols')
#footprint_search_paths[KICAD].append('/usr/share/kicad/footprints')

# Create part templates.
q = Part("Device", "Q_PNP_CBE", dest=TEMPLATE)
r = Part("Device", "R", dest=TEMPLATE)

# Create nets.
gnd, vcc = Net("GND"), Net("VCC")
a, b, a_and_b = Net("A"), Net("B"), Net("A_AND_B")

# Instantiate parts.
gndt = Part("power", "GND")             # Ground terminal.
vcct = Part("power", "VCC")             # Power terminal.
q1, q2 = q(2)                           # Two transistors.
r1, r2, r3, r4, r5 = r(5, value="10K")  # Five 10K resistors.

# Make connections between parts.
a & r1 & q1["B C"] & r4 & q2["B C"] & a_and_b & r5 & gnd
b & r2 & q1["B"]
q1["C"] & r3 & gnd
vcc += q1["E"], q2["E"], vcct
gnd += gndt

generate_netlist()
#generate_pcb()

# ./example_from_readme_bug_179.py
ERROR: No footprint for GND/#PWR1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for VCC/#PWR2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for Q_PNP_CBE/Q1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for Q_PNP_CBE/Q2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R3. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R4. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R5. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
INFO: 0 warnings found while generating netlist.
INFO: 9 errors found while generating netlist.

ERROR: No footprint for GND/#PWR1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for VCC/#PWR2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for Q_PNP_CBE/Q1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for Q_PNP_CBE/Q2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R1. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R2. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R3. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R4. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]
ERROR: No footprint for R/R5. @ [/poolz1_1x4TB_A/cfg/python/skidl/bug_179/example_from_readme_bug_179.py:37]

# ls
total 9.0K
1.5K drwxr-xr-x 2 user user    7 2024-03-15 16:09:18 .
1.5K drwxr-xr-x 3 user user   10 2024-03-15 16:01:01 ..
 512 -rw-r--r-- 1 user user    0 2024-03-15 16:09:17 example_from_readme_bug_179.erc
1.0K -rw-r--r-- 1 user user 2.1K 2024-03-15 16:09:18 example_from_readme_bug_179.log
1.5K -rw-r--r-- 1 user user 4.8K 2024-03-15 16:09:18 example_from_readme_bug_179.net
1.5K -rwxr-xr-x 1 user user 1.2K 2024-03-15 16:08:34 example_from_readme_bug_179.py
1.5K -rw-r--r-- 1 user user 2.1K 2024-03-15 16:09:18 example_from_readme_bug_179_lib_sklib.py


[performance] General caching issues

I recently reported an issue in discord after creating a listing the project title was missing.

Turns out it was a caching issue.
Overall seeing some issues when creating/updating listings etc of the information not displayed correctly or very quickly on the frontend. This can lead to confusion since the user may not know they need to hard refresh multiple times to see changes.
As one example, when I create a new listing, sometimes it takes numerous refresh for the listing to show and if I change screens, like go to marketplace and then back to my profile my listing is not there until I refresh.
The other thing I often see (not a caching issue) is every time I click on my profile page the create listing button spinner shows for 8,10 or more seconds - what is causing that?
There are other issues already created around caching, i.e. KlimaDAO/klimadao#1008 and KlimaDAO/klimadao#1015 so clearly caching is a known issue. I'm not sure we can icebox this before launch but also not sure what the solution or level of effort would be to improve the UX.

Single project page caching updates passed QA.
#1025

Portfolio data page looks good, except for two minor notes. See my comment in #1047
https://github.com/KlimaDAO/klimadao/pull/1047#issuecomment-1515618024

#1099 passes QA. This concludes all caching PRs.


Independent UI component with component-router

I thought about taking something like calendar/date-picker and enriching it with component-router. Could be published as part of elementalui. Makes sense, @JedWatson?
/cc @halhenke

Should work perfect with https://www.npmjs.com/package/react-day-picker (looks like it is the best one in the wild)


[opentelemetry-collector] Remove default resource values

Fixes #644

Hey @povilasv, thanks for taking a look. I responded to the comment (it is indeed run as a subchart).
I would still like to discuss whether resources should be set in the base chart. I don't think this is a good practice, as the resource usage is completely dependent on each particular use-case. Resources should be empty by default (leading to a best-effort QoS) and the user should be encouraged to think about their resource requirements, rather than relying on some arbitrary defaults.

Hi @verejoel, can you please rebase and incorporate the latest suggestions from https://github.com/open-telemetry/opentelemetry-helm-charts/issues/644?


changes that allow go-torch to work on windows -- some tests will sti…

…ll fail on windows b/c they have not been properly written for windows systems

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.5%) to 94.987% when pulling a16e10c7c0170bf3ace8209b6b80acbf4330a7ba on JKhawaja:JKhawaja into ddbe52cdc30e6a165aee3a634c597e01a235e85e on uber:master.

@prashantv I tried to think of a good test to pass on Windows that would be similar to:
func TestGenerateFlameGraph(t *testing.T) {
	testScriptFound(t, flameGraphScripts, GenerateFlameGraph)
	testScriptNotFound(t, &flameGraphScripts, GenerateFlameGraph)
}

but I do not know perl well enough to derive one, and any test I could think of would be rather arbitrary not actually testing properties of the code that needed to remain invariant.
The necessity of the iniital "perl" argument goes contrary to the design and testing of the system (where the functions like runScript() are written more generically).
I am not familiar enough with perl to have any suggestions on other systems.
Also of importance: the perl idea was not mine; it comes from #60 and @AlexAkulov


Added auth context provider

In this PR, I added React Context powered AuthProvider and ProtectedRoute components.
The ProtectedRoute will handle auth redirection where a user is not authenticated.
It also renamed the Main import from Routes.js to Routes.

Coverage remained the same at 83.794% when pulling ec39006a8e3445b1dc51ad3d7d16a6d5870cc2cf on add-auth-context-provider into cc6686c2c7565732206371d2e22c8f81e990469f on master.


How to capture the LoadUrl completion event of imageView?

How to capture the LoadUrl completion event of imageView?

you can use following snippet.
UrlRequestParam param;
param.onComplete = [this](UrlRequest* request) {
if (request->isError()) {
return;
}
Memory mem = request->getResponseContent();
m_viewImage->setSource(Image::loadFromMemory(mem));
});
UrlRequest::send(param);

I have to make a public image cache.
The current idea is to get the image through imageView->getSource() after the current event is retrieved and cached.
There are too many pictures in Sapp that need to be processed in this way, so that  every picture needs to be loaded in c++ code in this solution, which is probably not the best solution.
The best solution is to unify all image load events in the same function.


In channel block paging

swiping left and right in lightbox should start paginating through blocks in the order in whatever context you were coming from

Is this pre-launch @broskoski @csherron


Wireframe support color config

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

Codecov Report
Base: 5.76% // Head: 5.76% // No change to project coverage :thumbsup:

Coverage data is based on head (aafb7a0) compared to base (44f4d74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           dev/0.9     #74   +/-   ##
=======================================
  Coverage     5.76%   5.76%
=======================================
  Files            9       9
  Lines          347     347
  Branches        63      63
=======================================
  Hits            20      20
  Misses         323     323
  Partials         4       4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update repository after transfer

See https://github.com/senzing-garage/garage-roadmap/issues/3

Pull requests:

https://github.com/senzing-garage/file-loader/pull/73


There are two list of response status codes that disagree with one another

The list at https://sendgrid.com/docs/API_Reference/Web_API_v3/How_To_Use_The_Web_API_v3/responses.html isn't the same as the list at https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html

Thanks! Merging these would be a great idea. Thank you for the nudge! I will put this on our list to be cleaned up before we go fully over to our new API docs: https://sendgrid.com/docs/API_Reference/api_v3.html


Describe wrong prerelease version from prerelease

Prerelease versions are described wrong from other prerelease versions.
For example, if the latest version is 0.1.0-1 and a feat commit is created, the new described version in 0.2.0-1, while it should be 0.1.0-2.

Fixed in 2.1.1


Add video api

Adds support for the Vonage Video API

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (13808e1) 97.27% compared to head (624285e) 97.53%.

Files
Patch %
Lines

src/vonage/client.py
87.50%
1 Missing :warning:

src/vonage/video.py
99.30%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   97.27%   97.53%   +0.25%
==========================================
  Files          25       26       +1
  Lines        1102     1257     +155
==========================================
+ Hits         1072     1226     +154
- Misses         30       31       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Incorrectly generated description

Given this API: https://developers.checkmango.com/operation/operation-createexperiment
The generated request class CreateExperiment has a bad comment:
/**
 * createExperiment
 */
class CreateExperiment extends Request
{
	protected Method $method = Method::POST;

	public function resolveEndpoint(): string
	{
		return "/api/teams/{$this->team}/experiments";
	}

	/**
-	 * @param int $team The ID of the team to list experiments in.
+	 * @param int $team The ID of the team to create the experiment in.
	 */
	public function __construct(
		protected int $team,
	) {
	}
}

This is due to the OpenAPI Parameter description being defined on the "paths" instead of on the individual endpoints in the openapi spec:

{
  "get": {
    // ...
  },
  "post": {
    // ...
  },
  "parameters": [
    {
      "in": "path",
      "name": "team",
      "description": "The ID of the team to list experiments in.", // Defined here
      "example": 3,
      "required": true,
      "schema": {
        "type": "integer"
      }
    }
  ]
}

If you move the parameter definition inside the get/post and give them individual descriptions, this should work as expected.

Closing this, as its not a package bug, let me know if i have misunderstood.


Pinata deploy action does not remove old pined

I use this action to deploy a website but for some time now I've seen that it no longer removes the old pins when running the action. I don't get any error though. This is the code, in case you want to recreate the situation:
name: deploysite

on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - uses: jakejarvis/hugo-build-action@master
      with:
        args: --minify --buildDrafts
    - uses<EMAIL_ADDRESS>      with:
       pin-name: '[My.pin.name]'
       path: './public'
       pinata-api-key: [API Key]
       pinata-secret-api-key: [Secret API Key]
       remove-old: true

I saw that is just a permission issue from my Pinata account. The action works well.


Version number of all NuGet Dependency is 0

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
nuget
Package manager version
latest
Language version
.NET 9, C# 13
Manifest location and content before the Dependabot update
https://github.com/dailydevops/healthchecks/blob/main/Directory.Packages.props
dependabot.yml content
https://github.com/dailydevops/healthchecks/blob/main/.github/dependabot.yml
Updated dependency
No response
What you expected to see, versus what you actually saw
https://github.com/dailydevops/healthchecks/network/dependencies?page=1

And even more...
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response

The NuGet updater does detect and report package version numbers, so I suspect the issue is somewhere further up the chain.
@jakecoffman or @abdulapopoola can you help route this?


ObservableScrollView in ViewPager with scrollview callback set

I have a set up where i need the scrollview in the viewpager.  If I dont set the scrollviewcallback than everything works fine, however if I set the callback, it will sporadically scroll to a random page in the viewpager when I try and scroll down.
And again If I comment out setting the callback it works fine.

Hello, I've run into the same problem, any resolution? I'm about to dig in and check it out if needed...

Hi,
Perhaps it can be solved with the fix in #117 (f17e3ce).
Does your code include this fix?


System to handle the data from the CSV file

Develop a system for assigning students to teams based on user input or pre-defined logic (e.g., randomly, evenly, etc.).
From US #70

done


[BUG] types field is not set in the package.json

🐛 Bug 描述 Bug description
Cannot load typings for the project while using it.
🏞 期望结果 Desired result
Bundling types with the library would help using it in a typescript based project.
🚑 其他信息 Other information
Nothing else! Really love the shadow effect it creates under the images :smile:

+<EMAIL_ADDRESS>

Thanks! :)


function parameters naming convention

Hi,
in the python implementation the setting to adjust the aperiodic fit is called 'aperiodic_mode', in the matlab wrapper however, the setting is called 'background_mode'.
This is might cause unnecessary confusion (at least it did for me) and it might be better to rename the background mode to aperiodic_mode for consistency

Yes - you are completely correct, sorry about that. We have not been super clear on noting some of the changes going on.
The reason there is the difference is that we are in the midst of a major release, that has some name changes - this reflects the change in name in the original Python version. However, that is not properly released yet, so if you download python-FOOOF with pip, it actually will still have the old name (background_mode, etc) and so will work with the wrapper right now.
Long story short:

current version here should work if you use the pip installed FOOOF (though this is different from what is currently on Github)
if you want to use the newest version, you can install the Python version from Github, and install the fooof_mat wrapper from the 'dev' branch here, and everything is updated.

It should all be merged / released and become consistent soon! Thanks for trying it out!

New releases have been made, so the current master branch of this repository is now up to date with the new release of the Python FOOOF version.


Self-Runable Model for NN

So far, NN model needs to load ModelConfig, ColumnConfig & BasicNetwork to run/execute like ModelRunner.
Better to have a unified format  model file and based on such file which can be run like IndependentTreeModel for GBDT, only one class and one model to execute it.
The model format used to be PMML, now it can be private format and private execution engine.

Done


Master

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please add REST spec PR link to the SDK PR
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: agettier sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

Please remove the patch.  Done by mistake…
From: Azure Builder<EMAIL_ADDRESS>Sent: Monday, July 23, 2018 11:04 AM
To: Azure/azure-sdk-for-net<EMAIL_ADDRESS>Cc: Al Gettier<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-net] Master (#4577)
Can one of the admins verify this patch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Azure/azure-sdk-for-net/pull/4577#issuecomment-407089643 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHyM7y6Aw8laB6vgEY2s0Q83qu6-XwZ7ks5uJeXJgaJpZM4VbJ1O .  https://github.com/notifications/beacon/AHyM7-9FWhpdnj8s-xyVIKOQgJQOURpMks5uJeXJgaJpZM4VbJ1O.gif

@agettier closing this


[Feature] Not floating property panel

Summary
A fix property panel.
Motivation
Hi, after few hours in appsmith i think that the floating property panel is not very productive. It's sometime hard to make prop panel visible. It can hide some element you want to view. It some time hard to see where it was.

We built an early version of this.
https://www.loom.com/share/a893da277e474f86876ded3df1b04a1d
If you want to try it out, please login here: https://deploy-preview-3242--appsmith-editor-ce.netlify.app/applications/60394bd4e05a915e92acb70d/pages/60394bd4e05a915e92acb70f/edit
To login use<EMAIL_ADDRESS>/ community because the user database is different here.


Text background is not white

When my editor use sun-valley-ttk theme, i found a bug:
Python:3.9.9, Tcl/Tkinter:8.6, Windows:10
I used idle's highlight, when the highlight work, the highlighted word's background's color is different with the Text() background.
That looks bad.....
This is a bug or just my computer's wrong.
When i "take off" sun-valley-ttk theme, everything goes well, and the highlight color this not different with the Text() background
And use ttk lib isn't effect the Text() color, so i think is theme's wrong.
Can anyone tell me what is the happened.
Thx.
Program original file github.com/sadjok/CodeNoteBook

I tested with anthor file, the problum is the theme.

strange, i change a computer, the Text() color looks not different with highlight background...

So if I understand well, when you select something in the Text widget, its background changes. Right?

em, i mean when the text widget create, the background is different with white.

😵💫

Could you share a screenshot?

How to show a screenshot
?

On your pc press Control + Shift + S and select the area you want to capture, and paste it in the Github Comment box using Control + V

Control + Shift + S

Win + Shift + S if you're on Windows, or just simply Print screen.


DayPickerSingleDateController Jump to current month on date prop change

Here's my simple component
    <DayPickerSingleDateController
      date={getDateFromUrl(this.props.router)}
      focused
      numberOfMonths={1}
      onDateChange={console.log}
      onFocusChange={noop}
    />

My URLs are in the format /date/${yyyy}/${mm}/${dd}, and the getDateFromUrl() function just transforms the URL into a momentObject.
Repro:

Load page /date/2017/01/01, the DayPickerSingleDateController will highlight Jan 1st 2017.
Navigate client side (i.e. no page refresh) to /date/2018/01/01

Expected result:

DayPickerSingleDateController changes its visible month to Jan 2018

Actual result:

DayPickerSingleDateController stays as Jan 2017.
Jan 1st 2017 gets un-highlighted (this is good)
If I manually scroll to Jan 2018, I see Jan 1st 2018 being hightlighted (which means the date prop has correctly been changed)

It sounds like this is a dupe of https://github.com/airbnb/react-dates/issues/1257! This is on my to-do but I haven't gotten around to it. We'd definitely be open to a PR though.
I think for this particular case, in the componentWillReceiveProps method of the DayPicker*Controller components, you could check if the selected date has changed and if the new date is visible or not (there's a helper for that) and then set the month accordingly.... there may be some finagling beyond that, but that's the gist of it.

I'm keeping this as the canonical issue since the description is so nice and succinct!

Are you needing help on this ? @majapw

@matheusmonte would love a PR for this, as this is not a top priority for us right now!

@majapw I get this, but if you want help on something more priority,  May I help?

@matheusmonte please! :) I think if you look into the way the onMonthChange/onYearChange methods work, that is a good starting point for how to satisfy this requirement. I imagine you'd make the change in the componentWillReceiveProps of the DayPicker as well as the DayPickerSingleDateController/DayPickerRangeController. :) Happy to accept a PR! @GoGoCarl might be a good reviewer as well (if they're willing :P).

@majapw OK, I will working on this weekend, I think, next week will be good to review. If I can help in something more, please, let me know.

@majapw / @matheusmonte Happy to add a review when it's ready!

Any updates on this issue?

I've got a PR to resolve this issue here: #1481

Is there a way how to not add these attributes? You have it wrong and even if that was implemented correctly it's not always what you want, which is our case.
Role grid must be sued only when it's a data grid with implemented keyboard navigation. Using such roles without implementing the rest hurts the accessibility.

Doing a quick recap, because the issue is now spread over multiple threads and PRs.
Solution: this isn't implemented, yet. Suggested workaround 1 or workaround 2 is to force the calendar to re-render by assigning the date string as the key, although your UX designer will hate it because calendar will flick.
Related issues (could be more):
https://github.com/airbnb/react-dates/issues/135
https://github.com/airbnb/react-dates/issues/48
https://github.com/airbnb/react-dates/issues/240
Related PRs (could be more):
outdated PR: https://github.com/airbnb/react-dates/pull/1481
author closed after deciding solution isn't good enough: https://github.com/airbnb/react-dates/pull/1487

I appreciate all the hard work the maintainers do to make this stuff available for us, but this is such a basic function of a date range picker, particularly when picking multi-month or multi-year ranges that it seems a bit odd that it hasn't been addressed yet. I can't think of any other date range picker I have ever used that does not focus the calendar popup on the relevant month from the input clicked.
This alone is likely to eventually cause us to switch from using react-dates to another library. You can still have a performant animation for a calendar and have a wide range of months, or just don't animate when jumping to a distant month.

Is there any updates on the status of this? Are we still looking for a PR to deal with it? If so I can attempt a fix.

if anyone still interested even with a dirty hack 😬, here is one:
https://codesandbox.io/s/frosty-wilbur-1irkh

Relevant code snippets from @ImadBoumzaoued's codesandbox (updated a bit to check for visibility and TS):
useEffect(() => {
  const isVisible = monthController?.current?.isVisible
  if (!isUndefined(isVisible) && !isVisible) {
    // Checking for undefined above should gurantee the below are defined
    monthController!.current!.onMonthSelect(monthController!.current!.month, internalStartDate!.format('M'))
  }
}, [internalStartDate])

<DayPickerRangeController
  ...
  renderMonthElement={params => {
    monthController.current = { ...params }
    return params.month.format('MMMM')
  }} />

Got a similar issue to jump to the current month after clicking to the next/prev months.
Hopefully, someone will make a fix for this! 😉

Having same problem. Any news about this bug? :-)

+1 Me too. :(

I see there are some merged, linked PRs that reference this issue, but neither of these appears to address the original issue of having the picker month navigate to the newly-set month and date onChange. #1481 seemed promising but is now years stale so just wondering if there is some other solution that was merged and failed to reference this open issue?
In the meantime I'm going the route of setting key={myDate} to trip rerenders + lodash.debounce but hoping for a cleaner solution

No, there's nothing I'm aware of, altho you can check with the latest master and make sure.
If anyone wants to rebase #1481, and can comment on it with a link to their branch (please do NOT open a new, redundant PR), I'll be happy to try to get that landed.

Hi @ljharb, thanks for landing the fix for this issue. Could you please publish a new version of react-dates to npm that contains the fix?


Support for standard PDF Form Fields

First of all, congrats for the incredible work! Very impressive!
Noticed that Forms are saved in Templates which are in json format with binary payload and structured metadata. Has there been a discussion to support standard PDF Form fields for better interoperability with other PDF software?
For example pdf-lib has extensive API support for pdf form fields:
https://github.com/Hopding/pdf-lib#fill-form
Thank you!
Ivelin

Hi, @ivelin

Has there been a discussion to support standard PDF Form fields for better interoperability with other PDF software?
Not yet... But this idea is interesting!
Does it mean that the created PDF will be a PDF with values set in the PDF form?

Hi, @ivelin Thank you for the question.

Has there been a discussion to support standard PDF Form fields for better interoperability with other PDF software?

Not yet... But this idea is interesting! Does it mean that the created PDF will be a PDF with values set in the PDF form?

Yes. The PDF Form fields can be empty with edit enabled or populated and read only after. See details in the pdf-lib docs:
https://pdf-lib.js.org/docs/api/classes/pdfform

Yes, would be amazing to use your designer app, and when I change out the Document Template, once I upload it into your designer: it ought to auto-detected existing standard PDF form fields and surface the design information into your JSON format to allow for editing of the original PDF form

lol, that would be so cool, i didn't know pdf lib has those capabilities already

I fully agree with ivelin. I had such a case in my current project. We needed to generate a PDF with forms that the client could edit and we would process the edited PDF after and insert the data into the DB. I used jspdf as it was the only one I found with support for forms. A pain to work with though. More than 1000 lines for just 4 pages.

Version 3 has been feature released. It might be possible to implement by defining the new custom schemas feature.
https://pdfme.com/docs/custom-schemas

Can confirm that this is possible, I've done a proof of concept for a project I'm working on. Will look at sharing the solution (or maybe a bonafide plugin!) if time allows me to. Essentially I just made a quick and nasty monkeypatched text plugin and supplied a new pdfRender function (essentially the couple of lines from the pdf lib link above) and worked a treat!

@jedimonkey Awesome! If it becomes possible, please share the code with us.


Fix matrix members in structs, vpos

Fixes the VPOS shader argument type and fixes structs with matrices in them.
Note that GL specifies vpos as starting at 0.5,0.5 for the bottom left, while in XNA it starts as 0,0 at top left. Both are in screen pixels.

Took care of the matrix part: https://github.com/FNA-XNA/MojoShader/commit/18f9e93ffeb7f34aa9319b781b1b3dddb3200d80
gl_FragCoord is going to have to be a whole separate thing in the form of MOJOSHADER_glViewport, which will affect both that variable as well as gl_Position, in more ways than one. That's for another day though.


tooling fails to generate bundle.js with npm run command

I defined dev command in my package.json like the following:
{
  "dependencies": {
    "lodash": "^4.6.1",
    "numeral": "^1.5.3",
    "query-string": "^3.0.1",
    "rx": "^4.0.8"
  },
  "devDependencies": {
    "tooling": "^0.15.0"
  },
  "name": "chake-ui",
  "scripts": {
    "dev": "tooling watch --use react"
  },
  "tooling": {
    "index": {
      "title": "Chake UI"
    }
  },
  "version": "0.1.0"
}

then try to start tooling with command npm run dev:
$ npm run dev

><EMAIL_ADDRESS>dev $PROJECT_DIR
> tooling watch --use react

webpack: wait until bundle finished: /
webpack built 76675d3b91ab7cf6c580 in 6231ms
Hash: 76675d3b91ab7cf6c580
Version: webpack 1.12.14
Time: 6231ms
    Asset     Size  Chunks       Chunk Names
bundle.js  4.84 MB       0       main

ERROR in multi main
Module not found: Error: Cannot resolve 'file' or 'directory' $PROJECT_DIR/node_modules/tooling/node_modules/webpack-hot-middleware/client in $PROJECT_DIR
 @ multi main
Child html-webpack-plugin for "index.html":
         Asset     Size  Chunks       Chunk Names
    index.html  42.7 kB       0
webpack: bundle is now VALID.

but if I type the regular command tooling watch --use react, everything works fine.

I can infer that you're using npm@2, right?
If you run npm i webpack-hot-middleware inside your project directory and it works fine then I can confirm the issue.

Recommend to run npm install -g npm@3, much faster to install babel then.
And this problem would be solved too. (reinstall tooling then) 😄


Expose isMethodCall matcher in flutter_test

Quite a few unit tests of https://github.com/flutter/plugins depended on the deep equality semantics of == on MethodCall. Since that semantics is gone with https://github.com/flutter/flutter/commit/4e2e69797ac412f3cbee9ba7e48478713f272bc1, we should make it easy to port those tests.
Cf. https://travis-ci.org/flutter/plugins/jobs/299119004

Thank you! Apologies for missing the plugins repo.

@cbracken :-) Some reviewer should have been aware of those tests.


use uid instead of id for notifications

Pre-Flight checklist

[ ] Testing

[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-hugo-themes/issues/121
What's this PR do?
In an effort to build ocw-www content generated by ocw-studio, it was noticed that the partial for notification in the www theme looks for an identifier in the id property of the front matter of the notification.  This id is currently a Unix timestamp generated at the time of the creation of the file if you are using the hugo new syntax as defined in the archetype in the www theme for notification. ocw-studio doesn't use hugo new to create content and instead generates content based the WebsiteStarter config used to generate the site.  ocw-studio however does generate a UUID for each piece of content it creates, and this is deposited in the front matter of any given piece of content under the uid key.  This PR moves the theme to look at the uid property and uses that to key  to generate the id property in HTML and manage dismissal.
How should this be manually tested?

Read the readme if you have never spun up a site with ocw-hugo-themes before
Clone the repo at https://github.mit.edu/ocw-content-rc/the-ocw-www-rc_2b7b49fc4f784ca293edee4368e35a88
Clone ocw-hugo-projects: https://github.com/mitodl/ocw-hugo-projects
Start the webpack dev server in ocw-hugo-themes with npm run start:site:webpack
Start the hugo server in the cloned content repo directory by running hugo server --config /path/to/ocw-hugo-projects/ocw-www/config.yaml --themesDir /path/to/ocw-hugo-themes
Browse to http://localhost:1313 in an incognito window
Verify you see a beta notification at the top of the screen
Dismiss the notification and refresh the page.  It should not re-appear

I'm having trouble reproducing this. On ocw-www it generates public/index.html which is served when I run npm start, but I only see public/index.xml when I have EXTERNAL_SITE_PATH set to the repo in the description. Do you have an idea what's going on?

@noisecapella I made a big oversight in the testing instructions.  Moving to ocw-studio content, we'll be doing the Hugo build a little differently to account for Hugo configs being stored in ocw-hugo-projects.  Sorry for the confusion.


Unable to read data

I'm trying to connect, however i'm faced by the following error:
Traceback (most recent call last):
File "./toonclient.py", line 22, in
toon.login()
File "/home/ferdy/toon/Toon.py", line 31, in login
self.sessiondata = r.json()
TypeError: 'dict' object is not callable

Can you give me a little more info on your environment? Python version? Requests module version? Are you, by chance, running Debian Stable? If you feel adventurous, try changing 'r.json()' on line 31 to 'r.json' and see if that helps.

No responses on questions / many updates since the report was made. Closing; please re-open if the issue still exists (and add more info).