Canvas Size != ImageSize

Hi!
I guess since the last update the image size seems to differ from the resulting image. If I set the canvas to 1024x1024 all the ouput images seem to be 1126x1126 and for 512x512 they are 563x563.
Thanks for your great work!

Hi!
I guess since the last update the image size seems to differ from the resulting image. If I set the canvas to 1024x1024 all the ouput images seem to be 1126x1126 and for 512x512 they are 563x563. Thanks for your great work!

Hello, I just looked at it, there are no problems with the sizes. In the last update I didn't touch the size :). What browser?

Thanks, Browser is Edge on Windows 10.

Thanks, Browser is Edge on Windows 10.

I looked in Edge and everything is fine too. Maybe you have some other node that changes the size, I’m even at a loss to answer, hmmm...
https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet/assets/25489996/5a3d9b79-df12-4a11-98c7-34cf1b13d067

The size are not correct here neither when using an image as input, the output is smaller for an image 1024 width 768 height, I got   960x720

@AlekPet,

I looked in Edge and everything is fine too. Maybe you have some other node that changes the size, I’m even at a loss to answer, hmmm...

I also faced this problem that the size of the output image did not correspond to the input image. the reason was simple. this happens when the browser page scale is not equal to 100%.
PS: after change page zoom, you need to refresh the page for the bug to reproduce itself

@AlekPet,

I looked in Edge and everything is fine too. Maybe you have some other node that changes the size, I’m even at a loss to answer, hmmm...

I also faced this problem that the size of the output image did not correspond to the input image. the reason was simple. this happens when the browser page scale is not equal to 100%.
PS: after change page zoom, you need to refresh the page for the bug to reproduce itself

Hello, thanks you! I corrected it a little, although in the “selection” mode the controls are displayed incorrectly. Update yourself. 😄


:bug: :wrench: make identityIndex respond to address change

fix the issue where IdentityIndex did not show latest address when changing wallets
reported in #4449
affecting wallet dropdown and tansfer page
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[ ] Closes #<issue_number>
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/22791238/206836186-fd8693c7-c17a-4c74-992b-67feb00cb53d.mp4

pay 30

😍 Perfect, I’ve sent the payout
💵 $30 @ 29.76 USD/KSM ~ 1.008 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x2cb874d6fe1a323fcdad8f1d8ed0c2c4887d07aae66e3be84131d5807dd1a2b2
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


worker plane components of etcd node not getting upgraded when one control plane node is powered down

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Cluster is deployed with 1 etcd, 3 control plane and 2 worker
maxUnavailable control plane is 1, maxUnavailable_worker = 10% (default)
Power off one control plane
edit cluster - change the k8s version to 1.16 from 1.15
The cluster is stuck in Updating state with error: 2020/02/29 23:06:57 [ERROR] ClusterController c-lf8fc [cluster-provisioner-controller] failed with : [controlPlane] Failed to upgrade Control Plane: cannot proceed with upgrade of controlplane since 1 host(s) are found to be inactive prior to upgrade
Only etcd components get upgraded in this case.
Now, edit cluster, maxUnavailable control plane is 2
The other two Active control planes - get upgraded. - all the components including control plane and worker plane components.
ETcd node has not upgraded.
Error seen: [workerPlane] Failed to upgrade Worker Plane: cannot proceed with upgrade of worker since 1 host(s) are found to be inactive prior to upgrade; [workerPlane] Failed to upgrade Worker Plane: cannot proceed with upgrade of worker since 1 host(s) are found to be inactive prior to upgrade

Logs for second error:

2020/02/29 23:17:14 [INFO] Provisioning cluster [c-lf8fc]
2020/02/29 23:17:14 [INFO] Updating cluster [c-lf8fc]
2020/02/29 23:17:19 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:36311
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: Initiating Kubernetes cluster
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [certificates] GenerateServingCertificate is disabled, checking if there are unused kubelet certificates
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [certificates] Generating admin certificates and kubeconfig
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [certificates] Checking and deleting unused kube-etcd certificates
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: Successfully Deployed state file at [management-state/rke/rke-388463859/cluster.rkestate]
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: Building Kubernetes cluster
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2020/02/29 23:17:19 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:19 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:19 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2020/02/29 23:17:19 [ERROR] cluster [c-lf8fc] provisioning: Failed to set up SSH tunneling for host [<IP_ADDRESS>]: Can't establish dialer connection: can not build dialer to [c-lf8fc:m-s6czq]
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2020/02/29 23:17:19 [ERROR] cluster [c-lf8fc] provisioning: Removing host [<IP_ADDRESS>] from node lists
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [network] No hosts added existing cluster, skipping port check
2020/02/29 23:17:19 [INFO] cluster [c-lf8fc] provisioning: [certificates] Deploying kubernetes certificates to Cluster nodes
2020/02/29 23:17:19 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:19 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:19 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:19 [INFO] Starting container [cert-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:19 [INFO] Starting container [cert-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:20 [INFO] Starting container [cert-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:20 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:20 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:20 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

W0229 23:17:25.359302       6 reflector.go:326] github.com/rancher/norman/controller/generic_controller.go:229: watch of *v1.ConfigMap ended with: too old resource version: 2473 (2509)
2020/02/29 23:17:25 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:25 [INFO] Removing container [cert-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:25 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:25 [INFO] Checking if container [cert-deployer] is running on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:25 [INFO] Removing container [cert-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:25 [INFO] Removing container [cert-deployer] on host [<IP_ADDRESS>], try #1

I0229 23:17:26.073054       6 http.go:116] HTTP2 has been explicitly disabled
2020/02/29 23:17:26 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Rebuilding and updating local kube config
2020/02/29 23:17:26 [INFO] cluster [c-lf8fc] provisioning: Successfully Deployed local admin kubeconfig at [management-state/rke/rke-388463859/kube_config_cluster.yml]
2020/02/29 23:17:26 [INFO] cluster [c-lf8fc] provisioning: [reconcile] host [<IP_ADDRESS>] is active master on the cluster
2020/02/29 23:17:26 [INFO] cluster [c-lf8fc] provisioning: [certificates] Successfully deployed kubernetes certificates to Cluster nodes
2020/02/29 23:17:26 [INFO] cluster [c-lf8fc] provisioning: [file-deploy] Deploying file [/etc/kubernetes/kube-api-authn-webhook.yaml] to node [<IP_ADDRESS>]
2020/02/29 23:17:26 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:26 [INFO] Starting container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:27 [INFO] cluster [c-lf8fc] provisioning: Successfully started [file-deployer] container on host [<IP_ADDRESS>]
2020/02/29 23:17:27 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:27 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:27 [INFO] Removing container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:27 [INFO] cluster [c-lf8fc] provisioning: [remove/file-deployer] Successfully removed container on host [<IP_ADDRESS>]
2020/02/29 23:17:28 [INFO] cluster [c-lf8fc] provisioning: [file-deploy] Deploying file [/etc/kubernetes/kube-api-authn-webhook.yaml] to node [<IP_ADDRESS>]
2020/02/29 23:17:28 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:28 [INFO] Starting container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:28 [INFO] cluster [c-lf8fc] provisioning: Successfully started [file-deployer] container on host [<IP_ADDRESS>]
2020/02/29 23:17:28 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:29 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:29 [INFO] Removing container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:29 [INFO] cluster [c-lf8fc] provisioning: [remove/file-deployer] Successfully removed container on host [<IP_ADDRESS>]
2020/02/29 23:17:29 [INFO] cluster [c-lf8fc] provisioning: [file-deploy] Deploying file [/etc/kubernetes/kube-api-authn-webhook.yaml] to node [<IP_ADDRESS>]
2020/02/29 23:17:29 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:29 [INFO] Starting container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:30 [INFO] cluster [c-lf8fc] provisioning: Successfully started [file-deployer] container on host [<IP_ADDRESS>]
2020/02/29 23:17:30 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:30 [INFO] cluster [c-lf8fc] provisioning: Waiting for [file-deployer] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] Removing container [file-deployer] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [remove/file-deployer] Successfully removed container on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [/etc/kubernetes/kube-api-authn-webhook.yaml] Successfully deployed authentication webhook config Cluster nodes
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Reconciling cluster state
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Check etcd hosts to be deleted
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Check etcd hosts to be added
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Rebuilding and updating local kube config
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: Successfully Deployed local admin kubeconfig at [management-state/rke/rke-388463859/kube_config_cluster.yml]
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] host [<IP_ADDRESS>] is active master on the cluster
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [reconcile] Reconciled cluster state successfully
2020/02/29 23:17:31 [INFO] Setting maxUnavailable for worker nodes to: 1
2020/02/29 23:17:31 [INFO] Setting maxUnavailable for control nodes to: 2
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: Pre-pulling kubernetes images
2020/02/29 23:17:31 [INFO] Image [rancher/hyperkube:v1.16.7-rancher1] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] Image [rancher/hyperkube:v1.16.7-rancher1] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] Image [rancher/hyperkube:v1.16.7-rancher1] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: Kubernetes images pulled successfully
2020/02/29 23:17:31 [INFO] cluster [c-lf8fc] provisioning: [etcd] Building up etcd plane..
2020/02/29 23:17:31 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:31 [INFO] Starting container [etcd-fix-perm] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:32 [INFO] cluster [c-lf8fc] provisioning: Successfully started [etcd-fix-perm] container on host [<IP_ADDRESS>]
2020/02/29 23:17:32 [INFO] cluster [c-lf8fc] provisioning: Waiting for [etcd-fix-perm] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:32 [INFO] cluster [c-lf8fc] provisioning: Waiting for [etcd-fix-perm] container to exit on host [<IP_ADDRESS>]
2020/02/29 23:17:32 [INFO] Removing container [etcd-fix-perm] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:32 [INFO] cluster [c-lf8fc] provisioning: [remove/etcd-fix-perm] Successfully removed container on host [<IP_ADDRESS>]
2020/02/29 23:17:33 [INFO] Image [rancher/rke-tools:v0.1.52] exists on host [<IP_ADDRESS>]
2020/02/29 23:17:33 [INFO] Starting container [rke-log-linker] on host [<IP_ADDRESS>], try #1

2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [etcd] Successfully started [rke-log-linker] container on host [<IP_ADDRESS>]
2020/02/29 23:17:34 [INFO] Removing container [rke-log-linker] on host [<IP_ADDRESS>], try rancher/rancher#1
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [remove/rke-log-linker] Successfully removed container on host [<IP_ADDRESS>]
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [etcd] Successfully started etcd plane.. Checking etcd cluster health
2020/02/29 23:17:34 [INFO] [controlplane] Now checking status of node sowmya-test-ctrl-m-2
2020/02/29 23:17:34 [INFO] [controlplane] Now checking status of node sowmya-test-ctrl-m-3
2020/02/29 23:17:34 [INFO] Attempting upgrade of controlplane components on following hosts in NotReady status:
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [controlplane] Building up Controller Plane..
2020/02/29 23:17:34 [INFO] Resetting max_unavailable_controlplane to 1 since 1 host(s) are found to be inactive prior to upgrade
2020/02/29 23:17:34 [INFO] [controlplane] Now checking status of node sowmya-test-ctrl-m-2
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [controlplane] Successfully started Controller Plane..
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: [controlplane] Processing controlplane hosts for upgrade one at a time
2020/02/29 23:17:34 [INFO] cluster [c-lf8fc] provisioning: Processing controlplane host sowmya-test-ctrl-m-2
2020/02/29 23:17:34 [INFO] [controlplane] Getting list of nodes for upgrade
2020/02/29 23:17:36 [INFO] [controlplane] Now checking status of node sowmya-test-ctrl-m-3
2020/02/29 23:17:36 [INFO] cluster [c-lf8fc] provisioning: Upgrade not required for controlplane and worker components of host sowmya-test-ctrl-m-2
2020/02/29 23:17:36 [INFO] cluster [c-lf8fc] provisioning: Processing controlplane host sowmya-test-ctrl-m-3
2020/02/29 23:17:36 [INFO] [controlplane] Getting list of nodes for upgrade
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: Upgrade not required for controlplane and worker components of host sowmya-test-ctrl-m-3
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [controlplane] Successfully upgraded Controller Plane..
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [authz] Creating rke-job-deployer ServiceAccount
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [authz] rke-job-deployer ServiceAccount created successfully
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [authz] Creating system:node ClusterRoleBinding
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [authz] system:node ClusterRoleBinding created successfully
2020/02/29 23:17:37 [INFO] cluster [c-lf8fc] provisioning: [authz] Creating kube-apiserver proxy ClusterRole and ClusterRoleBinding
2020/02/29 23:17:38 [INFO] cluster [c-lf8fc] provisioning: [authz] kube-apiserver proxy ClusterRole and ClusterRoleBinding created successfully
2020/02/29 23:17:38 [INFO] cluster [c-lf8fc] provisioning: Successfully Deployed state file at [management-state/rke/rke-388463859/cluster.rkestate]
2020/02/29 23:17:38 [INFO] cluster [c-lf8fc] provisioning: [state] Saving full cluster state to Kubernetes
2020/02/29 23:17:38 [INFO] cluster [c-lf8fc] provisioning: [state] Successfully Saved full cluster state to Kubernetes ConfigMap: cluster-state
2020/02/29 23:17:38 [INFO] [worker] Now checking status of node sowmya-test-etcd-m-1
2020/02/29 23:17:39 [INFO] Attempting upgrade of worker components on following hosts in NotReady status:
2020/02/29 23:17:39 [INFO] cluster [c-lf8fc] provisioning: [worker] Building up Worker Plane..
2020/02/29 23:17:39 [INFO] kontainerdriver rancherkubernetesengine stopped
2020/02/29 23:17:39 [INFO] cluster [c-lf8fc] provisioning: [worker] Successfully started Worker Plane..
2020/02/29 23:17:39 [INFO] cluster [c-lf8fc] provisioning: [worker] Upgrading Worker Plane..
2020/02/29 23:17:39 [ERROR] ClusterController c-lf8fc [cluster-provisioner-controller] failed with : [workerPlane] Failed to upgrade Worker Plane: cannot proceed with upgrade of worker since 1 host(s) are found to be inactive prior to upgrade

Expected Result:
Worker plane components of etcd node should have upgraded.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master head - commit id: 37363ba67
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): rke do
Kubernetes version (use kubectl version):

1.15 to 1.16

verified on latest master-head - commit id: c30c16afe
Steps:

Cluster is deployed with 1 etcd, 3 control plane and 2 worker
maxUnavailable control plane is 2, maxUnavailable_worker = 10% (default)
Power off one control plane
edit cluster - change the k8s version to 1.16 from 1.15
The two Active control planes - get upgraded. - all the components including control plane and worker plane components.
The etcd node - etcd components and worker plane components get upgraded
The add ons get upgraded
And the cluster is seen in Upgrading state with the worker nodes NOT upgraded.
Error seen : Provisioning incomplete, host(s) [<powered-down-control>] skipped because they could not be contacted; Provisioning incomplete, host(s) [<powered-down-control>] skipped because they could not be contacted


Allow custom CPU and memory thresholds per ECS container

The Shibboleth service owners would like different alarm thresholds for the most critical containers, so we add support for specifying CPU and memory thresholds for each ECS container to make this module more viable and less minimal.

Looks like you chose to go with no defaults and the memory and CPU thresholds must be specified? Or am I missing something? I'm fine with that implementation decision.

Unfortunately, it's a little tricky to do defaults the way I would have liked to do in Terraform, though I haven't given up on that yet.


Occasional build failures due to addkey container showing state

The following should not show - ever. Especially in CI.
amazeeio-ssh-agent-add-key is not running

Will observe the builds over the next few days  - hopefully I've done enough to resolve this.


Add volume for auth log. For fail2ban

Is your feature request related to a problem? Please describe.
Please add the volume with the log of authorization. Also add the IP address of unsuccessfully authorized person in the log. It will help to use fail2ban. Sometimes it is necessary to release portainer.io in the Internet. Also brute force which strains begins
Describe the solution you'd like
Describe alternatives you've considered
Additional context

@itsconquest Could you please reopen the issue? Current Log will not give any hint about IP or client itself and looks like:
2020/04/15 07:49:18 http error: Invalid credentials (err=Unauthorized) (code=422)
2020/04/15 07:49:18 http error: Invalid credentials (err=Unauthorized) (code=422)

Also error code 422 here does not looks like fitting to the issue. 401 has being used when Session expired, but not when user enter wrong username/password:
2020/04/11 19:23:32 http error: Unauthorized (err=Unauthorized) (code=401)
2020/04/11 19:23:32 http error: Unauthorized (err=Unauthorized) (code=401)

Can we please have this feature request reopened? There seems to be alot of discussion about portainer revising its rate limiting to avoid users being locked out by bot spam, but in reality revising the rate limiting will not help. Adjusting Portainer's logs to allow an established solution like fail2ban to protect Portainer would avoid the Portainer crew from having to implement protection within Portainer for the majority of linux users who can use fail2ban to protect Portainer from local (or otherwise) attacks and hence reduce the locked user issue stemming from automated bot login spam.

Can we please have this feature request reopened?

sure


Can't update to 0.28

Hi,
I'm trying to update to 0.28 FROM 0.27.5 with the following commands:
git pull origin release && composer install && php artisan migrate
but keeps getting the following error:

error: Your local changes to the following files would be owerwritten by merge:

And then a long list of php-files, js-files and svg-files.
I haven't changed any of these files as far as I know.
What to do?

I had the same issue.
After i did the backup like discriped Backup routine, i did a
git reset --hard
Before the update.
That worked fine for me and i didn‘t lose any of my configuration.
I don‘t know if its the best way but its simple and worked for me

I had the same issue.
After i did the backup like discriped Backup routine, i did a
git reset --hard
Before the update.
That worked fine for me and i didn‘t lose any of my configuration.
I don‘t know if its the best way but its simple and worked for me

I will try that and let you know if it works.

Hmmm... it got a little bit longer, but now I get this:
[ErrorException]
file_put_contents(/var/www/html/BookStack/vendor/composer/installed.json):
failed to open stream: Permission denied

Maybe this helps:
https://stackoverflow.com/questions/41212362/composer-file-put-contents-composer-json-failed-to-open-stream-permission

Did you manage to solve your issues @nimmerdk?
If not, looks like the user, that you're running composer as, does not have permission to the vendor directory. Happy to help further or I can close this if you have got things working or given up...

Not entirely as I'm still getting some errors. although it seems that my Bookstack eventually got updated.
But I managed to f*ck up my ubuntu machine so hard, that I have to start over, so I will be installing a fresh copy later today.
/nimmer

Since it's been a few months I'll close this off.

I had the same issue.
After i did the backup like discriped Backup routine, i did a
git reset --hard
Before the update.
That worked fine for me and i didn‘t lose any of my configuration.
I don‘t know if its the best way but its simple and worked for me

Thanks it worked !


Added world language Dataset

Please Merge
Happy Hacktoberfest'22
Thanks!

Good one @yashrajmani
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to the profile section from the top right-hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!
And don’t forget to share your achievement with your friends.


fix(balancer) make stream proxy balancer retries work

Summary
It was reported by @KentAVP that on stream module the retries don't work in #8029
Issues Resolved
Fix #8029

@javierguerragiraldez thanks for reviewing, but it seems that with dbless, I now see this in the first test that I added:
2021/11/05 17:30:06 [error] 4325#0: *2 lua entry thread aborted: runtime error: kong/runloop/balancer/balancers.lua:102: attempt to index upvalue 'targets' (a nil value)
stack traceback:
coroutine 0:
	kong/runloop/balancer/balancers.lua: in function 'create_balancer_exclusive'
	kong/runloop/balancer/balancers.lua:195: in function 'create_balancer'
	kong/runloop/balancer/balancers.lua:229: in function 'get_balancer'
	kong/runloop/balancer/init.lua:233: in function 'execute'
	kong/runloop/handler.lua:944: in function 'balancer_execute'
	kong/runloop/handler.lua:1129: in function 'after'
	kong/init.lua:757: in function 'preread'
	preread_by_lua(nginx.conf:91):2: in main chunk while prereading client data, client: <IP_ADDRESS>, server: <IP_ADDRESS>:19000

Do we have another bug too?

attempt to index upvalue 'targets' (a nil value)

this is typical of not going through the right initialization functions.  did it happen on an actual Kong instance, or is it a unit test?


More documentation for the stormpathApplication reference

Looks good! I fixed a couple of typos (d4411db8986c2ae7a0b7a0ce14aea144dd487e7c). Merging this now :+1:

Thanks!


userwidgets ( 8 pt )

Implement new permissions
Build out the API and UI to be able to support: updating user password, updating user name, updating user permissions, send out new invites, properly remove users and finish user listing.
Userwidgets
model

[ ] #103
includes new permissions

api

[ ] #102
branch

adaptions for new permission format
user PATCH /user/:email implemented
make sure current re-invites are not broken

ui

[ ] #104

issuefab
model

[ ] Create custom key / issuer / verifier permissions ( 1 pt )

Delegation - CREV
Purchase - CREV
CostCenter: { Root:CREV, Child:CREV}
Reports
Payment: {Expense,Pre-paid,Card}
Banking

[ ] #105

financial controller all
regular user { payment, user: { view, invite } }

api

[ ] reset issuefab/api and userwidgets/api ( 0 pt )

app

[ ] adopt the changes in userwidgets/model 0.5.x update and the corresponding changes in issuefab/model

roles update


⚠ Anthelion has degraded performance

In d013960, Anthelion ($ATH) experienced degraded performance:

HTTP code: 200
Response time: 2458 ms

Resolved: Anthelion performance has improved in 67720fb after 6 minutes.


Make it easier to find custom bot modules when using zulip-botserver

I don't have a specific proposal, but probably some combination of documenting PYTHONPATH and adjusting how we search for bot modules is well worth doing to make it easier to help folks who are not deeply familiar with Python get bots running successfully.  This thread has discussion https://chat.zulip.org/#narrow/stream/92-learning/topic/bot.20basics/near/1068769.
The first step for this issue is coming up with specific proposals for how to improve the implementation or documentation.

I saw this and wondered if at least for our packaged bots the registration implementation which I started working on in #517 may be useful?

Can I work on this

@b-thebest There is no firm plan for going about this yet, so as Tim mentioned we likely want a proposal for fixing it first - I'd suggest discussing ideas in #integrations on chat.zulip.org.

@PIG208 do you think #708 resolved this?  I guess we can leave this option open until wethe documentation feels good for this workflow.


Webms in gallery mode

Add WebM to gallery mode swipe. Checks for webm in url, if not webm, then use standard view for .gif
fixes https://github.com/Rukkaitto/mobichan/issues/25

Looks like you might already have a branch for this. This is a simplistic approach. Take it or leave it, doesn't matter to me.

There's one issue : webms don't stop playing after being swiped to the side. Results in webms playing sound over each other.

@Rukkaitto
I see in dev tools multiple webm viewer pages are being created, thus explaining the issue you are seeing.

There's a few ways to solve this.

Create a swipe listener that pauses the video and potentially disposes the player itself. I know how to do this in java/android, gotta do some research for dart/flutter.

Create a static webmviewer page, Flutter vlc supports a single player and swapping out the play URL, so you have 1 player, but change its URL its loading... this might be trickier with the gallery page mechanisms but should be doable.

You should take a look at feature/webm-swipe, in my last commit I came up with my solution, not sure if it's ideal though.

@Rukkaitto I took a look at that branch, that's basically the same path I was thinking through. That will work, lets get that merged in and you can close this.
If you have more bugs log em.

@Rukkaitto  did you mean to merge this?  I was referring to your current webM feature branch that should merge

@Rukkaitto  did you mean to merge this?  I was referring to your current webM feature branch that should merge

I misunderstood, but I'll fix the issue we were talking about.

@Rukkaitto my discord thellamafarm#7609 if you want to chat thru this. I have a few more ideas.


problem with open db msgstore.db

i have a whatsapp 4 business in my phone also have in msgstore.db in /data/data/com.whatsapp.w4b/databases/msgstore.db but when i test app i got a error like this and force close app
2-27 10:11:40.296 19159-19395/ga.nikhilkumar.whatsappsender E/SQLiteLog: (14) cannot open file at line 32456 of [bda77dda96]     (14) os_unix.c:32456: (13) open(/data/data/com.whatsapp.w4b/databases/msgstore.db) -  12-27 10:11:40.297 19159-19395/ga.nikhilkumar.whatsappsender E/SQLiteDatabase: Failed to open database '/data/data/com.whatsapp.w4b/databases/msgstore.db'.     android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (code 14): Could not open database         at android.database.sqlite.SQLiteConnection.nativeOpen(Native Method)         at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:209)         at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:193)         at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:463)         at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:185)         at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:177)         at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:808)         at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:793)         at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:696)         at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:711)         at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:704)         at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:104)         at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:100)         at android.os.AsyncTask$2.call(AsyncTask.java:305)         at java.util.concurrent.FutureTask.run(FutureTask.java:237)         at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)         at java.lang.Thread.run(Thread.java:761) 12-27 10:11:40.299 19159-19395/ga.nikhilkumar.whatsappsender E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1     Process: ga.nikhilkumar.whatsappsender, PID: 19159     java.lang.RuntimeException: An error occurred while executing doInBackground()         at android.os.AsyncTask$3.done(AsyncTask.java:325)         at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)         at java.util.concurrent.FutureTask.setException(FutureTask.java:223)         at java.util.concurrent.FutureTask.run(FutureTask.java:242)         at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)         at java.lang.Thread.run(Thread.java:761)      Caused by: android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (code 14): Could not open database         at android.database.sqlite.SQLiteConnection.nativeOpen(Native Method)         at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:209)         at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:193)         at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:463)         at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:185)         at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:177)         at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:808)         at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:793)         at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:696)         at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:711)         at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:704)         at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:104)         at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:100)         at android.os.AsyncTask$2.call(AsyncTask.java:305)         at java.util.concurrent.FutureTask.run(FutureTask.java:237)         at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)          at java.lang.Thread.run(Thread.java:761)  12-27 10:11:51.179 19159-19182/ga.nikhilkumar.whatsappsender E/EGL_emulation: tid 19182: eglSurfaceAttrib(1174): error 0x3009 (EGL_BAD_MATCH)
i already give read/write permission for app whereas i got error

It requires root access to access WhatsApp database. If your device is rooted and you have given the desired permission, let me know or you may proceed with the non-rooted method for which only accessibility permission is required.
P.S. Sending bulk messages by entering the messages in WhatsApp database may lead to blocking of the account. I recommend using non-rooted method till development for the rooted method is getting finished.

i'm testing app on emulator and it is rooted (superuser) screenshot attachet here
and i have another question about can you send csv file template for me ?

In that case, disable root permission for the app using the superuser app and continue with the non-rooted method or provide me with the logcat of the app at the time of the error.

@nikhilmuz when disable root permission for app (in superuser) app provide error like this:
12-30 01:15:49.626 4113-4113/ga.nikhilkumar.whatsappsender E/AndroidRuntime: FATAL EXCEPTION: main
    Process: ga.nikhilkumar.whatsappsender, PID: 4113
    android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@766865a is not valid; is your activity running?
        at android.view.ViewRootImpl.setView(ViewRootImpl.java:679)
        at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:342)
        at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93)
        at android.widget.Toast$TN.handleShow(Toast.java:434)
        at android.widget.Toast$TN$2.handleMessage(Toast.java:345)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6119)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

my friend i have another question about csv template, can you share me csv template that you provide for this app ?

The sample CSV template is already committed to this repo. Refer readme to get it. If you still face any issue do let me know or try using another phone.

Hi @nikhilmuz - I tried to use this app and also ran into the same SQLiteCantOpenDatabaseException.
My device is rooted (an S5 running Lineage / Android 9 OS). I granted root permission for the app as well.
I verified the file it's looking for exists and made sure the permissions looked OK (using adb shell). Could this be a problem with newer versions of Android preventing 1 app from opening a database that belongs to another app? Since the database call is done outside of the SU() library that's just what jumped out to me.. But, I'd love to hear your thoughts.
(I can run this using AccessibililtyServices -- I'm mostly interested in learning about rooted direct access though)
 (14) cannot open file at line 36921 of [c255889bd9]
 (14) os_unix.c:36921: (13) lstat(/data/data/com.whatsapp.w4b/databases/msgstore.db) -
 Failed to open database '/data/data/com.whatsapp.w4b/databases/msgstore.db'.
 android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (code 14 SQLITE_CANTOPEN): Could not open database
 	at android.database.sqlite.SQLiteConnection.nativeOpen(Native Method)
 	at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:212)
 	at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:196)
 	at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:503)
 	at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:204)
 	at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:196)
 	at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:880)
 	at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:865)
 	at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:766)
 	at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:783)
 	at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:775)
 	at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:104)
 	at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:100)
 	at android.os.AsyncTask$2.call(AsyncTask.java:333)
 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245)
 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 	at java.lang.Thread.run(Thread.java:764)
 FATAL EXCEPTION: AsyncTask #1
 Process: ga.nikhilkumar.whatsappsender, PID: 23774
 java.lang.RuntimeException: An error occurred while executing doInBackground()
 	at android.os.AsyncTask$3.done(AsyncTask.java:354)
 	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
 	at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
 	at java.util.concurrent.FutureTask.run(FutureTask.java:271)
 	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245)
 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 	at java.lang.Thread.run(Thread.java:764)
 Caused by: android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (code 14 SQLITE_CANTOPEN): Could not open database
 	at android.database.sqlite.SQLiteConnection.nativeOpen(Native Method)
 	at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:212)
 	at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:196)
 	at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:503)
 	at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:204)
 	at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:196)
 	at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:880)
 	at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:865)
 	at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:766)
 	at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:783)
 	at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:775)
 	at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:104)
 	at ga.nikhilkumar.whatsappsender.sender.WhatsappApi$1.doInBackground(WhatsappApi.java:100)
 	at android.os.AsyncTask$2.call(AsyncTask.java:333)
 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 	... 4 more
   Force finishing activity ga.nikhilkumar.whatsappsender/.Sender

@jpage4500 It works on RR (Based on Lineage Oreo) for me. Maybe WhatsApp for business is not installed on your mentioned phone. Check it once. Alternatively, to use it for WhatsApp check for database files in /data/data/com.whatsapp/databases/ instead of /data/data/com.whatsapp.w4b/databases/ and update all the package names accordingly in codes including the internal storage folder hardcoded in the codebase. Also, /data/data/ already have read access unless it's not app specific folder inside it. So, there is no need to call it from shell under the SU library.

@nikhilmuz - I tried with WhatsApp for business. I also tried with the normal WhatsApp version (with modified paths like above).
I verified the paths exist and the SU commands making the folders readable works. I can only think that maybe Android Pie (9) has something that prevents this.

It maybe the case I will go through android developer change log for the
same but I don't think it should be the case. Anyways you may try it with
SU access and let me know.
On Sun, 5 May, 2019, 3:45 AM Joe Page<EMAIL_ADDRESS>wrote:

@nikhilmuz https://github.com/nikhilmuz - I tried with WhatsApp for
business. I also tried with the normal WhatsApp version (with modified
paths like above).
I verified the paths exist and the SU commands making the folders readable
works. I can only think that maybe Android Pie (9) has something that
prevents this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nikhilmuz/WhatsApp-Bulk-Sender/issues/15#issuecomment-489369668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEZUYFYAUGGUGR3KV7G6GYLPTYDH3ANCNFSM4GMLQ5DA
.

I was able to successfully test this using another device, an S5 running OS 5.1.1
For now I am guessing Android 9 prevents opening the database in another app's folder (even if permissions are read/write)
FWIW - this is the line of code I'm talking about:
db = SQLiteDatabase.openOrCreateDatabase(new File("/data/data/com.whatsapp.w4b/databases/msgstore.db"), null);

I even did this test on Android 9 -- I created the File object and logged the full path and if it exists() or not and it reported back 'false'. So, there might not be much that can be done.
I briefly thought maybe you could use SU to copy the database to another location (like the app's) -- modify it -- then use SU to copy it back again.. seems like it could lead to other issues though but might be worth trying as a way to get this to work on OS 9.

@jpage4500 Your Idea did work. Thanks for the suggestion and your contribution.


CommandBarFlyout.ShowMode is not available in earlier target platform minimum versions

Describe the bug
CommandBarFlyout.ShowMode property is not available in earlier target platform minimum versions
Steps to reproduce the bug
Steps to reproduce the behavior:

Create a UWP project targeting minimum versions earlier than 17763
Create a CommandBarFlyout element in XAML markup.
Try to set its ShowMode property in XAML.
Build the project.

Expected behavior
The project is built successfully and the behavior of CommandBarFlyout is accordingly changed.
Actual behavior
XAML editor indicates that ShowMode property is not available in the target platform minimum version, and the project will fail to build with error "The XAML Binary Format (XBF) generator reported syntax error '0x09C4' : Property Not Found"
Screenshots
Not applicable
Version Info

Package version: 2.0.181018004
Windows version: 17763.346
Target Platform Version: 17763
Minimum Platform Version: 16299
Visual Studio version: 15.9.6

NuGet package version
Microsoft.UI.Xaml 2.0.181018004

Windows 10 version
Saw the problem?

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)
Yes

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Additional context
Not applicable

You can use Conditional XAML to make it so that you only use ShowMode on supported platforms. Unfortunately with the split between WinUI and the platform today we can't make all functionality available on downlevel Win10. In particular with CommandBarFlyout there is some Flyout functionality that was implemented in the platform.


Remove old dead code that generated ministers

HoI4 does this now once the name lists are created, so that code is nor longer necessary, and makes everything more complex.

Looking at it in more detail, if we want advisers to have names and portraits, we need something similar to this code. So don't remove it.


1.6.2 Download

Is there a 1.6.2 download? I see the 1.6 download back on the old Google Code archive. I see there is references to 1.6.2 on github but no place to download them? Is 1.6.2 only available as source? Is there are tag for it?

There are no binaries. You can pull from master.

Mind making a tag/release of what is 1.6.2 so we know we have a known good version?


If I hava a async operating in 'script' tag, how could I do to make sure rendering page after get full data.

Hello, when I get a page from phantom I can't get data from ajax
Such as
<script>
request.get('/ajax')
  .end((err, res) => {
     dom1.innerHTMl = res.text
  }

</script>

In this code, dom1 can't be rerender for 'res.text'
How could I do to resolve it??
Thank u

This is not an issue for this module and probably an upstream issue instead. Closing as I don't think I can help.


Incompatibility with custom config setopt shwordsplit

Hi,
Here is an issue noticed during my move to zimfw (from a basic zsh, without any framework), when importing my existing zsh customizations.

[x] I've checked the existing issues and I'm not duplicating a report.
[x] I'm using the latest version of zimfw.
[x] I've checked the Changelog and I'm not being affected by documented changes.
[x] I've checked the 📢 Announcements and I'm not being affected by announced changes.
[x] I was able to reproduce the issue with a clean installation of Zim.
[x] I've pasted the output of zimfw info below.

Describe the bug
git-info doesn't work in a git directory, when using "setopt shwordsplit" (typically used in my .zshrc)
Steps to reproduce

Go in a git directory

~
% cd .zim/modules/utility

~/.zim/modules/utility on master
%

set option shwordsplit

~/.zim/modules/utility on master
% setopt shwordsplit
git-info:zformat:232: invalid argument: %%B%F{magenta}%b%c%s${(e)git_info[status]:+"

~/.zim/modules/utility
%

=> error

unset option shwordsplit

~/.zim/modules/utility
% unsetopt shwordsplit

~/.zim/modules/utility on master
%

=> no issue anymore
Current behavior
In step 2. we notice the error :
git-info:zformat:232: invalid argument: %%B%F{magenta}%b%c%s${(e)git_info[status]:+"
Expected behavior
Ideally, user configurations should not affect the behavior of Zim.
zimfw info
% zimfw info
zimfw version:        1.10.0 (built at 2022-09-27 22:44:10 UTC, previous commit is 05b8e0c)
OSTYPE:               linux-gnu
TERM:                 xterm-256color
TERM_PROGRAM:
TERM_PROGRAM_VERSION:
ZIM_HOME:             /tmp/tmp.FjTXshbGLs/.zim
ZSH_VERSION:          5.8.1

Additional context
Maybe this plugin (and also others) should use something like "emulate -L zsh" ?
According to man zshoptions :
       LOCAL_OPTIONS <K>
              If this option is set at the point of return from a shell  func‐
              tion, most options (including this one) which were in force upon
              entry to the function are restored; options  that  are  not  re‐
              stored  are PRIVILEGED and RESTRICTED.  Otherwise, only this op‐
              tion, and the LOCAL_LOOPS, XTRACE and  PRINT_EXIT_VALUE  options
              are  restored.   Hence  if  this  is explicitly unset by a shell
              function the other options in force at the point of return  will
              remain  so.   A shell function can also guarantee itself a known
              shell configuration with a formulation like  `emulate  -L  zsh';
              the -L activates LOCAL_OPTIONS.

Unless there is a way to do this in zimfw/zimfw rather than in each module.
Thanks

Hi @fdelavier. Good point. The zimfw plugin manager was already updated to use builtin emulate -L zsh, but not the modules. Will start by fixing this one. Thanks!


Super Secret Password on example project!

Super Secret Password on example project!

That sounds like a good joke :).

I tried to npm install and npm start on example project in this repo.
But it don't show nothing
Super Secret Password

Well because the examples aren't there to show anything. If you see that it means it's working :+1: And you can build your app starting from there :grin:


Add Svelte link so Kit website.

this seems like it might be out of place since it's text and the others are images

I was thinking that on right side, there are "external" sources, resp. anything else than kit.svelte.dev, should I move it to middle?

that doesn't seem right either. my inclination would be to make it a svelte logo

I got that idea about using logo too. but the problem is Svelte and SvelteKit have same logo. For user it can be confusing?

How about this?

Can you share a screenshot?

will this be merged? Btw. after rebase, this PR is totally mess...

Fixed version of your PR here: https://github.com/sveltejs/sites/pull/62
I think you might just need to delete your sites repo and start over


fix: use newer editableText component

Description

Removes red background on error (fixes https://github.com/appsmithorg/appsmith/issues/24098)
Changes saving state icon to use new standard loader icon (fixes https://github.com/appsmithorg/appsmith/issues/24112)

Media
https://github.com/appsmithorg/appsmith/assets/13763558/d5fc8b4d-f3cd-4b9d-a0d7-54c9aa9921c6

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test
/build-deploy-preview env=release skip-tests=true

/build-deploy-preview env=release skip-tests=true

Issue 1 - Fixed

Issue 2 - We are now able to see the new Loader. However the loader does not seem to rotate like it does in other places. Also we are not able to see the loader after changing the Workspace name.

https://github.com/appsmithorg/appsmith/assets/39921438/06e0faf7-d3e6-42c6-ba40-67ea7fd5b21c

However the loader does not seem to rotate like it does in other places.

To do so we would have to update the design-system-old spinner, which is not useful as we are building a new component for this in a few weeks time. I have changed the icon so that the difference is not glaring when seen for a split second.

/ok-to-test

/ok-to-test

@tanvibhakta I see we are using old gray in edit field. Approving the rest of the changes.


 At one pack, vehicles cannot pass. One on each team side.
Expected behavior
All Supply Piles can be moved around equally. No confusion.
Screenshots
Vehicles can drive around.

Vehicles can not drive around, but infantry can move around.

fixed.


HADOOP-18635 : Expose distcp counters to user via new DistCpConstants "CONF_LABEL_DI…

…STCP_TOTAL_BYTES_COPIED".
The constant indicate number of bytes copied by distcp operation. It is exposed via configuration parameter through which user can obtain the value.

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  8s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 58s

trunk passed

+1 :green_heart:
shadedclient
23m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-tools_hadoop-distcp.txt
hadoop-tools/hadoop-distcp: The patch generated 3 new + 18 unchanged - 0 fixed = 21 total (was 18)

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
shadedclient
23m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
15m 58s
/patch-unit-hadoop-tools_hadoop-distcp.txt
hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

117m 35s

Reason
Tests

Failed junit tests
hadoop.tools.TestExternalCall

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5402

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1c80ac3f44b1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a3dcbd611b0d06f06431e4128c96bcfacf9c3866

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/1/testReport/

Max. process+thread count
704 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 32s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 58s

trunk passed

+1 :green_heart:
shadedclient
25m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-tools_hadoop-distcp.txt
hadoop-tools/hadoop-distcp: The patch generated 5 new + 29 unchanged - 0 fixed = 34 total (was 29)

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 57s

the patch passed

+1 :green_heart:
shadedclient
24m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
15m 21s
/patch-unit-hadoop-tools_hadoop-distcp.txt
hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

120m 24s

Reason
Tests

Failed junit tests
hadoop.tools.TestExternalCall

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5402

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6e382f48f842 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bce2f6885de6486f50e21fab63479fb77308225

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/2/testReport/

Max. process+thread count
566 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
42m 15s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 58s

trunk passed

+1 :green_heart:
shadedclient
24m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 53s

the patch passed

+1 :green_heart:
shadedclient
25m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
16m  0s
/patch-unit-hadoop-tools_hadoop-distcp.txt
hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

119m 28s

Reason
Tests

Failed junit tests
hadoop.tools.TestExternalCall

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5402

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ac77e5e911bb 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3b4574246a6cbf9d3f04c7a15aa1fd5f7f7fe61c

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/3/testReport/

Max. process+thread count
572 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m  5s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 55s

trunk passed

+1 :green_heart:
shadedclient
26m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 49s

the patch passed

+1 :green_heart:
shadedclient
26m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
14m 52s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

123m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5402

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a45725ac2cee 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 15669c18810037abf5204f0fd868e23d253532c8

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/4/testReport/

Max. process+thread count
585 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5402/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I really don't like how the results come back.
I'm going to propose adding IOStatistics support to distcp so lined up for future work and to not modify the source config to suddenly become two way exchange of data

DistCp to implement IOStatisticsSource
until job finishes, getIOStatistics() to return null
when job finished,

// to create a builder
IOStatisticsStore iostats = IOStatisticsBinding.iostatisticsStore()
  .withCounter(DISTCP_TOTAL_BYTES_COPIED)
  .build()

// then set the counter to the retrieved value
iostats.setCounter(DISTCP_TOTAL_BYTES_COPIED, <counter>)

This is extra work and you have to learn a new api, but

IOStatisticsAssertions has the asserts
IOStatisticsLogging has pretty printing
you can take an IOStatisticsSnapshot and send over the wire as json or java serialized object
lines it up perfectly for us collecting more detailed stats, not just from the workers (trickier...) but also cost of directory scanning, cleanup etc.


⚠ ClamAV has degraded performance

In f07bada, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 17c132d after 24 minutes.


Centos 6 with Kernel 3.10 ruid_setup>ruid_set_perm:setgid(48) failed

Hello, I'm using mod_ruid2 for a long time and this is the first time that I'm having issue. I'm installing a new server to replace an old one. I installed mod_ruid2 using yum
mod_ruid2-0.9.8-2.el6.x86_64
After the installation I've configured on the following way one of the virtual host
<Directory /var/www/vhosts/MYDOMAIN.COM/httpdocs>
RMode config
RUidGid mydomain psacln
RGroups psacln

But when I'm trying to test my website i'm getting the following error at /var/log/httpd/error_log
[Tue Jul 07 12:48:44 2015] [error] mod_ruid2 www.MYDOMAIN.COM GET / HTTP/1.0 ruid_setup>ruid_set_perm:setgid(48) failed. getgid=48 getuid=48
My server doesn't have SELinux configured, in fact it's disabled.
I checked the source code and found the lines where it's giving error
Line 523, where is checking if setgid(gid) is 0
    if (setgid(gid) != 0)
    {
            ap_log_error (APLOG_MARK, APLOG_ERR, 0, NULL, "%s %s %s %s>%s:setgid(%d) failed. getgid=%d getuid=%d", MODULE_NAME, ap_get_server_name(r), r->the_request, from_func, __func__, dconf->ruid_gid, getgid(), getuid());
            retval = HTTP_FORBIDDEN;
    } else {
            if (setuid(uid) != 0)
            {
                    ap_log_error (APLOG_MARK, APLOG_ERR, 0, NULL, "%s %s %s %s>%s:setuid(%d) failed. getuid=%d", MODULE_NAME, ap_get_server_name(r), r->the_request, from_func, __func__, dconf->ruid_uid, getuid());
                    retval = HTTP_FORBIDDEN;
            }
    }

My question is, is there any chance that Kernel 3.x are blocking some action at this module? I couldn't find the same issue at internet.
UPDATE: I've been able to install a kernel 2.6.X and it's working without problem but now I'm beeing crazy trying to understand/find why it's not working with kernel 3.10.X

Have seen this error on new boxes, where i migrated working setups from old ( but both had same OS/Apache/PHP version, but do to being different provider, they did run different kernel - can't tell now which exactly ).
Non working setup was like this :
<VirtualHost ..>
...
<Directory /abc/com>
Mode config
RUidGid some thing
...

Once i moved ruid2 config outside of Directory, started working without changing kernel :
<VirtualHost ..>
...
Mode config
RUidGid some thing
<Directory /abc/com>
...

While its not an equivalent config, it may help someone.


Alternative?

Since this project seems dead, is there any alternative for this project?

I'm afraid not AFAIK
I suggest you to look at my code to implement your own system. It is not a lot of code. My idea was to do it properly as a jquery plugin but this is really not necessary.
Good luck

Your code is nicely ported to nodejs ;)

Is this nicely ported code is available on Github? :)


Better error messages when api is down

As I write this issue it seems that https://corona.lmao.ninja/countries is down? so the cli hangs for around 2 minutes and then spits out the following error
undefined UNHANDLED ERROR
undefined ERROR → Error
i REASON → Request failed with status code 524
i ERROR STACK ↓
 Error: Request failed with status code 524
    at createError (C:\Users\user\AppData\Roaming\npm\node_modules\corona-cli\node_modules\axios\lib\core\createError.js:16:15)
    at settle (C:\Users\user\AppData\Roaming\npm\node_modules\corona-cli\node_modules\axios\lib\core\settle.js:17:12)
    at IncomingMessage.handleStreamEnd (C:\Users\user\AppData\Roaming\npm\node_modules\corona-cli\node_modules\axios\lib\adapters\http.js:236:11)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Would be better to have some sort of timeout a minute or so and then notify the user that the api is down / can't be reached

DONE
🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.2.0
🔗 https://www.npmjs.com/package/corona-cli

Beautiful! Thank you!


Withraw jmeter tests

this PR can be closed and the test should be added into ext_repo https://github.com/lnbits/lnbits-extensions/pull/283

this PR can be closed and the test should be added into ext_repo lnbits/lnbits-extensions#283

I agree, can you please move this test there

after it is merged


Add CALL logo, first ERC777 token by GCA

GCA / Global Crypto Alliance (gcalliance.io). First ERC777 token ever

To speed up the screening process, please provide detail information about the project, media coverage (if any), and the following information to help imToken team better understand your project.
Team background:
Project current status:
Media coverage:
Recommended gas limit for users (default is 60,000):
PR example: https://github.com/consenlabs/token-profile/pull/1636


Harden GitHub action workflows

We use SHAs instead of tag names to refer to action versions. Dependabot will help us manage the SHAs.
Update permissions to minimum necessary.
Add harden-runner to monitor egress of action. After some time, we can tighten the egress to limit hosts/ports.
We also update the maintainers script to generate markdown which passes markdownlint checking.

@bjhargrave overall looks good but why was the DCO check removed?

why was the DCO check removed

@nathan-weinberg It is not removing the DCO check. That config permitted org members to skip the Signed-off-by in their commit messages. I don't think we want that anymore. It was part of the initial commit for this repo to get things going.
https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members


Change Arbitrum banner into Ethereum banner

Rationale
Launch on Ethereum will replace the Arbitrum launch banner on the website and dapp
Implementation
Change wording into: "Layer up! You can now bridge from L1 (Ethereum) to rollups (L2)"

@andfletcher is this copy validated by marketing @DBecane  ? I'm not in favor of using brackets in info stripes, it adds an extra layer of commentary. If we want to go more specific I would rather just write L1 Ethereum and L2 Rollups and make a decision on semantic consistency

@andfletcher is this copy validated by marketing @DBecane ? I'm not in favor of using brackets in info stripes, it adds an extra layer of commentary. If we want to go more specific I would rather just write L1 Ethereum and L2 Rollups and make a decision on semantic consistency

@olympe-silve yes, I copy-pasted it.
@DBecane your call. but please hurry up.

@andfletcher is this copy validated by marketing @DBecane ? I'm not in favor of using brackets in info stripes, it adds an extra layer of commentary. If we want to go more specific I would rather just write L1 Ethereum and L2 Rollups and make a decision on semantic consistency

Fully agree with this

"Layer up! You can now bridge from Ethereum L1 to rollups"

@GabrielBuragev see the final decision above ! To use on both the website news stripe and the app news stripe.
Keep the little stars also !


[rlgl] Array Texture support

Issue description
For my project I need array texture support.
Array textures simplfy managing multiple textures of the same size and format. Instead of switching the texture each drawcall, a single index can be used and thus objects with different textures can be batched. You can even use them to emulate 3D texture without much overhead.
This feature is core since OpenGL 3.0 and OpenGL ES 3.0, which both are supported by Raylib. However they are not exposed by Raylib.
Proposed changes
I could think of two ways to add this to raylib:

Add a new Texture2DArray type:
typedef struct Texture2DArray {
    unsigned int id;        // OpenGL texture id
    int width;              // Texture base width
    int height;             // Texture base height
    int slices;             // Amount of slices
    int mipmaps;            // Mipmap levels, 1 by default
    int format;             // Data format (PixelFormat type)
} Texture2DArray;

👍Pros:

Doesn't touch Texture.
Type safety at compile time.
Can be hidden away in rlgl to keep the core API clean.
Easy to validate platform compatibility at compile time.

👎Cons:

Needs additional API which increases rlgl complexity.

Alternative: Turn Texture into an uber struct for all texture needs:
typedef struct Texture {
    unsigned int id;        // OpenGL texture id
    int width;              // Texture base width
    int height;             // Texture base height
    int slices;             // NEW: Amount of slices, 0 by default
    int mipmaps;            // Mipmap levels, 1 by default
    int format;             // Data format (PixelFormat type)
} Texture;

By setting slices to > 1 indicates that this is an array texture.
👍Pros:

No additional API. Existing texture API would simply be extended for support.

👎Cons:

Increases complexity of Texture which is frequently used.
No type safety. Mismatching types (texture vs. array texture) would only be caught at runtime.
Might confuse beginners.

@julhe I prefer to avoid texture arrays. I think not that many users would benefit of this addition and it adds an unneeded extra level of complexity to raylib.

@raysan5 I was just researching array texture support in raylib and stumbled upon this issue.
In my opinion, support for array textures could actually benefit many users, as it is the preferred alternative to using texture atlases, avoiding issues such as bleeding during mipmap generation.
I understand the desire to limit the complexity of raylib, however, this also limits the what can be achieved with it and/or greatly increases the complexity of applications developed with it (for example, having to deal with mipmapping texture atlases correctly).
I really enjoy working with raylib as it usually speeds up my work a lot - in some situations, such as this one, it can be frustrating though.
As texture arrays are nowadays a rather standard technique, I would argue that it could actually be confusing for users not to be able to use it, and having to learn about workarounds / other techniques to accomplish the same goal.
A reconsideration of this feature on your part would be greatly appreciated, but I understand if you choose to limit raylib to more basic features.

I think the use of texture arrays is limited to a few specific use-cases, most users don't probably need it and users requiring that advance feature are probably users able to implement it directly with OpenGL for their specific use cases.


About This Hack reads opencore version incorrectly

It's not that serious of a issue to be honest, more just a visual thing.

ATH seems to not be able to read opencore version correctly now, as version 2 has released this week. I'm sure its a easy fix, but I just wanted to point it out :)

I don't see a problem? OpenCore is being read as it should be.

Oh? I thought it was reading the version wrong: 1.0.1 instead of 2.0.1, which is the latest release. If I'm wrong, I'll just close the ticket.


Update http4s-blaze-client, ... to 0.20.6

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.20.4 to 0.20.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.http4s" }]

labels: semver-patch

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   51.63%   51.63%
=======================================
  Files          29       29
  Lines         244      244
=======================================
  Hits          126      126
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688e7b1...eff9930. Read the comment docs.


[Exploris] Issue with EASY-IC lockmass calibration/filtering

I am running into an issue when converting a .raw file from an Exploris 120 to the mzML format with ThermoRawFileParser.
The mzML file is converted successfully and lockmass is presumably applied to the generated data. However the lockmass (202.0778) is not filtered out from the MS1 and MS2 scans like it is the case when examining the spectra with XCalibur and FreeStyle. I tried to look into the different parameters of ThermoRawFileParser, but without success. Any insight about how to get the calibrated/filtered data from the .raw file to .mzML with ThermoRawFileParser ?
Thanks in advance for the support.
The raw and resulting mzML files here (as well as mzXML from RawConverter see below):
https://drive.switch.ch/index.php/s/y35gSbwxpn8sk8s
Converted with the following parameters:
ThermoRawFileParser.exe" -i 20230217_RMG_RMG_1_conditioning_26.raw --ignoreInstrumentErrors

NB1: trying to convert the same file with MSConvert fails with an error.
Starting...
Opening file "J:\20230217_RMG_RMG_1_conditioning_26.raw" for read...
Calculating SHA1 checksum...
Processing...
Failed - System.Runtime.InteropServices.SEHException (0x80004005): External component has thrown an exception.
   at pwiz.analysis.SpectrumListFactory.wrap(MSData* , vector<std::basic_string<char\,std::char_traits<char>\,std::allocator<char> >\,std::allocator<std::basic_string<char\,std::char_traits<char>\,std::allocator<char> > > >* , IterationListenerRegistry* )
   at pwiz.CLI.analysis.SpectrumListFactory.wrap(MSData msd, IList`1 wrappers, IterationListenerRegistry ilr)
   at MSConvertGUI.MainLogic.processFile(String filename, Config config, ReaderList readers, Map`2 usedOutputFilenames)
   at MSConvertGUI.MainLogic.Go(Config config, Map`2 usedOutputFilenames)

NB2: trying converting the same file with RawConverter produces an mzXML file with lockmass removed (trying mzML doesn't create an output file).
(http://fields.scripps.edu/rawconv/

Hi @lfnothias,
thank you for using ThermoRawFileParser. Lock mass is applied at the instrument side, i.e. the spectra are already recalibrated in the raw file, and, thus, TRFP does not perform any processing of it. Lock mass is a part of the, so-called, reference peak data, it is included in the output by default (similarly to how it is done in MSConvert), you can use -x, --excludeExceptionData to exclude it. Please, note, however, that this option excludes not only lock mass (and other reference data) but also some other peaks (for example, artifacts of FT process, splits, etc), all such peaks are marked by the instrument as exception. There is no option to exclude them separately. Usually, it is just a couple of such peaks per spectrum, and, thus, they do not make a huge difference for any downstream data analysis. Marking exclusion and reference peaks and adding/removing them from the scan data are performed by the instrument itself and the raw file reading libraries, respectively; TRFP just request and reads the data provided, i.e. does not modify it in any way.
The scans that have lock mass applied will have the word lock in their scan filter (this parameter is included in mzML output).
Please, let me know if it answers you question.

Wonderful ! Thanks a lot for the support. That works beautifully ! With that option the EASY-IC lockmass is removed from MS1 and MS2 scans in the mzML produced. I checked both for POS and NEG mode.
Eyeballing few MS2 spectra, it seems that there might be residual mass observed at very low level for m/z 201.0708 in negative mode and 201.128 in pos mode, but it seems neglectable.


Fixed the switch-off subcommand in Fish

Current behavior:
$ phpbrew switch-off
Invalid: command not found
~/.phpbrew/init (line 2):
Invalid argument
^
from sourcing file ~/.phpbrew/init
	called on line 699 of file ~/.phpbrew/phpbrew.fish

in function “__phpbrew_update_config”
	called on line 726 of file ~/.phpbrew/phpbrew.fish
	with parameter list “”

in function “__phpbrew_reinit”
	called on line 379 of file ~/.phpbrew/phpbrew.fish

in function “phpbrew”
	called on standard input
	with parameter list “switch-off”

phpbrew is switched off.

Additionally:

Fixed the switch-off behavior when there's no system PHP version (Bash and Fish):$ phpbrew switch-off
/usr/bin/env: ‘php’: No such file or directory
phpbrew is switched off.

Refactored the generation of the ~/.phpbrew/init file (Bash and Fish).

Fixes #926.
Fixes #905.
Closes #1015.
Closes #1037.

Coverage decreased (-0.09%) to 40.312% when pulling 2a6ab0e0fb13bd8dcab53a77310c909f73766a51 on morozov:issues/926 into 040c806070ee3380a13b05f71a0db26996baead6 on phpbrew:master.


Register routers through FPS

Closes #98

Thanks for this @davidbrochart -- sorry this never got any attention. Nonetheless, we now support registering datasets and routers via plugins: https://xpublish.readthedocs.io/en/0.3.3/user-guide/plugins.html


plaso VSS option incorrect

https://github.com/log2timeline/plaso/blob/9cc50c972b257d6cbbea38fa8b39f0bf027e0960/plaso/cli/storage_media_tool.py#L581
^ option should be --no_vss in below location
https://github.com/google/turbinia/blob/86158a95a0b134978628c1680d0997667ec7c935/turbinia/workers/plaso.py#L43
Please check how this will work if recipes pass in the --vss_stores option

The current default for unattended mode is to disable VSS processing, so the --no_vss option should not be necessary. However I'll change Plaso UX to deprecate --no_vss and support --vss_stores=none going forward. Also see: https://github.com/log2timeline/plaso/issues/4150

Looked at this issue today and if i understand correctly, using "--vss_stores none" should not be a problem and we just need to remove any references to the now deprecated "--no_vss" option. Is my understanding correct @joachimmetz ?

As of the (pending) next release plaso will support --vss_stores=none and will complain about --no_vss. In the future --no_vss will be removed.


Add support for nested structures

I would like to be able to create lists in my fields.

Closed since this is no longer necessary.


fix: dependence in package.xml and CmakeLIst.txt

Description
Fixed dependence so that pybind11 can find python modules.

Related links

Notes for reviewers

Pre-review checklist for the PR author

[ ] I've confirmed the contribution guidelines.
[ ] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR has been properly tested.
[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] (Optional) The PR has been properly tested with CARET_report verification.
[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 6.70%. Comparing base (dab6890) to head (0b1924c).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #198   +/-   ##
=====================================
  Coverage   6.70%   6.70%
=====================================
  Files         15      15
  Lines        969     969
  Branches     374     374
=====================================
  Hits          65      65
  Misses       873     873
  Partials      31      31

Flag
Coverage Δ

differential
6.70% <ø> (?)

total
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enhancement: Alert Design

Hello
can you add some alert dialog design? I would like a Alert dialog that is on the page shown and not as toast or popup. Is there a way to implement this?
Best Regards
ModdyLP

Do you mean modal dialog? http://materializecss.com/modals.html#!

No I mean the same as a Modal Dialog but not as Popup. I think it would look nice if you have a a quarder like the cards and then a symbol for warning or error.

Should it be in library? It's pretty easy to implement it
http://codepen.io/kmmbvnr/pen/pbppLW

Oh that look good but without the Buttons it would be better. But for now thank you very much for your help.

What is the difference between this and a modal?


Android 6

the plugin is not working on android 6.
'Can't play this video.'

I am getting the same thing on android 6 and some phones using 5.1.1   . I am urgently trying to find a solution. Any thoughts?

Same here ! 'Can't play the video.'
Any solutions?

Use the YouTube iframe api instead of this plugin
On Tuesday, December 15, 2015, Deepu Varghese<EMAIL_ADDRESS>wrote:

Same here ! 'Can't play the video.'
Any solutions?
—
Reply to this email directly or view it on GitHub
https://github.com/Glitchbone/CordovaYoutubeVideoPlayer/issues/22#issuecomment-164701639
.

--
This e-mail message, its contents, and any attachments are privileged and
confidential information intended solely for the use of the intended
addressee. If you are not the intended addressee, any dissemination,
distribution, copying, or other use of this message, its contents, or any
attachments is prohibited under applicable law.  If you have received this
e-mail in error, please notify me immediately by reply e-mail, phone, or
fax and delete the message.

Me, too. Can't play on Android 6.0.2

Someone have found a solution?

Me too

I get
"an error occured during the retrieval of the video this could be due to network" also

hey, is anyone still interested on this?
I think this plugin should be update to use https://developers.google.com/youtube/android/player/reference/com/google/android/youtube/player/YouTubePlayer
I just did that, and it works perfectly fine.
There's only one caveat: the android platform would require a YouTube Data API key to work.
I'll probably fork this and add that. :)

hey great to hear that you are working on it. Waiting for your update.
Thank you.

@d0cz .. Hey.. Waiting for your update. :-)
Thank You...

sorry for the long delay... I did all the work in my work account/repository! Didn't log in my personal account for a month (as you can notice).
https://github.com/d0cz/CordovaYoutubeVideoPlayer
hope it helps.... somehow :)

it says

Error: Cannot find plugin.xml for plugin 'package'. Please try adding it again.

when i try to install the plugin.

@d0cz how do I add my API key. Sorry I'm just clueless here.

For Android 5.0+ you will need to update the YOUTUBE_API_KEY (package com.bunkerpalace.cordova.Config) with your own YouTube Key.

I don't understand what file to edit? or you want me to change package name, then where?
Kindly guide thanks


[swedish] sv_welcome_links-documentation

Ping @ random Swedish reviewers - @jacob-carlborg would you be so kind to have a look at this translation, too? :)

Ping @Vild

Updated according to suggestions. Thanks!

@vild @jacob-carlborg thanks for your amazingly fast review! Once you have approved the changes, we can ship this ;-)

Everything looks good what I can see

Everything looks good what I can see

Thanks again to everyone!!


https://babeljs.io/ does not work, but http://babeljs.io/ does

The URL https://babeljs.io/ is listed as https on https://github.com/babel/babel and https://github.com/babel/babel.github.io etc... but https version of URL doesn't work.
http://babeljs.io/ loads fine.
I get this message when I use the https URL.
Secure Connection Failed

An error occurred during a connection to babeljs.io. The server rejected the handshake because the client downgraded to a lower TLS version than the server supports. (Error code: ssl_error_inappropriate_fallback_alert)

    The page you are trying to view cannot be shown because the authenticity of the received data could not be verified.
    Please contact the website owners to inform them of this problem.

What version of firefox are you using?

Firefox 35.0.1 and Chrome Version 40.0.2214.111 m have the issue for me.
Maybe just update your the URLs in  https://github.com/babel/babel etc... to point to http://babeljs.io/

I'm not experiencing this in either browser

hmm... maybe my IT is aggressively blocking certain https urls.

An FYI for others who may have this. My company had a problem with its proxy server (hidden to me) that was causing the issue.


Fix a minor typo

What does this PR accomplish?

📙 Documentation

Changes proposed by this PR:
Just fixes a small typo I noticed
Notes to reviewer:
N/A
📜 Checklist

[x] Works on the ./demo sub directory
[x] Test coverage is excellent and passes
[x] Documentation is thorough

Thanks!