modify scatter_update to hack variable initialization check

Fixes #3373

Can one of the admins verify this patch?

no tests? Also, it looks very hacky in the way it forces initialization.

I'll add test. I have tested on cpu, and it truly reduced memory cost. I find that if use sess.run(data.initializer), memory cost doubles because init_variable will stay in memory.

@suiyuan2009 Thanks a lot for the PR and sorry for the late response. There is lot of good work gone into this CL. However, a kernel initializing an input ref tensor has no precedent elsewhere in TensorFlow. Also, adding @alextp to comment as he might have more insight into this.

@suiyuan2009 Thanks for writing this!
It sounds like the problem you're trying to fix here is that the memory usage for zero-initializing variables is bigger than what it takes to store the variable. Is that it?
If so, I wonder if there's a better way of doing it than hacking scatter_add.

@alextp modifying tf.Variable is a choice.

@suiyuan2009 another option is to make a ZeroInitialize op which allocates storage and zero-initializes it (the current assign op will allocate storage but it needs the zero-tensor to exist).
@mrry @keveman  do you think it makes sense to support this?

@alextp I think your suggestion of a ZeroInitializer op makes more sense than adding a flag to the individual assign ops. I'd be inclined to keep it in tf.contrib because it seems specific to the current implementation of variables, it's not fundamental, and we will probably want to deprecate it once there's no longer a need for it.
Longer term, it would be great if we could identify points in the graph where a tensor buffer is expiring, so we could replace the copy in tf.assign() with a move, but in the short term this should work.

@suiyuan2009 do you want to implement this ZeroInitialize op? I expect it
will be quite similar to what you have here in the end.
On Wed, Sep 7, 2016 at 9:42 AM, Derek Murray<EMAIL_ADDRESS>wrote:

@alextp https://github.com/alextp I think your suggestion of a
ZeroInitializer op makes more sense than adding a flag to the individual
assign ops. I'd be inclined to keep it in tf.contrib because it seems
specific to the current implementation of variables, it's not fundamental,
and we will probably want to deprecate it once there's no longer a need for
it.
Longer term, it would be great if we could identify points in the graph
where a tensor buffer is expiring, so we could replace the copy in
tf.assign() with a move, but in the short term this should work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4077#issuecomment-245342032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxUGcDQo6ifSM9-uT_CYwDn4eCo3dks5qnulcgaJpZM4JuwXP
.

--

Alex

@alextp I'll implement it.

@alextp ZeroInitializerOp is added.

@alextp I moved all codes to tf.contrib.framework, and modified some code as you advised. I don't find a way to track memory usage of tensorflow in python, maybe the allocator in C++ can do it.

Jenkins, test this please.

Jenkins, test this please.

Can you rebase this with master? I see two conflicts, on contrib/.../variables.py and contrib/.../variables_test.py

@alextp conflict solved.

Jenkins, please test this change.

Jenkins, test this please.

Jenkins, test this please.

@gunan do you understand these test failures? Why is a deptest only failing on linux gpu? Is Jenkins building from a merge of master and this branch or from the head of this branch? I'd like to merge this PR but I don't know how to make it work.

@keveman can you help with the build issue?

ERROR: /workspace/tensorflow/contrib/framework/BUILD:38:1: in check_deps rule //tensorflow/contrib/framework:python/ops/_variable_ops.so_check_deps:
Traceback (most recent call last):
File "/workspace/tensorflow/contrib/framework/BUILD", line 38
check_deps(name = 'python/ops/_variable_ops.so_check_deps')
File "/workspace/tensorflow/tensorflow.bzl", line 669, in _check_deps_impl
fail(_dep_label(input_dep) + " cannot...))
tensorflow/contrib/framework/kernels:zero_initializer_op cannot depend on tensorflow/core:framework.
here is the actual failure message.
Does this help about the issue any better?

@gunan I did find this error message, but I don't understand why only the GPU build is doing this dependency check, and where was it added. Any clues?

@alextp I find def tf_custom_op_library has this deps check, and //tensorflow/core:framework in its disallowed_deps list. I use tf_custom_op_library rule in tensorflow/contrib/framework/BUILD, but my tensorflow/contrib/framework/kernels:zero_initializer_op is not depend on tensorflow/core:framework but tensorflow/core:framework_headers_lib.

@alextp works now.

Jenkins, test this please.

@alextp sorted now.

Jenkins test this please.
On Sep 22, 2016 12:15, "Ziming Dong"<EMAIL_ADDRESS>wrote:

@alextp https://github.com/alextp sorted now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4077#issuecomment-248873534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxS0_Z0XR-UgE2reE0R9pDaReKEkfks5qsmNCgaJpZM4JuwXP
.

Jenkins, test this please.

@suiyuan2009 can you merge with master? It seem like this picked a version which fails some unrelated tests. I need the tests to pass before I can merge this PR.

@alextp I did a git rebase, so this is supposed to be the latest.

@alextp I configured python path to python3 and run bazel test the-target, everything is ok.

Jenkins, test this please.

Looking at the jenkins status I think tensorflow master might be broken. @m3bm3b as the buildcop, am I right or did I misread something?

(and I suspect things are broken because https://ci.tensorflow.org/view/Tensorflow Jenkins Monitored builds/ has red in suspicious places)

It certainly looks suspicious to me.
I will look into it..
Mike
On 22 September 2016 at 10:43, Alexandre Passos<EMAIL_ADDRESS>wrote:

(and I suspect things are broken because https://ci.tensorflow.org/
view/Tensorflow%20Jenkins%20Monitored%20builds/ has red in suspicious
places)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4077#issuecomment-248974836,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJsp2TFa3LuLGvtfIihowQIx2bU4HaHtks5qsr5XgaJpZM4JuwXP
.

Opensource tests are triaged by another rotation.
Adding @martinwicke FYI.

Jenkins, test this please.

@alextp can you see the build log, I used another machine to build and it failed, the log says Error in /usr/bin/python': double free or corruption`

test passed on my master branch, but failed on this pr branch, error msg is
`/tensorflow/bazel-out/local-py3-opt/testlogs/tensorflow/contrib/learn/random_forest_test/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
WARNING:tensorflow:Using temporary folder as model directory: /tmp/tmprlp8hgwp
WARNING:tensorflow:Using default config.
WARNING:tensorflow:Given features: Tensor("input:0", shape=(?, 4), dtype=float32), required signatures: TensorSignature(dtype=tf.float32, shape=TensorShape([Dimension(None), Dimension(4)]), is_sparse=False).
WARNING:tensorflow:Given targets: Tensor("output:0", shape=(?,), dtype=float32), required signatures: TensorSignature(dtype=tf.float32, shape=TensorShape([Dimension(None)]), is_sparse=False).
/home/zido/.cache/bazel/_bazel_zido/374c60a9747170d275c203f96a981f83/execroot/tensorflow/bazel-out/local-py3-opt/bin/tensorflow/contrib/learn/random_forest_test.runfiles/org_tensorflow/tensorflow/contrib/learn/python/learn/graph_actions.py:778: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
logging.warn('Input iterator is exhausted: %s.', e)
WARNING:tensorflow:Input iterator is exhausted: .
.WARNING:tensorflow:Using temporary folder as model directory: /tmp/tmp5qucovm4
WARNING:tensorflow:Using default config.
WARNING:tensorflow:Given features: Tensor("input:0", shape=(?, 13), dtype=float32), required signatures: TensorSignature(dtype=tf.float32, shape=TensorShape([Dimension(None), Dimension(13)]), is_sparse=False).
WARNING:tensorflow:Given targets: Tensor("output:0", shape=(?,), dtype=float32), required signatures: TensorSignature(dtype=tf.float32, shape=TensorShape([Dimension(None)]), is_sparse=False).
WARNING:tensorflow:Input iterator is exhausted: .
..
Ran 3 tests in 17.033s
OK
*** Error in /usr/bin/python3': double free or corruption (!prev): 0x000000000171c350 ***

I run  gdb --args python3 tensorflow/contrib/quantization/python/dequantize_op_test.py, get
----------------------------------------------------------------------
Ran 3 tests in 0.070s

OK

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff787601f in _int_free (av=0x7ffff7bb5760 <main_arena>, p=<optimized out>, have_lock=0) at malloc.c:3996
3996    malloc.c: No such file or directory.

@alextp I think it's ok now. It seems load_op_library has some problem with test_session, but I can't figure it out.

Jenkins, test this please.

Android Demo App test has a download problem.

Jenkins, test this please.

I do not see any error, It simply fails when I configure for GPU, and run:
$ bazel test tensorflow/contrib/framework:variables_test -c opt
--config=cuda
On Sat, Oct 1, 2016 at 9:05 PM, Ziming Dong<EMAIL_ADDRESS>wrote:

@suiyuan2009 commented on this pull request.
In tensorflow/contrib/framework/python/ops/variables_test.py
https://github.com/tensorflow/tensorflow/pull/4077:

var = tf.Variable(initializer)

var_zero = tf.contrib.framework.zero_initializer(var)
with self.test_session() as sess:

 with self.assertRaisesOpError("Attempting to use uninitialized value"):

   var.eval()

 if use_init:

   sess.run(var.initializer)

   with self.assertRaisesOpError("input is already initialized"):

     var_zero.eval()

   self.assertAllClose(np.ones(shape), var.eval())

 else:

   var_zero.eval()

   self.assertAllClose(np.zeros(shape), var.eval())

def testZeroInitializer(self):
for dtype in (tf.int32, tf.int64, tf.float32, tf.float64):

What's the error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4077, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHlCOdln7PFHFtuDvcKzuodHX5G9Ciwtks5qvy1ygaJpZM4JuwXP
.

Any nightly GPU build which runs this test is also broken:
http://ci.tensorflow.org/view/Nightly/job/nightly-matrix-mac-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON3,label=mac1-slave/79/console
http://ci.tensorflow.org/view/Nightly/job/nightly-matrix-mac-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON2,label=mac1-slave/79/console
http://ci.tensorflow.org/view/Nightly/job/nightly-matrix-linux-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON3,label=gpu-linux/247/console
http://ci.tensorflow.org/view/Nightly/job/nightly-matrix-linux-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON3.5,label=gpu-linux/247/console
http://ci.tensorflow.org/view/Nightly/job/nightly-matrix-linux-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON2,label=gpu-linux/247/console
it is not even flaky, it only runs on pip tests, and it fails on every
single run on GPU.
This test is omitted from no-pip runs on jenkins. That is how we missed the
breakage before.
On Sat, Oct 1, 2016 at 9:30 PM, Gunhan Gulsoy<EMAIL_ADDRESS>wrote:

I do not see any error, It simply fails when I configure for GPU, and run:
$ bazel test tensorflow/contrib/framework:variables_test -c opt
--config=cuda
On Sat, Oct 1, 2016 at 9:05 PM, Ziming Dong<EMAIL_ADDRESS>wrote:

@suiyuan2009 commented on this pull request.
In tensorflow/contrib/framework/python/ops/variables_test.py
https://github.com/tensorflow/tensorflow/pull/4077:

var = tf.Variable(initializer)

var_zero = tf.contrib.framework.zero_initializer(var)
with self.test_session() as sess:

 with self.assertRaisesOpError("Attempting to use uninitialized value"):

   var.eval()

 if use_init:

   sess.run(var.initializer)

   with self.assertRaisesOpError("input is already initialized"):

     var_zero.eval()

   self.assertAllClose(np.ones(shape), var.eval())

 else:

   var_zero.eval()

   self.assertAllClose(np.zeros(shape), var.eval())

def testZeroInitializer(self):
for dtype in (tf.int32, tf.int64, tf.float32, tf.float64):

What's the error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4077, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHlCOdln7PFHFtuDvcKzuodHX5G9Ciwtks5qvy1ygaJpZM4JuwXP
.

@gunan I'll test on my local machine to see what's wrong.

Sent out a proposed fix for it internally (did it there because it's easier to test). Don't worry about it :)
Essentially just passed the Device as a parameter and changed it to:
auto out_flat = out_tensor->flat<T>();
out_flat.device(ctx->eigen_device<Device>()) = out_flat.constant(T(0));

@jhseu Thank you~


Add documentation on plotting ASReview files

added response to issue #464

Thanks @paprika27. Happy to merge.
Looking forward to more contributions by you.

Thanks @paprika27. Happy to merge.
Looking forward to more contributions by you.


ScrollView doesn't take rejection well ?

Couldn't understand this warning!

Imo dup of #41, CC: @brentvatne

Yes I think this is the same as #41. I don't want to add more documentation in this regard, but we could clarify the warning.

Warning: A View is trying to become touch responder, but ScrollView will still respond to the touch (See https://github.com/facebook/react-native/issues/41)

Is this better?


Items Improvments

We need to solidify, document, and improve the structure of items.

[x] Ownership
[x] Better abstraction so creating new items and modifying them is easier
[x] #14
[ ] Create documentation

No one else is using or modifying items in any substantial way so I am putting off documentation


chore(ci): cancel previous workflow runs on push

Issue being fixed or feature implemented

Slow workflow runs can fill up the pipeline, making it necessary to manually cancel older runs. This PR adds an action to the workflow to cancel previous runs from the same branch with a different SHA.
What was done?

Add styfle/cancel-workflow-action action
How Has This Been Tested?

In CI
Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

I think this is failing because we need to cherry-pick commits from v0.20-dev into master. I tried to learn how to do this, I think the procedure is to cherry-pick from v0.20-dev to master on the local machine and push? Does this look right?
git checkout master
git cherry-pick 135baeb^..44d91a8
git push


k2tf: reproducible vendor

Description of changes
related to https://github.com/NixOS/nixpkgs/pull/245159
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@Janik-Haag can you have a look a this?

Result of nixpkgs-review pr 246648 run on x86_64-linux 1

1 package built:

k2tf

Sorry that it took me so long to respond 🙈

no worries, appreciate your time !


Add repeat table headers

Repeat table headers

Hei, Alice.
Thanks for the thoughtful PR.  A few thoughts:

I wonder if the boolean is necessary.  Said differently, if the repeating header rows count parameter defaults to zero (which we need to do to avoid a backwards-incompatible change), it would already be truthy/falsey.  I was thinking the interface might be simpler to either declare a certain number of repeating rows and get that behaviour, or declare nothing and get no repeating behaviour.
Please add corresponding tests to the table model spec.
Please update the README so other users can learn about the feature.

Thanks!

Hi, John!
I implemented your comments and fix code.
Thank you for your advices!

Hi, John!
I implemented your comments and fixed code.
Thank you for your advices!

Awesome!  I tend to work on issues and PRs once a month at a local meetup, so I'll do a final review then and get everything integrated into an official release.
I'm super fussy about naming so I may make a few cosmetic alterations to your code, but I'll ping you here either way so you can update your Gemfile and, if necessary, do a fast find-and-replace on your caracal views.
Thanks for contributing!

Any news around this @jdugan? Something I can do?

Hello @AliceVerner
Thanks for sharing this,
Why your PR did not merge it will help everyone.


Average electron position / Dipole Integrals

Hi, I am trying to get the integral
<i| r |j>
which I assume to be
[<i| x |j>,   <i| y |j>,   <i| z |j>]
Is this assumption correct?
I am running the following case:
H 0.0 0.0 0.0
sto-3g basis
atoms = [1, 0, 0, 0, 0, 0]
natoms = 1
bas = [0, 0, 3, 1, 0, 3, 6, 0]
nbas = 1
env =  [0.0
 0.0
 0.0
 3.425250914
 0.6239137298
 0.168855404
 0.9817067282501578
 0.9494640079478909
 0.2959064596969707]

which is a Hydrogen at 0.0 0.0 0.0, with a normalized STO-3g basis.
Running
cint1e_r0_sph!(buf, [0,0], atoms, natoms, bas, nbas, env)

I get buf = [0.0,   0.0,   -3.4252091]
I need some help interpreting this result. Is this integral equivalent to the average position of the electron? If so, should it not be zero?
Ultimately, I am trying to write a little orbital localization scheme following this paper. If you could give some directions regarding these integrals I would appreciate it.
Thank you.

I think there should be at least 4 numbers before exponents in env, 3 numbers for xyz and one for zeta.
And, a recommended way is to call from pyscf. Here is an example
from pyscf import gto

mol = gto.Mole(atom='''H 0.0 0.0 0.0''', basis='sto-3g',
      spin=1).build()

print(mol._atm, mol._bas, mol._env)
print(mol.intor_by_shell('int1e_r_sph', (0,0)))

which provides all zero integrals as expected.
with this script you  can see a set of correct _atm, _bas and _env can be
[[ 1 20  1 23  0  0]]
[[ 0  0  3  1  0 24 27  0]]
[0.         0.         0.         0.         0.         0.
 0.         0.         0.         0.         0.         0.
 0.         0.         0.         0.         0.         0.
 0.         0.         0.         0.         0.         0.
 3.42525091 0.62391373 0.1688554  0.98170675 0.94946401 0.29590645]

Here, 20-22nd numbers are xyz, 23rd is zeta, and 24-26th are exponents. (count from zero)

Thank you!
Is there a reason why you start env with those 20 extra zeros?

Thank you!
Is there a reason why you start env with those 20 extra zeros?

That's generated by PySCF (hardcoded, I think).

Thank you!
Is there a reason why you start env with those 20 extra zeros?

That's generated by PySCF (hardcoded, I think).

It seems that without those, I get incorrect integrals for dipole moment. Just a thing to keep in mind if using libcint directly.

The beginning of env is reserved for some parameters, like the gauge origin, the parameter for range-separated integrals.  Here are the definitions https://github.com/sunqm/libcint/blob/master/include/cint.h.in#L25. Dipole integrals needs env[1:4] to save the common origin of the dipole operator


a section for implementations?

Why not create a section for implementations?

I've just finished a Python implementation.

ping @jbenet

following the merge of #16 this issue can now be closed

following the merge of #16 this issue can now be closed


Add @typescript-eslint/consistent-type-imports to eslint config

How does everyone feel about just adding this as an eslint rule so we don't have to think about whether something should be imported as a type or a value for optimization?
This should make it easier to enforce import types where can essentially just run eslint --fix

Oh @bwateratmsft is going to love this. Yeah we should add this to our shared eslint config.

Will update this next week using the shared eslint config*

Updated!


Cannot receive bitcoin funds in Bitcoin Core Wallet

I know very little about all of this, but thought it would be easy to make a deposit with Circle and to send it to Bitcoin Core as a wallet.
I originally sent money from Circle to Bitcoin Core Aug. 3rd. The bar at the bottom of Bitcoin Core read 7 years and some weeks.  I left my computer on as I kept getting requests for more space on my computer. Eventually, after about 4 days, the bar went down to 1 year and some weeks. At this time, everything stopped. I have a very old computer and I assumed that was the problem. I started the process all over again at 7 years and some weeks. In the last three days, it has dwindled down to 2 years and 15 weeks, but once again is frozen.
Someone recommended putting the wallet file into Blockchain to actually get the bitcoins I have not been able to access. I found the file, and dumped it into the window on Blockchain. I then typed the necessary info to ensure that I was not a robot. Then I got this prompt:
If this wallet is encrypted please enter the password below. Otherwise leave it blank. I left this blank, I have no idea what password I would have to enter. After I entered this info, nothing happens. No new wallet is opened and when I did open a new wallet with them, I don't see any of these bitcoins in the wallet.
ANY HELP???? Please!?
Thanks, and thanks for your patience with my lack of knowledge about all of this.

I'm sorry to hear that you are having such a difficult time. Unfortunately, we are not able to provide support for bitcoin core. My best suggestion is to post your issue to https://www.reddit.com/r/btc/ or https://www.reddit.com/r/bitcoin/. If you need assistance with a KeepKey product, please visit our support desk at https://keepkey.freshdesk.com/support/solutions.


fix static default builds

In the Makefile the default builds did not use the static_build flag
and would always build shared executable.
Signed-off-by: Keith Wiles<EMAIL_ADDRESS>

Works with default build now, thanks!


Enable autocomplete anywhere in expression.

@beorn7 @fabxc

The problem I see here that it enables the (metric name) autocomplete really anywhere, i.e. if I type a label name or a label value, it will still show me metric names. That's perhaps more confusing (especially for the non-pro user) than it helps.
I realize that we basically have to re-implement parts of the parser in JS to provide better autocompletion. It would be super awesome to have label name or even label value autocompletion, but until then, we should at least offer autocompletion only where a metric name is expected.

@beorn7 Valid point. Though after using this for a while, it's hard to imagine going back to a non-autocomplete behavior. So I'm split. Will sleep over this some more (we'll be distracted the next days anyways) and then see how to proceed.

It's probably easy to rule out at least a few cases (within quotes, within curly braces) and not offer auto completion in that case.

"Reimplemeting parts of the parser in JS" sounds intense. In reality "open curly brace" and "in label value" is all we need, which is pretty simple.
Good motivation to think about HTTP endpoints for label stuff (we had some in the planning stage, IIRC).
I think the usability benefits of this feature exceed the required effort by several orders of magnitude.

Yeah, those were my thoughts when writing my last comment.

Later, add retrieving label names or even values.
Then add label completions in a similar approach as above.
Completing functions and aggregators would be great, too, but then it really evolves into a lot of parsing logic in the UI.

Sounds good.

What's your plan for this PR @juliusv?
I would really like to see this merged as current AC is mostly dysfunctional for serious expressions.

Me too. But before I jump again into more advanced JS parsing, I need a quiet weekend or something like that :) Soon[tm]!

@fabxc @beorn7 Turns out a quiet flight without internet was what I needed. Check this out now, it autocompletes really nicely only outside of strings or label matchers. I wrote this code on a plane in a sleep-deprived mode, but it seems to be working for me...

Sweet, works well for me :+1:
Next step would be auto-completing label names and values, which our API should provide for.
But this is the most important part.
How about getting rid of the "insert metric at cursor" button?

@fabxc Updated to remove the "Insert Metrics" selector.

@fabxc Are you on top of this or is my review required?

Ah, :+1: implied after removing that button :)

Wheeee!


AOT

Can this project be supported in native AOT?

@bodong1987

Can this project be supported in native AOT?

This project is just a combination of Avalonia's controls, so in theory if Avalonia supports it, this project will support it. It's just that I don't know much about native aot at the moment, and I don't know what I should do.


name in annotation shouldn't depends on following line.

In nni documents, it says name variable in nni.variable must be left variable of following line, and nni.functionchoice must be function name of right side. It doesn't make sense, and NNI can support annotation without name variable. The name variable should be used like display name in web ui only.

This is just the guarantee that the user annotate on the right line(or on the right variable).

This is just the guarantee that the user annotate on the right line(or on the right variable).

user know where to add the line is enough. NNI shouldn't to make it harder to use to validate something right.


Support override modifier

Closes #79

Will be released in the next version!

Hi @juanrgm, Thank you so much for your PR. Please respond to the notification here. https://github.com/trivago/prettier-plugin-sort-imports/discussions/118


Getting started "Tweak My Settings" resets the getting started page

Oh, weird. Previously the view state of getting started would be saved and restored on changing tabs but looks like that isn't happening anymore for some reason.

Oh, weird. Previously the view state of getting started would be saved and restored on changing tabs but looks like that isn't happening anymore for some reason.

This was in codespaces, maybe that's it (webview vs iframe)?

This was in codespaces, maybe that's it (webview vs iframe)?


Visible CollisionShape3D faces and random Color

edit : After lots of change https://github.com/godotengine/godot/pull/40123#issuecomment-655251208 better show the state of the PR
https://github.com/godotengine/godot-proposals/issues/906
It add a default color face to BoxShape3D, CapsuleShape3D, CylinderShape3D and SphereShape3D when used with CollisionShape3D.
Each instance can have custom color and texture to differentiate them to help gamedesigning bigger scene.

I still have thing TODO but not sure what fit the best for godot

[x] Default Color in EditorSettings
[x] Random Color
Miss other shapes
Random Color EditorSettings

I added random_color in the editor_settings, but when I try to get the value in the constructor to enable use_custom_color in the shape I have a mutex insult. It happen during the "docbase pass".
Any idea where I should check the editor value instead ?

The PR is ready on my side for the 4 shapes, it only miss one feature :

EditorSettings Random Color : If disabled on creation a shape will not use it's custom color (that is randomized on the constructor). But I can't use EDITOR_DEF on its constructor, I have mutex error during the doc generation phase. If anyone have an idea

Those should probably be wrapped inside #ifdef TOOLS_ENABLED sections, as there's no point having this code on release.

Those should probably be wrapped inside #ifdef TOOLS_ENABLED sections, as there's no point having this code on release.

Oh true, for the Shape parts I guess ?

Oh true, for the Shape parts I guess ? Gizmo are already tools ?

As far as I'm aware, yes. Anything within the "editor" folder is only compiled on editor builds already.

Oh true, for the Shape parts I guess ? Gizmo are already tools ?

As far as I'm aware, yes. Anything within the "editor" folder is only compiled on editor builds already.

Ok thank's, I didn't though about that. I'll do a little comit

Please amend the commits together: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

How does this behave when using Debug > Visible Collision shapes during gameplay?

How does this behave when using Debug > Visible Collision shapes during gameplay?

The behavior didn't changed for that part, I only added visibility inside CollisionShape3DGizmoPlugin

If I edit the get_debug_mesh and add the material creation directly inside shape it could be easly done

How does this behave when using Debug > Visible Collision shapes during gameplay?

The behavior didn't changed for that part, I only added visibility inside CollisionShape3DGizmoPlugin.
But it could be done if I add the mesh and material creation inside the shape directly and use it in get_debug_mesh()

In-editor and debug visible collision shapes should look the same imho.

Ok I added visible faces on runtime.

I will not squash the commit directly cause I want to have a bit of review on it cause i'm not sure if I did everything right

What is the use case for custom textures? I personally wouldn't find that useful for debugging, but custom colors do seem nice. I'm not against custom textures, I'm just curious why this was done.

In source engine there were texture for trigger and you could have different one for "death", "spawn", "ladder" etc...

Ok I have a big problem with that PR.
On release I remove the property added to the Shapes with DEBUG_ENABLED.
So when I try to export a game with collision shapes it instant crash because I guess godot try to load property that doesn't exist in the .tscn ? Is there a way to do Editor Only property ?
Thank's

There are a few things worrying me as well with this PR:

The intermediate class now exists for the sole purpose of editor debugging. It's also meaningless for a game or exported.
If the properties aren't properly stripped on export, a user setting up textures will end up with them being loaded in the final game, even if not used at all, which is a waste of resources.
Unless we consider it's fine, we may need better support for stripping editor-only features.

@Zylann Like you proposed in Discord, I could Give a random color on the shape in the gizmo plugin (to stay editor side, using it's ObjectID).
I would have used composition but I was not sure how to bind method using composition ?

I pushed a new version with random color based on ObjectID of the Shape and you can switch to a common color in the editor option.

Changing the common color need to restart the editor.
Disabling the "random color" need to trigger readraw() on the gizmo plugin, so selecting or other the shape.
At runtime it only show random color when Visible Collision Shape is enable. Should I add a parameters at godot launch like Visible Collision Shape do ?

OH MAN, MORE SOURCE ENGINE STYLE, HAMMER EDITOR CHANGES, I LOVE IT
hammer is such an easy to use tool, it's so stupid powerful, i'd love if the engine went towards the source engine's ease of use direction and easy of convenience

I feel the texture may be a bit much to be honest, but color could be ok.

@pouleyKetchoupp Hello, yeah I would still be interested finalizing this PR. But I don't have time for now until end of september (or at least can't promise anything).
I took note of the change you requested and thanks for these comment (also JFonS), if that PR is still needed after September, I will finalize it.
For the custom color per instance I'll try adding it too.

@Cold-0 Sounds good! No problem to wait until end of September.

When the "custom color" would be (re)added, when the collision node is
added, we add a random color and if the "use custom color" is check use it.
And maybe a config in the editor to allow the "use custom color" checked on
node creation ?
Le sam. 4 sept. 2021 à 00:51, Hugo Locurcio @.***> a
écrit :

@.**** commented on this pull request.
In editor/node_3d_editor_gizmos.cpp
https://github.com/godotengine/godot/pull/40123#discussion_r702190654:

@@ -3613,6 +3624,21 @@ void CollisionShape3DGizmoPlugin::redraw(EditorNode3DGizmo *p_gizmo) {
Vector handles;
handles.push_back(Vector3(r, 0, 0));
p_gizmo->add_handles(handles, handles_material);

// Visible Faces

if (EDITOR_DEF_RST("editors/3d_gizmos/collision_shape/show_faces", true)) {

	Ref<ArrayMesh> m = sp->get_debug_arraymesh_faces();

	if (EDITOR_DEF_RST("editors/3d_gizmos/collision_shape/random_color", true)) {

Should random colors even be kept in the first place? We don't use random
colors for raycasts or 2D collision shapes after all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/40123#discussion_r702190654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADTCYMMUKKIXW45T7GEJGTUAFGPXANCNFSM4OQRVMIA
.

Seems this PR was automatically closed because the author deleted their branch/entire fork. This is probably salvageable and given there has been plenty of activity on this PR, there is interest.

This needs to be salvaged.

What is the use case for custom textures? I personally wouldn't find that useful for debugging, but custom colors do seem nice. I'm not against custom textures, I'm just curious why this was done.

Regarding the use case for custom textures (or even a single texture for all shapes), one good reason to have them is that they give you spatial awareness, which a plain color doesn't. In short, seeing a textured pattern (even a checkerboard or grid) will give you a visual indicator of how far away the shape is from the camera (if it's a huge shape covering a large plane, for instance). This also helps to distinguish intersecting shapes of the same color if the outline isn't visible for some reason.
I'm putting this here in case someone is interested in salvaging this PR, although this can be implemented in a separate future PR.

This can also be done procedurally I think.
Color, Grid, Text, Can easly give these nice visual


Code completion popup

Fix for #57027. The issue was that _filter_code_completion_candidates_impl always resets the selected item. While up/down won't cause an update, there is a race condition where updating the list and then quickly changing selection will cause the selection to move and then reset. This can also happen even when the update doesn't actually change the list of options.
The fix here was to have _filter_code_completion_candidates_impl check to see if the new options list is the same up to the currently selected item. Then we only reset the selection if the list differs before the selection. That way if the list only changes after the selection we won't reset. If the list changes before our selection, then we still want to reset as the selected item may no longer be meaningful.
This is done by building a new list and then comparing. There is an increased memory footprint in that we must hold two lists while doing the update, but once we are done we discard the old list. There is also a time increase in that we need to perform the list comparison (copying over the new list should be the same as clearing the old list and building the new one like we did originally). Considering that this lists will typically be small the time and memory hit should be unnoticeable from a UX standpoint.
I also implemented it for the overridden version but I wasn't sure how to test that directly. But the tests for the non-overridden version should check the base logic. I am not 100% sure how this override system works so any notes and explanation would be appreciated.
I haven't squashed yet, but figured I was going to have to make some updates in the review anyway so will squash after the notes.

Thanks for your contribution. Please squash the commits as required by our pipeline (https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request)

I haven't squashed yet, but figured I was going to have to make some updates in the review anyway so will squash after the notes.

Yeah, that's fine. But when you do, please make sure to use a commit message that follows the project's style. The current title of this PR is a good option.

Squashed commits and addressed feedback

Addressed Feedback


typo: jsut -> just

@nschonni : Thanks for your contribution! The author, @, has been notified to review your proposed change.


OCI_BindArrayOfStrings memory corruption

When using this bind function to update DB in batch mode, the application crash is explored. The problem is in the OCI_StringUTF16ToUTF32, the input data is stored as UTF16, but the step is (index * size * sizeof(otext)), when ocilib compiled to use widechar the otext variable will be set to UTF32. For a little workaround you can look at this commit - https://github.com/stevemqeen/ocilib/commit/5c28fbbd1e1c715cf220090f7c2083d80038eccd

Hi,
Thanks for reporting issues.
I will commit a fix for it this evening and release v4.3.3 by the weekend.
Best regards,
Vincent


Motivations Part 3a

What other governing authorities are trusted to authorize which parties can perform what actions within their own trust registries.

authorize which parties can perform what actions within their own trust registries.

it really is to extend the members of this trust registry to their own trust registry for their own purposes.  This is one-way trust only. (two-way trust can be enabled with another entry in the other trust registry. In x.509, this is known as cross-certification.  This is the foundation of the web of trust.
<EMAIL_ADDRESS>to figure out what verbiage to add (if any).

comments from v1 draft - closing


Fix for spikeglx to repair #1246

#1246 have broken spikeinterface and neuroconv tests.
Here a fix that should be OK.

Does it make sense to add a test similar to the failing ones in SI & neuroconv?

Ok for now it seems to fix the downstream issues. @samuelgarcia Thanks for the fix


Test with PHP 7.3

This PR add PHP 7.3 to Travis config.

Coverage remained the same at 97.814% when pulling 45bd5e91a21eccbd14b611c21503290eb8930897 on tuupola:travis-php73 into c2177436410cebef3405e2010dea74ba51aa55f1 on slimphp:3.x.


Fix pyright errors

Updating pyright introduced a number of new error reports:

[x] geometry type error

https://github.com/timwie/aio-overpass/blob/868443de2958cc9353b31ee3bbf128d62a9d4298/aio_overpass/element.py#L237
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:351:5 - error: "geometry" overrides symbol of same name in class "Element"
    Variable is mutable so its type is invariant
      Override type "Point | None" is not the same as base type "BaseGeometry | None" (reportIncompatibleVariableOverride)
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:377:5 - error: "geometry" overrides symbol of same name in class "Element"
    Variable is mutable so its type is invariant
      Override type "LineString | LinearRing | Polygon | None" is not the same as base type "BaseGeometry | None" (reportIncompatibleVariableOverride)
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:416:5 - error: "geometry" overrides symbol of same name in class "Element"
    Variable is mutable so its type is invariant
      Override type "Polygon | MultiPolygon | None" is not the same as base type "BaseGeometry | None" (reportIncompatibleVariableOverride)

My intention with adding the geometry property to Element was to emulate an abstract property, that all the subclasses need to extend with some BaseGeometry. pyright is right to complain here though.

[ ] _try_validate_geometry() type errors

https://github.com/timwie/aio-overpass/blob/868443de2958cc9353b31ee3bbf128d62a9d4298/aio_overpass/element.py#L613-L651
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:623:49 - error: Argument of type "GeometrySequence[MultiPolygon*]*" cannot be assigned to parameter "geometries" of type "OptGeoArrayLike" in function "intersection_all"
    Type "GeometrySequence[MultiPolygon*]*" is incompatible with type "OptGeoArrayLike"
      "GeometrySequence[MultiPolygon*]*" is incompatible with "Geometry"
      "GeometrySequence[MultiPolygon*]*" is incompatible with "None"
      "GeometrySequence[MultiPolygon*]*" is incompatible with protocol "SupportsArray[dtype[Any]]"
        "__array__" is not present
      "GeometrySequence[MultiPolygon*]*" is incompatible with "Sequence[SupportsArray[dtype[Any]]]"
      "GeometrySequence[MultiPolygon*]*" is incompatible with "Sequence[Sequence[SupportsArray[dtype[Any]]]]"
      "GeometrySequence[MultiPolygon*]*" is incompatible with "Sequence[Sequence[Sequence[SupportsArray[dtype[Any]]]]]"
    ... (reportArgumentType)

  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:636:20 - error: Expression of type "GeometryDetails[Polygon]" is incompatible with return type "GeometryDetails[G@_try_validate_geometry]"
    "GeometryDetails[Polygon]" is incompatible with "GeometryDetails[G@_try_validate_geometry]"
      Type parameter "G@GeometryDetails" is invariant, but "Polygon" is not the same as "G@_try_validate_geometry" (reportReturnType)

  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:645:20 - error: Expression of type "GeometryDetails[MultiPolygon]" is incompatible with return type "GeometryDetails[G@_try_validate_geometry]"
    "GeometryDetails[MultiPolygon]" is incompatible with "GeometryDetails[G@_try_validate_geometry]"
      Type parameter "G@GeometryDetails" is invariant, but "MultiPolygon" is not the same as "G@_try_validate_geometry" (reportReturnType)

[ ] _try_validate_geometry() type errors

https://github.com/timwie/aio-overpass/blob/868443de2958cc9353b31ee3bbf128d62a9d4298/aio_overpass/element.py#L705-L711
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:709:27 - error: Argument of type "BaseGeometry" cannot be assigned to parameter "shell" of type "_PolygonShellLike" in function "__new__"
    Type "BaseGeometry" is incompatible with type "_PolygonShellLike"
      "BaseGeometry" is incompatible with "Polygon"
      "BaseGeometry" is incompatible with "LineString"
      "BaseGeometry" is incompatible with protocol "SupportsArray[dtype[Any]]"
        "__array__" is not present
      "BaseGeometry" is incompatible with "Sequence[SupportsArray[dtype[Any]]]"
      "BaseGeometry" is incompatible with "Sequence[Sequence[SupportsArray[dtype[Any]]]]"
      "BaseGeometry" is incompatible with "Sequence[Sequence[Sequence[SupportsArray[dtype[Any]]]]]"
    ... (reportArgumentType)
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:709:40 - error: Argument of type "list[BaseGeometry]" cannot be assigned to parameter "holes" of type "_PolygonHolesLike" in function "__new__" (reportArgumentType)

[ ] _geometry() type error
https://github.com/timwie/aio-overpass/blob/868443de2958cc9353b31ee3bbf128d62a9d4298/aio_overpass/element.py#L868

  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/element.py:868:34 - error: Argument of type "(lat: float, lon: float) -> tuple[float, float]" cannot be assigned to parameter "func" of type "(float, float, float | None) -> tuple[float, ...]" in function "transform"
    Type "(lat: float, lon: float) -> tuple[float, float]" is incompatible with type "(float, float, float | None) -> tuple[float, ...]"
      Function accepts too many positional parameters; expected 2 but received 3 (reportArgumentType)

[ ] OrderedRouteView.path type error

https://github.com/timwie/aio-overpass/blob/868443de2958cc9353b31ee3bbf128d62a9d4298/aio_overpass/pt_ordered.py#L216-L227
  /home/runner/work/aio-overpass/aio-overpass/aio_overpass/pt_ordered.py:225:53 - error: Expression of type "Generator[Iterator[LineString | None], None, None]" is incompatible with declared type "Iterator[Iterator[LineString]]"
    "Generator[Iterator[LineString | None], None, None]" is incompatible with "Iterator[Iterator[LineString]]"
      Type parameter "_T_co@Iterator" is covariant, but "Iterator[LineString | None]" is not a subtype of "Iterator[LineString]"
        "Iterator[LineString | None]" is incompatible with "Iterator[LineString]"
          Type parameter "_T_co@Iterator" is covariant, but "LineString | None" is not a subtype of "LineString"
            Type "LineString | None" is incompatible with type "LineString" (reportAssignmentType)

Removed pyright in 476773c. There's too many errors that are tricky to "fix" without resorting to ignore comments.


Create Sales Dashboard Project

This project is about sales data wherein the analysis focuses on calculating sales and y-o-y changes; showing sales and profit on a hex map; monthly sales by segment; and a sunburst chart showing category and sub-category sales

This project is about sales data wherein the analysis focuses on calculating sales and y-o-y changes; showing sales and profit on a hex map; monthly sales by segment; and a sunburst chart showing category and sub-category sales


Allow new roots to be specified on the command-line

We have the .factor-roots file and the FACTOR_ROOTS environment variable, but there is a use-case that would be nice to have roots specified on the command-line, something like:
factor -roots="~/foo:~/baz" blah.factor

See, for example the discussion here:
https://github.com/kanaka/mal/pull/98#issuecomment-152253257

There was also a question about whether we should have . (the current directory) always be a vocab-root, although I think maybe that would cause some confusion in the majority of long-term image-based use-cases.

Maybe . can be added as a vocab-root when factor is run with a script file as an argument?  That could prevent the confusion.  I also note that lots of languages have . in the path, like python, for example.

Great idea I think. The roots are set in the hook in vocabs.loader and that hook is stripped out when you deploy images. So adding . would only matter when you are using Factor in development mode.


decode-json + catch-object-exception + open-html  turns something into an error which is none

https://metafacture.org/playground/?flux=inputFile
|+open-file
|+as-lines
|+catch-object-exception+
|+open-http
|+as-records
|+decode-json
|+list-fix-values("type[]")
|+print
%3B
&data=https%3A//lobid.org/resources/1188059580.json
https%3A//lobid.org/resources/HT020467687.json
file content, first link provides no json but a Error message second does and is not broken:
https://lobid.org/resources/1188059580.json
https://lobid.org/resources/HT020467687.json

inputFile
| open-file
| as-lines
| catch-object-exception
| open-http
| as-records
| decode-json
| list-fix-values("type[]")
| print
;

When running it on the command line the following exception happens:
$ '/home/tobias/Downloads/metafix-runner-1.1.2/bin/metafix-runner' '/home/tobias/git/metafacture_workflows/rpbArticleRelatiedTypeInLobid/lobidTypeTesterForRpb.flux'
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/tobias/Downloads/metafix-runner-1.1.2/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/tobias/Downloads/metafix-runner-1.1.2/lib/slf4j-simple-1.7.21.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]
0    [main] ERROR .flowcontrol.ObjectExceptionCatcher  - 'com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'ERROR': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (String)"ERROR: "Not found:<PHONE_NUMBER>""; line: 1, column: 6]' while processing object: https://lobid.org/resources/1188059580.json
114  [main] ERROR .flowcontrol.ObjectExceptionCatcher  - 'com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'ERROR': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (String)"ERROR: "Not found:<PHONE_NUMBER>"{
  "@context" : "http://lobid.org/resources/context.jsonld",
  "id" : "http://lobid.org/resources/990366605490206441#!",
  "type" : [ "BibliographicResource", "Book" ],
  "medium" : [ {
    "label" : "Print",
    "id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
  } ],
  "title" : "Weinfreunde Marx & Engels",
  "almaMmsId" : "990366605490206441",
  "hbzId" : "HT020467687",
  "deprecatedUri" : "http://lobid.org/resources/HT020467687#!",
  "isbn" : ["[truncated 14186 chars]; line: 1, column: 6]' while processing object: https://lobid.org/resources/HT020467687.json
0       |

When only using the second link, the transformation works.

Ha, I moved the exception catcher in front of decode-json, then it works.
Could the exception catcher not properly end its job after open-http?


Multiple duplicate services are found on the Rockbot.

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[y ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Why duplicate service names are found on the Rockbot andthey don't have endpoints？

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking8.1.0，JRE1.8
Which company or project?

I think there are issues we discussed this. Please search before submitting a new one.


Disallow unknown json fields in payload

📝 Summary

⛱ Motivation and Context

📚 References

✅ I have run these commands

[ ] make lint
[ ] make test
[ ] make run-mergemock-integration
[ ] go mod tidy

Codecov Report

Merging #211 (fb434b7) into main (df5e354) will increase coverage by 0.34%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   72.16%   72.51%   +0.34%
==========================================
  Files           6        6
  Lines         636      644       +8
==========================================
+ Hits          459      467       +8
  Misses        151      151
  Partials       26       26

Flag
Coverage Δ

unittests
72.51% <81.81%> (+0.34%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/service.go
82.67% <0.00%> (ø)

server/mock_relay.go
85.81% <100.00%> (ø)

server/utils.go
66.66% <100.00%> (+5.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5e354...fb434b7. Read the comment docs.


Fix codegen output for object with indexer

Summary
The current implementation think {[key:T]:U} and {key:object} are the same type, which is semantically wrong.
This pull request fixes the problem and return {type:'GenericObjectTypeAnnotation'}, so that {[key:T]:U} is Object. The current schema cannot represent dictionary type, Object is the closest one.
The previous incorrect implementation actually bring in code with logic that doesn't make sense (treating indexer as property), those and related unit test are all undone.
Changelog
[General] [Changed] - Fix codegen output for object with indexer
Test Plan
yarn jest react-native-codegen passed

I fear this will conflict with https://github.com/facebook/react-native/pull/35098 and won't pass our internal builds as we rely on parsing indexed properties for (std::)map data structures in C++ TM.
I agree that mixing properties and indexed types is not ideal - but it was a cheap initial solution.
If we want to 'Fix codegen output for object with indexer' I would expect that this change:

splits properties and indexes apart
correctly parses them and exports them to the output

I don't think the current PR can be landed as it - as it simply removes existing logic.
For the current sample we would then output something as:
                  'typeAnnotation': {
                    'type': 'IndexedObjectTypeAnnotation',
                    'properties': [
                      {
                        'name': 'key',
                        'typeAnnotation': {
                          'type': 'GenericObjectTypeAnnotation'
                        }
                      }
                    ]

as we rely on parsing indexed properties for (std::)map data structures in C++ TM.

Hi @christophpurrer . As I mentioned in the description, the current behavior parses {[key:T]:U} exactly like {key:object}. I think this is a incorrect behavior, and you can't tell the difference between them, I don't really understand how will it be translated to a map instead of a struct with 'key'.
But @cipolleschi I think here is exactly a useful use case. I am totally fine if we could add a new type here. Otherwise, the only correct way will be treating it like an object, and code using std::map should just be reverted, because it relies on a bug.

as we rely on parsing indexed properties for (std::)map data structures in C++ TM.

Hi @christophpurrer . As I mentioned in the description, the current behavior parses {[key:T]:U} exactly like {key:object}. I think this is a incorrect behavior, and you can't tell the difference between them, I don't really understand how will it be translated to a map instead of a struct with 'key'.
But @cipolleschi I think here is exactly a useful use case. I am totally fine if we could add a new type here. Otherwise, the only correct way will be treating it like an object, and code using std::map should just be reverted, because it relies on a bug.

Totally agree we shouldn't treat index and property the same.
Ideally it would be great to still parse and emit the indexes to the parsed output - we already have the logic, we just need to stored them under indexes instead of properties > If not doing this here, do you want to send out a follow up PR for that work?
If we know the key type and value type of of indexed objects it makes it safer down the road when we convert them to std:map representation

@ZihanChen-MSFT  > What is your main motivation for this PR? Are you fixing an actual issue / bug on your side OR you 'just' want to make things semantically correct?

What is your main motivation for this PR?

in Microsoft/react-native-windows we have our backend too, the C++ codegen there will print the most detailed types we could find to improve type safety.
By having {[key:T]:U} be the same as {key:U}, it will generate a struct with a field key for a dictionary type, and make real fields missing in native world, it is a blocker for us.

/rebase

Unfortunately, things are breaking internally.
We have a bunch of
UnsupportedTypeAnnotationParserError: Module NativeFeliosSceneModule: Flow type annotation 'MixedTypeAnnotation' is unsupported in NativeModule specs
I think we should add some logging on which file is being parsed in case of errors 🤔
I cannot understand which module is actually emitting the error because is only see the name of the file that aggregates all the modules specs...

@cipolleschi https://flow.org/en/docs/types/mixed/ Looks like mixed, 'any' and Object all give no information about types but:

Object: Flow knows it is an Object (so it could not be undefined, but it could be null though).
'any': Flow would treat it as any type if needed.
'mixed': Flow assume it could be anything, but the type is unknown, no automatic conversion is performed.

So I will generate mixed as Object.


Fix code scanning alert - Comparison of narrow type with wide type in loop condition

Tracking issue for:

[ ] https://github.com/eProsima/Micro-XRCE-DDS-Client/security/code-scanning/1

This should be fixed with https://github.com/eProsima/Micro-XRCE-DDS-Client/pull/302


Getting the following error when I try to run the app

I'm getting the following error when I try to run the app with ionic serve

Yes, the node module for ionic changed and I missed the config. I pushed a fix. Good find.

Awesome, thank you!


SDL_CONTROLLER_BUTTON_RIGHTSHOULDER wrong button trigger, LEFTSTICK wrong button trigger and RIGHTSTICK does not trigger

It has to do with the mouse click also? Sometimes it spawns an enemy in the mouse pos without clicking

it was because of SDL dll's


ValueError: Error when checking target: expected conv2d_11 to have shape (16, 16, 1) but got array with shape (256, 256, 1)

i m training this model on rgb images and grayscale mask. I m getting this error. Can anyone help. Thanks

You need to reshape your images to the target size (256,256) or change the target size. You can try to use my fork and see if it works for you.


Mark touch and wheel event listeners as passive to improve scroll performance

Google PageSpeed Insights reports:
Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance.
https://web.dev/uses-passive-event-listeners/

Can you provide any logs to help determine where the problem listener(s) are? Most, if not all are already marked as passive.

Can you provide any logs to help determine where the problem listener(s) are? Most, if not all are already marked as passive.

PageSpeed Insights marks this location as the source of the problem in the minimized player:
plyr.min.js:1:3031

same question.source code position
{
key: "listeners",
value: function (e) {
var t = this,
n = e ? "addEventListener" : "removeEventListener";
["touchstart", "touchmove", "touchend"].forEach(function (e) {
t.element[n](e, function (e) {
return t.set(e);
}, !1);
});
}

This is caused by the rangetouch package, a utility package also by @sampotts which is used by plyr.
The source code for the compiled code in the comment above is at https://github.com/sampotts/rangetouch/blob/master/src/js/rangetouch.js#L131 and seems to register the problematic non-passive listeners.

I also get the error "Does not use passive listeners to improve scrolling performance" on Lighthouse. It marked the source as follows:
plyr.io
/3.7.8/plyr.js:1:3496(cdn.plyr.io)


Add a "why" blurb to each concept

Why is the call stack important? In what situations is it most useful? When and where? Stage of career? Application?
I would find it useful to have a short and clear blurb for each in the readme.

please assign this to me

can you please assign this issue to me

Hello,
I'm interested in contributing to this project and would like to work on this issue. Could you please assign it to me?
Thank you!
Div16s🙂


Find an API for for weather data

Preferably one that already is queryable in RDF/linked data. Otherwise, use RML.io to convert!

I found this API which provides weather daily forecast for up to 16 days in future, or hourly forecast for up to 4 days in the future:
https://openweathermap.org/api/hourly-forecast
I will check if the API is free to use as it's not clear (they say 1000 request free per day). The return type is JSON.

I got a key, but it's not active. On their website, it says it can take a few hours.... Greeeat.

I will try by the end of today to take the JSON response from one of these and convert it to RDF using the RML.io


Octave 4.0 PPA crashes when multiplying matrices

Greetings,
as reported in https://github.com/CoSMoMVPA/CoSMoMVPA/issues/33 and https://github.com/matlab2tikz/matlab2tikz/issues/745, a recent upgrade from GNU Octave 3.8 to 4.0 using a PPA on Ubuntu (https://launchpad.net/~octave/+archive/ubuntu/stable) by @mtmiller results in GNU Octave crashing on the travis-ci system. I observed crashes when evaluating simple expressions such as:
mtimes([1;2],[1,2])

which gives the following error when using the GNU Octave 4.0 PPA referenced above:
panic: Illegal instruction -- stopping myself...
attempting to save variables to 'octave-workspace'...
save to 'octave-workspace' complete
/home/travis/build.sh: line 41:  5843 Illegal instruction     $OCTAVE --eval "${TC}"

A full transcript from the travis system is here: https://travis-ci.org/nno/CoSMoMVPA/builds/78056101.
Note that I was unable to reproduce this on my laptop using the same Ubuntu version as used by travis running in virtualbox, or on a 64-core machine running Debian. On both machines the code runs fine.
Removing OpenBLAS (through apt-get purge libopenblas-base; changeset: https://github.com/nno/CoSMoMVPA/commit/d02d964a88912d33f66fd94944a9979933782410) fixes the issue; tests run fine again (https://travis-ci.org/nno/CoSMoMVPA/builds/78072774). This suggests that in certain circumstances the presence of OpenBLAS is related to GNU Octave crashing.
@mtmiller suggested to raise the issue here. If I can provide further assistance in tracking down the issue, fee free to contact / tag me.
Thanks for you consideration.

@nno , @mtmiller,
I think libopenblas-base of  Ubuntu 12.04 is very old. Is it possible to test OpenBLAS 0.2.14 or develop branch?
Xianyi

Good point, I hadn't noticed which release these failed builds were tracking. @nno was this illegal instruction error only ever seen on 12.04? If so then the right solution is probably for me to drop the recommendation on OpenBLAS for that specific backport.

@xianyi, It's not easy (at least for me) to test OpenBLAS 0.2.14 as I don't have direct access to the travis machines; I can only provide it with build configurations.
@mtmiller, I have not encountered the illegal instruction error before. It did not see it using Octave 3.8 on Ubuntu 12.04.
Thanks to both of you for the quick and helpful replies.

@nno I mean to ask, do you have any equivalent Travis jobs running on 14.04 without error, and this error only appears on 12.04. It seems to me this is the case, and I should simply drop OpenBLAS from the dependency list as it's too old.

@mtmiller: Travis only supports running jobs on 12.04 (http://docs.travis-ci.com/user/ci-environment/) at the moment.
Travis support for 14.04 has been asked for in March 2014 (https://github.com/travis-ci/travis-ci/issues/2046) and there is a milestone for it (https://github.com/travis-ci/travis-ci/milestones/Ubuntu 14.04 - Trusty Tahr). The milestone has currently six issues remaining.
Thus, it seems impossible to have equivalent Travis jobs on 14.04.

And @nno, I will have an update coming to the PPA soon that will drop the libopenblas-base dependency in favor of ATLAS for 12.04. If/when you get Travis builds on 14.04, OpenBLAS should work much better there.

Very good @mtmiller, thanks for your support.

It's not the absolute latest version, but we have a more recent version of openblas available in a ppa at https://launchpad.net/~staticfloat/+archive/ubuntu/julia-deps/ that you might be able to use.

The abovementioned travis milestone for Ubuntu 14.04LTS support appears to have been completed
in march of this year, so assuming all is well (and has been for some time)


arcz/indentation

From https://github.com/arcz
Found with the compilation warning:
[143/260] Building CXX object CMakeFiles/lib3mf.dir/Source/Model/Reader/NMR_ModelReaderNode.cpp.o.cpp.oeamLattice1702_Ref.cpp.o.o
../Source/Model/Reader/NMR_ModelReaderNode.cpp: In member function 'void NMR::CModelReaderNode::parseContent(NMR::CXmlReader*)':
../Source/Model/Reader/NMR_ModelReaderNode.cpp:175:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  175 |     if (!pszNameSpaceURI)
      |     ^~
../Source/Model/Reader/NMR_ModelReaderNode.cpp:178:6: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  178 |      if (nCount > 0) {
      |      ^~

Thanks @arcz .


A random crash

Describe the bug
The game crashed randomly after chopping down a tree (menril tree from integrated dynamics). It occured once so far so I don't know if the crash if that was the exact cause of the crash but I've just started out and was chopping trees. I've chopped and replanted a vanilla oak tree, a sun tree from primal magick mod and chopped down without replanting a menril tree from integrated dynamics. The crash log claims it is caused by the beaver familiar tree finding, however I had no chance to get any familiars yet (it occurred literally during the first wood chopping from entering a new world). Upon relogging the game world was fine and no further crashes occurred (as of yet). I am attaching the crash report and the log file in case it is helpful.
To Reproduce
Steps to reproduce the behavior:
I was unable to reproduce it.
Expected behavior
Not crashing.
Screenshots
If applicable, add screenshots to help explain your problem.
System (please complete the following information):

Occultism Version: occultism-1.18.1-1.26.0
OS: Windows 10
Minecraft Version: 1.18.1
Modpack Link and Version, or list of mods:
Custom mod pack with mod list contained within the crash report.

Additional context
Add any other context about the problem here.
crash-2022-02-01_20.25.42-server.txt
2022-02-01-5.log
Edit: I should've checked that it was just reported. Sorry for the second report.

Thanks for reporting!
Duplicate of #641, handling there


Remove werkzeug dep & limit protobuf to 3.20.0

Since https://github.com/maxcountryman/flask-login/issues/686 is fixed and Airflow 2.4 (alpha at the moment) won't need it, we are good to remove it from our setup.cfg
We will release 1.8.1 since this PR is merged in https://github.com/astronomer/astronomer-providers/pull/614
This PR also limits protobuf to <=3.20.0  # Bigquery provider isn't compatible with it. Details in https://github.com/apache/airflow/commit/25a9ae3b2eec85dfd500b0a921045fc95ab8ffd6 and https://github.com/astronomer/astro-sdk/commit/d6911b3df322c5f029b8b7a555036c8944188255

I merged it with broken mypy so that I could fix it in the following PR so we can release 1.8.1


AP-815-SPIKE

What
Link to story
Describe what you did and why.
Checklist
Before you ask people to review this PR:

[ ] Tests and rubocop should be passing: bundle exec rake
[ ] Github should not be reporting conflicts; you should have recently run git rebase master.
[ ] There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
[ ] The PR description should say what you changed and why, with a link to the JIRA story.
[ ] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

This code is fine as far as it goes, but the hard part of searching is not the isolation of matching records, but the ordering by relevance.

I agree.  But this does the search to the extent as required in the ticket.  The ordering of the rows is already taken care of by sorting.  A more comprehensive search that re-sorted the results would need more code and all the complexity therein.

It's amazing what a bit of sleep can do. I've just remember something - we are already using a JavaScript search library (JsSearch) - see app/javascript/src/modules/proceedings.js.

A decision was made to implement this in the back-end, not front-end, so closing this PR.


Unable to build on Windows

When i tried running make command, I am getting the following error.
CMake Error at CMakeLists.txt:25 (find_package):
By not providing "FindSDL2.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "SDL2", but
CMake did not find one.
Could not find a package configuration file provided by "SDL2" with any of
the following names:
SDL2Config.cmake
sdl2-config.cmake

Add the installation prefix of "SDL2" to CMAKE_PREFIX_PATH or set
"SDL2_DIR" to a directory containing one of the above files.  If "SDL2"
provides a separate development package or SDK, be sure it has been
installed.

@sparkskapil I haven't tried building this on Windows except within WSL. That said, it looks from the error you're getting as though you don't have SDL installed. SDL is listed as a requirement in the README.
Are you trying to build this within WSL? If you, you can install SDL via apt. If you're building in some other way, you might be able to use this page to install SDL.
If you have SDL installed already, CMake may not be able to find the file that it provides - you may need to follow the error's suggestion and point CMAKE_PREFIX_PATH at your SDL installation so it can be detected.

@sparkskapil I'm going to close this for now as I hope I've provided a solution to your issue. If you are still experiencing difficulties, please feel free to re-open with some more details.


Upgrade orchestra/testbench to 4.x

Upgrade orchestra/testbench to 4.x so this is compatible with Laravel 6.x

@muglug Hi! Any update with this PR? Thanks!

Sorry! Update is, it’s merged

Great! Thank you :)
Can't wait for the next release 👍

There's a new release!


Make NGINX port configurable

In file /var/lib/dokku-alt/plugins/nginx-vhosts/post-deploy, the port that NGINX listens on is hard-wired
  cat<<EOF
server {
  listen      $DOKKU_LISTEN_IPV6:80;
  listen      $DOKKU_LISTEN_IPV4:80;
  server_name $@;
  return 301 $WHERE;
}
EOF

In our configuration, we run NGINX on port 80 behind VARNISH, which in turn serves port 80.
Therefore, I would like to make the port that NGINX listens on variable. A potential place would be /home/dokku/dokkurc which is sourced in /usr/local/bin/dokku.

I have created a pull request.

I have a similar request.
However, I believe it would be more natural to extract the port number from the HOSTNAME.
For instance:
$ dokku domain:set app hokku.me:82
Would, in the post-deploy replace 80 (the default port) by 82 or any other port.


Stages are doing significant work before they are executed

BPZ, FlowEngine, and possibly other stages are currently doing significant work when they are instantiated, instead of waiting for when they are run.
FlowEngine does this:
Inserting handle into data store.  flow: data/example/inputs/example_flow.pkl, FlowEngine

BPZ does this:
  Generating new AB file El_B2004a.DC2LSST_u.AB....
El_B2004a DC2LSST_u
x_res[0] 3000.0
x_res[-1] 11500.0
Writing AB file  /Users/jzuntz/src/lsst/TXPipe/conda/lib/python3.9/site-packages/examples/estimation/data/AB/El_B2004a.DC2LSST_u.AB
and lots more

This only happens the first time, but it would still be nice to move it later or include the data files in the package, maybe. The directory they are currently being written to is the one I mentioned just now in LSSTDESC/RAIL#238

I'm going to audit all of the rail subpackages that have subclasses of the RAIL stages looking for any that are doing substantial work in the __init__ methods. If I find any, I'll create an issue in the corresponding repository and will link to those issues here as well.

The only stage that I found that seemed like it might be doing extraneous work in the __init__ method was the following:

https://github.com/LSSTDESC/rail_pzflow/blob/main/src/rail/creation/engines/flowEngine.py

Created issue: https://github.com/LSSTDESC/rail_pzflow/issues/8 to track it.

For those of you following this issue, given that we've audited the subclasses and created follow up issues as needed. Can we close this issue out now? If there is still work to be done, or thoughts to be had on this one, I would recommend closing it anyway, and opening a new issue to track the new work.

I think I'd like to keep it open just until the subclass issues are resolved, if that's okay.


Added priority queue using STL

Description of Change
Added priority queue using STL
Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

The formatter is so bizzarre. Why does it throw this error? Isn't this std lib?
/home/runner/work/C-Plus-Plus/C-Plus-Plus/data_structures/priority_queue.h:12:10: error: 'cassert' file not found [clang-diagnostic-error]
#include <cassert>
         ^

Appreciate if someone can explain || help me with this.
The formatter is so bizzarre to me. Why does it throw this error? Isn't this std lib?
/home/runner/work/C-Plus-Plus/C-Plus-Plus/data_structures/priority_queue.h:12:10: error: 'cassert' file not found [clang-diagnostic-error]
#include <cassert>
         ^

The file's format shall be .hpp if you're using the C++ language.
For the C language, you must use .h format.

Appreciate if someone can explain || help me with this.
The formatter is so bizzarre to me. Why does it throw this error? Isn't this std lib?
/home/runner/work/C-Plus-Plus/C-Plus-Plus/data_structures/priority_queue.h:12:10: error: 'cassert' file not found [clang-diagnostic-error]
#include <cassert>
         ^

The file's format shall be .hpp if you're using the C++ language.
For the C language, you must use .h fo

Appreciate if someone can explain || help me with this.
The formatter is so bizzarre to me. Why does it throw this error? Isn't this std lib?
/home/runner/work/C-Plus-Plus/C-Plus-Plus/data_structures/priority_queue.h:12:10: error: 'cassert' file not found [clang-diagnostic-error]
#include <cassert>
         ^

The file's format shall be .hpp if you're using the C++ language.
For the C language, you must use .h format.

Oops. Tyvm. Just updated.

The formatting fails due to outdated code of avltree.cpp which I did only change NUL to nullptr. The PriorityQueue should have passed clang-tidy checks


PERMISSION doesn't work with selecting a single id

I'm using the permissions feature like
DEFINE TABLE media SCHEMALESS
PERMISSIONS
  FOR select, update, delete WHERE user_email = $auth.email,
  FOR create NONE;
;

I can correctly select all media with this
  let media = await db.select("media");

however selecting a particular media that exists fails
  let medium = await db.select(`${params.id}`);

RecordError: Record not found: media:01GR6XTHC4ASPSW4VQ00KN2ME1

even though that record is included in the all media selected.
For now I can just get all media and filter by id with js as a workaround. Maybe I misunderstood something, but I expected this to work.
Let me know if anything
(I'm running surrealdb from latest master commit and using the latest released version of the js lib).

Duplicated of #43 . This comment might help.

It doesnt look like a duplicate, the id exists here, the permission system doesnt allow to return it. Let me know if i misunderstood

It doesnt look like a duplicate, the id exists here, the permission system doesnt allow to return it. Let me know if i misunderstood

Use .query() instead.

I assume that you were using the nightly version of surrealdb there? This should be good in the next release. Thanks!


Can't navigate when layout has more than one island

See https://github.com/adamzerner/nav-issue-demo for reproduction.
First I created a new Fresh project. Then I set up a _layout.tsx file like so:
import { LayoutProps } from "$fresh/server.ts";
import { Foo } from "../islands/foo.tsx";
import { Bar } from "../islands/bar.tsx";

export default ({ Component }: LayoutProps) => {
  return (

      <Foo />
      <Bar />
      <Component />

  );
};

Where Foo and Bar are the following (no JavaScript):
export const Foo = () => {
  return
Foo
;
};

and
export const Bar = () => {
  return
Bar
;
};

Then, in routes/_index.tsx, I added Greet Alice. If I remove <Bar />, the link works. But with both <Foo /> and <Bar /> in the layout, it does not.

Hey @adamzerner, thanks for including a reproduction repo -- that's really great. Unfortunately I can't seem to reproduce the issue! I click the link and see:
Foo
Bar
Hello alice

What does deno --version say for you? I get:
deno 1.37.2 (release, x86_64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.2.2

@deer Thanks!
Sorry about the issues reproducing. I just tried rm -rfing the repo locally and then git cloneing to see if I could reproduce it after a git clone. I have had weird, inconsistent results that I'm still trying to pinpoint. For the time being, if you try some combination restarting your dev server a few times, refreshing the page, and navigating back in the browser after hitting http://localhost:8000/greet/alice, do you ever run into it?
code/nav-issue-demo [master] » deno --version
deno 1.37.2 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.2.2

Hm, actually this seems to be a way to reproduce it. In short, after cloning, start the dev server, don't visit the site, kill the dev server, start the dev server again, visit the site, try clicking the link, and it won't work.
~/code » rm -rf nav-issue-demo
~/code » git clone git@github.com:adamzerner/nav-issue-demo.git
Cloning into 'nav-issue-demo'...
remote: Enumerating objects: 37, done.
remote: Counting objects: 100% (37/37), done.
remote: Compressing objects: 100% (29/29), done.
remote: Total 37 (delta 4), reused 37 (delta 4), pack-reused 0
Receiving objects: 100% (37/37), 11.65 KiB | 2.33 MiB/s, done.
Resolving deltas: 100% (4/4), done.
~/code » cd nav-issue-demo
code/nav-issue-demo [master] » deno task start
Task start deno run -A --watch=static/,routes/ dev.ts
Watcher Process started.
The manifest has been generated for 6 routes and 3 islands.

 🍋 Fresh ready
    Local: http://localhost:8000/

^C
code/nav-issue-demo [master] » deno task start
Task start deno run -A --watch=static/,routes/ dev.ts
Watcher Process started.
The manifest has been generated for 6 routes and 3 islands.

 🍋 Fresh ready
    Local: http://localhost:8000/
Watcher File change detected! Restarting!

 🍋 Fresh ready
    Local: http://localhost:8000/

Sadly I still can't reproduce it. I did try refreshing and restarting in various combinations as well as your suggested order.

@adamzerner Are there any errors printed in the browser console or the network tab?

Hm, I think it might be specific to Firefox. I'm able to reproduce it in Firefox but not Chrome or Safari. I'm on the latest versions of Firefox, Chrome and Safari. 119.0, 119.0.6045.105, and 17.1 respectively.
I know "it works on my machine" isn't really valid, but for what it's worth, here's a gif of it happening for me:

Are there any errors printed in the browser console or the network tab?

I see this in my browser console:
TypeError: a.default.detectStore(...) is undefined
[h1-check.js:1:1301](moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js)
    u moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js:1
    1337 moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js:1
    n moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js:1
    <anonymous> moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js:1
    <anonymous> moz-extension://278d97d8-a3f5-4940-a634-8dff07648ead/h1-check.js:1
    inject resource://gre/modules/ExtensionContent.sys.mjs:581
    AsyncFunctionNext self-hosted:852
 Fresh  Connected to development server.

And nothing in my server console:
Watcher File change detected! Restarting!

 🍋 Fresh ready
    Local: http://localhost:8000/

I have the same issue, it only happens on firefox with deno task start.
I can reproduce it with

create a project deno run -A -r https://fresh.deno.dev
run deno task start
go to http://localhost:8000/
change the url to http://localhost:8000/greet/john -> it sends you back to http://localhost:8000/
remove  <Counter count={count} />
change the url to http://localhost:8000/greet/john -> it works

Note: after removing Counter, the page doesn't refresh when changing it. That happens also on chrome.
In my private project, I don't use islands yet but the navigation is broken too. I see that in the terminal the right page is called but then it goes back

I tried the steps in Firefox, but I'm unable to reproduce the described issue. Tried on macOS + windows with latest Firefox.

Note: after removing Counter, the page doesn't refresh when changing it. That happens also on chrome.
This part is already fixed in main, see https://github.com/denoland/fresh/pull/1956

I tried the steps in Firefox, but I'm unable to reproduce the described issue. Tried on macOS + windows with latest Firefox.

I should have said that I use Ubuntu (linux Mint)

Note: after removing Counter, the page doesn't refresh when changing it. That happens also on chrome.

This part is already fixed in main, see #1956

Nice! But it seams that it was not released yet. Last release was 3 weeks ago (1.5.2). The fix is 2 weeks ago.
Also I checked the latest Fresh version out, everything looks like it works there.

Not sure what changed, but I'm able to reproduce it now. Investigating...


Stacks and queue

[x] Top-level README “Table of Contents” is updated
[x] Feature tasks for this challenge are completed
[x] Unit tests written and passing

[x] “Happy Path” - Expected outcome
[x] Expected failure
[x] Edge Case (if applicable/obvious)

[x] README for this challenge is complete

[x] Summary, Description, Approach & Efficiency, Solution
[x] Link to code
[x] Picture of whiteboard

Fixed lint errors in Queue constructor and test file
Dequeue is returning a value
Enqueue refactored to be 0(1)
Pop is returning a value


Additional setup to enable running on mac

Hello. Could you add README about setup on MAC with new h3 tag?
for example,
MAC OS SetUP
here to add your comment

sure, i will send a new PR with this change :)


Added Fiserv Logo

Signed-off-by: SaimSonu<EMAIL_ADDRESS>Description
Added Fiserv Logo to Contributors Section
This PR fixes #171
Signed commits

[x] Yes, I signed my commits.

Looks good @BondaSaim 👌🏼

Looks good @BondaSaim 👌🏼

Thank you @Nikhil-Ladha

Nice! Thanks for taking these on, @BondaSaim. You're most welcome to join the Layer5 Community (https://layer5.io/community). There is a Newcomers call each Thursday that is very welcoming.


ARTEMIS-2664 Fix the credits acquiring.

Move acquireCredit outside the deliveredAcks update function, since it may be
re-applied when attempted updates fail.

@franz1981 are you merging then?


netcdf-cxx4: during tests, use netcdf's installed plugins

Description of changes

Install plugins in netcdf's build
Set the plugin path so we can use them in netcdf-cxx4's tests, which rely on the bzip2 plugin existing

Resolves #218456
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 218675 run on x86_64-linux 1

4 packages marked as broken and skipped:

ezminc
python310Packages.rlax
python310Packages.worldengine
python311Packages.worldengine

11 packages failed to build:

gplates
mapcache
mysql-workbench
perl534Packages.Tirex
perl536Packages.Tirex
python310Packages.arviz
python310Packages.pymc
python310Packages.sunpy
python311Packages.plotnine
python311Packages.python-mapnik
t-rex

85 packages built:

EBTKS
apacheHttpdPackages.mod_tile
bicgl
bicpl
cdo
cloudcompare
conglomerate
eccodes
entwine
gdal (python310Packages.gdal)
gmt
gnudatalanguage
grass
inormalize
libLAS
libminc
mapnik
mapproxy
mapserver
merkaartor
minc_tools
minc_widgets
mni_autoreg
n3
nco
ncview
netcdf
netcdf-mpi
netcdfcxx4
netcdffortran
octavePackages.ncarray
octavePackages.netcdf
octopus
oobicpl
openorienteering-mapper
ovito
paraview
pdal
postgresql11Packages.postgis
postgresql12Packages.postgis
postgresql13Packages.postgis
postgresql14Packages.postgis
postgresql15Packages.postgis
pymol
python310Packages.boltztrap2
python310Packages.bsuite
python310Packages.cartopy
python310Packages.datashader
python310Packages.eccodes
python310Packages.fiona
python310Packages.folium
python310Packages.geopandas
python310Packages.h5netcdf
python310Packages.meshio
python310Packages.netcdf4
python310Packages.osmnx
python310Packages.plotnine
python310Packages.pygmt
python310Packages.python-mapnik
python310Packages.rasterio
python310Packages.sfepy
python310Packages.wktutils
python310Packages.wrf-python
python311Packages.boltztrap2
python311Packages.cartopy
python311Packages.eccodes
python311Packages.fiona
python311Packages.folium
python311Packages.gdal
python311Packages.geopandas
python311Packages.h5netcdf
python311Packages.meshio
python311Packages.netcdf4
python311Packages.osmnx
python311Packages.pygmt
python311Packages.rasterio
python311Packages.wktutils
python311Packages.wrf-python
pytrainer
qgis
qgis-ltr
qmapshack
saga
sumo
udig

@ofborg build netcdf-cxx4 netcdf nco