Add default credentials and stop keep tracking of user credentials

Git was still looking for changes to .env and spotiplot.env, which could end up resulting in the user commiting its credentials.
Renaming the files to default... should prevent this from happening, as the credentials are listed in the .gitignore file.
Fix #30

Should modify the README to make instructions more clear


feat: Add new keyword to check max length based on space type

This will add a new keyword
maxLengthWithSpaceType to allow higher body length limit to turbo spaces
"maxLengthWithSpaceType": {
  "default": 10000,
  "turbo": 20000
}

so on sequencer or UI while calling validateSchema we can pass a new param spaceType which can be default by default or if we pass turbo max length will be 20000
How to test:

Run yarn test and Try passing bigger body to proposal.json
and try adding spaceType to test/schema.spec.ts

const isValid = validateSchema(schema, example, {
  snapshotEnv: 'mainnet',
  spaceType: 'turbo'
});

We will need to allow more voting strategies too for Turbo spaces

We will need to allow more voting strategies too for Turbo spaces

Yes will create a new PR if we agree on the concept of adding new keyword like here
follow status here https://discord.com/channels/955773041898573854/1187284357799481484/1187287152426504282


wrong result if "}" included

I want to parse the following js object:
{hello: function() {console.log('hi');}}

For that I use chompjs like that
from chompjs import parse_js_object
parse_js_object("{hello: function() {console.log('hi');}}")

The result:
{'hello': "function() {console.log('hi');"}

but it should be:
{'hello': "function() {console.log('hi');}"}

Could it be that the parser stops at the first closing curly bracket?

For now chompjs doesn't work's well with functions. For example it will break if a function has arguments:
>>> chompjs.parse_js_object("{test: function(a, b, c){} }")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mariusz/Documents/Praca/venv/lib/python3.8/site-packages/chompjs/chompjs.py", line 29, in parse_js_object
    raise ValueError("Parser error: ... {}".format(str(exception).encode('utf-8')))
ValueError: Parser error: ... b' c){} }'

I have an update in mind that should solve both this and reported problem.

For now chompjs doesn't work's well with functions. For example it will break if a function has arguments:
>>> chompjs.parse_js_object("{test: function(a, b, c){} }")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mariusz/Documents/Praca/venv/lib/python3.8/site-packages/chompjs/chompjs.py", line 29, in parse_js_object
    raise ValueError("Parser error: ... {}".format(str(exception).encode('utf-8')))
ValueError: Parser error: ... b' c){} }'

I have an update in mind that should solve both this and reported problem.

I found a solution in which I doubled all quotes and passed all JavaScript Functions/ Specials as a String to python, because i did not need to change them. My implementation is like this. It is a messy workaround but works

I found a solution in which I doubled all quotes and passed all JavaScript Functions/ Specials as a String to python, because i did not need to change them. My implementation is like this. It is a messy workaround but works

Since version 1.1.1 chompjs can handle JavaScript functions:
>>> import chompjs
>>> chompjs.parse_js_object("{hello: function() {console.log('hi');}}")
{'hello': "function() {console.log('hi');}"}
>>> chompjs.parse_js_object("{test: function(a, b, c){} }")
{'test': 'function(a, b, c){} '}


[Bug] Composition layer variables are overwritten by variable with the same name

cookie-composer version: 0.10.3
Python version: 3.11.2
Operating System: MacOS - 13.4.1

Description
I have a composition template layers file with two different sources that have variables with same name, but different values (the repo in the issue doesn't exist, as my repo is a private one that can't be accessed directly)
---
template: "https://gitlab.com/cookie-composer-modules"
directory: "gcp/cloud_function"
context:
  project_name: My awesome project
  service_name: backend
  runtime: python:3.11
---
template: "https://gitlab.com/cookie-composer-modules"
directory: "gcp/gae"
context:
  project_name: My awesome project
  service_name: frontend
  runtime: nodejs:20

But what happens is that the second context is overwritten by the first one, no matter what.
The output of the .composition.yaml is as it follows :
---
checkout: null
commit: xxxxxxxxxxxxxxxx
context:
  __project_slug: my_awesome_project
  __service_slug: backend
  project_name: My awesome project
  runtime: python:3.11
  service_name: backend
directory: gcp/cloud_function
merge_strategies:
  '*': do-not-merge
no_input: true
overwrite: []
overwrite_exclude: []
password: null
skip_generation: []
skip_hooks: false
skip_if_file_exists: false
template: https://gitlab.com/cookie-composer-modules
---
checkout: null
commit: xxxxxxxxxxxxxxxx
context:
  __project_slug: my_awesome_project
  __service_slug: backend
  project_name: My awesome project
  runtime: python:3.11
  service_name: backend
directory: gcp/gae
merge_strategies:
  '*': do-not-merge
no_input: true
overwrite: []
overwrite_exclude: []
password: null
skip_generation: []
skip_hooks: false
skip_if_file_exists: false
template: https://gitlab.com/cookie-composer-modules

The expected output would be that the first template use the first context and the second template the second one.

I'll look into it this weekend

@MathRdt I have a branch and PR that should fix the issue. Are you able to install cookie composer from the branch and test your use case?


Adding FAQ section

Want to add a faq section on the landing page.
please assign it under jwoc

Add all the things like faq, quiz, etc below the footer in this format  ..

I am not able to locate the footer exactly. can you share ss where exactly you want me to create it.

i want it in the home page itself..

Okayy

Please check discord.

check discord !! @nisha331


GitHub Desktop App? 💭

@davcsj asked about GitHub Desktop App: https://github.com/apps/desktop

Having used git & GitHub since loooong before the App was released,
I haven't used it much ... but perhaps I should and try to summarise how it's useful. 💭

Crucially: is it useful to a beginner? Or a distraction?
i.e. are beginners better off just using the command line for the 6 commands they need
and only installing the Desktop App when they need something more advanced? 🤷♂

I have some gnarly merge-conflicts in a work project right now so considering diving into this.
I've always done merge-conflict resolution manually via cli in the past ... 💻 ⏳

Personally, I don't have it. Although I have it on my iPad but it is only used secured login credentials. I do not even use git much. Went back to old style backups. much more my style. I use github for stars.


Fix the inaccurate expired time of MOB HFiles

MOB HFiles are expired earlier than their reference data

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
branch-2.5 passed

+1 :green_heart:
compile
2m 22s
branch-2.5 passed

+1 :green_heart:
checkstyle
0m 33s
branch-2.5 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 21s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
2m 21s
the patch passed

+1 :green_heart:
javac
2m 21s
the patch passed

-0 :warning:
checkstyle
0m 33s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 31s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.

-1 :x:
spotless
0m 33s
patch has 23 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

32m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 27a6be0765a8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 59s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
branch-2.5 passed

+1 :green_heart:
compile
0m 42s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
shadedjars
4m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
213m 50s
hbase-server in the patch failed.

238m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 638e3c1ed2f0 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/testReport/

Max. process+thread count
4026 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
branch-2.5 passed

+1 :green_heart:
compile
0m 52s
branch-2.5 passed

+1 :green_heart:
shadedjars
6m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
230m 21s
hbase-server in the patch passed.

258m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f19950c791fe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/testReport/

Max. process+thread count
4256 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 32s
branch-2.5 passed

+1 :green_heart:
compile
2m 24s
branch-2.5 passed

+1 :green_heart:
checkstyle
0m 33s
branch-2.5 passed

+1 :green_heart:
spotless
0m 38s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 19s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
2m 21s
the patch passed

+1 :green_heart:
javac
2m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 47s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  8s
The patch does not generate ASF License warnings.

30m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 02ae0bc6d794 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 53s
branch-2.5 passed

+1 :green_heart:
compile
0m 43s
branch-2.5 passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
shadedjars
5m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
188m  3s
hbase-server in the patch passed.

210m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f1e7aacd395c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/testReport/

Max. process+thread count
4376 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 12s
branch-2.5 passed

+1 :green_heart:
compile
0m 41s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
shadedjars
4m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

-1 :x:
unit
214m  5s
hbase-server in the patch failed.

235m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5597

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux db6a4bd1151e 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / fbc7a27583

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/testReport/

Max. process+thread count
3927 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5597/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Please open a PR against master branch first? In HBase, we first fix something in master branch and then cherry-pick to other branches.
Thanks.


README: Add link to discussion group

Add a link to the discussion group so people know where to ask
questions.  This wasn't immediately apparent to me.
Debated putting it under documentation, but felt weird.

Hi Kyle,
Documentation would be a better section for it than Library development. :) Could you move it? I'll merge the PR then.
Thanks!

Updated.


Edge smoothing causes blank spots with large images

I have an 88560px square image (viewable at http://chrisjordan.com/gallery/epu/#e-pluribus-unum, though you won't see this issue there), and when I zoomed in to twice 1:1 resolution, the edge smoothing introduced with #764 caused tiles to partially draw. I believe this is due to rounding errors.
Here is a screenshot...the grey areas are the background showing through.

If I use smoothTileEdgesMinZoom: Infinity I don't get this artifact.
Here is the repro code (meant to go into /test/demo/basic.html in this repository):
    var tileSource = {
        "Image": {
            "xmlns": "http://schemas.microsoft.com/deepzoom/2008",
            "Url": "http://chrisjordan.com/dzi/e-pluribus-unum_files/",
            "Format": "png",
            "Overlap": "1",
            "TileSize": "254",
            "Size": {
                "Height": "88560",
                "Width": "88560"
            }
        }
    };

    var viewer = OpenSeadragon({
        debugMode: true,
        id: "contentDiv",
        prefixUrl: "../../build/openseadragon/images/",
        tileSources: tileSource
    });

    viewer.addHandler('open', function() {
        var containerWidth = $('#contentDiv').width();
        var maxZoom = (tileSource.Image.Size.Width / (containerWidth * 0.5));
        viewer.viewport.panTo(new OpenSeadragon.Point(0.5, 0.75), true);
        viewer.viewport.zoomTo(maxZoom, null, true);
    });

@mindfreeze any thoughts?

Tried this and it looks a lot like the issues I had when trying to fix rotation and edge smoothing to work together. @avandecreme was the one that finally cracked it so maybe he will be of more help here.

I submitted a PR. It was easier than I feared :)

Yeah, nice catch!


Avoid localizing nuspec and NuGet MSBuild properties

Fixes https://github.com/NuGet/docs.microsoft.com-nuget/issues/2006

Adds some global no-loc terms
Uses inline code blocks in .nuspec properties and in MSBuild properties for NuGet pack and restore targets.
Minor proofreading

@Mikejo5000 Any thoughts why this isn't working? We tried closing/opening the PR

@JonDouglas There is a general outage in for all builds on docs.microsoft.com. They are working to escalate the issue.

@JonDouglas Still no ETA on the fix, but you're not alone!

@Mikejo5000 Is there anything I can help? Any update on the outage?

@dominoFire @JonDouglas Hi, no workarounds for it, and unfortunately no updates yet. I know they are working hard to resolve the issue.

Docs Build status updates of commit e70a68e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:warning:Warning
View
Details

docs/reference/msbuild-targets.md

Line 110, Column 232: [Warning-bookmark-not-found] Cannot find bookmark '#packing-using-a-nuspec' in 'reference/msbuild-targets.md', did you mean '#packing-using-a--file'?
Line 111, Column 82: [Warning-bookmark-not-found] Cannot find bookmark '#packing-using-a-nuspec' in 'reference/msbuild-targets.md', did you mean '#packing-using-a--file'?
Line 112, Column 95: [Warning-bookmark-not-found] Cannot find bookmark '#packing-using-a-nuspec' in 'reference/msbuild-targets.md', did you mean '#packing-using-a--file'?
Line 388, Column 26: [Warning-bookmark-not-found] Cannot find bookmark '#restoring-packagereference-and-packagesconfig-with-msbuild' in 'reference/msbuild-targets.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JonDouglas If any PRs are still not building properly, try to close and re-open.

Docs Build status updates of commit 78caa35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 33bf7d3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/concepts/Security-Best-Practices.md
:warning:Warning
View
Details

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/concepts/Security-Best-Practices.md

Line 138, Column 23: [Warning-file-not-found] Invalid file link: '../consume-packages/package-references-packagereference-in-project-files'.
Line 73, Column 138: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /visualstudio/ide/solutions-and-projects-in-visual-studio?view=vs-2019#solution-explorer. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 85ac519:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/Security-Best-Practices.md
:white_check_mark:Succeeded
View

docs/consume-packages/Package-References-in-Project-Files.md
:white_check_mark:Succeeded
View

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Choosing "Reconcile->Actions->Create a new topic for cell" results in cells without an identiferSpace set

When reporting a bug please provide the following information to help reproduce the bug:
Version of OpenRefine used (Google Refine 2.6, OpenRefine2.8, an other distribution?):
2.7, 2.8 and build from current master
Operating Systems and version:
MacOS High Sierra
Browser + version used - Please note that OpenRefine doesn't support Internet Explorer but works OK in most cases:
Safari 11.1
Steps followed to create the issue:
On a column that has not been reconciled, choose the drop down menu:
Reconcile->Actions->Create a new topic for cell
Current Results:
Unreconciled cells are marked as if reconciled for a 'new' item but no identifierSpace is set (as no reconciliation service has been specified
Expected Results:
I think it should not be possible to end up with a seemingly reconciled cell to have no identifierSpace.
Either the option should be non-operational in some way (possibly ignoring cells where there is no current identifierSpace set) or the user should be prompted for an identifierSpace for non-reconciled cells - or similar... (another idea might be to have a default identifierSpace set by the user that would be used in these situations)

I'd wondered about the situation where you did a reconcile when you already had a filter on - would the cell then lack the identifierSpace?
But agree about the general principle

In case of a partial reconcile of a column, you still get a ReconConfig object in the column metadata, so matching unreconciled cells to new should not be an issue.

One possible way to fix this would be to add a dialog (similar to the one for the "Use values as identifiers" action) asking for the reconciliation service to use when creating the "new" reconciliation judgments. This dialog would only be shown if the column does not have a ReconConfig object already (in which case the croresponding service would be used directly).

@wetneb I like that idea.  I think we should try it out.

Unassigning because we are not actively working on this.

Closing in favour of #4985, a duplicate but more explicit issue.


⚠ Fortnite has degraded performance

In 09be4ca, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1505 ms

Resolved: Fortnite performance has improved in f95266e.


MINOR: Fix PluginInfoTest for Connect

The refactorings in https://github.com/apache/kafka/pull/13219 are largely very helpful; however, the changes to the PluginInfoTest suite have caused it to begin failing.
This PR reverts the changes to that test suite and adds a note on why we use assertTrue(foo.equals(bar)) instead of assertEquals(foo, bar).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 would you have a moment to take a look at this?
I'm going to bed now; feel free to merge if everything looks alright.

Ah, apologies, I wasn't aware of this behaviour

Since this is causing build failures on trunk and, with the exception of a two-line comment, the changes revert the test class in question to its last green state, I'm going to merge this change.
I will be happy to address any questions/comments here and, if necessary, file a follow-up PR.

@clolov No worries :)
It may be worth checking the CI build results for your PRs in the future. I know it can be tricky to tell sometimes if a test failure is due to flakiness or not, but if something fails on every different JDK/Scala version combination, it's probably a real failure and should be addressed before merging.

My bad, I thought I ran tests on all changed classes but clearly I missed some. Thanks @C0urante for the quick fix!


update doc

What problem does this PR solve?

Add link in provider example

Add terraform init

@zhangyangyu PTAL


Analyst - Create RFI

User Story
As an Analyst
I want to create an RFI
So that the applicant will be able to upload the requested files.
Acceptance Criteria:

[ ] RFI in the sidebar
Given an analyst is on an application page where they can see the sidebar
when they click on the RFI tab
then they will see the RFI page
icon is envelope from font-awesome

[ ] Show 'New RFI' button
Given that I'm on the RFI page
When I click on "New RFI"
Then I will be directed to the RFI form

[ ] RFI Number generated
Given that an analyst is a person who exists in the world and has watched Lion King 16 times
when they are on the RFI form
Then they will see an autogenerated RFI #
and the format will be RFI-CCBC-XXXXYY-Z
RFI-CCBC ID-#
For CCBC-010023's first RFI, the # would be: RFI-CCBC-010023-1
For CCBC-010102's fifth RFI, the # would be: RFI-CCBC-010102-5

[ ] RFI type checkboxes
[ ] Due by date date-picker
[ ] Email correspondence file upload, no file type restrictions, multiple files allowed
[ ] Checkboxes for requesting files

[ ] Action: Save
Given that an analyst is on the RFI page
When they click on Save
Then the values are created in the database
And I'm redirected to the page "List RFIs"
And a success toast with the text "RFI saved"

[ ] Cancel
Given that an analyst is on the RFI form
when they press cancel
then any information is abandoned
and the RFI number can be used for the next RFI submitted for this application

Technical Analysis

[ ] On creation of an RFI, a new schema is stored in the ccbc_public.form table with type rfi
[ ] Should create a new computed column to easily get rfi for an application
[ ] .

Wireframes
Wireframes
New RFI

New RFI - Empty state

New RFI - Open and filled

Not included:

** Scenario: Validate if RFI type is not empty**
Given the fields have valid information
And the RFI type field has no option selected
When I click on Save
Then a Error mensage appears
And the operation is cancelled

Deprioritized
- [ ] Open and close accordions
Given I'm entering a new RFI
When I click the + icon
Then the section will open
When I click the - icon
Then the section will close

- [ ] Show checkbox beside each uploaded file in the application
Given I'm entering a new RFI
And an applicant has uploaded a file as part of their application
When I open a section
Then a checkbox will be visible beside each filename uploaded

@elliottSlee for post MVP I think we will need to design how they will create new 2nd and subsequent RFIs.  I noticed that 'New RFI' button disappears in the screens above.  Also do you think we need to reword the button to 'Create RFI'.... more of an action word?

Looks good, just one thing; the file upload is throwing an error

@MarsRomer2 sorry I mentioned on Teams that the permissions for analyst uploads were coming in another ticket that is in review.

Right! I will put it back in PO review column and review this ticket when that one is done

IT works!!! only one thing, it doesn't allow multiple file uploads.  Can you please make that change?


⚠ Samsung has degraded performance

In 41f00c9, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2913 ms

Resolved: Samsung performance has improved in 69ad5d1.


Support migration of multiple database instances on Spring Boot app startup

How does the Mongock runner retrieve the database URI and database name? Does it reads spring boot application properties?
Is there an API on in SpringBootMongockBuilder to set the database URI and database name? For now I am using this:
@Bean
public SpringBootMongock mongock(MongoTemplate mongoTemplate, ApplicationContext springContext) {
return new SpringBootMongockBuilder(mongoTemplate, "com.banyan.poc.moduleA.migration.changes")
.setApplicationContext(springContext)
.setLockQuickConfig()
.setThrowExceptionIfCannotObtainLock(true)
.build();
}
This works but I need a way to provide database URI and database name programmatically. In my production app, I will never know the URI before starting the app.

Mongock relies on MongoTemplate, and assumes everything is set up.
I don't fully understand when you say "In my production app, I will never know the URI before starting the app", I guess after boostrapping you retrieve the configuration from somewhere else. I probably miss something, but it seems a bit bizarre. Anyway, in that case, you shouldn't be providing Mongock as bean at bootstrap time neither as ApplicationRunner nor InitializingBean.
You should be building it as you are doing(but not as a bean) once you've got the mongo's properties and run manually the method run.
Please not,  latest Mongock's version is 4.1.2.BETA. We'll be providing official documentation soon.

First, thanks for a quick response.
We will be deploying the app in cloud and will be used by multiple customers but each customer database will be a different instance. So we will be retrieving the database URIs from a centralized database. And so we will need to pass in list of database URIs for migration.
I would like to know what object can we use mongock to run manually? Class com.github.cloudyrock.mongock.Mongock does not seem to have any APIs to add configuration or run/execute manually?
Thanks.

sorry, for some reasons I didn't see this.
The main issue or concern is "how are you creating the connection?". I mean, do you create a MongoTemplate for each database? Do you Create a mongoClient for each and connect directly to the client's database?...
Depend on that you could be using MongockSpring or MongockStandalone, but I need a bit more technical information.
Cheers

Hi,
Currently we are in POC phase. But yes we will need to create MongoTemplate for each database instance. I did a small test as below and was able to execute migration across multiple database instances. For now I have the URI list as hardcoded but we may have to build/retrieve this list somehow. Do you see an issue with this approach?
@Configuration
public class MigrationRunner {
@Value("${spring.data.mongodb.database}")
private String dbName;
@Autowired
public Environment environment;
@Bean
public void runMigration() {
// hard coded list for now
List tenantUris = Arrays.asList("mongodb://some_IP:27017/poc", "mongodb://localhost:27017/poc");
tenantUris.forEach(uri ->  {
MongoClient mongoClient = MongoClients.create(new ConnectionString(uri));
MongoTemplate template = new MongoTemplate(mongoClient, dbName);
SpringMongock springMongock = new SpringMongockBuilder(template, "com.poc.migration.changes")
.setSpringEnvironment(environment)
.setLockQuickConfig()
.setThrowExceptionIfCannotObtainLock(true)
.build();
springMongock.execute();
});
}
}

Sorry for the delay. Is that failing right now?
Anyway, as you are not really using any Spring feature for Mongock, I would recommend to use the standAlone version. Please see the readme:

explanation
how to use it


fix(ci): separate rpm/bin/bin-static/deb packages before publication, rename bin-static

What type of PR is this?
/kind bug
/area CI

What this PR does / why we need it:
This fixes a couple things with the publish package pipeline

Now different types of packages are extracted to different directories. In the current state, static overwrites bin!
The static artifact is renamed before being uploaded to maintain consistency with the artifact names

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 87448a819d35145407e8c376c9456149947eea0b

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.35.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Refs #2501


CORS issue

I'm using EmberCLI for my front end. I have included sails.io.js, and added the following code:
io.sails.url = 'http://localhost:1337';
But I get the following error:
XMLHttpRequest cannot load http://localhost:1337/socket.io/?__sails_io_sdk_version=0.11.0&__sails_io_s…sails_io_sdk_language=javascript&EIO=3&transport=polling&t=1421409540966-5. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access.
I have set allRoutes: true and origin:'http://localhost:4200' in config/cors.js, however I'm thinking that these settings only affect requests to the routes based on the comments in that file. I tried adding the headers in the config/http.js file using customMiddleware, but I get the same error.

Same problem here. Tested with sails.js server v0.10.5 and sails io client 11.5.
Server is running at http://localhost:1337 and clients at http://localhost. allRoutes is set to true.
Only when i use socket.io 0.9x OR sails io 0.10x it is working.

I've got this issue, too. Using server v0.10.5 and and sails io client 11.5. Same config as @moehlone

+1

Hey,  all, I found the problem, you should use the socket.io.js file in the generated sails project
/assets/js/dependancies/sails.io.js
Installing this module directly from bower just is not compatible with sails backend.

Ah, thanks @everdance--this is correct.  The currently hosted sails.io.js is compatible with Sails v0.11.x only.  Sails v0.11 upgraded to use Socket.io 1.0, and we had to update the client to match.  You should always use the sails.io.js client that comes bundled with the version of Sails that you're using.  To upgrade later (if you upgrade your Sails app from v0.10.5 to v0.11.x), you can run sails generate sails.io.js.
Added a note to the docs about using the proper version!


Python buildpack: App staging failed in the buildpack compile phase

For most Python 3.x runtimes, we are getting
Server error, status code: 400, error code: 170004, message: App staging failed in the buildpack compile phase
We see this in a virgin Cloud Foundry using python-buildpack 1.1.2. We have tested with CF v203 and CF v200.
Using git master python-buildpack and CF v203, staging succeeds. (This workaround does not work
for v200.)
The application is trivial, it simply writes back some environment variables.
Staging succeeds for Python 2.7.x (tested 2.7.8 and 2.7.9), and for 3.4.0 and 3.4.1.
We see the above mentioned error for all other 3.x.y we have tested:
3.4.2
3.3.0-3.3.6
3.2.5
3.1.5
Looks like it's time for a new python-buildpack release.

@jhellan, we are going through a process of documenting (and perhaps culling) versions of the binaries across all buildpacks.
To see the supported version of binaries, you can look at the manifest.yml file of the root of the directory.
v1.1.2 manifest.yml includes Python 2.7.0-2.7.9, 3.2.0-3.2.3 and 3.4.0-3.4.1.
Are there reasons to support the in between versions you've documented as unsupported? 3.3, 3.1, etc.

On 17. mars 2015 21:08, JT Archie wrote:

@jhellan https://github.com/jhellan, we are going through a process
of documenting (and perhaps culling) versions of the binaries across
all buildpacks.
To see the supported version of binaries, you can look at the
|manifest.yml| file of the root of the directory.
v1.1.2 manifest.yml
https://github.com/cloudfoundry/python-buildpack/blob/v1.1.2/manifest.yml
includes Python 2.7.0-2.7.9, 3.2.0-3.2.3 and 3.4.0-3.4.1.
Are there reasons to support the in between versions you've documented
as unsupported? 3.3, 3.1, etc.

We have an application which had been running 3.3.2 for a long time, and
had a hard time figuring out why we could not deploy a new version.
As for the other versions, we tested some of those we found  in
builds/runtimes. When 3.4.0 and 3.4.1 worked, and 3.4.2 was present, we
really thought it was intended to work. Never thought of
checking manifest.yml :-)
Regards
Jon

—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/cf-release/issues/637#issuecomment-82576336.

@jhellan, did we resolve your issue? We can reopen, again.
We have upcoming epic to better document the supported versions of our runtimes.
Thanks, JT

On 24/03/15 15:32, JT Archie wrote:

@jhellan https://github.com/jhellan, did we resolve your issue? We
can reopen, again.
We have upcoming epic
https://www.pivotaltracker.com/epic/show/1747328 to better document
the supported versions of our runtimes.
Thanks, JT

Up to you. I know where to look next time. But there really should be a
consistent way to check
for all buildpacks. E.g. there is no manifest.yml for the php buildpack.
Jon

We are glad to announce as of last week, the PHP buildpack is using the same manifest.yml files as the rest of the buildpacks. :)


Adapt the new v3 protocol

Follow the new v3 protocol.

Screenshots

Codecov Report

Merging #53 into master will decrease coverage by 9.17%.
The diff coverage is 44.80%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   67.26%   58.09%   -9.18%
==========================================
  Files          11       14       +3
  Lines         666      661       -5
==========================================
- Hits          448      384      -64
- Misses        185      237      +52
- Partials       33       40       +7

Impacted Files
Coverage Δ

internal/idgen/idgen.go
0.00% <0.00%> (ø)

reporter/log.go
0.00% <0.00%> (ø)

reporter/grpc.go
32.94% <28.12%> (-26.26%)
:arrow_down:

segment.go
74.07% <42.85%> (-6.51%)
:arrow_down:

plugins/http/client.go
45.83% <50.00%> (ø)

plugins/http/go_resty.go
60.00% <60.00%> (ø)

plugins/http/server.go
46.15% <60.00%> (+0.15%)
:arrow_up:

propagation/propagation.go
66.03% <79.16%> (ø)

trace.go
83.33% <88.88%> (+0.11%)
:arrow_up:

noop.go
57.14% <100.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be06e8d...36081c7. Read the comment docs.

Do We expect coverage rate decrease 10%?

Do We expect coverage rate decrease 10%?

Let me update the unit test.

Seems no coverage change?

Seems no coverage change?

Please review :)


Usage of unused variable

While debugging my game I noticed that ScrollDistance has no effect. It turns out the value is hardcoded and the variable is not being used.

This actually regressed waaaaaaaaay back, at https://github.com/ppy/osu-framework/commit/530a4a6a2f3d226cd542483e9328f1f897ee04e3.
While this change does appear to make some sense, I'm not sure that the precise case should remain hardcoded? Both should probably be controllable somehow, even if by having the precise scroll be a fraction of the non-precise distance (would be one-eighth with current numbers).

I think that can be touched upon in a further PR and get this in as is. Not sure whether best is to expose it as controllable or divide or to keep it as hardcoded (because it is supposed to track precisely).


Update to Go 1.13.1

After merging #3685 which took us to 1.12.7, I figure we may as well jump to the latest.
Needs an update to the tools submodule to cope with changes in go vet

Bumped to 1.13.3 released 2019/10/17


[Home][ArtistRail] Follow button disappears on iPad

Can you try to check the ‘DOM’ with the ‘Show Inspector’ option in the debug menu (shake) ?


CoremlBugFixes:Input variable name can be something other than data; …

…making pad and stride optional.
Earlier, we were not providing data_names argument while creating the module which meant that the input data variable name was assumed to be "data". This is fixed. Also, added a unit test for it (due to which utils.load_model(..) had to be refactored).
The second bug was we missed assuming pad and stride parameters for convolutional layers are optional arguments. Added a unit test for this too.
Also, tested with mnist model from the tutorial page by changing the input variable name to something other than "data".
@jiajiechen @srikris @mli @piiswrong

@nswamy @piiswrong can you please review and merge? We are waiting on this to complete before launch


Loading a checkpoint when running TrainingAnomalyDetector_public

When I load an existed checkpoint this line, an error shows below.
My question is should the code define something as
network = AnomalyDetector(args.feature_dim)
model = TorchModel.load_model(args.checkpoint)
Not really sure about the coding structure of TorchModel, so I want to confirm with you is it right to add network = AnomalyDetector(args.feature_dim) before it, and it will work perfectly?
Traceback (most recent call last):
  File "train_anomaly_detector.py", line 153, in <module>
    criterion = RegularizedLoss(network, custom_objective).to(device)
NameError: name 'network' is not defined

Definitely! Thanks for reporting this. I will fix it soon.


gamma argument in EfficientFrontier has no effect

Describe the bug
When I ran EfficientFrontier on the stock prices this package uses for its unit tests, different gamma values led to the same weights. I have tried both min_volatility and max_quadratic_utility objectives/methods. gamma enters into the convex optimisation objective itself; it's inconceivable that 100 and 0 would lead to the same weights.
Expected behavior
Should obtain different portfolio weights for drastically different gamma values. I am aware that there's a L2_reg objective function in the package; but if gamma is exposed in the constructor of EfficientFrontier, then I don't think users should need to manually add the L2 regularisation objective for gamma != 0.0
Screenshots

Operating system and python version:
e.g MacOS 10.14.6, python 3.8.3, pyportfolioopt 1.2.3, cvxpy 1.0.31
I appreciate this package very much; looking forward to improving it, one way or another!

Hi @openerror,
Really appreciate the detailed report! This is indeed a bug, I forgot to remove gamma from the constructor when I changed the API – it does not connect to anything and I will remove it in the next release.
Cheers!
Robert

Thanks for the prompt response, Robert. In that case, how would one add L2 regularisation as an objective? You included the following lines in the documentation, but how does one actually define & adjust gamma's value? (Tried running the lines below, same results as gamma = 0)
ef = EfficientFrontier(expected_returns, cov_matrix)  # setup
ef.add_objective(objective_functions.L2_reg)  # add a secondary objective
ef.min_volatility()  # find the portfolio that minimises volatility and L2_reg

Would gladly contribute the relevant edits to the docs, once it's clear how to do it

@openerror
Really sorry for the slow reply – I was quite busy with internship work this summer. I'm glad you figured it out. I'll have a go at making the docs a bit more clear on this.
Cheers,
Robert

No worries Robert, I was busy with my internship, too. Looking forward to a better and more complete package!


Failed withdraw bucket with ledger

I got this error message:
send action error: {"code":13,"message":"invalid sender","metadata":{"content-length":"0","content-type":"application/grpc-web-text+proto","grpc-message":"invalid sender","grpc-status":"13"}}
After i approved with my Ledger this message came. I didn't have same problem with another bucket.

Can you send the bucket ID's which worked, and the one which failed?

Also, are you using the latest 0.2.6 IoTeX app installed? You can get it from the Ledger Live app store if you enable "Developer mode" in Ledger Live settings. 😀

Still the same thing after i updated iotex app in Ledger.  Iotexlab is bucket, which won't send :( Got same message after update.

are you using ioPay desktop with your Ledger, or are you using the "Ledger" connection option on the stake.iotex.io page?


added support of missing functionalities of rocksdb

modified existing functionalities and added missing as per latest rocksdb(rocksdb_5.9.2)

@chirino  as all the checks have been passed successfully. So could you please suggest us the next steps to be followed or done.

can any maintainer have a look on these changes..

Please merge this also as hawtjni changes are merged
https://github.com/fusesource/hawtjni/pull/50

@gnodet can you please have a look on these changes also
hawtjni changes are already merged
https://github.com/fusesource/hawtjni/pull/50

I don't see any usage of shared_ptr in your commit ? How does this PR relates to the hawtjni PR ?

Hi @gnodet
Yes, this PR does not relate with the hawtjni PR.
The PR add the new functionalites which is present in rocksdb but not currently supported by rocksdbjni, functionlities like Keymayexist, Single delete for write Batch
Please consider the PR to merge.

@gnodet this is long pending PR to provide support of missing functionalities in rocksdbjni and present in rocksdb
it would be helpful for all rocksdbJni users, Please consider the PR to merge.

Hi @gnodet
I am curious to know when are you planning in merging the PR. If any help or information required from our side, do let us know.
It will be  helpful for the rockdbjni users, to see the support of the missing functionalities of the rocksdbjni

@gnodet Any update on the PR merge status.

@gnodet can you review this PR to be merged

can someone have a look on this PR in which i tried to align with RocksDB

Maybe you should investigate switching to the official rocksdb java support which is available since RocksDb 3.5.0, 4 years ago:
http://repo1.maven.org/maven2/org/rocksdb/rocksdbjni/


SOFTWARE-6027: Add osg 24 to build matrix

Does this have external users? Maybe once we are satisfied that OSG 24-based builds work, we can remove OSG 23 from the build matrix.

I believe it's all internal, Also, the 23-* build series has never been used in prod, all the PATh facilities are currently still on a 3.6 build

Good point. I'm down with removing the 23-* build series outright


datetime error in --tconv option

The following error is raised in --tconv compiler option

datetime.py:336 Uncaught TypeError: Cannot read property 'name' of null

I traced up in call stack. The problem is that 'offset' is null (in datetime.py:1776)

    # __pragma__('opov')
    if not (self._minoffset <= offset <= self._maxoffset):

It has no problem without --tconv option. Possibly 'opov' option collides with --tconv option?
I am trying to use --kwargs, --keycheck, --tconv options altogether because the compiled javascript is directly readable, and I want to obfuscate my source code. Only --tconv  option encounters an error in datetime.

Without your code that uses datetime it will be difficult to determine where the null value comes from. Preferably something that can be transpiled in order to reproduce the issue.


React Native SDK

Build React Native SDK docs

Follow CLI format

Revisit in future after larger SDK discussion.


Create the Hero section for FORUM website

You have to create a hero section for the FORUM website. You need to replicate the below design as close as possible.

Resources
FIGMA
Guidelines

The code should be clean and reusable.
You have to make a component for hero-section by making a folder inside THIS and then create a index.js file in which you have to write your code.

Note

Make sure you follow the given template before making the pull request.

claim

claim

claim

claim

Note: You don't have to design it, rather you have to code it in react and tailwind CSS

I'll code @yashg-116

claim

Go for it

Go for it @vishalola

I can code it

Note: You don't have to design it, rather you have to code it in react and tailwind CSS

The issue has been assigned for now. You can claim if it will be reopened or if a new issue comes up 👍🏼

claim


automatically calculate crc32 for flash based application

The new revision will calculate crc32 for the stage2 boot block and store at 0x100000FC.
This operation only works for flash-based applications.

I was thinking these days, maybe I should also handle the condition when people have a stage2 block less than 252?
I have got a solution. If you think this is a good idea. Please reject this one. and I will push another merge request with a new solution.
Thank you.


Remove some deprecated GraphQL fields

See the Announcement update

Posted an update to announce the changes in https://opencollective.com/engineering/updates/breaking-change-removing-some-deprecated-fields-from-our-graphql-api


Wrong AMI in template-two (part-two)?

Running CloudFormation like described in part-two gives me this error:
AWS::EC2::Instance   EC2Instance API: ec2:RunInstances Not authorized for images: [ami-25865252]
Changing the ImageId to ami-20bd1f57 fixed this for me.

I'm also getting this error:
CREATE_FAILED | AWS::EC2::Instance | EC2Instance | API: ec2:RunInstances Not authorized for images: [ami-20bd1f57]
My region is definitely eu-west-1. I am unable to find this ami when I search in public images within the AWS AMI's menu. I realise this was last commented on in 2014 - just wondering if it's still available to use?

Hi @ella-jennings - thanks for flagging this up, and thanks for fixing the issue. If you'd like to submit a pull request with that fix I'd be more than happy to merge it.


multi language in react

Make sure these boxes are checked before submitting your issue - thank you!

[ √] I have checked the superset logs for python stacktraces and included it here as text if any
[ √] I have reproduced the issue with at least the latest released version of superset
[√ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.18.5
Expected results
multi language in react
Actual results
multi language in react
I have use react-intl-universal to improve multi language in react page.you can see Pull request #3082.

No need to open a a new issue for your PR, please close.


Tailwindcss integration

I think it will be cool to add tailwindcss integration maybe through the use of a class attribute on each component or on html tags

+1 for tailwindcss integration and update docs to pass templates/props to nodemailer

Is this as simple as passing in a class name and it will work with Tailwind CSS?
I have no experience with Tailwind CSS but the components can export a class such as:
<script>
  let className = undefined;
  export { className as class }
</script>

<h1> class={className}><slot /></h1>

Ok thanks, I will try this.

Is this not possible at the moment? I was looking through the code and found components have {...$$restProps} which means "pass all props to the element". This should include the class prop.


Update topmed data

Current data is from is from Nov 2018, should be updated

Freeze 8 is downloaded here: gs://seqr-reference-data/GRCh38/TopMed/freeze8

https://console.cloud.google.com/dataproc/jobs/7fe4e76b61984605a17e4b7b874ee259/monitoring?region=us-central1&authuser=0&project=seqr-project

https://github.com/broadinstitute/hail-elasticsearch-pipelines/pull/285
https://github.com/broadinstitute/seqr-pipeline-airflow/pull/60


Update google provider 4.x

waiting for release v0.0.3 of https://github.com/mineiros-io/terraform-google-bigquery-dataset-iam to mark this PR as r4r


Support Automatic Job Creation

It should be possible to, e.g:

From a theory T, e.g:

x * (y * z) = (x * y) * z.
x’’ = x.
x = x * (x’ * x).
(x * x’) * (y’ * y) = (y’ * y) * (x * x’).

Generate consequences using Prover9:

C.

Then, for each c in C, check if t inT:

(T - t) ∪ c ⇔ T.

Make sure the implementation is generic enough, and does not apply only to algebra tools.

Generic basic test implemented using bash commands

Prover9 Mace4 test implemented


Sink values closer to their use

Example of null check with a temporary:
v0 = $.DOM;
v1 = this.table;
v0.toString;

There is no need for the v0 temporary.

Obsolete


UPDATE UI

Updated UI to make the website look convenient and nice.
List of changes:
1.Increased font sizes and style
2. changed the background
3. added new news page
4. Organised contact page

This PR will not be accepted as you have directly taken information from https://www.covid19india.org/ which is absolutely unacceptable and also attempting to change meaningful CSS alterations made by other PR's.


Cache Evaluable's "attrs" at construct time, and return by ref

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

FYI there's a build failure:
error[E0277]: a value of type `partiql_value::Tuple` cannot be built from an iterator over elements of type `(std::string::String, partiql_value::Value)`
   --> partiql-eval/src/eval.rs:264:13
    |
264 |             attrs.into_iter().map(|k| (k.into(), Null)).collect()
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ------- required by a bound introduced by this call
    |             |
    |             value of type `partiql_value::Tuple` cannot be built from `std::iter::Iterator<Item=(std::string::String, partiql_value::Value)>`
    |
    = help: the trait `FromIterator<(std::string::String, partiql_value::Value)>` is not implemented for `partiql_value::Tuple`
    = help: the trait `FromIterator<(&'a str, T)>` is implemented for `partiql_value::Tuple`
note: required by a bound in `collect`
   --> /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905[483](https://github.com/partiql/partiql-lang-rust/actions/runs/4147861168/jobs/7175224975#step:6:484)/library/core/src/iter/traits/iterator.rs:1832:19
    |
    = note: required by this bound in `collect`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `partiql-eval` due to previous error

Probably needs #297 merged in first?


[SPARK-6598][MLLIB] Python API for IDFModel

This is the sub-task of SPARK-6254.
Wrapping IDFModel idf member function for pyspark.

Test build #29398 has started for   PR 5264 at commit 1dc522c.

Test build #29398 has finished for   PR 5264 at commit 1dc522c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29398/
Test PASSed.

LGTM. Merged into master. Thanks!


Azure SQL Server - Laravel not detecting lost database connections

Laravel Version: 5.6
PHP Version: 7.2
Database Driver & Version: pdo_sqlsrv

Description:
Running Laravel on CentOS 7.4 in an Azure VM. Using Azure SQL Server database and Azure queues.
We have queue workers running. These monitor the queues with no issues. However, after a short time (a few hours or thereabouts) if a job comes in on the queue, the job throws an exception as it tries to access the database. The exception includes the message:

ERROR: SQLSTATE[08S02]: [Microsoft][ODBC Driver 13 for SQL Server]SMux Provider: Physical connection is not usable [xFFFFFFFF].

This continues for all further jobs, until the queue workers are killed.
Steps To Reproduce:
Most of the details are above. Basically, use Azure SQL Server with pdo_sqlsrv driver, run a artisan queue:work, do nothing for a couple of hours, then dispatch a job to the queue that needs to use the database.
I have found the list of error messages that Laravel uses to decide whether a database connection has been lost:
https://github.com/illuminate/database/blob/71f75f4d1d7ffaa33da4bde0da6f246ed7741479/DetectsLostConnections.php#L10
I have hacked "Physical connection is not usable" into that list on our system to see if that fixes the problem. Will know later today.
Assistance sought here: https://laracasts.com/discuss/channels/laravel/how-do-i-add-a-message-to-the-list-detecting-a-closed-database-connection

A 17:00 BST scheduled job we have ran successfully after being left without processing any queued jobs for 2.5 hours. It's looking promising. I'll leave the system for the midnight job to see how that goes, before submitting a PR.
Just a note, but the list of messages that Laravel checks for, to determine whether the database connection has been closed, are all English. How does this work in other locales, where the PDO driver may be returning non-English error messages? Are they all having problems running queue worker daemons?

Had a different "connection lost" error this time:

SQLSTATE[08S01]: [Microsoft][ODBC Driver 13 for SQL Server]TCP Provider: Error code 0x68

It is becoming apparent to me that this list of error messages that indicate a connection was lost, needs to be configurable. I can see no way to override that Trait, hard-coded in the Connection class, that is not macroable (AFAICS), except by an override in the autoloader.
If the trait moved the list of messages to a property, and provided some public methods to manipulate that list, that could be one approach.

Hello @judgej, I have this problem as well and it's caused by running the workers in daemon mode, causing the connection to the DB to be left open.
When changing to not use it in production it fixes the issue (although jobs and processed much slower).
You can increase the timeout in SQL Server but not sure how to do it for AzureDB
SQLSTATE[08S02]: [Microsoft][ODBC Driver 13 for SQL Server]SMux Provider: Physical connection is not usable [xFFFFFFFF]

I've not been able to find much information on what running the jobs in non-daemon mode actually does. If it continuously restarts itself every few seconds, then that is a horrendous use of resources - constant database connects, constant process restart processing costs. I would rather avoid that if I can. But the documentation on what it actually does is very sparse.
Having the database connection dropped though inactivity is fine, so long as Laravel invisibly reconnects when the connection is needed again. Obviously avoid keeping transactions open for long periods, as you could end up with lost data when that drops.
I am finding this is becoming an issue with long-running queue listeners though. When the queue connection drops, it sends an error message to Laravel, and Laravel is not able to handle it and reconnect. For now, I'm restarting the queue workers every ten minutes, which is a reasonable compromise.
The PR I've submitted has the "Physical connection is not usable" message you are seeing included in the list of message Laravel uses to recognise lost connections, which should help you if/when it gets merged in. However, I do feel a better solution is needed there, something that will work in non-English locales would be good for a start, or a way for applications to inject there own list of messages would be an okay workaround.

Would that make Laravel auto reconnect? Or just show a more friendly error message?
We never seem to have dropped connections our MySQL or PostgreSQL applications.
I will try your PR on my local and report back!

You do have dropped connections with MySQL. It is Laravel that quietly brushes them under the carpet, reconnects, then retries the SQL or DML again for you. That's the magic of using a framework - it does stuff like that so you don't have to think about it.

This is becoming a real problem on production, I wrote some terrible code which seems to have fixed it until your PR goes through, since you can't easily override the trait
private function checkForDroppedConnection()
{
    $location = '../vendor/laravel/framework/src/Illuminate/Database/DetectsLostConnections.php';
    $file = file_get_contents($location);

    if (!\Illuminate\Support\Str::contains($file, 'Physical connection is not usable')) {
        $newFile = file_get_contents('../storage/hacks/DetectsLostConnections.php');
        $fp = fopen($location, 'wb');
        fwrite($fp, $newFile);
        fclose($fp);
    }
}

Which copies over the new file, this can be run as a composer post-install hook, or even just stick it in a middleware

The other way is to duplicate the whole class, make your changes, then make sure it is loaded before the Laravel version is loaded (just a nasty hacky include in index.php will make sure it is loaded, and the composer autoloader won't then try to load the original unpatched version.

Did I submit the PR to the wrong place?

I think so! Realised none of these PR's got merged then saw this was read only. I reopened it on the real one and was merged (sorry, feel like I took your credit) I tagged this issue to be looked at.

@adamtester I'll hunt you down - for a beer. I obviously failed to get this thing fixed, and you did, so thank you :-)

@adamtester Thank you.
I ran this command in my docker container and the error disappeared.
sudo docker exec -ti dockerizedapp_app_1 supervisorctl restart laravel-worker:laravel-worker_00


Process reconciliation as a plugin

Outline & Motivation
The DDP strategy and its subclasses have a feature called "deadlock detection and process reconciliation". It can ensure that all processes terminate properly when an error occurs on a subset of the ranks. Without this feature, the processes where no errors occur would continue to run and hang/wait at the collectives.
Pro:

Can save you costs when running in the cloud.
No zombie processes you have to manually kill

Con:

Implementation is hardcoded into the DDPStrategy, does not work well with inheritance
Makes trainer exception handling complex
Assumes a shared filesystem

Pitch

Remove the feature from PL strategies (#16204)
Introduce it as a plugin under fabric
Introduce Strategy.on_exception that the exception handler can call in a standardized way
Re-introduce it in PL strategies once flattening preparations for Fabric integration are done

[ ] Subtask: Add the plugin to other strategies such as deepspeed:  #16518

A strategy can enable the plugin like so:
if not torch_greater_equal_foo and has_shared_filesystem:
    enable_plugin()

and by implementing
def on_exception(self, exception):
    self.plugin.reconciliate_processes(...)

Additional context
Credit for the ideas @carmocca
No response
cc @justusschock @awaelchli @carmocca

In #16525 I implemented a limited version of this proposal. It's intra-node only and only runs under the SIGTERM signal, but it could be extended to support inter-node, more signals, or any exception type.
My code was loosely based on https://github.com/pytorch/pytorch/blob/v1.13.1/torch/distributed/elastic/multiprocessing/api.py


Invalid coins value

If I set coins amount in double format it throws me an error "Invalid Coins value".
For example here or while creating transfer message:
decimal tonAmount = 0.1d;

Cell swapToJettonBody = DeDustNativeVault.CreateSwapBody(new DeDustNativeSwapOptions()
{
    PoolAddress = pool.Address,
    Amount = new Coins(tonAmount)
});

But if the amount is in string format, it works good.

fixed in #108


recolor Remove Theme Items icons from Godot 4 colors to Godot 3

follow-up to #62559.
we found more icons that mistakenly had the Godot 4 colors,
so i fixed them too.

Thanks!

As a tip for future PRs, you might want to create a specific branch for the PR instead of using your fork's 3.x or master branch. This lets you have multiple PRs which can be merged independently, and avoids situations where your 3.x branch might end up having commits not found in the upstream one (e.g. if a PR made from your 3.x ends up not being merged, or being merged with a rebase). See PR workflow for details.


iframe consumes pointer events from widgets appearing on top

Steps to Reproduce
// ignore: avoid_web_libraries_in_flutter
import 'dart:html';
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

void main() {
  // ignore:undefined_prefixed_name
  ui.platformViewRegistry.registerViewFactory('someViewType', (int viewId) {
    final wrapper = DivElement();
    final div = IFrameElement()
        ..width = '640'
        ..height = '360'
        ..src = 'https://www.youtube.com/embed/IyFZznAk69U'
        ..style.border = 'none';
    wrapper.append(div);
    return wrapper;
  });

  runApp(MaterialApp(home: HomeScreen()));
}

class HomeScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      drawer: Drawer(child: Container(color:Colors.yellow, child: RaisedButton(
      onPressed:()=>debugPrint("123123")
      ))),
      body:  SizedBox(
      width: 640,
      height: 360,
      child: HtmlWidget(),
    ),
      floatingActionButton: Builder(builder: (context) {
        return FloatingActionButton(
          child: Icon(Icons.menu, color: Colors.white),
          onPressed: () {
            Scaffold.of(context).openDrawer();
          },
        );
      }),
    );
  }
}

class HtmlWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return HtmlElementView(viewType: 'someViewType');
  }
}

class HtmlHelloWorldWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return HtmlElementView(viewType: 'hello-world-html');
  }
}

Actual results:

flutter doctor -v
[✓] Flutter (Channel dev, v1.16.4-pre.50, on Mac OS X 10.15.4 19E266, locale
    zh-Hans-US)
    • Flutter version 1.16.4-pre.50 at /Users/angus/flutter
    • Framework revision d14a301e41 (4 days ago), 2020-03-31 19:14:22 -0400
    • Engine revision fc5b44c901
    • Dart version 2.8.0 (build 2.8.0-dev.18.0 e8c4aed700)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/angus/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.0.beta.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 43.0.3
    • Dart plugin version 193.6015.53

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.0

[✓] Connected device (3 available)
    • macOS      • macOS      • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome     • web-javascript • Google Chrome 80.0.3987.149
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

I need help badly

The only solution
// ignore: avoid_web_libraries_in_flutter
import 'dart:html';
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

void main() {
  // ignore:undefined_prefixed_name
  ui.platformViewRegistry.registerViewFactory('someViewType', (int viewId) {
    final wrapper = DivElement()
      ..style.width = '100%'
      ..style.height = '100%';

    final div = DivElement()
      ..contentEditable = 'true'
      ..style.width = '100%'
      ..style.color = "red"
      ..style.backgroundColor = 'red'
      ..style.height = '100%';
    wrapper.append(div);
    return wrapper;
  });

  runApp(MaterialApp(home: HomeScreen()));
}

class HomeScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      drawer: Drawer(
          child: Container(
              color: Colors.yellow,
              child: RaisedButton(onPressed: () => debugPrint("123123")))),
      body: SizedBox(
        width: 640,
        height: 360,
        child: HtmlWidget(),
      ),
      floatingActionButton: Builder(builder: (context) {
        return FloatingActionButton(
          child: Icon(Icons.menu, color: Colors.white),
          onPressed: () {
            Scaffold.of(context).openDrawer();
          },
        );
      }),
    );
  }
}

class HtmlWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return HtmlElementView(viewType: 'someViewType');
  }
}

Hi @AngusPei
I tested with the current latest master the code from your last post
screenshot
logs where clean building, but got some exception running
[ +295 ms] Debug service listening on ws://<IP_ADDRESS>:51731/e09Z_3mhTT0=
[   +1 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[        ] 🔥  To hot restart changes while running, press "r". To hot restart (and refresh the browser), press "R".
[   +1 ms] For a more detailed help message, press "h". To quit, press "q".
[+1291 ms] ══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞══════════════════════════════════════════════════════════

[  +11 ms] The following StateError was thrown during a platform message response callback:

[        ] Bad state: Future already completed

[   +1 ms] When the exception was thrown, this was the stack:

[        ] dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 195:49  throw_

[        ] dart-sdk/lib/async/future_impl.dart 42:79                                     complete

[        ] packages/flutter/src/services/binding.dart 177:18                             <fn>

[        ] dart-sdk/lib/async/zone.dart 1374:10                                          runUnaryGuarded

[        ] lib/_engine/engine/window.dart 331:23                                         <fn>

[        ] lib/_engine/engine/window.dart 488:17                                         <fn>

[        ] dart-sdk/lib/async/zone.dart 1439:54                                          runUnary

[        ] dart-sdk/lib/async/future_impl.dart 141:18                                    handleValue

[        ] dart-sdk/lib/async/future_impl.dart 682:44                                    handleValueCallback

[        ] dart-sdk/lib/async/future_impl.dart 711:32                                    _propagateToListeners

[   +7 ms] dart-sdk/lib/async/future_impl.dart 516:7                                     [_complete]

[        ] dart-sdk/lib/async/future.dart 315:15                                         <fn>

[        ] dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 50:19       internalCallback

[        ] ════════════════════════════════════════════════════════════════════════════════════════════════════

[+164919 ms] Application finished.
[  +54 ms] Stopped debug service on ws://<IP_ADDRESS>:51731

[  +34 ms] Failed to clean up temp directory: /var/folders/c3/l5jpznsj5k37yrj47l__xpw40000gn/T/flutter_tools.wBGvDs
[   +1 ms] "flutter run" took 216,764ms.

[✓] Flutter (Channel master, v1.18.1-pre.15, on Mac OS X 10.15.4 19E266, locale en-EE)
    • Flutter version 1.18.1-pre.15 at /Users/nevercode/development/flutter_master
    • Framework revision 17079f26b5 (6 hours ago), 2020-04-06 01:21:01 -0400
    • Engine revision 9b8dcc7ecf
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 05103dfe5a)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (2 available)
    • Chrome     • chrome     • web-javascript • Google Chrome 80.0.3987.163
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

@iapicca
There is no problem with the current version

[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale
    zh-Hans-US)
    • Flutter version 1.18.0 at /Users/angus/flutter
    • Framework revision 14f3a36aba (2 days ago), 2020-04-03 17:06:01 -0700
    • Engine revision 09bc1fc45e
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 e736495eb7)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/angus/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.0.beta.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 43.0.3
    • Dart plugin version 193.6015.53

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.0

[✓] Connected device (3 available)
    • macOS      • macOS      • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome     • web-javascript • Google Chrome 80.0.3987.149
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

@iapicca 1.18.0-pre.04 DIV Click invalid

/cc @hterkelsen

I also had similar issue on beta Flutter version 1.17.0, and also happened on newest master channel.
The icon button can't fire any event on Stack widget with HtmlElementView
class _BroadcastViewState extends State<BroadcastView> {
  @override
  void didChangeDependencies() {
    final IFrameElement iframeElement = IFrameElement();
    iframeElement.height = MediaQuery.of(context).size.height.toString();
    iframeElement.width = MediaQuery.of(context).size.width.toString();
    iframeElement.src =
        '/assets/index.html';
    iframeElement.style.border = 'none';
    iframeElement.id = 'iframe';
    // ignore:undefined_prefixed_name
    ui.platformViewRegistry.registerViewFactory(
      BroadcastView.createViewId,
      (int viewId) => iframeElement,
    );
  }

  @override
  Widget build(BuildContext context) {
    return HtmlElementView(
      viewType: BroadcastView.createViewId,
    );
  }
}

class BroadcastScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Stack(
        children: <Widget>[
          BroadcastView("2e3a4751cc05489083db0316f44e47f5", "channel01"),
          Positioned.fill(
            child: Align(
              alignment: Alignment.bottomRight,
              child: RawMaterialButton(
                onPressed: () {
                  print('clicked');
                },
                child: new Icon(
                  Icons.live_tv,
                  color: Colors.white,
                  size: 25.0,
                ),
                shape: new CircleBorder(),
                elevation: 2.0,
                fillColor: Theme.of(context).primaryColor,
                padding: const EdgeInsets.all(15.0),
              ),
            ),
          )
        ],
      ),
    );
  }
}

What is the deadline?

Grade is underestimated, IFrame tags are common in web development.
In fact, I prefer to support the interaction of nested subpages through the webview_flutter plugin, so that we can use a set of source code to achieve multi-platform support.

It’s at least P3, because I don’t have an alternative solution, which is no different from a crash.

Add dart html library, unlike Flutter.

Added the framework label because the framework should tell the engine if there's a region on top of the iframe that should capture pointer events before iframe swallows them. I have a proposal here: https://docs.google.com/document/d/1GUAx3aqdtEoaBMTNpsS1-i59QZlwTi6vUCASbaanPCo

Bumped the priority as we're hearing this concern repeatedly (e.g. see the duplicate issue reports).

@AngusPei

It’s at least P3, because I don’t have an alternative solution, which is no different from a crash.

You should be able to work around the issue by putting a platform view in the drawer that covers the entire drawer (e.g. an empty <div> that stretches horizontally and vertically to cover all the available space). This way the platform view will intercept pointer events before they reach the iframe. As long as the interceptor platform view does not itself contain an iframe Flutter will be able to process the pointer events.

If a dialog is showing over the iframe, clicks on the dialog will also be consumed by the iframe. Also, if I have any Flutter widgets (like a Button) showing over an iframe, clicks on that widget will also get passed to the iframe. That workaround won't work for these cases.

@carloshwa You are correct, and we should provide a more complete fix for this. Drawers, dialogs, pop-up menus, and other widgets that are known to appear on top of other content should take precedence over iframes by default. Having said that, Button (as well as checkbox, text, slider, and most other widgets) is an example of a widget that typically does not appear on top, but rather pushes other widgets aside (e.g. using Column, Row, Flex, Grid and other layout). Such widgets should not be aware of iframes. Instead, a container that causes these widgets to be painted on top (e.g. a dialog) would be responsible for redirecting pointer events to the framework.

Workaround
@AngusPei

It’s at least P3, because I don’t have an alternative solution, which is no different from a crash.

You should be able to work around the issue by putting a platform view in the drawer that covers the entire drawer (e.g. an empty <div> that stretches horizontally and vertically to cover all the available space). This way the platform view will intercept pointer events before they reach the iframe. As long as the interceptor platform view does not itself contain an iframe Flutter will be able to process the pointer events.

Can you give a code example -- I don't follow

Is there any update regarding this issue?

Just because of this issue, We have to switch complete app to native web framework.
iframe overlap preload navigation drawer and that becomes unresponsive.
any idea if any js code trick can we use inside targeted iframe server to rearrange stack?

Is this being worked on? This bug makes Google Maps integration in a web app largely unusable.

/cc @ditman

I'm currently working in a new widget that can be used to wrap interactive elements that are going to end up on top of an HtmlViewElement to prevent clicks from "going through".
This is probably a sufficient workaround until the framework supports this natively. If you have a RaisedButton(...) Stacked on top of a video player / iframe, you can replace it by:
MouseClickBoundary(
  clickable: true,
  child: RaisedButton(...),
),

and it should work as expected! (Clicks being handled by the RaisedButton, and not passed through to the video player / iframe underneath.

I'm currently working in a new widget that can be used to wrap interactive elements that are going to end up on top of an HtmlViewElement to prevent clicks from "going through".
This is probably a sufficient workaround until the framework supports this natively. If you have a RaisedButton(...) Stacked on top of a video player / iframe, you can replace it by:
MouseClickBoundary(
  clickable: true,
  child: RaisedButton(...),
),

and it should work as expected! (Clicks being handled by the RaisedButton, and not passed through to the video player / iframe underneath.

@ditman is that widget available somewhere? 😯

@ditman is that widget available somewhere? 😯

@joaquini while doing an example for it, I stumbled upon issue #71888, so I had to stop and try to find a minimal repro which took a while. I'll push what I have to my repo so the widget can be used from a git dependency until it lands in pub.dev!

I've pushed my changes here:
https://github.com/ditman/flutter-packages/tree/web-click-boundary/packages/web_mouse_click_boundary
It might be depended on like so:
web_mouse_click_boundary:
  git:
    git: https://github.com/ditman/flutter-packages.git
    ref: web-click-boundary
    path: packages/web_mouse_click_boundary

(Check the example for the usage)
All feedback is welcome, I'll try to write some tests for it next!

@ditman Thanks for the work on this! One use case that still affects me is scroll gesture events get passed to the underlying iframe.
Example:
My app has a Google Maps widget, and a Nav Drawer open over it. If I scroll the list in the drawer using my touchpad's scroll gesture, it also zooms in / out the underlying Google Map.

@carloshwa have you used the widget above as the root element of your drawer? I have to say, so far I've only tested click events. Scroll events may be handled differently :/

@ditman That actually worked! I wasn't sure where to put the widget to make it work with the drawer.
Next case I'm having trouble with is PopupMenuButton. If I wrap it with MouseClickBoundary, the button itself does not pass events to the iframe, but when the popup menu is open, clicks on the menu do get passed through.

@ditman thank you. I tried wrapping that over Horizontal Listview and that work really well, so I guess scrolling is also fine.

@ditman, it works really well. Thank you very much.
code snippet
 drawer: MouseClickBoundary(
		clickable: true,
		child: Drawer(
		  child: ListView(

 ...
 floatingActionButton: MouseClickBoundary(
		clickable: true,
		child: FloatingActionButton(

full code
import 'package:flutter/material.dart';
import 'dart:ui' as ui;
import 'dart:html' as html;
import 'package:web_mouse_click_boundary/web_mouse_click_boundary.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
	return MaterialApp(
	  title: 'Flutter Demo',
	  home: MyHomePage(),
	);
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool _isDrawerOpen = false;
  double _drawerWidth = 304.0;

  @override
  Widget build(BuildContext context) {
	return Scaffold(
	  appBar: AppBar(
		title: Text("Drawer Example"),
	  ),
	  drawer: MouseClickBoundary(
		clickable: true,
		child: Drawer(
		  child: ListView(
			padding: EdgeInsets.zero,
			children: <Widget>[
			  DrawerHeader(
				child: Text('Drawer Header'),
				decoration: BoxDecoration(
				  color: Colors.blue,
				),
			  ),
			  ListTile(
				title: Text('Item 1'),
				onTap: () {
				  print("click");
				},
			  ),
			  ListTile(
				title: Text('Item 2'),
				onTap: () {
				  print("click");
				},
			  ),
			],
		  ),
		),
	  ),
	  body: Iframe(),
	  floatingActionButton: MouseClickBoundary(
		clickable: true,
		child: FloatingActionButton(
		  onPressed: () {
			print("click");
		  },
		  tooltip: 'Increment',
		  child: Icon(Icons.add),
		),
	  ),
	);
  }
}

class Iframe extends StatelessWidget {
  Iframe() {
	// ignore: undefined_prefixed_name
	ui.platformViewRegistry.registerViewFactory('iframe', (int viewId) {
	  var iframe = html.IFrameElement();
	  iframe.src = 'https://flutter.dev';
	  return iframe;
	});
  }
  @override
  Widget build(BuildContext context) {
	return Container(
		width: MediaQuery.of(context).size.width,
		height: MediaQuery.of(context).size.height,
		child: HtmlElementView(viewType: 'iframe'));
  }
}

class SecondRoute extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
	return Scaffold(
		appBar: AppBar(
		  title: Text("route test"),
		),
		body: Text("SecondRoute"));
  }
}

@carloshwa Maybe my code does not behave properly in all cases, as you can see it's pretty "generic". For some specific problems, I think it'd be best that we create a separate issue where you can share some snippets of code where the issue is reproducible (without a full app).
I'll try to have this reviewed and merged ASAP, I'm writing some tests for it.
(For everybody, there's a "debug" parameter that should make the boundary visible (red, with 50% opacity), I find it useful when used as the background of a layout element, to see what's really covered/not covered, in buttons, not so much because often the boundary is exactly the same size as the button!)

This is great progress so far, thanks @ditman !

We've just discovered a bug in the flutter web engine that will make the "clickable" property obsolete; I'll remove it from the codebase soon.

The fix mentioned above has rolled to flutter master, so I have removed the "clickable" property from the widget.
The framework should be smart enough to handle the mouse cursor properly. Remember that you can set the cursor property on your HtmlElementViews manually, if needed, like so:
html.Element htmlElement = html.VideoElement()
  ...
  ..style.cursor = 'auto'
  ...;

As suggested by a teammate, I've renamed the widget to PointerInterceptor, and changed it's package name; here's the new pubspec.yaml config:
web_pointer_interceptor:
  git:
    git: https://github.com/ditman/flutter-packages.git
    ref: web-click-boundary
    path: packages/web_pointer_interceptor

This is now a package: https://pub.dev/packages/pointer_interceptor
Thanks everybody for the feedback, I'm closing this issue.

@ditman Do you currently own a house? Can I buy you a house? Maybe a private jet? This is the best package any one has ever made for any language in any universe.
Seriously. It works and the bug has been making me look useless and this works, and it works, and the bug was terrible and this fixes it, and it works.

@ditman Do you currently own a house? Can I buy you a house? Maybe a private jet? This is the best package any one has ever made for any language in any universe.
Seriously. It works and the bug has been making me look useless and this works, and it works, and the bug was terrible and this fixes it, and it works.

LOL thanks @DannyJoinedApps, you made my day :P

LOL thanks @DannyJoinedApps, you made my day :P

@ditman  Hi, first of all thanks for that wonderful package, I am facing some issue, I have 3 HTMLElement view in a screen, and above having DropDownButton the first issue if i wrap PointerInterceptor with dropdown its not working, and then i wrapped PointerInterceptor with child of the DropDownMenuItem there it works as excepted, so the second issue is if i have enabled only one html view its working smoothly if i have enabled all the three views, then i open the dropdown, the page got blinking continuously any idea about this ?

@ThalapathySiva thanks for the kind words!
It is hard to diagnose an issue just with a few descriptions of a sentence, but it might be related to this:
https://github.com/flutter/flutter/issues/71888
Can you confirm it looks similar (and follow #71888) for updates?

@ditman  Thanks for reply, I think its kinda related to that, here i will attach mine.

I have added Pointer Interceptor for dropdownItem text so its just behaving like this even though i didn't hover my mouse. And in my console i am keep on getting  "Flutter: restoring WebGL context".

@ThalapathySiva a quick workaround may be to attempt to build/run your app with --web-renderer html command-line option? It may flicker less.
The flickering that people usually report in flutter web is that HtmlElementViews "reload" (if they contain an iframe, or a text editor, or a video player or similar), not the surrounding flutter UI.
The flickering that you're seeing here, however, looks like a new bug. If you can provide a small example app that displays the problems that you're seeing, we'd appreciate a new bug report for the platform-web canvaskit renderer. You can start reporting a new issue here!
Thanks for reaching out!

@ditman  Sure, can you have any idea about this issue  #78294.Thank you


Enabling the video by a participant triggers participant added event on the other one

Steps to reproduce:

Create a call with two participants
the first participant enables his video
the second participant got a participant added event triggered.

My blueprints:

test

Issue solved.


Update HPWHsim to use btwxt v1.0.0

Convert btwxt calls to updated API.
This initial version duplicates prior functionality by updating btwxt calls.  As with the prior version, no error callback scheme is implemented.  An issue has been added to note this.
All HPWHsim regression test pass successfully.

@chipbarnaby should also update the README reference to the Btwxt version (maybe remove the version altogether?).