Degenerate triangles or wired triangles (wrong topology) generated

Hi, when I use meshoptimizer to optimize terrain, it generated Degenerate triangles or wired triangles (wrong topology, original is regular 2d grid), Is this an known issue?

This is probably the same as #346, but it would help if you could attach the example mesh before the simplification (eg in .obj format) as well as simplification parameters to make sure this is fixed.

gltfpack.exe -si 0.2  -i ./TerrainTest.obj -o ./TerrainSimplified.gltf

Thanks for your reply,
version: version 0.15
cmd: gltfpack.exe -si 0.2  -i ./TerrainTest.obj -o ./TerrainSimplified.gltf
TerrainTest.zip

real world  case: I slightly modified the code to support edge locks and use error instead of target triangle num to simplify mesh.

Oh, I didn't realize you're using 0.15. Since 0.16 meshopt_simplify tries to prevent triangle flips, and since 0.16 it also has an option to lock edges - you might be able to upgrade to 0.18 to resolve these? If you want to simplify to the largest degree possible within a given error you can simply pass target_index_count = 0.

I tried using the new version, using the same input, the result is quite different,  it looks like the error is magnified a lot. and yes, the target_index_count is  set to 0, and use error only.

Oh, I didn't realize you're using 0.15. Since 0.16 meshopt_simplify tries to prevent triangle flips, and since 0.18 it also has an option to lock edges - you might be able to upgrade to 0.18 to resolve these? If you want to simplify to the largest degree possible within a given error you can simply pass target_index_count = 0.

Use ver 0.18, the test obj result is much better, but there are still wire triangles

Hi, I am having the same issue when simplifying a grid-like mesh to half its triangle count (border locking enabled). Some triangles seem to get flipped while other triangles are generated out of nowhere, causing z-fighting. Is there any progress on this issue? I am using the latest version. I can provide an obj file for reference.

@vtroxi If you can provide an .obj file that would help make sure that a fix for this fixes all known instances of the problem.

Great, thanks! The problem in this specific scene seems to be that the triangle can be flipped in two stages - first by getting collapsed to a degenerate triangle (normal = 0), second by moving one of the resulting vertices basically anywhere. In both cases the dot product hasTriangleFlips computes at the end is exactly zero, so it returns false. On your scene the problem is fixed by changing < to <= in condition return nbc.x * nbd.x + nbc.y * nbd.y + nbc.z * nbd.z < 0;.
I will need to look at other examples here to see if this improves them. The "perfect" solution likely requires adjusting the predicate in a more complicated way but that could wait if the simple fix improves the situation without regressing anything.

On the original example scene in this issue the fix also helps although one triangle still gets flipped.
Before (view from below the mesh):

After:

The example in the issue #346 requires a more complex fix to hasTriangleFlip which effectively involves restricting the triangle movement somewhat more severely than we do now, and that involves additional computations. I think I might close this issue with the simple fix and use the other issue to track the more complex one.

Thanks for the investigation! I've already thought that the triangle flip check might be the culprit here. In my own quadric simplifier I've encountered a similar issue and after a lot of trial and error, I've just settled on using a threshold of 0.2 when checking for triangle flips. It might not be a perfect solution but as you've already pointed out, a perfect solution could turn out to be quite complex.
I agree that the simple solution is probably sufficient for now, as it already fixes most of the issues. A more complex solution for better results would be nice to have but I think that most users will probably be fine with "almost perfect" results.

Future improvements to this will be tracked as part of #346 that has a couple examples that don't get fixed by the simple tweak.


Pressure sensor

http://ourhabproject.com/pressure-temperature-altitude-sensor/
Might be neat to have one inside and one outside.

See also #11.


Add Marching Ants animation to docs

Notes for Reviewers
This PR fixes #337
Signed commits

[x] Yes, I signed my commits.

Quality work, @Alero-Awani.
Is there an existing section with code snippet that needs to be replaced?

I thought that we had a yaml or json example in here somewhere. It can make sense to continue to have as a behind-the-scenes way of setting this animation (instead of using the mouse to do it), but we'll need to make sure the it is still set in the same way. I don't think that it is. Soooo, we'll either need to delete or update.

@Alero-Awani
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).
Please add it as an agenda item to the meeting minutes.

@Alero-Awani Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).
Please add it as an agenda item to the meeting minutes.

adding

Quality work, @Alero-Awani.
Is there an existing section with code snippet that needs to be replaced?

@leecalcote This embedded design needs to be replaced with a more complex design. I'll do that and include it in this PR.


GraphQL FilterCriteria does not work well filtering topics

Description
As a Besu user, I want to use graphql endpoint to retrieve data from the ledger following indications from file schema.graphqls, which specify this for FilterCriteria:
# FilterCriteria encapsulates log filter criteria for searching log entries.
input FilterCriteria {
    # FromBlock is the block at which to start searching, inclusive. Defaults
    # to the latest block if not supplied.
    fromBlock: Long
    # ToBlock is the block at which to stop searching, inclusive. Defaults
    # to the latest block if not supplied.
    toBlock: Long
    # Addresses is a list of addresses that are of interest. If this list is
    # empty, results will not be filtered by address.
    addresses: [Address!]
    # Topics list restricts matches to particular event topics. Each event has a list
  # of topics. Topics matches a prefix of that list. An empty element array matches any
  # topic. Non-empty elements represent an alternative that matches any of the
  # contained topics.
  #
  # Examples:
  #  - [] or nil          matches any topic list
  #  - [[A]]              matches topic A in first position
  #  - [[], [B]]          matches any topic in first position, B in second position
  #  - [[A], [B]]         matches topic A in first position, B in second position
  #  - [[A, B]], [C, D]]  matches topic (A OR B) in first position, (C OR D) in second position
    topics: [[Bytes32!]!]
}

When I try to read logs filtering topics without the first parameter, like [[], [B]], it does not return any log.
Example (not work):
query: `{
    logs(filter: {
        topics: [[],["0xE0a68584111D702a141beCB6692631F1Dae4711f"],["0xE0a68584111D702a141beCB6692631F1Dae4711f"],["0x058e6afe3590A7DA1A5Ad7A6fE0df7060c7d12cF"]]
        fromBlock: 0
        toBlock: 500
        addresses: []
    }) {
        topics
        data
        transaction {
            block {
                timestamp
            }
        }
    }
}`

console.log(response.data.logs)
[]

Example (work):
query: `{
    logs(filter: {
        topics: [["0xc3d58168c5ae7397731d063d5bbf3d657854427343f4c083240f7aacaa2d0f62"],["0xE0a68584111D702a141beCB6692631F1Dae4711f"],["0xE0a68584111D702a141beCB6692631F1Dae4711f"],["0x058e6afe3590A7DA1A5Ad7A6fE0df7060c7d12cF"]]
        fromBlock: 0
        toBlock: 500
        addresses: []
    }) {
        topics
        data
        transaction {
            block {
                timestamp
            }
        }
    }
}`

console.log(response.data.logs)
[
  {
    topics: [
      '0xc3d58168c5ae7397731d063d5bbf3d657854427343f4c083240f7aacaa2d0f62',
      '0x000000000000000000000000e0a68584111d702a141becb6692631f1dae4711f',
      '0x000000000000000000000000e0a68584111d702a141becb6692631f1dae4711f',
      '0x000000000000000000000000058e6afe3590a7da1a5ad7a6fe0df7060c7d12cf'
    ],
    data: '0x00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001',
    transaction: { block: [Object] }
  }
  ...
]

Steps to Reproduce (Bug)

Deploy a Besu network with graphql enabled.
Run some contracts.
Call graphql endpoint looking for logs without the first topic filter.

Expected behavior:
Query should return logs according to schema.graphqls comments.
Actual behavior:
Example matches any topic in first position, B in second position does not return any logs.
Frequency: Always
Versions (Add all that apply)

Software version: besu/v22.1.1-dev-1c39d481/linux-x86_64/openjdk-java-11 (and older)
Java version: openjdk version "11.0.13" 2021-10-19
OS Name & Version: "Ubuntu 20.04.4 LTS"
Kernel Version: Linux <IP_ADDRESS>-microsoft-standard-WSL2  x86_64 x86_64 x86_64 GNU/Linux (tested in WSL2 from Windows10 and Windows11)
Docker Version: 20.10.12

@elenaizaguirre we're looking at this issue this week.

@elenaizaguirre this should be fixed now - can you try it out and let us know how it goes? Thanks!


Update/deprecated api docs

Removes docs for notifiers that use v1 of our API. v1 of our API has been shut down.
Adds doc for XML API v2.3 back and updates it.

Originally removed here: https://github.com/airbrake/airbrake-docs/pull/57
Original doc can be viewed here: https://github.com/airbrake/airbrake-docs/blob/3711054d963f3aae289856ffca13b26825359070/jekyll/_docs/api-2/notifier-api-v23.md

Thanks for reviewing, guys! 👍


Not strictly NFC cleanups toward being lint-clean

Only weirdness that jumps out from all of the removed tests for types that don't admit falsy values: this.env is treated as nullable in 686c13c but non-nullable in 0468491 -- should maybe keep the nullability check in 0468491?
All looks good otherwise!

Thanks for looking!

Only weirdness that jumps out from all of the removed tests for types that don't admit falsy values: this.env is treated as nullable in 686c13c but non-nullable in 0468491 -- should maybe keep the nullability check in 0468491?

In sk_runtime (686c13c) env is declared:
  env: Environment | undefined;

while in sk_types (0468491) env is declared:
  private env: Environment;

which is the origin of that oddity AFAIU.


Add cache control configuration option

This issue is a continuation of the discussion from this item regarding adding a new configuration option to be able to set the cache-control header for the importmap.json file.  The default is public, must-revalidate, max-age=0 which results in the file being cached at cloud edge locations for an indeterminate amount of time.
In the linked issue, there was talk of making it a new configuration item.  After reviewing the documentation again, however, I'm wondering if it's currently possible using the s3.putObject property.  So... including something like this in the import-map-deployer's config.json:
{
  "s3": {
    "putObject": {
      "CacheControl": "no-store"
    }
  }
}

@joeldenning Would this work or is there a need to add something new?  Based on how it was coded, it looks like it would work.

It appears that this setting does NOT result in the cache-control header of the importmap.json file be set with an overridden value.
In the thread I linked above, I believe an assertion was made that the import-map-deployer will only be able to set/update the cache-control header value of the importmap.json file if the importmap.json file is living with the import-map-deployer service.  That is not how my system is setup:  the import-map-deployer service is running in an EC2 instance and the importmap.json file is hosted in an S3 bucket.  And yet every time the import-map-deployer is called - even with the s3.putObject configuration described above - the cache-control value for the importmap.json file keeps being reset to public, must-revalidate, max-age=0.

It appears that this setting does NOT result in the cache-control header of the importmap.json file be set with an overridden value.
In the thread I linked above, I believe an assertion was made that the import-map-deployer will only be able to set/update the cache-control header value of the importmap.json file if the importmap.json file is living with the import-map-deployer service.  That is not how my system is setup:  the import-map-deployer service is running in an EC2 instance and the importmap.json file is hosted in an S3 bucket.  And yet every time the import-map-deployer is called - even with the s3.putObject configuration described above - the cache-control value for the importmap.json file keeps being reset to public, must-revalidate, max-age=0.

I'm wondering if it's currently possible using the s3.putObject property.

No this doesn't work - not sure where you got the idea to try it. We don't pass the import-map-deployer config straight through the the AWS SDK.
I think the best approach would be to add a new configuration item called cacheControl. That way we could respect the configuration for other backends, too, not just for S3.
{
  "urlSafeList": ["https://unpkg.com/", "https://my-organization-cdn.com/"],
  "username": "admin",
  "password": "1234",
  "manifestFormat": "importmap|sofe",
  "cacheControl": "public, must-revalidate, max-age=0",
  "locations": {
    "default": "import-map.json",
    "prod": "s3://cdn.canopytax.com/import-map.json",
    "test": "import-map-test.json"
  }
}

I'm wondering if it's currently possible using the s3.putObject property.

No this doesn't work - not sure where you got the idea to try it. We don't pass the import-map-deployer config straight through the the AWS SDK.
I think the best approach would be to add a new configuration item called cacheControl. That way we could respect the configuration for other backends, too, not just for S3.
{
  "urlSafeList": ["https://unpkg.com/", "https://my-organization-cdn.com/"],
  "username": "admin",
  "password": "1234",
  "manifestFormat": "importmap|sofe",
  "cacheControl": "public, must-revalidate, max-age=0",
  "locations": {
    "default": "import-map.json",
    "prod": "s3://cdn.canopytax.com/import-map.json",
    "test": "import-map-test.json"
  }
}

@joeldenning Glancing at the s3.js file, it looked like the following code would use the s3.putObject config to override the default values when writing the importmap.json file:
exports.writeManifest = function (filePath, data) {
  const jsonPromise = new Promise(function (resolve, reject) {
    const file = parseFilePath(filePath);
    s3.putObject(
      {
        Bucket: file.bucket,
        Key: file.key,
        Body: data,
        ContentType: "application/importmap+json",
        CacheControl: "public, must-revalidate, max-age=0",
        ACL: "public-read",
        ...s3PutObjectConfig,
      },
      function (err) {
        if (err) reject(err);
        else resolve();
      }
    );
  });

I guess I'm not reading it correctly?

@joeldenning Glancing at the s3.js file, it looked like the following code would use the s3.putObject config to override the default values when writing the importmap.json file:
exports.writeManifest = function (filePath, data) {
  const jsonPromise = new Promise(function (resolve, reject) {
    const file = parseFilePath(filePath);
    s3.putObject(
      {
        Bucket: file.bucket,
        Key: file.key,
        Body: data,
        ContentType: "application/importmap+json",
        CacheControl: "public, must-revalidate, max-age=0",
        ACL: "public-read",
        ...s3PutObjectConfig,
      },
      function (err) {
        if (err) reject(err);
        else resolve();
      }
    );
  });

I guess I'm not reading it correctly?

@joeldenning would you be comfortable with us writing validation and unit test testing that ensures the following?

a user can only set CacheControl to either

"no-store"
a string ending in "must-revalidate, max-age=0"

I feel that it's important to do this since (from my perspective), the whole point of the import map is that it's fetched fresh anytime an update to it is made.

@joeldenning would you be comfortable with us writing validation and unit test testing that ensures the following?

a user can only set CacheControl to either

"no-store"
a string ending in "must-revalidate, max-age=0"

I feel that it's important to do this since (from my perspective), the whole point of the import map is that it's fetched fresh anytime an update to it is made.

@dgreene1 There are enough options with the cache-control header that I'm not sure the second validation item (a string ending in "must-revalidate, max-age=0") is reasonable unless we would want to be very stringent.  Order doesn't matter for the comma-delimited cache-control directives FWIW.  Also, eg. someone could want to use s-maxage instead of max-age.
If we want to be stringent, we could say the only allowed values are no-store, public, must-revalidate, max-age=0, and maybe no-cache?  Going the other way (which is what my PR currently has), we could not validate at all and put the onus on the consumer to ensure the cache-control header is correct.

@dgreene1 There are enough options with the cache-control header that I'm not sure the second validation item (a string ending in "must-revalidate, max-age=0") is reasonable unless we would want to be very stringent.  Order doesn't matter for the comma-delimited cache-control directives FWIW.  Also, eg. someone could want to use s-maxage instead of max-age.
If we want to be stringent, we could say the only allowed values are no-store, public, must-revalidate, max-age=0, and maybe no-cache?  Going the other way (which is what my PR currently has), we could not validate at all and put the onus on the consumer to ensure the cache-control header is correct.

I guess I'm not reading it correctly? Is this not where the import map is written to S3? I do understand that this would only work for AWS.

@mellis481  it looks like i misremembered the code we had in s3 - yes it looks like we do pass through the s3 options. Not sure why that didn't work for you. I still think the cacheControl option is probably best as a top level config, though, so that it works with all io-methods. I've merged that PR and will release a new version shortly.

would you be comfortable with us writing validation and unit test testing that ensures the following?
a user can only set CacheControl to either
"no-store"
a string ending in "must-revalidate, max-age=0"

@dgreene1 no, I don't think we can safelist all valid cache control headers, as there are dozens (hundreds?) of organizations using import-map-deployer with myriad use cases. Cache busting is notoriously tricky, and I don't think it makes sense for this project to assert that it knows better than its users about how to do it. Providing a good default is important, which I think we are doing. I agree with what @mellis481 said here:

There are enough options with the cache-control header that I'm not sure the second validation item (a string ending in "must-revalidate, max-age=0") is reasonable unless we would want to be very stringent

I guess I'm not reading it correctly? Is this not where the import map is written to S3? I do understand that this would only work for AWS.

@mellis481  it looks like i misremembered the code we had in s3 - yes it looks like we do pass through the s3 options. Not sure why that didn't work for you. I still think the cacheControl option is probably best as a top level config, though, so that it works with all io-methods. I've merged that PR and will release a new version shortly.

would you be comfortable with us writing validation and unit test testing that ensures the following?
a user can only set CacheControl to either
"no-store"
a string ending in "must-revalidate, max-age=0"

@dgreene1 no, I don't think we can safelist all valid cache control headers, as there are dozens (hundreds?) of organizations using import-map-deployer with myriad use cases. Cache busting is notoriously tricky, and I don't think it makes sense for this project to assert that it knows better than its users about how to do it. Providing a good default is important, which I think we are doing. I agree with what @mellis481 said here:

There are enough options with the cache-control header that I'm not sure the second validation item (a string ending in "must-revalidate, max-age=0") is reasonable unless we would want to be very stringent

The cacheControl option was implemented in https://github.com/single-spa/import-map-deployer/pull/89, and fixed in #90. I have released it in https://github.com/single-spa/import-map-deployer/releases/tag/v3.2.0

The cacheControl option was implemented in https://github.com/single-spa/import-map-deployer/pull/89, and fixed in #90. I have released it in https://github.com/single-spa/import-map-deployer/releases/tag/v3.2.0

@mellis481 it looks like i misremembered the code we had in s3 - yes it looks like we do pass through the s3 options. Not sure why that didn't work for you.

I actually think I had a syntax issue. It should work and FWIW it would actually override the cacheControl config value if you also supplied s3.putObject.CacheControl (for AWS only of course). Not sure if this is a concern. If so, we'd just want to move the CacheControl set line in s3.js below the s3Object spreading.

@mellis481 it looks like i misremembered the code we had in s3 - yes it looks like we do pass through the s3 options. Not sure why that didn't work for you.

I actually think I had a syntax issue. It should work and FWIW it would actually override the cacheControl config value if you also supplied s3.putObject.CacheControl (for AWS only of course). Not sure if this is a concern. If so, we'd just want to move the CacheControl set line in s3.js below the s3Object spreading.


…

added an icon to the website for the browser header and made the GitHub logo Clickable

sorry brother.


fix: include schema and notice file in pip package

:tada: This PR is included in version 5.0.0-develop.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


REPL - Could not find constraint in list of versions when library is not cached

(Deno)
Steps to reproduce:

Cache a version of your JSR module.
Publish a new version.
Import the new version inside the REPL or a Jupyter notebook.

There isn't a time frame within publishing of a new version for this issue to happen. It happens even days later as long as it hasn't been cached already.
I can cache it when using deno run or when using the command "Deno: Cache Dependencies". Only Jupyter and the REPL have this issue.

What version of deno are you using?

Oh, nevermind, just read:

I can cache it when using deno run or when using the command "Deno: Cache Dependencies". Only Jupyter and the REPL have this issue.

Seems I can't transfer this to the deno repo, but it's a deno issue and not really jsr.

Should I close it here and reopen in the deno repo?

Opened https://github.com/denoland/deno/issues/22748


jest Not Closing

Environment
Knex version: 0.15.0
Database + version: MySQL 5.7.21
OS: macOS
Bug

Explain what kind of behaviour you are getting and how you think it should do
I'm not completely sure this is a bug or even knex-related, but I thought I'd post this here to at least get confirmation. I'm writing tests using jest where I create a database during globalSetup, and then tear it down in globalTeardown. jest closes as expected when I create and drop the database, but it will hang if I make any queries using knex in my tests. The queries do perform as expected, and don't output any errors

Error message
jest detects an open handle, but it's not related to knex.

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to mysql or postgresql, then single file example which initializes
needed data and demonstrates the problem.

setup.js
import db from '../../src/db'

module.exports = async () => {
  await db.createDatabase()
}

teardown.js
import db from '../../src/db'

module.exports = async () => {
  await db.dropDatabase()
}

db.js
import knex from 'knex'

import knexfile from '../../knexfile'

let pool = knex(knexfile)

// create the connection pool
async function createPool () {
  pool.min = 0
  await pool.destroy()
  pool = knex(knexfile)
}

async function createDatabase (name) {
  const dbName = name || connInfo.database
  const dbConfig = Object.assign({}, knexfile)
  delete dbConfig.connection.database

  // re-create the connection pool with no database name, create the database, and use it
  await createPool()
  await pool.raw(`
    CREATE DATABASE IF NOT EXISTS ${dbName}
      DEFAULT CHARACTER SET = utf8mb4
      DEFAULT COLLATE = utf8mb4_unicode_ci
  `)

  // re-add the database name to the knexfile config
  console.info(`Database has been created: ${dbName}`)
  dbConfig.connection.database = dbName
  await createPool() // re-create the pool using the database once again
  console.info('DONE DONE DONE DONE DONE')
}

async function dropDatabase () {
  // drop the database using the existing connection pool
  await pool.schema.raw(`DROP DATABASE IF EXISTS ${connInfo.database}`)
  await pool.destroy()
  pool = null

  console.info('Database has been dropped')
}

export default {
  createDatabase,
  dropDatabase,

  get pool () {
    return pool
  },
}

Please add single file minimal test case for reproducing the problem without jest. If the problem is that jest is doing something mystic which causes the behaviour then issue should be opened to jest support forum. Also knexfile contents is important to add.
Im 60% certain that you’ll find what is causing the behavior you are experiencing while writing that minimal test case.
I would close this as cannot reproduce for now. There is more info how minimal repro should lopk like in CONTRIBUTING.md

@elhigu Thanks for the heads-up! I created a minimum repo, and couldn't reproduce it myself. I eventually came up with a workaround: create a raw mysql connection to create/drop the database. Then, I added initialize()/shutdown() functions that serve as wrapper functions to create and destroy the pool within along with a few other precautions.

If you or someone else runs into this issue again and can create a reproducible test case we can reopen it.

For those coming here with the same (or similar) issue, "cleaning up" knex in jest is a little confusing.
Your globalTeardown file is the place to empty (or drop) the database.  There is a new connection for each test file, so you need to clean that up separately, with:
afterAll(async(done) => {
   await knex.destroy()
   done()
})

You can either put this in each of your test files, or in a single script that is loaded with setupTestFileAfterEnv in the jest config.

@good-idea Sounds like you are initializing new knex instance (with new pool) in every test file... If you would be using the same knex instance in every test file, then single global .destroy() should be enough.

Long after the battle, but it might still be useful:
@elhigu in fact in jest each test file is executed independently (so that they can be run in parallel). So each creates its own node export singletons, meaning each does indeed have its own knex instance, no way around it...
Here's the jest issue explaining this: https://github.com/facebook/jest/issues/7184
So  @good-idea 's way is the only way as far as I can tell...

Just found this thread. I'm not sure if knex has been updated since but I am trying to add the code snippet from @good-idea's answer but it says that property destroy does not exist on type typeof knex. I have each of my functions that I am testing in a different file which each import a common db.js which exports a function that returns a knex object. I have no access to the internal knex instance that each function is using.


Fix package list for clusters based on CentOS

The client recipe defines a list of packages to install. Both the -devel and -client packages have XtraDB Cluster counterparts, so use them instead if setting up a cluster.

@arnesund thank you very much! I have rebased this on top of the latest master and merged it in as #257.


Export Airbases

Just like the initial export of all units, all airbases should be exported once on mission start. The "base_captured" event should be handled to update captured airbases. We should check, whether we can exclude airbases of type "SHIP" as they should be included in the unit export.

Exported airbases should also show frequencies and tacan on the map


Handling infailed worlds

What is an "infailed" world? Multiverse-Core has never done anything with inventories or god mode.

Sorry for my bad English. Here is my next try to describe it.
The thing I want to report is that if a world is removed (/mv remove) or disabled. Players that logout in these worlds and than log in (now its "infailed" for me, because the world don't exist) they will properly die because they don't move their location and in the other world (default world) the location of the old world is in the underground. So there is nothing that multiverse do but I expected that's multiverse job.
But just forget it. I think you wont do anything. But I can write a plugin on my own that logs the logout world and checks on login, if the world is "infaild" and if that happens I can teleport the player somewhere else. The only problem here I cant get the object address of the unloaded/removed world. So I cant call out an worldchangeevent for other plugins, e.g. Inventory Manager.
If you have an Idea how I can get the World Object of and unloaded world, I would be glad to hear it.
Thanks for all.

You cannot get the World object of an unloaded world.


Defined new revisions for golang dep: github.com/kubernetes/cli-runtime

Ran component through the scanners since I noticed it had not been harvested yet. PR matches curation site. Closing.


Add ContainsPoint trait

Hi! Thank you for helping out with Embedded Graphics development! Please:

[x] Check that you've added passing tests and documentation
[x] Add a simulator example(s) where applicable
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics, simulator, tinytga, tinybmp) if your changes affect the public API
[x] Run rustfmt on the project
[x] Run ./build.sh (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
This PR adds a contains(point: Point) methods to all primitives that are closed shapes. The added Shape trait can be extended in the future to contain additional functions that don't make sense on line like primitives.
@jamwaffles Any suggestions for a better name, or do you think Shape is OK?

Maybe call it ClosedShape? It hints that there's something "special" about the trait (in this case requiring that the shape be closed), as opposed to Shape which is very general.
If the trait is going to only handle collision detection, it might be better to give it a name suiting that purpose instead.

If the trait is going to only handle collision detection, it might be better to give it a name suiting that purpose instead.

I'm not sure yet. Maybe it's better to have more traits with fewer methods each to have fine grained control of which primitive supports which methods. But this would also mean that trait bounds might get more complex.
Should I rename the trait to Contains or maybe ContainsPoint at the moment and rename it later (before the 0.7 release) if additional methods are added?

Should I rename the trait to Contains or maybe ContainsPoint at the moment and rename it later (before the 0.7 release) if additional methods are added?

Yeah, ContainsPoint sounds like a good idea. Can you open a tracking issue so we remember to check before release?

Yeah, ContainsPoint sounds like a good idea.

Changed. Should be ready for review now.

Can you open a tracking issue so we remember to check before release?

I'll add this to my existing tracking issue, because it's directly related IMO.

Looks good to me, but... how do you feel about the semantics of lines? Can't a line contain a point, even with a thickness of 1? That might be an edge case, but a thick line can certainly contain a point, so shouldn't it also implement ContainsPoint?

ContainsPoint is only implemented for unstyled primitives and I would consider an unstyled line to have 0 width.
But testing if a point is on the stroke of a line is a useful feature that could be added later. I'm not sure if it should use ContainsPoint or something specific for lines. Lines could also benefit from line specific features, like testing if a point is to the left or right of the line.

Makes sense to me. Will you implement the same trait for styled primitives too? I don't think that needs a different trait, right?

Will you implement the same trait for styled primitives too?

No, I haven't plan to implement ContainsPoint for styled primitives. Instead there will be different ways of testing if a point is inside a styled:

styled.primitive.contains(point)
styled.fill_area().contains(point)
styled.stroke_area().contains(point)
styled.bounding_box().contains(point)

One useful addition might be a method to test if a point is on the stroke:
styled.is_on_stroke(point) (this needs a better name) which would equal styled.stroke_area().contains(point) && !styled.fill_area().contains(point) for closed shapes, but could also be implemented for lines and arcs.


Section "Configuration" in README.md lacks information

This is my intent (choose one)

[ ] I want to report a bug
[x] I want to request a feature or change
[ ] I want to provide or change a feature

The problem
Currently the documentation for the configuration points to https://github.com/davidtheclark/cosmiconfig whereas it would be much more helpful to have an actual list of supported keys like here: https://github.com/xing/hops/tree/master/packages/preset-defaults
Proposed solution
Provide full list of default keys

@saviomuc we completely rewrote the main readme and just released hops@latest so this issue should now be fixed :tada:


Improve compile instructions

The first time I read this paragraph I did not really understood it. This should help future users understand it a bit better, and ask less support questions, so that you can focus on more productive things than explaining me that I need to increase the number of supported services. :)

@mergify backport main foxy


Investigate Vapor compatibility, and add it if needed.

Hey there. Supporting vapor seems to be a subtask. Chunked uploading is ultimately what we need. With that you could support large files, S3, GCS, etc, etc. Would you be open to a PR for this? I may have time to check it out soon.

I'd LOVE a PR @flexgrip :)


Disable automatic PR builds on the remove environment pipeline

Description
Disable automatic PR builds on the remove environment pipeline
Related issues
Testing

/azp run

/azp run

/azp run

/azp run

/azp run


jenkins show up as 404 when I try to start it

Repro:

Start up kitematic
Search for the jenkins container
Start it

Result:
An error occured: HTTP code is 404 which indicates error: no such container...

Thanks for the issue
Can you check the logs for any issue: cmd+alt+i then click Console

No errors in console.  I did find that this occurs to me in general when I try to add any container.  This was off of a fresh install on OSX 10.10.3
I do have docker and boot2docker installed separately as well

Hi, I did a fresh install of Kitematic on OSX 10.10.3 as well and am getting the same error message on any container that I try and install. I am also seeing nothing in the console.

404 usually means the image pull failed so the image cannot be found. The error message definitely needs to improve.
Taking a look.

Also, if you click the Docker CLI button and then try docker run jenkins, does it work? What is the error?

See my comment here: https://github.com/kitematic/kitematic/issues/584#issuecomment-108435576
It looks like the "404 image not found" is an issue with too many redirects in VirtualBox.
HTH

Same as https://github.com/kitematic/kitematic/issues/588
Temp workaround is there. (Merging threads)
Thanks!

while installing jenkins we are getting HTTP Status 404 - /


refactor: use flake-parts for the flake

Adds flake-parts to use for the flake. Ideally we would make this so that src/modules/top-level.nix is added to imports (with a little wrapper that adds it under dream2nix option), so we completely remove src/default.nix from the picture. I'm creating this as a draft so we can first do that first and then we can merge it. I moved the interface and updaters to modules and separated the flake itself a bit more (templates moved under templates and tests apps moved under tests). src/default.nix is still there but it's probably better to keep it for compat anyways

Maybe at some point we could remove src/lib.nix completely and instead implement makeFlakeOutputs as a wrapper for using the flake-parts module.

Yes, we should do that.

Also I feel the historically grown file structure could be refined. We have:

functions.
dlib.
utils.
dream2nix-interface.

... which I feel overlap a bit and maybe we should not have this separation/or another separation. What do you think? Should we have just anything under functions.{something}.{function} in the future?

We can do that, I just didn't do it right now since I felt changing all the internal stuff in one go would be confusing. We can put all of them under functions and mark most of the functions as internal so that it's apparent it's not meant for public use.

Sounds good. If you can fixed the two commented things, feel free to merge it.


No. of rows shown in comparison are limited to 10.

'Sample Rows with Unequal Values' shows just 10 rows which are different.
I want to see what changed in all the rows in the 2 dataframes, not just 10 rows.
Is there a way I can see all the unequal rows?
Please advise.

Hey there, Thanks for the question.
So I think you could do this in a couple of ways:
This might not be idea but one option if you want to see a specific column and you know the number of records you'd like to sample
compare.sample_mismatch(column="name", sample_count=1000)

Another option is to use:
compare.intersect_rows

intersect_rows gives you a dataframe which you can then check the *_match fields.
3rdly the following will also return more rows if you prefer the reporting format:
print(compare.report(sample_count=1000))

Thanks a lot. I was able to configure my way to see all rows.
I was wondering if there is an effective way to format parts of the compare.report output in a data frame?
I am thinking of converting the output to a CSV and then loading it as a dataframe.
Please let me know if you have a better way of doing it.

@ZlatGod when you say format, what do you mean exactly? Like visual formatting? Or something else. Sorry, just want to make sure I'm understanding correctly

When you see the compare.report output there are a lot of sections in that output.
Some of them are under the following headings:

Columns with Unequal Values or Types
Sample Rows with Unequal Values

So out of all the sections in the output, I just want to capture the output data which is under the above-mentioned headings. Once I capture them, I want to convert it into a dataframe.
Refer the screen capture..might help you figure out. Thanks.

I think compare.column_stats would give you the above in a dict format.
Does that help?

Closing the issue. Feel free to reopen it if you need.

Can I get the full script and How the comparision for large data set with Maximum columns


Assume having C++11 available

This remove old code, for pre c++11 compilers.

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[x] All tests run without failure.
[x] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #813 (4a5d98c) into master (4b85d67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   62.25%   62.25%
=======================================
  Files         291      291
  Lines       23466    23466
=======================================
  Hits        14608    14608
  Misses       8858     8858


computed and collection vars in coverage table working for boxplot

Resolves #1086
This PR incorporates both computed and collection variables into the variable coverage table. In the former case, it's quite straightforward to add any computed var. In the latter case, it's more complicated because we're adding more rows than the current table expects.
To Dos

[x] Have all variables and appropriate numbers show up in the variable coverage table for boxplot
[x] Use display labels for vars in a collection var
[x] Repeat for scatter

For next time

i added an issue for improving the computed variable response. I'll add more details to that issue soon but that should then prevent the web-eda plugins from defining a variableId.

@dmfalke there is definitely more that can be generalized. I'm off next week so i might end up just merging this and making a new tech debt ticket to improve the organization 😞 . I'll link it here if i do! Otherwise i'll work on it when im back!
I have a plan for how to improve it i just didn't get the time this week unfortunately!

That is a-ok with me. Just something to keep in mind as we grow our collection of vizs supporting provided vars


consider removing package-lock.json

As far as I can tell, in the absence of an npm-shrinkwrap.json, the use of package-lock.json in any package published to npmjs.org invites only increased risk of "works on my machine" problems.
Because package-lock.json is explicitly excluded from being published, the main effect is to ensure that the maintainers of a package are using increasingly outdated versions of their dependencies compared to the versions their users end up using the package with.
Am I missing something?

According to git, package-lock.json was last modified 33 hours ago. Deleting it and regenerating it yields this:
$ git diff --stat
 package-lock.json | 37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)


Dual stack config iptables

What this PR does / why we need it:
Before this PR, MY_POD_IP env var was used to determine whether ipv6 nat rules should be configured on the virt-launcher pod.
On dual stack cluster MY_POD_IP will contain only the ipv4 address. So the code has to be changed to support dual stack.
Since there is no env var for MY_POD_IPS and k8s 1.16 doesn't support creating env var using pod.status.podIPs.
This commit changes IsIpv6Enabled to use podInterface addresses.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

virt-launcher support Ipv6 on dual stack cluster.

does the ping for example of test 1780 works between VMs ?
or just manual one ?

please rebase on top
https://github.com/kubevirt/kubevirt/pull/3954
a ping problem might was masked before

/test pull-kubevirt-e2e-k8s-cnao-1.17
/test pull-kubevirt-e2e-k8s-1.17
/test pull-kubevirt-e2e-k8s-1.16

/retest

does the ping for example of test 1780 works between VMs ? (with little manual hack needed, since it doesnt have yet both ips in the vm scheme)
or just manual one ?
i saw couple problems when i did almost exactly that locally, so this why i am asking.

Yes, besides connectivity outside the cluster (which is should have a fix in PR) all the other tests pass.

does the ping for example of test 1780 works between VMs ? (with little manual hack needed, since it doesnt have yet both ips in the vm scheme)
or just manual one ?
i saw couple problems when i did almost exactly that locally, so this why i am asking.

Yes, besides connectivity outside the cluster (which is should have a fix in PR) all the other tests pass.

and the dns as we spoke right ?

does the ping for example of test 1780 works between VMs ? (with little manual hack needed, since it doesnt have yet both ips in the vm scheme)
or just manual one ?
i saw couple problems when i did almost exactly that locally, so this why i am asking.

Yes, besides connectivity outside the cluster (which is should have a fix in PR) all the other tests pass.

and the dns as we spoke right ?

1780 doesn't use dns. I tested in manually on the dual stack cluster. Changed the serverIp on the test to use the vm.status.interface[0].ip[1] and of configureIPv6OnVMI changed it not to check whether ipv6 need to be configured or not but to always configure it.

/test pull-kubevirt-e2e-k8s-1.16

does the ping for example of test 1780 works between VMs ? (with little manual hack needed, since it doesnt have yet both ips in the vm scheme)
or just manual one ?
i saw couple problems when i did almost exactly that locally, so this why i am asking.

Yes, besides connectivity outside the cluster (which is should have a fix in PR) all the other tests pass.

and the dns as we spoke right ?

1780 doesn't use dns. I tested in manually on the dual stack cluster. Changed the serverIp on the test to use the vm.status.interface[0].ip[1] and of configureIPv6OnVMI changed it not to check whether ipv6 need to be configured or not but to always configure it.

1780 i said just as an example of a wider issue, and as we discussed offline there are more DNS places we need to fix.
Some you started, some affect the tests we will fix according needs.

/lgtm

I do suggest to change the commit title and message,
the title isnt accurate since it affect more things
the commit message, is going straight to the 1.16 problem but doesn't explain more than the title said,
but i didnt block on it, its up to you

/test pull-kubevirt-e2e-k8s-1.16

/lgtm

/test pull-kubevirt-e2e-k8s-1.17

/retest

/test pull-kubevirt-e2e-k8s-1.17

/approve
Would we have to do the same for other CNI interfaces which provide an IP?

We don't support ipv6 for such interfaces. Only the primary pod interface (and only masquerade binbding). I hope we will have dhcp server that provides the vm ipv6 information soon and then we can drop the configureIpv6OnVm code.

/retest

Merging some trivial approved PRs to help prow a little.


VS2022 Blazor Razor components not colored when included in the project

This issue has been moved from a ticket on Developer Community.

I have a razor component that I have excluded from the Project.
In the Solution explorer I press the Show all files button to see all the files
I include the razor component that I had excluded before.
Then, the C# in the razor component doesn't get any colors (See image)
Yet another bug in VS2022. I have added 5 new bugs this week alone.

Original Comments
Feedback Bot on 4/27/2022, 00:36 AM:
(private comment, text removed)

Original Solutions
(no solutions)

Putting as 17.3 candidate but not high priority. Workaround is to close and reopen document

When you undelete a deleted file from git (using the git changes), the same thing happens.
Even after closing the file and opening again the colors are all over the place for the undeleted file.

When you undelete a deleted file from git (using the git changes), the same thing happens. Even after closing the file and opening again the colors are all over the place for the undeleted file.

In this instance I was seeing no colors at all. Are you seeing instances where the colors are just permanently off?

Sometimes I see no colors.
Sometimes I see mixed Christmas tree colors.
Sometimes I see the right colors while scrolling and then, when I stop, the colors get messed up.
I don't really understand how many more way of getting it wrong there can be.

Fixed in more recent VS preview builds.


[BUG]Issue connecting ACS to Cognitive Services - Cognitive Services Authentication error.

Similar issue to https://github.com/Azure/azure-sdk-for-net/issues/38573
I have an issue with the Call Automation OpenAI_Sample in Java. I have simply downloaded the sample and built it and deployed it as a Spring Application in my Azure environment.
Library Name and version.
Azure.Communication.CallAutomation 1.1.0 ( I updated the library - the download had a beta version(1.1.0-beta.1) initially but had the same issue with that)
Problem Description
I am getting a 401 with Subcode 8565 but unlike the above referenced issue the voice name is set to "en-US-NancyNeural".
I have connected my ACS resource to my Cognitive Services resource as outlined in the documentation and it appears to be connected in ACS.
When the incoming call arrives I get the following error:
023-11-24T12:27:25.042Z  INFO 1 --- [nio-8080-exec-7] c.c.callautomation.ProgramSample         : Call connected performing recognize for Call Connection ID: 411f3300-c0e2-4530-a4f1-a7e0d95e88ab 2023-11-24T12:27:25.637Z ERROR 1 --- [nio-8080-exec-9] c.c.callautomation.ProgramSample         : Received failed event: Action failed due to a Cognitive Services authentication error. Please check your authorization input and ensure it is correct.
 It mentions a "Cognitive Service Vault Key" but that appears to be associated with the openai service key. I have added my cognitive services key to the "cognitiveServicesUrl"  using the ?key= notation on the url but that makes no difference either.
If I go into speech studio and try out speech recognition and tts using the cognitive resource used above everything works as expected.
Setup (please complete the following information):

OS: Azure Spring
IDE: Eclipse
Library/Libraries: As per the OpenAI call automation example except for the one I upgraded to the latest version.
Java version: 17
App Server/Environment: Azure Spring Container
Frameworks: Spring Boot

Additional context
Add any other context about the problem here.

@juntuchen-msft @cochi2 could you please assist?

I sorted this out myself. The problem was the fact that I had created a Speech Services resource, since the first part of the sample deals with text to speech and speech to text. However, it looks like you need to create a "Multi Service Azure Cognitive Service". Once I did this and connected this to my ACS the sample works.

@JohnMelody Glad you sorted it out. Is there anything we can help from here on?

No thank you. This is working fine for me now. This can be closed.


added explicitArrayProcessor

My specific case has to do with parsing iOS Xcode Storyboard XML, where tag names indicate whether the children will be single or multiple, e.g.
<scenes>
  <scene>
     <objects>
        <view>
          <subviews>
             <subview>
                ...

Using hard set explicitArray to 'true' requires accessing objects awkwardly:
storyboard.scenes[0].scene[0].objects[0].view[0]

Using hard set explicitArray to 'false' will make the code break in different scenarios, depending on whether the parent has a single child or multiple children:
storyboard.scenes[0].scene.objects // works when there's a single scene, breaks on multiple scenes
storyboard.scenes[0].scene[0].objects // ok when there are multiple scenes, breaks on single scenes

I added an option called explicitArrayProcessor that uses a function to determine whether a child element should be part in an array.
The function takes 2 parameters: the parent name and the child element
In my case I just check if the parent's name ends with an 's', and if so I assume child elements should be put in an array.
I think this can be useful in other scenarios as well.

Thought i'd post my validator to accomplish automatic xml => json array processing (including single item arrays) with help from martinandert's super-sweet inflector module... (parsing xml
var inflected = require('inflected');

...

var options = {
    explicitArray: false,
    validator: function(xpath, currentValue, newValue) {
        var currentNodePath = xpath.split('/').pop();
        var currentNodeSingularizedChild = newValue[inflected.singularize(currentNodePath)];

        if(currentNodeSingularizedChild) {
            if(Array.isArray(currentNodeSingularizedChild)) {
                newValue = currentNodeSingularizedChild
            }
            else {
                newValue = [ currentNodeSingularizedChild ];
            }
        }

        return newValue;
    }
};

With this input:
<booking>
  <rentalUnitId>1234</rentalUnitId>
  <trackingNumbers>
    <trackingNumber>
      <name>dejay-A</name>
      <number>1234</number>
      <date>today</date>
    </trackingNumber>
  </trackingNumbers>
</booking>

Results in:
{
    "rentalUnitId": "1234",
    "trackingNumbers": [
        {
            "name": "dejay-A",
            "number": "1234",
            "date": "today"
        }
    ]
}

Is there a possibility to use your validator without the inflected package?


An optional crate feature to switch from Elixir nil to Erlang undefined?

First of all, thank you for creating Rustler! We have been using it since 2019 for Erlang projects, and it is working great.
We are actually using a fork of Rustler because we wanted to use atom undefined instead of nil. We wanted Rultler to encode Rust None into Erlang undefined.
undefined is commonly used in Erlang language and libraries to indicate absence of a value.
For example, if you create an Erlang record (which is just a tuple) without giving values for some fields, these fields are filled with undefined.
%% File: example.hrl
-record(rec, {field1, field2}).

$ erl
Erlang/OTP 25 [erts-13.1.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]

Eshell V13.1.2  (abort with ^G)
1> rr("example.hrl").
[rec]
2> #rec{field1 = 10}.
#rec{field1 = 10,field2 = undefined}
3>

Another example is that there are many functions in erlang module that return undefined if the value is not found. For example, erlang:process_info/2 returns undefined if the process is not alive (doc).
In our fork of Rustler, we directly replaced all occurrences of nil with undefined (diff). It was a quick hack, but worked for us.
Now we are thinking of contributing this feature to the upstream Rustler. We are thinking of adding a crate feature something like erlang-style-encoder to switch from nil to undefined. When the feature is enabled, Rustler will encode Rust None into Erlang undefined.
Does this make sense? Is there any better way to do this? Any feedback is welcome.

Using undefined for None looks useful for Erlang, but a crate feature seems very blunt to achieve this: It disallows mixing nil and undefined, which could be useful when interacting both with Elixir and Erlang records, for example. What do you think about another type, which encodes to undefined? For example, we could have a type struct<T> ErlangOption(Option<T>) which implements AsRef to forward into the inner Option<T>. ErlangOption would then implement Encoder and Decoder itself. Would something like that work for your use case?

It could also be set on the init! macro. In the end, your NIF DLL will be either used from an Erlang or from an Elixir module, very likely not from both, right?

Thank you guys for the comments. I believe both ways should work for our Erlang case. I think ErlangOption would be more flexible than other way: when you use Elixir with Erlang libraries, you may want to interact Rust with both Elixir and Erlang records.
So please assign this issue to me, and let me work on the ErlangOption way. I will create a PR when it is ready.


Somalia Registration SO-MPND

Hi,
Please can the following registration agency be added: http://org-id.guide/list/SO-MPND
Thank you,
Amy

Thanks!


[Title Bar Customization] TAG Security and Privacy Questionnaire

This has been created by cut-and-paste from https://w3ctag.github.io/security-questionnaire/, as requested in the TAG review instructions.

What information might this feature expose to Web sites or other parties, and for what purposes is that exposure necessary?
The feature exposes whether or not the title bar overlay is visible (feature detection) and the size and position of the overlay. The latter could be used to determine the operating system upon which the browser is running.

Is this specification exposing the minimum amount of information necessary to power the feature?
Yes. Both feature detection and position of the overlay are necessary for a developer to customize the title bar region.

How does this specification deal with personal information or personally-identifiable information or information derived thereof?
N/A (this feature does not collect or use personal information)

How does this specification deal with sensitive information?
N/A (this feature does not collect or use sensitive information)

Does this specification introduce new state for an origin that persists across browsing sessions?
No

What information from the underlying platform, e.g. configuration data, is exposed by this specification to an origin?
None

Does this specification allow an origin access to sensors on a user’s device?
No

What data does this specification expose to an origin? Please also document what data is identical to data exposed by other features, in the same or different contexts.
This exposes information to the top level frame only about 1. whether or not the title bar overlay is displayed and 2. the size and position of the title bar overlay. These can be used to determine the platform upon which the browser is running, which can also be determined via window.navigator.platform or window.navigator.userAgent

Does this specification enable new script execution/loading mechanisms?
No

Does this specification allow an origin to access other devices?
No

Does this specification allow an origin some measure of control over a user agent’s native UI?
Yes

What temporary identifiers might this specification create or expose to the web?
None

How does this specification distinguish between behavior in first-party and third-party contexts?
The JS APIs and CSS environment variables describing the title bar overlay will only be available to the top level frame, and therefore, only to the origin for which the web app was initially installed.

How does this specification work in the context of a user agent’s Private Browsing or "incognito" mode?
N/A (PWAs do not support private browsing)

Does this specification have a "Security Considerations" and "Privacy Considerations" section?
Yes

Does this specification allow downgrading default security characteristics?
No

Closing as no additional action/followup appears to be needed.


Misleading error message with missing servicex.yaml

In the absence of a servicex.yaml file defining endpoints, I see the following error message:

ServiceXException: (ServiceXException(...), 'Unable to find name/type uproot in api_endpoints in servicex.yaml configuration file. Saw only names (default) and types (xaod)')

This sounds as if a servicex.yaml file was found, but that my desired endpoint was not included in there. Instead, it would be useful if the error message mentioned that no file was found.

Fixed in 3.0 client


Resizeable and Collapsable sidebar with GridSplitter

Hi!
I'm trying to make a resizeable and collapsable sidebar.
I expect it to have the following behaviour:

A user can resize the sidebar up and down to a particular boundary (i.e. set Min and Max width).
A user can entirely hide (and then show) the sidebar

I use Grid with three columns: one for the sidebar, the second for the GridSplitter to accomplish resize and the third for the main content.
If I configure the Grid like this:
<Grid.ColumnDefinitions>
    <ColumnDefinition Width="Auto" />
    <ColumnDefinition Width="Auto" />
    <ColumnDefinition Width="*" />
</Grid.ColumnDefinitions>

I can successfully resize the sidebar and hide it with IsVisible="True" but it does not have Min Width. If I set MinWidth for the sidebar control
<Panel Grid.Column="0" MinWidth="100" />

I can still resize the leftmost column to the size less than it's content MinWidth.
If I set MinWidth for a Grid Column:
<ColumnDefinition Width="Auto" MinWidth="100" />

The splitter lets me resize the column down to this MinWidth (just like I need), however, when I hide the sidebar with IsVisible="False" the column persists (i.e. blank space with MinWidth is shown).
The splitter is very thin and it is not an option to resize the column to width 0 and consider this as "collapsed" since there is no way to resize it back.
I'm using Avalonia 0.10.0-rc1

Have you find a solution having the same problem ...

Hi there! I'm just experiencing this same behavior right now. Is there a way to hide a resized column in a grid?

There is an expected behavior with the grid. Column can not hidden, if you set MinWidth to it. You need to set it to zero.
Alternatively you can set MinWidth on the child control itself.

SplitView has similar behavior out of box, but without grid splitter

You can Add a Thumb to the GridSplitter which you can use to Resize the Pane.

You can Add a Thumb to the GridSplitter which you can use to Resize the Pane.

Сan you please give an example ?

I solve that issue by applying one of two classes that change the Grid.ColumnSpan attribute:
<Panel>
  <Panel.Styles>
    <Style Selector=".sidebar_open">
      <Setter Property="Grid.ColumnSpan" Value="1"></Setter>
    </Style>
    <Style Selector=".sidebar_close">
      <Setter Property="Grid.ColumnSpan" Value="3"></Setter>
    </Style>
  </Panel.Styles>

  <Grid ColumnDefinitions="*,Auto, 420">
    <Panel Grid.Column="0"
      Classes.sidebar_open="{Binding IsSidebarOpen}"
      Classes.sidebar_close="{Binding !IsSidebarOpen}">
    </Panel>
    <GridSplitter Grid.Column="1" Width="3" MinWidth="1" BorderThickness="0"
      VerticalAlignment="Stretch"
      IsVisible="{Binding IsSidebarOpen}"></GridSplitter>
    <Panel Grid.Column="1" IsVisible="{Binding IsSidebarOpen}">
      <TextBlock>This is the sidebar</TextBlock>
    </Panel>
  </Grid>

</Panel>

``


Fix broken links, remove duplicate variable

Just found a few small things.

@stefansundin Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@stefansundin Thank you for signing the Contributor License Agreement!

Thank you!


Maximum Concurrency option

It'd be useful to have an option to arbitrarily limit the amount of running scripts to a certain maximum, such as 5 or 10.
For the most part, I've been able to rely on --stages to prevent too much from happening at once, but with the introduction of one new package that has no inter-workspace dependencies, it has become too much for the CI server I'm using to handle.

I'm thinking an environment variable would be nicer in this case, WSRUN_MAX_CONCURRENCY.
FYI this is the place in the code that controls this feature:
https://github.com/whoeverest/wsrun/blob/master/src/run-graph.ts#L88

I'd much prefer an argument over an environment variable, but I'd willing to accept both as options.

Alright, made a PR for this for what I would want — feel free to alter and/or merge at your leisure.


how to train on multi classes data?

how to train on multi classes data?

Modify the number of output dimensions of the last layer


Deletion of constants deletes more lines than expected

Fixes: #50 and wp-cli/config-command#101
This pull request addresses the bug where using wp config delete to remove a constant from wp-config.php that includes concatenated functions or complex strings results in the incorrect deletion of more than just the targeted constant.
Current Behavior
Currently, when deleting a constant that includes concatenated functions or special characters, the regex used in the deletion function does not properly isolate the constant. This results in deleting additional lines or even other constants. For example:
define( 'WP_DEBUG', false );
define( 'USER_PATH', '/var/www/' . get_current_user() );
define( 'THIS_AND', md5( 'that' ) );
if ( isset( $_SERVER['HTTP_X_FORWARDED_PROTO'] ) && 'https' === $_SERVER['HTTP_X_FORWARDED_PROTO'] ) {
	$_SERVER['HTTPS'] = 'on';
}
define( 'DISABLE_WP_CRON', true );

Running wp config delete USER_PATH would improperly affect adjacent lines.
Steps to Replicate

Have a wp-config.php file with a constant definition concatenating a function.
Run wp config delete USER_PATH.

Expected Outcome
Only the line defining USER_PATH should be removed, leaving all other settings and definitions intact.
Issue Details
The issue stemmed from the regex pattern used in the removal function, which failed to correctly identify the boundaries of the constant definition when it involved concatenated functions or complex string values.
Proposed Solution
This PR introduces a revised regex pattern that more accurately matches and isolates define statements, even when they contain complex string values or are among multiple statements on a single line. The new regex handles variations in whitespace and formatting, ensuring that only the specific constant is removed.

@shreya0204 Thanks for the PR. Could you please add some tests also?

@shreya0204 Thanks for the PR. Could you please add some tests also?

Can you guide me on how to add?

@shreya0204 Thanks for the PR. Could you please add some tests also?

Can you guide me on how to add for this particular fix?

Tests regarding add/remove config is in this file - https://github.com/wp-cli/wp-config-transformer/blob/main/tests/AddRemoveTest.php This could provide idea for the test implementation. Here are the steps to run test https://github.com/wp-cli/wp-config-transformer?tab=readme-ov-file#testing

@ernilambar I've implemented a new test to ensure the safe removal of constants that have concatenated strings as their values. This test specifically checks that only the targeted constant is removed, and that no additional lines or constants are inadvertently affected during the process.


Using with different IP than from load balancer IP

Is it possible to assign a different IP as the dns endpoint than the K8S load balancer created by ingress?

Yes, you can override the value provided by your ingress controller via the external-dns.alpha.kubernetes.io/target annotation on the Ingress.
Have a look at https://github.com/kubernetes-incubator/external-dns/blob/master/docs/faq.md#are-other-ingress-controllers-supported.

Hi,
It would be nice to set a target ip directly in the deployment which would override the target annotation.
Our usecase there for is separation of concern in a managed environment: platform team knows ip of external LB and development teams know hostnames.
Is such configuration possible?
Thanks,
Jo


Remove maputnik

#265
Before

After

I would keep it. Just like a ref mb specs like mvt, we should link and promote style editing

Sure - I'll leave it to someone else to champion this change if they desire.

I agree that we should link to some style editor from our documentation website @nyurik. But at the moment it looks like maputnik is a maplibre project and it takes a very prominent place on our website, which I think is not accurate.

Thanks for the pull request @birkskyum!

@wipfli please don't self merge.


Update RxJava dependency

RxJava 2.2.3 was released recently. Generally a good idea to keep our dependencies up to date.
Release notes

Should we consider this for 2.2? @muratg?
Filed #3237 for the AzDO failure, which appears to be an unrelated flaky test.

Given that we don't have functional automation here, can you manually verify the updated version? We don't know what, if any, changes may have come in that could break our usage scenarios.

Yeah, I tested the chat sample to verify before making the PR because I had the same reservation as you.

Meh, I'm not going to worry about 2.2. It's not like there's anything here we need. Let's just carry on and merge once the build is green.


CI on Linux and Mac is failing

/home/runner/work/_temp/c/discord_game_sdk.h:222:28: error: expected ';' after top level declarator
/home/runner/work/_temp/c/discord_game_sdk.h:228:17: error: expected ';' after top level declarator
/home/runner/work/_temp/c/discord_game_sdk.h:222:28: error: expected ';' after top level declarator, err: true
/home/runner/work/_temp/c/discord_game_sdk.h:228:17: error: expected ';' after top level declarator, err: true
thread 'main' panicked at 'discord_game_sdk_sys: bindgen could not generate bindings: ()', discord_game_sdk_sys/build.rs:89:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

2.5.7 is broken

Revert to 2.5.6 if you need this to work ASAP, Discord don't seem to be keen on pushing fixes


[Migration]: Awesome migration show cases of Rspack

Manually close for stale. Create a new one if needed :).


ListResponse size

when a paginated json list is retrieved from the Transloadit API, with listAssemblies for example, the method ListResponse.size returns the total number of assemblies owned under the user account. The expected behavior is to return the number of assemblies present in that particular json response.

Both numbers are important and may be used in different scenarios. If one is interested in "the number of assemblies present in that particular json response", they can also use list.getItems().length() at the moment.

Both numbers are important and may be used in different scenarios

Yes this was my thought also, but I think the intuitively, this name list.size might be misleading for the purpose it serves currently. The documentation as a matter of fact is misleading. I was thinking if list.size does the same as list.getItems().length(), since it is already documented to behave that way. Then a method list.totalSize or something could serve for what list.size currently does.

IMO, there is no correct way for how ListResponse#size() should behave but in the ends it's up to each person own preferences. What you should still keep in mind is that such a change would be breaking backwards compatibility and even if the usage for the Java SDK is still low, I would like to avoid this.

closing this based on Marius' comment


Throw on invalid package target

Node throws ERR_INVALID_PACKAGE_TARGET when a package target doesn't start with ./.
resolve.exports doesn't throw anything.
const pkgJson = {
  exports: {
    './a': '../b',
    './c': 'd',
  }
};

resolve(pkgJson, './a'); // passes but not allowed by node
resolve(pkgJson, './c'); // passes but not allowed by node

Ref:

https://nodejs.org/api/esm.html#esm_resolver_algorithm
https://github.com/nodejs/node/blob/2af43f65055de2817eb7907d3a3d3b3a3de127f5/lib/internal/modules/esm/resolve.js#L368

This module is not a validator –  only resolves existing exports mappings & returns what's defined.
Because the value is returned as defined (except subpatterns, which are evaluated), this is trivial to apply on the returned output string.

This module is not a validator –  only resolves existing exports mappings & returns what's defined.
Because the value is returned as defined (except subpatterns, which are evaluated), this is trivial to apply on the returned output string.

Thanks for the explanation! Perhaps you could put a non-goals section inside the README so that people know exactly which parts of the Node exports resolution ("resolution" might not be the best word as sometimes resolvers include validation and sometimes they don't) they have to implement themselves.

Thanks for the explanation! Perhaps you could put a non-goals section inside the README so that people know exactly which parts of the Node exports resolution ("resolution" might not be the best word as sometimes resolvers include validation and sometimes they don't) they have to implement themselves.


Rename to eslint-plugin-no-arrowception

Shouldn't this be named after the plugin guide of ESLint?
http://eslint.org/docs/developer-guide/working-with-plugins
Or is there some higher plan to have a group of rules, which you then provide via plugin?

This is just a standalone rule, not a plugin. It is part of eslint-plugin-hapi. If you're interested in using it in a plugin of your own, here is an example of how to do it https://github.com/continuationlabs/eslint-plugin-hapi/blob/master/lib/index.js#L13.

Thank you for the clarification @cjihrig


[C++] Support predicate pushdown for timestamp and string types in Parquet Scanner

Describe the enhancement requested
I am using version 8.0.0. And I use Scanner class to read Parquet files.
When I read datas about timestamp or string types, I use TimestampScalar or StringScalar as predicate value, less or greater functions in expressions.h to organize filter expressions. I add these expressions to the ScanOptions.filter.
select timestamp_col, string_col from parquet_file;  -- query1
select timestamp_col, string_col from parquet_file where timestamp_col < '2020-01-01';  -- query2
select timestamp_col, string_col from parquet_file where string_col > 'hello';  -- query3

Although the query results are correct, queries 2 and 3 take longer than query 1.
This indicates that queries 2 and 3 scan all data into memory before filtering, rather than avoiding scanning unnecessary row groups  by predicate pushdown first.
I make sure that these queries filter some groups of rows in my parquet data by predicate  pushdown.
And I also tested the int32 type, which is able to do predicate pushdown.
So could you please support predicate pushdown for timestamp and string types in Parquet Scanner？And more, please support decimal, interval, date and other types.
Or this is just not supported in version 8.0.0. Please tell me which Arrow version supports predicate pushdown about these types.
Component(s)
C++

I think we might need more details or a reproducing script of some kind.  Here is a quick experiment I ran:
import pyarrow as pa
import pyarrow.compute as pc
import pyarrow.parquet as pq
import pyarrow.dataset as ds
import shutil

shutil.rmtree("/tmp/my_dataset", ignore_errors=True)

values = list(range(100))

int_col = pa.array(values, pa.int64())
ts_col = pc.cast(int_col, pa.timestamp('us'))

table = pa.Table.from_arrays([int_col, ts_col], names=["ints","timestamps"])

ds.write_dataset(table, "/tmp/my_dataset", format="parquet")

my_dataset = ds.dataset("/tmp/my_dataset")

# Prime the query once to load parquet metadata into memory
my_dataset.to_table()

big_ts = pc.cast(pa.array([1000], pa.int64()), pa.timestamp('us'))[0]
print("WITH FILTER")
print(my_dataset.to_table(filter=pc.field("timestamps") > big_ts))

print("WITHOUT FILTER")
print(my_dataset.to_table())

I then tested this with strace using the command strace -f -P /tmp/my_dataset/part-0.parquet python repr.py:
WITH FILTER
pyarrow.Table
ints: int64
timestamps: timestamp[us]
----
ints: [[]]
timestamps: [[]]
WITHOUT FILTER
[pid 43296] openat(AT_FDCWD, "/tmp/my_dataset/part-0.parquet", O_RDONLY) = 7
[pid 43296] newfstatat(7, "", {st_mode=S_IFREG|0664, st_size=2111, ...}, AT_EMPTY_PATH) = 0
[pid 43296] newfstatat(7, "", {st_mode=S_IFREG|0664, st_size=2111, ...}, AT_EMPTY_PATH) = 0
[pid 43314] pread64(7, "\25\4\25\300\f\25\266\6L\25\310\1\25\4\22\0\0\240\6\0\0\r\1\0\1\r\10\0\2\r\10\0"..., 595, 4) = 595
[pid 43314] pread64(7, "\25\4\25\300\f\25\266\6L\25\310\1\25\4\22\0\0\240\6\0\0\r\1\0\1\r\10\0\2\r\10\0"..., 595, 695) = 595
[pid 43314] close(7)                    = 0
pyarrow.Table
ints: int64
timestamps: timestamp[us]
----
ints: [[0,1,2,3,4,...,95,96,97,98,99]]
timestamps: [[1970-01-01 00:00:00.000000,1970-01-01 00:00:00.000001,1970-01-01 00:00:00.000002,1970-01-01 00:00:00.000003,1970-01-01 00:00:00.000004,...,1970-01-01 00:00:00.000095,1970-01-01 00:00:00.000096,1970-01-01 00:00:00.000097,1970-01-01 00:00:00.000098,1970-01-01 00:00:00.000099]]

I also verified with a debugger that the row groups are not actually being read.

Yes, you are right. I'm sorry. When I build the expression, I set the wrong types.


Retry backup deletion based on the resync mechnism

Longhorn/longhorn#5458

cc @innobead

It can be tricky since, even if the function returns true, it still includes a message to explain what's happening. Therefore, the message is wrapped as an error. To avoid any confusion, could rename the function to below.
func (bc *BackupController) isBackupNotBeingUsedForVolumeRestore(backupName, backupVolumeName string) (bool, error)


Add Dockerfile and post to dockerhub

This seems supernice. So nice that I want to be able to run it on my server and develop in that instead of on a local computer.
I've created a Dockerfile that works for this.
FROM python:3.9

RUN pip install 'cadquery-server[cadquery]'

RUN apt-get update && apt-get install -y \
	libgl1 \
	libgl1-mesa-glx \
	&& rm -rf /var/lib/apt/lists/*

RUN mkdir /data
WORKDIR data

RUN echo "import cadquery as cq\nfrom cq_server.ui import UI, show_object\nshow_object(cq.Workplane().box(10,10,10))" > /data/main.py

ENTRYPOINT ["cq-server", "/data"]

So base the entire thing on the python image (which is based on debian), install libgl, create a folder where cq-server will look for files and create a little default example. The example is just a nice add for those that forget to mount /data to something.
This still allows you to use all the flags that cq-server has. So docker run cq-server --ui-theme dark still works for example.
Given this if you accept the proposal, you could use GitHub Actions to build the image and publish it to DockerHub so users could just do docker pull roipoussiere/cadquery-server (or cq-server).
The resulting docker image is about 2.72 GB, but I don't think it's possible to really reduce it without loosing anything.
Thoughts?

Now that #11 is merged, what are your thoughts about adding GitHub Actions to automagically build and push to dockerhub when there is new stuff in main?
And perhaps also tag images with the releases.

I updated the docker file to load cq-server files locally instead from git (1e8e4ce).
This way it's really fast to rebuild the image when developing and we don't have git dependency.
I also added instructions on readme (47def65).
The image on the docker hub is now updated with the last version. You can give a try:
docker run -p 5000:5000 -v $(pwd)/examples:/data cadquery/cadquery-server

So I'm going to close this, please create a new issue about the CI. :)


ignore the ssl certificate errors so that sites with self-signed certificates can be checked for availability

Is your feature request related to a problem? Please describe.
the checks against https with a self-signed certificate fails.
Describe the solution you'd like
ignore the ssl certificate validation so that those check will check the connection/availability of the service, not the certificate
Describe alternatives you've considered
ignore the ssl certificate errors
Additional context

Duplicate of #28.
Ignoring SSL certificate errors is not in the scope of this project. There are ways to let ciao trust self-signed certificates, one of them described in this comment https://github.com/brotandgames/ciao/issues/28#issuecomment-517901990.

Sorry for digging this, but I also feel that this should be a feature. Ciao is such a simple service and having to trust a self-signed certificates every time a Docker container gets updated, for example, and unfortunately some of them do create new certificates, is far from simple.
Also a 401 response is, some times, the correct response if the user is not signed in. Ciao shows these with a yellow badge and calls the eye, when it's just the way it should be.


Create generic Apollo SSR client factory package

Moves/consolidates the generic Apollo client factory logic to its own package so it can be used by other SSR Apollo clients.

 Robust site search with flexibility to search only certain sections


Refactored c'tor bodies to MakeValueProto() function.

This refactoring makes all constructor bodies look the same: 1 statment
setting the type_ member using MakeTypeProto(), and 1 statement
setting the value_ member using MakeValueProto(). This way we can
re-use the make-a-value-proto logic without having to invoke the
constructor then steal the value_ data member from it.
This refactoring was done in preparation for adding Spanner Struct
support, which I suspect will involve some form of std::typle, which
should work well with helper functions like this.
modified:   value.cc
modified:   value.h

This change is

PS: There are some tidy errors.


Testing with LightHouse Shows I don't have SW registered and fails to respond with

I tested with Lighthouse on this site https://shopping-list.now.sh/ and it says no service worker registered and it fails to return 200 when offline. If I test manually it shows that it installs a SW. I don't know if it's Lighthouse not detecting.

I'm not seeing that:

If you continue to see issues, it's probably worth raising a bug against the Lighthouse project.

Oops sorry I travelled and couldn't connect to the internet. Yeah I fixed what was causing it. I had some bad setup with requireJS which made the app take so long to load. Thanks!


access: approver

See https://go.dev/wiki/GerritAccess
Hello Go release team,
I am kindly requesting Approver access as we need more people to approve changes coming in from the ppc64le side
Group URL: https://go-review.googlesource.com/#/admin/groups/1005,members
Gerrit email address<EMAIL_ADDRESS>The following summarizes my contributions towards golang so far,
https://go-review.googlesource.com/q/aravind5
https://go-review.googlesource.com/q/aravinda

Related Issues and Documentation

access: may-start-trybots #52070 (closed)
access: may-start-trybots #61553 (closed)
access: approvers #28469 (closed)
access: Approver #59102 (closed)
access: approver/trust for ppc64 related changes #47644 (closed)
access: Approving CLs ("approvers") #56321 (closed)
access: approvers + may-start-trybots #30297 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Your request has been reviewed and approved. You should now be an approver. Please comment here if you run into any problems. Thanks for your contributions!


[Papercut] Improved Theme.php (changed default values)

Description

Added "themeFontDefaults" Array
Replaced strings with array data from defaults array

Please describe your pull request:

What does it improve?
Makes better use of variable $themeColorDefaults and increases clearity and comprehensibility.
Removes duplicate values when already exists and declared.

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
No

How to test?
Reload themes in backend theme manager

Changed to integer

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-17254.
Please use this issue to track the state of your pull request.


babel-runtime

Question: use babel-runtime + runtime transformer instead of importing specific polyfills for Map, Set, etc.?
Could set as a peerDependency so installation is up to the user to determine necessity (wouldn't be required once Node fully implements all ES6 runtime features).

going to flip back to explicit polyfills. may open up Babel 6 as an option.

just kidding, Babel is there so that I don't have to think about legacy and so I can stop supporting Node 0.10 without making code changes.


attach domain field to shorten request data packet

restore when https://github.com/thedevs-network/kutt/issues/287 is resolved

As a workaround, the request body is not set to send field domain if it is same as the Host domain
For example, if the default host url is https://mycustomkutt.it and user opts this domain in the select menu, the domain field is not attached to the API request body.


Designer & linguist features off

Dear Feedstock developers,
I've noticed the "-DFEATURE_designer=OFF" and "-DFEATURE_linguist=OFF" CMake switches in the build.sh and bld.bat build scripts in the qt6 branch. Would it be possible to ship these two tools too? It turns out that the uic tool if PySide6 cannot be compiled without these, and therefore developing a Python program with PySide6 in a conda environment is a major pain. Or is there some reason, e.g. filename clashes between packages?
Thank you for your considerations.
Regards,
Andras

it was too long to build within the allocated CI time

Thanks @jschueller for your quick reply. Is this problem persistent? If yes, can these (and probably other) tools be split into a different package?


add CD2H logo to website

Please report the issue under the apppriate header below.
Content to be added or changed:
add CD2H logo to website

@mellybelly need clarity as to where this should go (at bottom of the page?) and should this include a funding statement?

It needs a funding statement as well, yes please. I think it could go in multiple places - potentially at the footer and in the contributors/attributions? depends on layout.
Here is the funding information and we can link to the CD2H website as well.
Funded by NIH U24TR002306
https://ctsa.ncats.nih.gov/cd2h/

@jaeddy can you work on this one?

I created a PR to add the logo to the repo
#129

@jaeddy once you have clarity on what other orgs logos we need feel free to comment here and the corresponding PR

Done!


bootstrap-select not showing

First of all, thanks for very nice plug-in!
I am trying to use the bootstrap-select but have a problem.
Basically, I load .html page when user selects a menu in my navigation bar.
If I put the bootstrap-select inside body in my index.html, it works.  However, If I put it in other .html (for example weekly.html) file where it is being loaded into #pageContent, the dropdown doesn't show.
Is there anything I am missing here?
Archive.zip

Hello!
I fixed the issue by adding this after the AJAX load.
Thanks!
        $('.selectpicker').selectpicker({
            style: 'btn-primary',
            size: 10
        });


bug: Ionic push google-api-key uncaught exception

Type: bug
Platform: android 5.x webview
Hello,
I've tried to use the push api. It worked on dev mode. But when I try to set the google-api-key for production mode, an error occured :
ionic push --google-api-key xxxxxxxxxxxx
An uncaught exception occurred and has been reported to Ionic

Cannot read property 'on' of undefined (CLI v1.6.4)

Your system information:

Cordova CLI: 5.1.1
Ionic CLI Version: 1.6.4
Ionic App Lib Version: 0.3.8
OS: Windows 7 SP1
Node Version: v0.12.7

I use a non standard structure for my project  https://github.com/Justin-Credible/Ionic-TypeScript-MDHA-Starter
Is there a way to set the google api key manually ?
Thanks in advance !

Greetings @arthurvirus!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

An uncaught exception occurred and has been reported to Ionic
Cannot read property 'on' of undefined (CLI v1.7.7)
Your system information:
Cordova CLI: 5.3.3
Ionic Version: 1.1.0
Ionic CLI Version: 1.7.7
Ionic App Lib Version: 0.6.3
OS: Windows 7 SP1
Node Version: v4.2.1
I am also facing similar error? any solution for this?

Please file here: https://github.com/driftyco/ionic-io-issues/issues


Update README.md

Appveyor badge shows cancelled so i removed it!

We'll be normalizing the project coming up soon and applying the template is easiest if the stuff remains the same.


Use setup-go action to cache dependencies

Description
I changed the workflow to cache dependencies using actions/setup-go. actions/setup-go@v3 or newer has caching built-in.
AS-IS
- name: Install Go
  uses: actions/setup-go@37335c7bb261b353407cff977110895fa0b4f7d8
  with:
    go-version: ${{ matrix.go-version }}

TO-BE
- name: Install Go
  uses: actions/setup-go@268d8c0ca0432bb2cf416faae41297df9d262d7f
  with:
    go-version: ${{ matrix.go-version }}
    cache: true

It’s literally a one line change to pass the cache: true input parameter.

References

https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows
https://thearchivelog.dev/article/caching-dependencies-to-speed-up-workflows/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Revert: KVIRT-237-upgrades to resolve vulnerabilities in hostplumber

Codecov Report
Patch and project coverage have no change.

Comparison is base (84bd4a9) 0.00% compared to head (9fef850) 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #97   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files           1       1
  Lines         664     664
======================================
  Misses        664     664

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cookies

When on my website I login to my profile and the browser gets a session coookie - the browser-sync dont get it ... so I'm not login.
Maybe there is a way to transfer cookies from my website when I use a config file with proxy mode in browser-sync?

@shakyShane I'm using 1.9.1 and still have problems with cookies.
We have a staging site at http://our.internal.staging:4000 where we login and get cookies. Now I'm developing a new project on http://our.internal.staging:5000 using BrowserSync and the requests aren't sending out with the cookies attached and I failed to log.


[5.1] Gelf logging handler for Monolog

This PR is adding support of Gelf log format. It allows to send logs to popular Graylog and Logstash logging servers. I suppose it will be one more step for Laravel towards easy multi-host cloud deployments.
To enable log formatter developer should change config/app.php
    'log' => 'gelf',
    'log_gelf_host' => '<IP_ADDRESS>', // required
    'log_gelf_port' => 12201, // optional, 12201 by default
    'log_gelf_protocol' => 'udp', // optional, "udp" (default) and "tcp" supported

To make it work, please make sure you have graylog/gelf-php package installed
composer require graylog2/gelf-php

The amount of logging configuration options people are suggesting lately is almost making me want a separate logging config file in 5.2.

This would probably be good as a package.


magnify2 tool

This version of the magnify tool renders the image in the target scale in a different element, and then copies pixels from it, therefore it can reach up to the resolution of the original image. This addresses issue https://github.com/chafey/cornerstoneTools/issues/182
.
An example can be viewed at
https://rawgit.com/diego0020/cornerstoneTools/magnify2/examples/magnify2/index.html

Excited to see a PR for this! Thanks for your hard work, @diego0020 👍

This is great! If possible it would be better if we could replace the current magnify tool with this. We could put it behind a configuration flag or something so that it's not a breaking change for now. Maybe we should also add a CR or MG to make the demo better.

@diego0020, heads up. drawMagnificationTool is called by magnifyTouchDrag's dragCallback. However, it depends on zoomCanvas being initialized to properly render.
The only place zoomCanvas is ever initialized is in the drawZoomedElement method, which is only ever called by the mouse tool. This means that the touch version of this tool never renders a magnified version (returns prematurely).

You are right.
Is there a similar method for touch tools?
On Tue, 21 Nov 2017 at 09:45 Danny Brown<EMAIL_ADDRESS>wrote:

@diego0020 https://github.com/diego0020, heads up. drawMagnificationTool
is called by magnifyTouchDrag's dragCallback. However, it depends on
zoomCanvas being initialized to properly render.
The only place zoomCanvas is ever initialized is in the drawZoomedElement
method, which is only ever called by the mouse tool. This means that the
touch version of this tool never renders a magnified version (returns
prematurely).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chafey/cornerstoneTools/pull/286#issuecomment-346047902,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG9ZqkUPzjzHJLsK9fLz4dcFlm51BeFyks5s4uHxgaJpZM4QcW6T
.

@diego0020, this is untested, but you could probably do something like...
function touchStartCallback (e, eventData) {

  const element = eventData.element;

  if (eventData.isTouchEvent === true) {
    external.$(element).on('CornerstoneToolsTouchDrag', eventData, dragCallback);

    currentPoints = eventData.currentPoints;
    drawZoomedElement(e, eventData);
    // On next frame
    window.requestAnimationFrame(() => drawMagnificationTool(eventData));
    external.$(element).on('CornerstoneNewImage', eventData, newImageCallback);
  }
}

And change:
const magnify2TouchDrag = touchDragTool(touchStartCallback, options);

I ended up using an approach similar to crosshairs tool. I tested it on my phone and it is working, but I would appreciate additional testing.

The implementation looks like it should work just fine. I'll load it locally and give it a spin when I get some downtime this week. Thanks for the hard work, @diego0020!

I've added a few comments, but nothing major is jumping out at me. This should be good to merge if we:

Replace the magnify implementation with the magnify2 implementation
Implement the small changes/suggestions, or provide good reasoning for why we should not

Yeah we can remove the old one. I've asked @galelis to take the PR from here and get it integrated. Thanks @diego0020!


Integrate Lanyard to have a "current status" widget

see
https://api.lanyard.rest/v1/users/511724576674414600 (my discord id)

Also see
https://gist.github.com/dustinrouillard/8140fd47c5900d4421637b098b6d92c0
https://lanyard-visualizer.netlify.app/511724576674414600

These can be fetched through the discord media proxy : https://media.discordapp.net/${activity.assets.large_image.replace("mp:", "")}
or without the discord media proxy if you don't want it, but with it, it keeps the end user's ip hidden from the server hosting the image, since that's not discord for the mp:external assets.
activity.assets.small_image.startsWith('mp:external') ? activity.assets.small_image.replace(/mp:external/([^/]*)/(http[s])/g, '$2:/')
: https://cdn.discordapp.com/app-assets/${activity.application_id}/${activity.assets.small_image}
Of course this is only targeting small_image but you can also use the same for large_image
and this section of code will use the external link if external, or the app-assets if it's an app asset


list all objects once at init time

Now informer just watch for new event, but If the controller crash and restart, events triggered between down time should have a chance to to resolved.
So I suggest add some function, so that we can list all the objects at initiate time.

You need to track a resourceVersion to ask when to start getting events from. Too early is not always possible. Did you try https://docs.rs/kube/0.15.1/kube/api/struct.Informer.html#method.init_from ?.

In fact, I just want get the latest version once, but I didn't know the version when the informer is crashed or closed, so I can't use init_from with a version

In another world, I hope the informer can send me all the objects I watched once.

I hope to get something like this:
fn list_resource(&self) -> Result<(Vec<WatchEvent<K>>, String)> {
        let req = self.resource.list(&self.params)?;
        let events = self.client.request_events::<Object<P,U>>(req)?;
        for e in events {
            self.events.write().unwrap().push_back(e);
        }
    }

@clux Do you have any suggestion?

Hm, not sure I completely understand. You want list_resource to return all events "you watched once". I'm not sure what you mean by that. Also I don't know what your String return type is meant to be. The resourceVersion?
Maybe you need to track that in your app if you depend on not double handling resources.
Is there a standard way in go that you know this is supported?

I found out that it is  controller-runtime who did this thing. Maybe we just need to add lister for informer.

Are you wondering about how to list the resources before starting to watch changes? E.g. here is a List and then Watch implemented using client-go:

Most operators work by initially loading all relevant instances of a resource by using an initial List() call, and then subscribing to updates using a Watch() call.

I also agree that usecase could be shown in the watch example, it's not just about crashing, it's when you start the informer.

@Ciantic  Yes, I solve this issue by list of the resources myself before start informer. It could be better if the informer have this feature.

This should work better in 0.22.0 now because poll is streaming and we update the version between every received event.
Thus, if there's an error, the next .poll() will just continue from the last seen resourceVersion. However, if we get a 410 Gone, we still reset the resourceVersion` to latest; because there's nothing else we can do when we've gone out of history (Bookmarks #54 are meant to make this problem better in the future).
Current behavior: https://github.com/clux/kube-rs/blob/f71e7243ecdf4cd7513f03bb287eac1982c178cd/src/api/informer.rs#L174-L185
If your controller / app outside kube-rs has a chance of crashing, then you need to save the .version() somewhere and feed that into Informer::init_from for your next reboot (and hope that you haven't gone out of history).

My initial advice was to give all the objects with the latest verison in the streaming when the informer was initialized. It doesn't matter with the revision of one object. But I think it could also be done by the controller / app outside rube-rs. So I think I could close this issue.
But I think the work you've done in 0.22.0 would still be very helpful!
Thanks again! @clux


Add debug option to show href-links on hover

By setting parameter DBT to HREF, you can quickly view the href-target on any link included in the abapGit UI. You just have to hover over the link.
Examples:

Looks like a nice feature :+1: