Adding a tag flag to override default imgpkg bundle tag

Adding a tag flag to override default imgpkg bundle tag
What this PR does / why we need it:
Today, by default, pkg release while generating imgpkg bundle add bundle-<TIMESTAMP> as tag. This PR adds a flag to pkg release which will override that tag with the flag value.
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?
Yes
Additional Notes for your reviewer:
Review Checklist:

[x] Follows the developer guidelines
[x] Relevant tests are added or updated
[x] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[x] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

Not sure if you have raised it but it does not seem to be mentioned in this thread, we should merge it away with this PR if it is up


chore: Add mock LLM for test purposes; Enable multiple step() calls in test units to enhance test robustness

Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
close #364  close #1047

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.

Thanks @lllllyh01, but I think there are some changes needed to be made:

we already have a model named StubModel, which is also used as a dummy model for testing.
In the future we want to replace the StubModel with mock because containing test codes in delivered codebase will cause confusion and is not a good practice. We think it's better to keep dummies inside the test module. Here is an existing example using mock for backend models, FYR: https://github.com/camel-ai/crab/blob/main/test/agents/backend_models/test_openai_model.py
For multiple step tests, I think one important goal is to make sure the state of ChatAgent is not changed unexpectedly (implicitly) after calling each step(), i.e. step() should have no side effects on the agent and model, especially the configurations. Therefore, I think the test case should be more focused on this part, while the response content is actually not important. To be clearer here are some bugs related to this we found before: [BUG] O1 Preview Model Will Raise KeyError #1044 [BUG] Tools will be invalid after calling step() with output schema #894

I know this issue could be tricky to fix, please feel free to reach out if you get stuck or want to have further discussions :)

Got it, I'll modify this pr accordingly. Thank you for your further explanation!

Thanks @lllllyh01! Should we refactor StubModel for this since they are used for the same propose?

Hi @lightaime , thank you for your comment! Yes I think we can integrate the FakeLLMModel into StubModel. I will refactor it. I'm also trying to use Mock() instead of stub model according to @WHALEEYE suggestions.
This pr is still working in progress and may need some more time to be ready, but please let me know if there are any further comments or suggestions.


[core] Dogs not appearing

OS: Windows 11, 64-bit, AMD
Dogs are not appearing when I enter cargo run. Can't find the cause of this bug.

Update: After commit ea2250a, "Hello, dogs!" is appearing but not cute enough


Add Source Generated code to git

This PR adds the output from source generators into the git source control, so that actual changes to the generated code can be tracked.

Codecov Report
Base: 87.46% // Head: 86.02% // Decreases project coverage by -1.45% :warning:

Coverage data is based on head (329af3f) compared to base (e1656ad).
Patch coverage: 77.31% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   87.46%   86.02%   -1.45%
==========================================
  Files         186      197      +11
  Lines        4972     5783     +811
  Branches     1167     1363     +196
==========================================
+ Hits         4349     4975     +626
- Misses        335      460     +125
- Partials      288      348      +60

Impacted Files
Coverage Δ

...rLinq.Generator/SuperLinq.Generator/Cartesian.g.cs
47.85% <47.85%> (ø)

...nerator/SuperLinq.Generator/ToDelimitedString.g.cs
53.57% <53.57%> (ø)

...ync.Generator/SuperLinq.Generator/ZipShortest.g.cs
66.66% <66.66%> (ø)

.../SuperLinq.Generator/SuperLinq.Generator/Fold.g.cs
72.91% <72.91%> (ø)

...Linq.Async.Generator/SuperLinq.Generator/Fold.g.cs
76.78% <76.78%> (ø)

...sync.Generator/SuperLinq.Generator/ZipLongest.g.cs
80.95% <80.95%> (ø)

...q.Async.Generator/SuperLinq.Generator/EquiZip.g.cs
84.21% <84.21%> (ø)

...rLinq.Generator/SuperLinq.Generator/Aggregate.g.cs
100.00% <100.00%> (ø)

...perLinq.Generator/SuperLinq.Generator/EquiZip.g.cs
100.00% <100.00%> (ø)

...Linq.Generator/SuperLinq.Generator/ZipLongest.g.cs
100.00% <100.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Can't edit Edges in WebView (any more?)

My Environment

ArangoDB Version:        3.4.1
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   Manual Start in Docker
Operating System:        Ubuntu 18.04
Disks in use:        HDD
Used Package:              Ubuntu

Component, Query & Data
Affected feature:
Graph Viewer
Problem:
Maybe my memory is playing tricks to me - but I have the feeling I used to be able to edit Edges in the Graph Viewer.
Right now (login as root) I'm just able to modify documents. A click on the Edge gives me on the bottom part information on the key and which attribute it has, but no option to do modifications.
The routeplanner-example for instance has this option.
On which parameter does it depend whether or not I'm able to edit it?
Thank you

If you click on an edge, a radial menu with two options should pop up:

A click on the pencil icon opens the inline document editor.
Is is pencil option missing for you? Can you post a screenshot?
If it occurs with a specific graph only, can you share it?
You can try the latest version and another browser to see if it makes a difference.

This is getting more and more weird.
Test 1:
Regularly opening the graph and clicking on the edge: Pencil appears
Test 2:
Loading full graph: Pencil appears
Test 3:
Changing the Node-Label in the menu from "_key" to "Name": No pencil icon
Test 4:
Loading full graph witch changed Node-Labels: No pencil icon
Here's the image:

I just saw some odd behavior as well, but I don't think it's related to the node label option.
At first, hovering an edge highlights it, and the radial menu works. However, it sometimes gets stuck. Loading the full graph or changing any of the options fix the hovering, but then the radial menu doesn't show up at all anymore. This odd behavior seems to persist even if you reopen the graph until you refresh the entire page.
Chrome 73 on Windows and ArangoDB 3.4.4
@hkernbach @KVS85 Have you seen this behavior before?

Is there any workaround or possible explanation for this yet?

Will be fixed in: https://github.com/arangodb/arangodb/pull/8979
& https://github.com/arangodb/arangodb/pull/8980

I'm running the Docker-Image of ArangoDB. What's the preferred way of updating it?

It is not released yet. This patch will be included when we're publishing 3.4.6.

Hi @qohelet,
version 3.4.6, which includes a fix for this issue, has been released.
In case you are still facing this problem, please comment and we will reopen it.
Regarding the docker upgrade: One possible way is to pick the old database and use it as bounded /data volume for a new docker container (after old container is stopped). Start the new docker container with the option --server.upgrade-auto to perform the upgrade.
You could also use arangodump to create a backup in your old version docker deployment and restore this backup using arangorestore in your new version docker deployment.

Hello,
I just upgraded ArangoDB to 3.6.3-1 and see no pencil button for edges. In 3.3.25 it was visible until I set startnode. Now it never appears.
Also it would be nice to have delete button for edges.
Server OS: Debian 8.
Client OS: OpenSUSE 42.1
Browsers: FIrefox 68.8 ESR, Google Chrome 74.0, Chromium 81.0, all plugins disabled.

Fix will be part of 3.6.4.
PR: https://github.com/arangodb/arangodb/pull/11615

Also it would be nice to have delete button for edges.

Yes true, we could add that. I'll create a feature request ticket.

Hi @qncm,
Thanks for reporting.
Version 3.6.4, which includes a fix for this issue, has been released.
From the Changelog:

Fixed ability to edit graph edge in Graph Viewer of web UI.

Please find the latest release in the download section.


Avoid readthedocs action for a [skip ci] commit message

📚 Documentation preview 📚: https://xarray-ms--16.org.readthedocs.build/en/16/

Seems like the action is triggered from RTD's side, so not able to disable it in the GHA yaml

https://docs.readthedocs.io/en/stable/pull-requests.html
https://docs.readthedocs.io/en/stable/guides/pull-requests.html


Why do you block no-cache responses

What is the security benefit of blocking no-cache responses? I presume to prevent a verified cross-origin script from reloading to a different, unverified version. How can this happen during one browsing session, and wouldn't other cache control request/response directives still allow for a malicious reload of a script nonetheless?

That's not what that code is doing. It's not blocking the request. It's introspecting it. If the server is sending nocache header, it's possibly for the purpose of sending a different responses at different times.
For example, send a malicious payload to the client for the page with nocache header, then when the extension attempts to verify, send a non-malicious version. This is an attempt to prevent circumvention of verification.


SAK-42273 - Profile: Update name pronunciation to support Safari / iOS

This has not been tested on a real IOS device with Safari, waiting for testing results.
According to W3CSchool, Safari supports WAV as mime-type.....
https://www.w3schools.com/html/html5_audio.asp

Submitted an update that works with Safari and uses spring HttpRange


New pages return 404 on page refresh and direct navigation, but load when navigated from another page

After adding a new page to the src/pages directory, page won't load on direct navigation or on page refresh. Page loads when clicked through from another page.

Restarting the development server solves this problem.
404 only appears before the first dev server restart.
Confirmed that navigating from another page works (either through the navigation bar, or by adding a link to the new page on an existing page.

Underlying issue here is related to #121. Can be fixed by restarting dev server.


T509: Functionally Hausdorff + countable network => submetrizable

New T509: Functionally Hausdorff + countable network ==> submetrizable.
This allows to automatically deduce that 8 more spaces are submetrizable.

@Almanzoris do you see a button like this? If so, you can "Squash and merge" the changes you approve into main branch (so it becomes available to the public). If not, I should adjust your permissions.

@StevenClontz I don't.

I merged this one so it won't be delayed, but I fixed things so you can merge approved contributions in the future (including when you approve them yourself).

I merged this one so it won't be delayed, but I fixed things so you can merge approved contributions in the future (including when you approve them yourself).

Sure. Thank you for the trust!


ADD get course data

Solves #290
/courses/get/ returns course data as-well as tas for the course

Can you create a test for this new endpoint, and handle when the course does not exist with an error_response rather than a 500.


Reduce the memory consumption of ChannelOutboundBuffer

The initial capacity of a ChannelOutboundBuffer is 32, and it means each ChannelOutboundBuffer will end up with 32 entry objects as a channel lives on, even if the channel's maximum number of pending write requests is always 1.
We could do a few things to fix this:

Reduce the initial capacity to a smaller value such as 4.
Recycle entry objects or do something similar (we don't need thread local here obviously.)

http://stackoverflow.com/questions/24726973/netty-4-0-19-final-memory-leak-with-io-netty-channel-channeloutboundbufferentry

I have meet this issue, I try to disable AUTO_READ, and manually trigger read() operation by my self, and this issue disappear, Java heap memory consumption is quite stable.


Rule0024SemicolonAfterMethodOrTriggerDeclaration - System.NullReferenceException

Do you have any thoughts on what is causing the issue?
Analyzer 'BusinessCentral.LinterCop.Design.Rule0024SemicolonAfterMethodOrTriggerDeclaration' threw an exception of type 'System.NullReferenceException' with message 'System.NullReferenceException: Object reference not set to an instance of an object.
   at BusinessCentral.LinterCop.Design.Rule0024SemicolonAfterMethodOrTriggerDeclaration.AnalyzeSemicolonAfterMethodOrTriggerDeclaration(SyntaxNodeAnalysisContext ctx)
   at Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics.AnalyzerExecutor.<>c__DisplayClass53_1.<ExecuteSyntaxNodeAction>b__1() in X:\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\DiagnosticAnalyzer\AnalyzerExecutor.cs:line 752
   at Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics.AnalyzerExecutor.ExecuteAndCatchIfThrows_NoLock(DiagnosticAnalyzer analyzer, Action analyze, Nullable'1 info) in X:\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\DiagnosticAnalyzer\AnalyzerExecutor.cs:line 1095'

I've added additional error handling to this rule in the (pre-release) version v0.31.2 of LinterCop.
Could you switch to the pre-release version of the LinterCop and verify if it resolves the issue?

@a-gnius I wanted to follow up on this issue to check if you are still encountering this exception.
If the issue is no longer relevant or has been resolved, please let me know, and we can close this issue.

With the v0.31.2 I don't encounter this exception anymore. Thanks


Tutorial Docs Example Code Breakage

On this page of the documentation: https://reactnavigation.org/docs/intro/headers
There is the following code snippet:
static navigationOptions = ({ navigation }) => {
  const {state, setParams} = navigation;
  const isInfo = state.params.mode === 'info';
  const {user} = state.params;
  return {
    title: isInfo ? `${user}'s Contact Info` : `Chat with ${state.params.user}`,
    headerRight: (
      <Button
        title={isInfo ? 'Done' : `${user}'s info`}
        onPress={() => setParams({ mode: isInfo ? 'none' : 'info'})}
      />
    ),
  };
};

Which in following along with the tutorials leads to this stack trace:

The full code snippet to replicate this example in App.js is:
import React from 'react';
import {
  AppRegistry,
  Text,
  View,
  Button
} from 'react-native';
import { StackNavigator } from 'react-navigation';
import { TabNavigator } from 'react-navigation';

class RecentChatsScreen extends React.Component {
  render() {
    return(
       <View>
         <Text>List of recent chats</Text>
         <Button
           onPress={() => this.props.navigation.navigate('Chat', { user: 'Lucy' })}
           title="Chat with Lucy"
         />
       </View>
     )
  }
}

class AllContactsScreen extends React.Component {
  render() {
    return(
       <View>
         <Text>List of all contacts</Text>
         <Button
           onPress={() => this.props.navigation.navigate('Chat', { user: 'Lucy' })}
           title="Chat with Lucy"
         />
       </View>
     )
  }
}

const MainScreenNavigator = TabNavigator({
  Recent: { screen: RecentChatsScreen },
  All: { screen: AllContactsScreen },
});

MainScreenNavigator.navigationOptions = {
  title: 'My Chats',
};

class ChatScreen extends React.Component {
  static navigationOptions = ({ navigation }) => {
    const {state, setParams} = navigation;
    const isInfo = state.params.mode === 'info';
    const {user} = state.params;
    return {
      title: isInfo ? `${user}'s Contact Info` : `Chat with ${state.params.user}`,
      headerRight: (
        <Button
          title={isInfo ? 'Done' : `${user}'s info`}
          onPress={() => setParams({ mode: isInfo ? 'none' : 'info'})}
          />
      ),
    };
  };
}

const SampleNavigationApp = StackNavigator({
  Home: { screen: MainScreenNavigator },
  Chat: { screen: ChatScreen },
});

AppRegistry.registerComponent('SampleNavigationApp', () => SampleNavigationApp)

I am more than happy to answer any further questions you may have on this, and eagerly look forward to hearing your thoughts!
All the best. :smile:

Resolved this, don't remember how unfortunately, but closing!


Add quetzals

Add quetzal transportation between Varrock and Civitas illa Fortis
Whistle to hunter guild
Quetzals around varlamore

Thank you!


timeout period expiry mid communication

Hi
can someone explain what I need to do to overcome this error please?
I'm trying to query the OBD port on a 2003 Skoda Fabia mk1.
thanks
Justin
`
C:\Users\User\Desktop>kw1281test.exe COM4 10400 17 GetSKC
KW1281Test: Yesterday's diagnostics...Today.
Version 0.80-beta (https://github.com/gmenounos/kw1281test/releases)
Args: COM4 10400 17 GetSKC
OSVersion: Microsoft Windows NT 10.0.22621.0
.NET Version: 7.0.0
Culture: en-US
Opening serial port COM4
Sending wakeup message
Wakeup duration: 2 seconds
Reading sync byte
Keyword Lsb $01
Keyword Msb $8A
Protocol is KW 1281 (8N1)
Caught: System.IO.IOException This operation returned because the timeout period expired. : 'COM4'
Unhandled exception: System.IO.IOException: This operation returned because the timeout period expired. : 'COM4'
at System.IO.Ports.SerialStream.EndRead(IAsyncResult)
at System.IO.Ports.SerialStream.ReadByte(Int32)
at System.IO.Ports.SerialStream.ReadByte()
at System.IO.Ports.SerialPort.ReadByte()
at BitFab.KW1281Test.Interface.GenericInterface.ReadByte() in C:\Users\gmeno\src\kw1281test\Interface\GenericInterface.cs:line 34
at BitFab.KW1281Test.KwpCommon.ReadByte() in C:\Users\gmeno\src\kw1281test\KwpCommon.cs:line 103
at BitFab.KW1281Test.KW1281Dialog.ReadAndAckByte() in C:\Users\gmeno\src\kw1281test\KW1281Dialog.cs:line 442
at BitFab.KW1281Test.KW1281Dialog.ReceiveBlock() in C:\Users\gmeno\src\kw1281test\KW1281Dialog.cs:line 373
at BitFab.KW1281Test.KW1281Dialog.ReceiveBlocks() in C:\Users\gmeno\src\kw1281test\KW1281Dialog.cs:line 351
at BitFab.KW1281Test.KW1281Dialog.Connect() in C:\Users\gmeno\src\kw1281test\KW1281Dialog.cs:line 91
at BitFab.KW1281Test.Tester.Kwp1281Wakeup(Boolean ) in C:\Users\gmeno\src\kw1281test\Tester.cs:line 39
at BitFab.KW1281Test.Tester.GetSkc() in C:\Users\gmeno\src\kw1281test\Tester.cs:line 482
at BitFab.KW1281Test.Program.Run(String[]) in C:\Users\gmeno\src\kw1281test\Program.cs:line 243
at BitFab.KW1281Test.Program.Main(String[]) in C:\Users\gmeno\src\kw1281test\Program.cs:line 26
`

I increased the timeouts to 5 seconds and the uncaught exceptions have been squashed.
in trying to get the SKC key I received the following output which included a request to inform the project maintainer @gmenounos .  so here goes.  the SKC read was not successful.
Unlock code for software version 'VSQX01LM 01.20' is 3D 36 40 36
Please report this to the program maintainer.
Sending Custom "Need Seed/Key?" block
Sending Custom "Seed request" block
Block:  AF B6 6B 9F A4 D8 B7 60 03 00
Unexpected seed suffix: $03 $00, (Expected $01 $00)
Sending Custom "Key response" block
Sending Custom "Need Seed/Key?" block

Thanks for discovering that the timeout needs to be increased. I'll add that to the next version.
What part number is your cluster? (The ReadIdent command will show that)
A few people lately have been trying to use kw1281test with non-VW cars and encountering the "Unexpected seed suffix: $03 $00" error.

Pretty sure this cluster is not K-line.  There is a long post on tdiforum where someone uses a concentrator to get access.   Should still be accessible via k-line through the OBD2 port.
I think this is the same cluster as present on polos and yetis btw
Will post photos of the part number data as soon as I can work out how to get the editor to accept them!
I've tried with vag k com too.  Can read a few lines of eeprom then hangs reading block 0x48.

here is a link to the photos I referred to
not sure which is the model number.
VD1 110 080 253 / 014
SKODA 6YO 920 981 M B41

Pretty sure this cluster is not K-line. There is a long post on tdiforum where someone uses a concentrator to get access. Should still be accessible via k-line through the OBD2 port.

Any chance you could dig up a link to that info? I need to know what part to buy and wiring info to communicate with my cluster (6Q0920800) on the bench.

@gmenounos  Maybe the timeout should be an optional setting then?

I've seen other tools build in trapping to the timeout routine to restart transactions that have timed out but with a longer timeout period.  That may be a more user friendly solution.

@jpadie would you share precompiled version with increased timeout?

Sure.  I can do that this weekend.  On 23 Mar 2023 12:06, gapx15 @.***> wrote:
@jpadie would you share precompiled version with increased timeout?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Has anyone thought of rewriting this in JavaScript and deploying as a webapp?

Sure.  I can do that this weekend.  On 23 Mar 2023 12:06, gapx15 @.> wrote: @jpadie would you share precompiled version with increased timeout? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

Or send me the changes and I can push out a new version.

Has anyone thought of rewriting this in JavaScript and deploying as a webapp?

Very interesting idea. I'm not a JavaScript developer, so I wasn't aware that you could access serial ports from a web app, but apparently you can.

That makes more sense from a code base maintainability perspective.I will sort out a PR over the weekend.  On 24 Mar 2023 21:40, Greg Menounos @.***> wrote:
Sure.  I can do that this weekend.  On 23 Mar 2023 12:06, gapx15 @.> wrote: @jpadie would you share precompiled version with increased timeout? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
Or send me the changes and I can push out a new version.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I've released a new version with your changes. Thanks for providing them. I will make this configurable at some point.

Great stuffI'm working on a proof of concept port to JavaScript but I have a doubt about whether the wake up will work as there is no way to bypass drivers through JavaScript to my knowledge. I will spend some time this week testing the readIdent function and see what is possible.On 29 Mar 2023 02:41, Greg Menounos @.***> wrote:
I've released a new version with your changes. Thanks for providing them. I will make this configurable at some point.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

so far, no joy with a js implementation.  bauds other than the "standard" baudRates are honoured by the underlying lib on a "best efforts" basis; so no guarantee that the timing is correct.
However I am stuck on an earlier issue I think - i cannot seem to get the port even to open to the ECU.  other serial connections seem ok.
`console.log("waking up");
//first connect to the serial port with a very slow baud rate

navigator.serial
    .requestPort({})
    .then((port) => {
        port.open({
            baudRate: 5,
            dataBits: 7,
            stopBits: 1,
            parity: "odd"
        });
        console.log(port.getInfo());
        const writer = port.writable.getWriter();
        console.log(writer);
    })
    .catch((e) => {
        console.log(e);
    });`

I do get a response from getInfo() which means that the binding to the USB cable is correctly made.  but nothing after that.  i think this could be worked around with a tiny C or goLang helper app to handle the wakeUp but I wonder then what value/flexibility that would bring over a pure C# implementation.


feat(UI-1112): add google tag manager

Description
Implemented by the explanation from here:
https://support.google.com/tagmanager/answer/14847097?hl=en&ref_topic=15191151&sjid=15209236849471240215-EU
Linear Ticket
https://linear.app/autokitteh/issue/UI-1112/add-googletagmanager-to-the-app
What type of PR is this? (check all applicable)

[x] 💡 (feat) - A new feature (non-breaking change which adds functionality)
[ ] 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
[ ] 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
[ ] 🏎 (perf) - Optimization
[ ] 📄 (docs) - Documentation - Documentation only changes
[ ] 📄 (test) - Tests - Adding missing tests or correcting existing tests
[ ] 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
[ ] ⚙ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
[ ] ☑ (chore) - Chores - Other changes that don't modify src or test files
[ ] ↩ (revert) - Reverts - Reverts a previous commit(s).

https://github.com/stafyniaksacha/vite-plugin-radar


Replays: final boss

About the PR
Requires https://github.com/space-wizards/RobustToolbox/pull/4156
Zip files, integrates it with content bundles so works directly in the launcher.
Changelog

:cl: ElectroSR (& a bit PJB)

add: The game now supports recording and playing back replays of the round.
add: You can already get started recording client-side replays yourself. You can start recording at any time with the replay_recording_start and replay_recording_stop commands.
add: Recorded replays are stored in %APPDATA%/Space Station 14/data/replays (or equivalent on other platforms). You can view a replay by dragging its zip file onto the latest version of the launcher.

Changelog should mention the button in launcher to open the data folder.

also if you wanna be funny add a guidebook entry and a button in the escape menu for replay record start/stop.

I'll leave that for somebody else to figure out the UX I just wanna get the technical side out the door right now.


AstDump Unit Test

This is an attempt to boost our coverage numbers by targeting the one file with zero coverage.
https://youtu.be/xS1pDvb_6Hk

thread_cpu_timer_test (this morning's version) failed in Release mode. Suspect operations I need are being compiled out.


Initial Elixir SDK project

Initial project for the Elixir language SDK. The sdk is here until we have its dependencies published as Hex packages.
The SDK for Elixir differs from other sdks as it does not need a proxy. Since the SDK is developed in Elixir we can connect it directly with the other Nodes in a more direct way.
This also brings an implication that will have to be resolved by our Operator as he will have to know the sdk used so he can not inject the proxy container in the Pod where the Host Function Elixir is.

WDYT of leaving %Value{} struct iteraction to whoever calls handle_command?
Maybe just returning in the same interface as a GenServer in handle_command/2 callbacks looks better, like:
{:reply, response, state}
{:noreply, state}

Or even with the possibility of instead of state, returning context:
{:reply, response, context}
{:noreply, context}

WDYT of leaving %Value{} struct iteraction w/ state and response to SpawnSystem :call?
Maybe just returning in the same interface as a GenServer in handle_command/2 callbacks looks better, like:
{:reply, response, state}
{:noreply, state}

Or even with the possibility of instead of state, returning context:
{:reply, response, context}
{:noreply, context}

I thought of this proposal and didn't choose it because the value as the name suggests is an "object" of value, that is, it was thought, in the sdks, to be an interface where the user demonstrates the actual intention that he wants to pass for the proxy. All the workflows and pipelines we'll create are based on the user having a quasi-declarative way to create them. Doing this sort of thing like GenServer does means keeping lots of pipes of different return types which I don't particularly like. A more plausible improvement that I see is implementing a Protocol on the %Value type to make it easier to use the type. For example:
{reply, ctx} =
   Value.of(new_state)
   |> Value.workflow(side_effects: [my_side_effects_list_here])

{:reply, reply, ctx}

It would be a better api than the current one. But we need the user to return not only data but also intents and that's why I think it's better to work with a wrapper type like Value than just receiving the output types.

@eliasdarruda  I'll merge with Main and we'll go from there.


Better Smoke test setup

Small improvement to make the errors from the smoke test start up make more sense.

Coverage increased (+0.05%) to 35.077% when pulling 7fd59b5b73f48b95c5087781a2e324f84193e2d5 on anthonydresser/bettersmokesetup into dc751dbde6e5bb6e469941e145553f0d9329f959 on main.


add dependabot

Description of Changes
See https://github.com/open-telemetry/opentelemetry-log-collection/pull/102/files
This configuration assumes that we will have a go module in / and /internal/tools. Right now we use sub modules but this PR https://github.com/observIQ/stanza/pull/304 will change that.
I also intend to update make install-tools to behave like this https://github.com/open-telemetry/opentelemetry-log-collection/blob/main/Makefile, which will add the /internal/tools module.
Please check that the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Add a changelog entry (for non-trivial bug fixes / features)
[ ] CI passes

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.413803
-0.27582216
130.22037
+0.7980957

1
5000
5.206998
-0.58610153
137.30348
+1.9892273

1
10000
10.793177
+0.3275938
143.93831
-0.7932434

1
50000
53.513657
+3.3931465
177.74232
+4.306305

1
100000
102.74363
+1.3327713
241.48384
+7.514282

10
100
1.9139125
-0.034379482
138.53462
+5.440201

10
500
6.1382465
-0.37907076
138.70541
-0.7258911

10
1000
13.448412
+1.6724052
147.70447
+1.6403503

10
5000
55.38057
-0.9144325
184.72427
-0.9801941

10
10000
106.23394
+0.26838684
223.34886
-0.1857605


(easysetup): iam:CreatePolicy required, even though policy exists

Describe the bug
When adopting a new Greengrass Core, we need temp credentials to do a lot of things. I don't want those credentials to be able to create new IAM policies and roles, so I created them myself, since they are reused across all adoptions. But, I cannot do the adoption since I don't have iam:CreatePolicy rights.
https://github.com/aws-greengrass/aws-greengrass-nucleus/blob/8a9bd022c7a1da82012eec4a006839d7b7e36f70/src/main/java/com/aws/greengrass/easysetup/DeviceProvisioningHelper.java#L399
Here you run createPolicy directly, and it will never answer that it already exists since we don't have permission to create.
I would propose running the getPolicy first for checking if it exists instead of relying on the error message.
To Reproduce
Run easysetup with minimal permissions
Expected behavior
It should say it exist and move on.
Actual behavior
Attaching TES role policy to IoT thing...
Error while trying to setup Greengrass Nucleus
software.amazon.awssdk.services.iam.model.IamException: User: arn:aws:sts::xxx:assumed-role/GreengrassCommissioningRole/tempcore-30293-setup is not authorized to perform: iam:CreatePolicy on resource: policy GreengrassV2TokenExchangeRoleAccess

Environment

OS: Raspbian Stretch
JDK version: OpenJDK8
Nucleus version: latest?

Additional context
I need to add very permissive permissions to a role that will be running in the first-run scripts of my embedded device to add it as a temp core device in greengrass.

Workaround:
Add iam:CreatePolicy permission with the specific policy as resource :+1:
              - Effect: Allow
                Action:
                  - "iam:CreatePolicy"
                Resource: !Ref GreengrassV2TokenExchangeRoleAccess

Hi, thanks for reporting this. We are looking into it and will post an update here once done.
As you pointed out, at the moment iam:createPolicy is needed in the minimum permissions for setting up the core with the --provision option. While we work on eliminating the need for create permissions when some of the resources exist, you seem to have worked around it by scoping down the iam:createPolicy permission to just the specific policy, please let us know if you have any questions about that.

Closed by PR #805. Will be released soon in our next patch.

Closed by PR #805. Will be released soon in our next patch.

Got the changes now, and updated my commissioning role policy to just be allowed to fetch the specific policy, but I think there is a missing check here: https://github.com/aws-greengrass/aws-greengrass-nucleus/blob/07ebae237cac1f5a142aefd06ae8723bea5303b3/src/main/java/com/aws/greengrass/easysetup/DeviceProvisioningHelper.java#L463
My policy don't allow Nucleus to get "random" policies, but only the one it needs. Now I'm getting a error that my role is not authorized to perform iam:GetPolicy in resource: policy arn:aws:iam::aws:policy/GreengrassV2TokenExchangeRoleAccess. So it doesn't try my supplied policy first, which is arn:aws:iam::<account_id>:policy/GreengrassV2TokenExchangeRoleAccess. And since the exception isn't catched, it crashes.

Can you just update it to add access to both of those roles? We try the first one which is the style of AWS predefined policies because Greengrass should be adding a premade policy in the future.

Can you just update it to add access to both of those roles?

Yes, I added that to my policy now to get it working, and now it works. It's just a "gotcha" I didn't expect and didn't understand before looking at the code.

Understood, thank you for reporting this, we'll look into addressing it in future releases.

Addressing it here https://github.com/aws-greengrass/aws-greengrass-nucleus/pull/868


Final pull request for V1 launch

Docs Build status updates of commit c4ef9bd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

licensed-hardware/faq.md
:white_check_mark:Succeeded

licensed-hardware/index.md
:white_check_mark:Succeeded

licensed-hardware/process-added-value.md
:white_check_mark:Succeeded

licensed-hardware/process-branding.md
:white_check_mark:Succeeded

licensed-hardware/process-engagement.md
:white_check_mark:Succeeded

licensed-hardware/process-product-submission.md
:white_check_mark:Succeeded

licensed-hardware/process-reporting.md
:white_check_mark:Succeeded

licensed-hardware/program-DTC.md
:white_check_mark:Succeeded

licensed-hardware/program-designed-for-surface.md
:white_check_mark:Succeeded

licensed-hardware/program-designed-for-xbox.md
:white_check_mark:Succeeded

licensed-hardware/program-inclusive-technology.md
:white_check_mark:Succeeded

licensed-hardware/proposal.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix compile error in DesignableTabBarController

I've got following error on Xcode 9 beta 4. And fixed it.
Cannot convert value of type 'String' to expected dictionary key type 'NSAttributedStringKey'

The error is the same to the one reported on Issue #272

Thanks


Extension issue

Issue Type: Bug
Extension Name: git
Extension Version: 1.0.0
OS Version: Windows_NT x64 10.0.19043
VS Code version: 1.68.0

:warning: We have written the needed data into your clipboard. Please paste! :warning:

@orimaro123, could you please provide the steps to reproduce the issue that you are experiencing? Thank you!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[TechDocs] Prevent warning creep in api-report.md

Hey, I just made a Pull Request!
Since we just cleaned these up!

🏆


Exit code 3

I'm getting an non-zero exit code (3) which is messing up my automation.  Is the exit 3 a true error?
I've narrowed it down to group4.
Running with this command:
bash -x ./prowler -g group4 -M html 2>stderr.txt
the end of the stderr.txt file has this (i can paste more if needed):
+ echo '[check44]' Ensure routing tables for VPC peering are '"least' 'access"' '(Not' 'Scored)	'
+ echo 'us-west-2:' No VPC peering 'found	'
+ echo '
'
+ [[ PASS == \F\A\I\L ]]
+ [[ PASS == \W\A\R\N\I\N\G ]]
+ is_junit_output_enabled
+ [[  html  =~  junit-xml  ]]
+ false
+ for i in '"${!GROUP_ID[@]}"'
+ '[' cislevel1 == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' cislevel2 == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' extras == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' forensics-ready == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' gdpr == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' hipaa == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' secrets == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' apigateway == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' rds == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' elasticsearch == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' pci == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' trustboundaries == group4 ']'
+ for i in '"${!GROUP_ID[@]}"'
+ '[' internet-exposed == group4 ']'
+ [[ html =~ html ]]
+ addHtmlFooter
+ cat
+ unset HTML_REPORT_INIT
+ cleanTemp
+ [[ 0 -ne 1 ]]
+ rm -fr /tmp/prowler.cred_report-XDV1r5
+ scoring
+ [[ '' == \1 ]]
+ exit 3
+ cleanTemp
+ [[ 0 -ne 1 ]]
+ rm -fr /tmp/prowler.cred_report-XDV1r5```

The Same issue I am also facing is there any update for the issue

Thank you both for your patience here. I need to take some time on this to understand how to improve it.

Is there definitely an issue here? I was trying to reproduce this and whilst I did get exit code 3, it was because check43 (not included in the output above) was failing. This check would fail on any AWS account out of the box: "[check43] Ensure the default security group of every VPC restricts all traffic (Scored)" - the default Security Group allows outbound traffic to <IP_ADDRESS>
Once I fixed that default SG, re-running group4 with the command above exited with 0. Is there a chance that your check43 is failing too? No doubt I'm missing something though

Hi, any updates regarding this issue? as the job is successful but I am getting error code 3

Hi @deanvaturi can you please share here the command that you are using and output? As @marcjay mentioned, Prowler shows exit code 3 when a check fails because users want their deployment fails and make sure no insecure resources are deployed (when using codebuild, jenkins, etc.), see this line here:
https://github.com/toniblyx/prowler/blob/master/include/outputs#L133
So for example try running prowler with a check that pass and right afterwards run echo $? and you will get a 0. If you do the same with a check that ends with a fail echo $? will give you a 3.
In order to change that behavior you have two options, a dirty one changing that mentioned line or a nicer one with something like this in your build (this is just an example):
SCAN_RESULT=$(./prowler -c check32 -M csv,html && echo OK || echo FAILED)
That will make CodeBuild to work fine any time and also you will capture the output in that variable, in case the proper prowler command fails then CodeBuild will fail. Does it make sense?

I added PR #865 to control if failed Checks generate exit code 3.

This is finally fixed with the Z feature thanks to @Kirizan. Please test branch 2.5.1 and reopen this issue if needed.


Update README.md

It seems that '0' does not work, so I replaced '1'

This is the list use '0'

This is the list use '1'


Updated error message for missing variables

Coverage remained the same at 96.503% when pulling 5c9e13a0377471ef2c3cbe1c5d0da270cb396db6 on feature/better_errors_for_actions into bec7132407be118e77b24b67e55e91c67b9f91a7 on master.


prototype2-script: the Ingress demo can run on MacOS

This PR moves the Envoy proxy, used in the Ingress part of the P2 demo, to be running in container, so that it can connect to the network created by KinD, to be able to proxy downstream clusters, even while it runs in the extra virtualisation layer introduced by Docker or Podman on MacOS.
Fixes #550.

@ncdc @jmprusi this implements the approach we discussed. I've successfully tested it with Docker Desktop for Mac, as well as with Podman 3.

@jmprusi can you review?

@jmprusi thanks a lot for the review. I think I've covered your comments. I've also added small fixes for:

|& fails with GNU bash version 3.2.57 on MacOS
Unbounded IMAGE_FLAG variable
Duplicated calls to the Envoy container clean-up function

Tested locally.

@sttts @jmprusi I have re-pushed to make the tests pass (otherwise retries kept failing). Could you re-enable auto-merge once again so that it gets merged?


Install ncurses dev dependency

The blade gem which we are using in Rails, depends on curses gem. And this gem depends on the ncurses library.

@meinac thanks for the patch!
In the end I committed myself because install needs a first info argument and it was faster for me to push it than to ask you to revise.


Fix Dir#exists? deprecation warning.

Fixes the deprecation warning for Dir.

Thank you!

Thank you too!

Released in 3.12.2


diceware: add missing 'setuptools' to propagatedBuildInputs

(cherry picked from commit f641fca688c8be93bcb1c0f54920ce16e9b0e631)

Motivation for this change
Currently fails with:
[grahamc@Petunia:~]$ nix-shell -p diceware --run diceware
Traceback (most recent call last):
  File "/nix/store/izqgibxvwydd4yg29p2hym1zsfq4sxfy-diceware-0.9.6/bin/.diceware-wrapped", line 7, in <module>
    from diceware import main
  File "/nix/store/izqgibxvwydd4yg29p2hym1zsfq4sxfy-diceware-0.9.6/lib/python2.7/site-packages/diceware/__init__.py", line 19, in <module>
    import pkg_resources
ImportError: No module named pkg_resources

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Can confirm this fixes the issue on darwin.


Implement custom buttons

Unfortunately we can't really add any styles to the out-of-the-box RN buttons:

However, it seems like there are a lot of ready-to-use solutions out there using the TouchableXXXX components.
Here is a good example from Facebook: https://github.com/facebook/react-native/blob/master/Libraries/Components/Button.js
More reading: https://stackoverflow.com/questions/43585297/react-native-button-style-not-work
I think this is high priority because it will help prove that we have full style control over simple form elements.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e492b331c8133b5b
Upwork Job ID:<PHONE_NUMBER>874089984
Last Price Increase: 2023-01-03

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

hahaha.... oops. I guess using 123 as a test issue number wasn't great. I'm so sorry for all the noise here!


Serialize protein association settings and protein groups

Move the ParsimonySettings from PeptideFilter to PeptideSettings as Brendan suggested, so that PeptideFilter continues to represent only things that are configurable in the settings UI.
Add serialization for ParsimonySettings (as protein_association)
Add protein_group type to schema
Add subclass of FastaSequence, FastaSequenceGroup, which acts like a FastaSequence most of the time but serializes all of its proteins in XML (keeping just a single peptide_list though)

The audit logs didn't change (which surprised me) because the settings were already being stored in the audit log, and their representation didn't change from my refactoring here. That's up to AssociateProteinsSettings.CreateEntry(). Can you can check the audit log format so you can say whether or not it's not good the way it is now?
I did (minimally) change the unit test for serialization to make sure protein_group works. And I did some manual testing and checking of the document as well. Is there a test pattern for saving and reloading a document after it's been run through a test just to check the serialization works?

Just committed the ProteinGroupMetadata changes. That part warrants a re-review @nickshulman @brendanx67 . I'm touching a lot of code I'm not familiar with.

Do you understand why TestAuditLogLocalization is failing? It seems the existing code has decided that suddenly ProteinMetadata.WebSearch is a tracked property that might end up in the audit log. Though, I can't see why.

Do you understand why TestAuditLogLocalization is failing? It seems the existing code has decided that suddenly ProteinMetadata.WebSearch is a tracked property that might end up in the audit log. Though, I can't see why.

It was an errant track attribute in the subclass' copy-pasta that nobody noticed. Including me, until I commented out the derived property (going back to a non-virtual in the base class to see if that was the issue) and got a compile error.

I think space around the slashes would be good. Monospaced for the sequence also would be interesting to see. The way these tips get shown is a two-step interaction, where first the node is asked how big the tip needs to be and then it is asked to paint the tip on a resulting window. It seems like this shouldn't be that hard to expand to support scrolling. Maybe returning (optionally) two sizes: tip window size, and content size. Then the tip could have scrollbars added based on the content size (if specified).

I didn't intend for the tooltip/scrolling discussion to delay this PR (if that's what you mean by 'we have gone beyond my initial review'). Only the (missing) placeholder Brian mentioned should be addressed IMO.
Adding the spaces between slashes helped for moderate groups:

But large groups still look unwieldy:

I'm thinking the descriptions should be separated by linefeeds instead of slashes. And maybe for Species, if all the values are the same, collapse it down to that value (e.g. just "Homo sapiens" if all the proteins are in the group are Homo sapiens). Could also do that for Gene, although it's not as common that a group will have just one gene.

@bspratt Is it normal to get multiple gene names for a single protein (e.g. aliases)?

My understanding is that while it's not common, multiple genes can indeed produce the same protein.

No I mean aliases: https://www.genecards.org/cgi-bin/carddisp.pl?gene=DLD

Multiple genes would not produce the same protein accession, but could produce two different accessions with the same protein sequence. That would not be uncommon between species or subspecies, but would be fairly uncommon within a species.

You can also implement wrapping for some of the fields that appear very
wide right now. You can see that Description and sequence already have
wrapping implemented.
On Thu, Jul 21, 2022 at 7:36 AM Matt Chambers @.***>
wrote:

I didn't intend for the tooltip/scrolling discussion to delay this PR (if
that's what you mean by 'we have gone beyond my initial review'). Only the
(missing) placeholder Brian mentioned should be addressed IMO.
Adding the spaces between slashes helped for moderate groups:
[image: image]
https://user-images.githubusercontent.com/5011937/180238030-5fc882cb-5500-4c0d-95a9-c87950468bc3.png
But large groups still look unwieldy:
[image: image]
https://user-images.githubusercontent.com/5011937/180238429-ce36a7cc-a37d-48be-ab1d-91d1908a26a2.png
I'm thinking the descriptions should be separated by linefeeds instead of
slashes. And maybe for Species, if all the values are the same, collapse it
down to that value (e.g. just "Homo sapiens" if all the proteins are in the
group are Homo sapiens). Could also do that for Gene, although it's not as
common that a group will have just one gene.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2158#issuecomment-1191564360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUC2DIUEIOMT5TUJZLLVVFN5VANCNFSM53MCZIGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@chambm I guess I don't understand the question, sorry

The value for "Gene" in the last screen capture has 4 different space separated aliases for the same gene. That's not my code doing that (I don't think). Is it supposed to be that way?

Yeah, that's normal: we ask
https://rest.uniprot.org/uniprotkb/stream?query=P09622&format=tsv&columns=id,genes,organism,length,entry name,protein names,reviewed
and they respond with
Entry	Entry Name	Reviewed	Protein names	Gene Names	Organism	Length
P09622	DLDH_HUMAN	reviewed	Dihydrolipoyl dehydrogenase, mitochondrial, EC <IP_ADDRESS> (Dihydrolipoamide dehydrogenase) (Glycine cleavage system L protein)	DLD GCSL LAD PHE3	Homo sapiens (Human)	509

OK after fixing a bug with the first sequence length of the protein group always being used for web lookups (leading to lots of unknowns), and adding wrapping for all fields, I get this:


SqlSetup:Fixes issue #1254

Pull Request (PR) description
SqlSetup:Fixes issue #1254
This Pull Request (PR) fixes the following issues

Fixes #1254

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nesith sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #1299 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            dev   #1299    +/-   ##
=====================================
+ Coverage    97%     97%   +<1%
=====================================
  Files        35      35
  Lines      4374    4376     +2
=====================================
+ Hits       4269    4271     +2
  Misses      105     105

Thanks for this @nesith! 😃


FID in Cifar10.

Thank you to the author for your work. Compared with opanai's code, your code adds more details and solves many of my previous problems. Thank you. But when I used your open source ADM_cifar10_baseline.pt model, the final fid calculation result was 3.38, which is still far behind the 2.99 in your paper. Below is the script I generated. Are there any questions?
python3 scripts/image_sample.py \

--image_size 32 --timestep_respacing 100 \

--model_path ./ckpt/ADM_cifar10_baseline.pt \

--num_channels 128 --num_head_channels 32 --num_res_blocks 3 --attention_resolutions 16,8 \

--resblock_updown True --use_new_attention_order True --learn_sigma True --dropout 0.3 \

--diffusion_steps 1000 --noise_schedule cosine --use_scale_shift_norm True --batch_size 256 --num_samples 50000

My final result is
Inception Score: 9.63854694366455
FID: 3.386766967519236
Thanks again.

Hi @RachelTeamo , your 3.39 FID is correct because you were using 100 sampling sites (--timestep_respacing 100)
2.29 FID was obtained by 1000 sampling steps


How to export the serving input function as a protobuf(pb) file?

Thanks for this awesome tutorial. I have doubt, How do we serve the input function for this model and export the (.pb) file. So we can upload the (.pb) file to the Google cloud and get predictions from the cloud components. To serve the input function, I  wrote this code
def serving_input_fn():
    feature_placeholders = {
      'var1' : tf.placeholder(tf.float32, [None]),
      'var2' : tf.placeholder(tf.float32, [None]),
      ...
    }
    features = {
        key: tf.expand_dims(tensor, -1)
        for key, tensor in feature_placeholders.items()
    }
    return tf.estimator.export.ServingInputReceiver(features,
                                                    feature_placeholders)

How do I export this serving input function and save as protobuf file? To export the file, I used
export_dir = '<folder_path>'
classifier.export_savedmodel(export_dir, serving_input_fn)

But it throughs following error

ValueError: export_outputs must be a dict and not<class 'NoneType'>

Thanks but this is not an issue and serving is not in the scope of this tutorial.
A simple google search would have given you your answer though:
https://stackoverflow.com/questions/48681600/how-to-store-model-in-pb-file-with-estimator-in-tensorflow

@vincentteyssier  Thanks!


Address review comments by @enetz and @jpfeuffer

Ref https://github.com/OpenMS/OpenMS-docs/pull/65.

Describe the change

PR checklist

[x] I have added description of the change I'm proposing in the OpenMS Documentation.
[x] I have read and followed OpenMS Documentation Contributing guidelines.
[x] I have attached a screenshot of the relevant area after this change.
[x] CHANGELOG.md is updated.
[x] I have added my name in CONTRIBUTING.md.

Very nice! The detailed descriptions about Cmake build type etc, are they going into the developer documentation?

yes.


The "FindAssembliesWithReferencesTo" task failed unexpectedly after Visual Studio 2019 update

I keep a vanilla copy of a brand new server+client Blazor project following the instructions on Microsofts docs so that way when something breaks after an update in a larger project, I can come to this one to try and more easily troubleshoot.
It looks something like this: https://github.com/BretMishler/LoanCalc
As you can see, other than the little controller I added to play with, it's pretty vanilla and has worked fine. It's been a little over a week since I've tried running it and since that time, the only thing that has changed has been an update to Visual Studio 2019 (maybe two?).
Now, when I run the project, I get this error which causes the solution to not build:
Error MSB4018 The "FindAssembliesWithReferencesTo" task failed unexpectedly. System.IO.FileNotFoundException: Could not find file 'C:\Users\bmishl\source\repos\BretMishler\LoanCalc\LoanCalc.Client\bin\Debug\netstandard2.0\LoanCalc.Client.dll'.
File name: 'C:\Users\bmishl\source\repos\BretMishler\LoanCalc\LoanCalc.Client\bin\Debug\netstandard2.0\LoanCalc.Client.dll'
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   at Microsoft.AspNetCore.Razor.Tasks.ReferenceResolver.GetReferences(String file)
   at Microsoft.AspNetCore.Razor.Tasks.ReferenceResolver.Resolve(ClassifiedAssemblyItem classifiedItem)
   at Microsoft.AspNetCore.Razor.Tasks.ReferenceResolver.ResolveAssemblies()
   at Microsoft.AspNetCore.Razor.Tasks.FindAssembliesWithReferencesTo.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()	LoanCalc.Server	C:\Program Files\dotnet\sdk\3.0.100-preview6-012264\Sdks\Microsoft.NET.Sdk.Razor\build\netstandard2.0\Microsoft.NET.Sdk.Razor.MvcApplicationPartsDiscovery.targets	53

Also to note is that when I go through the steps to make a new solution, only Blazor (server-side) shows up. Client side is missing as an option, though normally I've been creating the project in the command line anyways.

I am having the same issue. I think my issue have something to do with Dot Net framework being lower.

Thanks for contacting us, @BretMishler.
The error you're receiving here is actually a bit confusing, and we plan to address that as part of https://github.com/aspnet/AspNetCore/issues/11226.
The actual issue is that the dependency failed to build, so you will have to find what actually have failed during that build.


Add support for ICU 73-1

name: 🎉 New Feature
about: Add support for version 73.1 of ICU

Description
ICU 73.1 has been released this morning https://github.com/unicode-org/icu/releases/tag/release-73-1.
This PR adds support to it

Thanks! @jderusse 🎉, 73.1 should work now


colspan & rowspan

Hy,
How to add colspan & rowspan in at-table?
thx.

Check out the readme please.

I know this thread is very old, but there is nothing in the readme about colspans. I wonder what you meant back then.


Example of exception handling

I can't find anywhere any example of how to handle "Invalid handshake" errors. If you go directly to the websocket server with a browser it wont be able to upgrade the connection to a socket and throws and exception. I am not sure where/how to catch that exception. It would be very helpful to add an example for this.

Invalid handshake
Traceback (most recent call last):
File "/Users/david/.pyenv/versions/venv-3.6.4-dm-socket/lib/python3.6/site-packages/websockets/handshake.py", line 85, in check_request
assert get_header('Upgrade').lower() == 'websocket'
AssertionError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/david/.pyenv/versions/venv-3.6.4-dm-socket/lib/python3.6/site-packages/websockets/server.py", line 88, in handler
extra_headers=self.extra_headers,
File "/Users/david/.pyenv/versions/venv-3.6.4-dm-socket/lib/python3.6/site-packages/websockets/server.py", line 437, in handshake
key = check_request(get_header)
File "/Users/david/.pyenv/versions/venv-3.6.4-dm-socket/lib/python3.6/site-packages/websockets/handshake.py", line 93, in check_request
raise InvalidHandshake("Invalid request") from exc
websockets.exceptions.InvalidHandshake: Invalid request

import asyncio
import websockets

async def echo(websocket, path):
    async for message in websocket:
        await websocket.send(message)

asyncio.get_event_loop().run_until_complete(
    websockets.serve(echo, 'localhost', 8765))
asyncio.get_event_loop().run_forever()

Above is the simple echo code. If you browse to it with http://localhost:8756 you get that exception

this is also necessary when a crawler decides to visit your dns name and causes a lot of 404s which would cause exceptions and cause pain for whomever is handling the server alerts.
a catch all handler to handle all the http traffic and server 404 would be very helpful.

It would be nice to handle such requests a bit more gracefully.
In the current version of websockets, you can write a WebSocketServerProtocol subclass and override process_request to respond 404 to any request that doesn't contain a suitable Upgrade header.

#393 should address this comprehensively. Let me know if you have feedback on that PR. Thanks!

great. returning 426 is a good idea.


Reboot of your system might kill your container image files

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
I am using a clean F31 distribution. On my server i created a technical user (id > 1000, not the first) , that is dedicated to run a podman-container, rootless of course. I got my server into run state and before a shutdown i make sure, that the container is stopped by podman stop .
After reboot i want to restart the podman-container, but the container-file is not there. The when i try to remove that image, podman tells me, that there is no file.
[tlxoffice@chasmash docker_kivitendo]$ podman ps -a
CONTAINER ID  IMAGE                       COMMAND               CREATED         STATUS                     PORTS                        NAMES
a6edeae3c880  localhost/kivi_prod:latest  /lib/systemd/syst...  42 minutes ago  Exited (0) 30 minutes ago  <IP_ADDRESS>:9190->80/tcp  jovial_stonebraker
[tlxoffice@chasmash docker_kivitendo]$ podman start a6edeae3c880
Error: unable to start container "a6edeae3c880": cannot chown run directory /run/user/1001/overlay-containers/a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39/userdata: chown /run/user/1001/overlay-containers/a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39/userdata: no such file or directory
[tlxoffice@chasmash docker_kivitendo]$ podman rm a6edeae3c880
Error: error freeing lock for container a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39: no such file or directory
[tlxoffice@chasmash docker_kivitendo]$ podman rm a6edeae3c880
Error: no container with name or ID a6edeae3c880 found: no such container

gaaahhh!
Steps to reproduce the issue:

get a user with a uid > 1000. It looks like, that the very first user does not have this problem

stop your container

reboot und try to restart the container again

Describe the results you received:
[tlxoffice@chasmash docker_kivitendo]$ podman start a6edeae3c880
Error: unable to start container "a6edeae3c880": cannot chown run directory /run/user/1001/overlay-containers/a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39/userdata: chown /run/user/1001/overlay-containers/a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39/userdata: no such file or directory

Describe the results you expected:
a proper start!
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
[tlxoffice@chasmash docker_kivitendo]$ podman version
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.13.5
OS/Arch:            linux/amd64

Output of podman info --debug:
[tlxoffice@chasmash docker_kivitendo]$ podman info --debug
debug:
  compiler: gc
  git commit: ""
  go version: go1.13.5
  podman version: 1.7.0
host:
  BuildahVersion: 1.12.0
  CgroupVersion: v2
  Conmon:
    package: conmon-2.0.10-2.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.10, commit: 6b526d9888abb86b9e7de7dfdeec0da98ad32ee0'
  Distribution:
    distribution: fedora
    version: "31"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1001
      size: 1
    - container_id: 1
      host_id: 165536
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1001
      size: 1
    - container_id: 1
      host_id: 165536
      size: 65536
  MemFree:<PHONE_NUMBER>4
  MemTotal:<PHONE_NUMBER>4
  OCIRuntime:
    name: crun
    package: crun-0.10.6-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.10.6
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: journald
  hostname: chasmash
  kernel: 5.4.15-200.fc31.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.3+dev
      commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e
  uptime: 44m 9.47s
registries:
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /home/tlxoffice/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.7.5-2.fc31.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.7.5
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 77
  RunRoot: /run/user/1001
  VolumePath: /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
[tlxoffice@chasmash docker_kivitendo]$ rpm -q -f /usr/bin/podman
podman-1.7.0-2.fc31.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
a proper Fedora F31

/kind bug

No such file or directory on rootless storage directory? We should be recreating that on detecting a reboot. RunRoot is set appropriately to a tmpfs, so it looks as though we ought to be wiping the alive file after reboot, which is confusing.
Error: error freeing lock for container a6edeae3c8807b9d39b54733566c2533dd53f8efbcd92365b98913896261bb39: no such file or directory
That is not particularly concerning - looks like another consequence of the refresh code not running after a reboot. The question becomes whether the code is running, but erroring out, or if it is not running at all. A debug trace (add --log-level=debug to a Podman command) of the first Podman process run after a reboot would be appreciated.

Sorry,
i am a bit confused, because i would never put a container image on a tempoary filesystem.
The curious thing is, that this does not happend on a workstation F31 Installation with a user having a uid 1000.
I want to point our,that is stopped the container before i initiate a reboot. So there should not be any volatile data on a tmpfs directory at all, am i right.-

How can i support to solve it ?
How can i make sure, that the stopped state of the container will not get lost ?

What is happening is that Podman is not detecting and appropriately handling the reboot; as such locks are not reallocated, temporary directories are not recreated, etc. We detect reboots via a file created on a tmpfs directory, somewhere in RunRoot (as seen in podman info), which appears to be a tmpfs filesystem and should be recreated after reboot. If you can provide a --log-level=debug trace of the first Podman command run after a reboot, it would help debug what is going on (whether we are not detecting the reboot at all, or encountering an error when we try to handle it).

Salut Matthew,
first of all, thank you for taking some time to help me!
ok, here is what you have asked me for:
`[tlxoffice@chasmash docker_kivitendo]$ podman start 2f803416eaf0 --log-level=debug
DEBU[0000] Using conmon: "/usr/bin/conmon"
DEBU[0000] Initializing boltdb state at /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod/bolt_state.db
DEBU[0000] Overriding run root "/run/user/1001/containers" with "/run/user/1001" from database
DEBU[0000] Overriding tmp dir "/run/user/1001/libpod/tmp" with "/var/tmp/run-1001/libpod/tmp" from database
DEBU[0000] Using graph driver overlay
DEBU[0000] Using graph root /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage
DEBU[0000] Using run root /run/user/1001
DEBU[0000] Using static dir /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod
DEBU[0000] Using tmp dir /var/tmp/run-1001/libpod/tmp
DEBU[0000] Using volume path /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/volumes
DEBU[0000] Set libpod namespace to ""
DEBU[0000] Not configuring container store
DEBU[0000] Initializing event backend journald
DEBU[0000] using runtime "/usr/bin/runc"
DEBU[0000] using runtime "/usr/bin/crun"
DEBU[0000] Initialized SHM lock manager at path /libpod_rootless_lock_1001
DEBU[0000] Using conmon: "/usr/bin/conmon"
DEBU[0000] Initializing boltdb state at /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod/bolt_state.db
DEBU[0000] Overriding run root "/run/user/1001/containers" with "/run/user/1001" from database
DEBU[0000] Overriding tmp dir "/run/user/1001/libpod/tmp" with "/var/tmp/run-1001/libpod/tmp" from database
DEBU[0000] Using graph driver overlay
DEBU[0000] Using graph root /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage
DEBU[0000] Using run root /run/user/1001
DEBU[0000] Using static dir /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod
DEBU[0000] Using tmp dir /var/tmp/run-1001/libpod/tmp
DEBU[0000] Using volume path /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/volumes
DEBU[0000] Set libpod namespace to ""
DEBU[0000] No store required. Not opening container store.
DEBU[0000] Initializing event backend journald
DEBU[0000] using runtime "/usr/bin/runc"
DEBU[0000] using runtime "/usr/bin/crun"
INFO[0000] running as rootless
DEBU[0000] Using conmon: "/usr/bin/conmon"
DEBU[0000] Initializing boltdb state at /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod/bolt_state.db
DEBU[0000] Overriding run root "/run/user/1001/containers" with "/run/user/1001" from database
DEBU[0000] Overriding tmp dir "/run/user/1001/libpod/tmp" with "/var/tmp/run-1001/libpod/tmp" from database
DEBU[0000] Using graph driver overlay
DEBU[0000] Using graph root /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage
DEBU[0000] Using run root /run/user/1001
DEBU[0000] Using static dir /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod
DEBU[0000] Using tmp dir /var/tmp/run-1001/libpod/tmp
DEBU[0000] Using volume path /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/volumes
DEBU[0000] Set libpod namespace to ""
DEBU[0000] [graphdriver] trying provided driver "overlay"
DEBU[0000] overlay: mount_program=/usr/bin/fuse-overlayfs
DEBU[0000] backingFs=extfs, projectQuotaSupported=false, useNativeDiff=false, usingMetacopy=false
DEBU[0000] Initializing event backend journald
DEBU[0000] using runtime "/usr/bin/runc"
DEBU[0000] using runtime "/usr/bin/crun"
DEBU[0000] Made network namespace at /run/user/1001/netns/cni-db6a4b73-596b-6ec1-26db-fcead227882a for container 2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680
DEBU[0000] slirp4netns command: /usr/bin/slirp4netns --api-socket /var/tmp/run-1001/libpod/tmp/2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680.net --disable-host-loopback --mtu 65520 -c -e 3 -r 4 --netns-type=path /run/user/1001/netns/cni-db6a4b73-596b-6ec1-26db-fcead227882a tap0
DEBU[0000] overlay: mount_data=lowerdir=/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/4ZY7RHOX2TAAYZ6IO35HRQMUX4:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/EMX4EADEPNYIPC44S7BRU3ONO3:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/ZRL57DDOZYQAANFACBKABCS47S:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/XLAZHGJUWAJVWIF7CLZQ7H6ZQO:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/7S7KYZ3PUWAX5MTRRTPX2F5C3W:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/Y2F3XBWRTPYKUZBZD7O2LVRFMB:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/DT7APDD2TJCFPPKKDNF4WHE2M4:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/6DIBLEDQXK5MB6MQBQQ2INTHM3:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/N7VHH4AZ6GAMA2CSJZ7FKCYZUL:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/2UJC4S3Z6RO65JSU3K6LDXBZRW:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/EJYHYP6J72FVY3HKTTAYNSNAGQ:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/4VG766MZVJRNTTGVM5RUMPRUN5:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/LKARK4CLIV2VDBNFZT54L3FRJD:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/5ZFVM2R6MELOF7LYFAU64XUCBT:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/THOYQ5NTIZL2QCOI2524VCJ3WJ:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/VFF2UYOY225UMW3APVC35ZH6NN:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/H53OUC4CG45ZVMTL3T5A3CRYBF:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/ER4ZK6KNUCH275WMQGBZLMSAL2:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/F37KEJYE3AJLZE3QFK3CSD6LXI:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/2HWJ5PG6YDLO2SEVQEJOXSDS65:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/SXIUXRZRMN6RTBQ2YMZVWMSAJ2:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/BRMGEU4F65MSFTMOMW2AMSH7P6:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/O4ZCAP5RWZ4RZTBZAEOJEPUJHL:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/ZENWBLPY6MG7EM2XUWCTJWZWU4:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/YBZ7V5F6HSU6MT55PHUSBWLRPX:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/K6RRCAOLMYT3BFGDWGBWLNMHZP:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/AWBUAAVMVZUBVEQUHR3QMB4ZJM:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/JBVCEG5WZPRJPCN36FPBA7S5UX:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/POPIFKHISJMADXP726HNTDXYVM:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/6RS6ZMJY7FABMILQSONMCROEMK:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/3MDNMFCOBZM6PJ2QZEWL6C4QA4:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/NVPUFQI37N6NMT3IAQW3AL6O6K:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/SJIAYEZTDFEDLSDWZMQSXOJKV2:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/WUOGADXPXGQI5QV2VIK2KCEALI:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/OVUKVVJBWY5MGVEYAERXHSRSWN:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/JLX2HQUJVCD6HAPDXFAWA64AGF:/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/l/HBRR5H3IXUNKDZ27L3H532MPGP,upperdir=/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/6c24af328b9a145e647a6867097b39d485ac81a81184449d1c6bd3ea664376f6/diff,workdir=/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/6c24af328b9a145e647a6867097b39d485ac81a81184449d1c6bd3ea664376f6/work,context="system_u:object_r:container_file_t:s0:c581,c641"
DEBU[0000] mounted container "2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680" at "/mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/6c24af328b9a145e647a6867097b39d485ac81a81184449d1c6bd3ea664376f6/merged"
DEBU[0000] Created root filesystem for container 2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680 at /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/overlay/6c24af328b9a145e647a6867097b39d485ac81a81184449d1c6bd3ea664376f6/merged
DEBU[0001] Cleaning up container 2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680
DEBU[0001] Tearing down network namespace at /run/user/1001/netns/cni-db6a4b73-596b-6ec1-26db-fcead227882a for container 2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680
DEBU[0001] unmounted container "2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680"
ERRO[0001] unable to start container "2f803416eaf0": cannot chown run directory /run/user/1001/overlay-containers/2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680/userdata: chown /run/user/1001/overlay-containers/2f803416eaf0631157c571c41ae57aaf0a4b7bebf9b005f8feeacf9b10a96680/userdata: no such file or directory
`

DEBU[0000] Using tmp dir /var/tmp/run-1001/libpod/tmp
Is this directory on a tmpfs?
If not, that is why we're not detecting reboot. You could try deleting the libpod database at /mnt/raidSpace/Homes/tlxoffice/.local/share/containers/storage/libpod/bolt_state.db and your containers.conf (usually lives in ~/.config/containers/libpod.conf) and see if tmp dir is moved into /run/user/1001 where it should be.

Salut Matthew,
the directory /var/tmp/run-1001/libpod/tmp was not a tmpfs. So i removed the user and created a new technical user. After a reboot, the very first podman call gave me this:
 - - - -
INFO[0000] running as rootless
DEBU[0000] Using conmon: "/usr/bin/conmon"
DEBU[0000] Initializing boltdb state at /mnt/raidSpace/Homes/techlxoffice/.local/share/containers/storage/libpod/bolt_state.db
DEBU[0000] Using graph driver overlay
DEBU[0000] Using graph root /mnt/raidSpace/Homes/techlxoffice/.local/share/containers/storage
DEBU[0000] Using run root /run/user/1001/containers
DEBU[0000] Using static dir /mnt/raidSpace/Homes/techlxoffice/.local/share/containers/storage/libpod
DEBU[0000] Using tmp dir /run/user/1001/libpod/tmp
DEBU[0000] Using volume path /mnt/raidSpace/Homes/techlxoffice/.local/share/containers/storage/volumes
DEBU[0000] Set libpod namespace to ""
DEBU[0000] No store required. Not opening container store.
DEBU[0000] Initializing event backend journald
DEBU[0000] using runtime "/usr/bin/runc"
- - - -

So i figured out, where he goes:
[techlxoffice@chasmash docker_kivitendo]$ df -k /run/user/1001/libpod/tmp
Dateisystem    1K-Blöcke Benutzt Verfügbar Verw% Eingehängt auf
tmpfs            1604232       4   1604228    1% /run/user/1001

looks better. So let's start the stopped container:
[techlxoffice@chasmash docker_kivitendo]$ podman ps -a
CONTAINER ID  IMAGE                       COMMAND               CREATED         STATUS                     PORTS                        NAMES
29dc6c4e0d90  localhost/kivi_prod:latest  /lib/systemd/syst...  39 minutes ago  Exited (0) 12 minutes ago  <IP_ADDRESS>:9190->80/tcp  boring_zhukovsky
[techlxoffice@chasmash docker_kivitendo]$ podman start 29dc6c4e0d90
29dc6c4e0d9038ae7298b8faef2002d76476032c5aeb1002fd838adb3f702140

Isn't this fantastic!
Thanks Matthew!


Create python venv environments for python-based projects

🚀 Feature Proposal
Create pyenv environments for all manually-installed Python2 or Python3 projects.
Motivation
This will save the assessors time and effort.

Completed as part of splitting this role out from cisagov/ansible-role-kali.  See also cisagov/kali-packer#52.


artifactory oidc

Overview
Include a summary of the change and link to the issue it addresses.
Description
Include context, motivation, brief description, and an impact of the change(s). List follow-up tasks here.
How Has This Been Tested?
Describe the tests that you ran to verify your changes. Provide instructions for verification.

[ ] Test A (e.g. Test A - New test that does ... run in ...)
[ ] Test B

Checklist
Before submitting this PR, please make sure:

[ ] I have read the CONTRIBUTING document.
[ ] My code is consistent with the rest of the project
[ ] I have tagged the relevant reviewers and/or interested parties
[ ] I have updated the READMEs and other documentation of affected packages

References
Please list relevant documentation (e.g. tech specs, articles, follow up or related work) relevant to this change, and note if the documentation has been updated.

Hey @finn-tbd is still still a DRAFT? Should we rebase on main and keep it going?

very much still in draft (see failing CI). I wouldn't have a PR open at all, but the CI doesn't trigger until you open a PR


Themes for Vtable-gantt

For the left side of the table I can set the theme (option.taskListTable.theme), but the right side has to be styled manually. In this case there are limitations. For example, I cannot customize the underlayBackgroundColor parameter. If I set a dark theme for the left part of the table, the right part will have a white spot under the table anyway.
So, it would be nice to be able to set the theme for the whole table at once, or to be able to set the underlayBackgroundColor for the right part. If it is possible now, could you tell me how?

sorry，this option underlayBackgroundColor not write on website's tutorial. It can help you @vladpro3

Thank you! But it would be great to set the theme somewhere in one place for both the left and right side of the table at once


Due Date

Editor or section editor or secretary must be able to set a due date for author or reviewer. If due date is exceeded then they can be warned.


fix test compilation

I am not sure of the effects of removing this instance, but the tests compile now with Cabal.

fixed by 8276fb6fdb015a080a729f1fe7725de3081ddd8f

fixed by 8276fb6fdb015a080a729f1fe7725de3081ddd8f


Cm 1110 get quiz id endpoint

Codecov Report

Merging #380 (56815ba) into develop (e826416) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 56815ba differs from pull request most recent head 9bad3a8. Consider uploading reports for the commit 9bad3a8 to get more accurate results

@@           Coverage Diff            @@
##           develop     #380   +/-   ##
========================================
  Coverage    62.54%   62.54%
========================================
  Files           80       80
  Lines         2598     2598
  Branches       379      379
========================================
  Hits          1625     1625
  Misses         958      958
  Partials        15       15

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Change the reserved label key for env

What this PR does / why we need it:
This PR changes the special label key name to env from pipecd.dev/env.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice. Thank you.
/lgtm


winapi is seemly unmaintained may be more wiser to switch to the official windows_sys crate

Old: https://github.com/retep998/winapi-rs
New: https://github.com/microsoft/windows-rs
Might make a PR for that but for now just for creating this issue for notice. windows_sys crate seems also easier to use.

I don't really know which branch I should do a pull request on, they all have non matching commits @arcnmx could you please tell me how I can contribute ?

Here is an example on how to get edid from windows crate:
use windows::Devices::Enumeration::DeviceInformation;
use windows::Devices::Display::{DisplayMonitor, DisplayMonitorDescriptorKind};

pub fn list() -> Vec<Vec<u8>> {
    let mut edid_list = vec![];
    if let Ok(ref selector) = DisplayMonitor::GetDeviceSelector() {
        if let Ok(Ok(ref devices)) = DeviceInformation::FindAllAsyncAqsFilter(selector).map(|devices| devices.get()) {
            for device_information in devices {
                if let Ok(Ok(ref device)) = DisplayMonitor::FromInterfaceIdAsync(&device_information.Id().unwrap()).map(|device| device.get()) {
                    if let Ok(edid) = device.GetDescriptor(DisplayMonitorDescriptorKind::Edid) {
                        edid_list.push(edid.to_vec())
                    }
                }
            }
        }
    }
    edid_list
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_list() {
        let displays = list();
        println!("{}, {:?}", displays.len(), displays);
        assert_ne!(displays.len(), 0);
    }
}

With a Cargo.toml file as followed :
[dependencies.windows]
version = "0.44.0"
features = [
    "Devices_Enumeration",
    "Devices_Display",
    "Foundation",
    "Foundation_Collections"
]

While windows is a branch with the port from winapi to windows, v0.3.x is the next develop branch that already builds on top of it - so the next breaking release will include the switch-over.

Do you know when will it be done ? it would be nice to only have windows ddc api on windows. If you need any help please tell me where I can help and open a pull request.

Hi @arcnmx, Andrea here. I have recently started using your crate for a side project and I would also be interested in helping get the v0.3.x branch reach the release stage - may I ask you what is missing (if any)?

I've put together the 0.3.0 milestone to show what's missing. I primarily need to finish the enumeration I've been experimenting with and then release ddc 0.3.
For the most part testing helps - if you can try the branch out (depend on it and ddc 0.3 via git, or alternatively use ddc-hi 0.5), feedback in any direction can help push it along. I'm primarily using ddc-hi 0.5 and ddcset as a test implementation to validate the new release - but that isn't as necessary if others are using it successfully!

For easier testing and to remove myself as a bottleneck, the windows branch has been merged into main and released as an alpha.


Make small, reusable components

Make it possible to display individual components:

balance
disconnect button
payment component

And allow e.g. balance to be disabled on the button.
Also consider if these can be programmatically executed (such as disconnecting)

This is being worked on in other issues


Docs build fails with instrument view.

Instrument view for NMX is not needed right now but it was useful for mcstas xml parser,
so I tried to add it in the documentation as well.
But the document build failed due to the output.
It fails complaining about the number of lines. It seems to be related to this issue.
ERROR: Line 404 exceeds the line-length-limit.
WARNING: Each notebook should have at least one section title

It leads to the failure of linking the notebook page to the main page, since it couldn't parse the title of the notebook.
It happened locally and also in the CI build. (The docs build test itself doesn't fail but the notebook is not included in the main page.)
scippneutron doesn't have this issue so there must be a solution.
For now the instrument view is included as a code snippet, not as a cell.

For now the instrument view is included as a code snippet, not as a cell.

Can you post a link to where this is done? I'd like to look at the code to see if I can figure out what's going on.

For now the instrument view is included as a code snippet, not as a cell.

Can you post a link to where this is done? I'd like to look at the code to see if I can figure out what's going on.

Sorry...! Forgot to add the link. It's still in the open PR #18

Fixed by #23


Problem w change in media query processing

In this merge https://github.com/LoicMahieu/react-styled-flexboxgrid/commit/b832bb2e71ee281094c7eaf9d2fa545d81d81363 the workings of styled flexbox grid have been changed.
I don't think this is a good choice, and I'm having problems in my personal project because of this.
First, the merge changes em processing to px processing. This is not the way flexboxgrid (https://github.com/kristoferjoseph/flexboxgrid/blob/master/src/css/flexboxgrid.css) processes units and makes react-styled-flexboxgrid actually not flexboxgrid anymore.
The +1 on the min width was presumably the reason to switch to pixels, since this is the common way to prevent media query problems.  On my project I'm seeing single columns on two <Col xs={12} sm={6} [...] because of this.
In short, this can't be right.

Hi
First, thanks for your feedback.
The motivation behind #13 has not been explain and it's a shame ;) I didn't handle it directly so I can't explain clearly why we did this. I wasn't confortable with the fact to go to pixels values too.
I will come back here next week with the explanation and we could discuss about it.

Perhaps you could add the breakpoint unit type to the theme definition so that people can customize it, if they want that, but otherwise functionality is preserved

As illustrated in the following article, em should be used in breakpoints to work properly cross-browser and support users changing their browsers font-size

https://zellwk.com/blog/media-query-units/

If you read the comments in that article, you'll see evidence from folks that the author is incorrect in his conclusions - specifically the Safari not reporting px the same as the other browsers when zooming. If you look at the animated gif in his article, you'll see that the px test matches the other browsers' tests; its the em/rem tests that differ on Safari.  Px based queries get consistent results across browsers when zooming.
I just tested this on Chrome and Safari and both Chrome and Safari's media query with px behave the same. You can try with http://codepen.io/blyne/pen/mPwmvX (I changed from the 400px/25em/25rem to 640px/40em/40rem)

Good point @zentuit , i have overlooked the comments.
A media query using em or rem (e.g. max-width) is based on the size of the viewport.
The viewport isn't affected by the elements inside of it even if the elements are larger than the viewport. CSS gives us control over the font sizes of the elements, but not the viewport.

I guess that would explain the switch from em to px ?

Let's also not forget that this library is supposed to be a react implementation of flexboxgrid, which clearly goes the "em" way

Is there any plan to deal with this issue?

Sorry to being back late.
@mschipperheyn @splars I agree with you, this library is supposed to be kind of port of flexboxgrid and I want to follow their implementation.
I reverted the commit in #35 and it is published v1.1.0
Thanks


VSCode breaks when you try to delete a node_module which is used by a process on Windows 10

Title says it all

/needsMoreInfo


Python Sample Code Error

The Sample code for the Alternator load balancing, try1.py and try2.py when executing, gives the error
botocore.exceptions.NoRegionError: You must specify a region.

The line responsible for this is
    dynamodb = boto3.resource('dynamodb', endpoint_url=alternator_url,
            aws_access_key_id='alternator', aws_secret_access_key='secret_pass')

Updated code with the additional region_name='us-east-1' fixes the issue
    dynamodb = boto3.resource('dynamodb', endpoint_url=alternator_url, region_name='us-east-1',
            aws_access_key_id='alternator', aws_secret_access_key='secret_pass')

This is true, this is a strange AWS SDK bug, that you need a region name even if it's not actually used (because the explicit endpoint_url overrides the region anyway). The java/README.md explains (this text isn't present in python/README.md):

The region passed to withRegion does not matter (and can be any string),
because AlternatorRequestHandler will override the chosen endpoint anyway,
Unfortunately we can't just drop the withRegion() call, because without
it the library will expect to find a default region in the configuration file
and complain when it is missing.

As this text explains if you have in ~/.aws/config
[default]
region = us-east-1

The region_name option will no longer be required.
But I agree it's worth changing the test to include region_name='doesnt-matter' or something (I think using the name doesnt-matter instead of us-east-1 is better because it emphasizes that this parameter is needed but ignored).


Orchestrator API: Resolve Cleaning Request for Golden Record Update Endpoint

The BPDM Orchestrator should have an endpoint to resolve cleaning requests that have been reserved for Golden Record update.
Redoc
Open-API yaml

We dropped the idea of explicit endpoints for each cleaning step in favour of generic cleaning step endpoints found here: #458
Therefore, I will close this issue now.


Run integration tests in parallel

Description
Integration tests can take up to 27 minutes when we run them across 4 separate instances. Unfortunately our spitting of the tests is uneven. This PR lets CircleCI split the tests into 10 separate containers so that we get more even coverage and then it runs them in parallel.  Now the average time is closer to 16min.  Here's a breakdown of a single run:

You can read more about Running Tests in Parallel on the CircleCI website.  This also leverages the Cypress spec utility like we were using before.
Could we do this faster? Yes! But we'd have to do one e2e test per file and then use CircleCI's built in test timer to figure out how to split them. This is something we could address in the future if we wanted to.
Note: If accepted we have to update github's merge criteria first and then folks need to rebase on master to get this change.

We should test using https://www.cypress.io/dashboard before doing even more customization of our integration test runners.

We should test using https://www.cypress.io/dashboard before doing even more customization of our integration test runners.

Agreed, seems like a great tool. This PR doesn't change anything except how we divide up the tests. Previously I divided them up based on directory. Now its divided up based on filename in a predictable order. Same infra, same CI/CD, and no code changes. The advantage here is getting back 10+ min per run. It's probably the best optimization we have right now.
I also want to point out that integration tests aren't just testing out the cypress js stuff. It's also doing a lot of end to end testing on our infrastructure and containerization. So before we move them to move to the Cypress Dashboard we ought to confirm we aren't losing anything.

The only risk I foresee is if some tests depends on other tests to be run before them and when circle ci spilts them it might be ignorant of the fact.

The only risk I foresee is if some tests depends on other tests to be run before them and when circle ci spilts them it might be ignorant of the fact.

We should not be doing this anyways so not a ding but something to keep in mind.


Permission set "Quiz_Host" not found in target org.

Attempting to install with a brand new Dev Org, and the latest CLI version, 7.36.0, on a Windows machine and I get a few errors. I do get a username, password, scratch org id and url after these errors, but I am pretty sure without a permission set, it's not going to work properly.  Here is the terminal output:
PS C:\Users\Melissa> sfdx force:auth:web:login -d -a myhuborg
Successfully authorized<EMAIL_ADDRESS>with org ID 00D##############K
You may now close the browser
PS C:\Users\Melissa> cd quiz-host-app
PS C:\Users\Melissa\quiz-host-app> .\install-dev.bat quiz sample
Installing Quiz org:

Org alias:      quiz
Data:           sample

Cleaning previous scratch org...
Successfully marked scratch org quiz for deletion
Creating scratch org...
Successfully created scratch org: 00D##############A, username: test-<EMAIL_ADDRESS>Pushing source...
### MissingMessageError: Missing message source_push:commandDescription for locale en_US.
at Messages.getMessageWithMap (C:/Program Files/Salesforce CLI/client/node_modules/@salesforce/core/lib/messages.js:277:19)
at Messages.getMessage (C:/Program Files/Salesforce CLI/client/node_modules/@salesforce/core/lib/messages.js:261:21)
at Object. (C:/Program Files/Salesforce CLI/client/node_modules/salesforce-alm/dist/commands/force/source/push.js:28:45)
at Module._compile (C:/Program Files/Salesforce CLI/client/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
at LazyLoader.loadModule (C:/Program Files/Salesforce CLI/client/node_modules/@salesforce/lazy-require/lib/LazyLoader.js:139:21)
at Function._load (C:/Program Files/Salesforce CLI/client/node_modules/@salesforce/lazy-require/lib/LazyLoader.js:115:29)
at require (C:/Program Files/Salesforce CLI/client/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
at fetch (C:/Program Files/Salesforce CLI/client/node_modules/@oclif/config/lib/plugin.js:111:21)
at Plugin.findCommand (C:/Program Files/Salesforce CLI/client/node_modules/@oclif/config/lib/plugin.js:125:21)
at Object.load (C:/Program Files/Salesforce CLI/client/node_modules/@oclif/config/lib/plugin.js:58:72)
at Config.runCommand (C:/Program Files/Salesforce CLI/client/node_modules/@oclif/config/lib/config.js:149:27)
### Installation failed.
Assigning permissions...
### === Failures
USERNAME                       ERROR MESSAGE
─────────────────────────────  ───────────────────────────────────────────────────────────────────────────────
<EMAIL_ADDRESS>### Permission set "Quiz_Host" not found in target org. Do you need to push source?
Importing data...
### ERROR running force:data:tree:import:  The requested resource does not exist
Installation failed.

Hi @muel8192,
Looking at your logs, I can see that there's a first an error when pushing sources:
Pushing source...
### MissingMessageError: Missing message source_push:commandDescription for locale en_US.

If sources are not pushed, the install script won't be able to find and assign the permission set.
There seems to be something wrong with your CLI install as per the CLI node.js stack trace. That may be a CLI bug that is unrelated to this project.
Can you try to push sources again by running:
sfdx force:source:push

If that fails, can you check that you are able to source push on any other project like the LWC recipes sample app?

Using the push command failed and so did trying LWC recipes sample app. I uninstalled the CLI, and reinstalled and it worked in the originally intended to way. Apparently, you can install the newest CLI  over the old version without receiving errors, and see that it is the newest version, but when you use it, you get errors!