Aircraft not automatically disarming while in Land flight mode

Describe the bug
I'm having an issue where my hexacopter will not disarm once the aircraft has landed. The aircraft was flown in Position flight mode (or Stabilize flight mode) and then changed to Land flight mode. The aircraft is able to successfully descend and touch the ground successfully. However, instead of disarming, the motors speed up, which results in the aircraft wanting to tip over and crash.
I have looked on the internet and I have found that it is important to get the hover throttle percentage correct as well as  the manual minimum throttle percentage. I have adjusted these values but still no success. I also changed the parameter (COM_DISARM_LAND) to 0.1 seconds, but still no success.
I know that there isn’t an issue with the actual aircraft as I have managed to successfully perform a mission using APM firmware, where it was able to land and disarm safely.
Is this possibly an issue with the firmware or does someone perhaps know a solution to this problem?
P.S. I have disabled the arming switch (changed parameter CBRK_IO_SAFETY from 0 to 22027)
To Reproduce
Steps to reproduce the behavior:

Disable arming switch
Change flight mode to Position or Stabilize
Arm & takeoff to an altitude between (5 - 10 metres)
Switch flight mode to Land

Expected behavior
The aircraft should land and disarm successfully and not want to tip over and crash.
Log Files and Screenshots
https://logs.px4.io/plot_app?log=bc0410c1-4285-4781-bf1b-b6ddee3b120d
Drone
DJI F550 Flame Wheel (hexacopter)

Thanks for the issue and the log. @bresch do you see what the issue is? Is this expected with 1.9.2?

I have exactly the same problem with my Multicopter. Any updates on this?

We're planning to review the land detection logic in the near future. Please post logs here if you still have an issue with the land detector.

We're planning to review the land detection logic in the near future.

@bresch are you planning to review MC land detector, FW land detector, or both?  (I have comments related to FW land detector if that is with scope of your effort).

@Antiheavy I'll mainly focus on the MC land detector, but please, share your ideas for FW; I'll keep them in mind if I need to rework the interface.

I've had the same problem using APM firmware. Finally, it was found that flight control had installed ultrasonic height detection equipment, and it was normal to restore the default settings.


Quickswitch UI for Tunnel vs. Building Passage

Hi @quincylvania, I was using the new quickswitch UI (Location / iD Version) for https://www.openstreetmap.org/way/779926439 and noticed, that the tunnel was layer=-1. I now see, that the tunnel (type) building_passage was also not set, so the layer=-1 makes sense. (At first I thought it was a bug re-appearing that was in iD a long while ago; might be https://github.com/openstreetmap/iD/issues/4516.)
Ideally, the quickswitch would notice that the node I am starting with is connected to a building and choose the building passage. Or maybe the validator could pick that up to help me fix it right after I finished drawing (which would be https://github.com/openstreetmap/iD/issues/7377 I guess).

Ideally, the quickswitch would notice that the node I am starting with is connected to a building and choose the building passage.

This sounds okay.


Use built-in chalk typings and fix references.

Addresses issue #3452 .

Thank you for the PR. Unfortunately this is a duplicate of #3435

For future reference: always install / update / remove dependencies with yarn. Otherwise yarn.lock is not updated. That's what makes CI fail for this PR.
Closing as a duplicate of #3435


Mesh exploder

Description
This is just a tentative draft only to see if there's any interest in a little feature that I've found can be very helpful and revealing of problematic and sub-optimal meshes when I've previously implemented it as a little in-engine visualiser.
This just displaces vertex positions as a function of their local position and their vertex ID, which means that multiple vertices in the same position but which are actually distinct vertices (with different vertex IDs) are displaced by different amounts, revealing gaps between triangles that don't share the exact same vertices.
Sometimes those gaps are just where the mesh author expects (i.e. faceted triangle normals and/or texture co-ord breaks/seams will expose these breaks that partially duplicate coincident vertices) but sometimes they can reveal otherwise hidden, unintentionally broken meshes, which then exposes faults in the original source asset data and/or the asset pipeline.
This kind of visualisation has revealed a bunch of problems for me in different engines in the past, like -

Broken vertex welding code in asset pipelines
Excessive/unintended source asset vertex attributes getting used in asset pipeline processing
Unnecessary, never visible (e.g. interior double-sided) geometry
Even multiple sets of the same geometry overlaid on each other!

Yes, it's technically possible to identify the same things with the existing visualisation and vertex data table, if you're prepared to carefully and patiently examine the data, but it's much easier to just quickly waggle a slider to reveal these things.
Rather than re-implement the same kind of thing in different engines (some of which can be a real hassle), I thought that this kind of thing is quite well suited to renderdoc, so I gave this a go.

A few things I should probably mention -

There seems to be no existing QSlider widget anywhere in rdoc, so when I initially added a slider widget, it draw nothing and, not being familiar with Qt, it took me a while to figure out that I seem to have to implement some rudimentary slider bounds and drawing code myself.  Is that expected?  Is there a simpler way to achieve better slider drawing than the way I've tried it?
Because renderdoc's mesh visualisation cannot rely on any other vertex attributes (e.g. we don't always have normals or any attributes other than position available) then choosing a good vertex displacement direction only based on position can result in us exploding the vertices along directions that aren't particularly effective in revealing the disjoint gaps.  Perhaps it would be possible to build up an extra vertex attribute set used by renderdoc's mesh visualiser, which fills in a better displacement direction (like an average of all adjoining triangle face normals would often make for better/cleaner mesh explosion), which can then be used by the rdoc mesh visualiser vertex shader,  but that feels like something only worth doing as a later refinement (if any of this gets any interest).

I can seen how it's slightly ... unusual, so I won't mind if it's not to your taste but it would be nice to also understand where you think the drawbacks might outweigh the benefits I've tried to describe above.  Please let me know what you think.

Thanks for getting in touch with an early checkin/feedback, that's really helpful when developing any change. I think this would be OK to add - I'd say it's definitely niche in its use, but it's fairly light on implementation complexity and doesn't add a huge extra maintenance burden or interfere for people who aren't using it.
The thing I would say at a high level is that it would make sense to have this as more of a feature you enable when you want it, than having the slider always visible by default. Maybe it should be one of the solid shading modes, if that makes sense? If that was renamed from 'solid shading' to 'visualisation mode' it might be more inclusive of this concept.
That way there isn't a slider present all the time for people who only want its use occasionally or might not understand what it's for as it's not as immediately intuitive as wireframe or vertex highlighting. This also allows you to be a bit more generous with the UI - e.g. I don't see a reset-to-default button which would be useful if you accidentally nudge it and want to set it back to 0, and you might want different exploding algoithms or weightings.
As a more minor implementation note - might it make sense to implement this inside the flat shaded geometry shader? That way you have a per-triangle face normal to work with for the direction. The vertex ID could be passed through easily enough from vertex to geometry stage.
The lack of slider theming in the custom theme is indeed because there's not been a slider before - the custom theme only covers the controls currently in use. It can probably be tweaked a bit but I'll wait until this PR is more final.

As a note just to avoid miscommunication, while this is marked as draft then unless you specifically request comment or a review I'm not going to do so as you may be pushing intermediate commits while working on this. Also while it's a draft I'll stick to high level feedback and wait for precise feedback until it's more final.

Yes I wasn't sure which was going to land first but indeed there was a new solid shade/visualisation mode added recently for mesh shader support.
Regarding the commits - squashing is fine especially with a hefty conflict resolve for this.  It's certainly something to strive for but logical separation is an ideal not a requirement. The only thing I am strict about is that each commit individually should comply with clang-format and compile (so no commits in PRs which only fix compile errors or formatting). Everything else is negotiable IMO.
I'll do a more detailed review next week as I'm away for the weekend. The meshletCounts fix sounds good, I think the if(!pipe) is a bit indirect - the lit-shaded pipeline will not be created when the topology is point, so it will end up as NULL there and so we fall back to just 'solid'.

so no commits in PRs which only fix compile errors or formatting

OK. You can see I've immediately broken that with what I hope are fixes to some python and documentation tests 😄 but rest assured, the intention isn't to leave it like that;  it's just so you or anyone who may be interested can see what subsequent smaller incidental or incremental changes have been made, but once everyone's happy with everything, I'll squash them into the main feature commit.

Regarding -

I don't see a reset-to-default button which would be useful if you accidentally nudge it and want to set it back to 0

it automatically snaps the slider back to 0 when released (although there seems to be some other weird widget interaction that I'm not familiar with, which manages to move the slider in a way that doesn't give us a 'on released' event to snap back to zero 🤷 ).
Re. -

might it make sense to implement this inside the flat shaded geometry shader? That way you have a per-triangle face normal to work with for the direction. The vertex ID could be passed through easily enough from vertex to geometry stage.

I might have misunderstood but I'm not sure how that would work.  If we defer displacing vtx positions until the GS, where we construct face normals from the tri positions, then exploding/displacing along the tri face normals will always shatter the resultant mesh into individual shards with gaps between all primitives, even with vertices that are shared between prim edges because the GS is emitting a triplet of new displaced verts for each primitive;  the useful aspect of the visualiser is to reveal cracks along primitive edges where the underlying vertex IDs are not shared (well, that and helping to reveal additional coincident duplicate primitives).   I think the ideal way to reveal that would be to calculate a displacement normal for each vertex ID as an
average of all triangle face normals that share/reference it, but that's beyond the ability of a geometry shader.  That kind of thing would require a CPU-side traversal of the entire draw's index list before then baking these calculated displacement normals into a new vertex stream... all of which starts to complicate things quite a bit and I worry may well have unforseen complications/interactions with other systems in rdoc.

I hope this wasn't premature but I've squashed all the feedback changes down into one feature commit now and also changed from a draft PR to a normal PR.


Reading a cookie value

Hi,
I want to get the cookie of web page. Could you please tell me how can we get the cookie ?

For the time being, you can read a cookie using the ExecuteScript keyword and executing a client-side script, like this:
- description: Read a cookie named "MyCookie"
  action: org.getopentest.selenium.ExecuteScript
  args:
      script: |
      function getCookieValue(cookieName) {
          var regexResult = document.cookie.match('(^|[^;]+)\\s*' + cookieName + '\\s*=\\s*([^;]+)');
          return regexResult ? regexResult.pop() : '';
      }

      // Replace the cookie name in the line below
      return getCookieValue('MyCookie');

  - script: $log("The cookie value was " + $output.result);

Make sure to replace the cookie name in the script with the one that you want to read.
In the next OpenTest version we will have a specialized ReadCookie keyword that you'll be able to use for this.

Your given code is not working in my scenario:
I want to read all the cookies present , but not getting all the cookies value one is missing here.
Also Attach the picture:
I am using this code :

description: Read a cookie named "MyCookie"
action: org.getopentest.selenium.ExecuteScript
args:
script: |
function getCookieValue() {
var result = document.cookie;
return result ;
}
return getCookieValue();
script: $log("The cookie value was " + $output.result);

Click on the "Console" tab in the Chrome developer tools and manually run the code document.cookie to check if you see the cookie you are looking for. If you can see it there, my guess is that your test might be trying to read it at the wrong time, when the cookie is not created yet. Maybe the cookie is created by some JavaScript code that takes a while to execute. You can try adding a delay before reading the cookie, just to see if that makes any difference.

It is working..
Thanks for reply :)


typo in installation instructions

Many operating systems are case-sensitive, so pip install -e qspectra will search for a folder with that casing. However, the GitHub repo has capital Q and S which will be preserved in the git clone.

thanks!


Number of delegates for each category

@mmahdigh pls let us know if you have any updates

@mmahdigh pls let us know if you have any updates

Hi! Sent it into the group.


Arc A770 Slow speed

Discussed in https://github.com/GpuZelenograd/memtest_vulkan/discussions/51

Originally posted by mia14112 December 15, 2024
Hi, my Arc A770 is real slow in the test. In GPU-Z the Bandwith is 512gb/s and in the test it's only achieving ~105gb/s. The fans are not even starting to spin on the card.

My System is:
Ryzen 7700X
X670E Carbon
64GB DDR5
Asrock A770 8GB
Corsair HX1200

Hi, the card is only drawing ~144w (max is 252) and only ~4gb of memory are actually used.
CPU usage was around 2% during the run.
HWInfo is saying the Card is limited by PL4 (Powerlimit 4) which seems odd as PL4 should be 800W

Originally posted by @mia14112 in https://github.com/GpuZelenograd/memtest_vulkan/discussions/51#discussioncomment-11574007
~2-3gb/s read and ~0.1-0.2gb/s write without memtest running

Thanks @mia14112 for reporting!
I'm summarizing here the discussion result:
The so low bandwidth usage is definitely an issue. And its quite starnge that much higher read bandwidth is reported by GPU-Z. Maybe the Arc GPU somehow do strange things regarding read caching - either is pulling to huge blocks  that then are discarded before usage or discards small blocks to early before they are processed. Or uses exessive read operations during the writing stage for some reason.
The "only ~4GB tested " is unrelated  problem. Some drivers do not expose more then 4Gb in a single block. This is not related to low bandwidth and appears on some AMD gpus too, not to severe problem for signal lines stability testing, so this may be treated as minor by now.
Unfortunately, I don't think that I can fix this before I perform some debugging on an Arc GPU.


Derived table outer scope visibility

Add support for outer scope visibility for derived tables, as introduced in MySQL 8.0.14.
References:

MySQL Blog Post: Outer references for derived tables
MySQL Worklog task and notes for derived table outer scope visibility

Resolves: https://github.com/dolthub/dolt/issues/4534
Remaining Work:

merge in latest GMS changes from main and retest
run Dolt CI tests – https://github.com/dolthub/dolt/pull/4472

Thanks for the feedback @max-hoffman. I've got subquery alias caching working correctly now and all tests are passing. I'm still waiting on Dolt CI tests to run (https://github.com/dolthub/dolt/pull/4472), but they're looking good so far.
I did have to add one hack that I would still like to unwind... I changed CachedResults.WithChildren to not return a new instance, in order to fix the cache mem leaks I was seeing. That obviously isn't a good change, but I figured it might be okay for a short amount of time while we fix the CachedResults mem cache leak.
I'm going to give the code another review myself this afternoon and make sure there aren't any TODOs left in there or anything else to clean up, but other than that I think it's ready for you and @zachmu to comb over and see if you see any concerns.

I found a bug where the local cache is filled and successfully copied to the global cache, but there is only one primary row and the next step of copying the global cache into HashLookup and deleting the global cache is never triggered. This got me thinking more about the whole cache setup we have going on. Afaik the handoff is error proof right now, but is the handoff complexity necessary? Should the *sql.Context just be responsible for cache lifecycle if there is always a global component? I think your cache identifier and global ids are more dev-friendly than opaque disposal functions (maybe a combination of session Id plus incrementing integer would be a slight improvement for multi-user sessions). Nodes communicating cache references by id, and then using get() and dispose() into the context-managed caches all the way through just seems simpler?


(menu) - export the items count

Bug, feature request, or proposal:
Proposal
What is the expected behavior?
When a menu has no items the trigger should be hidden / disabled, otherwise the client press on a button that do nothing.
Currently I'm working on a wrapper that accept the menu from the nested component.
I can't know what menu-items would be provided, but I know I don't want to show the trigger button if the menu is empty.
I know in the past there was a query list, but now it's deprecated.
Is there any way to know from the menu itself it it has no children items? (instead of passing around another input to indicate if the menu should be visible)?
What is the current behavior?
The menu will be opened even if there are no items to presents
What are the steps to reproduce?
https://stackblitz.com/edit/angular-6e1x8z-6pd65g
What is the use-case or motivation for changing an existing behavior?
Mentioned above
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 7.0.2
Node: 9.0.0
OS: win32 x64
Angular: 7.0.0
... compiler, core
Package                      Version
@angular-devkit/architect    0.10.2
@angular-devkit/core         7.0.2
@angular-devkit/schematics   7.0.2
@angular/cli                 7.0.2
@schematics/angular          7.0.2
@schematics/update           0.10.2
rxjs                         6.3.3
typescript                   3.1.3
material              7.0.2
Is there anything else we should know?
Maybe the default behavior is fine, but I really think there should be an indicator in the menu level if it has children items or not.
Thanks

I can't know what menu-items would be provided, but I know I don't want to show the trigger button if the menu is empty.

Why wouldn't you know which items are provided? I'm assuming that you'll have something like:
<mat-menu>
  <button *ngFor="let item of items">{{item}}</button>
</mat-menu>

In this case you can look at the length of the items. The MatMenu component does expose the items property which contains the amount of items in the menu, but you should keep in mind that using it in the view might lead to "Changed after checked" errors.

Thanks for the response.
Unfortunately, my case is not so easy.
As I mentioned above, the menu button is inside a infrastructural component.
The user can wrap his component around his component and provide a template for the menu itself Meaning I don't have something like
<button *ngFor="let item of items">{{item}}</button>.
I guess it's more like this example: https://stackblitz.com/edit/angular-material2-issue-rrryta
You can see that from the wrapper component I can't have any indication whether the mat-menu provided from app.component has items.
(I actually have another layer of abstraction  that renders a ng-template inside the mat-menu, but I think the stackblitz demonstrate the problem)
Do you have any suggestions?
Thanks

It seems the items property is deprecated (At least from the documentation), that's why I started this issue from the first place.
Is there any other way to achieve that?
Thanks


Density Corrected Wind Speed Input

If a wind speed signal that has been density corrected outside the tool is input directly the tool has no way to know that the correction has already been performed. Wind Speed column definitions should have a "Density Corrected" property that defaults to False.
In the context of PCWG Share 1 this is a problem if density correction is applied externally and then density (or pressure and temperature) are defined in the dataset config as the analysis will then automatically apply density correction.

This feature is now added to the 'Advanced' tab on a dataset.


Focus Button UX Updates

Use Case
Problems:

Styling for button states do not clearly reflect on vs off
There is no indication when clicking the button that anything has or will happen
It is not clear what the button does (without player on, especially) or that there is a connection between clicking an agent and button

Acceptance Criteria
Ticket #320 is a part of the acceptance criteria for this ticket. Styling updates to button.
Implement new tooltip language
Details
Design Link: https://xd.adobe.com/view/75b6a3c8-f650-443b-bccc-d1fcd134a35e-20e5/
This is the dev implementation ticket for UX ticket #247

Also warn user if they toggle focus without an agent selected, depending on https://github.com/simularium/simularium-viewer/issues/122


Version 2.x branch uses 'const' in one place

logger.js line 17: const formatRegExp = /%[sdj%]/g;
Since 2.x is supposed to run against node 0.10, and there is only a single instance of const in the 2.x codebase, I think this is a bug.

PR here: https://github.com/winstonjs/winston/pull/902


GDScript: Fix error message for unfound type

old: "Foo" was not found in the current scope.
vs
new: Could not find type "Foo" in the current scope.

Make the message consistent with other errors in  resolve_datatype, now it is more clear that a search subject is a type.
Related to #73663.

Thanks!


Support exponential backoff for chunkRetryInterval

An exponential backoff algorithm should be used to prevent Resumable.js from causing traffic spikes.
Implementation could be allowing a function reference for chunkRetryInterval, with a default function implementing exponential backoff with closure.
wait_time = 4ms
while not success:
    # double the wait for each failure
    wait_time = wait_time * 2
    # prevents "waves" of retry traffic
    wait_time = wait_time + random_ms()
    wait(wait_time)
    attempt_transmission()

+1

I'm trying to implement that in a retry callback by updating the chunkRetryInterval (doubling up to a max, resetting when progress is made) but I can't figure out how to update the options of my Resumable object.  Any hints?
The basic idea:
    r.on("fileRetry", function (file) {
        var newRetryInterval = Math.min(r.opts.chunkRetryInterval * 2, maxChunkRetryInterval);

        console.log("Increasing retry interval from", r.opts.chunkRetryInterval, "to", newRetryInterval);
        r.opts.chunkRetryInterval = newRetryInterval;   <=== not taking effect AFAICT
    });
    r.on("fileProgress", function (file) {
        if (r.opts.chunkRetryInterval > minChunkRetryInterval) {
            console.log("Resetting retry interval after progress");
            r.opts.chunkRetryInterval = minChunkRetryInterval;
        }
    });


clear without limit

rocksdb has a very nice DeleteRange API which is non blocking and would be great for clear. However, there are two problems:

Open end is not supported. (Could be hack emulate with '\fffffffffffffff')
Limit is not supported.

Any chance of making these optional in the level API?

Optionally if we could add a deleteRange API call and discourage clear.

Why is DeleteRange better? Especially if it does not support these options?

Because it's non blocking. It can apply the delete lazily while applying it to all preceding reads.

Not sure I understand what you mean by non blocking.

Not sure I understand what you mean by non blocking.

It doesn't block the thread.

From the JS side that doesn't matter. Unless your concern is not having enough threads in the async worker pool (for things other than level)?

I'm actually trying to do all the write operations in the main js thread due to a few different reasons:

Avoid marshalling data to the thread pool.
Increase consistency with reads, i.e. writes are immediately visible for preceding read calls.
Avoid problems with writes being applied out of order due to thread pool scheduling.

In rocksdb and I believe also leveldb writes are non blocking as long as the writing threads can keep up.

Not sure if there's anything left to answer here. I'll address some specific points:

Open end is not supported

That simply makes it incompatible with the abstract-level API. Unlike limit, the use cases for ltgt options are (I hope) obvious and these options are a core part of level. So can't make this an optional feature.

Limit is not supported

See https://github.com/Level/abstract-level/issues/38#issuecomment-1264189479 - which was a duplicate issue?

Optionally if we could add a deleteRange API call and discourage clear.

I don't want to add RocksDB-specific features that are a limited subset of existing functionality. Your implementation is free to have additional methods ofc (like deleteRange). Perhaps a better way forward is to not follow the abstract-level interface at all, if the requirements are too different.

Increase consistency with reads, i.e. writes are immediately visible for preceding read calls. Without having to add a lot of complicated write barriers and read queuing in the binding.

You have have a fundamentally different idea of what the order of operations should be. Which is fine, but it's not level. Level promises consistency in a simple way: want to know that a write finished? Await it. Subsequent reads are then guaranteed to include that written data.

Avoid problems with writes being applied out of order due to thread pool scheduling.

Same applies here: userland code can decide (to care about) the order, by awaiting.


Converting inner/outer surface files to WM and pial format in Freesurfer

Hi HippUnfold Experts,
Thanks a lot for your efforts to create a great package! I am working on a 7T laminar-resolution fMRI project to extract BOLD signal across different gray matter layers of the hippocampal subfields. To this end, I need to first delineate pial/GM and WM/GM boundaries of the hippocampus and subsequently bin the GM area to several depths using this toolbox . It works with Freesurfer surfaces namely .pial and .white outputs but freesurfer does not provide surface-based tissue delineations for subcortical regions (see the attached file as an example). That's where HippUnfold comes handy as it generates inner, outer and midthickness .gii files that I believe correspond to WM, pial and GM, respectively. My questions to you: 1) is there a way to convert those inner and outer .gii files to .white and .pial format? I tried mris_convert to change the .gii files to ASCII which is readable by OpenFmriAnalysis toolbox, but the outputs lose geometry and do not match the corresponding anatomy anymore. 2) Could you please clarify what exactly the midthickness surface represent?  I would greatly appreciate hearing your thoughts.
Many thanks and best wishes,
Khazar

Hi Khazar,
2: The midthickness surfaces are very similar to those generated by Freesurfer (in the image below, cyan is similar to orange; green to yellow, and blue to red). That is, it is 50% of the distance between the inner and outer surfaces using this method to correct for shifting laminae between sulci and gyri.
1: For converting surface files, I'm surprised that mris_convert didn't work out-of-the-box, but you could you try again with the extansion .mgh in the output to specify that it is a surface?
Also note that Nibabel or Matlab's gifti toolbox work great for loading surfaces!

Hi Jordan,
Thanks for the quick feedback! As recommended, I changed the output extensions and it worked. No geometry issues anymore :)
Just a follow-up question. I ran HippUnfold with singularity using a T2w modality (inplane resolution 0.43 X 0.43, slice thickness = 1.5 mm) and added the --t1-reg-template flag. The T1 image has an isotropic voxel size of 0.75 mmm. I suppose this approach is superior than running HippUnfold using the T1 modality only. Right? Is the T2 image being aligned to individual T1 image during the processing? or the use of T1 is meant to guide the template registration? It would be great if you could kindly elaborate on this. Thanks a lot already in advance!
Cheers,
Khazar

Glad to hear the surface conversion worked!
Yes your correct that the --t1-reg-template flag is ONLY for registration to template, and this is often not even needed as the T2w can usually be registered without issue (i usually would only use this flag if the T2w registration had failed already).
T2w images are often preferred in the hippocampal subfields literature, but aren't necessarily better in HippUnfold. It sounds like your T1w and T2w images have comparable voxel volumes, so I expect they should perform equally well in HippUnfold. I personally have a preference towards T1w isotropic images since they tend to show a bit more detail in the head and tail of the hippocampus, but it will also depend on image quality (eg. SNR or artefacts like dropout). You could judge by what you can subjectively see in the two types of images, or just try both (ie. using a separate output directory for each modality) and see which looks nicer (again by subjective judgement. If you post a few screenshots I'd be happy to offer my opinion, but I suspect you'll do fine on your own too!)


Remove flowdock support

Change-type: major
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!


High CPU usage

Thanks for this great tool!
I noticed that when running the deck from the documentation, my CPU goes to almost 100%. Do you know why?
from spiel import Deck, present

import inspect
from textwrap import dedent

from rich.box import SQUARE
from rich.console import RenderableType
from rich.layout import Layout
from rich.markdown import Markdown
from rich.padding import Padding
from rich.panel import Panel
from rich.style import Style
from rich.syntax import Syntax

from spiel import Deck, Slide, present
from spiel.deck import Deck

deck = Deck(name="Your Deck Name")

SPIEL = "[Spiel](https://github.com/JoshKarpel/spiel)"
RICH = "[Rich](https://rich.readthedocs.io/)"

def pad_markdown(markup: str) -> RenderableType:
    return Padding(Markdown(dedent(markup), justify="center"), pad=(0, 5))

@deck.slide(title="Decks and Slides")
def code() -> RenderableType:
    markup = f"""\
        ## Decks are made of Slides

        Here's the code for `Deck` and `Slide`!

        The source code is pulled directly from the definitions via [inspect.getsource](https://docs.python.org/3/library/inspect.html#inspect.ge
tsource).

        ({RICH} supports syntax highlighting, so {SPIEL} does too!)
        """
    root = Layout()
    upper = Layout(pad_markdown(markup), size=len(markup.split("\n")) + 1)
    lower = Layout()
    root.split_column(upper, lower)

    def make_code_panel(obj: type) -> RenderableType:
        lines, line_number = inspect.getsourcelines(obj)
        return Panel(
            Syntax(
                "".join(lines),
                lexer="python",
                line_numbers=True,
                start_line=line_number,
            ),
            box=SQUARE,
            border_style=Style(dim=True),
            height=len(lines) + 2,
        )

    lower.split_row(
        Layout(make_code_panel(Deck)),
        Layout(make_code_panel(Slide)),
    )

    return root

if __name__ == "__main__":
    present(__file__)

Hi! So, it's been a while since I thought about this code, but my first guess is that I believe Spiel tries to render every 1/30th of a second, so that's why there's consistent CPU usage. I am surprised it's that high though.
Would you mind trying to get an https://github.com/P403n1x87/austin speedscope trace? That could be useful to see where time is being spent in the render loop.


Slow trackpad scrolling while running LinearMouse

Thanks for the wonderful app in the first place, it finally replaced SteerMouse for me. But I just noticed some weird behavior while using my trackpad after a long time of only using my mouse. The scrolling speed is severely slowed down while scrolling slowly. This happens while all options in LinearMouse are disabled but is back to normal as soon as I quit LinearMouse so it has to be related.
Is it just me or can someone else confirm this behavior? Running macOS Monterey 12.0.1 on a 14" MacBook Pro.
Edit: This seems to be caused by the most recent release introducing sensitivity/acceleration settings. I cannot reproduce this on 0.2.8.

Thank you! Should have been fixed in https://github.com/lujjjh/LinearMouse/actions/runs/1561763028.


Fix SourcePost hook was not fired properly

Add ++nested to CmdUndefined/FileType hook for SourcePost event fire.
Remove unneeded ++nested
Change pattern of SourcePost to opt directory which resolved link

Thanks a lot. cheers!


Create gh-pages branch and move the code to there

If you create a gh-pages branch and move the code from master to there, you can take care of jekyll functionality. That way the URL can be http://codeformiami.org/miami-budget

https://help.github.com/articles/using-jekyll-with-pages/

Another idea would be to make a codeformiami subdomain like, miamibudget.codeformiami.com, at which point I'd like to host that on my AWS server in order to put it on a Meteor.js stack. That way this has an easy avenue of becoming an app. Additionally, it can have features like auto-deploy and such.
What do you think @ErnieAtLYD ?

so codeformiami.org is already DNS mapped to the github gh-pages branch. So any project that gets will be mapped to codeformiami.org - I actually have NO idea how subdomains work within the context of github, maybe @CristinaSolana or @CyberStrike knows?
I don't think meteor.js and github pages play nice together. But if there is functionality that will be added that will supercharge the budget app where meteor is necessary it may make sense to host the code somewhere else with a new domain (due to the previously mentioned mapping issues.)

http://miamigraph.com exists and takes care of this.


cloudflare_ruleset for rate_limit does not set the name right

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.7.3
on linux_amd64

provider registry.terraform.io/cloudflare/cloudflare v4.24.0
provider registry.terraform.io/hashicorp/google v5.16.0

Affected resource(s)

cloudflare_ruleset

Terraform configuration files
resource "cloudflare_ruleset" "rate_limit" {
  zone_id     = data.cloudflare_zone.this.id
  name        = "Rate limiting to prevent DDOS"
  description = "Rate limiting to prevent DDOS"
  kind        = "zone"
  phase       = "http_ratelimit"

  rules {
    action = "block"
    ratelimit {
      characteristics = ["cf.colo.id", "ip.src"]
      period = 300
      requests_per_period = 10000
      mitigation_timeout = 600
    }
    expression = "cf.zone.plan eq \"ENT\""
    enabled = true
  }
}

Link to debug output
https://gist.github.com/gugdewescale/067f61872494f076a56b44fb270f6410
Panic output
No response
Expected output
The output is right in Terraform but the result is not right in Cloudflare.
The name I set is not right. Instead there is a random generated ID.
If I modify the random generated name with a new one and trigger a Terraform plan I get no modifications. For Terraform everything is all right.
Actual output
  # module.cloudflare_waf["ulocation"].cloudflare_ruleset.rate_limit will be created
  + resource "cloudflare_ruleset" "rate_limit" {
      + description = "Rate limiting to prevent DDOS"
      + id          = (known after apply)
      + kind        = "zone"
      + name        = "Rate limiting to prevent DDOS"
      + phase       = "http_ratelimit"
      + zone_id     = "[REDACTED]"

      + rules {
          + action       = "block"
          + description  = (known after apply)
          + enabled      = true
          + expression   = "cf.zone.plan eq \"ENT\""
          + id           = (known after apply)
          + last_updated = (known after apply)
          + ref          = (known after apply)
          + version      = (known after apply)

          + ratelimit {
              + characteristics     = [
                  + "cf.colo.id",
                  + "ip.src",
                ]
              + mitigation_timeout  = 600
              + period              = 300
              + requests_per_period = 10000
              + requests_to_origin  = false
            }
        }
    }

Steps to reproduce

Terraform apply
Check Cloudflare WAF rate limits rules

Additional factoids
No response
References
No response

this isn't an issue with the terraform provider. as the HTTP interactions show, the name property is set correctly. if you're seeing it being represented differently in the dashboard, you should open a support ticket to have it escalated to the team to investigate or provide the reasoning.


Sometimes getting: Error: protocol security negotiation failure

Hi! Using FreeRDP 1.0.1 and FreeRDP 1.0
If I just try to connect to Windows XP machine with
xfreerdp -u user IP
it shows:
Error: protocol security negotiation failure
if I run the same command again and again for about 3 times for the fourth time it would connect.
Sometimes (after couple of failures) I provide --no-tls but it works.
But when I use --no-tls initially it would show (again, sometimes): Error: protocol security negotiation failure
I am having to run the same command again and again until it works.

just sudo  it


Uncaught Error: tunneling socket could not be established, statusCode=503

[Enter steps to reproduce:]

...
...

Atom: 1.55.0 x64
Electron: 6.1.12
OS: macOS 11.2.1
Thrown From: Atom Core
Stack Trace
Uncaught Error: tunneling socket could not be established, statusCode=503
At internal/streams/legacy.js:59

Error: tunneling socket could not be established, statusCode=503
    at ClientRequest.onConnect (/app.asar/node_modules/tunnel-agent/index.js:166:19)
    at Object.onceWrapper (events.js:288:20)
    at ClientRequest.emit (events.js:200:13)
    at Socket.socketOnData (_http_client.js:485:11)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:166:17)

Commands

Non-Core Packages

This could be a temporary network problem or maybe you are behind a proxy?

Yes, I was behind a proxy.

There goes the problem. I will go ahead and close this issue


[Frontend] Adjust CSS of "Create Modeling Tool"

Adjust the CSS, the input options and responsive messages with JavaScript (which were controlled by Angular till now).

Logo adjusted


Readme

add xinix
add links and emoji

make it nicer

Applied some formatting.

add pics
add links (mkat xinix discord?)

Rewrite readme according to project vision


DragBehavior: Transform window coordinates to parent coordinates befo…

...re dispatching
I'm not sure but I think DragBehavior should be fixed.
Because in DragBehavior._change_touch_mode(), touch is Window Coordinates.
At least this pull request fix #5480
sorry for my bad English

Is there any specific problem this PR fixes? I don't see #5480 as an issue (I might be wrong, but I think it's just misunderstood drag_timeout).

I commented to #5480.
Well if you don't see it as an issue please close this PR.
Since I'm not fluent in English I might misunderstand the documentation.
@KeyWeeUsr

@gottadiveintopython Thanks for the fix! I didn't notice the touch isn't corrected before checking for the collision the first time. 🍡

You're welcome  :ice_cream:
Love Kivy


PyDot does not quote attributes containing colons

I noticed a bug where using a colon (:) in an edge label caused a crash. I was able to fix it by escaping the colon with a blackslash: \:.
Here was the error I received:
"dot" with args ['-Tpng', '/tmp/tmph0iza0_n'] returned code: 1

stdout, stderr:
 b''
b"Error: /tmp/tmph0iza0_n: syntax error in line 9 near ':'\n"

Thank you @peternowee; I don't 100% understand what those issues are talking about, so I cannot say for certain that they are the same issue, although they certainly sound related. I will work on the information that you asked for.
Is it feasible to add some 'sanitizing' to escape special characters (in the Dot language) in label attributes to improve the user experience? It is not a great experience to encounter an opaque error when using standard ascii characters in a string for a label, but I see that this may have consideration for backwards compatibility.

Okay here is the reproducible example:
Example Code
import pydot

def create_graph(label: str):
    graph = pydot.Dot('finite_state_machine', graph_type='digraph', rankdir='LR')

    # Add nodes
    graph.add_node(pydot.Node('0', shape='circle'))
    graph.add_node(pydot.Node('1', shape='doublecircle'))

    # Add edges
    graph.add_edge(pydot.Edge(0, 1, label=label))  # <- This is where the problem is occuring

    print(graph.to_string())
    graph.write_png('output.png')

Bad Path
If I call this on a label that has a colon:
create_graph("a:b")

It fails:
"dot" with args ['-Tpng', '/tmp/tmpqd2ls604'] returned code: 1

stdout, stderr:
 b''
b"Error: /tmp/tmpqd2ls604: syntax error in line 5 near ':'\n"

Traceback (most recent call last):
  File "test.py", line 16, in <module>
    create_graph("a:b")
  File "test.py", line 14, in create_graph
    graph.write_png('output.png')
  File "...pydot.py", line 1743, in new_method
    self.write(
  File "...pydot.py", line 1828, in write
    s = self.create(prog, format, encoding=encoding)
  File "...pydot.py", line 1956, in create
    assert process.returncode == 0, (
AssertionError: "dot" with args ['-Tpng', '/tmp/tmpqd2ls604'] returned code: 1

And the debug printout shows the problem:
digraph finite_state_machine {
    rankdir=LR;
    0 [shape=circle];
    1 [shape=doublecircle];
    0 -> 1  [label=a:b];
}

Note the lack of quotes around a:b in label=a:b.
Happy Path
When any sort of slash (/, \) anywhere in the label, there are quotes.
If I call this on a label that has a colon and a slash:
create_graph("a:b/3.4")

It succeeds, and we can see the label is quoted correctly:
digraph finite_state_machine {
    rankdir=LR;
    0 [shape=circle];
    1 [shape=doublecircle];
    0 -> 1  [label="a:b/3.4"];
}

It looks like this may be a duplicate of #118 (Automatically quote node names containing a colon), but I am not seeing any part of the label attribute being removed as seems to be the case in that issue.

This is issue is a duplicate of #258.

Yeah, the reason pydot does not add quotes to a:b is that attribute values are IDs according to the DOT Language definition, just as node or edge names are IDs. It then considers b to possibly be a compass/port inside the ID, as they are used in the endpoints of DOT edges, even though attribute values of course do not have a compass/port.
Indeed, because we are talking about attribute values here, we are talking about an exact duplicate of pydot/pydot#258. I see you mention while I am typing this. :smile: Not sure what you mean with Dot keywords, but as far as I can tell that is not the root cause of either that issue or the issue here. I consider pydot/pydot#258 a further duplicate of pydot/pydot#118 and pydot/pydot#224 in that they will probably all be solved in one go.
About your question of improving the user experience: The usual suggestion until now has always been to do additional quoting. That is: Wrap the name/attribute/value/ID in additional double quotes. See https://github.com/pydot/pydot/issues/28#issuecomment-92396615 or https://github.com/pydot/pydot/issues/38#issuecomment-92396729: '"Testnode:###@"' for some of the earliest suggestions for that. A recent example is in https://github.com/pydot/pydot/issues/258#issuecomment-795798099: fillcolor='"red:yellow"'.
But even that is not very user friendly and therefore I think we should have a better solution in pydot 2.0. See the discussions about colons, quoting, ports and new method signatures in pydot/pydot#118 and pydot/pydot#224, but also in pydot/pydot#72. No need to repeat all that here. A first proposal has been made in pydot/pydot#259, but still requires a lot of work. I have some personal notes on it already, but I have not gotten around to writing up a complete response. I also wanted to take a step back and think about the method signatures, transition for existing users, etc. Not ask the contributor for improvements on details first and then have to ask for a larger overhaul again later.
So subscribe to pydot/pydot#259 and the other issues mentioned above if you are interested in the future, better solution and until then I am afraid it will just be additional double-quoting, or backslashes as you found.
I was typing this answer while your comments were coming in, so apologies if it is a bit messy. I will go to sleep now, it is past midnight here already. Will see your reply in the morning. Good luck.


PV2-3206 - Upgraded projects to .NET 6

The SFA.DAS.Payments.ProviderAdjustments.ServiceFabric project has a packages.config file - can this be safely removed?


Added TiDB to list of third-party DB backends.

TiDB is a MySQL compatible database and has a backend for Django overriding features supported differently in TiDB as compared to MySQL.
We would love to get listed on the list of third party backends on the databases page.
Please let us know in case any changes are required to help us get listed here.
Thanks!

@zhangyangyu Thanks :+1:


yarn.lock

Should remove the yarn.lock file here. See<EMAIL_ADDRESS>for more info

Yeah that would be great. Originally I was under the impression it was as good thing to commit. Thanks for the reading material :+1:


Next

Realign ci fixed added in next branch

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix: unstable sort skips/duplicates issues across pages

When viewing issues in sorted order, some issues are duplicated across pages and some are missing. This is caused by the lack of tie-breakers in database queries, making pagination inconsistent.
Fixes #13395.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@16adaae). Click here to learn what that means.
 Consider uploading reports for the commit 2643991 to get more accurate results

@@           Coverage Diff           @@
##             main   #18094   +/-   ##
=======================================
  Coverage        ?   44.89%
=======================================
  Files           ?      824
  Lines           ?    91586
  Branches        ?        0
=======================================
  Hits            ?    41119
  Misses          ?    43871
  Partials        ?     6596

Impacted Files
Coverage Δ

models/issue.go
58.94% <35.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16adaae...2643991. Read the comment docs.

@lafriks can you also review this PR?

Looks good from my side


benchmarks_setup.bat

Uploading initial windows .bat file
Issues still need to be fixed from https://github.com/Significant-Gravitas/Auto-GPT-Benchmarks/issues/21

@jonathansheets517 If you would find this valuable we can merge this in or edit it.
Let me know.


Fix authentication flow - #594

Description
Fix requested changes in PR #594

Update naming and comments
Add model_version param in auth request
Fix auth flow and properties in server_config
Check both secret and pub key if provided

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[X] I have labeled this PR with the relevant Type labels
[ ] My changes are covered by tests

I was testing MNIST example and made some additional fixes along the way


board boundry bugged

In the MFC_Ti_Flyback_rev2-PcbDoc.kicad_pcb (attached the test case), the y max that is returned seems to be about 0.0 when it should be about -35.
The x min is returned as 31 when it should be 25.
Just ran the current top-level app.
The actual board boundary is:
x_min     25.4
x_max    76.2
y_min   -38.1
y_max  -25.4
MFC_Ti_Flyback_rev2-PcbDoc.kicad_pcb.txt

Looks like the database uses pin positions only for board area.
Should be using the Edge.Cuts geometer. E.g:   (gr_line (start 138.2522 111.9378) (end 138.2522 98.0694) (layer Edge.Cuts) (width 0.4064) (tstamp 1CAD9470))

looks like not all our current designs have Edge.Cuts geometer, such as bm3??

looks like not all our current designs have Edge.Cuts geometer, such as bm3??

https://github.com/djmerrill/PCBBenchmarks/blob/master/bm3/bm3.routed.kicad_pcb

bm3 is the only one without. I'll add the Edge.Cuts to bm3.

bm3 now has Edge.Cuts
Please let me know if you find it missing in other test cases.


background sync

syncing the brews and recipes in the background when the user isn't currently on the page using service workers

this feature really only makes sense when doing extensive changes, seeing as the app its current form only changes text at the most this wouldnt be needed


angular 9 support

Modules are not working with angular 9 application. See below
ERROR in Failed to compile entry-point ngx-drag-and-drop-lists (main as commonjs) due to compilation errors:
node_modules/ngx-drag-and-drop-lists/module/module.js:17:35 - error NG1010: Value at position 0 in the NgModule.declarations of DndListModule is not a reference: [object Object]
17                     declarations: [DndDraggable, DndHandle, DndList, DndNoDrag],
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ERROR in node_modules/ngx-drag-and-drop-lists/module/module.d.ts:17:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class

17 export declare class DndListModule {
                        ~~~~~~~~~~~~~

I spent a few hours tracking this down, I was going to submit a fix, but it looks like the easiest solution for now is to disable ivy.  It doesn't look like it is going to be worth trying to fix, there is a more robust solution in @angular-cdk that is likely the way to go.
For the record, the workaround was:
tsconfig.json:
  "angularCompilerOptions": {
    "enableIvy": false
  }

@slegge
Hi,
thanks mate, I am trying this right now will let you know

I spent a few hours tracking this down, I was going to submit a fix, but it looks like the easiest solution for now is to disable ivy. It doesn't look like it is going to be worth trying to fix, there is a more robust solution in @angular-cdk that is likely the way to go.
For the record, the workaround was:
tsconfig.json:
  "angularCompilerOptions": {
    "enableIvy": false
  }

Yup its working now thanks.

hey @slegge / @rahul-inno - did you add "enableIvy": false to the parent application or to ngx-drag-and-drop-lists to get around the Modules issue?


Drop dependency on VLD (and use OpCache to dump bytecode instead)

Sure. But the main point here is to not depend on something outside of the standard distribution.

 Leaving windows aside, where installation is a case of downloading a single file, I would say for most users, it doesn't really matter what is part of a standard distribution anyway, because there is no such thing prepared by the group. Almost everyone relies on the packaging decisions made by the maintainer of the packages for their operating system, so what is standard isn't really down to the group anyway. You could bundle extension X with php-src, but it may still require additional installation steps in the real world. Similarly, it makes no different to most people that all of those extensions I listed are not part of php-src, because package maintainers make them as available as the php runtime itself.
I'm not really trying to talk you round, and as maybe obvious, I'm not really sure of the justification for taking the position that it's bad to rely on extensions, just trying to provide my perspective, and likely the perspective of most extension authors.
Maybe there is something I don't see that does make it bad, and I'd be happy to hear reasoning :)

From a userland perspective I can say

its easy to use what you get from your distribution/hoster (like you said)
it requires additional effort to use something not part of the distribution/hoster and a lot of people I met are not able to install other extensions or keep them up2date after installed once. Its a real peoblem of the eco system and would benefit if the process would get easier.
having less dependencies is always a net win, no matter how easy it would be to resolve them


expose nat underlay address by p2p service

Expose underlay address with NAT address parameters just as it would be communicated in the handshake in order to be discoverable in debugapi addresses response.
expected behaviour:
bee start \
    --api-addr=:8082 \
    --debug-api-enable \
    --debug-api-addr=:6062 \
    --data-dir=/tmp/bee2 \
    --bootnode="" \
    --p2p-addr=:7072 \
    --swap-enable=false \
    --nat-addr=<IP_ADDRESS>:7072

curl -s localhost:6062/addresses | jq

{
  "overlay": "473662ffe198262e95f74491b8cebe65c2de79b8376f2356cbf6ec7cf923eaac",
  "underlay": [
    "/ip4/<IP_ADDRESS>/tcp/7072/p2p/16Uiu2HAm2a5wd2Bo45haSDUKa5gYKdGJaQWrCVRcMqTSq2s9ossz",
    "/ip4/<IP_ADDRESS>/tcp/7072/p2p/16Uiu2HAm2a5wd2Bo45haSDUKa5gYKdGJaQWrCVRcMqTSq2s9ossz",
    "/ip6/::1/tcp/7072/p2p/16Uiu2HAm2a5wd2Bo45haSDUKa5gYKdGJaQWrCVRcMqTSq2s9ossz",
    "/ip4/<IP_ADDRESS>/tcp/7072/p2p/16Uiu2HAm2a5wd2Bo45haSDUKa5gYKdGJaQWrCVRcMqTSq2s9ossz"
  ],
  "ethereum": "0x0000000000000000000000000000000000000000",
  "public_key": "02b1ba590f9a3f5ce190bd13cbaeb9c320adf67e612020cff19f466415ab0a3b4c"
}

fixes #792

/beekeeper

@janos , I connected this with #792. Is that correct?

@Eknir yes, it is, it is linked. It would be nice to get some more reviews on this PR as it is here for a longer time.

@paxthemax this PR is waiting for a review for a few days, were you able to have a look at it?


8vim.com

I don't know if you plan to keep this domain, but it looks like you forgot to renew it (or to remove it from the project description and sources if not) ! 😉

yea... I was not able to set it up and yearly payments were draining my pocket, so I just let it go. Will fix the docs.

TODO: remove references to 8vim.com from the docs.

8vim.com redirects to crap now :(

And from link in app also...

bump.
I came here to report the link in the About Us panel.
The bad link looks really spammy.


Add geomorphon function

A geomorphon classifier would be nice to have here.
See:
https://svn.osgeo.org/grass/grass-addons/grass7/raster/r.geomorphon/r.geomorphon.html
https://search.r-project.org/CRAN/refmans/whitebox/html/wbt_geomorphons.html

Do you have a specific need/thoughts about it? I came across it earlier, but it wasn't that straightforward to implement.

Nothing direct, I'm in a workshop ecologists talking about using it as a simple terrain classifier. It seems like an interesting and alternative to the methods already here, and I just assumed it should go in this package if these was to be a Julia version. But yeah, maybe not so straightforward, I didn't actually look at the algorithms yet.
https://www.sciencedirect.com/science/article/abs/pii/S0169555X12005028?via%3Dihub


feat: add nonces to transactions

Fixes #468
What

Added support for transaction nonces in the client side
Fixed websocket unit test

Nonces are now required from the backend, and the frontend now queries the current nonce before submitting a transaction in order to be able to pass it as a parameter.
Why

to get closer to the ethereum specification and behavior
to help with preventing duplicated transactions and pave the way for other features such has replacing a transaction

Testing done

tested the new feature
tested the unit test fix

Decisions made

Nonces are a required parameter
Added an early exception to prevent transactions with an incorrect nonce
Had to add a check for from_address to allow the fund_account method to work (see transactions_processor.py)

Checks

[ ] I have tested this code
[x] I have reviewed my own PR
[x] I have created an issue for this PR
[x] I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Special attention requested on transactions_processor.py

User facing release notes

Implemented client-side handling of transaction nonces

Kindly requesting your review as well @cristiam86 to validate the functionality

Kindly requesting your review as well @cristiam86 to validate the functionality

sure, I'm on it


[Alsace20TV] Add new extractors Alsace20TVIE, Alsace20TVEmbedIE

Please follow the guide below

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
This PR adds support for extraction from two page types in the alsace20.tv site.
Requested in and resolves #30603. Thanks to OP @Shnoulle for additional testing documented there.

title is a required metadata field, so in this case it's deliberate.
The actual webpage (which isn't currently downloaded) may contain elements like this in its <head>:
<title>Votre JT du jeudi 3 février</title>
<meta property="og:title" content="Votre JT du jeudi 3 février" />
<link rel="image_src" href="https://www.alsace20.tv/videoimages/grand/220203_JT.jpg" />
<meta property="og:image" content="https://www.alsace20.tv/videoimages/grand/220203_JT.jpg" />
<link rel="canonical" href="https://www.alsace20.tv/VOD/Actu/JT/Votre-JT-jeudi-3-fevrier-lyNHCXpYJh.html" />
<meta name="medium" content="video" />
<meta property="og:video" name="og:video" content="https://www.alsace20.tv/hdr_visio/visio_v7.swf?key=lyNHCXpYJh" />
<meta property="video_width" name="video_width" content="480" />
<meta property="og:video:width" name="og:video:width" content="480" />
<meta property="video_height" name="video_height" content="270" />
<meta property="og:video:height" name="og:video:height" content="270" />
<meta property="og:type" content="video" />
<meta name="video_type" content="application/x-shockwave-flash" />
<meta property="og:video:type" content="application/x-shockwave-flash" />
<meta property="og:video:duration" name="og:video:duration" content="1073" />

So it would be possible to look for a title there, as is often done. But if that's missing from the API result, perhaps the result is broken in other ways. Also, the absence of title could be trapped and  caught as ExtractorError rather than KeyError, but other extractors don't generally do that.
The extractor might also fail with ExtractorError at self._sort_formats(formats) if no formats are found.


Marker cluster click

Does this module extends the clusterclick event? If yes, how do I do it? if no, do you have any recommendation to do it? I wanted to achieve getting the mid point of clicked clustered coordinates.
I checked this one on the leaflet doc, the click event:
https://github.com/Leaflet/Leaflet.markercluster

@jperelli Hi thank you for the enhancement. This is a very useful module.


Odd Error envelope routines parameter error

I just started getting this odd error when connecting a socket. The response crashes the nodejs 11.10 server
also other versions that worked for me otherwise too 11.9.
uncaughtException: [Error:<PHONE_NUMBER>58880:error:060CC07A:digital envelope routines:EVP_CIPHER_asn1_to_param:cipher parameter error:../deps/openssl/openssl/crypto/evp/evp_lib.c:81:
I recently rebuilt my certificate chain etc. Servers is topped up with highest bit Elliptical Keys
Signature Algorithm:  sha512ECDSA Public Key: ECC (384 bits) Params: ECDSA_P384 Version: V3
Anyway same settings I used before. Tried both TLS 1.3 chrome://flags enabled and not, etc.
Problem exists for both Chrome Version 72.0.3626.109 (Official Build) (64-bit) and latest Firefox as well.
so it's seems a problem in websocket.
I've used OpenSSL 1.1.0g  2 Nov 2017 to create the keys.
Something is changed to trigger this error but I'm not sure what.
Is there a way to better follow up and figure out what parameter is wrong and causing the error?

This does not happen with 11.8.0 and below. Something is failing since 11.9.0 and now also broken in 11.10.0


libmodsecurity - Stripping last character in ARGS: regex

It appears the last character in a regex string is being stripped when the rule is run.  I compiled libmodsecurity, the ngnix connector, and nginx on Centos7 about an hour ago.
Take the below rule:
SecRule ARGS:/test1/ "@contains teststring" "id:50,phase:2,t:lowercase,log,pass"
This should match when using the following URL query string: ?test1param=teststring123
Looking at the debug log, it does match but the regex we are evaluating against is test instead of test1:
[4] (Rule: 50) Executing operator "Contains" with param "teststring" against ARGS:regex(test).
[9]  T (0) t:lowercase: "teststring123"
[9] Target value: "teststring123" (Variable: ARGS:test1param)
[4] Matched vars updated.
[4] Running [I] (_non_ disruptive) action: log
[9] Saving transaction to logs
[4] Rule contains a `pass' action
[4] Rule returned 1.

Looking at the below rule, we should not match the supplied query string:
SecRule ARGS:/test12/ "@contains teststring" "id:50,phase:2,t:lowercase,log,pass"
Query String: ?test1param=teststring123
Since the last character seems to be stripped, it does match on test1 instead of evaluating test12:
[4] (Rule: 50) Executing operator "Contains" with param "teststring" against ARGS:regex(test1).
[9]  T (0) t:lowercase: "teststring123"
[9] Target value: "teststring123" (Variable: ARGS:test1param)
[4] Matched vars updated.
[4] Running [I] (_non_ disruptive) action: log
[9] Saving transaction to logs
[4] Rule contains a `pass' action
[4] Rule returned 1.

Thank you @Lcreager !!! Fixed at: c3a0d8d9bb49b0ffe7850b15fb8d0f1a2be00e55.


chore: release main

:robot: I have created a release beep boop
auto-instrumentations-node: 0.52.1
0.52.1 (2024-11-07)
Dependencies

The following workspace dependencies were updated

dependencies

@opentelemetry/instrumentation-aws-lambda bumped from ^0.46.0 to ^0.47.0
@opentelemetry/instrumentation-aws-sdk bumped from ^0.45.0 to ^0.46.0
@opentelemetry/instrumentation-mysql2 bumped from ^0.42.0 to ^0.42.1
@opentelemetry/instrumentation-pg bumped from ^0.47.0 to ^0.47.1
@opentelemetry/instrumentation-undici bumped from ^0.7.0 to ^0.7.1

instrumentation-aws-lambda: 0.47.0
0.47.0 (2024-11-07)
⚠ BREAKING CHANGES

aws-lambda: Remove explicit x-ray context in favor of global propagator (#2369)

Features

aws-lambda: Remove explicit x-ray context in favor of global propagator (#2369) (a926f53)
instrumentation-aws-lambda: take care of ESM based (.mjs) handlers (#2508) (0309cae)

instrumentation-aws-sdk: 0.46.0
0.46.0 (2024-11-07)
Features

aws-sdk: add s3 and kinesis service extensions for aws-sdk instrumentation (#2361) (a5b5614)

instrumentation-mysql2: 0.42.1
0.42.1 (2024-11-07)
Bug Fixes

instrumentation-mysql: fix test for mysql2 v3 (#2168) (#2451) (ad8c581)

instrumentation-pg: 0.47.1
0.47.1 (2024-11-07)
Bug Fixes

pg: Do not add SQLCommenter comments to prepared statements (#2456) (8070c7f)

instrumentation-runtime-node: 0.9.0
0.9.0 (2024-11-07)
⚠ BREAKING CHANGES

instrumentation-runtime-node: add prom-client-metrics (#2136)

Features

instrumentation-runtime-node: add prom-client-metrics (#2136) (80d0c74)

instrumentation-undici: 0.7.1
0.7.1 (2024-11-07)
Bug Fixes

instrumentation-undici: fix a possible crash if the request path is a full URL (#2518) (28e209a), closes #2471
instrumentation-undici: Fix RequestType (#2503) (9a20e15)

This PR was generated with Release Please. See documentation.

cc: @me for email updates

:robot: Created releases:

auto-instrumentations-node-v0.52.1
instrumentation-runtime-node-v0.9.0
instrumentation-undici-v0.7.1
instrumentation-aws-lambda-v0.47.0
instrumentation-aws-sdk-v0.46.0
instrumentation-mysql2-v0.42.1
instrumentation-pg-v0.47.1
:sunflower:

workflow run: https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/11732666215/job/32685368660
Looks all good, AFAICT.


Update minimum support boto version.

boto 2.2.20 introduces kinesis.  alternatively, this requirement could be
relaxed by using conditional imports.

I'm a little confused. What was the scenario that this became an issue with? Were you trying to setup the repo for development?
Ideally, I would like to allow people to use Moto even if they are using an older Boto version.

created an issue with more details.  apologies for not starting with that.
also updated this pull request with the correct minimum version based on
Kinesis.  feel free to close if you'd prefer to address via a less drastic
option (I was thinking conditional imports based on what features are
available in boto ... perhaps you'll have an even more clever solution!)
On Mon, Feb 23, 2015 at 3:39 PM, Steve Pulec<EMAIL_ADDRESS>wrote:

I'm a little confused. What was the scenario that this became an issue
with? Were you trying to setup the repo for development?
Ideally, I would like to allow people to use Moto even if they are using
an older Boto version.
—
Reply to this email directly or view it on GitHub
https://github.com/spulec/moto/pull/314#issuecomment-75662561.

Ah, got it. I forgot that we actually import boto in some places. This makes sense then.
Thank you!


deploy a first version of the the packages

Codecov Report

Merging #3 (00b2244) into main (e6418d2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            5         5
  Branches         1         1
=========================================
  Hits             5         5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6418d2...00b2244. Read the comment docs.


Visualizer with probability

Hi, when I run the
Quickstart: Using sed_vis in Python code
with the demo file a001.wav and a001_system_output_prob.csv
that is:
import sed_vis
import dcase_util
audio_container = dcase_util.containers.AudioContainer().load(
'./tests/data/a001.wav'
)
reference_event_list = dcase_util.containers.MetaDataContainer().load(
'./tests/data/a001.ann'
)
estimated_event_list = dcase_util.containers.MetaDataContainer().load(
'./tests/data/a001_system_output_prob.csv'
)
event_lists = {
'reference': reference_event_list,
'estimated': estimated_event_list
}
vis = sed_vis.visualization.EventListVisualizer(event_lists=event_lists,
audio_signal=audio_container.data,
sampling_rate=audio_container.fs)
vis.show()
However, I got the following warning:
.../lib/python2.7/site-packages/matplotlib/figure.py:2299: UserWarning: This figure includes Axes that are not compatible with tight_layout, so results might be incorrect.
warnings.warn("This figure includes Axes that are not compatible "
.../lib/python2.7/site-packages/matplotlib/tight_layout.py:209: UserWarning: tight_layout cannot make axes height small enough to accommodate all axes decorations
warnings.warn('tight_layout cannot make axes height small enough '
and the resulted png figure didn't show probability and the estimated results were also gone.
I don't know how to figure it out, can you give me some tips? Thank you very much!

I cannot reproduce this issue with Python 3.6 and matplotlib 2.2.3.
What version of matplotlib you are using? Seems that you are using Python 2.7.

Thank you for your prompt reply.
Yes, I am using Python2.7 in order to use this repo directly. And the version of matplotlib is 2.2.4.
So, can we do something to make it work?

Unfortunately, it seems that I cannot reproduce this issue even with matching matplotlib version. I get correct png-file when using vis.save(filename='test.png') instead of vis.show().

Ok, thank you~ I will take more tries~ I close it.


prepdocs.ps1 requires .NET 8 to run successfully

When running "azd up" without .NET 8 SDK installed the above error occurs.
The readme of the repo indicates that .NET 7 is required.
It may need an update.

yep, docs just got updated.

Marking this issue as resolved since .NET 8 is GA and docs are updated.


Refactor Plausible Adapter

This PR refactors the plausible adapter to use the new adapter system like all other adapters such as Google and ActiveCampaign.

Closing this PR to create a PR with all adapters


(Testing CI: aggregator compile error #542)

What is this PR doing?
How can these changes be manually tested?
Does this PR resolve or contribute to any issues?
Checklist

[ ] I have manually tested these changes
[ ] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

Tests pass / could not reproduce.


HEllo World

Here

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Yeah, I suspect it's either been created by accident or for a +1 on hacktoberfest. This is the English version of the guide page.
Since it's already been marked invalid I will be closing this.


⚠ Processors has degraded performance

In 9a425df, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 39 ms

Resolved: Processors performance has improved in d6b4703.


adding bot to group causes error

Hi!
If I add the bot to a group, the bot crashes:
9|halbot  | /root/halbot/node_modules/telegraf/lib/core/network/client.js:293
9|halbot  |             throw new error_1.default(data, { method, payload });
9|halbot  |                   ^
9|halbot  | TelegramError: 400: Bad Request: chat_id is empty
9|halbot  |     at Telegram.callApi (/root/halbot/node_modules/telegraf/lib/core/network/client.js:293:19)
9|halbot  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
9|halbot  |     at async ctx.ok (file:///root/halbot/node_modules/utilitas/lib/bot.mjs:93:35)
9|halbot  |     at async ok (file:///root/halbot/skills/ai.mjs:32:20) {
9|halbot  |   response: {
9|halbot  |     ok: false,
9|halbot  |     error_code: 400,
9|halbot  |     description: 'Bad Request: chat_id is empty'
9|halbot  |   },
9|halbot  |   on: {
9|halbot  |     method: 'editMessageText',
9|halbot  |     payload: {
9|halbot  |       chat_id: undefined,
9|halbot  |       message_id: 27,
9|halbot  |       inline_message_id: '',
9|halbot  |       reply_to_message_id: undefined,
9|halbot  |       disable_notification: true,
9|halbot  |       onProgress: true,
9|halbot  |       text: 'Hey |'
9|halbot  |     }
9|halbot  |   }
9|halbot  | }

Fixed. Please check it out. Thanks for your info.

thank you for the update
I added the bot to a group and it doesn't respond to anything in the group, even if I directly address the bot
as soon as I assigned the admin role of the group to the bot, it crashes with:
file:///root/halbot/node_modules/utilitas/lib/bot.mjs:67
                if (msg.new_chat_member.user === ctx.botInfo.id
                        ^

TypeError: Cannot read properties of undefined (reading 'new_chat_member')
    at file:///root/halbot/node_modules/utilitas/lib/bot.mjs:67:25
    at execute (/root/halbot/node_modules/telegraf/lib/composer.js:485:23)
    at /root/halbot/node_modules/telegraf/lib/composer.js:486:27
    at execute (/root/halbot/node_modules/telegraf/lib/composer.js:485:23)
    at /root/halbot/node_modules/telegraf/lib/composer.js:486:27
    at /root/halbot/node_modules/telegraf/lib/future.js:145:16
    at execute (/root/halbot/node_modules/telegraf/lib/composer.js:485:23)
    at /root/halbot/node_modules/telegraf/lib/composer.js:486:27
    at /root/halbot/node_modules/telegraf/lib/composer.js:161:31
    at execute (/root/halbot/node_modules/telegraf/lib/composer.js:485:23)

if I restart the bot after I made it admin, it responds in the group, but just once, after that every reply is being ignored and I see
[BOT 2023-03-27T09:25:35.913Z] Missing response.

in the log

TypeError: Cannot read properties of undefined (reading 'new_chat_member')

This is not the right version of utilities. Please update all the depending packages or reinstall the latest halbot. :)

if I restart the bot after I made it admin, it responds in the group, but just once, after that every reply is being ignored and I see
[BOT 2023-03-27T09:25:35.913Z] Missing response.

in the log

It's OK to see this line of logs. Because telegram will send lots of system messages to the bot client, not all the messages need to be parsed and replied to. I ignored some of the messages from the system, which will show this log that tell us the bot receiving messages.

If you see this after you update to the latest version, please come back and let me know, thanks!

@kamil-malinski
1st, You have to give the bot permission to access the messages in the group, which means you need to give the bot admin role. That is a limitation of telegram APIs.
2nd, Halbot will only reply to messages when it has been mentioned in a group, not all the messages by default. You can let it reply to all the messages in a group. That will be a bit crazy, but you can do it if you want by adding the group keyword to the chatType array of the config file.


[WIP] update pfp and quotes upto 539

[x] Update Names
[x] Update Roles
[x] Quote 490
[ ] Word Wrapping on Raven's quote (526)

The issue of word wrapping on 526 is left as a commented todo for the moment.

Wrapping for 526 is fixed, I believe this is ready for a review, barring another pass on names/roles/pfp if necessary


npm run generate generates unnecessary index.html files

Environment

Operating System: Windows_NT
Node Version:     v18.16.0
Nuxt Version:     3.6.3
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      typescript, ssr, router, nitro
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/yukinakato/nuxt3-issue-repro
Describe the bug
Hi! I'm using Nuxt 3 with Client-Side Rendering mode by ssr: false.
On Nuxt 3.6.2, npm run generate generates files in the dist folder like this:
dist
├─ _nuxt (includes many files)
└─ index.html

which is completely fine for SPA web sites.
On Nuxt 3.6.3, npm run generate generates unnecessary index.html files which correspond to index.vue in sub directories, and the dist folder looks like this:
dist
├─ _nuxt (includes many files)
├─ subdir (???)
│   └── index.html
└─ index.html

subdir is not necessary for SPA here. Just deploying root index.html and _nuxt directory works.

How to reproduce

clone the repo, npm i and npm run generate
After changing Nuxt version to "nuxt": "3.6.2" in package.json, npm i and npm run generate then you won't see subdir in the dist folder.
Additional context
No response
Logs
No response

Possibly, caused by this change: https://github.com/nuxt/nuxt/commit/e9dac76348802f49db995693399586d535c2b21e

Not generating /subdir/index.html was a bug in 3.6.2 that is resolved.
If you want to revert to the previous behaviour you can use the following configuration:
export default defineNuxtConfig({
  hooks: {
    'prerender:routes' ({ routes }) {
      routes.clear()
      routes.add('/')
    }
  }
})


Table matNoDataRow missing "mdc-data-table__row"

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14
Description
When the table row selector matNoDataRow is hit it doesn't include the class mdc-data-table__row. I guess that's the default class for a row!
The quite similar bug #26162 was reported as well - at least the start and the conclusion was the same!
Reproduction
https://stackblitz.com/run?file=src%2Fapp%2Ftable-filtering-example.html

Enter any kind of invalid data

Expected Behavior
matNoDataRow should automatically inject class mdc-data-table__row
Actual Behavior
matNoDataRow is NOT inject class mdc-data-table__row . One needs to do it manually - with the risk of an internal change of the class names!
Environment
Angular CLI: 15.2.1
Node: 19.7.0 (Unsupported)
Package Manager: npm 9.5.0
OS: linux x64
Angular: 15.2.1
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, localize, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
Package                         Version
@angular-devkit/architect       0.1502.1
@angular-devkit/build-angular   15.2.1
@angular-devkit/core            15.2.1
@angular-devkit/schematics      15.2.1
@schematics/angular             15.2.1
rxjs                            7.8.0
typescript                      4.9.5

Hi @leomayer, I can't access the stackblitz link you provided. Is it publicly visible?

I thought it is but perhaps...
You can use the public example from the documentation of Angular Material
https://material.angular.io/components/table/examples#table-filtering
Labeled with Table with filtering and filter something which isn't found.

Duplicate of https://github.com/angular/components/issues/26162.


Lighthouse scoring doc updates

What's changed, or what was fixed?

Updated the details of how Lighthouse v3 (and v4) does scoring.

Target Live Date: No later than Mon Nov 12. But hopefully before.

[ ] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele
+R: @patrickhulce

Whoops!
There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/lighthouse/scoring.md#L130 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/tools/lighthouse/scoring.md#L5 - WF Tag 'wf_updated_on' must be within the last 7 days.
src/content/en/tools/lighthouse/v3/scoring.md#L128 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful

:+1:

:+1:

:+1:

:+1:

@petele not sure on kayce's availability.. can we get this landed in the meantime? ;)

:tada: This has been pushed live to https://developers.google.com/web/


fix(client): filetype can be nil on nightly for get_language_id

See https://github.com/neovim/neovim/issues/31262

Has been fixed in core in the meantime so no longer be needed


Explorer display is very slow

Explorer display is very slow.
I think the explorer of testnet as follows is very slow:
http://explorer.testnet.symboldev.network/
It seems to be taking over 20 secs for the top page to be fully displayed.
I would like to see improvement.
Thanks!

did it happen to your machine every time?
One of the reasons I can think of is that we are pulling a lot of data from the different API endpoints.

did it happen to your machine every time?
One of the reasons I can think of is that we are pulling a lot of data from the different API endpoints.

This isn't just happening on the testnet explorer, I regularly experience it on the main net explorer which I use everyday and it makes the experience problematic at times.
I'm afraid some people don't have 10-20 seconds to wait for it to load and think it is broken and move on.

I just made a video, and it took over 2 minutes to load the page. I have tested both Safari and Firefox and both are affected. I would upload the video but trying to figure out how to get a 2 minute video to Github from my phone without breaking the internet :-)

Thank you. Fixed in v1.1.1


bump to version 2.3

Signed-off-by: Xun Zhang<EMAIL_ADDRESS>Description
Change back to OpenSearch version 2.3 for 2.3 branch.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #417 (5afba3f) into 2.3 (e09bee2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.3     #417   +/-   ##
=========================================
  Coverage     91.43%   91.43%
  Complexity      528      528
=========================================
  Files            59       59
  Lines          1529     1529
  Branches        122      122
=========================================
  Hits           1398     1398
  Misses           89       89
  Partials         42       42

Flag
Coverage Δ

ml-commons
91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Since last update all tags in html appear in red

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: abusaidm.html-snippets-0.0.17, anseki.vscode-color-0.1.11, dbaeumer.jshint-0.10.15, donjayamanne.githistory-0.1.0, donjayamanne.python-0.4.2, DotJoshJohnson.xml-1.6.0, HookyQR.beautify-0.4.1, lonefy.vscode-JS-CSS-HTML-formatter-0.2.1, ms-vscode.csharp-1.4.1, ms-vscode.Theme-TomorrowKit-0.1.3, msjsdiag.debugger-for-chrome-1.2.1, robertohuertasm.vscode-icons-3.0.5, Zignd.html-css-class-completion-1.0.3

Steps to Reproduce:

Open any html document

@solondon What color theme are you using?

Tommorow night Bright. I have replicated setup on another pc same files and addons and they work, I cant work out what the difference is. Thanks for the response

The underlying grammar has changed that creates the syntax highlighting tokens. We are now using standard text mate grammar, generated scopes should be similar, but changes can occur. Looks like the Tommorow night Bright color theme is sensitive to these change.
Nothing I can do from our side, we are not authoring neither the grammar not the color theme.

thanks for taking the time to look and reply, that does appear to be the issue. Cant work out why its ok on the other machine, but at least I have  a workaround now. Many thanks


Overhaul

Changes:

Remove a bunch of old, unused stuff
Refactor things for clarity
Fix a few bugs
Speed things up - including dumbing down merging, for now
Fully parallelize qgraph traversal
All prioritization and throttling is now done on a per-KP basis by trapi-throttle.

Whoops, I will add aiostream to the requirements. Also, it seems that our automated tests are not failing properly.

Yeah, I'm not sure why the Github automated tests didn't catch that. Seems like it shouldn't be saying that all checks pass. Also, it seems like Strider takes much longer to build locally now? I don't know whether that is an issue or expected behavior, just something I noticed.

Well, luckily, Github is reporting the same thing as I am this time. I have one test failing locally still. "test_self_edge" in test_server.py is failing.


Name of the chemical (Chebi) in GO-CAM and the widget

Hi,
In GO-CAM models and the widget, the name used for the chemicals is the official Chebi name which often different that the one used in RHEA for the same Chebi. RHEA name is usually closer to the one used in the literature and more understandable for the user.
Would it be possible to display the RHEA name for the chemical ? at least in the widget?
An example:
http://noctua.geneontology.org/workbench/noctua-visual-pathway-editor/?model_id=gomodel%3A622aace900001143
D-glucopyranose (CHEBI:4167) is actually D-Glucose in RHEA and in Uniprot function, which is confusing for the user:
https://www.rhea-db.org/rhea/60376
Thank you.
@pgaudet

Looking at the ChEBI OBO file: These would be 'easy' to parse out using  [UniProt] synonyms
[Term]
id: CHEBI:4167
name: D-glucopyranose
subset: 3_STAR
def: "A glucopyranose having D-configuration." []
synonym: "D-glucose" RELATED [UniProt]


prefer-exponentiation-operator

Current dependencies on/for this PR:

main

PR #60   👈

This comment was auto-generated by Graphite.


Possible fix for the servant's money bag tracking

I noticed the string was searching for "moneybag", but the in-game chat text uses "money bag" now - dunno when that changed, but I figured adding the space would fix the tracker too.

Tyvm

No problem, it annoyed me so I just put in some elbow grease. Like any FOSS users should.

Can this be pushed to the plugin in an update? Still not updated as of Oct 24, 2024

Thank you.

Can this be pushed to the plugin in an update? Still not updated as of Oct 24, 2024

It’s waiting for RL approval, see https://github.com/runelite/plugin-hub/pull/6252


NOTE: from now new issues are added to the main komodoplatform zebra repo

see https://github.com/KomodoPlatform/zebra/issues

see main repo


Misc. intermediate commits for support for historical balance lookups in Rosetta

Thank you for contributing to Mina! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.
Miscellaneous small fixes and additions to support adding historical balance lookups to Rosetta (https://github.com/MinaProtocol/mina/pull/7114).
Ran Rosetta test suite successfully.
Checklist:

[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ x Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them:

!ci-build-me

!ci-build-me


dbt-utils "star" returns all columns even if all columns are listed in except list

Describe the bug
When using the star dbutils function, if you (inadvertently) include every column of a table in the except list, star.sql returns *. This leads to unexpected behavior where the query attempts to return all columns. (I would expect star.sql to return an empty string in this situation.)
In the web app, the SQL compiles fine, adding the * in where expected. Bizarrely, it even previews just fine, as if the * were not there. The issue only arises when doing dbt run.
Steps to reproduce
A simplified example of where I discovered it.
with salesorderdetail as (
  select * from {{ ref( 'fact_sales_order_detail') }}
),

dim_product as (
  select
    column_a,
    column_b,
    column_c
  from {{ ref('dim_product') }}
),

select
    sod.*,
    {{ dbt_utils.star(from=ref('dim_product'), relation_alias='pr', except=["column_a", "column_b", "column_c"]) }},
from salesorderdetail sod
    left join dim_product pr
        on pr.column_a = sod.product_id

Expected results
I suppose I would expect a compile error to be thrown, spurred by an error return from star.
Actual results
The query compiles just fine, adding a * in where the star function was called. No error is even seen when previewing the query, although you can see the * in the compiled query. Specifically, the above query would compile to:
with salesorderdetail as (

  select * from [long string pointing to fact_sales_order_detail]
),

dim_product as (

  select
    column_a,
    column_b,
    column_c
  from [long string pointing to dim_product]
),

select
    sod.*,
    *,
from salesorderdetail sod
    left join dim_product pr
        on pr.column_a = sod.product_id

This attempts to load all the columns of sod twice, leading to a compile error due to having multiple columns with identical names.
System information
The contents of your packages.yml file:
packages:
  - package: dbt-labs/dbt_utils
    version: 0.9.1

Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[x] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
1.2.0
Are you interested in contributing the fix?
Sure but not 100% sure how. There needs to be some handling to determine if all columns appear in the except list, either in star or in get_filtered_columns_in_relation I believe. Perhaps a check as simple as if the except list length is equal to (or greater) the table's column list length.

Hey @KennyShaevelA8, I agree that this is a bit of a surprise!
Its origin can be traced back with three whys:
At the most obvious level, it happens because of this:
https://github.com/dbt-labs/dbt-utils/blob/ba7ee523b0833d1564721f92bbdfe3cf82a5e62b/macros/sql/star.sql#L16-L18
But why does that happen? It's because we start with an empty list, and add desired columns to it:
https://github.com/dbt-labs/dbt-utils/blob/ba7ee523b0833d1564721f92bbdfe3cf82a5e62b/macros/sql/get_filtered_columns_in_relation.sql#L18-L20
And why does that happen? Best I can tell, this dates back to https://github.com/dbt-labs/dbt-utils/pull/561 which is dealing with the fact that SQLFluff doesn't like select statements without any columns specified.
What to do about it? I'm not sure! The reason specified for the change in #561 was that a model doesn't exist at the time that SQLFluff runs.
Perhaps instead of returning '*', it should return a static string like 'no columns provided to star() macro' - valid SQL, but clearly wrong for analytics purposes. @swanjson what do you think?

@joellabes without looking at the code again, would there be a way to determine the difference between an empty string created by "except" columns and an empty string due to the table not existing? The default * is what allows sqlfluff to run if the model hasn't been created before. It seems the rarer case to have all the columns of model in the except clause than linting on a file that has not been built yet.

I had a quick look at identifying whether it's because the model hasn't been built yet, but it's given me trouble in the past so I wouldn't want to rush back into it.

The default * is what allows sqlfluff to run if the model hasn't been created before

I know, but it doesn't have to be a star, right? It just has to be any valid SQL syntax, which is why I thought a static string might be a better compromise - the CI robots don't care, and it's more obvious to the humans what happened. Right now the result of the macro is the exact opposite of what was requested which is sorta weird.

Coming back to this: I asked in the sqlfluff channel and got a "sounds okay, I think" from @barrywhart which I'm taking as a full endorsement and moving forward 🚀

Closed by #732


Update sys-fn-pagerescracker-transact-sql.md

The fourth parameter of function sys.dm_db_page_info can be default,'LIMITED' or 'DETAILED', it does not have the value 1.
Following query is not correct, I replace the 1 with 'DETAILED'
SELECT page_info.*
FROM sys.dm_exec_requests AS d
CROSS APPLY sys.fn_PageResCracker (d.page_resource) AS r
CROSS APPLY sys.dm_db_page_info(r.db_id, r.file_id, r.page_id, 1) AS page_info

@liweiSecurity : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[Bitbucket server] Drone CLI not working with upper-case user's names

Bugs or Issues? Please do not open a GitHub issue until you have
discussed and verified in our chatroom:
https://gitter.im/drone/drone

No answer.

$ drone --version
drone version 0.7.0

drone registry add --repository ACH/drone-with-java --hostname *** --username ***--password ***
json: cannot unmarshal array into Go value of type drone.Registry

The same with quotes

$ drone registry add --repository 'ACH/drone-with-java' --hostname *** --username *** --password ***
json: cannot unmarshal array into Go value of type drone.Registry

$ drone registry add --repository "ACH/drone-with-java" --hostname *** --username *** --password ***
json: cannot unmarshal array into Go value of type drone.Registry

And repository is  case-sensitivity

$ drone registry add --repository ach/drone-with-java --hostname *** --username *** --password ***
client error 404:

I am closing as I am unable to repeat. The below CLI commands work for me as expected
drone registry add \
  --repository=foo/bar \
  --username=foo \
  --password=bar \
  --hostname=foo.com

If you continue experiencing issues please consider sending a pull request


Update failed

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.1
Operating system/version
windows10 wsl2
Describe the bug

Steps To Reproduce
nvim into lazyvim
l
U (update plugins)
failed.
Expected Behavior
you guys can told me what should I do?
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

well you have local changes for noice it seems
either go into the local folder and do git restore ., just delete it or uninstall the plugin with lazy first


Handle NOASSERTION for download URI value

According to SPDX specification section 7.7
https://spdx.github.io/spdx-spec/v2.3/package-information/
This enables a workaround for Gradle 8.2 which no more allows to retrieve downloadUrl from resolved artifact
Sample workaround:
tasks.withType<SpdxSbomTask>().configureEach {
    taskExtension.set(object : DefaultSpdxSbomTaskExtension() {
        private val NOASSERTION = URI.create("NOASSERTION")
        override fun mapRepoUri(input: URI?, moduleId: ModuleVersionIdentifier): URI {
            return NOASSERTION
        }
    })
}

Maybe "NONE" value should be used if repoUri is null
refs: #29 #30

is it still required? I had some time ago a conversation with Gradle and they ensured me that the API to get the download URL works again.


Unit converter

Title and Issue number

Title : Unit Converter
Issue No. : #130
Code Stack : HTML, CSS ,JS
Close #130

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] I have updated the Index.html file for my contribution

@sadanandpai Please take a review of my PR & please merge it.

@sadanandpai I have resolved the conflicts...Can you please take a look & please merge it

I have deleted those files & have changed the codes . @sadanandpai Can you please take a review & please merge it

@apu52 please address the comments properly. Do not mark resolved without fixing.


Doc change for sstableloader.rst - Clarify that "Cassandra must be stopped" applies to the source cluster

Clarify that "Cassandra must be stopped" applies to the source cluster

closed in favor of https://github.com/apache/cassandra/pull/1072


PR author gets auto-assigned

Description
In most cases, pull request author should be assigned an assignee of the pull request. This task makes sure the PR author assigns as an assignee.
Acceptance Criteria

[ ] Install https://github.com/marketplace/actions/auto-author-assign
[ ] Test it

Complexity: 2

Doesn't work, see https://github.com/drpaneas/romie/pull/54

Just sent a new PR, please review @ktsamis  @JohnGavr