Generating Docs on Mono fails

When trying to generate docs on Mono (v3.10 on OSX 10.10) it complains about a missing dll: /Users/devboy/Development/devboy/Paket.Unity3D/docs/tools/generate.fsx(30,1): error FS0078: Unable to find the file 'Microsoft.Web.XmlTransform.dll'
When adding the Microsoft.Web.Xdt dependency and add it to my generate.fsx #I "../../packages/Microsoft.Web.Xdt/lib/net40" I get the following error:
Processing the file 'docpage' failed
Source written to: '/var/folders/_d/n081d8b13hg_xtwhdk94cyx80000gn/T/tmp1743356.tmp.cs'
Compilation errors:
 - error: (0, 0) Assembly `fsi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f536804aa0eb945b' references `FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version number than imported assembly `FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

System.Exception: Generating HTML failed.
  at FSharp.Literate.RazorRender.handleCompile[String] (System.String source, Microsoft.FSharp.Core.FSharpFunc`2 f) [0x00000] in <filename unknown>:0
  at FSharp.Literate.RazorRender.ProcessFile[IDictionary`2] (Microsoft.FSharp.Core.FSharpOption`1 properties) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Templating.generateFile (System.String contentTag, IEnumerable`1 parameters, Microsoft.FSharp.Core.FSharpOption`1 templateOpt, System.String output, IEnumerable`1 layoutRoots) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Templating.processFile (FSharp.Literate.LiterateDocument doc, System.String output, FSharp.Literate.ProcessingContext ctx) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Literate.ProcessMarkdown (System.String input, Microsoft.FSharp.Core.FSharpOption`1 templateFile, Microsoft.FSharp.Core.FSharpOption`1 output, Microsoft.FSharp.Core.FSharpOption`1 format, Microsoft.FSharp.Core.FSharpOption`1 formatAgent, Microsoft.FSharp.Core.FSharpOption`1 prefix, Microsoft.FSharp.Core.FSharpOption`1 compilerOptions, Microsoft.FSharp.Core.FSharpOption`1 lineNumbers, Microsoft.FSharp.Core.FSharpOption`1 references, Microsoft.FSharp.Core.FSharpOption`1 replacements, Microsoft.FSharp.Core.FSharpOption`1 includeSource, Microsoft.FSharp.Core.FSharpOption`1 layoutRoots, Microsoft.FSharp.Core.FSharpOption`1 generateAnchors) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(System.String file, System.String output) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.FSharpFunc`2[System.String,System.String].InvokeFast[Unit] (Microsoft.FSharp.Core.FSharpFunc`2 func, System.String arg1, System.String arg2) [0x00000] in <filename unknown>:0
  at <StartupCode$FSharp-Literate>.$Main.processDirectory@180 (Microsoft.FSharp.Core.FSharpOption`1 format, Microsoft.FSharp.Core.FSharpFunc`2 processScriptFile, Microsoft.FSharp.Core.FSharpFunc`2 processMarkdown, System.String indir, System.String outdir) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Literate.ProcessDirectory (System.String inputDirectory, Microsoft.FSharp.Core.FSharpOption`1 templateFile, Microsoft.FSharp.Core.FSharpOption`1 outputDirectory, Microsoft.FSharp.Core.FSharpOption`1 format, Microsoft.FSharp.Core.FSharpOption`1 formatAgent, Microsoft.FSharp.Core.FSharpOption`1 prefix, Microsoft.FSharp.Core.FSharpOption`1 compilerOptions, Microsoft.FSharp.Core.FSharpOption`1 lineNumbers, Microsoft.FSharp.Core.FSharpOption`1 references, Microsoft.FSharp.Core.FSharpOption`1 fsiEvaluator, Microsoft.FSharp.Core.FSharpOption`1 replacements, Microsoft.FSharp.Core.FSharpOption`1 includeSource, Microsoft.FSharp.Core.FSharpOption`1 layoutRoots, Microsoft.FSharp.Core.FSharpOption`1 generateAnchors) [0x00000] in <filename unknown>:0
  at FSI_0002.buildDocumentation () [0x00000] in <filename unknown>:0
  at <StartupCode$FSI_0002>.$FSI_0002.main@ () [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0

I am not a .NET developer (just yet) and can't even find the <IP_ADDRESS> of FSharp.Core, or if that is even the real issue.
Can you give me any pointers?

You can now try with #135.

Hey everyone, came to try out the scaffolds today on mono as well and getting a similar error:
FSharp.Formatting Information: 0 : FSharp.Formatting Logging setup!
Yaaf.FSharp.Scriping Information: 0 : Yaaf.FSharp.Scripting Logging setup!
Copying file: /Users/akropp/src/personal/ProjectScaffold/docs/output/img/logo-template.pdn
Copying file: /Users/akropp/src/personal/ProjectScaffold/docs/output/img/logo.png
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/style.css
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/style.css.bak
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/style_light.css
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/tips.js
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/img/github-blue.png
Copying styles and scripts: /Users/akropp/src/personal/ProjectScaffold/docs/output/content/img/github.png
Generating '/Users/akropp/src/personal/ProjectScaffold/docs/tools/../content/index.html'
FSharp.Formatting Critical: 0 :
Processing the file 'docpage' failed
Source written to: '/var/folders/14/q83_4prd2pj0wq43hqk88j5w4kx0d8/T/tmp21816c2e.tmp.cs'
Compilation errors:
 - error: (0, 0) Assembly `fsi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f536804aa0eb945b' references `FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version number than imported assembly `FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

System.Exception: Generating HTML failed.
  at FSharp.Literate.RazorRender.handleCompile[String] (System.String source, Microsoft.FSharp.Core.FSharpFunc`2 f) [0x00000] in <filename unknown>:0
  at FSharp.Literate.RazorRender.ProcessFileModel[IDictionary`2] (System.Type modelType, System.Object model, Microsoft.FSharp.Core.FSharpOption`1 properties) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Templating.generateFile (Microsoft.FSharp.Core.FSharpOption`1 references, System.String contentTag, IEnumerable`1 parameters, Microsoft.FSharp.Core.FSharpOption`1 templateOpt, System.String output, IEnumerable`1 layoutRoots) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Templating.processFile (Microsoft.FSharp.Core.FSharpOption`1 references, FSharp.Literate.LiterateDocument doc, System.String output, FSharp.Literate.ProcessingContext ctx) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Literate.ProcessScriptFile (System.String input, Microsoft.FSharp.Core.FSharpOption`1 templateFile, Microsoft.FSharp.Core.FSharpOption`1 output, Microsoft.FSharp.Core.FSharpOption`1 format, Microsoft.FSharp.Core.FSharpOption`1 formatAgent, Microsoft.FSharp.Core.FSharpOption`1 prefix, Microsoft.FSharp.Core.FSharpOption`1 compilerOptions, Microsoft.FSharp.Core.FSharpOption`1 lineNumbers, Microsoft.FSharp.Core.FSharpOption`1 references, Microsoft.FSharp.Core.FSharpOption`1 fsiEvaluator, Microsoft.FSharp.Core.FSharpOption`1 replacements, Microsoft.FSharp.Core.FSharpOption`1 includeSource, Microsoft.FSharp.Core.FSharpOption`1 layoutRoots, Microsoft.FSharp.Core.FSharpOption`1 generateAnchors, Microsoft.FSharp.Core.FSharpOption`1 assemblyReferences, Microsoft.FSharp.Core.FSharpOption`1 customizeDocument) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(System.String file, System.String output) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.FSharpFunc`2[System.String,System.String].InvokeFast[Unit] (Microsoft.FSharp.Core.FSharpFunc`2 func, System.String arg1, System.String arg2) [0x00000] in <filename unknown>:0
  at <StartupCode$FSharp-Literate>.$Main.processDirectory@199 (Microsoft.FSharp.Core.FSharpOption`1 format, Boolean processRecursive, Microsoft.FSharp.Core.FSharpFunc`2 processScriptFile, Microsoft.FSharp.Core.FSharpFunc`2 processMarkdown, System.String indir, System.String outdir) [0x00000] in <filename unknown>:0
  at FSharp.Literate.Literate.ProcessDirectory (System.String inputDirectory, Microsoft.FSharp.Core.FSharpOption`1 templateFile, Microsoft.FSharp.Core.FSharpOption`1 outputDirectory, Microsoft.FSharp.Core.FSharpOption`1 format, Microsoft.FSharp.Core.FSharpOption`1 formatAgent, Microsoft.FSharp.Core.FSharpOption`1 prefix, Microsoft.FSharp.Core.FSharpOption`1 compilerOptions, Microsoft.FSharp.Core.FSharpOption`1 lineNumbers, Microsoft.FSharp.Core.FSharpOption`1 references, Microsoft.FSharp.Core.FSharpOption`1 fsiEvaluator, Microsoft.FSharp.Core.FSharpOption`1 replacements, Microsoft.FSharp.Core.FSharpOption`1 includeSource, Microsoft.FSharp.Core.FSharpOption`1 layoutRoots, Microsoft.FSharp.Core.FSharpOption`1 generateAnchors, Microsoft.FSharp.Core.FSharpOption`1 assemblyReferences, Microsoft.FSharp.Core.FSharpOption`1 processRecursive, Microsoft.FSharp.Core.FSharpOption`1 customizeDocument) [0x00000] in <filename unknown>:0
  at FSI_0003.buildDocumentation () [0x00000] in <filename unknown>:0
  at <StartupCode$FSI_0003>.$FSI_0003.main@ () [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
Stopped due to error
Running build failed.
Error:
System.Exception: generating help documentation failed
  at FSI_0001.Build.generateHelp' (Boolean fail, Boolean debug) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit _arg1) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit unitVar0) [0x00000] in <filename unknown>:0
  at Fake.TargetHelper.runSingleTarget (Fake.TargetTemplate`1 target) [0x00000] in <filename unknown>:0

---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target         Duration
------         --------
Clean          00:00:00.0032827
AssemblyInfo   00:00:00.0090185
Build          00:00:03.8195270
CopyBinaries   00:00:00.0035621
RunTests       00:00:00.7889371
CleanDocs      00:00:00.0031411
Total:         00:00:11.4937800
Status:        Failure
---------------------------------------------------------------------
  1) System.Exception: generating help documentation failed
  at FSI_0001.Build.generateHelp' (Boolean fail, Boolean debug) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit _arg1) [0x00000] in <filename unknown>:0
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit unitVar0) [0x00000] in <filename unknown>:0
  at Fake.TargetHelper.runSingleTarget (Fake.TargetTemplate`1 target) [0x00000] in <filename unknown>:0```

I did a git clone of the scaffolds project and ran `./build.sh`

@devshorts This seems to be similar to https://github.com/tpetricek/FSharp.Formatting/issues/323. Can you try to update your packages (especially mono)? Otherwise add the workaround I suggested in the linked issue.

Also similar to #205. I have updated everything and I can still reproduce the issue. My workaround still works after updating everything.
My OSX 10.11 installation was a clean install. So right now I have a clean environment with only XCode,  Xamarin and Node on it.
For me, this is a OSX only issue as I am able to build the project as is on Windows and Ubuntu.
Building FSharp.Formatting on my Macbook generates the same error message when building its own documentation.


Fix resolution check

current Situation:
starting a tile preheat in webmercator with highest resolution 50m
the client is creating the list of tiles with the function grid.getClosestZoom(50) and tries to calculate zoomlevel 12.
the server (service-wmts) is translating zoomlevel 12 to a resolution of 38m and rejects the zoomlevel 12 tiles because he checks highest_resolution > zoomlevel 12 resolution.
with this fix:
client and server are using the getClosestZoom, service-wmts is validating if the current zoomlevel is supported with zoom check.

i will fix this in the client part of the script


As a user I would like to see quality badges on the project homepage (README)

There are a multitude of quality badges we can add to the project README.md for new users:

Build status
Go report card
TypeScript related badges (need to research)
More...?

hey @arikkfir  can i take this one. I am new to open source and would like to try it.

Hi, sure thing, go ahead!


Emitter.prototype.of should return a new Emitter instance

It would be great to be able to do something like this:
var io = require('socket.io-emitter')({ host: '<IP_ADDRESS>', port: 6379 });
var nspEmitter = io.of('/someNamespace');

... and then be able to use nspEmitter multiple times afterwards to do actions related to that namespace. That would make it behave similarly to the of() function of SocketIO itself: http://socket.io/docs/rooms-and-namespaces/#custom-namespaces
Instead, for socket.io-emitter, the of() function needs to be used before each emit(). This inconsistency between SocketIO and socket.io-emitter leads to some confusion. At the very least, the documentation should state that of() needs to be called before each emit().

It take a lot of time to investigate this for me. Hope that will be fixed.

@travellingprog I'll be happy to merge your pull request!

Closed by https://github.com/socketio/socket.io-emitter/pull/56.


Vendor packages for NVIDIA H100 GPU

is this needed with the gpucount pr going in?

is this needed with the gpucount pr going in?

It's plan B in case GPU count PR not fully functioning. Moreover, even with GPU count PRs in, we need several large scale VM SKUs.

But shouldn’t the moc tag be bumped either way?
Get Outlook for iOShttps://aka.ms/o0ukef

From: JamesLiang29 @.>
Sent: Thursday, June 20, 2024 12:27:07 PM
To: microsoft/cluster-api-provider-azurestackhci @.>
Cc: Zach @.>; Comment @.>
Subject: Re: [microsoft/cluster-api-provider-azurestackhci] Vendor packages for NVIDIA H100 GPU (PR #278)
is this needed with the gpucount pr going in?
It's plan B in case GPU count PR not fully functioning. Moreover, even with GPU count PRs in, we need several large scale VM SKUs.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/cluster-api-provider-azurestackhci/pull/278#issuecomment-2181094223, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK6ZN4OISLVK722YL2B2XTLZIL7FXAVCNFSM6AAAAABJJVIMRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGA4TIMRSGM.
You are receiving this because you commented.Message ID: @.***>

But shouldn’t the moc tag be bumped either way?

Yes, depends on the merge order one of us may be covered by another and discarded.

But shouldn’t the moc tag be bumped either way?

Yes, depends on the merge order one of us may be covered by another and discarded.

But the other PR already merged

But the other PR already merged

This one is newer, contains changes for NVIDIA H100 support.


Include script that allows starting JupyterLab from the command line

VSCode, Sublime, and several other editors provide a mechanism to install a launch script that allows easily  launching the app from the command line. The script is setup so that the terminal immediately returns back to running bash instead of displaying the stdout of the app. We want to include something similar.
This would involve adding a command to the command palette that installs the script to a directory like /usr/local/bin. I talked to @ellisonbg , and he recommends using "jlab" for the script name.

Here's electron one:
#!/bin/bash

if [ "$(uname)" == 'Darwin' ]; then
  OS='Mac'
elif [ "$(expr substr $(uname -s) 1 5)" == 'Linux' ]; then
  OS='Linux'
else
  echo "Your platform ($(uname -a)) is not supported."
  exit 1
fi

if [ "$(basename $0)" == 'atom-beta' ]; then
  BETA_VERSION=true
else
  BETA_VERSION=
fi

export ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT=true

while getopts ":wtfvh-:" opt; do
  case "$opt" in
    -)
      case "${OPTARG}" in
        wait)
          WAIT=1
          ;;
        help|version)
          REDIRECT_STDERR=1
          EXPECT_OUTPUT=1
          ;;
        foreground|benchmark|benchmark-test|test)
          EXPECT_OUTPUT=1
          ;;
      esac
      ;;
    w)
      WAIT=1
      ;;
    h|v)
      REDIRECT_STDERR=1
      EXPECT_OUTPUT=1
      ;;
    f|t)
      EXPECT_OUTPUT=1
      ;;
  esac
done

if [ $REDIRECT_STDERR ]; then
  exec 2> /dev/null
fi

if [ $EXPECT_OUTPUT ]; then
  export ELECTRON_ENABLE_LOGGING=1
fi

if [ $OS == 'Mac' ]; then
  if [ -L "$0" ]; then
    SCRIPT="$(readlink "$0")"
  else
    SCRIPT="$0"
  fi
  ATOM_APP="$(dirname "$(dirname "$(dirname "$(dirname "$SCRIPT")")")")"
  if [ "$ATOM_APP" == . ]; then
    unset ATOM_APP
  else
    ATOM_PATH="$(dirname "$ATOM_APP")"
    ATOM_APP_NAME="$(basename "$ATOM_APP")"
  fi

  if [ -n "$BETA_VERSION" ]; then
    ATOM_EXECUTABLE_NAME="Atom Beta"
  else
    ATOM_EXECUTABLE_NAME="Atom"
  fi

  if [ -z "${ATOM_PATH}" ]; then
    # If ATOM_PATH isn't set, check /Applications and then ~/Applications for Atom.app
    if [ -x "/Applications/$ATOM_APP_NAME" ]; then
      ATOM_PATH="/Applications"
    elif [ -x "$HOME/Applications/$ATOM_APP_NAME" ]; then
      ATOM_PATH="$HOME/Applications"
    else
      # We haven't found an Atom.app, use spotlight to search for Atom
      ATOM_PATH="$(mdfind "kMDItemCFBundleIdentifier == 'com.github.atom'" | grep -v ShipIt | head -1 | xargs -0 dirname)"

      # Exit if Atom can't be found
      if [ ! -x "$ATOM_PATH/$ATOM_APP_NAME" ]; then
        echo "Cannot locate ${ATOM_APP_NAME}, it is usually located in /Applications. Set the ATOM_PATH environment variable to the directory containing ${ATOM_APP_NAME}."
        exit 1
      fi
    fi
  fi

  if [ $EXPECT_OUTPUT ]; then
    "$ATOM_PATH/$ATOM_APP_NAME/Contents/MacOS/$ATOM_EXECUTABLE_NAME" --executed-from="$(pwd)" --pid=$$ "$@"
    exit $?
  else
    open -a "$ATOM_PATH/$ATOM_APP_NAME" -n --args --executed-from="$(pwd)" --pid=$$ --path-environment="$PATH" "$@"
  fi
elif [ $OS == 'Linux' ]; then
  SCRIPT=$(readlink -f "$0")
  USR_DIRECTORY=$(readlink -f $(dirname $SCRIPT)/..)

  if [ -n "$BETA_VERSION" ]; then
    ATOM_PATH="$USR_DIRECTORY/share/atom-beta/atom"
  else
    ATOM_PATH="$USR_DIRECTORY/share/atom/atom"
  fi

  ATOM_HOME="${ATOM_HOME:-$HOME/.atom}"
  mkdir -p "$ATOM_HOME"

  : ${TMPDIR:=/tmp}

  [ -x "$ATOM_PATH" ] || ATOM_PATH="$TMPDIR/atom-build/Atom/atom"

  if [ $EXPECT_OUTPUT ]; then
    "$ATOM_PATH" --executed-from="$(pwd)" --pid=$$ "$@"
    exit $?
  else
    (
    nohup "$ATOM_PATH" --executed-from="$(pwd)" --pid=$$ "$@" > "$ATOM_HOME/nohup.out" 2>&1
    if [ $? -ne 0 ]; then
      cat "$ATOM_HOME/nohup.out"
      exit $?
    fi
    ) &
  fi
fi

# Exits this process when Atom is used as $EDITOR
on_die() {
  exit 0
}
trap 'on_die' SIGQUIT SIGTERM

# If the wait flag is set, don't exit this process until Atom tells it to.
if [ $WAIT ]; then
  while true; do
    sleep 1
  done
fi

Closing as implemented in #273.


Updated Version of Hydra (v1.0.2)

Hi All,
This isn't a proper issue, but I have an updated version of Hydra.  I've added it to tag, v1.0.2.   These changes include the addition of bowtie2 to align short reads, as well as updates to the versions of different packages to run Hydra.  The packages in this version get downloaded from other anaconda.org accounts, such that I'm only hosting the Hydra package on my personal anaconda.org account.  There are new instructions for downloading on the v1.0.2 github page, but I haven't updated any of the developers' instructions.
Check it out, try and break it, all that fun stuff.

Error with v1.0.2:
Fetching package metadata ...........
NoPackagesFoundError: Package missing in current linux-64 channels:

cufflinks 2.2.1*

You should pester Eric :)
—ste

On Mar 31, 2017, at 2:09 PM, bioliyezhang<EMAIL_ADDRESS>wrote:
Error with v1.0.2:
Fetching package metadata ...........
NoPackagesFoundError: Package missing in current linux-64 channels:
cufflinks 2.2.1*
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/montilab/Hydra/issues/33#issuecomment-290786522, or mute the thread https://github.com/notifications/unsubscribe-auth/AJADH0EhEB1yAPK7G0k69oOx_tzu0Wdpks5rrUFFgaJpZM4Lffdi.


Sequences enable transparency by default in Foot terminal

Using the Foot terminal, and the following line in .zshrc:
(cat ~/.cache/wal/sequences &)

The background of the terminal is always transparent by default. (about 0.5 in 0.0 - 1.0 range, i'd say)
I have no idea where this comes from, i've tried running with wal -b "#000000" and wal -a 1.0 but it stays transparent.
The only way to get it right now is skip the sequences and let the terminal set the colors by creating a template, but that means there can't be any curly brackets in the config file apart for the where the colors need to be, which makes it really difficult.

This sounds a lot like https://codeberg.org/dnkl/foot/issues/434, which was fixed in https://codeberg.org/dnkl/foot/pulls/435. @RicArch97 any chance you can build and test latest foot from git?
Note that the transparency issue was a bug, plain and simple. Foot didn't actually support setting transparency runtime. But we do now, since https://codeberg.org/dnkl/foot/pulls/437. I also recently added support for changing the selection (highlight) bg/fg colors: https://codeberg.org/dnkl/foot/pulls/440. All this is in latest git.

@dnkl I should have check Foot's issues before i posted here 😄 . I will test the lastest version!

@dnkl Tested latest git version and it seems to work correctly now. Thanks for developing the Foot terminal, it feels way faster than Alacritty.

Thanks for developing the Foot terminal

You're welcome :)

it feels way faster than Alacritty.

Well, both have their weak and strong points, I believe. But I obviously prefer foot :D


ctkAbstractPythonManager: revert change to clean up PythonQt before f…

…inalizing the Python interpreter
This commit reverts 77a24f217d3ef65586107dded4d1df76e36049bf.
The original change worked in conjunction with fixes in PythonQt to avoid
various crashes while destroying the ctkAbstractPythonManager, for example by
calling Py_DECREF after the Python interpreter was finalized.
Further testing shows that a better fix is indeed to finalize first to ensure
clean destruction of PythonQt objects, and to make PythonQt's clean up step more
robust by handling a finalized interpreter.
An example of code which necessitates this change is creating an instance of
class Foo:
    class Foo(object):

      def __init__(self):
	    self.timer = qt.QTimer()

      def __del__(self):
	    self.timer.setSingleShot(True)

During Py_Finalize(), the Foo instance's del method is called, which in turn
calls a method on a Qt object. For this to succeed, PythonQt's data must still
be in place.
This depends on https://github.com/commontk/PythonQt/pull/31

Assuming I update the PythonQt hash, would this be ready for integration ?

Yes, this one is ready. The PythonQt hash should already be up-to-date.


text-size-adjust: More details on old desktop WebKit bug

The oldest Chrome I have access to is v26, which is affected by the bug. So I don't know how far further back the bug goes.
The bug was fixed in Chrome v27.
The oldest Safari I have access to is v5.1.7, which is affected by the bug. So I don't know how far further back the bug goes.
The bug is gone as of Safari v6.2.7. I don't have access to v6.0 or v6.1.
Testcase: https://bug-56543-attachments.webkit.org/attachment.cgi?id=86034
Bug: https://bugs.webkit.org/show_bug.cgi?id=56543

(The merge conflict has been resolved.)

Thanks! Sorry for the delay, was gonna research some more but since it mostly affects pretty old versions it doesn't seem worth delaying any further.


Roll Flutter Engine from a08bd5a07c2a to 1b567e80386e (1 revision)

https://github.com/flutter/engine/compare/a08bd5a07c2a...1b567e80386e
2024-11-08<EMAIL_ADDRESS>In the embedder Impeller render target, use a multisample texture for the depth buffer only if MSAA is supported (flutter/engine#56444)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Tidy up WA UiAutomator bass classes

In general we need to tidy up the base class/es since there a few things that are a bit woolly. i.e. variable names are of mixed case, the methods aren't const correct, instance methods on static objects etc. Other changes like default step values could be added then.

Closing after commit: 4b2417a


OpenCorporates reconciliation endpoint incompatible with OpenRefine 3.6

Since #3731, the OpenCorporates reconciliation endpoint (https://opencorporates.com/reconcile) does not work correctly in OpenRefine.
To Reproduce
Steps to reproduce the behavior:

First, reconcile some list of companies to OpenCorporates
Then, click one of the reconciliation candidates

Current Results
You land on a 404 page because the slash characters in the URL are incorrectly escaped.
Expected Behavior
Working URLs.
This could be achieved by:

keeping the previous behaviour for services which do not declare any protocol version in their manifest (i.e. they are following 0.1)
adjusting the specs (and OpenRefine's code) to specify in the templates whether escaping is expected or not (https://github.com/reconciliation-api/specs/issues/39)

Versions

OpenRefine: 3.6-SNAPSHOT

I would like to try to solve this issue as no good first issues are available. Can you please assign me this issue so that at least I can try to solve this?

If you can guide me towards some first issue, then I would be glad.


Calls to systemsetup in macos script return error message

Calls to systemsetup in the macos setup script return error messages. Here's an example:-
[:~] $ sudo systemsetup -setrestartfreeze on
2022-07-18 12:50:15.251 systemsetup[16791:120362] ### Error:-99 File:/AppleInternal/Library/BuildRoots/b6051351-c030-11ec-96e9-3e7866fcf3a1/Library/Caches/com.apple.xbs/Sources/Admin/InternetServices.m Line:379
[:~] $ sudo systemsetup -setcomputersleep Off > /dev/null
2022-07-18 12:55:37.204 systemsetup[17214:126771] ### Error:-99 File:/AppleInternal/Library/BuildRoots/b6051351-c030-11ec-96e9-3e7866fcf3a1/Library/Caches/com.apple.xbs/Sources/Admin/InternetServices.m Line:379

Issue occurred on macOS Monterey 12.4, with an intel based chip. Commands run from a bash shell.

2> /dev/null will suppress the messages. I haven't seen an issue with doing this and settings appear to apply.


The title of the merged PDF is the lecture title

set a file name for merged pdfs (lecture title)

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
[ ] I implemented the changes with a good performance and prevented too many database calls.
[ ] I documented the Java code using JavaDoc style.

Client

[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

Screenshots

Congrats on your first contribution. 🎉  Once you check off all items on the checklist, make sure to switch the PR from 'draft' to 'ready for review'.


Warn about vecLib on Mac OS X

Fixes #3621.
vecLib does not work correctly in MNIST example.
In this PR, we detect it and show warning.

Along with this check, I moved Python 3.5.0 check into chainer._environment_check for cleanliness of code.
Relevant section in Tips has been removed, as it's no longer needed.

I haven't tested this PR because I don't have Mac OS X...
When reviwing, please test that it can actually detect vecLib.

Honestly I was thinking that we should reorganize tips page and write more general tips (such as debug mode or CHAINER_TYPE_CHECK), but that should be another topic. I will fix.
(The missing link was typo for https://github.com/chainer/chainer/issues/704, btw)

Fixed (and altered some wording in the tips).

For general usage, this configuration is exposed through numpy.show_config() too. Not immediately relevant for this PR since it doesn't take a query arg but could be convenient.

@hvy
numpy.show_config() writes the output to standard output as a plain text, which is not suitable for being treated programatically. Or am I missing something?

@niboshi Ah, yes you are right. I thought that it returned the config data.

LGTM!

@niboshi Is this to be back-ported?

Ah, I think so. It should be helpful for v3 users as well.


PeerPods CR & controller for handling dangling cloud resources

Fixes: #375
Here's a suggestion for monitoring and deleting dangling resources, this is RFC as I'd like to get feedback on the general idea and implementation but it's also WIP as there're still things to fix and improve
Architecture & Workflow:
Creation time:
With every successful peer-pod VM creation cloud-api-adaptor will create also a PeePod CR (predefined by the operator) which contains the cloud provider and its VM instance id.
Owner references:
The PeerPod CR is owned by the original Pod object that represents the peer-pod, upon pod deletion background cascading deletion getting into action which means the Pod will be deleted first and the GC will handle the owned PeerPod CR later.
Deletion time:
(Normal case) When remote hypervisor will get the stopVM request (upon pod deletion) it will delete the podVM instance and if successful it will remove the finalizer attached to the owned PeerPod object so it can then be cleaned by the GC
(Failure case) In case for some reason cloud-api-adaptor doesn’t honor the delete request of it fails to delete it, the finalizer is not removed and then when peer-pods controller will recognize deletion that the GC is trying to perform for the owned PeerPod object and that it still has the finalizer it will comprehend it needs to preform the deletion of podVM resource based on the PeerPod CR fields

Currently supports and tested only with libvirt and aws

TODOs:

[ ] Docs
[x] Move to a separate directory?
[x] Adapt to #710
[ ] Tests
[ ] support more providers
general fixes &  improvements

I addresses all the issues commented, i hit some module issues due to the pkgs movements, hence, it blocks me from testing ATM but i don't expect code to have additional dramatic changes.
(also need to rename peer-pod-ctlr to peer-pod-ctrl)

removed the WIP & RFC, please review
NOTE: it still requires to remove some hacks that was done for testing before merging
all other changes can be done as follow up also supporting other providers

Please remove any commits that are really not required for peerpod CR. For example I think this commit is not needed - all: mv cloudmgr pkg under pkg/

I think this specific change is based on my previous comment.
It is OK with me to keep using the original package location of cmd/cloud-api-adaptor/cloudmgr. I'll submit another PR to reorganize the cloudmgr functionality into each cloud provider code in pkg/cloud/*.

Please remove any commits that are really not required for peerpod CR. For example I think this commit is not needed - all: mv cloudmgr pkg under pkg/

I think this specific change is based on my previous comment.
It is OK with me to keep using the original package location of cmd/cloud-api-adaptor/cloudmgr. I'll submit another PR to reorganize the cloudmgr functionality into each cloud provider code in pkg/cloud/*.

@yoheiueda thanks for clarifying. I think since this PR is quite big, keeping it specific to the controller required changes will be better from review and test standpoint. wdyt ?

@snir911 thanks for implementing this important feature. Overall it looks good. I need to do a second pass but before that few generic comments to help move forward.

Please squash few commits. For example the reconcile loop function and the api etc creation can be in one PR.

you mean to split the api calles from the CAA to a different PR?

Please remove any commits that are really not required for peerpod CR. For example I think this commit is not needed - all: mv cloudmgr pkg under pkg/

As @yoheiueda mentioned i moved it as he requested, however, i think reverting it and reorganize later also make sense, also i think it would help to avoid the need to point go.mod to the root dir

Add proper copyright statements for CoCo

ok

Please rename the folder to peerpod-controller to match the CR - peerpod.

The reason i used "ctrl" and not "controller" is because when i tried to stick with this naming in the other operator (peer-pod-config-controller it resulted in failure with some of the objects definitions due to a too long name (default names the operator-sdk is using)
Of course it can be modified, but i thought it would be better to be unified with the naming conventions in both operator

@snir911 thanks for implementing this important feature. Overall it looks good. I need to do a second pass but before that few generic comments to help move forward.

Please squash few commits. For example the reconcile loop function and the api etc creation can be in one PR.

you mean to split the api calles from the CAA to a different PR?

These two commits

8e0206b11a9e3d73a9090ea08592e379a7e59553
b2b243461f9ebc4851cdf9855c3e0f4d48ab801e

Please rename the folder to peerpod-controller to match the CR - peerpod.

The reason i used "ctrl" and not "controller" is because when i tried to stick with this naming in the other operator (peer-pod-config-controller it resulted in failure with some of the objects definitions due to a too long name (default names the operator-sdk is using) Of course it can be modified, but i thought it would be better to be unified with the naming conventions in both operator

:-( ..Let's use peerpod-ctrl (peerpod as a single word to denote the CR)


speed_limit_mph is a metadata stored in Waymo map features.

But this kind of meta data is not properly processed. We just say: if you don't have this data in your SD, then we randomly choose one.

In converter1 (convert_waymo_to_metadrive.py), the speed_limit_mph is properly stored.

We need to:

[ ] Make sure MetaDrive will not through away this information.
[ ] transform it to kmh in converter1


feat(addon-doc): support customization top level navigation menu

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Build or CI related changes
[ ] Tests related changes
[ ] Documentation content changes

What is the current behavior?

What is the new behavior?

Do we need this somewhere? I believe we will rework accordion component completely soon so I wouldn't want more things tie us up to the old API. Besides some options do not really make sense in the context of navigation, like rounded or borders.


fix: [M3-7590] – Improve UX for Linode Resize dialog when linode data is being loaded

Description 📝
Improve the UX for the Linode Resize dialog.
Changes  🔄

Only display Linode Resize form if linode data has been loaded (if it is still loading, render a <CircleProgress />)
Prevent dialog title from being Resize Linode undefined by rendering an empty string when linode.label is undefined as the linode data loads

Target release date 🗓
7/8/24
Preview 📷

Before
After

How to test 🧪
Reproduction steps
Verification steps
As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@abailly-akamai Any objections to this approach? I couldn't reproduce some of the items you mentioned in the ticket, but in prod I was seeing "Resize Linode undefined" as the dialog title and the dialog contents shifting abruptly (when opening from the Linodes landing page). Waiting until the linode data has been fetched before rendering the full form addresses those issues.


Avoid parsing html recursively, improve perf, chjj/marked#506

https://github.com/chjj/marked/issues/506

@afc163 Thanks :+1:


Switch Params not working : How to remove them?

Hi ,
Our generated SDK has switch params for the boolean schema model. It only passes true value to body when it is passed. We need it to be used both the ways. Can anyone please let me know if I can pass an option not to avoid creating switch params. Can we just have normal positional param ?

@dolauli Please help with this. Is there any way we can make boolean as normal input instead of hastable.

Hi Team, Can anyone Please check and suggest this? @dingmeng-xue

Hi @dolauli , Please find the info. Any switch param generated via the boolean schema model which is converted to switch param, doesn't pass false value if it not passed. We need a functionality where we can pass the false value also. Please check. Thanks for the help.
SDK Link : https://github.com/Commvault/CVPowershellSDKV2/tree/2022E https://www.powershellgallery.com/packages/CommvaultPowerShell/0.2.11
Uploading the text file instead of yaml. I generate using cmdline  : autorest Configuration1.yaml --namespace="Commvault.Powershell" --clear-output-folder --output-folder="C:\cvpowers\CommvaultPowerShell" --powershell --input-file=OpenAPI3.yaml --verbose
Adding the contents of the directive file
module-version: 0.2.11
nested-object-to-string: true
subject-prefix: CV
directive:

from: OpenAPI3.yaml
where: >-
$.servers[0].url
set: >-
http://WebserverUrl.Commvault.com/webconsole/api/

from: OpenAPI3.yaml
where: >-
$.info.title
set: >-
CommvaultPowerShell

from : OpenAPI3.yaml
where: >-
$.paths..content
transform: >-
const json_obj = {};
for(var each in $)
{
if(each != "application/xml")
{
json_obj[each] = $[each];
}
}
return json_obj

where:
variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$
remove: true

OpenAPI3.txt

If you want to pass false, you should use -<switchname>:$false.
And for an optional bool parameter, the mapping is as below.
-<switchname>:$false -> false
-<switchname> -> true
The switch parameter is not provided -> not appear in the payload.

This info worked . Thanks a lot for the help!

I know this is old, but Microsoft's documentation for "Update-MgUser" is out of date here:
https://learn.microsoft.com/en-us/microsoft-365/enterprise/block-user-accounts-with-microsoft-365-powershell?view=o365-worldwide
Dolauli's comment resolved this correctly.


Upgrade build to vuejs3

Hello,
I tried to update the build process to support VueJS 3.0. I also updated the bus event such as to use the mitt library as vuejs doesn't support anymore to be used as a bus.
The build is working, but I was not able to test it.
Let me know if I can do anything else to help release a vuejs3 compatible version.
\cc @matfish2

Thank you very much for the work you have done.
The only issue I have with this merge is that it will break vue 2 support.
So I'm thinking I will pull this request into a different vue3 branch, test it, and publish as a separate package on npm (vue-pagination-3).
Please let me know if you have any reservations.

Yes, I think it's a good idea to create another branch and release it in another package. 👍


Object tracking

Supported query:
SELECT id, T.iids, T.bboxes, T.scores, T.labels
FROM MyVideo JOIN LATERAL EXTRACT_OBJECT(data, YoloV5, NorFairTracker)
    AS T(iids, labels, bboxes, scores)
WHERE id < 30;

'DataFrame' object has no attribute 'append'

Can we use the SEGMENT construct to track sequences within a segment? Since tracking is done on a sequence of consecutive frames, calling an object tracker on arbitrary frames in the videos seems unintuitive.

I don't understand what you mean by arbitrary frames. We are always calling the tracker on consecutive frames and the tracker ensures it provides a unique id to any new object.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.

Can we use the SEGMENT construct to track sequences within a segment? Since tracking is done on a sequence of consecutive frames, calling an object tracker on arbitrary frames in the videos seems unintuitive.

I don't understand what you mean by arbitrary frames. We are always calling the tracker on consecutive frames and the tracker ensures it provides a unique id to any new object. Reg SEGMENT: I was thinking of using GROUP BY on object ids returned by the tracker to construct actual tracks and maybe support some geometric predicates on it.

I think ``

@pchunduri6 Let me know your thoughts.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.
I'm deliberately sending the frame data to the tracker for extracting reid features if required.

This leads to an interesting problem. Predicate pushdown may not work in this case. For example, when we have WHERE id < 30 or id > 70. Filtering the frame first will give us different results.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.
I'm deliberately sending the frame data to the tracker for extracting reid features if required.

This leads to an interesting problem. Predicate pushdown may not work in this case. For example, when we have WHERE id < 30 or id > 70. Filtering the frame first will give us different results.

Yup, that is true. But isn't the user deliberately only wanting to track the objects from 30-70? We can add it as a warning in the documentation. I haven't worked on documentation yet. Was thinking of doing it in another PR.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.
I'm deliberately sending the frame data to the tracker for extracting reid features if required.

This leads to an interesting problem. Predicate pushdown may not work in this case. For example, when we have WHERE id < 30 or id > 70. Filtering the frame first will give us different results.

Yup, that is true. But isn't the user deliberately only wanting to track the objects from 30-70? We can add it as a warning in the documentation. I haven't worked on documentation yet. Was thinking of doing it in another PR.

This is not a common use case, but just for example. User are interested in vehicles before 6PM or after 7PM. So the query will have WHERE timestamp < 6PM or timestamp > 7PM. Now consider there is a vehicle circling around through the whole time. Without predicate pushdown, the vehicle will have a unique id associated with it (assuming no errors). With predicate push down, the vehicle can have two ids because the location of the vehicle in the last frame for timestamp < 6PM and the first frame for timestamp > 7PM can be quite different.
There is also a risk that random vehicles in the first frame for timestamp > 7pm will be matched to random vehicles in the last frame for timestamp < 6PM, which will not happen if we don't do predicate push down.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.
I'm deliberately sending the frame data to the tracker for extracting reid features if required.

This leads to an interesting problem. Predicate pushdown may not work in this case. For example, when we have WHERE id < 30 or id > 70. Filtering the frame first will give us different results.

Yup, that is true. But isn't the user deliberately only wanting to track the objects from 30-70? We can add it as a warning in the documentation. I haven't worked on documentation yet. Was thinking of doing it in another PR.

This is not a common use case, but just for example. User are interested in vehicles before 6PM or after 7PM. So the query will have WHERE timestamp < 6PM or timestamp > 7PM. Now consider there is a vehicle circling around through the whole time. Without predicate pushdown, the vehicle will have a unique id associated with it (assuming no errors). With predicate push down, the vehicle can have two ids because the location of the vehicle in the last frame for timestamp < 6PM and the first frame for timestamp > 7PM can be quite different. There is also a risk that random vehicles in the first frame for timestamp > 7pm will be matched to random vehicles in the last frame for timestamp < 6PM, which will not happen if we don't do predicate push down.

Yes, that is a problem. I can't think of a solution right now. Not pushing down the predicate will be super expensive.
I believe trackers should be able to handle it. Most trackers consume frame id to compute flow. But depends on the tracker.
What do you suggest?

Can we use the SEGMENT construct to track sequences within a segment? Since tracking is done on a sequence of consecutive frames, calling an object tracker on arbitrary frames in the videos seems unintuitive.

I don't understand what you mean by arbitrary frames. We are always calling the tracker on consecutive frames and the tracker ensures it provides a unique id to any new object. Reg SEGMENT: I was thinking of using GROUP BY on object ids returned by the tracker to construct actual tracks and maybe support some geometric predicates on it.

The GROUP BY idea looks good to me.
By arbitrary frames, I meant the upstream query could potentially return any frames based on the predicate right. For example, consider the return ids 10, 120, 250, and 300. What would track mean when run on such frames? It's not an implementation or design issue. From a usability standpoint, I was just thinking if there's a way to limit the use of the tracker to specific types of input sequences.

One-off invocations of the tracker would generate different object-ids, correct? Let's say I run the object tracker on frames 1 to 30, then 70 to 100 in a continuous scene. Would the same objects have different object ids? The follow-up question would be, can we merge them in a subsequent call? Seems like a good use-case for supporting re-identification.

Yes, this can happen. However, if we add support for a tracker that also takes into about reid features, we should be able to achieve it. This can be an extension of the current implementation.
I'm deliberately sending the frame data to the tracker for extracting reid features if required.

This leads to an interesting problem. Predicate pushdown may not work in this case. For example, when we have WHERE id < 30 or id > 70. Filtering the frame first will give us different results.

Yup, that is true. But isn't the user deliberately only wanting to track the objects from 30-70? We can add it as a warning in the documentation. I haven't worked on documentation yet. Was thinking of doing it in another PR.

This is not a common use case, but just for example. User are interested in vehicles before 6PM or after 7PM. So the query will have WHERE timestamp < 6PM or timestamp > 7PM. Now consider there is a vehicle circling around through the whole time. Without predicate pushdown, the vehicle will have a unique id associated with it (assuming no errors). With predicate push down, the vehicle can have two ids because the location of the vehicle in the last frame for timestamp < 6PM and the first frame for timestamp > 7PM can be quite different. There is also a risk that random vehicles in the first frame for timestamp > 7pm will be matched to random vehicles in the last frame for timestamp < 6PM, which will not happen if we don't do predicate push down.

Yes, that is a problem. I can't think of a solution right now. Not pushing down the predicate will be super expensive.
I believe trackers should be able to handle it. Most trackers consume frame id to compute flow. But depends on the tracker.
What do you suggest?

I see. We can print a warning message for now. Re-id is needed I  think to achieve the same results with / without predicate push down.  Even then, there still can be errors from re-id.

@gaurav274 Please help checking the Notebook test case.

Sure, looking into it.

@xzdandy Hopefully, the changes should fix the build-related issue.
Btw, do you think there is a meaningful test case for object tracking? Also, please review that I accidentally didn't remove your changes.

@xzdandy Hopefully, the changes should fix the build-related issue. Btw, do you think there is a meaningful test case for object tracking? Also, please review that I accidentally didn't remove your changes.

That is a good point. We should have a test case for EVAtracker abstract class and builtin nor_fair tracker.


issue about  Input of TCN

Hi,I would like to understand the meaning of the input (B, C, L) of the TCN model. B represents the batch size. Does C represent the dimension of each sample feature? Does L represent the sequence length of each sample? Does args.nhid in the network represent the convolution of the length of the sample sequence? For multivariate time series modeling, what input should tcn handle? For example, data.shape is (data_number, feature_dim).

Your interpretation of C and L is correct.
For multivariate time series modeling, you should use it similar to how you use RNN/LSTM. Make sure your data has a temporal/sequence-length dimension.


updated to react 0.14.2

React 0.14 is starting to get supported, I updated the react-version and recompiled the examples.

Thanks!


Define non-enumerable props for serializer when toMatchObject fails

Summary
Fixes https://github.com/facebook/jest/issues/2351
Please forgive me for submitting a pull request before the issue is accepted

No hard feelings if the issue is unacceptable
Because this is my first code contribution to Jest, it might take a while to make it acceptable :)
An implementation might make clear anything lacking in problem description and analysis

Test plan

Added 4 tests to matchers-test.js and glad for advice how to improve or add to them
Existing tests for toMatchObject still pass with the new code

Current coverage is 68.16% (diff: 100%)

Merging #2628 into master will increase coverage by 0.05%

@@             master      #2628   diff @@
==========================================
  Files           137        137
  Lines          5011       5019     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3413       3421     +8
  Misses         1598       1598
  Partials          0          0

Powered by Codecov. Last update 980d3d8...d282eea

I'm generally scared of supporting these things because getOwnPropertyDescriptor etc. is really really slow over things like "Object.keys" and in 99% of the cases it isn't what people want or expect.

Thank you, that makes sense, and it’s what I needed to know. I think that relevant subset matching requires a helper function, which can return enumerable $$typeof properties.
So you can close this pull request and the issue.


Nothing happened when pressing link in toolbar

Hi,
I'm adding link in QuillToolbar options but when I'm clicking on it then nothing is happening. i tried to get html using onHtmlChange when we made selection it is making anchor tag but there is not way to add link.
Am i missing something ?

Hi, I'm adding link in QuillToolbar options but when I'm clicking on it then nothing is happening. i tried to get html using onHtmlChange when we made selection it is making anchor tag but there is not way to add link.
Am i missing something ?
have you decided this problem?

I checked on the official documentation and found that you have to select text and then link on link but not working on my side. So I implemented a custom method to get link and put in editor.

I checked on the official documentation and found that you have to select text and then click on link but not working on my side. So I implemented a custom method to get link and put in editor.

Hey! Can you share your solution here pls? 🙏


Lazy Loadimg Image on Flutter Web

Hi this is a feature request.
Use case
On the web, loading a long list of the image has a critical impact on performance.
As a current state of Flutter Web, the browser load every offscreen image, increasing the loading time.

An offscreen image like avatar_4.jpg would be immediately loading together with the onscreen image, increasing the time of loading the web.
First load, avatar_4.jpg is not a viewport and shouldn't load yet.

After scrolling and image is in viewport, the image should load.

Normally, a web developer can provide loading = "lazy" on an image to mark the image as lazy load.

But Flutter is rendering web in the canvas so the Flutter team might have to discuss some work about this.
Without this, a metric like Lighthouse would be recommended to Defer offscreen images (web.dev.

Since Lighthouse also has a role in ranking the web on Google, web developer also usually check their web on Lighthouse as a process.
Lazy load image has a large impact on the web development side as the image is one of the heaviest assets on the web.
With Lazy Load Image, Flutter would have a much better performance metric.
Current Workaround in Flutter.
As a current workaround of Flutter, a developer could create a lazy ListView to lazy render widget, but this also lazy render every widget, not just an image.
On the web development side, most of the time, developers don't need to lazy render element but rather let the browser process it with HTML which has better performance than appending it using JavaScript thus having better SEO performance to let crawler read the content of the web.
This request only applies to Lazy Loading an image anywhere not inside some widget/list but rather load if it presents onscreen (reason in Proposal below).

Proposal
According to HTML Standard (whatwg.org) or known as w3, image tag accept loading attribute with a possible value of either eager or lazy.

Where eager is to suddenly load the image on any condition.

And lazy is to load an image when the element is onscreen.

It would be a good idea to match with web development API for future usage if Flutter Web will support export as HTML and JavaScript.
Adding an optional named argument loading on an Image widget like an HTML tag, accepting an enum of ImageLoading (or any other name) with a default value of ImageLoading.eager to provide an image loading method matching property with w3 standard (currently provide eager and loading) but could also extend for Flutter's implementation way of image loading in the future.
build(context)
  final imageLink = "https://walfiegif.files.wordpress.com/2020/12/out-transparent-23.gif?w=371&h=458"

  return Image.network(
    imageLink,
    loading: ImageLoading.lazy,
  );
}

If possible, it would be awesome to be able to use this API in native Flutter as it will reduce a lot of boilerplate in like 99% of production app with an image as lazy loading is used almost everywhere.
Opinion: This should be provided by Flutter directly as it's one of the important standards for the web optimization process.
Thanks for considering this proposal.

@SaltyAom
doesn't PageView.builder / ListView.builder does that already?

Correct me if I'm wrong, I'm no an expert in Flutter.
Technically, it does but not isn't the proposal
This proposal is to request a way to only lazy load an image in a list not an entire widget in a list.
True that PageView.builder and ListView.builder, does lazy load the image but by rendering widget in a list lazily by pagination and loads more when need but that applies to every widget as well not only the image.
Let me quote this section from above.

Current Workaround
As a current workaround of Flutter, a developer could create a lazy ListView to lazy render widget, but this also lazy render every widget, not just an image.
On the web development side, most of the time, developers don't need to lazy render element but rather let the browser process it with HTML which has better performance than appending it using JavaScript thus having better SEO performance to let crawler read the content of the web.
This request only applies to Lazy Loading an image anywhere not inside some widget/list but rather load if it presents onscreen.

Usecase
Let's say that I'm building documentation in Flutter web, and I use PageView.builder or ListView.builder to the layout of main content which contains text and image, if I search to offscreen text it wouldn't be found because it hasn't rendered yet.
Although it does lazy load image it has a tradeoff where some widget which should be rendered but didn't.
Not only that I couldn't search offscreen text, but it would also have a problem with SEO and the web crawler couldn't read the collect the data because it hasn't been rendered (If Flutter Web is going to be able to export to HTML where crawler can read the web in the future).
Basically, this proposal is to request a way to only lazy load an image in a list not an entire widget in a list.

Not only that I couldn't search offscreen text, but it would also have a problem with SEO and the web crawler couldn't read the collect the data because it hasn't been rendered (If Flutter Web is going to be able to export to HTML where crawler can read the web in the future).

I suspect this is not how flutter works and at the moment we do have a big seo problem for that reason

Basically, this proposal is to request a way to only lazy load an image in a list not an entire widget in a list.

"everything is a widget" - quote -

I understand that currently, the Flutter team is working hard to solve problems with SEO, which is why I also add if in the future after Flutter solved the problem.
Think about this as a proposal which is not needed to be done right now but after some time in the future.
As lazy load image has a big role in web optimization, which Flutter might have to be done later to optimize the Flutter web platform.
I'm not quite sure why you quote "Everything is a Widget" on "this proposal is to request a way to only lazy load an image in a list not an entire widget in a list.".

I'll provide another case so if the previous one is not clear if Flutter had solved the problem with SEO.
Take Medium as an example.
Sometimes lazy render widget by pagination is not the best way to do lazy load image, let's say I want a web to render whole content to let web crawler read the content.

But in the content, there's also an image, which means when the web is loaded the image is also loaded.
The thing is to make whole content render except an image, to increase First Contentful Load which is also one of the SEO metrics by Lighthouse for ranking web on Google.
SEO is not only about the content being read by a web crawler but also a performance score provided by Lighthouse.
Currently, Lighthouse is being used to measure the performance of the web.
The more performance the web has, the more likely it's going to have a higher rank combining with other metrics and content.
The image has a direct impact on performance measurement with Lighthouse which means it's also one of an SEO problem.
Currently, there are two workarounds with their own tradeoff.

Using ListView.builder but will sacrifice content being read from the web crawler. (If Flutter solved SEO problem)
Do not use any lazy render at all and let the whole content load. (This will have SEO impact on performance metric)

This proposal is to provide the third way.
To render the contentful part and prevent the image from being loaded if it's offscreen.
Not to lazily render widget in a list by pagination using ListView.builder.
I hope you understand, thank you.


Orchestrion Roll searches returns no useful result

https://xivapi.com/search?indexes=Recipe&string=Orchestrion Roll can't return any results for orchestrion rolls.
PS. this issue is originally reported by a cafemaker user from https://github.com/thewakingsands/cafemaker/issues/7

I am super late but it looks like your PR may have fixed this so I am going to close it.


[Bug]: Uncaught (in response) TypeError: Cannot read properties of undefined (reading 'fetch')

Steps to reproduce
Just follow the steps of this Cloudflare doc
https://developers.cloudflare.com/browser-rendering/get-started/screenshots/
Expected results
It should work fine but it's not
Actual results

X [ERROR] Uncaught (in response) TypeError: Cannot read properties of undefined (reading 'fetch')

      at PuppeteerWorkers.launch
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:17022:32)
      at Object.fetch
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18638:58)
      at fetchDispatcher
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18744:19)
      at __facade_invokeChain__
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18706:10)
      at Object.next
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18703:14)
      at drainBody
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18664:32)
      at __facade_invokeChain__
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18706:10)
      at __facade_invoke__
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18710:10)
      at Object.fetch
  (file:///C:/Users/Sunny/Desktop/browser-worker/.wrangler/tmp/dev-ffqvPk/index.js:18760:14)

@imaxisXD can you post the code for your worker ?

@imaxisXD I'm closing this feel free to reopen

I'm also hitting this error with only the example code (using Hono if it might matter):
  const exportPngRoutes = new Hono<{ Bindings: Env }>();

  exportPngRoutes.get('/screenshot', async (c) => {
    try {
      let img: Buffer;
      const browser = await puppeteer.launch(c.env.SCREENSHOT_BROWSER);
      const page = await browser.newPage();
      await page.goto('https://google.com');
      img = (await page.screenshot({ type: 'png' })) as Buffer;
      await browser.close();
      return new Response(img, {
        headers: {
          'content-type': 'image/png',
        },
      });
    } catch (error) {
      console.error(error);
      return new Response('Error', { status: 500 });
    }
  });

Ah, for future googlers – this is because the browser bindings do not work in wrangler local dev. You need to use --remote flag on wrangler to run this from wrangler.
This is easy to miss because wrangler reports the Browser is available when you start it, even if it's actually going to be undefined in your env.


Fix column name typos

Should be all lowercase id:
https://github.com/AlexsLemonade/scpca-nf/blob/fcf766cc6656f9f90d3b96fa0ae2a6ad8c05b46e/bin/merge_sces.R#L226-L227

This is intentional, because those are the column names from the original tool.

If these are the expected column names, then something else may be wrong since these columns are in the most recently-run merged object.  It also implies our docs are wrong:
https://github.com/AlexsLemonade/scpca-docs/blob/53d4f79b863688e6fab289d5e83d30db813f66dc/docs/merged_objects.md?plain=1#L328-L332
https://github.com/AlexsLemonade/scpca-docs/blob/53d4f79b863688e6fab289d5e83d30db813f66dc/docs/sce_file_contents.md?plain=1#L319-L323

No, I'm wrong, thinking about somewhere else!

Closed by #719


reduce exec time of fast-unstake benchmarks

closes https://github.com/paritytech/substrate/issues/13077

/cmd queue -c bench-bot $ pallet pallet_fast_unstake

/cmd queue -c bench $ pallet pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247985

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247986

/cmd queue -c bench $ pallet pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2248125

/cmd queue -c bench $ pallet pallet_fast_unstake

/cmd queue -c bench $ dev pallet pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

Should be correct. See https://github.com/paritytech/substrate/pull/12924#issuecomment-1376268126

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2261473

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2261474

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

40 minute, not so bad.

/cmd queue -c bench $ pallet dev pallet_fast_unstake

40 minute, not so bad.

Now its down to 17 min, including compilation. Thanks :tada:

The code looks good, some minor naming nits, otherwise I like what happen to the weights and execution times!

The code looks good, some minor naming nits, otherwise I like what happen to the weights and execution times!

Thanks for the review, weight are already updated.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2263636

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd cancel 27-4f8016e9-9aca-464e-9112-513e1a8a1f3d

/cmd cancel

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2264304

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2264420

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2264618

/cmd queue -c bench $ pallet dev pallet_fast_unstake

bot rebase

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench PATCH_substrate=13120 $ runtime polkadot-dev

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd cancel

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd cancel

/cmd queue -c bench $ pallet dev pallet_fast_unstake

So the execution time is more like an hour now, and I have re-worked the whole thing a bit.

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2267484

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2267483

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2267482

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

/cmd queue -c bench $ pallet dev pallet_fast_unstake

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2304942

/cmd queue -c bench $ pallet dev pallet_fast_unstake

bot merge


login: Add a basic login flow

There's plenty more to do to improve the UX of this, and I've
filed several follow-up issues.  Most critically, we'll need
to store the resulting credentials on the device (#34), so you don't
have to repeat the login each time you start the app.
But this is enough that it becomes possible to log in at an
account of your choice, making the flow testable end to end.
In particular this makes a useful bootstrapping step toward
the task of storing data locally (#13): with this, there's now some
useful data we could store.
Fixes: #11

Thanks!

Also it would be good to make the new screens behave well with "system intrusions"; do you think we could do that by just putting the whole content of each screen in a SafeArea?

Seems likely.
Remind me how you reproduced getting the system intrusions to intrude? ISTR that being in landscape mode; but these lists have max widths that are less than a phone's landscape-mode width, so perhaps that wasn't it.

Hmm, I'm not sure I actually reproduced getting the system intrusions to intrude; I just figured it might happen on some screens. You could try removing the max widths and running in landscape mode, yeah.
One thing I think I did notice is that some of the contents weren't horizontally padded even in portrait mode on my iPhone, where there are no system intrusions. To get that padding with and without system intrusions, and without too much padding, I think we've had good results with the SafeArea.minimum property.

One thing I think I did notice is that some of the contents weren't horizontally padded even in portrait mode on my iPhone, where there are no system intrusions.

Ah right, I remember that now. Yeah, will do.

Revision pushed; PTAL.

Thanks, LGTM! There was a hiccup building for manual testing but that's solved: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20version.20solving.20failed/near/1541336
(I'll send that solution in a PR next.)


Fix issue #38 Can't benchmark on medqa

PR to fix #38 , solution provided by @JulienVig

add self.subsets = ['med_qa_en_source'] in MedQA class in evaluation/benchmarks.py to fix the error datasets.exceptions.DatasetGenerationError: An error occurred while generating the dataset when evaluation on medqa
add wandb, scikit-learn packages in requirements.txt and remove unused import statement import openai in evaluation/inference.py

Fix accuracy_calibrate division by zero bug


Can't select radio button

Hi,
I'm not able to select a radio button. My pdf analysis is:
FieldType: Button
FieldName: 4 IP
FieldNameAlt: {{ ip.4 | X }}
FieldFlags: 49152
FieldValue: 5
FieldJustification: Left
FieldStateOption: 5
FieldStateOption: Off

and my python is:
from pdfjinja import PdfJinja

pdfjinja = PdfJinja('test.pdf')
forms = {
    "ip": {
        "8":True
    }
}
pdfout = pdfjinja(forms)
pdfout.write(open('filled.pdf', 'wb'))

What am i doing wrong? Is it supported?

ok, now i get it


cargo-miri does not work with sccache

Must be related to https://github.com/rust-lang/miri/pull/573

<>build log<>
$ cargo -vV
cargo 1.45.0-nightly (cb06cb269 2020-05-08)
release: 1.45.0
commit-hash: cb06cb2696df2567ce06d1a39b1b40612a29f853
commit-date: 2020-05-08
$ rustc -vV
rustc 1.45.0-nightly (75e1463c5 2020-05-13)
binary: rustc
commit-hash: 75e1463c52aaea25bd32ed53c73797357e561cce
commit-date: 2020-05-13
host: x86_64-unknown-linux-gnu
release: 1.45.0-nightly
LLVM version: 9.0
$ rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /usr/local/rustup
installed toolchains
--------------------
stable-x86_64-unknown-linux-gnu
nightly-2020-05-14-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu
installed targets for active toolchain
--------------------------------------
wasm32-unknown-unknown
x86_64-unknown-linux-gnu
active toolchain
----------------
nightly-2020-05-14-x86_64-unknown-linux-gnu (default)
rustc 1.45.0-nightly (75e1463c5 2020-05-13)
$ bash --version
GNU bash, version 5.0.3(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ cargo miri --version; rustup component add rust-src; pushd core; cargo miri test --verbose -- -- storage2; popd
miri 0.1.0 (10419b3 2020-05-11)
info: downloading component 'rust-src'
info: installing component 'rust-src'
/builds/parity/ink/core /builds/parity/ink
Running `"/usr/local/rustup/toolchains/nightly-2020-05-14-x86_64-unknown-linux-gnu/bin/cargo" "install" "xargo" "-f"` to install a recent enough xargo.
    Updating crates.io index
 Downloading crates ...
  Downloaded xargo v0.3.20
  Installing xargo v0.3.20
 Downloading crates ...
  Downloaded addr2line v0.12.1
  Downloaded tempdir v0.3.7
  Downloaded walkdir v1.0.7
  Downloaded num-traits v0.2.11
  Downloaded serde v0.8.23
  Downloaded rand v0.4.6
  Downloaded object v0.19.0
  Downloaded libc v0.2.70
  Downloaded rustc-serialize v0.3.24
  Downloaded rustc-demangle v0.1.16
  Downloaded remove_dir_all v0.5.2
  Downloaded num-traits v0.1.43
  Downloaded dtoa v0.2.2
  Downloaded gimli v0.21.0
  Downloaded fs2 v0.4.3
  Downloaded error-chain v0.7.2
  Downloaded dirs v1.0.5
  Downloaded cfg-if v0.1.10
  Downloaded backtrace v0.3.48
  Downloaded autocfg v1.0.0
  Downloaded toml v0.2.1
  Downloaded rustc_version v0.1.7
  Downloaded serde_json v0.8.6
  Downloaded same-file v0.1.3
  Downloaded itoa v0.1.1
  Downloaded semver v0.1.20
   Compiling libc v0.2.70
   Compiling autocfg v1.0.0
   Compiling gimli v0.21.0
   Compiling cfg-if v0.1.10
   Compiling object v0.19.0
   Compiling rustc-demangle v0.1.16
   Compiling xargo v0.3.20
   Compiling same-file v0.1.3
   Compiling semver v0.1.20
   Compiling serde v0.8.23
   Compiling itoa v0.1.1
   Compiling rustc-serialize v0.3.24
   Compiling remove_dir_all v0.5.2
   Compiling dtoa v0.2.2
   Compiling walkdir v1.0.7
   Compiling num-traits v0.2.11
   Compiling rustc_version v0.1.7
   Compiling rand v0.4.6
   Compiling dirs v1.0.5
   Compiling fs2 v0.4.3
   Compiling num-traits v0.1.43
   Compiling tempdir v0.3.7
   Compiling serde_json v0.8.6
   Compiling addr2line v0.12.1
   Compiling toml v0.2.1
   Compiling backtrace v0.3.48
   Compiling error-chain v0.7.2
    Finished release [optimized] target(s) in 24.83s
  Installing /usr/local/cargo/bin/xargo
  Installing /usr/local/cargo/bin/xargo-check
   Installed package `xargo v0.3.20` (executables `xargo`, `xargo-check`)
error: failed to run `rustc` to learn about target-specific information
Caused by:
  process didn't exit successfully: `sccache /usr/local/rustup/toolchains/nightly-2020-05-14-x86_64-unknown-linux-gnu/bin/miri - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit code: 2)
--- stderr
error: failed to execute compile
caused by: Compiler not supported: "error: Unrecognized option: \'E\'\n\n"
error: `"/usr/local/rustup/toolchains/nightly-2020-05-14-x86_64-unknown-linux-gnu/bin/cargo" "check" "--release" "--manifest-path" "/tmp/xargo.fvDL6G47j2QU/Cargo.toml" "--target" "x86_64-unknown-linux-gnu" "-p" "std"` failed with exit code: Some(101)
   0: error_chain::make_backtrace
   1: <error_chain::State as core::default::Default>::default
   2: <std::process::Command as xargo::extensions::CommandExt>::run
   3: xargo::sysroot::build
   4: xargo::sysroot::update
   5: xargo::main_inner
   6: std::rt::lang_start::{{closure}}
   7: std::rt::lang_start_internal::{{closure}}
             at /rustc/75e1463c52aaea25bd32ed53c73797357e561cce/src/libstd/rt.rs:52
      std::panicking::try::do_call
             at /rustc/75e1463c52aaea25bd32ed53c73797357e561cce/src/libstd/panicking.rs:297
      std::panicking::try
             at /rustc/75e1463c52aaea25bd32ed53c73797357e561cce/src/libstd/panicking.rs:274
      std::panic::catch_unwind
             at /rustc/75e1463c52aaea25bd32ed53c73797357e561cce/src/libstd/panic.rs:394
      std::rt::lang_start_internal
             at /rustc/75e1463c52aaea25bd32ed53c73797357e561cce/src/libstd/rt.rs:51
   8: main
   9: __libc_start_main
  10: _start
fatal error: Failed to run xargo

so in CI, where I use sccache everywhere by default it helps me to
unset RUSTC_WRAPPER
cargo miri setup # to avoid if it asks for sudden new dependencies
cargo miri test ...

process didn't exit successfully: sccache /usr/local/rustup/toolchains/nightly-2020-05-14-x86_64-unknown-linux-gnu/bin/miri - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg (exit code: 2)
[...]
caused by: Compiler not supported: "error: Unrecognized option: 'E'\n\n"

The problem here is that sccache doesn't support using miri as compiler. It only checks for rustc and clippy-driver as rustc compilers. In all other cases it assumes that it is a C compiler and passes -E as argument, which miri doesn't support.
https://github.com/mozilla/sccache/blob/f50207525810c12f9dbad2b9e92892d055b1b38a/src/compiler/compiler.rs#L906
https://github.com/mozilla/sccache/blob/f50207525810c12f9dbad2b9e92892d055b1b38a/src/compiler/compiler.rs#L1052

Must be related to #573

I don't think so. That is us overwriting RUSTC_WRAPPER. The error you see happens when we call xargo, which is before we do anything with RUST_WRAPPER.
I have no experience with sccache, so I am not sure if the better solution is to add "miri" as a rustc name in sccache, or to unset RUSTC_WRAPPER in cargo miri.

I proposed a fix in https://github.com/rust-lang/miri/pull/1426.
@TriplEight would that work for you, or do you require Miri builds to actually be sccache'd? I'm afraid I wouldn't know what it takes to achieve that.

Thanks for mentioning!
It would be really great to have it cached (both with sccache and CARGO_TARGET_DIR), because it takes a really long time on heavy projects.
But currently it seems to break my CI completely.
The setup is: I have everything needed installed in docker image and CI just checkouts the commit and runs the cargo command. It uses sccache and CARGO_TARGET_DIR. And what happened is I've added miri, xargo and rust-src to the CI docker image and started having failures all over CI (not just in miri job).
I believe this fix is going to fix what I've just described. Can share logs and whatever code is needed, but tomorrow.

It would be really great to have it cached (both with sccache and CARGO_TARGET_DIR), because it takes a really long time on heavy projects.

What is taking long is likely the actual evaluation -- as in, running the program. I don't think it makes any sense to cache that.^^
CARGO_TARGET_DIR is a separate problem, see https://github.com/rust-lang/miri/issues/1311.

It seems if I set the rustc-wrapper in ~/.cargo/config, it didn't fixed. 😕

It seems if I set the rustc-wrapper in ~/.cargo/config, it didn't fixed. 😕

@inflation

It seems if I set the rustc-wrapper in ~/.cargo/config, it didn't get fixed.

Ah, sorry I missed this. It's usually better to open a new issue rather than commenting in an existing one.
A new issue for this has just been created: https://github.com/rust-lang/miri/issues/2429.


[GSB] Additional cleanups

Eliminate RequirementSource::isSelfDerivedSource(), whose sole caller was unnecessary code
Move the potential archetype -> component index mapping off of potential archetypes

@swift-ci please smoke test and merge

The first commit was wrong and the second got merged in a different PR.


Scroll to top - group add list issue - Fixed

Details

The issue was with the OptionsSelector component which is rendered at New Group Creation screen. When the selected user is unselected the scroll index was set to a wrong index which was causing issue and due to that required index (0) was not passed to the scrollToIndex function. Now after fixing the condition relating to the selected list. It is now working fine.
Fixed Issues

$ https://github.com/Expensify/App/issues/9918
Tests

I have tested New group screen with multiple scenarios which includes selecting-deselecting in many combinations.
I have tested other screens where this component is used like new chat screen, search screen and many more.

[X] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] iOS / native
[X] Android / native
[X] iOS / Safari
[X] Android / Chrome
[X] MacOS / Chrome
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product was added in all src/languages/* files
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] Any functional components have the displayName property
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] iOS / native
[X] Android / native
[X] iOS / Safari
[X] Android / Chrome
[X] MacOS / Chrome
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product was added in all src/languages/* files
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] Any functional components have the displayName property
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Press on floating icon on the home screen and then select New Group.
Now select names randomly and check if after deselecting any user the screen should scroll to top of the list.

[X] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/78416198/181631156-07139e7b-58a8-45bf-9fd4-f05c93543c78.mp4
Mobile Web

https://user-images.githubusercontent.com/78416198/181631227-2f24d3af-d134-47b0-acda-a10c5156ccf9.mov
Desktop

https://user-images.githubusercontent.com/78416198/181631289-533646f9-fe6b-4198-b155-c1aa98f44492.mov
iOS

https://user-images.githubusercontent.com/78416198/181631372-de9202c2-016e-4323-8283-af4f59a7dee8.mov
Android

https://user-images.githubusercontent.com/78416198/181631443-471eea24-9ed8-481a-9e39-0bd3a987fa01.mov

I have read the CLA Document and I hereby sign the CLA

Will be adding video in few minutes

@jeet-dhandha can you please use Rory's code https://github.com/Expensify/App/issues/9918#issuecomment-1187964955?

Added the code

@rushatgabhane @roryabraham Added Videos

@jeet-dhandha please write the test and QA steps in the PR post otherwise, LGTM!

@rushatgabhane Added QA steps and Test done.

I have tested New group screen with multiple scenarios which includes selecting-deselecting in many combinations.
I have tested other screens where this component is used like new chat screen, search screen and many more

Press on floating icon on the home screen and then select New Group.
Now select names randomly and check if after deselecting any user the screen should scroll to top of the list.

@jeet-dhandha these test steps aren't clear. Can you please change it to somethinglike

Tap on Fab menu
Tab Group Chat
Scroll and select 3-4 users.
Unselect one of the user from the list.
Verify that the view does not scroll after unselecting a user from a group conversation

@Expensify/applauseleads After this is deployed to staging we should update the regression test suite added in this issue to cover this case on all the multi-selection pages:

Use the arrow keys to highlight one of your selected options.
Press the Enter key to deselect the highlighted option.
Ensure that all the selection options are visible, and that the focus has moved to the first unselected option.

I just went ahead and clarified the QA steps

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.1.88-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I am on my mobile so can't confirm, but I think it probably was deployed to production in 1.1.89-4 (IIRC). The deploy comments were broken for one release. Check if the code is on the production branch to see for sure


⚠ ClamAV has degraded performance

In 141cf10, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 588 ms

Resolved: ClamAV performance has improved in 6ae4a8a.


Want to Make Font Consistent Across Navbar and Body

Issue:
The navbar and body currently use different fonts, affecting the website's visual consistency and readability.
Solution:
If this enhancement sounds good, I’d love to work on implementing it. Could you please assign this issue to me?
Request:
Please assign this issue to me and add labels:
GSSoC-extd, Hacktoberfest-accepted, level label.

Issue:
The navbar and body currently use different fonts, affecting the website's visual consistency and readability.
Solution:
If this enhancement sounds good, I’d love to work on implementing it. Could you please assign this issue to me?
Request:
Please assign this issue to me and add labels:
GSSoC-extd, Hacktoberfest-accepted, level label.

@Kavish-Paraswar Thank you for your comment. It seems you've copied the same content as my original issue. I'm currently assigned and working on this. Feel free to share any specific suggestions or insights

@ANSHIKA-26 I noticed that the issue I am working on (#201) hasn't been assigned a level 1/2/3. Could you please assign the appropriate level so I can ensure I'm meeting the project's expectations?

Hi @ANSHIKA-26
I want to work on this issue.
You can refer to my previous project.
https://raj-aditya-27.github.io/SarvottamSamachar/

Is this issue still open?