iOS support

I didn't see any listed iOS support. I thought that I would open an issue for it.
I recently got Mio running iOS CI on Travis. It isn't super generalized, but some of the insights that I discovered could be useful in figuring out how to generalize it.
The iOS CI script is here: https://github.com/carllerche/mio/blob/master/ci/run-ios.sh
The difficulty lies in the fact that a process on iOS must start up a coca application* within 20 seconds or the OS will kill the process. Even more fun is that the iOS application must run on the main thread. This wouldn't be a huge deal except that the rust test runner is pretty limited and also starts on the main thread.
The insight that I had is that you can specify an alternate entry point symbol during the link phase. So, I build a little iOS harness that starts the app then runs the Rust tests.
This could probably be generalized and included in cross.

I am not an iPhone dev, so I may be misunderstanding or using wrong terminology.

There's support for building iOS targets on MacOS (see [1] in the Supported Targets), but it's likely not legal to provide images to build iOS on other targets.
https://github.com/cross-rs/cross/pull/516#issuecomment-896047293

Additionally, the iPhoneOS SDK should be fetched directly from Apple, as I am not sure of the legality of the GitHub repository this depends upon.
I think it would be possible to extract it from an Xcode copy fetched from Apple using an user-provided Apple developer account. Obviously, as users of the feature must comply with Apple’s terms of service, this whole feature is only to be used on Linux installed on Apple-branded hardware.

Cargo itself can compile for iOS as long as xcrun is installed (IE, on macOS or using a macOS emulator):
cargo build --target aarch64-apple-ios

If you want to cross compile for iOS you should try https://GitHub.com/cloudpeers/xbuild


Replace UUID with SecureRandom for Hash & Salt

The use of UUID's was never intended to be used for tokens, only internal Id's. All tokens should be generated with the new function HashcodeGenerator#generateSalt(bytes).

Issue was raised during a Coverity check while investigating potential CSRF. However, a quick check revealed that UUID is using SecureRandom to generate 122 of the 128 bits, which should be enough randomness for Tokens as well.


[🚀esl-panel-group]: add ability to collapse inner accordion when nesting accordion

As an esl-panel-group component consumer, I want to have the ability to support inner accordion with the following behavoir:
hide event of panel is followed by all its nested panels collapsing.
Implement ESLNestedPanelGroup (ESLNestedAccordion) mixin

Recommended spec (suggested bt @ala-n , @NastaLeo, @Natalie-Smirnova ):
Extend esl-related-target mixin.
Scope of updates:

[ ] make related target able to target multiple related togglable
[ ] make related target mixin customizable in terms of observed actions:
introduce esl-related-target-action with 'hide'|'show'|'all'(default) as a values

:tada: This issue has been resolved in version 4.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix typo in Grafana dashboard

Fix typo in Sidekiq panel used by the rummager deployment dashboard.

Excelellent. 👍


treeview_size override in init.lua works only when manually saving init.lua .

Thanks for the report, need some extra information to simplify testing:

Are you using the original lite or lite-xl?
Which operative system do you use?

I'm using Lite XL 2.1.5 on Arch Linux.

I was thinking that maybe it has to do with the fact that you don't use the common.merge() way to manage config options. What do you think ?

Yes, it's probably related to that. I created this plugin to work with the original Lite. Then added some support for LiteXL but never changed the settings. I'm a bit occupied this week, do you want to try to implement a fix and send a PR? Otherwise I can test it and implement a fix when I have some free time.

I've already been trying to convert the config options to use common.merge(), but it still doesn't work so I'll need some more time to understand why. I'll open a PR as soon as I have it working.

I got some time now and tried to reproduce the issue. I edited the init.lua file and it worked as expected. How you are changing that value without editing the file?

I did the following:
Run this:
lpm run todotreeview
Add config.treeview_size = 600 * SCALE to the user init.lua
Do core:quit
Re-run lpm run todotreeview
The width that you see should  be back to 200, even though in the user init.lua it's 600

The issue here will be that lpm will always pick the version set in it's configuration file for the plugin so even you change stuff it will still pick the old version. Still have to test some more but I think it mostly should be working now. Will then need to update the version to be used by lpm in the lite-xl-plugins repository

Issue should be fixed in this commit https://github.com/drmargarido/TodoTreeView/commit/0b3937a0f0d761843df9b71cfea35884e839348b.
You will need to use config.plugins.todotreeview instead of just config when changing configs in the init.lua file.
I still have to make a PR on the lite-xl-plugins repo for lpm to pick the most recent version.

I'll try right away, thanks.

It seems to be working perfectly now!

Nice, glad its working and it's useful for you :+1:
In the meantime I created a PR in the lite-xl-plugins repository to update the version they pick there https://github.com/lite-xl/lite-xl-plugins/pull/474

PR was now merged to LiteXL so if people download it with lpm it should pick the most recent version.


setFromResponse now really results in true or false

since in android setFromResponse always resulted in null. I decided to fix this part as it was mentioned by some other folks too.

@pmyagkov It seems like that the project owner no longer visits github anymore.


Set roles on register

I am trying to set roles on register,
{
"name": "Joe Smith",
"username": "joesmith",
"email"<EMAIL_ADDRESS>"password": "bigsecret",
"confirmPassword": "bigsecret",
"roles": ['admin']
}
seems that config.security.defaultRoles overwriting it
or
how is it possible to set by myself the roles while registering?

userModel: {     whitelist: ['roles']   }


[musl] add posix_spawn chdir functions

Add posix_spawn_file_actions_add[f]chdir_np, as present in musl 1.1.24 and above (reference).

@rustbot label +stable-nominated


[pdpix] Fix Network Types to be Compatible With Each Other

Now that we've replaced our home-grown Port16 type with u16, and the associated Ipv4Endpoint struct with std::net::SocketAddrV4, we should have an easier time of interfacing our code with Rust standard library code (which uses standard types).
But there are some places where existing code was converted in place that are no longer needed and/or make sense.   And there are some compatibility functions we still have that are no longer needed (or are now inefficient).
Example inefficiency problem:
catcollar/mod.rs (and catnap/mod.rs) contain a parse_addr function that (now) converts a std::net::SockAddrV4 into a ::nix::sys::socket::SockaddrStorage.  It does this by pulling the addr and port out of the input SockAddrV4 and then creating a new SockAddrV4 from that addr and port.  And then uses SockaddrStorage::from() to create the SockaddrStorage from the new SockAddrV4.  There is no point to creating this additional SockAddrV4, as the SockaddrStorage::from() could just be called using the input SockAddrV4.  Moreover, there is no real need for parse_addr anymore, as SockaddrStorage::from() by itself does the same thing directly.
Another example:
catcollar/mod.rs (and catnap/mod.rs) contain a pack_result function that (essentially) converts an OperationResult into a demi_qresult_t.  For OperationResult::Pop, it goes through some unnecessary convolutions to create the sga_addr field (a sockaddr_in) from the popped SocketAddrV4 (which is also just a sockadd_in), when it could just copy the bits over (if Rust would let it).

@BrianZill and @anandbonde this is related to https://github.com/demikernel/inetstack/issues/124, right?

@BrianZill and @anandbonde this is related to demikernel/inetstack#124, right?

Somewhat.  It's really about cleaning up properly after the removal of the Ipv4Endpoint type rather than having a polymorphic socket address.  But they're related since we replaced the Ipv4Endpoint type with SocketAddrV4s for the most part.
Your recent PR [demikernel/demikernel#145] fixed an inefficiency where we were doing an extra pair of byte swaps.  I don't know for sure that that particular case came about because of the removal of the Ipv4Endpoint type, but it seems likely.

FYI, the Rust 1.64.0 release notes contain this little gem:

Rust 1.64.0 changes the memory layout of Ipv4Addr, Ipv6Addr, SocketAddrV4 and SocketAddrV6 to be more compact and memory efficient. This internal representation was never exposed, but some crates relied on it anyway by using std::mem::transmute, resulting in invalid memory accesses.

I don't think we have anything that depends upon the internal representation, but if we do, I suppose we shouldn't be doing that.

FYI, the Rust 1.64.0 release notes contain this little gem:

Rust 1.64.0 changes the memory layout of Ipv4Addr, Ipv6Addr, SocketAddrV4 and SocketAddrV6 to be more compact and memory efficient. This internal representation was never exposed, but some crates relied on it anyway by using std::mem::transmute, resulting in invalid memory accesses.

I don't think we have anything that depends upon the internal representation, but if we do, I suppose we shouldn't be doing that.

Thanks for keeping an eye on this, @BrianZill.
We don't rely on the internal layout of these structures and if we do, this should be reported as a bug.


add regression test for #1567

Adds a regression test for #1567.

@bors r+

:pushpin: Commit b3757d0e514e4bcac5b783daade1bed3c99220bc has been approved by RalfJung

:hourglass: Testing commit b3757d0e514e4bcac5b783daade1bed3c99220bc with merge 7ac8be8529d77c0f75e6459859e4831a81498aca...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 7ac8be8529d77c0f75e6459859e4831a81498aca to master...


Target Temperature mqtt issue

Govee Device SKU
H7133
Govee2MQTT Version
latest
Describe the issue
This is going to be difficult to describe!
I have a H7133 Smart Space Heater. Your mqtt integration is phenomenal with one (big) issue.
The temperature reported through Target Temperature is wrong in a really weird way.
Let's say the target temperature on the device, set by the app, is 72F (22C, 295K). The MQTT generated entity reports it as 161.6 which is the Fahrenheit equivalent of 72C as opposed to the Fahrenheit representation of 72F!!!!!!!
Since this is outside the allowed range (which is also misreported in Centigrade as 5-30), we get an error and the entity is unusable.
Why?
As I understand this, your add-on creates a mqtt state that both describes the entities and reports their status.
HA mqtt then consumes this to create entities. (I could be wrong!).
I think but am not sure, that the problem is in the metadata generated by your code which confused the mqtt integration.
Perhaps (and I am totally guessing) it's here:
{
	"dataType": "ENUM",
	"defaultValue": "Celsius",
	"fieldName": "unit",
	"options": [
		{ "name": "Celsius", "value": "Celsius" },
		{ "name": "Fahrenheit", "value": "Fahrenheit" }
	],
	"required": true
						}

the value might need to be C and F. This is a guess.
All I know is that I get a Invalid value for number.space_heater_pro_target_temperature: 161.6 (range 5.0 - 30.0)
Another example of the problem. In the pic below, I set the target temperature to 68F (which happens to be 20C). It updated the H7133 correctly and posted the correct value to MQTT.
But the value posted in number.space_heater_pro_target_temperature was 156.2 (see screenshot below), which is 68C (as opposed to 68F) in Fahrenheit!

I suspect my description of the problem is inadequate! So please interrogate me for more data!
Startup Diagnostics
Invalid value for number.space_heater_pro_target_temperature: 161.6 (range 5.0 - 30.0)
Additional Logs
No response
Home Assistant Logs
No response
Anything else?
No response

A similar problem with the Govee Humidifier issue: https://github.com/wez/govee2mqtt/issues/171

Have a PR to fix this: https://github.com/wez/govee2mqtt/pull/256


No default jsDelivr CDN file set

This package doesn't have a default file set. You can set it via jsdelivr, browser, or main field in package.json

Hi @mayordwells, thank you, we’re aware—it’s coming with the next patch: #5667.


Fixes #164 - change MCTS subscriber's LMP or DOB

Also moves a number of tests from KilkariControllerBundleIT to SubscriptionServiceBundleIT and does some other small cleanup.

Made a few small changes per CR feedback -- please review.

@larubbio @frankhuster @koshalt  Pretty please? It won't take long...

Other than above comments, lgtm

@larubbio ready for another look after adding field constraints and making SubscriberService.update transactional

The changes for my comments look fine.


Cannot Build Docker

Followed your Wiki to build the docker. Got 2 errors

Copy error at step 13.

Step 13/19 : COPY --from=builder /usr/local/lib/libdlib.so* /usr/local/lib
When using COPY with more than one source file, the destination must be a directory and end with a /

Fixed by adding trailing /
COPY --from=builder /usr/local/lib/libdlib.so* /usr/local/lib/

I have NO idea how to fix this one:

Step 14/19 : COPY --from=builder /usr/local/lib/php/extensions/no-debug-non-zts-20180731/pdlib.so /usr/local/lib/php/extensions/no-debug-non-zts-20180731/
COPY failed: stat /docker/storage/overlay2/22e778c041f5119a410ad4e166b3b8ac24b0668edad77efadf80b18f5be25f9d/merged/usr/local/lib/php/extensions/no-debug-non-zts-20180731/pdlib.so: no such file or directory

same for me

Same here!

Here my working Dockerfile
FROM nextcloud:apache as builder

# Build and install dlib on builder

RUN apt-get update ; \
    apt-get install -y build-essential wget cmake libx11-dev libopenblas-dev

ARG DLIB_BRANCH=v19.19
RUN wget -c -q https://github.com/davisking/dlib/archive/$DLIB_BRANCH.tar.gz \
    && tar xf $DLIB_BRANCH.tar.gz \
    && mv dlib-* dlib \
    && cd dlib/dlib \
    && mkdir build \
    && cd build \
    && cmake -DBUILD_SHARED_LIBS=ON --config Release .. \
    && make \
    && make install

# Build and install PDLib on builder

ARG PDLIB_BRANCH=master
RUN apt-get install unzip
RUN wget -c -q https://github.com/matiasdelellis/pdlib/archive/$PDLIB_BRANCH.zip                                                                                \
    && unzip $PDLIB_BRANCH \
    && mv pdlib-* pdlib \
    && cd pdlib \
    && phpize \
    && ./configure \
    && make \
    && make install

# Enable PDlib on builder

# If necesary take the php settings folder uncommenting the next line
# RUN php -i | grep "Scan this dir for additional .ini files"
RUN echo "extension=pdlib.so" > /usr/local/etc/php/conf.d/pdlib.ini

# Test PDlib instalation on builer

RUN apt-get install -y git
RUN git clone https://github.com/matiasdelellis/pdlib-min-test-suite.git \
    && cd pdlib-min-test-suite \
    && make

#
# If pass the tests, we are able to create the final image.
#

FROM nextcloud:apache

# Install dependencies to image

RUN apt-get update ; \
    apt-get install -y libopenblas-base

# Install dlib and PDlib to image

COPY --from=builder /usr/local/lib/libdlib.so* /usr/local/lib/

# If is necesary take the php extention folder uncommenting the next line
# RUN php -i | grep extension_dir
COPY --from=builder /usr/local/lib/php/extensions/no-debug-non-zts-20190902/pdli                                                                                b.so /usr/local/lib/php/extensions/no-debug-non-zts-20190902/

# Enable PDlib on final image

RUN echo "extension=pdlib.so" > /usr/local/etc/php/conf.d/pdlib.ini

# Increse memory limits

RUN echo memory_limit=1024M > /usr/local/etc/php/conf.d/memory-limit.ini

# Pdlib is already installed, now without all build dependencies.
# You could test again if everything is correct, uncommenting the next lines
#
# RUN apt-get install -y git wget
# RUN git clone https://github.com/matiasdelellis/pdlib-min-test-suite.git \
#    && cd pdlib-min-test-suite \
#    && make

#
# At this point you meet all the dependencies to install the application
# If is available you can skip this step and install the application from the ap                                                                                plication store
#
ARG FR_BRANCH=master
RUN apt-get install -y wget unzip nodejs npm
RUN wget -c -q -O facerecognition https://github.com/matiasdelellis/facerecognit                                                                                ion/archive/$FR_BRANCH.zip \
  && unzip facerecognition \
  && mv facerecognition-*  /usr/src/nextcloud/facerecognition \
  && cd /usr/src/nextcloud/facerecognition \
  && make

RUN DEBIAN_FRONTEND=noninteractive apt-get install -y libbz2-dev && \
    docker-php-ext-install bz2


Error processor

Description
Implements an error processor, that acts similar to the filter processor, only that it negatively acknowledges all records passed to it. This allows the user to stop the pipeline (or send records to the DLQ) if a record matches a certain condition.
I realized we need this when we updated the webhook processor to not fail on HTTP statuses less than 500. If a user wants to still configure the pipeline to fail if the status code is for example 404, they can configure an error processor now, e.g.:
version: 2.2
pipelines:
  - id: example
    status: running
    connectors:
      ...
    processors:
      - id: request
        plugin: webhook.http
        settings:
        response.status: '.Metadata["http_status"]'
      - id: fail-on-404
        plugin: error
        condition: `{{ eq .Metadata.http_status "404" }}`

[!IMPORTANT]
~Depends on https://github.com/ConduitIO/conduit-processor-sdk/pull/46, validate action will fail until we merge that PR and update the processor-sdk dependency.~ Updated.

Quick checks:

[X] I have followed the Code Guidelines.
[X] There is no other pull request for the same update/change.
[X] I have written unit tests.
[X] I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb a blog post would be nice, feel free to take the initiative on that one, I'm kinda swamped right now.


Exceptions on aenter not handled.

We are using aiomqtt to connect to AWS IoT Core with client certificate and just in time registration, this means first connection to broker will fail with an Operation Timed out exception from line client.py: __aenter__().await self._wait_for(self._connected, timeout=None). We have the following retry logic, but we continuously get  "MqttReentrantError" exception for following iterations since self._lock is not released and self._connected future is not re-initialized for the second call.
while True:
    try:
       async with client:
          ...

The following change in client.py: __aenter__() solved the problem.
-        await self._wait_for(self._connected, timeout=None)
+        try:
+            await self._wait_for(self._connected, timeout=None)
+        except Exception as e:
+            self._lock.release()
+            self._connected = asyncio.Future()
+            raise e

Following since I was debugging this with John.
Feel free to reach out to either of us if we can help with a reproduction!

Thanks both of you for the issue and the solution, good catch! 😊


cd in .bashrc Overrides wsl --cd launch argument from Windows

Windows Build Number
Microsoft Windows [Version 10.0.19043.1165]
WSL Version

[X] WSL 2
[X] WSL 1

Kernel Version
5.10.16
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps

Launch WSL.
Add cd ~ to your .bashrc file.
Close WSL.
Browse to some folder on your local disk. For Example: C:\ (backslash important).
Shift + Right-Click the folder.
Select 'Open Linux shell here' from the context menu.
WSL launches at ~ as defined in .bashrc rather than the folder specified in the context menu in Windows.

Note: Steps 4-6 can be replaced by running the following from PowerShell: wsl --cd C:\
Expected Behavior
WSL should open at the directory specified by the context of it's invocation / launch, rather than being overridden by the .bashrc file. In other words, the --cd argument should always be honored.
I might suggest that this argument should be processed by WSL AFTER the login process has run its course, including loading the .profile, .bash_profile, and .bashrc files. Only then, should WSL process the --cd argument passed in by Windows.
Actual Behavior
WSL incorrectly launches at the last-most directory specified by any cd command specified in the login files, thereby entirely ignoring the --cd argument passed in from the wsl launch command in Windows.
I've experienced this issue for years and have searched through all the Linux, Bash, and WSL documentations, as well as developer and Microsoft blogs, and even reached out to the WSL team on Twitter. I have found no solution to this problem.
Diagnostic Logs
No response

Isn't your "Actual Behavior" the "Expected" one? The --cd argument changes directory with chdir(2) in init process. Then init fork and exec bash. bash then reads .bashrc and changes directory again. So, the last working directory is determined by .bashrc.

While I see your point, this is the expected behavior when using .bashrc, as explained in the comment above. The best solution would to be to remove the cd command from your .bashrc.


feat: refreshable query atom

Small change to allow refreshing of query atom.

Hi, thanks for the suggestion. I have a few questions:

Does it really refresh (refetch) with this change?
Is it a typical way for tRPC for refetching? What is the case with trpc/react binding?

Yes, I tested this quickly with the Pokemon example app. The atom can be refreshed as expected
A refresh function is needed if the query result from TRPC can change overtime, for example if the result change after a mutation.

2: My question is how the API should be designed. I'm afraid the atomWithRefresh usage is not explicit, so people wouldn't notice. Maybe it's just a doc issue.

https://trpc.io/
Do you know where does it describe about refresh capability in their docs?

2: My question is how the API should be designed. I'm afraid the atomWithRefresh usage is not explicit, so people wouldn't notice. Maybe it's just a doc issue.

Oh, refresh here basically mean just fetching the resource again, so for example:
// Assume the TRPC server expose a query called
// `getCurrentTime` that will just return the current time
const [time, refreshTime] = jotaiClient.getCurrentTime();

// This would change everytime refreshTime is called
console.log(time);

How would you refetch query, if you used createTRPCReact without Jotai?

How would you refetch query, if you used createTRPCReact without Jotai?

createTRPCReact match reactQuery behaviour, so you will get a refetch function that you can call: https://tanstack.com/query/latest/docs/framework/react/reference/useQuery

https://tanstack.com/query/latest/docs/framework/react/reference/useQuery

I see.

Yeah, up to you how you want to expose this to the user, I guess :)

Doesn't sound too bad then. After all, it's still pre v1.

Please also change this:
diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json
index a59d926..6afcb06 100644
--- a/.codesandbox/ci.json
+++ b/.codesandbox/ci.json
@@ -1,5 +1,5 @@
 {
   "buildCommand": "compile",
   "sandboxes": ["new", "react-typescript-react-ts"],
-  "node": "14"
+  "node": "18"
 }


Switch to poppler pipeline

Currently, there are two issues with this:

[ ] weird gray border at the edge of any LTeX
[ ] bad render positioning, there's a little offset with Cairo recording surfaces which I don't know how to remove

Otherwise, it works and is probably faster than the current master.

weird gray border at the edge of any LTeX

Did you check what happens after processing the pdf in Makie?
To me it seems that all pdfs have a gray frame when opening on macos. After importing to inkscape that frame is gone.

Hmm, good point - will have to test that.  As I recall it did not.

Looks like there are rotation issues in the PNG backend, which is really strange, but aside from that it looks good.  I'm not comfortable merging this without figuring the PNG issues out, though.
With CairoMakie (rendered direct from surface)
corrupted_axis.pdf

SVG looks bad here but fine on my Mac, somehow.
With GLMakie (rendered to image and plotted), it doesn't show up at all:

OK, I still have some boundingbox issues but otherwise it looks fine.  See the following images:

As of https://github.com/JuliaPlots/MakieTeX.jl/pull/25/commits/5d0c7f86d432b861998f5a3a127bb6cc4bad2a23, I was rendering directly from Poppler on cairo_draw.  However: Poppler apparently forgets about the page at some point, so I am now trying to add a Glib object reference to CachedTeX.  If that doesn't work, then I'll switch back to Cairo surfaces.

This should now be ready for anyone who wants to try it!  External API is essentially the same, but two new features.

Set MakieTeX.MAKIETEX_RENDER_UNSAFE[] = true to use an experimental Poppler direct renderer.  It works well on CairoMakie PDFs and GLMakie but horribly otherwise.   It also somehow "forgets" (possibly Poppler garbage collection) the document content after more documents are loaded, so be sure you don't have too much tex with this!
Run MakieTeX.hijack_latexstrings!() to replace Makie's MathTeXEngine implementation with compiled LaTeX!  This works for everything - axis, label, etc.  Just pass a LaTeXString in.  It will even set the font color relative to the theme!

Also, text! has been overridden for TeXDocument as well, so you can directly plot text / tikz using those.

As a stopgap, I brute-forced the Poppler issue by reloading the pdf at each CairoMakie render.

New approach - devolve teximg to a Scatter of image markers or similar!  This will make the pipeline a lot clearer...

@greimel, thanks for the suggestion of tectonic!  It seems to work pretty well as a fallback, and it does basic TikZ as well!  I think that with this, we can successfully call MakieTeX platform-independent!
With the text hijacking, I can do this:
fig = Figure()
l1 = Label(
    fig[1, 1], L"A \emph{convex} function $f \in C$ is \textcolor{blue}{denoted} as \tikz{\draw[line width=1pt, >->] (0, -2pt) arc (-180:0:8pt);}";
    tellwidth = false, tellheight = true
)
ax1 = Axis(
    fig[2, 1];
    xtickformat = x -> latexstring.("a_{" .* string.(x) .* "}"),
    ylabel = L"\displaystyle \Phi(\vec x) = f(\vec x) + g(V)",
    ylabelpadding = 15
)
heatmap!(ax1, Makie.peaks())
fig

Two problems: note the large whitespace gap on the left (caused, I think, by a bad boundingbox in teximg) and the weird x tick labels.  The x tick label issue is just because of asynchronous updates, which I am not entirely sure how to handle.
Essentially, the ticks just take too long to render; because of that, there is some asynchronicity between the positions and the markers.  I would have to implement a pipeline such that the cached tex and positions go together - maybe by forcing the user to pass Vector{Tuple{CachedTeX, Point3f}}?

Theming is fully integrated!
julia> fig = with_theme(theme_dark()) do
                           fig = Figure(fontsize = 12, resolution = (300, 300))
                           ax = Axis(
                               fig[1,1];
                               xlabel = LaTeXString("time (\$t\$) in arbitrary units"),
                               ylabel = LaTeXString("here we go fellas"),
                               title  = LaTeXString(raw"A \emph{convex} function $f \in C$ is \textcolor{red}{denoted} as \tikz{\draw[line width=1pt, >->] (0, -2pt) arc (-180:0:8pt);}"),
                               xtickformat = x -> latexstring.("a_{" .* string.(x) .* "}"),
                               xlabelpadding = 12,
                               ylabelpadding = 12,
                           )
                           # plot to the axis
                           heatmap!(ax, Makie.peaks(); colormap = :inferno)
                           fig
                       end


Typo in URL text

Typo in URL text
Typo in URL text in the below mentioned site:
https://docs.microsoft.com/en-us/xamarin/android/app-fundamentals/services/foreground-services
Screenshot attached:

@nishanthmahe Thanks for your feedback. I transferred it to Xamarin team. They will track and fix the typo there.


[Bug] 使用 Cloudflare 无法完成构建

Describe the bug
A clear and concise description of what the bug is.
使用 Cloudflare 无法完成构建
与#3411遇到的错误不一样
To Reproduce
Steps to reproduce the behavior:

fork 本仓库
使用Cloudflare Page连接github构建
使用npx<EMAIL_ADDRESS>构建应用程序出错

Expected behavior
A clear and concise description of what you expected to happen.
预期：成功使用Cloudflare构建
Screenshots
If applicable, add screenshots to help explain your problem.
Deployment

[ ] Docker
[ ] Vercel
[ ] Server

Desktop (please complete the following information):

OS: [e.g. ]
Browser [e.g. ]
Version [e.g. ]

Smartphone (please complete the following information):

Device: [e.g. HUAWEI mate20]
OS: [e.g. HarmonsyOS 3.0.0]
Browser [e.g. chrome]
Version [e.g. 78.0]

Additional Logs
Add any logs about the problem here.
2024-02-12T09:53:28.061683Z	Cloning repository...
2024-02-12T09:53:28.911201Z	From https://github.com/grsu1/ChatGPT-Next-Web
2024-02-12T09:53:28.911928Z	 * branch            bfefb991921439dfee457b0a08002eb7347622ee -> FETCH_HEAD
2024-02-12T09:53:28.912266Z
2024-02-12T09:53:28.98352Z	HEAD is now at bfefb99 chore: update tauri dependencies (#4018)
2024-02-12T09:53:28.984047Z
2024-02-12T09:53:29.078782Z
2024-02-12T09:53:29.079315Z	Using v2 root directory strategy
2024-02-12T09:53:29.105491Z	Success: Finished cloning repository files
2024-02-12T09:53:29.784518Z	Detected the following tools from environment<EMAIL_ADDRESS><EMAIL_ADDRESS>2024-02-12T09:53:29.78518Z	Installing project dependencies: yarn
2024-02-12T09:53:30.431069Z	➤ YN0070: Migrating from Yarn 1; automatically enabling the compatibility node-modules linker 👍
2024-02-12T09:53:30.43132Z
2024-02-12T09:53:30.524971Z	➤ YN0000: ┌ Resolution step
2024-02-12T09:53:32.016617Z	➤ YN0061: │ stable@npm:0.1.8 is deprecated: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
2024-02-12T09:53:32.316595Z	➤ YN0032: │ fsevents@npm:2.3.2: Implicit dependencies on node-gyp are discouraged
2024-02-12T09:53:32.351483Z	➤ YN0061: │ @babel/plugin-proposal-dynamic-import@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-dynamic-import instead.
2024-02-12T09:53:32.367543Z	➤ YN0061: │ @babel/plugin-proposal-class-static-block@npm:7.21.0 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-static-block instead.
2024-02-12T09:53:32.425397Z	➤ YN0061: │ @babel/plugin-proposal-json-strings@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-json-strings instead.
2024-02-12T09:53:32.441013Z	➤ YN0061: │ @babel/plugin-proposal-export-namespace-from@npm:7.18.9 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-export-namespace-from instead.
2024-02-12T09:53:32.489668Z	➤ YN0061: │ @babel/plugin-proposal-private-property-in-object@npm:7.21.0 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
2024-02-12T09:53:32.494187Z	➤ YN0061: │ @babel/plugin-proposal-class-properties@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
2024-02-12T09:53:32.500864Z	➤ YN0061: │ @babel/plugin-proposal-private-methods@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
2024-02-12T09:53:32.503828Z	➤ YN0061: │ @babel/plugin-proposal-nullish-coalescing-operator@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
2024-02-12T09:53:32.530605Z	➤ YN0061: │ @babel/plugin-proposal-numeric-separator@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
2024-02-12T09:53:32.533033Z	➤ YN0061: │ @babel/plugin-proposal-optional-catch-binding@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-catch-binding instead.
2024-02-12T09:53:32.557965Z	➤ YN0061: │ @babel/plugin-proposal-logical-assignment-operators@npm:7.20.7 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-logical-assignment-operators instead.
2024-02-12T09:53:32.591033Z	➤ YN0061: │ @babel/plugin-proposal-unicode-property-regex@npm:7.18.6 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-unicode-property-regex instead.
2024-02-12T09:53:32.599679Z	➤ YN0061: │ @babel/plugin-proposal-async-generator-functions@npm:7.20.7 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
2024-02-12T09:53:32.608663Z	➤ YN0061: │ @babel/plugin-proposal-optional-chaining@npm:7.21.0 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
2024-02-12T09:53:32.612161Z	➤ YN0061: │ @babel/plugin-proposal-object-rest-spread@npm:7.20.7 is deprecated: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
2024-02-12T09:53:39.869273Z	➤ YN0000: └ Completed in 9s 344ms
2024-02-12T09:53:39.939065Z	➤ YN0000: ┌ Post-resolution validation
2024-02-12T09:53:39.939603Z	➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
2024-02-12T09:53:39.939778Z	➤ YN0000: └ Completed
2024-02-12T09:53:39.940076Z	➤ YN0000: Failed with errors in 9s 416ms
2024-02-12T09:53:40.00525Z	Error: Exit with error code: 1
2024-02-12T09:53:40.005473Z	    at ChildProcess. (/snapshot/dist/run-build.js)
2024-02-12T09:53:40.005606Z	    at Object.onceWrapper (node:events:652:26)
2024-02-12T09:53:40.005763Z	    at ChildProcess.emit (node:events:537:28)
2024-02-12T09:53:40.005897Z	    at ChildProcess._handle.onexit (node:internal/child_process:291:12)
2024-02-12T09:53:40.013099Z	Failed: build command exited with code: 1
2024-02-12T09:53:40.811702Z	Failed: error occurred while running build command

This should be fixed by https://github.com/ChatGPTNextWeb/ChatGPT-Next-Web/pull/4279


Rename ListDialplanEvent.php to ListDialPlanEvent.php

To avoid this message and respect the PSR-4 standard, please rename this file in ListDialPlanEvent.php
Class PAMI\Message\Event\ListDialPlanEvent located in ./vendor/marcelog/pami/src/PAMI/Message/Event/ListDialplanEvent.php does not comply with psr-4 autoloading standard. Skipping.

Coverage decreased (-38.9%) to 53.268% when pulling 7bb6fdc4e207c4dac6cd2f95613c54e301e159f0 on genpas:patch-1 into db4b2278e2f15362a176e79ae96a0fa3b2e66dd1 on marcelog:master.


sns#create_platform_endpoint: If token and attributes are the same, return endpoint

#4056

Hi @bblommers, thanks for confirming the PR. I've added & updated tests.
https://github.com/spulec/moto/pull/4055/commits/5d49275791978177126dcc4fea702aab04d62660
I was wondering if you could check them !

Codecov Report

Merging #4055 (5d49275) into master (7147c5f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4055   +/-   ##
=======================================
  Coverage   94.98%   94.98%
=======================================
  Files         465      465
  Lines       50450    50453    +3
=======================================
+ Hits        47918    47921    +3
  Misses       2532     2532

Flag
Coverage Δ

servertests
55.86% <20.00%> (-0.01%)
:arrow_down:

unittests
94.85% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/sns/models.py
96.50% <100.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7147c5f...5d49275. Read the comment docs.

thanks for review&merge!


pull request for e2e test at 01/14/2017 09:15:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


various for PMID:25987607

decreased protein localization to mitotic spindle pole body during M-phase
abolished protein localization to nucleus during mitotic M-phase
abolished protein localization to nucleus during mitotic interphase
abolished protein localization to mitotic spindle during M-phase
standard defs

also
abnormal protein localization to microtubule minus end

new terms
abolished protein localization to nucleus during mitotic interphase FYPO:0004753
abolished protein localization to mitotic spindle pole body during mitosis FYPO:0004754
abolished protein localization to mitotic spindle during mitosis FYPO:0004754
abnormal protein localization to microtubule minus-end FYPO:0004755
For the first request, I added another synonym to FYPO:0002822 'decreased protein localization to mitotic spindle pole body during mitosis' (it already had the related synonym 'decreased protein localization to mitotic spindle pole body during mitotic M phase').
Similarly, for the second one I added synonyms to FYPO:0003192 'abolished protein localization to nucleus during mitosis', and named the new terms using 'mitosis'.
I've also standardized the other terms  on 'mitosis' in name & xp, and 'mitotic M phase' in related synonyms, because we had a lot more terms with 'during mitosis' to start with, and a few had the 'M phase' synonyms. I can separate them out if it turns out we need to make a distinction (would need an explanation of what the distinction is, for the text defs).
... and I included FYPO:0004754 by mistake because I got my head spun right round, but it won't hurt to keep it in case it's useful later.

edit file: 0f9dda8eb776ac06d7de0f4795eb1ae6da751294
release: 863e7570fe1db168c75b987dcd624cf183f18827


required === notNull?

It seems that the required flag is only used in Model validation, and the notNull flag is translated to NOT NULL for the underlying database.
Is it a good idea to have required reflected in notNull? Since mismatching those does not make sense, it would mean the Model validation accepts a null value, but the database doesn't, or the other way around. Both cases are broken, but the former most.
Adding a case for required that overrides attr.notNull with the same value as required here would suffice I think:
https://github.com/balderdashy/waterline/blob/master/lib/waterline/core/schema.js#L155
Thoughts?

Hi @aars, that's a very interesting question. From a validation standpoint they are indeed very similar, check required vs. notNull code.
The only advantage I can think of in keeping them as they are is that enforcing a required validation doesn't impose database constraint as notNull does, but that would probably be an edge case.
Not sure what was the original intention for this difference, not even sure if it was intentional. Do you know @particlebanana?

@dmarcelino What would be the actual use case of this enforced 'requiredbut nonnotNull` edge case? I don't think there is one.

I can image cases where you have more than one process using the DB and one process may need less restrictions than the other. Example, one automated process pre-populates records in a DB. Then that DB is exposed via a web service to a human who has the task of enriching those records. In a case like this you may want the automated process to get away from filling a given field but you may want to enforce the human to fill it. I'm sure this won't be common, like I said, an edge case.

When you define your data model and specify that a property is required, in my opinion, you are specifying that that property is required in your data model. Just that. To ensure correctness.
It starts to get confusing when the definitions of a data model act one way on input (checking for existence of a required property), and another on output (db-write), since the required flag does not have an effect towards my database. I can also safely retrieve a record from my database that is missing a required value. IMHO That's simply broken.
In the edge case you describe, the property is simply not required in the data model. When it becomes required it should either migrate that data to a model where the property is required, or the requiredness of the property is enforced in the input validation. Not in the ORM.

When you define your data model and specify that a property is required, in my opinion, you are specifying that that property is required in your data model. Just that. To ensure correctness.

I would agree with this if the properties used in model definition were all DB constraints but they are not, it's a mix between validations and DB constraints. For example, unique is purely a constraint that has no validation associated with. On the other hand email is a validation that has no DB constraint associated with. It gets bit blurry in other cases, for example, notNull is both validation and constraint.

That is exactly why it is confusing :)
One thing that we could improve anyhow are the docs. They could be more clear about what validations, db contraints and/or both are.
Personally I think enforcing notNull on required is a good choice, but we could make it so required implies notNull, and notNull itself could be used to override it to false if someone really really wants to.

One thing that we could improve anyhow are the docs. They could be more clear about what validations, db contraints and/or both are.

@eddieajau is doing a great job in balderdashy/waterline-docs/pull/71: Refactoring docs. Feel free to add comments to the PR to further improve it :wink:

Personally I think enforcing notNull on required is a good choice but we could make it so required implies notNull, and notNull itself could be used to override it to false if someone really really wants to.

I'm not sure that's less confusing that what exists now :) With the extra nuisance of potentially not being backwards compatible.
In my opinion, the good thing of the current way required / notNull work is that the developer has options:

required - validation at the ORM level, don't enforce in the DB;
notNull - validation at the ORM level plus DB constrain.

The bad thing is that, as you pointed out, it's confusing what effect each option has on the DB. At this point I'm personally not sure if we should change required behaviour or just improve the docs.
I would also love to know what the original authors (@balderdashy/owners) had in mind when they created required and notNull.

@dmarcelino I agree. It might just get more confusing ;) At least now I know (and I was told that's half the battle). I'm curiouabout the original intent as well.
I'll comment on the docs. Thanks for your time.

@aars, check https://github.com/balderdashy/waterline/issues/1047#issuecomment-111140584, notNull may become different than required after all. Would love to hear your opinion on that thread.

I think it's worth updating the docs to note the exact behaviour the required is testing for. I'm happy for you to assign this issue to me and I'll work on something after the new structure is merged if you like.

Lets continue discussing this issue in balderdashy/waterline-docs#86.


docs: fix the description of MaxHeight

Thanks for catching this, @Isti115!

You're welcome, always happy to help where I can. 😉
Thank you for these amazing libraries! 🙂
I've just discovered the whole "charm" ecosystem and everything is so well executed, from the libraries to the apps and the website is awesome as well. 😀


Updated a multilingual site from <IP_ADDRESS> to 8.2 latest git and got error

I tried to update a multilingual site from <IP_ADDRESS> (with 2 languages present) to latest git version (06112017). And I got the following woops error;
Doctrine \ DBAL \ Exception \ InvalidFieldNameException
An exception occurred while executing 'update Stacks set siteTreeID = ?' with params [1]: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'siteTreeID' in 'field list'

Is this a known bug, or?

It looks like your installed version is still <IP_ADDRESS>, did you run the upgrade?

I ran the http://site.dk/index.php/ccm/system/upgrade and that error popped up after a few seconds. So yes I ran the upgrade!

I tried to do it again with 8.2.0RC1 and got same result (same error).
I made a small video of what I did here: https://www.concrete5.dk/assets/c5-82-upgrade-error/
Here is a screenshot of how the site structure looks like on this site:

I still can't upgrade after trying latest RC1 (20170621) - Still get same error!

Any error logged to /dashboard/reports/logs ?

@mlocati I can't get to the dashboard after the upgrade attempt. It's totally crashed and I have to reload the database from backup and I also have to replace the files in /application/config/doctrine/proxies because they were replaced by the upgrade before the crash.

After the crash, you could check the contents of the Log database table if you can't access the dashboard: more details are really needed to  find the cause of this issue

Just a moment, I'll try again now...

I got 2 new entries in the log:
Number one:
Exception Occurred: /var/www/clients/client1/web56/web/concrete/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:71 An exception occurred while executing 'update Stacks set siteTreeID = ?' with params [1]:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'siteTreeID' in 'field list' (0)
And number 2:
Exception Occurred: /var/www/clients/client1/web56/web/concrete/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:71 An exception occurred while executing 'update Stacks set siteTreeID = ?' with params [1]:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'siteTreeID' in 'field list' (0)
But I think that number 2 came because I tried to get to the dashboard and got the same woops error.

That's really strange: the problematic line https://github.com/concrete5/concrete5/blob/8b09b1f6b8b59e1f7109d69dfeb90e5a697b2036/concrete/src/Updater/Migrations/Migrations/Version20160725000000.php#L893 occurs after https://github.com/concrete5/concrete5/blob/8b09b1f6b8b59e1f7109d69dfeb90e5a697b2036/concrete/src/Updater/Migrations/Migrations/Version20160725000000.php#L181 (where the column should be created)... maybe is the transaction that causes problems?

I have no idea about this. Doctrine is still black water for me (Ronny, my colleague,  is beginning to understand it). But it's a real problem - I have a number of multilingual sites that needs upgrading.

I think the issue is that we had the siteTreeID column in Stacks in early
8.0 and 8.1 – and now we've actually removed it again. So we either need to
force people to upgrade to 8.1 and then 8.2 – or we modify the large 8.0
upgrade routine and remove that siteTreeID update SQL (because it's not
actually used.)
On Thu, Jun 22, 2017 at 1:08 PM, Michael Jensen-Maar <
<EMAIL_ADDRESS>wrote:

I have no idea about this. Doctrine is still black water for me (Ronny, my
colleague, is beginning to understand it). But it's a real problem - I have
a number of multilingual sites that needs upgrading.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/issues/5543#issuecomment-310488427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgNwTlfGTRt44nK7fjfcbVLs68JjL36ks5sGsmwgaJpZM4N2XFO
.

Upgrading a multilingual site from 7.5.13 to 8.1 totally messes up the stacks and global areas. I'm not sure an upgrade from 8.1 to 8.2 then would fix that.

I think the issue is that we had the siteTreeID column in Stacks in early
8.0 and 8.1 – and now we've actually removed it again.

@aembler you're right: I didn't noticed commit cbbcb874c8d8a8870bfcd7c2ed4ddf7a95e9664d
So, what about #5600?

Should I make a test where I simply remove this line and then run the updater again?

I just did! And it seem to work. I did get some errors, but I'm not sure if it's core related. But the site is running 8.2 after the upgrade so I think it's OK!

Could you post here the errors you've had?

I'm almost sure they are SuperMint3 (the theme) related. But here it is:

I also see that when upgrading a multilingual site, all auto_nav blocks has to be moved one level up.
If I fx. had a top menu auto_nav that was set to second level I now have to set it to first level to get the same result.
I can live with that, but a very big site would be a big pile of work to change settings in all auto_nav blocks used in sidebars on all pages. But it can be done and it's not generating any error, it's just annoying.

I get an other interesting issue. But it's definitely an SuperMint3 theme issue. I'm trying to contact Sebastien (SuperMint developer) by Skype right now. But I get this error in the browser console:
"Resource interpreted as Stylesheet but transferred with MIME type text/html"
This did not happend before the upgrade!

This is resolved with #5601


Breakout rooms: apply figma designs

https://www.figma.com/file/WnaolONWg9gV7YJysTOk3d/App-Protótipo?type=design&node-id=3834-2891&mode=design

For the first part, only the join breakout room process. we can resume the activity and tackle the development of the "creation of group rooms" in a second part

Something like that, but without the Moderator options (


Add inputType to RichTextEditor to allow auto capitalisation

Fixes https://github.com/matrix-org/matrix-rich-text-editor/issues/826.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c698b1b) 87.43% compared to head (b396781) 89.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #879      +/-   ##
============================================
+ Coverage     87.43%   89.39%   +1.95%
============================================
  Files           165       86      -79
  Lines         18956    15324    -3632
  Branches       1045        0    -1045
============================================
- Hits          16575    13699    -2876
+ Misses         2087     1625     -462
+ Partials        294        0     -294

Flag
Coverage Δ

uitests
?

uitests-android
?

uitests-ios
?

unittests
89.39% <ø> (+3.86%)
:arrow_up:

unittests-android
?

unittests-ios
?

unittests-rust
89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CASMINST-5894: hex-aware unix-fu for setting efibootmgr nextboot

Description

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4

/backport main


Don't Merge! PR real time test for source branch full build

OPS Build status updates of commit 8894e66:
:clock10: Full build: average full build time is 6 min(s) 12 sec(s) [calculated from last 15 build(s)]

Note: This is a FULL build due to a configuration change (usually in openpublishing.publish.config.json and/or docfx.json). It is strongly suggested to merge this configuration change after the business hours, as it could impact the overall build performance of other PRs on the 'pr-basebranch' branch. For more detailed info, please click here.

OPS Build status updates of commit 8894e66:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


cache name collisions of 2 functions with the same name on different modules

I think the @cache solution works, as well as using no decorator.
When I update to the newest version (v7.23.0) of gdsfactory and use @gf.cell(autoname=False, copy_if_cached=False) it seems like functions with the same name in different modules (e.g. module1.some_function returning 'comp1' and module2.some_function returning 'comp2') return the component imported from the function which gets called first. When the function in the second module is called afterwards it doesn't return the component that it is supposed to import, but instead seems to refer to the function in the first module and returns that component instead. So if we first use module1.some_function, calling module2.some_function afterwards returns comp1 instead of comp2.
Originally posted by @FJohlinger in https://github.com/gdsfactory/gdsfactory/discussions/1547#discussioncomment-9094365

You can do this
in module1

@gf.cell(include_module=True)
def straight(**kwargs):
  return gf.components.straight(**kwargs)


feat(KITT3-2662): add alias mapping for markdown import of nested lists

adds an alias mapping of lists for markdown import from figma pages (up to 3 levels nesting)
'-' or '#' character denoting a list item are not provided by the Figma API due to Figma autocomplete behavior, instead list items in a list should be prefixed by editors '>' which will be replaced with '-' during markdown import
Example:

looks good


Docker image build for test

Purpose

Build the ballerina base image prior running the tests so that it wont pull the image from dockerhub. Using the image from dockerhub leads to inconsistencies with the ballerina compiled balx.

Goals

Increase build stability.

Approach

Use assembly plugin to build a zip file and then build the docker image using the java client.

Codecov Report

Merging #208 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #208      +/-   ##
===========================================
- Coverage     65.06%   64.7%   -0.36%
+ Complexity      117     116       -1
===========================================
  Files            14      14
  Lines           561     561
  Branches         56      56
===========================================
- Hits            365     363       -2
- Misses          167     168       +1
- Partials         29      30       +1

Impacted Files
Coverage Δ
Complexity Δ

...erinax/docker/generator/DockerArtifactHandler.java
53.28% <0%> (-1.46%)
14% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1826a...61aacf9. Read the comment docs.


Add a "funds raised" banner to website that tracks total Euros raised

We could have a banner which shows the total Euros raised so far at the top of the website... not sure if it will look cool or not, but perhaps there is another "simple" way to share our progress besides the blog posts?
@PaulaNietoG what are your thoughts?

This looks very promising: https://chartscss.org/components/data/
Not sure if it should go on the main page (index) or the about page...

I think it's a good idea, I like this style that show the rounded amount of money either directly or when hovering:
. I'd put it on home, next to the PCBakers logo. It would also be nice to add the month/year below each bar 😄

That's what I was thinking too- using some of the animation/mouseover styles to make it fancy, then we just need to update the table with the new info once a month and this library takes care of the rest in css. There were two types of visualizations which I thought could work:

the column plot would be nice to show the month-by-month breakdown  (the one you mentioned)
the area plot may be better to show the cumulative funds raised since PCBakers began

, maybe making the mouseover on each month would reveal the amount raised in that month? Not sure if it's possible but we can experiment.

That's what I was thinking too- using some of the animation/mouseover styles to make it fancy, then we just need to update the table with the new info once a month and this library takes care of the rest in css. There were two types of visualizations which I thought could work:

the column plot would be nice to show the month-by-month breakdown  (the one you mentioned)
the area plot may be better to show the cumulative funds raised since PCBakers began
, maybe making the mouseover on each month would reveal the amount raised in that month? Not sure if it's possible but we can experiment.


Run it on some known datasets

https://github.com/robvanvolt/DALLE-datasets
imagenet1k
imagenet21k
coco

store output somewhere convenient (kaggle, huggingface?)

https://github.com/rom1504/img2dataset/tree/main/examples
should be easy now that end2end is available, do it

do that then put it in the exploration demo


Updated all dependencies to latest version

Description
I have updated all the dependencies of the project.

please use the proper template for the pull requests

also use single quotes in your prettier config as we are trying to use single quotes over the whole codebase


Wondering if Pinpoint Agent 2.5.4 supports Vert.x version 4.2.5.

I am Wondering if Pinpoint Agent 2.5.4 supports Vert.x version 4.2.5.
In the comments of the github source code of the 2.5.4 agent plugin, the range is up to 4.2.2,
but I wonder if version 4.2.5 is not supported.
Because the README file says that version 4.X is supported.

The pinpoint agent 2.5.4 version supports vert.x 4.2.5 version.
It also supports versions from pinpoint agent 3.0 to vert.x 4.5 and later.


error api vesion

Output of helm version:
Output of kubectl version:
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
[root@dev3 kubernetes]# helm template istio --namespace istio-system ./helm/istio > ~/istio-1.2.2.yaml
Error: apiVersion "config.istio.io/v1alpha2" in istio/charts/mixer/templates/config.yaml is not available

@13567436138 Can you show the the istio/charts/mixer/templates/config.yaml template to better understand the issue? Also, what Helm and k8s versions are you using?

the problem of helm,downgrade from 3.0.0.beta3 to 2.14.0 solve the problem

i guess, that this issue is related to https://github.com/helm/helm/issues/5654.
it's necessary to add the parameter --validate to the templating command. then the available api-versions will be checked against the remote-cluster. without the --validate parameter, the validation is executed against the default k8s api-types.
IMO opinion there are two optimizations which may be discussed in this context.

the naming parameter --validate is quite irritating - because a validation happens always, it just tell helm to perform a remote-validation --> call the parameter --remote-validation
a complete "offline-templating" isn't available in helm v3. it would be nice to have the offline-templating without validation back

PS: i opened the issue https://github.com/helm/helm/issues/6452 where i've found another issue in combination with this validation, when the client-go cache isn't up-to-date.

The istio chart is known to not work with Helm 3. It uses the crd-install hook which was dropped in Helm 3. https://github.com/istio/istio/issues/17167


list_messages returns more messages than requested

Bug description
If messages are cached, then list_messages returns more than expected if there are some with the same message_type, because they just get added https://github.com/iotaledger/wallet.rs/blob/6385301b1935a45da91d47dda086725fe779f597/src/account/mod.rs#L1224
Steps To reproduce the bug
Explain how the maintainer can reproduce the bug.

let txs = await account.listMessages(0, 0, 1)
console.log('this is length', txs.length)
txs = await account.listMessages(0, 1, 1)
console.log('this is length', txs.length)

I get both prints with length 1, however, when disabling the first 2 lines, the skip in the second call is applied and i get a length of 0 (expected behaviour)
Expected behaviour
I don't think we should just append all cached messages
Actual behaviour
Cached messages get just added

Have you solved？I got the same issue


build: add update-ends-newline.sh to add ends-newline

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #232
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/ok-to-test

/approve
/lgtm


How to fail the build when SQ fails?

We are very happy with the integration with SQ. We have been spending 2 weeks on cleaning up our code base and think we are ready for our builds to fail whenever SQ fails.
Is there a way to fail a build? Note we want the results from the server (it has some "resolve as won't fix" configured stuff), not only local results.
I hope it's possible to get the results back while pushing to the server, and of course I am happy to PR something if it's not possible yet.

This plugin cannot do that.
There's probably some sonar api you can use to request the number of issues of the build and some baseline you can compare it with.
I know that its possible using a sonar plugin for bitbucket. It's a long shot but that might work for you. You can configure it as a merge blocker on a pull request.

I am already building it, wanted to show it to you but it's not done yet ;-)

I think I got it working, here is the output:
The SonarQube Scanner has finished
19:48:27.044  Creating a summary markdown file...
19:48:27.053  Analysis results: https://[redacted]/dashboard/index/[redacted]
19:48:27.055  Post-processing succeeded.
Checking whether the project passed the SonarQube gateway...
SonarQube gateway status returned from request: 'OK'
The SonarQube gateway for '[redacted]' returned OK, well done! If you want to show off the results, check out https://[redacted]/dashboard?id=[redacted]

Here is the full script:
https://github.com/GeertvanHorrik/RepositoryTemplate/blob/master/replace/deployment/cake/tasks.cake#L108
Of course you are allowed to use any of it if you want to incorporate it into his extension.

I think I got it working, here is the output:
The SonarQube Scanner has finished
19:48:27.044  Creating a summary markdown file...
19:48:27.053  Analysis results: https://[redacted]/dashboard/index/[redacted]
19:48:27.055  Post-processing succeeded.
Checking whether the project passed the SonarQube gateway...
SonarQube gateway status returned from request: 'OK'
The SonarQube gateway for '[redacted]' returned OK, well done! If you want to show off the results, check out https://[redacted]/dashboard?id=[redacted]

Here is the full script:
https://github.com/GeertvanHorrik/RepositoryTemplate/blob/master/replace/deployment/cake/tasks.cake#L108
Of course you are allowed to use any of it if you want to incorporate it into his extension.

The link you have provided is not working. I end up at https://github.com/GeertvanHorrik/RepositoryTemplate/blob/master/deployment/cake/tasks.cake but could not find anything related to gateway failure. Could you point me to the right source please?

It's in this finally block where we fail the build (including a link to the sonarqube gateway that failed):
https://github.com/GeertvanHorrik/RepositoryTemplate/blob/master/deployment/cake/tasks.cake#L345


consider all addresses on an interface

An interface can have multiple addresses. We should consider all addresses on an interface when we are looking for an interface with a given address.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Shimin Guo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.1%) to 16.899% when pulling 9e626bee2e08ccfca77937fd2fbcce3796052b90 on guoshimin:multiple-addrs into c22607684e0122246f07fd0074f7ca5b74fe0e83 on aledbf:master.

Ping @aledbf

@guoshimin thanks!


tests: disable base tests in xdp/tc nodeport lb test

Flaky once in a while, so disable for now until we have found
the cause for it.
Signed-off-by: Daniel Borkmann<EMAIL_ADDRESS>

test-me-please

Coverage increased (+0.03%) to 46.844% when pulling 97e70bb5e860a2bc7c57ba79c422cbf9242c80a3 on pr/disable-nodeport-base-tests into 58195f13295ea2579fc7b61694737a6419256c21 on master.

test-me-please


[Feature request] CompletionItem's icon can be defined by icon property.

Since now the CompletionItem's is defined by the kind, I think we can also support an optional icon: string | Uri property that will make it more powerful.
What I want to implement is an extension that can autocomplete color by providing a color palette, and I can see what the color really is by the CompletionItem's icon. This will help developers choose the appropriate colors.
Look forward to your reply.

Honestly, this is unlikely to happen because it also impact the LSP and that mean each extension needs to ship icons that match the style of the corresponding editor, Eclipse style icons, Sublime style icons etc. That's why we have common set of kinds which editor associate to icons.


catch levels for decision tables

Get catch level recommendations from the JMC for 2020. At the 2019 Feb. SRG meeting it was brought up that equally spaced increments could be helpful.

To run forecasting with the new catch level of 500,000, make a copy of the base model folder and call it 2019.03.00_base_srg500000, then delete the folder mcmc/forecasts
Run the following:
source("R/all.R");build(TRUE, FALSE, FALSE, "2019.03.00_base_srg500000")

Also have to update the captions (in Exec Summary and main tables) , and check the actual text.....

Hmmm.... I get an error:
...
If you see 999, we got to the end of the control file successfully! 999
Making a copy of an unallocated dvector
Making a copy of an unallocated dvector
 end of parameter section
Error: param_init_bounded_number_vector was not allocated.
Error in file(file, "rt") : cannot open the connection
In addition: Warning messages:
1: In shell(shell.command) :
  'cd c:/andy18/github/hake-assessment/models/2019.03.53_fecundity/mcmc/catch-levels/default-hr & ss3 -mceval' execution failed with error code 1033
2: In file(file, "rt") :
  cannot open file 'c:/andy18/github/hake-assessment/models/2019.03.53_fecundity/mcmc/catch-levels/default-hr/derived_posteriors.sso': No such file or directory

Same for base case. I'll try again in the morning (when more alert!), just mentioning in case anyone else gets it....

I got an error too, but restarting my R workspace seems to have solved it.

Ah, that old chestnut. But I started a new R session each time.

Just so you know, I'm most of the way there but having some issues with the risk plot. I'll push everything once I get that right. It's been a lot of poking around and debugging to get this right.

I got it working at 1AM. I have the new doc built for the morning

All done and Chris automated the captions.
My error was not due to any changes - I just can't run SS any more...

I'm guessing this was opened again so that we could ask JMC in July about whether or not to keep the levels we have or use new ones? The technical aspects of code are all done and working.

Yes. They should be able to specify then what they want, so we don't have to re-run in the meeting (which then caused me further problems). Though I think now we have an idea of what people will want - just make sure there's not a big gap of, say, 200,000 t between the useful values.

So last year we originally (submitted version) had a big gap between 410,000 and 587,000 for 2019 catch. So in the meeting we added the intermediate 500,000. This year the coverage is fine.


Exception on storing-credentials example

On line where opening json file it raise "AttributeError: 'module' object has no attribute 'parse'".
https://github.com/debrouwere/google-analytics/wiki/Authentication#storing-credentials
Posible solution supporting python 2 and 3
    import os
    import sys

    if os.path.exists(CREDENTIAL_FILE):
        # credentials = json.parse(open(CREDENTIAL_FILE))
        if sys.version_info[:2] >= (3, 0):
            credentials = json.load(open(CREDENTIAL_FILE))
        else:
            credentials = json.load(file(CREDENTIAL_FILE))

Thanks, fixed!

(Also, Python 3 uses open just like Python 2 does.)


Can't find file after eas build with artifactPath

Hi everyone,
I am a beginner with Expo and I am working on a CI/CD project to upgrade our deployment and test flow.
I am currently facing an issue with my generated artifacts from Expo as I would like to store them in my repository after the build succeeded in order to retrieve them later with pipelines.
I use the following command to build my project on Expo for both iOS and Android :
eas build --platform all --non-interactive --profile preview
Eas.json file description :
"build": {
    "preview": {
      "android": {
        "buildType": "apk",
        "artifactPath" : "android/build"
      },
      "ios" : {
        "simulator" : true,
        "artifactPath" : "ios/build"
      },
      "distribution": "internal"
    }
  },

Project structure :
I have both folders in my project :

android/build
ios/build

Final issue :
My app has been successfully builded on Expo but I can't find my artifact (app.tar.gz for iOS) in my /ios/build folder.
Here is the build output :
✔ Build finished

🍎 iOS app:
https://expo.dev/artifacts/eas/***********.tar.gz

If anyone has an idea how I can retrieve it correctly, it would help me a lot.
Thanks in advance !

@wkozyra95 Thanks for the reply !
That looks clear now.
Would it be possible to automatise this ? It would help me a lot !

Yes, you can run eas build --json  pipe that to e.g. jq and extract archive URL from that. After you get URL just curl/wget and commit changes

Thanks a lot !
I will take a look to that and test, I might close the issue a bit later if it works.

I think it worked, I managed to retrieve the output and curl the url but the output of the curl is quite strange.
I have a link to my artifact as a .tar.gz file but when I unzip it, I don't see any .app file. Am I missing something there ?

I am following the expo EAS build documentation and it says that I should have a tar.gz file after the build.
I successfully retrieve it and I managed to download it with curl as you recommended in your reply. However, I don't see any .app file as mentioned in the documentation. Am I missing something?

I'm closing the issue because of the inactivity. Let us know if we can help you with anything.


[feat] create project with out git user config

Describe the feature
I am creating a new project on window.
It show me an error.
 Run git config --global user.email<EMAIL_ADDRESS>git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: unable to auto-detect email address (got 'cqh@DESKTOP-3UUOHOC.(none)')

can onlook create new project without a git config?

@cqh963852,
We'll move away from using git to create the new project in the future. For now, is this a hard blocker for you?
You could also import any React/Nextjs project instead. This process simply clones this Nextjs template https://github.com/onlook-dev/starter-v1 and import it. So you can clone it or create a new next project https://nextjs.org/learn-pages-router/basics/create-nextjs-app/setup and import it instead.
Does this help?


Session 3 slides for intro and patchwork

This gets things started for the part 3 slides.

I get this:
The package "gridGraphics" is required to add base plots to patchworks

I'll install gridGraphics and try again.

Otherwise looks great to me! I guess we'll eventually want to get a list of all the dependencies across the three sections 😆


Cart rule not working For Shipping code .

Framework Version: 0.1.6

Framework Version: 0.1.6

Fixed


Revamped User Interface: Title Bar, Dark Mode, and Stylish Cards

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #4918
Description

Revamped Title Bar: Redesigned the title bar to improve visibility and aesthetics, ensuring a modern, clean look.
Dark Mode Toggle: Added a dark mode toggle for a seamless switch between light and dark themes, enhancing user experience.
Background Redesign: Updated the background styling to improve readability and visual appeal.
Improved Container Padding: Adjusted padding for a balanced layout and better content alignment.
Hover Effects on Cards: Introduced a new hover effect on cards, changing the background and text colors for an interactive, engaging feel.
Color Scheme Update: Enhanced colors to ensure consistency and accessibility across the interface.
Overall Page Optimization: Refined layout and visual elements to create a cohesive and user-friendly experience.

These updates collectively elevate the UI, making it more responsive, visually appealing, and accessible.
Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
BEFORE:

AFTER:

Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

ohh there are conflicts


Copy TaskCache from MVC

https://github.com/aspnet/Coherence-Signed/issues/345
@pranavkm

:shipit:


Ignore whitespace when viewing diff of a branch

Fixes #8 which just needed to activate the extension on BitBucket's branches url regex (add to manifest)

@kyleladd thanks for the update. The updates to the extension have been published to the Chrome Web Store; should be available in an hour or so:
https://chrome.google.com/webstore/detail/white-space-diff-for-bitb/bkopdnhlifaaimncdeklkmlcllkfeahi
Cheers!


feat: Add UDP GRO option

Allows setting UDP_GRO on the socket.
https://www.man7.org/linux/man-pages/man7/udp.7.html

Enables UDP receive offload.  If enabled, the socket may
receive multiple datagrams worth of data as a single large
buffer, together with a cmsg(3) that holds the segment
size.  This option is the inverse of segmentation offload.
It reduces receive cost by handling multiple datagrams
worth of data as a single large packet in the kernel
receive path, even when that exceeds MTU.  This option
should not be used in code intended to be portable.

@Thomasdezeeuw Thank you, I've implemented your feedback, the only thing I wasn't 100% sure on was "Could also you make sure it's order by option name." let me know if I need to make more changes

Thanks @XAMPPRocky


add fault tolerance plugin

Is your feature request related to a problem? Please describe.
Resiliency against failure e.g

ability to retry a database query that times intermittently,
ability to timeout a database query that takes some time to execute,
falling back to executing a cached query / function after several errors

Describe the solution you'd like
a plugin that declares:

@retry, @timeout, fallback annotations to support various fault tolerance pattern.
or that offers a configurable programmatic api to apply the above pattern

Describe alternatives you've considered
This is current achievable by hooking into the created resolvers and compose them into any of your preferably circuit breakeer / fault tolerant js library.

/cc @craicoverflow, @wtrocki
Automatically generated comment to notify maintainers

You reading my mind don't you? And have been on fire today!
Thank you for logging this issue as I had this somewhat planned when dealing with production ready template.

This is current achievable by hooking into the created resolvers and compose them into any of your preferably circuit breakeer / fault tolerant js library.

I would look for doing this first as bringing more opiniated approaches into graphback might drive off some community. We have multiple ways to compose things (including services) and that might work.
Sorry for snapping issue. We can chat about it at some point

You reading my mind don't you? And have been on fire today!
Thank you for logging this issue as I had this somewhat planned when dealing with production ready template.

This is current achievable by hooking into the created resolvers and compose them into any of your preferably circuit breakeer / fault tolerant js library.

I would look for doing this first as bringing more opiniated approaches into graphback might drive off some community. We have multiple ways to compose things (including services) and that might work.

+1 this is a good idea.

Sorry for snapping issue. We can chat about it at some point

Sure, that's the whole idea of opening this issue, to get the discussion going.

Hey, I'd like to work on this issue.
What would be a good starting point for this?

Hey, I'd like to work on this issue.
What would be a good starting point for this?

Hi @namit-chandwani. Follow the Plugin creation guide and check out the other plugins for help.
We don't have any strict approach for this other than the description provided by @machi1990.

Hi @namit-chandwani. Follow the Plugin creation guide and check out the other plugins for help.
We don't have any strict approach for this other than the description provided by @machi1990.

Hey @craicoverflow!
I've now got an idea of how plugins work in Graphback by going through the relevant docs.
But there's this one thing that I need help with.
Let's say I make some changes in the SchemaCRUDPlugin.ts file.
After that, I move to the packages/create-graphback directory where I run node dist/index.js Trial-Graphback-Project to initialize a server named Trial-Graphback-Project using any one of the Graphback's existing templates.
Then I move into the generated graphback server's directory (ie. Trial-Graphback-Project) where I find the .graphqlrc.yml file, which is configured to use the Schema CRUD Plugin in order to generate the schema.
Now whenever I run the yarn generate command here, I would want the updated local version of my SchemaCRUDPlugin.ts file to be used for schema generation.
But we know that won't happen, as @graphback/codegen-schema package present in node_modules is the one which was installed at the start (using yarn install) and not the local one present in packages/graphback-codegen-schema/, so it does not contain the changes which I had made locally.
So I looked this up on the internet and found a solution which uses the npm link command.
I then followed the following steps to link the generated graphback server to the updated local version of the @graphback/codegen-schema package:

cd packages/graphback-codegen-schema/  ->  npm link
cd packages/create-graphback/Trial-Graphback-Project/  ->  npm link @graphback/codegen-schema

But no luck even after following the above steps. Still the locally updated SchemaCRUDPlugin.ts file is not being used for schema generation.
Is there anything that I'm doing wrong here while using the npm link command?

Hey @craicoverflow!
I've now got an idea of how plugins work in Graphback by going through the relevant docs.
But there's this one thing that I need help with.
Let's say I make some changes in the SchemaCRUDPlugin.ts file.
After that, I move to the packages/create-graphback directory where I run node dist/index.js Trial-Graphback-Project to initialize a server named Trial-Graphback-Project using any one of the Graphback's existing templates.
Then I move into the generated graphback server's directory (ie. Trial-Graphback-Project) where I find the .graphqlrc.yml file, which is configured to use the Schema CRUD Plugin in order to generate the schema.
Now whenever I run the yarn generate command here, I would want the updated local version of my SchemaCRUDPlugin.ts file to be used for schema generation.
But we know that won't happen, as @graphback/codegen-schema package present in node_modules is the one which was installed at the start (using yarn install) and not the local one present in packages/graphback-codegen-schema/, so it does not contain the changes which I had made locally.
So I looked this up on the internet and found a solution which uses the npm link command.
I then followed the following steps to link the generated graphback server to the updated local version of the @graphback/codegen-schema package:

cd packages/graphback-codegen-schema/  ->  npm link
cd packages/create-graphback/Trial-Graphback-Project/  ->  npm link @graphback/codegen-schema

But no luck even after following the above steps. Still the locally updated SchemaCRUDPlugin.ts file is not being used for schema generation.
Is there anything that I'm doing wrong here while using the npm link command?

I'd highly appreciate it if you could help me with this, whenever you're free. 😊
/cc @craicoverflow @wtrocki @machi1990

Hey @craicoverflow!
I've now got an idea of how plugins work in Graphback by going through the relevant docs.
But there's this one thing that I need help with.
Let's say I make some changes in the SchemaCRUDPlugin.ts file.
After that, I move to the packages/create-graphback directory where I run node dist/index.js Trial-Graphback-Project to initialize a server named Trial-Graphback-Project using any one of the Graphback's existing templates.
Then I move into the generated graphback server's directory (ie. Trial-Graphback-Project) where I find the .graphqlrc.yml file, which is configured to use the Schema CRUD Plugin in order to generate the schema.
Now whenever I run the yarn generate command here, I would want the updated local version of my SchemaCRUDPlugin.ts file to be used for schema generation.
But we know that won't happen, as @graphback/codegen-schema package present in node_modules is the one which was installed at the start (using yarn install) and not the local one present in packages/graphback-codegen-schema/, so it does not contain the changes which I had made locally.
So I looked this up on the internet and found a solution which uses the npm link command.
I then followed the following steps to link the generated graphback server to the updated local version of the @graphback/codegen-schema package:

cd packages/graphback-codegen-schema/  ->  npm link
cd packages/create-graphback/Trial-Graphback-Project/  ->  npm link @graphback/codegen-schema

But no luck even after following the above steps. Still the locally updated SchemaCRUDPlugin.ts file is not being used for schema generation.
Is there anything that I'm doing wrong here while using the npm link command?

I'd highly appreciate it if you could help me with this, whenever you're free. 😊
/cc @wtrocki

Hey @craicoverflow!
I've now got an idea of how plugins work in Graphback by going through the relevant docs.
But there's this one thing that I need help with.
Let's say I make some changes in the SchemaCRUDPlugin.ts file.
After that, I move to the packages/create-graphback directory where I run node dist/index.js Trial-Graphback-Project to initialize a server named Trial-Graphback-Project using any one of the Graphback's existing templates.
Then I move into the generated graphback server's directory (ie. Trial-Graphback-Project) where I find the .graphqlrc.yml file, which is configured to use the Schema CRUD Plugin in order to generate the schema.
Now whenever I run the yarn generate command here, I would want the updated local version of my SchemaCRUDPlugin.ts file to be used for schema generation.
But we know that won't happen, as @graphback/codegen-schema package present in node_modules is the one which was installed at the start (using yarn install) and not the local one present in packages/graphback-codegen-schema/, so it does not contain the changes which I had made locally.
So I looked this up on the internet and found a solution which uses the npm link command.
I then followed the following steps to link the generated graphback server to the updated local version of the @graphback/codegen-schema package:

cd packages/graphback-codegen-schema/  ->  npm link
cd packages/create-graphback/Trial-Graphback-Project/  ->  npm link @graphback/codegen-schema

But no luck even after following the above steps. Still the locally updated SchemaCRUDPlugin.ts file is not being used for schema generation.
Is there anything that I'm doing wrong here while using the npm link command?

I'd highly appreciate it if you could help me with this, whenever you're free. Thanks in advance!😊
/cc @wtrocki @craicoverflow @machi1990

We use yarn workspaces. If you install project using yarn you will be able to see the changes.

We use yarn workspaces. If you install project using yarn you will be able to see the changes.

@wtrocki
Yes, I have been doing the same ie. I installed the project using yarn and used yarn link.
Sorry I wrote npm link instead of yarn link everywhere in my previous comment by mistake (edited that comment now), but yarn workspace is what I'm using too.
I'm not sure what's causing this issue.


fromJson should return not nullable

Since Gson.fromJson return null only if string is null, it can return not a nullable type.

Unfortuately, that's not true as Gson().fromJson<Whatever>("null") == null.
So fromJson does returns null when given the String "null".

I think it should be based on null ability of the generic parameter

What do you mean ?

In my code, I use ``!!immediately after everyfromJson. If I would like it to be nullable, I would use Whatever?`.

I see your point.

v1.7.0 corrects this

Needs simple sample of using Kotson.
This does not work
`import com.github.salomonbrys.kotson.*
import com.google.gson.*
fun main (args: Array ) {
val obj:JsonObject = jsonObject(
"name" to "kotson",
"files" to 4
)
println(" ${obj}")
class Person(public val obj: JsonObject) {
val name: String by obj.byString("name") // Maps to obj["fullName"]
val files: Int by obj.byInt("files")   // Maps to obj["dates"][0]
}
val person=Gson().fromJson(obj,Person ::class.java)
}`


Document the process for releasing a new sidecar

/release-note-none
/assign @jsafrane @xing-yang @pohly

lgtm
@pohly, what do you think?

lgtm

/lgtm


Shepherd Documentation

Lots of Shepherd's current documentation within GitHub is currently difficult to read or completely out of date (like the sensors docs). A new and more comprehensive rewrite is needed to better onboard new members to the project. The medium (GitHub, Notion, Just the Docs, etc.) is yet to be decided. Additionally, information about Shepherd is spread in several places including the onboarding repo, so this information needs to be streamlined.

(


null vs 0

let x = 0
let y = 0
x = null
control.assert(x == y, "s1")

This program passes on the device and fails in the simulator.
@tballmsft @pelikhan : I think it should succeed on both. Comments?

agreed. null == 0


add input from text

Hi, can you add input from text file contains urls js

Hi, i'm adding to my todo list


gatk4 mutect2 produces unexpected SNV calls

I have tumor/normal paired-read targeted sequencing data.
Using bcbio gatk <IP_ADDRESS> and mutect2, I get 3749 calls in the output vcf file.
Using the "ready.bam" produced by bcbio/bwa, I tried running gatk4/mutect2 without bcbio and the vcf produced has only 121 calls, which seems more reasonable.
41 of the calls are found in both results. What could be causing this discrepancy?
bcbio config snippet:
- analysis: variant2
  genome_build: hg19
  metadata:
     batch: xx2
     phenotype: normal
  description: Normal.AGTTCC
  files: [R1.fastq.gz, R2.fastq.gz]
  algorithm:
    aligner: bwa
    mark_duplicates: true
    recalibrate: true
    platform: illumina
    tools_off: [gemini]
    tools_on: gatk4
    variantcaller: mutect2
    variant_regions: Baits.bed

and the gatk4 command:
/gatk-<IP_ADDRESS>/gatk --java-options "-Xmx2g" Mutect2 \
-R hg19.fa \
-I tumor.bam \
-I normal.bam \
-tumor tt \
-normal nn \
-L Baits.bed \
-O ttnn.vcf.gz

Also wondering if "realign: true" is recommended for gatk4 pipelines. Thanks.

Hi Brad,
Thanks as always for the thorough response.
Just want to clarify a couple things:

You are writing "MuTect2" whereas the gatk4 caller is "Mutect2" (note the lowercase "t"). I want to make sure you that we are both referring to the GATK "Mutect2".
See: https://gatkforums.broadinstitute.org/gatk/discussion/10911/differences-between-gatk3-mutect2-and-gatk4-mutect2

You're right, I was looking to filter by "PASS" but actually I needed to look for "." in the FILTER column instead. Now the number of PASS calls is down to ~1000 (w bcbio + gatk-<IP_ADDRESS>) and 121 (gatk-<IP_ADDRESS>). The bcbio results and depths look better so I think I need to modify the way I'm running GATK4 w/o bcbio.

Anyway, I'll consider this resolved for now. Thanks again.

Thanks much for this. Apologies, I do mean Mutect2 in GATK4. I need to undo the part of my brain that automatically capitalizes the T in the middle. Glad the filter differences make sense and please let us know if there is anything that can use tweaking on the bcbio side as you test more.