return RewriteResult for rewrite_path & rewrite_struct_***

Tracked by https://github.com/rust-lang/rustfmt/issues/6206
Description
Modify following functions to return RewriteResult

rewrite_path and its caller (rewrite_struct_lit / pat)
method rewrite_aligned_item of AlignedItem trait

Impl rewrite_result for PreciseCapturingArg, AssocItemConstraint, PolyTraitRef, TraitRef in types.rs
(These are the nodes that were waiting for certain rewrite_*** to return RewriteResult. see #6220)
Side notes

rewrite_prefix, another method of the AlignedItem trait remains Option<String> since it is used for the possible range of width for struct prefix (see struct_field_prefix_max_min_width)
Additionally, there are some messy unknown_error() calls since I haven't modified write_list, itemize_list, and similar functions. There's ongoing concern about modifying these functions and the iterator implementation for ListItems.

Thanks for another PR. This one is next on my todo list

Running the Diff-Check Job now

Just noting that this broader change (not specifically this PR, but the overall mission of #6206, has a higher chance of causing merge conflicts on the subtree syncs so if possible it would be good to try to get some more frequent syncs through

@calebcartwright Thanks for pointing that out. I'll try to follow your advice :)

@calebcartwright Thanks for pointing that out. I'll try to follow your advice :)

nothing for you to worry about @ding-young, it was mostly a note to myself & Yacin to try to get these in more frequently

@calebcartwright good call out. I don't think there's been many changes in r-l/rust recently, but I can certainly look to get subtree-push PRs out weekly or bi-weekly to keep up with the changes here.


fix: delete de.json after npm run clean

The file app/translations/de.json wasn't deleted after running npm run clean
See #1050

Coverage remained the same at 98.953% when pulling 9dd0b73f84c15bfc9fc4d71f0063af77b0829b3e on rubenmoya:master into 8693af3708e31f25fc0883256da605b3ccc03c9a on mxstbr:master.

Coverage remained the same at 98.953% when pulling 1015b22be8472d263831152a3938f51e7f955cb9 on rubenmoya:master into 8693af3708e31f25fc0883256da605b3ccc03c9a on mxstbr:master.

Thanks @rubenmoya!


Removed unused function and credential includes in iot_pkcs11_mbedtls.c

Description
iot_pkcs11_mbedtls.c has a function xIsObjectWithNoNvmStorage which is currently not used anywhere in the code. It's purpose is to check whether a PKCS #11 object was stored in NVM or in a header file.
It is desirearable to remove this function because

It is unused / dead code.
We can remove aws_clientcredential.h, aws_clientcredential_keys.h, iot_default_root_certificates.h from our dependencies.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you please:
* Remove the same symbol from the Infineon port.

* Fix spelling in your PR title.

* Add an informative description to your PR.

I have completed these changes


Add Service Button is Unclear

When filling out shipping options, the add service button, I found myself clicking the "Add Service" button to try to save a shipping option.
It's a common pattern to fill out a set of fields and then click a button to add them to the parent data, and the service section isn't separated from the rest of the shipping option, which gives the impression that the Add Service button acts on the entire shipping option.
The Add Shipping Option button is similarly unclear, it's not obvious if you need to click it to add the data you've already filled in, or to create a new option. If you have the modal scrolled so the Add button is at the bottom of the modal, the new set of fields added when you click on it may not be visible, so you think it didn't "add" the data above it, and you click it multiple times.
The confusion is increased by the delete button affecting the Shipping Option above it. That implies the Add Shipping Option button also affects the option above it.
Suggestions:

Make it more clear services are a sub-section of the shipping option, and may have multiple services.
Make it more clear the Add Service button belongs to the services sub-section.
Make what the Add Shipping Option button will do more obvious.
Visually separate the Add Shipping Option button so it's clear it doesn't belong to the Shipping Option above it.
Move the delete button next to the heading for the Shipping Option ("Shipping Option X") or somewhere similar so it's more clear which option the delete button is associated with.
Consider changing the interaction so there is only one actively edited Shipping Option and Service at a time. When a new one is added, the old one would switch from input fields to regular text. Clicking on it would switch it back to active (this might be doable by just a visual change, so the inputs are still inputs, but styled as if they were static text).

Ok so there are a few things that I think we can do to help this experience out in the short term.

The modal design/layout needs to be updated to match the latest designs. The new design does a much better job of separating the major sections. It will also separate each shipping option better.

We can change the Add Service button to a link to prevent accidental clicks. This is the approach Wix takes too.

We can also move the Add Shipping Option button to the next Add Shipping Option X container. When Add Shipping Option is clicked, the form fields display (similar to how Add Return Policy section works).

I agree on the placement of the delete shipping option button too. We can move it next to the Shipping Option X title. Make sure there is a delete confirmation on click too.

Those look good.


Add NULL as a first class citizen of the Unity Container

Description
Current implementation does not recognize NULL as valid object.
Problem
A lot of times NULL is a valid value for the dependency created by a Factory or registered as an instance.
Solution
Add NULL as a first class citizen to Unity system.
Impact
Existing code should not be impacted.

When migrating from 3.3 to <IP_ADDRESS> this did have a compatibility impact. A custom LifetimeManager of mine returned null when no value was stored yet. This caused Unity to create a value and store it. Subsequent gets returned that value. Now the initial return null; causes null to be stored.
The code looked like this:
    public override object GetValue(ILifetimeContainer container = null)
    {
        return someDictionary.TryGetValue(key) ?? LifetimeManager.NoValue;
    }

Without the ?? LifetimeManager.NoValue which is the fix.
I believe types deriving from SynchronizedLifetimeManager are not affected because there is special handling for null and NoValue there. My type derived directly from LifetimeManager.
I have fixed this by using the new NoValue. Notifying you of this because this might break other users.

Yes, it is a breaking change and should be dealt with by lifetime manager designers.
This issue documents the change so you could act accordingly.


If a debug-button is clicked while the debug pane is open, it is just closed

Currently, switching the tab toggles the tab, but I think being able to close the tab by selecting it is of limited functionality.

Fixed in #176


Explore No-Credentials "Authentication"

NOTE: This needs to wait until after the Code Freeze #181 , but going ahead and filing this so we're tracking.

This was an accident, 197 is the correctly filed issue.


[SPARK-46592][DOCKER][TEST] OracleIntegrationSuite is flaky because of ORA-04021

What changes were proposed in this pull request?

This PR mounts docker-entrypoint-initdb.d to OracleDocker to set DDL_LOCK_TIMEOUT and retry alter user system to ensure the password of SYSTEM user is correctly set.
Why are the changes needed?

https://github.com/apache/spark/actions/runs/7405337059/job/20148144542
https://github.com/apache/spark/actions/runs/7403889993/job/20144539155
https://github.com/apache/spark/actions/runs/7401841987/job/20138483574
Fix test flakiness caused by ORA-04021
22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: CONTAINER: Resetting SYS and SYSTEM passwords.
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT:
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: User altered.
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT:
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: ALTER USER SYSTEM IDENTIFIED BY "Th1s1sThe0racle#Pass"
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: *
24/01/04 04:22:09.284 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: ERROR at line 1:
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: ORA-65048: error encountered when processing the current DDL statement in
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: pluggable database FREEPDB1
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: ORA-04021: timeout occurred while waiting to lock object
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT: Help: https://docs.oracle.com/error-help/db/ora-65048/
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT:
24/01/04 04:22:09.285 docker-java-stream-568158377 INFO OracleIntegrationSuite: STDOUT:

Does this PR introduce any user-facing change?

no
How was this patch tested?

OracleIntegrationSuite
Was this patch authored or co-authored using generative AI tooling?

no

+1, LGTM. Merging to master.
Thank you, @yaooqinn.

Thank you @MaxGekk @dongjoon-hyun @LuciferYang


Use debug builds for dev work

This should make setting up the dev environment much faster.
If we need more performance for crypto operations, we should use:
https://doc.rust-lang.org/cargo/reference/profiles.html#overrides
to optimize only the most important crypto crates.

Codecov Report
Base: 58.99% // Head: 58.99% // No change to project coverage :thumbsup:

Coverage data is based on head (e1c7069) compared to base (da0dc1e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   58.99%   58.99%
=======================================
  Files         100      100
  Lines       16019    16019
=======================================
  Hits         9451     9451
  Misses       6568     6568

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Build times are ~40% better than release:

While test times seem unaffected:


Batch-mode: Retrieve multiple CDS-cards from one CDS-Service

Technical scenario: I would like one client to retrieve a lot of potential CDS-cards from one CDS-service in a performant way (one request-one response)
Scenario: I would like to retrieve the status for all inbound-patients of a ward - or for the whole hospital to enable visualizing overviews.
Issue: A CDS-Card does not provide context information

While it is possible to provide an own hook like this to enable requesting multiple contexts
“context”: {
{ “patientId”: “1”, “encounterId”: “abc” },
{ “patientId”: “2”, “encounterId”: “def” },
//       ... more....
}

A response for such a request would have multiple CDS-Cards - missing context info - or a way to retrieve it

I talked with @jmehlbrech offline about this and to provide more color to this issue, I recall having discussions around this topic previously; though, I cannot find any existing issues around this. The gist of this issue is that cards have no reference to a resource/entity/thing back in the EHR.
For instance, imagine a patient-list-view hook that for its context, informs the CDS Service of each patientId for the patients the user is viewing (see @jmehlbrech's context noted above). The resultant CDS cards have no reference to those individual patients in the list. So, the EHR has no ability to associate an icon/card/etc to individual patients within the list.
Another example would be on some imagined medication-list-view hook where the hook is invoked when the user is viewing all of the medications the patient is taking. The EHR again has no ability to associate the resultant CDS cards with individual medications.


Invalid Data with queries.

I for the life of me cannot figure out why this config does not work:
        xWEFSubscription "WEFSubscription" {
            SubscriptionID = "AppLocker"
            SubscriptionType ="SourceInitiated"
            Enabled = $true
            Ensure = "Present"
            Description = "Collects forwarded AppLocker events."
            HeartBeatInterval = 900000
            MaxLatencyTime = 900000
            Query = @(
                'Microsoft-Windows-AppLocker/EXE and DLL:*[System[(Level=2)]]',
                'Microsoft-Windows-AppLocker/MSI and Script:*[System[(Level=2)]]',
                'Microsoft-Windows-AppLocker/Packaged app-Deployment:*[System[(Level=2)]]',
                'Microsoft-Windows-AppLocker/Packaged app-Execution:*[System[(Level=2)]]'
            )
        }

here is the output:
VERBOSE: [WIN2016-DSC]: LCM:  [ Start  Resource ]  [[xWEFSubscription]WEFSubscription]
VERBOSE: [WIN2016-DSC]: LCM:  [ Start  Test     ]  [[xWEFSubscription]WEFSubscription]
VERBOSE: [WIN2016-DSC]: LCM:  [ End    Test     ]  [[xWEFSubscription]WEFSubscription]  in 0.1400 seconds.
VERBOSE: [WIN2016-DSC]: LCM:  [ Start  Set      ]  [[xWEFSubscription]WEFSubscription]
VERBOSE: [WIN2016-DSC]:                            [[xWEFSubscription]WEFSubscription] SubscriptionID: AppLocker
Failed to save subscription. Error = 0xd.
    + CategoryInfo          : NotSpecified: (Failed to save ...n. Error = 0xd.:) [], CimException
    + FullyQualifiedErrorId : NativeCommandError
    + PSComputerName        : win2016-dsc

The data is invalid.
VERBOSE: [WIN2016-DSC]: LCM:  [ End    Set      ]  [[xWEFSubscription]WEFSubscription]  in 0.3530 seconds.
The PowerShell DSC resource '[xWEFSubscription]WEFSubscription' with SourceInfo '::18::9::xWEFSubscription' threw one or more non-terminating errors while running the Set-TargetResource functionality. These errors are logged
to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
    + CategoryInfo          : InvalidOperation: (:) [], CimException
    + FullyQualifiedErrorId : NonTerminatingErrorFromProvider
    + PSComputerName        : win2016-dsc

I'm really not sure what the problem is.  the ETW channel just says the same errors.  I have tried removing the Microsoft-Windows-AppLocker from the path.  I have tried wildcarding the log Microsoft-WIndows-AppLocker*:*...  I have tried replacing the / with %4 as what the log is actually named in the file system.
I am using WMF 5.1 on server 2016 core, x64.
And just to add, I built this from an existing subscriptions XML, so the queries do work when imported in with wecutil.

Turns out this was due to the XML being generated with the tags <CredentialsType> with is not correct.  As soon as I change the xml tag to <CredentialType> it corrects the issue.  I have submitted the correction is Pull Request #10.


Non UTF-8 chars are removed from path

First of all, using non UTF8 characters in paths is bad practice, however, I'm in a position where I cant change the paths since they are determined by my University. With that said...
Having a non UTF8 characters in the path won't work when pressing the "Run current matlab file" in vscode. However, running current cell works fine.
Pressing run file yields:
run('/Users/max/Library/CloudStorage/OneDrive-Linkpingsuniversitet/Sensor_Fusion_TSRT14/Lab2/test.m')
Error using run
/Users/max/Library/CloudStorage/OneDrive-Linkpingsuniversitet/Sensor_Fusion_TSRT14/Lab2/test.m not found.

The "ö" in the path has disappeared on closer inspection, real path is equal to
/Users/max/Library/CloudStorage/OneDrive-Linköpingsuniversitet/Sensor_Fusion_TSRT14/Lab2/test.m

What is the version of MATLAB and Python you are currently using?
I have tested running a .m file with a path containing non-UTF8 characters, and have found that everything worked fine with MATLAB 2023a and Python 3.9.

Sure thing! I conducted two more tests with different settings and got one of them to work.
The above test was done with the settings

Matlab pybackend: No
MacOS Ventura 13.3.1(1),
Matlab R2022b ARM Beta version
Python 3.10.9

Second test displaying the same issue on Linux (I have sneeked in a Ö after Sensor Fusion Folder)

Matlab pybackend: No
Ubuntu 23.04
Matlab R2023a x64
Python 3.10.9

(base) max@ubuntu:TSRT14-Lab2 $ /usr/local/bin/matlab -nodesktop -nosplash

                                                        < M A T L A B (R) >
                                              Copyright 1984-2023 The MathWorks, Inc.
                                         R2023a Update 1 (<IP_ADDRESS>9454) 64-bit (glnxa64)
                                                           March 30, 2023

Warning: X does not support locale en_US.UTF-8

To get started, type doc.
For product information, visit www.mathworks.com.

f>> printf('Working directory: %s\n', pwd);
Working directory: /home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor FusionÖ/TSRT14-Lab2
>> run('/home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor Fusion/TSRT14-Lab2/test.m')
Error using run
/home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor Fusion/TSRT14-Lab2/test.m not found.
>>

Doing a test with Ubuntu and pybackend enabled (wiith a "ö" in path after "Sensor Fusion")

Matlab pybackend: Yes
Other settings same as previous

python /home/max/.vscode/extensions/shinyypig.matlab-in-vscode-0.3.2/pybackend/matlab_engine.py --cmd="""fprintf('Working directory: %s\n', pwd);"""
(base) max@ubuntu:TSRT14-Lab2 $ python /home/max/.vscode/extensions/shinyypig.matlab-in-vscode-0.3.2/pybackend/matlab_engine.py --cmd="""fprintf('Working directory: %s\n', pwd);"""
---------------------------------------------------------
MATLAB Engine for Python is ready (terminate with 'quit')
---------------------------------------------------------
Working directory: /home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor Fusion/TSRT14-Lab2
>>> run('/home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor FusionÖ/TSRT14-Lab2/test.m')
z =
    10
>>>

success!
However, an interesting note on how the "Working directory" print doesn't include the Ö while the run path does!

It seems to be a issue with matlab.
(base) max@ubuntu:TSRT14-Lab2 $ /usr/local/bin/matlab -nodesktop -nosplash

                                                        < M A T L A B (R) >
                                              Copyright 1984-2023 The MathWorks, Inc.
                                         R2023a Update 1 (<IP_ADDRESS>9454) 64-bit (glnxa64)
                                                           March 30, 2023

Warning: X does not support locale en_US.UTF-8

Can files with non-UTF-8 characters in their paths be run directly from the Matlab command line?

Yeah, the command
run('/home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor FusionÖ/TSRT14-Lab2/test.m')

with the Ö works fine from within the matlab command prompt.
Correct me if im'm wrong. butt since the extension is "building" the run command (without the ö) it should be the extension having problem with the char? As we can see from test 2: The run command is wrongly built, which gets generated from pressing the "run" button from within vscode.
>>> run('/home/max/Nextcloud/Utbildning/Universitet/4_e aret/TSRT14 - Sensor Fusion/TSRT14-Lab2/test.m')

However, I agree that the error message regarding locale support is weird, however Mathworks says it should have no functionality changes https://www.mathworks.com/matlabcentral/answers/1925710-warning-x-does-not-support-locale-en_us-utf-8


Urgent - all PRs blocked because of failing tests

Tests run fine locally but fail on the build server. This is blocking my 2 prs and seeminly every other PR on the repo.
@ATheorell  i feel like its to do with caching and API keys - would you be able to give us a quick fix?
Also @similato87 were you looking at removing the catching? do you know anything about why these are failing?

@TheoMcCabe caching is removed.
There is one test that uses an openai key and did so successfully on github for a while, though
stopped working recently. My suggestion is that we remove this test for now, until we have a working key. However, this means that we have to test manually that gpte runs locally before merging.

handled with hotfix in #1123

Thanks for sorting @ATheorell . hero

No problem! I see this as a temporary fix though. We can keep the issue open for now


Use of prefixed internal attribute names

Let's say my server returns the following object:
{ id: 1, name: "name", route: "ABC" }
Restangular then adds its own methods and properties to the object. "route" is used by Restangular, so it shadows my route property. Even if I called Restangular.stripRestangular(response), it would remove "route" from the object.
It would be better if Restangular used some prefix internally to avoid name clashes.

Issue closed, but I think the original request should be integrated in the Restangular framework.
Working with a prefix helps a lot, I'am working in a project right now with a name conflict with Restangular...


https://github.market : Buy Github Stars, Forks & more over at https://github.market

Boost visibility and ranking of your Github Profile and Repositories with our products over at https://github.market
We sell:

Github Stars
Github Forks
Github Followers
Github Watchers
Github Reactions
Github Upvotes
Github Comments
A Github Botting Tool

Our high-quality products come with substantial bulk discounts, ensuring both excellence and cost-effectiveness.
Buy now over at https://github.market

Благодарю за письмо.Иван


came across this issue,anyone give some hints?

cmd/src/github.com/concourse/baggageclaim/volume/docker_image_strategy.go:40: cannot use strategy.Repository (type string) as type reference.Named in argument to client.NewRepository:
	string does not implement reference.Named (missing Name method)

Looks like the Docker dependency has changed their API. Make sure you're working in baggageclaim inside the [concourse/concourse][https://github.com/concourse/concourse] repository to guarantee the correct dependency versions.

@xoebus thanks for your hints.


Chaining Jobs?

I just can't find a definitive answer to this: Is it possible to chain jobs? As far as I can tell, I cannot. As I see it, each job is completely independent and thus there is a huge amount of duplication going on.

gitlab 7.12 will support .gitlab-ci.yml config, maybe there something like that would be possible

Can you provide an example?
Currently, to my knowledge, Gitlab-CI supports regular jobs and "deploy" jobs. Regular jobs are all ran in parallel. If they succeed the "deploy" job is ran. To my understanding you can only have one "deploy" job but as many parallel "regular" jobs as you want. Please correct me if I'm wrong though.

A basic example; I compile come code and run some unit tests. If I want to deploy, now I need to compile again. That is redundant work.
In TeamCity, for example, it allows you to have multiple jobs. Any of which might require another job as a dependency. In addition, the artifacts of the first job (as well as environment variables) can be copied and moved to the dependent job... finally, that second job can be on another runner all together.

Artifacts aren't supported unfortunately.
You're free to have your job push an artifact/environments to some store and have your deploy job pull them down.

This feature I would consider essential to any practical use.  Very typically we build a set of libraries, which are independently installable and deployed, and a set of applications which also happen to consume those libraries.  Some of those libraries are dependant on others.  Hence, one build needs to be able to then trigger another, with the artifacts/results of the first library build also passed on so we can test any changes down the entire build tree.  I kinda know how to do this in Jenkins, and actually it is much easier in Jenkins just having a bunch of the different builds run on the same machine by having the end part of each build script also run a (local) make install target as well as trigger the next build, rather than by artifact copying.  But with self-contained single job disposable containers, like travis ci and gitlab ci seem to prefer, this methodology seems unavailable, and no alternate solution seems immediately obvious either.

:+1:


[Table] In-line editing of Data Table

Description
Extend the IoT Data Table to allow for editing of lines row-by-row
Name of Pattern or Asset
Data Table
User outcome
Use can edit the data of visible columns using appropriate component, and save multiple row edits at once
Proposal
https://jsw.ibm.com/browse/GRAPHITE-3571

Additional context
https://jsw.ibm.com/browse/GRAPHITE-3571

Add an icon to toggle in-line edit mode on in the top-right of the data table
Replace other content in the table header with Save and Cancel buttons at top when edit mode is on
Programmatically display the correct component for editing the fields shown, depending on the data source. Date fields are displayed with date picker, numeric with numeric spinner, alphanumeric with text entry, etc.

Issue to add Date picker and Numeric spinner to design library: https://github.ibm.com/Watson-IoT/pal-tracking/issues/6

Components should display with proper padding and alignment within the width of the row/column
Fields should be validated on entry, before save (Install date cannot be in the future, End of Life cannot be in the past, Expected life must be greater than or equal to 1, etc)

Issue for error state: https://github.ibm.com/Watson-IoT/pal-tracking/issues/32

Display toast with undo option https://ibm.invisionapp.com/d/main#/console/15350624/319220019/preview (Use light version of toast. Dark version does not match PAL update)

PAL tracking issue: https://github.ibm.com/Watson-IoT/pal-tracking/issues/20
Assigned dev: https://github.ibm.com/lijianig
waiting on dev to communicate their public github username

The spec shows this:

But we already have a delete/cancel design for multiple rows which is this one:

Would it not make sense to use the same design and code for the row editing (but with save/cancel buttons instead)?

@lukefirth I agree this sounds ideal. What are your thoughts?

@JordanWSmith15 @KarenGski was this option explored at all? what are your thoughts?

I have no preference from a design perspective. We should not show the "X items selected" string if we go with the blue bar.

I'm fine using the same mechanism for both multi-select and inline edit.
As Jordan said, the items selected isn't relevant because you aren't doing bulk actions....  unless there IS a use case to allow the user to perform batch inline edits.  We don't currently have it, but I could imagine a user wanting to select a few things and then change all the values at once.  Maybe a future enhancement.

I think the challenge/difference here is that the bulk edit of the data table is wholesale (it's for every single row) whereas the bulk action bar only deals with performing actions on the currently selected (denoted by the checkboxes) rows, as stated above.
In other words, I believe we'd run into conflicts with a user editing many rows, and then having the action bar/checkboxes have an uncertain relationship.
We could make this work, by removing the checkboxes and the X' items selected' when in an edit mode, making it seem like 'all rows' are selected implicitly when in bulk edit mode - which would allow us to use the action bar styling, but that does sound A: A bit more complicated than I'd like (hacking both the main table and the action bar a bit), and B: Reliant on users understanding the implict 'this action bar is referring to any changes I made anywhere in the cells) in order to work. 🤔 hmmm.

@lukefirth I hear what you are saying and it makes sense. FWIW, in my personal perspective I view the bulk action bar to just be about bulk actions and not explicitly tied to checkboxes. It feels like two separate things. One is a mechanism for selecting what fields you want to to have action applied to (checkboxes/ edit button) and then the action bar which is just the action you are going to apply to whatever is selected. It does seem weird to have two different ways to apply bulk action. Totally understand that others may not draw those same conclusions.

Thanks everyone for pitching in. To clarify my proposal, there would be no checkboxes and no "X items selected" in the case of row editing. David described the separation of concerns well above. It could look like this:

I do get what you're saying (so thats good, we at least all understand each others perspectives ha).
I do like the primacy that the bar gives to the save/action - it makes it very clear the table is in a temporary state and an action 'there' is needed to release it back to its regular state. This is nice and appropriate.
However, I do still reach a kind of discomfort in using the action bar styling for this. Which I'll try to ellucidate:

In the grand scheme of patterns outside of the data table, this may be considered a very special kind of 'form', kind of in the same way that the dashboard editor can be seen as one too. In all cases where there is a save/cancel pair, we both have a hard pattern of 'save on the right, cancel on the left' and a styling choice of primary for save, secondary for cancel as a button pair. Using this action bar styling while matching other 'bulk actions' in the table. Long way of saying - this may make it partially more inline with other things in the sphere of the table, but would break it further from any other cancel/save patterns in our applications.

Normally, the actions in the bar are always initiating something (or the 'null' action of dismissing the action bar) - and so can adopt a primary styling. However, this state is no longer showing a pallette of initiate-able actions but a 'positive' and a 'negative' action (to cancel). Which makes it a little different in that it reuses the 'cancel' of the action bar in a slightly different way than it is regularly used. In 'normal' cases the action bars cancel action would be a null type action. "I started going to make a bulk action, but decided not to so I clicked the cancel and it just deselected things' - nothing is lost. However here the cancel is used for a negative action. Clicking it will likely be a destructive act - losing any changes you've already made. This one is a really finicky thing I know, so treat this point as a lesser one.

This introduces a second action bar (you could still in multiselect tables have checkboxes that will trigger the action bar) which I'm not sure is actually a good thing. They will look very similar, but intiated in different ways, have different content and behave in the different ways outlined above.

Really point 1 is my main concern from a UX perspective - making it more like regular bulk actions (when it is actually a seperate action bar), and departing it from the standard save/cancel button pair we use for any other kind of edit/create states.
However, I'd love to get a visual design expert eye on this too. @amymillett , would you mind pitching in?

Since the row actions can conflict with the edit mode (think deleting a row while a cell is edited) we should probably also disable the row actions. Also, the row actions as they currently are implemented could obscure cells on row hover, preventing the user from clicking/editing the cell content using the mouse.

Agree with Luke that the multi-select boxes would have to be disabled for this to make sense at at this point.
But again.. there could be a case in the future where you'd want to select more than one row and then click into a field on any of the rows and have the change for that field apply to all of them.  I've seen that in things like RTC before but not sure how much people need it.

So @lukefirth, what do I do?

Should I go with white the cancel/save bar like in the original proposal or with the blue bar?
Should I also completely disable the row actions like I suggest above?

Go with the original proposal.
The challenge there is that disabling them completely will also stop users being able to remove a row, which is a normal part of most editing cases. While I agree with your point, I do not think completely disabling will work for this reason, unless there is another mechanism a team can use to ensure a remove action would be able to be present in the row when changed to edit mode without it being a regular action.

@stuckless See the discussion about row actions above, are you ok with allowing them for now and have Luke define a better solution for them in a separate issue?

@lukefirth The default buttons are slightly wider and don't center the text, is that ok or should I modify that so that they look exactly like in the design spec?
Default buttons:

@bjornalm I'm ok with the row actions.  We can always disable them ourselves, or completely remove them, by hooking into the table's edit state.

@stuckless @lukefirth Do we need row editing in the TableCard as well?

@bjornalm

Button style: Apologies for this, we're still working out some design 'kinks'. Use the default style, but please switch the order to place the save on the right, cancel on the left (I thought I'd caught all instances of it the other way around...)

Row edit in table cards I have no tracked requirement for this at present from the teams, but it does seem like something that would be only a matter of time before one of our teams using table cards ask for it. My recommendation here is that if its easy to do now, do so, but if its any real work at all to make it work in table cards - then we should leave it and hit whatever our next priority is and return if/when it comes up as a priority.

:tada: This issue has been resolved in version 2.77.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


build mxnet with MKL installed on system

If I want to build mxnet with an existing MKL, I need to set
USE_INTEL_PATH=.....
and run make -j USE_BLAS=mkl
Do I still need to set USE_MKL2017 = 1?
Setting USE_MKL2017 seems always downloading MKL and use the downloaded MKLML to build mxnet, correct? Will it turn on different code in mxnet by setting USE_MKL2017=1?

YES. you should set USE_MKL2017 to 1 to use MKL set in INTEL_PATH.

@BiranLi But setting MKL2017=1 always downloads mklml libraries and used those to build mxnet instead of using the mkl installed.
Also is mklml a subset of MKL or a subset of MKL_DNN?

@patricianing Have you run the mklvars.sh script in current session?

@BiranLi where is mklvars.sh located? I only see prepare_mkl.sh in the master directory.

@patricianing Check the path where you installed mkl2017 such as "/opt/intel/mkl/bin/". Then exercute "source mklvars.sh intel64".

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


Can't use with JDK 1.7 throw java.lang.UnsupportedClassVersionError

Trying to use 3.0.1 library, downloaded from Maven repository at Websphere 8.5 in project which build with JDK 1.7 but it throws the following error:
java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=com/auth0/jwt/algorithms/Algorithm, offset=6
I've tried to recompile from source but it didn't help, maybe I've done something wrong because it's first time I using gradle.
Can somebody help me with this issue?

It's a duplicate of #115 and as stated we need to the value specified in the issue. Will try to address it this week,  PRs are welcomed.

I'd be happy to PR you but I don't know how? I've downloaded source code and compiled it locally without changing anything in build.gradle file and it just worked. I can upload your my *.jar file but doubt if it will help you.


Add feature that shows cron format as friendly string

As suggested by http://reddit.com/u/HereComeTheMinions
http://www.reddit.com/r/programming/comments/2ma95k/visual_opensource_cron_editor/cm2cxpa
Provide friendly text format explaining cron, such as:
*/20 * * 13,12,24 8,11 *
# Every twenty seconds on on the 12th, 13th and 24th, only in august and november.

+30 Internet Points

Come on, I support you

6½ years later...
like azza-bazoo.github.io/prettycron/


Scala 3

Update Scala versions.
Update sbt, sbt plugins, GitHub Actions.
Enable Scala 3 build.

What is the motivation for this PR? As the readme mentions, you probably should not use this library for anything except when talking to scalajs-linker and scalajs-js-envs. Those libraries are built for 2.12 and 2.13 only, by design of how the Scala.js repo is organized. If necessary, they can be used from Scala 3 using cross(CrossVersion.for3Use2_13).

@sjrd Mainly so we can move on to publishing scalajs-js-envs for Scala 3 if that is the plan, to get rid of the cross(CrossVersion.for3Use2_13) usages.

The situation is basically the same for scalajs-js-envs: what's the actual issue with for3Use2_13?
I guess if you want scalajs-js-envs on _3, you will also want scalajs-linker. But the latter is very unlikely to get built for _3 in the foreseeable future, due to how scala-js/scala-js is architected; it would create a circular dependency between scala-js/scala-js and lampepfl/dotty, which is not desirable.
From my point of view, it's much easier to keep using for3Use2_13 for this set of core libraries. None of them define any macro nor have they any dependency on any external library, so it's always safe to do so.


Slow page rendering with thousands of Tags present on objects

Environment

Nautobot version (Docker tag too if applicable): 1.6.0rc1, 2.0.0b2
Python version:
Database platform, version:
Middleware(s): django-debug-toolbar (optional)

Steps to Reproduce

Configure 2000+ Tags that apply to a particular model (or all models)
Create instances of that model such that each tag is used one or more times
Navigate to the list view for that model

nbshell example:
>>> for i in range(1, 2001):
...     t = Tag.objects.create(name=f"Tag {i}", slug=f"tag-{i}")
...     t.content_types.add(ContentType.objects.get_for_model(Prefix))
...
>>> for i in range(1, 2001):
...     p = Prefix.objects.create(prefix=f"2001:{i}::/64")
...     p.tags.add(Tag.objects.get(name=f"Tag {i}"))
...
>>>

Expected Behavior
Page to load relatively quickly regardless of the number of tags.

Observed Behavior
Page loads substantially slower due to the large number of tags.
Investigation suggests that this is due to server-side rendering of the list of all possible tags as part of TagFilterField. When django-debug-toolbar is enabled, it can be seen that thousands of copies of the selectwithdisabled_option.html template have been included in the page; DJDT's memory consumption can grow into the gigabytes as a result due to it caching the complete template rendering context for each such copy.
List view of Prefix with page size of 50 and no Tags applied:

Same list view with 2000 Tags in use:

Initial investigation suggests that changing TagFilterField to use DynamicModelMultipleChoiceField like most other filter fields, instead of statically rendering it at page load time, mitigates the issue.

As a mitigation for django-debug-toolbar, adding DEBUG_TOOLBAR_CONFIG = {... "SHOW_TEMPLATE_CONTEXT": False, ...} greatly reduces DJDT's memory consumption when rendering this page, making it possible to at least continue to use the toolbar for its other functionality.

Remove the tag object count, and make the filter queryset be all tags for the given content type.


Plot a graph that shows how much adding additional training data improves labeller accuracy.

It would be very useful to show the "learning curve" for our training efforts. So start with a subset of papers, train, see results. Add more papers and repeat. Keep adding and repeating and see the plot. Is accuracy improving ? How rapidly?

Done. https://github.com/nasa-petal/PeTaL-labeller/tree/main/auto-labeler/MATCH#effect-of-training-dataset-size-on-match-precision


Gas canister equipped sprites need to be a layer below backpacks

Description

I wanted to do so in #30809 but I couldn't figure out how. Ideally, it should be above eva/outer clothing/belt but below back slot.
Screenshots

This is what it should look like:

It also needs to be below the hair layer, as seen here.


Add support for authentication of polymorphic principals

This change adds support for polymorphic java.security.Principal classes for use with Dropwizard's authentication mechanism. See #1318 for background.
My company has been running these custom AuthValueFactoryProvider and AuthDynamicFeature classes in our API server for months without issue. As stated in the ticket, we have a need to issue multiple classes of API keys to different API consumers and this change has suited the job well.
Note that the new PolymorphicAuthDynamicFeature only supports authentication, as opposed to authorization. AuthDynamicFeature's short-circuit on RolesAllowed/DenyAll/PermitAll doesn't jive with per-Principal-subclass filtering, so I opted to limit the feature to authentication.

Thanks for the thorough review, @arteam. I've heeded your feedback and updated the diff.
In digging further into the dropwizard-auth tests, I decided to collapse AuthBaseResourceConfig into AbstractAuthResourceConfig. I don't think the usefulness of the two separate classes warrants the complexity imposed by a class hierarchy of DropwizardResourceConfig within a test package. So, this change now comprises two commits, the first of which does a bit of cleanup within the auth tests.
The meat of the change which adds support for polymorphic Principals now reflects your comments. PolymorphicAuthValueFactoryProvider and AuthValueFactoryProvider each extend AbstractValueFactoryProvider directly. The meat of their respective createValueFactory methods is offloaded to a package-private PrincipalContainerRequestValueFactory class. The rest of the two provider classes is basically boilerplate.
And I added a PolymorphicPrincipalEntityTest which wires the new pieces up and ensures that authentication by multiple Principal subclasses in a resource actually works.
I'm not sure how (or if it's even worth it) to test PrincipalContainerRequestValueFactory. Taking a look at Jersey's source, AbstractContainerRequestValueFactory itself isn't tested, so I couldn't find a precedent for mocking ContainerRequest injection functionality.
Still not a fan of the "PolymorphicFoo" naming convention, but I still can't come up with anything better.

Thanks, Evan. Your reasons about collapsing AuthBaseResourceConfig and introdcing PrincipalContainerRequestValueFactory seem sensible for me. I've added comments about minor details of the implementation, but overall this is ready to merge.
Also, could you be so kind to update the release notes for 1.0 version? This would make easier for users
to track this improvement.

Change should now be good to go. I took the liberty of adding myself to the contributors page, too. Hopefully not too gauche.
Thanks again for the thoughtful review, @arteam!

Thanks for contributing to Dropwizard!

Hopefully not too gauche.

Not at all. But we usually do this automatically with a [Ruby script|https://github.com/dropwizard/dropwizard/blob/master/docs/list_contributors.rb]. We run it time to time to actualize the list.

Don't know if this is the right place to say "thank you", but this contribution just saved me a lot of work! Thanks a lot @evnm @arteam =)


Use index.rst for main doc file in folders

Many of the main sections have their content in files with the name of the folder, e.g., http://docs.zephyrproject.org/api/api.html.  This prevents using shorter URLs such as http://docs.zephyrproject.org/api because the default action, in this case, is to retrieve a file named index.html.  Renaming, for example, api.rst to index.rst will fix this problem.

addressed by #12991


Make nominating a bit more controllable

This PR contains code split off from the rest of the work that's in progress for https://github.com/bpfkorea/agora/issues/1004
These changes look nice on their own and they can be merged before the rest of the work is submitted.

Fixed commit message.

Ok resolved comments and removed code which didn't belong here.

@linked0 can you approve / merge this? It will unblock the rest of my work.

Thank you!


list/append fails for Origin, IRIX 6.5

Reported by Ansley B Manke on 28 Oct 2002 22:50 UTC
Paul Kushner at GFDL, finds this on Origin systems, not linux.
Also Laurent Cherubin, U. Miami, on a IRIX 6.5, version 5.41 but not v5.22.
Kushner:
sp rm eg.txt
!list the number 1 to eg.txt
list/file="eg.txt" 1
!append the number 2 to eg.txt
list/file="eg.txt"/append 2
!cat the file
sp cat eg.txt
Cherubin, similar example writing variables to an ascii file.
let day = 22; let mxdepth=25
list/format=(2(1x,f9.2))/file=depth.dat/nohead day, mxdpth
let day = day + 1; let mxdepth=mxdepth+24
list/format=(2(1x,f9.2))/file=depth.dat/nohead day, mxdpth
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/471

Comment by<EMAIL_ADDRESS>on 29 Oct 2002 16:41 UTC
correct the script under Laurent Cherubin (he'd sent an incomplete example,
my errors previously):
let day = 22; let mxdepth=25
list/format=(2(1x,f9.2))/file=depth.dat/nohead day, mxdepth
let day = day + 1; let mxdepth=mxdepth+24
list/format=(2(1x,f9.2))/file=depth.dat/nohead day, mxdepth

Comment by<EMAIL_ADDRESS>on 31 Oct 2002 16:53 UTC
This is actually the same bug as bug #445 - which has been fixed.


Workspaces - workspace-api endpoint URL

The URL in the documentation must be changed from:

Workspace API: https://workspace-api-v2.${INGRESS_HOST}/

which sort of works but only outputs
{"detail":"Not Found"}
to:

Workspace API: https://workspace-api-v2.${INGRESS_HOST}/docs

which is the correct URL for FastAPI

Fixed with 698069cb457f1d21e0867c79331def2a50736e3f


Allow smoke tests to run during 'cf7 push APP-NAME --strategy rolling'

What's the user value of this feature request?
Currently all of our deployments to CF is done with halfpipe-cf-plugin
Essentially what happens under the hood is
$ cf halfpipe-push -manifestPath path/to/manifest-dev.yml -appPath path/to/app -testDomain dev.cf.com
# cf push my-app-CANDIDATE -f path/to/manifest-dev.yml -p path/to/app --no-route --no-start
# cf map-route my-app-CANDIDATE dev.cf.com -n my-app-dev-CANDIDATE
# cf start my-app-CANDIDATE

At this point we can run smoke tests agains my-app-dev-CANDIDATE.dev.cf.com before running the promote step.
$ cf halfpipe-promote -manifestPath path/to/manifest-dev.yml -testDomain dev.cf.com
# cf map-route my-app-CANDIDATE dev.cf.com -n my-app # from manifest
# cf map-route my-app-CANDIDATE dev.cf.com -n some-other-host --path nodejs # from manifest
...
# cf rename my-app my-app-OLD
# cf stop my-app-OLD
# cf rename my-app-CANDIDATE my-app

There is a couple of issues with this approach

Every time we deploy we get a new app guid, which makes it hard to create graphs for apps
If the memory for the app is 1G and we need 10 instances, at the point of deployment we require 20G of memory, 10 for the current app and 10 for the candidate app.
We need to maintain this, when the rolling strategy is 90% there.

Who is the functionality for?
Our developers that use CF.
How often will this functionality be used by the user?
Thousands of times a tay.
Describe the solution you'd like
It would be neat to be able to say
$ cf7 push APP-NAME --strategy rollingWithSmokeTests --testRoute blah.domain.com
$ TEST_ROUTE=blah.domain.com ./smokeTests && cf7 continue-deployment APP-NAME || cf7 cancel-deployment APP-NAME

Where continue-deployment would un-map the testRoute, bind the routes from the manifest and continue with the rolling strategy.

Thank you for your submission. If you still run into this issue with the latest CLI v8,  please open a new ticket.


Verilog HDL Module Instantiation error at hx8kdemo.v(65)

Hi there,
Currently I am trying to synthesize PICORV32 onto DE0 Nano FPGA using Quartus Prime Lite.
I have no problem synthesizing with synth_area_top.v it was successful.
However when it comes to hx8kdemo.v I get an error as shown below.

Verilog HDL Module Instantiation error at hx8kdemo.v(65): cannot elaborate array of instances because the declaration for the instantiated module has not been analyzed.
I am not sure if I missed adding any files into the project that caused so? Appreciate if anyone could provide me a guide in this case.

The "hx8k" refers to the Lattice iCE40HX-8k FPGA and the error you get is for the SB_IO module which is an IO primitive of that FPGA family. When targeting an Altera/Intel FPGA you would need to replace it with the corresponding vendor specific primitive.


Failure in populate machine file locally

TASK [ansible-role-pdsh-machines : populate machines file locally] *************
fatal: [install2]: FAILED! => {"failed": true, "msg": "'ansible.vars.hostvars.HostVars object' has no attribute u'groups.compute'"}

Possibly due to the recent ansible update from EPEL (see https://github.com/CSC-IT-Center-for-Science/fgci-ansible/issues/117 )

Should be fixed by @A1ve5 in a8eeee485e68c0afde437d105aeaeaf51a16cf7d - we'll update requirements.yml next week.

As far as I can see this has been fixed. Not seeing these errors when running pdsh-machines role on our install node.
Are you still seeing these errors @jabl ?

Seems to work now. Thanks!


Impossible to "cast interface" of Vyper contract

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (dea5405 2023-08-17T00:25:19.368594453Z)
What command(s) is the bug in?
cast interface 0x5f3b5DfEb7B28CDbD7FAba78963EE202a494e2A2
Operating System
Linux
Describe the bug
I'm trying to cast the interface of the veCRV vyper contract and it gives me an error
(0x5f3b5DfEb7B28CDbD7FAba78963EE202a494e2A2)

Right, this is because we currently do not have vyper support for cast interface—sorry!

@Evalir how does cast interface work under the hood? I'd have thought cast could grab the API via etherscan and generate a solidity interface for it, without vyper support

That would have been my thought as well
ABI should be the same format from Vyper and from Solidity


No Secrets From the Magaji

text: A Magaji with this card can block with +1 intercept even if not yet needed, the limitations of adding intercept doesn’t apply to continuous/always on effects which this is (similar to Sport Bike).
link: https://www.vekn.net/forum/rules-questions/76491-no-secrets-from-vlad-tepes?start=12#86152

It's rather clear from card text, I don't think it needs an addition. Complications lies in the interaction with Vlad Types ability, and rulings on Vlad Types are up to date.


Synchronize scrolling of template previews

Currently you can preview a Boa query with all templates substituted.  This opens the query in a new window (to the side by default).
It would be nice if the two windows synchronized their scrolling so you can scroll just one window and the other shows the similar part.  This is similar to how the diff view works.

This plugin has behavior we want and we can probably gain inspiration: https://github.com/dqisme/vscode-sync-scroll/tree/master/src


Only use browserify-shim when building dist files

Similar to https://github.com/brightcove/videojs-playlist/pull/44, this allows a user to import contrib-dash without setting video.js and dash.js to window first.

LGTM 😫


Remove default_app_config settings

These are only required in Django < 3.2, which we no longer support.

Ah yep - was only searching for the django.VERSION line, which those don't have. Will update...


Analyse Shape Constraint Outputs

[x] perform a grid search over the shape constraint trade-off parameter.
[x] compare shape measurement results using the parametric dataset.
[x] compare MSE results using the parametric and/or realistic dataset.

The optimal value of gamma is 2 after testing the values in [0.1 0.5 1 2 10] in this notebook.
However when measuring the ellipticity error, we notice that it decreases when the magnitude increase. The magnitude plot has the opposite behavior than the SNR plot. Which means that the ellipticity error behavior is counter intuitive.

Note : Adapative moments are measured using a window (see section 2.1 of Hirata & Seljak 2003) so this measure is biased and this could be the reason why its error behavior is not correlated with the ellipticity one.
Test to better understand the ellipticity error behavior:

[ ] replace the mean by the median in the plots to make sure that there is no outlier in the error distribution that is biasing the estimation.
[ ] check visually the galaxy images in each bin.
[ ] check if smaller galaxies are better reconstructed than larger galaxies. The training dataset has a bigger proportion of smaller galaxies. This could lead to the network learning to reconstruct small galaxies better than elongated galaxies.

By replacing the mean bu the median in the plots this notebook. The general trend remains the same which means that it is most likely not caused by outliers.

After checking the galaxy images per bin, two effects has been noticed that seem to explain the behavior of the ellipticity error curve.
The first effect is having elongated galaxies having reconstruction that are more punctual as seen in the example below. This is probably due to the prevalence of smaller galaxies in the dataset distribution.

The second effect is having smaller objects for lower magnitudes and also having observation that contain mostly noise. This seems to lead the network to guess a galaxy which would most likely have a punctual shape that corresponds to the target most of the time, like in the example below:

When the trade-off parameter of the shape constraint, γ, is set to 2. The reconstruction of elongated galaxies seem to be more successful in comparison to the absence of constraint, see example below:

And behavior of the ellipticity error for this value decreases when the magnitude increases which corresponds better to the expected behavior.

The unwindowed ellipticity measurement on the Unet reconstructions contain a considerable proportion of outliers which values are outside [-1, 1]. This is due to the residual noise in the reconstructions. Even though the intensity of the residual noise in the reconstruction is very low (see plot below), it is still enough to drastically deteriorate the unwindowed ellipticity measure.

This leads us to only consider the windowed shape measurement.
For further details, the problem was investigated in:
https://github.com/CosmoStat/ShapeDeconv/blob/master/notebooks/UNET_Evaluation/unet_window_investigation.ipynb


Hover Bug

When using the toolbar on the side of the client as I hover over each option it creates drop downs or something and makes it impossible to use. There is a screenshot linked

Re-download your launcher from the website.

Duplicate of #1449


optimize: Optimize the undo stack.

Description
timers   of Undo stack observers removed. Just use one timer in Undo stack.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test undo/redo actions

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

I've test this branch; I confirm that the lag probblem after moving group of Nodes was solved. :+1:

we still have multiple issues regarding performance for select all, doing undo and redo, movement improved but can be more


EXR calculation for PixelAspectRatio broken

The code, at least in OIIO 1.5.20, to do this is:
    float xdensity = spec.get_float_attribute ("XResolution", 0.0f);
    float ydensity = spec.get_float_attribute ("XResolution", 0.0f);
    if (! aspect && xdensity && ydensity) {
        // No aspect ratio. Compute it from density, if supplied.
        spec.attribute ("PixelAspectRatio", xdensity / ydensity);
    }

is ydensity really supposed to be using X and not Y resolution?  As coded, won't this always produce a ratio of 1 if aspect was not previously set?
I guess what happened is that YResolution is not specified by the EXR standard, so the author gave up and committed the following broken code?  If so, maybe it's better just to hard code the aspect ratio to 1.

I'm not sure there is a bug here.
Remember, this may be outputting to exr, but we don't know where the image has come from.
So the logic that this is using is: If the spec gives an aspect ratio, use it. Otherwise, compute it from x and y densities.
There's also logic in the exr reader to set YResolution (implicitly, based on the xresolution and aspect in the exr file being read).
So in general, this code should be confident that either aspect is set, or both xresolution & yresolution are set, or else it gives up and doesn't attempt to set a non-default aspect ratio.

How is the above code different from:
    float xdensity = spec.get_float_attribute ("XResolution", 0.0f);
    float ydensity = xdensity;
    if (! aspect && xdensity && ydensity) {
        // No aspect ratio. Compute it from density, if supplied.
        spec.attribute ("PixelAspectRatio", xdensity / ydensity);
    }

or even:
    float xdensity = spec.get_float_attribute ("XResolution", 0.0f);
    if (! aspect && xdensity) {
        // No aspect ratio.  Not only did I botch the code with a typo, but I completely misread (clearly did not carefully read) your post here.
So sorry. It's an obvious cut and paste error in the code. I'll submit a patch immediately.

Sometimes you have to just spell it out for me as plainly as possible. I think I would not have botched this one if you had just said:

float xdensity = spec.get_float_attribute ("XResolution", 0.0f);
float ydensity = spec.get_float_attribute ("XResolution", 0.0f);

The second line should retrieve "YResolution", shouldn't it? Probably a cut-and-paste error.

I'll try to read more and think more carefully about issues as they whiz through my inbox. :-)

I'm currently having issues with OIIO not using namespaces with OpenEXR on Windows. Anyone else?

@ZeroCrunch  Related to this ticket specifically?

No. Sorry, in general. My mistake.

It would be better to ask on the oiio-dev mail list, where it would be read by lots of people who have built OIIO on many platforms. These GitHub "issues" are only seen automatically by people who subscribe, which is a tiny slice of the community.
Also, it will help to describe precisely which versions of OIIO and OpenEXR are involved, and exactly what you mean by "issues," directly quoting commands and error messages where possible.

I think this has long since been fixed.


Unable to add Postgres table

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
master
Expected results
Database added successfully
Actual results
The addition fails with "module has no attribute merge_perm"
Steps to reproduce
getting to Sources -> Databases -> Add and filling the parameters (sqlalchemy/postgres)
The issue has been tracked down to bce02e3 and I'll submit a PM immediately.

If you submit a PR shortly no need to open an issue too, thanks.

Okay, thanks for the info. I won't next time :)

https://github.com/airbnb/superset/pull/1692


Parse from string

Table.load should accept CSV files as a string and parse them.This would help users with browser environments, as they wouldn't need to create a Stream to pass in some data.
To distinguish against the string input that is a local or remote file, we could either use a heuristic like string length, or a regex matching slashes or .csv, and we could try the options in order, or better yet, we could just add an option to enable parsing as CSV and keep the default behavior the same.
Thanks!

Please preserve this line to notify @roll (lead of this repository)

It might have been implemented in frictionless-js cc @risenW


Memory leak or poor memory performance.

$ grep "influxdb" /var/log/messages
Dec 11 18:30:32 crosstalk kernel: [18228436.798056] Out of memory: Kill process 7657 (influxdb) score 670 or sacrifice child
Dec 11 18:30:32 crosstalk kernel: [18228436.838105] Killed process 7657 (influxdb) total-vm:35068428kB, anon-rss:33083764kB, file-rss:880kB
Dec 12 02:34:17 crosstalk kernel: [18257484.632229] influxdb invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0
Dec 12 02:34:17 crosstalk kernel: [18257484.632234] influxdb cpuset=/ mems_allowed=0-1
Dec 12 02:34:17 crosstalk kernel: [18257484.632238] CPU: 9 PID: 2910 Comm: influxdb Not tainted 3.10.28-4 #1

top - 09:42:13 up 130 days,  5:07,  2 users,  load average: 4.39, 4.16, 5.04
Tasks: 245 total,   2 running, 243 sleeping,   0 stopped,   0 zombie
Cpu(s): 23.0%us,  1.9%sy,  0.0%ni, 73.9%id,  0.8%wa,  0.0%hi,  0.4%si,  0.0%st
Mem:  65898548k total,  5616964k used, 60281584k free,    48872k buffers
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                24
On-line CPU(s) list:   0-23
Thread(s) per core:    2
Core(s) per socket:    6
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 45
Stepping:              7
CPU MHz:               2000.040
BogoMIPS:              3999.97
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              15360K
NUMA node0 CPU(s):     0,2,4,6,8,10,12,14,16,18,20,22
NUMA node1 CPU(s):     1,3,5,7,9,11,13,15,17,19,21,23
Hi @toddboom , I met the similar situation today, one of the Influxdb servers crashed due to OOM.
Above is my hardware setup, and the server only runs Influxdb. I have approximately 120K points for both write and read per second. I have some queries like "select func(x) from x where time > now() - 5m group by time(1m)" and I will write the output of those queries back to Influxdb for further query. I do not use continuous query because continuous query often hangs in my production, this is another story. But the OOM killer is really a killer. Alternatively, is there any way to free memory from a running influxdb?

Same issue here. I just setup a PoC running on a VM. it was running fine for a few days with 4G of memory and it started to consume all the memory today even after I added additional 4G of RAM. No CQ as well. I'm using collectd input.
shard_db_v2]# du -sh * .
1.2G	00001
100K	00002
Not sure how to get the stat for the DB itself and the number of ttl points.

I'm getting this quite often on c3.xlarge instances, particularly when my boss tries to select a week's worth of data at 0.1s intervals. I'm trying to tune down max-open-shards and max-open-files, but I can't find much current documentation on the parameters. The example on the website show max-open-files configured at 40 and that seems unusually restrictive. Currently I have 10 max-open-shards and 1000 max-open-files with nofiles set to 65536, and I haven't crashed yet with these settings, but I'm afraid to let my boss use it again. When it crashed before, max-open-shards was set to 0 (unlimited).

This is likely fixed in 0.9.0 and we won't be making fix releases for the 0.8 line. Please test against the latest 0.9.0 RC and let us know if there's an issue.

@pauldix are you sue that memory issues are fixed? without verifying you are marking it closed. I am also having memory issue on influx 0.8.8
dmesg:
[2425195.754801] Out of memory: Kill process 24552 (influxdb) score 983 or sacrifice child
[2425195.764315] Killed process 24552 (influxdb) total-vm:154248772kB, anon-rss:129593940kB, file-rss:0kB

@lokeshverizon There's enough difference between 0.8.8 and 0.9.0 that bugs in one don't offer much insight into the other system. The memory leaks in 0.8.8 will not be fixed. Most likely 0.9.0 has new memory leaks to find, but the behavior that leads to these leaks is not particularly strange or unusual.


[EDA] Refactor: REL_Relationships_Con_TDTM - After Update

Critical Changes
Changes
To improve readability, modularity, and performance, we've refactored the REL_Relationships_con_TDTM class. The functionality of this class hasn't changed.
Issues Closed
New Metadata
FACT_ReciprocalRelationshipService.cls
MAPR_RELAutoCreateSettings.cls
MAPR_ReciprocalRelationshipSettings.cls
MODL_ReciprocalRelationshipMapping.cls
SRVC_ReciprocalRelationship.cls
SRVC_ReciprocalRelationshipInversion.cls
SRVC_ReciprocalRelationshipList.cls
FACT_ReciprocalRelService_TEST.cls
MAPR_RELAutoCreateSettings_TEST.cls
MAPR_ReciprocalRelationshipSettings_TEST.cls
MODL_ReciprocalRelationshipMapping_TEST.cls
SRVC_ReciprocalRelInversion_TEST.cls
SRVC_ReciprocalRelationshipList_TEST.cls
SRVC_ReciprocalRelationship_TEST.cls
Deleted Metadata
Testing Notes

@m-kinkade it looks like many of Kevin's comments are related to your work too. Would you mind taking a look just in case we don't miss anything for your PR? Thank you!


HF_TASK Enviournment Variable error

I have tried to deploy an embedding model in AWS Sagemaker endpoint using the provided guide that uses inference.py to deploy custom code. the endpoint is created and starts but when I query the end-point I get the following error.
"You need to define one of the following ['audio-classification', 'automatic-speech-recognition', 'feature-extraction', 'text-classification', 'token-classification', 'question-answering', 'table-question-answering', 'fill-mask', 'summarization', 'translation', 'text2text-generation', 'text-generation', 'zero-shot-classification', 'conversational', 'image-classification', 'image-segmentation', 'object-detection'] as env 'HF_TASK’
How do I set the enviournment variable in the note book I am using for deployment or inside the inference.py file.
Also is it necessary to keep ‘model_fn’ and ‘predict_fn’ name the same in the inference.py file
please guide I have been stuck for quite a while now and changing anything in the inference.py files requires me to generate the .tar.gz file again which takes alot of time

@316usman Are you using a custom model_fn function in your inference.py ?
This error message is probably caused by the default load function of the HuggingFace handler_service, see here.
This means that Sagemaker is not able to find a custom model_fn in your inference.py (or can't find your inference.py),  thus it's using the default one provided by the HuggingFace base image.
And yes, it's required to keep model_fn, predict_fn, input_fn and output_fn names the same, because this is how the handler_service will retrieve them: see here


Use bank-vaults configure for configuring Vault in docker-compose env

This is going to be integrated in  #1424


Add badge tag type support

Add badge support. Badge is non UI modifiable tag which allows other service to ingest.
Test with the following:
[{"tag_type": "badge", "tag_name": "test-tag1"}]
tfeng@tfeng-mbp143 ~/src/amundsenmetadata-private (master) $ curl -X PUT http://<IP_ADDRESS>:5000/table/"hive://gold.schema/table"/tag/test-tag2?tag_type=badge
{"message": "The tag test-tag2 for table_uri hive://gold.schema/table with type badge is not added successfully as badge is not part of the whitelist"}
tfeng@tfeng-mbp143 ~/src/amundsenmetadata-private (master) $ curl -X PUT http://<IP_ADDRESS>:5000/table/"hive://gold.schema/table"/tag/test-tag?tag_type=badge
{"message": "The tag test-tag for table_uri hive://gold.schema/table with type badge is added successfully"}
tfeng@tfeng-mbp143 ~/src/amundsenmetadata-private (master) $ curl -X GET http://<IP_ADDRESS>:5000/table/"hive://gold.schema/table"/tag/?tag_type=badge
[{"tag_type": "badge", "tag_name": "test-tag"}, {"tag_type": "badge", "tag_name": "test-tag1"}]
tfeng@tfeng-mbp143 ~/src/amundsenmetadata-private (master) $ curl -X DELETE http://<IP_ADDRESS>:5000/table/"hive://gold.schema/table"/tag/test-tag?tag_type=badge
{"message": "The tag test-tag for table_uri hive://gold.schema/table with type badge is deleted successfully"}```
it works as expected.

Codecov Report

Merging #91 into master will decrease coverage by 1.91%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   77.82%   75.91%   -1.92%
==========================================
  Files          19       19
  Lines         938      984      +46
  Branches       87       96       +9
==========================================
+ Hits          730      747      +17
- Misses        184      208      +24
- Partials       24       29       +5

Impacted Files
Coverage Δ

metadata_service/config.py
100% <100%> (ø)
:arrow_up:

metadata_service/proxy/neo4j_proxy.py
69.74% <19.04%> (-3.44%)
:arrow_down:

metadata_service/exception.py
83.33% <66.66%> (-16.67%)
:arrow_down:

metadata_service/api/table.py
89.77% <69.56%> (-10.23%)
:arrow_down:

metadata_service/proxy/atlas_proxy.py
84.69% <75%> (-0.39%)
:arrow_down:

metadata_service/proxy/base_proxy.py
67.27% <80%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be622b7...712868d. Read the comment docs.

@jinhyukchang @danwom I updated the pr based on the discussion.

also cc @verdan for FYI we plan to add a new concept called badge which is non human editable type of tag(ingestion from endpoint) to allow tables to show sth like "golden/production ready/beta" etc.
If the table doesn't have any badge, the FE won't show, so it should behave the same as before for atlas proxy.  But once we roll out, do let us know if you are seeing any issues.

also cc @verdan for FYI we plan to add a new concept called badge which is non human editable type of tag(ingestion from endpoint) to allow tables to show sth like "golden/production ready/beta" etc.
If the table doesn't have any badge, the FE won't show, so it should behave the same as before for atlas proxy. But once we roll out, do let us know if you are seeing any issues.

thanks @feng-tao, this will be pretty useful to apply Ranger Policies attached to Atlas entities. 👍


When passing invalid thrift to tcurl it does not print line number

I get output like:
$ tcurl -t ./benchmarks/benchmark.thrift -p <IP_ADDRESS>:21300 a b

undefined:6350
      throw peg$buildException(null, peg$maxFailExpected, peg$maxFailPos);
            ^
SyntaxError: Expected "/*", "0x", "=", "xsd_attributes", "xsd_nillable", "xsd_optional", "}", [+\-], [0-9], comment, end of line, list separator or whitespace but "." found.

it tells me the line number of the pegjs grammar but not the line number in the thrift file.
For this concrete error I left a ... in a struct definition to remind myself to add more things.

PEG SyntaxError instances have that information. We’ll surface it.


Added --suspend-ui to the Dockerfile run

Pull Request Test Coverage Report for Build 867

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 865:
0.0%

Covered Lines:
7938

Relevant Lines:
7938

💛  - Coveralls

Pull Request Test Coverage Report for Build 867

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 865:
0.0%

Covered Lines:
7938

Relevant Lines:
7938

💛  - Coveralls

Close #177

Closes #193


BLD: Use Azure Pipelines for deploying new tagged releases

Is your feature request related to a problem? Please describe.
It would be ideal for Azure Pipelines (AP) to execute the upload to PyPI on new tag versions for Continuous Delivery (CD). This will allow us to eventually drop the use of Travis CI so we have one less config file/environment to manage.
Describe the solution you'd like
Implement AP's functionality with the Python package twine to execute this on a new tag.
Describe alternatives you've considered
It could be possible to create a GitHub Action to do this however this would add another platform to our CI while trying to remove Travis.
Additional context
Travis additionally manages:

[ ] upload of coverage data to coveralls
[ ] testing of Python3.5-min

These will also need to be transferred to AP before we can drop Travis.

@Calama-Consulting do you mind adding me as an owner to https://test.pypi.org/project/pvlib/ ? It would be ideal to test future PRs for this on a the development version of PyPI.


Fix alternatives configuration on RHEL flavours

Previously, a new alternative was created for java/javac that did not configure the slave commands (for example, keytool). This is not necessary, because the RHEL packages being used properly declare their alternatives. Futhermore, it made a lot of standard tools like keytool unavailable.
I'm unsure about the state of Debian/Ubuntu: Ubuntu has the same problematic configuration in https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/Ubuntu.yml#L137-L161. But the proper way there is to use update-java-alternatives, not alternatives. The Debian playbooks don't do this at all. Happy to address that in a separate PR if someone helps me understand the thinking there.

@aahlenst failure on centos 6:
TASK [Common : Set Default JRE] ************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Needed to install the alternative, but unable to do so as we are missing the link"}
	to retry, use: --limit @/ansible/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/main.retry

Should be fixed. Travis is having a bad time. Jobs cannot be started and it happens for other PRs, too.

I'm able to test CentOS6/7/8 on x64 here: https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/864
(The link won't work until some prior runs have finished, just FYI)

@Willsparker Thanks for triggering that job. Seems to have successfully completed.


Fix it cannot use RdocDarkfishParser on CLI

I tried to use RdocDarkfishParser from CLI.
However, the parser seems not to be loaded.
$ doc_to_dash doc -o docset -p RdocDarkfishParser

/Users/giginet/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/doc_to_dash-0.0.9/lib/doc_to_dash/cli.rb:30:in `const_get': uninitialized constant RdocDarkfishParser (NameError)
        from /Users/giginet/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/doc_to_dash-0.0.9/lib/doc_to_dash/cli.rb:30:in `run'
        from /Users/giginet/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/doc_to_dash-0.0.9/lib/doc_to_dash/cli.rb:6:in `run'
        from /Users/giginet/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/doc_to_dash-0.0.9/bin/doc_to_dash:4:in `<top (required)>'
        from /Users/giginet/.rbenv/versions/2.2.3/bin/doc_to_dash:23:in `load'
        from /Users/giginet/.rbenv/versions/2.2.3/bin/doc_to_dash:23:in `<main>'

So I fixed it. Please check it out.

Awesome! I haven't used this in a few years, thanks for fixing this!
I've since stopped using a OS X (and Dash) for day to day development, so does this still generate valid Dash Docsets?  Wasn't sure if the format had changed.

I generated docsets and imported into latest Dash(v3.1.2).
Then it seems to work correctly yet. Don't worry. :smiley:


metabase: service module and test

Motivation for this change
Adding service module along with the test for metabase.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @schneefux @thoughtpolice

@GrahamcOfBorg test metabase

Hehe, reviewed by multiple people at the same time

@GrahamcOfBorg test metabase

@GrahamcOfBorg test metabase

@GrahamcOfBorg test metabase

@GrahamcOfBorg test metabase

Commits are a bit messed up, adding yourself as a maintainer should be the first one, and it shouldn't include other parts of the PR

@Infinisil sorry, my last force push did not go thought, here we go. :)

@GrahamcOfBorg test metabase

ping @Infinisil @aanderse

Awesome. If I could only ask one more thing it would be to drop the unused optionalString reference. Then merge. I promise. :smiley:


grouping tests via describe

Is this a bug report or a feature request?
feature request
Version Info
Version of Majestic: alpha
Version of Jest: 22.2.1
Version of Node: 11.2
Operating System: mac OS X Mojave
Feature Description
In jest you can group tests together using a describe block. It would be very handy and useful to represent this in majestic in the same way. Also it should be possible to run all the tests, that are inside that describe-block.

Hey,
I rewrote Majestic from scratch and it's now supports grouping by describe. Would you be able to give it a try? instructions are here: https://github.com/Raathigesh/majestic/tree/v2

Thx @Raathigesh that sounds really great. I'm afraid I am not working on that corresponding project anymore but I have informed my successors about the good news.

Great. Thanks.

Hi @Raathigesh,
@alxshell 's successor here 👋
Thank you for taking action here.
What we thought would be really handy is a "Run"-button for each level:
✔ run on file-level: runs all tests in the file
❌ run on describe-level: runs all tests within the describe
❌ run on it/test-level: runs a single test
This helps if you are running long lasting tests, made a change and just want to rerun a single test/test group.
Currently I am doing this maually via jest -t 'describeName' or jest -t 'testName'.

Hi @nicostorl 👋 ,
The main reason for removing the button from each level is to make things simple but if it adds value we could add it as an enhancement.
Also, you could always add it.only() or describe.only() to the test/describe you want to run and jest will run only that even if you run the entire file. That would not work for you as an alternative?

Hi @Raathigesh,
that's a good point 😃 I guess this will make my developing-life easier as-well.
If there are some non-developers that want to rerun just a subset of all tests it might add value but that's currently not the case for us.

Hi,
I agree it could be useful to be able to run a single it or describe and I'll keep that in mind for future  :)
I'll close this issue for now but feel free to open issues if you feel like things could be improved.


Milestone issues and pull requests

Will fix #1711

screenshot

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e8b197d). Click here to learn what that means.
The diff coverage is 12.82%.

@@           Coverage Diff            @@
##             master   #5293   +/-   ##
========================================
  Coverage          ?   37.3%
========================================
  Files             ?     313
  Lines             ?   46466
  Branches          ?       0
========================================
  Hits              ?   17333
  Misses            ?   26649
  Partials          ?    2484

Impacted Files
Coverage Δ

routers/repo/milestone.go
0% <0%> (ø)

routers/routes/routes.go
85.51% <100%> (ø)

models/issue.go
48.42% <100%> (ø)

models/issue_milestone.go
57.66% <55.55%> (ø)

routers/repo/issue.go
32.32% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b197d...4bfb599. Read the comment docs.

@lunny Would it be possible to put something like "92 opened, 10 closed" ?

@adelowo see the screenshot, I think I have put them there and added some filters which is better than github.

@lunny Sorry about that... I am so used to Github writing it in "plain text" ...


Exercises-w2

Exercises
Name
Robert Hoekstra
Class
214 (Tech 3)
GitHub username
https://github.com/robert-hoekstra/js-bootcamp
Bootcamp exercises
ChessBoard
FizzBuzz
Looping a Triangle
Bean Counting
Minimum
Sum of a Range
Flattening
Vector Type
Unfinished
I find these exercises too hard and would like to have some more information about them.
Locked Box
Roads
Bootcamp notes
Notes
Still working on the notes of the remaining chapters 8, 10 and 11.
It is too much information for me to understand and summarize in the short time we had in the previous two weeks. So I will be updating this repository during the week off.

I find these exercises too hard and would like to have some more information about them.

Any specific information you're looking for? @robert-hoekstra


[Feature] Ability to configure package.json file for other generators.

Using packagejson scope option.
For example new dependencies could be added to newly created package.json file if some generator will add such options to scope:
packagejson: {
    dependencies: {
        jade: '*'
    }
}

Feature will be very useful for new views generators.

Scheduled for bump~

@CWyrtzen @rachaelshaw Any news on this ?

@mikermcneil would you mind taking a quick look at this?

@mikermcneil @rachaelshaw @CWyrtzen Please somebody take a look.

@konstantinzolotarev looks good- only things I'd ask are:

please format the code using the .editorconfig file so the spacing is normalized (i.e. two spaces for indentation).
Just for consistency, can we call it packageJson instead of packagejson?

Thanks!

Updated


Feature for querying by type and change status

It is throwing many errors please run behave tests locally before you create a PR @freshao1017


Change ExportTemplate Uniqueness Constraint

Carved from #2908
Proposed Changes
Move to unique_together on just content_type and name, reject migration if duplicate

Closed by #3871


Revert "Image streams optimization (#1616)"

This reverts commit b73c3149ad7930048d00a0c9d2fab046e41d227c.
Fixes #1637.
Likely fix for #1636 - tagging @alan-baker.

If we revert, we no longer need #1635 either.

#1642 should also fix both issues.

Merging as discussed in the Feburary 28th teleconference to unblock additional fixes.


Fixing problem with map centering for Deep insights

@javisantana @AbelVM
First part of https://github.com/CartoDB/deep-insights.js/issues/190.
This really closes the problem -> https://github.com/CartoDB/deep-insights.js/pull/199

I think we should not recenter the map on new layers added, this problem should be address in DI.js when the map size changes because of the panel, something around here https://github.com/CartoDB/deep-insights.js/blob/master/src/dashboard-view.js#L45
sidebarVIew.on('resize', function() {
   mapView.invalidateSize()
})

What about in create-dashboard.js try:
...
var widgets = new WidgetsCollection();
if (widgets.size() > 0) {
  vis.resizeMap();
}
vis.instantiateMap();

And then in CartoDB.js a function with:
...
resizeMap: function () {
     var c = this.mapConfig;
     if (c.view_bounds_sw && c.view_bounds_ne) {
       this.map.setBounds([
         c.view_bounds_sw,
         c.view_bounds_ne
       ]);
     } else {
       this.map.setCenter(c.center);
     }
   },
},
...

retest this please

Approved by the CTO.

:es:


Updated the FAQ topic.

Learn Build status updates of commit 8fe8e6b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit bd626ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 8e49e05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:white_check_mark:Succeeded
View

docs/microsoft-365-developer-program-get-started.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Update wasm-smith for recent changes to module-linking

Implement exporting modules/instances
Implement implicit instances from two-level imports
Update encoding of instance arguments
Implement outer aliases to types/modules

Heh no worries, it's high time someone calls out my sloppy comments anyway :)

Heh no worries, it's high time someone calls out my sloppy comments anyway :)


Add cluster support via Resolver

This adds support for RabbitMQ clusters to connect up to one of a number of servers.
It does this through a Resolver interface which has a single method called Resolve() which can return a list of servers.  There is a standard implementation included called StaticResolver that will just take a list of URLS to connect to and optionally shuffle that list.
This interface approach allows for implementers of the library to extend for service discovery or other advanced typologies.
Fixes:  #148

I went ahead and wrote my own wrapper that has this and does things slightly different.  No longer have a strong requirement for this.


CLI too bright background text color

I was taking a look at the project's code and the lib used to print colors but I couldn't find the reason (issue showed in the picture above) so I'm making this issue.
PS: The text is not being selected by the terminal's cursor.
Environment
Terminal: Alacritty

Theme:
# (Github Dark High Contrast) Colors for Alacritty

[colors.bright]
black = "#4c566a"
blue = "#81a1c1"
cyan = "#8fbcbb"
green = "#a3be8c"
magenta = "#b48ead"
red = "#bf616a"
white = "#eceff4"
yellow = "#ebcb8b"

[colors.cursor]
cursor = "#d8dee9"
text = "#2e3440"

[colors.dim]
black = "#373e4d"
blue = "#68809a"
cyan = "#6d96a5"
green = "#809575"
magenta = "#8c738c"
red = "#94545d"
white = "#aeb3bb"
yellow = "#b29e75"

[colors.normal]
black = "#3b4252"
blue = "#81a1c1"
cyan = "#88c0d0"
green = "#a3be8c"
magenta = "#b48ead"
red = "#bf616a"
white = "#e5e9f0"
yellow = "#ebcb8b"

[colors.primary]
background = "#0a0c10"
dim_foreground = "#a5abb6"
foreground = "#d8dee9"

hey @pandasoli, thanks for reporting!
Extension.js uses @colors/colors/safe for all messages, but the terminal code from your screenshot seems related to turbo (the lib used to manage the monorepo) so not something we can do much about.
below are all the messages we use. assuming logging functions in these files print readable content, we should be good:

https://github.com/extension-js/extension.js/blob/main/programs/cli/cli-lib/messages.ts
https://github.com/extension-js/extension.js/blob/main/programs/develop/webpack/lib/messages.ts
https://github.com/extension-js/extension.js/blob/main/programs/develop/commands/commands-lib/messages.ts
https://github.com/extension-js/extension.js/blob/main/programs/develop/plugin-browsers/browsers-lib/messages.ts

will close for now as not actionable, please reopen if I'm mistaken. thanks!


New App: GitHub Status

Description
Use the GitHub status page to report on the current status of GitHub services. If all services are up, "No issues" will be displayed. If 4 or less services are down they will be displayed by name (with yellow/red colors). If more than 4 services are down the number of services down will be displayed along with the outage color.

Copilot

🤖 Generated by Copilot at 7bc6558
Summary
📝🚀🌐

Added a new applet called github_status that displays the status of GitHub services on the tidbyt device. Added a docstring to github_status.star and a manifest file to apps/githubstatus/manifest.yaml to provide metadata and documentation for the applet. Followed the tidbyt applet development guide for the format and content of the docstring and manifest file.

githubstatus app
docstring and manifest file
autumn leaves of code

Walkthrough

Add a new applet for displaying GitHub status information (link, link)
Define the applet metadata, such as name, summary, description, and author, in the docstring of github_status.star and the manifest file manifest.yaml (link, link)
Import the json, net, and time modules and declare the constants for the GitHub status API URL and the refresh interval (link)
Define the fetch_github_status function that makes a GET request to the GitHub status API and returns a JSON object with the status message and indicator (link)
Define the render_github_status function that takes the JSON object from the previous function and renders a pixel art image on the tidbyt display, using different colors and icons depending on the status indicator (link)
Define the main function that loops indefinitely and calls the previous two functions, updating the tidbyt display with the latest GitHub status every refresh interval (link)

I have read the CLA Document and I hereby sign the CLA

recheck


chore(main): release 0.2.1

:robot: I have created a release beep boop
0.2.1 (2024-09-04)
Documentation

README: add zenodo DOI and latest release version (ef8444d)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.1
:sunflower:


Add top/bottom bars

This PR adds a top and bottom bar to atom-workspace.
<atom-workspace class="workspace">
  <atom-panel-container class="header"></atom-panel-container><!-- New -->
  <atom-workspace-axis class="horizontal"></atom-workspace-axis>
  <atom-panel-container class="footer"></atom-panel-container><!-- New -->
  <atom-panel-container class="modal"></atom-panel-container>
</atom-workspace>

It allows packages to add <atom-panel>s that span across the whole width and not just above/under the editor.
The status-bar or tabs could go on top and under the tree-view.

Tasks

[x] Change to flexbox
[x] Add top/bottom bar elements
[x] Add API
[x] Add specs

Todo after merging

Merge: https://github.com/atom/tree-view/pull/627

Closes #8939

This looks very promising! :sparkles:

I think if we allow other packages to add a panel that spans across the full width at the bottom, the status-bar should also go full width and be below it. Otherwise, this looks a bit odd having it above the tool-bar.

I'm working on a package that needs to be fullwidth. This will be :cool: .

@simurai Looks good to merge when you're satisfied. I don't think moving the status-bar when the panels are there is actually crucial because it's generally full of metadata for the current editor and it seems a little strange to separate it from the bottom of the editor by an arbitrary amount.

@thedaniel I tested a few packages and made some tweaks so they don't break. So I think it should be good now.
Well, I still found one that inlines the height based on the whole window, which doesn't work when header/footer gets populated. There are probably more that do the same, but maybe ok?

I think it's maybe OK. What happens, does the youtube pane cover up the header/footer? We could always give package authors like @alexandruionascu feedback on a better way to calculate height after this gets merged.

No, the footer covers the youtube pane. Which is not too problematic in this case.

Right, we can notify package authors about it.

Right, we can notify package authors about it.

We can even open PRs. When we merge this, just point me at repos and I can try to fix a few :wink:

Sounds good. I started a "Packages that break or have issues" list in the description.
Only packages that add an atom-panel on the left/right should be affected.

@simurai Great, thanks!

I'm sorry for the complete offtopic, but what plugin is the one with the GitHub icon (among others) that you're using, @simurai ?

@alexandernst It's https://atom.io/packages/tool-bar. Plus https://atom.io/packages/flex-tool-bar so you can easily map any command to a button.

@simurai Thank you so much! This plugin should be part of core imho, it completely rocks! \o/

Code-wise this looks good to me: nice work here, @simurai! :sparkles:
I know we haven't done so for other kinds of panels, but what would you think about testing the actual dimensions/coordinates in workspace-element-spec.coffee? So that we make sure that our flex box CSS code is actually working as expected. I can add those specs myself or we can :pear: and add them together.
Also, I gave this a quick test-drive and I have jotted down a couple of concerns (which maybe are not related to this PR, but to the respective packages instead?):

Header panels cause tabs' top-border to look inconsistent/missing:

Header panels cause tree-view projects to look off:

I noticed you opened a PR on tree-view which is maybe addressing 2), but https://github.com/atom/tree-view/pull/627#issuecomment-151683080 seems to state it's not needed anymore. Thoughts?

@as-cii Thanks for testing. Point 2 should be fixed with the PRs above.
Point 1: Yeah, it looks a bit odd if you just add text with One light. I guess it depends on the theme and the package that would occupy the header. For example the tool-bar has a bottom border so it should look ok.

I think we can leave it up to the package/theme to either add a bottom border or a different background color to have some kind of separation.

I can add those specs myself or we can :pear: and add them together.

:pear:ing would be great. I'm flying home tonight, so I'll ping you about it.

Wow, very nice!

@rm-code This hasn't been merged yet

@alexandernst I know :grin: Looking forward to it though. Especially if it enables #10208 to be merged as well.

 Add top/bottom bars

The code looks good to me. @as-cii are you still interested in :pear:ing with @simurai to add some DOM-based specs?

Looks good! :sparkles:
:shipit: after specs go :green_heart:!

Travis builds are legit. Merging.

@benogle Don't forget to merge https://github.com/atom/tree-view/pull/627 please

Thanks for the heads up

This broke some Nuclide stuff too. Will this go out with 1.5.0 or 1.6.0?

Sorry about that. It'll be out in 1.6

@zertosh Sorry. Yeah, noticed that scrolling of Nuclide's file-tree will break.
Any idea where that  with inline height: 100%; comes from? If that  can be removed, I think it should work.

Or if that  needs to stay, removing the height and adding flexbox should work too:
atom-panel.left > div {
  height: initial !important;
  display: flex;
}

@simurai: No worries, @ssorallen is the one looking into. I think he has a solution to support both the new and old behavior- something we have to do since we can't upgrade everyone at fb to 1.6.0 at the same time.

@simurai Thanks for checking out the Nuclide DOM. I will try out your fix.

I think he has a solution to support both the new and old behavior

Good point. Most packages currently use .my-package { height: 100%; }. Then in 1.6.0 core styles will override it with initial atom-panel-container > atom-panel.left > * { height: initial; } to make it work with Flexbox and the added header/footer.
If you wanna keep the current markup, inheriting the height and adding flexbox seems to work with both versions.
<atom-panel class="left tool-panel panel-left">
  <div style="height: inherit; display: flex;">


obtain stage from options not provider

provider is actually a kind of 'defaults' object, that can't be relied on for config.

Without this change, sls deploy always tries to enable tracing on the dev stage and not the provided stage (i.e. stable or prod)

@bdgamble in their service, they set:
provider:
  stage: ${...}

ah, should we follow suit?

Coverage remained the same at 100.0% when pulling 784f7b667ec69456a192481fb2e7f3bcb5aa4d02 on dougmoscrop:master into b7f57107071692eba952ffd81195ab8ef1fca311 on AlexanderMS:master.