Add images to failure dump that fail assertions, e.g. of dimensions (OSOE-497)

When running BasicVisualVerificationTests.VerifyNavbar() all the while the .navbar-brand element has some missing or broken styles, the test will fail like this:
Error:
  Shouldly.ShouldAssertException : elementImageOriginal.Height
      should be greater than or equal to
  28
      but was
  18

See https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/3694863540, Annotations, 6th error for an example.

The above error is not very helpful in case you're not already deep inside the concerned area of code. It would be more helpful to have the offending element screenshots, the expected and the actual ones, inside the failure dump in order to more quickly and easily identify the problematic element on the page.
Jira issue

Here's where the error is thrown on size mismatch: https://github.com/Lombiq/UI-Testing-Toolbox/blob/fb10e99ff04138c500902313f1c36ae0d26477f6/Lombiq.Tests.UI/Extensions/VisualVerificationUITestContextExtensions.cs#L405.
We could catch those potential exceptions, add the images to the failure dump, and then simply throw again. For example.

The images are added to the failure dump. Under the DebugInformation/VisualVerification folder, you should the following for each failing visual verification assertion: the baseline image, the actual image, and a mask of the diff between the two. There are further files for context too:

What are you missing from these?

Take a look at the code place linked above - there are Shouldly assertions that throw exceptions when not met, and no images are being saved to the dump.

OK, so this is only for dimension mismatch.

While images are not saved to the failure dump like above, the captured element image is saved to the failure dump (as well as full-page screenshots of the whole test, as usual). A diff can't be saved, because for that we need images of the same dimension.
So, what can be done is a better exception message that explains what the issue is and how to fix it. Does something like this sound more helpful?

The dimensions of the captured element (264px x 28px) are smaller than the dimensions of the baseline image (270px x 29px). This can happen if due to a change in the app, the captured element got smaller than before, or if the baseline image is mistakenly too large. The suggested baseline image with a screenshot of the captured element was saved to the failure dump. Compare this with the original image used by the test and if suitable, use it as the baseline going forward.

Surely, the proposed exception message is much better.
I was thinking that we could save screenshots of just the mismatched element - the page screenshot wasn't very helpful in finding the cause of the issue because it was just a the header text element that was slightly lower than expected which was (almost) not visible on the large screenshots.

In such cases, the suggested file (i.e. that's a current screenshot of the tested element, with the correct dimensions) will be (already is) saved to the failure dump, like this:

You can use this to compare the baseline image (i.e. that's saved in the repo to test against) that you have locally. But algorithmically this isn't straightforward, since the two files will have different dimensions (so, there's no way to diff them unless we assume a location of the smaller image on the larger one, like upper-left corner, which is arbitrary).


大喜利ボット

Codecov Report

Merging #202 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   44.53%   44.67%   +0.14%
==========================================
  Files          45       45
  Lines        4123     4123
  Branches      849      849
==========================================
+ Hits         1836     1842       +6
+ Misses       1820     1814       -6
  Partials      467      467

Impacted Files
Coverage Δ

prime/index.js
17.79% <0%> (+0.28%)
:arrow_up:

sushi-bot/index.js
58.82% <0%> (+0.73%)
:arrow_up:

ponpe/index.ts
35.77% <0%> (+3.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b8238...e1a570e. Read the comment docs.


Download link to preprocessed_zhang.h5ad dataset

Hi,
Thanks for writing this amazing tool. Can you please provide the link to preprocessed_zhang.h5ad that is required to run the tutorial notebook, or, point me to the url of the dataset.
The closest dataset I could get was count.h5ad inside https://download.brainimagelibrary.org/cf/1c/cf1c1a431ef8d021/processed_data/ , Please let me know if that's same as the above file.
Thanks

Hi @hiraksarkar,
thank you for opening an issue.
I added the data preparation notebook needed to create preprocessed_zhang.h5ad to the ncem_benchmarks repository.
We are using the counts.h5ad matrix you mentioned (accessable here) and additionally cell_metadata.csv which contains x and y coordinates and cell type annotation on cell level. cell_metadata.csv can be requested from Zhang et al. directly for further analysis.
Supsequently, we normalized and logp1 transformed the data with scanpy as stated in the notebook.
Happy to help if you encounter any more difficulties!

Hi @AnnaChristina ,
Thanks a lot.

Hi,
I am a reader of 'ncem'. I am appreciated by your excellent work. I plan to use this package with CODEX image data. Yet, I failed to load my data referring the above tutorial code. I find there are a lot of prefix like 'zhang','Hartmann' to build a dataloader. I don't know how to choose them. May I request for a help?

Hi @Luosanj,
thanks for raising the issue andyour interest in using ncem!
from your outstream I inspect you are trying to use ncem on one of our predefined datasets right? If I read your message correctly, you want to use ncem on your own data right?
For this purpose, we designed a custom dataloader which can be called on any AnnData object and you will just need to specify the categorical cell types in .obs.
Could you confirm that a custom dataloader is what you require? or do you want to use ncem with our predefined datasets?
Thanks and best!

Hi Anna,
Thanks a lot for response! I want to use my own CODEX image data with NCEM tool. Where is the 'custom dataloader' that you build? And by the way, CODEX image data hasn't got genes but has protein marker intensity. In this case do you use marker intensity to replace gene expression in linear model and encoder-decoder model for CODEX image data?
Cheers!

Hi Anna,
The former question has been solved. That problem is due to my python version. I run my CODEX image data successfully with your tutorial. Yet, I have a question that when you run your CODEX Image data, did you normalize marker density data into the range between 0 and 1? From my result, the figure of sender receiver effect through edge 'magnitude' is drawn like this. Have you met this issue before ? The figure of sender receiver effect through number of differential genes is normal.

Hi @hiraksarkar,
which version of ncem are you using?
In the most recent ncem==0.1.4 we return the dataframe used for ploting the circular plot and this might help to understand what is happening for the magnitude. I would assume one interaction has a quite large absolute magnitude and this might be the issue generating the plot shown above.

Hi! When I try to apply the sender-receiver analysis to my dataset, I received this error
(350, 10, 14)
(350, 10, 196)
Traceback (most recent call last):
File "", line 1, in
File "/Users/hailey/anaconda3/envs/newenv/lib/python3.8/site-packages/ncem/interpretation/interpreter.py", line 912, in get_sender_receiver_effects
x_design = np.concatenate([target, interactions.squeeze()], axis=1)
File "<array_function internals>", line 180, in concatenate
ValueError: all the input array dimensions for the concatenation axis must match exactly, but along dimension 2, the array at index 0 has size 14 and the array at index 1 has size 196
I was wondering what might be the cause of this problem and how should I fix this?


MGW2 (DMWG03LM), ValueError: invalid literal for int() with base 10: b

DMWG03LM
Logger: custom_components.xiaomi_gateway3.core.gateway
Source: custom_components/xiaomi_gateway3/core/gateway/gate_mgw2.py:81
Integration: Xiaomi Gateway 3 (documentation, issues)
First occurred: 22:04:17 (2 occurrences)
Last logged: 22:09:17

<IP_ADDRESS> | Can't update gateway stats
Traceback (most recent call last):
  File "/config/custom_components/xiaomi_gateway3/core/gateway/gate_mgw2.py", line 81, in mgw2_update_stats
    "rssi": int(rssi) + 100
ValueError: invalid literal for int() with base 10: b''

fixed #885 #889

MR #889  has been conflicted with MR #885,  it should use only one of these two MRs.
2022-12-23 19:12:45.616 WARNING (MainThread) [custom_components.xiaomi_gateway3.core.gateway] <IP_ADDRESS> | Can't update gateway stats
Traceback (most recent call last):
File "/config/custom_components/xiaomi_gateway3/core/gateway/gate_mgw2.py", line 82, in mgw2_update_stats
"rssi": int(rssi) + 100 if len(rssi) >=1 else 0
TypeError: object of type 'int' has no len()


SW-6281 Log bodies of failed requests

Currently we log request and response bodies for employees for troubleshooting.
Extend the logging to also include request bodies for requests that result in
error responses, even if the users aren't employees. This will help us
troubleshoot unexpected request failures.

#2622  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 20, 6:46 PM EST: A user merged this pull request with Graphite.


feat: hide copy text button on no JavaScript browsers

problem space
a keen viewer of your (hypothetical) site sees a code block with a copy button however finds that it is non-functional due to their hard line stance against JavaScript running in the browser.
a potential solution
you write a (hypothetical) hacky expressive-code plugin to lazily patch this out as an issue but it's not enough (don't use this since it will create a noscript block in every code block, or do but live a sub-optimal and complicit life):
import { definePlugin } from 'astro-expressive-code';
import { h } from 'astro-expressive-code/hast';

// No JavaScript User
// hides the code copy button for those who don't use JavaScript.

export const noJavaScriptUser = () =>
  definePlugin({
    name: 'No JavaScript User',
    hooks: {
      postprocessRenderedBlockGroup: ({ renderData: { groupAst } }) => {
        groupAst.children.push(h('noscript', [h('style', 'figure.frame > div.copy { display: none; }')]));
      },
    },
  });

the way out
the expressive-code plugin-frames plugin should build in support for hiding the copy button on noscript environments in a robust way that probably doesn't copy the noscript tag many times over multiple code blocks (like how it does in the above example).
the astro solution
now I'm no expressive-code expert, but to fix this in https://github.com/withastro/astro it might be able to be done by just adapting the code earlier in this issue into somewhere above:
https://github.com/expressive-code/expressive-code/blob/84cdd77f3d6c25ef1836af6cf7420fe9053116b6/packages/astro-expressive-code/src/renderer.ts#L58
just convert from the https://github.com/syntax-tree/hastscript h call (from the code above) to using the object initializer!
obviously, this won't work on other targets.
concerns
as pointed out by a stackoverflow commenter in the year 2009, this sort of hack is:

Not allowed in the xhtml standard at least.

every browser I've tried this on seems fine with this.

An alternate solution could lie in https://caniuse.com/mdn-css_at-rules_media_scripting. As of writing this comment, $85.64\%$ of users can use this css rule to hide the copy button.

Hello and welcome!
I can imagine adding the CSS media query solution @media (scripting: none) { ... } to hide the copy button in case scripting is disabled. This approach seems to be a reasonably small change that would not require any additional HTML to be sent out for every code block.
Does the method you're using to disable JS get properly detected by this example on MDN?

Interestingly enough, the MDN example linked doesn't seem to load with javascript.enabled = false on Firefox. I have given it a try though (on Firefox) and the media query seems to work just fine for detecting the about:config flag.

Fixed in #230. Thank you for the PR and welcome to the circle of Expressive Code contributors!


Some updates to fix Errors

<IP_ADDRESS> to <IP_ADDRESS> in the main
changes to prevent a NullReferenceException i was having so added  && vrm != null) in ValheimVRM.cs
Fixed some game errors for VRMEyePositionSync

Everything seams to work, merging.


Checks return types in testing.numpy_cupy_*

Jenkins, test this please.

Jenkins, test this please.

Jenkins CI test (for commit 62a5ffcbf273b4dae9f646654f1b853abcea760e, target branch master) failed with status FAILURE.

Seems like there are functions that returns two numpy arrays instead of one cupy and one numpy array

Jenkins, test this please.

Jenkins CI test (for commit 8985ad9fcbc26c8826d82bb7bc0d74244a76bc9c, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit dcf35c88b47914a751d021db169b68730a1c0d20, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit bb58ca455b9b2a42113a5bc1ed44476d1d10d44d, target branch master) succeeded!


This package (cf binary) likley has to be GPL licensed due to linking against FFTW

We came to the conclusion here:
https://github.com/conda-forge/pyshtools-feedstock/issues/3
that the Conda Forge binaries that link against FFTW have to be GPL licensed. This would likely the case for this package too.

Thanks for pointing that out. It is actually CeCILL licensed which is compatible with GPL. It is regarded as a license with copyleft characteristics. The following excerpt is relevant:

5.3.2 DISTRIBUTION OF MODIFIED SOFTWARE
When the Licensee makes a Contribution to the Software, the terms and conditions for the distribution of the resulting Modified Software become subject to all the provisions of this Agreement.
The Licensee is authorized to distribute the Modified Software, in source code or object code form, provided that said distribution complies with all the provisions of the Agreement and is accompanied by:
a copy of the Agreement,

a notice relating to the limitation of both the Licensor's warranty and liability as set forth in Articles 8 and 9,

and, in the event that only the object code of the Modified Software is redistributed,
a note stating the conditions of effective access to the full source code of the Modified Software for a period of at least three years from the distribution of the Modified Software, it being understood that the additional acquisition cost of the source code shall not exceed the cost of the data transfer.

5.3.3 DISTRIBUTION OF EXTERNAL MODULES
When the Licensee has developed an External Module, the terms and conditions of this Agreement do not apply to said External Module, that may be distributed under a separate license agreement.
5.3.4 COMPATIBILITY WITH OTHER LICENSES
The Licensee can include a code that is subject to the provisions of one of the versions of the GNU GPL, GNU Affero GPL and/or EUPL in the Modified or unmodified Software, and distribute that entire code under the terms of the same version of the GNU GPL, GNU Affero GPL and/or EUPL.
The Licensee can include the Modified or unmodified Software in a code that is subject to the provisions of one of the versions of the GNU GPL, GNU Affero GPL and/or EUPL and distribute that entire code under the terms of the same version of the GNU GPL, GNU Affero GPL and/or EUPL.

The CeCILL-B package license was a typo, and is being rectified in #11. Do you think this suffices?

I'm not sure. I haven't thought about it in a while. I did open this issue to try to articulate things:
https://github.com/conda-forge/conda-forge.github.io/issues/1065
There is a confusing nuance about the dynamic linking that I never came to a solid conclusion on and it doesn't seem like there is much energy to try to address it.


Library not working on Kotlin 1.4.x

Library only works on Kotlin 1.37.2 but not on version 1.4.x
Error
e: Could not find "/Users/xxxxxx/.gradle/caches/modules-2/files-2.1/dev.bluefalcon/library-iosx64/0.7.2/a144ef7bdbb2b135d54d02993a459c6f89e4e643/library.klib" in [/Users/xxxxxx/AndroidStudioProjects/kmm-demo, /Users/xxxxxx/.konan/klib, /Users/marc.forn/.konan/kotlin-native-prebuilt-macos-1.4.10/klib/common, /Users/xxxxxx/.konan/kotlin-native-prebuilt-macos-1.4.10/klib/platform/ios_x64].
Daemon vm is shutting down... The daemon has exited normally or was terminated in response to a user interrupt.
This will be fixed by pointing library to newer version of Kotlin.
Looking forward and update :)

Hi @marcforn - i have just uploaded a new version to maven, this should appear in a few hours. version: 0.8.0 - now supports 1.4.10

Great job!! Thanks


test(fix):refactor tests

** DO NOT MERGE **
Refactoring tests to work without mocked test data.

Not needed anymore. Different PR addresses this.


Avoid netcdf warning

With this PR, scipy.io.netcdf_file is used instead of scipy.io.netcdf.netcdf_file, since the latter is being deprecated in scipy, so scipy has started printing a warning about it.

Looks good to me.


DecimationAlgorithm enum not found

Expected Behavior
I am no pro at Angular/JS, but by seeing the d.ts file and how the decimationOptions are defined, I expect the DecimationAlgorithm enum to be exported
export declare enum DecimationAlgorithm {
  lttb = 'lttb',
  minmax = 'min-max',
}

And that, when declaring options, I can use the following:
plugins: {
  decimation: {
    enabled: true,
    algorithm: DecimationAlgorithm.lttb
  }
}

Current Behavior
https://codepen.io/Nico-DF/pen/WNRWJQr
"export 'DecimationAlgorithm' was not found in 'chart.js'
error Command failed with exit code 1.
Maybe it is a misunderstanding on my side, but currently, I'm forced to do the following:
plugins: {
  decimation: {
    enabled: true,
    // @ts-ignore
    algorithm: 'lttb'
  }
}

The ts-ignore is needed due to the definition of the option

The DecimationAlgorithm type is exported. https://github.com/chartjs/Chart.js/blob/master/types/index.esm.d.ts#L1955-L1958
Do you have a reproduce that uses TS? I created this test case and it worked as expected
import { Chart, DecimationAlgorithm } from '../../../index.esm';

const chart = new Chart('id', {
  type: 'bubble',
  data: {
    labels: [],
    datasets: [{
      data: []
    }]
  },
  options: {
    plugins: {
      decimation: {
        algorithm: DecimationAlgorithm.lttb,
      }
    }
  }
});

Sorry for the delay, took a few days off, the codepen exhibits the not found exception, and for the TS, something like this does not work (which I agree is weird as I also saw the export on d.ts file)
import { ChartData, ChartDataset, ChartOptions, DecimationAlgorithm } from 'chart.js';

public static buildChartOptions(
    xLabel: string,
    yLabel: string,
    minX: number,
    maxX: number,
    zoomCallback: () => void
  ): ChartOptions {
    return {
      // We are using objects like {x: 10, y: 20}, disabling parsing for performance
      parsing: false,
      // Data are already ordered
      normalized: true,
      animation: false,
      responsive: false,
      scales: {
        y: {
          title: {
            display: true,
            text: yLabel
          },
          type: 'linear',
          ticks: {
            minRotation: 50,
            maxRotation: 50
          }
        },
        x: {
          title: {
            display: true,
            text: xLabel
          },
          type: 'linear',
          min: minX,
          max: maxX,
          ticks: {
            minRotation: 50,
            maxRotation: 50
          }
        }
      },
      plugins: {
        decimation: {
          enabled: true,
          algorithm: DecimationAlgorithm.lttb
        },
        legend: {
          align: 'start'
        },
        zoom: {
          limits: {
            x: { min: minX, max: maxX }
          },
          pan: {
            enabled: true,
            mode: 'x'
          },
          zoom: {
            enabled: true,
            mode: 'x',
            onZoom: zoomCallback
          }
        },
        tooltip: {
          mode: 'index',
          intersect: false
        }
      }
    };
  }

This functions creates for me the ChartOptions and I use it to build several different graphs.
Using the enum will fail with "export 'DecimationAlgorithm' was not found in 'chart.js'
(On IDE chart.js refers correctly to index.esm.d.ts)

I could try to setup a mock project and post the link here if you want (probably not before tomorrow though)

Here's a repro: https://codesandbox.io/s/competent-hooks-bi2i7?file=/src/index.ts
The issues is, chart.js is written in javascript, so the exported typescript enum never gets compiled and transpiled to an object, as it would in a typescript project. So it really is undefined.
The type checking works fine though, so you can just use 'lttb'.
I think we should stop exporting the enums, because those are not really usable.

And another note, seems like there is a better solution, by using const enum: https://stackoverflow.com/a/50568865/10359775

Thanks for the update @kurkle, I agree that using 'lttb' works (it is what I'm doing right not), but if using a strict check with tslint, it will fails as string != DecimationAlgorithm, that was basically my point

Sorry for missing the actual point, but I think the const enum could be an answer to that too. Unless you then really need to use something called module isolation and that is not really possible in all cases? (still really new to TS)

Didn't saw the last part of comment, I think that indeed it might do the trick, thanks for the help, didn't think of it (still pretty new too)
But nonetheless, I either missed a thing or the generation is effectively clunky as I agree with @etimberg that I also see the export declare enum DecimationAlgorithm in d.ts file, so I let you guys confirm whether or not there is an issue with how enums are transcompiled

I agree that using 'lttb' works (it is what I'm doing right not), but if using a strict check with tslint, it will fails as string != DecimationAlgorithm, that was basically my point

I believe the string was fixed in #9010.

Indeed, the type will now match.
Concerning the enum export, I'll trust you on what to do with this Issue

I tried out the export const enum solution locally, but the output .d.ts files appear identical.

What do you mean by "output .d.ts"? We are shipping the definitions as is now, if I'm not mistaken.
The result should be only visible in a typescript project using the types, where the typescript compiler would convert the enum values to strings in the const case. At least this is my understanding, but I'll verify it.

Diff of the .js output of npx tsc decimation_algorithm.ts by changing declare to const:

@etimberg sorry for the ping, but since you were the one approving the other PR and this follows the same pattern, would you mind reviewing the PR I've just prepared. Thanks!


Better defaults for DefaultHander and Hardfault

@jamesmunns and I had a discussion on Matrix about the current defaults that leave HardFault_ and DefaultHander_ implemented as infinite loops.
This should most likely be replaced with panic in the default case to help the implementors detect issues and if nothing is done the panic crate takes care of the default course of action.
This might increase code size a bit, but for those that do not want this can override it and provide their own implementation.
From an API standpoint it is not a breaking change, however the documentation states that we use infinite loops as the default, so it is a breaking change.

An alternative would be to panic when #[cfg(debug_assertions)] is on, and use infinite loops otherwise. That way users won't have to go through the hassle of overriding handlers to get small executables.

Could do, but honestly I'd prefer exceptions to reset if I've selected panic-reset or panic-persist as my panic handler, even in release mode.
If you have a panic handler that disregards the panicinfo, it should still be largely optimized out (branch to panic handler/SCB::sys_reset(), instead of infinite branch loop)

This should probably have been closed by #257, but that has since been reverted, with the decision to make overriding non-maskable interrupt handlers unsafe (https://github.com/rust-embedded/cortex-m-rt/pull/289), so closing as wontfix instead.


Segmentation fault while performing Convolution2D

Bug Description
Segmentation Fault running Test Code - Mnist while calling Convolution 2D.
Reproduction Steps

Downloaded the requisite file from http://yann.lecun.com/exdb/mnist/
Ran the Mnist.cpp - print is happening just before Convolution2D is called
Same issue with self written code

Platform and Hardware
[Please list your operating system, [GPU] hardware, compiler, and other details if relevant]
RHEL8.0, -1- INTEL: Intel(R) Xeon(R) Gold 5218 CPU @ 2.30GHz, 34296 MB
Intel(R) FPGA Emulation Platform for OpenCL(TM): Intel(R) FPGA Emulation Device, 34296 MB
ArrayFire v3.8.0 (OpenCL, 64-bit Linux, build d99887a)
I had installed flashlight using vcpkg. Does that install latest version or I have to install fresh version?

The installed version of flashlight is flashlight-cpu[core,fl]:x64-linux -> 0.3#2
moreover I get error when i set seed using fl::setSeed(1);
error: ‘setSeed’ is not a member of ‘fl’
Please do help solve this issues


Add general convolution TTIR op. Add pass that legalizes it to Conv2D

Added ConvolutionOp, a very flexible convolution operation that can represent a convolution (and conv-transpose) of any dimensionality

Adding because stablehlo only has one convolution operation exactly like this, and we don't want to legalize to specific convolutions in dialect conversion, rather transform it within the same dialect.
Created a TTIR_ConvLayoutAttr to store the dimension numbers of the input, weight, and output.

I.e which index is the batch dimension, which index is the channels dimension, which indices are the spatial dimensions

Added a pass that recognizes when a ConvolutionOp is a legal Conv2d (or can be converted to one by permuting the input, weights, and/or output) and performs the transformation.
In the future we can add passes that legalize ConvolutionOp to any ConvNd or ConvNdTranspose.

This converts broad TTIR Conv to a more specific and narrow one. Should we leverage Jovan's work to consolidate the decomposition into a narrower set of TTIR operations?
https://github.com/tenstorrent/tt-mlir/pull/969

I belive @jserbedzijaTT will merge this soon, can we wait a day or two to consolidate things from the start? :)


Add tool support for jlama

Issue
Closes #1660
Change
This PR adds tool calling support for Jlama added in 0.3.1 release.
I have tested these changes with Mistral and Llama-3.1 models.
General checklist

[X] There are no breaking changes
[X] I have added unit and integration tests for my change
[X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
[X] I have manually run all the unit and integration tests in the core and main modules, and they are all green

[X] I have added/updated the documentation
[X] I have added an example in the examples repo (only for "big" features)
[ ] I have added/updated Spring Boot starter(s) (if applicable)

Checklist for adding new model integration

[ ] I have added my new module in the BOM

Checklist for adding new embedding store integration

[ ] I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
[ ] I have added my new module in the BOM

Checklist for changing existing embedding store integration

[ ] I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

Examples PR: https://github.com/langchain4j/langchain4j-examples/pull/106

This release also includes a fix for https://github.com/langchain4j/langchain4j/issues/1506

@tjake those 2 comments are not critical, if you won't be able to address them till wednesday, I will merge it anyway to include it in this release


Cleanup command fails for multiple delivered branches

git phlow cleanup failed for the 2nd delivered branch with no reason/explanation
Running the same command again successfully deletes the branch
[praqma.com]$ git branch
  delivered/1136-update-persona-for-mortench3000
  delivered/1227-fix-bad-image-filename
* gh-pages
[praqma.com]$ git phlow cleanup
Deleted local branch delivered/1136-update-persona-for-mortench3000
Could not delete branch delivered/1227-fix-bad-image-filename
[praqma.com]$ git phlow cleanup
Deleted local branch delivered/1227-fix-bad-image-filename

@mortench3000 The command only deletes branches with git branch  -d which means unmerged changes are not deleted. Sometimes if the branch was delivered using a rebase a new sha will be created and git cannot see if the commit of the branch has ended up on master. For this case I believe that it is because we do a fetch at the end of the command, to prune untracked branches, and therefore updates what branches have been integrated. The second run will then register that the merges was changed, and delete the branch. I will say this is expected behaviour.

Ok - If the command fails, just run it again.
Thanks for the technical explanation though...

However it could be a little more clear


Streaming file encryption

Going to punt on this feature for now. I want to get the basics of webtorrent/instant.io as quickly as possible and this feature is a distraction.
The WebRTC transport is already encrypted, and if users really want they can encrypt their files before sending them with instant.io.

Re-opening, since this feature is a requirement for #18.

FYI there is a lib developed, which uses NaCl encryption on top of WebRTC to encrypt files end-to-end in a secure way (so the signalling servers cannot do MITM attacks): https://github.com/saltyrtc

hey, just saw this -  I have a module that would be suitable,
https://github.com/dominictarr/pull-box-stream
but ideally, we might want to modify that a little bit, so that encrypted blocks are a) aligned to bit torrent blocks, and seekable. currently pull-box-stream can just encrypts streaming blocks, but makes them whatever length the source provides the buffers as. That means you could still seek from the beginning, but it would be much more neat to be able to seek from any point.
what we'd have is some size block that was nice for eg video, so that you can start streaming, that aligned with the bit torrent block size, because you need to jump to the encrypted blocks to decrypt them.
Hmm, actually, since fixed sized blocks work best with bit torrent, you can have something simpler than box-stream. Anyway, happy to help with this if you decide it's time.

@dominictarr I don't have time at the moment for this, but thanks for sharing the link to pull-box-stream. I didn't know that there was a way to run libsodium in the browser via chloride, so that's good to know!

cool, I think the question is just: is there a way to predict the blocks that will be requested? if yes, then this is easy.

the block boundries, i mean


Tab expansion in beta4

System Details

posh-git version/path: v1.0.0-beta4
PowerShell version: tried with both 6.2.5 and 7.0.0
Git version: 2.26.2.windows.1
Operating system name and version: Windows 10, Version 2004

Issue Description
I am experiencing a problem with the tab expansion.
I have Set-Alias g git in my $profile and tab completion with g worked in beta2 and beta3, but now broken in beta4. Simply does nothing if I type g fetTab.
Also, if I set the UseLegacyTabExpansion to $True it starts to work again.

It turns out PowerShell's built-in Register-ArgumentCompleter does not take into account aliases to native apps that have registered completers. I think the fix for this is pretty easy.  So we will need to pass in any aliases we discover for git,tgit,gitk.

FYI, I'm getting a PR ready to fix this but there is one big caveat.  The code to register argument completers for apps and their aliases, happens once during the load of the module.  So you will need to ensure your aliases are defined in your profile script before you import posh-git.


PV value precision formatting

for the home page: when live monitor box is checked, update the toExponential() call to use only 2 digits since space is limited
For a single PV details page: if the PV precision value from web socket is not blank and not zero, use that to round PV value. Otherwise, show full value from web socket

https://github.com/ChannelFinder/pvinfo/pull/34


Add Mouath Ibrahim to Contributors list

Thank you for this.

@iMouath, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I accepted it?

@Roshanjossey It was an awesome and straightforward experience, following the tutorial you setup was easy and clear even though that it was copy and pasting the commands it's still learning because of how well written and informative the commands are.
The whole thing got me excited to look for more projects to contribute I found this website dedicated to get you started on first contribution by listing projects with issues that labeled for beginners
http://up-for-grabs.net
I'm native Arabic speaker I'll try to add translations for your project.
Thank you again
cheers.

@iMouath we also have a slack team to help / mentor people trying to contribute to other projects.
You can join us by going to https://firstcontributions.herokuapp.com
We're also trying to build a web app where people can easily find projects they'd love to contribute to


Macos build issues

Hello,
I tried to build the library on MacOs (please not i cannot have root access under any circumstance and i only have access to files in my home folder)
the compiler:
➜  ustl git:(master) gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.0.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

when running your install command:
➜  ustl git:(master) ./configure && make install
Installing /usr/local/include/ustl/bktrace.h ...
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [/usr/local/include/ustl/bktrace.h] Error 64

when running make:
➜  ustl git:(master) make
    Compiling bktrace.cc ...
clang: error: unknown argument: '-fno-enforce-eh-specs'
clang: error: no such file or directory: '@TGT_OPTS@'
make: *** [.o/bktrace.o] Error 1

The final usage i hope to achieve with your library is on multiarch and multi-platform armeabi, armeabi-v7a, arm64-v8a x86 and x86_64.
No dynamic linking possible.
Can you help with building the static library?
It is possible to move to a proper linux environment if this is a lost cause on mac, but it is odd that it won't build...

Can you help with building the static library?

A static library can be built by passing --with-static option to configure. If you do not want the shared library, also pass --without-shared option. This how I always build uSTL for myself, so this use case should work well.

install: illegal option -- D

Yeah, that's the problem with BSD-based systems. You always have to live in the stone age.
install -D creates necessary directories in the installation path. In many cases, it is probably possible to do without it, when, say, installing to /usr/include that already exists. I can add a configure check that will remove the -D, but perhaps you can investigate whether you can get a decent version of install instead. Just because your OS wants to live in the stone age, doesn't mean you have to.

➜  ustl git:(master) gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents
/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.0.0 (clang-9<IP_ADDRESS>)

Your problem seems to be that you have a gcc that says it is clang version 9. Schizophrenic compilers are not supported :) It seems to actually be gcc 4.2.1. Please try running gcc -dumpversion and see if it outputs something sane.

indeed it was 4.2.1
thanks for your help


abnormal mechanical nociception (MP:0002734)

If this is a request for a new term, please provide us with the following information.

Preferred term label (e.g., asplenia)

a. increased mechanical nociception
b. decreased mechanical nociception

Synonyms (e.g., absent spleen)

Textual definition (the definition should be understandable even for non-specialists. Include a PubMed ID or URL(s) to refer to any relevant article(s) that provides information about the suggested term).

a. increased capability to sense pain elicited by mechanical stimulation
b. increased capability to sense pain elicited by mechanical stimulation
pmid:25704616

Any additional notes to clarify the meaning or use of the term. Please provide a PubMed ID or URL(s) for the source of this information.

Suggested parent term (Please look in the hierarchy of the MP using the MP Browser or other browsers such as OLS and find the place in the MP where the new term best fits)

a. & b. abnormal mechanical nociception (MP:0002734)

If you would like a nanoattribution, please indicate your ORCID id or provide a label such as MGI:sbello (organization, first initial-last name)

RGD:sjwang

MP:0020955 - increased threshold
MP:0020954 - decreased threshold


Load multiplayer doesn't work for the second time

Steps to reproduce:

Load game
Quit to main menu
Load game again

Seems like it's because the events has been bound on the first init (MultiplayerCoordinator.OnClientStateChanged) and now they got processed before client is connected.


Razor .mpack version generation for VSMac

Currently it seems that the .mpack for VSMac addin is produced with version 42424242. There used to be an MSBuild property DotNetUseShippingVersions which would generate a proper version such as <IP_ADDRESS>.
Also we need the Razor assemblies inside the .mpack to have proper versions and not <IP_ADDRESS> otherwise they fail to load because we reference the wrong version.
cc @davidkarlas

Are you looking at local builds or the official build?

The CI that produces the .mpack, but it would be nice to know what to pass on the command line to emulate the official build locally as well. We need to be able to produce the right versions as 42 is useless to us.

I'm guessing the logic somewhere here is relevant:
https://github.com/dotnet/arcade/blob/d71c43c7efee344c50724e8a94251f56b2a71194/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L18-L25
We probably need to somehow tie AddinVersion to this generated build number.

Here's what I see from a recent build: https://dev.azure.com/dnceng/internal/_build/results?buildId=245555&view=results

<Addin id="RazorAddin" namespace="Microsoft.VisualStudio.Mac" version="8.0.20190701.2" name="Razor Language Services" author="Microsoft" description="Language services for ASP.NET Core Razor" category="Web Development">
<Runtime>
<Import assembly="Microsoft.VisualStudio.Editor.Razor.dll" />
<Import assembly="Microsoft.CodeAnalysis.Razor.Workspaces.dll" />
<Import assembly="Microsoft.AspNetCore.Razor.Language.dll" />
<Import assembly="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.dll" />
<Import assembly="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.dll" />
<Import assembly="Microsoft.AspNetCore.Mvc.Razor.Extensions.dll" />
<Import assembly="Microsoft.CodeAnalysis.Razor.dll" />
<Import assembly="Microsoft.VisualStudio.Mac.LanguageServices.Razor.dll" />
<Import assembly="Microsoft.VisualStudio.Mac.RazorAddin.dll" />
</Runtime>
<Dependencies>
<Addin id="::MonoDevelop.Core" version="8.0" />
<Addin id="::MonoDevelop.Ide" version="8.0" />
</Dependencies>
</Addin>

Oh interesting! That's what I need. I was looking here: https://github.com/aspnet/AspNetCore-Tooling/pull/697/checks?check_run_id=155788066

Now the question is: what did your build do right and what did my build do wrong? :)

In other words, I need to produce an .mpack with the correct versions (as in your screenshots above) for this PR: https://github.com/aspnet/AspNetCore-Tooling/pull/697
and in the future in all other places of course.

In other words, I need to produce an .mpack with the correct versions (as in your screenshots above) for this PR: aspnet/AspNetCore-Tooling#697
and in the future in all other places of course.

O_o I must be missing something. Why do you need to produce the mpack separately? 😄

For debugging purposes when making local changes :) It's not just for this PR.
From trial and error we've found that build.cmd /p:OfficialBuildId=20190702.01 /p:VersionSuffix= seems to do what we want, but it fails the build after producing the .mpack, so it feels like it's not the right solution.
There's an e-mail thread with @tmat going on, I'll update the issue when we have a good solution.

I've tried again and build -binaryLog /p:DotNetUseShippingVersions=true seems to be working fine. Not sure why it wasn't working before.
Apologies for the noise.

For debugging purposes when making local changes :) It's not just for this PR.

Ah, just so you know we publish all of the symbols to symweb with source link so unless you need debug optimized bits that should definitely get you 90% of the way.


Sema: Look through FunctionConversionExpr in getEnclosingApplyExpr()

Follow up to https://github.com/apple/swift/pull/61481.
There is already a test case exercising this case but there happens to be no observable difference in the compiler output because noasync diagnostics already gracefully fall back to looking up the diagnostic SourceLoc another way.
Resolves rdar://100883622.

@swift-ci please test


Tool bugs when editor loses focus

If the editor loses mouse capture and does not trigger the MouseUp event, this causes tools to break - thinking they are still operating even though the action should have been aborted. Tools should handle the LostMouseCapture event to account for this.

fixed


Fixed the CORS wildcard activation

This works for me, looks sensible and is easy to understand. Thanks!


Add new tslint rules and do some refactoring.

I'm proposing some changes here (NO FUNCTIONAL CHANGES ONLY DECORATION):

New more strict rules (same as the app templates).

Make some private methods private

Extract some util methods in a separate util file under shared folder, since there will be new page-service that will need them too.

Create new Config.ts file under shared folder for the same reason.

I would go much further with the refactoring, but I would like to negotiate it with @borisKarastanev first

I think Gruntfile.js could use some eslint ❤ too (as a separate PR).


Upgrade to newest version of NextJS

We are behind on our version of NextJS, this brings about a need to verify if Relay will work along with Next
Thomas from CAS made a document on their upgrade here:
https://docs.google.com/document/d/1RiLHdwIs9POaQH5Nj2igzdPasGnKjK1L35ljQqRr_0c/edit#

Nothing for PO to review so moving to sprint done


[WIP] Feature/crd humio view

Fixes #207
Changes
Added HumioView CRD
Name and Connections can now be set.
Description is omitted for now as we would need an update to the view api
Controller
Added support for adding, updating and deleting views
Tests performed
I have run all tests via "make test".
I have also spun up a humio cluster via the hack tools and observed the changes to the humio views in the cluster.
Please let me know if anything is missing or should be changed.

I can see that the e2e tests are failing where running make test works.
I will gladly accept some hints on how to proceed 👍

I just had a look at the failing test, it looks like it's failing because the Humio View test tries to create a repository that already exists. We should change the repositoryKey and repositoryToCreate resources to be unique so that it doesn't conflict with the repository test.
Humio Resources Controllers Humio View
  Should handle view correctly
  /home/runner/work/humio-operator/humio-operator/controllers/humioresources_controller_test.go:343
STEP: Creating a shared humio cluster if it doesn't already exist
STEP: Creating the repository successfully

• Failure [0.008 seconds]
Humio Resources Controllers
/home/runner/work/humio-operator/humio-operator/controllers/humioresources_controller_test.go:35
  Humio View
  /home/runner/work/humio-operator/humio-operator/controllers/humioresources_controller_test.go:342
    Should handle view correctly [It]
    /home/runner/work/humio-operator/humio-operator/controllers/humioresources_controller_test.go:343

    Expected success, but got an error:
        <*errors.StatusError | 0xc000f4aa00>: {
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "humiorepositories.core.humio.com \"humiorepository\" already exists",
                Reason: "AlreadyExists",
                Details: {
                    Name: "humiorepository",
                    Group: "core.humio.com",
                    Kind: "humiorepositories",
                    UID: "",
                    Causes: nil,
                    RetryAfterSeconds: 0,
                },
                Code: 409,
            },
        }
        humiorepositories.core.humio.com "humiorepository" already exists

    /home/runner/work/humio-operator/humio-operator/controllers/humioresources_controller_test.go:389

Ah, that should be an easy fix. Will you go ahead or should I @kaspernissen ?

I think I might have it. make test succeeds locally (it also did in the initial version, so no guarantee), let's see if e2e succeeds here as well 🙏

Unfortunately, didn't fix the failing test. We found the issue, which seems to be an addition in the cli package, that now results in the expectation to not match; https://github.com/humio/cli/blame/dea38288df5de0e5e4c52a049207b7322ba1bc4c/api/repositories.go#L15
@mahlunar is working on a fix.

Fixed. The Repository Id was the culprit which failed on assertions. I have added a new struct in the test file that excludes the Id field. Let me know if this is ok.

Rebase done and updated manifests.


Add Symfony PhpUnit recipe files to ignore files

The symfony recipe create or phpunit bridge creates a bin/phpunit file which should also add to ignore stack trace. In bundles also the symlinked vendor/bin/simple-phpunit script is sometimes used so also this should be ignored.

@owenvoke Can you release this one?

@owenvoke @nunomaduro did stuble over some other issue so maybe wait for the release to avoid to much work on your side :)

@nunomaduro the following could be added to the release if accepted:
https://github.com/nunomaduro/collision/pull/182
https://github.com/nunomaduro/collision/pull/183
https://github.com/nunomaduro/collision/pull/184


"Configuration" UI in Azure Portal doesn't actually save all the newly entered values

Steps to repro:

Goto your Static Web App in Portal, goto "Configuration" tab.
Try adding e.g. 5 new config values.
Press Save.

The page says everything was successfully saved, but if you refresh the page, some of your newly added params will be missing.
Specifically, it seems to be saving not more than two values at a time.
Also, the page keeps saving previously entered values in browser's autocomplete cache and then keeps showing those values as suggestions. That is a huge security issue. You never want your secrets to be silently cached anywhere!

The bug is the same as #121.
Turning off autocomplete for these fields is a good idea.
@takyyon @miwebst

Closing as duplicate.


[Task]: Create new API for Git repo limit exceeded data

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Today, we are using the applications/new API to get the information of the 3 connected repos which is shown on the Git repo limit exceeded modal if a user tries to connect the 4th repo to Git. This API is quite heavy hence we need to create a separate API for the same providing only the required information along with the workspace name.

There should be a different api for release-notes too, if it doesn't exist today.

@AnaghHegde  - Is this still valid? Do we need a new API?

@sondermanish Is this required now or can we close it? Where does the repo limit is being checked?


he/she and it

Pretty sure I'd find it more offensive if someone were to call me an "it" as opposed to a "he" or a "she".

Some context:

I would say that “it” works well for Harry the Worm though?
In all seriousness, you are right. If you have another suggestion, please share.
Regarding that, they and it are merely suggestions. Most importantly, they work well
with technical writing as seen on GitHub, but not as much for fiction / stories.
Also: alex just highlights some points of interest. Authors should just see them that way,
alex does not enforce its rules.


hdPath not working

what is the purpose of hdPath while library does not care about it and always returns the first account?
import { DirectSecp256k1HdWallet } from "@cosmjs/proto-signing";
import { stringToPath } from "@cosmjs/crypto";
const mnemonic = "surround miss nominee dream gap cross assault thank captain prosper drop duty group candy wealth weather scale put";
const wallet = await DirectSecp256k1HdWallet.fromMnemonic(
  mnemonic,
  {
    hdPath:stringToPath("m/0'/0"),
    prefix:"cosmos"
  }
);
const [firstAccount] = await wallet.getAccounts();
console.log(firstAccount)

result is:
{
  algo: 'secp256k1',
  pubkey: Uint8Array(33) [
      3, 129,  99, 213, 142,  36, 239, 180,
     26, 198, 236, 184, 247, 160, 135,  96,
     29, 171, 165, 245, 151, 144, 205, 203,
     10, 121, 114, 173,  79,  30,  41, 177,
    251
  ],
  address: 'cosmos1lsagfzrm4gz28he4wunt63sts5xzmczw8pkek3'
}

now i will change the hdPath:
import { DirectSecp256k1HdWallet } from "@cosmjs/proto-signing";
import { stringToPath } from "@cosmjs/crypto";
const mnemonic = "surround miss nominee dream gap cross assault thank captain prosper drop duty group candy wealth weather scale put";
const wallet = await DirectSecp256k1HdWallet.fromMnemonic(
  mnemonic,
  {
    hdPath:stringToPath("m/0'/1"),
    prefix:"cosmos"
  }
);
const [firstAccount] = await wallet.getAccounts();
console.log(firstAccount)

the result is still the same.

Where did you find hdPath as an option? It needs to be plural and takey an array as DirectSecp256k1HdWallet always works with a list of accounts.

 const wallet = await DirectSecp256k1HdWallet.fromMnemonic(
   mnemonic,
   {
-    hdPath:stringToPath("m/0'/1"),
+    hdPaths: [stringToPath("m/0'/1")],
     prefix:"cosmos"
   }
 );

Please also note that a HD path in Cosmos always have 5 components, even if some wallets don't always show them.


docs: deprecate appcast

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Continues #15085 by replacing mention of appcast in the Homebrew Cask docs with an explanation of the :sparkle strategy for livecheck. Also throws in a brief description of :extract_plist for good measure.

Thanks!


[SPARK-49935][BUILD] Exclude spark-connect-shims from assembly module

What changes were proposed in this pull request?
This pr exclude spark-connect-shims from assembly module to avoid it from being included in the distribution when executing dev/make-distribution.sh.
Why are the changes needed?
spark-connect-shims is only used to resolve compilation issues, and it should not be included in the jars directory of the distribution, otherwise, it may disrupt REPL-related functionalities.
For examples:

spark-shell will fail to start

bin/spark-shell --master local
WARNING: Using incubator modules: jdk.incubator.vector
Using Spark's default log4j profile: org/apache/spark/log4j2-defaults.properties
{"ts":"2024-10-11T11:54:03.437Z","level":"WARN","msg":"Your hostname, MacBook-Pro.local, resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface en0)","context":{"host":"MacBook-Pro.local","host_port":"<IP_ADDRESS>","host_port2":"<IP_ADDRESS>","network_if":"en0"},"logger":"Utils"}
{"ts":"2024-10-11T11:54:03.439Z","level":"WARN","msg":"Set SPARK_LOCAL_IP if you need to bind to another address","logger":"Utils"}
Using Spark's default log4j profile: org/apache/spark/log4j2-pattern-layout-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 4.0.0-SNAPSHOT
      /_/

Using Scala version 2.13.15 (OpenJDK 64-Bit Server VM, Java 17.0.12)
Type in expressions to have them evaluated.
Type :help for more information.
             if (_sc.getConf.getBoolean("spark.ui.reverseProxy", false)) {
                     ^
On line 9: error: value getConf is not a member of org.apache.spark.SparkContext
               val proxyUrl = _sc.getConf.get("spark.ui.reverseProxyUrl", null)
                                  ^
On line 10: error: value getConf is not a member of org.apache.spark.SparkContext
                   s"Spark Context Web UI is available at ${proxyUrl}/proxy/${_sc.applicationId}")
                                                                                ^
On line 13: error: value applicationId is not a member of org.apache.spark.SparkContext
               _sc.uiWebUrl.foreach {
                   ^
On line 18: error: value uiWebUrl is not a member of org.apache.spark.SparkContext
               s"(master = ${_sc.master}, app id = ${_sc.applicationId}).")
                                 ^
On line 23: error: value master is not a member of org.apache.spark.SparkContext
               s"(master = ${_sc.master}, app id = ${_sc.applicationId}).")
                                                         ^
On line 23: error: value applicationId is not a member of org.apache.spark.SparkContext
                               ^
       error: object SparkContext is not a member of package org.apache.spark
       note: class SparkContext exists, but it has no companion object.
                    ^
       error: object implicits is not a member of package spark
              ^
       error: object sql is not a member of package spark

SparkR tests on Windows may also fail due to spark-connect-shims being in the classpath.

https://github.com/apache/spark/actions/runs/11259624487/job/31309026637
══ Failed tests ════════════════════════════════════════���═══════════════════════
── Error ('test_basic.R:25:3'): create DataFrame from list or data.frame ───────
Error in `handleErrors(returnStatus, conn)`: java.lang.NoSuchMethodError: 'void org.apache.spark.SparkContext.<init>(org.apache.spark.SparkConf)'

  at org.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:3050)

  at org.apache.spark.api.r.RRDD$.createSparkContext(RRDD.scala:141)

  at org.apache.spark.api.r.RRDD.createSparkContext(RRDD.scala)

Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass GitHub Actions
All Maven test passed on GA: https://github.com/LuciferYang/spark/runs/31405720205

Sparkr on windws test passed on GA: https://github.com/LuciferYang/spark/actions/runs/11291559675/job/31434704406

Manual check:

dev/make-distribution.sh --tgz -Phive

spark-connect-shims is not in either directory jars or directory jars/connect-repl, and both spark-shell and connect-shell can be used normally
Spark shell
bin/spark-shell --master local
WARNING: Using incubator modules: jdk.incubator.vector
Using Spark's default log4j profile: org/apache/spark/log4j2-defaults.properties
{"ts":"2024-10-12T02:56:47.637Z","level":"WARN","msg":"Your hostname, MacBook-Pro.local, resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface en0)","context":{"host":"MacBook-Pro.local","host_port":"<IP_ADDRESS>","host_port2":"<IP_ADDRESS>","network_if":"en0"},"logger":"Utils"}
{"ts":"2024-10-12T02:56:47.639Z","level":"WARN","msg":"Set SPARK_LOCAL_IP if you need to bind to another address","logger":"Utils"}
Using Spark's default log4j profile: org/apache/spark/log4j2-pattern-layout-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 4.0.0-SNAPSHOT
      /_/

Using Scala version 2.13.15 (OpenJDK 64-Bit Server VM, Java 17.0.12)
Type in expressions to have them evaluated.
Type :help for more information.
24/10/12 10:56:49 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Spark context Web UI available at http://<IP_ADDRESS>:4040
Spark context available as 'sc' (master = local, app id = local-1728701810131).
Spark session available as 'spark'.

scala> spark.range(10).show()
+---+
| id|
+---+
|  0|
|  1|
|  2|
|  3|
|  4|
|  5|
|  6|
|  7|
|  8|
|  9|
+---+

Connect shell
bin/spark-shell --remote local
WARNING: Using incubator modules: jdk.incubator.vector
Using Spark's default log4j profile: org/apache/spark/log4j2-defaults.properties
{"ts":"2024-10-12T02:58:17.326Z","level":"WARN","msg":"Your hostname, MacBook-Pro.local, resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface en0)","context":{"host":"MacBook-Pro.local","host_port":"<IP_ADDRESS>","host_port2":"<IP_ADDRESS>","network_if":"en0"},"logger":"Utils"}
{"ts":"2024-10-12T02:58:17.328Z","level":"WARN","msg":"Set SPARK_LOCAL_IP if you need to bind to another address","logger":"Utils"}
24/10/12 10:58:19 INFO BaseAllocator: Debug mode disabled. Enable with the VM option -Darrow.memory.debug.allocator=true.
24/10/12 10:58:19 INFO DefaultAllocationManagerOption: allocation manager type not specified, using netty as the default type
24/10/12 10:58:19 INFO CheckAllocator: Using DefaultAllocationManager at memory/netty/DefaultAllocationManagerFactory.class
Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 4.0.0-SNAPSHOT
      /_/

Type in expressions to have them evaluated.
Spark connect server version 4.0.0-SNAPSHOT.
Spark session available as 'spark'.

scala> spark.range(10).show
Using Spark's default log4j profile: org/apache/spark/log4j2-pattern-layout-defaults.properties
+---+
| id|
+---+
|  0|
|  1|
|  2|
|  3|
|  4|
|  5|
|  6|
|  7|
|  8|
|  9|
+---+

Was this patch authored or co-authored using generative AI tooling?
No

@HyukjinKwon Please take a look If you have time, thanks ~
I have checked the Maven test and SparkR on Windows test on GA, and briefly tested spark-shell and connect-shell after  dev/make-distribution.sh --tgz -Phive. They are all functioning successful with this pr.

Merged to master.

Thanks @HyukjinKwon


error  clang:error  'foo.h' file not found

I tried working with header files in the same directory with the current source code I'm working with, but I get the following error: error  clang:error  'foo.h' file not found. My settings for SublimeLinter are:
{
    "linters":{
        "clang": {
            "args": "-Wall -fsyntax-only -fno-caret-diagnostics",
            "I": [
                // "full/path/to/src",
                "$HOME/local/includes/c"
            ]
        },

        "clang++": {
            "args": "-Wall -fsyntax-only -fno-caret-diagnostics",
            "I": [
                "$HOME/local/includes/cpp"
            ]
        }
    },
}

I noticed that when I add the full path to the current working directory I get no errors (currently commented out) or if I transfer it to $HOME/local/includes/c. I tried adding ${folder} to the I parameters but still get the errors.

SOLVED: Adding $file_path to I solves the problem.


[Unity][Frontend] Import tanh and fix layer_norm

This PR provides some quick fixes for fx_translator to import tanh and fix the error when importing torch.nn.functional.layer_norm.

Thanks @SiriusNEO can you add a unit-test about the fix?


config: Update schema.json -> config-schema.json

This slipped through the rename in 2a5986f7 (schema/state-schema.json:
Add a JSON Schema for the state JSON, 2016-06-01, #481) and the first
round of fixes in dfb85b16 (schema/README: Fix links to
(config|state)-schema.json, 2016-06-13, #498).
Fixes #517.

LGTM

LGTM


Changing title and menu Item color

[X] This is a question about using the theme.
[ ] This is a feature request.
[X] I have updated all gems with bundle update.
[X] I have tested locally with bundle exec jekyll build.
[ ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

Minimal Mistakes version: 4.4.1
github-pages or jekyll gem version: gem version
Operating system: Windows 10

Expected behavior

Change the color of the title and menu item
Steps to reproduce the behavior

I copied the file _masthead.scss (found in _sass\minimal-mistakes\ in the gem installation) into my site under a newly created directory_sass\minimal-mistakes_masthead.scss.
Then I change  .masthead__menu { } and added color: red;
I rerun locally using bundle exec jekyll build.
But the title didn't change color.
I also try to completely removed the content of my _masthead.sass but I still had the same website. Normally with all the sass removed the theme should be broken...
I guess I didn't override correctly or missed a step, but I cannot find what I missed. Any help would be welcome.

Overriding Sass partials found in a theme gem is somewhat limited due to how Jekyll processes them. They're not like _includes and _layouts where you can override a specific file by adding it to your root folder.
To override the Sass you need to copy the entire _sass folder, which defeats the purpose of using a theme gem since you'll have to stay in sync with any changes.
The alternative is to copy /assets/css/main.scss to the same location locally. And then add any style overrides after @import "minimal-mistakes";.
In your case it would look something like this:
---
# Only the main Sass file needs front matter (the dashes are enough)
---

@charset "utf-8";

@import "minimal-mistakes";

// your styles here
 .masthead__menu {
  color: red;
}

Thanks for you quick answer.
I tried to copy locally and change main.scss. (Literally copied your code above).
But the color didn't change. I tried to clear the cache but didn't change anything.

I was just pasting in the CSS you wrote as an example. You'll need write CSS that will actually do something like.
To override the masthead link color you'll need something like .greedy-nav a { color: red; }.

All right, thanks. That' really shows that my skills in css are really low...
You right with your latest code it works perfectly.
I'll now focus on the other changes I need to do in the main.scss file.
Thanks again for your quick help.
You can close this ticket.


CONTRIBUTING.md file mssing.

Hey  @Anishkagupta04 ,
Pranjal here Contributor @GSSoC'24
repository currently lacks a CONTRIBUTING.md file, which is an important resource for guiding potential contributors on how to engage with the project effectively. A CONTRIBUTING.md file outlines the contribution guidelines, coding standards, and procedures for submitting pull requests, thus streamlining the contribution process and ensuring consistency across contributions.
could you assign this to me ?

I would like to work on this issue. Please assign me this task.

@suhanipaliwal you can do
if you don't mind to work with @Pranjalll01 you both together can do

I can work with @Pranjalll01 on this issue. Please assign this issue to me as well. Also, please add the labels of GSSOC'24 and the label of appropriate level (like level 1, 2 or 3) on this issue.

Sure @Anishkagupta04 ,
We don't have any issue.


Survey Property :  postInvisibleQuestions : boolean (default is true)

Prevents hidden question to be submitted.
Possible scenario
Q1. Do you have a car ? a. yes b. no
If yes Q2: What's the color of your car?
Now if no is selected then there's no meaning of Q2

Hi,
Yep, it looks like it makes sense.

I have added clearInvisibleValues property, default value is false. If it is true, survey clears all invisible question values before firing onComplete event or sending data to a server.
Thank you,
Andrew

Tested no issues.


Revert "Make internal scap_procs.c functions static"

This reverts commit 7c433fc30a3ef834165a11d3d9978dacd7ee552d.
It turns out some tests calls these functions directly.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Make some low level scap functions non-static so they can be called from tests.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

3e34f4d Revert "Make internal scap_procs.c functions static"

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.10.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


segmentation fault with to_expr

This causes a segmentation fault:
open expr tactic

example (A : Type) (a : A) : A :=
by do to_expr `(sorry) >>= exact

Also this:
open expr tactic

example (a : nat) : nat :=
by do to_expr `(nat.zero) >>= exact

The changes done this morning have fixed this issue.
BTW, the first example will fail since we don't know what is the expected type for the sorry.
We should use
example (A : Type) (a : A) : A :=
by do to_expr `((sorry : A)) >>= exact

Or use the refine tactic that will elaborate the sorry with respect to the current target.
example (A : Type) (a : A) : A :=
by refine `(sorry)

We can also define a different to_expr that elaborates the given qexpr using the current target as the  expected type.

Here is the to_expr that uses the current target to elaborate the given qexpr
open expr tatic

meta_definition to_expr_target (a : qexpr) : tactic expr :=
do tgt ← target,
   to_expr `((%%a : %%tgt))

example (A : Type) (a : A) : A :=
by do to_expr_target `(sorry) >>= exact

@avigad @dselsam I managed to reproduce the bug after I installed Ubuntu 16.04.
The commit above fixes the problem.


is it working

is this playable project ?

Yes, this is a playable proejct, feel free to copy, fork, edit.

thanks for the reply

looks like very old project

ti thought it about paddling canoe ,,,,,,,,


race condition breaks/subverts table-based 'story'/scenario tests

[Edit]
Upgrading this to a bug.
How to replicate

If the testing project already exists on the dev server, run npm run takedown.
Run npm run setup to set up a brand new project.
Run tests with (I believe) 80cc3edf8ab064f74e5b790219a83af543c9d59a.
The second signature question id page will time out.
See https://github.com/plocket/docassemble-MAEvictionDefense/runs/1742130312?check_suite_focus=true

Why?
The signature canvas page times out because the rental agreement page eats up the signature rows for some unknown reason. This is how it happens:

rental agreement loops through the first time. The selectors in getField() find the most specific fields possible based on the values given. The 'continue' button is hit.
The fact that the next page hasn't finished loading - that we're still on the rental agreement page - is not detected. The code thinks the 'continue' action was completed successfully.
The rental agreement page goes through the loop again. This time, any /sign rows somehow catch something. There is no var_name or choice_name value, just the set_to value of /sign. I think the others are undefined. I'm not sure what they catch, though. I do know they are INPUT fields with type="hidden". That field uses up any and all /sign rows in 'setting' the value of that field. The 'continue' button is 'hit' again.
The rental agreement page goes through the loop a third time. This time it catches no variables and hits 'continue' again.
The next page is reached.
When the signature page is found, there's no /sign row for it.

Notes

We need to be able to find hidden fields. Most fields are hidden so that they can be interacted with, but so that only pretty stuff is actually visible.
There's something that's not being awaited. If you put delays in certain places, an error will be caused by the page navigation even though the process of finding the nodes has not completed and the code should still be waiting for the next page DOM content to load. I've checked all our functions. None of the ones affecting this were missing awaits. When I added awaits to the ones we (I) had missed, this didn't solve the problem.

[Orignal post]
To make tables work as 'stories', we need the variable rows to be able to be listed out of order. That's fine most times, but we've run into at least one situation where we can't track down a race condition, requiring the developer to break the table into two parts. It means they need a When the terminal question id is "some id" step to stop early, then put in their own And I wait 2 seconds before creating another table for the rest of the variables.
For those tests order does matter, which is not what we want from stories.
Can we somehow allow some way for developers to influence this situation? An extra wait after hitting 'continue' for some specific pages? An extra wait at the start of some pages? An extra wait after setting a field?

The current table-based steps now loop until they find the target id, so the specific race conditions we faced are solved - the test just loops again till it gets the next page. It'd be great to know if that could create an infinite loop, but since we don't know what the problem was, we don't know how to find out if that would be an issue.
Regardless, we might table this for now as we don't have any current situations we can use to troubleshoot issues.

Note: I observed something about the rent agreement race condition - it seems to only happen on the first test that goes through that step just after setup. Logs were this:
First after setup, then the following test:
(* = setting a variable including buttons, > = continuing, ~ = signature)
..*>**>*>******>****>**>***>*>>>>**>*>>**>>****...>*>****>*>>**>**>***>>>>*>**>**>>**F
..*>**>*>******>****>**>***>*>>>>**>*>>**>>****...>****>*>>**>**>***>>>>*>**>**>>**~>**>*.....

That deviation is the rental agreement page. It might load a second time or something? What variable is it setting?

The table/story-based tests don't have this problem any more, but the regular sentence-type steps still would.

The table/story-based tests don't have this problem any more, but the regular sentence-type steps still would.

This is no longer solved. The bug in #115 requires us to differentiate between continuing and other actions, and the only way that will work is if we can successfully figure out when a page has continued. Latest idea if we can work out the kinks:
Make sure the page has navigated before moving on...? This only works if all buttons set with variables are navigation buttons so we can reliably test for that. Do we know that's true for a fact? Certainly some buttons will not navigate, but maybe we can count on variable-setting buttons to do so.

This is no longer solved. The bug in #115 requires us to differentiate between continuing and other actions, and the only way that will work is if we can successfully figure out when a page has continued. Latest idea if we can work out the kinks:
Make sure the page has navigated before moving on...? This only works if all buttons set with variables are navigation buttons so we can reliably test for that. Do we know that's true for a fact? Certainly some buttons will not navigate, but maybe we can count on variable-setting buttons to do so.

Just had a potentially freakin' brilliant idea - when a column in the table does not have a value, shall we give it one? At least for the var_name? That might prevent the whole thing from being an issue because maybe then these fields won't be found!

Just had a potentially freakin' brilliant idea - when a column in the table does not have a value, shall we give it one? At least for the var_name? That might prevent the whole thing from being an issue because maybe then these fields won't be found!

 I'm working on a solution I think will actually deal with this. Hope it won't create an infinite loop. May want to put limiters on it. At the end of the loop in the data step:
// Already there:
    remaining_vars = await custom_timeout;
    scope.remaining_vars = remaining_vars;
    expect( Array.isArray(remaining_vars) ).to.be.true;  // in case it times out
    ({ question_has_id, id, id_matches } = await scope.examinePageID( scope, target_id ));

// New stuff
    // Attempt to solve weird race condition issues where page has not properly continued
    while ( id === prev_id ) {
      await scope.page.waitFor( 50 );
      ({ question_has_id, id, id_matches } = await scope.examinePageID( scope, target_id ));
    }
    prev_id = id;  // Prep for next loop

Hope to make a PR soon.

Welp, that won't work by itself because it will loop infinitely if the next page has the same id. For example, with something being asked with an index variable or the like (looping through the same question for different objects).
What to do instead? URL? Worth a shot. Glad we thought of it before it happened, though.


C2-66 Update Schedules Endpoints

This PR correlates to ticket C2-66 which deals with changing the schedules endpoints and operations to match the API doc.
Changes

Added a new GET operation to retrieve a specific schedule from the database depending on the year passed with it.
Added a new PUT operation to update a specific schedule from the database depending on the year passed with it. I have only tested sending back the whole schedule with the updated part added to it already.
Added new routes for these operations in main.
Added the number registered field to the schedules struct.
Updated the generation workflow to insert the generated schedule into the database, that was missing from last sprint

LGTM!


Added ability to include exif data for iOS and Android

Thanks for submitting a PR! Please read these instructions carefully:

[X] Explain the motivation for making this change.
[X] Provide a test plan demonstrating that the code is solid.
[X] Match the code formatting of the rest of the codebase.
[X] Target the master branch, NOT a "stable" branch.

Motivation (required)
This adds the architecture for iOS and Android to optionally offer the ability to include exif data with the selected photos. The requires iOS library permissions, hence includeExif defaults to false.
Test Plan (required)
These changes will be released to several thousand users in our production application via our fork.

Need to do more regression testing, but would like some initial feedback from reviewers.

Added iOS 13 and below support for Exif data. (still needs permissions). @Johan-dutoit could I get some initial feedback on this? Writing a comprehensive test plan now for all the scenarios, which I will manually QA and attach videos.

@Johan-dutoit because PHAsset.fetch needs permissions, the permission dialog will appear when that native code is executed, maybe it's better to default includeExif to false when permissions are NOT granted, and make a note on the README that includeExif requires permissions to be asked before you open the picker to work. Let me know your thoughts

I am waiting for this update.

@ansarikhurshid786 Want to give this a peer review (CR) then maybe we can get it through faster? Waiting for mod to give feedback on code, then will upload the QA I did of scenarios.

@lukebrandonfarrell  how long it will take to available?

@ansarikhurshid786 I'm waiting on a mod to give me initial feedback @Johan-dutoit ??

Do you want me to upload QA scenarios first @Johan-dutoit ? I was thinking a first round of CR, incase there are any changes, then test plan / QA scenarios, that would make more sense to me

@Johan-dutoit can you please give feedback and done it as soon as possible. i am eagerly waiting for this update.

@lukebrandonfarrell do this pr only include exif with timestamp only? I am looking for latitude and longitude from exif data

@ansarikhurshid786 This PR only adds timestamp, but it adds a structure to allow easy addition of any permission-required metadata, if you want location it will be pretty straightforward to add

@lukebrandonfarrell I branched off your p/r to return the local asset id for videos and images on iOS. I'm not sure if the flag includeExif should be renamed or I should add an additional flag because to acquire the id it needs to have permissions.

Let's go with includeExtra before merging this (along with the time change).  We can move forward with additional 'extras' once this is in.

@lukebrandonfarrell sounds good. thanks a lot for your work on this. I'm also away this week for Web Summit so won't be active much either.

@Johan-dutoit Can you re-review the requested changes?

@Johan-dutoit Still need a final review on this if you have time? Since it was from your recommendation to add UTC it would be good to get a quick thumbs up or thumbs down on the approach I implemented. Thanks

:tada: This PR is included in version 4.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

hey @lukebrandonfarrell @Johan-dutoit , was just checking in on this. awesome to see that it was released 😎  what are the next steps on merging the second p/r (https://github.com/Qeepsake/react-native-image-picker/pull/1)?

@helenaford Any chance we could open that PR against this repo, and then I'll review it, and merge, tbh looks good to me!

@lukebrandonfarrell sure,  will look into this over the next few days 😎


Avoid colored small icon on action bar

Hi!
I would know if there is a way to change the action bar icon for the notification, I get my colored launch icon on notification bar, but it not should be colored, isn't it?
Thank you in advance!

#132


Allow offline editing in Remote-WSL

After successfully opening a VSCode editor in Remote-WSL mode and then some time after, I lose network connectivity, I want the editor to remain usable.  The current behavior brings up the Disconnected. Attempting to reconnect  modal. After dismissing the modal, the modal returns almost immediately, making it impossible to continue editing. I want to be able to continue editing the file until network connectivity is restored. Only VSCode features dependent on the network  should be disabled

@ozimos Sorry for the slow response, I think I misunderstood this issue when I first read it. Do you use the regular WSL on your local machine? What do you mean "then some time after, I lose network connectivity"?

Apologies for the muddled issue description. Yes, I use WSL2 on my windows machine. No, I do not turn off the wifi. But sometimes, the internet connection becomes unstable or goes down completely. At such times VSCode displays the Attempting to reconnect modal. When the modal is closed, it pops up immediately or shortly thereafter. While the modal is open, I cannot continue typing in the text editor. So after typing a few letters the modal pops open, I close it, type a few letters and the cycle repeats. I will try to reproduce by turning off my Wifi

I have investigated this and pushed https://github.com/microsoft/vscode/commit/bb01438efce6d7cb91a40543fd5b6911031a481b to log more information when disconnection occurs. Here is what I do:

I open a new WSL window
I go to the Windows Network Adapter Settings and disable my Ethernet network (the only active one besides vEthernet(WSL) ).
the VS Code windows continues to work correctly and everything is fine
I go and re-enable the Ethernet network
the browser WebSocket disconnects which sends us in the reconnection loop

This is what I see with the extra logging that I just pushed:
[2021-06-09 19:13:24.642] [renderer3] [info] [remote-connection][ExtensionHost][c2db8…][reconnect] received socket close event (wasClean: false, code: 1006, reason: ).
[2021-06-09 19:13:24.694] [renderer3] [error] {"isTrusted":true}
[2021-06-09 19:13:24.696] [renderer3] [info] [remote-connection][ExtensionHost][c2db8…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
[2021-06-09 19:13:24.696] [renderer3] [info] [remote-connection][ExtensionHost][c2db8…][reconnect] resolving connection...
[2021-06-09 19:13:24.696] [renderer3] [info] [remote-connection][ExtensionHost][c2db8…][reconnect] connecting to <IP_ADDRESS>:45139...
[2021-06-09 19:13:24.696] [renderer3] [info] [remote-connection][Management   ][709a5…][reconnect] received socket close event (wasClean: false, code: 1006, reason: ).
[2021-06-09 19:13:24.697] [renderer3] [error] {"isTrusted":true}
[2021-06-09 19:13:24.697] [renderer3] [info] [remote-connection][Management   ][709a5…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
[2021-06-09 19:13:24.698] [renderer3] [info] [remote-connection][Management   ][709a5…][reconnect] resolving connection...
[2021-06-09 19:13:24.698] [renderer3] [info] [remote-connection][Management   ][709a5…][reconnect] connecting to <IP_ADDRESS>:45139...
[2021-06-09 19:13:32.773] [renderer3] [info] [remote-connection][Management   ][709a5…][reconnect] reconnected!
[2021-06-09 19:13:32.789] [renderer3] [info] [remote-connection][ExtensionHost][c2db8…][reconnect] reconnected!

And I can confirm that the WebSockets are being closed using the Network Tab:

@aeschli I would first ask that maybe you can investigate if WSL is the root cause of the closing WebSockets. If WSL is not the root cause of the socket disconnect, then I think we need help from @deepak1556 and create an issue for Chromium.

Not sure if something has changed, but I'm not able to reproduce a disconnect. I tried the steps from https://github.com/microsoft/vscode/issues/121799#issuecomment-857881313, tuning of th WSL Ethernet Adapter, Airplane mode, WIFI disconnect. I get reconnected correctly.
Closing the issue for now.

@alexdima Hm, I don't have a wired network adapter and would first have to organize/buy an USB-3 adapter/dock...
Do we want to extract the 'enable adapter triggers disconnect' into a new issue? I'm nor sure if/how it relates to the original reported issue.


Fix FOUC issue with root gradient

This quick fix prevents a rare FOUC that sometimes results in following occlusion glitch:

by delaying that root gradient until the page loads.

Thanks, @dvdsgl. It's been a cool project to contribute to! 😈


Create codeql-analysis.yml

Great work 😀

@akallabeth looks good overall but I think this might generate some noise once it's really active and the first results are detected.


fix(date-picke): close range datepicker after clicking elsewhere on page

Overview
Resolves  #772
Close the date picker icon when this component loses focus
Added
Removed
Changed
Testing / Reviewing

Hi @asudoh, I don't know exactly if there is a side effect of the code I deleted,, but when we click on the start date, and then on the end date the date picker is always displayed, and it works

Thanks @rezak-otmani and @alisonjoseph for diving into this topic! Here’s what I see with @rezak-otmani’s change:

And here’s what I expect:

@alisonjoseph is right that the usage of that option is not something Flatpickr intended, but the code was to prevent date picker from being closed in the scenario I brought up. Flatpickr has the code to close the dropdown in that scenario, and cannot be disabled unless we temporarily set inline option.
Hope it makes sense to everybody. Please don’t hesitate to bring up if there are any questions. Thanks!

@alisonjoseph can you review again and see if you're still seeing the issue?

LGTM now! ✅


can it stop printing not requested information?

when i restore a ckpt, I found that there is an automated printing that:
INFO:tensorflow:Restoring parameters from checkpoint/fnn/params.ckpt-37000
can i stop this?

this is better question for stackoverflow (I usually pipe output of TensorFlow through "grep -v" to stop unwanted output)


fixed broken link for quint-cheatsheet.pdf in README.md

Hello :octocat:
I've fixed the broken quint-cheatsheet.pdf link in the README.md file.

Thank you!!


Use swc instead of tsc

ref https://github.com/flatgeobuf/flatgeobuf/issues/235

Won't do, it doesn't actually do type check.


Generate complete tree math test vectors

This just extends the tree math KAT so that it generates complete outputs.  Right now, it only generates results for half of the tree.
NB: I was not able to build OpenMLS, so I don't know if this patch actually builds.

@kkohbrok - It looks like the known-answer test JSON file needs to be regenerated.  Is there an easy way to do that?


Support for "node" config object to include keys like "fs", "module"

Bug report
I am using Antlr4 which was working fine with webpack-4, but after upgrading to webpack-5, it throwed the following error
Module not found: Error: Can't resolve 'fs' in '/Users/Saravanan/projects/frontend/widgets/web/node_modules/antlr4'

As specified here in stackoverflow adding the following in the webpack config will work.
node: {
  fs: "empty",
  module: "empty"
}

But in webpack-5 there is no support to specify those keys in node object, it was specified here in the doc
That implies that i could able to use the libraries that i were using with webpack-4.
I am kind of struck because it blocks my development

What is the current behavior?
Not allowing to specify the node object with keys that was working well in webpack-4
If the current behavior is a bug, please provide the steps to reproduce.
N/A

What is the expected behavior?
Webpack-5 should allow pollyfill the nodeJs options

Other relevant information:
webpack version:  webpack-5-beta-16
Node.js version: node 12
Operating System: Mac Os
Additional tools: Antlr4

resolve: {
    alias: {
      // path to polyfill
      'fs': false
    },
  },

Answer above, feel free to feedback


crash visualstudio 2017 , windos 10 when tesseract 4 is add

i hope i'm following the correct instructor to start this issue , if i'm not please let me know what is wrong so i can avoid it .
hi , i finally install tesseract 4.0 with visual studio 2017 windiws 10 . I have used it with a smaple code and everything worked fine . now im facing this problem

i read this website and it seems like it's a problem in visual studio it self they asked to add this part of code but i still cant get it where to add this code
https://social.msdn.microsoft.com/Forums/windows/en-US/522946b7-cb39-43b3-868d-ae9bde1a458b/application-crash-ucrtbasedll
private static void AbortHandler(int signal)
{
throw new OperationCanceledException();
}
[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
public delegate void SignalHandler(int signal);
[DllImport("ucrtbase.dll", CallingConvention = CallingConvention.Cdecl, SetLastError = true, EntryPoint = "signal")]
private static extern IntPtr SubscribeSignal(int signum, SignalHandler handler);
static void Main(string[] args)
{
SubscribeSignal(20, AbortHandler);
// more code
}

Are you making jokes?

Do you have problem with tessdata? No you don't. So why you created issue in tessdata repository?
Is there problem in official tesseract code? You does not report anything relevant.  So why are you creating issue in tesseract project?


Disable cpu mitigations

Looking at a Phoronix article we can see that there is a decent amount of performance used in mitigating. I think that we should consider these risks and determine if the performance is worth it. I'm planning to update the docker image, but in 5.19 retbleed is fixed with yet another performance hit.
Things left to do

[ ] Benchmark
[ ] Discuss if these risks are worth taking. (I believe that we should be fine)

Maybe we should wait until we have system configuration module so we can easily just put that in there

oops


Document process launching arguments with aim of cross-machine rationalization

Original issue: https://charm.cs.illinois.edu/redmine/issues/126

The handling of +p, ++p, +n, +ppn, ++ppn options are inconsistent across various machine layers. We need to clearly understand where and how these options are handled on various machine layers (net, LRTS-based, others), with and without SMP. The goal is ultimately to rationalize the handling of these arguments across systems to provide a consistent interface for application users.

Original author: Abhishek Gupta
Original date: 2013-04-05 19:44:31

https://wiki.engr.illinois.edu/display/ppl/Process+Launch+Parameters

Original date: 2017-10-06 15:20:49

This likely ends up being obviated by the shift to hwloc-driven launch

Original date: 2018-02-01 05:42:47

hwloc launch parameters obviate the need for this


Create Configuration based off current Sysmon Configuration

Can you create a module to dump the current configuration and write it to a compatible xml file?

I would need to be with parsing the output of sysmon.exe since the filters and rules are in binary format and Mark is not sharing the format
Sent from my iPhone

On Feb 20, 2017, at 5:42 PM, Kyle Weller<EMAIL_ADDRESS>wrote:
Can you create a module to dump the current configuration and write it to a compatible xml file?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[LLVM] Encapsulate LLVM target for use with LLVM libraries

See https://github.com/apache/tvm-rfcs/pull/83

Thanks @kparzysz-quic . Reading the implementation it is unclear how cl::opt is restored atm, is it something that we need to continue work on?

@kparzysz-quic lmk when you need a review here--it's draft so i've been ignoring it

This was a prototype/proof-of-concept that was evolving with the RFC, so the commit history is a bit messy.  I replaced this by https://github.com/apache/tvm/pull/12140.


Maven Repository Unavailable

Hi there,
Your maven repo are unavailable . Check this out please!

Hi Jorge,
Everything looks good on my end, can you paste here the error you are getting?

Additionally, can you give me the version of Android Studio, Gradle and its Android plugin you are currently using?

Hi!
Android Studio Version: 1.5.1
Gradle: 1.5.0
Android plugin: Last version
Error:
Show in File
Show in Project Structure dialog

Error:A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugCompile'.
   > Could not resolve me.villani.lorenzo.android:android-cropimage:1.1.0.
     Required by:
         bookball-android:app:unspecified
      > Could not resolve me.villani.lorenzo.android:android-cropimage:1.1.0.
         > Could not get resource 'http://lorenzo.villani.me/android-cropimage/me/villani/lorenzo/android/android-cropimage/1.1.0/android-cropimage-1.1.0.pom'.
            > Could not GET 'http://lorenzo.villani.me/android-cropimage/me/villani/lorenzo/android/android-cropimage/1.1.0/android-cropimage-1.1.0.pom'.
               > The target server failed to respond

Gradle:
repositories {
mavenCentral()
maven {
    url 'http://lorenzo.villani.me/android-cropimage/'
}

}
...
compile 'me.villani.lorenzo.android:android-cropimage:1.1.0'
...

I can fetch http://lorenzo.villani.me/android-cropimage/me/villani/lorenzo/android/android-cropimage/1.1.0/android-cropimage-1.1.0.pom without trouble.
Can you run something like curl -L http://lorenzo.villani.me/android-cropimage/me/villani/lorenzo/android/android-cropimage/1.1.0/android-cropimage-1.1.0.pom and check that it prints the contents of an XML file?

I had the same issue, importing the graddle plugin.
My specs are:
Android Studio Version: 1.5.1
Gradle: 1.5.0

@lvillani yes it prints.

I'm trying to reproduce the issue. Until I get this sorted out I think that a possible work-around is to clone the repository locally and add android-cropimage as a compile-time dependency. You can follow the structure of this repository, see for example:

The master build.gradle
The build.gradle file used in the example project

Unfortunately I cannot reproduce the issue locally. @jzeferino @jmspt Are you behind a corporate proxy/firewall?

For some reason its working now!
Thank you for all.

:+1:

Failed to resolve: me.villani.lorenzo.android:android-cropimage:1.1.2

@almas-alright Make sure it's not a temporary problem on your end.

Thanks a lot for Reply me,
Now it works fine for me, a gradle problem occured.
On Mon, Aug 8, 2016 at 4:28 PM, Lorenzo Villani<EMAIL_ADDRESS>wrote:

@almas-alright https://github.com/almas-alright Make sure it's not a
temporary problem on your end.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lvillani/android-cropimage/issues/57#issuecomment-238198792,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvJLLLwvoEVLy4IYtZ7AInBr0rTcVhvks5qdwTVgaJpZM4HCMtg
.

--
Almas alright http://bit-bytetech.com

Having same problem now: Error:(449, 13) Failed to resolve: me.villani.lorenzo.android:android-cropimage:1.1.2
Have tried 1.1.0 and 1.1.1 also. Am including the repo like follows:
repositories {
maven { url 'http://lorenzo.villani.me/android-cropimage/' }
}


Did you ever have decent programming lessons before releasing this rubbish?

You can't convert python to lua by inserting the keyword "local" in front of each line of code.
Try to convert this one and you'll see:
https://github.com/Broham/suncalcPy/blob/master/suncalc.py
Good free advice from me: delete this project, take a decent programming course and then try again.

Why so serious? Why so toxic?
You can't convert one language to another. And it is doesn't matter, you are converting spanish to english or python to lua. There always will be many limitations.
Who are you to listen your free advices? No projects, no repos. It's an open source.


Change button text color

Change text color on orange buttons in hero section to neutral so they meet accessibility requirements. Solves issue #21

That's great! Thanks for the changes @emmalearnscode

@all-contributors please add @emmalearnscode for design, code