Unacceptable completion performance on a project that has ProvidedTypes.fs(i) included

15.7.1

git clone https://github.com/fsprojects/FSharp.Data.SqlClient.git
cd FSharp.Data.SqlClient
build Build
Open SqlClient.sln
Open DesignTime.fs file
Go to line 347, for example
Add an empty line
Type "L" character
Wait for completion
It takes about 5 seconds to get the completion, devenv.exe consumes a lot of CPU
Delete the "L", repeat
Completion takes the same long time to appear

Looking at the reactor logs:

DesignTime.fs is checked instantly
Background checking blocks the reactor thread for more than 3 seconds

I think something wrong with caching background check results: the huge ProvidedTypes.fs seems to be rechecked every time on any ParseOnCheckFileInProject call.
Reactor: 77,745.864 BAD-BG-SLICE: >3s <-- background step, took 3982.1349ms

It turns out the problem is not caused by ProvidedTypes.fs. I've created a minimal repro: https://github.com/vasily-kirichenko/SlowTypecheckRepro

can you please upload the repro?

just saw you already created a git. never mind

Maybe amount of overloads in some types of this assembly?

@smoothdeveloper maybe.
Does anybody remember a packages with a type with LOTS of overloads?

Yes overload resolution is sloooooow
Vasily Kirichenko<EMAIL_ADDRESS>schrieb am Di., 22. Mai 2018,
12:53:

@smoothdeveloper https://github.com/smoothdeveloper maybe.
Does anybody remember a packages with a type with LOTS of overloads?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/4961#issuecomment-390948358,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNOcL7wPY8uTNQoPGRFNeLZP-A4LJks5t0-4lgaJpZM4UHi0b
.

Why Visit is non optional:

even though it's virtual, not abstract:

can you see what part of isexactmatch is slowest?
from very quick review I can see that CompiledSigOfMeth is called with same arg in IsExactMatch and in IsPartialMatch

and in IsTyparKindMatch

Yes, I've optimized away the double call of CompiledSigOfMeth. But I think the problem is that all virtual methods are checked (> 1000), because for abstract classes all methods are marked as required to implement:
https://github.com/Microsoft/visualfsharp/blob/4eed66b39d0db4c3c2d63bf11e98f4ea3f30be4c/src/fsharp/MethodOverrides.fs#L461-L478

What if filter dispatch slots by minfo.IsAbstract = true?

https://github.com/Microsoft/visualfsharp/pull/4970

With https://github.com/Microsoft/visualfsharp/pull/4971

Found this https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/MethodOverrides.fs#L320
This is iteration over dispatchSlots, which is done inside List.iter over the same dispatchSlots, so for 1K overloads, IsExactMatch was called up to 1M times :(

Looks like they are doing something like a discriminated union - just without DUs in the language.

Fixed via https://github.com/Microsoft/visualfsharp/pull/4971

I do have a project with an often used create method with over 300 overloads (use case interoperability with c# for otherwise inlined methods). Can I help with testing something? I do have issues with performance in general and completion, quickinfo and colouring specifically. It may be related.

@abelbraaksma just install the nightly vsix and try https://blogs.msdn.microsoft.com/dotnet/2017/03/14/announcing-nightly-releases-for-the-visual-f-tools/


Mark the HTTP client classes as isolated

Description:
$subject

Fixed by https://github.com/ballerina-platform/module-ballerina-http/pull/411 and https://github.com/ballerina-platform/module-ballerina-http/pull/414


chore : add selected channel version to MsgChanOpenInitResponse and MsgChanOpenTryResponse

Description

Add a version field to MsgChannelOpenInitResponse and MsgChannelOpenTryResponse in proto and gen proto
Set the selected channel version in the MsgChannelOpenInitResponse and MsgChannelOpenTryResponse

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

closes: #1204

also close #1203

Codecov Report

Merging #1279 (6d46432) into main (86638c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   80.31%   80.32%
=======================================
  Files         166      166
  Lines       12004    12008    +4
=======================================
+ Hits         9641     9645    +4
  Misses       1908     1908
  Partials      455      455

Impacted Files
Coverage Δ

modules/core/04-channel/keeper/events.go
100.00% <100.00%> (ø)

modules/core/keeper/msg_server.go
58.19% <100.00%> (+0.29%)
:arrow_up:

And one suggestion for future contributions: since you're closing two issues with one PR, I think it would have been preferable to create separate PRs for each issue. I know that it adds a bit of extra overhead and these issues were small, but, besides helping in reviewing, in this particular case @colin-axner explained that there was a way to backport the PR for https://github.com/cosmos/ibc-go/issues/1203 in a patch release. But since https://github.com/cosmos/ibc-go/issues/1204 requires to be back ported in a minor release (because go API is expanding), now that both improvements are bundled in the same PR, then we will need to backport this PR as a minor release. Not a biggie, but just something to keep in mind for the future!

Great explanation @crodriguezvega, I agree with this. Even when the changes are small/straight forward, it can be useful to keep them isolated

@crodriguezvega @colin-axner @damiannolan thanks for reviewing and your suggestions. I'll do it better next time !


[WFCORE-539] Set recursive to false for non-runtime only resources.

The comment from PR https://github.com/wildfly/wildfly-core/pull/490 indicated the value should be false. Changed to true so deployment resources are recursively cloned.

Linux Build 1236 is now running using a merge of 58cae87934a9eb890a1fe3726694317a245d370c

Core - Full Integration Build 502 is now running using a merge of 58cae87934a9eb890a1fe3726694317a245d370c

Windows Build 924 is now running using a merge of 58cae87934a9eb890a1fe3726694317a245d370c

Windows Build 924 outcome was SUCCESS using a merge of 58cae87934a9eb890a1fe3726694317a245d370c
Summary: Tests passed: 3044, ignored: 95 Build time: 0:18:36

Linux Build 1236 outcome was SUCCESS using a merge of 58cae87934a9eb890a1fe3726694317a245d370c
Summary: Tests passed: 3044, ignored: 95 Build time: 0:18:52

Core - Full Integration Build 502 outcome was FAILURE using a merge of 58cae87934a9eb890a1fe3726694317a245d370c
Summary: Tests failed: 1 (1 new), passed: 2856, ignored: 379 Build time: 0:49:18
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.smoke.webservices.WSTestCase.testManagementDescriptionMetrics: java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)


Layering bug with search results on user page

Describe the bug
The search results feed from the search bar appear beneath some of the content on the user's page.
To Reproduce
Steps to reproduce the behavior:

Go to a user's page
Search something in the search bar

Expected behavior
Search results would be on top of the user's page.
Screenshots

What device are you on?
PC running Windows 10, using Microsoft Edge Chromium.
Additional context
None.

this was fixed in #2537


[codecov] Use Go 1.20 as it is specified in go.mod and currently supported Go version on the backend

What changed?
I've set Go version so it will match with our Makefile EXPECTED_GO_VERSION.

Why?
I've seen a log message on codecov execution:
Makefile:50: Caution: you are not using CI's go version. Expected: go1.20, current: go version go1.22.1 linux/amd64

To eliminate possible inconsistencies between executions on buildkite and make and codecov we will use the same version.

How did you test it?
Unit tests on CI.

Potential risks
None

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018eaaff-2fd9-4a3e-99d5-e006db424ffa
Details

0 of 0   changed or added relevant lines in 0 files are covered.
23 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.02%) to 66.271%

Files with Coverage Reduction
New Missed Lines
%

service/history/task/transfer_standby_task_executor.go
2
87.01%

common/task/fifo_task_scheduler.go
2
85.57%

service/matching/taskListManager.go
2
80.96%

common/persistence/statsComputer.go
3
96.07%

service/history/task/fetcher.go
6
85.05%

service/history/task/cross_cluster_task_processor.go
8
80.79%

Totals

Change from base Build 018eaac3-4342-4613-8e92-81e25686f073:
0.02%

Covered Lines:
96964

Relevant Lines:
146315

💛  - Coveralls


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4612

Questions ?
Please refer to the Backport tool documentation


Use ARM NEON code even if SIMDe is disabled

@K-os could you confirm this compiles and runs on ARM with and without SIMDe (i.e. TARGET_SIMD_X86=0)?

I tested it on a M2 machine and both configurations pass make test.


FE #64 Env data visualization adjustments

Things what are purely aesthetic and whatnot.
Changes:

Higher max value (100) for data points.
Scales leaf wetness value to fit a 0-100 range.
Increases interpolation exponent to make ranges smoother. <- This is a lie.
Sets sans-serif font for dashboard.
Adds menu-item class for nesting lists under entries.
Some minor whitespace tweaks.

Looks good! :ship:


Deque

Tox.ini is missing. Both your pop methods can't handle popping on a one-node deque. You throw an error if the user attempts to insert a value of 0. There might be some other errors hiding under that as well.


Add Passthrough environment on Quest

Enables passthrough mode on Quest and adds a new environment called 'Passthrough' to the environments panel 🚀
I still need to explore if we can add this capability on other platforms, would love to get Vive/Index working but I hear it's quite a hack. Passthrough is managed programmatically so should be quite easy to extend on other platforms as and when supported!

this branch also removes some of the android manifest settings that appear to be breaking other android-based headsets - will check once merged.

Is it me or do all the hull brushes look unlit?
Is there an easy way for the passthrough environment not to be last in the list? I feel it deserves more prominance!

Lights are added back, hopefully! Yes it should be simple enough to move the environment higher in the list, perhaps it could be first even if it loads to 'standard' by default?

Passthrough is first in the list, lights are re-enabled, and ambient has been set to a middle grey to give some shadow contrast


Debugging Session Start Button should prevent double submission

It's possible to start several debugging sessions at the same time by clicking the Debugging Session start button really fast. This leads to incorrect behavior of the debugging experience.
Pressing F5 multiple times has the same effect.

@digeff I can not reproduce this, or I am just not fast enough.
Can you reproduce with any repository. On what platform do you see this?
@weinand can you repro this?

@isidorn we should prevent this independent from how quickly you press the F5 button.

Yup we are protecting with our state changes - in theory somebody could be fater than the state changes thus being able to start two times. But I was unsuccessfull. Can you repro?

It doesn't count if I cannot reproduce this, since there will be always a faster computer where this can be reproduced. We should make our 'protection' robust against this. If the 'state change' comes too late, then we will have to introduce a 'state change pending' lock.

we have a state for that, it is 'initializing'. Previously I was setting this state too late (after running preLaunchTask), this state is now set asap.

@isidorn that sounds like a great fix. But I will have a hard time verifying this ;-) I need the faster computer now!

@weinand Actually, I think that the slower the computer, the easiest it'll be to reproduce this (because the human needs to be faster than your code changing the state).
I originally reproduce this in a very slow Mac.

@digeff of course, you are right. But getting a faster computer is always a good idea ;-)


drivers: serial: ns16550: Fixed a bug related to shell failure on ehl_crb

Updated boot priority to PRE_KERNEL_1 for all instances
and removed dependency on PCIe. As shell is not working
in a situation where console is using a UART instance under
PCIe and boot priority set to POST_KERNEL.
Fixes #56751
Signed-off-by: Anisetti Avinash Krishna<EMAIL_ADDRESS>

@akanisetti as far as I see, the issue is related to any situation where a PCIe-based instance of ns16550 is used, i.e. it's not specific to only EHL. I'd therefore remove any mention of EHL from the commit message.


A more careful retrieve from PubMed is needed

Hi Chengxin, a huge thanks to your great work of BioLip2, I have vision inspect some of the non-bioactivate but mentioned in the abstract of origin PubMed paper, it indicate the retrieve is not perfect.
For example PDBID 6p0z, A protein bound to GDP and Mg, ligand ACE are included in Biolip2, may because there's a word "placed" in abstract match "ace"?

Thanks for pointing out this. We will try to update the biological relevance mapping, which would require a fair bit of programming.


Confused about oauth version (?)

Hi again,
If I log a new Twitter object, I notice it says it's using Oauth 1.0
Isn't the app auth w/ bearer token oauth v2.0?  Reference: https://developer.twitter.com/en/docs/authentication/oauth-2-0
This:
import * as Twitter from 'twitter-v2';
import { apiKey, apiSecretKey, bearerToken } from 'keys';

const client = new Twitter({
  consumer_key: apiKey,
  consumer_secret: apiSecretKey,
  bearer_token: bearerToken,
});

console.log(client);

Returns this:
Twitter {
  credentials: Credentials {
    _consumer_key: '...',
    _consumer_secret: '...',
    _bearer_token: '...',
    _access_token: undefined,
    _access_token_secret: undefined,
    _bearer_token_promise: null,
    _oauth: OAuth {
      consumer: [Object],
      nonce_length: 32,
      version: '1.0',
      parameter_seperator: ', ',
      realm: undefined,
      last_ampersand: true,
      signature_method: 'HMAC-SHA1',
      hash_function: [Function: hash_function],
      body_hash_function: [Function: hash_function]
    }
  }
}

FWIW, I'm GETting tweets just fine. Is the stated oauth version anything I should be concerned about?
Thanks

As per the twitter documentation

As this method [OAuth 2.0] is specific to the App, it does not involve any users. This method is typically for developers that need read-only access to public information.

Right now this library uses OAuth 1.0 for both application and user authentication as it covers both use cases (resulting in less to maintain) however any contributions that would switch over to OAuth 2.0 only for application authentication would be welcome!
In the meantime I don't believe there's anything to be concerned about, OAuth 1.0 is stable for app authentication.


Noob - I have no clue D:

Hello all, I'm interested in this project and want to change a single pokemon's model to a Legendary for the cosmetic value but I'm afraid I have no clue how to go about setting this up.
If anyone is willing to help me via Skype, that would be amazing.
I'm not banking on any help but I'll still ask for it.
Kind Regards
Shia

Issues are not a support forum. Please look at the examples what you want exists already and close this.

I knew that someone would comment something as unhelpful as that.
An issue is something that a person cannot solve, therefore I have posted it in the issue tab to ask for help... I have looked at the "examples" yet I can't seem to figure it out, in the future, please post helpful things as opposed to your sour comments.
Cheers
Shia

An issue is a real issue with the project not with your failure to read the instruction or the examples.

I can link you several issues that are cries for help if you would like, mate.
Here's some more helpful information regarding my issue, that I have posted in the ISSUES section ...
I have Node JS, it's just a cmd window, I have the example code I wish to use, how does one generate the MITM Certificate?
I don't want replied from peasants such as yourself, jmoriau.
Thanks
Shia

Ugh you just proved my point you didn't even read the README, or you would have your answer already.
Again the ISSUES are for issues with the project not your setup. Again it's not a support forum.
And yes, since pokemongo was released, everyone makes a github account to come "cry for help" as you say.
Doesn't mean it's okay. Most of the other big pokemon projects have disabled the issues for this very reason or at least limited it to contributors only. Because non-programmers like yourself think it's the right place to be spoon-fed everything, just look at all the closed issues asking for a "youtube video tutorial".
Finally if you can't understand that what you're trying to achieve is already available in the examples you shouldn't use this project. This project is not meant to be one-click install/run by non-programmers. It's meant instead to be used as building-blocks to write yourself what you want to achieve. If you can't write (or don't even know what is) coffeescript/javascript you really can't use this.

Yes, I did read the README, it's normally the first thing you look at when it comes to anything and everything.
I'm terribly sorry that I can't read coffee script/java script and I'm even more sorry that you don't possess the capability to even offer a single iota of help.
What a lovely first impression you have made for this community.
Get cancer and Kind Regards
Shia


Some Hygiene on how it looks in Obsidian

Been careful that it's only descriptions, but do check it doesn't break anything if you accept

@jun6lee Thanks for the update to the docs, some of the docs are auto-generated,can you edit it again?

Sure, could you identify which are auto-generated? I'll do the rest accordingly.

CHANGELOG.md
manifest.json
package.json


Pip/setuptool version updates leave old installs behind

eg:
$ heroku run bash
Running bash on REMOVED... up, run.3117 (Standard-1X)
~ $ ls -ld .heroku/python/lib/python2.7/site-packages/pip-*
drwx------ 4 u56615 dyno 4096 Mar  2 19:21 .heroku/python/lib/python2.7/site-packages/pip-8.1.2-py2.7.egg
drwx------ 4 u56615 dyno 4096 Mar  2 19:21 .heroku/python/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg
~ $ ls -l .heroku/python/lib/python2.7/site-packages/setuptools-*th
-rw------- 1 u56615 dyno 492154 Mar  2 19:21 .heroku/python/lib/python2.7/site-packages/setuptools-25.2.0-py2.7.egg
-rw------- 1 u56615 dyno 792919 Mar  2 19:21 .heroku/python/lib/python2.7/site-packages/setuptools-32.1.0-py2.7.egg

In our case the cache had been purged not that long ago, however I imagine some users (who haven't recently changed their python version or manually run purge_cache) will have many more installs. Each old install is about 7MB.
pip/setuptools are currently installed via python setup.py install, which doesn't handle uninstallation:
https://github.com/heroku/heroku-buildpack-python/blob/66f5a66740a7d30ed2d4250fefdc547a0037e800/bin/steps/python#L49-L75
Other than say switching to get-pip.py instead of setup.py installing the archive (which is probably not desired for a few reasons), I think the best solution might just be to run this as part of that install block, prior to installing the new version:
rm -fr .heroku/python/lib/python2.7/site-packages/pip-*
rm -fr .heroku/python/lib/python2.7/site-packages/setuptools-*

For anyone curious as to whether this was fixed or wontfixed (since there was no comment), it was fixed by:
https://github.com/heroku/heroku-buildpack-python/commit/09b7e448410b08e96a763fa1c73178e2ff5dddd3
(This was non-obvious, since the commit message was "fix tests" and it was landed directly to master without using pull requests, and GitHub doesn't email people watching the repo about direct commits to master.)

this fixed a problem i was having today, thanks!

This can now be closed, fixed by:
https://github.com/heroku/heroku-buildpack-python/commit/65648fb7a802078e125f4e0926b2042ba1f55b11#diff-57a28f8b2bf70b3efa895ae239e9d986R61


Add some more information to version select options

Not sure what date is in there (version created, plan approved) or if its working as the date has no label.

This issue will no encompass a couple other things:

Display a label the current legal version
Show a date range the plan was legal for

@calebissharp @okanji please also include the plan status at the time and who got it there, e.g., 'Approved - Lisa Moore'

Stuff to display:
is current legal version <-- should just be an indicator on one.
effective legal start date
effective legal end date
created by user
status
other stuff from endpoint:
version/snapshot id
version #.
endpoint /plan/?/versionsummary

RAN01. - Legal period (1999 dec - 2004 jan)    -  Wrongly Made (STANDS).   -   Lisa Moore.  -View

@okanji ping me when you have time to work on this (and the home screen preview thing).  I might try to get a poor man's version of the select list that is there working with legal start and end dates,  so we can slam a release out then let you carry on with the home screen thing and making this one better.
When 727 is done I can help you again learn to make test data to do this.

@okanji I like the update however there is a bit of an issue where there is a “stands” status (there are a couple of those) as they can be current legal but in current version their status isn’t showing so everything looks greyed out. I wonder if the status should be shown for these. @micheal-w-wells may have suggestions here.

@LisaMoore1 @micheal-w-wells how does this look? I decided to use same status component that has been used elsewhere in application. I have tried to make the current legal version stand out by colouring the avatar and the approved dot while greying out the other versions.
Does anyone have an RUP number that has multiple versions? I would like to take a look and see what the different statuses look like. As shown above, I could only find versions that had a status of approved.

@okanji I like the update however there is a bit of an issue where there is a “stands” status (there are a couple of those) as they can be current legal but in current version their status isn’t showing so everything looks greyed out. I wonder if the status should be shown for these. @micheal-w-wells may have suggestions here.

@LisaMoore1 thanks for the detailed feedback, the version above that I have shown a screen shot of seeks to address your suggestions

LGTM.  Best way to get @LisaMoore1 is to go ahead and PR to dev, get either @calebissharp or myself to review and then mark the issue (not the PR) as ready to test and put in the QA column.

@okanji See #760 for some comments/screenshots on this. Might be something to talk to @calebissharp and @micheal-w-wells about as I think this is touching on a few things about how we identify/categorize different statuses so it is clear to users what they are looking at.

I think our recent api changes should have fixed this one.  I don't think there's any change for Oamar here.

@micheal-w-wells Noticed a couple of funky things here.  Not sure if they are related to this issue or not. Can you take a look?

[ ] legal start/end don’t need time (might help avoid the overlap) although it is useful during all of this testing
[ ] once an amended plan hits “stands” as far as users are concerned it “stands” whether it is reviewed or not.

if changed to wrongly made it is still THE SAME amendment
the legal start and end date remain the same
no changes have been made between stands and
displaying the various versions (especially with different start/end dates/times make it seems like there are multiple amendments
[ ] can we somehow just show the most recent version of an amendment? If we had history capturing all status changes looking at that version would give us the whole picture

@micheal-w-wells I think because the plan can't be edited in any "stands" statuses, we can ignore every status when finding legal versions, except "Stands - Not Reviewed", because it's always the first one.

can we somehow just show the most recent version of an amendment? If we had history capturing all status changes looking at that version would give us the whole picture

@LisaMoore1 Maybe I'm misunderstanding, but isn't this the same as looking at the plan from the main plan page, at least while there is an amendment in progress? Then once the amendment is completed, it will appear in the versions list as "Stands" or just "Approved".

@calebissharp Yes I think that is right — main page shows the most recent. The thing that confuses me is when I look at the version list and I see all of the versions associated with that single amendment when really the most recent one (provided all the status changes are showing up in history) tells me everything I need to know — and is more clear that it is all associated with a single amendment.

i'm gonna make my afternoon goal find a way to make amendments less confusing in the version list, i think i have an idea of how to go about it


Fix issue #314

Coverage remained the same at 100.0% when pulling 5aa73c0bca2935f73d1584cf90e671225cdae19e on issue_314 into 7ab824a6394d8e4036ad9717fe414ecb1fb33c18 on master.


Add VPN instances to SSH Config

The ssh_config file should have the VPN instances added after the VPN is created. This may just be a documentation change.
Adding the VPN to the SSH config will allow a consistent run of ansible-playbook without needing separate arguments depending on which playbook is run.
Ref #44

Would be interesting to see if we can automate adding the IP with http://docs.ansible.com/ansible/latest/lineinfile_module.html as part of the ansible run.

I looked into this but the vpn instance creation is in the same role as the vpn instance configuration.
I added a block in the ssh_config with '' as the host and that works for the first run of the vpn role. We could setup a step after the vpn instance is configured to replae that '' with the actual ip address.
I'm not sure how that would play when replaceing the vpn instance though.

fixed in #66


change local repository path

Hi,
is it possible to change the path to the "Local repository" per parameter or variable?

It's currently impossible, but I shall take some time to fix issues in Gopm.... :sob:

can you consider disabling "local repository" too? I want to use a docker container as builder so $HOME is volatile so it would be amazing if gopm could simply git reset --hard in place

I need change local repository path too, do you have any plan to implement is function?
maybe  a global setting file is enough.


Allow array of button ID's on useNavigationButtonPress

Example usage
useNavigationButtonPress(()=> {}, 'componentId', ['foo', 'bar']);

I can submit a PR if you like.

Instead of using an array you can easily declare two hooks like this:
 useNavigationButtonPress(() => {}, componentId, 'foo')
 useNavigationButtonPress(() => {}, componentId, 'bar')

That's a lot of keystrokes. Array of buttonIds solves that issue, and it is specially useful when grouping related buttons into one listener @jpgarcia

If you want to handle multiple button events you can do it like this (same way with the array approach):
useNavigationButtonPress(e => {
  switch (e.buttonId) {
    case 'foo':
      // handler
      return
    case 'bar':
      // handler
      return
    default:
      return
  }
}, componentId)

This Closes #14


Here's a suggestion

suggest convert the python print function to low version, eg:
print(f’abc{value}’)
to
print(‘abc{}’.format(value))
so it can support not only python3.6 but other versions as well.

Sorry for late comment, I was so busy these days
Thanks for your suggrestion. I'll check it.


Feature Request: Ability to serialize object into JWT Token Payload

I wanted to start this conversation here before offering a pull request. I want to see what the community thinks as well as project maintainers.
When using Adonis Auth with JWT, the sample code below only serializes the Entities Primary Key into the Payload.
const user = yield User.find(1)
const token = yield request.auth.generate(user)

Code: https://github.com/adonisjs/adonis-auth/blob/master/src/Schemes/Jwt/index.js#L93-L103
JWT Spec and the jsonwebtoken library support providing object literals into the payload. It would be very useful if Adonis Auth also supported this use-case. An example of practical use of this feature would be such as if you want to add the Users Profile object into the payload, so you don't need to make another API call for that information (or and it to the response itself).
Without this feature you have to work around it by adding the object into the response body (to avoid another Web I/O).
const profile = yield user.profile().fetch();
const token = yield request.auth.generate(user);
response.send({ token: token, profile: profile });

Many client side frameworks have built in support for JWT payloads, example Aurelia Auth, which has an API to get the JWT payload. If the payload had an object expected you wouldn't need to do any further processing to get the details of the Users Identity, or any special logic to store and maintain that information through the life of the session, which is something the framework is already doing with the payload.
Offering this feature is trivial, there are a few different ways I see how it could be done, but first would like to here others thoughts. If anyone wants to see sample change-sets in how this could be achieved I would be glad to provide and discuss further

@starr0stealer How would you decode the payload on client side? since there is a secret associated with encoding the data.

JWT is a defined standard that formats a token in 3 parts, Header Payload Signature. The Header states its JWT and the algorithm used to created it. Payload is used to transmit any data you want to pass over. Signature is the Hash that includes the Header Payload secret.
The spec defines that we can read Header Payload not Signature. For that reason we can't change a JWT Token and expect it work.
Client Side frameworks already read the token. Such as Aurelia Auth and auth0/jwt-decode.
This is what prompts the feature request, to expand the Payload sent, to be more useful.

Okay that make sense. I have another question, which is more related to usability.
You talk about attaching extra data to the payload, let's think of it Profile, what will happen if profile gets updated? The payload will still have the old data.
Whereas with id in the payload, you are kind of forced to fetch the update profile every time.
Thoughts?

The developer should still be responsible to manage State of the JWT Payload. Normally if the underlying data of a JWT Token changes the token should be renewed. So if the Payload changes, they need to handle how they like, renew token or just make an API call for the update.
To maintain how Session works with Adonis Auth the primaryKey attached during generate() should still be the Identity id, usually this would be the same object as Profile, sometimes not. The Payload would be separate from the primaryKey object.

I'm also thinking about how to handle entry points into the existing Adonis Auth API on the generate() method.
A few different use cases I can already think of, based on Payload needs and Identity Model design.

Only provide the Identity.primaryKey in the Payload
Default implementation
generate(identity)
Provide the Identity.primaryKey and the entire object in the Payload
Typical Identity Model, ie profile details such as name are in this model
generate(identity, serializeIdentity = true)
Provide the Identity.primaryKey and an object literal in the Payload
Sometimes the profile details are in a sub entity, or another object is desired
generate(identity, payload = { })

Trying to digest the flow.

I can attach arbitrary data to the token generation call.
There should be refresh method on the JWT auth, which will regenerate a fresh token.
Also refresh will take an extra parameter of arbitrary data which was sent along to the generate method.

Also I would like to nest the payload inside a different key for better separations of concerns. For example: When i decode the token it should something like
{
  identifier: 1,
  data: { ... }
}

Using a single parameter for 2 things is kind of wrong approach.
generate(identity, serializeIdentity = true) and generate(identity, payload = { })

Ideally I believe serializeIdentity should do the job. If I want to attach the user profile to the payload, I can eagerload the relationship. Which will have the user profile automatically serialized to JSON.
const user = yield User.find(Id)
yield user.related('profile').load()

request.auth.generate(user, true)

Sample very basic change to generate() to meet different use cases. Other methods would need to change, since the Payload and location of primaryKey has changed.
  * generate (user, serializePayload) {
    if (!user) {
      throw new NE.InvalidArgumentException('user is required to generate a jwt token')
    }
    const primaryKey = this.serializer.primaryKey(this.options)
    const primaryValue = user[primaryKey]
    if (!primaryValue) {
      throw new NE.InvalidArgumentException(`Value for ${primaryKey} is null for given user.`)
    }

    let payload = {
        primaryKey: primaryKey
    }

    if (serializePayload != null) {
      const payloadType = typeof(serializePayload)
      if (payloadType === "boolean") {
        payload.data = user;
      } else if (payloadType === "boolean") {
        payload.data = serializePayload
      }
    }

    return this._signToken(payload, this.jwtOptions)
  }

"eagerload the relationship" Can indeed work, but another use case is where you want to pass non entity model data. A sparse model, with just needed values for example.

@starr0stealer The idea is to force the user to follow the right design, instead of doing anything and coming up the spaghetti code.
I cannot think of any situation, where the payload should have data not related to a user. If there is, then they should hit the API.
Also this makes the process of refresh token simple, as we can easily refetch the relationships, instead of asking the user to pass all the custom data again on refresh.

I think that has a few negative affects. Anyone can decode the JWT Payload. The Identity model could have the password, which now needs to be transient otherwise you have security issues. If you just allow relationship to get more details, you also now have bloated data passing in the line (the first object you don't need, and other info such as Dates). What someone puts in the token can change App to App.
I like the idea of built in Token Refresh, not everyone will need that. Some that do, may need to apply their logic. In my current App I am handling Refresh myself, wouldn't like to loose that ability.
I like a framework to simplify common tasks, but not limit what I can do for Business Rules

I have different thoughts here. I believe libraries should do the common tasks and frameworks should enforce better design.
Regarding the data security, you can also define which fields to hide to serialized JSON by defining visible or hidden properties on your model.
class User extends Lucid {

  static get hidden () {
     return ['password']
  }

}

I completely agree with frameworks handling common tasks and best practices, but not limitations. The JWT spec allows anything to be put into Payload, and any implementation of it should do the same. In regards to data transfer over the net, common practice is to limit how much you pass over. A large Model hierarchy just for three fields isn't the best option.

@starr0stealer
I have to map my mind over it, can u share a PR with refresh and generate method accepting the payload? Also I am against the usage of a single parameter for 2 things.

I use JWT in .NET using the jwt-dotnet/jwt library and it allows me to specify any information I would like in the payload. I like having the flexibility to define what I need and what I don't. It takes a dictionary that allows me to specify the key and value. I know that the jsonwebtoken library is used under the covers and it allows you to specify what you would like. It would be nice to be able to send a js object to the generate token method to specify the key and values you would like to pass with the token.
generate(payload, exp)

This would be a nice API and allow good flexibility. I feel like when a framework attempts to limit a user for security concerns it can get in the way of usability.
generate({
   userId: 1,
   name: 'Some Name',
   email<EMAIL_ADDRESS>}, 72000);

That API seems like it would give me the same usability as using the library directly and give full control over the payload and expiration time. The expiration time would be nice to be able to define in the auth.js configuration file as well, but allowing an override in the generate method for a "rememberme" type functionality.
The payload could be run through some sort of serializer that ignores certain properties based on the model if the model is passed which would be fine as well. I think documentation in the auth section would be enough to inform users not to send the password. If the user has used JWT in the past this would be a no brainer.

@thetutlage I will be glad to put something more detailed together into a PR

@thetutlage This is what we discuss earlier about extending the payload of the JWT and allow us to extend the JWT Validator.

@RomainLanz That was related to extend the configuration, this is more related to the actual data being sent over the wire.
I am very much open to get the ideal implementation for the JWT and API tokens Auth, and I believe the usage of the framework in production apps will have more requirements over the time.

We discuss about both 😛
Why not pass an object that is merged into the payload?
yield request.auth.generate(user, object)

--

I have two starting points, outlined in the Branches below. The idea of Refresh may need further discussion. The Developer would need to say when a Token needs updated, calling generate () will update the token.
This Branch handles the basic need, to include the User into the Payload: jwt-payload
  * generate (user, serializeIdentity) {
    if (!user) {
      throw new NE.InvalidArgumentException('user is required to generate a jwt token')
    }
    const primaryKey = this.serializer.primaryKey(this.options)
    const primaryValue = user[primaryKey]
    if (!primaryValue) {
      throw new NE.InvalidArgumentException(`Value for ${primaryKey} is null for given user.`)
    }
    let payload = {identityId: primaryValue}
    if (serializeIdentity) {
      payload.data = user
    }
    return this._signToken(payload, this.jwtOptions)
  }

This Branch handles above and, allows the user to provide any Object into the Payload: jwt-payload
  * generate (user, serializeIdentity) {
    if (serializeIdentity) {
      return generateCustom(user, user)
    }
    const primaryKeyValue = this.getPrimaryKeyValue(user)
    return this._signToken({identityId: primaryKeyValue}, this.jwtOptions)
  }

  * generateCustom (user, model) {
    const primaryKeyValue = this.getPrimaryKeyValue(user)
    const payload = {identityId: primaryKeyValue, data: model}
    return this._signToken(payload, this.jwtOptions)
  }

I created #14 in the simplest way to capture all use cases, usage examples below.
// API
  * generate (user, customModel) {
    if (!user) {
      throw new NE.InvalidArgumentException('user is required to generate a jwt token')
    }
    const primaryKey = this.serializer.primaryKey(this.options)
    const primaryValue = user[primaryKey]
    if (!primaryValue) {
      throw new NE.InvalidArgumentException(`Value for ${primaryKey} is null for given user.`)
    }
    let payload = {identityId: primaryValue}
    if (customModel) {
      payload.data = customModel
    }
    return this._signToken(payload, this.jwtOptions)
  }

// Usage
const user = yield User.find(Id)
yield user.related('profile').load()

request.auth.generate(user) // payload { indentityId }
request.auth.generate(user, user) // payload { indentityId, data : user }
request.auth.generate(user, user.profile().fetch()) // payload { indentityId, data : profile }
request.auth.generate(user, {foo: 'bar'}) // payload { indentityId, data : {...} }

@starr0stealer
Make sure to call .toJSON on the the model, which will return the serialized json instead of the actual model instance.
So it can be
payload.data = typeof(customModel.toJSON) === 'function') ? customModel.toJSON() : customModel

@thetutlage  I've updated to check for toJSON, thank you

Any progress on that?

@thetutlage
We are starting to get more people interested in this feature request, as its a really import feature of JWT and as stated by @marines any implementation without the ability to define a Payload doesn't provide much usage

@starr0stealer @marines I am really sorry, this issue has been on sideline for a while. I will add this feature tomorrow morning itself.
Have some more changes in mind with the proposed PR.

Done in https://github.com/adonisjs/adonis-auth/commit/2e413fe8643141f4d3752f4df04bd936bd65638d


Section widgets are not styled correctly

It seems like section widgets don't inherit the style from above. I think you mentioned that, but I think we should track it. An example would be the about page.

The lack of inheritance is on purpose.  The prose class works fine for the text areas, but it is absolutely ugly with anything else.  So the widgets aren't in the same div as the various text sections. In places where we want some amount of consistency, we'll need to figure out what prose does for the specific style we want to mimic and then do it by hand.  This might be another place for some named classes that we can reuse.


Feature: Disable auto-sizer on row height

Implement a way that allows the developer to indicate whether he wants to disable the auto-sizer on row height/width

fixedRowHeight and fixedRowWidth have been introduced to interact with CellMeasurer


[AzureStaticWebAppV0] Add skip_api_build to Devops Task

Bumped minor version  to 202

Per instructions here: https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/taskversionbumping.md

Update task.json

added skip_api_build input

Documentation changes required: N
Added unit tests: N
Attached related issue: N

LGTM

@anatolybolshakov @denis-tikhomirov we need to merge this PR. Approvals from our end are done. Thank you!

/azp run


added failing test for TransitionHook on not selectively calling routerWillLeave

In reference to issue #1317
Fails as of 285a61f
When transitioning from /grandparent/parentB/child to /grandparent/parentA, it calls Grandparent.routerWillLeave, which it should not.

awesome, thank you!

I think we've got a solution for this, should be making it into the code soon

The TransitionHook mixin and routerWillLeave are gone in the latest code on master. Instead, you can tie directly into the history object to register your transition hooks.

I believe this indirectly tests the order that the hooks get called. Thanks for this test case, it sparked a revamp of our transitions!


Some bugs in Top-down observation

The top-down obs messes up! Not sure is coming from rendering or visualization

Really interesting bug, but unfortunately it is not related to the failure of PPO/SAC. Since we are using single environment.
https://user-images.githubusercontent.com/22206995/111469817-1a235500-8762-11eb-86c8-1059f7079a27.mp4


fix sendLocalResponse in wasm

fix #23047
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/wait

https://dev.azure.com/cncf/envoy/_build/results?buildId=117861&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=21e6aa7d-f369-5abd-5e4e-e888cac18e9c
https://github.com/envoyproxy/envoy/blob/f09ed3646b88fae777a060be37f3224dfa67f428/source/extensions/common/wasm/context.h#L30
There seems to be a problem with this clang tidy check, this using will be used in the context.cc like:
https://github.com/envoyproxy/envoy/blob/f09ed3646b88fae777a060be37f3224dfa67f428/source/extensions/common/wasm/context.cc#L152


move the built cratesfyi into the vagrant container

Works around https://github.com/rust-lang/rust/issues/49710 when developing docs.rs with a Windows host.
This sets the CARGO_TARGET_DIR environment variable within the vagrant box to a folder inside the container rather than in the share. This means that when building the cratesfyi executable or the docs.rs service, the files will be placed inside the container (in /home/cratesfyi/target) rather than in /vagrant. This does mean that the binaries will be unavailable outside the container without manually copying them out. However, without this change, any build will fail with an error like the one in the linked issue. Combined with https://github.com/onur/docs.rs/pull/216, I can fully build docs.rs from a Windows host.

Thanks @QuietMisdreavus, but that vagrant image really needs some work. I am planning make a great return to this project really soon.


Prune checkpoints in Lambda

Description
Closes https://github.com/quickwit-oss/quickwit/issues/4613
Avoid accumulating file sources when running Lambda indexer
How was this PR tested?
Describe how you tested this PR.

i'd rather we always keep the last X checkpoints

Yes, couldn't agree more. I logged in https://github.com/quickwit-oss/quickwit/issues/4613 a few things I tried to achieve that and why they failed. We could definitively come up with a solution but it would require a more massive rewrite on the metastore or the source.


feature request, allow special characters for section and var names

subject changed by Rudi to match the feature request of post #2

Would it perhaps be an option to be less strict when reading the sections and values, and just convert special characters to underscore before creating the variables? This is already being done for '.' correct?
https://github.com/rudimeier/bash_ini_parser/blob/8fb95e3b335823bc85604fd06c32b0d25f2854c5/read_ini.sh#L232-237

I switched to using the 'next' branch which supports special characters in the section names.
However I came across a complex example in one of the configuration files that I am parsing that is still not handled as expected:
enabled = true

# top-level directories for browsing, as <name> <uri>
directories =
    Albums                  local:directory?type=album
    Artists                 local:directory?type=artist
    Composers               local:directory?type=artist&role=composer
    Folders                 local:directory:
    Genres                  local:directory?type=genre
    Performers              local:directory?type=artist&role=performer
    Release Years           local:directory?type=date&format=%25Y
    Tracks                  local:directory?type=track
    Last Week's Updates     local:directory?max-age=604800
    Last Month's Updates    local:directory?max-age=2592000

# database connection timeout in seconds
timeout = 10

In this example, each line is handled as a separate parameter value pair, and the script fails on Folders                 local:directory:, expecting an '=' at the end. Any ideas on how to deal with the above?

I've created pull request https://github.com/rudimeier/bash_ini_parser/pull/9 to add support for multiline values, and added a few other features similar to what can be found in Python's RawConfigParser.
All of the tests still run and I've added a few new ones. @rudimeier will you please review?


Generated Client should have all services

Rather than forcing clients to instantiate a new client every single time new UsersService vs new AccountService it would be better to generate a single client. Would prefer new FernClient() and then something like client.usersService().getUser()

this is now true


google play service

hi
i tryed many time but i get the same error
E/GooglePlayServicesUtil: The Google Play services resources were not found. Check your project configuration to ensure that the resources are included.

Hello,
the issue you describe does not seem related to Android-Hotpatch. Results on google might show they you can ignore this message (see https://github.com/danwilson/google-analytics-plugin/issues/108 or https://stackoverflow.com/questions/18068627/logcat-message-the-google-play-services-resources-were-not-found-check-your-pr).


Loading animation looks broken

Apart from that, the extension is great! :-)

Thanks for reporting! Dupe of https://github.com/cschleiden/vscode-github-actions/issues/76 which should be fixed with the next VS Code release 🤞


Set config path from environment variable

flexget should read the path to the config file from an environment variable. FLEXGET_CONFIG for example.
The env variable should only be used if no command line config path has been given. I.e. set the path from the first one of these that is set:

-c /path/to/config.yml
FLEXGET_CONFIG
default locations, one of ~/.flexget, $XDG_CONFIG_HOME/flexget

I guess this could work for Windows as well. Setting %FLEXGET_CONFIG%.
Any thoughts on the variable name?

Contributions are evaluated, we're not putting effort into this one.


Terracotta chart doesn't use release name in resources

It creates the resources with default name and default namespace. It is impossible to manage multiple clusters in same docker cluster this way. It should use the name we provide during helm install as prefix for every resource it creates.

@mobasherul : can you have a look please ?


feature request: Pop-up message

Hi Chris,
Congratulations on your initiative.
I have a small suggestion:
Currently when I save a file and it is not checked in to min the SPGo shows a message on the output console, to draw more attention it would be possible to also display the message in the VSCode pop-up, as shown in the example below:

Thanks
Marcos

Hello @mcallegario - I encountered this same issue when I was testing the latest SPGo release. I will make sure that upload errors due to checked out files are displayed in a popup in the next version of SPGo.


What about the RC4 Cipher Suite?

So I've been running into this a lot in my Skype deployments. I go to my servers and disable TLS 1.0, 1.1, SSL2 and SSL3. I also disable all the week ciphers (i.e. everything below AES 128). Magically my mediation and edge servers start throwing fits! Media no longer flows. So I go back in and enable RC4 128/128 and it all starts working again.
I can find ZERO documentation on the required cipher suites for Skype for Business. I can only fine "we support TLS 1.2 now" etc. Has anyone else run into this? The security folks at my various clients are going nuts about us leaving any RC4 cipher open on servers that (even if they're in the DMZ) have to be exposed to the internet. I've gotten no word from MS on potential patches to SFB 2015 or if RC4 use is actually deprecated in 2019.

@eragon921 Thank you for this feedback
I want to make sure this gets addressed the best way possible so I am sending this to the Teams team and I would also like you to oppen up a support ticket for it as well so we can tackel this from both sides.
I have put a not for the Teams team to reply to you with information once they have any word on this issue as well.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Here is a quick video on opening a ticket: https://www.youtube.com/watch?v=puuOy0sEg1Y
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

So I asked my Microsoft PFE and this is what he got back,
Officially Microsoft does not support disabling individual ciphers in a
Skype for Business environment.  We do support disabling TLS 1.0/1.1, with
the proper CU and following documented procedures.  However, the product
group has not tested disabling individual ciphers and will not support an
environment that does disable them individually.  From the product group
the reason RC4 is most definitely required is that the initial connection
header appears to CryptoAPI as an RC4 request.  While it is not an RC4
request, if RC4 is disabled CryptoAPI won’t even process the request to
find an acceptable cipher.  According to the product group they are not
using RC4, but the connection header utilizes the same format as RC4.  The
product group currently has no plans to change this aspect of the product
due to the high costs involved in changing all of the initial connection
portions of the product.
Seth Schumacher
On Thu, Sep 13, 2018, 3:07 PM AndreaBarr<EMAIL_ADDRESS>wrote:

@eragon921 https://github.com/eragon921 Thank you for this feedback
I want to make sure this gets addressed the best way possible so I am
sending this to the Teams team and I would also like you to oppen up a
support ticket for it as well so we can tackel this from both sides.
I have put a not for the Teams team to reply to you with information once
they have any word on this issue as well.
I think the best way forward is if you can open a service ticket in your
tenant so this can get resolved ASAP. Based on outcome let me know if it is
something that can be called out in the docs.
Here is a quick video on opening a ticket:
https://www.youtube.com/watch?v=puuOy0sEg1Y
If you don't mind please keep us posted here on the resolution and I
really want to get this information you are discovering back into the docs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/678#issuecomment-421118045,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMhMaO3wQEegib17-wM8RkF9x3xLoL0ks5uaq0FgaJpZM4WAaVq
.

@eragon921 Thank you for this feedback
I will make sure this is sincluded in the backlog. I appricate the extra bit of information so we can get this updated.

@MicrosoftHeidi Any updates on this issue? Thanks!

https://support.microsoft.com/en-us/help/2868725/microsoft-security-advisory-update-for-disabling-rc4
Audiocodes uses RC4 by default and this can be changed to other Cipher suites like AES128-SHA256

Hi all, sorry for the delay. I've  been ill. Please take a look at the answer from @eragon921 and PFE. Disabling individual ciphers isn't supported by the Product Group with good reason. Please see the answer above and also, thank you, Seth!

The challenge is that Audio Codes uses it by default, and due to some regulations, RC4 is considered to be less secure. So chances are that in such environments, we would experience this issue.
Some public documentation, along with partnering with AudioCodes to change the default to a different CIPHER would be a great start.

@eragon921 Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


[ES2015][TypedArray] add other 8 types

add Uint8Array, Int16Array Uint16Array, Int32Array, Uint32Array, Float32Array Float64Array Uint8ClampedArray
Support the conversion between any pairs of those types.
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang<EMAIL_ADDRESS>

Why does not the auto-build/test system run?

@LaszloLango Thanks for the comments, About the test, this patch mainly focus on the conversion of different types, and we didn't implement the method such as "forEach, fill, indexOf, ..." yet. I will add more tests about the conversion, and will implement other methods in the following patch.

updated

jerry-core/ecma/operations/ecma-typedarray-object.c:304: style(variableScope): The scope of the variable 'tmp' can be reduced.
This is the fail

@jiangzidong please fix the doxygen related errors. Run doxygen and check the related warnings. There are some issues with your group names.
* \addtogroup float32array prototype ECMA Float32Array.prototype object built-in
must be
* \addtogroup float32arrayprototype ECMA Float32Array.prototype object built-in
and * \addtogroup string ECMA Float32Array object built-in
must be
* \addtogroup float32array ECMA Float32Array object built-in
etc.

@LaszloLango updated. sorry that i didn't notice the doxygen part.

LGTM


Pod Import

Once, the pod export feature is complete (#136 #228) , we can start to create a utility to import that data.
The importer will have to modify the URI references of the old pod's rdf data.
To reduce link rot, we should consider creating a redirect service from the old pod provider to the new one.
The export-import process should be able to be done manually or triggered automatically together with an AP Move activity.

@Laurin-W On the pad I had put this idea:

Import and export could be done by an external app, which receives full rights on the Pod.

You added:

Since ActivityPods include activitypub collections which are not interpretable by a standard spec-compliant solid / ldp client, the external app will have to query the pod using a user-facing SPARQL endpoint (which is at risk right now) or need to support recursing through AP collections as well. Export using the backend is therefore easier.
For clients, see also https://pdsinterop.org/solid-migrator/ and https://github.com/jeff-zucker/solid-file-client/

By external apps, I was not talking about a browser-based client, but about the backend part that apps in v2 will be able to deploy. We could, in theory, allow some apps to have full access to our Pod, including the SPARQL endpoint (without WAC permissions check), even if we don't use SPARQL elsewhere anymore.
The advantage I see is that we avoid putting too much code in the Pod provider. But there could be some problems nonetheless so this is something to think about thouroughly.


Introduce easyinstall options for installing stand-alone rascsi

Introduce options for doing everything except installing a systemd service for rascsi/rascsi-web
Refactored the script to make it more modular
Added code comments describing each function

@rdmark Your latest changes make the installation changes much more transparent, thank you.
I noticed that the manpages are currently install in /usr/share/man. I would have expected /usr/local/man instead, which would be consistent with the installation path for the binaries. (The manpage installation change is currently not yet mentioned, by the way.)

@uweseimet I agree it's good manners by a script to be up-front about potentially destructive operations that it will do, rather than just say "trust us" ;)

@uweseimet Added manpage notices. The manpage installation script is in the Makefile I believe.

@rdmark Yes, the manpage path is hardcoded in the Makefile. @akuker Any idea why the manpages are installed in /usr/share/man instead of /usr/local/man?

Just noticed that /usr/local/man is a link to /usr/share/man, i.e. we should update the path in the Makefile to /usr/local/man for consistency. In practice the final manpage location will stay the same.

@rdmark In case https://github.com/akuker/RASCSI/pull/474 is approved, the easyinstall message about where the manpages are installed should be updated to /usr/local/man. This might be a link, or maybe not, or may even point to different locations, depending on the OS. Looking at /usr/local/man on the respective platform will show.

@rdmark Yes, the manpage path is hardcoded in the Makefile. @akuker Any idea why the manpages are installed in /usr/share/man instead of /usr/local/man?

There is a very logical reason...... because I'm a n00b. I probably just grabbed the first result from google of "where do man files go" and didn't think about what I was doing.
It really does belong in /usr/local/man

@rdmark In case #474 is approved, the easyinstall message about where the manpages are installed should be updated to /usr/local/man. This might be a link, or maybe not, or may even point to different locations, depending on the OS. Looking at /usr/local/man on the respective platform will show.

Fixed & pushed


Is it possible to add options to toolbar for font colour and more heading sizes?

Hi
I've been trying to find if there is a way to add a couple of font colours to select from and a couple of different size headings (h1/h2/ h3).  I can see how you can hide certain options in the toolbar, but is there a way to add more functionality such as the font colours etc?
Any advice greatly appreciated.
Many thanks

I am supporting this request. Especially the one for the different header sizes. It would also be great if one could include  tags as separation lines.

You can override the toolbar with some thing like the code below. The only issue I am having is trix expects a specific loading order and the defer on the script in resources/views/trixassets.blade.php is causing a issue. The html is loading before trix so the the toolbar isnt loading all of the new config
<head>
@trixassets
<script>
    window.addEventListener('load', function() {
        Trix.config.blockAttributes.heading2 = {
            tagName: 'h2'
            , terminal: true
            , breakOnReturn: true
            , group: false
        }
    })
    addEventListener("trix-initialize", event => {
        const {
            toolbarElement
        } = event.target
        const h1Button = toolbarElement.querySelector("[data-trix-attribute=heading1]")
        h1Button.insertAdjacentHTML("afterend", `
<button type="button" class="trix-button" data-trix-attribute="heading2" title="Heading 2" tabindex="-1" data-trix-active="">H2</button>
`)
    })
</script>
...


[client] js: Fetch public conf once from /config; embed.js: Preserve default config values

isso: js: embed.js: Preserve default config values
This way, Isso is not confusing users when a server config value overwrites a client default one, i.e. if the user has not actually attempted to overwrite it.
isso: js, py: Fetch public conf once from /config
This is an improvement on top of: 02f3ea0658680ce200258bc66d509403846b62d5 "Have client read out shared settings from server (#311)"
So far, the config dict was being sent with the server response when fetching comments from the fetch() / (GET) endpoint.
Create new endpoint at /config, which will serve a JSON representation of the server's public_conf. Also remove the config object from fetch() responses.
Extend the JS client api file to fetch from the /config endpoint, which will only happen once via the fetchComments hook on page load.
EDIT: Have a couple of nasty race conditions right now, needs further work. Caused by multiple instances of config copying from default_config, where the templates might receive either a pre-copy or post-copy instance.

cc @pellenilsson @brad, looking forward to your reviews. Hope you can rebase your changes on top of this.

@Kerumen continuing discussion from #842

It seems that in development, window.Isso.fetchComments() reload the whole page. I have to dig more.

That seems strange to me. With the branch from #821, I don't see a refresh of the whole window. Both init() and fetchComments() now do exactly what they're supposed to.

But I have discovered another issue which is a race condition during the reading of the default config and fetching of the server config. See this branch with some logging. You need to refresh the page a couple of times to hit it.
comment:
Object { css: true, "css-url": null, "max-comments-top": "inf", "max-comments-nested": 5, "reveal-on-click": 5, avatar: true, "avatar-bg": "#f0f0f0", "avatar-fg": (8) […], vote: true, "vote-levels": null, … }
comment: gravatar
true
comment:
Object { css: true, "css-url": null, "max-comments-top": "inf", "max-comments-nested": 5, "reveal-on-click": 5, avatar: true, "avatar-bg": "#f0f0f0", "avatar-fg": (8) […], vote: true, "vote-levels": null, … }
    avatar: true
    "avatar-bg": "#f0f0f0"
    "avatar-fg": Array(8) [ "#9abf88", "#5698c4", "#e279a3", … ]
    css: true
    "css-url": null
    feed: false
    gravatar: false
    langs: Array(4) [ "en-US", "en", "en", … ]
    "max-comments-nested": 5
    "max-comments-top": "inf"
    "reply-notifications": false
    "reply-to-self": false
    "require-author": false
    "require-email": false
    "reveal-on-click": 5
    vote: true
    "vote-levels": null
    <prototype>: Object { … }

!!!
comment: gravatar
true
# should not be true!
!!!

Setting reply-to-self to false
Setting require-email to false
Setting require-author to false
Setting reply-notifications to false
Isso: Client value 'true' for setting 'gravatar' overridden by server value 'false'.
Since Isso version 0.12.6, 'data-isso-gravatar' is only configured via the server to keep client and server in sync
Setting gravatar to false

GET http://localhost:8080/demo/undefined
[HTTP/1.1 404 NOT FOUND 4ms]

Note conf.gravatar is supposed to be overriden to false because of the server config:
{
  "config": {
    "reply-to-self": false,
    "require-email": false,
    "require-author": false,
    "reply-notifications": false,
    "gravatar": false
  }
}

But in some cases (like the above), it'll result in some instances being set to true and later/earlier(?) evaluating to false.
This is due to some bad importing practices - a lot of code relies on config, templates or i18n but these get imported multiple times from multiple sources, and they're each carrying state instead of being purely functional. I'm not sure what the best way forward is here - have everything originate from embed.js and pass config as a parameter to each successive import/call?
My idea for how the flow should look like is this:

embed.js loaded
have default config
look for data-isso-* vars
look for endpoint, or fall back to script source
fetch config
use fetched config vars to overwrite default
initialize isso
render postbox
fetch comments
render comments

Further problems

Class vs instance vars
Multiple copies of e.g. config, i18n
Race conditions
Circular imports

I am positive that by introducing a sort-of lock using wait_for, the races for config options should be fixed. Merging, can still be improved upon later.


Please invite me to the GitHub Community Organization

Name
Divyat Agrawal
Discord Username (if applicable)
L-Drago#5984

Welcome to the community!
Lets learn more and contribute more🎉🎉


placeholder gets cut off when using Autolayout + placeholder text is more than 1 line

I use auto layout and when a view is aligned to the bottom of the text view, it cuts off the placeholder label

@devxoul Can you fix this issue? Thanks


Pre- & Post- condition evaluation for Bridge Actions

The work on this PR is to concentrate on the individual nodes actions of the dependency graph that has been a part of plan execution.

Hi @franklinselva . In the SequentialPlanMonitor I am interanally using UP's simulator. Would that make sense here as well for the preconditions?
Part of my reasoning behind that was that it already provides checking of complex precondition expressions.  In UP there is also ongoing work on a temporal simulator that might be interesting, too.

@sebastianstock Thanks for the direction. I will give it a try from my side.

Closing this PR, since a lot of work has been diverged from the time we have started.


importing the main module causes errors while using Angular Universal

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-sm4bvm?file=src/app/app.component.ts
Steps to reproduce
Just simply install the module with ng add and import it in a module (lazy loaded) and run it by server. Everything is working fine without server side rendering.
What is expected?
It's expected at least to run without error and if it's not compatible with Angular Universal, we can handle it with *ngIf="isBrowser".
What is actually happening?
I'm getting these errors:
C:\Users\vahidnajafi\repos\project\dist\server.js:186704
        Object(tslib_es6["__metadata"])("design:paramtypes", [Event]),
                                                              ^

ReferenceError: Event is not defined
    at C:\Users\vahidnajafi\repos\project\dist\server.js:186704:63
    at Module.<anonymous> (C:\Users\vahidnajafi\repos\project\dist\server.js:186708:2)
    at __webpack_require__ (C:\Users\vahidnajafi\repos\project\dist\server.js:21:30)
    at Object.ng-zorro-antd (C:\Users\vahidnajafi\repos\project\dist\server.js:166774:18)
    at __webpack_require__ (C:\Users\vahidnajafi\repos\project\dist\server.js:161065:30)
    at Object../node_modules/ng-zorro-antd/ng-zorro-antd.ngfactory.js (C:\Users\vahidnajafi\repos\project\dist\server.js:161224:31)
    at __webpack_require__ (C:\Users\vahidnajafi\repos\project\dist\server.js:161065:30)
    at Object../src/app/modules/sazframework/sazframework.module.ngfactory.js (C:\Users\vahidnajafi\repos\project\dist\server.js:165959:31)
    at __webpack_require__ (C:\Users\vahidnajafi\repos\project\dist\server.js:161065:30)
    at Object../src/main.server.ts (C:\Users\vahidnajafi\repos\project\dist\server.js:166456:39)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>server: `node local.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\vahidnajafi\AppData\Roaming\npm-cache\_logs\2019-04-04T17_19_42_062Z-debug.log

Environment
Info

ng-zorro-antd
7.2.0

Browser
Chrome

Sorry about the demo link. This is not reproducible due to the error in server side rendering.

After a bit of searching, I just added the following codes to server.js:
const domino = require('domino');
const fs = require('fs');
const path = require('path');
const Zone = require('zone.js');
const DIST_FOLDER = path.join(process.cwd(), 'dist');
const template = fs.readFileSync(path.join(DIST_FOLDER, 'browser', 'index.html')).toString();
const win = domino.createWindow(template);
global['Event'] = null;
global['document'] = win.document;

And now at least it runs fine. But still wondering why this happens.
In addition, some of the components like nz-carousel is not supporting Angular Universal.

We do not support SSR (or universal) yet. Please track our milestone https://github.com/NG-ZORRO/ng-zorro-antd/issues/2474.
Duplicate of #43.

@wendzhue I see in previous issues. But for me, it even doesn't allow me to run my server. Does it occur to you? Or maybe I'm doing something wrong. Thanks.

@vahidvdn Haven't run into that problem before personally. What do you mean by server? Is it an Angualr dev server provided by Angular CLI? From your previous comment, it seems that you write a server yourself.

I use ng-toolkit and it uses Angular Universal under the hood. You mean this doesn't happen in Angular Universal? Maybe relates to ng-toolkit library?
How can I make a reproduction with stackblitz? There should be nodejs server.

@vahidvdn You can create a new repo and share the link with us.

You can create a new repo

Ok, I'll do it. It might take a while.

I guess the reason is that Event is not accessible in the server rendering context

That's true. It's like localStorage. But I'm wondering why this happens only to me.

You can exclude ng-zorro-antd from your projects and try if Event is accessible

Where do you mean I should test? Withing my Angular project.

Hey @wendzhue Here is the GitHub repo, demonstrating the error. Please see the readme.

@wendzhue Any idea why this happens to me?

now NGzorro supposed to have SSR but i get the same error, simple angular cli generated app, ng add ngzorro, then ng add @nguniversal/express-engine, run npm run build:ssr and npm run server:ssr
error
`        Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__metadata"])("design:paramtypes", [Event]),
^
ReferenceError: Event is not defined`

@mapsgeek our doc site is built with static render with SSR, if you meet any problem, plz submit a new issue with repro link.

sorry i didn't read the edits to the server.ts file in the docs, no problem now it works just fine :)

@mapsgeek Where do you exactly mean?

@vahidvdn  https://ng.ant.design/docs/universal/en here
it's pretty much what you have done by adding the global['event']=null
but i don't know why it didn't work when i tried your suggestion but then worked when i replaced my server.ts content with the one on the docs page here.


Implement a script/tool to spin up a primitive test net with DHT bootstrap nodes

For experimentation purposes, we need to be able to quickly spin up and tear down a dev net that includes at least one DHT bootstrap node in order for the embedded IPFS nodes to work.
The number and location of full nodes, light clients, and dht bootstrap nodes should all be configurable. Along with a way to inspect the logs of each these nodes.

while it's not a tool, it is a pretty good template for running other more complex experiments https://github.com/lazyledger/dht-bootstrap-experiment


Values dismatch with last version of Ecto

When I migrated from ecto rc.3 to ecto rc.4, this error has started to appear:
** (Ecto.ChangeError) value `#Ecto.DateTime<2016-05-09 05:09:32>` for `MyApp.User.updated_at` in `insert` does not match type Timex.Ecto.DateTime
       (ecto) lib/ecto/repo/schema.ex:611: Ecto.Repo.Schema.dump_field!/6
       (ecto) lib/ecto/repo/schema.ex:620: anonymous fn/6 in Ecto.Repo.Schema.dump_fields!/5
       (elixir) lib/enum.ex:1473: Enum."-reduce/3-lists^foldl/2-0-"/3
       (ecto) lib/ecto/repo/schema.ex:618: Ecto.Repo.Schema.dump_fields!/5
       (ecto) lib/ecto/repo/schema.ex:567: Ecto.Repo.Schema.dump_changes!/6
       (ecto) lib/ecto/repo/schema.ex:182: anonymous fn/11 in Ecto.Repo.Schema.do_insert/4
       (ecto) lib/ecto/repo/schema.ex:595: anonymous fn/3 in Ecto.Repo.Schema.wrap_in_transaction/6

Looks like it's the same issue that calecto had.

I have the same issue! Would be cool to get it fixed. For now i removed use Timex.Ecto.Timestamps from the model.

I am having the same issue!

I pushed some changes which may address this. They are on master if one of you can give it a go and try to see if you can produce the same error. Sorry for the trouble and the delay!

@JustMikey ping :)

Pretty sure this is working now in 1.1.3, I'll leave this open awhile longer so that one of you has a chance to report back to me that things look good on your end. So far my tests appear to work as expected.

@bitwalker I apologize for the long reply. It works correctly on my side, thank you very much.

Excellent :), thanks for the reply!

Also works here :)


⚠ gorzdrav.org has degraded performance

In 3b21dbc, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 2655 ms

Resolved: gorzdrav.org performance has improved in a5a581b.


Could you share the training loss to improve reproducibility?

Hi, thanks for sharing the datasets! I'm trying to train a flan model using t5 and other backbone models. However i'm not confident enough on how well I reproduced your results. Specifically I got much lower MMLU scores. Could you please share the training loss curve (or simply the loss at convergence?) Below is mine:

I was using similar settings (batch size = 80, max_seq_len = 2300)
The final loss is around 0.6 after smoothing. What about the official values?

hey could you please let me know where can I find the scripts/.gin files to train FLAN on t5x based models ?

you mean you used the huggingface model and fine tuned it on FLAN datasets ?
that works fine for me as well.
btw did you get relatively similar results to what the official FLAN-T5 has ?

I use checkpoints downloaded from huggingface, but I ran with my in-house distributed training code.
I only tested and compared with FLAN-T5 it on MMLU dataset. It turns out that my results are way lower than the official FLAN-T5 checkpoints.


Number of errors found

Enhancement description
In case of errors being found while running, output also the number of errors, not only the fact that it errored. This is invaluable to see whether the changes resolved errors, introduced errors, or had no effect at all.
Suggested approach or solution
Form phpat | 2.55s | ERRORS FOUND to phpat | 2.55s | 16 ERRORS FOUND

That's a good idea, I will add it soon. Thanks!

That's a good idea, I will add it soon. Thanks!

PHPat has been rebuilt as a PHPStan extension (v0.10). This feature is now included 🙂


Java Aug release

Java Aug release

API change check
API changes are not detected in this pull request.


Adding experimental feature of matching DTB to smbinfo

Hey @eriknordmark @deitch @gianlzed @sstabellini need your collective eyes on this -- this hack came from my work on enabling NVidia Jetson and at first I wasn't too thrilled about it -- but it sort of grew on me.
After all -- we do carry a few DTBs around and there seems to be no shame in picking them to use as a measure of last resort on a carefully curated set of systems where they can be useful.
IOW, I guess I don't see much of a downside.
Thoughts?

 Is there any way to make this modular?

 Is there any way to make this modular?

 Is there any way to make this modular?

yeah -- that's how I was thinking too but as I said -- it sort of "grew on me"
for now I'm thinking we just put it there and see how it goes -- one potential option is that we actually remove it altogether if we can figure out how to stick proper DTB into UEFI on Jetson
alternatively (if we can't) we can THEN think about making it more modular
sounds good?

 Is there any way to make this modular?

yeah -- that's how I was thinking too but as I said -- it sort of "grew on me"
for now I'm thinking we just put it there and see how it goes -- one potential option is that we actually remove it altogether if we can figure out how to stick proper DTB into UEFI on Jetson
alternatively (if we can't) we can THEN think about making it more modular
sounds good?

Sure. With just one, it isn't worth much more effort than that.

Sure. With just one, it isn't worth much more effort than that.


Questions about the toolchain

Hi thanks so much for your work. I am not that familiar with Bazel as well as llvm. I wonder whether it can be used to get the llvm IR while using bezel to build the project, e.g., tensorflow. If so, how can we do that? Many thanks.

This is out of scope for this project. This would need to be supported at the level of the cc_* rules and they are defined within bazel. So unless bazel supports this, it can not be done here. An alternative would be to write alternative C++ rules but that will be a large body of work.


System.Text.Json Serializer uses declared array item type rather that runtime type

I'm not sure is it a bug or a feature, but i'm getting unexpected result when performing object-json serialization on asp.net core 3.0:
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100
 Commit:    04339c3a26

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100\

Host (useful for support):
  Version: 3.0.1
  Commit:  19942e7199

Consider the following class structure:
public class ClassA
 {
     public string BasePropA { get; set; } = "value A";
 }
 public class ClassB: ClassA
 {
     public string ChildPropB { get; set; } = "value B";
 }
 public class ArrayContainer
 {
     public ClassA[] Items { get; set; } =
     {
         new ClassB()
     };
 }

When using System.Text.Json.JsonSerializer.Serialize() resulting json includes only BasePropA value, but when serializing it with Newtonsoft.Json.JsonConvert.SerializeObject() it contains both - parent and child fields, which is expected (see img bellow):

Dup of https://github.com/dotnet/corefx/issues/38650.


README: change architecture image

这个 PR 实现什么功能/修复什么问题:
架构图调整
是否需要 backport 到之前的 release 分支:

NONE

Codecov Report

Merging #1822 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1822      +/-   ##
=========================================
+ Coverage    7.58%   7.59%   +<.01%
=========================================
  Files         412     412
  Lines       63607   63521      -86
=========================================
- Hits         4827    4826       -1
+ Misses      58369   58284      -85
  Partials      411     411

Flag
Coverage Δ

#aFlag
7.59% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/util/rbacutils/rbac.go
70.4% <0%> (-0.94%)
:arrow_down:

pkg/compute/models/networks.go
0.92% <0%> (+0.06%)
:arrow_up:

pkg/appsrv/response.go
69.23% <0%> (+3.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a9e89...955a6ea. Read the comment docs.


new version is not as friendly as older versions

Being able to snap between recipes in the chain was much more effective way to figure out what pieces were needed for the recipes.

You can still select mods on the left side by right clicking them. Is that the feature you're looking for or something else?


kernel-devsrc.bbappend: support arm64 kernel 5.19+ on Kirkstone

Adapted backport from Langdale.
Add tool files in the kernel sources needed to build kernel 5.19+ on arm64. This should solve the issue where TorizonCore Builder isn't able to build kernel modules on current Verdin AM62 releases of Torizon OS, which have kernel 6.1.
Related-to: TCB-426

On the original commit, I see they also added this for arm
cp -a --parents arch/arm/tools/gen-sysreg.awk $kerneldir/build/	2>/dev/null || :

I guess we do not need this? I ask since our arm32 modules should also be on a kernel greater than 5.19.

Good point, I ended up ignoring that because I thought it referred to powerpc on a quick glance.
I couldn't find gen-sysreg.awk in arch/arm/tools/ in upstream stable 6.1.y used in our current arm32 SoMs, but I think we should follow the original commit and put the copy command for arm as well, just to be sure.
If the file isn't present the copy command is ignored anyway, so that line shouldn't cause problems.


Error in loading the solution with VS2013

Hi,
I just cloned the repository and I ran into an error in opening the main project.  It seems that you may be using an MSBUILD extension for tasks that I may not have.  It will be great if you can share the extension you are using so I can also replicate.  This is the error I am getting, I am trying to see if I can solve this :-)
D:\github\DNN.Events\DotNetNuke.Events.vbproj : error  : The imported project "C:\Program Files (x86)\MSBuild\MSBuildCommunityTasks\MSBuild.Community.Tasks.Targets" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.  D:\github\DNN.Events\Installation\Project.targets
Thanks!  BTW, this is a great module, I am trying to extend this with my special need which is to be able to select multiple events and be able to check out once instead of per event.
Regards,
David

The MSBUild task routines are put in the open source as well. See the documentation here:
http://dnnevents.codeplex.com/documentation#Install
From version 5.1.0 MS Build is used to support the debug and release build processes. Look here for more details - http://dnntcmsbuild.codeplex.com/. DNN Events up to version 6.1.3 uses DNNTc MSBuild1.9.0.
If you want to remove the dependency from the automatic build with this MS Build structure, just remove all calls to the DNNtc attribute, remove the project.targets as file and remove the reference to the DNNtc in the solution file.


Simultaneous homing of MFA delays seems to cause communication problem where one or both delays hang forever

@ksunden has definite thoughts on the matter. Please fill in.

There seems to be some cross talk where the two delay stages (which communicate on the same serial port) are reading each other's communications. I think, it's hard to see how that would occur given the code.... Would need to see what each is trying to parse when it fails.

I believe this is addressed by yaqd-newport (though have only had one, so have not tested)


Added support for floating point field i.e. Fields.number

Hi I have added a new field 'number' in Fields. I needed this to enter latitude and longitude. Please check.

@anbhole does it fix #100 ?

Yes it does with my latest commit.

On 28-Mar-2016, at 16:43, Pavel Tiunov<EMAIL_ADDRESS>wrote:
@anbhole https://github.com/anbhole does it fix #100 https://github.com/allcount/allcountjs/issues/100 ?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/allcount/allcountjs/pull/111#issuecomment-202343677

Cool! Thanks!

Was there a new allcountjs version released with this added Field type? It would be greatly appreciated as we are precisely requiring it for latitude/longitude data.

@nick13jaremek will release 1.24.1


checking out 3.6 compatibility

Description
Looks like current code passes 3.6 support. Adding test to travis for continued support and testing.
GitHub Issues

#104

Coverage remained the same at 90.835% when pulling 2b4ce579d8af2713f1f656143d280bfe52bc0a4c on mcrowson:36-support into f6387766ea27f673b1778624e16ab7b934c8f475 on refindlyllc:development.


ERROR:dn_object_detect/lib/libyololib.so: undefined reference to `cvRound'

I uesd Ubuntu 16.04 and ros kinectic. When I complied this project, the error is like this:
..._ws/src/dn_object_detect/lib/libyololib.so: undefined reference to `cvRound'
collect2: error: ld returned 1 exit status
dn_object_detect/CMakeFiles/dn_object_detect.dir/build.make:249: recipe for target '..._ws/devel/lib/dn_object_detect/dn_object_detect' failed
make[2]: *** [..._ws/devel/lib/dn_object_detect/dn_object_detect] Error 1
CMakeFiles/Makefile2:1092: recipe for target 'dn_object_detect/CMakeFiles/dn_object_detect.dir/all' failed
make[1]: *** [dn_object_detect/CMakeFiles/dn_object_detect.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Invoking "make -j8 -l8" failed
Can you tell me what is the reason? How can I solve this?
Thanks!

#7 might help. make sure your code is compiled to the same version of OpenCV.

Thank you, but i don't kown how to  point the make file to OpenCV2 as he said.
How to do with that?
Thanks


Get smart attrs without admin permissions in windows?

Is that possible? For example smartmontools/smartctl work fine without admin privileges.

smartmontools/smartctl is written in C++ and they are likely directly accessing the SMART registers.  In C#, this library is making use of WMI and some of the objects are restricted and require elevated permissions to access.
At present there is no practical way around using admin permissions.


Allow people to pick custom colors with SINCRONI_EMBED_COLOR

def random_color():
    return random.randint(0, 0xFFFFFF)

basically this would at least the random.randint would be a random color option

Also basically make the command and such for per server and chat_type.

Mostly done:
https://github.com/JDJG-Holding-Team/Sincroni/blob/939be08a4aeda292d831f7b75ee0d5787b3cb878/cogs/global.py#L342
Just needs a command for it.

color picker with slash commands is going to be a nature since discord does not have a default.

https://github.com/JDJG-Holding-Team/Sincroni/commit/78a249e4c8fc305b84f05d76fe52dd211c034f04#commitcomment-138773859
This is the color list creation which I can always again in the future.

Stuff:

https://github.com/JDJG-Holding-Team/Sincroni/commit/ff75eee93d1a289d6b4a44e969c08d0f020466cc
Also:
https://github.com/JDJG-Holding-Team/Sincroni/blob/ff75eee93d1a289d6b4a44e969c08d0f020466cc/cogs/global.py#L453
https://github.com/JDJG-Holding-Team/Sincroni/blob/ff75eee93d1a289d6b4a44e969c08d0f020466cc/cogs/global.py#L442
https://github.com/JDJG-Holding-Team/Sincroni/blob/ff75eee93d1a289d6b4a44e969c08d0f020466cc/cogs/global.py#L463

https://github.com/JDJG-Holding-Team/Sincroni/commit/aec9e5974daafba806ee06170c9f175081b913c2
may only need line 463 addressed.

class ChooseColor(ui.View):
    message: Union[discord.Message, discord.WebhookMessage, discord.InteractionMessage]

    def __init__(self, user_id: int, *, timeout: float = 60.0):
        super().__init__(timeout=timeout)
        self.user_id: int = user_id
        self.value: Optional[int] = None

    def _disable_all_buttons(self) -> None:
        for child in self.children:
            if isinstance(child, ui.Button):
                child.disabled = True

    async def interaction_check(self, interaction: discord.Interaction, /) -> bool:
        if interaction.user.id != self.user_id:
            await interaction.response.send_message("This is not for you!", ephemeral=True)
            return False

        return True

    @ui.button(
        label="Color Integer",
        style=discord.ButtonStyle.green,
        custom_id="color_int",
    )
    async def choice_1(self, interaction: discord.Interaction, _: ui.Button) -> None:

        return

    @ui.button(
        label="Color Text",
        style=discord.ButtonStyle.green,
        custom_id="color_text",
    )
    async def choice_2(self, interaction: discord.Interaction, _: ui.Button) -> None:

        return

I don't know.

https://github.com/JDJG-Holding-Team/Sincroni/pull/19
This may be enough to close this.

It appears to be complete.


Replace animation with AnimatedContent

Looking at ComposeStateChanger, its code seems very complicated, mostly due to animations.
Maybe using AnimatedContent composable in place of custom baked animation system would allow for cleaner code?
I can take a stab of that in the PR if you want.

Hm, now that I think about it, it would be a breaking change, because AnimationConfiguration would no longer accept Modifiers. Is this worth it?

The library is 0.9.X because it was highly likely that breaking changes would occur in the future.
Is AnimatedContent no longer experimental? I cannot accept code in the library that relies on experimental features.

Ah, you are right, it is experimental. But I feel like half of the animation APIs in Compose are experimental (and it does not look like they are going to get either changed or stabilized any time soon), so it's a practical thing to use it.

It's practical thing to use them in apps, but irresponsible to expose it in libraries (yes, I mean that even for accompanist).
So until they're stabilized, a better course of action is to reimplement ComposeStateChanger in such a way that it uses AnimatedContent, but it shouldn't be part of the library.
If there's something that the library should be doing, it's https://github.com/Zhuinden/simple-stack-compose-integration/issues/15, but I haven't figured out how to do it without creating scoped services, but that depends on whether scoped services are provided (and is otherwise optional).

Merging #17 should have done this.


Container with childGap prop added applies margin to bottom of a child element, even if it's the only child

To fix, I believe that the last child should never have a bottom margin applied to it:

@JCarmine Can you link to the page so we can look at the dom? Want to make sure there isn't a sibling of the button that's hidden, because we can't repro this.
If you can repro here, that would help
https://codesandbox.io/s/childgap-repro-bug-154k4?file=/src/MyComponent.js

Issue is visible on main

Issue was caused by a bug in BuildPartner; closing.


VirtualBox breaks with kernel 6.12

Describe the bug

VirtualBox is unable to start VMs with kernel 6.12. It works with 6.11.
Steps To Reproduce
Steps to reproduce the behavior:

NixOS 24.11 (with kernel 6.12)
Install VirtualBox (virtualisation.virtualbox.host.enable = true;)
Create VM (Windows 10 was what I chose)
Try to start VM

Expected behavior

Start VM.
Actual behavior

Error message:
VirtualBox can't operate in VMX root mode.
Please disable the KVM kernel extension, recompile your kernel and reboot
(VERR_VMX_IN_VMX_ROOT_MODE).

(new lines added for better readability)
Additional context

It works with Linux kernel 6.11.
Edit: modprobe -r kvm_intel makes VirtualBox work on 6.12. In 6.11 kvm_intel can coexist with VirtualBox.
Metadata

system: "x86_64-linux"
host os: Linux 6.12.3, NixOS, 24.11 (Vicuna), 24.11.710650.e2605d0744c2
multi-user?: yes
version: nix-env (Nix) 2.24.10
channels(root): "nixos-24.11"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Sounds like a config issue.
https://forums.virtualbox.org/viewtopic.php?t=111681
https://forums.virtualbox.org/viewtopic.php?t=34880

Sounds like a config issue. https://forums.virtualbox.org/viewtopic.php?t=111681 https://forums.virtualbox.org/viewtopic.php?t=34880

Thanks for the feedback! Yeah, I considered that as well, however it is not enabled in the config explicitly (but implicitly). So module kvm_intel is enabled, however this is true for 6.11 and 6.12 and only the latter breaks VirtualBox.
The proposed fix modprobe -r kvm_intel does indeed work for 6.12, but it still seems like a bug as KVM and VirtualBox should be able to coexist. And as mentioned a few times, 6.11 does not need this (and kvm_intel is loaded).

Given that the second link is from 14 years ago, as in the problem and solution haven't changed in that long, I doubt a kernel version bump is the cause here. vbox is a type-2 hypervisor, kvm is type-1, afaik they've always been incompatible. So blacklisting the module in your config seems to be the way to go.

Also running into this issue after upgrading to 24.11 from 24.05. Changed nothing in the config concerning kvm or virtualbox.
For now the workaround is effective (Thanks @acmelabrat for that - modprobe -r kvm_intel ; modprobe -r kvm works here), but I'm also puzzled as to why/how this worked in the previous kernel but does no longer.

@unode See my previous comment, this is not a new error.

@eclairevoyant I understand, but like @acmelabrat my (same) configuration allows coexistence of kvm_intel and virtualbox modules before migrating to NixOS 24.11.
If this is now no longer the case, should a check be made globally to ensure that kvm and virtualbox aren't simultaneously loaded?
In other words, if a user enables virtualisation.virtualbox.host.enable = true; but virtualbox still fails to run correctly for them, can a safety net or a better error or warning (e.g. at config level) be shown?

I imagne that's just good luck in terms of the module not getting loaded, since again, this incompatibility is far older than 24.05.

I imagne that's just good luck in terms of the module not getting loaded, since again, this incompatibility is far older than 24.05.

Tested this on Debian and it works with KVM module enabled. The error is reproducible if I actually start VMs simultaneously with KVM and VirtualBox, but that is beside the point; I was just curious.
Just for the record: I can start KVM and VirtualBox VMs in succession just fine on Debian too (which implies both modules being enabled).

Huh, with a broader search I found this one:
https://forums.opensuse.org/t/warning-for-virtualbox-users-and-kernel-6-12/180892
It is about VBox 7.1, but it is apparently a 6.12 change and unrelated to VBox' version. Adding this to configuration.nix resolves the issue, while still keeping the KVM module enabled.
boot.kernelParams = [ "kvm.enable_virt_at_load=0" ];

This is still an issue as this is an extra step that is only necessary with 6.12, so my guess would be that the parameter should be added to 6.12 directly at install.

Would virtualisation.virtualbox.host.enableKvm = true; help?

Would virtualisation.virtualbox.host.enableKvm = true; help?

Not a real solution, however it's interesting. The caveat is that the performance is likely that of KVM which is not good for Windows guests. I am going to give it a try nonetheless.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/issue-with-virtualbox-in-24-11/57607/2


Guiset regression on some systems

Reported in https://github.com/tridactyl/tridactyl/issues/3418
There must be some subtle difference between how the two messengers read and write.

Can repro on win8, native 0.3.3.

Think I've got it. writePref depends on read returning "" when it fails, but read doesn't do that.


Defib gives no feedback when someone is rotting

Description

Even if you can examine them, it should still tell you.
Reproduction

Try to defib someone who is rotting
Clicking them doesn't give any feedback
It should let you defib but give the error that the person is rotting and fail
Screenshots

Additional context

Fixed by #17167 I think