[accessibility-quiz]: experience and suggestions

Describe the Issue
i just noticed that, starting from the Learn Accessibility by Building a Quiz 1 class, i started to see many more codes i haven’t seen before, none of them really introduced, but was just told to write them down or had to research them based on the prompt.
it felt a bit like a drastic change compared to the previous classes.
i can understand that it might be hard and time/energy consuming to "introduce" new codes every time, but since it has been done fairly well up until that point, it felt weird that that wasn't an option anymore.
maybe it could be better if you let people know since the beginning that there are other sources they should/could check during the course of the projects to understand better all the bits and bobs?
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-1
Your code
none

Expected behavior
either a constant general "behaviour" similar throughout a course or an heads up early on saying that things might differ from project to project and that the best way to deal with it is x y z.
Screenshots
No response
System

Device: Zenbook
OS: Linux Mint 20.3
Browser: Brave
Version: v1.43.93

Additional context
No response

Thanks for reporting @lucyferu. We try to avoid this - ideally and generally, the first time a new concept/property/element is introduced, we like to give a short explanation on it, what it does, and the syntax, etc.
I don't suppose you know what specific steps you were seeing this on are? or what things you were asked to use that you hadn't been taught yet? If you're willing, a list of these would be pretty awesome.

If any of the code given in the Accessibility Quiz project has not been introduced yet, I suggest the following:

Automatically add the code as boilerplate
Remove the lessons mentioning it
Add a step mentioning the boilerplate automatically being added

The reason for this is the project is supposed to teach accessibility concepts - not CSS properties that are unrelated.

If you're willing, a list of these would be pretty awesome.

i can definitely try to send you a list, i will need to go back to them and check step by step and i can't do that right now, so bare with me a bit more? 😅

Everything has a bit of a learning curve. Just supplement the course content with books that expound more on the matter. You'll learn a great deal via your own research.

Everything has a bit of a learning curve. Just supplement the course content with books that expound more on the matter. You'll learn a great deal via your own research.

i do that anyway, it just that the "lessons" style suddenly changed.
sometimes new codes are introduced, sometimes they're not.
i think it would be better to have a continuity.

If you're willing, a list of these would be pretty awesome.

sorry, haven't managed to get around this list yet.

I don't mean to speak for the original poster, but I feel the exact same way about this particular lesson, so I figured I would post a comprehensive list of what steps I personally thought could use some reworking:
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-3
This one isnt that bad since we also had to write this line of code in I believe 1 or 2 other lessons, but it was glossed over a bit when it was introduced making this step a little confusing.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-8
this step wasn't too bad either, it just lacked some information in my opinion. This is the first time we have been introduced to a value like max(100px, 18vw) for the property width. Are there other properties/values formatted like this? Does it take additional arguments? What does vw stand for? If your philosophy is to have students research the topics themselves, that's fine (and a useful skill to teach/learn!) but that's not how the previous lessons were, so I figured I would mention this step.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-9
once again I am a being a bit nit-picky with this step. This is a bit of an abrupt introduction to aspect ratio - I found the formatting of the value 35 / 4 a bit odd... what units of measurement are being used here? are there other ways to format the value? It would also be nice to get an explanation of what rem means. I also didn't see an aspect ratio of 35 / 4 mentioned anywhere on the freeCodeCamp Style Guide.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-13
this is one of the steps that is most problematic in my opinion - even though I've spent some time working with HTML and CSS, I had no idea what this step wanted me to do. Turns out there is an element > element {} selector - I don't believe any lesson before mentioned this selector at all. It might be useful to explain how it's different from the element element {} selector, especially considering the element > element {} selector is used twice more within this lesson. On top of this, the space-evenly value (or any of the other values, for that matter) for the justify-content property were not properly introduced before this step.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-14
another problematic step. You are previously taught to add an action attribute to the form element to add a submit function, and that's it. This step wants you to also add a method attribute with a value of post - something that wasn't explained previously.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-26
i think this step should simply be split into two. The explanation of the step is really concise and I think either a more detailed explanation or an additional step would clean this up.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-33
I'm beginning to realize the CSS portion of this lesson is the one with the most issues - this step is another one. Never before this step was the element::before pseudo-selector mentioned. I know in a previous lesson the element::after selector was used, but since it was kind of glossed over, by the time I saw this step I had no idea what it wanted - especially with how little explanation there is.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-35
this step's explanation seems unfinished? What text content should I add? It also seems a little weird to add text content and a label for an element that hasn't been put on the page yet, at least in this context.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-40
this is a simple step but the test is a little too strict. For some reason, it didn't take it when I used an input element, and I had to use a button which is not the main method used to add a submit button in previous lessons.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-42
Might be helpful to explain what <br /> does for this step.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-45
this step was the most confusing one for me. What in the heck does this want me to do? What is a contrast ratio?? This step made me feel like I skipped a whole lesson or something.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-46
I don't believe it was ever explained in a previous lesson how to remove underline from text in CSS.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-47
space-between is another possible value of the property justify-content that we've never seen before this step. Considering we have just been introduced to flexbox, it was a bit jarring just to be asked to "vertically center" the elements within the header. Also, how does one exactly fix the header to the top of a viewport? What even is a viewport? (for the record I know, just some questions someone new is probably asking). Never before this step were the properties of position or top properly explained.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-48
I just feel that anyone doing this lesson for the first time likely isn't seasoned enough to understand what this step is asking. The concepts used to complete this step were all introduced previously, but the explanation is too vague in my opinion. Where exactly am I adding padding? and how much?
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-53
at this point it seems like the lesson just wants me to put in the code wrong first and use the hints to finish the steps. Things just aren't being explained.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-60
again, the CSS list-style property was never introduced before this lesson.
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-65
this step has you use a universal selector, *. This has been done in previous lessons, but never explained enough that the user would understand how to "select all elements".
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-66
this is a pretty abrupt introduction to at-rules, but at this point I am being pretty redundant.
Overall, this lesson had me convinced that I accidentally skipped a week's worth of material, but I hadn't. Perhaps the philosophy with this lesson was to push the user to research and teach themselves (which is absolutely fine, for the record!). The soft-skill to research and find solutions for yourself is invaluable and should be taught - I just noticed that this lesson was quite the departure from the previous ones and may leave users feeling frustrated.
Many of the steps just had you copying and pasting many css properties at once, which doesn't feel super conducive to learning CSS. All in all, I believe this lesson simply tries to teach too much at once, and leaves lots of things unexplained.
Depending on what the freeCodeCamp team is trying to achieve, I would personally either make it clear to the user that they are expected to look up topics and research to fill in the knowledge gaps (and maybe provide some sources), or distribute some of the topics introduced in this lesson to some of the earlier ones. The first couple of lessons in this block were actually quite short, so I think the latter solution is pretty feasible.
Quick disclaimer: I am just an average user and I don't feel entitled to any of these adjustments. I am merely trying to provide an incredibly detailed list of what I personally found difficult with this lesson so that anyone who is interested has as much info as possible. freeCodeCamp is and always will be a fantastic resource and the fact that it is free is mind-blowing - so please don't take this post as an insult!!!
Thanks so much.

@mcp1997 Thank you for the detailed feedback. It is important to remember that the new curriculum format is designed to be heavily reliant on the hints, as well as the order they are given. The hints do often just give the answer as code to copy-pasta.
Here are my comments on some of the points:

I found the formatting of the value 35 / 4 a bit odd... what units of measurement are being used here?

There are no units. It is a fraction (ratio) of the width to the height.

I also didn't see an aspect ratio of 35 / 4 mentioned anywhere on the freeCodeCamp Style Guide.

The aspect ratio of the full-size logo is 35 / 4. So, the style guide just says to not distort the logo.
Perhaps we should remove this bit of detail?

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-26
i think this step should simply be split into two. The explanation of the step is really concise and I think either a more detailed explanation or an additional step would clean this up.

I will push back on this a little, just because we do not necessarily want multiple steps in a row where nothing is taught/learnt.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-33
I know in a previous lesson the element::after selector was used, but since it was kind of glossed over, by the time I saw this step I had no idea what it wanted - especially with how little explanation there is.

Considering how little is needed to be done for the lesson, and the explicitness of the first hint, I cannot see anything productive being added to this lesson.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-35
this step's explanation seems unfinished? What text content should I add?

The main thing we tried out in this project was giving Campers the freedom to add any text they want instead of the usual "You have to add exactly this text ...". So, you can add any text you want. I do agree, this could be done better by providing enough context for Campers to put some reasonable text down.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-40
this is a simple step but the test is a little too strict. For some reason, it didn't take it when I used an input element, and I had to use a button which is not the main method used to add a submit button in previous lessons.

This should not be the case. We specifically allow for either an input or button element in the tests:
https://github.dev/freeCodeCamp/freeCodeCamp/blob/51b6b8a728e822e53d66da2698b70bfafbd9ba98/curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/6145f685797bd30df9784e8c.md#L14-L18

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-45
this step was the most confusing one for me. What in the heck does this want me to do? What is a contrast ratio?? This step made me feel like I skipped a whole lesson or something.

I am not sure what would improve this, without having a very lengthy description explaining what "contrast" means, and what a "ratio" is. Frankly, these are common English words.
The instruction does leave some guess work, but, at the end of the day, the easiest solution is to make the font colour white, seeing as the background is dark.
The hope with the lesson is Campers will take the time to input multiple values to experiment with the contrast.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-46
I don't believe it was ever explained in a previous lesson how to remove underline from text in CSS.

The answer is given in the first hint. So, I am not sure we need an explanation.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-48
... the explanation is too vague in my opinion. Where exactly am I adding padding? and how much?

The point of the lesson is almost any amount of padding can be added. Hopefully, Campers will test/experiment until it "looks" right.

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-53
at this point it seems like the lesson just wants me to put in the code wrong first and use the hints to finish the steps. Things just aren't being explained.

Again, the main issue is there is nothing to learn in this step - it is a "make look nice" step. So, it is open to multiple values and methods of getting to those values.

at this point it seems like the lesson just wants me to put in the code wrong first and use the hints to finish the steps.

Why do you say this? What did you originally put?

In general, if I redid the project lessons, I would remove most of the CSS steps - they have nothing to do with accessibility (yes, yes, nice visuals improves accessibility, but there is nothing specific here).

Based on this, some immediate actionables might be:

step-8: Explain the max function.

Unfortunately, this is the only project that uses this function. So, we cannot easily explain it earlier.

step-13: Explicitly say: Use the > selector to....
step-14: Already being tracked in #48002
step-35: Rephrase to say something along the lines of: Add a CSS -related question to the label text
step-42: Explain the use of br elements. Specifically, their use in addresses.
step-60: This is probably an opportunity to explain how ul/li elements are useful in demarcating groups and flow, but their default styling could be misleading. - Add a description saying that, but better.
step-66: This is already a long description, but is an important enough topic that we could split it up into two lessons further introducing at-rules.

For most of the other CSS issues brought up, the fact is:
a) This project needs to focus on accessibility
b) The first hints are so explicit, there should be no need for the same to be put in the description

Thanks so much for your quick and detailed response, I really appreciate you taking the time to explain each step I mentioned. It does seem your philosophy is to have users struggle a bit, use hints, do some tweaking, trial and error, etc.
I was able to get through the lesson with my prior knowledge + some googling + hints, I may have just gotten a little carried away with trying to put myself in an absolute beginner's shoes. I think in general I just saw the learning curve spike a little bit with this lesson.
That being said I think the actionables you came up with are great ideas to help reduce confusion about all the new topics introduced in this lesson, and I think adding a bit of context when asking users to put in their own content would be fantastic.
Thanks again for your careful attention to this issue!
Cheers

I am not sure what would improve this, without having a very lengthy description explaining what "contrast" means, and what a "ratio" is. Frankly, these are common English words.

I just wanted to point out that the Markers project talks in some length about color contrast. (let me know if you want me to get a ref to the step(s)). It doesn't mention ratios. Maybe it can?
Randell just found another bug in this curriculum, please see:
https://forum.freecodecamp.org/t/learn-accessibility-by-building-a-quiz-step-56/565245

Also can someone fix the title of this issue to something that specifically mentions the build a quiz project? (It would make it easier to find if anything else comes up)

Also can someone fix the title of this issue to something that specifically mentions the build a quiz project? (It would make it easier to find if anything else comes up)

We can still do this, but we have started tracking projects with multiple issues through milestones: https://github.com/freeCodeCamp/freeCodeCamp/milestone/29

I have opened another issue to track step-56: https://github.com/freeCodeCamp/freeCodeCamp/issues/48182

at this point it seems like the lesson just wants me to put in the code wrong first and use the hints to finish the steps.

Why do you say this? What did you originally put?

Yes for me this is what works best when I don't know what to do in one of these steps. I click on Check first (before I type anything), then follow the hint. Then click on it again, and follow the hint etc. (so yes, I too have encountered a step or two where this method is the one that helps me get through it. First one to come to mind was step 56 because I didn't know why they wanted the new rule to be at the top - in fact I still don't. I typed it in at the bottom first.)

Personally I want to add that in step 18 you are asked to link anchors to page elements by their ids, but element links are never encountered or explained before that point, so you have to rely on hints to find out that href needs to be set as #element-id.

Closing this as stale. Many of the discussed issues have been addressed. Others are detailed in existing issues.


Target does not change saving to an existing link

I am trying to update the target on an existing link using this code:
    String one = "C:"+File.separator+"Tmp"+File.separator+"1.txt";  // Already exists
    String two = "C:"+File.separator+"Tmp"+File.separator+"2.txt";  // Already exists
    String link = "C:"+File.separator+"Tmp"+File.separator+"link.txt.lnk";
    ShellLink.createLink(one,link);
    ShellLink slink = new ShellLink(link);
    slink.getLinkInfo().setLocalBasePath(two);
    slink.saveTo(link);

At the end of this operation, the link is still pointing to file 1.txt and the program did not generate an error to indicate anything is wrong.  I think the code should either update the link or throw an error telling the user the operation did not complete as anticipated.

Setting local base path is not enough to define target file location. Primary structure the system uses to determine link target is LinkTargetIDList. In fact, I don't know real reasons for creating so many complicated and duplicated things, i've only created tool for managing it.
I've added separate function for setting target path of ShellLink object using LinkTargetIDList.

I see.  Leave it to Microsoft to make things more complicated than they need to be.
I appreciate your adding the function to set the target.  I will update my code to use that.  Thank you.


test: add check for the correct admin UI redirect, for #27

The tests are fine.
✅ install from directory
❌ install from release
As expected.


If no logreason is entered, use Removal reason title as {reason}

So, we're basically logging all removals to a log sub for statistical purposes, and we have a bunch of fixed removal reasons (specific sub rule, "Sitewide rule" or "Other")
Currently, there is no way to do this automatically - but we have to manually fill in the removal reason, such as "Rule 6". It'd be swell if it instead worked the following way:

If the Logreason text field at the bottom the remove post is optional
If the mod selects a removal reason with a title, and no text is manually entered in the logreason text field, just set {reason} to the title of the removal reason
If the value of the Logreason text field is changed by the author, use this.

[Note: this should coincide with the RR cleanup/restructuring]


Fails to launch due to ArgumentException

I am running vim in cygwin with a build of  omnisharp-rosyln. When I launch vim and open a .cs file, it asks which of the 19 solution files in my repository I want to load. I select the solution file. But when the .cs file opens, I get the error
channel 0 closed: '   at OmniSharp.HostHelpers.Start(Func1 action)`
And :messages reveals
channel 0 open: 'System.ArgumentException: OmniSharp only supports being launched with a directory path or a path to a solution (.sln) file.'
channel 0 open: 'Parameter name: path'
channel 0 open: '   at OmniSharp.Services.OmniSharpEnvironment..ctor(String path, Int32 hostPid, LogLevel logLevel, String[] additionalArguments)'
channel 0 open: '   at OmniSharp.CommandLineApplicationExtensions.CreateEnvironment(CommandLineApplication application)'
channel 0 open: '   at OmniSharp.Http.Driver.Program.<>c__DisplayClass0_1.<Main>b__1()'
channel 0 open: '   at OmniSharp.CommandLineApplication.<>c__DisplayClass11_0.<OnExecute>b__0()'
channel 0 open: '   at OmniSharp.CommandLineApplication.Execute(IEnumerable`1 args)'
channel 0 open: '   at OmniSharp.Http.Driver.Program.<>c__DisplayClass0_0.<Main>b__0()'
channel 0 open: '   at OmniSharp.HostHelpers.Start(Func`1 action)'
CONNECTION: <urlopen error timed out>

Subsequently no omnisharp functionality works in vim, with it unable to connect to the server.
Contents of my vimrc
execute pathogen#infect()
let g:OmniSharp_server_path = 'C:\Program Files\omnisharp-roslyn\artifacts\publish\OmniSharp.Http.Driver\win7-x64\OmniSharp.exe'
let g:OmniSharp_timeout = 1
let g:OmniSharp_start_server = 1
let g:OmniSharp_port = 2000
syntax on
filetype plugin on
filetype plugin indent on
"... and other stuff

If you're in a linux-like environment but using a Windows OmniSharp-roslyn, you'll need to add let g:OmniSharp_translate_cygwin_wsl = 1 to your .vimrc

I have tried that. I just tried it again now. I get the same error: 'System.ArgumentException: OmniSharp only supports being launched with a directory path or a path to a solution'

It's pretty hard to guess what your environment looks like from the few details you've given. Where did your Omnisharp-roslyn come from? Have you tried downloading the latest release from https://github.com/OmniSharp/omnisharp-roslyn/releases ?

Also, what does your folder structure look like? Do you have 19 .sln files at the root of your repo?

I'm using Omnisharp from https://github.com/OmniSharp/omnisharp-roslyn/. I built it locally from the master branch. The build was successful and I can launch the server.
My directory structure looks like repo/src/SolutionFile.sln. Yes, there are about 19 solution files but they are not at the root of the repo.
I can more information on Monday.

I built from revision 05bf8fc9a8461b6ec38bacff6d0380c875aa8bda

Well that's good to narrow it down. In that Console project, let's try some things. Try adding this to your .vimrc:
let g:OmniSharp_translate_cygwin_wsl = 1
let g:OmniSharp_proc_debug = 1

Now when you load a .cs file you'll get some info about what is getting executed, please post the output here.

Sorry for the delay in response. I have now found the cause. Of course it was an environment problem. My cygwin is set up uniquely with respect to my /home/<username> directory.
In my case adding the following line to OmniSharp#util#get_start_cmd helped:
let solution_path = substitute(solution_path, '/home/mate/', '/Users/mate/', 'g')
I think the "wslpath tool" mentioned in the body of that function might help this. In any case, the issue is resolved.


pre-commit fails inside a docker container: nodeenv returned non-zero exit status 2

I've dockerized my project and I want to be able to execute pre-commit hooks within the container. This currently work for everything except pyright.
Here's my .pre-commit-config.yaml file:
repos:
  - repo: local
    hooks:
      - id: pyright
        name: pyright
        entry: scripts/type-check.sh
        language: system
        types: [python]
        pass_filenames: true

Here's my scripts/type-check.sh:
#!/bin/bash -ue

if [[ -n $* ]]; then

    # Don't attempt to source a virtualenv when you're running inside the container.
    # The correct environment is the global environment in that case.
    if ! type -f /.dockerenv >/dev/null 2>&1; then
        echo "Attempting to activate a virtualenv if present..."
        # Active virtual environment (check several possibles places), it helps if the script
        # is executed from PyCharm (e.g. configuring it as an External Tool) or
        # with GitHub Desktop

        # shellcheck disable=SC1090
        test -f venv/bin/activate && source "$_"

        # shellcheck disable=SC1090
        test -f .venv/bin/activate && source "$_"

        # shellcheck disable=SC1090
        test -f env/bin/activate && source "$_"
    else

    pyright "$@"
fi

As you can see, the reason we're using a script is because our developers tend to use a name for their virtualenv that they personally like the best, so we can't use a hook like: repo: https://github.com/RobertCraigie/pyright-python directly because it forces us to hardcode the venv name. However, this setup works fine locally and should in theory be fine in the container too.
Instead we get this error:
Running inside the container, skipping virtualenv activation.
 * Environment already exists: /root/.cache/pyright-python/nodeenv
Traceback (most recent call last):
  File "/usr/local/bin/pyright", line 8, in <module>
    sys.exit(entrypoint())
  File "/usr/local/lib/python3.8/site-packages/pyright/cli.py", line 34, in entrypoint
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/lib/python3.8/site-packages/pyright/cli.py", line 19, in main
    return run(*args, **kwargs).returncode
  File "/usr/local/lib/python3.8/site-packages/pyright/cli.py", line 25, in run
    pkg_dir = install_pyright(args, quiet=None)
  File "/usr/local/lib/python3.8/site-packages/pyright/_utils.py", line 64, in install_pyright
    node.run(
  File "/usr/local/lib/python3.8/site-packages/pyright/node.py", line 105, in run
    binary = _ensure_available(target)
  File "/usr/local/lib/python3.8/site-packages/pyright/node.py", line 38, in _ensure_available
    return Binary(path=_ensure_node_env(target), strategy=Strategy.NODEENV)
  File "/usr/local/lib/python3.8/site-packages/pyright/node.py", line 65, in _ensure_node_env
    _install_node_env()
  File "/usr/local/lib/python3.8/site-packages/pyright/node.py", line 98, in _install_node_env
    subprocess.run(args, check=True)
  File "/usr/local/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-m', 'nodeenv', '/root/.cache/pyright-python/nodeenv']' returned non-zero exit status 2.

I'm not aware of how to specify extras with pre-commit but you can try it out today with
python -m pip install 'git+https://github.com/RobertCraigie/pyright-python.git#egg=pyright[nodejs]'

When released, it will be
pip install pyright[nodejs]

Please let me know if you run into any issues with this new setup.

As you can see, the reason we're using a script is because our developers tend to use a name for their virtualenv that they personally like the best, so we can't use a hook like

Would this solution help here? https://github.com/RobertCraigie/pyright-python/issues/203#issuecomment-1706832522


is this mamba thing really required ?

Actually I just created a virtual environment and made a git + install pip requirements.
Works fine so far, also webui starts, however Voice generation only works on CPU it says. So i guess that mamba thing is for cuda.
Automatic1111 seems to work without mamba?

No, it's just one way to install it. If you can install Cuda and Pytorch and the libraries, you can just the requirements.txt files instead.

I did the same thing but I am getting Loading Bark models...
preload_models No GPU being used. How can I make it use gpu?

No, it's just one way to install it. If you can install Cuda and Pytorch and the libraries, you can just the requirements.txt files instead.

thx for the reply. Can you pls give a bit more detail how to do it now exactly without miniforge and just using venv?
a 1 click installer of course would be the greatest :D
There is no pure requirements.txt:
requirements-dev-pip.txt
requirements-pip.txt
which one to use ?
I guess i have to add those from environment-cuda.yml ?

If you are using a normal python venv then activate that venv and install this
pip install torch==2.0.0+cu118 torchvision --extra-index-url https://download.pytorch.org/whl/cu118

Note that cu118  from both parts of the commands must match the cuda version you have installed

torchaudio 2.0.2 requires torch==2.0.1, but you have torch 2.0.0+cu118 which is incompatible. should I install it?

I haven't tested the pip, but the mamba install does give you torch==2.0.1 at the end, so that sounds right.

I did that but now it says the opposite ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchvision 0.15.1+cu118 requires torch==2.0.0, but you have torch 2.0.1 which is incompatible.

I'll be in Bark Discord probably very late Monday (Tuesday AM really).


hardcode TLS ciphers to modern standards

Hardcode docker registry certs to mozilla modern recommendations, as upstream project doesn't currently have this configurable.

I did try to go this route, but when I noticed the cipher list was still hardcoded on the master branch, it didn't leave much option.
We can look at contributing this back as something that can be configured, but as of today if we want to harden this, we need to change the config in the sources.


Missing Element.outerHTML

Ver: 1.00RC
Closure definition is in ie_dom.js:
https://github.com/google/closure-compiler/blob/15e8c339cb9d6d88ca16181c529f809b233f077f/externs/browser/ie_dom.js#L1105-L1109

A PR has been raised in upstream and we can close this issue once it has been merged. See google/closure-compiler#3397

Thanks

This can now be closed as the PR has merged upstream


v1.3.0 Deployment for Ink Mainnet

Add new chain
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).

Chain_ID: 57073

When trying to verify the deployment, I'm getting:
ERROR: SignMessageLib not deployed at 0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2

When trying to verify the deployment, I'm getting:
chain 57073 exists on Chainlist
RPC reported chain 57073
CompatibilityFallbackHandler deployments:
• canonical deployment OK
CreateCall deployments:
• canonical deployment OK
GnosisSafe deployments:
• canonical deployment OK
GnosisSafeL2 deployments:
• canonical deployment OK
MultiSend deployments:
• canonical deployment OK
MultiSendCallOnly deployments:
• canonical deployment OK
GnosisSafeProxyFactory deployments:
• canonical deployment OK
SignMessageLib deployments:
ERROR: SignMessageLib not deployed at 0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2

Thanks for reporting. I was using branch v1.3.0 which is missing SignMessageLib deployment.
I used v1.3.0-1 branch now and contracts are now deployed. Also, changed deployments to eip155 addresses.
Verification status for CompatibilityFallbackHandler: SUCCESS
Verification status for CreateCall: SUCCESS
Verification status for DefaultCallbackHandler: SUCCESS
Verification status for GnosisSafe: SUCCESS
Verification status for GnosisSafeL2: SUCCESS
Verification status for GnosisSafeProxyFactory: SUCCESS
Verification status for MultiSend: SUCCESS
Verification status for MultiSendCallOnly: SUCCESS
Verification status for SignMessageLib: SUCCESS
Verification status for SimulateTxAccessor: SUCCESS
✨  Done in 3.50s.

Looks good now!
Verified with:
$ npm run -s review:verify-deployment -- --version v1.3.0 --chainId 57073 --rpc $RPC --verbose
Parsed options:
{
  version: 'v1.3.0',
  chainId: '57073',
  rpc: '...',
  verbose: true
}
chain 57073 exists on Chainlist
RPC reported chain 57073
CompatibilityFallbackHandler deployments:
• eip155 deployment OK
CreateCall deployments:
• eip155 deployment OK
GnosisSafe deployments:
• eip155 deployment OK
GnosisSafeL2 deployments:
• eip155 deployment OK
MultiSend deployments:
• eip155 deployment OK
MultiSendCallOnly deployments:
• eip155 deployment OK
GnosisSafeProxyFactory deployments:
• eip155 deployment OK
SignMessageLib deployments:
• eip155 deployment OK
SimulateTxAccessor deployments:
• eip155 deployment OK


GUI(swing)

Updating this as a swing project & making JFrame with console + option pane(changing audio quality ..ect) would be cool!

#5


Oven does not show up

I have a GE Profile convection oven that does not show up under this integration.  I have tried reinstalling the custom component, rebooting HA, and verifying the oven shows up in the SmartHQ app for GE.  There is an error that keeps popping up in my HA log.
2021-07-28 05:19:46 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/config/custom_components/ge_home/update_coordinator.py", line 287, in on_device_initial_update
    self.maybe_add_appliance_api(appliance)
  File "/config/custom_components/ge_home/update_coordinator.py", line 121, in maybe_add_appliance_api
    api.build_entities_list()
  File "/config/custom_components/ge_home/devices/base.py", line 112, in build_entities_list
    e for e in self.get_all_entities()
  File "/config/custom_components/ge_home/devices/oven.py", line 34, in get_all_entities
    cooktop_config: ErdCooktopConfig = self.appliance.get_erd_value(ErdCode.COOKTOP_CONFIG)
  File "/usr/local/lib/python3.9/site-packages/gehomesdk/ge_appliance.py", line 119, in get_erd_value
    return self._property_cache[erd_code]
KeyError: <ErdCode.COOKTOP_CONFIG: '0x551c'>

Yep, this issue was found and should be fixed in the "dev" branch.  Can you clone that branch and place into custom components and confirm if it resolves your issue?

Should be fixed in 0.4.0, feel free to re-open if you're still running into an issue.


Redirects to nested README.md/index.md with directory URLS

I stumbled on this when looking into #23. The key difference is use_directory_urls is set to true in this case.
mkdocs.yml
site_name: test
use_directory_urls: true

theme:
  name: material

plugins:
  - redirects:
      redirect_maps:
        foo.md: foo/README.md

Note that with use_directory_urls enabled, the original markdown do is the same as the redirect target. This results in the redirect output file being generated on top of the file generated by mkdocs. It appears that the only productive thing the plugin can do in this situation is true raise an error.
This occurs in both v1.0.1 & v1.0.3. This occurs for when the redirect target is README.md or index.md.
Commands to reproduce:
mkdir -p docs/foo
touch docs/foo/README.md
pip install -U mkdocs-redirects==1.0.3
mkdocs build

site/foo/index.html
<!doctype html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <title>Redirecting...</title>
    <link rel="canonical" href="./">
    <meta name="robots" content="noindex">
    <script>var anchor=window.location.hash.substr(1);location.href="./"+(anchor?"#"+anchor:"")</script>
    <meta http-equiv="refresh" content="0; url=./">
</head>
<body>
Redirecting...
</body>
</html>

I believe one workaround is to create an empty file in the original position


fix screen change glitch on pixel scale

Description
fixed screen change event connection, which was broken because we initialize viewer and canvas before the window
closes #566
Type of change

Bug-fix (non-breaking change which fixes an issue)

References
https://github.com/napari/napari/issues/566
How has this been tested?

manually tested screen change and verified the glitch is gone

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works

oops I pushed the branch to main repo, dang I will delete the branch after merged

Maybe @jni can test this out too. Also I'm curious if this fixes #1423 too, maybe @hhelmbre might be able to try this fix out and let us know!!

Amazing job identifying that the problem can be solved by adding this missing connection!! I can get access to another monitor later this evening and test this, but in the mean time I'm curious why you put this inside a function and the try catch. Are we sometimes unable to find the window? You also call out PyQt5 in the comment, but does the same apply to PySide2 or is this a PyQt5 specific problem?
Could we just get the window handle and do the connection in the init in one line?
Again really great detective work chasing all this down, I know that even though fix in the end is very short it was a lot of effort to identify this as the root cause.

The unit test for pyside version cannot find the window. However this piece is only in vispy qt backend, so I am not sure if pyside would see this issue at all

The unit test for pyside version cannot find the window. However this piece is only in vispy qt backend, so I am not sure if pyside would see this issue at all

I think both pyside2 and pyqt5 are looking for that qt window so it is probably the same for both, but I'm not sure either.
Do I understand though that we need the try catch to make some of our unit tests pass, but we don't need it in normal operation? If so maybe we can find an alternative approach where we adjust our unit tests in some way. We've generally tried to avoid try catch statements like this in the codebase, but curious what @jni thinks in this case.

The unit test for pyside version cannot find the window. However this piece is only in vispy qt backend, so I am not sure if pyside would see this issue at all

I think both pyside2 and pyqt5 are looking for that qt window so it is probably the same for both, but I'm not sure either.
Do I understand though that we need the try catch to make some of our unit tests pass, but we don't need it in normal operation? If so maybe we can find an alternative approach where we adjust our unit tests in some way. We've generally tried to avoid try catch statements like this in the codebase, but curious what @jni thinks in this case.

fwiw let me see if the _backend check does the trick, maybe we can get rid of the try catch, I was just being lazy and copied from vispy codebase

It works!!!! This is amazing!! I just tested it with another monitor. It literally would have saved my embarrassment in front of an audience of ~1000 people at SciPy two years ago 🤣 . We can sort out the testing/ try test stuff tomorrow, but so great to have this working, it will make a big difference when people give presentations using projectors (if we ever stop using zoom that is) cc @jni

@sofroniewn just caught up on the discussion about previous versions of the code with the try/except. I agree that it would be nice if it could be avoided, but I wouldn't hold back the PR for very long if figuring out a workaround for CI is a pain. Thanks @ziyangczi for trying out various options!

Looks you found the fix @ziyangczi!! All tests are passing and the functionality works as expected, and the code change is beautifully simple.
I think this is good to merge. Was there anything else you wanted to look at before doing so?

I was just waiting for people to test it out, maybe particularly on pyside2, but we merge now can reopen the issue if more to be found


Unicode error

When running this script (only tested with the --dry parameter), I get the following error:
found 889 downloaded files
found 879 rtorrent files
Traceback (most recent call last):
  File "~/./rtorrent_cleanup.py", line 154, in <module>
    main(args.rtorrent_working_dir, args.rtorrent_download_dirs)
  File "~/./rtorrent_cleanup.py", line 90, in main
    if check_if_single_file_torrent(torrent_file):
  File "~/./rtorrent_cleanup.py", line 21, in check_if_single_file_torrent
    content = f.read()
  File "/usr/lib/python-exec/python3.9/../../../lib/python3.9/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xdf in position 876: invalid continuation byte

I guess one of my downloads contains some weird unicode that can't be parsed in utf-8... but I'm not sure which? I haven't dabbled in python yet...

You could add a print(torrent_file_path) before line 20 and then the last file it prints before the error is the problem.

I identified the torrent file, removed it, so it wouldn't hang again but then it crapped its pants with the next torrent file:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfa in position 1243: invalid start byte
Kinda don't want to do this for potentially every single torrent in there...


Feature/docs

Codecov Report

Merging #135 into 2.0 will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            2.0   #135   +/-   ##
===================================
  Coverage   100%   100%
===================================
  Files         1      1
  Lines        66     66
===================================
  Hits         66     66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c0a83...c192bc8. Read the comment docs.


Bug: Unable to connect to Switch Bot

Describe the Bug
After installed the plugin and configured the switch bot params I got some errors and now work as excepted.
I already tried to check the prerequisites and everything is fine, tried also reboot, reinstall without success.
From Switch app I can activate the bot.
To Reproduce
Install the plugin and configure.
Expected Behavior
I expect to show in home app and in the home bridge accessories
Relevant Log Output
I attached my logs

Config for homebridge-switchbot
{
            "name": "SwitchBot",
            "credentials": {
                "token": "mytoken",
                "secret": "mysecret",
                "notice": "Keep your Token & Secret a secret!"
            },
            "options": {
                "devices": [
                    {
                        "deviceId": "DAE1CDDDD696",
                        "configDeviceType": "Bot",
                        "connectionType": "BLE",
                        "bot": {
                            "mode": "press",
                            "deviceType": "garagedoor",
                            "doublePress": 1
                        },
                        "logging": "debug"
                    }
                ],
                "logging": "debug"
            },
            "platform": "SwitchBot"
        }

Screenshots

Device and Model
Raspberry Pi 4
Node.js Version
v18.16.0
NPM Version
v9.5.1
Homebridge Version
v1.6.1
Homebridge Switchbot Plugin Version
v2.6.2
Homebridge Config UI X Plugin Version
No response
Operating System
Raspbian

I keep getting a 401 error on the API call.
I have tried to reset the token with no luck. I am assuming that is why the Call inside of Home Bridge fails because the authorization to the API doesn't authenticate.

Having same issue.

@Luccio96, what Config UI X version are you using?
@DylanBadolato please open your own issue as your Homebridge instance is more than likely different.
@carlheinmostert please open your own issue as your Homebridge instance is more than likely different.

v2.8.0 is released


when two KinematicBody2D collide, why one can be pushed by another?

Operating system or device - Godot version:
godot 2.1.3
Issue description:

when move KinematicBody2D A towards B,  B will be also push slowly to that direction.
Should not B keep static and stop the movement of A?
Steps to reproduce:
Link to minimal example project:

if you are not intending B to move, then simply don't call move or
move_and_slide. Otherwise it will try to resolve collision against the
other body and get pushed
On Thu, Jun 22, 2017 at 10:25 PM, alexzheng<EMAIL_ADDRESS>wrote:

Operating system or device - Godot version:
godot 2.1.3
Issue description:
when move KinematicBody2D A towards B, B will be also push slowly to that
direction.
Should not B keep static and stop the movement of A?
Steps to reproduce:
Link to minimal example project:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9322, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26Oxky730vGTeMXY_jia1sGAegYfks5sGxPygaJpZM4ODB2y
.

But according the API document:
Kinematic bodies are special types of bodies that are meant to be user-controlled. They are not affected by physics at all (to other types of bodies, such a character or a rigid body, these are the same as a static body).
B should bot be moved by A.

If do not call move on A, what else api should I call to move A and resolve collision?
Thanks!

@alexzheng move prevents overlaps, if both move one overlaps first and will try to avoid it (if you move zero still may try to separate the amount set on the body).
You can look at the Q&A, there are some suggested ways to create a "composite" body where the main moves and children acts as solid.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

@akien-mga Would it be possible to revise this? I had a bug on my game where blocks could be pushed by the player even when they were not supposed to. I needed to continuously run move_and_slide on the block to implement gravity and have it fall down. But it seems that the player could somehow push it when running the game in slow motion.

Please open a new issue with detailed steps to reproduce. This issue was low quality and thus didn't get any activity in one year, and was closed more than one year ago. Reopening it won't help giving it a better focus.

Cheers. Will do as soon as I can prepare an example project.
On Fri, Dec 13, 2019 at 5:27 PM Rémi Verschelde<EMAIL_ADDRESS>wrote:

Please open a new issue with detailed steps to reproduce. This issue was
low quality and thus didn't get any activity in one year, and was closed
more than one year ago. Reopening it won't help giving it a better focus.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9322?email_source=notifications&email_token=AAV7RW76WXGHP2HDZ5BIUZDQYNBONA5CNFSM4DQMDWZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGZIT6A#issuecomment-565348856,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAV7RWYF5OUHPWLHZ6CDEFTQYNBONANCNFSM4DQMDWZA
.


limit() not work with hasMany() when using ActiveDataProvider

view file as follows:
         <?= GridView::widget([
                'dataProvider' => new ActiveDataProvider([
                    'query' => $user->getProblems()->limit(10),
                ]),
                'columns' => [
                'id',
                ]
            ]); ?>

Model file as follows:
public function getProblems()
{
    return $this->hasMany(ProblemRecord::className(),['created_by'=>'id']);
}

the gridview works but the limit not worked.

https://github.com/yiisoft/yii2/blob/master/framework/data/Pagination.php#L210

adding
'pagination' => false,
solve the problem, i think it's a bug.

If you want to use a fixed number of records you have to disable pagination which otherwise would choose the limit for you. This is expected behavior.

If you still want to paginate limited data, you can use ArrayDataProvider instead.
return new yii\data\ArrayDataProvider([
'allModels' => $query->limit(5)->all()
]);

the better solution would be to set the totalCount of records manually.

I tried, but in my case it only changes the total count in response headers, but not the amount of data returned.


tests/storage-vm: add test for snap zfs.external

Test for https://github.com/canonical/lxd-pkg-snap/pull/413

@tomponline this was tested locally. The current CI failures are unrelated as the test bits are inactive when snap info lxd doesn't contain zfs.external.
Now that I talk of snap info, I'm reminded that this might not be looking at the current data from the snap but might be checking the store's copy instead. Should I use a different gating mechanism?

Now that I talk of snap info, I'm reminded that this might not be looking at the current data from the snap but might be checking the store's copy instead. Should I use a different gating mechanism?

I changed it to instead look at the /snap/lxd/current/commands/daemon.start script directly. Not super clean but should be reliable.


Event becomes an event w/ multiple days if created in monthview

Describe the bug
An event created in the month view becomes an event with multiple days, if a custom duration is put in, even if the duration doesn't exceed the day.
In short the endDate isn't set correctly.
To Reproduce
Steps to reproduce the behavior:

Go to the month view
Insert an event name
Uncheck the "All day event" checkbox
Insert a custom start and endtime
Click on save
Now the endDate in the frontmatter is set to the day after the event.

Expected behavior
The endDate should be the same as the start date.
Console Errors
No errors are printed to the console.
Device info (please complete the following information):

OS: Windows 11
Plugin Version: 0.5.1

Thanks for the bug report! This is due to how FullCalendar represents all-day events. I'll work to either fix this issue outright or also add an "end date" field to the modal so that this can be edited in-line rather than manually in the yaml.

I am experiencing this identically, except for the following:
OS: Ubuntu 20.04
Plugin Version: 0.5.3


Add option to run WebGPU tests on software rasterizer

Similar to d3d11_sw, d3d12_sw, add wgpu_sw option that will initialize the testing framework on a software renderer.
We need this for running tests on CI.

Dawn does not allow this. The only way is to modify source code.
@MikhailGorobets Please add reference to the code and close this as not planned.

We need to skip all devices except the WARP device at this point:
https://github.com/google/dawn/blob/ad49eea87ac16d83539a38fc9c995555bc70ffa6/src/dawn/native/Instance.cpp#L376


Remove 'large' image files from distribution?

Hi there.
Thanks for making this mod. Nice and simple and just what I was looking/hoping for!
If I could make one small suggestion, since this is called "Lightweight" mod - then I guess you can remove the "container-image.png" and "inventory-image.png" files from the distribution, if they aren't needed? They are 496KB in total which accounts for around 96% of the total package size.

Changes done, will be reflected in newest version when that is released.


Fetching svg from assets seems to fail when running on mobile

Hi there, thanks for this nice plugin.
I have some files in my src/assets/svg-icons folder
I use the plugin like this:

where svg resolves to: "assets/svg-icons/white-logo.svg"
If I run the ionic app in a browser everything works great but when I build the cordova app and run it on a real device (tested on android only) it fails.
Using Chrome inspector I see the following error:
GET file:///assets/svg-icons/white-logo.svg net::ERR_FILE_NOT_FOUND
As a temporary work around I added the following:
if (this.platform.is('cordova') && this.platform.is('android')) {
this.url = '/android_asset/www/' + this.url;
}
Is this the expected behaviour or should this be something the plugin should take care of?
thanks
Alessio

The plugin doesn't do anything special for Cordova, so it's just resolving the base to file:/// automatically in that environment.
You could probably set the base like so:
InlineSVGModule.forRoot({ baseUrl: '/android_asset/www/' })

Thanks for clarifying this.


Pair in C++ STL

Description 📜
I want to add documentation of Pair in C++ STL.

Domain of Contribution 📊

[x] C/CPP

/assign

can u assign ?

/assign

Closing as the PR got merged


[Model saving and loading] possibility to save additional content next to the checkpoint.ckpt file

🚀 Feature
I want to save my variables that I need to init my model in a config file in the same folder as the checkpoint is saved. Therefore, my feature request is to make the variable filepath of save_checkpoint(self, filepath) in trainer_io.py (line 247) available in the function def on_save_checkpoint(checkpoint). Like this, I can save additional parameters in the same directory like the checkpoint. Overwriting the class method load_from_checkpoint allows me then to load again whatever I want and add to the args and kwargs object before passing it to  pl.LightningModule.load_from_checkpoint(checkpoint_path, map_location, tags_csv, *args, **kwargs).
Motivation
I want to use MyLightingModule.load_from_checkpoint(PATH) without adding the kwargs manually but loading them automatically from the checkpoint path. However, I also do not want to save the kwargs of my Model in the checkpoint itself, since then the checkpoint will be loaded two times, one time to get the kwargs and another time to actually load the model.
Pitch
Adding filepath of def save_checkpoint(self, filepath) as an argument to the def dump_checkpoint to then either add the filapath as a variable to checkpoint or pass it along the model.on_save_checkpoint(checkpoint, ).
Like this everybody is able to save anything else next to the checkpoint location.
Alternatives
Not really a nice one. I could of course define my own trainer and overwrite the method, but I think knowing the path in on_save_checkpoint has maybe many other advantages.
Additional context
Here, is an example of how my implementation would look like in the lightning module:
def on_save_checkpoint(self, checkpoint):
    with open(os.path.splitext(f'{checkpoint['filepath']}.yaml')[0]+'.yaml', 'w') as outfile:
        yaml.dump(self.model_kwargs, outfile, default_flow_style=False)

@classmethod
def load_from_checkpoint(cls,
        checkpoint_path: str,
        map_location: Optional[Union[Dict[str, str], str, torch.device, int, Callable]] = None,
        tags_csv: Optional[str] = None,
        *args, **kwargs
):
    kwargs = yaml.load(open(os.path.splitext(f'{checkpoint_path['filepath']}.yaml')[0]+'.yaml'), Loader=yaml.FullLoader)
    return pl.LightningModule.load_from_checkpoint(checkpoint_path, map_location, tags_csv, *args, **kwargs)

I think this deserves a bump. This would allow for saving scalers associated to the model as well!

Can't we use on_save_checkpoint/on_load_checkpoint hooks for that matter? See the docs.


Dev Tooling: Get verible into Bazel for linting + indexing

https://github.com/google/verible

Ref: hdl.github.io/awesome/items/verible

@hzeller - Is this done?


E2E side-input test for Sink

Create a new directory called sink-redis-side-input at https://github.com/numaproj-contrib/e2e-tests-go
Copy https://github.com/numaproj/numaflow-sinks/tree/main/redis-e2e-test-sink and put it https://github.com/numaproj-contrib/e2e-tests-go

is this done?

is this done?

Yes it is already merged -https://github.com/numaproj-contrib/e2e-tests-go/tree/main/sink-side-input
PR- https://github.com/numaproj/numaflow/pull/1257 (for both source and sink with sideinputs)


[10.x] Allow for validation rule extensions in validator

This pull request introduces support for class-based extensions, which implement the ValidationRule interface, into the validator.
In Laravel, you can use the Validator::extend method to register custom validation rules. With the release of version 10, a new interface was introduced to define such rules. Since the aforementioned method accepts a class-string, it feels quite intuitive to do the following:
use Illuminate\Contracts\Validation\ValidationRule;

class Uppercase implements ValidationRule
{
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        //
    }
}

...

use Illuminate\Support\Facades\Validator;

Validator::extend('uppercase', Uppercase::class);

This fails however, since the expected declaration of the validate() method does not match with the new interface. This irks me a bit, since there’s now multiple ways to define a custom rule, but you still have to adhere to the old way to extend the validator. It does not help that it has only been documented up to version 7.x.
I propose a change to the validator, so you may pass a class-string that implements the ValidationRule interface.
A current workaround would look something like this:
Validator::extend('uppercase', function ($attribute, $value, $parameters, $validator) {
    $rule = InvokableValidationRule::make(new Uppercase(...$parameters));

    $rule->setValidator($validator);

    return $rule->passes($attribute, $value);
});

Validator::extend isn't really something we document or recommend anymore.

If you truly want to achieve such a thing, try https://packagist.org/packages/henzeb/ruler-laravel

Validator::extend isn't really something we document or recommend anymore.

Indeed, looked for a while in the documentation thinking it wasn't documented yet because of the updates.
What do you recommend ? Using the new Macroable trait ?
Rule::macro('uppercase',function () { return new Uppercase();  }

or simply to instantiate the ValidationRule in the rules like stated in documentation ?


Migrate diagnostic settings storage retention should clearly state when ARM deployments will fail

ARM deployments of new diagnostic settings with retention policy started failing today Mon 14th Aug 2023 AEST in Australia East Region. We are in the process of raising a support ticket regarding this however this document should clearly state when ARM deployments will start to fail.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b686f483-4bd0-bc14-53f3-e893287ac652
Version Independent ID: ccc2c126-e4bb-75d0-1941-d4f7ffbae3a1
Content: Migrate diagnostic settings storage retention to Azure Storage lifecycle management - Azure Monitor
Content Source: articles/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy.md
Service: azure-monitor
Sub-service: essentials
GitHub Login: @EdB-MSFT
Microsoft Alias: edbaynash

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Howdy,
@cperfect is your error:
Status Message: Diagnostic settings does not support retention for new diagnostic settings.

Which is similar to what is reported here: https://github.com/Azure/ResourceModules/issues/3572
?
This feels like it was an unscheduled change in behavior - it has been a week, can we get confirmation if this was intended / scheduled @RyanHill-MSFT ?

There are a flurry of new comments also flagging their deploys are broken on that similar issue.

Similar here: https://github.com/hashicorp/terraform-provider-azurerm/issues/23051

It looks like Microsoft preponed the deprecation of retention policies.

Looks like this is the new expected behavior (they just missed the deadline): https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy

Is there a different process of migrating to Azure Storage lifecycle management when you are sending your logs to the Log Analytics Workspace? I see a prerequisite is, "An existing diagnostic setting logging to a storage account."


Updating DynamicACL to pull list of operations projects from config i…

…nstead of being hardcoded

Addresses #27

LGTM

looks like we forgot about this... @jcantrill any opposition to merging this?

[merge]...can we do that in this repo?


Source Code Usage Request

Dear Developer,
I'd like to use parts of your engine's source code for my own engine. I plan to redistribute the changed code on github, of course I'll credit you and your repository.
My question is if this is okay for you...
Thanks in advantage

Hi mathsy!
MinimalChessEngine is open-source under the simple and very permissive MIT License.
Unlike other licenses (like Stockfish's GPL for example) using my source doesn't force you to make your own engine open source, too.
The only requirement is indeed to give proper credits. So if you link to the github repository and maybe additionally mention that the original source is published under the MIT license that would be entirely fine!


How can I use $fetch in nuxt-cron?

Hello! Can you help me to understand how I can use $fetch inside cron?
fill path = server/cron//bnovo-auth.ts
import { defineCronHandler } from '#nuxt/cron';

export default defineCronHandler('everyTenMinutes', () => {
    $fetch('/bnovo/auth')
    .then(() => {
        console.log('bnovo auth success')
    })
    .catch((e) => {
        console.log('bnovo auth failed')
    })
}, {runOnInit: true})

I understood that, if I want to use $fetch I need nitro event handler, like this example https://nitro.unjs.io/guide/fetch#in-server-fetch
But I need to use your cron with my api. For this solution I prefer use $fetch, because it's working on server side. But in first time running script I have next error:
[nuxt] [request error] [unhandled] [500] Cannot access 'nitroApp' before initialization
And this is okay for this.
I will glad if you help me with this problem.

For more understanding I provide to you my code from repository.
this is my cron file
https://github.com/bobrov-site/nedvijka/blob/087d4b7d7017df60f70eb08f4b5380418d08f594/server/cron/bnovo-auth.ts#L4
this is my auth file, when i call my bnovo auth
https://github.com/bobrov-site/nedvijka/blob/master/server/routes/bnovo/auth.ts


[DOCS] : removed extra full stop

Notes for Reviewers
The Catalog Docs have a extra line and full stop at the end.

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 584840d545e4dc394aaabd5936967d69c4b9397b at: https://657b25e20c672136919dfb9b--meshery-docs-preview.netlify.app


Optimize invokedynamic for non-capture lambdas

When an Idris function is passed to Java as a lambda and the function doesn't capture any variables, instead of closing over the Idris function, we could move the function reference inside the lambda implementation so that there is no capture and LambdaMetaFactory doesn't have to create a class and an instance at runtime which should improve performance. This is how method references in Java are also compiled into.
Example 1
ArrayList.fromList ["foobar", "hello", "world"] >>=
        stream >>=
        filter (jlambda (not . isPrefixOf "foo")) >>=
        map (jlambda Strings.reverse) >>=
        collect !toList

For the above code, here is the decompiled Java code from bytecode for the lambda passed to map method:
var2 = new IdrisObject(65718);
Function var3 = (var1x) -> {
    return (String)Runtime.unwrap($lbraceAPPLY_0$rbrace(var2, var1x));
};

var2 is the reference to the reverse Idris function and it can be safely moved inside the lambda as it doesn't use any variables from the context.
Example 2
IntStream.from !(vectToArray [2, 4, 6]) >>=
       map (jlambda (+1)) >>=
       sum

Here the lambda for map method call is compiled into:
var2 = new IdrisObject(65686);
IntUnaryOperator var3 = (var1x) -> {
    return ((Integer)Runtime.unwrap($lbraceAPPLY_0$rbrace(var2, var1x))).intValue();
};

As in the first case, here also the Idris function reference can be moved into the lambda implementation.

This has been fixed in Idris 2 JVM backend.
c <- Stream.fromCollection list >>=
            (flip map foo) >>=
            (flip filter (\s => toPrim $ pure $ (length s > 15))) >>=
            count

In the bytecode for map and filter, the values necessary to call the lambdas are no longer closed over especially Main::foo is passed as a method reference directly.
public static Object extr$main$6(Object ext$0, Object $jvm$arg2) {
        return ((Function)Basics.flip((eta$0) -> {
            return (eta$1) -> {
                return Stream.map(csegen$13.evaluate(), new main.String("main/String"), new main.String("main/String"), eta$0, eta$1);
            };
        }, Functions.curry(Main::foo), $jvm$arg2)).apply(ext$0);
    }

    public static Object extr$main$9(Object ext$0, Object $jvm$arg1) {
        return ((Function)Basics.flip((eta$0) -> {
            return (eta$1) -> {
                return Stream.filter(csegen$13.evaluate(), new main.String("main/String"), eta$0, eta$1);
            };
        }, (s) -> {
            return (eta$0) -> {
                return Types.$gt$$gt_Ord_Nat(M_Prelude.M_Types.String.length(s), new BigInteger("15"));
            };
        }, $jvm$arg1)).apply(ext$0);
    }


Tested against Django 3.1 and 3.2

This PR tests the package against Django 3.1 and 3.2 with DRF 3.12.*
cc: @jpadilla

@jpadilla, any chance to review this?
Let me know if any blockers.
Thanks in advance.

@jpadilla, a gentle ping.

@jpadilla, can you please review this one?

@jpadilla looking forward to hear from you on it.

@jpadilla Could you please have a look at his PR? We at Open edX would appreciate it very much.


subscriptionExpiration for topic

for some reasons, my subscriptionName changes when my server restarts. But the old subname still exists in pulsar-server and alarms messages heap up.   so maybe there should be expire policies for unused subscription.

Yes, there is ttl policy for this: https://pulsar.apache.org/docs/en/cookbooks-retention-expiry/
This is a kind of question, would like to close this issue, if the ttl policy could not solve your issue, feel free to reopen this issue.

Yes, there is ttl policy for this: https://pulsar.apache.org/docs/en/cookbooks-retention-expiry/
This is a kind of question, would like to close this issue, if the ttl policy could not solve your issue, feel free to reopen this issue.

@uestczshen
subscriptionExpirationTimeMinutes seems to help you:
https://github.com/apache/pulsar/blob/2dc24705efe61fdfca3315edb29946d3a0a9e599/conf/broker.conf#L178-L180
This setting can be enabled at broker level or namespace level.
cf: https://github.com/apache/pulsar/pull/6851

@uestczshen
subscriptionExpirationTimeMinutes seems to help you:
https://github.com/apache/pulsar/blob/2dc24705efe61fdfca3315edb29946d3a0a9e599/conf/broker.conf#L178-L180
This setting can be enabled at broker level or namespace level.
cf: https://github.com/apache/pulsar/pull/6851


enhancement print more log while get_rowset_by_ids missed some rowsets

Proposed changes
Issue Number: close #xxx
get_rowset_by_ids my return less rowsets than given rowset_ids, because compaction may delete some rowsets that refered by rowset_ids.
This might cause update fail due to not found key, we print more log here for debuging
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


How to set default file instead of index.html

I want to use home.html as default root file instead of index.html.
any way to do it?

I suggest making sure only home.html exists inside the directory and then enable renderSingle.


Tweet time interval set to 10 hours, change it to 3 hours

can i get to work on this

PES2UG21CS229
Keshav Agrawal
Can i work on this issue.

@Keshav1105 @KunalMaverick
Open to everyone for the first hour


Decorate forbidden stores in relay page

https://kolmafia.us/threads/hide-buy-from-relay-mall-search-if-the-store-is-in-forbiddenstores.28029/

Should it be calling "preference" by "property" instead?

And no, I think externally it's all "preference" (e.g. prefref).


Error.log - Cannot overwrite variable

Hi,
I am receiving the following errors in the error.log when using kansa. Can you help please?
Get-WMIRecentApps reports error on XXX: "Invalid namespace  Cannot overwrite variable CMPNAMELENGTH because it is read-only or constant. Cannot overwrite variable SEPARATOR because it is read-only or constant. Cannot overwrite variable EXTLENGTH because it is read-only or constant. Cannot overwrite variable MAXPATH because it is read-only or constant."
Get-Netstat reports error on XXX: "Cannot overwrite variable CMPNAMELENGTH because it is read-only or constant. Cannot overwrite variable SEPARATOR because it is read-only or constant. Cannot overwrite variable EXTLENGTH because it is read-only or constant. Cannot overwrite variable MAXPATH because it is read-only or constant."
Get-DNSCache reports error on XXX: "Cannot overwrite variable CMPNAMELENGTH because it is read-only or constant. Cannot overwrite variable SEPARATOR because it is read-only or constant. Cannot overwrite variable EXTLENGTH because it is read-only or constant. Cannot overwrite variable MAXPATH because it is read-only or constant."
Get-ProcsWMI reports error on XXX: "Cannot overwrite variable CMPNAMELENGTH because it is read-only or constant. Cannot overwrite variable SEPARATOR because it is read-only or constant. Cannot overwrite variable EXTLENGTH because it is read-only or constant. Cannot overwrite variable MAXPATH because it is read-only or constant."
Exit-Script function was passed an error, this may be a duplicate that wasn't previously cleared, or Kansa.ps1 has crashed.
You cannot call a method on a null-valued expression.
Cannot overwrite variable CMPNAMELENGTH because it is read-only or constant.
Cannot overwrite variable SEPARATOR because it is read-only or constant.
Cannot overwrite variable EXTLENGTH because it is read-only or constant.
Cannot overwrite variable MAXPATH because it is read-only or constant.

Having the same issue

Submitted a pull request that fixes this issue. #211


Make McCree use his flashbang instead of custom projectile

lol we all worked on this seperately. I'll try to review PR's before I work next time.
Closing as this implementation is already very similar to my implementation in v3.1.0


Changed format to suit English numerals

Some slight tweaks that output in english numerals

Totally missed this PR :(
Just added your patch here: https://github.com/divan/num2words/commit/57dba452f9421c72bc7fa8e44e4596419bde0355
Thank you!


Update theory-of-operation.md

Fix typo
Provide a narrative description of what you are trying to accomplish:

[X] Is this related to documentation?
This is a simple typo fix.

Thanks, @benharold!


VCF output missing header ##contig lines

Hello,
I suppose this is more of a feature request than bug.
It looks like the output VCF doesn't contain contig fields. Most command line VCF parsers (e.g. GATK, bcftools) require  contig fields even though it is optional under VCFv4.2.  Judging by the code, this isn't a bug. but just in case here are the parameters I used
longshot -n -c 2 --ts_tv_ratio 2 -D 10:800:50 -E 0.05 -e 3 -r chr{} --bam minimap_bams/ADA_1_nanopore_passed.bam --ref genome.fa --out {}_ada1_longshot_out.vcf -d longshot/ada1/debug_{}

It should work now!


[Feature] Dark Mode

Description
Implement Dark mode for the application to give it a better look.
Screenshots
No response
Additional information
We can have a toggle at the side for dark mode

Hi, I think I could work on this. Could you assign me?

Sure!

Hey, could you link me to instructions on how to get Firebase working locally? The posts are not loading when I run my fork of the project on my computer. I am getting this error: @firebase/firestore: Firestore (9.10.0): Uncaught Error in snapshot listener: {"code":"resource-exhausted","name":"FirebaseError"}. Any tips?

Actually we made way too many requests to firebase due to so many changes and testing etc and actually exhausted the free limit for today, so this error occured .  Don't worry , it should refresh in some hours

Sounds good- I'll get to work when it's back up.

It should be back up by PDT 00:00hrs

Hi, unfortunately something came up and I will be unable to work on this project for the next couple of days. I think it's best if somebody else gets this issue assigned to them.

It's Okay

is this still available?
May I contribute to this?

is this still available?
May I contribute to this?

yes it's available :) , feel free to work on this!

is this still available?
May I contribute to this?

yes it's available :) , feel free to contribute to this!

you can assign me this

I can also work on it. Could you assign it to me?

I can also work on it. Could you assign it to me?

sorry bud, it was claimed before you :)

closed in #85


feat(api): issue #209 - find all by author

Ticket
https://github.com/VirtusLab/strapi-plugin-comments/issues/209
Summary
What does this PR do/solve?
Provides ability to filter by author for generic & strapi users

/api/comments/author/:id - Strapi users
/api/comments/author/:id/generic - Generic users

Test Plan

Run you projects with some comments created
Run queries against endpoints:

/api/comments/author/:id - Strapi users
/api/comments/author/:id/generic - Generic users

You should get comments authored by specific user with related entity attached

Codecov Report

Merging #213 (2777602) into master (69293c1) will increase coverage by 0.94%.
The diff coverage is 87.93%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   79.59%   80.54%   +0.94%
==========================================
  Files          34       35       +1
  Lines         897      925      +28
  Branches      302      314      +12
==========================================
+ Hits          714      745      +31
+ Misses        179      176       -3
  Partials        4        4

Flag
Coverage Δ

unittest
80.54% <87.93%> (+0.94%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/services/utils/parsers.ts
85.36% <85.36%> (ø)

server/services/common.ts
83.92% <93.33%> (+3.70%)
:arrow_up:

server/services/utils/functions.ts
82.27% <100.00%> (ø)

server/utils/constants.ts
100.00% <100.00%> (ø)


Only AD

Hi,
I would like to know if i only want to set up the AD only. I do not want other machines.
What's the vagrant command?

All you need to do is remove lines from Vagrant/Vagrantfile for all of the hosts other than DC


Adding python tests using pytest for API based scrapers

Purpose
This pull requests added a tests folder which contains basic pytest tests. Having tests allows for safer refactoring of code and easier long term maintenance (if well maintained and used).
Tests added for:

processor.py
arcgis.py
dcat.py
usmart.py

Some minor changes were made to the above to allow for testing, but these have been as minimal as possible.
2 minor fixes are included:

usmart.py urls contained spaces - 364238d93c89b27d969c068be5d56acda9d31054
processor.py added blank lines to csvs on windows - 7678f7df7ddfb7aa448057df37cb13c9dda0057d

Testing Notes
A markdown file is included in the test folder to explain how to install pytest and the validators module. And then how to run and add more tests (for more details google pytest)
Testing
All tests currently pass on my windows machine

Closing request without merging.
I'm going to move this work on to a separate branch in my fork and then re submit, This will allow me to make changes safely if needed.


Tagged and structure still have some differences

Type:
(tagged t a b c)
=>  ((constructor t)
         (Promise
          (All (a22/T b23/T c24/T) ((structure (a b c)) a22/T b23/T c24/T))))

Should be (so that it can be instantiated:
(All (a22/T b23/T c24/T)
 ((constructor t)
      (Promise
          ((structure (a b c)) a22/T b23/T c24/T))))

Fixed


Obsolete methods that can be removed safely

This addresses obsolescence from issue https://github.com/castleproject/Windsor/issues/338
This PR mainly targets:

ActAs
Parameters
ServiceOverrides
Properties
Most methods in DefaultKernel_ObsoleteAPI
Most methods in WindsorContainer_ObsoleteAPI

Obsolete methods that can be removed safely:

Removed obsolete Resolve methods from IKernel/DefaultKernel && IWindsorContainer/WindsorContainer
Removed the obsolete AddComponent methods from IKernel/DefaultKernel
Removed the obsolete indexer from IKernel/DefaultKernel && IWindsorContainer/WindsorContainer
Removed the obsolete Properties methods from Component Registration
Removed the obsolete ServiceOverrides methods from Component Registration
Removed the obsolete Parameter method from Component Registration
Removed the obsolete ActAs method from Component Registrations and updated documentation

Obsolete methods that cannot be removed safely:

IKernel/DefaultKernel AddFacility(String key, IFacility facility)
IWindsorContainer/WindsorContainer AddFacility(String key, IFacility facility)

Still need to update CHANGELOG.md but will wait to avoid merge conflict.

Looks good, just a comment about ActAs.

All good.

Thanks. I will come back on the other PR tomorrow night.


(p)hue traceback on light actions since 0.48 -> 0.50 upgrade

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.50.1
Python release (python3 --version):
3.4
Component/platform:
lighting
Description of problem:
Upon triggering a light action (like on/off) the following traceback is observed and there's a delay updating the UI state (presumably until the next poll).
Expected:
No traceback and immediate UI update
Problem-relevant configuration.yaml entries and steps to reproduce:

Add a hue light
Turn it on

Traceback (if applicable):
2017-07-30 20:16:36 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 233, in _step
    result = coro.throw(exc)
  File "/opt/homeassistant/lib/python3.4/site-packages/homeassistant/core.py", line 1025, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/opt/homeassistant/lib/python3.4/site-packages/homeassistant/components/light/__init__.py", line 279, in async_handle_light_service
    yield from light.async_turn_on(**params)
  File "/usr/lib/python3.4/asyncio/futures.py", line 388, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.4/asyncio/tasks.py", line 286, in _wakeup
    value = future.result()
  File "/usr/lib/python3.4/asyncio/futures.py", line 277, in result
    raise self._exception
  File "/usr/lib/python3.4/concurrent/futures/thread.py", line 54, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/opt/homeassistant/lib/python3.4/site-packages/homeassistant/components/light/hue.py", line 432, in turn_on
    self._command_func(self.light_id, command)
  File "/opt/homeassistant/lib/python3.4/site-packages/phue.py", line 898, in set_light
    converted_light) + '/state', data))
  File "/opt/homeassistant/lib/python3.4/site-packages/phue.py", line 667, in request
    return json.loads(response.decode('utf-8'))
  File "/usr/lib/python3.4/json/__init__.py", line 318, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.4/json/decoder.py", line 343, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.4/json/decoder.py", line 361, in raw_decode
    raise ValueError(errmsg("Expecting value", s, err.value)) from None
ValueError: Expecting value: line 1 column 81 (char 80)

Additional info:

Retract - didn't notice it'd automatically picked up my ha-bridge instead of the hue bridge directly.


⚠ SceneTime has degraded performance

In ef82c22, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1613 ms

Resolved: SceneTime performance has improved in eafe536 after 6 minutes.


Utilise serverless-offline-ssm to fix local development

Currently running locally does not work as expected due to incompatibility with serverless-offline and ssm: variables - https://github.com/dherault/serverless-offline/issues/1647. A suggested solution is to use this package https://www.serverless.com/plugins/serverless-offline-ssm

Workaround is to comment SSM vars in serverless.yml. E.g.
functions:
  handler:
    handler: src/index.handler
    memorySize: 256
    timeout: 900
    # environment:
    #   DISCOGS_USER_TOKEN: ${ssm:/discogs-market-monitor/discogs_user_token}
    #   SENDGRID_API_KEY: ${ssm:/discogs-market-monitor/sendgrid_api_key}
    #   DISCOGS_USERNAME: ${ssm:/discogs-market-monitor/discogs_username}
    #   SHIPS_FROM: ${ssm:/discogs-market-monitor/ships_from}
    #   DESTINATION_EMAIL: ${ssm:/discogs-market-monitor/destination_email}
    #   SENDER_EMAIL: ${ssm:/discogs-market-monitor/sender_email}

Using parameter store secrets as done in https://github.com/jch254/market-monitor-api also allows running locally


Create requirements.txt

added required libraries in requirements.txt

good yaar.
On Fri, Oct 2, 2020 at 5:23 PM Bharat Purohit<EMAIL_ADDRESS>wrote:

added required libraries in requirements.txt
You can view, comment on, or merge this pull request online at:
https://github.com/DBT-BIF/Biosensor-Python/pull/3
Commit Summary

Create requirements.txt

File Changes

A requirements.txt
https://github.com/DBT-BIF/Biosensor-Python/pull/3/files#diff-b4ef698db8ca845e5845c4618278f29a
(4)

Patch Links:

https://github.com/DBT-BIF/Biosensor-Python/pull/3.patch
https://github.com/DBT-BIF/Biosensor-Python/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DBT-BIF/Biosensor-Python/pull/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNUA77TTFU5I4JVVIF2JX3SIW5MFANCNFSM4SBTJHXA
.

--
*Yours Sincerely *
Rakesh SharmaResearch associateBioinformatics Infrastructure Facility
University of Rajasthan, Jaipur.INDIA


Currently the admin password is only needed when trying to access /client/${clientId}/conversations

The password should be required by accessing /

@ja-fra can you please confirm this issue. Maybe we have to make a hotfix, before the 04. of Oct.

That's true. Access is currently only restricted for the /admin/** part.
Currently we can't completely lock down access, since rocket.chat needs access to certain sevices. Possible temporary fix (until #60 is ready) could be to restrict access to all except /rocket/** and /conversation/**

The most important issue here is, that one is able to delete configurations when opening the main admin view. Since the access is not restricted everyone can delete a complete config who is allowed to access the Smarti endpoint.

@ja-fra by this new rule the Smarti Widget can not be loaded without authentication:
http://localhost:8080/plugin/v1/rocket.chat.js
as well as the
http://localhost:8080/plugin/v1/system/health
http://localhost:8080/plugin/v1/system/info
So please restrict access to all except /rocket/**, /conversation/**, /plugin/** and /system/**

@ja-fra Is there an application property that can be used to disable the auth?

@ruKurz jetzt schon: security.enabled = false


[Live Trains] Scrolling short destinations

There is sufficient space to display the 1st departure destination but it is still scrolling (as seen in picture) and in some cases the destination is too long but it is not scrolling (I forgot to screenshot that but will copy that in if I see it again)

Example of destination too long but is not scrolling


Add support for zAdd options like XX|NX and so on

https://github.com/phpredis/phpredis/issues/760
phpredis now support the options but the stubs not

Thanks for your review and the format has been reverted.

Thank you!


Increase sandbox limits for my crate(s) please

Crate name
sos-sdk
Build failure link
https://docs.rs/crate/sos-sdk/0.10.0/builds
Additional details
Just started failing on version 0.10.0 it was fine on 0.9.0 and I haven't made any big changes that should affect how the documentation is generated.
Also the same problem for the sos and sos-net crates, so if you could increase these too it would be appreciated:
https://docs.rs/crate/sos/0.10.0/builds
https://docs.rs/crate/sos-net/0.10.0/builds
Thanks very much 🙏

What kind of limit increase to you request?
From what I see in the build failure, the problem is:

unknown feature stdsimd

or am I missing something?

Ah sorry @syphar, I missed that error, this is first time I have come across this failure, however it's strange I can build the docs on MacOS and Linux locally.
Seems like other people are having the same issue with ahash.


Update registry select box option with typed name(alias) or URL

The first commit is #1439. This PR should not be analized until #1439 is merged.

The objective of the second commit is to make the "registry" field extracted from the text input box useful when triggering a pull. At now, it is ignored and the option is directly taken from the select box. This means that, writting myregistry.mydomain.tld/myrepo/image:latest requires a registry with URL myregistry.mydomain.tld to be chosen in the select box. If not <selected_domain>/myrepo/image:latest is pulled.
This commit overrides the selected option with the typed URL, if possible:

If registry is null, the select box is used. Go on.
If registry is not null, it is compared to the URL of the option selected in the box.

If they match, everything is OK, go on.
If they don't, check if any of the registries matches.

If a match is found, update the select box with the typed value and show a notification (info or warning). Go on.
If no match is found, show notification (info or warning). What to do? Is it supported to pull an image from a registry which is not added to the registries list? If not, we might keep the current behaviour for this case: ignore registry and use the option in the box. Or, we might trigger a "Do you want to add this registry?" dialog.

Note that the proposed implementation checks if the typed registry contains any period. If it does, the URL field of the registries is used for matching. If it does not, the Name is used. This allows to use the names of the registries as an alias. That is, given a registry in the select list named "mynamedregistry", the  myregistry/myrepo/image:latest is supported and forwards to myregistry.mydomain.tld/myrepo/image:latest.

[ ] With registryService.js#L99-L107 I am trying to get something similar to var registries = service.registries() in order to use registries inmediately: registryService.js#L109-L117. Promises drive me mad :S.
[ ] imageService.js#L132-L133 are the placeholders for the notifications and modifying the value of the select box.

https://github.com/docker/distribution/blob/master/reference/reference.go
name                := [domain '/'] path-component ['/' path-component]*
domain              := domain-component ['.' domain-component]* [':' port-number]
domain-component    := /([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9-]*[a-zA-Z0-9])/
port-number         := /[0-9]+/
path-component      := alpha-numeric [separator alpha-numeric]*
alpha-numeric       := /[a-z0-9]+/
separator           := /[_.]|__|[-]*/

Mind opening an issue to describe the functional changes ?

I wil. But I'd like to discuss #1439 first, because the implementation of this will depend on the constaints we set there. Replying there now.


Add gateway runner with docker containers

The runner is pretty easy to use compared to the existing steps. I believe even non-Java developers can use it.

Ok ..  lets get rid of docker compose .. but lets add info on how to use the runner somewhere.

The runner is pretty easy to use compared to the existing steps. I believe even non-Java developers can use it. Note that the existing step requires maven build either.

One drawback I can think of from this new approach is it's built more like a manual integration test. Modifications and state that might've been applied to containers (ex: postgres) that you want persisted will spin down alongside the application run.
An example workflow being: You spin up the backend DB and initialize, spin up the gateway, run some queries, modify how the gateway handles query history in some fashion, and then attempt to spin the gateway back up again. In the current setup the DB state would clear and you'd be required to either: re-do all the previous steps, change the code and mount your changes as an init script, update the backend container to mount it's data to a volume, etc.
I think that's the core gain from leveraging a compose file is that you get a bunch of functionality (+life cycle management) out of the box through a few YAML tags.
Note: The way I see it is once the gateway is dockerized, it'd be nice to provide a compose file which includes the latest Gateway image and allows for new coming users to hop into a README, run docker compose -f localdev/docker-compose.yml up -d and then they'd have a detached but connected running ecosystem where they can freely spin a gateway container up/down.
Feel free to ignore this if you'd like 😄 I'll be away from the internet for the next week or so and unfortunately won't be able to respond

We can simply provide a flag to reuse containers like TESTCONTAINERS_REUSE_ENABLE in Trino. No need to redo all steps.

Addressed comments.


let PG* environment variables setup test connection

A simple change to not break expectations. I was surprised PGHOST did not work.

@jinty Because the tests run all sorts of things, including destructive stuff, I fear that picking up the PG connection string from the environment is dangerous. That's why we use the TEST_ prefix - to be explicit.

sure, no worries it surprised me and I just thought it might be an oversight.

@jinty A PR adding a warning explaining why it failed to connect and how to fix it would probably get merged, if you were offering 😉