ability.duration >  .... bug still exists

@bloerwald is the expert on non-existence and default values. Does https://github.com/DengSir/tdBattlePetScript/issues/26 answer your question? I guess we may need to change this to just error instead

I'm not a programming expert and it might be bad practice, but how about:
Extension/Conditions.lua:
Addon:RegisterCondition('ability.duration', { type = 'compare', argParse = Util.ParseAbility }, function(owner, pet, ability)
local isUsable, currentCooldown, currentLockdown = C_PetBattles.GetAbilityState(owner, pet, ability)
return ability and currentCooldown or infinite
end)
-->
Addon:RegisterCondition('ability.duration', { type = 'compare', argParse = Util.ParseAbility }, function(owner, pet, ability)
local isUsable, currentCooldown, currentLockdown = C_PetBattles.GetAbilityState(owner, pet, ability)
return currentCooldown
end)
Core/Condition.lua:
function Condition:RunCondition(condition)
local owner, pet, cmd, arg, op, value = self:ParseCondition(condition)
local fn  = self.apis[cmd]
local opts = self.opts[cmd]
if not fn then
    error('Big Bang !!!!!!')
end

local res = fn(owner, pet, arg)
return opTabler[opts.type][op](res, value)

end
-->
function Condition:RunCondition(condition)
local owner, pet, cmd, arg, op, value = self:ParseCondition(condition)
local fn  = self.apis[cmd]
local opts = self.opts[cmd]
if not fn then
    error('Big Bang !!!!!!')
end

**if res == nil then
    return false
end**

local res = fn(owner, pet, arg)
return opTabler[opts.type][op](res, value)

end

Is there ever a case where argParse returning nil is valid, which i think is what happens here?
I'm thinking something more fundamental where RunCondition returns false before it even gets to calling fn if argParse is provided on the condition but it returned nil

I sadly just don't think there is a generic "correct" solution to this question, but I feel like "if condition invalid, false" is wrong. Given
use(#1) [ self.ability(nonexistent).duration > 1 ]
use(#2)

the old implementation always did 1, the new one always does 2. Given
use(#2) [ self.ability(nonexistent).duration <= 1 ]
use(#1)

the old implementation also always did 1, the new one always does 1.
Which one does the user want? The user writing script A apparently wants always-2, but what does the user want given they wrote the script the other way around? Surely they also want 2, not 1?
This means that you can't write generic scripts like that if the condition evaluates to false. The old implementation might be unexpected, but it is consistent at least. a = not a is a bad thing to do imo, even in an error case. I'd rather add support to make scripts error out at that point…

It seems fairly consistent to me if a condition is always false for an ability your pet doesn't have (so doesn't matter if your comparison is > 1 or <= 1, both would fail the condition as it never does the comparison).
That's pretty much be same behavior use has where it just skips if you specify the name of a spell the current pet doesn't have.

Does a nonexistent ability have a duration? I don't think so. At least we can't prove it. So it should be false or an error.

.ability([^)]*).duration exists in 798 out of 5895 scripts on xufu but only 109 scripts compare with < or >. There are only 47 scripts using .ability([^)]*).duration *>, the only case that would change with the suggested patch.  Whatever decision you take, I suggest to not do it quickly and discuss it with users, even if these are fringe cases, as it affects all other ability conditions.

In reality, most scripts I have actually looked at will not be influenced by this change: They all already guard against that case or they use duration < x which doesn't change.
The following scripts are probably influenced (only relevant lines of script copied):
https://wow-petguide.com/Strategy/13027/Rogue_Azerite-Dragonkin
standby [ self.ability(only-with-pet1).duration > 1 & self.ability(only-with-pet1).duration > 1 ]

This is wrong in my definition of duration: It will always fire, while the suggested change only fires with pet1. Your change would fix it (or defining no-cooldown = 0).
https://wow-petguide.com/Strategy/8639/Snakes_on_a_Terrace
ability(Prowl:536) [enemy.ability(Dive:564).duration>2]
ability(Prowl:536) [enemy(#3).active & self(#1).active]

This is fine: only enemy 2 has Dive, so no change at all whether duration = inf or 0.
https://wow-petguide.com/Strategy/15167/Snakes_on_a_Terrace-Elemental
ability(Blazing Yip:1359) [self(#2).dead & self.ability(Puppies of the Flame:1354).duration>3]

Condition will be true, but only the pet having Puppies has Blazing, so no change.
https://wow-petguide.com/Strategy/10758/Airborne_Defense_Force-Dragonkin
use(Arcane Storm:589) [ !enemy(#2).active & enemy.round<4 ]
use(Arcane Storm:589) [ !weather(Arcane Winds:590) & enemy.ability(Toxic Fumes:2349).duration>1 ]

Only enemy 2 has Toxic Fumes. This condition might be true for Enemy 1&3 wrongly. Currently, it is true if [weather is not up, enemy #1 round < 4, enemy #3 round < 4], with change it is true if [enemy #1 round < 4, enemy #3 round < 4]. That's a change, but it is irrelevant to the strategy if I understand correctly.
https://wow-petguide.com/Strategy/10828/Extra_Pieces-Critter
use(Stampede:163) [ self.ability(Dodge:312).duration>1 ]

Only pets with both abilities exist.
https://wow-petguide.com/Strategy/9603/Cursed_Spirit
-- 9.01 duration bug repair
if [enemy(#1).active]
use(Locust Swarm:1007) [enemy.ability(Ghostly Bite:654).duration>1]
endif
--
use(Scratch:119)

This script assumes that .ability(nonexistent).duration = 0 rather than inf. Your change would be fine, but defining no-cooldown = 0 would do the same. Alternatively,
use(Scratch:119) [enemy.ability(Ghostly Bite:654).duration <= 1]
use(Locust Swarm:1007)

would do the same.
https://wow-petguide.com/Strategy/5940/Crypt_Fiend
if [ self.ability(Breath:115).usable ]
    use(Decoy:334) [ enemy.ability(Nightmare:1731).duration<2 ]
    use(Breath:115)
endif

dead code, no pets have Breath.
Note that I only looked at duration > cases where missing-ability.duration = inf would be an issue, not at any where missing-ability.duration = 0. You can look at the strategies using duration > https://wow-petguide.com/Strategy/32, https://wow-petguide.com/Strategy/2409, https://wow-petguide.com/Strategy/6845, https://wow-petguide.com/Strategy/2936, https://wow-petguide.com/Strategy/2938, https://wow-petguide.com/Strategy/2939, https://wow-petguide.com/Strategy/4779, https://wow-petguide.com/Strategy/3864, https://wow-petguide.com/Strategy/3172, https://wow-petguide.com/Strategy/8639, https://wow-petguide.com/Strategy/4047, https://wow-petguide.com/Strategy/5943, https://wow-petguide.com/Strategy/5920, https://wow-petguide.com/Strategy/5938, https://wow-petguide.com/Strategy/5939, https://wow-petguide.com/Strategy/5940, https://wow-petguide.com/Strategy/6267, https://wow-petguide.com/Strategy/6391, https://wow-petguide.com/Strategy/7431, https://wow-petguide.com/Strategy/7490, https://wow-petguide.com/Strategy/9603, https://wow-petguide.com/Strategy/9882, https://wow-petguide.com/Strategy/9894, https://wow-petguide.com/Strategy/9898, https://wow-petguide.com/Strategy/10379, https://wow-petguide.com/Strategy/10758, https://wow-petguide.com/Strategy/10828, https://wow-petguide.com/Strategy/10968, https://wow-petguide.com/Strategy/11822, https://wow-petguide.com/Strategy/11963, https://wow-petguide.com/Strategy/12152, https://wow-petguide.com/Strategy/12634, https://wow-petguide.com/Strategy/12544, https://wow-petguide.com/Strategy/13027, https://wow-petguide.com/Strategy/13743, https://wow-petguide.com/Strategy/14273, https://wow-petguide.com/Strategy/15167, https://wow-petguide.com/Strategy/15172, https://wow-petguide.com/Strategy/15223, https://wow-petguide.com/Strategy/15436, https://wow-petguide.com/Strategy/15759, https://wow-petguide.com/Strategy/16175, https://wow-petguide.com/Strategy/16340, https://wow-petguide.com/Strategy/16430, https://wow-petguide.com/Strategy/16581, https://wow-petguide.com/Strategy/16584, https://wow-petguide.com/Strategy/16585, or those using .ability.duration < https://wow-petguide.com/Strategy/1277, https://wow-petguide.com/Strategy/1446, https://wow-petguide.com/Strategy/7046, https://wow-petguide.com/Strategy/1692, https://wow-petguide.com/Strategy/1807, https://wow-petguide.com/Strategy/2064, https://wow-petguide.com/Strategy/6919, https://wow-petguide.com/Strategy/3732, https://wow-petguide.com/Strategy/2976, https://wow-petguide.com/Strategy/3074, https://wow-petguide.com/Strategy/3162, https://wow-petguide.com/Strategy/4408, https://wow-petguide.com/Strategy/4072, https://wow-petguide.com/Strategy/4077, https://wow-petguide.com/Strategy/9310, https://wow-petguide.com/Strategy/5193, https://wow-petguide.com/Strategy/5943, https://wow-petguide.com/Strategy/9301, https://wow-petguide.com/Strategy/5920, https://wow-petguide.com/Strategy/5938, https://wow-petguide.com/Strategy/5939, https://wow-petguide.com/Strategy/5940, https://wow-petguide.com/Strategy/6601, https://wow-petguide.com/Strategy/6870, https://wow-petguide.com/Strategy/9322, https://wow-petguide.com/Strategy/7431, https://wow-petguide.com/Strategy/7766, https://wow-petguide.com/Strategy/9321, https://wow-petguide.com/Strategy/8816, https://wow-petguide.com/Strategy/9268, https://wow-petguide.com/Strategy/9238, https://wow-petguide.com/Strategy/9249, https://wow-petguide.com/Strategy/9257, https://wow-petguide.com/Strategy/9312, https://wow-petguide.com/Strategy/9302, https://wow-petguide.com/Strategy/9266, https://wow-petguide.com/Strategy/9267, https://wow-petguide.com/Strategy/9270, https://wow-petguide.com/Strategy/9374, https://wow-petguide.com/Strategy/10158, https://wow-petguide.com/Strategy/11526, https://wow-petguide.com/Strategy/10449, https://wow-petguide.com/Strategy/10522, https://wow-petguide.com/Strategy/10530, https://wow-petguide.com/Strategy/10684, https://wow-petguide.com/Strategy/10891, https://wow-petguide.com/Strategy/10932, https://wow-petguide.com/Strategy/12027, https://wow-petguide.com/Strategy/12788, https://wow-petguide.com/Strategy/12591, https://wow-petguide.com/Strategy/13167, https://wow-petguide.com/Strategy/13170, https://wow-petguide.com/Strategy/13172, https://wow-petguide.com/Strategy/13168, https://wow-petguide.com/Strategy/13169, https://wow-petguide.com/Strategy/13171, https://wow-petguide.com/Strategy/14891, https://wow-petguide.com/Strategy/14890, https://wow-petguide.com/Strategy/15257, https://wow-petguide.com/Strategy/15515, https://wow-petguide.com/Strategy/15759, https://wow-petguide.com/Strategy/15808 yourself, if you want.

Of course a non-existent ability doesn't have a cooldown, so that would be an error. I would instantly agree with an error since that's safe. My goal with the old ticket was making it semantically sane and somewhat-how-people-expect-it, while still holding the requirement of basic logic, i.e. a = a => a != not a.  I'd also agree on changing the definition to non-existent = 0 if users confirm that's what they expect. non-existent = silent ignore does not seem to be what people want, most of the time.
From a programming perspective, I find a line being silently ignored completely weird. I don't feel like that's the same as with use (nonexistent) since that's action vs condition. An action not working is different from the condition for using that action not working. x [true] can still fail to execute. x [true] should not not execute if the current pet doesn't have true though.

What people expect:
[self.ability(nonexistent).duration>1] same as [self.ability(nonexistent).exists & ...duration>1] (implicit) --> false & error --> False comes first. So I think most people would expect a false.
What they don't expect:
[self.ability(nonexistent).duration>1] --> [self.ability(nonexistent).exists & ...duration>1] --> true & ('inf' > 1) --> True (https://github.com/axc450/pbs/issues/17#issue-1455895731)

[self.ability(nonexistent).duration>1] --> [self.ability(nonexistent).exists & ...duration>1] --> true & ('inf' > 1) isn’t what is happening. [self.ability(nonexistent).duration>1] --> 'inf' > 1. [self.ability(nonexistent).exists & self.ability(nonexistent).duration>1] --> FALSE & ('inf' > 1)`.
i have seen the script
use(ultimate) [ enemy.ability(dodge).duration > 0 ]
use(filler)

which surely wants to use ultimate if the enemy can’t ever dodge.
I‘ll remove myself from this discussion and let @axc450 decide.

I know under the hood is "[self.ability(nonexistent).duration>1] --> 'inf' > 1" happening. But I would expect that the ability will be checked first if the ability exists. Maybe it's wrong but that's what I would expect.
use(ultimate) [ enemy.ability(dodge).duration > 0 ]
use(filler)

--> I don't want to get the information whether the enemy can dodge or not. It's clear, I want to know the duration (>0). Big difference. And when the ability doesn't exists then I can't get duration informations --> error
Anyway, thanks for the time and effort to analyze the scripts from xufu.

Ultimately, I think the correct answer here is that things need to be redesigned internally so that functions stop returning bools and return actual errors which will halt the scripts on the offending line. There are good points on both sides but when you have something invalid, I dont think it should return a bool at all.
Leaving this issue open until we have had a proper think about how a redesign would work.


Pin dependencies

[x] Pin all the dependencies in package.json.
[x] Review the dependencies and check if they are needed.
[x] Check whether all scripts are working properly and fix them if not.

Implemented in #457

Implemented in #457


Error when run 'FacebookTabBar'

Error message: 'undefined is not an object (evaluating 'this.props.tabs.map')
I got that message after I try to run 'FacebookTabBar'

Just need to add default value for tabs. Would you like to make pull request?

FacebookTabBar is just an example. If you make PR it would be great.

is this solved? I get the same problem too.


Update text Layer

Hello,
To start, thank you very much for this library, it's perfect !
Next, I'm going to explain my situation :
I want to create a C# personnal application to read a psd file, get a specific layer, and update it. After the update, the application save the file as png file (with an other name if is it possible). The layer is always a text layer.
With your code, I got the good layer, but I don't find how Can I modify his text. There isn't method or attribut representing the text in the layer.
My code :
PsdFile psd = new PsdFile();
psd.Load(@"C:\Users\sigt_vm\Documents\03_IF\Visuels\PSD\PSD_Liga.psd");

Layer lScore = psd.Layers.FirstOrDefault(l => l.Name.Contains("Score"));

I attached my psd file, opened with Photoshop.
Can you help me ? :)
Thank you !

Up ? :/

UP :) ?

@ValentinM92 did you ever figure out how to do this?

Hello,
The owner of this library doesn't really answer me and I give up this way.
So i dont find a solution to update a PSD layer in .Net with a library :(

From: Timothy<EMAIL_ADDRESS>Sent: Saturday, February 9, 2019 9:14:00 PM
To: bizzehdee/System.Drawing.PSD
Cc: ValentinM92; Mention
Subject: Re: [bizzehdee/System.Drawing.PSD] Update text Layer (#5)
@ValentinM92https://github.com/ValentinM92 did you ever figure out how to do this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bizzehdee/System.Drawing.PSD/issues/5#issuecomment-462075655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AawOsYZUP8Ce6rD6eBtZu40mqENo4Qgbks5vLywIgaJpZM4NI1Sw.

Hello,
To start, thank you very much for this library, it's perfect !
Next, I'm going to explain my situation :
I want to create a C# personnal application to read a psd file, get a specific layer, and update it. After the update, the application save the file as png file (with an other name if is it possible). The layer is always a text layer.
With your code, I got the good layer, but I don't find how Can I modify his text. There isn't method or attribut representing the text in the layer.
My code :
PsdFile psd = new PsdFile();
psd.Load(@"C:\Users\sigt_vm\Documents\03_IF\Visuels\PSD\PSD_Liga.psd");

Layer lScore = psd.Layers.FirstOrDefault(l => l.Name.Contains("Score"));

I attached my psd file, opened with Photoshop.
Can you help me ? :)
Thank you !

try try
static bool CheckIsText(System.Drawing.PSD.Layer layer)
{
foreach (var AdjustmentInfo in layer.AdjustmentInfo)
{
if (AdjustmentInfo.Key == "Tysh")
{
return true;
}
}
return false;
}

我想知道怎么才能得到一个组下面有多少个图层，头疼


Fix metrics dead link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add new logo icons

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #252, #260
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Add new and edit existing partner logo icons
Add hazard icons
Update dependencies

Type of change:

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery
Add new partner logo icons and update existing ones with revised dimensions. Update TypeScript configuration to process source JavaScript files and target ES2022.
New Features:

Add new partner logo icons for various airlines including Cape Air, Mokulele Airlines, Royal Air Maroc, Porter Airlines, Iberia, Kenmore Air, Malaysia Airlines, Royal Jordanian, Southern Airways Express, Air Tahiti Nui, SriLankan Airlines, Bahamasair, Aleutian Airways, and Air Tahiti.

Enhancements:

Update existing partner logo icons with new dimensions for airlines such as Ravn Alaska, American Airlines, Cathay Pacific, Emirates, Fiji Airways, Korean Airlines, LATAM Airlines, Qantas, Singapore Airlines, Japan Airlines, Hainan Airlines, FinnAir, British Airways, Condor, Aer Lingus, Icelandair, and Israel Airlines.

Build:

Update TypeScript configuration to include source JavaScript files instead of distribution files and set the target to ES2022 with node module resolution.

:tada: This PR is included in version 4.43.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[backend] String values are saved with double quotes in Chart values/settings

Related PR: https://github.com/epinio/ui/pull/300#issuecomment-1673179636

I suspect that the issue is the fact that the server is not storing the incoming CV data as-is somewhere where it can be returned without effort. Instead it tries to ~heuristically~hackishly reconstruct the CV data from the helm release of the server. And returns JSON data, instead of the incoming plain strings, for the more complex structures (nested maps, arrays, maps in arrays, ...)
Plan to fix:

Store the CV data in the service secret. Return it from there when asked.
Keep the heuristic reconstruction for backward compatibility with 1.9.0-created services which will not have this stored CV data.


iter: Tests are not passing for ProductIterator using autofree

VSL version: 0.1.36
OS: ArchLinux (Linux)
What did you do?
Executed ./bin/test --use-autofree
What did you expect to see?
Expected the tests to pass using autofree
What did you see instead?

@natemcintosh probably you could be interested on solving this one 👌🏻

Yea, I can reproduce this pretty easily. However, it doesn't happen when not running with --use-autofree. I don't know enough about the v compiler to say why this might happen.
Do you have any suggestions?

@natemcintosh yeah, I saw that too but I'm not really sure why it is happening. I'll try to debug it and see if I can give more context to solve it 👌🏻

@natemcintosh Seems that all is passing with -gc boehm, so I assume the problem is that autofree is not stable enough yet. I'll close this issue for now


Derive dlog keys size from snark pk when proving

It should be possible (please @UlrichHaboeck75 confirm) to derive the dlog key size by reading index data and the number of commitments inside the snark pk passed to prover. In this way, we wouldn't need to pass the supported segment size to the prover functions, thus reducing the possibility of introducing bugs.
If not possible, or if there is a more elegant way to do it, let's discuss on alternatives

As discussed offline, it's not possible to uniquely determine the segment size from the pk including the size of domain H and K.


syntatical improvements to progress bar

Just some minor syntatical improvements to the progress bar component;

use class properties / static class properties where possible
assign styled components to a variable before exporting it to allow for better dev experience (human readable name in chrome dev tools)

Coverage decreased (-0.02%) to 99.222% when pulling fb119e3ce93305b57492db5f80d61e9ff92bf923 on GGAlanSmithee:progress-bar-improvements into 2d09df1d1a2aaca43023976816f9310836131a40 on react-boilerplate:dev.

Coverage decreased (-0.02%) to 99.222% when pulling 60d36df7ca1764ceafb40745933d4cb5d461c97e on GGAlanSmithee:progress-bar-improvements into f80169ce2236004178591b1427b54eb8227b1bff on react-boilerplate:dev.

Coverage decreased (-0.02%) to 99.222% when pulling 9c5c660f3fd035807757f529a3b2fb228c16fc70 on GGAlanSmithee:progress-bar-improvements into 5c495e7185ab7f584cb4008acd8258a114b41648 on react-boilerplate:dev.

@GGAlanSmithee I just realized that static propTypes are not used in other files. I'd like to have uniform coding style. Let's have the propTypes outside of the class for now. Use of anonymous functions for class methods is acceptable because we haven't used those anywhere else. Does that make sense?

@KarandikarMihir
Updated it to not use the static keyword. (FYI it used it even before my PR).

Coverage decreased (-0.01%) to 99.231% when pulling 348222962a92aaa91b218cbc117a17d3357e410f on GGAlanSmithee:progress-bar-improvements into 5c495e7185ab7f584cb4008acd8258a114b41648 on react-boilerplate:dev.

Coverage decreased (-0.01%) to 99.231% when pulling 348222962a92aaa91b218cbc117a17d3357e410f on GGAlanSmithee:progress-bar-improvements into 5c495e7185ab7f584cb4008acd8258a114b41648 on react-boilerplate:dev.

Coverage decreased (-0.01%) to 99.231% when pulling 7f29d29e17395e616a41cd5872a01b42c6311d1e on GGAlanSmithee:progress-bar-improvements into ea1e1c451c12bd4b36057d884a1087d45a27310a on react-boilerplate:dev.

@GGAlanSmithee No problem! Thanks a lot for your work! Merging when checks pass.

Coverage decreased (-0.01%) to 99.231% when pulling<PHONE_NUMBER>9d8a9e8a9e84c70ed7e6456c77cc12 on GGAlanSmithee:progress-bar-improvements into f813fb6aba2a761875ad75f28ebaa30da07a658d on react-boilerplate:dev.


Screenshot when error occured

Hi,
I'm curious how to capture screenshot when actual result does not meet expected result?
Because I could not find any screenshot captured when it happened...

@fergadipa Screenshots are not embedded yet but I would implement it as a new feature at some point. Meanwhile Try XCSummary tool to do that !


CSS not displaying on posts

Hello, I can't seem to get CSS displaying correctly for posts (the rest of the site works fine).
http://skydusk.github.io/
As you can see the first test post doesn't display properly: http://skydusk.github.io/2015/08/27/Test.html
Do you know what I'm doing wrong here? Also many thanks for this design, its one of my jekyll favourites

In https://github.com/skydusk/skydusk.github.io/blob/master/_layouts/default.html#L15 , add a / before css. It should be
<link rel="stylesheet" href="/css/style.css">
Notice the '/' before css/style.css

yes someone managed to tell me the exact same thing a few minutes ago, everything is displaying correctly now.
once again thank you for this theme, its really great.


add Notification Type to Snack Messaging

@fabian-bizfactory please let me know once you've looked through the diff and you think this is ready for review

Sorry, about the PR pull. Found a potential issue after creating it


Fix typo in guide

Added required dependencies into the guide (without dependencies dropdown doesn't work: https://jsfiddle.net/h9rfjL81/2/ , but it works when they are added: https://jsfiddle.net/a5d1zgh6/2/ )


embassy.dev using self-signed traefik cert and hsts is enabled - cannot access from chrome or firefox

sorry if this is the wrong repo..
I am unable to access https://embassy.dev/ from chrome or firefox
ssl labs reports

and chrome reports that hsts is enabled for the site, therefore the self-signed cert is not accepted.

I'm migrating the server, it should be back up in some minutes. Sorry for the trouble!

thanks for the fast response. FYI, I was following a link from this page https://tweedegolf.nl/en/blog/70/we-asked-5-people-why-they-like-embedded-rust

Fixed now!


New Sample: Monitor Security Risks

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?

What's in this Pull Request?

This adaptive card extension sample demonstrate ability to monitor security risks using identity protection graph api from Viva Connection Dashboard

@ArijitCloud Thanks for the update. I will give it a review and publish as soon as I can.


Bug: Snippets using "$" not "${" as tab indexes.

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:38:28.425Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

base16-themes
AndrsDC
1.0.6

JSDocTagComplete
HookyQR
0.0.2

material-icon-theme
PKief
1.1.4

lorem-ipsum
Tyriar
1.0.0

theme-toothpaste
aalaap
0.0.1

vscode-color
anseki
0.2.2

theme-material
bcmarinacci
1.3.0

theme-material-neutral
bernardodsanderson
0.9.0

htmltagwrap
bradgashler
0.0.3

theme-dracula
dracula-theme
1.2.5

php-intellisense
felixfbecker
0.0.12

spacegray-vscode
ionutvmi
1.1.4

markdown-table-formatter
josa
0.0.4

theme-material-theme
jprestidge
1.0.1

vscode-scss
mrmlnc
0.6.0

Theme-TomorrowKit
ms-vscode
0.1.3

sublime-keybindings
ms-vscode
1.8.0

stylelint
shinnn
0.20.4

code-spell-checker
streetsidesoftware
0.12.2

gitblame
waderyan
1.3.0

change-case
wmaurer
1.0.0

Material-theme
zhuangtongfa
1.0.3

Steps to Reproduce:

Create PHP snippet:

{
	"CDN": {
		"prefix": "cdn",
		"body": [
			"$this->cdn($1)$2"
		],
		"description": "Insert a view->cdn method call."
	}
}

Open a PHP file and run the snippet. Output is this->cdn()  with "this" selected. Should output $this->cdn() with caret within the cdn call.

escape the $ sign using \\
in your case use the following for the body:
"\\$this->cdn($1)$2"

Thanks


[Enhancement] Get last version (use autoupdate_main.py from parent git

Allow to get the most enhanced version, may be prone to bug so maybe add a disclaimer.
Possible fix works and have been used for a few weeks now, current usage (main.py) is unchanged.
Description
What I likes about charles version is the autoupdate script, so I adapted it to klept0 git
Possible Fix
Save as autoupdate_main.py, change any call of main.py in your task scheduler to call it without changing the flags
import os

import sys
from io import BytesIO
from zipfile import ZipFile

import requests

def update(version: str):
    url = "https://github.com/klept0/MS-Rewards-Farmer/archive/refs/heads/master.zip"
    folderName = "MS-Rewards-Farmer-master"
    with open(".gitignore", "r") as f:
        exclusions = f.read().splitlines()
        exclusions = [e for e in exclusions if e != "" and not e.startswith("#")] + [
            ".gitignore",
            ".git",
            "autoupdate_main.py",
        ]
    print("Removing old files...")
    for root, dirs, files in os.walk(".", topdown=False):
        for name in files:
            path = os.path.join(root, name)
            relativePath = path[2:]
            if not relativePath.startswith(tuple(exclusions)):
                os.remove(path)
    print("Downloading...")
    r = requests.get(url)
    data = BytesIO(r.content)
    print("Extracting...")
    with ZipFile(data, "r") as zipObj:
        files = [
            f
            for f in zipObj.namelist()
            if f.startswith(folderName) and not f.endswith("/")
        ]
        for file in files:
            newName = file.replace(f"{folderName}/", "")
            dirName = os.path.dirname(newName)
            if "/" in newName and not os.path.exists(dirName):
                print(f"Creating folder {dirName}...")
                os.makedirs(dirName)
            with zipObj.open(file) as src, open(newName, "wb") as dst:
                dst.write(src.read())
    with open("version.txt", "w") as f:
        f.write(version)
    print("Done !")

def getCurrentVersion():
    if os.path.exists("version.txt"):
        with open("version.txt", "r") as f:
            version = f.read()
        return version
    return None

def getLatestVersion():
    r = requests.get(
        "https://api.github.com/repos/klept0/MS-Rewards-Farmer/commits/master"
    )
    return r.json()["sha"]

if __name__ == "__main__":
    currentVersion = getCurrentVersion()
    latestVersion = getLatestVersion()
    if currentVersion != latestVersion:
        print("New version available !")
        update(latestVersion)

    print("Starting...")

    import main

    main.sys.argv[1:] = sys.argv[1:]
    main.main()

I know the original repo stopped using it because it caused issues and didn't work right. I never got around to implementing it as I just do maintenance updates and if a  new feature is added then I would let people know in the TG chat


Migrate to CB3 syntax

Linter will complain: https://github.com/conda-forge/conda-smithy/issues/757.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The "source" section was expected to be a dictionary, but got a CommentedSeq.
The "source" section was expected to be a dictionary, but got a CommentedSeq.


[BEAM-3579] Fix textio.Write

R: @lostluck

Thanks!

R: @tgroh (please merge)

https://issues.apache.org/jira/browse/BEAM-3646 tracks adding that documentation to the Java SDK; there are likely other places which should have similar warnings.


Missing support for --version command line argument

Desired behavior: return something like "TRIK Studio (Windows 64) 3.3.1"

Fixed in #55


update midterm blog

update my midterm blog

Thanks @JoannaCCJH -- please make the following changes.
I've fixed the problem and commited. Please recheck!


Compatibility with Debian 8.2 "jessie"

I need to install grsecurity on a Debian 8.2 "jessie" machine with Liquid Feedback. Is it supported by the installer?

Yes - but Debian sid now has a prebuilt grsec kernel package so it's easier to use that (add sid to your apt sources and set the target release to jessie)

Unfortunately SID is unstable and I need a stable release. What do you suggest?

Set the target release to Jessie in your apt config so sid is only used for this one package. It uses the "testing" patch from grsecurity.net and not unstable as such

Ok, I'll try and report back.


Objects endpoint

When testing the /<api-root>/collections/<id>/objects/ endpoint, it seems that the server returns JSON if the Accept header is set to application/vnd.oasis.taxii+json but returns HTML if it is set to application/vnd.oasis.stix+json. Looking at Section 5.3 in the spec it looks like it should accept the STIX media type.

Thanks for reporting this. I will get this fixed.

Fixed. The test server is running with the updated code.


[Event Request] report 5852 "Suggest Capacity Standard Cost" - OnInsertStdCostWkshOnBeforeInsert

Describe the request
local procedure InsertStdCostWksh(Type2: Option; No2: Code[20])
begin
    with ToStdCostWksh do begin
        Init();
        Validate("Standard Cost Worksheet Name", ToStdCostWkshName);
        Validate(Type, Type2);
        Validate("No.", No2);

        Validate(
          "New Standard Cost",
          RoundAndAdjustAmt("Standard Cost", RoundingMethod[1], AmtAdjustFactor[1]));
        Validate(
          "New Indirect Cost %",
          RoundAndAdjustAmt("Indirect Cost %", RoundingMethod[2], AmtAdjustFactor[2]));
        Validate(
          "New Overhead Rate",
          RoundAndAdjustAmt("Overhead Rate", RoundingMethod[3], AmtAdjustFactor[3]));

        OnInsertStdCostWkshOnBeforeInsert(ToStdCostWksh, RoundingMethod, AmtAdjustFactor);
        if not Insert(true) then
            Modify(true);
    end;
end;

[IntegrationEvent(false, false)]
local procedure OnInsertStdCostWkshOnBeforeInsert(var ToStdCostWksh: Record "Standard Cost Worksheet"; RoundingMethod: array[3] of Code[10]; AmtAdjustFactor: array[3] of Decimal)
begin
end;

Additional context
Just because we need it...Internal work item: AB#493280

Hmm, a bit of extra work here. It seems this event exists in W1 23.01 but not in the NL localization. How is that possible?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14606.


Improve the a11y of licensing values in the audio player

Problem

Aria-label on licensing values will not be read. aria-label is only valid on interactive elements, but is attached to a span.
Description

The preferred fix would be to wrap this in a link that points to detailed information on the licensing of the image, but you can’t embed interactive components inside other interactive components. So the best option available using the current model is to use aria-hidden=”true” on the current licensing information and add the expanded version for screen readers in text that’s hidden visually using a screen-reader-text class.
No audio feedback for screen readers when changing the slider value.
Additional context

Reported by Joe Dolson (https://make.wordpress.org/openverse/2022/09/07/frontend-release-v3-4-8-and-a-call-for-a11y-testing/#comment-95)
Implementation

[ ] 🙋 I would be interested in implementing this feature.

Blocked due to code freeze for Nuxt 3 migration.


Responsive resizing bug

I think this was mistakenly taken out here:
https://github.com/jrowny/react-absolute-grid/commit/43ab96c7e4552b36032745ace795054b7ef2b829?diff=unified#diff-0e642873a5d3a0a4b6da941a0c719864L112

Thanks. My mistake. I've removed this flag whatsoever in 2.0. Don't think this is needed. See #16 and #15

Closing because this should be fixed by #16


Jest installation and use of basic example is unclear / throws Error.

Using jest-enzyme, here is my test file, copied directly from your examples:
import React from 'react'
import {mount, shallow} from 'enzyme'

function Fixture() {
  return (

      <input id="checked" defaultChecked />
      <input id="not" defaultChecked={false} />

  );
}

describe('wrapper', () => {
  it('works', () => {
    const wrapper = mount(<Fixture />); // mount/render/shallow when applicable
    expect(wrapper.find('#checked')).toBeChecked();
    expect(wrapper.find('#not')).not.toBeChecked();
  })
})

I have installed as devDependencies jest-enzyme, enzyme, react-addons-test-utils.
I get this failure message:
> CI=true react-scripts test --env=jsdom

 FAIL  src/__tests__/ListModalSpec.js
  ● wrapper › works

    TypeError: expect(...).toBeChecked is not a function

      at Object.<anonymous> (src/__tests__/ListModalSpec.js:16:38)
      at process._tickCallback (internal/process/next_tick.js:103:7)

How am I holding it wrong?

Did you follow the setup for jest-enzyme? https://github.com/blainekasten/enzyme-matchers/blob/master/packages/jest-enzyme/README.md#setup

Yes. Here is my package.json:
{
  "name": "react-example-project",
  "version": "1.0.0",
  "description": "Simple React project",
  "main": "index.js",
  "repository": {},
  "scripts": {
    "test": "CI=true react-scripts test --env=jsdom",
    "watch_test": "react-scripts test --env=jsdom"
  },
  "author": "Amanda Simon",
  "license": "UNLICENSED",
  "dependencies": {
    "babel-cli": "^6.18.0",
    "babel-plugin-transform-react-jsx": "^6.8.0",
    "babel-preset-es2015": "^6.18.0",
    "babel-plugin-add-module-exports": "^0.2.1",
    "react": "^15.4.1",
    "react-dom": "^15.4.1",
    "react-router": "^3.0.0"
  },
  "devDependencies": {
    "enzyme": "^2.7.1",
    "jest-enzyme": "^2.1.0",
    "react-addons-test-utils": "^15.4.2",
    "react-scripts": "0.8.4"
  },
  "babel": {
    "presets": [
      "es2015"
    ],
    "plugins": [
      "transform-react-jsx",
      "add-module-exports"
    ]
  },
  "jest": {
    "setupTestFrameworkScriptFile": "./node_modules/jest-enzyme/lib/index.js"
  },
}

react-scripts currently uses<EMAIL_ADDRESS>

Ah, so react-scripts handles jest config a little bit differently. This PR show you how to setup jest-enzyme with react-scripts https://github.com/facebookincubator/create-react-app/pull/994/files

Thanks! You might add that link & explanation to the jest-enzyme README.
I'd started to dig through node_modules figuring react-scripts might be the problem but hadn't put it together yet that I could pass it a setup file. Thank you!

Okay, I got the first example above working by following the instructions (making a setupTests file that imports jest-enzyme). I get a "Pass". But, other matcher examples still fail. For example:
import React from 'react'
import {mount, shallow} from 'enzyme'

function Fixture() {
  return (

  );
}

describe('wrapper', () => {
  it('works', () => {
    const wrapper = mount(<Fixture />); // mount/render/shallow when applicable
    expect(wrapper.find('span')).toBePresent();
    expect(wrapper.find('ul')).not.toBePresent();
  })
})

Produces:
 FAIL  src/__tests__/ListModalSpec.js
  ● wrapper › works

    TypeError: Cannot read property '_tag' of undefined

      at Object.<anonymous> (src/__tests__/ListModalSpec.js:17:34)
      at process._tickCallback (internal/process/next_tick.js:103:7)

Sorry I'm having such a hard time figuring this out!

This seems to be same error as: https://github.com/blainekasten/enzyme-matchers/issues/55 since the other matcher examples work.

What version of React are you using?

I just copied your test into my repo and it passed just fine. It must be a react version I wasn't planning for..

Thanks! You might add that link & explanation to the jest-enzyme README.

I'd started to dig through node_modules figuring react-scripts might be the problem but hadn't put it together yet that I could pass it a setup file. Thank you!

A smart idea. Want to submit a PR for it?

Sorry I'm having such a hard time figuring this out!

No problem at all! Glad you are finding this to be helpful!

15.4.1
"dependencies": {
    "babel-cli": "^6.18.0",
    "babel-plugin-transform-react-jsx": "^6.8.0",
    "babel-preset-es2015": "^6.18.0",
    "babel-plugin-add-module-exports": "^0.2.1",
    "react": "^15.4.1",
    "react-dom": "^15.4.1",
    "react-router": "^3.0.0"
  },
  "devDependencies": {
    "enzyme": "^2.7.1",
    "jest-enzyme": "^2.1.0",
    "react-addons-test-utils": "^15.4.2",
    "react-scripts": "0.8.4"
  },

Yay, I reproduced it on 15.4.2! I'll try and find a fix. Thanks so much! I'm not sure if there is a work around right now

Awesome! Thank you!

Can you test 2.1.1-rc1 please

I published 2.1.1 which seemed to fix this. Thanks for the reports!


Incorrectly formats variable assignation

Describe the bug
Incorrectly formats variable assignation operator := as : =.
To Reproduce
Run this correct SQL through sqlfmt:
select partman.create_parent( 'public.deliveries_finished', 'created_at', 'native', 'daily', p_premake := 20) ;

Expected behavior
select
    partman.create_parent(
        'public.deliveries_finished', 'created_at', 'native', 'daily', p_premake := 20
    )
;

Actual behavior
Notice the separation between the colon and the equal sign:
select
    partman.create_parent(
        'public.deliveries_finished', 'created_at', 'native', 'daily', p_premake: = 20
    )
;

Additional context
sqlfmt, version 0.20.0
This makes the SQL to fail.

Thanks for the report. Is this MySQL?

This is Postgres (PL/pgSQL).


Review downloads features

Some of them don't include the right things or are not named correctly

@allthesignals Can you clarify this further?

@chriswhong raised some questions about what the download links include

Dup of #369


Possible dangling pointer in esp_netif_set_hostname_api (IDFGH-4189)

IDF version: (master)

Problem Description
In esp_netif_set_hostname_api, p_netif->hostname may no longer be valid if the function returns for any reason after freeing esp_netif->hostname but before setting p_netif->hostname to the new pointer
https://github.com/espressif/esp-idf/blob/357a2776032299b8bc4044900a8f1d6950d7ce89/components/esp_netif/lwip/esp_netif_lwip.c#L1106-L1141
Steps to reproduce

Set a valid hostname so that esp_netif_set_hostname_api copies the string, sets p_netif->hostname, and returns ESP_OK
Now repeat with an invalid hostname (eg. with strlen > ESP_NETIF_HOSTNAME_MAX_SIZE). The previous hostname will be freed, but p_netif->hostname still points to this memory as the function returns early.
esp_netif_get_hostname will return ESP_OK but the pointer is not valid; also presumably lwip functions that use this pointer may send junk (eg. dhcp_option_hostname)

Expected Behavior

Keep p_netif->hostname in sync with esp_netif->hostname.

Perhaps skip strdup (or free) if there is any error. Only copy string if it will be used.

Thanks for reporting.

Thanks for reporting and sorry for late reply, we have a fix under internal reviewing and the issue will close automatically once the fix is available on GitHub. Thanks.


@rendition for an inscription in Kannada script and language?

@danbalogh
Would this do?
<div type="edition" xml:lang="kan-Latn" rendition="class:83217 maturity:83215">
Where "class: 82317" = Brāhmī and derivatives
and "maturity:83215" = vernacular Brāhmī-derived script
NB: this applies to https://dharmalekha.info/texts/DHARMA_INSKarnataka00001

I suppose so.

Fine. Thanks!


Allow byte array bodies without coercion

In order not to copy bodies, allow byte array bodies that are set as the Entity with no coercion.

Fixed in 0.3.0 with the new coercion stuff.


fix added for JSON not generating for failed integration tests #90799

This pull request contains the fix for the issue #90799  where json report was not getting generated in case of failed integration tests.
The code to get the response data has been moved out of the "if block for pass test status" so that json report gets created irrespective of test fail or test pass status.
if (responseDataCallback != null) {
await responseDataCallback(response.data);
}
Changes are done in packages/integration_test/lib/integration_test_driver.dart file only.
The fix has been tested on android, iOS and Web and found to be working fine.
Before - integration_reponse_data.json file was not generated for failed integration tests
After - integration_reponse_data.json file is getting generated for both fail and pass integration tests.
Please review this pull request and merge it to provide the fix in future Flutter release.

This will need tests. Also it seems to be failing some of the existing tests, though I haven't checked why.

I am going to close this PR for now. Feel free to re-open when you find the time to address the comment above.


Cannot connect to mssql 2014, 2016 from docker, only 2017

I create empty web api project and try run it in docker container and connect to mssql server.
using (var connection = new SqlConnection("Server=ip,port;Database=master;User=test;Password=test"))
{
       connection.Open();
}

When connecting to the sql server 2014,2016, the application hangs endlessly. If i run without docker its works fine. If i install sql express 2017 connection from docker works fine. Why? How to fix it?

@ajcvickers ?

@concretor91 Looks like you could be hitting https://github.com/dotnet/SqlClient/issues/43 If not, then please file a new issue at https://github.com/dotnet/SqlClient/issues and include a small, runnable project/solution or complete code listing.

@ajcvickers
Perhaps this is the same problem. I keep experimenting. I install last service pack on sql 2014(sql 2014 installed long ago), but no effect, still endless hangs. I completely remove sql 2014 and install. Now instead of freezing it gives an error:
OpenSslCryptographicException: error:1425F102:SSL routines:ssl_choose_client_version:unsupported protocol
Again, this is a clean template. I only change method of controller. I try .net core 2.2, 3.9 preview 7.
        [HttpGet]
        public ActionResult<IEnumerable<string>> Get()
        {
            using (var connection = new SqlConnection("Server=ip,port;Database=master;User=user;Password=password"))
            {
                connection.Open();
            }

            return new string[] { "value1", "value2" };
        }


ZTE-SH-CN-run-application-scale-stateful-set-2017-09-08

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

cc @zhangxiaoyu-zidif

This is a translation PR from ZTE-Shanghai.

cc @markthink

@jianglingxia Please close PR, update to k8smeetup library, unified submission..Do not submit a single file..
update table:
https://docs.google.com/spreadsheets/d/1FDFCv9RK5nSMgLXhPrJ5k7r5QvHnNEFnXbvoFiM8v20/edit#gid=1015862274

@jianglingxia Please close PR, update to k8smeetup library, unified submission..Do not submit a single file..
update table:
https://docs.google.com/spreadsheets/d/1FDFCv9RK5nSMgLXhPrJ5k7r5QvHnNEFnXbvoFiM8v20/edit#gid=1015862274

@chenopis  We will maintain a list of translators，As far as possible to avoid a separate submission。
https://docs.google.com/spreadsheets/d/1nHCp-wHf26lqcah9CVQpPaiSFxqVrsdFlCyRyHCjz80/edit#gid=0

@markthink
keeping it seems to be ok.

thanks for your careful review and I have modified with your advice,If you think no problem ,I will squash into one commit,thanks! @zhangxiaoyu-zidif

LGTM


Local Admin Required

Is it possible to have a portable version (even if it is limited) that does not require local admin to run/install

Not currently. Due to MSI installation and various functionality the toolkit does, it needs admin access on your Windows machine.


fix an error in tolerance argument

Purpose

Fixes the argument order bug introduced in #78. Also slightly increase the relative tolerance.
To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


feat: outputs timing for check-style blocks

The "Verifying formatting" step is sometimes slow-ish, and when we run
clang-tidy from the command line, it would be nice to see what it's
doing. This PR adds timing output to each section of the check-style
script so the user can see what it's doing, and we'll know if a section
all of a sudden gets slow and can be optimized. The output looks like:
2020-05-05T18:41:32Z: Verify formatting
Running check-include-guards: ... 0.045 seconds
Running cmake-format:         ... 3.607 seconds
Running clang-format:         ... 1.981 seconds
Running buildifier:           ... 0.041 seconds
Running black:                ... 0.148 seconds
Running shfmt:                ... 0.024 seconds
Running shellcheck:           ... 1.237 seconds
Running include fixes:        ... 1.876 seconds
Running whitespace fixes:     ... 2.632 seconds

This change is

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devjgm)

ci/check-style.sh, line 35 at r1 (raw file):

printf "%-30s" "Running check-include-guards:"
time {
  problems=""

The initialization of problems probably belongs outside the time block.

Fixed, though I don't think it matters in bash since curly braces don't create a new scope or subshell.

ci/check-style.sh, line 63 at r1 (raw file):
Previously, devjgm (Greg Miller) wrote…
In a followup to that previous comment I said, "I was unable to produce such a big change inside a docker run. -n 3 seemed to be the best, but the differentials were fractional seconds, so I'm happy to stick with -n 1." Take that as you see fit.

Oh, I never saw that followup. Not sure how I missed it. But thanks for checking. 1, 3, 42, whatever is fine w/ me.


quote env var names

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We use this on livebook server --help, which has no markdown formatting, which is why we use no quoting in this section. Thanks!


Problem with ModSecurity no support JSON

A good day! I have reverse proxy nginx with modsecurity
after send POST http I have error
ModSecurity: JSON support was not enabled [hostname ""] [uri "/postComment"] [unique_id "0dAcAcxcAcncABABAYAcAcAc"]
To fix  it I rebuild modsecurity with LibYAJL library
git clone git://github.com/lloyd/yajl
tar  yajl
cd yajl/
./configure
make
make install
ldconfig
cd Modsecurity/
./configure --with-yajl="/usr/local/lib /usr/local"
make
make install
ln -s /usr/local/share/pkgconfig/yajl.pc /usr/share/pkgconfig/yajl.pc
after that steps I have same error!
How I can fix it?
nginx -V
nginx version: nginx/1.10.3 (Ubuntu)
built with OpenSSL 1.0.2g  1 Mar 2016
TLS SNI support enabled
configure arguments: --with-cc-opt='-g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2' --with-ld-opt='-Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z,relro -Wl,-z,now' --prefix=/usr/share/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --lock-path=/var/lock/nginx.lock --pid-path=/run/nginx.pid --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --with-debug --with-pcre-jit --with-ipv6 --with-http_ssl_module --with-http_stub_status_module --with-http_realip_module --with-http_auth_request_module --with-http_addition_module --with-http_dav_module --with-http_geoip_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_image_filter_module --with-http_v2_module --with-http_sub_module --with-http_xslt_module --with-stream --with-stream_ssl_module --with-mail --with-mail_ssl_module --with-threads
uname -a
Linux free 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
With Best Regards!

Hi @alterego2004
I think you're not pointing the --with-yajl option to the correct path. As you have already make install YAJL the configure script should be able to detect it automatically so you could omit the --with-yajl option and you should see something like when running ./configure: configure: using YAJL v2.1.1
At the end of the script you should see a summary which should show YAJL options  as highlighted below:
ModSecurity - v3.0.2-64-ga3980bb for Linux

 Mandatory dependencies
   + libInjection                                  ....v3.0.2-64-ga3980bb
   + SecLang tests                                 ....a3980bb

 Optional dependencies
   + GeoIP/MaxMind                                 ....found
      * (GeoIP) v1.6.2
         -lGeoIP , -I/usr/include/
   + LibCURL                                       ....found v7.38.0
      -L/usr/lib/x86_64-linux-gnu -lcurl,  -DWITH_CURL_SSLVERSION_TLSv1_2 -DWITH_CURL

+ YAJL                                          ....found v2.1.0
-lyajl , -DWITH_YAJL -I/usr/include/yajl
   + LMDB                                          ....not found
   + LibXML2                                       ....found v2.9.1
      -lxml2, -I/usr/include/libxml2 -DWITH_LIBXML2
   + SSDEEP                                        ....not found
   + LUA                                           ....found v503
      -llua5.3 -L/usr/lib/x86_64-linux-gnu/, -DWITH_LUA -I/usr/include/lua5.3

 Other Options
   + Test Utilities                                ....enabled
   + SecDebugLog                                   ....enabled
   + afl fuzzer                                    ....disabled
   + library examples                              ....enabled
   + Building parser                               ....disabled
   + Treating pm operations as critical section    ....disabled

If this is not what you're getting, try specifying the --with-yajl with the correct path pointing to the YAJL header files (.h) like /usr/include/yajl or /usr/local/include/yajl or even to the path where you compiled YAJL (yajl/build/yajl-2.1.1).

As this question is more specific with libModSecurity and not related with the ModSecurity-nginx connector I will be closing it. If you still have problems, please open the issue on the appropriate bug tracker for libModSecurity here: https://github.com/SpiderLabs/ModSecurity/issues


Fix error message type

Fixes typo in WhiskActivation JSON serdes reader.
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[x] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a47cd42). Click here to learn what that means.
The diff coverage is 50%.

@@           Coverage Diff            @@
##             master   #3595   +/-   ##
========================================
  Coverage          ?   74.5%
========================================
  Files             ?     126
  Lines             ?    5950
  Branches          ?     378
========================================
  Hits              ?    4433
  Misses            ?    1517
  Partials          ?       0

Impacted Files
Coverage Δ

...main/scala/whisk/core/entity/WhiskActivation.scala
91.22% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47cd42...4412c8b. Read the comment docs.


French blocking list

The feature
I use a list of prefixes to block voice spam in France, and it works great. Professionals have to use these prefixes.
Here is the list :

0162, 0163, 0270, 0271, 0377, 0378, 0424, 0425, 0568, 0569, 0948, 0949 (France métropolitaine : +33)
09475 (Guadeloupe, Saint-Martin, Saint-Barthélemy : +590)
09476 (Guyane : +594)
09477 (Martinique : +596)
09478, 09479 (La Réunion, Mayotte : +262)

For exemple, with a rule written like this (?:33)?162.* for the 0162 prefix, it works perfectly.
Source :
ARCEP : https://www.arcep.fr/actualites/actualites-et-communiques/detail/n/plan-de-numerotation-050922.html

Hi, I'm not quite sure what this is about.
Are you looking for a regex? But it's already working perfectly.
Do you want to share your regex? But where is it?
Or just promoting the website and let people do it on their own?

Hi, at the moment I have a working list. And I was thinking of a solution to make it easier for French users to use this regex, either by importing a list or by selecting an option in the app.
I'm not sure how I can share this list and in which format.

I see, if you are using a single regex like (?:33)?(162.*|163.*|270.*|......), simply share it as a text string.
For multiple rules, consider using a .csv file, for example:
pattern, description
(?:33)?(162.*|163.*|270.*|......), description A
(9478.*|9479.*), La Réunion Mayotte
...

It can be "imported as multiple rules" by other people.

As for me here's my regex in France
(?:33)?(1(?:62|63)|2(?:70|71)|3(?:77|78)|4(?:24|25)|5(?:68|69)|9(?:48|49))\d{6}

I'll create a wiki page to gather all regex templates, there will be a new entry "Share Regex" when reporting issues, you can share your regex here and I'll merge them to the wiki page.

It's done, please shared it in the issue list, they will be collected to the wiki page.

Done, now the wiki will be updated automatically whenever there is an issue with label "share regex" is ceated, edited , or deleted.
For example, this issue:

will be sychronized to wiki like:

either by importing it or by selecting an option in the app.

I think users should have the ability to preview the contents before importing, because the usefulness of them is very subjective. I anticipate there to be lots of regex templates in the future, a larger web page would be a better option.
And more importantly, I don't need to mantain the list, the wiki page will get updated automatically :)

Ok, so I close this issue. We can share our Regex now :) .
Thank you


SandpackProps do not allow extended files

Bug report
Sandpack allows extended files options, but exported SandpackProps doesn't allow multiple files with extended options.
https://github.com/codesandbox/sandpack/blob/0c7c0e2bb1ad6c68e51ca93482b72c211fbf382c/sandpack-react/src/types.ts#L48
Packages affected

[ ] sandpack-client
[x] sandpack-react

Description of the problem
Here in the docs files can be of two types. Either Record<string, string> or Record<string, SandpackFile>.
https://sandpack.codesandbox.io/docs/getting-started/usage#file-format
What were you doing when the problem occurred?
A student of my course is learning frontend and as a part of the advanced exercise we are building a custom Sandpack component with extended functions.
What steps can we take to reproduce the problem?

Clone this repository
In this file:
https://github.com/AnthonyNet/create-a-developer/blob/main/src/components/NaucMe__SandPack.tsx#L39-L54
there are errors because of files.

It is enough to just change SandpackProps to allow this file as well
Your Environment

Software
Name/Version

Sandpack-react version
2.6.0

PS: I am willing to do PR to fix this.

PR is there:
https://github.com/codesandbox/sandpack/pull/932


Micromodal cancel buttons are 2px taller than Confirm buttons

If you look closely at these buttons:

The Cancel button is 34px tall and the Confirm button 32px; it appears to be 16x text height, 8px padding on each side, and only Cancel has a 1px border. I think using outline is a common fix for this?  Not sure.
@ganpa3 @sahil839 as folks working on this area.

@zulipbot claim

@zulipbot claim

@ganpa3 Hello, I am trying out as a contributor here. I picked up this issue and I have tried locating the exact code, and I cannot seem to locate it. Since you worked on the popovers, do you mind directing me to where I can find the code? Thank you

@timabbott Maybe we should just remove the border?
This looks fine to me:

Hovering on the cancel button changes the background color so that it can be seen (maybe make it a bit darker?):

@timabbott @ganpa3 I think it would be a better experience if we could show a user that it is a button? What if we give it an outline that disappears into a background color when you hover on it?  What do you think?

@ganpa3 I just looked through firebase and they have a similar pop-up that matches your idea. I think it may work. The background can be darker

@alya thoughts?  My inclination is that it's nice to have buttons have an always visible pill shape for recognizability.

I tried doing this. @timabbott @ganpa3 is this okay?

I tried doing this. @timabbott @ganpa3 is this okay?

That looks reasonable to me, if we want to do the button approach.
By the way, @hunterachieng, you can edit GitHub comments via the three-dot menu in the upper right.

@alya abott I had made a PR to this issue. I finished working on it. Should
I abandon it ?
On Sun, 5 Dec 2021, 04:47 zulipbot, @.***> wrote:

Hello @hunterachieng https://github.com/hunterachieng, you claimed this
issue to work on it, but this issue and any referenced pull requests
haven't been updated for 10 days. Are you still working on this issue?
If so, please update this issue by leaving a comment on this issue to let
me know that you're still working on it. Otherwise, I'll automatically
remove you from this issue in 4 days.
If you've decided to work on something else, simply comment @zulipbot
abandon so that someone else can claim it and continue from where you
left off.
Thank you for your valuable contributions to Zulip!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/20209#issuecomment-986149780, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4KQNTDO5EVOFPBA2XGC3TUPLADBANCNFSM5HV5FADA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@hunterachieng no need, as you are waiting for any additional feedback. Thanks for checking.

I think this was resolved through @amanagr redesigning the buttons to use our existing button styles.  Closing as now invalid.  Thanks for working on this @hunterachieng!

Specifically 8123ebbfc0c2bc617dc0a29bbbfa55f79a2d7155.


fix: remove lifetime from InMemoryCachePermissions

InMemoryCachePermissions::into_cache consumes the calculator, but still holds an unneeded lifetime

I see this is done in multiple places, so it seems like it's the standard, I will close this for now


default fetchPolicy not being applied

The documentation mentions we can set a default fetchPolicy for all requests, except it doesn't seem to work : whatever policy I put in the defaultOptions.$query.fetchPolicy in VueApollo provider is ignored.
After having a closer look to network calls, it seems the 'cache-and-network' policy is applied, whatever default value I pass
However, overriding this default value in components queries works fine, but still I'd like to avoid repeating the fetchPolicy for every query I write and set it globally
Using 3.0.0-beta.11, with the following snippet :
export default new VueApollo({
  defaultClient: new ApolloClient({
    link: ApolloLink.from([
      ...
    ]),
    cache: new InMemoryCache(),
  }),
  defaultOptions: {
    $query: {
      fetchPolicy: 'no-cache',
    },
  },
})

Am I missing something ?
Best regards

Please update to latest release and report back if you still have the issue.

3.0.0-beta.11, which i'm using, is actually the latest release

Latest is beta.13

Aahh sorry, was checking from your github releases instead of NPM
Moving to beta.13 solved the problem, thanks ! :)

Hum npm was not updating, i tried manually both rc.2 and rc.4 but still have the issue, (using vue-cli-plugin-apollo btw)
Doing this make only one query and then no more until i reload the page
// Create vue apollo provider
	const apolloProvider = new VueApollo({
		defaultClient: apolloClient,
		defaultOptions: {
			$query: {
				fetchPolicy: 'no-cache'
			}
		},
		errorHandler(error) {
			console.log('%cError', 'background: red; color: white; padding: 2px 4px; border-radius: 3px; font-weight: bold;', error.message)
		}
	})

doing this correctly remake the query everytime
await apolloClient.query({
		variables: {
			email
		},
		query: gql`
			query($email: String!) {
				createResetCode(email: $email)
			}
		`
	})


Unable to parse URI

I use version 4.13 with PHP 7.2.5 .
I have a project name in the form
"project_id": "example.com:api-project-xxxxxx",
and when I use example
$serviceAccount = ServiceAccount::fromJsonFile(__DIR__.'/../../../config/keys/google-service-account.json');
$firebase = (new Factory())
    ->withServiceAccount($serviceAccount)
    ->create();

I got error
Fatal error: Uncaught InvalidArgumentException: Unable to parse URI: https://example.com:api-project-xxxxxx.firebaseio.com in /export/www/DEVEL/example.com/vendor/guzzlehttp/psr7/src/Uri.php on line 78
What can be? example.com:api-project-xxxxxx is a valid name form for google

I don't understand. I use generated file from the google console panel.  How is it possible that Google generates incorrect data for me? Problem is during parsing JSON. I have very old project, and my project_id is not understandable for your code.
I have databaseUri: https://example.com:api-project-xxx.firebaseio.com and it is correct URI for google but it's not correct for your library and parse_url (PHP). The problem is in sign ":" .
I changed GuzzleHttp\Psr7/Uri for
 public function __construct($uri = '')
    {
        // weak type check to also accept null until we can add scalar type hints
        if ($uri != '') {
            if ($uri == "https://example.com:api-project-xxx.firebaseio.com") {
                $parts[0] = "https";
                $parst[1] = "example.com:api-project-xxx.firebaseio.com";
            } else {
                $parts = parse_url($uri);
                if ($parts === false) {
                    throw new \InvalidArgumentException("Unable to parse URI: $uri");
                }
            }
            $this->applyParts($parts);
        }
    }

and it's work great, but it can't be. I think that not all URI for database is valid with RFC (parse_url), and it's a mistake to valid in this way
    protected function getDatabaseUriFromServiceAccount(ServiceAccount $serviceAccount): UriInterface
    {
        return uri_for(sprintf(self::$databaseUriPattern, $serviceAccount->getProjectId()));
    }

I see that firebase change url to database from:
https://example.com:api-project-xxx.firebaseio.com/
to
https://example-com-api-project-xxx.firebaseio.com/
I think that something like that must be implemented for for project_id in form: example.com:api-project-xxx

The service account JSON file that Google generates is fine. It includes the project ID which can have any form, apperently.
In most projects, the project ID is identical to the subdomain on firebaseio.com, so a project id foo would point to the Firebase Database URI https://foo.firebaseio.com.
That's why the SDK by default uses the project ID from the service account file and uses it for the database URI.
In some project, the project ID is not identical to the subdomain on firebaseio.com, and that's why the ->withDatabaseUri() method exists, so that you can override the value.
If you are sure that you are using the database URI displayed at https://console.firebase.google.com/u/0/project//database//data (after clicking the link, select your project) and the displayed URI indeed is https://example.com:api-project-xxx.firebaseio.com, you should contact them and tell them that this is an error, because this is not a valid URI, which you can check with a cURL command in your terminal:
❯ curl -I "https://example.com:api-project-xxx.firebaseio.com/"
curl: (3) Port number ended with 'a'

The URL you have provided is not a valid URL.

I see that firebase change url to database from:
https://example.com:api-project-xxx.firebaseio.com/
to
https://example-com-api-project-xxx.firebaseio.com/
I think that something like that must be implemented for for project_id in form: example.com:api-project-xxx

This is something you can do when initializing the SDK:
$firebase = (new Factory())
    ->withServiceAccount($serviceAccount)
    ->withDatabaseUri('https://example-com-api-project-xxx.firebaseio.com')
    ->create();

Yep, if I use withDatabaseUri with my URI, then it's work great.
But I think, that library should do this.
anyway, thanks @jeromegamez .

I will try to look for a reliable specification by Google/Firebase - if there is one, I will 👍

Hello again @digitalStyx 😅
If you upgrade to the latest release, you should be able to remove the withDatabaseUri(...) line again :). Cheers!


Move AssetGalleryField API to AssetAdmin

Keeping AssetGalleryField complicates building the admin/assets React UI, since it relies on form schema calls to render the gallery as a form field.
Split out from https://github.com/silverstripe/silverstripe-framework/issues/5711

[x] Use AssetAdmin->getClientConfig() to pass through config values (rather than data attrs on the form field)
[x] Move PHP logic from field to AssetAdmin
[x] Consolidate API calls, remove unused ones (like getFilesBySibling)
[x] Fix search logic
[x] Remove unused legacy code from AssetAdmin (e.g. the duplicate addFolder() call)
[x] Adjust React init to use URLs in AssetAdmin
[x] Remove unused AssetAdmin templates
[x] Move DropzoneUploadField instance into the upload API call (this subclass of UploadField could be removed completely, we might just use the Upload class directly)
[x] Fix documentation
[x] Write tests for createFolder
[x] Write tests for createFile
[x] Fix unit tests

WIP: https://github.com/open-sausages/silverstripe-asset-admin/commits/pulls/4.0/assetadmin-api-refactor

PR at https://github.com/silverstripe/silverstripe-asset-admin/pull/202

I've given this some peer review. I'll let you respond to my feedback. :)

Fixed with https://github.com/silverstripe/silverstripe-asset-admin/pull/202


[1.12.2] Futura Block does not render correctly as facade

Issue Description:
I crafted facades with Chisel's futura block and did not render as he normal block. Two types were invisible. See pictures below

EnderIO: 5.0.33
EnderCore: 1.12.2-0.5.39
Minecraft: 1.12.2
Chisel: 1.12.2-<IP_ADDRESS>
CTM:  MC1.12.2-<IP_ADDRESS>
Forge: 1.12.2 - <IP_ADDRESS>55
SpongeForge? no
Optifine? yes 1.12.2 HD U E2
Single Player

Uh @tterrag

Uh @tterrag1098 ideas?

The first 2 are because you are holding a facade (i think)... holding a facade/conduit/wrench makes all facades invisible..
As for the last one maybe @tterrag1098 could figure it out

The first 2 are because you are holding a facade (i think)... holding a facade/conduit/wrench makes all facades invisible..
As for the last one maybe @tterrag1098 could figure it out

As I applied it to a conduit, the conduit was also insivible. Normally you should be able to see the conduit, if you hold a facade/conduit/wrench.


K3

Hi,
is there already a timeline or plan on supporting K3 with the Ki2?
Thanks so much
Paul!

Hi,
I second the request from @CaesarrrZ - that would be great!
Thank you for this great implementation so far!
Best regards,
g.

+1 here
Sent from my BeOS tablet(forgive any typos)

From: goldenstarshine @.>
Sent: Thursday, May 16, 2024 1:19:46 PM
To: valterc/ki2 @.>
Cc: Subscribed @.***>
Subject: Re: [valterc/ki2] K3 (Issue #220)
Hi,
I second the request from @CaesarrrZhttps://github.com/CaesarrrZ - that would be great!
Thank you for this great implementation so far!
Best regards,
g.
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2115808754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A32AEC2GOTIFHCSTG22BDGDZCTTDFAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHAYDQNZVGQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I installed the apk on a new karoo and works but its imposible to pair with my ultegra

Ditto. Got the current version sideloaded, but it won't find my electronic shifting groupsets produced by a Japanese company. :-)

Same issue as above.  Version 6 sideloaded to the new Karoo just fine, but it cannot find my Shimano Ultegra Di2 when searching.  Super bummed…

Hammerhead needs to activate the SDK on the K3, so I'll wait to buy it, who knows how long that will take.

I saw a post in the Karoo Users FB group from a K3 owner who sideloaded YouTube, Apple Music and Spotify apps.  He claimed all were working great… I’m not a software person, but wouldn’t these need the SDK to be activated if they are operating correctly?
If that’s not the case, maybe everyone on this email should reach out to Hammerhead Customer Support and request the SDK be activated.  I’m new to Di2 and was loving Ki2 on my Karoo 2.  I’m massively disappointed to find this functionality is not (currently) available with my new K3.
Chris Heck
On May 20, 2024, at 5:12 AM, vmpg @.***> wrote:

Hammerhead needs to activate the SDK on the K3, so I'll wait to buy it, who knows how long that will take.
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2120021253, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR57LMZ7MNZPBR6S56LXGYLZDG46BAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGAZDCMRVGM.
You are receiving this because you commented.Message ID: @.***>

Without the sdk the KI2 app does not work, you can start it but the di2 sensors are not found.
Other apps are not affected because they do not interact with the Karoo ride app.

Thanks - that makes sense.  I guess I will reach out to Hammerhead Customer Support and request the SDK be activated, noting that without it, I will return the K3 (I have 30 days) and just keep my K2 since an important piece of functionality I want and expected is not available.  I don’t know if that will do any good, but it’s the truth and worth a try.
Chris
On May 20, 2024, at 10:24 AM, vmpg @.***> wrote:

Without the sdk the KI2 app does not work, you can start it but the di2 sensors are not found.
Other apps are not affected because they do not interact with the Karoo ride app.
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2120569222, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR57LMZDRVPBFQWYPGQBZVDZDIBSZAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGU3DSMRSGI.
You are receiving this because you commented.Message ID: @.***>

BRPaulAm 21.05.2024 um 14:57 schrieb heckcj @.***>:
Ok, I sent support an email yesterday and filled out the form this morning.  So I’ve hit them up twice on this matter.
Chris
On May 21, 2024, at 2:55 AM, FlavourDave @.***> wrote:

Yes, we all have to open a request on this regard to make them move. Go to this pagehttps://support.hammerhead.io/hc/en-us/requests/new and write them a friendly message that the SDK availability is a decisive aspect in the purchase decision.
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2121881939, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR57LMY4GAEM5BZN252JD33ZDLVWBAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRHA4DCOJTHE.
You are receiving this because you commented.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

There now is a thread in the Hammerhead Support forum for this as well, feel free to express your support!

Quick summary to keep everyone up to date:
To make Ki2 work on Karoo 3 we need to do two things:

Update ANT connectivity
Wait for Hammerhead to enable the SDK

We can easily fix the ANT connectivity without any support from Hammerhead - I'm working on this. As for the SDK this needs to be done by Hammerhead. I believe that this is a small fix/change from Hammerhead side. Let's wait a while but keep pressure on their support channels.

ANT connectivity problems will be fixed by #225. This means we can pair/connect to Di2 from Ki2 in Karoo 3 - but without the SDK we cannot add any Ki2 data field to ride profiles or use any other functionality like audio alerts, etc.

Thanks for keeping us updated!  Will there be a new version of Ki2 forthcoming, or does this fix happen "behind the scenes?"
Chris
On May 29, 2024, at 2:06 PM, Valter Costa @.***> wrote:

ANT connectivity problems will be fixed by #225https://github.com/valterc/ki2/pull/225. This means we can pair/connect to Di2 from Ki2 in Karoo 3 - but without the SDK we cannot add any Ki2 data field to ride profiles or use any other functionality like audio alerts, etc.
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2137984240, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR57LM3YBFXUADCCR467U5TZEYKJFAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHE4DIMRUGA.
You are receiving this because you commented.Message ID: @.***>

There's an official response from Hammerhead in the SDK thread where we're asking for an SDK for the last Karoo.

Thanks for keeping us updated! Will there be a new version of Ki2 forthcoming, or does this fix happen "behind the scenes?"

The new Ki2 7.0 release has the new ANT connectivity update, which will support connections to Di2 on Karoo 3.
However because Hammerhead still haven't enabled the SDK, it is not possible to display Ki2 data fields in the ride screen and most Ki2 features (sounds alerts, battery notification, etc.) will not work.

Very cool thanks! Will the control via Di2 buttons work already without the SDK?ThanksPaul Am 17.06.2024 um 13:33 schrieb Valter Costa @.***>:
Thanks for keeping us updated! Will there be a new version of Ki2 forthcoming, or does this fix happen "behind the scenes?"
The new Ki2 7.0 release has the new ANT connectivity update, which will support connections to Di2 on Karoo 3.
However because Hammerhead still haven't enabled the SDK, it is not possible to display Ki2 data fields in the ride screen and most Ki2 features (sounds alerts, battery notification, etc.) will not work.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@valterc thank you for updating Ki2, I was able to sucsssfully connect my 12spd di2. I understand that without SDK most features wouldn’t work.
I was hoping that the overlay screens would work at least, but they do not show-up on the ride or any other screens. Does the overlay screens require SDK support? If not I would love to work with you get that working.

Hi!New update just came out.. SDK added? Nothing mentioned in the release notes..ThanksPaul Am 18.06.2024 um 22:27 schrieb nguyenvo96 @.***>:
@valterc thank you for updating Ki2, I was able to sucsssfully connect my 12spd di2. I understand that without SDK most features wouldn’t work.
I was hoping that the overlay screens would work at least, but they do not show-up on the ride or any other screens. Does the overlay screens require SDK support? If not I would love to work with you get that working.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

It seems (from my exploration) that Hammerhead is developing 'Extensions' support for Karoo 3. I guess they are still developing it so things might change, for the time being it seems that Extensions can create 'sensors' and add elements to the ride screen.
Until they release something officially we'll have to wait (or buy a different unit).

Someone over at karoo.reddit.com contacted Hammeread support asking for an update on the SDK. Support replied that they're working on releasing an SDK, but didn't provide a timeline.
All details here.

Someone over at karoo.reddit.com contacted Hammeread support asking for an update on the SDK. Support replied that they're working on releasing an SDK, but didn't provide a timeline.
All details here.

yes, that someone is me. Jami from HH support responded very kindly. He even followed up with this:

Hi,
I know that several community members are waiting for the SDK! It'll take a little time to develop and prep it for release, but it will definitely open up lots of new potential when developers can create software for the new Karoo.
Don't hesitate to reach out if you need anything else!
Happy Riding,
Jami
Hammerhead

We have some news from HH, extension support is officially available: https://github.com/hammerheadnav/karoo-ext
It appears to be quite complete in terms of features, but I haven't used it yet. It's going to take some time to port Ki2, but looking at the documentation it looks like it will support all Ki2 features.

Great news!  Thanks for letting us know and for taking this on.
Coffee forthcoming….

On Nov 22, 2024, at 3:29 PM, Valter Costa @.***> wrote:
We have some news from HH, extension support is officially available: https://github.com/hammerheadnav/karoo-ext
It appears to be quite complete in terms of features, but I haven't used it yet. It's going to take some time to port Ki2, but looking at the documentation it looks like it will support all Ki2 features.
—
Reply to this email directly, view it on GitHub https://github.com/valterc/ki2/issues/220#issuecomment-2495092362, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKSXUKDBAQ4BRIMBLDMIPL2B6443AVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVGA4TEMZWGI.
You are receiving this because you are subscribed to this thread.

Appears that the extensions have been officially released, https://github.com/hammerheadnav/karoo-ext .

Really hope that's enough to get Ki2 on the new Karoo (it doesn't mention there that it's an SDK)

Same question as posed by dylanbeechey… Hammerhead just released a software update for the Karoo 2 and Karoo (3). According to the release notes, “New Extensions are supported on both the new Karoo and Karoo 2. Previous apps built on the Karoo 2 SDK will not work with the new Extensions SDK.”  Does this mean this update will break Ki2 on a Karoo 2?

@heckcj check out @valterc 's response here: https://github.com/valterc/ki2/issues/253 Looks like K2 should still be good and he's working on K3 🙏🏽🥳

Perfect, and thanks for the follow-up info!
On Nov 27, 2024, at 5:44 PM, dylanbeechey @.***> wrote:

@heckcjhttps://github.com/heckcj check out @valterchttps://github.com/valterc 's response here: #253https://github.com/valterc/ki2/issues/253 Looks like K2 should still be good and he's working on K3 🙏🏽🥳
—
Reply to this email directly, view it on GitHubhttps://github.com/valterc/ki2/issues/220#issuecomment-2504935019, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR57LM63F4LB7VOGRTQD4FL2CZDMZAVCNFSM6AAAAABHY4LNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBUHEZTKMBRHE.
You are receiving this because you were mentioned.Message ID: @.***>

Hey, quick update on the support for Karoo 3. There are some quirks with the Karoo Extensions (the new SDK), that Hammerhead is working to fix, hopefully soon.
Until then, I'm trying to understand the best way to move to extensions. It's likely that Ki2 will lose some functionality:

Will remove some of the button commands, for example the screenshot (is anyone using that anyway?)
The ride overlay will change to a native android overlay - not sure how good it will be
Still unclear if we will have support for storing the gear information in the FIT file
Still unclear if we can have all the existing graphical ride elements

It's going to take a few weeks until we have something good enough to test.

@valterc thanks so much for working on this, and for the update!
I'm sure everyone has their personal preferences, but personally I'd love if I could still a) display what gear I'm in on my K3, and b) use the customizable buttons on my GRX shifters to control things like map zoom on the K3.
...but any integration is better than no integration, and whatever Ki2 ends up looking like I appreciate your efforts!

Thanks so much @valterc ! Getting any type of integration back and being able to see gears would be a win for me. Appreciate what you do!

@valterc Bought you a beer for all your work !!

I sent you another beer. Thank you for your excellent work.

Thanks for the updates @valterc. Bought you coffee. I've never used an github app that works this good. Hope there is an update for K3 too.

hello, is there already a new timeline as to when KI2 will be available on the current Karoo?

Hi everyone, thanks for support, I have some news to share about Ki2.
I have a fully working version for the new Karoo extensions, that version should be compatible with Karoo 3 (I haven't tested).
There are a few notes about this version that I will share for potential feedback from you:

The plan moving forward is to mainly use the native Karoo profile elements, essentially we will add the Di2 as a new device to Karoo and then use the Gears elements from Karoo itself. (FIT recording will be supported)
There are still some bugs/limitation that Hammerhead are working on their end.
The new version of the app will not be backwards compatible. This means anyone using Ki2 will have to re-install the app.

I will soon release an update to Ki2 that will disable future auto-updates for the current version. Likely next week I can release a first version with the Karoo extension and support for Karoo 3.

Awesome Valter! Thanks so much for the hard work on this. Can't wait to start using Ki2 again!

Great news at the end of this year Valter. I am exited to use the app Ki2 back again. Thanks for your outstanding work on this.

Awesome!! Thank you, Valter!

Great job Valter 🙌

great jod ！n thanks @valterc


Envy view defaults to gate view

When I open a saved project, the Envy always defaults to gate view even if I had left it on rubber band/line view. Not a big issue obviously. Rack 0.6.1, OSX 10.13.5

ok thanks.  I think I have seen that before, will look into it for next release.


Add contributors to readme

Auto-generation in the future?

Would be an option, but I think currently manual updates take less effort.


Show package funding links under package metadata

This is not ready for merging yet, but wanted to get some initial feedback on the styling and wording. I'm not a big fan of it saying "accepts" funding. It's very "flat" wording, and I'd like it to be a little more exciting, but not too over the top!

Bear in mind that some packages have a significant number of links:

There's a possibility that the list may look as if it's displaying incorrectly if/when people have two links to the same sponsorship platform but with two different usernames. In that case, it looks like this:

I don't think we should cope with this situation explicitly, we would need to parse out the username and it's such an edge case.

The underlying code is not ready for review yet @finestructure. I accidentally requested the review.

This is now ready for review.
It may seem like overkill to include a dependency like TLDExtract to make the domains a little more palatable in the display, but I think it’s worth it as it really does make the text easier to parse and there is no easy way to strip subdomains without the canonical TDL list. The package is well-maintained and automatically updated, and it’s a small dependency.
Up to date screenshots:


bug: collection-repeat: 2px border between items

Type: bug
Platform: all
collection-repeat (nightly) adds an 2px border between the items.
http://codepen.io/osahner/pen/PwRYgR
does not happen with version 1.0.0-beta.14.

Funny you bring that up, we JUST fixed that in a branch and should be hitting master very soon. It'll be fixed in the next release, thanks.

still an issue. any eta?

Still an issue.


Cowboy worker :killed when server under load

Following this gist: https://gist.github.com/mgwidmann/7162c6da59e027a3f0617575fb147897 but using fib/36 instead of fib/35 as it shows in the script causes the cowboy worker to die.
Heres what the log points out:
01:06:10.177 [error] Ranch listener Hotcode.Endpoint.HTTP had connection process started with :cowboy_protocol:start_link/4 at #PID<0.5429.0> exit with reason: :killed

More information can be found here: https://groups.google.com/forum/#!topic/phoenix-talk/GmbKMPko8kM
This very well may be a cowboy issue.

So from what I've found, my workers are getting sent a brutal_kill message because thats what the generated `relup

Using the following .appup file solves the problem:
{"0.0.2",
 [{"0.0.1",
   [{load_module,'Elixir.Hotcode.Endpoint',brutal_purge,soft_purge,[]},
    {load_module,'Elixir.Hotcode.Fib',brutal_purge,soft_purge,[]},
    {load_module,'Elixir.Hotcode.ErrorHelpers'},
    {load_module,'Elixir.Hotcode.Gettext'},
    {load_module,'Elixir.Hotcode.Repo'},
    {load_module,'Elixir.Hotcode.Router.Helpers'},
    {load_module,'Elixir.Hotcode.Router',brutal_purge,soft_purge,[]}]}],
 [{"0.0.1",
   [{load_module,'Elixir.Hotcode.Endpoint',brutal_purge,soft_purge,[]},
    {load_module,'Elixir.Hotcode.Fib',brutal_purge,soft_purge,[]},
    {load_module,'Elixir.Hotcode.ErrorHelpers'},
    {load_module,'Elixir.Hotcode.Gettext'},
    {load_module,'Elixir.Hotcode.Repo'},
    {load_module,'Elixir.Hotcode.Router.Helpers'},
    {load_module,'Elixir.Hotcode.Router',brutal_purge,soft_purge,[]}]}]}.

Is there any way to know to do this besides testing it out manually like I did? i.e. how can I recognize code that will need soft purging?

@mgwidmann This is one of the caveats of hot upgrades/downgrades with Erlang. The auto generated appups are best effort, but may not always work for all applications. Pre-exrm, appups were written by hand (or people wrote their own appup generators), and in general, doing hot upgrades/downgrades requires intimate knowledge of how your app should be upgraded/downgraded. For most cases, the auto-generated appups exrm produces are good enough, but it will never be able to cover all the edge cases.
However, I can look into whether there is a way I can "smarten" up the appup generator to soft purge based on some critiera. Problem is, I'm not sure what the criteria is specifically. Could you describe in more detail what led you to making that change? That might give me some ideas.

@fishcakez helped me out on slack to get this file working. We mostly toyed around with it, and through trial and error came up with that file. I'm not sure how I would come up with this file on an actual project, which is why I was concerned.
I understand if you don't know how to do this programmatically, maybe it would help if there was more information on writing appup files on the wiki.

@mgwidmann It's not an easy subject but doc exists:
http://erlang.org/doc/man/appup.html
http://erlang.org/doc/design_principles/appup_cookbook.html
http://learnyousomeerlang.com/relups
https://www.metabrew.com/article/erlangotp-releases-rebar-release_handler-appup-etc


.Net Standard / Core Support

Hi there,
thanks for this Package. Is there any Support for .NetStandard in planing? Are there mayor problems?

Yes, I would like to support .NET Standard 2.0.
The library is quite simple, so I guess will be easy add the support.

First of all thanks for the package!
I've played around for a bit, and it seems there is need to create new project that is targeting .NET Standard. You can copy all the files and it works (HelperSharp is minor problem, where you can just replace With extension method).
If you wish I can maybe open pull request with the changes needed?

@hbagarich yes, a pull request would be great!


Simonbray compchem

Thanks!
Can you also merge into the compchem branch? Then the new commits should appear here as well: https://github.com/galaxyproject/training-material/pull/1202

ping @chrisbarnettster

@simonbray  Yes I didn't get those notifications previously....
Will do so.

Hi @chrisbarnettster, could you perform this merge? Keen to get the new tutorial into the training material repo as soon as we can. :)

Hi @simonbray
I've pulled upstream, Fixing up some copyright issues with images and then
will be ready today :)
All the best,
C
On Mon, May 13, 2019 at 10:09 AM Simon Bray<EMAIL_ADDRESS>wrote:

Hi @chrisbarnettster https://github.com/chrisbarnettster, could you
perform this merge? Keen to get the new tutorial into the training material
repo as soon as we can. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chrisbarnettster/training-material/pull/6#issuecomment-491720151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAQWXWGNZ54PXIECMEDC2TPVEO5BANCNFSM4HG6EFDA
.

@simonbray see galaxyproject/training-material/#1378

Thanks!


Time-series Line Chart - Time Grain - does not work if time is not a string

"Time-series Line Chart" can show timeseries where the time column is a bigint, but it fails when trying to set the time grain.
Expected results
It should work.
Actual results
Error: function date_trunc(unknown, bigint) does not exist LINE 1: SELECT DATE_TRUNC('year', year) AS __timestamp, ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts.

Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug

Load default/examples datasets
Go to "Games per Genre over time"
Set the time grain to "Year"
Click "Run"
See the error

Environment
(please complete the following information):
Latest Docker image.
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
date_trunc is used over the time column, which can be a string or can be an integer-like column. "Time grain" fails if the date column is not a string.

This issue is a bit of an antique, and representing a version of Superset that's no longer supported. A LOT of updates have been made to the Timeseries (ECharts) plugin AND how time is handled by both the backend and viz control panels in general. Since this is stale, I'm going to close it, but if anyone is still experiencing similar issues in current-era Superset, we can most certainly re-open this!


Bazel 0.27.0

I commented out the src deps for now. See commit.
bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do. cc @mboes
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @kalbasit @groodt

I commented out the src deps for now. See commit.

I think that's fine given that we had to disable them in Bazel 0.26 anyway. Should we just remove the code, for now, to keep the derivation clean? We can file a separate PR with all of it re-enabled so we have something to start working on?

bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do. cc @mboes

I think that this is fine as well. Last time I spoke to the Bazel team, they informed me that Python 3 is going to become the default Python interpreter for Bazel internals and possibly the default toolchain.

@GrahamcOfBorg build bazel bazel.tests

Shall we close this PR in favor of https://github.com/NixOS/nixpkgs/pull/63532?

bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do.

Sounds fine.

This will be integrated in the other PR.


Effective Date

Hi,
When is the ability to export to Dataverse available in the UK?

Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0371ed0e-974c-5a94-0ba4-f7f1aee43deb
Version Independent ID: 0371ed0e-974c-5a94-0ba4-f7f1aee43deb
Content: Migrate Microsoft Access data to Microsoft Dataverse (contains video) - Power Apps
Content Source: powerapps-docs/maker/data-platform/migrate-access-to-dataverse.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @NHelgren
Microsoft Alias: NHelgren

Thanks for your comment, @SpenCov101. This issue has been assigned to the doc author for review.

As Microsoft stagger their deployments across the globe, it would be good for ALL new feature releases to have (approximate) release dates dependant on geography. We don't all live in Redmond. 😀
Kind Regards

This is live #close


Please update to 1.21

We need this mod to play music on the server. Thank you! XD

This is a purely client side mod, and it is staying that way. Using Open Note Block Studio you can export a song to a datapack, you should try that instead.

This is a purely client side mod, and it is staying that way. Using Open Note Block Studio you can export a song to a datapack, you should try that instead.

It seems that the translation is not very accurate. I think what I meant is to play music for friends on the server. However, I currently use ViaFabric to solve this small problem. Of course, 1.21 will be more convenient. XD