Fix/lw 7153 fix stake keys not part of reward accounts

Context
TxBuilder delegatePortfolio "Internal error: insufficient stake keys" in web-extension context.
Multi-delegation derives new stake keys when needed.
In web-extension context, the new stake keys are reflected in rewardAccounts provider with delay due to keyAgent deriving in UI script and wallet running in background script.
Proposed Solution
wait for new stakeKeys to be reflected in  rewardAccounts

Ready for squashing @mirceahasegan


Fix the issue that Hystrix plugin case NPE

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
#1285

Coverage remained the same at 23.8% when pulling 2522f1c7122c723833226674320153aad191f9c0 on ascrutae:fix/hystrix-npe into 3f7a86f98f8f719f1a6ee44acbc88b9e942a7e97 on apache:master.


The custom operator not supported for group context?

Description
The group context was used for model parallelism of neural network train. The mx.sym.LogisticRegressionOutput works when it's been used for loss calculation, but not customized operator.
Environment info (Required)
OS: Ubuntu 14.04.5 LTS
Python: 2.7.13
mxnet: 0.12.1, pulled from master branch and built from source
Package used (Python/R/Scala/Julia):
Python: mxnet, numpy, scipy
Build info (Required if built from source)
Bulit from command line by following https://mxnet.incubator.apache.org/get_started/install.html
MXNet commit hash:
2f8c1e83f94e84a25a48d2cd43136030fb3f2d1e
Build config:
Only change is to enable the profiler.
Error Message:
Traceback (most recent call last):
File "_ctypes/callbacks.c", line 315, in 'calling callback function'
File "/git/mxnet/python/mxnet/operator.py", line 621, in creator
op_prop = prop_cls(**kwargs)
TypeError: init() got an unexpected keyword argument 'ctx_group'
Minimum reproducible example
The script to generate the network, which works:
...
fc2 = mx.symbol.FullyConnected(data=concat, name='fcout_'+str(gpu), num_hidden=out_dim/num_gpus)
loss = mx.sym.LogisticRegressionOutput(data=fc2, label=labs)
The script to generate the network which used customized operator, and didn't work:
...
fc2 = mx.symbol.FullyConnected(data=concat, name='fcout_'+str(gpu), num_hidden=out_dim/num_gpus)
act2 = mx.sym.Activation(data=fc2, name='acout_'+str(gpu), act_type='sigmoid')
loss = mx.sym.Custom(data=act2, label=label, name='ce_'+str(gpu), op_type='CrossEntropyLoss')
Is this because the custom op is not support yet for group context?

Can you please add the labels - "Operator", "Bug", "Question"

@mg0880gm are you still seeing this issue with the latest version of mxnet ?

Verified on my end that the fix works.


python38Packages.asyncssh: 2.7.1 -> 2.7.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.asyncssh is: "Asynchronous SSHv2 Python client and server library"
meta.homepage for python38Packages.asyncssh is: "https://asyncssh.readthedocs.io/"
meta.changelog for python38Packages.asyncssh is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.7.2 with grep in /nix/store/m0ah0zlkz6k661w0iy3h4j533cl7rsrr-python3.8-asyncssh-2.7.2

found 2.7.2 in filename of file in /nix/store/m0ah0zlkz6k661w0iy3h4j533cl7rsrr-python3.8-asyncssh-2.7.2

directory tree listing: https://gist.github.com/6806d0f4378ea01e9c01721464b80799

du listing: https://gist.github.com/20a154d9690a44ae60d0bece0a6808f6

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
home-assistant
python38Packages.aioasuswrt
python38Packages.asyncssh
python39Packages.aioasuswrt
python39Packages.asyncssh

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m0ah0zlkz6k661w0iy3h4j533cl7rsrr-python3.8-asyncssh-2.7.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.asyncssh https://github.com/r-ryantm/nixpkgs/archive/72da097527aee5be261b238726c820d04d5b8528.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m0ah0zlkz6k661w0iy3h4j533cl7rsrr-python3.8-asyncssh-2.7.2
ls -la /nix/store/m0ah0zlkz6k661w0iy3h4j533cl7rsrr-python3.8-asyncssh-2.7.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

https://github.com/NixOS/nixpkgs/pull/141037/commits

2.7.2 already in master, see https://github.com/NixOS/nixpkgs/commit/f106d8f3ae5d6dfb051b77a2e58c0c9b5aefa03f


Test of full mutlsig credential issuance via agent APIs.

Signed-off-by: pfeairheller<EMAIL_ADDRESS>

Codecov Report

Merging #169 (6f1b9a9) into master (acd9041) will increase coverage by 0.66%.
The diff coverage is 93.42%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   88.74%   89.40%   +0.66%
==========================================
  Files         149      150       +1
  Lines       34261    34452     +191
==========================================
+ Hits        30404    30803     +399
+ Misses       3857     3649     -208

Impacted Files
Coverage Δ

src/keri/core/eventing.py
76.53% <ø> (+0.35%)
:arrow_up:

tests/core/test_witness.py
99.74% <ø> (ø)

src/keri/app/cli/commands/vc/registry/incept.py
36.66% <25.00%> (+0.45%)
:arrow_up:

src/keri/app/kiwiing.py
76.13% <62.50%> (+3.42%)
:arrow_up:

src/keri/vdr/credentialing.py
82.77% <83.33%> (+22.32%)
:arrow_up:

src/keri/app/agenting.py
93.20% <90.90%> (+0.31%)
:arrow_up:

tests/app/test_issue_credential.py
98.12% <98.12%> (ø)

src/keri/app/forwarding.py
86.55% <100.00%> (+0.72%)
:arrow_up:

src/keri/app/grouping.py
83.67% <100.00%> (+2.55%)
:arrow_up:

src/keri/app/indirecting.py
74.69% <100.00%> (+14.10%)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd9041...6f1b9a9. Read the comment docs.


chore: integrate jison into webpack build

Description
Removes the original jison build process into the webpack build for consistency and improved local development.
How to test
run yarn test
1. run yarn test command
2. Wait for results

Success criteria: All tests should pass
run yarn dev
1. run yarn dev command
2. goto a web browser and open up http://localhost:9000/
3. open up browser console to check for errors

Success criteria:

none of the charts should fail to render
browser console shouldn't show any mermaid compile errors.

run yarn build
1. run yarn build command
2. Wait for build to complete

Success criteria: No build errors
run yarn release
1. run yarn release command
2. Open up the dist/index.html and change the mermaid script tag src to ./mermaid.min.js
3. Run yarn dev command (starts the server)
4. goto a web browser and open up http://localhost:9000/
5. open up browser console to check for errors

Success criteria:

none of the charts should fail to render
browser console shouldn't show any mermaid compile errors.

Pull Request Test Coverage Report for Build 876

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.767%

Totals

Change from base Build 871:
0.0%

Covered Lines:
2196

Relevant Lines:
4483

💛  - Coveralls


Pause message are showing in the wrong moment

Pause message shows up when my worked time is the same then my workday hours

This was resolved in #17.


Is there a featrue to limit message len?

Is there a featrue to limit message len? e.g:

No as of now


Installation Errors

Hi,
I am getting many errors while installing the latest version of the package.
Here are the last few lines from the terminal output:

Creating a new generic function for ‘packageName’ in package ‘AnnotationDbi’
Creating a generic function for ‘ls’ from package ‘base’ in package ‘AnnotationDbi’
Creating a generic function for ‘eapply’ from package ‘base’ in package ‘AnnotationDbi’
Creating a generic function for ‘exists’ from package ‘base’ in package ‘AnnotationDbi’
Creating a generic function for ‘sample’ from package ‘base’ in package ‘AnnotationDbi’
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (AnnotationDbi)
ERROR: dependency ‘XML’ is not available for package ‘biomaRt’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/biomaRt’
ERROR: dependencies ‘XML’, ‘restfulr’ are not available for package ‘rtracklayer’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/rtracklayer’
ERROR: dependencies ‘rtracklayer’, ‘biomaRt’ are not available for package ‘GenomicFeatures’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/GenomicFeatures’
ERROR: dependency ‘rtracklayer’ is not available for package ‘BSgenome’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/BSgenome’
ERROR: dependencies ‘rtracklayer’, ‘BSgenome’, ‘GenomicFeatures’ are not available for package ‘VariantAnnotation’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/VariantAnnotation’
ERROR: dependencies ‘BSgenome’, ‘VariantAnnotation’, ‘rtracklayer’ are not available for package ‘MungeSumstats’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/MungeSumstats’

The downloaded source packages are in
        ‘/tmp/RtmpQE2e9e/downloaded_packages’
Downloading GitHub repo RajLabMSSM/echoconda@HEAD
Skipping echoconda, it is already being installed
Downloading GitHub repo RajLabMSSM/downloadR@HEAD
Skipping downloadR, it is already being installed
Downloading GitHub repo RajLabMSSM/echodata@HEAD
Skipping echodata, it is already being installed
Downloading GitHub repo RajLabMSSM/echotabix@HEAD
Skipping echotabix, it is already being installed
Downloading GitHub repo RajLabMSSM/echoannot@HEAD
Skipping echoannot, it is already being installed
Downloading GitHub repo RajLabMSSM/catalogueR@HEAD
Skipping catalogueR, it is already being installed
Downloading GitHub repo RajLabMSSM/echoLD@HEAD
Skipping echoLD, it is already being installed
Downloading GitHub repo RajLabMSSM/echofinemap@HEAD
Skipping echofinemap, it is already being installed
Downloading GitHub repo RajLabMSSM/echoplot@HEAD
Skipping echoplot, it is already being installed
Skipping install of 'echodeps' from a github remote, the SHA1 (2a0ccae6) has not changed since last install.
  Use `force = TRUE` to force installation
Running `R CMD build`...
* checking for file ‘/tmp/RtmpQE2e9e/remotes36a274e7d28fd/RajLabMSSM-echolocatoR-b8dd387/DESCRIPTION’ ... OK
* preparing ‘echolocatoR’:
* checking DESCRIPTION meta-information ... OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
Omitted ‘LazyData’ from DESCRIPTION
* building ‘echolocatoR_2.0.1.tar.gz’
ERROR: dependencies ‘echoconda’, ‘downloadR’, ‘echodata’, ‘echotabix’, ‘echoannot’, ‘catalogueR’, ‘echoLD’, ‘echofinemap’, ‘echoplot’ are not available for package ‘echolocatoR’
* removing ‘/autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/R/library/echolocatoR’

Based on the warning messages, it seems these packages failed to install:
Warning messages:
1: In i.p(...) : installation of package ‘XML’ had non-zero exit status
2: In i.p(...) : installation of package ‘restfulr’ had non-zero exit status
3: In i.p(...) : installation of package ‘biomaRt’ had non-zero exit status
4: In i.p(...) : installation of package ‘rtracklayer’ had non-zero exit status
5: In i.p(...) :
  installation of package ‘GenomicFeatures’ had non-zero exit status
6: In i.p(...) : installation of package ‘BSgenome’ had non-zero exit status
7: In i.p(...) :
  installation of package ‘VariantAnnotation’ had non-zero exit status
8: In i.p(...) : installation of package ‘MungeSumstats’ had non-zero exit status
9: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a27563b38e4/echodata_0.99.14.tar.gz’ had non-zero exit status
10: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a275ca1bb7f/echoconda_0.99.7.tar.gz’ had non-zero exit status
11: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a276594f92/downloadR_0.99.4.tar.gz’ had non-zero exit status
12: In i.p(...) : installation of package ‘XML’ had non-zero exit status
13: In i.p(...) : installation of package ‘restfulr’ had non-zero exit status
14: In i.p(...) : installation of package ‘biomaRt’ had non-zero exit status
15: In i.p(...) : installation of package ‘rtracklayer’ had non-zero exit status
16: In i.p(...) :
  installation of package ‘GenomicFeatures’ had non-zero exit status
17: In i.p(...) : installation of package ‘BSgenome’ had non-zero exit status
18: In i.p(...) :
  installation of package ‘VariantAnnotation’ had non-zero exit status
19: In i.p(...) :
  installation of package ‘MungeSumstats’ had non-zero exit status
20: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a272f10389b/echotabix_0.99.8.tar.gz’ had non-zero exit status
21: In i.p(...) : installation of package ‘XML’ had non-zero exit status
22: In i.p(...) : installation of package ‘restfulr’ had non-zero exit status
23: In i.p(...) : installation of package ‘biomaRt’ had non-zero exit status
24: In i.p(...) : installation of package ‘rtracklayer’ had non-zero exit status
25: In i.p(...) :
  installation of package ‘GenomicFeatures’ had non-zero exit status
26: In i.p(...) : installation of package ‘BSgenome’ had non-zero exit status
27: In i.p(...) : installation of package ‘ensembldb’ had non-zero exit status
28: In i.p(...) :
  installation of package ‘VariantAnnotation’ had non-zero exit status
29: In i.p(...) : installation of package ‘OrganismDbi’ had non-zero exit status
30: In i.p(...) : installation of package ‘biovizBase’ had non-zero exit status
31: In i.p(...) : installation of package ‘ggbio’ had non-zero exit status
32: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a2751ed251c/echoannot_0.99.7.tar.gz’ had non-zero exit status
33: In i.p(...) : installation of package ‘XML’ had non-zero exit status
34: In i.p(...) : installation of package ‘restfulr’ had non-zero exit status
35: In i.p(...) : installation of package ‘biomaRt’ had non-zero exit status
36: In i.p(...) : installation of package ‘rtracklayer’ had non-zero exit status
37: In i.p(...) :
  installation of package ‘GenomicFeatures’ had non-zero exit status
38: In i.p(...) : installation of package ‘ensembldb’ had non-zero exit status
39: In i.p(...) :
  installation of package ‘EnsDb.Hsapiens.v75’ had non-zero exit status
40: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a274c1cba21/catalogueR_1.0.0.tar.gz’ had non-zero exit status
41: In i.p(...) : installation of package ‘XML’ had non-zero exit status
42: In i.p(...) : installation of package ‘restfulr’ had non-zero exit status
43: In i.p(...) : installation of package ‘biomaRt’ had non-zero exit status
44: In i.p(...) : installation of package ‘rtracklayer’ had non-zero exit status
45: In i.p(...) :
  installation of package ‘GenomicFeatures’ had non-zero exit status
46: In i.p(...) : installation of package ‘BSgenome’ had non-zero exit status
47: In i.p(...) :
  installation of package ‘VariantAnnotation’ had non-zero exit status
48: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a272f247bf/echoLD_0.99.7.tar.gz’ had non-zero exit status
49: In i.p(...) :
  installation of package ‘/tmp/RtmpQE2e9e/file36a2744704520/echofinemap_0.99.3.tar.gz’ had non-zero exit status
50: In i.p(...) : installation of package ‘XML’ had non-zero exit status

Session info
R version 4.1.3 (2022-03-10)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: Red Hat Enterprise Linux 8.6 (Ootpa)

Matrix products: default
BLAS/LAPACK: /autofs/nccs-svm1_home1/anuragv/.conda/envs/echoverse/lib/libopenblasp-r0.3.21.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] remotes_2.4.2

loaded via a namespace (and not attached):
[1] compiler_4.1.3 tools_4.1.3    curl_4.3.2

Thank you!

After some more troubleshooting, I found the issue was with the missing libxml library. After installing the library (conda install r-xml), echolocatoR installation finished successfully!

Ah yes, XML is a tricky R dep to install on some machines. I'll add a note about this in the troubleshooting section of the README.
Thanks for reporting this!

Done!
https://github.com/RajLabMSSM/echolocatoR#installation-troubleshooting


feat: basic validation of CAR files

Summary of changes

Changes introduced in this pull request:

add forest-tool car validate command.

This new command verifies the invariants expected to be true for all CAR files (not just Filecoin CAR files).
Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

We could also cover the case where we ignore the block validity and the Forest index. All in all, a user could do this. (not sure why, though)

Done.


events useCapture

The EventTarget.addEventListener(type, listener[, useCapture]) let’s us specify if we want to initiate capture.
But it does not seem as Rx.Observable.fromEvent(element, eventName[, selector]), as used here in render-dom.js, supports setting the useCapture flag. This is, in Web development, a quite important feature to be able access, for example when focus, blur and change events don’t bubble.

Can you suggest this change on RxJS? I would build this on Cycle side only if it does not happen in RxJS.

Yes, I can do that. I found this this https://github.com/Reactive-Extensions/RxJS-DOM/blob/master/doc/operators/fromevent.md

Open issue https://github.com/Reactive-Extensions/RxJS/issues/897

I got this answer.

use RxJS-DOM for useCapture as it makes more sense there with Rx.DOM.fromEvent. Since Rx.Observable.fromEvent is such a flexible event converter, useCapture is only used in one code path as it isn't required for Node.js, Angular, jQuery, etc.


Frame Export Jpg - not supported exception

If you want to save the frames as single images, this only works if you activate the option "zip the image".

If you do not select this option you will get an error message

Thank you for the feedback.


[max] ignored [uploadedFiles]

[max] ignored [uploadedFiles]="images"...
if i have in uploadedFiles images=['path'] and max=1
I can upload another image

see https://github.com/aberezkin/ng2-image-upload/issues/162


Related Posts

Could we do a simple implementation of "related posts"?
A basic idea could be loading more posts from the category of the active post
They could be added at the bottom of the page. More from [category]

hey @colbyfayock I was thinking on this one and I think I have an implementation. Not sure if you are already working on it... if not, happy to send a PR 😃
Looks like this:

hey @colbyfayock I was thinking on this one and I think I have an implementation. Not sure if you are already working on it... if not, happy to send a PR 😃
Looks like this:

that looks good to me! maybe a little extra spacing above the header to separate it similar to the "last updated" line from the original content
but yeah, go ahead with a PR!

that looks good to me! maybe a little extra spacing above the header to separate it similar to the "last updated" line from the original content
but yeah, go ahead with a PR!

Perfect! Making that change, and sending the PR 💪

Perfect! Making that change, and sending the PR 💪


Fix documentation CI

Closes https://github.com/paris-saclay-cds/ramp-board/issues/525
Supersedes and closes https://github.com/paris-saclay-cds/ramp-board/pull/528

I'm not sure the Python version is the problem - it builds fine locally. Was going to check if moving packages to install via conda instead of pip would help.

I think it might be also the sphinx 4.0 release that was made last week breaking things.


[Device Support Request] ROBB smarrt ROB_200-008-0

Is your feature request related to a problem? Please describe.
Adding the ROBB smarrt ROB_200-008-0 switch works, but no entities are created. This switch is a whitelabel version of another brand (not sure but probably Sunricher SR-ZG9001K4-DIM2).
Describe the solution you'd like
Would be massive if it could be added :)
**Device signature - this can be acquired by removing the device from ZHA and pairing it again from the add devices screen. {
"node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4644, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
"endpoints": {
"1": {
"profile_id": 260,
"device_type": "0x0001",
"in_clusters": [
"0x0000",
"0x0001",
"0x0003",
"0x0b05"
],
"out_clusters": [
"0x0003",
"0x0004",
"0x0005",
"0x0006",
"0x0008",
"0x0019",
"0x0300",
"0x1000"
]
},
"2": {
"profile_id": 260,
"device_type": "0x0001",
"in_clusters": [
"0x0000",
"0x0001",
"0x0003",
"0x0b05"
],
"out_clusters": [
"0x0003",
"0x0004",
"0x0005",
"0x0006",
"0x0008",
"0x0019",
"0x0300",
"0x1000"
]
}
},
"manufacturer": "ROBB smarrt",
"model": "ROB_200-008-0",
"class": "zigpy.device.Device"
}
Thanks!

Its one dual dimmer switch / remote that looks very Zigbee and Z2M is only exposing the zigbee commands for getting entries and battery and no magic converters.
Is you getting events form the switch the listening to events in HA ?
Developer Tools > EVENTS and putting zha_event in "Events to subscribe to" and kicking "start listen".

Hi Matt,
Yes! I'm seeing the events:
Event 3 fired 20:00: {     "event_type": "zha_event",     "data": {         "device_ieee": "bc:33:ac:ff:fe:6f:ad:ad",         "unique_id": "bc:33:ac:ff:fe:6f:ad:ad:2:0x0006",         "device_id": "367928266b5700330c1a2bfbb0c36895",         "endpoint_id": 2,         "cluster_id": 6,         "command": "off",         "args": []     },     "origin": "LOCAL",     "time_fired": "2021-09-01T18:00:54.948382+00:00",     "context": {         "id": "74cd48c6d502a04c4d2f251e4869db9c",         "parent_id": null,         "user_id": null     } }

That great !!
Z2M is hocking on, off, move_with_on_off and stop_with_on_off. for both dimmer "sides".
You can using them in automatons as triggers with events (not device) but you need using more or less all information from the event for getting it working and using endpoint 1 and 2 for getting the right commands from left and right keys. The dimmer commands is very likely long press and release.


Move logic to delete a storage service into a Celery task

The logic currently in the delete_storage_service view (in the Aggregator Blueprint) should be moved into a Celery task to avoid possible timeouts, etc.

Fix is merged.


[FLINK-17230] Fix incorrect returned address of Endpoint for external Service of ClusterIP type

What is the purpose of the change
At the moment, when external Service is set to ClusterIP, we return ${internal-service-name} + "." + nameSpace as the address of the Endpoint, which could be problematic since we don't create the internal service in ZooKeeper based HA setups.  According to FLINK-16602, we always use external Service for rest communication so that this PR returns ${external-service-name} + "." + nameSpace as Endpoint's address instead.
Brief change log

Fix incorrect returned address of Endpoint for the external Service of ClusterIP type
Port KubernetesUtils.getInternalServiceName to InternalServiceDecorator
Port KubernetesUtils.getExternalServiceName to ExternalServiceDecorator
Fix code style

Verifying this change
This change hardens Fabric8FlinkKubeClientTest#testClusterIPService to add a test branch for Endpoint's address.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @TisonKun. Could you help take a look?


Shutdown delay

Every time i run process hacker. If I want to shutdown computer, I need to wait 3-5 minutes for shutdown computer. how to fix it?

Why would it be Process Hacker causing the delay?

Why would it be Process Hacker causing the delay?
It happened after I used this program. I find that some people have the same problem as me.
https://wj32.org/processhacker/forums/viewtopic.php?t=3408

It happened after I used this program

Process Hacker does nothing on shutdown, never has and never will. It also does not even know when you shutdown the machine... GUI processes also cannot ever delay shutdown since Windows forcefully terminates the application after 20 seconds using the "WaitToKillAppTimeout" registry value.
So knowing PH does absolutely nothing on shutdown and would be forcefully terminated anyway... Why would it be Process Hacker causing the delay?

I find that some people have the same problem as me.

I'll ask the same question which nobody answered... What security software do you have installed?
You should also check your event log which will identify the program delaying shutdown:
https://www.thewindowsclub.com/identify-windows-services-delaying-shutdown-startup

@plan291037
Did you find out what was causing it? It would be good to know what it was for future reference.

@plan291037
Did you find out what was causing it? It would be good to know what it was for future reference.
I'm not sure what system this is. I just turn off the default programs that I don't use.

So knowing PH does absolutely nothing on shutdown and would be forcefully terminated anyway... Why would it be Process Hacker causing the delay?

I have encountered this issue too including on a fresh machine. I uninstalled Process Hacker and it solved it. That would tend to indicate that at least in some conditions, it can cause it. But at the time, I didn’t know about those means of investigation that you mentioned. I might give them a try in some near future, thanks.
When the problem occurs, I also cannot start any program that requires administrator privileges. consent.exe pops up in the list of processes but the UAC prompt never does, so consent.exe just gets stuck. (And so does Process Hacker if it was the one spawning it.)

I reinstalled Process Hacker yesterday and the issue reoccurred after two months without problem and without Process Hacker, which establishes rather conclusively that Process Hacker is, if not a sufficient cause, at least a necessary one.
Unfortunately, the two diagnostic methods mentioned above don’t seem to be of much help here. The verbose status messages seem to only appear with the fullscreen spinning dots, but when the shutdown problem occurs, the system does not even reach that point — the session is not closed. One can still open programs (except those that require going through the UAC, as I mentioned) and interact with them. It’s just that after a few minutes, Windows suddenly “wakes up”, closes everything and shuts down, but once it starts doing that, it’s very fast at it.
Perhaps for that reason, the event log doesn’t seem to contain anything related to that either.
Possibly relevant is that I only remember the problem occurring with “hybrid shutdown” (“Fast startup” enabled), i.e. neither reboots nor manual invocations of shutdown /s /t 0.

I have encountered the similar issue with v2.39 r124 on a newly installed Windows 10 21H2.
If I replace Task Manager with PH, it takes quite a long time to shutdown. Something is also not normal with the following boot up. It appears to be not a normal shutdown but I cannot tell more and it may be platform specific.
After switching it back, it seems fine to shutdown normally.
I tend to think there may be some problems with the replacement functionality, or maybe other things, given that some people have faced similar issues. Average users are not knowledgeable enough to provide more diagnostic information. It may not be reproducible on every machine but it would be great if developers can dig into it.

establishes rather conclusively that Process Hacker is, if not a sufficient cause, at least a necessary one.

The problem is that Process Hacker does literally nothing on shutdown and does not change any windows settings... So there's nothing anyone can change or review or investigate and figure out why shutdown isn't working... If Process Hacker did something, anything before or during shutdown like save a database then that would be something we could look into.
But PH literally doesn't do anything before/during shutdown that can interfere with shutdown or block shutdown... It could only be some third party software scanning for PH and causing this because otherwise it makes zero sense.

if your accout not administrator, try this: cancel the "run as  administrator"


Textures are appearing darker in 2d vs 3d

Godot version
3.3.2(stable)
System information
windows 10, gles3
Issue description
Images are appearing with correct color in 3d space, but in 2d space on the ui, the icons are showing up much darker. I am using the default 2d pixel import options for each icon. I've tried changing every setting, and none of them seem to fix the color of the icon. I must be doing something wrong and there's no way that it is my import settings are wrong.
I am using the same texture for the sprite3d and the sprite2d. I read that there is a possibility that the texture is getting reimported on the fly to 3d import settings instead of 2d pixel settings like I want.
Steps to reproduce

Use the same png as a texture and then put that texture icon on the hud as a sprite 2d and then put that same texture as a sprite3d in the 3d space.
Minimal reproduction project
No response

MRP here
sprite 2d and 3d.zip
GLES3 screenshot

GLES2 screenshot

@KuamyWilbanks please attach Minimal reproduction project next time

MRP here
sprite 2d and 3d.zip
GLES3 screenshot

GLES2 screenshot

@KuamyWilbanks please attach Minimal reproduction project next time

Thank you very much, will do! Also, your screenshots are much better at presenting the issue.

That's normal, one texture is in linear color space and one is using sRGB. Which one is used depends on where the texture is used, see https://docs.godotengine.org/en/stable/getting_started/workflow/assets/importing_images.html#srgb and https://docs.godotengine.org/en/stable/tutorials/misc/gles2_gles3_differences.html#color-space

Duplicate of https://github.com/godotengine/godot/issues/18941 (fixed in master).


File Manager: Download Folder feature (all files in folder and it's subfolder)

Hi
A nice feature that should be easy to implement is to allow downloading of a folder. Or more presiscly, to recursively download all files in the folder and sub-folders.
I suggest that when you select a folder and click download, that a pop-up appear asking if you really want to download all files in that folder. Maybe there should be an option to "download files in sub-folders", or just the files in the selected folder.
PS. I will try implement this myself. Maybe sometime this weekend.

Good suggestion. A menu box with the following choices:

Download folder and (item count) files.
Download all files only (item count).
Download folder only.

Added it to the list #262.

Hello there,
is someone on this Task?
I am currently redesign the File-Manager, when its done it would look like FileZilla FTP Client. ;-)
Functionality Planned:

Download / Upload Folders
Delete Folders its and content
Resume Download / Upload


CRITICAL: [Actionable Whispers] Changes when categorizing / sharing a tracked expense are not saved

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Note: This occurs as part of a feature from this PR
Break down in numbered steps

Create a workspace
Create a tracked expense
Choose to categorize it
Update the transaction details in the final confirmation page

Expected Result:
The new shared/categorized transaction details should be saved
Actual Result:
They are not
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015eae82d8e6ef3565
Upwork Job ID:<PHONE_NUMBER>653587968
Last Price Increase: 2024-04-16

This is something that will need to be fixed in the BE

Changes are merged- pending deploy

Just tested and this looks like the tracked expense info is being saved.

Noice!


the debugger starts with nothing happening

hello, I've been trying to use VSCode to write and debug java. However after I set up the configuration and click the debug button, nothing happened.
Here are pictures about the problem. The first one shows my configuration and the second one shows the state after I clicked the debug button. Please ignore the folder named "1".

Even if I change the startup class into a non-exist class the debugger still remains the same and throw no error. Any body can help me? Lots of thanks!

I have the same question, please！how do you fix it?

+1 same problem.

Sometimes this happens, I just stop the debugger and run again.

+1 same problem
beg for someone!!!!!!!Could you help me!!!!??!?!?!??!

@gylidian this eventually happens, just try to reload your editor and debug again.
The mine is working as expected.

@faustinoaq
my vscode can only run,but cannot debug
after reload,nothing changed.

Your launch.json looks good, I don't know what could be the problem :sweat_smile:

@faustinoaq
Thank you all the same!  ~~😸

your jdk language is not english

I have the same problem, don't know why

Yeah, It is a known issue.
I don't know what why it happens. Also is a bug hard to reproduce.

your jdk language is not english

Maybe you can try a machine completely in English :sweat_smile:

@faustinoaq
Hi, faustinoaq , I have encountered this issue too. After days of searching in github.com |  visualstudio.com | stackoverflow.com  , and  now  ...... I hate this issue ......
If you would, please give a intelij OR eclipse simple HelloWorld sample, which have project structure and vs code settings(settings.json  tasks.json   launch.json ),  thank you very much

I recommend you Intellij or Eclipse because they are more friendly and work out the box. :sweat_smile:
VSCode is a bit messy, because you need to figureout about bugs, misconfigurations, enviroments, etc. So I'm able to debug using this plugin, but it sometimes doesn't fit my requirements.
VSCode is better for JavaScript/Typescript, and other languages without an IDE. However Java is widely supported by almost every good IDE (Intellijj, Eclipse, Netbeans, etc).

@faustinoaq
Yes, you are right. I just want to edit all of languages in one place, and open too much window is so complex. But finally, Intelij or eclipse is better. Also vs code can edit python, but when I want to develop program nor script, I will use pyCharm. (what I said just looks like a jet brain's Ad,  ^_^ )

@faustinoaq I have tried for several times, but nothing changed

And I found an error in the output window:

Currenlty I'm able to debug using the latest version of this extension:

I don't know what would be happening with you configuration :sweat_smile:

I'm using the default configuration

@faustinoaq I set the launch.json same as yours, but still failed. the stepin stepout button I never have seen them become clickable. and the first green button, it always grey or a blue pause icon.

@LimnN I don't know what would be happening, but If VSCode don't work for you, try Intellij Idea or Eclipse because they have better support for java debugging out-the-box :sweat_smile:


[Bug Report] video streaming with rtsp not working

Hi, I,m working with IP camera and get video streaming through RTSP url using media_kit library but get no response and error.
It appears on console.
Intel(R) HD Graphics 5500
media_kit: ANGLESurfaceManager: Direct3D Feature Level: 11_0
1 1
media_kit: VideoOutput: Create Texture:<PHONE_NUMBER>456
media_kit: VideoOutput: Using H/W rendering.
1920 1080
media_kit: VideoOutput: Free Texture:<PHONE_NUMBER>456
media_kit: ANGLESurfaceManager: Direct3D Feature Level: 11_0
media_kit: VideoOutput: Create Texture:<PHONE_NUMBER>472
flutter: VideoOutput.Resize
flutter: {handle:<PHONE_NUMBER>344, id:<PHONE_NUMBER>456, rect: {height: 1080, left: 0, top: 0, width: 1920}}
flutter: VideoController: Texture ID:<PHONE_NUMBER>456
flutter: VideoOutput.Resize
flutter: {handle:<PHONE_NUMBER>344, id:<PHONE_NUMBER>472, rect: {height: 1080, left: 0, top: 0, width: 1920}}

Not enough details for me to say anything.

https://github.com/bluecherrydvr/unity uses package:media_kit for playback of RTSP streams.
Something is wrong on your end; not mine.

Have you solved your problem yet? Please list the code so I can look at it


[[FIX]] Allow RegExp literal as yield operand

Extend the lexer to recognize RegExp literals which immediately follow
the yield operator.

Coverage decreased (-0.07%) to 97.645% when pulling 05f5a7e6a556913038c1022cff253ba3d6f99a26 on jugglinmike:gh-2956-yield-regexp into ae9ae5b24aecab2d0f5f60953bb155560673cbf5 on jshint:master.

Coverage decreased (-0.07%) to 97.645% when pulling 05f5a7e6a556913038c1022cff253ba3d6f99a26 on jugglinmike:gh-2956-yield-regexp into ae9ae5b24aecab2d0f5f60953bb155560673cbf5 on jshint:master.

Nice work!


Adds code coverage report via Coveralls

NB: requires setting env variable COVERALLS_REPO_TOKEN in codeship

See code coverage in Coveralls here: https://coveralls.io/github/antleaf/nims-hyrax?branch=develop

one of the builds passed, at least


Add Feedback button

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

in navar/ or in footer
so people can rate and interact
Use Case
assign this to me under gssoc ext and hacktoberfest
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Trisha-tech @Suman373 Please assign this issue under gssoc extended and hacktoberfest and give me appropriate level


Using datatables search property in the column

First of all: Great project!
There is a problem though: Datatables has a key "search" for each column, where one can specify a search term for this column:

In the doc it is here: https://datatables.net/manual/server-side

The plan is to use it with this example: https://datatables.net/examples/api/multi_filter_select.html
The problem now is: This lib uses a "key:value" syntax from the global search.
I could hack around it by adding the "key:value" kind of search into the global search box, but I think it would be better to use this feature of datatables.
I could do a pull request, but wanted to ask first: What was the reasoning behind doing it this way? And how could we add this feature without making the API to complicated, since just adding it on top might become confusing due to merging the searches etc..

Hi @reinoldus, thanks for the Issue and for drawing my attention to DataTables' own column search feature.  To answer your question--I didn't support this column searching feature because I wasn't aware of it, unfortunately!  That said, I like my key:value solution from the global search--it works well for my use case--but we should be able to support this column search feature too.
My global search is always a case insensitive regex search in Mongo (another quirk that some may not prefer). Incorporating DT's column search, also as a case insensitive regex, might be pretty straightforward:
Possibly:
    def dt_column_search(self):
        return ["{}:{}".format(column["data"], column["search"]["value"]) for column in self.request_args.get("columns")]

And then...
    def search_specific_key(self):
        """Search specific keys (columns) like 'key:value'.

        :return:
        """
        _col_specific_search = {}
        for term in self.search_terms_with_a_colon + self.dt_column_search:
            col, term = term.split(':')
            _col_specific_search.update({col: {'$regex': term, '$options': 'i'}})

        return _col_specific_search

I haven't tested this, but it should support the global key:value solution as well as the DT's column search.
The harder part of course is honoring the regex: true/false setting on a per column basis, which I've ignored with the above implementation.
Do you have another solution that doesn't break anything else?  I'm happy to look at a pull request.

added in v0.3.0 with thanks to @reinoldus


Add support to transpile modules inside node_modules

Take a look at https://github.com/zeit/next.js/issues/706 .
I think it is necassary. Last time I tested, nuxtjs does transpile it in development mode. But not in production.

This feature request is available on Nuxt.js community (#c878)

Hey @muhajirframe. Thanks for reference, we will keep track of comments and adding if actually needed. However i've not seen any popular library exporting not transpiled version. For tree shaking and advanced optimization, modules should create special esm builds, like bootstrap-vue or vue.js. Also if it is necessary for one special package as of https://github.com/zeit/next.js/issues/706#issuecomment-289118600 mentioned, we can do similar thing with nuxt.config.js using build.extend (However It may cause uglifyjs problems too as it currently not supports esm modules and this is probably why prod builds are failing)

From #1080 @icx960324:

Hello.
It seems that babel-loader will skip transforming files in node_modules.
use the traditional way to config babel but it did't work.

    loaders: [
      {
        test: /iview.src.*js$/,
        use: {
          loader: 'babel-loader',
          options: {
            presets: ['es2015'],
            plugins: ['transform-runtime']
          }
        }
      },
//   below are default nuxt loaders config.

So I wonder is there any way to let babel transform files in node_modules.
Thank you. XD

See https://github.com/ccxt-dev/ccxt/issues/225#issuecomment-331594281 (a solution that adds a Babel rule for transpiling a specific ES6 module in node_modules). You can also remove the general /node_modules/ exclusion that way (by monkey-patching the config.module.rules object).

To add some keywords for those googling: we had an issue with fat arrows not transpiled and failing in IE11. To find out what was causing it I just searched for => over .nuxt/dist folder. It appeared to be coming from latest query-string module written in ES6.
One solution would be to transpile it as stated above, we've just downgraded the module to v5 (which is plain ES5).

We may ship https://github.com/AndersDJohnson/webpack-babel-env-deps into nuxt to support transition node_modules. Working with @Atinux on it :)

@pi0 any updates on including https://github.com/AndersDJohnson/webpack-babel-env-deps into nuxt?

I'm also interested by this feature, I can use transpileDependencies in vue.config.js with the default template from vue-cli. doc here https://cli.vuejs.org/config/#transpiledependencies
I'm trying to import this plugin: https://github.com/alessiomaffeis/vue-picture-input

For all Googlers: https://nuxtjs.org/api/configuration-build/#transpile


Construct a Parser object

As a developer I would like yo construct an Object that will abstract the internal workings of parsing a CSV File.
Requirements

The constructor requires a string as it's first parameter representing the path to a file.
The constructor optionally accepts a second parameter representing the delimiter for values. If no value is specified the delimiter should default to a comma.
The constructor optionally accepts a third argument, an array of strings that defines the header columns.
A type of CSVParser\Parser is returned on successful construction of the object.
An Exception should be thrown when the file path specified points to a file that does not exist.
Valid delimiters should be limited to commas, pipes '|' or tab '\t' characters

Interface
Example 1
$parser = new CSVParser\Parser('/tmp/sample.csv');

Example 2
$parser = new CSVParser('/tmp/sample.csv', '|');

Example 3
$parser = new CSVParser\Parser('/tmp/sample.csv', '|', ['col_1', 'col_2']);

This this asking for the constructor to be able to take in 3 different possible options?  Similar to the idea of overloading in other languages?

Correct. PHP does not support method overloading though so you will need to look into default parameters.

This issue has been completed.


Historical versions, change names to have an official on-chain name

In #521 , we changed the schema to make names a list.
A bit annoying, is that in the cosmos SDK there is a notion of "official upgrade name", which you need for configuring cosmovisor.
I think we should we switch to:

code_upgrade_name
display_upgrade_name (optional)
(Or something to this extent)

Maybe let's just give chain upgrades a single name, not a list of names.

That SGTM


Issue with an idicator which contains an ipv4-addr and email-addr property.

I found that an indicator which contains "ipv4-addr" pattern strings was skipped to slide.
            "pattern": "[ipv4-addr:value = '<IP_ADDRESS>']",

I checked sources, and it seems that there is something wrong in stix2slider/convert_pattrn.py
Line 143:
    def toSTIX1x(self, id2x, existing_obj=None):
        if not existing_obj:
            cyboxClassConstructor = map_extensions_to_cybox_class(self.determine_expression_type())
            existing_obj = cyboxClassConstructor()

map_extensions_to_cybox_class returns cybox.objects.address_object.Address.
However, cyboxClassConstror() returns None.
I think that an Address Constructor shuld call with an indicator value like this.
# return None
obj_ = Address()
# return some instance
obj_ = Address('<IP_ADDRESS>')

I have also failed to slide if a pattern string contains email-addr:value.
"pattern": "[email-addr:value =<EMAIL_ADDRESS>
I guess that we should append a "email-addr" : EmailAddress element in _CYBOX_OBJECT_MAP.
Thanks!

@stmtstk - good catch - email-addr was missing from _CYBOX_OBJECT_MAP.
I tested it with this pattern:

"pattern": "[ipv4-addr:value = '<IP_ADDRESS>'] AND [email-addr:value =<EMAIL_ADDRESS>
However, I didn't see any issues with the pattern:

"pattern": "[ipv4-addr:value = '<IP_ADDRESS>']

Can you send me the STIX 2.1 file that was causing that problem.

@rpiazza
Thank you for your kind replay.
I tried to slide an indicator with ipv4-addr again and I confirmed that ipv4-addr was converted to STIX 1.x successfully.
It seems that I missed the ipv4-addr indicator in STIX 1.x.
I apologize.
However, it still fails about email-addr.

I will be pushing the fix soon.

Hello @rpiazza,
I also ran into an error with ipv4-addr: value.

AttributeError: 'EqualityComparisonExpressionForSlider' object has no attribute 'root_type'

I want to convert the STIX 2.1 Indicator to STIX 1.1.1.
I attach the STIX 2.1 data and the pip freeze results.
datas.zip
Could you please tell me what's wrong?
Best regards,
thamamo

@thamamo
When I ran it in my environment I was able to generate STIX 1.1.1 with no problems.
Can you perhaps include some extra info - like a stack trace?

Hello @rpiazza,
Thank you for your reply.
I attach the stack trace information.
stacktrace.zip
Best Regards,
thamamo

Hello @rpiazza,
Thank you for your reply.
I attach the stack trace information.
stacktrace.zip
Best Regards,
thamamo

Hi @thamamo,
I realized that the current published version of the slider is out of date.  A new version will be out soon after the latest version of python-stix2 is released.  As a stop-gap measure, you could go to github and get the latest version.
https://github.com/oasis-open/cti-stix-slider

Hi @rpiazza,
I installed the latest version from Git and it worked fine.
Thank you for your kind and quick support.
Thanks and Regards,
thamamo


Initial Code Review

The changes here represent everything that has been done to create this package thus far.  I created an empty branch off the initial commit called audit and this PR is a merge of master's HEAD into the audit branch.  The main thing to review is:

htseq2multx.pl

It would also be helpful to review:

tests/run_tests.sh

Anything else is a bonus.

Very thorough job. Most of the comments are minor. I probably shouldn't have included all of the suggestions for each double-sigil deref, they clutter the review, but once I started I thought it best to be consistent.

I know that my preference for the double-sigil deref is generally in disfavor and that my opinion that they are easier to read (when there's no arrow or index/key) and less cluttery is not a popular one.

I wasn't actually able to run the ./run_tests.sh successfully. Didn't debug too far yet, but here's the output: https://gist.github.com/lparsons/89c46744bf0be957bae7ad501d1c8aa3

Yeah, since I haven't yet written the Makefile.pl, your run of the tests will fail because:
Can't locate IO/Pipe/Producer.pm

Very helpful review @lparsons. Thanks!

Incidentally @jcmatese, I'll be working on another project today, so reviewing now is fine.  I'll try to remember to change the PR title to prepend [WIP] when I start making changes.

Incidentally, when you go through the review in the github web interface, how do you initiate the independent little code suggestion? Are you like, selecting the lines and using a contextual menu with an edit option or something?  It's pretty nifty you can make those mini-PR's.

Incidentally, when you go through the review in the github web interface, how do you initiate the independent little code suggestion? Are you like, selecting the lines and using a contextual menu with an edit option or something? It's pretty nifty you can make those mini-PR's.

Yeah, it's a very cool feature (and would be useful when not abused as I did). Basically, it works on the line(s) that you are commenting on. Click on the little +/- icon and it fills in some markdown automatically. You edit that, and it automatically puts in the little diff. See step number 6 on Commenting on a pull request:

Incidentally @jcmatese, I'll be working on another project today, so reviewing now is fine. I'll try to remember to change the PR title to prepend [WIP] when I start making changes.

FYI - You can mark PRs as "Draft" as well, see Introducing Draft Pull Requests.
Documentation on Changing the stage of a pull request

Incidentally @jcmatese, I'll be working on another project today, so reviewing now is fine. I'll try to remember to change the PR title to prepend [WIP] when I start making changes.

FYI - You can mark PRs as "Draft" as well, see Introducing Draft Pull Requests.
Documentation on Changing the stage of a pull request

Whoops, I just inadvertently converted this PR into a Draft.  I am not certain I understand the distinction between a draft and a pre-reviewed PR.

Clicking the "ready for review" button, to undo...

Incidentally @jcmatese, I'll be working on another project today, so reviewing now is fine. I'll try to remember to change the PR title to prepend [WIP] when I start making changes.

FYI - You can mark PRs as "Draft" as well, see Introducing Draft Pull Requests.
Documentation on Changing the stage of a pull request

Huh.  The convert to draft button didn't seem to appear to do anything, but apparently it worked...  Seems like there should be some sort of confirming feedback.

I have not yet created a tag for the fastq-multx release nor updated the documentation for IO::Pipe::Producer, but those are not directly associated with this PR.
Ready for second review from @lparsons and @jcmatese.

I think this is likely the last round.  Great catches lance!

LGTM! :shipit:

Thanks for all the attention to detail.  I always learn things from your reviews.

nudge @jcmatese

Thanks @jcmatese!


Carousel wont render anything

I'm just trying this carousel, and it can't even rendered.
I'm using your example as a reference.
What did i do wrong?
Code
const renderCarouselItem = ({ item }) => {
  return (
    <View style={{ flex: 1 }}>
      <Text>{item.name}</Text>
    </View>
  );
};

render() {
    return (
      <View style={{ flex: 1 }} >
        <Carousel
          ref={(c) => { this._carousel = c; }}
          data={[{ name: 'a' }, { name: 'b' }]}
          renderItem={renderCarouselItem}
          sliderWidth={400}
          itemWidth={200}
        />
      </View>
    );
  }

Packages

"react": "16.0.0-alpha.12"
"react-native": "0.46.4"
"react-native-snap-carousel": "^3.2.2"

Same problem here

@sitompul
try this
const renderCarouselItem = ({ item }) => {
  return (
    <View style={{ flex: 1 }}>
      <Text>{item.name}</Text>
    </View>
  );
};

render() {
    return (
      <View style={{ flex: 1 }} >
        <Carousel
          ref={(c) => { this._carousel = c; }}
          data={[{ name: 'a' }, { name: 'b' }]}
          renderItem={renderCarouselItem}
          sliderWidth={400}
          sliderHeight={200}
          itemWidth={200}
          itemHeight={200}
        />
      </View>
    );
  }

@agungjk it still doesn't work.
Could you also provide me with your current react-native version?

Hi @sitompul @agungjk,
Can you take a look at the answer I gave to a similar question and tell me if that helps?

did you using yarn?
i have some trouble with yarn, so i reinstall all package using npm
this is my code
    _renderItem ({item, index}) {
        return (
            <Card>
                <CardItem cardBody>
                    <Image
                        style={styles.content.item.image}
                        source={require('./../../assets/img/promo.png')}>
                        <View style={styles.content.item.title}>
                            <Text>
                                {index}-Lorem ipsum dolor sit amet...
                            </Text>
                        </View>
                    </Image>
                </CardItem>
            </Card>
        );
    }

render() {
    return (
      <View>
                    <Carousel
                        data={[{}, {}, {}]}
                        renderItem={this._renderItem}
                        sliderWidth={width}
                        sliderHeight={250}
                        itemWidth={width - 80}
                        itemHeight={250}
                        slideStyle={{
                            width: width - 100,
                            height: height * 0.55,
                            marginLeft: 10,
                            marginRight: 10
                        }}
                        inactiveSlideOpacity={1}
                        inactiveSlideScale={1}
                        />

      </View>
    );
  }

"react": "16.0.0-alpha.12"
"react-native": "0.46.1"
"react-native-snap-carousel": "^3.2.2"

It works now thanks @bd-arc !

@sitompul No problem ;-) I'll make sure to add a note to the doc about handling item's height because I don't think I made it clear enough.


Don't check .ftpignore when editing remote files

I have added a config file in my .ftpignore file. This is fine when I am editing locally - I don't want it uploaded on save.
However if I open the remote version of the config file my changes cannot be saved to the remote server at all. This was not the behaviour I expected.
It would also be nice if editing a remote file edited only the remote copy and did not overwrite my local copy. Or if this could be an setting.

Basically, there is no way to edit a file remotely. You will need to download the file, it will be stored in a maximum of one tmp folder and will be deleted after time.
Atom projects are working and basically consistent with the files.
If you do not want to overwrite, create new project and work there.
I do not agree with your logic, sorry.
--
Select file in tree > Mouse right click > Upload file. This is "Force" upload, without ignores.
(But this will be a separate menu item later.)

Different workflows for different folks I guess. I'm used to using Coda where editing a remote file does not sync it to your local copy.
The context menu option to force upload works great, thanks!

There would be not wrong feauture anyway. But it's too much trouble for now this package. If you have time and you want to deal with it then I'd like to have PR.


Read only rating bar

I appriciate the rating bar implementation.
I think there should also be a privilege of having read-only rating bar.

Would add this feature. But for now you can wrap the widget with AbsorbPointer widget to make it read only

This feature has been added in the new version. Please check README.

Great, Really appriciated. Thank you.


support startingIndex == r.length for std.range.radial

useful for searching around a mid-point in a sorted array,
e.g. foreach (e; r.radial(r.lowerBound(pivot).length))
symmetric support of both empty left and right subrange
still throws when startingIndex is bigger than r.length

Alrighty. Can you please make a note in the documentation as well? Thx!

done

cool!


Move assembly into a separate project

That would ease adding modules that exist as separate project

We finally have another project to bundle Gatling with Highcharts.
see https://github.com/excilys/gatling-with-highcharts-bundle


Extract features from Graph attention network

I am trying to extract only features from graph attention network, I was using Gcn as feature extractor and I want to replace it with GAT
gc1 = GraphConvolution( input_dim = 300,  output_dim = 1024, 'first_layer')( features_matrix, adj_matrix )
gc2 = GraphConvolution(input_dim = 1024, output_dim = 10 ,'second_layer') (gc1, adj_matrix)

Where GraphConvolution layer is defined as :
class GraphConvolution():
    """Basic graph convolution layer for undirected graph without edge labels."""
    def __init__(self, input_dim, output_dim, name, dropout=0., act=tf.nn.relu):
        self.name = name
        self.vars = {}

        with tf.variable_scope(self.name + '_vars'):
            self.vars['weights'] = weight_variable_glorot(input_dim, output_dim, name='weights')
        self.dropout = dropout

        self.act = act

    def __call__(self, inputs, adj):

        with tf.name_scope(self.name):
            x = inputs
            x = tf.nn.dropout(x, 1 - self.dropout)
            x = tf.matmul(x, self.vars['weights'])
            x = tf.matmul(adj, x)
            outputs = self.act(x)
        return outputs

Now to replace gcn layer with GAT, I tried this :
from gat import GAT

# Because Gat is accepting 3d input [ batch, node, features ]
features_matrix     = tf.expand_dims(features_matrix, axis = 0)
adj_matrix          = tf.expand_dims(adj_matrix, axis = 0)

gat_logits = GAT.inference( inputs = features_matrix,
                                 nb_classes  = 10,
                                 nb_nodes    = 22,
                                 training    = True,
                                 attn_drop   = 0.0,
                                 ffd_drop    = 0.0,
                                 bias_mat    = adj_matrix,
                                 hid_units   = [8],
                                 n_heads     = [8, 1],
                                 residual    = False,
                                 activation  = tf.nn.elu)

Now I want to get just the logits from GAT as features and it should learn the features too, so I set training = True
But the accuracy from GCN features I was getting around 90% but in GAT features I am not able to get accuracy more than 80 %, instead, it should increase the accuracy compared to GCN.
Is there anything I am missing in the network or my hyperparameters are not correct to compare to the hyperparameters i was using in GCN.
@PetarV-  @gcucurull  Can you suggest me how I can extract feature from GAT and if I am doing correct way then why I am not getting good accuracy.
Thank you

Looking at your GCN, it looks like the first layer has a hidden state of 1024 units, whereas for GAT you have set hid_units to [8]. This means that the first layer has 8 heads with a hidden size of size 8 each, which is much smaller than the hidden size used in the GCN.
You can try changing hid_units to [128] or [256], which will increase the hidden size of each head in the first layer, increasing the capacity of the model.

@gcucurull  And the code which I am using is correct? I had doubt that maybe I am not using the network properly.

@monk1337 Yes, it looks good.

@gcucurull  Thanks for the quick response. I have one more doubt, So in attention heads, we are passing a list [8, 1]
I went through the code and the got the idea that it's for the output layer.
for i in range(n_heads[-1]):
            out.append(layers.attn_head(h_1, bias_mat=bias_mat,
                out_sz=nb_classes, activation=lambda x: x,
                in_drop=ffd_drop, coef_drop=attn_drop, residual=False))
        logits = tf.add_n(out) / n_heads[-1]

But what should be the ratio between input heads and output heads? How it is affecting output?

The output layer is the one computing the logits, if you use multiple heads, the final logits will be the average over the logits produced by each output head.
However, in our experiments we always used only 1 output head, that's why it is set to [8,1].
There isn't really a ratio between input heads and output heads since the number of output heads should be 1. The number of input heads basically controls the number of parameters of the model and its expressive power, so you might want to increase or decrease depending on your task.

@gcucurull  Thanks for the response. Is it input heads are same as no_of_classes? Or what is the default head size should I use if I have big graph?

The number of input heads and number of classes is not related.
8 input heads worked well for our case so I suggest starting with that value and tweaking it empirically. Increasing it will increase the capacity of the model, decreasing it will reduce it but also speeds things up and lower the memory consumption.

@gcucurull I tried to experiment with no of heads and hidden units from range 2 to 1024 but couldn't get accuracy nearby GCN layer which I showed above. GCN is producing 90% accuracy and Gat is not crossing more than 85% after many combinations of hidden units and no of heads. I also tried to add two layers of GAT, let me know if it is correct :
        logits_graph = GAT.inference( inputs = realtion_batch,
                                 nb_classes  = 800,
                                 nb_nodes    = 22,
                                 training    = True,
                                 attn_drop   = 0.0,
                                 ffd_drop    = 0.0,
                                 bias_mat    = adj_batch,
                                 hid_units   = [8],
                                 n_heads     = [8,1],
                                 residual    = False,
                                 activation  = tf.nn.elu)

        logits_graph_s = GAT.inference( inputs = logits_graph,
                                 nb_classes  = 256,
                                 nb_nodes    = 22,
                                 training    = True,
                                 attn_drop   = 0.0,
                                 ffd_drop    = 0.0,
                                 bias_mat    = adj_batch,
                                 hid_units   = [8],
                                 n_heads     = [8,1],
                                 residual    = False,
                                 activation  = tf.nn.elu)

But when I tried these two layers, accuracy is 0.0 for 100 epochs.
Why Gat is not performing better than GCN?

The code is not quite ok.
First of all, if you want to have multiple GAT layers, you don't have to call GAT.inference twice, you have to increase the number of elements in the hid_units list. Also, why do you set nb_classes to 800? Do you really have 800 classes? You also seem to be working with very small graphs, with nb_nodes set to 22.
The correct way to have a GAT model with 2 layers, with 8 heads per layer and 128 units per head is the following:
    logits_graph = GAT.inference( inputs = realtion_batch,
                             nb_classes  = NUMBER_OF_OUTPUT_CLASSES,
                             nb_nodes    = NUMBER_OF_NODES,
                             training    = True,
                             attn_drop   = 0.0,
                             ffd_drop    = 0.0,
                             bias_mat    = adj_batch,
                             hid_units   = [128, 128],
                             n_heads     = [128, 128, 1],
                             residual    = False,
                             activation  = tf.nn.elu)

@gcucurull  n_heads are  [8,8,1] or [128,128,1] ?

Sorry, you are right, it is [8, 8, 1], I edited the message to correct it.

Did this work?

Yup


Tanhauhau 1267

Fix typo issue 1267

Looks like you are having the same issue here as in #1287   @tanhauhau Let me know if you need some help with creating PR's.


Added support for combining --dot and --circular options

The changes are inspired by PR #224.
I tested it against my project and I successfully generated a .dot file that contains only circular dependencies.
I'm not familiar with the test files of this repository, So @pahen would you please review these changes and add some test cases to your project? and it would be great if you merge it any soon.
Thanks

Thanks for your contribution! Added in v3.11.0 and published to NPM :)


Potential threading issue in XlsBiffStream

Since I fixed some other locking issues in LogManager, I also took a look at more places where locking is used. The locking in XlsBiffStream looks a bit strange. The Seek and Read methods use a lock, but not the ReadAt method. The reason why this is a problem in the ReadAt method is that it also uses the m_offset field:
if (m_offset + rec.Size > m_size)
    return null;

I find this piece of code a bit strange. Perhaps this is not an issue with locking, but rather that it should use offset instead of m_offset? Perhaps it should rather be:
if (offset + rec.Size > m_size)
    return null;

Another, minor, issue is that you should avoid locking on "this" and use a "private object m_lock" instead. See for instance here for a motivation: http://stackoverflow.com/questions/251391/why-is-lockthis-bad
Another, even more minor, issue in this class is mixed naming conventions (sometimes for fields m_ and sometimes not).

Yeah, I think there have been many fingers in the pie. Personally I don't like m_ - mostly because it looks ugly. The original authors are long gone though so I'd be hesitant to change anything in that core biff stuff, unless it relates to some real life issue.

The code in question has changed a lot in develop, f.ex ReadAt() no longer exists and the locking is mostly removed. Should be OK to close.


Generalise to "Water Linked devices" and add UGPS support

Original Companion UGPS support contains several overlaps with the DVL-A50 driver here. Since both devices are from Water Linked, it likely makes sense to have both devices available via the same package, which can asynchronously monitor for both. That may also lend itself to easier integration between the DVL and UGPS in future.

It's been decided to do this as a separate extension. Progress is here.


Not running under torch 1.0.0

When I run python WCT.py --cuda, I get an error:
Traceback (most recent call last):
  File "WCT.py", line 9, in <module>
    from util import *
  File "/home/apogentus/Desktop/Projects/Experiments/Style_transfer/Not_mine_ST/PytorchWCT-master/util.py", line 3, in <module>
    from torch.utils.serialization import load_lua
ModuleNotFoundError: No module named 'torch.utils.serialization'

I use pytorch v.1.0.0, ubuntu 18.04, python 3.6.8. From this discussion it follows that load_lua is no longer supported for torch 1.0.0. Could you please make your code compatible with the current version of pytorch or recommend some workarounds?

Under pytorch 0.4.1 everything runs without problems.

Yes, I solved it by
conda install pytorch=0.4.1
conda install pillow torchvision scipy


Move from source-map to source-map-js

I made the fork of<EMAIL_ADDRESS>which is 4x times faster and still sync and written in JS only.
More info about fork here: https://github.com/7rulnik/source-map-js#difference-between-original-source-map
It partly solves https://github.com/evanw/node-source-map-support/issues/206

I see that old node versions are failing. Is it still actual?

Oh, god, finally somebody with a common sense

I'd love to see this merged, @evanw is there a plan to merge this ? can we help with something ?


kiss-chroot: Mount /dev/shm, /tmp and /run

Closes #8

On another note. I've been using my own fork of bubblewrap to replace kiss-chroot. It's entirely rootless and correctly mounts all host stuff, etc. Something to think about for later.

How about also (bind-) mounting /dev/pts so that tty works, which lets pinentry do its thing for GPG2 password entry?

Done.


Regression: yum $releasever results in 404 error for RHEL yum repo

This commit, which changes ${releasever} (set to 5/6/7 for RHEL) to $releasever (uses the yum releasever) does not work for us on RHEL6.  The yum $releasever is 6Server, and the actual gitlab URL needs just 6.
https://github.com/vshn/puppet-gitlab/commit/1192cc6a4c4b4e9dc30b4775c9dc3dc6f4ca0bbd
This was previously noted and fixed / working fine, e.g. as seen in this issue:
https://github.com/vshn/puppet-gitlab/issues/42
I'm happy to put in a PR (I forked the module anyway so that I could get my upgrade to proceed), but I wanted to put in an issue first to get confirmation.

Also, since the old code used is_hash, and that is deprecated, would you prefer:

ignore $::os[release][major] and just use $::operatingsystemrelease
use validate_legacy (but that only supports Puppet 4.4.x+, so may be too version restricting)
replace it another way?

Code in question:
if is_hash($::os) {
$releasever = $::os[release][major]
} else {
$releasever = $::operatingsystemmajrelease
}

+1

I am getting this on redhat 7 as well.

I can confirm that this issue is affecting us on Redhat Enterprise Linux as well

I created #172 which fixes this issue (again, I guess?) and also adds the proper GPG key for EE if you are using EE and enables RPM verification.


[FromBody] always null when binding string (JsonReaderException)

Is this a Bug or Feature request?:
Bug
Steps to reproduce (preferably a link to a GitHub repo with a repro project):
Simple project (bindstringrepro.zip, but also below).

Run the app using dotnet run
Use Postman to make a POST to http://localhost:5100/api/values. Set the content type to application/json, and add valid JSON in the body, e.g. { } or { "Value": "Some value" }
The controller should echo back the JSON in the response
Instead, it always returns a 204 (No Content) because Model Binding fails

public class Program
{
    public static void Main(string[] args) => CreateWebHostBuilder(args).Build().Run();

    public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
        WebHost.CreateDefaultBuilder(args)
            .UseUrls("http://localhost:5100")
            .ConfigureServices(services => services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Latest))
            .Configure(app => app.UseMvc());
}

[Route("api/[controller]")]
public class ValuesController : ControllerBase
{
    // GET api/values
    [HttpPost]
    public ActionResult<string> Post([FromBody] string payload)
    {
        return payload;
    }
}

Description of the problem:
An MVC controller with a single string parameter, decorated with [FromBody]. POSTing a JSON body to the API with an application/json Content-Type triggers the JsonInputFormatter, but throws a JsonReaderException, even if the JSON is completely valid (e.g. {}).
As far as I can tell, binding a string to the body should be possible. @RickStrahl explicitly mentions it in a post from last year, so I'm guessing this is a change in 2.x?

Logs compressed for readibility

info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 POST http://localhost:5100/api/values application/json 2
dbug: Microsoft.AspNetCore.HostFiltering.HostFilteringMiddleware[0]
      Wildcard detected, all requests with hosts will be allowed.
dbug: Microsoft.AspNetCore.Routing.Tree.TreeRouter[1]
      Request successfully matched the route with name '(null)' and template 'api/Values'.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Route matched with {action = "Post", controller = "Values"}. Executing action bindstringrepro.Controllers.ValuesController.Post (bindstringrepro)
dbug: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Execution plan of authorization filters (in the following order): None
dbug: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Execution plan of resource filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
dbug: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Execution plan of action filters (in the following order): Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter
dbug: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Execution plan of exception filters (in the following order): None
dbug: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Execution plan of result filters (in the following order): Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.SaveTempDataFilter
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder[22]
      Attempting to bind parameter 'payload' of type 'System.String' ...
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder[44]
      Attempting to bind parameter 'payload' of type 'System.String' using the name '' in request data ...
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder[2]
      Rejected input formatter 'Microsoft.AspNetCore.Mvc.Formatters.JsonPatchInputFormatter' for content type 'application/json'.
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder[1]
      Selected input formatter 'Microsoft.AspNetCore.Mvc.Formatters.JsonInputFormatter' for content type 'application/json'.
dbug: Microsoft.AspNetCore.Server.Kestrel[25]
      Connection id "0HLH8G3GLI442", Request id "0HLH8G3GLI442:00000001": started reading request body.
dbug: Microsoft.AspNetCore.Server.Kestrel[26]
      Connection id "0HLH8G3GLI442", Request id "0HLH8G3GLI442:00000001": done reading request body.
dbug: Microsoft.AspNetCore.Mvc.Formatters.JsonInputFormatter[1]
      JSON input formatter threw an exception.
Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: {. Path '', line 1, position 1.
   at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)
   at Newtonsoft.Json.JsonTextReader.ReadAsString()
   at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder[45]
      Done attempting to bind parameter 'payload' of type 'System.String'.
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder[23]
      Done attempting to bind parameter 'payload' of type 'System.String'.
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder[26]
      Attempting to validate the bound parameter 'payload' of type 'System.String' ...
dbug: Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder[27]
      Done attempting to validate the bound parameter 'payload' of type 'System.String'.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Executing action method bindstringrepro.Controllers.ValuesController.Post (bindstringrepro) with arguments () - Validation state: Invalid
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action method bindstringrepro.Controllers.ValuesController.Post (bindstringrepro), returned result Microsoft.AspNetCore.Mvc.ObjectResult in 0.1929ms.
dbug: Microsoft.AspNetCore.Mvc.Infrastructure.DefaultOutputFormatterSelector[11]
      List of registered output formatters, in the following order: Microsoft.AspNetCore.Mvc.Formatters.HttpNoContentOutputFormatter, Microsoft.AspNetCore.Mvc.Formatters.StringOutputFormatter, Microsoft.AspNetCore.Mvc.Formatters.StreamOutputFormatter, Microsoft.AspNetCore.Mvc.Formatters.JsonOutputFormatter
dbug: Microsoft.AspNetCore.Mvc.Infrastructure.DefaultOutputFormatterSelector[4]
      No information found on request to perform content negotiation.
dbug: Microsoft.AspNetCore.Mvc.Infrastructure.DefaultOutputFormatterSelector[8]
      Attempting to select an output formatter without using a content type as no explicit content types were specified for the response.
dbug: Microsoft.AspNetCore.Mvc.Infrastructure.DefaultOutputFormatterSelector[10]
      Attempting to select the first formatter in the output formatters list which can write the result.
dbug: Microsoft.AspNetCore.Mvc.Infrastructure.DefaultOutputFormatterSelector[2]
      Selected output formatter 'Microsoft.AspNetCore.Mvc.Formatters.HttpNoContentOutputFormatter' and content type '' to write the response.
info: Microsoft.AspNetCore.Mvc.Infrastructure.ObjectResultExecutor[1]
      Executing ObjectResult, writing value of type 'null'.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action bindstringrepro.Controllers.ValuesController.Post (bindstringrepro) in 121.5176ms
dbug: Microsoft.AspNetCore.Server.Kestrel[9]
      Connection id "0HLH8G3GLI442" completed keep alive response.
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 267.6543ms 204

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
Microsoft.NETCore.App 2.1.4

His example is a JSON encoded string search for the following, on the linked blog post.

This works to retrieve the JSON string as a plain string. Note that the string sent is not a raw string, but rather a JSON string as it includes the wrapping quotes:

If you want to get at the raw body content, I'd suggest just reading it yourself, or if you reallly really want something that's a parameter, implement something like: https://github.com/aspnet/Mvc/blob/release/2.2/test/WebSites/FormatterWebSite/StringInputFormatter.cs

Thanks for the quick reply @rynowak 👍

His example is a JSON encoded string search

Hmmm, so it is, fair point. I read that as meaning it had to be JSON, not only a JSON string.
I can work around the issue for my example. The easiest way for me was just to bind a JObject and call ToString() in the method. Horrible performance-wise, but this is a rarely-called non-performance critical endpoint, so it'll do for now.
It still seems a little odd to me that it doesn't work though. I guess it's a rare use case. This was an app ported from old-school ASP.NET, so apparently there's a difference in behaviour there.

I guess it's a rare use case.

Can I ask a few questions for my own education? I've always been a little mystified when these topics come up.

What do you ultimately need the body for?
Why is it important that you bind it to a parameter?
Why do you want to body as a string as opposed to a stream?

Sure

What do you ultimately need the body for?

It's being deconstructed into various domain objects. We don't have control over the incoming document (it's an external system posting to ours), so we need to be quite flexible in how we deconstruct it (I believe - I didn't write it)

Why is it important that you bind it to a parameter?

It's not important, it's just convenient. Wherever possible I don't want to have to mess with the underlying request. MVC should handle that for me 🙂

Why do you want to body as a string as opposed to a stream?

Because existing APIs need a string

Makes sense! If you really like the idea of it being a parameter, I'd suggest using the StringInputFormatter I linked.
If you want to do something more first class, you also have the option to write your own model binder - that sounds like a better fit. Then you could do the translation into your domain models in there (if it helps).
Closing this since it sounds like there's no action needed from us.

One reason for parameters vs streams is documentation. Parameters self document the api vs hidden black box with stream. This is true both for just looking at the code or if you use doc tools to generate api docs.


Rohan patch1

1st fix) #392

2nd fix) #347

3rd fix) #357

Closing the pull requests #411 and #412 , because the changes done there are reflected in this new PR

Please provide one pull request per fix. This will speed up review process since PRs can be merged indepently.

Okay. I will do them just now. Thanks 😄

Closing this PR. Scattered this PR into three new PR #417  #416 #415


to_numeric fails to coerce on TypeError, only works on ValueError

Calling to_numeric with errors='coerce' should coerce all non-numeric values to NaN.  However, it only seems to work when ValueError is thrown and not for TypeErrors.
Code Sample, a copy-pastable example if possible
import pandas as pd

print "Pandas Version %s\n" % pd.__version__
for badval in ["hello", [], {}]:
    series = pd.Series([badval])
    coerced = pd.to_numeric(series, errors='coerce')
    try:
        pd.to_numeric(series)
    except Exception as e:
        error = e
    print "Bad Value: %s  error=%s  coerced=%s" % (badval, type(error).__name__, coerced.dtype)
    print "DataFrame:"
    print coerced
    print ""

Expected Output
Pandas Version 0.18.1

Bad Value: hello  error=ValueError  coerced=float64
DataFrame:
0   NaN
dtype: float64

Bad Value: []  error=TypeError  coerced=object
DataFrame:
0    []
dtype: object

Bad Value: {}  error=TypeError  coerced=object
DataFrame:
0    {}
dtype: object

output of pd.show_versions()
INSTALLED VERSIONS
------------------
commit: None
python: 2.7.12.final.0
python-bits: 64
OS: Linux
OS-release: 4.0.9-63_fbk11_3989_g7d5ca22
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8

pandas: 0.18.1
nose: 1.3.4
pip: 8.1.2
setuptools: 25.1.6
Cython: 0.22
numpy: 1.11.1
scipy: 0.18.0
statsmodels: 0.6.1
xarray: None
IPython: 5.0.0
sphinx: 1.2.3
patsy: 0.3.0
dateutil: 2.4.1
pytz: 2015.2
blosc: None
bottleneck: None
tables: 3.1.1
numexpr: 2.6.1
matplotlib: 1.4.3
openpyxl: 1.8.5
xlrd: 0.9.3
xlwt: 0.7.5
xlsxwriter: 0.6.7
lxml: 3.4.2
bs4: 4.3.2
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: 0.9.9
pymysql: None
psycopg2: None
jinja2: 2.8
boto: 2.36.0
pandas_datareader: None

There have been some improvements to to_numeric lately, and this seems fixed in the 0.19.0rc1:
In [24]: for badval in ["hello", [], {}]:
    ...:     series = pd.Series([badval])
    ...:     coerced = pd.to_numeric(series, errors='coerce')
    ...:     print(coerced)
    ...:
0   NaN
dtype: float64
0   NaN
dtype: float64
0   NaN
dtype: float64

In [25]: pd.__version__
Out[25]: '0.19.0rc1+22.g18cf0e7'

Possibly fixed by https://github.com/pydata/pandas/pull/13326

So the fix will be in the upcoming 0.19.0 release. @JonathanMace Thanks for reporting!


python310Packages.azure-keyvault-secrets: 4.3.0 -> 4.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.azure-keyvault-secrets is: "Microsoft Azure Key Vault Secrets Client Library for Python"
meta.homepage for python310Packages.azure-keyvault-secrets is: "https://github.com/Azure/azure-sdk-for-python"
meta.changelog for python310Packages.azure-keyvault-secrets is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.4.0 with grep in /nix/store/crii3p5wzj89l3yq7vs2dfjq1rd89psw-python3.10-azure-keyvault-secrets-4.4.0

found 4.4.0 in filename of file in /nix/store/crii3p5wzj89l3yq7vs2dfjq1rd89psw-python3.10-azure-keyvault-secrets-4.4.0

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
appdaemon
python310Packages.azure-keyvault
python310Packages.azure-keyvault-secrets
python39Packages.azure-keyvault
python39Packages.azure-keyvault-secrets

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/crii3p5wzj89l3yq7vs2dfjq1rd89psw-python3.10-azure-keyvault-secrets-4.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.azure-keyvault-secrets https://github.com/r-ryantm/nixpkgs/archive/9e1b79d3443a5a0047fbbe8814661df076132f9c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/crii3p5wzj89l3yq7vs2dfjq1rd89psw-python3.10-azure-keyvault-secrets-4.4.0
ls -la /nix/store/crii3p5wzj89l3yq7vs2dfjq1rd89psw-python3.10-azure-keyvault-secrets-4.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

appdaemon
python310Packages.azure-keyvault
python310Packages.azure-keyvault-secrets
python39Packages.azure-keyvault
python39Packages.azure-keyvault-secrets

Maintainer pings
cc @jonringer for testing.

Result of nixpkgs-review pr 166225 run on x86_64-linux 1

5 packages built:

appdaemon
python310Packages.azure-keyvault
python310Packages.azure-keyvault-secrets
python39Packages.azure-keyvault
python39Packages.azure-keyvault-secrets


Tsylia/Admins Template pattern

It has added new admins's dtos, services, controllers, and utility classes to WebApi. This is an attempt to refactor these classes according to the Template method.

@VadymLevkovskyi, could you review this PR? It attempts to use the Template pattern to organize the admins' services in the WebAPI project. I've left the old services to compare their functionality. I will remove them and start to write tests when this code improves after your reviews.


quantity input correction

Questions
Answers

Description?
quantity input correction

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes #30911

Sponsor company
Your company or customer's name goes here (if applicable).

How to test?
All the details are on the issue.

Before

After

Default flex-wrap value is nowrap, no need to specify it further. ✅

Issue is not just about input group. The main cause  of that is whole block with add to cart and wishlist is not allowed to wrap. Can you add this fix to this PR?

IMO this button should be on the product image, just like it is on products list or somewhere near the product title:

In area with quantity input only order related actions should be allowed.
But changes like that would have to be made in blockwishlist module (move to different hook) or in Hummingbird theme (. No point to change it here in classic. If anything I would simply decreased margin a little:
.wishlist-button-product {
  margin-left: 0.5rem !important;
}

Hi @JBLach
Thank you for your PR ! I tried it and it correct the issue as we can see :

but we also see that the wishlist button is on a different line. If we have a short add to cart button. we have this button on an other line than the quantity, as we can see :

@PrestaShop/product-team is it what we want ?
FYI : I do it with a three column on the product page
If it's ok for the PM, I will put it in QA approved :heavy_check_mark:
Thank you !

This should go to 2.0.x, 2.1.x and develop.

Thank you @JBLach @AureRita !


fixing interfaces and matching devices up with DISK_MOUNT_POINTS style

Looks good just fix up the commit message - https://github.com/deis/workflow/blob/master/src/contributing/submitting-a-pull-request.md

done


Update, alphabetize, and remove duplicates

Alphabetizing doesn't do anything for the system really, and this PR adds some additional blacklisted emojis that are meant to be available to use.

I've been adding any I came across that are formatted like a regular word (first letter caps, other letters lowercase) and might feasibly come up unintentionally in normal conversation. If there are any that you think aren't problematic enough to belong on the blacklist, feel free to remove them, or point them out and I'll remove.
(Alphabetization was just to make the list more conveniently human-readable.)

Several of these are not something that would come up in conversations which is what the default blacklist is meant for. I have added a couple to the main list.