[$1000] On "Split Bill" page, the display name doesn't sync on other devices after renaming it

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log into Account A
Split a bill with multiple accounts, including Account B
While on the split bill page, rename the display name on Account B

Expected Result:
Account B's display name on device A should synchronously update just after it has been renamed on account B's device
Actual Result:
Renaming doesn't synchronously update on device A.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/2b2aa9a4-0e90-4033-8f19-1d262717036b
https://github.com/Expensify/App/assets/93399543/a4bd99e5-81ad-45e7-a3c2-6dbd80db080b
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685512857055539
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01182a1297b99a7cd4
Upwork Job ID:<PHONE_NUMBER>940458496
Last Price Increase: 2023-07-03

Proposal
Please re-state the problem that we are trying to solve in this issue.
Account B's display name on device A should synchronously update just after it has been renamed on account B's device
What is the root cause of that problem?
The problem here is that when we initialize commponent MoneyRequestConfirmationList  this.state.participants is initialized in constructor with value calculated from this.getParticipantsWithAmount(props.participants). Therefore, if props.participants changes, this.state.participants is not updated accordingly.
And similarly in the MoneyRequestModal  component, the selectedOptionsis initialized with the return value from OptionsListUtils.getPolicyExpenseReportOptions(props.report) or OptionsListUtils.getParticipantsOptions(props.report, props.personalDetails). Therefore, if props.report or props.personalDetails changes, the value of selectedOptions will change accordingly. if props.report or props.personalDetails changes after the MoneyRequestModal component is initialized, selectedOptions will not change accordingly.
What changes do you think we should make in order to solve the problem?

With MoneyRequestConfirmationList we will add.

componentDidUpdate(prevProps) {
    if (prevProps.participants !== this.props.participants) {
        const formattedParticipants = _.map(this.getParticipantsWithAmount(this.props.participants), (participant) => ({
            ...participant,
            selected: true,
        }));

        this.setState({ participants: formattedParticipants });
    }
}

With MoneyRequestModal:

useEffect(() => {
    setSelectedOptions(
        ReportUtils.isPolicyExpenseChat(props.report)
            ? OptionsListUtils.getPolicyExpenseReportOptions(props.report)
            : OptionsListUtils.getParticipantsOptions(props.report, props.personalDetails),
    );
}, [props.report, props.personalDetails]);

What alternative solutions did you explore? (Optional)
N/A

We have a refactor PR here that will handle the name/avatar changes in confirmation page. Here is the specific changes that handle that. It's not final yet though, so I guess we can hold this one.

Thanks! Let's put it on HOLD as the code coincides and might be fixed.
Putting it on HOLD on issue https://github.com/Expensify/App/issues/17662

still on hold

No longer on hold. https://github.com/Expensify/App/issues/17662 is resolved.

@namhihi237 and @honnamkuan do you want to update your proposal we have refactored the code.
@abdulrahuman5196 could you help to review the proposals here, thanks!

Hey @honnamkuan I just tested it right now, it is still reproducible, I will attach a video down below. It would help if you would share a screen recording with us to identify if there are any missed steps.
https://github.com/Expensify/App/assets/111440031/fe2527d8-372c-4885-9c1f-d4920874d260

thanks for that breakdown @bernhardoj! to confirm, was the issue fixed via https://github.com/Expensify/App/issues/17662, or do we still need to address something here?

@MonilBhavsar
@bernhardoj 's response here is correct https://github.com/Expensify/App/issues/20010#issuecomment-1623052679
This issue is now happening only for user who you have never chatted with. What the expectation here? Should the display name change? AFAIK no, correct me if wrong.

This doesn't seem like issue to me https://github.com/Expensify/App/issues/20010#issuecomment-1621778418
If there is not chat between users, we won't send pusher events for name update and it won't get updated.
Not an issue IMO. cc @Beamanator @Puneet-here buddy check please 🙏

Agreed @MonilBhavsar 👍

Yoo, thanks Alex 🙌

@maddylewis, we can close this issue now. It will be great to add regression testing steps for this flow.
Reported issue was fixed by https://github.com/Expensify/App/pull/17964/
So, we need to pay reporting bonus to @Nathan-Mulugeta

tomorrow morning i will pay the $250 reporting bonus to @Nathan-Mulugeta and then close the issue!

@maddylewis is processing payment

offer sent to @Nathan-Mulugeta

Just accepted offer @maddylewis

paid!


Schema Validation Azure DevOps

This is just to capture an issue for people searching for the same issue.
The schema validation was not working for a repository that is hosted on Azure DevOps Service.  The issue resulted in being the URI of the origin.  This particular repository had originally been cloned using the older visualstudio.com URI schema (this did not validate)
e.g.
https://.visualstudio.com//_git/
Creating a new repo clone using the newer URI schema (this did validate)
e.g.
<EMAIL_ADDRESS>

Interesting, thanks for reporting @drewkg. Can you describe what you mean when you say "schema validation"? Do you mean the new schema auto-detection feature, or something else?

Apologies, I mean the ability to detect and download the json schema for your instance of Azure DevOps Service which includes the custom plugins that you have installed.
I have only just discovered this VS Code extension so I am unsure if this is new, but it is very useful.

Thanks for the report! Both types of URLs should work, so I'll take a look and see what's going on.


Global hook for doing something in response to a synchronous server call

Updated as discussed.

Pinging on this since some downstream work depends on it


Data Access

We need ways to read and write the data attached to each node. Implement this.

With the Data and DataExt traits defined in node and implemented by both Directory and File (and with a blanket implementation of DataExt for all Data, this should be enough for now - more useful methods can be potentially added to DataExt if needed beyond read and write, however these are the basis for any special cases.


Update play services

Update the play services version

This has since been updated. Version 0.3.2 is using play service 9.6.1


Changed bitmonerod to monerod on 'getting started' page

This along with the remaining s/bitmonerod/monerod/ are all handled in #187.


Added PS4 7.00 7.01 7.02 Offsets

Someone asked for 7.02. Enjoy, it ought to function properly.
Testing is required, but all 7.00 offsets align with those of 7.02.

Stage 3 always results in a Kernel Panic / Sudden shutdown. This was tested around 8-10 times on my 7.02 PS4.

Stage 3 always results in a Kernel Panic / Sudden shutdown. This was tested around 8-10 times on my 7.02 PS4.

Same issue with me. I barely get past stage 1 and stage 2 is a rare sight. By the time it progresses past KASLR it'll freeze and kernel panic. I'm wondering if one or more of the offsets are wrong or if it's the firmware security? Perhaps the script needs adjusting?

Hey, I appreciate your help with testing. I'll have some time over the weekend to review them again. Initially, I ran the tests with version 702 and then cross-checked with version 700, but there might be something I miss.

Hey, I appreciate your help with testing. I'll have some time over the weekend to review them again. Initially, I ran the tests with version 702 and then cross-checked with version 700, but there might be something I miss.

I managed to compile ppyn C++ with your changes to the script and got it working for macOS High Sierra and have doubled the time to check by about 80% so testing goes much, much quicker. One issue I've found is it'll fail on [-] Scanning for corrupted object...failed. about 10-15 times (I have it set on --auto-retry) until it gets to the second stage, then kernel panics. Thanks again for your help!

Ok, I did find that memcpy appeared to be correct, but it actually wasn't. Feel free to try it if you'd like. I will check stage 1 and stage 2 tomorrow.

Ok, I did find that memcpy appeared to be correct, but it actually wasn't. Feel free to try it if you'd like. I will check stage 1 and stage 2 tomorrow.

I'm getting successful stage2 execution on 7.02. (i.e. the console's displaying the "PPPwned" notification)
Based on the last 40 attempts, the success rate is ~60% with all other attempts failing to find the corrupted object during the memory corruption stage.
I did get two kernel panics on my first and fourth attempts (not included in the success rate measurement), but I think these were both due to user error / not waiting for "Cannot connect to network: (NW-31274-7)".

Yes, I get the same results with version 7.55. I believe you'll achieve better results using C++ instead of Python. When I have some time, I'll plug in my 7.55 and give it a try.
Thank You For Confirming It Works.


New participants workflow

New agreed text for participants page.
Signed-off-by: martinrvisser<EMAIL_ADDRESS>Description
Adds:

drop down to community for participants page
participants page (tbd automation around the participant listing)
button to create new issue with participants form

Issues Resolved
Example: closes #112
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

i think this is mergable but I do think it should include more than one organization before it's deployed, just from an optics perspective.
I know there is an issue with Aiven (#110), but I'd like them to take the action to commit the actual info and logo so it looks as they want. Also it went from being called partner to participant, so that's a slight shift they should be okay with.


added the ability to return the offending word

I did not want to break the api, so i just updated the calls to wrap the old one, but i'm writing a discord bot that needs a filter like this, but wanted to list the word that was the offense in a log without re looping through.

Codecov Report

Merging #21 (46ee798) into master (d66babb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           73        76    +3
=========================================
+ Hits            73        76    +3

Impacted Files
Coverage Δ

goaway.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66babb...46ee798. Read the comment docs.

@Luberry Thank you for your contribution!
I'm sorry for going back on my word, but I ended up removing the boolean from ExtractProfanity - it just didn't make sense to me.
If somebody wants to have just the boolean, they can simply use IsProfane.
In any case, this has been released in v1.3.0


Timeout issue

Hey I am using 5.1 library, i think this issue still exits in latest library as well.
Issue is,
used  timeout as 30 seconds in test cases development:
Wait Until Element Is Not Visible id=${autoaction_name}, 30
On prerequisites used:
Set Browser Implicit Wait     60 seconds
Set Selenium Implicit Wait    15 seconds
or  with 60 sec

Here Set selenium implicit wait is overall configuration, but testcase is still considering the overall wait 15 seconds instead of 30 seconds which i configured, basically it should be overwritten with testcase implementation. otherwise this leads serious issue for objects we expect longer time to wait. I think this issue is the for element should be visible as well.
Fix ASAP.

Please report the issue to SeleniumLibrary's issue tracker, this issue tracker is only for Robot Framework core. I recommend you to also explain the issue in a bit more detail. I read the description twice and didn't really understand what the problem is.


Using "-i" to put AC3 track as second track (after video) is not working. It's set as index=0 every time.

When I use the -i argument, according to the code, it's supposed to put that track as the second track with the first track being the the video.
        # Puts the AC3 track as the second in the file if indicated as initial
        if [ $INITIAL = 1 ]; then
                CMD="$CMD --track-order 0:1,1:0"
        fi

This isn't happening and the AC3 track is being put first (index=0) with video being second (index=1).
I don't understand how the --track-order argument works with mkvmerge otherwise I'd suggest a fix.

After mucking with this a bit, discovered that the fix is simple and I created a PR for it:
https://github.com/JakeWharton/mkvdts2ac3/pull/114


[Future req] BMWApps data supply, eg. Weather

HI,
could you try to add connectivity between bmw apps (e.g. weather) and online services. I heard  that somebody from Russia developed such an app that restore online connectivity through Bluetooth teetering in case your subscription is over or broken telematic box (sim card problems).
Many apps are still able to get content from ConnectedDrive servers without problems, except the subscriptions (e.g. RTTI) and auth messages.
Other approach could be for example to get weather use different weather source and just give proper xml file to head unit to present it in many places and give alerts (e.g. storm, heave rain, snow, ice on road).

Internet connectivity via Bluetooth can be enabled via coding.  You'll need to make the following changes to your VO:
Add 609, 6AK, 6NS, 6NR and 616. Remove 615, 6AA, 6NF and 6NK
Check out this thread on BImmerfest.com for more info.
FYI this is for NBT only, and will not work for NBT Evo head units.

I saw that topic but as i mentioned its only for the Old unit. What i heard and asked is for the new headunit nbt evo and entrynav.

My bad, you did mention a telematic module, which is only used by the NBT Evo.  The only information I've seen via the forums is that internet over BT is not possible for the Evo.  If you have a link to the app you mentioned please post it.

Unfortunatelly i dont have this App and russian forum link i have dont exists anymore. On bimmer fest forum in one of threats somebody else mentioned that aswell.

Interesting, I didn't know about this feature! My car doesn't support any weather map or telematics at all.
I haven't found any APIs to do as you suggest, to upload custom weather data into the car. I can only affect things within my own app entries in the car, while the weather functionality would be a functionally separate app. It sounds like the weather app runs entirely in the car, too, while I only have access through the phone's remote app functionality, and so I would only possibly be able to alter any BMW apps on the phone.
Sorry about that!

Can you share some information how I can debug the connectivity and API you found.  I can try to dig into that, but before I have to lunch successfully the app in my car.
I saw "similar" app up and running in one Russian guy with NBT_Evo ID6. He told me that it work like a proxy between the car and BMW servers to provide date with are free.  Also he told me that in next revision it'd be possible to use different weather and search provider.
So somehow they manage to overwrite the internet connectivity settings in HU to use phone internet tethering. If the phone is not connected or have not an internet connectivity HU just stated "No connection" error.  He was not a tech guy so i didnt manage to get more info.

https://bmw.spoolstreet.com/threads/anyone-thought-of-building-a-connected-drive-server.1512/
https://bmwi3owner.com/2016/01/secrets/
https://github.com/edent/BMW-i-Remote/#servers
https://community.smartthings.com/t/beta-release-bmw-connecteddrive/122165

https://www.bmwclub.ru/categories/avtomobili-bmw.145/
This is the Russian forum I was talking about.

I'm going to close this, because it's not within this project's scope (replicating Android Auto features as IDrive apps).

Ok, but I talked with some friends who I introduced the app and they like it. But to replikate missing connected services it would be also nice to have whether service avaliable in the car for current location and also temporarily for location of the destination.


Added merge_group event to run cli tests

Summary
Title says it.
How was it tested?
Still needs to be tested in github actions.

ok now go-lint actions aren't running. Closing this, we'll revisit once merge queues are out of beta


Remove obsolete examples

I realize I should have read more carefully, but the example code deleted here and especially the link to this documentation threw me off for 30-40 minutes this morning.  I finally found the up-to-date documentation - thanks.  I'm thinking you might want to remove it from the main README to help out the next person.

:+1:
Spent some time trying to figure out what was up this morning as well.

I fixed this when I made the 0.13.x branch the default on GitHub. Docs should match the code of the branch they are in. For a while, people were installing 0.13.x from npm and then coming and reading the 1.0 README on GitHub.
After we push 1.0, the master branch will again be the default and all future work will be done in feature branches.


NIFI-5849: ListXXX can lose cluster state on processor restart

NIFI-5406 introduced the issue by trying to use the resetState variable for
different purposes. AbstractListProcessor should have had a different variable
to control whether to clear state for tracking entity strategy.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1, code change LGTM, merging to master, thanks @ijokarumawak


Add option to mark non-primary columns as database generated.

Any column should be able to be marked as database generated.
API Proposal
As the configuration possibilities for a single column stack up by now, we should consider adding a new fluent API just for columns.
This could look something like this:
entityBuilder.Property(x => x.Column).WithName("column");

With the option to mark it as database generated:
entityBuilder.Property(x => x.Column).HasDefault();

// Or

entityBuilder.Property(x => x.Column).IsGenerated();

Related to #13.


 Check these notes: https://bit.ly/2ZEqIau
npm WARN deprecated<EMAIL_ADDRESS>🚨 This package has been deprecated in favor of separate inclusion of a polyfill and regenerator-runtime (wh
en needed). See the @babel/polyfill docs (https://babeljs.io/docs/en/babel-polyfill) for more information.
npm WARN deprecated<EMAIL_ADDRESS>You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8
 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compati
bility issues. Please, upgrade your dependencies to the actual version of core-js.

Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>node version 18.5.0
npm version 8.12.1

To Reproduce
Steps to reproduce the behavior:

npm i --save adminjs6.0.3<EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected behavior
Successful npm installation.
Desktop (please complete the following information if relevant):

OS: Windows 10
Browser: Chrome

Additional context
I think you should update the versions of the peer dependencies,  so they are matching the dependencies.

If i use npm install -f

If i use npm install -f i get this error:
 throw Error( "Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the followin
g reasons:\n1. You might have mismatching versions of React and the renderer (such as React DOM)\n2. You might be breaking the Rules of Hooks\n3. You
 might have more than one copy of React in the same app\nSee https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this prob
lem." );
            ^

Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
    at resolveDispatcher (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\react\cjs\react.development.js:1476:13)
    at Object.useState (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\react\cjs\react.development.js:1507:20)
    at ae (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\styled-components\dist\styled-components.cjs.js:1:13285)
    at renderWithHooks (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server-legacy.no
de.development.js:5662:16)
    at renderIndeterminateComponent (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-ser
ver-legacy.node.development.js:5735:15)
    at renderElement (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server-legacy.node
.development.js:5950:7)
    at renderNodeDestructiveImpl (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server
-legacy.node.development.js:6108:11)
    at renderNodeDestructive (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server-leg
acy.node.development.js:6080:14)
    at retryTask (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server-legacy.node.dev
elopment.js:6532:5)
    at performWork (C:\Users\vasil\Desktop\app\d3d-main-api\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server-legacy.node.d
evelopment.js:6580:7)

Node.js v18.5.0
[nodemon] app crashed - waiting for file changes before starting...

Please see if this comment helps you:
https://github.com/SoftwareBrothers/adminjs/issues/1180#issuecomment-1190293422
I'll have a look at peer deps issue today/tomorrow

It's a duplicate of https://github.com/SoftwareBrothers/adminjs/issues/1180#issuecomment-1190293422


[Core] Fix sorting of Dictionary keys

StringName keys were sorted as StringName which is unstable.

Fixes: https://github.com/godotengine/godot/issues/97522

Considering an alternative solution which allows fetching keys with StringName converted to String to improve behavior, will push as a separate commit soon when tested
Added a few cases I could find of this, will remove any that aren't relevant (the code in PackedDataContainer isn't affected as it sorts differently)

Added a unit test for the Dictionary case, there are no stringify tests currently for JSON so left that for now, but can add if desired

Removed the alternative fix and will look at it for the future, to get this out there soon
Was looking at the new sort method of Dictionary which I had forgotten to look at after it was added for this purpose, but it doesn't suite this without some changes as it suffers from the same ordering limitations, namely preserving compatibility for Variant ordering in general
So for context, this solves that OP_LESS of Variant sorts by type, so all String keys are sorted separately and StringName keys are sorted separately, further StringName keys are sorted by pointer for performance, but that's unstable
This was introduced by changes that removed the conversion from StringName to String on all keys in:

#70096

Tl;Dr;
This aims to solve sorting of Dictionary keys in serialisation in a compatibility preserving way while not impacting performance in general

Does this fix the animation tscn sorting issue?

Yes it should, will confirm fully today if no one else has

Thanks!

Thank you!


Clarify machine name issues with VPN.

Clarify names of machines vary for TNA/dxw.

Changes in this PR:
Trello card / Rollbar error (etc)
Screenshots of UI changes:
Before
After

[ ] Requires env variable(s) to be updated

I have created a PR which attempts to simplify the staging marklogic section and addresses this in it. Worth checking that first: https://github.com/nationalarchives/ds-caselaw-public-ui/pull/525


time_interval split recursion limit

The function split from the class TimeIntervals raises an exception when passing a list of about 990 points.
    @profile
    def split(self, points):
        if len(points) == 0:
            return
        p = points[-1]
        for i in range(len(self.intervals)):
            if (self.intervals[i].start < p) and (self.intervals[i].end > p):
                self.intervals = self.intervals[:i] \
                                 + [TimeInterval(self.intervals[i].start, p), TimeInterval(p, self.intervals[i].end)] \
                                 + self.intervals[(i + 1):]
        self.split(points[:-1])

This is because there is a limit in the recursion in Python to avoid possible overflows.
We should change the recursive call to a for loop.
Before I do the modification, do you see any reason why it was a recursive call from the first instance that I should consider?

I tried in my local machine the following code and it seems to work. However, still need to do some tests as do not understand the rest of the code yet.
    @profile
    def split(self, points):
        for p in points:
                for i in range(len(self.intervals)):
                    if (self.intervals[i].start < p) and (self.intervals[i].end > p):
                        self.intervals = (self.intervals[:i]
                                         + [TimeInterval(self.intervals[i].start, p),
                                            TimeInterval(p, self.intervals[i].end)]
                                         + self.intervals[(i + 1):])

I have been looking at the function and there is something that intrigues me.
Is it a true condition that the original intervals are non-overlaping? meaning that any given point can only be in one of the intervals??
If that is true, then the for loop do not need to go trough all the intervals once it has found the one in which it falls, and you could break.
If that is not true there is a possible error as the intervals are getting longer but the original indices only iterate for the original intervals length. Every time that you split an interval you may miss one interval at the end.

Yes the original intervals must be non-overlapping, otherwise they would have been merged. So yes you are correct that a point can only be one. Your for loop should be fine. I hadn't considered that the recursion depth wasn't actually a bug but python being overprotective!

That is great! I will do a pull request (or push the change if I have permission).

Commit 7c4747a324d2a53dd33b291b72464d7476fb8d06 fixes #29.
I added as a comment that the time intervals need to be non-overlapping. In that way, I break the internal for loop when the right interval is found per each point.


fix error reporter is not a function

Description

fixes error reporter is not a function

Related Issues

fixes #1 Error "TypeError: reporter is not a function"

i think you extract it in a new file, and export it then?


include use-credentials for webmananifest component when exposed

it will require to change pwa plugin api: https://github.com/antfu/vite-plugin-pwa/blob/main/src/html.ts#L22
It will be better to also expose the webmanifest link.

closed via https://github.com/userquin/vite-pwa-sveltekit-integration/commit/ac86b49b19594800c9f443cb7e13f78f6cb50f29


Synchronization error when running DEA on GSE18858

Brandon reported a problem when running dea on this experiment:
http://www.chibi.ubc.ca/Gemma/expressionExperiment/showExpressionExperiment.html?id=2931
Custom dea settings:

factors: treatment
subset by: collection of material

Dea takes ages to run, and then shows "Synchronization Error" dialog with no futher information.

Will try to reproduce and look at the logs.

The DEA finishes, but returns an empty response so the UI is not updated. However, there should be 4 subsets, and only 2 show up. Will investigate further.

Trying to reproduce this caused Gemma to stall and tomcat had to be restarted. This is a first hint into the mysterious Gemma crashes that have been happening every once in a while, always when a DEA has been running,

This specific case seems to be resolved, the DEA for this experiment is done.


Update tvm-weaknesses.md

Updated the option as it has changed. It states "no security update" instead of no updates available.

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10090

Learn Build status updates of commit be3cbc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-vulnerability-management/tvm-weaknesses.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 54b1e59:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-vulnerability-management/tvm-weaknesses.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fix Ruby compilation problems on MinGW

This fixes an undefined variable reference in the Makefile, and adds a Rakefile template to correctly reference the current core library version. It also uncomments the tracing function stub implementations, because they need to be defined for the core DLL to compile, and fixes a couple of signed-to-unsigned conversion compilation failures in tcp_server_windows.
These problems were showing up in the Ruby artifact build. This doesn't appear to completely fix the build, but it changes the error. CC @apolcyn Once this is merged, you may be able to make more progress there.
This fixes #8918.

Please hold merging until the fixit is done.

Jenkins: test this please

test this please

Linux failure is #9133, Mac failure appears to be #9241, and it looks like the interop clients and servers just failed to connect to each other.

btw this fixes https://github.com/grpc/grpc/issues/8124
running rake gem native locally on this now works to create the gems

btw labelling this is pre-req of 1.1 release - outside of other blockers to ruby 2.4.0 support, this is needed to build any ruby package from the master branch.

The Linux failure is #9150. The Windows failure is #9186.


Improve normal map VRAM Compression with RGTC

Fixes #57981
This PR extends etcpak with an RGTC compression module, as well as changes the compression type used by normal maps to RGTC_RG, instead of DXT5. This fixes artifacts caused by the R channel being quantized.
Also sets the compression type to RGTC_R for textures which only use the R channel.
Comparison:

master
PR

Have you considered proposing these changes upstream to https://github.com/wolfpld/etcpak/?

Have you considered proposing these changes upstream to https://github.com/wolfpld/etcpak/?

I did, but first I would like to implement SSE4 variants of the code for faster compression when available. I may do it sometime in the near future.

 Anyways great job, i’vbeen waiting for this.

As mentioned above, it would be really nice to have SSE4 versions of the code, and for this to be upstreamed. But I think we should merge what we have in the meantime as the quality improvement is really important

Perhaps the Godot-specific code from this and the modified squish decompressor could be moved to its own module one day, since RGTC isn't really considered to be part of the S3TC family?

Thanks!
As far as I understand the added files are not technically thirdparty and are fully original? Not sure if this is ideal, but I guess it lets us keep everything nicely organized (and yeah, maybe it can be upstreamed at some point). And since they are completely original, we don't need to mention them in /thirdparty/README.

As far as I understand the added files are not technically thirdparty and are fully original? Not sure if this is ideal, but I guess it lets us keep everything nicely organized (and yeah, maybe it can be upstreamed at some point). And since they are completely original, we don't need to mention them in /thirdparty/README.

The files aren't completely original as they use the code from the library's DXT5 alpha compressor, so maybe that should be mentioned?

In that case, I guess yes. After the "Files extracted from upstream source:" list you could add something like
Two files (ProcessRgtc.{cpp,hpp}) have been added to provide RGTC compression implementation, based on library's ProcessDxtc.{cpp,hpp}.


When setting/clearing a render region, the frame entity is not updated in the Attribute Editor

Fixed.


Emurasoft.EmEditor version 22.2.12

[x]  Have you signed the Contributor License Agreement?
[x]  Have you checked that there aren't other open pull requests for the same manifest update/change?

[x]  Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.
Microsoft Reviewers: Open in CodeFlow

Unfortunately, the same pipeline issue that causes the Internal-Error-Dynamic-Scan label to be applied also causes pipeline logs to not be generated/stored, complicating diagnosis.


Error running prediction example on Inception-BN

I am trying to run the Use Pretrained Inception-BatchNorm Network in python. The execution throws and error on line: prob = model.predict(batch)[0] with the error message:
MXNetError: InferShape Error in ch_concat_3c_chconcat: [14:35:56] src/operator/./concat-inl.h:152: Check failed: (dshape[j]) == (tmp[j]) Incorrect shape[2]: (1,320,15,15). (first input shape: (1,576,14,14))

I tried downloading the Inception-BN model again to make sure it was up to date but it didn't make a difference. I do suspect the problem could be on line: model = mx.model.FeedForward.load(prefix, num_round, ctx=mx.gpu(), numpy_batch_size=1) where I had to change gpu for cpu since my server is not equiped with a gpu. Nevertheless the error doesn't seem to point on that direction.
Any idea how to fix it? Is using a cpu instead of a gpu a problem other than a lower performance?
Finally here is the complete error information:
---------------------------------------------------------------------------
MXNetError                                Traceback (most recent call last)
<ipython-input-7-98e51e4226e1> in <module>()
      1 # Get prediction probability of 1000 classes from model
----> 2 prob = model.predict(batch)[0]
      3 # Argsort, get prediction index from largest prob to lowest
      4 pred = np.argsort(prob)[::-1]
      5 # Get top1 label

/users/CREATE/olb/mxnet/python/mxnet/model.pyc in predict(self, X, num_batch, return_data, reset)
    589         data_shapes = X.provide_data
    590         data_names = [x[0] for x in data_shapes]
--> 591         self._init_predictor(data_shapes)
    592         batch_size = X.batch_size
    593         data_arrays = [self._pred_exec.arg_dict[name] for name in data_names]

/users/CREATE/olb/mxnet/python/mxnet/model.pyc in _init_predictor(self, input_shapes)
    520         # for now only use the first device
    521         pred_exec = self.symbol.simple_bind(
--> 522             self.ctx[0], grad_req='null', **dict(input_shapes))
    523         pred_exec.copy_params_from(self.arg_params, self.aux_params)
    524

/users/CREATE/olb/mxnet/python/mxnet/symbol.pyc in simple_bind(self, ctx, grad_req, type_dict, **kwargs)
    623         if type_dict is None:
    624             type_dict = {k: mx_real_t for k in self.list_arguments()}
--> 625         arg_shapes, _, aux_shapes = self.infer_shape(**kwargs)
    626         arg_types, _, aux_types = self.infer_type(**type_dict)
    627         if arg_shapes == None or arg_types == None:

/users/CREATE/olb/mxnet/python/mxnet/symbol.pyc in infer_shape(self, *args, **kwargs)
    410             The order is in the same order as list_auxiliary()
    411         """
--> 412         return self._infer_shape_impl(False, *args, **kwargs)
    413
    414     def infer_shape_partial(self, *args, **kwargs):

/users/CREATE/olb/mxnet/python/mxnet/symbol.pyc in _infer_shape_impl(self, partial, *args, **kwargs)
    470             ctypes.byref(aux_shape_ndim),
    471             ctypes.byref(aux_shape_data),
--> 472             ctypes.byref(complete)))
    473         if complete.value != 0:
    474             arg_shapes = [

/users/CREATE/olb/mxnet/python/mxnet/base.pyc in check_call(ret)
     75     """
     76     if ret != 0:
---> 77         raise MXNetError(py_str(_LIB.MXGetLastError()))
     78
     79 def c_str(string):

MXNetError: InferShape Error in ch_concat_3c_chconcat: [14:35:56] src/operator/./concat-inl.h:152: Check failed: (dshape[j]) == (tmp[j]) Incorrect shape[2]: (1,320,15,15). (first input shape: (1,576,14,14))

Stay tuned. We have already trained a new Inception-BN model. Will make it public soon.

I can confirm that the googlnet/inception symbols don't work with the current top of tree.
For example this script https://github.com/dmlc/mxnet/blob/master/example/image-classification/symbol_inception-bn.py
src/operator/./concat-inl.h:152: Check failed: (dshape[j]) == (tmp[j]) Incorrect shape[2]: (32,320,13,13). (first input shape: (32,576,14,14)

@arnocandel @ernestbofill Please check the latest pretrained model.

What has been updated?
https://github.com/dmlc/mxnet-model-gallery
It says last commit 8 month ago

The current symbol generator scripts for Inception/Googlenet family of models are broken. To get a valid graph similar to the latest pretrained bundles, a pad (1,1) needs to be added to the last Pooling layer.

To answer your question: the backend went through a change that broke backward compatibility.

@ernestbofill Please download the latest pretrained model from data.dmlc.ml/mxnet/models/imagenet/

@winstywang Can you double check the url(http://data.dmlc.ml/mxnet/models/imagenet)? I can't access it.

Hi. I downloaded the new model. But the same example that I initially posted about now crashes at a previous step:
The crashing code is:
# Load the pre-trained model prefix = base_dir + model_prefix num_round = 126 model = mx.model.FeedForward.load(prefix, num_round, ctx=mx.cpu(), numpy_batch_size=1)
And the error:
` MXNetError: Failed loading Op conv_1 of type Convolution: Cannot find argument 'cudnn_off', Possible Arguments:
kernel : Shape(tuple), required
convolution kernel size: (y, x)
stride : Shape(tuple), optional, default=(1,1)
convolution stride: (y, x)
dilate : Shape(tuple), optional, default=(1,1)
convolution dilate: (y, x)
pad : Shape(tuple), optional, default=(0,0)
pad for convolution: (y, x)
num_filter : int (non-negative), required
convolution filter(channel) number
num_group : int (non-negative), optional, default=1
Number of groups partition. This option is not supported by CuDNN, you can use SliceChannel to num_group,apply convolution and concat instead to achieve the same need.
workspace : long (non-negative), optional, default=512
Tmp workspace for convolution (MB).
no_bias : boolean, optional, default=False
Whether to disable bias parameter. `

@thirdwing The URL works for me.

@winstywang I have download the latest model, but it still reports that
MXNetError: InferShape Error in ch_concat_3c_chconcat: [18:35:35] d:\chhong\mxnet\src\operator./concat-inl.h:152: Check failed: (dshape[j]) == (tmp[j]) Incorrect shape[2]: (1,320,15,15). (first input shape: (1,576,14,14))


CrossTab View

Cross Tab has been added to Angular MicrobeTrace. It is currently deployed on Mossy site. It allows users to change dataset (nodes, links, clusters), change the X and Y variables, pivot the table, show raw count or proportion of total, change text size, export as csv or excel, and import settings from a style file. Let me know what you think and if you see any bugs or anything that needs to be changed.

Thanks David!
From: David Cowan @.>
Sent: Monday, June 17, 2024 1:57 PM
To: CDCgov/MicrobeTrace @.>
Cc: Subscribed @.***>
Subject: [CDCgov/MicrobeTrace] CrossTab View (Issue #824)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Cross Tab has been added to Angular MicrobeTrace. It is currently deployed on Mossy site. It allows users to change dataset (nodes, links, clusters), change the X and Y variables, pivot the table, show raw count or proportion of total, change text size, export as csv or excel, and import settings from a style file. Let me know what you think and if you see any bugs or anything that needs to be changed.
—
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/MicrobeTrace/issues/824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHMTDBN7EZ2GSFC4AJCKIX3ZH4PNLAVCNFSM6AAAAABJOO72HSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TOOJQHE3DKMI.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>


TLS connectivity to ACME server failing

Using WINACME client on Windows Server 2012 R2.
Trying to communicate with the acme plugin on my software and getting the error message
WinACME initial connection failed, retrying with TLS v1.2 forced.
Using Google CAS as the CA, not sure on troubleshooting this.

Feed the acme API endpoint into the Qualsys SSL check to see which TLS ciphers they support for TLS1.2, then do the same on your server, if you don't have any overlaps then your server and theirs can't agree how to communicate.


upstream-community-operators [N] [CI] poison-pill-operator (0.0.1)

New Submissions

[x] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.

/retest

/test all

/hold cancel

@n1r1 can you please fix?
Value of 'metadata.annotations.containerImage' not used in any container, please check.

/retest

@mvalarh fixed.
can you please re-trigger tests?

/merge possible

@mvalarh looks like all test passed.
Is there anything else I should do on my side to get this merged?


Endless loop when filename contains brackets

using latest chokidar on windows
have a folder with a file inprogress[00].txt
use the following code:

var chokidar = require("chokidar");

console.log("before watch");

var watcher = chokidar.watch("the path", {
    ignoreInitial: false,
    persistent: true
});

console.log("after watch");

watcher.on("all", function(type, path) {
    console.log(type, path);
});

watcher.on("ready", function () {
	console.log("ready");
});

watcher.on("error", function(error) {
    console.log("error handler ", error);
});

process.on('uncaughtException', function(error) {
    console.log("uncaughtException: ", error);
});

I see repeaded calls to nodefs-handler#_addToNodeFs().
This seems to have worked fine in 0.12.x

Yep, reproduced. That's pretty crazy.

Ok I see what it is. The brackets are being recognized as a glob pattern so it keeps opening watchers against the directory when it wants one for the file. Fix forthcoming.


09 JUL 2024 - InnerSource SIG Meeting Minutes

Date
Tuesday 09 JUL 2024 - 10:00AM EST / 3:00PM UK
Attendee Identity
Please identify yourself when you attend the meeting by providing your name and affiliation in reply to this thread. Alternative we will need to add you here if you do not have a Github id

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS SIG Leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS SIG meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
[ ] Review FINOS Slack InnerSource SIG Channel - https://finos-lf.slack.com/archives/C01SYB503QT
[ ] FINOS InnerSource SIG Talk: InnerSource Reimbursement Model
Research by Friedrich-Alexander-University Erlangen-Nürnberg (Germany) - 30 mins
[ ] Q&A - 10-15 mins
[ ] Other upcoming talks
[ ] AOB, Q&A & Adjourn (5mins)

Talk Abstract
InnerSource mirrors the Open Source paradigm, providing a free-flowing, unobstructed way of conducting software engineering. Thus, it is being hailed as one of the most promising innovations in software engineering, since it enables collaboration across traditional organizational borders. However, as this fundamentally changes established management and development strategies, there is still contention on how to best adapt to the new way of thinking.
We as MECOIS,  the InnerSource team at FAU Erlangen (Germany) have made it our goal to break down economic barriers to entry and enable the integration of inner source into more traditional workflows. By focusing on quantitative approaches, our aim is to ease transitioning to inner source or to improve existing processes, and to benefit both management and developers alike.
In this talk specifically, we will present our newly-developed “InnerSource Reimbursement Model”, which we've built in collaboration with partners from industry and legislation. This model extends the traditional IT chargeback model and provides clear guidance on how to measure, aggregate, and distribute inner source development cost from code contributor to code user. Using modular building blocks, our approach enables inner source controlling at various levels of granularity - from a pure cost-based view needed for management, to a more holistic and value-added perspective required for tax accounting.
By the end of the presentation, attendees will have a clearer understanding of how they can use our quantitative methods to measure and steer InnerSource processes for a successful integration of Open Source principles in closed organizations.
Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Minutes

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom Details

https://zoom.us/j/97717618541
Meeting ID: 977 1761 8541
Passcode: 878599)

Join by phone
Find your local number: https://zoom.us/u/adJnH9JOiY
Mailing List
Email<EMAIL_ADDRESS>to subscribe to the InnerSource SIG
mailing list.

Chamindra from Citibank 👋

Rob Moffat / FINOS 👋

Dirk Riehle of U of Erlangen; can't stay long sadly (have to listen and grade final student presentations)

Joe Zang | Fannie Mae. Hello all!

Mimi Flynn / Morgan Stanley

Katrina Novakovic - Citi

Adam Mukamal - JPM

Joseph Haire - JPM

Alex Zbarcea - FNMA

Thomas Steeenbergen - Independent


Read SLP files

Add ability to read in SLP files, individual functions for: Video, Instances, Skeleton etc.
to-do: Add comments & tests

moving constructors

Adding test for L178[https://github.com/talmolab/sleap-io/blob/b6a2472fdd91465f35a0614ff30ae056c34f60cb/sleap_io/io/dataset.py#L178] in dataset.py


Text content shows through link modal

On version 3.0.6:

@joostvanhoof hi there - this is now fixed in v3.0.7

Awesome, thanks! I did notice that there is a similar issue with the menu bar. If you have enough content then the menu bar becomes sticky (as expected and this works). When it does, you can not click any of the buttons on the menu bar anymore.

@joostvanhoof this is now repaired in v3.1.2. Laravel Nova frustratingly keeps removing tailwind classes which then have no effect anymore in third party addons like mine.


🐞 [CLI]: dagger functions $function_name returns an error if return type is not a dagger object

What is the issue?
calling dagger functions foo on the following function definition raises the following error:
Error: function 'foo' returns non-object type STRING_KIND
package main

type Testmodule struct{}

func (m *Testmodule) Foo() string {
	return "bar"
}

Dagger version
dagger v0.9.11
Steps to reproduce
run dagger functions foo on the code given above
Log output
Error: function 'foo' returns non-object type STRING_KIND

Oh so this is slightly different than what you originally mentioned in discord (Error: function 'validate' returns non-object type VOID_KIND when the return type was a string).
Error: function 'foo' returns non-object type STRING_KIND is technically expected since there's no functions available on a string. I can sort of see why it might be confusing though. I'll just update the error message to be a bit more explanatory for now if nothing else.

Oh so this is slightly different than what you originally mentioned in discord (Error: function 'validate' returns non-object type VOID_KIND when the return type was a string).

oh! sorry about that! Since I was trying out multiple things, I was actually getting VOID_KIND when the return type of the function is only an error :pray: . Just saw the PR and it's definitely more clear now. Thx for addressing it! :hugs:


Three Rivers Park District Theodore Wirth Request

Description
This PR creates a new folder, follow_up_requests, with one completed request for Three Rivers Park District. The script follow_up_requests/trpd-wirth-home-locations/theodore_wirth_agency_percentages.R aggregates estimated home locations for visitors to Theodore Wirth Regional Park into several regions of interest, such implementing agency boundaries, suburban Hennepin County, etc. The results are written to an excel workbook with a metadata sheet in the same folder.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix
[x] New feature

Courtesy checklist

[x] styler:::style_active_pkg()
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have tagged this PR appropriatley

Hi @eroten! I think this one is pretty straightforward.
One thing to note is that I read the implementing agency boundaries from a shapefile on the N drive (line 58) because I can’t currently connect to GISLibrary through R (issue with my machine, working to get it fixed with IS). Please feel free to change that if you’d rather this use the councilR function to access GISLibrary.
Thanks again for getting this started!

@ravenmcknight  Do you recall how the agency boundaries were created? I'd prefer we have that instead of a full path

@eroten The agency boundaries should be the equivalent of reading the “RegionalParksSystemImplementingAgencies” layer from GISLibrary. I’m just now realizing that this is the only data across the whole repo that would not be accessible to someone outside of the Council, though. Would it make sense to save a copy to data-raw and read it from there? I couldn’t find the agency boundaries on Geospatial Commons or anywhere else public, so I’m not sure about “publishing” it here.

@ravenmcknight, thats a good point. Could we replicate the data manually using the city boundaries and county boundaries? We should be able to use an st_difference() to cut out MPRB and Bloomington from Hennepin County and St. Paul from Ramsey County. That can be done entirely with data from {tigris}, so will be reproducible outside the Council. We would save the code to make the dataset, but not have to save the dataset itself.

@eroten ah yes, I like that! I can put that together a little later today.


fix: use graphql as a dependency to resolve TS type definition problems

Summary
(If you have not already please refer to the contributing guideline as described
here)

[ ] Tell us about the problem your pull request is solving.
[ ] Are there any open issues that are related to this?
[ ] Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! :heart:

Installed!
Installing to /home/travis/.npm/_npx/4883/lib/node_modules/dtslint/typescript-installs/next...
Installed!
Error: /home/travis/build/feathers-plus/feathers-hooks-common/types/tests.ts:307:5
ERROR: 307:5  unnecessary-constructor  Remove unnecessary empty constructor.
at /home/travis/.npm/_npx/4883/lib/node_modules/dtslint/bin/index.js:158:19
at Generator.next ()
at fulfilled (/home/travis/.npm/_npx/4883/lib/node_modules/dtslint/bin/index.js:5:58)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>lint:types: npx dtslint types
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>lint:types script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  Test failed.  See above for more details.
The command "npm test" exited with 1.
Done. Your build exited with 1.

@j2L4e ^^^

Seems unrelated. This can be merged, I'll fix the tests in #489

@PowerMogli thanks! we'll need the @typings/graphql package as a dependency, too

After merging PR#489 and this one, I'm getting this error locally when running npm run test:
Installed!
Error: /home/johnsz/shared/repos/feathers-plus/feathers-hooks-common/types/index.d.ts:6:35
ERROR: 6:35   expect  TypeScript@next compile error:
Cannot find module 'libphonenumber-js'.

/home/johnsz/shared/repos/feathers-plus/feathers-hooks-common/types/tests.ts:70:35
ERROR: 70:35  expect  TypeScript@next compile error:
Cannot find module 'libphonenumber-js'.

    at /home/johnsz/.npm/_npx/5323/lib/node_modules/dtslint/bin/index.js:158:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/johnsz/.npm/_npx/5323/lib/node_modules/dtslint/bin/index.js:5:58)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>lint:types: `npx dtslint types`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>lint:types script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/johnsz/.npm/_logs/2018-12-19T14_00_30_775Z-debug.log
feathers-hooks-common$

@j2L4e could you submit a PR? Thanks.


BUG: in docs, showing "QWIK WARN Serializing dirty task. Looks like an internal error."

So ever since we've changed the headless tabs code we've been getting these error messages:
QWIK WARN Serializing dirty task. Looks like an internal error.
This is coming from the "pause" process in Qwik.
I've added a feature to Qwik so we'll know why this is happenning.
In the meantime, I've debugged it and figure out that when I comment out this function call... the errors goes away
@wmertens have any idea why this call would leave the task in a dirty state?
(my assumption is that it's because we're doing things syncronously, where they are in fact suppose to be async, like signal changing, but I'm not sure)

Closing as this was fixed in qwik 1.7.0 iirc.


Hellow i need work in other models

Hellow i need work in other models Like Anycubic Photon Mono, please!

Hey, pull requests aren't the right way of asking for support/help. If you would like to, please create a topic under Discussions.
That said, I can't help much with Anycubic printers since I don't own any of them.
Thanks for your interest on mariner anyway! :)


Transmitter test fail

Hi,
I tried running go test -v .\appinsights\... but the tests fail with:
# github.com/microsoft/ApplicationInsights-Go/appinsights
appinsights\transmitter_test.go:318:14: Sprintf format %q has arg *result.response of wrong type github.com/microsoft/ApplicationInsights-Go/appinsights.backendResponse
FAIL    github.com/microsoft/ApplicationInsights-Go/appinsights [build failed]
?       github.com/microsoft/ApplicationInsights-Go/appinsights/contracts       [no test files]

Using go version go1.12.7 windows/amd64

Thanks for the heads-up, this regressed in 1.12.  The format string was wrong, but was only used in error messages, so it didn't easily show up.  Fixed with b1df07a.


support parsing datetime format for Synology custom log synocmsclient.log

Problem
Synology DiskStation OS has an unsupported syslog datetime format in file synocmsclient.log
Mon Dec  5 20:31:50 PST 2016
synogpoclientd: not join cms, need not start

Solution
Support the ad-hoc message datetime format.  Add test cases in datetime.rs and comment where they originate.

I thought there was already support for this ad-hoc datetime format.  This needs some investigation.

Fixed in 1e58094eafae95c9c09b35c63aa000a0edfd5845


FromFormAttribute.Name is not accounted for, leading to exceptions or dropped/missing form parameters

Description
Version 6.4.0
For the following action, an error is thrown when generating the swagger document because the Name property on FormFormAttribute is not respected, leading to an attempt by Swashbuckle to add the same Id parameter to the body multiple times.
[Route("test")]
public class MyController : Controller
{
    [HttpPost]
    public virtual IActionResult AddChildItem(
        [FromForm(Name = "Id")] int Id,
        [FromForm(Name = "ChildItem")] Item ChildItem
    )
    {
        return Ok(new
        {
            Id,
            ChildId = ChildItem.Id
        });
    }

    public class Item
    {
        public int Id { get; set; }
        public string Name { get; set; }
    }
}

ArgumentException: An item with the same key has already been added. Key: Id
System.Collections.Generic.Dictionary<TKey, TValue>.TryInsert(TKey key, TValue value, InsertionBehavior behavior)

SwaggerGeneratorException: Failed to generate Operation for action - MyController.AddChildItem (Coalesce.Web.Ko). See inner exception
Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperation(ApiDescription apiDescription, SchemaRepository schemaRepository)

The value of this string on the attribute is surfaced through ApiParameterDescription.ParameterDescriptor.BindingInfo.BinderModelName. It needs to be prepended to the parameter name (with a dot) if present. Unfortunately, a workaround with a custom filter is not possible as the exception is thrown before the filter can even run.
Additional scenarios
The above scenario throws an exception because the parameter don't even differ by case. By changing the controller action's parameters to camelCase, we can prevent the exception, but the resulting OpenAPI document is still incorrect and will result in correct API calls because when FromFormAttribute.Name is set, it is required in the request body but still missing from the corresponding parameters in the OpenAPI document.
    [Route("test")]
    public class MyController : Controller
    {
        [HttpPost]
        public virtual IActionResult AddChildItem(
            [FromForm(Name = "id")] int id,
            [FromForm(Name = "childItem")] Item childItem
        )
        {
            return Ok(new
            {
                id,
                ChildId = childItem.Id
            });
        }
    }

As you can see, childItem.Id is not populated because the OpenAPI doc + request are missing the childItem part of the parameter name:

Also reported to aspnetcore, as I'm not sure if this is expected/intentional that this not be accounted for by ApiExplorer. https://github.com/dotnet/aspnetcore/issues/43815

Ping


Fix time-series merge to correctly handle weekends

The merge method did not set the containsWeekends flag
This caused an exception on building

Thanks for fixing!


UI - Blocked Users status appears as REQUESTED NOW

Issue:
Like the title says, when you block a user their status will change to REQUESTED NOW
OS:
All
STR:
Block a user
Screenshot:

Looks to be related to https://github.com/Satellite-im/Uplink/blob/c0be35f16b3a8ca450f5daa0fe94afcd25c5d375/ui/src/components/friends/friend/mod.rs#L84-L89


Add warnings after patch_sklearn & unpatch_sklearn. Update of documentation

Due to unsolved swap patch problem, I made a decision to reopen this pull request.
My developments about swap patch problem are available here: https://github.com/OnlyDeniko/daal4py/tree/frozen/swap_patch_problem


Change sysconfig_file for Debian/Ubuntu to '/etc/default/named'

This was changed quite a while back, see https://salsa.debian.org/dns-team/bind9/-/commit/6fd962a36bb54e0106e001aff6cce056d54e2526.
Fixes https://github.com/theforeman/puppet-dns/issues/234

@ekohl could you PTAnotherL :-)

@ekohl could you please take another look?

The problem in the tests was that you were confusing the OS family and name facts. You also missed that Debian 11+ has changed it. So I ended up submitting https://github.com/theforeman/puppet-dns/pull/238 for this.


Add SqliteDatasetWriter to store items in sqlite db

OK. I have finally finished the big refactor. I have addressed all the things we talked about and more.
Here is the top summary:

The methods now return result
Errors are mapped to local error struct
Separate into Write and Storage
Dataset reader now automatically figures out how data is stored.
Improved thread safety.
Use PathBuf/Path instead of strings (also makes more portable by not using "/" for directory designation).
Writes to a temporary file and renames to db file after successful write.
Disables journaling and sync for fast writes (at least 3X times faster writes). It's okay for DB is a new and can be recreated if computer crashes.


Change virtualbox DNS address to <IP_ADDRESS>

In that case the guest is assigned to the address <IP_ADDRESS>, the gateway is set to <IP_ADDRESS> and the name server can be found at <IP_ADDRESS>.
https://www.virtualbox.org/manual/ch09.html

Both work for me, but I think <IP_ADDRESS> is correct.

@njam before I commit this, can you give me the backstory on what has led to this PR?  The fix seems benign, so I am thinking we should just commit it.

I just stumbled upon this, while working on something else.
I'm not sure why <IP_ADDRESS> works, but both addresses seem to work equally well:
# dig @<IP_ADDRESS> -p 10053 www.cm.dev.cargomedia.ch
[…|
;; ANSWER SECTION:
www.cm.dev.cargomedia.ch. 0	IN	A	<IP_ADDRESS>

;; Query time: 7 msec
;; SERVER: <IP_ADDRESS>#10053(<IP_ADDRESS>)
;; WHEN: Thu Aug 18 15:17:34 2016
;; MSG SIZE  rcvd: 58

# dig @<IP_ADDRESS> -p 10053 www.cm.dev.cargomedia.ch
[…]
  I am planning to merge #249 on Monday/Tuesday and prep a release.  If this isn't already merged, I will merge it at that time too.

Merged as 1df24371fc98f69f045d054a692be38d2330b32e

Reverting as @hferentschik would like to discuss this further.

agree

we can leave <IP_ADDRESS> as nobody complained so far, and it worked just fine


Fix a typo in DESCRIBE_ROUTE_TABLES_RESPONSE

There are to 'tagSet' nodes in the DESCRIBE_ROUTE_TABLES_RESPONSE, so responses to 'DescribeRouteTables' requests are buggy.

After digging a little deeper, it looks like the problem only affects boto3 client. I've just added two tests (boto and boto3) to validate the fix. The "boto" test always passes, the "boto3" test only passes with the fix.

Great, thanks!