Rename repo & builds

Context
General naming recommendations are continuing to depreciate (and expected to depreciate further) using 'monkeypox'. We likely should replace 'monkeypox' with 'MPXV' (and possibly Mpox in some places). This will require:

[x] Institute redirects for the URLS for all builds

Slack thread
https://github.com/nextstrain/nextstrain.org/pull/712
https://github.com/nextstrain/nextstrain.org/pull/713

[x] Replace all 'visible' links (where we write out URLS for files & similar) in docs & text (such as description)

#165
#169
#171

[ ] Rename the repo (GitHub should take care of redirects as long as a new repo nextstrain/monkeypox isn't created)
[ ] Update files on S3

Slack mention

Lots of progress here - I've updated the task list. @corneliusroemer is there anything else you can think of?

I think that sounds good. Next step would be repo rename? Let's do it one at a time to be able to know what broke it in case something breaks

@corneliusroemer sounds good! Would you be able to do that whenever's good for you to monitor breakage? I'll be signing off soon and will be busy most of tomorrow.

Also, this effort has shifted to use mpox instead of mpxv based on @trvrb's reasoning in Slack:

I prefer mpox mainly because we've tended to use common names for viruses rather than the acronyms, eg ebola rather than ebov, zika rather than zikv, mumps rather than MuV, dengue rather than denv.

Repo rename done by @trvrb (Slack thread).

I updated the task list in the issue description, and I think everything is done here. Please re-open if you notice anything that was missed.


fix typos

Signed-off-by: yupeng<EMAIL_ADDRESS>

Thanks for the PR -- I'm not too picky about the casing in comments so I think it's OK to leave as-is.  Thanks!


ConsentForm performance concerns

Plugin Version

google_mobile_ads: ^5.1.0
We've noticed a heavy delay on Android when fetching the CMP form which varies drastically from newer phones to older phones. iOS and newer phones seem to take the "default" 2 seconds to load and show the CMP form (same for Android simulators). Older phones fare quite worse however...
Using a OnePlus 6 it took close to 5 seconds for the form to show. And using a weaker phone (Ulefone Note 7) it never even shows because the request times out every time after ~10 seconds.
Is loadAndShowConsentFormIfRequired supposed to be such a performance-heavy task? Or are these delays not normal at all?
We tested with multiple CMP forms set up (including Google's sample one) and the performance was the same, so the form itself does not seem to influence the delay, only the phones.
Any idea of what is going on? I can provide the minimal implementation used to test this, but since it only varies from phone to phone, I doubt its value.
Thanks.

Thanks @malandr2, we'll see what we can do from our end.


ALPHA7

Please update to ALPHA7

He already did @NickTehUnicorn

I haven't updated the plugin.yml yet.

this issue appears to be obsolete.


Add Attr.nodeName

Similar to Attr.nodeValue, it's a passthrough to name.
Test added on the web platform side: https://github.com/w3c/web-platform-tests/pull/2590

Nevermind, it's not listed in the spec at all. Seems to be a random webkit thing...

Attr once inherited from Node. That has been changed in the spec and browsers haven't been brave enough to catch up in that regard yet.

:star: TIL! Thanks @Sebmaster, glad to know the story.

Reopened, as it actually was just added to the spec in reaction to my testing PR.


expose kubeconfig ttl setting in harvester

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

Rancher 2.8.x introduced a new setting for kubeconfig ttl. The default value for the setting is 30 days. As a result admin kubeconfig generated from Harvester expires in 30 days since this leverages the embedded rancher.
Solution:

The PR exposes the same kubeconfig ttl setting via harvester, with the harvester value taking precedence over rancher setting.
Related Issue:
https://github.com/harvester/harvester/issues/5874
Test plan:

@bk201 @m-ildefons should we just use this setting to sync both auth-token-max-ttl-minutes and kubeconfig-default-token-ttl-minutes together?

looks like the token ttl in the kubeconfig token is set to the lower of auth-token-max-ttl-minutes and kubeconfig-default-token-ttl-minutes. I have tested the following scenarios:

scenario 1: auth-token-max-ttl-minutes is 10mins and kubeconfig-default-token-ttl-minutes is 0mins.
The resulting kubeconfig token has ttl set to 10 mins and does stop working at 10 mins

apiVersion: management.cattle.io/v3
authProvider: local
current: false
description: Kubeconfig token
expired: false
expiresAt: ""
isDerived: true
kind: Token
lastUpdateTime: ""
metadata:
  creationTimestamp: "2024-06-05T01:37:08Z"
  generateName: kubeconfig-user-9lj8c
  generation: 1
  labels:
    authn.management.cattle.io/kind: kubeconfig
    authn.management.cattle.io/token-userId: user-9lj8c
    cattle.io/creator: norman
  name: kubeconfig-user-9lj8c88r4c
  resourceVersion: "1266865"
  uid: 1edfc983-31dd-419b-9a3e-b905947feb1c
token: -----
ttl: 600000
userId: user-9lj8c
userPrincipal:
  displayName: Default Admin
  loginName: admin
  me: true
  metadata:
    creationTimestamp: null
    name: local://user-9lj8c
  principalType: user
  provider: local

scenario 2: auth-token-max-ttl-minutes is 0mins and kubeconfig-default-token-ttl-minutes is 90mins.
The resulting token has a ttl of 90mins

apiVersion: management.cattle.io/v3
authProvider: local
current: false
description: Kubeconfig token
expired: false
expiresAt: ""
isDerived: true
kind: Token
lastUpdateTime: ""
metadata:
  creationTimestamp: "2024-06-05T01:57:07Z"
  generateName: kubeconfig-user-9lj8c
  generation: 1
  labels:
    authn.management.cattle.io/kind: kubeconfig
    authn.management.cattle.io/token-userId: user-9lj8c
    cattle.io/creator: norman
  name: kubeconfig-user-9lj8c5mrxc
  resourceVersion: "1282860"
  uid: a81ff594-3766-4bfc-b474-0b48fddbf034
token: -----
ttl: 5400000
userId: user-9lj8c
userPrincipal:
  displayName: Default Admin
  loginName: admin
  me: true
  metadata:
    creationTimestamp: null
    name: local://user-9lj8c
  principalType: user
  provider: local

scenario 3: auth-token-max-ttl-minutes is 0mins and kubeconfig-default-token-ttl-minutes is 0mins.
The resulting token has a ttl of 0, which is the desired result.

apiVersion: management.cattle.io/v3
authProvider: local
current: false
description: Kubeconfig token
expired: false
expiresAt: ""
isDerived: true
kind: Token
lastUpdateTime: ""
metadata:
  creationTimestamp: "2024-06-05T02:07:09Z"
  generateName: kubeconfig-user-9lj8c
  generation: 1
  labels:
    authn.management.cattle.io/kind: kubeconfig
    authn.management.cattle.io/token-userId: user-9lj8c
    cattle.io/creator: norman
  name: kubeconfig-user-9lj8cvnqmc
  resourceVersion: "1290901"
  uid: 7f1c510c-fd25-467d-a12a-bc831caa9444
token: --
ttl: 0
userId: user-9lj8c
userPrincipal:
  displayName: Default Admin
  loginName: admin
  me: true
  metadata:
    creationTimestamp: null
    name: local://user-9lj8c
  principalType: user
  provider: local

I was more in favour of always keeping both in sync. The proposal was to keep the default to 0, as anything else would be a change from current behaviour.

We need to document that behaviour somewhere that the HARV UI will modify kubeconfig-default-token-ttl-minutes and auth-token-max-ttl-minutes when the setting is changed, otherwise it will be confusing for the user.

@mergifyio backport v1.2 v1.3


Fix removal of mediaelement when native controls are used

If native controls are used on iPhone, iPad or Android devices,
t.container is never set, thus it can not be used. However the video
player title isn't built in that case and does not need to be removed.
Without this fix, calling .remove() on the mediaelement leads to an
error message on iPad, iPhone and Android if the native controls are
used.

Thanks for the new PR. Merged now


Installation issues

There's still a few installation niggles:

[x] the gallery.yaml file needs to be manually copied into site-packages. The best way to solve this might be through package data? Addressed in PR #13 .
[x] the installation of the tljh-voila-gallery package does not currently install the package. Addressed in PR #9.
[ ] dockerspawner is only installed after hub has started running. This requires running sudo systemctl restart jupyterhub after dockerspawner has been installed.
[x] the build-images script still needs PyYaml -- this should be removed in favour of ruamel.yaml. Addressed in PR #12 .
[ ] we could create the build-images systemd service as a post-install step.

As of now, running the following commands brings up a fully working system:
git clone https://github.com/jupyterhub/the-littlest-jupyterhub.git
git clone https://github.com/voila-gallery/gallery.git
cd ~/the-littlest-jupyterhub/
sudo python3 bootstrap/bootstrap.py --plugin /home/ubuntu/gallery/tljh-voila-gallery/
sudo systemctl restart jupyterhub  # restart with dockerspawner
sudo /opt/tljh/hub/bin/build-gallery-images

once #17 is merged you don't need the restart anymore.

The two remaining points (restart and build-images systemd service) have now been added.


RDP-Wrap disabled by Windows Update KB4088876

Since the forementioned Windows-Security-Update on Windows 8.1 RDPconfig tells "not supported". The current workaround ist to desinstall the update and disable it on the Update-List. Therefore, the code for the trmsvr.dll should be updated.

Which termsrv.dll version?

Same here, win8.1, listener not supported
termsrv.dll version 6.3.9600.18928

Duplicate of #418.

We are uninstalling this patch from all twenty of our Server 2012 r2 RTDS servers. It is causing random servers to freeze and nobody can get in until the offending server is rebooted.


Update TemplateLiteralMatch to include source importPath and importIdentifier

Problem
As we continue to flesh out the shared usage of this library amongst various community tooling, I realized that in order to handle the different types of recompilation that the caller has to call parseTemplates multiple times in order to know how each template needs to be processed.
For example, when ember-template-lint processes inline templates, it will need to know if a given template should be considered "strict mode" or "loose mode" in order to enable the right set of template linting rules (e.g. no-implicit-this).  Right now, in order to do that ember-template-lint would have to process the same file twice:
const strictTemplates = parseTemplates(someJsFileContents, 'app/components/foo.hbs', {
  templateLiteral: [
    { importPath: 'ember-template-imports', importSpecifier: 'hbs' }
  ]
});
const looseTemplates = parseTemplates(someJsFileContents, 'app/components/foo.hbs', {
  templateLiteral: [
    { importPath: 'ember-cli-htmlbars', importSpecifier: 'hbs' }
  ]
});

Solution
Concretely, I think we should update the TemplateLiteralMatch to include the importSpecifier and importPath that they came from.
https://github.com/ember-template-imports/ember-template-imports/blob/8acb56937008a2e55807ba6f9f21146a5ccda058/src/parse-templates.ts#L13-L18
Should become:
export interface TemplateLiteralMatch {
  type: 'template-literal';
  tagName: string;
  start: RegExpMatchArray;
  end: RegExpMatchArray;
  importPath: string;
  importSpecifier: string;
}

This would allow ember-template-lint to all parseTemplates one time, and process each of the templates we find appropriately.

Closed by #47


Add deps, wallet and balance activities

Add assets, manifest, dependencies, wallets list, wallet and balance pages.
JNI Library needs to manually compiled and import in the project, for now.

Tested locally, ACK!


[WIP] Support subscriptions

TODO

[ ] Documentation
[x] Validation (require async iterables for root subscription fields, prevent their use elsewhere)
[x] Unit tests validating above validation
[ ] Integration tests for all servers that support subscriptions (all of them?)
[x] Consider how we feel about adding yet more directives to the schema

https://github.com/captbaritone/grats/assets/162735/6a072806-3fc9-49e2-aade-954cb8d4fa7d

Integration tests ended up being too fiddly to figure out.


Create proxy package

Create a package to interract with openai or equivalent
Create a package to interract with kube-apiserver
Think about a way we could transform LLM respones into kubecommands/http requests

Hey @a-hilaly why do you need to proxy openai instead of calling the REST endpoint / using the client package?


Add information about localisation in contributing.md

Summary of the Pull Request
Adds a section about localisation in the contributing.md file.
PR Checklist

[x] Closes: #21784

Nice and simple. Good to have. Any chance #15243 could be done too?

Nice and simple. Good to have. Any chance #15243 could be done too?

I tried having a look at it, but I understand too less of how it is made now to update it.

@crutkas This is ready for review

LGTM! Merging as all comments are addressed. Thanks for the contribution!


Use service account token inside build pod

This allows authentication to OpenShift from within the build pod, by looking for the /var/run/secrets/kubernetes.io/serviceaccount path and using it if available.
It only does so if use_auth is not set to False and no other authentication credentials have been supplied.
This behaviour can be explicitly enabled or disabled by setting builder_use_auth = false in the configuration file.
Why might you explicitly enable it? For instance, if the only authorized users use client certificates (so use_auth must be off), the plugins will need to authenticate and the only way they can do so is by enabling builder_use_auth.
Why might you explicitly disable it? For instance, if the osbs-client version installed in the buildroot image is older than this pull request merge, plugins will not be able to authenticate without additional authentication credentials.

Looks good and seems to work fine, merging.


[bug] Fix tracer resource tag for create_hash_returning_id

Currently, the resource tag for create_hash_returning_id looks like Redcord:ModelName which is affecting the grouping on other resources. This fixes the issue.

Codecov Report

Merging #83 (32dd4da) into master (b7326e2) will decrease coverage by 2.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   96.86%   94.43%   -2.43%
==========================================
  Files          32       32
  Lines        1688     1688
==========================================
- Hits         1635     1594      -41
- Misses         53       94      +41

Impacted Files
Coverage Δ

lib/redcord/redis.rb
92.94% <ø> (-7.06%)
:arrow_down:

lib/redcord/relation.rb
88.54% <0.00%> (-10.42%)
:arrow_down:

spec/relation_spec.rb
92.85% <0.00%> (-7.15%)
:arrow_down:

lib/redcord/attribute.rb
94.18% <0.00%> (-4.66%)
:arrow_down:

spec/actions_spec.rb
86.08% <0.00%> (-3.61%)
:arrow_down:

spec/migration/index_spec.rb
96.82% <0.00%> (-3.18%)
:arrow_down:

spec/custom_index_spec.rb
96.94% <0.00%> (-3.06%)
:arrow_down:

spec/serializer_spec.rb
97.00% <0.00%> (-3.00%)
:arrow_down:

lib/redcord/actions.rb
94.57% <0.00%> (-0.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7326e2...32dd4da. Read the comment docs.

update: only trace at the action/relation level to avoid spliting model_names
:mag_right: Click to see changes since last update.


nil tag/field values may cause panic

User report: "the issue was in attempting log a pointer field when its value is nil, causing a nil dereference."
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x45fbd8]

goroutine 103 [running]:
.../jaeger-client-go.ConvertLogsToJaegerTags(0x0, 0x4, 0x4, 0xc424f50c20, 0x3, 0x3)

I'll take a look at this error and report back.  Was there a reproducer by any chance?

The only way to pass nil as a log field seems to be via this OpenTracing method:
// Object adds an object-valued key:value pair to a Span.LogFields() record
func Object(key string, obj interface{}) Field {
	return Field{
		key:          key,
		fieldType:    objectType,
		interfaceVal: obj,
	}
}

Unfortunately I'm not able to reproduce; I've tried various OpenTracing methods to log nil fields to no avail.  Simplest reproducer:
	type testStruct struct{}
	var testNil testStruct
	sp.LogFields(log.Object("test", &testNil))

	var testArr []string
	sp.LogFields(log.Object("test", &testArr))

Output:
2018/03/05 00:12:52 Initializing logging reporter
2018/03/05 00:12:52 Reporting span 635f8eb17725855f:635f8eb17725855f:0:1

I encountered similar situation on our Jenkins CI, which is running the code in the Docker in Docker mode. In our application, we use span.LogKV and except for one single use case, where we use Go stdlib Time struct, everything is just string type. During the build, I don't expect any spans to be collected, as we are not running jaeger agent next to our code. The global tracer is set up practically as following.
cfg := jaegercfg.Configuration{}
closer, err := cfg.InitGlobalTracer(serverName)

Once I removed this logging, I wasn't seeing the panic anymore We are using Bazel (0.5.3) with Go locked on 1.8.3.
 Basically matching @rsyed83 findings.
I will post more findings later today.

After changing the Time struct to Time.String(), I am seeing
2018/03/15 12:55:43.834593 identity-api(108): panic: runtime error: makeslice: cap out of range
2018/03/15 12:55:43.834607 identity-api(108):
2018/03/15 12:55:43.834612 identity-api(108): goroutine 50 [running]:
2018/03/15 12:55:43.834618 identity-api(108): github.com/uber/jaeger-client-go.ConvertLogsToJaegerTags(0x726f662d736e6f69, 0x6e6574746f67, 0x0, 0xc42165d3e0, 0x6, 0x6)
2018/03/15 12:55:43.834623 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/jaeger_tag.go:29 +0x6f
2018/03/15 12:55:43.834628 identity-api(108): github.com/uber/jaeger-client-go.buildLogs(0xc421467d70, 0x2, 0x1, 0xc421715040, 0xa, 0xa)
2018/03/15 12:55:43.834633 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/jaeger_thrift_span.go:73 +0x126
2018/03/15 12:55:43.834637 identity-api(108): github.com/uber/jaeger-client-go.BuildJaegerThrift(0xc42165f590, 0x1a2a940)
2018/03/15 12:55:43.834642 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/jaeger_thrift_span.go:40 +0xd7
2018/03/15 12:55:43.834646 identity-api(108): github.com/uber/jaeger-client-go.(*udpSender).Append(0xc4200e78c0, 0xc42165f590, 0xc42003df10, 0x1, 0x0)
2018/03/15 12:55:43.834650 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/transport_udp.go:90 +0x4a
2018/03/15 12:55:43.834655 identity-api(108): github.com/uber/jaeger-client-go.(*remoteReporter).processQueue(0xc4200f38b0)
2018/03/15 12:55:43.834659 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/reporter.go:273 +0x1f6
2018/03/15 12:55:43.834664 identity-api(108): created by github.com/uber/jaeger-client-go.NewRemoteReporter
2018/03/15 12:55:43.834668 identity-api(108): 	vendor/github.com/uber/jaeger-client-go/reporter.go:209 +0x239```

can you provide a complete example that reproduces this?

I also encountered this problem. This should not be a problem with the library, have you use span.LogKV/LogFields after span.Finish called

@yurishkuro If someone can guide in reproducing this, I can fix this.

@VineethReddy02 there may be several issues reported here, it's hard to tell, since nobody actually provided a reproducable example. From the initial description it seems like sp.LogFields(log.Object("test", nil)) might be causing a panic.

Current logic
func (s *Span) LogFields(fields ...log.Field) {
	s.Lock()
	defer s.Unlock()
	if !s.context.IsSampled() {
		return
	}
	s.logFieldsNoLocking(fields...)
}

Proposed logic
func (s *Span) LogFields(fields ...log.Field) {
   if fields != nil {
	s.Lock()
	defer s.Unlock()
	if !s.context.IsSampled() {
		return
	}
	s.logFieldsNoLocking(fields...)
  }
}

As am unable to produce the issue and validate. It's just a wild guess @yurishkuro & log.Object() is part of opentracing dependency
Any suggestions?

Have you tried a unit test with sp.LogFields(log.Object("test", nil))? There's no point in guessing the solution if we cannot reproduce the problem.


Old link redirect isn't really working

Some of the older links that are being "redirected" via the Ember app, like

http://www.ember-cli-mirage.com/docs/v0.4.x/manually-starting-mirage

aren't really working. Need to figure out a better solution (e.g. statically rendering 302 pages in those directories).

Gonna ignore this for now.
I wanted to set up proper redirects because some link-checking tool was reporting these old URLs as invalid, since the redirect is done by JavaScript. My idea was to switch it to using a <meta http-equiv="refresh"> tag, but that's still only respected by browsers, so I'm not sure it would help tools like that link checker.
Ideally we'd be able to set up server-side redirects but we can't on GH Pages (unless we were using Jekyll).
Gonna stick with the current implementation for now, but if anyone knows a better way please let me know!


Unify handling of color

Is your feature request related to a problem?
We have what appears to be a free for all in the way different classes handle/manage color as briefly touched on here, https://github.com/visit-dav/visit/pull/5205#issuecomment-720763011.
This should probably be cleaned up to use the same, consistent representation and storage for color everywhere. I would recommend that internally in VisIt, we represent colors as double[5] where first 3 are RGB, 4th is Alpha and 5th, when needed, is position (as in color control point) and where all values are in the range [0...1]. We should leave that model only to interact with the outside world (VTK, GL, Qt, etc.). This design would have downsides only in cases where we'd expect to handle very large (e.g. millions of entries) arrays of colors. Even in the most elaborate color tables, I can't myself imagine any cases with more than a few thousand colors. So, I don't think this would ever be an issue.

@biagas you mentioned something about unifying the way we handle colors and it reminded me we have this issue about that.


BlockingKnotProxy / BlockingAdapterProxy

Some APIs we integrate with provide only sync methods. It means that we need to use blocking operations in our Knots and Adapters. This task should provide some kind of template how to write our modules correctly.

Adapter: https://github.com/Cognifide/knotx/pull/341/files


Allow defining multiple services per cadl file

Right now we assume in a few places (getAllRoutes, getServiceNamespace) that only a single service is defined per cadl compilation. I don't believe this restriction is justified and it can be useful to define multiple services in a single cadl. An example scenario is defining an app that has two function app endpoints, or a function app and an app service with different APIs.

Seems related to https://github.com/microsoft/cadl/issues/678 ?

Potentially, although the same server can be described through different @server endpoints

Actions:

make getServiceXYZ allow multiple
getAllRoutes takes in which service namespace
rename @serviceTitle (deprecate) and others in @service decorator
[More design] solve importing a service to get types but not take all the service description(don't want to gen service)

Notes from design meeting
@serviceTitle("FrontEnd")
@openapi  // in "@cadl-lang/openapi"
@client
namespace MyOrg.FrontEnd {

}

@service({title?: string })
@serviceTitle("InternalBackEnd")
@openapi
@useHttp
@azureFunctions({AppServicePlan: "foobar"})
namespace MyOrg.InternalBackEnd {

}

@grpc.package
namespace MyOrg.Foo {

}

// in sidecar.cadl
@@openapi(FrontEnd)


[DE-255] Re-enable Facebook Marketing relationships tests, tweak filter criteria

These tests were hotfix disabled when deploying to prod, because there were failures on prod data that we didn't experience when running against dev.
There seem to have been some inconsistencies with how airbyte applied date filters across certain models, so there might be records in the ads table that don't have corresponding campaigns in the campaigns table. To handle this, I've filtered most of the tests on created_time to match the airbyte connection settings grabbing data from 2022 and beyond. There are a couple of insights tables that have stats generated for old ads/campaigns (all 0 spend, 0 impressions) and I've filtered those out too.

ok @emily-flambe! I went ahead and made some of our test configs more consistent, and added (and documented) some thresholds to filter out our very strange edge cases. lmk what you think!


encode physical section URLs

pid_to_eml_physical automatically generates download URLs from the pid. These should be URL encoded, which is congruent with what metacatUI does (see https://github.com/NCEAS/metacatui/issues/523).

@jeanetteclark asked me to take a quick scan and I found three spots to update:
https://github.com/NCEAS/arcticdatautils/blob/master/R/eml.R#L106:L106
https://github.com/NCEAS/arcticdatautils/blob/master/R/eml.R#L1150:L1150
https://github.com/NCEAS/arcticdatautils/blob/master/R/eml.R#L106:L106
I looked for:

Calls to EML::set_physical
Strings with "cn/v2", "resolve", and "object"

assigning this issue to myself in comments because I don't have the permission to


ion-nav api improvements and make howto

The current ion-nav implementation in the demo app is a bit too boilerplate.
Needs refactoring with a separate component, that also allows the user to access the ion-nav methods.
Next, a howto project is recommendable for developers to understand the API in svelte

https://github.com/Tommertom/ionic-svelte-nav-howto


Deprecation annotation not working without deprecation reason

Description:
According to graphql spec depreciation reason is optional for @depricated directive.
Deprecation annotation not working without deprecation reason.
Steps to reproduce:
import ballerina/graphql;

@graphql:ServiceConfig{
    cors: {
        allowOrigins: ["*"]
    },
    graphiql: {
        enabled: true
    }
}
service /a on new graphql:Listener(9000) {
    // not working
    @deprecated
    resource function get greet() returns string {
        return "hi";
    }

    // but this works
    # # Deprecated
    @deprecated
    resource function get greet2() returns string {
         return "hi";
     }
}

Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

# # Deprecated
@deprecated
resource function get greet2() returns string {
     return "hi";
}

I think this is the correct way to use the @deprecated directive without a reason according to the spec. Even if we use deprecated directive like this, It's not showing as a deprecated field in GraphiQL client. But it works in Playground. Seems like a bug in GraphiQL client.
Consider the following:
service /a on new graphql:Listener(9000) {
    # # Deprecated
    # please use the `greet2`
    @deprecated
    resource function get greet() returns string {
        return "hi";
    }

    # # Deprecated
    @deprecated
    resource function get greet2() returns string {
         return "hi";
     }
}

In GraphiQL:

In Playground:

It seems this is the correct way to use the @deprecated directive without a reason according to the spec. @ThisaruGuruge can you confirm this?

Consider this:
@deprecated
resource function get greet() returns string {
    return "hi";
}

I think the Ballerina language does not support deprecating without the doc comment like this. The way is the one @DimuthuMadushan mentioned.
But I think we should be able to mark it as deprecated without the reason. No point in defining the doc comment, if we don't want to add a reason. @MaryamZi any thoughts?

BTW, Even if we use deprecated directive like this, It's not showing as a deprecated field in GraphiQL client. But it works in Playground. Seems like a bug in GraphiQL client.

Yes, this might be a bug in GraphiQL. Shall we check this with them?

Checked this again. It seems like there's no issue form the lang or the GraphQL package in Ballerina. Even when we don't have a deprecation documentation, the Ballerina compiler issues a warning, but still works as expected.
The introspection query works as expected and returns the field as deprecated, even though we don't have a deprecation reason.
I think the issue is with the client tools where they do not identify fields without deprecation reason as deprecated. Let's check this with the tooling communities. Closing the issue since this isn't a bug in our side.


mbar

Do I understand correctly that mbar is a UCUM code for millibar? mbar shows up in a mapping here, but fails if entered as a code at https://units-of-measurement.org/

Some other things I ran into int the 15 units used in my data set:

rpm (rounds per minute)- doesn't seem to be defined by UCUM, equivalent to, I think, 2.[pi].rad.min-1 . That doesn't resolve, BTW.
Gigabyte and Gibibyte didn't resolve
millbar is the link I tried for mbar.
I had pixels as a unit, and see that {} syntax isn't yet supported. A vote for that... Just to check, if supported it would be pixels ?

Sorry @alanruttenberg for the slow response. see #40 for the explanation for this issue. We are aware and will fix it in due time.
As for the other units thank you for bringing them to our attention I'll make sure to tackle each of them when I have time to dedicate to this again.


Verbiage clean-up in tutorials

Tutorials need a review and updates, the verbiage can be confusing.

We have removed comments from the source code, or are planning to remove any comments that may linger. In general during this devise upgrade, we're cleaning up tutorials so its not really an "issue" anymore so much as part of our to-do list on another effort.


change deadname and update twitter

uh oh, that was definitely in need of updating! thanks for the PR 👍


[Operation Question] How to separate truncation and matmul operations

Issue Type
Support
Modules Involved
MPC protocol, SPU runtime
Have you reproduced the bug with SPU HEAD?
Yes
Have you searched existing issues?
Yes
SPU Version
spu 0.9.0b1
OS Platform and Distribution
Linux Ubuntu 22.04
Python Version
3.11.5
Compiler Version
No response
Current Behavior?
I'd like to do some latency testing for multiplication and truncation operations. Here is a short overview of how it would look:
Input x and weight y are represented using 16 bits fixed point each. Therefore, when you do a multiplication, you expect them to have 32 bits representation in fixed point. However, suppose you have a ring size of 64 bits. You could then do another 32 bits * 32 bits multiplication before overflowing your ring size of 64 bits.
How can I do this in secretflow? In particular, I want to be able to control the fixed point representation size of each input to the matrix multiplication, and only truncate after specific multiplications (not every multiplication).
Thank you for your help!
Standalone code to reproduce the issue
N/A

Relevant log output
N/A

Hi @wilyub
I don't think you could seperate matmul and truncate in Python bindings of SPU. You may have to dive into kernels of SPU runtime.

I would suggest having a look at https://github.com/secretflow/spu/blob/main/REPO_LAYOUT.md.

@wilyub To bench the matmul only without the truncation, we can use "integer" matrix instead of the floating point matrix.

Thanks for the update, I'll take a look at integer containers. Another thing that has been confusing me is benchmarking the time for softmax/silu/division, etc... From my reading of the literature (Puma, CipherGPT, etc..) these operations should introduce a high latency cost because they require a lot of communication. However, in my tests it seems like these operations do not add significant time to the end to end runtime of one layer in a transformer model? It seems like the largest amount of latency is attributed to the matrix multiplications instead.
I've added a screenshot of my log when I benchmarked one layer of Llama7B. The nonlinearities are implemented in jax (jax.nn.softmax and jax.nn.silu). However, as you see in the log, the vast majority of the time spent is on the mmul_aa operation (I assume this is matrix multiplication). Any idea if I've messed something up here?
Note: I'm using SEMI2K with FM64. I also did some 3PC testing with ABY3 (also FM64) and saw similar results.

@Ye-D

Please let me know if you find anything out about the above nonlinearities issue. I can also provide my code if it helps with reproducability (although like I said earlier, I just used the out of the box jnn.softmax() and jnn.silu() alongside some matrix multiplications).
One other thing that has been weird for me is the matmul benchmark. I tried two tests. One of them I did a matrix multiplication for the value weight matrix and the hidden states. (Only one matmul call). In the other test I did that matmul in addition to a matmul for hidden states and key weight matrix, and hidden states and query weight matrix. (Three matmul calls). However, the logs show the latency for the matmul to be nearly identitcal. Even weirder, the number of bytes sent/received are exactly the same. This sounds weird to me because I would expect matmul time to be tripled if we call three matmuls? I have sent a snapshot of my log and for the code.

both query_states and key_states are unused values, so matmuls defining them are dead code and should be killed during optimizations.


Sliderbar

Even if we don't have this exactly match the style we want to have in the long run, I think it would be worthwhile to have this code implement a knob type of thing, since I know we'll eventually want to have that (i.e. the circle in the middle that you drag around).

If you're receiving a bindable, the bindable has the min/max (range) built-in. You should use this where possible.

Can we rename the class to SliderBar?


chore(deps): upgrade jenkins-x/jx3-versions to version 1.1.20

from: https://github.com/jenkins-x/lighthouse.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test kube

gsm
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test kube

gsm
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test gsm

vault
93dc62a98f22b23136dc98bd51e53e6ac07b3988
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


NextUpdate trigger "hangs" at -85secs

I noticed some strange behaviour of the NextUpdate trigger, which seems to "hang" at -85secs, irrespectively of being stationary in a zone or on the move.
Per screenshot below, Pina left the office at 05.44.35pm, causing the zone to change from "Office Pina" to "Away" until being home at 05.:53:45pm. In between, she was 250km away(?) and the Next update trigger started a count-down when she left the office starting at +29secs every 5secs until -85secs and stopped there. While driving, it all of a sudden jumped to 05:51:10pm to be the next update and then looped again from +29secs to -85secs before arriving home.

Logfile:

Any idea what I configured wrong, or is it a bug in b13? Thx for your help. Cheers, Mike

Lets see if this happens again in b14. At some time, I've seen that from time-to-time myself and it always/seems to correct itself.


Fix: path for async

Changed paths to have /ngsi-ld/v1
Removed user_id from response of /async/status

Can one of the admins verify this patch?

test this please

test this please


Cosmos Spark - switching to reflection instead of bridge-approach to avoid SecurityException when installing connector by directly copying into /databricks/jars folder

Description
When deploying the Connector in Databricks by copying it directly into /databricks/jars folder instead of using the Databricks API or UI to install the connector a SecurityException (see below) would be thrown for write operations.
java.lang.SecurityException: class "org.apache.spark.SparkInternalsBridge$"'s signer information does not match signer information of other classes in the same package

This PR switches from using a bridge-approach to using reflection. It also allows opting-out of providing custom metrics in case there are any issues with using the reflection code. And for any reflection related failures custom metrics will simply be suppressed.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - cosmos - spark

/azp run java - cosmos - spark

/azp run java - cosmos - spark


Basic Creation and insertion predefined ads tests

This patch creates a basic creation and insertion tests for the predefined ads.

Coverage increased (+41.86%) to 61.47% when pulling d0cbc1ad3e945daa4efd1764e4b743c2a05dabd0 on development_interstitialTests into ba42607b73839a5bbc197b8b7fb7944d386b167d on development.


reading pem ocsp response

i have such simple code
#include <openssl/x509.h>
#include <openssl/x509v3.h>
#include <openssl/ssl.h>
#include <openssl/ocsp.h>
#include <openssl/pem.h>
#include <openssl/asn1.h>

int main() {

	PEM_read_bio_OCSP_RESPONSE(NULL, NULL, NULL);
	return 0;

}

at complile i have warning's
test.c: In function 'main':
test.c:10:2: warning: passing argument 1 of 'PEM_ASN1_read_bio' from incompatible pointer type [-Wincompatible-pointer-types]
  PEM_read_bio_OCSP_RESPONSE(NULL, NULL, NULL);
  ^
In file included from /usr/include/openssl/ssl.h:162:0,
                 from test.c:3:
/usr/include/openssl/pem.h:407:7: note: expected 'void * (*)(void **, const unsigned char **, long int)' but argument is of type 'char * (*)()'
 void *PEM_ASN1_read_bio(d2i_of_void *d2i, const char *name, BIO *bp, void **x,
       ^
test.c:10:2: warning: passing argument 4 of 'PEM_ASN1_read_bio' from incompatible pointer type [-Wincompatible-pointer-types]
  PEM_read_bio_OCSP_RESPONSE(NULL, NULL, NULL);
  ^
In file included from /usr/include/openssl/ssl.h:162:0,
                 from test.c:3:
/usr/include/openssl/pem.h:407:7: note: expected 'void **' but argument is of type 'char **'
 void *PEM_ASN1_read_bio(d2i_of_void *d2i, const char *name, BIO *bp, void **x,

so i can't build my project with -Werror, but it's very important to do it.
maybe in will be better to use IMPLEMENT_PEM_rw for implemeting this functions?
or change implementation of https://github.com/openssl/openssl/blob/243ecf19ddc0dc2366de1be5c404d66d483b196d/include/openssl/ocsp.h#L125 this macros to smth like this
return (OCSP_RESPONSE *)PEM_ASN1_read_bio((void * (*)(void **, const unsigned char **, long int))d2i_OCSP_RESPONSE, PEM_STRING_OCSP_RESPONSE, b, NULL, NULL , NULL);

We currently do not support -Wincompatible-pointer-types  It would be nice to do this in a future release.


[file] commit response returns size as a float

Package version (if known): november release
After committing file upload, I get:
{
    "mimetype": "image/jpeg",
    "status": "completed",
    "bucket_id": "1ac3d7d9-1302-4b93-bb30-9b16dabbca0f",
    "links": {
        "self": "https://<IP_ADDRESS>:5000/api/records/b0tr1-x3r31/draft/files/leaf_doge.jpg",
        "commit": "https://<IP_ADDRESS>:5000/api/records/b0tr1-x3r31/draft/files/leaf_doge.jpg/commit",
        "content": "https://<IP_ADDRESS>:5000/api/records/b0tr1-x3r31/draft/files/leaf_doge.jpg/content"
    },
    "updated": "2020-12-01 20:23:41.808082",
    "file_id": "1c30c558-0610-4873-9c5b-169f5424754e",
    "key": "leaf_doge.jpg",
    "created": "2020-12-01 19:56:38.159707",
    "checksum": "md5:f609873ed7e830497933ed9e4838634c",
    "version_id": "ac99a2c8-0cc3-440d-bacf-de58aac2f53f",
    "size": 955828.0,
    "storage_class": "S",
    "metadata": null
}

where size has a decimal point. That shouldn't be the case.

https://github.com/inveniosoftware/invenio-records-resources/blob/master/invenio_records_resources/services/files/schema.py#L35 The schema sets it as Number, should be Integer.

https://github.com/inveniosoftware/invenio-records-resources/blob/master/invenio_records_resources/services/files/schema.py#L35 The schema sets it as Number, should be Integer.


[TF 2.0 API Docs] Edited Documentation to tf.dtypes.cast

Fix #29210 by changing example to tf.dtypes.cast.

@kooock can you please sign CLA.

I signed it!


databricks-sdk dependency

Hey, what is the reason for using such a lower version(0.17.0), do u plan to update to the latest? Since we are also using project that conflicts with your version of databricks-sdk.

We're working on it; semi-blocked by trying to get them to integrate this PR: https://github.com/databricks/databricks-sdk-py/pull/823


tf.get_collection to extract variables of one scope

Hi,
I have n(e.g: n=3) scopes and x (e.g: x=4) no of Variables defined in each scope.
The scopes are:
    model/generator_0
    model/generator_1
    model/generator_2

Once I compute the loss, I want to extract and provide all the variables from only one of the scope based on a criteria during run-time. Hence the index of the scope idx that I select is an argmin tensor cast into int32
    <tf.Tensor 'model/Cast:0' shape=() dtype=int32>

I have already tried:
    train_vars = tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES, 'model/generator_'+tf.cast(idx, tf.string))

which obviously did not work.
Is there any way to get all the x Variables belonging to that particular scope using idx to pass into the optimizer.
Forgive me if this question doesnt fit into tensorflow issues.
Thanks in advance!
Vignesh Srinivasan

@yaroslavvb : I have posted it there now.
http://stackoverflow.com/questions/42073239/tf-get-collection-to-extract-variables-of-one-scope

Thanks @yaroslavvb!


Feature request: Support for IMAP "public folders"

At the moment, K9 seems to only show folders under the user. IMAP subtree, i.e. the user's mailbox.
Public folders are folders above the IMAP user.* subtree to which users may have access to or not. Additionally, it's not uncommon that users have access to other users' mailboxes, role accounts like "webmaster", "postmaster", "root", etc. being some common examples.
It would be quite nice and useful if every folder a user has access rights to would show up in the folder list in K9.

Duplicate of #1342


build: Fix path to go-to-protobuf binary

Avoid error like the following:
+ go install k8s.io/code-generator/cmd/go-to-protobuf
+ go-to-protobuf --go-header-file=./hack/custom-boilerplate.go.txt --packages=github.com/argoproj/argo/pkg/apis/workflow/v1alpha1 --apimachinery-packages=+k8s.io/apimachinery/pkg/util/intstr,+k8s.io/apimachinery/pkg/api/resource,k8s.io/apimachinery/pkg/runtime/schema,+k8s.io/apimachinery/pkg/runtime,k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/api/core/v1,k8s.io/api/policy/v1beta1 --proto-import ./vendor
./hack/generate-proto.sh: line 12: go-to-protobuf: command not found
make: *** [Makefile:281: proto] Error 127

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.
[x] My organization is added to USERS.md.

Is this the only problem?

@alexec For now yes. This is unrelated to the codegen build failure observed on master branch though.

@alexec This has been rebased and build is passing as well.


HTMLInfoWindow is not clickable if map-page gets loaded via navCtrl.setRoot

Branch: multiple_maps (v2)
This is a Ionic 3 App Scenario:
If you load the map directly on the homescreen, everything works fine.
If you go into the map-page via menu (navCtrl.setRoot), map is loading, markers are displayed, you can click any marker, but the InfoWindow's click-handler does not get executed then. Instead I think the click is passed through to the map (because InfoWindow disappers and you can drag the map).
Chrome Dev-Tools can click the HTMLInfoWindow and the handler executes correctly.

I'm not familiar with ionic at all. But as I said couple of times (and as you may know), HTMLinfoWindow just adjusts the position of your contents.

Ah , I guess you use the click handler of ionic(angular)? If so, it's not possible. Because ionic does not manage the HTML elements that are created dynamically.

Hi, thanks for your reply! :)
As I said, the click handler works fine if you directly go to this page. It only does not work if you come via setRoot...
It is not an Angular click-event listener. Instead I set the click handler via:
infoDiv.addEventListener("click", () => {
                    console.debug("click-handler run");
                });

I'm sorry but I'm really not familiar with ionic. What is setRoot?
In order to understand how to handle click position this plugin, you need to learn about native side.
Are you familiar with Android/iOS development?
If so, I will tell you. But if not so much, please just share your project files on github or bitbucket.
I will check your project files.
How to and why?
https://github.com/mapsplugin/cordova-plugin-googlemaps/issues/1479

Hi, thanks for your offer, it would be very kind, if you'd take a look at it:
https://github.com/fr4gstar/findlunch.git
branch: fix_map-infowindow-not-clickable

Thank you for sharing your project files.
The reason was the depth calculation of the HtmlInfoWindow contents was incorrect for some reason.
Please reinstall the plugin.

ping

solved it, thanks!


Make crop work the same for pil and tensor

In the transforms.functional.crop, if the cropping area is out of the image, in the case of pil, the box will be padded by zeros, whereas in the tensor, only the inside of the image will be returned.
See this notebook.
In this PR functional_tensor.crop pad if needed.

Thanks for the PR @Jaesuny , I think we can avoid calling pad all the times. Let's improve the code like that.
I think documentation update would be also needed ...

Thanks for the review @vfdev-5 . Updated based on your feedback.

Thanks for the changes!
Lint is failing in https://app.circleci.com/pipelines/github/pytorch/vision/8117/workflows/29ea8926-e7f7-448b-b705-53905de1de37/jobs/580130 , but once you fix it the PR is good to merge.


Add the sign up section

Is your feature request related to a problem? Please describe.
This is a simple sign up section that has a input, button and SVG images which you can find in the website-assets folder in the root project.
Describe the solution you'd like
Ensure you make it responsive and include the SVG images.
Below is the desktop and mobile view.

Describe alternatives you've considered
n/a
Additional context
n/a

Hey @muchirijane ! I would like to work on this issue.

@bhantsi Are you still working on this issue or @TD-17 should help you?

Kinda super busy these days @TD-17 please take it. I am so sorry for the inconveniences


Add PodDisruptionBudget support

Add support to PodDisruptionBudget to increase HA of ExternalSecrets deployments.
What is the added value?
Achieve HA for ExternalSecrets deployments
Give us examples of the outcome

Add pdb to certController
Add pdb to webhook
Add pdb to operator

Fixed with #1163 :pray:


Dev container: Use Microsoft Python Language Server for autocomplete

For VSCode users, this will dramatically improve the autocompete experience comparing with the default jedi language server.

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   28.47%   28.47%
=======================================
  Files          35       35
  Lines        2704     2704
  Branches      494      494
=======================================
  Hits          770      770
  Misses       1911     1911
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ca571...391cc36. Read the comment docs.


wip complement

Change-Id: I0e20e5c5cc363ab95456301e35e5145cb093898b

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.34%. Comparing base (75cc8f0) to head (b0f511c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   73.46%   74.34%   +0.88%
==========================================
  Files          23       24       +1
  Lines         260      269       +9
  Branches        7        7
==========================================
+ Hits          191      200       +9
  Misses         69       69

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Canvas support?

Hello! I think the answer is "no", but I wanted to check - does iv-viewer support zoom/pan on canvas images? For instance, if I have an HTMLCanvasElement, can I pass that to iv-viewer rather than an html image element?
Great library, thank you!

Howdy, just checking on this. Canvas support would be an awesome feature!

@s-yadav, I just wanted to check in and get your thoughts on this issue. Thanks!

Hey, @s4m0r4m4. Sorry missed replying earlier on this. Currently, it does not support canvas. I would like to understand the use case for HTMLCanvasElement.
Ideally, you can get the data URL  from canvas canvas.toDataURL() and pass the data URL as img url on the load method.
https://github.com/s-yadav/iv-viewer#instance-methods

Hello! My use case is that I have very large images (~200-400MB) that are sent to my app via websocket. I can't afford to render these in the main thread (it locks up the UI for too long!), so I am using a webworker to render that image in an offscreen canvas, along with rendering other items in the canvas.
To use your canvas.toDataURL() approach, I would have to run that in the worker and send the data URL back to the main thread and then pass it to iv-viewer. That data URL will be quite large, so there will be a performance hit.
It's probably not a good use case for this library, but I figured I would check to see perhaps there was a solution I was missing. Thanks for your reponse!


2.0.2 instance types/counts + blueprint hook

The blueprint hook tries to find instance counts/types and ultimately puts them in a runtime generated ops file. Unfortunately, this prevents me from using the same params concept for my counts/types for my isolation segments since it will error with:
[ERROR] No such instance group <instance I want> - cannot change instance counts to 6.
        Valid instance groups are:
          nats, diego-cell, diego-api, uaa, scheduler, router, api, cc-worker, adapter,
          doppler, log-api, tcp-router, credhub, haproxy
[ERROR] Could not determine which YAML files to merge: 'blueprint' hook exited with 1:

Yes, in this case, since you are already specifying the instance group directly in your environment, you can specify the instance count directly inside its yaml block, and don't need to use the params helpers.  Please let me know if that is not acceptable, and why.

I'm using my own ops file for creating an isolation segment.  I got around it by having to rename my parameter, which isn't great. My point is the blueprint hook shouldn't prevent me from using a preferred paradigm.


 We decided to postpone supporting SparseMat.

Do you have plans to support calcHist without SparseMat overload in the near future?
I tried to use it with dense hist, but it does not work in my case.
I modified the code slightly because nimages was not included in argument list. I added it but it gives me segmentation fault during calculation.
Am I doing it wrong, or it is not supported yet? If it is not supported yet, are there any plan for supporting it in the near future?
Thanks


Integrate with Geekli.st

Would be nice to show recent commit info on profile pages, and Geekli.st is already doing a great job of it.  Maybe we could integrate with them somehow?
API docs: http://hackers.geekli.st/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Site down.


Publish to Maven Central

Thanks for creating this library, I'm currently looking into updating an Android app and it's libraries to use SLF4j 2.x. Unfortunately our current SLF4j implementation using Timber isn't supported anymore (in fact; you're the only one with support for 2.x!).
One limitation for us it that we only allow libraries from Maven Central and the official Google repository. Not Jitpack.
Are you planning to publish your library to Maven Central?

Hi Niels!
I'm glad you appreciate this library (give it a star if you like it :) )
Publish it to Maven Central can be nice, I'll look into it!

@nielsvanvelzen done!
The artifact has moved from com.github.unveloper:slf4j-timber to io.github.unveloper:slf4j-timber
Enjoy :)

Thanks! It works as expected


CU-gjy9be add cancel api for payment order

Task linked: CU-gjy9be Add some imporve of payment order process, in case creat lots of order of same did


solution: update Yarn to latest version

Codecov Report

Merging #1218 (cf9ff41) into master (1947af8) will decrease coverage by 0.69%.
The diff coverage is n/a.

:exclamation: Current head cf9ff41 differs from pull request most recent head 5c9202f.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Misleading Statement

For extensions that require access to Azure Storage, you can allow access using Azure NSG Service Tags for Storage (If using Azure Firewall)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a01146cd-ccd3-210d-66ee-d097ba958061
Version Independent ID: d3726453-07cd-414e-cac8-49497b1540d6
Content: Azure VM extensions and features for Windows
Content Source: articles/virtual-machines/extensions/features-windows.md
Service: virtual-machines-windows
GitHub Login: @roiyz-msft
Microsoft Alias: roiyz

Hi @havronl - Thank you for your feedback! We will review and update as appropriate.

@havronl Can you please elaborate on the misleading statement so that we can update/correct the document. Thanks.

@havronl This doc lists down all the service tags and says that

The following service tags are available for use in network security groups rules. Service tags with asterisk at the end (i.e. AzureCloud*) can also be used in Azure Firewall network rules.

From your statement, it seems like you are saying that you can allow access using Azure NSG Service Tags for Storage, only if we are using Azure Firewall. Is that right?
Please elaborate on why do you think the statement is incorrect.

@havronl Please share the details as asked above so that we can ensure doc is correct. Thanks :)

@havronl We will now close this issue. Please share the details when you are ready and tag me in a comment. I will reopen it and we will gladly continue the discussion.


Issue 1701 enhance connector api

About this change - What it does
Extends the ConnectorOverview API to add a boolean when there is an open Claim Request.
Adds a POJO for use with the connector promotion for easier use.
Adds a check to return REQUEST_OPEN when a promotion request is already available.
Updates the Claim Connector Request API to use a body instead of request Params.
Updates the angular components to work with all the updates, e.g. success -> SUCCESS in the promotion details.
Make changes to coral to use the new POJOs (no change in functionality purely a renaming exercise.)
Resolves: #1701
Why this way

May not be in this PR : User should be able to edit the connector before submitting promotion request, as the connector config contains environment specific information like jdbc urls, pwds etc.


support:

Support Question

Not deployed music bot in telegram please deploy to on music bot

Not deployed music bot in telegram please deploy to on music bot

Share screenshot or logs of deployment.

Hi bhai

visit @YukkiSupport on Telegram (:


recognize can crash with 'attempt to subtract with overflow'

If you write a parser that returns a constant string in the first tuple position, and you pass that to recognize, you can crash in a very strange way. The reason is pretty obvious now that I tracked it down: recongize uses 'offset', which relies on the returned string being a subslice of the input.
It would be nice if there was a debug assertion in there, at least, to do a bounds check and provide a more helpful panic message.
use nom::{combinator::recognize, IResult};

fn strange_but_technically_valid_parser<'a>(s: &'a str) -> IResult<&'a str, &'a str> {
    Ok(("", s))
}

fn main() {
    let test_str = "test".to_string();
    let _ = recognize(strange_but_technically_valid_parser)(&test_str);
}

For posterity, this is the output:
thread 'main' panicked at 'attempt to subtract with overflow', /home/mullr/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-7.1.1/src/traits.rs:85:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:143:14
   2: core::panicking::panic
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:48:5
   3: <&str as nom::traits::Offset>::offset
             at /home/mullr/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-7.1.1/src/traits.rs:85:5
   4: nom::combinator::recognize::{{closure}}
             at /home/mullr/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-7.1.1/src/combinator/mod.rs:514:21
   5: nom_recognize_crash_repro::main
             at ./src/main.rs:9:13
   6: core::ops::function::FnOnce::call_once
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

rustc 1.60.0 (7737e0b5c 2022-04-04)
nom 7.1.1, no extra features

Yeah, you can't do that. The "rest" you return needs to be a subslice of your input.

You're violating nom invariants so it makes sense that it would panic.

Yes, this is clear. I'm suggesting that the invariants could be checked with a debug assert (or perhaps some other mechanism), to save future users some debugging time.


squash image from imagebuilder when last parent is scratch, because i…

when using imagebuilder and last/only parent is 'scratch', it produces 2 layers, from which 1 of them is empty, so we have to actually run squash even for imagebuilder in that case
Signed-off-by: Robert Cerven<EMAIL_ADDRESS>

@rcerven Tested. FWIW, LGTM. Need more acronyms :P

We end up with two layers after a custom base image too -- one for the imported filesystem, and another for the Dockerfile processing. I think this is might be a very similar case.
Do we really need to only end up with a single layer for FROM-scratch builds? Note that if we left this alone, so there were two layers, we could potentially drop squashing altogether at some point in the future. If we stick to wanting a single layer, we must always carry squashing support.

@twaugh
Yeah I know we end up with 2 layers for base as well, in scratch case is only weird that the one layer is empty 0 size, but yeah I am aware of the fact we wanted to get rid of squashing, so this is basically for us to decide, if we want to have 2 layers for scratch (1 empty), and get rid of squash, or keep squash and have only 1 layer

closing this, we will go with 2 layers for scratch without need on squashing


[FINE]#1280 pr for FINE, adds supported_consoles attribute and related changes

this is a copy of https://github.com/ManageIQ/manageiq-ui-service/pull/1280 for fine
WIP till https://github.com/ManageIQ/manageiq/pull/16589

@himdel Looks like the backend pr needed for this was approved, ready for you at your earliest!


fix flex in dialog content on ie11

Fixes #108

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed, 1 unresolved discussion (waiting on @manolo)

src/shared-styles.html, line 34 at r1 (raw file):

      [part="content"] {
        display: 1 0 auto;

incorrect property value

Comments from Reviewable

I have reimplemented the solution in scope of this PR.

Reviewed 3 of 3 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable

This PR fixes the issue with IE but it breaks the layout for Edge (screenshot above)

After long investigation, we came up with the decision to use display: flex on overlay parts.

Review status: 1 of 3 files reviewed, all discussions resolved (waiting on @web-padawan)

Comments from Reviewable

Reviewed 1 of 3 files at r2, 2 of 3 files at r3.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


spaced-comment

Current dependencies on/for this PR:

main

PR #152   👈

This comment was auto-generated by Graphite.


Sort only selected imports

A context menu which only sorts currently selected imports would be great improvement.
Thanks

With the release of Typescript 2.8 over a year ago, the ability to organize imports comes bundled with Typescript, in a better implementation than this one made for a hack week. As such, I have no further plans to maintain this project.
If for whatever reason you would like to take ownership of this repository, please let me know.


Broken images

Ahoy matey!
Before ye create a new issue, please make sure to search through the existing issues to see if your problem has already been addressed.
Issue Description:
The last merge broke some images and we need to fix them.
Page number and chapter:
Multiple. Will need to find them and resolve them.
Expected result:
Fix the broken images.
Actual result:
Additional context:
This is a good first issue
Thanks for bringing this issue to our attention. We'll do our best to address it as soon as we can.
Yarrrr!

Hey @loftwah can I work on this issue ?

Absolutely! I'll assign it to you. I haven't set anything up for this yet formally, but I can leave it with you for the week.

Welcome to the project!

great!, I did found 1 but ig I gotta check it out nicely to find the others !
will update as soon as I find them !
Thank you !

This has been unassigned. I will complete the task.

uhhh sorry I forgot about it
will try to find other issues to contribute to

Nevermind, I don't think it was you I think we fixed it unintentionally without you.

Ooo okay, ig I am gonna create an extension that can remind me of the assigned issues every morning at a certain time, bcoz this is something that I do really often
Thank you will try to contribute to other issues !

We all do it, don't sweat it.


Add: (get/set) (color/class/mode)

New functions are added to this plugin:
viewer.annotations.get_color(): return the current stroke's color for annotations.
viewer.annotations.set_color(c): set a color for the next annotation, c can be a string like 'red', 'blue', .. or '#FF0000' format.
viewer.annotations.get_mode(): return the current mode of the viewer, it can be either {'DRAW' or 'MOVE'}.
viewer.annotations.set_mode(): set the mode of the viewer to {'DRAW' or 'MOVE'}, this function takes only those two string values as input.
viewer.annotations.set_class(): set a specific HTML class for each annotation (in the <path> tag). New style can be added to specific annotation based on class name. (We are assuming to draw several annotations in different colors and different classes).
viewer.annotations.get_class(): return  the current active class the is used for drawing.

I don't have the power to merge things here, and I'm not sure if @Emigre is still maintaining this project, but I thought I'd add my two cents:
For starters, I think it's awesome that you've added all these new features! Definitely seems more powerful.
Secondly, though, looking at the changes, it looks like there are quite a number of changes that are unrelated to these new features... Looks like a complete overhaul of the plugin! Typically, with a pull request it's good to focus on just one feature at a time, and at the very least to explain what all the changes are for.
Thirdly, I think function names like getColor would be more in-line with the OSD naming convention, if you wanted to match that in this plugin.
Anyway, of course it's up to @Emigre how they want to proceed. Even if they aren't still maintaining the project, it's good to have this PR here so that it can help other people who want these features!
If it does turn out @Emigre has abandoned this repo, you might consider making your version an official fork. We can update http://openseadragon.github.io/#plugins to point to it.

hey guys hi. I've been absent for a while, but to be honest this plugin has been the last of the priorities in my life for a while - I was thiking on getting rid of it somehow, to be honest. @iangilman thanks for keeping an eye, you are really great, I'm amazed that you've maintained the attention on the plugin for so long. Very nice of you.
@magednasan thanks for the contribution, but, as @iangilman was saying, there  is a lot of stuff here, some of them are changes that are not heading in the direction I had in mind. As an example, I did not have in mind to support bower. Also the change seems unrelated to the rest. All I'm sayin is, you are adding several things in one go.
I really don't know what would be the best way to handle this. In my mind I was going to remove preact from this plugin and implement something simpler to update the SVG. I had an idea on how to do this, which would end up with the plugin not depending on any library. I'll have ot think what to do.

@iangilman as the "guardian"of the OpenSeadragon ecosystem, perhaps you have ideas on what would be the best? Feel free to email me or contact me in any way if you want to discuss, be involved or advice. Cheers.

To give you both some context around this, I created this as a mindless experiment years ago with no particular intention. I didn't add unit tests, I did not use TypeScript, I used an already existing rendering library... In short I didn't think about it too much. But then over time I've received a number of PRs to it. It seems that some people are actually interested in the plugin. To my surprise!....

@Emigre Good to hear from you! Yes, there certainly does seem to be interest in this plugin! I think the big annotation option for OSD is https://github.com/recogito/annotorious-openseadragon but I think this plugin has a lot of appeal because it's simpler and doesn't depend on other things, so I think there's value in both.
I would certainly be happy if you wanted to continue to support and evolve this plugin. If @magednasan's changes aren't to your liking, it's your perogative to reject this PR or ask for changes to it. You should definitely take it in whatever direction you feel is best! Of course if you don't want to continue to maintain it, maybe making an announcement in the issues or the readme saying you're looking for a new maintainer would be good.
I'm curious to hear what @magednasan thinks... If they want to pick up the torch, or if they're happy to leave it as it is.


Document @Install and its usages in components

Environment

Documentation version: Snapshot
Part of the documentation: Manual

Description
If you search "@ Install" in existing documentation - it's not well documented (idea, purpose, usages in components).
As an example - Table.Column delegates (formatter, columnGenerator, valueProvider) are not mentioned in documentation at all.

Add @Subscribe and @Install to https://doc.cuba-platform.com/manual-7.0/screen_controller_annotations.html

Also for methods like setOptionImageProvider() (i.e. setters of providers) add examples of using them with @Install (by generating this code in Studio "Handlers" tab):
@Inject
private Image imageResource;

@Install(to = "fooLookupField", subject = "optionImageProvider")
private Resource fooLookupFieldOptionImageProvider(Foo foo) {
    String iconName = Boolean.TRUE.equals(foo.getStatus()) ? "icons/active.svg" : "icons/inactive.svg";
    return imageResource.createResource(ThemeResource.class).setPath(iconName);
}


fix(git): respect scp-like URL for nested submodules

What does this PR try to resolve?
parent_remote_url used to be &str before #12244. However, we changed
the type to Url and it started failing to parse scp-like URLs since
they are not compliant with WHATWG URL spec.
In this commit, we change it back to &str and construct the URL
manually. This should be safe since Cargo already checks if it is a
relative URL for that if branch.
How should we test and review this PR?
This is current a draft because I had a hard time adding a test around it.

Scp-like URL (e.g. git@github.com:rust-lang/cargo.git) doesn't accept custom port. In our container_test we need to specify a custom port number.
There seems to be no way to configure a git submodule without cloning the repo. Otherwise we could have configured it and perceived it fail when fetching instead of parsing URL.

To test it, I ended up manually creating a repo with a submodule with scp-like URL.
Additional information
I feel like this worth a beta backport (we missed the nightly window).
I also feel like it is pretty safe to merge without adding a test if we cannot figure out how to.
Fixes #12295

Looks good to me.
Yea, there isn't a particularly good way to test scp-style URLs since they don't support port numbers. My only idea would be to put cargo itself inside a docker container, and orchestrate the test around using port 22. But that sounds sufficiently annoying that I wouldn't want to bother with it yet.
A beta backport sounds good to me, too.
@bors r+

:pushpin: Commit a7247babf60c7cb7969b764c6046d6dd391f7871 has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit a7247babf60c7cb7969b764c6046d6dd391f7871 with merge 5a9f611178f48cd8c11632aa3f18776e58a0e59d...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 5a9f611178f48cd8c11632aa3f18776e58a0e59d to master...


Terragrunt project appears multiple times in output

When running the diff on our project we somehow get some projects multiple times in the output. You can see the result here: https://dashboard.infracost.io/share/evblu6q4e9kfgnegw0qbvz16krd3c1fl#1ed99956-4c8e-49d5-bc56-fe14c5e0ed75
i.e. the first one appears two times, apparently its matched somehow twice (the path is differently). Do you know how I could solve this? Maybe with the config file?
Thanks in advance!

Thanks @fellnerse, I'll look into this today. Do you have the current command you are using to run Infracost?

here are parts of our azure pipeline:
      - task: InfracostSetup@1
        inputs:
          apiKey: $(TERRACOST_API_KEY)
          version: "0.10.6"
          enableDashboard: true
      - bash: infracost breakdown --path=deployments --format=json --out-file=$(file_name)
        displayName: Generate Infracost cost estimate

      - publish: "$(file_name)"
        artifact: infracost-baseline

      - task: InfracostSetup@1
        inputs:
          apiKey: $(TERRACOST_API_KEY)
          version: "0.10.6"
          enableDashboard: true
      - download: 'main-pipe' # this comes from pr.yaml resource section
        artifact: infracost-baseline # and this from the jobs.publish-baseline.yaml

        # Generate an Infracost diff and save it to a JSON file.
      - bash: |
          infracost diff --path=deployments \
          --format=json \
          --compare-to=$(Pipeline.Workspace)/main-pipe/infracost-baseline/infracost-baseline.json \
          --out-file=$(file_name)
        displayName: Generate Infracost diff

      - bash: |
          infracost comment azure-repos \
             --path $(file_name) \
             --azure-access-token $(System.AccessToken) \
             --pull-request $(System.PullRequest.PullRequestId) \
             --repo-url $(Build.Repository.Uri) \
             --behavior delete-and-new
        displayName: Post Infracost comment

Thanks @fellnerse. I've been unable to reproduce this, but it looks like something funny is going on with how we detect the Terragrunt module paths. Is there any chance you could email me the full pipeline YAML, along with the infracost-baseline.json and infracost.json assets it generates? If that's possible my email is alistair _at_ infracost.io.

🙌  thanks for investigating @fellnerse. Let us know if you find any other odd issues.


add store.dispatch fixes #1644

@reggi 👍

This doesn’t pass the tests.

I’m closing because of the failing test. #1647 is another fix, and it doesn’t fail the tests.


bump to version 1.5.0

Codecov Report

Merging #125 into master will decrease coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   91.29%   90.82%   -0.47%
==========================================
  Files          58       58
  Lines        1988     1919      -69
==========================================
- Hits         1815     1743      -72
- Misses        173      176       +3

Impacted Files
Coverage Δ

src/py42/__version__.py
100.00% <100.00%> (ø)

src/py42/_internal/compat.py
70.00% <0.00%> (-30.00%)
:arrow_down:

src/py42/sdk/__init__.py
82.35% <0.00%> (-4.32%)
:arrow_down:

src/py42/modules/alertrules.py
80.00% <0.00%> (-1.82%)
:arrow_down:

src/py42/sdk/queries/__init__.py
88.23% <0.00%> (-1.24%)
:arrow_down:

src/py42/_internal/clients/alertrules.py
80.85% <0.00%> (-1.15%)
:arrow_down:

src/py42/response.py
93.87% <0.00%> (-0.67%)
:arrow_down:

src/py42/_internal/clients/storage/__init__.py
91.66% <0.00%> (-0.65%)
:arrow_down:

src/py42/_internal/auth_handling.py
94.44% <0.00%> (-0.30%)
:arrow_down:

src/py42/modules/securitydata.py
93.06% <0.00%> (-0.27%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2840242...c759592. Read the comment docs.


Confusing error message on user creation

I deployed dex using a fake emailer config, and when I tried to add a user I saw the following error message (verbatim): ERROR: error sending password reset email No HTML or Text template found for template name.:. I feel like there is some context missing from this after the colon.

My guess is that an empty string was passed as the "name" of the template execute, rather than the context missing after the colon.

No guessing please. The issue was an incorrectly named environment variable.

@bobbyrullo woo, thanks!

For reference: https://github.com/coreos/dex/pull/164


add firewall filters to postgres

Codecov Report

Merging #4 (0f9cd16) into master (5d82519) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   90.91%   90.91%
=======================================
  Files         299      299
  Lines       34870    34884   +14
=======================================
+ Hits        31702    31716   +14
  Misses       3168     3168

Impacted Files
Coverage Δ

...c7n_azure/c7n_azure/resources/postgresql_server.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d82519...0f9cd16. Read the comment docs.


Generate and save consent cookie

USER STORY
As an user who has set my consent config in a company's privacy center to opt out of data sales and sharing, I want the company to reflect my preference in a cookie that is set on my browser, so that my preferences can be read from the cookie to prevent client side sales and sharing to third parties.
REQUIREMENTS
AC

Given that I have chosen to opt out of data sales and sharing, when I save my preferences, then a cookie is placed on my browser which explicitly indicates I have opted out of data sales and sharing.

DESIGNS
N/A
Extra Info

https://github.com/ethyca/fidesops/pull/1407
You can see the design of the Ethyca Pro Cookie here. We will eventually expand this cookie to also support opt-in/out status of other types of cookies - Essential, Functional, analytics, Advertising.
We may need to add an explicit "data sales and sharing" consent type to the privacy center config, so that we know that when it is set, to set the cookie ( https://github.com/ethyca/fidesops/blob/main/clients/ops/privacy-center/config/config.json)

@ssangervasi @Kelsey-Ethyca  Updating this a bit to separate data sales and data sharing into two preferences. We should set the cookie with unique properties for both.


Removed node modules

When cloning repo, run npm i to get node_modules

From issue #3

From issue #3

Removed node modules

Removed node modules


Adding GitHub stars to the Keycloak homepage

Closes #465
At the time of writing this, Keycloak has 20277 GitHub stars.
This adds the widget at different breakpoints:

There is also the option to add this as an embedded SVG, where the icon links to the GitHub repo, and the number of stars links to the stargazers list. I decided against it as an image is simpler to layout and more control over the link. This might be a precaution if the shields service should be hacked.

@jonkoops / @stianst - please let me know what you think of this change.


x-anonymous-consents missing in CORS config

Environment Details

Spartacus:  1.3
Browser: Chrome
OS: MacOsx

Steps to Reproduce
Enable anonymous consent on Spartacus
Go to SmartEdit
Go Homepage (staged or online)
Use preview perspective
Click on a link to another page
Observed Results
Error happens in the console and page does not load properly. This issue also happens through other steps.
Error in the console :
Access to XMLHttpRequest at 'https://localhost:9002/rest/v2/electronics-spa/cms/pages?fields=DEFAULT&pageType=ContentPage&pageLabelOrId=homepage&lang=en&curr=USD' from origin 'https://localhost:4200' has been blocked by CORS policy: Request header field x-anonymous-consents is not allowed by Access-Control-Allow-Headers in preflight response.
spartacus-core.js:25301 Unknown http response error: -1
Expected Results
The page related to the link should be opened without any error
Offer to Fix
Yes, I will open a PR.

@CarlEricLavoie we state you have to add this in the docs
https://sap.github.io/cloud-commerce-spartacus-storefront-docs/anonymous-consent/#page-title
what would the fix be? to add to default ootb 1905?

Hi Bill I opened a PR on the documentation repo. See linked PR above

Ah sorry I miss read you are correct I missed it. Closing this ticket


Update revised roadmap (online version)

Nir doing first proof

Nir doing first proof

For discussion by committee

Part 4 is the first item on the March committee meeting agenda.
Geoff

@PatReynoldsFUG  to replace content on live document with column 1 from new Roadmap doc.

I have lost access to the drive.  Will do when access restored/I am sent a link.

@PatReynoldsFUG to place link to committee working doc in this story

This is the working document: https://docs.google.com/document/d/1oZCD-MYIgbAt2yLDCVxVJgtR1OR8jUgyTm3ABdt_Zmk/edit?usp=sharing - please let me know if you need access.

@PatReynoldsFUG to update live version to remove comments (and make a copy for working on)

Copy with comments removed now here: https://docs.google.com/document/d/1JXlZ1X3QjiM_t48ASP1pNC0J2HgscS17bXHvblHsZsE/edit?usp=sharing

@geoffj-FUG will take a look at the document

Pat
I have added comments to the document.
Geoff

Emailed some thoughts to Denise 30 May 2024

Pat to find document and email Denise the link


[New Constant] Relative Times

List of new constants/events

[x] In the morning
[x] In the evening
[x] After lunchtime

This type of grammar already works but there is need for more testcases!

Todo notice to myself:

Add testcases for the in the x case

Try to see if there's a grammar missing as I think I haven't accounted for all of them. If not, close this issue


brew install eosio

macOS: 10.13.6-x86_64
$ brew install eosio
==> Installing eosio from eosio/eosio
==> Downloading https://github.com/eosio/eos/archive/v1.8.0.tar.gz
==> Downloading from https://codeload.github.com/EOSIO/eos/tar.gz/v1.8.0
######################################################################## 100.0%
Warning: Cannot verify integrity of fcc4996828aa5cc0c832f7604b1fc6850923e428475e8f6709959f66bec12ef9--eos-1.8.0.tar.gz
A checksum was not provided for this resource
For your reference the SHA-256 is: 173122c922bd13bb837620bd27d25755efec294dd54a050fc1838e8546b640f7
Error: An exception occurred within a child process:
RuntimeError: Error, only supporting binary packages at this time

eosio only supports 10.14 now. That's probably the reason for your error but I have no way of testing 10.13 at the moment

the bottle has been updated to report a more intelligent error when not running 10.14+, closing issue as resolved

macOS Catalina: 10.15.6
➜  ~ brew install eosio
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> Updated Formulae
Updated 5 formulae.
==> Installing eosio from eosio/eosio
==> Downloading https://github.com/eosio/eos/archive/v2.0.7.tar.gz
Already downloaded: /Users/amaurycalleja/Library/Caches/Homebrew/downloads/835fef79b625d321e2f7b609c9e8f03822dcda89317b439a8a5c8835fbc244f6--eos-2.0.7.tar.gz
Warning: Cannot verify integrity of 835fef79b625d321e2f7b609c9e8f03822dcda89317b439a8a5c8835fbc244f6--eos-2.0.7.tar.gz
A checksum was not provided for this resource.
For your reference the SHA-256 is: 9a9ecd36242d620e0165766f41f5f942ff6d1a9edc12dac418a0ebcaf2dc4d8a
Error: An exception occurred within a child process:
RuntimeError: Error, only supporting binary packages at this time


Support imagePullSecrets for init-pwd,operator and fe-proxy

Description
The image for the components "operator" and "fe-proxy" may need to be pulled from a private registry. To achieve this, add the configuration item imagePullSecrets.
Reuse the configurations for the "init-pwd" job from the "FE" component, including starrocksFESpec.affinity and starrocksFESpec.imagePullSecrets.
Related Issue(s)
Please list any related issues and link them here.
Checklist
For operator, please complete the following checklist:

[ ] run make generate to generate the code.
[ ] run golangci-lint run to check the code style.
[ ] run make test to run UT.
[ ] run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

[x] make sure you have updated the values.yaml
file of starrocks chart.
[x] In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
chart( kube-starrocks chart).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jimmy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


AJ-1771: id filter for paginated record query

This PR modifies the pre-existing POST /{instanceid}/search/{v}/{type} API.
Before this PR, that API accepted a payload of:
{
  "offset": 0,
  "limit": 10,
  "sort": "ASC",
  "sortAttribute": "string"
}

After this PR, it will accept a payload of:
{
  "offset": 0,
  "limit": 10,
  "sort": "ASC",
  "sortAttribute": "string",
  "filter": {
    "ids": [
      "string"
    ]
  }
}

That is, it will now accept a filter object, which can contain an ids array of strings.
Both filter and filter.ids are optional for backwards compatibility. If you omit them, the API will behave as it previously did.
If you DO specify values in filter.ids, it will behave like a SQL IN clause, and filter the query results to only those records whose ids match one of the supplied values.
Some functional behaviors:

sorting of results is still controlled by the sort and sortAttribute params. Sorting does not consider the order of ids in filter.ids.
results still respect the limit and offset values. If you specify 20 filter.ids but a limit of 10, you'll get (up to) 10 records back.

You may want to read through the test cases in RecordControllerSearchFilterTest in this PR for detailed examples of behavior.
Anyone who is using a Java/Python client will need to update their client after this PR to get access to the new models.

Open Questions:

If the user specifies more filter.ids values than limit, should we return only limit records, or should we throw a 400 Bad Request error?
If the user specifies an empty filter.ids: [], should we return 0 results always, or should we treat that equivalent as having omitted filter.ids and return all results? Or, throw a 400 Bad Request?

Open Questions:

If the user specifies more filter.ids values than limit, should we return only limit records, or should we throw a 400 Bad Request error?
If the user specifies an empty filter.ids: [], should we return 0 results always, or should we treat that equivalent as having omitted filter.ids and return all results? Or, throw a 400 Bad Request?

I think just limit records.  A 400 seems too annoying if the user made a mistake.
Definitely not 400, for the same reason as above.  I'm torn between the other two choices, though - I lean towards 0 results since it does seem like they're specifically requesting none, but that seems like a dumb thing to do so it seems like it would be a mistake and should just count as omitting it.

Definitely not 400, for the same reason as above. I'm torn between the other two choices, though - I lean towards 0 results since it does seem like they're specifically requesting none, but that seems like a dumb thing to do so it seems like it would be a mistake and should just count as omitting it.

A 400 response is useful for telling the user that they made a mistake and prompting them to correct it, vs us trying to guess at what they might have intended and maybe getting it wrong.

Open Questions:

If the user specifies more filter.ids values than limit, should we return only limit records, or should we throw a 400 Bad Request error?

I still feel strongly that if limit is less then the number of ids, an error should be returned - mostly based on prior experience of people getting confused and thinking something is wrong with the client vs catching their own error. In the end, its an easy thing to resolve if people ask -- but this still means getting to communicate with customers about behavior that is intended (which can be an annoying thing for them). With all that said, this can also be resolved by providing good client documentation and leaving it at that (i.e. that limit will always apply, no matter the filter)

If the user specifies an empty filter.ids: [], should we return 0 results always, or should we treat that equivalent as having omitted filter.ids and return all results? Or, throw a 400 Bad Request?

0 results seems reasonable to me if filter.ids is present. My one worry is that in swagger filter.ids will be there by default and that can be possibly confusing, but again can be resolved by providing good client documentation that states the intended behavior.


Customize CSS options (frozen/read-only background color)

It would be nice to edit the background color of frozen and read-only cells from the Advanced Settings Editor of JupyterLab.
From the repository I saw there are only two CSS variables in the style/base.css file, more specifically:

--jp-frozen-bg
--jp-readonly-bg

I tried to override them from the Theme advanced editor but it doesn't recognize these variables.

Thanks for the feedback, I will check with my team if they want to work on this 👍

I have added this feature on the same PR without realizing that the PR was still open 😅. I hope that is okay.

I had to change the CSS variable to enable dynamic change, it is not stored in the root like so:

Released in version 0.1.1 https://github.com/DataDog/jupyterlab-freeze/pull/7


Update layers/meta-balena digest to c005b8b

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
22f6f33 -> c005b8b

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Can one of the admins verify this patch?


Use Fn::GetAZs Function for allocating Availability Zones

Because reasons :)

Looks good but I'd replace the "" arg to Fn::GetAZs with { "Ref" : "AWS::Region" }
`

:+1:


[SVG Font] Keep a copy of UTF-8 XML source string during the whole SVG processing.

Sometimes ThorVG is accessing source string after the load call return, and UTF-8 string should stay valid until processing is done. Also, remove 4 unnecessary UTF-32 → UTF-8 conversions per rendered glyph.
Fixes https://github.com/godotengine/godot/issues/75490

Thanks!

Cherry-picked for 4.0.3.


Fixed issue #11

I don't see any other way to do this because no real event is fired when the mouseMarker is added to the map.

Thanks for your contribution ! I reviewed it quickly... it's a pity we don't have unit test on this package, this is somehow risky to merge such changes :/

You can check out my branch and test it. I know it's not beautiful but if nobody else can find a better fix.
Without this Leaflet.Draw integration is just broken...

Feel free to change it as you wish!

I allow you to just copy my/your code and make your own commit, just that it gets fixed! Thank you for your time and project!


Firefox CORS support

Firefox is more strict than chrome about CORS requests from https pages to http urls
https -> http://localhost:22000 doesn’t work, so you need to use http remix.
The problem is our plugin is served from https://jpmorganchase.github.io/qr/ and if you change it to http, you are automatically redirected to https.
So we need to serve it from a url that works in both http and https mode.
We can either turn off the "Enforce HTTPS" setting on the github pages site or we need another place to host the plugin.

Fix will be released soon, see #30


Fix GCM of CSE stores

Stop CSE of stores.
Backports to ch11,12,13,14

Could fix it by splitting CSE stores in GCM, BUT this is a tutorial and it makes GCM harder.  Easier not to fold


Same icon is used for configuration and queue-ing a report next to each other

@miq-bot add_label ui
cc @dclarizio @epwinchell @serenamarie125

@dclarizio @serenamarie125 The word "Queue" was added to the button recently (see below.) As far as I know, this is the only screen where both are seen together. Is it alright or should be choose a different icon for Queue?

@epwinchell I'm for a new icon, not sure the gear represents queue anyway

My suggestion: http://fontawesome.io/icon/play-circle-o/

What does queue do ?!🙄
On Friday, September 9, 2016, Eric Winchell<EMAIL_ADDRESS>wrote:

My suggestion: http://fontawesome.io/icon/play-circle-o/
[image: screen shot 2016-09-09 at 1 39 20 pm]
https://cloud.githubusercontent.com/assets/1287144/18396667/dd0b7146-7692-11e6-9097-3f8a279a77c7.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/issues/10734#issuecomment-245985106,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL7NU9LlgD_4PQZXFVJuxr5_elafxY8Wks5qoZnpgaJpZM4JsBcb
.

--

Serena Chechile Doyle
UXD | Unified Management Experience
Red Hat
Cell<PHONE_NUMBER> | IRC - serena | Skype - serenamarie125 | Twitter -
@serenamarie125

@serenamarie125 Pressing the "queue" button adds the report request to the task queue.  In other words, it "gears up" the report.

Is that the same as Schedule New @epwinchell?
On Fri, Sep 9, 2016 at 3:03 PM, Eric Winchell<EMAIL_ADDRESS>wrote:

@serenamarie125 https://github.com/serenamarie125 Pressing the "queue"
button adds the report request to the task queue. In other words, it "gears
up" the report.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/issues/10734#issuecomment-246008269,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL7NU9znEzVtfncC_Vd6-4-WBiUE8e7Cks5qoa11gaJpZM4JsBcb
.

--

Serena Chechile Doyle
UXD | Unified Management Experience
Red Hat
Cell<PHONE_NUMBER> | IRC - serena | Skype - serenamarie125 | Twitter -
@serenamarie125

@serenamarie125 no, what queue does it is basically queues the report to run asap, in other words, if a worker is available, it runs immediately, but if not, it will run once one frees up.  Scheduling creates a recurring report run on certain days/times.

@serenamarie125 bump

I like the http://fontawesome.io/icon/play-circle-o/ @epwinchell !  I'll also put this somewhere in our UXD land so people know we are using it for Run going forward.  Thanks!