Better typings for Cmd.run (Typescript 3.0)

If you ever want to make the jump to Typescipt 3.0 (which I understand you may not want to), this PR enables better typings for Cmd.run:

option.args has the same type as f's arguments, and is mandatory if f takes any argument
otpions.successActionCreator takes as only argument the return value of f (unwrapped if f returns a Promise)

Take a look I did similar improvement https://github.com/redux-loop/redux-loop/pull/191

@stereobooster I saw your PR, mine is a little different in scope because it requires TS 3.0, while yours can be used with the current version. Sorry if this looks like I'm "competing" with you, this is absolutely not what I intended :)
The goal of this PR is more to show that we could have some really better typings with this new version. Again, I know there are good arguments for not changing version (even if TS 3.0 has almost no breaking changes), and I just want to open the discussion.

By the way I think the test/typescript.spec.ts may not work as intended, because my changes definitely broke them and the tests are still green :(

By the way I think the test/typescript.spec.js may not work as intended, because my changes definitely broke them and the tests are still green :(

When I changed code, it failed here, because dispatchNoop expects function, not a symbol as an argument.
Cmd.run(dispatchNoop, { args: [Cmd.dispatch] })

Since this requires ts 3.0, it would be a breaking change right?

@bdwain yes it would be a breaking change because it would require users to use typescript 3.0.
I could rewrite it to support 2.8, which folks at DefinitelyTypes seem to think is reasonable: typings for most react-* require 2.8, as do some other popular libraries like bluebird.
It would allow the same guarantees as this PR, but be a little more verbose (which would be of no concern for users). Tell me what you guys think.

@antoinewdg yea if it's possible to support both that would be great I think. I'd rather avoid introducing a breaking change if possible

I'm also interested in seeing better typescript types for redux-loop, and have opted for overriding the types locally until the package types are improved. Luckily TypeScript 3.1 introduces typesVersions with which you can provide different types for different versions of typescript. This way you would be able to introduce better types, without breaking backwards compatibility with older versions of typescript. Managing multiple different typings files might become tedious though.

@antoinewdg sounds like v3.1 might help this.

@sbdchd thanks! I'd be happy to look at a PR if you open it.

since this one is out of date maybe easiest to open a new one?

I see now you opened #207

#207 actually covers a different typing case, allowing for success and failure actions to be different types in the union of actions.
This pr ensures that args and the params of the function passed to Cmd.run() match.

got it. well if you want to reopen this one in a new PR and with the comments addressed I'll be happy to check it out.


Extract integration helpers to separate package

Closes #911
Introduced changes

Moved helper code from integration tests to utils crate within forge so it can be reused for benchmarks.

Breaking changes

Checklist

[x] Linked relevant issue
[x] Updated relevant documentation
[x] Added relevant tests
[x] Performed self-review of the code
[x] Added changes to CHANGELOG.md

Don't merge it until my refactors are merged, please

No strong opinion on that, we can can it test_utils.


How does this work when AAD Connect Configuration Wizard creates the AD DS Connector accounts?

We are using AAD Connect Sync 1.1.614.0 at my organization and we chose to let AAD Connect create all service accounts automatically, in the final configuration steps creating filters in AD I noticed that if i accessed the Directory partition configuration  in the MIISClient that the Sync engine would use the account i configured the partition with for future authentications to sync job runs and not the MSOL_# account automatically created by the sync wizard.  How do I get the sync engine to use the account created by the sync engine without changing the MSOL_# password which would be security issue?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22058cc4-f62d-517a-ab34-853a518b284f
Version Independent ID: d0fce43e-e427-b1a9-f389-ec7bdbc3b400
Content: Azure AD Connect sync:  Changing the AD DS account password
Content Source: articles/active-directory/connect/active-directory-aadconnectsync-change-addsacct-pass.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@rh1701 Thanks for your feedback! We will investigate and update as appropriate.

Please open a new MSDN forum post and community will help address your query. Please refer to below link to MSDN forum to ask new question -
https://social.msdn.microsoft.com/Forums/azure/en-US/newthread?category=windowsazureplatform&forum=WindowsAzureAD
Do post the forum thread link here so that I make sure you are being helped.

@rh1701 We will now proceed to close this thread. As stated please open MSDN thread and mention the link here so that I can ensure that the necessary help is provided.


Select Definition

Hi, Sorry of this is the wrong place to ask.
I am separating my endpoints into grouped definitions based on version (i.e. api/v1, api/v2) and thanks to Extended OpenApiPlugin, to support multiple options I am able to do that.
However I need to be able to link them from the Swagger UI using the "Select Definition" dropdown.
This is done in SpringFox using multiple Docket. Here's a screenshot example
I can't see if that is possible in Javalin?

Hmm this plugin is not exactly the same as before and we don't support schema versioning yet, so it's something we need to address as first 🤔 I guess we could add an optional "versions" parameter to @OpenApi annotation and then provide a possibility to expose those tagged routes under different path.

OpenApi plugin supports now multiple versions of definitions, you can name them using array property called versions, e.g.:
versions = "v1"

By default all annotations use "default". The url to each version is resolved using query parameter, as follows:
http://localhost:8080/openapi.json - displays default scheme
http://localhost:8080/openapi.json?v=default - displays default scheme
http://localhost:8080/openapi.json?v=v1 - displays v1 etc.

It's also injected into Swagger UI config automatically, so you can choose any available scheme from definition list:


Roshankcjha

@ishandeveloper the pull request made here resolves the following issues:
#41 Made it based on the Website description(You can find the new logo or favicon icon in here
#99 On clicking the image  it redirects back to the home page (https://coursify.ishandeveloper.com)
#1 and #3(Course content addition with photos and repeated content deleted)

@ishandeveloper I am unable to understand why the greeting action gets failed . Is there any problem with the code do report quickly?

@ishandeveloper did this pull request get the issue resolved?Or should I try something else?


cornerstone is loading the dicom image, but making its own canvas?

I'll start off by saying I'm very new at web development in general never mind cornerstone.
I got cornerstone libraries added to the scripts and they are running fine as far as I can tell, but on completion  of loading and rendering , the  with the canvas contained a new canvas with zero width and height, I'm assuming something cornerstone has done.
Any ideas what would be causing this?

Can you post a working example of this? Maybe you are adding a canvas element yourself to the html source, which is not the way cornerstone works. See this codepen for a minimal working setup.

Yes Cornerstone will create a canvas inside your enabled element, if there isn't already a canvas inside it with the class 'cornerstone-canvas':
See:
https://github.com/cornerstonejs/cornerstone/blob/master/src/enable.js#L52
https://github.com/cornerstonejs/cornerstone/blob/5069401cafc9d8b91a8db035030b63405c28c505/src/internal/getCanvas.js#L28


Visual Studio 2017 Office Development

For VS 2017, installing the Microsoft Office Developer Tools should be done through the Visual Studio 2017 Installer, which can be accessed from the New Project window.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7795f659-9cc4-310b-1ea6-9842a6a2930a
Version Independent ID: cfc98572-f913-6f48-cfe4-1b9dd526d7fc
Content: Get started creating SharePoint-hosted SharePoint Add-ins
Content Source: docs/sp-add-ins/get-started-creating-sharepoint-hosted-sharepoint-add-ins.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Thanks for post, have added it to the docs.


Add content gc ref labels from containers, images, and snapshots

Currently the objects which can retain content from labels are limited. This limitation has required clients to work around this and and in some cases add outside reference counting (e.g. buildkit keeping content for snapshots). Updated the logic to treat content and snapshot labels equally and simplified the code in the process.
I would also recommend we consider backporting this to 1.2 since the change is tightly scoped with clearly defined tests. Current GC performance is good enough that any effect based from additional calls (additional cursor seek for every image, container, and snapshot) is negligible and offset by one less seek for each content (single call to sendLabelRefs saves an extra bucket lookup).

Codecov Report

Merging #3064 into master will increase coverage by 0.05%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
+ Coverage   43.46%   43.51%   +0.05%
==========================================
  Files         103      103
  Lines       11033    11015      -18
==========================================
- Hits         4795     4793       -2
+ Misses       5503     5485      -18
- Partials      735      737       +2

Flag
Coverage Δ

#linux
47.51% <88.23%> (+0.02%)
:arrow_up:

#windows
40.34% <86.84%> (+0.05%)
:arrow_up:

Impacted Files
Coverage Δ

metadata/gc.go
64.1% <86.84%> (+2.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6f46...7cfb99a. Read the comment docs.

LGTM


Change from pyscf.agf2.GreensFunction and pyscf.agf2.SelfEnergy to dyson.Lehmann

The latter offers more flexibility, is cleaner, and supports more modern utilities for analysis and so forth.

Done in #35


sdk/azcore: TokenCredential should not be internal

Bug Report
In sdk/azcore, the TokenCredential interface, as well as related structs such as TokenRequestOptions are in an internal package and cannot be used by third-party code.
We are working with APIs that are not supported by the SDKs yet, including some that have no roadmap to be supported. In order to interact with them, we need to retrieve access tokens. Because the TokenRequestOptions is internal, we cannot invoke GetToken on an azcore.TokenCredential object and retrieve an access token. Thus, we cannot make API calls without having to also re-implement the entire auth flow.

import path of package in question, e.g. sdk/azcore
SDK version e.g. 0.23.0
output of go version: go version go1.18 linux/amd64

TokenCredential and TokenRequestOptions are exported, though from different packages, so it's possible to implement custom credential types and acquire a token from any credential type in azidentity:
package main

import (
    "context"

    "github.com/Azure/azure-sdk-for-go/sdk/azcore"
    "github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
    "github.com/Azure/azure-sdk-for-go/sdk/azidentity"
)

// implementing TokenCredential
type CustomCredential struct {}

func (c *CustomCredential) GetToken(ctx context.Context, options policy.TokenRequestOptions) (*azcore.AccessToken, error) {
	return nil, nil
}

var _ azcore.TokenCredential = (*CustomCredential)(nil)

// calling GetToken()
func main() {
	cred, err := azidentity.NewDefaultAzureCredential(nil)
	if err != nil {
		panic(err)
	}
	tk, err := cred.GetToken(
		context.TODO(), policy.TokenRequestOptions{Scopes: []string{"https://management.azure.com/.default"}},
	)
	if err != nil {
		panic(err)
	}
}

var _ azcore.TokenCredential = (*CustomCredential)(nil)

Thanks for the explanation. I'll take a look at that and will let you know if I run into any issue.

For some additional context, there are two reasons why we have internal types that are exported via type aliases.

To break cyclic dependencies.
To offer a type in one package (e.g. azcore) but its usage in another (e.g. runtime).

I've refactored the internal content that's actually exported under an internal/exported package to make it clear.  In this process, it was discovered that we didn't actually need to do this with TokenCredential and its related types, so those are now defined in the packages from where they're exported.


OGC API - Tiles

The OGC just published https://ogcapi.ogc.org/tiles/
To be clear, TiTiler DO NOT AIM to follow the specification to the letter (because the specification is not built around dynamic tiling but more on static tiling) but we can try to follow some part.

/tileMatrixSets: List available TMS (already implemented)
/tileMatrixSets/{TileMatrixSetId}: TMS metadata (already implemented)
/conformance

Note: The Tile spec is based on the TMS 2.0 specification so we will have to update morecantile first
full spec https://docs.ogc.org/is/20-057/20-057.html

@vincentsarago Once Morecantile 4.0 is fully released,I can start working on this!

🙏

Quick update, I don't think we will be able comply with the OGC Tile 2.0 specification.
We will be able to update the tilematrixset (like https://github.com/developmentseed/tipg/blob/main/tipg/factory.py#L1275-L1364) but for the other endpoints it will be pretty hard.
DataSet Collection ({datasetAPI}/collections/{collectionId}/tiles)
We don't have collections in titiler! Some could think that /cog or /mosaic could be collectionId but this will makes things more complex.
Also the specification is pretty strict about the query parameter for the endpoints, and url=dataset url won't be accepted.
TileSet
example: https://github.com/developmentseed/tipg/blob/main/tipg/factory.py#L1366-L1555
We might still want to add tileset but I'm not sure it will be worth it especially knowing that it's pretty much impossible to titiler to be OGC compliant.
I personally, as the project maintainer, don't see any obligation to comply with OGC specification because TiTiler has existed for quite some time already and I never had official requests to make it so.


move to chained CNI execution

Move to CNI chaining mechanism as agreed upon in https://github.com/containernetworking/plugins/pull/88. One minor change is still needed to the upstream ipvlan plugin, so that plugin remains forked -- will work to upstream the fix. All installs need to move to the new plugin chained format, as this change breaks compatibility with the old cni-ipvlan-vpc-k8s configuration format.
Add reuseIPWait as a mechanism to lock IP addresses between chained plugin execution and default to 60 seconds.
Move registry to /run (tmpfs backed).

I'm excited to see ReuseIPWait implemented! I'm working on switching over to this from a similar AWS CNI plugin we wrote internally before lyft and aws released these plugins. Ours was implemented using routing, and we're itching for the ipvlan performance improvements. I identified IP reuse as an issue and was about to implement a similar change, so I'm happy I don't have to now, thanks!
For background: Early on with our CNI plugin, we noticed that rapid IP reuse was a big issue. We run hundreds of replicated clusters in Kubernetes like MySQL, Redis, etc so when we'd roll our nodes, we'd hit issues where a MySQL or redis process which was replicating from some IP was suddenly trying to replicate from a pod from a different MySQL/Redis cluster before their sidecars had time to tell them about their new master.
For this situation, 60s is generally good enough, but there is still a chance that it is too short, like if an operator is in the process of restarting on another node. We could tune that setting to something like 5 minutes, but then we'd also risk running out of IPs on smaller nodes. The way we handled this on our end was to treat the available IP pool as a FIFO queue so we'd optimistically wait as long as possible before reusing IPs. How would you feel about implementing that in this PR? It looks like it would be as easy as sorting registryFreeIPs from oldest to newest and then inverting the loop to iterate through registryFreeIPs instead of free.
If you'd prefer not to tackle it in this PR, I can follow up separately if you're all on board with the idea. Thanks!

I just saw that you mentioned us for shared subnets, thanks. We've been using it for a few months on some mid-size clusters (100+ nodes) and it has been working great so far.
In addition, you could add to the doc that the containerd runtime also works (we haven't tested it at scale yet, but it will be the case very soon)

@PaulFurtado I'm fine with moving to an approach where we optimistically wait as long as possible before reusing IPs. Let's tackle that as part of a separate PR tho.


button.when_pressed = whoops()

Is there a way we can throw an error if someone tries to set when_pressed (or when_active) to a non-callable object? It's common to accidentally write:
def hello():
    print("Hello")

button.when_pressed = hello()

https://twitter.com/CotswoldJam/status/684420747939438592
I'm guessing what happens here is it sets the .when_pressed property to None (the return value of the function). I imagine it would be easy enough to detect whether this value is callable and reject it if not.
@waveform80?

It looks as if passing a non-callable to when_pressed is already being handled. It goes through when_activated, which in turns calls _wrap_callback, and that checks if the input is callable:
def _wrap_callback(self, fn):
    if fn is None:
        return None
    elif not callable(fn):
        raise InputDeviceError('value must be None or a callable')
    ...

L180 of input_devices.py

That's true. Perhaps it's not possible then?

Precisely so, sorry: None is the default value meaning "no callback assigned". Because any routine that doesn't explicitly return a value in Python implicitly returns None, this also means that calling a function with no explicit return and assigning that to the callback will disable that callback.
One option I possibly should have considered was a special non-callable value other than None (e.g. a singleton class instance), but I'm afraid now it's established there's little we can do without a fairly major break with backwards compatibility. That said, I still think None is the natural choice for "no callback" in Python (it's certainly used in plenty of other frameworks in a similar manner) and the user does learn a valuable lesson in fixing this bug (that parentheses imply execution, while the function name alone is just referencing).
In other words, I'm not 100% convinced this requires fixing in the first instance though I do acknowledge it's likely to be encountered by people new to programming and that is admittedly a key audience for this library (an alternative view point would be that Python should warn about functions without explicit returns, or differentiate between functions that return values and those that don't ... but then that would smack horribly of VB's procedure/function distinction ;)

Ah, that's a shame.
You're right, None is definitely the natural choice for "no callback". Makes perfect sense for un-setting a callback. Anything else would be a bit odd. Shame though - would have been good to catch that common error! But of course, a useful lesson!

Why can we convert when_pressed to a property and check the value assigned when set? Would that be a "not pythonic" thing to do?

It is a property! See input_devices.py#L133
The problem is, you should be able to unset the when_pressed event by setting it to None:
button.when_pressed = None

However, if the user accidentally calls the function when passing it to when_pressed, it silently passes None. While this may surprise the user, it's expected behaviour. Observe:
>>> def hello():
...:    return "Hello"

>>> a = hello()
>>> print(a)
Hello

>>> def hello():
...:    print("Hello")

>>> a = hello()
Hello
>>> a
None

So effectively you are unsetting the event by accident.

Indeed, when execution "falls off the end" of a function without hitting a return statement, Python implicitly causes the function to return None. In other words, Python has no concept of a function that returns no value; a function always returns a value and if it doesn't do so explicitly, it will implicitly return the None value.
Now, given that when_pressed is indeed a property, we still need some value to indicate when the desired action is to "do nothing". I'd argue that the natural choice is the value None (indeed, this is what many event-driven frameworks use in such cases). However, it is true that I could have selected something different. I could have made the property accept callables only (i.e. throw an error if anything like None is assigned), and then used a callable which does nothing as the default value, e.g.:
def do_nothing():
    pass

button.when_pressed = do_nothing

However, that would require that anyone wishing to unset the property firstly know about this "do_nothing" callable, import it from somewhere, and then use it (or define their own, of course).
Unfortunately it also leads to a certain amount of inefficiency. We can't know (without disassembling the provided callable) that it actually does nothing. As a result, we'd have to permanently install event handlers for everything that could possibly have them; at the moment we can use None as an indicator that we don't need to bother listening for certain events (we don't actually take advantage of this because we haven't needed to yet, but the option exists and this is one reason frameworks prefer non-callables for such defaults).
Notwithstanding the above, the backwards compatibility argument still trumps everything else. To change now would break all code that uses None to disable an event handler (this is a particularly common use case, especially when debugging at the command line). Sorry!

Yeah I think we can agree there's nothing to be done. Thanks!

Thanks for the extensive answers, I didn't realise None was an expected value to remove the callable. gpiozero/input_devices.py#L145

Hmmm, just reading through this again (wow, 3 years later!) and a thought occurred to me...
Given that the default value of .when_pressed is None, could we emit a warning in the property-setter if the property was previously None, and we're again setting it to None?
It might help people who get caught out by the button.when_pressed = hello() example, and I can't think of any legitimate scenarios where you'd deliberately set a callback to a None value if it was None already?

Ooh that's a good idea

Implemented in PR #726


ENH: convert to / construct from ragged array (flat coordinates and offset arrays)

Fixes #1498
This still needs some more docs and tests.
Some general comments:

Input welcome on naming!

I currently called this to_coordinates_offsets and from_coordinates_offsets (I used to_ because there is a matching from_, although otherwise a get_.. would also be consistent with the other get_coordinates/get_parts/.. functions we already have)
Some other ideas that have floated before: to/from_flatcoords. In geoarrow I used flat_coords_offset_arrays

Performance:

Currently this is not an optimal implemenation (from_coordinates_offsets is about the same speed as from_wkb for a largish test case with (multi)polygons). This is mostly because of doing this with our existing APIs in multiple passes (for example in the from_ method, we first create linearrings, which we then clone in to create polygons, and clone those again to create multipolygons. This cloning takes a significant amount of time, and is not needed in this case)
We could do better with a custom implementation (eg https://github.com/pygeos/pygeos/pull/93 in cython), but I would first like to focus on the exact API to implement and the correctness, so that we could include this in a Shapely release faster. And then later for subsequent releases we can still improve the performance of the function.

Additionally, there are some API questions:

For 3D geometries, should we automatically include z in the coordinates? get_coordinates has a include_z=False keyword and so doesn't "infer" this itself
For roundtripping mixed single and multi geometries, would we like to have an option in the from_ function to return Multi geometries with 1 part as the singular version? (that doesn't guarantee a faithful rountrip, since you can have eg MultiPolygons with a single sub-polygon in your input, but I do think it would cover the large majority of use cases where someone would prefer to preserve the mixture).
Currently, this function returns the coordinates as a single, interleaved (xyxy) array (which matches our get_coordinates function). There is still some discussion about whether we should rather prefer separate arrays for x and y (xx and yy) (https://github.com/geopandas/geo-arrow-spec/pull/26/), but I think we can easily add an interleaved=True/False keyword (or other name) later to support both.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

105 of 118 (88.98%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 84.778%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shapely/_flatcoords.py
104
117
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2250

Relevant Lines:
2654

💛  - Coveralls

I don't think you need to include z at this time. GeoArrow spec iirc says that we use interleaved xy (which may be on its way out) and that if z is present it'll be in its own ListArray.
Again referencing GeoArrow, a Multi geometry with only a single member is still a multi geometry. I'm not familiar with a use case where users might like to implicitly convert Multis to singles.

GeoArrow spec iirc says that we use interleaved xy (which may be on its way out) and that if z is present it'll be in its own ListArray.

Does it? Interleaved xy and separate z would be an interesting approach (and would align geoarrow with FlatGeobuf), but my read of the current spec page is that xyz would be in a FixedSizeList column of width 3.

Point: FixedSizeList<double>[n_dim]
For an array of Point geometries, only a single array is used of interleaved
coordinates. n_dim can be 2, 3, or 4 depending on the dimensionality of the
geometries, and the field name of the list should be "xy", "xyz" or "xyzm",
reflecting the dimensionality.

Looks like your reading is the correct one! We had talked about leaving z in its own column and I assumed that's what was decided.

Yes, the current spec specifies all interleaved, and if we allow structs as well (as we are currently planning), it would be all three separate fields (although I raised the option of separate xy and z in https://github.com/geoarrow/geoarrow/pull/26#issuecomment-1251535340, but that wasn't further discussed).
But for the current PR, I am always returning a single coordinates array (we could provide an option later to not have interleaved, or to return it as Fortran ordered array, which would basically allow seeing it as separate arrays as well). And so if returning 3D data, it would simply be a (n, 3) array instead of (n, 2) array.
My main question is about what API we want here: I could detect from the first geometry in the array whether it is 2D or 3D, and then automatically return xy or xyz. Alternatively, this could require an argument specified by the user explicitly (this is what we do in get_coordinates, which by default always returns only xy, but has a include_z=True option to return xyz)

Another thought about the API: for the to_.. function, currently I always return a tuple of 2 elements: the coordinates array + a variable length tuple of offset arrays (or empty tuple in case of points) -> eg return coords, (offset1, offset2).
But alternatively, I could also return this as a flat (variable-length) tuple, where you know the first element is always the coordinates array, and then the remainder of the tuple the offset arrays -> eg return coords, offset1, offset2

I intuitively prefer the first proposal API (return coords, (offset1, offset2))
It also fits better into PEP484: Tuple[ndarray[float], Tuple[ndarray[int], ...]]

to/from_ragged_array seems like a reasonable naming convention here.

cc @ianthomas23 this will probably also be interesting for spatialpandas (conversion between geopandas/shapely geometries and  spatialpandas/awkward array like representation, which currently exist in spatialpandas but this should optimize that conversion)

@jorisvandenbossche Thanks for the heads-up here. I'll need to look into the details and see what overlap there is with what we have been considering.

I updated the PR: updated the name to to_ragged_array/from_ragged_array, fixed some bugs in handling empty geometries, and also added some explanation and expanded docstring.
There is one more API question that I bumped into (while trying to add optional support for returning 3D coordinates with an include_z like in get_coordinates).
Currently, I was always returning a flattened (np.ravel()) 1D array of coordinates, instead of the original 2D array of coordinates you get from shapely.get_coordinates (i.e. coords = shapely.get_coordinates(arr).ravel()), because this is what the list array in Arrow under the hood is. But for shapely's point of view, it's probably more logical to leave out the ravel() (it's still easy and cheap for the user to do this if they want to have the flattened array). Because then you could for example also pass those coordinates directly to eg shapely.points(..) without having to reshape them (coords.reshape((-1, 2))).
Doing this would also help when the function can optionally return z coordinates, because then you can see this from the coordinates array shape ((n, 2) vs (n, 3)), instead of having to keep track of this manually what you passed for include_z.

I think this is ready, and unless there are major comments, am planning to merge this in one of the next days (to have it included in 2.0)

@brendan-ward @caspervdw thanks a lot for the feedback!


DriftIsolate.shutdownAll is keeping isolate form exiting

Describe the bug
DriftIsolate.shutdownAll is leaking a ReceivePort, keeping the isolate from exiting when the event loop is empty.
The following program never exits:
import 'dart:io';
import 'dart:isolate';

import 'package:drift/drift.dart';
import 'package:drift/isolate.dart';
import 'package:drift/native.dart';
import 'package:path/path.dart' as p;

Future<void> main() async {
  final tmpDir = await Directory.systemTemp.createTemp();
  final path = p.join(tmpDir.path, 'db.sqlite');

  DriftIsolate? driftIsolate;

  final receivePort = ReceivePort();
  await Isolate.spawn(
    _startBackground,
    _IsolateStartRequest(receivePort.sendPort, path),
  );
  driftIsolate = await receivePort.first as DriftIsolate;

  await driftIsolate.shutdownAll();
}

void _startBackground(_IsolateStartRequest request) {
  final executor = NativeDatabase(File(request.targetPath));
  final driftIsolate = DriftIsolate.inCurrent(
    () => DatabaseConnection.fromExecutor(executor),
    killIsolateWhenDone: true,
  );
  request.sendDriftIsolate.send(driftIsolate);
}

class _IsolateStartRequest {
  final SendPort sendDriftIsolate;
  final String targetPath;

  _IsolateStartRequest(this.sendDriftIsolate, this.targetPath);
}

I think the problem is that a channel is created in _open and never close.
https://github.com/simolus3/drift/blob/7b5c33593748c60831f1f3101a8581ff13b7b50e/drift/lib/isolate.dart#L99-L101

Good catch, thanks! Fixed this in c0ec36eaaa28c1206b26b4be27b1d8d70dd59fdb.


Circuit: Extend and clean the test coverage for Validation and Confirmation in Circuit

Closes https://github.com/t3rn/x-t3rn/issues/113
Adds tests for swap with insurance, Add liquidity with + without insurance, extra tests for corfirm/protocol https://github.com/t3rn/protocol/pull/3
TODO:

[ ] Test out handling multiple side effects
[ ] Add GetData side-effect to event parser and write tests

This branch is on the old version of substrate, closing the pr in favour of an updated branch


Random spaces or broken characters in html mails with a lot of content

Hello,
we encountered an issue when sending multipart emails (html and text) with a lot of content.
There either random spaces inside the source code of the mail or broken characters because of invalid character entities.
Since things are working fine when we use the swiftmailer, we could get an idea where the error could be.
According to the RFC 2045 (search for "76"), you are doing a a hard line break instead of a soft line break after 76 characters (see Zend\Mime\Part and search for 76).
Swiftmailer is handling this 76 character limitation totally differently.
Since this is not an easy topic my thoughts are no having any kind of offense inside. My Intension is to put you into the right direction.
How can you reproduce this issue?
Send a multipart email with a lot of content in html and text.
Best regards,
Stev
[Update]
It would be cool if you could put the link to the RFC 2045 as close to the code as possible.
It took me a while to get the sense behind this "76" number when I had a look into the code.
What about this way?
    'line-length'      => 76, //@link** http://www.faqs.org/rfcs/rfc2045.html

Or put the "76" as constant on top and add the link as comment?

Is there a change of getting an update for this ticket?

@stevleibelt Could you provide a sample email that demonstrates the issue? This will be easier for us to reproduce if we aren't having to first try and craft an email to trigger the issue.
Thanks!

@weierophinney can I send you a sample of mail that breaks the swift mailer limit? I am having the same problem that I get random breaks in swiftmailer

This repository has been closed and moved to laminas/laminas-mime; a new issue has been opened at https://github.com/laminas/laminas-mime/issues/3.


schemaless inserts are truncating time to even seconds

I'm trying to use the python library (taosws) to do schemaless inserts into TDengine <IP_ADDRESS> and it seems to be incapable of inserting timestamps with more precision than one second. I've tried all the available PySchemalessPrecision arguments (Microsecond, Nanosecond, etc.).
expected behavior:
lines = [
{'metric': 'actualhighsidecurrentdc1',
'timestamp':<PHONE_NUMBER>.844247,
'value': 2.3500000000001364,
'tags': {'dataType': 'ufloat', 'units': 'A'}}
]
ar = conn.schemaless_insert([json.dumps(lines_all)], PySchemalessProtocol.Json, PySchemalessPrecision.Microsecond, 0, 0)
cur = conn.cursor()
cur.execute('select * from actualhighsidecurrentdc1')
res = cur.fetchall()
res[0][0].timestamp()
Out:<PHONE_NUMBER>.844247
observed behavior:
res[0][0].timestamp()
Out:<PHONE_NUMBER>.0

It is okay , thanks for your support


feat(os): add arch linux support

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


+m activities

🐛 Bug Report
Yesterday, probably a little over 24h before this post I used +m activities and it listed my recent activities entirely. Now I get An unexpected error occurred
The only new activity that got added to the list since then would be mining saltpetre and cluetrip.
Good luck lol

great minds think a like lol #3996

🐛 Bug Report
Yesterday, probably a little over 24h before this post I used +m activities and it listed my recent activities entirely. Now I get An unexpected error occurred
The only new activity that got added to the list since then would be mining saltpetre and cluetrip.
Good luck lol

great minds think a like lol #3996

https://github.com/oldschoolgg/oldschoolbot/issues/3996


Add support for all languages in wikitionary

Instead of continuing to add more and more ugly if cases and hardcoding the lists of the languages it might be a good idea to make the code generic to allow adding more languages by just changing a simple configuration file.
A few examples of code that needs changing:
https://github.com/tirkarthi/NotificationDictionary/blob/d8ac11d193b48c8ef5949436572c4d26fb056302/app/src/main/java/com/xtreak/notificationdictionary/MainActivity.kt#L82-L85
https://github.com/tirkarthi/NotificationDictionary/blob/d8ac11d193b48c8ef5949436572c4d26fb056302/app/src/main/java/com/xtreak/notificationdictionary/MainActivity.kt#L212
https://github.com/tirkarthi/NotificationDictionary/blob/d8ac11d193b48c8ef5949436572c4d26fb056302/app/src/main/java/com/xtreak/notificationdictionary/MainActivity.kt#L224
https://github.com/tirkarthi/NotificationDictionary/blob/d8ac11d193b48c8ef5949436572c4d26fb056302/app/src/main/java/com/xtreak/notificationdictionary/MainActivity.kt#L278-L279
Relevant issues: #39 #49 #55 #56

Agree that the language handling needs refactoring since I remember the places to update which is error prone.
The issue with adding new language is that is it's not easy to parse XML of different languages since they exist in different formats of markup without any standard to parse them. AFAIK, there is no database dump available from Wiktionary and the XML dump has to be parsed per language using Python. Since I am not a native speaker I also need to randomly verify few words to ensure the meaning and parts of speech are correct. This also involves updating CDN which is also a manual process. This makes adding new languages a tiresome process.


BinaryBuilder builds?

First I don't use the project. But maybe It would be easier to use if it was on Yggdrassil. I can contribute to this if you think it would be fine to add it.

You mean shipping LIKWID as an artifact? I mean, this would be great and feel free to try. But given that LIKWID wants to run a daemon etc. I don't think it's possible.

Commonly, the only option for bundled LIKWID is the perf_event backend which does not require a daemon and can be installed as user.


Remove blueprints (use ember-cli-frost-blueprints)

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[ ] #patch# - backwards-compatible bug fix
[x] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

At first glance, this looks like a major, but since the dependency of ember-cli-frost-blueprints is added, it should be a net-gain actually because the *-test blueprints are available now, the ones that were previously in ember-frost-test, thus the minor.
CHANGELOG

Removed blueprints for generating tests, they are now provided by ember-cli-frost-blueprints
Added ember-cli-frost-blueprints to the dependencies so that the same blueprints are still available to consumers of this addon.
Fixed #374 by doing the above.

Changes Unknown when pulling d1d0b296abeacd9b7b4dcd74bf7321019d1ef647 on job13er:remove-blueprints into ** on ciena-frost:master**.

Approved - nice win on this!


Verify the form of v1/association/toconcept/rename. Is it a query only or does it have body?

See ObservationEndpoints.renameConcept for an example

Confirmed that it was originally written as a form body with fields: old and new for both observation and association. In tapir, I set it as query params so I'll need to redo that using the RenameConcept dto objects instead.


/lib/codemirror.js missing

In latest commit (master branch) /lib/codemirror,js is missing. Is it intentional?

Yes it's a problem because I use this link in lot of application :s

This is #4328


Reading tasks from parent directories?

Is it not possible to read gulp task files from a parent directory? I have the following directory structure and using
require('require-dir')('../../config/gulp/tasks');
Doesn't read in the files.  But if I copy the folder gulp/tasks into my Modules A directory and update the paths then it works perfectly.  I'm trying to prevent unncessary duplicate task files.

project root

config

gulp
-tasks

modules

module A
module B

Thank you for any help.

What OS/node version?
I did a simple test and it seems that requireDir('../../') does resolve correctly


web extension webview can't load latest content

Does this issue occur when all extensions are disabled?: Yes

Version: 1.62.0
Commit: b3318bc0524af3d74034b8bb8a64df0ccf35549a
Date: 2021-11-03T15:28:42.479Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36 Edg/95.0.1020.44
Steps to Reproduce:
I. download file from https://xsro.vscode-unpkg.net/xsro/vscode-dosbox/0.1.6/extension/web/dist/index.js?target%3Dalpine-x64
2. download zip from https://marketplace.visualstudio.com/_apis/public/gallery/publishers/xsro/vsextensions/vscode-dosbox/0.1.6/vspackage?targetPlatform=alpine-x64 and find file in \extension\web\dist\index.js
3. the two should be the same, but they are different
I test with <vscode.dev> and find the web extension use file in step 1 which may be an old version. This make my extension doesn't work in browser

I just downloaded them and verified the files are 100% the same. Can you pin point exactly the differences you see in them, with diff?

For example, in the end of the two files

Can you redownload those URLs and verify? Cause I can't really see that difference.

Hello, Can you offer a screenshot of what you see?
Are they all look like the file in the right part of my screenshot, or left part?

Interesting, I just saw the file change myself. Did you somehow republish this extension's version? I thought this wasn't supported at all.

I use Github Action for publishing.
I think there are no way to republish the extension

I see now, the problem is the URL:

https://xsro.vscode-unpkg.net/xsro/vscode-dosbox/0.1.6/extension/web/dist/index.js?target%3Dalpine-x64
https://xsro.vscode-unpkg.net/xsro/vscode-dosbox/0.1.6/extension/web/dist/index.js?target=alpine-x64

That = is being URL encoded somehow. Where did you get that URL from?
cc @sandy081

from develop console

I find we just need to convert from Uri to string with parameter skipEncoding=true.
var {URI} = require("vscode-uri");
const link="https://xsro.vscode-unpkg.net/xsro/vscode-dosbox/0.1.6/extension/web/dist/index.js?target=web"
const uri=URI.parse(link)
console.assert(uri.toString(true)===link)//ok
console.assert(uri.toString()===link)//wrong
console.log(link,uri.toString(),uri.toString(true))

Thank you very much.  Maybe it's necessary to doc about this.

Glad to know you're unblocked here. I think the current documentation should be enough.


"New release available" text doesn't update when changing language

I noticed the blue underlined text notifying the user of a new release in the startup window does not change when switching to a different language. It instead remains in the language that the application was originally started in.
Reproduction:
-Open app in non-latest version (I used 2.33) so that a new release will be found.
-Change language through the Options window
Example: Started the app in Greek and switched to English

Thanks, it was fixed.


Add duration type support for gRPC

Description:
Need to support protobuf duration support in,

runtime level
code generation level

Related to https://github.com/ballerina-platform/ballerina-standard-library/issues/43

In protobuf, the type Duration is represented using a message like below, refer to this link for more details.
message Duration {
  // Signed seconds of the span of time. Must be from -315,576,000,000
  // to +315,576,000,000 inclusive. Note: these bounds are computed from:
  // 60 sec/min * 60 min/hr * 24 hr/day * 365.25 days/year * 10000 years
  int64 seconds = 1;

  // Signed fractions of a second at nanosecond resolution of the span
  // of time. Durations less than one second are represented with a 0
  // `seconds` field and a positive or negative `nanos` field. For durations
  // of one second or more, a non-zero value for the `nanos` field must be
  // of the same sign as the `seconds` field. Must be from -999,999,999
  // to +999,999,999 inclusive.
  int32 nanos = 2;
}

According to the above structure, syntactically it is possible to represent the Duration type in Ballerina using time:Utc; because time:Utc is a tuple that holds seconds and nanoseconds(as a fraction) values. However, semantically it is invalid to represent a time duration using time:Utc.
The optimal way to represent time duration in Ballerina is time:Seconds. Even, in the time package, we use time:Seconds to represent durations according to the following API.
public isolated function utcAddSeconds(Utc utc, Seconds seconds) returns Utc {}

Also, time:Seconds is nothing but a decimal type that represent seconds(as the whole number) and nanoseconds(as the fraction).
@daneshk @shafreenAnfar @dilanSachi WDYT?

Yes, correct. time:Seconds type is more appropriate for the protobuf duration type.


query_data_python

EPIC Link
#230
Acceptance Criteria (Tasks)

[ ] Error when running the 4th cell: "HTTPError: 500 Server Error: INTERNAL SERVER ERROR for url: https://api.maap-project.org/api/query/"
[x] Fix broken link

Closing as we are removing this notebook.


Docker Image not starting up properly

I am unable to start the standard crate container:
>  docker run  -p 4200:4200 -p 4300:4300 -p 5432:5432 crate   crate -Cnetwork.host=_site_

[2017-09-14T11:04:26,025][INFO ][o.e.n.Node               ] [Hirscheck] initializing ...
[2017-09-14T11:04:26,115][INFO ][o.e.e.NodeEnvironment    ] [Hirscheck] using [1] data paths, mounts [[/data (/dev/sda2)]], net usable_space [1.2tb], net total_space [1.9tb], spins? [possibly], types [xfs]
[2017-09-14T11:04:26,115][INFO ][o.e.e.NodeEnvironment    ] [Hirscheck] heap size [7.3gb], compressed ordinary object pointers [true]
[2017-09-14T11:04:26,465][INFO ][i.c.plugin               ] [Hirscheck] plugins loaded: [jmx-monitoring, lang-js]
[2017-09-14T11:04:27,896][INFO ][o.e.p.PluginsService     ] [Hirscheck] no modules loaded
[2017-09-14T11:04:27,898][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [crate-azure-discovery]
[2017-09-14T11:04:27,898][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [es-repository-hdfs]
[2017-09-14T11:04:27,898][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.plugin.BlobPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.plugin.CrateCorePlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.plugin.HttpTransportPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.plugin.PluginLoaderPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.plugin.SrvPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [io.crate.udc.plugin.UDCPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [org.elasticsearch.discovery.ec2.Ec2DiscoveryPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [org.elasticsearch.repositories.s3.S3RepositoryPlugin]
[2017-09-14T11:04:27,899][INFO ][o.e.p.PluginsService     ] [Hirscheck] loaded plugin [org.elasticsearch.transport.Netty4Plugin]
[2017-09-14T11:04:27,923][INFO ][o.e.n.Node               ] [Hirscheck] node name [Hirscheck], node ID [s23OqJ6bTNaWJHfGoa8nxg]
[2017-09-14T11:04:27,961][INFO ][o.e.n.Node               ] [Hirscheck] CrateDB version[2.1.6], pid[1], build[ef717e0/2017-08-29T11:08:06Z], OS[Linux/4.12.5-300.fc26.x86_64/amd64], JVM[Oracle Corporation/OpenJDK 64-Bit Server VM/1.8.0_121/25.121-b13]
[2017-09-14T11:04:28,829][INFO ][i.c.module               ] [Hirscheck] CrateDB Enterprise features are active. Please request a license before deploying in production or deactivate the Enterprise features. https://crate.io/enterprise
[2017-09-14T11:04:29,776][INFO ][o.e.d.DiscoveryModule    ] [Hirscheck] using discovery type [zen]
[2017-09-14T11:04:32,001][INFO ][o.e.n.Node               ] [Hirscheck] initialized
[2017-09-14T11:04:32,002][INFO ][o.e.n.Node               ] [Hirscheck] starting ...
[2017-09-14T11:04:32,206][INFO ][psql                     ] [Hirscheck] publish_address {<IP_ADDRESS>:5432}, bound_addresses {<IP_ADDRESS>:5432}
[2017-09-14T11:04:32,234][INFO ][i.c.p.h.CrateNettyHttpServerTransport] [Hirscheck] publish_address {<IP_ADDRESS>:4200}, bound_addresses {<IP_ADDRESS>:4200}
[2017-09-14T11:04:32,252][INFO ][o.e.t.TransportService   ] [Hirscheck] publish_address {<IP_ADDRESS>:4300}, bound_addresses {<IP_ADDRESS>:4300}
[2017-09-14T11:04:32,262][INFO ][o.e.b.BootstrapChecks    ] [Hirscheck] bound or publishing to a non-loopback or non-link-local address, enforcing bootstrap checks
ERROR: [1] bootstrap checks failed
[1]: initial heap size [268435456] not equal to maximum heap size [7906263040]; this can cause resize pauses and prevents mlockall from locking the entire heap
[2017-09-14T11:04:32,270][INFO ][o.e.n.Node               ] [Hirscheck] stopping ...
[2017-09-14T11:04:32,437][INFO ][o.e.n.Node               ] [Hirscheck] stopped
[2017-09-14T11:04:32,437][INFO ][o.e.n.Node               ] [Hirscheck] closing ...
[2017-09-14T11:04:32,453][INFO ][o.e.n.Node               ] [Hirscheck] closed

hi @zopyx, you need to set CREAT_HEAP_SIZE
like documented here:
https://crate.io/docs/crate/guide/best_practices/docker.html
sh$ docker run -d --name=crate01 \
      --net=crate -p 4201:4200 --env CRATE_HEAP_SIZE=2g \
      crate -Cnetwork.host=_site_

Closing this since the issue seems to be fixed by setting CRATE_HEAP_SIZE properly.

I am facing the same issue.
I tried using:
sh$ docker run -d --name=crate01 \
      --net=crate -p 4201:4200 --env CRATE_HEAP_SIZE=2g \
      crate -Cnetwork.host=_site_

but still the same error occur.
Please guide to resolve this.

@pooja1pathak
Could you post the logs / error message you get?
If you set CRATE_HEAP_SIZE it should either work or you should see a different error.

Hi @mfussenegger , Thanks for your response.
when I run command: docker run --name=crate01 --net=crate -p 4201:4200 --env CRATE_HEAP_SIZE=1g crate -Cnetwork.host=site
I get the following logs:
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
2019-02-20 05:06:30,212 main ERROR ThresholdFilter contains an invalid element or attribute "onMismatch"
2019-02-20 05:06:30,260 main ERROR ThresholdFilter contains an invalid element or attribute "onMismatch"
[2019-02-20T05:06:30,285][WARN ][o.e.c.l.LogConfigurator  ] [unknown] Some logging configurations have %marker but don't have %node_name. We will automatically add %node_name to the pattern to ease the migration for users who customize log4j2.properties but will stop this behavior in 7.0. You should manually replace `%node_name` with `[%node_name]%marker ` in these locations:
  /crate/config/log4j2.properties
2019-02-20 05:06:31,021 main ERROR ThresholdFilter contains an invalid element or attribute "onMismatch"
2019-02-20 05:06:31,023 main ERROR ThresholdFilter contains an invalid element or attribute "onMismatch"
[2019-02-20T05:06:31,036][WARN ][o.e.c.l.LogConfigurator  ] [Monte Borga] Some logging configurations have %marker but don't have %node_name. We will automatically add %node_name to the pattern to ease the migration for users who customize log4j2.properties but will stop this behavior in 7.0. You should manually replace `%node_name` with `[%node_name]%marker ` in these locations:
  /crate/config/log4j2.properties
[2019-02-20T05:06:31,411][INFO ][o.e.e.NodeEnvironment    ] [Monte Borga] using [1] data paths, mounts [[/data (/dev/mapper/centos-root)]], net usable_space [934.9mb], net total_space [6.1gb], types [xfs]
[2019-02-20T05:06:31,411][INFO ][o.e.e.NodeEnvironment    ] [Monte Borga] heap size [1015.6mb], compressed ordinary object pointers [true]
[2019-02-20T05:06:31,412][INFO ][o.e.n.Node               ] [Monte Borga] node name [Monte Borga], node ID [CuxO0YH_RmqQBuFpKMU8Xw]
[2019-02-20T05:06:31,445][INFO ][o.e.n.Node               ] [Monte Borga] version[3.2.3], pid[1], build[396af61/2019-02-07T12:18:27Z], OS[Linux/3.10.0-957.1.3.el7.x86_64/amd64], JVM[Oracle Corporation/OpenJDK 64-Bit Server VM/11.0.1/11.0.1+13]
[2019-02-20T05:06:31,445][INFO ][o.e.n.Node               ] [Monte Borga] JVM arguments [-Xms1g, -Xmx1g, -Djava.awt.headless=true, -XX:+UseConcMarkSweepGC, -XX:CMSInitiatingOccupancyFraction=75, -XX:+UseCMSInitiatingOccupancyOnly, -Xlog:gc*,gc+age=trace,safepoint:file=/data/log/gc.log:utctime,pid,tags:filecount=16,filesize=64m, -XX:+DisableExplicitGC, -Dfile.encoding=UTF-8, -Djna.nosys=true, -Dlog4j.shutdownHookEnabled=false, -Dlog4j2.disable.jmx=true, -Dlog4j.skipJansi=true, -Dio.netty.noUnsafe=true, -Dio.netty.noKeySetOptimization=true, -Dio.netty.recycler.maxCapacityPerThread=0, -XX:+HeapDumpOnOutOfMemoryError, -XX:HeapDumpPath=/data/data, -XX:+UnlockExperimentalVMOptions, -Des.cgroups.hierarchy.override=/]
[2019-02-20T05:06:31,981][INFO ][i.c.plugin               ] [Monte Borga] plugins loaded: [hyperLogLog, jmx-monitoring, lang-js]
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[2019-02-20T05:06:33,313][INFO ][o.e.p.PluginsService     ] [Monte Borga] no modules loaded
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [crate-azure-discovery]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [es-repository-hdfs]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.BlobPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.CrateCorePlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.HttpTransportPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.LicensePlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.PluginLoaderPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.plugin.SrvPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [io.crate.udc.plugin.UDCPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [org.elasticsearch.analysis.common.CommonAnalysisPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [org.elasticsearch.discovery.ec2.Ec2DiscoveryPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [org.elasticsearch.plugin.repository.url.URLRepositoryPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [org.elasticsearch.repositories.s3.S3RepositoryPlugin]
[2019-02-20T05:06:33,314][INFO ][o.e.p.PluginsService     ] [Monte Borga] loaded plugin [org.elasticsearch.transport.Netty4Plugin]
[2019-02-20T05:06:35,783][INFO ][o.e.d.DiscoveryModule    ] [Monte Borga] using discovery type [zen] and host providers [settings]
[2019-02-20T05:06:37,141][INFO ][i.c.p.ssl                ] [Monte Borga] HTTP SSL support is disabled.
[2019-02-20T05:06:37,841][INFO ][o.e.n.Node               ] [Monte Borga] initialized
[2019-02-20T05:06:37,841][INFO ][o.e.n.Node               ] [Monte Borga] starting ...
[2019-02-20T05:06:37,906][INFO ][psql                     ] [Monte Borga] PSQL SSL support is disabled.
[2019-02-20T05:06:38,075][INFO ][psql                     ] [Monte Borga] publish_address {<IP_ADDRESS>:5432}, bound_addresses {<IP_ADDRESS>:5432}
[2019-02-20T05:06:38,113][INFO ][i.c.p.h.CrateNettyHttpServerTransport] [Monte Borga] publish_address {<IP_ADDRESS>:4200}, bound_addresses {<IP_ADDRESS>:4200}
[2019-02-20T05:06:38,132][INFO ][o.e.t.TransportService   ] [Monte Borga] publish_address {<IP_ADDRESS>:4300}, bound_addresses {<IP_ADDRESS>:4300}
[2019-02-20T05:06:38,152][INFO ][o.e.b.BootstrapChecks    ] [Monte Borga] bound or publishing to a non-loopback address, enforcing bootstrap checks
ERROR: [1] bootstrap checks failed
[1]: max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144]
[2019-02-20T05:06:38,179][INFO ][o.e.n.Node               ] [Monte Borga] stopping ...
[2019-02-20T05:06:38,246][INFO ][o.e.n.Node               ] [Monte Borga] stopped
[2019-02-20T05:06:38,246][INFO ][o.e.n.Node               ] [Monte Borga] closing ...
[2019-02-20T05:06:38,271][INFO ][o.e.n.Node               ] [Monte Borga] closed

I think there is some issue with bootstrap checks.
Please guide me further to resolve this issue.

See https://github.com/crate/crate/issues/8227

@seut Thanks a lot.
That solved my issue.

docker run --rm -ti --privileged $CRATEDB_IMAGE sysctl vm.max_map_count=262144


[zh] removed depracated ruby client library

en PR https://github.com/kubernetes/website/pull/30461/files
/assign @tengqm

Thanks.
/lgtm
/approve


Start work on parsing JSON LD with data cleaning functions

@tfardet Could you please look this over?

Fixes #2


Basic catalog searching

Allow searching using the new catalog system, via an RDF representation in JSON-LD. Showing record details is not yet working, I am working on that in a separate branch. This branch contains the code to make sense of JSON-LD responses with nested information and with a specified order of subjects using the ActivityStreams scheme.
Known issue: #182 (Correctly handle duplicate records in external catalogs)

Thank you for the thorough review, I learned a lot from it! I have made all the requested changes, I think.

Everything has been addressed now, I will merge the pull request.


support ArchGDAL v0.7.0

https://github.com/yeesian/ArchGDAL.jl

This package does not yet support ArchGDAL 0.7, so unless you are explicitly using ArchGDAL master or dev'ed the package, there shouldn't be any problems, right?
https://github.com/evetion/GeoDataFrames.jl/blob/a6ec96bb0a2f4dc0f86304e1b67582525e7ac48b/Project.toml#L14
But from https://github.com/yeesian/ArchGDAL.jl/pull/179, this should be the fix:
_FIELDTYPE[fieldtype] -> convert(DataType, fieldtype)
And this:
https://github.com/evetion/GeoDataFrames.jl/blob/a6ec96bb0a2f4dc0f86304e1b67582525e7ac48b/src/io.jl#L14-L15
can become
table = AG.getlayer(ds, layer)

Fixed by #21


pitch period linear transformation?

https://github.com/mozilla/LPCNet/blob/master/src/train_lpcnet.py#L97
the code did some change for the pitch period feature,
periods = (.1 + 50*features[:,:,36:37]+100).astype('int16')
Why the feature is changed in this way?

same question...


[Question] How Elm handles the case in Example 2 where there are two same components underneath ?

This is a newbie's question.
I am curious how Elm differentiates the two same components underneath. Or how does it implement the namespace concept here?
Any extended source about this topic?
Thanks in advance.

Questions are better asked on the mailing list.


CF Growing Pains

CF is rapidly growing (hooray!) and teams are using it (huge win!). Buuuut the bigger it gets, the more time it takes to maintain it. Two years ago this week we decided to architect CF components as separate repos. Modularization and composability FTW. I think we made two mistakes with this decision:

We conflated modularity and compartmentalization

I kiiiind of regret breaking out CF into separate repos. It can be modular without being siloed into separate repos. Every time we update CF's testing tools or docs layout, we have to roll out those changes to 20 different repos. It's a pain. It's not a pain because there's redundant source code, it's a pain because we didn't foresee how frequently we'd iterate on components' testing, packaging and documentation. It's also annoying to have to constantly navigate in and out of directories when hacking on CF.

We didn't give enough forethought to CF maintenance.

Manually updating 20 modules' package.json's sucks (for example, if we want to switch from pa11y to node-wcag for 508 testing). Other projects handle this with a custom CLI or a centralized test script that's stored in its own repo but these things risk creating even more technical debt. We currently do it all manually which is not fun.

Note: I'm still advocating for every component to have its own manifest with dependency listing and semantic versioning. I'm simply suggesting that we move all the components' source code into the main capital-framework repo and use a build script to test and publish the components.
I don't 100% know what this would look like. Maybe we'd keep a package.tmpl file that gets processed for every component as a prepublish script? Maybe we'd just move every component into a components sub-directory of capital-framework? Maybe we'd have a separate npm (or bower) branch that stores everything in master's src directory after some processing?
I'll hack on a POC over the next couple weeks. In the meantime, please share any thoughts.
TL;DR: The larger CF grows, the harder it is to maintain. We need to fix this. I propose we move all source code into a single repo.

Another issue I'm seeing is now that we're releasing more often, PRs quickly become stale due to either the author or the reviewer not having the same exact versions of another module. I'd hate to peg versions, because a release to one module means updating every other modules dependencies. At the same time, having the ability to install a component that's not released, like say my breakpoints branch on my own fork, is a really great way to test in-progress work on a real project. It's going to be a fine line to walk, but I'm definitely in-favor of a single source that is somehow broken up when published.

@contolini Definitely interested in you pursuing this concept and developing a POC.
@jimmynotjim If we don't peg dependencies, what's the plan for preventing accidental breakage?
And you bring up a good point about testing unreleased component WIPs. How would we pull that off in this kind of scenario? I'd like to avoid any copy-and-paste-based solution. I can maybe see some ways to handle it with extensive branching.

yesssssssss one repo one repo

Concept posted in https://github.com/cfpb/capital-framework/issues/210

For the curious, here's my WIP branch.

I believe this is closed now that Voltrazord is done. Feel free to re-open if I missed something.


Update metrics-information.md

Fix the incorrect kubelet metrics link
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I have read the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

The old link is wrong. No such link at all.
So, change to correct link.


FDIV.S and FSUB.S disambiguation

Following up on #179. FDIV and FSQRT are actually defined in terms of the single precision instructions. FSQRT.S looked fine to me. I just rephrased the paragraph to be explicit about FSUB.S and FDIV.S.

Thanks!


new alternative to pulp

I just wanted to put this here for a reminder. There is a new(ish) Python solver package that we may condsider: coin-or/python-mip.

Currently ortools is the solver listed in requirements.txt. This should probably be either swapped back to coin-or/pulp or changed to python-mip. Both the options are "more" open-source and under the COIN-OR umbrella. In terms of conda-forge availability, pulp is the better option, but I have raised the issue in mip, as well.

@rwei5 can you let us know your thoughts on this. I think we want to abstract the solver and allow users options to plug into whatever solvers we can support.

In terms of the stuff I want to contribution for model building (location allocation, routing, and transportation), having a single dedicated solver would be much less painful. These three types of problems can be seem in the Integrations and Application section of the spaghetti Tutorials.

See also #2

mip was chosen in #49

details in #55

We currently used or-tools as our interface to exact solvers because or-tools allow you to use several widely used open-source and commercial solvers in addition to its own coin-or. The new coin-or/pulp James mentioned served as similar purpose.
I agree with @sjsrey maybe for exact solvers, we do not define any base exact solver and allow people to use whatever exact solver they want as long as they inherit our base class and has the .solve method.

We currently used or-tools as our interface to exact solvers because or-tools allow you to use several widely used open-source and commercial solvers in addition to its own coin-or. The new coin-or/pulp @jGaboardi mentioned served as similar purpose.

During the spopt meeting on 2020-06-05 it was decided that we adopt coin-or/python-mip for the following reasons:

python-mip is solver agnostic (like coin-or/pulp and google/ortools) and supports both coin-or/CBC (open-source) and Gurobi (commercial)
CBC is included with python-mip
Gurobi is by far the most robust and performant commercial solver with potentially dramatic performance improvements compared to Gurobi alone or the Gurobi interfaces in ortools and pulp
ortools is not available through conda-forge and though python-mip is not currently available via conda-forge, the development team is aware of the issue
region only adopted ortools as the solver interface since the last release; previously pulp had been used and the EOL release for region lists pulp as a requirement
python-mip's syntax is modeled after pulp

I agree with @sjsrey maybe for exact solvers, we do not define any base exact solver and allow people to use whatever exact solver they want as long as they inherit our base class and has the .solve method.

The current framework for spopt, like region before it, does not enforce a specific solver.
If this issue warrants further consideration we should discuss it in the next spopt hack and/or the September dev meeting.

The current framework for spopt, like region before it, does not enforce a specific solver.
If this issue warrants further consideration we should discuss it in the next spopt hack and/or the September dev meeting.

There is an spopt meeting this friday at 9am on the pysal calendar.

There is an spopt meeting this friday at 9am on the pysal calendar.

I have started a meeting notes wiki that mimics the one in pysal/pysal. The first meeting notes entry is here.

closing for now -- solver agnostic is the way to go -- we just have to make sure the include all necessary solvers/wrappers in the requirements, etc.


Screen API

This is mostly just a direct port of the fabric screen api with some minor changes such as

Some naming changes in mixins per the contributing guidelines
Events as entrypoints

To be completed:

[ ] Javadoc (Currently there is just the existing fabric javadoc, which i think would suffice with some minor changes)

@EnnuiL might want to double check the javadocs of the input stuff, since I've heard stuff about GLFW and MC constants.

Ah, while the initial plan of the input refactor was to switch to Minecraft's constants (and those were indeed refactored), we ended deciding to keep using the GLFW constants;
I checked the javadocs anyway, and yeah, it all seems correct


Rewrite of Operate pages

Updates the operations pages for the 0.9 release changes and terminology updates:

CLI page: remove duplicate commands
Registration: update commands, improve layout, update terminology
Invocation: update commands, improve layout, update terminology
Versioning: update commands, improve layout, update terminology
Tracing page: update commands, improve layout, update terminology

Remove architecture page because it's outdated and provides unnecessary details

@tillrohrmann I will merge this PR and then go through all the docs to update the CLI command outputs.


Change embedding and LLM model

Change it to use Jina embeddings and Llama3.2 90B as the LLM via groq.

Can i work on this @sujith27pes

sure


[WIP]Download Android APK feature. Issue: #11647

https://github.com/zulip/zulip/issues/11647
Testing Plan:
Manual visual testing
GIFs or Screenshots:

@theredcap you need to refactor the commit message. You can learn here
And as far as the code is concerned, logic wise it appears fine to me but I have one question, in apps.html why did you use
 structure?

@theredcap you can put your styling in /static/styles/landing-page.scss

I applied the cleanups suggested by @borisyankov, made some minor styling cleanups, and merged this as 8e1dff708e2dd109eebde4fe7049cc147fb142a6.  Thanks for working on this @theredcap!
I didn't close the original issue, because we still need to replace the two badges.  @borisyankov do you want to just take care of that change?  The code involved is:

update_page in static/js/portico/landing-page.js, plus apps_events in that same file.
templates/zerver/apps.html
static/styles/landing-page.scss
https://play.google.com/intl/en_us/badges/ and the similar page for iOS.


File Corrupted: AstroML/data/sdss_spectra/spec4000_corrected.npz

The file of spec4000_corrected.npz located at AstroML/data/sdss_spectra/ is corrupted.
Error message received when either trying to load it with numpy.load() or open it with 7-zip.
Is it possible to replace it with the right copy? :smiley: @cxnvcarol @diego0020 @juandoso

The original source of the data file was moved/deleted and is no longer available. I suggest to check the updated version of the AstroML tutorial at https://github.com/astroML/astroML


Searching in collectibles tab will display regular tokens rather than NFTs

Expected: only filter collectible tokens when using this particular search bar.

FYI. The version in iOS just have 1 way of searching, no matter which "tab" the user is in, once the user starts search, it is against "All" and doesn't have the tile/grid layout anymore. Simpler and harmless, if it's easier.


Experiment using WebWorker and comlink

This is an experiment in using a WebWorker and comlink in this extension. It doesn't do anything useful yet, we are debugging at this stage.

The latest commits seem to be helping:

Thanks, this is great. I will try to incorporate it into my experiments using WASM commands.

Closing as superseded by #15.


[release/2.7 backport] Add reference.ParseDockerRef utility function

backport of https://github.com/docker/distribution/pull/2786 for the release/2.7 branch
to address https://github.com/containerd/containerd/issues/3031 if included in a 2.7.x patch release
ParseDockerRef normalizes the image reference following the docker
convention. This is added mainly for backward compatibility. The reference
returned can only be either tagged or digested. For reference contains both tag
and digest, the function returns digested reference, e.g.
docker.io/library/busybox:latest@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa

will be returned as
docker.io/library/busybox@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa.

@dmcgowan @caervs - no idea if there's plans to do a 2.7.2 release, but thought I'd open a backport (in case there are plans)

ping @dmcgowan PTAL

rebased to make the vendor-check pass (which should be fixed by https://github.com/docker/distribution/pull/3001)

ping @dmcgowan @manishtomar @stevvooe PTAL

LGTM


Add Pre-Commit Hooks Definition

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Footer mobile view needs a little improvement

yes you can take this up and fix it

can you assign me?


cherry-pick changes from feature/ase_plugin to feature/ase_plugin2 (#…

…1252)

ASE: adding ASE as a plugin.
Lzhan55/ase plugin (#1236)
Lzhan55/ase plugin2 (#1247)
ASE: Added a libopae-c-ase.so to make ASE application backward compat… (#1250)

libopae/plugins/ase/Makefile is still missing.


VMware/KVM migration to KVM - the OS type is not set (CentOS 4.5 32bit, by default). VM settings also empty

ACS <IP_ADDRESS> (RC2):
New ACS Feature from 4.19:
Migrating a VMware VM to KVM - the end resulting VM has OS type set to "CentOS 4.5 32bit" - since the form doesn't provide a way to choose the OS type during the conversion (nor do we, as it seems?, check for the OS type in the migration process)
The same is true for the feature: Importing KVM from QCOW2 on a shared/local storage feature - there is no way to choose the OS typd

If we don't have time to fix this for 4.19, then, at the bare minimum, we should be updating documentation to state the needed next steps after the VM is imported (and before powering it for the first time). In some cases, VM settings/details also need to be set (if the migrated VM is for example EUFI-enabled)
cc @shwstppr @DaanHoogland @weizhouapache @rohityadavcloud

We have added a note about the default import template and its guest OS type on: https://github.com/apache/cloudstack-documentation/pull/377

@nvazquez , is this all we do about this (i.e. can we close this ticket?)

I'm fine if we keep it for future migration improvement

Improvement to come in future releases


added my name to contributer list

Thank you!

Hi  @dksehdals216, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


GSK-1993 Updated usage of enum value to enum name

Description
Use enum name instead of values for serialization
Related Issue

GSK-1993 (Available on Linear)

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[x] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

@kevinmessiaen Maybe we should change the enums type to (str, Enum) also ?
This may allow more easy comparison


Include "total" when doing a Find

I would like to see the total number of search results displayed in the UI.
(I think I've seen this in the issue list before, sorry if its a duplicate.)

@waderyan editor or search viewlet?

I believe I had search viewlet in mind...

We have it.


push src/nmdc_submission_schema/scripts/check_examples.py and refine later

pushed into main in

https://github.com/microbiomedata/submission-schema/commit/c4247332561712a87f19fb4489ce65fea8f19b09

the attribute_usage_count.tsv output might be the most unique added value, but that's bout the schema, not about the example data!


Random test failure - Client bidirectional Streaming

A random failure on the test :
"frees-rpc client should be able to run client bi-directional streaming services"
with the error:
List() was not equal to
List(E(A(100,200),foo3), E(A(1000,2000),foo4))

is ignored on Travis for now

Possible duplicated by #164

Closing as duplicate of #164 since those only seem to happen for FS2 bidi tests; let's (re-)open as a separate issue if we see it happening with Monix and/or non-bidi tests.
(Folks getting notifications for the testing issues: sorry to have gotten your hopes up)


ImportError: cannot import name 'marketfeed' from 'dhanhq'

aftr installing whl file I am getting error for code 2 of example
from dhanhq import marketfeed
C:\Users\Sudhakar\Downloads>pip install dhanhq_ticker_py-0.1.0-py3-none-any.whl
Processing c:\users\sudhakar\downloads\dhanhq_ticker_py-0.1.0-py3-none-any.whl
Requirement already satisfied: python-dotenv in c:\users\sudhakar\appdata\local\programs\python\python311\lib\site-packages (from en
dhanhq-ticker-py is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of
C:\Users\Sudhakar\Downloads>cd ..
C:\Users\Sudhakar>python dhan.py
Traceback (most recent call last):
File "C:\Users\Sudhakar\dhan.py", line 1, in
from dhanhq import marketfeed
ImportError: cannot import name 'marketfeed' from 'dhanhq' (C:\Users\Sudhakar\AppData\Local\Programs\Python\Python311\Lib\site-packa

Attempting uninstall: dhanhq-ticker-py
Found existing installation: dhanhq-ticker-py 0.1.0
Uninstalling dhanhq-ticker-py-0.1.0:
Successfully uninstalled dhanhq-ticker-py-0.1.0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
breeze-historical-options 1.2 requires attrs==23.1.0, but you have attrs 23.2.0 which is incompatible.
breeze-historical-options 1.2 requires certifi==2023.11.17, but you have certifi 2024.2.2 which is incompatible.
breeze-historical-options 1.2 requires numpy==1.26.2, but you have numpy 1.26.4 which is incompatible.
breeze-historical-options 1.2 requires python-dotenv==1.0.0, but you have python-dotenv 1.0.1 which is incompatible.
breeze-historical-options 1.2 requires urllib3==2.1.0, but you have urllib3 2.2.0 which is incompatible.
yfinance 0.2.36 requires beautifulsoup4>=4.11.1, but you have beautifulsoup4 4.9.3 which is incompatible.
Successfully installed Brotli-1.1.0 TgCrypto-1.2.5 aiohttp-3.9.3 aiosignal-1.3.1 attrs-23.2.0 boltons-23.1.1 certifi-2024.2.2 charset-normalizer-3.3.2 dhanhq-ticker-py-0.1.0 docopt-0.6.2 environs-10.3.0 frozenlist-1.4.1 idna-3.6 marshmallow-3.20.2 msgpack-1.0.7 multidict-6.0.5 numpy-1.26.4 packaging
-23.2 polars-0.20.7 pycryptodome-3.20.0 python-dotenv-1.0.1 requests-2.31.0 scipy-1.12.0 setuptools-69.0.3 sourcedefender-11.0.10 urllib3-2.2.0 websockets-12.0 wheel-0.42.0 yarl-1.9.4
C:\Users\Sudhakar\Downloads>
C:\Users\Sudhakar\Downloads>pip show dhanhq
Name: dhanhq
Version: 1.2.3
Summary: The official Python client for communicating with the Dhan API
Home-page:
Author: Dhan
Author-email<EMAIL_ADDRESS>License: MIT LICENSE
Location: C:\Users\Sudhakar\AppData\Local\Programs\Python\Python311\Lib\site-packages
Requires: pandas, requests
Required-by:
now tell what's wrong?


Windows: Remove MSVC define redundant with _MSC_VER

See https://github.com/godotengine/godot/pull/81200#discussion_r1335783464.

Indeed, thanks. Just noticed that one too.


MAINTAINERS: Misc updates

Added @benburkert and @bgentry so they can sign off on stuff going into master, also fixed a bunch of email addresses.

lgtm


GetBlogPost Function

The GetBlogPost function under scrape-blog is missing

Thanks for reporting this. It has now been added.

resolved


Unable to ad fill color to icons

Package name(s)
Icons (@salt-ds/icons)
Package version(s)
"@salt-ds/core": "^1.25.0",
"@salt-ds/icons": "^1.11.0",
"@salt-ds/theme": "^1.14.0",
Description
fill color is not getting applied to icons. If I give it value like 'red' it works. However, var(--salt-status-negative-foreground) is not working as expected
<ArrowDownIcon
style={{ fill: "var(--salt-status-negative-foreground)" }}
size={2}
/>
Steps to reproduce
No response
Expected behavior
No response
Operating system

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

The code works, please debug your app to see why css variable is not resolving correctly.
https://stackblitz.com/edit/salt-template-xv6dvu?file=App.tsx

I can see it's working in above example. Maybe something wrong at my end. I am using ember app with honeycomb library to render react components. Not sure, If that's messing things up.

Raise a question on go/ask-salt, which you can paste screenshot of your CSS inspector. We need to understand what actually happens, e.g., whether the color is overridden by others, or css variable is not resolved because salt-theme is not there.

I could see that variable was not resolved in the inspector. I'll share the screenshot in sometime

I have imported import<EMAIL_ADDRESS>file. Unable to add screenshot here

What about SaltProvider

Yes added that as well

Even the button component's style is not getting added. I feel css is somehow not getting loaded properly. I can see in inspector variables are not getting resolved

Can't reproduce this, closing to indicate not a bug.


[Paypal] Allow to provides Content-Security-Policy nonce to iframe

Problem
I would like to use Content-Security-Policy on my website with nonce-* instead of unsafe-inline.
When I do that, it blocks Paypal inline scripts included in their iframe since they don't have the nonce value.
Possible solution
Paypal has a way to provide a nonce, as explained here.
I think it could be a nice security improvement if Adyen component could handle this.
Maybe it's also applicable to other payment providers.

Hi @Altahrim,
Thanks for raising this. We will add this to our backlog and update you once it's ready. Hope this helps!

Hi @Altahrim
We released a new version this week (5.2.0) which the cspNonce can be passed to Paypal component.
I'll close this ticket, but feel free to reach out to us if you find any issue related to this matter.
PR: #1339


Possibility of a command to perform a subroutine X times

I'm carefully considering this

Is this worth adding?

This is unlikely to be added in the forseeable future as it detracts from the simplicity of this language. The slippery slope would continue and there would be the addition of more complex constructs like while loops.


Multiples tables, same page, different settings

Hello.
If I have the following code:
    var sset = {
        paging: false,
        searching: false,
        rowsGroup: ['some1:name'],
        columns: [{
            name: 'some1',
            title: 't1',
        }, {
            name: 'some2',
            title: 't2',
        }]
    };

    var uset = {
        paging: false,
        searching: false,
        ordering: false,
        rowsGroup: ['some3:name'],
        columns: [{
            name: 'some3',
            title: 't3',
        }, {
            name: 'some4',
            title: 't4',
        }]
    };

    var table_sorted = $('#table_sorted').DataTable(sset);
    var table_unsorted = $('#table_unsorted').DataTable(uset);

    $("#add_stuff").click(function() {
        for(var i=0; i<4; i++) {
            table_sorted.row.add(['value' + count, i]);
            table_unsorted.row.add(['value' + count, i]);
        }
        table_sorted.draw();
        table_unsorted.draw();
        count++;
    });

Only on of the tables will correctly group rows. The other will not.
In different experiments, the first table is the one which gets rows to group, while in other experiments, it is the second.
Is this a bug in the plug-in, some limitation of it, or am I missing something?
Thank you.

Yes. This is known defect in plugin. I discovered it before the first release but used the plugin only for one table without any modifications. This should be fixed soon (I expect so)

any update? @ashl1

I have the same problem, any update?


Addresses cross compile for syscall.Unmount by delegating to Mount.

You will need to re-enable your plug-in as well in the kubelet.

make release-skip-tests now passes

LGTM

Shippable is green


[Client] Allow to create two client instances

The way a client is instanced right now is buggy (guilty here) because everytime we create a client instance, we alter the Class variable routes.
As a consequence, if we want to create two client instances (for whatever reason), the second instance will have incorrect routes as it will use the already altered class variable.

 class Client:

   routes = {"token": "/login/access-token",
               ...
              }

    def __init__(self, api_url, credentials_login, credentials_password):
        self.api = api_url
        self._add_api_url_to_routes()
        ...
    def _add_api_url_to_routes(self):
        for k, v in self.routes.items():
            self.routes[k] = urljoin(self.api, v)
     ...

Suggested solutions:

change  the current routes class variable to "_routes" and create a deepcopy self.routes in the constructor before calling _add_api_url_to_routes.
Refactor the whole class construction.

Thanks for reporting that, I actually tackled it in #74 changing the way the routes attribute gets created. That solves the problem on my end, let me know if it doesn't on yours!

@florianriche could you tell me how to reproduce the bug?
If it was indeed fixed by #74 as suggested earlier, we can close this issue :ok_hand:

Solved by #74

@frgfm I close it at samedi tome of your comment !
Just noticed the big when in a terminal trying to  test the client,  id you créate a first api-client and then a second, the second wont ne able to retrieve a token. I think it is solved know.


chore(wayland) : accelerate damage updates, reduce unnecessary cycles

I think it's better to optimize the efficiency according to different occasions here.

Before:

After:

This is when running on my host computer. In fact, it takes about 8ms to refresh the entire image on my embedded target.

Can we keep both? If LV_COLOR_DEPTH is the same as the system's color depth use memcpy else convert it.

The system's color depth can be different to LV_COLOR_DEPTH. Is that what you mean? I didn't consider the situation.
Maybe I need some time to consider how to improve it.

Hi @kisvegabor , I checke the current code and find that this modification is sufficient.
As lv_conf.h show:
/*Color depth: 1 (1 byte per pixel), 8 (RGB332), 16 (RGB565), 32 (ARGB8888)*/
#define LV_COLOR_DEPTH 32

And logic for mapping pixel types in wayland.cpp :
static void shm_format(void *data, struct wl_shm *wl_shm, uint32_t format)
{
    struct application *app = data;

    switch (format)
    {
#if (LV_COLOR_DEPTH == 32)
    case WL_SHM_FORMAT_ARGB8888:
        app->format = format;
        break;
    case WL_SHM_FORMAT_XRGB8888:
        if (app->format != WL_SHM_FORMAT_ARGB8888)
        {
            app->format = format;
        }
        break;
#elif (LV_COLOR_DEPTH == 16)
    case WL_SHM_FORMAT_RGB565:
        app->format = format;
        break;
#elif (LV_COLOR_DEPTH == 8)
    case WL_SHM_FORMAT_RGB332:
        app->format = format;
        break;
#elif (LV_COLOR_DEPTH == 1)
    case WL_SHM_FORMAT_RGB332:
        app->format = format;
        break;
#endif
    default:
        break;
    }
}

I think there will not happen color depth is equal to 24 bits.And we don't need to consider it like fbdev.cpp:
    /*32 bit per pixel*/
    if(vinfo.bits_per_pixel == 32) {
        uint32_t * fbp32 = (uint32_t *)fbp;
        int32_t y;
        for(y = act_y1; y <= act_y2; y++) {
            location = (act_x1 + vinfo.xoffset) + (y + vinfo.yoffset) * finfo.line_length / 4;
            memcpy(&fbp32[location], (uint32_t *)color_p, (act_x2 - act_x1 + 1) * 4);
            color_p += w;
        }
    }
    /*24 bit per pixel*/
    else if(vinfo.bits_per_pixel == 24 && LV_COLOR_DEPTH == 32) {
        uint8_t * fbp8 = (uint8_t *)fbp;
        lv_coord_t x;
        int32_t y;
        uint8_t *pixel;
        for(y = act_y1; y <= act_y2; y++) {
            location = (act_x1 + vinfo.xoffset) + (y + vinfo.yoffset) * finfo.line_length / 3;
            for (x = 0; x < w; ++x) {
                pixel = (uint8_t *)(&color_p[x]);
                fbp8[3 * (location + x)] = pixel[0];
                fbp8[3 * (location + x) + 1] = pixel[1];
                fbp8[3 * (location + x) + 2] = pixel[2];
            }
            color_p += w;
        }
    }
    /*16 bit per pixel*/
    else if(vinfo.bits_per_pixel == 16) {
        uint16_t * fbp16 = (uint16_t *)fbp;
        int32_t y;
        for(y = act_y1; y <= act_y2; y++) {
            location = (act_x1 + vinfo.xoffset) + (y + vinfo.yoffset) * finfo.line_length / 2;
            memcpy(&fbp16[location], (uint32_t *)color_p, (act_x2 - act_x1 + 1) * 2);
            color_p += w;
        }
    }
    /*8 bit per pixel*/
    else if(vinfo.bits_per_pixel == 8) {
        uint8_t * fbp8 = (uint8_t *)fbp;
        int32_t y;
        for(y = act_y1; y <= act_y2; y++) {
            location = (act_x1 + vinfo.xoffset) + (y + vinfo.yoffset) * finfo.line_length;
            memcpy(&fbp8[location], (uint32_t *)color_p, (act_x2 - act_x1 + 1));
            color_p += w;
        }
    }
    /*1 bit per pixel*/
    else if(vinfo.bits_per_pixel == 1) {
        uint8_t * fbp8 = (uint8_t *)fbp;
        int32_t x;
        int32_t y;
        for(y = act_y1; y <= act_y2; y++) {
            for(x = act_x1; x <= act_x2; x++) {
                location = (x + vinfo.xoffset) + (y + vinfo.yoffset) * vinfo.xres;
                byte_location = location / 8; /* find the byte we need to change */
                bit_location = location % 8; /* inside the byte found, find the bit we need to change */
                fbp8[byte_location] &= ~(((uint8_t)(1)) << bit_location);
                fbp8[byte_location] |= ((uint8_t)(color_p->full)) << bit_location;
                color_p++;
            }

            color_p += area->x2 - act_x2;
        }
    } else {
        /*Not supported bit per pixel*/
    }

I think vinfo.bits_per_pixel == 24 && LV_COLOR_DEPTH == 32 is what you worry about before.

The original code could convert to color depth if Wayland's color depth and LVGL's color depth wasn't matching. It seems this functionality is dropped in this PR.

There may be situations I don't know, so I revised it according to your suggestion.

But I did check the codes. Though original codes can solve the 24 lv color depth to 32 system color depth, it's impossible in such context. But anyway, thank you for your careful consideration.

The last commit look good to me. Thank you very much! :slightly_smiling_face: