BUG: trust-constr Bounds exclusive

Reference issue

Closes #15093
What does this implement/fix?

The scipy docs define Bounds as inclusive but trust-constr treats bounds as exclusive. According to Nocedal, Jorge, and Stephen J. Wright. "Numerical optimization" Second Edition (2006), p. 393, interior point methods necessarily treat bounds as exclusive. To work around this limitation of interior point methods and create consistent behavior for Bounds, this PR modifies trust-constr so that Bounds passed to trust-constr are expanded by epsilon.
Additional information

Thank you @ellieLitwack

Thank you @ellieLitwack


beautify never really start

I have no gist to provide since it won't produce it.
I tried this on ubuntu 14.04 and ubuntu 15.10
I have the latest version of atom and the latest version of pep8 and autopep8.
here is a code sample :
""" this is a sample file """

def(  pep8error,anotherone):
    return;

here is the result when applying autopep8 :
""" this is a sample file """

def(pep8error, anotherone):
    return

Now when I'm in atom and start to beautify the file, either with ctrl+alt+b, or trying to produce a debug gist with the Atom Beautify: Help Debug Editor command, a pop up appears,  "beautification in progress", it's loading and nothing more is happening.

I have a similar issue in so much that when I activate Beautify, the pop-up window comes up, and just spins telling me that "Beautification in progress", but nothing happens.  The window will remain open, and no beautification ever takes place.   I have to hide the window, and I never get any results.  Have tried w/ debugging and same happens, but w/ no debugging information.


[#17] updated README with deployment instructions to Firebase, added …

…firebase config files

This looks fine to me, though I don't know heaps about Firebase.
@hollyschinsky could you have a look?


custom community logo not shown with nctr-gsl-dev

I'm running a node locally and registered a custom community
then running ipfs locally too:
ipfs daemon

starting the app and selecting the community gives me
======== Exception caught by image resource service ================================================
The following NetworkImageLoadException was thrown resolving an image codec:
HTTP request failed, statusCode: 400, http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png

When the exception was thrown, this was the stack:
#0      NetworkImage._loadAsync (package:flutter/src/painting/_network_image_io.dart:99:9)
<asynchronous suspension>
Image provider: NetworkImage("http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png", scale: 1.0)
Image key: NetworkImage("http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png", scale: 1.0)
====================================================================================================

And I only see the default encointer faces as community logo

I'm running a node locally and registered a custom community then running ipfs locally too:
ipfs daemon

starting the app and selecting the community gives me
======== Exception caught by image resource service ================================================
The following NetworkImageLoadException was thrown resolving an image codec:
HTTP request failed, statusCode: 400, http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png

When the exception was thrown, this was the stack:
#0      NetworkImage._loadAsync (package:flutter/src/painting/_network_image_io.dart:99:9)
<asynchronous suspension>
Image provider: NetworkImage("http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png", scale: 1.0)
Image key: NetworkImage("http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png", scale: 1.0)
====================================================================================================

And I only see the default encointer faces as community logo

look at your url: http://<IP_ADDRESS>:8080/ipfs/null/icons/3.0x/community_icon.png
null means, that communityIconsCid is not set, yet!
this is taken from metadata, so metadata was still null.
but also, I think that it won't work to locally display the icon when accessing <IP_ADDRESS>.2:8080/ipfs/CID/...
i think it should be on another adress for local host (not sure, but do you know what the url should be where you can access your cid? i think its <IP_ADDRESS> or your local ip.. smth. like that)

I guess this has been resolved with #404, #405


[Bug] TRADFRI bulb E27 state not updated

Using zigbee2mqtt latest version with homebridge-z2m. One of the zigbee devices is https://www.zigbee2mqtt.io/devices/LED1732G11.html#ikea-led1732g11
Problem: When I control light bulb from home app, the state is not updated:
example:

light is off, i turn it on from home app, it will stay on for 1 second then turn off (just in home app, the light is still on). if i press again in home app on the light, it will "stay" on.
light is off, i press on home app to turn it on, it will stay on for 1 second then display as off (only in home app), in reality the light bulb remains on. if i press again on homeapp accessory it will remain on.
go to zigbee2mqtt ui and manually turn on/off the bulb, the state is updated ok in home app.
manually publish "{"state":"OFF"} of {"state":"ON"} to MQTT topic, bulb will turn off or on and the state in home app will update as expected
Only when i control the accessory from home app, the state will not be updated in home app.

{
            "mqtt": {
                "base_topic": "zigbee2mqtt",
                "server": "mqtt://MY_MQ_IP:MY_MQ_PORT",
                "reject_unauthorized": false,
                "keepalive": 60,
                "version": 4
            },
            "defaults": {
                "exclude": false
            },
            "platform": "zigbee2mqtt"
        },

Homebridge Zigbee2MQTT: homebridge-z2m v1.8.0

sounds like a duplicate of #383. Please try to workaround mentioned there.

Thanks,
that fix it.

duplicate of https://github.com/itavero/homebridge-z2m/issues/383

duplicate of https://github.com/itavero/homebridge-z2m/issues/383


Fix/detect windows excluded ports

Add an extra step to check if a port is in excluded port range on Windows

So it basically returns "reserved" instead of "closed" for those ports, right?
Can you give a use case where such a distinction would be important?
I'm also concerned, since this project is so old, about projects that might depend on it being "closed" and not be able to handle an entirely new keyword. Basically could this change affect users negatively?
Great catch BTW!

First, I apologize for leaving this PR inactive for so long. I've been quite busy recently.
I've been using this package to search for an available port within a preferred range to bind a new server. While it generally works well, I've encountered occasional instances where I couldn't bind a server even though the package indicated that the port was not in use (i.e., 'closed').
After some research, I discovered that Windows might 'exclude' certain ports. This means that these ports are reserved by other software or the OS, making them unavailable for binding even though they appear to be free.
I understand that this could be a breaking change, so it might be better to introduce a new function to address this issue.
I'm figuring out how to write reliable test cases. However, testing 'excluded port ranges' can be challenging since they vary randomly, and some environments may not have them at all.
(And apologies for my bad English - I used ChatGPT to correct the grammar.)

Thanks for the detailed explanation!
Ok so it seems the keyword 'reserved' is not really necessary in your use case, right? You only just wanna know if it's 'open' or 'closed', right?
So why not just have it return 'open'?
It's the breaking away from these two keywords that we currently use: 'open' and 'closed', and introducing a new 'reserved' that might be (more of) a breaking change, than simply just amending the functionality to check whether a port (for whatever reason - reserved or otherwise) is open or closed.

since they vary randomly

As for tests, you can just use the command above to find out those ports during tests.

tests.js
function findExcludedPorts () {
  if (!isWindows) return [] // nothing to check if not windows, right?
  const output = execSync('... net sh command to find excluded ports')
  const excludedPorts = output.something
  // return excludedPorts
  const sample = output[1]
  test.cb('...', t => {
    portScanner.find(sample) //... test here
  })
}

Yes, the keyword 'reserved' is not necessary to me. However, I think returning 'open' for excluded ports may be a breaking change too, since originally it returned 'closed'.
And the test code you provided will work in most cases, but we have some edge cases where there are no excluded ports; in this case we cannot test anything (the test will pass though).

If the main objective is just finding a free, bindable port, it would be fine.

Hmm, what other use cases are you thinking might be there?
As far as I can tell, that's probably the main purpose:

Portscanner can check a port, or range of ports, for 'open' or 'closed' statuses.

it’s worth noting that the test could produce false positives in rare circumstances.

probably fine, tests don't need to be exhaustive, just covering the basics is a good start, we can refine later if we need to.

Hmm, what other use cases are you thinking might be there?

Maybe someone can use this package to detect whether some server program is running (they can do this check without this package by sending arbitrary request... but just in case). So I can't say this is 100% safe from breaking something.
The only way I can come up with not to break anything is, just adding an option to let users decide whether it should check excluded ports or not. (Or we can add new methods - e.g. isPortExcluded / findBindablePort)

Maybe someone can use this package to detect whether some server program is running (they can do this check without this package by sending arbitrary request... but just in case). So I can't say this is 100% safe from breaking something.

I'm not sure I understand, could you elaborate as an example?
Right now, if a user tests a reserved port (say 5357) it would currently return "closed", right?
And if we fix this by changing it to "open", how would it break that user's use case? Like what could such a user be doing with "closed" return value for this reserved port?

isPortExcluded

Great idea, but also fully agree on it complicating things further. This might go into scope creep (original package intent is to just find out open ports).

Personally I'm still leaning towards changing it to "open" and calling it a day. That would be the least of a breaking change than all other ideas IMO.

I'll give you an another example since I also don't think the example I gave you is appropriate.
Consider a port scanner, which scans for literally "open" ports, to check if we can "communicate" with those ports (not to check if we can "bind" a new server). A hacking tool that checks vulnerability of all the open servers can be an application example. For this case, if we mark excluded ports as "open", the communication will fail since there is no server bound to those ports.

I'm convinced, thanks for persisting! Let's go forward with this.
I tried adding some tests but it seems not all ports given by the netsh command are returning the "reserved" keyword. Could you improve on this? We don't need to be exhaustive but we do need it to be reproducible.
ports: [
  [ '2869', '2869' ],
  [ '36189', '36288' ],
  [ '36289', '36388' ],
  [ '50000', '50059' ]
]
portsToCheck: [
   2869, 36189, 36190,
  36191, 36289, 36290,
  36291, 50000, 50001,
  50002
]
testing: 2869
testing: 36189
testing: 36190
testing: 36191
testing: 36289
testing: 36290
testing: 36291
testing: 50000
testing: 50001
testing: 50002
50002 { error: null, status: 'closed' }
50001 { error: null, status: 'closed' }
50000 { error: null, status: 'closed' }
36291 { error: null, status: 'reserved' }
36290 { error: null, status: 'reserved' }
36289 { error: null, status: 'reserved' }
36191 { error: null, status: 'reserved' }
36190 { error: null, status: 'reserved' }
36189 { error: null, status: 'reserved' }
2869 { error: null, status: 'open' }

As you said before, adding a new keyword "reserved" can also break something as returning "open" for excluded ports can. There are several options we can try to keep backward compatibility:

Add option
Introduce a new method
To make things easier, just bump the major version and document about the new keyword.

And thanks for working on the tests! As I know, the range 50000~50059 is 'administered port exclusions' (you can see '*' on the output), which means the user can freely bind a new server since the user reserved them.
I have no idea about 2869 BTW. Did you run the tests multiple times? It could be a timing issue.

I was planning to but I did not get a chance to improve the tests yet, let me know if you're able to. They just need to be reproducible (even if we test just a few ports). Like is there a way to know for sure which ones would return the "reserved" status? Also probably worth considering not creating any false positives (a "closed" returning "reserved")?
Also yeah releasing a new major was my plan as well.


Do not import polyfills from non polyfill code

This relies on Map being available on all platforms used for transcoding. Looks like we only use the basic layer. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
LGTM


headers with a standard name like string.h and limits.h should be renamed

Reported as: lp:1436744
Reported by: lp:~grobbelaar
Reported at: 2015-03-26T08:52:21Z

Imported from Launchpad using lp2gh.

$ find . -name string.h
./third_party/libmemcached/libmemcached-1.0/struct/string.h
./third_party/libmemcached/libhashkit-1.0/string.h
./third_party/libmemcached/libhashkit/string.h
./third_party/libmemcached/tests/string.h
"string.h" is a header from the C runtime library. Project headers should not use this name.

Due to this, Windows in-tree builds of PECL/memcached fail, because other extensions include these files:
C:\php-snap-build\dep-aux\vs16\x64\libmemcached\include\libhashkit-1.0\string.h(27): error C2054: expected '(' to follow 'HASHKIT_API' (compiling source file ext\bz2\bz2.c)
…

Yeah, libmemcached/include/libhashkit-1.0 and siblings must not be in the include paths

And that is even possible. Thanks!


ARM fails to decode "NV" (never) condition code

Describe the bug
The ARM disassembler / SLEIGH description does not include the "NV" condition code. This is sometimes (mis)used in 26bit ARM code by 1990s assembly programmers, to NOP out instructions without removing what the instruction was. It's along the lines of the assembly version of commenting out a line of code in C.
To Reproduce
Steps to reproduce the behavior:

Open a binary containing instructions with an NV condition code, e.g. ''00 00 00 FB'' which is ''BL (next instruction)'' in ARM little-endian.
Select the first byte of the instruction and try to disassemble it.
See error.

Expected behavior
Instruction is disassembled as ''BLNV'', which would be a NOP.
Ideally the instruction would decode correctly but have some kind of flow override or flag set to skip the Pcode.
Also acceptable would be for it to just decode as a NOP, perhaps with a comment "NV condition code in use".
Screenshots

Environment (please complete the following information):

OS: Linux Mint
Java Version: OpenJDK 17
Ghidra Version: 10.3, Git master from 14-Dec-2022 1628 GMT.
Ghidra Origin: Locally built from Git sources

We only support ARMv4 and up. Following ARMv2, the "NV" cond field is listed as unpredictable. In ARMv5 it's explicitly not allowed as cond = 15 is used to encode other instructions.

Would there be any objection to me extending the ARM SLEIGH description to add support for ARMv3 and potentially ARMv2 and submitting a PR for that?
What would be the preferred way to implement ARMv3?
I'd also like to add support for the APCS-R/APCS-2 calling convention (summary version here: https://heyrick.eu/assembler/apcsintro.html ) as used by RISC OS, on a separate PR. Am I correct in thinking that would mostly just need additions to the ARM CSPEC file?

We would have to discuss internally whether we would want to support ARMv3/v2. I can bring it up. The main concern is going to be the significant differences from ARMv4 and up.
As for the calling convention, that would be easier to support. It looks pretty clear - at least APCS-2. APCS-R if we were going to support the earlier versions of ARM.


interact layout regression

Interact widgets are now positioned horizontally instead of vertically. This can easily overflow the horizontal space if there are several widgets:
With ipywidgets-5.2.2 + widgetsnbextension-1.2.6:

With ipywidgets-6.0.0.beta5 + widgetsnbextension-2.0.0b7:

This is indeed fixed by #1011.


feat!: add 'decode_return_data' abstract method to EcosystemAPI

BREAKING CHANGE: Adds new abstract method.
What I did
I noticed decode_calldata() was missing from the EcoystemAPI and it is expected to exist, so I added it.
Also fixed doc links related to api.transactions.py
Also added missing doc strs to EcosystemAPI
How I did it
Added abstract method
How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

NOTE: This PR is technically a breaking-change because it adds a new abstractmethod. However, since it is only adding it to EcosystemAPI and all out ecosystems currently use ape-ethereum, it is low-risk that this would affect any plugins (unless some users out there are already making Ecosystem plugins that we don't know about).

I think I actually need a decode_call_data() for Starknet

I think I actually need a encode_call_data() for Starknet

I thought we had this, but apparently we do not (sort of mixed in with "serialize transaction").
In favor of adding it though!


Error - missing module 'init' on test.run_registered_tests()

After the minor change under capabilities/init.lua I was able to run the test. (see  #54)
Unfortunately it was throwing the next error:
PS Q:\repos\smartthings_edge_drivers> lua54 "Q:\repos\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-contact\src\test\test_zigbee_contact_battery.lua"
Running test "Battery Voltage test cases" (1 of 3)
--------------------------------------------------
Received unexpected error: module 'init' not found:
        no field package.preload['init']
        no file 'Q:\repos\smartthings_edge_drivers\lua_libs-api_v0\init.lua'
        no file 'Q:\repos\smartthings_edge_drivers\lua_libs-api_v0\init\init.lua'
        no file '.\init.lua'
        no file '.\init\init.lua'
        no file ''
        no file 'Q:\lua\init.dll'
        no file 'Q:\lua\..\lib\lua\5.4\init.dll'
        no file 'Q:\lua\loadall.dll'
        no file '.\init.dll'
        no file 'Q:\lua\init54.dll'
        no file '.\init54.dll'
stack traceback:
        [C]: in function 'require'
        [C]: in function 'xpcall'
        ...s_edge_drivers\lua_libs-api_v0\integration_test\init.lua:214: in upvalue 'run_configured_test'
        ...s_edge_drivers\lua_libs-api_v0\integration_test\init.lua:326: in function 'integration_test.run_registered_tests'
        ...\zigbee-contact\src\test\test_zigbee_contact_battery.lua:139: in main chunk
        [C]: in ?
FAILED

We appear to have a gap in the documentation, and I can make a not of that.  If you want to run the tests for a driver, you have to execute it from the src directory of the driver you are testing as that mimics how they would be expected to run on target.


update badges

What problem does this PR solve?
What is changed and how it works?

/run-all-tests

/merge

/cherry-pick release-3.0


Add a link to the marketplace

A link to
https://marketplace.visualstudio.com/items?itemName=milan-kovacic.vitest-lab
somewhere in the README file or the github project description would be helpful

Hi, I've added the link to the README file.


move duplication in services to Connection.get and Connection.post

Motivation (Why)
Tony and I will soon need to raise AccessTokenRejected and limiting the duplication to the Connection methods helps a lot with that.
Later we can reduce the duplication in Connection too - just not yet.
Consequence

No change in terms of callers as Connection is encapsulated.

Think we made a good call resisting the temptation to DRY this early on too @abreckner :smile:.

Ah I see you updated this. Great stuff!

Reference article: https://stackoverflow.com/questions/1103985/method-chaining-why-is-it-a-good-practice-or-not


Allow honest validators to reorg late blocks

Specify a function in fork choice get_proposer_head which returns the parent block upon which a proposer may build while possibly reorging the canonical head (if it was broadcast late and lacks sufficient attestation weight).
The mechanism is designed with safeguards built in so that it does not cause liveness failures:

Only single-slot reorgs are attempted: block N + 2 may build on block N if block N + 1 arrived late.
Finalization must be occurring with the expected frequency determined by REORG_MAX_EPOCHS_SINCE_FINALIZATION. The default is to require optimal finalization (every 2 epochs).
REORG_WEIGHT_THRESHOLD is set to 20% (half of the proposer boost) so that an attacker must control up to PROPOSER_BOOST_SCORE - REORG_WEIGHT_THRESHOLD = 20% of attester weight in order to perform an ex-ante reorg. The attack works by releasing attestations for the block at slot N + 1 around the same time as the honest proposer publishes the attempted reorg block at N + 2. The late attestations tip the weight of the N + 1 block from < REORG_WEIGHT_THRESHOLD to > PROPOSER_BOOST_SCORE, meaning that block N + 1 will be preferred to block N + 2.

For background on the development of this idea, see: https://github.com/sigp/lighthouse/pull/2860.
Pros

Completely optional for clients and node operators, can be switched on and off via a flag. Low risk.
Can be rolled out almost immediately unlike other late block mitigations which are still in R&D.

Cons

Considerable complexity, particularly regarding the overriding of fork choice updates for the canonical head.
Obsoleted by (block, slot) fork choice. If a viable implementation of (block, slot) fork choice emerges then reorging late blocks will become the default behaviour.
Relies on proposer boost, which may be phased out in favour of other fork choice changes (e.g. view-merge).

Thanks to @potuz @mkalinin @terencechain @fradamt @casparschwa @djrtwo for feedback on this idea.

Since this is optional, it might be nice to separate it from other parts of the spec a bit more, similar to optimistic sync. We could contain the complexity a bit, especially if it might be phased out in the future.

What is the circuit-breaker mechanism for when latency is > 4s? Is the intention that checking "single_slot_reorg" and "participation_ok" should act as one, because, when latency is > 4s and blocks do not get attestations in their slot, the parent block would either be too old or not have enough weight?
If that's the case, I think this should be clarified. It might also be nice to have an explicit circuit-breaker that's easier to reason about, and gives clear liveness guarantees (e.g. explicitly turn off the reorg functionality whenever too many proposals are being missed)

@fradamt Yeah the single slot & participation conditions are meant to be the circuit-breaker for asynchrony (although I think the single slot condition alone is sufficient). I think the outcome is that with message delay $\text{4s} < \Delta < \text{16s}$ then every second block will be re-orged and we'll get 50% of blocks on average. Once the delay exceeds 16s then blocks will be forced to build on a parent from at least 2 slots prior and we'll get <50% of blocks on average, without the proposer re-org rules coming into effect at all. In other words the only change in behaviour is for the delay window $\text{4s} < \Delta < \text{16s}$.

It might also be nice to have an explicit circuit-breaker that's easier to reason about, and gives clear liveness guarantees (e.g. explicitly turn off the reorg functionality whenever too many proposals are being missed)

Are you thinking of something like the builder API circuit-breaker conditions about number of missed blocks in the last N blocks and number of epochs since finalization? We could add number-of-skipped-blocks check (while keeping single_slot_reorg), and replace the current participation check with the the epochs-since-finalization check? The main reason I'd like to keep the single_slot_reorg check is that it simplifies the implementation greatly in terms of calculating and caching things.

I've rebased this on dev and addressed some of the outstanding review comments. I think there are still several decisions we need to take before merging:

Q1: Is the current location alongside the other fork choice functions the right location for these specs? As they're optional they could alternatively live in ./fork_choice alongside the safe block specs.
Q2: How should we address the tension between specifying a precise strategy, and giving implementations the freedom to explore more aggressive strategies? This has implications for how the spec is written, which tests we write, and what inferences we are able to make about re-orgs on live networks.

A: max precision: Don't account for any deviations from the spec. Write test cases that enforce when clients should and shouldn't re-org (positive and negative tests, respectively).
B: max freedom: Allow clients to deviate from the spec in any way they wish. Write some test cases that describe minimum scenarios in which clients should re-org, but don't specify any negative tests beyond very extreme cases where re-orgs are actually impossible.
C: balance: Account for some acceptable deviations from the spec in tests. Write a mix of positive and negative tests while trying to avoid negative tests that would fail on current implementations. Allow implementations to skip some tests if they explore more exotic strategies in future.

I think my current preference for Q2 is option (C). I think the only outstanding difference between Prysm and Lighthouse is our handling of unrealized justification. Lighthouse currently won't re-org a block that updates unrealized justification, while Prysm will, because it assumes it can achieve equivalent justification by packing the block's attestations. I'm not opposed to changing Lighthouse to follow Prysm and specifying this as a case where we should re-org.

I am starting to get more worried about this change -- the reason is that it implements a version of the block/slot fork choice, but without the mitigations that would have to be in place to avoid reorging under poor networking conditions.
Also, we should probably open a discussion about the 4s attestation timeline at this point. In order for attestations, we need (1) block propagation and (2) block validation all to happen in this time slot, which is starting to become more work (e.g. with 4844) and does not feel like the appropriate slot division anymore since the work in the other three thirds remains the same (and is overall less time critical).

without the mitigations that would have to be in place to avoid reorging under poor networking conditions.

There is a constraint on the slot of a parent block as a mitigation to poor network connections, i.e. parent_block.slot + 1 == head_block.slot. If a block was missed in a parent slot then no reorg is enforced.

Also, we should probably open a discussion about the 4s attestation timeline at this point.

I think we should raise it on one of the next calls. It would be nice to see the distribution of attestation and aggregates submitting over time into their respective slot phases.

There is a constraint on the slot of a parent block as a mitigation to poor network connections, i.e. parent_block.slot + 1 == head_block.slot. If a block was missed in a parent slot then no reorg is enforced.

Yes, but that makes any slot whose parent was not reorged subject to a reorg. Seems pretty harsh!

I think we should raise it on one of the next calls. It would be nice to see the distribution of attestation and aggregates submitting over time into their respective slot phases.

Yeah, it's a good idea, I will check if we can get this data

I've pushed the change suggested by @potuz to address the "selfish mining" attack described here.
I would appreciate some help from @hwwhww writing tests. Alternatively we could merge as-is and add tests in a follow-up PR.

In addition to my previous reservations on this change, I also have a new one:
A fork choice change like this should not be taken light-heartedly. In fact, we explicitly don't want that people think they can just mess with the fork choice. As an example, if someone built a bribery protocol to reorg blocks intentionally, I would consider this an attack on Ethereum.
Therefore it might be best to actually roll back the change from clients now and re-start the discussion to make sure this is in a public forum and agreed by everyone, at least on ACDC.

This was widely discussed in ACD at the time and thoroughly agreed upon. The only reason this wasn't merged then is that we couldn't make public some aspects of pulled tips. The implementation complexity of these changes are deeply intricate to roll back lightly

@dankrad I was keen to push ahead with this fix, because as Potuz said it had fairly broad support, but it also mitigated what I saw as a security issue introduced by MEV at the merge. Without late block re-orgs, proposers are incentivised to wait until the last moment to reveal their blocks, e.g. 10s into the slot. I think this damages the network more than intentionally re-orging blocks that are late.
Another thing is that this change does not modify fork choice, as in the part of fork choice that determines what the head should be. It's just an (incentive-compatible) tweak to the rules for choosing which block to build upon. Unlike bribe-based re-orgs, it also reinforces the honest behaviour of other validators: publishing blocks on time, and publishing attestations at or before the attestation deadline.
Like Prysm, Lighthouse has this feature behind a flag and could disable it by default (or permanently) if desired.

Hi @michaelsproul
I refactored the specs to re-arrange and reduce the duplicate code in get_proposer_head and should_override_forkchoice_update. It helps me to define the test cases. What do you think about this refactoring?

Q1: Is the current location alongside the other fork choice functions the right location for these specs? As they're optional they could alternatively live in ./fork_choice alongside the safe block specs.

It reminds me of the confirmation rule PR, which defines the new feature in a new fork_choice/confirmation-rule.md file. I'm not 100% sure if adding a new doc is necessary, but it would be better to clarify which parts are "optional" and which are "honest validator fork choice rule".

If should_override_forkchoice_update returns True but get_proposer_head later chooses the canonical head rather than its parent, then this is a misprediction that will cause the node to construct a payload with less notice. The result of get_proposer_head MUST be honored in preference to the heuristic method.

I saw that get_proposer_head is optional in phase0 FC, but here, it's not clear to me if should_override_forkchoice_update is MUST to enable. Could you clarify a bit?

Q2: How should we address the tension between specifying a precise strategy, and giving implementations the freedom to explore more aggressive strategies? This has implications for how the spec is written, which tests we write, and what inferences we are able to make about re-orgs on live networks.

IMO clients can have the flexibility to implement it into a more efficient algorithm, but in regard to the result of the computed head, it should be identical because of the risk of chain split. I doubt spec tests have covered everything. 😅

Another thing is that this change does not modify fork choice, as in the part of fork choice that determines what the head should be.

It modifies the rules on how to vote for a block.

It's just an (incentive-compatible) tweak to the rules for choosing which block to build upon. Unlike bribe-based re-orgs, it also reinforces the honest behaviour of other validators: publishing blocks on time, and publishing attestations at or before the attestation deadline.

Again, I'm not so much against this change, but now feel that it needs broader agreement and is not something that clients should be able to implement before that is reached. Maybe this is something to at least discuss on next ACD if people generally agree with this change.

It modifies the rules on how to vote for a block.

I don't see how this modifies voting rules:: attesters in the orphaned committee would not have attested for the late block cause they sent attestations at 4 seconds. Attesters in the next committee are following the usual forkchoice and proposer boost mandates them to vote for the reorging block.

having things like this behind flags dubious at best and should be considered a temporary solution to address urgent problems and not a permanent state.

Just to clarify this, the only reason Prysm has this behind a flag is to protect from an implementation bug that can cause a liveness issue. We do this with most changes that touch core functions like block production. This has nothing to do with the feature being or not merged in the spec. As far as we were concerned this was thoroughly discussed and agreed in ACD albeit some reservations about disclosing because of certain forkchoice attacks that's were present at the time

Hi @hwwhww, sorry for the slow reply! Thanks for cleaning this up and adding tests, I really appreciate that :blush:

I saw that get_proposer_head is optional in phase0 FC, but here, it's not clear to me if should_override_forkchoice_update is MUST to enable. Could you clarify a bit?

I tried to clarify the wording of this section in 3f1bc2051294d7ea632b5010500f98a331119d39. Both functions are optional, and should_override_forkchoice_update should only be enabled when the proposer reorg feature is enabled. This is how Lighthouse and Prysm work currently.

check if we should output get_proposer_head result. It is labeled optional so I hesitated. also, consider moving get_proposer_head to a separate place

I think the tests should include get_proposer_head as well, as it is arguably more important than should_override_forkchoice_update. If clients don't implement it they can simply skip those checks in their fork choice test runner.
I also think we should just leave it in the current location, as it seems like we may want to make this feature mandatory in future (Potuz mentioned that several PBS designs rely on it, but I haven't dug deeper).

confirm if test format is ok and run with a client

I'll try running the test vectors with Lighthouse soon. Maybe once they also include get_proposer_head checks.

@michaelsproul thank you!
I updated the test format: https://github.com/ethereum/consensus-specs/blob/d8440f8bb4496d053a36b5fef64420d5149156bb/tests/formats/fork_choice/README.md#checks-step

add get_proposer_head
add mocking validator_is_connected into should_override_forkchoice_update check.

Now running the fork-choice testgen.

@michaelsproul
FC-only test vectors of commit d8440f8

minimal_fc_d8440f8.tar.gz
mainnet_fc_d8440f8.tar.gz

FC-only test vectors of commit https://github.com/ethereum/consensus-specs/commit/d8440f8bb4496d053a36b5fef64420d5149156bb

Tests are passing on Lighthouse (https://github.com/sigp/lighthouse/pull/4887). I expected at least one test to fail because Lighthouse doesn't have the REORG_PARENT_WEIGHT_THRESHOLD check. This implies the test coverage could be expanded with a case where the reorg would go ahead if it weren't for the low weight of the parent (i.e. where head_weight < REORG_WEIGHT_THRESHOLD && parent_weight < REORG_PARENT_WEIGHT_THRESHOLD).


Schema Registry

Context
Should be possible for users to easily create, discover and use existing schemas
Proposal
Create a simple method (similar to pre-configured vaults) for accessing useful schemas.
Related issues

#712

I think the RFC for Schema Improvements #712 could be a valuable addition to this.

@flammehawk absolutely, I see them as related features (they both help each other).

Specially https://github.com/dendronhq/dendron-site/pull/89/files#diff-3956c364d18dd866588cd9d87abcaa45c5ea38d7d3af2b0d6f42a6938b83053d
that part of the RFC


[Table visualization] Add functional tests for new table vis

Description
There are five test cases:

basic.spec.js contains tests related to vis page, like inspector, save an object.

https://user-images.githubusercontent.com/79961084/207220982-38db069e-5231-404e-b393-a115d99dbdac.mov

data.spec.js tests diff metrics and buckets aggregations.

https://user-images.githubusercontent.com/79961084/207221321-aeb29608-ded9-4ca3-8650-241b73eb7401.mov

options.spec.js contains tests on options panel.

https://user-images.githubusercontent.com/79961084/207221595-39e2ea6b-f605-44f3-b7fa-6e742679fb19.mov

split.spec.js tests table functions, like sort, adjust col width, split tables and etc.

https://user-images.githubusercontent.com/79961084/207221934-bb4d74b5-78d8-48ce-8921-4b34829bdc8d.mov

embed.spec.js tests how an embedded table visualization works.

https://user-images.githubusercontent.com/79961084/211651255-b0b27dc6-0133-441e-9f9e-42b071c918bd.mov
Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests.
Partially Resolved
https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/401
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ananzh Do you need confirmation from Ashwin before merging? If not, we can approve and get it merged.

@tianleh no you do not :) I only had minor comments on the original PR. Sorry @ananzh for letting this slip through the cracks, this PR however might need to be rebased since some of the changes seem to be irrelevant to the PR and all the checks do not pass right now.


Remove hardcoded certificate name for code signing

Remove hardcoded certificate name (expected as as input argument).
Add check for certificate.
Signed-off-by: Violeta Sebe<EMAIL_ADDRESS>

@AdamBrousseau pls review, thx


Impact
Avoid the default action kill the program
Testing

Hi @xiaoxiang781216 why ignore the signal action twice?

Oh, the merge in our internal git looks wrong. Sorry, let's close this PR.


Website: Color Picker Component

We need to implement the Color picker in our toast builder website.

Hi Payam, I'm interested in contributing to this feature. Could you please let me know if someone else is already working on it or not?

Hey @mahmoud-eslami
Thanks for your proposal
Yes, you can start working on it.
I will assign it to you.

It would be awesome if we could achieve something like this in a dialog.


ratelimiter implementation

linting is not important here for now :p

should we also have a ratelimited event? so users can provide custom logging impls for ratelimits. this event could be fired when we avoid a ratelimit aswell as when we actually hit 429

should we also have a ratelimited event? so users can provide custom logging impls for ratelimits. this event could be fired when we avoid a ratelimit aswell as when we actually hit 429

I think a separate event for each would be better, something like RatelimitPrevented and RatelimitReceived


enhancement: refactoring file structure

The problem
All the files are stored in the same folder, which is not ideal way of maintaining the code.
Describe the solution you'd like
Creating separate directories (folders) to maintain stylesheets, images and html pages.

Hello!
I created this issue. Can you please assign this issue to me? Thanks!

Hello!
Can you please assign me this issue? Thanks!

The problem
All the files are stored in the same folder, which is not ideal way of maintaining the code.
Describe the solution you'd like
Creating separate directories (folders) to maintain stylesheets, images and html pages.

**Hello how are you? ** Thank you for your attention. The necessary investigations are currently ongoing and we will inform you later. While this is happening, don't forget to star the project and follow us. Good luck

The problem All the files are stored in the same folder, which is not ideal way of maintaining the code.
Describe the solution you'd like Creating separate directories (folders) to maintain stylesheets, images and html pages.

Hello again, the index issue you mentioned has been reviewed and can be edited as you indicated.
Subject: Issue Assignment I have reviewed your request to take over the issue titled Issues. I am assigning it to you now.
If you have any questions or need further clarification on the requirements, please do not hesitate to contact me. I look forward to your contributions!
Best regards, [Berat Gökdemir]

Hello @brgkdm. Can you add good first issue label to this issue?
Thanks!

Hello @brgkdm. Can you add good first issue label to this issue? Thanks!

Hello, as you requested, the label has been updated to "good first issue".

Hello @brgkdm. Can you add good first issue label to this issue? Thanks!

Hello, as you requested, the label has been updated to "good first issue".

Thanks! I think this issue can now be closed.


Remove blacklisted website

Can you remove it.altervista.org from the blacklisted website? This is just the Italian website for altervista.org not a website of advertisements.
I've already asked to Steven Black to remove it and he sent me here.
Thanks

@MarcoDiFrancesco done. Thanks for report.


adding test files to test pr workflow

testing pr workflow

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-csharp-cosmos-sql -b pr/42

View Changes | Compare Changes

Project: todo-csharp-mongo
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-csharp-mongo -b pr/42

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-csharp-sql -b pr/42

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo-aca -b pr/42

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo-swa-func -b pr/42

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo -b pr/42

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-aca -b pr/42

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-swa-func -b pr/42

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/42
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo -b pr/42

View Changes | Compare Changes

Project: todo-csharp-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-csharp-mongo -b pr/43

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-aca -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-swa-func -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-terraform -b pr/43

View Changes | Compare Changes

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-csharp-mongo -b pr/43

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-aca -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-swa-func -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo -b pr/43

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/43
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-terraform -b pr/43

View Changes | Compare Changes


[Task] Clean up deprecated code that is older than 3 releases

Deprecated code older than 3 releases (older or equal to 3.6.0) shall be removed from the master branches as agreed by the project governance. To simplify the task all @Deprecated introduced before 2018-11-28 21:54 shall be removed.

[ ] https://github.com/vert-x3/vertx-web/issues/1351

Should never be fixed


Add nullable annotation to DAO functions

Coverage remained the same at 19.877% when pulling feafd1b4a943a1b7ed0f276c7211e0cffca32094 on alyiwang:master into a38d6e08adaf5ab4da209236ed32076194027e31 on linkedin:master.

Coverage remained the same at 19.877% when pulling 30497f57dbfb29998e97018882d27c4c1aa15ab7 on alyiwang:master into a38d6e08adaf5ab4da209236ed32076194027e31 on linkedin:master.


When there are multiple subscribers in a host, there will be a lot of data loss, use SHM

Hello ecal developers, I found the following problems when using the official test case: when there are multiple subscribers, there will be more data loss, and the results are as follows:

I tried to set the buffer to be larger, set it to 10, but still there is a lot of data loss:

I wrote some test code myself, using protobuf for image transmission, the frequency is 10hz, and the shared memory method is used. When there are 1 or 2 subscribers, the data loss is basically 0, but when there are 3 subscribers , the data loss rate is about 1%-3%, when there are 4 or 5 subscribers, the data loss rate is about 10%-60%, very unstable, the following is my test data, the data I recorded Missing serial number:
➜  ecal git:(master) ./build/bin/ecal_demo_image_rec -n 2
ros helper thread running ...
stop signal received
stop signal received
-------------------- left_image ----------------------
seq start : 9
loss data seq: 1 2 3 4 5 6 7 8 9 11 12 13 14 15 16 17 18 19 20 21 22 26 27 28 29 32 36 40 48 49 54 70 84 88 89 108 110 116 120 124 127 128 129 131 132 133 134 135 136 137 140 148 149 150 163 166 170 171 182 188 189 190 191 198 206 207 208 216 223 229 230 232 236 240 249 255 259 270 279 280 290 291 299 316 328 329 337 349 355 356 357 359 360 378 388 398 408 419 423 429 432 433 438 447 450 452 454 458 460 468 477 485 487 489 490 491 498 499 502 504 518 521 530 532 538 540 549 551 558 559 572 586 590 592 594 598 599 609 613 617 619 620 630 632 638 640 646 648 649 650 652 653 655 658 659 661 665 666 670 672 675 676 683 689 718 720 725 728 730 736 737 746 755 758 768 788 791 798 799 813 815 821 822 823 825 829 837 840 842 848 860 862 876 877 878 880 887 890 895 896 898 904 910 913 914 920 926 927 928 929 930 940 957 959 960 962 966 968 969 970 979 980 982 987<PHONE_NUMBER> 1014 1017 1018 1020
loss message count : 222
loss rate : 21.9585 %
Messages received                       : 784
ROS to eCAL image average latency       : 0.959432 ms
ROS to eCAL image min latency           : 0.808 ms @ 141
ROS to eCAL image max latency           : 2.99 ms @ 556
Message average latency                 : 8.84261 ms
Message min latency                     : 4.936 ms @ 209
Message max latency                     : 18.333 ms @ 6
eCAL to ROS image average latency       : 1.25238 ms
eCAL to ROS image min latency           : 0.849 ms @ 615
eCAL to ROS image max latency           : 7.79 ms @ 12
Message size received                   : 7271467 kB
Size of each message                    : 9274.83 kB
Throughput                              : 1048878 kB/s
                                        : 1024 MB/s
                                        : 113 Msg/s
--------------------------------------------
1020 789 9 0.959432 0.808 2.99 8.84261 4.936 18.333 1.25238 0.849 7.79 11.0544 1024 113 21.9585

-------------------- mid_image ----------------------
seq start : 8
loss data seq: 1 2 3 4 5 6 7 8 14 15 16 17 18 19 20 23 24 27 29 30 32 35 37 38 41 44 49 59 60 61 64 69 72 76 79 90 94 105 106 109 110 115 125 128 129 130 134 135 137 139 140 142 146 147 155 170 176 179 180 184 189 194 195 197 198 209 214 216 217 219 220 225 229 237 239 240 246 249 250 252 257 267 268 270 274 275 280 294 298 310 314 315 330 335 341 358 360 365 369 377 388 389 397 399 402 409 410 415 418 420 429 430 439 444 446 449 450 468 473 474 475 494 507 509 510 518 523 527 531 541 546 548 550 558 560 579 580 585 590 591 610 614 626 637 638 639 640 650 658 659 665 667 677 679 680 688 690 697 700 704 707 709 716 728 729 734 744 747 749 750 756 760 768 774 775 789 797 799 809 810 811 815 820 825 827 830 834 835 838 867 873 874 877 880 885 886 887 889 893 894 899 900 910 918 920 924 929 940 941 949 950 956 960 970 971 974 975 977 980 986 987 988 989 990<PHONE_NUMBER>
loss message count : 219
loss rate : 21.6403 %
Messages received                       : 786
ROS to eCAL image average latency       : 0.983738 ms
ROS to eCAL image min latency           : 0.857 ms @ 352
ROS to eCAL image max latency           : 2.405 ms @ 347
Message average latency                 : 8.38145 ms
Message min latency                     : 4.885 ms @ 728
Message max latency                     : 19.742 ms @ 15
eCAL to ROS image average latency       : 1.28079 ms
eCAL to ROS image min latency           : 0.799 ms @ 351
eCAL to ROS image max latency           : 6.678 ms @ 15
Message size received                   : 7289899 kB
Size of each message                    : 9274.68 kB
Throughput                              : 1106572 kB/s
                                        : 1080 MB/s
                                        : 119 Msg/s
--------------------------------------------
1020 791 8 0.983738 0.857 2.405 8.38145 4.885 19.742 1.28079 0.799 6.678 10.646 1080 119 21.6403

In the above test output results, there are 4 subscribers, I sent 1020 frames of data, loss data seq records the serial number of data loss, loss rate is the data loss rate, and some delays
Special note: I actually tested it with the official use case after I found multiple subscribers.
My test code repository is as follows: https://github.com/jiejieTop/middleware_benchmark

ecal version : 5.10.2

Thank you for your issue report.
Can you please activate the handshake option described here and recheck ?

Thank you for your issue report.
Can you please activate the handshake option described here and recheck ?

Yes, I tested it and the modification works, thank you very much for your reply

Thank you for your issue report.
Can you please activate the handshake option described here and recheck ?

There is another question. During the test, I found that the latency of different subscribers is different. Some subscribers have low latency, while others have high latency. Why?

@jiejieTop thank you for that great observation. Unfortunately there is a small issue in this (rarely used) handshake mechanism that causes the publisher to wait for every acknowledge in a serial manner instead fully parallel. We will fix this soon and bring it in 5.11.

thank you for that great observation. Unfortunately there is a small issue in this (rarely used) handshake mechanism that causes the publisher to wait for every acknowledge in a serial manner instead fully parallel. We will fix this soon and bring it in 5.11.

thank you


Remove the Feature_IsolatedMonarchMode fix

See:

MSFT:38540483
#12774
#12825
#12856

in #12825 we tried out two fixes blindly to fix this crash. Turns out, neither was the real root cause. #12856 did fix it though.
We should probably remove the "big hammer" fix of falling back to the isolated monarch, and just do the "little hammer" one. Or heck maybe even neither, since there seems to be no difference here.

I believe that we should keep the fix -- because now, if the OOP COM call fails _monarch WILL be null and we can trigger the appropriate fallback behavior.
Falling back to an unregistered local monarch is light years ahead of ... whatever the heck was gonna happen otherwise, right?


Release Apk Build Failed

Building apk fails with the following output:
flutter\.pub-cache\hosted\pub.dartlang.org\qonversion_flutter-4.0.0\android\src\main\kotlin\com\qonversion\flutter\sdk\qonversion_flutter_sdk\QonversionFlutterSdkPlugin.kt: (42, 71): Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type Activity?

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':qonversion_flutter:compileReleaseKotlin'.
> Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 32s
Running Gradle task 'assembleRelease'...                           34.3s
Gradle task assembleRelease failed with exit code 1

Hello, @Hassico
Could you please try to use the latest version of SDK?

I have the same problems. My Flutter SDK is 3.0.1 and the qonversion_flutter package is the latest (4.3.1). But when I run with out debug on Android simulator it show the same problems. Please Fix It.

Hi, @trunglecp
We will investigate and fix the problem ASAP. Let's keep in touch 🤝

We've released the new version with the fix of the current issue! Please, upgrade the Flutter SDK version to 4.3.2.


Configurable fuzzy matching

I noticed pull request https://github.com/mmgoodnow/cross-seed/pull/32 which upped the boundary for matching a torrent.  I think it should be taken a step further and allow that matching amount to be a user input (the default value would be left to how it is now and only changed if the user wanted to use the new input option).  This would allow for values, such as .1 * length or even .2 * length for torrents that include samples, nfos, subtitles and other stuff.  This would be useful for people who dont mind having a few extra torrent matches that aren't 100% and also want to seed ones they have that are 80% completed and will download the missing 20% and then begin seeding
Relevant code:
const lowerBound = length - 0.02 * length;
const upperBound = length + 0.02 * length;

I like that idea. I'll add it to the backlog, but pull requests are always welcome!

Definitely a good idea +1

I've merged @jasonhazel's PR. No guarantees from me on it working well.


V2 and TP mods pic, VictimCrasherOverlay HP Bar readjustment, changing hardcoded 127 0 0 1

Title says it all, but here's more thorough information:

Adding V2 mods picture to the counter so it will show V2 on counter while playing with V2.
Changing the original Target Practice mods pic to follow the style of others.
Changing HP Bar from smooth to normal (I have always wanted to change this because it's changing too lazily).
Changing hardcoded link in javascript code form <IP_ADDRESS>:24050 to location.host for multi-device compatibility for VictimCrasherCompact, VictimCrasherOverlay and WaveTournament.

Thanks!


Relations with query not work

We have this class:
<?php

namespace App;

use App\Comment;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasMany;

class Post extends Model
{
    public function comments(): HasMany
    {
        return $this->hasMany(Comment::class);
    }

    public function commentsUnread(): HasMany
    {
        return $this->comments()->where('unread', true);
    }
}

After run php artisan ide-helper:models we got:
/**
 * @property-read \Illuminate\Database\Eloquent\Collection|\App\Comment[] $comments
 */

But expected:
/**
 * @property-read \Illuminate\Database\Eloquent\Collection|\App\Comment[] $comments
 * @property-read \Illuminate\Database\Eloquent\Collection|\App\Comment[] $commentsUnread
 */

Seems like because ide-helper just search functions with relations names and ignore method return type.
Anyone have workaround for this?

Fixed in #763


VM: 9p disk device shares

Adds the ability to share directories from the host into the VM guest using the 9p protocol.
Requires that the lxd-agent is running inside the VM.
Example usage:
lxc config device add v1 test disk source=/some/host/dir path=/some/vm/dir

The readonly property is supported.

Testsuite passed

Testsuite passed

Testsuite passed


Restored environment tiers image

The image showing the environment tiers was previously removed. It's important to keep it due it shows the expected environment considerations according to quantity of connected users and/or transaction lines per hour

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.

The image is incorrect, that's why it was removed. Thanks.


ajuda na resolução deste desafio.

Challenge Comment out HTML has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<!-

Hello World

CatPhotoApp

<!->

Hello Paragraph

Hi @matondodomingos
Please visit the Help Chat Room, for coding help.
Thanks.


Avoid creating auxiliary file with common file ending (blx.bib)

I want to configure git-ignore by using the endings of temp files such as acn, glo, toc, aux, ... but *-blx.bib seems to be an automatically created biblatex file. Is it possible to give it another file ending?

No, you can't.
but you can add
*-blx.bib

to your .gitignore


Create API skeleton

Create the API skeleton for fit and competent

Duplicate
Issue: Scottish-Natural-Heritage/Licensing#409


Fetch withRelated creates bad related collection

Using these models, the following creates an entry in the join table that is missing the source object's id (which in this case is person_id).
Person.collection().fetch({ withRelated: 'cars' }).then(function(people) {
  return people.at(0).related('cars').create({ model: 'Jetta'})
});

Using fetch without the withRelated works. Using fetchOne also works, and actually still works if the withRelated is provided.
By the way, I may have a few more questions/issues that I'll be submitting over time. I'm still experimenting with the library and I like it a lot. I'm having a little difficulty getting started because a few of the finer points of how the library works are still new to me. This could be because I'm not coming from Backbone. Anyway, I'll try to keep track of the examples that I'm working through, and perhaps this is something that we could add to a guide.
Thanks!

Somehow I missed this issue when I created the other one. I'm closing this as duplicate of #629, since the newer one has more information and a workaround for anyone with this issue.


update HTTP/3 errors

Fixes #2174.

rename HTTP_UNEXPECTED_FRAME to HTTP_FRAME_UNEXPECTED
remove the HTTP_WRONG_STREAM error
rename errors from HTTP_ to H3_

Codecov Report

Merging #2176 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
- Coverage   86.51%   86.51%   -<.01%
==========================================
  Files         104      104
  Lines        7480     7478       -2
==========================================
- Hits         6471     6469       -2
  Misses        748      748
  Partials      261      261

Impacted Files
Coverage Δ

http3/server.go
65.16% <100%> (ø)
:arrow_up:

http3/error_codes.go
100% <100%> (ø)
:arrow_up:

http3/client.go
87.39% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af8a33...ea0050e. Read the comment docs.


how to predict depth of images from different at the same time

Dear author,
I want to predict the depth from many images captured by different cameras. it will be spend long time if we put a single image to the model every time. So I want to put a batch of images to the model one time, but there is a problem, the camera has different intrinsics, and cannot use a normal cameral model. I have tried to the inference function, but  miss in "get_func('mono.model.model_pipelines.' + model_type)(cfg)"

Dear author, I want to predict the depth from many images captured by different cameras. it will be spend long time if we put a single image to the model every time. So I want to put a batch of images to the model one time, but there is a problem, the camera has different intrinsics, and cannot use a normal cameral model. I have tried to the inference function, but miss in "get_func('mono.model.model_pipelines.' + model_type)(cfg)"

I hope this issue would help. By the way, do not forget to set the launcher to make the codes execute in DDP mode.

Dear author, I want to predict the depth from many images captured by different cameras. it will be spend long time if we put a single image to the model every time. So I want to put a batch of images to the model one time, but there is a problem, the camera has different intrinsics, and cannot use a normal cameral model. I have tried to the inference function, but miss in "get_func('mono.model.model_pipelines.' + model_type)(cfg)"

The code supports different camera settings in a batch. You only need to enclose the original camera information in JSON file.
Please see this: https://github.com/YvanYin/Metric3D/blob/main/mono/utils/custom_data.py


Contacts Don't Have Record Type or Primary Affiliations

The two resource contacts, when just deployed to a new scratch org, do not have their organization in Primary Affiliation. This was part of the dataset as recently as Friday. Not sure how that disappeared.
Scott Blumenthal and Thomas Helper both have them in my dev org (from which the dataset was pulled) but not in the most recent scratch org I spun up.

Hmm. Looks like the problem might be related to this: New York Times and Resource Organization have the wrong record type. They both showed up as Household Accounts, rather than Resource Organization accounts. If I try to add a primary affiliation to one of them, it's stopped by the validation rule we have in place.

Possible that we need an "Ensure Account Record Types" flow in cumulusci.yml, @Nickers3 or @davidmreed ? I see there's a flow for Contact record types. Is that where this problem could be originating?

@mkolodner this might be due to the error I had last week - 16 columns, 15 values.  I manually added a null at the end, but maybe it needed to be before.  Once we get the picklist values confirmed, we can focus on this.

Figured this out.  The Record Type ID and Contact IDs referenced on the Account object weren't in the rest of the file.  Updated the IDs in contact/record type rows and data updated as expected.


Gradle 5.0 build fails on non-macOS systems

Error message:
> No value has been specified for property 'MacAppBundlePlugin jreHome'.
jreHome is only actually required if bundleJRE = true. I was able to fix the build by setting jreHome to an arbitrary value.
See this thread on the Gradle forum.

believe this is fixed in 52f098fc86ea9978506452fdd6b2ce6100857ff0 by setting jreHome to "" and making it optional property


equations broken in the doc

equations eg at https://pyriemann.readthedocs.io/en/latest/generated/pyriemann.utils.tangentspace.log_map_logeuclid.html#pyriemann.utils.tangentspace.log_map_logeuclid are broken

All equations are broken.

can you replicate locally?

No, but my environnent is a little old: my sphinx version is 4.5.0, instead of 5.3.0.


Add custom copy handler to fix pasting issues

Task/Issue URL: https://app.asana.com/0/inbox/856498667309057/1200177881901832/1200188293296345
Tech Design URL:
CC:
Description:
Add custom copy handler to fix pasting issues - in some cases selecting 'Copy' from Text Field menu does not populate URL part of Pasteboard item. If target application requires it for pasting to function properly, pasting there will fail.
Steps to test this PR:

Open webpage.
Select URL - copy it.
Open Gmail app, try to paste url into email.

Device Testing:

[ ] iPhone
[ ] iPad

OS Testing:

[ ] iOS 11
[ ] iOS 12
[ ] iOS 13
[ ] iOS 14

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Thank you!


Use lock in dd.read_hdf

Fixes #760
Suggestions welcome on how to test this.

cc @rabernat @shoyer

This is my minimal broken example:
import pandas as pd
import dask.dataframe as dd
import numpy as np

fname = 'testfile.h5'
key = '/group/dataset'

dtype = np.dtype([('idx','i4'),('val_a','f8'),('val_b','f8')])
N = 10000000
#store = pd.HDFStore(output_fname, mode='w')
with pd.HDFStore(fname, mode='w') as store:
    recarray = np.empty(N, dtype)
    df = pd.DataFrame.from_records(recarray)
    store.append(key, df)

df = pd.read_hdf(fname, key)
ddf = dd.read_hdf(fname, key)
print(len(df))
print(len(ddf))

The last line gives me a segfault.
If I make N smaller, then it works. It is also platform dependent in a way I have not fully figured out.

This example unfortunately works for me both with and without these changes.

It works for me on my mac laptop but breaks on my linux workstation.
Also (somewhat obviously in retrospect), N just needs to be smaller than chunksize to trigger the segfault.
I will try checking out your branch.

@rabernat's example failed for me on master, worked with this PR.
In [2]: tables.__version__
Out[2]: '3.2.2'

In [3]: pd.__version__
Out[3]: '0.17.0rc1+63.gf5106d8'

HDF5 version 1.8.15 (on a mac).

Yup, I can confirm that this PR fixes the issues.

Can anyone think of a nice test to ago along with this that isn't huge?  Otherwise I'm likely to merge without a test.

@mrocklin seems like it's the ratio of len(df) : chunksize

Also (somewhat obviously in retrospect), N just needs to be smaller than chunksize to trigger the segfault.

import pandas as pd
import dask.dataframe as dd
import numpy as np

fname = 'testfile.h5'
key = '/group/dataset'

N = 100
#store = pd.HDFStore(output_fname, mode='w')
with pd.HDFStore(fname, mode='w') as store:
    df = pd.DataFrame(np.random.randn(N, 3))
    store.append(key, df)

df = pd.read_hdf(fname, key)
ddf = dd.read_hdf(fname, key, chunksize=2)
print(len(df))
print(len(ddf))

segfaults reliably for me.

added as a test


Consuming LocalRegionRequest Header during Address Resolution.

Consuming LocalRegionRequest Header during Address Resolution.
Description
The Cosmos DB Service returns a header to specify if a request is within the same Azure region. These changes are to the AddressResolver and GatewayAddressCache to consume this header and pass it along to the PartitionAddressInformation object during address resolution.
Type of change

[] New feature (non-breaking change which adds functionality)

/azp run

/azp run


AudioStreamPlayer3D.is_playing() bug

Tested versions
4.3 beta2
System information
Ubuntu 22.04.3 LTS, Godot 4.3 beta2
Issue description
Pointless console report
Steps to reproduce
Start the example project
Minimal reproduction project (MRP)
aud_bug.zip

Godot 3.4 beta 2 is no longer supported. It was superseded by 3.4-stable, 3.4.4-stable, and now the 3.5 and 3.6 branches are the only ones supported.
Please try to upgrade to 3.5.3 or 3.6-beta5 and see if the bug is still reproducible.

Sorry, I mixed up the version. I fixed it.

Please describe the issue in more detail, the MRP is useful but having a good detailed description is necessary for a bug report

This is a regression introduced between 4.3-beta1 and 4.3-beta2, and reproducible in current master (04a530f91fc83b41112007dbd2ce02e9528df682). I haven't bisected but I'd suspect #91382 @adamscott

Found the issue, fix inbound.


fix: #6153 highlight the destructive delete prompt

Issue #, if available:
fix: #6153
Description of changes:
This PR highlights the destructive delete project operation:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah Thank you for this! The new warning looks great really<3


Provide Option To Disable Checking For Updates

Is your feature request related to a problem? Please describe.
Currently I am using an older version of Storage Explorer due to issue 3161.
Describe the solution you'd like
I would like to disable checking for updates so I don't have to dismiss the update notification whenever I use Storage Explorer.
Describe alternatives you've considered
We'll use Azure Portal as well, but prefer the app.
Additional context
Storage Explorer is used quite regularly during development and frequently in efforts to track down issues/problems in production.
Thank you

Hey @mjgabriel. This isn't something we would add to Storage Explorer. It is important that we encourage users to stay up-to-date. Not only do newer versions of Storage Explorer provide new features, they often contain security fixes. We understand you not wanting to update in this case b/c of issue 3161, and we'll do our best to get the CosmosDB folks to address that issue.

Could you reconsider having it only pop-up once at app start-up and not repeatedly pop-up while the app is open?
Thank you :)

I second motion this


Error with Javascript for Learning Pathways when provisioned

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Upon provisioning the Learning Pathways solution expect to see the webpart rendering with views to the training content
Observed Behavior
When accessing it content receive error listed below:
[SPLoaderError.loadComponentError]:
***Failed to load component "141d4ab7-b6ca-4bf4-ac59-25b7bf93642d" (CustomLearningWebPart). Original error: ***Failed to load path dependency "CustomLearningWebPartStrings" from component "141d4ab7-b6ca-4bf4-ac59-25b7bf93642d" (CustomLearningWebPart). Original error: Error loading https://component-id.invalid/141d4ab7-b6ca-4bf4-ac59-25b7bf93642d_2.0.15/CustomLearningWebPartStrings
Unable to load script https://labcorpdev01.sharepoint.com/sites/apps/ClientSideAssets/26c9cd9f-db62-49b1-b102-7f0dad281ea0/v2-customlearningwebpartstrings_en-us_550d233e4c4642a78860ff6ed0424b18.js
***INNERERROR:
***Failed to load path dependency "CustomLearningWebPartStrings" from component "141d4ab7-b6ca-4bf4-ac59-25b7bf93642d" (CustomLearningWebPart). Original error: Error loading https://component-id.invalid/141d4ab7-b6ca-4bf4-ac59-25b7bf93642d_2.0.15/CustomLearningWebPartStrings
Unable to load script https://labcorpdev01.sharepoint.com/sites/apps/ClientSideAssets/26c9cd9f-db62-49b1-b102-7f0dad281ea0/v2-customlearningwebpartstrings_en-us_550d233e4c4642a78860ff6ed0424b18.js
***CALLSTACK:
Error
at t [as constructor] (https://spoprod-a.akamaihd.net/files/sp-client-prod_2019-07-05.010/sp-pages-assembly_en-us_0b9c90a9424a41e57a3ad3be1f178c04.js:45:29877)
at new t (https://spoprod-a.akamaihd.net/files/sp-client-prod_2019-07-05.010/sp-pages-assembly_en-us_0b9c90a9424a41e57a3ad3be1f178c04.js:169:74253)
at Function.e.buildErrorWithVerboseLog (https://spoprod-a.akamaihd.net/files/sp-client-prod_2019-07-05.010/sp-pages-assembly_en-us_0b9c90a9424a41e57a3ad3be1f178c04.js:169:86503)
at Function.e.buildLoadComponentError (https://spoprod-a.akamaihd.net/files/sp-client-prod_2019-07-05.010/sp-pages-assembly_en-us_0b9c90a9424a41e57a3ad3be1f178c04.js:169:82534)
at https://spoprod-a.akamaihd.net/files/sp-client-prod_2019-07-05.010/sp-pages-assembly_en-us_0b9c90a9424a41e57a3ad3be1f178c04.js:169:103929

Steps to Reproduce
Deleted Learning Pathway solution, deleted app catalog. Had global domain tenant admin recreate app catalog. Waited 30 minutes. He then re-provisioned. same error. Deleted all. Rechecked steps redid and same result. Appears to be issue with client side Javascript. We are checking to see if Intune rules are in fact blocking and causing the issue. You can see warning in attached image as well as some broken images
Thanks for your contribution! Sharing is caring.

@mgannotti -- Every time we've seen this issue it's because something is blocking downloading the content. Please check your browser network tab to see if any files are being blocked from being downloaded.

Thanks!
Michael Gannotti
Microsoft Teams Principal Technical Specialist
Microsoft
US – North East – National Health and Life Sciences
Mobile:<PHONE_NUMBER>
Email: mgann<EMAIL_ADDRESS>Connect with me on LinkedInhttps://www.linkedin.com/in/mikegannotti/ | Twitterhttps://twitter.com/gannotti | Facebookhttps://www.facebook.com/michaelgannotti | Instagramhttps://www.instagram.com/mgannotti/ | IGTVhttps://www.instagram.com/mgannotti/channel/
Visit the Microsoft Healthcare and Life Sciences Bloghttps://aka.ms/HLSBlog
From: Julie Turner<EMAIL_ADDRESS>Sent: Friday, July 19, 2019 3:42 PM
To: pnp/custom-learning-office-365<EMAIL_ADDRESS>Cc: Michael Gannotti<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [pnp/custom-learning-office-365] Error with Javascript for Learning Pathways when provisioned (#103)
@mgannottihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmgannotti&data=02|01|Michael.Gannotti%40microsoft.com|d44af395ca794a23859a08d70c811a4b|72f988bf86f141af91ab2d7cd011db47|1|0|636991620933977687&sdata=xavMHRTde1h%2FjYyNuzdNmeMdK7hSo%2F98AC3p0dnbWM4%3D&reserved=0 -- Every time we've seen this issue it's because something is blocking downloading the content. Please check your browser network tab to see if any files are being blocked from being downloaded.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnp%2Fcustom-learning-office-365%2Fissues%2F103%3Femail_source%3Dnotifications%26email_token%3DAHZCDUKLUAMNX5CFSTSUPYDQAIKGZA5CNFSM4IFLGDP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MSNRY%23issuecomment-513353415&data=02|01|Michael.Gannotti%40microsoft.com|d44af395ca794a23859a08d70c811a4b|72f988bf86f141af91ab2d7cd011db47|1|0|636991620933987681&sdata=UD8h1jM2IqeTyIhpTTfM1g3KUF0TJYi%2BfO8IfUAKYV4%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHZCDUPFHHALMRDR4TG3BR3QAIKGZANCNFSM4IFLGDPQ&data=02|01|Michael.Gannotti%40microsoft.com|d44af395ca794a23859a08d70c811a4b|72f988bf86f141af91ab2d7cd011db47|1|0|636991620933987681&sdata=WUBKb5TJbQt50VsisP1uIhsJppVZqQg32lVtFUV6c9s%3D&reserved=0.

The customer reviewed InTune Policy and found following, remediated, and now Learning Pathways functioning as expected :-)

I have confirmed the Azure AD Conditional Access policy that enforces the “Use app enforced restrictions” session control in SharePoint Online when connecting from a non-complaint or non-AAD joined device was causing this issue. I have disabled the policy and the site is showing up correctly!


Preview camera before trying to capture on Android

Fixes https://github.com/lwansbrough/react-native-camera/issues/770
Not sure if there is a better place to perform the preview, or why preview isn't being run by default, but in my case it isn't, and needs to be.

Ah, ok, so if your <Camera> element has no children, no preview is rendered, so bad things happen.
Alternatively if your <Camera> element does have children, but you style your element as display:none; worse things happen.
I don't think anything bad happens from calling startPreview() more than once, so this should be fairly safe to add.


Cajetzer/docs

updated setup.md after testing deployment myself.
added configuration.md template

I am going to make some updates to the main readme to better clarify the scenario and solution.


Enable dependabot for github actions

It prevent using outdated/insecure github actions, consider adding this when migrating to GHA

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Shutdown WiFi module during power-down routine.

Currently, it appears, the WiFi module will still respond to a ping if connected via USB and told to power down (power switch/SCPI command).  We want to completely shut down the WiFi module during the power down sequence.

i have added a small state machine in wifi app task to handle power down, but it few seconds for the wifi to get deinitialized for some reason. Commit id  8a5aeaaa9e97c7580073d0344dc4b2045d51d2a1


Fixed rendering bug

I spotted a small rendering issue when attempting to represent a small amount of progress/fill on a larger progress component. You can reproduce this in the example app as per the screenshot below. Set the size of one of the progress indicators to 300 and set the fill to be small (e.g. less than 50) - the fill will appear to render as 2 dashes rather than one.

I was able to fix this by increasing the second stroke dash parameter to an arbitrarily higher value. I'm afraid I don't know where 700 came from, nor do I honestly truly understand this stroke functionality, so you may not find this to be an appropriate solution. However, I found this to work sufficiently for the cases I've tried.

I also observed that the stroke dash is not required for the background as we just want a solid arc. I removed the code and could not observe any difference in rendering behaviour in in the sample app or my own app so I've removed those properties.

I was just wondering when someone might have a chance to look at my PR as I'm currently depending on this library in one of my projects but I am currently pointing to my fork. Let me know if you need any additional explanation.

Looks fine for me, thanks!

Perfect, thanks!


feat: Updated the @Transient from the jakarta dependency.

Description
This is the PR for the TASK
Changes in PR:

Added the Jakarta dependency in pom.xml of appsmith-server and appsmith-interfaces.
Replaced the @Trasient from the jakarta by removing from springframework.

Difference between org.springframework.data.annotation.Transient and jakarta.persistence.Transient
@org.springframework.data.annotation.Transient specifically states to the spring framework that the Object Mapper you are using should not include this value when converting from Java Object to JSON.
Also note if you attempted to persist the above entity into the database, it would still save it to the database because @org.springframework.data.annotation.Transient only applys to Object mapping frameworks not JPA.
fixes- #33572
Please review this PR- @sharat87

Summary by CodeRabbit

Chores

Updated dependencies to use jakarta.persistence-api version 3.2.0.
Refactored annotations from org.springframework.data.annotation.Transient to jakarta.persistence.Transient for multiple models.

Hey @Naveen-Goud, thank you for your work and for opening a PR. However, that task is not intended for the release branch. It is for a separate project, that's still in its own PR, and hasn't been merged to release. We don't want this change on the release branch as it is today.
On that note, I'll be closing this PR. Please pick tasks that have the "Good first issue" label on them to avoid this in the future. Thank you!


[DO NOT MERGE] Add Updated timeago styling to  globally

Normal State

Hover State

We should add it to the Metrics pages too here:

Closing for now until we can find time to work on it.


Ability to block user/orgs

server: Remove unused Organization.Status enum
server: Disable authz and public page in case of blocked subject
server: Disable user & organization API for blocked resources

Would be great with your eyes on this @frankie567 🙏🏼


Create PR to fmu-dataio with Eclipse data types

Mentioned in refinement 30.10.2023

https://github.com/equinor/fmu-dataio/pull/384 Closes


[STORY][Prototype] As a passport holder, I want confirmation of the stake on my identity so that I know my stake is successful

Completed Week 3 Build Week - Refer to Week 3 update in #MC-Demos channel

Acceptance Criteria completed


update readme adding instructions for local setup

Issue describing the changes in this PR
This PR updates readme adding instructions for local setup
Pull request checklist

[X] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[X] My changes are added to the CHANGELOG.md
[X] I have added all required tests (Unit tests, E2E tests)

Additional information
Additional PR information

cc @skyao


Support password Input

There are use cases like "Change / Manage  password " where you mask the information that you have typed in a chatbot with "*" . Having this enabled will allow this to be implemented in many use cases.

@manoj-ganapathy Thanks for this, I'm also looking for this function. I believe you should rephrase it a little, though. AdaptiveCards is not necessarily bound to HTML (many renderers are unrelated).
Basically, the way I see it it would make sense to add a "password" style to the Input.Text; currently supported styles up to now are text/tel/url/email. Each renderer will decide how to produce a Text Input facility (which for HTML would mean a password type input).
The team should add the Schema tag and discuss it.

Thanks for the suggestion folks. My initial thought on this would be a new style enum on Input.Text -- something like password or masked
Thoughts? @dclaux @khouzam
{
   "type": "Input.Text",
   "style": "password"
}

I don't have a strong opinion on the design, however I am not sure this is something Adaptive should support. Do we really want cards to be able to collect passwords? Not that's it's not already possible, but this would make it explicit. I am worried about possible attack/phishing vectors.

@dclaux David you have an interesting point; let me just rephrase it so we can check it more easily. Let me know if this is a correct interpretation.

This feature is to be considered safe, as long as there are no supported cases where the either the host or the card author are unaware of the final wiring (protocol) in use.
E.g. Is it supported for a card author to publish an Action.Submit and such action be transmitted by channels that have not been agreed upon, by a receiving host? Even at an intermediate stage/hop?
Either make it so such case is explicitly unsupported, or let the password feature be implemented by specific hosts by overloading.

We could indeed make it a host option to support password style, that would make things better. Yet, I still feel uneasy about it, because Adaptive Cards will be used by hosts/in contexts that we don't control, and even though I can't put my finger on a concrete example I have a feeling this feature could be exploited. At the same time, I do recognize that some companies still have legacy systems that rely on username/password, but nowadays the "right" way to auth is via an OAuth handshake where the user's credentials never leave the domain/service that owns them.

:) you can’t control the use of profanity so why not remove text block.

Hm I'm not quite sure the use of profanity can have as deep a negative impact on anyone as stealing their credentials...

Seriously, I think that being transport agnostic should work both ways. You don’t guarantee that it’s safe. You don’t prevent the safety features of a protocol to be leveraged either.

The problem is that the masking feature can give the false impression that it is safe for the end user to enter their password. I can tell you that with Actionable Messages in Outlook, for instance, it is absolutely out of the question that we'd make this feature available, even though the underlying channel is verified and the sender of the message is explicitly allowed to do so. We simply don't want to encourage the practice.
I don't own this decision anyway, this is just my opinion. If there is a strong consensus that it is needed, we can certainly add it to the format and allow hosts to opt out.

From a Operation perspective...One of the most common reason for calls to call centers  is for reset password / Change password...If they want to enable this using Chatbots for security type of use cases...it will not be used unless there is secured way for passing this information in encrypted format and also masking the character during the process. I believe if we can get this done. It will be used in many corporate enterprises.

Any updates on this?
Something like this would be really nice for our use case. I understand the security concerns for things like actionable messages and was wondering if there is an existing concept for features that are unsupported on certain platforms? Basically, we'd like to have one for the nodejs, Android, and iOS SDKs so that we can handle the input in a custom action that we've created to handle things securely and specific to our needs. We're trying to avoid creating a full-blown textBlock extension to handle this if at all possible.

Any update on this ?

@matthidinger @dclaux how about having an open meeting to take this argument to some final closure?
@shawnphoffman and @shawnphoffman in line with the comments on this, do remember AdaptiveCards is extendable on the host side too (using such extensibility at large would render many things incompatible, which isn't good, but this particular password thing seems to call for it).
By the way how are you guys? Do you have a Discord channel or some other means to reach out?

Hey Ignacio, long time! We don't have a Discord channel but it's been on the list.
Indeed this is a complicated one from a security standpoint. I will get a thread started with some security folks here at Microsoft and see if any options are available.
In the meantime as Ignacio mentions you can achieve this today using the element extensibility APIs. So if you're stuck trying to achieve that let us know and we can help.

As a bot author, I don't have access to the element extensibility APIs. The platform my bot uses defines how cards are rendered and even which controls I can display. So this solution doesn't work for everyone.
Additionally, every programming language has a method or library for soliciting masked passwords from the user (including Microsoft's Powershell Get-Credential cmdlet). Providing that masking method does not make you responsible for any misuse of that mechanism.

IMHO it is a strange argumentation to not provide masking that it could be used in an unsecure way. A developer has to decide if he has to guard very sensitive information as credit card numbers or if it is just meant to give access to some chatbot features for registered users only.
Without seeing the documentation I automatically wrote it this way:
{
"type": "Input.Text",
"style": "password"
}
but NO... sad (to be read with Trump voice)

Hi team,
Is there any solution for this requirement? I have to implement a Teams integrated solution as well where people have to initialize a password for a secondary account users request.
If Adaptive Cards if not able to provide this, I'll be forced to look for any alternatives. How promising this solution may look for everything else.

No updates on this so far I imagine? I believe that many people would apprechiate something simple, such as a password tag or style so you can enter the characters into a field and spying eyes wouldn't be able to spot the actual password.

Hi folks, we've actively looking into this feature right now and if we get the appropriate security signoff it is a candidate for the upcoming v1.4 release.

Great! we are waiting for it :)

I would like to add my voice of concern to @dclaux 's. This will be abused for bad and just masking the field will give that false sense that the storage or transmission of the password in the field is "secure". I'm sorry to all my fellow pentesters out there that would love to see this feature added.

Is there any update on the release of this feature?

Any updates?

Any updates?

Yes, it's been added to the Milestone 8 Backlog. Just gotta wait and see if it will actually make it in or if it might be cancelled due to security concerns.

Hi everyone, this is a dupe of #4673 and we are going to include it in our next release. No ETA for that release yet but please feel free to "watch" the other issue and we'll keep you updated

OMG it's here!!!!


csv-ingest error

Describe the bug
During the interviews about problem definition, it was identified that csv-ingest is throwing errors on a fresh install. This needs to be tested and verified and fixed if the issue exists.
Steps To Reproduce
install fresh quickstart-vdk
try out csv-ingest
Expected behavior
possibly error
I am sorry I can't tell you more because I don't know what exactly the error was, but this needs to be checked.
Version  (please complete the following information):
no info on this
Additional context
The person also explained that they didn't understand what was the expected outcome, it could be that the expected outcome needs to be documented.
So as part of this ticket please make sure that the documentation about csv-ingest is explaining what it does and why it exists.

Triaged. Closed as stale.


Supporting multiple URL params with launchApp

Is your feature request related to a problem? Please describe.
Why is only one URL param allowed with launchApp({ url })? Is there a specific reason?
Something like https://testt.com/go/?screen=BehaviorLessons&behaviorKey=helpful won't work.
https://github.com/wix/Detox/blame/2cd7b1a2d57eee0b9fa819e1319b557955732ef1/detox/src/devices/Device.js#L119
Describe the solution you'd like
Allow multiple URL params when passing URL to launchApp

@noomorph is this an iOS limitation? I would like to submit a PR.

I think you are confusing things here. Your example is one URL with multiple arguments. That’s supported, you just need to support it in your code.

Also, both operating systems support only URL as input. How would multiple URLs work anyway? It makes no sense.

@LeoNatan it's not - if I do launchApp({ url: 'https://testt.com/go/?screen=BehaviorLessons&behaviorKey=helpful' }} in the app only https://testt.com/go/?screen=BehaviorLessons comes through.

I think you're being a little quick here... I wouldn't raise this concern if I didn't have an issue...

In that case, it's a bug.

ok, let me report it as a bug

But that is ONE URL, not many. Those are arguments.

I have changed the title.

Thanks.
Well, in your code you call them URL params: https://github.com/wix/Detox/blame/2cd7b1a2d57eee0b9fa819e1319b557955732ef1/detox/src/devices/Device.js#L119

@noomorph Can you pls check how the JS handles URLs? Most likely it's an issue with encoding.

@kennym That's something else. Please read the code. It checks that only one of url/userNotification/userActivity is provided.

@LeoNatan good catch.

I think the issue lies here:
https://github.com/wix/Detox/blob/65e1975c5164ee82658255f3ec9e44fdce412896/detox/src/devices/ios/AppleSimUtils.js#L251
Perhaps return _.map(launchArgs, (v, k) => ${k} "${v}").join(' ').trim(); would better. @kennym Would you like to test and possibly submit a PR with a fix?

@LeoNatan I'm going to give that a try tomorrow morning.

Okay, guys, keep me in the loop if you need anything from me. If I got it right, @kennym volunteered to look into it today and you don't need my assistance at the moment. Correct me if I am wrong.

@LeoNatan that fixed it!

Fixed in #1302


Change validation and parse order of postData params/text.

This PR fixes https://github.com/loadimpact/har-to-k6/issues/14
Changes made:

Validation now allows both postData.params and postData.text to be specified.
Special validation case if mimeType is application/x-www-form-urlencoded and both fields are specified.
Prioritize postData.params over postData.text is both are specified.

The validate method is way off when it comes to dryness, but this is nor the time or the place to start a refactor, so LGTM.

Tenks! ✌🏻


feat: Allow binding only via linear element ends

Change the behavior of binding to only allow connections if the start or end node of an arrow is dragged.

Couple more notes:

there are a few cases where we should keep showing the suggested bindings, in particular (check production to see how it works in practice):

when moving bound arrow(s) with a keyboard
when resizing/rotating 3+ point bound arrows
... maybe more?

previously the now removed maybeSuggestBindingForAll() function was bailing if we had more than 50 selected elements. I'd still keep doing this so we don't allocate large arrays on the hot path unnecessarily when calculating the suggested bindings.


Remove duplicate Jenkins builders

Currently there are 2 Jenkins builds firing.  One of them always fails, as it has an old version of Java7 that plays poorly with PowerMock.  We should delete that Jenkins build

@quidryan / @rspieldenner are you able to remove this Jenkins build: https://netflixoss.ci.cloudbees.com/job/Hystrix-pull-requests/ ?

@mattrjacobs When you're logged into CloudBees, do you see the "Delete Project" link?

When I attempt to login, it uses some SSO logic and determines I'm not a member of netflixoss.

You should be able to log using just your email, no password, then get sent
to OneLogin. Once in there, you'll be logged into CloudBees. Then access
netflixoss.ci.cloudbees.com, and click login AGAIN. Can you drop by today?
On Tue, Feb 3, 2015 at 11:43 PM, Matt Jacobs<EMAIL_ADDRESS>wrote:

When I attempt to login, it uses some SSO logic and determines I'm not a
member of netflixoss.
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/Hystrix/issues/605#issuecomment-72804306.

I got @benjchristensen's help on this


/app/credentials.py file missing

Documentation says to update the /app/credentials.py file, but it is not there.

That's an old error on the instructions. You don't need to edit that file anymore, just set the ENV variables in the notebook, that's it.
I just fixed the documentation. Thank you.


Vue component

Hi, love this plugin! I built a plugin to integrate it in Vue.js.
Maybe you want to put a link in the README file.
Here's the url : https://www.npmjs.com/package/vue-scrollmonitor
Keep me posted. Thanks.

Thanks! I'll take a look and probably add a link. Until then I'll leave this issue open so other people can find it.


Adding SQA dataset

As discussed in #880
Seems like automatic dummy-data generation doesn't work if the builder is a ArrowBasedBuilder, do you think you could take a look @lhoestq ?

This dataset seems to have around 1000 configs. Therefore when creating the dummy data we end up with hundreds of MB of dummy data which we don't want to add in the repo.
Let's make this PR on hold for now and find a solution after the sprint of next week

Closing in favor of #1566