[macOS] Treat github-api-pat as sensitive variable

Description
This PR changes github_api_pat Packer variable to be treated as sensitive. This is to prevent the value from being displayed in the logs.

Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

Hey @paveliak! Running tests. Will merge when done.


Add catalog to the work dir path.

Description
Adds catalog to the work dir path for the case where there are the same name schema in different catalogs.
The work dir will be "/Shared/dbt_python_model/{schema}/" without catalog, and "/Shared/dbt_python_model/{catalog}/{schema}/" with catalog.

Thanks! merging.


Cj summary wf cleanup

remove usage of public_ref dir
update and extend READMEs
clean up scripts
rename directories (having Q2 in the names doesn't make sense anymore)

I wasn't sure which names can be changed, and which have to be kept the same to be compatible with the OEB specifications.
There might be potential for more consistent naming, especially in nextflow.config.
There's still a file extension (".bed") hardcoded in compute_metrics.py. I would have parameterized this, but since this script has to be changed anyway if there's a different input file format, I didn't.
Still TO DO:
add description to README with instructions on which files have to be changed in order to tailor the summary workflow to a different benchmarking event
Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have updated corresponding READMEs (if applicable)
[x] My code follows the templates/style guidelines of the repository
[x] In- and output formats comply with APAeval specifications
[ ] No parameters or file names are hardcoded
[x] Results, logs or other output is not commited to the repository
[x] I have tested my code

I wasn't sure which names can be changed, and which have to be kept the same to be compatible with the OEB specifications.
There might be potential for more consistent naming, especially in nextflow.config.
There's still a file extension (.bed) hardcoded in compute_metrics.py. I would have parameterized this, but since this script has to be changed anyway if there's a different input file format, I didn't.

I confirm that it worked like a charm. Thanks again @ninsch3000!
I think we can merge this branch now given that the cleanup is ready and continue working on add_working_Q2_summaryworkflow

Thanks for approving @AsierGonzalez !
I'll merge and then I'll change the READMEs in the other branch, ok?

Sure, please go ahead


Update link to latest browser extension

Let me upload it on our GCS

@fhildeb which version it is? Did you take MV2 or MV3 ?

Its MV3, develop 245

Looks good, thanks!


Add a new, more quiet logger

Example of it in action:
https://github.com/google/wireit/assets/1659/c1f9cc34-0340-4b52-9ac5-8c9f20552196
Also supports watch mode:
https://github.com/google/wireit/assets/1659/72f5d7e0-1d8e-46c4-9ba8-021d19c3df46
Supports services too, emitting their output immediately.

Ah, the change from default broke some tests, I'll get to those tomorrow.

Comments addressed! I rebased over #838 after it was squashed and merged, so only the last two commits are new


Bug fix laravel request host

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ce970de). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head ec98cc6 differs from pull request most recent head 98989fa. Consider uploading reports for the commit 98989fa to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files

@@          Coverage Diff           @@
##             main      #4   +/-   ##
======================================
  Coverage        ?   0.00%
  Complexity      ?      29
======================================
  Files           ?       4
  Lines           ?      65
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?      65
  Partials        ?       0

Flag
Coverage Δ

7.4
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce970de...98989fa. Read the comment docs.


Should fail or warn on duplicate field name

When I validate the following code on JSONlist.com:
{
    "keya": 1,
    "keyb": 0,
    "keya": 0
}

It reports valid JSON. The last value "keya" is taken and the previous is ignored. Some JSON libraries do the same, but AFNetworking in particular fails for duplicate field names.
JSlint reports:

Problem at line 4 character 5: Duplicate 'keya'.

"keya": 0

JSON: bad.

if you do something like this:
{"function": {"replace": {"column": "NAME", "esc_string": "-", "esc_string":"_"}}}

then it will call it valid but the reformatting engine will drop the duplicate.  I think it should just warn cuz this is valid JSON for us, but the reformat should not drop the dup for you


Docs update

Updated docs to have quick start guide. Let me know what you think of it.

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   82.09%   82.09%
=======================================
  Files          37       37
  Lines         905      905
  Branches      110      110
=======================================
  Hits          743      743
  Misses        162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e28d15...5ae57a7. Read the comment docs.


Show mobile menu button on all tabs

Overview
On mobile, we currently only show the menu button (which is the only way to access THORChain Lending and LP) when the Trade tab is active.
It's hidden/not visible otherwise, which is confusing for users.
References and additional details

Acceptance Criteria
Users should be able to access the menu from any tab on mobile.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

@reallybeard - can you tackle this?

@reallybeard - can you tackle this?

this will be fixed in the new mobile UX improvements

closing in pref of #6438
thank you @reallybeard !


Adding a challenges README for static web milestone

This is the initial content for individual and team challenges for the Static Web milestone

:+1:


v1.6 backports 2020-03-04

#9483 -- fqdn: Avoid races when updating global cache on GC (@raybejjani)
#10416 -- Fix dead link in 1.4->1.5 upgrade documentation (@Ropes)
#10434 -- Envoy: Apply CVE fixes 2020-03-03 (@jrajahalme)

Not backported as these depend on other changes not backported to v1.6:

#10218 -- cilium: encryption + tunnel improvements and fixes (@jrfastab)
#10268 -- cilium: encryption, segfaults if existing non-Cilium xfrm policy without mark set exists (@jrfastab)
#10388 -- test: Avoid using global map for Cilium configuration (@brb)

Once this PR is merged, you can update the PR labels via:
$ for pr in 9483 10416 10434; do contrib/backporting/set-labels.py $pr done 1.6; done

This change is

never-tell-me-the-odds

I investigated the failure and am convinced it is not a regression but a flake as described in #10446:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17678/
Ignoring failure to override merge.


Minimum of 20 stars is not being followed

As 5th in the acceptance criteria:

To maintain high quality projects in the list, your project must have at least 20 stars.

I noticed this is not being followed on latest PRs that were merged.
https://github.com/OSSPhilippines/pinoy-made/blob/23189193d4535ff0309aad8ace26b3737e18b751/CONTRIBUTING.md?plain=1#L21

Hey @roniemartinez apologies, we'll take a look first with @jofftiquez thanks!

@roniemartinez This is negligence on our part. Thank you for filing an issue. We cannot remove the merged project but we will make sure to double check the guidelines moving forward. Thank you again! 💪🏽


Incorporate NSIS installer into AppVeyor

@aymanhab is it okay if I work on this?


Added command line and environment to the hermit entry parameters

I'd like to get rid of the hypercalls in uhyve just to retrieve the env and argv. I think it makes sense to add them to the boot information, as they are available at boot time anyway.
(Once implemented in uhyve and hermit, this would solve https://github.com/hermit-os/uhyve/issues/35)

I think that is a good approach, but it should be considered that we potentially pass hundreds of environment variables.
As changing uhyve to use device trees is a bigger project, maybe we can still go with this approach as an intermediate step? (To at get rid of the hypercall first)

I'd like to avoid having to do a entry version jump for this.
I think gradual migration should be easy. I'll open a draft PR tomorrow for initial device tree support for Uhyve, just for bootargs.

Superseded by https://github.com/hermit-os/uhyve/pull/758


Appstudio update test-component-pac-vowa

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-vowa-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
31 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
21 seconds
deprecated-base-image-check

✅ Succeeded
20 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
50 seconds
clamav-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
10 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-vowa-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
9 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary


Reland #74722

Reland #74722 with additional changes. Internal tests are passing (saving for a few minor scuba issues).
The original PR failed some internal tests, because when text is changed but the caret location isn't, we didn't clear the _textChangedSinceLastCaretUpdate flag at the end of that frame. And the next caret location change will be seen as caused by the text change, triggering showCaretOnScreen when it shouldn't.
Original issue: https://github.com/flutter/flutter/issues/74566
Fixes: #76569, #68778, #50713
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I signed the CLA.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong Hey,
I just investigated #76569. It seems that this PR can fix this bug.
I will keep an eye on this and wait to confirm again after landing.

when this merge will be released?


Initial Commit for DLG Crash Info

Please review this DCI module for general release.

Had no issues building/running for compiler 6. Could not build for compiler 5 (v5.06 update 7 (build 960)).

It would be nice to add the cmake build to the example.

Would you change the figures format and style in readme to have the same style for all the examples? you can find the SVG file in the other examples.

Would you change the figures format and style in readme to have the same style for all the examples? you can find the SVG file in the other examples.

Hi, this has never been communicated publicly that we were switching to a standard for the ReadMe.md.   Which examples and can you point me to the internal documentation that describes this process.

There are some issues I need to mention. Is there any particular reason to include both .h and .c file in the project?
In the user app, It is necessary to have the copyright license from Renesas on the files.

in building process , I have this fatal error , did I do something wrong?
compiling user_crash_info.c...
linking...
Program Size: Code=16104 RO-data=2248 RW-data=80 ZI-data=7116
FromELF: creating hex file...
After Build - User command #1: fromelf --bincombined --output=".\out_DA14531\Objects\dlg_crash_info_531.bin"  ".\out_DA14531\Objects\dlg_crash_info_531.axf"
After Build - User command #2: fromelf C:\Users\a5140624\Desktop\Initial\DA145xx_SDK\<IP_ADDRESS>2.1\projects\BLE_SDK6_examples\features\dlg_crash_info\Keil_5\out_DA14531\Objects\dlg_crash_info_531.axf --disassemble --interleave=source  --text -c --output=outfile.lst
ARM FromELF: Execution interrupted due to an illegal storage access.
Finished: 1 information, 0 warning, 0 error and 1 fatal error messages.
".\out_DA14531\Objects\dlg_crash_info_531.axf" - 0 Error(s), 0 Warning(s).
Build Time Elapsed:  00:00:18

by this example we are supposed to see a log each time application crashes on terminal (in this case each time pushing reset button)?
If this is the case I cannot see it. Only on the first run I see such log ,not updating by each push.

There are some issues I need to mention. Is there any particular reason to include both .h and .c file in the project? In the user app, It is necessary to have the copyright license from Renesas on the files.

Yes, the APIs are then exposed and better for reference.  It is a personal peference, and more of the industry standard than not including them.  Having to 'toggle' the header file is 'clunky'

in building process , I have this fatal error , did I do something wrong?
compiling user_crash_info.c... linking... Program Size: Code=16104 RO-data=2248 RW-data=80 ZI-data=7116 FromELF: creating hex file... After Build - User command #1: fromelf --bincombined --output=".\out_DA14531\Objects\dlg_crash_info_531.bin" ".\out_DA14531\Objects\dlg_crash_info_531.axf" After Build - User command #2: fromelf C:\Users\a5140624\Desktop\Initial\DA145xx_SDK\<IP_ADDRESS>2.1\projects\BLE_SDK6_examples\features\dlg_crash_info\Keil_5\out_DA14531\Objects\dlg_crash_info_531.axf --disassemble --interleave=source --text -c --output=outfile.lst ARM FromELF: Execution interrupted due to an illegal storage access. Finished: 1 information, 0 warning, 0 error and 1 fatal error messages. ".\out_DA14531\Objects\dlg_crash_info_531.axf" - 0 Error(s), 0 Warning(s). Build Time Elapsed: 00:00:18

Please do a pull.  This is is an old error message.  The latest Keil does not like to create a listing file properly.  You can check the user Run 2 - on some computers I don't have errors, on others I do.  I still creates the assembly file just throws an error.

by this example we are supposed to see a log each time application crashes on terminal (in this case each time pushing reset button)? If this is the case I cannot see it. Only on the first run I see such log ,not updating by each push.

Are you loading it to flash prior?

There are some issues I need to mention. Is there any particular reason to include both .h and .c file in the project? In the user app, It is necessary to have the copyright license from Renesas on the files.

Yes, the APIs are then exposed and better for reference. It is a personal peference, and more of the industry standard than not including them. Having to 'toggle' the header file is 'clunky'

One other comment.  These files are are config files as well, intended for the user to modify easily if needed.  If I do not include them, it won't be obvious to the users that there is flexibility in the API.


Cannot install out of the box

Hello,
I wanted to use this as a base as I have to deploy multiple namespaces at once in a single Chart.
So as a test I simply tried to install it out of the box with no changes , following the instructions but it failed
helm version
version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.16.10"}

kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:48:33Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1+9807387", GitCommit:"98073871f173baaa04dc2bafab50effd62c308a6", GitTreeState:"clean", BuildDate:"2021-08-06T14:06:43Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}

What I did:
$ helm repo add k8s-as-helm https://ameijer.github.io/k8s-as-helm
"k8s-as-helm" has been added to your repositories

$ helm install my-namespace k8s-as-helm/namespace --version 1.0.2 --dry-run --debug
install.go:178: [debug] Original chart version: "1.0.2"
install.go:199: [debug] CHART PATH: /home/emanuele/.cache/helm/repository/namespace-1.0.2.tgz

Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: could not get information about the resource: resource name may not be empty
helm.go:88: [debug] resource name may not be empty
could not get information about the resource
helm.sh/helm/v3/pkg/action.existingResourceConflict.func1
	helm.sh/helm/v3/pkg/action/validate.go:54
helm.sh/helm/v3/pkg/kube.ResourceList.Visit
	helm.sh/helm/v3/pkg/kube/resource.go:32
helm.sh/helm/v3/pkg/action.existingResourceConflict
	helm.sh/helm/v3/pkg/action/validate.go:43
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
	helm.sh/helm/v3/pkg/action/install.go:293
main.runInstall
	helm.sh/helm/v3/cmd/helm/install.go:267
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:125
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.2.1/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.2.1/command.go:974
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:87
runtime.main
	runtime/proc.go:225
runtime.goexit
	runtime/asm_amd64.s:1371
rendered manifests contain a resource that already exists. Unable to continue with install
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
	helm.sh/helm/v3/pkg/action/install.go:295
main.runInstall
	helm.sh/helm/v3/cmd/helm/install.go:267
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:125
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.2.1/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.2.1/command.go:974
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:87
runtime.main
	runtime/proc.go:225
runtime.goexit
	runtime/asm_amd64.s:1371
INSTALLATION FAILED
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:127
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.2.1/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.2.1/command.go:974
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:87
runtime.main
	runtime/proc.go:225
runtime.goexit
	runtime/asm_amd64.s:1371

OK, we will use the release name as the namespace name unless overridden


New Advantech interfaces

Company Info

Company name: Advantech
Company website: https://www.advantech.com/
GitHub presence: https://github.com/ADVANTECH-Corp/

PnP Device Info

Product website: https://www.advantech.tw/products/68ccaea2-9ff5-4f85-97f2-3d11244b0a08/aimb-286/mod_ad53f4ec-0d78-4995-aeed-337921f3c837
Product website: https://www.advantech.tw/products/68ccaea2-9ff5-4f85-97f2-3d11244b0a08/aimb-233/mod_cde85434-6351-4d35-a510-a6ace6df9d3e
Product website: https://www.advantech.tw/products/1-2jkbyz/ark-1220l/mod_7ca795a7-8a5a-4da8-9a0c-c7776c0fc437
Product website:https://www.advantech.tw/products/1-2jkbyz/ark-1551/mod_47d30ee7-28b6-41bc-83a1-a7ca416e68cd

Model Submission Goals

Device certification

Code Owners & Reserved Names

@paul53huang

@paul53huang can you update this PR to be on sync with the main branch?

@paul53huang can you update this PR to be on sync with the main branch?

@rido-min done!
Thanks for the help!

@rido-min done!
Thanks for the help!

Hi @rido-min my manager already give you permissions to merge pull request.

Hi @rido-min my manager already give you permissions to merge pull request.


Add support for dart compilation-server status

This command would allow for users to query the running status of the resident frontend compilation service for their current project.

@derekxu16 @a-siva is this something that still makes sense to do?

Not sure how useful this is if the command line tool is able to automatically figure out the location of the frontend server and connect to it or start one if there isn't one.

Yeah, I agree. This doesn't seem like a feature that will be used frequently.

That's what I figured, just wanted to make sure there wasn't something obvious I was missing. I'll just close this issue then.


lua51Packages.xml2lua: init at 1.5-2

required by the upcoming rest.nvim
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 286558 run on x86_64-linux 1

5 packages built:

lua51Packages.xml2lua
luaPackages.xml2lua (lua52Packages.xml2lua)
lua53Packages.xml2lua
lua54Packages.xml2lua
luajitPackages.xml2lua


Grammatical change to code signing instructions

This is a documentation-only change to the code signing instructions.

Thanks @drewvolz!


Streaming/Chunked upstream responses are buffered when pagespeed is on

I have an upstream Django server which flushes html in chunks and then optimized by ngx_pagespeed. Config looks like below
    gzip on;
    pagespeed on;
    pagespeed gzip off;
    pagespeed FileCachePath /var/cache/nginx-pagespeed;
    pagespeed HttpCacheCompressionLevel 0;
    pagespeed RewriteLevel Passthrough;

NPS_VERSION=<IP_ADDRESS>
NGINX_VERSION=1.8.1
Nginx alone without pagespeed doesn't do any buffering.
I have tried the same with Apache ModPageSpeed and there is no buferring with Apache and the optimzied html is flushed immediately
Is there any configuration that I am missing with nginx?

Hmm.  That's not supposed to happen: we should be passing through flushes from the origin, not buffering, and we should do that even if you had all the rewriters on.  (And we actually have some pretty complicated logic in our rewriters to make sure we can safely handle a flush anywhere.)
I just tested this with the echo module though, and I'm seeing exactly what you're seeing:
$ curl -sS www.jefftk.com/echoflushecho?PageSpeedFilters=
[2s pause]

before flush

after sleep(2) and flush

$ curl -sS www.jefftk.com/echoflushecho?PageSpeed=off

before flush

[2s pause]

after sleep(2) and flush

This is with:
         location /echoflushecho {
           echo "
before flush
";
           echo_flush;

           echo_sleep 2;

           echo "
after sleep(2) and flush
";
         }

I had thought we had a test for this case, but all I'm seeing is Headers are not destroyed by a flush event.

@jeffkaufman there are some changes around flushing behavior contained in https://github.com/pagespeed/ngx_pagespeed/pull/936
This also contains a test we worked on for timing flushes..
(the PR also contains stuff involving shutting down differently, but it may make sense to factor out just the flushing-related changes).

I have a nice test for this; I'll send it out after lunch

Actually, your test in #936 is good, and mine is too complicated.
The root of the problem here is that we never set the flush flag, in nginx.  Thinking now, we should probably set  the flush flag whenever it's set on the buffer chain coming in?
Looking over #936 and https://github.com/pagespeed/mod_pagespeed/pull/1066, it's not actually clear to me whether this would fix #1163 by default?
(I poked @morlovich again about reviewing #1066 -- I'm sorry it's taking so long!)

On flushing behaviour for the proposed change -- from https://github.com/pagespeed/ngx_pagespeed/pull/936/files#r28490250 :

When string_piece_to_buffer_chain is called by NgxBaseFetch it will always have the flush argument set to true.
By default, we will never flush at all except when we are done transforming (equalling current behaviour).
We could consider switching the new follow_flushes argument to true for nps, which would make us flush when the upstream indicates it want us to. We could recommend enabling flush_html for reverse proxy setups.

The argument for optionizing it is that when we would have very chunky incoming content, it may be nice to have an option to not follow that. But I think defaulting to following flushes would be good?

I'm not sure we need an option not to follow upstream flushes; we've always followed them for apache with no complaints.
We could add an option not to follow them, but then either:

we shouldn't document it, and just keep it as an escape hatch in case there turned out to be something big we were missing, or
we should make it work for both apache and nginx and document it fully

If Apache always behaved like that without trouble, that makes me think the option is overkill too.
But ProxyFetch does seem to handle decisions around flushing carefully, and we need a way to inform it that it should follow flushes for us in ngx_pagespeed (and the other async servers).
Perhaps remove the FollowFlushes options from the mps side in https://github.com/pagespeed/mod_pagespeed/pull/1066 and instead pass in if ProxyFetches should always follow flushes to the ProxyFetchFactory when constructing it?

Background:
ProxyFetch's flush stuff was done for PageSpeedService, which was a proxy,
so bytes were arriving over TCP. A lot of it is basically there to make
sure to
flush data gotten from the backend ASAP, so the first CWND gets sent out as
soon as we get it, then the second one, and so on. Beyond that, it also
tries to limit
memory usage.
This is already all controllable via options->idle_flush_time_ms() and
options->flush_buffer_limit_bytes(), and there is an overall enable switch
in
Options()->flush_html()
On Fri, Mar 25, 2016 at 4:05 PM, Otto van der Schaaf <
<EMAIL_ADDRESS>wrote:

If Apache always behaved like that without trouble, that makes me think
the option is overkill too.
But ProxyFetch does seem to handle decisions around flushing carefully,
and we need a way to inform it that it should follow flushes for us in
ngx_pagespeed (and the other async servers).
Perhaps remove the FollowFlushes options from the mps side in
pagespeed/mod_pagespeed#1066
https://github.com/pagespeed/mod_pagespeed/pull/1066 and instead pass
in if ProxyFetches should always follow flushes to the ProxyFetchFactory
when constructing it?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/ngx_pagespeed/issues/1163#issuecomment-201466577

I'm seeing significantly elevated TTFB (200ms instead of 70ms with ?PageSpeed=off for ~260kb of HTML) using <IP_ADDRESS> on nginx 1.9.15 with fastcgi. This is a new install so I have no previous data for comparison. In my case, enabling the inline_images filter seems to reduce TTFB by 50ms. All details and debug log can be found here.
Any chance this is the same buffering issue (I'd expect pagespeed to at least flush the header asap) or just unavoidable parsing overhead?


Automated cherry pick of #835: Ignore reconciling against unmanaged child jobs in the jobframework

Cherry pick of #835 on release-0.3.
#835: Ignore reconciling against unmanaged child jobs in the jobframework
For details on the cherry pick process, see the cherry pick requests page.
Fix a bug where a child batch/job of an unmanaged parent (doesn't have queue name) was being suspended.

/assign @alculquicondor

Ah, errors.Join was introduced since Go 1.20...
#13 47.92 # sigs.k8s.io/kueue/pkg/controller/jobframework
#13 47.92 pkg/controller/jobframework/reconciler.go:242:24: undefined: errors.Join

/kind bug


Feature Flags component

Resolves: #745
Replaces: #756
Reasoning for this solution in #756 comments.

Any concern about the reasoning that got us here?  Or the general approach?

@jaketrent i love the simplicity and do think that other teams would find by using this approach
for the new colors...will we need to write a guide about how to provide the context value. we'll need to ensure that value matches up with what our button/link/etc components expect. does our team own that flag in launch darkly?


Salt-master: external_auth with pam authentication fails

Issue description
When using salt on nixos, pam authentication does not work.
Steps to reproduce
Using this configuration in /var/lib/salt/master.d/cirb.conf:
external_auth:
  pam:
    vagrant:
     - .*

I would get this error:
λ ~ → salt -a pam '*' -l trace test.ping
[DEBUG   ] Reading configuration from /etc/salt/master
[DEBUG   ] Including configuration from '/var/lib/salt/master.d/cirb.conf'
[DEBUG   ] Reading configuration from /var/lib/salt/master.d/cirb.conf
[DEBUG   ] Using cached minion ID from /etc/salt/minion_id: nixos
[DEBUG   ] Missing configuration file: /home/vagrant/.saltrc
[TRACE   ] The required configuration section, 'fluent_handler', was not found the in the configuration. Not loading the fluent logging handlers module.
[TRACE   ] None of the required configuration sections, 'logstash_udp_handler' and 'logstash_zmq_handler', were found in the configuration. Not loading the Logstash logging handlers module.
[DEBUG   ] Configuration file path: /etc/salt/master
[WARNING ] Failed to open log file, do you have permission to write to /var/log/salt/master?
[WARNING ] Insecure logging configuration detected! Sensitive data may be logged.
[DEBUG   ] Reading configuration from /etc/salt/master
[DEBUG   ] Including configuration from '/var/lib/salt/master.d/cirb.conf'
[DEBUG   ] Reading configuration from /var/lib/salt/master.d/cirb.conf
[DEBUG   ] Using cached minion ID from /etc/salt/minion_id: nixos
[DEBUG   ] Missing configuration file: /home/vagrant/.saltrc
[DEBUG   ] MasterEvent PUB socket URI: /var/run/salt/master/master_event_pub.ipc
[DEBUG   ] MasterEvent PULL socket URI: /var/run/salt/master/master_event_pull.ipc
[DEBUG   ] Could not LazyLoad pam.auth: 'pam' __virtual__ returned False
The specified external authentication system "pam" is not available

Technical details
I am wondering if there is a need for patch for this code: https://github.com/saltstack/salt/blob/develop/salt/auth/pam.py#L150

Salt-version: salt 2017.7.1 (Nitrogen)
System:  17.09.1813.bf3dbc2b38 (Hummingbird)
Nix version: 1.11.15

ping @aneeshusa (the robot doesn't seem to do it ;-)

Due to its extensive modularity, there is a huge number of optional dependencies for Salt, and it's undesirable to include them all in the Nixpkgs version. It looks like external_auth with PAM authentication requires the pam library to be available, so you'll need to override the package in some way include it. You can try to .override the Salt package and include pam in the extraInputs. If that doesn't work, you'll likely need to use overrideAttrs to inject pam in somewhere else.
I have to run at the moment, but if you can't get it working with either of those, leave another comment, and I'll take another look.

@aneeshusa Thanks for your quick repy.
I have just added super.pam to extraInputs (I have already been using such a mechanism to get pycopg2) but without success:
    packageOverrides = super:
      let self = super.pkgs;
          salt = super.salt.override {
            extraInputs = [super.python2Packages.psycopg2 super.pam];
          };
      in { inherit puppetdb-dns geppetto salt; };

In case it helps this is an extract of the auth.py module from salt:
try:
    PAM_START = LIBPAM.pam_start
    PAM_START.restype = c_int
    PAM_START.argtypes = [c_char_p, c_char_p, POINTER(PamConv),
            POINTER(PamHandle)]

    PAM_AUTHENTICATE = LIBPAM.pam_authenticate
    PAM_AUTHENTICATE.restype = c_int
    PAM_AUTHENTICATE.argtypes = [PamHandle, c_int]

    PAM_ACCT_MGMT = LIBPAM.pam_acct_mgmt
    PAM_ACCT_MGMT.restype = c_int
    PAM_ACCT_MGMT.argtypes = [PamHandle, c_int]

    PAM_END = LIBPAM.pam_end
    PAM_END.restype = c_int
    PAM_END.argtypes = [PamHandle, c_int]
except Exception:
    HAS_PAM = False
else:
HAS_PAM = True

I no longer use Salt and this issue was last updated 3 years ago, going to close as stale.


Stream rewrite

This PR removes the need for sniproxy by using nginx's built in stream handling. It requires extensive testing before we mainline to make sure nothing breaks.
It requires significant updates to 2 main images (ubuntu-nginx / generic) & minor tweaks to monolithic (adding expose 443) and docker-compose (removing sniproxy and remapping 443)
Please collate all discussion / issues here, I have opened a PR on ubuntu-nginx in case there are code specific comments:https://github.com/lancachenet/ubuntu-nginx/pull/2
From a docker compose:
git pull
git checkout stream
docker-compose up -d

or if you are running base containers, stop sniproxy, then recreate monolithic using #stream and pass port 443 in as well

Tested the docker-compose branch for stream using a mono - dns pair. I can see https requests coming through the logs for epic, battlenet, stream and origin as expected. Downloads on the big four also seem to work as intended.

I can see the upstream taking effect on the HTTPS requests and the HTTP seem to cache as expected. This change appears to work as expected in my home network.

@mintopia @Lepidopterist any comments or happy to merge?

I've had it running here for a week or so with no issues! Happy to merge.


v1.8 backports 2021-02-12

#14611 -- cilium: Send pod->node traffic through tunnel in IPSec+vxlan case (@jrfastab)

Minor conflict in pkg/node/manager/manager.go.

#14114 -- labelsfilter: add reserved labels to default identity label list (@ArthurChiao)

Minor conflict in pkg/endpointmanager/manager.go.

#14793 -- ipcache: Add ExternalIP of the local node to ipcache (@AnishShah, @brb)

Many minor conflicts.

#14893 -- docs: Add FQDN limitation to IPVLAN docs (@joestringer)
#14913 -- iptables: Fix incorrect SNAT bypass with endpoint routes and tunneling (@pchaigno)

Conflict (the code changed has been refactored).

#14920 -- docs: Document hostport requirements in eni (@joestringer)
#14634 -- Makefile: build Cilium with madvdontneed=1 (@aanm)

Remove change on clustermesh-apiserver.Dockerfile which doesn't exist in v1.8.

#14675 -- bpf: Do not bypass conntrack if running kube-proxy+vxlan+endpoint routes (@pchaigno)

All changed files conflicted.

#14847 -- docs: Added instruction to also delete kube-proxy configmap (@yoshz)
#14756 -- Fix reverse DNAT for externalTrafficPolicy=Local service with kube-proxy (@pchaigno)

Many conflicts.

#14924 -- Fix encryption in IPAM ENI mode (@aditighag)

Couple of conflicts.
I changed EnableIPv4Masquerade to Masquerade in daemon/cmd/ipam.go. Please double check.

#14338 -- labelsfilter: Update documentation and add unit tests (@pchaigno)

Once this PR is merged, you can update the PR labels via:
$ for pr in 14611 14114 14793 14893 14913 14920 14634 14675 14847 14756 14924 14338; do contrib/backporting/set-labels.py $pr done 1.8; done

test-backport-1.8

Cilium-Ginkgo-Test-k8s can be ignored as all the (equivalent) K8s-1.X-kernel-4.9 jobs are passing.


[e2e test] port flash attention from sglang

@Dewei-Wang-sh as discussed offline please provide more details for this issue.

current status:
after code rewriting to block ptr and enabling a subset of the sglang flash attention, the end2end llama3-8B can run.
possible support plans :

get good perf without code rewriting ( compiler do the rewriting is an option)
support full set of the function in this case.
once we have decided what to do next, we can revisit this issue


Fix timezone, week start and count

Hi,
I  added some capabilities to your helpful and wonderful project :

Taking into account timezones
Taking into account the WKST setting ( see WKST example on  http://www.kanzaki.com/docs/ical/rrule.html)
Stop when RRULE[COUNT] is reached (There's a mistake in your computation, I didn't want to change all, therefore I just added some breaks but we can do something better).

If you want to merge my work...
Don't hesitate to ask me if you have questions.
Best,
Jérôme

Thanks for this - the changes look to be very useful
Before I can merge, I will have to test on my end. I am seeing some funkiness with the indentation - think your editor must be set to tabs whereas this project uses 4 spaces as specified in our contributing guidelines. (Please pay particular attention to guideline 3.)

Hi,
Sorry for the indentation.
I'll change my editor configuration before next changes.
Tell me if you want me to change that for the lasts modifications.

Yes please commit again correcting the indention, etc. based on the contributing guidelines. Thanks

Hi,
I opened 3 issues in adequation with my pull request. (I didn't see the one about the timezone already opened, sorry).
I'll work later on correcting the indentation, etc.
A quick question :
Is there a reason that you don't use strtotime instead of the iCalDateToUnixTimestamp method ?
I can't see what this method gives more.
strtotime works fine with timezone and converts properly ICS date format to an unix timestamp.
examples :
strtotime("20160707T150000Z") gives the 7/7/2016 15:00 UTC timestamp
strtotime("20160707T150000") gives the 7/7/2016 15:00 local time timestamp (timezone define in php.ini or by date_timezone_set)

I opened 3 issues in adequation with my pull request. (I didn't see the one about the timezone already opened, sorry).

It's a little late opening issues after committing fixes because normally you would reference in your commit message the issue you are targeting.
--

Is there a reason that you don't use strtotime instead of the iCalDateToUnixTimestamp method ?
I can't see what this method gives more.
strtotime works fine with timezone and converts properly ICS date format to an unix timestamp.

No doubt it's historical and a decision made by the original author

Closing in place of #70


added code, imports and exports for progress video

Added my part of the code, with import, export, and import also to the init file.

Good work @sharafcs50.

Thanks for updating your files Sharaf!

Concerning your handler file progress-hander.js you forgot to add the const related to your function handleProgress (for example video and progressBar)
Concerning the function scrub is the same you forgot to add progress and video elements
For the listeners, you need to create a file for each listener.
For ler mousedown = false; you should put it in the data.js and you just import it when you will need to use it.
and of course for the init.js file you need to import all the listener files you will create. For your case they will be 4.


Fix architecture visualisations on the website

Currently, the arrows seem to be broken:

Also, there are some HTML tags like <sup> displayed.
From this page

I think this is fixed in the current version of the documentation :)


Don't error when unused envs are present

Fixes https://github.com/Xuanwo/serde-env/issues/58

Ideally, it should be controlled by deny_unknown_fields, but I'm okay with proceeding with this PR first.


Update documentation for clean version of datasets

Add a bit of explanation to clean version of TU graph data sets and provide a link to the paper.

Codecov Report

Merging #770 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   98.47%   98.47%
=======================================
  Files         143      143
  Lines        4388     4388
=======================================
  Hits         4321     4321
  Misses         67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee67d93...431f967. Read the comment docs.


Add latest_crosslink to AttestationData - (Spec PR #585)

Description
As an implementor, I want AttestationData to contain latest_crosslink so that it is calculable from within an attestation how many epochs said attestation spans, and that my client is compliant with the Beacon Chain spec v0.4.
Acceptance Criteria

AttestationData contains latest_crosslink (of type Crosslink) instead of latest_crosslink_root.
Relevant references are updated to comply with above. It is up to the implementor to verify operation, however some of these reference are:

The processAttestations method in BlockProcessorUtil.
The updateCrosslinks method in EpochProcessorUtil.

This change is adequately tested.

Additional Information
See https://github.com/ethereum/eth2.0-specs/pull/585

Closed by #399


Error Creating a container with last BCContainerHelper for a BC 14 version

Hello,
I tried to run this PSScript :
$containerName = 'bc14'
$password = 'XXXXX'
$securePassword = ConvertTo-SecureString -String $password -AsPlainText -Force
$credential = New-Object pscredential 'XXXXX', $securePassword
$auth = 'UserPassword'
$artifactUrl = Get-BcArtifactUrl -type 'OnPrem' -country 'fr' -select 'Latest' -version '14.29.47804.0'
#Get-BcArtifactUrl -type 'Sandbox' -version '14.29.47804.0' -country 'fr' -select 'Closest'
New-BcContainer -accept_eula
-containerName $containerName     -credential $credential
-auth $auth     -artifactUrl $artifactUrl
-imageName 'mybcimage'     -isolation 'hyperv'
-memoryLimit 8G     -includeCSIDE
-doNotExportObjectsToText `
-updateHosts
New-BcContainerBCUser -containerName $containerName -Credential $credential -ChangePasswordAtNextLogOn:$false -PermissionSetId SUPER
But i had the following log during creation :
_New-BcContainerBCUser -containerName $containerName -Credential $credential -ChangePasswordAtNextLogOn:$false -PermissionSetId SUPER
BcContainerHelper is version 3.0.0
BcContainerHelper is running as administrator
Host is Microsoft Windows 11 Pro - 21H2
Docker Client Version is 20.10.12
Docker Server Version is 20.10.12
Downloading application artifact /onprem/14.29.47804.0/fr
Downloading C:\Users\StevenBalé\AppData\Local\Temp\b496db32-ab23-4c7c-82b3-bab6663a38ca.zip
Unpacking application artifact to tmp folder using 7zip
Fetching all docker images
Fetching all docker volumes
ArtifactUrl and ImageName specified
WARNING: Unable to find matching generic image for your host OS. Using mcr.microsoft.com/businesscentral:10.0.20348.524
Building image mybcimage:onprem-14.29.47804.0-fr based on mcr.microsoft.com/businesscentral:10.0.20348.524 with https://bcartifacts.azureedge.net/onprem/14.29.47804.0/
fr
Pulling latest image mcr.microsoft.com/businesscentral:10.0.20348.524
10.0.20348.524: Pulling from businesscentral
Digest: sha256:6a94d69217ee35c4f827bc08c307f1ed3f2a8e1e615ab1f0e03e52b6284ee6ec
Status: Image is up to date for mcr.microsoft.com/businesscentral:10.0.20348.524
mcr.microsoft.com/businesscentral:10.0.20348.524
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.20348.524 (ltsc2022)
Host OS Version: 10.0.22000.434 (21H2)
Using process isolation
Files in c:\bcartifacts.cache\uwk5kgnp.3we\my:
Copying Platform Artifacts
c:\bcartifacts.cache\onprem\14.29.47804.0\platform
Copying Database
Copying Licensefile
Copying Installers
C:\bcartifacts.cache\onprem\14.29.47804.0\fr\Installers
Copying TestToolKit
C:\bcartifacts.cache\onprem\14.29.47804.0\fr\TestToolKit
Copying UpgradeToolKit
C:\bcartifacts.cache\onprem\14.29.47804.0\fr\UpgradeToolKit
Copying Extensions
C:\bcartifacts.cache\onprem\14.29.47804.0\fr\Extensions
c:\bcartifacts.cache\uwk5kgnp.3we
Sending build context to Docker daemon  1.183GB
Step 1/6 : FROM mcr.microsoft.com/businesscentral:10.0.20348.524
---> ec337f4a98bc
Step 2/6 : ENV DatabaseServer=localhost DatabaseInstance=SQLEXPRESS DatabaseName=CRONUS IsBcSandbox=N artifactUrl=https://bcartifacts.azureedge.net/onprem/14.29.47804.
0/fr filesOnly=False
---> Running in 5f5a742dfd3d
Removing intermediate container 5f5a742dfd3d
---> 80c467459d71
Step 3/6 : COPY my /run/
---> 1c1ecdcc371f
Step 4/6 : COPY NAVDVD /NAVDVD/
---> 3836827e412d
Step 5/6 : RUN \Run\start.ps1 -installOnly
---> Running in 19a2de3b1e12
Using installer from C:\Run\130
Installing Business Central
Installing Url Rewrite
Installing OpenXML
Installing DotNetCore
Starting Local SQL Server
WARNING: Waiting for service 'SQL Server (SQLEXPRESS) (MSSQL$SQLEXPRESS)' to
start...
Starting Internet Information Server
Copying Service Tier Files
Copying Web Client Files
Copying Windows Client Files
Copying PowerShell Scripts
Copying ConfigurationPackages
Copying Test Assemblies
Copying TestToolKit
Copying UpgradeToolKit
Copying Extensions
Copying ClientUserSettings
Copying ReportBuilder
Restoring CRONUS Demo Database
Determining Database Collation
Changing Database Server Collation to French_100_CI_AS
Restoring CRONUS Demo Database
Installing C:\NAVDVD\Installers\FR\RTC\RoleTailoredClient.Local.Fr.msi
Skipping C:\NAVDVD\Installers\FR\WebHelp\WebHelp.Local.Fr.msi
Modifying Business Central Service Tier Config File for Docker
Creating Business Central Service Tier
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Starting Business Central Service Tier
Importing CRONUS license file
Generating Symbol Reference
Stopping Business Central Service Tier
Installation took 829 seconds
Installation complete
New-Bcimage Telemetry Correlation Id: dc3ec697-5b30-403e-b0a6-a5b8d133d510
New-BcContainer Telemetry Correlation Id: 63b0bf11-1ef8-47fc-9ad4-15ede9022ad1
Docker Build failed with exit code -1
Au caractère C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\3.0.0\ContainerHandling\New-NavImage.ps1:635 : 25

...              throw "Docker Build failed with exit code $LastExitCode"

             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Docker Build failed with exit code -1:String) [], RuntimeException
FullyQualifiedErrorId : Docker Build failed with exit code -1_

is it related to Telemetry feature ?

You would see that the Get-BcArtifactUrl also emits telemetry, so I would not expect that to be a problem.
2 things to try

grab the latest containerhelper
remove -imagename 'myimage' from the new-bccontainer

Are version 14 artifacts removed?
The oldest version is 15 with the following command
Get-BCArtifactUrl -select Latest

@capc0 - on-premises artifacts should still be there if you specify -type onprem
sandbox artifacts are removed over time.

ok i found.
thanks
Steven.

Yeah - this was a different issue (The paging file is too small for this operation to complete.)
Thanks


Fastify - Bad DX error handling

Is your feature request related to a problem? Please describe.
Following this example https://github.com/bufbuild/connect-es-integration/tree/main/fastify any error thrown inside a RPC implementation is not logged to the console. The error is also not propagated to the Fastify error handler.. It seems the error is never propagated or logged https://github.com/bufbuild/connect-es/blob/main/packages/connect/src/protocol-connect/handler-factory.ts#L248-L265 The dev has no idea why the RPC call failed.
Describe the solution you'd like

Allow to define an error handler or
Pass the error to the fastify logger. or
Throw the error in the fastify handler and provide a default implementation so we can handle them natively with fastify.

Please also add an "Errors" section to the Node.js docs https://connect.build/docs/node/getting-started
Please specify whether the request is for Connect for Web or Connect for
Node.js.
Connect for Node.js

This is also affecting us. Just from an expectations perspective, is it likely this will get looked at in the near future or not so much?

We just released support for server side interceptors, with this you can catch errors that are raised inside the RPC handlers:
import * as http from "http";
import routes from "./connect";
import { fastifyConnectPlugin } from "@connectrpc/connect-fastify";
import type { Interceptor } from "@connectrpc/connect";

const logger: Interceptor = (next) => async (req) => {
  try {
    return await next(req);
  } catch (e) {
    const ce = ConnectError.from(e);
    console.log(ce.message);
    throw e;
  }
};

const server = fastify();

await server.register(fastifyConnectPlugin, {
 routes,
 interceptors: [logger],
});

await server.listen({
  host: "localhost",
  port: 8080,
});

You can also use the contextValues pass the fastify logger and access that from the interceptor.

Great news! Thank you. Have you also thought about leveraging the existing technology, Fastify, to implement such functionality? Fastify has an extensive hook system. I find it not intuitive when features are re-implemented, although I understand the reason (easier to implement). In the end, all server plugins are abstracted by the connect interface, and you can't really go just the framework way.

Regarding the issue. As far I understand. Interceptor doesn't solve the issue. Any error in the handler are swallowed https://github.com/connectrpc/connect-es/blob/main/packages/connect-fastify/src/fastify-connect-plugin.ts#L133-L140 and can't be catched by fastify global error handler.

Any error in the handler are swallowed https://github.com/connectrpc/connect-es/blob/main/packages/connect-fastify/src/fastify-connect-plugin.ts#L133-L140

This is not related to implementation errors that are thrown in the handlers, this is in situations where the connect itself fails to write for some reason. This is fallback to not miss such errors.

But the error won't be catchable by fastify global error handler correct?

But the error won't be catchable by fastify global error handler correct?

Are you referring to protocol errors or handler errors?
Connect handles the latter and sends the appropriate error response back to the client. If you want to log them you can use the interceptor to do so. This is equivalent of writing back an error status code in plain fastify.
Protocol errors are unexpected and are currently logged in the snippet you pointed to, if you think there is an idiomatic way of doing that, feel free to open a PR for that.

Thanks for clarifying! I'd like to come back to the initial issue. Do you see a way to leverage fastify more to avoid thinking in connectrpc and fastify? E.g how can we improve the integration in a way that connectrpc handlers behave the same as fastify handlers?

how can we improve the integration in a way that connectrpc handlers behave the same as fastify handlers? That would allow to use fastify as it is with all hooks.

I am not quite sure what you mean here. Can you open a PR with how you think it should look?

Let me rephrase. Connectrpc register routes through fastify. Because it is an integration for fastify, as a dev, I'd expect I can use fastify as it is. This includes the hooks of the full request / response life cycle.


Update install.sh

python2-line:77

Hi, this version only supports Python 2. For Python 3 please see fsociety-team/fsociety.


feat(xdg spec): use $XDG_DATA_HOME by default

Seems the sm-agent binary still create the ~/.supermaven/config.json
close #37

@sm-victorw can you please merge this? Would also be great if sm-agent created the config in the proper location (~/.config/supermaven/config.json) instead of ~/.supermaven.

@sm-victorw since it's not open source and there's no way to contribute, can you tell if there are any plans to change sm-agent to use XDG location as well?


List all accounts in the service

As a developer
I need to retrieve all accounts in the service
So that the application can retrieve data correctly
Details and Assumptions

I need to fetch data from the database with all the accounts registered. The accounts must be provided from a file or a web endpoint.

Acceptance Criteria
gherkin
Given a set of accounts
When I call the database through a function
Then I will retrieve all registered accounts in the service


App not running when installing the package

when i install the package and run react-native run-android it gives this error
> Task :app:processDebugManifest FAILED

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.2/userguide/command_line_interface.html#sec:command_line_warnings
15 actionable tasks: 3 executed, 12 up-to-date
E:\ReactNative\esewatest\android\app\src\debug\AndroidManifest.xml:11:7-34 Error:
        Attribute application@allowBackup value=(false) from AndroidManifest.xml:11:7-34
        is also present at [eSewaSdk.aar] AndroidManifest.xml:14:18-44 value=(true).
        Suggestion: add 'tools:replace="android:allowBackup"' to <application>
element at AndroidManifest.xml:7:5-117 to override.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:11:7-34
        is also present at [eSewaSdk.aar] AndroidManifest.xml:14:18-44 value=(true).
        Suggestion: add 'tools:replace="android:allowBackup"' to <application>
element at AndroidManifest.xml:7:5-117 to override.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup. Run CLI with --verbose flag for more details.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081

Simply replace false with true or  add 'tools:replace="android:allowBackup"' to  element.


bound style attribute is not reflected

Version
3.2.0-beta.1
Reproduction link
sfc.vuejs.org
Steps to reproduce
This is a problem that has occurred since 3.2.0-beta.1.
Bound style attribute is not reflected.
And interestingly, if you add an empty style attribute, the bound style will be reflected.
e.g.
<h1 :style="`color: ${x};`" style="">Hello World!</h1>

See minimal reproduction.
What is expected?
bound style attribute will be reflected
What is actually happening?
bound style attribute is not reflected

Probably the reason for this is that the handling of the case where the style is a string is missing here.


ci: Add cue for bats tests

I'd like to run cue "eval" in a test.bats instead of dagger "do" ... since some universe.dagger.io/x packages need services that we don't run in CI (e.g. kubernetes). Thought that was a good suggestion from @marcosnils do cue eval check versus running 0 tests.
Signed-off-by: Jeremy Adams<EMAIL_ADDRESS>

SGTM! as I said to Jeremy privately. Even though it's not a full E2E test, I do believe it still adds value to prevent possible incorrect CUE plans.

I agree, though with #493 , in practice cue eval is not super helpful because it fails to catch an entire class of the most common errors... Still can't hurt to have it, just want to set expectations.

On the other hand, I guess that once the CUE package manager is in place, each universe package could live on it's own repo with their correspodning proper CI infrastructure to test it better.

I think there's an opportunity for universe to provide a common test infrastructure that makes it very easy for each universe package to get maximum coverage with minimum work. It could actually be an argument in favor of adding it to universe instead of keeping it standalone. To be discussed later :)

@jpadams if you rebase on main you should pickup the fix to the connection closed before server preface received errors CI is getting

Rebasing ...

New failure involving GHA cache timeouts is a separate issue from the previous. It's tracked here: https://github.com/dagger/dagger/issues/2365
Should pass on a retry (eventually).

@jpadams Hackish: You can use dagger do ACTION --help to do some bare minimum validation.
That will load the plan, run the validator, scan for actions and some other stuff.
Will probably catch more flukes than cue eval

@jpadams Hackish suggestion: You can use dagger do ACTION --help to do some bare minimum validation.
That will load the plan, run the validator, scan for actions and some other stuff.
Will probably catch more flukes than cue eval

@aluzzardi using dagger do ACTION --help takes care of everything cue eval would have done and more, then sounds like I should abandon this PR and keep it simple :)
cc @shykes

@aluzzardi Was mulling over not adding cue for cue eval tests and instead using dagger do ACTION --help, but...noticed issue prob related to an existing issue.
//...working dagger plan above
foo: bad //where `bad` is undefined
//working dagger plan below...

will show up with cue eval:
$ cue eval
actions.test.deploy.foo: reference "bad" not found:
    ./test.cue:37:16

but not with dagger do test --help
$ dagger do test --help
Usage:
  dagger do [flags]

Flags:
...

Opened a quick fix in #2378
@jlongtine Can you take a look?


Nesbox Problem

I have the nesbox ready on Weebly and I loaded the rom and it says click here to play game, but I can't click on it.

I clicked on it and it just reloaded the page

dont click on the embed i sent. cop and paste it to your site
On Thu, Feb 1, 2018 at 1:04 PM, Tyr3<EMAIL_ADDRESS>wrote:

I clicked on it and it just reloaded the page
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nesbox/emulator/issues/83#issuecomment-362385509, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AgYef37gA7S0gpgh-mnfWPVpsATcU1Scks5tQhjQgaJpZM4R0fdj
.

--
Best Regards
-Kiel

i clicked on it in the site

weird, it runs just fine on mine
On Fri, Feb 2, 2018 at 12:26 PM, Tyr3<EMAIL_ADDRESS>wrote:

i clicked on it in the site
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nesbox/emulator/issues/83#issuecomment-362681811, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AgYefxgClnYUkP5n0Z_Y0QQhfP1h82Y9ks5tQ2FhgaJpZM4R0fdj
.

--
Best Regards
-Kiel

what did you do?


Azure Arc supports any recovery of failed deployment which updated db

Scenario:
Application code and CI-CD is outside of azure (on-Prem)
After CI-CD I'm pushing built application image to Azure Image Registry.
Helm charts is doing deployments  as per namespace (Azure Kubernetes Cluster), in the helm multiple stages present with single deployment. (multiple stages of sync, in a single deployment 6 stages- each stage upgrades kubernetes resources).
Within this stages im dealing with database schemas ( Azure SQL Server DB) and Persistent storage too.
Question:
In case of new image comes up and Azure Arc is syncing the change with deployment and for some reason helm deployment fails and there already some changes done at schema/ storage?
What are the options available for self healing / resolving such failures / rollback mechanism for configuration + database changes?

Hi @vinupatil2008 , I am not sure I fully understand the Q but when it comes to Azure Arc, by having a GitOps configuration that points to your application git repo, you will be able to (potentially) roll back to the previous config. I say "potentially" because I don't completely understand the entire flow of the deployment.
As for the database, I highly recommend reading this great article from Weaveworks around how to correctly handle DB schemas during Kubernetes rollouts.

@vinupatil2008 I will go ahead and close this for now. Feel free to reach out for anything else.

Hi @vinupatil2008 , I am not sure I fully understand the Q but when it comes to Azure Arc, by having a GitOps configuration that points to your application git repo, you will be able to (potentially) roll back to the previous config. I say "potentially" because I don't completely understand the entire flow of the deployment.
As for the database, I highly recommend reading this great article from Weaveworks around how to correctly handle DB schemas during Kubernetes rollouts.

Thank you

@vinupatil2008 I will go ahead and close this for now. Feel free to reach out for anything else.

Thank you Kamrat.
Article you shared is good information, it cleared out many things.


Receba

https://github.com/NVIDIA/DeepLearningExamples/issues/1416

Please open an issue with more details.


file descriptors cache needs to be disableable / configurable

Cuz for now it could cause issues on fetching pieces on the other nodes like
2024/09/11 13:51:50 [STORAGE] LOAD PIECE FROM <IP_ADDRESS>:10501 ERR: failed to query piece 4. err: response deadline exceeded, err: context deadline exceeded

because node is waiting infinitely, also limit is too low for the lib as server usually have unlimited file descriptors setting.
But for nor now it is impossible to manage it, because
fs is private (being used in torrent.getInternalPieces)
limit is const
Reproduce steps:

create multiple bags on a single process with ~10 mb file

tr, err := storage.CreateTorrent(ctx, c.rootStoragePath, user, user, c.progress, c.conn, refs, func(done uint64, max uint64) {
		if done == max {
			wg.Done()
		}
})
err = tr.Start(true, true, false)

request those files on Ton-Proxy multiple times, after 3-4 try download gets stuck

curl ... -x https://<IP_ADDRESS>:8081 http://<BAG_ID>.bag/output.mp4 -o output_d.mp4

> GET http://<...>.bag/output.mp4 HTTP/2
> Host: ....bag
> User-Agent: curl/8.4.0
> Accept: */*
> Proxy-Connection: Keep-Alive
>
{ [5 bytes data]
  0     0    0     0    0     0      0      0 --:--:--  0:09:42 --:--:--     0^C

^ 10 minutes trying to download
in case of downgrade to 0.6.3 issue is not reproducable anymore

@xssnick I'll take a look at it

@kolayuk could you provide a fully reproducible scenario, the code snippet you provided is quite incomplete. Just the most simple way to reproduce it. Would be quite helpful.

Yes, if if would be possible to override fs without a limit / cache (custom implementation up to executable) - it would be a solution

It is strange why it stuck and not downloads after some attempts, it blocks forever and never unlocks?

It will unlock probably at the point when FDs will go lower than 800, but it can take a lot of time if you're continue to serve all your uploads (or you have to manually stop some of them). But my point is this limitation makes some sense for consumer machines (as linux usually have 1024 default limitation) - but makes no sense to have it strict limitation in lib (not in cli) as lib can be used in server-side software and servers usually have 1M file descriptors limitation or
$ ulimit -n
unlimited

depends on kernel

Yes, @kolayuk you are right the reason why its get locked is because the 800 limit is reached. And as long as fs.Free() is not called this counter of FDS won't decrease, hence not unlocking. About increasing the limit, I also agree on the point of at least making it configurable.

It is strange why it stuck and not downloads after some attempts, it blocks forever and never unlocks?

The reason is because the limit is reached, and the call to Wait() in Acquire method will block until the current FD counter decrease. At least this is what I think. Maybe we should think about how to make this limit configurable

As an option, we can make it configurable by command line argument, with default value to unlimited (or something really big), then if someone wants to tune it he can use this argument to set a specific value

Actually PR above with the increase does not help, interfaces are needed to override that behaviour. Lock occurs from the mutexes, not that FD limit


KEB update queue is inconsistent at processing operations

Description
The update queue has odd behaviour when processing update operations. An operation as observed in BTP cockpit shows "Failed" without any explanation, but in KEB database it shows
{"state":"succeeded","description":"update in progress"}

Previously it also showed no state at all with a description update in progress, which likely confused BTP cockpit and it eventually considered the operation as failed.
Expected result
consistent and deterministic processing of update operations to always contain valid state as well as matching description.
Actual result
inconsistent and non-deterministic update operations processing with mismatching description.
Steps to reproduce

update an SKR from BTP cockpit.
Troubleshooting

I thoroughly checked KEB's behavior while it's processing the update queue. Everything works fine, just an update of operation description on success was missing. I addressed this in the following PR:
https://github.com/kyma-project/control-plane/pull/1162

BTP Cockpit does not refresh update status until user reloads a page. Even when KEB and Provisioner are done with processing update operation and mark it as succeeded, BTP Cockpit displays Processing status. After some time BTP Cockpit session expires, a pop-up window to reload a page appears and user is required to do so. After page reload, update status in BTP Cockpit is green.

thanks @szwedm for thorough investigation. I guess the most problematic part when BTP Cockpit was showing "failed" despite KEB reporting "success" has already been fixed on the other side of the fence. I think there might be still some room for UX improvement on the BTP Cockpit side but that is not in scope of this issue.
I vote for successful close of this one.

@szwedm never mind, I guess I was wrong with the stability of this. @PK85 found another instance of our update queue manager to not be as robust as we hoped, copying his comments here for better visibility:

Something is still messed up on our side. I'provisioned canary azure 2.0 in our kyma-integration GA and in BTP status "in progress" in a forever mode. Then checked did investigation on our side:

https://kyma-env-broker.{{ host  }}/oauth/v2/service_instances/516C9308-DDF3-4D1C-A1A7-E14EB80724FF/last_operation

returns:

{
	"state": "in progress",
	"description": "update in progress"
}

Gardener was updated really fast and nodes were scaled up.

Next:

kcp runtimes -c c-713d7b2 -o json

and:

  "data": [
    {
      "instanceID": "516C9308-DDF3-4D1C-A1A7-E14EB80724FF",
      "runtimeID": "36bdb89e-d62b-440c-9dc7-a9f2e5f7b376",
      "globalAccountID": "d4037436-f01a-4adc-aa2b-52836f459bfe",
      "subAccountID": "30a620f8-cf71-4a67-9f67-38343fe4e38e",
      "region": "westeurope",
      "subAccountRegion": "cf-eu10-canary",
      "shootName": "c-713d7b2",
      "serviceClassID": "47c9dcbf-ff30-448e-ab36-d3bad66ba281",
      "serviceClassName": "kymaruntime",
      "servicePlanID": "4deee563-e5ec-4731-b9b1-53b42d855f0c",
      "servicePlanName": "azure",
      "provider": "Azure",
      "status": {
        "createdAt": "2021-12-10T10:19:27.832071Z",
        "modifiedAt": "2021-12-13T21:51:04.915981Z",
        "state": "updating",
        "update": {
          "data": [
            {
              "state": "in progress",
              "description": "update in progress",
              "createdAt": "2021-12-13T21:51:04.412161Z",
              "operationID": "022c887a-cd66-4b91-9597-b20633b1e4d6"
            }
          ],
          "totalCount": 1,
          "count": 1
        }
      },
      "userID"<EMAIL_ADDRESS>      "avsInternalEvaluationID": 156095257
    }
  ],
  "count": 1,
  "totalCount": 1

fwiw, it looks like KEB is sometimes just really slow at processing the update operation because today it is marked as successfully processed
$ kcp runtime -c c-713d7b2 -ojson

{
  "data": [
    {
      "instanceID": "516C9308-DDF3-4D1C-A1A7-E14EB80724FF",
      "runtimeID": "36bdb89e-d62b-440c-9dc7-a9f2e5f7b376",
      "globalAccountID": "d4037436-f01a-4adc-aa2b-52836f459bfe",
      "subAccountID": "30a620f8-cf71-4a67-9f67-38343fe4e38e",
      "region": "westeurope",
      "subAccountRegion": "cf-eu10-canary",
      "shootName": "c-713d7b2",
      "serviceClassID": "47c9dcbf-ff30-448e-ab36-d3bad66ba281",
      "serviceClassName": "kymaruntime",
      "servicePlanID": "4deee563-e5ec-4731-b9b1-53b42d855f0c",
      "servicePlanName": "azure",
      "provider": "Azure",
      "status": {
        "createdAt": "2021-12-10T10:19:27.832071Z",
        "modifiedAt": "2021-12-13T21:51:04.915981Z",
        "provisioning": {
          "state": "succeeded",
          "description": "Operation created",
          "createdAt": "2021-12-10T10:19:27.826292Z",
          "operationID": "54169518-7c6e-4275-917b-e8ab1301f52a"
        },
        "upgradingKyma": {
          "data": null,
          "totalCount": 0,
          "count": 0
        },
        "upgradingCluster": {
          "data": null,
          "totalCount": 0,
          "count": 0
        },
        "suspension": {
          "data": null,
          "totalCount": 0,
          "count": 0
        },
        "unsuspension": {
          "data": null,
          "totalCount": 0,
          "count": 0
        }
      },
      "userID"<EMAIL_ADDRESS>    }
  ],
  "count": 1,
  "totalCount": 1
}

I suppose a good starting point would be looking at prometheus metrics for how long it takes to process various operations (or add some if they don't exist yet)

Digging through the logs didn't help me to discover anything useful.

It looks like provisioner took ~6 minutes to poll gardener for success on the operation 80e8602b-0f62-4a5e-94ac-89079793bd42,

started at Dec 13, 2021 @ 22:51:05.183
finished at Dec 13, 2021 @ 22:57:50.854
logs

KEB processing of that operation seems to have halted

it called provisioner at Dec 13, 2021 @ 22:51:05.180 but last log message in KEB mentioning this update operation_id=022c887a-cd66-4b91-9597-b20633b1e4d6 is Dec 13, 2021 @ 22:51:05.199, after that KEB never reuques this operation
logs

I have tried to reproduce the case and I couldn't get the exact same behaviour.

@wozniakjan thanks for the information. We might have a bug in the update queue that will be really hard to spot. It's strange that KEB dropped the update operation, leaving it with 'in progress' state. I wonder if that could happen when KEB pods are terminated while the operation has not been fully processed.

KEB pods are terminated while the operation has not been fully processed.

that was also my suspicion but at the moment of writing this, KEB has been up for over 3 days without being terminated, so it is probably something else. For me, really hard to debug, I think we may want to implement better and more detailed tracking for each operation at the cost of performance.

update: there are actually two bugs both introduced by my PR #825

the update queue will always try to check reconciliation status for kyma2.0. In this case, the status was failing because reconciliation had some bugs, but for min/max updates we don't need to check that and can pronounce cluster healthy despite reconciliation failing
the operation needs to be explicitly marked as "failed", and it wasn't implemented that way.

I will submit a PR shortly addressing at least some portion of the shortcomings.


[STORM-3718] Updating the dropwizard dependency

What is the purpose of the change
Updating the dependency since the company that I work at (JPMC) currently is using this image, however our container scanning tool AquaSec shows that there is a critical vulnerability with the current version and suggested that it gets updated to version 1.3.19
How was the change tested
Update the different dependencies as required when the build fails and re building to see if it passes

Thanks for updating. Can you squash the commits?

Are you able to do that when you click merge on the dropdown? I can't figure out how to do it in intellij. If not I'll try again.


MudDrawer - Weird opening with longer menu names

Bug type
Component
Component name
MudDrawer
What happened?
If you menu items names with 2 or more words and is slight long, then when the mud drawer is opening from a "mini" state, the name is wrapped onto multiple lines, pushing other menu items below it down, then when the draw has fully opened, the second word pops back up to the correct position and everything aligns again. This results in weird looking animation when opening the drawer.
Example Gif

Frames from the gif which show the wrapped text issue

Expected behavior
The menu name shouldn't be wrapped so it doesn't go to the line below for the brief moment the drawer is opening.
Reproduction link
https://try.mudblazor.com/snippet/GYQwYbFsWcHhZwNA
Reproduction steps
See reproduction link
Relevant log output
No response
Version (bug)
6.0.2
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Adding nowrap onto the MudNavLink appears to fix it.
<MudNavLink Href="/importforecasts"<EMAIL_ADDRESS>Style="white-space: nowrap">
       Import Forecasts
</MudNavLink>

Is this something that should be added to the mud-nav-item class by default?

Adding nowrap onto the MudNavLink appears to fix it.
<MudNavLink Href="/importforecasts"<EMAIL_ADDRESS>Style="white-space: nowrap">
       Import Forecasts
</MudNavLink>

Is this something that should be added to the mud-nav-item class by default?

@Garderoben

Adding nowrap onto the MudNavLink appears to fix it.
<MudNavLink Href="/importforecasts"<EMAIL_ADDRESS>Style="white-space: nowrap">
       Import Forecasts
</MudNavLink>

Is this something that should be added to the mud-nav-item class by default?

This doesn't fix it completely. Because then you can no longer have multi line NavLinks. See https://github.com/MudBlazor/MudBlazor/pull/3181

I applied the "white-space: nowrap" fix as described by @Gareth064 but I still find that the height of MudNavLinks changes between 40px and 40.5px depending on whether the menu is closed or open. Hard-coded the height to fix it for now.

@danielchalmers do you know how to fix it?

You can set a static width for the drawer content (height on top/bottom) to avoid it resizing during transition and thus wrapping what's inside:
  &.mud-drawer-pos-left .mud-drawer-content {
    width: var(--mud-drawer-width, var(--mud-drawer-width-left));
  }

  &.mud-drawer-pos-right .mud-drawer-content {
    width: var(--mud-drawer-width, var(--mud-drawer-width-right));
  }

This will result in a scrollbar when it's closed and during transition. You could hide the overflow to avoid that scrollbar, but the fact that some users might have designed their drawer to include scrollbars complicates this.
Removing support for scrollbars out-of-the-box would be simplest because it seems like an edge case anyway. If they need it back they can override the styles. I just don't know how widespread this is.


lengthen the fs-drift CI test to 15

original duration was 5 seconds, but
fs-drift default report interval changed from 1 to 5 sec,
so no records were getting generated for thread counters
causing CI test to fail when it looked for records in
corresponding index.

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

Results for minikube_jjb

Test
Result
Retries
Duration (HH:MM:SS)

/rerun all

Results for minikube_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fs_drift
Pass
0
00:05:27

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fs_drift
Pass
0
00:04:08


Workbench on IE 11 not working

I get the following error when trying to run spfx  on IE 11 in workbench On-Premise
@font-face failed OpenType embedding permission check. Permission must be Installable.
File: fabricmdl2icons-2.23.ttf
webpart wont' load in IE but works good in chrome

Thank you for reporting this issue, but all SPFx or SP Dev issues should be reported in the sp-dev-docs issue list like noted in the issue template of this repository. This issue list should be only used for sample issue.
This is just to ensure that the issue you are reporting will be addressed and noted officially by our engineering. Thanks for moving this to the right location.


Updated Logo and Responsiveness

Fix: #231
I have done all the changes as mentioned in the issue.
Description:
-I have updated the Logo to match with the website's UI.
-The logo changes according to the light and dark mode.
Before:

After:

-I have also added responsiveness for devices larger than 992px screen.

Please note that this is not in line with our code of conduct. To ensure clarity and proper assignment tracking, please attach the issue number to your PR description. This helps us confirm that the issue is assigned to you. Kindly update your PR with the issue number and resubmit.
Example:
Fixes #123 - Brief description of the fix.

I have added the issue number

Great contribution to GSSOC'24! 🎉

It is working on my Laptop. I have updated my fork too.

Create PR again


No focus for X11 window if mouse is not over it, despite forceinput

I'm on the git version of hyprland:
❯ pacman -Qm | grep hyprland
hyprland-git r2046.0634abf-1
waybar-hyprland 0.9.15-1

I installed the release version of albert:
pacman -S albert

I want to launch it through the X protocol as it doesn't work well with Wayland, see here.
I've put this in my config file:
windowrule = center,^(albert)$
windowrule = forceinput,^(albert)$
exec-once = QT_QPA_PLATFORM=xcb albert

After albert is launched:
albert &; disown

And shown:
albert show

The floating window does not receive focus if the mouse is not over it, despite the forceinput.

I can still obtain focus through the movefocus dispatcher, but it seems it is because it moves the mouse

any other app besides albert? It requires a fuckton of deps.

sorry I don't think I have any other XWayland apps installed.
I also don't use albert anymore.

Since i discovered the issue while implementing noinitialfocus, here is a short description where to look if you also have such a problem:
The app has probably met one of these rules which is why m_bNoInitialFocus = true; was set and therefore the window don't get the initalFocus. By setting forceinput you have ensure to get the initialFocus because in this line if statement we override the  m_bNoInitialFocus to false.

any other app besides albert? It requires a fuckton of deps.

Can confirm on ulauncher and catapult on GDK_BACKEND=x11

I can still obtain focus through the movefocus dispatcher, but it seems it is because it moves the mouse

So how do you use the movefocus? In a key binding or in a window rule?

Is this still a problem?

@raffaem

as I said I don't use albert anymore and don't user hyprland either for the time being.
Closing as the issue is now moot.


Correct iard.md

Remove all references to the MinimumAgePolicyProvider that is not used when using IAuthorizationRequirementData.
The middleware constructs a policy adding the requirements from IAuthorizationRequirementData.GetRequirements
https://github.com/dotnet/aspnetcore/blob/82b0fc9f43ae2bd50fb95f427116efc2f6f094df/src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs#L130

Internal previews

📄 File
🔗 Preview link

aspnetcore/security/authorization/iard.md
Custom authorization policies with IAuthorizationRequirementData

@adityamandaleeka can you assign someone to review this?


Missing breaks in switch statement

My interpretation of this code is that should the if statement evaluate to false the corresponding return won't be called, and the program will erroneously move onto the next case statement. Each case statement should end with a break;.
https://github.com/CANopenNode/CANopenNode/blob/533801574055c5dacf60fb6b18930c288336dce1/stack/CO_PDO.c#L843-L850

No the code works as intended, it needs to drop through
It checks N data bytes (where N is 1-8 as set by the PDO length) to see if
the the value has changed compare to the cached value and the COS flag is
set for that byte. If any byte has changed AND has a COS flag the entire
PDO must be transmitted. As soon as it has a match it returns 1, if it does
not match it checks the next byte in the PDO until all bytes are checked,
The switch just lets it jump into the correct starting N.
Regards
Robin
On 13 September 2017 at 13:41, Matthew Watson<EMAIL_ADDRESS>wrote:

My interpretation of this code is that should the if statement evaluate to
false the corresponding return won't be called, and the program will
erroneously move onto the next case statement. Each case statement should
end with a break;.
https://github.com/CANopenNode/CANopenNode/blob/
533801574055c5dacf60fb6b18930c288336dce1/stack/CO_PDO.c#L843
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CANopenNode/CANopenNode/issues/58, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJtGPlcwX9Y9TVY1PiaOREWfeVhm-Naks5sh81wgaJpZM4PWC75
.


[Feature Suggestion] progress meter (pv subcommand)

hello, again
you may consider this eye-candy, but it is some quality of life improvement.
use case (implementation)
pv
the pv command -- https://linux.die.net/man/1/pv
$ pv --help
Usage: pv [OPTION] [FILE]...
Concatenate FILE(s), or standard input, to standard output,
with monitoring.

  -p, --progress           show progress bar
  -t, --timer              show elapsed time
  -e, --eta                show estimated time of arrival (completion)
  -I, --fineta             show absolute estimated time of arrival
                           (completion)
  -r, --rate               show data transfer rate counter
  -a, --average-rate       show data transfer average rate counter
  -b, --bytes              show number of bytes transferred
  -T, --buffer-percent     show percentage of transfer buffer in use
  -A, --last-written NUM   show NUM bytes last written
  -F, --format FORMAT      set output format to FORMAT
  -n, --numeric            output percentages, not visual information
  -q, --quiet              do not output any transfer information at all

  -W, --wait               display nothing until first byte transferred
  -D, --delay-start SEC    display nothing until SEC seconds have passed
  -s, --size SIZE          set estimated data size to SIZE bytes
  -l, --line-mode          count lines instead of bytes
  -0, --null               lines are null-terminated
  -i, --interval SEC       update every SEC seconds
  -w, --width WIDTH        assume terminal is WIDTH characters wide
  -H, --height HEIGHT      assume terminal is HEIGHT rows high
  -N, --name NAME          prefix visual information with NAME
  -f, --force              output even if standard error is not a terminal
  -c, --cursor             use cursor positioning escape sequences

  -L, --rate-limit RATE    limit transfer to RATE bytes per second
  -B, --buffer-size BYTES  use a buffer size of BYTES
  -C, --no-splice          never use splice(), always use read/write
  -E, --skip-errors        skip read errors in input
  -S, --stop-at-size       stop after --size bytes have been transferred
  -R, --remote PID         update settings of process PID

  -P, --pidfile FILE       save process ID in FILE

  -d, --watchfd PID[:FD]   watch file FD opened by process PID

  -h, --help               show this help and exit
  -V, --version            show version information and exit

re-use case/synergy
you could reuse the pv implementation for the status output of the dd command
prior art
gnu shtool prop
markdown cannot show it correctly but the propellor will be printed on the same line
$ dd .... | shtool prop -p "processing" 2>&1|tr '\r' '\n'
processing...|
processing.../
processing...-
processing...\
processing...|
processing.../
processing...-
processing...\
processing...|
processing.../
processing...-
.....

dd
modern dd has the status=progress option that print transfer stats every second like this:
$ dd ..... status=progress 2>&1|tr '\r' '\n'
271581184 bytes (272 MB, 259 MiB) copied, 1 s, 271 MB/s
551550976 bytes (552 MB, 526 MiB) copied, 2 s, 276 MB/s
832569344 bytes (833 MB, 794 MiB) copied, 3 s, 277 MB/s
1110441984 bytes (1,1 GB, 1,0 GiB) copied, 4 s, 278 MB/s
1391460352 bytes (1,4 GB, 1,3 GiB) copied, 5 s, 278 MB/s
1671430144 bytes (1,7 GB, 1,6 GiB) copied, 6 s, 279 MB/s
1951399936 bytes (2,0 GB, 1,8 GiB) copied, 7 s, 279 MB/s
2231369728 bytes (2,2 GB, 2,1 GiB) copied, 8 s, 279 MB/s
2509242368 bytes (2,5 GB, 2,3 GiB) copied, 9 s, 279 MB/s
2790260736 bytes (2,8 GB, 2,6 GiB) copied, 10 s, 279 MB/s
3070230528 bytes (3,1 GB, 2,9 GiB) copied, 11 s, 279 MB/s
3351248896 bytes (3,4 GB, 3,1 GiB) copied, 12 s, 279 MB/s
3633315840 bytes (3,6 GB, 3,4 GiB) copied, 13 s, 279 MB/s
3914334208 bytes (3,9 GB, 3,6 GiB) copied, 14 s, 280 MB/s
.....

wget
wget has:

--progress=dot – traces the retrieval by printing dots on the screen, each dot representing a fixed amount of downloaded data.
--progress=bar – draws an ASCII progress bar graphics (a.k.a "thermometer" display) indicating the status of retrieval. If the output is not a TTY, the "dot" type will be used by default.

$ wget --progress=dot .....

     0K .......... .......... .......... .......... ..........  1%  194K 17s
    50K .......... .......... .......... .......... ..........  3%  394K 12s
.....
  3200K .......... .......... .......... .......... .......... 99% 11,9M 0s
  3250K .......... .........                                  100%

$ wget --progress=bar .....
FILE             0%[....................]       0  --.-KB/s
FILE             1%[....................]  43,69K   172KB/s
FILE             4%[....................] 159,69K   311KB/s
FILE            18%[==>.................] 595,69K   774KB/s
FILE            35%[======>.............]   1,13M  1,10MB/s
FILE            53%[=========>..........]   1,70M  1,38MB/s
FILE            65%[============>.......]   2,10M  1,47MB/s
FILE            83%[===============>....]   2,66M  1,63MB/s
FILE           100%[===================>]   3,19M  1,75MB/s

curl
curl has a simple progress bar
$ curl -# .... 2>&1|tr '\r' '\n'
#=#=-#
##O#- #
#=#=#   #
-#O#- #   #

                                                                                0,2%
                                                                                1,1%
##                                                                                2,8%
#####                                                                                6,2%
##########                                                                           13,2%
#####################                                                                25,5%
###############################                                                      38,5%
###########################################                                          52,0%
#####################################################                                64,1%
##########################################################                           69,9%
####################################################################                 82,8%
################################################################################     97,3%
################################################################################### 100,0%

So you want toybox's "count -l" to have an -L 8123748 variant so it knows how much data to expect and can do a progress bar and percentage complete?
As for "prior art", one of my first interactions with busybox back in the day was submitting my little "count" toy to them I'd been using since the 90's http://lists.busybox.net/pipermail/busybox/2003-October/043590.html and the immediate suggestion was of course to add a progress bar ala http://lists.busybox.net/pipermail/busybox/2003-October/043613.html and then there was bikeshedding on the list and the IRC channel and a fw weeks later the concept went in as https://git.busybox.net/busybox/commit/?id=e9080c9f4170 and then there was more bikeshedding I largely stayed out of because I'd been happy with "count"...

that is why i did not use the word "request" but rather "suggestion".
and i have to confess that i totally missed "count".

So you want toybox's "count -l" to have an -L 8123748 variant so it knows how much data to expect and can do a progress bar and percentage complete?

lets skip the discussion about a (graphical) progress meter a bit.
i have looked at count -l and it is a wonderful headstart i did not notice.
given that, a -L <expected-total> would be nice to show a "percentage complete".
looking at wc ... would it make sense to have an option to count lines (\n) instead ?
i have a number of use cases where a script reads line-wise from a file, calculating and showing progress.

You mean give count a line counting option? I could make -L do line counting and -p do progress bar, sure. Neither is hard, it's just... you listed 33 options for "pv" above and I'd like to know where the edges of the problem space are before extending much further. (Looks like pv uses -s for estimated size, might as well match that.)
Let's see...
-p and maybe -eI are implied by -s, -trab is default, -l you just requested and I guess -0 goes with that.
But -TA are silly, I'm not doing -F, -nwDiBC are micromanaging, what is -q FOR (don't put it in the pipeline then, cat exists), -wH have environment variables that already do that, -f implies that we care  whether stderr is a terminal which is not currently the case, -E is similarly out of scope, -c is toybox policy, -RPd are just off in la-la land, and -hV have --long versions as part of default toybox plumbing so aren't an individual command's job.
You could make an argument for adding -LS (which would explain -q) but that's not really this command's job? Ratelimiting is usually bidirectional, so it's more a netcat -f thing? Hmmm. I suppose you could make the case that we've got the plumbing so it's cheap for us to do...
So maybe -sl0LSq options. And maybe test that "zcat blah | COLUMNS=47 count" works right, although defaulting to 80 seems pretty reasonable too...
P.S. I usually try to have this kind of discussion on the mailing list. Microsoft github will eventually go the way of all web services and this history will be lost, with no obvious standard export format to migrate the archive elsewhere.

i will subscribe

not needed


Make wielding automatically drop the item on your other hand

About the PR
Fixes #2120
Includes the changes in https://github.com/space-wizards/space-station-14/pull/27975
Media
https://github.com/CM-14/CM-14/assets/10968691/d6877c99-e68a-48a7-91af-9bb76cdefb21

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

tweak: Attempting to dual wield something will now automatically drop the item in your other hand.

This will be closed when upstream is merged

Done in https://github.com/space-wizards/space-station-14/pull/27975


Unique constraint is not validated

Current Behaviour (for problems)

open https://github.com/Stephen-Gates/data-package-examples/blob/master/zip/test-time.zip
validate
unique constraint error not detected

Expected Behaviour

error detected

Your Environment

Data Curator version: 0.7.0
Operating System and version: e.g. macOS High Sierra 10.13.1

@mattRedBox https://github.com/frictionlessdata/tableschema-js/releases/tag/v1.7.0 is out.
Suggest this is now unblocked and can be included in 0.10.0 build?

Fixed with 1.7.0 release
Nice work @roll


Add Building PortMaps to Cable Trace

Hey Guys,
It would be really cool to be able to upload a building map of some sort, with the ability to either drag and drop port locations, or add en-masse to the map/picture and have these locations show up in the Cable Trace section.
We have several buildings with several racks and most have very different port numbering schematics, it would be cool yo have this visualised within the system easily when tracing a cable/device.
Cheers!

This issue has been closed as it does not conform to one of the provided templates as required by the contributing guide. If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).

@jeremystretch Apologies, hopefully the edit above suffices?
Let me know if not!
Cheers!

@watsonnet endpoints can be modelled with the existing device type/devices.

Allow upload of building maps/floorplans of some sort


Deny cleartext network communication (USEID-568)

I'm closing this one as cleartext communication is disabled by default for the API levels that we are targeting.


Remove first read delay

The device currently starts "time" as zero and waits to do the first read until sensorSampleInterval, which is a long wait for the user. Either do a sample during setup(), or advance the initial time to sensorSampleInterval during setup(), so the first read happens in the first iteration of loop(). loop() will then immediately reset time to zero and we've entered the normal device pattern?

Fixed by initializing timeLastSample as -(sensorSampleInterval *1000), which triggers the sample read on the first iteration of loop(). loop() resets timeLastSample to a normal value after the first sample read.


Fix shell socket stuck issue in delopy_cert function. Refer to issue #51

Thanks for the contribution! I made one small tweak to cleanup some duplicate curl arguments than I think might have been accidentally added, but let me know if I missed anything with that change. Otherwise, this has been released in v0.10.5.
I'm a little puzzled as to why this was an issue in your environment (I wasn't entirely clear on how to reproduce in based on #51), but in any case, this seems like a cleaner approach to sending along the file contents with curl anyway, so I like it! I've also verified that the @ syntax for attaching files directly should have been supported since the --data-urlencode option was introduced in curl (v7.18.0), so I don't think this should result in any compatibility differences.


port: Support null for built-in function empty

Fixes #3483
Description
The doc of empty shows that if the input is null, true would be given.
Example:
empty(null)   -> true
empty(undefined)   -> true

Pull Request Test Coverage Report for Build 700094467

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 84.957%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/functionUtils.ts
11
90.29%

Totals

Change from base Build 699656075:
0.06%

Covered Lines:
18883

Relevant Lines:
21167

💛  - Coveralls