Wrong option -EnableRemoting when using Invoke-Command and Enter-AzVM

Hi expert,
When executed using the commands listed in the "Invoke PowerShell script across remote VMs" and "Interactively log on to a remote VM" Sections, the following error was displayed:

Invoke-AzVMCommand : Parameter set cannot be resolved using the specified named parameters. One or more parameters issued cannot be used together or an insufficient number of parameters were provided.

Enter-AzVM : Parameter set cannot be resolved using the specified named parameters. One or more parameters issued cannot be used together or an insufficient number of parameters were provided.
As far as we can see, the option "-EnableRemoting" of each command seems not to be used now.
I expect team to modify it to an executable command.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d429ecd5-657d-35fc-fbe5-d8131c4da484
Version Independent ID: 5b51f1ff-c0b2-4810-7c05-b867a9aa06af
Content: Azure Cloud Shell Quickstart
Content Source: articles/cloud-shell/quickstart-powershell.md
Service: azure
GitHub Login: @maertendMSFT
Microsoft Alias: damaerte

@kogesaka Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@kogesaka Verified and updated the document as required. Thanks.


matrix-hookshot: 4.0.0 -> 4.1.0

Description of changes
https://github.com/matrix-org/matrix-hookshot/releases/tag/4.1.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Deployed and tested on my server.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2289

Can we try adding iconv for darwin? Otherwise please mark it broken.
hookshot/target/release/build/markup5ever-fe48539dfa75bf64/build_script_build-fe48539dfa75bf64" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: ld: library not found for -liconv
          clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

error: could not compile `markup5ever` due to previous error
warning: build failed, waiting for other jobs to finish...
Internal Error: Command failed: cargo build --release --target x86_64-apple-darwin
    at checkExecSyncError (node:child_process:885:11)
    at Object.execSync (node:child_process:957:15)
    at BuildCommand.<anonymous> (/nix/store/afndff0pcbiy12n5gdbp2a098s1a92wa-napi-rs-cli-2.12.0/lib/napi-rs-cli/index.js:27918:26)
    at Generator.next (<anonymous>)
    at /nix/store/afndff0pcbiy12n5gdbp2a098s1a92wa-napi-rs-cli-2.12.0/lib/napi-rs-cli/index.js:3467:71
    at new Promise (<anonymous>)
    at __awaiter$1 (/nix/store/afndff0pcbiy12n5gdbp2a098s1a92wa-napi-rs-cli-2.12.0/lib/napi-rs-cli/index.js:3463:12)
    at BuildCommand.execute (/nix/store/afndff0pcbiy12n5gdbp2a098s1a92wa-napi-rs-cli-2.12.0/lib/napi-rs-cli/index.js:27806:16)
    at BuildCommand.validateAndExecute (/nix/store/afndff0pcbiy12n5gdbp2a098s1a92wa-napi-rs-cli-2.12.0/lib/napi-rs-cli/index.js:1993:37)
error: builder for '/nix/store/ds29q3ahrhhakffzh0wimg4ssyg3ahr8-matrix-hookshot-4.1.0.drv' failed with exit code 1;

The build still seems to fail on ofborg, but maybe I'm doing something wrong? Unfortunately I don't have a mac to test it on.

The change looks correct to me, so lets just mark it broken and let someone with a mac deal with this.


Large dataset numpy arrays solution - store batches on hard drive?

I have tried to load big matrices into numpy arrays and then to call the dataset creation routines. However, very large data can pose memory issues for numpy. Usually we need lots of data for deep learning and this data cannot be kept all in memory.
It would be nice to have the batches stored on hard drive in different parts, and loading these parts into memory at training one by one, rather than the full dataset. Maybe I can try to implement something like this. In this case should the train function should be modified or what is the best way?

Have you tried using a callable for your datasets? Maybe something like this, which chooses a random dataset and a random offset for each batch:
SOURCES = 'foo.npy', 'bar.npy', 'baz.npy'
BATCH_SIZE = 64
def batch():
X = np.load(np.random.choice(SOURCES), mmap_mode='r')
i = np.random.randint(len(X))
return X[i:i+BATCH_SIZE]
exp.train(batch)
You can do anything inside this callable, including loading up arrays from disk, as long as it takes no arguments and returns a numpy array with the correct shape.

If you need more sophistication from your callables, you can also encapsulate them inside a class, just make sure instances of the class are callable by defining the __call__ method:
class LargeDataset:
    def __init__(sources=('foo.npy', 'bar.npy', 'baz.npy'), batch_size=64):
        self.sources = sources
        self.batch_size = batch_size
        self.src = -1
        self.idx = 0
        self.X = ()

    def __call__(self):
        if self.idx + self.batch_size > len(self.X):
            self.idx = 0
            self.src = (self.src + 1) % len(self.sources)
            self.X = np.load(self.sources[self.src], mmap_mode='r')
        try:
            return self.X[self.idx:self.idx+self.batch_size]
        finally:
            self.idx += self.batch_size

I haven't tested this but it should be close.

thanks! I haven't tried with callables at all until now. I was using the dataset class for some arrays. I will give it a try!

have you tried http://docs.scipy.org/doc/numpy/reference/generated/numpy.memmap.html#numpy.memmap? but i'm pretty sure that writing your own callable would be more efficient.

+1 -- memmap is pretty great. It can run into issues with multiple processes, but mostly it's a good idea.

I would like to train the network with all possible arrays(foo,baz,bar) ,with the following constrains

Only one dataset is loaded at a time (to save RAM /memory related issues)
i
The weights learnt after loading foo.npy and training on 'foo.npy' is the starting point when 'baz.npy' is called upon .

###########################################
exp=theanets.Experiment(theanets.Autoencoder,layers=(x,x/2,x/4,x),tied_weights=True)
Sources='foo.npy', 'bar.npy', 'baz.npy'
for i in range(len(Sources)):
training_batch=np.load(Sources[i],mmap_mode='r')
exp.train(training_batch)
########################################

Yes, that looks fine.


CS-43546: Update in import command

version bump: @contentstack/cli-cm-import
1.13.0 -> 1.13.1

Updated the global field to remove the references from RTE (Advanced and custom).
After the creation of content types add the create-extension so that the extensions which depend on content types are created

Removed the extension from extensions which depend on the content type.
Then once the content types are created then taking all the content types.
If the title of the content type on which the extension is depending is there then adding the to the list of extensions that needed to be created.
Creating the extension then and updating the mapper file

Closing the PR as the fixes were added as a part of another ticket


Cuda refactor

Currently, the code in VideoDecoder.cpp has a lot of #ifdef ENABLE_CUDA directly in functions. This refactor applies the following principles:

The logic in VideoDecoder.cpp should not need #ifdef ENABLE_CUDA inside of it.
CUDA code should be localized to explicit CUDA source files.
We should limit the entry points from generic code into CUDA code through an explicit API. Functions in this API will throw an exception if called from generic code that was not compiled with CUDA support.

Note: this was originally #193, but I abandoned that because #196 temporarily moved GPU support into a feature branch.

I like the change to the NVTX macro. Even the other code changes are fine, but I don't see what problem is solved by moving the code to a new set of files. That makes reading the code harder because cmd+f doesn't work and you have to do a search to find it. It may also create merge conflicts when we make other changes to the VideoDecoder.cpp file when we are merging this branch back into the main branch. My vote is to avoid tons of code movement on this branch to keep it mergable into the main branch. We can revisit this once this branch is merged back to main.
In other words I don't agree with principle (1) and (2).
Principle (3) I agree with but then the API should be a generic one. I suspect eventually we will land on an API like:

an API to decode to an AVFrame
an API to color convert from AVFrame to whatever output destination

(2) could then be a trampoline function to do cuda conversion if needed.
This type of API was done by me in an internal diff to improve performance for batch decoding because currently we are doing inefficient copies because we entangle the creation of the output tensor to color conversion. By decoupling memory allocation, decoding and color conversion we can reduce the decode time by half for some frames.
Lastly, Fbcode uses buck TARGETS files that would also need to be updated with this change, but we can worry about those later.

@ahmadsharif1, I think you make a good point that we should avoid changes on this branch until we're ready to merge into main. I also think whatever we do to refactor the organization of CUDA code should follow the APIs you proposed - we should wait until we have those APIs.
On how to avoid the ifdefs: I think we can do that by pushing the decision up to compilation and linking. We create libraries that always include CUDA and always don't include CUDA. We decide which libraries to link against at build time. We wouldn't have a trampoline, but we would need a clear API to implement.
Closing, and we'll revisit when we can follow those APIs and we're already working on main.


The Scheduled Tasks Event reader needs to add attributes for real int, hex int, and what the exit code really was

if you exit -1, the action completed event will show a result code of<PHONE_NUMBER> in history, as EventData\ResultCode of<PHONE_NUMBER>, as "(0xFFFFFF00) in the main view column "Last Run Result".
All these are great, but I want the exit code.  See? Then I can look in my code where I exited that code!  It's like, magic!
Positive integers 0,1,2 etc come back pretty good.
Custom exit codes don't get a message string.

Make the test loop through and see where the break from match to unmatch is.


Update Composer dependencies (2021-10-20-00-12)

Visual regression test passed!
View the visual regression test report


Deploy "Let's Fly" to the PROD Curious Reader Container app

User Story
As a Product Owner,
I want to add a second app, "Let's Fly" (in English), into the production Curious Reader container app WITHOUT having to update the Curious Reader container app in the Play Store,
So that users of the Curious Reader app have multiple pieces of content that they can use, we test being able to update the Curious Reader container app with new content remotely, and that we can use multiple apps' content for advertising download of the Curious Reader container app on social media.

We missed our window for using English as a test bed and going straight into the languages we want in production (Hindi, Nepali, Zulu, Luganda, and Ukrainian) instead.


How do I run this with my own data and just infer?

Hey all,
I see that you have a custom dataloader for the solution, but I was curious how to use this network on my own data. For example, say I have a PCD which is already incomplete, I do not have the ground truth for this. I just want to run inference on this data. How would be the best way to progress using this network? Any help on this would be very much appreciated. Thank you for the contribution !!

The scenario described bears similarity to the KITTI dataset, where GT data for the completed shape of cars is not available. To address this limitation, we utilize the ShapeNet cars dataset for training purposes. You can also employ a similar approach with your own dataset by following these instructions.

Hey, thanks for the update. I was more curious on how to use this repository to just test with my data. Because I think the pretrained ones should be good enough for my data. My expected way of work would then be to just input my incomplete pointcloud and  just get the result from the network as output pointclouds. Is that something that is included anywhere in the code ?

I did not provide a specific script for your use case.
However, you can prepare your data by following the same format as the KITTI dataset and utilize the KITTI dataloader for compatibility and ease of use.
This approach will allow you to effectively handle your data in a manner similar to the KITTI dataset.


test: Added Test for ShadowContainer re-layout issue

GitHub Issue (If applicable): #

Closes #791
PR Type
What kind of change does this PR introduce?

Other... Please describe: Test

What is the current behavior?
There is no test for that

What is the new behavior?
Added a new test

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Tested the changes where applicable:

[ ] UWP
[x] WinUI
[x] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[ ] Controls Doc Update
[ ] Extensions Doc Update
[ ] controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[x] Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[x] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal)
[x] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

@Mergifyio backport legacy/3x release/stable/3.1


Feature request: CLI client for cadence

In some of the issues I see on the uber/cadence repo I've noticed a cadence-cli being mentioned.  Is that open sourced?
If not, that would be a really handy tool.

Yes we do have have a cli internally for cadence, but unfortunately it is not open sourced yet.  We have plans to open source the cli but just haven't found the time yet.  Let's keep this issue open until the cli is open sourced.

This has been done.  See https://github.com/uber/cadence/tree/master/tools/cli.
I've also created a docker image of it on docker hub: https://hub.docker.com/r/ryanwalls/cadence/


C26453: escaping URL to display it as text

Hello, @MikeWasson  ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
"Example URL at line 24 is displayed as a link, it must be escaped in order to be displayed as text"
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.

Thanks @guardrex ,


atspi: Add default path and service name to SocketProxy

It took me ages to figure out why my test app was no longer being registered by the AT-SPI registry since I switched to the atspi crate. I forgot that I had set the default_path and default_service attributes on my SocketProxy implementation. So I would suggest to add these back here too.
I am aware that Socket can also be implemented by providers, but I think it makes sense to have it pointing towards the registry by default. You aren't supposed to know where it is located (it's not documented anywhere afterall) unless you're an AT-SPI nerd!

Thanks so much!


Add Pulsar generator

Nice to see this contribution, thanks a lot @cbornet
Don't hesitate to ping me if you need help

I fixed the CI issues. Ready for review.

Thanks a lot @cbornet : will review it soon :)

@pascalgrimaud I've done the changes and fixed the docker-compose file


feat: added home page to playground

What this PR does:
@nank1ro On a high level this PR adds a basic showcase of the shadcn widgets by using the routes as a way to identify all the shadcn widgets that the repo contains. This ensures that when adding new routes they will automatically appear on the home page. Pls feel free to add any feedback or close this if not needed!

Adds a new file that contains the list of routes
Adds a new home page which lists the routes in a grid view and navigates to a route on tap
Adds HomePage as the root

Isn't this what the "example" does already?
The playground is used by the docs to showcase specific components with specific styles. While the example shows all the components with navigation and customizations from the right side.
Can you explain the use case you imagined? Where would you show it?

Ahh no use case specifically. I just launched the playground and found it odd that I landed on a 404 page, did not know it was specifically designed to be this way. Feel free to close this then thank you!


Getting error with python 3.5.4

When i use final command : i.e. pip install -e D:/pyt
Then i am facing the problem. Please let me know where i am doing wrong.
c:\users\xyz\appdata\local\programs\python\python35\include\pyconfig.h(243): fatal error C1083: Cannot open include file: 'basetsd.h': No such file or directory
error: command 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe' failed with exit status 2

$ python bootstrap.py
Traceback (most recent call last):
File "bootstrap.py", line 1, in
from neo.Settings import settings
File "D:\pyt\neo\Settings.py", line 14, in
import logzero
ImportError: No module named 'logzero'

This means you haven't installed the requirements.txt or your virtual environment has not been activated.

Sorry if i am in the wrong place, but can someone help me with this issue.
I have an error when i add this on my python code and try to build:
from neocore.Cryptography.Crypto import Crypto
BUT
from boa.interop.Neo.Runtime import CheckWitness
from boa.interop.Neo.Storage import GetContext, Put, Delete, Get
from boa.builtins import concat
Only those 3 lines, building just fine.
How can i add the module neocore in my python code?
I already installed all the requirements on neo-python, i can see the neocore folder in the venv.
Thanks!

You can't import normal python modules in smart contracts.

So the normal python modules can only for script outside the smart contract?
Smart contract itself can only in boa?
Thank you, (i am in learning stage now)

Yes, exactly. Orient yourself on the boa examples for what you can do in smart contracts: https://github.com/CityOfZion/neo-boa/tree/master/boa_test/example

Thank you very much!


add(test): Check that scan task removes keys, unify scan task acceptance tests, and add test to CI

Motivation
We want to check that the scan task removes keys after receiving RemoveKeys messages.
Closes #8286
Closes #8274
Closes #8259
PR Author Checklist
Check before marking the PR as ready for review:

[x] Will the PR name make sense to users?
[x] Does the PR have a priority label?
[x] Have you added or updated tests?
[x] Is the documentation up to date?

For significant changes:

[x] Is there a summary in the CHANGELOG?
[x] Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.
Solution

Deletes the scans_for_new_key test now
Renames scan_subscribe_results test to scan_task_commands
Calls scan_task.remove_keys() from scan_task_commands test
Waits for the scan task to drop the results sender, then:

Empties the results channel
Asserts that the first error is a Disconnected error

Related Cleanups:

Updates remove_keys() to accept a Vec instead of a slice.

Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:

[ ] Does the PR scope match the ticket?
[ ] Are there enough tests to make sure it works? Do the tests cover the PR motivation?
[ ] Are all the PR blockers dealt with?
PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Thank you @gustavovalverde for finding the issue!


Add a fallback for redirects to the app

This issue is imported from pivotal
In several cases, email-links aren\'t opend in the defailt browser, and redirecting to the app using a ```https://....eduid.nl/...``` url won\'t work.

When the /client/mobile/... redirects are opened in a browser (instead of the app), a 404 is displayed.
Instead, we should display a button Open in app containing a href to eduid:///client/mobile/... to force it to open in the app.
All the links in the emails that are send on request of the mobile client need to to go to the eduID web app, displaying a button with a redirect to the mobile app. See the tasks for an overview.

https://github.com/OpenConext/OpenConext-myconext/commit/4328dced4009d8caebb751e656ecd1844faa6c90 (Okke Harsta - Mar 10, 2023)

https://github.com/OpenConext/OpenConext-myconext/commit/b945b5676b8011e68910354483e8a8d1d9219ae4 (Okke Harsta - Mar 13, 2023)


CircleCI deploy to dev.peerpad.net failing ...

@olizilla: I merged #294 to master to see if it would deploy to dev.peerpad.net.
https://circleci.com/gh/ipfs-shipyard/peer-pad/310
It appears to have failed when it tried to configure the DNS:
error: did not find account for: dev.peerpad.net

needs to update the dev record in the peerpad.net zone

I modified the deploy script here:
https://github.com/ipfs-shipyard/peer-pad/commit/47d29e451ded0be30b59e69bfd326a2ed933ed7b
It appears to have been successful:
https://circleci.com/gh/ipfs-shipyard/peer-pad/312
$ dig +short _dnslink.dev.peerpad.nettxt
"dnslink=/ipfs/QmeWR3gKDGoSn2QyCWiT4d2N8UHzAEECqzViq1jZ6P8a6U"

However, the page isn't loading for me.
https://dev.peerpad.net/
I wonder if the 'A' record for dev.peerpad.net is pointing to the correct place?
$ dig +short dev.peerpad.net
<IP_ADDRESS>

I think everything is correct ... I think the gateway is just loading terribly slowly:
https://dev.peerpad.net/

thats somewhat good. At least peerpad can auto deploy once more.

everything is looking good to me right now, closing this


Some server needs explicit event or task when doing search

DAViCal seems not to yield results at all if doing a query that includes search filters but does not specify if we want events, tasks or journals.
calendar.mail.ru will yield a 400 Bad Request-error when doing a query that does not specify if we want events or tasks (or journals), including the query "give me everything on the calendar" and "give me the object with the specified UID".

The test framework already supports DAViCal, and there is a hack in the object_by_uid-method to support DAViCal, but the behaviour from calendar.mail.ru is not very well supported.
Tasks:

The object_by_uid-method  already has some fallback functionality when nothing is found (supporting for DAViCal), make sure the same fallback functionality works when 400 Bad Request is returned from the calendar server
I have for a long time had in mind that the user could give hints on what server one is connecting to when creating the client object.  The idea is that the library can apply various workarounds dependent on the calendar server.  In this case it would mean always passing the "event"-flag when doing searches on calendar.mail.ru, and to do separate searches for events and tasks on DAViCal and combine the results.
The idea above should probably wait until after 1.3.10 has been released.  In the meanwhile the test libary should be hacked up so that it works towards calendar.mail.ru

For calendar.mail.ru, calendar.objects() will just throw a NotFoundError, even if  calendar.events() yields results.
I'll work around it with a compatibility hook in the test code, but the proper solution depends on #402


Remove or rename prepublish hook

Hi there,
currently coffee-coverage uses prepublish as script hook. Unfortunately this isn't only run pre publish, as the name suggests, but also after npm install. This slows down build processes including coffee-coverage unnecessarily.
It would be great if you could use a different hook or use something like in-publish to ensure it doesn't run during npm install.
Best,
Daniel

I've read about in-publish before, but I don't get it.  :P  Why is it a problem to run the prepublish hook when you npm install from the coffee-coverage project?  It doesn't get run when someone else does an npm install coffee-coverage, so it only affects you if you're developing on coffee-coverage, no?

Actually I always thought it is also run when npm installing it as a dependency, but you're right :D


Not working on localhost.

I used minimal documentation code
const advancedMatching = {}; // optional, more info: https://developers.facebook.com/docs/facebook-pixel/advanced/advanced-matching
const options = {
  autoConfig: true, // set pixel's autoConfig. More info: https://developers.facebook.com/docs/facebook-pixel/advanced/
  debug: false, // enable logs
};
ReactPixel.init('FACEBOOKPIXELID', advancedMatching, options);

ReactPixel.pageView();
ReactPixel.revokeConsent();

and granting consent on button click
        <button onClick={ReactPixel.grantConsent}>
          Accept cookies
        </button>

but my request is being blocked
request
request expanded
am i supposed to run localhost using ssl with ngrok with ?

it is not issue with this library but with browsers policy, by default browsers don't allow https requests from website running on http, since localhost was on http so that was causing the issue to make it work on local host please follow this
https://stackoverflow.com/questions/3102819/disable-same-origin-policy-in-chrome

it is not issue with this library but with browsers policy, by default browsers don't allow https requests from website running on http, since localhost was on http so that was causing the issue to make it work on local host please follow this
https://stackoverflow.com/questions/3102819/disable-same-origin-policy-in-chrome


Disable ThreadIdsInJstopinfoTest as the stable version is flakey

This test has been failing about 50% of the time since we turned the unit tests back on.
The test and its related infrastructure have changed significantly on TOT, so it's not worth working on this version of the test.

@swift-ci please test

Fine, but please open a rdar:// as this needs to be reenabled once we rebase.

@dcci Not sure what you mean by that.  I'm only disabling this on stable.  If we rebase from stable we still won't want to work on this test because it is a very out-of-date version.  If we rebase from upstream-with-swift, we'll get the new version which isn't disabled.

@jimingham I mean when we merge from upstream-from-swift we need to make sure we resolve the conflict correctly (i.e. we re-introduce this test).
BTW, I'm afraid this is not the correct way of disabling this test.
In CMake, if you have a file in a directory but that's not tracked, the build system will complain (presumably this will happen here as well).

@swift-ci please test

ehm, not sure about commenting the whole test either. This is going to cause a lot of pain when we want to resolve merge conflicts. If you want to go for this, maybe #if 0 the whole block?
Also, can you please squash your commits? Otherwise the history will become terribly messy. Thanks.

The tests didn't start so I guess you're still good to make these changes I suggested.

I think you just changed text indentation. Please undo that, and while you're there, squash. It's not great that there are 5 commits in the history for disabling a test.

Sorry, s/you changed text indentation/you still have commented code/

You are right about that, how annoying.  I don't want to delete the file.  But #if 0 is nicer, I'll try that.
I still don't understand your point about upstream-with-swift.  I'm only disabling this on stable.  I don't remember if we still have an automerger from stable->upstream-with-swift, but if we do it's going to horribly mangle this test anyway, and we'll just have to put the  UWS version back in place.  Otherwise the change will just sit on stable.  There's no intention of disabling this on UWS, at least not until we determine that the revised version of the test is still flakey.

@swift-ci please merge

OK, fine re upstream-with-swift. Thanks for making these changes. Please squash your commits and then this is good to go for me.

If you're unfamiliar with the practice, GitHub has an excellent article on the topic.
https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
This keeps the whole repo in a much better state (and also makes archeology much easier :)
Thanks for taking the time for doing this.

@swift-ci please test

@jimingham, here's how to squash these commits and update the PR:
$ git fetch origin
$ git rebase -i origin/stable
$ git push -f jimingham stable

@swift-ci please test

This seems to pass. Can you please unclutter the history rebasing/squashing (look at the previous comment) & commit this?

Well, that didn't work.  I'll try again with another test branch.


Fix typos and grammatical error

I corrected some typos and grammatical error

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   54.31%   54.31%
=======================================
  Files          42       42
  Lines        1598     1598
=======================================
  Hits          868      868
  Misses        668      668
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27e4e3...771f7ee. Read the comment docs.


yaml: imported fields treated as type none

Component:

VSCode Extension

Extension version: v0.13.0
LSP version:
OS version and name: Windows 11

I am on the latest stable version of the extension/LSP.
I have searched the issues of this repo and believe that this is not a duplicate.

Issue
When a YAML file is imported and passed to a method, the receiving method treats the passed data as type none.
main.typ:
#let print_name(content) = [
  #for item in content [
    #item.name
  ]
]

#print_name(
  yaml("data.yaml")
)

data.yaml:
- name: Alice
- name: Bob

VSCode will report this error despite compilation preview being successful:

I figured that this is caused due to lack of null-checking for the passed-in variables. Adding checks like this in the function resolves the issue:
#if content != none {
 ...
}

However I think the current message is not intuitive, maybe it can be replaced with something like 'content' may be of type none?


Implement proposed SA1028: NoTrailingWhitespace

This includes the analyzer, the code fix provider, and the tests.
Of notable mention is that IIRC the original StyleCop did not notice trailing whitespace at the end of a single line or multi-line comment. I took some extra trouble to fill that gap. I believe this will find all trailing whitespace. Although we often want to emulate legacy StyleCop behavior, I believe this is simply filling a bug in the original and I expect especially given the auto fix provider that folks can quickly upgrade their code if necessary when applying this rule.
Fix #729

:+1: Looks good. I've made a few remarks (mostly performance related)

We should definitely profile this one to see if there may be performance issues. Its scanning a lot of items each time the syntax tree is modified.

@AArnott Should this rule also cover trailing whitespace after conditional directives (like #if (Debug) )?
I couldn't find any evidence that it does.

Good catch on the condition directives. I'm working on adding that now.

I'm hesitant to enable this by default prior to seeing it in action under the profiler, but I do want to get it included. Can you make sure the following items are clearly addressed in the documentation for the rule? For each case, please indicate whether or not the analyzer checks for trailing whitespace in this location, and also whether or not the code fix removes trailing whitespace in this location.

:question: What is the behavior of the rule in disabled code (e.g. between #if false and #endif)?
:question: What is the behavior of the rule within line comments?
:question: What is the behavior of the rule within documentation comments?
:question: What is the behavior of the rule within verbatim string literals?

@sharwell I'm pleased to say that all your questions are already answered by tests I've written, with the exception of the first one (condition directives) which I'm adding now. But the answers so far, and planned for the first one, is that the analyzer is active in all those contexts. And I can certainly run a perf trace on a project with this turned on to see how much time it adds.

I'm really hoping the IDE will delay evaluation of this rule long enough that it's not constantly appearing at the caret location while typing code...

Good point, @sharwell. I wonder if there's a way to detect when there is an incomplete statement and skip it. No point in reporting trailing whitespace when the line itself is incomplete or wrong in some other way.

We could check if the CompilationUnitSyntax's ContainsDiagnostics property is true, but that would cause all diagnostics in the file to disappear mid-statement while typing. It also doesn't cover typing in comments.
Best thing right now would probably be to experiment with it and see if it is annoying.

Aside: As usual, any time I'm using VS 2015, I find a bug. This time I found a gross memory leak. Just in working with StyleCopAnalyzers, devenv.exe is taking 1.2GB of RAM. Time to file another bug.

I've tested the performance of SA1028 and it's hard to even get it to show up on traces. And when it does, it's very small. So I think we're OK here. This doesn't surprise me because I was careful to avoid allocations or expensive work as much as possible.
I also tried the experience of simply typing code while this rule was turned on. It doesn't look like it pops up while I'm typing much. I can find it if I pause and look through the error list but otherwise it wasn't noticeable. I recommend we merge this.


DeviceCodeCredential() error: "need admin approval"

azure-identity==1.2.0
azure-keyvault-secrets==4.0.1
Windows 10
python 3.6.10
My command line app can successfully use InteractiveBrowserCredential() to get credentials for the user when the OS has a browser, but for SSH connections, we need a solution like DeviceCodeCredential().  For some reason, DeviceCodeCredential requires a client id, and is difficult to find the right configuration to make it work.  Why can't it be as easy as InteractiveBrowserCredential() to use, but just provide an alternative UI?
Anyway, I created an app with AAD, gave it permission to access the Azure Key Vault (user impersonation).  Using the client id of this app (is that the client id I am supposed to use??), it prompts the user to sign in, give permission to the app, and then issues the error "Need Admin Approval".  Huh?
I'm not sure if its asking referring to the admin for the app (which is me, I think), the admin for my service subscription (which is me, I think), or possible an admin for my company (Microsoft) for all Azure accounts.  If its is not me, I have no idea how to find this admin person.  And should that even be necessary?  All of this is not needed for the InteractiveBrowserCredential() API.
BTW, when I added the API permission to access the Key Vault to my app, it said that Admin Approval was not required.
I must be missing something - can anyone provide some guidance here?  Thanks in advance.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi @rfernand2, Here is a sample of DeviceCodeCredential.
For the value of the parameter cliend_id in DeviceCodeCredential, you should use AZURE_CLI_CLIENT_ID directly in the azure/identity/_constants.py file.
Sample code snippet:
from azure.identity import DeviceCodeCredential
from azure.identity._constants import AZURE_CLI_CLIENT_ID
from azure.keyvault.secrets import SecretClient

credential = DeviceCodeCredential(AZURE_CLI_CLIENT_ID)
client = SecretClient(VAULT_URL, credential)
secret = client.set_secret("secret", "the test passed")
assert secret.value == "the test passed"

Please feel free to reach us with more detailed information if the error still persists by using the sample.
@jongio

Hi @v-xuto, thanks for the code sample.  I love the simplicity - who knew there was an AZURE_CLI_CLIENT_ID?!  Any way, I just pasted in my Vault URL and tried it.  I get the following error:

(exper) c:\github\ExperimentTools\cmdlineTest>python azure_device_code_test.py
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code BFNHY86BX to authenticate.
Traceback (most recent call last):
File "azure_device_code_test.py", line 9, in
secret = client.set_secret("secret", "the test passed")
File "c:\anaconda3\envs\exper\lib\site-packages\azure\core\tracing\decorator.py", line 71, in wrapper_use_tracer
return func(*args, **kwargs)
File "c:\anaconda3\envs\exper\lib\site-packages\azure\keyvault\secrets_client.py", line 117, in set_secret
**kwargs
File "c:\anaconda3\envs\exper\lib\site-packages\azure\keyvault\secrets_shared_generated\v7_0\operations_key_vault_client_operations.py", line 1434, in set_secret
map_error(status_code=response.status_code, response=response, error_map=error_map)
File "c:\anaconda3\envs\exper\lib\site-packages\azure\core\exceptions.py", line 83, in map_error
raise error
azure.core.exceptions.HttpResponseError: (Forbidden) Access denied to first party service.
Caller: name=from-infra;tid=f8cdef31-a31e-4b4a-93e4-5f571e91255a;appid=04b07795-8ddb-461a-bbee-02f9e1bf7b46;iss=https://sts.windows.net/f8cdef31-a31e-4b4a-93e4-5f571e91255a/
Vault: xtsandboxvault;location=eastus

Maybe I am using a different version than you?  My info:

azure-identity==1.2.0
azure-keyvault-secrets==4.0.1
Windows 10
python 3.6.10

Hi @rfernand2,
When you run azure_device_code_test.py file, you need according to the following instructions on the browser to open the link https://microsoft.com/devicelogin, then enter the corresponding code (such as BFNHY86BX) for authentication. I wonder if you have done so?
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code BFNHY86BX to authenticate.

Yes, for the above test, I was running on my home computer (tried it multiple times).  The web page gave me the response "You have signed in to the Microsoft Azure Cross-platform Command Line Interface application on your device. You may now close this window.".
However, I just ran the same test at work, and... it worked!  Same confirmation message from the browser but without the stack trace, and I verified that I can now read and write secrets to the vault.  This was on Windows; I also verified its works from my Linux machine.  This is awesome.
Before we close this issue, let me try again from my home PC.  Any reason why it wouldn't work there?

Also, can you direct me to any documentation you have on AZURE_CLI_CLIENT_ID?  I can't seem to find much about it searching the web.  I am trying to figure out if there are condition under which it won't work.  Thanks...

I'm not sure if its asking referring to the admin for the app (which is me, I think), the admin for my service subscription (which is me, I think), or possible an admin for my company (Microsoft)

It's the third one, an admin for your Azure AD tenant needs to grant the permission to your application.

Before we close this issue, let me try again from my home PC. Any reason why it wouldn't work there?

Unless you use a VPN (or live at the office), you're on a different network at home. Your Key Vault may have network access restrictions (docs).

Also, can you direct me to any documentation you have on AZURE_CLI_CLIENT_ID?  I am trying to figure out if there are any conditions under which it won't work

It's undocumented. The _constants module is internal and changes without warning; this constant in particular will be removed in a future release. The best practice is to have your application registered with Azure AD, with the permissions it requires.

Thanks for opening this issue, please open another if you encounter further problems. I'm closing this issue because the mentioned problems are due to Azure AD and Key Vault configuration, and can't be resolved by the SDK.


[wait for #1295] [graph] Support creating RunLayerContext

Implement the function to create RunLayerContext given the
InitLayerContext and update it in the given LayerNode.
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1296. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @kparichay, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1296-202106171015580.23473000526428-849cad1db018dad8ee4639f19a0813696e338afa/.


invisible animated or interactive blocks

Mod Name
Optifine / Rubidium / Embeddium / Embeddium++
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

[X] I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version
1.20.1
Mod Loader
Forge
Issue description
I am using the Eureka Ships mod and I noticed this error caused by optimizer mods such as (Optifine, Rubidium, Embeddium and Embeddium++)
Any Block that has animation or is interactive becomes invisible if it is part of a ship created by (Eureka mod)
I have seen videos of other players who do not have this problem with animated blocks and I do not understand how it happens to me when using any of the mentioned ones (performance mods)
Is there a way to fix this and keep the animations?
The eureka mod works normally without any other mod but when any of the others is installed this happens and playing without an optimizer causes a drop in FPS
I am a Forge user
Screenshot:

Issue reproduction
Simply install the Eureka mod and its requirements (all updated) and combine it with Embeddium or any optimizer (any version).
forge version: 47.2.0 for 1.20.1
I have both the requirements and the mod updated
Logs
latest.log

Update embeddium to latest, disable any type of distance based culling in embedium+ settings


Initialize unit tests

As title, I think it will be good to initial unit tests for this repository.
If possible, I also prefer using PHPUnit to accomplish this issue.

Feel free to create those and send a pull request


Difficulties in implementation

I tried to implement this gem on an existing project, already followed all the steps listed in the readme, installing solidus_social and generated the app and credentials on amazon. Seems the option to checkout through amazon is not displayed, not even the sign-up with the social auth.  Already tried with a fresh install of solidus.
Do you have any idea what I'm missing?

Hey there, please make sure of the following:

That you have setup the Amazon Gateway and that it is active
That you have [data-hook='cart_buttons'] within the markup for your cart page as the gem uses deface to add the amazon checkout button.

If you have to customize your cart page and don't want to add [data-hook="cart-buttons"] to the markup I'd suggest you take a look at the override here so you manually render the appropriate partial

Thanks, that was the solution, I really appreciate your help.

Sorry for bothering you again, but now I'm stucked with a new error on confirm page:

that makes me think that the state is not declared, I am right?


Adding Sigmoid Asymmetric Loss to TFA losses

Describe the feature and the current behavior/state.
The paper's abstract:
In a typical multi-label setting, a picture contains on average few positive labels, and many negative ones. This positive-negative imbalance dominates the optimization process, and can lead to under-emphasizing gradients from positive labels during training, resulting in poor accuracy. In this paper, we introduce a novel asymmetric loss (”ASL”), which operates differently on positive and negative samples. The loss enables to dynamically down-weights and hard-thresholds easy negative samples, while also discarding possibly mislabeled samples. We demonstrate how ASL can balance the probabilities of different samples, and how this balancing is translated to better mAP scores. With ASL, we reach state-of-the-art results on multiple popular multi-label datasets: MS-COCO, Pascal-VOC, NUS-WIDE and Open Images. We also demonstrate ASL applicability for other tasks, such as single-label classification and object detection. ASL is effective, easy to implement, and does not increase the training time or complexity. Implementation is available at: https://github.com/Alibaba-MIIL/ASL.
Relevant information
Are you willing to contribute it (yes/no): yes
Are you willing to maintain it going forward? (yes/no): yes
Is there a relevant academic paper? (if so, where): yes, https://arxiv.org/pdf/2009.14119.pdf
Is there already an implementation in another framework? (if so, where): yes
In Pytorch (original):
https://github.com/Alibaba-MIIL/ASL/tree/main/src/loss_functions
Implementation in tf.keras.loss:
https://github.com/dongyups/asymmetric-loss-tf2-keras/blob/main/test.ipynb
Was it part of tf.contrib? (if so, where): No
Which API type would this fall under (layer, metric, optimizer, etc.)
Loss
Who will benefit with this feature?
People who want to try out loss for their multi-label classification tasks.

As it was mainly applied to vision tasks can you open a ticket in https://github.com/keras-team/keras-cv to check if they are interested?

Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Minimize

Hi!
When i try to minimize i get the program laying down at the windows search as a bar (At_Minimize).

Then i do maximize again and form shows but it is all black without visible controls, i need to press the icon at the taskbar to get the controls back.
(I use cuiFormRounder and cuiFormDrag)
I use Windows 10, updated Visual studio 2022 and net8.0-windows
It also seems like i get an exception when i exit program in debug, that is followed with an an error message when i press continue on the exception.

First text in exception:
Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at CuoreUI.Components.cuiFormRounder.TargetForm_VisibleChanged(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnVisibleChanged(EventArgs e)
at System.Windows.Forms.Form.OnVisibleChanged(EventArgs e)
at System.Windows.Forms.Control.OnVisibleChanged(EventArgs e)
at System.Windows.Forms.Control.OnVisibleChanged(EventArgs e)
at System.Windows.Forms.Control.OnVisibleChanged(EventArgs e)
at System.Windows.Forms.Control.WndProc(Message& m)
at Microsoft.DotNet.DesignTools.Frame.DesignerWindowFrame.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)
Thanx
Torbjørn

i'll look into it soon

i seem to have fixed the bug, coming in next release soon

Super, ty for your time!


Uploading broken files to Amazon S3

I'm using mongoid along with carrierwave to upload files using JSON API. My controller method looks like this-
def create
    content = Content.new(content_params)
    content.user_id = current_user.id
    content.asset_type = content.asset.file.extension
    if content.save
      render json: content, status: 201, location: [:api, content]
      ProcessAsset.perform_async(content.id.to_s) unless content.asset_type != 'pdf'
    else
      render json: { errors: content.errors }, status: 422
    end
end

Model
class Content

  include Mongoid::Document
  include Mongoid::Timestamps

  before_create :set_base_price

  mount_base64_uploader :asset, AssetUploader
  # more code
end

While the whole process works great, the file uploaded to S3 (pdf in this case) has no content in it.
I believe this has something to do with StringIO being used to read the file from the system. It sets the content_type to plain/text. This is confirmed when I download the pdf and try to open it on my system.
Here's my json I'm using to upload -
{
"content": {
"campus" : "569df3c4be84c511c0000001",
"course" : "569dfe1cbe84c511c0000006",
"subject" : "56a0c4debe84c50d2f000006",
"batch" : "2015",
"title" : "RipAndSave",
"asset": "data:application/pdf;base64,L2hvbWUvbW9qby9Eb3dubG9hZHMvc2FtcGxlLnBkZg=="
}
}
I'm using Rails 4.2, Mongoid 5.1
Can you help?

@lebedev-yury Have you been able to take a look at this yet?

Hi! You are experiencing the problem only with pdf file uploads, or with other file types too?

It's the same for images too. The content type saved is text/html
On 7 May 2016 23:39, "Yury Lebedev"<EMAIL_ADDRESS>wrote:

Hi! You are experiencing the problem only with pdf file uploads, or with
other file types too?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/lebedev-yury/carrierwave-base64/issues/31#issuecomment-217656855

You mean that when you open the url to the uploaded file, it shows the file as plain in the browser? If yes, this might be a problem with incorrect content-disposition, set in your amazon s3

Hey Yuri,
I'm publishing a sample repository for the above error. The storage, both file system and remote (S3) set the content type to text/plain. You can fork the repository to test it. Also, I don't set content-disposition anywhere.
https://github.com/Mohakjuneja/Base64upload

The base64 string when decoded is the absolute path to the original file on local machine.

I think you misunderstand the concept of base64 encoded uploads. How do you think your web application would get the file contents from your local machine, by just having the address?
Base64 string should contain the contents of the file, that you want to upload, encoded in base64 string

Hi Yuri,
I apologise. I figured it myself just a few hours after writing to you. I'm
sorry about the trouble. I was fixated on it for over a week when I wrote
to you. Thank you for taking out time to see it!
On 18 Jul 2016 12:33, "Yury Lebedev"<EMAIL_ADDRESS>wrote:

The base64 string when decoded is the absolute path to the original file
on local machine.
I think you misunderstand the concept of base64 encoded uploads. How do
you think your web application would get the file contents from your local
machine, by just having the address?
Base64 string should contain the contents of the file, that you want to
upload, encoded in base64 string
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lebedev-yury/carrierwave-base64/issues/31#issuecomment-233249169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFBQvvn_I2ZxdJJb0hD8UBw6LAS5GP0Tks5qWyVUgaJpZM4IBgGb
.

Hi @lebedev-yury ,
I'm trying to upload multiple files(20), with an average size of 700 KB using careerwave-base64 but my request times out. Is it suitable to upload them with this approach?


Tabs in generated migrations

Today I noticed, that when one generates migrations via the command (php artisan module:migration create_example_table for example), there are tabs in it (instead of spaces).
When generating models there are spaces in it (as far as I noticed). So I'd appreciate if this could be changed to spaces instead of tabs... because tabs suck :trollface:

Is this question talk about indentation ? If you prefer using space instead of tab, you can reformat your code manually.

That's what I do too.:)
Would you consider switcher to PSR-2, once Laravel has too (in version 5.1) ? :smile:

I don't know. I would consider it.

I was just asking, because I had the impression, that there are both things used. But in case it's only tabs - this issue can obsiously be closed :).
I wouldn't start switching to spaces before laravel did it...


Added support for multiple calls of the same function with different args

Fixes #6
@rjmackay would you be able to have a look on this solution and test it with your project? Thanks!

That seems to work for me.
Here's some of the code I have testing an IMAP email integration just to give you an idea:
$mockFetchStructure = PHPMockery::mock("Ushahidi\App\DataSource\Email", "imap_fetchstructure");
        // Call for first email
        $mockFetchStructure
            ->with('notreallyaconnection', 1, FT_UID)
            ->once()
            ->andReturn(
                (object)[
                    'parts' => [
                        11 => (object)[
                            'subtype' => 'HTML'
                        ],
                        111 => (object)[
                            'subtype' => 'PLAIN'
                        ]
                    ]
                ]
            );
        // Handle call for 2nd message
        $mockFetchStructure
            ->once()
            ->with('notreallyaconnection', 5, FT_UID)
            ->andReturn(
                (object)[
                    'parts' => [
                        55 => (object)[
                            'subtype' => 'HTML'
                        ]
                    ]
                ]
            );
        // Handle call for 3rd message
        $mockFetchStructure
            ->once()
            ->with('notreallyaconnection', 7, FT_UID)
            ->andReturn(
                (object)[
                    'parts' => [
                        77 => (object)[
                            'subtype' => 'PLAIN'
                        ]
                    ]
                ]
            );

@rjmackay Thanks for your feedback! I'm going to release it shortly :)


psc-ide-server: Be able to provide non-default location to "output/" path

It'd be lovely if we could specify the build-output directory; at the moment it's unfortunately hardcoded to whatever's given to -d plus "output"/.
(In my case, for example, I'm writing a library that's being built to lib, so that I can publish it on npm and have it look like any other library. I'm also working on something else that's building to support/lib/.)
PS: Thanks for writing this project. :smile:

I just wanted to wait until someone needed it before making it configurable ;)
It gets even worse... it's hardcoded TWICE https://github.com/kRITZCREEK/psc-ide/blob/5790093d233f8ff03d94a6d96c2a0333bf50d960/src/PureScript/Ide.hs#L185
code:nose: :D

:heart_eyes:


Removed sct_register_graymatter (obsolete old code) from sct_testing functions

… function from SCT as well.
Requirements

[*] Is there a issue open describing the motivation for this pull request ?
[ ] Does the pull request need an update of the documentation ?
[*] Does the pull request need additional test(s) ?
[ ] Clean up the warnings generated by the style guide

Description of the Change
Removing sct_register_graymatter function from sct_testing
Steps and Constraints
[The steps of reproducing the pull request]
Applicable Issues
Implements or Fixes #1900
Future work: remove the function from SCT as well.

All tests are passed now.


Error at converting Cardinality Restrictions over nominals into SPARQL queries

from owlapy.render import DLSyntaxObjectRenderer
from owlapy.model import *
from owlapy.owl2sparql.converter import Owl2SparqlConverter
ce=OWLObjectMinCardinality(cardinality=1,property=OWLObjectProperty(IRI.create('http://example.com/society#hasChild')),filler=OWLObjectOneOf(OWLNamedIndividual(IRI('http://www.benchmark.org/family#','F3F42'))))
print(DLSyntaxObjectRenderer().render(ce))
print(Owl2SparqlConverter().as_query("?x", ce))

leads to
≥ 1 hasChild.{F3F42}
Traceback (most recent call last):
  File "/home/demir/Desktop/Softwares/Ontolearn/sparql_converter.py", line 8, in <module>
    print(Owl2SparqlConverter().as_query("?x", ce))
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/owlapy/owl2sparql/converter.py", line 627, in as_query
    parseQuery(query)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/rdflib/plugins/sparql/parser.py", line 1542, in parseQuery
    return Query.parseString(q, parseAll=True)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/util.py", line 256, in _inner
    return fn(self, *args, **kwargs)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/core.py", line 1200, in parse_string
    raise exc.with_traceback(None)
pyparsing.exceptions.ParseException: Expected SelectQuery, found '{'  (at char 29), (line:3, col:1)

Similarly, (perhaps again expectedly) mapping doesn't work over multiple nominals
from owlapy.render import DLSyntaxObjectRenderer
from owlapy.model import *
from owlapy.owl2sparql.converter import Owl2SparqlConverter
ce=OWLObjectMinCardinality(cardinality=1,
                           property=OWLObjectProperty(IRI.create('http://example.com/society#hasChild')),
                           filler=OWLObjectOneOf(
                               (OWLNamedIndividual(IRI('http://www.benchmark.org/family#','F3F42')),
                                OWLNamedIndividual(IRI('http://www.benchmark.org/family#','F3F44')))))
print(DLSyntaxObjectRenderer().render(ce))
print(Owl2SparqlConverter().as_query("?x", ce))

≥ 1 hasChild.{F3F42 ⊔ F3F44}
Traceback (most recent call last):
  File "/home/demir/Desktop/Softwares/Ontolearn/sparql_converter.py", line 10, in <module>
    print(Owl2SparqlConverter().as_query("?x", ce))
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/owlapy/owl2sparql/converter.py", line 627, in as_query
    parseQuery(query)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/rdflib/plugins/sparql/parser.py", line 1542, in parseQuery
    return Query.parseString(q, parseAll=True)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/util.py", line 256, in _inner
    return fn(self, *args, **kwargs)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/core.py", line 1200, in parse_string
    raise exc.with_traceback(None)
pyparsing.exceptions.ParseException: Expected SelectQuery, found '{'  (at char 29), (line:3, col:1)

The same exception also occurs for OWLObjectMaxCardinality and OWLObjectExactCardinality
We need to create a SPARQL query from ≥ 1 hasChild.{F3F42} . It would be great if one of you could take care of it
@nkaralis @bigerl @alkidbaci
For the context, the SPARQL mapping works perfectly well if filler is not OWLObjectOneOf.

I guess the error stems from  converting an expression involving OWLObjectOneOf
ce=OWLObjectSomeValuesFrom(property=OWLObjectProperty(IRI('http://www.benchmark.org/family#','hasSibling')),filler=OWLObjectOneOf((OWLNamedIndividual(IRI('http://www.benchmark.org/family#','F6F84')),)))
print(DLSyntaxObjectRenderer().render(ce))
print(Owl2SparqlConverter().as_query("?x", ce))

∃ hasSibling.{F6F84}
Traceback (most recent call last):
  File "/home/demir/Desktop/Softwares/Ontolearn/sparql_converter.py", line 8, in <module>
    print(Owl2SparqlConverter().as_query("?x", ce))
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/owlapy/owl2sparql/converter.py", line 627, in as_query
    parseQuery(query)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/rdflib/plugins/sparql/parser.py", line 1542, in parseQuery
    return Query.parseString(q, parseAll=True)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/util.py", line 256, in _inner
    return fn(self, *args, **kwargs)
  File "/home/demir/anaconda3/envs/venv/lib/python3.10/site-packages/pyparsing/core.py", line 1200, in parse_string
    raise exc.with_traceback(None)
pyparsing.exceptions.ParseException: Expected SelectQuery, found 'FILTER'  (at char 86), (line:4, col:2)

Why use Owl2SparqlConverter().as_query and not Owl2SparqlConverter().convert ?

Because Owl2SparqlConverter().convert does not share a valid SPARQL query in string but a list of strings.
We should have a function (instead of a class)
from owlapy.owl2sparql.converter import owl_expression_to_sparql
to convert an OWL class expression into a SPARQL query. Would you like to take care of it ?


Need more information on licences to be enable on Service Account used by Logic App

Does this service account also needs to have an exchange licence enabled ? Or Just enable only MS Teams License as mentioned in the documentation.

My Team creation failed when there was no valid email address connected to the service account, it returned a NULL value when adding the owners and members as the email address field was empty. I've added a exchange license so there's an mailbox attached to this account. All emails when the teams are created are sent using the service account.
As is my understanding after testing, I'm not the creator of this app, just a happy user.

I too had same issue , it returned null when i assigned only teams license to the service account, But when i enabled exchange license it worked. But documentation only says "Service account is nothing but an Office 365 user who has Teams licenses enabled "

Hi @aravindmunna, @FritsH , The minimum license required for the service account is E3. Since there are some tenant's which follows A1, A2 etc, we mentioned Teams License enabled which covers basic requirements like having access to Teams and SharePoint online.

Hi @aravindmunna, @FritsH , The minimum license required for the service account is E3. Since there are some tenant's which follows A1, A2 etc, we mentioned Teams License enabled(to make it simple for user) which covers basic requirements like having access to Teams, SharePoint Online and Exchange. Thanks for your feedback, we will look into it.

Thank You.

@aravindmunna @FritsH the Service Account requires SPO, Teams and Exchange licenses. It also requires an EXO mailbox. This is because it connects to SPO, Teams and Exchange in the Logic App. The emails are also sent from the Service Account. I have updated the documentation accordingly and will now close this issue.

@alexc-MSFT  Sure, You can close.  Thank you.. I appreciate your clear explanation on this. Now i hope it help others as well.


PendingFollowRequests always empty

I've tried with multiple different instagram accounts, but the users: [] in results is always empty - I just get a ton of suggested_users.
Did instagram remove support for that api call? Any idea how we can get pending requests now?

ah sorry. mixed up the PendingFollowRequests with "following requests" I've sent out myself.


Update HeroSystem6e.html and css to add Martial Maneuvers

Added common Martial Maneuvers from rules
Moved Combat Skill Levels to narrow column
Added "Pur" column to flag purchased Martial Maneuvers

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Character Sheet Info Roll20 Internal Use only.


Re-organize and rename tests

Coverage: 93.674%. Remained the same when pulling b89cd553b8792f0d90317847388585b9545eadaa on nimmo-refactor-post-observation-test-capybara into fe1614da66f6268bf55e72fdfe3be9381762378f on main.


Control.update_parameter() got an unexpected keyword argument 'event'

Hi there,
I am trying to reproduce the examples here: https://agentpy.readthedocs.io/en/latest/guide_interactive.html
The widgets appear and work but when I attempt to change the parameters I get the following error:
TypeError                                 Traceback (most recent call last)
File ~/.local/lib/python3.10/site-packages/ipysimulate/control.py:134, in Control._handle_button_msg(self, _, content, buffers)
    131 def _handle_button_msg(self, _, content, buffers):
    132     """ Handles messages from the front-end
    133     by calling method of same name as msg. """
--> 134     getattr(self, content.get('event', ''))(**content)

TypeError: Control.update_parameter() got an unexpected keyword argument 'event'

And the parameters changes don't work. I am using the version 0.2.1 on Python 3.10.4

My mistake. I think this was due to some old packages I had that were blocking the update of others. With a clean python installation/virtual environment, it works properly.


Print some additional output on macOS if pkg-config fails

homebrew is broken by design and requires manual user-intervention.
See https://github.com/Homebrew/homebrew-core/issues/40179 for more
details.
Fixes https://github.com/gtk-rs/cairo/issues/263

Fine enough for me then, thanks!

So problem now is that build.rs is autogenerated. Should we add a special case to gir for this if the crate name is gobject-sys? @EPashkin ideas? :)

@sdroege IMHO adding this for ns.sys_crate_name=="gobject-sys" is good idea,
I will add it

@EPashkin Updated the PR. Thanks!

👍

@sdroege Thanks, 👍 after all version.txt updated

Regenerated all the version.txt. Wanted to keep the churn lower but the CI does not like that :)

@GuillaumeGomez all green


Asp.net core 2.0 support release

Hi,
We would like to use the WebApi.Hal package in a .net core MVC application but the latest version (2.6.0) is not Asp.net .core compatible.
In the repository It seems that the sources have been updated to build against netStandard 2.0, do you plan on releasing a new version soon?
regards,
Willem

You mean a new nuget package right? I have a more fully tested implementation, but wanted to build a net core project in the solution before releasing to complement the existing .net framework solution.

yes I mean a new nuget release

Would anybody else from the group like to see more before we do a nuget release? Next, I wonder if I'd actually be able to do this 3.0 version to nuget, what sort of permissions I'd run into.

I've been sort of silent in this group for a while, not because I've gone away -- we're actively using this library every day. The reason for silence is I have confidence in the improvements and the people doing them. I'd say go for it.

I made a request to Jake via nuget.org to become an owner of the package so i can upload the 3.0 nuget version targeting netstandard2.0. Hopefully the email address associated with the package is still live.

Last call for @JakeGinnivan before we have to take a more drastic action to get a new nuget package out there. The existing nuget package owners have to approve it, or one of us needs to become an owner or we may have rename the package start over.

Happy to say that a new nuget package with the .netstandard work from @Jetski5822 has been released to nuget.org.
https://www.nuget.org/packages/WebApi.Hal/

YAY!!!


(fix) Parse "not created" status message

There was a problem with the status message "not created". I fixed the regexp and added a test. I had to extract the parseStatus function to properly test it.
My editor automatically removed all the whitespaces on empty lines.. Hope that is okay.

Thanks!


[BUG]: build.gradle.kts not recognized when enabling code coverage

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
Gradle
Task version
3
Issue Description
My gradle build file is a kotlin file, build.gradle.kts , and not build.gradle. The .kts file isn't recognized when the task wants to enable code coverage. See the attached log output: it complains about missing build.gradle file and doesn't try to look for build.gradle.kts. At the first glance, it happens because the filename is hardcoded here: https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/GradleV3/Modules/code-coverage.ts#L19
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
ubuntu-latest
Relevant log output
##[warning]Unable to append code coverage data: Error: File or folder doesn't exist: /home/vsts/work/1/s/build.gradle
    at Object.appendTextToFileSync (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/node_modules/azure-pipelines-tasks-codecoverage-tools/utilities.js:80:15)
    at JacocoGradleCodeCoverageEnabler.enableCodeCoverage (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/node_modules/azure-pipelines-tasks-codecoverage-tools/jacoco/jacoco.gradle.ccenabler.js:37:18)
    at Object.enableCodeCoverageAsync (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/Modules/code-coverage.js:34:32)
    at /home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:92:43
    at Generator.next (<anonymous>)
    at /home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:4:12)
    at run (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:27:12)
    at Object.<anonymous> (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:154:1)
##[warning]Failed to enable code coverage: Unable to append code coverage data: Error: File or folder doesn't exist: /home/vsts/work/1/s/build.gradle
    at Object.appendTextToFileSync (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/node_modules/azure-pipelines-tasks-codecoverage-tools/utilities.js:80:15)
    at JacocoGradleCodeCoverageEnabler.enableCodeCoverage (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/node_modules/azure-pipelines-tasks-codecoverage-tools/jacoco/jacoco.gradle.ccenabler.js:37:18)
    at Object.enableCodeCoverageAsync (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/Modules/code-coverage.js:34:32)
    at /home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:92:43
    at Generator.next (<anonymous>)
    at /home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:4:12)
    at run (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:27:12)
    at Object.<anonymous> (/home/vsts/work/_tasks/Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4/3.238.0/gradletask.js:154:1)
/home/vsts/work/1/s/gradlew clean build jacocoTestReport

Full task logs with system.debug enabled
No response
Repro steps
No response

Hi @erosb, thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.

Hello, can this be prioritized any time soon?


Add SDMMC support

I'd like to use the microSD slot on the STM32F7-Discovery board. This is connected to:

Pin
GPIO
Description

A12
PC12
SDMMC_CK

D12
PD2
SDMMC_CMD

G14
PC8
SDMMC_D0

F14
PC9
SDMMC_D1

B14
PC10
SDMMC_D2

B13
PC11
SDMMC_D3

I have an embedded-sdmmc crate, but that only handles SD cards connected to generic embedded-hal::spi devices. I'd like to add an implementation of the embedded-sdmmc::blockdevice::BlockDevice for the SDMMC peripheral on the STM32F7.
I'll try a few things out in my fork and send a PR once I think it's working.

I've been working on getting SD/SDIO/MMC card host interface (SDMMC) to work, didn't get done with it though until priorities shifted, maybe someone would like to build on my previous work (which is predominantly on customizations of the stm32h7 hal implementation).
The reading worked partially.
https://github.com/systec-ms/stm32f7xx-hal/tree/sdmmc


Enable noImplicitOverride and fix all the errors

Enabled noImplicitOverride in tsconfig.json and tsconfig.build.json.
Fixed 3000+ compile errors.

I wrote this node script to do the heavy lifting (including it here in case it is useful for similar things in the future):
"use strict";

// This script expects to find a build.log in the same directory (e.g. the result of running `tsc --build > build.log`).
// It will look for errors resulting from violations of noImplicitOverride, and insert override keyword.
// This is meant to be a way of enabling noImplicitOverride and quickly fixing all violations.

const fs = require("fs");
const chalk = require("chalk");

const buildLog = fs.readFileSync("build.log", "utf8");

const errorRegex =
  /(?<filePath>.+)\((?<errorLine>\d+),(?<errorColumn>\d+)\): error (?<errorCode>TS\d+): (?<errorMessage>.*)/;
const declarationRegex = /(public|protected)?( static)? (\w+)\(/;

(async function () {
  let totalErrorCount = 0;
  let fixedErrorCount = 0;
  const processedLines = new Set();
  for (const line of buildLog.split("\n")) {
    try {
      const match = line.match(errorRegex);
      if (match) {
        totalErrorCount++;
        const { filePath, errorLine, errorColumn, errorCode, errorMessage } =
          match.groups;

        if (processedLines.has(`${filePath}:${errorLine}`)) {
          console.log(`Skipping duplicate error in ${filePath}:${errorLine}`);
          continue;
        }

        processedLines.add(`${filePath}:${errorLine}`);

        fixedErrorCount++;

        const lineIndex = errorLine - 1;

        const fileContent = fs.readFileSync(filePath, "utf8").split("\n");
        const lineContent = fileContent[lineIndex].replace(
          declarationRegex,
          "$1$2 override $3("
        );
        fileContent.splice(lineIndex, 1, lineContent);
        fs.writeFileSync(filePath, fileContent.join("\n"));
      }
    } catch (e) {
      console.log(chalk.red(`Error processing line: ${line}`));
      console.error(e);
      break;
    }
  }
  console.log(`Found ${totalErrorCount} errors`);
  console.log(`Fixed ${fixedErrorCount} errors`);
})();

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15009/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15009/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15009/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15009/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15009/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15009/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15009/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15009/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15009/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15009/merge/testResults/webgpuplaywright/index.html


GeoJSON with DivIcons can't be BringToFront'd?

Hi,
If I have a GeoJSON layer with a pointToLayer function like this:
let circleHtml = '<div style="height: ' + x + 'px; width: ' + x + 'px; opacity:' + col.opacity + '; background-color:' + col.fillColor + '; border: ' + col.weight + 'px solid ' + col.color + ';border-radius: 30px;"/>';
let circleIcon = L.divIcon({ iconAnchor: L.point(x / 2, x / 2), html: circleHtml, className: '' });
return L.marker(latlng, { icon: circleIcon });

then BringToFront/BringToBack has no effect.
However, if using CircleMarkers or other Path-types, it works as intended.
Any ideas why this happens, and how to reorder the first type of layers?

This is expected behaviour: L.Markers do not have a bringToFront method, so running L.FeatureGroup.bringToFront() does not affect the markers in that group.
Also note that L.Paths do have a bringToFront method.

@IvanSanchez Okay, thank you for clarification. I'm guessing I'll have to play around with z-Index then to reorder layers on the map?

@simison Yeah, the way of handling z-ordering on markers is messing with the z-index offsets themselves. While I agree that there should be a way to bringToFront markers, it's not easy to make that work along custom z-index offsets.


Switch DELTA to gauge from counter

A Counter is defined as a cumulative metric that only ever goes up. The DELTA value could go up or down depending on the minute of time and what is measured.
Tested this on our live instance and switching this without changing the name doesn't seem to break anything in Prometheus.

Thanks @fastest963!


Replace grep base images parsing with dockerfile-json

This is more reliable and allow us to fix bugs where base images were loaded incorrectly.
For example, previously this part in Dockerfile:
LABEL description="this is a build
from single-arch"
Would return "single-arch" as a base image.
Using dockerfile-json also solves the problem of omitting "scratch" from the results.
Another advantage is that when we have something such as:
FROM registry.access.redhat.com/ubi9/ubi:latest as builder ...
FROM builder AS build1
then only the original image
"registry.access.redhat.com/ubi9/ubi:latest" will be reported.
KFLUXBUGS-1269

This has to be merged only after https://github.com/konflux-ci/buildah-container/pull/62 and the image reference has to be replaced.

/retest

When playing with dockerfile-json to see if it could help with https://github.com/konflux-ci/build-definitions/issues/1200, I found out it will probably make things even worse :disappointed:
FROM registry.fedoraproject.org/fedora-minimal:40

RUN /bin/sh <<EOF
mkdir -p /etc/foo
cp -aR /src/foo /etc/foo
EOF

$ dockerfile-json /tmp/Dockerfile
[dockerfile-json 1.0.8] error: parse "/tmp/Dockerfile": dockerfile/instructions.Parse dockerfile parse error on line 4: unknown instruction: mkdir

It looks like the latest release of dockerfile-json (from 3 years ago: https://github.com/keilerkonzept/dockerfile-json/releases) uses a version of buildkit that didn't yet support heredocs (and who knows what else).
Then I tried to build dockerfile-json from source to see if it's fixed in main, but it doesn't even compile anymore:
# github.com/keilerkonzept/dockerfile-json/pkg/dockerfile
pkg/dockerfile/parse.go:26:46: not enough arguments in call to instructions.Parse
	have (*parser.Node)
	want (*parser.Node, *linter.Linter)

All my trust in that project just went out the window

On the other hand, the fix was pretty simple if we want to fork the project and add some CI so that the auto-merged Renovate updates don't just randomly break main
diff --git a/pkg/dockerfile/parse.go b/pkg/dockerfile/parse.go
index 44daf75..02dac0a 100644
--- a/pkg/dockerfile/parse.go
+++ b/pkg/dockerfile/parse.go
@@ -23,7 +23,7 @@ func ParseReader(r io.Reader) (*Dockerfile, error) {
 	if err != nil {
 		return nil, fmt.Errorf("dockerfile/parser.Parse %v", err)
 	}
-	stages, metaArgs, err := instructions.Parse(result.AST)
+	stages, metaArgs, err := instructions.Parse(result.AST, nil)
 	if err != nil {
 		return nil, fmt.Errorf("dockerfile/instructions.Parse %v", err)
 	}

On the other hand, the fix was pretty simple if we want to fork the project and add some CI (or contribute this upstream, but it looks rather abandoned) so that the auto-merged Renovate updates don't just randomly break main
diff --git a/pkg/dockerfile/parse.go b/pkg/dockerfile/parse.go
index 44daf75..02dac0a 100644
--- a/pkg/dockerfile/parse.go
+++ b/pkg/dockerfile/parse.go
@@ -23,7 +23,7 @@ func ParseReader(r io.Reader) (*Dockerfile, error) {
 	if err != nil {
 		return nil, fmt.Errorf("dockerfile/parser.Parse %v", err)
 	}
-	stages, metaArgs, err := instructions.Parse(result.AST)
+	stages, metaArgs, err := instructions.Parse(result.AST, nil)
 	if err != nil {
 		return nil, fmt.Errorf("dockerfile/instructions.Parse %v", err)
 	}

@chmeliik Thanks for your investigation here. I tried forking the repo, so far just to my account and adding the fix you proposed. Now it can be build from source and the main branch - see https://github.com/konflux-ci/buildah-container/pull/62
Now, the heredocs can be parsed as well, because it uses latest buildkit version. But this concerns me, I wanted to avoid having more work, but if we decide to fork the repo, setup the CI and maintain it, it will require further work down the line. But seems like we do need such a funcionality. The dockerfile-json uses the parsing from the buildkit directly, if we wanted we could build our own tool around it as well.

Is there a reason that we are only making these changes on the v0.2 tasks?

Is there a reason that we are only making these changes on the v0.2 tasks?

I remember briefly discussing this with Adam, that it does not seem to worth to update the 0.1 tasks, as we are not expecting many users to still use them and this update does not seem that critical to include it in the old tasks. But if you have better knowledge of this and feel like I should update the 0.1 tasks as well then let me know.

I remember briefly discussing this with Adam, that it does not seem to worth to update the 0.1 tasks, as we are not expecting many users to still use them and this update does not seem that critical to include it in the old tasks. But if you have better knowledge of this and feel like I should update the 0.1 tasks as well then let me know.

The question comes from a maintenance burden. If the change is minimal to make, then it seems like it would be better to make it so that the tasks are the same.
I am not saying that we should do it, I am just raising the observation that we are not.

I remember briefly discussing this with Adam, that it does not seem to worth to update the 0.1 tasks, as we are not expecting many users to still use them and this update does not seem that critical to include it in the old tasks. But if you have better knowledge of this and feel like I should update the 0.1 tasks as well then let me know.

The question comes from a maintenance burden. If the change is minimal to make, then it seems like it would be better to make it so that the tasks are the same.
I am not saying that we should do it, I am just raising the observation that we are not.

It might be minimal to make, but it would again take some time to test it. And as far as I understand, the e2e tests here are running only the newer version of tasks.


fix temporary models and model fields

several model fields and settings are in a temporary state that needs resolving in 3.0.1.
People

[x] OldProfile should be removed

Projects

[x] OldProject should be removed
[x] Grant.project should use the models.CASCADE deletion handler and not allow null
[x] Grant.old_project should be removed
[x] Membership.project should use the models.CASCADE deletion handler and not allow null
[x] Membership.old_project should be removed
[x] ProjectRelatedLink.project should use the models.CASCADE deletion handler and not allow null
[x] ProjectRelatedLink.old_project should be removed

Events

[x] OldEvent should be removed

Blog

[x] OldBlogPost should be removed

Resources

[x] DateRange should be moved to pages app
~delete everything else, including the entire app~

cleanup migration ran in qa without problems and did not introduce any data errors


Call changed_lines() with the correct lnum in empty buffer in ex_append

Fix #9438

Why does code coverage drop that much when I remove two empty lines in tests...

Why does code coverage drop that much when I remove two empty lines in
tests...

Code coverage for pull requests tends not to work very well.
You can hopefully look at the code you changed to see if it is covered
by tests.  But the total percentage is irrelevant.
--
hundred-and-one symptoms of being an internet addict:
166. You have been on your computer soo long that you didn't realize
you had grandchildren.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

The first commit I pushed to the branch passed all checks. Then I pushed another commit to the branch only removing two blank lines from the tests I added, and code coverage suddenly dropped.

I'll post more about the problem I'm trying to solve here. The problem is a side-effect of patch 7.4.1970. Patch 7.4.1970 changed ex_append to call appended_lines_mark() with 1 as lnum when the buffer is empty (before that patch it passed 0), which in turn calls changed_lines() with 2 as lnum (before that patch it passed 1), and the first line is not marked as modified. As a result, the first line is sometimes not displayed, e.g., when :insert or :append is used from a timer in an empty buffer.

And in this PR I'm just changing it to call appended_lines() instead of appended_lines_mark(), and with 0 as lnum instead of 1, so the marks are still not affected, but the first line is marked as modified, so it will be displayed correctly by win_update().


[FEATURE REQUEST]: Add NERFC Download Extents

Feature Request Type

[X] User Interface (UI)
[X] Application Programming Interface (API)

Is your feature request related to a problem? Please describe.
NERFC extents are not much larger than the largest river system (Connecticut River) that NAE operate for and full extent of NERFC products are more useful than clipped versions to watershed extents.
Describe the solution you'd like
Below are approximate NERFC rectangular corner point coordinates, subject to verification by Stephen Kissock at NAE:
| Latitude | Longitude|
| 50.228 | -73.696|
| 46.049 | -64.952|
| 38.779 | -72.164|
| 42.058 | -79.987|

Thanks @FHanbali.  @adamscarberry, I think we should add a table to the database to contain polygons for the 13 RFCs (and separate them from the watershed table).  What do you think?
We could make the table schema very similar (if not identical) to watershed, but would only hold the 13 RFC boundaries.  https://www.weather.gov/gis/RFCBounds.  Then, for areas of interest, we could UNION the watershed and river_forecast_center tables so either is an option for extract.
Alternatively, we could add all RFCs to the existing watershed table, change the name of the table to aoi, add a column called something like aoi_type (watershed, rfc, ...) so the watershed table becomes more of a generic "areas of interest" table.

NAE would prefer a single product that covers our regulated area (we have no regulated basins in Maine). This would greatly assist our CWMS setup and covers only 36k SHG grid cells. The area can be trimmed down a little from those above and I included the SHG coordinates in case you are still using those.
                      |  Lat, Long   |  SHG X, Y
         Bottom Left  | 41.0, -73.8  |   900, 1120
         Upper Right  | 45.4, -70.7  |  1020, 1370

Thank you!

Awesome information @stephenkissock. What do you typically call the regulated area if we were to give it a name? Is it associated with a particular watershed?

Just go with "NAE" since it would cover all five basins.

Adding RFC extents more broadly became necessary for QA testing of new products to be added for FY23-Quarter 1 objectives. Adding this issue to FY23-Q1 milestone (cc @FHanbali).
We started with the shapefile here (https://www.weather.gov/gis/RFCBounds) which includes all RFC boundaries. QGIS was used to transform the shapefile to EPSG:5070 (Standard Hydrologic Grid) and create bounding boxes for all RFC extents.
The following script (starting point) is used to generate SQL needed to add the RFC extents to the database.

Note: RFC bounding box coordinates on the "left" and "bottom" are rounded down to the nearest multiple of 2000 (2km), "right" and "top" are rounded up to the nearest multiple of 2000 (2km). This ensures the boundaries saved in the database both land on a cell edge of a grid saved with a projection of SHG (EPSG:5070) with a cell size of 2000 and always include the entire original RFC boundary.

import json
import math

buffer, cellsize = 0, 2000
round_down = lambda val: int((math.floor(val/cellsize)*cellsize)-buffer)
round_up = lambda val: int((math.ceil(val/cellsize)*cellsize)+buffer)

_json = '''{
"type": "FeatureCollection",
"name": "rfc",
"crs": { "type": "name", "properties": { "name": "urn:ogc:def:crs:EPSG::5070" } },
"bbox": [ -2356057.872395,<PHONE_NUMBER>71785, 2258191.54104844, 3505169.15998809 ],
"features": [
{ "type": "Feature", "properties": { "OBJECTID": 2, "SITE_ID": "KRF", "STATE": "MO", "RFC_NAME": "Missouri Basin", "RFC_CITY": "Kansas City\/Pleasant Hill", "BASIN_ID": "MBRFC" }, "bbox": [ -1389593, 1556204, 483276, 3043875 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -1389593, 1556204 ], [ 483276, 1556204 ], [ 483276, 3043875 ], [ -1389593, 3043875 ], [ -1389593, 1556204 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 3, "SITE_ID": "STR", "STATE": "UT", "RFC_NAME": "Colorado Basin", "RFC_CITY": "Salt Lake City", "BASIN_ID": "CBRFC" }, "bbox": [ -1774279, 999789, -811701, 2357426 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -1774279, 999789 ], [ -811701, 999789 ], [ -811701, 2357426 ], [ -1774279, 2357426 ], [ -1774279, 999789 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 4, "SITE_ID": "TUA", "STATE": "OK", "RFC_NAME": "Arkansas-Red Basin", "RFC_CITY": "Tulsa", "BASIN_ID": "ABRFC" }, "bbox": [ -907431, 1147930, 367713, 1866333 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -907431, 1147930 ], [ 367713, 1147930 ], [ 367713, 1866333 ], [ -907431, 1866333 ], [ -907431, 1147930 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 5, "SITE_ID": "RSA", "STATE": "CA", "RFC_NAME": "California-Nevada", "RFC_CITY": "Sacramento", "BASIN_ID": "CNRFC" }, "bbox": [ -2356058, 1243480, -1518404, 2540457 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -2356058, 1243480 ], [ -1518404, 1243480 ], [ -1518404, 2540457 ], [ -2356058, 2540457 ], [ -2356058, 1243480 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 6, "SITE_ID": "ORN", "STATE": "LA", "RFC_NAME": "Lower Mississippi", "RFC_CITY": "New Orleans\/Baton Rouge", "BASIN_ID": "LMRFC" }, "bbox": [ -23139, 673055, 1293858, 1702397 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -23139, 673055 ], [ 1293858, 673055 ], [ 1293858, 1702397 ], [ -23139, 1702397 ], [ -23139, 673055 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 7, "SITE_ID": "RHA", "STATE": "PA", "RFC_NAME": "Middle Atlantic", "RFC_CITY": "Central Pennsylvania", "BASIN_ID": "MARFC" }, "bbox": [ 1350832, 1687761, 1843609, 2404393 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ 1350832, 1687761 ], [ 1843609, 1687761 ], [ 1843609, 2404393 ], [ 1350832, 2404393 ], [ 1350832, 1687761 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 8, "SITE_ID": "MSR", "STATE": "MN", "RFC_NAME": "North Central", "RFC_CITY": "Minneapolis", "BASIN_ID": "NCRFC" }, "bbox": [ -650499, 1616600, 1097654, 3052061 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -650499, 1616600 ], [ 1097654, 1616600 ], [ 1097654, 3052061 ], [ -650499, 3052061 ], [ -650499, 1616600 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 9, "SITE_ID": "TAR", "STATE": "MA", "RFC_NAME": "Northeast", "RFC_CITY": "Boston", "BASIN_ID": "NERFC" }, "bbox": [ 1361036, 2161958, 2258192, 3040497 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ 1361036, 2161958 ], [ 2258192, 2161958 ], [ 2258192, 3040497 ], [ 1361036, 3040497 ], [ 1361036, 2161958 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 10, "SITE_ID": "PTR", "STATE": "OR", "RFC_NAME": "Northwest", "RFC_CITY": "Portland", "BASIN_ID": "NWRFC" }, "bbox": [ -2294670, 2191666, -1103294, 3505169 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -2294670, 2191666 ], [ -1103294, 2191666 ], [ -1103294, 3505169 ], [ -2294670, 3505169 ], [ -2294670, 2191666 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 11, "SITE_ID": "TIR", "STATE": "OH", "RFC_NAME": "Ohio", "RFC_CITY": "Cincinatti", "BASIN_ID": "OHRFC" }, "bbox": [ 610718, 1413236, 1488217, 2294358 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ 610718, 1413236 ], [ 1488217, 1413236 ], [ 1488217, 2294358 ], [ 610718, 2294358 ], [ 610718, 1413236 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 12, "SITE_ID": "ALR", "STATE": "GA", "RFC_NAME": "Southeast", "RFC_CITY": "Atlanta", "BASIN_ID": "SERFC" }, "bbox": [ 630164, 273886, 1833437, 1740464 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ 630164, 273886 ], [ 1833437, 273886 ], [ 1833437, 1740464 ], [ 630164, 1740464 ], [ 630164, 273886 ] ] ] } },
{ "type": "Feature", "properties": { "OBJECTID": 13, "SITE_ID": "FWR", "STATE": "TX", "RFC_NAME": "West Gulf", "RFC_CITY": "Dallas\/Fort Worth", "BASIN_ID": "WGRFC" }, "bbox": [ -1205734, 209815, 270829, 1759952 ], "geometry": { "type": "Polygon", "coordinates": [ [ [ -1205734, 209815 ], [ 270829, 209815 ], [ 270829, 1759952 ], [ -1205734, 1759952 ], [ -1205734, 209815 ] ] ] } }
]
}'''

rfcs = json.loads(_json)

for f in rfcs['features']:

    xmin, ymin, xmax, ymax = round_down(f['bbox'][0]), round_down(f['bbox'][1]), round_up(f['bbox'][2]), round_up(f['bbox'][3])

    #-- xmin,ymax (top left), xmax ymax (top right), xmax ymin (bottom right), xmin ymin (bottom left), xmin ymax (top left again)
    print("'{}',ST_GeomFromText('POLYGON (({} {}, {} {}, {} {}, {} {}, {} {}))', 5070)".format(
        f['properties']['BASIN_ID'], xmin, ymax, xmax, ymax, xmax, ymin, xmin, ymin, xmin, ymax)
    )

All River Forecast Center extents have been added to develop & stable versions of the Cumulus database.


Adding Firestore Vector Store

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[x] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

@logan-markewich appreciate if we can get a review here 🙏🏻

@pr-Mais I think my only concern here is the lack of a similarity score (Thanks @pl04351820 and @JU-2094 for the reviews here)

@logan-markewich comments have been addressed, thanks a lot.


Reflect changes post s3 migration and prow.tanzu.io migration

This is a follow-up on migration of prow logs to S3.
Front end of testgrid could be generated with the changes in this PR.
However, testgrid backend has updater controller which checks for Prow job logs and populates cells in testgrid. This controller currently accepts only GCS buckets for source of truth of Prow job logs and does not work with S3.
{"config":"gs://vagator-testgrid/config","error":"read first column: group path: gs://bucket may not contain a port: gs://s3:/tanzu-prow-logs/logs/post-test-image/","file":"pkg/updater/updater.go:378","func":"github.com/GoogleCloudPlatform/testgrid/pkg/updater.Update.func
2","group":"post-test-image","level":"error","msg":"Failed to update group","time":"2022-03-31T09:17:04Z"}

This PR should be merged only when updater supports S3.
Signed-off-by: Rajas Kakodkar<EMAIL_ADDRESS>

/hold

/title Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration

/retitle Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration