test

Docs Build status updates of commit 2ae726c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

.openpublishing.redirection.json
:x:Error

Details

.openpublishing.redirection.json

[Error] source_path 'enterprise-graph' in master redirection file should point to a file of supported extension: .md, .yml.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 671cfc3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

.openpublishing.redirection.json
:x:Error

Details

.openpublishing.redirection.json

[Error]

Error occurred: System.ArgumentException: Illegal characters in path.
   at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
   at System.Security.Permissions.FileIOPermission.QuickDemand(FileIOPermissionAccess access, String fullPath, Boolean checkForDuplicates, Boolean needFullPath)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.BaseRedirectionResolver.<CheckSourcePath>b__10_0(RedirectionEntry entry)
   at System.Linq.Enumerable.WhereListIterator`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.BaseRedirectionResolver.CheckSourcePath(IEnumerable`1 entries)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.RedirectionGenerator.<ResolveCoreAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Program.<RunAsync>d__2.MoveNext()

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 671cfc3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

.openpublishing.redirection.json
:x:Error

Details

.openpublishing.redirection.json

[Error]

Error occurred: System.ArgumentException: Illegal characters in path.
   at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
   at System.Security.Permissions.FileIOPermission.QuickDemand(FileIOPermissionAccess access, String fullPath, Boolean checkForDuplicates, Boolean needFullPath)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.BaseRedirectionResolver.<CheckSourcePath>b__10_0(RedirectionEntry entry)
   at System.Linq.Enumerable.WhereListIterator`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.BaseRedirectionResolver.CheckSourcePath(IEnumerable`1 entries)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Resolvers.RedirectionGenerator.<ResolveCoreAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.OpenPublishing.Build.Applications.RedirectionResolver.Program.<RunAsync>d__2.MoveNext()

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Crashed when using isIntialFirstResponder on CocoaTextField

Environment

master branch
CocoaTextField.swift

Problem
Crashed when using isIntialFirstResponder(true) modifier.

eg)
SomeView
.sheet(isPresented: $isPresented) {
    CocoaTextField("", text: self.$text)
        .isInitialFirstResponder(true)
}

Why
Calling becomeFirstResponder() -> Bool may cause crash before adding the view to view hierarchy as described in this apple document.: (https://developer.apple.com/documentation/uikit/uiresponder/1621113-becomefirstresponder)
I suppose SwiftUI doesn't change view hierarchy while it is in makeUIView step. so,  Calling becomeFirstResponder() in makeUIView cause crash.
Workaround
Use DispatchQueue.main.async to delay executing becomeFirstResponder(). updateUIView() doesn't occur crash, so I suppose SwiftUI add view to view hierarchy just after makeUIView().
before
public func makeUIView(context: Context) -> UIViewType {
        let uiView = _UITextField()

        uiView.delegate = context.coordinator

        if let isFirstResponder = isInitialFirstResponder, isFirstResponder {
                uiView.becomeFirstResponder()
        }

        return uiView
    }

after
public func makeUIView(context: Context) -> UIViewType {
        let uiView = _UITextField()

        uiView.delegate = context.coordinator

        if let isFirstResponder = isInitialFirstResponder, isFirstResponder {

            DispatchQueue.main.async {
                uiView.becomeFirstResponder()
            }
        }

        return uiView
    }

Fixed! Thank you for reporting. It's weird because I haven't encountered this on iOS 13.4, but I know that SwiftUI is buggy across older versions.


Possible "wrong" setting of css 'max-height' for select dropdown

Hi,
I want to use the custom scrollable feature of the select dropdown. However using maxVisibleItems did not work. On inspecting the code as well as the fake elements stylings I stumbled upon a possible bug.
When the styling of the "listHolder" element is set, the code is:
this.listHolder.css({maxHeight: this.getOverflowHeight(maxCount),overflow: 'auto'});
However the max-height is not applied to the list holder. I've fixed this problem for me by changing maxHeight to 'max-height'.
Furthermore, as the list holder element is a <span>-Element I would recommend to consider adding display:'block' by default, as <span>-Elements by default are inline elements which are not capable of having CSS-height stylings.
Thanks a lot.

Hi @Grillmeisterfleisch !
What jQuery version are you using? I've just tried to set maxHeight to <span> element and it works just fine. You can check the current behavior of custom scrollbars by opening index.html from this repo.
Regarding the block element - JCF heavily relies on some styles which must be in the CSS (check "theme-minimal" folder). All of these styles cannot be simply set inline via JS. Regarding the listHolder - it has display: inline-block style defined in CSS, so it supports height.

Hi @inferpse !
The jQuery Version I'm using is jQuery 2.1.4. I know it's quite old, but due to some dependencies on other parts of the project I am working on i am not able to use a newer version :-/ . I guess that's the problem why setting the max-height via 'maxHeight' did not work in my environment.
Thanks for the hint regarding the CSS dependencies of the theme minimal folder - I did not know that and guessed that all required styles to provide a basic functionality would be set inline via JS as this was the first problem I've encountered using JCF.
Thank you for your help :)

Cool. Thanks for feedback - now I see that we're missing information related to CSS in the documentation. It will be added later.


Account Deletion and Lies from Nylas Support

I've already reached out to your team about deleting account.
The first reply I received was:
Hey Dan,

Thanks for writing in about your Nylas Mail question. Unfortunately, we are no longer providing help support for Nylas Mail or N1. As a company, Nylas is focused on our API products to help other developers build email, calendar, and sync capabilities into their own applications.

While we no longer provide help support, N1 and Nylas Mail will continue working just as they do today - we are not turning them off any time in the forseeable future. If you have a subscription for N1 or Nylas Pro, those will continue to work. If you're a developer, or you know some developers interested in email or Electron applications, we encourage forks of the Nylas Mail project - https://github.com/nylas/nylas-mail/

If you want to cancel your N1 or Nylas Mail subscription, please visit http://billing.nylas.com and we'll give you a prorated refund of your purchase.

Thanks for being a Nylas Mail or N1 user -

Cheers,
Sachin

I was shocked to receive this wherein I replied that under EU DPD and the upcoming GDPR, I have the right to remove my personal information. I then received this reply from Sachin.
Sorry you hit the automated response. Deleted.

I went to check if my account was really deleted at billing.nylas.com only to find that my account was only active. I guess Nylas has a different definition of "deleted"?

I honestly regret trying this product out because I am struggling to remove it from my laptop. I was trying to find a replacement for Thunderbird and really liked Nylas's UI. I should have expected a red flag if they needed me to create an account just to use a dead service, but hindsight is 20/20 I suppose.

Is this truly an issue/bug with the nylas-mail software application or more of a support complaint?

This is still almost the same answer.
The very first ticket/answer was:

Unusued account automatically get deleted.

I asked more information, never been answered. Then 2 weeks later, i retried:

Mathieu,
Sorry, but we are no longer providing customer support for Nylas Mail or N1. Please see this post for details. You may wish to check https://github.com/nylas-mail-lives/nylas-mail or http://getmailspring.com/ for an alternative email client.
If you need a refund, please visit https://billing.nylas.com to downgrade your subscription to Basic (free). We'll automatically refund your credit card for the remaining time left on your subscription.
If you've forgotten your Nylas password, please visit https://billing.nylas.com/forgot to do a password reset. Then you can downgrade to Basic.
We automatically delete unused Nylas Mail accounts, but it can take some time - unfortunately, we cannot accept immediate deletion requests.
Sincerely,
The Nylas Team

As a first supporter, not having an option to opt-out or delete is outstanding. And more the fact they just don't want to do any support. What about our data living in their server? What about the deletion time?
I'm starting a legal complain about it, mail me if you want to join.
Mathieu

Seems like peoples new about it: https://news.ycombinator.com/item?id=12408288

When I see an open source project that forces me to create an account on their to use their product without advertising it on the project homepage clearly, i jump on my seat. Just a few searches on the internet and i'm on this issue. I delete the app from my desktop and went for a coffee instead. Now days a proper account deletion process should be the first feature to code.
Cheers!


D&D 3.5 (fr), fix str check

better fix thanks to comments by @pjbehr87 in the https://github.com/Roll20/roll20-character-sheets/pull/1812

Thank you for making these changes!


[BUG] bloxstrap displaying as context menu container on discord and can't detect presence.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
[BUG] bloxstrap displaying as context menu container on discord and can't detect presence. I've tried possible fixes and still isn't fixed.

What do you mean by "context menu container"?

Is this still happening?

Issue has stale for over a month, and will be reopened if further information is given.


Easy-fix: Coveralls code coverage algorithm is wrong( decrease when adding documentation)

I just noticed that the goveralls decrease for adding documentation or other files.
This cannot be the real coverage target. We need to adapt the filters :sunflower:

i will try to fix  it

Ouch, this is really bad :/

@flavio  yop,  to me seems that adding a ruby and dir decrease. i will have try to look at it more in deep once i have some free time in life :sunflower:


Problem using ACLs for authentication

Original issue:
https://github.com/dask/dask/issues/2852
I am tagging @bdrosen96 at the recommendation of @martindurant
Summary:
token = hdfs3.HDFileSystem().delegate_token(user='jlord')
hdfs = hdfs3.HDFileSystem(token=token)
hdfs.ls('/user/jlord') # everything works
hdfs.ls('/user/hive/warehouse/database_name.db/table_name') # File Not Found Error Below

The error:
---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
<ipython-input-35-1412502a9b50> in <module>()
----> 1 hdfs.ls('/user/hive/warehouse/database_name.db/table_name')

/nas/isg_prodops_work/jlord/conda/envs/dask/lib/python3.6/site-packages/hdfs3/core.py in ls(self, path, detail)
    333         """
    334         if not self.exists(path):
--> 335             raise FileNotFoundError(path)
    336         num = ctypes.c_int(0)
    337         fi = _lib.hdfsListDirectory(self._handle, ensure_bytes(path),

FileNotFoundError: /user/hive/warehouse/database_name.db/table_name

I can use hdfs.ls on any directory that I would expect to have access to except for the hive warehouse which is protected using Sentry. I have been told that Sentry uses ACLs to manage permissions to files/directories in the hive warehouse.
Looking at the ACLs yields:
$ hadoop fs -getfacl /user/hive/warehouse/database_name.db/table_name
# file: /user/hive/warehouse/database_name.db/table_name
# owner: hive
# group: hive
user::rwx
user:hive:rwx
group::---
group:hive:rwx
group:hdpruff:rwx
group:hdpqra:r-x
mask::rwx
other::--x

I do not have group hive (which I assume is managed by sentry), but I do have group hdpruff and hdpqra.
hadoop fs -ls can find that directory and I can use spark to read the underlying parquet file for that hive table.

Calling hdfs3._lib.hdfsGetLastError() yields
InvalidParameter: Invalid parameter: cannot convert 4601 to "Permission"

The problem is the if statement here https://github.com/ContinuumIO/libhdfs3-downstream/blob/18ae9565eb426d9caec2e0ee77e2739aa41d06f3/libhdfs3/src/client/Permission.cpp#L33
The number 4601 is binary 0b1000111111001. The rightmost 9 bits still appear to correspond to the permissions. user: rwx, group: rwx, and other: --x. The problem is the extra leftmost bit which is not expected by Permission.cpp. I cannot find any documentation that explains why that bit is 1.
I was able to comment out the if statement, rebuild the library and re-run hdfs.ls('/user/hive/warehouse/database_name.db/table_name') which now returns a result. I don't know why this if statement exists, however, so I do not know if removing that statement will have unintended consequences (and it probably will).

Good detective work, @quartox !
Since the further code doesn't use any of the bits other than the right 9 as you describe, and 13 for encryption,  I'd be tempted to ignore the if statement too. @bdrosen96 any thoughts on this?

I believe that we have this addressed in my fork as well as the uncommitted branch (not sure what is happenning with that?):
https://github.com/martindurant/libhdfs3-downstream/blob/brett/kms/libhdfs3/src/client/Permission.cpp#L32-L47
You could ignore the encryption bit for doing directory listing, but will have problems reading file contents if it is encrypted without using a version that handles the encrypt/decrypt stuff using KMS.

Re: what's the status of the unmerged branch: that's where we were seeing problems with the implementation of the proxy/impersonation, i.e., secure things would work only is the user were configured as a proxy entity, whereas only the hdfs user should normally be.
Conversely, using the current master with your libgsasl branch seemed enough to get "private" security working (but not KMS, of course). I am not currently assigned to work on any of this, hence the pause in progress.

@quartox , you are most welcome to try the PR branch too, and see if it works for you, especially in conjunction with various secure configurations.

Is there a way that I can build the conda package locally or can you try emailing me the zipped conda build of the PR branch? It is annoying to build in each of my environments but if I could just do a local conda install after building and trick hdfs3 into thinking that it is a reasonable dependency, then I can work with that for now.

You can download the recipe from conda-forge/hdfs3-feedstock, and change the source to point to your local git clone/branch. If you run conda-build on this, it will make a real conda package in some temporary location (which is echoed to the console) which you can directly conda-install from. Using a local file will not update dependencies, which is probably what you want.


Cannot install on Windows 10 x64 with Node.js 6.11.2

Hello, I receive the following message when trying to install your moduel (npm install nfc-pcsc):
598 silly install printInstalled
599 verbose stack Error<EMAIL_ADDRESS>install: node-gyp rebuild
599 verbose stack Exit status 1
599 verbose stack     at EventEmitter. (C:\job\node\node_modules\npm\lib\utils\lifecycle.js:255:16)
599 verbose stack     at emitTwo (events.js:106:13)
599 verbose stack     at EventEmitter.emit (events.js:191:7)
599 verbose stack     at ChildProcess. (C:\job\node\node_modules\npm\lib\utils\spawn.js:40:14)
599 verbose stack     at emitTwo (events.js:106:13)
599 verbose stack     at ChildProcess.emit (events.js:191:7)
599 verbose stack     at maybeClose (internal/child_process.js:891:16)
599 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
600 verbose pkgid<EMAIL_ADDRESS>601 verbose cwd C:\job\node
602 error Windows_NT 10.0.15063
603 error argv "C:\job\node\node.exe" "C:\job\node\node_modules\npm\bin\npm-cli.js" "install" "nfc-pcsc"
604 error node v6.11.2
605 error npm  v3.10.10
606 error code ELIFECYCLE
607 error<EMAIL_ADDRESS>install: node-gyp rebuild
607 error Exit status 1
608 error Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
608 error Make sure you have the latest version of node.js and npm installed.
608 error If you do, this is most likely a problem with the @pokusew/pcsclite package,
608 error not with npm itself.
608 error Tell the author that this fails on your system:
608 error     node-gyp rebuild
608 error You can get information on how to open an issue for this project with:
608 error     npm bugs @pokusew/pcsclite
608 error Or if that isn't available, you can get their info via:
608 error     npm owner ls @pokusew/pcsclite
608 error There is likely additional logging output above.
609 verbose exit [ 1, true ]
Can you please suggest me how to fix that and install your module.

Hi @vsdigitall,
I think, it is caused by missing required system dependencies for building this library.
Because this library uses Node Native Modules, which are being built (using node-gyp) when installing (fyi I don't provide prebuilt binaries, because it brings more problems than it solves), you need to have installed Python 2.7 and some Visual Studio C++ build tools, as described in node-gyp's installation guide for Windows.
You can install all the required tools and configurations with Microsoft's windows-build-tools using npm install --global --production windows-build-tools from an elevated PowerShell or CMD.exe (run as Administrator) as described in Option 1 of node-gyp's guide.
After that, you can run npm install nfc-pcsc, and it should be installed without any problems.
If not, try restart computer to allow the changes made during windows-build-tools installation to be correctly propagated.

I think, that adding note about these required dependencies would be worthwhile. So, I definitely add more info about it in the docs.
Hope it helps.

Hi @pokusew
I run into simular issue with 32 bit Window 10 env. I installed Python2.7.14, then node-gym and Visual studio 2017 community version. But it seems like I could't build lib pcsclite, it complained that the file "build\pcsclite.vcxproj" doesn't exist after it built at least "addon.cpp  pcsclite.cpp cardreader.cpp win_delay_load_hook.cc" four files. Later I noticed this page, I took your "Option 1" soultion, tried to solve this, I successfully installed<EMAIL_ADDRESS>but after I run "npm install nfc-pcsc" again, the error message was the same :(
Would you mind to take look what went wrong please:
... ...
addon.cpp
pcsclite.cpp
d:\jss\node_modules@pokusew\pcsclite\src\common.h(34): warning C4477: '_snprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 2 has type 'LPVOID' (compiling source file ..\src\pcsclite.cpp<EMAIL_ADDRESS>cardreader.cpp
win_delay_load_hook.cc
d:\jss\node_modules@pokusew\pcsclite\src\common.h(34): warning C4477: '_snprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 2 has type 'LPVOID' (compiling source file ..\src\cardreader.cpp<EMAIL_ADDRESS>C:\Users\Administrator.node-gyp\8.9.1\ia32\node.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0
x1F12B0<EMAIL_ADDRESS>gyp ERR! build error
gyp ERR! stack Error: C:\Program Files\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd D:\JSs\node_modules@pokusew\pcsclite
gyp ERR! node -v v8.9.1
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

Hi @bincheng68,
it seems that it is the same (or at least similar) issue as described in https://github.com/oracle/node-oracledb/issues/280 or perhaps in https://github.com/electron/electron-rebuild/issues/163.
I suggest that you follow this quide. According to it, the following could help:

delete folder C:\Users\Administrator.node-gyp\
try again running npm install nfc-pcsc

If it does't solve the issue, you could try another steps mentioned in that quide.
Please let me know, if it works for you.
I am available for chat here https://discord.gg/bg3yazg.
Hope it helps.

PS Don't forget to star ⭐ my nfc-pcsc library, if you find it useful. 😃 Thanks.

Thank you @pokusew , it's working now :)


Titans

Hii from my teams
We really enjoyed in this hackathon here is my code link
You will find all the detail about our project team members in TITANS-challenge.md file

PLEASE DO NOT DELETE ANY FILE.  Please re-open this PR and re-submit if you wish to. Thanks!


Update cats-effect, cats-effect-laws to 3.3.14 in series/4.x

Updates

org.typelevel:cats-effect
org.typelevel:cats-effect-laws

from 2.5.5 to 3.3.14.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Scalafix Migrations

org.typelevel:{cats-effect,cats-effect-laws}:3.0.0 (created no change)

github:typelevel/cats-effect/v3_0_0?sha=v3.0.0

org.typelevel:{cats-effect,cats-effect-laws}:3.3.0 (created no change)

github:typelevel/cats-effect/v3_3_0?sha=series/3.x

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.typelevel" }
}]

labels: library-update, early-semver-major, semver-spec-major, scalafix-migrations, commit-count:1

Superseded by #1668.


Unable to setup node as nobled is not installed

Go Version of 1.21.0 is installed.
Path Variables are set as per documentation
Make Install is succesfull, but nobled is not installed

Hey @bmalepaty 👋🏻  Thanks for opening this issue!
Could you please confirm if you have your Go path added?
In Zsh this looks something like: export PATH="$PATH:$(go env GOPATH)/bin"

Yes, Go is added to the Path Variable

All these too were executed
export GOROOT=/usr/local/go
export GOPATH=$HOME/go
export GO111MODULE=on
export PATH=$PATH:/usr/local/go/bin:$HOME/go/bin

You need $HOME/go/bin in your path, which it looks like it's not from the screenshot you provided.

Added that too - Still the same issue

Could you try to run make install without the sudo?


aks-preview 0.4.62 - The checksum of the extension does not match the expected value

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
aks-preview
Description of issue (in as much detail as possible)
User failed to install aks-preview extension due to checksum failed.
IcM : https://portal.microsofticm.com/imp/v3/incidents/details/203612575/home
Original issue: https://github.com/Azure/azure-cli-extensions/issues/2302
Actions replay
[2020-09-03 09:31:00] Feature PR  Add acc sgx addon cli support merged.
[2020-09-03 12:58:00] Release PR Release aks-preview 0.4.62  merged.
[2020-09-03 13:01:00] Index PR 1 [Release] Update index.json for extension [ aks-preview ] genereated.

whl (checksum: 52f8c14aae3f9aa76714bdf007976a04037cf1e7d18bf3e83f2cba2a5184ec43) is uploaded to storage

[2020-09-03 14:12:00] Index PR 2 [Release] Update index.json for extension [ aks-preview ] manually trigged.

whl (checksum:<PHONE_NUMBER>9b3aae977c3c0e6263a271b20ea130467d89c0dee19877198f070, override 52fc...) is uploaded to storage

[2020-09-03 14:13:00] Index PR 2 [Release] Update index.json for extension [ aks-preview ] manually closed.

checksum<PHONE_NUMBER>9b3aae977c3c0e6263a271b20ea130467d89c0dee19877198f070 abandoned in index.json

[2020-09-03 17:48:00] Index PR 1 [Release] Update index.json for extension [ aks-preview ] merged.

checksum 52f8c14aae3f9aa76714bdf007976a04037cf1e7d18bf3e83f2cba2a5184ec43 merged into index.json, which cause the conflict.

Summary
The root cause is that we have a manual trigged Index PR which override previous whl file but did not update the index.json file.
How to improve

Never override existing whl file while uploading to storage
pros: less changes in pipeline
cons: need to use a new version after Release PR gets merged.

Change build whl program, if the commit is the same,  make sure the checksum is the same too.
pros: less changes in azdev

Upload whl to an temp storage first, move to final storage after merge index.json PR
pros: do not need to use a new version
cons: more work to do, changed existing process

Refactor current extension release process (create a new process just like current azure-cli ones, can manually trigger or timely trigger.
pros: more natural. solve the checksum problem from the root.
cons: max work to do. The whole release process is changed.

We had an internal discussion and have a conclusion now.
The root cause of this problem is that there are 2 index PRs for one extension at the same time. And there is no need to support 2 index PRs in our extension release process. So we will add a validation for this before uploading whl to storage. In this validation, we will check if there is already an open index PR, if yes, this pipeline will fail and notify Azure CLI team.
And if we actually want to use a new index PR, we can close the old one first and manually trigger a new one.

thanks @arrownj, will you make the change?

The extension release pipeline has been updated.


fix: overflow properties

Description

Checklist

[x] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you linted your code locally prior to submission?

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.39%. Comparing base (0cec4ae) to head (aef0736).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

writer/doc_writer.py
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   98.62%   98.39%   -0.23%
==========================================
  Files           4        4
  Lines         436      437       +1
==========================================
  Hits          430      430
- Misses          6        7       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[dev] Different behavior of "Accept-Encoding" header

Original mentioned here as feedback for the dev mode.

request.headers.get('Accept-Encoding');

Currently the wrangler dev runtime has different behavior for the Accept-Encoding header than a cloud deployed worker. Accessing it returns the actual values of a client (e.g. gzip, deflate, br) which can be misleading as later on those won't be forwarded but always replaced with gzip. Having them aligned helps to be consistent so developers can be aware of that circumstance before running the worker in production.

ok - from my investigation when sending Accept-Encoding: gzip, deflate, br as a request header
addEventListener('fetch', event => {
  event.respondWith(handleRequest(event.request))
})

async function handleRequest(request) {
  let accept_encoding = request.headers.get("Accept-Encoding")
  console.log(accept_encoding)
  let response = await fetch("https://example.com")
  let content_encoding = response.headers.get("Content-Encoding")
  console.log(content_encoding)
  return response
}

command
console.log(accept_encoding)
console.log(content_encoding)
observed Content-Encoding response header

wrangler dev
gzip, deflate, br
null
Header does not exist

wrangler preview
gzip, deflate, br
null
Header does not exist

wrangler publish
gzip
null
br

This will be fixed when we release the stuff in #1085 - i just tested wrangler dev with source built from branch avery/edge-dev-server and i get the following:

command
console.log(accept_encoding)
console.log(content_encoding)
observed Content-Encoding response header

wrangler dev
gzip
null
br

this is the same you see when you publish a worker 😄

The issue is resolved with the recent change of using the latest edge workers.


Bot doesnt play

I click on the play button and I play the level but immediately stops playing. The game gets very laggy and then it goes back to a normal framerate. Help?

Are you trying to record a macro with ReplayBot? If you are, press the Record button instead of the Play button. ReplayBot prevents user inputs while playing a macro to retain the bot's accuracy.


How to highlight multiple values ?

Hi everyone,
First thanks for this incredible work to import MPandroidChart in flutter !
Is it possible to highlight several values ?
Like we can do in MPAndroidChart with
chart.highlightValues(new Highlight[] {h1, h2});
Arno

It is supposed to be like
LineChartController.painter.highlightValues([ h1, h2 ]);

But I couldn't get that to work

It is supposed to be like
LineChartController.painter.highlightValues([ h1, h2 ]);

But I couldn't get that to work

For a single value I found the following was also necessary:
controller.state?.lastHighlighted =
            highlights.length == 0 ? null : highlights[0];

The state must be updated because the painter is recreated every time build is called on the chart.

@Arnooow have you find any solution to this?

It is supposed to be like
LineChartController.painter.highlightValues([ h1, h2 ]);

But I couldn't get that to work

I did add this to the line_chart_controller.dart,
void highlight(List<Highlight> highlights) {
    painter?.highlightValues(highlights);
    state?.lastHighlighted = highlights.length == 0 ? null : highlights[0];
    state?.setStateIfNotDispose();
  }

yet it didn't seem to work


mobilevlm_v2 with lora

Dear author, I would like to inquire whether mobilevlm_v2 can be trained using the LoRa method for language models, and if so, how significant is the impact on accuracy?

Sure, under setting of mobilevlm v2 with increasing data samples, using LoRA drops 1-2 points on average performance compared with full parameter fintuning.

Hi, we are closing this issue due to the inactivity. Hope your question has been resolved. If you have any further concerns, please feel free to re-open it or open a new issue. Thanks!


P: Get rid of some bad phenos still showing up e.g. "chronic"

Should be some sub-tree of the HPO DAG to eliminate (didn't we already do this?)

The term "chronic" (HP:0011010) is a descendant of "Clinical Modifier" (HP:0012823).  We should limit to descendants of "Phenotypic abnormality" (HP:0000118).
Check out http://compbio.charite.de/phenexplorer/ for a decent tool for exploring HPO.  The "ontology" tab lets you browse the ontology structure.

Ok- so we / Robin did do the subtree pruning.   It was actually an error in one of our source files.
In the file we get from Charite, HP:0002582: Chronic atrophic gastritis has a reference ("xref") to the MeSH entry for "Chronic", which in a post-processing script we add as a synonym.  I looked and it seems like these "xref" fields don't add much- they are either the same name as the HPO term, one of its synonyms, or erroneous (as in this case), so I just took this step out
For reference: our process is that we take in some file from compbio.charite.de- onto/raw/hpo.obo- which we then parse using onto/parse_hpo.py -> onto/data/hpo_phenotypes.tsv; then, before every run of pheno_extract_candidates we run another preprocessing script which outputs to pheno_terms.tsv
Clearly this processing should be simplified, but I think we'll accomplish this when we add UMLS #10

Note @Colossus that the script needs to be rerun; instead of rerunning everything in make_all.sh just do: cd onto && rm data/phenotypes.tsv && python parse_hpo.py raw/hpo.obo data/hpo_phenotypes.tsv

@ajratner I get: rm: cannot remove `data/hpo_phenotypes.tsv': No such file or directory and the file is not created afterwards

That's odd, I would think it would have been there- have you ever run the
pheno extractor from your repo?  If so this file would need to be there, or
else an error should have been thrown, or else something else going on...
Either way, just don't remove it, run the python script to create it
On Wed, Jul 15, 2015 at 10:09 AM Colossus<EMAIL_ADDRESS>wrote:

@ajratner https://github.com/ajratner I get: rm: cannot remove
`data/hpo_phenotypes.tsv': No such file or directory and the file is not
created afterwards
—
Reply to this email directly or view it on GitHub
https://github.com/HazyResearch/dd-genomics/issues/24#issuecomment-121681852
.


Improve mentions with NIP21

I love that Astral is explicit about mentions and allows me to edit them. NIP21 now lets you fix some awkwardness though:

[ ] Allow me to remove all mentions - If I want to reply to a thread mentioning yet somebody else, I want to remove all reply-mentions first - not one by one.
[ ] Allow me to add mentions in the mentions list without having to reference them in the content.
[ ] Allow me to remove mentions without removing the reference in the content - nip21 allows that. The content changing when I click [x] on a mention is weird.

Actually ...
I think the ideal way to represent this would be to have :bell: @ Monlovesmango in the content with the :bell: turning into :no_bell: when you click it inline and the "mentions" input hidden by default as an advanced feature. "edit 12 mentions"-button.


Major Problem with PHONE masking code.

I was having major issues with the phone masking code.  I was able to reproduce on your demo.

@VagyokC4 ,
You mean that the unmasking is totally useless?

@RobinHerbots  Yes.  The normal control seems to work well.  Its when I use the phone mode that I run into issues.  I have another issue but I haven't been able to isolate it correctly yet, so I haven't posted it, but it is with the phone control and appears on my production environment, while browsing with a mobile phone.  It's as if the mask does not work, and numbers get scrambled (very weird)

@VagyokC4 ,
I will enhance the unmasking for the phone mask.  For mobile I'm working on some part of it.  Follow up coming commits.

Remove Phone alias #1981


Can't run SOCI tests under Windows using ODBC data source

Environment:
Windows 8.1. 64 bit
ODBC and MS SQL
MSVC 2013
Had a problem trying to run tests using command 'ctest -VV -C Debug' for ODBC soci build. Tests ran but each asked about the data source (see attached screenshot) and after specified the password. Because there are many tests it makes it not practical to run them as one has to enter same information over and over again (I gave up after entering this about 5 times). Consider changing tests to accept a db connection string that includes driver name, server, login and password. Something like:
Driver={SQL Server};Server=<IP_ADDRESS>\SPSQL;Uid=sa;Pwd=Master10

Historically, ODBC tests assume use of FILEDSN, see tests/odbc/test-mssql.dsn.
Perhaps it could be improved with the use of SOCI 3.2+ feature of connection_parameters.

@mloskot Well, I suspect, the problem almost in add_test :)
      add_test(${TEST_TARGET}
        ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${TEST_TARGET}
        ${${TEST_CONNSTR_VAR}})

here we got
-- SOCI_ODBC_TEST_ACCESS_CONNSTR            = test-access.dsn
without full path to dsn.
Test runs out of the source and test driver unable to find this file.
Perhaps we need pass connection string as absolute path to dsn.
Will check it soon.

This is default setting, legacy from previous tests configuration where it was assumed that user specifies FILEDNS location as CMake argument. That's exactly what Travis CI did
cmake \
-DSOCI_ODBC_TEST_MYSQL_CONNSTR="FILEDSN=${PWD}/../backends/odbc/test/test-mysql.dsn;"

See https://github.com/SOCI/soci/blob/release/3.2/bin/ci/script_odbc.sh

well, but for Windows it'll not work, unless you're using msys shell.

@mloskot Ideally, the best way to use cmake is to avoid usage of platform specific scripts
so command sequence
cmake ..
cmake --build .
ctest -VV

should work on any platform.
But real world is far from ideal :)

@picant in you case the better way is provide path to MSSQL DSN file as @mloskot suggested during project generation.
for example
cmake -DSOCI_ODBC_TEST_MSSQL_CONNSTR= < path to DSN with your connection parameters > .......

This should save your time with MSSQL.
AFAIK, other backends tests can be skipped using ctest command line.
So anyway it can be closed as WAE (work as expected).

Closing.
If anyone would have suggestion how to improve running the ODBC tests, please submit a new PR. Thanks.


609 enable lusd collateralization

Resolves #609

Is there an issue with the CI

Is there an issue with the CI? I'm on mobile so my capabilities are limited.

"Compare Test Coverage" is failing, but I have no idea what that is for.

Is there an issue with the CI? I'm on mobile so my capabilities are limited.

"Compare Test Coverage" is failing, but I have no idea what that is for.

Can you verify that the percentage of test coverage has not decreased with this pull request?
That is the intended purpose of that CI.

It doesn't even get that far. Just Exit code 1

It doesn't even get that far. Just Exit code 1

I'll check it in few hours

@hashedMae
The CI action "Compare Test Coverage" fails due to decreased test coverage.
If you check the "Print coverages" step here you may see the development branch test coverage and PR's test coverage:
Development branch coverage: 38.17
PR branch coverage: 35.82

This PR makes the coverage error more verbose
Pls add more tests for the "LUSD collateralization" feature

There are a few unresolved conversations. Do you know how to find them conveniently?

You need to resolve all outstanding comments before GitHub merges.

Not sure about this curve3PoolTokenAddress

Not sure about this curve3PoolTokenAddress

https://github.com/ubiquity/ubiquity-dollar/blob/8db0891b6488e8262ec7c269889e6a7577679b44/packages/contracts/src/dollar/facets/ManagerFacet.sol#L252 :monocle_face: strange have you tried clean up and regenerate types again ?


Run the test in 'make prepublish' to prevent the regression to lack the expexted file

This adds the regression test for #332

This change is

bors r+


[New Port Request] proxygen

Library name:Proxygen
Library description:Proxygen: Facebook's C++ HTTP Libraries
Source repository URL:https://github.com/facebook/proxygen
Project homepage (if different from the source repository):https://github.com/facebook/proxygen
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

Duplicated to https://github.com/microsoft/vcpkg/issues/1495.


Example for STFTSpectrogram layer

After discussion on the contribution of the STFTSpectrogram layer (PR: 20313), I added a code example of using this layer in various modes.

@fchollet I resolved all the comments.


max_number_of_steps ignored in Distributed Layout?

It looks like the argument max_number_of_steps is ignored or has unexpected behavior in DistributedLayout?
I set the number of 10 million and the algorithm runs for well over (currently at 50 million). I assumed that max_number_of_steps specifies how many environment steps to run an algorithm before terminating everything (actors, evaluators, learner, etc.). Is that incorrect?

From a look at distributed_layout, it does look like it used to create a coordinator that knows how to terminate the program. Are you using one of the distributed agents in Acme and getting this behavior?

I am using a a class that's derivative of R2D2. The only change I made was to overwrite make_learner for a custom loss function so it should behave as normal?
This is what the new builder looks like. I am using the learning_lib from the DQN Jax agent. Maybe that breaks something?
class CustomBuilder(r2d2.R2D2Builder):
  """CustomBuilder agent Builder. Agent is derivative of R2D2 but may use different network/loss function
  """
  def __init__(self,
               networks: r2d2_networks.R2D2Networks,
               config: r2d2_config.R2D2Config,
               logger_fn: Callable[[], loggers.Logger] = lambda: None,
               LossFn: learning_lib.LossFn=R2D2Learning,
               LossFnKwargs=None):
    super().__init__(networks=networks, config=config, logger_fn=logger_fn)

    LossFnKwargs = LossFnKwargs or dict()
    self.loss_fn = LossFn(**LossFnKwargs)

  def make_learner(
      self,
      random_key: networks_lib.PRNGKey,
      networks: r2d2_networks.R2D2Networks,
      dataset: Iterator[reverb.ReplaySample],
      replay_client: Optional[reverb.Client] = None,
      counter: Optional[counting.Counter] = None,
  ) -> core.Learner:

    # The learner updates the parameters (and initializes them).
    return learning_lib.SGDLearner(
        network=networks,
        random_key=random_key,
        optimizer=optax.chain(
            optax.clip_by_global_norm(self._config.max_gradient_norm),
            optax.adam(self._config.learning_rate, eps=1e-3),
        ),
        target_update_period=self._config.target_update_period,
        data_iterator=dataset,
        loss_fn=self.loss_fn,
        replay_client=replay_client,
        replay_table_name=self._config.replay_table_name,
        counter=counter,
        num_sgd_steps_per_step=self._config.num_sgd_steps_per_step,
        logger=self._logger_fn())

This looks alright. Have you checked the logs? The coordinator should print out the number of steps seen so far. If not something is probably wrong.

@ethanluoyc thanks a lot for helping debug this!
@wcarvalho I don't believe we've experienced this problem before. Did you manage to resolve it?
Could you try the following things to help debug this:

Can check if you can reproduce this with the standard DistributedPPO example. This uses the same layout, so if it works, then the problem is not in DistributedLayout.
Can you make sure that the max_number_of_steps is properly propagated to the DistributedLayout constructor? I noticed that neither the R2D2 example nor the R2D2 Agent are passing max_number_of_steps to the layout.

I believe this was an error in my code. My apologies.


Add google analytics tracking code

To inform on how we can make improvements to FreeStyle, I've added some tracking code to determine how often and what sections of FreeStyle are in use.

Hey,
The code looks fine to me but should we place this immediately inside the head? Is it still the case the higher up in the page the code the better?

The docs say

immediately after the  tag on every page of your site

https://developers.google.com/analytics/devguides/collection/gtagjs/
So I assumed it was the first thing inside the body element, as it's invalid to have anything out-with the head/body

My mistake, the admin dashboard says

Copy and paste this code as the first item into the

Will update

Going on the snippet being correct so 👍 from me.


(react-native) TypeError Properties can only be defined on Objects

We have an react-native app with 25k+ users and have gotten over 1000 crashes over the last 3 months reported in bugsnag. The crash typically happens within 1 sec of startup, but sometimes it takes a few seconds. We have not been able to reproduce this in development. It is happening on both ios and android. The only thing we have to go off of is the stacktrace provided by bugsnag:
iOS bugsnag stack trace:
TypeError Properties can only be defined on Objects.
    [native code] defineProperty
    node_modules/react-redux/lib/connect/mergeProps.js:54:21
    node_modules/react-native/node_modules/@babel/runtime/helpers/typeof.js:17:17 _get
    node_modules/react-redux/node_modules/hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js:100:11
    node_modules/react-native/node_modules/@babel/runtime/helpers/typeof.js:17:17 _get
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 res
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 _toConsumableArray
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 _defineProperties
    [native code] value

Android bugsnag stack trace:
TypeError Properties can only be defined on Objects.
    [native code] defineProperty
    node_modules/react-redux/lib/utils/isPlainObject.js:20:19
    node_modules/react-native/node_modules/@babel/runtime/helpers/typeof.js:17:17 _get
    node_modules/react-redux/lib/components/connectAdvanced.js:130:29
    node_modules/react-native/node_modules/@babel/runtime/helpers/typeof.js:17:17 _get
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 _typeof2
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 RCTDeviceEventEmitter
    node_modules/react-native/node_modules/@babel/runtime/helpers/toConsumableArray.js:8:59 _defineProperties
    [native code] value

Which leads me to believe it has something to do with react-redux
here are the dependencies in the package.json:
"dependencies": {
    "@emotion/core": "^10.0.16",
    "@fragaria/address-formatter": "^2.0.5",
    "@react-native-community/art": "^1.0.3",
    "@react-native-community/async-storage": "^1.8.0",
    "@react-native-community/cameraroll": "^1.3.0",
    "@react-native-community/clipboard": "^1.2.2",
    "@react-native-community/datetimepicker": "^2.1.0",
    "@react-native-community/masked-view": "^0.1.6",
    "@react-native-community/netinfo": "^5.9.0",
    "@react-native-firebase/app": "^6.4.0",
    "@react-native-firebase/crashlytics": "^6.4.0",
    "@react-native-firebase/messaging": "^6.4.0",
    "@react-navigation/bottom-tabs": "^5.1.1",
    "@react-navigation/drawer": "^5.0.6",
    "@react-navigation/native": "^5.0.9",
    "@react-navigation/stack": "^5.1.1",
    "apisauce": "^0.14.3",
    "bugsnag-react-native": "^2.20.0",
    "bugsnag-sourcemaps": "^1.0.4",
    "emotion-theming": "^10.0.14",
    "lodash": "^4.17.10",
    "moment": "^2.22.2",
    "moment-round": "^1.0.1",
    "prop-types": "15.6.0",
    "react": "16.11.0",
    "react-native": "0.62.2",
    "react-native-app-auth": "^5.0.0",
    "react-native-audio-recorder-player": "^2.4.3",
    "react-native-call-detection": "^1.9.0",
    "react-native-camera"<EMAIL_ADDRESS>    "react-native-config": "^0.12.0",
    "react-native-device-info": "^5.0.0",
    "react-native-fast-image": "^7.0.2",
    "react-native-geolocation-service": "^4.0.0",
    "react-native-gesture-handler": "^1.6.0",
    "react-native-google-places-autocomplete": "^1.4.1",
    "react-native-intercom": "^13.1.0",
    "react-native-keyboard-aware-scroll-view": "^0.9.1",
    "react-native-maps": "0.26.1",
    "react-native-modal": "^11.4.0",
    "react-native-notifications": "^3.1.2",
    "react-native-open-maps": "^0.3.4",
    "react-native-permissions": "~1.1.1",
    "react-native-pie": "^0.6.1",
    "react-native-progress": "^4.1.2",
    "react-native-rate": "1.1.10",
    "react-native-reanimated": "^1.7.0",
    "react-native-safe-area-context": "^0.7.3",
    "react-native-screens": "^2.0.0-beta.10",
    "react-native-snap-carousel": "^3.8.4",
    "react-native-sound-player": "^0.10.3",
    "react-native-splash-screen": "^3.2.0",
    "react-native-svg": "^12.0.3",
    "react-native-swipe-list-view": "^2.0.3",
    "react-native-vector-icons": "6.6.0",
    "react-native-video": "^4.4.5",
    "react-native-video-controls": "^2.6.0",
    "react-native-webview": "^8.1.1",
    "react-redux": "^7.1.0",
    "redux": "^4.0.5",
    "redux-logger": "^3.0.6",
    "redux-mock-store": "^1.5.4",
    "redux-persist": "^6.0.0",
    "redux-saga": "^1.1.3",
    "reselect": "^4.0.0",
    "rn-fetch-blob": "^0.12.0"
  },
  "devDependencies": {
    "@babel/core": "^7.6.2",
    "@babel/plugin-proposal-class-properties": "^7.4.0",
    "@babel/preset-env": "^7.4.3",
    "@babel/runtime": "^7.9.6",
    "@storybook/addon-actions": "5.1.11",
    "@storybook/addon-knobs": "5.1.11",
    "@storybook/addon-links": "5.1.11",
    "@storybook/addon-notes": "5.1.11",
    "@storybook/addon-ondevice-actions": "5.1.11",
    "@storybook/addon-ondevice-knobs": "5.1.11",
    "@storybook/addon-ondevice-notes": "5.1.11",
    "@storybook/addon-storyshots": "5.1.11",
    "@storybook/addons": "5.1.11",
    "@storybook/react-native": "5.1.11",
    "babel-eslint": "^10.0.2",
    "babel-jest": "^24.9.0",
    "babel-loader": "^7.1.5",
    "babel-plugin-module-resolver": "^3.2.0",
    "babel-polyfill": "7.0.0-beta.3",
    "eslint": "^5.16.0",
    "eslint-config-airbnb": "^13.0.0",
    "eslint-import-resolver-babel-module": "^5.1.0",
    "eslint-plugin-import": "2.2.0",
    "eslint-plugin-jsx-a11y": "2.2.3",
    "eslint-plugin-react": "7.12.4",
    "jest": "24.9.0",
    "jest-plugin-context": "^2.9.0",
    "jetifier": "^1.6.4",
    "metro-react-native-babel-preset": "^0.58.0",
    "react-addons-test-utils": "~15.4.1",
    "react-dom": "16.8.3",
    "react-native-testing-library": "^2.1.0",
    "react-test-renderer": "^16.13.1",
    "wd": "^1.11.4"
  }

Any clues as to what the issue may be?

Hmm.  Never seen this one before.
Looking at the last line of the stack trace in the published code here:
<EMAIL_ADDRESS>it's just Babel implementing default export:
var _default = [whenMergePropsIsFunction, whenMergePropsIsOmitted];
exports["default"] = _default;

The isPlainObject one is even weirder, because line 20 is just a comparison:
"use strict";

exports.__esModule = true;
exports["default"] = isPlainObject;

/**
 * @param {any} obj The object to inspect.
 * @returns {boolean} True if the argument appears to be a plain object.
 */
function isPlainObject(obj) {
  if (typeof obj !== 'object' || obj === null) return false;
  var proto = Object.getPrototypeOf(obj);
  if (proto === null) return true;
  var baseProto = proto;

  while (Object.getPrototypeOf(baseProto) !== null) {
    baseProto = Object.getPrototypeOf(baseProto);
  }

  return proto === baseProto;  // this is line 20 here
}

So, I don't see anything we can do about this, or anything that's "obviously our fault" here code-wise that we could actually fix in some way.

Maybe you're compiling your code with some funky webpack config?
On Tue, 28 Jul 2020, 19:27 Mark Erikson<EMAIL_ADDRESS>wrote:

Hmm. Never seen this one before.
Looking at the last line of the stack trace in the published code here:
<EMAIL_ADDRESS>it's just Babel implementing default export:
var _default = [whenMergePropsIsFunction, whenMergePropsIsOmitted];exports["default"] = _default;
The isPlainObject one is even weirder, because line 20 is just a
comparison:
"use strict";
exports.__esModule = true;exports["default"] = isPlainObject;
/** * @param {any} obj The object to inspect. * @returns {boolean} True if the argument appears to be a plain object. */function isPlainObject(obj) {
if (typeof obj !== 'object' || obj === null) return false;
var proto = Object.getPrototypeOf(obj);
if (proto === null) return true;
var baseProto = proto;
while (Object.getPrototypeOf(baseProto) !== null) {
baseProto = Object.getPrototypeOf(baseProto);
}
return proto === baseProto;  // this is line 20 here}
So, I don't see anything we can do about this, or anything that's
"obviously our fault" here code-wise that we could actually fix in some way.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reduxjs/react-redux/issues/1620#issuecomment-665171831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWFL7PNERJENWHFI73T7X3R54C6TANCNFSM4PKWB4AA
.

Thanks for your input.
Yes, it seems likely to be something with babel. But Why only intermittent crashes then?

Sorry, no idea :(
Unfortunately, there doesn't seem to be anything actionable here for us, so I'm going to go ahead and close it.  If you do figure out something, let us know.


[feat] Allow to change provisioning entries name/loc even when after they have a node binded

Ref: https://github.com/zwave-js/zwave-js-ui/discussions/3694#discussioncomment-9318701

We are running into this. When we notice a typo or want to change the name or location of a SmartStart entry that is already assigned the edit button is not present. Implementing this would make it easy to update the name or location in Home Assistant by simply editing the SmartStart entry then excluding the device and SmartStart would then re-include the device using the updated name/location.
Thank You

@AlCalzone Should this be possible?

I think it's fine. This info is just for the user anyways.

@AlCalzone --
Just upgraded to v9.14.0 and tested this. Don't see the edit button active after upgrade on all our SmartStart entries which are already assigned to nodes. Have cleared our browser cache with same results. Should the edit button become active on in-use entries after this upgrade? Let me know if you need debug information and if so where to send it. Thanks!

I can see it, could you double check the version please?

I can see it, could you double check the version please?

LOL sorry just saw that I pushed the commit after 9.14.0 release. Please wait for 9.14.1 or, if using docker, use master tag isntead


Feature Request - Saving Image + Label file within DetectNet-Camera.cpp

I think it would be really useful for certain use cases to be able to save an image plus the label file on command.
That way we can build a dataset that can then be adjusted/fixed before adding it back to the original dataset used to create the model.  To retrain the model with the more data.
In my case I'm actually using the object detection boundary boxes to do a separate classification network.  For example if I had hundreds of toy cars I would want to first find the cars using detectnet, and then I'd want to run a separate classification on the cars to determine the exact type. Like a Porsche 911 or a Ford F150.
I'm trying to do this myself, but of course I immediately ran into an issue due to my lack of knowledge with CUDA (never used it before). Where I'm confused about the GPU memory space versus the CPU memory space. I'm using the saveImageRGBA function that's used within detectnet-console.cpp, but it looks like its meant for an data within the GPU memory. For detectnet-camera it looks like the frame gets captured to shared image space, and then it gets converted to RGBA within the GPU space.  I get a segmentation fault when I try using the saveImageRGBA function.

Were you able to achieve this?
I am trying to do the same. I guess the imgRGBA needs to be copied to CPU memory using cudaMemcpyDeviceToHost, so as to be able to use the saveImageRGBA function.

If you make the change camera->ConvertRGBA(imgCUDA, &imgRGBA, true), then imgRGBA will be zeroCopy shared memory that you can access from CPU without needing cudaMemcpy.  See here in the header:
https://github.com/dusty-nv/jetson-inference/blob/f41f1c06f8fd31e17069d69f5822e0864026ac2f/util/camera/gstCamera.h#L58


nodePackages.@angular/language-server: init at 18.2.0

Description of changes
Adds the angular language server to nodePackages for neovim users managing their own lsps via extraPackages.
homepage: https://github.com/angular/vscode-ng-language-service#readme
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for your first contribution!
It's a general consensus on nixpkgs to no longer add packages to nodePackages, and instead prefer to add them as standalone packages: https://github.com/NixOS/nixpkgs/issues/229475
I thinks this should be better communicated....
angular/language-server is packaged with yarn, I assume you could use the newly added yarn-specific hooks to package it: https://nixos.org/manual/nixpkgs/unstable/#javascript-yarn

My bad I wasn't aware of that decision and was following the documentation here. Would it be useful to open a documentation PR to add a reference to issue #229475 within the language-frameworks javascript section?

I would be happy to package it via yarn. Would you prefer that I do that on another branch and PR and make reference to this one, or would it be better to revert my commit and continuing working on the same branch/PR?

2. Would you prefer that I do that on another branch and PR and make reference to this one

that would be fine

or would it be better to revert my commit and continuing working on the same branch/PR?

You can continue this PR but it must be force pushed. We want a cleanish history.

My bad I wasn't aware of that decision and was following the documentation here. Would it be useful to open a documentation PR to add a reference to issue

Ref: https://github.com/NixOS/nixpkgs/issues/319341

Reopening PR as it's been packaged as a derivation with mkYarnPackage.


Recursive conditions "Cond1(Cond2(VAL))"

Like area(UI(abd),UI(cd))

You can customize it to a degree.
Example:
{'SPELL_NAME', 'player.area(40).enemies>UI(x_ENE)'},

But going even further and customizing the area function in itself would be cool.
Like this:
{'SPELL_NAME', 'player.area(xVAR).enemies>UI(x_ENE)'},

xVAR is the same as UI(xVAR)

at this point, i could enable this with a single line, i just dont know if it would break anything yet, thats why i havent done so already...
just saying its now forgotten 👍

No Risk, No Gain ..
"It would be great if you  direct us to how to do it and let us take the risk

@Noelpqr
https://github.com/MrTheSoulz/NerdPack/blob/master/system/dsl.lua#L102
bellow that line add
Args = DSL.Parse(Args, Spell, Target)


Question about connector with b2

Hi there, thanks for putting this repo together.
In the trino-b2 example the readme mentions the file core-site.xml but it is not used in the docker compose per my understanding.
Is that correct or should it be included somewhere?
Thanks.

Hi @nsoria1 - you're correct. I'll remove it from the repo.

Actually, I discovered that we need core-site.xml with Apache Hive 4.0.0. PR incoming...

See https://github.com/bitsondatadev/trino-getting-started/pull/50

Thanks a lot @metadaddy - looks like that was required because I was unable to get the docker compose up and running for that example

You're welcome, @nsoria1! BTW, you might want to join the Trino Slack channel. I'm metadaddy there, too, and I'm always happy to chat about anything Backblaze B2-related.

@bitsondatadev Could you close this one, please?


HBASE-26477 Fix MiniMapReduceCluster failure under Java17

https://issues.apache.org/jira/browse/HBASE-26477

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

It seems that the failed UT is not related to the changes.

Here is the only JVM options for this case. After adding this option, the UT passed locally.

Adding this option will have problem under Java version 8 (not sure if is works for java 11) and will crash the JVM. Maybe we should not set it as default in hadoop MR if we still support java8.

Ok. I guess it would be a good idea to update the doc. For example, in the Java version here: https://hbase.apache.org/book.html#basic.prerequisites where we can add the required java options for a production MR cluster.


Improve libraries requirements

Click as a dependency is only required for the CLI.
The newest version of boto3/botocore do not have a different behaviour on the way it creates the client session.
Allowing newer versions of boto3 and botocore shouldn't be an issue.
PR Overview

[n ] This PR requires new unit tests [y/n] (make sure tests are included)
[y ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[y ] This PR is backwards compatible [y/n]
[ n] This PR changes the current API [y/n]

Yes indeed @sankalpbhatia
But click is still something that's not necessary for this as a library, therefore I believe should be moved to the extras as suggested.

I agree. Would it be possible for you to rebase with recent changes and update this PR?

@sankalpbhatia Hello
Been a long time now. Any plans to review now the rebase has been done?
Thank you,

Thanks for revising. I have merged the review.

@JohnPreston The commit seems to have broken the existing tests. My bad for not noticing it earlier. Would you have bandwidth to fix these? If not, the service team will need to revert this and rework on it with a fix.

Hi @JohnPreston We had to revert this commit as it was failing our tests. It was a miss from me to not notice that. Would you be willing to re-work on this?


Remove mesh specific event raising methods from spatial awareness system

The spatial awareness system previously was exposing mesh specific methods to raise events to registered listeners. This is not a sustainable implementation in that future spatial observers will wish to raise events for other types of data (ex: planes, points).
To reduce the likelihood of future breaking changes / observer incompatibilities, this breaking change is being made,

Observers now no longer call a RaiseAdded, etc methods on the spatial awareness system interface
Observers wishing to inform client code (should be all of them) will now call the spatial awareness system's HandleEvent method and provide the data and the delegate to call.
NO changes are required of existing client code.

While working on this change, a race condition was discovered in the spatial awareness demo scene where, when using the model observer, events were not received. This has been resolved.
Tested using the spatial awareness demo scene running in editor and deployed to a HoloLens (viewing the event messages in the Visual Studio debugger)

/azp run mrtk_pr

/azp run mrtk_pr


Update Package.swift

Moved firebase dependency to one that has spm
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

Read the contribution guidelines.
If this has been discussed in an issue, make sure to mention the issue number here.  If not, go file an issue about this to make sure this is a desirable change.
If this is a new feature please co-ordinate with someone on FirebaseUI-Android to make sure that we can implement this on both platforms and maintain feature parity.

@hacx, thanks for the contribution! Please sign the CLA in googlebot's comment above, then we can review the code and figure out what's causing the build failure.


Installed on my mac, but doesn't work at all ...

No matter how many times I reload, it does nothing. I'm running High Sierra Mac osx ...

None of the snippets appear when you type? Are other snippets working for you? Are there any error messages when the package loads?
I made this at a hackathon a long time ago at this point. I made it work for comments only in c, objective c, c++ and java code. Are you working on a file of that type?

Thanx for your reply. Yes, snippets from other extensions work fine. And
I'm working on a React project.
On Thu, Aug 16, 2018 at 1:15 AM, Tobiah Zarlez<EMAIL_ADDRESS>wrote:

None of the snippets appear when you type? Are other snippets working for
you? Are there any error messages when the package loads?
I made this at a hackathon a long time ago at this point. I made it work
for comments only in c, objective c, c++ and java code. Are you working on
a file of that type?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TobiahZ/vscode-comment-snippets/issues/8#issuecomment-413268226,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQCZ97mfjFpBBZM2rgPWEE3iMIZiBbsks5uRFcwgaJpZM4V7t5H
.


Cannot find 'filename' on error when debugging

An odd behavior has emerged, particularity when running the debugger that on error VS Code is looking for a dependency in a folder referenced to the working directory rather then the installation directory of python.
The simplest code snippet I have is the following:
`
import pandas as pd
import csv
import numpy as np
def loadAsin(path):

	load_list = []

	with open(path, 'r', newline='') as csvfile:
    		csvstream = csv.reader(csvfile)
    		for row in csvstream:
        		load_list.extend(row)

	try:
    		load_list.remove('product_id')
	except:
        	pass

	return load_list

def main():
	filepath = 'asin_sample.csv'

	asin_list = loadAsin(filepath)
	print(len(asin_list))

	#asin_df = pd.Series(asin_list)
	asin_df = pd.DataFrame(asin_list)
	asin_df = pd.Series(pd.unique(asin_df))

	print(len(asin_df))
	print(asin_df.head())
	asin_df.to_csv('asin_unique_sample.csv', index=False)

if __name__ == "__main__":
	main()

`
which produces an error:
"Unable to open 'hastable_class_helper.pxi': File not found (file:///{working directory}/pandas/_lib/hastable_class_helper.pxi).
This behavior is not present when running in the interpreter, rather get the correct error msg displayed in the console.
'ValueError: Buffer has wrong number of dimensions (expected 1, got 2).
When using pd.Series there is no error and the code executes fine.

We are going through old issues and we noticed that no one from the team had replied to this issue. I want to apologize for the oversight and to let you know that the issue was reviewed by the team and triaged (as shown by the labels applied to this issue).

Closing as this should be fixed. If it isn't, feel free to file a new issue 😊


Provide support for multiple writes per second within single board instance

Currently running the same write repeatedly one-after-the-other raises an error:
board.pin_write(df, "cool_pin", type="csv")
board.pin_write(df, "cool_pin", type="csv")

pins.errors.PinsError: Attempting to write pin version to [...]/20240720T080112Z-320a1, but that directory already exists.

Presumably this is just because both writes occurred in the same second, so they get the same filename. I expect this sort of thing could come up when people are using pins in a pipeline that unexpectedly runs really quickly for whatever reason. Maybe that's an abuse of pins 🤷
I reckon the individual board object can keep track of when the most recent write was and impose a within-object rate limiting to cope with this. In theory, you could have a separate rate limit for each pin but that's just added complexity.
All that's needed is a new class variable which stores the most recent write time, a conditional check and a time.sleep call, probably also a call to inform since this is an unusual case.
With all that said, my main motivation for this is just to make testing easier - but I think it also has the benefit of avoiding a somewhat cryptic error message and adding some robustness.

In the R package, we handle this by mocking the version name in many tests. For example, here:
https://github.com/rstudio/pins-r/blob/de47c3141d97020e9f4a6a2e93d5823bc649105b/R/testthat.R#L133

That sounds reasonable. I think then I'll look to add some documentation about this limitation in this section:
https://rstudio.github.io/pins-python/get_started.html#how-and-what-to-store-as-a-pin
It currently gives advice against using pins for concurrent write from multiple processes, and I think this is a similar case that can just be added explicitly.
For context, I am working on #241, and I'm trying to create the equivalent of this test:
https://github.com/rstudio/pins-r/blob/de47c3141d97020e9f4a6a2e93d5823bc649105b/R/testthat.R#L165-L173
I'm interested how this test passes in R without dedicated rate-limiting.
In Python, I could monkey-patch the board after the initial write, to modify the name of a pin version after the fact. That seems quite unpleasant within the test itself, but it might be tolerable in a few tests.
Another option is to temporarily mock the datetime (!) during the initial write.

Aha, the time.sleep approach is already being used in the test suite:
https://github.com/rstudio/pins-python/blob/70380b4532f3778e4777888507a49c2d1cab1ae8/pins/tests/test_boards.py#L351-L355

One issue I've noticed is that running the get_started.qmd notebook suffers from this issue, since it has back-to-back pin_write calls. Perhaps the solution is created= arguments, but this muddies the illustration.


Update alter-database-scoped-configuration-transact-sql.md

This change may not be correct, but it's unclear to me what the author's intent was.
There is a DMV called sys.dm_exec_query_stats and one called sys.dm_exec_query_statistics_xml, but not one called sys.dm_exec_query_statistics.
Since sys.dm_exec_query_stats doesn't store query plan XML, but sys.dm_exec_query_statistics_xml does, I can make an Educated Guess© about it.

@markingmyname

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Chapter 7 Build Issue

Ran into an issue with trying to build chapter 7
cd C:\chapter7
bower update
pulp build

I got the following error message
Error found:
in module Data.AddressBook.Validation
at C:\chapter7\src\Data\AddressBook\Validation.purs line 31, column 3 - line 38, column 6

  Could not match type

    { unicode :: Boolean
    , sticky :: Boolean
    , multiline :: Boolean
    , ignoreCase :: Boolean
    , global :: Boolean
    }

  with type

    RegexFlags

while checking that type { unicode :: Boolean
                         , sticky :: Boolean
                         , multiline :: Boolean
                         , ignoreCase :: Boolean
                         , global :: Boolean
                         }
  is at least as general as type RegexFlags
while checking that expression { unicode: false
                               , sticky: false
                               , multiline: false
                               , ignoreCase: false
                               , global: false
                               }
  has type RegexFlags
in value declaration phoneNumberRegex

See https://github.com/purescript/purescript/wiki/Error-Code-TypesDoNotUnify for more information,
or to contribute content related to this error.

* ERROR: Subcommand terminated with exit code 1

I hadn't altered anything and there isn't a type definition in the module for the "RegexFlags" type to work off of debugging. Could this be a setup issue on my side of things?

Hmm, this works for me, so I'm not sure what's gone wrong here. Maybe you should try using the latest code on the 0.11.3 branch until that version is released.


Update request: python311Packages.openrazer 3.5.1 → 3.6.1

Package name: python311Packgaes.openrazer
Latest released version: 3.6.1

Current version on the unstable channel: 3.5.1

Current version on the stable/release channel: 3.5.1

[x] Checked the nixpkgs pull requests

Notify maintainers

@evanjs
@roelvandijk
@Lucus16
Last update pull request was made by: @SuperSandro2000
Note for maintainers: Please tag this issue in your PR.

#264068


merge the latest version

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: yyjt1987:x: shinhye218You have signed the CLA already but the status is still pending? Let us recheck it.

无法合并，重解决冲突后重新提交

就为了支持trim？

不好意思，是我操作失误，我是要把最新的合并到我自己的分支上，见谅。

不好意思，是我操作失误，我是要把最新的合并到我自己的分支上，见谅。

还是冲突啊

这个改动仅仅为了trim？


Scroll invalidation seems broken on an RTX 2070?

Environment
Windows build number:  Win32NT 10.0.19042.0 (Microsoft Windows NT 10.0.19042.0)
Windows Terminal version (if applicable): Version: 1.4.3243.0

Any other software?
Ubuntu WSL2 4.19.104-microsoft-standard

Steps to reproduce

Launch Windows Terminal.
Launch an Ubuntu WSL2 session. (Not WSL). This is the Windows 10 Store app, called "Ubuntu". It's currently running 20.04 in WSL2.
In Ubuntu WSL, find a directory location where there's a known cloned .git repository.
In the repository, run git log or git status, if you have a lot of modified changes yet to be committed. This should at least print enough characters in Windows Terminal, that you will definitely need to scroll up/down to view everything that was printed in the window.
Use your mouse and drag the Windows Terminal scrollbar up or down very quickly.
Observe the error. I think the display is not refreshing correctly. (See below)

Expected behavior
I should be able to view text normally.
Actual behavior

I made it easier to reproduce, instead of seeing all those red text which is really hard to view:

Whoa! What GPU do you have? We only used to see this when partial presentation was broken...

And does experimental.rendering.software or experimental.rendering.forceFullRepaint make a difference here?
See: https://docs.microsoft.com/en-us/windows/terminal/customize-settings/global-settings#rendering-settings

Or, does selecting (and deselecting) the text in the buffer reveal what you'd actually expect to be visible?

Whoa! What GPU do you have? We only used to see this when partial presentation was broken...

Dual GPUs setup. One GTX 1060, and one RTX 2070 Turbo.

And does experimental.rendering.software or experimental.rendering.forceFullRepaint make a difference here?
See: https://docs.microsoft.com/en-us/windows/terminal/customize-settings/global-settings#rendering-settings

Just the setting "experimental.rendering.forceFullRepaint": true is good enough for me to fix the issue. I didn't know about this setting configuration before.

Or, does selecting (and deselecting) the text in the buffer reveal what you'd actually expect to be visible?

Selecting and deselecting the text in the buffer reveals the text I expected it to print out after doing a simple ls -a.

Out of curiosity, does this bug only repro for one of the GPUs? If forceFullRepaint fixes this, then it might be a sign that either partial presentation doesn't work for that GPU, or we're not doing something right for that specific one.

Repaint fixes this, then it might be a sign that either partial presentation doesn't work for that GPU, or we're not doing something right for that specific one.

How should I test this? Do I just disable the device, then reboot for each of these graphics card?

Actually, another question: How do you determine what rendering device the Windows Terminal is using for rendering? Maybe if that information is included somewhere when creating a diagnostic file, would it help to pinpoint which device the rendering is malfunctioning?
If these are not viable, then nevermind.

@tommai78101 I don't have more than GPU but did you try this?

@onomatopellan That's actually better. Let me try that and see how it goes.

@onomatopellan @zadjii-msft
Apparently, Windows Terminal runs on RTX 2070, and that's what's causing the screen tearing/partial rendering issue when scrolling up/down fast enough.

Also it is strange that my GTX 1060 is gone from this menu...

And if I switch to Intel UHD Graphics 630, I don't get that screen tearing.

@tommai78101 It seems you need to specify which one is the High Performance GPU. Can you find somethinng like this?

@tommai78101 It seems you need to specify which one is the High Performance GPU. Can you find something like [this]

No, I'm not on the Windows 10 Insider, since this is is home personal computer. I do not want to be an Insider.
I'm still on the 19042 build, per OP at the top.

I've marked this bug up for our backlog and stuck the "needs repro" tag on it. Probably our best bet is gonna be someone on the team getting this under a debugger . . . but that's going to be difficult.
I think there might be some tracing we can use to help determine what exactly is happening, but I'll need to consult.

Cool, let me know if you need anything.
For now, I'm going to stick to using the experimental.rendering.forceFullRepaint option, since it works perfectly.

Hey so I know it's been a few years - You still seeing this/? If you are, could you try out the new rendering engine in the Preview builds? I'm curious if that new engine just fixes this for you.

@zadjii-msft Hello, I installed the Windows Terminal Preview, and just checked. Unfortunately, the issue is still not fixed when I turned off the experimental.rendering.forceFullRepaint option.

In action:

Ah okay that's my bad. The experimental.useAtlasEngine setting actually goes in your profile settings, rather than the globals (like the other rendering settings). Can you try there instead? (also, that setting doesn't hot-reload, so you'll need to reboot the terminal).
Thanks for bearing with me!

@zadjii-msft I moved the settings under the profile setting, and redid the test.  The new rendering engine settings seems to be working now.
Seems to be working now.

What was the issue found that would cause the error with the rendering issue before the new Atlas engine?

Honestly, I don't know! The two engines have pretty different paths by which they interact with the GPU. Perhaps the set of calls we're using with the old renderer (most likely Present1) just don't play nice with your GPU.
This bumps a discussion topic we've been putting off. What exactly should we do with bugs like this? Where there's a bug in the dxrenderer, but it's resolved in the new renderer. We're ultimately planning on defaulting to the new engine for everyone (once it's a bit more stable).
I'm proposing we add a Resolution-FixedByAtlasRenderer label. Use that to tag issues we know are fixed already. Maybe just close those out right now? Maybe we could add a rule to the bot so that /atlas would give a little blurb about the new renderer and how to enable it for now.

Oh we looped back on this but never actually closed it out. 🤦
We did end up tracking a whole pile of "fixed by atlas" things, but this escaped.


what causes ? createFileSystemProviderError or ERR Unknown (FileSystemError): Error: timed out

ERR Unknown (FileSystemError): Error: timed out
at new t (https://demo.net:8443/ide.main.5b173b.js:16:129721)
at Object.t.createFileSystemProviderError (https://demo.net:8443/ide.main.5b173b.js:16:130360)
at t.toFileSystemProviderError (https://demo.net:8443/ide.main.5b173b.js:60:6383354)
at t. (https://demo.net:8443/ide.main.5b173b.js:60:6376134)
at https://demo.net:8443/ide.main.5b173b.js:16:2489
at Object.throw (https://demo.net:8443/ide.main.5b173b.js:16:2594)
at s (https://demo.net:8443/ide.main.5b173b.js:16:1416)

Is this v1? I don't think there's an ide.main.js in v2.

This is v1 so closing off as deprecated


common/analysis/violation_handler.{h,cc} needs a test

The move to common highglighted that the violation handler did not have a test yet and mostly was 'accidentally' tested by the lint_tool_test.sh. So would be good to add a violation_handler_test.cc to test things in isolation.
A mutant testing run found some examples that could be a good starting point; it changes lines and observes if this is affecting any test; here are examples of code changes that would not trigger any tests to fail:

In violation_handler.cc:35: Changing this line to

  const bool print_alternative_number = !(fixes.size() > 1);

In violation_handler.cc:36: Changing this line to

  for (size_t i = 0; !(i < fixes.size()); ++i) {

In violation_handler.cc:126: Changing this line to

   if (is_interactive_ || first_round) {

The complaints there are mostly complaining about user-visible outputs, and in general this code is dealing with user inputs and outputs which might make it seem hard to test at times.
Outputs could probably be somewhat easy tested by passing a std::stringstream and checking if we get some expected output.
But it might also be a consideration in the future to provide some more structured output (as we have headlines, listings etc. of sorts) which might be useful for different UI situations.
For  user-input we call verible::ReadCharFromUser(..) right now directly inside ViolationFixer::InteractiveAnswerChooser(), which makes it hard to mock out. But if this was a call to a std::function that we pass in (e.g. std::function<char(const std::string &prompt)> ask_user), we can mock that out easily in a test and have more freedom in places where we need it e.g. in partially automated places where we might get the input via some other means, web-frontends etc ... well and of course a test.
So as always with tests in mind, we might end up with a more readable, testable and easier to maintain code.

@wsipak : since you're working on the detangling of that code anyway, could you have a look adding a first test for this (and maybe even consider changes as suggested above) ?


Inject Collections framework

Current coverage is 85.33% (diff: 88.88%)

Merging #44 into master will increase coverage by 1.27%

@@             master        #44   diff @@
==========================================
  Files            29         29
  Lines           527        532     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            443        454    +11
+ Misses           84         78     -6
  Partials          0          0

Powered by Codecov. Last update 0696b93...a3d574d


feat: migrate-mongo

#92
manque le script pour appliquer les migrations

:tada: This PR is included in version 1.32.0 :tada:
The release is available on:

v1.32.0
GitHub release

Your semantic-release bot :package::rocket:


patch-rs binding

I'm using git dependency for patch-rs, because v0.2 is not published yet.

I tried that, but the compiler complains:
error[E0277]: `(dyn std::error::Error + std::marker::Send + 'static)` cannot be shared between threads safely
 --> src/bindings/app/patch.rs:8:38
  |
8 |             this.0.process().map_err(rlua::Error::external)
  |                                      ^^^^^^^^^^^^^^^^^^^^^ `(dyn std::error::Error + std::marker::Send + 'static)` cannot be shared between threads safely
  |
  = help: the trait `std::marker::Sync` is not implemented for `(dyn std::error::Error + std::marker::Send + 'static)`
  = note: required because of the requirements on the impl of `std::marker::Sync` for `std::ptr::Unique<(dyn std::error::Error + std::marker::Send + 'static)>`
  = note: required because it appears within the type `std::boxed::Box<(dyn std::error::Error + std::marker::Send + 'static)>`
  = note: required because it appears within the type `std::option::Option<std::boxed::Box<(dyn std::error::Error + std::marker::Send + 'static)>>`
  = note: required because it appears within the type `error_chain::State`
  = note: required because it appears within the type `patch_rs::PatchError`
  = note: required because of the requirements on the impl of `failure::Fail` for `patch_rs::PatchError`
  = note: required because of the requirements on the impl of `std::convert::From<patch_rs::PatchError>` for `failure::Error`
  = note: required because of the requirements on the impl of `std::convert::Into<failure::Error>` for `patch_rs::PatchError`
  = note: required by `rlua::Error::external`

How about this.0.process().ok()? The downside is that we lost the error message.

@dariusc93
I tried that, but the compiler complains:
error[E0277]: `(dyn std::error::Error + std::marker::Send + 'static)` cannot be shared between threads safely
 --> src/bindings/app/patch.rs:8:38
  |
8 |             this.0.process().map_err(rlua::Error::external)
  |                                      ^^^^^^^^^^^^^^^^^^^^^ `(dyn std::error::Error + std::marker::Send + 'static)` cannot be shared between threads safely
  |
  = help: the trait `std::marker::Sync` is not implemented for `(dyn std::error::Error + std::marker::Send + 'static)`
  = note: required because of the requirements on the impl of `std::marker::Sync` for `std::ptr::Unique<(dyn std::error::Error + std::marker::Send + 'static)>`
  = note: required because it appears within the type `std::boxed::Box<(dyn std::error::Error + std::marker::Send + 'static)>`
  = note: required because it appears within the type `std::option::Option<std::boxed::Box<(dyn std::error::Error + std::marker::Send + 'static)>>`
  = note: required because it appears within the type `error_chain::State`
  = note: required because it appears within the type `patch_rs::PatchError`
  = note: required because of the requirements on the impl of `failure::Fail` for `patch_rs::PatchError`
  = note: required because of the requirements on the impl of `std::convert::From<patch_rs::PatchError>` for `failure::Error`
  = note: required because of the requirements on the impl of `std::convert::Into<failure::Error>` for `patch_rs::PatchError`
  = note: required by `rlua::Error::external`

How about this.0.process().ok()? The downside is that we lost the error message.

error-chain is not compatible with failure: https://github.com/rust-lang-nursery/error-chain/issues/240
I'm doing this:
            this.0
                .process()
                .map_err(|e| rlua::Error::external(failure::err_msg(e.to_string())))

@dariusc93
Ok, I tested current master branch of patch-rs, it works!
Publish a new version to crates.io then I'll update this PR.

@juchiast done, v0.3.0 is out there.
@dariusc93 I agree, I should have used failure from the beginning. Some of my projects still use error-chain so for some reason I went for that.

@hedgar2017, :+1: :+1:
@juchiast :+1: :+1:
@dariusc93 :+1: :+1:


UTF-8 for oauth2ExceptionSerializer

Had an issue with modified exception, which contained UTF-8 symbols like 'š'. It was serialized to JSON as 'scaron'. Generally, it's ok, but in my case I had to write my own serializer to accomplish the task of returning a proper UTF-8 exception message. Wouldn't it be better to use UTF-8 charset here instead of default ISO-8859-1?

@keizik Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@keizik Thank you for signing the Contributor License Agreement!

@keizik Thank you for the PR but this has already been resolved by this (reverted) commit 9d84370.


config updates

@cameron-a-johnson / @Purg

@cameron-a-johnson  the configs under config/tasks are what you need. The activity ids are based on the ids in config/activity_labels/all_recipe_labels.yaml, which for now are different than each respective recipe activity config (I need to update the annotations before changing the ids in each file)


Removing unused subdirectories [6327]

Removes subdirectories that are not used anymore

Build status:

Linux
Mac
Windows


unnecessary console.logs

When receiving the text files, there are unnecessary console.log()s that can be confusing to the inexperienced user

All console.logs were removed.


From 5.21.0 to 5.33.0, highlight doesn't work

Hi, I recently opened a issue to say that my editor doesn't work when I update it but in fact, It's just highlight text which doesn't work when I try to udate to the latest version of codemirror.js.
Note that all widgets are already up to date.
I tried CodeMirror.colorize() but no change.
Do I need to add more code to colorize the editor or keep the older version?

If you mean highlighting of code within the editor, you don't need colorize for that. You just need to load the proper modes. Check CodeMirror.modes to see if your modes are there.

For the editor, I have :
And when I type CodeMirror.modes in the console, it return
All needed dependencies (HTML, XML, JS, CSS) are loaded.
And editor.getMode().name returns "htmlmixed"

Since I'm seeing neither the xml nor the css mode in that screenshot, it seems like those aren't actually loaded. Look into that.

I have {null: ƒ, htmlmixed: ƒ, javascript: ƒ, xml: ƒ, css: ƒ, markdown: ƒ} for the latest version.
It work now and markdown  work too.
You're the best.
Much thanks.


this.hubConnection.on("UpdatedMissions"..  is firing many times

Hello, I am using Azure SignalR REST API to send message to the client.  My client is an Angular app.    We have a Azure SignalR service.   From our backedn service we issues Rest API call to the user.
Like so:
 public async Task SendUpdatedMissions(string userId)
        {
            _defaultPayloadMessage = new PayloadMessage
            {
                Target = "UpdatedMissions",
                Arguments = new[] {
                    userId
                }
            };

            string url = GetSendToUserUrl(userId);

            if (!string.IsNullOrEmpty(url))
            {
                var request = BuildRequest(url);

                var response = await Client.SendAsync(request);
                if (response.StatusCode != HttpStatusCode.Accepted)
                {
                    Console.WriteLine($"Sent error: {response.StatusCode}");
                }
            }
        }

I have three different methods I am listening for and two are working well, however,  when I fire UpdatedMissions from the REST API.  The client receives the message many times.
 this.hubConnection.on("UpdatedMissions", () => {
          // this.missionsService.refreshMissionsFromService();
          console.log('received UpdatedMissions');
        });

Here is the rest of the code where I start SignalR connection on client:
public startSignalRConnection() {
    this.getSignalRConnection().subscribe(con => {
      console.log('SignalR con: ' + con);
      const options = {
        accessTokenFactory: () => con.accessToken
      };
      this.hubConnection = new SignalR.HubConnectionBuilder()
        .withUrl(con.url, options)
        .configureLogging(SignalR.LogLevel.Information)
        .build();

        this.hubConnection
        .start()
        .then(() => {
          this.addSignalRListener();
        console.log('Connection started');
        })
        .catch(err => console.log('Error while starting connection: ' + err));
    //  this.hubConnection.start().catch(error => console.error(error));
    });
  }

  public addSignalRListener = () => {
    this.hubConnection.on("UpdatedProfile", () => {
      this.profileService.refreshStatsFromService();
    });

    this.hubConnection.on("UpdatedMissions", () => {
      // this.missionsService.refreshMissionsFromService();
      console.log('received UpdatedMissions');
    });

    this.hubConnection.on("BroadcastLeaderboardUpdate", () => {
      this.leaderboardService.refreshLiveLeaderboardFromSignalR();
    });
  }

When I put a breakpoint in there it just keeps firing one after another and I am unable to figure out why.
You can see here it logged 16 times.  The REST API is definitely not getting called 16 times.

Is the same send-to-user rest api used for UpdatedProfile and UpdatedMissions. If so, they are equivalent. If UpdatedProfile works well, UpdatedMissions should works well too.
Could you tell me how many times the listener UpdatedMissions is registered for one hub connection?
Assume that you call rest api for 1 time, if you always get 16 times for each message, you might register 16 times for UpdatedMissions for each hub connection.

You can try our new Management SDK to send messages in your backend service.
You don't have to build the request. The interface is almost the same with IHubContext and more efficient to use Persistent mode which establish a websocket connection to communicate with SignalR service.
Introduction to this SDK.

@realwanpengli  Let me take a look.  This morning it seems to be working as expected which is weird, because all day yesterday it was not.   I will monitor it and also take a look at the Management SDK.

Great to hear that it worked. Close the issue due to no more comments for more than 1 week.


[Sema] NFC: Use exhaustive switches in PatternKind::Named

Also, flip the polarity so that programmers that add new ReferenceOwnership kinds know what to do. This is a followup to #15419.

@swift-ci please smoke test

@swift-ci please smoke test

Thanks @rudkx – This makes my research branch easier to maintain.