fix memory leak in xml parser

closes https://github.com/Azure/azure-sdk-for-cpp/issues/2427
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage


tsd reinstall and tsd install should allow for a folder

if I want to run tsd in sub-directory, I have to cd into it then run it. Is there a flag I am missing that allows tsd to install in a sub-directory?
If not, I'd love to see this work:
tsd reinstall -t=src -r -o
which would then reinstall typings in the src folder. where -t is target

You can use --config flag or change the typing directory path by editing your tsd.json file.
Example using --config:
Having the following directory structure:
root/
 | - src/
      | - tsd.json

From root directory you can use:
tsd install --config src/tsd.json

Example editing tsd.json file:
Having the following directory structure:
root/
 | - src/
 | - tsd.json

Open the tsd.json file and edit the path and bundle attributes:
{
...
  "path": "src/typings",
  "bundle": "src/typings/tsd.d.ts",
...
}

Note: I fixed a bug with --config option. To get the latest version you must install<EMAIL_ADDRESS>https://github.com/DefinitelyTyped/tsd/releases/tag/0.6.5-beta

Cool, thanks. I missed this combo tsd install --config src/tsd.json. This is better than cd-ing into the folder and back out.

:thumbsup:


Feature/overtime dev

These issues will be address in the next PR, so we can deploy into Dev for user testing.


Write test cases for projectById() in projectResolver.test.ts

It has been implemented through #358


 Avoid this in favor of System.Posix.Escape.Unicode (escape)

Package posix-escape


Wrong paths for man

I used @asdf-vm to build py2pack, and while generating for anyconfig the .spec contained:
%dir /home/jayvdb/.asdf/installs/python/3.7.2/share/man/man1
/home/jayvdb/.asdf/installs/python/3.7.2/share/man/man1/anyconfig_cli.1

I suspect something is using sys.executable, and this might be fixed by using /usr/bin/python* instead, but that could create new problems.

I would prefer working Python (thus sys.executable) than non-standard setups. Hopefully you know how to use search-and-replace function of your editor.


Broken After 0.24

After updating the lib, there's a chance that the String Array does not work correctly.
I tested below code in obfuscator.io
rows.forEach((row, index) => {
  if (o.val) fn(` CONTENT ${o.val}`)
})

String Array

Rotate
Shuffle
Base64 Encoding
Threshold - 0.5

Split String Chunk: 15

The above will generate (result differs for each run):
rows['forEach']((c, d) => {
    if (o[b('0x0')])
        fn('\x20CONTENT\x20' + o['val']);
});

rows['forEach']((c, d) => {
    if (o[b('0x1')])
        fn(b('0x0') + o['val']);
});

rows['forEach']((c, d) => {
    if (o['val'])
        fn(b('0x1') + o[b('0x0')]);
});

I was expecting the code to be below instead.
    if (o[b('0x0')])
        fn(b('0x1') + o[b('0x0')]);

And what is wrong?

If you worried about different indexes for string array calls, it is ok, because shuffleStringArray option is enabled.

For example, i tested with the following code:
const rows = [
    {
        val: 'foo'
    },
    {
        val: 'bar'
    },
    {
        val: 'baz'
    }
];

rows.forEach((row, index) => {
  console.log(`CONTENT ${row.val}`);
})

And everything is ok. Order of logs is correct: 'foo', 'bar', 'baz'

Thanks for the quick reply. Actually you need to add the if before the console.log.
It is ok if it does not break anything but for my case, it broke my tests.
There are no errors but the code after the if is not executed.

Can you show me a standalone small example, that is worked before obfuscation and does not work after?

The problem looks the same as here:
https://github.com/javascript-obfuscator/javascript-obfuscator/issues/496
Can you try to search a minimum standalone example that will reproduce this error?

I've been trying to reproduce a simpler example however not able to reproduce. The source that I have i quite complex which I'm trying to find the pattern that causes it.
Similar to #496 there is no error but produces a wrong result due to the if condition is not met.
My initial suspect was the if condition was wrongly replaced.

Try to play with options as I said before. We should t find as many hints as possible

I've turned off every as below and still having wrong results.
    target: 'node',
    compact: false,
    controlFlowFlattening: false,
    deadCodeInjection: false,
    debugProtection: false,
    debugProtectionInterval: false,
    disableConsoleOutput: false,
    identifierNamesGenerator: 'mangled',
    log: false,
    renameGlobals: false,
    rotateStringArray: false,
    selfDefending: false,
    sourceMap: false,
    splitStrings: false,
    splitStringsChunkLength: 15,
    stringArray: false,
    stringArrayEncoding: 'base64',
    stringArrayThreshold: 0.9,
    shuffleStringArray: false,
    transformObjectKeys: false,
    unicodeEscapeSequence: false

If you want, I can email you a sample as my code and the result.

It will be nice! Send it on sanex3339 a t yandex.ru

Finally, found the issue here:
function run(aaa, { missing = '' } = {}) {
    let q = `run ${aaa} `;
    if (missing)
        q += ` SOMETHING ${missing}`;
    return q;
}

console.log(run('dummy', { missing: 'IMPORTANT' }))

The { missing } is renamed but the outside calling function is still using the same signature.

Nice!

PR with the fix https://github.com/javascript-obfuscator/javascript-obfuscator/pull/544

Please, try 0.24.5 version

Reopened until approve from your side

It was fixed there:
https://github.com/javascript-obfuscator/javascript-obfuscator/issues/496
So expect that it was fixed here too

Comment here if this problem will happen again

Yes. Just tested and it looks good so far. Thanks for the quick fixes!

Nice! Thank you for investigating the problem


Replace tags signature to [String, Seq[String]] to support next osm 0.7 version

Using map here is incorrect. We should use list or array. It could be same key two values in real life pbf and we should keep the data reader not changing anything.

Are you sure of that? Do you have any example or reference to be sure?
The pbf format stores series of keys,values pointing to the stringTable. Do you mean that there is more than one reference in the same Node/Way/Relation to the same key?
I think that the pbf editor is not support this behaivor.
In that case, this is a bug and it is necessary to change the format to Map[String, Seq[String]] (no array or list)

Confirmed:
From the OSM documentation:

As OSM doesn't natively support multiple values for keys (yet), mappers have come up with various MV tagging schemes, each with their pros and cons.

So osm only support one value per key. It will be support in the next 0.7 version.
I'm going to keep it open for the next v2, but definitely is not a bug.

I'm going to create a tag for osm-0.7 so we can track these things and open it again.

Iam sure about that. I met a lot of such case. PBF allows it. Please have a look on how other reader like osm2orc，osm parquetizer or osmosis pbf2 read. Array is better than map.

Don't innovate, just array is enough. Map has more memory footprint too.

I think changing this ticket back to what it is is better

For example: https://github.com/openstreetmap/osmosis/blob/master/osmosis-pbf2/src/main/java/org/openstreetmap/osmosis/pbf2/v0_6/impl/PbfBlobDecoder.java#L207-L221

Looks like you are offended because I change the title. Sorry for that, rolling back.

If you say that there are cases, even when in the documentation say that it is not supportes, I will beliave your. But understand that I need to check it to be 100% sure.
In the case of suppor of different values per key, I think that tags represent a map of key->value.
It is easy to use and I did not see any problem with the performance.
There are people extracting data from tags (in fact, it is the main use) and Map is the right structure to access by key.
Anyway, let me search cases in the planet to be sure that this is a case. If you want to do it, I will appreciate it.


Need more detailed information for deployed aspire dashboard

Currently deployed aspire dashboard hides so many details about how it's implemented by azure container apps. They should be documented or there should be a way to view the detail deployed aspire dashboard.
The list shows what's I've learned(possibly wrong) for deployed dashboard and the detail I want to explore.

Aspire Dashboard is provisioned as a child resource of the container app. According to the document, we need to config azd config set alpha.aspire.dashboard on. But this config seems not alpha anymore. And the dashboard is deployed by default, is there any way to easily disable it before provision? To edit the bicep files seems a way, but not comfortable enough.
Currently there is only option on azure dashboard to switch on/off the dashboard for the environment. There is no way to view the Aspire Dashboard resource detail such as memory/CPU/request usage. If I'm not wrong, dashboard is also a container which brings cost.
When Aspire Dashboard is provisioned, four OTLP endpoints are configured, and there is no way to view how they are configured in detail.
The deployed Aspire Dashboard seems using microsoft OIDC as authentication way which is not the default. This should be documented.

All the above is caused by the fact that we can't view Aspire Dashboard resource detail from azure. Is it because the aspire-dashboard dotnetComponent is still under development?
We need to get access to view the Aspire Dashboard resource detail although it may be the internal implementation detail. At least we should be able to view the cost caused by dashboard.

The dashboard in ACA is an Azure feature. You don't get to control any details other than what is publicly documented an exposed via the ARM API. You don't get to pick or configure how it is configured and that is by design. As a customer of azure, it's a black box (it could be an azure specific fork for all you know 😉).
That said, I think it is fine to document in the ACA documentation the aspire dashboard and what it supports from a public API POV.

Aspire Dashboard is provisioned as a child resource of the container app. According to the document, we need to config azd config set alpha.aspire.dashboard on. But this config seems not alpha anymore. And the dashboard is deployed by default, is there any way to easily disable it before provision? To edit the bicep files seems a way, but not comfortable enough.

There isn't. Can you file an issue here https://github.com/Azure/azure-dev.

Currently there is only option on azure dashboard to switch on/off the dashboard for the environment. There is no way to view the Aspire Dashboard resource detail such as memory/CPU/request usage. If I'm not wrong, dashboard is also a container which brings cost.

You're not paying for it.

When Aspire Dashboard is provisioned, four OTLP endpoints are configured, and there is no way to view how they are configured in detail.

That's an implementation detail.

The deployed Aspire Dashboard seems using microsoft OIDC as authentication way which is not the default. This should be documented.

How it works should be documented for sure.


[Bug] Wizard event "click.fu.wizard" should not fire when content includes li elements

I've experienced unexpected behavior with unexpected steps switching.

Add the next code to the first .step-pane element:

First item

Second item

Click on "First item" row

Expected result: nothing should happened.
Actual result: last step would be activated.
The reason is selector for steps elements ("li.completed") located inside all of the wizard element:
https://github.com/ExactTarget/fuelux/blob/master/js/wizard.js#L60
My suggestion:
var stepsContainer = this.$element.children('steps-container')
stepsContainer.on('click.fu.wizard', 'li.complete', $.proxy(this.stepclicked, this));

Could I provide PR for that?

Yes, please do provide a PR!
Please provide unit tests for this as well.

@cormacmccarthy Could you take a loot at the PR https://github.com/ExactTarget/fuelux/pull/1879 ?


Image pixel effect

Description 📜
It is effect using Basic math functions of vanilla javascript to play with the pixels of images
Fixes #1667

Type of change 📝
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Add a new project

Domain of Contribution 📊
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[] I have performed a self-review of my own code or work.
[] I have commented on my code, particularly in hard-to-understand areas.
[] My changes generate no new warnings.
[] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸

@Gurdeep475 , @Mrjoy832 , please check and merge, else seven day will be over and bot will close the issue.

@Gurdeep475 , @Mrjoy832 , please check and merge, else seven day will be over and bot will close the issue.

bot se upor hum hain😂😂re-open kor denge..aur merge hoga sab time de do thora...mera aur vi project hain

Whats this? changes should be done only on your folder

Can you tell me

 Whats this? changes should be done only on your folder

@Mrjoy832  sir, can you tell me one thing, If I have to push multiple projects in one repo, all the previous changes  comes on the branch which comes after that even after I make a new branch , it happens , what should I do?

Can you tell me

 Whats this? changes should be done only on your folder

@Mrjoy832 sir, can you tell me one thing, If I have to push multiple projects in one repo, all the previous changes comes on the branch which comes after that even after I make a new branch , it happens , what should I do?

You can delete previous branch after merging of PR and can create every new PR for Every new issue

@Mrjoy832 ,sir ,please remove invalid tag , i have deleted every unnecessary files from this pr

Now @Mrjoy832  merge this pr ,
wo copy/pasting ke time ek do curly braces ek line niche ho gyaa hai purane todo app me, wohi change aa raha , apka todo app , maine dubara se add kar diya hai successfully.

Now @Mrjoy832 merge this pr , wo copy/pasting ke time ek do curly braces ek line niche ho gyaa hai purane todo app me, wohi change aa raha , apka todo app , maine dubara se add kar diya hai successfully.

@Mrjoy832 same as cute bear login

@Mrjoy832 ,hum bass jo dusre PR ke pages the , unko delete kiye hain wo isme aa rhe the

Now @Mrjoy832 merge this pr , wo copy/pasting ke time ek do curly braces ek line niche ho gyaa hai purane todo app me, wohi change aa raha , apka todo app , maine dubara se add kar diya hai successfully.

@Mrjoy832 same as cute bear login

@Mrjoy832 ,hum bass jo dusre PR ke pages the , unko delete kiye hain wo isme aa rhe the


deps: update quick-xml dependency

The quick-xml dependency is currently pinned to v0.25, while upstream has already released v0.29.
However, I'm not sure how to handle some of the breaking changes since v0.25:

The $text attribute (added in v0.28.0) breaks the new custom Value deserializer (though adding a case for "$text" to the match statement seems to solve that (not sure if that's correct, but it seems to work 😕)
quick-xml now defaults to writing self-closing XML tags when serializing empty strings (i.e. empty string values are written as <value><string /></value> and empty bytes are written as <value><base64 /></value>. While this is valid XML and should be acceptable for XML-RPC, it's inconsistent with other implementations

I've checked how Python's xmlrpc module handles this (see below) - it supports reading XML with self-closing tags, but it does not seem to ever write them. I don't think there's a way to control this behaviour from the quick-xml serializer side (without writing a custom serializer ...)

import xmlrpc.client
xmlrpc.client.loads("<params>\n<param>\n<value><string /></value>\n</param>\n</params>\n")
# (('',), None)
xmlrpc.client.loads("<params>\n<param>\n<value><string></string></value>\n</param>\n</params>\n")
# (('',), None)
xmlrpc.client.dumps(("",))
# '<params>\n<param>\n<value><string></string></value>\n</param>\n</params>\n'

@bahlo You seem to have more experience with weird XML-RPC clients / servers than me - do you think it would be an issue if dxr clients / servers started sending XML-RPC messages that contained self-closing XML tags for empty strings / bytes?

Correction: quick-xml seems to write <string/> and <base64/> without a space before />. It looks weird to me for some reason, but it appears to be valid XML 1.0 syntax.

Hah yeah I sadly do—the server I‘m interfacing with is using XMLRPC++ 0.7 and does not support self-closing xml tags so I‘d selfishly advise to not use that feature 🥸

quick-xml v0.30 was released with the new API.
This commit updates the dependency and adjusts the code accordingly:
https://github.com/ironthree/dxr/commit/ee8799856d2eebbaad81167ccbf92c22a542bd30
Will be part of the upcoming (soon!) v0.6.0 release.

appreciate it!


handling of primitive arrays is broken with explict parse

e.g. given this json { "ids" : [1,2,3] } it works fine in regular mode, but in explict parse it generates code with
while (parser.nextToken() != JSONToken.END_ARRAY) {
ids.add(new Integer(parser));
}
which won't compile

fixed in ddd29736ae9aca4895f5dee57bad3333fdc4c015


(#22) add jest for testing with example test

Adds respective GHA workflow with CodeCov. Internally adds the packages for testing with mongo, jest for tests and jest-utils for common utils needed later.
Description
Add testing!
Related Issue
#22
Motivation and Context
This solves devs being able to write automated tests with coverage reports.
How Has This Been Tested?
How the tests have been tested? Goes a bit far ;)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@all-contributors please add @davidzwa for test

@all-contributors please add @davidzwa for review

@all-contributors please add @Lucxjo for review

https://github.com/all-contributors please add @Lucxjo for review

@all-contributors please add @Lucxjo for review

@all-contributors check


fix: use flag to prevent vcpkg lock timeout

Fixes https://github.com/googleapis/google-cloud-cpp/issues/4487
The flag was implemented by Microsoft in
https://github.com/microsoft/vcpkg/pull/12227, thanks to @strega-nil!
I believe we were seeing this flake not because of multiple installs
happening at once, but rather because the machines that run our docker
tests were sometimes overloaded and running very slow and thus it
sometimes took more than 1.5 sec to acquire the lock. This is just a
hypothesis.
But regardless, we're now passing --x-wait-for-lock to all of our
vcpkg install invocations to avoid these flakes.

This change is

The changes look good.
Is the lock used for remove as well as install? We do a remove before each?/all? installs to clean up old versions.

Good point. The flag works when passed to vcpkg remove also, so I think we might as well pass it there too. I made that change and am letting the test re-run.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

FWIW, this is not necessary in classic mode (which is what i assume you're using); i decided it made the most sense to not lock for existing customers, and only lock for manifest users (since that's the plan for vcpkg moving forward)

FWIW, this is not necessary in classic mode (which is what i assume you're using); i decided it made the most sense to not lock for existing customers, and only lock for manifest users (since that's the plan for vcpkg moving forward). The lock no longer exists for you, basically.

Oh. TIL about "classic" and "manifest" mode for vcpkg (https://vcpkg.readthedocs.io/en/latest/specifications/manifests/). Thanks for chiming in. I'll just drop this PR.
Thanks for fixing this issue!


⚠ Bofrost.lu has degraded performance

In c5edb0a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2663 ms

Resolved: Bofrost.lu performance has improved in 9c16dc8 after 47 minutes.


Add Ubuntu 20.04 container

This new container uses buildpack-deps:focal as base, and this
commit duplicates the ubuntu-18.04-git folder and rename every
reference of the old container. Plus, it also rebrand the image
without the -git, because is more than obvious that it will have
git installed.
Fixes #303

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: felipecassiors sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Didn't notice, but this seems to be already included in #294 and its branch (without pull request): clantz/multi-tag-and-variant-expansion/containers.


Shade log4j for databricks fat jar

Shade log4j for databricks fat jar.

@ancasarb Is the RP ready for merge ? The CI failure looks like irrelative.

@ancasarb Could you help merge ? Thanks!


Documentation for Authentication Microservice

The purpose of this task is to add all documentation for the Authentication microservice.
This includes comments for the code written, proper logs, and README.md file

Completed documentation of this microservice.


Fix line number color for light background ttys

Currently the line number is almost invisible with light background
screens. I think using the same color as the file looks fine and it's a
good compromise.
Another option would be chosing another color that looks fine in all terminals, but I went for the easiest.

Thanks for the pull request, @deivid-rodriguez.
The solution to the problem is to instead not explicitly output the text as white (but still have it be bold). This has the same visual effect on dark backgrounds as before, but results in dark bolded text on light backgrounds. I've done this in 9df12f7ab8b5eaf714617ab593dbc8998bd1c4b0.
Thanks for the report!

It works! Thanks a lot!


Neither warning nor error announced when both are at cursor position

Testing #213344
I hear "warning" and "error" when only one of the two is at the cursor position, but I don't hear any of the two when there are both:

Not sure if this is a bug, but it doesn't read the warning or error message when only one is present, but just says "warning" or "error" and nothing more.

Closing as I haven't heard user reports about this


Build Error

Terraform can determine which modules and providers need to be installed.
╷
│ Error: Duplicate module call
│
│   on module/provider.tf line 7:
│    7: module setup_clis {
│
│ A module call named "setup_clis" was already defined at
│ module/main.tf:28,1-18. Module calls must have unique names within a
│ module.
╵

@balasgit The provider.tf file is in the wrong place. You put it in the root directory and it needs to be in test/stages

Fixed - its Typo mistakenly placed @seansund. thanks for catching up

One pending error
Error: Reference to undeclared module
│
│   on module/main.tf line 3, in locals:
│    3:   bin_dir       = module.setup_clis.bin_dir
│
│ No module call named "setup_clis" is declared in module.gitops_module.
╵
╷
│ Warning: Attribute Deprecated
│
│   with module.dev_cluster.module.setup_clis.random_string.uuid,
│   on .terraform/modules/dev_cluster.setup_clis/main.tf line 15, in resource "random_string" "uuid":
│   15:   number  = false
│
│ NOTE: This is deprecated, use numeric instead.
│
│ (and 2 more similar warnings elsewhere)
╵


Support - Launch Screen

Screens:

Title
Launch

AI difficulty
Map selection?

Controls / How To Play
Credits

Attribution for sounds/music

Possible storyline intro:

It's the year <insert future date>.
After the <apocalyptic event>, humankind must fight the forces of <enemy> for survival in a lonely galaxy.
You are <protagonist>, <rank> of strike force <greek letter>, sent to <mission>.
[Engaging conceit to set up or excuse unrealistic 2D RTS gameplay...]


Ignore links which are recognized as the catch-all route

@GavinJoyce
We've noticed an issue which arises from having a catch-all style route in one's router.
Take the given router, for example:
Router.map(function () {
  this.route('not-found', { path: '/*path' });
});

So let's say i have a route on my site, /reviews, that is not an ember route. If I create the anchor
Reviews

this little line of code detects it as an ember route an tries to transition to it.
This PR allows one to configure a router's catch-all route, and ignore route where this route is the handler. Configuration looks like this:
// config/environment.js
ENV['hrefToDefaults'] = { catchAll404Route: '404' };

Ok, so using git rmand git mv did not help. :/

@briangonzalez Thanks for this. I haven't used catch all routes before, perhaps you could expand a little on why you don't want to transition to them?

@GavinJoyce The description in the PR outlines the problem well, but let me try to rephrase it.
So let say you have a frankensite of some server rendered (Rails) and some client rendered pages (Ember).
If in my handlebars template (Ember) I have the following anchor tag which links to the server rendered "reviews" page:
My reviews

ember-href-to incorrectly treats this anchor tag as an Ember 404 route, since when you ask the router if it recognizes the route "/reviews" it returns true.

Thanks, that makes sense. Do you have many of these links? Could you use link-to for these types of link? Also, I wonder if we can inspect the matched route and determine if it is the catchall route?

As opposed to using a config? Let me try that. Wonder what the criteria would be.

And yea, we have ~10-15 of these routes.

As opposed to using a config?

Yeah, perhaps we could always ignore the catchall route? It would be nice to avoid needing to provide configuration.

we have ~10-15 of these routes.

Another possible option is to skip the transition based on the presence of a class on the anchor. Something like:
click me

Another possible option is to skip the transition based on the presence of a class on the anchor.

I was thinking about that as well, but seemed like too much developer overhead.

Wonder what the criteria would be. (in regard to auto detecting that the matched route is a catch all)

presumably we can check if the route path begins with /*?

Looks like *path works as well.
http://stackoverflow.com/questions/14548594/how-to-handle-no-route-matched-in-ember-js-and-show-404-page

Perhaps contains '*' then? I wonder if there is any other possible valid path the contains a *?

begins with * or /* might do it

Check this out:

I also see this:

The catch all routes, I've tried both variations, always have an EpsilonSegment at index 0 and a StarSegment at index 1.

nice!

Ok, going to take a stab at this.

New PR to come.

@GavinJoyce I don't see a good way to check if instanceof EpsilonSegment since I don't have that class in context.
Any thoughts?

"hello".constructor.name => string
does that work?

route.segments[0].constructor.name # "object"

tricky. here's where it's defined: https://github.com/tildeio/route-recognizer/blob/2a5a26ca35b1b77fe60622a769e577420d736c74/lib/route-recognizer.js#L82

@rwjblue says he thinks the router needs an ignore function  or array of matchers.
I guess in the meantime I can just use my fork.

sounds good, thanks


Adding unit cents and Midi controller for syntax highlighters

These will add additional annotations for syntax highlighters:
https://github.com/kmturley/sfz-syntax-highlighters

This is potentially a bit confusing as "MIDI Controller" or "loop" isn't really a unit. But I guess it makes sense to use the existing "unit" field for this because that's what the syntax highlighters will use?
Could also quibble with a few specific unit names for a few opcodes, but that's a minor thing we can sort out later.

I see. Would being compatible with that vscode extension be valuable enough to users to keep the same nomenclature, or is it no biggie? I'm thinking just calling the MIDI-related opcodes as "Midi" for this purpose would be a little less confusing. But I don't think that's enough of a reason to break something that's already in use by many people.

I'd be interested to know if editors other that vscode use the 'comment' field in textmate grammar files..?
I wonder if using 'cents' to describe units of percentage may be confusing versus its more common use to describe fractions of a semitone. In general 'cents' implies a relation to pitch or frequency.

I haven't forgotten about this, just been thinking... adding units that will be visible in the pages for things that are numbers without units could potentially confuse human readers.
There's gotta be a way to make both syntax highlighters and human readers of the page happy, but right now I don't know what that is. But we should definitely add cents as a unit to the pitch-based controls. Can we just do the cents for pitch opcodes as a first step (maybe another pull request), because that's clearly the right thing to do for those opcodes, and then leave the rest for later?

Would being compatible with that vscode extension be valuable enough to users to keep the same nomenclature, or is it no biggie?

I think Kim is referring to units mentioned in Arne's comments in the tmlanguage file. These don't form any part of the syntax rules and don't surface to users, so I think the answer is 'no biggie'.

I guess we can close this and check in a later moment a different solution, if Kim agrees, and based on this comment seems to be the case.

@redtide is correct. As both syntax.yml and the syntax highlighter file are hand written, there are many differences. This means I have low confidence that these changes are actually correct.
I will close this PR!
Related to my comment, hand writing this file is slow and error prone. If I have time after sfz web player prototype, I will look into an alternative solution.
One possible approach would be to have a automated job, which installs each sfz player. Then runs each player with different input.sfz files. A different file to test each opcode. And compare the audio generated.
If the player output matches the test, then it passes and that opcode is tagged.


how do I login a user after account signup?

After a user signups for an account by giving email, password, password confirmation, how can I directly sing in in the user?
I need to be able to get the access-token, expiry etc only then the login process can complete.
But how do I get the token without firing another request to auth/sign_in? Is there a way?

I think I got it.
create_new_auth_token is the method.


Show rules to Tokenizer calss in .from_df

When calling Tokenizer.from_df, rules=rules lies inside the call to get_tokenizer and so the Tokenizer class defaults to the default fastai rules as the class cannot see any fules added in .from_df()

Ah thanks!


looks like deps is failing (LoadError: TypeError: in ServerWS, in type definition, expected Type, got a value of type typeof(HTTP.Handlers.RequestHandlerFunction))

julia> versioninfo()
Julia Version 1.8.2
Commit 36034abf26 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 16 × AMD Ryzen 7 5800H with Radeon Graphics
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 16 virtual cores

http: 1.5.3
(@v1.8) pkg> precompile
Precompiling project...
  ✗ WebSockets
  0 dependencies successfully precompiled in 2 seconds. 97 already precompiled.

ERROR: The following 1 direct dependency failed to precompile:

WebSockets [104b5d7c-a370-577a-8038-80a2059c5097]

Failed to precompile WebSockets [104b5d7c-a370-577a-8038-80a2059c5097] to C:\Users\aryan\.julia\compiled\v1.8\WebSockets\jl_8B7.tmp.
WARNING: could not import HTTP.handle into WebSockets
WARNING: could not import HTTP.Transaction into WebSockets
ERROR: LoadError: TypeError: in ServerWS, in type definition, expected Type, got a value of type typeof(HTTP.Handlers.RequestHandlerFunction)
Stacktrace:
 [1] top-level scope
   @ C:\Users\aryan\.julia\dev\WebSockets\src\HTTP.jl:289
 [2] include(mod::Module, _path::String)
   @ Base .\Base.jl:419
 [3] include(x::String)
   @ WebSockets C:\Users\aryan\.julia\dev\WebSockets\src\WebSockets.jl:18
 [4] top-level scope
   @ C:\Users\aryan\.julia\dev\WebSockets\src\WebSockets.jl:40
 [5] include
   @ .\Base.jl:419 [inlined]
 [6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
   @ Base .\loading.jl:1554
 [7] top-level scope
   @ stdin:1
in expression starting at C:\Users\aryan\.julia\dev\WebSockets\src\HTTP.jl:289
in expression starting at C:\Users\aryan\.julia\dev\WebSockets\src\WebSockets.jl:1
in expression starting at stdin:1

maybe you have HTTP 1 installed? it isn't compatible

@mind6 it is https://github.com/JuliaWeb/WebSockets.jl/blob/2ea25b7273b052290bbfb30fc205665f137a8a04/Project.toml#L13

WebSockets.jl now has a new version, requiring Julia 1.8.2+ and HTTP 1.1.0 to 1.5. Hopefully, this solves the issue; simply do Pkg.update() and check README.md!


reference closed issues in changelog

Fixes #806
I reused the ChangelogProvider.extractIssues method so that what's displayed in the changelog is the same as the issues that are commented upon to advise they have been released.
I have placed the logic inside the Commit class, since it can apply to any type of commit, not just conventional ones.
I could not find a Mustache way to display something once if a list is not empty, so i added a commitIssuesCount property. If you know how to do so, we could get rid of that extra property, however everything i tried didn't work.
Couple of things you may want to double-check:

i have modified the default format of the conventional-commits preset
i have not modified the default format
since there is an info log in extractIssues, it is logged once for each commit, and may confuse the user as to why the same log line is repeated many times
the issues in the Mustache context are always prefixed by #. This is done so that pre-computed links look better, and to ensure links that would be rendered by Github or others would always be rendered as links, so the # doesn't need to be added in the template. It may be a bit restrictive, but i think that should be fine with most users.

The PR is separated in multiple commits, as some are fixes that are required but not directly related to the new feature. Feel free to keep as-is, or squash when merging. I thought you would appreciate the split, even just to see them separately.
Checklist

[x] Review Contribution Guidelines.
[x] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Update documentation when applicable.

I found, and fixed another issue with extractIssues, where all the #5 would be matched, even if it was preceded by the repo and it would not match.
Closes: someone/repo#1, owner/repo#2, repo#3, (#4) previously all 4 issues would be returned, now if the canonical repo name isowner/repo, only 2 and 4 are matched.

Indeed, we would need the additional form as well. Updating the regex is the way to go.

Indeed, we would need the additional form as well. Updating the regex is the way to go.

Done!

Thank you! 😄


load configuration at boot time

that should make readiness probe to mark instance as live
without requiring to make any request to it

👍


Notes about use in CI and only add service principal if generating K8s cluster

@rgardler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Google style SSO login

Well, first thing I couldn't come up with better title for issue so apologies. Now, to the situation I have django-mama-cas as my cas server, and I am using django-cas-ng on three other applications. I have followed instruction for django-cas-ng as specified on your github page. A simple scenario, my apps are A, B, C when I successfully login into A then switch to tab and request login page for B I should be logged into B automatically(If I am not wrong this is what SSO is meant to do). How using django-cas-ng and django-mama-cas I can achieve this?

Single Sign On perfectly work out of the box with django-cas-ng and jasig CAS (unless the user checked  "Warn me before logging me into other sites.").
I never used mama-cas so I don't know if there is a special manipulation to do to get SSO to work.
Did you add the urls of you apps A, B, C to the list of allowed services on the CAS ?
--
Beware, SSO is sometimes used to refer to SIngleSignOn and sometimes to SigleSignOut cf https://wiki.jasig.org/display/CASUM/Single+Sign+Out so it can be confusing

@nitmir Can you explain the flow from client side in case of single sign on in django-cas-ng? Because at the moment I am using a cookie based solution to make it work, but I would rather prefer not to do it this way. I know I must be surely missing something in configuration.
In my case A, B, C all are on same domain, as is my CAS. If I add urls of A, B, C to CAS's list of allowed services does it mean I can drop cookie based flow? It's a bit unclear to me atm

@Rajesh-Yogeshwar If the client is already authenticated to the cas and want to access service A, the following happen :
https://A -> 302 redirect -> https://cas/login?service=A -> 302 redirect -> https://A?ticket=ST-SQjd…
In background the service A fetch https://cas/serviceValidate?service=A&ticket=ST-SQjd…
the cas responds OK if the ticket is valid and user is logged to service A, else the cas responds with an error and the user is not logged.
If the client is not authenticated to the CAS https://cas/login?service=A should display a login form, when on successful login to the cas the user is redirected to https://A?ticket=ST-SQjd…
Usually all services and the CAS are on different domains but that's not mandatory and I have a couples of services on the same domains working fine. Just be careful that a service A do not erase some cookies of service B (for example service A and B on the same domain should not use the same cookie name to handle sessions or else the user wont be able to login service A and B in the same time)
Indeed if you use the CAS to authenticate user, you should not need some shared cookies across services.

This is the kind of explanation that needs to be in readme. I am working on my dev machine and every thing is hosted on localhost. So probably because of this I am not able to get it working. Thank you for a good explanation

@Rajesh-Yogeshwar it is working in production?

@morocarlo Yes. I got it working. But what I did was take idea from explanation provided by  @nitmir and rolled my own little solution. Its been working on my company's private applications for more than a year.

Hi, @Rajesh-Yogeshwar, i can't log in automatically with differents domains, how you do that?


[backport] Fix dead sphinx links

Backport of #6450

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 2f50ab60d9b14c7b56de76241ed44b369b3f5568, target branch v6) succeeded!

CI failure looks unrelated.


Suppress warnings when cache path does not exist.

See issue #605
I also changed the docs for auth parameter of Spotify.init to "access token" instead of "authorization token". In issue #599, a user confused the access token with the authorization code.

It looks like the unit tests are failing because they expect open to be called with the cache path. You might have to help me fix the tests.

@Peter-Schorn to be honest I'm struggling with the tests as well, they would need a proper clean up.
Can I suggest we do it more simply: keep it like before but catch FileNotFoundError?
try:
    ..
except FileNotFoundError:
    ..
except IOError:
    ..

@stephanebruckert I would've preferred to use FileNotFoundError as well, but it doesn't exist in python 2.7. That's why I had to change it to os.path.exists.

I've been looking at the unit tests trying to figure out how they work, but I'm very confused. Is a cache file ever created for the tests?

It seems all mocked to me, checking that the right functions are called, and forcing their return values. It looks like we force the token to be created from a JSON.
These tests might not be perfect or very clear, but I trust they make some sense. I would really avoid refactoring them in this PR. I'm having a look at the methods here to see if we could catch missing files in 2.7 https://stackoverflow.com/q/21367320/1515819

This would work in 2.7:
import errno

try:
    open('./file')
except EnvironmentError as e:
    if e.errno == errno.ENOENT:
        print("File not found (file does not exist at all)")
    else:
        print("Can't read file (file exists, but might not have permission to read it")

Nice one! Looks great to me, I can merge if you want?

Yes, go ahead.


Warning when invoking explorer.newFile

Issue Type: Bug
Executing explorer.newFile without having a folder open produces the following warning

Cannot read property 'isReadOnly' of undefined

Steps to repro:

Open vscode without any folder or workspace
Bind explorer.newFile to a keyboard shortcut
Invoke explorer.newFile
Notice the warning

Expected result:
Either

The OS file dialog is displayed to choose the file location, or
No new file is created and a clearer warning is displayed

VS Code version: Code - Insiders 1.47.0-insider (8cd3fe080bee38d28ba01d0d71713d6ec22b254e, 2020-06-19T06:35:49.048Z)
OS version: Windows_NT x64 10.0.18363

I suggest you add a When Expression that replicates how VS Code hides this command from the Command Palette until the workspace consists of at least one folder.

I acknolwedge this issue.
We accept PRs that fix this.
Code pointer https://github.com/microsoft/vscode/blob/4f76209b7c60bd736d9d9afcd7ad1fce3e0215e8/src/vs/workbench/contrib/files/browser/fileActions.contribution.ts#L224
Probably the command should not even be executed in the purple no folder workspace

@isidorn I felt like working on this, idea: https://github.com/microsoft/vscode/pull/109905

@bpasero thanks a lot, I have commented on the PR


Bug 1975485: Open debug view if routed from the view debug view link

https://bugzilla.redhat.com/show_bug.cgi?id=1975485

Note to self: @rayfordj , this will require a downstream offline-dependency update.


cherry-pick calico-enterprise content

Description
cherry-pick #3508

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 9 committers have signed the CLA.:white_check_mark: lmm:white_check_mark: tmjd:white_check_mark: bmckercher123:white_check_mark: caseydavenport:white_check_mark: lxpollitt:white_check_mark: ozdanborne:white_check_mark: alexeymagdich-tigera:white_check_mark: bcreane:x: Rafael VanoniRafael Vanoni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit e270565d768ab97bd1dffadf68cde8162af587de
https://deploy-preview-3519--calico.netlify.app


[Bug] DLL load failed

Description
I tried to convert a .mp3 file, which was inside of the same folder as spleeter and python. I got the error message, "DLL load failed: A dynamic link library (DLL) initialization routine failed."
Step to reproduce

Installed using ffmpeg
Ran 'spleeter separate -i juice_wrld_lucid_dreams_dir_by_colebennett.mp3 -p spleeter:2stems -o splits'
Got DLL load failed: A dynamic link library (DLL) initialization routine failed. error

Output
Share what your terminal says when you run the script (as well as what you would expect).

Traceback (most recent call last):
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "c:\users\paul\appdata\local\programs\python\python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "c:\users\paul\appdata\local\programs\python\python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Paul\AppData\Local\Programs\Python\Python37\Scripts\spleeter-script.py", line 11, in
load_entry_point('spleeter==1.4.3', 'console_scripts', 'spleeter')()
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\spleeter_main_.py", line 47, in entrypoint
main(sys.argv)
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\spleeter_main_.py", line 31, in main
enable_logging()
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\spleeter\utils\logging.py", line 60, in enable_logging
tf_logger = get_tensorflow_logger()
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\spleeter\utils\logging.py", line 27, in get_tensorflow_logger
from tensorflow.compat.v1 import logging
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow_init_.py", line 28, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "c:\users\paul\appdata\local\programs\python\python37\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "c:\users\paul\appdata\local\programs\python\python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "c:\users\paul\appdata\local\programs\python\python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
Environment

OS
Windows

Installation type
pip

RAM available
8 GB

Hardware spec
Intel (R) Core(TM) i5 CPU    750 @ 2.67 GHz 2.67 GHz

Additional context

I followed Dylan Tallchief's tutorial, "https://www.youtube.com/watch?v=tgnuOSLPwMI"

I also tried putting apostrophes around the file, and used "-p", but nothing worked.

The DLL error is related to Tensorflow, sound like your installation is invalid. We do not provide assistance for external youtube tutorial. Please follow the wiki for installation or go to Gitter channel to ask for assistance.


Failed to build HIE <IP_ADDRESS> with cabal <IP_ADDRESS>

stack ./install.hs cabal-build-all

Progress 0/13ghc-pkg: cannot find package Cabal-<IP_ADDRESS>
ghc-pkg: cannot find package clock-0.7.2
Progress 1/13: cabal-doctest-1.0.6, clock-0.7.2, hashable-<IP_ADDRESS>, js-flot-0.8.3ghc-pkg: cannot find package js-flot-0.8.3
Progress 2/13: cabal-doctest-1.0.6, extra-1.6.14, hashable-<IP_ADDRESS>, js-flot-0.8.3ghc-pkg: cannot find package hashable-<IP_ADDRESS>
Progress 3/13: cabal-doctest-1.0.6, extra-1.6.14, hashable-<IP_ADDRESS>, js-jquery-3.3.1ghc-pkg: cannot find package cabal-doctest-1.0.6
Progress 4/13: cabal-doctest-1.0.6, extra-1.6.14, js-jquery-3.3.1, primitive-<IP_ADDRESS>ghc-pkg: cannot find package extra-1.6.14
Progress 5/13: extra-1.6.14, heaps-0.3.6, js-jquery-3.3.1, primitive-<IP_ADDRESS>ghc-pkg: cannot find package js-jquery-3.3.1
Progress 6/13: heaps-0.3.6, js-jquery-3.3.1, primitive-<IP_ADDRESS>, random-1.1ghc-pkg: cannot find package primitive-<IP_ADDRESS>
Progress 7/13: heaps-0.3.6, primitive-<IP_ADDRESS>, random-1.1, unordered-containers-<IP_ADDRESS>ghc-pkg: cannot find package random-1.1
Progress 8/13: heaps-0.3.6, random-1.1, unordered-containers-<IP_ADDRESS>, utf8-string-<IP_ADDRESS>ghc-pkg: cannot find package unordered-containers-<IP_ADDRESS>
Progress 9/13: heaps-0.3.6, unordered-containers-<IP_ADDRESS>, utf8-string-<IP_ADDRESS>ghc-pkg: cannot find package utf8-string-<IP_ADDRESS>
# git (for submodules)
Synchronizing submodule url for 'submodules/HaRe'
Synchronizing submodule url for 'submodules/HaRe/submodules/cabal-helper'
Synchronizing submodule url for 'submodules/HaRe/submodules/ghc-mod'
Synchronizing submodule url for 'submodules/brittany'
Synchronizing submodule url for 'submodules/cabal-helper'
Synchronizing submodule url for 'submodules/floskell'
Synchronizing submodule url for 'submodules/ghc-mod'
# git (for submodules)
# cabal (for cabal)
# cabal (for cabal)
Warning: The update command is a part of the legacy v1 style of cabal usage.

Please switch to using either the new project style and the new-update command
or the legacy v1-update alias as new-style projects will become the default in
the next version of cabal-install. Please file a bug if you cannot replicate a
working v1- use case with the new-style commands.

For more information, see: https://wiki.haskell.org/Cabal/NewBuild

Downloading the latest package list from hackage.haskell.org
To revert to previous state run:
    cabal update --index-state='2019-05-18T23:29:35Z'
# cabal (for cabal-build-doc)
Resolving dependencies...
cabal: Cannot build the package generate, it is not in this project (either
directly or indirectly). If you want to add it to the project then edit the
cabal.project file.

Error when running Shake build system:
  at src/Development/Shake/Internal/Args.hs:81:69-79:
* Depends on: cabal-build-all
  at install.hs:134:30-69:
* Depends on: cabal-build-doc
* Raised the exception:
user error (Development.Shake.command_, system command failed
Command: cabal new-build hoogle generate
Exit code: 1
Stderr:
cabal: Cannot build the package generate, it is not in this project (either
directly or indirectly). If you want to add it to the project then edit the
cabal.project file.

)

Afaik, it should be cabal new-exec hoogle generate.

@fendor I successfully built latest master (33d4581f4d7a43e5b8f6219055afe625bf7ad594). I think issue is supposed to be opened until next stable release which fixes it.

There was a stable release! Will close this now.


If the original block of a non-orphan block becomes an orphan block, the copy object does not become an orphan block (incompatibility with CRuby).

In CRuby, after copying a block object from a directly given block object, when control is returned from that method, the copied object also switches to orphan block.
However, mruby does not switch to orphan block, even going back at least to version 1.3.0.
def m(&b)
  b.dup
end

x = m { break 1 }
begin
  x.call

  # Even if mruby goes back at least to version 1.3.0, it gets here.
  raise "BAD!"
rescue LocalJumpError
  # Where CRuby gets here.
  p "GOOD!"
end

The way I see to solve this problem is either to follow the CRuby behaviour, or to compromise and make all copy objects orphan blocks.

(1) If we compromise, we just force the MRB_PROC_ORPHAN flag in mrb_proc_copy(). Perhaps additions to doc/limitations.md are needed.
(2) If the behaviour is to be similar to CRuby's behaviour, we believe it would be to add proc->body.origin so that we can track whether it is an orphan block or not. The workload is somewhat more involved.
(3) We will close this issue as if we didn't see it.

Which one looks better for mruby?
:black_cat: I'm in the process of retrying #6282, which was reverted in #6295, and ran into this issue when I thought the previous issue was resolved.

In relation to commit 204928120bb6c81d660ac1c94fbd3284041b8920.
A version that overcomes #6295 is in https://github.com/mruby/mruby/compare/master...dearblue:mruby:again-6282.
It does not do ci->blk entity references, so there is no need to GC mark them. It just compares the address as an identifier.
However, I can't do PR at this time because of the issues I first addressed.


HHH-12979 - Setting hibernate.javax.cache.uri property value as relative path causes an error

https://hibernate.atlassian.net/browse/HHH-12979

@vladmihalcea I noticed that ConfigHelper is deprecated and it is mentioned we should use the ClassLoaderService. It's indeed what is done in the legacy Ehcache region factory (together with other manipulations which are IMHO useless) so I added a commit with this approach.
Note that it doesn't support the classpath:// URI scheme as it's not something we support elsewhere. It will be supported if it is supported by the framework (Spring registers a classpath:// handler for instance).
But it checks the classpath by default, which is what we used to do for Ehcache.
Thoughts?

We do support classpath:// urls elsewhere as I listed somewhere else we
discussed this.
FWIW I did look into writing and registering a custom handler.  The problem
that I ran into there is that you can register only a
single URLStreamHandlerFactory in a given VM - as in the method to register
a URLStreamHandlerFactory can literally only be called once in a given VM
ever.  I suspect that works for Spring because it controls VM startup (as
a container or boot).  IMHO that is a dead-end approach for us to look at.
[1] See the javadocs -
https://docs.oracle.com/javase/8/docs/api/java/net/URL.html#setURLStreamHandlerFactory-java.net.URLStreamHandlerFactory-
On Thu, Oct 18, 2018 at 6:09 AM Guillaume Smet<EMAIL_ADDRESS>wrote:

@vladmihalcea https://github.com/vladmihalcea I noticed that
ConfigHelper is deprecated and it is mentioned we should use the
ClassLoaderService. It's indeed what is done in the legacy Ehcache region
factory (together with other manipulations which are IMHO useless) so I
added a commit with this approach.
Note that it doesn't support the classpath:// URI scheme as it's not
something we support elsewhere. It will be supported if it is supported by
the framework (Spring registers a classpath:// handler for instance).
But it checks the classpath by default, which is what we used to do for
Ehcache.
Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/2591#issuecomment-430968669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOUE3CubSfS_waJmUUpOcY2DLwjzkXYks5umGF0gaJpZM4Xs3Dw
.

@gsmet @sebersole I thought that I don't have access to ClassLoaderService, but realized that I could load it via the SessionFactoryOptions.getServiceRegistry.
I'll try to use that instead and see how it works.

That's exactly how you get the ClassLoaderService, so +1 :D
On Thu, Oct 18, 2018 at 6:56 AM Vlad Mihalcea<EMAIL_ADDRESS>wrote:

@gsmet https://github.com/gsmet @sebersole
https://github.com/sebersole I thought that I don't have access to
ClassLoaderService, but realized that I could load it via the
SessionFactoryOptions.getServiceRegistry.
I'll try to use that instead and see how it works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/2591#issuecomment-430980498,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOUE2fGx8B45zuoMbh5pdS9UrJDakaZks5umGx1gaJpZM4Xs3Dw
.

@gsmet I noticed your commit and saw you deleted the "classpath://" test. Shouldn't we add support for that in ClassLoaderService as well?
Due to Spring, some devs might write the URI with the "classpath" scheme, although that's not natively supported by Java.

Due to Spring, some devs might write the URI with the "classpath" scheme, although that's not natively supported by Java.

I'm confused by this.  The whole premise here is that, yes, we want to add support for this where we load the resource (important distinction).  It sounds like you are asking if we want to do that (resounding yes).  Am I missing something?

As I understand it and as it is done with my commit, if Spring is used, it will register a handler for classpath:// and it will work out of the box (the first new URI( name ) will succeed).
If not, it won't.
But I think it's fair and we shouldn't try to play with the classpath:// handler considering Spring might have registered one with a different classloader than ours.
Maybe we could have an additional thing in ClassLoaderServiceImpl that removes the classpath:// prefix if there is one, once the first call has failed. This way, in the Spring case, it will work and use the Spring class loader and if Spring is not there, it will still work and use our class loader.
Would that work for everyone?

@gsmet sounds good to me.

@gsmet I think we should rebase and integrate this one. What do you think?

@vladmihalcea yes, I added a commit in the Monday morning GitHub confusion and was unable to add a comment to warn you.
I just rebased the PR.


Got ant build files working

Before, the ant build files did not know where to find Lib2585. That has been fixed. Also, I added another build file named testbuild.xml which just builds the project and does not try to deploy software to the robot.

This closes #5.


⚠ ClamAV has degraded performance

In b7a6457, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 340 ms

Resolved: ClamAV performance has improved in febc006.


rmarkdown support?

Hi Chris,
If this is too far afield, feel free to close, but am trying to figure out how to include rmarkdown as a dependency, so that I can rmarkdown::render().
Unfortunately rmarkdown requires pandoc as a dependency.  Not sure how to install pandoc in my init.R.  Would I need to fork the buildpack to include those binaries?  There's a debian package on github. RStudio also hosts binaries.
Any pointers/ideas would be greatly appreciated.  Happy to contribute back to the readme/vignette! Thanks!

Hi, yes it's possible, but would be easier with a custom build than trying to hack the buildpack. I created the heroku-buildpack-r-build for this purpose.
The pandoc debian package can be installed by adding it to the list of packages in the Aptfile of the build project. See heroku-buildpack-apt for more information on the Aptfile.
If this is something many people need, then I'll be happy to merge it in and rebuild the latest R versions.
In the meantime, I've build one for you with this package included. You can try it out by specifying the following R version as 3.2.1 and Buildpack version as 20150727-1701 in the .r-version and .r-builpack-version files respectively (see example of how to specify versions here).

ahhhhhhh -- ok, this makes a lot of sense.  thanks!

I see this is closed, but I was hoping to get some support on this same issue rather than open a new one.  I am using this buildpack version, and it is installing pandoc, however the version is <IP_ADDRESS>, and when the application runs rmarkdown::render(), it errors out with:
Error: pandoc version 1.12.3 or higher is required and was not found.
I am uncertain on how to update pandoc, any suggestions?

For anyone else finding this issue, the buildpack has been updated to include pandoc 1.15 now. (See #55)


Convert JSON to importable Jsonnet

Is your feature request related to a problem? Please describe.
It is currently hard to make custom changes to dashboards and other from this repository, while still making it possible to get future updates. For example: I would like to add the cluster variable and use DKK as currency in all the queries in https://github.com/opencost/opencost-grafana-dashboard/blob/main/dashboards/cost-reporter/opencost-cost-reporter-basic-overview.json
Describe the solution you'd like
Currently, this repository are described to contain a "Collection of OpenCost Grafana dashboards", which are currently saved as JSON.
I propose to change it to contain OpenCost mixins instead:

A mixin is a set of Grafana dashboards and Prometheus rules and alerts, packaged together in a reuseable and extensible bundle. Mixins are written in jsonnet, and are typically installed and updated with jsonnet-bundler.

It would make sense to have Grafana dashboards, Prometheus rules, and alerts in this repository written in Jsonnet, such that users can import the contents with Jsonnet and change what they want with code, instead of manually patching stuff.
Describe alternatives you've considered
Manually (or using a custom script) adding a cluster="$cluster" label to all dashboards, and what other changes I would like.

This sounds useful, we'd take a PR for sure.

Unfortunately, I am not an expert in Jsonnet so I will probably not be the best candidate for this. It could be nice to get someone else on this :sweat_smile:


Run aws cloudformation describe-stack-events on a Create Cluster failure in E2E

Description
What problem are you trying to solve?
Currently, if we experience a failure in the create-cluster step in the E2E testing suite flow, we don't get any detail on why the CloudFormation stack failed to deploy. We should automatically run aws cloudformation describe-stack-events <stack-id> after a failure to ensure that we get all the information directly in the logs.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Can I work on this as well @jonathan-innis ?

Yep! Assigned!


Implement addon hooks

The Angular2App should implement the Addon Hooks of ember-cli
The only hook that doesn't make sense for now is config, as Angular2 applications don't have configuration settings.
Let's use this issue to track our progress, but open up a new issue for each hook we intend to implement now and work on.

Same as #7, third party installation will include hooks.

how to show no records found in angular 6


fix(azure): use regular storage instead of premium

premium storage does not support block blobs, whereas regular storage does.
Error coming from wal-e, which makes workflow completely unusable with this setup:
azure.storage._http.HTTPError: Block blobs are not supported.

cc @dtzar @slack.
closes #693.

Commit that changed this behaviour would be https://github.com/deis/workflow/commit/bb54bef54ac1600d59ac1b5bc868c282cfb12b45

Yes, it is true that premium storage doesn't support page blobs.  https://docs.microsoft.com/en-us/rest/api/storageservices/fileservices/using-blob-service-operations-with-azure-premium-storage
Your removal of the premium LRS switch should do the trick.

Looks like Standard_LRS would work!?
https://docs.microsoft.com/en-us/rest/api/storagerp/srp_sku_types

thanks guys! Edited the PR to just switch the --sku flag to Standard_LRS.

LGTM2

confirmed, it works with Standar_LRS


feat(filtering): allow filtering/sorting to be opt-in

:tada: This PR is included in version 2.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


runtime: Fatal Error in heapBitsForObject during GC on Windows

What version of Go are you using (go version)?
go version go1.10 windows/amd64

Does this issue reproduce with the latest release?
???
What operating system and processor architecture are you using (go env)?
windows/amd64

What did you do?
I have a program that uses cgo. The program implements a user mode file system and is available here. The program runs on Windows, macOS and Linux.
I am experiencing this problem during testing of the Readdir operation on Windows. The problem is rather easy to reproduce with the proper setup (happens 1 every 3-4 test runs). Unfortunately it is not trivial to recreate this setup. (I can provide instructions if desired.)
What did you expect to see?
I expected the program to continue running without problems.
What did you see instead?
Every few test runs the program crashes within heapBitsForObject. I provide stack traces from two different crashes:
fatal error: unexpected signal during runtime execution
fatal error: unexpected signal during runtime execution
[signal 0xc0000005 code=0x0 addr=0xffffffffffffffff pc=0x41382e]

runtime stack:
runtime.throw(0x7164f3, 0x2a)
        C:/Program Files/Go/src/runtime/panic.go:619 +0x88
runtime.sigpanic()
        C:/Program Files/Go/src/runtime/signal_windows.go:161 +0x170
runtime.(*mspan).base(...)

        C:/Users/billziss/Projects/go/src/github.com/billziss-gh/objfs/vendor/github.com/billziss-gh/objfs.pkg/objio/onedrive/onedrive.go:635 +0x21a fp=0xc042461b80 sp=0xc042461a70 pc=0x65baca
github.com/billziss-gh/objfs/cache.(*Cache).readdirNode(0xc042128000, 0xc042394dc0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        C:/Users/billziss/Projects/go/src/github.com/billziss-gh/objfs/cache/cache.go:762 +0x171 fp=0xc042461ca8 sp=0xc042461b80 pc=0x52d451
github.com/billziss-gh/objfs/cache.(*Cache).Readdir(0xc042128000, 0x2e56, 0x0, 0x1, 0x1, 0x18, 0x6ca100, 0x1)
        C:/Users/billziss/Projects/go/src/github.com/billziss-gh/objfs/cache/cache.go:372 +0xa1 fp=0xc042461cf8 sp=0xc042461ca8 pc=0x52b5d1
github.com/billziss-gh/objfs/fs/objfs.(*objfs).Readdir(0xc0420765d0, 0xc0421a5c32, 0x1, 0xc042250300, 0x0, 0x2e56, 0xc042042058)
        C:/Users/billziss/Projects/go/src/github.com/billziss-gh/objfs/fs/objfs/objfs.go:272 +0x1dd fp=0xc042461de0 sp=0xc042461cf8 pc=0x63a56d
github.com/billziss-gh/objfs/vendor/github.com/billziss-gh/cgofuse/fuse.hostReaddir(0x103b00, 0x513fe20, 0x7ff8bace5980, 0x0, 0x513fe40, 0x0)
        C:/Users/billziss/Projects/go/src/github.com/billziss-gh/objfs/vendor/github.com/billziss-gh/cgofuse/fuse/host.go:931 +0x13f fp=0xc042461e48 sp=0xc042461de0 pc=0x53bd4f
github.com/billziss-gh/objfs/vendor/github.com/billziss-gh/cgofuse/fuse._cgoexpwrap_02f8cc1aff87_hostReaddir(0x103b00, 0x513fe20, 0x7ff8bace5980, 0x0, 0x513fe40, 0x7ff8ca82a686)
        _cgo_gotypes.go:776 +0x5a fp=0xc042461e88 sp=0xc042461e48 pc=0x538d8a
runtime.call64(0x0, 0x513fc20, 0x513fd90, 0x30)
        C:/Program Files/Go/src/runtime/asm_amd64.s:574 +0x42 fp=0xc042461ed8 sp=0xc042461e88 pc=0x454602
runtime.cgocallbackg1(0x0)
        C:/Program Files/Go/src/runtime/cgocall.go:316 +0x1aa fp=0xc042461f58 sp=0xc042461ed8 pc=0x402d6a
runtime.cgocallbackg(0x0)
        C:/Program Files/Go/src/runtime/cgocall.go:194 +0xef fp=0xc042461fc0 sp=0xc042461f58 pc=0x402b1f
runtime.cgocallback_gofunc(0x0, 0x0, 0x0, 0x0)
        C:/Program Files/Go/src/runtime/asm_amd64.s:826 +0xb2 fp=0xc042461fe0 sp=0xc042461fc0 pc=0x455bd2
runtime.goexit()
        C:/Program Files/Go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc042461fe8 sp=0xc042461fe0 pc=0x456de1

Have you ran your tests or code with -race, to verify that there isn't any memory corruption? Sometimes, these weird internal panics are because of race conditions.
I assume that the code runs fine on some non-Windows platforms?

Have you ran your tests or code with -race, to verify that there isn't any memory corruption? Sometimes, these weird internal panics are because of race conditions.

Thanks for the pointer. I will rerun the tests with -race and report back.

I assume that the code runs fine on some non-Windows platforms?

I have only observed this problem on Windows. However the test in question is a Windows-only test at this point (it is from a Windows-only file system test suite). It is unclear if the same set of conditions could result in a similar problem on other platforms.

I built the program with -race. (The build command line was go build -race -ldflags "-s -w" as I usually build it with go build -ldflags "-s -w".)
After a few runs the program appears to have crashed completely (i.e. no panic or printout). The returned ERRORLEVEL is -1073741819==0xc0000005, i.e. STATUS_ACCESS_VIOLATION. It appears that the program has crashed as before, but this time it was unable to print anything on the console.

/cc @aclements @randall77 @cherrymui @alexbrainman

I am closing this as I believe this is related to a problem with one of the cgo packages used (which has now been fixed). I will reopen if it reappears.


Better Mob ESP/Tracer Selection

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
A GUI so that the player can select what mobs are selected for ESPs and Tracers, similar to that of XRay
Describe alternatives you've considered
None
Additional context
None

Ran into a weird bug with rendering that delayed this issue - despite this, I do have a fairly good working of the new UI ready.


Observer Role has already been assigned

What steps will reproduce the problem? Trying to sign up a new guest user
What is the expected result? That the observer role had not been previously assigned
What do you get instead? The above error.
Additional info

Q
A

Version
1.0.?

PHP version
8.2

Operating system
Windows 10

The ...resources/rbac/assignments file on installation has the array filled in. This has been useful for testing but will be an empty array in future. Remove the assignment to user_id 2 to solve the above error.


Ensure updating columns triggers a re-render

Add a deep comparison of the columns prop (using JSON.stringify()) to the componentWillReceiveProps function.
fixes #662

@tannerlinsley Can you have a look at this one (happy to discuss on Slack).

Please follow this example to see how to update the columns correctly: https://codesandbox.io/s/o4q0lqqwxy

Thanks for your help @tannerlinsley that makes sense.

The moral of the above link is use the follow to update columns correctly
this.setState({       columns: [...this.state.columns]  })


Feature Request: ImGuiNotify

Thanks for the awesome work. Would be nice to include this library in the bundle too: ImGuiNotify

Please see https://github.com/pthom/imgui_bundle/issues/187#issuecomment-1991130980


TypeScript error: 'HotTable' refers to a value, but is being used as a type here.

Description
If we create react app with typescript and make use of our wrapper and typed hotRef: React.RefObject<HotTable> we receive an error 'HotTable' refers to a value, but is being used as a type here..
But we can't use typeof operator and try hotRef: React.RefObject<typeof HotTable>; because we get another error in this.hotTableComponent.current.hotInstance the Property 'hotInstance' does not exist on type 'typeof HotTable'..
So it needs further investigation.
Steps to reproduce

create-react-app and npm install handsontable @handsontable/react
try to use type or interface and use refs
npm run start

Demo

https://codesandbox.io/s/typescript-error-hottable-refers-to-a-value-but-is-being-used-as-a-type-here-xee4r?file=/src/index.tsx
Your environment

React wrapper version: 3.1.2
Handsontable version: 7.4.2

I researched the subject further and I think, however, it is not a bug.
Some constructs, such as class, introduce both a TypeScript type and a value. In our context, 'HotTable' refers to value but is being used as a type here. To use it as a type we could try typeof operator. But  typeof on a class depends on the context. In our context (value) typeof HotTable result a function, because of how classes are implemented in JavaScript. In type context typeof HotTable is type typeof HotTable, not HotTable itself.
To use HotTable as a type we must use InstanceType generic <InstanceType<typeof HotTable>>. In that HotTable is a type.
Here is an updated demo - https://codesandbox.io/s/instancetype-typeof-oj6gu?file=/src/index.tsx
What do you think @jansiegel?

@pnowak This is really insightful, and most importantly - it seems to work fine! I think it's a good way to ensure we're getting what we want in terms of class typing.
This issue seems to be caused by the usage of the addUnsafePrefixes method, which takes a class, checks the React version, and prepends the componentWillUpdate and componentWillMount methods with the UNSAFE_ prefix. I'm not sure why exactly this happens, but to be on the safe side, I moved the prefixing mechanism to the class constructor, so the typings for HotTable and HotColumn would remain unchanged on export. This way it should be possible to use HotTable as it was up to version 3.0.0.
That being said, we should schedule a task to rewrite the wrapper logic to the new React architecture, so there's no need to prefix anything no more.

I have a problem verifying that the new version of React-Handsontable fixes this problem. @wojciechczerniak  tested this locally in his application and didn't notice the blocker for release.

The error was visible in the IDE. It is no longer present in the latest Hot-React version 3.1.3


[docs] Add Onepixel to the showcase

For inspiration, here are two great showcases:

https://www.gatsbyjs.org/showcase/
https://nextjs.org/showcase/

I have changed the order of some of the websites. I have used Similarweb and the number of traffic each site gets.

Onepixel is shutting down, so the showcase doesn't work anymore. I'd do a PR but am currently overloaded with work. Could you look into this @oliviertassinari ?

@cHewN Yes, we are shutting down Onepixel, I have transitioned from this project to a fulltime engagement on Material-UI.

https://www.rank2traffic.com/onepixel.com


Giphy returns object instead of image

I can't seem to replicate this issue, closing for now

Found instance where this would occur, when gif command fails to return an image like !gif Matthew Knox


Developers need ability to fork Eth to LocalNet

The ability to fork MainNet & public testnets will be very useful for developers.
Use Cases

Fork ETh to LocalNet so to use UniSwap liquify pools
Test against real world smart contracts
Eliminate the need to deploy contracts that already exist publically.

Requested by @lucas-janon & @tarunyadav1

Looks no longer relevant, please feel free to reopen otherwise


s.infer returning unreliable typescript types for simple document schemas

Given the following document schema:
import { s } from '@sanity-typed/schema-builder';

import { wysiwyg } from './shared';

export default s.document({
  name: 'page',
  title: 'Page',
  preview: {
    select: {
      title: 'title',
      subtitle: 'lastUpdated.value',
    },
  },
  fields: [
    {
      name: 'title',
      title: 'Title',
      type: s.string(),
    },
    {
      name: 'lastUpdated',
      title: 'Last Updated',
      type: s.object({
        fields: [
          {
            name: 'title',
            title: 'Title',
            type: s.string(),
          },
          {
            name: 'value',
            title: 'Value',
            type: s.string(),
          },
        ],
      }),
    },
    wysiwyg({
      name: 'content',
      title: 'Content',
    }),
  ],
});

I get the following types produced via export type PageDocument = s.infer<typeof page>;:
type PageDocument = {
    _type: "page";
    _createdAt: string;
    _id: string;
    _rev: string;
    _updatedAt: string;
}

Note that I don't get any types related to title, lastUpdated, lastUpdated.title, lastUpdated.value, or content.
(For reference on wysiwyg, look at this issue)

Same issue as https://github.com/saiichihashimoto/sanity-typed/issues/36#issuecomment-1557884527. I suspect the return value of wysiwyg() has a type of { ..., name: string } rather than { ..., name: 'content' }, so typescript won't be certain how to name the field and it ends up consuming all the other fields. I think the same suggestion there will solve this too: make wysiwyg() return a type instead of a field, and you'll have an easier time.
Just to be clear you can make it return a field. You'll just have to manage the name being returned has to be a literal string value yourself. Also, everything else in this library is returning types, so you'll likely end up fighting upstream as you progress.


Infinite scrolling: In the operations table, only print entries that can be shown inside the screen

See also http://jlongster.com/Removing-User-Interface-Complexity,-or-Why-React-is-Awesome

http://robert.ocallahan.org/2014/02/implementing-virtual-widgets-on-web.html
http://people.mozilla.org/~roc/virtual-list-demo.html

Approximately resolved: show only a subset of operations in the front page, and set a timer to show X more operations every Y milliseconds. Works for me (thanks for the trick @padenot).

Nice one!


Add UIWebView JS Binding

Here I added the UIWebView api to cocos2d-js
Hope it meets your standard and can merge the PR.
Kind regards,

Hi, @MohHeader We really appreciate your contribution !
First of all, UIWebView is not bound because it's still experimental in Cocos2d-x, that means its APIs are not stable, and it's not implemented for all platforms. And most of all, we have other priorities. But we do receive other users claim their requirements of WebView. If you are willing to do this, we will discuss it Monday.
Secondly, about PR of bindings, we do have some rules:

No auto bindings codes (everything in frameworks/js-bindings/auto) should be committed, because they are gonna be generated automatically by a robot.
The configuration file changes should be committed instead, that means modifications in tools/tojs.
Cocos2d-JS's API should follow the same style which is different than Cocos2d-x, for example, no create functions should be bound, all constructors and init functions should be bound because we use new construction in JS.

You can refer to this discussion too: http://discuss.cocos2d-x.org/t/how-to-upload-image-within-app-to-server-with-cocos2d-js/19569/11
More specifically, if you are willing to improve your PR, please do the following:

Commit your changes in tools/tojs/cocos2dx_ui.ini instead of all the codes in auto folder.
Create a PR to Cocos2d-x repo and modify the accessibility of UIWebView's constructor to CC_CONSTRUCTOR_ACCESS so that its constructor can be automatically bound with bindings generator.

Hi @pandamicro , It is nice to hear from you.
And for sure I can understand your priorities, :smiley:
I will update the PR, based on your advice ASAP,
Looking forward to hear from you regarding Monday's meeting.
Thanks,

Hi, @MohHeader Sorry, we can't bind WebView yet because of a bindings generator problem.
The WebView is only implemented on iOS and Android, but the auto bindings codes are for all platforms, so the binding of WebView will cause compiling issue on other platforms.

Hi @pandamicro ,
What about applying the Binding in the Manual folder,
may be there we can handle the platforms issue ?
Or do you think that we have just to wait that WebView supports all other platforms ?
May be we can do both ( Move it to the Manual ) and let it stay as an unmerged  PR, so that others can benefit from it ?
Thanks :smiley:

Good idea, in this case, you need to wrap all the bindings code of WebView into a if section like this:
#if (CC_TARGET_PLATFORM == CC_PLATFORM_ANDROID || CC_TARGET_PLATFORM == CC_PLATFORM_IOS)

...

#endif

Hi, @MohHeader, I think I found another solution, we need to create another auto binding configuration file for such features (platform oriented). Then the registration function can be wrapped into a target selector macro. We have decided to merge WebView and VideoPlayer in v3.5

@MohHeader
Can you help me try this webpage https://www.anyimg.org/ with your WebView and test it on Android device?
The webpage can loaded properly but the "Pick an image" button not working on my Android device v4.4.4.
But it is working properly on iOS device v.7.1.2
Thanks.

Hi @pandamicro , That's great news,
for now I will update the PR with the new instructions, ( I know I am late, But it was a very busy week )
Hi @Zinitter Yes sure let me test it.
But I think it may have an issue with how android do handle the request to select file.
Did you tried the same page using cocos2d-x WebView ?
or it will be better if you tried using a normal android project's webview to test it.

Hi @Zinitter
I tried to search the issue too,
And yes, it looks that it needs a special handling
http://stackoverflow.com/questions/5907369/file-upload-in-webview
Note that not some Android versions ( like 4.4.4 ) needs more special handling steps.
May be you will need to create an issue on cocos2d-x github repo.
:)

Hi @MohHeader
Thanks for your help and the info you given!
Currently, i only develop with Cocos2d-JS in Cocos Code IDE.
So i only tested the page with WebView in Cocos2d-JS.
However, I tried to open the page in mobile browser of Android device, the button working fine.
May be we can reflect this WebView problem on Android to Cocos2d-X.

@MohHeader
I tested the webpage with Cocos2d-X v3.4 cpp-tests on Android device.
The button is not working.


sweep_id should be documented as str, not dict, in wandb.agent()

In the docstring for agent():
https://github.com/wandb/wandb/blob/a339333b3ee93864daf416f04c1501186dffac5c/wandb/wandb_agent.py#L534
sweep_id is specified to be a dict; however,
https://github.com/wandb/wandb/blob/a339333b3ee93864daf416f04c1501186dffac5c/wandb/sdk/wandb_sweep.py#L31-L33
specifies that sweep() returns a str.
The documentation for agent() should be fixed.

Hi @juliangilbey,
Thanks for bringing this to our notice! I'll fix this right away.
Thanks,
Ramit


Remove Mechanize

It doesn't look like we use the Mechanize gem at all. We occasionally have to upgrade it due to bugs with it and nokogiri. But if we don't use it, then no sense keeping it as a dependency.
There's no direct references to it in any of the application, analytics code (including the scripts) or statsample. It was added to the project around 2018 so may have been used in early work?
This PR removes Mechanize. As a result, its dependencies are removed too which includes a number of other gems. I've not checked to see if these might be used elsewhere.
@PhilipTB are you aware of Mechanize being used in the past? Its for performing web requests, working with web pages, etc.

Further review shows this was added in a commit in Jun 2018 when the first Gemfile was added. While Mechanize was added to the Gemfile, it doesn't seem to have been used in the scripts which at that point did direct includes.
So I think this may have been added as something to be used later and has been there ever since.


Scroll bottom limit higher than body height

I am using your plugin on a project and I've encountered a bug where the scroll stops at ~100px higher than the body's bottom.
Apparently, changing line 134 with:
minScrollTop = container.get(0).clientHeight - container.get(0).outerHeight;
(changing scrollHeight to outerHeight)
fixes the issue. I'm not sure if it's a real bug or poor implementation of other things but this seems to fix it for me

sorry, I meant to post this on a different plugin. please ignore it


464 intel power gadget alternative for apple silicon chips

[x]  CPU Metrics with Powermetrics
[x]  GPU Metrics with PowerMetrics
[x]  Update doc to explain how to give sudo rights to Powermetrics (I not then fall back to constant mode)

Thanks, it will be a great addition to CodeCarbon.

@benoit-cty this is ready for review

@SaboniAmine will you have a moment to check this ?


Help page: expand content & improve design

Right now, it's not particularly helpful. 😉
https://opentexts.world/support
User feedback will also help to inform this section. Once there's a content structure, I can look into how the design can best support that content.

I'm going to start labelling any issues that bring up issues we'll probably want to explain in a bit more detail on the help page with an add-to-help-page label, so we can more easily find & track them. I expect this label will collect more issues as we start testing the site.
Off the top of my head, we'll probably also want to explain:

how to search
how to use filters
different file formats available
how to download a dataset from a search
who to contact if you run into issues

Thanks Sarah.  Shall I start by writing one long set of help topics, and then you can take a look from a design point of view to work out how to bust structure it and split it up (if splitting up is required)?

Yes, that sounds like an excellent approach! I anticipate we'll go with a long scrolling page sort of deal here, but we'll definitely let the content dictate that. I expect it'll be something of an ongoing work in progress, especially as testing & actual usage brings up additional topics to add.

Ready for @sarahmonster to work on. Thanks! 🥇


Feature Request: Proxy

It would be useful to add a proxy flag to enable the utilization of a tool for rotating IP addresses to prevent blacklisting.

I added a pull request.


🎈 10.6.0

🎈 Release
Preparation for 10.6.0 release.
Comparison to 10.5.0: https://github.com/osrf/sdformat/compare/sdformat10_10.5.0...sdf10
Needed by https://github.com/ignitionrobotics/ign-sensors/pull/153
Checklist

[x] Asked team if this is a good time for a release
[x] There are no changes to be ported from the previous major version
[x] No PRs targeted at this major version are close to getting in
[x] Bumped minor for new features, patch for bug fixes
[x] Updated changelog
[ ] Updated migration guide (as needed)
[ ] Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Codecov Report

Merging #694 (d66b589) into sdf10 (12cfedd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf10     #694   +/-   ##
=======================================
  Coverage   87.81%   87.81%
=======================================
  Files          65       65
  Lines       10403    10403
=======================================
  Hits         9135     9135
  Misses       1268     1268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12cfedd...d66b589. Read the comment docs.

@scpeters , addressed your feedback on 2fd4065


Module version numbers in package.json are incorrect

All of the modules appear to list 7.0.0-rc.1 as their version, and non-core modules depend on<EMAIL_ADDRESS>"^7.0.0-beta.1", while 7.0.8 appears to be the latest published version.

@bclinkinbeard The latest production versions are published from the 7.0-release branch. Master is only used to publish beta releases. This is documented in https://github.com/uber/deck.gl/blob/master/dev-docs/directory-structure.md#branching-and-releasing-model.

Ah, the package versions are correct when installed but the peer deps are not. Installing @deck.gl/layers results in a package.json with the definition below. Same for /geo-layers, /google-maps, etc.
"peerDependencies": {
<EMAIL_ADDRESS>"^7.0.0-beta.1"
  },

Thanks for fixing that. I also noticed that the LICENSE file is not included in the published assets. I'm happy to create a PR if it's just a matter of adding it to files in all of the package.json files but I wanted to ask if there's a better way.

Closing in favor of #3151


ShowCase url for latest wicked-charts with chartjs is not working

https://wicked-charts-showcase.appspot.com/
Could you please check this and see if you can get the site up?
We need this for reference to create charts on our application

Hello,
Unfortunately the site seems to be getting more visitors than expected and so is sometimes offline. We'll see if we can fix that. In the meantime you can run the showcase locally by following these instructions:
https://github.com/adessoAG/wicked-charts/wiki/Developer-Info:-Starting-the-Showcase-Application

Hello,
Unfortunately the site seems to be getting more visitors than expected and so is sometimes offline. We'll see if we can fix that. In the meantime you can run the showcase locally by following these instructions:
https://github.com/adessoAG/wicked-charts/wiki/Developer-Info:-Starting-the-Showcase-Application

Thanks a lot!

The website should be up for about a year now.


Amplify update storage - add function error

Describe the bug
Adding Lambda function through Amplify update storage.
accepting default create new function.
Amplify push returns error "An error occured during the push operation: Resource is not in the state stackUpdateComplete"
Amplify CLI Version
4.21.0
To Reproduce
after successfully pushing Add storage, with options for allow auth and guest access.
go through Amplify update storage to add a function.
Expected behavior
lambda function successfully pushed to amplify backend.
Desktop (please complete the following information):

OS: Ubuntu
Node Version. 12.16.3

Additional context
existing amplify project was pulled onto a new linux machine.
the only operations performed on the new linux machine is amplify pull and amplify update storage

@pseudyx Can you check what's the status of your stack in cloudformation?


Add admin pages for WhereHows

Currently, WhereHows can only config through API. So if I want to change one job's configuration or want to add a new job, I have run the service and use 'curl' call from command line follow the steps. This is a pain for a admin who need to manage and operate the WhereHows backend jobs. What I usually do is use a database tools(Aqua data studio) which have UI so I can open a table and directly change the value there. But absolutely this is not a standard way.
We should have several 'admin' pages in frontend that could configure WhereHows backend job. User with 'admin' permission login can enter the admin pages.
These admin pages are all one to one map to database configuration tables
They contains at least these pages :

Scheduled jobs --> wh_etl_job
job configurations --> wh_etl_job_property
all applications configurations --> cfg_application
all databases configurations--> cfg_database
wherehows property --> wh_property
job execution history (read only) --> wh_etl_job_execution

In lineage ETL, there are several configuration table also better need to have a frontend:

filename_pattern
dataset_partition_layout_pattern
log_lineage_pattern
log_reference_job_id_pattern

什么时候完成哦，正在使用wherehows.

There are some news in thath issue ?


Installing dependencies in create-keystone-app fails

Creating an app fails after this command: yarn create keystone-app keystone-migration
with this error:
✔ Check ./keystone-migration
✔ Create KeystoneJS Project
✖ Install dependencies with Yarn
    → spawn yarnpkg ENOENT

because here it spawns yarnpkg instead of yarn

yarnpkg is an alias of yarn, no idea why it didn't work

Hmm 🤔 And if you run yarnpkg in that directory, it works?

@jesstelford sorry, this time I was too fast to open the issue.
I don't know why it didn't work from the beginning, but now it works as expected 🤷♂
Could be an issue unrelated to create-keystone-app.
Next time I'll investigate more before opening an issue.
Thank you!

Not a problem. Glad it's working 🎉


[VkAlternativeBridge] New bridge

Hey. This is me again, with new bridge for the VK.com. I have now moved all parsing and formatting to third-party libraries that I added to vendor/, so that it is easier for me to test and debug the core logic, and also allows me to take advantage of the modular architecture. However, in the process of profiling, in addition to the slow getContents(), I found another important bottleneck - simplehtmldom. This library not only has a few bugs that annoyed me in the past pull request, but it is also very slow at parsing and dom travel. As a result, I decided to replace it with DiDOM, which in the best scenario (the minimum number of pages download requests) accelerated the bridge 7-8 times. The library is quite handy and I highly recommend it as a replacement for simplehtmldom. I have attached zip with 3 Cachegrind files for the same request and different parsing libraries used so you can see the performance benefits for yourself. Although the performance is already much better, there is still some room for optimization, in particular, predownloading can be improved, I will deal with that later.

Good evening, @em92. What else should I do to get my pull request merged? Now this bridge is both faster and more featureful than the old bridge, and it is also fully backwards compatible.

Good evening, @em92. What else should I do to get my pull request merged? Now this bridge is both faster and more featureful than the old bridge, and it is also fully backwards compatible.

Zhestko ty refaktornul kanesh. Maybe ping other maintaners (I know @em92 got himself membership because other mantainers were busy, but still worth a shot imo)?

Maybe ping other maintainers (I know @em92 got himself membership because everybody else were busy, but still worth a shot imo)?

I plan to add an extractor that will use the public vk api in order to use it to test the extractor-parser. Also the parser itself needs to be repaired a little (direct links to the video are broken for a week already and some other minor things too, although it is still absolutely usable - I am using it as my daily driver), only after that I will probably ask for the status of a member - I'm ready to work on some other bridges and I will try not to do such big refactorings :) I'm busy at the moment, maybe after next week I can get down to it.

On a side note, any ideas how to get this working locally?

Just copy vendor/didom, vendor/vk-post and bridges/VkAlternativeBridge.php to corresponding folders in your instance root.

Other "non-official" bridges were self-contained php files I just threw in bridges.

These are new dependencies in the vendor folder, a new parser library (otherwise parsing took forever with the standard simplehtmldom) and my mini-libraries into which I took out extraction and formatting - they wouldn't interfere with other bridges and rss-bridge itself.
I believe rss-bridge should let to split bridges in several files naturally (in their own directory), as some sites require a lot more code to effectively support, in particular social networks sites - which need most the conversion to RSS!

Sorry we are not adding 3 vendor libs for this.


💡 [FEATURE] - Add Chatbot

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request

Explain your solution
The hover effect on social media icons is an interactive design feature that activates when a user places their cursor over any social media icon on the website.
Any alternative approaches/features
No response
Additional Context
No response

Hey @jfmartinz , I want to resolve this issue . Please assign this to me under GSSOC.

Can you explain the issue further? I ccant understand what you wanat to do

I want to add a chatbot section to your website, which will help attract people.

Please assign this issue to me under GSSOC labels.


Fix to note about OneWay vs. OneTime performance

@jwmsft : PR passed acceptance checklist. Please evaluate the change further for technical accuracy and handle as appropriate. Thanks!

@tiwahu , thanks for submitting this correction.


chore(deps): update common-dev-assets digest to 540953e

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
3154a9b -> 540953e

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.6.3 :tada:
The release is available on:

GitHub release
v1.6.3

Your semantic-release bot :package::rocket: