Deployment of Autosubmit GUI Mock version

In GitLab by @wuruchi on Nov 9, 2021, 14:01
Hello @kserrade @mcastril
We are presenting the latest developments of Autosumit GUI and its components at the next ec earth meeting, next Thursday. Since an important part of the presentation revolves around the new interaction available through Autosubmit GUI, we have developed a mock version of Autosubmit GUI that the attendants can use to play around. This version has some restrictions and doesn't query real data but some predefined examples.
In consequence, we need a place (host) to deploy this mock version so it's accessible to the public. We will need a web server: apache, nginx, etc. This host can be outside the BSC network. I am planning on using a URL shortener to share its location at the beginning of the presentation.

In GitLab by @wuruchi on Nov 9, 2021, 15:49
@kserrade Sure, but if possible we would prefer that the address doesn't start with https://earth.bsc.es/ because we don't want the attendants to accidentally discover the real Autosubmit GUI. FYI @mcastril.

In GitLab by @kserrade on Nov 10, 2021, 10:54
Yes, this is something that always bothered me.
Why not ask for the authentication by CAS to any connection to autosubmit app?

In GitLab by @mcastril on Nov 10, 2021, 11:15
I also continued thinking about it yesterday, and I also got to the conclusion that maybe we have to force all users to login in order to use the application.
My only concern was that users will need to run the VPN to use the app. But given that there is even a mobile VPN we have not many excuses.

In GitLab by @kserrade on Nov 9, 2021, 16:07
Ok. I will ask now.

In GitLab by @wuruchi on Nov 9, 2021, 16:07
@kserrade https://autosubmit.bsc.es/presentation should be Ok. I have created the folder /srv/www/htdocs/autosubmit_presentation01 in bscesweb04 for this purpose.
FYI @mcastril

In GitLab by @mcastril on Nov 10, 2021, 11:15
The Autosubmit one

In GitLab by @wuruchi on Nov 10, 2021, 11:14
Hello @mcastril
Which repository? The Autosubmit (this one) or the Autosubmit GUI one?

In GitLab by @wuruchi on Nov 10, 2021, 11:16
Ah, yes. The documentation has some references to the GUI.

In GitLab by @mcastril on Nov 9, 2021, 17:46
Thanks @kserrade, that would be perfect. Our main concern was that the URL was too similar to the real one.
PS: By the way, this repository is public and I saw some issues in which the full URL is exposed... I edited a few but there are at least a dozen

In GitLab by @wuruchi on Nov 10, 2021, 12:11
@kserrade Sure. I will open an issue once I start working on it to keep track of its progress.

In GitLab by @kserrade on Nov 10, 2021, 11:33
I would require authentication. If you access the GUI, I assume you're working so you should have your VPN enabled.
@wuruchi could start the developments and testing and as soon it's ready, we announce it and we give one week before enabling it.

In GitLab by @wuruchi on Nov 15, 2021, 12:29
Hello @kserrade @mcastril
https://autosubmitgui.bsc.es/presentation/ is working.

In GitLab by @wuruchi on Nov 19, 2021, 13:27
Hello @kserrade
We will start with the development of further authentication restrictions that will require users to be authenticated by CAS in order to access Autosubmit GUI. For this purpose, we will need a testing platform capable of sending authentication requests to CAS. There are the requests:
I have created the /srv/www/htdocs/autosubmittest at bscesweb04, so we need a URL pointing to that folder, I suggest: https://earth.bsc.es/autosubmittest/. Then, we will need that CAS accepts requests from that URL, similar to what we already have with https://earth.bsc.es/autosubmitapp/.
This new web will allow us to test the authentication development and also to test features in a more realistic scenario.
FYI: @mcastril

In GitLab by @kserrade on Nov 12, 2021, 11:08
@wuruchi, the alias is ready.
https://autosubmitgui.bsc.es/presentation/ --> /srv/www/htdocs/autosubmit_presentation01/presentation
I could not use autosubmit.bsc.es because is already in use (pointing to bscesautosubmit01). By the way @mcastril are you aware of this link (I wasn't)? Is currently used?

In GitLab by @mcastril on Nov 15, 2021, 19:21

I could not use autosubmit.bsc.es because is already in use (pointing to bscesautosubmit01). By the way @mcastril are you aware of this link (I wasn't)? Is currently used?

I wasn't, and I don't think that anybody is using it... Also, having two different machines I don't think it is useful to have an alias for just one of them.

In GitLab by @wuruchi on Nov 10, 2021, 11:18
Well, we can always limit the actions of non-authenticated users. In some way, that will force users to login without being too restrictive.

In GitLab by @wuruchi on Nov 22, 2021, 11:22
Thanks @kserrade
https://earth.bsc.es/autosubmittest/ is working. I will test the connection to CAS now.

In GitLab by @wuruchi on Dec 1, 2021, 12:50
Thanks @kserrade

I've found one bug. When you log out, you still can see all experiments (as being logged in).

If you refer to the ACTIVE EXPS button, then that is intended, but we can change it. However, if you are still able to access the experiment's tree or graph view, then that's a bug. It happened to me the first time I opened the page after the update, I suppose it has something to do with the browser cache. Please try again.

When should we deploy this version?

I am thinking about Thursday next week, but I'd wait for @mcastril input.

In GitLab by @kserrade on Nov 19, 2021, 16:36
Sysadmin contacted. I will contact you as soon as it's ready.

In GitLab by @mcastril on Dec 1, 2021, 12:49
@kserrade I think that this is on purpose. The idea is that our users do not need to log in all the time.
Of course, this could be a problem in the case of using a shared computer... but we could assume that they have different computer users.
What do you think about that?
Maybe, we could add an option to keep the token for 7 days or not.

In GitLab by @kserrade on Nov 22, 2021, 11:08
Should be working. Can you test it?

In GitLab by @kserrade on Dec 1, 2021, 12:39
Great @wuruchi. I completely agree with the points you shared.
I've found one bug. When you log out, you still can see all experiments (as being logged in).
When should we deploy this version?

In GitLab by @wuruchi on Nov 22, 2021, 14:19
Hello @kserrade
After a couple of pitfalls, I can confirm that the CAS authentication is working in the testing environment. I'll start working on the login improvements now.
FYI @mcastril

In GitLab by @wuruchi on Dec 1, 2021, 12:21
Hello @kserrade @mcastril
The login restrictions have been applied in the build https://earth.bsc.es/autosubmittest/
The current behavior is:

All users can see the Home page (Search page) and perform searches.
Only Logged Users can access the experiment information (Main page that contains all the views).
When an unidentified user tries to access the experiment's information page, the app redirects to the CAS Login page. If logged in (in CAS), the user is redirected to the Home page where the right credentials and the user token have been set up for future usage.
The tokens are generated using JWT on the server side.
Once the session token has been set up, it will be valid for 10 hours (I am thinking about increasing it to 7 days but it is open to discussion). The user will be correctly identified by this token, which is stored in the browser, even if the VPN connection is not active. In this way, the user only needs to connect to the VPN to be authenticated.
Every time the user enters the Home page, a verification procedure tests the authenticity of the token. I might move it to some more common component, but I don't want to saturate the server with authentication calls. However, it can be done if required.

In GitLab by @wuruchi on Dec 2, 2021, 14:18
Hello @mcastril

When I logged out I wasn't redirected to About. Is it something to be developed?

Probably a cache issue, refresh the page and try again.

If I understood well (and after doing some tests) the GUI will no longer remember the user if CAS is not active.

Currently, the App should be able to remember, for up to 10 hours, a logged in user even if CAS is not accessible. If you logout, then the App forgets the user and will request authentication through CAS in the next visit.

In GitLab by @mcastril on Dec 1, 2021, 14:45
Sorry, that was not accurate. I was referring to the experiment description, shown in the search view.
Usually, people fill in the project name there, and so on.
Would it be possible to make the CAS login appear just before loading the page? Maybe that's easier and it will work forever.
Reason: We planned to add additional tabs with information about the resources (used space, queues, etc)

In GitLab by @mcastril on Dec 2, 2021, 12:42
Thank you @wuruchi.

When I logged out I wasn't redirected to About. Is it something to be developed?

If I understood well (and after doing some tests) the GUI will no longer remember the user if CAS is not active. I am not against it, but neither I am against remembering users in the same system for some days as we discussed.

In GitLab by @mcastril on Dec 1, 2021, 12:55
Thanks @wuruchi.
Do you think that it is enough to only hide the details? I am not sure, this is an open question.
Some of the experiment descriptions are really detailed, and looking at some different days maybe be enough for anybody to know the projects that we are working on.

In GitLab by @wuruchi on Dec 1, 2021, 12:57

Do you think that it is enough to only hide the details?

Sure, we can also disable the Summary or any other buttons from the Home page based on the logged status.

In GitLab by @wuruchi on Dec 1, 2021, 17:24
Hello again @mcastril @kserrade
I've implemented some requested improvements:

It is necessary to be authenticated to access the Home page. Otherwise, the app will redirect to the CAS login page.
On subsequent visits, and after authentication, the Home page will open and the user name will be displayed in its regular place.
The Logout button now takes you to the About page, some sort of Good Bye page. If the user tries to access the Home page from there, it will reuse the CAS cookie (if available and valid) and authenticate; otherwise, it will redirect to the CAS login page.

In GitLab by @wuruchi on Dec 1, 2021, 15:19

Sorry, that was not accurate. I was referring to the experiment description, shown in the search view.

Yeah, I have added that those are hidden for non-authenticated users.

Would it be possible to make the CAS login appear just before loading the page?

Yes, I will implement it.

In GitLab by @wuruchi on Dec 1, 2021, 12:52
Hello @mcastril

Maybe, we could add an option to keep the token for 7 days or not.

Yeah, I am not sure about this setting, 5 days seems Ok too. You log in on Monday and forget about it until next week.

In GitLab by @kserrade on Dec 1, 2021, 12:56
Yes, it was a cache issue. In the end, even if you log out, you still have the CAS cookie active in your browser.

In GitLab by @kserrade on Dec 13, 2021, 10:00
I agree with the date and sending an email to the users a week before.

In GitLab by @mcastril on Nov 9, 2021, 14:01
moved from autosubmit#752

In GitLab by @wuruchi on Dec 20, 2021, 10:25
The new version that requires authentication has been released.
If any problem arises, I will create another issue.

In GitLab by @mcastril on Dec 3, 2021, 18:03

Probably a cache issue, refresh the page and try again.

Probably I didn't understand the behavior. I tried it with Firefox and Chrome, using Private sessions, and it doesn't work for me.

Currently, the App should be able to remember, for up to 10 hours, a logged in user even if CAS is not accessible. If you logout, then the App forgets the user and will request authentication through CAS in the next visit.

Yeah, yesterday I was trying to disconnect from the VPN right after, and after entering again in the GUI it was trying to connect to CAS. But now it seems to work fine.

In GitLab by @wuruchi on Dec 10, 2021, 17:15
Hello @mcastril @kserrade
I think it is almost an agreement now that the token should last 5 days (120 hours). So now the question is: When should we deploy it? I am thinking about next Monday 20th. In that case, I'd send an email to the users on Monday 13th informing them about the upcoming changes.

In GitLab by @mcastril on Dec 13, 2021, 10:33
I also agree with the date. Informing the users is very important too.

In GitLab by @wuruchi on Dec 6, 2021, 22:38
Hello @mcastril
I am glad it is working now. We still haven't decided for how long should a token be valid. I am inclined to make it 5 days.


Invalid value of AF read; Flag ingerpretation

Hi,
I have met surprising behaviour while loading this simple VCF with 2.1 version.
The source vcf looks like:
##fileformat=VCFv4.2
##INFO=<ID=AC,Number=A,Type=Integer,Description="Allele count in genotypes, for each ALT allele, in the same order as listed">
##INFO=<ID=AF,Number=A,Type=Float,Description="Allele Frequency, for each ALT allele, in the same order as listed">
##INFO=<ID=AN,Number=1,Type=Integer,Description="Total number of alleles in called genotypes">
##INFO=<ID=DB,Number=0,Type=Flag,Description="dbSNP Membership">
##INFO=<ID=DP,Number=1,Type=Integer,Description="Total depth of called genotypes">
##INFO=<ID=MAJ,Number=1,Type=String,Description="Major allele is REF or ALT">
##contig=<ID=MT,length=16569>
#CHROM  POS     ID      REF     ALT     QUAL    FILTER  INFO
1       10109   rs376007522     A       T       22940.40        .       AC=86;AN=176;AF=0.4886;DP=17307;MAJ=REF;DB
1       10150   rs371194064     C       T       2276.70 .       AC=31;AN=176;AF=0.1761;DP=15279;MAJ=REF;DB

I read it using com.lifeomic.variants and below is what is read.
scala> val myVcf = spark.read.format("com.lifeomic.variants").option("use.info.map", "true").option("use.info.type", "true").load("....vcf")
scala> myVcf.show
+-----+-----+-----+-----+-----------+---+---+--------+------+---+---+-----+-----+----+----+
|chrom|  pos|start| stop|         id|ref|alt|    qual|filter| an|maj|   dp|   af|  ac|  db|
+-----+-----+-----+-----+-----------+---+---+--------+------+---+---+-----+-----+----+----+
|    1|10109|10108|10109|rs376007522|  A|  T|22940.40|     .|176|REF|17307|[0.0]|[86]|null|
|    1|10150|10149|10150|rs371194064|  C|  T| 2276.70|     .|176|REF|15279|[0.0]|[31]|null|
+-----+-----+-----+-----+-----------+---+---+--------+------+---+---+-----+-----+----+----+

What is suprising is:

The AF data is lost. It is set 0.0 without visible reason.
Flag DB is not interpreted correctly, I would expect db to have boolean value, while the DB data is lost completely here...

Thank you for your time, best wishes,
Piotr

Yeah, I'll take a look. Thanks.

My guess is the vcfs that we have looked at expect the info fields to be there. I'll try to get a patch up that tests with null info columns.

Found the bug. A fix will be up momentarily and I can push it to maven central. Thanks for reporting it.

Released version 0.3.0. https://oss.sonatype.org/#nexus-search;quick~lifeomic .
Some important notes that will be apart of the release notes. Type Info fields will now have a prefix attached to the key of info_ due to the fact there were cases of collision in names with format fields.


preStop hook got interrupted and graceful termination failed

Hi masters,
I'm trying out preStop hook supported by latest spark-operator, and I noticed the preStop hook failed if I run some time-consuming task or simply sleep for a while before pod terminated. The chart spec is the same as in user-guide:
spec:
  driver:
    lifecycle:
      preStop:
        exec:
          command:
          - /bin/bash
          - -c
          - touch /var/run/killspark && sleep 65

Detailed error message are as below:
[root@wzhan-node1 opt]# kubectl describe pod spark-app-driver
  Warning  FailedPreStopHook  1s         kubelet, rob-ha-local-node6  Exec lifecycle hook ([/bin/bash -c touch /var/run/killspark && sleep 65
' exited with 137: , message: ""

Starting from stopping driver container, it took about 30s before showing FailedPreStopHook, setting terminationGracePeriodSeconds to 60 sec didn't help either.
Any idea why this is happening?
Thanks,
Wenjing

Hi, I am facing the same issue. Did you get a solution?


[Bug]: Just go to my server and explodes

Description

Error: Attempt to read property "project" on null (View: /var/www/html/resources/views/livewire/server/delete.blade.php) (View: /var/www/html/resources/views/livewire/server/delete.blade.php) (View: /var/www/html/resources/views/livewire/server/delete.blade.php)

Minimal Reproduction (if possible, example repository)
Just go to my server and explodes
Exception or Error
No response
Version
147

@andrasbacsai

Can you please manually run the following command on your server:
docker exec -ti coolify bash -c "php artisan app:init --cleanup"
And let me know if it solves your issue. IF not please reopen the issue.

Thanks bro, can you explain me what could happend to learn?

yep, on restart error: https://github.com/coollabsio/coolify/issues/1499 @andrasbacsai


make test fails

Fatal error: exception Failure("This function always errors")
W: Test 'test_error' fails: Command '/home/ygrek/work/contrib/sqlite3-ocaml/_build/test/test_error.native' terminated with error code 2
E: Failure("Tests had a 16.67% failure rate")
Makefile:13: recipe for target 'test' failed
make: *** [test] Error 1

This started to happen with v4.0.0.
Here is the output from v3.0.0 which works ok :
This function always errors
Bind threw an error

Thanks, I've improved the testing application.  The library actually behaved as it should, but the testing application didn't.  I guess you don't need an immediate release.  Installation should still be possible.


If OpenAI key is provided but there is no credit card associated spinner just spins

Need to catch this case and show an error on the progress page.

Got a variant of this because I hadn't made my credit card 'pay up front:

Found the solution here.

However, to be clear, (after a bit more thought), I think the plug-in is doing the exact right thing already in my case. It forwarded the failure message to me, and then I handled it with OpenAI.


:bug: virtual/authorization: shallow copy of RBAC objects

Summary
No need to deep-copy for changing the name. This switches to shallow copies in virtual workspace authorization hot path.
Related issue(s)
Fixes #
Release Notes

Optimize authorization in virtual workspaces.

/lgtm
/approve


Intel Fix: INTEL_NAME [MAP][ID]

Name
Requiem/Omega
Intel Id
No response
Fix Needed
There seems to be a requiem intel that is labeled as an omega intel.
The website says that theres 200 requiem intel and 161 omega intel, however it should be 201 requiem and 160 omega intel.
Don't know which one exactly but if i find while on my intel hunt i will update this for whatever one it is
Any Other Info
No response

@SxyDragon thanks for this, looks like it's one of the omega documents. Will investigate.


[BUG] Plugin (Sliding Planes (Andy's Mode)) Compatibility Problem

Describe the bug
while stacking multiple panes, some panes (only the stacked one on the left side) get translucent (background)
To Reproduce
Steps to reproduce the behavior (this is an example):

open more than 2 files, while stacking the panesthe issue occours

Screenshots
https://imgur.com/J0prTgN
Version [Desktop or Mobile]:
Desktop
Additional context
see screenshot, should be enough to understand the issue

Pushed a fix


Enhacements.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

[x] Add page error custom for bulma.
[x] Add  visual indicator to labels of required fields.
[x] Add tests page error.

Add custom error page.
Add visual indicator to labels of required fields.
Add tests for error page.

👍


UX: Display a better error message if the reason for no backends is #lines > disable_max_lines

When attempting to open Aerial, if there is an appropriate backend but there are more than disable_max_lines lines in the current file, Aerial displays the notification "Aerial could find no supported backend". This confused me for a few minutes, until I ran AerialInfo and saw "File exceeds disable_max_lines size". It would be helpful if this information was included in the initial error message.

That error message is left over from an earlier time. I think it makes more sense now to always open the aerial window, even if there are no symbols. This is more consistent with the behavior that happens if you open aerial and switch to an unsupported buffer. Plus, now we put some detailed diagnostic information in the window if there aren't any symbols, so it won't be as confusing!

I think it makes more sense now to always open the aerial window, even if there are no symbols.

I agree, this would be a nice improvement. Thanks for fixing this!


State variables don't respect module namespaces

Given
module A {
  var x: int
}

module B {
  var x: int
}

module C {
  import A
  import B
  action step = all {
    A::x' = A::x,
    B::x' = B::x,
  }
}

We get
$  quint typecheck t.qnt
t.qnt:2:3 - error: [QNT202] Multiple updates of variable x
2:   var x: int
     ^^^^^^^^^^

t.qnt:6:3 - error: [QNT202] Multiple updates of variable x
6:   var x: int
     ^^^^^^^^^^

error: typechecking failed

But I would expect these variables to be completely distinct.
On the face of it, this looks to me like an iteration of the general namespacing motif from #1288.

Oh right. My solution considered only instances, but this should also include namespaces. I'm afraid this will be more complicated to fix, tho. We'll figure something out.


Where is the cursor?

@cjwirth
Hello
When I input text, view doesn't scroll to the cursor position.
https://www.dropbox.com/s/qsn324g41ns0o2e/Cursor.mov?dl=0
PS: After pod install code is different with your example code.
For example, in you sample code has adjustContentOffsetFromCaretPosition, but master branch has no it.

The master branch has the bugfix for this merged in, but I haven't released it. There might be some bugs (there are 2 issues about the placeholder right now) that might be due to this bug fix.
This issue, however, has already been fixed on master.
You can use
pod 'RichEditorView', :git =><EMAIL_ADDRESS>:branch => 'master'

to install the master branch into your project instead of the current release.


docs(form): screen reader warning

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
This is needed as screen reader users will explore the form before filling it out. If there are validation messages this can be confusing as they are trying to just understand the form content.
Issue Number: #3557
What is the new behavior?
Update docs to explain screen reader support for validation message behavior. Screen reader users need message describing how validation messages are triggered. This is needed as screen reader users will explore the form before filling it out.
Unfortunately Angular does not have an easy way to check if there are any validators applied to a given form so this will need to be managed on the application side. https://github.com/angular/angular/issues/13461
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@clane updated


Publish 07/26/2022 3:30 PM PT

Docs Build status updates of commit a5da63a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-MobileDeviceStatistics.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


MKOB: Playback doesn't allow blank lines in .pkrec file

@leskerr mentioned:

I edited the .pkrec file to delete large parts of the recording that aren't relevant, and I included blank lines between sections to make the breaks easier to find in the editor. However, MKOB chokes on those blank lines so I had to remove them.

PKREC files (recordings) can now have blank lines and (full line) comments. The comments must be on a line of their own and start with either '#' or "//". Comments may include leading whitespace.
Unfortunately, comments cannot be at the end of a data line, as JSON doesn't support that.


[Documentation] API Docs use http rather than https

Throughout the API documentations, the code examples currently use http rather than https. This means following the docs faithfully or using copy/paste generates 301 responses:
As documented:
http http://dmptool.org/oauth/token grant_type='client_credentials' client_id=$DMPTOOL_CLIENT_ID client_secret=$DMPTOOL_CLIENT_SECRET scope='public'
HTTP/1.1 301 Moved Permanently
Connection: keep-alive
Content-Length: 134
Content-Type: text/html
Date: Wed, 19 Oct 2022 15:10:47 GMT
Location: https://dmptool.org:443/oauth/token
Server: awselb/2.0

<title>301 Moved Permanently</title>

301 Moved Permanently

With protocol revised:
http https://dmptool.org/oauth/token grant_type='client_credentials' client_id=$DMPTOOL_CLIENT_ID client_secret=$DMPTOOL_CLIENT_SECRET scope='public'
...headers elided...
{
    "access_token":  "==token-provided-here==",
    "created_at":<PHONE_NUMBER>,
    "expires_in": 6092,
    "scope": "public",
    "token_type": "Bearer"
}

(Commands issued using httpie rather than cURL for ease of use.)

(FWIW, I'm happy to help go through and make those changes to the documentation if desired.)

Thanks for pointing this out @TSSlade.

Thanks again for pointing this out @TSSlade. I have updated the docs


Add support for containerd runtime

Is your feature request related to a problem? Please describe.
When installing pixie on a cluster that uses the containerd runtime, most cluster metadata is missing.

Hey @safarmer , the fix for this has just rolled out in our latest release (0.7.7). If Pixie is still running on your cluster, it should already be auto-updated to the latest version. Otherwise, you can redeploy with px deploy and it should automatically deploy.
In case you're wondering, the changes for the fix are here: https://github.com/pixie-labs/pixie/commit/f6dca0f5b4fba1ae0d92cdfaa18839883458eebc
We look for "containerd" in the container ID, and use cri-containerd in the cgroup proc file path if that is the case.
Let us know if this worked for your environment!

Thanks @aimichelle for the quick fix. I can confirm that cluster metadata is working correctly.

Awesome! Glad to hear that it's working now. Feel free to reach out again if you run into anything else/have any questions.
Closing this issue now, since it's been resolved.


Allow user to put comments in when configuring a tool

@bpagon13 doesn't this already work if they start the line with a #?

It does work in the sense that vent doesn't evaluate it at all when saving or pulling up configurations. However, any comments that are made are not pulled up and shown when a user is trying to configure a tool. This could be a pain if a user comments something out to try something out, and then when they go back in to uncomment it, it's not there anymore.

ah, good point.


failed to create fsnotify watcher: too many open files

+ /usr/local/bin/dockerd --data-root /var/lib/docker
failed to create fsnotify watcher: too many open files

and many other steps:
+ yamllint .drone.yml
--
2 | + yamllint .devcontainer/docker-compose.yml
3 | .devcontainer/docker-compose.yml
4 | 1:1 warning missing document start "---" (document-start)
5 |
6 | + yamllint config.yaml
7 | config.yaml
8 | 1:1 warning missing document start "---" (document-start)
9 |
10 | failed to create fsnotify watcher: too many open files

From job log:
$ kubectl -n drone logs drone-job-2123-sfdiczvmqhfscmqth-vm4q7
{"arch":"amd64","level":"debug","machine":"***","msg":"runner: get stage details from server","os":"linux","stage-id":2123,"time":"2019-07-05T02:10:40Z"}
{"arch":"amd64","build":6,"level":"info","machine":"***","msg":"runner: start execution","os":"linux","pipeline":"default","repo":"***","stage":1,"stage-id":2123,"time":"2019-07-05T02:10:41Z"}
{"arch":"amd64","build":6,"error":null,"level":"info","machine":"***","msg":"runner: execution complete","os":"linux","pipeline":"default","repo":"***","stage":1,"stage-id":2123,"time":"2019-07-05T02:14:22Z"}

So, It seem that my Kubernetes node is running out of file descriptors. which is fine, easy to fix.
but the build step clearly failed, but the build is all green. When a job fail with an error, it should not pass.

Drone can handle proper exit codes, if a step doesn't exit with a code >0 it's by design green.


Month Dropdown should respect the min/max dates

Right now the months are just a hardcoded list https://github.com/Hacker0x01/react-datepicker/blob/master/src/month_dropdown.jsx#L83
If my min date is December 31st 2008 and my max date is January 1st 2010 then all the months in 2008 and 2010 will be selectable in the months dropdown despite my date limit. Can the month dropdown be a bit smarter and figure out the months that are actually available given the min/max date range?

Related to #642

@rafeememon lol I forgot that I had commented on that


Logo Designs

Good Day, These are the files for the design, I also add banner design in your readme file. Thank You

Dear sir, will it be merged?

Sorry for asking this but will this PR will be merged?

Thanks!

@jbeguna04 feel free to send another PR to list your name in the credits https://github.com/f2prateek/dart#credits. Something along the lines of "The logo was designed by Jibbie Eguna".


KAFKA-7503: Connect integration test harness

Expose a programmatic way to bring up a Kafka and Zk cluster through Java API to facilitate integration tests for framework level changes in Kafka Connect. The Kafka classes would be similar to KafkaEmbedded in streams. The new classes would reuse the kafka.server.KafkaServer classes from :core, and provide a simple interface to bring up brokers in integration tests.
Signed-off-by: Arjun Satish<EMAIL_ADDRESS>Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@rhauch @kkonstantine @ewencp any thoughts on this PR? thanks!

@kkonstantine thanks so much for your multiple passes. I believe I've addressed all your comments (tried something a bit with the latches though). Please take a look at the changes, and let me know if they work out.

Thanks so much, @kkonstantine. Highly appreciate the review comments.
@rhauch I believe I have addressed all your comments as well. would you mind taking another pass at this?

one quick question to everyone. do you think it makes sense to move the EmbeddedConnectCluster and EmbeddedKafkaCluster to /connect/runtime/src/main/java/org/apache/kafka/connect/tools/? this well help us package these classes in case we want to use them to test connector code in the future. thanks!

@ewencp any thoughts on this PR?

@ewencp any chance you could squeeze in a review of the latest changes?

@ewencp looks like I misinterpreted the changes needed to set the connect port dynamically. I've added commits which configure connect to pick any available (by setting rest.port to 0). also, we should now be able to bring up multiple connect workers. finally, the classes were refactored for readability. specifically:

moved out the HANDLES map in MonitorableSinkConnector into a separate class(es) to make the overall code to monitor record arrival more readable;
the MonitorableSinkConnector connector now no longer manages latches, this is done in the handles. the tasks only call TaskHandle methods to count down latches on message arrival.
the ConnectorHandle class records the messages arrived in all of its tasks. this is useful when we cannot rely on an exact number of messages coming into tasks (for example: in the multi worker case, the tasks can get rebalanced multiple times, and there is a race condition on which task consumes how many records).

retest this please

@ewencp: we have a green build (JDK 8) now. Could you please take a look at this PR, and if it looks good, can we merge it? thanks!

@wicknicks This is looking very close, just a few last issues I found.


votewitness success executed when witness is missing

Impact:
Data about missing witnesses saved in database
STR:

Start Golos dApp on Cyberway
Vote for missing witness

Actual result:
votewitness action completed successfully
Expected result:
votewitness action must failed with error about missing witness

#277


Pause menu crash

When I either try to save or click off of starfield then click back in and it goes to the pause menu it crashes starfield everytime it happens without fail and I have tried every method known to try to fix it without success I do use cheat engine 7.5 so not sure if that could be the cause because it happened before I got that also

Game Version
<IP_ADDRESS>
New Game
Yes
Reproduction Steps
Attempt to save or click off of starfield then click back on starfield to where it automatically brings up the pause menu

I have over 100 hours into the game without a single crash. I'm sorry to say this is likely an issue specific to you. The fact that you are using a third-party program alongside the game is a very common cause of these types of issues. Not saying it is the cause, but it's certainly not the way the code from Bethesda was expected to operate.
I don't think a "patch" is going to fix this issue for you. You need to do some work locally to determine why you have such an unstable operating environment.


Handinteraction Demo in Unity Holographic Remoting

Describe the bug
Enabling MRTK, then Holographic Remoting. Build settings ARM running a Hololens 2. When running holographic remoting, the handtracking doesn't seem to register touch. However, occasion grabbing is registered. There is the option to toggle these actions, but this doesn't affect the result.
To reproduce
Steps to reproduce the behavior:

Unity version 2019.4.3f1
Add MRTK
Load examples
Open handtracking demo
Try to play the keyboard. You'll have the hand tracking rays, but no hand interactions.

Expected behavior
When the hand intersects the keyboard, the notes should play. This performs as expected in Unity when using manual controls. When loaded in Hololens 2, there are only hand rays.

Unity Version [e.g. 2019.4.3f1]
MRTK Version [e.g. v2.5.2]

Target platform (please complete the following information)

HoloLens 2

Additional context
Doesn't seem to work for other demos either.

If you're using the legacy Windows Mixed Reality package, you'll need to additionally install DotNetWinRT.
If you're using Windows XR Plugin with an MRTK version pre-2.7.0, you'll need to make sure you're using the correct profiles. It sounds like your profiles are correct if you see hand tracking rays, so my best guess is that it's the DotNetWinRT configuration.
I'm going to close this out as it's had low traction for a few months, but please re-open if you're still having issues!


[Normal Mode] viw key combination differs to vim

In normal mode typing VIW selects from the current char to end of the word. In classic vim the whole word. I don't know if is a deliberate behavior or it can be configured.

Indeed, this looks like a bug. What's strange is the iw motion works with operators, but not doing the correct thing in visual mode.

having
const prepareApps =
it sometimes selects prepareApps and the =`
and sometimes it selects nothing but the actual character where the cursor is on.

I believe this was fixed in #2429.