Registering a dll built on 64 bit machine doesn't seem to work on 32 bit machines

Hello Dave,
Thanks alot for the awesome library, I built a project involving ContextMenu and Overlay Handlers. My development machine is 64 bit system. I built with release Mode(Solution Config) and Any CPU(Solution Platform) settings.
I am able to register the dll on other 64 bit machines and its working fine. If I try to register the same dll on 32 bit system It doesn't get register.

With ServerManager : The dll can't be loaded and I get "The file filename.dll is not a sharpshell server" error
With Regasm : I get error RA0000 : Could not load file or assembly 'filename.dll' or one of its dependencies. Operation is not supported. (Exception from HRESULT: 0x80131515)
With Server Registration Manager : Fails to load dll and I get unhandled exception.

I'm able to register the same dll via all 3 methods in 64 bit system, any insight on this would be helpful, should I build again on 32 machine ?

You could try using the configuration (Platform) for x86 instead of Any CPU.

@Countryen Ya that would create another dll for 32 bit machines which I am trying to avoid here.

I have compiled as any platform in my project without problem, I'm using regasm to register. Please check the source at apkshellext
-----原始邮件-----
发件人: "sagar UDAY KUMAR"<EMAIL_ADDRESS>发送时间: 2015/9/4 18:02
收件人: "dwmkerr/sharpshell"<EMAIL_ADDRESS>主题: Re: [sharpshell] Registering a dll built on 64 bit machine doesn'tseem to work on 32 bit machines (#90)
@Countryen Ya that would create another dll for 32 bit machines which I am trying to avoid here.
—
Reply to this email directly or view it on GitHub.

@sagaru Why do you want to avoid that? You want it to run on 32bit so it would be best to compile for 32bit.
It's at least worth a try.

@Countryen The idea is just to have only one dll compatible for all machines. (dll compiled on 32bit machine does work on other 32bit machines)
@kkguo Thanks for comment and for giving reference to your project, I'll check and get back to you. meanwhile have you even tried with dotnet TargetFrameworkVersion as v4.0 sometime?

From my experience, you can not mix 32 and 64.
I always distribute both 32bit and 64bit versions of my program, explaining which one to install. If there is any easier way I would be glad to hear about it though :-)

@nicolas-raoul , for .net dll, yes, you could compile the dll as "any cpu", and it will be loaded both 32bits and 64bits according to loading environment.

Looks like this can be closed, but please re-open if needed.


Don't throw the exception of Bloom filter config has been changed in BloomFilter

https://github.com/redisson/redisson/blob/dcab532b84530f5c64db10826bf8bab03d957568/src/main/java/org/redisson/RedissonBloomFilter.java#L163-L165
If we modify bloomfilter's config in redis, it will make contains function cycling constantly.

Fixed in https://github.com/redisson/redisson/issues/5130


Fixes issue with StopIteration exceptions using python 3.7

Python 3.7 changes how StopIteration exceptions internal to a generator are handled. Before they were silently swallowed and now they are converted to runtime exceptions. This causes issues with blocking tee code in OpenNIR. BlockingTeeControllerThread's run method catches the StopIteration and and stores it. _blocking_tee_iter() access that exception and re-raises it. This worked in earlier Python versions, but the preferred manner to handle this is to catch internal StopIterations and terminate the generator.
I added a test for exception type so that a file not found exception or similar would still bubble up the stack.
I'll also mention that this code isn't doing what is expected:
        if value is not StopIteration:
            yield value

The function next() raises a StopIteration exception so ctrl.value is not updated. (The older style iter.next() would return a StopIteration I believe). If there was a reason to test for StopIteration, it should be done with isinstance. It is not hurting anything because the is not test is always true, but should probably be changed to simple yield the value without the test. I can do that on this PR if desired.

Thanks! Looks good to me. I believe this is a fix for the issue brought up in #31.
I suspect the implementation was originally trying to use StopIteration as a sentinel value there, much like it does here: https://github.com/Georgetown-IR-Lab/OpenNIR/blob/onir/interfaces/trec.py#L269. But you're right that it's not doing anything here, so it can be removed.


WIP PR: Correct auto-indent behaving in unexpected ways

Description of Changes

[x] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[x] Change Tests for unmatched opening brackets without keyword
[x] Add Tests for more keywords
[x] Add Tests for brackets, # and keywords in single quote strings
[x] Add Tests for brackets, # and keywords in triple quote strings

[x] Over multiple lines

[x] Add Tests for all behaviours described in #5606
[ ] Add Tests for all behaviours described in #887
[x] Add Tests for all behaviours described in #7377

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Correct unexpected behaviour of the auto-indent feature of the editor widget.
Largely rewrite plugins/editor/widgets/codeeditor.py CodeEditor.fix_indent_smart
to be more readable, make it respect strings and comments better when matching brackets,
have it only indent by two levels when required by keywords, and possibly more.
Issue(s) Resolved

Fixes #5606
Issue #887 Is both a feature request and a bug report. The feature request is out of scope for this PR.
Fixes #7377
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: definite-purple

Heya, so first-time contributor here. I'll need another one or two days to get this done but had questions and didn't know where else to ask them:
The file test_autoindent.py contains the tests relevant to my PR.
When I notice something amiss with already implemented tests (e.g. a test named curly brackets testing parens like the two above), can I just fix that in a commit for this PR, or should I not touch them?
I haven't really figured out how squashing commits works, and it's not that high of a priority for me personally. Since the relevant section in the Dev-wiki is still unwritten, should I just not bother for this?
That's all for now, looking forward to hearing back from you!

Heya, so first-time contributor here.

Hey, really glad to know that you want to contribute to Spyder!

I'll need another one or two days to get this done but had questions and didn't know where else to ask them

Sure, this is the best place to ask questions.

When I notice something amiss with already implemented tests (e.g. a test named curly brackets testing parens like the two above), can I just fix that in a commit for this PR, or should I not touch them?

If the changes you're making also alter the results of some of our tests, then you need to fix them. But if you think our tests could be improved to better catch what they are supposed to do, then I think it's better to leave that for another PR.

I hit a minor(?) roadblock when trying to infer the appropriate indent from lines inside a triple-quoted string literal or line-continued string literal.
There isn't by chance something like a context explorer already implemented in spyder?
Something that tells me whether the literal was opened with ' " ''' """?
(Or some form of lexical analysis tool, that works inside a limited scope?)
I can manage without, but it won't be as elegant as it could be.

Something that tells me whether the literal was opened with ' " ''' """?

You can take a look at the method called in_comment_or_string in spyder/plugins/editor/widgets/codeeditor.py

Hello @definite-purple! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/editor/widgets/codeeditor.py:

Line 2349:1: W293 blank line contains whitespace
Line 2356:1: W293 blank line contains whitespace
Line 2397:25: E117 over-indented
Line 2399:49: E231 missing whitespace after ':'
Line 2399:58: E231 missing whitespace after ':'
Line 2399:67: E231 missing whitespace after ':'
Line 2421:80: E501 line too long (83 > 79 characters)
Line 2478:45: E231 missing whitespace after ':'
Line 2478:54: E231 missing whitespace after ':'
Line 2478:63: E231 missing whitespace after ':'

I found sourcecode.get_identifiers

You can take a look at the method called in_comment_or_string in spyder/plugins/editor/widgets/codeeditor.py

Thanks. I can't really use this for what I was trying to do. I was looking for something more like #3493

Okay…
My latest commit affected pre-existing tests. Could somebody please look over them to check that the new behaviour is indeed the correct one?
Summary of changes in the tests:

Old
New

Ending a line with an opening bracket always indents the next line two levels
Only indents one level, except if prevline started with one of the block opening keywords that accept arguments

When in tabstop mode, always try to vertically align with the opening bracket, but no more than two tabs
… I just added an item after the opening bracket and commented out the first two tests, because I don't think that was ever intended behaviour?

Could you some examples of the before/after behaviors? I think that would make things easier to understand for us.

Through all the changed behaviour, only the tests ending with any opening bracket and not starting with a keyword have been affected.
Each of the examples shows the new cursor position after the function got called as |
long_list_name = (
        |

Changed to:
long_list_name = (
    |

In addition the tests about vertical align when using tabstops with print( were changed to print(""

def function(
        |

Stayed the same as before.

long_list_name = (a,
                  |

Stayed the same as before

Ok, thanks! I agree with all your changes.

@definite-purple, do you need help to finish this PR?

@dalthviz, please help @definite-purple to finish this PR. I think it's very important that we include this work in our next beta.

@definite-purple, do you need help to finish this PR?

Hey, yes. I need help with this PR. Somehow this project fell off my radar, and my free time is limited for the next handful of weeks.

@dalthviz, please help @definite-purple to finish this PR. I think it's very important that we include this work in our next beta.

That would be much appreciated. I have some changes that are still local-only, which I'll commit and push later today.
As far as I remember, most of the implementation is done. What was left was writing tests and figuring out if the sloppy way I handled triple-quoted string literals causes issues.

Thanks a lot @dalthviz for helping @definite-purple to finish this one!! Do you think it's ready? Or are there other things still to be addressed?

No problem @ccordoba12 :+1:, about the state of the PR, I think I'm missing the addition of a test with the cases at #887 although I'm unsure of what is the expected behavior and how the test should be

I'm unsure of what is the expected behavior and how the test should be

I think the only thing worth covering in test is what's mentioned here https://github.com/spyder-ide/spyder/issues/887#issuecomment-232154538


feat: Add links to all Drupal modules on drupal.org

I've added links to all Drupal.org modules so navigation is a little easier.
To do this i added a Live template in phpstorm to create a link easily.
[$SELECTION$](https://drupal.org/project/$SELECTION$)

Looks good. Thanks.


adding --role flag to key import

closes #881
Signed-off-by: Avi Vaid<EMAIL_ADDRESS>

Can one of the admins verify this patch?

This is still WIP
Discussion:

should we have a --gun flag for compatibility with the flat key store? as of now you can specify the path if you want a key associated with a gun but this won't be possible in a flat keystore. followup: should we even have a path if we have a flat keystore
if there is a role flag should we limit to importing only one key or add that to all specified keys?

Thanks for the quick fixing!

Do you get this error when import keys:
failed to import key to store: PEM headers did not contain import path

@avaid96 I think taking a GUN makes sense, and a GUN header makes sense more than a path header in the flattened keystore.  I think #825 included both headers - can import guess the path based on the GUN for now until flatten keystore is merged?

@HuKeping Yep, that's what we are trying to fix.  :)

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

jenkins, ok to test.

Also, this totally fixes https://github.com/docker/notary/pull/720 :)  And those tests all pass with this PR.

LGTM when CI goes green!

LGTM pending CI.  Thank you for all of your hard work on this feature!

Of course, thanks for the detailed review on this PR! 😄

Thank you for all your work on this @avaid96!  :D


Add a new gauge for SqrtCZ and support SqrtCZ† and fix and improve spin inversion gauge

@pavoljuhas when I use ops.CZ I get
cirq-core/cirq/transformers/gauge_compiling/sqrt_cz_gauge.py:28: error: Cannot determine type of "CZ"  [has-type]

@pavoljuhas when I use ops.CZ I get
cirq-core/cirq/transformers/gauge_compiling/sqrt_cz_gauge.py:28: error: Cannot determine type of "CZ"  [has-type]

This seems to happen because check/mypy cirq-core follows the import cirq loading order and that line is reached before the cirq.ops package is fully loaded.  If gauge_compiling is not imported from transformers.__init__ the typecheck seems to pass.
Do we need to import gauge_compiling by default at import cirq or can it be an optional thing requiring import cirq.transformer.gauge_compiling to access?
If optional, we may save ourselves some headaches with circular imports or strange typechecking errors down the line.


x/text/cases: Upper drops the 129th character

Here is a simple program that should uppercase some text:
package main

import (
	"golang.org/x/text/cases"
	"golang.org/x/text/language"
)

func main() {
	const a = "abcdefghijklmnopqrstuvwx\n"
	text := a + a + a + a + a + a
	print(cases.Upper(language.Make("en")).String(text))
}

I would expect to get:
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX

but instead I get:
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCEFGHIJKLMNOPQRSTUVWX

The last "D" is dropped, which is the 129th character.

Greek works fine.
print(cases.Upper(language.Make("el")).String(text))

ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX
ABCDEFGHIJKLMNOPQRSTUVWX

The problem starts in transform/transform.go (line 571):
		nDst, nSrc, err = t.Transform(dst[pDst:], src[:n], pSrc+n == len(s))

At this point, dst[pDst:] will be a zero-length slice. This calls cases/map.go (lines 135-144):
func (t *undUpperCaser) Transform(dst, src []byte, atEOF bool) (nDst, nSrc int, err error) {
	c := context{dst: dst, src: src, atEOF: atEOF}
	for c.next() {
		upper(&c)
	}
	// Standard upper case does not need any lookahead so we can safely not use
	// the checkpointing mechanism. pDst and pSrc will always point to the
	// furthest possible position.
	return c.pDst, c.pSrc, c.err
}

But unfortunately c.next() will, after two loops, increment c.pSrc. See cases/context.go (lines 73-93):
func (c *context) next() bool {
	c.pSrc += c.sz
	if c.pSrc == len(c.src) || c.err != nil {
		c.info, c.sz = 0, 0
		return false
	}
	v, sz := trie.lookup(c.src[c.pSrc:])
	c.info, c.sz = info(v), sz
	if c.sz == 0 {
		if c.atEOF {
			// A zero size means we have an incomplete rune. If we are atEOF,
			// this means it is an illegal rune, which we will consume one
			// byte at a time.
			c.sz = 1
		} else {
			c.err = transform.ErrShortSrc
			return false
		}
	}
	return true
}

Back in transform/transform.go, this means dst will grow and then start reading from pSrc+1. This is wrong and leads to the letter being skipped.
--
I see two solutions. First, if passing an empty dst is supposed to result in undefined behavior, then a simple fix is to avoid it by changing transform/transform.go (line 554) to:
	if pDst+nDst < initialBufSize {

--
If instead an empty dst should be checked for in a robust way, then context.next() should be fixed like so:
func (c *context) next() bool {
	if len(c.dst) == 0 {
		c.err = transform.ErrShortDst
		return false
	}
	c.pSrc += c.sz
	if c.pSrc == len(c.src) || c.err != nil {
		c.info, c.sz = 0, 0
		return false
	}
	v, sz := trie.lookup(c.src[c.pSrc:])
	c.info, c.sz = info(v), sz
	if c.sz == 0 {
		if c.atEOF {
			// A zero size means we have an incomplete rune. If we are atEOF,
			// this means it is an illegal rune, which we will consume one
			// byte at a time.
			c.sz = 1
		} else {
			c.err = transform.ErrShortSrc
			return false
		}
	}
	return true
}

Resolved, see https://go-review.googlesource.com/#/c/13076/.


Make erlexec an optional dependency

While the option to use the node compiler via erlexec is very nice, it could be an optional dependency for those who want it.

Pull Request Test Coverage Report for Build fcc0a6d29f0b94b2dd1ddd18f4474e37e0283b46-PR-9

4 of 22 (18.18%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-15.4%) to 81.197%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/compilers/node.ex
4
22
18.18%

Totals

Change from base Build 5d3156fd56aa87ee8c00e6230ba037195b9825b5:
-15.4%

Covered Lines:
95

Relevant Lines:
117

💛  - Coveralls

Sorry about the delay! I merged in PR #10 with your work along with the fix for the tests and an error message to let people know how to use the node compiler instead. Thanks for the contribution!


feat: support both AnimatedSprite2D and AnimatedSprite3D

Hi poohcom1, thank you for this brilliant addon.
Meanwhile I'm working on a HD2D-ish project, finding this addon can only work with AnimatedSprite2D. I suppose it could support 3D as well so I modified some lines to have it recognize both AnimatedSprite2D and AnimatedSprite3D nodes. Turned out it works for my project. So here's my PR.
Please forgive my formatter eliminating all the tabs on the blank lines. Please let me know how you think.
Thanks
mogita

Looks good to me!
Thankss :D


Error: unpack requires a string argument of length 32

Hi, I've been using this and generally it supports most of the foxpro .dbf file, but there is one file that can't be read for some reason, it says "unpack requires a string argument of length 32". What might causes this?
Here is the file: https://drive.google.com/file/d/0BweenIzZNEAtSWdoM1M1d3Z5YjQ/view?usp=sharing

I found out that if the record is too few this error will occur.

Sorry my bad, there is no problem with your code.


Environment variable -x not defined in windows builds

In windows packages, I get the following output.
 Successfully updated the environment
Collecting tests from "C:\\Users\\runneradmin\\AppData\\Local\\rattler/cache\\pkgs\\my-package-0.2.5-py39h30aeb06_0"
Testing commands:
test run_test.bat
test run_test.py
Environment variable -x not defined
No broken requirements found.
Testing Python imports:
import my_package
Environment variable -x not defined
 all tests passed!

You are probably running set -x somewhere which is not wanted in windows

yes. Let me fix that.


Error during deployment

Hi,
System :
Ubuntu 20.04
Docker version 20.10.21, build baeda1f
Docker Compose version v2.12.2
I have a problem when i want to deploy this project with this following message :
 => CANCELED [deployments-plc2 internal] load build context                                                                                1.1s
 => => transferring context:                                                                                3.2s
 => CANCELED [deployments-hmi3 internal] load build context                                                                                3.3s
 => => transferring context:                                                                                0.8s
 => [deployments-pys internal] load build context                                                                                3.3s
 => CACHED [deployments-hmi2 2/7] RUN mkdir src                                                                                0.0s
 => ERROR [deployments-hmi2 3/7] COPY ./src/ ./src/                                                                                0.0s
 => CANCELED [deployments-plc1 internal] load build context                                                                                1.3s
 => => transferring context:                                                                                2.2s
------
 > [deployments-hmi2 3/7] COPY ./src/ ./src/:
------
failed to solve: failed to compute cache key: "/src" not found: not found

Because of some bugs, you must manually create the folder with the name "src" in the deploy directory and then try to deploy it.
Let me know if it works, so I can fix it.

No it doesn't works, same issue

Actually, you had to create "src" folder in the docker definition files, like "ics-docker".
I updated init.sh file to do it.
Please pull the project and run it again.

I know that this bug existed a while ago. But we resolved it.
And our update works since your error changed after the update.
A fresh clone might work.
Please clean your environment and deploy it again.

I have exactly same issue and I have fresh pull of repo.
I had to add "apt-get install -y apt-utils" als to ics-docer/Dockerfile also

@toglader and @Jderach : It seems that the problem was the ownership of files.
Obviously, the docker-composer cannot create "./src" file in docker folders.
I updated the "init.sh" to perform actions with "Sudo".
So please pull and try again.

For me issue was fixed by adding apt-utils to installable packages but also adding "-y"  to Dockerfiles in "apt install telnet" lines


update Data Sources does not support subtype group layers

Describe the bug
I noticed that when using subtype group layers in arcPro, the update data sources failed to change sources for sub layers. It breaks the data source, and you have to manually select the new source for at least one layer, then the others apply too.
Expected behavior
subtype groups and all layers should point to the new workspace
Desktop (please complete the following information):

ArcGIS Pro 3.1

I have seen that you need to restart pro for the changes to take effect in some maps.  I have not been able to determine why yet.  Can you test restarting pro after running the tool and see if map is correct.

Hi Mike,
restarting ArcPro does not work for me.
note that sometimes it is the group layer that looses data source, and sometimes it is the layers

Can you send me a mapx with the broken layers so I can see what is not being switched.  I cannot repo the issue.

Unfortunately, Pro does not allow exporting mapx with broken sources, even without the "include data and UNC path" option

I just sent you a mail with a link to check with my aprx and data

You can export a map to a mapx like this:

I will take a look at the data you sent

The map is being properly repathed for me.  What version of the tool/pro are you using?  If you have a broken map, export it to mapx.  I am interested in seeing the mapx json to see what may be incorrect in there.

ArcGIS Pro is v3.1.3
UDMS is v3.1.1
I just sent you the mapx

non repo - closing due to inactivity


fix lint issues

Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

Run operator BDD testing
Please add comment: /jenkins test

Run RHPAM operator BDD testing
Please add comment: /jenkins RHPAM test

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

/Jenkins test

/Jenkins test

PR job #789 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/789//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/789/display/redirect
See console log:

Console Logs
                         FAIL	github.com/kiegroup/kogito-operator/test	701.494sFAILTests finished with code 1-------- Pruning namespacesI0323 19:22:08.210577   55521 request.go:665] Waited for 1.045634774s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/snapshot.storage.k8s.io/v1?timeout=32s{"level":"info","T":"2023-03-23T19:22:10.033Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-23T19:22:10.059Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-23T19:22:10.059Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/789/consoleText+ tail -n 100

PR job #790 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/790//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/790/display/redirect
See console log:

Console Logs
                                         FAIL	github.com/kiegroup/kogito-operator/test	4702.558sFAILTests finished with code 1-------- Pruning namespacesI0323 20:55:26.277073   57193 request.go:665] Waited for 1.031744014s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/template.openshift.io/v1?timeout=32s{"level":"info","T":"2023-03-23T20:55:27.868Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-23T20:55:27.906Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-23T20:55:27.906Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesStuck project j-bdd-6b02No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.No resources found in j-bdd-6b02 namespace.Projects deleted:j-bdd-6b02-------- Clean Cluster operators--- Clean installplans in openshift-operatorsDelete installplans.operators.coreos.com install-9bmnw in namespace openshift-operatorsinstallplan.operators.coreos.com "install-9bmnw" deletedDelete installplans.operators.coreos.com install-x29dv in namespace openshift-operatorsinstallplan.operators.coreos.com "install-x29dv" deleted--- Clean subscriptions in openshift-operatorsDelete subscriptions.operators.coreos.com kogito-operator in namespace openshift-operatorssubscription.operators.coreos.com "kogito-operator" deleted--- Clean clusterserviceversions in openshift-operatorsDelete clusterserviceversions.operators.coreos.com kogito-operator.v1.35.0 in namespace openshift-operatorsclusterserviceversion.operators.coreos.com "kogito-operator.v1.35.0" deleted--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh

/jenkins test

PR job #791 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/791//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/791/display/redirect
See console log:

Console Logs
                           FAIL	github.com/kiegroup/kogito-operator/test	2962.002sFAILTests finished with code 1-------- Pruning namespacesI0323 23:01:39.696473   55579 request.go:665] Waited for 1.001738449s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/operator.openshift.io/v1?timeout=32s{"level":"info","T":"2023-03-23T23:01:41.556Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-23T23:01:41.577Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-23T23:01:41.578Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh

/jenkins test

PR job #792 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/792//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/792/display/redirect
See console log:

Console Logs
                           FAIL	github.com/kiegroup/kogito-operator/test	2687.059sFAILTests finished with code 1-------- Pruning namespacesI0324 01:47:22.841471   55470 request.go:665] Waited for 1.025921154s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/operators.coreos.com/v2?timeout=32s{"level":"info","T":"2023-03-24T01:47:24.697Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-24T01:47:24.709Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-24T01:47:24.709Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh

/jenkins test

/jenkins test

PR job #794 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/794//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/794/display/redirect
See console log:

Console Logs
                                   FAIL	github.com/kiegroup/kogito-operator/test	2486.566sFAILTests finished with code 1-------- Pruning namespacesI0328 19:31:39.979450   56832 request.go:665] Waited for 1.011214904s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/whereabouts.cni.cncf.io/v1alpha1?timeout=32s{"level":"info","T":"2023-03-28T19:31:41.755Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-28T19:31:41.772Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-28T19:31:41.772Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/794/consoleText+ tail -n 100

/jenkins test

PR job #795 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/795//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/795/display/redirect
See console log:

Console Logs
                         FAIL	github.com/kiegroup/kogito-operator/test	2753.162sFAILTests finished with code 1-------- Pruning namespacesI0329 09:31:07.245384   55774 request.go:665] Waited for 1.021183309s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/helm.openshift.io/v1beta1?timeout=32s{"level":"info","T":"2023-03-29T09:31:09.061Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-29T09:31:09.091Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-29T09:31:09.092Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ tail -n 100+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/795/consoleText

/jenkins test

maybe it is related:
bundle community-operators/openshift-marketplace/2.3.x/infinispan-operator.v2.1.5 is deprecated"}

/jenkins test

PR job #797 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/797//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/797/display/redirect
See console log:

Console Logs
                                   FAIL	github.com/kiegroup/kogito-operator/test	2405.755sFAILTests finished with code 1-------- Pruning namespacesI0330 10:12:55.169144   55827 request.go:665] Waited for 1.000930126s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/node.k8s.io/v1beta1?timeout=32s{"level":"info","T":"2023-03-30T10:12:56.933Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2023-03-30T10:12:56.948Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2023-03-30T10:12:56.948Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean installplans in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean installplans in operatorsNo resources found in operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafanafolders.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanafolders.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:345: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/797/consoleText+ tail -n 100

test failures are not related


File extensions not working

Does not work as expected:

setting Options->General->File extensions -> log -> Save
opening a file.log with plugin active == message:
Your configuration settings do not include the currently selected file extension.
The rendered file extensions are 'log'.
The current file is 'file.log'. False
clicking View-Refresh works

Looks like we submitted the same issue at the exact same time ;) See #13 which has been closed now.

Damn it. Too distracted ^^° Will build a new version soon.
Thanks

Big sorry about the delay.
A new version is up, 0.5.1 (https://github.com/nea/MarkdownViewerPlusPlus/releases).
This time I tested all option I could think of. Don't know what happened last time. Left in debug outputs and didn't correctly validate the check. Sorry about that.
Hope this is good now, otherwise let me know :)
Cheers


[Docs] DatePicker - Add disabled dates example

Fixes #3054.

Thanks! Looks good.
Do you think it would make sense to  have another example that shows random dates disabled?

Sure, good idea, I'll do that. The weekends-only one makes it look like there are limitations on what can be disabled.

Not really sure what I did to cause an unrelated test to fail... unfortunately I can't run the tests locally because I'm on Windows and running into this issue.

Thanks for updatingthe PR. Looks like CI timed out. It's passing here, so may just be transient. You could try setting a minDate and maxDate (Not sure how efficiently shouldDisableDate is implemented...)

what I did to cause an unrelated test to fail

We have a flaky test on the Dialog that fails from time to time. Rerunning the task should fix it.

LGTM! Can you squash an we can merge. :+1:

All set, thanks!

Thanks for the PR!


Distribution list and account forwards are messed up

There is a bug in relation to distribution lists which are indirectly created via a user profile's forward section:

A user creates forwards and follows the comma-separated email address list convention.
The result are mangled arrays which make postfix break in several ways:
debug.txt

root@email:~# tail -n 500 /var/log/mail.log | grep u\'
May 13 14:41:27 email postfix/error[25546]: 4DBA2E0704<EMAIL_ADDRESS><EMAIL_ADDRESS>relay=none, delay=0.03, delays=0.01/0.01/0/0.01, dsn=5.1.3, status=undeliverable (bad address syntax)
May 13 14:41:27 email postfix/lmtp[25547]: 4DBA2E0704<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']@FQDN>, <EMAIL_ADDRESS>relay=FQDN[private/dovecot-lmtp], delay=0.04, delays=0.01/0.01/0/0.01, dsn=5.1.1, status=undeliverable (host FQDN[private/dovecot-lmtp] said: 550 5.1.1<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']"@FQDN> User doesn't exist<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']"@FQDN (in reply to RCPT TO command))
May 13 14:41:27 email postfix/lmtp[25547]: 4DBA2E0704: to=<u'@FQDN>, <EMAIL_ADDRESS>relay=FQDN[private/dovecot-lmtp], delay=0.05, delays=0.01/0.01/0/0.02, dsn=5.1.1, status=undeliverable (host FQDN[private/dovecot-lmtp] said: 550 5.1.1 <u'@FQDN> User doesn't exist: u'@FQDN (in reply to RCPT TO command))
May 13 14:41:35 email postfix/error[25546]: 87240E0708<EMAIL_ADDRESS><EMAIL_ADDRESS>relay=none, delay=0.03, delays=0.02/0.01/0/0.01, dsn=5.1.3, status=bounced (bad address syntax)
May 13 14:41:36 email postfix/lmtp[25547]: 87240E0708<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']@FQDN>, <EMAIL_ADDRESS>relay=FQDN[private/dovecot-lmtp], delay=1, delays=0.02/0.01/0/0.98, dsn=5.1.1, status=bounced (host FQDN[private/dovecot-lmtp] said: 550 5.1.1<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']"@FQDN> User doesn't exist<EMAIL_ADDRESS>u'<EMAIL_ADDRESS>u' redacted@email.address']"@FQDN (in reply to RCPT TO command))
May 13 14:41:36 email postfix/lmtp[25547]: 87240E0708: to=<u'@FQDN>, <EMAIL_ADDRESS>relay=FQDN[private/dovecot-lmtp], delay=1, delays=0.02/0.01/0/0.99, dsn=5.1.1, status=bounced (host FQDN[private/dovecot-lmtp] said: 550 5.1.1 <u'@FQDN> User doesn't exist: u'@FQDN (in reply to RCPT TO command))

These also show weird in both interfaces after saving, which is documented below:

Domain admins cannot see the implied distribution lists, but Super admins can.

Thanks for the report but I think this bug already existed before transition to 1.9

I have changed the description of the issue above.

Thanks for closing this. Will try it out and give feedback as quickly as possible.


[CI] Fix pipeline by using v13249166-eafe611 for DATADOG_AGENT_BUILDIMAGES

What does this PR do?
The former DATADOG_AGENT_BUILDIMAGES tag v11651098-faf0544 was not available for every image hence making the CI crash. This PR is using v13249166-eafe611 image instead that was built just now in datadog-agent-buildimages from a clone of faf0544 which was the commit the former image was from.

Motivation
CI tests were failing.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

windows-unit-tests fail but #15556 is fixing it !


Add syntax highlighting to README

I will just fix the minor mistake I found myself :)

Thank you ;)


Add a --query-driver flag to clangd-indexer

Hi there! I'm trying to build a static index for a codebase that I'm cross-compiling.
I believe that in order to use clangd in this situation, you need to provide a path to the compiler with the --query-driver flag so that clangd can find the appropriate headers. However, there's no such flag for clangd-indexer. So when I try to build the index, I'm seeing a lot of include errors as it's not finding the correct headers.
Is there a way to get this to work that I've missed? And if not, would you accept a patch to add a flag like this to clangd-indexer?

Is there a way to get this to work that I've missed?

The alternative to --query-driver is to specify your cross-compiler's system include paths manually.
You can run <cross-compiler> -E -v -xc++ - (this is what clangd does when --query-driver is specified), look at the list of system include paths printed after #include <...> search starts here, and add a corresponding -isystem <path> to your source files' compile commands for each one.
Unfortunately, the simplest way to add those -isystem <path> flags would be using a clangd config file, but unfortunately that's not hooked up for clangd-indexer either...
So that leaves you with arranging for your compile_commands.json to contain those -isystem flags, which may or may not be straightforward depending on how you're generating your compile_commands.json.

And if not, would you accept a patch to add a flag like this to clangd-indexer?

I don't call the shots so I can't guarantee that a patch would be accepted, but I think that would be a nice addition and fill a logical gap. I'm happy to provide guidance if you'd like to write a patch.

Is there a way to get this to work that I've missed?

The alternative to --query-driver is to specify your cross-compiler's system include paths manually.
You can run <cross-compiler> -E -v -xc++ - (this is what clangd does when --query-driver is specified; replace -xc++ with -xc if you're working on C code), look at the list of system include paths printed after #include <...> search starts here, and add a corresponding -isystem <path> to your source files' compile commands for each one.
Unfortunately, the simplest way to add those -isystem <path> flags would be using a clangd config file, but unfortunately that's not hooked up for clangd-indexer either...
So that leaves you with arranging for your compile_commands.json to contain those -isystem flags, which may or may not be straightforward depending on how you're generating your compile_commands.json.

And if not, would you accept a patch to add a flag like this to clangd-indexer?

I don't call the shots so I can't guarantee that a patch would be accepted, but I think that would be a nice addition and fill a logical gap. I'm happy to provide guidance if you'd like to write a patch.


Ci/new testnet

Description and Motivation

This PR adds the new narwhal-2 testnet data. Also improves the load_env_variables alias so that it prints what chain you just loaded.
Related Issues

Checklist:

[x] I have read Migaloo's contribution guidelines.
[x] My pull request has a sound title and description (not something vague like Update index.md)
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation.
[x] The code is formatted properly cargo fmt --all --.
[x] Clippy doesn't report any issues cargo clippy -- -D warnings.
[x] I have regenerated the schemas if needed cargo schema.

Code changes LGTM, I haven't verified the contract address though.

yeah factory/migaloo1dpx7ytug647wefe7ajxmg5ejt68gxcfvw35f4e/test is just an example, this is meant to be tweaked as needed.


feat: 3897 - mutilingual gallery and swipeable images - read only

What

Introduced the language selector in the product image gallery and the swipeable images.
This is READ-ONLY for the moment - that is, you cannot add a "translated" image in a new language.
The reason behind is that there is confusion and I need functional help:

When the app is in a specific language and the user sees the product images, for the moment the user sees the "best possible" images (either the image in the language or the fallback image for that image field)
But if the user selects "an unknown language", should the user see an empty image, or the best image?
In short, the question is "when do we show the 'no image yet' for an image field, in the specific case of multilingual images"

Screenshots
App in French.
Gallery:

in French
language selector
in Spanish

Swipeable images:

in French
language selector
in Spanish

Part of

#3897

Files
New file

image_field_extension.dart: moved code from product_cards_helper.dart

Deleted files

product_image_unswipeable_view.dart
smooth_images_sliver_list.dart
smooth_images_view.dart

Impacted files

image_upload_card.dart: minor refactoring
language_selector.dart: added an optional foreground color (use case: explicit white for images on a black background)
new_crop_page.dart: minor refactoring
nutrition_page_loaded.dart: now using a new special case constructor of ProductImageSwipeableViewinstead of now deletedProductImageUnswipeableView`
product_cards_helper.dart: added language-related methods; refactored
product_image_carousel.dart: minor refactoring
product_image_data.dart: added language
product_image_gallery_view.dart: simplified the display of the 4 images; added the language selector on top; refactored the title
product_image_swipeable_view.dart: now handles the "mono imagefield" case; now manages languages; minor refactoring
product_image_viewer.dart: added the language selector; removed the irrelevant Scaffold

Codecov Report

Merging #3917 (f2a63b2) into develop (e5bf1cb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3917      +/-   ##
===========================================
- Coverage    10.64%   10.63%   -0.01%
===========================================
  Files          271      268       -3
  Lines        13478    13489      +11
===========================================
  Hits          1435     1435
- Misses       12043    12054      +11

Impacted Files
Coverage Δ

...th_app/lib/cards/data_cards/image_upload_card.dart
0.00% <0.00%> (ø)

...ib/cards/product_cards/product_image_carousel.dart
0.00% <ø> (ø)

...smooth_app/lib/data_models/product_image_data.dart
0.00% <ø> (ø)

...app/lib/generic_lib/widgets/language_selector.dart
0.00% <0.00%> (ø)

.../smooth_app/lib/helpers/image_field_extension.dart
0.00% <0.00%> (ø)

...s/smooth_app/lib/helpers/product_cards_helper.dart
0.00% <0.00%> (ø)

...h_app/lib/pages/product/nutrition_page_loaded.dart
0.00% <0.00%> (ø)

.../lib/pages/product/product_image_gallery_view.dart
0.00% <0.00%> (ø)

...ib/pages/product/product_image_swipeable_view.dart
0.00% <0.00%> (ø)

...th_app/lib/pages/product/product_image_viewer.dart
0.00% <0.00%> (ø)

... and 1 more

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you @teolemon for your review!
I got rid of the Sliver effect because in this particular case we're only talking about 4 list tiles with an additional language selector (the page used to include more pictures, maybe that made sense back then to use a Sliver).
I needed to simplify the page in order to add the language selector, and to make it consistent with the rest of the app (cf. the gallery title).
That said, I'm still stuck with the functional issue I mentioned in the OP. I'll be a little more verbose in issue #3897.


ol 7.6 network trouble

Reproduce steps:
Deploy admin offer from preview link, choose image WebLogic Server <IP_ADDRESS>.0 and JDK 11_07 on Oracle Linux 7.6.  It's ready in resource group "oraclevm-admin-76" in "Oracle Enterprise Java" for quick check.
Access WebLogic console portal from browser with public ip or dns, e.g. http://wls-d315056581-admindomain.eastus.cloudapp.azure.com:7001/console
Expected result: open WebLogic login page. Actual result: console portal is not accessible.
ssh to adminVM machine and curl http://localhost:7001/console, it works.
WebLogic Server is not available from public access.
Reproduced images:
WebLogic Server <IP_ADDRESS>.0 and JDK 11_07 on Oracle Linux 7.6
WebLogic Server <IP_ADDRESS>.0 and JDK 8u251 on Oracle Linux 7.6
WebLogic Server <IP_ADDRESS>.0 and JDK 8u251 on Oracle Linux 7.6
The issue CANNOT reproduce on images:
WebLogic Server <IP_ADDRESS>.0 and JDK8u131 on Oracle Linux 7.4
WebLogic Server <IP_ADDRESS>.0 and JDK8u131 on Oracle Linux 7.3
Root cause:
Check with firewall-cmd, no port is open, see screenshot.
Image
Check with netstat
Image
Workaround:
Open port 7001 and 7002 from firewall, can solve the issue, with following commands:
firewall-cmd --zone=public --add-port=7001/tcp --permanent;
firewall-cmd --zone=public --add-port=7002/tcp --permanent;
firewall-cmd --reload;
More:
I deploy machine with image WebLogic Server <IP_ADDRESS>.0 and JDK 11_07 on Oracle Linux 7.6, ssh to the machine, I found firewall-cmd was not available.
Then run setupAdminDomain.sh in that machine, firewall-cmd has been installed.
Now WebLogic deploy tool version is 1.8.1, I checked source code, didn't found anything related to firewall.

@sanjaymantoor @edburns
I fixed the issue for admin offer @pullrequest, according Sanjay's changes on arm-oraclelinux-7.6-wls-cluster,  pls review.

Resolved in admin and configured cluster offers.  Fix in dynamic cluster still forthcoming from @galiacheng .


Dev: Documentation for token usage

Document how devs can use our tokens in their code.
Make sure to cover these things:

[ ] How to install
[ ] How to use
[ ] Downloaded package structure

@daine @adorayi I think we can close this ticket. We recently added documentation for token usage to the token readme.

Talked to Daine - she agreed it can be closed so closing this issue.


feature(web): create script to split large files

Describe your changes

Issue ticket number and link
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

Hey @Si3rr4wow I don't think this is the place for it...
Unless I missed something, it's a local utility that may be useful to refactor code, but why in the npm scripts? I would have put it in a private repo / gists to make available to everyone, when needed?

@fabfab-kc I don't think, in its current state, this splitter has much value outside of this repo. As I mentioned in my comment on the Cursor this bakes in rules that are sympathetic to the way code is written for BO ie ES6 import syntax and jsdoc types. As it is this wouldn't even work on front office code. I can make it more configurable (as I said, I'd like to do that) but then this repo will still end up owning the config


Client does not build with @streaming blob

I don't understand why the following Smithy model:
$version: "1.0"

namespace com.amazonaws.simple

use aws.protocols#restJson1

@restJson1
@title("SimpleService")
service SimpleService {
    version: "2022-01-01",
    operations: [
        StreamingOperation,
    ],
}

@http(uri: "/streaming", method: "GET")
operation StreamingOperation {
    input: StreamingOperationInput,
    output: StreamingOperationOutput,
}

@input
structure StreamingOperationInput {}

@output
structure StreamingOperationOutput {
    output: StreamingBlob,
}

@streaming
blob StreamingBlob

fails to build.
error[E0308]: try expression alternatives have incompatible types
  --> simple/rust-codegen/src/json_deser.rs:19:29
   |
19 | / ...                   aws_smithy_json::deserialize::token::expect_blob_or_null(
20 | | ...                       tokens.next(),
21 | | ...                   )?,
   | |________________________^ expected struct `aws_smithy_http::byte_stream::ByteStream`, found struct `aws_smithy_types::Blob`
   |
   = note: expected enum `std::option::Option<aws_smithy_http::byte_stream::ByteStream>`
              found enum `std::option::Option<aws_smithy_types::Blob>`

However, if I add @httpPayload above the line output: StreamingBlob, then it builds fine.
I don't see anything in the Smithy spec that says streaming blobs must also be bound with @httpPayload. I would have assumed that adding @httpPayload would be superfluous; I had always thought that blob @streaming would imply that the data is automatically streamed over the HTTP body. However, I can't reconcile that idea with the example that is featured in the Smithy docs:
operation StreamingOperation {
    input: StreamingOperationInput,
    output: StreamingOperationOutput,
}

@input
structure StreamingOperationInput {}

@output
structure StreamingOperationOutput {
    @required
    streamId: String
    output: StreamingBlob,
}

@streaming
blob StreamingBlob

Here, it would seem like @streaming should be strictly interpreted as simply "the data could be very large and thus should not be stored in memory or that the size is unknown at the start of the request" as per the spec, without ascribing any special semantics as to how the data is sent over HTTP, since the body also contains a streamId string.
This last example from the Smithy docs also fails to compile in smithy-rs, but is accepted by Smithy CLI.

Turns out the model should be rejected by Smithy and the Smithy spec should be updated.
The rule that needs to be enforced is "if protocol supports httpPayload, then streaming MUST be paired with httpPayload".
https://github.com/awslabs/smithy/issues/1075

It looks like the linked Smithy issue was resolved a while ago, so I think this validation was added.


Vehicle not found + ScriptableObject.CreateInstance

I get a lot of these error massages. Don't know if they are related, but it seems that one or both causes the game to freeze after a while.

ItemClass must be instantiated using the ScriptableObject.CreateInstance method instead of new ItemClass.
(Filename:  Line: 598)

Vehicle not found!
at System.Environment.get_StackTrace()
at Building.RemoveGuestVehicle(UInt16 vehicleID, Vehicle ByRef data)
at FuelAlarm.CustomCargoTruckAI.RemoveTarget(UInt16 vehicleID, Vehicle ByRef data)
at FuelAlarm.CustomCargoTruckAI.SetTarget(UInt16 vehicleID, Vehicle ByRef data, UInt16 targetBuilding)
at RealCity.RealCityCargoTruckAI.ArriveAtTarget(UInt16 vehicleID, Vehicle ByRef data)
at CargoTruckAI.ArriveAtDestination(UInt16 vehicleID, Vehicle ByRef vehicleData)
at CarAI.SimulationStep(UInt16 vehicleID, Vehicle ByRef vehicleData, Frame ByRef frameData, UInt16 leaderID, Vehicle ByRef leaderData, Int32 lodPhysics)
at VehicleAI.SimulationStep(UInt16 vehicleID, Vehicle ByRef vehicleData, UInt16 leaderID, Vehicle ByRef leaderData, Int32 lodPhysics)
at TrafficManager.Custom.AI.CustomCarAI.CustomSimulationStep(UInt16 vehicleId, Vehicle ByRef vehicleData, Vector3 physicsLodRefPos)
at TrafficManager.Custom.AI.CustomCargoTruckAI.CustomSimulationStep(UInt16 vehicleId, Vehicle ByRef vehicleData, Vector3 physicsLodRefPos)
at VehicleManager.SimulationStepImpl(Int32 subStep)
at SimulationManagerBase`2.SimulationStep(Int32 subStep)
at VehicleManager.ISimulationManager.SimulationStep(Int32 subStep)
at SimulationManager.SimulationStep()
at SimulationManager.SimulationThread()  [Core]

Thanks for the feedback.

For Vehicle not found! I have fixed this issue in new release version of RealGasStation Mod.
Please update this Mod and Use TMPE to remove all vehicle.
Please feedback to me whether there is two dll inside
F:\SteamLibrary\steamapps\workshop\content\255710\1623509958

For ItemClass must be instantiated using the ScriptableObject.CreateInstance method instead of new ItemClass.
Can you unsub my mod and check if it is still exist?

@gatepoet
I fix 2
For 1, Please give me feedback，thanks

Fixed now.


Write Permissions in JSON

I'm not sure for other people, but I rather enjoy writing in JSON rather than YAML.  Is there a way we could let users choose what language they want to write in?

PEX2 uses json as its permissions format.


Rework of the converters

Hi @Koenkk
Due to the large number of issues which are opened again and again with the same problems:
e.g. Do I have a new device, how can I integrate it ?
e.g. How can I edit the file xyz ?
e.g. Multiple Converter for other devices but somehow different.
etc.
etc.
I have considered to revise the current state of converter.
Therefore I thought about the following structure:
per device a separate file e.g. vendor_model_ownedefinition.js
content. the section for fromZ
the section for fromZigbee and toZigbee as well as the actual devices part
e.g.
{
        zigbeeModel: ['lumi.sensor_switch'],
        model: 'WXKG01LM',
        vendor: 'Xiaomi',
        description: 'MiJia wireless switch',
        supports: 'single, double, triple, quadruple, many, long, long_release click',
        fromZigbee: [fz.xiaomi_battery_3v, fz.WXKG01LM_click, fz.ignore_onoff_change, fz.ignore_basic_change],
        toZigbee: [],
    },

so we have an own exact assignment for the converters for each model.
The advantage: Dynamic editing per model as well as simple adding of own models (e.g. with HASSIO).
I can take over the revision, but I need your help regarding the exports and the associated processing.
Maybe you would be interested to do this with me soon ?

Yes, but I doubt of this would solve the problems. Most people have trouble finding the devices.js file, understanding it isn't a problem most of the times. We get a lot of PR's supporting new devices which are most of the time good.


Double Tapping the Discovery Link Opens 2 Menus

DESCRIPTION:
If the user quickly taps the Discover link twice, two menus will appear.  The top menu will be properly populated with channels.  Dismissing the top menu reveals a blank menu underneath.

REPRO STEPS:

Launch LBRY 0.15.3 on Android 10
Double tap the 'Discover' link
Tap Back Button when menus open

Results: Two menus opened, one is blank
Expected: One menu opens

ENVIRONMENT:

Pixel 2 XL
Android 10
LBRY 0.15.3

MEDIA:

INTERNAL USE:

DEFINITION OF DONE:

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

LBRY ADDRESS:
bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b
<EMAIL_ADDRESS>

Fixed in https://github.com/lbryio/lbry-android/pull/898.

This still occurs in 0.15.6

Fix Confirmed 0.15.8


Map render function is called twice

Clicking on a feature calls map render function twice.
Reproduction:

Click on a single, not clustered feature.
Sidebar opens and logs Opening left sidebar with action twice, which means it is being rendered twice.

It is caused by React StrictMode.

To help you find accidentally impure code, Strict Mode calls some of your functions (only the ones that should be pure) twice in development.

I tested openaedmap.org and log is shown once. If it affects production please reopen


DoRA implementation differs from PEFT DoRA

@sayakpaul and I investigated an issue with loading a LyCORIS LoRA checkpoint which uses DoRA in diffusers. For some reason, we couldn't get the shapes of the DoRA scale vector to match with the shapes produced by PEFT (which is what diffusers uses under the hood). After some investigation, we think that the DoRA implementations diverge as the DoRA scale is applied along a different axis here compared to PEFT. To reproduce:
import torch
import torch.nn as nn
import torch.nn.functional as F

from lycoris import create_lycoris, LycorisNetwork

class DemoNet(nn.Module):
    """
    A Simple Pytorch Module for demo
    """

    def __init__(self):
        super().__init__()
        self.test_1 = nn.Linear(784, 2048)
        self.te_2st = nn.Linear(2048, 784)
        self._3test = nn.Linear(784, 10)

    def forward(self, x):
        h = self.test_1(x)
        h = F.mish(h)
        h = self.te_2st(h)
        h = x + h
        h = self._3test(h)
        return h

# FIRST APPLY LYCORIS DORA
net = DemoNet()
LycorisNetwork.apply_preset({"target_name": ["test_1"]})
lycoris_net1 = create_lycoris(net, 1.0, linear_dim=16, linear_alpha=2.0, algo="lora", dora_wd=True)
lycoris_net1.apply_to()

print(lycoris_net1.lycoris_test_1.dora_scale.shape)
# prints: torch.Size([1, 784])

# NOW USE PEFT DORA
from peft import LoraConfig, get_peft_model
net = DemoNet()
lora_config = LoraConfig(target_modules=["test_1"], use_dora=True)
peft_model = get_peft_model(net, lora_config)

print(peft_model.base_model.model.test_1.lora_magnitude_vector["default"].weight.shape)
# prints: torch.Size([2048])

As we can see, LyCORIS applies DoRA along axis 0 and PEFT along axis 1. If this observation is correct, it would make the DoRA checkpoints incompatible between the two packages and would also mean that one of the two is implementing DoRA incorrectly.

Linear(2048, 768) have weight matrix in shape [2048, 768]
based on the paper's description, they obtain weight decompose scale on "k" and their notation for weight matrix is "dxk"

I think in your example, LyCORIS have correct implementation
BUT, in my personal opinion, I think both implementation will have similar result.

Thanks for the quick response.
It can indeed be a bit confusing on what axis the DoRA scaling should be applied, especially with the transpose operation that's implicit in the linear layer. IIRC I had the wrong axis first when I started to implement it but one of DoRA authors reviewed the PR and made me aware of the mistake. Thus I'd like to assume it's correct in PEFT but maybe not :)
At the end of the day, it is not easy to make this change now, whether on the PEFT or LyCORIS side, as it would invalidate all existing DoRA checkpoints. So I guess we can just leave it as is if DoRA models are working fine in both implementations. It would just mean that checkpoints are incompatible between the two packages.

Thanks for the quick response.
It can indeed be a bit confusing on what axis the DoRA scaling should be applied, especially with the transpose operation that's implicit in the linear layer. IIRC I had the wrong axis first when I started to implement it but one of DoRA authors reviewed the PR and made me aware of the mistake. Thus I'd like to assume it's correct in PEFT but maybe not :)
At the end of the day, it is not easy to make this change now, whether on the PEFT or LyCORIS side, as it would invalidate all existing DoRA checkpoints. So I guess we can just leave it as is if DoRA models are working fine in both implementations. It would just mean that checkpoints are incompatible between the two packages.

Based on the equation in DoRA paper with W' = W+BA and B is [d, r] A is [r, k]
In Y = WX + B linear equation, it means k is for input axis and d is for output axis
Which is as same as how pytorch store their parameters (out_dim, in_dim)
I think LyCORIS is correct following the description in paper
But I won't deny the possibility that paper author actually want to apply on output axis

Thanks for the quick response.
It can indeed be a bit confusing on what axis the DoRA scaling should be applied, especially with the transpose operation that's implicit in the linear layer. IIRC I had the wrong axis first when I started to implement it but one of DoRA authors reviewed the PR and made me aware of the mistake. Thus I'd like to assume it's correct in PEFT but maybe not :)
At the end of the day, it is not easy to make this change now, whether on the PEFT or LyCORIS side, as it would invalidate all existing DoRA checkpoints. So I guess we can just leave it as is if DoRA models are working fine in both implementations. It would just mean that checkpoints are incompatible between the two packages.

If you think "apply on output axis" is somehow required
I can try to implement an option for user to select which to apply
BUT, I may not break the default behaviour.

I will support "loading" output axis ver of DoRA in LyCORIS first.

I agree that breaking the existing method is not a good idea. Whether adding a new option to use the other axis is worth it, I don't know.
I dug through the original code by the DoRA authors (which now switched to PEFT) and found this line:
https://github.com/NVlabs/DoRA/blob/bd3ed6f91bcfb1a1725089b6ba0325ab79404de0/commonsense_reasoning/peft/src/peft/tuners/dora.py#L389
Here it looks like the vector has the shape of out_features, not in_features. So in the code example above, that corresponds to 2048, which is what we see for PEFT. If I understand that code correctly, it corresponds to the PEFT implementation. But I agree that this seems to contradict the use of k in the snippets that you cite.

@BenjaminBossan ok I will take this as result of some misleading representation in paper
Will try to add some compatibility things in my side
not sure if PEFT will have it though. Since lot of user are using LyCORIS to training things too

Maybe @nbasyl can comment on the notation and if it would make sense to have an option to swap the axis.

@BenjaminBossan I added wd_on_output option in 3.1.1 and if you pass wd_on_output=True it will make correct weight decomposition


added an event

Nice! Also add the editorial links for all rounds.  We'll merge once you add them.
I see we gave a problem with having only one contest button. We'll deal with that separately. Maybe create an issue for it.
Linking with #25

I have made the changes. Please verify them.


Update documentation

Update:

UserGuide.adoc
README.adoc
Developer.adoc (version number)

Add:

New screenshot

Remove:

Old redundant screenshot

Pull Request Test Coverage Report for Build 439

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.435%

Totals

Change from base Build 437:
0.0%

Covered Lines:
2359

Relevant Lines:
2698

💛  - Coveralls


en

In this team, we are 4 in number,
@DilsherB , @fezzopro , @tumainimaganiko , and @rachaouldbabaali
here is the Link to the project

Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your board.
Invalid Code Review Request
You have submitted a project, that does not contain a screenshot of the current state of the Kanban Board at the time of review request which is seen as a requirement here
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Hope all is well, and that my comments were helpful. 😸
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.
Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

Hi @rachaouldbabaali,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:

All cards have assignees✔

Required Changes ♻

[ ] According to the project requirements:

At the time of this review, these are the pointings:
@tumainimaganiko 15
@rachaouldbabaali 9
@fezzopro 11
@DilsherB 10
As you can see, @rachaouldbabaali has 9 points while @tumainimaganiko has 15.  15-9 = 6.  6 > 5.
Kindly, make it so any skill member has no more than 5 points as compared to the other members of the team.
That way, we will meet this particular requirement.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you @Meltrust, the issue has been fixed

Hi @rachaouldbabaali ,
Wow, you did it 🎉

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗
Well done!
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To highlight

Pointings are now equal, according to the requirements.✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you @Meltrust 😃


Include millisecond logging

Missed this out on my PR from yesterday; merging in Stephen's changes that got accepted upstream by the Adhearsion project: https://github.com/adhearsion/adhearsion/pull/474/files
@sfgeorge Review per favor
cc: @rsuddeth

Dig it, danke! :+1:
@ajayanty Can you merge this for us?


cmd/compile: mention that -m can be given multiple times

-m can be given up to 4 times to increase the verbosity of the printed optimization decision: https://github.com/golang/go/search?q=LowerM

Should the flag description also be updated or should it be kept terse?
https://github.com/golang/go/blob/9a555fc24c318bf1b07bdc07d5c02e372681e401/src/cmd/compile/internal/base/flag.go#L72


Creator can Apply or Save a Color from/to Their Preset Library

[x] Click to apply a color to an element
[x] Save a color to presets
[x] Delete color preset

Verified in RC1