timestamp in suffix of indexname

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Create a model with 'Products'
Run a command 'artisan scout:import App\Models\Product'
Search term in Kibana 'GET _cat/indices'
See timestamp in suffix of indexname (products_1607192739)

Version
Laravel 8.0
Scout 8.4.0
This package (matchish/laravel-scout-elasticsearch) 4.0.3

I believe you've forgot to describe the bug)

We need timestamp for zero downtime update. Alias of the index is products so when you make query to products actually you do do it against index with timestamp

We need timestamp for zero downtime update. Alias of the index is products so when you make query to products actually you do do it against index with timestamp

I understand, thanks :+1:


Complex Generics and conditionals

Bug Report
🔎 Search Terms
generic generic expressions
🕗 Version & Regression Information
All tested versions
⏯ Playground Link
Playground link with relevant code
💻 Code

class A<
    A_GENERIC extends Array<any> | Record<string, any> = Record<string, any>
> {
    constructor(displayType: A_GENERIC extends Array<any> ? 'array' : 'entity') {

    }
}

class B<B_GENERIC extends Record<string, any> = Record<string, any>> extends A<B_GENERIC> {
    constructor() {
        super('entity');
    }
}

🙁 Actual behavior
TSError:
Argument of type '"entity"' is not assignable to parameter of type 'B_GENERIC extends any[] ? "array" : "entity"'.

🙂 Expected behavior
No TS Errors because B_GENERIC extends {}

It's a design limitation. See https://github.com/microsoft/TypeScript/issues/34634#issuecomment-545415219.

@MartinJohns ohhh, thanks! You don't know any workarounds for this?


show witness distance in poc transactions

{hotspot_name} witnessed {distance in miles} away at {rssi}, {SNR}, {SF}, valid/invalid.

Since we check max distance (poc_max_hop_cells) and hex distance (poc_v4_exclusion_cells) we should show those instead?

@abhay what would that way look like in the UI? I'm not too familiar with h3 yet or what those chain vars represent exactly, so I'm not quite sure how I'd implement that or how well it would solve the user problem here. Would that be an overlay on the map? Do you think that's something I could add in addition to the way @cokes518 suggested above?
I was just about to add it the way Coco suggested by converting from h3 to lat/lon and using this function and just printing out the distance when I saw your comment, so not sure how to proceed on this for now.

@danielcolinjames hotspots have an h3 which represents the cell so you want to do distance between h3 indexes at the very least. From there you can see if it's within the range of the chain vars.

@abhay ah okay perfect, I get it now, thank you! I'll see if I can figure out some way to colour it with a success / fail colour without looking awful too...

I'm sure it'll look 💯

Potentially don't bother showing this data for any transactions before block 123479 (when poc_v4_exclusion_cells was set at poc_version = 4) or 200500 (when poc_max_hop_cells was set at poc_version = 8).

Thanks, that's really helpful to know, will do some tests with transactions around those block numbers and see 👍
Also, just to double check, if a distance == 8, it's excluded right? I.e. the rule is: valid = distance > 8 && distance < 2000, rather than >= 8 && <= 2000, right?
(Obviously won't hard code the values)

Please ignore the design of this, just testing locally, but I think I'm going to rearrange the layout of the witness info to something like this:

Also, just to double check, if a distance == 8, it's excluded right? I.e. the rule is: valid = distance > 8 && distance < 2000, rather than >= 8 && <= 2000, right?

valid ~= poc_v4_exclusion_cells <= hex_distance < poc_max_hop_cells
low end: https://github.com/helium/blockchain-core/blob/master/src/poc/blockchain_poc_path_v4.erl#L335-L346
high end: https://github.com/helium/blockchain-core/blob/master/src/poc/blockchain_poc_path_v4.erl#L319-L330


feat: added auto curVersion with device info

This PR makes the curVersion parameter optional as it takes the app version using rn-device-info.
Also mentioned in - #15

@SudoPlz can you please review the PR and let me know if there is any change required.

How should I test it ? I don't see any test files

I mean locally, using the example project.
Also what's with the yarn file changes, was that intended?
Looking good so far.

I am getting this on android
And ios build is failing for some reason (maybe due to latest xcode update)

Okay after fixing pods again it seems to work tested it with and without passing version.
Hope now you can merge it

Cool, thanks for the changes, looking good so far.
Question, what's with the yarn file changes, was that intended?

I removed yarn files because I added it accidentally, seems you are using
npm instead of yarn.
On Wed, May 5, 2021, 5:10 PM Ioannis Kokkinidis @.***>
wrote:

Cool, thanks for the changes, looking good so far.
Question, what's with the yarn file changes, was that intended?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SudoPlz/sp-react-native-in-app-updates/pull/20#issuecomment-832620589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVA4NWJL62MJWCAQHBQ37TTMEVCNANCNFSM44CUFJNQ
.

I still see yarn files in your pr

is it fine now ?

There's still a .yarnrc file, could you please delete that too?
Thanks

@SudoPlz I have deleted it, it's actually in your repo.

@ShivamJoker apologies I totally missed that.
Merging now.

Released under 1.1.0

Released under 1.1.0

Wouldn't it be better to use github actions and connect release directly to npm ?

Do you feel like creating a pr for that too?

@SudoPlz we are still needing to pass empty object, can you fix it ?

@ShivamJoker that was just a typings issue. Fixed it on 1.1.1


Does not work with Uglify

as the title says, i tried using it with ionic framework and it compiles with uglify where it doesnt work!

Yes, even I am facing same issue when I import this plugin to Angular 8 project. I am getting following error.
clj-fuzzy.js:2 Uncaught TypeError: Cannot use 'in' operator to search for 'clj_fuzzy' in undefined
at ea (clj-fuzzy.js:2)
at clj-fuzzy.js:5
at Object../node_modules/clj-fuzzy/src-js/clj-fuzzy.js (clj-fuzzy.js:6)
at webpack_require (bootstrap:79)
at Object../node_modules/words-to-numbers/dist/index.js (index.js:21)
at webpack_require (bootstrap:79)
at Object../node_modules/words-to-numbers/index.js (index.js:1)
at webpack_require (bootstrap:79)


build randomly fails with error code 65

Issue Description
I migrated our manual buildscript to fastlane some time ago and I am very happy in general. The only problem I have left, is random build failures. In average every second build fails with error code 65 without any more information. Before using fastlane, I didn't have these errors.
I googled a lot, but couldn't find anything that helped me. My experience with ios is limited. So I am stuck on how to debug this. There is nothing in the logs that indicates an error. I don't think its a configuration problem, otherwise it should always fail. Is there something I can run differently to get more information what fails? Any documentation that I can read that might help me? Or some other place I should rather ask?
Complete output when running fastlane, including the stack trace and command used
I run:  fastlane staging
....
build	18-Apr-2016 08:19:31	â–¸ Running script 'Copy Pods Resources'
build	18-Apr-2016 08:19:31	â–¸ Running script 'Upload dSYM File'
build	18-Apr-2016 08:19:31	â–¸ Running script 'Increase Build Number'
build	18-Apr-2016 08:19:31	â–¸ Running script 'Embed Pods Frameworks'
build	18-Apr-2016 08:19:31	â–¸ Touching our.app
build	18-Apr-2016 08:19:31	â–¸ Signing /Users/marketing/Library/Developer/Xcode/DerivedData/our-dmeacgssaqxzojagsftlykfuymct/Build/Intermediates/ArchiveIntermediates/..../some.app
build	18-Apr-2016 08:19:31	â–¸ Touching some.app.dSYM
build	18-Apr-2016 08:19:31	** ARCHIVE FAILED **
build	18-Apr-2016 08:19:31	[08:19:32]: Exit status: 65
build	18-Apr-2016 08:19:31	[08:19:32]: -------------------
build	18-Apr-2016 08:19:31	[08:19:32]: --- Step: slack ---
build	18-Apr-2016 08:19:31	[08:19:32]: -------------------
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
default_platform :ios

platform :ios do
  before_all do
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/x"
    cocoapods
    unlock_keychain(
      path: "",
      password: "password",
      set_default: true
   )
  end

  private_lane :build do |options|

   appId = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)

   update_info_plist(
    app_identifier: appId,
    plist_path: "path/to/plist.plist"
  )
   update_app_identifier(
     app_identifier: appId,
     plist_path: "path/to/plist.plist"
   )

   increment_build_number({
     build_number: latest_testflight_build_number + 1
   })
   cert(keychain_path:"keychain/path/")
   sigh

   if options.key?(:family)
     gym(scheme: "our Release",
        xcargs: "TARGETED_DEVICE_FAMILY=\"#{options[:family]}\""
        )
   else
     gym(scheme: "our Release")
   end

 end

  desc "Runs all the tests"
  lane :test do
    scan
  end

  desc "Build for stating"
  lane :staging do

   update_info_plist(
   plist_path: 'path/to/plist.plist',
   display_name: 'our alpha'
   )
   badge(alpha: true)

   build
   pilot(skip_submission: true)

  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful

     slack(
       message: "Successfully uploaded a testversion for #{lane}."
     )
  end

  error do |lane, exception|
     slack(
       message: "error on lane #{lane}: " + exception.message,
       success: false
     )
  end
end

Environment
fastlane version fastlane 1.81.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
no
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
no

For me too
Here is the same thing

So i was thinking where i am wrong so i started scrolling on top and see this

** CLEAN FAILED **

The following build commands failed:
Clean.Remove clean path of that file or framework
Now i have two questions

If CLEAN FAILED than can we stop the process of Archiving ?
can we change the color of FAILED messages like its currently in pink which is the same as warning message of the compiler so wasn't able to get notice i am attaching the screens below for better idea?

@saruye Can you please post the full log? Thanks.

Hi I uploaded the outputs of a successful build and a failing one. I don't see much difference between the 2 logs :/
When I was researching the error I found that some people had a problem with a failing script. I checked some of them and I don't think that they fail. I also checked the build log (/Users/marketing/Library/Logs/gym/coolApp-coolApp\ Release.log) for more detailed information and they also liked quite similar and I couldn't find any errors there either.
Is there anything else I can run to get more detailed information about why this error is occurring?
Thanks for you help already!
fastlane_staging_20160421_0726_success.txt
fastlane_staging_20160421_error.txt

@saruye Thanks for the logs. Can you isolate the gym call and confirm if you still see the issue? If so, can you try building your app using xcodebuild? Do you see the same behavior?

I extracted the set -o pipefail && xcodebuild -workspace './fileee.xcworkspace' -scheme 'fileee Release' -destination 'generic/platform=iOS' -archivePath '/Users/marketing/Library/Developer/Xcode/Archives/2016-04-22/fileee 2016-04-22 06.40.09.xcarchive' archive | tee /Users/marketing/Library/Logs/gym/fileee-fileee\ Release.log | xcpretty
and did run it for a couple of times. I did see the same behavior. Sometimes it suceeds, sometimes it fails. I also did run it without the pipefail and still saw failures sometimes. Do you want me to provide some logs without |xcpretty?

Hi @saruye! Thanks for following up. If your build fails when you use xcodebuild it isn't an issue with Fastlane. Are you able to build your app in Xcode itself? Thanks!

hi,
building with Xcode doesn't produce these issues. I suspected it might not be fastlane directly. I posted it here since I didn't have the issue before migrating to fastlane and I am totally stuck and don't know where else to look for the cause of these random failures. Can you hint me at some other place where to look? Or some command to run?
Thanks!

@saruye Thanks for following up. I'm going to close out this issue, because it looks like you are seeing the same problem as #4197. We are going to work through this over there. Thanks!

Thanks for looking into this! If I can test something or be of any help, let me know. Looking forward to this issue being resolved :)


[UIExplorer]Fix UIExplorer some stuff

Fix UIExplorer header :

Thanks for the PR!
I think these issues have been fixed in other diffs that have sync'd or will sync to github soon.


HTTP::Client: don't turn body_io into nil if content-length is zero

Fixes #8461

Cool! I can't merge because of the requested changes, but if someone else can, please do.


Update from-now.md

fromNow() actually returns distance from time with prefix in

https://github.com/dayjs/dayjs-website/pull/110#issuecomment-1510390469


Uncompressed RAW in A6000

Not seen it elsewere. The only thing that is trully a necessity for me is uncompressed raw, even if the buffer is full faster, or it takes forever to write to the memory card. I do a lot of night /strartrails/ timelapse and the compressed raw option drives me insane, with all the problems it gives to users like myself.
Can it be implemented? If so, can we have it? Thank you in advance!

+1

I don't think this can be implemented As said on the main page "keep in mind, this app can only unlock features that are already there".  Uncompressed raw is not a hidden feature on any "A" series of camera.  This hack is not the same as Magic Lantern... Magic Lantern added new features to Canon cameras. This hack just unlocks hidden features.

The a7ii series has had the ability to do uncompressed raw since firmware 2.0 in Nov 2015-- so it does exist in some form in those firmwares-- given that the a7ii and the a7 have the same processor/sensor shouldn't their firmwares be cross compatible?  I'm not sure if there are any other hardware differences (RAM amounts and such...)

I think ALL Sony cameras have the same BIONZ processor.  At least every
camera from the a6000 up has it.  Sensors and things change, but I've never
heard of Sony using a different processor...  With Canon you always hear
about Digic 5 and Digic 6 and all that.. .I've never heard about anything
but the same BIONZ for all Sony cameras... (though the amount of RAM
could differ.. I kinda doubt it.)
On Fri, Jul 8, 2016 at 10:31 PM, lessbones<EMAIL_ADDRESS>wrote:

The a7ii series has had the ability to do uncompressed raw since firmware
2.0 in Nov 2015-- so it does exist in some form in those firmwares-- given
that the a7ii and the a7 have the same processor/sensor shouldn't their
firmwares be cross compatible? I'm not sure if there are any other hardware
differences (RAM amounts and such...)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ma1co/OpenMemories-Tweak/issues/54#issuecomment-231465040,
or mute the thread
https://github.com/notifications/unsubscribe/ADSkd3NV5dYxF997q4M2FffNDXUmoKqsks5qTrOqgaJpZM4Iemrn
.

An app to enable uncompressed RAW on the A6000 would be great! Hope this can be a reality in the near future!

+1


Reproject replaces 0 with -1 if nodata is not set

I have a custom Landsat cloud mask based on QA band with values 0 and 1 and a Landsat panchromatic band. When I try to match cloud mask to a resolution of a panchromatic band with odc.reproject, 0's in a mask are replaced with -1's.
mask_pan = mask.odc.reproject(pan.odc.geobox).persist()
mask.rio.nodata == None                  # True (nodata is not set)
mask_pan.rio.nodata == None              # True (nodata is not set)
mask.data[0][2000][2000].compute()       # 0 (0 - data, 1 - cloud)
mask_pan.data[0][4000][4000].compute()   # -1 (panchromatic band is 2x larger than the others)
np.unique(mask)                          # array([0, 1])
np.unique(mask_pan)                      # array([-1,  1])

But, for example, if we set a nodata in mask, or pass dst_nodata=-1 arg, then 0's are not replaced.
Also, it happens only if data is integer, and everything works correctly if data is float.
P.S. Here is also a notebook with minimum examples that shows the cases when this bug occurs and when it does not.
https://colab.research.google.com/drive/1MPoYkNOsBAZ6CBOSitYxtR1mhwn1QMU5?usp=sharing

Hi Simon.

What odc-geo version are you using?

import odc.geo as geo
geo.__version__

mask_pan.odc.nodata == mask_pan.rio.nodata?

odc-geo version: 0.4.8
mask_pan.odc.nodata == mask_pan.rio.nodata is True


Add an Windows title bar

@XxThunderBlastxX  If you give the more information about this issue I can try to contribute to it

@SoumyadeepOSD Its the long top bar you can see for any application. It consist of minimize, maximize , close button on right hand side.
You can use bitsdogo_windows package for this as well.
While doing this I would suggest you to make it as a common reusable widget.

Go for it

@XxThunderBlastxX i want to work on this issue after my latest PR #21 is merged. Can i take up this issue after it is merged ?

I would like to work on this issue... Can you please assign this to me..


Removed volume tag from root volume

Removed volume tag from ec2 instance. This modify permit to tag ebs volume attached to the ec2 instance without conflicts.
A terraform bug create conflict between tag  of root volume (defined on the ec2 resource) and ebs tag.

v1.23.0 has been released with support for volume_tags.
Terraform 0.11 users can use it. Similar functionality for Terraform 0.12 will be released soon.


Rename Circuit.to_unitary_matrix to Circuit.unitary

Goal: be consistent with cirq.unitary.
Could drop the method, but it provides more useful options.

Adding deprecation


Tag support in the future?

I know the theme wants to capture the minimalist spirit and it's a wonderful theme, but tags are missing and that would be a really useful addition.

Tagging seems to work through hugo's default taxonomies https://gohugo.io/content-management/taxonomies/


6.0.0-beta.x regression, array of data imported as JSON file get transformed to an object, why?

Describe the bug
I have a JSON file with the following structure
[
  {"name":"Ethel Price","gender":"female","company":"Enersol","id":1,"category":{"id":1,"name":"Gold"}},
  {"name":"Claudine Neal","gender":"female","company":"Sealoud","id":2,"category":{"id":1,"name":"Gold"}},
]

when I import the file via an import, it is returning an array (good) of data in Vite 5.x but in 6.x it imports the same file as an object (bad) for unknown reason when I expect it to remain an array. This seems like a regression when comparing to Vite 5.x
Reproduction
https://stackblitz.com/edit/vitejs-vite-qwnzvw?file=main.js
Steps to reproduce
Just run the Stackblitz provided.
running the same Stackblitz with Vite 5.x I get this

but running with Vite 6.0-beta, I get this (notice the prototype changes to Object instead of Array)

System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 1.71 GB / 15.85 GB
  Binaries:
    Node: 20.13.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.9.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.12.2 - C:\OwnCloudDev10\GitHub\slickgrid-universal\node_modules\.bin\pnpm.CMD
  Browsers:
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.19041.4355

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It seems I broke it in #18303. For now, setting json.stringify: false would work.

Ah thanks for the info, I'm assuming that it's because of line 54 since pretty everything in JS is derived from object and that includes arrays. Perhaps the if condition should skip arrays?
https://github.com/vitejs/vite/blob/f65d6ae5a762708d2412da37fb4efc0256f1b535/packages/vite/src/node/plugins/json.ts#L51-L55

We also have a isObject utility that we can use: https://github.com/vitejs/vite/blob/8a7af50b5ddf72f21098406e9668bc609b323899/packages/vite/src/node/utils.ts#L387-L389


Twig/Extensions is no longer maintained and breaks Opcache Preload

Summary

The dependency https://github.com/twigphp/Twig-extensions is no longer maintained and there is options to migrate to their readme
Currently this extension is breaking PHP 7.4 Opcache preload fonctionality.
Steps to reproduce

Actual Result

Fatal error</b>:  Cannot redeclare twig_truncate_filter() (previously declared in vendor/twig/extensions/lib/Twig/Extensions/Extension/Text.php:38) in

Expected Result

Details about your environment

OroPlatform version:  4.1
PHP version: 7.4.5

Additional information

I've got the same issue

We removed twig/extensions dependency in 4.2 LTS version.


CRASH on deleting single character

Select Text -> Click New -> type Qwerty. Now start deleting the characters. App will crash when you'll delete last character Q. Reason for crash is '-[__NSCFConstantString characterAtIndex:]: Range or index out of bounds'
in CLTextSettingView.m
in -(void)textViewDidChange:(UITextView*)textView
Here's the line of code causing crash: (Line No. 304)
if(selection.location+selection.length == textView.text.length && [textView.text characterAtIndex:textView.text.length-1] == '\n') {

I've just run into this issue. The problem also happens if you highlight all existing text and tap delete. The if statement needs to also ensure the text view has at least one character in it before trying to access the character at length - 1.

We've run into the same issue :(
@yackle any chance that PR can be merged??

@az-oolloow
Could you open PR on this repository?

@yackle I faced this issue too and open a PR at https://github.com/yackle/CLImageEditor/pull/238, please let me know if this could be merged


Enable Media library video optimization by default

Context

Summary
Remove the feature flag for video optimization via media library.
Relevant Technical Choices
Move toggleVideoOptimization util to e2e-utils package.
Tweak e2e tests to use toggleVideoOptimization util
Remove enableMediaPickerVideoOptimization feature flag.
To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #7842

QA + UAT instructions would be great as this is a user-facing change

QA + UAT instructions would be great as this is a user-facing change

@swissspidy Is that needed? It was tested as part of https://github.com/google/web-stories-wp/pull/7766

At the very least we'd want reassurance that it still works as expected & is enabled by default now. So should be a very quick one to QA.

At the very least we'd want reassurance that it still works as expected & is enabled by default now. So should be a very quick one to QA.

Added QA instructions.


Awesome Book issues.

Awesome Books: A complete website with navigation is an exercise in which I will take the Awesome books application and convert it into a fully functional website. I will refactor the project to add three new sections on top of the two sections, i have already completed: Books list (done), Add book form (done), a new Contact info section, a Navigation bar, and a Footer. The goal here is to master all of the tools and best practices learned about in previous steps to use them in all Microverse projects and most likely in my future job as well.

you done good job Bro

I have nothing to mention in your project
just well done 👍

You did everything as per requirment
Good job


DOC: whatsnew edits

ok, will tag after you merge this (and @TomAugspurger makes his API.rst change)


Create PoC for Client <=> Server Interaction

This involves creating a webpage that has two side-by-side instances of the game loaded that each represent the two players.  The left side is Player 1 and the right side is Player 2.  When it is Player 1's turn, Player 2 is unable to move any units but is capable of selecting/viewing units and visa-versa.  The two instances of the game will communicate with an instance of a virtual server class that will be responsible for echoing actions taken during a turn to the two client instances.'
As part of the refactoring, the offline apps vs bots (Chaos and Faceoff) will work similar to Player vs Player.  That is, the player client instance will communicate with a virtual server instance, which will relay actions between the player and the bot.
All work will be done in the "client" branch until it is complete.  Upon completion, the client branch will be merged into master since it should continue to work even when a true server is absent.

Added a new commit to the client branch that represents a major refactoring of the client code.  It centers around creating a class to manage game state.  Game state management is something that will be expected of a server, but can also run in the browser for offline games.  In the process of creating this class, I've implemented game data and made some changes to player turn data.  I also made incremental progress on other initiatives such as removing jQuery dependence and converting classes to use ES6 module and class syntax.
Even when running in a browser, however, there needs to be a fairly strong boundary between the client and game state.  Right now, the Game class talks directly to the GameState class.  This is not a terrible thing, but I will introduce a new class called "LocalTransport" that will initialize a Web Worker.  The GameState class will run inside that Web Worker.  The "LocalTransport" class will transparently proxy data exchange between the Game class and the Web Worker.  The benefit of using a Web Worker is to allow the GameState class to run in a separate thread than the Game class.  This will be particularly helpful in allowing the Game class to run smooth animations while bots are thinking hard about their next move in parallel.  Right now, animations will stutter while bots think.  Implementing true parallel thread processing makes the offline game experience operate more similarly to an online game experience.
At some point, we will also create a "RemoteTransport" class that will facilitate data exchange between the Game class and the server.  The Game class does not care if it is talking to a remote or local transport since the interface is expected to be the same.  An instance of either class may be provided to an instance of the Game class so that the Game instance can request and observe changes in state.

I have changed direction on how to provide a proof-of-concept of client-server communication.  Rather than creating side-by-side apps showing two game clients talking to each other, I have created a web worker that runs the server-side logic in the browser.  The communication between the app and the web worker is similar to the expected communication between the app and a server.
This is now complete and all code has been merged to master.


update to latest lodash

why are you still using old lodash?

Hey man, just a heads up, on their README they say:

This project is not being actively developed or maintained.

We need to do this before we pull in the latest dagre as we've moved dagre to lodash 4.


Inventory as template and single bootstrap script 4

Change content and motivation

Changes inventory to a template file.
Changes bootstrap script into single bootstrap script that can be changed via config file.
Adds role "master" to node labels. (Needed to separate nodes when selecting which part of bootstrap script to run)
Changes deprecated ansible_ssh_user to ansible_user
Sets kubernetes token to default "" so it can be left out of config if Kubernetes is not to be installed. Empty string will not be acceped by KubeAdm so not a security issue.
Generates openstack list of public ip for ansible-inventory with private ip if no public ip is set (to overcome problem with inventory from template)

@andersla maybe merge master for latest fixes, so the CI will pass


Suggestion: use eslint to upgrade vars to es6

I see alot of prs to upgrade to es6. Some noise might be reduced if you set eslint to require let and const, then allow eslint to auto fix the errors..

Feel free to close or disregard, this is a process suggestion, not a webpack issue

No probs.
We set up defaults for the contrib projects. If you have time, give it a go and let us know what you think. 👍

@bebraw is this still up for grabs?

@tarang9211 I'm not sure. Just checking. I hope Tobias comments. 👍

@bebraw @sokra Sounds good. Looking forward to fixing this.


[FEATURE] Allow overriding the @SuperBuilder c'tor

I appear not to be able to do the following:
    @SuperBuilder
    class SomeClass {
        protected SomeClass(SomeClassBuilder<?, ?> b){
            // ...
        }
    }

as the compiler complains that the c'tor is already defined. I assume the error comes from Lombok inserting the c'tor, even if it is already written in the source.
This seems to be at odds with other Lombok features, such as for instance @Builder. It would really be nice to be able to do this.
Granted, in order to work like the Lombok-generated c'tor, the manually-written one would have to do quite a bit of voodoo. But this seems better than the alternative, which is to de-lombok the whole class.
Use case
I encountered this case while trying to write a data structure with a Map field, where I wanted both to leverage the @Singular annotation (for easier building) and at the same time have a modifiable map. @Singular generates unmodifiable maps. If it had been @Builder, I could have written a c'tor taking the builder and made sure my map was mutable. With @SuperBuilder, I do not appear to be able to.
The problem at hand might also be solvable if there were an option to have mutable structures with @Singular. However, the changed proposed here seems to me both less intrusive and potentially more useful in general.

Can confirm. This is simply not implemented yet, but should not be much of an effort.
However, I think your problem could be solved also right now by manually implementing the singular methods. If you don't need the immutability, it's not that complex. Furthermore, you won't create the same map three times.

However, I think your problem could be solved also right now by manually implementing the singular methods.

Blimey! Hadn't thought of that. Can confirm it works. Thank you very much, @janrieke. That was... some impressive visualisation there.


receive: can not load WAL data when restart

Thanos, Prometheus and Golang version used:
Thanos: self build from thanos master: a09a4b97c243b7652446685c73f6b80bb9417fe2
Golang: go version go1.12.7 darwin/amd64
Prometheus: 2.13.0
thanos build command: GOOS=linux GOARCH=amd64 go build -o thanos ./cmd/thanos
What happened:
I'm trying to use thanos receive, they are running as expected hours before I restart it.
the thanos receive try to load WAL data again and again
What you expected to happen:
load WAL data and listen & receive new data.
How to reproduce it (as minimally and precisely as possible):
I'm not sure is there any logic issue when receive starting? the thanos-0.7 can restart successful but master code cannot.
Full logs to relevant components:
Logs

level=info ts=2019-10-10T13:11:00.909450843Z caller=main.go:170 msg="Tracing will be disabled"
level=warn ts=2019-10-10T13:11:00.909646509Z caller=receive.go:145 component=receive msg="setting up receive; the Thanos receive component is EXPERIMENTAL, it may break significantly without notice"
level=info ts=2019-10-10T13:11:00.910759805Z caller=factory.go:39 component=receive msg="loading bucket configuration"
level=info ts=2019-10-10T13:11:00.913326316Z caller=receive.go:432 component=receive msg="starting receiver"
level=info ts=2019-10-10T13:11:00.913810978Z caller=handler.go:160 component=receive component=receive-handler msg="Start listening for connections" address=<IP_ADDRESS>:19211
level=info ts=2019-10-10T13:11:00.913638216Z caller=main.go:353 component=receive msg="listening for requests and metrics" component=receive address=<IP_ADDRESS>:19210
level=info ts=2019-10-10T13:11:00.913837063Z caller=main.go:257 component=receive msg="disabled TLS, key and cert must be set to enable"
level=info ts=2019-10-10T13:11:00.91392518Z caller=prober.go:143 component=receive msg="changing probe status" status=healthy
level=info ts=2019-10-10T13:11:00.914250195Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570680000000 maxt=1570687200000 ulid=01DPT7F6K1TJJC4XAJJ9WVBZY5
level=info ts=2019-10-10T13:11:00.91435138Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570687200000 maxt=1570694400000 ulid=01DPTEAZDMJJDYSZ5XVQ9Z76XQ
level=info ts=2019-10-10T13:11:00.914334174Z caller=receive.go:293 component=receive msg="hashring has changed; server is not ready to receive web requests."
level=info ts=2019-10-10T13:11:00.914388157Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570694400000 maxt=1570701600000 ulid=01DPTN6PKK3HJA99PH74XZYWPX
level=info ts=2019-10-10T13:11:00.914437502Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570701600000 maxt=1570708800000 ulid=01DPTW2DQ6DQT1YZ9BF40QJS47
level=info ts=2019-10-10T13:11:01.480532567Z caller=head.go:509 component=receive component=tsdb component=tsdb msg="replaying WAL, this may take awhile"
level=info ts=2019-10-10T13:11:54.313611621Z caller=head.go:533 component=receive component=tsdb component=tsdb msg="WAL checkpoint loaded"
level=info ts=2019-10-10T13:11:58.976905831Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2034 maxSegment=2167
level=info ts=2019-10-10T13:12:03.674326957Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2035 maxSegment=2167
level=info ts=2019-10-10T13:12:08.825274021Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2036 maxSegment=2167
level=info ts=2019-10-10T13:12:13.699480427Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2037 maxSegment=2167
level=info ts=2019-10-10T13:12:18.64123707Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2038 maxSegment=2167
level=info ts=2019-10-10T13:12:23.570922965Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2039 maxSegment=2167

.....

level=info ts=2019-10-10T13:22:40.613369573Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2165 maxSegment=2167
level=warn ts=2019-10-10T13:22:41.261691466Z caller=head.go:492 component=receive component=tsdb component=tsdb msg="unknown series references" count=104
level=info ts=2019-10-10T13:22:41.261809977Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2166 maxSegment=2167
level=info ts=2019-10-10T13:22:41.26233365Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2167 maxSegment=2167
level=info ts=2019-10-10T13:23:18.541986663Z caller=head.go:509 component=receive component=tsdb msg="replaying WAL, this may take awhile"
level=info ts=2019-10-10T13:24:06.787360411Z caller=head.go:533 component=receive component=tsdb msg="WAL checkpoint loaded"
level=info ts=2019-10-10T13:24:11.174920806Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2034 maxSegment=2167
level=info ts=2019-10-10T13:24:15.48524744Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2035 maxSegment=2167
level=info ts=2019-10-10T13:24:20.140672496Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2036 maxSegment=2167
level=info ts=2019-10-10T13:24:24.467852131Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2037 maxSegment=2167
level=info ts=2019-10-10T13:24:28.944796843Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2038 maxSegment=2167

....

level=info ts=2019-10-10T13:33:51.954823544Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2136 maxSegment=2167
level=warn ts=2019-10-10T13:33:57.647949531Z caller=head.go:492 component=receive component=tsdb msg="unknown series references" count=6973
level=info ts=2019-10-10T13:33:57.648056531Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2137 maxSegment=2167
level=warn ts=2019-10-10T13:34:03.485428154Z caller=head.go:492 component=receive component=tsdb msg="unknown series references" count=7034
level=info ts=2019-10-10T13:34:03.485536561Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2138 maxSegment=2167
level=info ts=2019-10-10T13:34:22.347698132Z caller=main.go:170 msg="Tracing will be disabled"
level=warn ts=2019-10-10T13:34:22.348067504Z caller=receive.go:145 component=receive msg="setting up receive; the Thanos receive component is EXPERIMENTAL, it may break significantly without notice"
level=info ts=2019-10-10T13:34:22.34921212Z caller=factory.go:39 component=receive msg="loading bucket configuration"
level=info ts=2019-10-10T13:34:22.353678479Z caller=receive.go:432 component=receive msg="starting receiver"
level=info ts=2019-10-10T13:34:22.353887745Z caller=main.go:353 component=receive msg="listening for requests and metrics" component=receive address=<IP_ADDRESS>:19210
level=info ts=2019-10-10T13:34:22.354027884Z caller=prober.go:143 component=receive msg="changing probe status" status=healthy
level=info ts=2019-10-10T13:34:22.354002076Z caller=handler.go:160 component=receive component=receive-handler msg="Start listening for connections" address=<IP_ADDRESS>:19211
level=info ts=2019-10-10T13:34:22.354402573Z caller=main.go:257 component=receive msg="disabled TLS, key and cert must be set to enable"
level=info ts=2019-10-10T13:34:22.35507048Z caller=receive.go:293 component=receive msg="hashring has changed; server is not ready to receive web requests."
level=info ts=2019-10-10T13:34:22.355474967Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570680000000 maxt=1570687200000 ulid=01DPT7F6K1TJJC4XAJJ9WVBZY5
level=info ts=2019-10-10T13:34:22.355602831Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570687200000 maxt=1570694400000 ulid=01DPTEAZDMJJDYSZ5XVQ9Z76XQ
level=info ts=2019-10-10T13:34:22.355642604Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570694400000 maxt=1570701600000 ulid=01DPTN6PKK3HJA99PH74XZYWPX
level=info ts=2019-10-10T13:34:22.355704854Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1570701600000 maxt=1570708800000 ulid=01DPTW2DQ6DQT1YZ9BF40QJS47
level=info ts=2019-10-10T13:34:22.840486871Z caller=head.go:509 component=receive component=tsdb component=tsdb msg="replaying WAL, this may take awhile"

Environment:

OS (e.g. from /etc/os-release): ubuntu
Kernel (e.g. uname -a): 4.15.0
Others:

On master receive will on startup ensure that it starts with a clean state, so it loads the WAL, flushes it to a block and then uploads it. That's why you're seeing it be loaded multiple times.

@brancz @squat sorry for later reply. I didn't see critical errors except some unknown series error log like  caller=head.go:492 component=receive component=tsdb msg="unknown series references" count=6973.
if it will load multiple times, is there an exact number of how many times? seems it's an infinite loop and always loading

@GuyCheung the WAL will be reloaded twice on startup (only one of the two times actually has data played back) and two times every two hours:
During startup:

startup for ReadOnly DB flush (data is played back)
startup for Write DB

... then every two hours:

once for ReadOnly DB flush (data is played back)
again for Write DB open

@squat thanks for ur information! I think I know why it's always keep loading... the process had been OOM and been killed. I have some questions based on this, could you help me?

1st, during multiple times replay, the memory will not released?

In my mind, I think the memory will not much bigger than the data folder on the disk? but I found the process took about 47G memory(total 48G), and the WAL data folder on disk was about 22G
the process took about 47G memory when been killed:
[7140727.569918] Out of memory: Kill process 89696 (thanos) score 936 or sacrifice child
[7140727.573522] Killed process 89696 (thanos) total-vm:52478600kB, anon-rss:47156872kB, file-rss:0kB, shmem-rss:0kB
[7140730.168611] oom_reaper: reaped process 89696 (thanos), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

the receiver data folder size like below:

2nd, according to this situation, is there some way I can limit the memory to avoid OOM?

I try to find the answer on the internet, but unfortunately, I didn't find any useful information, and there is a voice said the Prometheus 2 can not limit the memory, I'm not sure about this.

3rd, about the WAL replay, I got succeed on a 128G memory host, but seems not only replay twice?

I think it was replayed triple times during startup, and each time seems took 10 minutes, did this act as ur expectation?  is there sth we can do to reduce the replay time cost?
the key points of my logs like below:

level=info ts=2019-10-15T11:30:13.41402523Z caller=receive.go:432 component=receive msg="starting receiver"
level=info ts=2019-10-15T11:30:13.414148657Z caller=main.go:353 component=receive msg="listening for requests and metrics" component=receive address=<IP_ADDRESS>:19210
level=info ts=2019-10-15T11:30:13.414159228Z caller=handler.go:160 component=receive component=receive-handler msg="Start listening for connections" address=<IP_ADDRESS>:19211
level=info ts=2019-10-15T11:30:13.414214989Z caller=prober.go:143 component=receive msg="changing probe status" status=healthy
level=info ts=2019-10-15T11:30:13.414218471Z caller=receive.go:293 component=receive msg="hashring has changed; server is not ready to receive web requests."
level=info ts=2019-10-15T11:30:13.414273506Z caller=main.go:257 component=receive msg="disabled TLS, key and cert must be set to enable"
level=info ts=2019-10-15T11:30:13.414441585Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571104800000 maxt=1571112000000 ulid=01DQ6WK24Q2YT0FF2P4X9C24QQ
level=info ts=2019-10-15T11:30:13.414492525Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571112000000 maxt=1571119200000 ulid=01DQ73ESJB1ADEC1AJ53449AXY
level=info ts=2019-10-15T11:30:13.414524465Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571119200000 maxt=1571126400000 ulid=01DQ7AAGNR3YW4KE0JZ16E7VSJ
level=info ts=2019-10-15T11:30:13.4145516Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571126400000 maxt=1571133600000 ulid=01DQ7JCVJMGZKY88TTVF6Z9WX8
level=info ts=2019-10-15T11:30:13.728236906Z caller=head.go:509 component=receive component=tsdb component=tsdb msg="replaying WAL, this may take awhile"
level=info ts=2019-10-15T11:30:47.562607851Z caller=head.go:533 component=receive component=tsdb component=tsdb msg="WAL checkpoint loaded"
level=info ts=2019-10-15T11:30:53.447669188Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2493 maxSegment=2588
level=info ts=2019-10-15T11:30:58.981511175Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2494 maxSegment=2588
level=info ts=2019-10-15T11:31:04.501141802Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2495 maxSegment=2588
level=info ts=2019-10-15T11:31:10.169544723Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2496 maxSegment=2588

......

level=info ts=2019-10-15T11:40:25.17463596Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2584 maxSegment=2588
level=info ts=2019-10-15T11:40:31.55063322Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2585 maxSegment=2588
level=info ts=2019-10-15T11:40:32.134839757Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2586 maxSegment=2588
level=info ts=2019-10-15T11:40:32.13568359Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2587 maxSegment=2588
level=info ts=2019-10-15T11:40:32.136520863Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2588 maxSegment=2588
level=info ts=2019-10-15T11:40:48.050314426Z caller=head.go:509 component=receive component=tsdb msg="replaying WAL, this may take awhile"
level=info ts=2019-10-15T11:41:19.363551827Z caller=head.go:533 component=receive component=tsdb msg="WAL checkpoint loaded"
level=info ts=2019-10-15T11:41:26.103639804Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2493 maxSegment=2588
level=info ts=2019-10-15T11:41:31.860346412Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2494 maxSegment=2588
level=info ts=2019-10-15T11:41:37.503849905Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2495 maxSegment=2588
level=info ts=2019-10-15T11:41:43.180104605Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2496 maxSegment=2588

.......

level=info ts=2019-10-15T11:51:48.263074931Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2586 maxSegment=2588
level=info ts=2019-10-15T11:51:48.263503714Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2587 maxSegment=2588
level=info ts=2019-10-15T11:51:48.263827295Z caller=head.go:557 component=receive component=tsdb msg="WAL segment loaded" segment=2588 maxSegment=2588
level=info ts=2019-10-15T11:55:32.977551161Z caller=compact.go:495 component=receive component=tsdb msg="write block" mint=1571133600003 maxt=1571137701384 ulid=01DQ7M5MPT3ZVP0YGNVWZZBRX3 duration=3m26.870889547s
level=info ts=2019-10-15T11:55:32.977767127Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571104800000 maxt=1571112000000 ulid=01DQ6WK24Q2YT0FF2P4X9C24QQ
level=info ts=2019-10-15T11:55:32.977804379Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571112000000 maxt=1571119200000 ulid=01DQ73ESJB1ADEC1AJ53449AXY
level=info ts=2019-10-15T11:55:32.977831925Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571119200000 maxt=1571126400000 ulid=01DQ7AAGNR3YW4KE0JZ16E7VSJ
level=info ts=2019-10-15T11:55:32.977858102Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571126400000 maxt=1571133600000 ulid=01DQ7JCVJMGZKY88TTVF6Z9WX8
level=info ts=2019-10-15T11:55:32.977885957Z caller=repair.go:59 component=receive component=tsdb component=tsdb msg="found healthy block" mint=1571133600003 maxt=1571137701384 ulid=01DQ7M5MPT3ZVP0YGNVWZZBRX3
level=info ts=2019-10-15T11:55:33.274419251Z caller=head.go:509 component=receive component=tsdb component=tsdb msg="replaying WAL, this may take awhile"
level=info ts=2019-10-15T11:55:43.440394647Z caller=shipper.go:349 component=receive msg="upload new block" id=01DQ7M5MPT3ZVP0YGNVWZZBRX3
level=info ts=2019-10-15T11:56:06.821192263Z caller=head.go:533 component=receive component=tsdb component=tsdb msg="WAL checkpoint loaded"
level=info ts=2019-10-15T11:56:13.313346626Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2493 maxSegment=2589
level=info ts=2019-10-15T11:56:19.591774203Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2494 maxSegment=2589
level=info ts=2019-10-15T11:56:25.923561156Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2495 maxSegment=2589
level=info ts=2019-10-15T11:56:32.700377317Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2496 maxSegment=2589
level=info ts=2019-10-15T11:56:39.431858684Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2497 maxSegment=2589

..........

level=info ts=2019-10-15T12:06:15.766904275Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2586 maxSegment=2589
level=info ts=2019-10-15T12:06:15.767436341Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2587 maxSegment=2589
level=info ts=2019-10-15T12:06:15.767896116Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2588 maxSegment=2589
level=info ts=2019-10-15T12:06:15.768469372Z caller=head.go:557 component=receive component=tsdb component=tsdb msg="WAL segment loaded" segment=2589 maxSegment=2589
level=info ts=2019-10-15T12:06:37.956202426Z caller=receive.go:239 component=receive msg="tsdb started"
level=info ts=2019-10-15T12:06:37.9562544Z caller=prober.go:114 component=receive msg="changing probe status" status=ready
level=info ts=2019-10-15T12:06:37.95626502Z caller=receive.go:243 component=receive msg="server is ready to receive web requests."
level=info ts=2019-10-15T12:06:37.956699189Z caller=receive.go:347 component=receive msg="listening for StoreAPI gRPC" address=<IP_ADDRESS>:19219

@GuyCheung, this huge growth in WAL looks to me to be the same issue that #1654 fixes. Every time that the receive component triggers a flush, the WAL is replayed and written to a block but the WAL is never deleted. Only new samples are actually written to the block but ALL samples are processed. This means that the the receive component has to do way more work than necessary. If the receive component has correctly shut down and cleaned the WAL, there should be 0 replay cost when starting back up.

@GuyCheung now that #1654 has merged, could you test again using the image built from the commit?

@squat I have tried the new version which commit id is 48a8fb6e2f6a476bcffa508d6609a19847c695ef
but I got OOM on the 128GB memory hosts...  and the data folder size just about 6GB, could you help to look into this?

I shared the pprof/heap file to you: https://drive.google.com/file/d/1iKqfMD9brOXbt7mLqJCX689AhRPuzJ_N/view?usp=sharing

@squat I also tried to test the receive component with this patch - same story, but with small chunk - ~80 MB generated wal logs can't be replayed (single segment) - got OOM with 4GB memory limit on the container.

Does this continue to occur for you?

I am also seeing huge spikes in memory after a restart. 9GB becomes 93GB.  I have more details in https://github.com/thanos-io/thanos/issues/2107 (which I closed as a duplicate after finding I missed this issue), but sounds pretty similar to what everyone else is seeing.

This still happens with Thanos v0.11.0

This can largely be attributed to WAL replay cost of the Prometheus TSDB, which thanos-receive makes use of. This is being improved on Prometheus itself already, once merged there, it'll trickle down to here.

@brancz - can you point us to some existing Prometheus PR?

One example: https://github.com/prometheus/prometheus/pull/6679. There are more ideas in the pipeline once that work is completed.

Still valid for v0.12.1

Not necessarily a general solution (as it just pushes the problem out further), but latest version of prometheus TSDB should at least cut this problem in half: https://github.com/prometheus/prometheus/pull/7098

same problem for v0.12.2, restart receive, then oom

We are issuing a similar problem with our setup, we have Thanos-Receive to get metrics from 8 clusters, we are running the pods on 64GB memory VMs and it gets OOM Killed atleast once a day and we lose the data for atleast 2 hours. Is there  a way to circumvent this scenario?

stills valid for v0.17.2, after restart receiver component. OMM Killed

stills valid for v0.17.2, after restart receiver component. OMM Killed

same problem for v0.18.0, restart receive, then oom

I'm reopening this. It seems like there is still an issue. If we think this is not an issue. Let's convert this to a discussion and redirect users to the discussion for similar issues.
cc @brancz @squat @bwplotka

still happening

This is still happening on the latest release

Still happening on 0.24.0

Still happening on 0.29.0

still happening on 0.31.0


open_manipulator_p_simulations: 1.0.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository open_manipulator_p_simulations to 1.0.0-1:

upstream repository: https://github.com/ROBOTIS-GIT/open_manipulator_p_simulations.git
release repository: https://github.com/ROBOTIS-GIT-release/open_manipulator_p_simulations-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.0
previous version for package: null

open_manipulator_p_gazebo
* First release of the open_manipulator_p_simulations stack
* Contributors: Ryan Shim, YongHo-Na, HyeJong KIM

open_manipulator_p_simulations
* First release of the open_manipulator_p_simulations stack
* Contributors: Ryan Shim, YongHo-Na, HyeJong KIM

I am sorry for sending a PR failing. This is my first time trying Bloom.
I will check what mistake I made and close this PR.
Thank you,
Jaehyun


VS Code includes one or more invisible characters while working on my program.

Type: Bug
VS Code Version# 1.81.1 on Windows 10 x64
Compiler gives error for the following:
#include <stdio.h>
printf("\nMemory allocation error\n");
This happens pretty often with printf(). I did some changes in my program (in this instance, I deleted couple of REM lines), and it came up with the error message: "too few arguments" for all the printf statements!
I then did a "select all", cut the whole program, and paste it into a Notepad blank page. I then cut it from the Notepad and paste it back to VS Code workbench. The problem was gone, no more errors.
Obviously, there is a bug in VS Code that introduces invisible characters.
VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:22:42.175Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.91GB (19.82GB free)

Process Argv
--crash-reporter-id b5a2fca0-60b4-424b-a726-5d6682b3c5be

Screen Reader
no

VM
0%

Extensions (25)

Extension
Author (truncated)
Version

android-dev-ext
ade
1.3.2

gnu-debugger
chi
1.0.3

codeium
Cod
1.2.66

dart-code
Dar
3.70.0

flutter
Dar
3.70.0

gitlens
eam
14.2.1

vscode-firefox-debug
fir
2.9.8

c-cpp-runner
fra
8.1.0

vs-code-runner
Har
2.0.1

vscode-gnu-global
jay
0.3.5

Kotlin
mat
1.7.1

cmake-tools
ms-
1.15.31

cpptools
ms-
1.17.2

cpptools-extension-pack
ms-
1.3.0

notepadplusplus-keybindings
ms-
1.0.7

java
red
1.21.0

cmake
twx
0.0.17

vscode-lldb
vad
1.9.2

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

vscode-java-debug
vsc
0.53.0

vscode-java-dependency
vsc
0.23.1

vscode-java-pack
vsc
0.25.13

vscode-java-test
vsc
0.39.1

vscode-maven
vsc
0.42.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263cf:30792227
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
2e4cg342:30602488
f6dab269:30613381
vscrp:30673768
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofa:30804715
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30812749

/confirmPlease

Please diagnose the root cause of the issue by running the command F1 > Help: Troubleshoot Issue and following the instructions. Once you have done that, please update the issue with the results.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

I did F1, etc. A reporting window opened up. But when I click on `Preview on GitHub' button, it opens a 'Windows Explorer' for me to choose a file(?). So, I can't get past the Issue Reporter window. There's no 'Report' button. I'm stuck. Therefore, I'm writing here:
I hi-light a word (for instance, printf) and do a Ctrl+F to find them;
I do some changes;
I leave the FIND active;
I then click on the triangle at the upper right corner of the screen to debug my code, and the following non-sense error pops-up:
PS E:\DIR> cd "e:\DIR" ; if ($?) { gcc tempCodeRunnerFile.c -o tempCodeRunnerFile } ; if ($?) { .\tempCodeRunnerFile }
tempCodeRunnerFile.c:1:1: error: expected '=', ',', ';', 'asm' or 'attribute' at end of input
1 | printf
| ^~~~~~

BTW, I no longer do copy-paste and back. I close FIND, I click on an empty line, and I hit compile again. It works !


fix: compatibility with types/react 18.2.22

chore(deps): update to latest versions
refactor: make types more compatible with React
chore: remove leftover dep

This moves us away from framework-agnostic types in the Story definition, but since the project is practically coupled with React, I think it's ok for now, until we focus on providing support for other frameworks.

@itsjavi I tested the main branch again, so far no type errors and forwardRef is working great!


commented unit test and fixed context.

Fixed Extension Context type.
Commented unit test that was breaking other unit tests on docs-markdown.

/azp run


Status, Details, and List rayclusters CLI Functions

Issue link
Closes #240
What changes have been made

Added list rayclusters details raycluster and status raycluster functions in the CLI
Added list_clusters_all_namespaces to list all RayClusters in all the namespaces in a Kubernetes Cluster

Verification steps
After building SDK, see list of commands using codeflare

list rayclusters for listing, optionally specifying namespace or --all
status raycluster specifying name as an argument and namespace as an option
details raycluster specifying name as an argument and namespace as an option

There are also unit tests for these functions to be run
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[x] Manual tests
[ ] Testing is not required for this change

@Maxusmusti @carsonmh  what about using cluster.get_current_namespace() instead of requiring a namespace? This should just default to the current context's namespace.


SOLR-16427: Enable error-prone PatternMatchingInstanceof rule

https://issues.apache.org/jira/browse/SOLR-16427
Description
With the new errorprone rules and starting from 16+ we can use pattern-matching for instanceof.
Solution
This PR enables PatternMatchingInstanceof and applies auto-refactoring from IntelliJ for pattern-matching cases.
Note that these changes are not backwards compatible (branch_9x) as the refactored code makes use of a JDK 16 feature.
Tests
No tests were added or removed. Tests with pattern-matching improvements were refactored accordingly.
Checklist
Please review the following and check all that apply:

[X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[X] I have created a Jira issue and added the issue ID to my pull request title.
[X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
[X] I have developed this patch against the main branch.
[X] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Waiting for https://github.com/apache/solr/pull/2877 to rerun the checks and merge afterwards.


Make /products and /organizations endpoints authenticated only

Now that creators discovery is not really a thing anymore, we should rework the /products and /organizations endpoints so they are targetted only at the creators themselves, i.e. working only on the products/organizations they own.
This will dramatically ease things in terms of implementation and API design. Typically, I'm currently struggling with custom fields, because I don't really want to output them in the products schema for the anonymous users.

What about storefronts? Since we easily know upfront which organizations have storefront enabled, we can easily create a /storefront endpoint which will return all in one:

Organization data
Products data

If the organization doesn't have storefront enabled, return 404. No other way to discover products.
Bonus point: it'll make the storefront load faster.

Fully agree and really like this approach @frankie567. Go for it 👏


adjust the translation of zh-CN

Some dispensable improvements for translation of zh-CN.
Changed the some capitalization, spaces, and translation of a few sentences.

Thanks!


do not skip updating rtt view ubo if multiple scenes are active

testPG: #01KDKN

One test is failing

Up? :) @TrevorDev

It appeared to be a 503 on one of the servers hit for a texture unrelated to the PR. I reran it and it passed now.

Looks like we are rate limited on those API, we should try to move the storage to our cdn for the scene ?


update default console version

Updates Console default version to v2.7.0

Closing because of https://github.com/redpanda-data/helm-charts/pull/1465


Fix all DeprecationWarning: invalid escape sequence

Hello,
Here is a small clean-up patch to prevent those warnings:
httpbin/helpers.py:26: DeprecationWarning: invalid escape sequence \_
  ASCII_ART = """
httpbin/helpers.py:71: DeprecationWarning: invalid escape sequence \
  ANGRY_ASCII ="""
httpbin/helpers.py:438: DeprecationWarning: invalid escape sequence \s
  match = re.search('\s*(W/)?\"?([^"]*)\"?\s*', part)

Fixes #602.

Gentle ping :)


GitHub Enterprise Server: context.github.graphql() fails with 406

Bug Report
Current Behavior
When sending a GraphQL Query before sending any other request in an event handler, Probot sends a request to [GHE_HOST]/api/app/installations/[installation id]/access_tokens instead of [GHE_HOST]/api/v3/app/installations/[installation id]/access_tokens. The GHES instance responds with a 406 error
module.exports = (app) => {
  app.on("push", ({ github }) => {
    await github.graphql(`query {
      viewer {
        login
      }
    }`)
  });
};

See ttps://probot-talk.slack.com/archives/C6S4FC8AF/p1603208624022600 /cc @pjbreaux
Environment

Probot version(s): 10.9.3
GitHub Enterprise Server

Here is a test case to reproduce the problem with the underlying @octokit libraries:
https://runkit.com/gr2m/probot-probot-1386

You'll have to update your dependency tree in order to get the latest version of @octokit/core (3.1.3). When in doubt, try rm -rf package-lock.json node_modules && npm install


fix(amplify-cli-core):new-line escape sequence made os-specific

Description of changes
Fixed issue of non-matching substrings in amplify-cli-core package
(Error was being thrown due \n not being recognized as a valid newline escape sequence character in Windows)
Fixed the issue by making \n os-specific in nature
Issue #, if available

#7813
Description of how you validated changes

cd packages/amplify-cli-core
yarn test
(Successful completion of tests)

Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #7814 (56b8220) into master (af66811) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7814   +/-   ##
=======================================
  Coverage   52.71%   52.71%
=======================================
  Files         550      550
  Lines       27702    27702
  Branches     5361     5361
=======================================
  Hits        14604    14604
  Misses      12115    12115
  Partials      983      983

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af66811...56b8220. Read the comment docs.


Pagination for objectify implementation and fix flat=True and objectify=True usage

Hi, Matt!

If flat and objectify params set as True,  DjangoRestMultipleModels tried to append datum to the dict "result" through usage "append" method. Obviously use objectify=True and flat=True together is an incorrect approach, i've add checking this.

We use pagination only for certain querysets (such as listing results) and we should't paginate additional querysets (such as filters, features for results, etc). So I see no reason to maintain our own approach for this and add it to code.

Hey @evgenosiptsov!
Thanks for the updates.  Unfortunately, I had to remove the pagination before formatting when objectify=True -- I think that might have only worked with your custom pagination, but running the queryList through pagination before formatting otherwise meant that querysets weren't being executed when objectify=True in all my tests.
The flat/objectify checks are much appreciated though!


feat(playback-core, mux-player): Add support to removeTextTrack. Remo…

…ve all identified tracks on hls destroy. Add methods to mux-player.
Adding for forward-looking use cases with timed metadata.

Since we're adding convenience methods to add and remove tracks, should we also provide a way to get a list of tracks?

Yeah good call. I'll add that.


Support Countdown Mode

Overview
In Countdown mode, there is a bug in the underlying library that causes the Confirm button of this component to not work when a value is first selected by the picker. You have to move the wheel at least twice. This PR implements the workaround suggested in that issue.
Although this fixes the problem for the main use case, it unfortunately does not fix it completely. There is a use case (hopefully rare) where, if the user spins the picker to 0 hours, 0 minutes, iOS will immediately advance the picker to 0 hours 1 minute and the Confirm button won't work the next time you move the picker.... it has to be moved at least twice. I haven't been able to figure out a workaround for this.
Test Plan
I modified the example component, adding a Duration (countdown) button for iOS only (the underlying component does not support countdown on Android.) I ran the example on an iOS device and it works fine. I also ran on an Android device to make sure I didn't break anything there.

@chetstone Just wanted to say thank you for adding this workaround. I've been stuck on this problem for a couple days now and now my app is working as it should! Thank you!


Add hasAccess method

Added a has Access method, this delegates to an internal _hasAccessToRoute method which will can then be called in both the set and resolve methods.
Added tests for the same.

Leave a comment


Incorrect translation placement

When an InfoPlist.strings is present, the contents of Localizable.strings (in /tmpstrings) while get appended to InfoPlist.strings.
#79 Fixes the issue

Closing this since #79 is merged.


adding markdown file

Here's my test stuff @ebeshero

Hey Grason Nice job with your test. This is Test 5 of GitHub

@A-Little-Coconut I'm finally merging in old branches from the Git Test. Good work with round 3! You can safely delete your tefftBranchTest3 on your local copy of the textAnalysis-Hub repo if you haven't done so already.


[AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers'

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
Module Name
avm/res/api-management/service
(Optional) Module Name if not listed above
avm/res/api-management/service
(Optional) Module Version
No response
Description
Please add the creation of Microsoft.ApiManagement/service/loggers so that API Management can be monitored and logged.
For example (azd): https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/gateway/apim.bicep#L61
CC: @jongio
(Optional) Correlation Id
No response

Assigning to myself due to issue with auto group assignment.

@tony-box - Do you have an ETA for this?

@jongio There is a question here that I need to confirm with you.
For AVM’s APIM module, compared with the files in infra/core, only the Microsoft.ApiManagement/service/loggers function is missing.
However, compared with the infra/app/apim-api.bicep file currently used by this todo-java-mongo template, the Microsoft.ApiManagement/service/apis/diagnostics function is also missing.
Regarding this issue, do you think it is necessary to add the missing feature Microsoft.ApiManagement/service/apis/diagnostics to the issue https://github.com/Azure/bicep-registry-modules/issues/1124?


Expose install/upgrade as a variable to stack template

This would make writing stack files so much easier, some images (mongo, stolon etc..) need different options for initial installation vs upgrade.

I think it would have to be service specific, otherwise for example adding mongo to a stack would be considered an upgrade.

Sounds like something that should be dealt with in the Docker images for those kinds of services. Things like looking for a /var/lib/postgresql/INSTALLED_VERSION flag-file from the persistent data volume or something, in order to perform the in-place upgrade on the service restart?

Not all things can be expected to be inside an image. And I was only talking about stack level install vs upgrade. If stack is modified and redeployed it's still an upgrade (but it might be an install or removal of a service). Those are kinda two different things, although they are related.
For example I would like a stack to prompt postgres version on install. Postgres version cannot be changed afterwards so I would like to block that prompt if user is doing an upgrade. There are many other use cases also where this kind of variable would be very handy.


Crowd Response by CrowdStrike Added

why direct link to a zip file?

Other links basically all arrive at a specific page for a single tool. CrowdStrike only offers a generic page for all its tools, so user has to look for it. Thought this was appropriate, but linking to generic page is also possible
Sent from my Windows Phone

From: Meir<EMAIL_ADDRESS>Sent: 6-12-2015 08:57
To<EMAIL_ADDRESS>Cc: Herman<EMAIL_ADDRESS>Subject: Re: [awesome-incident-response] Crowd Response by CrowdStrike Added (#26)
why direct link to a zip file?

Reply to this email directly or view it on GitHub:
https://github.com/meirwah/awesome-incident-response/pull/26#issuecomment-162285531

It seems that all their tools are offered as services... which tool exactly is the downloaded tool?

Just replaced the link to the community tools page. There are some non-IR tools there, like Heartbleed scanner. Still an interesting page for security professionals.


bring containers up to date

eg:
julia initialization failed
ERROR: Requests not found while loading /home/beaker/src/core/config/plugins/eval/ipythonPlugins/julia/beaker.jl, in expression starting on line 18 while loading In[1], in expression starting on line 1

016-01-09 15:50:56 (1.38 MB/s) - '/root/.julia/v0.4/MbedTLS/deps/downloads/mbedtls-2.1.1-apache.tgz' saved [
1829955/1829955]
INFO: Done downloading file https://tls.mbed.org/download/mbedtls-2.1.1-apache.tgz
INFO: Attempting to Create directory /root/.julia/v0.4/MbedTLS/deps/src
INFO: Attempting to Create directory /root/.julia/v0.4/MbedTLS/deps
INFO: Directory /root/.julia/v0.4/MbedTLS/deps already created
INFO: Changing Directory to /root/.julia/v0.4/MbedTLS/deps/src/mbedtls-2.1.1
===============================[ ERROR: MbedTLS ]===============================
LoadError: could not spawn cmake -DUSE_SHARED_MBEDTLS_LIBRARY=On .: no such file or directory (ENOENT)
while loading /root/.julia/v0.4/MbedTLS/deps/build.jl, in expression starting on line 68

LoadError: precompile(true) but require failed to create a precompiled cache file
while loading /home/beaker/.julia/v0.4/IJulia/deps/build.jl, in expression starting on line 2

https://github.com/twosigma/beaker-notebook/commit/9341e997eb334571c4a1fcfb96dc9b4b5b2815a5
https://github.com/twosigma/beaker-notebook/commit/c1c4d7852af5980fc5440e1cd9652daf0d48c336


Autosuggest Correction

Fixes a bug in the autosuggest trigger that was causing the defaults not to set correctly when the autosuggest link was used.  As a result, no expanders would be selected.
To Test:
http://mike-koha.ebsco-gss.net/
If you need login credentials please let me know.
Search for "presbaterian"
You should get a "Did you mean presbyterian" option on the next page.
Click the Did you mean link.
Note that the default expanders and limiters are still selected.

also looks good to me


Play commands not ready when bot says they are

Play commands not ready when bot says they are
Works immediately.

!loop
!queue
etc.

Works after maybe 30-45 seconds,

!play
!playskip

good job finding the bug @svante-jonsson

will be fixed for 2.0


23 add login admin

Resolves #023
Description

Appropriate colours and typography is used
Only works when using an authenticated user in Firebase
Sign out button works

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

We double checked that authentication works as intended
Correct email but incorrect password prevents login and gives a warning message (Vice-versa)

Screenshots
Login page when first rendered:

When incorrect password is provided:

Note:
When testing feature
username<EMAIL_ADDRESS>password: kiwanis2022

Hey @topanb11 and @rajagoat! I went through and unresolved some comments left by @Narigo and @BogDAAAMN that should be addressed.
Some things I'd like to highlight...
If I remember correctly, I think code reviews are a new thing to some of this group so I say the following to help you all learn, not place blame, shame, or call anyone out. 🙂 When your code has been reviewed, it is typical to continue the conversation by replying to comments made by the reviewers, especially when they ask a question or for clarification on something. If instead they leave a suggestion for a change, thought, or praise, feel free to use an emoji (I like 👍 and ❤ ) to signal acknowledgment before implementing the change and/or moving on. Then the reviewer who originally wrote the comment is the one to resolve the conversation, as they'll be alerted that a change was made to the code or their comment was acknowledged. Once all the conversations have been resolved, that is when the code is ready to be merged into the main branch! 🎉
A few comments were made regarding npm packages you're using that are still waiting to be addressed. There were a couple about including both @material-ui and @mui packages (here) and (here), one about versioning your TypeScript (here), and another about the use of formik and yup (here).
I cannot stress enough the importance of decision-making behind the use of third-party libraries. With every new npm package you pull into your code, it adds much more potential for a security breach. With an app that handles people's personal information, that's something we really want to be aware of. Setting a specific version number for each package is one way to mitigate these threats. Another thing to consider is the size of your codebase. Right now you're pulling in two packages that do the same thing, @material-ui and @mui. By including them both, you're doubling the load with no added benefit. This is what @Narigo was getting at with his comment about formik and yup.
Lastly, @BogDAAAMN offered to pair up to program in his review in this PR and another one. I highly suggest you take him up on his offer. Pairing is a large part of programming so the more experience you have with it the better!
Thank you everyone for your hard work! It's much appreciated by all of us from Ruby for Good!

Thanks for the feedback @meg-gutshall! @topanb11 and I appreciate it, as we are somewhat new to this process as you rightly said. We will make sure to respond to all comments by the reviewers moving forward as you have suggested, and will wait for them to resolve it as well. If time permits, we will also definitely take up @BogDAAAMN's offer to pair program.
A sincere thanks again to you, @BogDAAAMN, and @Narigo for your comprehensive feedback throughout the process!


setSubmittedOnChange() for DateRangePicker

Is there a possibility of adding a method similar setSubmittedOnChange() of SelectFilterConfig to the DateRangePicker class?
I want the grid to update immediately after selecting the date range, without having to click on refresh.

Yep. If you want to implement is as soon as possible, I will appreciate if you will do it yourself & create pull request. Than I will check changes, accept it and publish new grids release.

Released in v0.9.12


Fail to run test in Pytest.

Describe the bug

Python from VS
Steps to Reproduce

Create Python Application Project.
Add test_1.py file with code

def test_passing():
    assert 42 == 42
def test_failure():
    assert 42 == -13

Set Test framework as "pytest" in python project properties page.
Open TE with the Test > Windows > Test Explorer menu command
Run Tests.

Expected behavior
Tests can be run successfully.
Additional context and screenshots
The test was skipped.

Logs

Output for General in the Output panel

========== Starting test run ==========
cd C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\
set PYTHONPATH=C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\
"C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python.exe" "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py" C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\ pytest "" 0 "" "" dummyfilename .\test_1.py::test_failure .\test_1.py::test_passing --junitxml=C:\Users\vting\source\repos\PythonApplication6\TestResults\junitresults_9bc9d3ef-2301-4c1f-a1be-cb0ecd8ad0f4.xml --rootdir=C:\Users\vting\source\repos\PythonApplication6\PythonApplication6 -o junit_logging=all -o junit_family=xunit1
Traceback (most recent call last):
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 189, in <module>
    main()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 30, in main
    run(testRunner, coverage_file, test_file, args)
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 119, in run
    patch_translate_non_printable()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 136, in patch_translate_non_printable
    translate_non_printable =  getattr(_pytest.compat, "_translate_non_printable")
AttributeError: module '_pytest.compat' has no attribute '_translate_non_printable'
Results for pytest not found C:\Users\vting\source\repos\PythonApplication6\TestResults\junitresults_9bc9d3ef-2301-4c1f-a1be-cb0ecd8ad0f4.xml
========== Test run finished: 2 Tests (0 Passed, 0 Failed, 2 Skipped) run in 272 ms ==========

If you enter pytest==8.0.2 and run the pip install, the error should be gone. It's an issue within that pytest version.

As clearly shown in the screenshotted stacktrace, this is an issue with PTVS accessing pytest private API which has moved. It should not do that at all ideally, but if it does, it's not pytest's fault if things break - that's why it's private API in the first place.


Add BOT Token

Token Information

Project official website: https://www.botpla.net/

Project official social:

Twitter: https://twitter.com/BotPlanet_

Telegram: https://t.me/botplanetnews

Instagram: https://www.instagram.com/bot.planet/

Medium: https://botplanet.medium.com/

Github: https://github.com/BOTDeFi

Bitcointalk: https://bitcointalk.org/index.php?topic=5357949.msg57845384#msg57845384

Discord: https://discord.com/invite/botplanet

Verification of Token
Link to source contract in the footer of web page.

All good. Thanks!


fixes #542 missing project phase in French PDF

Fixes #542

Project phase Design was not showing up in French. It's because the field was only entered in one language, instead of providing a main and alternate language entry. Also change Design to "Conception" in French, as in French, design, is an "anglicisme" and refers to the esthetic qualities, not the act of defining the structure etc.


add .launch files to .gitignore

As wonderful as it is to have a matching launch configuration automagically generated when gradle eclipse is run, it not being ignored by the .gitignore file is rather annoying. Zidane told me to blame @Minecrell for this, which I gladly do.
Same Issue goes for Sponge (and I suppose SpongeVanilla)

There needs to be something else going wrong then, I added it in https://github.com/SpongePowered/SpongeCommon/commit/c21f90b9e71dc939c7fa3003e58ab8dcb0c87544#diff-a084b794bc0759e7a6b77810e01874f2R77

My bad, I noticed this issue on sponge and immediatly assumed it was on SpongeCommon as well. Should I reopen this in the Sponge project? :D
I have now double-checked and the line is only missing in Sponges .gitignore. SpongeVanilla and SpongeCommon are fine.

Oh I see, my bad - seems like I missed it there.


Type Error in creating Subpopulation

Describe the bug
I ran this code mentioned in the README.md
To Reproduce

Code snippet:
  from robustnessgym import Spacy, ScoreSubpopulation

 def length(batch, columns):
     """
     Length using cached Spacy tokenization.
     """
     column_name = columns[0]
     # Take advantage of previously cached Spacy informations
     tokens = Spacy.retrieve(batch, columns, proc_fns=Spacy.tokens)[column_name]
     return [len(tokens_) for tokens_ in tokens]

 # Create a subpopulation that buckets examples based on length
 length_subpopulation = ScoreSubpopulation(intervals=[(0, 10), (10, 20)],
                                           score_fn=length)

 dataset, slices, membership = length_subpopulation(dataset, columns=['question'])
 # dataset is updated with slice information
 # slices is a list of 2 Slice objects
 # membership is a matrix of shape (n x 2)

Errors and traceback '....'
 ---------------------------------------------------------------------------
 TypeError                                 Traceback (most recent call last)
 <ipython-input-4-3a673fb6fabf> in <module>
      14                                           score_fn=length)
      15
 ---> 16 dataset, slices, membership = length_subpopulation(dataset, columns=['question'])
      17 # dataset is updated with slice information
      18 # slices is a list of 2 Slice objects

 /opt/conda/envs/robustnessgym/lib/python3.8/site-packages/robustnessgym/slicebuilders/slicebuilder.py in __call__(self, batch_or_dataset, columns, mask, store_compressed, store, num_proc, *args, **kwargs)
     132                 )
     133             # Slice a batch
 --> 134             return self.process_batch(
     135                 batch=batch_or_dataset,
     136                 columns=columns,

 /opt/conda/envs/robustnessgym/lib/python3.8/site-packages/robustnessgym/slicebuilders/subpopulation.py in process_batch(self, batch, columns, mask, store_compressed, store, *args, **kwargs)
      52
      53         # Apply the SliceMaker's core functionality
 ---> 54         slice_membership = self.apply(slice_membership, batch, columns, *args, **kwargs)
      55
      56         # Store these slice labels

 /opt/conda/envs/robustnessgym/lib/python3.8/site-packages/robustnessgym/slicebuilders/subpopulations/score.py in apply(self, slice_membership, batch, columns, *args, **kwargs)
     186         ), "Must have exactly one score per example."
     187
 --> 188         return self.bin(scores=scores)
     189
     190

 /opt/conda/envs/robustnessgym/lib/python3.8/site-packages/robustnessgym/slicebuilders/subpopulations/score.py in bin(self, scores)
      61         # Bin the scores
      62         return (
 ---> 63             (self.left_limits <= scores[:, np.newaxis])
      64             & (scores[:, np.newaxis] <= self.right_limits)
      65         ).astype(np.int32)

 TypeError: '>=' not supported between instances of 'int' and 'NoneType'

System Information

OS: Linux
Versions for RG and relevant dependencies :  robustnessgym (v0.0.2), spacy (v2.3.5)

Hi, thanks for the bug report -- we've been addressing a bunch of issues behind the scenes, and should have good documentation and an updated README for RG in the next 7-10 days.
In the meantime, I recommend,

upgrading to the latest RG version (0.0.3) which makes some changes to our API (pip install --upgrade robustnessgym)

Here's a code snippet that is tested with v0.0.3, let me know if you have trouble with this.
from robustnessgym import Spacy, ScoreSubpopulation, Identifier, Dataset
from robustnessgym.core.decorators import prerequisites

dataset = Dataset.load_dataset('boolq', split='validation')
# `datasets` has made some updates, temporary workaround to set the dataset identifier that we'll fix in v0.0.4
dataset._identifier = dataset.identifier.without('version')(version=dataset.info.version.version_str)

spacy = Spacy()
dataset = spacy(dataset, ['question'])

def length(batch, columns):
    """
    Length using cached Spacy tokenization.
    """
    column_name = columns[0]
    # Take advantage of previously cached Spacy informations
    tokens = Spacy.retrieve(batch, columns, proc_fns=Spacy.tokens)
    return [len(tokens_) for tokens_ in tokens]

# Create a subpopulation that buckets examples based on length
# `prerequisites` is a temporary workaround to specify that `length` requires Spacy to be cached
# this will not be required in v0.0.4
length_subpopulation = prerequisites(Spacy)(ScoreSubpopulation)(
    identifiers=[Identifier('0-10'), Identifier('10-20')],
    intervals=[(0, 10), (10, 20)],
    score_fn=length,
)

# v0.0.3 no longer modifies `dataset`
sls, mat = length_subpopulation(dataset, columns=['question'])


Macro: System threats R-groups as connection points and ignores real connection points (rakes)

Issue found in the context of testing #3580
Steps to Reproduce

Switch to Macromolecules view
Load this file: ConnectionPoints.zip (unzip first)
Select Single Bound tool

Start to connect F1 and F2 monomers
Select Connection Points dialog appears - this is ok, expand it to large mode

Actual behavior
Note that my custom monomer (F2) has many R-groups and two connection points (primary and secondary) in micro view

but in Select Connection Points dialog - it ignores real connection points (rakes) and threats R-groups as connection points

Expected behavior
System should show two connection points for my custom monomer and ignore R-groups
Desktop (please complete the following information):

OS: win10
Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].

Approved with @olganaz and @AlexanderSavelyev that we use rglabels as monomer attachment points in macro mode.
One thing which will be discussed further is to create requirements for rgroup attachment points in macro mode. We need to decide how we are going to display them.
Closing the issue.

Ok


Submit additional data for server-side processing

Is it possible to submit additional data (eg. status of a dropdown) for further processing on server-side?

YES, see this demo for ref.

thanx


Add chips

I know this has been nixed a few times, but the time is right to add chips to the UI toolbox. Would make life a lot easier for forms development.
https://material.io/components/chips

Just the HTML and CSS, or JS to go with it for specific implementations?

Thank you for the fast reply.
HTML and CSS would be great, but as long as it plays nicely with jQuery I would be happy.
An ideal solution would be one that would store an ID, so that you could have a contact chip that displays the person's name while holding their email address.

You could make this my birthday and Christmas gift this year.

i believe the "close" button needs JS and looks like he works as a checkbox like buttons with toggle state

Is there anything I can do to help? Or is this all under control?
Awesome idea!

Just the HTML and CSS, or JS to go with it for specific implementations?

I know you have a lot of other components to focus on right now, but I'd love to find this under the Christmas tree.

So
Chip Style
Icon on the front
Text label
optional close button/icon
optional checkbox state?

So
Chip Style
Icon on the front
Text label
optional close button/icon
optional checkbox state?

Yes! I think that's it.

I think I can work on that.

Any updates to this?

I couldn't do it. Can someone else take it up

Had a go at making what could be the design document for the chip component.
 Please tell me that this is still needed.

Love the design work so far... my only comment is that chips should have a container so that they wrap. The container should also have an option for placeholder text. Like if a person is typing, the inputs can be added as chips.