Has anyone been able to write the delaunator-js demo in C++?

The demo here  lists a bunch of code that works with the JS version of this lib, but because of what I'm assuming is type differences across the implementations, porting it isn't straight forward. Has anyone been able to render the voronoi edges like the js demo does?

Here's my attempt incase anyone knows what the issue is, but I'd definitely love to look at someone else's completed version because mine is broken. Attached is what it renders out too (red lines are the delauntor's coords indexes by triangles, and the circles are the circumcenters, but the blank is supposed to be the vornoi edges, or even triangle edges).

    using edge_t = size_t;
    using v_double_t = std::vector<double>;
    using double_pair_t = std::pair<double, double>;
    using v_double_pair_t = std::vector<double_pair_t>;

    auto triangleOfEdge = [](edge_t e) {
        return (edge_t)std::floor(((size_t)e) / (size_t)3.0);
    };

    //returns 3 edge IDs
    auto edgesOfTriangle = [](edge_t t) -> std::vector<edge_t> {
        return std::vector<edge_t>{3* t, 3* t + 1, 3 * t + 2};
    };

    //finds 3 points for a given triangle id
    auto pointsOfTriangle = [edgesOfTriangle](const delaunator::Delaunator& delaunator, edge_t tri_id) ->std::vector<size_t> {
        auto edges = edgesOfTriangle(tri_id);

        std::vector<size_t> points;
        auto find_tri_for_edge = [delaunator](edge_t e) -> size_t{ return delaunator.triangles[e]; };
        std::transform(edges.begin(), edges.end(), std::back_inserter(points), find_tri_for_edge);

        return points;
    };

    auto edgesAroundPoint = [nextHalfEdge](const delaunator::Delaunator& delaunator, edge_t start) {
        std::vector<edge_t> result;

        edge_t incoming = start;
        do {
            result.push_back(incoming);
            const edge_t outgoing = nextHalfEdge(incoming);
            incoming = delaunator.halfedges[outgoing];
        } while (incoming != (edge_t)-1 && incoming != start);

        return result;
    };

    auto triangleCenter = [pointsOfTriangle](v_double_pair_t points, delaunator::Delaunator& delaunator, edge_t tri_id) -> std::pair<double, double>
    {
        auto tri_points = pointsOfTriangle(delaunator, tri_id);
        std::vector<std::pair<double, double>> vertices{};
        std::transform(tri_points.begin(), tri_points.end(), std::back_inserter(vertices), [&points](edge_t tri_point) {
            return points[tri_point];
        });

        auto result = delaunator::circumcenter(
           vertices[0].first, vertices[0].second,
           vertices[1].first, vertices[1].second,
           vertices[2].first, vertices[2].second
        );
        return std::pair<double, double>(result.first, result.second);
    };

    auto forEachVoronoiEdge = [&](v_double_pair_t points, delaunator::Delaunator& delaunator, std::function<void(edge_t, double_pair_t, double_pair_t)> callback) {
        for (auto e = 0;  e < delaunator.triangles.size(); e++) {
            if (e < delaunator.halfedges[e]) {
                auto pt = triangleOfEdge(e);
                auto p = triangleCenter(points, delaunator, pt);
                auto qt = triangleOfEdge(delaunator.halfedges[e]);

                //this seems to be a bug, qt should never be higher than 10k
                if (qt > 10000) {
                    auto qwe = delaunator::INVALID_INDEX;
                    //__debugbreak();
                    continue;
                }
                auto q = triangleCenter(points, delaunator, qt);
                callback(e, p, q);
            }
        }
    };

Figured out the issue with mine, I was missing a * 2 when looking into the coords which makes sense. I'll close this and leave the code for anyone else looking to have a demo port (after some tweaking to my pasted in code, I'm sure)
    auto nextHalfEdge = [](edge_t edge) { return (edge % 3 == 2) ? edge - 2 : edge + 1;  };

    auto triangleOfEdge = [](edge_t e) {
        return e / 3;
    };

    //returns 3 edge IDs
    auto edgesOfTriangle = [](edge_t t) -> std::vector<edge_t> {
        return std::vector<edge_t>{3* t, 3* t + 1, 3 * t + 2};
    };

    //finds 3 points for a given triangle id
    auto pointsOfTriangle = [edgesOfTriangle](const delaunator::Delaunator& delaunator, edge_t tri_id) ->std::vector<size_t> {
        auto edges = edgesOfTriangle(tri_id);

        std::vector<size_t> points;
        auto find_tri_for_edge = [delaunator](edge_t e) -> size_t{ return delaunator.triangles[e]; };
        std::transform(edges.begin(), edges.end(), std::back_inserter(points), find_tri_for_edge);

        return points;
    };

    auto edgesAroundPoint = [nextHalfEdge](const delaunator::Delaunator& delaunator, edge_t start) {
        std::vector<edge_t> result;

        edge_t incoming = start;
        do {
            result.push_back(incoming);
            const edge_t outgoing = nextHalfEdge(incoming);
            incoming = delaunator.halfedges[outgoing];
        } while (incoming != (edge_t)-1 && incoming != start);

        return result;
    };

    //circumcenter of triangle
    auto triangleCenter = [pointsOfTriangle](v_double_t points, delaunator::Delaunator& delaunator, edge_t tri_id) -> std::pair<double, double>
    {
        auto tri_points = pointsOfTriangle(delaunator, tri_id);
        std::vector<std::pair<double, double>> vertices{};
        std::transform(tri_points.begin(), tri_points.end(), std::back_inserter(vertices), [&points, &delaunator](edge_t tri_point) {
            return double_pair_t{delaunator.coords.at(tri_point*2), delaunator.coords.at(tri_point*2 + 1)}; //this is the * 2 that was missing
        });

        auto result = delaunator::circumcenter(
            vertices[0].first, vertices[0].second,
            vertices[1].first, vertices[1].second,
            vertices[2].first, vertices[2].second
        );
        return std::pair<double, double>(result.first, result.second);
    };

    auto forEachVoronoiEdge = [&](delaunator::Delaunator& delaunator, std::function<void(edge_t, double_pair_t, double_pair_t)> callback) {
        //forEachTriangleEdge
        //for (unsigned e = 0;  e < delaunator.triangles.size(); e++) {
        //    auto halfedge = delaunator.halfedges[e];
        //    if (e < halfedge && halfedge != delaunator::INVALID_INDEX) {
        //        try{
        //            auto p = double_pair_t{delaunator.coords.at(delaunator.triangles[e] * 2), delaunator.coords.at(delaunator.triangles[e] * 2 + 1)};
        //            auto q = double_pair_t{delaunator.coords.at(delaunator.triangles[nextHalfEdge(e)] * 2), delaunator.coords.at(delaunator.triangles[nextHalfEdge(e)] * 2 + 1)};
        //            callback(e, p, q);
        //        }
        //        catch (std::out_of_range& ex) { my_print(L"invalid"); }
        //    }
        //}

        ////forEachVoronoiEdge
        for (unsigned e = 0;  e < delaunator.triangles.size(); e++) {
            auto halfedge = delaunator.halfedges[e];
            if (e > halfedge && halfedge != delaunator::INVALID_INDEX) {
                edge_t pt = triangleOfEdge(e);
                double_pair_t p = triangleCenter(delaunator.coords, delaunator, pt); //now im passing in the coords from delaunator

                edge_t qt = triangleOfEdge(delaunator.halfedges[e]);
                double_pair_t q = triangleCenter(delaunator.coords, delaunator, qt);

                callback(e, p, q);
            }
        }
    };


feat: update assets

Automated Pull Request to update assets.

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/253e4a25-842c-4446-bd20-65f6c3d75264/artifact/32f3beaffcedf6f3/p/5d6c0295f41f19755965ec04ef208176

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/eea42a7f-ef90-4134-a5af-193890689825/artifact/12f039d5bebe3508/p/95a474d6eb19886bd781a8e2f2b15a60


Remove use of static fields in examples

Fixes #174

All examples seem to work, I'm not able to test examples/plugin though, since I'm missing a test.dll file.


Add extra field to AuthToken

I want to add more fields to the AuthToken how I do that?

I could really use a simple description field. It would be great if the model used for tokens could be made swappable or otherwise overridable in some manner.

This is now possible with https://github.com/James1345/django-rest-knox/pull/275.


STM32U5XX devices ADC12 extended calibration fails

Describe the bug

Extended calibration for ADC12 produces the wrong calibration values which leads to incorrect ADC readings from the peripheral.
Issue was adding in this PR: https://github.com/zephyrproject-rtos/zephyr/pull/75048
To Reproduce

Reproduction is extremely finnicky. The issue appeared and disappeared with changing code in completely unrelated places.

CPU is at 160 MHz.
ADC clock prescaler is 4.
Optimisation is set for size.

Expected behavior

ADC readings are correct.
Impact

ADC readings peripheral are sometimes offset from real voltage values. While offset is consistent, it's appearance is unpredictable. Impact is bad and continued use of ADC is untenable.
Environment (please complete the following information):

Ubuntu 22.04.2 LTS
Zephyr SDK 0.16.8
Zephyr 3.7.0

Additional context

The issue is already fixed in the STM32 HAL driver. This issue is identical to https://github.com/STMicroelectronics/STM32CubeU5/issues/29 and was fixed in https://github.com/STMicroelectronics/STM32CubeU5/issues/29#issuecomment-1708366862. This fix was later added to release 1.4.0 of their library.

Hi @FrankZShen
I've just pushed #78748 that reproduces what is done in the Cube. Could you test and let me know if that solves your problem?

Yes, that work fixes fit for me. 👍

Perfect, thanks for your feedback!


Use GitHub Action instead of Travis for CI

Signed-off-by: Tamal Saha<EMAIL_ADDRESS>

Tests are passing in my fork. You need to setup the token for codecov.io using repo secrets, if you still want to use this service.
https://github.com/wandrs/xormstore/runs/2750589075?check_suite_focus=true


SimpleDimensionLine - looks like Autodesk Forge

Description 📝
I want to integrate this tool looks like Autodesk Forge Measurement .

Suggested solution 💡
I can handle that, but i can not fork branch "big -restructure". And i want to access this function https://github.com/IFCjs/components/blob/big-restructure/src/core/Components/index.ts#L131 to make the width of line dimension none- change when we zoom out/in
Alternative ⛕
No response
Additional context ☝
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Hey @RyugaRyuzaki great idea! If you want to make it yourself, you should already be able to fork the main branch and start working on it 🙂 Will you start working on this? Otherwise, don't worry, we can do this ourselves. I agree that dimensions can be greatly improved.

We already have endpoints in our measurements! You can check them out in the tutorial. If you want to customize them, you can also create your own custom dimension components. Cheers


AssertionError: Inconsistent state: has_parent=False, has_rank=True

multi-machine,multi-gpu:
2022-05-21 09:28:21.116 [ERROR] Traceback (most recent call last):
2022-05-21 09:28:21.116 [ERROR]   File "/root/share/program/lama-main/bin/train.py", line 76, in
2022-05-21 09:28:21.116 [ERROR]     main()
2022-05-21 09:28:21.117 [ERROR]   File "/root/share/program/lama-main/saicinpainting/utils.py", line 154, in new_main
2022-05-21 09:28:21.177 [ERROR]     assert has_parent == has_rank, f'Inconsistent state: has_parent={has_parent}, has_rank={has_rank}'
2022-05-21 09:28:21.177 [ERROR] AssertionError: Inconsistent state: has_parent=False, has_rank=True
2022-05-21 09:28:21.608 [ERROR] Traceback (most recent call last):
2022-05-21 09:28:21.609 [ERROR]   File "/opt/aps/context/run.py", line 43, in
2022-05-21 09:28:21.609 [ERROR]     exec_code(cell_code,i)
2022-05-21 09:28:21.609 [ERROR]   File "/opt/aps/context/run.py", line 35, in exec_code
2022-05-21 09:28:21.610 [ERROR]     exec(code, globals)
2022-05-21 09:28:21.610 [ERROR]   File "1 cell", line 4, in
2022-05-21 09:28:21.654 [ERROR] Exception: exec failed
2022-05-21 09:28:21.655 [ERROR]
2022-05-21 09:28:21.655 [ERROR] During handling of the above exception, another exception occurred:
2022-05-21 09:28:21.656 [ERROR]
2022-05-21 09:28:21.656 [ERROR] Traceback (most recent call last):
2022-05-21 09:28:21.657 [ERROR]   File "/opt/aps/context/run.py", line 45, in
2022-05-21 09:28:21.657 [ERROR]     raise ExecutionError(sys.exc_info())
2022-05-21 09:28:21.658 [ERROR] main.ExecutionError: (<class 'Exception'>, Exception('exec failed'), <traceback object at 0x7fad01b89e10>)
2022-05-21 09:28:21,787 [ERROR] exit code is 1
root@dl-1655299666-pod-jupyter-6dd949c6b4-tgf65:~/.dllog/2022-05/ZITS_20220521092748#
how to fix this?

multi-machine,multi-gpu:
2022-05-21 09:28:21.116 [ERROR] Traceback (most recent call last): 2022-05-21 09:28:21.116 [ERROR] File "/root/share/program/lama-main/bin/train.py", line 76, in 2022-05-21 09:28:21.116 [ERROR] main() 2022-05-21 09:28:21.117 [ERROR] File "/root/share/program/lama-main/saicinpainting/utils.py", line 154, in new_main 2022-05-21 09:28:21.177 [ERROR] assert has_parent == has_rank, f'Inconsistent state: has_parent={has_parent}, has_rank={has_rank}' 2022-05-21 09:28:21.177 [ERROR] AssertionError: Inconsistent state: has_parent=False, has_rank=True 2022-05-21 09:28:21.608 [ERROR] Traceback (most recent call last): 2022-05-21 09:28:21.609 [ERROR] File "/opt/aps/context/run.py", line 43, in 2022-05-21 09:28:21.609 [ERROR] exec_code(cell_code,i) 2022-05-21 09:28:21.609 [ERROR] File "/opt/aps/context/run.py", line 35, in exec_code 2022-05-21 09:28:21.610 [ERROR] exec(code, globals) 2022-05-21 09:28:21.610 [ERROR] File "1 cell", line 4, in 2022-05-21 09:28:21.654 [ERROR] Exception: exec failed 2022-05-21 09:28:21.655 [ERROR] 2022-05-21 09:28:21.655 [ERROR] During handling of the above exception, another exception occurred: 2022-05-21 09:28:21.656 [ERROR] 2022-05-21 09:28:21.656 [ERROR] Traceback (most recent call last): 2022-05-21 09:28:21.657 [ERROR] File "/opt/aps/context/run.py", line 45, in 2022-05-21 09:28:21.657 [ERROR] raise ExecutionError(sys.exc_info()) 2022-05-21 09:28:21.658 [ERROR] main.ExecutionError: (<class 'Exception'>, Exception('exec failed'), <traceback object at 0x7fad01b89e10>) 2022-05-21 09:28:21,787 [ERROR] exit code is 1 root@dl-1655299666-pod-jupyter-6dd949c6b4-tgf65:~/.dllog/2022-05/ZITS_20220521092748#
how to fix this?

Hi, did you solve this problem?

did you find a solution?

same problem

same problem

Are you using Slurm based HPC?


Add basic documentation/extend examples before making repo public

Before we go public we should have some basic documentation ready.

There is some documentation and repo is public


Bug fix update group roles

PR updated with the fixes for
updateEntityPermissions
updateGroupPermissions
updateRolePermissions
covering their unit tests as well


Remove default 0 value

Hi,
How can I remove the default 0 value for MoneyMaskedTextController form field?

I also need to remove it so i can show the text field hint placeholder text

Me too

Yeah, I will try to change this and make a pull request.

Yeah, I will try to change this and make a pull request.


Include missing files in sdist

Include missing files in sdist for #9
Tested with
++ mktemp -d
+ D=/tmp/tmp.3qWZXzD0kB
+ trap 'rm -rf /tmp/tmp.3qWZXzD0kB' EXIT
+ python -m venv /tmp/tmp.3qWZXzD0kB
+ python setup.py sdist -d /tmp/tmp.3qWZXzD0kB
running sdist
running check
reading manifest template 'MANIFEST.in'
writing manifest file 'MANIFEST'
creating python3-logstash-0.4.73
creating python3-logstash-0.4.73/logstash
making hard links in python3-logstash-0.4.73...
hard linking README.md -> python3-logstash-0.4.73
hard linking README.rst -> python3-logstash-0.4.73
hard linking setup.py -> python3-logstash-0.4.73
hard linking logstash/__init__.py -> python3-logstash-0.4.73/logstash
hard linking logstash/formatter.py -> python3-logstash-0.4.73/logstash
hard linking logstash/handler_amqp.py -> python3-logstash-0.4.73/logstash
hard linking logstash/handler_tcp.py -> python3-logstash-0.4.73/logstash
hard linking logstash/handler_udp.py -> python3-logstash-0.4.73/logstash
Creating tar archive
removing 'python3-logstash-0.4.73' (and everything under it)
+ cd /
+ /tmp/tmp.3qWZXzD0kB/bin/pip install /tmp/tmp.3qWZXzD0kB/python3-logstash-0.4.73.tar.gz
Processing /tmp/tmp.3qWZXzD0kB/python3-logstash-0.4.73.tar.gz
Installing collected packages: python3-logstash
  Running setup.py install for python3-logstash: started
    Running setup.py install for python3-logstash: finished with status 'done'
Successfully installed python3-logstash-0.4.73
WARNING: You are using pip version 19.2.3, however version 20.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
+ echo Success
Success
++ rm -rf /tmp/tmp.3qWZXzD0kB

Yeah I haven't touched this since Python 3.5 I think


Preset domainspec

Fixes https://github.com/kubevirt/kubevirt/issues/1584
Not every field of a DomainSpec is valid (or copied from) a VMIPreset. This PR introduces a new type for tracking the actual fields of a VMIPreset that's separate from what a VMI uses.
Remove UUID as a supported field from VirtualMachineInstancePresets as it does not make sense.

Thanks @davidvossel! I think this PR was just in a holding pattern waiting for a review. I don't think there's going to be much disagreement on it since it's mostly boilerplate.


Cache cargo-audit on CI

We spend five minutes of CPU time on each CI building cargo audit.
I think we should:

enable caching so that we don't rebuild it each time
install it with --debug, so that we don't spend as much time building it
maybe somehow only trigger it when Cargo.lock changes?

The current setup is here:
https://github.com/rust-analyzer/rust-analyzer/blob/02f761ba4bd356ef2aeae5ed8bdd750c57ade30d/.github/workflows/ci.yaml#L11-L19

Either that, or set up cargo-audit's CI to build binaries.


Fix Airflow/github error handling

This PR resolves an error handling issue that masks the underlying issue.

Previously the error details listed
      ...
      File "/opt/anaconda3/envs/elyra_dev/lib/python3.7/site-packages/elyra/pipeline/processor_airflow.py", line 93, in process
        self.log.debug('Error adding pipeline to Airflow git queue: ' + e)
    TypeError: can only concatenate str (not "UnknownObjectException") to str

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Withdrawing. See https://github.com/elyra-ai/elyra/pull/1316


bug(mat-tooltip): flickering issue on mat-tooltips with delay setting

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
?
Description
When hovering out of a mat tooltip with a delay before the delay ends, there is flicker of the mat tooltip which appears and then quickly disappears.
Stackblitz from from the official documentation with added delay setting: https://stackblitz.com/edit/angular-jhdwzh?file=src%2Fapp%2Ftooltip-custom-class-example.html
loom: https://www.loom.com/share/02182737108a4887bdcf5ded660fdb50
Reproduction
Steps to reproduce:

create a mat tooltip with a delay of 1000
hover in and out of the element with tooltip quickly
the tooltip flickers when mouse moves out of the element before the delay ends

Expected Behavior
The tooltip shouldn't be displayed when the mouse moves out of the element before the delay ends
Actual Behavior
The tooltip flickers when moving the mouse out of the element before the delay ends.
Environment

Angular: 13.3
CDK/Material: 13.3
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows/Macos

I think it's similar to this one. (#24614).


Publish to repository

Would it possible to get this code published into a repository such as maven central or jcenter? This would make it more easily usable as clients would not have to build and install it manually, instead it could be included as an entry in a maven pom file or gradle build script for example.

Hi Michael,
this plugin is integrated with https://jmeter-plugins.org which is some kind of standard way to install plugins in JMeter.
How would you use a maven dependency?

Hi Yoann,
Thanks for the quick response, and please excuse my ignorance, I am not overly familiar with the details of JMeter, I have been asked to come in and help clean up the build process on an existing project that I am still getting up to speed on.
We have a use case where we are wanting to pull this code as dependency into a standard java project.
It has actually been worked on by a group of other guys so I am not sure exactly why. I have removed the dependency from their gradle.build file and the code still compiles, so I am not sure why it has been added, I will have to go back and ask. For now I will close this issue until I have spoken to them, if it is still a requirement I may come back and raise a new one.
Thanks,


fix: throw if sfdx is not found

When sfdx is not installed and a TestSession tries to create a test project using the force:project:create command it will fail with (sometimes) an error that is not very intuitive.  This adds some code that will throw an error that is more helpful.
@W-8996057@

@shetzel how about the situation when one does not have a project and then run sfdx commands as part of TestSession setup?

@shetzel how about the situation when one does not have a project and then runs sfdx commands as part of TestSession setup?

@peternhale - Not exactly sure what you're asking.  Do the setup commands require a project?  If they do, the commands would fail as expected.  Or are you asking what would happen if sfdx isn't installed and sfdx commands are run as part of TestSession setup?  They could pass or fail - it depends.  After project creation in the TestSession constructor, if the TESTKIT_EXECUTABLE_PATH is not set it is assigned to ./bin/run.  So if the command is not installed as a dev-plugin and it's not in the current plugin then it would fail with something like, "Command not found".

@shetzel how about the situation when one does not have a project and then runs sfdx commands as part of TestSession setup?

@peternhale - Not exactly sure what you're asking. Do the setup commands require a project? If they do, the commands would fail as expected. Or are you asking what would happen if sfdx isn't installed and sfdx commands are run as part of TestSession setup? They could pass or fail - it depends. After project creation in the TestSession constructor, if the TESTKIT_EXECUTABLE_PATH is not set it is assigned to ./bin/run. So if the command is not installed as a dev-plugin and it's not in the current plugin then it would fail with something like, "Command not found".

@shetzel I guess what I asking is when setup commands include sfdx force:org:create ... and sfdx is not installed what will the error look like and would it be better if TestSession confirmed sfdx was installed. The setup function does not use execCmd, it calls shell.exec directly. Since we have a better message emitting from TestProject, I thought it would also apply to TestSession.

@shetzel how about the situation when one does not have a project and then runs sfdx commands as part of TestSession setup?

@peternhale - Not exactly sure what you're asking. Do the setup commands require a project? If they do, the commands would fail as expected. Or are you asking what would happen if sfdx isn't installed and sfdx commands are run as part of TestSession setup? They could pass or fail - it depends. After project creation in the TestSession constructor, if the TESTKIT_EXECUTABLE_PATH is not set it is assigned to ./bin/run. So if the command is not installed as a dev-plugin and it's not in the current plugin then it would fail with something like, "Command not found".

@shetzel I guess what I asking is when setup commands include sfdx force:org:create ... (or other sfdx commands) and sfdx is not installed what will the error look like and would it be better if TestSession confirmed sfdx was installed. The setup function does not use execCmd, it calls shell.exec directly. Since we have a better message emitting from TestProject, I thought it would also apply to TestSession.

@peternhale - Oh you're right!  Sorry about that.  Yeah that'll have the same problem.  I'll refactor the solution.  Thanks!


Import sorting doesn't work on certain import types

Your Environment

Prettier version: 2.8.8
node version: 19.8.1
package manager: yarn@3
IDE: VScode

Describe the bug
The reproduction code isn't sorted properly. When the import './global.css'; is at the top, it isn't sorted to bottom. When at the bottom, it's split with a newline like it should be.
To Reproduce
Sort using VSCode or Prettier CLI.
Expected behavior
It sorts properly.
Screenshots, code sample, etc
import './globals.css';
import clsx from 'clsx';
import { Work_Sans as WorkSans } from 'next/font/google';

Configuration File (cat .prettierrc, prettier.config.js, .prettier.js)
{
  "semi": true,
  "singleQuote": true,
  "bracketSpacing": true,
  "trailingComma": "none",
  "pluginSearchDirs": false,
  "importOrderTypeScriptVersion": "5.0.4",
  "importOrder": ["<THIRD_PARTY_MODULES>", "", "^@/(.*)$", "", "^[./]"],
  "plugins": [
    "@ianvs/prettier-plugin-sort-imports",
    "prettier-plugin-tailwindcss"
  ]
}

Error log
No logs.
Contribute to @ianvs/prettier-plugin-sort-imports

[ ] I'm willing to fix this bug 🥇

Hi, this is expected behavior. Side effect imports (imports with only a specifier) are not safe to rearrange. If you had two css imports like that, and we sorted them, it could change the generated cascade and break the styles in your app. The trivago version of this plugin does sort these imports, so you can use that if you're not worried about potential issues.

Ah ok, thanks for the explanation.

Hi, this is expected behavior. Side effect imports (imports with only a specifier) are not safe to rearrange. If you had two css imports like that, and we sorted them, it could change the generated cascade and break the styles in your app. The trivago version of this plugin does sort these imports, so you can use that if you're not worried about potential issues.

I completely understand this, but I think it would be nice to be able to hard specify some side effect imports directly. For example, we have to include import 'twin.macro' in every file, and we'd like it to always be at the top, but if we specify 'twin.macro' in our order config, it is not affected. I think if we explicitly specify one, that should override any safety rules.

For reference, there's some additional context around this issue here: https://github.com/IanVS/prettier-plugin-sort-imports/issues/51
@LordZardeck, you bring up an interesting point here.  Whereas it's difficult to accomplish any kind of sorting for generic side-effect-only imports, perhaps we could respect explicit, exact matches like 'twin.macro'.  @LordZardeck, would you mind opening a new issue with a proposal of this idea, so we can discuss it further?


[Bug]: SpaCy version issue

Bug Description
Our build with 0.10.37 started to fail when 0.10.38 was released today. pip was unable to resolve SpaCy version requirements.
On further digging, I found that spacy version requirement has been changed to *
https://github.com/run-llama/llama_index/pull/13634/files#diff-27c22ecf2f62e56c8d2bf98a06cb5d30d84a49c6aba59fc5192ed92732f08d50R66

Request you to release a fix immediately.
Version
0.10.37
Steps to Reproduce
Described above.
Relevant Logs/Tracbacks
No response

@dosu we're using pip not poetry.

You must have some other requirements that are causing spacy to search for a version? A pip install llama-index in a fresh env works for me

Fixed in llama-index-core=0.10.38.post2
pip install -U llama-index-core will get it


Tests!

Because ... tests!
This is overdue, but now that the pins work is merged it's actually substantially easier. We should be able to construct a MockPin class and use that for testing all the device stuff. As for testing the pin implementations themselves, I'll come up with some minimal hardware config for it but it's probably not hard (wire one GPIO to another, configure one as output, one as input, test away - or something like that).

I wanted tests before it was cool. #87

Doh! Closing as duplicate of #87 because Dave didn't search the issues first :(

:)


Files access when installing package

Assets like gripper URDF files cannot be accessed when package is installed to site-packages.
To reproduce error install this package directly from github:
pip install git+https://github.com/mrudorfer/burg-toolkit.git@dev

Then loading a gripper in simulation:
import burg_toolkit as burg
import numpy as np

sim = burg.sim.GraspSimulator(burg.Scene(), verbose=True, plane_and_gravity=True)
gripper = burg.gripper.Franka(sim)
gripper.load(np.eye(4))

The error will be:
b3Printf: b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,152]:

b3Printf: URDF file '/home/martin/dev/burg-toolkit/venv/lib/python3.6/site-packages/burg_toolkit/gripper/assets/franka/model.urdf' not found

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/martin/dev/burg-toolkit/venv/lib/python3.6/site-packages/burg_toolkit/gripper/franka.py", line 31, in load
    baseOrientation=orientation
pybullet.error: Cannot load URDF file.

Checking the site-packages directory to which the toolkit has been installed, the asset folders are not there and hence the files cannot be found.
What is the best way to install the package including those files?

It works now in the scenario described above, by adding package_data info in setup.py.
It might not work for other ways of distributing, especially when it is packaged up the files may not be physically accessible, and then retrieving them from within the package by relative path as is the case now will not work. Also there is a lot of confusion and ambiguity about how to make it work for all cases, see e.g. here.
Anyways, for now this is resolved (in dev branch).


Support for variables

Hi,
do you have any plans to support variables, e.g
path1: "./this/is/the/path"
path2: "{{path1}}/subfolder"

Regards
Stefan

No


Define layers order

Related to: https://github.com/CartoDB/cartodb.js/issues/1982

[x] Add moveLayer(layer, index) function to Engine
[x] Add moveLayer(layer, index) function to Client
[x] Add setOrder(index) function to Layer
[x] Add bringToBack() function to Layer
[x] Add bringToFront() function to Layer
[x] Add tests
[x] Add examples

@IagoLast @ivanmalagon @alonsogarciapablo @inigomedina

how this affects interactivity?

Interactivity is not affected by this PR.

Passed acceptance.
🇯🇲


fix: update torrust tracker config in bencher

Now, some configuration options have default values. So we only need to disable options that make the tracker slower.
Some options are still mandatory, like:

metadata.schema_version
logging.threshold
core.listed
core.private

@josecelano could you please open a PR updating the torrust-tracker commit rev listed in the bencher README file, to one known to work with these changes?

@josecelano could you please open a PR updating the torrust-tracker commit rev listed in the bencher README file, to one known to work with these changes?

https://github.com/greatest-ape/aquatic/pull/209


Error: Variables not allowed while running terraform apply

I have issues
I'm submitting a...
[root@linux01 terraform-aws-eks]# terraform apply
var.cluster_name
Name of the EKS cluster. Also used as a prefix in names of related resources.
Enter a value: firsteks
var.subnets
A list of subnets to place the EKS cluster and workers within.
Enter a value:
var.vpc_id
VPC where the cluster and workers will be deployed.
Enter a value:
provider.aws.region
The region where AWS operations will take place. Examples
are us-east-1, us-west-2, etc.
Enter a value: us-east-1
Error: Variables not allowed
on  line 1:
(source code not available)
Variables may not be used here.
[root@linux01 terraform-aws-eks]

[ ] bug report
Error: Variables not allowed
[ ] feature request
[ ] support request
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
If this is a bug, how to reproduce? Please include a code sample if relevant.
What's the expected behavior?
Are you able to fix this problem and submit a PR? Link here if you have already.
Not able to fix
Environment details
Using default variables

Affected module version:
OS:  RHEL-8.0.0_HVM-20190618-x86_64-1-Hourly2-GP2 (ami-0c322300a1dd5dc79)
Terraform version:
Terraform v0.12.5

provider.aws v2.20.0
provider.local v1.3.0
provider.null v2.1.2
provider.template v2.1.2

Any other relevant info

You're not supposed to run terraform from the root of this repo. Try from examples/basic 🙂


refactor(publish): add an ICSP generation struct to pass more inform…

…ation when generating ICSPS
Fixes #172
Description
This PR refactors the ICSP generation to allow for more information about the image to be passed in (e.g. whether it is an operator image)
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Added unit test

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/lgtm


Val.lazy() and Val.lazyAsync()

See Issue 57
An implementation and documentation for Val.lazy() is provided. It calls the
given Supplier only once without notifing any observers. It is null-safe, but
not thread-safe.
An API is suggested for Val.lazyAsync(). Three variants are given. One merely
gives a Callable to be executed in some other thread. Another gives the
Executor to be used. Finally, a Supplier for a CompletionStage can be used as
well. Together, these should provide for every case from maximum usability to
maximum control.

I think placeholders are not needed. If one needs a default value, they can use asyncVal.orElseConst(defaultValue).

I would always require providing an Executor.

Good point for the default values. Saves an argument by using a fluent Builder (of sorts), I like it.
I have mixed feelings about not providing a default Executor. It fits better with JavaFX and the rest of the framework I guess. But one of the strong points of reactive programming is that these details can be hidden by the framework. So the usability, compared to other reactive frameworks or even just java.util.Stream, goes down a lot.
Also, it would probably result in at least one ThreadPool or something for each class that uses this method. So a lot of unnecessary Threads get created as well. I like to have a lot of control over the code I'm using, so I can see your point. But still think having a default Executor in the background would be preferrable.
As for your third point, why not both? I can certainly see use cases for your version. But mine is also quite useful. It allows for example to have one lazy call that will initialize several Vals by chaining the CompletionStages.
I'm having some trouble with my toolchain here. But I will provide an updated version later.

It allows for example to have one lazy call that will initialize several Vals by chaining the CompletionStages.

How is it going to initialize several Vals when it returns just a single Val?

I would suggest Either<? extends Exception, T> instead.

public interface Try<T> extends Either<Throwable,T>

I would suggest Either<? extends Exception, T> instead.

public interface Try extends Either<Throwable,T>

Oops, got that mixed up, sorry.

My idea for the `CompletionStage` ist the following: On the very first call create a `CompletionStage<SomeClass>`, then return `CompletionStage<String>`, `CompletionStage<Integer>` or whatever, each containing some property of `SomeClass` after the first `CompletionStage` finished. This way I can for example request some DTO with various properties, then use this result in multiple lazy `Val`s.

I've got to go now, but I will write up some code later, including examples for the wiki.

Also, it would probably result in at least one ThreadPool or something for each class that uses this method. So a lot of unnecessary Threads get created as well.

That would be insane. We could use ForkJoinPool.commonPool() to execute those tasks. I prefer to be explicit about concurrency, but as long as we document it and advise to use explicit executor for more control...

Never mind, I forgot (again) that Val is pretty smart already.
Assume a class Person that you receive from somewhere (DB, filesystem, ...)
public class Person {
    private String name;
    private int age;

    // getter, setter, etc.

You can then do the following:
public class PersonModel {
    private Val<Person> person = Val.lazyAsync(this::getFromSomewhere);
    private Val<String> name = person.map(Person::getName);
    private Val<Integer> age = person.map(Person::getAge);

    private Person getFromSomewhere() {
         // Load a person from some slow location
    }

This actually works because map()is lazy. I will turn it into a unit test. With just a tiny bit of code we have a model with on-demand loading. I like it. :)
Before I was thinking about chaining the CompletionStages, but it's much easier to chain the Vals. I suppose that kills the only argument I can see for that signature.

Anyway, if we have
<T> Val<T> lazy(Supplier<T> supplier);
<T> Val<Try<T>> awaitAsync(CompletionStage<T> completionStage);

then one can implement that lazyAsync(Supplier<CompletionStage<T>> completionStage) easily, if they want to:
<T> Val<Try<T>> lazyAsync(Supplier<CompletionStage<T>> completionStageSupplier) {
    return lazy(completionStageSupplier).flatMap(awaitAsync);
}

Bit short on time, I'll come back to this on Monday and start implementing some things.

Sounds good.

Just to let you know, I'm still working on it. But I seem to have some problem. I first thought it was the threading, now I think ValBase does not work as a base for me. Anyway, I'll get it running eventually. ;)

What's the difficulty with ValBase? It should also be straightforward to implement it using a Var initialized to null and set to the result on completion. A direct implementation extending ValBase might just be a tiny bit more efficient.

Now that is weird.  I had a NPE in my tests, simply because I had the condition wrong. But it never showed up. Instead the FX thread blocked somewhere. So my tests ran into timeouts without ever showing the exception anywhere.
Now I just have to clean up my code and I'll commit it. I'll be on vacation for a week, so take a look around, give me some feedback, and I'll fix anything next Sunday.

Good, enjoy your vacation!

OK, got it. The number of hoops I had to jump through to get the tests running is insane. Suffice it to say that simply installing an exception handler is not enough...
Well, it works now. Implementation is nice and simple.

Looks good. A few more things to consider:

Shouldn't removing the listener from the Val returned from lazyAsync cancel the asynchronous task if it hasn't started yet? Consider scrolling a list of image previews. If the user scrolls down before all the images were loaded, their loading should be cancelled so that the images that are now in the view could be loaded.
We should abstract over the Platform::runLater executor, taking a second executor as an argument. This way, the methods will be usable for someone who uses ReactFX on a different thread than the JavaFX application thread. I would keep the JavaFX thread methods for convenience, but they would just call the more general methods. See for example EventStreams.ticks, CompletionStageStream#await or various methods on EventStream taking two executors.
Maybe also supply an explicit executor for awaitAsync.

Yes and no. Canceling rarely makes sense. Most use cases are going to be RPC calls or http requests or something similar. These usually do not support canceling very well. Even if they do, the benefit will be small. I can implement it, but often it won't help.
On the other hand, a delay would be handy. Adding an optional parameter with a delay in milliseconds, and not starting the request if the listeners were removed before the end of the delay, seems better.

and 3. I will add it, but along with a warning. In EventStreams or reactive systems in general, you have more control over the thread your work will be done on. This is not the case with ObservableValues. Any listener will be called on the thread that triggered the update, and it's cumbersome to change that for a single listener. For bindings it's worse. So when the Val is bound to a UI component in any way, no matter how many steps are in between, it will crash, and it's going to be hell to debug as a binding in the stack trace won't tell you which ObservableValue was the culprit.

Canceling rarely makes sense. Most use cases are going to be RPC calls or http requests or something similar. These usually do not support canceling very well.

Even for non-cancellable tasks, we can still support cancelling if the task hasn't started yet, i.e. is still in the executor's queue. I think it is crucial for something like image previews combined with scrolling.

.2. and 3. I will add it, but along with a warning. In EventStreams or reactive systems in general, you have more control over the thread your work will be done on. This is not the case with ObservableValues. Any listener will be called on the thread that triggered the update, and it's cumbersome to change that for a single listener. For bindings it's worse. So when the Val is bound to a UI component in any way, no matter how many steps are in between, it will crash, and it's going to be hell to debug as a binding in the stack trace won't tell you which ObservableValue was the culprit.

I had something much simpler in mind. Namely, when the observable value lives on a thread other than JavaFX application thread (thus is not bound to any UI component). You already implemented transfer from the asynchronous executor to JavaFX application thread via Platform::runLater. I just meant to abstract the Platform::runLater as an additional executor.

Phew, sorry for the long wait. Was kinda busy.
Anyway, here are some features. You can select the thread for publishing events and there is a delayed version which cancels if all observers are removed during the delay.
I do not yet cancel running operations. This would make tracking the state very hard.

Instead of tracking "Did I start the operation?", there is the obvious additional state "Did I start and then cancel the operation?".
Then the question "Should the worker thread be interrupted (in the sense of the interrupted flag)?"
What if the operation was supposed to be canceled, but completed anyway? How is it checked? Should the result be discarded?

This is not just a lot of work, it's also a lot of potential for bugs that I cannot realistically cover with unit tests. I will think of ways to do this in a reasonable way. So please stay tuned.
On the positive side, I recently used ReactFX and UndoFX with this new feature to build a Flux-based window with a lazy loading TableView. Works like a charm. So thanks a lot for the great work.

Oh, and please note that I moved the {{ScheduledExecutorServiceTimer}} into util and made it public. I used it, so I had to somehow change the visibility, and it looks polished and useful enough to be public.


Ability to keep last install/upgrade job pods

I have had many occurrence where Drupal upgrade goes failing due to some issue with drush cim or drush updb. The current job will be deleted after 5 failed execution. Would it be possible to retain the last job pod to facilitate log reviews? I think the parameter for that might be:
  annotations:
    "helm.sh/hook": post-upgrade
    "helm.sh/hook-weight": "10"
    "helm.sh/hook-delete-policy": hook-succeeded

to
  annotations:
    "helm.sh/hook": post-upgrade
    "helm.sh/hook-weight": "10"
    "helm.sh/hook-delete-policy": before-hook-creation

What do you think? Possibility?

I think this looks fine, would you be able to make a P.R?
@zachomedia any comments?

OK, I will create a quick PR.

Merged :) Thanks so much in improving this chart for everyone!


Update restore CRD with required cleanup changes

Signed-off-by: sahare<EMAIL_ADDRESS>

/assign @birsanv


Number parsing not implemented

Parsing for localized numbers is not implemented. This seems like just an oversight.

This issue has been moved to dart-lang/intl#44.


Scale Workers

Change workers from 4 to 2 per new service. Maybe add new command to admin scripts to change number.

This issue was moved to StackHut/stackhut-toolkit#22


Asteroids doesn't exit properly

When trying to quit asteroids with the 'q' key after the game is over, it does not close correctly and you have to use the cross at the top corner

Will be resolved by issues #67 and #65


Mitaka nfp 29 april 2016

Passed ATF with 2 failures out of 11 test cases.
2 failures were traffic related.

Changes are fine and ATF passed on freshly installed setup. Need to still debug the pecan struck issue which is happening on some of the setups.


Unable to download webpage: HTTP Error 429: Too Many Requests

youtube-dl https://www.youtube.com/watch?v=hcfGm247m4Q
[youtube] hcfGm247m4Q: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 429: Too Many Requests (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 314, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1674, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib64/python2.6/urllib2.py", line 397, in open
response = meth(req, response)
File "/usr/lib64/python2.6/urllib2.py", line 510, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib64/python2.6/urllib2.py", line 435, in error
return self._call_chain(*args)
File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
result = func(*args)
File "/usr/lib64/python2.6/urllib2.py", line 518, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Duplicate of #5138.


binary files which generated by saving the model in python and R are  different, missing initial "binf"

For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System:
Linux
Compiler:
Package used (python/R/jvm/C++):
python and R
xgboost version used:
0.6
If installing from source, please provide

The commit hash (git rev-parse HEAD)
Logs will be helpful (If logs are large, please upload as attachment).

If you are using python package, please provide

The python version and distribution
The command to install xgboost if you are not installing from source

If you are using R package, please provide

The R sessionInfo()
The command to install xgboost if you are not installing from source

Steps to reproduce

generate any xgboost model, in python,
model.save_model("file1.model")
in R, xgb.save(xgb.load("file1.model"),"file2.model")
Two binary files are different.

What have you tried?

any follow up?


use

@Zekeny, thank you. You have opened this issue in the Kong/kong repo: https://github.com/Kong/kong/issues/7575


GCal integration - one way import from GCal to gadsu

synchronize gcal events. import (locally add), delete (locally delete) and update (from gcal to local). so for sync, its one way, gcal always wins.
when changing an appointment (add/update/delete) while having an internet connection, all changes will be propagated to gcal.
NO support yet for OFFLINE working...
implement some client suggesting component, when reading appointment title and map to existing client (string comparison functionality).

[x] sync logic
[x] sync report view
[x] import logic

i'm afraid this might not work with the first shot... be brave.


feat: Add code for computing service coverage windows and trip counts

Adds TripCalendarUtil, which provides methods for computing service coverage windows based on daily trip counts.
Will hopefully be useful for #886 and PR #1289.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues

@davidgamez @isabelle-dr Could someone take a look and merge this so that I can use it in #1289?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bdferris-v2:x: davidgamezYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bdferris-v2:x: davidgamezYou have signed the CLA already but the status is still pending? Let us recheck it.


Allow showing Calibration Curve normalized value on Peak Area graph

The right-click menu on the Peak Area graph will allow you to choose to display the concentration calculated using the calibration curve.

There are two new menu items on the Normalize To context menu: "Default" and "Calibration Curve". "Default" is always available but the "Calibration Curve" menu item only shows up if you have chosen a Regression Fit at "Peptide Settings" > Quantification.
"Default" means to use whatever Normalization Method is specified for the currently selected peptide. That option is more important on the Area CV Histogram graph, where you are showing data from multiple peptides. You need an option that says to use each peptide's individual normalization method.

Thanks for the feedback, Brendan.
Oops. I had forgotten about the TODO comments that I had in there. They all indicated something which I did not want to commit to master at all. (We should come up with something that causes an inspection error such as "//DONTMERGE".)
There are a couple of things that we should think about before I merge this to master:

This change makes it so that we never use the ratio lists on TransitionChromInfo and TransitionGroupChromInfo. Those ratios are still there so that I can have my assert during tests where I verify that the numbers in those lists are the same as what I calculate from scratch with "NormalizedValueCalculator".

The SequenceTree uses NormalizedValueCalculator to calculate the ratios that it displays. I have tried to make sure that it is just as fast as it used to be. Can you point me at a really large document which has heavy labels in it? I want to make sure that TransitionTreeNode.GetResultsText has not gotten any slower with my changes.

When you change which label type you are normalizing to in the Area Replicate Graph Pane, it changes the text that gets displayed on the transitions in the Targets tree. Currently, when you choose Global Standards, it continues to display whatever the last ratio that you were displaying. Now that we have more options, like Median normalization and Calibration Curve, we should figure out what we should display in the Targets tree. Would people want to see the median normalized peak area for transitions in the Targets tree, in the same way that we show them the ratio to heavy?


Fix issue 21129: Make OnlyResult store a value tuple instead of a static array of CommonType.

For static arrays, only used to store a reference to its caller. This was bad. I changed it (in https://github.com/dlang/phobos/pull/7253 ) to take its arguments by value, but I didn't realize the static array case - so it started storing a reference to its constructor parameters, which was more obviously bad, as it crashed (@system) or failed to compile (@safe).
This PR changes only to store the tuple of arguments in the range and convert to the common type as late as possible.
ping @JohanEngelen
Note that I test with const(char) as there seems to be a bug with CommonType - it thinks char[] and string are best unified as char[].

As the bot states, this should target stable.

Thanks.
Can you include improvements to the documentation of only? The documentation currently uses words that have little exact meaning in programming ("assemble", "in-situ") and it is not clear that the parameters are copied into the resulting object.

"Copying the range means copying all elements" seems pretty clear. Afaiu this is how only was always meant to work. Not sure how else I'd phrase it while still talking about behavior, not documenting the implementation.

This might cause other problems. Now, Only!(long, int) is a different type than Only!(int, int). Whereas, before it was the same type. Might be a bit contrived.

Yes but I mean, it's super awkward to fix that. I'd have to sort the tuple and keep a map of indexes to tuple indexes.

Yes but I mean, it's super awkward to fix that. I'd have to sort the tuple and keep a map of indexes to tuple indexes.
Does that unittest describe an actual semantic requirement or just a "nice to have"?

Yes but I mean, it's super awkward to fix that. I'd have to sort the tuple and keep a map of indexes to tuple indexes.
Does that unittest describe an actual semantic requirement or just a "nice to have"? It's not in the only docs.

Yes but I mean, it's super awkward to fix that. I'd have to sort the tuple and keep a map of indexes to tuple indexes.
Does that unittest describe an actual semantic requirement or just a "nice to have"? It's not in the only docs.

I'd have to sort the tuple and keep a map of indexes to tuple indexes.

No, that wouldn't solve it -- the types are different, not just in a different order.
What I see as a possible problem is this:
struct SomeStruct
{
  typeof(only(1L, 1L) someRange;
}

// one place
auto s = SomeStruct(only(1L, 1L));

// some other place
auto s = SomeStruct(only(2L, 3));

Definitely contrived. I don't have an example in the wild. indeed the fact that buildkite passed completely suggests there isn't [m]any.
But of course, buildkite didn't catch the problem that triggered this fix.
I definitely have code that uses the typeof(only(...)) to save an Only struct as a member, but I set it in one place, so it shouldn't be affected.
Then of course, there's the matter of proliferation of templates.
It's also a bit worse performing for opIndex. Hm.. just thought of this too -- if the implicit conversion is expensive or destructive, then it might break code which expects the conversion to only run once. Another contrived example.
It seems like your original PR is fixing a one-off odd case, and this PR is fixing a one-off odd case, only to add more one-off odd cases.
Is it worth considering to go back to the original mechanism, and fix the original one-off a different way? Like maybe using something like checking for each parameter if an implicit cast to Unqual!T is possible, and if so, use that for determining the common type?

No. The original version did not match the description. The revised version still did not match the description. The implementation was just wrong both times, in ways that contradicted the explicit documentation. If OnlyResult is to take its parameters by value, it has to actually match the parameters' types.
I'd say just go for it. Template proliferation and minor index performance loss should not come at the expense of correctness.

Perhaps a solution: Can we have the conversion take place at the call site? (i.e. only(Values...) only accepts values that are all of the same type?
Can you also add a testcase for the alias this type of "conversion" ? Thanks!

Wouldn't that break the static array example if the range is returned?

Wouldn't that break the static array example if the range is returned?

Ah yes indeed you are completely right. Somehow I am treating only (what a very weird and inexplicable function name it is!) as chain that should only be used to pass as function parameter and not stored.

ping

@FeepingCreature Can you also add a testcase for the alias this type of "conversion" ?

@johanengelen done.

Technically, I think this should target stable. Is it worth holding up the beta for this? Was going to tag auto-merge.

Yeah, it's sort of a regression, isn't it? Retargeting to stable.

This isn't going to pass buildkite (due to the temporary difference between master and stable for phobos+no-autodecode), but auto-merge will give it priority on the testers.

This is triggering some kind of problem in phobos for the buildkite build:
std/range/package.d(921): Deprecation: storage class `ref` has no effect in type aliases

That's unrelated to this PR. Note that it happens in chain, not only - and the code is marked "This doesn't work yet", lol.

I know. What concerns me is that it doesn't happen anywhere else (I haven't seen a massive buildkite failure like that in other PRs). It's a lovely error with no indication of what the compiler was doing when it tried to compile that. Possibly some combination of chain/only in some test or something is causing this, but I don't know why then it would pass all the autotesters, etc.

This diagnostic was enabled recently in DMD and I've already removed that code in master. Seems like

You're right, that's weird. I don't see any recent merge in DMD that would trigger that.

I wonder if it's possible buildkite got caught right in the middle of the switch to target the stable branch. Try a re-force-push?

Maybe. I've retriggered Buildkite

Didn't work. Maybe try a force push? or close and reopen?

This diagnostic was enabled recently in DMD and I've already removed that code in master. Seems like Buildkite uses dmd-master to build stable?

Yes, that's a bug in Buildkite. When you change the target branch in GitHub without a new commit or force-push, then Buildkite doesn't update the base branch, i.e. BUILDKITE_PULL_REQUEST_BASE_BRANCH="master". Hence, dmd master gets checked out.

It's a bit hard to workaround this as GitHub's API are rate-limited.
Anyhow, I force-pushed.

Well, I'll be back in 12h. Good luck! ;)


Shift+Tab not working after click in editor under Safari

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When you click inside the editor and click somewhere in the text, you can't use Shift+Tab anymore under Safari (according to my test, other browsers are fine), the focus stays every time inside the editor. Pressing Tab works fine.
Here's a demo: https://jsfiddle.net/vrhm7jtd/5/
Click inside the editor, then click somewhere in the text and Shift+Tab will stop to work.
What is the expected behavior?
Focus moves on the previous focusable element.
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
Latest (0.11.7) version of Draft.js, macOS 10.15.7 Catalina with Safari 14.0 (156<IP_ADDRESS>.9)

We have the same bug across many safary browsers with different wysiwyg editors, which we had reduced to just simple contenteditable div element.
After hours of trials and searches we found this 12 years old bug report: https://bugs.dojotoolkit.org/ticket/8987
In short, someone suggest setting tabindex="-1". It was one of the most unthinkable hypothesis, but after all we give it a try and surprisingly it worked!
All javascript editors suffering from this bug now works perfect.
OMG that was unthinkable 12 years old bug.

The trick is to set tabIndex to -1 onfocus, and restore it onBlur. Alternatively helps explicit focus() call onclick.

@vsvasya @haafus Thank you, working fine!


Is there a possibility to add a fallback to UIWebView for <iOS 9 devices?

Title says it all, just a question.
Since 10% of devices are still running iOS 8, it would be nice.
source: https://developer.apple.com/support/app-store/

Hello! Thanks for using Ionic! This behavior actually already exists in this plugin! If it is running on a device running ios 8 it will fall back to uiwebview since wkwebview does not work well on ios8. Thanks!

@jgw96 is right!
since this plugin is just a incremental fork of https://github.com/apache/cordova-plugin-wkwebview-engine#notes it fallback to UIWebView
we are going to update our README to reflect that.
Thanks for opening the issue!

@nickkenens I just committed a tiny edit to our readme to make this more clear. Thanks!

@jgw96 thanks for the clarification!


LLaVA predictions are always empty

Thanks for the awesome paper and repo!
I was trying out LLaVA and noticed that the model predictions were always empty strings, and was able to narrow it down to this line https://github.com/ys-zong/VL-ICL/blob/6ad043d625f8205b75f57e720441cfc98d0fd5a1/utils/model_inference.py#L76.
It seems LLaVA already outputs only the tokens it generated, and not the whole context tokens + generated tokens.
The fix is quite easy, just decode the whole generated sentence, without truncating it first with the input_token_len.
Is my thinking correct or am I missing something?

Hi, thanks for your interest. I think that's due to different versions of Llava - the older version I used when developing this repo seems to need this slicing (I'll need to double check it). But if decoding the whole generated sentence works for you, that's totally fine to just go without truncation.

Ah I see, thanks!

Ah I see thanks!


Clock time displayed is half of the actual time period

Describe the bug
The displayed clock pulse on the right side panel is wrong
Expected behavior
The clock time (ms) displayed is only half of the actual working clock. For example, if the clock pulse is set to 500ms, the time period of the working clock pulse is actually 1s on the platform.
Device Information [optional]:

OS: Win 10
Browser: Chrome
Version: 89

Additional context
https://en.wikipedia.org/wiki/Pulse_duration

Are you working on this issue? (Yes/No)
No

@humble-barnacle001 could you provide more information on how to recreate the issue?

I would love to work on this issue , can you please assign it to me ?

Hey is this still an issue ?

@Subhadiptech Go Ahead 👍🏼

Still an issue for me as of today. Just built a MOD50 timer to count 5 seconds with a 10Hz clock input but with the clock set to 100ms it takes 10 seconds to cycle, so the clock speed must actually be double what I selected.


[Icon Request]:

Housekeeping

[X] I'm sure this issue is not a duplicate

Icon Type

[X] File Icon
[ ] Folder Icon

Icon Type

[ ] Extension
[x] Filename
[ ] Language ID

Original Icon

Icon Information
should be like gear or else
More Information:
.config file should be adjusted to a gear icon or something else, it shouldn't be just show a file icon, thx.

Do you have any practical use cases of the .config file? What tools use it?


UPS Integration Environment warning email

I received this message from UPS

This message is to inform you that you are currently using UPS Developer Kit APIs in the Customer Integration Environment (CIE), which is not intended to perform as the UPS® production environment. To avoid slow response times or planned outages, please migrate to the UPS production environment by November 25, 2014.

I believe I am using the production environment, and that this message might be an error. However, I'm not sure if Active Shipping provides a way to change between these environments, or how to check which environment I'm using.
Do you know?

The following URLs are defined:
    TEST_URL = 'https://wwwcie.ups.com'
    LIVE_URL = 'https://onlinetools.ups.com'

It should pick LIVE_URL by default, unless you pass :test => true as an option to the method.


[release 0.7.1]: Plugging in CA certificate and key failed on Verify CA certificate

Ref doc: https://istio.io/docs/tasks/security/plugin-ca-cert.html

ran through the steps following the https://istio.io/docs/tasks/security/plugin-ca-cert.html
on Verifying the new certificates, step 4

tail /tmp/pod-cert-chain.pem -n 22 > /tmp/pod-cert-chain-ca.pem
tail: -n: No such file or directory
tail: 22: No such file or directory

modified and ran following commands
tail -n 22 /tmp/pod-cert-chain.pem  > /tmp/pod-cert-chain-ca.pem
openssl x509 -in /tmp/ca-cert.pem -text -noout > /tmp/ca-cert.crt.txt
openssl x509 -in /tmp/pod-cert-chain-ca.pem -text -noout > /tmp/pod-cert-chain-ca.crt.txt
diff /tmp/ca-cert.crt.txt /tmp/pod-cert-chain-ca.crt.txt

Return differences, Expect that the output to be empty
diff /tmp/ca-cert.crt.txt /tmp/pod-cert-chain-ca.crt.txt
5c5
<             e3:75:89:fa:c1:67:6f:c1
---
>             9e:5e:83:37:72:3d:43:c4:2f:3e:34:b5:91:a7:77:c4
7c7
<         Issuer: C=US, ST=California, L=Sunnyvale, O=Istio, OU=Test, CN=Root<EMAIL_ADDRESS>---
>         Issuer: C=US, ST=California, L=Sunnyvale, O=Istio, CN=Istio CA
9,11c9,11
<             Not Before: Jan 24 19:15:51 2018 GMT
<             Not After : Dec 31 19:15:51 2117 GMT
<         Subject: C=US, ST=California, L=Sunnyvale, O=Istio, CN=Istio CA
---
>             Not Before: Apr 12 23:10:41 2018 GMT
>             Not After : Apr 13 18:10:41 2018 GMT
>         Subject: O=
16,33c16,33
<                     00:cb:30:b1:af:fc:6e:d3:3c:b9:ad:50:62:b2:8f:
<                     5f:7e:09:74:d1:b4:4a:bc:1f:c7:17:80:17:f7:fc:
<                     ad:99:9e:87:aa:cc:b5:dd:72:10:93:cf:ee:fc:1c:
<                     bd:88:2b:d5:c1:72:0c:bf:24:f4:09:b8:89:ab:f6:
<                     8f:12:3e:66:25:4c:b4:97:36:eb:52:cd:77:a2:77:
<                     97:aa:b3:d7:7f:b8:ab:dc:7c:dd:47:0f:92:06:15:
<                     e5:b2:1f:73:00:f6:49:5d:c1:7d:dc:32:54:dc:66:
<                     9b:3c:ac:01:bc:62:74:21:53:09:3c:81:42:b8:32:
<                     0f:c1:6e:24:14:02:3b:47:ff:00:e4:b4:9d:3e:b1:
<                     71:e8:4c:8c:5e:5e:ca:33:c8:de:90:2d:32:f4:39:
<                     d3:8f:cd:ff:7d:8e:f6:59:c5:97:ed:84:e9:81:97:
<                     81:1c:07:9e:40:e3:d3:67:62:98:6c:56:a5:da:02:
<                     ec:6a:be:bd:3e:01:52:d1:3a:26:11:23:bd:33:5e:
<                     18:8a:de:e6:cc:1d:56:0c:ad:b3:f6:0d:eb:fb:32:
<                     f1:10:d7:49:e4:91:bf:66:c9:0a:7b:e4:ce:e0:38:
<                     aa:8b:93:89:b7:f8:7c:ca:ca:52:d5:c9:3c:2c:9b:
<                     42:a2:57:bd:f7:5f:6e:98:1c:a0:e6:8a:ee:7e:5a:
<                     88:95
---
>                     00:c8:e2:b4:88:df:7d:bb:7e:5b:25:78:18:94:5b:
>                     e0:92:0a:b0:0d:98:fa:70:0f:93:15:f6:e1:6a:94:
>                     e4:83:0f:a7:13:1d:03:58:b1:55:dd:17:49:45:73:
>                     b2:ce:76:13:8c:c0:d7:fc:fa:b8:b5:93:9e:a8:f2:
>                     5c:41:b0:76:50:92:06:11:f6:3d:1c:45:52:78:12:
>                     6c:71:c6:a9:34:e0:63:4a:36:50:18:11:13:cc:63:
>                     c7:a7:f1:83:22:1f:20:6e:93:20:8d:d1:71:3d:79:
>                     a8:25:cf:60:9e:50:ae:db:d3:35:52:8d:04:8b:2c:
>                     12:01:48:1d:20:d5:77:62:6d:7b:92:c0:a3:65:1b:
>                     4d:bc:2c:6e:aa:3c:2f:49:38:b3:75:c6:08:8d:d3:
>                     38:bc:73:ed:8d:2e:3d:5f:fe:60:30:ca:cc:7c:b6:
>                     6d:20:45:5e:e3:c4:e6:86:46:57:ae:d1:ba:dc:a8:
>                     c5:7b:d7:ea:5e:5d:16:c5:5c:87:be:b7:92:df:c1:
>                     30:d3:de:23:da:c9:1d:e1:1b:09:d1:c6:37:c3:02:
>                     ed:7d:ff:56:d9:8b:95:c5:42:d1:4d:ba:d6:55:0e:
>                     43:c8:f5:9e:ba:46:b0:9c:9c:03:ee:f4:2b:31:c1:
>                     cf:7d:9c:1c:5d:21:65:78:34:aa:f8:10:05:9c:c9:
>                     5b:fb
36,39c36,41
<             X509v3 Key Usage:
<                 Certificate Sign
<             X509v3 Basic Constraints:
<                 CA:TRUE
---
>             X509v3 Key Usage: critical
>                 Digital Signature, Key Encipherment
>             X509v3 Extended Key Usage:
>                 TLS Web Server Authentication, TLS Web Client Authentication
>             X509v3 Basic Constraints: critical
>                 CA:FALSE
41c43
<                 DNS:ca.istio.io
---
>                 URI:spiffe://cluster.local/ns/default/sa/default
43,57c45,59
<          96:d1:c4:86:1c:80:b2:f7:b8:2b:86:cb:80:15:ed:1f:05:b3:
<          a3:a4:a9:17:37:40:7d:7a:4b:4a:1a:4e:24:db:50:34:44:5b:
<          de:a8:3a:89:41:90:75:8f:b0:03:60:69:99:29:0a:af:74:70:
<          ff:a0:a5:3f:9f:9c:08:6e:df:1a:87:0f:69:98:7e:73:ee:0d:
<          c6:6f:6c:b8:cb:99:05:90:ad:34:e7:98:38:c2:1f:bc:23:dc:
<          09:2f:bc:3d:0f:f4:84:2e:3f:d0:9d:d6:24:ac:c6:06:cb:1a:
<          68:cb:9f:27:1c:e0:14:f3:ed:0c:9f:7d:f2:46:3c:ae:54:4e:
<          82:17:52:69:5b:78:db:7f:e3:5c:80:18:9c:fd:d8:d3:99:fc:
<          4c:61:11:06:3e:d3:2d:db:48:55:bb:54:23:1d:c9:1c:0a:37:
<          3d:62:72:c0:0e:a6:10:3a:2f:14:c2:61:24:44:69:f6:c0:c7:
<          22:bd:41:6e:15:ca:d5:31:4d:67:a1:cd:1f:a8:08:9e:44:92:
<          32:db:c2:e0:fb:5e:8d:be:f8:f4:f4:da:78:f4:4f:17:b2:03:
<          ff:f7:aa:ff:70:07:f1:42:b9:d0:5d:d3:41:c2:e3:12:a5:94:
<          b0:95:27:68:52:a5:b4:e7:3e:44:08:f3:0e:49:5c:50:f7:86:
<          e1:8e:9e:30
---
>          14:7d:21:2d:6c:8b:66:3a:1a:c1:bf:6b:98:10:3e:28:d1:08:
>          1f:d1:72:5b:8f:ab:19:e4:e7:c2:06:df:7e:02:67:4e:c8:e1:
>          c6:12:ec:7d:16:ea:a4:b1:bc:14:0a:e9:2d:b4:29:62:c5:62:
>          93:4d:77:21:ee:63:b7:47:5c:94:03:52:d8:fc:58:16:f9:ef:
>          5d:b4:e6:ed:5b:3b:43:aa:eb:19:50:8b:ee:9d:3d:fb:89:48:
>          55:62:04:40:16:62:f2:5d:20:ea:de:fc:bd:10:ac:0c:de:f0:
>          34:fc:ca:c9:0f:45:23:27:4e:c3:d4:f4:25:b3:5b:d5:a1:2c:
>          b4:05:db:3f:8d:5c:2a:6e:08:18:c8:c9:bd:a1:ae:92:38:17:
>          68:c2:96:6b:f3:53:04:84:bf:12:0f:4c:c1:6f:50:3e:62:43:
>          ec:04:35:44:95:44:ab:04:48:4c:3c:5c:61:60:80:57:dd:fd:
>          35:90:28:5e:a4:fa:5a:90:a2:53:ba:52:d9:6e:b8:dc:85:20:
>          36:fc:e9:c3:c2:f9:d8:0b:2d:3c:e0:2e:0d:d4:2f:06:5a:1f:
>          ba:63:e8:19:92:9b:04:38:49:30:11:e2:ec:b8:ff:b5:88:a2:
>          30:c9:cb:35:d9:34:63:33:c2:a7:d7:22:5a:51:8a:25:f3:c5:
>          e9:6a:38:49

@kidiyoor

@liminw

@vilobhmm

Sorry this is a known issue on release V0.7.1. It is fixed by:
https://github.com/istio/istio/commit/3a4bad74995d7c0e6b33bd3ff82d2dfb18f4ab71
As a work around, you can use V0.6.0 Istio CA. Otherwise please wait for V0.8 to come out.

thanks  @myidpt. How different is 0.7.1 CA compared to 0.6.0.
Will rest of 0.7.1 istio components be able to work with 0.6.0 CA ?

Yes, the CA is pretty stand-alone from other components. It should work with other V0.7.1 components.

Hope this issue is get fixed in the Istio 0.8.0 version? Please confirm


image extension can't be loaded in fresh conda env with torchvision 0.13.1

🐛 Describe the bug
Hi,
Quick FYI that I'm getting this warning when installing torch and torchvision from a fresh conda env
/private/home/fmassa/.conda/envs/fairvit2/lib/python3.9/site-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: libtorch_cuda_cu.so: cannot
open shared object file: No such file or directory
  warn(f"Failed to load image Python extension: {e}")

This can be reproduced by doing
create -f conda.yaml

with the follwoing conda.yaml
name: bug_repro
channels:
  - defaults
  - pytorch
  - conda-forge
dependencies:
  - python=3.9
  - pytorch=1.12.1
  - torchvision=0.13.1
  - cudatoolkit=11.3
  - nvidia-apex=0.1
  - timm
  - pip

Versions
Python 3.9
PyTorch 1.12.1
TorchVision 0.13.1
CUDA 11.3

FYI @atalman , it looks like installing torchvision with apex leads to problems discovering libtorch_cuda_cu. Not sure if this is a problem with us or with apex though?


I want to take over the npm release of this package.

Is there something that needs changed?

<npmjs.com/toml-loader> invite maintainer, i am going to release.
My npmjs username: septs
https://github.com/NiceLabs/toml-loader new implementation

support webpack 4
enhanced exception handling
follow up on the <npmjs.com/toml> update

@nice-labs/toml-loader stage release:
https://npm.septs.me/#/detail/@nice-labs/toml-loader


Making lots of changes to get building on OSX to work.

I had some time to get this working. It builds and runs now on my machine with XCode 10.2 and OSX 10.14.5. I don't really know CMake, so sorry if it's a bit of a mess.
The only interesting changes were using Boost filesystem when std's isn't available, passing some hints for GLFW so the window could be created, and I had to modify the cursor fragment shader to remove gl_FragColor. I also set GLFW_COCOA_GRAPHICS_SWITCHING to true so it doesn't force a switch to the discrete GPU while it's running.

Hey. Many thanks for your contribution. I really respect this. It is currently 08 AM here and I am going to have time to look into it at about 08 PM tonight (including streaming on twitch ;)


Add a debugging compilation option for showing list of NAMs

If cmake is run with -DTRACE=ON, then some #ifdefs become active that make strobealign print the list of found NAMs for each query.
I find myself adding this type of output quite often for debugging purposes, and think it would be nice to have this as part of the code, disabled by default, but easily enabled.
CHUNK_SIZE is forced to 1 when tracing is on to ensure that SAM/PAF output comes right after the corresponding tracing output. (Otherwise you get the tracing output for all queries within one chunk follewd by all the SAM/PAF output for all queries in the chunk.)

approved


Various fixes

Codecov Report

Merging #162 (efd0d35) into master (730f285) will decrease coverage by 0.09%.
The diff coverage is 19.20%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   27.46%   27.37%   -0.10%
==========================================
  Files          73       73
  Lines       16105    16197      +92
  Branches      273      273
==========================================
+ Hits         4424     4434      +10
- Misses      11408    11490      +82
  Partials      273      273

Impacted Files
Coverage Δ

src/clj/skylobby/fx/root.clj
7.19% <0.00%> (-0.22%)
:arrow_down:

src/clj/skylobby/fx/players_table.clj
4.51% <1.81%> (-0.34%)
:arrow_down:

src/clj/spring_lobby.clj
11.34% <5.88%> (+<0.01%)
:arrow_up:

src/clj/spring_lobby/ui_main.clj
11.57% <25.00%> (+0.34%)
:arrow_up:

src/clj/skylobby/fx/battle.clj
51.68% <55.17%> (+0.03%)
:arrow_up:

src/clj/spring_lobby/client/handler.clj
38.20% <100.00%> (+0.09%)
:arrow_up:

src/clj/spring_lobby/util.clj
61.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730f285...efd0d35. Read the comment docs.


Help migrate Bohemia off the createRootDataStore API

Part of https://github.com/microsoft/FluidFramework/issues/9660
AC:

catalog all usages of createRootDataStore and _createDataStoreWithProps
migrate all found usages to aliasing

closed as duplicate ^


Randomize mint

Hey, this project is awesome, is there anyway to randomize the mint ?
So if a user mint several nfts, he don't gets the following numbers nfts, like for example #112, #113, #114 but #34, #427, #298 ?

Randomize your assets before uploading to candy machine.

Hey, thank you, how can i do this ?
Directly in the hashlips art engine ? or after it's generated, but it needs to keep each pear of (image, json) ?


Add Dark Mode

Dark mode is the a neccesity for every website. Can dark mode be added?

Dark mode is the a neccesity for every website. Can dark mode be added?

Can I try to work on this issue?
It can take a little time, is this a Problem?

Sure. No one is working on it at the moment.

@dephraiim Hello sir i can add dark mode so please assign it to me

Hi, I already changed my version to Dark Mode. Kindly assign me this issue.


Add test to check basic interactions with layer controls widgets

Fixes/Closes

Closes #
Description

References

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Hi @alisterburt, thank you for giving this a check! I think the problem comes from PySide2/6 not having the findChildren signature that supports passing a tuple of types (which seems like is only available for PyQt 5/6 bindings). Will push a fix for that :+1:

Looks great!
@kne42 any thoughts on this one? In particular, are there some other parts of the GUI you were thinking needed more automated testing?

Nice work! Thank you @dalthviz 🎉
If you can follow up on this suggestion that would be fantastic.


libp2p service (aka Daemon)

Some context on https://github.com/libp2p/interop/issues/1

This issue is here as placeholder for discussion around the libp2p service

I'm just gonna throw some brief notes here:

Environments

web browsers
daemons
desktop tools (e.g. network manager)
any program communicating over libp2p
linux kernel
core internet routers/switches (e.g. openflow)
mobile devices
embedded devices (home routers, raspberries, printers, toasters, etc.)

Daemon

Instead of IPFS's current daemon model, where you can mostly provide configuration only at startup, I'd like to do something closer to cjdns's daemon model. The daemon always starts with a bare-minimum configuration (key material, and the API address to bind to), and a user space tool is used to configure the daemon through the API.
This would give us hot config reloads, which are very important to have in networking software.

CLI examples

> libp2pctl node add foo
Created node
  /p2p/QmFoosPeerID

> libp2pctl start foo
Starting node
  /p2p/QmFoosPeerID
API listening on
  /unix/var/run/libp2p/foo/api.sock

> libp2pctl listen /ip4/<IP_ADDRESS>/tcp/4001
Loading transports
  /ip4
  /tcp
Swarm listening on
  /ip4/<IP_ADDRESS>/tcp/4001
Saving configuration changes
  ok.

# then the ipfs daemon uses the libp2p node api to bind its bitswap handler (unix socket or whatever) to the node
> libp2pctl bind /ipfs/bitswap/1.0.0 /unix/var/run/ipfs/bitswap.sock

> libp2pctl status foo
Node healthy
  /p2p/QmFoosPeerID
API listening on
  /var/run/libp2p/foo/api.sock
Swarm listening on
  /ip4/<IP_ADDRESS>/tcp/4001
Have 3 active protocols
  /libp2p/id/1.0.0 as internal
  /libp2p/kad-dht/1.0.0 as /var/run/ipfs/dht.sock
  /ipfs/bitswap/1.0.0 as /var/run/ipfs/bitswap.sock
Have 46 connections
  12 /ip4/tcp
  34 /ip6/udp
Have 67 open streams
  46 /libp2p/id/1.0.0
  21 /libp2p/kad-dht/1.0.0

@lgierth I'm working on a prototype of what you describe here now and should have something thrown together by tonight.

@lgierth I don't have as much done as I'd like due to some other projects taking too much time (grr), but here's my initial work: https://github.com/paralin/go-p2pd
A little demo of node creation: https://asciinema.org/a/zSIXd5at5WqPMKPN86i6sEucy

Nice going @paralin 👏🏽

@lgierth OK, small update: https://asciinema.org/a/3HEUSN35CXQWVtD4RmsISNUBX
Implemented:

node add
node start
node status
node list
node listen

@paralin that looks pretty sweet.
I have a slightly different approach in mind, that can accelerate the daemon work greatly. We could reuse the commands lib used in go-ipfs, and thus save the daemon from getting blocked by extensive API design. We know it works reasonably okay-ishly and we know its issues. It won't be a high-performance API as it should eventually be, but it'd be more than fine for a first HTTP-based iteration.

I have a slightly different approach in mind, that can accelerate the daemon work greatly. We could reuse the commands lib used in go-ipfs

So, yes, this will allow us to reuse a bunch of code. And yes, unifying an API and a CLI is an interesting and cool idea. However, evolving an API is tricky so I'd like to take some time to think through this. The commands library in go-ipfs has some significant drawbacks. Many of these can probably be avoided but we'll have to be careful.

It has poor error handling. We have two error paths, commands can theoretically return multiple errors, and we use duck typing to determine if something is an error or a result. However, the next release should improve this a bit. I'd like to remove the duck typing entirely before we start using it in a libp2p daemon.
It still has race conditions. It's getting better but many of the code paths in the commands library are convoluted and hard to reason about.
Poor performance. There are places where we end up parsing things twice for various reasons. These can be improved, it's just time consuming and hard to do without breaking other things (again, convoluted code paths).
It mixes a user interface with an API. This was kind of the point of the library but command-line argument parsing should be done by a client, not a server. This makes the API significantly less nice to use from another program (the primary usecase for the libp2p daemon). It also means that passing non-file binary objects is pretty damn difficult to impossible (without additional manual encoding).
It uses mime multipart encoding for directory uploads (makes it hard to program/script against if you want to upload multiple files). May not be an issue for libp2p but still baggage we need to carry.
It puts some of the arguments in the URL but allows others to be streamed in the body (newline separated).

Having implemented this in JS, I'm sure @diasdavid would like to chime in.

I was reading there was an intention this becomes part of the Linux Kernel - just wondering if that happened, of it happening maybe I might be able to help

There is now a daemon implementation (go-libp2p-daemon). There is no in-kernel implementation and it's not planned in the near future (but might be nice eventually).

There is a js equivalent here - it's largely used for interop testing.  Further discussion (if required) should happen there.

FYI I'm still working on a libp2p daemon - dynamically configurable, supporting flexible yaml files to configure the controllers - see Bifrost.
This is the continuation of the work I posted about in here in 2017 towards a libp2p "daemon" to share resources between other processes.
I see that go-libp2p-daemon is not actively being developed


fix: syntax path and char range tokens

I forgot about the char range thing when i fixed the syntax tokens.
and i think the path / looks better with the keyword.control (OPT 1) token, OPT 2 is using the keyword.operator.new token, i think OPT 1 is the most readable version, but let me know if you prefer OPT 2.

Option 1 is good 👍🏼


Temporary fix for table data not getting the latest value from UI

This PR fixes #11320
This is a temporary fix for the release and I'll investigating on what is actually causing the bug.

Just realized that this targeted fix won't work as this is a public API that's breaking. We need to block release until we find and root cause this behavior change in the API.

Coverage decreased (-0.0006%) to 36.028% when pulling 11b9be977c4be82d6cac8040e47b223d7da5e786 on aasim/fix/tabledatatemp1.20 into f109afb24221c3ede86f45815597df12ac76f316 on release/1.20.


Vote revealer question

When the votes are printed to chat, can other players see that or does it only show up for the player only?

local only


HttpResponseMessage RetryAfter header is unable to parse decimal values.

While working with MS Graph, I've found I'm being returned decimal retry-after header values. The HTTP spec says that Retry-After values as seconds in decimals are valid, but parsing with HttpResponseMessage.Add throws a FormatException. For example new System.Net.Http.HttpResponseMessage().Headers.Add("retry-after", "2.542"); but I think it's reasonable that this should be parsed correctly as per the HTTP spec? Obviously getting the ceiling of that decimal as an int is fine, but will cause unnecessary latency in a system.

The HTTP spec does not allow fractional values.

The value of this field can be either an HTTP-date or a number of
seconds to delay after the response is received.
 Retry-After = HTTP-date / delay-seconds

A delay-seconds value is a non-negative decimal integer, representing
time in seconds.
 delay-seconds  = 1*DIGIT

https://tools.ietf.org/html/rfc7231#section-7.1.3
The ABNF is 1*DIGIT which only allows digits and not the decimal point.  The term "decimal integer" indicates it is a base 10 integer.

Thanks for clarifying @darrelmiller, not familiar with ABNF so that makes sense now. In that case I need to go raise a bug with the Graph/Teams team.

@daverant This issue came to my attention via a thread involving Teams PMs.  So they are aware of the issue.


CSS: do not show origin of warning

Refs: https://github.com/Microsoft/vscode/issues/62049
Have the following css:
a {
	isidor: 5;
}

Notice the hover. There is too much redundant information here, why do we show [css.lint.unknownProperties] and [unkownProperties] at the end?
I would not expect this to be rendered as it feels like an implementaiton detail to me.

This is a regression on the diagnostics display.
1.28:

Insiders:

In both case, the diagnostics returned are:
const diagnostics = {
  code: "unknownProperties",
  source: "css.lint.unknownProperties",
  message: "Unknown property: 'foo1'"
}

@octref This is a feature and not a regression. Here is some context
Last milestone we started showing error codes in the problems view (https://github.com/Microsoft/vscode/issues/49215)

Some extensions like tslint were already showing error codes in the message (since they were not shown) and now it got duplicated but they could not remove the error codes from message because error codes are not shown in inline and hovers in the editor yet. So this milestone we also started showing them at all places we show errors.
https://github.com/Microsoft/vscode/issues/60749
Issue here is that the CSS diagnostics are having redundant information. source should just be css and not include additional information like error codes. Then the message looks as follows
[css] Unknown property: 'foo1' [unknownProperties']
This is way better than what it is now. I would leave up to you to remove or retain the error code.

I enjoy things lined up in the left, so I hope you can consider @joaomoreno's idea in #62370. I can also just not return code for lint diagnostics, since it's covered in the source.

My problem is: As someone who's writing a LSP, there is no place I can find information & track breaking changes on how each property is surfaced in the interface. This is true for Hover, Diagnostics, CompletionItem etc. This probably breaks my end-to-end test I have for Vue too.

Don't want to change back & forth, so waiting for #62370's discussion and moving to November.

I enjoy things lined up in the left, so I hope you can consider @joaomoreno's idea in #62370.

Sure, we can improve how to show source & code properties. But I do not think it is not related to this issue. This issue is about not to include additional details in source and use code for codes or rules.

I can also just not return code for lint diagnostics, since it's covered in the source.

Please do not do that. Source should be the origin of the diagnostic which is css in your case. Again, use code for codes or rules.

My problem is: As someone who's writing a LSP, there is no place I can find information & track breaking changes on how each property is surfaced in the interface. This is true for Hover, Diagnostics, CompletionItem etc. This probably breaks my end-to-end test I have for Vue too.

@dbaeumer I suppose above comment is for you.

@octref I see the point however from a pure LSP point of view we can only spec the data and not the rendering of it. There could have already been a client that renders the source and error code in which the UI would have looked bad.
The thing we can do in the LSP is adding comments that this data is usually presented in a user interface. So for diagnostics something like this:
	/**
	 * The diagnostic's code, which usually appear in the user interface.
	 */
	code?: number | string;

	/**
	 * A human-readable string describing the source of this
	 * diagnostic, e.g. 'typescript' or 'super lint'. It usually
	 * appears in the user interface.
	 */
	source?: string;

	/**
	 * The diagnostic's message. It usually appears in the user interface
	 */
	message: string;

This would make it more clear that someone has to think about not duplicating the information.

@dbaeumer

which usually appear in the user interface.
This is not clear to the user. Where in the interface? How is it presented? Monospace font or default UI font?

I would appreciate an illustration that shows association between the data and the UI. Here's a simple one I made in 1 minute:

I think this is a doc issue: We should document the UI behaviors of our LSP Client / VS Code UI, and when we introduce changes, inform people who depend on it.
Discussed with @sandy081. We'll change CSS back for this milestone and look for a way to improve the UI display in the next milestone.

@octref I see your point but the only thing we can do in the LSP to improve the doc and give examples on how the values of these strings should usually look like (in terms of their content). The goal of the LSP is to not define any UI. So if a client decides to never render an error code of a diagnostic in the UI and does this consistently this is fine with the LSP spec. If a client decides to render the source in a post-fix fashion this is fine as well. The LSP spec can not be a UI guideline for client tools.
Thinks are however different for the VS Code API.

Thinks are however different for the VS Code API.

Exactly, my point is it's hard to track the changes in VS Code client implementation of LSP. As a language extension author, the data I'm sending back are the same but the user experience are changed. Sometimes it's good, like the file icon completion when CompletionItemKind is File, some changes might result in undesirable behaviors for users, like this one.

But then I think this is not LSP specific. An extension using directly the VS Code language API is affected the same way by this. I didn't change any VS Code LSP client code :-)


explore alternative networking solution

Currently we are using retrofit for making network calls to replicate.com.  Ktor and Kotlinx-serialization for networking.
@Lamouresparus @mayorJAY


Invalid shadermodel/shadertype values when running D3D12Raytracing samples

When trying to run the D3D12Raytracing samples I get the following errors:

I have updated the windowsSDK to 10.0.17763, added the lastest binaries (1.5-dxr), updated windows to version 1809, and updated my nvidia (GTX1080) drivers to the lastest version (418.81). But the problem still persists, even on a fresh download of the master branch. What am I missing?

You also need an updated Visual Studio - version 15.8.4 or higher as per https://github.com/Microsoft/DirectX-Graphics-Samples/blob/master/Samples/Desktop/D3D12Raytracing/readme.md#requirements.

Thank you! Figured it was something obvious like that..


Moved ES2015 support to Babel transform-runtime.

Fix for issue #174
Modified build configuration to replace Babel-Polyfill with the Babel transform-runtime plugin to provide polyfills without polluting the global namespace.

Ok if not necessary, closing.


[KBFS-2747] Quick and dirty 'fixes' to unblock mobile

I don't expect these to be the final fixes.
In this PR:

Enable the dirty block cache for InitMinimal
Enable the node cache for InitMinimal
Enable the metrics registry for InitMinimal, because why not.

We have a lot of unguarded access for the dirty block cache and the node cache. I suspect that we need the node cache because of GetOrCreateRootNode, but the dirty block cache can probably get a no-op version of itself that does nothing.

@strib: I'm happy to defer to any and all recommendations you give. For now I'm testing with this because it's needed to make the native app not crash. But I don't expect to merge this at all.

Ah cool, thought you were looking for a review to merge.  These seem totally fine for testing a branch, and are a good starting point for doing a proper KBFS-2744 someday.

Yeah part of the reason I tagged you for review is to surface the parts that are actually crashing on mobile, so you know where to go with KBFS-2744.

Not needed any more since the constrained build mode has been introduced.


Integrate with Codacy/ Code Climate

Integrate with Codacy/ Code Climate

Blocker from the Andela Team

Finally done


How to use it?

请问如何使用？https://github.com/kagurazakasanae/MelonLoader-YuanShen该项目已经不维护，加载失败。求详细的使用方法。
How to use it? https://github.com/kagurazakasanae/MelonLoader-YuanShen The project has not been maintained, loading failed. Find detailed usage methods.

dm me on discord portra#3319


Show Indication of Hover for Status Bar Items

https://github.com/lapce/lapce/commit/a92b3f273d5f4e07360994f5ea43d06ed05598f3 Added the ability to click on the status bar items. It would be good to show a visual indication on hover (probably changed background like the left sidebar file explorer), rather than just changing the mouse cursor.

Ah, I see. Both of the non-default themes I typically use don't seem to have a different colors set up for background and hover. Oops.


define github token as credential and update readme

Great, thank you!

Sorry, i forgot to add the documentation...
Thank you anyway


List install instructions for Foxy on main install page

Just a thought: should be maybe swap the column order?

Just a thought: should be maybe swap the column order?

Changing the order has been proposed before: https://github.com/ros2/ros2_documentation/pull/320
The discussion didn't lead to any conclusion though. I don't have a preference.

Feel free to update the order in a follow-up.


Load RDF (textbox input) discards root subject

Describe the bug
When I go "Load RDF" and I enter the following data:
<http://example.com/foo> <http://id.loc.gov/ontologies/bibframe/mainTitle> "foo"@en .
<http://example.com/foo> <http://sinopia.io/vocabulary/hasResourceTemplate> "profile:bf2:Title:AbbrTitle" .
<http://example.com/foo> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/AbbreviatedTitle> .

and I set http://example.com/foo as the root.
Then when I click "Submit" and preview rdf, the root subject (http://example.com/foo) has been lost.

This seems confusing and I'm not sure what a good solution is.  Either add validation or remove "Load RDF"

@justinlittman is this still relevant given planned work on Load RDF for Derive?

Yes. I think the current behavior is correct (discarding the URI). However, I think that this happens should be made clearer to the user.
Perhaps in general, we should inform the user when the URI is discarded (e.g., when loading from RDF, when deriving). But defer to your / @astridu judgment.

is the URI ever not discarded?

If we are loading a resource from Sinopia (e.g., via search), the URI is retained. If we load from elsewhere, it is discarded.

why do we retain it when loading resource from Sinopia?

The assumption is that you are finding an existing Sinopia resource, loading it, making changes to it, and saving it.

no with the Load RDF tab the assumption is you are just copying in data to open a new resource, not the resource with the URI, right? to find something and edit it more you use the search tab. was my understanding.

Yes. We've entirely managed to miscommunicate. Currently:

search=retain URI
load by RDF=drop URI
which I think is what we were both saying.

so purpose of this ticket is: add UI text that says root subject URI is ignored?

Or more generally, make it clear to the user what is happening.

Load RDF tab needs redesign (incl to support https://github.com/LD4P/sinopia/issues/258
@astridu can you do a new design? @justinlittman has some ideas about it so please consult with him. thanks!

NOTE: the reason we need to redesign this sooner than later is that we are using the Load RDF path as the way to quickly show how to load external data (https://github.com/LD4P/sinopia/issues/95)

See https://github.com/LD4P/sinopia/issues/258#issuecomment-536746391 for design.