Multiple services and multi modules.

Question.
TLDR

Multiple services with multi modules doesn't work well if you define a new service in the common module with no sources (no fragments) and wants to use it in a feature module. It'll work just fine if you define a dumb Fragment and the sources will be generated in the feature module.

Hi folks,
I've been using the multi modules feature and it have been great by now. In my setup I've the following configuration:
A shared module containing common Fragments and Types. But this module also defines the following services:
// shared build.gradle
apollo {
   generateApolloMetadata.set(true)

    // there is also rootPackageName and sourceFolder
    // because each service will have its own source folder like
    // com.myapp.shared.apione/fragments/*

    service("apiOne") {
        schemaPath = "../../schemas/apiOne.json"
    }

    service("apiTwo") {
        schemaPath = "../../schemas/apiTwo.json"
    }

    customTypeMapping = [] // ...
}

Now each feature module is able to depends on this shared module and get access to the generated Fragment when necessary. Each feature module is configured like so:
apollo {
    // schema is only defined in shared module

    // each feature defines services they use so they can define their own queries/fragments
    service("apiOne") {
        rootPackageName = "${featurePackage}.api.apione" // com.myapp.dashboard
        sourceFolder = "com/myapp/api/apione/"
    }

    service("apiTwo") {
        rootPackageName = "${featurePackage}.api.apitwo" // com.myapp.dashboard
        sourceFolder = "com/myapp/api/apitwo/"
    }
}

They also depends on project(":shared") and uses apolloMetadata from it.
By doing this we have the following advantages:

We can share common fragments and types across multiple modules
We can also shared our schemas files which means that our feature modules don't need to have it anymore.

First question: is this configuration right to integra multiple services with multi modules? The documentation does not says much about it and in the second question below I explain a problem we're having with it.
Second question: we introduced a new service and something bad happened: we aren't able to generate sources of the feature modules because apollo couldn't provide enough information about the new service and this is... strange.
This happened because our shared module didn't have any GQL files inside the source folder of the new service. If we put a dumb Fragment or Query inside the source folder of the new service we are able to generate the sources for the features modules.
Thank you all in advance.
Best,
Lucas.

The dependency graph is the following:

Ah, good catch! And thanks for the very detailed bug report. I made a reproducer there: https://github.com/martinbonnin/apollo-android-samples/tree/main/multi-modules-multi-services
Indeed there's something wrong with the Gradle config so that when there's no graphql file, the task will be completely skipped with NO-SOURCE and will not write the metadata. As you found out, the workaround is to add an empty .graphql file in the shared module. The longer term fix is to refactor a lot of the Gradle logic (see also https://github.com/apollographql/apollo-android/pull/2668)

Ah, good catch! And thanks for the very detailed bug report. I made a reproducer there: https://github.com/martinbonnin/apollo-android-samples/tree/main/multi-modules-multi-services
Indeed there's something wrong with the Gradle config so that when there's no graphql file, the task will be completely skipped with NO-SOURCE and will not write the metadata. As you found out, the workaround is to add an empty .graphql file in the shared module. The longer term fix is to refactor a lot of the Gradle logic (see also #2668)

I see! Thank you for your response, Martin. The short-term fix is fine and I'll go with it.
This indeed solved my problem. I thought I did something wrong while setting up the shared module.
Thank you again!


feat(jsii): compress .jsii file under feature flag

Introduces a flag to be set in package.json:
"jsii": {
  "metadata": {
    "jsii": {
      "compress": true
    }
  }
}

That will emit a .jsii.gz compressed assembly file rather than the uncompressed .jsii file. As part of this PR, the jsii logic that loads assembly files need to be updated to recognize both .jsii and .jsii.gz files.
Closes #3561

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I don't think the flag needs to be buried under jsii.metadata.jsii.compress (and also, that name isn't specific enough).
I'd rather:

Expose feature via CLI argument --compress-assembly, which defaults to false (i.e: --no-compress-assembly)
POSSIBLY allow configuring it in package.json in jsii.compressAssembly (also defaults to false for obvious reasons)

I also wonder whether we should plan for a "compatibility" mode that'll emit BOTH compressed and uncompressed assemblies... I currently lean towards "no", but... I don't know... This feels like it could benefit from an RFC / impact analysis, so we don't surprise people too much...

superseded by #3570 and another PR coming soon.


Description and tags for shipping packages

Resolves #5463

:shipit:

Opened new PR (https://github.com/aspnet/EntityFramework/pull/5611) with further changes discussed in this PR.


The stunner-gateway-operator-controller-manager is failing to start due to the Dataplane CRD not being installed before the controller starts.

I installed the dev version of stunner-gateway-operator   using helm(Chart version stunner-gateway-operator-dev-0.15.0 ) , and now stunner-gateway-operator exited abnormally
Here's my logs
 2023-08-17T10:29:57.997819374Z  ERROR   ctrl-runtime.controller-runtime.source.EventHandler     if kind is a CRD, it should be installed before calling Start   {"kind": "Dataplane.stunner.l7mp.io", "error": "no matches for kind \"Dataplane\" in version \"stunner.l7mp.io/v1alpha1\""} sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1.1         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/source/kind.go:63 k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func1         /go/pkg/mod/k8s.io/apimachinery@v0.27.2/pkg/util/wait/loop.go:62 k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext         /go/pkg/mod/k8s.io/apimachinery@v0.27.2/pkg/util/wait/loop.go:63 k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel         /go/pkg/mod/k8s.io/apimachinery@v0.27.2/pkg/util/wait/poll.go:33 sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/source/kind.go:56 2023-08-17T10:30:07.988854671Z  ERROR   ctrl-runtime    Could not wait for Cache to sync        {"controller": "dataplane", "error": "failed to wait for dataplane caches to sync: timed out waiting for cache to be synced for Kind *v1alpha1.Dataplane"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.1         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:202 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:207 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:233 sigs.k8s.io/controller-runtime/pkg/manager.(*runnableGroup).reconcile.func1         /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/manager/runnable_group.go:219 2023-08-17T10:30:07.988926582Z  INFO    ctrl-runtime    Stopping and waiting for non leader election runnables 2023-08-17T10:30:07.988983143Z  INFO    ctrl-runtime    shutting down server    {"path": "/metrics", "kind": "metrics", "addr": "<IP_ADDRESS>:8080"} 2023-08-17T10:30:07.989002223Z  INFO    ctrl-runtime    Stopping and waiting for leader election runnables 2023-08-17T10:30:07.989015373Z  INFO    ctrl-runtime    Shutdown signal received, waiting for all workers to finish     {"controller": "udproute"} 2023-08-17T10:30:07.989020444Z  INFO    ctrl-runtime    Shutdown signal received, waiting for all workers to finish     {"controller": "gateway"} 2023-08-17T10:30:07.989024744Z  INFO    ctrl-runtime    Shutdown signal received, waiting for all workers to finish     {"controller": "node"} 2023-08-17T10:30:07.989028694Z  INFO    ctrl-runtime    Shutdown signal received, waiting for all workers to finish     {"controller": "gatewayconfig"} 2023-08-17T10:30:07.989053724Z  INFO    ctrl-runtime    All workers finished    {"controller": "gateway"} 2023-08-17T10:30:07.989058654Z  INFO    ctrl-runtime    All workers finished    {"controller": "udproute"} 2023-08-17T10:30:07.989062284Z  INFO    ctrl-runtime    All workers finished    {"controller": "gatewayconfig"} 2023-08-17T10:30:07.989066294Z  INFO    ctrl-runtime    All workers finished    {"controller": "node"} 2023-08-17T10:30:07.989070174Z  INFO    ctrl-runtime    Stopping and waiting for caches 2023-08-17T10:30:07.989671422Z  INFO    ctrl-runtime    Stopping and waiting for webhooks 2023-08-17T10:30:07.989691322Z  INFO    ctrl-runtime    Wait completed, proceeding to shutdown the manager 2023-08-17T10:30:07.989718533Z  ERROR   setup   problem running manager {"error": "failed to wait for dataplane caches to sync: timed out waiting for cache to be synced for Kind *v1alpha1.Dataplane"} main.main         /workspace/main.go:179 runtime.main         /usr/local/go/src/runtime/proc.go:250
So what  the Dataplane crd is 🤔

CC: @davidkornel
Thanks for the report. I'm afraid this is a known issue: the dev Helm chart does not install the recently introduces Dataplane CRD. Until we sort this out, you can work around the problem by cloning the repo and issuing make install deploy in the root dir. But I hope we can settle this in ASAP.

Okay ~


UnicodeEncodeError: 'charmap' codec can't encode character '\u0414' in position 102: character maps to

Thanks for fixing that last one.  Did some more road testing and found this one.
Looking for old dir at .\stls\alphaflight83 designs\Wedding-Favor-Heart-Pendant
Traceback (most recent call last):
File "D:\thingygrabber\thingy_grabber.py", line 661, in
main()
File "D:\thingygrabber\thingy_grabber.py", line 649, in main
Designs(user, args.directory, args.quick).download()
File "D:\thingygrabber\thingy_grabber.py", line 241, in download
RC = Thing(thing).download(self.download_dir)
File "D:\thingygrabber\thingy_grabber.py", line 463, in download
fl_handle.write("{},{},{}, {}\n".format(fl.link, fl.name, fl.last_update, ba
se_link))
File "C:\Program Files\Python38\lib\encodings\cp1252.py", line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u0414' in position
102: character maps to

Hmmm. Looks like I need to sanitise filenames


Could not read PGP secret key

https://github.com/duckie-team/duckie-quack-quack/actions/runs/3170799708/jobs/5163656121#step:22:350

FIXED! 🥳
https://github.com/duckie-team/duckie-quack-quack/actions/runs/3171211550/jobs/5164438325


[Fixed in GH-6052] Safari Firefox: Missing Visual Focus on My Account: Close Account

Chrome: ✔ (note: button focus border is barely visible)
Firefox: ✔ (note: button focus border is huge)
Safari: ❓

Chrome: OK
Missing keyboard accessibility & visual focus on:

Cancel button on Firefox
Cancel & Close Account buttons on Safari

Tested on dev3.

Chrome ✅
Firefox ✅
Safari ✅


Sym link?

In the readme you talk about how you symlink the dot files into your home directory. When I do this I'm unable to get terminal coloring, etc , and a few other things working. How are you symlinking exactly? I've tried a few methods, and the only way I have it working is by directly copy & pasting.

The README says:

You can clone the repository wherever you want. (I like to keep it in ~/Projects/dotfiles, with ~/dotfiles as a symlink.) The bootstrapper script will pull in the latest version and copy the files to your home folder.

So assuming you decide to clone into ~/Projects/dotfiles you would run ln -s ~/Projects/dotfiles ~/dotfiles"

Yeah. I did that. And I had .osx didn't run properly. (terminal colors
didn't install) I assumed that was a path issue. I removed $HOME and that
had zero effect. Quite a few other things didn't work either.
On Thu, Mar 26, 2015 at 3:41 PM, Gareth Lewin<EMAIL_ADDRESS>wrote:

The README says:
You can clone the repository wherever you want. (I like to keep it in
~/Projects/dotfiles, with ~/dotfiles as a symlink.) The bootstrapper script
will pull in the latest version and copy the files to your home folder.
So assuming you decide to clone into ~/Projects/dotfiles you would run ln
-s ~/Projects/dotfiles ~/dotfiles"
—
Reply to this email directly or view it on GitHub
https://github.com/mathiasbynens/dotfiles/issues/516#issuecomment-86687003
.

--

Brian


Wrong parameter used in FindByNameAsync method of Microsoft.AspNetCore.Identity.EntityFrameworkCore.RoleStore

/// <summary>
        /// Finds the role who has the specified normalized name as an asynchronous operation.
        /// </summary>
        /// <param name="normalizedName">The normalized role name to look for.</param>
        /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
        /// <returns>A <see cref="Task{TResult}"/> that result of the look up.</returns>
        Task<Role> IRoleStore<Role>.FindByNameAsync(string normalizedRoleName, CancellationToken cancellationToken)
        {
            cancellationToken.ThrowIfCancellationRequested();
            ThrowIfDisposed();
            return Roles.FirstOrDefaultAsync(r => r.NormalizedName == normalizedName, cancellationToken);
        }

should be:
/// <summary>
        /// Finds the role who has the specified normalized name as an asynchronous operation.
        /// </summary>
        /// <param name="normalizedName">The normalized role name to look for.</param>
        /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
        /// <returns>A <see cref="Task{TResult}"/> that result of the look up.</returns>
        Task<Role> IRoleStore<Role>.FindByNameAsync(string normalizedName, CancellationToken cancellationToken)
        {
            cancellationToken.ThrowIfCancellationRequested();
            ThrowIfDisposed();
            return Roles.FirstOrDefaultAsync(r => r.NormalizedName == normalizedName, cancellationToken);
        }

The normalized **role** name to look for.

Sort of. The XML documentation is wrong, The function parameter is correct :)

This is resolved in 1.1


Git Version Not Updated On First Request

This addresses issue #439 along with some other issues.  This PR was originally addressed just to fix a bug I found where the first request to spring cloud server after a git update results in the prior version number being returned along with the new config.  However, during further testing, I realized that the fix was only partial.  Here is a list of issues it resolved...

SCCS would return an incorrect version on the first request after the following use cases.

An update to an existing branch on the Git server.
When retrieving a tag the version would be null
When a hardReset was done due to a merge error.

SCCS would return a NoSuchLabelException when requesting a tag or branch that was created after the initial clone. #439

I have also added some easy setup code to create tests which operate off a local and remote repository which allows for more robust testing of "real world" git scenarios.  I have also added many new unit tests to cover these use cases.

Current coverage is 68.82% (diff: 100%)

Merging #538 into master will increase coverage by 0.01%

@@             master       #538   diff @@
==========================================
  Files            61         61
  Lines          2068       2069     +1
  Methods           0          0
  Messages          0          0
  Branches        345        345
==========================================
+ Hits           1423       1424     +1
  Misses          505        505
  Partials        140        140

Powered by Codecov. Last update 25b25fe...d5f4d8e

Awesome test BTW

@spencergibb - requested comment is done.  Please review.

@ryanjbaxter and @spencergibb
After doing some more testing with this fix I discovered some uncovered use cases where this fix didn't return the correct version. Specifically, the system would return the prior version (with correct config) on the first request after the local repo was pulled.
While looking into this I also discovered why new branches/tags were not showing up if they were created after the initial clone as described in #439. The reason was twofold.

Since checkout was being called prior to the pull, any new branches or tags didn't exist locally so it would throw a NoSuchLabelException.
The JGit pull doesn't offer the ability to add a --tags so even if we did the pull prior to the checkout it still wouldn't see new tags.
The fix was to first do a fetch prior to the checkout (unless shouldPull is false) so we can see the new tags/branches.  We also no longer do a pull, but instead do a separate fetch(so we can add the --tags option) and merge.  A pull is basically just a fetch and merge so this is fine.

Fixing both issues were fairly intertwined so I decided to submit this as one PR.
As an added bonus I have added some good test setup code to make testing git calls with a local repo that replicates with a remote repo we can make changes to.  This makes the unit test more "real".  Several new unit tests were added to cover server-side git changes.

@rlynch
In your last comment, you mention you do a separate fetch allowing you to add the "--tag" flag but I do not see this in your code (the TagOpts.FETCH_TAGS option is not set on the FetchCommand). As a consequence, a moved tag will not be fetched from the remote repo.

Wow, it was included in my brain. I will add it along with a test case. Thanks for pointing out my miss!

@Krustie101 - TagOpts.FETCH_ALL added to fetch and unit test extended to cover this case.  Thanks again for finding this.

@rlynch
Thank you for putting in the effort to improve the config server. Much appreciated!

@spencergibb @ryanjbaxter - Guys, any comment(s) on this?

@rlynch I haven't had a chance to review the new changes. It's in my queue.


some question about curriculum training

Hello, it is very nice work! I have some question about  curriculum  training.
I have attention that the line 239-242 in train_gssl.py，that mean every loop in task_type_list you should build a new network model in the code ?  And I have no find current loop training loading last loop saved weight?
this way can promise the model learning easy to hard?
Looking forward to your reply.

Hi. Yes, when there is better estimate of pseudo labels, the model will be trained from scratch, otherwise the wrong pseudo labels from last iteration may harm the model. And this is not something new in our curriculum strategy, but a common practice of self-training. Hope I answered your question.

Thank you for your reply. I have clearly understood this principle.


Fix abp_pcap_detection example

Description

Work-around for change in cudf introduced by https://github.com/rapidsai/cudf/issues/10226
Fix handling of indexes and offsets in examples/abp_pcap_detection/abp_pcap_preprocessing.py
Cudf will throw a different exception on a series of strings than a list of strings

fixes #790
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

/merge


On the Japanese site, User.csv has the owner written, but Japanese was not available

It seems that Japanese cannot be used in the Owner or Member column of user.csv, but since it has been translated on the ja-jp site, the user was not added to the site as it was.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe932bdb-d43e-356a-2c61-5d0f5c895695
Version Independent ID: fe932bdb-d43e-356a-2c61-5d0f5c895695
Content: Deploy teams at scale for frontline workers in Microsoft Teams - Microsoft 365 for frontline workers
Content Source: microsoft-365/frontline/deploy-teams-at-scale.md
Service: microsoft-365-frontline
GitHub Login: @LanaChin
Microsoft Alias: v-lanachin

@TinaMcN Please help. Thanks

Including @MartinOersted to help with this.

Please open a bug as per previous requests. If you cannot maybe ask Tina Burden.

@tiburd Please help. Thanks

Thank you for submitting this localization issue.
I submitted a translation bug: 233809
I'm closing this issue because the Global Services team will handle it from here.


Add a function to get the list of commands as string and array.

Syntax:
SqCommand.List();           // Should return a string with all the commands.
SqCommand.Collect();     // Should return an array with all the commands.
Example of usage:
print(SqCommand.List());
print(SqCommand.Collect());
Output:
cmd1, cmd2, cmd3,.....
["cmd1", "cmd2", "cmd3",....]

I haven't added a method to create them as a list in a string but I've added the means necessary to achieve it by script.
The two new methods of the command manager to obtain all command listeners as some sort of list:
local array_of_listeners = mycmdmanager.GetArray();
local table_of_listeners = mycmdmanager.GetTable();

The benefits of each is that the array will contain them in the same order as the manager stores them, whereas the table might sort them by name. Also, the array could also have them sorted by name if before retrieving them, the Sort() methods is called on the manager.
The third method is to iterate all command listeners with a callback:
local str = "";
mycmdmanager.Foreach(this, function(listener) {
    str += listener.Name;
    str += ", ";
});


Added models sanity check for ES6 classes.

A tiny change that would go along with standardhealth/shr-es6-export#9.

Closing this PR since I merged the commit into the existing pull request #63 (since this commit depends on the updated version of shr-es6-export).


Adds caching to avoid hitting Twitter API Rate Limits

Hello Anthony,
Thank you for this PR, that was in the TBD, so it's very welcomed :-)
https://wiki.jasig.org/display/PLT/EsupTwitter+Roadmap
Tested quickly, it seems to work well.
-> I'm going to merge this PR directly.
I will next modify just two little things :

if I understand your doc, setting maxElementsInMemory to 10 seems too low - I hesitate to put directly 100 as the default value.
log4j : I have to check but org.springframework.web in debug mode is too verbose for example ...


Depth of conv layers compared to DCGAN paper

Hi Taehoon,
Just to be sure, the number of filters in your implementation is half of those in the original paper. For example, with default gf_dim=64 the first layer of the generator has 512 instead of 1024 as in the original paper.
Is this intentional?

I also found this. The dimension of first layer - fully connected layer for generator is 4x4x512 instead of 4x4x1024 as described in the paper. Are there any special reason? Thanks. @MustafaMustafa @carpedm20


Update deps

This PR updates some dependencies to resolve the following issues:

It appears that nokogiri logic was removed in 20dad91035a10c84f68608b2b1aba8f32f226153 but the dependency wasn't removed.
github-markdown has been deprecated. html-pipeline now uses commonmarker.

Thank you!

Released as 0.5.0.


Fix node-gyp build on Windows

Summary
The issue with the Windows node-gyp build seems to be related to the headers not being properly downloaded/populated. This PR pre-populates them which seems to fix the issue.
NONE

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/22132
https://circleci.com/gh/mattermost/desktop/22131
https://circleci.com/gh/mattermost/desktop/22130


Add node 6

This includes upgrading fh-messaging and fh-metrics to Node 6
Node 6 support:

Update engines to node 6.9
Change ^ to ~, and * to specific version
Replace geoip with geoip-lite due to node-gyp error when doing npm install
Add countries-list to fill in missing data from geoip-lite's output
Build script updated to build in Node 6: http://bob.feedhenry.net:8080/job/fh-messaging_pullrequests/configure

JIRA: https://issues.jboss.org/browse/RHMAP-16212

retest this please

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

@rachael-oregan yes since the dependencies are updated

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

retest this please

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

retest this please

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

SonarQube analysis reported 2 issues:

 1 major
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Refactor this code to not nest more than 3 if/for/while/switch/try statements.

Hi! Closing this PR as it seems stale. If it's still relevant, please rebase and feel free to re-open. Thanks!


Parsing error: Type expected

Before You File a Bug Report Please Confirm You Have Done The Following...

[ ] I'm using eslint-plugin-astro. (*.astro file linting does not work with the parser alone. You should also use eslint-plugin-astro with it.)
[X] I'm sure the problem is a parser problem. (If you are not sure, search for the issue in eslint-plugin-astro repo and open the issue in eslint-plugin-astro repo if there is no solution.
[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.49.0
What version of eslint-plugin-astro and astro-eslint-parser are you using?

<EMAIL_ADDRESS><EMAIL_ADDRESS>
What did you do?
Running eslint --ext .js,.ts,.astro .

Configuration
{
	"root": true,
	"extends": [
		"eslint:recommended",
		"plugin:sonarjs/recommended",
		"plugin:unicorn/recommended"
	],
	"parserOptions": {
		"ecmaVersion": "latest",
		"sourceType": "module",
		"extraFileExtensions": [".astro"],
		"project": "tsconfig.json"
	},
	"overrides": [
		{
			"files": ["*.ts"],
			"extends": [
				"plugin:@typescript-eslint/recommended",
				"plugin:@typescript-eslint/strict"
			],
			"rules": {}
		},
		{
			"files": ["*.astro"],
			"parser": "astro-eslint-parser",
			"parserOptions": {
				"parser": "@typescript-eslint/parser"
			},
			"env": {
				"browser": true
			}
		},
		{
			"files": "*",
			"extends": ["prettier"]
		}
	]
}

---

---

Hi

What did you expect to happen?
Type checking astro frontmatter
What actually happened?
error  Parsing error: Type expected
Link to Minimal Reproducible Example
On it, buts simply a astro svelte starter with.
Additional comments
No response

When I remove "project": "tsconfig.json" it works... i don't know if this is intended?


1.9.0

Fixes #2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This also moves to the sdist as the source, this will automatic updating of requirements.

CI is here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=366794&view=results

CI is failing as requirements.txt is not part of the archive :(

Made an upstream PR: git commit --amend --no-edit --signoff

CI https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=366803&view=results

🎉


Release/rare screeching mole

Try out this version of the Hiro Wallet - download extension builds.

https://youtu.be/riu7rA5YB5o?t=121

https://youtu.be/riu7rA5YB5o?t=121

That is scary! 😆

@alter-eggo I am seeing some odd behavior here in the sip10 send form testing the release build. The amount field symbol and selected asset field flash STX before resolving ...and one time it stuck for me on STX even though I was trying to send DIKO tokens.


Are there any way to import current images and container already created with boot2docker?

They should be reflected on Kitematic automatically. Are you not seeing them?

No they don't, check it

Right now we don't show containers without exposed ports.
For CLI containers without ports (like hello-world), this is more or less a bug. As of Kitematic 0.5 that will be changed - all containers run from a tagged image (pretty much any container you'd ever want to see will be shown).
Thanks for the issue!

This was fixed in 0.5. Anything done on CLI is reflected in Kitematic now :smile:
Note that 0.5 now uses machine. We even have a little terminal button in the bottom-left of the app you can use to open a docker-ready terminal on your mac.
That said, you can't directly important from a boot2docker vm yet via machine, there's a ticket open for that IIRC. Look out for this soon!
Jeff


 It only appears to happen to columns that are text whereas numeric columns it works fine
Steps to Reproduce
Table has ~300 columns, but the query looks something like
select colA, colB['foo'] as "bar', colB['acme'] as "abc", colB['aaa'] as "bbb".... order by "bar" asc nulls first

Actual Result
This is the error returned
NotSerializableExceptionWrapper[class_cast_exception: class org.apache.lucene.util.BytesRef cannot be cast to class java.lang.String(org.apache.lucene.util.BytesRef is in unnamed module of loader 'app'; java.lang.String is in module java.base of loader 'bootstrap')]

Expected Result
Query to work

Thanks for the report. I believe this was fixed with https://github.com/crate/crate/pull/13235. Could you try with the latest version?

Will look into upgrading, just not sure if/when that'll occur.

@mfussenegger  can you backport this to 4.8.4?

@mfussenegger can you backport this to 4.8.4?

We usually backport to older versions only if there is an active subscription to our services. If you have any concerns, please don't hesitate to reach out to me georg (at) crate.io or open a request at https://support.crate.io/. Perhaps we can work together to find a solution.

@bputt-e is there any update on this? have you tried upgrading?

@matriv not yet, plan to upgrade it mid april

upgrading resolved our issue

Thx for letting us now @bputt-e !


option to control toast size

Summary
It would be nice if there would be an option in the component api to control the size of the toast (width for example).
Development and design required.
Justification
In some cases the toast can look stuffed with content (with fixed width as it  is now), for example if there is a lot of text in it and also if some html is provided in the message property. It may be a good idea to control the width for example if there is a lot of content inside.
Additional information
This first image would be from the old design and there you can see that we had different width and also "Connection problems" part of the text was provided to toast via heading property in the configuration.
The second image is the new implementation and there you can see that it looks maybe a bit stuffed (this was also one of the remarks in previous review). Heading was added via message property though but it would be nice to have separate heading property so that we could apply some logic to it.

@stefanbukovski can you show us an example?

was fixed with 10.22.1
https://github.com/baloise-incubator/design-system/commit/d04f3a557c43a2e2d17f5a5c2a2a14a67d530612


cleanup - removed duplicate const MAX_ACTUATORS definition

There are two dupliacate const definitions, one global and one in the class, which is singletone anyway.
The definition is duplicated to _max_actuators

Keep the upper case naming for a constant? MAX_ACTUATORS

Hmm, upper case with underscore doesn't look quite right, but let's go with it for now.
This is probably a good example of why we need a coding standard for naming constants, member variables, etc.
Thanks @BazookaJoe1900

Google c++ style guide? https://google.github.io/styleguide/cppguide.html#Constant_Names

Sorry about the bad coding standard.. I was rushing doing the pr.
I will fix that.... but in two days. Wait with the marging

No need to apologize, the problem is there's no (written) coding standard

It's still nice to get rid of the duplication and easy to change later. Thanks again.


Adding Subgroup support

What type of PR is this?
/kind feature

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #115
Special notes for your reviewer
Does this PR introduce a user-facing change?

Still missing

Adding annotation for the exclusive topology of subgroups
Changing the SubGroupSize label to be an annotation instead

/ok-to-test

Let me read the KEP first before back to the PR.

/retest

/retest

/retest

/retest

Will review later.

/retest

btw, did you run "make generate" to update the client go as well?

/retest

I had not, just ran it before the latest commit

@ahg-g @kerthcet do you want to check this PR one more time?

/hold
just so it doesn't get merged by mistake before I get a chance to look at it

I did test it in practice, as well as added e2e and integration tests

/lgtm
/approve
/label tide/merge-method-squash
/hold cancel


Getting error Cannot read property 'authenticationfailure' of undefined

Hi,
After successfully login to cas and redirect back, getting below error again and again while accessing api.
[2] [TypeError: Cannot read property 'authenticationfailure' of undefined]
[2] [Error: CAS authentication failed.]
My service is pointing to localhost.
Is there a way to debug ?

Same problem :

I'm doing a rewrite of this module (with no API-breaking changes) and I'm going to validate the structure of the CAS server's response. All this will do it provide a more useful error message, though.
If the CAS server in the test cases was operating correctly and on the correct version, then this might be a problem with slashes. I'll be using url.resolve to build my request URLs in the new version.


Update Delete Blocks contextual menu item to not reference the number of blocks

When right clicking on a stack of blocks, a "Delete N Blocks" menu item is shown, with N corresponding to the number of blocks in the stack. In Scratch proper, this is shown as "Delete Block", regardless of the number of blocks in the stack. The code for handling procedure deletion also looks for the "Delete Block" string literal to patch the implementation to scour the workspace for references to the procedure and warn about them, which is currently broken as a result.

Duplicate of #99


Change Text Size to resolve overlapping

As we can see from the provided image that on resizing the window size the text is overlapping. I want to resolve this issue.
Please assign me this issue as a GSSOC Participant.

I'm the participant in GSSOC'21. Could you please assign me this.I would love working on this.

someone did this issue.


Bump sigstore/sigstore dep and explicitly import KMSes

Since https://github.com/sigstore/sigstore/pull/276/, KMS
implementations (AWS, GCP, etc.) are not included by default, to reduce
dependencies for callers who don't want all those impls.
Chains does want those deps, so we explicitly import them.
cc @dlorenc

/lgtm

/lgtm


Yjdh-114: Employer extra fields: separate invoicer

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #301 (bfba2c7) into develop (2856388) will decrease coverage by 0.99%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #301      +/-   ##
===========================================
- Coverage    96.01%   95.01%   -1.00%
===========================================
  Files          162       88      -74
  Lines         5798     2851    -2947
===========================================
- Hits          5567     2709    -2858
+ Misses         231      142      -89

Impacted Files
Coverage Δ

.../applications/tests/test_application_validation.py
98.76% <ø> (-0.28%)
:arrow_down:

...kend/kesaseteli/applications/api/v1/serializers.py
90.66% <100.00%> (-6.00%)
:arrow_down:

backend/shared/shared/models/abstract_models.py
100.00% <0.00%> (ø)

backend/benefit/terms/models.py

.../migrations/0006_field_changes_for_employee_api.py

...tions/0010_application_missing_applicant_fields.py

backend/benefit/applications/tests/conftest.py

backend/benefit/users/tests/factories.py

...enefit/applications/tests/test_ahjo_integration.py

... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2856388...bfba2c7. Read the comment docs.


Update golang to 1.20

How to categorize this issue?

/area open-source
/kind enhancement
Golang v1.20 was released on February 1st, you'll find the changelog here: https://go.dev/doc/go1.20
Tasks

[ ] Prepare PR to update images for unit and integration tests in prow to Go 1.20

[x] merge PR which fixes wrong images labels first https://github.com/gardener/ci-infra/pull/573

/assign

Waiting for homebrew PR to get merged https://github.com/Homebrew/homebrew-core/pull/122082.

All above tasks are completed. Can we close this issue? As for the optional tasks, I understood that we cannot fully drop github.com/hashicorp/go-multierror, and that the -pgo is alpha. So, probably we shouldn't follow up with them for now?


New Navigation bar is updated

Notes for Reviewers
This PR fixes #127
https://github.com/layer5io/docs/assets/76243585/4b4a8a1b-0a93-4a39-b43e-085804c0f650
Signed commits

[x] Yes, I signed my commits.

Products should be rename to Solutions
Search bar isn't working

Hi @Aniumbott  ,
Thanks for your PR! 🚀 I encourage you to share this in the Website Meeting today at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.
You're welcome in the meeting today
Cheers, and Happy New Year 🥂,
Subscribe to community calendar for more details of meetings at Layer5.

Products should be rename to Solutions
Search bar isn't working

Ya, I just noticed. It was the problem with the CDN scripts which were required for the dropdown, Anyways I've updated it with a custom script.
Also, I have updated the Products -> Solutions.

@Aniumbott sorry for misunderstanding from my side please change Solutions back to Products

@Aniumbott are you still working on it?

yep

@Aniumbott oh great please add Cloud and Meshmap link to the top navbar

also when we search the text in search box becomes white, it should remain blackish

also when we search the text in search box becomes white, it should remain blackish

Done 👍

also when we search the text in search box becomes white, it should remain blackish

Done 👍
Let me know if anything else is required.

on home its working fine but when you go to the Cloud or Meshmap and than click on products, icons aren't showing up

I thought the static folder is the root for images as per in _index.md so I didn't think that the path would be relative, Sorry for this misunderstanding.

@Aniumbott Thank you for this and I would really appreciate if you can fix one last thing i.e. the active nav color which should change based on the page you are in

@Aniumbott No update here, lets get this active button issue fixed on next PR

Ok, I will shift to a separate PR. Sorry, I was busy for a few days.

@Aniumbott Please create an issue about it and assign it to yourself

@Aniumbott No update here, lets get this active button issue fixed on next PR


A reasonable way to handle with different upload_path and serve_path

The project structure
app/
  __init__.py
config.py
manage.py

I create an UploadSet in app/__init__.py
photos = UploadSet('photos', IMAGES)

When I set UPLOADS_DEFAULT_DEST = 'app/uploads/', the photos will save at app/uploads
but when I visit http://localhost/_uploads/photos/bg.jpg,
FileNotFoundError: [Errno 2] No such file or directory: '/Users/tianyizhuang/Projects/CamusKit.Backend/app/app/uploads/photos/bg.jpg'

An extra app in the path.
What's the reasonable way to deal with the problem?

Use the builtin function photos.url("bg.jpg") to get the URL for the image.

Please use StackOverflow for questions about how to use the library.


JayHorn crashes on another trivial program

public class Test {
    public int x;
    public int main(String[] args) {
        Test a = null;
        a.x = 42;
        return 0;
    }
}

gives
Exception in thread "main" (<Test: int main(java.lang.String[])>) local type not allowed in final code: null_type local: n0
	at soot.jimple.validation.TypesValidator.validate(TypesValidator.java:44)
	at soot.jimple.JimpleBody.validate(JimpleBody.java:125)
	at soot.jimple.JimpleBody.validate(JimpleBody.java:110)
	at soottocfg.soot.transformers.AssertionReconstruction.reconstructJavaAssertions(AssertionReconstruction.java:283)

It does not make a difference whether "main" is static or not ;-)

I think this is Soot's way of catching the null dereference. Added a check for that now.


Ability to add an empty state component when there are no results

Thank's for this great plugin!
Describe the solution you'd like
An ability to add an empty state component when there are no search results for a better user experience

Hi @yairco1990, do you mean something like this:

exactly!


Don't sudo to install if using nvm

If one is using nvm, sudo npm install -g vtop won't work. I nearly gave up and I found the solution on #79. I think this should be written in the README.md.

Thanks!


Third-party keyboards seem to crash more frequently.

Third-party keyboards on iOS have been reported to crash Flutter.  Per @alardizabal via email.
I've not yet seen this myself.  But @abarth says this is because we're using the wrong IME API on iOS and that @xster plans to fix?

There are a cluster of iOS Keyboard bugs many likely caused by us currently using the wrong API level to interface with the iOS Keyboard.  I believe https://github.com/flutter/flutter/issues/4818 is the bug where the fix is likely to be tracked.

I've tested my in-progress changes with GBoard and things are working pretty well for me. There's a bit more work to do on the layout side, but this should be resolved when the current work lands.

flutter/engine#3586 lands support for almost all keyboard APIs, with the exception of:

force touch cursor positioning
voice dictation

This should be enough to get third-party keyboards happy. Please re-open if you're still seeing issues.


Deprecations and removals for Chrome 63 with related updates.

Whoops!
There were 2 critical errors that broke the build and prevented it from being automatically deployed.
There were 5 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/updates/2017/10/chrome-63-deprecations.md#L3 - Attribute description cannot contain HTML or markdown, found: A round up of the deprecations and removals in Chrome 63 to help you plan. In this version, new behavior on interface properties, removal of a webkit function, and a change to RTCRtcpMuxPolicy.
src/content/en/updates/2017/10/chrome-63-deprecations.md#L19 - Do not hard code developers.google.com in links.
WARNINGS
src/content/en/updates/2017/02/chrome-57-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/03/chrome-58-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/06/chrome-60-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/08/chrome-61-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/chrome-63-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.

Whoops!
There were 2 critical errors that broke the build and prevented it from being automatically deployed.
There were 5 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/updates/2017/10/chrome-63-deprecations.md#L3 - Attribute description cannot contain HTML or markdown, found: A round up of the deprecations and removals in Chrome 63 to help you plan. In this version, new behavior on interface properties, removal of a webkit function, and a change to RTCRtcpMuxPolicy.
src/content/en/updates/2017/10/chrome-63-deprecations.md#L19 - Do not hard code developers.google.com in links.
WARNINGS
src/content/en/updates/2017/02/chrome-57-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/03/chrome-58-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/06/chrome-60-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/08/chrome-61-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/chrome-63-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.

Whoops!
There were 1 critical errors that broke the build and prevented it from being automatically deployed.
There were 5 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/en/updates/2017/10/chrome-63-deprecations.md#L19 - Do not hard code developers.google.com in links.
WARNINGS
src/content/en/updates/2017/02/chrome-57-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/03/chrome-58-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/06/chrome-60-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/08/chrome-61-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/chrome-63-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.

Whoops!
There were 5 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2017/02/chrome-57-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/03/chrome-58-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/06/chrome-60-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/08/chrome-61-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/chrome-63-deprecations.md - No wf_blink_components field found in metadata. Add if appropriate.


Never finds link info

Hello,
In Chatterino settings, Link information is enabled but it never ever finds link information. Whatever the link, it doesn't find any info.
I did a fresh install of Chatterino multiple times, nothing changes.
I tried with youtube, twitch and twitter links.
Please tell me anything that comes to your mind to fix things.
Ask me anything you need to know about the settings if you need.
Thanks in advance
Chatterino 2.2.2 (commit 07fc0c3ad)
Windows 10

Could you please provide a screenshot of what appears when you hover over the link?

In addition to what ALazyMeme said, it would also be helpful if you provided the links you tested. 😄

I tried with every link I found on a stream I was watching, none of them worked, but I'll put some examples :
https://www.twitch.tv/sodapoppin/clip/BashfulLightZebra4Head
https://www.youtube.com/watch?v=7KqvkMQVQhc
https://www.youtube.com/watch?v=UEAS1zYvxIk
for each of them when I put my mouse on it it doesn't do anything for a bit, I assumed it was loading the info and after a little bit , maybe less than 30 sec, I get what's on the pic below

And about the template to follow, I followed it, but I thought screenshots were not useful in this case and I have no way of reproducing it, I install Chatterino and the problem is here, so to reproduce it just put your cursor on the link, which is obviously not the way to reproduce it if I'm the only one with problems. I didn't want to just say put your cursor on the link.

I have the same issue on macOS Big Sur. "No link info found" always appears, I've tested YouTube (shortened/not shortened) and Discord invite links.

It looks to me like the link resolver of the Chatterino API cannot be reached for some reason so the request times out.
If this problem occurs regularly, it would be interesting to see whether you can access the link resolver's server via this link.
If that link works for you, please also post the contents of this link in a reply on this issue. Thank you! :smile:

@leon-richardt
"This site can't be reached"
I don't have access to the link, let me restart my router

My router was blocking it in some way, I restarted it and it works
That's a problem I have sometimes, my router just stop some things from working like twitch for example but I didn't think about it
Thank you for all your help and sorry for the inconvenience 😅

My router was blocking it in some way, I restarted it and it works
That's a problem I have sometimes, my router just stop some things from working like twitch for example but I didn't think about it
Thank you for all your help and sorry for the inconvenience

Great to hear! I would suggest you leave this issue open until he heard back from @MIGI10 as well.

My router was blocking it in some way, I restarted it and it works
That's a problem I have sometimes, my router just stop some things from working like twitch for example but I didn't think about it
Thank you for all your help and sorry for the inconvenience

Great to hear! I would suggest you leave this issue open until we hear back from @MIGI10 as well.

Fixed, I had the same issue, router was blocking access. Thank you anyway!


Delete the webtorrent-desktop npm package

It looks like we actually have people using npm install webtorrent-desktop.
Version 0.13.0 was never served from webtorrent.io - we went directly from 0.12.0 to 0.13.1. The the auto updaters also skipped that version. Despite that, we got telemetry reports from quite a few users using version 0.13.0.
That means they must have either downloaded the version directly from the Github Releases page, or used npm install. I bet it's the latter.

Does the auto updater actually work correctly after npm install? The initial install is not done thru Squirrel, so probably not...
Either way, we already have tons of different ways to install WebTorrent. Windows exe, Windows zip, Mac dmg, Mac zip, Linux deb (64- and 32-bit), Linux zip (64- and 32-bit). I don't think we want to support even more ways than that. Complexity makes it harder to be robust.

If the auto updater doesn't work for our npm users, then that helps explain why ~15% of our users are still on versions older than 0.12:

That 15% also includes:

People who ran the app today for the first time in weeks
People who used the Portable ZIP install option

I agree, I don't think GUI applications fits well with npm install.
On Mac I think something like Cask would be the better option.

@mathiasvr I don't want to support cask either. For Mac, we have a single supported way to install the app: using the DMG.

@dcposch I was just mentioning it as an alternative to npm if people really wanted to install through the terminal. Regarding supporting it developers rarely have a choice, and I just checked - it's already there.

For now maybe you could just deprecate it first to give users time to adjust, before fully deleting it.

@demoneaux sounds good

@dcposch I don't have a strong opinion about this, so I'll defer to you.
But I don't think webtorrent-desktop is the main reason that people are still on pre-0.12 versions. Check out the latest stats:

That's 8% of users on pre-0.12 versions. That lines up nicely with our Linux user count, which is ~9.5% if we go by download count. (26,980 Linux downloads / 284,930 total downloads)
We also have 100+ followers on GitHub who get emails whenever there's a release, so maybe they did download directly from GitHub?

That's 8% of users on pre-0.12 versions. That lines up nicely with our Linux user count, which is ~9.5%

Well, we can see how much overlap there actually is. From yesterday's telemetry file:
$ cat logs/telemetry/2016-09-17.log | jq -c '{v:.version,o:.system.osPlatform}' | grep null | sort | uniq -c
 127 {"v":null,"o":"darwin"}
  36 {"v":null,"o":"linux"}
 155 {"v":null,"o":"win32"}

So we have pre-0.12 users on all OSes

We also have 100+ followers on GitHub who get emails whenever there's a release, so maybe they did download directly from GitHub?

Good point. This explains why we had quite a few people install 0.13.0, even tho that was never linked to from the site or the auto updater. (We skipped directly to 0.13.1.)
Ideas:

Delete the npm package
Add a sentence or two to the top of CHANGELOG.md explaining that your app should auto update itself on Mac and Windows, no action required, and that you should install it from the website.
Mark all new Github releases as pre-release (non production) until it's on the website.

Delete the npm package

Sure, the reason we added this in the first place was to let 32-bit linux users use the app. But we have a build for them now, so this isn't an issue anymore. Let's try deleting it and see how many people it impacts. PR incoming.

Add a sentence or two to the top of CHANGELOG.md explaining that your app should auto update itself on Mac and Windows, no action required, and that you should install it from the website.

Mark all new Github releases as pre-release (non production) until they're on the website.

If the user is on GitHub downloading a release, I think they're a power user and can figure things out for themselves. But I think a note about how we have an auto-updater is a good idea!

The deed is done 💀
https://www.npmjs.com/package/webtorrent-desktop
Here's the new readme:

DEPRECATED: Install WebTorrent Desktop from the official site: https://webtorrent.io/desktop
This package is deprecated. Install WebTorrent Desktop from the official site: https://webtorrent.io/desktop.
Why?
The reason we added created this package in the first place was to let 32-bit
Linux users run the app. But we have an official 32-bit Linux build now, so this
isn't an issue anymore.
Supporting multiple ways of consuming the app creates more potential ways the app
can fail and we're trying very hard to make it super reliable.
As a bonus, on Mac and Windows, the official release comes with a sweet
auto-updater.


Bluetooth Low Energy client sample in javascript

I would like to use the Bluetooth Low Energy client sample in a javascript app, but the sample is written only in c#, How can I find its javascript version?

I've created a backlog item for the feature team.

Hi EZZAHED,
Unfortunately JavaScript version of the sample will not be in the next couple updates. We've prioritized our sample backlog by requests and we've had many for C++ and will focus on it next. If you have issues using our APIs from JavaScript please feel free to asks specific questions.


Code refactoring for gutil.PluginError

I added sudo: false to .travis.yml for faster CI build.

It makes the build really faster than ever. Read the blog post Faster Builds with Container-Based Infrastructure and Docker for details.

I updated dotfiles.

I added .jshintrc.
I removed .npmignore and added files field to package.json instead.

I replaced lodash with smaller modules to reduce source size.

_.defaults -> object-assign
_.uniq -> array-uniq

I updated dependencies and devDependencies.

Maybe it will fix this issue but I cannot confirm the problem.

I introduced istanbul-coveralls to the coveralls script.
I updated test script to let JSHint work correctly.
I updated badge URLs in readme.
I updated test script.

I replaced .should.not.equal(-1) with .containEql.
I removed all the unused variables.

Could you release a new patch version?
Although this module will be depreceted, it's worth doing that.

@shinnn 3.0.2

@contra Thanks!


feat: serialize lists as sequences

This PR should address #6. So far I've implemented the serialization of lists as sequences, but only started the work on the deserialization parts.

This is solved with the latest rewrite in #8.


Add instructions for the Android build

Yay! I will test for realsies, next week.

Nice!
I ran through the steps on my workstation and laptop and can confirm this works. Have a few suggestions and a couple of gotchas you can consider including.

Just one more thing but :+1:, very cool to see this progressing.


Mismatched heads hashes on documents with javascript numbers

Hello! It appears that some documents fail with a Mismatched heads hashes when sent from a rust Backend to the javascript library that include numbers.
For example:
{ "number": 1 }

Will fail, but:
{ "number": "1" }

Will succeed.
A repository with a reproduction is at adamhjk/automerge-mismatched-hash.

Will this be fixed by #128 (automerge/automerge#371)?

@vedantroy should this be fixed as of https://github.com/automerge/automerge-rs/pull/152 did you have a setup to check?


IDVA6-1299 - Welsh Translation - Add a Company

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1299
Changes:

Added Welsh translations for 'add company' page
Updated 'continue' translation in common.json

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


can't see my references

Subject: can't see my references
Description:
whenever i click on the tab "references" i can't actually see anything there, though i already have 2.
Results:
Backend version: develop-f07e2814
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Page: https://couchers.org/messages/surfing
User: alexander_g (25824)

i can see them now


QoS Policy Errors and Map Not Publishing

I am encountering an issue where no data is being published to the /map topic.
Below are the details of my setup and the steps I have taken so far:
Environment:
ROS2 Version: Humble
Simulator: Webots
Visualization: Foxglove
System: Ubuntu 22.04 on Docker
Middleware: rmw_fastrtps_cpp
Issue Description:
The /map topic is visible, and ros2 topic list shows it as existing. However, ros2 topic echo /map reveals that no data is being published.
I am not using Velodyne lidar - I don't think this is a requirement.
Might be a middleware issue, but when I runros2 doctor and ros2 doctor -r, everything looks fine.
The lidarslam_ros2 node appears to be running without any apparent issues. (Log below)
ros2 launch lidarslam lidarslam.launch.py
[INFO] [launch]: All log files can be found below /root/.ros/log/2023-12-02-00-27-20-850854-72f875f9b2f4-23672
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [scanmatcher_node-1]: process started with pid [23708]
[INFO] [static_transform_publisher-2]: process started with pid [23710]
[INFO] [graph_based_slam_node-3]: process started with pid [23712]
[static_transform_publisher-2] [WARN] [1701476840.895559210] []: Old-style arguments are deprecated; see --help for new-style arguments
[static_transform_publisher-2] [INFO] [1701476840.903340210] [static_transform_publisher_dIfNbir1rGlI9JHN]: Spinning until stopped - publishing transform
[static_transform_publisher-2] translation: ('0.000000', '0.000000', '0.000000')
[static_transform_publisher-2] rotation: ('0.000000', '0.000000', '0.000000', '1.000000')
[static_transform_publisher-2] from 'base_link' to 'velodyne'
[scanmatcher_node-1] registration_method:NDT
[scanmatcher_node-1] ndt_resolution[m]:2
[scanmatcher_node-1] ndt_num_threads:2
[scanmatcher_node-1] gicp_corr_dist_threshold[m]:5
[scanmatcher_node-1] trans_for_mapupdate[m]:1.5
[scanmatcher_node-1] vg_size_for_input[m]:0.5
[scanmatcher_node-1] vg_size_for_map[m]:0.1
[scanmatcher_node-1] use_min_max_filter:true
[scanmatcher_node-1] scan_min_range[m]:1
[scanmatcher_node-1] scan_max_range[m]:200
[scanmatcher_node-1] set_initial_pose:true
[scanmatcher_node-1] publish_tf:true
[scanmatcher_node-1] use_odom:false
[scanmatcher_node-1] use_imu:false
[scanmatcher_node-1] scan_period[sec]:0.2
[scanmatcher_node-1] debug_flag:true
[scanmatcher_node-1] map_publish_period[sec]:15
[scanmatcher_node-1] num_targeted_cloud:20
[scanmatcher_node-1] ------------------
[scanmatcher_node-1] [INFO] [1701476840.913879376] [scan_matcher]: initialize Publishers and Subscribers
[scanmatcher_node-1] [INFO] [1701476840.915610793] [scan_matcher]: initialization end
[graph_based_slam_node-3] [INFO] [1701476840.934688085] [graph_based_slam]: initialization start
[graph_based_slam_node-3] registration_method:NDT
[graph_based_slam_node-3] voxel_leaf_size[m]:0.1
[graph_based_slam_node-3] ndt_resolution[m]:1
[graph_based_slam_node-3] ndt_num_threads:2
[graph_based_slam_node-3] loop_detection_period[Hz]:3000
[graph_based_slam_node-3] threshold_loop_closure_score:0.7
[graph_based_slam_node-3] distance_loop_closure[m]:100
[graph_based_slam_node-3] range_of_searching_loop_closure[m]:20
[graph_based_slam_node-3] search_submap_num:2
[graph_based_slam_node-3] num_adjacent_pose_cnstraints:5
[graph_based_slam_node-3] use_save_map_in_loop:true
[graph_based_slam_node-3] debug_flag:true
[graph_based_slam_node-3] ------------------
[graph_based_slam_node-3] [INFO] [1701476840.934871710] [graph_based_slam]: initialize Publishers and Subscribers
[graph_based_slam_node-3] [INFO] [1701476840.936463085] [graph_based_slam]: initialization end

ros2 node list correctly outputs graph_based_slam node and scan_matcher node:
ros2 node list
/Ros2Supervisor/Ros2Supervisor
/TurtleBot3Burger
/controller_manager
/diffdrive_controller
/foxglove_bridge
/foxglove_bridge_component_manager
/graph_based_slam
/joint_state_broadcaster
/robot_state_publisher
/scan_matcher
/static_transform_publisher_dIfNbir1rGlI9JHN
/static_transform_publisher_vc2cCkVSG7m3Rf60
/transform_listener_impl_aaaadaa2a1e8
/transform_listener_impl_aaaadf109cd8

Output from ros2 topic list
ros2 topic list
/Ros2Supervisor/remove_node
/TurtleBot3Burger/compass/bearing
/TurtleBot3Burger/compass/north_vector
/clicked_point
/clock
/cmd_vel
/current_pose
/diffdrive_controller/transition_event
/dynamic_joint_states
/imu
/initial_pose
/initialpose
/joint_state_broadcaster/transition_event
/joint_states
/map
/map_array
/modified_map
/modified_map_array
/modified_path
/move_base_simple/goal
/odom
/parameter_events
/path
/remove_urdf_robot
/robot_description
/rosout
/scan
/scan/point_cloud
/tf
/tf_static
/velodyne_points

Troubleshooting Steps Taken:
I checked that there is a publisher on the /map topic
ros2 topic info /map -v
Type: sensor_msgs/msg/PointCloud2

Publisher count: 1

Node name: scan_matcher
Node namespace: /
Topic type: sensor_msgs/msg/PointCloud2
Endpoint type: PUBLISHER
GID: 01.0f.56.e7.9c.5c.<IP_ADDRESS>.<IP_ADDRESS>.1b.<IP_ADDRESS>.<IP_ADDRESS>.00
QoS profile:
  Reliability: RELIABLE
  History (Depth): UNKNOWN
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

Any help would be appreciated. Thank you in advance.

The 'scam_mathcer' node might not be performing scan matching. You can check if the input scan topic is properly fed into the 'scan_mathcer' node using 'ros2 topic info -v'. By setting the 'scan_mathcer debug_flag' to true in the YAML file, you can view more detailed logs.
https://github.com/rsasaki0109/lidarslam_ros2/blob/develop/lidarslam/param/lidarslam.yaml#L28

Fixed the issue by adding a correct remappings for scan_matcher
lidarslam_params = os.path.join(package_dir, 'resource', 'lidar_slam.yaml')
scan_matcher = Node(
    package='scanmatcher',
    executable='scanmatcher_node',
    parameters=[lidarslam_params],
    remappings=[('/input_cloud','/scan/point_cloud')],
    output='screen',
    condition=launch.conditions.IfCondition(use_lidar_slam)
)

graph_based_slam = Node(
    package='graph_based_slam',
    executable='graph_based_slam_node',
    parameters=[lidarslam_params],
    output='screen',
    condition=launch.conditions.IfCondition(use_lidar_slam)
)

Thank you so much for your help!


[Issue 769]: Fix retrieval of the correct Object during $destroy on elements within an Array

Description
During a $destroy (e.g. when conditions evaluate to false), form.key is used to access the appropriate part of the Model in order to apply the DestroyStrategy.
This does not work for Elements within an Array, because form.key looks like this:
['array', '', 'property']
In other words, it does not have a reference to the ArrayIndex of the Element (within which contains the property to be destroyed).
My fix was to make a copy of the form.key (in order to avoid breaking anything else that depends on its original format), and then update it so that it looks like this:
['array', '5', 'property']
Where '5' here is just an example of the ArrayIndex.
This "updated" form.key is then used in the sfSelect to correctly access the appropriate part of the Model to be destroyed.
Fixes Related issues

https://github.com/json-schema-form/angular-schema-form/issues/769

Checklist

[x] I have read and understand the CONTRIBUTIONS.md file
[x] I have searched for and linked related issues
[ ] I have created test cases to ensure quick resolution of the PR is easier
[x] I am NOT targeting main branch
[x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

@doomie999 thanks for the PR, does this still work if there is an array within an array?

@Anthropic Unfortunately, this fix doesn't work correctly on Arrays nested within Arrays.
I used scope.$index as the ArrayIndex of the Element in the Array. Thus, when a $destroy is triggered on a nested Array, the scope.$index picks up the ArrayIndex in the nested Array, and my fix incorrectly sets that as the ArrayIndex of the parent Array as well.
Having said that, I was actually able to access the ArrayIndex of the parent Array by using scope.$parent.$parent.$parent.$index, but this didn't feel very elegant to me.
Would you be able to offer any advice on how to access the ArrayIndex of the parent Array?

Take a look at #742 it adds arrayIndeces which would give you the sub array path. I just merged it into the webpack-babel branch, if you re-target that branch it will be available to you. The changes may not be super clear on how to test it though, I am working on that at the moment and this weekend.

@Anthropic I took a look at #742 and the webpack-babel branch (took a while because the change in build script from gulp to npm threw me off for a bit!)
Pardon my inexperience with ASF, but I'm not quite sure how to go about using the fix for #742 in this issue. #742 creates the arrayIndices (via the same chaining of $parent as I mentioned above), but this is done in the builder, and the arrayIndices are not available in sfField (where the $destroy is done).
I could repeat the same logic written in #742 inside sfField, but that's not quite DRY. Any thoughts/suggestions?

@joelwkent any ideas on the best way to get your arrayIndices into sfField for a destroy?

Hi guys, apologies I had not seen this question until @Anthropic gave me a nudge on Gitter.
I wonder if we can move the arrayIndices code to a service that could be used by this PR and conditions, onChange etc... I'm not 100% sure how to do this but I'll have a look over the code and report back shortly.

@doomie999 I have committed some changes towards a solution, still have more work to do, but I think I have a way to make the details available soon-ish.

@doomie999 the code I added passes the index and array indices to the scope by adding a controller above the added items and then importing that data using require ?^^sfKeyController into sfField. I have added the bejhaviour to array and tabarray.

@doomie999 FYI the latest version in the ASF webpack branch seems to work better now.
You can see from the debug output that the key is available and should work with destroy now.

As I mentioned in #769 I believe I have this working in alpha.4 at the latest, so I will close this. Turned out that I changed the ng-repeat to use $$hashKey which seems to have done the trick. Thank you so much for your help on this @doomie999 I really appreciate it, you saved me a lot of time trying out variations I would have tried myself, so thank you!


Demo folder included

I'm not sure whether this is intentional or not but the OpenJDK builds by AdoptOpenJDK include a demo/ folder while the  OpenJDK builds by Oracle do not.
Personally I don't see much use from the demos and certainly would not want to deploy them on a production server.
Maybe the can be offered as a separate download.
Zulu interestingly does include the demo/ folder.

Admittedly it's not very big (see below) but makes sense for it to be removed from production binaries
 24K	demo/nbproject/scripting/jconsole-plugin/nbproject
 32K	demo/nbproject/scripting/jconsole-plugin
 32K	demo/nbproject/scripting
 24K	demo/nbproject/management/FullThreadDump/nbproject
 32K	demo/nbproject/management/FullThreadDump
 24K	demo/nbproject/management/JTop/nbproject
 32K	demo/nbproject/management/JTop
 24K	demo/nbproject/management/VerboseGC/nbproject
 32K	demo/nbproject/management/VerboseGC
 24K	demo/nbproject/management/MemoryMonitor/nbproject
 32K	demo/nbproject/management/MemoryMonitor
128K	demo/nbproject/management
 24K	demo/nbproject/jfc/FileChooserDemo/nbproject
 32K	demo/nbproject/jfc/FileChooserDemo
 24K	demo/nbproject/jfc/Font2DTest/nbproject
 32K	demo/nbproject/jfc/Font2DTest
 24K	demo/nbproject/jfc/TransparentRuler/nbproject
 32K	demo/nbproject/jfc/TransparentRuler
 24K	demo/nbproject/jfc/Metalworks/nbproject
 32K	demo/nbproject/jfc/Metalworks
 24K	demo/nbproject/jfc/TableExample/nbproject
 32K	demo/nbproject/jfc/TableExample
 24K	demo/nbproject/jfc/SwingApplet/nbproject
 32K	demo/nbproject/jfc/SwingApplet
 24K	demo/nbproject/jfc/SampleTree/nbproject
 32K	demo/nbproject/jfc/SampleTree
 24K	demo/nbproject/jfc/Notepad/nbproject
 32K	demo/nbproject/jfc/Notepad
256K	demo/nbproject/jfc
424K	demo/nbproject
200K	demo/jfc/Stylepad
 44K	demo/jfc/FileChooserDemo
 48K	demo/jfc/CodePointIM
 20K	demo/jfc/TransparentRuler
3.0M	demo/jfc/SwingSet2
 96K	demo/jfc/Metalworks
 64K	demo/jfc/TableExample
 48K	demo/jfc/SampleTree
 68K	demo/jfc/Notepad
1.7M	demo/jfc/J2Ddemo
5.3M	demo/jfc
5.7M	demo```

TSC has voted to remove the Demo folder.

I've raised a PR to remove demo folder.
https://github.com/AdoptOpenJDK/openjdk-build/pull/1605


Update the version of base libraries and OS

1. related issue
https://github.com/ucbrise/clipper/issues/583, https://github.com/ucbrise/clipper/issues/551
2. Change the base OS from debian:stretch-slim to ubuntu:18.04 in ClipperLibBaseDockerfile
debian:stretch-slim uses libboost-all-dev (<IP_ADDRESS>) (link), but I have suffered with the 'epoll_reactor' bug of Boost in the production environment, and this bug was resolved by Boost 1.65.0. (link)

https://svn.boost.org/trac10/ticket/7611
https://svn.boost.org/trac10/ticket/10956
https://svn.boost.org/trac10/ticket/8605
https://svn.boost.org/trac10/ticket/8538

To avoid this bug, we changed the base OS from debian:stretch-slim to ubuntu:18.04, in which we can install libboost-all-dev (1.65.1) easily. (link) The sizes of the two Docker images are similar.

debian:stretch-slim : 55.3MB
ubuntu:18.04 : 69.9MB

3. Update folly from v2<IP_ADDRESS> to v2<IP_ADDRESS>
It's difficult to determine what version is stable because folly is released by weekly. So I will try to apply the 2<IP_ADDRESS> version first of all, which is the latest in brew.

[ ] Check all the unit tests about Clipper.

4. Update FindBoost.cmake to support the latest version of Boost(1.70.0)

I imported the following three files from here.

FindBoost.cmake
FindPackageHandleStandardArgs.cmake
FindPackageMessage.cmake

5. we can finally build the Clipper on Mac OS using the methods on this site.

http://clipper.ai/contributing

Do not merge this PR yet.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2054/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2056/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2059/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2060/
Test PASSed.


F-Droid reproducible build failed

https://monitor.f-droid.org/builds/log/com.starry.myne/391#site-footer
Only the zip metadata is different.

New versions are reproducible. Do you know why?

Which versions are failing and what's the f-droid pipeline link?

Ah, my mistake. FitBook build failed because background_fetch is not needed anymore. I have fixed it. Sorry!


RuntimeError - Cannot write  to an ascii plist

I get following errors when i try pod install.
RuntimeError - Cannot write  to an ascii plist
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:63:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:29:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:128:in `write_dictionary_key_value_pair'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:119:in `block in write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:118:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:118:in `write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:108:in `write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:55:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:29:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:97:in `write_array_element'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:91:in `block in write_array'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:90:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:90:in `write_array'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:80:in `write_array'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:53:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:29:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:128:in `write_dictionary_key_value_pair'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:119:in `block in write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:118:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:118:in `write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:108:in `write_dictionary'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer.rb:55:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:29:in `write_object'
/usr/local/lib/ruby/gems/2.2.0/gems/nanaimo-0.1.2/lib/nanaimo/writer/xml.rb:13:in `write'
/usr/local/lib/ruby/gems/2.2.0/gems/xcodeproj-1.4.0/lib/xcodeproj/plist.rb:55:in `block in write_to_path'
/usr/local/lib/ruby/gems/2.2.0/gems/xcodeproj-1.4.0/lib/xcodeproj/plist.rb:53:in `open'
/usr/local/lib/ruby/gems/2.2.0/gems/xcodeproj-1.4.0/lib/xcodeproj/plist.rb:53:in `write_to_path'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:7:in `save_metadata'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:71:in `block (4 levels) in <module:CocoaPodsAcknowledgements>'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:63:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:63:in `block (3 levels) in <module:CocoaPodsAcknowledgements>'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:60:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:60:in `block (2 levels) in <module:CocoaPodsAcknowledgements>'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/user_interface.rb:64:in `section'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-acknowledgements-1.1.2/lib/cocoapods_acknowledgements.rb:52:in `block in <module:CocoaPodsAcknowledgements>'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:109:in `call'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:109:in `block (3 levels) in run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/user_interface.rb:142:in `message'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:103:in `block (2 levels) in run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:101:in `each'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:101:in `block in run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/user_interface.rb:142:in `message'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/hooks_manager.rb:100:in `run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/installer.rb:493:in `run_plugins_post_install_hooks'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/installer.rb:472:in `perform_post_install_actions'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/installer.rb:121:in `install!'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/command/install.rb:37:in `run'
/usr/local/lib/ruby/gems/2.2.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/lib/cocoapods/command.rb:50:in `run'
/usr/local/lib/ruby/gems/2.2.0/gems/cocoapods-1.1.1/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Cocoapods version:
pod --version
1.1.1

On 0.39.0 version all work correct.
Podfile
source 'https://github.com/cocoapods/Specs.git'

platform :ios, '8.0'
inhibit_all_warnings!

plugin 'cocoapods-acknowledgements', :settings_bundle => true

target 'Some' do
    pod 'SomePod'
    ...

    taget 'Test' do
        pod 'SomeTestPod'
    end

end

Without plugin all also work fine.

gem install xcodeproj:1.4.1


Add LBO expansion

Adds functionality to add an expansion of intensity on the surface of a mesh in a Laplace-Beltrami-Operator eigenvector basis.

Tests are passing locally - will merge now and fix on a different PR.


Explorer Enable Undo doesn't prompt

Testing #141351
On macOS

Ensure the explorer.enableUndo setting is not modified (default to warn)
Create two folders A and B, create file a.py in A
Drag it to B
Undo

There isn't any prompt of warning

Renaming a file and undo doesn't warn either.

The way I interpreter warn is it will warn is it prompts and tells you what's going to happen when you undo/redo as the undo/redo is focus based and it's likely to mis-trigger. I don't necessarily want to disable this feature (as it's convinient) but I want to be aware of what's going to change. Undo the dnd is one of them as I might miss where the file will be moved into (especially when I'm traversing in the undo stack).

Changed the config around to better stratify this:
		'explorer.confirmUndo': {
			'type': 'string',
			'enum': [UndoConfirmLevel.Verbose, UndoConfirmLevel.Default, UndoConfirmLevel.Light],
			'description': nls.localize('confirmUndo', "Controls whether the explorer should ask for confirmation when undoing."),
			'default': UndoConfirmLevel.Default,
			'enumDescriptions': [
				nls.localize('enableUndo.verbose', 'Explorer will prompt before all undo operations.'),
				nls.localize('enableUndo.default', 'Explorer will prompt before destructive undo operations.'),
				nls.localize('enableUndo.light', 'Explorer will not prompt before undo operations when focused.'),
			],


Route Helpers extension causes long compilation times

When enabling the Route Helpers extension, the compilation time increases by several seconds even on a small project with a handful of routes.

As the official Phoenix Router Helpers are deprecated, I see no point in fixing this issues (btw. in 0.3.0 the situation already improved).


Create alok-38

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Closing PR as user is banned from EddieHub for breaking the code of conduct


Wrong olcSuffix and olcRootDN

When creating the container using e.g. --env LDAP_BASE_DN=o=inet --env LDAP_DOMAIN=inet the ldap server gets configured with olcSuffix: dc=inet and olcRootDN: cn=admin,dc=inet. This is a bug. Access rules are ok, e.g. olcAccess: {1}to * by self read by dn="cn=admin,o=inet" write by * none.
IMHO the LDAP_DOMAIN env should be dropped completely - the concept is simply wrong and buys nothing but confusion and bugs.

@jelmd seem like you have hit one of the numerous issues linked to these variables. This is why I had created a discussion issue which sums up all these as well as some fix I made to do stronger checking on coherency between all these env variables values.


"Text" and "Caption" in MessageBoxA API display in ASNI encoding format as default

Hey guys:
I'm a newbie to Windows application development and Rust.
My file is UTF-8 encoding, here is my code
 MessageBoxA(None, "标题", "你好，微软", MB_OK);

And this is  what the box look like:

I hope the box can show Chinese friendly, What should I do? Am I missed some API?

You should try the MessageBoxW variant. You'll need to make sure your strings are null terminated and encoded as utf16. You can take a look at this file from Minesweeper:
https://github.com/robmikh/minesweeper-rs/blob/master/src/wide_string.rs

Yep, as @robmikh mentioned, you need to use the Unicode or "wide" variant of the APIs that typically end with a W (e.g. MessageBoxW).


documentation: updates for rostest

Modify documentation to reflect the new API for rostest, see ros/ros_comm#555.

I guess this patch would also apply to the "format1" version of this:
https://github.com/czalidis/catkin/blob/documentation_rostest/doc/howto/format1/rostest_configuration.rst
It's a little tedious to keep them in sync, but we should try to. Can you please update the "format1" version with your changes as well?

Otherwise it looks good, thanks @czalidis. +1

Ok, I'll do. I completely forgot about "format1"...

Can you please add a newlines before the start of a new sentence (in the paragraphs you added)?

You mean that each sentence should start in a new line? (because thats not the case for the rest of the document)

Yes, this is currently our recommended style since it makes diffs easier to read.
Otherwise changes can propagate through the whole paragraph due to re-wrapping everything.
Don't worry about the existing paragraph - they need to be cleaned up at some point.

Thanks!


:robot: Build and publish ubuntu arm generic

Currently, we only release the opensuse-leap, but we can already build ubuntu and maybe others too? Not sure if we want to provide all flavors also as generic, I know this adds to the build time, but my fear would be that if we never test them, they might be in a broken state and we will not notice. So let me know what you think

Building them doesn't mean we test them, unless they are used in some test scenarios. Is there really a benefit in building more of them?

yeah indeed, I meant to say testing the build at least ... but it's a good question, not sure who would be consuming these so no idea if there's little or much value from it

@mudler what is the goal for the generic images? Should we have ready to download images from all flavors, or just having the existing one is ok?

We discussed this in planning. This is the outcome:
We don't have a plan on how to automate the arm testing (because emulating arm on non-arm CPUs with qemu is very slow). For this reason, it doesn't make sense to built too many flavors for this. As soon as we automate testing, we can add more.
For now, testing will be manual and one flavor should be sufficient.

Makes sense closing


Readme needs to be updated with an example for getting the "location" from a model

I've been really struggling to figure this out.
I know that request.location has "country" and "city" methods, but I really want to get the country and city from my model, which is geocoded_by :ip_address. I couldn't find any examples of how to do that. My model has latitude and longitude coordinates, and those are being set correctly. But now how do I get the country and city based on those coordinates?

Oh I see, geocoded_by ONLY returns a latitude and longitude. I need to use reverse_geocoded_by if I want to store the city and country in the database.


Staging never completes when Java buildpack is selected

Issue appears to be caused by the length of the buildpack name returned from the detect script. Since the Java one is really long, adding decorator names causes it to overrun some (undocumented?) limit.


After read parquet file  by parquetRead  result object is not full

Hi,
version : ^1.1.0
I have file parquet compression SNAPPY, when
let fileData: any[][] = [];

	var asyncBuffer: AsyncBuffer = await asyncBufferFromUrl(url);
	await parquetRead({
		file: asyncBuffer,
		compressors: {
			SNAPPY: snappyUncompressor()
		},
		onComplete: (data): void => {
			fileData = data;
		}
	});

parsed result is not complete
22425501.parquet.zip
in unparsed structure missed Menu->categories->dishes->addons->items-> price, volume, ingredient (this object total unparsed) in source data for this object is present
from source file
���Dish extra 1���Dodatki do ≈õniadania�  ƒ•∆Ö����������Ì���<��ˇˇˇˇ�""ÎÂÄˆ���������Ì����òòÖ®ÿ������‡»����∂Ì���21985972���21985948���22861716���22673128���22672907XX≤£ﬂº <�����861005���20997760���11742617���895653�((ùÒôÊ�����‡»����ˇˇ‰�$$øÙª€<�����UK���EN���PL�88Ω≠â¿ �����h9∂l�������§í$�  ùÄËÙ<�����–¶–µ–±—É–ª—è���Onion���Cebula���asd ���≈ömietana 12%���–ö–∞—Ä—Ç–æ–ø–ª—è���Potato���Ziemnaik�<<‹®à¯�����h9∂l�������à∆˙à��
In parsed
ingredient: undefined In source value for this field is preset (it required field)
price: undefined, (some is filled some empty but in parsed i missed for all)
volume: undefined (some is filled some empty but in parsed i missed for all)

@menesty thanks for the report and the clear repro steps.
I've just published a new version v1.1.1 which includes a fix for nested struct parsing. The output now matches pyarrow and duckdb. Please let me know if that solves your problem!


Integrate oculus audio spatializer

Hey, not sure if this has been discussed already but I'm curious if anyone has attempted to integrate the oculus audio spatializer into this plugin. I played around an AudioStreamPlayer3D and it seems like godot's default audio system is nowhere near good enough for compelling VR. I don't mind taking a stab at integrating the library, but I wanted to drop an issue here to track it and in case anybody has advice/recommendations.

@ellenhp that would be super cool, would this be for things like HRTF?

Yeah, the main benefit is getting their HRTF pipeline. That said, looking through the docs shows they do also have the ability to take 3d meshes and dynamically estimate reverberation for a given environment. I'm not sure how simplified these meshes have to be, and whether or not that's something that's feasible to integrate.
The basic idea of what I'm thinking is subclassing AudioStreamPlayer3D (call it ARVRAudioStreamPlayer3D or something) for the audio sources and rerouting the audio from these players to the oculus API if available, otherwise going through the default audio system. If I end up figuring out how to pass meshes to the audio system I'll likely do so by letting developers add a ARVRAudioMesh node as a child of their big static meshes like buildings and terrain. The node would handle extraction of the mesh from the parent and passing it down to native code where it can be sent to the oculus audio driver. That's the first design that popped into my head, so I'm very open to feedback.
I do want to emphasize though that the primary thing I'm hoping to accomplish is getting the HRTF stuff working. I think that's the bare minimum. I can imagine reverb being a huge pain, so I don't want to over-promise.

That sounds like a good approach!
I would involve @BastiaanOlij in the design for the ARVRAudioStreamPlayer3D class as we'd probably want an API flexible enough to support other VR (and maybe AR) backends.

I can't say I've dived into the audio side of Godot much at all. Eric (Oculus) did mention before he'd be interested in seeing us support the audio side of the Oculus SDK.
From what little I played around with it with the gun tutorial I did a sound played can be location based so it adjust volume per ear and optionally pitch for a moving sound source, that audio stream is then input into Godots audio bus system where effects are added and sounds of different sources are mixed to create a final output to the speakers.
I'm not sure how that would fit in with the approach Oculus takes and how the two could be combined or make use of eachother.

After discussion on the discord, I elected to try to integrate Resonance Audio into godot instead of linking with a platform-specific audio library. There's a proof of concept of this integration here: https://github.com/ellenhp/godot/tree/hrtf
I'm working on a PR to add it to godot knowing that it's not super likely to be accepted as-is. Hopefully it'll start the discussion though.

Hi, I’m really interested in using HRTF on the Oculus Quest in Godot as I consider it essential for VR. Did anything ever came out of this?

I did manage to integrate resonance audio into godot, but it broke with a recent change for 4.0. @fire has been working on fixing it I think. He also maintained a 3.x branch of the audio spatialization code for a while.

https://github.com/V-Sekai/godot/tree/feature/spatial-audio is my branch with a demo project at https://github.com/V-Sekai/godot-spatial-audio-project

@fire Do you plan to open a PR to integrate your spatial audio changes?

I am currently spread thin, so I wasn't expecting to open a pull request to Godot Engine 4.0.
@ellenhp and I didn't have a good design for the Resonance Audio technology so the api is jankly integrated.
Assistance welcome and appreciated.
We sketched out a design where we extract the ambisonic coding from the Resonance library, but I'm more focused on game related things.
There was also a reverb audio based on a variation of a nav mesh but for open spaces. There is a prototype youtube video, but I think the last gap was generating the "sound graph" node for transmission of the reverb audio network rather than hand coding the graph.

Yeah, there are a few things we could do. Reduz made a proposal for one way we could add spatial audio if I remember right. But doing it in a non-disruptive way to the rest of the engine is tricky and would take a lot of work. Depending on how much of a hurry you're in to get something working I'd consider forcing Godot into 7.1 mode and applying a HRIR to each channel during down-mixing to stereo. You could also increase the maximum number of channels slightly (from 8 to 9, rounding up to five l/r pairs) and then use those 9 channels to encode a second order ambisonic representation of the sound from each 3d source. Then mixing would happen as normal and you could inject some ambisonic decoding code into the final mixing step.
Come to think of it, I wonder how hard it would be to replace the current channels system with something a bit more generic. An array of 4 AudioFrames and a hard cap at 8 channels is a bit limiting, and the mapping from those 4 AudioFrames to a 7.1 system is so artificial that I wouldn't mind if someone improved it (3 of the AudioFrames correspond to symmetric speaker pairs but for one of them the left goes to subwoofer, right goes to center, or vice versa). I personally think there's a lot of room for a cleanup of the channels system, and if it were cleaned up in a forward-thinking way, it's entirely possible that the channel systems could be pluggable. If SPCAP became a module, spatial audio could also be a module which would make the maintenance burden so much smaller for people who need to do spatial audio.
I also really believe this is important because, plainly, SPCAP performs very poorly for stereo audio with default parameters. It's passable if you have stereo speakers but for headphones it really is unacceptably bad IMO. If we modularize the channels system we could maintain SPCAP as a loudness-preserving panning system for 3.1, 5.1, 7.1 and introduce some other, better panning algorithm for stereo which is what 90% of our users will be doing anyway.


Add: hassentitylist

Description
Adds a new tidbyt app which allows for multiple HomeAssistant entities to be displayed together. Its primary designed use case is to show a list of HomeAssistant step tracker entities in a list, and order them from most-to-least steps.

Copilot

copilot:all

I have read the CLA Document and I hereby sign the CLA.

recheck