Fixed #34384 -- Used secret key fallbacks for user in request session.

ticket-34384

@David-Wobrock Thanks :+1: Please add a release note (4.1.8), and see my comment.

@ezarowny Does it work for you?

Thank you all for helping out on the PR 👍
Awesome team work 🙌


stdin is missing(no output), when using the engine to do digest.

here is my test code
when i create the EVP_MD by nid :
int res = 1;
if ((md = EVP_MD_meth_new(nid, 0)) == NULL) {
        WARN("Failed to allocate cipher methods for nid %d\n", nid);
        return NULL;
}
res &= EVP_MD_meth_set_init(md, my_sha1_init);
res &= EVP_MD_meth_set_update(md, my_sha1_update);
res &= EVP_MD_meth_set_final(md, my_sha1_final);
res &= EVP_MD_meth_set_cleanup(md, my_sha1_cleanup);
res &= EVP_MD_meth_set_flags(md, MY_FLAG);
res &= EVP_MD_meth_set_app_datasize(md, sizeof(MY_CTX));

and then in method my_sha1_final
static int my_sha1_final(EVP_MD_CTX* ctx, unsigned char* md)
{
    // here is the SHA1 code
    memcpy(md,sha1_result,size);
    LOG(sha1_result);
    return 1
}

then i do the test :
echo "Hello" | apps/openssl dgst -sha1
echo "Hello" | apps/openssl dgst -sha1 -engine myengine

Then the result will output in my log , but it won't show in the (stdin) , like this:
engine "myengine" set.
(stdin)=

and my openssl version is 1.1.1f , not sure is thisproblem with my code or a problem with openssl.
Thanks

is anybody have seen this bug ?

I very much suspect the problem is in your LOG function.  Without seeing it there is nothing anyone can to do assist.

@paulidale says:

Where does the engine "myengine" set. message come from?

https://github.com/openssl/openssl/blob/f775b5c4857d1fef67f487c2ec6017b1f1c6eb19/apps/apps.c#L1317


You can assign to local variables outside the scope with regex

Right now we only have a list of constant IDs for match write nodes, but this doesn't convey the depth. (It actually does add the locals to the correct scope though, so this is more of an enhancement than a bug.)
As an example:
a = 1
tap { /(?<a>)/ =~ to_s }

This will yield a match write node with locals: [:a] with no knowledge of depth. We should replace this constant[] with a node[] and use local variable target nodes instead.

I actually walk my static scope stack to reacquire depth.   I think it makes more sense to use Nodes here as well especially if you are not compiling code but merely using it as a syntax tool.


Recruitify v7.2

Made the Preview button at the center and addeda hover effect to it

Heyy @priyam-03 I have fixed the issues as per your request. Please check and update me if there are any changes i need to make


When listing objects in a huge S3 bucket it exceeds the call stack limit

Probably a bit of an edge case but if you try to deploy a massive site to a massive bucket (mine is 71.7GB and has 167,651 objects):
RangeError: Maximum call stack size exceeded
I think this is to do with the way the list objects function is called recursively. Maybe implementing a queue here would fix this issue?

I don't think a queue is necessary. We could fix this by using async/await within a loop, removing the recursion.

I'm trying to reproduce this. I spun up a new EC2 instance and used it to populate a bucket with many tiny files.
mkdir files
cd files
dd if=/dev/urandom bs=1024 count=256 | split -a 5 -b 1 - file.
aws s3 sync . s3://manyfilestest.joshwalsh.me

Now I'm trying to deploy my site to the same bucket. How long does it usually take before it gives the error? Mine has been sitting on Listing objects... for a while.


Central List not updating schedule

I have copied the example json, but the scheduler is not updating to reflect the file.
Node-Red v0.18.2

Almost one year ago and I ran into the same problem.
I created a 'http in node' to serve the central list, which works fine if I call it via the browser (plus I can see the GET-request at the debug tab), but there's no (GET) request fired by the scheduler and I waited several times for more than 10 minutes.
Did you solve it somehow?

I figured it out, 'hassio' as domain doesn't work, because it points to the internal docker ip and port 1880 isn't open. It works well with the "external" ip.
I think the example is wrong, the description is 'use the 26th May 2009', so it has to be '[{"id":0,"start":"2009-05-26T10:00:00.000Z","end":"2009-05-26T17:00:00.000Z"},...'.


RadioTherm CT100 support

I'm interested in knowing if this can be supported and how. I'll be willing to help contribute if pointed in the right direction.

Support for Radiotherm devices is provided by the Python module radiotherm. To support the CT100 series the module needs to be expanded.

@fabaff Thanks for pointing me to the module. My thermostat is a CT100 v0.08. This model isn't a WIFI version. It is a Z-wave only. Will I still be able to expand the module to getting it working or this module only supports the WIFI models?

@slimatic check this pr https://github.com/balloob/home-assistant/pull/1416
it will add z-wave thermostats


docs: register vite for the open-source developer incentive scheme (tea)

Description
The purpose of this PR is to create a reward/incentive for developers who contribute to the vite project.
This is achieved by registering the project with the tea protocol, a newly created initiative to offer incentives to developers of registered open source projects.
This pull request creates a registration file (tea.yaml), which enables the project to start earning incentives.
Additional context
The tea protocol distributes intrinsic incentives to opensource projects, based on the value they bring to the open source ecosystem. It also distributes donated incentives to a project and its downstream components, so those downstream components get appropriate recognition for the value they contribute.
Early adopters to the tea protocol earn greater incentive rewards, as rewards only start accruing from the point the project is registered. The full background to the tea initiative is explained here https://tea.xyz/what-is-this-file
The tea protocol scans github for the tea.yaml file in this pull request, as a basis to start accruing incentives
I am a tea protocol community member tasked to find and propose high value projects to receive incentives. I do not receive the incentives that stream to this project, these are earned by the project and its contributors.
I do receive a 1 off recognition for finding worthy projects. This project was one of my 1st thoughts to propose, as it is a common dependency in project I've developed
What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[X] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[X] Update the corresponding documentation if needed.
[X] Ideally, include relevant tests that fail without this PR but pass with it.

Hi, we've discussed this recently and decided to not go with this for now, but thanks for the proposal!


Including the escape single quotes warning in the next 0.9 release

Not sure how the release process works. This is just an attempt to get the escape quotes warning out of the next 0.9 release.
This is a:

[x] documentation update
[x] bug fix with no breaking changes
[ ] new functionality
[ ] a breaking change

All pull requests from community contributors should target the main branch (default).
Description & motivation

Checklist

[x] This code is associated with an Issue which has been triaged and accepted for development.
[ ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[ ] Postgres
[ ] Redshift
[ ] Snowflake

[ ] I followed guidelines to ensure that my changes will work on "non-core" adapters by:

[ ] dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
[ ] using the limit_zero() macro in place of the literal string: limit 0
[ ] using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP

[ ] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have added an entry to CHANGELOG.md

@joellabes -- let me know if I can do anything to help get this thru. There were a couple commits in here that I didn't expect so see and I added an entry in the changelog for the hypothetical 9.6 release. Not sure if that all follows the process.

Thanks @jsnb-devoted, just released a fix for this separately 🙏


Spike review: GitHub Issues

Now that the spike on GitHub Issues is complete, we need to review the plugin evaluation doc and map out next steps.

The plugin evaluation doc was reviewed offline. With the PR accepted in the upstream plugin, we are good with what is there today. The plugin has also been added to the showcase app, so this spike and follow-on activities are complete.


Incompatible typescript error

I have the following error message when i try to use the plugin in my app:
store.use(PiniaSharedState({ enable: true, initialize: false })):
Argument of type '({ store, options }: PiniaPluginContext<string, StateTree, _GettersTree<StateTree>, _ActionsTree>) => void' is not assignable to parameter of type 'PiniaPlugin'.
  Types of parameters '__0' and 'context' are incompatible.
...

Is it no longer compatible with the current pinia version?

Updated pinia version. Can you try again?

Thanks , now it's working 👍


Generate feeds by categories?

Possible?

Yes, it will put rss.xml (and other files) into category directory as well.


Build aperture-tech-docs in PR to verify that changes are correct

Add a CircleCI Job that will trigger on PRs with documentation changes to verify that the documentation is building correctly.

Merged as part of a PR that fixed go templates used to generate markdown


Asset utils: Fetch static UObject/UClass from asset in ctor

As observed, the warning of specific assets over their missing UE version (thus might not be fully functional) appears as being loaded from a map or directly from cpp, or opened in the Editor.
Normally UE should provide backward compatibility to assets but as transition from UE4 to UE5, it seems the project's Contents are not auto converted.


Add to_tidy method for converting time-series repr to tidy

Codecov Report
Patch coverage: 88.23% and project coverage change: +0.31 :tada:

Comparison is base (f094556) 76.66% compared to head (9221d85) 76.97%.

:exclamation: Current head 9221d85 differs from pull request most recent head 6c12221. Consider uploading reports for the commit 6c12221 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   76.66%   76.97%   +0.31%
==========================================
  Files           9        9
  Lines         617      634      +17
  Branches      150      129      -21
==========================================
+ Hits          473      488      +15
- Misses        118      119       +1
- Partials       26       27       +1

Impacted Files
Coverage Δ

src/pandas_indexing/__init__.py
80.00% <ø> (ø)

src/pandas_indexing/core.py
82.14% <85.71%> (+0.21%)
:arrow_up:

src/pandas_indexing/accessors.py
86.04% <100.00%> (+0.50%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


needed libboost version for compiling

This issue is about the compatibility of newly compiled versions on linux 64bit machines against different libboost versions.
Let me explain:
I wanted to run crave <IP_ADDRESS> as a masternode on a ubuntu 16.04 but compiling failed because of too low memory (a VPS, 2GB, no swap possible because of btfrs).  So "bad luck", I sticked to the binary version 2.1.0 which runs smoothly so far after some little issues.
But later I thought to compile crave <IP_ADDRESS> on another machine and just copy it and maybe conribute it to the community, because nobody cares at the craveproject website so much for the linux versions. I compiled on ubutnu 14.04, but there the compiler comes out of the box with libboost version 1.54, but compiling worked fine and crave and also the masternode mode run smoothly.
So I copied craved in the corresponding directories on ubuntu 16.04 and tried to run it. Then the dark knight called  "Sir Sucks-a-lot" came by and shouted at me:
./craved: error while loading shared libraries: libboost_system.so.1.54.0: cannot open shared object file: No such file or directory
Obviously craved loads some shared libraries which must exist on the system in a specific version, but on ubuntu 16.04 I can not (and don want) downgrade. Also maybe other libs also needs to be downgraded later - not a sustainable way. But on 14.04 I also don't want to upgrade and recompile. The highest version I can reach is anyway 1.55, but ubuntu 16.04 comes around with 1.58 for libboost and if I want to contribute a complete Version for Linux 64bit as a binary later it needs to be statically compiled and not dynamically loading different libraries of specific versions.
Is it possible to change that and to let people on 64bit linux machines upgrade to <IP_ADDRESS>?
If there is a simple solution afterwards I will contribute the 64bit and 32bit versions and keep them up-to-date.

Feeling so lonely in this issue thread!

HI. If you use *nix systems you must know that static linking is completely removed from GNU. So it's impossible to do what you want.

i don't want it statically linked but maybe the dependencies could be more generous?
is it not possible to let craved just use the version of libboost it find on the system it is started on?

It's not craved issue, it's *nix systems feature, so it's not possible.


Enforce a strict pdf naming convention

This will allow my grading scripts to run easier and we won't have to rename stuff manually.

This is irrelevant now that we are using canvas grader.


[trailblazer clues] found a wrong message of a clue that is indeed possible to succeed

This issue is for the external plugin: {trailblazer clues}

later got closed


fix slice memory leak

modified:   transfer.cc

When using slice plugin, in a close procedure of a sub request, a passive_vc calls PluginVC::do_io_close and PluginVC::process_close reschedules active_vc using core_lock_retry_event. Then another PluginVC::reenable of active_vc calls by PluginVC::process_write_side of passvie_vc using sm_lock_retry_event. in this case, a PluginVC::process_read_side calling will set need_read_process to false, and another PluginVC::main_handler will not call PluginVC::process_read_side. Then handle_server_resp of slice plugin could not be called with TS_EVENT_EOS event, upstream of data could not close and data will leak. Here is a pull request to fix this memory leak


good job! but how to set the continuousWaveform = true?

like this url: https://wavesurfer.xyz/examples/?record.js
record = wavesurfer.registerPlugin(
RecordPlugin.create({
renderRecordedAudio: false,
scrollingWaveform,
continuousWaveform,
continuousWaveformDuration: 30, // optional
}),
)
how to set the continuousWaveform = true?   thanks

Hi @ctrlaltman,
Thank you for reporting the issue! I've reviewed your query and identified the solution. The recordPluginOptions configuration supports continuousWaveform as well as other options. Here's a minimal example demonstrating how to set it up:
const containerRef = ref<HTMLDivElement | null>(null);

const options = computed(() => ({
    height: 48,
    waveColor: "#66667D",
    progressColor: "#6A24FF",
    barGap: 5,
    barWidth: 5,
    barRadius: 8,
    cursorWidth: 0,
    url: "https://revews-bucket.s3.ap-southeast-1.amazonaws.com/a06mmMU3sgnzuUkH4OiHvyuUgCFdLSnJaDLBao7y.webm",
}));

const { pauseRecording, startRecording, stopRecording, currentTime, isPauseResume } = useWaveSurferRecorder({
    containerRef,
    options: options.value,
    recordPluginOptions: {
      continuousWaveform: true,
      // Add other supported options here as needed
    },
});

This setup ensures that `continuousWaveform` and other `recordPluginOptions configurations` are properly applied.

Additionally, please ensure you have updated to the latest version of the package to access this functionality. Feel free to let me know if you encounter any issues or need further assistance!


Use latest liferay version

Current coverage is 63.13%

Merging #66 into master will increase coverage by +0.53% as of f36da7a

@@            master     #66   diff @@
======================================
  Files           26      26
  Stmts          730     830   +100
  Branches        90      92     +2
  Methods          0       0
======================================
+ Hit            457     524    +67
  Partial         36      36
- Missed         237     270    +33

Review entire Coverage Diff as of f36da7a

Powered by Codecov. Updated on successful CI builds.

Just started reviewing :) :octocat: Sent from GH.


Linux: Fix emojis not showing in the game log

VRCX on Windows relies on Segoe UI Emoji font to render emojis in the game log to indicate a friend or a favourite, as this font is proprietary it cannot be used on Linux, I have remapped Segoe UI Emoji to use twemoji font instead (MIT licence)
It lacks colour but properly shows up

Tested on Fedora 41 and OpenSUSE Tumbleweed

I have completely replaced the system emoji font usage with Noto Color Emoji via @infolektuell/noto-color-emoji npm package, this change will affect everyone not just the Linux version; I have kept the earlier change adding twemoji as a system emoji font for Wine for further compatibility. I believe this should be good to merge now.


Connect smd to Telegram

Hey guys,
Do you have any idea to how can we connect SMD to our telegram bot?
I'll really appreciate if you can help me.
Thanks.

https://t.me/SpotifyMusicDownloaderBot - you can use this one.

Yes, I have it, but I want to use my own server when you are down. :(

You can just use the desktop version in this case.


adding support for importing images between providers

at first will be implemented only for IBM PVS <--- IBM PVC import
added 'import_image_queue' and supplimenting methods to 'ManageIQ::Providers::CloudManager::Template'
static method self.import_image_queue accepts as options 'provider_id' and 'image_id'
'options[:provider_id]' contains provider id from which an image will be imported
'options[:image_id]' contains image id which is to be imported from the above provider
base class implementation queues an event and the handler can be implemented in children
base class also contains empty implementation of the event
added short comments description for 'import_image_queue'
incorporated "rubocop" suggestions

@iv1111 can you talk through the decision to implement this as a CloudManager::Template class method?  Not sure what that buys us over implementing it on the CloudManager as an instance method as that would give us the provider to import into automatically.  A class method on the template doesn't appear to buy us much and is a little confusing because I believe the action is acting on the provider not a template right?

@agrare Hi. I've seen create_image_queue in the code, which is implemented as a class method too. So, I decided to proceed in a similar way. We had a short discussion about this back in Feb.

Where do I have to move the code then to? To app/controllers/api/base_controller/manager.rb?

Okay following the pattern of .create_image works even though I think that is a little strange as well

@iv1111 can you squash the commits that modified then restored the gemfile since those are unrelated to this change?

seems that "supports_feature_mixin" does not contain a hash of queriable actions anymore

I guess we are good to go then. Is it possible to merge it in a squashed way?

We don't squash & merge, please rebase to squash to the commits you want

@agrare Done. I've squashed them into one. Thanks for the review and help in the resolution of issues.

@iv1111 do you have an API PR that goes with this?

@iv1111 do you have an API PR that goes with this?
Not yet, I'm working now on making one.

Created the corresponding PR in the manageiq-api repository: https://github.com/ManageIQ/manageiq-api/pull/1021


Error messages in f-strings use the location of the f-string

Similar to #145 but less severe. We now use the location of the f-string when reporting any linter errors within an f-string, which is inaccurate (but an improvement).

Fixed by @harupy in https://github.com/charliermarsh/ruff/pull/1494.


Failed config

hello,
when i  use multiple UART buses esphome fail config.
Failed config
sml: None
Too many candidates found for 'uart_id' type 'uart::UARTComponent' Some are 'my_uart', 'my_uart1'.
[]
#################################################
esphome:
name: sml-32
esp32:
board: esp32dev
framework:
type: arduino
logger:
web_server:
port: 80
local: true
api:
ota:
password: "86ad66ea5b9b72bccf57812ec0157368"
wifi:
ssid: Mi wifi1
password: behnam123
ap: {}
captive_portal:
external_components:

source:
type: local
path: components
components: [ obis_d0 ]

uart:

id: my_uart
rx_pin: GPIO16
tx_pin: GPIO17
baud_rate: 300
data_bits: 7
parity: EVEN
stop_bits: 1
id: my_uart1
rx_pin: GPIO19
tx_pin: GPIO18
baud_rate: 300
data_bits: 7
parity: EVEN
stop_bits: 1

obis_d0:

id: my_sm
uart_id: my_uart
id: my_sm1
uart_id: my_uart1

sensor:

platform: obis_d0
name: "Positive active energy (A+) total"
obis_d0_id: my_sm
obis_code: "\x021.8.0"
unit_of_measurement: kWh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kWh"

platform: obis_d0
name: "active energy (A+) in tariff T1"
obis_d0_id: my_sm
obis_code: "1.8.1"
unit_of_measurement: kWh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kWh"

platform: obis_d0
name: "active energy (A+) in tariff T2"
obis_d0_id: my_sm
obis_code: "1.8.2"
unit_of_measurement: kWh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kWh"

platform: obis_d0
name: "active energy (A+) in tariff T3"
obis_d0_id: my_sm
obis_code: "1.8.3"
unit_of_measurement: kWh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kWh"

platform: obis_d0
name: "active energy (A+) in tariff T4"
obis_d0_id: my_sm
obis_code: "1.8.4"
unit_of_measurement: kWh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kWh"

platform: obis_d0
name: "reactive energy (Q+) total"
obis_d0_id: my_sm
obis_code: "3.8.0"
unit_of_measurement: kvarh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kvarh"

platform: obis_d0
name: "reactive energy (Q+) in tariff T1"
obis_d0_id: my_sm
obis_code: "3.8.1"
unit_of_measurement: kvarh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kvarh"

platform: obis_d0
name: "reactive energy (Q+) in tariff T2"
obis_d0_id: my_sm
obis_code: "3.8.2"
unit_of_measurement: kvarh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kvarh"

platform: obis_d0
name: "reactive energy (Q+) in tariff T3"
obis_d0_id: my_sm
obis_code: "3.8.3"
unit_of_measurement: kvarh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kvarh"

platform: obis_d0
name: "reactive energy (Q+) in tariff T4"
obis_d0_id: my_sm
obis_code: "3.8.4"
unit_of_measurement: kvarh
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{6}\.\d{2}\*kvarh"

platform: obis_d0
name: "active maximum demand (A+) total"
obis_d0_id: my_sm
obis_code: "1.6.0"
unit_of_measurement: kW
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{3}\.\d{3}\*kW"

platform: obis_d0
name: "reactive maximum demand (Q+) total"
obis_d0_id: my_sm
obis_code: "3.6.0"
unit_of_measurement: kvar
accuracy_decimals: 4
state_class: total_increasing
device_class: energy
value_regex: "\d{3}\.\d{3}\*kvar"

platform: uptime
name: Uptime
id: uptime_sensor
update_interval: 60s
on_raw_value:
then:
- text_sensor.template.publish:
id: uptime_human
state: !lambda |-
int seconds = round(id(uptime_sensor).raw_state);
int days = seconds / (24 * 3600);
seconds = seconds % (24 * 3600);
int hours = seconds / 3600;
seconds = seconds % 3600;
int minutes = seconds /  60;
seconds = seconds % 60;
return (
(days ? to_string(days) + "d " : "") +
(hours ? to_string(hours) + "h " : "") +
(minutes ? to_string(minutes) + "m " : "") +
(to_string(seconds) + "s")
).c_str();

platform: wifi_signal
name: "WiFi Signal Sensor"
update_interval: 60s

text_sensor:

platform: obis_d0
name: "Device Identification"
obis_d0_id: my_sm
obis_code: "C.1.0"
value_regex: "\w{16}"

platform: template
name: Uptime
id: uptime_human
icon: mdi:clock-start

platform: version
name: "Version"

##############################

platform: wifi_info
ip_address:
name: IP Address
ssid:
name: Connected SSID
bssid:
name: Connected BSSID
mac_address:
name: Mac Wifi Address
scan_results:
name: Latest Scan Results

binary_sensor:

platform: status
name: "obis reader status"

##################################

platform: gpio
pin: GPIO34
name: "Cover alarm"
device_class: window

switch:

platform: restart
name: "obis reader Restart"

output:

platform: gpio
pin: 5
id: output1

button:

platform: output
name: "Get data "
output: output1
duration: 500ms
on_press:
then:

uart.write:
id: my_uart
data: [0x2F, 0x3F, 0x21, 0x0D, 0x0A]
delay: 1s
uart.write:
id: my_uart
data: [0x06, 0x30, 0x30, 0x30, 0x8D, 0x0A]

Please check if this fix works for you.

Hello . There is no error in compilation.
thanks for solving this problem.


Adds config.templates to a GET /campaigns/:id response [pr]

What's this PR do?
Modifies the campaign-get middleware in a GET /campaigns/:id response to query Contentful for the campaign entry that has a campaignId field value matching our campaign id passed in the query parameter, parse it, and set it as a config property on the campaign.

Renders the newly added webSignup field as a config.templates.webSignup property - returning the text to send a user, and the topic to set the conversation to

Adds a campaignConfigs cache to cache campaign Contentful entries

Adds a cache query parameter to the GET /campaigns/:id endpoint to allow manually clearing Redis cache for the campaign and campaignConfig

This still needs more unit tests (e.g. parseCampaignConfig) but wanted to open at this point to help keep this reviewable)
How should this be reviewed?
Verify GET /v1/campaigns/2299 contains a config set as expected. This is the only campaign I've added a webSignup value for, but will be backfilling all current campaigns that are sending web signup messages.
Any background context you want to provide?
Once this is in place, Signup message requests in gambit-conversations will be updated to inspect the config.templates.webSignup property instead of the first item it finds in the topics array.
We also aim to deprecate the MENU command per https://www.pivotaltracker.com/story/show/159796050 -- which means we'll no longer need the GET /campaigns resource to include a list of topics by campaign for anything business critical (Gambit Admin can be updated to either make multiple requests, or start on GraphQL integration). This means we can remove a lot of the complexity around caching a long list of all topics for the sake of returning topics by campaign in these endpoints.
Relevant tickets
Similar to https://www.pivotaltracker.com/story/show/157369418 in the sense that admins no longer require the web signup topic to match a keyword topic, broadcast topic, etc.
Checklist

[x] Documentation added for new features/changed endpoints.
[ ] Tested on staging.

Tested on staging, and verified config.templates.webSignup I've created for our test campaign 2299, https://ds-mdata-responder-staging.herokuapp.com/v1/campaigns/2299:

{
  "data": {
    "id": 2299,
    "title": "Two Books Blue Books",
    "tagline": "Host a Dr. Seuss book drive to benefit kids in family shelters.",
    "status": "active",
    "currentCampaignRun": {
      "id": 6441
    },
    "config": {
      "id": "68Oy1FcaR2EiaMieicaoom",
      "templates": {
        "webSignup": {
          "text": "Thanks for signing up for Two Books Blue Books! To get started, click this link: https://www.dosomething.org/us/about/our-people",
          "attachments": [

          ],
          "template": "webSignup",
          "topic": {
            "id": "2Wzzquygx2wwMWe8kQAMgc",
            "name": "Two Books Blue Books autoReply",
            "type": "autoReply",
            "createdAt": "2018-08-10T00:36:19.926Z",
            "updatedAt": "2018-08-13T14:16:42.499Z",
            "campaign": {
              "id": 2299,
              "title": "Two Books Blue Books",
              "tagline": "Host a Dr. Seuss book drive to benefit kids in family shelters.",
              "status": "active",
              "currentCampaignRun": {
                "id": 6441
              }
            },
            "templates": {
              "autoReply": {
                "text": "Who let the dogs out?",
                "topic": {

                }
              }
            }
          }
        }
      }
    },
    ....
  }
}


Approving Additional Photo + Quantity on Existing RB does not change total approved quantity

Added new photo to existing RB, increased quantity, submitted. No change in total approved quantity (good). Approved reportback, but total approved quantity did not register update -- not sure if I need to run cron to get it to do so?

(Regardless of whether the new photo is approved or not, running CRON changes the total reportback quantity (total approved quantity) to the new quantity; the first file associated with the RBID has already been classified as reviewed.)


handle ~ in local repo paths

This adds code to resolve ~ in local paths to the user's home
directory. It also ensures that the user's home dir is replaced with ~
in the output of repository list and skeleton list to make paths
shorter.

Codecov Report

Merging #41 into master will decrease coverage by 0.23%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   73.16%   72.93%   -0.24%
==========================================
  Files          24       25       +1
  Lines        1092     1112      +20
==========================================
+ Hits          799      811      +12
- Misses        206      211       +5
- Partials       87       90       +3

Impacted Files
Coverage Δ

pkg/cmd/skeleton/list.go
76.47% <50.00%> (-4.18%)
:arrow_down:

pkg/skeleton/info.go
85.48% <50.00%> (-2.66%)
:arrow_down:

pkg/homedir/homedir.go
71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caff9d7...f90e74c. Read the comment docs.


Documentation on module usage

The documentation for use as a module seems to be a bit outdated.
# Module Use

from pylode import OntDoc

# initialise
od = OntDoc(ontology="some-ontology-file.ttl")

# produce HTML
html = od.make_html()

# or save HTML to a file
od.make_html(destination="some-resulting-html-file.html")

In the current code base, shouldn't that be something like:
# Module Use

from pylode.profiles.vocpub import VocPub
# or from pylode.profiles.ontpub import OntPub

# initialise
od = VocPub(ontology="some-ontology-file.ttl")

# produce HTML
html = od.make_html()

# or save HTML to a file
od.make_html(destination="some-resulting-html-file.html")

hi @edmondchuc and @nicholascar . Thank you for PyLODE. Is the project still actively maintained ? Looking at the commit history I would think it is, but I am surprised that an issue like this one has a MR that is not merged. Would you need help to review it ?


[enhancement] Allow a different method of viewing spell text on prewritten spellbooks

The text on spellbooks can be quite difficult to read due to its angle, font and size. A method of viewing it more easily, whether through opening a gui, displaying it on the tooltip or printing into chat, would help massively with accessibility,

This already exists! You can view spellbook text in a GUI by placing it into a vanilla lectern or converting it into a book.

i feel like a tooltip with spellbook's contents, visible while not holding the sneaking button would be nice.
by the way, @ssblur your discord invite on the curseforge page seems to be broken, could i please have a new one?

@B4CKU The Discord invite linked on the Curse page is a hotlink through http://dc.blur.lol and appears to still be working as of the time of writing. This links to https://discord.com/invite/fzZZhbe4rr
I have tried to use a tooltip in the past, however this can cause issues with longer books, and involves a not insignificant amount of work to get working to an acceptable level. At the moment, there are ways included in the game to view the contents of a spellbook. While I will be looking into other ways to potentially show this info, and definitely want to ensure Scriptor is accessible, I don't currently see an acceptable way to implement this as suggested.
Thank you again for your suggestion!


What do you mean by ascending and descending order?

Hi there,
Thanks for your great work! In section 4.4, you did an ablation study about adding prompt to transformer layers in descending order or ascending order. I don't quite understand this difference. Could you please elaborate on this?

Hi,
In the ablation study, we first control the number of transformer layers to add prompts (e.g., k layers). When added in descending order, it means these 4 layers are the last-k layers (e.g., layer 21-24 for BERT-large when k=4) of the transformer. If added in ascending order, it means these 4 layers are the top-k layers (e.g., layer 1-4 for BERT-large when k=4).


RAVTDBQ-171 Support for Default Constraint

Added support to create SqlNode for TIMESTAMP WITH TIME ZONE datatype.

L1 done. The changes look good to me.


Ensure same ordering in ControlledGate equality check

Breaking Change
Changes ControlledGate equality check to enforce gates have same order.
Fixes #5110

@tanujkhattar

@tanujkhattar I added a check in test_eq that also asserts the unitaries of each gate in an equivalence set is equivalent (the converse obviously does not always hold).
For (b), my understanding is we decided not to go that route. ControlledGate(Z, control_values=[0,1]).on(q0, q1) would equal ControlledGate(Z, control_values=[1,0]).on(q1, q0). even though their gates don't match. This is consistent with how PauliString and DensePauliString work:
    q0, q1 = cirq.LineQubit.range(2)
    ps1 = cirq.DensePauliString('XY').on(q0, q1)
    ps2 = cirq.DensePauliString('YX').on(q1, q0)
    assert ps1 == ps2  # passes
    assert ps1.gate == ps2.gate  # fails

@daxfohl You are right. Thinking a bit more about it, I think there are still some rough edges with the way controlled ops and gates interact. For example:

Two equal controlled operations can have different unitaries.

cop1 == cop2 but cirq.unitary(cop1) != cirq.unitary(cop2)
The reason is the same as what you mentioned for the controlled gate case -- i.e. unitary cares about qubit ordering but equality check doesn't.
The way this is handled for pauli strings is that we have provided an explicit .matrix() method which takes a qubit order and returns the unitary matrix for that particular ordering.

cop.gate and cop.with_qubits(*new_qubits).gate will be generally true if the qid_shape for all qubits is the same, but it'll be false if we have multiple qubits with different shapes.

This is because with_qubits() preserves the ordering of control_values but changes the ordering of qubits.
This is the right thing to do for the operation, but it does assume that the user knows what they are doing.
So, it's possible that op.with_qubits(new_qubits) throws an error if the new ordering of qubits is not consistent

But anyways, I think these issues are independent of the change being made here so I'll be happy merge this PR.


Remove pen test environment

Context
Remove pen test env as ITHC's have been completed
Pen resources have already been destroyed.
Changes proposed in this pull request
Remove pen config files
Remove pen references from code
Guidance to review
Check I haven't missed anything
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Register API pen test


Update .gitignore

Proposed changes
The Tarball instructions have the reader download the zst file, but it is missing from the .gitignore so it shows up as a new file to be added.
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[ ] I have read the CONTRIBUTING document
[ ] I have added Molecule tests that prove my fix is effective or that my feature works
[ ] I have checked that all Molecule tests pass after adding my changes
[X] I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

I didn't read https://github.com/rancherfederal/rke2-ansible/blob/main/CONTRIBUTING.md because that's a dead link... :man_shrugging:

fixed with https://github.com/rancherfederal/rke2-ansible/blob/1fd346d3ceb0dec2670142f5704979e7aec580fe/.gitignore#L12-L13


Child element constructor is called twice

Description
When you render a child Lit element, the constructor is called twice.
This has been causing some problems: particularly with the web-dialog component that is throwing exceptions when it's rendered inside of a Lit element. It's logging a console error on the second element creation.
Minimal repro: https://github.com/RandomEngy/lit-double-ctor-repro
I write a console message each time the child element class instance is constructed and you see two entries for Sub element created.
Using lit 2.2.0.
Steps to Reproduce

Render a child Lit element as part of a parent lit element.
Observe the number of times the child element constructor is called.

Expected Results
Constructor is called once
Actual Results
Constructor is called twice
Browsers Affected

[x] Chrome
[ ] Firefox
[x] Edge
[ ] Safari 11
[ ] Safari 10
[ ] IE 11

(Possibly more, only tested in Edge and Chrome)

That seems like a large project for a reproduction... what should I be looking at? Can you make a live reproduction on lit.dev?

I copied the official Lit starter project to get this repro. I'll try to get a lit.dev repro this weekend.

Here's an repro on the Lit playground. It reproduces if you clear the console then refresh.


Update CODEOWNERS

per #43 , : remove javier added jose
What type of PR is this?
Add one of the following kinds:

subproject management

What this PR does / why we need it:
Updates CODEOWNER following change of Telefónica representative.
Which issue(s) this PR fixes:

Fixes #43
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

@Kevsy for CODEOWNERS it looks good to me - I've invited @JoseMConde to get a CAMARA member and into @camaraproject/simple-edge-discovery_codeowners. We need to wait for the acceptance of the invite.

Thanks @Kevsy, I have pending to create this PR, thanks a lot. :)
@hdamker I've recieved an email notification, but nothing that I have to accept.
It is more like an information mail.

Sorry for the inconveniences.

@hdamker I've recieved an email notification, but nothing that I have to accept.
It is more like an information mail.

I see ... I don't how the acceptance actually looks like, but I can confirm that you have somehow accepted the invitation (and others not yet, you might can see it as a member at https://github.com/orgs/camaraproject/people). BTW: I have deleted the picture of the mail as it potentially contained personalised links.
So we are good to go here.


Fixed a bug preventing navigation via omnibar due to loading outside Angular

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #332   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          61     61
  Lines        1453   1455    +2
  Branches      228    228
=====================================
+ Hits         1453   1455    +2

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

#srcapp
100% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/app/app.component.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939db63...850d1a8. Read the comment docs.


"Best Guess" finishing strategy results in lost postcards

The way we were saving the response after choosing the highest-confidence matching bird species, left the selection ignored, and thus finishing the postcard discards that sighting, rather than selecting the correct species.
So if a postcard included one sighting with a recognized bird, and one sighting with "cannot decide", it would save the recognized bird, but would not save the best-guess bird for the 2nd sighting. And because the postcard was "finished", there's now no other way to get back the discarded sighting (not entirely true: I believe there is a graphql mutation that allows us to convert a sighting back into a recognized bird, but it is not implemented, and it requires knowing the sighting id which cannot be discovered except via log files or automation trace history)

This was addressed in jhansche/pybirdbuddy#1, by handling each sighting in the postcard independently. This applies the preferred finishing strategy to each sighting, rather than applying it to all sightings in the postcard.
Now in the above scenario, it handles each sighting in the postcard separately, so it will accept the recognized sightings as they are, and when choosing the species for the best-guess sighting or converting a sighting to a "mystery visitor", it now correctly takes the api response sighting report as a way to build upon the progress of that postcard, so that when submitting the finalized postcard report, it contains all the right report tokens.
This was fixed in pybirdbuddy v0.0.7 which will be in the next release. The change is binary compatible, so it can be tested using the "main" branch of ha-birdbuddy.


Add a feature to add previously solved leetcode questions.

You can use the Manual Submit Button that appears on the solution page for each accepted solution to reupload previous solutions. Is this what you mean?


I have completed the Exploratory Data Analysis. Now I will be proceeding with models to be tested.

Pull Request for ML-Crate 💡
Issue Title: BellaBeat - Capstone Project by Google

Aim of the project : The aim of this project is to create a model which will analyze the Bellabeat project.
Name: Arjit Bhardwaj
GitHub ID: BhardwajArjit
Idenitfy yourself: KWOC Contributor

Closes: #248 (partially)
Describe the add-ons or changes you've made 📃
Till now I have completed the Exploratory Data Analysis and concluded the correlations between various variables.
Type of change ☑
What sort of change have you made:
Exploratory Data Analysis completed
Example how to mark a checkbox:-

[x] My code follows the code style of this project.
-->
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
No issues so far
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Hi @abhisheks008, I have updated the pull request as per the changes requested. Kindly review it.
Definitely, I'll complete this project before 9th January 2024.
Kindly consider this PR for the mid evals.

Hi Abhishek,
I have updated PR with changes requested. Kindly review it.
On Fri, Dec 22, 2023 at 9:39 AM Abhishek Sharma @.***>
wrote:

Assigned #456 https://github.com/abhisheks008/ML-Crate/pull/456 to
@BhardwajArjit https://github.com/BhardwajArjit.
—
Reply to this email directly, view it on GitHub
https://github.com/abhisheks008/ML-Crate/pull/456#event-11322440791, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2EMD64PCVCGBK4VI27UWLDYKUBZFAVCNFSM6AAAAABA42TXX2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZDENBUGA3TSMI
.
You are receiving this because you were assigned.Message ID:
@.***>

Looks good to me. Proceed with the models once you are ready to do it. I will not merge this PR as of now, make the whole project and update it here. I have noted your work for the mid evaluations.

Sure. Thanks a lot.

Hi @abhisheks008, I have updated the PR with the models. Please review the whole project.


reverting a merge commit using revert -m

Hi,
Thanks a lot for your tool which is excellent.
I wanted to add an exercise about how to undo a faulty merge, following: https://www.kernel.org/pub/software/scm/git/docs/howto/revert-a-faulty-merge.txt
It seems that when trying to revert a merge commit, the tool accepts it, whereas git asks for  something like: git revert -m 1 Cx
Did I miss something ?

I wouldn't be surprised if we have a bug/mismatched git engine behavior with something like that :)


[Website] Downloading talk slides

Some participants are asking whether is it possible to download slides associated with the talks. So, is it possible to do so?

@abdullah-alnahas Unfortunately, I don't think it's possible as our infra team doesn't have the access to the uploaded slides.
I suggest them to reach out to the authors for such requests.
(Closing this one now)


Low level design and migration plan for new Stateful Network Firewall design

User Story
We currently use Network firewall with stateless rules.  This causes issues for some types of traffic and we have to bypass the firewall.  We have a high level design for a stateful firewall here https://app.diagrams.net/#G1w8dZs5vZOoy0dvCnRr5P6GHc3VQRdwLq on the TGW and NWFW integration tab.
This redesign will have impact on the existing networking and we need to carefully plan the changes so that they do not majorly impact platform users (some downtime may be unavoidable).
This ticket is to complete analysis and create a detailed plan on how to achieve this.
Note there are 2 tickets which will help make this work simpler and should be done in advance of the changes to the firewall:
https://github.com/ministryofjustice/modernisation-platform/issues/1397
https://github.com/ministryofjustice/modernisation-platform/issues/2010
Definition of done

[x] detailed plan of migration to new design
[x] new issues for the work created

Reference
How to write good user stories

Completed pending review of document in team google drive

https://docs.google.com/document/d/1tMMCJtsmgLXOhCw9wW9su12IRnqlb7-n2AemIn1zCjg/edit


Test suite failed to run, Could not find source file

🐛 Bug Report
Jest fails to find tests, ends with error:
● Test suite failed to run

    Could not find source file: 'C:\path\to\project\src\test-file.spec.ts'.

      at getValidSourceFile (node_modules/typescript/lib/typescript.js:135637:29)
      at Object.getSemanticDiagnostics (node_modules/typescript/lib/typescript.js:135859:36)
      at doTypeChecking (node_modules/ts-jest/dist/compiler/language-service.js:11:35)
      at node_modules/ts-jest/dist/compiler/language-service.js:96:25
          at Array.forEach (<anonymous>)
      at compileFn (node_modules/ts-jest/dist/compiler/language-service.js:94:26)
      at Object.compile (node_modules/ts-jest/dist/compiler/instance.js:90:25)
      at TsJestTransformer.process (node_modules/ts-jest/dist/ts-jest-transformer.js:94:41)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:479:35)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:569:40)

Jest config:
 "jest": {
    "preset": "ts-jest",
    "testEnvironment": "node"
  }

To Reproduce
The only concrete reproduction step I was able to find and fix this is to downgrade ts-jest from 25.3.1 to 25.2.1, then tests are being discovered, are running and passing.  (or to make error re-appear - update it back to latest)
System:
OS: Windows 10
Npm packages:
    jest: 25.3.0
    ts-jest: 25.3.1
    typescript: 3.8.3

Please let me know if more info is needed.

Close as duplicated with #1506 , the fix already added. Please wait for the next release.


Cannot allocate memory

After a while of using Liburing I start getting OSError: [Errno 12] Cannot allocate memory message, no matter what I do after this point, its sticks to this message. Its as if io_uring_queue_exit() does not clean up after itself. I have to restart my system at this point.

Looks like memory leak. A few quick questions:

What kernel version do you use?
What op types you submit (i.e. IORING_OP_*)? E.g. *READV, *READ_FIXED, *READ, *TIMEOUT
Do you use fixed files and/or fixed buffers?
Are you re-creating io_uring instances dynamically or allocate them at the beginning?
Is it mult-threaded?
Did you check /proc/slabinfo ?

BTW, there is a new patch [1] dealing with memory leaks, can be related.
And it would be even more useful, if you can provide a reproducer or your program that triggered it.
[1]<EMAIL_ADDRESS>

1. What kernel version do you use?

linux5.8-rc4

2. What op types you submit (i.e. IORING_OP_*)? E.g. *READV, *READ_FIXED, *READ, *TIMEOUT

normally happens with socket for some reason file io seems to work fine. So io_uring_prep_recv, io_uring_prep_send with MSG_DONTWAIT and io_uring_prep_poll_add

3. Do you use fixed files and/or fixed buffers?

no, not yet

4. Are you re-creating io_uring instances dynamically or allocate them at the beginning?

set at beginning

5. Is it mult-threaded?

no

6. Did you check /proc/slabinfo ?

no, what should I keep an eye out for?
I am using this in Python
If that patch is going to be in the next rc5 I can test and let you know.

Thanks!

no, what should I keep an eye out for?

I want to see which bucket grows indefinitely. That can make obvious what
kernel structure leaks. E.g. struct io_kiocb, representing a single io_uring's
request, is in "kmalloc-256" or something similar.
You can attach its content here either after getting the error, or, If you can't
get it because of OOM, after running it for some time.

I am using this in Python

Doesn't matter

If that patch is going to be in the next rc5 I can test and let you know.

Great, that would be helpful

slabtop can be helpful in getting an overview of slabs that are growing out of control.
Where are you getting -ENOMEM? Please be specific. Is it in a cqe, or is it doing io_uring_queue_init()?

It would happen when io_uring_prep_init() would run again.
I will keep looking at slabtop, I will have to wait till next time it happens.
Would something like strace help?

What is io_uring_prep_init()? Please be as specific as you can, we don't necessarily have your source code or what you are running. An strace would certainly help, as it'll show where the error is occuring. Right now I'm just guessing it's io_uring_queue_init() -> io_uring_setup().

And even better than that, a reproducer would be very helpful too.

io_uring_prep_init(512, ring, 0)

I figure I run the test that comes with liburing at this point and this is the result. If I where to restart my system and run this test again, I am sure it would pass!

make[1]: Entering directory '.../Liburing/libs/liburing/test'
Running test poll
Running test poll-cancel
Running test ring-leak
Running test fsync
Running test io_uring_setup
io_uring_setup(0, 0x7ffe6ff476a0), flags: none, feat: none, resv: 0x00000000 0x00000000 0x00000000, sq_thread_cpu: 0
io_uring_setup(1, (nil)), flags: none, feat: none, resv: , sq_thread_cpu: 0
io_uring_setup(1, 0x7ffe6ff476a0), flags: none, feat: none, resv: 0x00000001 0x00000001 0x00000001, sq_thread_cpu: 0
io_uring_setup(1, 0x7ffe6ff476a0), flags: 0xffffffff, feat: none, resv: 0x00000000 0x00000000 0x00000000, sq_thread_cpu: 0
io_uring_setup(1, 0x7ffe6ff476a0), flags: IORING_SETUP_SQ_AFF, feat: none, resv: 0x00000000 0x00000000 0x00000000, sq_thread_cpu: 0
io_uring_setup(1, 0x7ffe6ff476a0), flags: IORING_SETUP_SQPOLL|IORING_SETUP_SQ_AFF, feat: none, resv: 0x00000000 0x00000000 0x00000000, sq_thread_cpu: 16
Needs root, not flagging as an error
PASS
Running test io_uring_register
RELIMIT_MEMLOCK: 65536 (65536)
io_uring_register(-1, 0, (nil), 0)
io_uring_register(3, 0, (nil), 0)
io_uring_register(4,<PHONE_NUMBER>, (nil), 0)
io_uring_register(4, 0, 0x7fffed6f3fa0, 1)
io_uring_register(4, 0, 0x7fffed6f3fa0, 1)
io_uring_register(4, 0, 0x7fffed6f3fa0, 1)
Unable to map a huge page.  Try increasing /proc/sys/vm/nr_hugepages by at least 1.
Skipping the hugepage test
reserve file-backed buffers
io_uring_register(4, 0, 0x7fffed6f3fa0, 1)
expected 95, got 12
io_uring_register of 131072 bytes failed with ENOMEM (expected).
io_uring_register of 65536 bytes failed with ENOMEM (expected).
successfully registered 32768 bytes (0).
io_uring_register(4, 0, 0x5617154da6c0, 1025)
io_uring_register(4, 0, 0x5617154da6c0, 1024)
expected success, got 12
allocated<PHONE_NUMBER>0 bytes of address space
io_uring_register(4, IORING_REGISTER_FILES, 0x7f755867e000, 32767)...succeeded
io_uring_register(4, IORING_UNREGISTER_FILES, 0, 0)...succeeded
io_uring_submit:
opcode: 6
flags:  0x00000000
fd:     4
poll_events: 0x00000005
io_uring_register(4, 2, 0x7fffed6f3f1c, 1)
FAIL
Test io_uring_register failed with ret 1
Running test io_uring_enter
io_uring_queue_init: Cannot allocate memory
Test io_uring_enter failed with ret 1
Running test nop
Running test sq-full
Running test cq-full
Running test 35fa71a030ca-test
Running test 917257daa0fe-test
Running test b19062a56726-test
Running test eeed8b54e0df-test
Running test link
Running test send_recvmsg
queue init failed: -12
Running test a4c0b3decb33-test
Running test 500f9fbadef8-test
Running test timeout
Running test sq-space_left
Running test stdout
This is a pipe test
This is a fixed pipe test
Running test cq-ready
Running test cq-peek-batch
Running test file-register
Running test cq-size
Running test 8a9973408177-test
Running test a0908ae19763-test
Running test 232c93d07b74-test
Running test socket-rw
Running test accept
test_accept_sqpoll: skipped, not root
accept: accept.c:229: test_accept_many: Assertion `io_uring_queue_init(2 * nr, &m_io_uring, 0) >= 0' failed.
timeout: the monitored command dumped core
./runtests.sh: line 58: 82947 Aborted                 timeout --preserve-status -s INT $TIMEOUT ./$T $D
Test accept failed with ret 134
Running test timeout-overflow
Running test defer
ring setup failed
Test defer failed with ret 1
Running test read-write
SQPOLL requires root, skipping
buffer reg failed: -12
test_io failed 0/0/0/1/0/0
Test read-write failed with ret 1
Running test io-cancel
ring create failed: -12
test_io_cancel 1 1 failed
Test io-cancel failed with ret 1
Running test link-timeout
Running test cq-overflow
Running test link_drain
Running test fc2a85cb02ef-test
Test needs failslab/fail_futex/fail_page_alloc enabled, skipped
Running test poll-link
Running test accept-link
Running test fixed-link
Running test poll-cancel-ton
ring setup failed: -12
Test poll-cancel-ton failed with ret 1
Running test teardowns
Running test poll-many
failed ring init
poll-many failed
Test poll-many failed with ret 1
Running test b5837bd5311d-test
Running test accept-test
Running test d77a67ed5f27-test
SQPOLL requires root, skipped
Running test connect
Running test 7ad0e4b2f83c-test
Running test submit-reuse
Running test fallocate
Running test open-close
Running test file-update
Running test accept-reuse
io_uring_init_failed: -12
Test accept-reuse failed with ret 1
Running test poll-v-poll
Running test fadvise
Running test madvise
Suspicious timings (56 > 44)
Running test short-read
Running test openat2
Running test probe
Running test shared-wq
Running test personality
Not root, skipping
Running test eventfd
Running test send_recv
./send_recv: skipping SQPOLL variant
Running test eventfd-ring
Running test across-fork
Running test sq-poll-kthread
sqpoll requires root!
test_sq_poll_kthread_stopped_exit: skipped
sqpoll requires root!
test_sq_poll_kthread_stopped_noexit: skipped
Running test splice
Running test lfs-openat
Running test lfs-openat-write
Running test iopoll
iopoll requires root, skipping
Running test d4ae271dfaae-test
Test requires root, skipping
Running test eventfd-disable
Running test close-opath
Running test ce593a6c480a-test
Running test cq-overflow-peek
OVERFLOW not set on -EBUSY, skipping
Running test statx
Running test sq-full-cpp
Tests  <io_uring_register> <io_uring_enter>        failed
make[1]: *** [Makefile:100: runtests] Error 1
make[1]: Leaving directory '.../Liburing/libs/liburing/test'
make: *** [Makefile:20: runtests] Error 2

What's your ulimit -l setting for the user you are using?
I discovered a small gap where ring exit + ring init could fail, because we account the memory freed only after the async ring exit work has run. Posted a fix here. Not sure if it's your issue, but it's definitely an issue if you are very tight on your ulimit -l setting and you do back-to-back exit+init of rings.
https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.8&id=309fc03a3284af62eb6082fb60327045a1dabf57
In any case, please try it.

ulimit -l is 64 for the user, I have tried messing with that setting before in the past, I could only change it as su and it would reset back.
Yes, I would be working on Liburing for hours and slowly these problems would start here and there and it would gradually get worst.
I would have to wait till next Linux5.8-rc5 to try the patches.

For now, just edit /etc/security/limits.conf and add this line at the end:
*                -                memlock                -

and you should be fine.

Ok, done, thanks.

The fix is upstream now, so it'll be in -rc5. Please do retry with -rc5 once released, or just use current linus -git.

I am not getting that error anymore on rc5, loos like that patch did the job, nicely done.. @axboe

Great, it was just down to timing then, no leak.Thanks for re-testing!

any workaround for older kernels?
since ubuntu is the most popular linux thing, this will take a while until uring is usable :/

The patch is going into 5.7-stable (it's already been added, so will be in the next release). Earlier kernels are not affected.

ah nice. i'm on 5.7.8 and affected. so this version is unpopular enough to ignore the problem?

The distros will track -stable, so once 5.7.9 is out it should propagate to the distros pretty quickly. As a work-around until that happens, just increase the memlocked limit as mentioned above.

https://lwn.net/Articles/826290/
5.7.9 is out, was released an hour ago.


[cudapoa] keep member type and allocation size in sync

The way cudapoa allocates buffers right now is by calculating the size based on type of the struct elements. However, the sizing calculation uses the type explicitly instead of drawing it from the member element directly. This means the type has to be specified in two places, and more importantly updated in two places concurrently, which is the source of many problems.
It would be a good idea to use something like http://www.cplusplus.com/reference/typeinfo/type_info/name/ to keep the types in sync so they only need to be updated in one place.

Could you elaborate on the problem a bit? Right now, I doubt that typeinfo is the right tool.

@ahehn-nv here's an example of the problem -
Struct member defined here - https://github.com/clara-genomics/ClaraGenomicsAnalysis/blob/dev-v0.5.0/cudapoa/src/cudapoa_kernels.cuh#L113
The allocation is done here - https://github.com/clara-genomics/ClaraGenomicsAnalysis/blob/dev-v0.5.0/cudapoa/src/allocate_block.hpp#L224
So we want to keep the types in sync. I realize typeinfo isn't the right one (I briefly looked at it), but maybe decltype is better for it?
P.S. This aside, the allocation in cudapoa can also do with an overhaul with our new alocator classes and so on.

@ahehn-nv - I was being daft and overthinking it. sizeof(variable_name) would work just fine for this problem.

Yes, that sounds better. :+1:


Updates UID:s in the test data to remove invalid values

Changed the UID:s in the test DICOM files to remove invalid UID:s and the related warnings from pydicom when reading the data.

I stilll get warning messages on "siemens_axiom_artis.dcm", "philips_allura_clarity_u104.dcm", and "philips_allura_clarity_u601.dcm". I am using pydicom version 3.0.1.
Any ideas why?

E.g. "Invalid value for VR UI: '1.2.8<IP_ADDRESS>80043.8.971.00.37881344602234345332104216659618145'." with "philips_allura_clarity_u601.dcm"

Well... it could be because I made a double error. One in the loop replacing invalid UID values and one in the validation run. :)
I've had another go at it now. Could you @MaxHellstrom  try and verify that the new UID don't give any warnings on your end now.

Thanks. All files works now!


Add support for "Automatic" splits

Summary of the Pull Request
Adds support for auto as a potential value for a splitPane keybinding's split argument. For example:
        { "keys": [ "ctrl+shift+z" ], "command": { "action": "splitPane", "profile": "matrix", "commandline": "cmd.exe", "split":"auto" } },

When set to auto, Panes will decide which direction to split based on the available space within the terminal. If the pane is wider than it is tall, the pane will introduce a new vertical split (and vice-versa).
References
PR Checklist

[x] Closes #3960
[x] I work here
[x] Tests added/passed
[n/a] Requires documentation to be updated

Validation Steps Performed
Ran tests, played with it.

@msftbot merge this in 5 minutes


Change reflexive -> reflective

This is really cool.
When reading through the code I noticed that you use the term "reflexive" rather than "reflective" which doesn't seem accurate to me (by my understanding of "computational reflection").

Ah, thanks for pointing this out! Something new that I've learned today.
I had definitely heard the other one and adopted it for explaining my own work on computational reflection. I guess I figured that since the technique is called "computational reflection", the tactics would be called "reflective".

To be clear, I don't know which one is correct. I think that changes other than replacing reflexive with reflective are valuable, at least.


IActionViewItem should not live in common

The IActionViewItem-type defines the html rendering of an action. However, for some unknown reason that interface is defined in common  (src/vs/base/common/actions.ts), with an ugly render-signature like this: render(element: any /* HTMLElement */): void;. There used to be a duplicate definition, and more correct declaration of that interface but that got (rightfully) removed by @joaomoreno via https://github.com/microsoft/vscode/commit/e7279b1c505569c52d9f813b9c76476374001db0.
This issue is about moving the type into its correct location and that starts with fixing dependencies that also live in common. I could only find two: src/vs/workbench/common/views.ts#IViewPaneContainer and src/vs/workbench/common/composite.ts#IComposite.

There used to be a duplicate definition, and more correct declaration of that interface but that got (rightfully) removed by @joaomoreno via e7279b1.

It was a lovely week, everybody on vacation, so I went around the codebase with a chainsaw.

🪓  Yeah, not blaming. the action and action rendering world hasn't received any love in last 5 years - it's about time

Removed it from src/vs/workbench/common/views.ts#IViewPaneContainer.
Assigned @bpasero forsrc/vs/workbench/common/composite.ts#IComposite.

I removed IActionViewItem from IComposite, I think moving IComposite is not an option.

Thanks everyone


DOC: <Issue related to /docs/integrations/tools/eleven_labs_tts/>

URL
https://python.langchain.com/docs/integrations/tools/eleven_labs_tts/
Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
Is this doc updated? I've tried the simple example, and didn't worked
Idea or request for content:
Is this doc updated? I've tried the simple example, and didn't worked

created PR to fix the tool https://github.com/langchain-ai/langchain/pull/27130


[backport/0.40] Backport important patches

Describe changes
Backports some fixes to 0.40:

fixes the user activation flow.
pins openAI to <1.0.0
pins slqmodel to 0.0.8

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Gave up getting this through the CI because too much has happened since 0.40


KeyError in MosesDetokenizer

Getting a KeyError when trying to detokenize three or more symbols:
from nltk.tokenize.moses import MosesDetokenizer
MosesDetokenizer().detokenize(['```'])

  File "/usr/local/lib/python3.6/site-packages/nltk/tokenize/moses.py", line 613, in detokenize
    return self.tokenize(tokens, return_str)
  File "/usr/local/lib/python3.6/site-packages/nltk/tokenize/moses.py", line 574, in tokenize
    if quote_counts[normalized_quo] % 2 == 0:
KeyError: '```'

In printable ASCII characters, the problem seems to occur for ",  ',  and `.
Using Python 3.

@moiri-gamboni Thanks for catching that!! My bad on this.
Missed the initialization for the normalized quote at https://github.com/nltk/nltk/blob/develop/nltk/tokenize/moses.py#L566. Currently, the line quote_counts.get(normalized_quo, 0) does nothing. It should have been:
quote_counts[normalized_quo] = quote_counts.get(normalized_quo, 0)

It should correspond to this line in detokenizer.perl in moses


Android/Linux/Vpn

I dont knew if I can ask Questions here but I do it anyway =).
I have setup WebUi with my Android phone, it works fine with my local ip on the server. But when I try to come from outside local network with my external ip it do not work.
What am I suppose to do, get ddns ore am I doing something wrong?

That's right! You have to access using you public IP address.
On Mon, Sep 3, 2018 at 5:39 PM nph479<EMAIL_ADDRESS>wrote:

I dont knew if I can ask Questions here but I do it anyway =).
I have setup WebUi with my Android phone, it works fine with my local ip
on the server. But when I try to come from outside local network with my
external ip it do not work.
What am I suppose to do, get ddns ore am I doing something wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lgallard/qBittorrent-Controller/issues/165, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF6EtxWm-AiaSzwTxd0ClMFNNerMnKwmks5uXZN8gaJpZM4WYB94
.

I have done this, same settings in the server and the Android, the router have 8080/8999 in the UPnP service list.
If I just change the Ip to local and there is the torrents list.

Configure a second server for your public access!

Ok. Now I try both ip "<IP_ADDRESS>" "<IP_ADDRESS>" is this correct?
Local ip works ok but public not, I also try in my computer web-browser and Local ip ok but not Public ip.

Take into account that probably your public IP is set to your router, therefore you must NAT your traffic to your PC. Check your router settings to achieve that!

Now I have try with Virtual server with Port 8080 open and also Port-triggering with Port 8080 but outside Lan I cant get connection.
 Is there a tutorial for all this?

You have to NAT you traffic.


[release-0.34] fix pdb controller segfault

manual backport of the primary fix and unit test for #5849
This backport focuses only on the segfault and targeted unit test and does not include the other unit test enhancements #5849 introduced.
Fixes event recording causing a segfault in virt-controller

/retest

/lgtm
/approve


Publish HTML docs for 1.1 RTL in addition to main

Currently the docs workflow only publishes documentation for registers at main. To make it easier to look up registers for 1.x, also publish the registers from the patch_v1.1 branch.
This was tested on my fork of this repo. See sample output:

Workflow run: https://github.com/jhand2/caliptra-rtl/actions/runs/12472498726
main: https://jhand2.github.io/caliptra-rtl/main/internal-regs/?p=
1.1: https://jhand2.github.io/caliptra-rtl/v1_1/internal-regs/?p=

Not sure what I'm supposed to do to bypass the test timestamp, since this is a documentation-only change:
Latest non-doc hash is d5cfea9be870d8539efef4462eef4b564d01553e
Error, submitted timestamp [1734735334] is outdated: it precedes the latest non-documentation commit to branch by more than an hour [1734981795]
Please rerun any internal/company proprietary testcases, which should invoke .github/scripts/stamp_repo.sh to attest to successful completion
DO NOT manually run stamp_repo.sh on your branch to bypass this step - the output timestamp/hash is used to verify internal testcase sign-off is successful

Thanks for doing this Jordan, nice improvement!
The hash check is firing because this PR modifies a yml file. The "doc-only" exception currently only applies to .md/.png files.
We could probably stand to except the workflow files as well - adding ! -path "*.github/workflows/* here: https://github.com/jhand2/caliptra-rtl/blob/docs_1_1/.github/workflows/pre-run-check.yml#L102 should do the trick.
A couple additional requests as part of this PR:

Update https://github.com/jhand2/caliptra-rtl/blob/docs_1_1/.github/workflow_metadata/README.md to indicate that the hash check workflow also ignores updates to workflow yml files
Update https://github.com/jhand2/caliptra-rtl/blob/docs_1_1/docs/CaliptraReleaseChecklist.md to include a task for updating doc_gen.yml to include version-specific register documentation at the time of each new release.

Also, a topic for discussion in the WG: Do we go back and retroactively update the README from patch_v1.1 to point to these new pages?
We could just directly update the release collateral https://github.com/chipsalliance/caliptra-rtl/releases/tag/v1.1


Cannot send on macos

Hello,
Using a locally built version of bob (using opam pin) on a macos 12.6.1 (x86-64), the send does not work see below:
> bob send <file> -r <our relay> -vv
Password: wheayantelt-moadth
[ 62196][     DEBUG][            bob.pack]: Compute <file>.
[ 62196][     DEBUG][          bob.stream]: End of the file: <file>
[ 62196][     DEBUG][           bob.fiber]: Close the file-description 4
[ 62196][     DEBUG][            bob.pack]: <file> -> 299192bd26006baa2b1704c6924368a21600dbff
[ 62196][     DEBUG][            bob.pack]: Store of <file>.
[ 62196][     DEBUG][            bob.pack]: The PACK stream is ready to be sent.
[ 62196][     DEBUG][           bob.fiber]: Call to connect() (operating system: Unix)
[ 62196][     DEBUG][           bob.fiber]: Set file-descriptor into a non-blocking mode.
[ 62196][     DEBUG][           bob.fiber]: Try to connect to <our relay>
[ 62196][     ERROR][           bob.fiber]: Got an error for a non-blocking connect(): Operation now in progress.
bob: connect(): Operation now in progress.

[ 62196][     DEBUG][           bob.fiber]: Close remaining file-descriptions:
[]

Any hint would be appreciated.

This seems to be related to the behaviour of connect. We had already reported different behaviour on different platforms (see #13) but it seems that my previous version of me had already suspected a possible error on macOS:
https://github.com/dinosaure/bob/blob/f898b50855af838b2e8e9542f203975410d1aec2/lib/fiber.ml#L239
Thank you for your issue, I am unfortunately not a Mac owner, can you test this version (#28) of Bob which should (a priori) fix your issue?
We should probably also look at Cosmopolitan support. It seems to me that the "bob.com" version works on MacOS (surprising) which describes a behaviour I had not imagined (maybe on MacOS, IsFreeBSD returns true...).

Hi,
Testing is still not satisfying. Now it can connect but it only send 64KiB and then terminate.
The debug trace is too big for this forum (1.1 M). You can find it there https://gist.github.com/fdagnat/ae32ea9e64fc3f465d8c909a7b2a5c48
Have a good day

it only send 64KiB and then terminate.

I will try to figure out why. It will take a time because it seems that this bug appears only on MacOS (and I need to talk to some friends to reproduce & test your case). Can you tell me which version of OS X do you have and which Mac (to be able to reproduce then)?

As already said above, I run macos 12.6.1 on a x86-64 mac.

With the help from @kit-ty-kate (who she has a MacOS too), I can understand a bit more what is going on. It seems that problem is much more related to how we read the given file than the transmission and/or the protocol (which is a kind of good news). More concretely, it seems that bob only read 64Kib of your file and terminate by an End_of_file here:
https://github.com/dinosaure/bob/blob/f898b50855af838b2e8e9542f203975410d1aec2/lib/stream.ml#L748-L752
(Confirmed by your log here).
This signal can come from read() or a possible double-close of the file-descriptor or simply from an exception leak. Unfortunately, I am blindfolded on this issue and need more information on Bob's behaviour on macOS. In the PR proposed above, I have added a commit that adds logs for the three cases described. Would it be possible to rerun your example and get the log? Finally, only the logs for bob.fiber and bob.stream (probably bob.pack as well) are interesting.

Hi again,
No problem for testing. Do not hesitate. My only question is how do I limit the logs to the bob.fiber, bob.stream and bob.pack?

We don't have yet a standalone mechanism to filter logs. You probably can just save all logs into a file and do a grep like:
$ bob send -p <password> file.txt &> log.txt
$ grep "bob\.\(fiber\|pack\|stream\)" log.txt

For the moment the complete debug is here: https://gist.github.com/fdagnat/38c48d12b392e5fd2e1c68185c3eb805

For the moment the complete debug is here: https://gist.github.com/fdagnat/38c48d12b392e5fd2e1c68185c3eb805

Arf, I forgot to notice you to re-update the version of bob:
$ opam pin add bob https://github.com/dinosaure/bob.git#fix-connect-macos-native
$ opam reinstall bob

https://gist.github.com/fdagnat/b6ff30fa4a910ccbabef31fc8993e341, is it better?

Yes, it's better, I will try to figure out from this outcome what is going on precisely :+1:.

I think I finally found the issue. It seems that the End value is given by something else than our read() syscalls. Now, we have 2 possibilities: an exception leak or a signal from select about an exception.
https://github.com/dinosaure/bob/blob/f898b50855af838b2e8e9542f203975410d1aec2/lib/fiber.ml#L386-L391
The documentation about the select() behavior and the possibile difference with a BSD/Linux system is not clear. So I decided to avoir the handler of select()'s exceptions. I updated #28 with that. I added some logs too to really figure out the execution path in details. Can you re-update Bob and show the same kind of logs?
$ opam pin add bob https://github.com/dinosaure/bob.git#fix-connect-macos-native
$ opam reinstall bob
$ bob send -p <password> file.txt &> log.txt
$ grep "bob\.\(fiber\|pack\|stream\)" log.txt

https://gist.github.com/fdagnat/d530d233914d381f9c067d8022bba3ef

It seems to work, probably, on the other side, you must have the same version of bob but from what I see, bob transmitted the whole file. Can you confirm that?

Hum, the other party was a colleague on Linux using the official bob release. He get a file but with an error about the hash of the file. We can do more testing tomorrow if it is needed.
Thanks for your work

Thansk, I just made a PR (#30) for that and the upstream version of Bob should work. I relaunched a build on https://builds.osau.re/ to integrate this PR into the bob.com binary. I rebased #28 with this PR too. If we take in account your last log it seems that the error is more about the transmission than the MacOS support now.
It will be useful to get a log from the sender (with a MacOS & the fix available on #28) and the receiver (whatever the system & bob~upstream).
On the sender, something like:
$ opam pin add bob https://github.com/dinosaure/bob.git#fix-connect-macos-native
$ opam install bob
$ ob send -p <password> file.txt &> log.txt

And on the receiver:
$ wget https://builds.osau.re/job/bob/build/latest/f/bin/bob.com
$ chmod +x bob.com
$ ./bob.com recv <password> -vvv &> log.txt

It will be super useful.

Hello again,
Testing the new code, my file is systematically corrupted. On the receiver side we get:
> bob recv ...
Accept from ...:55967 [Y/n]:
>>> Received a file: 2211.16212.pdf.
>>> ⠇  128.0 KiB    1.4 MiB/s
[ 72890][     ERROR][           bob.fiber]: close(): Bad file descriptor
bob: Corrupted file (unexpected hash).

I tested with both send and receiver on my mac and with sender mac and receiver linux and got the same result.
By consequence, I think there is another issue. Notice that now the receiver gets 2 blocks of 64K. In case it may serve, I let the trace there https://gist.github.com/fdagnat/b537392382c67dc56ba8deedaf59d478.
Thanks again

I don't know if it's relevant, but it could be an idea to log a warning here:

You probably right but I don't think the issue about the corrupted file is related to this probable double-close. It's more about: how Bob deflates and transmits the file to the relay. The DNS part was already done before (just to resolve osau.re). My intuition is (only on Mac):

we start to deflate and transmit the file
at the end, we close the connection
the relay close abruptely the connection
the receiver close the connection too but it did not receive everything...

It's probable that, on Mac, when we close the socket, we did not send everything for whatever reason. Again, it's highly related to the system's behavior and Mac (probably) temporise TCP/IP packets. Something like a flush is probably needed.

To confirm my hypothesis, I just added a new commit on #28 which set the socket for the secure room with TCP_NODELAY. By this way, we ensure that the system should sends everything and properly close the socket then. I'm not sure that it's the right fix - and probably not the right solution - but it permits to restrict the system's behavior about the transmission.
@fdagnat Would it be possible to test with this new version (again, do the opam pin add and opam reinstall to make sure you have the right version). If the problem persist, I definitely need a MacOS to see what is wrong...

Good news! I have an access to a Mac and I can reproduce your error. I will try to fix that as soon as I can but the iteration between logs and bugs will be better! I will come back to you when I will fix the initial issue. Thanks for your patience.

I tried to play a bit with a Mac and see what happens. Currently, I can notice a real corruption between the sender and the receiver. As far as I can say, the relay is not the source of the bug but it seems that the sender craft a packet and send something which was changed by an other part of the code. This is indeed very intriguing. I'll try to look more closely at Bob's behaviour on the Mac, but it seems that the bug is related to the notion of block ownership.
Like you, locally (and the relay), everything works. Like you, if you force some scheduling with -vvv which does I/O, Bob works too. Otherwise, it doesn't work.


Add a GitHub Action for linting

We should add linting via golangci-lint to catch formatting and other issues early

+1
See https://github.com/operator-framework/operator-controller/pull/264 for an example


Build a simple app that uses this API

"The #1 best way to understand and address the weaknesses in an API's design and implementation is to use it in a production system. Whenever feasible, design an API in parallel with an accompanying integration of that API."
Maybe something like:
http://interactive.orlandosentinel.com/health-inspections/

Also it's a great way to showcase the API.

@marcoslhc is building our app here: https://github.com/marcoslhc/restaurant-inspections-webapp
Thank you! ;)

@marcoslhc how is the app going? I think @leordev  and I might build a second webapp to test some things, in clojurescript!

Features Stub
[ ] 1
[ ] 2

Just a quick update on the Front End app, @marcoslhs and I will be back by January to complete the first iteration.

@Pancakerobot The API is running here http://<IP_ADDRESS> You'll see the root endpoint responds with a description of all endpoints. All endpoints are GET requests and, when optional query params are available, they will be described on the API's JSON response.


Expose exception data in OnQuickShot failed?

Could your proved a reason/exception data in OnQuickShotFailed?  I'd like to be able to send telemetry and help customers if they having a problem.

Hi. Yes this sounds like a good idea. I will look into it

@dasgithub76 Hi. I just released update 1.3.0 which now provides you with a error message in onQuickShotFailed()


Add react-enhanced-form to build with s-c + typo

Add react-enhanced form to build with s-c section

👍


entc/gen: add SchemaType to generator

What this PR does: Exposes field.SchemaType to templates generated by entc/gen.

I signed the CLA, but no clue how to retrigger it. 🤷

Hey @jaredallard and thanks for your contribution!
Can you please elaborate why this change is needed, and why f.Column().SchemaType doesn't work for you?
See example in migrate/schema.tmpl.

Hey @a8m, sorry for the lack of context on this. This change was useful for me when attempting to get the schema type, but from the Nodes context. I looked at schema.tmpl but it seemed like I would need to do a lot of go-template logic to go from a given Nodes -> tables -> column -> SchemaType, and that's why it was useful! I could easily have missed something though, this seemed inline with the rest of the stuff on the Field type though so I figured this would be useful to have.
Thanks for your work on this project, by the way! I absolutely love it.

Looks like that works, so we can close this. Thank you!

Looks like that works, so we can close this. Thank you!

Wonderful! Thanks for your contribution 😄

Thanks for your work on this project, by the way! I absolutely love it.

Great to hear this! If your company uses it, it will be great if you can (and want to) add it to the ent-users wiki page - I'm trying to build a community for ent 😃


id3, how to  remove x-frame-option?

the identityserver3
the response-header always include the "x-frame-option",  i don't wanner this , so how i can do about it?

This is the IdentityServer4 issue tracker.


An add_package("glm") in a target won't be exported to other target which contains a dependency on the target

Describe the bug
I have a static target. GLM is added to it as a package, and its headers are exposed by calling add_includedirs with {public = true}. Now if I add this target as a dependency to other target, glm won't be exposed.
Here goes an example to reproduce it
xmake.lua
set_project(Test)
set_languages("c++17")

add_requires("glm 0.9.9+8", {alias = "glm"})

target("lib")
    set_kind("static")
    add_includedirs("lib/", {public = true})
    add_files("lib/*.cpp")
    add_packages("glm")

target("app")
    set_kind("binary")
    add_files("app/app.cpp")
    add_deps("lib")

lib/lib.h
#include <glm/vec3.hpp>
glm::vec3 mul(glm::vec3 vector, float factor);

lib/lib.cpp
#include <lib.h>
glm::vec3 mul(glm::vec3 vector, float factor) {
    return vector * factor;
}

app/app.cpp
#include <lib.h>

int main() {
    return 0;
}

Expected behavior
The example should be compiled
GLM headers should be exposed to app.cpp
Error output
% xmake -vD
[ 37%]: compiling.release lib/lib.cpp
"/usr/bin/xcrun -sdk macosx clang" -c -Qunused-arguments -arch x86_64 -mmacosx-version-min=11.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -std=c++17 -Ilib -I/Users/hebo/.xmake/packages/g/glm/0.9.9+8/d639b7d6e3244216b403b39df5101abf/include -o build/.objs/lib/macosx/x86_64/release/lib/lib.cpp.o lib/lib.cpp
[ 50%]: compiling.release app/app.cpp
"/usr/bin/xcrun -sdk macosx clang" -c -Qunused-arguments -arch x86_64 -mmacosx-version-min=11.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -std=c++17 -Ilib -o build/.objs/app/macosx/x86_64/release/app/app.cpp.o app/app.cpp
error: @programdir/modules/private/async/runjobs.lua:210: @programdir/modules/private/action/build/object.lua:75: @programdir/modules/core/tools/gcc.lua:473: In file included from app/app.cpp:1:
lib/lib.h:3:10: fatal error: 'glm/vec3.hpp' file not found
#include <glm/vec3.hpp>
         ^~~~~~~~~~~~~~
1 error generated.
stack traceback:
    [C]: in function 'error'
    [@programdir/core/base/os.lua:792]: in function 'raise'
    [@programdir/modules/core/tools/gcc.lua:473]: in function 'catch'
    [@programdir/core/sandbox/modules/try.lua:127]: in function 'try'
    [@programdir/modules/core/tools/gcc.lua:422]:
    [C]: in function 'compile'
    [@programdir/modules/private/action/build/object.lua:75]: in function 'script'
    [@programdir/modules/private/action/build/object.lua:88]: in function '_build_object'
    [@programdir/modules/private/action/build/object.lua:113]: in function 'jobfunc'
    [@programdir/modules/private/async/runjobs.lua:188]:
    [C]: in function 'trycall'
    [@programdir/core/sandbox/modules/try.lua:121]: in function 'try'
    [@programdir/modules/private/async/runjobs.lua:182]: in function 'cotask'
    [@programdir/core/base/scheduler.lua:317]:

stack traceback:
        [C]: in function 'error'
        @programdir/core/base/os.lua:792: in function 'raise'
        @programdir/modules/private/async/runjobs.lua:210: in function 'catch'
        @programdir/core/sandbox/modules/try.lua:127: in function 'try'
        @programdir/modules/private/async/runjobs.lua:182: in function 'cotask'
        @programdir/core/base/scheduler.lua:317: in function <@programdir/core/base/scheduler.lua:315>

Related Environment

xmake version: 2.3.8(brew)
os: macOS 11.0.1
target platform: macosx x86_64

Additional context
Note that GLM is a header only library. And I found while calling add_requires XMake merely put its headers into the inlude directory

A simple (but not so straight forward) workaround is to add add_packages("glm") to target app as well. According to  https://github.com/xmake-io/xmake/issues/1104 a new feature may be added in future?

A simple (but not so straight forward) workaround is to add add_packages("glm") to target app as well.

Well, it actually works

According to #1104 a new feature may be added in future?

Maybe it's a bug? But it may also be automatically fixed if adding the feature metioned in #1104

Maybe it's a bug? But it may also be automatically fixed if adding the feature metioned in #1104

It is not a bug. By default includedirs is private, users need to manually configure {public = true} to export it. Of course add_packages does not support it yet.
I will support it in future versions, but currently you can only add glm to the app target.

I have supported it. https://github.com/xmake-io/xmake/issues/1254


EKS create timeouts inconsistent between module and resource (over two repositories)

The default value here: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/variables.tf#L189
Is not consistent with the default value here: https://github.com/terraform-providers/terraform-provider-aws/issues/5165
It should be updated to "30m" to reflect the good default value selected else where.

I totally agree!
the defaults should come from upstream. Do you mind to open a PR? If not, I can do it

@verdverm @confiq Thanks for opening this issue. Can you please open a PR for this ?

I have a feeling that I've hijacked this issue :)
I've create the PR for this

Resolved by #736


Set volume size limit

Set max volume size limit for the tenant
There is a need to limit maximum size of a volume to levels
that the storage infrastructure can handle.
Setting a maximum limit on size of a volume also prevents
a tenant from creating large volumes that have not been tested
and certified to satisfy SLA objectives.

Thank you for contributing to openstack/cinder!
openstack/cinder uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


http 500 while pod is starting

Once the pod is running, the page loads fine. This happened while waiting for the pod to start.
log:
<IP_ADDRESS> - - [10/Jul/2018 06:56:58] "GET /jupyterhub/services/notebooks/demo/test/74871936eed7d586d8034a3ecadd444f369492df?branch=master HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2309, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
    response = self.handle_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1741, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/app/src/notebooks_service.py", line 77, in decorated
    return f(user, *args, **kwargs)
  File "/app/src/notebooks_service.py", line 218, in launch_notebook
    headers=headers
  File "/usr/local/lib/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.6/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The entire part that waits for the pod to spawn needs to be reworked. I will create a separate issue since this will be a large refactor.

I'm not sure this is still an issue -- closing for now


Add Footer design

Is your feature request related to a problem? Please describe.
Footer Design
*Describe the solution you'd like
Adding good design to footer.

Pls assign it to me under hacktoberfest.

footer design is not a component I guess.

It's okayy you can add footer designs as well,but make sure it's purely html,css and js.

Pls assign it to me under hacktoberfest.

Assigning this to you. 🎊🎊🎊

Thanks for assigning . I will do it in HTML,CSS, JS only.

Any updates ?

Sure. All the best !

Pls consider my PR for the issue #15


Clicking on a input type"reset" will erase all textboxes with placeholders

I don't know if it's the intended behavior but if you add an <input type"reset" /> in your page and click on it every textboxes will be reset to empty and all placeholders values will be erased.
If I test the behavior of a placeholder on a browser that supports placeholders, the values are reset but placeholder values remains still there.
Is there any workarounds ?

Hi guys, It also happends calling method reset()

Though this behavior is not desired, it is based on the current implementation of the plugin. The plugin uses invisible input text fields to accomplish the placeholder holder effect. Clicking on a reset button will clear up the invisible input text fields that this plugin relies on. To fix this, it means rewriting this entire plugin. So either don't use a reset on the form or use my other plugin https://github.com/amerikan/placeholder-polyfill which solves the same problem, however, in a different manner.

I have the same problem,when call : $("#***Form").resetForm();
My solution  is :
$('input,  textarea').removeClass("placeholder"); // remove placehodel class
$('input,  textarea').placeholder();


deps: Resolve conflicting python updates

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message: deps: Resolve python requirement updates
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Close #15691 Close #15694 Close #15697 Close #15689
[Optional Deprecated:]
[Optional API Considerations:]

gitdb requirement has some inconsistency preventing upgrade
upstream ticket here:
https://github.com/gitpython-developers/gitdb/issues/69

/retest

gitdb requirement has some inconsistency preventing upgrade of smmap

this is now resolved upstream

merging other resolution PRs ...
/wait

@moderation @mattklein123 ci is passing - ill clear the related dependa prs once this  has landed and merge all the other prs


python312Packages.pvo: 2.1.1 -> 2.2.0

Diff: https://github.com/frenck/python-pvoutput/compare/refs/tags/v2.1.1...v2.2.0
Changelog: https://github.com/frenck/python-pvoutput/releases/tag/v2.2.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363958

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.pvoutput
python311Packages.pvo
python311Packages.pvo.dist
python312Packages.pvo
python312Packages.pvo.dist


ERROR: LoadError: (2): File not found

Hey I am trying to run the following the save.efetch function in Julia v1.4.0. On Windows 10.
When I attempt to run this code:
BioMedQuery.PubMed.save_efetch!(conn, efetch_doc, true, true)
I get the following error:

Saving 15 articles to database
┌ Warning: getindex(df::DataFrame, col_ind::ColumnIndex) is deprecated, use df[!, col_ind] instead.
│   caller = select_columns(::MySQL.Connection, ::String) at mysql_db_utils.jl:62
└ @ BioMedQuery.DBUtils C:\Users\antho.julia\packages\BioMedQuery\K4kwC\src\DBUtils\mysql_db_utils.jl:62
ERROR: LoadError: (2): File 'C:UsersanthoDocumentsMachine_LearningWork2020-04-17_PubMed_basic.csv' not found (Errcode: 2)
Stacktrace:
[1] execute!(::MySQL.Connection, ::String) at C:\Users\antho.julia\packages\MySQL\R2gKS\src\MySQL.jl:84
[2] db_insert!(::MySQL.Connection, ::Dict{String,DataFrame}, ::String, ::String; verbose::Bool, drop_csv::Bool) at C:\Users\antho.julia\packages\BioMedQuery\K4kwC\src\PubMed\pubmed_sql_utils.jl:482
[3] save_efetch!(::MySQL.Connection, ::XMLElement, ::Bool, ::Bool) at C:\Users\antho.julia\packages\BioMedQuery\K4kwC\src\PubMed\eutils_sql_save.jl:25
[4] create_mysql_pubmed_db(::String, ::String, ::XMLElement) at C:\Users\antho\Documents\Machine_Learning\Work\collect_data.jl:132
[5] main() at C:\Users\antho\Documents\Machine_Learning\Work\collect_data.jl:604
[6] top-level scope at C:\Users\antho\Documents\Machine_Learning\Work\collect_data.jl:627
[7] include(::Module, ::String) at .\Base.jl:377
[8] exec_options(::Base.JLOptions) at .\client.jl:288
[9] _start() at .\client.jl:484
in expression starting at C:\Users\antho\Documents\Machine_Learning\Work\collect_data.jl:627

This code seems to work on MacOS however I have not been able to get this running on Windows.

Just FYI, this package is unmaintained/deprecated.

Is there another package that performs similarly?

I'm not sure, sorry.