WIP: Update mesh command layout per CLI review

This PR updates the mesh command layout per
https://docs.google.com/document/d/16SWW14zrwFKc9OzH6biMQD1u9INllzMa56jde9vgQkM/edit?ts=5d30fc6c#heading=h.z0zx9zymre83

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
df3f29b65b559afea8fb83cfa2654c6e79921a6c
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

from linter prow job:
/home/prow/go/src/istio.io/operator/cmd/mesh/profile.go missing license
/home/prow/go/src/istio.io/operator/cmd/mesh/profile.go missing Copyright
/home/prow/go/src/istio.io/operator/cmd/mesh/manifest.go missing license
/home/prow/go/src/istio.io/operator/cmd/mesh/manifest.go missing Copyright

@ostromart: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-lint-master

operator-build-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-build-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-lint-master

operator-build-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-build-master

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-lint-master

operator-build-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-build-master

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-mandiff-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-lint-master

operator-build-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-build-master

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-mandiff-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-mandiff-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-mandiff-master

operator-lint-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-mandiff-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-mandiff-master

operator-lint-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-lint-master

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-lint-master
576bac11bc2fb18f5ca9c0846fb92a66497de33e
link
/test operator-lint-master

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

operator-mandiff-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
d13b0e67df488fb6af16e4ab330b1fbc5a79622d
link
/test operator-test-master

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

operator-mandiff-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-mandiff-master

operator-lint-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

operator-mandiff-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-mandiff-master

operator-lint-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-lint-master

operator-test-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

operator-mandiff-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-mandiff-master

operator-lint-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-lint-master

operator-test-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-build-master

operator-lint-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-lint-master

operator-test-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-test-master

operator-mandiff-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
84dc2422d377d645406bd77ac39628f75afe1fab
link
/test operator-lint-master

operator-test-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-test-master

operator-mandiff-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-mandiff-master

operator-build-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-build-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-test-master

operator-mandiff-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-mandiff-master

operator-build-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-build-master

operator-lint-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-test-master

operator-build-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-build-master

operator-lint-master
96b1f2499b6f04dad0165e0d1805e6e37b74fcbd
link
/test operator-lint-master

operator-mandiff-master
e67d76e8445099582905c349a76bd164f1c39621
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-mandiff-master
5a1693f11c09bf04e5c6c8878d3e97e5f1cce7b3
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-mandiff-master
a3e300a220967a6c413c14db1c4a17587e4f2322
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-mandiff-master
a3e300a220967a6c413c14db1c4a17587e4f2322
link
/test operator-mandiff-master

operator-lint-master
a3e300a220967a6c413c14db1c4a17587e4f2322
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
a3e300a220967a6c413c14db1c4a17587e4f2322
link
/test operator-lint-master

operator-mandiff-master
629c43eb2ef1e95369917ec4d00a6bc83be2beb5
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-mandiff-master
629c43eb2ef1e95369917ec4d00a6bc83be2beb5
link
/test operator-mandiff-master

operator-lint-master
629c43eb2ef1e95369917ec4d00a6bc83be2beb5
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao I see a breakage in the tests here but I'm scratching my head how it could happen since I haven't modified any of the files in the following failed line:
helm template --namespace istio-system --name istio /usr/local/google/home/mostrowski/go/src/istio.io/operator/data/charts/crds -f /usr/local/google/home/mostrowski/go/src/istio.io/operator/data/charts/global.yaml -f /usr/local/google/home/mostrowski/go/src/istio.io/operator/tests/profiles/helm/values-istio-default.yaml
Error: render error in "istio-crds/templates/crds.yaml.orig": template: istio-crds/templates/crds.yaml.orig:72:14: executing "istio-crds/templates/crds.yaml.orig" at <.Values.certmanager....>: can't evaluate field enabled in type interface {}

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
629c43eb2ef1e95369917ec4d00a6bc83be2beb5
link
/test operator-lint-master

operator-mandiff-master
747d39a28ea3f18454e980444864db462bd59174
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-mandiff-master
22352358d66d3489432993c1e96d943bb95c3f7b
link
/test operator-mandiff-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test-all

/test all


Sporadic cosmetic bug with freezeColumns - partially hidden first non-frozen column

Hello,
I'd like to report a minor cosmetic bug with freezeColumns. I saw #171 and #91 but this looks different.
To reproduce:

Visit the Freeze Columns story
With the grid in its non-frozen state (ie, starting state when you visit/refresh the page), change the width of the browser window so that the header word "Title" is barely fully visible (see image below)
Focus on the "First name" of the first row, use your right arrow key to move right until you get to the "Title" column
Use your left arrow key to move back to the frozen "First name" column.

Following these steps, you will notice that even though the first column is in focus, the grid hasn't adjusted the non-frozen columns to line up evenly with the frozen column (meaning, the "Last name" column is partially hidden). Moving right once more to the "Last name" column with the right arrow key solves the problem.
You will note that if you follow the above steps but instead move right to the "More info" column (step 3), there is no issue.
I am using:
Chrome: Version 99.0.4844.83 (Official Build) (arm64)
MacOS 12.3 (M1)
Starting Point:

How it looks after following the steps above

In action

Thank you for the report, will fix.

Can you please try and see if you can reproduce this on the 4.0.0 branch? I put in some fixes for calculation of cell locations.

I have not yet been able to reproduce the issue, are you able to reproduce on firefox?

Okay I managed to reproduce the issue on firefox, I believe this is already fixed in 4.0.0. Please re-open if you are able to repro on the 4.0.0 branch.

Great, thanks. I was able to reproduce in firefox and safari.
I'll let you know if it shows up after you release 4.0.0. Many thanks for the prompt response and consideration.

I've just published 4.0.0-alpha1 on npm if you wish to test

Thank you. I tried running storybook locally on the 4.0.0 branch but ran into some errors (I'm guessing related to my own setup).
I'll look to try out the new alpha in my own code when I have a chance and report back.

Would you mind telling me what errors you ran into so I can make sure there
are no configuration issues I need to resolve?
On Sat, Mar 26, 2022 at 11:42 AM Mike Reczek @.***>
wrote:

Thank you. I tried running storybook locally on the 4.0.0 branch but ran
into some errors (I'm guessing related to my own setup).
I'll look to try out the new alpha in my own code when I have a chance and
report back.
—
Reply to this email directly, view it on GitHub
https://github.com/glideapps/glide-data-grid/issues/225#issuecomment-1079751903,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAHN232RX4YMVSIX6UABATVB5LB7ANCNFSM5RXMD24Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Sure. Haven't run storybook locally before so I wouldn't be surprised if it's something silly/dependency-related on my end.
Clone glide-data-grid and pull 4.0.0 branch.
Run npm install
Run npm run storybook
There I see a bunch of errors like this
ERROR in ./packages/cells/src/cell.stories.tsx
Module not found: Error: Can't resolve '@glideapps/glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
 @ ./packages/cells/src/cell.stories.tsx 22:0-91 59:31-50 109:25-35 124:16-28 137:16-28 151:16-28 166:16-28 180:16-28 195:16-28 209:16-28
 @ . sync ^\.(?:(?:^|\/|(?:(?:(?!(?:^|\/)\.).)*?)\/)(?!\.)(?=.)[^/]*?\.stories\.tsx)$
 @ ./generated-stories-entry.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js

ERROR in ./packages/cells/src/index.ts
Module not found: Error: Can't resolve '@glideapps/glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
 @ ./packages/cells/src/index.ts 1:0-58 15:22-34 26:22-34
 @ ./packages/cells/src/cell.stories.tsx
 @ . sync ^\.(?:(?:^|\/|(?:(?:(?!(?:^|\/)\.).)*?)\/)(?!\.)(?=.)[^/]*?\.stories\.tsx)$
 @ ./generated-stories-entry.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js

ERROR in ./packages/cells/src/cells/user-profile-cell.tsx
Module not found: Error: Can't resolve '@glideapps/glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src/cells'
 @ ./packages/cells/src/cells/user-profile-cell.tsx 2:0-78 32:20-37 62:31-44
 @ ./packages/cells/src/index.ts
 @ ./packages/cells/src/cell.stories.tsx
 @ . sync ^\.(?:(?:^|\/|(?:(?:(?!(?:^|\/)\.).)*?)\/)(?!\.)(?=.)[^/]*?\.stories\.tsx)$
 @ ./generated-stories-entry.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js

and then a bunch like this:
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  6.28 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
<EMAIL_ADDRESS>2.03 KiB {HtmlWebpackPlugin_0} [built]
ModuleNotFoundError: Module not found: Error: Can't resolve '@glideapps/glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/Compilation.js:925:10
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:401:22
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:130:21
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:224:22
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:2830:7
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:6877:13
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:214:25
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:213:14
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:44:7
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
    at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:67:43
resolve '@glideapps/glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
  Parsed request is a module
  using description file: /Users/mike/dev/opensource/glide-data-grid/packages/cells/package.json (relative path: ./src)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/mike/dev/opensource/glide-data-grid/packages/cells/src/node_modules doesn't exist or is not a directory
      /Users/mike/dev/opensource/glide-data-grid/packages/cells/node_modules doesn't exist or is not a directory
      /Users/mike/dev/opensource/glide-data-grid/packages/node_modules doesn't exist or is not a directory
      /Users/mike/dev/opensource/node_modules doesn't exist or is not a directory
      /Users/mike/dev/node_modules doesn't exist or is not a directory
      /Users/mike/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/mike/dev/opensource/glide-data-grid/node_modules
        using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path: ./node_modules/@glideapps/glide-data-grid)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/mike/dev/opensource/glide-data-grid/node_modules/@glideapps/glide-data-grid doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .jsx
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .cjs
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
<EMAIL_ADDRESS>doesn't exist
            as directory
              /Users/mike/dev/opensource/glide-data-grid/node_modules/@glideapps/glide-data-grid doesn't exist

Let me know if any additional info would help.

I see, you didn't run npm run bootstrap from the root if I had to guess.
On Sat, Mar 26, 2022 at 12:05 PM Mike Reczek @.***>
wrote:

Sure. Haven't run storybook locally before so I wouldn't be surprised if
it's something silly/dependency-related on my end.
Clone glide-data-grid and pull 4.0.0 branch.
Run npm install
Run npm run storybook
There I see a bunch of errors like this
ERROR in ./packages/cells/src/cell.stories.tsx
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
@ ./packages/cells/src/cell.stories.tsx 22:0-91 59:31-50 109:25-35 124:16-28 137:16-28 151:16-28 166:16-28 180:16-28 195:16-28 209:16-28
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
ERROR in ./packages/cells/src/index.ts
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
@ ./packages/cells/src/index.ts 1:0-58 15:22-34 26:22-34
@ ./packages/cells/src/cell.stories.tsx
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
ERROR in ./packages/cells/src/cells/user-profile-cell.tsx
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src/cells'
@ ./packages/cells/src/cells/user-profile-cell.tsx 2:0-78 32:20-37 62:31-44
@ ./packages/cells/src/index.ts
@ ./packages/cells/src/cell.stories.tsx
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
and then a bunch like this:
Child HtmlWebpackCompiler:
Asset      Size               Chunks  Chunk Names
__child-HtmlWebpackPlugin_0  6.28 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
@./core-common/dist/cjs/templates/index.ejs] 2.03 KiB {HtmlWebpackPlugin_0} [built]
ModuleNotFoundError: Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/Compilation.js:925:10
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:401:22
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:130:21
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:224:22
at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:2830:7
at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:6877:13
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:214:25
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:213:14
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :15:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:44:7
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :15:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :27:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:67:43
resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
Parsed request is a module
using description file: /Users/mike/dev/opensource/glide-data-grid/packages/cells/package.json (relative path: ./src)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
/Users/mike/dev/opensource/glide-data-grid/packages/cells/src/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/glide-data-grid/packages/cells/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/glide-data-grid/packages/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/node_modules doesn't exist or is not a directory
/Users/mike/dev/node_modules doesn't exist or is not a directory
/Users/mike/node_modules doesn't exist or is not a directory
/Users/node_modules doesn't exist or is not a directory
/node_modules doesn't exist or is not a directory
looking for modules in /Users/mike/dev/opensource/glide-data-grid/node_modules
using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path: ./node_modules)
Field 'browser' doesn't contain a valid alias configuration
using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path<EMAIL_ADDRESS>no extension
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid doesn't exist
.mjs
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.mjs doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.js doesn't exist
.jsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.jsx doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.ts doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.tsx doesn't exist
.json
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.json doesn't exist
.cjs
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.cjs doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.ts doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.tsx doesn't exist
as directory
@.***/glide-data-grid doesn't exist
Let me know if any additional info would help.
—
Reply to this email directly, view it on GitHub
https://github.com/glideapps/glide-data-grid/issues/225#issuecomment-1079755865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAHN2Y5XKX3MS2N6QC3FA3VB5NWLANCNFSM5RXMD24Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Thanks, @jassmith - that was it.
It wasn't clear that I needed to run that from CONTRIBUTING.md (I also needed to first have jq installed via brew install jq)
I was able to confirm that the bug is fixed in branch 4.0.0.
Cheers!

Fixed contributing docs in 4.0
On Sat, Mar 26, 2022 at 12:05 PM Mike Reczek @.***>
wrote:

Sure. Haven't run storybook locally before so I wouldn't be surprised if
it's something silly/dependency-related on my end.
Clone glide-data-grid and pull 4.0.0 branch.
Run npm install
Run npm run storybook
There I see a bunch of errors like this
ERROR in ./packages/cells/src/cell.stories.tsx
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
@ ./packages/cells/src/cell.stories.tsx 22:0-91 59:31-50 109:25-35 124:16-28 137:16-28 151:16-28 166:16-28 180:16-28 195:16-28 209:16-28
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
ERROR in ./packages/cells/src/index.ts
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
@ ./packages/cells/src/index.ts 1:0-58 15:22-34 26:22-34
@ ./packages/cells/src/cell.stories.tsx
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
ERROR in ./packages/cells/src/cells/user-profile-cell.tsx
Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src/cells'
@ ./packages/cells/src/cells/user-profile-cell.tsx 2:0-78 32:20-37 62:31-44
@ ./packages/cells/src/index.ts
@ ./packages/cells/src/cell.stories.tsx
@ . sync ^.(?:(?:^|/|(?:(?:(?!(?:^|/).).)?)/)(?!.)(?=.)[^/]?.stories.tsx)$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
and then a bunch like this:
Child HtmlWebpackCompiler:
Asset      Size               Chunks  Chunk Names
__child-HtmlWebpackPlugin_0  6.28 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
@./core-common/dist/cjs/templates/index.ejs] 2.03 KiB {HtmlWebpackPlugin_0} [built]
ModuleNotFoundError: Module not found: Error: Can't resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/Compilation.js:925:10
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:401:22
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:130:21
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:224:22
at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:2830:7
at /Users/mike/dev/opensource/glide-data-grid/node_modules/neo-async/async.js:6877:13
at /Users/mike/dev/opensource/glide-data-grid/node_modules/webpack/lib/NormalModuleFactory.js:214:25
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:213:14
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :15:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:44:7
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :15:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/Resolver.js:285:5
at eval (eval at create (/Users/mike/dev/opensource/glide-data-grid/node_modules/tapable/lib/HookCodeFactory.js:33:10), :27:1)
at /Users/mike/dev/opensource/glide-data-grid/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:67:43
resolve @./glide-data-grid' in '/Users/mike/dev/opensource/glide-data-grid/packages/cells/src'
Parsed request is a module
using description file: /Users/mike/dev/opensource/glide-data-grid/packages/cells/package.json (relative path: ./src)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
/Users/mike/dev/opensource/glide-data-grid/packages/cells/src/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/glide-data-grid/packages/cells/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/glide-data-grid/packages/node_modules doesn't exist or is not a directory
/Users/mike/dev/opensource/node_modules doesn't exist or is not a directory
/Users/mike/dev/node_modules doesn't exist or is not a directory
/Users/mike/node_modules doesn't exist or is not a directory
/Users/node_modules doesn't exist or is not a directory
/node_modules doesn't exist or is not a directory
looking for modules in /Users/mike/dev/opensource/glide-data-grid/node_modules
using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path: ./node_modules)
Field 'browser' doesn't contain a valid alias configuration
using description file: /Users/mike/dev/opensource/glide-data-grid/package.json (relative path<EMAIL_ADDRESS>no extension
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid doesn't exist
.mjs
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.mjs doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.js doesn't exist
.jsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.jsx doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.ts doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.tsx doesn't exist
.json
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.json doesn't exist
.cjs
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.cjs doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.ts doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
@./glide-data-grid.tsx doesn't exist
as directory
@.***/glide-data-grid doesn't exist
Let me know if any additional info would help.
—
Reply to this email directly, view it on GitHub
https://github.com/glideapps/glide-data-grid/issues/225#issuecomment-1079755865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAHN2Y5XKX3MS2N6QC3FA3VB5NWLANCNFSM5RXMD24Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Add examples, TODO

This PR mainly adds examples to the README but also adds a #TODO comment in init.py  to indicate extra work needed.  In addition, init.py was auto-formatted by PyCharm to be PEP-8 compliant, and a .gitignore file was added.
This addresses Issue #2 .

I believe this PR has been resolved.

I would like to think so, although I didn't merge the PR. Because all of the code in this repo is auto-generated, it really isn't possible to merge pull requests. I did try to address the problems identified by the PR though. The examples added to README.md I hope are covered by the sample code found in v20-python-samples


Append tag and its value to resource groups.

Modify
Append tag and its value to resource groups.
to
Append a tag and its value to resource groups.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 526dc7c5-6317-cf35-53a9-e010f4701b60
Version Independent ID: 087272dd-50ee-87a7-48d8-9b3b9008474f
Content: Quickstart: Create a blueprint in the portal - Azure Blueprints
Content Source: articles/governance/blueprints/create-blueprint-portal.md
Service: blueprints
GitHub Login: @mumian
Microsoft Alias: jgao

@himachida
Thanks for your feedback! We will investigate and update as appropriate.

@himachida - Thanks again for bringing this to our attention. We have updated the doc and it will be live once it's merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Create AWS Billing Alarm By Default

This is just a ticket for discussion, it might be beyond the scope of Zappa, but during @daheats's DjangoCon talk on Alexa skills, she mentioned creating Billing Alarms as a fail-safe against massive financial fail - as I've seen massive $$$ fail happen a few times in the wild, it might be useful to set a sane default for Zappa to create during deploy. (Especially with applications that have S3 event triggers that re-upload, as you could easily create an infinite loop.)

I'm not sure a general billing alarm makes sense for zappa to create (though I agree that you should set billing alarms on your AWS account!). For example, we deploy 3 zappa lambdas and have a host of other AWS services, no way could zappa figure out a sane value for our billing alarms. (Unless there is a lambda-specific billing metric I don't know about).
I would say a realistic thing would be to create alarms on the invocation count or sum of duration for the zappa lambda function. Since lambdas are charged by duration it seems like a good proxy for a billing alarm? I'm not sure what the config option would be though (enable_alarm, expected_invocations, expected_duration and some math during deploys)?

Ah, excellent point, I think that actually makes a good proxy. Yes, I like that more.

I'm looking into creating this. I think for now, we can probably limit this to function duration -- instead of creating another alarm for invocations. (Money wise, compute-time overshadows request pricing: https://aws.amazon.com/lambda/pricing/)
As far as creating the alarm, I'm thinking that we should set it at hourly resolution. So, expected_duation would be in milliseconds, and expected_invocations would be reqs/hr. Then, we'd calculate an hourly compute time 'allowance', and set an alarm to trigger if we exceed that.
We can set the defaults to be rather generous, so this doesn't trigger in normal/modest operations. I think the default config should only alarm you when something has obviously gone wrong -- like the s3 infinite loop example.

✨🍰✨

I'm glad that you got billing alarms out of my talk! Hope it helps save
some $$!
On Wed, Aug 30, 2017 at 12:12 PM, Kenneth Reitz<EMAIL_ADDRESS>wrote:

✨🍰✨
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Miserlou/Zappa/issues/1053#issuecomment-326090321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdo1b7GK6FXnupcgd7lKST0rDeue8cUks5sdbQbgaJpZM4O2ycb
.

--
All my best,
Heather Luna
DjangoCon US Sponsorship Chair
P.<PHONE_NUMBER>
@h34th3r329
*The DjangoCon conference is organized by DEFNA
https://www.defna.org/about/, a non-profit 501(c)(3) organization, so
your sponsorship is tax-deductible. *


Support limit orders

It crashes failing to find a buy transaction when analysing a sell transaction without this change.
Note that that further changes may be needed to support all transaction types. Maybe it should check for prefix like BUY or SELL without regarding for specific mechanism?

Thanks for contributing! :)


CI_BASE_REPO and CI_PULL_REPO mismatch

The former contains the full github repo URL, the latter only e.g., murdock-ng/murdock-html.

ah, this is a backend issue


Update message/user channel list with unread counts and colors.

The RTM stream gets all these messages, may as well put them to work.

todo: move active channels/users to top of list? lots of users == messages go missing
adds self-channel back, because it's a valid scratchpad

.. or is it better to move the channel list to be a table with cells instead of doing regex backflips on the name/counter?


pub upgrade error

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

pub upgrade

What is the expected output? What do you see instead?
What version of the product are you using?
Dart 1.8.5
On what operating system?
Linux Mint 17
What browser (if applicable)?
n.a.
Please provide any additional information below.
Trace log in attachment.
pubspec.yaml:
name: 'TableTest'
version: 0.0.1
description: >
  A starter template for a polymer.dart web app.
#author: <your name><EMAIL_ADDRESS>#homepage: https://www.example.com
environment:
  sdk: '>=1.0.0 <2.0.0'
dependencies:
  browser: any
  polymer: any
transformers:

polymer:
    entry_points: web/index.html

Attachment:
log.txt (23.84 KB)

This issue has been moved to dart-lang/pub#3.


fix(gateway): Deno WebSocket

Use Deno's ws via eval
The old method imports fixGateway from url in bot package to overwrite gateway which doesnt work (at least from my testing)

Thanks for the PR but we do not use eval in the libs code.


always evaluates tasks right away, ignoring andThen chains

Problem definition
Code using always in an andThen chain will execute before the previous value in the andThen chain is called.
An example taken from the minimal test case found here -
port run : Task x ()
port run = writeFileNotOK file "testomatic"
  `andThen` (always (readFileAndLog file))

The problem is that always will evaluate readFileAndLog file before writeFileNotOK file "testomatic" is run, meaning that the file will not exist and readFileAndLog file will die.
always is passed readFileAndLog(file), rather than a function object which hasn't been called yet through use of bind.
(\_ -> (readFileAndLog file)) on the other hand produces a function containing the readFileAndLog call, so the function isn't called until after the first Task is stepped through.
The fix in current Elm
Use lambda functions ignoring the argument instead of always. For example,
port run : Task x ()
port run = writeFileNotOK file "testomatic"
  `andThen` (\_ -> (readFileAndLog file))

instead of
port run : Task x ()
port run = writeFileNotOK file "testomatic"
  `andThen` (always (readFileAndLog file))

### In brief
Using always will evaluate a task. If it's wrapped in Native with Task.asyncFunction then it returns an obj without having executed any of it
Possible fixes
I'm not sure if this should even be fixed. The behaviour of always kind of makes sense. It could be fixed by making always evaluate when it used rather, than when it's defined. Or it could be a modification to andThen that wraps the following function in a function call, so that andThen always (readFileAndLog file) becomes andThen(.., function() { always(readFileAndLog(file)) })
The andThen modification makes most sense to me and should be fairly simple to implement. It will sadly introduce another nesting of functions, but for correct behaviour I think it's worth it.

Elm has strict evaluation, so always must behave the way it does.
My interpretation here is that you are misusing Native, not following the implicit contract that is expected to hold when you wrap some native code in a Task. For example, in Native.FS.readFileAndLog, you shouldn't simply issue a fs.readFile-call. Instead, you should wrap that in a Task.asyncFunction (on the JavaScript) side.

In other words, your native code in the present form wouldn't pass the review that is required before it would be whitelisted for publishing to http://package.elm-lang.org/.
If you "follow the rules" (which are not really written down anywhere) for wrapping impure stuff in Tasks, then the native code might get whitelisted, and the resulting could would not suffer from the issue you observe.
(Or I am totally off with everything I've just written in this and the previous comment.)

My impression is in line with @jvoigtlaender's - if that code doesn't work, then readFileAndLog must have a side effect (which it idiomatically shouldn't), and all bets are off. :smile:

Concretely, why does readFileAndLog not look as follows?
  const readFileAndLog = function (path) {
      return Task.asyncFunction(function (callback) {
        fs.readFile(path, function(err, data){
          if(err){
            throw err;
          }else{
            console.log("data: ", data);
          }
        });
        return callback(Task.succeed(Utils.Tuple0));
      });
    };

Ah, yes, you're right. The lack of the wrapping with asyncFunction is the problem.
In that case, I feel like the fix I proposed to the author shouldn't work, either. always should behave like (\_ -> a), and having the two separate behaviours for seemingly identical definitions is confusing, while they compile down to two different behaviours.

I'm not clear on that last paragraph. Do you mean always a should behave like (_ -> a)? Not in Elm. Test with a = Debug.crash "Bang".

Also, I hadn't previously noticed that "you" (who I addressed the comments to) are not the author of that native code. :smile:

Yeah, although of course Debug.crash has a side effect by design. :smile:
There are other cases where they aren't equivalent, having to do with recursive types. I don't remember offhand, but there was definitely a case I came across where something worked with an anonymous function but not with always.
Given that always is less concise than \_ -> and has some edge cases, our style guide recommends against ever using it - which I agree with.

So consider the following:
always : a -> b -> a
always a _ = a

ignoreEverything : b -> a
ignoreEverything = always (readSomeFile file)

vs
ignoreEverything : b -> a
ignoreEverything = (\_ -> readSomeFile file)

To some extent, I feel like these should be equivalent. I know they're not, because you pass readSomeFile file as a value to always, not as a function, whereas the lambda version will evaluate readSomeFile file when it's called.
Perhaps the docs should be updated to reflect? It's always a surprise when I see these kinds of problems, because always seems like it should be the same.

To me, this really boils down to "This is Elm, which chose strict evaluation."
The difference you are observing here is why lazy languages like Haskell are sometimes preferred for having better equational theories. In Haskell, always a and \_ -> a are equivalent, and actually this example is exactly what differentiates the evaluation semantics of Haskell from that of Elm.

And again, if we stick to pure code (except for possible nontermination, which might also be considered a side-effect), then there's no problem. In that world (module nontermination), always a and \_ -> a are equivalent even in Elm.
I don't really know what documentation should be added to address the problem. If everybody plays nice (no side effects through cheating with native code), the problem does not exist.

Sorry for writing comment after comment. The above "vs" does not show a real problem if you agree to not give readSomeFile file a non-Task type.

Right. Put another way, the reason they're not equivalent is that ignoreEverything has a bug in its Native implementation.
I think there are compelling reasons to deprecate always, but I actually think this is one of the arguments to keep it: it's a kind of canary in the coal mine. Any code that doesn't work the same way when using always versus \_ -> because of a Native implementation detail is necessarily broken!

I'd go ahead and close it then...nobody else in the current discussion has
permission to close it as far as I know!
On Tue, Dec 1, 2015, 10:30 AM Noah<EMAIL_ADDRESS>wrote:

Coming from a Haskell background, perhaps that's why I'm always surprised
by how always works.
I agree if you play nice, then it's not a problem. Except there does seem
to be some really rare cases where even if you don't introduce Native
code, it happens to be a problem. Basing this just off what people we work
with have said.
That being said, until there are some concrete examples of this that are
easily reproducible, then this is pretty much up in the air. Next time I
come across one I'll revisit this issue - I had thought for sure it was
this problem, but now in future I'll know I can check this.
Any code that doesn't work the same way when using always versus _ ->
because of a Native implementation detail is necessarily broken!
This is a great point. I've added it to Native docs I'm building on here
https://github.com/NoRedInk/take-home/wiki/Native-best-practices
Feel free to to close this issue as I think it's not an actual issue.
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/issues/453#issuecomment-161055945.

I'd be interested in seeing any case like this:

Except there does seem to be some really rare cases where even if you don't introduce Native code, it happens to be a problem. Basing this just off what people we work with have said.

as well.
Any case where always exp is different from \_ -> exp and where this does not come from either of:

nontermination inside exp,
Debug.crash inside exp,
native code inside exp that wouldn't get (or shouldn't have gotten) through the review process,

would require a fix.
The way the language is designed, there shouldn't be such cases other than of the above three kinds.

There was one case having to do with recursively defined types and decoders
where Evan pointed out the fix was to switch...can't remember it though.
Don't think it was broken per se though.
On Tue, Dec 1, 2015, 11:14 AM Janis Voigtländer<EMAIL_ADDRESS>wrote:

I'd be interested in seeing any case like this:
Except there does seem to be some really rare cases where even if you
don't introduce Native code, it happens to be a problem. Basing this just
off what people we work with have said.
as well.
Any case where always exp is different from _ -> exp and where this does
not come from either of:

nontermination inside exp,
Debug.crash inside exp,
native code inside exp that wouldn't get (or shouldn't have gotten)
through the review process,

would require a fix.
The way the language is designed, there shouldn't be such cases other than
of the above three kinds.
—
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/issues/453#issuecomment-161066552.

so, I've updated this in a branch https://github.com/Fresheyeball/isolating-task-bug/blob/asyncFunction-solution/Native/FS.js
Adding .asyncFunction to readFileAndLog seems to fix this problem. However I don't understand why it fixes it. Is it reasonable to say that when writing Native code in Elm, that task creation should always be done with .asyncFunction?

It fixes it because by wrapping the impure stuff in that asyncFunction call, you give the Elm runtime (specifically this module) control over when the task is run. So that is what "task creation" actually means: you create the task, but only in so far as you express what work should be done, then passing that over to the runtime. The runtime can sequence the actions, so you don't get out-of-order effects. In contrast, if you omit that wrapping, you don't really "create" a task for later execution. Instead, you do the execution right away, with all that entails about out-of-order execution of effects and the problems that can result from that.
Whether it is really always the case that you should wrap tasks in asyncFunction? I think yes, but maybe there are some cases I'm not thinking of right now where something weaker is okay. Evan might be able to tell.
(Of course, there's also the other way of bringing native stuff into the Elm world, via signals.)

Ok better heuristic:
Impure effects, even if synchronous, should be wrapped with Task.asyncFunction on the Native side.

Here's one way to think about it. When you write a native function which returns a Task, your native function executes at the time the Task is created, not at the time the task is performed. So, if you need the Task to do something each time it is performed (which is usually the case -- otherwise, it might not need to be a Task), then you'll need to arrange for that somehow. One way is to use Task.asyncFunction to provide a function to be called when the task is performed.

Vunderbratski! Thank you all for helping me come up to speed on Elm Native!


copr: supprot scanning all locks first in RangeScanner

PCP https://github.com/tikv/tikv/issues/5707

What have you changed?

ForwardScanner and BackwardScanner can ignore locks when scanning.
RangeScanner is able to collect all locks in the ranges first.

What is the type of the changes?

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

[x] Unit test
[ ] Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Does this PR affect tidb-ansible?
Refer to a related PR or issue link (optional)

[x] kvproto: https://github.com/pingcap/kvproto/pull/502
[ ] TiDB:

Benchmark result if necessary (optional)

[ ] TODO

Any examples? (optional)

Close this util the pre-work is finished


Fix local auth linking over user email

This PR address an issue where a user could delete their local auth account, then re-link by supplying an email address currently used by a user. (an email column exists both as a user column and as an auth column. For auth, it's what you would use to login. For user, it's more of a contact thing)
Note: this same fix has been added to the js-self-service-recovery branch,  so a conflict is likely when one of these is merged in.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Closing, as this was handled in the self-service-recovery PR


[sdk/azcore/cloud] Add proper managed service identities to cloud configurations

Feature Request
Cloud configurations (AzureChina,AzureGovernment,AzurePublic) ship with AD hosts included. It would be helpful if they also came with the respective managed service identities included.
See PR #22017 for a suggestion.

@chlowell, @scottaddie Is this something Identity has considered doing?

I don't understand the proposal. Applications don't need cloud-specific information to authenticate managed identities. The linked PR adds an audience for a "managedServiceIdentity" service; I don't know what that service is, but in general we don't add authentication information for services directly to azcore. Instead, each client library does that at runtime when imported, like this. So far as I can tell, we don't have a client library for a "managedServiceIdentity" service, which explains why we don't add this audience to cloud configurations today. That also means we have no use for the audience added in the PR i.e., no client would use that value.
@MaxHorstmann, can you describe the scenario you're trying to unblock with this issue/PR?

Hi @chlowell, thanks for your response. Honestly, it's been a few months and I longer recall the details here, so I'd suggest we close this for now. If anyone else feels the need to investigate further I can make an effort to refresh my memory. :) Thanks again!


Fixing IndexError on grouped_batch_sampler.py

Fixing #474 and #55.

Hey @LeviViana,
Thanks for your fix.
Could you please update the PR according to @fmassa's request?

@botcs, I guess this is it.


🐛 BUG: Can open devtools using wrangler pages

Which Cloudflare product(s) does this pertain to?
Wrangler
What version of Wrangler are you using?
3.0.1
What operating system are you using?
Mac
Describe the Bug
Context: I have wrangler installed locally in my project as a devDependency.
I run my app locally with this command: wrangler pages dev --compatibility-date=2023-01-01 ./pages
Everything works fine but I can't open the devtools when I get this menu:
 [b] open a browser, [d] open Devtools, [c] clear console, [x] to exit

b does open my browser (Brave) but d doesn't do anything. How do I get devtools to run? I tried going to brave://inspect but I don't see anything related with workerd.
What am I missing? 🤔

Closing due to a lack of response.


Add Logger

Add a logger with levels:

Debug
Info
Warning
Error
Off

This PR also log the main events on Clappr, such as events triggered and base objects creation.

:beers:


Search for an event

Is your feature request related to a problem? Please describe.
I would love to have a search function to find an event by the summary or by the description (or maybe by the location).
Describe the solution you'd like
A class method which returns a list (iterator) with every event who contains the search term.
Describe alternatives you've considered
Of course the best would be a complex search method, the returned list sorted by relevance. Maybe there is a python package for that.
Additional context
The easiest way without sorting:
class Event
[...]
  def contains(self, term: str) -> bool:
      """Return True if this event summary or description or location contains the search term."""
      return term in self.summary or term in str(self.description) or term in str(self.location)

class Timeline
[...]
  def search(self, term: str) -> Iterator[Event]:
      """Return an iterator containing all events contains the search term."""
      for item in self._iterable:
          if item.item.contains(term):
              yield item.item

Alright, tnx anyway.


Document automatic sorting of multipoint geometries

Expected behavior and actual behavior.
Hey, this surprised me, so I wondered whether the documentation could get strengthened here?
The points extracted from a MultiPoint are no longer in the same order as the original point set. Instead, the coordinates are sorted by their x value. This is significant for geopandas users, since it means that geometries are no longer aligned after applying a union to any subset of points.
Steps to reproduce the problem.
Build a random point cloud
import numpy
import geopandas
import matplotilb.pyplot as plt
from shapely import ops, geometry
numpy.random.seed(8675309)
points = numpy.random.normal(size=(100,2))

Make a multipoint out of it:
multipoint = ops.unary_union([geometry.Point(c) for c in points])

then extract the coordinates back out:
points_extracted = numpy.hstack([geom.xy for geom in multipoint.geoms]).T

We can see a few things:
assert points_extracted[0] == points[0] # Fails!

and a quick visualization suggests that the points become sorted on their x coordinate after the union:
plt.plot(points.T[0])
plt.plot(points_extracted.T[0])
plt.show()

Operating system
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

Shapely version and provenance
1.6.4 installed from conda.

@ljwolf documentation is all we can do. This is a known issue with GEOS.

OK, will try to send along a patch for documentation. Thanks for confirming!


Replacing '$ ' with '$$ ' breaks the case where the original '$' was

Replacing '$ ' with '$$ ' breaks in the case where the original '$' was escaped, by adding an additional '$'.

I think without a specific use case (like a failing test) I'd prefer to just leave this alone.


replacing pug for html

Fixes #585
Description
This PR replaces all pug code for the equivalent in HTML
Test scenarios

Open the current testing site
Open this PR testing link another browser tab
Browse whenever you want but do it in both at the same time
You should not notice any difference

you can also remove pug loader from package.json and quasar.conf.js and jest.config.js

@EJSG, thank you for the review!
I fixed the config files and resolve all pending conflicts.


Symlink .gitignore -> .dockerignore

Although this repo doesn't have a Docker recipe (I could contribute mine but I wonder if that's too opinionated to be here), I believe other docker users around have their own boilerplate repos where they point their build contexts into the site directory but end up needing to create this file manually.
It's a small change but I believe it's going to save people's time, especially because .dockerignore doesn't resolve recursively and narrowing the build context is a good practice anyway.
Do not ignore .dockerignore

Dockerignore and gitignore have different syntax. As-is this PR will put you in a world of hurt

Reference? This has been working for me.

Additionally: there are many strategies a user could use when creating a WordPress Docker image and we can’t make a generic dockerfile that works well with all of them.

Which is why this PR doesn't include a Dockerfile.

RE Dockerfile comment: check updated comment. The edit history is a wild ride lol.

Dockerignore and gitignore have different syntax. As-is this PR will put you in a world of hurt

Reference? This has been working for me.

https://docs.docker.com/engine/reference/builder/#dockerignore-file
https://git-scm.com/docs/gitignore

complicated bedrock gitignore
################################################################################
# If you update me, you need to update .dockerignore with
# `make site/.dockerignore`. This happens automatically on `make`
################################################################################

# Node Package Manager
node_modules

/.composer
/.npm

# Query Monitor
/web/app/db.php

#phinx generated template
/phinx.yml

# Temporarily ignored because of old URL structure
/web/img/*
/web/images/*

/debug.log

# WordPress #
!/web/app/uploads/.gitkeep

/web/.htaccess
/web/app/upgrade
/web/app/uploads/*
/web/wp

# WP-CLI
/*.sql
/wp-cli.yml

# Dotenv
/.env
/.env.*
!/.env.example
/env.sh

# Composer
/vendor

## Composer-based Plugins
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ
/web/app/plugins/ZZZ

## Composer-based mu-plugins
/web/app/mu-plugins/ZZZ

accompanying dockerignore
.git/
################################################################################
# If you update me, you need to update .dockerignore with
# `make site/.dockerignore`. This happens automatically on `make`
################################################################################

# Node Package Manager
**/node_modules

.composer
.npm

# Query Monitor
web/app/db.php

#phinx generated template
phinx.yml

# Temporarily ignored because of old URL structure
web/img/*
web/images/*

debug.log

# WordPress #
!web/app/uploads/.gitkeep

web/.htaccess
web/app/upgrade
web/app/uploads/*
web/wp

# WP-CLI
*.sql
wp-cli.yml

# Dotenv
.env
.env.*
!.env.example
env.sh

# Composer
vendor

## Composer-based Plugins
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ
web/app/plugins/ZZZ

## Composer-based mu-plugins
web/app/mu-plugins/ZZZ

Also consider how dockerignore impacts different strategies for creating the docker image

people could be installing composer in their dockerfile
people could be using the composer/composer docker image to install composer deps and then copy them from the filesystem into the docker image
people may want to whitelist in their dockerignore rather than blacklist (good idea)


Some uncommon Social Media Sites may be not included in the exceptions

Some uncommon Social Media Sites may be not included in the exceptions. Common ones may be also included. Comment/Reply below for list of social media sites that can be captured or displayed by Iframe or similar method

*This is a self-determined issue. Note that thedoggybrad have proper awareness about the issue. Issues similar/duplicate to this will be closed and instead will be redirected here.

List of Possible Social Media Sites
*To be constantly be edited. Possibly to be added on the filter,  but not for now.
|~wattpad.com

*This issue will be closed due to that there is no more popular social media sites not on the exceptions. Kindly open a new issue for a unpopular social media sites, so I can add them in the exceptions. Thank You.


Unsupported authorization API versions in kucero as per k8s 1.22 and approver adaptation issue

We tested kucero 1.5.1 CSRs signing in a kubernetes 1.22 cluster and noticed the CSRs were not being approved.
Kucero logs pointed to issues with the SAR. e.g:
time="2021-11-08T09:13:56Z" level=info msg=Signing
time="2021-11-08T09:13:56Z" level=error msg="SubjectAccessReview failed: the server could not find the requested resource"

We noticed that the Authorization API used in Kucero, is also V1beta1 and has been removed in Kubernetes 1.22.
The authorization.k8s.io/v1beta1 API version of LocalSubjectAccessReview, SelfSubjectAccessReview, and SubjectAccessReview is no longer served as of v1.22.
After changing the API to V1 and testing, the CSRs were issued but the state didn't got changed to approved. Checking the kubelet code because of this missing state, kubelet will not get the certificate.
We tried adding a condition in the approver part and that seems to work. Perhaps this was not needed in older versions.
The following changes lead to kucero working in k8s 1.22
diff --git a/controllers/certificatesigningrequest_controller.go b/controllers/certificatesigningrequest_controller.go
index 29144b4..c229d5d 100644
--- a/controllers/certificatesigningrequest_controller.go
+++ b/controllers/certificatesigningrequest_controller.go
@@ -21,7 +21,7 @@ import (
  "crypto/x509"
  "fmt"
- authorization "k8s.io/api/authorization/v1beta1"
+ authorization "k8s.io/api/authorization/v1"
  capi "k8s.io/api/certificates/v1"
  capiv1beta1 "k8s.io/api/certificates/v1beta1"
  corev1 "k8s.io/api/core/v1"
@@ -154,7 +154,7 @@ func (r *CertificateSigningRequestSigningReconciler) authorize(csr *capi.Certifi
      ResourceAttributes: &rattrs,
    },
  }
- sar, err := r.ClientSet.AuthorizationV1beta1().SubjectAccessReviews().Create(context.TODO(), sar, metav1.CreateOptions{})
+ sar, err := r.ClientSet.AuthorizationV1().SubjectAccessReviews().Create(context.TODO(), sar, metav1.CreateOptions{})
  if err != nil {
    return false, err
  }
@@ -165,6 +165,7 @@ func appendApprovalCondition(csr *capi.CertificateSigningRequest, message string
  csr.Status.Conditions = append(csr.Status.Conditions, capi.CertificateSigningRequestCondition{
    Type:    capi.CertificateApproved,
    Reason:  "AutoApproved by kucero",
+   Status:  corev1.ConditionTrue,
    Message: message,
  })
 }

/cc @jenting

Thank you. I'll take time to tackle it. And thanks for your approach on fix it.

Thank you. I'll take time to tackle it. And thanks for your approach on fix it.

@jenting When can we expect a fix for this issue?

I'll try my best this week or next week.

I'll try my best this week or next week.

Thank you. Do let me know if any help is needed.

We tried adding a condition in the approver part and that seems to work. Perhaps this was not needed in older versions.

I did check from k8s 1.15 to k8s 1.22, all support authorization v1 version :tada:
I'll apply your patch, thanks for your effort.


Webkit fix inheritance

Moving the conversation to the proper branch. The tests have been updated and everything should be ready to go.

Just for documentation, this branch is a replacement to https://github.com/typekit/webfontloader/pull/38, which I will now close.
This looks good to me. I think this is ready to go out, along with the Fontdeck module branch at https://github.com/typekit/webfontloader/pull/37.
Do you want to merge those two branches to master, update the changelog, and do a new version release, or should I? I'm happy to do it.

It would be great if you took care of it.
Thanks Sean!
On Tue, Nov 29, 2011 at 11:37 AM, Sean McBride
<EMAIL_ADDRESS>wrote:

Just for documentation, this branch is a replacement to https://github.com/typekit/webfontloader/pull/38, which I will now close.
This looks good to me. I think this is ready to go out, along with the Fontdeck module branch at https://github.com/typekit/webfontloader/pull/37.
Do you want to merge those two branches to master, update the changelog, and do a new version release, or should I? I'm happy to do it.

Reply to this email directly or view it on GitHub:
https://github.com/typekit/webfontloader/pull/39#issuecomment-2943768

--
Jeremie

Alright, this and the other change are merge and released as 1.0.23. Jeremie, can you get this latest version up onto the Google CDN when you get a chance? Thanks.

It should be live tomorrow.
Thanks Sean!
On Tue, Nov 29, 2011 at 12:25 PM, Sean McBride
<EMAIL_ADDRESS>wrote:

Alright, this and the other change are merge and released as 1.0.23. Jeremie, can you get this latest version up onto the Google CDN when you get a chance? Thanks.

Reply to this email directly or view it on GitHub:
https://github.com/typekit/webfontloader/pull/39#issuecomment-2946090

--
Jeremie

Sean,
Although you said to @wolthers here that the Google module fixes the Webkit early-firing of the active event error, I'm still seeing it occur.
Try the code at http://jsfiddle.net/bMxMN/1/ on a slow connection (in Safari) and notice that the second line claims the font has loaded, before the TTF file has actually downloaded completely.

I'm not sure if the Google module actually fixes the issue or not, as I didn't write or test that code for them. At any rate, it's only a workaround to the issue, and I think it requires specific information about their library of fonts in order to work, so it shouldn't solve the issue for non-Google web fonts.
@jeremiele would know more and might be interested in getting to the bottom of it if you were indeed trying to load Google web fonts. As for a more general fix, it's going to require re-thinking how we're doing font loading detection, as merely watching the width of a rendered span is not enough in these webkit browsers. Perhaps something with canvas where we look at the pixel data or comparing to a tiny web font that we send data down for in the JS itself.

The code you have in jsfiddle is using 1.0.22 of the web font loader
which does not contain the fix, change the URL to
ajax.googleapis.com/ajax/libs/webfont/1/webfont.js to always get the
latest of the v1 version (or at least change the version to 1.0.23 or
1.0.24).
On Mon, Jan 30, 2012 at 10:16 AM, Sean McBride
<EMAIL_ADDRESS>wrote:

I'm not sure if the Google module actually fixes the issue or not, as I didn't write or test that code for them. At any rate, it's only a workaround to the issue, and I think it requires specific information about their library of fonts in order to work, so it shouldn't solve the issue for non-Google web fonts.
@jeremiele would know more and might be interested in getting to the bottom of it if you were indeed trying to load Google web fonts. As for a more general fix, it's going to require re-thinking how we're doing font loading detection, as merely watching the width of a rendered span is not enough in these webkit browsers. Perhaps something with canvas where we look at the pixel data or comparing to a tiny web font that we send data down for in the JS itself.

Reply to this email directly or view it on GitHub:
https://github.com/typekit/webfontloader/pull/39#issuecomment-3724401

--
Jeremie


How to you install it ?

How do you install this library ? There are no steps in the README describing how to install it.
Thanks, it seems promising

Hello ! Thank you so much for your feedback, I appreciate it !
I am adding a "How to install" section to the README file
Have a nice day/night !

I added it, you can check the updated README file now.

I'm closing this since it's been inactive for a while, feel free to open an issue if there is anything else.
Thanks again for your feedback !


Adjust Android lifecycle code in line with context preservation changes

[x] Depends on https://github.com/ppy/osuTK/pull/74

Removes the "kill on pause" behaviour which was in place due to the context loss.
Ensures that the game host is not created multiple times on resuming game.
Suspends all threads on activity pause and resumes them again on activity resume.
Additionally I've had to manually pause/start all audio output on pause/resume via BASS as unfortunately pausing the audio thread itself did not appear to be sufficient (the audio would continue playing even after the app was paused/backgrounded). Not sure how this isn't an issue on iOS.

Tested on two Android devices that I own:

Samsung Galaxy J7 2016 / SM-J710F (Android 7),
OnePlus 8T / KB2003 (Android 11)

Additionally I've had to manually pause/start all audio output on pause/resume via BASS as unfortunately pausing the audio thread itself did not appear to be sufficient (the audio would continue playing even after the app was paused/backgrounded). Not sure how this isn't an issue on iOS.

iOS is quite robust in that an application can't break / interfere with the overall device state, so it will force audio to stop playing when an app goes into the background. An app needs to request background audio support (which shows the user that an app is using this) in order to play in the background.

Tested to work on my test device. Let's get this in for further user testing.


os_type does not work on HTML5

GM bug, cross-platform. os_windows returns string literal 0a0 = 0 (expected integer 0), os_macosx returns string literal 1a0 = 0 (expected integer 1)
I'd venture that the leading digit(s) before a are the constant. We can make a workaround but unless the need is pressing then we should leave this be until YYG fix it

🙈

I think I might be wrong about this! My debug string was formatted wrong

False alarm probably? Seems to work as expected for me


Restructure build scripts

Use make in an attempt to make building for new distros + kernel versions as easy as possible.

Can you include https://github.com/kinvolk/tcptracer-bpf/commit/6bb1beae79de4207c9c03bf8d876ad33710ff4bb here?

https://github.com/kinvolk/tcptracer-bpf/pull/2

Done, thanks.

lgtm


[App] GitLab

Expected Behaviour

Offer gitlab as an app using its helm chart:

https://docs.gitlab.com/charts/
https://docs.gitlab.com/charts/installation/

Context

From the docs:

Note: There are currently known limitations when using this chart, and not all features of GitLab are available.

Suggested on Twitter -> https://twitter.com/alexellisuk/status/1288518379607937024

Hi there!
Started writing on this in a fork (https://github.com/Johannestegner/arkade) (branch feature/gitlab-app which is not yet pushed).
This will be my first contribution to this repository and GitLab is quite a huge application (with many services), so I'm thinking to open up the following optional flags:
--ce (Install the Community Edition of GitLab (default: false))
--postgresql (Install PostgreSQL alongside GitLab (default: false))
--redis (Install Redis alongside GitLab (default: false))
--minio (Install MinIO alongside GitLab (default: false))

I feel that the default values of persistent storage and other things like these are quite sane and I can't imagine someone wants to install the suite without any storage at all, and if they do, they can use --set to do so.
I also consider if the optional additions should even be possible to choose in this installation (that is Prometheus, Grafana and GitLab runner).
Here is a link to all the global variables available:
https://docs.gitlab.com/charts/charts/globals.html
Does this sound like a good idea?

Correction to this:

--ce (Install the Community Edition of GitLab (default: false))
--postgresql (Install PostgreSQL alongside GitLab (default: false))
--redis (Install Redis alongside GitLab (default: false))
--minio (Install MinIO alongside GitLab (default: false))

 --ce (Install the Community Edition of GitLab (default: false))
 --postgresql (Install PostgreSQL alongside GitLab (default: true))
 --redis (Install Redis alongside GitLab (default: true))
 --minio (Install MinIO alongside GitLab (default: true))

https://github.com/alexellis/arkade/pull/252

/close
implemented in #252 Thanks


Script named setup.py

Script named setup.py conflicts with setuptools standard naming, and may confuse people and tools like pip

It has been renamed to initialize_infra.py


TST: windows compat for testing / msgpack

skipping a couple of parsing routines that cause odd test failures on windows
msgpack compat for windows (not tested before, prob not working correctly). Slight internal API change where writing the dtype.name rather than dtype.num, but back-compat is ok on this. (and forward compat is better).

cc @kawochen
turns out the windows msgpacks were incorrectly being read. thanks for the creation scripts!


Update error-code-AADSTS50020-user-account-identity-provider-does-not…

…-exist.md
Added new cause from line 27-36 and updated number of other causes.
This is added to divert the support cases with similar issue on daily basis.
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

#5275

Copy the changes into https://github.com/MicrosoftDocs/SupportArticles-docs-pr/pull/5275, and close this PR.


Fix: Fixed issue with the text alignment in the properties window

Resolved / Related Issues
Fix the bad position of the text Capacity in the properties of drives.
The correct padding is 25, not 28, as the rectangle (width 15 + margin 10).
Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)
Before/After

The width should be changed to 16 and the margin to 12

The changes are made. I applied the same change to the tooltip for consistency.


Updates to setup.md document steps 3 and 4.

Updates to images in Step 3

Thank you @cybersecfaith for the updates to the documentation !
That is very important for all RasQberry users.


custom domain requires no TXT record at apex

Should move this TXT record to ness.<domain>, rather than the apex.

:tada: This issue has been resolved in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: update deps for v2.0.3

Checklist

[ x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ x] Ensured the license file is being packaged.

Closes #36

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29, 43]
requirements: run: cachecontrol >= 0.12.11 should not contain a space between relational operator and the version, i.e. cachecontrol >=0.12.11
requirements: run: lockfile >= 0.9 should not contain a space between relational operator and the version, i.e. lockfile >=0.9
requirements: run: rich >= 12.3.0 should not contain a space between relational operator and the version, i.e. rich >=12.3.0
requirements: run: unearth >= 0.6.0 should not contain a space between relational operator and the version, i.e. unearth >=0.6.0
requirements: run: virtualenv >= 20 should not contain a space between relational operator and the version, i.e. virtualenv >=20

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29, 43]

unearth is pending merge here, for the record
https://github.com/conda-forge/staged-recipes/pull/20112#issuecomment-1220238667

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

oh also @daylinmorgan you might want to include a dependency on filecache b/c conda is weird about bracketed pip dependencies. I got that one merged the other day.

@theAeon The "filecache" extra for cachecontrol is on lockfile though, right?

I don't believe it is. Can you link me to where you're seeing that?

https://github.com/ionrock/cachecontrol/blob/6155c199438bfc3944a833f1dec6fb74134476f1/setup.py#L25

oh, wow, I misread that horribly. Guess I didn't need to package filecache for conda after all. You're good.

Is there any reason why you would need this old version? Otherwise, I would go with the bot PR #44 with the new version. With https://github.com/conda-incubator/grayskull/pull/377 the bot should also be able to make correct automated PRs for new versions again.

I think it's fine to just use the version in #44, but the recipe there still has extra dependencies.
PDM no longer requires:
- click
- chardet
- idna
- wheel

And two should have python version constraints added:
- tomli >=1.1.0  # [py<311]
- importlib-metadata  # [py<38]


Default values in destructuring can not be assigned to union types

It doesn't seem like it's possible to assign default values to destructured parameters when other than simple types are involved. For instance I'd expect all the examples from this fiddle to work.
/* @flow */

function fooOK({ x }: { x: ?string }): string {
  return "default string";
}

function foo2({ x = "string" }: { x: ?string }): string {
  return "default string";
}

function foo3({ x = undefined }: { x: ?string }): string {
  return "default string";
}

function foo4({ x = null }: { x: ?string }): string {
  return "default string";
}

Even explicitly typing the default values like (null: ?string) doesn't seem to work.

I think that's not how assigning default values to destructured variables work. When you assign the default values correctly flow won't complain:
/* @flow */

function foo({ x }: { x: ?string }): string {
  return "default string";
}

function foobar({ x }: { x: ?string } = { x: "string" }): string {
  return "default string";
}

function foobar({ x }: { x: ?string } = { x: undefined }): string {
  return "default string";
}

function foobar({ x }: { x: ?string } = { x: null }): string {
  return "default string";
}

@JanPeter It is possible to assign default values both in function parameter definitions like you have, and in destructuring definitions. Just try
function foo ({ x = 10 }) { return x }
foo({})
>> 10

in your browser. More info here
There is also a difference in behaviour in that in your defintions I can call foobar() with no arguments, whereas in my definition I have to at least provide foobar({}), and of course this should be reflected in the type checking.

Duplicate of #2093


can't get the crop to drop the proper item

trying to get a custom crop to drop prosperity shards and i can't quite figure it out no matter what i add or change it either drops essence or doesn't show up at all
my current version of code is as follow:
{
"name": "Prosperity",
"type": "mysticalagriculture:prosperity_shard",
"tier": "mysticalagriculture:1",
"ingredient": {
"item": "mysticalagriculture:prosperity_block"
},
"color": "D3E9EC",
"textures": {
"flower": "mysticalagriculture:block/flower_dust",
"essence": "mysticalagriculture:item/essence_gem"
},
"crux": "mysticalagriculture:prosperity_block"
{
"essence": "mysticalagriculture:prosperity_shard"
}

Minecraft: 1.20.1
Forge:47.1.99
Cucumber: 7.0.9
Mystical Agriculture: 7.0.11
Mystical Customization: 5.0.1
Singleplayer or Multiplayer: singleplayer

That JSON is not valid (test with this tool). Also type is supposed to be a crop type which should be one of the values outputted by the /mysticalcustomization types command. You probably want mysticalagriculture:resource.

I'm going to close this due to inactivity. If this is still an issue on the latest version you can reply here.


Chore/1237 update to version 1.0.0

Keeping our package name change (ts-data-json)

Looks good to me!


[doc] Add Introduction to SNMP

What does this PR do?

Add https://datadoghq.dev/integrations-core/tutorials/snmp/introduction/ to "Futher Reading" section
Motivation

https://datadoghq.dev/integrations-core/tutorials/snmp/introduction/ helps to setup SNMP.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@kayayarai @AlexandreYang Thank you both! I don't have permission to merge this PR, so could you merge?

@keisku Sure I can, but the repo is currently frozen for Agent Release. I will merged when it's unfrozen in about a week.

@keisku the repo was frozen for agent release, but it's not anymore. Just merged the PR.


Fix error handling

Don't emit an error event if there is no error.
That has caused me some headaches lately when working with the stellar sdk. I think that fix is rather critical.
Maybe you guys have a good idea for a regression test?

If I'm reading the spec correctly, this is actually the intended behaviour:

When a user agent is to reestablish the connection, the user agent must run the following steps. [...]
Queue a task to run the following steps:

If the readyState attribute is set to CLOSED, abort the task.

Set the readyState attribute to CONNECTING.
Fire a simple event named error at the EventSource object.

See processing model in the specification. I have not compared this behaviour to what is actually performed in various browsers at this time, however.

@andywer - is this still an issue for you? If so, could you please add tests?

Closed due to inactivity


Research Area: Event Based Batch Inclusion

The OP Stack is designed such that there is a single batcher key in the L1 SystemConfig contract. This EOA is controlled by the op-batcher, which is responsible for publishing the data to L1. A batch is only considered canonical if it is from the batcher key and to the batch inbox contract.
This design is simple but is not super flexible. Since it must be an EOA, batches cannot be submitted using a smart contract wallet. It is also not possible to arbitrarily program batch validity rules. If we modified the batch inbox to be a smart contract, a canonical batch could be decided by an event emitted by the smart contract.
Using a smart contract event to determine batch validity would allow developers to permissionlessly innovate on leader election mechanisms. It could be possible to build a simple round robin scheme to enable a more decentralized sequencer, where different sequencers can be allowed to submit the next set of batches. It would also be possible to build an attestation network that can hook into the batch validity rules where a batch is only considered canonical if enough of the attesters signed off on the batch.
In practice an event definition would need to be defined that would signal to the op-node that the transaction includes a valid batch. As long the configured batch inbox emitted this event, then the op-node would know to interpret the batch as valid and attempt to process it further. This was explored in https://github.com/ethereum-optimism/ecosystem-contributions/issues/63

This would also enable the development of a based rollups using the OP Stack


Suggestion: Sonarr - Add + Search, instead of standard Add

Currently, if a user adds a show to Sonarr through HTPC Manager, it is only "Adding" the show, which defaults in Sonarr to waiting on releases in Rss feeds.
If you add a show directly in Sonarr, you have the "Add" option, and the "Add + Search" option.
I recommend that HTPC Manager's Add feature send the "Add + Search" command instead of the standard "Add".
Or give the option of either way.
I would like to use HTPC Manager as a way for friends/family to add shows to Sonarr, without having direct access to Sonarr. With it doing the Add only, they will never get the backlog of episodes for a show, without me going into Sonarr myself to tell it to search.  Preferably, it should start grabbing the backlog for them when they add it, so they can start watching soon on Plex.

I believe its possible to do that already, I dont have access to sonarr now but i think it kicks off a https://github.com/Sonarr/Sonarr/wiki/Command#seriessearch. You can invoke that manually by selecting the show, then pick that option from the dropdown button.

I'd like to see this too. I believe Add+Search is somewhat new and having it be a selectable option makes sense

Ok

its now on by default


Drag and drop files with selenium causes classes to be removed from drop target

I'm dropping files onto an ngf-file-drop element through Selenium with the following script:
        var inputs = $inputStr;
        e = document.createEvent("HTMLEvents");
        e.initEvent('drop', true, true);
        e.dataTransfer = {
          files : []
        };
        for (var i = 0; i < inputs.length; i++) {
          e.dataTransfer.files.push(jQuery('#'+inputs[i]).get(0).files[0]);
        }
        e.dataTransfer.files.item = function (i) {
          return this[i];
        }
        var result = document.evaluate("$target", document, null, XPathResult.ORDERED_NODE_ITERATOR_TYPE, null);
        var elem = result.iterateNext();
        elem.dispatchEvent(e);

$inputStr is a php variable which is a JSON array of ids for input elements, which I've previously added files to.
$target is the XPath to the ngf-file-drop element I want to drop files onto.
When I run the test, everything goes well, except any classes on the ngf-file-drop element are removed. A bit of sleuthing found that this is because in drop.js Line 101, actualDragOverClass is undefined.
I'm not in a position to see if the latest version solves this problem, but eyeballing the code suggests it does not.

Fixed in version 7.3.0


New chipset on BMD-200

BMD-200 is no longer shipped with nrf51422, but instead with nrf51822. Changes in the Makefile (JLINK_OPTIONS) required.

Thanks for the heads-up. I graduated a couple of months ago, but trying to keep the project alive :)
Can you submit a pull request or a code example for this code change?

line 29: JLINK_OPTIONS = -device nrf51822_xxaa -if swd -speed 100
This worked for me :)


Consider adding support for Handlebars .hbs file ending

The correct internet media type is text/x-handlebars-template according to http://handlebarsjs.com/.

node-mime now sits on top of https://github.com/jshttp/mime-db.  Please submit requests for new types there.  Thanks!


Error detected in aggregate-report

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1514312&view=logs&j=3b141548-98d7-5be1-7ef8-eeb08ca02972&t=41e0d8dc-42df-5fff-2417-80cd016cccdb
We have one error reported in aggregate-report.
Could you please investigate and take action on either remove or rotate the secret?

#24126