make import & make PythonAPI stopped working after installing ros2 bridge

CARLA version: 0.9.13
Platform/OS: Ubuntu20
Problem you have experienced: I installed ROS2 bridge, which worked fine for me. Afterwards I tried importing a new map to the game via make import, and I got the following error:

CMake Error: Error: generator : Ninja
Does not match the generator used previously: Unix Makefiles
Either remove the CMakeCache.txt file and CMakeFiles directory or choose a different binary directory.
make: *** [Util/BuildTools/Linux.mk:124: LibCarla.client.release] Error 1

I got this after make PythonAPI, too. Is there something I can do?
Steps to reproduce: Install ROS2 bridge to ubuntu20 machine, run the examples (ros2 launch carla_ros_bridge carla_ros_bridge_with_example_ego_vehicle.launch.py). After, do make import.
Other information (documentation you consulted, workarounds you tried): Haven't tried much of anything yet (except deleting the ros bridge), for I didn't find anyone with the same error message.

Well, make launch isn't working anymore either. Gives the same error message

I tried installing carla from source again and during make PythonAPI I get the following output:

Using clang-10 as the CARLA compiler.
Setup.sh: Retrieving libc++.
Cloning into 'llvm-8.0-source'...
remote: Enumerating objects: 36751, done.
remote: Counting objects: 100% (36751/36751), done.
remote: Compressing objects: 100% (32058/32058), done.
remote: Total 36751 (delta 4686), reused 34943 (delta 4021), pack-reused 0
Receiving objects: 100% (36751/36751), 50.81 MiB | 5.22 MiB/s, done.
Resolving deltas: 100% (4686/4686), done.
Updating files: 100% (35358/35358), done.
Cloning into 'llvm-8.0-source/projects/libcxx'...
remote: Enumerating objects: 8052, done.
remote: Counting objects: 100% (8052/8052), done.
remote: Compressing objects: 100% (4726/4726), done.
remote: Total 8052 (delta 3946), reused 5825 (delta 3040), pack-reused 0
Receiving objects: 100% (8052/8052), 3.70 MiB | 11.84 MiB/s, done.
Resolving deltas: 100% (3946/3946), done.
Cloning into 'llvm-8.0-source/projects/libcxxabi'...
remote: Enumerating objects: 136, done.
remote: Counting objects: 100% (136/136), done.
remote: Compressing objects: 100% (129/129), done.
remote: Total 136 (delta 24), reused 28 (delta 2), pack-reused 0
Receiving objects: 100% (136/136), 743.04 KiB | 3.38 MiB/s, done.
Resolving deltas: 100% (24/24), done.
Setup.sh: Compiling libc++.
-- The C compiler identification is Clang 10.0.0
-- The CXX compiler identification is Clang 10.0.0
-- The ASM compiler identification is Clang
-- Found assembler: /usr/bin/clang-10
-- Check for working C compiler: /usr/bin/clang-10
-- Check for working C compiler: /usr/bin/clang-10 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++-10
-- Check for working CXX compiler: /usr/bin/clang++-10 -- broken
CMake Error at /usr/share/cmake-3.16/Modules/CMakeTestCXXCompiler.cmake:53 (message):
The C++ compiler

"/usr/bin/clang++-10"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: /home/vtt/carla12/Build/llvm-8.0-build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_c899b && [1/2] Building CXX object CMakeFiles/cmTC_c899b.dir/testCXXCompiler.cxx.o
[2/2] Linking CXX executable cmTC_c899b
FAILED: cmTC_c899b
: && /usr/bin/clang++-10     CMakeFiles/cmTC_c899b.dir/testCXXCompiler.cxx.o  -o cmTC_c899b   && :
/usr/bin/ld: cannot find -lstdc++
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Does this ring a bell to anyone?

SOLVED: After succesfully installing another version of CARLA, I went back and just... did what it told me to do. Deleted CMakeCache.txt file and CMakeFiles directory and it worked. How embarrassing.


[Bug] color parse() does not understand new spec rgb and hsl colors

Version
5.4.3
Link to Minimal Reproduction
NA
Steps to Reproduce
I have a bar chart with gradient fill of colors using the new w3c standard for hsl, a la., hsl(229deg 73% 50%) When I hover my chart the tooltip animation code tries to parse these colors for the keyframes and throws because the color.parse function does not understand this color format and is returning undefined where a color is expected by the keyframe anim code.
Current Behavior
color.parse('hsl(0deg 100% 100%)`) returns undefined
Expected Behavior
color.parse('hsl(0deg 100% 100%)`) returns some valid color value.
Environment
- OS: NA
- Browser: NA
- Framework: NA

Any additional comments?
No response

Color formatting is a complex topic and I would suggest using a third-party library to convert it to normal color format and pass it to ECharts.

To add more contexte hsl colors is require to use tailwind with css variables for the client to be able to use his own theme.
And i want some chart to be with corporate color.
And this does not work :
{
   areaStyle: {
        opacity: 0.8,
        color: new graphic.LinearGradient(0, 0, 0, 1, [
          {
            offset: 0,
            color: 'hsl(var(--color-primary-400)',
          },
          {
            offset: 1,
            color: 'hsl(var(--color-primary-700)',
          },
        ]),
      },
}


Build tooling needed

Similar to https://github.com/open-telemetry/opentelemetry-collector/tree/main/cmd/builder, we need a way to generate and then build a binary of the project.
Currently, if this repo is used as a library, it means that after loading the module a use needs to go to the package and run go generate to build the project. Ideally there would be tooling for this.
This becomes more important when we add custom probes.

Here's how Odigos generates the code from the library right now: https://github.com/odigos-io/odigos/blob/12171a085ec7ac4e80d6221de95b1374343a585f/odiglet/Makefile#L9-L14
If users are building a custom agent that imports our default Probes as well as their own custom Probes (https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/1105) this will need to run a similar command across multiple repos. Using go mod vendor might also be an approach we could recommend.
This tooling could take a similar config format to the collector builder that Tyler shared.
On the SIG call we also talked about this tool handling offset generation (will be needed for users to write custom Probes) and possibly generating Go code for a custom Probe to expose things like the Manifest and getting structfield IDs. In the latter, I think the tooling should be separate from the API types and just import them.
All in all this is going to be a pretty key toolkit for custom Probes and library users


Initial implementation of tool to generate integration tests.

Manually tested that tests can be generated with:
python tensorflow/lite/micro/integration_tests/generate_per_layer_tests.py --input_tflite_file tensorflow/lite/micro/models/person_detect.tflite --output_dir tensorflow/lite/micro/integration_tests/person_detect/conv

And run with:
make -f tensorflow/lite/micro/tools/make/Makefile test_integration_tests_person_detect_conv_test
bazel test tensorflow/lite/micro/integration_tests/person_detect/conv:integration_test

This tool is in very early stages of prototyping. Follow-up PRs will add tests and improve the tool.
Some bugs:
* http://b/205046520
* http://b/205042963
* http://b/204109200
BUG=see description.

I'm going to merge as is. This PR is a port into open source of an internal experimental tool that Nat started.
We'll make improvements incrementally. One of the bugs linked from the PR description tracks that work.


Extract random literals used in the codebase to a class as constants

E.g., see this comment. https://github.com/spring-projects-experimental/spring-pulsar/pull/88/files#r963711252

This is not really needed at this point - closing.


How to get range and initial value at the same time?

Hello, I'm using 2 calendars to have a date range.
If users set a date in the first calendar, then the days are highlighted in the second calendar, starting from the date set in the first calendar.
Is it possible to set the date of the first calendar as initial date in the second calendar?
https://jsbin.com/temosuboqe/edit?html,css,js,output

how you solved it?


Support Arrow 12.0.0

[ ] Add API to use IndexOptions
[ ] Add API to use MatchStringOptions (Vector functions to use substrings)

Includes contributing to Arrow

[x] Faster creation of SubFrames using FilterNode
[x] Use new Table#join
Remove sorting after join. Arrow may output deterministic order of rows.
[ ] Support RankOptions in Vector#rank
[ ] Support changed order of Group result (https://github.com/apache/arrow/pull/34551)

Result is unchanged. Remove unnecessary reordering.

Used new Table#join in #238 .

Update Vector#rank in #239 .

Update Vector#index in #240 .


blowfish-tools new site error

Hello, I created the project with blowfish-tools new command and there was an error. How do I solve this problem?
The following is the log information generated by the CLI:
PPM2-MacBook-Air Desktop % blowfish-tools new blowfish_web
✔ Hugo is available
✔ Git is available
✔ Folder ok...
✔ Hugo site created
✔ Git initialized
✔ Blowfish installed
⠋ Configuring BlowfishError: ENOENT: no such file or directory, lstat 'blowfish_web/themes/blowfish/config/_default'
at lstatSync (node:fs:1640:25)
at getStatsSync (node:internal/fs/cp/cp-sync:120:19)
at checkPathsSync (node:internal/fs/cp/cp-sync:72:33)
at cpSyncFn (node:internal/fs/cp/cp-sync:58:42)
at Object.cpSync (node:fs:3077:3)
at utils.directoryCopy (file:///usr/local/lib/node_modules/blowfish-tools/src/utils.js:101:8)
at flow.configureNew (file:///usr/local/lib/node_modules/blowfish-tools/src/flow.js:116:17)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
errno: -2,
code: 'ENOENT',
syscall: 'lstat',
path: 'blowfish_web/themes/blowfish/config/_default'
}

Hello @xiaopindev I just tried on my mac and it seems to work.
Are you running the command with enough permissions? What OS are you using?

Hello, @nunocoracao . I found out it's my network instability. It can be created normally when the network is normal.


AKS - unable to connect cluster with Kubectl after AKS Upgrade : clusterRole.rbac.authorization.k8s.io "admin" not found

Rancher versions:
rancher/server or rancher/rancher: v2.0.0-rc3 (docker tag preview)
rancher/agent or rancher/rancher-agent : v2.0.0-rc3
Infrastructure Stack versions:
kubernetes (Azure AKS): 1.8.1 => 1.9.6
Docker version: (docker version,docker info preferred)
Client:
 Version:       17.12.1-ce
 API version:   1.35
 Go version:    go1.9.4
 Git commit:    7390fc6
 Built: Tue Feb 27 22:17:40 2018
 OS/Arch:       linux/amd64

Server:
 Engine:
  Version:      17.12.1-ce
  API version:  1.35 (minimum version 1.12)
  Go version:   go1.9.4
  Git commit:   7390fc6
  Built:        Tue Feb 27 22:16:13 2018
  OS/Arch:      linux/amd64
  Experimental: false

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
cat /etc/os-release :
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

uname -r :
4.4.0-1055-aws

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Rancher server on AWS
Steps to Reproduce:
Create an Azure Container Service cluster
Upgrade the cluster via Azure Console https://docs.microsoft.com/fr-fr/azure/aks/upgrade-cluster
check the AKS cluster name generated via Azure Console
in my case :

resource-group : rancher2-aks
cluster name in azure : c-dtsbn

All sub commands are launched in Azure Web Console
az aks get-credentials --resource-group rancher2-aks --name c-dtsbn

kubectl get nodes
NAME                     STATUS    ROLES     AGE       VERSION
aks-rancher-14199006-0   Ready     agent     23h       v1.8.1
aks-rancher-14199006-1   Ready     agent     23h       v1.8.1
aks-rancher-14199006-2   Ready     agent     23h       v1.8.1

az aks get-upgrades --resource-group rancher2-aks --name c-dtsbn --output table
Name     ResourceGroup    MasterVersion    NodePoolVersion    Upgrades
-------  ---------------  ---------------  -----------------  --------------------------------------------------------
default  rancher2-AKS     1.8.1            1.8.1              1.8.2, 1.8.6, 1.8.7, 1.8.10, 1.8.11, 1.9.1, 1.9.2, 1.9.6

az aks upgrade --resource-group rancher2-aks --name c-dtsbn --kubernetes-version 1.9.6

The entire process take about 30 minutes
Commands launched in Azure Web Console
kubectl get nodes
NAME                     STATUS    ROLES     AGE       VERSION
aks-rancher-14199006-0   Ready     agent     21m       v1.9.6
aks-rancher-14199006-1   Ready     agent     9m        v1.9.6
aks-rancher-14199006-3   Ready     agent     32m       v1.9.6

Results:
After the upgrade, unable to connect via Rancher Kubectl
E0429 07:27:03.632153       1 generic_controller.go:204] ProjectRoleTemplateBindingController project-bgdn2/creator [cluster-prtb-sync] failed with : clusterRole.rbac.authorization.k8s.io "admin" not found
E0429 07:27:03.638287       1 generic_controller.go:204] RoleTemplateController project-owner [cluster-roletemplate-sync] failed with : clusterRole.rbac.authorization.k8s.io "admin" not found

Error:
clusterRole.rbac.authorization.k8s.io "admin" not found

It seems that in 1.9, kubernetes made a change such that it does not create its built in roles if RBAC is off. But I was not able to reproduce this in 1.10, so the behavior seems limited to 1.9.
We observed this problem in minikube, but hadn't observed it in AKS because I don't think we upgraded the cluster to 1.9.
To work around, the easiest fix is to just create these built in roles manually. You could do so by downloading tand unzipping the attached file and running
kubectl apply -f clusterroles.yaml

I havent thoroughly tested this yet, but I believe it should work
clusterroles.zip

I apply clusterroles.yaml
The clusterRole "admin" was successfully created
kubectl apply -f clusterroles.yaml
clusterrole "admin" created
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
clusterrole "cluster-admin" configured
clusterrole "edit" created
clusterrole "view" created

kubectl get clusterRole
NAME                                AGE
admin                               9m
cluster-admin                       2d
cluster-owner                       2d
edit                                9m
project-bgdn2-namespaces-edit       2d
project-bgdn2-namespaces-readonly   2d
project-owner                       2d
project-owner-promoted              2d
view                                9m

But I'm still unable to connect to the cluster via kubectl embedded in Rancher.
There is no more error in Rancher Server Log.
But an error in my browser
WebSocket connection to 'wss://35.xxx.11.yy/v3/clusters/c-dtsbn?shell=true' failed: Error during WebSocket handshake: Unexpected response code: 404

I've also the clusterRole.rbac.authorization.k8s.io "admin" not foundmessage with the default AKS cluster during cluster provisioning (the only AKS 1.8.1 k8n version from the rancher ui). So its not only 1.9.

Reopened this issue. Related to this issue
https://github.com/rancher/rancher/issues/13921

Unable to reproduce.  @soumyalj if you see this issue again please preserve the environment so we can investigate the root cause.

Tested with master.

Create a AKS cluster with k8sv1.8.10 on Azure portal
Import the AKS cluster to rancher
After import, kubectl shell launched successfully from rancher
Creation of pods succeeded.
Remote kubectl also worked
Upgraded K8s on Azure portal to v1.9.9
Upgrade succeeded. After uograde, kubectl shell launched successfully from rancher
Remote kubectl also worked


appimageupdatetool-179-30cb1ce-x86_64.AppImage fails

I tried to use appimageupdatetool-*.AppImage from the commandline, but in a very non-standard way:

I call it via a symlink named aiu-tool.
I run it against a symlink named im pointing to the real AppImage of ImageMagick.

It all goes well until about 69%. Then it falls down with a chain of messages saying:
 [....]
-1 returned
-1 returned

zsync2: failed to retrieve from ImageMagick-bc5b257-gcc-x86_64.AppImage, status -1
100.00% done (19.40 of 19.40 MiB)...
Update failed!

I'm aware that my AppImage should really carry a proper version information (which it doesn't do this yet) -- but I also like to "kick the tires" in order to test stuff.
The ImageMagick AppImage so far works as expected, even though the Travis build at the end said "Your build exited with 1." and I had to "force" the upload to the GitHub releases page.
However, I submit this issue because you may gain interesting insights into your tool when it has to deal with a possibly faulty AppImage.

I also ran aiu-tool --self-update and ./aiu-tool ./aiu-tool, which both worked, despite of using symlinks only.
The updated aiu-tool symlink meanwhile points to appimageupdatetool-180-d89753f-x86_64.AppImage, but this also fails on my ImageMagick AppImage. This most likely means that something is wrong with my ImageMagick AppImage and its .zsync file.

Files:

My ImageMagick GitHub releases page
ImageMagick-xperimental.AppImage
ImageMagick-bc5b257-gcc-x86_64.AppImage.zsync

The AppImage you are trying to update from (="old") is ImageMagick-xperimental.AppImage?

@probonopd asked:

"The AppImage you are trying to update from (="old") is ImageMagick-xperimental.AppImage?"

Yes.
However, and unfortunately, by accident I locally overwrote my previous AppImage and triggered a new Travis run, so the old one is no longer there to narrow down the error. What I have now is the newest, and here appimageupdatetool (correctly) tells me that there is nothing to update, and it's the newest version. So no way to reproduce the problem (unless you downloaded the AppImage early enough...)
Will have to see if the problem re-appears for the next builds. I'll keep the issue open for now. Will close it if it is gone...

No, I didn't save the old one...

I'm aware that my AppImage should really carry a proper version information (which it doesn't do this yet) -- but I also like to "kick the tires" in order to test stuff

As mentioned a few times, AppImageUpdate doesn't care at all about any version information and alike meta data. What it does is download the descriptor file for the remote file, then check the local file for chunks which haven't been modified, and download the rest. This mechanism is based on the file contents only.
I am not a fan of issues kept open until they can be someday in the future, but I understand your reason to do so. However, I'd ask you to find a way to reproduce this behavior which is independent from such a scenario, a minimal working example (MWE). This makes tracing down alleged bugs a lot easier for the developers, and also allows for writing reproducible tests.

I assume this has been resolved. @KurtPfeifle please confirm.

Closing as it has most likely been resolved. Please reopen otherwise.


[test_matmul.py::test_op] fails to run correctly on PVC

This case can pass on SPIRV path but fail on LLVM path.

The problem here is solvable by making capability checks specific to NVIDIA:
    if torch.cuda.is_available():
        capability = torch.cuda.get_device_capability()
        if capability[0] < 7:
            pytest.skip("Only test tl.dot() on devices with sm >= 70")
        if capability[0] < 8 and (ADTYPE == "bfloat16" or BDTYPE == "bfloat16"):
            pytest.skip("Only test bfloat16 on devices with sm >= 80")
        if capability[0] < 9 and (ADTYPE == "float8e4nv" or BDTYPE == "float8e4nv"):
            pytest.skip("Only test float8e4nv on devices with sm >= 90")
        if (ADTYPE == "bfloat16" or BDTYPE == "bfloat16") and SPLIT_K != 1:
            pytest.skip("bfloat16 matmuls don't allow split_k for now")

Enabled most tests via PR #326.


Improve documentation on the kinds of joins are valid together

Version: (e.g. 2.3.3)
Module: (e.g. quill-sql)
Database: (e.g. any)
In for comprehensions, the kind of joins that actually can work together and the kinds that cannot are confusing, largely because there are many different kinds of syntax. For example, a simple query followed by a flat-join is fine:
case class Person(name: String, residesIn: String)
case class Country(id:Int, name: String)

quote {
      for {
        p <- query[Person]
        c <- query[Country].leftJoin(_.name == p.residesIn)
      } yield (p, c)
}

Also fine if there are multiple simple queries:
quote {
      for {
        p <- query[Person]
        p1 <- query[Person] if (p1.name == p.name)
        c <- query[Country].leftJoin(_.name == p1.residesIn)
      } yield (p, c)
}

... but not if you refer back multiple levels:
quote {
      for {
        p <- query[Person]
        p1 <- query[Person] if (p1.name == p.name)
        c <- query[Country].leftJoin(_.name == p.residesIn)
      } yield (p, c)
}

Which gives:
Error:(64, 16) exception during macro expansion:
java.lang.IllegalArgumentException: requirement failed: Found an `ON` table reference of a table that is not available: Set(p). The `ON` condition can only use tables defined through explicit joins.
	at scala.Predef$.require(Predef.scala:224)
	at io.getquill.context.sql.idiom.VerifySqlQuery$$anonfun$io$getquill$context$sql$idiom$VerifySqlQuery$$loop$1$1.apply(VerifySqlQuery.scala:49)
	at io.getquill.context.sql.idiom.VerifySqlQuery$$anonfun$io$getquill$context$sql$idiom$VerifySqlQuery$$loop$1$1.apply(VerifySqlQuery.scala:39)
	at scala.collection.LinearSeqOptimized$class.foldLeft(LinearSeqOptimized.scala:124)
	at scala.collection.immutable.List.foldLeft(List.scala:84)

Now you can fix this by using the flat join syntax everywhere:
quote {
      for {
        p <- query[Person]
        p1 <- query[Person].join(_.name == p.name)
        c <- query[Country].leftJoin(_.name == p.residesIn)
      } yield (p, c)
}

However, the reason you have to do this is entirely un-intuitive, you need to know the minutia of how implicit and explicit joins work together in SQL and only then can you appreciate this error message (@mxl pointed this out for more detail). Here are some thoughts I have on this:

The documentation should divide the kinds of join syntaxes available (i.e. implicit joins, explicit joins, and flat joins) and then talk about how to use them together.
The above error message should point the user to the aforementioned documentation and say something along the lines of "just use explicit joins or flat joins instead i.e. add .join in a couple of places."

@getquill/maintainers

fixed by https://github.com/getquill/quill/pull/1241


Specialize the container type for antichains

Antichains are currently unconditionally heap-allocated. For totally
ordered elements, an antichain will container zero or one elements, but not
more. This would allow us to avoid the heap allocation and instead store
the element inline.
To enable this, we add an associated type to Timestamp that defines a
container storing an antichain of the type. The container implements the
functionality to let the current Antichain type function without change.
The obvious downside of this change is that we now include a type bound
T: Timestamp on the Antichain type, because the elements are based on
T's associated type, which infects a bunch of other places.
Signed-off-by: Moritz Hoffmann<EMAIL_ADDRESS>

This PR has the deficit that it's not possible to create a Antichain<Capability<T>> anymore because it requires the generic parameter to Antichain to be Timestamp. Capability cannot implement Timestamp as it cannot offer a minimum function.
This functionality is required by Differential. I don't think there's a good work-around other than splitting the Timestamp trait in what it currently is plus a TimstampStorage that only carries the associated storage type, but it's rather ugly and I don't know that it actually works.


Release v1.1.0

Codecov Report

Merging #56 (6d0eed7) into master (0a31421) will increase coverage by 2.74%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     29.29%   32.03%   +2.74%
- Complexity       30       32       +2
============================================
  Files            14       14
  Lines           198      231      +33
  Branches         27       27
============================================
+ Hits             58       74      +16
- Misses          135      151      +16
- Partials          5        6       +1

Impacted Files
Coverage Δ

...badev/dabirva/decoration/StickyHeaderDecoration.kt
0.00% <ø> (ø)

...ava/com/matbadev/dabirva/DabirvaBindingAdapters.kt
77.77% <50.00%> (+6.34%)
:arrow_up:

...irva/src/main/java/com/matbadev/dabirva/Dabirva.kt
79.41% <75.00%> (-9.05%)
:arrow_down:

...v/dabirva/internal/DiffableDiffUtilItemCallback.kt
100.00% <100.00%> (ø)

...java/com/matbadev/dabirva/DataBindingViewHolder.kt
66.66% <0.00%> (-3.34%)
:arrow_down:

...a/com/matbadev/dabirva/internal/CommonExecutors.kt
100.00% <0.00%> (ø)

...om/matbadev/dabirva/RecyclerViewBindingAdapters.kt
100.00% <0.00%> (ø)

...om/matbadev/dabirva/util/RecyclerViewExtensions.kt
100.00% <0.00%> (ø)

.../matbadev/dabirva/decoration/ItemHeaderProvider.kt
0.00% <0.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a31421...6d0eed7. Read the comment docs.


Multi gpu training supported?

I've tried running with CUDA_AVAILABLE_DEVICES="0,1" python CausalHiFiGAN/main.py, but it doesn't run on both gpus.

Sorry, not supported.


help : The Tor Browser Bundle should not be run as root.  Exiting.

The Tor Browser Bundle should not be run as root.  Exiting.

So don't run it as root?


⚠ UdeS website (prod) has degraded performance

In 85f86e6, UdeS website (prod) (https://www.usherbrooke.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1258 ms

Resolved: UdeS website (prod) performance has improved in 800970e.


 Use `show(err)` to see complete types.

julia> setdiff(testdomain, OpenInterval(67..39))
D ∪ Point(100.0)

D = {} (empty domain) ∪ {} (empty domain)

julia> setdiff(testdomain, OpenInterval(69..39))
D ∪ Point(100.0)

D = {} (empty domain) ∪ {} (empty domain)

That's... weird. I can reproduce it locally.

I'm not sure what causes the error: there mat be some random element to working with a Set. However, the underlying problem is that setdiffdomain1 is trying to be smart (in setoperations.jl), which it shouldn't. I'm pretty sure that fixing this routine will make the error go away.
Still, I'd like to chase the original error, because different types arise in intermediate steps, whereas the input types are all the same. It's likely that hashes of domains which are equal are different, but a real clash is very unlikely. More likely this is a bug somewhere.

another case: setdiff(UnionDomain(EmptySpace(),EmptySpace()),OpenInterval(97..84))

So the culprit of the error is this function. The error indeed goes away with a different implementation of the same logic, like this one:
function setdiffdomain1(d1::UnionDomain, d2)
	if d2 ∈ components(d1)
		uniondomain(filter(x->x!=d2, components(d1))...)
	else
		UnionDomain(setdiffdomain.(components(d1), Ref(d2)))
	end
end

This might not be the best implementation if the components of the union object are a vector (because of the splatting).
Looking at this code now, I would not write these routines again (the specialization of setdiffdomain for arguments of type UnionDomain I mean). They are optimizations. They may be nice in some cases, but they make the result of setdiffdomain less predictable. Users should not be relying on such optimizations.
I say that because you're working on unions of intervals. Please just ignore whatever DomainSets does and make your own implementation, it does not matter that it's different from what happens here. It is probably easier to reason about (predictable) optimizations when working solely with intervals.
(For the record, I know your example is cooked up, but the rule in the code is that UnionDomain always returns a UnionDomain object, but uniondomain is free to simplify. The same with SetdiffDomain and setdiffdomain, etcetera. The uniondomain function would never return a union of empty sets.)

Thanks for reporting, this is fun. I went digging into the internals of dictionaries. The difference between the (empty) open intervals happens at this line in dict.jl in base. It appears normal for there to be a difference here and it is not usually a problem. However, a few lines down the test for equality succeeds, in spite of the hashes of the EmptySpace and the open interval being different, because the open interval is equal to an empty interval. Thus, the outcome is different for different open intervals, even though all the types are the same.
Conclusion: the problem is that hash of two domains may be different even when they are equal according to isequal. The difference between hashes and equality makes it harder for dictionaries to decide whether or not an element is a key in the dictionary. The implementation of dict has some heuristics to allow for this, but they only succeed with a certain probability. That probability is not very high, so that varying the open interval a little bit made you find it.
This is a good catch! I've been wondering about the consequences of not respecting equavalence of equality and hashes. Unfortunately, this problem is hard to fix. It may be doable for intervals, but it will be a lot harder for domains.
I am not 100% sure of my explanation because I do not understand the internals of dictionaries.

Here is an example of the problem with isequal and hash acting differently. I'm sure this is known.
I am creating a dictionary with a single object. I create a long vector of elements equal to that one object, but with a different hash. (The hash is different because a has a different value for each element.) I then ask the dictionary whether it has that element as a key for each of those elements. In my test it responded positively 5 times and negatively 9995 times:
julia> struct MyType
              a
              end

julia> Base.isequal(d1::MyType, d2::MyType) = true

julia> objects = [MyType(rand()) for i in 1:10000];

julia> d = Dict(MyType(2.0) => nothing)
Dict{MyType, Nothing} with 1 entry:
  MyType(2.0) => nothing

julia> sum(haskey(d, objects[i]) for i in 1:length(objects))
5

The correct answer here would be yes 10000 times.

Thanks for the investigation!
The issue is not cooked up. It happens when I test the union of intervals. The way I check the correctness is to setdiff every component from the union and check if the final result is empty.
A case that looks more natural: iv"(4,10)" \iv"(7,9]" \ iv"(9,10)" \ iv"(4,7]"

Fixed by #152, could you confirm that?

Fixed by #152, could you confirm that?

My tests are passing.


Safe app transaction for non-owner warning not clear

Overview
When attempting to create a transaction from within a Safe app, the warning does not explicitly reference being a non-owner. This was removed with the allowance of non-owner to execute confirmed transactions.
Screenshots

Goals

Show a warning about being a non-owner when creating a transaction from within a Safe app.

Steps:
Try to create a safe app tx as a non-owner
Current result:

Expected result from prod:

Release 3.17.0 PR :  https://pr3260--safereact.review-safe.gnosisdev.com/app/rin:0x1230B3d59858296A31053C1b8562Ecf89A2f888b/apps?appUrl=https%3A%2F%2Fapps.gnosis-safe.io%2Fcompound%2F

All good, muchas gracias caballero ;)


"unique symbol" is generated to multiple .d.ts files

TypeScript Version:  4.0.3
Search Terms:
unique symbol, declaration, .d.ts, invalid, TS4023
Code
a.ts
type AX = { readonly A: unique symbol };
export const A: AX = 0 as any;

b.ts
import { A } from './a';
export const A1 = A;

tsconfig.json
{
  "compilerOptions": {
    "declaration": true,
    "strict": true,
    "noImplicitAny": true,
    "rootDir": "src",
    "outDir": "lib"
  }
}

Expected behavior:
Typescript should either throw TS4023, or generate the following code for b.d.ts:
import { A } from './a';
export declare const A1: typeof A;

Actual behavior:
Typescript generates "unique symbol" to both a.d.ts and b.d.ts:
a.d.ts
declare type AX = {
    readonly A: unique symbol;
};
export declare const A: AX;
export {};

b.d.ts
export declare const A1: {
    readonly A: unique symbol;
};

Project Link:
project.zip

Hm. I suppose we should issue an error here? The local type from a isn't reachable in b, so we print the type anonymously; however it contains a unique symbol which, by rights, refers to a symbol in a different file; so we can't really serialize it. The only thing you could write out is something like export declare const A1: typeof A, like you propose, but our declaration emit generally doesn't write out typeof queries on its own (simply because it doesn't generalize - it'd only work for exactly declarations of the form var x = some.dotted.name, which is an odd syntactic carve-out to make for TS code), which is why it's more in-line with our normal behavior to report an error on the attempted usage of a private symbol, and require an annotation.

In fact, the error already exists, and is simply failing to trigger due to an unfortunate bug.


ARROW-15802 [R] bindings for lubridate::make_datetime() and lubridate::make_date()

[x] bindings for lubridate::make_datetime() and lubridate::make_date()
[ ] bindings for base::ISOdatetime() and base::ISOdate()

The are some outstanding issues, mostly having to do with the timezone argument:

default values:

for ISOdate() the default value is "GMT" which, in fact, is "UTC".
for ISOdatetime() the default value is "" (current timezone)
for lubridate::make_datetime() the default value is "UTC"

the strptime binding does not support the tz argument - pointing to ARROW-12820 - which is now solved. I have a feeling that issue doesn't actually mean we can now switch on tz support in strptime.

The are some outstanding issues, mostly having to do with the timezone argument:

default values:
for ISOdate() the default value is "GMT" which, in fact, is "UTC".
I think this is fine, we can make ours just be "UTC" it's most important to match behavior even if it means our signatures are slightly different.

for ISOdatetime() the default value is "" (current timezone)
This is similar to our other issue with needing to add a TZ in arrow if we have "". Can we leave it as is and will that automagically become fixed when that other ticket is done? Speaking of: what is the status of that other ticket?

for lubridate::make_datetime() the default value is "UTC"
This is ok, right?

the strptime binding does not support the tz argument - pointing to ARROW-12820 - which is now solved. I have a feeling that issue doesn't actually mean we can now switch on tz support in strptime.
Yes, though for this binding you can actually "just" specify the timezone after you do the strptime, no?

For 1, the solution could be to set the default value for all tz args to "UTC".
Yup!

Speaking of: what is the status of that other ticket?

Still blocked by the Windows tz database availability issue #12536.

This is similar to our other issue with needing to add a TZ in arrow if we have "". Can we leave it as is and will that automagically become fixed when that other ticket is done?

Not sure that will automagically be solved since strptime will still not accept a tz argument (and that is the barrier).

Yes, though for this binding you can actually "just" specify the timezone after you do the strptime, no?

Not sure I follow, once x is created, I don't think I can change the value of x$type$timezone (it seems to be locked).


feat: add Zora Mainnet blockscout

Thanks in advance!

Hello @moisses89 :wave:
I rebased the branch to fix the conflict :raised_hands:
Thanks in advance!


Typo "Azure Blob storage"→"Azure Blob Storage"

https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-python

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Make this util isomorpic

Would be nice if this util is isomorphic. The following works for me server side (lib/parseHTML.js)
'use strict';
var DOMParser = require('xmldom').DOMParser;

Object.defineProperty(exports, "__esModule", {
  value: true
});

function parseHTML(html) {
  var parser = new DOMParser();
  var doc = parser.parseFromString(html, 'text/html');
  return doc.documentElement;
}

exports.default = parseHTML;

An isomorphic approach is useful, when migrating/converting legacy html content to Draftjs.
This would allow me to migrate content with migration scripts on the server.

I agree with @indianscout, making this package isomorphic would increase its compatibility, and hence its value, with many React projects out there. I've tried the suggested code and it works great, maybe @sstur could let @indianscout make a PR?
Cheers,
S.

Thanks @indianscout! I'm totally open to this, but:

It should be a peer or optional dependency somehow so we don't include the parsing code in people's front-end build. I'm open to ideas about how to do that.
I already use jsdom in my tests, I'd like to use the HTML parser from that if possible because it's extremely well tested to behave like the browser's parser.

I'm open to a PR for this or even just suggestions for point 1 and I can get to it.
Thanks!

The easiest way to achieve 1) is to move the parseHtml outside of the module and leave it up to the user what kind of parser has to be used.
The only necessary thing is to handover a W3C compliant DOM node to stateFromHTML():
'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.default = stateFromHTML;

var _draftJsImportElement = require('draft-js-import-element');

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

function stateFromHTML(element) {
  return (0, _draftJsImportElement.stateFromElement)(element);
}

(Not tested yet)
This would also solve 2) because the user can choose what kind of XML parser has to be used.

Thanks @indianscout. I've done it according to your suggestion (letting the user provide her own parser implementation).
Now stateFromHTML can take a second "options" parameter which can have a "parser" property to use whatever parser you like. The parser will receive one argument (html: string) and it must return an Element object which behaves like a DOM Element, or minimally, like a synthetic-dom element.
This was a pretty easy feature to add so thanks for the suggestion!


Maintenance Woes

@eligrey what are your plans for this project?
There has been some grumbling about the lack of attention.
We have forked and published this repo but package management is a mess.
Would you be amendable to transferring this project to an organization, https://github.com/yola, and letting an engineering team manage it?
If nothing else, add a few collaborators, including:

@beck
@stefanor (fellow coworker)
@stevenvachon
@tbranyen (if willing?)

@tbranyen if ☝  happens, could you add some collaborators to:

https://www.npmjs.com/package/classlist.js

Including:

https://www.npmjs.com/~yola
https://www.npmjs.com/~beck

I would very much like to shut-down our fork and work from a single source of truth.

@beck you're ignoring me.

Updated.

I'll be the negative ninny and say that I don't expect to hear a single word from @eligrey for at least 6 months.

So long as your fork maintains the same API, I'm alright with having ya'll start pushing releases to the npm package namespace. To be fair to @eligrey, let's give him some time to respond first. He may give ya'll merge rights to this repo (he should IMO), and then I'll add you all to the NPM package and you should be able to get it back into a good spot.

Sorry everyone. I have a lot of stuff going on in my personal life and at OFTN Inc. I've been too busy to adequately maintain this repository.
I am giving @tbranyen and @beck full access to this repo and full control over the direction.
@tbranyen and @beck please don't merge @stevenvachon's pull requests that large multiple unrelated changes all at once, or at least if you do they must be very well documented. I had one look at #53 and it was very off-putting.

@eligrey no worries, I'm not particularly happy with his attitude in general around this project. As a maintainer and someone also going through personal stuff I understand. Thanks for your help, it's in good hands :-p

Do whatever you want. My code makes projects better.

@stevenvachon I'm sure it does, but your attitude does nothing of the sort.

@tbranyen and waiting 2 years for a response does?

@beck What state is your fork in right now? Is it in a place where you could open a PR? Once we get this repo in good shape, we can publish the next artifact (IMO a major bump) to NPM.

The fork is near identical. The only difference is that it has a solution for https://github.com/eligrey/classList.js/issues/48.
I've opened a Roadmap issue, a better place to talk about "what's next?" instead of this issue. Feel free to edit and disagree with it. No hard opinions there.
Thanks @eligrey for letting others pitch in.


[Test] Check all applications in Ray Serve are running

Why are these changes needed?

add test for RayService to check if all applications are running

Related issue number

Closes #2482
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

cc @MortalHappiness


Empty row in Cube Creator returns "null" value in Visualize

When displaying the Quality of Bathing Water Cube on INT the column  Upper LOD is supposed to be empty. This happens both in preview mode as in the table view
I gave it the same property as the Lower LOD column in Cube Creator which is "integer" (Link)
However, Visualize displays the Upper LOD not as an empty column but with the "null" value. This is an issue in terms of consitency and also because null could be interpreted as "zero" in German.

Hi @tboeni, I investigated the issue and it seems there are some issues with the data:

the Upper LOD dimension is not marked as a numerical dimension, and we are treating it as a "namedNodeDimension". This means that we create a mapping of value – label to get the labels, and another problem appears here: the missing values are not marked with https://cube.link/Undefined value, but rather are simply empty (null). This means that we are omitting them from such mapping and simply convert actual value to string, which results in a "null" visible in the table. I assume there is a way to mark such values with https://cube.link/Undefined in the Cube Creator, because we have such logic to handle empty values since long time,
the Lower LOD dimension also misses the https://cube.link/Undefined values, but it's marked as numerical dimension – in this case again we check is the value is equal to https://cube.link/Undefined and if it's not (and this is not the case, as it's null), we convert it to an empty string.

It seems that handling of undefined values is described in the: Cube Schema documentation, so I would advise to try to adjust the dimensions in a recommended way (change the Upper LOD data type to numerical and replace nulls with https://cube.link/Undefined) and then the values should be displayed correctly in Visualize.
Technically, we also could adjust the logic to handle nulls together with https://cube.link/Undefined, but I think it makes more sense to follow the guidelines here.
Let me know if everything is clear and it's possible to update the cube with the new empty values 👌

Hi @bprusinowski
Thanks for the answer!
After checking im my Cube Creator project I found no differences in "values" that I had given the two different rows.
And as far as my checking went I did not find an option to mark rows / values as cube:undefined. I am not quite sure but from what you are telling me the source of this display issue comes from the way the data / values is handled in LINDAS?
If so I might have to consult Zazuko on the matter
Thanks already!

Hi @tboeni, no problem! I would check with Zazuko, because from our side it seems that the values are not what we expect :(


Add graffiti limit

As pointed here: https://github.com/dappnode/DAppNodePackage-prysm-prater/pull/100, there can be an issue with non-ASCII characters. I think we should follow course set there. It is bit messy since we have three clients on three chains, but we should have consistent solution everywhere.


EventArray.getInterval() returning wrong end time

From issue https://github.com/MideTechnology/SlamStickLab/issues/333: in enDAQ Lab 2.0 and later, getInterval() is reporting the end prematurely. This is possibly related to how the Lab is using idelib, but it shouldn't be happening in any case.
From the SlamStickLab repo issue:

Load an IDE longer than 10000000 samples (or whatever the 'Pre-Plotting Samples' is configured in the app preferences), so it will plot while continuing to load.
Zoom out (e.g. right-click).
The 'end of recording' gray area starts too early, apparently at what was the right side of the initial plot.

It seems like idelib.dataset.EventArray.getInterval() is returning incorrect values, at least where it's being used in the Lab's plots.PlotCanvas._OnDraw() (or render() in the Python 3 branch).
Confirmed to occur in Lab 2.0 and later.
This is probably an idelib bug, but easily repeatable in the Lab.

addressed in #28, #25 -> @StokesMIDE should be ready to close


Some API objects seem like exceptions to the kind blacklist rule

Cursory examination seems to indicate that rbac.v1alpha1.roleRef has a kind field that is meant to refer to a different API group's kind, rather than its own. This would make it an exception to the kind blacklist rule.

Note, though, that the "kinds" present are not API object kinds, at least in Kubernetes, because of the three permitted for now, only "ServiceAccount" matches an existing object kind. Neither "User" nor "Group" are kinds of Kubernetes objects.


Shadowrun sixth world v.38

Changes / Comments
Bugfix - NPC->Grunt fixed a bug or oversight on grunt repeating skills.   They were all showing Agility on the roll template as their ability.  Upon first opening a grunt sheet all repeating skills for the grunt will be re-set to use their default associated attribute and the display attribute will also be fixed.
Bugfix - NPC->Host IC dice roll buttons weren't working.
Bugfix - PC->Rolls->Misc fixed width on conversions
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ Y ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ Y ] Is this a bug fix?
[ N ] Does this add functional enhancements (new features or extending existing features) ?
[ N ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ NA ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ NA ] If this is a new sheet, did you follow Building Character Sheets standards ?

Character Sheet Info Roll20 Internal Use only.


Multy-gem repository

I should either separate gems (core, meta, AR, Enumerable) or make gemfiles in one workspace.
As travis do not actualy use gems, the second one is a bad idea. Also, it will make it less readable
The second one is better solution. I can place some meta files (i.e. travis, rubocop, rake) in core dir, and build some hierarchy. Don't sure travis would be ok with this, but should try
Wanted help about solutions/examples

Abandoned
Reason: multi-gem does not solve it's general purpose:


Select(index: {number}) initial load problem

Hello,
When I call the 'select' function after the new update, I can't touch the other menu buttons for initial load. After scrolling the pages, I can touch the menu buttons. I am waiting for your suggestions for the solution of this problem. Otherwise I will have to go back to the old version.

You should share your code so we can see what you did and try to make the same situation again on our side.

I'm not able to reproduce this. When are you calling select? Which version of Parchment are you using?

@yakupad any updates on this?

Closing this as I'm not able to reproduce. Let me know if you're still having issues with this 🙂


⚠ ClamAV has degraded performance

In c0b2c74, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 55 ms

Resolved: ClamAV performance has improved in 692b4c0.


From when is the Data?

Can you add to the Readme from when the individual Data Points are? Can the Year, or even Day of the Personality test be added to the SquLite Database? That would be very helpful, since I can't really use the Data without knowing when the tests were performed.
Best Regards!

I searched the Repo Link you Provided, It seems that the Years can somehow be extracted From the Timestamps. Do you still maintain this project or will I need to do it myself?

If you do, can you let us know ?


[FLINK-4799] re-add 'build-target' symlink on Unix systems

This adds back the link 'build-target' which points to the final build assembly in 'flink-dist/target/...'. The link is only created on Unix systems.

CC @uce

Thank you very much for this! Just tested this on OS X and it works as expected when packaging and cleaning. +1 to merge this.

+1 to merge

Nice one, +1 to merge

Thanks for the feedback. Merging this.


Using express-mongoose with dynamic helpers

I am building a simple blog. I have some "blocks" that I want to appear on every view, which are backed by a database. I want to set these blocks inside of the dynamicHelpers method in express. Does express-mongoose support dynamic helpers? If not, is support planned/possible?

Use express middleware and res.local
app.use(function(req, res, next){
   res.local('somePromise', User.find());
   next();
});

Works great. Thanks.


Change name of resource group

testing

Ran Plan for dir: . workspace: default
Show Output
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # azurerm_resource_group.az_rg will be created
+ resource "azurerm_resource_group" "az_rg" {
      + id       = (known after apply)
      + location = "eastus"
      + name     = "test-rg"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+ az_rg_location = "eastus"
+ az_rg_name     = "test-rg"

:arrow_forward: To apply this plan, comment:

atlantis apply -d .

:put_litter_in_its_place: To delete this plan click here
:repeat: To plan this project again, comment:

atlantis plan -d .

Plan: 1 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this pull request, comment:

atlantis apply

:put_litter_in_its_place: To delete all plans and locks for the PR, comment:

atlantis unlock

atlantis apply -d .

Ran Apply for dir: . workspace: default
azurerm_resource_group.az_rg: Creating...
azurerm_resource_group.az_rg: Creation complete after 1s [id=/subscriptions/6c902ca4-7573-4984-ae9f-2229e22fdd4f/resourceGroups/test-rg]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

az_rg_location = "eastus"
az_rg_name = "test-rg"

Applied to Azure

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: . workspace: default


workspace folder picker API

fixes https://github.com/Microsoft/vscode/issues/32936
Introduces new API to show a WorkspaceFolder picker.
/**
 * Shows a selection list of [workspace folders](#workspace.workspaceFolders) to pick from.
 * Returns `undefined` if no folder is open.
 *
 * @param options Configures the behavior of the workspace folder list.
 * @param token A token that can be used to signal cancellation.
 * @return A promise that resolves to the workspace folder or `undefined`.
 */
export function showWorkspaceFolderPick(options?: WorkspaceFolderPickOptions, token?: CancellationToken): Thenable<WorkspaceFolder | undefined>;

/**
 * Options to configure the behaviour of the [workspace folder](#WorkspaceFolder) pick UI.
 */
export interface WorkspaceFolderPickOptions {

	/**
	 * An optional string to show as place holder in the input box to guide the user what to pick on.
	 */
	placeHolder?: string;

	/**
	 * Set to `true` to keep the picker open when focus moves to another part of the editor or to another window.
	 */
	ignoreFocusOut?: boolean;

	/**
	 * An optional function that is invoked whenever a [workspace folder](#WorkspaceFolder) is selected.
	 */
	onDidSelectWorkspaceFolder?(folder: WorkspaceFolder): any;
}

fyi @dbaeumer

@bpasero  What will the picker do if there is only one folder?

@dbaeumer it will still show with just one entry in there. Since folders can come and go very dynamically without window reload, I would think it would be weird to sometimes show the picker and sometimes not depending on the count of folders. It will not show however if no folders are present in the workspace (just returns undefined in that case).
I am up for discussion on that particular topic.

Also: the API doc is quite clear around this imho: a picker for WorkspaceFolder determined by workspace.workspaceFolders. Imho we should show the picker even if that array has just one entry.

Continues via https://github.com/Microsoft/vscode/pull/34637


deps: golangci-lint to 1.55.2

Summary
This pull requests upgrades golangci-lint to the latest version to prevent issues in plugin workflows.

I'm very hesitant to make this change, as it will most likely break the lintin for existing plugin. golangci-lint is known if breaking stuff often.
Is there a patch version that we can use instead?

The next release after 1.52.2 was the minor v1.53.0.

Does the pipeline run successfully with v1.53.0?

Does the pipeline run successfully with v1.53.0?

Next one that works correctly in my local machine is v1.54.0.

I'm fine with merging the change as long we fix all linter issues that arise due to it after the merge.

I'm not watching all plugin repos, feel free to ping me around so I can take a look and fix pipelines.


fix lint warnings from DrawerLayoutAndroid

fix 3 lint warnings from DrawerLayoutAndroid.android.js

Can you please make sure that UIExplorer works with your changes applied, it looks like you're removing require for the module that is still used, which should result in a redbox on an attempt to run UIExplorer on android. Thanks!

sorry for the mistake.

@facebook-github-bot shipit

@mkonicek this one sunk like the titanic...maybe an iceberg appeared that day? I'll try again.

@facebook-github-bot shipit


Add static visualization of COVIDcast map (screenshot) to surveys page

Since we have lots of users going to the Surveys page from Facebook, it would be great if we could entice them to go to a map with a visual.
Easiest: a screenshot of the map with Facebook symptom data, linked to the map.
Better:  a dynamically updated screenshot of the map each day, with the most recent data available, linked to the map.

I have a proof of concept which produces a covidcast screenshot from the command line using the recipe in #489. Example from today (2020-10-07):

Propose to further automate by generating a screenshot on the delphi server periodically (e.g. every 12 hours). It's probably good at least initially to have human eyes on the PNG before setting this as survey page or social media image.
However as a prerequisite we'll need to install docker on the delphi server and make it usable by the automation user. @korlaxxalrok

@dfarrow0 Docker should be up and running on the server and usable by automation.

Closing this issue as obsolete.


question: the source of metadata for a demo dataset

demo dataset on https://datalad.github.io/datalad-catalog/#/dataset/deabeb9b-7a37-4062-a1e0-8fcef7909609/6d7fb68264f9b9951ae141fc830712a8744e3293 is coming from https://github.com/psychoinformatics-de/studyforrest-data .
But I do not see the metadata record which contains all that metadata which I guess was extracted using metalad_studyminmeta. E.g. if I search for sample metadata value -- the grant number -- https://github.com/search?q=repo%3Apsychoinformatics-de%2Fstudyforrest-data 01GQ1411&type=code  I see no hits.

Hey @yarikoptic
I think I generated that locally. However, the goal was at some point to update the studyforrest dataset (and subdatasets) with appropriate metadata. The one accessible example I can find is here: https://github.com/psychoinformatics-de/studyforrest-data/pull/61/files, and I'm pretty sure that contains the metadata that went into the catalog demo.

awesome -- thank you @jsheunis ! would be great to see that PR finalized.  Pretty much this issue is blocked by it .
according to the https://github.blog/2013-03-18-closing-issues-across-repositories/ it might be possible to add fixes datalad/datalad-catalog#338 to that PR


refs #2696 - remove guava from deps management

This will also put back the proper transitive Guava dependency to jaxrs2 module, thank you @frantuma


KAS 2305 Remove session-number-service from backend

Frontend PR: https://github.com/kanselarij-vlaanderen/frontend-kaleidos/pull/1289
After this gets merged, service should get archived on Github. https://github.com/kanselarij-vlaanderen/session-number-service

I archived the GH repo, but left the Docker Hub repo alone for now in case we would need to pull something between now and prod deploy time.


New contrib methods: train_model, train_save, experiment_save

This PR injects three new contrib command methods:

train_model
train_save
experiment_save

In addition, the comet contrib is now in a complete state, and uses the released version of comet_ml. If you run experiment/train followed by many visualize commands, the figures will automatically go to the right experiment.
See results here:
https://www.comet.ml/dsblank/ludwig/9f9b48c099734ff4ae91d9f2a02bfbea
Comet automatically logs Ludwig items:

Chart tab and Metrics tab: accuracy and loss
Code tab: command line
Hyperparameter tab: tensorflow hyperparameters
Graph tab: textual description of model (useful for diffs)
Output tab: output from training
System metrics tab: os version, etc.
Installed packages tab: all installed Python modules
Graphics tab: all ludwig-visualized figures
HTML tab: record of ludwig command lines for this experiment
Asset tab: all results and figures

This is really cool @dsblank !
I added one little comment for one thing that I didn't get 100% regarding swapping yaml and json extensions.
Other two little considerations:

I think it would be great if there was a vay to visualize the model definition in one of the comet tabs, not sure which one, ideally hyperparameters, but there you have key-values, while in Ludwig model definitions you have nested structures that don't fit in that pattern. Maybe in notes as a yaml text? Not sure but would be cool.
now I feel like the only missing piece is keeping track of the measures at the end of the epoch. This part of the training loop https://github.com/uber/ludwig/blob/master/ludwig/models/model.py#L542-L587 computes the measures on training validation and test. They are added to progress_tracker. You could add an additional contrib function there, maybe train_end_epoch or something like this, so that you can send the contents of the progress tracker to comet to keep track of those per-epoch measures too alongside the per-batch measures that you already track through tensorflow. Let me know if this makes sense to you.

@w4nderlust Thanks! It does a lot already, and I think we can continue to tweak this as we move forward.
We have plans to visualize model graphs for a large number of types of ML frameworks. Stay tuned!
I will take a look at injecting another contrib method there.
Thanks for the feedback and ideas!


New version: StaticArrays v0.12.5

Registering package: StaticArrays
Repository: https://github.com/JuliaArrays/StaticArrays.jl
Created by: @andyferris
Version: v0.12.5
Commit: 6bbf550a9652e7f670835d562afd91d225411bc0
Reviewed by: @andyferris
Reference: https://github.com/JuliaArrays/StaticArrays.jl/commit/6bbf550a9652e7f670835d562afd91d225411bc0#commitcomment-43640945

Hold on

This now points to a version of StaticArrays without the breaking changes. I'd like @c42f to confirm that this addresses his concerns and if so, we need to merge this manually, since automatic merging is otherwise blocked.

Yes, please merge this! I've verified that the tree hash da4cf579416c81994afd6322365d00916c79b8ae is the correct one according to our upstream new release branch upstream.  Thanks @andyferris :-)


#683 use resource func instead of resource func name

Can one of the admins verify this patch?

Coverage increased (+0.2%) to 66.301% when pulling e583c3d8fcf2e4d25bdfd3d32d7e9f4b86a8863f on lizihuai:master into 2dc08370a2af7b584b9c8d87ed05f04d355fc7d9 on go-chassis:master.

and all of documentations

and all of documentations
documentations was modified


Add tvOS deployment target

minor preprocessor fix to handle tvOs

What's with the random variations between TARGET_TV_OS and TARGET_OS_TV?

My bad fixing it right now !

LGTM


Please give a demo/example to use it with js file instead of ts file

I am using js files in my project instead of ts files. Also I don't have redux. Can anyone give me a demo, pretty basic demo of how to use this with the above setup, ie without converting my component to ts file.?

Hi, I will create a basic js example.
By the way, typescript mainly adds typing to js. Therefore,  the way of using the lib in ES6 is almost the same...

For the time being I managed to use gojs on the project without this package itself. Here is the code:
`import React, { Component } from 'react';
import go from 'gojs';
const goObject = go.GraphObject.make;
class RenderMap extends Component {
renderCanvas = (nodes, connections) => {
    var canvas = goObject(go.Diagram, "modalaInternalMap", {
                initialContentAlignment: go.Spot.Center,
                "undoManager.isEnabled": true
                });

    canvas.nodeTemplate = goObject(go.Node,
                        "Auto",
                        goObject(go.Shape, "RoundedRectangle", { strokeWidth: 0},
                        new go.Binding("fill", "color")),
                        goObject(go.TextBlock, { margin: 8 },
                        new go.Binding("text", "key")));

    canvas.model = new go.GraphLinksModel(nodes,connections);
}

componentDidMount = () => {
    this.renderCanvas(this.props.nodes, this.props.connections);
}

render() {
    return(

    );
}

}
export default RenderMap;`
But I love to see how you do it. Besides, adding ES6 and js documentation or example will give this package much more attention too. So far this is the only package exist on the planet to do its job.

Your code works. However, when you need more advanced features, you struggle to sync the react or redux state and the gojs model. In react, it's better to use immutable structures. But it's not the way gojs is designed. It's exactly where react-gojs comes into play.
I will add an es6 example as soon as possible

@jithesh-bridge I have just completed a javascript/ES6 example (without redux even though the lib is more interesting in a redux environment). This example is similar to the typescript one.
Link of the example: react-gojs-example-es6.

I will do a PR to update the documentation to include a reference to the js example

Thank you <3


Open editors: sections should not be collapsable

Refs: #20440

Click in open editors view, have at least two editors side by side
Use keyboard to navigate to Left section
Arrow left colapses the section
This section should not be collapsable - notice how the mouse click has no effect

@joaomoreno not the nicest fix:
this.toDispose.push(this.tree.addListener2('item:collapsed', (event: IItemCollapseEvent) => {
	if (event.item && event.item.getElement() instanceof EditorGroup) {
		setTimeout(() => this.tree.expand(event.item.getElement())); // unwind from callback
	}
}));

I think what is missing on the tree is some API to tell that a model element cannot be expanded.


(General) Expose file name template

Add an option to override file naming with support for template keywords. For example:

_
Value

Sheet
Test

Tab
Sheet01

Name template
%sheet%-%tab%

Would export a file named: Test-Sheet01

Keywords would need to be flanked by special chars, likely %.
Possible keywords:
Sheet specific keys:

%sheet% - The sheet's name
%tab% - The tab's name
%format%- The current export format (JSON or XML)

General keys:

%date% - The current date

Variants like %date-day% or %date-time% could have more specific formatting

%user% - Username for the person running the export

File keys:

%id% - The ID for the sheet file


Enhancement: Make it possible to resume experiments if the server crashes

A requirement for this will be to annotate checkpoints after resuming in such a way that indicates that they weren't produced in a single run.
Perhaps this annotation could be accomplished by incrementing a "run id" number, and maybe an optional (or required?) field that captures whether the previous run terminated cleanly or not. If we do include that additional field, it will need to be regarded as best-effort however, as there's no such thing as a tamperproof mechanism for determining whether or not there was a clean exit between runs.

TODO:
save reward normalization stats with other stuff
change experiment tools to enable resuming from checkpoint

This will depend on #40


client-side cloak.running?

How can I tell whether a client-side cloak instance is already configured and running?

cloak.running = true;


No such file or directory

On linux I get the following error when using cargo fmt after pulling updates from a github repository:
No such file or directory (os error 2)
usage: cargo fmt [options]
...

I don't know how to debug this any further. It would be nice if rustfmt would return a better error when a file is not found (like the name of the file, and where is rustfmt getting that file name from).

To clarify - cargo fmt used to succeed, you then updated the target source files using Git and then it breaks with the above message? Was this before running cargo build? Did running cargo build, cargo update, or cargo clean fix this?

To clarify - cargo fmt used to succeed, you then updated the target source files using Git and then it breaks with the above message?

Yes.

Was this before running cargo build? Did running cargo build, cargo update, or cargo clean fix this?

I only tried cargo test, and that did run fine.
The way I fixed it was removing the crate directory, and re-cloning it back. I have pulled a couple of times since without issues, if I am able to reproduce it I will leave the directory as is and try to debug it properly.
Anyhow it might be worth checking all the places in which a file is opened and see if the file name is reported as an error in case it isn't. If the filename is currently always reported I have no idea how I got that error message in the first place.

For me that happened when cargo was in my PATH but not rustfmt, probably triggered here: https://github.com/rust-lang-nursery/rustfmt/blob/master/src/bin/cargo-fmt.rs#L203

I had this problem too. Following @johannhof's information, adding $HOME/.cargo/bin to my PATH variable and reloading my terminal, I was able to successfully run cargo fmt.


Remove the need for a "root only" workspace file for pnpm

https://github.com/embroider-build/release-plan/pull/35 introduces a workaround for this repo because pnpm is acting badly.  It would be nice to fix this before 1.0 but at the very least we should document it somewhere 🤷

I'm pretty sure this was fixed with https://github.com/embroider-build/release-plan/pull/47 👍


CFP: Block pod startup until extant egress policies are applied

Cilium Feature Proposal
Is your feature request related to a problem?
Pods that are subject to an CiliumEgressGatewayPolicy can make a few requests immediately after pod startup that are not subject to the egress policy.
This problem was previously reported in https://github.com/cilium/cilium/issues/22969 as excessive latency between pod creation and policy application. That issue was solved by optimizing the policy application time; however a small window (1-2s) between pod creation and policy application still exists.
Describe the feature you'd like
We'd like Cilium to block pod startup until all egress gateway policies for all policies that were present at the time of the pod's creation have been applied to the pod.
I've previously filed this request via a support ticket (https://support.isovalent.com/hc/en-us/requests/332; internal enhancement request 520), but I wanted to re-request in public so that I could link this issue at folks.
(Optional) Describe your proposed solution
This is analogous to synchronously waiting for the CiliumEndpoint to be created when a pod is created, which Cilium added support for back in 2018:

https://github.com/cilium/cilium/issues/4409
https://github.com/cilium/cilium/blob/3f9d44ecddb74e37641d779e3944f64abbb65cf4/daemon/cmd/endpoint.go#L501-L505

Ideally a similar code path could be added for egress gateway policies—i.e., waiting for the first regeneration of egress policies after the new endpoint is created.
Workaround
For anyone else running into this, we've been successfully using the following workaround at Materialize. We plumb the list of known egress gateway IPs into an init container, and then block until curl https://checkip.amazonaws.com reports that the traffic is going out one of those egress IPs:
while [[ " ${KNOWN_EGRESS_IPS[*]} " =~ " $(curl https://checkip.amazonaws.com) " ]]; do
    sleep 0.5
done

Silly, but it works.

I am also interested lately into the correctness of egress gateway (and thus this but probably with less needs than you as my personal cluster where I use egressgateway is super small so this is probably nearly instantaneous in my case anyway). From what I can see (non isovalent/non expert opinion) on the subject this is most likely way harder to implement than the proposed solution you are describing because the BPF maps need to be updated on all the involved nodes (all the selected egress gateways + the client node) for the egress gateway to work correctly.
So it might needs that each node involved with a specified egress gateway report somehow whenever they update the egress maps and that on the CNI call it waits for that there. Not exactly sure what would be the best way to report the status though :thinking: (ciliumd endpoint status maybe?)...

Not stale.
On Sat, Jun 10, 2023 at 10:10 PM github-actions[bot] <
@.***> wrote:

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
—
Reply to this email directly, view it on GitHub
https://github.com/cilium/cilium/issues/24791#issuecomment-1585974263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGXSIEOQJQIWOKORB7UIY3XKUSIRANCNFSM6AAAAAAWYGIF6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

Not stale.

Still relevant.


Core pipeline mechanism

Implements abstract classes of pipeline structure

JSON schema part:

schema representation (description)
schema aggregation (with AJV)
schema validation (with AJV)

Parameter mapping (parameter name conflict) with a .map method


MD4 and MD5 differences.

I noticed https://github.com/openssl/openssl/commit/3009458e2f63b84e9631dfbf8b5c7cb38b2b283c#diff-c1d3fb8d60b1ac08be5a7c9a81bea049 . MD4 and MD5 are similar. I wonder if they could share some code. (Ideally it should be removed but I think NT password hashes use it.)

Actually, I think the differences between the two files are so minor they might not be copyrightable.

It's true that they are very similar.  Their copyrightability is a different question entirely, though.

It's not worth merging the code -- it works, there are assembler versions, and both algorithms are outdated anyway.  Closing this issue.  But thanks for looking at it.


system hangs in settings_load() nrf52840 custom board

Describe the bug
When try to call settings_load() before bt_le_adv_start() system hangs in custom board.
This works fine in nordic nrf52840 dev board.
To Reproduce
Steps to reproduce the behavior:
compile and flash -> samples/bluetooth/peripheral example. Works in DK but not in custom boad
Expected behavior
bt_le_adv_start() should return Zero and start advertising
Impact
Screenshots or console output
Environment (please complete the following information):

Linux Ubuntu 7.4.0
Toolchain zephyr-sdk-0.11.1

Additional context
If i understant correctly settings_load() tries to load/write bt_id from flash. Could this be flash related problem? Do i have to do something to flash (because this is custom made pcb)

@teijokk I don't know hat a SoC you are using, what kind of flash is used as the storage or How your storage partition looks like in the DTS.
I see not enough info for help with issue you registered.

Ok, i have consulted hw designer. soc is nrf52840_qi and there are no different memory or peripheral versions in that soc
my board dts flash declaration(default that comes in zephyr)
&flash0 {
/*
* For more information, see:
* http://docs.zephyrproject.org/latest/guides/dts/index.html#flash-partitions
*/
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
	boot_partition: partition@0 {
		label = "mcuboot";
		reg = <0x000000000 0x0000C000>;
	};
	slot0_partition: partition@c000 {
		label = "image-0";
		reg = <0x0000C000 0x000067000>;
	};
	slot1_partition: partition@73000 {
		label = "image-1";
		reg = <0x00073000 0x000067000>;
	};
	scratch_partition: partition@da000 {
		label = "image-scratch";
		reg = <0x000da000 0x0001e000>;
	};

	/*
	 * The flash starting at 0x000f8000 and ending at
	 * 0x000fffff is reserved for use by the application.
	 */

    /* Storage partition will be used by FCB/NFFS/NVS if enabled. */
	storage_partition: partition@f8000 {
		label = "storage";
		reg = <0x000f8000 0x00008000>;
	};
};

};

@teijokk, have you tried erasing the complete flash before uploading your program?

I have been managed to debug the code in our custom board. bluetooth/peripheral example . Seems that problem is not settings_load() or anything flash related. Program enters err = bt_le_adv_start(BT_LE_ADV_CONN_NAME, ad, ARRAY_SIZE(ad), NULL, 0);
then in
err = set_advertise_enable(false); (hci_core.c )
but then when called
err = bt_hci_cmd_send_sync(BT_HCI_OP_LE_SET_ADV_ENABLE, buf, NULL);(hci_core.c)
if (err) {
return err;
}
program running  k_cpu_idle(); forever and not returns in  bt_le_adv_start()

can anyone give me advice what is the correct way to investigate this problem?  bluetooth/beacon example works fine, but we need connectable ad in our project and that clearly not working.

@cvinayak can you help @teijokk ?

@teijokk, I would still start with disabling settings. In the prj.conf file comment the last 7 lines by inserting # before each line.

@joakimtoe can you help?

yes, have disabled setting in prj file.
#CONFIG_BT_KEYS_OVERWRITE_OLDEST=y
#CONFIG_BT_SETTINGS=y
#CONFIG_FLASH=y
#CONFIG_FLASH_PAGE_LAYOUT=y
#CONFIG_FLASH_MAP=y
#CONFIG_NVS=y
#CONFIG_SETTINGS=y
Code works in nrf52840_pca10056 dev board but not custom board. Same symptoms that before.

@joerchan can you help?

Hey, somethings changed. After let say 30-60 seconds minicom prints -> Advertising successfully started and i can confirm in nordic app that advertise works!

After 30 seconds? Can you please enable CONFIG_ASSERT?

enable asserts
CONFIG_ASSERT=y
no changes or any assert prints. i have tested 5 times and seems to work. time out is 30s when advertise starts. btw enabled CONFIG_BT_DEBUG_LOG=y
Have to test if this affect perormace of system or is this delay only for when bt is starting.
*** Booting Zephyr OS build v2.2.0-rc1-83-g4f9b9a4500d8  ***
[00:00:00.006,744]  fs_nvs: 8 SecAdvertising successfully started
tors of 4096 bytes
[00:00:00.006,744]  fs_nvs: alloc wra: 0, ff0
[00:00:00.006,744]  fs_nvs: data wra: 0, 0
[00:00:00.008,789]  bt_hci_core: HW Platform: Nordic Semiconductor (0x0002)
[00:00:00.008,789]  bt_hci_core: HW Variant: nRF52x (0x0002)
[00:00:00.008,789]  bt_hci_core: Firmware: Standard Bluetooth controller (0
[00:00:00.009,216]  bt_hci_core: No ID address. App must call settings_loa)
[00:00:00.016,754]  bt_hci_core: Identity: f2:a0:9e:23:6a:97 (random)
[00:00:00.016,754]  bt_hci_core: HCI: version 5.1 (0x0a) revision 0x0000, 1
[00:00:00.016,754]  bt_hci_core: LMP: version 5.1 (0x0a) subver 0xffff

@teijokk Could you check and possibly switch your clock control source?
CLOCK_CONTROL_NRF_K32SRC_RC
CLOCK_CONTROL_NRF_K32SRC_XTAL
Is  the two I would like to try and check if anyone of those have trouble.
Also please enable CONFIG_BT_DEBUG_HCI_CORE and CONFIG_BT_DEBUG_HCI_DRIVER.

@teijokk Could you share schematic?
At the beginning I'd choose nrf52840 pca10056 board configuration and started my project. For board modification I put nrf52840_pca10056.overlay file in project folder. I had some issue with my custom board because of power supply. In the end i found solution with CONFIG_BOARD_ENABLE_DCDC=n. My board have 3.3V supply.
So maybe you choose ready board that is closest to you and start modifying it?

i've enabled this CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC=y
Now system boot with no delay and i tested my own code with all sensor codes etc. all seems to work. There is external oscilator in scematics.... are chip using internal rc oscilator if this above settings is on?

@teijokk  if your custom board has long track to the XTAL and your load capacitors are not tuned to correct values, XTAL will take longer time or not settle. Also, power consumption during this setup time will be higher. I am guessing your 32KHz XTAL is not settling.

@teijokk It is what I suspected. The advertiser is waiting for the LFCLK to start.
Using RC is the nrf52 internal one. using the XTAL is the external one. I would look into if the design of the external XTAL is correct and within the requirements.
Using the RC is an alternative though.

Ok i talk with hw designer about this.. thanks for your time, i'm really grateful your help!

Close as root cause has been found and is not a zephyr issue.
@teijokk For further assistence with LFCLK please open up issue on https://devzone.nordicsemi.com/ to get in touch with the right people.


chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled

Description

Removed flags from codebase ab_create_new_apps_enabled & ab_start_with_data_default_enabled
Updated the signup cypress function to skip to application on user signing up

PR fixes following issue(s)
Fixes #31279

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Tests

Enhanced Cypress test commands for more reliable element interaction.
Improved API creation and renaming tests for better stability.
Optimized data source test commands for PostgreSQL, Google Sheets, and MySQL.

Refactor

Restructured CreateNewAppsOption.tsx for improved performance and maintainability.
Updated JSEditor.ts for better handling of QUERY_CONFIRMATION_MODAL_MESSAGE access.

Chores

Removed two feature flags for cleaner feature management.

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true recreate=true

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>@tag.Datasource, @tag.Binding"

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview recreate=true

/ok-to-test<EMAIL_ADDRESS>@tag.Anvil, @tag.Datasource, @tag.Workspace"

/ok-to-test<EMAIL_ADDRESS>@tag.Anvil, @tag.Datasource, @tag.Workspace"

/ok-to-test<EMAIL_ADDRESS>@tag.Workspace"

/ok-to-test<EMAIL_ADDRESS>@tag.Workspace"

@AmanAgarwal041 Changes LGTM, asking @Parthvi12 to review cypress files

/build-deploy-preview skip-tests=true

@AmanAgarwal041 Tested the onboarding flow once along with that widget binding and query creations, looks good. Let me know if you want me to specifically test any other areas, otherwise looks good!

/ok-to-test<EMAIL_ADDRESS>@tag.Workspace"

/ok-to-test<EMAIL_ADDRESS>@tag.Workspace"


Clicks are not working with Appium 1.3.5

Hi!
Seems like clicks for IOS devices are not working with latest Appium version:
{"status":13,"value":"ERROR running Appium command: invalid json, empty body"}
Request is /element/5003/click with empty body.
The same click works if I use Java client.
Request is the same (/element/5003/click) but the body is not empty: {"id":"5003"}
The client version is <IP_ADDRESS>

Wow.  Seems like a huge bug.  I'll fix it tomorrow and publish.  Thx.
Ciao,
Astro
Sent from my phone
On Mar 4, 2015, at 02:17, lbielski<EMAIL_ADDRESS>wrote:
Hi!
Seems like clicks for IOS devices are not working with latest Appium version:
{"status":13,"value":"ERROR running Appium command: invalid json, empty body"}
Request is /element/5003/click with empty body.
The same click works if I use Java client.
Request is the same (/element/5003/click) but the body is not empty: {"id":"5003"}
The client version is <IP_ADDRESS>
—
Reply to this email directly or view it on GitHub.

@lbielski - i just did a cursory look through, appium-dotnet-driver does not implement Click.  I believe the issue you are seeing resides with selenium.  Has this worked with previous versions of the dotnet driver?

@Astro03 - one of our customers is using .Net driver and it works locally for him. Not sure about the Appium version he is running his tests against(I will ask him), but it seems like it used to work.
We also have implementation of the same test in Javascript (mocha and 'wd' client https://www.npmjs.com/package/wd) and clicks also work.
My guess would be that Appium changed json parsing in recent version/versions and selenium driver for .Net hasn't been updated. Are you using the latest version?

I am not using the most up to date version of appium.
If you can let me know the exact setup, I can delve into it more.
Ciao,
Astro
Sent from my phone
On Mar 6, 2015, at 04:47, lbielski<EMAIL_ADDRESS>wrote:
@Astro03 - one of our customers is using .Net driver and it works locally for him. Not sure about the Appium version he is running his tests against(I will ask him), but it seems like it used to work.
We also have implementation of the same test in Javascript (mocha and 'wd' client https://www.npmjs.com/package/wd) and clicks also work.
My guess would be that Appium changed json parsing in recent version/versions and selenium driver for .Net hasn't been updated. Are you using the latest version?
—
Reply to this email directly or view it on GitHub.

Hi!
I am using the latest version of the .Net Client which I downloaded via the Nuget package manager in Visual Studio 201.
Here is an except of the code I am using:
var driver = new IOSDriver(new Uri("https://app.testobject.com:443/api/appium/wd/hub"), capabilities, new TimeSpan(0, 0, 15, 0, 0));
driver.Context = "WEBVIEW";
var loginView = driver.FindElementById("login-view");
var username = loginView.FindElement(By.Id("username"));
username.SendKeys("testuser");
driver.GetScreenshot();
var password = loginView.FindElement(By.Id("password"));
password.SendKeys("Im leben");
driver.GetScreenshot();
var btn = loginView.FindElement(By.TagName("a")); //Element found
btn.Click(); //FAILS
driver.GetScreenshot();

RvO

@penguinho is this what you were talking about? have you seen this problem?

Closing due to inactivity


NoMethodError undefined method `platform'

Hi,
I am getting NoMethodError when compiling cookbooks with test-kitchen. It looks like it has issue when Chef Client version is 13.0.113, which is the current latest release.
,,,
Installing Cookbook Gems:
Compiling Cookbooks...
   ================================================================================
   Recipe Compile Error in /tmp/kitchen/cache/cookbooks/hostname/attributes/default.rb
   ================================================================================

   NoMethodError
   -------------
   undefined method `platform' for #<Chef::Node::Attribute:0x00000002a44ac8>

   Cookbook Trace:
   ---------------
     /tmp/kitchen/cache/cookbooks/hostname/attributes/default.rb:4:in `from_file'

   Relevant File Content:
   ----------------------
   /tmp/kitchen/cache/cookbooks/hostname/attributes/default.rb:

     1:  # -*- coding: utf-8 -*-
     2:
     3:  default['hostname_cookbook']['hostsfile_ip'] = '<IP_ADDRESS>'
     4>> default['hostname_cookbook']['hostsfile_ip_interface'] = 'lo0' if platform == 'freebsd'
     5:

   System Info:
   ------------
   chef_version=13.0.113
   platform=ubuntu
   platform_version=14.04
   ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
   program_name=chef-client worker: ppid=1497;start=18:33:05;
   executable=/opt/chef/bin/chef-client

,,,
I workaround the issue by adding "require_chef_omnibus: 12.19.36" in my .kitchen.yml

FYI, this should be fixed in the Master branch (version 0.4.1) which is not pushed to the Supermarket (yet).
Thanks for the report!

Please consider a release as Chef 13 is released

@3ofcoins/hostname-developers @mpasternacki @xamebax are the only people with access to Supermarket. We really should publish (several) cut releases to the Supermarket.

@mburns yes! Thanks for the ping. I will deal with this in the next days.

The newest version is now published on the Supermarket, so I guess this should solve the issue.

I'm still facing this issue
chef_version=14.2.0
platform=oracle
platform_version=6.10
ruby=ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
program_name=chef-client
executable=/opt/chef/bin/chef-client
`Recipe Compile Error in /var/chef/cache/cookbooks/ruby_build/attributes/default.rb
NoMethodError
undefined method `platform' for #Chef::Node::Attribute:0x0000000004a87920
Cookbook Trace:
/var/chef/cache/cookbooks/ruby_build/attributes/default.rb:32:in `from_file'
Relevant File Content:
/var/chef/cache/cookbooks/ruby_build/attributes/default.rb:
25:
26:  # default base path for a system-wide installed Ruby
27:  default['ruby_build']['default_ruby_base_path'] = "/usr/local/ruby"
28:
29:  # ruby-build upgrade action
30:  default['ruby_build']['upgrade'] = "none"
31:
32>> case platform
33:  when "redhat", "centos", "fedora", "amazon", "scientific"
34:    node.set['ruby_build']['install_pkgs'] = %w{ tar bash curl }
35:    node.set['ruby_build']['install_git_pkgs'] = %w{ git }
36:    node.set['ruby_build']['install_pkgs_cruby'] =
37:      %w{ gcc-c++ patch readline readline-devel zlib zlib-devel
38:          libffi-devel openssl-devel
39:          make bzip2 autoconf automake libtool bison
40:          libxml2 libxml2-devel libxslt libxslt-devel
41:          subversion autoconf }`

@anirudhtetali I think you'll need to open a new issue.

I think you'll need to open a new issue.


Cross-Account e2e Tests + Conflicted Gateway Status

What type of PR is this?

feature + tests
Which issue does this PR fix:
#567
What does this PR do / Why do we need it:

Updated Gateway Controller to appropriately set the Programmed status of Gateways as Conflicted when there is a name conflict

Previously, the status would be left as Pending

Added new cross-account e2e test suite, named sharing

Not executed as part of normal e2e-test suite due to different environment expectations and testing goals

Added new environment variable SECONDARY_ACCOUNT_TEST_ROLE_ARN, which is used by the new test suite to assume the secondary account, which currently just shares resources to the primary account

In the future, the secondary account may be expected to have its own cluster, which would enable multi-cluster e2e testing in the new suite

Added new makefile target sharing-test, which runs the new suite
Added docs explaining how to use the sharing suite

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A
Testing done on this change:

Ran 3 of 3 Specs in 118.312 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (118.31s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/sharing       119.038s

Automation added to e2e:

sharing suite
Will this PR introduce any new dependencies?:

No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this PR introduce any user-facing change?:

No
Added cross-account e2e test suite

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Special highlight on duplicated code - last time when I did refactoring for FindServiceNetwork I had hard times with accesslog policy tests, surprisingly. We should take it more serious.

New E2E tests still pass:
Ran 3 of 61 Specs in 124.753 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 58 Skipped
--- PASS: TestIntegration (124.76s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   126.001s


[BUG] Unable to use MS Teams Workflow webhook url in Channels

What is the bug?
Microsoft is deprecating the Office 365 connectors for Teams and we need to utilize the Workflows webhook URL to post messages to Teams channels. I've generated a webhook URL but am unable to use it in OpenSearch.
Refer: https://devblogs.microsoft.com/microsoft365dev/retirement-of-office-365-connectors-within-microsoft-teams/
How can one reproduce the bug?
Method 1:

Go to 'Notifications -> Channels -> Create Channel'
Set a channel name
Select Channel Type -> Microsoft Teams
Webhook URL -> https://prod-XX.westeurope.logic.azure.com:443/workflows/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Click "Send Test Message"

Error:
[status_exception] Wrong Microsoft Teams url. Should contain "webhook.office.com"
Method 2:

Select Channel Type -> Custom webhook
Method -> POST
Webhook URL -> https://prod-XX.westeurope.logic.azure.com:443/workflows/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Click "Send Test Message"

Error:
[status_exception] {"event_status_list": [{"config_id":"666cK5EB6cKDPdC7sDsE","config_type":"webhook","config_name":"temp-MS Teams Workflow Test","email_recipient_status":[],"delivery_status":{"status_code":"500","status_text":"Failed to send webhook message Failed: {\"error\":{\"code\":\"InvalidRequestContent\",\"message\":\"The request content is not valid and could not be deserialized: 'Unexpected character encountered while parsing value: T. Path '', line 0, position 0.'.\"}}"}}]}
What is your host/environment?
AWS OpenSearch 2.11

Hi,
I have the same issue, do you already have something new regarding this issue?

Unfortunately the issue here is that the suggested migration path for moving away from the "Incoming Webhook" Office 365 Connector is to use a Power Automate Workflow with the "When a Teams webhook request is received" as the trigger, however this does not support the same basic JSON schema that the original connector supported and instead will only accept Adaptive Card data instead.
It is possible to temporarily work around this issue by using the OpenSearch "Custom webhook" notification channel type instead. This will allow you to define any webhook URL you want, and then within the actual monitor action you can format the message to include the correct JSON. For example something like this:
{
    "type": "message",
    "attachments": [
        {
            "contentType": "application/vnd.microsoft.card.adaptive",
            "content": {
                "type": "AdaptiveCard",
                "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
                "version": "1.3",
                "body": [
                    {
                        "type": "TextBlock",
                        "size": "Medium",
                        "weight": "Bolder",
                        "text": "{{ctx.monitor.name}}"
                    },
                    {
                        "type": "TextBlock",
                        "text": "{{ctx.trigger.name}}"
                    }
                ]
            }
        }
    ]
}

Obviously replacing the Mustache template variables for whatever is appropriate for your situation.

It's possible to configure the Teams workflow(PowerAutomate) webhooks any way you want. You don't have to adopt the default adaptive-card schema. I've managed to get the custom webhook to trigger with the OpenSearch action message defined with a Mustache expression as:
{   "text":  "{{ ctx.monitor.name }}"  }
But I wasn't able to access the data returned by my query that is referenced in the trigger condition. The variable {{ctx.results.0.hits.hits.0._source.body.value}} would render the error message captured in the data source but doesn't seem to be available. Is that a bug or expected?

[Catch All Triage - 1, 2, 3, 4, 5]


Prompted for invite code on Fedora

Following the Hacker News article I tried installing the Fedora RPM from the website but I'm still prompted for an invite code.
Tagging @oconnor663 per request.
➜  ~ keybase --version
keybase version 1.0.18-20170208170104+dc66461

@aramisbear Could you share a screenshot of the prompt asking you for an invite code?  And run keybase log send and tell us the ID?  Thanks!

ID is cd00cdc3d3a91f9869c58a1c
Screenshot https://imgur.com/a/xcS1z

Same issue here, using MacOS El Capitan.
keybase --version
keybase version 1.0.18-20170208165022+dc66461

and
Your log ID is:

  335f61c9e9563c8277dc861c```

Same here on Windows: http://i.imgur.com/A9hZsoO.jpg

@fnordson Your build's a bit out of date, so that might be why for you.  (Did you download it today?  You should get a dialog about a pending update.)

I created an account in Keybase, and then just logged in directly, that worked.

@cjb I downloaded it minutes before I posted here. Just seen the HN post. It works now with the code you provided there.

@fnordson Oops, I tagged you incorrectly.  Thanks for the update.


commented visually selected  text is not visible  when neovim is running inside tmux

Text is visible when neovim is running outside tmux, but not inside tmux.
I have checked this in alacritty, st and native terminal.
https://user-images.githubusercontent.com/31353917/148074699-9c936dae-34b6-4f43-995f-0af8e7022ffa.mp4

This is working for me
https://gist.github.com/andersevenrud/015e61af2fd264371032763d4ed965b6

@lngsx 's solution fixed the issue.
Thanks!


Phone call accept button missing

Hey,
Today I updated my Matrix client to version 0.8.12 (G-b146) on my HTC Android 6.0.1.
Since this version, i am not able to accept incoming phone calls.
The accept button doesn't exist anymore, there is just the a hang up button.

To investigate

(thanks @chris-je for reporting this issue)

@chris-je on which screen you don't see the accept button anymore?

The Room list (home)?
in a Room?
the notification?
Somewhere else?

Thanks for this precision

i can confirm, here a Screenshot of the "Incoming Call" screen
@bmarty

Reproduced when the phone is in "Do not disturb" mode

dev build 2258, bug still there regardless of "Do not disturb" mode @bmarty

can't reproduce :(

I was send rageshake report with comment 'for issue 2417'

https://github.com/matrix-org/riot-android-rageshakes/issues/2858

Confirmed on build #2278. Not able to answer voice or video calls

It starts from build 2247

It starts from build 2247

fixed