Implementation of JSON Web Token

These commits introduce the following things in order to make JSON Web Token (JWT, see https://jwt.io/) usable in takes:

A new Signature interface, similar to the Codec interface. The main difference is that while Codecs can encrypt and decrypt data, a Signature can only encrypt (aka sign) data.
An HMAC-SHA implementation of that interface with variations of 256, 384 and 512 bitlength. This is the standard signature algorithm for JWT.
A new interface for Token and two implementations that provide a JOSE token (JWT header) and a JWT payload token.
A new Pass that accepts JWT from a Bearer header and adds a new JWT to its response (obviously, that works only with JSON responses).

@yegor256 please, pay attention to this pull request

Job gh:yegor256/takes#743 is in scope.

+15 points just awarded to @semantosoph, total is +15.

Codecov Report

Merging #743 into master will decrease coverage by 1.47%.
The diff coverage is 19.81%.

@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
- Coverage     77.55%   76.07%   -1.48%
- Complexity      900      910      +10
============================================
  Files           205      208       +3
  Lines          4245     4356     +111
  Branches        323      329       +6
============================================
+ Hits           3292     3314      +22
- Misses          823      911      +88
- Partials        130      131       +1

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/org/takes/facets/auth/Token.java
0% <0%> (ø)
0 <0> (?)

src/main/java/org/takes/facets/auth/PsToken.java
0% <0%> (ø)
0 <0> (?)

.../java/org/takes/facets/auth/signatures/SiHmac.java
75.86% <75.86%> (ø)
10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5888370...3d19d36. Read the comment docs.

@semantosoph looks cool, thanks for your contribution! I made a few minor comments above

@yegor256  There you go, I made the requested changes.
I would appreciate it, if you could add me to the contributors list this time.

@semantosoph a few more comments above. Of course, we can add you to the list, but we don't have that list now :) Feel free to add it to README, just like it's done in github.com/yegor256/cactoos

@yegor256 Changes done. I'll compile the contributors list once I've got a little spare time.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

@semantosoph when you want me to release a new version, say it here, not in Twitter :)

@rultor release, tag is 1.6

@rultor release, tag is 1.6

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 1.6

@yegor256 Done! FYI, the full log is here (took me 20min)

Job gh:yegor256/takes#743 assigned to @caarlos0, please go ahead (policy).

@caarlos0 this job was assigned to you 8 days ago.
It will be taken away from you after 10 days from start (this is our policy).

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.


WIP - Create test util method to get VCAP username and password

@rabbah please handle the merge

It appears to me, that this and #443 are basically the same thing. Is there the possibility to deduplicate? Could we just return the "credentials" object and get the values we need directly in the test?

An alternative is for one method that accepts a vararg String... Which is the map properties to add and return. I think this leads to least duplication?

Closing will deliver on #443


Use CloudTrail events for Trusted Advisor checks

CloudTrail now has Trusted Advisor checks https://aws.amazon.com/about-aws/whats-new/2016/11/trusted-advisor-enables-automated-actions-and-custom-notifications/
It looks like we could switch the Trusted Advisor rules to use CloudTrail events instead of API calls to Trusted Advisor.

This was done!


Question: how to assert on snackbars?

I was trying to make a test to verify a snackbar appears. But the snackbar seems to dissappear (long delay) before Maestro can detect it. I am basically asserting visibility on the snackbar text.
Am I doing something wrong?

If it is for a publicly available app, could you please share:

The flow that you are running
The app you are running it on

I'm travelling right now but will prep a repro for you

Closing until more context is available


Add aws-kf-ci-bot into the list

This is required as the 1st step to solve this issue: #348
Note: let me know if you want me to create separate team-list for aws-kf-ci-bot.

Once this PR is approved, does Googler need to sync org manually? https://github.com/kubeflow/internal-acls/blob/master/github-orgs/sync_org.sh?

/lgtm
/approve
Thanks for the update!
I think it's okay for now.

It will sync automatically


RadioCards: when disabled, has a regular cursor

Opted for the regular cursor instead of cursor-not-allowed. Personally, not a huge fan of that cursor style and encourages someone to think something's broken or not in an expected state.

Since the changes here are relatively small, I've set this to merge into #release/0.6.2.  Feels like the current use case that kicked this off can move forward without it and be further improved by this on release.

@DavidLarsKetch I'm going to push this forward with cursor-not-allowed which I know neither of us love, but it's consistent with our other form elements.  Happy to revisit alternative cursor's later in the context of all form elements.


⚠ Samsung has degraded performance

In 78e4dc3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2570 ms

Resolved: Samsung performance has improved in dff644b.


How did you get the results in Table 1 ?

Hi
Where can I find the code to regenerate the prediction results of your paper?

Hi, we only provided the code for our own method (acLSTM-3LR) in this repository, and the datasets are available on the CMU Motion Capture website. You probably need to implement the other four methods by yourself. They are not very complicated.

Thanks for the reply.
I mean the numbers of (acLSTM) only.
How did you calculate the motion prediction error for your method?
These numbers:


Import CSS files from all specified load paths

Currently the importer just looks in the cwd for CSS files, this change allows makes it look in all load paths. This will help users who have bower_components on their load path.

@joefiorini , there is no issues link on your github page. I'm getting
[22:10:06] gulp-ruby-sass stderr: NoMethodError:
[22:10:06] gulp-ruby-sass stderr: undefined method
 `root' for #<Compass::SpriteImporter:0x00000002e7
7000>


Unable to access currency_options on Price object

Describe the bug
Currently it does't seem to be possible to access the currency options inside the Price object.
Might be something related to how it is generated, since it is an interesting structure.
The Price currency_options object is a hash that has as key the ISO 4217 code for the currency and the value is an instance of CurrencyOption.
For example:
"currency_options": {
    "eur": {
        "custom_unit_amount": null,
        "tax_behavior": "exclusive",
        "unit_amount": 35000,
        "unit_amount_decimal": "35000"
    },
}

Currently the generated code for the currency_options is only Option<CurrencyOption>, which can't fit the actual structure.
To Reproduce

Create a Price
Add a currency option for the Price
Tries to fetch the price with the currency_options expanded
No currency option available

Expected behavior
Being able to access the currency options inside the price
Code snippets
Code for fetching price
let prices = StripePrice::list(
    &client,
    &ListPrices {
        lookup_keys: Some(vec!["lookup_key".into()]),
        expand: &["data.currency_options"],
        ..Default::default()
    },
)
.await
.unwrap();

let price = prices.data.get(0).unwrap();
let currency_options = price.currency_options.as_ref().unwrap();

println!("{:?}", currency_options);
// > CurrencyOption { custom_unit_amount: None, tax_behavior: None, tiers: None, unit_amount: None, unit_amount_decimal: None }

OpenAPI SDK spec for currency_options:
currency_options:
  additionalProperties:
    $ref: '#/components/schemas/currency_option'
  description: >-
    Prices defined in each available currency option. Each key must be a
    three-letter [ISO currency
    code](https://www.iso.org/iso-4217-currency-codes.html) and a
    [supported currency](https://stripe.com/docs/currencies).
  type: object

OS
macOS
Rust version
1.67.1
Library version
0.18.4
API version
2020-08-27
Additional context
No response

Interesting is one word for it! :) I'm currently looking at the options we have.


Db views missing in GII with mssql db

Query to find tableNames in yii\db\mssql\Schema::findTableNames filters on Logical tables
It should also return view to allow model generation using gii.
I think "AND [t].[table_type] = 'BASE TABLE'" part of the query should be removed to include views as well

This has already been fixed in master via #7834


Service fabric integration

Changed connection protocol for outbound connection firewall rule

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[bug] Component doesn't report current status/"hvac_action" in Heat Pump (one switch heat/cool) mode

Hi,
First of all, thank you for this awesome thermostat component, that is finally something HA-based, which should and actually works with Heat Pump, that has only one switch for heat/cool.
As I said everything works as expected except "hvac_action" status. It just missing( see screenshot). As a result the thermostat entity doesn't show if it's idle or actively cooling/heating.
I did some tests and if I remove "heat_pump_cooling: sensor.study_heat_pump_state" from config and switch to simple heat or cool mode, it starts reporting the "hvac_action" status.

Please check v<IP_ADDRESS>

Please check v<IP_ADDRESS>

Now everything works completely fine! Status is reported and displayed in a thermostat entity.
Thank you for a very quick fix!


Test release tagging

What this PR does / why we need it:
Test new release tagging functionality
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/ok-to-test

/lgtm
/approve


The ability to use intellisense for any files is not working in coder 3.0.0.

I am using coder version latest for linux x86_64 and I found issues even with older version the issues are

Intellisense and auto completion is broken not working.
Extensions are not working at all
Even for editing html nothing works even after using snippets extensions.
Please fix them as it hurts productivity..
No suggestions working for even .js files.

sorry for incomplete gif
here is the full issue


ext: lib: crypto: Update mbedTLS 2.14.1

Since 2.12.0 release mbedTLS has an important security fix concerning
RSA PKCS#1 v1.5 decryption (CVE-2018-19608). Besides that it has very
few API changes, and the usual set of functional improvements, security
fixes and bug fixes. A list with all changes can be found in:
./ext/lib/crypto/mbedtls/ChangeLog
It should also be noted that the small change concerning _POSIX_C_SOURCE
applied to x509.c has been moved to platform_util.c, this time with a
proper define guard.
Signed-off-by: Aurelien Jarno<EMAIL_ADDRESS>

Codecov Report

Merging #12085 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12085   +/-   ##
=======================================
  Coverage   48.05%   48.05%
=======================================
  Files         281      281
  Lines       43416    43416
  Branches    10406    10406
=======================================
  Hits        20864    20864
  Misses      18403    18403
  Partials     4149     4149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523932c...d55b39c. Read the comment docs.

@rlubos: I wonder if you should be included in reviews like this, as I guess you're probably working with TLS more closely as anyone else ;-).


[Feature Request] helm package name should use --app-version

This is a continuation of the helm install --app-version thread #3555.  RE: @iorlas in https://github.com/helm/helm/issues/3555#issuecomment-549582383
To avoid all confusions, assuming:

A helm package is meant to be the "rpm" of an k8s application
Chart.version is meant to be the version of chart files (i.e. the yamls)
Chart.appVersion is version of the application - locking "this" .tgz to this application version (e.g. docker image tag)

In order to match the naming schemas of rpms and to avoid all confusions between --version and --app-version: the package name needs to reflect the app version, not the chart version.
In an idea world: once you've build your helm yaml files, you'll almost never change them as you deploy additional versions of your application.
One issue with matching versions is this doesn't really work in the real world dev environment:

# This is the chart version. This version number should be incremented each time you make changes to the chart and its templates, including the app version.

e.g. How do you build a package tagged by ref tags, e.g. git rev hash?
This, production releases, and the confusion over helm versions can all be resolved by just naming the package after the --app-version.

If this was the case, you couldn't iterate on charts unless there's also upstream changes to bump the version. This would render https://github.com/helm/charts/ impossible to deliver.
If your Helm charts are part of the project they deliver, then the version and appVersion should be the same (except the latter's a string). This is the case for Agones, for example, as well as the Helm charts we develop at my workplace.
In the RPM world, the RPM version generally contains the appVersion, with preceding epoch, and trailing package version. However, RPMs do not expect SemVer the way Helm does. I'm more familiar with Debian, which had its own version-ordering system and depended on packagers to mangle upstream versions to suit that, if they didn't already have a consistent order. It couldn't do things like SemVer can in terms of the ~ or ^ operators, because the version was purely ordered, without semantics.
It's the same reason version is a SemVer, while appVersion can be a string.
So in-short, (IMO) the Chart version is closer to the intent of the RPM version, but due to stricter limitations, diverges further from the appVersion than happens in RPMs.

Hmm. This is where things start coming at odds with each other when you start tying the appVersion to a Docker tag (a logical association). This is where we're having trouble, i.e. the dev scenario I mentioned above. Since version must be a SemVer, we simply cannot use Docker tags as a Chart version.
How do we create a visual version difference to the developers when appVersion isn't apparent on the charts?
Because of how k8s works with it applications: in a dev world, there has be be some way to allow tag versions across the board.

It couldn't do things like SemVer can in terms of the ~ or ^ operators, because the version was purely ordered, without semantics.

Why not? We do this all the time with php composer. We can use SemVer or we can use strings versions which are simply parsed or ignored in versioning schema, i.e. if version is not a SemVer number, don't include it in ~ and ^ pattern matching.

Please keep the conversation going in #3555. That way the rest of the community interested in the discussion can follow along without having to follow multiple threads. Thanks.

@bacongobbler I guess it is an attempt to split the discussion into multiple sub-topics. #3555 covers more than just a flag question.
This issue covers package naming issue, which is a side-question, although related to the whole versioning epic, could be covered aside.
Do you suggest to come up with whole picture of versioning first, in #3555, then providing a proposal covering all the pieces?

yes.


Style modal true to mockup

Looks like this now:

Nice!
On Thu, Dec 15, 2016, 05:55 Kristina Schneider<EMAIL_ADDRESS>wrote:

Merged #115 https://github.com/datproject/dat-desktop/pull/115.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/datproject/dat-desktop/pull/115#event-894713834, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACWlemkQqbTtj66KSGarXhHyQUbk9Vfyks5rIMg4gaJpZM4LNsxC
.


Day1 ex1

gogo

Your scripts don't have executable permissions, so they can't run as command-line programs (at least on Mac/Linux).

None of your functions have documentation strings.  You should write documentation strings for all your functions!  Good to start good habits early.

I notice that your text editor is using [tab] characters instead of 4 spaces; make sure you set the preferences of your text editor to not use tab characters when the tab key is pressed.  It will work as long as only tabs are used everywhere but as soon as someone else touches the code who is programmed to use spaces, then it will break.  So use spaces, not tabs (your editor should have some settings regarding this).

breakout.py
Your final printed sentence has an extra space before the period.  Can you fix this?
sum_digits.py
Interesting how you're casting the number string to a list....but that's not actually necessary.  For example, see what the following does:
s = 'I am a string'
for char in s:
    print char

i.e., you can loop through characters in a string without having to bother with the list thing.
Also note that the way you've written sum_digits takes only a string as input; might make a bit more sense to have it take a number and have the casting to string happen inside the function, but that's a minor point.
fizzbuzz.py
Good, but can you manage it with one fewer test statement?

HI Tim,
Thanks for the comments! I will look into them tonight. How do I give my
programs executable permission? I thought the first line in the programs
took care of that? Sorry to bother you with so many questions.
Best,
Jinsoo
On Jun 10, 2015 11:09 PM, "Timothy Morton"<EMAIL_ADDRESS>wrote:

Your scripts don't have executable permissions, so they can't run as
command-line programs (at least on Mac/Linux).
None of your functions have documentation strings. You should write
documentation strings for all your functions! Good to start good habits
early.
I notice that your text editor is using [tab] characters instead of 4
spaces; make sure you set the preferences of your text editor to not use
tab characters when the tab key is pressed. It will work as long as only
tabs are used everywhere but as soon as someone else touches the code who
is programmed to use spaces, then it will break. So use spaces, not tabs
(your editor should have some settings regarding this).
breakout.py
Your final printed sentence has an extra space before the period. Can you
fix this?
sum_digits.py
Interesting how you're casting the number string to a list....but that's
not actually necessary. For example, see what the following does:
s = 'I am a string'
for char in s:
print char
i.e., you can loop through characters in a string without having to bother
with the list thing.
Also note that the way you've written sum_digits takes only a string as
input; might make a bit more sense to have it take a number and have the
casting to string happen inside the function, but that's a minor point.
fizzbuzz.py
Good, but can you manage it with one fewer test statement?
—
Reply to this email directly or view it on GitHub
https://github.com/timothydmorton/usrp-sciprog/pull/12#issuecomment-110983268
.

Don't apologize---this is what learning looks like!
On a mac/linux system (and maybe in your terminal emulator) you would type chmod +x <filename> to give it executable permissions.  ls -l <filename> would show you the permissions (if you see 'x' characters then you're in business).


instances not passing healthcheck.

hello,
great example, when i run it my instances are not being seen as healthy by the elb?
any ideas?

Amazon Linux when doing a yum update could not see the repo. It needed a default internet gateway which my Dev vpc did not have.


Moving from Teststack White to FlaUI

Hi There
I have a big project written in Teststack white. Is there any efficient way of moving from TestStack white to FlaUI? We have approx. 200 tests under 3 projects. We have updated to .Net 4.8 and it broke all our UI tests written using TestStack.White. Please guide me if there is any best possible way.

@Harpreet20 In general it would depend on the exact functionality you use in the framework. I did something similar and it becomes very technical. As a rule of thumb use page object pattern if you haven’t used it yet. In my experience this makes upgrading smoother.

Thank you Godrose
We have all the windows objects in one class. Could you please share your steps? is it more efficient to update the white framework code locally and enhance it OR migrate the tests to FlaUI. Are you using FlaUI to run tests on server/VM using build pipelines?

I would recommend migrating the tests to FlaUI. The APIs are somewhat similar but still it's faster in my experience. You can also migrate gradually and maintain them side-by-side.
I use FlaUI in a CI server as well using YAML.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

If you have more to discuss, please head over to the gitter chat.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

Hi @Roemer - Is white adapter still active? we have similar problem statement. ie. we need to migrate a test suite that is developed using white framework to FlaUI. We are getting some errors during the migration process. Especially some of the methods such as Application.Session(), WindowsFactory.Desktop, AutomationElement.ControlTypeProperty are not recognised. Would you be able to help with this?

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

There is also a small adapter found here: https://github.com/FlaUI/FlaUI.Adapter.White
It allows to re-use some syntax from White but run with FlaUI. You could have a look at it.

Hi @Roemer - Is white adapter still active? we have similar problem statement. ie. we need to migrate a test suite that is developed using white framework to FlaUI. We are getting some errors during the migration process. Especially some of the methods such as Application.Session(), WindowsFactory.Desktop, AutomationElement.ControlTypeProperty are not recognised. Would you be able to help with this?

Hi There
I have a big project written in Teststack white. Is there any efficient way of moving from TestStack white to FlaUI? We have approx. 200 tests under 3 projects. We have updated to .Net 4.8 and it broke all our UI tests written using TestStack.White. Please guide me if there is any best possible way.

Hi @Harpreet20 - Did you managed to resolve this problem? If so, can you please guide us with the steps. We are trying to use white adapter but getting some errors.

Hi There
I have a big project written in Teststack white. Is there any efficient way of moving from TestStack white to FlaUI? We have approx. 200 tests under 3 projects. We have updated to .Net 4.8 and it broke all our UI tests written using TestStack.White. Please guide me if there is any best possible way.

Hi @Harpreet20 - Did you managed to resolve this problem? If so, can you please guide us with the steps. We are trying to use white adapter but getting some errors.

@Logesh8008
Hi Logesh, We moved to another solution and did not look at this thread. Did you manage to solve this problem? How was the merge?


Route [frontend.auth.account.confirm.resend] not defined

Followed the installation instructions for Laravel and the welcome page loads but if I try to do anything else I get the following error. Can someone help me out?
Route [frontend.auth.account.confirm.resend] not defined. (View: /home/victor/adminlte/resources/views/vendor/adminlte/layouts/partials/htmlheader.blade.php) (View: /home/victor/adminlte/resources/views/vendor/adminlte/layouts/partials/htmlheader.blade.php) (View: /home/victor/adminlte/resources/views/vendor/adminlte/layouts/partials/htmlheader.blade.php) --

Umm @fricna are you sure are you speaking about this package? I'm not aware of any frontend.auth.account.confirm.resend ?
I will close this issue feel because I cannot reproduce the problem. Please feel free to ask me to reopen the issue if you can give me more information.


Strict-Transport-Security on Bramble?

Is it possible to set the Strict-Transport-Security header from Bramble response?

Hi @marcosuma,
You can modify the response by wrapping the public or private mux http.Handler using a plugin. There's a few examples in the plugins folder, the best one is probably the cors example


The accuracy issue of real-time Speech-to-Text (STT) transcription

The text data returned by this callback
recorder.text(process_text)
often contains repeated content or accumulates with a delay. Are there recommended reference values for the recorder_config parameter?Thanks.
recorder = AudioToTextRecorder(**recorder_config)

This sounds more like the behaviour of the on_realtime_transcription_update callback. Definitely should not occur with the default parameter set. My first guess would be you are maybe using the same callbacks for both the on_transcription_finished callback from the text method and the on_realtime_transcription_update callback from the AudioToTextRecorder constructor.

Some updates on this. Former faster-whisper version prob caused this (got somehow corrupted on pypi), I think it was 0.6.0. Neuer versions are fine.

Thanks! Should I use the  0.6.0 version of the faster-whisper instead of the latetest [v1.0.1]?(https://github.com/SYSTRAN/faster-whisper/releases/tag/v1.0.1)
Or just update the latest faster-whisper / RealtimeSTT version?

great! Another question is the latest v0.1.15 of RealtimeSTT has the parameter beam_size, it can be use to reduce the delay?

You trade-offs:accuracy vs. Speed: A larger beam_size yields better quality output because the model can explore more options and potentially avoid local minima in the search space. But also means slower performance because more sequences are evaluated at each step.


Required environment variable

The spec doesn't seem to provide for an option to be required either by supplying an environment variable and/or supplying a command line option.
eg.
package main

import (
    "fmt"
    "os"

    "github.com/jawher/mow.cli"
)

func main() {
    app := cli.App("test", "test")

    app.Command("cmd", "command", func(cmd *cli.Cmd) {
        param := cmd.String(cli.StringOpt{
            Name:   "param",
            EnvVar: "PARAM",
        })
        cmd.Spec = "--param"
        cmd.Action = func() {
            fmt.Println("param", *param)
        }
    })

    app.Run(os.Args)
}

i'd like this program to succeed if the program is run as either myapp --param foobar or PARAM=foobar myapp but print the usage info otherwise if both are omitted.
I guess I can make the argument optional in the Spec and then check it from within the action, but it seems like a common enough use case that mow.cli would have a better way of specifying it.

@gwatts Thanks for raising the issue.
This is indeed a good suggestion.
I myself ran into this many times.

@jawher do you have any thoughts on how you would implement this?  I can probably create  a PR

@gwatts Actually I worked a bit on this, and it turns out that it's a tiny modification to the code, which surprised me. I'll have to look at it a bit more to be sure that it doesn't break anything else. Stay tuned !
But if you want to take a stab at it, the general idea is:

when an option is created, it is pre-initialized with either the value from the env var if it exists, or the user specified value.
the user spec is transformed into a finite state machine (FSM), where a required option is represented with a transition from a state A to B
while traversing the generated FSM, as of now, if a required option is not found in the user input, the traversal of this part is considered as failed

What needs to be done is: if no transition for an option is found, do not bail out immediately. Instead, check if a value for this option is already set. If that's the case, consider the traversal as successful.

@jawher that seems simple enough, though i was really wondering if you thought there was a need to be able to specify that behaviour - ie. that falling back to an env var was ok for a required parameter, or whether it should just always work that way.
Seems reasonable to me that that should be standard behaviour, but then that happens to fit my use case ;-)

Closing due to the merge of #43  :-)


Approval to contribute?

Hello, guys.
I have written a driver for the MAX31865 RTD-to-Digital converter.  It is limited at this point in that you have to ask the device to make a measurement for you, but it works.  I am currently adding code in order to take full advantage of the device's capabilities, including repeated automatic measurements at this point.
I would like to contribute to this project and add that driver here.
I followed the instructions here (https://github.com/androidthings/contrib-drivers/blob/master/CONTRIBUTING.md) and submitted the individual CLA, but have yet to hear anything back.
Is there anything else I need to do before I can start contributing to the project?
Thanks.
-Mario

We're still trying to figure out the process for accepting new drivers to the repository, as there's not a clear understanding of who would own the maintenance of this driver over time.
If you are writing a driver for a new peripheral, you can post it on your own GitHub and add it to JCenter or similar services on your own.

Understood.  I can put it in a repository of my own.  Once I do that, what are the possibilities you guys can create a repository for it under Contrib-Drivers with just a readme file that forwards people to my repository.  That way it would at least make people who come looking for a driver here to find it in my repository.
Thanks.

We are thinking about better ways to show drivers.


Copy images to clipboard

Feature details
It would be great if I could choose to copy the selected image to the clipboard rather than opening the file. My workflow is typically take screenshot (multiple)  ▶ use screenshot in another application (email, presentation, etc), so opening the file is an extra step. Thank you!

Create a new workflow.
Add a File Action Trigger.
2.1. Make the types +public.image.
Connect the Copy Image to Clipboard Automation Task.

You’re done. Now when using the workflow, you can use the Universal Action to copy images to the clipboard.


Pre/Post rollout disabling doesn't work when defined at the project level

When disabling pre-rollout tasks at the project level, it fails to set to the variable correctly if there is only the project variable defined.
https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L369-L376
The build script should check in a similar way to how we do other overrides (eg https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L74-L82)
This will impact Lagoon 2 and Lagoon 1 openshift and kubernetes build deploy images

@shreddedbacon those links now 404. Is this issue still valid?

Yeah, I believe it is based on this https://github.com/uselagoon/lagoon/blob/main/images/kubectl-build-deploy-dind/build-deploy-docker-compose.sh#L510-L517


[FEATURE REQUEST] Make the Additional Context part obligatory in the invitation template

Description of feature request, idea
Make the Additional Context part obligatory in the invitation template.
Add (multiple) screenshot links (if applicable)
No response
Add any other context about the feature request here
Many people just use the invitation template without explaining why do they want to join or simply without providing any input. I think we should make it obligatory. Let me know what do you think. Thanks. 🙂

I think we should make Additional Context obligatory because this will make the community know the actual reason why people are getting into EddieHub and would encourage us to work more on that. It would also enable community members to know the newly joined folks better.

@Sam-Varghese, that's what I just tried to say. :)

I`m not a fan of making the "Additonal Context" obligatory.
I think when you want to join the community we sould make it as effortles as possible for new folks to join.
For myself it would be deterrent that I have to provide those informations. Further I new folks could simple fill out that field with - etc.


chore: fix indent in views

Description
Although not explicitly stated, it appears that view file indentation is basically done with tabs.
This PR adds .editorconfig for Views and fixes indentation in some files.
It seems two space size indentation is common for HTML/CSS, so I set indent_size = 2.
The only one exception is system/Debug/Toolbar/Views/toolbar.css.
It is generated by scss and it uses space 2 indentation.
Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
[x] Conforms to style guide

I really don't have a preference here. Maybe see what @paulbalandan thinks from a CS Fixer perspective?

I don't have a strong opinion and will go with the general consensus, but my personal thoughts are why make it more complex than needed? We chose to use PSR12, so maybe just keep everything 4 spaces for consistency?

I guess - where do you see that this is a common practice? I personally haven't run across that and this feels like opening another "tabs vs spaces" war where there isn't a real winner, just personal choice. I've always been a tabs guy in the past, but find I really don't care anymore in that war, but why make things more difficult for ourselves and potential contributors?  Unless everyone's IDEs default to this?

I am kind of confused.
Does this PR propose using tabs in the view files or not (can not really distinguish on mobile)?
While this comes down to personal preference of course, I think I would like to have the same convention for all files that belong to the framework, regardless of their extension.

Does this PR propose using tabs in the view files or not (can not really distinguish on mobile)?

Yes, and tabs are mainly used now.
(No problem. If I see on PC, I can not distinguish!)

where do you see that this is a common practice?

Probably 2 space size indentation came from Google guideline.
In fact, it is by spaces, not by tabs.

Indent by 2 spaces at a time.
https://google.github.io/styleguide/htmlcssguide.html#Indentation

For readability, add two spaces of indentation. Do not use the tab key.
https://www.w3schools.com/html/html5_syntax.asp

Facts:

now we use tabs and spaces for indentation of view (HTML/CSS/JS) files.
we don't have proper .editorconfig for view files.

feels like opening another "tabs vs spaces" war where there isn't a real winner, just personal choice.

I don't like the word war, but unfortunately already someone is using tabs and another is using space for view files.
I think it would be better to at least be consistent.
If we agree with 4 space, I am okay.

Obviously, I'm a fan of the consistent approach so I vote for 4 space in views, also.

Four spaces works for me. @paulbalandan can we just lift the CS Fixer exemption for Views and have it apply the changes? Or is that likely to have more side effects?

This will have side effects and would need a different config file, like we did for the examples in the docs.

@paulbalandan Your opinion?

I think I skipped Views before because of some other rules affecting the files, not by the indentation rule.
Looks like majority wants 4 spaces for the view files, and that's okay with me. But I think it should be only for the PHP files. For the other files like JS or HTML, I think we should use what's the convention for those files.

It may be overkill but maybe we can setup GHA to run formatters on those other files, like ESLint or Prettier.

No one strongly objected to the 4 spaces, I created a new PR: #6039

It may be overkill but maybe we can setup GHA to run formatters on those other files, like ESLint or Prettier.

View files are changed rarely, so I want to see the new editorconfig works fine or not.
We are heavy user of GHA, so I don't want to add loads by adding checks that do not help a lot.

View files are changed rarely, so I want to see the new editorconfig works fine or not. We are heavy user of GHA, so I don't want to add loads by adding checks that do not help a lot.

Fair point. Yeah, that was overkill. 😂


Remove Travis CI configuration as GitHub Actions is now used for CI

Codecov Report

Merging #1088 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1088   +/-   ##
=========================================
  Coverage     99.39%   99.39%
  Complexity     2261     2261
=========================================
  Files           349      349
  Lines          6289     6289
  Branches        360      360
=========================================
  Hits           6251     6251
  Misses            5        5
  Partials         33       33

Flag
Coverage Δ
Complexity Δ

#unittests
99.39% <ø> (ø)
2261.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8e9b8...20af67d. Read the comment docs.


CSP Final, N@tM Retrospective | Isabel Marilla Individual Review | Period 2

My written review consists of my

[x] blog of CPT project, plans and completion of work here
[x]  design, an article that contains the preparation of key features before coding
[x]  correlation to CPT, an article that shows how your feature maps to College Board requirements
[x]  pull request(s), an issue containing a link to your pull requests from fork or branch to the main
[x]  code commits, the comments & deltas in GitHub that prove your work
[x] one-minute video, prepared in CPT style to highlight your feature with the project
https://www.veed.io/view/86f3e6a6-82b5-4f4b-9bd6-0bb3c6fe4778?panel=share

Your blog and all pieces on journey are looking very nice.  Try to fix these things quick.
Problems:

CPT requirements could be bullets with response to stand out better.  Not nested in paragraph.
Video is private, I can't get to it.

Thank you for looking at my blog! :)
I fixed all the changes. Let me know if it works!!!!!

Glows:

Gives short summary of project as introduction
Provides links to previous issues to show workflow and planning
CPT requirements gone over concisely in table
Commits aren’t just a big list, but gives key commits for specificity
Page shows clear organization in project
Video requirements also were discussed on blog page
Video also goes over everything nicely, and covers feature of website
Grows:
Video could have used a bit more editing, perhaps zooming or highlighting

Overall, I think you did wonderfully with this blog and video. It’s super organized and has enough information to provide evidence of fulfilling the CPT requirements, but doesn’t overwhelm the reader, as it is very easy to understand. Your video also goes over your feature at a nice pace. Well done.
5/5

Glows:

Gives short summary of project as introduction
Provides links to previous issues to show workflow and planning
CPT requirements gone over concisely in table
Commits aren’t just a big list, but gives key commits for specificity
Page shows clear organization in project
Video requirements also were discussed on blog page
Video also goes over everything nicely, and covers feature of website
Grows:
Video could have used a bit more editing, perhaps zooming or highlighting

Overall, I think you did wonderfully with this blog and video. It’s super organized and has enough information to provide evidence of fulfilling the CPT requirements, but doesn’t overwhelm the reader, as it is very easy to understand. Your video also goes over your feature at a nice pace. All requirements were completed, plus having really good organization. 1.1/1

Mathew does a nice job of highlighting some likes.  This shows that he is very vested in his grading and is picking out gems that he likes, or that need improvement.  I watched this video as well and though it has many great qualities there is something about things like "zooming", "highlighting" that need improvement.  Isabel does a great transition to backend home page and showing JSON/Collection in action; I think this is part of the running system and shows power of work leading into writeup about Collection.     These call outs are not only glows, but perhaps things Mathew could incorporate or learn form.

Glows (Blog):

The blog is concise and organized
Shows teamwork and cooperation through the writing, as many features were worked on with others
Links to the brainstorming and checkpoint blogs, demonstrating thought out planning and good documentation of project
Fleshed out explanation of the purpose of the project and functionality
CPT Requirements is organized in a table with each requirement clearly listed and a concise explanation of how their code satisfies requirements
Describes aspects of the video, helping viewer to better understand what information the video encompases
References a few key commits

Grows (Blog):

Bullet pointed information would have made information easier to process and much more concise
More pictures of code demonstrating the requirements could help provide concrete proof of met requirements in project
Link to video in blog would have been nice

Glows (Video):

Captions are easy to see and read
Demonstrates and explains the code nicely
I like the console and backend code demonstrations
No mouse wiggling

Grows (Video):

Zooming in on the features would help it stand out and would be easier for the viewer to understand what is going on

I think you did wonderfully overall. There is plenty of information within your blog post that demonstrates a well fleshed out project. Multiple links to documentation show well thought out planning of the project before execution. The blog is easy to understand and the information is easy to process. The requirements are described in decent detail, although some pictures of the code would be nice to have. Overall, I think this is a great blog.
1.1/1


Documentation planning

Problem Statement
Creating sub-issues for the #129
Create new issues for all documentation parts that need to be edited.
Should be completed by end of current sprint
Expected Behaviour
Issues have been created.
Tasks

[x] Check current documentation for errors
[ ] Check for missing parts of documentation
[ ] Create list for missing parts / errors

When we have the list of the things that need to be done, we can create the tickets and add them to the next sprint.

List of topics that have to be reworked in the rtd:

Architecture Overview
Project Structure
Pilot and Transpilemanager Documentation
Glossar


Import error for pose_extractor

Hello Daniil,
After successfully running python setup.py build_ext and adding the result to the  PYTHONPATH, I get a Segementation Fault 11 when trying to run the demo.py.
I checked the the path using python -c "import sys; print(sys.path) and the appropriate path('/xxx/lightweight-human-pose-estimation-3d-demo.pytorch/pose_extractor/build') is part of the list.
If I run  python -c " from pose_extractor import extract_poses I get the same segmentation fault 11.
The full error message for the first part is:
objc[4980]: Class CaptureDelegate is implemented in both /xxx/python3.7/site-packages/cv2/cv2.cpython-37m-darwin.so (0x11214f7d8) and /xxxi/lib/libopencv_videoio.3.4.2.dylib (0x123d6c8e8). One of the two will be used. Which one is undefined.
Segmentation fault: 11
I am currently using an Anaconda environment. My operating system is MacOs Catalina.
Thank you

Hi! The error tells, that there are two OpenCV version installed, so you should use only one (delete the second one, or somehow dispatch between Python and C++ symbols of CaptureDelegate).

Hello, thank you for taking the time to reply. I deleted one version, ran it again(rebuilt and exported path again for safe measure), now I simply received a Segmentation Fault 11.

This looks strange. If you have environment where OpenCV installed in Python, you may run just demo.py (without building C++ extension with setup.py), it will use just Python version of OpenCV.

This fps looks reasonable without GPU. For fast inference on CPU suggest to use OpenVINO.

Hope, it helped.


SharePoint Online Powershell - Root element missing error when run Connect-SPOService command

Hi Everyone,
I have newly installed SharePoint Online Management Shell (SharePointOnlineManagementShell_7521-1200_x64_en-us) on a windows 10 machine.
When i tried to run the 'Connect-SPOService -Url $adminUrl -Credential $credentials' I'm getting 'Root element is missing' error.

Category

[X] Question
[ ] Typo
[X] Bug
[ ] Additional article idea

Expected or Desired Behavior
When I ran the following command, I expect to connect to my SharePoint online tenant.
Steps to Reproduce

Install the SharePointOnlineManagementShell_7521-1200_x64_en-us
Open the SharePoint Online Managemnet Shell as administrator
Run the following commands
$adminUrl = "https://{domain}-admin.sharepoint.com" $userName =<EMAIL_ADDRESS>$password = Read-Host "Please enter the password for $($userName)" –AsSecureString $credentials = New-Object -TypeName System.Management.Automation.PSCredential -argumentlist $userName, $password Connect-SPOService -Url $adminUrl -Credential $credentials

What am I missing? Any guidance to resolve this issue is appreciated.
Thank you In advance

As this is around SharePoint Online PowerShell, we would appreciate if you'd create this to the right repository, since this is not really about the development topics. The right location would be https://github.com/microsoftDocs/office-docs-powershell. Thx.

Thank you Vesa. I have moved created new issue under the link you have provided.
Reference: https://github.com/MicrosoftDocs/office-docs-powershell/issues/919


New points_in_triangles_aligned function added

Codecov Report
Base: 78.64% // Head: 78.57% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (7e8ab49) compared to base (94d382e).
Patch coverage: 26.19% of modified lines in pull request are covered.

:exclamation: Current head 7e8ab49 differs from pull request most recent head 5ea456a. Consider uploading reports for the commit 5ea456a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   78.64%   78.57%   -0.07%
==========================================
  Files         178      178
  Lines       29913    29932      +19
==========================================
- Hits        23525    23520       -5
- Misses       6388     6412      +24

Impacted Files
Coverage Δ

resqpy/olio/vector_utilities.py
56.51% <21.05%> (+0.63%)
:arrow_up:

resqpy/grid_surface.py
73.35% <75.00%> (-1.01%)
:arrow_down:

resqpy/multiprocessing/wrappers/grid_surface_mp.py
71.61% <0.00%> (-0.65%)
:arrow_down:

resqpy/model/_xml.py
91.18% <0.00%> (-0.28%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


This library is fantastic! Can we use it also to parse 2525 Charlie codes?

This is working brilliantly for us and does exactly what it says on the tin. Thanks very much!
A quick question, can we gather information from a charlie code as well as create the symbol? For example, if given a code could we establish if it is a friendly sea unit? Or an enemy infantry unit? We were about to write our own parser for these codes and I thought maybe there'd be existing parsing in this lib.
Thanks again!

I've just found the getMetadata() function which seems to do exactly as I need.
symbol.getMetadata()
Thanks again.


The zksolc binary at path zksolc is corrupted

Hi,
I had follow the docs provided by zk Era.
https://era.zksync.io/docs/tools/hardhat/migrating-to-zksync.html#deploy-contracts
When i try to compile the contracts, i get this error:
Error in plugin @matterlabs/hardhat-zksync-solc: The zksolc binary at path zksolc is corrupted. Please delete it and try again.
Where i have already try to clean and re-install bu with the same result.
Thanks in advance

Bring to "default" settings fix the problem


Install instructions on webpage incomplete

I realize this is just a detail, but in the install instructions on the webpage it should say that if you install via pip without lxml, you need to have not only python and libxml2 headers, but also xslt1 headers (at least I had to install libxslt1-dev for the installation to succeed on Debian 7.8.
Thanks for your work!

This seems to be correct, as par the lxml website. I'll fix this ASAP.


cron refresh

We need to use module for crontab editing because by default it is not enable, and we have to crontab -e, make changes and write in order to reload and take care of this file

http://softwarefactory-project.io/r/3650


Support for downloading urls for posts with just photos

Creating this issue to address query for the comment: https://github.com/CrypticGuy/pyigdl/issues/1#issuecomment-2308898761
@amiteshore

Fixed as part of the PR: https://github.com/CrypticGuy/pyigdl/pull/6
Please update to 0.0.11 for using the library with the required fix.

@Amiteshore closing the issue as resolved. Please let me know if it works for you now.


Populating multiple paths is not supported

Refer to this mongoose document
https://mongoosejs.com/docs/populate.html#populating-multiple-paths
Seems it's not supported yet?

Can use Array for multiple paths
query['$populate'] = ['foo', 'bar']


python312Packages.fastcore: 1.7.2 -> 1.7.4

Diff: https://github.com/fastai/fastcore/compare/refs/tags/1.7.2...1.7.4
Changelog: https://github.com/fastai/fastcore/blob/1.7.4/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339761 run on x86_64-linux 1

24 packages built:

ghdorker
ghdorker.dist
python311Packages.execnb
python311Packages.execnb.dist
python311Packages.fastai
python311Packages.fastai.dist
python311Packages.fastcore
python311Packages.fastcore.dist
python311Packages.fastdownload
python311Packages.fastdownload.dist
python311Packages.ghapi
python311Packages.ghapi.dist
python311Packages.nbdev
python311Packages.nbdev.dist
python312Packages.execnb
python312Packages.execnb.dist
python312Packages.fastcore
python312Packages.fastcore.dist
python312Packages.fastdownload
python312Packages.fastdownload.dist
python312Packages.ghapi
python312Packages.ghapi.dist
python312Packages.nbdev
python312Packages.nbdev.dist


add compatibility for pushy to run inside service workers/web extensions

Hi @patrickkettner,
Thanks so much for your contribution!
We've merged your PR and added a caching mechanism for WebExtension browser storage in https://github.com/pushy/pushy-sdk-web/commit/dc41ff80701270be33036022a0ca65a9017df9fb as to avoid the async/await method signatures (as this will introduce multiple breaking changes for our clients).
These changes have now been published in version 1.0.13 of the Pushy Web SDK. Please give it a try, and let us know if you face any issues.


Show Space Around Zones setting does not persist on update or restart

Every time I restart my computer, or PowerToys is updated, the Show space around zones setting becomes enabled. Also, I'm not sure if this is related, but even with the space value set to 0, and setting it disabled, there is always still a border against the left  and right most zones and the edge of the screen. Between zones there is no border though. When dragging a window into the zone, the highlight area shows properly the entire area, but once dropped, the window shrinks to still have that border.

or PowerToys is updated

I just updated from v0.31.1 to v0.31.2 and had no border set before and there is no border after. So it worked for me for this update.
However, I've noticed your described behaviour for previous updates but cannot say for which ones the setting was not persisted.

@Nick-Zamora
what version are you running?

Sorry for slow response. I'm running v0.31.2 right now. I don't recall how my last update went though.

@Nick-Zamora
in 0.31.2 we have changed how the spaces around zones are persisted to disk. Also, now the value is per-template and per-layout and not anymore global.
We haven't had any report that the value is reset after a reboot. That would imply that the json file has been deleted.
Also, for upgrade, the file is not touched by the installer, so it should not reproduce.
Can you confirm that restarting the computer doesn't reset the value set per-layout?

That would imply that the json file has been deleted.

Where is this JSON saved to?

@bugybunny
%localappdata%\Microsoft\PowerToys\FancyZones\zones-settings.json

I want to reopen this instead of opening a new issue. This happened again with upgrade from v0.33.1 to v0.35.0. I am using the custom with name "Focus more centered for coding". I guess the "show-spacing":  was changed from false to true with the upgrade. I did not set the spacing to 0, I just untick the flag for the show spacing. So IIRC "spacing": 16 was also like this before the upgrade, just if it should be shown has been changed.
I did the following:

Download the release
Run the installer
Exited PowerToys because I was working on a PC where I do not need FancyToys yesterday. I did not open FancyZones (not the settings and also not the editor)
Started PowerToys today. Again without opening the FancyZones settings or the editor
Noticed the spaces and first opened the JSON file and copied the content (see below)
Opened the editor and unticked the box "Show space around zones"

(I have formatted the JSON to be better readable, original file was just one line)
{
	"devices": [
		{
			"device-id": "LOCALDISPLAY_5120_1440_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{7EBFB6B7-7DAD-471F-8528-8921450B7329}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "DELA10F#4&109cbb1&0&UID224795_5120_1440_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{43E391F2-2D82-4241-8392-15148D13F66E}",
				"type": "custom"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LEN40BA#4&109cbb1&0&UID265988_1920_1080_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{4AF8D022-2B38-4CEE-91E4-70DF4817523E}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "HWP3122#8&37aa7b8a&0&UID256_1920_1200_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{5C9D52C2-3647-4C6B-BDEC-20D5D82216F7}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LEN61B4#8&2edc1a3e&0&UID256_1920_1080_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{FC5588F4-F606-47EB-835A-A093E6F3FB11}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "HWP3123#8&37aa7b8a&0&UID258_1920_1200_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{E015F835-9A65-4564-A031-B6E88C241446}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LOCALDISPLAY_1920_1080_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{3D16B884-2004-4CDA-B847-3F55B52B55D6}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LEN61B4#8&2edc1a3e&0&UID256_1920_1200_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{02BED388-756E-4B86-B625-C68205BFBCE4}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LEN61B4#8&2edc1a3e&0&UID258_1920_1200_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{B554DA26-380F-4DD7-AC1D-BCDEEEDFF42E}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LOCALDISPLAY_3840_1080_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{3517DED5-C447-41E9-B010-09DF0448A3DA}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		},
		{
			"device-id": "LOCALDISPLAY_1920_1200_{00000000-0000-0000-0000-000000000000}",
			"active-zoneset": {
				"uuid": "{9F7D2178-2E59-44D9-8676-DDA8531FEFC1}",
				"type": "priority-grid"
			},
			"editor-show-spacing": true,
			"editor-spacing": 16,
			"editor-zone-count": 3,
			"editor-sensitivity-radius": 20
		}
	],
	"custom-zone-sets": [
		{
			"uuid": "{43E391F2-2D82-4241-8392-15148D13F66E}",
			"name": "Focus more centered for coding",
			"type": "grid",
			"info": {
				"rows": 1,
				"columns": 3,
				"rows-percentage": [
					10000
				],
				"columns-percentage": [
					3089,
					4408,
					2503
				],
				"cell-child-map": [
					[
						0,
						1,
						2
					]
				],
				"sensitivity-radius": 20,
				"show-spacing": true,
				"spacing": 16
			}
		}
	],
	"templates": [
		{
			"type": "blank",
			"show-spacing": false,
			"spacing": 0,
			"zone-count": 0,
			"sensitivity-radius": 0
		},
		{
			"type": "focus",
			"show-spacing": false,
			"spacing": 0,
			"zone-count": 3,
			"sensitivity-radius": 20
		},
		{
			"type": "columns",
			"show-spacing": true,
			"spacing": 16,
			"zone-count": 3,
			"sensitivity-radius": 20
		},
		{
			"type": "rows",
			"show-spacing": true,
			"spacing": 16,
			"zone-count": 3,
			"sensitivity-radius": 20
		},
		{
			"type": "grid",
			"show-spacing": true,
			"spacing": 16,
			"zone-count": 3,
			"sensitivity-radius": 20
		},
		{
			"type": "priority-grid",
			"show-spacing": true,
			"spacing": 16,
			"zone-count": 3,
			"sensitivity-radius": 20
		}
	],
	"quick-layout-keys": []
}

So, I am just in the process of upgrading PowerToys on another machine an started to do some checks before the upgrade. On this machine I am on v0.31.2.
Content of the zones-settings.json before the upgrade is as follows

zones-settings.json before upgrade and before opening the launch editor, formatted by a tool, was just one line originally
```json
{
   "devices":[
      {
         "device-id":"DELA10F#4&1a1f9b38&0&UID224795_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{08A7452F-C795-4295-9483-A3F21ADA503C}",
            "type":"columns"
         },
         "editor-show-spacing":true,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"DELA10F#4&1a1f9b38&0&UID200195_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
            "type":"custom"
         },
         "editor-show-spacing":false,
         "editor-spacing":5,
         "editor-zone-count":4,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"LEN40AF#4&1a1f9b38&0&UID265988_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
            "type":"custom"
         },
         "editor-show-spacing":true,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"LOCALDISPLAY_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
            "type":"custom"
         },
         "editor-show-spacing":false,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"LEN40AF#4&1a1f9b38&0&UID265988_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{4B5F1EE7-40A3-404B-A58A-F14BCDE23E78}",
            "type":"priority-grid"
         },
         "editor-show-spacing":true,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"LEN40AF#4&1a1f9b38&0&UID265988_1440_2560_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{410FF68C-83A1-4032-ADBB-89FEC059EAB4}",
            "type":"priority-grid"
         },
         "editor-show-spacing":true,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      },
      {
         "device-id":"LOCALDISPLAY_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
         "active-zoneset":{
            "uuid":"{DE27B8D5-AB02-4E57-98B3-F208421FB732}",
            "type":"priority-grid"
         },
         "editor-show-spacing":true,
         "editor-spacing":16,
         "editor-zone-count":3,
         "editor-sensitivity-radius":20
      }
   ],
   "custom-zone-sets":[
      {
         "uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
         "name":"Middle Focus",
         "type":"grid",
         "info":{
            "rows":1,
            "columns":3,
            "rows-percentage":[
               10000
            ],
            "columns-percentage":[
               3000,
               3945,
               3055
            ],
            "cell-child-map":[
               [
                  0,
                  1,
                  2
               ]
            ],
            "sensitivity-radius":20,
            "show-spacing":true,
            "spacing":16
         }
      },
      {
         "uuid":"{5FB00BE7-8C50-45C1-AC6F-9A7976B75145}",
         "name":"Focus",
         "type":"canvas",
         "info":{
            "ref-width":5120,
            "ref-height":1400,
            "zones":[
               {
                  "X":512,
                  "Y":140,
                  "width":3072,
                  "height":840
               },
               {
                  "X":1024,
                  "Y":280,
                  "width":3072,
                  "height":840
               },
               {
                  "X":1536,
                  "Y":420,
                  "width":3072,
                  "height":840
               }
            ],
            "sensitivity-radius":20
         }
      }
   ],
   "templates":[
]
}
</details>

I am always using "Middle Focus" and opening it in the layout editor is already interesting.

![image](https://user-images.githubusercontent.com/5311105/113856008-f96a8000-97a0-11eb-9c7f-a4d54b3460d7.png)

The editor shows the zones with spaces, `"show-spacing": true` is in the JSON and the zone overlay (while editing) also shows the spaces.
![image](https://user-images.githubusercontent.com/5311105/113856164-2b7be200-97a1-11eb-8872-a00688651ee1.png)

However, the zones have no spacing between them when I maximize something inside of a zone.
![image](https://user-images.githubusercontent.com/5311105/113856299-549c7280-97a1-11eb-9634-10909bfa07bf.png)

I can then go into the layout editor again, change to no spacing, save, edit and set to true again and then I have the spaces around the zones.
So to conclude: JSON already had `"show-spacing": true`, the editor showed it but it was not applied when moving windows to a zone. I did not edit the zones-settings.json manually or something like that. I did not even open the layout editor since the last upgrade (even some upgrades before, guess last time was when I had this problem after upgrade, dunno when that was). I cannot remember if I have ever restarted PowerToys. But IIRC I had some laptop restarts after Windows updates and this would have restarted PowerToys. So no idea when and how the `"show-spacing": true`  changed but it seems to not be update related and somehow it was never applied.
Unfortunately, I forgot to try and restart PowerToys manually before opening the layout editor to see if the `"show-spacing": true` would have been applied.

Interestingly, I just opened the zones-settings.json again after opening the layout editor and changing the show spacing again and saved. The file is now formatted (nothing automatic done by my editor) with newlines, like pasted above. Before it was just on one line. There were no newlines before (not even just \r), now there are \r\n. I guess it does not make a difference your used parser could still read the JSON correctly. Just something interesting that I noticed but hope it had no effect.

<details>
  <summary>During upgrade, file did not change (as expected)</summary>
```json
{
  "devices": [
    {
      "device-id": "DELA10F#4\u00261a1f9b38\u00260\u0026UID200195_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
        "type": "custom"
      },
      "editor-show-spacing": false,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "DELA10F#4\u00261a1f9b38\u00260\u0026UID224795_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{08A7452F-C795-4295-9483-A3F21ADA503C}",
        "type": "columns"
      },
      "editor-show-spacing": true,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "LEN40AF#4\u00261a1f9b38\u00260\u0026UID265988_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
        "type": "custom"
      },
      "editor-show-spacing": true,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "LOCALDISPLAY_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
        "type": "custom"
      },
      "editor-show-spacing": false,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "LEN40AF#4\u00261a1f9b38\u00260\u0026UID265988_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{4B5F1EE7-40A3-404B-A58A-F14BCDE23E78}",
        "type": "priority-grid"
      },
      "editor-show-spacing": true,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "LEN40AF#4\u00261a1f9b38\u00260\u0026UID265988_1440_2560_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{410FF68C-83A1-4032-ADBB-89FEC059EAB4}",
        "type": "priority-grid"
      },
      "editor-show-spacing": true,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    },
    {
      "device-id": "LOCALDISPLAY_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}",
      "active-zoneset": {
        "uuid": "{DE27B8D5-AB02-4E57-98B3-F208421FB732}",
        "type": "priority-grid"
      },
      "editor-show-spacing": true,
      "editor-spacing": 16,
      "editor-zone-count": 3,
      "editor-sensitivity-radius": 20
    }
  ],
  "custom-zone-sets": [
    {
      "uuid": "{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}",
      "name": "Middle Focus",
      "type": "grid",
      "info": {
        "rows": 1,
        "columns": 3,
        "rows-percentage": [
          10000
        ],
        "columns-percentage": [
          3000,
          3945,
          3055
        ],
        "cell-child-map": [
          [
            0,
            1,
            2
          ]
        ],
        "show-spacing": false,
        "spacing": 16,
        "sensitivity-radius": 20
      }
    },
    {
      "uuid": "{5FB00BE7-8C50-45C1-AC6F-9A7976B75145}",
      "name": "Focus",
      "type": "canvas",
      "info": {
        "ref-width": 5120,
        "ref-height": 1400,
        "zones": [
          {
            "X": 512,
            "Y": 140,
            "width": 3072,
            "height": 840
          },
          {
            "X": 1024,
            "Y": 280,
            "width": 3072,
            "height": 840
          },
          {
            "X": 1536,
            "Y": 420,
            "width": 3072,
            "height": 840
          }
        ],
        "sensitivity-radius": 20
      }
    }
  ],
  "templates": [
    {
      "type": "blank",
      "show-spacing": false,
      "spacing": 0,
      "zone-count": 0,
      "sensitivity-radius": 0
    },
    {
      "type": "focus",
      "show-spacing": false,
      "spacing": 0,
      "zone-count": 3,
      "sensitivity-radius": 20
    },
    {
      "type": "columns",
      "show-spacing": true,
      "spacing": 16,
      "zone-count": 3,
      "sensitivity-radius": 20
    },
    {
      "type": "rows",
      "show-spacing": true,
      "spacing": 16,
      "zone-count": 3,
      "sensitivity-radius": 20
    },
    {
      "type": "grid",
      "show-spacing": true,
      "spacing": 16,
      "zone-count": 3,
      "sensitivity-radius": 20
    },
    {
      "type": "priority-grid",
      "show-spacing": true,
      "spacing": 16,
      "zone-count": 3,
      "sensitivity-radius": 20
    }
  ]
}

After upgrade and PowerToys have been opened for the first time (just the main screen, not FancyZones or even the editor)
```json
{"devices":[{"device-id":"LEN40AF#4&1a1f9b38&0&UID265988_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}","type":"custom"},"editor-show-spacing":true,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"DELA10F#4&1a1f9b38&0&UID224795_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{08A7452F-C795-4295-9483-A3F21ADA503C}","type":"columns"},"editor-show-spacing":true,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"DELA10F#4&1a1f9b38&0&UID200195_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}","type":"custom"},"editor-show-spacing":false,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"LOCALDISPLAY_5120_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}","type":"custom"},"editor-show-spacing":false,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"LEN40AF#4&1a1f9b38&0&UID265988_1440_2560_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{410FF68C-83A1-4032-ADBB-89FEC059EAB4}","type":"priority-grid"},"editor-show-spacing":true,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"LEN40AF#4&1a1f9b38&0&UID265988_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{4B5F1EE7-40A3-404B-A58A-F14BCDE23E78}","type":"priority-grid"},"editor-show-spacing":true,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20},{"device-id":"LOCALDISPLAY_2560_1440_{EB174640-C79E-4D43-8A3F-0715D4B0E30F}","active-zoneset":{"uuid":"{DE27B8D5-AB02-4E57-98B3-F208421FB732}","type":"priority-grid"},"editor-show-spacing":true,"editor-spacing":16,"editor-zone-count":3,"editor-sensitivity-radius":20}],"custom-zone-sets":[{"uuid":"{7C2F89C6-9317-44BD-A4DE-75FF8BC88A72}","name":"Middle Focus","type":"grid","info":{"rows":1,"columns":3,"rows-percentage":[10000],"columns-percentage":[3000,3945,3055],"cell-child-map":[[0,1,2]],"sensitivity-radius":20,"show-spacing":false,"spacing":16}},{"uuid":"{5FB00BE7-8C50-45C1-AC6F-9A7976B75145}","name":"Focus","type":"canvas","info":{"ref-width":5120,"ref-height":1400,"zones":[{"X":512,"Y":140,"width":3072,"height":840},{"X":1024,"Y":280,"width":3072,"height":840},{"X":1536,"Y":420,"width":3072,"height":840}],"sensitivity-radius":20}}],"templates":[{"type":"blank","show-spacing":false,"spacing":0,"zone-count":0,"sensitivity-radius":0},{"type":"focus","show-spacing":false,"spacing":0,"zone-count":3,"sensitivity-radius":20},{"type":"columns","show-spacing":true,"spacing":16,"zone-count":3,"sensitivity-radius":20},{"type":"rows","show-spacing":true,"spacing":16,"zone-count":3,"sensitivity-radius":20},{"type":"grid","show-spacing":true,"spacing":16,"zone-count":3,"sensitivity-radius":20},{"type":"priority-grid","show-spacing":true,"spacing":16,"zone-count":3,"sensitivity-radius":20}],"quick-layout-keys":[]}```

So with the upgrade, the newlines are dropped. Maybe this is causing some unintended side effects even though I doubt it but this is the best guess at the moment.


wants to redesign the contact section.

I want to make the contact section looked professional and want to redesign it.

please assign this task to me under lvl 2 gssoc 24-ext and hacktoberfest. @amitkumardemo @beRajeevKumar

@anannya-2032 ?

thanks for the assign but it seems somebody alread done it.


require new line after var declaration, var assignation

How to make this?
Valid:
var some;

awesomeMethod();

// or

var some = 1;

awesomeMethod();

Invalid:
var some;
awesomeMethod();

// or

var some = 1;
awesomeMethod();

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8112003-require-new-line-after-var-declaration-var-assignation?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

This doesn't exist yet, but would be called requirePaddingNewLinesAfterVariableDeclarations

Thanks for contributing the suggestion @bjrmatos

Awesome!! Thanks for your feedback.

Is this not the same result as require-padding-newline-after-variable-declaration ?

Seems like http://jscs.info/rule/requirePaddingNewLineAfterVariableDeclaration covers it although maybe there should be some more examples


create modules with factory pattern

when you register models you create an instance of them and when needed you clone them. why you not just create them when needed? you can save all of the formats in a factory class and when needed create an instance of them by using factory and their creator functions! suppose you have tens of models and each take memory so when you create them all it causes memory consumption.

My thought when I added that was so you can have different models based on the data in a class and not the class itself to allow for models to be created that aren't known at compile time.
However, the same effect could be made if the creators were stored in

In my application I've many blocks which for some blocks takes some time to be initialized. see here and here, using factory method to create objects when needed has several benefits, We don’t incur the overhead of construction unless we actually use the object, and our startup times can be faster as a result (initialization of all blocks may takes long time). so we must separate registration from object creation.

I just created a pull request that is related to this issue #135

Hi all (and especially @facontidavide).
Change #164, which is closely related to this issue, has caused my application to break.
I'd like to state that I'm definitely sympathetic with the design direction that that PR implies, and rather than any kind of retreat, I'd prefer nodeeditor to move further towards explicit factories.
I had menu entries that, when selected, opened an open file dialog so that the node contents could be populated from the data in a file. These were awkward to implement in the prototype-based clone approach which existed prior to #164 because I had to pretend that my factory was actually an instance of a node data model. This was silly because it really only provided a name and a clone method. The clone method, once a file was selected, would return a genuine instance of the class to instantiate in the flow scene. Nevertheless, the approach worked.
After #164, I can't logically distinguish between the factory method being called to query its name, or being called to add its objects to the scene. Neither can I can't use the static method option, because the set of factories in my application is itself populated from another registry.
Right now, I'm going to have to use a hacky workaround where I assume that operator() will be called exactly once to populate the menus. This is obviously brittle :'(
In the PR discussion for #164, the following design was proposed, but not adopted:
class NodeDataModelSpec {
public:
// Actually create the NodeDataModel
virtual std::unique_ptr create() const = 0;
// Other information about the specific kind of NodeDataModel
virtual QString name() const = 0;
// ...
};
That looks ideal. Would there be support for switching to such a design? If not, can anyone suggest how to support my use-case?
Thanks for any thoughts on this :)


Tor Blocked Counrty

In my Turkey Tor is blocked I can acces tor using tor browser with auto bridges. But how can I make this add-on work in this case ?

You can't, sorry.


Bank image on —full

🐛 Bug Report
If you have a bank background image and view your full bank it overlays. Here's an example.
Possible fix would be to only show original background / remove the custom one.

Also note this isn't my bank I saw someone else and reported it.

=b --wide --full


build(logger): reduce node_modules size

Description of your changes
As detailed in #419 the size of node_modules for logger was unnecessarily big, this PR removes the full lodash lib in favor of targeted lodash.x depenencies brigning down the node_modules size to 1.8M from 139M.
Detailed list of changes:

Removed lodash & @types/lodash
Added lodash.clonedeep, lodash.merge, and lodash.pickby & respective @types/lodash.xxx
Updated imports to use new deps
Updated calls for merge in main Logger class since it was using the lodash/fp version that swaps the argument order.
Swapped npm-shrinkwrap.json for packages-lock.json since it was the last utility to still use it.

How to verify this change

Checkout branch & run unit tests in logger to check that there are no regressions.
Run npm pack
Install the packed version in a clean project
Run du -sh * to measure node_moduels size

(see screenshot below for steps 3 & 4)

Related issues, RFCs
#419
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] The code coverage hasn't decreased
[x] New and existing unit tests pass locally and in Github Actions
[x] The PR title follows the conventional commit semantics

Breaking change checklist
N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

well done!!
On Thu, Jan 6, 2022, 21:37 Sara Gerion @.***> wrote:

@.**** approved this pull request.
From 139M to 1.8M! Can't wait to have this one released 🚀
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-typescript/pull/427#pullrequestreview-846046905,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJLIUOQ5CTPP367W5VY5JTUUX4SLANCNFSM5LNAEJ5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***
.com>

thanks @dreamorosi

Need to merge #440 before this can be merged, checks fail because of same linting issue.

Ready to be reviewed again, all checks passing now.


GL_BYPASS_UPDATE_HOOK is not set in 1.2.0

Hello,
I tried to setup the fix for Hook errors while pushing over HTTPS but it does not work.
I found a topic on redmine forum which explain the problem and the fix.
Regards.

This is not mandatory any more:

set correctly gitolite_lib_dir_path, or better implement #630
add GL_BINDIR to lib/grack/server.rb, #630 again, I made a dirty patch

diff --git a/lib/grack/server.rb b/lib/grack/server.rb
index eb8af96..163af91 100644
--- a/lib/grack/server.rb
+++ b/lib/grack/server.rb
@@ -153,6 +153,7 @@ module Grack
       def smart_http_args
         [
           'env',
+          "GL_BINDIR=gitolite/src",
           "GL_LIBDIR=#{RedmineGitHosting::Config.gitolite_lib_dir_path}",
           "GL_REPO=#{repository_object.gitolite_repository_name}",
           "GL_USER=#{@env['REMOTE_USER']}"

And everything is working fine:

push by SSH triggers the redmine_git_hosting hooks
push by HTTPs triggers the gitolite hooks (which was not the case before, at least with 0.6.3)


unused code?

I am not entirely sure what this line is doing
https://github.com/neurostatslab/tensortools/blob/9d1edd8267e404850b5a1472b8fff4eabb9f3a8e/tensortools/ensemble.py#L116
It looks like the output of the function is not saved?

The call to kruskal_align modifies the factors in place and permutes the order of the components. See:
https://github.com/neurostatslab/tensortools/blob/9d1edd8267e404850b5a1472b8fff4eabb9f3a8e/tensortools/diagnostics.py#L19

thanks, I understand now.
I had to reimplement this function to separate fitting from plotting. I am now running all my fitting job on a cluster and I needed to run many fitting jobs with high ranks.


log_device_placement not working in some cases

Hey guys, thank you for working on TensorFlow so hard!
I think I found a small bug, but it might be so that I just don't understand ConfigProto correctly.
So:
config = tf.ConfigProto(log_device_placement=True)
server = tf.train.Server.create_local_server()
with tf.Session(server.target, config=config):

outputs the device placement correctly, but
config = tf.ConfigProto(log_device_placement=True)
server = tf.train.Server.create_local_server(config=config)
with tf.Session(server.target):

doesn't (at all).
While this is not groundbreaking, just wanted to let you know.
Cheers, Kris

That indeed seems to be at least a discrepancy between the documentation of tf.train.Server and the behavior.
@suharshs : Mind taking a look? It seems that tf.Session(target) in Python ends up sending a CreateSession RPC with CreateSessionRequest.config based on the options provided the tf.Session constructor. This means that the default provided to tf.train.Server was ignored. Which might be okay? But perhaps something needs to be cleaned up (either we don't have a "default" for the server, or we use it?)
FYI @mrry

The docs for tf.train.Server say:
config: (Options.) A `tf.ConfigProto` that specifies default
        configuration options for all sessions that run on this server.

This doesn't seem to match the code in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/distributed_runtime/rpc/grpc_server_lib.cc
It looks like the ServerDef (which has the session_opts) passed in isn't even passed to the MasterSession, unless I am missing something.
We need to somehow merge the session_opts in ServerDef with the ones passed to MasterSession before creating it. I'll look into this.
Thanks @krisjobs !


Optimized tunable field multiplication using w-width windowed method

This is a PR planned to be sent to the main BitVM repo. Please review if the interface is intuitive enough to be integrated into the main branch.

Thanks for the review @storopoli. Made most of the changes you suggested.

@manishbista28, can you do a quick review of the correctness of the implementation?

Closing this, feel free to reopen.


Figure out how to publish alpha/beta releases to Docker Hub

It looks like all I need to do to ship an alpha version to Docker Hub is NOT point the latest tag at it after it goes live: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/publish.yml#L75-L77

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1319#issuecomment-849780481

I'm going to try pushing an alpha of https://github.com/simonw/datasette/releases/tag/0.57a0 using this workflow I built a few months ago: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/push_docker_tag.yml

https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated now shows this at the top: https://hub.docker.com/layers/datasetteproject/datasette/0.57a0/images/sha256-4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db?context=explore

That worked:
 % docker run -it datasetteproject/datasette:0.57a0
Unable to find image 'datasetteproject/datasette:0.57a0' locally
0.57a0: Pulling from datasetteproject/datasette
75646c2fb410: Pull complete
edf8b70d3cc4: Pull complete
229daa3ebd94: Pull complete
65d21ac50a56: Pull complete
e083ad7cc3ca: Pull complete
ed4de1431432: Pull complete
1da5e8b27cca: Pull complete
Digest: sha256:4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db
Status: Downloaded newer image for datasetteproject/datasette:0.57a0
INFO:     Started server process [1]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8001 (Press CTRL+C to quit)


Investigate and implement a way to do alerting for breaking hiscore changes

Since the OSRS hiscores has so many breaking changes, we should try to find a way to implement alerting in case there is a problem with the parsing of the hiscores.
Maybe extract the logic for parsing hiscores into a @osrs-tracker/hiscores package, so we can use it both in the front and backend, or just move it to the backend so the alerting will be safer.

Maybe just a validation in the backend when the hiscores are requested, so we can send an alert when it fails to parse. This would also work well with a hiscores pkg.

bump, just broke again...

Closed with https://github.com/osrs-tracker/osrs-tracker-aws/issues/5


Syntax error for multiple exception catch with OR ( | )

Hi.
IntelliSense marks this as a syntax error:
            try {
            } catch (AException | BException $e) {
            }

Thanks.

Just came here while struggling with that

with multi catch ,it is report error incorrectly

This is tracked in https://github.com/Microsoft/tolerant-php-parser/issues/103


util/cmd: Package for parsing = pairs.

Utility package for parsing <key>=<value> pairs among shell command arguments.

Good catch re: "NULL on failure."  I have fixed the comments.

Nice! I would just change package name as I feel util/cmd is too generic. You already have cmd_arg prefix for all APIs so what about util/cmdarg?

Thanks, all.  I have renamed the package to util/cmdarg.


Remove reference to ANSIBLE_INVENTORY

ANSIBLE_INVENTORY is set by the embedded ansible bootstrap script

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.