Grainy and false color image with ASI120MC

Hi, i have a strange issue with images taken by my ASI 120 MC. There are two types of bad images which appears totally random and also last for hours when appears. in some nights doesn't appears at all... I attach a photo with both issues. Anyone knows what could  be the problem and how to fix it?
Both cases disappear only if i reboot the PI and if i only restart the allsky service this problem doesn't disappear.

I've just started using Allsky, and I have the same camera. I had the same issue last night...all of a sudden about mid way through the night (based on the video), it suddenly changed to a blueish tint. And towards morning it got grainy, almost looks like it is looking through a screendoor.

Today this problem started earlier and i am sure now it is because of camera. I attach two images, image(taken by camera) and image-processed(by allsky software. as it can be seen the problem appears from the image delivered by camera. I am thinking to one solution to detect this issues in openCV and when is detected to reset the ASI camera. But as my programming skills is almost equal to zero, i must learn how to do this from zero. :)

Try using a Dark Subtraction file that is the same resolution and your pictures. So, for the ASI120MC camera, your highest resolution is 1280 X 960. I have attached a Dark file with that exact resolution.  Then copy that file to your /home/pi/allsky directory.  You then have to options. 1. rename the file to Dark.png or edit your config.sh setting to  DARK_FRAME = dark_1280_960.png.

--

Is this not the same as doing a dark frame within the GUI?
I get the same type of images on mine and I have done the dark frame capture within the GUI.
Brad

It is not because of dark file. I am using a good "dark.png" image without any problems. What you see in pictures is not related to dark images. Appears and disappears randomly even on the "image" taken from the camera before it was processed with the dark. It is some kind of blue "grid" with totally different hot pixels from the dark taken.

I forgot to mention, i am using three darks, taken at 10, 20 and 30 degrees darks changed when chip sensor exceed +/- 5 degrees around this temperature values. But it has nothing to do with dark changing. This problem appears totally random and is a camera issue(in my opinion).

Well last night I started getting the same issue. It started the run with the blue/red/green dots and went all night. Powering it done and playing with the camera settings did nothing to fix it. During the day when the gain and exposure is at 0 no problems. Tonight I am going to limit the exposure and see if that helps.

In this evening i have seen the camera with that blue image full of hot pixels. Quick, in this state i make a dark frame. I used this dark to substract the hot pixels in the "startrails" software with very good results. So, if i will catch a fireball on this bad state of the camera i have the posibility now to clean the image and see the stars, even if the image remain bluish.

I am still doing testing on mine I finding that the Dome is degrading my photos a lot.
Need a better dome then the one I got off of Amazon.
Some of my first runs without the dome looked very good. I have the dome off as of 6-2-20 it ran last night and has a lot less hot pixels. Tonight going to run at gain 100 and auto expos.\ no dome.
My photos are at www.dentonknifeworks.com

I have (fortunatelly) a glass dome. Acrilic ones, in time, become less transparent and will make the quality of images lower, but i think it is noting to do with hot pixels. The images will become a bit blurry, i think. The real problem might be the temperature of the sensor... i think. I am thinking to place a small fan to cool down the ASI camera. Now, because ambiental temperature raised, i have more frequently this problem with bluish image and hot pixels. I will check this...

After more testing I agree the dome is not producing the Hot pixels.
What I did lastnight was redid the dark photo. I found that just turning it on and waiting a min is not the way to do it. I set the camera settings no auto settings, cover the camera turn on the dark frame and watch the live view. I let it run for at least 5min I found as I watch it and the camera ramped up I could see the hot pixels in the live view. I then turned off dark frame and looked at the dark.jpg in the allsky folder As I save as "Jpg" and found the hot pixels. The one I had before did not show the hot pixels. The end video looks better now all be it still some hot pixels are still showing.
I have not figured out if the dark frame is only used during the stacking and nothing else.
I am going to pull the images and stack them with the dark frame and see what I get with DSS.
Them Galss domes are kinda $$ ............. as to Temp mine has been running around 40 to 50C and here in Texas its getting Hot now....

I have seen the same. When the blue image appears, also new hot pixels(a lot of them) are shown, This ones, does not fit the usual dark and you need a new dark for processing this. I think this is a hardware problem related with debayering process inside the camera. I am thinking to detect when this appears and reset the USB, because the problem dissapear only if power off/on the camera. Also, in the next days, i will relocate the fan which cool down the PI to cool simultaneously both, pi and the camera.

The problem I see with the dark frames is that they vary with the exposure length.
Some nights, my exposures are very short - could be only a few seconds (lots of clouds, moon is out and light pollution), and other nights which are much darker, (up to 30 seconds). The dark frames for 30 seconds and the dark frames for a few seconds are vastly different.
On top of that, the ASI120MC-S is not a cooled camera. The hot pixels at sensor temperatures of 30C vs 10C are very different. We can't really control the temperature variable, but unless the entire dark capture routine is re-written to create some kind of library (based on temperature and exposure length), and then some kind of 'smart' dark subtraction which uses the meta-data to pick the best dark frame, you basically have to take fresh darks whenever there is a big variation in either temp or exposure length.

Well at this point it looks to me that the ASI120MC-S in this texas heat is not good for Allsky.
My camera temps average 40c to 60c during the night and Hot pixels are real bad. Anything above 4 secs are at gain of 50 the image is full of hot pixels. Now what dont make sense to me is I can do a 30 Sec image with different software with the same camera on a telescope and dont have the hot pixels.

This is what I am getting every night now.

My current dark file

I've found the entire dark subtraction process with this software to be a bit of a hit & miss exercise.
I had worse looking subs than you.
I deleted my dark, and just went without, and it was vastly improved.
When I get some time, I want to try and write my own dark library modification routine (I have created an issue in this regard). I would just try and make your darks as close to the same duration and gain/temperature as your typical night (though with the camera being uncooled this is going to be very diffcult).

Ok so I renamed the dark.png and let it run last night no difference at all it like the dark file is not doing anything at all.

That sounds like a useful result. I don't think you have to restart the service, but did you try that?
If you did, then I would try and make a fresh dark, and see how that goes.
The code does the following when it makes a dark frame:
convert "$FULL_FILENAME" "$DARK_FRAME" -compose minus_src -composite -type TrueColor "$FILENAME-processed.$EXTENSION"
so you could try it at the command line with your current dark and a sample image and see what you get:
convert whatever.png dark.png -compose minus_src -composite -type TrueColor output.png
Make sure your config file specifies the dark name (it should be dark.png)

Looking at your dark, and the image, they looks like they are vastly different (ie maybe you did the dark when it was cooler?). Given the temperatures you're talking about (40+ degree sensor is pretty hot) - I can guarantee you're going to be way cooler hanging off the back of a telescope vs being in a box.
I suspect I'm going to have the same issues as you when I get to summer. I think the only options are to get a cooled camera, or to code up a temperature sensitive dark library.
I looked at this a little - there are two main issues. The code library being used does not store meta data in the image files (unlike a FITS file for example). So neither the exposure length, nor the sensor temperature are stored in the image files. This makes coming up with a routine a bit messy. I'm thinking that either there needs to be a routine to encode the information in to the filename (which causes other issues), or adding a library to embed metadata in to the images (like EXIF data), which could then be used to be able to dynamically apply an appropriately scaled dark.

I am using three darks. From the original "capture.cpp" i export in a text file the sensor temperature. Then, PHP read the value from the file and is changing the dark.png with one of three darks taken at 10, 20, 30 degree celsius +/- 5 degrees histeresis around these values. But as i said, that bluish and pixeled image does not match any of that darks which are all good and is vorking very well in allsky dark substraction when the camera is working normally. Didn't had time to make a code to detect that blue image and switch to that specific dark which is good in that condition.

I am thinking your on the right track on the Temp. I added a fan to the box today I will see if it runs cooler tonight. At looking at the frames taken looks like 40c to 50c on temps. If the fan dont work I will put the cam on the scope and see what temps it gets too and recheck the bad pixels on it.

Well the fan helped on the temp now runing at 30 - 33c.
New photos look a little better but the old tear to the right side is still a random issue.
I have yet to play with the darks yet thanks for the code I will play with them.
Here is the new hot pixels photo at lower temps.

@RobertG73 I have the exact same issue as you.
The colour of the image changes toward the blue during the middle of the night for no reason at all.
Hot pixels that were green become blue or red
Hot pixels that were red (very few) become green.
A host of new red hot pixels are suddenly created.

Got worse again last night. I'm now getting banding appear on the RHS of the image when it goes all blue, pixely and ignores the dark. Of no use like this.

And this morning's image:

For my past experience with the asi120.  It not a good fit for a raspberry pi.  Had nothing but issues with it.  Worked with vendor and now I upgraded it to a asi224.  Much better quality and works better.

Thanks.
However, I'm slow to invest in another camera for this project.
I have a spare DMK camera.
Anyone got that to work on the Pi for this project?

Unfortunately not, I’m having the same issues with my ASI120MC-S on a Pi 4 4 GB. The cam works fine on a second Pi 4 as a guiding camera with the INDI drivers.

I put my ASI120MC-S back on the telescope and works fine. So I went with a HQ pi Cam and used the converted code.
No more problems hot pixels or torn video. The HQ pi Cam is not as sensitive as the ASI but its not bad. I have seen some located in darker Skys then I have and there are picking up the milky way.
This is a frame from last night the green tent needs to be adjusted. There is one problem with the HQ pi cam and that the auto exposure don't work in the modified software. So each night I adjust it for the conditions at the time. This shot was 20 sec at max gain of the camera I was hoping to catch some meteors last-night.

This issue is from an older release of the AllSky software; the current release uses a dark library with dark files based on sensor temperature which improves dark subtraction.  Other issues above might be hardware related.
If you think this problem might still be relevant, please test it with the newest version and submit a new issue if needed.  Thanks


If remotely doesn't return a promise, error is ambiguous

It would be great if Marty could return a descriptive error message when remotely does not return a promise.   While this is bug not against Marty, the error makes it very difficult to track down.  For example.
    getComments: function (id) {
        return this.fetch({
            id: id,
            locally: function () {
                return this.state[id];
            },
            remotely: function () {
                return CommentAPI.getComments(id);
            }
        });
    },

And
var API = Marty.createStateSource({
    type: 'http',
    getComments: function (id) {
        Q($.get(`/comments/${id}`)).then((comments) => {
            return CommentSourceActions.receiveComments(caseNumber, comments)
        });
    }
});

module.exports = API;

Returns the following error which is very hard to track down:
 TypeError: Cannot read property 'defaultProps' of undefined
    at Object.ReactElement.createElement (https://foo.redhat.com/assets/main.js:32465:12)
    at Object.ReactElementValidator.createElement (https://foo.redhat.com/assets/main.js:32760:47)
    at Object.ReactLegacyElementFactory.wrapCreateElement.legacyCreateElement [as createElement] (https://foo.redhat.com/assets/main.js:34109:29)
    at Object.React.createClass.renderComments.state.comments.when.failed (https://foo.redhat.com/assets/main.js:82465:31)

Note that it was only when I realized the remotely was returning undefined did I realize I must not have returned the promise within the API portion, that fixed it.
There are other places where a small mistake takes quite a bit of time to trace where the error was due to the ambiguous error messages.
Loving this flux abstraction btw!

Great idea, fixed. Thanks!


Inline image link support

Currently the library does not support inline images
hey some text ![some image](http://i.huffpost.com/gen/1498584/images/o-KOALA-facebook.jpg) some more text

Part of the base markdown syntax: https://www.markdownguide.org/basic-syntax#images-1

Can be achieved with ImageSpans

Won't be adding support for this in new rewrite. Currently there is no easy way to achieve this in Jetpack Compose AFAIK


[uglify-js] Lock version to 2.8.9 to avoid breakage like #12772

As per uglify-js maintainer @kzc's comment in https://github.com/mishoo/UglifyJS2/issues/1573#issuecomment-284940371 we should be locking our version to prevent issues like #12772 from happening again.
No test plan needed, people are already using this version of uglify-js (it's the latest).

I'd suggest using<EMAIL_ADDRESS>until the 2.8.x bugs are shaken out.

cc @davidaurelio

👍  This not being hardcoded has now caused me pain twice! (Less pain the second time, thank god) TO THE TOP WITH YOU! 🚀


Fix active_size format conversion in get_db_info function

In active_size conversion in couch_db:get_db_info/1 old db reduction's size format assumed to be an integer representing active state, when it also could be a tuple of active and external sizes.
This handeled correctly, for example, in couch_db_updater.erl.
This patch addresses conversion of both possible formats to CouchDB size_info record.
This closes issue COUCHDB-2701

How it's possible to reproduce such case? Never saw any problem with sizes for db info.

@kxepal I can reproduce it by migrating a test database from DBCore to CouchDB 2.0, but I doubt it could be shown in migration from CouchDB 1.6.x to 2.0, as far as I can tell from a code, 1.6.x doesn't have a concept of external size and just uses integer in there. I can try though.

@eiri by migrate you mean simple copy-paste db file from 1.x to 2.0 database directory? And what's the different between DBCore and CouchDB 1.x?

@kxepal  I don't think simple copy would do, given the database file going to be named as a shard. I thought of something like creating test db for 1.x, creating empty db with same name in 2.x (probably as r,w,n,q = 1), then overwriting it with 1.x and running compaction. Tricky business, but should be doable.
DBCore and CouchDB 1.x are quite different, but DBCore and Couch 2.0 are essentially the same apart from active/external format. Couch 2.0 uses #active_size record for it and DBCore just a 2 elements tuple, hence the PR.

I was asking for where reduce = is populated for checking how the tuple gets into that place.

@hdiedrich : in couch_db_updater.erl
It's the same in DBCore's couch_db_updater:btree_by_id_reduce/2, except, but of course, for the record vs tuple discrepancy.

I mean the #btree's reduce field that is used in couch_btree.erl
full_reduce(#btree{root=nil,reduce=Reduce}) ->
   {ok, Reduce(reduce, [])};
full_reduce(#btree{root=Root}) ->
   {ok, element(2, Root)}.

and ultimately produces the tuple {AS, ES} at the heart of this PR, which could be in SizeInfo0, via
{ok, DbReduction} = couch_btree:full_reduce(IdBtree),
SizeInfo0 = element(3, DbReduction),

@hdiedrich Yes I understand the question and link in my previous answer is pointing to the code point. It's populated on couch_db_updater init and btree_by_id_reduce is the reducer.

I was wondering where it is being assigned to the reduce field, found it here, thanks! https://github.com/apache/couchdb-couch/blob/master/src/couch_db_updater.erl#L553, https://github.com/apache/couchdb-couch/blob/master/src/couch_btree.erl#L49

+1 after variable name changed for consistency.

@rnewson: I've made an another related update in couch_db_updater.erl. Can you please take a look?
@davisp: Can you please take a look at this PR if you have time? It does the changes that hard to verify without DBCore and I'd like to have another +1 before merging it.

+1

+1


Feature/526 template overrides

Add template content blocks for basic customization.
Fixes #526

Current coverage is 100% (diff: 100%)

Merging #531 into master will not change coverage

@@           master   #531   diff @@
====================================
  Files           3      3
  Lines          66     66
  Methods         0      0
  Messages        0      0
  Branches        6      6
====================================
  Hits           66     66
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 3dd6d32...358c061


Broken links in docs/test-writing.org

In the file 'test-writing.org' three links, specifically "Setting up Kubemacs with APISnoop" , "SQL Tips and Tricks"  and " Anatomy of our Go function" are broken. When trying to change them, the confusion is that they are not linked to any link in the .org file as shown in the screenshot below:

/assign @zachmandeville
Please see comment on broken links for doc/test-writing.org
I also APISnoop/test-writing.org have under the same file name other valuable information.  Please review the location and name.

/close
Fixed by PR: Fix broken link #349


feat(apps/prod/jenkins/release): bind image pull secret name to jenkins controller service account

/run-all-tests


Error Index current_edited_scene = -1 is out of bounds spammed into a console at editor startup

Godot version:
5d83b67b573546104aa2710344c392afaa225254
OS/device including version:
Windows 10
Issue description:
Every time I start a new project or open an existing one the following errors are spammed into the console:

Steps to reproduce:
Just create a new project or open an existing one and you will see it.
Minimal reproduction project:
Too easy to reproduce

I see this too on Linux, I think it was introduced recently (past 2-3 weeks I'd say).


Support dis.findlinestarts behaviour change in Python 3.13

Hi guys.
Many thanks for working on this project.
It's awesome to see a differnt approach on code coverage for Python.

I know that the main branch of slipcover does not yet supports Python 3.13
https://github.com/plasma-umass/slipcover/blob/e5c95367135153ed747115e8bd41d65fef8f59bf/setup.py#L103
This issuer report is in preparation for Python 3.13 support
dis.findlinestarts was updated in 3.13 to

Changed in version 3.13: Line numbers can be None for bytecode that does not map to source lines.

Just to get slipcover moving,
after applying the following diff, I was able to "run" it on my code.
This is not a working diff, it's more of a highlight of places where findlinestarts changes are affecting slipcover
diff --git a/setup.py b/setup.py
index bda8f7d..115bc05 100644
--- a/setup.py
+++ b/setup.py
@@ -100,7 +100,6 @@ setuptools.setup(
     packages=['slipcover'],
     package_dir={'': 'src'},
     ext_modules=([probe]),
-    python_requires=">=3.8,<3.13",
     install_requires=[
         "tabulate"
     ],
diff --git a/src/slipcover/slipcover.py b/src/slipcover/slipcover.py
index 4218916..714be1b 100644
--- a/src/slipcover/slipcover.py
+++ b/src/slipcover/slipcover.py
@@ -66,6 +66,8 @@ class Slipcover:

         if sys.version_info[0:2] >= (3,12):
             def handle_line(code, line):
+                if line is None:
+                    return
                 if br.is_branch(line):
                     self.newly_seen[code.co_filename].add(br.decode_branch(line))
                 elif line:
@@ -358,6 +360,9 @@ class Slipcover:

             files = dict()
             for f, f_code_lines in self.code_lines.items():
+
+                f_code_lines = {line for line in f_code_lines if line is not None}
+
                 if f in self.all_seen:
                     branches_seen = {x for x in self.all_seen[f] if isinstance(x, tuple)}
                     lines_seen = self.all_seen[f] - branches_seen

slipcover pytest run still fails with 39 failed, 29 passed, 2 skipped in 5.62s

No pressure.
I was just trying slipcover with 3.13 and since there wasn't any other report, I have reported my hack.
I think that the is_branch change is wrong. Instead, the fix should be in def handle_line(code, line): . I have updated  the diff.

For now, pytest fails
    def test():
>       assert list(r.contents('imported')) != []
E       AttributeError: module 'importlib.resources' has no attribute 'contents'

/tmp/pytest-of-adi/pytest-4/test_loader_supports_resources0/t.py:10: AttributeError

content of that file.
I am not familiar with pytest...so I don't know how that file is created.
If this is pytest or some 3rd party pluging for pytest

import sys
sys.path.append('tests')
from pathlib import Path

import importlib.resources as r
import imported

def test():
    assert list(r.contents('imported')) != []

Hi, thanks again for your report! I now made changes to support Python 3.13 (eb39499). Release coming soon...

Thanks a lot. Much appreciated. I don't know when I will have time to test this.
Slipcover is definetly on my radar as a way to reduce test durations.


Oracle SQL limit syntax is wrong

If I want that only x entries will be returned then I could use .limit(x) but for Oracle the syntax isn't correct.
Using OracleQuery and .limit(2) results in
'SELECT * FROM "table" LIMIT 2'
but that doesn't work in Oracle DB.
Correct would be:
'SELECT * FROM "table" WHERE ROWNUM <= 2'

Hi, would prefer to try to avoid translating the same queries to different dialects. What we could do is give a constant that you can use in place.  Something like Query...where(ROWNUM <= 2). This would match the oracle syntax better, as well. What do you think?

While I would be happy with any fix I feel like what is the sense behind OracleQuery if the methods don't adapt to the correct database syntax?

The goal of pypika is not to map a common syntax to multiple DB platforms, but rather to provide a syntax that wraps the SQL you would be writing without it.

Then where is the value added compared to just directly writing SQL?
Side note: We switched to ponyORM since it fully supports Oracle and also works in a really pythonic way.

This pseudocolumn is available her https://github.com/kayak/pypika/blob/master/pypika/pseudocolumns.py#L6
The following code snippet is an example of how it can be used.
from pypika.pseudocolumns import RowNum
OracleQuery
    ...
    .where(RowNum > limit)


API boosting via clang-tidy

To prevent regression from latest API version, we should regularly run the API booster. If we can transform it to be a standard clang-tidy plugin, we can make this part of the CI clang-tidy phase.

@htuch would like to understand more on requirements.

what API boosting used for in envoy ?

This issue is stale due to the move to freeze the major version at 3 permanently.


Delete post-install-check.yaml file and replace it with post-validati…

…on.yaml
Fixes #222

aos-ci-test

@cooktheryan fyi the failed test is all down to your infra, nothing to do with the change (just checked the logs)

Agree I dont believe it should be a blocker. I believe it was just a fluke
occurance
On Mon, Jan 23, 2017 at 1:53 PM, Dani Comnea<EMAIL_ADDRESS>wrote:

@cooktheryan https://github.com/cooktheryan fyi the failed test is all
down to your infra, nothing to do with the change (just checked the logs)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/pull/223#issuecomment-274581598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslGNhmqcGxBZVfbrs5fsZ6XBKiTeuks5rVPc8gaJpZM4LqtRh
.

@dav1x if you do not see any issues with this we can merge

LGTM!


SCC Results (Windows/Internet Explorer) not coming out in eChecklist

If you import the JOAB SCC results for Windows 10 and IE 11, and then recategorize and export the eChecklist, the Windows tab and Internet Explorer tabs are empty (Win 10) or have just one host populated (IE11).  I did the export after importing 20 hosts.  The other tabs are populated correctly.
I tried again with just one host, importing just Win10 and IE11.  Same result.  The eChecklist is attached.
Win_10_-_x64-eChecklist-1 (3).xlsx

Ok...looking in to this, but it looks like SCC changed such that they added a "Id" and "id" attributes to the  tag.  And...now the VMS ID is coming out "xccdf_mil.disa.stig_group_V-63319".  So if you look in your sagacity.golddisk table you should see entries where vms_id = 'xccdf_mil.disa.stig_'  Run the SQL command below to remove those.  I've updated the SCC parser to only grab the V-[\d] value.
DELETE FROM sagacity.golddisk WHERE vms_id LIKE 'xccdf%'

So this means we have two bugs.

When you add a new checklist to a host, and it adds the associated findings, it doesn't necessarily check to see if the PDIs are already associated.  (But it never mattered, because the other findings come first in the table and are used instead)

When you add the new checklists due to OS, you need to reload the exiting PDIs for that host so you can update them with the new findings.

The fix for commenting out the last Insert in post_processing worked when it added a checklist to the host, but it also uncovered a new bug, where the tool never updates - only adds new findings.  I've chased it back as far as database.inc's get_target().  Researching there.


Added android:exported tag for authenticator service

Thanks!! Did you make sure it works BTW?

It has gotten past throwing that error, and there aren't any issues showing up in the build with this plugin now. I haven't gotten through a full successful build due to issues with other file plugins and support libraries vs. AndroidX.


Hot reloading via react-transform/babel6 is not working when rendering a connected component from a non-connected component

I think this is an issue with how react-redux handles the hot reloading of connected components. If you have a non-connected (dumb) component render a connected component as a wrapper component, any content within that wrapper will no longer be re-rendered on change.
Connected component:
class Form extends Component {
  constructor(props) {
    super(props);
  }

  render() {
    return (
      <form>
        {this.props.children}
      </form>
    );
  }
}

export default connect(...)(Form);

Dumb component rendering connected component:
class LoginForm extends Component {
  constructor(props, context) {
    super(props, context);
  }

  render() {
    return (
      <Form id="loginForm">
        this is a test
      </Form>
    );
  }
}

Changing the text this is a test will not cause the component to re-render.  Replace <Form> with <div> and everything works as expected.  Replace connect()(Form) with just Form and everything works as expected.
Repository demonstrating issue is available at https://github.com/bunkat/counter.  It is the react-redux counter example with babel6 hot loading and a new connected wrapper component.
To reproduce the issue:

git clone https://github.com/bunkat/counter.git
cd counter
npm install
npm start
Open browser to http://localhost:3000
Edit components/Counter.js
Modify the render method, change Clicked to Not Clicked

The module will be updated via HMR, but the Counter component will not be rendered with the new text.

So this is a bug. In particular it is caused by us recomputing child props inside shouldComponentUpdate() which is not at all guaranteed to run (for example, it won't run if the connect wrapper if forceUpdate()d which is exactly what react-transform-hmr does). This was introduced in #99.
@epeli Can you look at this? Ideally we shouldn't care if shouldComponentUpdate() is called or not. We definitely shouldn't rely on React doing it before every render. Maybe we should move the calculations back into componentWillReceiveProps and handleChange and solve #99 in some other way.

Note: this shouldn't affect anything other than hot reloading because normally forceUpdate() can only be called by component itself, and this is where the bug is. However we can't rely on React always calling shouldComponentUpdate() in the future in all cases so we better fix this before this breaks any real cases.

Fixed in 4.0.3, thank you again very much for reporting.
It involved an important rewrite and the lib just got better. ;-)

Confirmed this works on my project as well.  Thanks for fixing this so quickly!


Added size condition to view

As discussed with @bchapuis, this is a fix for the tile generation with the zoom between 8 and 12.

The computation still need to account for the loss of resolution when the points are far from the equator.
In theory we should reduce the distance threshold by the distance to the equator.
I tried something with
st_area(st_envelope(geom)) > POWER(156412 / power(2, 3)*10*cos(ST_Y(ST_Centroid(ST_Transform(geom, 4326)))),2)

but the reduction was too steep. Maybe with a less liner curve (log, sqrt ?)


tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node swap_out_gradients

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes. Added some custom TF operators.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below):1.10.1
Python version:3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:9.2
GPU model and memory: GeForce GTX 970
Exact command to reproduce:python3 train/train.py --gpu 0 --model frustum_pointnets_v2 --log_dir train/log_v2 --num_point 1024 --max_epoch 201 --batch_size 24 --decay_step 800000 --decay_rate 0.5

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Getting an error that "No registered '_CopyFromGpuToHost' OpKernel". Not able to find the refernce to this OpKernel anywhere.
Source code / logs
pid: 16638
WARNING:tensorflow:From /home/rishi/sw/frustum-pointnets/models/pointnet_util.py:126: calling reduce_max (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
WARNING:tensorflow:From /home/rishi/sw/frustum-pointnets/models/pointnet_util.py:212: calling reduce_sum (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
WARNING:tensorflow:From /home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py:519: calling conv1d (from tensorflow.python.ops.nn_ops) with data_format=NHWC is deprecated and will be removed in a future version.
Instructions for updating:
NHWC for data_format is deprecated, use NWC instead
2018-09-06 19:00:38.848283: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2018-09-06 19:00:38.920714: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:897] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2018-09-06 19:00:38.921052: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1405] Found device 0 with properties:
name: GeForce GTX 970 major: 5 minor: 2 memoryClockRate(GHz): 1.1775
pciBusID: 0000:01:00.0
totalMemory: 3.94GiB freeMemory: 3.56GiB
2018-09-06 19:00:38.921067: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1484] Adding visible gpu devices: 0
2018-09-06 19:00:39.115930: I tensorflow/core/common_runtime/gpu/gpu_device.cc:965] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-09-06 19:00:39.115958: I tensorflow/core/common_runtime/gpu/gpu_device.cc:971]      0
2018-09-06 19:00:39.115967: I tensorflow/core/common_runtime/gpu/gpu_device.cc:984] 0:   N
2018-09-06 19:00:39.116154: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1097] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 3282 MB memory) -> physical GPU (device: 0, name: GeForce GTX 970, pci bus id: 0000:01:00.0, compute capability: 5.2)
**** EPOCH 000 ****
2018-09-06 19:00:42.022472
2018-09-06 19:00:42.305938: W tensorflow/core/framework/allocator.cc:108] Allocation of 50331648 exceeds 10% of system memory.
2018-09-06 19:00:42.322253: W tensorflow/core/framework/allocator.cc:108] Allocation of 50331648 exceeds 10% of system memory.
2018-09-06 19:00:42.337831: W tensorflow/core/framework/allocator.cc:108] Allocation of 100663296 exceeds 10% of system memory.
2018-09-06 19:00:42.368540: W tensorflow/core/framework/allocator.cc:108] Allocation of 100663296 exceeds 10% of system memory.
2018-09-06 19:00:42.401274: W tensorflow/core/framework/allocator.cc:108] Allocation of 50331648 exceeds 10% of system memory.
2018-09-06 19:00:52.106763: E tensorflow/core/common_runtime/executor.cc:697] Executor failed to create kernel. Not found: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[Node: swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/truediv_2/_91)]]

Traceback (most recent call last):
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1278, in _do_call
return fn(*args)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1263, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1350, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[Node: swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/truediv_2/_91)]]

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "train/train.py", line 376, in
train()
File "train/train.py", line 201, in train
train_one_epoch(sess, ops, train_writer)
File "train/train.py", line 256, in train_one_epoch
feed_dict=feed_dict)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 877, in run
run_metadata_ptr)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1100, in _run
feed_dict_tensor, options, run_metadata)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1272, in _do_run
run_metadata)
File "/home/rishi/.local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1291, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[Node: swap_out_gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2 = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@gradients/fa_layer3/ThreeInterpolate_grad/ThreeInterpolateGrad_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/truediv_2/_91)]]

I tried this with r1.11 also and issue is there with latest release also.

Nagging Assignee @tatianashp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Any update on this?

Can you please check that you still see this issue with r1.12?
/cc @rmlarsen @azaks2

Nagging Assignee @tatianashp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@tatianashp I tried this with r1.12 but I still see same issue. Please note that I am using CUDA 10.0 with r 1.12.
`2018-11-04 10:53:31.772782: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1511] Adding visible gpu devices: 0
2018-11-04 10:53:32.225588: I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-11-04 10:53:32.225607: I tensorflow/core/common_runtime/gpu/gpu_device.cc:988]      0
2018-11-04 10:53:32.225612: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 0:   N
2018-11-04 10:53:32.225778: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 3293 MB memory) -> physical GPU (device: 0, name: GeForce GTX 970, pci bus id: 0000:01:00.0, compute capability: 5.2)
**** EPOCH 000 ****
2018-11-04 10:53:34.929683
2018-11-04 10:53:35.282864: W tensorflow/core/framework/allocator.cc:122] Allocation of 100663296 exceeds 10% of system memory.
2018-11-04 10:53:35.314713: W tensorflow/core/framework/allocator.cc:122] Allocation of 100663296 exceeds 10% of system memory.
2018-11-04 10:53:35.524664: W tensorflow/core/framework/allocator.cc:122] Allocation of 100663296 exceeds 10% of system memory.
2018-11-04 10:53:35.556079: W tensorflow/core/framework/allocator.cc:122] Allocation of 100663296 exceeds 10% of system memory.
2018-11-04 10:53:35.586546: W tensorflow/core/framework/allocator.cc:122] Allocation of 100663296 exceeds 10% of system memory.
2018-11-04 10:53:43.540498: E tensorflow/core/common_runtime/executor.cc:623] Executor failed to create kernel. Not found: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node {{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[{{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/truediv_2/_91)]]

Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1334, in _do_call
return fn(*args)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1319, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1407, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node {{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[{{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/truediv_2/_91)]]

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "train/train.py", line 376, in
train()
File "train/train.py", line 201, in train
train_one_epoch(sess, ops, train_writer)
File "train/train.py", line 256, in train_one_epoch
feed_dict=feed_dict)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 929, in run
run_metadata_ptr)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1152, in _run
feed_dict_tensor, options, run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1328, in _do_run
run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1348, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node {{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHostT=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"
.  Registered:  device='GPU'
 [[{{node swap_out_fa_layer3/ThreeInterpolate_2}} = _CopyFromGpuToHost[T=DT_FLOAT, _class=["loc@fa_layer3/ThreeInterpolate_2"], _device="/job:localhost/replica:0/task:0/device:CPU:0"](fa_layer3/tr`

Nagging Assignee @tatianashp: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I have the same problem,  has anyone solved it?

batch size set small,and  try  again

it seems like:

reduce the batch_size
reduce some convs outputs to reduce the params.

Hi, I got the same error, TF 1.13, CUDA 10, Cudnn 7, Ubuntu 16.04, GeForce GTX 1050 Ti/PCIe/SSE2,
Deprecated in favor of operator or tf.math.divide.
2019-03-28 08:51:16.696019: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-03-28 08:51:16.880719: I tensorflow/compiler/xla/service/service.cc:150] XLA service 0x7674990 executing computations on platform CUDA. Devices:
2019-03-28 08:51:16.880745: I tensorflow/compiler/xla/service/service.cc:158]   StreamExecutor device (0): GeForce GTX 1050 Ti, Compute Capability 6.1
2019-03-28 08:51:16.911657: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-03-28 08:51:16.914697: I tensorflow/compiler/xla/service/service.cc:150] XLA service 0x76e0580 executing computations on platform Host. Devices:
2019-03-28 08:51:16.914727: I tensorflow/compiler/xla/service/service.cc:158]   StreamExecutor device (0): ,
2019-03-28 08:51:16.915057: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1433] Found device 0 with properties:
name: GeForce GTX 1050 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.4805
pciBusID: 0000:4e:00.0
totalMemory: 3.94GiB freeMemory: 2.30GiB
2019-03-28 08:51:16.915091: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1512] Adding visible gpu devices: 0
2019-03-28 08:51:16.917505: I tensorflow/core/common_runtime/gpu/gpu_device.cc:984] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-03-28 08:51:16.917522: I tensorflow/core/common_runtime/gpu/gpu_device.cc:990]      0
2019-03-28 08:51:16.917528: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1003] 0:   N
2019-03-28 08:51:16.917648: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 2054 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1050 Ti, pci bus id: 0000:4e:00.0, compute capability: 6.1)
**** EPOCH 000 ****
2019-03-28 08:51:19.152603
2019-03-28 08:51:19.897926: W tensorflow/core/framework/allocator.cc:124] Allocation of 268435456 exceeds 10% of system memory.
2019-03-28 08:51:20.070020: W tensorflow/core/framework/allocator.cc:124] Allocation of 268435456 exceeds 10% of system memory.
2019-03-28 08:51:20.148307: W tensorflow/core/framework/allocator.cc:124] Allocation of 268435456 exceeds 10% of system memory.
2019-03-28 08:51:20.214870: W tensorflow/core/framework/allocator.cc:124] Allocation of 268435456 exceeds 10% of system memory.
2019-03-28 08:51:20.283382: W tensorflow/core/framework/allocator.cc:124] Allocation of 268435456 exceeds 10% of system memory.
2019-03-28 08:51:26.414952: E tensorflow/core/common_runtime/executor.cc:624] Executor failed to create kernel. Not found: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node {{node swap_out_fa_layer3/ThreeInterpolate_2}}
.  Registered:  device='GPU'
 [[{{node swap_out_fa_layer3/ThreeInterpolate_2}}]]

Traceback (most recent call last):
File "train.py", line 322, in
train()
File "train.py", line 160, in train
train_one_epoch(sess, ops, train_writer)
File "train.py", line 205, in train_one_epoch
ops['train_op'], ops['loss'], ops['pred']], feed_dict=feed_dict)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 929, in run
run_metadata_ptr)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1152, in _run
feed_dict_tensor, options, run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1328, in _do_run
run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1348, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: No registered '_CopyFromGpuToHost' OpKernel for CPU devices compatible with node {{node swap_out_fa_layer3/ThreeInterpolate_2}}
.  Registered:  device='GPU'
 [[{{node swap_out_fa_layer3/ThreeInterpolate_2}}]]

My batch size is 1.. any resolution?

well, i think your 2054 MB memory of '1050 Ti is incapable for your project..

level up your GPU.
reduce your img's size.
reduce some net parts' output number.

Closing because this issue is quite old.  Please reopen if you're still running into the same problem.

I have the same problem, has anyone solved it?

sorry do you have solved it?

have you solved it? maybe I need your help.


list functions should allow inverse filtering on tags

az group list --tag key=value is nice, but I'd like to filter inversely.
Specifically, I want to write a script that allows me to cleanup all resources in a resource group that contain colemick and lack a colemick-permanent=true tag.
I wasn't sure if there's a way to do this today...

@colemickens you should be able to use the --query functionality to accomplish this.

(Let me know if you'd prefer a different issue for this, but) I can't get it to work like I might've expected.
This has no output:
az group list -o json --query '[?tags.colemickpermanent == `true`].name'
Yet, if I feed it the same input data on the JMESPath website, I get output.
az group list -o json

[
  {
    "id": "/subscriptions/[redacted]/resourceGroups/colemick-acs-linuxdev",
    "location": "westus2",
    "managedBy": null,
    "name": "colemick-acs-linuxdev",
    "properties": {
      "provisioningState": "Succeeded"
    },
    "tags": {
      "colemickpermanent": "true"
    }
  }
]

Result from http://jmespath.org/ with [?tags.colemickpermanent == 'true'].name in the path box:
[
  "colemick-acs-linuxdev"
]

As always, minutes after posting... this works: az group list -o json --query "[?tags.colemickpermanent == 'true'].name

In case anyone is curious, this is what I came up with for a cleanup function using az and tags: https://github.com/colemickens/dotfiles/commit/d8146e950c1bf39fbc54be40fae98c5ede300b26


fix: avoid "Argument list is too large" on building via nix.

The buildLeanPackage uses environment variable to store a list of libraries,
then passes that variable to the lean as CLI arguments.
According to this (https://stackoverflow.com/a/28865503), CLI arguments and environment variables share same space, therefore there is an error "Argument list is too large" when building a package with too many components.
(for example - mathlib4)
This change makes buildLeanPackage to use a file instead of environment variable to store a list of libraries.

[X] Put an X in this bracket to confirm you have read the
External Contribution Guidelines.

Please put the link to your RFC or bug issue here.
PRs missing this link will be marked as missing RFC.
Didn't created an issue, because patch is trivial.

The Nix integration has been deprecated


Repository instantiation failed error after branch deletion

steps to reproduce:
given
branch layout with an entry and its local branch
when
delete the corresponding branch
then

expected TBD
actual error popup

TBD, but I think we should never block the UI with a alert like that in case a branch a missing

This is possibly a different issue but somewhat related.
Appears on ba277eca62e16c84abb61335ed3a7cddfb006c53.
Sometimes slide-out causes the very same error popup.
It looks like the write to branch layout file finishes after repository reinstantiation.

The case described above has been covered by #405.
I will verify other cases when the popup could appear

This is possibly a different issue but somewhat related.
Appears on ba277eca62e16c84abb61335ed3a7cddfb006c53.
Sometimes slide-out causes the very same error popup.
It looks like the write to branch layout file finishes after repository reinstantiation.

This was caused by async execution of branch deletion & repository update.
Fixed on #443


🚀 [New Feature_LP] -SignUP page

Description of the enhancement. ✍🏻
I would like to add the signup page for the website .
So , please assign this to me under GSSOC'23.
Describe briefly how you would implement this enhancement.
...

Screenshots Example (if applicable)
No response
Additional information
No response
Contributor terms

[X] I agree to follow the Contributing Instructions

Is this custom comment is proper ?

What custom comment @AmanJain18?

~What custom comment @AmanJain18?~
Oh yea, looks good, thinking of what to include... 😊

Sure, Let me know, what more we can add to that. ✌🏻☺

Can you please assign me this issue under GSSOC'23?


Zygisk detection and ASI not being installed

I got the new update and I have magisk v24 but the module doesn't seem to detect that I have zygisk on and I can't even install android system intelligence because the option to install it isn't there. Finally, I have a 720p device (Nokia 3.2) but it keeps says that my screen is 1080p

Fixed in 2.01


GLM compiler issues

The following issues were carried forward from PR #95:

The output of values that are default is not always suppressed. This is most often due to values for which the defaults are not set in the class template.

None of the transforms are output (so filters won't come through).

Schedules are suppressed even when they are defined by the user because there's no way to tell the difference between an internal schedule and a user schedule.

A round robin of models/ieee123 does not give the same result.

A sample of the output for model/ieee123 is attached for reviewer consideration.

Not all the classes have been converted to use the new "X_init()" form of property initialization.

@aivanova5, please review and update this list to remove things that now work ok.


Use monochrome symbol for directory tree

Before

After
(default)

(dark)

Testing done
Only checking visual
Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I don't mind approving this if necessary, but I must admit that the new image looks worse than the original one to me. The original one is very clearly a folder with subfolders. I'm not sure what the second image represents. It looks more like the pins of a microprocessor to me and it is not obviously a folder/subfolders at all.

I will try to do an other proposal

Does it look more like subdirectories now ?


Vite not serving the PHP file in routes other than /

Hi,
first of all, many thanks for your work!
I have run across a small issue while using the plugin for a Vue app. I have been able to install and run it without issue, and the index.php file is correctly served when opening the application root.
If you then navigate to a different route (eg. /login) it works fine, as long as the navigation is handled internally by the Vue router.
However, if you directly open a different route (eg. /login), or just press F5 to reload the page, the PHP file is not served. Vite returns either the contents of index.html (if present) or an empty page (otherwise).
Would it be possible to have the plugin serve index.php regardless of the entry route while in development?

Hi @andvaranaut,
thanks for for your submission.
I am glad the plugin works as expected and found it's userbase 😁
Looking forward to grow it into something even bigger and attract even more users.
Such a router is actually already in the works and should be ready somewhere by the end of the week.

Hi @donnikitos,
that's great to hear! As a workaround, I have just used a static index.html as a fallback. And, of course, it works flawlessly in production as long as you redirect all requests to index.php (instead of index.html) - just like in any other app.
If I may make a suggestion, and as long as it's feasible, it would be great if you could mock $_SERVER['REQUEST_URI'] also :-) (In my use case, I'm using the plugin to change the OpenGraph tags served depending on the route).

mock $_SERVER['REQUEST_URI']
I think that is actually a pretty good suggestion, considering the routing would be taken over.

@andvaranaut check out the rewriteUrl property, that should help with fixing the routing issue ;)
PS: I would be really glad about a star on the repo 😃

Hi @donnikitos
You have my star! :)
I have made a few tests and it seems to work perfectly in my use case :) Thanks!
If it is any help, I have found that returning undefined in any route that includes a dot or a colon (ie. changing the condition in your example to if (['.', ':'].some((s) => requestUrl.pathname.includes(s)))) is enough to make it work. As long as you don't have routes with any of these characters (or assets without them) it should work fine. :) (The dot filters out any request for a file with an extension, and the colon must be used because of what seem to be some of the Vite hot reload requests).

Awesome!

some of the Vite hot reload requests

I actually tried to exclude those automatically, do you maybe know exactly which ones those are?


[Bug] When opacity is specified in bar chart the border is rendered internally

Version
5.4.3
Link to Minimal Reproduction
https://codepen.io/blackat/pen/KKExXxd
Steps to Reproduce
I have just add the following code to your example
color: '#37A3EB',
opacity: 0.5,
borderColor: '#37A3E',
borderWidth: 20

Try to remove and add the opacity, with opacity the border is rendered internally rather than externally.
Current Behavior
The border is rednered internally and not around the column.
Expected Behavior
The border should be rendered around the column.
Environment
- OS: Mac Osx
- Browser: Chrome
- Framework: Angular 17.1.1

Any additional comments?
No response

the border is rendered internally rather than externally

Yes, bar border is rendered 'internally'(inside the bar) so that bar width remains constant. It seems this is by design and not related to opacity.
OTOH opacity is applied to both bar and its border. Demo Code
📌 please close issue if problem solved.

Hello,
thanks a lot for you answer, the issue is that the border get opacity applied as well reducing the contrast with the bar color.
Finally to obtain the effect I wanted I have used the rgba gradient as color of the bar, in this way without opacity the border is visible as it should.


Expanded Hive Testing

These tests validate the Hive JDBC driver and have fleshed out usage to include complex, generated SQL and meta-data testing.

Hi @bharatm363 can you create a JIRA on BIGTOP and describe what feature you'd like to add?

Sure @evans-ye, how can I go about doing that on https://issues.apache.org/jira/projects/BIGTOP/issues

@evans-ye I have created an issue on JIRA for this testing, https://issues.apache.org/jira/browse/BIGTOP-3049, please let me know if that is correct.

Thanks for the comments, I'll look into these, I'm going to refactor it some to make everything more readable and address some of the points you raised above. @evans-ye

Sure. Just want to let you know that it doesn't mean that everything I comment need to be addressed. If you think I'm wrong, reply with your thought.

@bharatm363 can we have this in 1.3?

@evans-ye Uploading some changes now, the main thing that I didn't directly address were the sql calls which are still performed in a large group. I thought that would be better as they all test the same kind of behavior without major differences between each one.

@evans-ye In terms of squashing I'm not sure I have the access to do so since the pull request is in the apache repo. Would you be able to squash the commits in this pull request?

@bharatm363 sorry to answer back late. I was on a week long vacation ;)
I know there's a squash button in Github, however since github is just only a mirror of Bigtop codebase, we don't use it more than reviewing the code.
Usually I'll just rebase my folked branch which creates the PR. Afterwards the changes shall be reflected.


Make long image annotation label titles wrap properly

Changes style settings so long annotation label titles no longer overflow outside of the popover, but wrap to the next line instead.
Closes #177

I prefer the shorter dialog, so that means the max-content rather than the min-content.


console.log pollutes stdout

console.log seems to be directed to stdout by default:
in a JSON function :
const fdk = require('@fnproject/fdk')

fdk.handle(function (input, ctx) {
	console.log("Running function")
	return "OK"
})

causes a JSON parse error in fn:
{"error":{"message":"invalid json response from function err: invalid character 'R' looking for beginning of value"}}

console is assignable so fix is to replace it with a monkey-patched version that sends logs to stderr only .

Or like other languages we should tell people to use console.error(). Trying to think whether all the FDK's should redirect stdout to stderr like you're suggesting.... ???

Yeah I think they should (if they can!)
Java does redirect stdout -> stderr  for the same reason (so System.out.printf(..) goes to the function log rather than polluting the call contract)
Thinking that bugs caused by (e.g) an accidental systemout.print  are going to be very difficult to debug as you'll just see a random Fn error relating to invalid protocols somwhere.

There are a number of frameworks that could be used.  I had tried a few but didn't invest enough time to determine if anyone of them was ideal.  Most seem to be focused on unit testing but one might work for us.


Implement mediaconnect

Implement add_flow_sources and update_flow_source.

Hi @bblommers , done merging the latest master and pushing it to my branch.


Remove the baseline from aggregate-report

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
No baseline for js. Remove the baseline from yaml
Fixed the failed pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1433901&view=results
Testing pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1436935&view=results
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

/check-enforcer override


scrcpy nix pkg on darwin crops the viewport, making scrcpy unusable

Describe the bug
scrcpy installed via nixpkgs shows screen of phone cropped (I would say 50% of clear estate is cropped). As soon as I replaced this version with the one from homebrew, problem is gone. It's scrcpy 2.0 version in both cases.
Steps To Reproduce
Steps to reproduce the behavior:
nix run nixpkgs#scrcpy
Expected behavior
Full screen of phone should be visible.
Screenshots

Notify maintainers
@DeltaEvo @lukeadams @msfjarvis
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.4.0, macOS 13.3.1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixpkgs"`
 - channels(gostrolucky): `"darwin, home-manager"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

I'm aware that the issue exists but I don't really have an answer why it happens. If I'll have time later in the week I'll try to poke around and see if I can find something.


Export eslint config for use in other client apps

Follow the pattern established the /config directory, from which we currently export the TailwindCSS config.
The design-system config itself is designed for typescript, so this will be a two-part project.

[x] Create an eslint-config directory and create a sub-package @pdap-design-system/eslint-config.
[x] Export the base config from this package. This will bundle the config as a part of the package, for use in other projects.
[x] In the root directory, update eslintrc.json -> eslintrc.cjs and extend the base config from @pdap-design-system/eslint-config.
[ ] Update the README to ensure ease of use.

Hi @joshuagraber, I believe that I can help with this issue. Would you mind assigning me to it?

Hi @joshuagraber. Your code looks good! A few clarification questions:

Did you end up updating the eslintrc.json to eslintrc.js? I don't see this change in your current PR; am I missing something?

When I update the README, do you want me to assume / include that you have in fact published the the config package to npm?

Any assistance would be helpful!

Hey, @Kenny4297 thank you for the clarifying questions here.

Yes, but eslint was complaining that it wasn't able to import it via dynamic require (perhaps they went cjs-only in version 8? I haven't had the chance to look into it), so I renamed to eslintrc.cjs to allow for the commonjs methods that eslint is expecting. The file is here. I've updated the issue description to match.

Yes, please! in eslint-config/package.json, you'll see that the "name" value is "@pdap-design-system/eslint-config. This will be extendable using the same string, once published (and we will publish before we merge this PR). So, TLDR: yes.

And then, if you are interested in picking up any other issues, this one is related and may be a good next step.


Obsidian hanged when sharing a page

Hi,
I'm testing the plugin, but I had trouble sharing some pages.
With simple text, it seems there is no problem; however, some of them hang obsidian, and I have to kill the process.
Test.md
I'm attaching a note that hangs samepage

Sorry for the issues and thanks for sharing! We're currently looking to secure funding, but once we do, I'd consider this a p0 bug that we'll prioritize.
From my initial investigation, it appears the parser is considering far too many possibilities (~1.5M states) as opposed to being an infinite loop. There are probably obvious optimizations here that we're missing to prune 99.99% percent of those


[improve][admin,broker] Add option to unloadNamespaceBundle with bundle Affinity broker url

Motivation
To provide an option for admin to unload namespace bundle with broker url to which the bundle has to be assigned to after the unload.
Modifications

Add an option to provide brokerWebServiceAddress (Ex: https://broker1.com:4443) while unloadingNamespaceBundle in the admin CLI and make corresponding changes in the pulsar-client-admin-api to support this.

Changes in pulsar-broker unloadNamespaceBundle API to accommodate  broker url while unloading.

Add functionality in LoadManger implementation to select affinity broker for a bundle while trying to assign unloaded bundle to broker.

Verifying this change
This change added tests and can be verified as follows:

Added end to end test to make sure the bundle assignment happens as per the expectation

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[x] The REST endpoints
[x] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[ ] doc-not-needed
[x] doc-complete

Matching PR in forked repository
PR in forked repository:

@vineeth1995 Thanks for the contribution.
The new feature should start with a proposal https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md
So that we can understand the motivation for the API change.

Codecov Report

Merging #18663 (39a9810) into master (cee697b) will decrease coverage by 9.96%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18663      +/-   ##
============================================
- Coverage     47.06%   37.10%   -9.97%
+ Complexity     8956     1969    -6987
============================================
  Files           592      209     -383
  Lines         56313    14420   -41893
  Branches       5844     1573    -4271
============================================
- Hits          26503     5350   -21153
+ Misses        26946     8483   -18463
+ Partials       2864      587    -2277

Flag
Coverage Δ

unittests
37.10% <ø> (-9.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...g/apache/pulsar/client/impl/ConnectionHandler.java
50.00% <0.00%> (-5.32%)
:arrow_down:

...pache/pulsar/broker/admin/impl/NamespacesBase.java

.../org/apache/pulsar/broker/admin/v1/Namespaces.java

.../org/apache/pulsar/broker/admin/v2/Namespaces.java

.../apache/pulsar/broker/loadbalance/LoadManager.java

.../pulsar/broker/loadbalance/ModularLoadManager.java

...che/pulsar/broker/loadbalance/NoopLoadManager.java

...roker/loadbalance/impl/ModularLoadManagerImpl.java

...er/loadbalance/impl/ModularLoadManagerWrapper.java

...broker/loadbalance/impl/SimpleLoadManagerImpl.java

... and 376 more

@codelipenghui I don't think this will require PIP as it's part of adding a flag in admin API. There are a large number of PRs which must have gone through PIP with similar changes but merge without any explanation. let me give you few examples
https://github.com/apache/pulsar/pull/16167
https://github.com/apache/pulsar/pull/14680
https://github.com/apache/pulsar/pull/12136
https://github.com/apache/pulsar/pull/13938
also PR which breaks backward compatibility https://github.com/apache/pulsar/pull/10601 was merged without any concerns.
I have many such examples where I see practice by the specific community to discourage people from their contribution and delay their efforts. I would strongly discourage such destructive practices.
There are such bad practices going on in the community and I have many examples. Please let us know if you have any concerns with the PR by adding an option flag if not then you should not BLOCK the PR unnecessarily as it will start -ve and destructive practice in the community and we didn't open source Pulsar for such things.

@codelipenghui I know there were multiple genuine PRs were blocked in past and they were sitting unmerged for a long time for multiple releases. I can clearly see the intention but we should avoid such destructive practice instead we should spend time in constructive efforts as not every contributor is vendor but users/companies are trying to contribute for their business usecases and such practice discourages companies to use Pulsar.

@codelipenghui can you please unblock the PR?

@codelipenghui ping

this PR is blocked for last 3 days and I haven't heard anything from @codelipenghui . can we unblock the PR or dismiss the review? we can't keep following up on the same thing again and again.

@codelipenghui I don't think this will require PIP as it's part of adding a flag in admin API. There are a large number of PRs which must have gone through PIP with similar changes but merge without any explanation. let me give you few examples
https://github.com/apache/pulsar/pull/16167
https://github.com/apache/pulsar/pull/14680
https://github.com/apache/pulsar/pull/12136
https://github.com/apache/pulsar/pull/13938

also PR which breaks backward compatibility https://github.com/apache/pulsar/pull/10601 was merged without any concerns.
I have many such examples where I see practice by the specific community to discourage people from their contribution and delay their efforts. I would strongly discourage such destructive practices.
There are such bad practices going on in the community and I have many examples. Please let us know if you have any concerns with the PR by adding an option flag if not then you should not BLOCK the PR unnecessarily as it will start -ve and destructive practice in the community and we didn't open source Pulsar for such things.

Sorry for the late response.
Yes, this is why I think it's better to have a proposal to avoid we will not introduce any API changes without a proposal in the future. I agree there are many changes to admin APIs without proposals/discussions. But we are on the wrong way, right? More and more people are starting to use Pulsar. We should be more careful about the API changes than ever.
I want to say there have been many CLI, and admin API changes without proposals before. If you just don't think we should not start with this PR(proposal required). It's ok for me. I think I should start a discussion under the mailing list first, not block this PR under an uncleared rule. I see all the PRs you provided are from StreamNative's engineers.  Please don't think I mean to facilitate StreamNative engineers.
Here is an example of a proposal that is not required for new metrics.
https://github.com/apache/pulsar/issues/18319
https://github.com/apache/pulsar/issues/18560

And I don't see the bundleBrokerAffinityMap will be persistent somewhere. The bundle affinity will disappear after the broker restarts?

Yes, that's the purpose. we don't want persistent mapping it's useful when you want to debug by moving bundle temporarily to the specific broker. We already have namespace isolation policy for persistent affinity.

IMO, it should be 2 parts.

No, it's connected to each other where you want to unload bundle by setting specific broker affinity for temporary testing and you don't want to keep it persistent. Here, the main idea is to keep it non-persistent for quick testing, which is the main motivation to help users in debugging.

Sorry, I have to give a request changes here.

Let me know if you have any more concern so, we can remove the hold.

@eolivelli I addressed your comments.

@eolivelli can you remove the blocker?

Lgtm
Please rebase.
We moved the website to another repository, can you please send the docs update to the website repository please? @tisonkun maybe can help

Conflict resolved in https://github.com/apache/pulsar/pull/18663/commits/6f94be4e56f0b0b34ac95af0d0bac4dda2551bf8
Counterpart in the site repo in https://github.com/apache/pulsar-site/pull/353

Since this is the first case, I made it a demo to be referred to later. Hopefully, we don't have new cases, but we only need to clear the backlog.

Merging...


README.md title graphic doesn't jibe with GH Dark Modes

Exhibit A (theme is "Dark dimmed"):

Exhibit B (theme is "Default dark"):

Do the source of these live on GitHub?

Stale.


Placing signs with NBT prompts for text.

Placing signs with NBT (acquirable with ctrl + middle click) prompts the user for text and provides a blank sign.
On single player vanilla/forge this results in the sign being placed, with no prompt, with the text of the original sign as expected.

I noticed this bug myself. I believe it has something to do with forge's fix for hacks involving manipulated sign data. I don't know if this is how vanilla 1.8.6 handles the same thing but if not someone needs to override forge to restore the vanilla behavior and replace it with vanilla's fix instead of a broken one.

I'd think fixing forge might be the better move

On Jun 4, 2015, at 7:32 AM, Starbuck Johnson<EMAIL_ADDRESS>wrote:
I noticed this bug myself. I believe it has something to do with forge's fix for hacks involving manipulated sign data. I don't know if this is how vanilla 1.8.6 handles the same thing but if not someone needs to override forge to restore the vanilla behavior and replace it with vanilla's fix instead of a broken one.
—
Reply to this email directly or view it on GitHub.

I can confirm this is a forge bug. Tested with vanilla 1.8.7 works as expected, Forge <IP_ADDRESS>0 will prompt for sign text when placing. I'll see what I can do about getting a PR to forge.

I already wrote and submitted one. Waiting for a response still.

@modwizcode I'm not seeing any PR to forge that addresses this issue. Sure you have a PR for this?

Oops thought this was the leaf issue. My apologies. The sign text one I
thought might be a challenge since forge intentionally broke it for safety.

Ok, found out why Joe's server works as expected, Joe's server runs SpongeVanilla not sponge.

Should be fixed now if you use Forge <IP_ADDRESS>7. I suppose this Sponge issue is only really 'fixed' when the forge dependency is bumped.

Can thisbe closed now that Forge has been bumped? 067d1bc167c82b2b214bb97af887a3dfc543a1e2


WIP: GDS CLI upgrade to urfave.v2 and profiles

Codecov Report

Merging #148 (f03dd35) into main (a70954b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   38.90%   38.90%
=======================================
  Files          30       30
  Lines        3339     3339
=======================================
  Hits         1299     1299
  Misses       1822     1822
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70954b...f03dd35. Read the comment docs.


Generate fake data for feed (bug 1131903)

This should generate the same sort of data as the feed support in https://github.com/mozilla/marketplace-api-mock/

I glanced briefly, looks fine. I think someone like @ngokevin should look since he's more familiar with feed models.

It would be cool if we could share some modules from Marketplace API Mock, but I guess the intention is to get rid of the API Mock. Although the code looks a bit cleaner in the API Mock.
Anyhow, looks fine. Looks like you followed https://github.com/mozilla/marketplace-api-mock/blob/master/factory/feed.py#L217 pretty well.


Bump ethcontract to 0.15.0

Test Plan
CI

Codecov Report

Merging #987 (612be7c) into main (541c192) will decrease coverage by 0.04%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
- Coverage   65.62%   65.58%   -0.05%
==========================================
  Files         121      121
  Lines       22412    22428      +16
==========================================
+ Hits        14708    14709       +1
- Misses       7704     7719      +15


[HOLD #11768] [$250] Report detail page is opened and closed immediately after login while trying to open that deeplink url reported by @0xmiroslav

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to any account
Go to report detail page
Copy url link
Logout
Visit copied url link
Login to same account

Expected Result:
Report detail page should keep open
Actual Result:
Report detail page is opened and closed immediately
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.23-7
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/199752503-924df49e-ab59-4455-93d8-cb7c1c3fdb05.mov
https://user-images.githubusercontent.com/43996225/199752547-f1fa3c65-230a-4337-a5ff-3ecd3d5100ad.mp4
Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667406681481269
View all open jobs on GitHub

Hm I'm not sure entering the URL should work when completely signed out. If you sent me that link, for example, I shouldn't be able to login/view the details without first entering your username / password.

Closing unless someone can help me understand this issue better.

@0xmiroslav I see what you're saying now. I misread your reproduction steps in slack, as if they implied you should be able to access the page in (5) before logging in.
Thanks for explaining further, that's all I was asking for. FYI everyone on our team knows what a deeplink is 😉 .

https://www.upwork.com/jobs/~0157c3b18be3398b9d

For when it comes time to do the RCA checklist, @aimane-chnaif brought up that this was likely caused by this PR.

it gets on Navigation.dismissModal() in withReportOrNavigateHome, which does navigateBackToRootDrawer and doesn't enter any ifs

I will review the proposal in few hours.

Reviewing now.

@NikkiWines this is one of the oldest issues in the /App repo. To help us clear out the large backlog of bugs, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is
For any that can't, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #bug-zero

@mollfpr, thanks for your proposal. It looks pretty good for the deep linking flow, but there're some anomalies in the UI as it loads the view. It looks like it cycles through a few options for the name of the workspace and the name of the room before loading correctly.
For the account doesn't have access flow, it seems like we still end up showing the `ReportSettingsPage1 very briefly.
I'll look into this issue further tomorrow.

Chatted with @puneetlath, since this issue is only a week only we're going to continue moving forward through the normal external process. @mollfpr please see my comments in this PR on your current proposal 🙇

It looks like it cycles through a few options for the name of the workspace and the name of the room before loading correctly.

Could be related to https://github.com/Expensify/App/issues/12629

For the account doesn't have access flow, it seems like we still end up showing the ReportSettingsPage very briefly.

Any suggestion for this part?

I am trying to figure out why the settings page is opened after login. It should take the user directly to the home screen.

@aimane-chnaif Interested to take this on. I am not getting time for this. Unassigning...

Just noting here, this might be similar cause in terms of react-navigation state so we might want to consider holding this for react-navigation project and apply workarounds if this persists. Similarly to this https://github.com/Expensify/App/issues/12717

Added this issue to the main tracking issue https://github.com/Expensify/App/issues/11768

I think we should revert this PR instead of build on it further. I've explained in detail here why the HOC solution is most likely not the one we want and have concerns that we are just adding complexity to a design that should be investigated and potentially rolled back.

Hm, ok Melv. So is the approach @marcaaron  revert the PR, re-test to see if this issue exists, and if not close it out?

Assigning myself to this issue as part of the larger navigation reboot and also putting this issue on hold.

Just double checking on this @marcaaron . So we need to revert https://github.com/Expensify/App/pull/12089 (@mollfpr ), then see if this issue still exists?

@kevinksullivan That's my understanding, yes.
@Beamanator Are you able to follow up on the plan we discussed here?

Yep yep didn't have time the last few days but planning on that follow-up for early next week 👍

Still working on the revert of #12089 as well as the larger react navigation initiative.

No longer on hold for #12089 but still on hold for navigation re-write.

Still on hold for the navigation revamp.

Switched out weekly for monthly given that the navigation project is large in scope and has no clear ETA.

Still on hold for navigation. We're going to be stuck here for some time to come.

Same same.

Still on hold I believe!

Still on hold.

offer sent @0xmiroslav
https://www.upwork.com/jobs/~01f027dd8b9450b032

FYI I am going OOO a few days so this payment may be delayed.

Hi, I am here to help you, this issue a deeplinking issue. And I think some props are missing to pass and receive which will need to be fixed. I am also going to submit proposal on upwork for this job.
If you are satisfy with my answer, then please submit my proposal, and we will sort it out within 3 business days

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~019c8de8fba62a664d

Got around to the payment! Should be all set here.


Tabs with different widths

hi,
Is there a posibility to have the tabs be the width of the text (with optional padding)?
as you can see here:
http://codepen.io/anon/pen/bdmeOO
All the tabs always have the same width, even when setting the col to differnt sizes

yeah, i think add a string cut in js should be good, or maybe have a overflow: hidden,
to protect the text in tabs too long

Yeah, I also thing I would rather have the text cut out somehow (overflow hidden is the easiest fix, js cutting the string and adding an elipsis would be the most readable), than to have unmatched tab widths.

+1

:+1:

You guys are saying you'd rather have tabs forced to be the same width with ellipses at the end of longer names than have variable widths on the tabs?  That viewpoint seems strange to me.
It's easy to create a good-looking set of tabs in HTML/CSS with variable widths.  The only problem seems to be the indicator.  It assumes tabs are the same width.  It doesn't seem to be overly difficult to match the position and width of each tab while making no assumptions about how wide each is.
Are the issues you have with variable widths from an implementation viewpoint?  Or do you have UX concerns?

I'm with you arfordweb. I like the way this works:
http://codepen.io/krabbypattified/pen/oYzrmB

There is now support for fixed width and variable width tabs.


Add Sona Creds to repo secrets for GH actions

Happy to do so myself if shared with me on passpack, or for you to add it @chuwy .

Have been added now. Closing (nothing to go in the PR so no point waiting for release)


Rounding up (or down) on partial cents?

First off, I really like this Gem, it looks exactly like what we need. Thanks for all the work.
I'm trying to understand the best way to use Money for calculating amounts of money involving partial cents. For example, for a certain fee calculation, I need to always round up calculations if there is a fraction of cents. For example, if the fee is 2.2% on $1, I need to the result to always be $0.03. When I run Money.new(1, 'usd') * 0.022 though, I get the result of $0.02. I assume the gem has to handle this use-case so what is the correct way to handle this?

Hi 👋  it sounds like you'd want the equivalent of:
currency = Money::Currency.find('usd')
amount = (BigDecimal(1) * 0.022).round(currency.minor_units, :up)
Money.new(amount, currency)
=> #<Money value:0.03 currency:USD>

We could expose the rounding option as an argument for the Money initializer and pass that along when we create a BigDecimal (see all modes here), so you'd get something like:
Money.new(BigDecimal(1) * 0.022, 'usd', round: :up)

WDYT?


Add November 2022 Updates

Added DocumentFormat.OpenXml.Office.SpreadSheetML.Y2022.PivotRichData namespace
Added DocumentFormat.OpenXml.Office.PowerPoint.Y2019.Main.Command namespace
Added DocumentFormat.OpenXml.Office.PowerPoint.Y2022.Main.Command namespace
Added Child RichDataPivotCacheGuid to DocumentFormat.OpenXml.Office2010.Excel.PivotCacheDefinition
Fixed .NET Core Remote Code Execution Vulnerability (#1222)

@mikeebowen merge changes from main. Make sure to remove the files marked as not in sync:
generated/DocumentFormat.OpenXml.Features/Microsoft.Interop.JavaScript.JSImportGenerator/Microsoft.Interop.JavaScript.JSExportGenerator/JSExports.g.cs

and similar

You'll also want to rerun the build locally to get some updates to the changed generated files

@mikeebowen any thing preventing this from merging at this point?

@twsouthwick it should be ok to merge. We discussed this morning and I was thinking we wanted review of the PR by external contributors but it's not necessary, they can review a draft release with all the changes for 2.19.

You'll want to merge from main and rebuild to get some updated changes to the part generation I've merged in


resolves #376 add adoc as a valid file ext for AsciiDoc

resolves #376

Fair enough. @dometto?

I'm for it! 👍

Thanks folks! :+1:


Module 10 no trust Self-Signed Certificate

For some students the self-signed certificate dialog doesn't appear and the webpage doesn't display anything.
Exercise 3:
Task 2: Verify that the Management web application requires a sign-in by using an organizational account
1. In the Solution Explorer pane, right-click the Contoso.Events.Management project, and then click Set as Startup Project.
On the Debug menu, click Start Debugging.
a. The Microsoft Visual Studio dialog will appear indicating that you can configure IIS Express to trust the self-signed certificate.
b. Click Yes.
c. The Security Warning dialog will appear indicating that the self-signed certificate cannot be verified but can still be installed.
d. Click Yes.

I get an error page right away.
"Make sure the web address https://localhost:44319 is correct"
Lab dies here.

What is RC4 Cipher? Not supported in IE 11 or Edge anymore????

@denschork I was not able to find the text:

"Make sure the web address https://localhost:44319 is correct"

in the Module 10 lab files. Can you give me a specific step number so I can work on resolving this as quickly as possible?

Task 2. Verify the management web app requires a sign-in by organizational account.....
step:

Set the startup project. DONE
Start Debugging.
a. Studio dialog will appear indicating... IT DOES NOT
b. ..
c. Security warning dialog will appear.... IT DOES NOT APPEAR

When START DEBUG it shows error page
MAKE SURE THE WEB ADDRESS https://localhost:44319 is correct
Lab dies right there.

@denschork This helps a lot! I will begin investigating this and issue a correction for those instructions.
Estimated response is 2-3 business days as there are a few of us offsite at a MCT related summit.

If you use the http://localhost:XXXX url instead manually typing it in, the correct prompts come up. You can go through the AD login. BUT you still end up with the same error page at the end. Details recommend enabling TLS/SSL 1.0, 1.1, 2.0.
ending url is the https://localhost:xxxx

What is RC4 Cipher? Not supported in IE 11 or Edge anymore????

RC4 is an older encryption algorithm that has been used by Transport Layer Security and Secure Sockets Layer. It is now thought to be insecure, so it is being phased out. You are right that it has been disabled in IE 11 and Edge: https://blogs.windows.com/msedgedev/2016/08/09/rc4-now-deprecated/ .
You might need to regenerate the certificate so the site works with newer browsers.

I am getting the same error, as we are deploying the VM with pre installed versions of Browsers/SDKs/VS do we need to go and explicitly update anything to overcome this error?

This: https://forums.iis.net/t/1230477.aspx?Windows+10+Pro+Visual+Studio+Enterprise+2015+fails+on+IIS+Express+using+HTTPS+SSL+web
suggests repairing IIS Express, which might upgrade it to a newer version.

@ConcreteGannet  Thanks a lot, error got resolved after repairing IIS Express

Good news.
Could you add that step to the lab instructions?

Solution:

Close Internet Explorer if you face "Make sure the web address https://localhost:44319 is correct"
Error and Minimize Visual Studio.

Press Windows + R, Type Control Panel and Press Enter.

In Search Control Panel, type Program Features and Reference and Click on it.

Locate IIS Express 10.0, right-click on it and click on Repair.

Continue your execution from Task 3.

I had the same issue while on the course, ramsamdam's steps above rectified it.

I'm actively looking at this individual lab and started working on rewriting it so that we can avoid re-installing IIS.

From: NerdOwls<EMAIL_ADDRESS>Sent: Tuesday, November 29, 2016 2:45:22 AM
To: MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions
Cc: Sidney Andrews; Comment
Subject: Re: [MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions] Module 10 no trust Self-Signed Certificate (#147)
I had the same issue while on the course, ramsamdam's steps above rectified it.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions/issues/147#issuecomment-263499283, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE1SiXC-Shs72-zPdn8SuZbSfT-aQTOCks5rC9gSgaJpZM4KP05I.

Thanks again. Repairing IIS works perfectly for he lab as written.


WIP: Fix data race (Repository.Units)

For https://github.com/go-gitea/gitea/issues/8205#issuecomment-532057682, https://github.com/go-gitea/gitea/issues/8205#issuecomment-532057573, https://github.com/go-gitea/gitea/issues/8205#issuecomment-532056715.

These race may be caused by permission's Units. I think a simple method is to change []*RepoUnit to []RepoUnit but not change more.
// Permission contains all the permissions related variables to a repository for a user
type Permission struct {
	AccessMode AccessMode
	Units      []*RepoUnit
	UnitsMode  map[UnitType]AccessMode
}

@lunny As I understand, the races are due to the concurrent access to the slice header (the ptr, len, and cap fields), besides the backing array. I am afraid that changing the type of slice element would not help. Maybe I am wrong, though.
It would be better if this can be solved by an architectural change that avoids sharing the data in any way. But I don't have a clear picture of how to do it.

Or we could copy the slices only but not change the slice element type. Permission's Unit is a reference of Repo.Units that has been changed by some other goroutines. I think that's the problem.

Another way is to fix the upper-level code by avoiding sharing the objects in the first place. One implementation I tried is to deep-copy the Issue objects before we forward them into different handlers. Unfortunately, the objects contain cycles, so I cannot use a library routine to accomplish that automatically.
I think there is a chance that we can pass the objects through the channels by value, not by pointers, to avoid sharing the memory.

Please resolve conflicts

@lunny I think this PR is not good. It touches too much code but does not address it fundamentally. We have to decide whether we want to make the model layer thread-safe (which is a big endeavor) or we take care of the concurrency problem at the upper layers (like passing the objects by values instead of pointers).