Apply gradle-versions-plugin to dependencyManagement project instead …

…of manually aggregating all dependencies.
Now that we do dependency management using Gradle, gradle-versions-plugin can be applied to our dependency management itself rather than aggregating dependencies across projects. This simplifies the configuration a little.
Example report

BUILD FAILED in 2s
[16:47] (dependency-management-updates●) Anuraag:~/git/armeria % ./gradlew :dependencyManagement:dependencyUpdates
Configuration on demand is an incubating feature.

> Task :dependencyManagement:dependencyUpdates

------------------------------------------------------------
:dependencyManagement Project Dependency Updates (report to plain text file)
------------------------------------------------------------

The following dependencies are using the latest release version:
 - cglib:cglib:3.3.0
 - ch.qos.logback:logback-classic:1.2.3
 - com.github.jengelman.gradle.plugins:shadow:5.2.0
 - com.google.code.findbugs:jsr305:3.0.2
 - com.google.guava:failureaccess:1.0.1
 - com.google.j2objc:j2objc-annotations:1.3
 - com.salesforce.servicelibs:reactor-grpc:1.0.0
 - com.salesforce.servicelibs:reactor-grpc-stub:1.0.0
 - com.spotify:completable-futures:0.3.2
 - com.spotify:futures-extra:4.2.2
 - gradle.plugin.net.davidecavestro:gradle-jxr-plugin:0.2.1
 - it.unimi.dsi:fastutil:8.3.0
 - javax.inject:javax.inject:1
 - javax.validation:validation-api:2.0.1.Final
 - junit:junit:4.13
 - kr.motd.gradle:sphinx-gradle-plugin:2.6.1
 - log4j:log4j:1.2.17
 - me.champeau.gradle:jmh-gradle-plugin:0.5.0
 - net.javacrumbs.future-converter:future-converter-rxjava2-java8:1.2.0
 - net.shibboleth.utilities:java-support:7.5.0
 - org.apache.curator:curator-recipes:4.2.0
 - org.apache.thrift:libthrift:0.13.0
 - org.apache.zookeeper:zookeeper:3.5.6
 - org.bouncycastle:bcprov-jdk15on:1.64
 - org.checkerframework:checker-compat-qual:2.5.5
 - org.curioswitch.curiostack:protobuf-jackson:1.0.0
 - org.dmonix.junit:zookeeper-junit:1.2
 - org.eclipse.jetty.alpn:alpn-api:1.1.3.v20160715
 - org.hamcrest:hamcrest:2.2
 - org.hamcrest:hamcrest-library:2.2
 - org.jetbrains.kotlin:kotlin-allopen:1.3.61
 - org.jlleitschuh.gradle:ktlint-gradle:9.1.1
 - org.jsoup:jsoup:1.12.1
 - org.junit:junit-bom:5.6.0
 - org.mortbay.jetty.alpn:jetty-alpn-agent:2.0.9
 - org.opensaml:opensaml-core:3.4.3
 - org.opensaml:opensaml-messaging-api:3.4.3
 - org.opensaml:opensaml-messaging-impl:3.4.3
 - org.opensaml:opensaml-saml-api:3.4.3
 - org.opensaml:opensaml-saml-impl:3.4.3
 - org.opensaml:opensaml-soap-api:3.4.3
 - org.opensaml:opensaml-soap-impl:3.4.3
 - org.reactivestreams:reactive-streams:1.0.3
 - org.reactivestreams:reactive-streams-tck:1.0.3
 - pl.project13.scala:sbt-jmh-extras:0.3.7

The following dependencies have later release versions:
 - com.auth0:java-jwt [3.8.3 -> 3.9.0]
     https://github.com/auth0/java-jwt
 - com.fasterxml.jackson:jackson-bom [2.10.1 -> <IP_ADDRESS>00130]
     https://github.com/FasterXML/jackson-bom
 - com.github.ben-manes.caffeine:caffeine [2.8.0 -> 2.8.1]
     https://github.com/ben-manes/caffeine
 - com.github.node-gradle:gradle-node-plugin [2.2.0 -> 2.2.1]
 - com.google.api:gax-grpc [1.51.0 -> 1.53.1]
     https://github.com/googleapis/gax-java
 - com.google.dagger:dagger [2.25.4 -> 2.26]
     https://github.com/google/dagger
 - com.google.dagger:dagger-compiler [2.25.4 -> 2.26]
     https://github.com/google/dagger
 - com.google.dagger:dagger-producers [2.25.4 -> 2.26]
     https://github.com/google/dagger
 - com.google.guava:guava [28.1-jre -> 28.2-jre]
     https://github.com/google/guava
 - com.google.guava:guava-testlib [28.1-jre -> 28.2-jre]
     https://github.com/google/guava
 - com.google.protobuf:protobuf-gradle-plugin [0.8.10 -> 0.8.11]
     https://github.com/google/protobuf-gradle-plugin
 - com.google.protobuf:protobuf-java [3.10.0 -> 3.11.3]
     https://developers.google.com/protocol-buffers/
 - com.google.protobuf:protobuf-java-util [3.10.0 -> 3.11.3]
     https://developers.google.com/protocol-buffers/
 - com.google.protobuf:protoc [3.10.1 -> 3.11.3]
     https://developers.google.com/protocol-buffers/
 - com.puppycrawl.tools:checkstyle [8.28 -> 8.29]
     https://checkstyle.org/
 - com.squareup.retrofit2:converter-jackson [2.6.2 -> 2.7.1]
     https://github.com/square/retrofit/
 - com.squareup.retrofit2:retrofit [2.6.2 -> 2.7.1]
     https://github.com/square/retrofit/
 - io.dropwizard:dropwizard-core [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-jackson [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-jersey [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-jetty [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-lifecycle [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-testing [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-util [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard:dropwizard-validation [1.3.17 -> 2.0.1]
     ${dropwizard.url}
 - io.dropwizard.metrics:metrics-bom [4.1.1 -> 4.1.2]
     https://metrics.dropwizard.io
 - io.grpc:grpc-bom [1.25.0 -> 1.27.0]
     https://github.com/grpc/grpc-java
 - io.micrometer:micrometer-bom [1.3.2 -> 1.3.3]
     https://github.com/micrometer-metrics/micrometer
 - io.netty:netty-bom [4.1.43.Final -> 4.1.45.Final]
     https://netty.io/
 - io.netty:netty-tcnative-boringssl-static [2.0.26.Final -> 2.0.28.Final]
     https://github.com/netty/netty-tcnative/
 - io.projectreactor:reactor-core [3.3.1.RELEASE -> 3.3.2.RELEASE]
     https://github.com/reactor/reactor-core
 - io.projectreactor:reactor-test [3.3.1.RELEASE -> 3.3.2.RELEASE]
     https://github.com/reactor/reactor-core
 - io.projectreactor.kotlin:reactor-kotlin-extensions [1.0.1.RELEASE -> 1.0.2.RELEASE]
     https://github.com/reactor/reactor-kotlin-extensions
 - io.prometheus:simpleclient_common [0.8.0 -> 0.8.1]
     http://github.com/prometheus/client_java
 - io.reactivex.rxjava2:rxjava [2.2.15 -> 2.2.17]
     https://github.com/ReactiveX/RxJava
 - io.zipkin.brave:brave-bom [5.9.1 -> 5.9.3]
     https://github.com/openzipkin/brave
 - net.javacrumbs.json-unit:json-unit [2.11.1 -> 2.13.0]
     https://github.com/lukas-krecan/JsonUnit
 - net.javacrumbs.json-unit:json-unit-fluent [2.11.1 -> 2.13.0]
     https://github.com/lukas-krecan/JsonUnit
 - net.sf.proguard:proguard-gradle [6.2.0 -> 6.3.0beta1]
     https://www.guardsquare.com/proguard
 - org.apache.hbase:hbase-shaded-client [1.2.6 -> 2.2.3]
     https://hbase.apache.org
 - org.apache.httpcomponents:httpclient [4.5.10 -> 4.5.11]
     http://hc.apache.org/httpcomponents-client
 - org.apache.kafka:kafka-clients [1.1.1 -> 2.4.0]
     https://kafka.apache.org
 - org.apache.tomcat.embed:tomcat-embed-core [9.0.29 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-el [9.0.29 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-jasper [9.0.29 -> 9.0.30]
     https://tomcat.apache.org/
 - org.assertj:assertj-core [3.14.0 -> 3.15.0]
     http://assertj.org
 - org.awaitility:awaitility [4.0.1 -> 4.0.2]
     http://awaitility.org
 - org.eclipse.jetty:jetty-bom [9.4.24.v20191120 -> 9.4.26.v20200117]
     http://www.eclipse.org/jetty
 - org.hibernate.validator:hibernate-validator [6.1.0.Final -> 6.1.2.Final]
     http://hibernate.org/validator
 - org.jctools:jctools-core [2.1.2 -> 3.0.0]
     https://github.com/JCTools
 - org.jetbrains.kotlinx:kotlinx-coroutines-core [1.3.3 -> 1.3.3-1.3.70-eap-42]
     https://github.com/Kotlin/kotlinx.coroutines
 - org.jetbrains.kotlinx:kotlinx-coroutines-jdk8 [1.3.3 -> 1.3.3-1.3.70-eap-42]
     https://github.com/Kotlin/kotlinx.coroutines
 - org.jetbrains.kotlinx:kotlinx-coroutines-rx2 [1.3.3 -> 1.3.3-1.3.70-eap-42]
     https://github.com/Kotlin/kotlinx.coroutines
 - org.mockito:mockito-core [3.2.0 -> 3.2.4]
     https://github.com/mockito/mockito
 - org.mockito:mockito-junit-jupiter [3.2.0 -> 3.2.4]
     https://github.com/mockito/mockito
 - org.openjdk.jmh:jmh-core [1.22 -> 1.23]

        http://openjdk.java.net/projects/code-tools/jmh/

 - org.openjdk.jmh:jmh-generator-annprocess [1.22 -> 1.23]

        http://openjdk.java.net/projects/code-tools/jmh/

 - org.reflections:reflections [0.9.11 -> 0.9.12]
     http://github.com/ronmamo/reflections
 - org.slf4j:jcl-over-slf4j [1.7.29 -> 1.7.30]
     http://www.slf4j.org
 - org.slf4j:jul-to-slf4j [1.7.29 -> 1.7.30]
     http://www.slf4j.org
 - org.slf4j:log4j-over-slf4j [1.7.29 -> 1.7.30]
     http://www.slf4j.org
 - org.slf4j:slf4j-api [1.7.29 -> 1.7.30]
     http://www.slf4j.org
 - org.slf4j:slf4j-simple [1.7.29 -> 1.7.30]
     http://www.slf4j.org
 - org.springframework.boot:spring-boot-actuator-autoconfigure [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-actuator-autoconfigure
 - org.springframework.boot:spring-boot-configuration-processor [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-tools/spring-boot-configuration-processor
 - org.springframework.boot:spring-boot-gradle-plugin [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-tools/spring-boot-gradle-plugin
 - org.springframework.boot:spring-boot-starter [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-starters/spring-boot-starter
 - org.springframework.boot:spring-boot-starter-actuator [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-starters/spring-boot-starter-actuator
 - org.springframework.boot:spring-boot-starter-test [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-starters/spring-boot-starter-test
 - org.springframework.boot:spring-boot-starter-web [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-starters/spring-boot-starter-web
 - org.springframework.boot:spring-boot-starter-webflux [2.2.1.RELEASE -> 2.2.4.RELEASE]
     https://projects.spring.io/spring-boot/#/spring-boot-parent/spring-boot-starters/spring-boot-starter-webflux
 - org.testng:testng [7.0.0 -> 7.1.1]
     https://testng.org
 - xml-apis:xml-apis [1.4.01 -> 2.0.2]

Failed to determine the latest version for the following dependencies (use --info for details):
 - jakarta.annotation:jakarta.annotation-api

Gradle release-candidate updates:
 - Gradle: [6.0.1 -> 6.1.1 -> 6.2-rc-1]

Generated report file C:\tools\msys64\home\Anuraag\git\armeria\dependencyManagement\build\dependencyUpdates\report.txt

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 18s
1 actionable task: 1 executed

What happens to the dependencies we specified in build.gradle, such as Tomcat 8.5 and Spring Boot 2.1 (and 1.5 although it's EOL'd)?

Yeah that's a good point, forgot that we do use unmanaged dependency versions too and want updates.
But I tried on an old version before any gradle script updates and don't see it working there either, it always shows the latest version anyways. Do we need to worry about them in that case?
 - org.apache.tomcat.embed:tomcat-embed-core [8.5.49 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-core [9.0.29 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-el [8.5.49 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-el [9.0.29 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-jasper [8.5.49 -> 9.0.30]
     https://tomcat.apache.org/
 - org.apache.tomcat.embed:tomcat-embed-jasper [9.0.29 -> 9.0.30]

They at least gave us nudge telling to check manually :laughing:

Got it - let me add some nudging at least

Thanks, @anuraaga

Thank you!

Added nudges, something like this prints at the bottom

Generated report file C:\tools\msys64\home\Anuraag\git\armeria\dependencyManagement\build\dependencyUpdates\report.txt
Don't forget to check the following for updates to legacy version downgrades
libthrift is currently version 0.12.0
https://search.maven.org/search?q=g:org.apache.thrift%20a:libthrift%20v:0.12.*

libthrift is currently version 0.9.3-1
https://search.maven.org/search?q=g:org.apache.thrift%20a:libthrift%20v:0.9.*

tomcat-embed-core is currently version 8.5.49
https://search.maven.org/search?q=g:org.apache.tomcat.embed%20a:tomcat-embed-core%20v:8.5.*

tomcat-embed-jasper is currently version 8.5.49
https://search.maven.org/search?q=g:org.apache.tomcat.embed%20a:tomcat-embed-jasper%20v:8.5.*

tomcat-embed-el is currently version 8.5.49
https://search.maven.org/search?q=g:org.apache.tomcat.embed%20a:tomcat-embed-el%20v:8.5.*

spring-boot-starter is currently version 1.5.22.RELEASE
https://search.maven.org/search?q=g:org.springframework.boot%20a:spring-boot-starter%20v:1.5.*

spring-boot-starter-test is currently version 1.5.22.RELEASE
https://search.maven.org/search?q=g:org.springframework.boot%20a:spring-boot-starter-test%20v:1.5.*

spring-boot-starter is currently version 2.1.10.RELEASE
https://search.maven.org/search?q=g:org.springframework.boot%20a:spring-boot-starter%20v:2.1.*

spring-boot-starter-web is currently version 2.1.10.RELEASE
https://search.maven.org/search?q=g:org.springframework.boot%20a:spring-boot-starter-web%20v:2.1.*

spring-boot-starter-test is currently version 2.1.10.RELEASE
https://search.maven.org/search?q=g:org.springframework.boot%20a:spring-boot-starter-test%20v:2.1.*


Allow creating a GitHub Discussion for a GitHub Release

TL;DR
The gh CLI allows to easily create a discussion when creating a release. That would be nice to have in release-please-action as well.
Detailed design
Add a setting gh-discussion-category that triggers the same behaviour as gh release create --discussion-category $CAT.
Additional information
See here for the documentation for --discussion-category:

https://cli.github.com/manual/gh_release_create

Thanks for this, but this is outside the scope of what we want release-please to do (it's not a common thing that most releases use). Because this is available as a GitHub action and it provides outputs, developers can chain together events to do this with external tools.


[New Port Request]

Library name: mmg
Library description: mmg is open-source software for bidimensional and tridimensional surface and volume remeshing.
Source repository URL:  https://github.com/MmgTools/mmg
Project homepage (if different from the source repository): https://www.mmgtools.org/
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Empty folders created

After creating xlsx in destination folder, there is created some random numbered folders.
Like  "1220132", there shod be option to remove them automatically.

I have this issue too, anytime when I run my script, it creates new empty folder

me too. solutions or options ?


Fixes batch isClosed check

Fixes #512
A bad flags check was causing batches to not be sized correctly (also making the final send() callback drop outside of the batch). This fixes that.
Performance seems unchanged. If anything, maybe a tiny bit faster.

LGTM 👍

We have registered too many constants without version checks. I'm gonna clean that stuff up. Bear with me please.


shopping cart/checkout page

this should be a standard looking checkout page with pricing, summary, thumbnail, etc (more to come)

Fantastic work Justin


HADOOP-19334. Remove usage of sun.misc.Unsafe

Description of PR
JIRA: HADOOP-19334. Remove usage of sun.misc.Unsafe
Fix compilation errors during the upgrade process, because sun.misc is not supported after jdk11.
We can replace sun.misc.Unsafe.
How was this patch tested?
exist ut test
For code changes:
replace sun.misc.Unsafe

changes:

Rewrite the method NativeIO.getOperatingSystemPageSize by calling the os command line.
FastByteComparisons
Drop UnsafeAtomicHelper in AbstractFuture.java
Replace related operations of sun.misc.Unsafe with AtomicLong such as unsafe.putLongVolatile(), unsafe.getLongVolatile() and unsafe.compareAndSwapLong.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 51s

trunk passed

+1 :green_heart:
compile
19m 36s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 58s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
4m 50s

trunk passed

+1 :green_heart:
mvnsite
4m 34s

trunk passed

+1 :green_heart:
javadoc
3m 44s

trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m 45s

trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
8m 59s

trunk passed

+1 :green_heart:
shadedclient
44m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
18m 58s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
18m 58s

root-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 generated 0 new + 15 unchanged - 20 fixed = 15 total (was 35)

+1 :green_heart:
compile
18m 42s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
18m 42s

root-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga generated 0 new + 24 unchanged - 20 fixed = 24 total (was 44)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 50s
/results-checkstyle-root.txt
root: The patch generated 5 new + 133 unchanged - 5 fixed = 138 total (was 138)

+1 :green_heart:
mvnsite
4m 33s

the patch passed

+1 :green_heart:
javadoc
3m 36s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m 44s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

-1 :x:
spotbugs
2m 50s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
43m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
20m 18s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
2m 49s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch passed.

-1 :x:
unit
266m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 15s

The patch does not generate ASF License warnings.

579m 47s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Found reliance on default encoding in org.apache.hadoop.io.nativeio.NativeIO.getOperatingSystemPageSize():in org.apache.hadoop.io.nativeio.NativeIO.getOperatingSystemPageSize(): new java.io.InputStreamReader(InputStream)  At NativeIO.java:[line 902]

Failed junit tests
hadoop.io.file.tfile.TestTFileSeek

hadoop.util.TestIndexedSort

hadoop.hdfs.shortcircuit.TestShortCircuitShm

hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles

hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation

hadoop.hdfs.shortcircuit.TestShortCircuitCache

hadoop.fs.TestEnhancedByteBufferAccess

hadoop.hdfs.TestParallelShortCircuitReadNoChecksum

hadoop.hdfs.TestParallelShortCircuitRead

hadoop.hdfs.TestDFSInputStream

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithShortCircuitRead

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.client.impl.TestBlockReaderFactory

hadoop.hdfs.TestParallelShortCircuitReadUnCached

hadoop.hdfs.client.impl.TestBlockReaderLocal

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7156/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7156

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f1de6a998ac6 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1f942eee962672491714495f4c5739ab1ec2b46e

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7156/1/testReport/

Max. process+thread count
4890 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7156/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


JS Tracker: Inaccurate documentation

Project: Javascript tracker
Version: Latest
Expected behavior:
Docs and schema are in sync.
Actual behavior:
Docs show targetUrl in trackAdImpression as optional, schema shows as required.
Steps to reproduce:
While looking at the docs for the snowplow JS tracker, we noticed that under trackAdImpression ( https://github.com/snowplow/snowplow/wiki/2-Specific-event-tracking-with-the-Javascript-tracker#361-trackadimpression ) that targetUrl is marked as not required. However in the schema validation used by Snowplow, it is marked as required ( https://github.com/snowplow/iglu-central/blob/b85fe4e002056a6c2b27a41f4ac7135dea87d9d3/schemas/com.snowplowanalytics.snowplow/ad_impression/jsonschema/1-0-0#L30 ) through a minimum length

Hi @rjerue
Thanks for the report.
It's minProperties: 1 that makes it fail if you don't pass in any parameters to a trackAdImpression call. It's fine to have an optional field with minLength: 1, this means targetUrl is not required.
Technically, none of the fields are required but you need to specify at least one of them. I agree the docs could make this clearer so I'll update them.


[WIP] new repo/developer activity & influence trend charts

This PR is initiated by #297, and any updates will be put here.

The first thing we should decide on is where to insert the new charts on both repo home page and user profile page.
For repo home page, I have two options now:

above code directory

below Languages

For user profile page:

What do you guys think? @frank-zsy @zhuxiangning @heming6666 @LiuChangFreeman @will-ww

I think the 2nd option of repo and user profile are fine as they are identical in layout logic and more elegant. I think the space above code is too wide and too aggressive, fix width is good enough for me.

Agree~

Successfully anchored:

A demo (from vscode repo page):

This is @frank-zsy 's trends of Activity & Influence:

Almost finished. Guys you can put your comment below and I will make it better.

@frank-zsy, why 404 NOT FOUND "https://hypertrons-oss.x-lab.info/activity_influence/actors/x/xiaoya-Esther.json"? Is this data not computed?

Do you think we should add i18n suuport for this charts? @frank-zsy

Do you think we should add i18n suuport for this charts? @frank-zsy

Yes, I suppose i18n is preferred for all components in hypercrx.

ok~

And can split activity and influence into tow different y axis since the value range is different?

Things can also be done with multiple-y-axis charts, and then we will have left-y and right-y to measure activity and influence separately. Which way do you prefer?

I think activity on left-y axis and influence on right-y axis is just fine since activity is easier to understand.

got~ I will make and update some demos later today.

How about this?

I think it is good enough to be a release~

Then I will add i18n support and update this PR.

en:

zh:

@frank-zsy @LiuChangFreeman @heming6666 Guys, this PR is ready to be reviewed!

Really looking forward to this feature, is there any other problems about this PR?

Yes, there is. I just found a bug. I will fix this.

light & dark themes will also be supported. I'm working on this.

I examined echarts options today and made interactions with the charts better, especially in terms of data zooming.
It looks like below now(in dark mode):

I think the PR is prepared to be merged :) @frank-zsy

/approve


pre-commit: yamlfmt

See also: https://github.com/apache/arrow-go/blob/e112ad0de5ca66133256f2db71bda4dd2d1731f5/.pre-commit-config.yaml#L58-L61

I tried yamlfmt, but it wants to un-wrap long strings which I think is a net negative for us, and retain_line_breaks doesn't seem to do anything

Oh, could you share a sample format result?

diff --git a/.github/ISSUE_TEMPLATE/usage_question.yaml b/.github/ISSUE_TEMPLATE/usage_question.yaml
index f8e0a7bc..c69d3141 100644
--- a/.github/ISSUE_TEMPLATE/usage_question.yaml
+++ b/.github/ISSUE_TEMPLATE/usage_question.yaml
@@ -23,30 +23,11 @@ body:
   - type: markdown
     attributes:
       value: >
-        While we enable issues as a mechanism for new contributors and passers-by who
-        are unfamiliar with Apache Software Foundation projects to ask questions and
-        interact with the project, we encourage users to ask such questions on public
-        mailing lists:
-
-        * Development discussions<EMAIL_ADDRESS>(first subscribe by sending an
-        e-mail to dev-subscribe@arrow.apache.org).
-
-        * User discussions<EMAIL_ADDRESS>(first subscribe by sending an e-mail
-        to user-subscribe@arrow.apache.org).
-
-        * Mailing list archives: https://arrow.apache.org/community/
-
-
-        Do not be surprised by responses to issues raised here directing you to those
-        mailing lists, or to report a bug or feature request here.
-
-
-        Thank you!
+        While we enable issues as a mechanism for new contributors and passers-by who  are unfamiliar with Apache Software Foundation projects to ask questions and  interact with the project, we encourage users to ask such questions on public  mailing lists: #magic___^_^___line * Development discussions<EMAIL_ADDRESS>(first subscribe by sending an  e-mail to dev-subscribe@arrow.apache.org). #magic___^_^___line * User discussions<EMAIL_ADDRESS>(first subscribe by sending an e-mail  to user-subscribe@arrow.apache.org). #magic___^_^___line * Mailing list archives: https://arrow.apache.org/community/ #magic___^_^___line #magic___^_^___line Do not be surprised by responses to issues raised here directing you to those  mailing lists, or to report a bug or feature request here. #magic___^_^___line #magic___^_^___line Thank you!
   - type: textarea
     id: description
     attributes:
-      label: >
-        Describe the usage question you have. Please include as many useful details as
-        possible.
+      label: >
+        Describe the usage question you have. Please include as many useful details as  possible.
     validations:
       required: true

diff --git a/adapter/jdbc/src/test/resources/h2/test1_all_datatypes_h2.yml b/adapter/jdbc/src/test/resources/h2/test1_all_datatypes_h2.yml
index c4f00170..c370337d 100644
--- a/adapter/jdbc/src/test/resources/h2/test1_all_datatypes_h2.yml
+++ b/adapter/jdbc/src/test/resources/h2/test1_all_datatypes_h2.yml
@@ -11,113 +11,52 @@

 name: 'test1_all_datatypes_h2'

-create: 'CREATE TABLE table1 (int_field1 INT, bool_field2 BOOLEAN, tinyint_field3 TINYINT, smallint_field4 SMALLINT, bigint_field5 BIGINT,
-    decimal_field6 DECIMAL(20,2), double_field7 DOUBLE, real_field8 REAL, time_field9 TIME, date_field10 DATE, timestamp_field11 TIMESTAMP,
-    binary_field12 VARBINARY(100), varchar_field13 VARCHAR(256), blob_field14 BLOB, clob_field15 CLOB, char_field16 CHAR(14), bit_field17 BIT,
-    null_field18 NULL, list_field19 INT ARRAY, map_field20 VARCHAR(256));'
+create: 'CREATE TABLE table1 (int_field1 INT, bool_field2 BOOLEAN, tinyint_field3 TINYINT, smallint_field4 SMALLINT, bigint_field5 BIGINT, decimal_field6 DECIMAL(20,2), double_field7 DOUBLE, real_field8 REAL, time_field9 TIME, date_field10 DATE, timestamp_field11 TIMESTAMP, binary_field12 VARBINARY(100), varchar_field13 VARCHAR(256), blob_field14 BLOB, clob_field15 CLOB, char_field16 CHAR(14), bit_field17 BIT, null_field18 NULL, list_field19 INT ARRAY, map_field20 VARCHAR(256));'

(and many more changes like this)

I also tried setting the config to only touch .pre-commit-config.yaml but it seems that doesn't take effect (or I didn't set it up right)

Oh... They are unexpected results...

Oh, I overlooked this discussion. I unwrapped long strings...

I also confirmed that retain_line_breaks=true doesn't seem to do anything.
yamlfmt -dry -formatter retain_line_breaks=true ...

I have no idea to resolve this format issue. For now, let me postpone this issue later.


Update logo

Dani had some good suggestions for the logo and the design, she wants to update it.

Hi, please assign this to me 😊


Unjailbreak unc0ver jailbreak

How to unjailreak unc0ver jailbreak?
There are lots of guide to unjailbreak for Electra using SemiRestore11/Rollectra, but I couldn’t find any for unc0ver.

You can use SemiRestore11/Rollectra on Unc0ver too!

^what he said


Fix cmake include path. Other minor fixes.

Issue #564

Yeah it's much better
Also o want to know why you want to use source tree ?
Since Vs 2017 you have CMake native support from visual studio with all your folder.

In my workflow I run cmake from a git bash shell and open the solution file in VS 2019. I'll look into VS integration later.

Also I want to know why you want to use source group ?

source_group() is also used by Xcode to generate groups.
Ability to open CMake file as a project is new option and by no means an excuse to drop support for filters in regular VS projects. IMHO


No ValidationError anymore when using 'yyyy-MM-DD' string with AwareDatetime type

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
In pydantic 2.6.0 the support for yyyy-MM-DD string for datetimes was added (issue + PR).
When using AwareDatetime, no ValidationError is raised anymore in 2.6.0+. However, since no Timezone information is attached to a yyyy-MM-DD string, I would expect a ValidationError to be raised.
Potential workaround: As mentioned in this issue a StrictDatetime could be possible, if so, how would a StrictUTCDatetime type work?
Example Code
from datetime import timezone
from typing import Annotated

from pydantic import AfterValidator, AwareDatetime, BaseModel, ValidationError

def validate_utc(dt: AwareDatetime | None) -> AwareDatetime | None:
    """Validate that the pydantic.AwareDatetime is in UTC."""
    if dt:
        if dt.tzinfo.utcoffset(dt) != timezone.utc.utcoffset(dt):
            raise ValueError('Timezone must be UTC')
    return dt

DatetimeUTC = Annotated[AwareDatetime, AfterValidator(validate_utc)]

class UTCModel(BaseModel):
    dt_aware: DatetimeUTC

if __name__ == '__main__':
    try:
        m = UTCModel(dt_aware='2023-01-01')
        print(repr(m))
    except ValidationError as e:
        print(e)
    """
    UTCModel(dt_aware=datetime.datetime(2023, 1, 1, 0, 0, tzinfo=TzInfo(UTC)))
    """

Python, Pydantic & OS Version
poetry run python -c "import pydantic.version; print(pydantic.version.version_info())"
             pydantic version: 2.6.1
        pydantic-core version: 2.16.2
          pydantic-core build: profile=release pgo=true
                 install path: /Users/xxx/Library/Caches/pypoetry/virtualenvs/myrepo-fwpETFsa-py3.11/lib/python3.11/site-packages/pydantic
               python version: 3.11.6 (main, Nov  2 2023, 04:39:43) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]
                     platform: macOS-14.3.1-arm64-arm-64bit
             related packages: typing_extensions-4.9.0 fastapi-0.109.2 mypy-1.8.0 email-validator-2.1.0.post1 pydantic-settings-2.2.1
                       commit: unknown

One solution could be as per this comment
class UTCModel(BaseModel):
    dt_aware: DatetimeUTC = Field(..., strict=True)

however, all the previously lax and valid formats will now fail as well, e.g.
input_data = datetime.now(timezone.utc).isoformat()

@davidhuser,
Thanks for reporting this. I'm adding this to the 2.6.2 milestone! Will keep you updated as I work on a fix.

Ah, so this was actually fixed by my fix for this: https://github.com/pydantic/pydantic/issues/8867.
Going to mark this as resolved, and will work on the 2.6.2 release now!

thanks for looking into it. Your link self-references to this issue, out of curiosity where was the fix implemented?

Ah, meant to link to this issue: https://github.com/pydantic/pydantic/issues/8762. Should be out now with 2.6.2!


Is there API for mutating AST nodes?

Let's say I need detect some dangerous js api call, when I found it in the AST I'd like to remove the node, and re-generate the updated code from mutated AST nodes. How can I do that?

see https://github.com/estools/escodegen


”Naidăș”, ”Lescovița” are listed in the drop-down menu

Description:
When user writes ”Naidăș”, ”Lescovița” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Naidăș"

Expected results
The location appears in the drop-down menu as "Sat Naidăș, CARAȘ-SEVERIN(Naidăș)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Lescovița"

Expected results
The location appears in the drop-down menu as "Sat Lescovița, CARAȘ-SEVERIN(Naidăș)".


Weblate could not merge upstream changes while updating the repository.

Could not merge the repository.
Weblate could not merge upstream changes while updating the repository.
Rebasing (1/2)
error: could not apply b476ecb... Translated using Weblate (German)
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply b476ecb... Translated using Weblate (German)
Auto-merging admin/i18n/de/translations.json
CONFLICT (content): Merge conflict in admin/i18n/de/translations.json
(1)
Typical workflow for fixing merge conflicts

Commit all pending changes in Weblate and lock the translation component.
wlc commit; wlc lock
Add Weblate exported repository as a remote.
git remote add weblate https://weblate.iobroker.net/git/adapters/nspanel-lovelace-ui/ ; git remote update weblate
Merge Weblate changes and resolve any conflicts.
git merge weblate/main
Push changes into upstream repository.
git push origin main
Weblate should now be able to see updated repository and you can unlock it.
wlc pull ; wlc unlock

done


Migrate PodSelectors for AWS/OpenStack CCM and CSI

What this PR does / why we need it:
We switched to using Helm for templating manifests for AWS/OpenStack CCM and CSI. However, PodSelector labels are different when using Helm. Because PodSelector labels are immutable, upgrading from an earlier KubeOne version fails.
This PR adds migration logic so that we mitigate this issue.
Which issue(s) this PR fixes:
xref #2782
What type of PR is this?
/kind bug
/kind regression
Does this PR introduce a user-facing change? Then add your Release Note here:
- Redeploy AWS EBS CSI driver upon upgrading from earlier KubeOne versions to KubeOne 1.7 to update PodSelector labels
- Redeploy OpenStack CCM and Cinder CSI driver upon upgrading from earlier KubeOne versions to KubeOne 1.7 to update PodSelector labels

Documentation:
NONE

/assign @kron4eg @ahmedwaleedmalik

/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-from-v1.24.15-to-v1.25.11
/test pull-kubeone-e2e-openstack-default-stable-upgrade-containerd-from-v1.24.15-to-v1.25.11

/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-from-v1.24.15-to-v1.25.11
/test pull-kubeone-e2e-openstack-default-stable-upgrade-containerd-from-v1.24.15-to-v1.25.11

/test pull-kubeone-e2e-aws-default-install-containerd-v1.25.11

/approve
/lgtm

/test pull-kubeone-e2e-aws-default-install-containerd-v1.25.11

/test pull-kubeone-e2e-aws-default-install-containerd-v1.25.11

/test pull-kubeone-e2e-aws-default-install-containerd-v1.25.11


Error System.IO.FileNotFoundException

Can I use this DLL on .NET Framework 4.7.2?  I get this error when trying to start the application, which is referencing the DLL.
using EasyTCP;
It does it when I insert this code in:
public static Server TCPServer = new Server();
Getting error:
System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.'

`InnerException
{"Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.":"System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"}
System.Exception {System.IO.FileNotFoundException}`


[improve] add readme stars

What's changed?

add readme stars

Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[x]  I have added the necessary unit tests and all cases have passed.

Add or update API

[x] I have added the necessary e2e tests and all cases have passed.

could https://api.star-history.com/svg?repos=apache/hertzbeat&type=Date look better?

Hi, we had a diagram before, but it was too slow to load sometime, so deleted it. It is recommended not to add this to keep the readme concise.

Hi, we had a diagram before, but it was too slow to load sometime, so deleted it. It is recommended not to add this to keep the readme concise.

okay, sorry i didn`t know


🇺🇦 remove fascism

https://en.wikipedia.org/wiki/Z_(military_symbol)

I gotta admire the effort, but I vote to NOT think about a letter in the alphabet as owned by a fascist regime, and instead mock them for copying the best shell utility evert o be invented.
rupa's Z for world domination!

Not picking sides in your fight, but you made a mistake - Z isn't Russian, it's Aussie.
https://en.wikipedia.org/wiki/Z_Special_Unit

Fascism remains.


[Suggestion] Pop-up "use emote" when tab on the emote and suggest an emote when typing

First suggestion. When tab on an emote in the chat it will pop-up something like this:

if it's too much work you can just add "use emote" pop-up only. When tab on use emote the emote name will appear in the text box.
Second suggestion. When typing something that related to the emotes name, suggest emotes will appear above the text like this:

Regarding the second feature: That is already a (somewhat hidden) feature in the Twitch App, which bttv-android supports. Just type a colon (:) and then emotes will be suggested for you.
The "use emote" button should paste the emote into the text field, do I understand that correctly?

Regarding the second feature: That is already a (somewhat hidden) feature in the Twitch App, which bttv-android supports. Just type a colon (:) and then emotes will be suggested for you.
The "use emote" button should paste the emote into the text field, do I understand that correctly?

Oh, I never knew colon suggested other emote outside of the simple ones. Thanks for informing me.
And yes, the "use emote" is essentially a copy&paste bottom, however it won't be copy to clipboard but directly paste to the text field. As for the "copy"  it's the one that copy to clipboard

Ok, colon doesn't suggest emote outside of twitch. It doesn't suggest 7tv, bttv or franker


Revert "Revert "gangway: add status change endpoint""

Reverts kubernetes-sigs/prow#156

/ok-to-test

/hold

/test pull-prow-integration
/unhold

Can you drop a sentence or two into the description about what the problem was and what is the fix?

/test pull-prow-integration
let's try it once more ;)

/test integration
/approve
@smg247 seeing you already reviewed the code I'm leaving the lgtm up to you ;)

/test pull-prow-integration

/lgtm


Incorrect @Synchronized("readLock") working

Hi!
Please take a look at attached source.
Explicit blocking (with synchronized blockes) works fine, but synchronized annotation breakes all rules.
BlockingTest.java.txt
jdk version is <IP_ADDRESS> and Lombok version is 1.16.10
p.s. also if you'll replace static logger with Slf4j annotation my Intellij Idea 15.0.3 will see it as a valid code but will give compilation error.

I removed logging I didn't like, changed the delays to 1 second and tried it out in Eclipse. The outcome is always something like
20:27:20.523 [Thread-0] INFO  c.o.handlers.search.BlockingTest - task1 locked
20:27:21.527 [Thread-0] INFO  c.o.handlers.search.BlockingTest - task1 unlocked
20:27:21.527 [Thread-1] INFO  c.o.handlers.search.BlockingTest - task2 locked
20:27:22.527 [Thread-1] INFO  c.o.handlers.search.BlockingTest - task2 unlocked
20:27:22.528 [main] INFO  c.o.handlers.search.BlockingTest - main locked
20:27:23.528 [main] INFO  c.o.handlers.search.BlockingTest - main unlocked

The two tasks behave the same, the locking works, what would you expect? Does it behave differently in Intellij?
I also tried @Slf4j and lowercased the logger name and it worked fine. In case the problem is Intellij specific, you should probably file an issue here.

You're right, it looks like a problem of plugin for Intellij Idea.


basic support for unary pretty print

(partially) fixes https://github.com/aya-prover/aya-dev/issues/687
leftovers:

print ¬ ¬ A instead of ¬ (¬ A)

leftovers:

print ¬ ¬ A instead of ¬ (¬ A)

No need, good enough
bors r+


[Feature Request] Option to add timestamps to database tables

Checkbox option perhaps to add the "created_at" and "updated_at" timestamp fields to any database tables.
Can add them manually with a default of "0000-00-00 00:00:00" but a little checkbox that added in $table->timestamps(); to the up() function would be a nice touch.
Fantastic job by the way guys with this plugin!!

->softDeletes() is a relative of ->timestamps(), another table wide setting, which could be bundled in with this too.

Yes that would be nice! :+1:

Sexytime!

+1

+1

+1

created_at, updated_at and deleted_at columns can now be added with new toolbar buttons on the database table management tab. The New Model popup now has checkboxes for enabling timestamps and Soft Deleting for new models. It's not possible to create new columns right from the New Model popup as it creates complex use cases (the database table editor can be open in another tab and have unsaved changes).

This feature is great.
I want to add complementary button "User integrity" or maybe "Data integrity", the purpose is add two fields to the table database: created_by and updated_by.
And complementary to soft delete: deleted_by.
But I have a question (issue #235), I would like to have your help.


Where is the adc-schema.json file?

ISSUE TYPE

Documentation Report

AS3 BUILD/ VERSION

f5-appsvcs (f5-appsvcs-3.2.0-7.noarch) | 3.2.0 | 7

BIGIP VERSION

Version | BIG-IP 12.1.2 Build 2.0.276 Hotfix HF2

SUMMARY

The F5 AS3 documentation indicates there is a json schema available:
For example:

https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/3/userguide/components.html#as3-json-schema

The JSON Schema document prescribes the syntax of an AS3 declaration (found in the file adc-schema.json in the /src/schema directory of the GitHub repository).
(Emphasis in original)

The Bolded filename and directory are not helpfully when I cannot find the GitHub repository that contains them. I have search F5Network Org in github, all of github, and google, and cannot find this schema file.

https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/3/refguide/as3-api.html

The request document may be a proper request (see as3-request-schema.json) or a ADC-only declaration (see adc-schema.json).
(Emphasis added)

Where can I find these files?

STEPS TO REPRODUCE
Click on the above links.
EXPECTED RESULTS
The documents linked above provide direct links to the json schema files, or are more descriptive of where to find them.
ACTUAL RESULTS
An unsatisfied F5 customer spends most of the day on a worthless Easter Egg hunt.

@kshanafelt I'm sending Tyler a message for us to chat about this; totally agree on the open issue, looking to provide you some support while it gets worked out.

I've raised visibility of this issue with engineering. Thanks for your patience.

@jmcalalang i sent the schema to Tyler

The schema files are now published on GitHub in this repo: https://github.com/F5Networks/f5-appsvcs-extension/tree/master/schema.  Closing this issue.


Fix/security context

Resubmitting https://github.com/grafana/k6-operator/pull/74 with the unit tests fixed. This PR will unblock us in a significant way.

Hi @adamdabbracci Thank you for the PR! Unit tests are still failing though :disappointed:
Github action: https://github.com/grafana/k6-operator/runs/5310014072?check_suite_focus=true
--- FAIL: TestNewRunnerJobLocalFile (0.00s)
    runner_test.go:921: NewRunnerJob returned unexpected data, diff: [Spec.Template.Spec.SecurityContext: v1.PodSecurityContext != <nil pointer>]
FAIL

This looks like a missing field during assertion and should be easy to fix.
Also, it's possible to run the following locally:
make test-setup-ci
make test

Github action is using the same commands.

Hi @adamdabbracci Thank you for the PR! Unit tests are still failing though 😞 Github action: https://github.com/grafana/k6-operator/runs/5310014072?check_suite_focus=true
--- FAIL: TestNewRunnerJobLocalFile (0.00s)
    runner_test.go:921: NewRunnerJob returned unexpected data, diff: [Spec.Template.Spec.SecurityContext: v1.PodSecurityContext != <nil pointer>]
FAIL

This looks like a missing field during assertion and should be easy to fix.
Also, it's possible to run the following locally:
make test-setup-ci
make test

Github action is using the same commands.

This isn't happening locally, but I'm guessing my branch was out of date with main. I just merged main and got all of the tests to pass successfully locally.

It seems we made commits approx. at the same time: you to your branch and me merging to main :sweat_smile: I think that's the reason Github now shows:

This branch cannot be rebased due to conflicts

I tried the local rebase of this branch onto main and there's a one-line conflict in pkg/resources/jobs/runner_test.go. Can I ask you please to do the rebase and force push the branch?
Unit tests are a pass so that's the only thing that prevents the merge.

My git-fu is very limited so I'm not sure if I did this right... but I believe I re-based.

Hmm, nope, it shows the same:

Right, when I fetch your branch I see this history:
98b4ea4 Fri Feb 25 09:56:11 2022 -0500 Adam D'Abbracci (HEAD, adamdabbracci/fix/securityContext) Merge branch 'fix/securityContext' of github.com:adamdabbracci/k6-operator into fix/securityContext
d702616 Thu Feb 17 14:51:00 2022 -0500 Adam D'Abbracci Recreated fix from correct branch
23ca359 Fri Feb 25 08:52:54 2022 -0500 Adam D'Abbracci Fixing unit tests
1505d43 Fri Feb 25 08:49:43 2022 -0500 Adam D'Abbracci Merge branch 'main' into fix/securityContext
1d8b4fd Fri Feb 25 08:49:39 2022 -0500 Adam D'Abbracci Mergeing upstream
57e4b3e Sat Feb 19 15:37:12 2022 +0100 Cansu Kavili (origin/main, main) update clusterrole template to be compatible with OpenShift
e6d8973 Thu Feb 17 14:51:00 2022 -0500 Adam D'Abbracci Recreated fix from correct branch
cbbbc31 Thu Feb 17 14:44:06 2022 -0500 Adam D'Abbracci Fixing broken unit tests
68e5c12 Thu Feb 17 14:40:11 2022 -0500 Adam D'Abbracci (adamdabbracci/main) Fixed missing unit tests
303db2b Fri Feb 11 16:26:31 2022 +0200 Olha Yevtushenko (tag: v0.0.7rc4, brian/main) starter: add retries on errors
46fb8e3 Wed Feb 9 10:06:21 2022 -0500 Brian Groux Update reconcile->finish naming, inline with create and start
350ca49 Fri Oct 22 14:20:19 2021 -0400 Brian Groux Add finished state change and clean up post execution

After rebase all of your commits should have ended above Cansu's commit. So something went off for sure :joy: The commands should have been ~ git rebase -i origin/main, resolve, then git push --force. But now it needs to be cherry-picked I think... So now it requires running another git rebase but skipping the duplicated commits like described in here or alternatively by resetting back to commit e6d8973 as described here and re-doing the rebase correctly. Would you like to try that yourself?
I'm fine with creating a separate PR with your commits and then merging that instead too.

Going to try a new PR, I think that's the easiest way. Thanks!

Hi @adamdabbracci, I've had a bit of time and fixed the branch for security contexts in #105 - it's merged in now.
I couldn't preserve your commit directly: it seems the necessary commit was made against the main branch in your repo and in order to add your changes, I had to make a separate commit. So I wrote your name as co-author of commit for unit tests fix instead: https://github.com/grafana/k6-operator/pull/105/commits/16b14a67f05173b9b44965310aa64b742c2cf703.
Please use the main branch and open an issue / PR if something is off. Thanks for working on this :slightly_smiling_face:

Amazing, thank you! I kept meaning to resubmit the PR but it got pushed
back by urgent things. I appreciate the help, and we will implement our
solution that needed this ASAP.
On Tue, Mar 29, 2022 at 2:49 AM yorugac @.***> wrote:

Hi @adamdabbracci https://github.com/adamdabbracci, I've had a bit of
time and fixed the branch for security contexts in #105
https://github.com/grafana/k6-operator/pull/105 - it's merged in now.
I couldn't preserve your commit directly: it seems the necessary commit
was made against the main branch in your repo and in order to add your
changes, I had to make a separate commit. So I wrote your name as co-author
of commit for unit tests fix instead: 16b14a6
https://github.com/grafana/k6-operator/commit/16b14a67f05173b9b44965310aa64b742c2cf703
.
Please use the main branch and open an issue / PR if something is off.
Thanks for working on this 🙂
—
Reply to this email directly, view it on GitHub
https://github.com/grafana/k6-operator/pull/101#issuecomment-1081477504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6DJLQ5HMSBB3F7RICRYVLVCKRWPANCNFSM5PEPGMVA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Adam D'Abbracci


open /var/db/dhcpd_leases: no such file or directory

launchctl start local.dlite
...

sudo dlite daemon
COM1 connected to /dev/ttys001
rdmsr to register 0x570 on vcpu 0
open /var/db/dhcpd_leases: no such file or directory

sudo touch /var/db/dhcp_leases # seems to "fix" this

i really appreciate these bug reports. i'll have a new release out shortly, but please do continue filing issues for anything else you find!

Working, thanks a lot!
Steps:
rm /var/db/dhcp_leases
sudo dlite install
sudo dlite daemon
COM1 connected to /dev/ttys002
rdmsr to register 0x570 on vcpu 0
rdmsr to register 0x34 on vcpu 0


avatar for gecko

Had to fix the height to meet the reqs! All is good.

cc/ @BeefKnuckleback -- I'm going to merge this, and see if it ever shows up. If it's super wrong, just comment here and we'll back it out/fix it/whatever, I have no idea.
We'll also nuke it if it appears and looks like a butt.


Clarify update() signature.

It is currently unclear where to manage non-rendering state change operations with the documentation deep in the explanation here rather than in the method signature.
In other places (i.e. render()), in text references to method calls seem to omit their arguments, so I did the same with update() and super.update(). Let me know if there is an alternate notation approach is preferred.

This was rolled into https://github.com/Polymer/lit-element/pull/161. Thanks for catching that.


useGlobalFilter custom filtering function doesn't work

Using v7?
Thanks for using the beta version of React Table v7! We're very excited about it.
Describe the bug
Can't set the custom filter function for the global sort
To Reproduce
Steps to reproduce the behavior:
In filter codesandbox example remove fuzzy filtering
Expected behavior
filterTypes ... text to be called on globalFilter value change
Codesandbox!
https://codesandbox.io/s/objective-https-0m4cr

Neither column filtering seems to call the filterTypes func

This is fixed in master and slated for release. Thanks for your help everyone!
@stevenhuyn please ask your question on our spectrum.chat/react-table forum. Thanks!


Issue 5928 r semantics for arithmetics

Opening locally for now. Nan can only be encoded in Double and floats, so other types do not require this check. You can't even write a test for select 'nan'::HUGEINT because you get a cast error. This PR is to see if tests pass.
Will eventually clean up the code and open the PR to master

closing because issue should be fixed with https://github.com/Tmonster/duckdb/pull/32


Update go.mod

🎉 Snyk hasn't found any issues so far.
✅ code/snyk check is completed. No issues were found. (View Details)


Add scaffolding for rollkit E2E tests

Summary
Add scaffolding for E2E tests which should do the following

spin up wasm simapp
spin up rollkit app
spin up celestia testnet

We can use the following images

ghcr.io/chatton/rollkit:latest
ghcr.io/chatton/ibc-go-wasm-simd:latest
ghcr.io/rollkit/local-celestia-devnet:v0.12.7

within the test for this initial step.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Work was done in https://github.com/cosmos/ibc-go/pull/6029 that can be referenced when this is picked up again.


Same downsample will return different images

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[X ] I have read the wiki page and cheat sheet, but there is no information I need.
[ X] I have searched in existing issues, but did not find a same one.
[ X] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
First, thanks for this great library.
I discovered one potential issue for downSamplingProcessor. I am not sure whether it is by design or bug. Basically downsampling function may return image with different aspect ratio based on the actual source.

self.bounds.size is 185 x 192
Original image size is 430 x 760

    self.kf.setImage(
            with: url,
            placeholder: nil,
            options: [
                .processor(DownsamplingImageProcessor(size: self.bounds.size)),
                .scaleFactor(UIScreen.main.scale),
                .transition(.fade(0.2)),
                .cacheOriginalImage
            ])

What
I set up the breakpoint and discover following two behaviors with one call site.
When we downsample using data, this function will be called
           return KingfisherWrapper.downsampledImage(data: data, to: size, scale: options.scaleFactor)
It returns image with exact same aspect ratio as original image
However if we retrieve an original image from disk or memory cache, then we will downsample the image

return image.kf.scaled(to: options.scaleFactor)
                        .kf.resize(to: size, for: .none)

It will not respect to aspect ratio when resizing.
Reproduce
[The steps to reproduce this issue. What is the url you were trying to load, where did you put your code, etc.]
Other Comment

if we choose not to cache original image, only cache downsampled image, the issue might be solved. I have not tried yet.
If we choose to cache original image, I feel we should change mode from .none to .aspectFit

The reason that the "image.kf.scaled" method gets called is Kingfisher failed to find the exact cached image in the cache. It might be due to that you have a different bound size when showing the image again. Kingfisher's DownsamplingImageProcessor also use the input size as a cache identifier. So if you provide different size later, Kingfisher would think that it is another version requested. Then, luckily, Kingfisher knows that the original image is already cached (the .cacheOriginalImage option), it can just load the cached original image and then do a downsampling operation.
However, the current implementation for downsampling a cached original image is just reverting to a resizing. I guess it should not be a limitation here (which also causes a performance regression when downsampling from a disk image). I will try to give a fix for it soon.

Thanks for your response and the fix. The way I tested it and reproduced using large images (8mb) and small cache size(80mb) within a collection view around 30 images in total.
bounds are exactly same, any in memory cache are just not large enough to hold everything, since I also enable to cache original image.
I believe your fix should also work, but I wonder do we need to convert to data and image back and forth. I felt the issue is caused by inconsistency, since when we downsample using data, we have this parameter kCGImageSourceCreateThumbnailWithTransform (scale based on original image ratio and orientation). When downsampling using original image, we do not scale or resize based on original image ratio. If we change it from
  return image.kf.scaled(to: options.scaleFactor)
                        .kf.resize(to: size, for: .none)

to
  return image.kf.scaled(to: options.scaleFactor)
                        .kf.resize(to: size, for: .aspectFit)

Should it be enough to fix the problem?

The original image will never be sent to memory. It is a disk only cache.
Converting between data and image is not that performance critical, as long as we do not render it. However, the kf.resize would decompress the full original image and render it to a smaller size, which is a memory critical operation. The main purpose of DownsamplingImageProcessor is to solve the high memory pressure when loading large images, so I believe it worths to avoid using resize at all.
It is not ideal to convert the image to data again. It is more a design limitation in the cache serializer system of Kingfisher. A possible workaround for it is that we can make some special handling to not use default cache serializer when encountering a DownsamplingImageProcessor. But I didn't find an elegant way to do it now. I will consider twice later when I have more time for it.


Fix sample selection with map panel

What changes are proposed in this pull request?
Sample ID to grid index map should be cleared when the grid is reset
How is this patch tested? If it is not, please explain why.
Hook test ✨
Release Notes

Fixed sample selection when interacting with plugins that use an extended selection

What areas of FiftyOne does this PR affect?

[x] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Summary by CodeRabbit

New Features

Introduced a custom hook useRecords for enhanced record management.
Added unit tests for the useRecords hook to ensure reliability.
Introduced unit tests for addRange and removeRange functions in the useSelectSample module.

Improvements

Streamlined import statements for better clarity and type safety.
Enhanced error handling in record retrieval logic.
Improved flexibility and efficiency in the useSpotlightPager hook by adjusting its parameter structure.

I think the real issue popped up during cleanup. Range selection needed to omit selections that the grid doesn't know about. Added unit tests to assert behavior


Firebase not compatible

I'm trying the 3.2.0 boilerplate version. Just cloned it and added firebase package. Whenever i try to npm run start, i get a browser error: Uncaught Error: Cannot find module "fs". It seems firebase is using dom-storage package and there seems to be some sort of incompatibility with webpack...

You're right, Firebase has compatibility problems. More here.

I found the same issue, does anyone know how to fix this
Uncaught Error: Cannot find module "fs"

I had to go back to older versions of react-boilerplate after messing up with 100 different dependencies problems because of this. I haven't tried any further since then...


Repo sync for protected CLA branch

The pull request is created from master637441703951991349 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add pipelining operator

Support the operator |> as in fsharp, e.g.
from k in keys(pattern) select get(k) |> distinct() |> collect()
the pipelined value should passed as the last argument to the target function, as in f#

resolved with fe546e2


Jupyter Tutorial for Bash and R backends

Now that we have a complete workflow using trident, we can aim at having a nice Jupyter/Binder tutorial, complete from downloading Poseidon packages to exploring and analysing them.
For Bash, @nevrome suggested this workflow:
trident list --remote --packages
trident fetch -d . -f "*2020_Immel_Moldova*,*2020_Wang_subSaharanAfrica*"
trident list -d . --packages
trident summarise -d .
trident survey -d .
trident validate -d .
trident forge -d . -f "<HYR002>,<Gordinesti>" -o test -n Testpackage

We could go further than that and even run a quick PCA and plotting in R (using a separate R-backend notebook)
For binder, we'd need to define an environment that includes trident as well as smartPCA. The latter is available via a conda package, so that's easy. Trident isn't on conda yet.

Added #61 for conda.


Improve the ui of idea info page

imrpove the ui of idea info page
it must be matching with theme of team info page
Directories :
idea ingo page : /views/Team-Builder-Dashboard/idea-info-page/idea-info.html
team info page : /views/Team-Builder-Dashboard/team-info-page/team-info-page.html

Hi @Naresh-chandanbatve
I want to work on this issue under KWOC'22. Can you please assign this to me?

@Trisha-tech
Go for it.


Using Cayenne over loraserver implementation?

Hi everyone,
I would like to know if there is a way or not using the web application MyDevices Cayenne over the server implementation?
The Lora App Server is really fine but I just want the possibility to have my payloads decrypted as I can manipulate data into dashboards or graphs, without having to administrate my network with Cayenne.
I know some people did this kind of thing but I just did not find out to do that.
Before, I was using the ELK stack to analyze received data but this service does not have a MQTT plugin to process data so I'm trying something else.
Thank you for your attention,
François

This features is already provided by the latest LoRa App Server version. Simply use the Cayenne LPP coded in your application settings.


It just crashes when installed

As the title says, right now it just crashes. I hope you can fix this, as this is a very important plugin for me 🥺

Should be fixed in 90636f4, reopen if you're still experiencing this.


unable to list journey/tree from subrealms

Frodo CLI version
Provide output of frodo -v
cli: v0.13.1
lib: v0.12.4
node: v18.5.0
Describe the issue
OpenAM 7.1.2 with realms

root realm /
subrealm /common
subrealm /common/partner
subrealm /common/organisation

frodo is able to list journeys in /common realm, but not /common/partner and /common/organisation
example
./frodo journey list http://server:8080/openam /common amadmin password
Classic deployment detected.
Connected to ForgeRock Access Management 7.1.2 Build 1b8a956b868a6794e652f23a878e694c07b8ecc9 (2022-March-11 20:06)
Listing journeys in realm "/common"...
TREE1
TREE2
TREE3
/common/partner contains one tree -> none are found
./frodo journey list http://server:8080/openam /common/partner amadmin password
Classic deployment detected.
Connected to ForgeRock Access Management 7.1.2 Build 1b8a956b868a6794e652f23a878e694c07b8ecc9 (2022-March-11 20:06)
Listing journeys in realm "/common/partner"...
Request failed with status code 404
{
code: 404,
reason: 'Not Found',
message: "Resource 'partner/realm-config/authentication/authenticationtrees/trees' not found"
}
/common/organisation contains one tree -> none are found
./frodo journey list http://server:8080/openam /common/organisation amadmin password
Classic deployment detected.
Connected to ForgeRock Access Management 7.1.2 Build 1b8a956b868a6794e652f23a878e694c07b8ecc9 (2022-March-11 20:06)
Listing journeys in realm "/common/organisation"...
Request failed with status code 404
{
code: 404,
reason: 'Not Found',
message: "Resource 'organisation/realm-config/authentication/authenticationtrees/trees' not found"
}

Confirmed, looking into this. Nested realms seem to be broken.


Does this stylesheet work with a ruby on rails application?

This might be a rails specific question, but I followed the instruction on the doc and I haven't been able to get it to work.
First, I moved all the font files, svg, eot, woff, ttf into the assets/font folder.
Then I added this line to the config/initializers/assets.rb
Rails.application.config.assets.precompile << /\.(?:svg|eot|woff|ttf)\z/
Then I dropped the css file into assets/stylesheet
Precompile assets, restart server, didn't work. I'm using the  <i class="icon-html"></i> icon-html
So then I tried moving the css file into the public folder and adding the line in the  to make it work, but the icon still shows up as a box.
There aren't any errors in the console either.

The stylesheet relies on relative paths to load the various fonts specific
to a browser.  You'd need to modify the stylesheet by hand for the new
adjusted path you used.
On Sun, Jun 26, 2016 at 2:58 PM, Ka Mok<EMAIL_ADDRESS>wrote:

This might be a rails specific question, but I followed the instruction on
the doc and I haven't been able to get it to work.
First, I moved all the font files, svg, eot, woff, ttf into the
assets/font folder.
Then I added this line to the config/initializers/assets.rb
Rails.application.config.assets.precompile << /.(?:svg|eot|woff|ttf)\z/
Then I dropped the css file into assets/stylesheet
Precompile assets, restart server, didn't work. I'm using the  icon-html
So then I tried moving the css file into the public folder and adding the
line in the to make it work, but the icon still shows up as a box.
There aren't any errors in the console either.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fizzed/font-mfizz/issues/44, or mute the thread
https://github.com/notifications/unsubscribe/AAjwAuJDY4wQhlaSgO2rAXOY2krBuErbks5qPsvggaJpZM4I-nfY
.

@kamok - yes it does.  You can download it and add it to your Rails app in vendor/assets manually or use the gem font-mfizz-rails.  The released version is out of date right now, so feel free to use the fork I created.
gem 'font-mfizz-rails', github: "ldstudios/font-mfizz-rails", branch: 'mfizz-2.4.1'

@jjlauer - this comment should be sufficient enough to close this out.  Rails support is made very easy by the release of the font-mfizz-rails Ruby gem.


Cache not being invalidated under a specific server config

I have two servers running, one is the main application server, the other is a task runner. Each server has it's own memcached instance for storing data related to it's own tasks, but both servers talk to the same database.
If I add data to the database in the task runner, it doesn't appear in the Django admin on the app server until the cache is cleared - I assume because the task runner is clearing it's own memcached data, not that of the application server.
What's the best fix for this? I can't pool the memcache instances together, as the task runner is at 100% CPU, 100% of the time, so I don't want to risk slow gets on the application from it being in the pool.
Is my best option for my task runner server to just use the memcached instance of the application and not maintain it's own?

Update: I've pointed my task runner to the memcached instance of the application. This should be ok for my use-case, I can't think of any side-effects at this time.


Load Testing

We need to see how dex performs under load; what are the scalability pressures, where do things start to break, etc.

I've found this tool to be handy https://github.com/rakyll/boom

nice, thanks for the tip

This might be useful too https://goad.io

We probably want to add a pprof endpoint or prometheus support for this.


Waste reduction logic app

📝 Scenario
As a FinOps practitioner, I need to get notified when there are cost optimization opportunities in order to keep my workloads running efficiently
🚀 Goal
Create a logic app to notify stakeholders when there are cost optimization opportunities.
📋 Tasks

### Tasks
- [ ] TODO: Add tasks required for each sub-release
- [x] Convert ARM Template into BICEP
- [x] Simplify Deployment Steps
- [x] Resolve email notification URL bug
- [x] Create docs/_automation/waste-reduction-logic-app/README.md
- [x] Test standard Logic App Connection
- [x] Add Azure QuickStart Template repo metadata
- [ ] Submit QuickStart PR
- [ ] Discuss the name
- [ ] Update the changelog
- [ ] Automated Test?
- [ ] Insert MI into template
- [ ] Add standard FTK tags

🙋♀ Ask for the community

We'd love to get your feedback! Please leave any questions, comments, or change requests in the release discussions at the bottom of each task list above. We'll try to close each of those out before we finalize the release.

I had conversations with some big customers regarding this workflow and installed it at one during an implementation engagement. Can we discuss this and perhaps work together to provide options related to this workflow as they gave me a few ideas related to this?

@jamelachahbar yes please let set some time to discuss

#810  and #844


doc(intro): replace the system tray with the latest one.

Issue:
Update the screen capture of system tray to the latest one.
What I did
How to test

Deploy preview ready!
Built with commit 187575070fcc48271860adcdecfb135507f3687e
https://deploy-preview-471--mcslite.netlify.com

Deploy preview ready!
Built with commit 187575070fcc48271860adcdecfb135507f3687e
https://deploy-preview-471--mcs-lite-introduction.netlify.com


Refactor on configuration builders for flexibility

Coverage decreased (-0.7%) to 96.373% when pulling bbacb7378d321d60feb6aed2653fb2c1b8faf3ad on lyncodev:master into aee3a91e0a3747aa1e4174f954b9d7e3a098ca3f on jtwig:master.


spin new should create a new directory by default

Options:

Existing behavior (don't create a new directory). Somewhat surprising and very annoying when a bunch of files get dropped into your top-level "projects" directory #467 mitigates this
Create a new directory by default (if --output isn't set)
Magic: if the current directory is empty, use it; otherwise, do option 2
Ask: prompt for the output directory, maybe with a default value from option 3

@itowlson and I discussed similar issue in https://github.com/fermyon/spin/issues/463.

#467 makes this less annoying, but I think this would still be a nice improvement.

I have a feeling that 'default to current directory' is inherited from the old 'copy an example' behaviour.  We certainly don't need to keep it.  The reason for it, I assume, was so people could create a directory, cd into it and do all their spinning there.
I'm not wildly keen on creating a new directory because it may not be obvious if it gets created into a busy place like Lann's project directory or Mossaka's root directory grin.  So I would definitely want to prompt rather than just create something!  Perhaps offer a choice of 'cancel, yes I really meant generate into busy directory, or pick new destination"...?

What about something like:
$ spin new http-rust
...
Project name: foobar
...
# (current directory empty)
Output directory [.]:
# (current directory full)
Output directory [./foobar]:

The easiest thing is just to make -o mandatory.  If the user wants to generate into the current directory they can go -o ....?

I personally think Cargo new my-project is pretty neutral and I don't have problems with it. How about we make spin new to have the same semantics?

So... make the output dir mandatory but make it positional rather than a flag?

A flag is a feature that allows user to specify which path to create spin project, but the default value should be current_dir/proj_name

Now I'm confused, sorry.  Is this saying there should be a new positional parameter which doubles as a "project name" (when creating a new Spin app, the application name) and the default for the directory, but there should also be a flag parameter to override the output directory?  Apologies for being slow to understand!

Following what Cargo does is my preferred option as well. "Project name" if not supplied on CLI should be prompted, the output of the template is then put into a new directory named "project name"
If "--init" is specified, initialize the current directory instead of creating new dir

cargo new requires an output directory on the command line; it doesn't prompt.
ivan@hecate:~/experiments/cn$ cargo new
error: The following required arguments were not provided:
    <path>

USAGE:
    cargo new [OPTIONS] <path>

Sorry I meant cargo-generate.

A flag is a feature that allows user to specify which path to create spin project, but the default value should be current_dir/proj_name

@itowlson sorry I was mistaken, yes make the output dir mendatory but make it positional. Just like cargo new

Because of https://github.com/fermyon/spin/issues/490
Instead of introducing a new variable, why not just reuse project name?
What I meant above is that "cargo new myproject" will create a crate named "myproject"
It infers the "project name" from the positional output parameter.

Because of https://github.com/fermyon/spin/issues/490
Instead of introducing a new variable, why not just reuse project name?
What I meant above is that "cargo new myproject" will create a crate named "myproject"
It infers the "project name" from the positional output parameter.

So is this like @Mossaka's "mandatory positional parameter" and we use that for both the project name (i.e. a well-known parameter like authors) and the output directory?
i.e. spin new http-rust myproject will set the name parameter to myproject and generate into a directory called myproject?

Sure. That's one way to skin the cat. I'm fi e that approach. If we do that we should remove the project name flag & the prompting of it if not specified.

Sure. That's one way to skin the cat. I'm fi e that approach. If we do that we should remove the project name flag & the prompting of it if not specified.
The other way, is to just prompt if project name wasn't explicitly set via "-n" and use that as the output directory name.

Hmm, I think the project name flag is currently ignored anyway... (mea culpa, should have either wired it up or taken it out before 0.2)

Yeah I believe you are correct. It prompts even if the "-n" is set.

The combination of names and directories and options and prompts is getting overcomplicated.  We don't need to go over the top on what is just meant to be a quick scaffolding system.
I'm happy with requiring a name a la spin new <template-id> <name>, and both setting a well known parameter and an output directory from that.
I do think we still need a -o or similar flag though to generate into a directory that isn't immediately below the current directory.  E.g. spin new http-rust myproject -o ~/tests/myproject.  Would that meet everybody's needs?

Hi there, I was looking to claim this issue but after getting Spin setup + poking around the CLI, I realize that #510 closes this (and comments as much, actually).

Thanks @ejmg ! I believe @itowlson completed this already. Ill close this issue.


Fix grafana dashboard validation

Motivation
Grafana dashboard validation CI job currently succeeds even if dashboards are invalid because git diff throws an error.

Description
Add --stat before non-option arguments

:tada: This PR is included in v1.6.0 :tada:


quiche_conn_send results -10 error

Hi, I am trying to use the c++ api of quiche for a plugin that I am writing in unreal engine. For testing purpose, I have written a simple client code which sends a string to a quic-go echo server. The result I get from quiche_conn_send() is a -10 error. I haven't yet passed it to a socket yet because I believe that this function generates a quic packet which can then be passed to the socket but it fails here.
I referenced issues #488 and #467 but I believe my case is different.
I have the updated boringSSL (since its pulled by quiche as a submodule).

We are also experiencing a similar issue in a similar situation as well. Unsure where exactly the root cause of the issue on windows at the moment.

I took a break from this project and have picked it up again recently. I was able to get past the -10 error by correcting the ALPNs. However I am still unable to ensure a handshake between the client and the server. I have posted the entire description along with the code on stackoverflow (https://stackoverflow.com/questions/78191225/troubleshooting-unreal-engine-integration-with-quiche-library-for-quic-client-de)
I am still new to quiche and unreal engine and have been struggling with this for a while now. Any help is highly appreciated.


support multi-byte strings on Windows

On Windows, it use double-byte character sets not UTF-8. So ReadFile return DBCS bytes. it should be converted to UTF-8.

Hey @mattn!
Nice seeing you over here! Your contribution looks great, but I'm a bit puzzled about the go fmt changes. I can't reproduce that output locally, neither with go fmt nor with goimports or goreturns. What tool did you use to format the sources?
If you don't mind, I could revert the formatting changes, so we can focus on reviewing the actual change.
Thanks again!

Ah, it seems that specification of go fmt changes recently. Sorry. I'll update this PR soon.

Hmm, at least, same result in go1.18.

I'll make this changes again.

https://github.com/golang/go/issues/51082
gofmt is changed

golang/go#51082
gofmt is changed

Understood! This seems to be a pending change for 1.19, tho? Can't reproduce it with 1.18.3 for what it's worth. I think we should stick to the existing format until this gofmt change is part of a stable Go release.

Reverted format

I can squash this changes. Do you want?

I can squash this changes. Do you want?

Thanks, but no need to, can do that here just fine!

Small note that this will close #393.

Thank you so much for the contribution, @mattn. Multi-byte support is really important to us. Cheers 🍻.


Alacritty window rescales during startup

When I start alacrity, it first creates a large window which is then very quickly resized to the final size (~70%).  The resizing is really fast and wouldn't bother me but my window manager (fvwm2) places the window based on the original size and that means that the window position ends up not being what it is supposed to be.
Ubuntu 16.10.  Default alacritty.yml except that I changed the font size to 13.

Thanks for filing this issue. The problem here is we need to know some font metrics to know the proper window size to create, but we can't know the font metrics without having the DPI scaling factor which comes from the window.
Glutin needs a way to get the DPI scaling info for a monitor without actually creating a window.

A workaround would be to open a window to get the DPI scaling factor, then close it and open a new one with the correct size.  Not great but perhaps better than the current state of affairs.

Sent from Alto
On Monday, February 13, 2017 at 12:28 PM Titus von der Malsburg<EMAIL_ADDRESS>wrote:
A workaround would be to open a window to get the DPI scaling factor, then close it and open a new one with the correct size. Not great but perhaps better than the current state of affairs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.￼

I personally find the resizing extremely distracting, especially for something I open on a regular basis.
A possible workaround could be allowing one to detect the dpi scaling factor (e.g launch with a flag, giving the output), which could then be added to alacritty.yml (if it's found in there, there then wouldn't be a need to resize)

Alacritty will resize the window after it has been mapped even if the window size has already been altered (e.g. by an xdotool command). As an example of where this might happen, tdrop (which is a wrapper to run programs as dropdowns) uses xdotool to set the window size before alacritty resizes itself (see noctuid/tdrop#38 for the original issue). This behavior is not a big issue w.r.t. using xdotool since -d 0 0 can be used to prevent it, but I found it unexpected.

@jwilm Could you change the parameters we enter in the config file so that we enter dimensions in pixels and you calculate the lines and columns after you initialize the window? At least that way, the window manager can make good decisions on where to place the window.

Can someone check if https://github.com/jwilm/alacritty/pull/2307 fixes this?

@chrisduerr still seeing the behavior with that branch.
The default size will typically stick and be fine, but is not a realistic use-case.
If you set the configuration file to a given terminal size in cols/lines (e.g my preferred ratio of 90/27) it still resizes down.
I suspect that the issue you were trying to address is a secondary one mentioned in a comment (resizing even if the size was already set by xdotool or similar), rather than the resizing on startup in general (the actual bug).
The original comment by @jwilm suggests that the issue is with lack of API support within glutin, but as per the two bugs above (tomaka/glutin#1096 and tomaka/winit#785) that's not apparently an issue.
What exactly is stopping us from figuring out the font metrics before actually creating a window at this point?
If there is something, could the one with that knowledge also follow up in tomaka/winit#785?

If you set the configuration file to a given terminal size in cols/lines (e.g my preferred ratio of 90/27) it still resizes down.

If you set window dimensions and the DPI factor is not equal to 1, it's impossible not to resize at startup.

The original comment by @jwilm suggests that the issue is with lack of API support within glutin, but as per the two bugs above (tomaka/glutin#1096 and tomaka/winit#785) that's not apparently an issue.

The issue is exactly what vberger has said in the winit issue. It's pointless that we're able to get the DPI for all displays when we do not know which display the window is going to be spawned on.

At this point, I think the question becomes "how do other terminals handle it?"
I don't experience the same problems in, say, Konsole.
All of my displays (at least at home) have a non-1 DPI factor, but all of my displays per-system also have identical DPI factors (same-size displays with same resolution in all multi-display setups).
Surely there's some way for alacritty to handle these common scenarios with equal grace to virtually every other alternative?

@5paceToast I've updated the PR to guess the DPI based on the first monitor available in the monitor list. This should prevent even more resizes at startup. Now the only condition where it will resize is when you have multi-DPI setup, specify dimensions and the DPI guess is incorrect.
Honestly this was a lot more complex than I would have liked, but now that I've already done the work it seems reasonable to include this. However I don't think there's anything left to do if this doesn't do the job.
I'd appreciate some feedback if this works for you, I've marked it to close this PR so let me know if it still doesn't help.

@chrisduerr fixes it entirely on my laptop.
Can't verify on my office system (not being in the office or anything), but I doubt it'd be any different.
Tried to build on my windows setup, but the build fails (not alacritty's fault, I think my rust setup is broken there).
I'll comment here if I run into further problems on either of the remaining two systems above.
If you don't hear from me it's because this UX issue is solved (at least on my end)!
P.S. I would have preferred if there was a simpler solution as well, but UX problems are pretty important in terminal emulators :/


Travis builds currently fail with python 3.5

Travis builds currently fail with python 3.5 because scipy 1.5 is used (instead of 1.3.x or 1.4.x).
This issue is addressed in PR #842.

PR #842 has been merged, closing this issue.