Add files via upload

PR Description
Interactivity issues resolved.
Add your description
I have corrected the header and footer of the website. I have also created a favicon icon, which is the logo of the website near the title of the page. Also, i have corrected the positioning of the looping video in the right side which was interefering with the alignment of the navbar. Also i have added spaces between all the logos and the names of button in the navbar. And some other aligning here and there have also been rectified.
Issue
#17  Interactivity based on design
Checklist

[✔ ] I have gone through the [contributing guide](## PR Description

Add your description
Related Issues: Issue for which you are raising a PR for

Closes #

Issue
[Issue number or description]
Checklist

[✔ ] I have gone through the contributing guide
[ ✔] I have updated my branch and synced it with project main branch before making this PR
[ ✔] Is this a bug fix/enhancement/documentation changes

Undertaking
I declare that:

The content I am submitting is original and has not been plagiarized.
No portion of the work has been copied from any other source without proper attribution.
The work has been checked for plagiarism, and I assure its authenticity.

[✔ ] I have updated my branch and synced it with project main branch before making this PR
[ ✔] Is this a bug fix/enhancement/documentation changes
[ ✔] Part of GSSOC
[ ✔] Tested for any breaking changes
[ ✔] Other relevant checks completed

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

[✔ ] I Agree

@varshith257 Actually i have just changed 2-3 files but my code editor just formatted some other files as well basically their alignment but their content is still as it was there in original files you can check as well. So what should i do in this case?

@varshith257 Kindy respond to my previous message. I am waiting for the next step :)


Singleton

If you made this object singleton, you could just do: SimpleMySQLi::query();
P.S. Thy not PDO?

Hey, thanks for your interest and suggestion. I've strongly considered that actually, but I think I prefer it as is.
I chose MySQLi to utilize some of its MySQL-specific features. For instance, you can get more info on queries. This is useful when you update a row with the same value. There's also proper methods for freeing and closing the statement/connection (Read this for the issue with closing the connection). I also would like to add async MySQL, as soon as they add prepared statements support.
But I would certainly be glad to maintain a PDO version in addition if there's any interest.


Fix simplify bug

Switch equals minus to minus equals

Are we okay with just merging small bug fixes like this without review at this stage?

For sure just merge unless feedback might help design/algorithm


[Spanish] Updated es.json with the latest strings from master.

I created a development environment and I ran:
npx laravel-language-extractor --theme default
And:

Translated the new added strings from the master branch.
Made a few fixes.

To the es.json file.

I'm creating another pull request with these fixes + solution for settings tabs translation


chore(deps): update memfs to the latest release

v3.2.2

We need fix CI problem, can you look at that?

Not sure why the pretter:lint script is failing.

Can you try to run prettier on code?

#159


[ARCTIC-761][WIP] update site docs of v0.4 with overview and concepts

Resolve #761
Brief change log

update Overview page
add Concepts dir and Catalogs, Table formats, Self-optimizing and Table watermark page in it
replace Table Properties page under Meta Service dir with Configurations page on top
remove Table formats dir
remove Meta Service dir (would be repaced by Admin Guide
modify name of Flink/Spark/Trino to Flink Integrations.etc
modify name of How to contribute to Contributing

@majin1102 I left some comments.

all comfirmed, plz check

@majin1102 I left some comments.

all comfirmed, plz check

You may want to remove the [WIP] tag from the PR's title if you are ready to merge this PR.


Enable AlmaLinux Acceptance testing

This will require a new beaker-hostgenerator release. I tested this in https://github.com/voxpupuli/puppet-yum/pull/290. Also contains https://github.com/voxpupuli/puppet_metadata/pull/69

maybe we should label it backwards-incompatible because it might spawn more CI jobs.

@smortex the problem we discussed on slack: Assume someone has alma and rocky 8 and 9 in their metadata.json and support puppet 6 and 7. When we merge #70 and #69, that means we spawn 8 additional CI jobs. Vox Pupuli has sponsoring and that's not a problem for us, but it could surprise other users and their environment. Because of that, we could make this a major release and hope that people won't update without checking the changelog (if they do, it's really their fault).


Intellisense

Issue Type: Bug
I work on both front-end and back-end technologies which are React, React-native and Node.js I have observed that many times intellisense stops working and sometimes i restart my vs code then suggestions again starts coming while coding but that too only happens only sometimes other than node.js for html and css intellisense works great. Please look into it. Other than that you have built a great software guys. I am amazed by the things vs code can do. For any language and every language.
Thanks
Narottam Singh
Software Engineer from India
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T15:04:31.999Z)
OS version: Linux x64 5.3.0-26-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz (4 x 3216)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
11.63GB (2.93GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.0.15

Closing as not actionable without more info from @narottamsingh-jft


ineffective canonicalization of intersections affects subtyping

In addToIntersection(), an effort is made to "skip" types that are supertypes of the intersection of the previously considered types, even if the type being considered is not a supertype of any previously considered type.
For example, if we have:
    interface ListOfA satisfies List<A> {}
    interface ListOfB satisfies List<B> {}

the type List<A&B> is redundant to ListA & ListB, even though it is not redundant to either ListA or ListB.
addToIntersection() works well for ListA & ListB & List<A&B>, simplifying it to ListA & ListB.
However, it does not consider the possibility that the addition of a type to the intersection may make a previously considered type redundant! So, ListA & List<A&B> & ListB is not simplified. List<A&B> is not re-considered after the ListB is added.
Existing tests can be adjusted to fail due to this issue:
    Inv<A&B&Co<A&B>> foo1(Inv<A&B> inv) => inv; // existing test
    Inv<A&Co<A&B>&B> foo3(Inv<A&B> inv) => inv; // new failing test
    ...
    Inv<C&D&Contra<C|D>> foo2(Inv<C&D> inv) => inv; // existing test
    Inv<C&Contra<C|D>&D> foo4(Inv<C&D> inv) => inv; // new failing test

It's not immediately obvious to me that this is a big deal. Perhaps we could even just comment out the ineffective code until a reasonable workaround can be found.

Perhaps it really wouldn't be too expensive to simply perform all of the necessary checks by 1) deferring the tests until all intersected types are collected and then 2) checking each intersected type against all of the others.
Currently, for an intersection with 10 components, 9 checks are performed against intersections with an average of 5 components, assuming no redundancies are found.
If the checks were deferred until all components were available, there would be 9 checks against intersections with 9 components, assuming no redundancies are found.
If important, perhaps there are some optimization opportunities too, such as gathering lists of generic supertype declarations for each component type, and for each candidate redundancy, only consider other intersection components that inherit one or more of the candidate's generic supertypes.


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/mxcl/homebrew
https://github.com/Homebrew/homebrew

HTTPS Corrected URLs

Was
Now

http://www.rust-lang.org/
https://www.rust-lang.org/

Rebased and pushes.


Migrate to the sitrep system

For reference workflow, refer to the 'Opt-in guide' section of #222.
The tasks of adding sitrep generation (opt-in guide step 1), need to be done independently for the following reusable workflows:

[ ] base container build
[ ] JAX core container build
[ ] upstream T5X container build
[ ] upstream PAX container build
[ ] Rosetta containers build
[ ] T5X MGMN tests
[ ] PAX MGMN tests
[ ] TE tests
[ ] Rosetta tests

The task of adding job summary and badge upload (opt-in guide step 2), need to be done independently for the following public-facing workflows:

[ ] CI
[ ] Weekly base build
[ ] Nightly JAX build
[ ] Nightly T5X build
[ ] Nightly PAX build
[ ] Nightly Rosetta builds: PAX, T5X build + test
[ ] Nightly TE test

/assistant rewrite the task lists above with more context so that each line is self-contained and is suitable as a standalone issue title


Macro call to open window for current user not working

If I try to call .sendUrl() using a userList, the call just does nothing and also logs no errors to the browser console. If I remove the userList argument completely, the call works but obviously opens the window for all users.

Foundry Virtual Tabletop version 9, build 238
System: "3.5e SRD" version 0.98.9
The only two modules active are "Inline Webviewer" and "lib - Color Settings".
What am I doing wrong here?

ah, v9 removed a value that was being read to check if the sender of the api method also needed to have the webview open. Fix coming right away!


PR feedback, make more strict FP adoption

I hope the fish operator is the right semantics in here. I think it is when we extend the understanding that KeyPath is just a syntactic sugar for (A) -> B?, which we are flatMapping to (B) -> C?. Then it's a >=> over Optional Monad. Can't think about KeyPath as a Monad itself because I can't create a KeyPath with custom init, it has internal use only in Swift. So thinking about it as a Prism Getter, that composition using >=> would make sense.
Also removed the second variant with a hardcoded C that ignores B, in favour of keyPath >=> (ignore >>> hardcodedDerivedAction), which looks more correct from the composition point-of-view.
The options without custom operator are now public anyway, for those who don't like the chosen custom operators, or any custom operator at all.


Fix #64253 - Support ~/ paths for typescript.tsdk

@mjbvz , Here is an implementation based on the inputs you gave to fix #64253 .
Please review this and let me know if anything needs to be changed :)
Thanks!

Thanks!


Merging with kraken?

Is there any plan to merge ocropy with its fork kraken?
Having two "ocropy"s is kinda confusing :)

This is really up to @tmbdev and @mittagessen to answer from a main developer's perspective but from my perspective, merging Ocropy and Kraken is not that important, but interoperability.
I think it's amazing what @mittagessen has created in terms of clean interfaces, documentation, forward compatibility and smart handling of models. I would really love to see Kraken's compact model serialization and repository features integrated into Ocropus.
On the other hand, Ocropus has seen so many iterations and produced so many tools (if you consider the code in OLD, clstm, hocr-tools...) with so many configuration options that I find new features all the time. But it has not been steadily maintained and keeping everything running and fixing bugs is a lot of effort.
So, for me it would be a more realistic goal to make interoperable/document the training mechanisms, model serializations and exchange formats.

I think it's amazing what @mittagessen has created in terms of clean interfaces, documentation, forward compatibility and smart handling of models.

Totally agree.
:+1:  +1: +1: +1: +1: for @mittagessen
One important feature that he added is built-in RTL support (for languages like Arabic and Hebrew).

I wasn't planning on changing ocropy much at this point. To me, ocropy is a collection of basic reference implementations of the most important steps in OCR.
I hope I'll have more time to work on document analysis, and my plan was to develop trainable versions of nlseg, gpageseg, language modeling, and logical layout analysis using GPUs and newer deep  models. These will simply be separate projects and otherwise work like the existing command line versions.

Tom, thanks for giving us ocropy / clstm !

I was working on creating shims for most ocropus-* tools early during development but quickly came to my senses and by now quite a bit of code was removed (1800 vs 5300 SLOCs excluding OLD). Porting everything from ocropy to kraken or separating all the logic in ocropy's command line drivers into a true library will IMO not have any major benefit. So there's agreement from my side to treat ocropy just an essentially fixed collection of reference implementations with sometimes quirky command line interfaces (no offense).
As most of the functionality is still the same and will probably stay there for a while adapting patches will be possible with minimal effort. The only exception is page segmentation which is high on my list of things to get rid of in favor of something better and trainable, albeit I'd really like to keep everything at least marginally workable on CPUs. Even then keeping the old implementation around won't cause much harm.

@tmbdev, @mittagessen  Can you recommend some papers on logical layout analysis with deep models? I'd love to play around with that :-)


Running GO_SLAM on Set of RGB Images

Hello,
First I really want to thank the GO-SLAM team for making this open source - its a fascinating thing you've all built here.
I am curious on how I could run GO-SLAM on a set of images inside of a folder - my main question is why it seems as though I need a set of depth images in the dataset.py file. Any suggestions would be very helpful.
Best,
Andrew

Nvm.
class Custom(BaseDataset):
def init(self, cfg, args, device='cuda:0'):
super(SiteWalk, self).init(cfg, args, device)
self.input_folder = os.path.join(self.input_folder)
self.color_paths = sorted(
glob.glob(os.path.join(self.input_folder, '*.jpg')))
self.depth_paths = None
self.n_img = len(self.color_paths)
self.load_poses(os.path.join(self.input_folder, 'trajectories'))
print("INFO: {} images got!".format(self.n_img))
def load_poses(self, path):
    # So here we provide identity matrix as proxy.
    # But it will not affect the calculation of ATE since camera trajectories can be aligned.
    self.poses = None


Final

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 49.32432% with 75 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (ab5deda) to head (b489a10).

Files
Patch %
Lines

src/action_rules/action_rules.py
53.53%
38 Missing and 8 partials :warning:

src/action_rules/candidates/candidate_generator.py
29.41%
22 Missing and 2 partials :warning:

src/action_rules/rules/rules.py
64.28%
3 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (ab5deda) and HEAD (b489a10). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (ab5deda)
HEAD (b489a10)

12
6

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
- Coverage   84.31%   68.64%   -15.67%
===========================================
  Files          11       11
  Lines         357      472      +115
  Branches       81      102       +21
===========================================
+ Hits          301      324       +23
- Misses         30      112       +82
- Partials       26       36       +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[FR] – add config setting to allow define FQDNs traffic to be captured

often times the actual hosts ( IPv4 or IPv6 ) traffic to be captured is not known,
all what's known is the FQDN ( i/e: storage.googleapis.com ), so it would be useful
to have a simpler way to hydrate the PCAP_FILTER with all IPs returned by a DNS lookup.

Proposed environment variable name is: PCAP_HOSTS
Proposed environment variable value is: comma separated list of FQDNs to be captured.
Proposed way of operation: all IPs resolved should be ORed agains each other, and ANDed with PCAP_FILTER

see pcap-cli:

https://github.com/gchux/pcap-cli/blob/v1.0.0-rc115/pkg/pcap/pcap.go#L16-L26
https://github.com/gchux/pcap-cli/blob/v1.0.0-rc115/pkg/pcap/pcap.go#L42

provides interface definitions for whatever filters need to be implemented;
it also includes a provider method to have all filters applied to the original BPF filter:

https://github.com/gchux/pcap-cli/blob/v1.0.0-rc115/pkg/pcap/pcap.go#L80-L95
which is used by both:

gopacket engine: https://github.com/gchux/pcap-cli/blob/v1.0.0-rc115/pkg/pcap/gopacket_engine.go#L89
tcpdump engine: https://github.com/gchux/pcap-cli/blob/v1.0.0-rc115/pkg/pcap/tcpdump_engine.go#L42

see commit: https://github.com/gchux/cloud-run-tcpdump/commit/0fde55e4f490af0404057265968055fad7979220
filter implementation: https://github.com/gchux/cloud-run-tcpdump/blob/ft/simple-filters/tcpdumpw/pkg/filter/dns_provider.go

tcpdumpw is hosting the code to implement filters ( as many as we want and can imagine )
and it provides a chain of filters that will be applied by all PCAP engines ( all use the same chain, so the chain is a singleton ):

see: https://github.com/gchux/cloud-run-tcpdump/blob/ft/simple-filters/tcpdumpw/main.go#L478-L480

All PCAP engines will create the filter on each execution so for this filter if the DNS mappings change in any of the scheduled executions, then all PCAP engines will produce updated filters to match the current state.
The new tcpdump flag for this filter is hosts which accepts a comma separated list of FQDNs.
Here how it looks in action:


Optional bonsai fields

Make measurement (height, width, nebari) and style fields optional.
Make minor updates to upload form. Namely: redirect the user if they are not authenticated, and use the actual username from the authContext in the upload process, instead of dummy data. To facilitate this, the User interface was updated (factored out, more like) into PartialUser and FullUser. Partial user works with the data that the backend provides on authentication (username, profile photo). This serves most needs. All, in fact—until we implement user pages and user settings pages which require full user objects.

Will look when I get home


maxEntries not working

The following creates the desired cache, but the maxEntries limit is not enforced.  The cache grows indefinitely:
runtimeCaching: [{
	urlPattern: /\/images\/.*/,
	options: {
		cache: {
			name: "images",
			maxEntries: 5
		}
	}
}];

I'm using sw-precache 4.1.0.

I think the issue is that you're not defining a handler. You can see an example of a valid configuration at https://github.com/GoogleChrome/sw-precache/blob/master/app-shell-demo/gulpfile.babel.js#L149
(Using handler: 'cacheFirst' is normally a good idea for this type of cache, if you know that the image at a given URL is unlikely to ever change.)
Apologies that this ends up being a "silent" failure. That's something we're hoping to improve in the next generation of this tooling.

Hmm... I'm pretty sure I was defining a handler and just left that out of the snippet in the report. You might want to check that it works with a handler defined. I'll have a look later as well.

You can see it working by visiting a few items under https://ifixit-pwa.appspot.com/ and then taking a look at the image-cache contents in the Applications tab of Chrome's DevTools. They should max out at 50 entries:

That's using a config from https://github.com/GoogleChrome/sw-precache/blob/master/app-shell-demo/gulpfile.babel.js#L147
If you have a public site with a deployed service worker that's not behaving as expected, could you pass along the URL?

After some digging, I found the problem was my fault.  I overrode the networkFirst handler to add in some custom logic and wound up ignoring some of the options.  False alarm.  I'm sorry about that.


moco encodes the resposne text by default charset, how can I force it to use utf8?

It seems moco encodes the resposne text by default charset. How can I force it to use utf8?

@ratlsun I found a encoding bug in Moco, which is related to response. Moco uses byte array as interface, but in the implementation, it converts byte array to string which could lose encoding information. I've already rewritten this part to fix that. Check out the latest code. This fix will be in next release.

Today I also encountered this problem by v0.10.2 standalone jar, so I submitted a new issue #133.


Updates in setting controller issue & enables tab command with lower case

adds skeleton controller file for respective window. - 778b6e8
refactored tab command validation to TabCommandParser class. - 38ac7d1

Tab command now enabled with lower case. e.g. tab Calendar -> tab calendar
Feel free to modify your respective skeleton controller class. Refer to TabCommandParser.java

resolves #45


jdk-19 RampDownPhase1 June 9th - Forks from mainline - New mirror & build pipeline jobs required

https://openjdk.java.net/projects/jdk/19/
RDP1 June 9th
We will need to:

Create git-skara-jdk19 mirror
Generate jdk19 build jobs
Update openjdk19-pipeline to build jdk19
Add openjdk20-pipeline
Add https://github.com/adoptium/temurin20-binaries

@andrew-m-leonard Just looking through the june milestone stuff ... I thought this was mostly complete although there's no temurin20-binaries repo yet - is that still a WIP?

@andrew-m-leonard Just looking through the june milestone stuff ... I thought this was mostly complete although there's no temurin20-binaries repo yet - is that still a WIP?

Ah that would be because I forgot about that ! thanks

Wiki doc: https://github.com/adoptium/temurin-build/wiki/Setting-up-new-build-jobs,-mirrors,...-when-a-new-openjdk-version-is-branched-from-jdk(head)

Refactor for release job needs jdk20 support:
20:14:13  Scheduling project: [build-scripts » release » refactor_openjdk_release_tool](https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] End of Pipeline
ERROR: Value for choice parameter 'VERSION' is 'jdk20', but valid choices are [jdk19, jdk18, jdk17, jdk16, jdk11, jdk8]
Finished: FAILURE


[flake8-pyi]: add rules for unrecognized platform check (PYI007, PYI008)

Add two flake8-pyi rules (Y007, Y008). ref: #848
The specifications are described in PEP 484 - Version and platform checking
The original implementation in flake8-pyi is shown below.

Implemention: https://github.com/PyCQA/flake8-pyi/blob/66f28a4407af2156f95d370941fae4dd98280740/pyi.py#L1429-L1443
Tests: https://github.com/PyCQA/flake8-pyi/blob/66f28a4407af2156f95d370941fae4dd98280740/tests/sysplatform.pyi

This looks like really good and thorough work. Before merging: is there any overlap between these rules and those we enforce via flake8-2020 (e.g., in crates/ruff/resources/test/fixtures/flake8_2020)?

I don't think there's any overlap between them. They have different motivations.
The flake8-2020 is mainly used to ensure that no errors occur when comparing with sys.version_info at runtime.
The flake8-pyi(Y002-Y008) is mainly used to ensure that the comparison statements with sys.version_info/sys.platform is simple enough, and thus ensure that the type checker can correctly distinguish version/platform specific behaviour.


dismantle cb leads to releasing capital core provinces

also fix color of CSA.

also remove "remove cores" on loosing.


Undefined behavior sanitizer

/cc @dot-asm

I personally would insist on adding no-asm to sanitized builds... Well, "insist" doesn't mean that I try to set a roadblock, it only means that we need one more person to look at arguments (mine being maximizing exposure of C to sanitizer) and express 3rd opinion.

I totally agree with @dot-asm: use no-asm for sanitized builds.

Do we assume no sanitiser can touch assembler? Seems unwise.
In general, shouldn't we have a variety of builds that are required to pass?

Sanitizer remains oblivious of code not compiled with -fsanitize, naturally including assembly. Therefore using assembly in sanitized builds would mask potential problems on platforms other than x86, because they tend to rely on C more. More C code you expose to sanitizer is better.

In general, shouldn't we have a variety of builds that are required to pass?

??? There is whole bunch of tests, several compilers, different configurations, linux and mingw, now with sanitizer, all are required to pass. Well, what's "required" really? In the context it means that failure to pass either should be treated as something to fix...

@dot-asm I built with sanitizers and no-asm and a new problem was found:
wp_block.c:595:16: runtime error: load of misaligned address 0x0000008309e7 for type 'u64', which requires 8 byte alignment

I'm not quite sure how that's supposed to be fixed though.
I'm also going to add "normal" (without sanitizers) no-asm builds to Travis (it doesn't hurt I guess), but right now I can't push to GitHub (ssh times out...)

It seems that the STRICT_ALIGNMENT macro can be defined to get a set of code that is supposed to avoid unaligned accesses such as these (though on x86 they do not generate SIGBUS).  That said, a quick reading of the code seems like it should still produce a 32-bit aligned access (where 64-bit alignment is formally required), which is incongruent with the sanitizer output claiming the accessed address ends in 7.

... STRICT_ALIGNMENT macro can be defined ...

Right. We need that macro defined in sanitized builds. In other similar cases PEDANTIC macro was used to achieve this. While one can argue if it's best choice I'd suggest to use it even here. Because if we decide to switch to something else later, then we'll know that PEDANTIC would be the only thing we have to look for. To preclude confusion. In wp_block.c there is #define STRICT_ALIGNMENT following be conditional #undef. The condition needs to be modified so that macro in question is not undefined if PEDANTIC is defined.

a quick reading of the code seems like it should still produce a 32-bit aligned access (where 64-bit alignment is formally required),

??? Where?

There seems to be some problems when defining STRICT_ALIGNMENT from ./config for wp_block.c. It also ignores the no-asm configuration for the ROTATE() macro, which makes the build fail due to the use of the ({ }) construct.
I made a patch that fixes both these issues, but I can't push to GitHub right now so I'll post it below:
diff --git a/crypto/whrlpool/wp_block.c b/crypto/whrlpool/wp_block.c
index 7baca60..0f02e8c 100644
--- a/crypto/whrlpool/wp_block.c
+++ b/crypto/whrlpool/wp_block.c
@@ -49,16 +49,15 @@ typedef unsigned long long u64;

 #define ROUNDS  10

-#define STRICT_ALIGNMENT
-#if defined(__i386) || defined(__i386__) || \
-    defined(__x86_64) || defined(__x86_64__) || \
-    defined(_M_IX86) || defined(_M_AMD64) || defined(_M_X64)
+#if !defined(__i386) && !defined(__i386__) && \
+    !defined(__x86_64) && !defined(__x86_64__) && \
+    !defined(_M_IX86) && !defined(_M_AMD64) && !defined(_M_X64)
 /*
  * Well, formally there're couple of other architectures, which permit
  * unaligned loads, specifically those not crossing cache lines, IA-64 and
  * PowerPC...
  */
-# undef STRICT_ALIGNMENT
+# define STRICT_ALIGNMENT
 #endif

 #undef SMALL_REGISTER_BANK
@@ -82,17 +81,18 @@ typedef unsigned long long u64;
 #endif

 #undef ROTATE
-#if defined(_MSC_VER)
-# if defined(_WIN64)            /* applies to both IA-64 and AMD64 */
-#  pragma intrinsic(_rotl64)
-#  define ROTATE(a,n) _rotl64((a),n)
-# endif
-#elif defined(__GNUC__) && __GNUC__>=2
-# if defined(__x86_64) || defined(__x86_64__)
-#  if defined(L_ENDIAN)
-#   define ROTATE(a,n)       ({ u64 ret; asm ("rolq %1,%0"   \
+#if !defined(OPENSSL_NO_ASM)
+# if defined(_MSC_VER)
+#  if defined(_WIN64)            /* applies to both IA-64 and AMD64 */
+#   pragma intrinsic(_rotl64)
+#   define ROTATE(a,n) _rotl64((a),n)
+#  endif
+# elif defined(__GNUC__) && __GNUC__>=2
+#  if defined(__x86_64) || defined(__x86_64__)
+#   if defined(L_ENDIAN)
+#    define ROTATE(a,n)       ({ u64 ret; asm ("rolq %1,%0"   \
                                    : "=r"(ret) : "J"(n),"0"(a) : "cc"); ret; })
-#  elif defined(B_ENDIAN)
+#   elif defined(B_ENDIAN)
        /*
         * Most will argue that x86_64 is always little-endian. Well, yes, but
         * then we have stratus.com who has modified gcc to "emulate"
@@ -100,16 +100,17 @@ typedef unsigned long long u64;
         * won't do same for x86_64? Naturally no. And this line is waiting
         * ready for that brave soul:-)
         */
-#   define ROTATE(a,n)       ({ u64 ret; asm ("rorq %1,%0"   \
+#    define ROTATE(a,n)       ({ u64 ret; asm ("rorq %1,%0"   \
                                    : "=r"(ret) : "J"(n),"0"(a) : "cc"); ret; })
-#  endif
-# elif defined(__ia64) || defined(__ia64__)
-#  if defined(L_ENDIAN)
-#   define ROTATE(a,n)       ({ u64 ret; asm ("shrp %0=%1,%1,%2"     \
+#   endif
+#  elif defined(__ia64) || defined(__ia64__)
+#   if defined(L_ENDIAN)
+#    define ROTATE(a,n)       ({ u64 ret; asm ("shrp %0=%1,%1,%2"     \
                                    : "=r"(ret) : "r"(a),"M"(64-(n))); ret; })
-#  elif defined(B_ENDIAN)
-#   define ROTATE(a,n)       ({ u64 ret; asm ("shrp %0=%1,%1,%2"     \
+#   elif defined(B_ENDIAN)
+#    define ROTATE(a,n)       ({ u64 ret; asm ("shrp %0=%1,%1,%2"     \
                                    : "=r"(ret) : "r"(a),"M"(n)); ret; })
+#   endif
 #  endif
 # endif
 #endif

a quick reading of the code seems like it should still produce a 32-bit aligned access (where 64-bit alignment is formally required),

??? Where?

In the non-STRICT_ALIGNMENT case, we get
189 # define C1(K,i)       (((u64*)(Cx.c+7))[2*K.c[(i)*8+1]])

which is casting some other quantity to pointer-to-64-bit.  Looking more carefully, I don't see why the pointer is appropriate; it seems like the expected output is just a 64-bit number, and also the "some other quantity" involves accesses to the character-array branch of the unions, which could easily have other-than-32-bit alignment.  The pointer had confused me in my too-quick reading, it seems.

It also ignores the no-asm configuration for the ROTATE() macro, which makes the build fail due to the use of the ({ }) construct.

Er, how is no-asm relevant for the ({}) construct, a gcc extension [also adopted by clang?]?  I thought the GNUC conditionals would catch such things.

Er, how is no-asm relevant for the ({}) construct

The problem is that it causes a warning which is treated as error due to -Werror. It also uses inline assembly despite the no-asm (but that's a separate problem).
Anyway, I pushed my whirlpool patch and also another fix for a warning in mem_clr.c, and the build is now green. The whirlpool patch is quite ugly, so if you have any alternative suggestion I'm all ears.

@dot-asm I replaced my whrlpool patch with yours, and the build is still green!

As I've got involved on level of contributing code, it's probably more appropriate is somebody else approves it.

Makes sense for another reviewer.
+1

+1

So what is the status of this?

Applied. Closing...


Bug: warning about never used value of connect function

Godot version:
3.1.1, stable official
OS/device including version:
Windows 8.1
Issue description:

I think it's self-explaining: This warning shouldn't appear in such circumstances
Steps to reproduce:
I had saved it as:
func _ready():
connect("pointed", self, "coord_maker", [second_ID, second_coord])
pass
At the moment this warning was correctly because those variables weren't used. But after some coding i realised i don't need to return it via connect(). So i had:
func _ready():
connect("pointed", self, "coord_maker")
pass
I saved it and worked on. After a while i spotted it still remains.
I had asked about it on Godot's Discord but they were suprised as well. I shared the code but this warning didn't show up to them.
Minimal reproduction project:
Punkt1.zip

It's about return value of connect, not arguments. See this comment: https://github.com/godotengine/godot/issues/27576#issuecomment-478683871
Is there anything more to the topic than already discussed in linked issue?

I shared the code but this warning didn't show up to them.

If they didn't try it on clean project, they most likely disabled this warning.

I wasn't sure if i'm not missing something and that's it

Is there anything more to the topic than already discussed in linked issue?
I don't think so, thank you for help


Add method to client to disconnect a QB account

The client now has a way of disconnecting a Quickbooks Account.
This is required for almost all Quickbooks applications. References here: https://developer.intuit.com/docs/0050_quickbooks_api/0020_authentication_and_authorization/oauth_management_api#/Disconnect

Coverage increased (+0.002%) to 99.06% when pulling 2e489b995d9d05d72391080ebdc37b3789f1d7c5 on pennypacker-labs:disconnect into 63c7c6a02258fade041cc28206c41b766599a9d0 on sidecars:master.


dropping node 4.x

node 4.0 is end of service
will drop node 4.0
ensure support of node 8  (and or node 10) on top of node 6
please update engine in package.json
"engines": {
   "node": ">=0.12.0"
 },

@jtary PTAL


rm: Add details for Google Artifact Registry

Signed-off-by: Andy Doan<EMAIL_ADDRESS>

@kprosise @mike-sul - I'm still investigating what's possible for the device side use of GAR. It will wind up either having a blurb like we do for AWS or Azure - just have to confirm what's possible

Docs for 46465b8d79d2904afb88dbc699e308bf427a3451 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1433/docs/artifacts/html/index.html

I'm hedging my bets here - I have a support question with GCP, but I think this is going to be our answer for device access.

Docs for 38bbad8387a36f05235b8c3af3bc0a0b1cc5e00e are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1434/docs/artifacts/html/index.html

@kprosise - i ran the steps outlined in this document in andy-corp to product this build - https://app.foundries.io/factories/andy-corp/targets/204/artifacts/build-amd64-partner/console.log

@doanac you can merge when ready!


[#4955] Fix: Handle the no agent case in main page

Hide realtime template
Remove server map

Codecov Report

Merging #4956 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4956      +/-   ##
==========================================
- Coverage   40.87%   40.85%   -0.02%
==========================================
  Files        2642     2642
  Lines       79207    79207
  Branches    10707    10707
==========================================
- Hits        32374    32361      -13
- Misses      43908    43919      +11
- Partials     2925     2927       +2

Impacted Files
Coverage Δ

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

...or/metric/response/ReuseResponseTimeCollector.java
77.19% <0%> (-3.51%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
65.51% <0%> (-3.45%)
:arrow_down:

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
71.01% <0%> (-1.28%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.81% <0%> (-1.05%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
83.58% <0%> (+2.98%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74e418...0393573. Read the comment docs.


@/charterafrica YouTube integration

Description
In order to build the consultation tool, we need ability to pull videos/audios from YouTube with their comments.
The task is to do a quick investigation to figure out what is the best way to go about this:

Does video embed include comments?
If not, how can you pull comments given a video id or url?
What is the best way of pulling multiple videos/audios? Example could be pulling from a playlist, or a channel, etc.

 (Please see Figma for any design updates).

cc @kelvinkipruto , @koechkevin

here is a document link to implementation plan.
We may need to make use of Google API to achieve desired goal.
cc @kilemensi @kelvinkipruto


How to hide customer phone number in Agent CCP screen on Amazon connect

I want to hide the customer phone number like XXXX and in fact only show last 4 digits of the customer number in the agent screen. This is for the security purpose. If they need to call them back they can dial from the list of calls they received from the call list XXXXXXX (last four digits)

If you just want to hide the numbers on the frontend, you can use javascript to programmatically set the numbers to "XXXXXXXXXX" upon a call coming in

I'm closing this issue, please feel free to reopen, or open a new one if your question is still unanswered.


Linux X11: cannot paste between two separate gogi apps

works fine within same app, but not between apps.  event stuff looked similar when sending clip to emacs vs. to other gi app (all with gide textview) -- emacs had no problem..  really not sure what the issue is.  error message is timeout.

check now with glfw 3.3

This still happens.


Where can I set environment variable for test from codelens?

I try to run unittest with codelens. If I run unittest from vscode I could write test command in tasks.json to set env variable that will execute on launch. Is there equivalence functionality for pressing codelens command?

@Thaina Unfortunately, I don't think that's currently possible.

@rchande Did your unittest command or nuget itself would read some config file in the project that contain env var and/or other config on their own?
Another thing I would like is to set output file. If it not possible would you pleased to include in that config file feature?

You can configure a .runsettings file to be used when running your unit tests. In the .runsettings file you can configure environment variables. See https://learn.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#specify-environment-variables-in-the-runsettings-file


F1.4.2 The service shall restrict access to all admin functions only to users with admin roles.

Admin functions include user management and question management


clarify "simple vs easy"

In the "simple vs easy" graph, I think "simple" and "easy" can be clarified.  maybe "quick and dirty" and "elegant" or something?  I instinctively knew what this was supposed to say, but still had to think of what the words meant (in part because I was tired)

To add to this, label the regions.  E.g.

set up git (left side of simple)  --> automated testing, fast development (right of simple)
no git (left of easy)  --> impossible to debug (right side of easy)

I can add to that, that the graph is a bit confusing and can use some rework.

I plan to rework that. All suggestions welcome. In particular what the confusing part is but I guess the point is that the graph is not self-explaining enough.

Mainly: "simple" and "easy" both sound like good things.  It's not clear that "easy" means "quick hacks" or "simple" means "take the time to implement it properly".


Error after disabling settings sync

Was verifying an issue

Disabled settings sync
Reenabled it but on the Stable service
Changed profiles a few times
Disabled Settings sync

Got an error poupup, here is the stack from the window log
[2022-09-30 12:06:10.032] [renderer1] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: h.with is not a function
    at u.C [as toUserDataSyncError] (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:808:40284)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:110971
    at async w.getRemoteSyncResourceHandles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:112541)
    at async vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:49047
    at async Promise.all (index 0)
    at async N.getRoots (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47536)
    at async N.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47035)
    at async Object.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3018:7181)
[2022-09-30 12:06:10.053] [renderer1] [error] h.with is not a function: Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: h.with is not a function
    at u.C [as toUserDataSyncError] (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:808:40284)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:110971
    at async w.getRemoteSyncResourceHandles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:112541)
    at async vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:49047
    at async Promise.all (index 0)
    at async N.getRoots (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47536)
    at async N.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47035)
    at async Object.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3018:7181)
[2022-09-30 12:06:10.233] [renderer1] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: h.with is not a function
    at u.C [as toUserDataSyncError] (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:808:40284)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:110971
    at async w.getRemoteSyncResourceHandles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:815:112541)
    at async vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:49047
    at async Promise.all (index 0)
    at async N.getRoots (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47536)
    at async N.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3145:47035)
    at async Object.getChildren (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3018:7181)

[2022-09-30 12:06:05.402] [settingssync] [info] Auto Sync: Triggered by Activity
[2022-09-30 12:06:05.402] [settingssync] [info] Sync started.
[2022-09-30 12:06:05.501] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2022-09-30 12:06:05.538] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2022-09-30 12:06:05.548] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2022-09-30 12:06:05.554] [settingssync] [info] Tasks: No changes found during synchronizing tasks.
[2022-09-30 12:06:05.809] [settingssync] [info] GlobalState: Updated remote ui state
[2022-09-30 12:06:05.874] [settingssync] [info] GlobalState: Updated last synchronized ui state
[2022-09-30 12:06:06.061] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2022-09-30 12:06:06.066] [settingssync] [info] Sync done. Took 669ms
[2022-09-30 12:06:10.014] [settingssync] [info] Auto Sync: Disabled.
[2022-09-30 12:06:10.014] [settingssync] [info] Auto Sync: Stopped
[2022-09-30 12:06:10.027] [settingssync] [info] Did reset the local sync state.

Do you have settings sync views enabled?

@roblourens Can you please verify this on latest insiders?


SVG don't rendering in converted file

When converting from md to pdf it don't render svg files.
Only text in the file:
[[ file_name.svg ]]

hello, the  syntax [[xx]] is not common mark, and is supported by obsidian only,  please use ![](url) instead.


Add language name as data-attribute

Allows displaying highlight language name as a hint, e.g.:
pre[class*="language-"]::before {
  content:attr(data-language-name);
  display: inline-block;
  position: absolute;
  top: 0;
  right: 0;
  padding: 4px 10px 2px;
  background-color: #e6e6e6;
  border-bottom: 1px solid #dddddd;
  border-left: 1px solid #dddddd;
  border-bottom-left-radius: 6px;
  font-size: 0.75em;
}

results in:

Not sure this is possible to inject as an "advanced option" instead, as preAttributes only allows static attributes.

Rather than a hardcoded option here, we are shipping #50 that will allow you to specify your own callbacks for any attribute name!

You’ll want something like this to replicate what you have in this PR:
preAttributes: {
  "data-language-name": ({language}) => language
}

Great, thank you!


Add pod annotations support

@vvbogdanov87 Thanks for writing this PR. I took a glance and it looks good to me. Let's see if travis happy with it. And then I think I can merge this in.


Write a Ruby program to convert string to titlecase

Description
Write a Ruby program to convert string to titlecase
Titlecase is a style of writing in which the first letter of each word is capitalized.
Input  : "hello world"
Output : "Hello World"

How to contribute

Save the solution in program/ConvertStringToTitlecase.rb file
Add ConvertStringToTitlecase.rb file in convert-string-to-titlecase folder

!assign


Invalid value for "audience"

TL;DR
OAuth token is not created because audience is null. I think...
Expected behavior
The OAuth token is created with the correct audience, short lived access tokens are created and authentication works as expected.
Observed behavior
I get the error below in my action. This happens when I hard code the audience to the default URL, when I set it as a secret and when I use a custom value in the pool and the matching value.
google-github-actions/auth failed with: retry function failed with 0 attempts: failed to generate Google Cloud federated token for ${ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }: {"error":"invalid_request","error_description":"Invalid value for \"audience\". This value should be the full resource name of the Identity Provider. See https://cloud.google.com/iam/docs/reference/sts/rest/v1/TopLevel/token for the list of possible formats."}

I'm not sure if this is a bug or a configuration value. I've made sure the provider user the project number. The project id is correct and the service account is correct too.
Anyone have an idea what I'm doing wrong. I've also reset the provider attributes back to: google.subject=assertion.sub and the error doesn't change. Is it possible that I'm missing an attribute (I had attribute.aud=assertion.aud, repo owner, etc but I removed them for debugging)? Which attribute am I missing?
Thanks in advance :)
Action YAML
name: Deploy self-hosted actions runner

on:
  push:
    branches:
      - main

jobs:
  run:
    name: 'Setup GCP and Deploy self-hosted actions runner'
    runs-on: ubuntu-latest
    permissions:
      contents: 'read'
      id-token: 'write'
    steps:
      - uses: actions/checkout@v3

      - name: Authenticate to Google Cloud
        id: auth-gcp
        uses: google-github-actions/auth@v0
        with:
          workload_identity_provider: '${ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }'
          service_account: '${ secrets.TERRAFORM_SERVICE_ACCOUNT_EMAIL }'
          project_id: '${ secrets.GCP_PROJECT_ID }'
          audience: '${ secrets.GCP_POOL_AUDIENCE }'
          token_format: 'access_token'
          access_token_lifetime: '1800' # 30 minutes

      - name: Initialise Terraform
        run: cd terraform && terraform init -reconfigure -backend-config="access_token="${{ steps.auth-gcp.outputs.access_token }}"" && cd ..

      - name: Validate Terraform
        run: cd terraform && terraform validate -backend-config="access_token="${{ steps.auth-gcp.outputs.access_token }}"" && cd ..
      - name: Create infrastructure
        run: cd terraform && terraform apply -backend-config="access_token="${{ steps.auth-gcp.outputs.access_token }}"" -target=module.self_hosted_ci_runners.google_compute_instance.runner -var 'github_access_token=${ secrets.PERSONAL_ACCESS_TOKEN }' && cd ..

Log output
1s
Current runner version: '2.294.0'
Operating System
Virtual Environment
Virtual Environment Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:2541b1294d2704b0964813337f33b291d3f8596b)
Download action repository 'google-github-actions/auth@v0' (SHA:ceee102ec2387dd9e844e01b530ccd4ec87ce955)
4s
Run actions/checkout@v3
Syncing repository: DerekCrosson/anya-final-project
Getting Git version info
Temporarily overriding HOME='/home/runner/work/_temp/61aa44c8-d64c-4df3-bbbb-f1886707f4fc' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /home/runner/work/anya-final-project/anya-final-project
Deleting the contents of '/home/runner/work/anya-final-project/anya-final-project'
Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
Determining the checkout info
Checking out the ref
/usr/bin/git log -1 --format='%H'
'84a7dab0f8032052a9b01a7c1a9f8e315d68c382'
0s
Run google-github-actions/auth@v0
Created credentials file at "/home/runner/work/anya-final-project/anya-final-project/gha-creds-1508dc439b6f43dc.json"

Error: google-github-actions/auth failed with: retry function failed with 0 attempts: failed to generate Google Cloud federated token for ${ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }: {"error":"invalid_request","error_description":"Invalid value for \"audience\". This value should be the full resource name of the Identity Provider. See https://cloud.google.com/iam/docs/reference/sts/rest/v1/TopLevel/token for the list of possible formats."}
0s
0s
0s
0s
Post job cleanup.
Removed exported credentials at "/home/runner/work/anya-final-project/anya-final-project/gha-creds-1508dc439b6f43dc.json".
0s
Post job cleanup.
/usr/bin/git version
git version 2.37.1
Temporarily overriding HOME='/home/runner/work/_temp/a8f8cd35-0268-4b05-adb2-dce4b996fba0' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /home/runner/work/anya-final-project/anya-final-project
/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
http.https://github.com/.extraheader
/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
0s
Cleaning up orphan processes

Additional information
Nothing I can think of right now, not sure if this is a bug

Hi @DerekCrosson
GitHub Actions expressions use the ${{ x }} syntax. Your example uses ${ x }: https://docs.github.com/en/actions/learn-github-actions/expressions#about-expressions
Please note, this is how GitHub Actions works, and is completely outside of our control.

Thanks, @sethvargo! I can't believe I missed that, really appreciate it :)


Create Combobox Component

You can use this one as reference:
https://codepen.io/smashtheshell/pen/qrvZvx
note:

label should be optional
use or own design system colors

Hello, I'm participating of the hacktoberfest can I take care of this one?


Export browser: Toggle button behavior is faulty

It should update the browser to show the "Comments" column.
Not possible yet with spec. https://github.com/pharo-spec/Spec/issues/1052

Not sure we need a browser just for exporting entities.
Or maybe if you want it to become a report generator, but just exporting could be a menu option on an entry of the Logger

@mahugnon told us he needed to comment entities before exporting them.
I figured it would be easier in an ad hoc browser.
My idea is: we could improve it by allowing the user to choose what they want to export (properties values, metrics, tags etc).
It could become a report generator, yes. For that we need to define our needs and decide more precise specifications


Can't delete a profile

I'll be honest, I made this profile a while ago so maybe I'm just in a bad state... but I get this:

Testing #161792

Hmm, I think this operation would still remove the profile instead of throwing an error.

Unfortunately, it doesn't delete it so I appear stuck with having this extra profile I made a while ago.

It seems I am not catching the error for tasks I do before removing the profile. They should not stop the remove operation. Fixing it.
Please verify in tomorrows insiders if you can remove it.

Worked today!


Separate and make two patterns: crafting pattern & machine pattern

Issue description: After days of not getting the auto-crafting to work. And watching over 10 to 20 videos of others not getting to make it work, I finally watched one video that actually defined specifically that the pattern grid was for crafting and the pattern encoder is for inputting to machines. I had only made pattern encoder and created all patterns with it. Now looking back at the wiki with that knowledge, it does say that.
What happens: using wrong pattern on wrong situation does not work. No way to tell by looking at pattern.
What you expected to happen:

Logic built in to warn user craftable item being written to pattern in encoder. and vice versa for machine pattern.

Add another line to wiki to explain that using the wrong pattern will cause the system to not work.

or 3. If there were two types of patterns, a  machine pattern and crafting pattern, they could be limited to which pattern generating machine they can be inserted into.
Steps to reproduce:

...
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: 2147
Refined Storage: 1.2.4

Does this issue occur on a server? [yes/no] don't know, play single player

When you craft the pattern encoder, in the tooltip clearly said what you are requesting

Okay, But, keep in mind what I stated about the youtube. There are many others that have this issue that spotlight the mod on youtube and end it with problems and autocrafting not working. I think a little effort to streamline this would help.

I don't know who you watched on YT but Direwolf20 always does very detailed tutorials and has one (in 2 parts) about RS. See part two for more info about autocrafting.


Add test coverage for delegated hash bins

This change adds tests coverage for path_hash_prefixes and
verifies that role names matching specific prefixed successfully
find and download the corresponding metadata files and do not
succeed to find existing, but non-matching files
Fixes #1639

[x] The code follows the Code Style Guidelines
[x] Tests have been added for the bug fix or new feature
[n/a] Docs have been added for the bug fix or new feature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.347%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1121

Relevant Lines:
1137

💛  - Coveralls

There are still some problems here:

roles_pref_map still seems unnecessary: _init_repo() call already adds the delegations defined in your test data so there seems to be no reason to then add them manually? If the data driven test setup (defining a Dataset outside the test) does not work in this case for some reason, then let's not use it: defining a Dataset outside of the test and then also generating the test data in the test code combines the worst of both worlds.
test comments say we verify that no metadata file was downloaded as expected for non-existing path, however:

we do expect delegated metadata to be downloaded for non-existing targetpaths if and only if the prefix of the hash of the targetpath matches the one in the delegation: this what the test is trying to test
test does not verify whether metadata was downloaded or not: it should

The tests in TestDelegationsGraphs are so far concentrated on testing delegations only: TargetFiles are not needed. I think this is a good idea for your test as well as it makes the test data smaller and focuses the test better. Yes, we should add target download tests for hash prefixes case but it does not need to happen in this class and it does not need to happen in this PR.

The test should assert the same things test_graph_traversal() does for the "paths" case: assert that  after get_targetinfo()
correct metadata files are in cache and that the expected repository requests were made (see how visited_order is used to check both of those).
The complication with this is that while DelegationsTestCase defines visited_order as the expected delegated targets that are downloaded, it does not define the targetpath that is used: the targetpath is currently hard coded in the test, usually as "missingpath". I'm totally fine doing the same in this test for the first version but I do expect you to assert that visited_order is correct: currently it is not used at all.

This is outside of scope for this PR but in case it makes the intent clearer: What DelegationsTestCase maybe should do is define a dict of target_paths and visited_orders:
search_results: {
    "missingpath": (["A", "B", "C"])
    "noMatchInCPaths": (["A", "B"])
}

Thank you for the review @jku ! I changed the test as you proposed and moved the old with target downloads to #1910 where your comments are addressed as well.


Changes to the search bar

Fixes #685
Search bar is not recognizable for some students when they are new to the website according to
Mr. Raymond G McCord who has responded to my poll in the p5 forum on discourse. He said slight design changes would be helpful for the students.
Changes:
Addition of a magnifying glass to the placeholder according to W3C standards for accessibility.
A 3px border for the input element.
A darker font color for the the placeholder text.

Screenshots of the change:

The magnifying glass emoji is too out of place and attention grabbing. Instead of making it part of the placeholder, can it instead be an :after element attached to the search bar with a simple image background and aligned to the right side of the search bar?
It doesn't need to be hidden even when the user is typing on the box, just need to make sure the text doesn't overlap with the image.

@limzykenneth I am working on it.

@limzykenneth How does this look?

I'd prefer the magnifying glass to be a simple monochrome image and for it to be inside the box.

@limzykenneth working on that.

@limzykenneth How does this look?

Much better, maybe make the image's outline color match the placeholder text's color.

@limzykenneth I haven't loaded an image in for the icon, it's just an unicode character rotated towards right. I don't think I'll be able to change the outline. Should I try a loading an image if you want the outline to be grey?


fix: Avoid double deployment of components in e2e-demo

Description
What is currently being done to deploy Applications/Components in e2e-demo.go appears to be incorrect: the test should not be creating a Component, then also manually creating a GitOpsDeployment targeting that component.
It should only be necessary to create the Component, then wait for HAS to update the GitOps repository with the new component contents.
The problem with the way the test currently works is it ends up creating 2 GitOpsDeployment resources, both targetting the same namespace with the same resources (but with slightly different metadata). This means that Argo CD is constantly fighting with itself to deploy 2 separate Argo CD Applications into the same namespace.
See this video to see what happens in this case. Notice that:

Argo CD is constantly deploying and redeploying the same resources on top of each other (see the flashing resources and status in the Argo CD UI)
Argo CD is warning about the resources clashing with each other, and the warning disappears and reappears (as the two 2 Argo CD Applications conflict)
(I recommend downloading the video to get the full 1080p resolution: google drive preview compresses the preview to be almost unreadable)

This is also likely causing the tests to intermittently fail, and is also likely causing them to take MUCH longer than they should.
My proposed solution is just to let HAS update the GitOps repository, after the component is created/updated, and let GitOps Service deploy the resulting update.
See below for how to reproduce the issue.
Issue ticket number and link
N/A
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How to reproduce
The easiest way to observe this is just to open the Argo CD web UI (see below), and then run the e2e tests as normal:

You will see the Argo CD Applications are constantly refreshing, as they are updating K8s resources on top of each other
You will see the Argo CD Applications have warnings about resources existing in multiple Argo CD Applications at once (which shouldn't happen).

You can see this behaviour if you open the Argo CD instance under gitops-service-argocd while the e2e-demo test is running.
Here is how you open the gitops-service-argocd instance:

Run this command to get the Argo CD URL, then  open Argo CD URL for the Argo CD installed gitops-service-argocd namespace (different URL from the openshift-gitops one):

ARGO_CD_ROUTE=$(kubectl get \
                 -n gitops-service-argocd \
                 -o template \
                 --template={{.spec.host}} \
                 route/gitops-service-argocd-server \
               )
echo "https://$ARGO_CD_ROUTE"

Run this command to get the password:

echo `kubectl -n gitops-service-argocd get secret gitops-service-argocd-cluster -o jsonpath="{.data.admin\.password}" | base64 --decode`

Enter admin and the password above, to log in.
Now, you can run the e2e tests, and you will can see the behaviour described above.
Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation

/approve


What did you expect to see?
Output  of  go test -v ./...:
=== RUN   Test
--- PASS: Test (0.00s)
PASS
ok      gocloud.dev/samples/gocdk-blob  0.137s
#### /tmp/go-cloud/samples/order <nil>
=== RUN   TestOrderForm
--- PASS: TestOrderForm (0.00s)
=== RUN   TestCreateOrder
--- PASS: TestCreateOrder (0.00s)
=== RUN   TestListOrders
--- PASS: TestListOrders (0.00s)
=== RUN   TestHandleRequest
2019/07/09 18:18:32 received {ID:x Email: InImage: CreateTime:0001-01-01 00:00:00 +0000 UTC}
--- PASS: TestHandleRequest (0.00s)
=== RUN   TestProcessOrder
--- PASS: TestProcessOrder (4.03s)
PASS
ok      gocloud.dev/samples/order       4.124s

What did you see instead?
> go test -v -coverpkg=./...  ./...
#### /tmp/go-cloud/samples/gocdk-blob <nil>
panic: open list.htmlt: no such file or directory

goroutine 1 [running]:
html/template.Must(...)
        /usr/lib/google-golang/src/html/template/template.go:373
gocloud.dev/samples/order.init.0()
        /tmp/go-cloud/samples/order/frontend.go:54 +0x23e
FAIL    gocloud.dev/samples/gocdk-blob  0.261s
#### /tmp/go-cloud/samples/order <nil>
=== RUN   TestOrderForm
--- PASS: TestOrderForm (0.00s)
=== RUN   TestCreateOrder
--- PASS: TestCreateOrder (0.00s)
=== RUN   TestListOrders
--- PASS: TestListOrders (0.00s)
=== RUN   TestHandleRequest
2019/07/09 18:19:04 received {ID:x Email: InImage: CreateTime:0001-01-01 00:00:00 +0000 UTC}
--- PASS: TestHandleRequest (0.00s)
=== RUN   TestProcessOrder
--- PASS: TestProcessOrder (4.03s)
PASS
coverage: 37.6% of statements in ./...
ok      gocloud.dev/samples/order       4.182s  coverage: 37.6% of statements in ./...

Note the line beginning with ####. This is the working directory of the samples/order test binary. In the bad case, it is .../samples/gocdk-blob instead of .../samples/gocdk-order.
NOTE: To test against tip, you will need to replace golang.org/x/xerrors with the contents of https://go-review.googlesource.com/c/xerrors/+/184937.

Reproduced, but it looks like this is working as intended.
The gocloud.dev/samples/order package tries to open the file "list.htmlt" in its initialization.
When the test gocloud.dev/samples/gocdk-blog is built, it includes the order package. -coverpkg=./... will cause the packages ./... to be instrumented and linked into each test binary, and that includes order. So when order is initialized within the gocdk-blog executable, it fails because it's run from the gocdk-blog directory.


Misalignment

https://hackrpi.com/#about

Another small issue is directing opening links like  https://hackrpi.com/#sponsors   or the faq/about  does not automatically bring the page to that section


Update User Story Map Miro Board and Zenhub tickets accordingly

Describe the task
We created zenhub tickets based on the miro board user story map, cross-referencing it with pre-created zenhub tix from the hackathon as well as using info from the service blueprints and dev process maps.
Now we need to ensure that the miro board is up to date.
Acceptance Criteria

[ ] Cross-reference miro board black sticky notes with zenhub user stories and epics and ensure they say the same thing and that nothing is missing
[ ] Edit user story map and create a separate user story map workflow as needed per user.

Additional context

Add any other context about the task here.
Or here

@NicoleGovvy and @suhafa  - is this something you would be able to help with? Hanna and I started to look at things, but we can connect more about this at the 1pm call today. cc @hannavovk

Certainly can! Looking forward to the call to get any additional insight before helping out

@suhafa  should we close this ticket since #209 has been created as next steps?


Oracle: Field named CACHE in projection leads to error

Hi
Whenever an unquoted field named CACHE (among others) is part of the projection, e.g. using the following query
-- https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/ALL_ALL_TABLES.html
SELECT CACHE FROM SYS.USER_ALL_TABLES

the parser (version 4.5) reports
Exception in thread "main" net.sf.jsqlparser.JSQLParserException: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "CACHE" "CACHE"
    at line 1, column 8.

Was expecting one of:

    "*"
    "STRAIGHT_JOIN"

When aliasing the table, e.g.
SELECT t.CACHE FROM SYS.USER_ALL_TABLES t

the exception changes to
Exception in thread "main" net.sf.jsqlparser.JSQLParserException: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "." "."
    at line 1, column 9.

Was expecting one of:

    "&"
    "::"
    ";"
    "<<"
    ">>"
    "COLLATE"
    "CONNECT"
    "EMIT"
    "GROUP"
    "HAVING"
    "INTO"
    "START"
    "WINDOW"
    "["
    "^"
    "|"
    <EOF>

	at net.sf.jsqlparser.parser.CCJSqlParserUtil.parseStatement(CCJSqlParserUtil.java:263)
	at net.sf.jsqlparser.parser.CCJSqlParserUtil.parse(CCJSqlParserUtil.java:81)
	at net.sf.jsqlparser.parser.CCJSqlParserUtil.parse(CCJSqlParserUtil.java:47)
	at TestMain.main(TestMain.java:26)
Caused by: java.util.concurrent.ExecutionException: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "." "."
    at line 1, column 9.

When wrapping the word CACHE with double quotes, it works fine.
SELECT t."CACHE" FROM SYS.USER_ALL_TABLES t

The shown behavior does apply to other keywords such as HAVING or INTO.

Good Morning, thanks for reporting.
This Keyword problem has been fixed already and you can use latest JSQLParser 4.6 Snapshot from Github Source.
I have tested your statement successfully.


Update heroicons v2

I have added/updated all new icons from the optimized directory without the mini (20px) set.

Maybe the prefix sm- can be used for the small icon set?

I was thinking about ms- which stands for mini solid since there is only a solid set by now, but maybe someday they will release the outline set so in which case we can use the mo-. However, sm- and om- are also good choices.

I added the mini icons with the m- prefix. As long as there's no outline version of them there's nothing to worry about I think.

Thanks!

So just to clarify I meant sm as in small and not as solid mini but I can see that that is a little confusing in the context.
I am completely fine with only the m Prefix (2.0.0 of blade-heroicons is already released, so that would be a little late for changing that)
I also don't think that there will be another set type (small outline) for heroicons soon.

If there's another set we can name it m-o- or something


Tapping a TextField can result in weird exception

I don't know what I did wrong to cause this nor how to fix it. (meaning a better error message would be good)
[00055.892] 09540.09581>  EXCEPTION CAUGHT BY GESTURE
[00055.896] 09540.09581> The following assertion was thrown while handling a gesture:
[00055.896] 09540.09581> 'package:flutter/src/widgets/focus_manager.dart': Failed assertion: line 289: 'node._parent ==
[00055.896] 09540.09581> null': is not true.
[00055.897] 09540.09581>
[00055.897] 09540.09581> Either the assertion indicates an error in the framework itself, or we should provide substantially
[00055.897] 09540.09581> more information in this error message to help you determine and fix the underlying cause.
[00055.897] 09540.09581> In either case, please report this assertion by filing a bug on GitHub:
[00055.897] 09540.09581>   https://github.com/flutter/flutter/issues/new
[00055.897] 09540.09581>
[00055.897] 09540.09581> When the exception was thrown, this was the stack:
[00055.901] 09540.09581> #2      FocusScopeNode._setFocus (package:flutter/src/widgets/focus_manager.dart:289)
[00055.901] 09540.09581> #3      FocusScopeNode.requestFocus (package:flutter/src/widgets/focus_manager.dart:253)
[00055.901] 09540.09581> #4      EditableTextState.requestKeyboard (package:flutter/src/widgets/editable_text.dart:427)
[00055.901] 09540.09581> #5      EditableTextState._handleSelectionChanged (package:flutter/src/widgets/editable_text.dart:451)
[00055.901] 09540.09581> #6      RenderEditable._handleTap (package:flutter/src/rendering/editable.dart:435)
[00055.901] 09540.09581> #7      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:102)
[00055.901] 09540.09581> #8      TapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:149)
[00055.901] 09540.09581> #9      TapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:119)
[00055.901] 09540.09581> #10     GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156)
[00055.901] 09540.09581> #11     BindingBase&SchedulerBinding&GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:147)
[00055.901] 09540.09581> #12     BindingBase&SchedulerBinding&GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:121)
[00055.901] 09540.09581> #13     BindingBase&SchedulerBinding&GestureBinding._handlePointerEvent (package:flutter/src/gestures/binding.dart:101)
[00055.901] 09540.09581> #14     BindingBase&SchedulerBinding&GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:64)
[00055.901] 09540.09581> #15     BindingBase&SchedulerBinding&GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:48)
[00055.901] 09540.09581> #16     _invoke1 (file:///usr/local/google/home/anwilson/fuchsia/flutter/lib/ui/hooks.dart:100)
[00055.901] 09540.09581> #17     _dispatchPointerDataPacket (file:///usr/local/google/home/anwilson/fuchsia/flutter/lib/ui/hooks.dart:58)
[00055.901] 09540.09581> (elided 2 frames from class _AssertionError)
[00055.902] 09540.09581>
[00055.902] 09540.09581> Handler: onTap
[00055.902] 09540.09581> Recognizer:
[00055.902] 09540.09581>   TapGestureRecognizer#b6abd(debugOwner: RenderEditable#46d18 relayoutBoundary=up18, state: ready)
[00055.902] 09540.09581>

cc @abarth in case you have any insight

We're attempting to focus a FocusNode that is already focused in another scope.

(We should generate a better error message for that case.)

This issue is still relevant as of Flutter 1.3.8

I can confirm the same behavior on iPad (6th gen) with iOS 12.1 and Flutter 1.3.8
Interestingly enough, this doesn't happen on iPhone under the same conditions

This code has changed quite a bit. If you still see this please file a new bug.


Nillable Optional Unique String Field with MinLen

Ok in my usage of ent I came across this scenario
field.String("text").Optional().Nillable().Unique(),

that I extend with
field.String("text").Optional().Nillable().Unique().MinLen(14),

So I'd assume validation occurs if the field != nil,
however validation occurs regardless and I have to do manual validation in the
handler, which is no big deal but I'm not sure if this is the way it's intended.
I can't say if it's a bug or if that's the way you intend it to work, therefore I didn't use the bug template for issues here.
What should be happening:
MinLen validation does not occur if
value := nil
// ...
.SetNillableText(value)

What is happening:
MinLen validation occurs if it's nil

Assuming the above is true then it's a bug as nil values should be ignored by SetNillable<> setters.

SetNillable setters are nops for nil values, see code here and here.
Can you provide a repo reproducing this issue?

I can try to create a repo with minimal content for this issue alone, but it will take some time, maybe this week.
I'll get back to you.

False alarm.
That is really weird.


GBHFacebookImageModel to  GBHFacebookImage

Hey  @terflogag ,
What do you think to change the name to GBHFacebookImage?
I think we don't need explicit say that it's a model.
So in the delegate we will have something like
func facebookImagePicker(imagePicker: UIViewController, didSelect: GBHFacebookImage)

Hey @frelei,
Yes why not, but if I doing that for the image, I need to do it for album also (even if it's private model). Probably for the 2.0 in January :)
Thanks for this issue :)


Django REST Framework 3.0

Hi,
are there any plans to support DRF 3.0?
If so, do you already have a rough timeline? And/or any contribution advises?
Thanks,
-Manuel

Support for DRF 3 is done. I will rewrite whole documentation and readme later this week


Update create-apps-for-teams-meetings.md

Docs Build status updates of commit 907a685:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/create-apps-for-teams-meetings.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


added plt.close('all') to prevent warning message

Closing this request to prevent overwriting newly merged animation.py and animation.gif files


shadps4: init at 0.3.1-unstable-2024-09-30

Description of changes
Adds shadPS4, an in-early development PS4 emulator.
Closes #339617
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4554

Have you been able to launch anything with this? For me the GUI launches and I can adjust settings & install homebrew pkgs, but it just freezes & eventually segfaults on everything eboot I try to launch.

Have you been able to launch anything with this? For me the GUI launches and I can adjust settings & install homebrew pkgs, but it just freezes & eventually segfaults on everything eboot I try to launch.

I haven't got around to it yet, but this might just be an issue with shadPS4 itself.

I've got a later commit building & working on some OpenOrbis samples, though there are some leftover warnings at configure time - unpackaged dependencies, and outdated/borked provided dependencies. I think we should resolve those issues first before getting this in.

0001-shadps4-Get-it-working.patch.txt

Seems like #331649 exists for toml11, but zydis v5.0.0 doesn't exist 🤔 and not sure about vulkan memory allocator

zydis: https://github.com/shadps4-emu/shadPS4/pull/546

the zydis commit in externals is from an unreleased dev branch (with an incompatible change) which will ultimately be v5, so v4 library need to be rejected

Our zydis package has no dependencies aside from cmake, so prolly fine to drop it from buildInputs and use the vendored one for now.
vulkan-memory-allocator: AFAICT the CMake config module doesn't expose its version, so it fails to determine if it satisfies the version constraint. Need to apply https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/commit/257138b8f5686ae84491a3df9f90a77d5660c3bd to our package.
sdl3: https://github.com/NixOS/nixpkgs/pull/326699

Just syncing some info: 0.3.0 is released :)

Tested this by building it myself, it seems to crash and exit without explanation unexpectedly when attempting to load a game which runs on the official build (CUSA01113)

Tested this by building it myself, it seems to crash and exit without explanation unexpectedly when attempting to load a game which runs on the official build (CUSA01113)

Could you send the logs here? I'm still waiting on SDL3 to be added

Could you send the logs here? I'm still waiting on SDL3 to be added

The logs don't say very much as it's a segfault
[Loader] <Info> emulator.cpp:Emulator:56: Starting shadps4 emulator v0.3.0
[Loader] <Info> emulator.cpp:Emulator:57: Revision GITDIR-NOTFOUND
[Loader] <Info> emulator.cpp:Emulator:58: Branch GIT-NOTFOUND
[Loader] <Info> emulator.cpp:Emulator:59: Description GIT-NOTFOUND
[Config] <Info> emulator.cpp:Emulator:61: General isNeo: false
[Config] <Info> emulator.cpp:Emulator:62: GPU isNullGpu: false
[Config] <Info> emulator.cpp:Emulator:63: GPU shouldDumpShaders: false
[Config] <Info> emulator.cpp:Emulator:64: GPU shouldDumpPM4: false
[Config] <Info> emulator.cpp:Emulator:65: GPU vblankDivider: 1
[Config] <Info> emulator.cpp:Emulator:66: Vulkan gpuId: -1
[Config] <Info> emulator.cpp:Emulator:67: Vulkan vkValidation: false
[Config] <Info> emulator.cpp:Emulator:68: Vulkan vkValidationSync: false
[Config] <Info> emulator.cpp:Emulator:69: Vulkan vkValidationGpu: false
[Config] <Info> emulator.cpp:Emulator:70: Vulkan rdocEnable: false
[Config] <Info> emulator.cpp:Emulator:71: Vulkan rdocMarkersEnable: false
[Config] <Info> emulator.cpp:Emulator:72: Vulkan crashDiagnostics: false
[Kernel.Vmm] <Info> address_space.cpp:Impl:352: System managed virtual memory region: 0x400000 - 0x7ffffbfff
[Kernel.Vmm] <Info> address_space.cpp:Impl:355: System reserved virtual memory region: 0x7ffffc000 - 0xfffffffff
[Kernel.Vmm] <Info> address_space.cpp:Impl:358: User virtual memory region: 0x1000000000 - 0x10fffffffff
[Kernel.Vmm] <Info> memory.cpp:SetupMemoryRegions:50: Configured memory regions: flexible size = 0x1c000000, direct size = 0x120000000
[Kernel.Vmm] <Info> memory.cpp:MemoryManager:35: Usable memory address space: 1087_GB
[Loader] <Info> emulator.cpp:Run:126: Game id: CUSA01113 Title: Gravity Rush™ Remastered
[Loader] <Info> emulator.cpp:Run:129: Fw: 0x4500000 App Version: 01.00
Segmentation fault (core dumped)

https://github.com/shadps4-emu/shadPS4/issues/1042 has been merged so that first patch can be removed. For Bloodborne specifically you probably want to include https://github.com/shadps4-emu/shadPS4/pull/1146, but shadps4 development is happening so quickly that it might make more sense not to include any patches with this derivation and let people use overrideAttrs to point to their own sources.

Managed to get things working to some degree! I'm using https://github.com/shadps4-emu/shadPS4/pull/1146 and two patches:
https://github.com/shadps4-emu/shadPS4/issues/1042
--- a/src/core/libraries/kernel/thread_management.cpp
+++ b/src/core/libraries/kernel/thread_management.cpp
@@ -1065,7 +1065,16 @@ ScePthread PThreadPool::Create() {
         }
     }

+#ifdef _WIN64
     auto* ret = new PthreadInternal{};
+#else
+    // TODO: Linux specific hack
+    static u8* hint_address = reinterpret_cast<u8*>(0x7FFFFC000ULL);
+    auto* ret = reinterpret_cast<PthreadInternal*>(
+        mmap(hint_address, sizeof(PthreadInternal), PROT_READ | PROT_WRITE,
+             MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0));
+    hint_address += Common::AlignUp(sizeof(PthreadInternal), 4_KB);
+#endif
     ret->is_free = false;
     ret->is_detached = false;
     ret->is_almost_done = false;

and this to get controls with work without a numpad:
diff --git a/src/sdl_window.cpp b/src/sdl_window.cpp
index bd2cc39d..13438149 100644
--- a/src/sdl_window.cpp
+++ b/src/sdl_window.cpp
@@ -127,19 +127,12 @@ void WindowSDL::onResize() {
 void WindowSDL::onKeyPress(const SDL_Event* event) {
     using Libraries::Pad::OrbisPadButtonDataOffset;

-#ifdef __APPLE__
     // Use keys that are more friendly for keyboards without a keypad.
     // Once there are key binding options this won't be necessary.
     constexpr SDL_Keycode CrossKey = SDLK_N;
     constexpr SDL_Keycode CircleKey = SDLK_B;
     constexpr SDL_Keycode SquareKey = SDLK_V;
     constexpr SDL_Keycode TriangleKey = SDLK_C;
-#else
-    constexpr SDL_Keycode CrossKey = SDLK_KP_2;
-    constexpr SDL_Keycode CircleKey = SDLK_KP_6;
-    constexpr SDL_Keycode SquareKey = SDLK_KP_4;
-    constexpr SDL_Keycode TriangleKey = SDLK_KP_8;
-#endif

     u32 button = 0;
     Input::Axis axis = Input::Axis::AxisMax;

and then using this for compilation:
with (import /home/ashley/projects/nixpkgs { });
shadps4.overrideAttrs (_: {
  src = lib.cleanSource ./.;
  patches = [ ./bloodborne.patch ./laptop-controls.patch ];
  cmakeBuildType = "RelWithDebugInfo";
})

It doesn't work super well with integrated graphics but still!

Tested this by building it myself, it seems to crash and exit without explanation unexpectedly when attempting to load a game which runs on the official build (CUSA01113)

I also had this and ran gdb which shows a trace related to it being unable to load the correct X11 libs. I reused a devshell from a previous project in order to get that stuff to work:
devShells.default =
          with pkgs;
          mkShell rec {
            nativeBuildInputs = [
              pkg-config
              trunk
              wasm-bindgen-cli
            ];
            buildInputs = [
              udev
              alsa-lib
              vulkan-loader
              xorg.libX11
              xorg.libXcursor
              xorg.libXi
              xorg.libXrandr # To use the x11 feature
              libxkbcommon
              wayland # To use the wayland feature
            ];
            LD_LIBRARY_PATH = lib.makeLibraryPath buildInputs;
          };

@henkery I also had this and ran gdb which shows a trace related to it being unable to load the correct X11 libs. I reused a devshell from a previous project in order to get that stuff to work:

shad2 = with pkgs; writeShellApplication {
            name = "shad2";
            text = ''${shadps4}/bin/shadps4 "$@"'';
            runtimeEnv.LD_LIBRARY_PATH = lib.makeLibraryPath [
              xorg.libXi

            ];
          };

this works equally well.

Prolly needs smth like this:
https://github.com/NixOS/nixpkgs/blob/d78d09350ac7dfe503cf48cbc59764aef4157b9a/pkgs/development/libraries/SDL2/default.nix#L206-L218
...but for $out/bin & just whatever X11/wayland libs it wants to dlopen().

Prolly needs smth like this:

Yep, I was just testing using a wrapper script as it didn't require recompilation, but you can just patch the rpaty in the binary. See my edited comment.

I've uploaded my changes at https://github.com/NixOS/nixpkgs/compare/master...expenses:nixpkgs:shadps4. I'm using a local path for the shadps4 source but that's only because I'm on a bad internet connection and it cuts off before I can clone the repo in nix. I'm using the latest head (https://github.com/shadps4-emu/shadPS4/commit/bf3e43b01683bd783323e12237027103fae28d54).

Things look good now :)

I just want to say that it seems working.

The emulator crashed when clicking play, but it may not be due to the PR since the appimage also crashes. The errors show that the emulator doesn't support certain thread settings, has some missing functions, and can't fully access the game files. https://github.com/shadps4-emu/shadPS4/issues/1311

It's working well and as expected perhaps we wish to discuss the release/update cadence here as well I see we've now switched to unstable versions but how will we maintain which version we track, is it just the maintainer who updates the tracked commit whenever they feel like it?

I'm depending on the unstable releases for now, until stable 0.3.1 is released.

We can always depend on latest release. For bleeding edge there is always https://github.com/chaotic-cx/nyx repo where bot automatically updates to the latest git commit.

If you want, you can add an update script.
passthru.updateScript = unstableGitUpdater {
  tagPrefix = "v";
};

Should make it trivial for anyone to make a bump (nix-shell maintainers/scripts/update.nix --argstr package shadps4), and @r-ryantm will automatically generate bump PRs whenever it runs the update script and the bumped build passes (which can happen abit too frequently on unstable packages with active upstreams like this, so should maybe opt out of the auto-updates in case the spam bothers you).
(I'll give this another review later today, not on an x86_64 machine right now)

New auto-updater doesn't make sense for our purposes & might confuse users with it non-functionality on NixOS: https://github.com/shadps4-emu/shadPS4/issues/1368
Patch to neutralise it for now:
0001-Disable-update-checking.patch.txt

(didn't wanna dig deeper into how to make Qt not get stuck on weirdly initiated windows on app shutdown, otherwise I'd make it throw a warning & immediately exit here instead of hijacking that dialogue)


Before you open a new issue

Before you open a new issue, please ensure you have done the following:

Review Closed Issues

Have you reviewed the closed issues to verify if your concern has already been resolved? Many common problems and their solutions are documented there.
Search Closed Issues

Consult the Wiki and Discussions

The Wiki is a valuable resource for guides and troubleshooting steps.
The Discussions section is also a great place to see if others have encountered and resolved similar issues.

Enable Log Mode and Review for Errors

If the program displays an error or behaves unexpectedly, please enable log mode and review the logs for any error messages. Include these logs in your issue submission.

Check the Windows Event Log (if the program crashes)

In the event of a program crash, please check the Windows Event Log for any related error messages (.NET runtime) and include that information in your report.

Please Note: Feature requests or issues that have already been addressed, as well as requests for features that already exist, will be closed without further comment.

i checked all that, but there ain't no search by name and ain't no available dubs


Always return 200 from /healthcheck

These changes return a 200 status code when a successful JSON response is returned from the healthcheck API, despite if one of our dependencies is down.
Healthcheck by default returns a 500 when one of the dependent services is down. The 500 status code should be reserved for cases when "the server encountered an unexpected condition that prevented it from fulfilling the request" (citation). While one of our dependencies going down is not good, it does not mean the /healthcheck API was unable to fulfill the request. As long as we successfully process the request, despite the health of our dependencies, we should return a 200.
I considered submitting a pull request to Healthcheck since I think the default behavior is incorrect, but I decided not to as a change in this behavior would probably break a lot of users.

@ivan-c we have @jhowe-uw to thank for this one!

@pbugni was leaning to develop but it doesn't look like we'll bring any changes from develop into the RC if I change the base branch in the PR (Ryan's topic branch was started before the RC)


Fix Handling of Long Responses in getBotReply Function

This PR updates the cleanupResponse function to handle responses exceeding Discord's message character limit by splitting them into multiple messages. Each segment is up to 2000 characters, adhering to Discord's constraints.
Changes:

Modified cleanupResponse to return an array of strings, each representing a part of the response.
Implemented a loop to split the response into chunks of 2000 characters.
Changed the messages variable declaration from let to const to address linting recommendations.

This enhancement ensures that long responses are delivered in multiple messages, preventing message truncation or errors.

No, I messaged you on reddit

https://discord.gg/BgVXsg3Q


Undefined variable: data

when call   php artisan es:indices:list from command line
It gives me
ErrorException  : Undefined variable: data
at /vendor/basemkhirat/elasticsearch/src/Commands/ListIndicesCommand.php:96
92|             $data[] = $row;
93|
94|         }
95|
96|         return $data;
97|
98|     }
99|
100|     /**

Make sure you add the necessary info in config/es.php

Just for clarification, I faced the same issue and I realized that I didn't have any index in my elasticsearch, so I created it and configured it in the config/es.php and it worked.
Suggestion: handle this error and provide a useful message.
Maybe close this issue?

Yes @pildit  and @ayrtonvwf you were right it was my mistake that I didn't configured the config/es.php file first
Thanks Guys :)


No obvious way to generate man pages

Wiki page
No response
Subcommand
No response
Description
I've been packaging git-branchless in the Arch Linux AUR (user repository) for a while now and am considering migrating it to official package repositories. I just bumped the packaging to the new v0.7.0 release, but I'm having trouble figuring out where the rumored man pages are.
I see from #112 the discussion about the topic, but no conclusion. It kind of punts to "disto packager support", but I am the distro packager and our tooling does support it, I just can't figure out where to get them from. I see in #114 some tooling was added suggesting man pages might be generated by build.rs and stuffed in the output dir, but I don't see them there either. In more current code I see a function being run as part of git branchless init that suggests it might be stuffing man pages locale to a repository, but I tried that too and didn't find any.
What is the status of having man pages and where can I get them from to add to our packaging?

Hi @alerque, the existing code for git-branchless init would install man-pages, except that it requires the man-pages feature to be enabled, and also the man-pages feature was removed at some point in the past. I opened https://github.com/arxanas/git-branchless/pull/830 to create an explicit git-branchless install-man-pages command; let me know if that works for you and I can merge it.

Thanks for looking into this! I dropped some comments on the PR.


ci(docs): :ferris_wheel: add deloy docs workflow

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


gesture problem

How does flutter respond to gesture interactions outside the widget?

@jijiawei16 Please clarify what do you mean saying "outside the widget"?

@jijiawei16  Please add more details in the question like an example of your use case.

For example, a Stack widget, its height and width all are 100px. It has a child widget Container. The Containers width and height all are 200px. Obviously, the size of Container exceeds the size of Stack. If a gesture is added to Container, how can we get the gesture click events outside the size range of Stack widget and within the size range of Container widget?

Duplicate of #19445.
@jijiawei16  Please check similar issues on stackoverflow as well, there are described some workarounds which may do the thing in your case of rectangular widgets.
Quoting @goderbauer, "It is intentional that widgets in the overflow area of a stack do not react to gestures and that's unlikely to change. I recommend that people with this (or similar) problems refactor their app to keep all interactable elements within the bounds of a stack."
The above mentioned issue is open and the documentation will be fixed at some point. Closing the issue if you don't mind.

@BondarenkoStas thank you very much!