Freezes

I have been having random freezes using this trainer, requiring a hard reset. The codes work perfectly otherwise. Is there anyway I can get more information from the WiiU so as to diagnose the problem? I am not sure which cheat may be the culprit. The first freeze happened at Eventide Island, I guessed it was a local occurrence and ignored it. The freezes have also been more common since the 4.0.3 update. Is there any further information I can give to help resolve this bug?

Hi, most of the codes are mine, and ive heard others have issues with crashing. I believe one of the codes MIGHT be using an unreliable pointer. Im not 100% certain but i have a hunch its the infinite health code. try avoiding that code and using the Mipha's Grace Instant Reset Code instead, and see if the crashing goes away.
unfortunately there's no real way to troubleshoot other than turning off a few codes and seeing if the crashes stop.

I don't use the health or stamina codes so another code must have been the issue. I was only using durability codes, immunity code, stealth code, moon jump, and the powers timer codes. Unfortunately I can't narrow it down further. I thought it might be the durability codes as when you reach Eventide the game probably moves the inventory pointer, creating a new second inventory causing the illusion that all of your stuff is gone.
Other random freezes I had were mostly me speeding around at 4x speed with the paraglider, not the loading stutters, but ones requiring hard reset. I really don't know why they happened.


consistent imports in text.rst

lgtm. can you squash. ping when pushed / green.

@SebastianRubbert docs still build fully? (note that we don't actually test this on travis, except after it is merged).

I rebuilt the doc and I did not have errors in the files I edited.

merged via https://github.com/pydata/pandas/commit/5803e4c7417130536e4c12412c03c5bbaac60219
thanks!


Bump the memory limit for the {registry-cache,shoot-rsyslog-relp}-unit jobs from 2Gi to 3Gi

/kind enhancement
What this PR does / why we need it:
We noticed that the unit tests jobs for the registry-cache and shoot-rsyslog-relp extensions are occasionally being OOMKilled:
% k -n test-pods get po | grep OOMKilled
28bc384e-b37c-4901-a559-595d68c68ccb   1/2     OOMKilled   0          4h9m
3afaa139-4632-41d1-a0d4-27c8b853bbed   1/2     OOMKilled   0          41h
3d3b8284-e13f-4859-aa58-f7c33d500f05   1/2     OOMKilled   0          10h
d052792c-da22-4cbf-80c2-eff7184aed1a   1/2     OOMKilled   0          14h

We ran the following experiment locally to see the memory usage of make verify:
We started a local container with with a memory limit and with the corresponding golang version:
docker run --rm -v ${GOPATH}/src/github.com/gardener/gardener-extension-registry-cache:/go/src/github.com/gardener/gardener-extension-registry-cache -it golang:1.23.0-bookworm bash

We executed make verify inside the container.
In parallel we watched the memory usage with
docker stats

Here are some numbers for the max memory usage from the make verify runs:
Max memory usage for registry-cache@main (go@1.23):
| Run | Value  |
|-----|--------|
| 1.  | 2.62Gi |
| 2.  | 2.81Gi |
| 3.  | 2.74Gi |
| 4.  | 2.82Gi |
| 5.  | 2.66Gi |
| 6.  | 2.71Gi |

Max memory usage for shoot-rsyslog-relp@main (go@1.22):
| Run | Value  |
|-----|--------|
| 1.  | 2.50Gi |
| 2.  | 2.58Gi |
| 3.  | 2.63Gi |
| 4.  | 2.74Gi |

Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A

/cc @dimitar-kostadinov @plkokanov


fix: IE 11 and older do not trigger popstate, use hashchange for chec…

IE 11 and older do not trigger the popstate event when the hash changes.
We have to use hashchange in this case.
It is a bug that will not be fixed. See https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/3740423/
Closes https://github.com/zurb/foundation-sites/issues/10771

Same as for others PRs: popstate is used a lot within the framework (Tabs, Accordion, Magellan, Reveal).
Please add an utility in foundation.util.core (or an other utility file if you think it is more appropriate) and avoid code duplication.

Good suggestion. Similar to the load utility method that you suggested?

@DanielRuf Exactly (with a better name, specific enough to Foundation)

@DanielRuf  I started implemented a generic popstateEvent and made some research:

hashchange is triggered only when the hash change. It is not similar to popstate as it will not be triggered when the url change. IE 8+.
popstate is triggered when the history state is changed. Edge 14+.

But none of these events will not being triggerd by history.pushState() (see https://codepen.io/ncoden/pen/ddLQmN). Only backward/forward history manipulations will (like clicking on a link or called history.back()). There is a good polyfill here but it works by overriding history.pushState.
The thing is: we do not even need to listen on all history change. We currently use popstate (checked for Accordion, Magellan, Reveal and Tabs) only for window.location.hash, and could rely on hashchange instead without any problems. No need for a polyfill.

Closing this in favor of https://github.com/zurb/foundation-sites/pull/11011


build from source Windows toolchain for CPU error

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): source
TensorFlow version: 1.12
Python version: 3.6
Installed using virtualenv? pip? conda?: virtualenv
Bazel version (if compiling from source):0.20
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0/<IP_ADDRESS>
GPU model and memory: AMD 2700

Building tensorflow from source I followed this description
<EMAIL_ADDRESS>I launch bazel and get the following error
(tensorflow) C:\Users\Stefan\tensorflow-build\tensorflow>bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
c:\users\stefan\tensorflow-build\tensorflow/.bazelrc
c:\users\stefan\tensorflow-build\tensorflow/tools/bazel.rc
WARNING: Option 'experimental_shortened_obj_file_path' is deprecated
INFO: Invocation ID: 1f1e1f31-ec58-4119-9c1d-385bb8e68863
ERROR: cc_toolchain_suite '@local_config_cuda//crosstool:toolchain' does not contain a toolchain for CPU 'x64_windows', you may want to add an entry for 'x64_windows|msvc-cl' into toolchains and toolchain_identifier 'local_windows' into the corresponding cc_toolchain rule (see --incompatible_disable_cc_toolchain_label_from_crosstool_proto).
INFO: Elapsed time: 3.855s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
How can I fix this?
Thanks for helping

TensorFlow officially supports NVIDIA® GPU card with CUDA® Compute Capability 3.5 or higher.
Unfortunately AMD gpu cards are not supported at this time. However you can still use TensorFlow CPU version which we support across various platforms.

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Plugin support

Addresses https://github.com/Azure/azure-sdk-for-net/issues/11986

/azp run net - servicebus - tests

Nice. Clean API!

/azp run net - servicebus - tests

The execution of the ServiceBusPlugin instances is controlled by the SDK. Each message will go through exactly one execution, the task will not be cached and reused. Using ValueTask for BeforeMessageSendAsync() and AfterMessageReceiveAsync() seems to be reasonable.

Agree this seems like appropriate use case for ValueTask. @pakrym?

Yes, ValueTask is reasonable here.

May I ask why ValueTask was chosen? I'm not saying it is the wrong choice here it just seems to me the rationals haven't really been presented here on this PR or let's say not enough to jump to the conclusion that ValueTask is the right choice.
When I look at the usability guidelines of the SDK I see a great emphasize on simplicity, discoverability and many more aspects that make it usable by end-users of various backgrounds. ValueTask is an advanced edge case in the .net framework. You could argue that a plugin is also an advanced edge case still it seems the implications on users is not mentioned here in the discussions.
Furthermore what are the use cases of plugins? If a plugin is allowed to be IO-bound it should return a task. If synchronous implementation of plugins are a thing then users can simply return Task.CompletedTask and there is no performance implications on that. When connecting back to the usability story Task and Task.CompletedTask are something that users are more aware of than ValueTask.
Now let's turn this argument around and assume ValueTask is the thing we want to return here then in my opinion the plugin abstraction conveys the following intent: We expect you the majority of time to synchronously complete and only occasionally to yield async. In such cases Value Task is the right choice.
If though the design is enable IO-bound and either be IO-bound or sync then Task is the right choice. I do think this is further backed up by this paragraph which is also linked as guidance in the .NET SDK blog post

Should every new asynchronous API return ValueTask / ValueTask?
In short, no: the default choice is still Task / Task.
As highlighted above, Task and Task are easier to use correctly than are ValueTask and ValueTask, and so unless the performance implications outweigh the usability implications, Task / Taskare still preferred. There are also some minor costs associated with returning a ValueTask instead of a Task, e.g. in microbenchmarks it’s a bit faster to await a Task than it is to await a ValueTask, so if you can use cached tasks (e.g. you’re API returns Task or Task), you might be better off performance-wise sticking with Task and Task. ValueTask / ValueTask are also multiple words in size, and so when these are awaitd and a field for them is stored in a calling async method’s state machine, they’ll take up a little more space in that state machine object.
However, ValueTask / ValueTask are great choices when a) you expect consumers of your API to only await them directly, b) allocation-related overhead is important to avoid for your API, and c) either you expect synchronous completion to be a very common case, or you’re able to effectively pool objects for use with asynchronous completion. When adding abstract, virtual, or interface methods, you also need to consider whether these situations will exist for overrides/implementations of that method.

https://devblogs.microsoft.com/dotnet/understanding-the-whys-whats-and-whens-of-valuetask/
Again I don't want to shoot down the design decision. I simply would like to better understand the rationals for ValueTask vs Task because I feel they haven't been sufficiently presented here in the PR (maybe they have been discussed in back channels).
@pakrym @JoshLove-msft

May I ask why ValueTask was chosen? I'm not saying it is the wrong choice here it just seems to me the rationals haven't really been presented here on this PR or let's say not enough to jump to the conclusion that ValueTask is the right choice.

I think Sean laid out the broad strokes for why ValueTask makes sense here. The SDK is responsible for executing these methods, and we can ensure that they are only awaited once. That said, it's true that usability is still something to consider as users will be implementing these methods. I'm not sure if having to return a ValueTask instead of a Task will provide a barrier for users, but we do have a precedent for this in the ProcessNextAsync method. This method needs to be overridden when implementing a custom pipeline policy for HTTP libraries, but it is the SDK's responsible for executing it.

Now let's turn this argument around and assume ValueTask is the thing we want to return here then in my opinion the plugin abstraction conveys the following intent: We expect you the majority of time to synchronously complete and only occasionally to yield async. In such cases Value Task is the right choice.

I'm not sure that we would be conveying that intent, as the generic ValueTask was all about optimizing for the synchronous completion case, whereas the non-generic version was introduced to enable async usage to be allocation free (from https://devblogs.microsoft.com/dotnet/understanding-the-whys-whats-and-whens-of-valuetask/)

When ValueTask was introduced in .NET Core 2.0, it was purely about optimizing for the synchronous completion case, in order to avoid having to allocate a Task to store the TResult already available. That also meant that a non-generic ValueTask wasn’t necessary: for the synchronous completion case, the Task.CompletedTask singleton could just be returned from a Task-returning method, and was implicitly by the runtime for async Task methods.
With the advent of enabling even asynchronous completions to be allocation-free, however, a non-generic ValueTask becomes relevant again. Thus, in .NET Core 2.1 we also introduced the non-generic ValueTask and IValueTaskSource. These provide direct counterparts to the generic versions, usable in similar ways, just with a void result.

We are definitely open to discussing this further, and we will do so when we meet on Monday to discuss the API. If you are interested in participating in this discussion, I can send the meeting your way 😃

@JoshLove-msft

The SDK is responsible for executing these methods, and we can ensure that they are only awaited once.

If that would be the driving force to adopt ValueTask (non-generic version) than almost every method would need to go with ValueTask if the method is awaited by the SDK itself (and not cached) and not the user code.
I tried to look into the history of the HttpPipelinePolicy and unfortunately it is not clear why ValueTask was chosen other than

VALUE TASK ALL THE THINGS

https://github.com/Azure/azure-sdk-for-net/pull/7638
While I like this and it puts a slight smile on my face it still leaves me curious. Especially considering Microsoft's own guidance

https://docs.microsoft.com/en-us/dotnet/api/system.threading.tasks.valuetask
A quick benchmark confirms that picture as well
BenchmarkDotNet=v0.12.0, OS=Windows 10.0.18363
Intel Core i7-8550U CPU 1.80GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.1.201
  [Host]     : .NET Core 3.1.3 (CoreCLR 4.700.20.11803, CoreFX 4.700.20.12001), X64 RyuJIT
  DefaultJob : .NET Core 3.1.3 (CoreCLR 4.700.20.11803, CoreFX 4.700.20.12001), X64 RyuJIT

Method
Mean
Error
StdDev
StdErr
Median
Min
Q1
Q3
Max
Op/s
Gen 0
Gen 1
Gen 2
Allocated

TaskCompleted
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
0.0000 ns
Infinity
-
-
-
-

TaskYield
1,610.7387 ns
24.4727 ns
22.8918 ns
5.9106 ns
1,605.3237 ns
1,573.5660 ns
1,588.5495 ns
1,632.5707 ns
1,651.1014 ns
620,833.2
0.0267
-
-
112 B

ValueTask
0.0434 ns
0.0428 ns
0.0400 ns
0.0103 ns
0.0257 ns
0.0000 ns
0.0166 ns
0.0722 ns
0.1514 ns
23,060,025,691.4
-
-
-
-

ValueTaskYield
832.7001 ns
16.6550 ns
37.5932 ns
4.8133 ns
837.6018 ns
715.5558 ns
816.3295 ns
857.4259 ns
888.5900 ns
1,200,912.5
0.0286
-
-
120 B

    [Config(typeof(Config))]
    public class TaskVSValueTask
    {
        private class Config : ManualConfig
        {
            public Config()
            {
                Add(MarkdownExporter.GitHub);
                Add(MemoryDiagnoser.Default);
                Add(StatisticColumn.AllStatistics);
            }
        }

        [Benchmark]
        public Task TaskCompleted()
        {
            return Task.CompletedTask;
        }

        [Benchmark]
        public async Task TaskYield()
        {
            await Task.Yield();
        }

        [Benchmark]
        public ValueTask ValueTask()
        {
            return default;
        }

        [Benchmark]
        public async ValueTask ValueTaskYield()
        {
            await Task.Yield();
        }
    }

I'm aware that using value task over Task is a bit of a controversial topic. Some people prefer it over Task and wish it would be the default. Still I can't find the reasons presented anywhere (maybe I'm just not looking close enough and suffer from weekend blindness due to too much sun exposure, it is finally nice weather again here! 🌞 )

@danielmarbach

Are we hoping to benefit from devblogs.microsoft.com/dotnet/async-valuetask-pooling-in-net-5 if available?

Exactly! The non generic Task vs ValueTask choice was driven by the hope of benefiting from pooling for async cases when that becomes available.

@pakrym sorry I was a bit brief in the call today because we were already over time. I meant this point from the official guidance


Add Male and Female Voice Toggle Through Settings Function

This is related to the AI only having a male voice available even though there is an option for the male voice.
Create a new settings window that has options like voice gender.

Working in main script, happy to announce that one more function will be coming with the 1.2 rollout!


fix(checkbox): match MD spec

This updates our checkbox to match the new Material Design spec, including:

Reducing the size
Animating the checkmark path
Increasing the speed of the transition

This is nice :tada:

Closing this in favor of a slightly cleaner implementation in #16186


How much computing resource is used by Arm NN?

How do I know how many cpus or gpus are used by Arm NN?

Hi @ivs-pychen
There are two previous issues that might have the answer your looking for: #92 #75
Internally I don't believe we have any tools to measure how many CPUs/GPUs Arm NN is using.
But you can use linux commands to inspect this, e.g. "top -H -p "


Reconstructed branch from zipped set of patches dumped in #928

Reconstructed branch from zipped set of patches dumped in #928:

https://github.com/DaemonEngine/Daemon/issues/928#issue-1892984160

The code was not read.
This is not reviewed, at all, so it is not approved.
All I did was to apply patches one by one by hand and rewrite the commits by hand when there have been patch application rejects, which happened more than once since the target reference for those patches is unknown.
It is said that “it seems to fix“ some “memory leak in both cvar systems (Cvar and cvar_t)”.

This is too big and needs to be split up or have some commits removed. Most commits obviously don't have anything to do with memory leaks.
BTW I doubt there is any real leak fixed here at all. It's just that when exiting the program we don't free all the pointers (which is pointless because the program is exiting). The only purpose in freeing them is to appease sanitizer programs.

For the code that's linked into the gamelogic, it's important to free memory for the shared lib use case

For the code that's linked into the gamelogic, it's important to free memory for the shared lib use case

The code in question is in src/engine/

I thought the changes to cm/ would be linked into the game logic?

I thought the changes to cm/ would be linked into the game logic?

There are changes to cm/ but they are very trivial and unrelated to memory management. There is just one commit that purports to fix a leak - I'm talking about that one.

BTW I doubt there is any real leak fixed here at all. It's just that when exiting the program we don't free all the pointers (which is pointless because the program is exiting). The only purpose in freeing them is to appease sanitizer programs.

Yeah we had that talk when doing https://github.com/DaemonEngine/Daemon/pull/897 and other things.
Anyway, if we have commits that removes false positive from ASAN that may even help us to better spot true positive, so I won't mind merging them.

This is too big and needs to be split up or have some commits removed.

Let's say each commit in this branch is a PR by itself but I will not open a PR per commit. If someones says something like LGTM for “fix -Wunused-macro”,  I will merge the said commit, moving steps by steps.

Good to merge:

R_LoadDDSImageData is static LGTM
static things LGTM

Wouldn't merge:

fix -Wunused-macro  looks pretty ugly
fix missing-variable-declaration looks bad
more static stuff looks bad because writing the two lines foo bar; extern foo bar; one right after the other is nonsensical
I dislike fix uninitialised-condition. This is more a matter of taste

There are good reasons we don't have certain compiler warnings enabled. Some of them just encourage making the code worse.

Good to merge:
* `R_LoadDDSImageData is static` LGTM

* `static things` LGTM

Wouldn't merge:
* `fix -Wunused-macro ` looks pretty ugly (and actively wrong in one case with the libpng thing)

* `fix missing-variable-declaration` looks bad

* `more static stuff` looks bad because writing the two lines `foo bar; extern foo bar;` one right after the other is nonsensical

* I dislike `fix uninitialised-condition`. This is more a matter of taste

There are good reasons we don't have certain compiler warnings enabled. Some of them just encourage making the code worse.

Thanks. About fix uninitialised-condition, it looks like changes in src/engine/framework/BaseCommands.cpp and src/engine/server/sv_client.cpp are just working around the fact the compiler doesn't know that Str::ParseInt modifies the argument. I don't know if there is a c++ way of telling the compiler the function does that. But what is your opinion about the change in src/engine/renderer/tr_scene.cpp ?

more static stuff looks bad because writing the two lines foo bar; extern foo bar; one right after the other is nonsensical

I guess you talk about:
-cvar_t                     *r_allowResize; // make window resizable
+extern cvar_t *r_allowResize; // make window resizable
+cvar_t *r_allowResize;

I guess the second line is an elaborated kind of typo. I can fix that. Have you seen something else? Can I merge this commit if I delete the second line?

fix -Wunused-macro  looks pretty ugly (and actively wrong with the libpng one)

Right, it looks like the change in libpng will just make the game to not build on some distros because with this change “it works for me” on another distro.
But what do you think about the #ifndef BUILD_VM in src/common/FileSystem.cpp and #ifdef _WIN32 in src/engine/framework/VirtualMachine.cpp?

Thanks. About fix uninitialised-condition, it looks like changes in src/engine/framework/BaseCommands.cpp and src/engine/server/sv_client.cpp are just working around the fact the compiler doesn't know that Str::ParseInt modifies the argument. I don't know if there is a c++ way of telling the compiler the function does that. But what is your opinion about the change in src/engine/renderer/tr_scene.cpp ?

It appears that the existing code has an off-by-one bug, where if the number of tests is MAX_VISTESTS - 1 and you attempt to register another one, the last slot will be recycled by mistake. The change makes the consequences of this bug worse by falling off the end of the function instead of reusing the last slot.

I guess you talk about:
-cvar_t                     *r_allowResize; // make window resizable
+extern cvar_t *r_allowResize; // make window resizable
+cvar_t *r_allowResize;

I guess the second line is an elaborated kind of typo. I can fix that. Have you seen something else? Can I merge this commit if I delete the second line?

It is clearly intentional as the same pattern is repeated several times in the commit. Apparently to appease some obscure warning. No, the commit is still no good if you delete the second line.

But what do you think about the #ifndef BUILD_VM in src/common/FileSystem.cpp and #ifdef _WIN32 in src/engine/framework/VirtualMachine.cpp?

I think the BUILD_VM one is silly and this commit is a waste of time.

Don't worry slipher, next time I have memleaks or other fixes like that, I'll just keep them for myself, and to make your stats look better, I might also avoid reporting a bug. I won't put code that is "nonsensical", "looks bad", etc under your eyes even if it contains a fix for a memory leak that is so trivial to prove (run with asan, nothing complicated) that it simply shows how much tools are used to sanitize the codebase: not at all, as you even admit by "not enabling some warnings". That's not the way to do things. The way to do things is to enable all warnings, and only disable those which do not make sense. But this would end up with thousands of warnings in this codebase, and daemon's warnings even propagate to the gamelogic because there's that much (warning) code in headers.
The more I know Unvanquished, the more I think the only stuff that have value for contributing back are changes in what mappers can do. Any other stuff just is a waste of time, and I'm sure you know why.

OK to merge:

remove unused global vars LGTM
move some cvars to static LGTM

Needs fixes:
fix a 200 Byte leak per cvar - using unique_ptr for cvarRecord_t is a good cleanup, but there's a problem with the bit migrating the ccvar strings (latchedString, resetString etc.) to std::string. Sometimes they have optional string semantics, with code like if (cvar.flags & CVAR_LATCH and cvar.ccvar.latchedString). Also looks like this commit won't compile on its own.


[development] fix components path

Pull Request Test Coverage Report for Build efd873d4-c1ac-42c7-9539-f4b8847eba93
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.093%

Totals

Change from base Build d4075ecb-5e91-40c6-939c-e54bd6c89250:
0.0%

Covered Lines:
358

Relevant Lines:
395

💛  - Coveralls


[PTX] Fix #195: PTX Kernel Signature match with arguments size during kernel launch

Description
This PR provides a fix for #195. The issue is that, from the NVIDIA Driver 510.60, the driver checks for the argument size of each parameter passed to the kernel. This was, in fact, a bug in the TornadoVM runtime. This patch provides a fix by using all buffers of the same size, and then padding when necessary.
With this patch, TornadoVM can run many unittests, including Matrix Multiplication benchmarks. However, there are still some errors during the kernel launch only when using the TornadoVM Kernel API. The fix for this part will be provided in a separate PR. Additionally, some of the reductions produce not-correct results (only from 30XX GPUs with NVIDIA driver >= 510.60).
This will be also patched in a separated PR.
The TornadoVM backend for GPUs using NVIDIA Drivers <= 510.54 is still working as normal.
Backend/s tested
This PR only affects the PTX-backed,

[ ] OpenCL
[X] PTX
[ ] SPIRV

OS tested
Mark the OS where this PR is tested.

[X] Linux
[ ] OSx
[ ] Windows

Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.

[ ] Yes
[X] No

How to test the new patch?
$ make BACKEND=ptx
$ tornado -Ds0.t0.device=0:0 -m tornado.examples/uk.ac.manchester.tornado.examples.compute.MatrixMultiplication2D
$ tornado --threadInfo --printKernel -ea -Dtornado.unittests.verbose=True -Xmx6g -Dtornado.recover.bailout=False  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  uk.ac.manchester.tornado.unittests.reductions.TestReductionsFloats#testComputeAverage

All changes done


Undefined control sequence. [\DeclareTOCStyleEntries]

Hi,
I have these errors when compiling the example in MacOS 10.14.6
kaobook-master/styles/kao.sty:807: Undefined control sequence. [\DeclareTOCStyleEntries] kaobook-master/styles/kao.sty:807: LaTeX Error: Missing \begin{document}. [\DeclareTOCStyleEntries[] kaobook-master/styles/kao.sty:808: Undefined control sequence. [\DeclareTOCStyleEntries] kaobook-master/styles/kao.sty:809: Undefined control sequence. [\DeclareTOCStyleEntries] kaobook-master/styles/kao.sty:810: Undefined control sequence. [\DeclareTOCStyleEntries] kaobook-master/main 2.tex:140: Undefined control sequence. [\mainmatter]
Thanks
Alex

This was solved by updating Tex Live. Sorry for posting this issue too fast.


Fix json lint CI

Summary
Quick fix in order to fix the json lint CI.
Details

[x] edit tox.ini
[ ] testing

@HuangJunye I need your approval to launch the actions :)

@mickahell Sorry I totally missed the notification of your PR! Thanks a lot for the fix!


Ticking Entity Crash 1.20.1 Modpack Issue

In some cases, after loading into a world with the mod installed, the game immediately crashes. I believe an existing blood particle is causing it, but I don't know what else this crash report details.
I am on 1.20.1 Forge 47.3.5 with mod version 1.2.1.
modlist.txt (Full modlist)
crash-2024-10-07_22.52.32-server.txt (Crash file)
latest.log (Log file)

I've noticed this issue with a couple of other users. I have a new version of the mod coming out soon with tons of bug fixes, and this will be one of them. Thanks for the report!


releng/docker/image-build.sh: allow use of a local XBPS repo

A new -r argument to image-build.sh allows the specification of (at most one) local directory that will be mounted to /pkgs when preparing the container image. This allows, e.g., a local test version of ZFS just by specifying
./releng/docker/image-build.sh -r /path/to/host/repo zbm-builder:$(date '+%Y%m%d')

This isn't (yet?) exposed in releng/make-binary.sh or releng/tag-release.sh. On the one hand, this is a special-enough use case that we can require a manual build of the container image (because make-binary.sh will use an existing container image that matches the desired tag) to use the feature. On the other hand, I'm open to ideas on how to expose this up the chain.
While I was at it, I fixed the -headers cleanup so the container image won't hang on to linux{5.15,6.1}-headers.

would be nice if another http repo could be specified too

Any number of web repos can now be configured; only if none are specified will the old default (servercentral.com) be used. The local repo is still limited to one because I don't want to mess around with multiple binds at different locations in the container.

This has been completely rethought. Now, users can specify multiple -r arguments to mount multiple host directories as repositories that will be available when installing packages into the build-container image. The -R remote repositories are also written to a custom XBPS configuration file that should take precedence over the system default but will not mask it, meaning things like
./releng/docker/image-build.sh -r $XBPS_DISTDIR/hostdir/binpkgs/branch1 -r $XBPS_DISTDIR/hostdir/binpkgs/branch2 -R https://my-partial-repo.zfsbootmenu.org/current -R https://another-partial-repo.zfsbootmenu.org/current/ zbm-builder:tag

will just do the right thing, falling back to the default XBPS repo for any packages that can't be found elsewhere.
THAT'S RIGHT, WE FSCKING HAVE -R!!!!1


Update add-on installation to Django 1.8.7

This updates the issue-146 branch so that add-ons can be installed again.
The details of the changes, and how to test them, are in Solinea/goldstone-compliance#28.

@jxstanford:
I believe the bug you found is now fixed.  Please review again at your convenience...

:+1:


Issue credits to Evan

Issue 15000 credits to @gnomevan.

 Follow up
On Sunday, 24-Mar-24 04:48:55 UTC by Gov4Git dev
Issued 15000 credits to member @gnomevan.


Get constraint with this argument of the type parameter for comparisons

Fixes #21117
Without doing so, in the given test case, when we check if our inference is assignable to the inference constraint, we get to comparing the methods and see () => MessageList<T> -> () => U, which is not assignable. By getting the constraint with the this type correctly set, we now check () => U -> () => U, which works as expected.

@ahejlsberg We had a new report of the same bug with a much simpler test case: #24151
I've added it here and synced the branch - we really should accept this.


Helm chart with default values fails to install

The helm chart fails to install, and never gets past the init job.
How to reproduce the bug
helm repo add superset https://apache.github.io/superset
helm repo update
helm upgrade --install my-release superset/superset --namespace default

Expected results
I expected the helm chart to install successfully
Actual results
Release "my-release" does not exist. Installing it now.
Error: failed post-install: timed out waiting for the condition

When the init job runs, it fails to connect to the postgres DB:
wait-for-postgres 2023/05/25 20:17:20 Problem with dial: dial tcp: lookup my-release-superset-postgresql on <IP_ADDRESS>:53: no such host. Sleeping 1s
wait-for-postgres 2023/05/25 20:17:21 Problem with dial: dial tcp: lookup my-release-superset-postgresql on <IP_ADDRESS>:53: no such host. Sleeping 1s
wait-for-postgres 2023/05/25 20:17:22 Problem with dial: dial tcp: lookup my-release-superset-postgresql on <IP_ADDRESS>:53: no such host. Sleeping 1s
wait-for-postgres 2023/05/25 20:17:23 Problem with dial: dial tcp: lookup my-release-superset-postgresql on <IP_ADDRESS>:53: no such host. Sleeping 1s

The Kubernetes services are named my-release-postgresql AND NOT my-release-superset-postgresql.
Screenshots
N/A
Environment
(please complete the following information):

browser type and version: N/A
superset version: 2.1.0 (Helm Chart 0.10.0)
python version: N/A
node.js version: N/A
any feature flags active: N/A

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
None

This one is a little tricky to fix.
The DB host value is set to include the release-name and the chart name:
https://github.com/apache/superset/blob/9df8d8dda538095ba3b30d1f82aa81acf17e1c95/helm/superset/values.yaml#L255
I can fix it to only be the {{ .Release.Name }}, but then when namePrefix is set, the postgres DB service name doesn't include the release name anymore, while the DB Host variable does and doesn't include the namePrefix.
I could set the postgresql.primary.fullname to match the above, but that would be a breaking change for existing deployments.
So I think I'll need to make another helper that solves that logic.


Unable to import powershell module

Description
When trying to import CoAPP powershell module it fails with an error.
It works on Appveyor, see log https://ci.appveyor.com/project/igagis/utki/builds/36356667
So this is why I think something is wrong with the image.
Area for Triage:
.NET Framework
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[x] Windows Server 2019

Expected behavior
Module is imported without errors.
Actual behavior
The following error occurs:
Line |
   3 |  Import-Module CoApp
     |  ~~~~~~~~~~~~~~~~~~~
     | Could not load type 'System.Web.HttpException' from assembly 'System.Web, Version=<IP_ADDRESS>,
     | Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

Repro steps
See build: https://github.com/cppfw/utki/runs/1434602700?check_suite_focus=true

Hello, @igagis
The default shell for Windows Server 2019 is PowerShell Core, not a PowerShell Desktop. You should set up PowerShell Desktop in your pipeline:
    - name: import CoAPP module
      shell: powershell
      run: |
        $env:PSModulePath = $env:PSModulePath + ';C:\Program Files (x86)\Outercurve Foundation\Modules'
        Import-Module CoApp

Hi @al-cheb
Thanks, it worked.
One more question, my build now fails on build step saying that no msbuild is found, see build: https://github.com/cppfw/utki/runs/1442074622?check_suite_focus=true
Though, on previous step of nuget update seems like it has found some msbuild.
Any idea why could this be?
The build phase is done by the ps1 script https://github.com/cppfw/utki/blob/master/nuget/build_nuget.ps1
as you can see from that script, I'm running %VS142COMNTOOLS%\VsMSBuildCmd.bat first, so, in my understanding it should initialize all the PATHs needed to find proper build tools including msbuild...

@igagis , I think this issue contains information about msbuild behavior: https://github.com/actions/virtual-environments/issues/1978

@maxim-lobanov Thanks, that worked as well!
One more small question: is it possible to append something to an environment variable?
For example, now I'm doing it inside of the step's run:
run: |
        $env:PSModulePath = $env:PSModulePath + ';C:\Program Files (x86)\Outercurve Foundation\Modules'
        Import-Module CoApp

is it possible to do it somehow in env: property, so that I could do it once for all steps? Something like this:
env:
  PSModulePath: $PSModulePath;C:\Program Files (x86)\Outercurve Foundation\Modules
steps:
   ....

I tried this and it does not work as expected, $PSModulePath is not substituted. But maybe there is some correct syntax to achieve that?

Unfortunately, it is not possible in env section.
But you can use GA workflow command:
steps:
- run: echo "PSModulePath=$(env:PSModulePath);C:\Program Files (x86)\Outercurve Foundation\Modules" | Out-File -FilePath $env: GITHUB_ENV -Encoding utf8 -Append

This way, updated variable will be available in all next steps. See details in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

@maxim-lobanov Thanks a lot! It worked!
To ease the appending paths to env vars I have wrapped that command to an action: https://github.com/marketplace/actions/append-path-to-an-environment-variable-using-powershell


Upgrade to node16

Description

Use node 16 cause actions with node 12 are deprecated

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: nick-fields/retry

Testing

What tests were added?

These can be either "integration tests" or unit tests

Thanks for the contribution @muffl0n!


NoSuchMethod forwarder conflicts with a declared member for a canonical name

The following program makes the CFE crash:
abstract class I {
  String get member;
}

class A implements I {
  static String member = "member";

  dynamic noSuchMethod(Invocation i) => "foo";
}

The stack trace:
Unhandled exception:
root::file:///tmp/qwerty.dart::A::@getters::member is already bound to Reference to file:///tmp/qwerty.dart::A::@getters::member with node A.member (Field:6174), trying to bind to Reference to A.member with node A.member (Procedure:35005)
#0      CanonicalName.bindTo (package:kernel/canonical_name.dart:242:7)
#1      Class.computeCanonicalNames (package:kernel/ast.dart:1294:51)
#2      Library.computeCanonicalNames (package:kernel/ast.dart:517:14)
#3      Component.computeCanonicalNamesForLibrary (package:kernel/ast.dart:13679:13)
#4      BinaryPrinter.computeCanonicalNames (package:kernel/binary/ast_to_binary.dart:560:19)
#5      BinaryPrinter.writeComponentFile.<anonymous closure> (package:kernel/binary/ast_to_binary.dart:579:7)
#6      Timeline.timeSync (dart:developer/timeline.dart:163:22)
#7      BinaryPrinter.writeComponentFile (package:kernel/binary/ast_to_binary.dart:577:14)
#8      writeComponentToFile (package:front_end/src/fasta/kernel/utils.dart:77:13)

This should be a compile-time error. You are not allowed to have a static member with the same base-name as an inherited instance member. This includes interface members, not just concrete members.


CASM-4368: Delete cray-product-catalog details from main and sub cm for a product version

Summary and Scope
Added feature to delete cray-product-catalog details from main and sub cm for a particular product version
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASM-4368
Change will also be needed in <insert branch name here>
Future work required by [issue id](issue link)
Documentation changes required in [issue id](issue link)
Merge after <[Update PR](https://github.com/Cray-HPE/cray-product-catalog/pull/236)>

Testing
List the environments in which these changes were tested.
Tested on:

<development system>
Local development environment
Virtual Shasta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[ ] Target branch correct
[ ] Testing is appropriate and complete, if applicable
[ ] Is a new version being released? Update https://github.com/Cray-HPE/cray-product-catalog/wiki/CSM-Compatibility-Matrix
[ ] HPC Product Announcement prepared, if applicable

Have just one comment, otherwise looks good to me. (OfCourse, we need to add unit tests for newly added code.)

I know this is still a draft PR, but since I just got done reviewing the other two, I figured I'd leave my feedback on this one as well.
This one also should have tests added for the new delete functionality

I know this is still a draft PR, but since I just got done reviewing the other two, I figured I'd leave my feedback on this one as well.
This one also should have tests added for the new delete functionality

Added tests for delete functionality as different PR


Add tests

Related to issue #246

Pull Request Test Coverage Report for Build 580

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 88.734%

Totals

Change from base Build 578:
0.6%

Covered Lines:
2040

Relevant Lines:
2299

💛  - Coveralls

If statements were removed as they were redundant. Exceptions are handled at the parser/command level and should not reach the Model.


New release on package control?

Not sure where to post this, but any chance we could get a new release posted to package control?  I'm using my fork to get #28 and #29 so I can get a working version, but I'd love to get back onto an official release.

Done: v1.2.3

Thank you!
On Mon, Dec 5, 2022, at 9:50 PM, thep0y wrote:

Done: v1.2.3 https://github.com/thep0y/python-black/releases/tag/v1.2.3
—
Reply to this email directly, view it on GitHub https://github.com/thep0y/python-black/issues/30#issuecomment-1338801254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHG6D3PPIPZCUT7QWWTKMTWL3H2PANCNFSM6AAAAAASUVGA3Y.
You are receiving this because you authored the thread.Message ID: @.***>


Unsigned Framework

Thanks for your excellent works!
I am trying to build a demo following the instructions in a YouTube video. However, when I built the project following his guidance in 4:49, I got a building failed error message. One of the error messages in my Xcode is "The Framework “QuickPoseCore.xcframework” is unsigned. Xcode will be unable to verify if the author changes.".
There is no response for selecting the "Accept Unsigned" button.
Could anyone please help me on this matter?
Thanks!

Hi xiaobaishu0097
I believe a member of the team has reached out to you directly.
If in doubt please base projects on our simpler sample apps rather than the deep dive videos as these are hard for us to maintain as we extend the SDK and would need to keep re-shooting videos for the deep dives.
I'll close this ticket now but do get in touch if you have any further issues.


Missing the ability to insert Sliver children

Feature request
This request is similar to https://github.com/EdsonBueno/infinite_scroll_pagination/issues/48, however, the use case is actually not yet covered by the package (not that I know). Namely, we need section headers, which requires to have slivers as children of the paged list.
Current support
What you can do currently is implement a sticky header:
slivers: [
  StickySliverHeader(...),
  PagedSliverList(...),
],

However, you cannot have section headers, i.e.:
PagedSliverList(
  pagingController: viewModel.pagingController,
  builderDelegate: PagedChildBuilderDelegate<LearningPlansOverviewItem>(
    itemBuilder: (context, item, index) {
      if (item is SectionHeaderItem) {
        return SliverHeader(...);
      }
      return RegularItemTile(...);
  ),
),

Proposal
It would be nice to have a version of the PagedSliverList that allows to have a PagedSliverBuilderDelegate that allows you to return Slivers instead of regular widgets (render box contract).
@EdsonBueno if you have another idea how to solve this, let me know.

Hi @creativecreatorormaybenot ,
I'm curious to know how you'd do that with a regular SliverList, because it seems to me that no even SliverList supports this.

@EdsonBueno Why do you think that this is not possible?
The way you do it is by placing the sticky headers as slivers into the CustomScrollView (see this for example). You do not place inside of the SliverList, but that is also not how it is supposed to work.
The reason this is not possible with PagedSliverList is that the headers need to be added as part of the paging. That is, to support this, PagedSliverList would need to work with the sliver contract in a way where it places the header slivers in between sections of render box children.

By doing this, we would loose the ability to build children on demand, since CustomScrollView takes all its children at once, and not via a builder.
This library relies on having the children built on demand to know when it's time to fetch more items.

@EdsonBueno You can implement the same logic using a builder.
That is also what I am saying btw - this is possible without pagination / a builder, but with the pagination package it is not possible at the moment. It would of course need to be implemented.

We need this feature

Adding some more example to this request. I stumbled upon exactly this same problem recently. My use case is as follows:

Full page needs to be vertically scrollable.
Page starts with title, followed by on horizontal list, followed by a paged grid which is grouped in sections with section title as header.

I stumbled upon this example for sticky header which uses sliver_tools for sticky header. They use simple trick of returning a MultiSliver in a sliver based list.
The way PagedSliverList is implemented in this package, it only accepts PagedChildBuilderDelegate which has an item builder from which we are not allowed to return sliver based widget. It is mandatory to return a RenderBox based widget. It breaks if we return a RenderSliver based widget from PagedChildBuilderDelegate's item builder.

This issue can be solved by creating a custom layout that allows for this logic.
If you desire to essentially have a "grouped list", this is actually quite easily possible with the grouped_list package and a small bit of glue code, that I have already written. You can see that here: https://github.com/EdsonBueno/infinite_scroll_pagination/issues/264#issuecomment-1682954132
I hope that satisfies your requirements.


Translate complete DU settings to German

All DirtyUnicorns settings are in German now.

Please merge.

Oops, missed this one... Will merge tonight.  Thanks.
On May 6, 2016 1:54 AM, "Trafalgar-Square"<EMAIL_ADDRESS>wrote:

Please merge.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/scotthartbti/android_packages_apps_DUI/pull/1#issuecomment-217353610


feat: plugins

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[x] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] I have added necessary documentation (if appropriate)

Description
Setup Gatsby Plugins
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

Thank you @riteshsp2000 🔥🔥🚀


ability to generate plaintext version

I currently use Zurb Foundation Email templates and send it to a Premailer server which generates both html and plaintext version.  I would like to switch over to mj but it seems I would have to give up my automatic plaintext generation feature as mj appears not to provide plaintext.
Describe the solution you'd like
api returns both html and plaintext version of the template
Describe alternatives you've considered
Premailer service returns both html and plaintext in the single response
Additional context
I am unsure of the value of this feature request.  Can you give feedback on the current value to spam filters and end users of sending a plaintext version along with html?  Perhaps I can switch to mj and not worry about plaintext anymore.  Or do you recommend users generate a plaintext version on their own and send that along with mj template result?

Hey @Enalmada,
Why don't you keep using Premailer with MJML? You just need to submit the HTML generated from MJML to Premailer and get the plain-text version, like you're doing currently.
About your question, it's good to add a plain-text version to your emails for people using an email client that doesn't support HTML (even if it's generally rare).

Thanks for the feedback about plain-text still being a best practice.  I will continue to use premailer for now.  Premailer homepage says it is no longer being maintained so I am keeping my eyes out for a more modern solution.  What do you recommend or think most mjml users are doing to generate plain text versions of email?  I am curious to factor that into how impactful this feature request could be to the community.

html2text is an excellent suggestion I will look into further.  Part of me just guesses premailer probably has a few years worth of open source code tuned for some specific "html to email" cases that could be worth incorporating into mjml.  The other part of me would not be that surprised if all premailer was doing was calling html2text.  Would mjml consider adding something like a new flag "--plaintext" that would give users similar functionality?

Probably not, we want to focus on generating responsive email HTML (which is also why we don't want to add templating language features in MJML).
Also, there are already good solutions for generating text from HTML so we don't want to reinvent the wheel by creating a parser MJML -> Text. An alternative would be to use a tool and do MJML -> HTML -> Text but that defeats the purpose of implementing it in MJML, and you'd be better off doing that using the tool of your choice.
I'll close the issue but feel free to add any comment based on what you end up using and your feedback about the tool you try as it could be helpful for others :).


Improve the documentation on the MSFR model on neutronics part

Close #166.

Job VTB Documentation on 7fb1c43 wanted to post the following:
View the site here
This comment will be updated on new commits.

I dont understand why the fission source would not be consistent with the power though, that wouldnt make sense?

Power density is ok because it is normalized to the total power. DNP, fission source and fluxes are unnormalized.

wrt to neutronics we output fission source and input DNP both in the same unnormalized state. So maybe that s why it's ok?

No, we are missing 1/k in the right hand side of Eq. 3 of this page: https://mooseframework.inl.gov/virtual_test_bed/docs/PRs/167/site/msr/msfr/griffin_pgh_model.html. f (fission source) is different from Q (power density). Probably missing 1/k will affect the power density shape slightly.

I know but this equation is linear. So this means our precursors are also off by 1/k, same as the fission source.
And if Griffin expects unnormalized precursors then we are consistent.
What does Griffin expect as external input precursors?
And if it expects normalized, does it really output unnormalized?

During eigenvalue calculation, x is unnormalized, but the power density p is, p = (P/|A*x|) A * x , where A is the fission energy production matrix, |A*x| represents the total unnormalized power, P is the total rated power. p is passed to energy equation in fluid. If we have feedback and we change P, we will get different k. dk/dP is known as the power coefficient.

I think we would want to normalize on the Griffin input side then transfer. So it would only inflate that input


Xcode 15 beta and Firestore 10.10: The signature of “gRPC-C++.xcframework” cannot be verified

Description
In Xcode 15 beta, updating to Firebase 10.10 throws a build error. "The signature of “gRPC-C++.xcframework” cannot be verified."
The full error is:
/Users/username/Library/Developer/Xcode/DerivedData/OptimisingFirestore-ejvnmdkwtmsvjjbnruaonpkfzunf/SourcePackages/artifacts/grpc-binary/gRPC-C++/gRPC-C++.xcframework:1:1: error: The signature of “gRPC-C++.xcframework” cannot be verified.
    note: Codesign verification failed
    note: /Users/username/Library/Developer/Xcode/DerivedData/OptimisingFirestore-ejvnmdkwtmsvjjbnruaonpkfzunf/SourcePackages/artifacts/grpc-binary/gRPC-C++/gRPC-C++.xcframework: bundle format unrecognized, invalid, or unsuitable

This issue does not occur when using Xcode 14.3, even when building for iOS 17 targets. As a temporary fix, downgrading to Firebase 10.8.1 resolves the issue.
Reproducing the issue

Download Xcode 15
Download the sample project  (or just create a new Xcode project in Xcode 15 and install Firestore)
Observe that there are no issues when building
Update Firebase to 10.10
Observe that the error listed above is thrown

Firebase SDK Version
10.10
Xcode Version
15
Installation Method
Swift Package Manager
Firebase Product(s)
Firestore
Targeted Platforms
iOS
Relevant Log Output
/Users/username/Library/Developer/Xcode/DerivedData/OptimisingFirestore-ejvnmdkwtmsvjjbnruaonpkfzunf/SourcePackages/artifacts/grpc-binary/gRPC-C++/gRPC-C++.xcframework:1:1: error: The signature of “gRPC-C++.xcframework” cannot be verified.
    note: Codesign verification failed
    note: /Users/username/Library/Developer/Xcode/DerivedData/OptimisingFirestore-ejvnmdkwtmsvjjbnruaonpkfzunf/SourcePackages/artifacts/grpc-binary/gRPC-C++/gRPC-C++.xcframework: bundle format unrecognized, invalid, or unsuitable

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

{
  "pins" : [
    {
      "identity" : "abseil-cpp-binary",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/abseil-cpp-binary.git",
      "state" : {
        "revision" : "bfc0b6f81adc06ce5121eb23f628473638d67c5c",
        "version" : "1.2022062300.0"
      }
    },
    {
      "identity" : "firebase-ios-sdk",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/firebase-ios-sdk",
      "state" : {
        "revision" : "5034479ca0c4f32f299677fb0ba1fe4d3e3e20b4",
        "version" : "10.10.0"
      }
    },
    {
      "identity" : "googleappmeasurement",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleAppMeasurement.git",
      "state" : {
        "revision" : "69f5b8425dd473d2f2475bba7f88f82cd9da0e36",
        "version" : "10.10.0"
      }
    },
    {
      "identity" : "googledatatransport",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleDataTransport.git",
      "state" : {
        "revision" : "7874c1b48cbffd086ce8a052c4be873a78613775",
        "version" : "9.2.3"
      }
    },
    {
      "identity" : "googleutilities",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleUtilities.git",
      "state" : {
        "revision" : "871d43135925cde39ef7421d8723ce47edfdcc39",
        "version" : "7.11.1"
      }
    },
    {
      "identity" : "grpc-binary",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/grpc-binary.git",
      "state" : {
        "revision" : "2b7656d8ee892cd39db460b1a0d849de618405e6",
        "version" : "1.50.1"
      }
    },
    {
      "identity" : "gtm-session-fetcher",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/gtm-session-fetcher.git",
      "state" : {
        "revision" : "d415594121c9e8a4f9d79cecee0965cf35e74dbd",
        "version" : "3.1.1"
      }
    },
    {
      "identity" : "leveldb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/leveldb.git",
      "state" : {
        "revision" : "0706abcc6b0bd9cedfbb015ba840e4a780b5159b",
        "version" : "1.22.2"
      }
    },
    {
      "identity" : "nanopb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/nanopb.git",
      "state" : {
        "revision" : "819d0a2173aff699fb8c364b6fb906f7cdb1a692",
        "version" : "2.30909.0"
      }
    },
    {
      "identity" : "promises",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/promises.git",
      "state" : {
        "revision" : "ec957ccddbcc710ccc64c9dcbd4c7006fcf8b73a",
        "version" : "2.2.0"
      }
    },
    {
      "identity" : "swift-protobuf",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/apple/swift-protobuf.git",
      "state" : {
        "revision" : "f25867a208f459d3c5a06935dceb9083b11cd539",
        "version" : "1.22.0"
      }
    }
  ],
  "version" : 2
}

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

In the meantime, a workaround would be to go back to the Firestore source distribution in Firebase 10.7.0 or earlier.

Hi everyone, this issue should be fixed with a newly released gRPC version. Please update your package dependencies to pull this in.

this fixed the issue, but opened a new segmentation problem:I get this compiler error when deploying "Unable to execute command: Segmentation fault: 11" and "Linker command failed due to signal (use -v to see invocation)"

(Xcode 15 Beta of course)

Hmm, I'm not reproducing that @TuncayEnsi in my sample app. What device/OS are deploying to? Are you deploying to the simulator?

No to a physical device, I am not able to. I am not getting any error when previewing in swiftUI thou...

iPhone 12 Pro Max

@TuncayEnsi, I'm not too sure what is going on. I was able to successfully deploy to an iPhone XR running iOS 16.4.

Could this be related to your project's bitcode configuration? See this SO answer. I'm trying to understand why it's throwing the segmentation fault..

Thanks for the answer!
I figured it had something to do with that. But I cannot find this option as shown in Stackoverflow in Xcode 15 any longer.
Therefore I cannot turn that of.
Is this something caused by me or has apple moved that?

Am 06.06.2023 um 22:57 schrieb Nick Cooke @.***>:
Could this be related to your project's bitcode configuration? See this https://stackoverflow.com/a/41454965/9331576 SO answer. I'm trying to understand why it's throwing the segmentation fault..
—
Reply to this email directly, view it on GitHub https://github.com/firebase/firebase-ios-sdk/issues/11401#issuecomment-1579441330, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2HWLXOSLTAREOVU6EBGPG3XJ6KUVANCNFSM6AAAAAAY4C57ZM.
You are receiving this because you were mentioned.

Deploying to iOS 17 Beta

@ncooke3 yes deleted all those files; also cleaned build folder via Xcode several times, still running into this

Hi everyone,
Not sure if others are still experiencing the issue & I'm going to be honest -- I am not at all a pro when it comes to Xcode but, after the whole day of trying different things and suggestions I managed to resolve the issue by:

Removing the Package Dependency
Clean Build Folder...
Quitting and relaunching Xcode
Reintalling [https://github.com/firebase/firebase-ios-sdk] to "Up to Next Major Version" 10.10.0 < 11.0.0
Going into "Xcode" in the menu bar and pressing "settings"
Going to the Locations
Re-configure the Command Line Tools

No idea if they're fully connected together but, it seemed to have work & my app is running as it was with firebase and no more errors are appearing.

thanks for the insight, for me nothing changed thou still not able to deploy to a real device

I read a lot of articles saying that bit coding is deprecated since Xcode 14

@TuncayEnsi, I'm not sure if there is anyway to configure bit code at this point. See this note. This makes me think the issue is something else. But I'm not sure if it's Firebase related–– did you try building and deploying your app with an older version of Firebase like 10.7.0 (see @paulb777's comment above)?

Build and deploying works and everything working fine on Firebase 10.7.0, I guess the problem is firebase therefore?

I will Stick to that version as it deploys on iOS 17 until this gets fixed. Is there anything bad about doing that?

I am also wondering why gRPC is not throwing the same signing issue in this version as it has also been downgraded

I will Stick to that version as it deploys on iOS 17 until this gets fixed. Is there anything bad about doing that?

Nothing bad, but there are some various bug fixes and features that 10.7.0 does not include. With regard to Firestore, 10.8.0 and above gives much faster build times for Firestore.

I am also wondering why gRPC is not throwing the same signing issue in this version as it has also been downgraded

gRPC is not throwing the same signing issue in this version likely because it is being built from source rather than a binary. In Firebase 10.8.0+, gRPC is included as a pre-compiled xcframework. This xcframework has a certificates bundle in the xcframework's Resources directory. In Xcode 15, such a bundle that's part of a binary distribution needs to be signed accordingly. In our case, this certificates bundle isn't used so I removed it in the latest gRPC release that I released today– which fixed the signing issue as signing was no longer needed.

Sincere apologies for the trouble here @TuncayEnsi, and thank you for helping narrow things down. It seems that Firebase 10.8.0+ is the issue, but I still don't know why. I will continue looking into it. If you are able to provide a minimum reproducible example project or error messages with any greater level of detail– that'd be greatly appreciated.

IIUC, the "signature" issue is solved and simulator development and some device development is now functional. Perhaps we should open a separate issue for the Segmentation fault on deployment to iOS 17?

Closing this one and will open an issue for the segmentation fault issue.


GetFilteredTransaction Expecting Value

We tried testing the GetFilteredTransaction from the blogpost on the cloud Strawberry GraphQL. After running it, we run into the error of
""message": "Expecting value: line 1 column 747 (char 746)",". We went into the discord to get help from @kaustubhKVS  We tried getting around the error by getting an owner and recipient public key by generating a key, setting the transaction, and getting the transaction to get working public keys. Even after entering public keys, we end up with an error
" "message": "Expecting value: line 1 column 747 (char 746)",".
After putting in the owner and recipient public key, we expected to get a list of data between the two users.

@apratimshukla6 @kaustubhKVS

The issue was caused due to a bug in parsing the JSON data after single characters had been committed to ResilientDB via the command line. This issue has now been resolved via regex and pulling the latest commit will fix it.


Update master README.md file for known issues

this is to address:
https://github.com/googlesamples/android-ndk/issues/61

LTGM.


errors running the application

I'm getting errors and here's one of them:
Process-5: Error processing video for event<PHONE_NUMBER>.169877-v4prgt
Traceback (most recent call last):
File "/app/./mqtt_client.py", line 303, in process_message
json_str = response.json()["choices"][0]["message"]["content"]
Dumb question but am i supposed to do the following on the host machine or in the container:
"Alternatively, you can simply install deps in requirements.txt, set .env and run mqtt_client.py."
I did everything in the instructions except the above since it said "alternatively". Does that mean my installation didn't go smooth? Or is this step mandatory? Thanks

Looks like my problem was that the openai key wasn't set correctly. I may have rectified the issue.

@Sceptersax if you haven't fixed it, try delete the prompt in the config file

Good to know thanks. My biggest issue with openai is the fact that it's just way to restrictive in terms of describing a person. It's very politically correct. I guess i can try to formulate different ways of query.


Font height

Is it possible to get an accurate height of a text string in a certain font and size? I tried to use nvgTextBounds but the height of the calculated bounding box (difference of ymax and ymin) is usually too large. I want to draw a rectangle around the text without any space to the top of the highest and bottom of the lowest letter.

The best way - to use font size as row height
IMHO it would be better choice.


EDA - histogram app constraints allow an integer ordinal but back end only allows continuous

production site and dev
GEMS 1
visualisation
histogram
x = Study year

Rserve log
2024-03-22 11:37:35.852115 Value is set to `count`. Resulting histogram object will represent counts of unique x-axis bins per group.
Error in validateHistogramPD(.histo, verbose) :
  The independent axis must be continuous for a histogram.

Variable metadata. (type=integer, shape=ordinal)

apps constraints for pass->histogram
{
	"0": {
		"name": "histogram",
		"displayName": "Histogram",
		"description": "Visualize the distribution of a continuous variable",
		"projects": [
			"ClinEpiDB",
			"MicrobiomeDB"
		],
		"maxPanels": 1,
		"dataElementConstraints": [
			{
				"xAxisVariable": {
					"isRequired": true,
					"minNumVars": 1,
					"maxNumVars": 1,
					"allowedTypes": [
						"number",
						"date",
						"integer"
					],
					"description": "Variable must be a number or date."
				},
				"facetVariable": {
					"isRequired": false,
					"minNumVars": 1,
					"maxNumVars": 2,
					"maxNumValues": 10,
					"description": "Variable(s) must have 10 or fewer unique values and be of the same or a parent entity as the Overlay variable."
				},
				"overlayVariable": {
					"isRequired": false,
					"minNumVars": 1,
					"maxNumVars": 1,
					"maxNumValues": 8,
					"description": "Variable must have 8 or fewer unique values and be of the same or a parent entity as the X-axis variable."
				}
			}
		],
		"dataElementDependencyOrder": [
			[
				"xAxisVariable"
			],
			[
				"overlayVariable",
				"facetVariable"
			]
		]
	}
}

Seems that it should also be allowedShapes: [ 'continuous' ], ?

I think this would affect the map supporting histograms too.
I have not been able to find an integer ordinal variable for a mappable study, however.


@vue/server-renderer renderToString generating incorrect srcset URL for source elements within a router link

Version
3.0.11
Reproduction link
https://github.com/lukewarlow/vue-server-render-bug
Steps to reproduce
Clone the git repository. Run npm install and then npm run generate. This will generate a dist/static/index.html file. (One is already generated)
What is expected?
The generated html file should have two picture elements which point to different images in both the source element and the img element. As seen in the source file at src/views/Home.vue.
What is actually happening?
In dist/static/index.html you will be able to see that the img elements have different src values which is correct. But the source elements both have the same srcset value which is incorrect.

I've updated my test case to Vue 3.1.0-beta5 (https://github.com/lukewarlow/vue-server-render-bug) but I still experience the issue with incorrect srcset in the SSR output. Is there some change I need to make to my SSR code?


Starting with jQuery

Proposed title of article
Starting with J query
Introduction paragraph (2-3 paragraphs):
To get started with JQUERY one need to Download the jQuery library from jQuery.com.
Include jQuery from a CDN, like Google After setting up the environment and including reference of jQuery library in your web page, it's time to use jQuery
JQUERY has some of the functions. Jquery () function
When you open your web page in a browser and load jQuery library successfully, it adds a global function named jQuery().
Key takeaways:
helps the learner to understand:

Query makes use of powerful, clean, and simple syntax that makes it easier to pick the DOM elements on the webpage that you want to change with JavaScript
enable you to chain effects and actions together for effective code

References:
N/A

Good afternoon and thank you for submitting your topic suggestion. @jakim34511171
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Hi, @jakim34511171. It's been some time since we suggested you should alter your topic to add more unique value to our readers. We are closing this now to make more room in our queue but feel free to reopen it once you're ready to tweak your topic to be more unique and provide more value to our readers.


The addVitePlugin example code in the docs does not work.

VitePWA is of type Plugin[], but addVitePlugin takes only Plugin type.
Docs
vite-plugin-pwa

I know we should probably change the docs example now, but do you plan to receive Plugin[] in the future?
PS. It's an example, so I'm not sure if it should be changed.

Good catch! I think the correct type for this is PluginOption

You're right! Sounds like a quick fix if you want to tackle it @ktym4a!

Let me tackle it!


Support quorum network

Not a standard, but widely adopted in its documentation.
https://docs.goquorum.com/en/latest/Getting Started/running/#configurable-transaction-size

Thanks for the PR @kigawas! Unfortunately I'm going to reject it since we don't have the bandwidth at the moment to properly ensure Quorum compatibility and I feel this may give a false impression in that direction.

@frangio
NP.
At least it's necessary to make it possible to config custom networks, do you agree?

That sounds reasonable if you want to open an issue about it.


Restores may hang or crash the app on Unc0ver

Notes:

Seems to be totally at random
Occurs with either backup
No crash log
No error messages
Syslog unhelpful?

Fixed and/or documented in v2.2.0.


Allow Configuration params via CLI

Which params are missing?

I think something about AppXManifest.xml properties. Like Language and BackgroundColor


Adds full example command line to run-operation docs

Description & motivation

Thanks @mirnawong1 no worries!


How to get image URL after use Sharp for image compression

I use cloud function for compressing the images. I don't know to get image URL after compressing

// upload file
        .then(() => {
		      if (debug) {
		        console.log(`Uploading ${tmpFile} to ${FilePath}`)
		      }
		      return bucket.upload(tmpFile, { destination: FilePath })
		    })
        // make download URL
        .then(file => {
		      if (debug) {
		        console.log('Generating Long-term download url')
		      }

		      // save the file's metadata to our inventory item
		      item.image = file[0].metadata

		      let config = {
		        action: 'read',
		        expires: '12-31-2591'
		      }
		      return file[0].getSignedUrl(config)
		        .then(data => {
		          return data
		        })
		    })

`const bucket = gcs.bucket(fileBucket);
const thumbFileName = `${fileName}_100X100`;
const thumbFilePath = path.join(path.dirname(filePath), thumbFileName);

// Create write stream for uploading thumbnail
const thumbnailUploadStream = bucket.file(thumbFilePath)

const pipeline = sharp();
// Create Sharp pipeline for resizing the image and use pipe to read from bucket read stream
pipeline
  .resize(profilePicHomePage[0], profilePicHomePage[1])
  .max()
  .pipe(thumbnailUploadStream.createWriteStream({
    metadata: {
      contentType: 'image/jpeg',
      metadata: {
        custom: customMetadata
      }
    }
  }));
bucket.file(filePath).createReadStream().pipe(pipeline);`

This my code, So I don't know how to get file URL after pipe

@lagmanzaza
After compressing the iamge. You should be re-uploading it in Google Cloud Storage (using bucket.upload).
Once that's done you can generate a downloadURL (using getSignedUrl )
This is what the code shown by @joemanfoo does. You can refer to it.
One additional step would be to save the download URL somewhere so that you can retrieve it on the client (I'm guessing that's what you want to do...) for that you could save the download URL you generated in the Realtime  Database for instance.
If you are looking for an example we are doing this in the generate-thumbnail sample:
https://github.com/firebase/functions-samples/blob/master/generate-thumbnail/functions/index.js

Thank you very much

@lagmanzaza can you share how did you accomplish that?

Ok, got it working.
// Get the file name.
      const fileName = path.basename(filePath);
      // Exit if the image is already a thumbnail.
      if (fileName.startsWith('thumb_')) {
        console.log('Already a Thumbnail.');
        return;
      }

      // Download file from bucket.
      const bucket = gcs.bucket(BUCKET);

      // We add a 'thumb_' prefix to thumbnails file name. That's where we'll upload the thumbnail.
      const thumbFileName = `thumb_${fileName}`;
      const thumbFilePath = path.join(path.dirname(filePath), thumbFileName);
      const thumbFile = bucket.file(thumbFilePath);
      // Create write stream for uploading thumbnail
      const thumbnailUploadStream = bucket.file(thumbFilePath).createWriteStream({
        metadata: {
          contentType: 'image/jpeg'
        }
      });

      // Create Sharp pipeline for resizing the image and use pipe to read from bucket read stream
      const pipeline = sharp();
      pipeline
        .resize(THUMB_MAX_WIDTH, THUMB_MAX_HEIGHT)
        .max()
        .pipe(thumbnailUploadStream);

      bucket.file(filePath).createReadStream().pipe(pipeline);

      const streamAsPromise = new Promise((resolve, reject) =>
        thumbnailUploadStream.on('finish', resolve).on('error', reject));

      streamAsPromise.then(() => {
        console.log('Thumbnail created successfully');
        const config = {
          action: 'read',
          expires: '03-01-2500'
        };
        thumbFile.getSignedUrl(config).then((thumbResult) => {
          console.log('Got Signed URLs.');
          const thumbFileUrl = thumbResult[0];
          resolve({ thumbnail: thumbFileUrl });
        });
      });

Expires next day even though specifying the date 03-01-2500
const config = {       action: "read",       expires: "03-01-2500"     };     const results = await Promise.all([       thumbFile.getSignedUrl(config),       file.getSignedUrl(config)     ]);

It's not clear on any documentation how to get URL  on admin to be used on <img> tags for instance.
The expires won't work because the maximum date is 7 days, several examples are wrong ...
You can see on documentation..
https://cloud.google.com/storage/docs/access-control/signed-urls#example
or here ...
https://googleapis.dev/nodejs/storage/latest/File.html#getSignedUrl
Examples like this one.. will expire in 7 days.....
https://github.com/firebase/functions-samples/blob/5cf35c2d4a0965e4e70165add3127f50cfcaa3c2/generate-thumbnail/functions/index.js#L87


vulkano-shaders example errors

I'm getting errors about vulkano_shaders::compile and vulkano_shaders::ShaderKind not being part of vulkano_shaders.

Sorry, can I get more details? Copy and paste the full error would be nice. It sounds like your getting this error when running an example? Which one?

This is the example:
https://github.com/vulkano-rs/vulkano/blob/master/vulkano-shaders/examples/example.rs
Notice on line 42:
vulkano_shaders::compile
The error I was getting was saying compile was not part of vulkano_shaders. Same with ShaderKind.

My bad, your original post was fine, I misread "vulkano-shaders example errors" as "vulkano example errors". This will be because of rececnt changes making git master out of sync with the crates.io released version. vulkano-shaders is mostly an implementation detail of vulkano, it generates rust code to be embedded in a vulkano application. So I'm not sure what you actually want to do with it. Maybe you are after something like https://github.com/google/shaderc-rs ?

No worries. Yes, I was using shaderc before, but thought I might not be doing something right, so I just wanted to try vulkan_shader. I thought the example might be out of date, but I didn't know it was just a code generator. Thanks for clearing things up.


🐛 BUG: stripe not working in page functions

What version of Wrangler are you using?
2.1.15 (also 2.2.2)
What operating system are you using?
Linux
Describe the Bug
Need stripe webhooks - it's a common use-case. AFAIK stripe should work as it works in cloudflare workers? https://blog.cloudflare.com/announcing-stripe-support-in-workers/
I also tried with --node-compat (wrangler pages dev ./dist --node-compat) but that brought about some strange internal errors with crypto signing.
// functions/hooks/payment.ts
import stripe from "stripe";

export async function onRequestPost({ env, request }) {
    // Match the raw body to content type application/json
    const sig = request.headers.get("stripe-signature");
    const body = await request.text();
    let event: Stripe.Event;
    try {
        event = stripe.webhooks.constructEvent(
            body,
            sig,
            env.STRIPE_WEBHOOK_SIGNING_SECRET
        );
    } catch (err: any) {
        console.error(err);
        return new Response(`Webhook Error: ${err.message}`, {
            status: 400,
        });
    }
    return new Response(JSON.stringify({ received: true }), {
        headers: {
            "Content-Type": "application/json;charset=utf-8",
        },
    });
}

Commands
npm add stripe
wrangler pages dev ./dist
Output
🚧 'wrangler pages <command>' is a beta command. Please report any issues to https://github.com/clo
udflare/wrangler2/issues/new/choose
▲ [WARNING] No compatibility_date was specified. Using today's date: 2022-11-15.

  Pass it in your terminal:

  --compatibility-date=2022-11-15

  See https://developers.cloudflare.com/workers/platform/compatibility-dates/ for more information.

Compiling worker to "/tmp/functionsWorker-0.43775990890548866.js"...
✘ [ERROR] Could not resolve "crypto"

    node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/crypto/NodeCryptoProvider.js:2:23:
      2 │ const crypto = require('crypto');
        ╵                        ~~~~~~~~

  The package "crypto" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "crypto"

    node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/utils.js:4:23:
      4 │ const crypto = require('crypto');
        ╵                        ~~~~~~~~

  The package "crypto" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "http"

    node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/net/NodeHttpClient.js:2:21:
      2 │ const http = require('http');
        ╵                      ~~~~~~

  The package "http" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "https"

    node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/net/NodeHttpClient.js:3:22:
      3 │ const https = require('https');
        ╵                       ~~~~~~~

  The package "https" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

4 error(s) and 0 warning(s) when compiling Worker.

✘ [ERROR] Build failed with 4 errors:

  node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/crypto/NodeCryptoProvider.js:2:23:
  ERROR: Could not resolve "crypto"
  node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/net/NodeHttpClient.js:2:21: ERROR:
  Could not resolve "http"
  node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/net/NodeHttpClient.js:3:22: ERROR:
  Could not resolve "https"
  node_modules/.pnpm/stripe@10.17.0/node_modules/stripe/lib/utils.js:4:23: ERROR: Could not resolve
  "crypto"

If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/i
ssues/new/choose
 ELIFECYCLE  Command failed with exit code 1.

@mikob this might help: https://jross.me/verifying-stripe-webhook-signatures-cloudflare-workers/

@rozenmd thanks very much, the workaround works :+1:! For others doing this workaround, make sure to modify your build command to something like this:
package.json
...
    "build": "[build your frontend...] && wrangler pages functions build --node-compat && cp _worker.js dist",
...

Since Stripe version 11.10.0, node_compat is no longer needed and you can simply import it in Workers/Functions without issue, so this can probably be closed out 🎉

Confirmed working with Stripe 11.10+ without node_compat for me.


build failure with gcc 4.3.5

  CC      build-blackfin/dns/client.o
src/dns/client.c: In function 'async_getaddrinfo':
src/dns/client.c:785: error: storage size of 'hints' isn't known
src/dns/client.c:794: error: 'AI_ADDRCONFIG' undeclared (first use in this function)

With reverted https://github.com/baresip/re/commit/6729125f93d171ff379fc75a0a6f42b26168f5b7 re builds again.

When looking in src/sa/sa.c, which compiles we have:
#ifndef WIN32
#include <arpa/inet.h>
#define __USE_POSIX 1  /**< Use POSIX flag */
#define __USE_XOPEN2K 1/**< Use POSIX.1:2001 code */
#define __USE_MISC 1
#include <netdb.h>
#endif

Using same snippet for client.c and also net.c then re compiles successfully.


Change unlock password to "unlock passcode"

Users confuse unlock password with Alby Account password. This minor copy change from "password" to "passcode" may help a bit pointing out the difference.
I also prepared a new illustration for onboarding form that will better show how it works:

With that change I also think we can improve copy here a bit (I do not think mentioning Alby Account here serves purpose, as users still confuse this and many users will not use Alby Account at all or don't know yet what is it.).
Current:
Set an unlock password
This password is used to protect your wallet and provide access to the browser extension. It cannot be reset and is separate from your Alby account password.

Proposed:
Set an unlock code
This passcode will allow you to unlock Alby on this device.
It cannot recovered, but may be changed later.

Note: this screenshot is based on new proposed layout #2250 , but changes to copy and screenshot can be applied to current layout as well)

Hello, Can I propose a design-based solution for this issue?

Although, passcode is a better option to point out the difference from password, in my opinion if we could ask the user to choose a "key" and if we could mention unlock alby or unlock extension, it would make it clearer for the user.

@nishtha1425 We will soon introduce Secret Key (seed phrase) for nostr and other protocol keys, so I'd rather not use key in this context. Do you have some other design in mind or just copy change?
I added "browser extension" to the copy btw

Is the confusion only while choosing the unlock passcode or while trying to access the extension?

I think both, depending on a user. The confusion comes from the fact that Alby account users can log in with password, so sometimes they think this screen asks them to use their Alby account password (it also comes down that they also confuse alby web wallet account with the extension)

exactly, so that is what i wanted to say that mentioning it in copy is important but other than that when the user has to put in the unlock passcode at that time we can specify "unlock alby extension" instead of "unlock to continue". I am suggesting change in the unlock screen also other than copy change. Like for example when we have to use any payment wallet the passcode to unlock the application is asked before we open the app and then when we have to make any transaction a different password is required. So when we open that app it says "Unlock app".
This the only suggestion i had in mind.
Thank you

@nishtha1425 I am not sure I understand your suggestions. There's no password when users are making transactions.
They unlock the extension every time they turn on the browsers. They need Alby account password if they want to use it in the extension, but they need to use it one time only.
If you'd like to propose some particular design changes, here's a master file of the extension design that you can copy and play around with!

@stackingsaunter The new designs are excellent! Cheers, Could you try adding an arrow to the next button as a visual cue that suggests a progression or movement forward? It could also be used to fill the negative space.

We have to change the password to passcode here @stackingsaunter do I understand the solution right ??

@Pratik-A-N yes,

[ ] change copy to:

Set an unlock code
This passcode will allow you to unlock Alby on this device.
It cannot recovered, but may be changed later.

[ ] change "unlock password" to "unlock passcode" everywhere in the extension

@stackingsaunter can you assign this issue to me I'm starting to work on it

Yes, I agree that it is confusing to have 2 different passwords (one to unlock the extension, and one for the Alby Account). A possible analogy is the login PIN on Windows vs the Microsoft Account password, or the unlocking pattern on an Android phone vs the Google Account password.
Using two different words for password (passcode and password) might not IMHO be a clear hint, and it might even be difficult to translate into other languages, I foresee that the translation might be the same word for both cases, or even passcode might be translated as something that accepts only numbers.


[Host | Host.Outbox | Host.Outbox.Sql] #260 - Sql outbox performance improvments (batching + optimised queries)

This comes as (another) unsolicited/undiscussed PR after investigating some performance issues that I was experiencing. Please feel free to be absolutely brutal with it and/or any aspect that is not to your liking.
The most jarring change is probably going to be with the addition of IMessageBusBulkProducer and the required changes to MessageBusBase.ProduceToTransport to allow batching and access from OutboxSendingTask.
Changes:

SQL far more performant. Index improvements, limiting soft locks to fewer rows and single queries/TVP's have had a profound impact. In testing, I was seeing no performance degradation as the table grew to several million entries.
OutboxSettings.MaintainSequence = false will allow for load balanced instances to process the outbox together (default is true to keep same behaviour).
MessageBusBase.ProduceToTransport signature has been changed to accept multiple messages for the same bus/path. Serialization has also moved into the method to allow the same.
OutboxForwardingPublishInterceptor is ordered with max int to ensure that it is the last interceptor to run. Publishing of messages from the outbox do not run through the interceptor pipeline (already done so before being placed in the outbox).
Batching support has been added to the Azure Service Bus and Azure Event Hub providers. Publishing of messages is in multiple orders of magnitude quicker than before (not benchmarked). Messages are submitted in batches of up to 100 by default.

The submission is lacking in additional unit tests at the moment (can be added once direction is determined), but existing tests should cover most scenarios as the flow should not change. One test was removed as it was no longer relevant.

Again, I completely understand that this is undiscussed. It was thrown together while looking at what could be done to improve the implementation, so please feel free to fob it off as heading in the wrong direction or give any changes that you feel would provide something more to your liking.
-Richard

Thanks for looking into this.
Yes, I believe the outbox could have deserved a performance Improvement pass since it's inception.
I wanted to improve the performance of outbox especially when going into millions of messages and database contention in another project that SMB is used we saw some potential for improvement. So this should align with that I believe.
The batch send was also something on the roadmap, so it's another good avenue.
Let me take the time to review it in depth and align the implementation.
I would also love to add some performance test to he able to baseline before and after.

@EtherZa  you're definitely on the right track. I've reviewed the PR and provided some suggestions to consider.
As a side note, the bulk produce interface might be leveraged down the road in v3 to be able to send a batch of messages, or when (future releases?) we will bring in an auto batching of single message publishes.
I would love to see some benchmark test (as an integration test) using the existing Outbox infrastructure on Azure. I can take that on in a second iteration of this feature.

I would also love to add some performance test to he able to baseline before and after.

I hear you with this, but TBH, I don't know how/what to benchmark. The gains are primarily through reducing the number of calls over the network and the cumulative latency between those calls. Mocking out the calls would nullify the benchmark and leaving them in puts the weighting on latency which is dependent on available bandwidth and round trip time.

I would love to see some benchmark test (as an integration test) using the existing Outbox infrastructure on Azure. I can take that on in a second iteration of this feature.

For my own testing, I used the Given_CommandHandlerInTransaction_When_ExceptionThrownDuringHandlingRaisedAtTheEnd_Then_TransactionIsRolledBack_And_NoDataSaved_And_NoEventRaised test and manually dumping several thousand messages into a local containerised db. The difference is chalk and cheese.

As a side note, the bulk produce interface might be leveraged down the road in v3 to be able to send a batch of messages, or when (future releases?) we will bring in an auto batching of single message publishes.

Great stuff. There are further improvements that could be made with the outbox model too.

Batching a large number of outbox bound messages through a TVP.
The OutboxSendingTask can vastly increase the polling interval if the OutboxForwardingPublishInterceptor were to emit an event after the "outboxing" transaction completes. Each balanced app instance could immediately pick up that it had placed a message in the outbox, with others checking in periodically. This could be extended with support of asynchronous notifications à la postgres notify.
The instance lock should renew itself instead of stopping to process messages when the time enters the LockExpirationBuffer window. The LockExpirationBuffer approach is risky if one part of the operation (publish or SQL sent status) is partially complete.

Battles need to be picked though :)

I have rebased from master and the run the first set of benchmarking tests that @zarusz added -thank you for adding them.
The results are skewed as the outbox is unfairly advantaged by having vastly lower latency and higher bandwidth available to it than the ASB, but do show an improvement.
Each set  od results are from three consecutive runs on a release build using a local SQL instance (containerised) with an Azure Service Bus (Standard tier) in the Australia East region. I have +- 78ms latency with the Australia East data centre (https://www.azurespeed.com/Azure/Latency).
master
direct
Message Publish took	: 00:00:05.1472734  00:00:04.8023864  00:00:04.8906686
Message Consume took	: 00:00:08.2347485  00:00:07.9732388  00:00:07.1775174

with outbox
Message Publish took	: 00:00:01.1531716  00:00:00.7929830  00:00:00.7882242
Outbox Publish took	: 00:01:14.1196937  00:01:14.7346352  00:01:15.8530969
Message Consume took	: 00:00:06.9526368  00:00:06.3923101  00:00:06.6098189

feature/260-sql-outbox-batching
direct
Message Publish took	: 00:00:04.8164905  00:00:04.6085346  00:00:05.1897898
Message Consume took	: 00:00:06.8671870  00:00:06.6343886  00:00:07.3392817

with outbox
Message Publish took	: 00:00:01.3155528  00:00:00.7840798  00:00:00.8276036
Outbox Publish took	: 00:00:04.0035331  00:00:04.6453286  00:00:04.5108678
Message Consume took	: 00:00:06.6543769  00:00:06.9201661  00:00:06.8933468

There are more changes needed before this will be ready to merge

Performance of non-bulk transports will be poor at the moment (worse than original)
Although failed delivery attempts are recorded, the current implementation does not process those that fail any differently to a new message (if a failure is due to size/incompatibility with the svb, the outbox will eventually stagnate)
The locking mechanism is not optimal. Instead of aborting progress when approaching the end of lock time, it would be better to extend the lock.

I am busy implementing the change to the three items above and will push asap.
Out of interest, I also ran single batches of 10k and 100k messages for the "with outbox" test only.
10k
Message Publish took	: 00:00:08.2749961
Outbox Publish took	: 00:00:18.5741174
Message Consume took	: 00:01:07.0192878

100k
Message Publish took	: 00:01:20.7375655
Outbox Publish took	: 00:02:59.2045206
Message Consume took	: 00:11:00.8795735

@EtherZa It is exciting to see way better numbers after your changes, good job!
A couple of thoughts:

It would be great to work on additional identified improvements (1-3) - perhaps in future PRs.
It might be good to capture the numbers (from your local and/or from the github actions) and to make a note on the Outbox docs - so that folks have a feel about the overhead.
I might consider refactoring and segmenting the bulk vs non-bulk capable transports (low on my priority list). In the future (perhaps v3) elevating the core interfaces to be able to produce a batch of messages which would go hand in hand with this PR.
Looking at the consumer times for 10k v 100k for ASB it would require adding partitioning and more concurrent consumers to let it scale better.

@zarusz I have pushed a commit for three items above. Please let me know if you are happy with the change, and I will rebase and sign. If you would prefer to defer it to another PR in order to limit scope/provide an alternate solution that's fine too -I can remove the commit easily from here.
Latest change includes:

Drops support for buses that do not implement IMessageBusBulkProducer. OutboxSendingTask can now be understood at a glance :)
Renew locks instead of aborting when time is nearly done (LockExpirationBuffer)
Apply a max number of delivery attempts before aborting a message. This does need further work as there are no back off strategies, etc; but at least it will not block the queue now. Indexes/Queries have been updated and tested against a table of 10m with no degradation in performance.
Azure Service Bus will now back off for 2.x seconds as per ServiceBusException (ServiceBusFailureReason.ServiceBusy). This should probably sit behind a gate to ensure all processes adhere to the cool off, but for now only the current execution path is affected.

It might be good to capture the numbers (from your local and/or from the github actions) and to make a note on the Outbox docs - so that folks have a feel about the overhead.

I think my timings are probably a little too biased. While there is a substantial performance improvement, mine are definitely stacked against the real world with the database being local and the svb being remote. GitHub actions would be better as there is no favour and they are repeatable/independent ...the only problem is that the timings are not being published (no logs for successful tests).

I might consider refactoring and segmenting the bulk vs non-bulk capable transports (low on my priority list). In the future (perhaps v3) elevating the core interfaces to be able to produce a batch of messages which would go hand in hand with this PR.

Supporting batch uploads to SVB/SQL would be a nice to have and would definitely be useful but probably not used too often.
In terms of performance, the impact from the boxing looks negligible IMO. It is too closely aligned with IO to make any tangible difference.
Before - Message Publish took	: 00:00:05.1472734  00:00:04.8023864  00:00:04.8906686
After  - Message Publish took	: 00:00:04.8164905  00:00:04.6085346  00:00:05.1897898

Looking at the consumer times for 10k v 100k for ASB it would require adding partitioning and more concurrent consumers to let it scale better.

As long as a single service can publish more messages from the outbox than that service can consume, I can't see an issue. It could become a problem if order is important though. It would kill scaling out in its current form. In that case, it would be better to lock by bus/path or custom strategy, so that multiple instances could each deliver for different streams.
Please let me know your thoughts and I'll take it from there.

@zarusz  Comments resolved, test added and rebased

Thanks for this massive PR @EtherZa!

Thanks for this massive PR @EtherZa!

@zarusz It's a pleasure. Thanks for the help and library :)