[WFLY-4221] Upgrade jBeret from 1.1.0.Alpha2 to 1.1.0.Alpha3

Linux Build 5719 is now running using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a

Windows Build 830 is now running using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a

Linux with security manager Build 706 is now running using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a

Linux with security manager Build 706 outcome was SUCCESS using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a
Summary: Tests passed: 791, ignored: 369 Build time: 0:05:20

Windows Build 830 outcome was SUCCESS using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a
Summary: Tests passed: 2906, ignored: 364 Build time: 0:50:16

Linux Build 5719 outcome was SUCCESS using a merge of e8dbcbad7c9cf4169689a0d3e003133638c54e5a
Summary: Tests passed: 2906, ignored: 364 Build time: 0:53:35


[Event modification] Event OnBeforeIssueReminder in codeunit 393 "Reminder-Issue"

Please add IssuedReminderHeader as var Parameter for Event OnBeforeIssueReminder
Thanks in advance
codeunit 393 "Reminder-Issue"
{
Permissions = TableData "Cust. Ledger Entry" = rm,
TableData "Issued Reminder Header" = rimd,
TableData "Issued Reminder Line" = rimd,
TableData "Reminder/Fin. Charge Entry" = rimd;
trigger OnRun()
var
CustPostingGr: Record "Customer Posting Group";
ReminderLine: Record "Reminder Line";
ReminderFinChargeEntry: Record "Reminder/Fin. Charge Entry";
ReminderCommentLine: Record "Reminder Comment Line";
IsHandled: Boolean;
begin
IsHandled := false;
OnBeforeIssueReminder(ReminderHeader, ReplacePostingDate, PostingDate, IsHandled, IssuedReminderHeader);
if IsHandled then
exit;
.
[IntegrationEvent(false, false)]
local procedure OnBeforeIssueReminder(var ReminderHeader: Record "Reminder Header"; var ReplacePostingDate: Boolean; var PostingDate: Date; var IsHandled: Boolean; var  IssuedReminderHeader: Record "Issued Reminder Header")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Requirements for volkswagen_we_connect_id not found: ['weconnect>=0.55.1'].

Version of the custom_component
V1.0.7 hacs says that's the latest
Installation method (hacs / manual)
Hacs
Describe the bug
Restarting ha gives the error Logger: homeassistant.setup
Source: setup.py:206
First occurred: 17:51:46 (1 occurrences)
Last logged: 17:51:46
Setup failed for custom integration volkswagen_we_connect_id: Requirements for volkswagen_we_connect_id not found: ['weconnect>=0.55.1'].
Is this saying I have to install weconnect as well?
Don't think I can do that, as I don't have a car that works with old weconnect.

Upgraded home assistant.
Reloaded all the hacs apps.
Restarted.
Deleted vw connect id.
Reloaded it. Got an error saying I might need to accept something.
Visited vw id connect on the Web, logged in again, accepted everything.
Reloaded vw I'd connect again.
It works.
Sorry for both you.


make uninstall should remove docker.lima and podman.lima

Otherwise make uninstall && brew install lima (for testing) doesn't work:
$ brew install lima
[...]
==> Pouring lima--0.11.0.catalina.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/docker.lima
Target /usr/local/bin/docker.lima
already exists. You may want to remove it:
  rm '/usr/local/bin/docker.lima'

To force the link and overwrite all conflicting files:
  brew link --overwrite lima

To list all files that would be deleted:
  brew link --overwrite --dry-run lima

Possible conflicting files are:
/usr/local/bin/docker.lima
/usr/local/bin/podman.lima

Make uninstall hardly ever works, guess we need "make distcheck" to come back...

Make uninstall hardly ever works

I'm not aware; what are the problems?

Too many lazy maintainers, I suppose. ☺

Oh, you meant in general? I thought you talked about make uninstall in the lima repo.

Oh, you meant in general? I thought you talked about make uninstall in the lima repo.

I was only trying to explain forgetting to add it in the first place, thanks for fixing it!


Parallelize FS operations: wrong programming language used in example code

While trying out this example in Azure Databricks, I found that the example code provided is written in Scala. The document indicates that it is Python code, but this is incorrect. This is also wrongly stated in the corresponding document in the Databricks Knowledge Base.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edb1e7ba-69a0-c13e-750a-d6dad13999de
Version Independent ID: 074aef47-9e46-64fb-b574-90a346ef7d98
Content: Parallelize filesystem operations - Azure Databricks - Workspace
Content Source: databricks/kb/dbfs/parallelize-fs-operations.md
Service: azure-databricks
GitHub Login: @dbsan
Microsoft Alias: saperla

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

@leifbro  - Could you please review this feedback and update the doc as needed ? - Thank you

Thanks for your dedication to our documentation. Unfortunately, we have been unable to address your issue and apologize for the delayed response. We are closing this issue, but if you feel that it's still a concern, please let us know directly at<EMAIL_ADDRESS>#please-close


Add support for Solidity 0.6 syntax

The current release crashes when compiling 0.6 code. I suspect we'll also need to account for the new 'fallback' functions (receive and fallback) and the virtual attribute.

It crashes because it depends on the 0.5 compiler directly.
My suggestion is that we release a new minor version updating that dependency to 0.6 and stop supporting 0.5. Ideally in the future we would have a way to delegate compilation to whatever environment the user is in. But supporting multiple version is potentially complicated so it should be left for later.
To upgrade the compiler and have things work we will have to check that whether any breaking changes were introduced to the AST. Unfortunately docgen doesn't yet have any tests using the compiler, there's only unit tests for other parts of the codebase. It would be nice to add an integration test as part of this upgrade, to make sure it's smooth.
In case there were any breaking changes to the AST, there is already code in place to make an 0.4 AST look like a 0.5 AST (it changes a function Contract() node into a constructor() node), so it would be a matter of adding a new section to that adapter.
https://github.com/OpenZeppelin/solidity-docgen/blob/40341d0d1a1f859de5f28d947b5aa021a5850d47/src/compile.ts#L63
For everything related to override, etc., we don't need to add any special support for that initially. They will be probably be new AST properties but they just wouldn't be exposed in docgen's API. We can add them later.

Fixed in https://github.com/OpenZeppelin/solidity-docgen/commit/087103120d419de2c44fdc6a79cb99d88f26bd3b and subsequent commits. Released in 0.4.0.


Remove keypad transmit mode and hardcode cursor keys

... for https://github.com/calleerlandsson/pick/issues/275 ...

This breaks the cursor keys in xterm for me since it now emits \e[
prefix as opposed of \eO. Instead of dropping transmit mode, can't we
just hardcode cursor keys with the \eO prefix instead? That would
requires less sync with pick.vim and no major bump.

If this is a viable approach, I'd like to see tests for added cursor keys.

If this is a viable approach, I'd like to see tests for added cursor keys.

Of course (see https://github.com/calleerlandsson/pick/pull/277) ... fortunately the tests are already there ...

@DBOTW you're right!


fix https://github.com/microsoft/vscode-copilot/issues/10096

@microsoft-github-policy-service rerun


Give drives a mount point

A deployment consists of a storage registry, storage providers, an ocdav handler and a graph api endpoint.
The storage registry organizes the storage spaces in a namespace.
The /webav endpoint then uses that namespace to provide human readable access to resources, but names and paths can change.
The /dav/spaces endpoint allows direct access to a storage space, regardless of the mount point.
To allow clients to build a custom registry (namespace) we need a way to expose the mount points for storage spaces.
When listing drives they should return a mountpoint property that contains the path in the global namespace that is accessible at /webdav, eg.: /personal/einstein for einsteins home space.
In oc10 / would be the users home and shares would be mounted in arbitrary locations.
In ocis we would make that /personal/einstein
The admin can build a namespace by mounting spaces in the storage registry as he sees fit. This is only a recommendation, because clients can build a completely different namespace if they desire. That includes storage spaces from other instances / deployments.

Possible Solution #36


First example in documentation doesn't work in Firefox

Prerequisites

[X ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
The Lean introductory documentation appears to be https://leanprover.github.io/introduction_to_lean/. At the beginning is a button labeled "Try it yourself". It doesn't seem to work for me in Windows/Firefox, latest stable versions. It appears to work in Windows/Chrome.
Steps to Reproduce

Open the above page in Firefox.
Click the button.

Expected behavior: [What you expect to happen]
Expected to see "hello world".
Actual behavior: [What actually happens]
Got error messages:
1:0:error: file '/library/init/wf.lean' not found
1:0:error: invalid import: init
could not resolve import: init
1:0:info: "hello world!" : string
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
1:0:error: file '/library/init/wf.lean' not found
Done(0.008sec)
-- Done(0.014sec)
Reproduces how often: [What percentage of the time does it reproduce?]
5 times out of 5.
Versions
(Unknown)
You can get this information from copy and pasting the output of lean --version,
please include the OS and what version of the OS you're running.
(Attempt to do this failed.)
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Dear @David263, the documentation you mention is not for Lean4. This repository is for Lean4, which is a very recently released version of Lean, and there is not yet much in terms of documentation/tutorials for Lean 4.
Could you please report this issue at https://github.com/leanprover-community/lean.


[FEATURE] Agent output as JSON format (Sequential Agents)

I want to use the output of a Agent Node as JSON format
I am using Sequential Agents , I have an Agent Node with otput, for example, {'var1': 'value1', 'var2':'value2'}. I want to use this output value (node output) as JSON format for using this in input params of a Custom JS function!
I need something like Structured Output Perser that i can use in an Agent Node.

2 ways you can solve this:
1.) Specify in system message to ask LLM returns a JSON. and give few examples.
2.) Use LLM with JSON structured output:

I have tried both alternatives, but neither recognizes the output as JSON. The output is a JSON, but it cannot be passed as input to a Custom JS Function because it is not recognized as JSON, but rather as LLM output or Agent output.

yeah currently custom JS function is not possible to be connected to agentflows, will add that support

+1
Or please let us manually enter JSON into the JSON Structured Output through a simple text box like in Advanced Structured Output Parser node that maybe could be parsed (no pun intended) by Flowise into the table-display structure that's currently in place. Adding key-value pairs using the "add item" is very cumbersome when dealing with more then just few elements. Thank! :)

I'd also like to have the tool agents and conversational chains being able to use the json output parser!

I would also like the tool agents and conversational chains to be compatible with the JSON output parser—it would be a game changer for me!


doc: Chinese version for plugin redirect.

we only have English doc now.

please give the link of English versioin doc.

https://github.com/iresty/apisix/pull/732/files#diff-5ceb1f214e01a516b34995b39d617aa8

I would send a standalone PR today.


(maint) Fix Facter API to export scalar_value.

Missing an export declaration on scalar_value<T>.  This prevents Facter
from exporting needed type info on Linux.

What's up with the windows build failure?

Windows be Windows'in.  Looking into it.

Did you look into it?

I haven't really yet as this got shoved to the side.  Feel free to close this as it's not blocking anything (it's needed for the native compiler prototype only at this point, on Linux).


Figma connect files

This PR adds some more code connect files to connect react components to figma implementations.

Rollout strategy

[x] Patch release
[ ] Minor release
[ ] Major release; if selected, include a written rollout or migration plan
[ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Storybook)
[ ] Changes are SSR compatible
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge
[ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

Hey @joshblack I think we need to disable the type check for those files, or do you know how we can fix it? We can't add an as TYPE statement, as this will me transferred to figma.

@lukasoppermann I'll revert the commit based on your comments 👍 I'll add more info here for where the changes came from.

This has to be reverted, we need children here.

The type error is because counter only accepts string | number in the component but we're giving it a JSX.Element from figma.children.

We need double quotes, otherwise we end up with no quotes in figma.

The type error here is that the value being passed on as current is not 'page' but instead is '"page"' with the nested double quotes.

this does not work I think as the code is not executed. But I'll check.

The type error here is because leadingVisual does not accept JSX.Element, it expects a React.FunctionComponent which is where () => leadingVisual comes from.

My assumption is that we're running into an issue between how we want to represent it in Figma and how it's structured over in TS world 👀 Let me know how you would like to resolve these. My fear for disabling TypeScript on these examples is that TS seems to be catching snippets that would be invalid if someone tried to copy and use them in code due to the type mismatches.


Document and cleanup all Wordpress Integration points (repos and Azure resources)

Make a document providing for each integration point

Azure Resource ID
Github Repo (of integration service)
Target Repo(s) (of websites that use each service),
Trigger URLs,
Slack channels reported to.
Current status (active/stale)

Identify and remove unused ones.

Excellent! I have been building on @chachasikes document today. Would love collaboration

Nice! Yeah, I can add this info there where appropriate.

Closing because it's been a year with no activity.


Ability to set a single handler for all exceptions that inherit from a base exception

This is for #188
This enables falling back to the handler of a parent exception if one exists. When an exception inherits from multiple classes, we will for handlers from left to right.
Example:
class A():
  pass

class B():
  pass

class C(A, B): # If this is raised but doesn't have a handler, we will look for handler for A first and then B.
  pass

class D(B, A): # If this is raised but doesn't have a handler, we will look for handler for B first and then A.
  pass

Let me know if you would prefer the helper functions added in utils were in cypthon. This is my first experience with cython so I don't really know what are the trade-offs and what is at stake.

Codecov Report

Merging #189 (29fc858) into main (f7264e5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           47        47
  Lines         4343      4348    +5
=========================================
+ Hits          4343      4348    +5

Impacted Files
Coverage Δ

blacksheep/utils/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7264e5...29fc858. Read the comment docs.

Thank You @YassineElbouchaibi for your contribution! I merge this change. I will document it. And about converting to Cython the functions, it shouldn't be necessary. Accessing __mro__ in Python is fast anyway.


Theming issue when using SSR

Description
When the colorMode property of <ThemeProvider /> is set to auto and SSR is used, it will still be displayed in light mode on browsers that prefer dark mode.
Steps to reproduce

Set the colorMode property of <ThemeProvider /> to auto.
Perform Next.js SSR / SSG rendering.
Open the page on the browser that prefers dark mode.
The displayed color scheme is day, not night.

Temporary patch
Add a hook named useAutoColorMode.
import { useEffect, useState } from 'react';

import useMediaQuery from '@/hooks/useMediaQuery';

enum ComponentColorMode {
  auto = 'auto',
  day = 'day',
  night = 'night',
}

const useAutoColorMode = () => {
  const [colorMode, setColorMode] = useState(ComponentColorMode.day);
  const darkModeEnabled = useMediaQuery('(prefers-color-scheme: dark)');

  useEffect(() => {
    setColorMode(
      darkModeEnabled ? ComponentColorMode.night : ComponentColorMode.day
    );
  }, [darkModeEnabled]);

  return colorMode;
};

export default useAutoColorMode;

Manually set colorMode in App.tsx.
const App = () => {
+  const colorMode = useAutoColorMode();

  // ...

  return (
-    <ThemeProvider colorMode="auto" preventSSRMismatch>
+    <ThemeProvider colorMode={colorMode} preventSSRMismatch>

Version
v35.16.0
Browser
Chrome

It seems that these updates are being automated batched in React 18 and it causes this problem.
https://github.com/primer/react/blob/main/src/ThemeProvider.tsx#L87-L89

Ouch!  That's definitely a bug.
Short term, we can delay the second setColorMode by either putting it in a timeout or by flushing updates before it.


IndicatorsControl item size

Hi Andrei,
As I always say, great plugin it's made all the difference to my app but I'd like to know how to shrink the size of the items in the indicators control.
Sometimes I'll have as few as 8 items and as much as 26 so to stand a chance of it fitting I'd either need smaller circles displayed or some sort of progress bar style.
Do you have any advice for me?
Thanks!

Hi @garnelsoftware
IndicatorsControl has a property ItemTemplate.
IndicatorItemView has a few props also.
<controls:IndicatorsControl>
  <controls:IndicatorsControl.ItemTemplate>
    <DataTemplate>
      <controls:IndicatorItemView Size="2" />
    </DataTemplate>
  </controls:IndicatorsControl.ItemTemplate>
</controls:IndicatorsControl>

Also, you can consider putting IndicatorsControl into ScrollView or maybe even building your own  IndicatorsControl

Excellent as always, thank you so much!
On Thu, 26 Oct 2023 at 15:15, Andrei @.***> wrote:

Hi @garnelsoftware https://github.com/garnelsoftware
IndicatorsControl has a property ItemTemplate.
IndicatorItemView has a few props also.
controls:IndicatorsControl
controls:IndicatorsControl.ItemTemplate

<controls:IndicatorItemView Size="2" />

</controls:IndicatorsControl.ItemTemplate>
</controls:IndicatorsControl>
Also, you can consider putting IndicatorsControl into ScrollView or maybe
even building your own IndicatorsControl
—
Reply to this email directly, view it on GitHub
https://github.com/AndreiMisiukevich/CardView/issues/426#issuecomment-1781220949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCCEDFOV63VC6CE42KFGJ3YBJWAHAVCNFSM6AAAAAA6RHQV3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGIZDAOJUHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Intrusive shared pointer mis-behavior (according to docs)

From the documentation:
The object oplist is expected to have the following operators (CLEAR and DEL), otherwise default operators are used.
This, however, seems not true, as the init_new (the documentation sample is also wrong on this one, calling it just _new) function is not generated at all, if a user doesn't provide a NEW in the OPLIST.
This OPLIST produces the needed init_new function:
(NEW(M_MEMORY_ALLOC), CLEAR(my_clear M_IPTR))
This however does NOT but should (if to believe the docs):
(CLEAR(my_clear M_IPTR))

Indeed.
The documentation & the code is wrong.
It shall only be define is the INIT is defined in the oplist and the NEW method has not been disabled.
The code & documentation have been updated.

This is not completely fixed. I created a PR for that one.

Fixed in https://github.com/P-p-H-d/mlib/pull/73


CreateSRSMedia.ps1 error

When I run CreateSRSMedia.ps1 under an Administrator PowerShell console, I get an error: “Cannot convert the "System.Object[]" value of type "System.Object[]" to type "System.Version". At line:1 char:1” (Running it from C:\MTR\CreateSRSMedia.ps1).  No useful information on what went wrong provided. Any idea what could be wrong???
I opened a Premier Performance Support ticket, but haven't been able to get a tech who knows what that script is so far. :(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f8b204f-9650-d268-8566-7a75ba0a1b6a
Version Independent ID: 9a963e63-6716-7522-8abe-c8a407d3a46d
Content: Configure a Microsoft Teams Rooms console - Microsoft Teams
Content Source: Teams/room-systems/console.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

I am getting the same error above as well.  Will update my version of PS and see if that fixes it.

I finally figured it out. I have a profile.ps1 in my WindowsPowerShell directory in my documents folder. I didn't use it anymore, but had a "Write-Host" line in there, which I didn't comment out from when I did.
I was able to replicate it by deleting the contents of profile.ps1 and putting write-host "Test" in the file. Launching powershell then gives the error. If I delete, or delete the contents of profile.ps1 so there is no write-host entries, it works fine. Write-Output also gives the error when launching this script. I tried a few other commands, such as changing directories, and it worked fine, but write-host or write-output in the profile.ps1 broke the script.
Weird? Absolutely. But

thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@richeklund thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@scanum I have opened a service ticket, but they did not have any interest in fixing it. Hopefully the feedback here can help others with a similar issue in the future.


[BUG] Install fails with use_2to3 is invalid error

setuptools version
67.7.0
Python version
3.8
OS
Ubuntu 22.04.2 LTS
Additional environment information
Use of pip 23.1 is required for the reproducer given, since it relies on --no-binary attempting to build a wheel.
Additionally, wheel should not be installed for the reproducer to work.
The changes in https://github.com/pypa/setuptools/pull/3849 seem related.
Description
Installation of coverage version 4.5.4 fails with setuptools version 67.7.0, but works with 67.6.1.
As a work-around, I can use the previous version of setuptools:
$ cat constraints.txt
setuptools==67.6.1
$ PIP_CONSTRAINT=./constraints.txt pip install coverage==4.5.4 --no-binary :all: --no-cache
Collecting coverage==4.5.4
  Downloading coverage-4.5.4.tar.gz (385 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 385.2/385.2 kB 1.5 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: coverage
  Building wheel for coverage (pyproject.toml) ... done
  Created wheel for coverage: filename=coverage-4.5.4-cp38-cp38-linux_x86_64.whl size=208278 sha256=73953647437bb81efefbaae00f779c00e8051e83d2ec0dba760e465e1793cc91
  Stored in directory: /tmp/pip-ephem-wheel-cache-pnyp3zi8/wheels/e7/0e/3f/4d16d7576f1070cf1a0028b1664aff2cc8e84c9c0e2b8f3207
Successfully built coverage
Installing collected packages: coverage
Successfully installed coverage-4.5.4

Expected behavior
$ pip install coverage==4.5.4 --no-binary :all: --no-cache
Collecting coverage==4.5.4
  Downloading coverage-4.5.4.tar.gz (385 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 385.2/385.2 kB 1.5 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: coverage
  Building wheel for coverage (pyproject.toml) ... done
  Created wheel for coverage: filename=coverage-4.5.4-cp38-cp38-linux_x86_64.whl size=208278 sha256=73953647437bb81efefbaae00f779c00e8051e83d2ec0dba760e465e1793cc91
  Stored in directory: /tmp/pip-ephem-wheel-cache-pnyp3zi8/wheels/e7/0e/3f/4d16d7576f1070cf1a0028b1664aff2cc8e84c9c0e2b8f3207
Successfully built coverage
Installing collected packages: coverage
Successfully installed coverage-4.5.4

How to Reproduce
pip install coverage==4.5.4 --no-binary :all: --no-cache
Output
$ pip install coverage==4.5.4 --no-binary :all: --no-cache
Collecting coverage==4.5.4
  Downloading coverage-4.5.4.tar.gz (385 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 385.2/385.2 kB 1.6 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      /tmp/pip-build-env-6bs8y2ax/overlay/lib/python3.8/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
      !!

              ********************************************************************************
              The license_file parameter is deprecated, use license_files instead.

              By 2023-Oct-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://setuptools.pypa.io/en/latest/https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
              ********************************************************************************

      !!
        parsed = self.parsers.get(option_name, lambda x: x)(value)
      /tmp/pip-build-env-6bs8y2ax/overlay/lib/python3.8/site-packages/setuptools/dist.py:954: DistDeprecationWarning: use_2to3 is ignored.
        ep.load()(self, ep.name, value)
      error in coverage setup command: use_2to3 is invalid.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

I updated the issue summary to mention using pip 23.1, since the reproducer relies on the new --no-binary behavior.

Also, wheel should not be installed for the reproducer to work.

Also, wheel should not be installed for the reproducer to work.

I don't think its presence matters if PEP 517 is used.
Though, if it's not used, we're probably hitting a direct setup.py install invocation...

Related #3899

Thank you very much.

@mattclay What is the fix here? 😅

@ashishra0 This issue was fixed in https://github.com/pypa/setuptools/pull/3900 and was included in setuptools v67.7.1.


lymphgen 2.0 - run per sample

lymphgen 2.0 allows runs per sample, therefore inputting per sample maf/seg/sv and outputting per sample lymphgen calls
Checklist for Updated Module
Important! If you are updating the module version, ensure the previous version of the module is restored from master.
If you want to restore a deleted file or directory from the remote master, you can use git checkout origin/master path/to/file,
then a git commit will ensure that file is tracked on your branch again.
Example:
mv modules/strelka/1.1 modules/strelka/1.2
git checkout origin/master modules/strelka/1.1

Just as a general comment; does the LymphGen R code work correctly for a single sample? IIRC, the web version of lymphgen had a bug where it was impossible to run a single sample through...

@ckrushton I have run it with just one sample so the LymphGen R code works fine for that - not sure why it'd be erroring out in the web version


laravel - illuminate/database migration proposal

Hi guys,
As you know i got the idea to rewrite munkireport from scratch. Unfortunately the task was just too gargantuan, with the scope increasing all the time.
So, I decided one possible way of migrating out of kissmvc to laravel would be to adopt one piece at a time. Many of the parts of the laravel framework can be used standalone.
I wanted to make sure that everyone was actually on board for this plan. so I'm making this issue an open discussion.
The plan at this stage is to adopt the Illuminate/Database part of the Laravel framework which would replace migrations, and eventually sql queries. # #

I'm in favour of this change, but I think it is a good idea to keep track of the pros and cons.
PROS

Structured DB setup
DB abstraction will open up the possibility to use other backends like PosgreSQL or MSSQL
Controlled migrations
Simpler DB syntax for developers

CONS

DB setup (creating tables) does not happen automatically anymore
Performance - adding a layer has some negative influence on performance
Existing documentation needs to be revised

I would try to make it a goal for zero performance regression.
We have 20,000 computers in MunkiReport, and it would not surprise me if there were even larger implementations out there. I really don’t want to face performance regressions.
Bryan

On Nov 25, 2017, at 4:24 AM, Arjen van Bochoven<EMAIL_ADDRESS>wrote:
I'm in favour of this change, but I think it is a good idea to keep track of the pros and cons.
PROS
Structured DB setup
DB abstraction will open up the possibility to use other backends like PosgreSQL or MSSQL
Controlled migrations
Simpler DB syntax for developers
CONS
DB setup (creating tables) does not happen automatically anymore
Performance - adding a layer has some negative influence on performance
Existing documentation needs to be revised
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/munkireport/munkireport-php/issues/900#issuecomment-346931920, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaWl28E0efLHQO3hYbvTazZyVo1oQrpks5s5-rIgaJpZM4QqXoI.

I understand your concern Bryan. I don’t think that performance is so black and white though. Any added feature has the potential to have a performance impact, therefore it’s better to quantify the impact and weigh it against the benefits. If there are no optimisations to be made, the only way to have zero performance impact is to add no features. In which case id just tag the repo and back port hot fixes only.

I personally have never used Laravel, however, I have a number of colleagues that use it and are actively still building apps in it. I'm all about using widely adopted frameworks, or at least ones that are adopted in my circle of peers.
I only ask that we take a look at all of the existing db tables and work on getting them closer to 3NF, if possible. While trying to write some custom reports using SQL, I noticed there are some tables that could use some... TLC.

Agree with you on all counts Nate. This will provide a good opportunity to rework any tables that have grown in strange ways.


Fix / roles and aria-attributes regarding modals

This PR

Applies the aria-modal attribute to the .dialog selector to group it together with the role attribute.

It removes the redundant aria-describedby in the ConfirmationDialog component, because this caused the heading to be read out loud twice
It does not apply aria-describedby, because the heading is read by the screenreader, users can navigate to any extra text describing the modal (such as the Edit Password modal, which has a description)
Tested on VoiceOver on macOS: It now currently reads the modal heading out loud and keeps everything else intact

The aria-labelledby attribute is removed in the ConfirmationDialog (which is actually only used for the 'Clear favorites' button), because this caused the heading to be read twice.

Solves: OTT-528, OTT-909

Awesome you were able to get it right! One question:

It does not apply aria-describedby, because the heading is read by the screenreader, users can navigate to any extra text describing the modal (such as the Edit Password modal, which has a description)

Here you meant to say aria-labelledby i guess? In my test on different screen readers, the heading of the modal is not automatically read (which I understood from your description). But you manually can navigate to it, so it will get read. I think it's acceptable, but of course it can be further approved upon (like most a11y optimisations) ;-) .
But as we discussed 1-on-1 yesterday, using aria-labelledby with an unique ID on the modal was technically difficult. Also during the stand-up of today you mentioned you discussed this with Christiaan and Roy. So that could mean we accept this situation, because it has already been discussed and I bring it up again. Sorry for that, in that case...
As a side note... I also did a small test with temporary using aria-label on the modals, instead of aria-labelledby, and noticed it will not get read on Talkback. But it does on other screen readers. So it is not consistently working across screen readers. Could be due we set the focus to the first interactive element, which gets priority over the modal title

But as we discussed 1-on-1 yesterday, using aria-labelledby with an unique ID on the modal was technically difficult. Also during the stand-up of today you mentioned you discussed this with Christiaan and Roy. So that could mean we accept this situation, because it has already been discussed and I bring it up again. Sorry for that, in that case...

What we discussed:

The header will get read anyway, as VoiceOver (MacOS) understands that the only header (h1) of the modal is the title
This makes aria-labelledby redundant
aria-describedby doesn't result into the description being read, so it doesn't add anything. You can indeed still navigate to the paragraph to read it (like Melissa mentioned)
These were conceptual conclusions, not technical (instead of using dynamic id's, we could simply set them statically: aria-labelledby="modal_title" aria-describedby="modal_description")


Collect telemetry on extension startup and shutdown

Uses redhat.vscode-commons to collect telemetry data.
To see what information is collected, please refer to USAGE_DATA.md
Closes #46
Signed-off-by: David Thompson<EMAIL_ADDRESS>

I've added the change to the CHANGELOG

Looks good. Feel free to merge when ready. We'll just need to adjust the tag after.


change button styling in prep to support new function + other minor f…

…ixes

Recipe image: https://screenshot.googleplex.com/jndztQuSDd7.png

Top of main page image: https://screenshot.googleplex.com/kS0EKinavAE.png
Bottom of main page image: https://screenshot.googleplex.com/KGig1o1z50D.png

Recipe card image:

Image of word definition card on contact page:

Image of contact page:


cloudflare moment

cloudflare moment (instead could use mcaptcha on libretranslate.com)
My reaction
What is going on with the traditional Chinease translations in general?

oh my, the first two have been quietly fixed?


closes #379: cli messaging in assert_list_of() (Priority review as other fns depend on it)

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes #379 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

Looks good to me! Others?

I think some changes are required. I'll submit a review later today.

from assert_list_of, arguments are not evaluated in the message, I did a quick update here: https://github.com/pharmaverse/admiraldev/pull/408


More clarification

There was confusion if the license is not assigned to the user.  Updated the information.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/9161

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Hi @Dansimp, PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

(The target pages have moved to the MicrosoftDocs/microsoft-365-docs repository and are updated from there.)

New PR targeting the new page: https://github.com/MicrosoftDocs/microsoft-365-docs/pull/4866


Exception caused by breaking changes in hash_diff gem

Issue summary
hash_diff gem has breaking changes in version 1.1.0. I've already open an issue CodingZeal/hash_diff#10 in its repo. This affects shopify_api gem and more specifically the ShopifyAPI::Rest::Base#save method.
Expected behavior
An example Ruby code for creating a customer. This is what we expect and what happens when using hash_diff (1.0.0).
customer = ShopifyAPI::Customer.create_instance(data: {email<EMAIL_ADDRESS>session: session)
customer.save
# => T::Private::Types::Void::VOID

Actual behavior
Exception is raised upon calling the same code with hash_diff (1.1.0).
customer = ShopifyAPI::Customer.create_instance(data: {email<EMAIL_ADDRESS>session: session)
customer.save
# .../gems/hash_diff-1.1.0/lib/hash_diff/comparison.rb:38:in `sort': comparison of Symbol with String failed (ArgumentError)

Steps to reproduce the problem

Install hash_diff version 1.1.0.
Initiate an instance of any REST object using ShopifyAPI::REST::Base.create_instance method. It doesn't matter if the data hash keys are strings or symbols.
Attempt to persist the record by calling ShopifyAPI::REST::Base#save method on the instance and you'll get an exception.

Specifications

shopify_api version: 2022-07.

The issue is resolved in hash_diff version 1.1.1.  Make sure that your project is using this one instead of 1.1.0.
If I was on the Shopify's team, I would consider dropping this dependency entirely because it's used only in one place and the logic could be handled internally. I may open a PR with the changes when I've got time.


⚠ Samsung has degraded performance

In 0c226dd, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2122 ms

Resolved: Samsung performance has improved in 67954e9.


fix[IDP] : Updated the broken links

Harness Developer Pull Request
Updated the broken links
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://656f30ea90df84006f194a50--harness-developer.netlify.app


Allow choosing custom head content / script position in document

Hi,
There is a possibility to add Custom Content to the HTML HEAD, however, it would be nice to allow to add/load/insert scripts at the end of HTML too.
<script>
...
...
</script>
</body></html>

There may be cases when a script needs to wait until the full HTML content is downloaded e.g. getting document.getElementsByClassName.. etc. If the script is in the head one needs to write an event listener to run the script when the document fully loaded. It may be eased to write the script at the end of the HTML document to ensure the document has already sure loaded.
Thank you for considering adding this feature.

Yes, you are right again. But that is simpler to put such scripts at the HTML end without writing event listener :)
However yes, in this case you must write something to allow that, but that is also not so much work whether to insert  after DOM element HEAD or before DOM element
</body>

I will also consider, to rewrite my scripts. :D

it is pretty easy to add an event listener for onload
Yes again, but FYI:
I had been a developer for very long years before but I'm not now. Thus I can remember such tricks :) but those are not at my finger now so easily. (I suppose you have in everyday practice, so I truly understand such a big work you are doing  :). I need to look after again how to write such a script even in my last works I had already forgotten also that where I had put them. :) :( Thus I can write at now very easy scripts, even using those some already have written well I need just understand and use them and not reinvent the wheel :)

So I thought perhaps it would be easier and quicker for you to add such a pretty easy possibility even if I understand you need to write a Setting also for this.
So much thank you for your understanding and consideration.

Yes my main hesitation with adding features is that I don't want to overwhelm users with options, and I want the options to be clear and simple.
Even right now I am not happy with their simplicity and so adding new features like the location of the custom content is something that, while simple to implement, adds a lot of complexity to the way I pass data around in the plugin and the way I present options to the user.
But again I will consider adding this, but I likely won't add it until I feel it can be added without becoming messy.

Hi,
I absolutely understand your above-written concern regarding the Settings being clear for users, and certainly coding new features may be more complicated even when the main reason for doing it may be simple. Okay!
I also was considering my possibilities and concluded;
My concern regarding putting my scripts into the HTML output is specific, and even if it may be generalized and simpler to put/write/insert custom scripts into the HTML automatically by your plugin which is a truly great addition and help, it even requires me some handmade cosmetic working in the output HTML. I mean, for example, I need to add a specific ID attribute for a certain HTML block element to work the script. This means I must edit the output HTML document by hand in every case anyway. This entails that inserting custom scripts at the head or before the end automatically becomes to me irrelevant.
Just consider adding this feature only if you think it can be useful for most users. I'm not closing this issue but you just close it if you think it may be more complex to do than worth.
Thank you for our conversation on this matter.

Hi,
I resolved my above-mentioned special scripts problem and used your already-built page feature adding a 'Custom head content' which works well. It is great and fine, and saves a lot of hand work :) Thank you.
Thus, I closed this issue because it became irrelevant to me, and although I wrote;

Just consider adding this feature only if you think it can be useful for most users. I'm not closing this issue but you just close it if you think it may be more complex to do than worth.

Reopen it if you think it is worth it for you to deal with.


The ability to specify a label for a column header without using a fi…

Hi.
Now the only way to set a label for the column headers (in the default template) is to use a filter. Please consider the possibility of doing this for the default template by using the setLabel function for FieldConfig. it looks logical. Thank you

Hi
FieldConfig has setLabel() method
See https://github.com/Nayjest/Grids/blob/master/src/FieldConfig.php#L161

You added label to template of filters row in this PR.
With this code we will have duplicate labels for some grids.
Column labels should be displayed in appropriate row:
See
https://github.com/Nayjest/Grids/blob/master/src/Components/ColumnHeadersRow.php


[FLINK-12333][docs] Add documentation for all async operations through REST API

What is the purpose of the change
Improve the description for all async-operations through REST API. Trigger savepoint and rescaling operations are all async-operations which would return a request-id for further query identifier. However, current REST documentation does not describe this clearly and users might be confused to use these REST APIs
Brief change log

Add description for all async operation headers.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot approve all


sig leaking allocations when T.untyped in params or returns

I've made a simple repo that reproduces the issue here. Essentially I'm seeing a major performance hit whenever the params/return in a sig has a T.untyped. Not sure if it's the root cause or not (or even if it's expected), but a method with a type signature like
sig {params(num: Integer).returns(T.untyped)}
def self.test(num)
  ...
end

is performing an allocation here every time it is called.

It's not a bug but a feature ;-). We have custom wrappers for runtime for
what we consider simple types for common method arities, based on
experience in Stripe's codebase.
That code doesn't consider T.untyped as a simple type(you'll see a similar
result for other complex types).
How much overhead do you see in practice? As long as method does something
useful, we see under 7% overhead averaged over all of Stripe API for all
runtime typechecking.
On 10 December 2019 15:20:48 Robert Looby<EMAIL_ADDRESS>wrote:

I've made a simple repo that reproduces the issue here. Essentially I'm
seeing a major performance hit whenever the params/return in a sig has a
T.untyped. Not sure if it's the root cause or not (or even if it's
expected), but a method with a type signature like
sig {params(num: Integer).returns(T.untyped)}
def self.test(num) ...
end
is performing an allocation here every time it is called.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Interesting. The allocation thing is probably a red herring then. Our actual type is more complicated. It's essentially:
sig do
  params(
    arg1: T::Hash[String, T.untyped],
    arg2: T::Hash[String, T.any(Type1, Type2)],
  ).void
end

That method get's called in a loop on the order of ~300k times and is ~1000x slower with the sig vs no sig or adding a .checked(:never) (666 sec vs 0.74 sec). Is there anything specific that jumps out as obviously a performance issue? i.e. is it the T::Hashes, the T.untyped, the T.any, or just the combination of all of them?
I'll try to see if I can fiddle with the reproduction scripts and get it to reproduce the performance hit we're seeing.

So I think I finally got to the bottom of this and in retrospect it should have been obvious: runtime type checks for T::Array and T::Hash are O(n). So it's nothing to do with the allocations or T.untypeds. In the example sig above arg2 is a hash with a couple thousand keys which explains calling it with vs. without runtime type checks being ~1000x slower.


feat: add storage url parsing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

87 of 117 (74.36%)  changed or added relevant lines in 6 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+1.5%) to 86.632%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/storage_models/core.py
51
65
78.46%

components/renku_data_services/storage_schemas/core.py
23
39
58.97%

Files with Coverage Reduction
New Missed Lines
%

bases/renku_data_services/crc_api/app.py
1
89.67%

components/renku_data_services/base_api/error_handler.py
1
93.42%

components/renku_data_services/resource_pool_models/core.py
1
87.8%

components/renku_data_services/storage_schemas/core.py
1
76.67%

Totals

Change from base Build<PHONE_NUMBER>:
1.5%

Covered Lines:
2009

Relevant Lines:
2319

💛  - Coveralls


Optimize setting data to series

See https://leeoniya.github.io/uPlot/bench/lightweight-charts.html.
It takes about 700ms to set data to 3 series. I guess we can use that to optimize our algorithms to set data faster.
Chrome DevTools profile

/cc @leeoniya I've created a separate issue for this.

nice.
let's first figure out https://github.com/leeoniya/uPlot/issues/185 so we're comparing apples to apples.

Not related to the screenshot above, but maybe related to optimizations of setting data in general, is the fact that the library currently expects series data as an array of objects of a certain shape (depending on the series type), so you'll often see a pattern like this (or something similar to what prepData() does in the example here):
mySeries.setData(
   array_of_stuff_I_have_from_my_data_source.map(
      my_obj_type => ({ ... shape that the lib wants ...})
   )

So if you're loading a lot of data, you'll do a huge allocation (and subsequent GC pass later) just to get the data into the right shape, which is also quite visible in profiling.
The d3 visualization app uses "accessor" functions, as an example, so when you set data there, you pass in the array of data the way you already have it, and a set of functions that take your array and an index, and return whatever the library expects. That's a way to prevent the need to copy data to a new shape and retrieve values as needed instead, eschewing unnecessary allocations.
What I did in my app now is using an array proxy that takes an array of my own types and converts them into the shape the library expects, which is a bit better GC-wise, but still worse than an "accessor" approach.
Working with accessors is a bit more annoying, but could be worth a try for huge sets of data. So the above boilerplate could then be written like this:
mySeries.setDataWithAccessors({
   data: array_of_stuff_I_have_from_my_data_source,
   dateAccessor: (data, idx) => data[idx].retrieve_the_date_from_my_own_type(),
   valueAccessor: (data, idx) => data[idx].retrieve_the_value_from_my_own_type()
})

or with closures
const arr = array_of_stuff_I_have_from_my_data_source;

mySeries.setDataWithAccessors({
   length: arr.length,
   dateAccessor: (idx) => arr[idx].retrieve_the_date_from_my_own_type(),
   valueAccessor: (idx) => arr[idx].retrieve_the_value_from_my_own_type()
})

a more efficient input format would help, but is likely not the main speedup here.
Chart.js-next [1] has basically identical prep code and runs in the same amount of time (~50ms) on my machine.
[1] https://leeoniya.github.io/uPlot/bench/Chart.js-next.html

btw we've made some perf improvements in #486 and now setting a data should be a bit faster.

I just tested https://leeoniya.github.io/uPlot/bench/lightweight-charts.html page with v3.6.1 and it seems that it is twice faster than v3.0.0 (~400ms vs ~200ms). The upcoming v3.7.0 is even more faster than v3.6.1 up to 25% (~150ms), so total improvements since v3.0.0 are ~60% (from 400ms to 150ms). I think this is good enough for now so we can close this issue.


Expose MicStreamSelector  to Unity

Hi guys
Just wondering if someone has been working on making the HoloToolKit MicStreamSelector available from Unity ?
Something we would need here soonish so I thought I should ask in case there's already something available privately.
Thanks in advance
-s

@andymule are you working on this currently?

Yeah should be done and checked in next week

Great news ! On Friday last weed I gave it a quick go, here is the c# bindings that seem to work except for MicGetFrame that I ignored.
You probably have done that already anyway !
`using System;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using UnityEngine;
namespace HoloToolkit.Unity
{
public class MicStreamSelector
{
#region Public APIs
    public static int MicInitialize(int category, int fftsize, int numBuffers, int samplerate)
    {
        return DLLImports.MicInitialize(category, fftsize, numBuffers, samplerate);
    }

    public static int MicStartStream(bool keepData)
    {
        return DLLImports.MicStartStream(keepData);
    }

    public static int MicStopStream()
    {
        return DLLImports.MicStopStream();
    }

    public static int MicStartRecording(String filename)
    {
        return DLLImports.MicStartRecording(filename);
    }

    public static int MicPause()
    {
        return DLLImports.MicPause();
    }

    public static int MicResume()
    {
        return DLLImports.MicResume();
    }

    public static int MicSetGain(float gain)
    {
        return DLLImports.MicSetGain(gain);
    }

    public static int MicDestroy()
    {
        return DLLImports.MicDestroy();
    }

    #endregion

    #region Internal

    /// <summary>
    /// Raw MicStreamSelector.dll imports
    /// </summary>
    private class DLLImports
    {
        [DllImport("MicStreamSelector")]
        public static extern int MicInitialize(
            [In] int category,
            [In] int fftsize,
            [In] int numBuffers,
            [In] int samplerate);

        [DllImport("MicStreamSelector")]
        public static extern int MicStartStream(
            [In] bool keepData);

        [DllImport("MicStreamSelector")]
        public static extern int MicStopStream();

        [DllImport("MicStreamSelector")]
        public static extern int MicStartRecording(
            [In] String filename);

        [DllImport("MicStreamSelector")]
        public static extern int MicStopRecording(
            [In] String path);

        /*
        [DllImport("MicStreamSelector")]
        public static extern int MicGetFrame(// float *
            [In] int length,
            [In] int numchannels
            );
        */

        [DllImport("MicStreamSelector")]
        public static extern int MicPause();

        [DllImport("MicStreamSelector")]
        public static extern int MicResume();

        [DllImport("MicStreamSelector")]
        public static extern int MicSetGain(
            [In] float gain);

        [DllImport("MicStreamSelector")]
        public static extern int MicDestroy();
    }

    #endregion
}

}`

Here is a new version kindly improved by Dave Sullivan here in London
'''c#
using System;
using System.IO;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using UnityEngine;
#if NETFX_CORE
using Windows.Storage;
#endif
namespace HoloToolkit.Unity
{
public class MicStreamSelector
{
public enum ErrorCode
{
ALREADY_RUNNING = -10,
NO_AUDIO_DEVICE,
NO_INPUT_DEVICE,
ALREADY_RECORDING,
GRAPH_NOT_EXIST,
CHANNEL_COUNT_MISMATCH,
FILE_CREATION_PERMISSION_ERROR,
NOT_IMPLEMENTED = -1,
SUCCESS = 0
}
#region Public APIs
    public static ErrorCode MicInitialize(int category, int fftsize, int numBuffers, int samplerate)
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicInitialize(category, fftsize, numBuffers, samplerate);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicStartStream(bool keepData)
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStartStream(keepData);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicStopStream()
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStopStream();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicStartRecording(String filename)
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStartRecording(filename);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicStopRecording(ref String filename)
    {

#if NETFX_CORE
string originalFilename = filename;
        IntPtr msgBuffer = Marshal.AllocHGlobal(256);

        try
        {
            Marshal.WriteByte(msgBuffer, 0);
            DLLImports.MicStopRecording(msgBuffer);
            filename = Marshal.PtrToStringAnsi(msgBuffer);
        }
        finally
        {
            Marshal.FreeHGlobal(msgBuffer);
        }

        //Debug.LogFormat("New audio filename is {0}", filename);
        //filename = System.IO.Path.Combine(KnownFolders.MusicLibrary.Path, filename);

        var fileInfo = new FileInfo(filename);
        if (fileInfo.Exists)
        {
            return ErrorCode.SUCCESS;
        }

        return ErrorCode.FILE_CREATION_PERMISSION_ERROR;

#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicPause()
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicPause();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicResume()
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicResume();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicSetGain(float gain)
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicSetGain(gain);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
    public static ErrorCode MicDestroy()
    {

#if NETFX_CORE
return (ErrorCode)DLLImports.MicDestroy();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
#endregion
#region Internal
    /// <summary>
    /// Raw MicStreamSelector.dll imports
    /// </summary>
    private class DLLImports
    {
        [DllImport("MicStreamSelector")]
        public static extern int MicInitialize(
            [In] int category,
            [In] int fftsize,
            [In] int numBuffers,
            [In] int samplerate);

        [DllImport("MicStreamSelector")]
        public static extern int MicStartStream(
            [In] bool keepData);

        [DllImport("MicStreamSelector")]
        public static extern int MicStopStream();

        [DllImport("MicStreamSelector")]
        public static extern int MicStartRecording(
            [In] String filename);

        [DllImport("MicStreamSelector")]
        public static extern void MicStopRecording(
            [In] IntPtr path);

        /*
        [DllImport("MicStreamSelector")]
        public static extern int MicGetFrame(// float *
            [In] int length,
            [In] int numchannels
            );
        */

        [DllImport("MicStreamSelector")]
        public static extern int MicPause();

        [DllImport("MicStreamSelector")]
        public static extern int MicResume();

        [DllImport("MicStreamSelector")]
        public static extern int MicSetGain(
            [In] float gain);

        [DllImport("MicStreamSelector")]
        public static extern int MicDestroy();
    }

#endregion
}
}

@andymule Looks like maybe we've got a couple implementations here. Reasons to wait on yours or should @stbertou just make a PR?

Thanks for this, Dave and Stephane. The MicStream code is still under some internal development, so I’m not sure how much of the changes will make it into HoloToolkit, but we’ll look at it. In particular, I’m not sure why it’s returning NOT_IMPLEMENTED when you’re not running NETFX_CORE, as the code works fine running in the Unity editor on Windows 10, and having the code run in the Unity editor makes development much easier.
From: Stephane Bertout<EMAIL_ADDRESS>Sent: Wednesday, July 6, 2016 2:34 AM
To: Microsoft/HoloToolkit-Unity<EMAIL_ADDRESS>Subject: Re: [Microsoft/HoloToolkit-Unity] Expose MicStreamSelector to Unity (#86)
Here is a new version kindly improved by Dave Sullivan here in London
'''c#
using System;
using System.IO;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using UnityEngine;
#if NETFX_CORE
using Windows.Storage;
#endif
namespace HoloToolkit.Unity
{
public class MicStreamSelector
{
public enum ErrorCode
{
ALREADY_RUNNING = -10,
NO_AUDIO_DEVICE,
NO_INPUT_DEVICE,
ALREADY_RECORDING,
GRAPH_NOT_EXIST,
CHANNEL_COUNT_MISMATCH,
FILE_CREATION_PERMISSION_ERROR,
NOT_IMPLEMENTED = -1,
SUCCESS = 0
}
#region Public APIs
public static ErrorCode MicInitialize(int category, int fftsize, int numBuffers, int samplerate)

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicInitialize(category, fftsize, numBuffers, samplerate);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicStartStream(bool keepData)

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStartStream(keepData);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicStopStream()

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStopStream();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicStartRecording(String filename)

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicStartRecording(filename);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicStopRecording(ref String filename)

{

#if NETFX_CORE
string originalFilename = filename;
    IntPtr msgBuffer = Marshal.AllocHGlobal(256);

    try

    {

        Marshal.WriteByte(msgBuffer, 0);

        DLLImports.MicStopRecording(msgBuffer);

        filename = Marshal.PtrToStringAnsi(msgBuffer);

    }

    finally

    {

        Marshal.FreeHGlobal(msgBuffer);

    }

    //Debug.LogFormat("New audio filename is {0}", filename);

    //filename = System.IO.Path.Combine(KnownFolders.MusicLibrary.Path, filename);

    var fileInfo = new FileInfo(filename);

    if (fileInfo.Exists)

    {

        return ErrorCode.SUCCESS;

    }

    return ErrorCode.FILE_CREATION_PERMISSION_ERROR;

#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicPause()

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicPause();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicResume()

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicResume();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicSetGain(float gain)

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicSetGain(gain);
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
public static ErrorCode MicDestroy()

{

#if NETFX_CORE
return (ErrorCode)DLLImports.MicDestroy();
#else
return ErrorCode.NOT_IMPLEMENTED;
#endif
}
#endregion
#region Internal
/// <summary>

/// Raw MicStreamSelector.dll imports

/// </summary>

private class DLLImports

{

    [DllImport("MicStreamSelector")]

    public static extern int MicInitialize(

        [In] int category,

        [In] int fftsize,

        [In] int numBuffers,

        [In] int samplerate);

    [DllImport("MicStreamSelector")]

    public static extern int MicStartStream(

        [In] bool keepData);

    [DllImport("MicStreamSelector")]

    public static extern int MicStopStream();

    [DllImport("MicStreamSelector")]

    public static extern int MicStartRecording(

        [In] String filename);

    [DllImport("MicStreamSelector")]

    public static extern void MicStopRecording(

        [In] IntPtr path);

    /*

    [DllImport("MicStreamSelector")]

    public static extern int MicGetFrame(// float *

        [In] int length,

        [In] int numchannels

        );

    */

    [DllImport("MicStreamSelector")]

    public static extern int MicPause();

    [DllImport("MicStreamSelector")]

    public static extern int MicResume();

    [DllImport("MicStreamSelector")]

    public static extern int MicSetGain(

        [In] float gain);

    [DllImport("MicStreamSelector")]

    public static extern int MicDestroy();

}

#endregion
}
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/HoloToolkit-Unity/issues/86#issuecomment-230724465, or mute the threadhttps://github.com/notifications/unsubscribe/AQ8k1b3V5RN2NQVm_xZOixW1eZD4lFNaks5qS3aQgaJpZM4JCM5N.

I'll let @Davesullivanatwork comment here but he told me the DLL was somehow not working from within the editor

@DanHolbert mind if I clean up your comment? It's full of the reply text from the email and is cluttering up this thread.

Done. I didn't realize that email replies were generating GitHub comments.

@andymule is this done? Can we get a PR?

Hey guys, didn't see all this talk until now. There are official PRs out on this repo and a matching one going into the main Holotoolkit. It should all be good to go everywhere. Please use excessively and make changes as you see fit. Cheers!

Thanks @andymule! - #117


Docker fails to start

Logs of functioning version outside of docker.
><EMAIL_ADDRESS>start
> ts-node cmd/bot.ts

open.time 0 2023-07-22T21:31:26.318Z
ws ready 2023-07-22T21:31:27.917Z
Bot started 2023-07-22T21:31:28.447Z

Using docker it stops after open.time
anyone knows what's happening?

For anyone experiencing this, I had to remove the quotes in the .env file passed to docker.


Add function to compute gaps for Mortar

It would be convenient to have a way to compute gaps without updating forces and Jacobian contributions in the mortar method.  See this code in Serac.  There, when we are using a penalty enforcement of the constraint we have to call update() twice for the code to work properly: once to update the gaps for computing the updated pressures, then again to compute the forces and Jacobian with the updated pressures.

Yeah right now you'd have to modify the implicit evaluation option to compute gaps only and then call update(). I don't think the gap, residual, jacobian calculations in the mortar physics routine are guarded correctly, but that is an easy fix. We could easily write an API function that computes the gaps for a given coupling scheme and currently registered mesh data, but if you wanted to update the geometry of the overlaps you may as well call update. If that feels awkward, maybe we have an API routine that actually wraps update(), but to the user feels like they are getting what they are asking for? Let's discuss more.


[incubator/kafka] Changed KAFKA_ADVERTISED_LISTENERS use a fully-qualified DNS name.

Added .svc.cluster.local to the default DNS name.
Fixes #19436
Signed-off-by: Kent Hagerman<EMAIL_ADDRESS>

/ok-to-test

/lgtm


[1.5] Disabling blur and shadows causes render issues on Mac Os X

Hello! After updating to 1.5 i've noticed that disabling both blur and shadow causes render issues on Mac Os X.
Steps to reproduce:

Open standard "Box2dLightsTest"

Add
rayHandler.setBlur(false);
rayHandler.setShadows(false);

after rayHandler = new RayHandler(world)
Notice artifacts like this:

In 1.4 everything is fine.

If this is a blocker, can we get at least a 1.5-SNAPSHOT released to Nexus?


BUG: Mitosis does not camelCase HTML attributes in React

Scope

[ ] This impacts ALL Mitosis outputs
[x] This only impacts specific generators/outputs (please list them here): React

Describe the bug
Attributes like srcset are camelCased in React (possibly other frameworks? Not sure). However, Mitosis does not account for that
To Reproduce
A link to a https://mitosis.builder.io/ fiddle containing the bug: link
Expected behavior
scrset should become srcSet in the React output. Same goes for all HTML attributes that are multi-word: https://reactjs.org/docs/dom-elements.html
Additional context

I am not sure what the comprehensive list of camelCased DOM elements is, but we can probably look at React's JSX types to determine what to do
I am also not sure if other frameworks do this camelCasing. We might need to do this elsewhere too

Technical information:
We already have a list of all HTML elements: https://github.com/BuilderIO/mitosis/blob/b8d083ca78bdaec332745d2a0f8c0890335072c4/packages/core/src/constants/html_tags.ts#L1
We want to go to the blockToReact function, and identify blocks that are native HTML elements, and rename any json.bindings or json.properties keys that should be camelCased.
https://github.com/BuilderIO/mitosis/blob/b8d083ca78bdaec332745d2a0f8c0890335072c4/packages/core/src/generators/react.ts#L164-L167
https://github.com/BuilderIO/mitosis/blob/b8d083ca78bdaec332745d2a0f8c0890335072c4/packages/core/src/generators/react.ts#L184-L186
In both of these for-loops, we want to add a check that looks like this:
const isHtmlElement = VALID_HTML_TAGS.includes(json.name);

const checkKeyShouldBeCamelCased = (key: string) => {
  // ... TO-DO:
}

const camelCaseNativeHTMLAttribute = (attrName: string) => {
  // ... TO-DO:
}

if (isHtmlElement && checkKeyShouldBeCamelCased(key)) {
  str += ` ${camelCaseNativeHTMLAttribute(key)=${value}`
} else if // the rest of the code

I will like to take up this issue

oh I'm not sure if lists are the wistest approach here, HTML spec constantly evolves. The intent behind our JSX is that we match React JSX, so srcSet should be srcSet in Mitosis too
In the early days I tried to do transformations like this (and we explored it with Qwik for a minute), but it wasn't wise
what's the concern with just writing <picture srcSet> in mitosis? then we dashCase them
React's logic is similarly intentionally simple, there is no trying to replicate DOM tags and attrs in the library, their logic (which the intent behind Mitosis is)
const isHtmElement = isFirstLetterLowerCase(json.name)

looking a little deeper, I feel a bit more reason to copy react the convention. with all of this we need to account for webcomponents too. what I've observed react's full logic is:
const isHtmlElement = isFirstLetterLowerCase(json.name)
const isBuiltInElement = !json.name.includes('-')
const isCustomElement = json.name.includes('-')

const isBuiltInHtmlAttrName = isHtmlElement && !propertyName.include('-')
const isCustomHtmlAttrName = isHtmlElement && propertyName.includes('-')

but in general we should stick to if Mitosis uses JSX style (camelCase properties) or HTML style. for familiarity, my belief was JSX style is the right way, with one exception for class - similar to what Solid does.


NuGet gallery UI should show target frameworks the package

Neither nuget.org nor preview.nuget.org show the target frameworks of a package. Consider a package that targets net40 and net45, but expresses no package dependencies. The gallery shows no hint as to what projects the package might install into.
Even when dependencies are expressed, that's only a rough estimate, and can under express the compatibility of this package. For example, a package might take a dependency on NetStandard.Library when targeting netstandard1.5 but have no dependency for net40, and the gallery will only show netstandard1.5 on the page even though net40 is also a target.
It seems like a super basic and critical trait of a package to be able to see on the gallery. Can it be added?
see also: https://github.com/NuGet/NuGetGallery/issues/2805

I don't know what others think about this, but for me, I can make do without a full list of every possible compatible runtime as long as package's explicit targets are listed. For example, if it contains builds for .NET Standard 2.0 and .NET 4.5.2 and the UI shows that, I can figure out that the .NET Framework 4.7.0 will work just fine with at least one of those. The main thing I'm looking to determine is, "Is there any target framework in the package that is compatible with my project's currently targeted framework?"

We've shipped a Frameworks tab on the package details page. This shows all package asset frameworks (frameworks directly expressed by assets in the package) and calculated frameworks (implicit support via TFM mappings). This was tracked by https://github.com/NuGet/NuGetGallery/issues/4843 and is now resolved.
If you feel that what you're describing is now implemented yet, please feel free to open a new issue with details!
Thanks!


fix cron examples

Change-Id: I51a429c367a7412f0f81afaf7ae9fd642ce3f52c

Closing this PR since the documentation has been fixed with 1.0.0


Modify circuit breaker

Add package flowtoken, which can control request traffic and adjust flow threshold automatically based on success rate per second.
Modify Redis client and Cluster client circuit breaker, change it to work with flowtoken.

Can you please rebase this on master and fix build? Specifically please replace convey with https://github.com/onsi/ginkgo - that is what we use for testing go-redis.

@vmihailenco Sorry for the late reply to you, I am on vacation these days.
I have replaced convey with ginkgo, and rebase my branch on master. When I do "rebase" for the latest code, there have some weird conflicts, so I aborted the latest rebase. Please check whether I need to do rebase again.


Doctype description added

You have not added the most first question that comes into the mind of a beginner that is what's the meaning of <! doctype html>. So I have added it.

Thank you :)


"Could not create GL context" error on startup for GL 3.0

Since commit 65dbb735249badebce7298ba97a8490d2bc20506 , when I try to run rs_doom, compiled with nightly rustc (1.6.0-nightly (8ca0acc25 2015-10-28)), I get this message:
$ target/debug/rs_doom
rs_doom: graphics error: SDL: SDL error: Could not create GL context

I'm on Ubuntu 14.04 x86_64, running on this laptop with the following specs:
CPU: Intel Core i3-2328M
GPU: Intel Sandybridge Mobile
the mesa driver supports Opengl 3.0 and 3.1(core profile), if it might help.

I was worried about this; I did a little compatibility survey on #rust-gamedev and it seemed fine though. I bumped the OpenGL requirement to 3.3, but I guess I shouldn't have.
The reason I had to do this was because I'm using a BUFFER_TEXTURE instead of a uniform array in static.vert because glium doesn't support uniform arrays (they're slightly obsolete in a sense, thanks to uniform blocks and buffer textures).
I should try switching back to a uniform array with a glium workaround. I'll have a look tonight, sorry about the breakage! :(

Hi @edward-san ! Sorry it took me a while to get to this; I merged #64 which (since you mention your drivers support 3.1 core), should make it work on your machine again. Could you please try and let me know? Thanks!

Yes, it opens fine, but the rendering is now different from before. See this screenshot:

Is the problem that washed-out-ness? Can't easily tell from the screenshot.

Would you mind checking out the old version (say git checkout 151b93a2d92c46aa8002edf69970dbe54c1f7637) and send me a comparison screenshot, please?

Oops, sorry for that. Here:

Thanks a lot @edward-san ! Good news is I managed to reproduce this by using my laptop's nvidia card instead of the integrated one. I'll try to find what's happening; working theory: BUFFER_TEXTURE is used to just store numbers, but it is a texture so sRGB correction hits somewhere where it didn't used to, muddling everything up.

Is there a way to disable the shader stuff so it could be run on OpenGL 1.x?
This way it could even start working on arm devices using the glshim wrapper.

@petevine In short, not easily: glium (the library used for OpenGL calls) doesn't support the fixed function pipeline and even if it did it's not clear that it would be easy to achieve all the effects needed using it. You're better off with a software renderer at that point. If you have some ideas or want to discuss this further, could you please file a different issue?

Regarding this actual issue. Having investigated more, it seems to be entirely unrelated to the buffer texture thing: even just clearing the screen looks different. The bug is triggered only by running the glium version with the nvidia card. Switching to the pre-glium version of the code or to the integrated gpu both fix it.
New theory: something in the initialisation of glium messes with gamma/brightness somehow.

OK so the issue was that if the device is SRGB capable, then glium assumes an SRGB framebuffer by default. I had to change everything to use SRGB everywhere and that seems to have fixed it on my nvidia card.
@edward-san Could you please check whether this works for you now?

@cristicbz yes, it fixed the issue.

Yay, great, thanks for filing and being patient!


Change query to an object in wp-source example

It was a string and that is wrong. It's an object.

@luisherranz  Thanks!
Approved & merged!


Make Reciprocal Method setting a drop-down

**lurch:attach W-010047

Tracking W-010047

Included in beta release version 1.13 (Beta 1) and higher

Hey guys - when does this go "live"?

It should be pushed to sandboxes on Wednesday, and to production a week after that, if I'm not mistaken. Could you please verify, @cpolcyn? Thanks!

This PR resulted in the creation of release beta/1.13-Beta_1. The HEDA 1.13 release will be created on Aug 3 and pushed to sandboxes that evening. It will then be pushed to production the following Tuesday, Aug 9.

Awesome - thank you for this detailed info.

Included in production release version 1.13


[Setup] add support for embedded MSIX packages

Summary of the Pull Request
What is this about:
This PR brings some functionality for integrating MSIX packages inside PowerToys installer with some commented out stuff - "TODO: Use to activate embedded MSIX" - for easier integration. I've also posted instructions and an example msix module integration in the issue.
What is include in the PR:
How does someone test / validate:
Quality Checklist

[ ] Linked issue: #11705
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

/azp run


PWA-257 update to react 16.3

Pull Request Test Coverage Report for Build 594

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.452%

Totals

Change from base Build 592:
0.0%

Covered Lines:
1857

Relevant Lines:
4378

💛  - Coveralls


Mono Compatibility appears to be broken: Cannot build VroomJS

Following the guide on the site: http://reactjs.net/guides/mono.html
Compiling the vroom engine fails consistently.
$ make native wError=no library=shared soname_version=<IP_ADDRESS> -j4
  CXX(target) /usr/local/src/v8-3.17/out/native/obj.target/preparser_lib/src/cached-powers.o
  CXX(target) /usr/local/src/v8-3.17/out/native/obj.target/preparser_lib/src/conversions.o
  CXX(target) /usr/local/src/v8-3.17/out/native/obj.target/preparser_lib/src/diy-fp.o
  CXX(target) /usr/local/src/v8-3.17/out/native/obj.target/preparser_lib/src/dtoa.o
../src/cached-powers.cc:136:18: error: unused variable 'kCachedPowersLength' [-Werror,-Wunused-const-variable]
static const int kCachedPowersLength = ARRAY_SIZE(kCachedPowers);
                 ^
1 error generated.
make[1]: *** [/usr/local/src/v8-3.17/out/native/obj.target/preparser_lib/src/cached-powers.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [native] Error 2

$ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/c++/4.2.1
Apple LLVM version 6.1.0 (clang-602.0.49) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.3.0
Thread model: posix

Just ran through the guide on ubuntu. Made it further but still:
$ g++ jscontext.cpp jsengine.cpp managedref.cpp bridge.cpp jsscript.cpp -o libVroomJsNative.so -shared -L /usr/local/src/v8-3.17/out/native/lib.target/ -I /usr/local/src/v8-3.17/include/ -fPIC -Wl,--no-as-needed -l:/usr/local/lib/libv8.so.<IP_ADDRESS>
jsengine.cpp: In member function ‘jsvalue JsEngine::ErrorFromV8(v8::TryCatch&)’:
jsengine.cpp:260:34: error: ‘memset’ was not declared in this scope
  memset(error, 0, sizeof(jserror));

#include <cstring>
needs to be added to jsengine.cpp for this to build.

Sorry I didn't see this until now, I was flying from the US to Australia and haven't checked my emails for a while.
On Mac OS X you may need to use gcc rather than Apple's LLVM. It looks like it's a build issue in V8 itself rather than VroomJS. It may have been fixed with a newer V8 version. Unfortunately VroomJS only supports an older version of V8 and I'm not experienced with C++ at all so it'd be quite difficult for me to update it myself.
Did you end up successfully compiling on Ubuntu once you added the cstring include?

 Feel free to reopen if this is still an issue for you. Thanks!


Floating point bug

ℹ Computer information

Windows build number: 18363.900
PowerToys version: 0.19.2
PowerToy module: Run

📝 Provide detailed reproduction steps (if any)

Open run
make calculation: 2382.11-1300

✔ Expected result
1082.11
❌ Actual result
1082.1100000000001
📷 Screenshots

tracked in #3697.  Limitation brought over from wox.  we're looking at how best to replace it


Feature: Opportunity add TTL to record

Example: Paper.book().write("city", "Lund").ttl(3600) //3600 sec
Now we can't read value after 3600 sec. It will return null

At this moment I use wrapper for this. But I have one drawback. I remove expired data when I read from db. I need automatic remove expired data with ttl (as redis do)

To be honest I don't think this feature should be a part of any database. You can design your data model in order to serve a purpose like yours. For example, you can keep a timestamp along with your data and check it on reading and so on. So I'm closing this feature request.


Leave sshkey out of yaml when disabled/not relevant

Not sure if there's any way to really test this. It should be safe to rely on only the presence of account.Key, since that was thoroughly validated at the time an account was requested...
https://github.com/ucdavis/hippo/blob/05086736d396b85df548b9935ad0415031536ef0/Hippo.Web/Controllers/AccountController.cs#L108-L137
Closes #289

@srkirkland That's not what they wanted. They asked for the key property to not be included in the yaml instead of leaving an undefined, null or empty string.


sorry it doesnot work

win 64  it just empty nothing go on
i did used poxy setting as you said.

i imaged that would be  ,but you make it ture .

windows 10 64-bit? Betwixt window is absolutely empty or you are not recording any requests?

Closing due to lack of sufficient info to investigate. Let me know if you'll need help.


I cannot install the whole thing :|
Followed the installation guide. Zero error but "php -m | more" still doesn't display the line sapnwr.
Tried even with different builds .... actually trying with Php 7.2.5-1+ubuntu17.10.1+deb.sury.org+1
Any idea?
Thx

Have you enabled the extension in your php.ini?

I cannot find any "enable extension" I just copied the extension=sapnwrfc.so without semicolumns following the guide .....
I put this under ;dynamic extensions

That should suffice. Any error output when you launch a script?

Did you put the extension line in the correct php.ini file? Debian uses separate files for CLI and web IIRC.

<?php
$parameters = [
    'ashost' => 'my.sap.system.local',
    'sysnr'  => '00',
    'client' => '123',
    'user' => 'DEMO',
    'passwd' => 'XXXX',
];

// connect
$connection = new SAPNWRFC\Connection($parameters);

// do work here

// close the connection
$connection->close();
?>

Tried this one .... nothing happened.
I used phpinfo to get php.ini path .... is that correct ?

It depends on whether you are using the script from CLI or web. If you put the extension line in a php.ini file and it doesn't show up with php -m and does not print warnings about being unable to load the extension, it most likely is the wrong file.
You can try php -dextension=sapnwrfc.so -m from CLI to check if the extension loads.

Now I Got something like this ..... Really didn't know about the cli/web .....


"Negrilești" and "Slobozia Blăneasa" are listed in the drop-down menu

Description:
"Negrilești" and "Slobozia Blăneasa" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Negrilești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Negrilești, GALAȚI (Negrilești)" and "Comuna Negrilești, GALAȚI".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Slobozia Blăneasa" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Slobozia Blăneasa, GALAȚI (Negrilești)".


Notice: Only variables should be passed by reference in _webcomponents_cmstags_process() (line 364 of /var/www/html/platforms/drupal-7/sites/all/modules/webcomponents/modules/webcomponents_cmstags/webcomponents_cmstags.module).

like it says Notice: Only variables should be passed by reference in _webcomponents_cmstags_process() (line 364 of /var/www/html/platforms/drupal-7/sites/all/modules/webcomponents/modules/webcomponents_cmstags/webcomponents_cmstags.module).

fixed in contrib


Issue Labeler Added using GitHub Action

Fixes #2021

Issue-labeler by using GitHub Action

Adding the .yml file
I have added the issue-labeler with the help of taking labeler and issue open action. The job of this Action will be to add the GSSOC21 label on the issues.
Trial Checking
I have Tried the Code on my Repository, GitHub Bot Adds the GSSOC21 Label Automatically added to the issue. Here is the Screenshot that Shows How the Workflow works!
After GSSOC this same code can be used to add labels like a month of issue, etc.,
-------- Screenshot  ---------

@plazzy99 Hope to see these changes live on this project soon, Please Merge it, sir!

@rudrakshi99 Please Review it once, It will be Helpful a lot

we cannot directly label the issues because the issue can be already solved or a similar issue is assigned to anyone else. so, I am closing the pr


Update to AndroidX Navigation 2.8.0

Pull request
Description
This PR updates to AndroidX Navigation 2.8.0. The changelog is available here.
Changes made

Update to AndroidX Navigation 2.8.0.
Migrate NavHost to use type-safe navigation.

Hopefully, future versions of AndroidX Navigation will simplify things a bit:

Support property level @Serializable (see b/348468840): with that we should be able to remove the buName workaround in ContentList.
Support compsable(KClass) (in addition to composable<Route>) (see b/361863272): this should allow us to remove the addContentListRoute function in both ListsHome files (in pillarbox-demo and pillarbox-demo-tv).

Checklist

[x] Your branch has been rebased onto the main branch.
[ ] APIs have been properly documented (if relevant).
[ ] The documentation has been updated (if relevant).
[ ] New unit tests have been written (if relevant).
[x] The demo has been updated (if relevant).
[x] All pull request status checks pass.

Sounds goods but still on the TV, when selecting an item in the player settings, it closed immediatly.

Yes, I've opened a dedicated ticket for that: https://github.com/SRGSSR/pillarbox-android/issues/702


Won't run

Installs but won't run on Windows 8.1EE Build 9600.

I having the same problem described by n3wjack and I tried  http://ginnivan.blob.core.windows.net/markpadrelease/MarkPad.application  and Still get the same I make the Icon but when I click on it nothing


Changed defaults in make_forecasting_problem

Also, always include a descriptive PR message please.

Here quick answers for your points, in short my changes run well and I already merged them into #1083 which also passes now.

introduce two new arguments, n_y_columns and n_X_columns with the obvious meanings.

then we need to add this new params also to the other functions such as make_classification_problem, make_regression_problem, make_clustering_problem as they will raise otherwise an error, I faced this already with make_clustering_problem which didnt have n_columns param and couldnt handle the **kwargs. When we use **kwargs and iterate over different functions, the given args need to be used in the end anywhere in the downstream calls, otherwise there will be an error of unexpected param given.

the inner _make_series take these two arguments in the n_columns place

There was not any test which didnt default to n_columns=2 when returning X.

n_columns gets a deprecation note/warning.

In my opinion make_forecasting_problem is a private function, as it lives also in a private file from sktime.utils._testing.forecasting. Probably best to actually rename it also to _make_forecasting_problem. Is it therefore necessary to deprecate it with warning?

n_X_columns defaults to 2.

Yes, now it always defaults to 2, as there was not any test that actually used another value. So when anyone wants to create such a test, then it would be the time to change sth, but I would prefer to go with my slim solution for now, as it also does not affect other code/logic. Then we could do the bigger refactor in your PR?

the docstrings are updated.

Done, sry just forgot it.

I think n_columns was not even used before we started with multivariate y. At least I could not find such a test. So it always defaulted.

looks good (skipped appveyor since #1083 contains this and tests passed)


Test runner hangs when using service_healthy value

The ideal scenario is to use the service_healthy value in the test runner service dependencies.
Inspecting the service, docker inspect ...-lighttpd-1 | jq ".[].State.Health" indicates the service is healthy.
Using service_started is incorrect, but it seems lighttpd starts fast enough where it doesn't matter.

It appears that Docker Compose only listens to its own healthcheck? Either way, this was changed. The healthy service startup ordering seems to work in b974be60ae1b99eb69f85c868a2e1c3a41923a13.


[Facebook] - Support for checkbox plugin (Opt-Ins)

Hi,
it would be great to have support for the facebook checkbox plugin to handle user Opt-Ins. I already created custom driver for this scenario, but maybe there's a better solution. Here's my code:
class FacebookOptinDriver extends FacebookDriver
{
    const DRIVER_NAME = 'FacebookOptinDriver';

    /**
     * Return the driver name.
     *
     * @return string
     */
    public function getName()
    {
        return self::DRIVER_NAME;
    }

    /**
     * Determine if the request is for this driver.
     *
     * @return bool
     */
    public function matchesRequest()
    {
        $validSignature = ! $this->config->has('facebook_app_secret') || $this->validateSignature();
        $messages = Collection::make($this->event->get('messaging'))->filter(function ($msg) {
            return isset($msg['optin']['ref']) && isset($msg['optin']['user_ref']);
        });

        return ! $messages->isEmpty() && $validSignature;
    }

    /**
     * Retrieve the optin message.
     *
     * @return array
     */
    public function getMessages()
    {
        $messages = Collection::make($this->event->get('messaging'));
        $messages = $messages->transform(function ($msg) {
            return new Message($msg['optin']['ref'], $msg['recipient']['id'], $msg['optin']['user_ref'], $msg);
        })->toArray();

        if (count($messages) === 0) {
            return [new Message('', '', '')];
        }

        return $messages;
    }
}

What do you think?
Thank you.

So this is just for identifying the user right? Do you need it for some kind of chat on the website?

Yes, it's to identify the facebook user on a website and obtaining the user approval to receive notifications via facebook messenger:

seamless way for people to receive updates via Messenger

Once the checkbox is checked the following data will be pushed to the webhook:
{
  "recipient":{
    "id":"PAGE_ID"
  },
  "timestamp":1234567890,
  "optin":{
    "ref":"PASS_THROUGH_PARAM",
    "user_ref":"UNIQUE_REF_PARAM"
  }
}

In my opinion, a custom driver is a good way of handling this 👍
This is pretty much like the FacebookPostbackDriver.
Do you want to provide a pull request for this?

Yes, I'll create a pull request

Awesome, thank you! :)