Fix RtlCopyVolatileMemory declaration conflicts

On the latest SDK (10.0.26100.0), winnt.h defined:
#ifndef _RTL_VOL_MEM_ACCESSORS_
#define _RTL_VOL_MEM_ACCESSORS_

...

volatile void*
__cdecl
RtlCopyVolatileMemory (
    _Out_writes_bytes_all_(Length) volatile void* Destination,
    _In_reads_bytes_(Length) volatile const void* Source,
    _In_ size_t Length
    );

...

#endif

Which the declaration is different from current phnt and guarded by _RTL_VOL_MEM_ACCESSORS_ macro.
This change will fix a compile-time error:
Error C2040 'RtlCopyVolatileMemory': 'void (void *,volatile const void *,SIZE_T)' differs in levels of indirection from 'volatile void *(volatile void *,volatile const void *,size_t)', which is occurred in Issue #36, reported in the first line.

The implementation for this function changed and it's been split into several different functions with a seperate library. I've removed the typedefs since these older types are unreliable and should not be used going forward.


Clarify python-dev requirement

Resolves #2?
As discussed with @TomMelt and @jatkinson1000, and in #26, this hopefully clarifies initial comment on the need for python-dev, or equivalent.

Yep that looks good to me. Thanks 👍


Implement BPF Loader

Implement BPF loader according to JS and Rust sources

I agree. Composable pieces that can be used (and tested) individually without relying on hidden network calls.

Great, thanks! Then I'll refactor and push the updated code.
One remotely related question -- I also implemented the deployment and program call methods for Solang (https://github.com/hyperledger-labs/solang/blob/main/integration/solana/index.ts#L163) , but they depend on go-ethereum library. Do you think that adding go-ethereum as a dependency to solana-go is too much, and it's better to create another library which depends on go-ethereum and solana-go? Or it's OK to add the dependency here and add the code?

@gagliardetto OK, the code seems to correspond close to Rust CLI implementation now.

@gagliardetto I am not sure that I will be able to write tests in the near future because of other tasks. Right now it's "works on my machine" and the code can be checked against the reference implementation. I'd say it should be safe to add to the library as it does not affect other features, and tests can be implemented in the next pull requests.

No problem! You already did an awesome great job here! I'll write the tests.
I'll try it out deploying some programs in the next few days.
Thanks for your work!

@gagliardetto I'll just push one more update according to comments in this PR https://github.com/solana-labs/solana/pull/20895

@gagliardetto I renamed the packaged and fixed the conditional branches

Thank you @lebdron !!!


Adds a capabilities service to Tentacle.

Background
Adds a capabilities service to make it easier to discover what capabilities the remote Tentacle supports. This will make it easier for clients to work out what it can do with the Tentacle.
Results
Adds a backwards compatible capabilities service. The service returns a list of the capabilities of tentacle. Currently it returns an empty list which mean tentacle supports the current set of tentacle features.
The capabilities service is backwards compatible with older Tentacles which do not have a capabilities service. This is done by wrapping a Halibut created ICapabilitiesDecorator with a BackwardsCompatibleCapabilitiesDecorator. That can be done with the extension method WithBackwardsCompatability. See the test for an example.
How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

PR to test with Octopus Server
Full build


support AFL++ fuzzing

Why can't the existing UNIX domain socket transport be used for fuzzing?

AFL expects to be able to start a process and write to it for fuzzing, so going through unix domain socket doesn't work (easily).

I see some duplication between tran_sock and tran_pipe, could we avoid that by moving the tran_pipe stuff into tran_sock?

Yeah, at least negotiate has a ton of duplication, let me take a look at fixing this.

Thanos: I refactored to share the negotiate code. I think trying to go any further would actually complicate things more - I don't want to add too much more to tran API.

I do not like the fact that this code around VFU_TRANS_PIPE will be part of regular builds although used only for testing.
Can we somehow extract it out and build only in case for AFL testing?

I don't want this to regress (not build) as we make changes though. I could add a build option, and only set it for "make pre-push" (or if explicitly given) ? Would that be better?

Yes that would be better to build only in case if explicitly asked or pre-push. Thanks

@swapnili @tmakatos ok now?


Why the custom types?

I recently created a similar maybe/monad/optional type library like yourself:
https://github.com/morganhein/mo/blob/main/maybe.go
I'm trying to understand why you're creating custom types in your library?
My question is 100% trying to understand if there's something i'm missing, but I don't see a reason to include types.
So, what's your thinking here? Thanks!

They aren't necessary but do make it visually closer to standard Go types. As they are type aliases there is no performance hit. They are also optional.

Closing this for now. Let me know if you have any other questions 👍


Problem: Internal Commands is missing the "Loading Table" while data is loading

This no longer appears to be the case.


Implemeting Optimizely

We would like to use Optimizely's A/B testing suite on our Barba.js powered site. For this to occur we will need to leverage Optimizely's ability to activate on push/pop state change as referenced here.
I wanted to check with you to confirm the best way of doing this. I see the Google Analytics implementation referenced in #88. Would something similar be the best way to implement this tracking code?
  Barba.Dispatcher.on('initStateChange', function() {
  if (typeof ga === 'function') {
    ga('send', 'pageview', location.pathname);
    console.log("sent-ga-code");
  }
});

This is the code that needs to activate Optimizely:
(function(history){
    var pushState = history.pushState;
    history.pushState = function(state) {
        if (typeof history.onpushstate == "function") {
            window.onpopstate({state: state});
        }
        return pushState.apply(history, arguments);
    };
})(window.history);

var currentUrl = document.location.hostname + document.location.pathname;

onPotentialRouteChange = function () {
  window.setTimeout(function() {
    var newUrl = document.location.hostname + document.location.pathname;
    if (newUrl !== currentUrl) {
      onRouteChange();
    }
    currentUrl = newUrl;
  }, 10);
};

history.onpushstate = onPotentialRouteChange;
window.onpopstate = onPotentialRouteChange;

onRouteChange = function() {
    window.optimizely = window.optimizely || [];
    window.optimizely.push({type: 'activate'});
};

So within Barba would this work?
  Barba.Dispatcher.on('initStateChange', function() {
    window.optimizely = window.optimizely || [];
    window.optimizely.push({type: 'activate'});
});

Thank you @luruke  for this awesome library!

Hello @grahamd711 ,
I don't use optimizely, but indeed your code
Barba.Dispatcher.on('initStateChange', function() {
    window.optimizely = window.optimizely || [];
    window.optimizely.push({type: 'activate'});
});

should do the job


Jittable eigh

@hawkinsp @tlu7 @rmlarson
This commit evades the varying blocksize issue associated with QDWH-SVD by using a different polynomial iteration that computes a rank-k orthogonal projector for given k directly. The specific algorithm is described here: https://core.ac.uk/download/pdf/79508571.pdf.
I'd been trying to avoid this because the performance and error behaviour, while still not awful, tends not to be quite so good as obtained by QDWH. But the solutions I came up with turned out to be generally even worse.

Closing. We've had a jit-table eigh for some time by using a bucketing and padding strategy.


[video_player] macOS with --enable-impeller no video

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
video_player
What target platforms are you seeing this bug on?
macOS
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
      url: "https://pub.dev"
    source: hosted
    version: "1.17.2"
  csslib:
    dependency: transitive
    description:
      name: csslib
      sha256: "706b5707578e0c1b4b7550f64078f0a0f19dec3f50a178ffae7006b0a9ca58fb"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.0"
  cupertino_icons:
    dependency: "direct main"
    description:
      name: cupertino_icons
      sha256: d57953e10f9f8327ce64a508a355f0b1ec902193f66288e8cb5070e7c47eeb2d
      url: "https://pub.dev"
    source: hosted
    version: "1.0.6"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_lints:
    dependency: "direct dev"
    description:
      name: flutter_lints
      sha256: a25a15ebbdfc33ab1cd26c63a6ee519df92338a9c10f122adda92938253bef04
      url: "https://pub.dev"
    source: hosted
    version: "2.0.3"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_web_plugins:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  html:
    dependency: transitive
    description:
      name: html
      sha256: "3a7812d5bcd2894edf53dfaf8cd640876cf6cef50a8f238745c8b8120ea74d3a"
      url: "https://pub.dev"
    source: hosted
    version: "0.15.4"
  lints:
    dependency: transitive
    description:
      name: lints
      sha256: "0a217c6c989d21039f1498c3ed9f3ed71b354e69873f13a8dfc3c9fe76f1b452"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
      url: "https://pub.dev"
    source: hosted
    version: "0.5.0"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.1"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
      url: "https://pub.dev"
    source: hosted
    version: "1.8.3"
  plugin_platform_interface:
    dependency: transitive
    description:
      name: plugin_platform_interface
      sha256: da3fdfeccc4d4ff2da8f8c556704c08f912542c5fb3cf2233ed75372384a034d
      url: "https://pub.dev"
    source: hosted
    version: "2.1.6"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
      url: "https://pub.dev"
    source: hosted
    version: "1.11.0"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
      url: "https://pub.dev"
    source: hosted
    version: "0.6.0"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  video_player:
    dependency: "direct main"
    description:
      name: video_player
      sha256: "74b86e63529cf5885130c639d74cd2f9232e7c8a66cbecbddd1dcb9dbd060d1e"
      url: "https://pub.dev"
    source: hosted
    version: "2.7.2"
  video_player_android:
    dependency: transitive
    description:
      name: video_player_android
      sha256: "3fe89ab07fdbce786e7eb25b58532d6eaf189ceddc091cb66cba712f8d9e8e55"
      url: "https://pub.dev"
    source: hosted
    version: "2.4.10"
  video_player_avfoundation:
    dependency: transitive
    description:
      name: video_player_avfoundation
      sha256: "6387c2de77763b45104256b3b00b660089be4f909ded8631457dc11bf635e38f"
      url: "https://pub.dev"
    source: hosted
    version: "2.5.0"
  video_player_platform_interface:
    dependency: transitive
    description:
      name: video_player_platform_interface
      sha256: be72301bf2c0150ab35a8c34d66e5a99de525f6de1e8d27c0672b836fe48f73a
      url: "https://pub.dev"
    source: hosted
    version: "6.2.1"
  video_player_web:
    dependency: transitive
    description:
      name: video_player_web
      sha256: "2dd24f7ba46bfb5d070e9c795001db95e0ca5f2a3d025e98f287c10c9f0fd62f"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  web:
    dependency: transitive
    description:
      name: web
      sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
      url: "https://pub.dev"
    source: hosted
    version: "0.1.4-beta"
sdks:
  dart: ">=3.1.3 <4.0.0"
  flutter: ">=3.13.0"

Steps to reproduce

Use official [video_player] plugin example
Enable Impeller via --enable-impeller
Add <key>FLTEnableImpeller</key><true /> to Info.plist
Add <key>com.apple.security.network.client</key><true/> to entitlements
Run app
No video :(

I'm using macOS 14.0 on M1 Max chip. Sound is playing, but there's no video. If I don't enable Impeller everything is almost good (there's bug with blinking video during playback but this is for other issue because it's floating bug I can't catch it).
I have seen some related issues but they're too old and fixed by new Flutter versions but I'm using the latest stable.
Expected results
Video and sound playing
Actual results
Video not playing but sound is OK
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';

void main() => runApp(const VideoApp());

/// Stateful widget to fetch and then display video content.
class VideoApp extends StatefulWidget {
  const VideoApp({super.key});

  @override
  _VideoAppState createState() => _VideoAppState();
}

class _VideoAppState extends State<VideoApp> {
  late VideoPlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.networkUrl(Uri.parse(
        'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4'))
      ..initialize().then((_) {
        // Ensure the first frame is shown after the video is initialized, even before the play button has been pressed.
        setState(() {});
      });
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Video Demo',
      home: Scaffold(
        body: Center(
          child: _controller.value.isInitialized
              ? AspectRatio(
            aspectRatio: _controller.value.aspectRatio,
            child: VideoPlayer(_controller),
          )
              : Container(),
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
          ),
        ),
      ),
    );
  }

  @override
  void dispose() {
    super.dispose();
    _controller.dispose();
  }
}

Screenshots or Videos

Screenshots / Video demonstration

Logs
Logs
[ERROR:flutter/shell/platform/embedder/embedder_surface_metal_impeller.mm(50)] Using the Impeller rendering backend (Metal).
Debug service listening on ws://<IP_ADDRESS>:62449/0JVPau7cQ3Q=/ws
Syncing files to device macOS...
[ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER>16384
[ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER>16384
[ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER>16384
[ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER>16384
...
[ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER>16384
2023-10-03 11:39:41.319 video_player_macos_with_impeller_issue[57872:7917475] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.6, on macOS 14.0 23A344 darwin-arm64, locale ru-BY)
    • Flutter version 3.13.6 on channel stable at /Users/admin/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (6 days ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/admin/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /Users/admin/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/admin/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Connected device (3 available)
    • iPhone (mobile) • 00008030-00125C940292802E • ios            • iOS 17.0.2 21A351
    • macOS (desktop) • macos                     • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)    • chrome                    • web-javascript • Google Chrome 117.0.5938.132

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @d-polikhranidi. Thanks for filing this. I see similar issues as well. Can you check if this provides more information https://github.com/flutter/flutter/issues/41688#issuecomment-1731867104?

Hi @d-polikhranidi. Thanks for filing this. I see similar issues as well. Can you check if this provides some information #41688 (comment)?

Hi @dam-ease. It doesn't seem that this is related to my problem, since after comment #41688 (comment) there was a [video_player] update that fixed issue
Have tested on iPhone simulator and real device with Impeller enabled - there was no issues. So I suppose that this issue is related to Impeller with macOS only. Do I need to open new issue or just wait when Impeller with macOS would be stable?

If impeller is breaking texture support on macOS, that would be an impeller bug rather than a video_player issue.

@AlessandroToschi please go ahead and open a PR.

Just another user confirming I'm having the same issue with Video Player on macOS with Impeller and latest stable.
Removing --enable-impeller from flutter run solves the issue for me, but hope to use Impeller when fixed.
@AlessandroToschi, do you have a PR for this? I'd like to follow it.
Flutter 3.24.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 80c2e84975 (2 weeks ago) • 2024-07-30 23:06:49 +0700
Engine • revision b8800d88be
Tools • Dart 3.5.0 • DevTools 2.37.2

Hey there! I was trying to use flutter_webrtc, whenever I used video capture, I'm getting. [ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER> error, @AlessandroToschi if it's fixing our issue, this will be cool solution.
I disabled impeller from macOS it's started work again, so we have issue on impeller on macOS whenever we using external_texture. I hope we can fix this soon

Hey there! I was trying to use flutter_webrtc, whenever I used video capture, I'm getting. [ERROR:flutter/shell/platform/embedder/embedder_external_texture_metal.mm(100)] Could not create external texture:<PHONE_NUMBER> error, @AlessandroToschi if it's fixing our issue, this will be cool solution.
I disabled impeller from macOS it's started work again, so we have issue on impeller on macOS whenever we using external_texture. I hope we can fix this soon

I'm having the same problem.


Create St Aidens C of E Hogh School

@TheGeekNamedHarry Please rename:
lib/domains/uk/sch/lancs/millfield to lib/domains/uk/sch/lancs/millfield.txt
lib/domains/uk/sch/lancs/st-aidans to lib/domains/uk/sch/lancs/st-aidans.txt
Thank you.

@TheGeekNamedHarry You might miss my previous comment. Please react.

@TheGeekNamedHarry Pull request merged. Thank you! However you did not name the file in the request correctly, thus I'll do it for you in about two hours. Please wait at least two hours after this message is sent, before start requesting the licenses at https://jetbrains.com/student.


Use notifications specs from github repo

Use notifications specs from github repo to avoid duplicate files in each workflow specs

@rgolangh in the MTA props, I do not see where you set the URL for the notification, is it missing?

/hold Do not merge until notification plugin is made a dynamic plugin: the PR uses the specs from release 1.0.3 (https://github.com/janus-idp/backstage-plugins/releases/tag/%40janus-idp%2Fplugin-notifications-backend%401.0.3)
Also maybe waits for https://issues.redhat.com/browse/FLPATH-878 as it fixes bugs with arrays and the specs contains arrays (for actions and targetUsers for instance)

@gabriel-farache pls rebase.

@rgolangh in the MTA props, I do not see where you set the URL for the notification, is it missing?

I think there's was a url in the openapi spec

So I still think we need a property for MTA for notification endpoint , because the default in the openapi spec
is localhost:7007
@gabriel-farache  Can you please add quarkus.rest-client.notifications.url=${BACKSTAGE_NOTIFICATIONS_URL:http://orchestrator-backstage.orchestrator/api/notifications/} to the application props of mta?

we would need to add , for e2e , an env variable to point at the e2e endpoint, similar to
https://github.com/parodos-dev/serverless-workflows/blob/37054d2ff27d83fffa600475e77eca7f11c41e27/.github/workflows/mta-e2e.yaml#L103

we would need to add , for e2e , an env variable to point at the e2e endpoint, similar to

@rgolangh or a kubectl patch to the props
kubectl patch configmap/m2k-props \
            --type merge \
            -p '{"data":{"move2kube_url": "http://move2kube-svc.default.svc.cluster.local:8080", "quarkus.rest-client.move2kube_yaml.url": "http://move2kube-svc.default.svc.cluster.local:8080", "broker_url": "http://broker-ingress.knative-eventing.svc.cluster.local/default/default", "quarkus.rest-client.notifications_yaml.url": "http://janus-idp-workflows-backstage.default.svc.cluster.local:7007/api/notifications/"}}'

But then a pod restart is required

So I still think we need a property for MTA for notification endpoint , because the default in the openapi spec
is localhost:7007
@gabriel-farache Can you please add quarkus.rest-client.notifications.url=${BACKSTAGE_NOTIFICATIONS_URL:http://orchestrator-backstage.orchestrator/api/notifications/} to the application props of mta?

we would need to add , for e2e , an env variable to point at the e2e endpoint, similar to

@rgolangh  done :)

/unhold

https://github.com/apache/incubator-kie-kogito-runtimes/pull/3377 is merged so sonataflow should have the openapi generator version that includes the fix in tomorrow's nightly

@gabriel-farache some of the changes were pushed in a previously merged PR. Please rebase.

@masayag done


analogue of sqlite3 error/warning log

https://www.sqlite.org/errlog.html

We are using logging, so someone can override that, if they wish, right?

I see no evidence of an analogue of this feature, nor of integration between the sqlite3 error log and any putative bayeslite error log (which would rely on #92 anyway, I think).

My mistake. bdbcontrib uses logging, but bayeslite doesn't. It would be a good idea to use python's logging library for messages to the user, in part to separate info from warning from error, and in part because then the api becomes easily overrideable with callbacks like this proposed one. git grep finds 250 instances of print, so although it's annoying, it's probably feasible to go through them and decide on a logging method to use for each one.

Every use of print right now is either (a) a bug, (b) in a comment/docstring, or (c) under external/ or in setup.py &c. and not relevant.  No part of the bayeslite API should do I/O outside the bdb file on request.
  This is another bug that would go away with apsw (#92).)
I'm suspicious of using the Python logging module: on first glance its design seems rather overengineered to me, and its implementation apparently involves a great deal of code to talk to the internet.  It also seems to me that it should be up to the user of the bayeslite API to direct where its logs go, rather than up to bayeslite to mix it with the application's log messages -- but I'm not familiar enough with the logging module to assess this critically.

Logging module does allow users to specify on a per-module basis where logs should go (if anywhere). Going through the api is great -- sorry that I didn't find the right thing to look for. What is it? In any case, even api results should be differentiated along the lines of result, info, warn, error, etc. The logging module is pretty standard and easy to override, but I think whatever we use, as long as we package it in a module (like bdbcontrib/src/logging.py) then the user can override it.

I don't understand the question about 'going through the API' -- can you clarify?
When I said 'No part of the bayeslite API should do I/O outside the bdb file on request', I meant that if any bayeslite.bayesdb_...()' call or bdb.method()` call has the effect of I/O -- other than due to, e.g., user-defined SQL functions, or due to reading a CSV file, or on the bdb file in question -- it's a bug.
When I said 'it should be up to the user of the bayeslite API to direct where its logs go', I meant to suggest an analogue of the sqlite3_config(SQLITE_CONFIG_LOG, callback, arg) call in the sqlite3 C API -- say, bdb.set_error_hook(callback).  A user might write a callback that goes through Python's centralized logging scheme.

We can now use the sqlite3 error log, since #92 is closed.  There's a snag: it's process-global, not per-database.  Maybe that's OK, but it's irritating.


AzCli support for checkpoint operations and added deleteFromHost flag for VM delete

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please add test for the new added commands

Added test cases for newly added scenarios


doesn't support control flow ops:

System information

OS Platform and Distribution (MAC 10.15.3 (19D76)):
TensorFlow installed from (binary):
TensorFlow version (1.15.0):

Provide the text output from tflite_convert
# Copy and paste here

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem.
If including tracebacks, please include the full traceback. Large logs and files
should be attached.
2020-02-22 01:14:04.085039: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-02-22 01:14:04.094983: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fa5fe943ce0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-02-22 01:14:04.094997: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
WARNING:tensorflow:From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/python/convert_saved_model.py:60: load (from tensorflow.python.saved_model.loader_impl) is deprecated and will be removed in a future version.
Instructions for updating:
This function will only be available through the v1 compatibility library as tf.compat.v1.saved_model.loader.load or tf.compat.v1.saved_model.load. There will be a new function for importing SavedModels in Tensorflow 2.0.
W0222 01:14:04.095364<PHONE_NUMBER> deprecation.py:323] From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/python/convert_saved_model.py:60: load (from tensorflow.python.saved_model.loader_impl) is deprecated and will be removed in a future version.
Instructions for updating:
This function will only be available through the v1 compatibility library as tf.compat.v1.saved_model.loader.load or tf.compat.v1.saved_model.load. There will be a new function for importing SavedModels in Tensorflow 2.0.
INFO:tensorflow:Restoring parameters from ./model/variables/variables
I0222 01:14:04.311928<PHONE_NUMBER> saver.py:1284] Restoring parameters from ./model/variables/variables
INFO:tensorflow:The given SavedModel MetaGraphDef contains SignatureDefs with the following keys: {'serving_default'}
I0222 01:14:04.437039<PHONE_NUMBER> convert_saved_model.py:80] The given SavedModel MetaGraphDef contains SignatureDefs with the following keys: {'serving_default'}
INFO:tensorflow:input tensors info:
I0222 01:14:04.437269<PHONE_NUMBER> convert_saved_model.py:99] input tensors info:
INFO:tensorflow:Tensor's key in saved_model's tensor_map: word_ids
I0222 01:14:04.437363<PHONE_NUMBER> convert_saved_model.py:41] Tensor's key in saved_model's tensor_map: word_ids
INFO:tensorflow: tensor name: word_ids:0, shape: (-1, 64), type: DT_INT32
I0222 01:14:04.437431<PHONE_NUMBER> convert_saved_model.py:43]  tensor name: word_ids:0, shape: (-1, 64), type: DT_INT32
INFO:tensorflow:Tensor's key in saved_model's tensor_map: labels
I0222 01:14:04.437486<PHONE_NUMBER> convert_saved_model.py:41] Tensor's key in saved_model's tensor_map: labels
INFO:tensorflow: tensor name: labels:0, shape: (-1, 64), type: DT_INT32
I0222 01:14:04.437530<PHONE_NUMBER> convert_saved_model.py:43]  tensor name: labels:0, shape: (-1, 64), type: DT_INT32
INFO:tensorflow:Tensor's key in saved_model's tensor_map: sequence_lengths
I0222 01:14:04.437580<PHONE_NUMBER> convert_saved_model.py:41] Tensor's key in saved_model's tensor_map: sequence_lengths
INFO:tensorflow: tensor name: sequence_lengths:0, shape: (-1), type: DT_INT32
I0222 01:14:04.437623<PHONE_NUMBER> convert_saved_model.py:43]  tensor name: sequence_lengths:0, shape: (-1), type: DT_INT32
INFO:tensorflow:output tensors info:
I0222 01:14:04.437661<PHONE_NUMBER> convert_saved_model.py:101] output tensors info:
INFO:tensorflow:Tensor's key in saved_model's tensor_map: labels_softmax_
I0222 01:14:04.437716<PHONE_NUMBER> convert_saved_model.py:41] Tensor's key in saved_model's tensor_map: labels_softmax_
INFO:tensorflow: tensor name: Cast:0, shape: (-1, -1), type: DT_INT32
I0222 01:14:04.437761<PHONE_NUMBER> convert_saved_model.py:43]  tensor name: Cast:0, shape: (-1, -1), type: DT_INT32
INFO:tensorflow:Restoring parameters from ./model/variables/variables
I0222 01:14:04.642255<PHONE_NUMBER> saver.py:1284] Restoring parameters from ./model/variables/variables
2020-02-22 01:14:04.806073: I tensorflow/core/grappler/devices.cc:60] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA support)
2020-02-22 01:14:04.806140: I tensorflow/core/grappler/clusters/single_machine.cc:356] Starting new session
2020-02-22 01:14:04.847576: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:786] Optimization results for grappler item: graph_to_optimize
2020-02-22 01:14:04.847595: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:788]   function_optimizer: function_optimizer did nothing. time = 0.003ms.
2020-02-22 01:14:04.847599: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:788]   function_optimizer: function_optimizer did nothing. time = 0ms.
WARNING:tensorflow:From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/python/util.py:249: convert_variables_to_constants (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.compat.v1.graph_util.convert_variables_to_constants
W0222 01:14:04.920840<PHONE_NUMBER> deprecation.py:323] From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/python/util.py:249: convert_variables_to_constants (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.compat.v1.graph_util.convert_variables_to_constants
WARNING:tensorflow:From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/python/framework/graph_util_impl.py:277: extract_sub_graph (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.compat.v1.graph_util.extract_sub_graph
W0222 01:14:04.921000<PHONE_NUMBER> deprecation.py:323] From /Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/python/framework/graph_util_impl.py:277: extract_sub_graph (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.compat.v1.graph_util.extract_sub_graph
INFO:tensorflow:Froze 8 variables.
I0222 01:14:04.977573<PHONE_NUMBER> graph_util_impl.py:334] Froze 8 variables.
INFO:tensorflow:Converted 8 variables to const ops.
 Therefore, cannot resolve as constant. Set "seed" or "seed2" attr non-zero to fix this
2020-02-22 01:14:07.416732: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 1: 152 operators, 242 arrays (0 quantized)
2020-02-22 01:14:07.417601: W tensorflow/lite/toco/graph_transformations/resolve_constant_random_uniform.cc:88] RandomUniform op outputting "dropout_1/random_uniform/RandomUniform" is truly random (using /dev/random system entropy). Therefore, cannot resolve as constant. Set "seed" or "seed2" attr non-zero to fix this
2020-02-22 01:14:07.418410: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 2: 151 operators, 241 arrays (0 quantized)
2020-02-22 01:14:07.418796: W tensorflow/lite/toco/graph_transformations/resolve_constant_random_uniform.cc:88] RandomUniform op outputting "dropout_1/random_uniform/RandomUniform" is truly random (using /dev/random system entropy). Therefore, cannot resolve as constant. Set "seed" or "seed2" attr non-zero to fix this
2020-02-22 01:14:07.419965: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 3: 150 operators, 239 arrays (0 quantized)
2020-02-22 01:14:07.420736: W tensorflow/lite/toco/graph_transformations/resolve_constant_random_uniform.cc:88] RandomUniform op outputting "dropout_1/random_uniform/RandomUniform" is truly random (using /dev/random system entropy). Therefore, cannot resolve as constant. Set "seed" or "seed2" attr non-zero to fix this
2020-02-22 01:14:07.421508: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Group bidirectional sequence lstm/rnn: 150 operators, 239 arrays (0 quantized)
2020-02-22 01:14:07.422579: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before dequantization graph transformations: 150 operators, 239 arrays (0 quantized)
2020-02-22 01:14:07.424002: I tensorflow/lite/toco/allocate_transient_arrays.cc:345] Total transient array allocated size: 231040 bytes, theoretical optimal value: 231040 bytes.
2020-02-22 01:14:07.424390: I tensorflow/lite/toco/toco_tooling.cc:454] Number of parameters: 3808024
2020-02-22 01:14:07.424903: E tensorflow/lite/toco/toco_tooling.cc:481] We are continually in the process of adding support to TensorFlow Lite for more ops. It would be helpful if you could inform us of how this conversion went by opening a github issue at https://github.com/tensorflow/tensorflow/issues/new?template=40-tflite-op-request.md
and pasting the following:
TensorFlow Lite currently doesn't support control flow ops: Enter, Exit, Merge, Switch. We are working on supporting control flow ops, please see github issue at https://github.com/tensorflow/tensorflow/issues/28485. Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, ARG_MAX, CAST, CONCATENATION, FULLY_CONNECTED, GATHER, GREATER_EQUAL, LESS, LOGICAL_AND, LOGISTIC, MAXIMUM, MINIMUM, MUL, PACK, RANGE, REDUCE_MAX, RESHAPE, REVERSE_SEQUENCE, SELECT, SHAPE, SPLIT, STRIDED_SLICE, TANH, TRANSPOSE. Here is a list of operators for which you will need custom implementations: LoopCond, RandomUniform, TensorArrayGatherV3, TensorArrayReadV3, TensorArrayScatterV3, TensorArraySizeV3, TensorArrayV3, TensorArrayWriteV3.
Traceback (most recent call last):
File "/Users/lidayuan/opt/anaconda3/envs/py371/bin/toco_from_protos", line 8, in
sys.exit(main())
File "/Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 89, in main
app.run(main=execute, argv=[sys.argv[0]] + unparsed)
File "/Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "/Users/lidayuan/opt/anaconda3/envs/py371/lib/python3.7/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 52, in execute
enable_mlir_converter)
Exception: We are continually in the process of adding support to TensorFlow Lite for more ops. It would be helpful if you could inform us of how this conversion went by opening a github issue at https://github.com/tensorflow/tensorflow/issues/new?template=40-tflite-op-request.md
and pasting the following:
TensorFlow Lite currently doesn't support control flow ops: Enter, Exit, Merge, Switch. We are working on supporting control flow ops, please see github issue at https://github.com/tensorflow/tensorflow/issues/28485. Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, ARG_MAX, CAST, CONCATENATION, FULLY_CONNECTED, GATHER, GREATER_EQUAL, LESS, LOGICAL_AND, LOGISTIC, MAXIMUM, MINIMUM, MUL, PACK, RANGE, REDUCE_MAX, RESHAPE, REVERSE_SEQUENCE, SELECT, SHAPE, SPLIT, STRIDED_SLICE, TANH, TRANSPOSE. Here is a list of operators for which you will need custom implementations: LoopCond, RandomUniform, TensorArrayGatherV3, TensorArrayReadV3, TensorArrayScatterV3, TensorArraySizeV3, TensorArrayV3, TensorArrayWriteV3.

@yuanlida
Supporting control flow ops is a work in progress.
See #28485


Implicit pyramids will cause AttributeError in add_image(channel_axis=...)

🐛 Bug
as @jni pointed out here https://github.com/napari/napari/pull/1092#discussion_r404757426, we have a bug in Viewer.add_image():  If the user passes an implicit pyramid (a list of arrays withouth explicitly using is_pyramid=True) and tries to use channel_axis != None, then there will be an AttributeError here, since a list does not have .shape:
https://github.com/napari/napari/blob/871825e9ca9f570575e0681132d638e03cb39708/napari/components/add_layers_mixin.py#L227
(note, the syntax of of that line changed in #1092, but the potential error was always there).

😞 any ideas on how we should fix this? this part of the api has always been prone to a little confusion. there was a time where we had a separate add_pyramid method but so much code was duplicated and it was unclear how to achieve parity with the labels layer. add_pyramid_labels felt like a bit much


Doesn't work at all

I required the package with composer, but it's not working at all for me.
If I add "Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class" to my config/app.php providers array, php artisan always gives me a FatalErrorException "Class 'Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class' not found".
If I remove the "::class" from the service provider, php artisan ide-helper:generate creates a _ide_helper.php in the root directory of my project, and it also looks fine, but PhpStorm doesn't seem to make any use of it. Auto-completion doesn't work and all the facades used by my app show up as warnings / errors inside PhpStorm.
PhpStorm also doesn't seem to be able to resolve vendor namespaces (e.g. in \Illuminate\Support\Facades\App the "Facades" show up in red, a tooltip says "Undefined namespace Facades", and additionally "App" show up with a yellowish background, a tooltip says "Undefined class App").
I'm using Laravel 5.0.33 with PHP 5.6.9 and PhpStorm 9.0. I'd be very grateful if someone could help.

Of you use the class notation, don't use quotes around it.
Did you index your vendor folder also?

@barryvdh I believe you should close issues after certain time period when we don't receive any input. They clutter issue-base and are hard to manage really. Wasting time going over useless issues really.

@barryvdh also one of this old "serviceprovider registration" problems => I vote for closing :}


test: migrate rust_version and rustc* to snapbox

What does this PR try to resolve?
Part of https://github.com/rust-lang/cargo/issues/14039.
Migrate following to snapbox:

tests/testsuite/rust_version.rs
tests/testsuite/rustc.rs
tests/testsuite/rustc_info_cache.rs

Looks great. Thank you for the migration.
@bors r+

:pushpin: Commit f51a580e51dab2c85224afb5a0eb83394b463a61 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit f51a580e51dab2c85224afb5a0eb83394b463a61 with merge a515d463427b3912ec0365d106791f88c1c14e1b...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing a515d463427b3912ec0365d106791f88c1c14e1b to master...


Update set-up-phone-system-voicemail.md

Fixed typo Cloud-only environments: Set up Cloud Voicemail for Cloud Phone System Users

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

topic already updated. closing.


Installation error with clang in Mac M1

Preliminaries

[x] I have followed the latest version of the
installation instructions.
[x] I have checked the troubleshooting page and my problem is either not mentioned there,
or the solution given there does not help.

Description of error
The error shows me a error because of manimpango, I've installed as in Manim Community Documentation, with all the dependencies and so on. But the problem comes once I run the command brew install manim.
Installation logs
> pip3 install manim
clang: error: no such file or directory: 'manimpango/cmanimpango.c'
clang: error: no input files
error: command '/usr/bin/clang' failed with exit code 1
note: This error originates from a subprocess, and is likely not a problem with pip.

ERROR: Failed building wheel for manimpango
Failed to build manimpango
ERROR: Could not build wheels for manimpango, which is required to install pyproject.toml-based projects

System specifications
# OS
macOS Monterey
# RAM
8 GB
# Python version
> python3 --version
Python 3.10.7

FFMPEG
Output of ffmpeg -version:
ffmpeg version 5.1.2 Copyright (c) 2000-2022 the FFmpeg developers
built with Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)

Additional comments
My clang output:
> clang --version
Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Seems like your system is trying to build manimpango locally, in this case you need the build dependencies mentioned here -- in particular, run pip3 install Cython before trying to run pip3 install manimpango again.

Yep it work, thanks. I suggest that this should be set in the community documentation as a comment


Make DocValuesIterator public [LUCENE-9203]

By doing this, we improve extensibility for new formats. Additionally this will improve coherence with the public method already existent in the class.

Migrated from LUCENE-9203 by juan camilo rodriguez duran, updated Jun 22 2021
Parent: #10276
Linked issues:

#10123

Closing.


CommentStream Comments not loaded

Trying to iterate replies to a comment yields nothing.
IEnumerable<Comment> comments = subreddit.CommentStream.Where(c => c.Comments.All(x => x.AuthorName != redditName));
In this case, no items should be returned when redditName has replied, but it still returns the comment object and drilling into comment.Comments yields no results.

I know you'd hardly ever expect to want to drill into the replies of something in a stream, but it should still be there.
You could get the full qualified comment like this
Comment qualifiedComment = reddit.GetComment(new Uri(comment.Shortlink)); but that seems a bit annoying to have to instantiate an entire new request.

What version of redditsharp are you using?

1.1.12

If I'm understanding this correctly, using a comment stream is going to be returning new comments as they come in. That means that by default, they wouldn't have any replies to them so it would always satisfy your Where expression.

In my use case: https://github.com/Bitz/BookHorseBot/blob/master/BookHorseBot/Program.cs#L42
IEnumerable<Comment> commentStream = subreddit.CommentStream.Where(c.CreatedUTC >= DateTime.UtcNow.AddMinutes(-15));

I am using a CreatedDate Threshold as well- so as to pick up older records.  Which works fine. But as it stands, it runs under the assumption that there /should/ be no replies vs actually doing a check.

I might need to look into this a little more, but I think what is happening is that your listing stream is returning comments as they come in, but then delaying it actually processing for 15 minutes. That does mean that the comment has already been retrieved from the API and you'd need to make an additional call to get any new replies to that comment underneath.

Since this is being redone in 2.0 with observables, I'm going to go ahead and close this issue. What is happening is the comment is fetched immediately, but then delayed in being returned to your object until later when it may have replies. It is working as intended as far as I can tell.


[MM-10813] Design update for Post attachments

Summary
Updates visual treatment of Post attachments (images, documents, videos, etc).
Ticket Link

Jira ticket (with visual design guidance)
Fixes https://github.com/mattermost/mattermost-server/issues/12841

Checklist

[x] Added or updated unit tests (required for all new features)
[x] Has UI changes

Device Information
This PR was tested on:

Android 9 (OnePlus 5 device)
iPhone X and iPhone 7 (simulators)

Screenshots

Mixed Attachments
Documents + Image
Overflow & Icons

Open Items

[ ] Text attachments (extension .txt) get treated as 'code' attachments by Mattermost. Should this continue?
[ ] Patch attachments (extension .patch) require updated icon to match the other new icons. Or, a decision to start treating patch attachments as 'code' attachments across Mattermost.

File attachment categories in Mattermost are defined here.

for QA
Android apk: https://releases.mattermost.com/mattermost-mobile-pr/build-pr-3511/Mattermost_Beta.apk
iOS ipa: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/build-pr-3511/Mattermost_Beta.plist

@chuttam I haven't looked at it yet but you have build failures, I believe you need to update the snapshots

@chuttam I haven't looked at it yet but you have build failures, I believe you need to update the snapshots

Yup. PR review changes are a work-in-progress, but will be sure to keep the snaps up-to-date as I knock through the feedback items piece-by-piece. Will ping here when PR is ready for re-review.

@enahum @migbot Back to you for Dev Review.
There is still one dev item and a few design questions left open, but I figured these needn't hold up Dev Re-Review.

@chuttam let me know what design questions you have?I'd be happy to answer them before completing my review.

@chuttam let me know what design questions you have? I'd be happy to answer them before completing my review.

You bet, @andrewbrown00 :

More definitive guidance to this background color question for showing the "+n" more images overlay, across different themes.

Text attachments (extension .txt) currently get treated as 'code' in Mattermost. Should this continue?

Patch attachments (extension .patch) require updated icon to match the other new icons. Or, a decision to start treating patch attachments as 'code' attachment or 'text' attachment across Mattermost.

More conversation around items (2) and (3) is here. See here for how Mattermost currently determines what icon/treatment to use for different file type extensions across all clients.

@chuttam thanks for the quick reply, feedback below:

I added my reply to the background color.
From a UX perspective .txt or .rtf files should use the text icon and other code types (.css .html .json etc.) should use the code icon.
I added a new icon for the patch file, it is available in the Invision file.

Let me know if you have any other questions. Looking forward to doing a review on this 😄

@chuttam  I'll have another look to the PR while you can use the comments added by @andrewbrown00 to update it accordingly ;)

[x] New PR in mattermost-redux to treat .txt and .rtf files as text files.
[x] Added new patch icon to PR.

At this point, no open design issues for this PR.

@chumbalum Redux PR is merged, you can update the commit hash in package.json and package-lock.json to c443a33c38febdfd5b90cdd054086f06fc5a8697

Bumping mattermost-redux SHA is blocked by this new issue that I'm looking into also. The problem only prevents us from seeing the new text attachment icon, so not a big blocker for this PR.

@chuttam here's a screenshot in reference to my last comment in Invision.
Assets are in the bottom right of the panel

@andrewbrown00 Here's what the image preview flow looks like with the new icons now. As you can see the black text icon (image 3 of 5 in the video below) gets completely washed out. At the moment, the "lightbox" is black, regardless of theme.

Adding a tint to icons (even conditionally) would color them all the same. Any thoughts to not having a black icon for "text" file attachments, assuming that's even an option?

What about removing other fileTypes from the gallery?

@enahum Yup, this could be a solution. However, an initial entry down this solution earlier (to resolve the attachment list "lookback" logic for correct attachment index) showed that we'd be removing the only way to download non-image attachments (via the 3-dot button). Can you confirm?
Meanwhile, I'll take another look at this now, given that my initial investigation was amongst a number of other refactorings and PR review changes that occupied my attention.

@chuttam I can confirm that is not going to be a problem as they cannot be currently downloaded. They can however be opened and then saved using the ios viewer or a third party app on android

@chuttan the only files that are downloadable are images and videos, so in the gallery we can show just images and videos and remove every other file type

@chuttan the only files that are downloadable are images and videos, so in the gallery we can show just images and videos and remove every other file type

Sounds good. I'm working on implementing this now.

@enahum Hmm... according to the new design, videos are not treated the same as images, and so fall into the 'non-images' treatment, which means no gallery for videos. Will this be an issue?

@chumbalum yes, that will be an issue, we should have images and videos in the gallery.

Understood. This effectively means that the option of removing other fileTypes from the gallery isn't straightforward and will require more time from me than available (before Monday's code stop) to get in hands of reviewers and testers. Unfortunately, I have low availability over the next 10-15 days, and someone else may have to pick this one up, if deemed important enough.
Options:
a) change text icon colour from black to perhaps the same blue as most of the other attachment icons. Existing app functionality continues and PR is ready for review.
b) take the extra time to remove non-images and non-videos from existing gallery functionality.
I do see a better way to handle the entire image gallery treatment going forward, but I'm unsure if this effort fell within the scope of MM-10813. My default thinking with this current PR was to leave pre-existing functionality (i.e. gallery) as untouched as possible.

@chuttam it sounds like it maybe be faster to swap out the color for the text icon that will translate across all themes. Can we use v(center-channel-color-20)?

@chuttam it sounds like it maybe be faster to swap out the color for the text icon that will translate across all themes. Can we use v(center-channel-color-20)?

Can do. What do you think about changing the color of the icon asset itself, to be the desired color? I say this because we don't have logic (at the moment) to selectively apply tints to individual assets (e.g. just the text icon), and this piece would have to be built/tested too. That said, I may be missing something obvious here.

Ok so I've managed to remove the docs files from the gallery, but videos are still shown, made it so gifs are part of the images, the file types icons now have the centerChannelColor, fixed the margins on ProgressiveImage and it should be good to go.

Test builds
Android and iOS

+1, this looks really good (mentioned one minor bug to EN). Approving for QA to review

Tested by PM and UX, reviews completed


Workout metadata missing.

Describe the bug
When I use HealthKitReporter.workoutQuery(predicate) to retrieve workout data, harmonized.metadata always returns null.
To Reproduce
try {       final workouts = await HealthKitReporter.workoutQuery(predicate);       workouts.forEach((element) {         print('metadata: ${element.harmonized.metadata}');       });     } catch (e) {       print(e);     }
Expected behavior
The metadata should look like this:
{HKAverageMETs: 4.85739 kcal/hr·kg, HKIndoorWorkout: 0, HKWeatherTemperature: 52.016 degF, HKWeatherHumidity: 7600 %, HKTimeZone: Asia/Shanghai, HKElevationAscended: 2403 cm}
Additional context
I think the reason might be that there's something wrong with Metadata.make()in the native code.

Hoping for this fix.. need elevation gain  for my existing project

I have solution....for workout. i can use substrac 1 seconds for startDate and add 1 seconds for endDate.!
Regards!


Add fastq download notebook

Closes #44

I left some comments via the ReviewNB.com website (very cool!), let me know if you have any trouble seeing/interpreting it.


fix: ensure branch permissions enforced for administrator

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

GitHub release
v1.1.3

Your semantic-release bot :package::rocket:


coreboot 24.05 and 24.02.01 are running out of disk space

When building the docker containers, the builds fail because of low disk space.
One quick solution would be to delete the coreboot toolchains after they are copied into the container.

I guess it is ok for now

Still an issue, see dagger run on main for coreboot_24.02.01 and for coreboot_24.05.
INFO: HTTP Request: POST http://<IP_ADDRESS>:35433/query "HTTP/1.1 200 OK"
INFO: services/coreboot_24.02.01: PUBLISHING
INFO: HTTP Request: POST http://<IP_ADDRESS>:35433/query "HTTP/1.1 200 OK"
INFO: HTTP Request: POST http://<IP_ADDRESS>:35433/query "HTTP/1.1 200 OK"
36  :   Container.sync DONE [3m7.9s]
39  :   Container.publish(address: "ghcr.io/9elements/firmware-action/coreboot_24.02.01:5e01648", platformVariants: [xxh3:e006f3903ca162a7]): String!
40  :     export layers
INFO: HTTP Request: POST http://<IP_ADDRESS>:35433/query "HTTP/1.1 200 OK"
ERROR: resolve: failed to export: mount callback failed on /tmp/containerd-mount4096659824: mount callback failed on /tmp/containerd-mount1008008140: failed to write compressed diff: failed to create diff tar stream: failed to copy: write /var/lib/dagger/worker/content/ingest/92b9f89570f5508173f1633800715bd0e9924ddc2687930da3dc5ea9e3392450/data: no space left on device
ERROR: Failed services/coreboot_24.02.01 in publish stage, error message: None
+----------------------------+-------------+-------------+------------+---------+
|         container          | build amd64 | build arm64 | test amd64 | publish |
+----------------------------+-------------+-------------+------------+---------+
| services/coreboot_24.02.01 |      OK     |      OK     |     OK     |   fail  |
+----------------------------+-------------+-------------+------------+---------+

seems that #414 fixed it shomehow


Make loss scale a gunpowder volume

Currently, the loss scale is computed inside the caffe.Train node. To have better control over it, and to include it in snapshots, error scale should be a new VolumeType LOSS_SCALE.

Done in 9ca07bf0f8b3c416d5dcfbb7f490a1226a6c0943.


Roll Engine from 45bedbe84123 to edf98eea8a57 (2 revisions)

https://github.com/flutter/engine/compare/45bedbe84123...edf98eea8a57
2022-04-05<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from PmeDIogNb... to TnyjEJbo_... (flutter/engine#32436)
2022-04-05<EMAIL_ADDRESS>assertion failure on empty indices in ui.Vertices constructor (flutter/engine#32434)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PmeDIogNbRLw to TnyjEJbo_AZe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


unknown error: Chrome failed to start: crashed

Hi, Jciolek
When I ran shell "sh ./protractor.sh protractor-conf.js", some errors threw.
protractor-conf.js is the default file in angular.io (v1.6.1),
but it works well when I run "protactor protactor-conf.js" on my host machine directly.
[04:03:01] I/direct - Using ChromeDriver directly... [04:03:01] I/launcher - Running 1 instances of WebDriver [04:04:01] E/launcher - unknown error: Chrome failed to start: crashed   (Driver info: chromedriver=2.27.440175 (9bc1d90b8bfa4dd181fbbf769a5eb5e575574320),platform=Linux 4.9.13-moby x86_64) [04:04:01] E/launcher - WebDriverError: unknown error: Chrome failed to start: crashed   (Driver info: chromedriver=2.27.440175 (9bc1d90b8bfa4dd181fbbf769a5eb5e575574320),platform=Linux 4.9.13-moby x86_64)     at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)     at Object.checkLegacyResponse (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:639:15)     at parseHttpResponse (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/http/index.js:538:13)     at client_.send.then.response (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/http/index.js:472:11)     at ManagedPromise.invokeCallback_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:1379:14)     at TaskQueue.execute_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2913:14)     at TaskQueue.executeNext_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2896:21)     at asyncRun (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2820:25)     at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:639:7     at process._tickCallback (internal/process/next_tick.js:103:7) From: Task: WebDriver.createSession()     at Function.createSession (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver.js:329:24)     at Driver (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/chrome.js:778:38)     at Direct.getNewDriver (/usr/local/lib/node_modules/protractor/built/driverProviders/direct.js:70:26)     at Runner.createBrowser (/usr/local/lib/node_modules/protractor/built/runner.js:198:43)     at /usr/local/lib/node_modules/protractor/built/runner.js:277:30     at _fulfilled (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:834:54)     at self.promiseDispatch.done (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:863:30)     at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:796:13)     at /usr/local/lib/node_modules/protractor/node_modules/q/q.js:556:49     at runSingle (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:137:13) [04:04:01] E/launcher - Process exited with error code 199

I remove protractor.sh from angular.io, now spec runs, but new exception threw.
[18:30:01] E/protractor - Could not find Angular on page http://localhost:8000/e2e/fixtures/anchor-scroll/ : retries looking for angular exceeded
F[18:30:11] E/protractor - Could not find Angular on page http://localhost:8000/e2e/fixtures/anchor-scroll-y-offset/ : retries looking for angular exceeded
F[18:30:21] E/protractor - Could not find Angular on page http://localhost:8000/e2e/fixtures/anchor-scroll-y-offset/ : retries looking for angular exceeded

I run the docker container successfully on my macbook host machine, but it doesn't work on CentOS...still reports
E/launcher - unknown error: Chrome failed to start: crashed

Hey here.
We got the same pbm on a debian 8!
[22:41:51] I/launcher - Running 1 instances of WebDriver
[22:42:51] E/launcher - unknown error: Chrome failed to start: crashed
  (Driver info: chromedriver=2.27.440175 (9bc1d90b8bfa4dd181fbbf769a5eb5e575574320),platform=Linux 3.16.0-4-amd64 x86_64)
[22:42:51] E/launcher - WebDriverError: unknown error: Chrome failed to start: crashed
  (Driver info: chromedriver=2.27.440175 (9bc1d90b8bfa4dd181fbbf769a5eb5e575574320),platform=Linux 3.16.0-4-amd64 x86_64)
    at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)
    at Object.checkLegacyResponse (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:639:15)
    at parseHttpResponse (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/http/index.js:538:13)
    at client_.send.then.response (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/http/index.js:472:11)
    at ManagedPromise.invokeCallback_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:1379:14)
    at TaskQueue.execute_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2913:14)
    at TaskQueue.executeNext_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2896:21)
    at asyncRun (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2820:25)
    at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:639:7
    at process._tickCallback (internal/process/next_tick.js:103:7)
From: Task: WebDriver.createSession()
    at Function.createSession (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver.js:329:24)
    at Driver (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/chrome.js:778:38)
    at Direct.getNewDriver (/usr/local/lib/node_modules/protractor/built/driverProviders/direct.js:70:26)
    at Runner.createBrowser (/usr/local/lib/node_modules/protractor/built/runner.js:198:43)
    at /usr/local/lib/node_modules/protractor/built/runner.js:277:30
    at _fulfilled (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:796:13)
    at /usr/local/lib/node_modules/protractor/node_modules/q/q.js:556:49
    at runSingle (/usr/local/lib/node_modules/protractor/node_modules/q/q.js:137:13)
[22:42:51] E/launcher - Process exited with error code 199

Hey guys,
Does this problem persist on the latest image?

Has anyone resolved the issue?

Thanks @sorx00
I guess I can close this now.

Actually, I've used native selenium + headless chrome to write an AT framework for angular.


feature(ui-ux): added get private key feature

What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

We're currently processing your upload.  This comment will be updated when the results are available.

LGTM, just the lint issue to fix


Ability to skip dereferencing inline/internal $ref values #214

Add new option to skip the internal references while parsing the document
This pull request fix the issue: https://github.com/APIDevTools/json-schema-ref-parser/issues/214

I'm struggling to see the use case here. So far in #214 it looked like one persons problems were solved with using bundling, then another person was simply using $ref incorrectly (entirely understandable, we've all done it).
Perhaps this is worth merging just for the sake of feature parity with the stoplight tool?
If so, can we document better?
What does skip internal mean? If it means "only replace $ref for external files but keep $ref for internal files" that kinda sounds like bundling? Maybe I've been away from my computer for too long or something. Please help me understand what we're trying to do.

Hello @philsturgeon,
thanks for reviewing this pull request.
You are right to be confused about this issue because it makes the bundling working in a different way, but let me explain you a bit of background.
In my company we created several OpenAPI files using the references in a different way than the official one and we were using a different library bundle them.
The previous library is not supported anymore, so I decided to modify our project to this library to bundle the files because it looks well done and maintained.
The references that this library expect are structured like this:

The reference that I'm using in my company are like this:

Both approaches have advantages and disadvantages.
For example, the second approach allows you to create links only one layer deep and centralize the versions in a single file (the root). In this way, if a new version of a shared object is released, you need to change it in only one place.
In this example, if you want to migrate to obj3.v4 you need to change it only once.
Another advantage is that you can share parts of an object between apis. In this example, if two apis wants to share the same obj1 but a different implementation of obj3 they can do it without duplicating the file obj1.
This can be useful is some situations but annoying in others. If you look at obj1.v1.json alone you are not able to understand its content until you put it inside a complete api.
Anyway, my goal is not to convince you that this alternative method of linking is a valid one, but explain why the option in this pull request is needed.
My team decided to use the second linking approach long time ago and, if possible, I would like to keep it in this way using this library to do the bundling.
How do you suggest me to document this option in github pages? do you want to rename the option value?
Thanks,
Marco

Have you seen this? https://apisyouwonthate.com/blog/json-schema-bundling-finally-formalised/
With $id and new tooling that supports $id in $ref, there is no reason for anyone to work on custom solutions or awkward hacks anymore. We could all just use $id.
This codebase has some plans to support the new hotness in https://github.com/APIDevTools/json-schema-ref-parser/issues/145, which really is a rewrite in the form of https://github.com/APIDevTools/json-schema-reader, but that rewrite has been paused due to life kicking everyone in the face. Experimentation and PRs welcome.

Link updated:
https://json-schema.org/blog/posts/bundling-json-schema-compound-documents


README unclear/unhelpful

I realize the problem is my own inability to do the thing, but I after having built the sln I don't get anything out of it;
I have no idea where I'm supposed to run gluaextract <in> [out] nor what the inputs format are.

I barely got it myself, so I have an answer here: https://github.com/handsomematt/glua-cache-extract/issues/2


onboarding-ops: Global truncation

This PR ...
**- Added OBX-23.1 truncation for CA-DPH.

AOE truncation is taken care of by Jorge's ticket 4197
IL - ORC-21-1 is done with ticket 4019..**

Test Steps:

./gradlew package
run: ./prime data --input junk/ca-dph-test-with-long-obx-23-1-values.csv --input-schema primedatainput/pdi-covid-19 --output-format HL7 --output-dir junk --route

Test File:
ca-dph-test-with-long-obx-23-1-values.csv

You should see the OBX-23-1 truncated as below:

Changes

Include a comprehensive list of changes in this PR
(For web UI changes) Include screenshots/video of changes

Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#issue - List GitHub issues this PR fixes

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
51
1h 25m
28

carlosfelix2
29
11h 50m
64

cwinters-usds
20
3h 56m
7

jimduff-usds
17
11h 32m
19

whytheplatypus
12
1h 48m
18

TomNUSDS
12
1h 23m
27

jbiskie
12
1h 2m
0

kevinhaube
10
53m
0

oslynn
10
1h 4m
5

ahay-agile6
9
3h 54m
5

brick-green-agile6
7
49m
0

JosiahSiegel
5
1h 19m
2

rhood23699
5
47m
0

sethdarragile6
5
37m
0

RickHawesUSDS
4
41m
1

jorg3lopez
4
17h 46m
4

meckila
3
3h 14m
4

TurkeyFried
2
13h 52m
0

jeremy-page
2
8m
0

clediggins-usds
2
8h 59m
1

bgantick
1
1d 19h 37m
1

acoushawk
1
16h 10m
0

snesm
1
16m
0

jh765
1
2h 54m
0

For testing generate a fake CA file as follow:
./prime data --input-fake 5 --input-schema primedatainput/pdi-covid-19 --output junk/ca-dph-test-with-long-obx-23-1-values.csv --target-states CA
Run:  ./prime data --input junk/ca-dph-test-with-long-obx-23-1-values.csv --input-schema primedatainput/pdi-covid-19 --output-format HL7 --output-dir junk --route


Problem: (fix #175) workflow to deploy by merging pr, dev and master …

Solution:
1. Deployment of staging: comment "/RUN" in PR only by limited collaborators i.e tomas and lesile, etc.
2. Deployment of production: only happen when merge to master

let's try it out for staging tmr day time :)

sure but this commit has to be merged before try it out. or I can show it in my own repo?

/RUN

/RUN


[WIP] Add compact method for multi-year

Pull request details
Describe the changes made in this pull request

List of related issues or pull requests
Closes #783
Collaboration confirmation
As a contributor I confirm

[ ] I read and followed the instructions in README.dev.md
[ ] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[ ] Tests are passing
[ ] Lint is passing

@abelsiqueira I'm pushing this draft PR for now just for you to have a look and see if there can be any improvements already. Thank you!
Specifically I have two questions:

We need the extra index for commission_year/investment_year for the parameter. Maybe, if you have time, you can think of how to do this properly.
The new expressions/variables do not seem to be very elegant. Do you have any suggestions there?

Hi @gnawin, it looks like the complexity exists because of the indexes, so I think we have to use DataFrames.
In other words, you have conditionals that make the indexes sparse, so maybe we have to store the indexes in a linearlized fashion. It depends on what you're going to do with it later, but the idea would be to move the indexes for which the variables and/or expressions are defined to dataframes.
Note that investment variables also have sparse indexes, but since they were small and simple, and we were in a rush to implement multi-year, we chose to let them have sparse indexes temporarily. The idea being that they will be moved to table format later.
The same could be done here, but the complexity might build up. It depends on how you need to use these expressions later.


Deprecate ignoring space after literal newline

Robot Framework has a strange quirk that a space character after a literal newline like \n  is ignored. In other words,  this test currently passes:
*** Test Cases ***
Example
    Should Be Equal    two lines\nhere    two lines\n here

The reason for this behavior is that it enabled wrapping long lines after \n when using the HTML format:

Test Case
Keyword
Argument
Argument

Example
Log
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n
INFO

Such wrapping doesn't work with the plain text format, and in general there has never been real benefits from this syntax with the plain text syntax. Now that RF 3.2 won't be supporting HTML anymore (#3081), this strange feature can go as well. We cannot remove it right away, but we can deprecate it in RF 3.2 and remove later.

A problem with deprecation is that handling \n happens in such code where the location where the syntax has been used isn't known. We can easily emit a warning that this syntax is deprecated, but the message won't tell where the problem occurs. The message has a timestamp and comparing it to timestamps in the execution log is possible, but finding exact locations using this approach is likely to be slow.
An easier solution is simply finding \n  usages from the test data. This can be done with an editor/IDE or an external tool like ack or pss. I used the latter with Robot's own tests using this command:
pss -a '\\n [^ ]' atest/robot/

This deprecation will be included in RF 3.2 alpha 1. If it turns out \n  syntax is used widely and finding usages is hard, we can still enhance the deprecation messages before RF 3.2 final. If there are valid use cases for this syntax, we can also consider removing the deprecation.

This quirk also has a quirk that space isn't ignored after \n when using the extended variable syntax. Inconsistency is not good, and an easy way to have consistent behavior it is removing the whole "feature".

I was able to enhance this a bit. Now the deprecation warning has a link to the keyword causing it if this syntax is used in keyword arguments. If it's used in e.g. in documentation, only the message is shown. Also added a reference to this issue to that message. Both changes will be committed shortly.

Sorry for commenting on a closed ticket.
What should be placed instead of the space, if the intent is for there to be a space required?

I guess maybe ${SPACE}?

Yeah, ${SPACE} ought to work.

Hello @pekkaklarck,
After this change I can see that now breaking variables which consist of \n is problematic, as this:
${a}=  Set Variable  two lines\nhere
${b}=  Set Variable  two lines\n
...  here
Should Be Equal  ${a}  ${b}

should PASS but it FAIL because 2 spaces as a separator between ... and next part of variable will be processed as 1 space as a part of variable so instead
two lines
here

we would have
two lines
 here


Nr of links is constant for the REAL generator

Hi Mark
I realize this is not very actively maintained, but recording this here while I'm deep diving into Linkbench a little. Comments on options for fixing this are welcome.
For development purposes, and maybe other reasons, I want to run quicker runs of Linkbench. I can make load phase quicker by loading less data. If I set maxid1 = 10001 I get a smaller nodetable and counttable. However, the load phase then continues to insert 44M records to linktable. This also means there will be on average thousands of links per node, which is probably not a good model of reality.
It appears the default links generator nlinks_func = real isn't configurable at all. Should it be? Maybe is should automatically adapt to maxid1 so that it always generates about 4 links per node?
I can workaround this issue by using another nlinks_func:
nlinks_func = com.facebook.LinkBench.distributions.ZipfDistribution
nlinks_shape = 1.5
nlinks_mean = 2

I have no experience with nlinks_func=real, but not adapting to maxid1 sounds like a bug. I am happy to take a pull request.


Virtual fence ui

This is an initial version with basic functionality. Holding shift and drawing in the map frame creates a virtual fence.

In the future, we would like to add text boxes where the exact dimensions can be added rather than having to draw.
There is currently no way to remove a virtual fence once added without replacing it with another virtual fence.
There are cases where robots move out of the virtual fence in simulation. The most common is when two rovers collide and to avoid the collision they move outside the virtual fence.

It also appears that a bug has been introduced causing rqt to crash if the pop-out map is open when the simulation is ended.

Just a comment, not a change that I need before merge:
Shoud there be a different box displayed for each robot when global frame is not selected?

One last change:

The virtual fence should not persist between simulation runs.


Issue running server.py

[tcp @ 0x7fa5e952a180] Connection to tcp://<IP_ADDRESS>:83 failed: Operation timed out
OpenCV: Couldn't read video stream from file "http://<IP_ADDRESS>:83/SnapshotJPEG?Resolution=640x480&amp;Quality=Clarity&amp;1509566566"
<class 'cv2.error'>

in prediction.py i found the line
cap = cv2.VideoCapture('http://<IP_ADDRESS>:83/SnapshotJPEG?Resolution=640x480&amp;Quality=Clarity&amp;1509566566')

and changed the image location to a valid url but nothing happened. How can I get this to work?

Hi @jacksonkr, apologies for the delay! Please ensure that the URL points to a motion JPEG source.


Broken Link to "Storing Values with the Equal Operator"

Challenge Generate Random Fractions with JavaScript has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
The link to "Storing Values with the Equal Operator" is broken, as that page doesn't seem to exist.  Most likely, it's supposed to link to this page:
https://www.freecodecamp.com/challenges/storing-values-with-the-assignment-operator
Clicking the current link redirects back to the Map page with: "We couldn't find a challenge with the name -storing-values-with-the-equal-operator. Please double check the name."

Yeah, we change the naming of that challenge recently. I believe the href link in this line needs to be changed to
storing-values-with-the-assignment-operator

Hello, I am new here and would like to contribute.
This issue looks like easy to learning. I will take care of it.


Updated description to have the generateAssetMap option

I noticed there's a "generateAssetMap" option on the plugin which isn't documented. I found it by reading the source code and it was very useful to me, so I changed the documentation and am submitting this PR with the relevant changes, it case you want to update the original documentation.

Thanks!


Provides singleton example for producer

Which Issue(s) This PR Fixes

Fixes #539
Brief Description

Provides singleton example for producer.
How Did You Test This Change?

No testing needed.

Codecov Report

Merging #540 (57eb6d6) into master (ef1aea9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #540   +/-   ##
=========================================
  Coverage     45.87%   45.87%
  Complexity      659      659
=========================================
  Files           207      207
  Lines         11491    11491
  Branches       2931     2931
=========================================
  Hits           5272     5272
  Misses         5991     5991
  Partials        228      228

Flag
Coverage Δ

java
62.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM


ci(Mergify): configuration update

This change has been made by @reveurguy from https://mergify.com config editor.

@Mergifyio update


 Yes

VS Code Version:  1.87.2
OS Version: Manjaro Linux

Steps to Reproduce:

In JavaScript, type this:

let nodes = [1,2,3,4];

and then start typing this:
nodes.fore

I get this idiotic autocomplete suggestion:

where it suggests nodes.foreach with lowercase e, which is incorrect and will throw an error in JavaScript because the correct method name is forEach with a capital E.
Even VSCode itself knows that, it can be seen in the screenshot above, where it shows the reference on the right.
And when I do accept the autocomplete suggestion, I get a different idiocy:

where this time the method name forEach is correct, but it has decided to add .array for no reason.

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!

I think your Triage Bot has gone berserk too.
Please reopen.

This is a question about using VS Code, not a bug. Those are snippets and what you show is expected for them

Well then it's poorly designed.
If I start typing nodes.forEach, why on earth would it make sense to autocomplete with nodes.array.forEach()... ?


S3Resource should override AbstractResource.createRelative

Type: Bug
Component:
S3
Describe the bug
S3Resource should override AbstractResource.createRelative in 3.0.0.

Thanks @ryanjbaxter, I missed that. PR ready