Implement middleware adding toolbar

A middleware that displays a summary toolbar for current request. Reference is available in Yii 2: https://github.com/yiisoft/yii2-debug/blob/master/src/assets/js/toolbar.js

I just thought that it would be nice to have a section with processed middlewares.

Yes. That's a good idea for a panel.


hello-world and hello-world@sha256:... are treated as different images

Description
hello-world and hello-world@sha256:... are treated as different images
Steps to reproduce the issue
$ nerdctl pull hello-world
docker.io/library/hello-world:latest:                                             resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb:    done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:f54a58bc1aac5ea1a25d796ae155dc228b3f0e11d046ae276b39c4bf2f13d8c4: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:feb5d9fea6a5e9606aa995e879d862b825965ba48de054caab5ef356dc6b3412:   done           |++++++++++++++++++++++++++++++++++++++|
layer-sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54:    done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 5.3 s

$ nerdctl image inspect hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb
FATA[0000] 1 errors:
no such image: hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb

$ nerdctl pull hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb
docker.io/library/hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb: resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb:                         done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:f54a58bc1aac5ea1a25d796ae155dc228b3f0e11d046ae276b39c4bf2f13d8c4:                      done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:feb5d9fea6a5e9606aa995e879d862b825965ba48de054caab5ef356dc6b3412:                        done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.9 s                                                                                total:   0.0 B (0.0 B/s)

$ nerdctl image inspect hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb
[
    {
        "Id": "sha256:feb5d9fea6a5e9606aa995e879d862b825965ba48de054caab5ef356dc6b3412",
        "RepoTags": [
            "hello-world:"
        ],
        "RepoDigests": [
            "hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb"
        ],
        "Comment": "",
        "Created": "2021-09-23T23:47:57.442225064Z",
        "Author": "",
        "Config": {
            "AttachStdin": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
            ],
            "Cmd": [
                "/hello"
            ]
        },
        "Architecture": "amd64",
        "Os": "linux",
        "RootFS": {
            "Type": "layers",
            "Layers": [
                "sha256:e07ee1baac5fae6a26f30cabfe54a36d3402f96afda318fe0a96cec4ca393359"
            ]
        },
        "Metadata": {
            "LastTagTime": "0001-01-01T00:00:00Z"
        }
    }
]

$ nerdctl images
REPOSITORY     TAG       IMAGE ID        CREATED               PLATFORM       SIZE        BLOB SIZE
hello-world    latest    6e8b6f026e0b    2 minutes ago         linux/amd64    20.0 KiB    6.9 KiB
hello-world    <none>    6e8b6f026e0b    About a minute ago    linux/amd64    20.0 KiB    6.9 KiB

Describe the results you received and expected
Received: hello-world and hello-world@sha256:... are treated as different images
Expected: should be treated as a single image
What version of nerdctl are you using?
v1.2.1
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

#1802 It looks related to this issue.

It looks like pull calls EnsureImage with "always" option: https://github.com/containerd/nerdctl/blob/8f2cad4ffac2ad0a93e6286626198147822a7c6b/pkg/cmd/image/pull.go#L50
which will ignore a check for existing image:
https://github.com/containerd/nerdctl/blob/8f2cad4ffac2ad0a93e6286626198147822a7c6b/pkg/imgutil/imgutil.go#L114-L115
what is meant by the PullMode values "always", "missing", and "never"?
https://github.com/containerd/nerdctl/blob/8f2cad4ffac2ad0a93e6286626198147822a7c6b/pkg/imgutil/imgutil.go#L54-L55


Remove execute rights from file internet-symbols.svg

Please, remove execute rights from file internet-symbols.svg

I have not a good knowledge of file permissions. Could you check if its fixed now? https://github.com/Xaviju/inkscape-open-symbols/commit/58182309378ca0eed2e45a6b6aeb7cb04abfb60f
If not, could you show me how to remove it?

Which operating system are you using?

Linux. Specifically I am using Ubuntu or Manjaro.

Go in a terminal to each directory that contains SVG files and type:
chmod a-x *.svg

I've made it and no changes occurred in any symbol set. Nothing to commit

then all is fine. I also checked latest download and there all is okay too.

Thanks!


feat(forge): add selectors list subcommand

Motivation
Lists functions, events and errors signatures + selectors of an individual contract or all contracts in the workspace
Closes #6038

Solution

add List to the SelectorsSubcommands enum on inspector.rs and implement the logic, using comfy_table to print the results

Example output:
forge selectors ls Dummy

thanks all!

Just want to say thank you for this!! This is so helpful!


Add filtering for comments

Is your feature request related to a problem? Please describe.
Especially, on views that allow many different categories of comments, it can happen that the number of comments becomes pretty large. In this case, finding a specific comment can be tedious work.
Describe the solution you'd like
Introduce filtering for comments. Options could be "Show all", "Specific type" and "specific type and instance". This way the number of displayed comments could be reduced to the ones in which the user is interested.
Additional context
Test findings v1.5.0

Duplicate of https://github.com/code-kern-ai/refinery/issues/136


make podman work with golang+openssl

Signed-off-by: Lokesh Mandvekar<EMAIL_ADDRESS>@baude @mheon @mrunalp

/assign @vrothberg

lol, this seems like a bad idea...

We need to get this in as a vendor update.

Closing this..


tournament: Put inputs/expectations inline, not in files

The previous iteration of reading/writing files is a valuable experience
in itself, but dilutes the focus of this exercise. We should consider an
exercise dedicated to that task if necessary, as discussed in #122.
Note that this preserves all behavior of existing test files. In
particular, the expectation that an invalid line is ignored is
preserved. If you wish for this behavior to be changed, you should
discuss that at https://github.com/exercism/x-common/issues/286 before
we make that change here.
The function tally now takes only a &str (it previously took two
Path, one for input and one for output) and now returns only a
String (it previously returned a Result<u32> where the Ok
counted the number of valid lines).
This commit is necessary but not sufficient for the closing of #122.
Points not covered by this commit but requested by #122 include:

Explain the input format. Covered by
https://github.com/exercism/x-common/pull/254
Explain behavior on invalid lines. Covered by
https://github.com/exercism/x-common/issues/286

amusing fact: Since the files output1.txt, output2.txt, output3.txt were pre-provided before this commit, I believe this means an empty implementation that does nothing will pass the tests.

This is good. I want to go through it a bit more carefully, but I don't think there's anything controversial here. As I mentioned in #122, no other languages use input/output files for this exercise. I don't think they are necessary.

squashed in the string suggestion since I'm pretty sure it's the way to go

a small rebase since both this and #155 removed some use lines (I just had to tell git "yup, all of them should remain removed")

With the removal of the File IO stuff, this problem could probably now be moved to a different spot in the order. It still requires a fair amount of work, but it's mostly just string parsing and some comparisons. Maybe it should move to somewhere in these problems?

hexadecimal
grade-school
queen-attack

Yeah now the list of skills is "string parsing, custom sorting, string formatting". I'm going to say after grade-school; both are problems that may see use of a HashMap to solve (store students by grade, store reults by team). Of course, if we have a desire to not put them together since they have too similar things, just say the word (that's why I mention it!)

Oh, I originally moved between grade-school and queen-attack.
In the meantime, robot-simulator was also added to the exact same position.
I'll add it before robot simulator.

Merging soon since it seems that all that wants to be said has been said.

Amazing. According to https://github.com/exercism/x-common/pull/22 , tournament was intentionally designed to include file I/O. The Rust track was the first track to have this exercise.
Looks like that purpose has been lost since then, both in this track and others.
I generally think the file I/O portion is not well-suited for the testing style of Exercism, but I see that above we considered whether there can be an exercise specifically dedicated for file I/O (the grep exercise ostensibly requires file I/O too).
I am sorry to the creator of this exercise for playing my part in the exercise's diversion from its original purpose. It was in the name of giving the exercise some purpose at all.

C# is the only track with vestiges of that file I/O since it uses streams.


Running ctest with parallel jobs in CI

Since we have 2 CPUs available in Github-provided runners, I though it may be beneficial to run Lethe tests in parallel. With two tests suites ran in parallel, the « Run Lethe tests » step is executed in (almost) half the time: twice the cores, half the time! I have to mention that verbose logging may be harder to read when two tests are executed at the same time, but ctest prints enough info to piece everything together.

Build Type (1)
Parallel (2)
Sequential (3)

Debug-dealii-master
8m 20s
16m 50s

Debug-dealii-v9.3.0
8m 18s
17m 11s

Release-dealii-master
69m 08s
107m 17s

Release-dealii-v9.3.0
54m 55s
81m 25s

(1) Commit 6bbebf
(2) https://github.com/technophil98/lethe/runs/2985108214
(3) https://github.com/lethe-cfd/lethe/runs/2952152517

As always, since the changes to the CI aren't merged yet, it is expected that this PR doesn't run with the proposed workflow.

Since we have 2 CPUs available in Github-provided runners, I though it may be beneficial to run Lethe tests in parallel. With two tests suites ran in parallel, the « Run Lethe tests » step is executed in (almost) half the time: twice the cores, half the time! I have to mention that verbose logging may be harder to read when two tests are executed at the same time, but ctest prints enough info to piece everything together.
Build Type (1)	Parallel (2)	Sequential (3)
Debug-dealii-master	8m 20s	16m 50s
Debug-dealii-v9.3.0	8m 18s	17m 11s
Release-dealii-master	69m 08s	107m 17s
Release-dealii-v9.3.0	54m 55s	81m 25s
(1) Commit 6bbebf
(2) https://github.com/technophil98/lethe/runs/2985108214
(3) https://github.com/lethe-cfd/lethe/runs/2952152517

This is something we tried in the past :) when we were using TravisCI. The issue we encountered is that some tests require mpirun=2. That is some tests actually use two cores at the same time. On TravisCI, the OS would then end  up being choked by the 3 (1 mpirun=2 and one single core) or 4 (2 mpirun=2) tests. The latter scenario was very catastrophic, with some tests just choking to a point they would start to timeout. Is there anything in Github Actions that prevents that?

This is something we tried in the past :) when we were using TravisCI. The issue we encountered is that some tests require mpirun=2. That is some tests actually use two cores at the same time. On TravisCI, the OS would then end up being choked by the 3 (1 mpirun=2 and one single core) or 4 (2 mpirun=2) tests. The latter scenario was very catastrophic, with some tests just choking to a point they would start to timeout. Is there anything in Github Actions that prevents that?

I should've figured out that I wasn't the first to come up with the idea. 😅 I thought: why not try try it?
We can try to execute ctest twice:

With 2 jobs in parallel whilst excluding mpirun=2 tests
Sequentially runningmpirun=2 tests

This way we can benefit from parallelism without chocking the runners!

This is something we tried in the past :) when we were using TravisCI. The issue we encountered is that some tests require mpirun=2. That is some tests actually use two cores at the same time. On TravisCI, the OS would then end up being choked by the 3 (1 mpirun=2 and one single core) or 4 (2 mpirun=2) tests. The latter scenario was very catastrophic, with some tests just choking to a point they would start to timeout. Is there anything in Github Actions that prevents that?

I should've figured out that I wasn't the first to come up with the idea. 😅 I thought: why not try try it?
We can try to execute ctest twice:

With 2 jobs in parallel whilst excluding mpirun=2 tests
Sequentially runningmpirun=2 tests

This way we can benefit from parallelism without chocking the runners!

Ouhhh Fancy. I love this.
Can you come up with a way to segregate the two? CTESTS supports regular expressions using ctest -R so maybe we could include/exclude MPI test and segregate the testing into two separate runs?

Let's try it out! 😎

Looks good! https://github.com/technophil98/lethe/actions/runs/1001395849

Looks good! https://github.com/technophil98/lethe/actions/runs/1001395849

Looks very, very, very good!


💣 The function getPunishment is inaccurate

In the Griefing contract, the function getPunishment exists to show the amount of punishment that is achievable for a given amount of cost.
The function returns incorrect values for two reasons:

The punishment amount is not limited by the maximum amount staked.
The getPunishment function uses multiplication but the actual getCost function which is used employes division. Due to quantization effects, division is not the inverse of multiplication. (e.g. 1÷3×3 ≠ 1)

Recommendation: remove the getPunishment function entirely because it can never be accurate.
References:

https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/modules/Griefing.sol#L91

Undecided on this one. I think having the function is worthwhile for reference purposes despite rounding error.

That's fair to keep it.
Alternate recommendation: document in the function that the result is approximate due to rounding/quantization


[BUG] Tagging Issue: App Crashes

Describe the bug
The app crashes when you try to tag "@" a user in a reply to a note.
To Reproduce
Steps to reproduce the behavior:

Select a note.
Tag "@" a user in a reply to the note.
The app crashes.

Expected behavior
A user is successfully tagged in a reply to a note.
Device (please complete the following information):

Android Version [e.g. 33]: GrapheneOS Android 14
App Version [e.g. v0.20.3]: v0.83.8

FYI, this seems to be an issue that only happens on the default keyboard of Graphene OS. Changing the keyboard fixes it.
https://coracle.social/notes/nevent1qyt8wumn8ghj7un9d3shjtnddaehgu3wwp6kytcpzemhxue69uhkummnw3ezu7rdwgh8ymmrddej7qghwaehxw309aux6u3ww4ek2mn0wd68ytn0wfnj7qgewaehxw309aex2mrp0yhxummnw3exzarf9e3k7mf0qyv8wumn8ghj7cmp9ehhyctwvajhq6tvdshxgetk9uq3jamnwvaz7tmvd9nksarwd9hxwun9d3shjtnrdakj7qghwaehxw309amxjar0wghxummnw3erztnrdakj7qgawaehxw309ahx7um5wghx6at5d9h8jampd3kx2apwvdhk6tcpzemhxue69uhk2er9dchxummnw3ezumrpdejz7qgmwaehxw309aex2mrp0yhx7unpdenk2urfd3kzuer9wchsqgxhrqmlyasagpmc0hqzeuapzlalsprve560tmewt3zsp34p2u3j0q7cuy75

Florisboard also has the same issue. Anysoft, GBoard and Unexpected Keyboards seem to work.

Does anyone have any idea where in the code we should be looking to fix this? It wasn't a problem on older versions of Amethyst. It was promptly reported since tagging people is an extremely common operation. Probably introduced in 0.83.8 or 0.83.9? Possibly as far back as 0.83.7.
I'll try to grab a test phone and see if I can determine the exact release that introduced this issue and report back here with whatever I find.

It's not on our code. The stack trace doesn't know any particular issues that can be handled on our codebase. But if you want to take a look, it is a bug that happens when the UrlUserTagTransformation class is used. VisualTransformations map the npub to the user's name in the edit field, reducing the length of the text. The issue happens because some keyboards run their auto-correct procedures in the modified text but with indexes of the original text, which causes an OutOfBounds exception.
Currently, the Alpha release of FlorisBoard has this issue fixed. OpenBoard and whatever Graphene uses as the default keyboard still have these issues. AnySoft, Unexpected Keyboard, and GBoard never crash.

This was solved on v0.87.6


Warn about manually editing the config file

The file is managed by the snap,
so manual edits would be overwritten when the configure hook runs.

In another words, users cannot modify this file manually

This is a config file that is generated by the configure hook. It is not part of the immutable snap package, and can be edited by the snap or users.


Improve the Build List UI

Includes #34
Hey there, just wanted to add some polish to your build list view controller, mainly:

Splits out the two local/remote
Shows the app versions that a build works with
Orders the builds

Before:

After:

Tests still pass:

re: https://github.com/artsy/eigen/pull/1817

This looks great! Thanks for submitting the PR, @orta


Clean Random & make RandBasis available

The Random object is meant to unify how randomness is used and ensures a seeded state. However, it was not possible to get a breeze RandBasis due to it being private. When working mit more than breezeUniform and breezeGaussian this is required, e.g. in
import breeze.stats.distributions._

val rnd = Random(9)
import rnd.breezeRandBasis
val gauss = Exponential(2.0)
gauss.draw() // should yield: 0.48878484018783064

Also fixed a typo in breezeUniform
Ranamed parameter sigma of breezeGaussian to avoid confusion - it is a standard deviation, not a variance
Use System.nanoTime() for more fine-grained seeding

@sschoenborn
Thanks for this fix. I agree with most changes, but find that the new interface is inconsistent. Either we should access the object via the randBasis, and then deprecate the breezeUniform method (my preference), or we add for all interesting distributions accessor methods.
What do you think?

I would then prefer the first solution: deprecate the direct methods breezeUniform / breezeGaussian and promote the direct use of breezeRandBasis

by the way: breeze 0.13 has a direct RandBasis.withSeed(seed) (and fixes a wrong pdf in MultivariateGaussian)

@sschoenborn Awesome. Thanks a lot for the changes. I will try to upgrade the dependency to breeze 0.13. This would also give us compatibility with scala 2.12.


chore(langgraph): Release 0.2.11

@jacoblee93 I think the git tag is missing for this one. Apologies if that's still in process. I only noticed because I keep a local copy of the repo checked out to the latest release tag, and I couldn't update it automatically based on the npm package's latest tag just now.

Thanks for the heads up!


Clicking on select icon doesn't open select

This one is quite simple - if you click on the arrow suffix icon on the select element, it doesn't actually engage the given element. I've also found the optimal fix to be to just set the icon's z-index to -1.
.select-wrapper .mdi-navigation-arrow-drop-down {
  position: absolute;
  right: 0;
  top: 0;
  font-size: 23px;

  z-index: -1;
}

This is fixed for next release.


Change respond-to-retina to respond-to-dpi

See https://github.com/cfpb/cfgov-refresh/pull/508#discussion_r29686797

Fixing


Drag drop with helper clone and insertInline messes up the dropped array?

Quick glance: http://g.recordit.co/GOL1YK5LR8.gif
I create a snippet with clone helper and insertInline to sort the items in the "droppable" area.

            {{fieldType.name}}

		{{item.name}}

Your field here

After dropping an item into the droppable area, it messed up the end array (changes them completely). I have no clue what causes this...

@phuwin You are doing it wrong. Pls refer, https://github.com/codef0rmer/angular-dragdrop/blob/master/demo/dnd-shoppingcart.html

@codef0rmer Can you point which is the wrong lines of code?

@phuwin AFAIK, your demo is quite similar to the shopping cart demo I shared earlier. Please refer to it because insertInline and other stuff you do not need.

@codef0rmer I still need the insertInline because I need the end array to be sortable.

You do not need to use insertInline in order to sort the array, that's
not why the feature was introduced. The insertInline is like sortable in
jqueryUI.
For the sorting functionality, you can sort the array upfront and use it in
ngRepeat then, refer filters demo for that:
https://github.com/codef0rmer/angular-dragdrop/blob/master/demo/dnd-filters.html
On Thu, Dec 8, 2016 at 1:35 PM, Phu Nguyen<EMAIL_ADDRESS>wrote:

@codef0rmer https://github.com/codef0rmer I still need the insertInline
because I need the end array to be sortable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codef0rmer/angular-dragdrop/issues/305#issuecomment-265678096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKNO3QQvWYQmFTbTkrryu0TCwbXYeGlks5rF7pcgaJpZM4LGlpQ
.

--
With Regards,
Amit Gharat
http://amitgharat.wordpress.com/
The luckiest person is one whose passion and profession are the same.

@codef0rmer Maybe there is a misunderstanding.
In the frontpage, it is written insertInline :

Make a list sortable. Same model is mandatory for draggable and droppable.

@codef0rmer The issue I have at the moment is that after the first item dropped, the later items mess up the end array. Sortable function works well though.

@codef0rmer Hi there, I also got this similar issue here.
here is the plunker url https://plnkr.co/edit/lTwpnTdLHtlnhTE1EaLm,
function try to achieve: In shopping cart panel, let's say it already has 1.lolcat shirt & 2.cheezeburger shirt, I want to be able to drag buckit shirt directly from the product panel to the cart panel, the result in the cart panel should have 1.lolcat shirt  2.buckit shirt 3.cheezeburger shirt.
As the plunker url showing, once I drag the buckit shirt from product panel and drop onto cheezeburger shirt which already in the cart panel, everything just mess up, it turns out the result showing 1.lolcat shirt  2.buckit shirt 3.buckit shirt
Please help, thanks!

@phuwin have you solved the issue you got now, seems I got the same issue at the moment.
Please share some light on the road if you've already figured it out, thanks!


Gene IDs after updated prepDE.py

Hi,
I am having trouble with geneIDs in gene_count_matrix file. I will give an example:
This transcript MSTRG.43175 found twice in the matrix.  And they do not have the same expression as can be seen below.
SRR7185486 SRR7185487 SRR7185505 SRR7185506 SRR7185508 SRR7185510 SRR7185511 SRR7185517 SRR7185518 SRR7185537 SRR7185553
MSTRG.43175               0          0        128          0          0          0          0          0          0          0          0
MSTRG.43175|RXRB          0          0          2        140          0          0          0         12          0          0          0

I checked merged GTF file(mstrg_43175.txt). It has many MSTRG.43175 transcripts as expected. I do not see any problem in that.
Could you help me understand the discrepancy I see in the gene_count_matrix file?
Happy New Year!
Asuman

Any update? @gpertea

Any update? @gpertea


getClass can fail because of java.lang.UnsupportedClassVersionError

This is issue is mainly here for future googlers.
getClass can silently fail with the underlying error java.lang.UnsupportedClassVersionError although it will only throw java.lang.RuntimeException: Class xxx not found.
To actually see the error you need to turn on tracing (taken from here):

uncomment line 23 in file src/native/common/include/jpype.h
python setup.py build -f
python setup.py install -f

The problem in my case was that I was compiling using java 1.8 but jpype found an old java 1.6 from the /urs/bin/java binary as I didn't set the JAVA_HOME environment variable.
It would probably save people a lot of time if we could actually expose the java.lang.UnsupportedClassVersionError thrown without the tracing enabled.
see: https://sourceforge.net/p/jpype/support-requests/5/
handy tool for different java versions: http://www.jenv.be/

This defect has been addressed by #550


Linking error only in Archive/Release build

Hey, probably this is a problem with my individual setup, but I can't really figure out a solution.
I have a relatively small and simple iOS app with FlyingFox (0.17.0). When I build for a debug configuration all works well including on device. But, if I want to archive my build for distribution, I get the following linker error:
Undefined symbol: protocol witness table for FlyingSocks.SocketPool<A> : FlyingSocks.AsyncSocketPool in FlyingSocks

I also don't really have FlyingSocks in use anywhere, just FyingFox.
Any idea what might be wrong? I really didn't mess with any specific settings during the build process and I checked if there are any noteworthy differences between debug and release but I can't find any that seem to be relevant.
If this helps:

XCode 16.0
Build Target is iOS 18
Dependency is managed through XCode package management
Swift 5
Other packages in the project are Starscream and SwiftUIKit, nothing else.

I am happy to read on anywhere else, but a pointer would be much appreciated. Thanks!

Thanks for reporting this issue. I've fixed something similar on Linux recently are you able to try the main branch to see if it still has the issue?
Can you also share the snippet of how you initialise HTTPServer? and I can attempt to reproduce.

Hey,
here is a quick snipped to help to reproduce:
import Foundation
import FlyingFox

class Server {
    let server: HTTPServer
    var serverTask : Task<(), any Error>?

    init(serverPort: Int = 8080) {
        self.server = HTTPServer(port: UInt16(serverPort))
    }

    func startServer() async throws {

        serverTask = Task {
            try await server.start()
        }

        try await server.waitUntilListening()
        print("Listening...")

    }
}

If you add that to the default iOS App template in XCode it already fails to build for the default release config. (After adding FlyingFox as a dependency.)
I'll tryt the main branch next.

Thanks, I've managed to reproduce the issue and it does appear that commit 2ec8ae2b fixed the issue so I have pushed out a new release 0.18.0

Can confirm 0.18.0 fixed the archive/release build. Thanks a lot!


chore(package): update aggregation-repository-provider to version 2.0.26

Coverage remained the same at 80.905% when pulling 73e2525fba3b546ab9e5eb7a911a9a8612f30b9f on greenkeeper/aggregation-repository-provider-2.0.26 into 25755d646e76840417cec3dd6c3982a7b2f3db92 on master.

:tada: This PR is included in version 7.8.26 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


nested objects does not work

From the documentation the following code does not work.
{
'foo': {
'bar': 'ok'
}
}
i18n.__('foo.bar');

I have this problem also. It basically adds a key 'foo.bar' to the bottom.

Hello,
First of all; you may describe a little more your problem and the context : what version do you use, are you in debug mode or not, etc.
I'm guessing you're installing from NPM so the version you have is not up to date (and this is being fixed : https://github.com/jeresig/i18n-node-2/issues/74)

See #72


⚠ Bofrost.lu has degraded performance

In 94b4ba3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 961 ms

Resolved: Bofrost.lu performance has improved in 3749a0e after 15 minutes.


Java packages

Note: I am replacing #12770 with this.
I have taken most of the concepts from the mentioned PR and cleaned them up.
I have also added a full build of JUnit 4.12 and a sample project, which uses said JUnit version.
Most artifacts are binaries because an extremely simplistic project like the one I created requires hundreds of artifacts. Building all of those from source is (surprisingly) impossible. - The Java world for you :D
I am terrible at rebasing in git, so I suggest we squash upon PR merge. (I did things out of order and in weird chunks, so it would not be a straight rebase with squashing; unless we remove context)
Here is what I have done:
Build support
Essentially what was already in #12770 except much less copying because as it turns out, Maven does like symbolic links if you do it right :)
I have a way to fetch Maven Central binaries (fetchMaven) and a build helper (mavenbuild).
I have also added optional skipTests and quiet parameters (both of which default to true).
Why default skipTests to true?
Turns out, JUnit expects hamcrest-core on the classpath without defining it as an explicit runtime dependency. If somebody knows how to convince a pom.xml that depends on JUnit but not hamcrest-core to run tests in offline mode, please do provide feedback.
Plugins
I have added a large number of default Maven plugins.
Theses are needed to get Maven to do anything at all...
I have created mavenMinimal for this purpose, a list of plugins and their dependencies that are required no matter what you are building. This list of automatically included when using mavenbuild.
Libraries
So far, I have all the libraries that are needed to

Run Maven (3.3.9)
Build JUnit 4.12
Run tests using JUnit 4.12

Mirror
I have added a maven alias to the fetchurl mirrors. This is not strictly required but may help in the future if URLs change or another mirror can be added.
Useful stuff

JUnit 4.12
Maven-Hello v1.0 and v1.1 (sample project to prove things work, code on GitHub)

Collections
Generally, if you have one of the Maven libraries that you depend on, they eventually pull in all their brothers and sisters with the same versions numbers as well. So I created mavenLibs collections to make things easier.
SHA512
Sorry @copumpkin, I know we just talked about it but the number of SHA512 in my branch had already been in the triple digits, so I kept it this way. (Forgive me :D)
Maven
The Maven/Java environment is dirty, crazy and unorganized for the most part.
Try building a "Hello World" application and you need to pull in hundreds of dependencies.
Don't even think about building all of those from source (see #12770) for examples of circular dependencies and seemingly endless chains of dependencies that will feel like time travel into the beginnings of Java.
This is why the code in this PR looks the way it does and lists more than 3,500 new LoC.
Compared to the old PR I have already abstracted and massively simplified...
Future
I would ask for any feedback I can get here.
This has been a lot of work but if most people are against this, I won't be mad.
If we decide to include javaPackages into nixpkgs, we should definitely write some documentation, which is why I added the appropriate label.
Note sure what else to say...

/cc @copumpkin @shlevy @puffnfresh @bendlas @Mathnerd314 because they all had comments on the old PR

Just an idea. It would be nice if fetchMaven could use attribute names from maven space, like:
fetchMaven rec {
  version = "2.4";
  artifactId = "maven-install-plugin";
  groupId = "org.apache.maven.plugins";
...

instead of:
fetchMaven rec {
  version = "2.4";
  baseName = "maven-install-plugin";
  package = "/org/apache/maven/plugins";
...

Re: groupId/artifactId
YES!

Ping :)

restarted travis builds

looks like travis fails

sorry i just notices, that this PR is meant for feedback. ignore me

👍

I say we merge it and iteratively improve on it. It fills in a big gap in nixpkgs today, and isn't going to hurt/conflict with any of the other package ecosystems by being merged.

The travis failures definitely look valid.

I will take a look at this today or tomorrow (I hope). Seems that Maven Central is sensitive to the (unintentional) double slash all the sudden...

Found two typos, everything should be good to go now. Let's see what Travis thinks...

There we go, Travis is happy

One more question: do people always just ask for the pom and jar combination or are there use cases for only asking for one? I'm wondering if we could cut down on the hash noise a bit by making fetchMaven do a recursive hash on the two files it retrieves at the same time. Not sure if that would complicate other things, but copying and pasting long strings of junk is bad enough without having to do it twice for every package 😄

For example, I have a (yet unpushed, sorry) fetchIvy fetcher that will use ivy to retrieve a whole pile of dependencies at once, and just hash once per bundle of dependencies.

I found it actually depends on the artifact... Some are POM-only, most want JAR and POM but it is technically allowed to only use the JAR and leave the POM alone (i.e. if you want to avoid pulling transitive dependencies). By doing it this way, I just decided to give all the options :)

@NeQuissimus I guess I'm saying that you could still allow people to ask for all those combinations without requiring one hash per thing you ask for. It might not be worth it, but as a potentially avid user of this thing I'm a little concerned about the code's UX 😄

I am hoping to eventually have some sort of auto-generation.  This is essentially more of a PoC than anything, I suppose :)

How's this going?

This is done from my POV

Fine by me!

Sure, fine by me. Thanks for the effort and patience!

Don't forget to make an issue in the issue tracker btw!

@NeQuissimus I'm trying to package an Ant-based project right now that needs a couple of JARs not shipped inside the tarball from Maven Central. Could you please give an example on how to add a Java package to the build inputs and modify the classpath?

You're going to need to write something similar to pkgs/development/java-modules/m2install.nix. I have not dealt with this stuff in a while, sorry.

We should consider to do with Maven something like what @peti is doing with Cabal: prepare snapshots of all .pom-files and all .sha1-files (like https://github.com/commercialhaskell/all-cabal-hashes https://github.com/commercialhaskell/all-cabal-files) and update them in nixpkgs on weekly or monthly basis.
Per-artifact pom-to-nix conversion (like in this PR) seems bad for the reasons:

There are 13 millions artifacts only in Maven Central (+ some number in bintray and sonatype), if we eventualy import a significant number of them into nixpkgs, Nix would require terabytes of memory to process nixpkgs.
It is not convenient for dependency resolution of more than 1 artifact. snapshot of all .pom-files + snapshot of all .sha1-files should provide enough information to run something like offline coursier against it, so it would be possible to create a Nix function

artifactsAndAllDeps [ "org.apache.hadoop:hadoop-client:2.7.7"
                      "org.apache.accumulo:accumulo-master:1.9.2" ];

which would produce a derivation with all jars + dependencies in our usual $out/share/java

looks like no one got round to doing all those improvements and fixes in the end, huh? 🙂
I'm currently wondering about wether to build an existing maven based project with nix. I'm fairly new to writing my own derivations and it's been quite a while since I've used java and I've also never really got to know the build systems in the java ecosystem, mostly I relied on my IDE doing the work for me back then.
Some documentation on how to use this to package maven projects would be nice :D
when is fetchmaven needed for example?
I'll just try to naively use mavenbuild on the repository like it's done with maven-hello.
Maybe I can write the documentation myself later if I succeed


[SFTP] Issues with drag & drop upload feature

drag & drop upload does not allow uploading of multiple files
after uploading a file via drag & drop, the file list does not refresh. would be good for it to automatically refresh, or add a refresh button (or using the F5 button) for us to manually refresh the file list

Fixed. Thanks for testing the nightlies by the way, I appreciate it!

happy to test! thanks for all the work!


Output of html

This PR changes the output of the graph to the directory in /tmp.
Fixes: #38

Hello @Honny1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file oval_graph/client.py:

Line 115:100: E501 line too long (112 > 99 characters)

In the file setup.py:

Line 18:19: E251 unexpected spaces around keyword / parameter equals
Line 18:21: E251 unexpected spaces around keyword / parameter equals
Line 21:5: E124 closing bracket does not match visual indentation
Line 21:6: W292 no newline at end of file

In the file tests/test_client.py:

Line 207:88: E231 missing whitespace after ','
Line 219:88: E231 missing whitespace after ','

Thank you for improving the PR, merging!


[Broker] Expose lastConsumedTimestamp and lastAckedTimestamp to subscription stats

Motivation
Currently, msgBacklog measures the number of messages that a subscription has not consumed and it is an estimated value. It is hard to tell the difference between a backlog estimate being wrong and messages being otherwise stuck. It would be great to expose lastConsumedTimestamp and lastAckedTimestamp to measure the activities of dispatch and acknowledge. So people can use these timestamps to tell if acknowledge and consumption are happening.
These two metrics provide a lag metric similar to Kafka.
Related Tasks: #5721

This has been solved #6051


Nice to have: Gizmo props for custom labels

Following this discussion:
https://github.com/threlte/threlte/issues/1089#issue-2495485226
This is a minor update of Extras/Gizmo component to add xLabel, yLabel and zLabel as props (insted of hardcoded 'X', 'Y', 'Z' values) to this component.
Please forgive me if I messed something up or of this is not the propper way to proceed with this change. This is actually my first PR in Github, but I think Threlte is pretty neat!

please add a changeset so that packaging will pick up the update 👍


The "{{.User.(ID/Username/Mention/Discriminator/Bot)}}" text on the website confuses people

I wanted to do a pr for this but uhhh i have no idea about html and also don't know how it should end up looking. The file you'd have to edit for this is cp_main.html
One or 2 examples like {{.User.Mention}}. {{.User.Username}} [for more info see the docs](https://docs.yagpdb.xyz/reference/templates#user) or something like that would be really good. The same goes for {{.Author.(Username/ID/Discriminator)}}, {{.Server.(ID/Name/Icon/Owner/Permissions)}}. Just so people don't ask why {{.Author.(Username/ID/Discriminator)}} gives them an error if they exactly copy and paste that into the response box.
Also jonas, check your dm, i messaged you something that I wanted to say about this here but can't because everyone would be able to see it.
Ah and one more thing... what actually is {{.Server.Permissions}}? I don't remember us being able to use that.

Re: The helper text
I'll open a pull request changing that.
Re: .Server.Permissions
Doesn't look like it is properly exposed? I'm getting errors that this field can't be evaluated, join feed just fails. I think it's this:
https://discord.com/developers/docs/resources/guild#guild-object-guild-structure
(see permissions? there)


higher performance on random,entropy and coreset methods compared to paper

I try to reproduce random,entropy and coreset methods based on mmdetection.  However, results are much higher compared to paper. Do you have any idea about this?
Thanks.

The results of all methods except MI-AOD using SSD is copied from Figure 6 in LL4AL and Figure 4 in CDAL. You can ask them for more reasons.

Okay. Thank you for your reply.

@ChenggangLu Would u mind sharing the scripts used to evaluate the entropy and coreset method? I am also working on similar issues, thanks!

The dataloader is initialized in the same way as author here
import numpy as np
import torch
import torch.nn as nn
import torch.nn.functional as F

from mmdet.utils import get_root_logger

class SelectionMethod:
    """
    Abstract base class for selection methods,
    which allow to select a subset of indices from the pool set as the next batch to label for Batch Active Learning.
    """
    def __init__(self):
        super().__init__()
        self.logger=get_root_logger()

    def select(self, selection_size):
        """
        Select selection_size elements from the pool set
        (which is assumed to be given in the constructor of the corresponding subclass).
        This method needs to be implemented by subclasses.
        It is assumed that this method is only called once per object, since it can modify the state of the object.

        Args:
            selection_size (int): how much images selected in one cycle

        Returns:
            idxs_selected (np.ndarray): index of chosen images
        """
        raise NotImplementedError()

class RandomSelectionMethod(SelectionMethod):
    def __init__(self,idxs_unlabeled):
        super().__init__()
        self.idxs_unlabeled=idxs_unlabeled

    def select(self, selection_size):
        np.random.shuffle(self.idxs_unlabeled)
        return self.idxs_unlabeled[:selection_size]

class EntropySelectionMethod(SelectionMethod):
    def __init__(self,data_loader,idxs_unlabeled,model):
        super().__init__()
        self.data_loader=data_loader
        self.idxs_unlabeled=idxs_unlabeled
        self.model=model

    def select(self, selection_size):
        self.logger.info(f'------ computing image entropy ------')
        entropy=torch.zeros(len(self.idxs_unlabeled)).cuda()
        for i,data in enumerate(self.data_loader):
            with torch.no_grad():
                if i in self.idxs_unlabeled:
                    idx=np.where(i==self.idxs_unlabeled)[0][0]
                    img=data['img'][0].cuda()
                    # calculate entropy
                    feat = self.model.extract_feat(img)
                    cls_scores, _ = self.model.bbox_head(feat)
                    all_cls_scores = torch.cat([
                        s.permute(0, 2, 3, 1).reshape(
                            s.shape[0], -1, self.model.bbox_head.cls_out_channels) for s in cls_scores
                    ], 1)
                    all_cls_scores=F.softmax(all_cls_scores,dim=2)
                    entropy[idx]=torch.sum(all_cls_scores*torch.log(all_cls_scores),dim=2).mean()
                if i%500==0:
                    self.logger.info(f'------ {i}/{len(self.data_loader.dataset)} ------')
        arg=entropy.argsort().cpu().numpy()
        return self.idxs_unlabeled[arg[:selection_size]]

class CoresetSelectionMethod(SelectionMethod):
    def __init__(self,data_loader,idxs_labeled,idxs_unlabeled,model):
        super().__init__()
        self.data_loader=data_loader
        self.idxs_labeled=idxs_labeled
        self.idxs_unlabeled=idxs_unlabeled
        self.model=model

    def select(self, selection_size):
        self.logger.info(f'------ computing image feat ------')
        feats=compute_feat(self.data_loader,self.model)
        feats_labeled=feats[self.idxs_labeled]
        feats_unlabeled=feats[self.idxs_unlabeled]

        self.logger.info(f'------ computing distances ------')
        dist=torch.cdist(feats_unlabeled,feats_labeled,p=2).min(dim=1)[0]

        self.logger.info(f'------ choose images ------')
        idxs_chosen=[]
        for i in range (selection_size):
            idx=dist.argmax()
            idxs_chosen.append(self.idxs_unlabeled[idx])
            new_dist=torch.cdist(feats_unlabeled,feats_unlabeled[idx].unsqueeze(0),p=2).squeeze()
            dist=torch.where(new_dist<dist,new_dist,dist)
            if i%20==0:
                self.logger.info(f'------ {i}/{selection_size} ------')
        return np.array(idxs_chosen)

def compute_feat(data_loader,model):
    logger=get_root_logger()
    feats=torch.zeros([len(data_loader.dataset),1024]).cuda()
    for i,data in enumerate(data_loader):
        with torch.no_grad():
            img=data['img'][0].cuda()
            feat = model.extract_feat(img)
            # feat shape [1024]
            feats[i]=nn.AdaptiveAvgPool2d((1, 1))(feat[1]).view(-1)
            if i%500==0:
                logger.info(f'------ {i}/{len(data_loader.dataset)} ------')
    return feats

@ChenggangLu Would u mind sharing the scripts used to evaluate the entropy and coreset method? I am also working on similar issues, thanks!
I use the same settings in Learning Loss.

I find out the reason. The data augmentation used in mmdetection is a little different from SSD in LL4AL. It seems that SSD in LL4AL miss sampling a patch the minimum Jaccard overlap with the objects is 0.5.
When i change the settings in mmdetection to be the same as SSD in LL4AL, the results are almost the same.

OK, thanks for your research.

Hi, did you rerun the SSD with Pascal VOC? How about your results? My results are lower than the paper,but my log file is same to the author'.

Hi, did you rerun the SSD with Pascal VOC? How about your results? My results are lower than the paper,but my log file is same to the author'.

Do you mean use MIAOD to select samples to train SSD with PASCAL VOC? I haven't tried yet.

Hi, did you rerun the SSD with Pascal VOC? How about your results? My results are lower than the paper,but my log file is same to the author'.

Do you mean use MIAOD to select samples to train SSD with PASCAL VOC? I haven't tried yet.

yes,i train SSD with VOC,but mAP is lower than the paper

@jiahao12121 Ok. I will try to use MIAOD and reply you later after getting results.

@jiahao12121 Ok. I will try to use MIAOD and reply you later after getting results.
Thank you! Recently i'm studying the code, i have some valuable questions, may i discuss with you? would you mind leaving a mail?

@jiahao12121 Ok. I will try to use MIAOD and reply you later after getting results.
Thank you! Recently i'm studying the code, i have some valuable questions, may i discuss with you? would you mind leaving a mail?

@jiahao12121 Ok. I will try to use MIAOD and reply you later after getting results.
Thank you! Recently i'm studying the code, i have some valuable questions, may i discuss with you? would you mind leaving a mail?

My email address is<EMAIL_ADDRESS>

@ChenggangLu Thanks for sharing the code and sorry for the late reply. For your original question, personally I think it might be due to the use of pretrained models.


merge from arlac77/template-cli-app,arlac77/template-github

package.json

chore(package): add ^3.5.2 remove ^3.5.1 (devDependencies.ava)
chore(package): add ^2.3.0 remove ^2.2.0 (devDependencies.rollup)

:tada: This PR is included in version 2.1.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support for 8k resolution videos (dav1d codec)

Currently decoding fails with
Traceback (most recent call last):
  File "/home/user/.local/lib/python3.10/site-packages/youbit/__main__.py", line 226, in decode_url
    filepath = decoder.decode(output)
  File "/home/user/.local/lib/python3.10/site-packages/youbit/yb.py", line 338, in decode
    with youbit.video.VideoDecoder(vid=file, zero_frame=zero_frame) as decoder:
  File "/home/user/.local/lib/python3.10/site-packages/youbit/video.py", line 169, in __init__
    raise RuntimeError(
RuntimeError: Unsupported codec: libdav1d

Adding support for the dav1d codec might be trivial or not so much depending on the GOP structure.
Might look into this sometime.


(Beta2) How i can remove the top label / dataset label in Bar/Scatter/Line Chart?

Hey guys,
how i can remove/hide the dataset-label in the topic headline chart types?
datasets: [   {     label: '',     ....   } ]
empty string or undefined doesnt work for me!

@pleinx are you talking about the legend? I don't think this is currently possible. should be easy to add though if the label is empty or undefined.

@etimberg yes, its the legend.
to make sure we mean the same: http://fs5.directupload.net/images/160223/vauxsbo3.png
Can you help me how i can disable the legend via editing the Chart.js (Beta2)

Are you wanting to disable the entire legend or just the text in the legend?
To disable the entire legend, add this in your config
legend: {
    display: false,
}

Off the top of my head, I don't know exactly where to edit to remove only the text. You could try setting the font size to 0 and see what happens, but i can't guarantee that it would work
legend: {
    labels: {
        fontSize: 0
    }
}

Hey @etimberg ,
thank you very much!
This works for me:
new Chart.Scatter(ctx, { 				data: scatterChartData, 				options: { 					legend: { 						display: false 					}}});

@pleinx where you have added this line of code?

@TubaKhan4
In the arguments of the constructor. See here:
$(document).ready(function() {
   var ctx = document.getElementById("canvas").getContext("2d");
   Scatter = Chart.Scatter(ctx, {
      data: scatterChartData,
      options: {
      	legend: {
      		display: true
      	}
      }
    });
  });

But it doesnt work with your version. I dont know which the current one, this was for beta2.

You can simply add public barChartLegend: boolean = true; in your component.ts file.

If you set legend display to false, elements on the top of the chart will be cropped.
So you can just replace legend with the empty text:
const options = {
  legend: {
    display: false,
  },
  title: {
    display: true,
    text: ''
  },
};

options: {
plugins: {
        legend: {display:false} //<-- This makes the legend not to display
    },

    scales: {
        y: {
            beginAtZero: true
        }
    }
}


Add file_hash to commit

Description:
To aid in seeing if a file is identical to other scanned files in other commits, output the "file_hash" field.
Checklist:

[ ] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you lint your code locally prior to submission?

@grogancolin this seems like a worthwhile change, could you work on resolving the merge conflicts?

@w0rmr1d3r currently there is no test for this. We can add a test case here https://github.com/zricethezav/gitleaks/blob/master/scan/scan_test.go#L773-L815 but that might be beyond the scope of this PR and better suited for https://github.com/zricethezav/gitleaks/issues/618


[ksqldb] Add implementation for describeCluster

Motivation
After upgrading the Kafka client library to 2.8.x some clients, like the KSQLDB server, require that describeCluster API is implemented.
Modifications

implement describeCluster
response with UnsupportedVersionException to unknown APIs

Verifying this change
This change added tests
Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc

No need to add docs, this is a standard API

[ ] doc
(If this PR contains doc changes)

This patch is also very important after the upgrade of the kafka client library


Cells with french accents exporting as FALSE instead of proper content

I'm pulling data from a SQL Server 2008 DB.  Cells with content containing french accents (ex: "Stéphane") come out as "FALSE" centered in the cell in excel.  var_dump'ing the content from the database shows it coming from the DB correctly

Hello I'm having the same issue right now but while importing from csv.
Lines with french accents return false so I can't process them.

Hello I'm having the same issue right now but while importing from csv.
Lines with french accents return false so I can't process them.

@CatoonTheCat You're replying to a very old ticket. Please note that if you're not using version 3.1, you're strongly suggested to upgrade to the latest version (as older are no longer supported).
Could you please open a new issue (by filling in the issue template) so we can better assist you? Thanks!

I found the cause of the issue, I needed to specify the encoding in my conf file. Sorry for updating an old ticket I didn't pay attention to the date.

I found the cause of the issue, I needed to specify the encoding in my conf file. Sorry for upping an old ticket I didn't pay attention to the date.

No worries, glad to hear it's resolved and thanks for using Laravel Excel :)


API 3.1 in beta

Steps to reproduce
Install newest beta version of Telegram.Bot
Expected  behavior
New methods like RestrictChatMemberAsync
Actual behavior
New methods not found
Environment data
NuGet Package Version: 13.0.0-beta-01
.NET Version: .NETFramework,Version=v4.6
IDE: VS 2017

I just took a look with dotPeek, and the methods are present in the dll, VS just doesn't recognize them

Object catalog doesn't recognize them either, uninstalling and reinstalling didnt help

Tried it with a new project (.NET 4.5.2, dunno if that matters) and it worked fine.

okay, was my bad. found the error.


Does not build on distros that provide libclangTooling as libclang-cpp.so

Some modern distros build clang such that there are no individual libraries libclangTooling.so etc, but only a single libclang-cpp library. For example Arch Linux does so since clang 10.
It would be cool if there was an option to enable Tsepepe to build on those distros (right now the build fails, because Tsepepe hardcodes linking to clangTooling everywhere).
For example qtcreator added an option to allow distros to opt-in to linking to libclang-cpp instead via an CLANGTOOLING_LINK_CLANG_DYLIB cmake option like this: https://github.com/qt-creator/qt-creator/blob/ee98c98676d96bbd633a92c976077adc129b82a1/cmake/FindClang.cmake#L7
It would be nice, if something similar could be added to this project. Would you accept a patch adding such an option?
P.S.: FYI the clang 15 build currently fails because of a missing header include:
diff --git a/src/src/libclang_utils/misc_utils.cpp b/src/src/libclang_utils/misc_utils.cpp
index d8ae744..548f5a2 100644
--- a/src/src/libclang_utils/misc_utils.cpp
+++ b/src/src/libclang_utils/misc_utils.cpp
@@ -9,6 +9,7 @@
 #include <iostream>
 #include <regex>

+#include <clang/Basic/SourceManager.h>
 #include <clang/Lex/Lexer.h>

 using namespace clang;

Hello! You are more than welcome to create such a patch. If more distros could be supported, then I am all for it.
Ad. P.S. I have pushed a commit with the fix you have proposed, but I still can't compile it with clang 15.0.6 due to problems with connecting std::filesystem iterators with the std::ranges::view. Now I can see that the include paths are taken from the system tree, instead of the system headers where clang is located (I use export CC=/some/local/user/path, which is not a system-wide visible compiler path). I need to check it out with a toolchain file.

Hello! You are more than welcome to create such a patch.

Thanks, I have pushed the fixes in #9 :)

I have pushed a commit with the fix you have proposed, but I still can't compile it with clang 15.0.6 due to problems with connecting std::filesystem iterators with the std::ranges::view

I didn't formulate that well... I didn't mean compiling with clang 15, I meant compiling with gcc but linking against libclang/libllvm 15, indeed the clang build doesn't work right now due to missing <ranges> support.


Publish this package to PyPi?

Hey! I really want to make use of the new partial JSON parsing support in one of the libraries I maintain but we've been maintaining compatibility with Pydantic v1 and it's still getting a lot of usage so we can't bump our minimum version requirement just yet :/
Would you be open to publishing this parser as a separate package to PyPi so we can add that as a dependency instead?

Yes we will, that's the plan.

Awesome! Any planned timeline you can share?

As soon as I have time.
Sorry, I can't be more specific than that.

https://pypi.org/project/jiter/ done

Thank you so much!


add view

run tests

Pull Request Test Coverage Report for Build 18

6 of 11 (54.55%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 97.314%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

boards/views.py
6
11
54.55%

Totals

Change from base Build 19:
-0.6%

Covered Lines:
797

Relevant Lines:
819

💛  - Coveralls

run tests

run tests


Allow user defined id when adding dashboards & visualizations

Thanks for merging this! Do you have any plans for releasing the next version on pypi? I'm working on a project that depends on this and unfortunately it's still quite messy in Python to add dependencies from github repos.

You are welcome ) Thanks for contribution
I am rather new to pypi, what should I change/add?

Just bump up the version number and publish a new release that includes the latest code. The recommended way is to do it using twine https://packaging.python.org/tutorials/distributing-packages/#uploading-your-project-to-pypi

Got it. Sure I will release a new version now

Done. The version 0.1.1 is released :)


Re factor the way notifications are called

Make all the logic in the Notification service and define what notifications there are via an enum(at least the standard ones), also call the audioService from there.

Enum not viable really due to how different notifications are.


[HUDI-2099] Hive lock which state is WATING should be released, otherw…

…ise this hive lock will be locked forever
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
when we acquire hive lock failed and the lock state is WATING， we should release this WATING lock； otherwise this hive lock will be locked forever。
test step：
use hive lock to control concurrent write for hudi， let‘s call this lock hive_lock
start three writers to write hudi table by using hive_lock concurrently， one of the writer will failed to acquire hive lock due to competition issues。
Exception in thread "main" org.apache.hudi.exception.HoodieLockException: Unable to acquire lock, lock object LockResponse(lockid:76, state:WAITING)
start another writer to write hudi table by using same hive_lock， then we find hive_lock is locked forever, we have no way to acquire it
Exception in thread "main" org.apache.hudi.exception.HoodieLockException: Unable to acquire lock, lock object LockResponse(lockid:87, state:WAITING)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
new UT added。
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #3186 (4fa699a) into master (202887b) will increase coverage by 3.77%.
The diff coverage is n/a.

:exclamation: Current head 4fa699a differs from pull request most recent head cf3420f. Consider uploading reports for the commit cf3420f to get more accurate results

@@             Coverage Diff              @@
##             master    #3186      +/-   ##
============================================
+ Coverage     46.19%   49.96%   +3.77%
+ Complexity     5385      400    -4985
============================================
  Files           921       67     -854
  Lines         40040     2938   -37102
  Branches       4294      318    -3976
============================================
- Hits          18495     1468   -17027
+ Misses        19661     1334   -18327
+ Partials       1884      136    -1748

Flag
Coverage Δ

hudicli
?

hudiclient
?

hudicommon
?

hudiflink
?

hudihadoopmr
?

hudisparkdatasource
?

hudisync
?

huditimelineservice
?

hudiutilities
49.96% <ø> (-8.45%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ies/exception/HoodieSnapshotExporterException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/hudi/utilities/HoodieSnapshotExporter.java
5.17% <0.00%> (-83.63%)
:arrow_down:

...hudi/utilities/schema/JdbcbasedSchemaProvider.java
0.00% <0.00%> (-72.23%)
:arrow_down:

...org/apache/hudi/utilities/HDFSParquetImporter.java
0.00% <0.00%> (-71.82%)
:arrow_down:

...he/hudi/utilities/transform/AWSDmsTransformer.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...in/java/org/apache/hudi/utilities/UtilHelpers.java
40.69% <0.00%> (-23.84%)
:arrow_down:

...rg/apache/hudi/utilities/HoodieSnapshotCopier.java
0.00% <0.00%> (-13.80%)
:arrow_down:

...che/hudi/common/model/HoodiePartitionMetadata.java

...e/hudi/client/transaction/ConcurrentOperation.java

...he/hudi/common/model/EmptyHoodieRecordPayload.java

... and 850 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202887b...cf3420f. Read the comment docs.

@n3nash ， could you pls help me to reiview this pr， thanks

@n3nash  pls see the UT added。 when user2_lockProvider want to acquire lock， it will acquire waiting_state_lock first， and in the finally block released this waiting_state_lock。 it's no problem.

@n3nash I think this broke master, due to not rebasing for the config changes


e_subject_common_name_not_from_san is no longer sufficient for enforcing CABF BRs

This is my solution to the issue I raised #625.  I've gone with a straightforward fix by making the old lint ineffective from the 21st August 2021 and making a new lint which performs a case-sensitive string comparison between the common name and SAN dNSNames.  I have also refactored the tests on the original lint to use the de facto standard table approach because it allowed me to largely copy and paste the new tests I wrote for the new lint across with just some minor tweaks.
Comments for reviewers:

I'm not super fond of the name for the new lint so I'm open to suggestions as I really struggled to come up with something given that lint_subject_common_name_not_from_san is already taken and I can't just use a w_/e_ prefix as both old and new lint return errors!  Maybe a suffix of '_case_sensitive' would work better?
~I'm not familiar with all the lingo surrounding the CA/B forum so if someone can let me know what I should have called the CABFBRs_SC48_EffectiveDate variable then that'd be great!~ Thanks @sleevi!

I don't know how to comment on this so I'm going to have to abuse the format a bit:
https://github.com/zmap/zlint/pull/627#discussion_r699463497
I think this is the only open question remaining and unless you've had time to look further and determine strict confirmation either way then I can add the changes you recommend of putting "::ffff:0:0/96" into the list of reserved networks and add the comment text you proposed in also and we should be covered against those concerns.

Looks like you guys were busy yesterday!  Thanks everyone for all the reviews, comments and for the merge


Global installation

Would you recommend for or against global installation? i.e. pipx

No and since this tool only saves drive space & will sometimes remove packages that actually are being used, I wouldn't recommend using it everywhere anyhow. This is a cool, but probably "dangerous to use at work" hacking project.
I haven't tried, but pipx will put the tool into its own venv. So if you ran it it would only clean up the venv where pipx put crap. It would not have any effect on othe venvs.
The rule of thumb is, if a tool needs a live import of a module, then it needs to be installed in the same venv. So black is pipx installable, but mypy is not.


Don't assume HTMLElement is in the global scope

Instead uses globalObject.HTMLElement, to avoid breaking in a node environment where HTMLElement is not defined.

Thanks for the PR @jetpacmonkey. Could we also get some tests for this? Or some information on how you have come to reproduce the error?

@jetpacmonkey Could you provide a bit more detail about the problem you're running into, and the surrounding circumstances?
The lines you changed are currently only run when isDom is true. isDom is only true when globalObject contains a location and document property.  So it sounds like you have an environment that is browser-like, but lacking HTMLElement. But if that's the case, then although changing it to globalObject.HTMLElement will stop an error from being thrown, since it'll now reference undefined, the resulting logic doesn't really make sense, as it translates to obj instanceof undefined.

Hmm, you're right. I'm using jsdom in my test environment, and only put a few values from the window object (including location and document) into the global scope. I updated my dependency on Sinon, and suddenly all of my tests that use Sinon.match (which depends on this library) started breaking. I'd rather not copy the entirety of my jsdom window into global if I don't have to, since the writers of jsdom call it an antipattern.

only put a few values from the window object (including location and document) into the global scope

Do you need this in the global scope, given as you've already said this is an antipattern?

True, doing less of an antipattern is still an antipattern :)
I'll see if I can remember why I did that, and remove whatever's depending on it. Thanks for the quick responses!

@jetpacmonkey did you get anywhere with that? I think unless there's a super solid usecase for this, I'd rather close the PR. Thoughts?

I have the exact use case of @jetpacmonkey, I'm using jsdom, and whenever using sinon.match I get this error, see #98

See also: https://github.com/airbnb/enzyme/issues/888

I think enzyme might be the real problem here, since it expects to execute in a browser-like environment, and I haven't come across a great tool for sandboxing browser-like environments. Someone should write one of those...
Anyways, it appears that I don't have a great way to get around that antipattern. However, what's really confusing me right now is the fact that I'm not intentionally putting location onto the global scope in my test environment, as far as I can see. This is feeling more and more to me like a bad interaction between various testing libs, which would mean this PR probably isn't the best solution. But... I still don't know what the actual solution should be.

This appears to be relevant: https://github.com/airbnb/enzyme/blob/master/docs/guides/jsdom.md#describewithdom-api-and-clearing-the-document-after-every-test
Antipattern or no, a shared global DOM appears to be required for testing React components.

@jetpacmonkey I'm also not putting location into the global..
Resuming:
enzyme is suggesting us to do something that the jsdom docs tell us not to do saying that there is no better way at the moment to do this.
Now, apart from that, who is adding the location to the global? Apparently shouldn't be jsdom.
Mistery..
My configuration before loading the react tests:
const doc = jsdom.jsdom('<!doctype html>', {
  url: 'http://localhost'
});
const win = doc.defaultView;

// Setup for react test-utils 'renderIntoDocument':
// it requires window, window.document and window.document.createElement
// globally available before you can import React
global.document = doc;
global.window = win;
global.navigator = {
  userAgent: 'node.js'
};

@keithamus according to this comment from enzyme member he think this should be an issue of type-detect.
What do you think?
As temp fix until this will be solved I can only see an extra line in my config before running the tests:
// [...] continues from above comment
global.HTMLElement = win.HTMLElement;

So, the initial reason for not merging this PR as it was presented was that obj instanceof undefined "doesn't make sense". However, it does avoid things unexpectedly breaking, and it doesn't cause any false positives. The only case where it has any effect at all is arguably an antipattern, but it's also a pattern that's explicitly recommended by at least one popular testing library.
Plus, I'd argue that relying on implicit globals any more than is absolutely necessary is an antipattern itself. @keithamus thoughts?

at work so cant get into detail, but essentially the pr needs to be updated
so that the tests involving HTMLElement are skipped if its undefined.
checking if it's defined should occur at the top with all the other checks.
On Apr 17, 2017 9:41 AM, "Jeremy Tice"<EMAIL_ADDRESS>wrote:

So, the initial reason for not merging this PR as it was presented was
that obj instanceof undefined "doesn't make sense". However, it does
avoid things unexpectedly breaking, and it doesn't cause any false
positives. The only case where it has any effect at all is arguably an
antipattern, but it's also a pattern that's explicitly recommended by at
least one popular testing library.
Plus, I'd argue that relying on implicit globals any more than is
absolutely necessary is an antipattern itself. @keithamus
https://github.com/keithamus thoughts?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/chaijs/type-detect/pull/91#issuecomment-294487593,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQdhvd7NXKZ3PidrD78XpQBDPx5gcbKfks5rw2wQgaJpZM4MlwBg
.

Alright, I can do that.

I had two real concerns initially with the PR; one being I wasn't totally satisfied with why we should make the change, as it seems we have valid enough code. I'm satisfied now, however, that there is clear precedent for us to be more defensive.
My larger concern is that I'd like some tests to prevent regressions in future. However this is a simple enough change and has hung around for nearly a month so I'm willing to forgo the need for tests. I would however agree with @meeber - isDOM should probably also check for 'HTMLElement' in globalObject so skip those checks if we're in a faked out DOM like jsdom. Update this and I'm happy to merge.

You know, I just re-read what @LeonardoGentile wrote. Checking if it's in the globalObject won't actually solve anything, because when a Node environment adds window to the global scope, globalObject isn't actually the global object, it's global.window. I really think relying on something to be in global scope instead of explicitly reading it from globalObject is a mistake.

And I have no problem writing a couple of tests for this. I just wanted to make sure that this was a solution that you guys were ok with before I spent the time.

Upon further reflection, I think we should do two things here:

Improve type-detect's global object detection so that in Node it always uses global as the global object, even if global.window is defined. According to this post, a reliable option is: var globalObject = Function('return this')();

Make it so that browser-related type checks are only performed if ALL browser-related globals being used by type-detect are defined. If this is done, then it doesn't matter if HTMLElement or globalObject.HTMLElement is used for the actual equality comparison, since the equality comparison will only occur in the first place if HTMLElement has already been verified to exist.

Function('return this')();

has CSP issues, otherwise 👍

@meeber I pushed up a check that should do what you described. I suppose for the new tests, I'll just add a jsdom devDependency and re-run the node tests using that?

The funny thing is, with my original change, it actually wouldn't have been obj instanceof undefined, since globalObject was the jsdom window, so globalObject.HTMLElement probably would have been defined.

Oh, and apparently the linter hated that commit. Looks like it was disabled for that line anyways, before, so I guess I'll do that again.

@jetpacmonkey Thanks for working on this! Regarding tests: not sure how I feel about pulling in jsdom as a dependency. I think it's reasonable to fix this specific problem, but making "all tests must pass in jsdom" an absolute requirement for all future builds is a bit of a leap at this point. I'm not really sure at the moment what I think the best strategy is here. I'm not opposed to moving forward without additional automated tests for this. Thoughts @keithamus @shvaikalesh?

Okay I've modified the PR to fix up all the comments. I'm happy with this but I'll dismiss my PR as I've contributed. @shvaikalesh @meeber could you please check through this and if we're all happy with this we can squash and merge as a fix: commit to get it released.

I think we should avoid new Function (because of CSP) and do something like var globalObject = typeof self === 'object' ? self : global.

Okay @shvaikalesh how about this? Best of both worlds?

@shvaikalesh @keithamus Can you talk me through how the global object detection now works?

@meeber
current code:
var globalObject = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : self;

PR:
var globalObject = typeof self === 'object' ? self : global;

Kinda the same thing, except that the latter option relies on self == window.

Okay, updated. We should be good now right? Whoever merged don't forget to squash+merge as fix:

The build failed because of ESLint errors
/home/travis/build/chaijs/type-detect/index.js
   9:47  error  'self' is not defined    no-undef
  16:17  error  'window' is not defined  no-undef
  17:18  error  'window' is not defined  no-undef
  18:20  error  'window' is not defined  no-undef

It would be easy to fix this with a few well placed comments:
// eslint-disable-next-line no-undef id-blacklist
var globalObject = typeof self === 'object' ? self : global;
/*
 * All of these attributes must be available on the global object for the current environment
 * to be considered a DOM environment (browser)
 */
/* eslint-disable no-undef */
var isDom = typeof window === 'object' &&
  'document' in window &&
  'navigator' in window &&
  'HTMLElement' in window;
/* eslint-enable no-undef */

Who can fix the branch, so we can get this merged?

@meeber @shvaikalesh shall we get this reviewed and merged?

Is there any plausible scenario in which isDom gets set to true (because window is an object and has the document, navigator, and HTMLElement properties), but globalObject gets set to something other than window on line 11? If so, then the code won't behave as expected.

Perhaps this is a bug, like the one is this PR, which we'll cross when someone experiences it. While technically possible, I doubt we'll ever see it - if someone is trying to emulate the DOM it's probably a mistake to be missing self.

Thank you 💯
It would be great if someone could publish a new release to npm

@gpoole I think we can make a release as soon as #112 gets merged

Ah perfect, thanks @vieiralucas!

@gpoole @chaijs/type-detect v4.0.4 just got released


Fix UTF-8 and add support for more §

Add support for UTF-8. (When my server sent some Chinese characters to mcrcon I found that there were some problem , so I try to fix it. );
Add support for §l , §m , §n , §r .
I use a red background color to replace $m and a highlight to replace $l.
But I can't find how to deal with §o . I think that it is not a good idea to use background color.

Sorry for my bad English and you can tell me my errors, thanks.

I find that it is not good to do anything for $l and $m. Especially $l is.
Sorry for my bad English again.


Add TZ envvar to default chart values

When attaching lubridate, users will often see an error like:
> library(lubridate)
System has not been booted with systemd as init system (PID 1). Can't operate.
Failed to connect to bus: Host is down

Warning message:
In system("timedatectl", intern = TRUE):
  running command 'timedatectl' had status 1

Investigation reveals this is related to https://github.com/rocker-org/rocker-versioned/issues/242
I'd suggest we set the TZ envvar to UTC by default in PWB and PC containers so users don't see this confusing error.

FYI this is now set by default in the upstream containers: https://github.com/rstudio/rstudio-docker-products/pull/725

Closing as its resolved upstream!


Convert SignFile to an exception filter

This reduces code complexity and might make callstacks easier to decode.

LGTM

@dotnet-bot test Windows_NT Build please


added kafkametricsreceiver

Adding the kafkametricsreceiver which should allow us to ingest kafka consumer lag

Any ideas on how I can fix the failing test?

Ah needs to be added to this list https://github.com/signalfx/splunk-otel-collector/blob/main/internal/components/components_test.go#L42

Hmm, it should be there in the files I've committed. No dice.

Oh it's because the actual receiver name is kafkametrics :-P

Oh, let me try that, thanks Jay


Provide a more accurate error description for SLO validation issues

Is your feature request related to a problem? Please describe.
I misconfigured the dynatrace secret but the error message said I was missing the secret.  I had mistakenly used the variable name DT_URL versus DT_TENANT which is expected
Describe the solution you'd like
Have the service provide a more accurate message, like missing literal DT_TENANT
Describe alternatives you've considered
None
Additional context
Here is picture of error message

Here is the wrong value (but the secret was created OK)
keptn create secret dynatrace --from-literal="DT_URL=abc" ....
versus this that is the required name
keptn create secret dynatrace --from-literal="DT_TENANT=abc" ....

@oleg-nenashev  @johannes-b  - This may now be part of the some other issues, but if the output for error messages are the same then perhaps we can still keep this one open.

This is a message provided by the integration, not by Keptn


Prototype?

https://github.com/tdolphin-org/AmigaOS.MUI.cpp.wrapper/blob/10ecb6c1a96a1084e2a1a99e7235436b67fffad8/examples/basic/Main.hpp#L11
https://stackoverflow.com/questions/38543876/prototype-of-main-function-in-c-or-c

@polluks could You clarify what is wrong with having declaration of main() in header?

removed unnecessary prototype of main()
https://github.com/tdolphin-org/AmigaOS.MUI.cpp.wrapper/commit/510f4580842a0971b22ae70bb2ef5f7608bb0860


Create a health-check endpoint that uses IP Safelisting

This will allow provinces such as Ontario to not have to rely on regenerating OTK's as a health check.

This is nice to have, quality of life.

Would be nice but PTs don't seem open to the idea will re-open if the need arises.


[Core/Bugfix] Add FP8 K/V Scale and dtype conversion for prefix/prefill Triton Kernel

Fix the FP8 Triton kernel issue. Should enable FP8 KV Cache to be used with:

chunked prefill
prefix caching

FIX https://github.com/vllm-project/vllm/issues/4381 https://github.com/vllm-project/vllm/issues/3880 https://github.com/vllm-project/vllm/issues/3156 https://github.com/vllm-project/vllm/issues/3880
TODO:

[x] Undo guards: https://github.com/vllm-project/vllm/pull/3903
[x] Regression test: https://github.com/vllm-project/vllm/issues/4381#issuecomment-2271579989

Notes:

@comaniac mentions upcoming flashinfer support, but I think supporting it in Triton as fallback is good for users who want to avoid installing heavyweight dependency
Regarding correctness, you can see that this PR merely brings up triton kernel to parity with vLLM's custom torch CUDA paged attention kernels: https://github.com/vllm-project/vllm/blob/a3bbbfa1d8c2f30581d37c6f30429d648bbbf87c/csrc/attention/attention_kernels.cu#L287,  https://github.com/vllm-project/vllm/blob/a3bbbfa1d8c2f30581d37c6f30429d648bbbf87c/csrc/attention/attention_kernels.cu#L417, where scaled_convert is defined as:
https://github.com/vllm-project/vllm/blob/a3bbbfa1d8c2f30581d37c6f30429d648bbbf87c/csrc/quantization/fp8/nvidia/quant_utils.cuh#L299

Example Output (decode v.s. chunked prefill with FP8 KV Cache):

Performance is similar to decode in low load case on max_chunk=16,max_sequence_len=512

I attribute the slightly lower perf to lack of perf tuning of the triton kernels

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

CC: @comaniac

/ready

@comaniac how can I trigger the CI? I have no dev env for vllm currently

The CI is already triggered.

I guess it is waiting for a runner to schedule buildkite/ci-aws/pr?

Turns out I actually needed to push new commit after converting from draft status to trigger CI

Hmm, actually; shouldn't Triton have support for mixed FP8 matmul?
https://github.com/triton-lang/triton/blob/194a00f0f54ecd85dba202d840242c5f3f72b068/test/TritonGPU/prefetch.mlir#L14
Anw, this is a story for next time; as we first need to ask users if they want to enable lower precision matmul with one operand in FP8

Should be working now:

/ready

Performance is similar to decode in low load case on max_chunk=16,max_sequence_len=512

@comaniac all tests pass

Hi, @jon-chuang. Thanks for your contributions.
The code in #3234 is too old to merge. I'll close #3234 once this PR done.

Can not work on NVIDIA Ampere GPU, like 3090.

Can not work on NVIDIA Ampere GPU, for example 3090.

Unfortunate limit of Triton

Can not work on NVIDIA Ampere GPU, for example 3090.

Unfortunate limit of Triton

Does #5975 help for this?

Can not work on NVIDIA Ampere GPU, for example 3090.

Unfortunate limit of Triton

Does #5975 help for this?

No it's for GEMM, not attention.

btw did you test on H100?

Yes tested locally on H100.

@comaniac should be ready for merge

Thank you @comaniac. Need your help to merge as I have no write access.

@jon-chuang Is this to-do fixed with this MR?
https://github.com/vllm-project/vllm/blame/main/vllm/attention/backends/xformers.py#L601

Yes, the comment should have been removed

Yes @chenxu2048


Rework build system

Tasks/goals:

create a BUILDING.md file with clear instructions
clarify/fix compilation with statically or dinamically linking (make build/make build-nostatic)
compile binaries under docker (after tests) so that docker images and binaries are compiled the same way
remove useless Makefile targets

Work was also made in commits:
34f86aa6
9dc01c46
67df89cd
340525c6

Released in v0.15.0


feat: Configurable tool button style melodic

Same as #1307 for melodic

Can this one be merged as well?


Unexpected EOF reached before read buffer was filled.

Hi Pedro Sánchez,
I am developing a Streaming App in Ionic for which i am developing a Cordova Plugin by referencing your code. Every thing looks good. Encoders are working good.
But, while connecting to Rtmp Server ( Youtube ) i am getting error "Unexpected EOF reached before read buffer was filled".
Digging Further into code.
PATH of issue.
connect(String url)  ->
handleRxPacketLoop() ->
rtmpDecoder.readPacket(inputStream) -->
RtmpHeader.readHeader(in, rtmpSessionInfo)-- >
Util.readBytesUntilFull(in, messageStreamIdBytes)  ->this throws Error.
I'm new to android and Sockets. Can you please help me Fix this issue?

Hi,
You have an error reading stream packet id necessary to create a packet and response to server.
Do you have this error always?
Can you share a logcat of your connection to know in which part of the connection it fails?
Also, if you can try with other network to discard internet problems.

I fixed that issue, i think i just missed some code as well as internet issues.
But now i am having another issue now.
Video packets are sent for some time and then they only audio was sent.
Attached adb Logs
logs.txt
.

Did you tried with my app example to discard problems with implementation?
Can you share example code used?
Which mode are you using? (camera1, camera2, display or from file)

my implementation consists of only display.
it worked once got stream up and running for 26sec and then video data was not uploading.
up from 2nd use data was not going i'm getting the same logs every time as above only few frames of video(Dislpay) from then no video data was uploaded.

Maybe your error is this:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/63
MediaProjectionManager API of android never render a frame if you are not doing something in your screen

is it something like keepAliveTrick() in DisplayService.kt?

worked like a charm.
can we add an overlay for stream with current implementation?
Thnq for such a awesome project and much greater support.
As you are expert in Android.
One last out of box question
i saw an application which is displaying entire mobile screen inside of the app's main activity/view.
and that to without asking permission for screen capture(media projection).
If possible can you explain me how to achieve that?

You can add an overlay with filters (necessary use opengl constructor in true):
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/app/src/main/java/com/pedro/rtpstreamer/openglexample/OpenGlRtmpActivity.java#L293
About your second question it is possible if you are recording only your own app because you can use canvas to get frames of your view like I'm doing in AndroidViewFilter:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/encoder/src/main/java/com/pedro/encoder/input/gl/render/filters/AndroidViewFilterRender.java

Thnq so much for the Help.


Publish 05/06/2022 3:30 PM PT

Docs Build status updates of commit 42c4ed0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisCivicAddress.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Feature/style overhaul

[ ] implement grid layout for headers and body content
[ ] color adjustments in headers/footers
[ ] new background image with correct size for application
[ ] fonts!

opened to master in error. closing.


[CT-1902] [Feature] Add relation_name to the node_info dictionary

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
As described by @jtcohen6 here this feature would:

Add relation_name (database.schema.identifier) to the node_info dictionary, which is present on all node-related logging events, and offers a convenience for looking up the most salient information. (The rest can be looked up in the manifest, using the node's unique_id.)

This would provide a mapping from relation_name → node unique_id (or vice versa). Other properties can be looked up via the node's unique_id within manifest.json.
Describe alternatives you've considered
I'm not aware of any reasonable alternatives to determine the final database.schema.identifier for a model that has been built.
For those who love a good unstructured text parsing challenge, I suppose they could try to extract this from logs/dbt.log somehow.
Who will this benefit?
There is at least one issue where a user wants to monitor logs for successful model execution and trigger another process downstream:

https://github.com/dbt-labs/dbt-core/issues/6712

Are you interested in contributing this feature?
No response
Anything else?
No response

For refinement:

When writing relation_name (and database, schema, identifier components) to the node_info dictionary, do we need to worry about case-sensitivity and/or quoted identifiers?

e.g., would we want to write out quoting also?
I'm guessing a consumer of this info will want to compare relation_name, etc for equality. I'm assuming case-sensitivity, quoting, and database-specific casing of unquoted identifiers would effect those comparisons.

@dbeatty10 Sorry, I missed your comment before resolving this in #7304!
The approach we're taking right now:

database, schema, alias are just the values (no quoting applied)
relation_name will be the full string representation, which respects "include" and "quoting" policies

We could add quoting as a standalone property in the future, but I think this strikes a nice balance for now, and matches what's available in the manifest

No worries!
Agreed that this strikes a nice balance:

relation_name will be the full string representation, which respects "include" and "quoting" policies


Workaround with tailwindcss lsp

Is there a known way to make the syntax highlighting work so that the tailwind autocomplete would work also in template files?

Isn't autocompletion part of a LSP?

autocmd BufRead,BufEnter *.component.html set filetype=angular in ftdetect/angular.vim works also to get the highlighting. But I don't get the tailwind autocomplete with either method.

I'm facing similar problems.
With the fix mentioned by @Ask-786 I'm getting the wrong hover results when trying to hover tailwind classnames.
Could you share the full example of your setup with tailwind?

Hi @JoschuaSchneider,
That's all I do regarding file type setup. It's still buggy, though. You have to open any TypeScript file before going into a template for the Tailwind LSP to work correctly.
If you need more details, You can check out my nvim config repo here: nvim.

Thanks for the quick response @Ask-786 !
My problem was that I still had the setup steps from the docs present. I replaced it with your autocmd snipped and now both is working for me.
Thank you!
For anyone wondering, here is my full plugin code for this module using your fix:
return {
  {
    'dlvandenberg/tree-sitter-angular',
    dependencies = {
      'nvim-treesitter/nvim-treesitter',
    },
    config = function()
      vim.api.nvim_create_autocmd({ 'BufRead', 'BufEnter' }, {
        group = vim.api.nvim_create_augroup('set-angular-filetype', { clear = true }),
        pattern = '*.component.html',
        callback = function()
          -- Necessary for angular lsp to get attached.
          vim.cmd [[set filetype=html]]
          vim.cmd [[set filetype=angular.html]]
        end,
      })
    end,
  },
}

I think you don't need to  explicitly install tree-sitter-angular @JoschuaSchneider .
It just get installed automatically when you enter a template file.
Sorry for the "Quick" reply by the way. was out of office for last few days.

In the nightly neovim build, filetype detection is added for Angular Templates.
Filetype is htmlangular. Please adjust your LSP config accordingly.
You need to update to the latest nvim-treesitter version also, as the angular parser is coupled to the new filetype.

I've created a pull request to nvim-lspconfig, and it got merged today. You can check it out here: https://github.com/neovim/nvim-lspconfig/pull/3240#event-13568102368. With this update, there's no need for any extra configurations for LSPs (emmet_language_server, emmet_ls, angularls and tailwindcss).
note:  as mentioned by @dlvandenberg, you need the nightly neovim build for this.