Mimir testing

Motivation
n order to raise our confidence in the stability of our observability platform and be sure that our ongoing work and releases won't negatively impact our observability platform operations we need to create extensive tests giving us early feedback loops. As mimir is one of our core components, we should make sure it's thoroughly tested.
Todo

[ ] Investigate some good initial test cases to give us feedback on the stability of a release on mimir on CI. This can be:

Validate Helm chart templating
Deploy chart on Kind (single instance)

[ ] Implement those CI test cases

[ ] Investigate some good initial test cases to give us feedback on the stability of a release before releasing. This can be:

Deploy chart on AWS, Azure, CAPI (later)
Integration test; Verify all component work together
Using canary to generate traffic

[ ] Implement those test cases

Make sure to stay with a set of minimal but valuable test cases, nothing to detailed and fancy.
Outcome

We have early, automatic feedback about the impact of a release of Mimir before releasing.

I think it would be nice to run mimir continous testing (similar to loki canary) for e2e tests

Yeah that's a nice idea :)

I am running mimir continuous_test on grizzly with the following config:
mimir:
  continuous_test:
    enabled: true
    auth:
      tenant: anonymous

and this renders the following metrics:

and we could just use those alerts https://github.com/grafana/mimir/blob/f52911d917c8c52e0da6a59348a64dd7f7622072/operations/mimir-mixin-compiled/alerts.yaml#L1097
The only downside is that we need to wait for the next minor helm chart release or use a weekly version because this https://github.com/grafana/mimir/pull/8654 is not yet released

So what's the best plan of action IMO is to wait for the continuous testing to be a default config for our mimir before doing anything else.
In the meantime, I'll create a dashboard using the metrics from the rules' mixins and if it's good enough, I'll think about pushing it upstream as a mixins dashboard.

I think so yes, maybe we can have a pr ready with the alerts? The mixins contains some that could be useful

@QuantumEnigmaa we decided in retro to use the chart version rc0 for now but keep the old image of mimir 2.13

We can start this again once we're done with multi-tenancy :)

Taken over the dashboard PR https://github.com/giantswarm/dashboards/pull/624 to close the epic

Blocked waiting for reviews

Continuous test is enabled:
Dashboard PR has been merged:

https://github.com/giantswarm/dashboards/pull/624

Alert based on failures under review:

https://github.com/giantswarm/prometheus-rules/pull/1355

All is done. Thanks @hervenicol for the reviews


Update 'Feeling curious?' tags in Works Landing

As Hayley noted in our May Analytics report, our users are using the tags (e.g. Paintings, Health, Botany, Science) on Works landing to discover the collections. We haven’t updated since we launched it last year and could use some refresh. It would be great if the result represent diverse topics or formats.
Suggestions: Eadweard Muybridge, John Thomson Glass plates, Death, Medieval, Surgery, Woodcuts, Illustrations

Consider using Harrison's image colour browser or image similarity experiments

New idea from Beta Release discussions:
Featured set of items to reflect our collection, that helps users to see what they can find in our collections. (New release will have Digital images, Pictures, and Books).

@jennpb I've updated the list based on the suggested topics from Collection Info team and Alice.


☂ Help us Kotlin-ify React Native tests - Round 2

☂ Help us Kotlin-ify React Native tests - Round 2
Hey all 👋
After the successful first round, we're back with another round of tasks to help us improve Kotlin support in React Native core. In this first stage we are looking for help to migrate tests and RN Tester to Kotlin.
How to work
If you wish to grab one of the task you should:

Verify that the task is not claimed yet.
Comment here that you claim a task.
Start working on the task. Testing instructions are below.
Send the PR for review. Ping @cortinico and @mdvacca for a review.
You can’t claim more than one task at a time.
If you’re not completing the task within a week, we’ll release it for the next contributor.

Code formatting
Please use KtFmt to format Kotlin tests.
You can use the web UI to reformat directly from the browser
[Easy] Migrating RN Tester to Kotlin
We’re looking into migrating our Sample App to Kotlin.
Please act as follow:

Fork and clone the repo
Verify that RN Tester runs with yarn && yarn android from the root folder
Migrate the file to Kotlin
Verify that RN Tester runs again using the same command.

List of files to migrate

[ ] RNTesterActivity.java assigned to @Randall71
[ ] RNTesterApplication.java assigned to @oliverloops
[ ] RNTesterReactHostDelegate.java assigned to @fabiansolheim
[ ] component/MyNativeView.java assigned to @BogiKay
[ ] component/MyNativeViewManager.java assigned to @tarunrajput
[ ] component/MyLegacyViewManager.java assigned to @imalgrab

[Hard] Migrating tests to Kotlin
We’re looking into migrating some of our production tests to Kotlin. Please note that some of those tests are @Ignore (so they’re not running). Your task would be to fix them and convert them to Kotlin.
Please act as follow:

Fork and clone the repo
Install the dependencies with yarn from the root repo.
Verify that tests are running green with: ./gradlew :packages:react-native:ReactAndroid:test
Remove the @Ignore annotation on the class/tests
Fix the test so that it’s green
Migrate the file to Kotlin
Verify that the tests are still green by using the command above.

List of tests to migrate

[ ] react/devsupport/JSDebuggerWebSocketClientTest.java assigned to @stewartsum
[ ] react/modules/network/NetworkingModuleTest.java assigned to @gerald-wambui
[x] react/uimanager/BaseViewManagerTest.java assigned to @retyui
[x] react/uimanager/JSPointerDispatcherTest assigned to @siddarthkay
[ ] react/uimanager/LayoutPropertyApplicatorTest assigned to @kevinah95
[ ] react/uimanager/MatrixMathHelperTest assigned to @fabioh8010
[ ] react/uimanager/ReactPropAnnotationSetterSpecTest
[ ] react/uimanager/ReactPropAnnotationSetterTest
[ ] react/uimanager/ReactPropConstantsTest assigned to @thiagobrez
[ ] react/uimanager/ReactPropForShadowNodeSetterTest
[ ] react/uimanager/ReactPropForShadowNodeSpecTest assigned to @agrittiwari
[x] react/uimanager/SimpleViewPropertyTest assigned to @sapkotamadhusudan
[ ] react/uimanager/UIManagerModuleConstantsTest assigned to @giolaq
[ ] react/uimanager/UIManagerModuleTest assigned to @shibasis0801
[x] react/views/image/ImageResizeModeTest assigned to @atlj
[x] react/views/image/ReactImagePropertyTest assigned to @bufgix
[x] react/views/text/CustomLineHeightSpanTest assigned to @tarunrajput
[ ] react/views/text/ReactTextTest assigned to @mateusz1913
[ ] react/views/textinput/ReactTextInputPropertyTest assigned to @yasincidem
[ ] react/views/textinput/TextInputTest assigned to @fathonyfath
[ ] react/views/view/ColorUtilTest assigned to @okwasniewski

www.vgtnyc.com

👋 I would like to claim react/views/text/ReactTextTest

Hey! I can work on react/views/view/ColorUtilTest

Hey, I can grab react/views/image/ImageResizeModeTest

for me please react/uimanager/BaseViewManagerTest.java

Hey 👋, i can work on https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/TextInputTest.java

Hey 👋 I can work on react/uimanager/MatrixMathHelperTest

@mdvacca, I'd like to migrate react/views/text/CustomLineHeightSpanTest

Hi @mdvacca : I'd like to migrate react/uimanager/JSPointerDispatcherTest Please assign it to me :)

Hi, I'd like to work on react/views/textinput/ReactTextInputPropertyTest

Hey 👋🏻 , I can work on react/uimanager/ReactPropConstantsTest

alos, can do react/views/textinput/TextInputTest

Hi, i can work on react/uimanager/SimpleViewPropertyTest

Hey, I'd like to work on component/MyLegacyViewManager.java

Next, I'd like to convert component/MyNativeViewManager.java

Hi, i can work on RNTesterActivity.java

Hey i'd like to work on RNTesterReactHostDelegate.java!

Hey can I work on RNTesterReactHostDelegate.java
?

Hey 👋, I'd like to claim RNTesterReactHostDelegate.java

Hello team 👋, I can work on RNTesterApplication.java  ☂

@KhatriSahil2799, @morgan4080, RNTesterReactHostDelegate.java was previously requested.
Would you like to pick any unassigned test?

Yes, I will. Let me take a look.

Hello team, I can work on react/uimanager/LayoutPropertyApplicatorTest.

Hi, can I work on the https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/TextInputTest.java test? Thank you! :)

I acclaim

I acclaim
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/NetworkingModuleTest.java

👋 Can I work on react/uimanager/UIManagerModuleConstantsTest ?

Can I work on uimanager/UIManagerModuleTest.java

Hey all,
I've assigned all the requested tasks so far 👍

I will take a stab at https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/JSDebuggerWebSocketClientTest.java if it is still up for grab.

I want to work on react/uimanager/ReactPropForShadowNodeSpecTest

Hey @mdvacca @cortinico , I might need some guidance on migrating react/views/textinput/TextInputTest.
I tried to fix some PowerMock issue by replacing the thenReturn call with thenAnswer. I've verified that the mocked function ReactChoreographer.getInstance() is called correctly (commit https://github.com/fathonyfath/react-native/commit/3cf29ef5cc5cca65cd919cb07ffe8b2a0d998e32). But then when running the test I receive this linker error related to Yoga:
java.lang.UnsatisfiedLinkError: no yoga in java.library.path: [/Users/name/Library/Java/Extensions, /Library/Java/Extensions, /Network/Library/Java/Extensions, /System/Library/Java/Extensions, /usr/lib/java, .]
	at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2678)
	at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830)
	at java.base/java.lang.System.loadLibrary(System.java:1886)
	at com.facebook.soloader.SoLoader.loadLibraryOnNonAndroid(SoLoader.java:926)
	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:882)
	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:869)
	at com.facebook.yoga.YogaNative.<clinit>(YogaNative.java:16)
	at com.facebook.yoga.YogaConfigJNIBase.<init>(YogaConfigJNIBase.java:23)
	at com.facebook.yoga.YogaConfigJNIFinalizer.<init>(YogaConfigJNIFinalizer.java:12)
	at com.facebook.yoga.YogaConfigFactory.create(YogaConfigFactory.java:12)
	at com.facebook.react.uimanager.ReactYogaConfigProvider.get(ReactYogaConfigProvider.java:20)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.<clinit>(ReactShadowNodeImpl.java:62)
	at com.facebook.react.uimanager.UIImplementation.createRootShadowNode(UIImplementation.java:96)
	at com.facebook.react.uimanager.UIImplementation.registerRootView(UIImplementation.java:150)
	at com.facebook.react.uimanager.UIManagerModule.addRootView(UIManagerModule.java:358)
	at com.facebook.react.uimanager.UIManagerModule.addRootView(UIManagerModule.java:316)
	at com.facebook.react.views.textinput.TextInputTest.testPropsApplied(TextInputTest.java:99)

I found some information that we're unable to load native lib using Robolectric runner: https://github.com/robolectric/robolectric/issues/1171
I tried to use SoLoader.setInTestMode(); regardless (commit: https://github.com/fathonyfath/react-native/commit/e12ca52e27fcd0df44cad22c6c7ae700b7f2d355). But now I receive an error with this stacktrace:
java.lang.UnsatisfiedLinkError: 'long com.facebook.yoga.YogaNative.jni_YGConfigNewJNI()'
	at com.facebook.yoga.YogaNative.jni_YGConfigNewJNI(Native Method)
	at com.facebook.yoga.YogaConfigJNIBase.<init>(YogaConfigJNIBase.java:23)
	at com.facebook.yoga.YogaConfigJNIFinalizer.<init>(YogaConfigJNIFinalizer.java:12)
	at com.facebook.yoga.YogaConfigFactory.create(YogaConfigFactory.java:12)
	at com.facebook.react.uimanager.ReactYogaConfigProvider.get(ReactYogaConfigProvider.java:20)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.<clinit>(ReactShadowNodeImpl.java:62)
	at com.facebook.react.uimanager.UIImplementation.createRootShadowNode(UIImplementation.java:96)
	at com.facebook.react.uimanager.UIImplementation.registerRootView(UIImplementation.java:150)
	at com.facebook.react.uimanager.UIManagerModule.addRootView(UIManagerModule.java:358)
	at com.facebook.react.uimanager.UIManagerModule.addRootView(UIManagerModule.java:316)
	at com.facebook.react.views.textinput.TextInputTest.testPropsApplied(TextInputTest.java:99)

The UIManagerModule class is being used in the following test that also is on the following tests:

react/views/text/ReactTextTest
react/uimanager/UIManagerModuleTest

cc: @mateusz1913 @shibasis0801
I believe the above tests also suffer from the same issue. How should we proceed with migrating those tests? Should we move those to instrumented tests?
I'm sorry I don't have extensive knowledge on the react-native codebase.

👋 @mdvacca @cortinico
I confirm I have similar issues with react/views/text/ReactTextTest.
Following up on what @fathonyfath wrote, I tried to mock Yoga parts as much as I could, which succeeded by throwing next error:
java.lang.AssertionError: Root node with tag 11 doesn't exist
	at com.facebook.infer.annotation.Assertions.assertNotNull(Assertions.java:19)
	at com.facebook.react.uimanager.UIImplementation.createView(UIImplementation.java:235)
	at com.facebook.react.uimanager.UIManagerModule.createView(UIManagerModule.java:419)
	at com.facebook.react.views.text.ReactTextTest.createText(ReactTextTest.java:529)
	at com.facebook.react.views.text.ReactTextTest.testFontSizeApplied(ReactTextTest.java:148)
...

it was caused by context.runOnNativeModulesQueueThread method insideUIImplementation.registerRootView not being run and not registering the root view shadow node (the rootview created inside the test) - it seems that ReactTestHelper.createCatalystContextForTest doesn't handle mocking that method
For testing purposes, I moved the shadow node registration outside of the context.runOnNativeModulesQueueThread so that in the test it runs immediately instead of being scheduled on the main thread (which does not run). This resulted in another error:
java.lang.RuntimeException: Cannot add a child that doesn't have a YogaNode to a parent without a measure function! (Trying to add a 'RCTRawText [text: test text]' to a '[RCTText 12]')
	at com.facebook.react.uimanager.ReactShadowNodeImpl.addChildAt(ReactShadowNodeImpl.java:223)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.addChildAt(ReactShadowNodeImpl.java:56)
	at com.facebook.react.uimanager.UIImplementation.manageChildren(UIImplementation.java:406)
	at com.facebook.react.uimanager.UIManagerModule.manageChildren(UIManagerModule.java:469)
	at com.facebook.react.views.text.ReactTextTest.createText(ReactTextTest.java:532)
	at com.facebook.react.views.text.ReactTextTest.testFontSizeApplied(ReactTextTest.java:148)

The virtual text (child) does not have yoga node, so here the real text (parent) should have the measure function set, which for unknown reason is not happening during the test.
At that moment I am lost and need a help in how to proceed. Should we use/implement some test/mocked uimanager instance or like @fathonyfath suggested move those to instrumented tests?

I have similar issues (like @fathonyfath, @mateusz1913) with react/uimanager/LayoutPropertyApplicatorTest.
I tried the same config like @mateusz1913 and a combination with SoLoader.setInTestMode(); of @fathonyfath. This resulted in another error too:
java.lang.AssertionError
	at com.facebook.infer.annotation.Assertions.assertNotNull(Assertions.java:31)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.getViewClass(ReactShadowNodeImpl.java:148)
	at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateShadowNodeProp(ViewManagersPropertyCache.java:128)
	at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackShadowNodeSetter.setProperty(ViewManagerPropertyUpdater.java:169)
	at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:72)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.updateProperties(ReactShadowNodeImpl.java:322)
	at com.facebook.react.uimanager.ReactShadowNodeImpl.updateProperties(ReactShadowNodeImpl.java:322)
	at com.facebook.react.uimanager.LayoutPropertyApplicatorTest.testDimensions(LayoutPropertyApplicatorTest.kt:92)
	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:580)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:287)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:99)

@cortinico  I claimed this react/uimanager/ReactPropForShadowNodeSpecTest.java, but can't generate build from source and found that there's an activeissue regarding the same. I am stuck at this open  issue #37770 . Would love to work on something else soon, but for now you can assign the test to someone else.

@agrittiwari Did you try these steps?

Please act as follow:

Fork and clone the repo
Install the dependencies with yarn from the root repo.
Verify that tests are running green with: ./gradlew :packages:react-native:ReactAndroid:test
Remove the @Ignore annotation on the class/tests
Fix the test so that it’s green
Migrate the file to Kotlin
Verify that the tests are still green by using the command above.

@agrittiwari Did you try these steps?

Please act as follow:

Fork and clone the repo
Install the dependencies with yarn from the root repo.
Verify that tests are running green with: ./gradlew :packages:react-native:ReactAndroid:test
Remove the @Ignore annotation on the class/tests
Fix the test so that it’s green
Migrate the file to Kotlin
Verify that the tests are still green by using the command above.

It works for me.

I'll try the last one. Thanks.

I can have a look at fixing react/uimanager/ReactPropAnnotationSetterTest

@cortinico I claimed this react/uimanager/ReactPropForShadowNodeSpecTest.java, but can't generate build from source and found that there's an activeissue regarding the same. I am stuck at this open issue #37770 . Would love to work on something else soon, but for now you can assign the test to someone else.

@agrittiwari I've released your test, thanks for the heads up. I'm working on a fix to make it easier to run those builds on Windows which will make it easier for you to contribute:

https://github.com/facebook/react-native/pull/38886
The fix is not landed yet.

As for the issue reported by @kevinah95 @fathonyfath and @mateusz1913:
You should be able to use the Shadow SoLoader like here:
https://github.com/facebook/react-native/blob/4dbf5dca7ab77deee734dd033a1e5350dfdc6764/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.kt#L21
If that doesn't work, please open a PR with what you were able to achieve so far, ping @mdvacca and me and we'll try to see what's happening. Let's move the conversation there for specific problem on a test as otherwise we'll ping everyone in this thread here.

@cortinico I am facing the same issues with Yoga not being available in the unit tests.
I have tried the workarounds @mateusz1913 @fathonyfath and @kevinah95 have demonstrated and reproduced the same results.
I'm also new to the react native code base, but I feel these should be moved to instrumentation tests.
As even if we mock everything and make the tests green, I'm not sure what they would be testing.
I am not clear how to proceed from here, I would like to release my test.

Sorry for the noise ^ please ignore. Was trying to silently help.

Hey! I want to work on react/uimanager/ReactPropForShadowNodeSetterTest

Hi, my PR for react/uimanager/MatrixMathHelperTest got merged. Could I take react/uimanager/ReactPropAnnotationSetterSpecTest now?

Hi, I can work on react/uimanager/UIManagerModuleTest if it has not been claimed yet 🙂

hey i would like to claim react/uimanager/ReactPropForShadowNodeSpecTest

@IzuEneh, I assigned ReactPropForShadowNodeSpecTest to you

Hi @mdvacca : I'd like to assist again and claim any one of the tasks that have been claimed but no PR is out yet. Can we free up those tasks?
an example which I noticed is RNTesterActivity.java

Hey all,
I'm releasing the files assigned to @Randall71 @oliverloops @gerald-wambui @kevinah95 @amrfarid140 @junaidn @AntoineDoubovetzky @fathonyfath as we haven't received any PR for those files (if this was not the case, or if you had difficulties converting some of the tests, please let me know).
Feel free to comment here if you want to have it re-assigned to you.
This will allow other contributors to pickup those files if they wish.

Hey! 👋 I can work on RNTesterActivity.java

Hello @cortinico,  I was assigned to RNTesterApplication.java I converted the file to kotlin but I have some troubles running the tests, i'm still not confident enough with the changes to open a PR

@oliverloops the RNTesterApplication.java file requires only that you launch the RN Tester app with yarn android. Please send over the PR you have and we can look into it.

Hi @cortinico : I'd like to try fixing react/views/textinput/TextInputTest

Hi @cortinico, I started working on react/uimanager/UIManagerModuleTest, I'd like to continue if that's ok.

Hi @cortinico, I see that react/uimanager/LayoutPropertyApplicatorTest is not assigned to anyone yet. Can I take up the task?

Hi @cortinico , I'd like to work on RNTesterApplication.java

Hey, I would like to work on react/modules/network/NetworkingModuleTest.java

Hi @mdvacca, I would like to work on react/views/text/ReactTextTest

@cortinico need your help. I am stuck with the error Task :packages:react-native:ReactAndroid:buildCodegenCLI FAILED
/bin/bash: line 1<EMAIL_ADDRESS>No such file or directory, when I run this command ./gradlew :packages:react-native:ReactAndroid:test.

@cortinico Yeah, I have run yarn add -W package.json but still ends with the same error.

@PanchumarthiAbhinav I believe the issue you're having is because you're building on Windows. Currently we support contributing to React Native only on Linux and Mac machines. We're looking into removing those blockers in the future.

okay, I get it.  Then I shall try to setup WSL2 in my system. You can remove the work assigned to me.

Hi @mdvacca ,
I would like to claim react/uimanager/ReactPropAnnotationSetterTest

I am trying to run testcases on main repo, I have Mac M1 but still getting this issue. Any idea or suggestion?
> Task :packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes FAILED

I have done yarn on root before running the command ./gradlew :packages:react-native:ReactAndroid:test
> Task :packages:react-native:ReactAndroid:hermes-engine:downloadHermes UP-TO-DATE
Download https://github.com/facebook/hermes/tarball/main

> Task :packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes FAILED

FAILURE: Build failed with an exception.

@ravir-simform could you open a separate GitHub issue, tag me there, and share the full build log you're seeing?

I would like to claim react/uimanager/ReactPropForShadowNodeSetterTest

Hi! I'd like to claim LayoutPropertyApplicatorTest

@siddarthkay Are you still interested in working on this? If not, can I please do it 😊?

Hey!
Yes I have WIP for it I'll raise a draft PR for it today!

Hey @Marcoo09, are you still working on it? I would love to work on react/views/text/ReactTextTest

Hey @ananta, I'm stuck, feel free to take it.

Hey @ananta, I'm stuck, feel free to take it.

Thanks! I'll start working on this right away @mdvacca

Hey! i`d like to contribute

hey @siddarthkay are you still working on react/views/textinput/TextInputTest or can I take it ?

Hey @adhamhassan99 : yeah I've been caught up and will probably be more caught up in coming 2 weeks, you can go ahead and start working on TextInputTest 🙏🏻

Hey @adhamhassan99 : yeah I've been caught up and will probably be more caught up in coming 2 weeks, you can go ahead and start working on TextInputTest 🙏🏻

Perfect will do my best as its my first ever OSS contribution ! wish me luck

@adhamhassan99 are you working on react/views/textinput/TextInputTest ? if not, i would like to take it up.

Ping for @adhamhassan99 @ananta @AntoineDoubovetzky @cu8code @MCanhisares @Frenzyritz13
Please let me know by the end of this week if you're still working on your test or not, otherwise we'll release it

@cortinico I wasn't able to work on these for the past few weeks; I'll have bandwidth this weekend to finish it if there's time for that, otherwise someone can pick it up and finish it by then

@cortinico It's quite busy these days, if anyone who has more free time wants to work on this you can remove me from the task.

@cortinico can i pick this up ? i am free for a few weeks, i will be able to work on it. however, this is my first time working on a n opensource project so i might need some help starting out. thanks.

@cortinico can i pick this up ? i am free for a few weeks, i will be able to work on it. however, this is my first time working on a n opensource project so i might need some help starting out. thanks.

@arjun1194 yup but you need to specify which file you want to work on.

I will be able to work on any file that no body else is working on right now, as i see all files marked with assigned to someone i am not able to decide

I will be able to work on any file that no body else is working on right now, as i see all files already marked with "assigned to someone". i am not able to decide

I've assigned you to @UIManagerModuleTest
I've also released your files @adhamhassan99 @ananta @cu8code @Frenzyritz13
Please let me know by the end of this week if you're still working on your test or not, otherwise we'll release it

✋ I can take TextInputTest.java. @cortinico feel free to assign it to me if it's available

@cortinico can you help me with some already merged PRs, want to check the code style that you guys follow. since it is my first time contributing to this project

@cortinico in the file, react/uimanager/UIManagerModuleTest , there is a comment @Ignore // TODO T14964130 can i get some more information about this ? i am not able to run the tests after removing the annotation.

@cortinico in the file, react/uimanager/UIManagerModuleTest , there is a comment @Ignore // TODO T14964130 can i get some more information about this ? i am not able to run the tests after removing the annotation.

Let me get back to you on this next week

Hi, I'D LIKE TO CLAIM https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/ReactTextTest.java

Hey! I'd like to work on react/uimanager/ReactPropForShadowNodeSetterTest

Hey👋, I would like to work on NetworkingModuleTest

Hey @giolaq @arjun1194 @MCanhisares @Aditya8840 I've reviewed the remaining tests that were still suppressed and I've ended up deleting your tests as they were too legacy and they had to be rewritten from scratch (so it was not worth to convert them to Kotlin)

Thank you all for the support!
We were able to migrate to Kotlin more than 20 tests thanks to the community support!
We'll be back in the future with more files to migrate


Prevent "bad gateway error?"

Can we redirect to the main page or the search interface rather than the "bad gateway" error?
e.g.
https://pqr.pitt.edu/mol/ULG

Closed with 9b3ec55352546ed23f73b77fe68512071db5cb2b

Nginx causes a redirect now


HTML

#HTML
User Story
As a bootcamp student
I want the prewrok notes to be structured on a webpage
so that I can easily find and read informations
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git and JavaScript with associated notes listed

Done!


Incorrect spritemap.svg path got when build on Windows.

I got "/assetsspritemap.[hash].svg" when build with Vite on Windows.
But on Linux, it works fine.

Hi, can you share a reproduction? I have tried on my windows machine, there is a small problem with the type of slash but not this kind of error.

Hi, can you share a reproduction? I have tried on my windows machine, there is a small problem with the type of slash but not this kind of weird path.

Here is the reproduction project.
demo.zip

https://github.com/SpiriitLabs/vite-plugin-svg-spritemap/blob/669f31ffc4bee03f47876c0bd0574ac5d443aaa8/src/plugins/build.ts#L62
maybe use path.posix.join ?

Hi, I have already implemented on my branch and this is not the problem. It is related to Vue plugin and windows some how. I continue to investigate.

So you was right, all path in build need to use posix format. A fix is coming in the 2.2.4.


Hijinks

Blame Kelos for giving me the idea...

Have a friend who has been pestering me to add a suggestion if people don't do annoying emotes during the BLU burst. Finally, I can give them what they've always wanted.


Display currency of payment request without changing local currency settings

Description
The local currency setting was being changed when a QR code/deeplink was used. Refactored components to use a currencyInfo parameter if passed instead of defaulting to using the local currency from state.
Other changes
None
Tested
Used a deeplink for a transaction in a different currency from my app currency.
Related issues

Fixes #4869

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.

@jeanregisser  to verify this task, i need to sync with @evan for OTP to login into BeanAndGo web app.
will sync it and update the status here

@jeanregisser @isabellewei verified task with Test flight build v1.5.1 (30) and Play store internal build 1.5.1<PHONE_NUMBER>) and found the following.

PHP currency is shown on Sending screen when user taps on OPEN VALORA APP button from B&G site.
Verified USD/by default selected in app currency is shown after navigate back from the sending screen
PHP currency is shown on Sending screen when user scan the QR code from B&G site.
Verified USD/by default selected in app currency is shown after navigate back from the sending screen

Need Clarification:

PHP amount is shown on sending screen when user taps on OPEN VALORA APP or Scan QR code from B&G site even though user has selected other currency from app setting.
can you please let us now is it expected or not?

Also, we have not purchased any items after tapping on OPEN VALORA APP or scanning QR code from B&G site as we have not much balance.
Please let us know if we need to proceed further to verify this task.
Thanks!!

Yes that's the expected behavior, thanks @Lss-Ankit

Okay thanks @jeanregisser for the update.


Add support to install ocp 4.x on aws

This commit:

Adds a template for creating jenkins job to install OpenShift on AWS.
Adds a build script and sample properties file for openshift v4
Updates readme.

@akrzos made the changes requested, PTAL.


[Tracking] Integrate wallet support into forc client commands (i.e. deploy, run)

Deploying contracts and running scripts on the Fuel VM will cost gas.
We need a way to enable users of forc deploy and forc run to sign transactions from a local wallet.
To achieve this, we can take advantage of the SDK's wallet API.
We will likely need to work with and simultaneously develop the forc-wallet plugin to ensure a smooth CLI wallet UX from the creation of a wallet all the way through to paying for transactions.
We should first help @digorithm to land the awesome work in https://github.com/FuelLabs/forc-wallet/pull/3 which has long since been unblocked with plugin support and wallet support in the SDK.
Before beginning work on this, we should first address #2412.
TODO

[x] #2412
[x] Ensure we can add a wallet with forc-wallet CLI. https://github.com/FuelLabs/forc-wallet/issues/13.
[x] Ensure we can use the created wallet to create a transaction within the deploy command. https://github.com/FuelLabs/forc-wallet/issues/5.
[x] Manually sign the transaction with the forc-wallet CLI. https://github.com/FuelLabs/forc-wallet/issues/7.
[x] Paste the result back into forc deploy.

Follow-up

[ ] Add a flag that allows for bypassing the manual input and use some default wallet dedicated to testing.
[ ] Consider using forc-wallet as a library within forc deploy to ease the process of selecting a wallet and signing the transaction. This might not even be desirable depending on how involved the signing process becomes in the wallet CLI as there will be many security issues to consider, and it might be safest to ensure they're dealt with in one place (the forc-wallet CLI).

Awesome -- looking forward to this.
Feel free to take over my forc-wallet PR in case it becomes a blocker and/or I'm busy with other work.

Closed as of #2641


CrossPlatformLocation Android 12

The Cross Platform Location demo service does not work when the app is closed, it only works with it open or in the background

actually the service does not start after killing the application in android 10 . with xiaomi phones

Just on Xaiomi phones?

Just on Xaiomi phones?

Yes

Just on Xaiomi phones?

also on Samsung on7.  and of course on xiaomi

In this last commit did you find the error? If yes, how to fix it here in the project? Grateful

It works OK on my Android 13 phone - I don't know why it would not work on Android 10. I think I have one that has Android 10, that I can test on later...

Did you add android:exported="True" in the manifest? in the android documentation it asks to add for the new android (>12). I added from your demo both in app and service

Is this code actually yours? I'm using your example. I remove the project and it runs without problems, when I add the service to the project I get this error. But the project is yours. without adding anything. Changing only the package name

Is this code actually yours?

Yes, this code is mine.

I'm using your example. I remove the project and it runs without problems, when I add the service to the project I get this error

What do you mean by "add the service"? The service is already added to the project. For Android, please load the CPLAndroidGroupD11.groupproj group project. You should not be loading the CrossPlatformLocation.dproj project by itself.

Yes, you got me wrong. I say that for the error not to rise I have to remove the service from the project. Adding the service again the error appears.

Can you try this?

Uninstall the app from your device

Rebuild the app

Deploy the app to your device

Run the app - when it prompts for permission, then shows the message about "location updates in the background", ensure that you select "Always" before tapping the back arrow

Let me know whether it still has the same problem

Yes, I already did those steps, but it didn't solve the problem.

Can you attach your .apk file to this report, please?

Can you attach your .apk file to this report, please?

Yes! I will send the access data too! username and password

send email to<EMAIL_ADDRESS>

I thought you meant the demo does not work for you. The .apk you sent is of your app, which has code in it that is very likely causing the issue, not the demo. I'm unable to resolve the issue unless I see all your code, but that is beyond the scope of support in Kastri. If you need help with finding the issue, please email me and I may be able to work out a quote

I'm studying delphi and compiling only the demo gives me the same error (when closing the application)
I noticed some curiosities. in D11 and package dw-fusedlocation-jar instead of dw-fusedlocation-2.0.0-jar as stated in the documentation for the D11 jar.
in the Lib folder there is no dw-fusedlocation-2.0.0-jar. Could this be causing the problem?

I noticed some curiosities. in D11 and package dw-fusedlocation-jar instead of dw-fusedlocation-2.0.0-jar as stated in the documentation for the D11 jar.

The documentation mentions no such thing. It specifically states: dw-fusedlocation-jar. This jar is for any version of Delphi, possibly from at least 10.4

I'm studying delphi and compiling only the demo gives me the same error (when closing the application)

Unfortunately I do not have a Xiaomi device to test on. Can you give the exact details of the error?

No device lens returns me the following messages.
I indicated with the arrow where the error appears as soon as I close the application and enter the service.
The error presents seconds after closing the application. The android tells me that the application does not respond and asks to close... If I remove the service from the project, the error no longer exists.

erro.log

the device lens log txt file

Android error report
java.lang.RuntimeException: Unable to start receiver com.delphiworlds.kastri.DWMultiBroadcastReceiver: android.app.ForegroundServiceStartNotAllowedException: startForegroundService() not allowed due to mAllowStartForeground false: service com.cruxsistemas.zapcargas/com.embarcadero.services.CrossPlatformLocationService
at android.app.ActivityThread.handleReceiver(ActivityThread.java:4469)
at android.app.ActivityThread.access$1700(ActivityThread.java:271)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2145)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8309)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1038)
Caused by: android.app.ForegroundServiceStartNotAllowedException: startForegroundService() not allowed due to mAllowStartForeground false: service com.cruxsistemas.zapcargas/com.embarcadero.services.CrossPlatformLocationService
at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:54)
at android.app.ForegroundServiceStartNotAllowedException$1.createFromParcel(ForegroundServiceStartNotAllowedException.java:50)
at android.os.Parcel.readParcelable(Parcel.java:3334)
at android.os.Parcel.createExceptionOrNull(Parcel.java:2421)
at android.os.Parcel.createException(Parcel.java:2410)
at android.os.Parcel.readException(Parcel.java:2393)
at android.os.Parcel.readException(Parcel.java:2335)
at android.app.IActivityManager$Stub$Proxy.startService(IActivityManager.java:6218)
at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1858)
at android.app.ContextImpl.startForegroundService(ContextImpl.java:1834)
at android.content.ContextWrapper.startForegroundService(ContextWrapper.java:791)
at android.content.ContextWrapper.startForegroundService(ContextWrapper.java:791)
at com.delphiworlds.kastri.DWMultiBroadcastReceiver.checkStartupIntent(DWMultiBroadcastReceiver.java:225)
at com.delphiworlds.kastri.DWMultiBroadcastReceiver.onReceive(DWMultiBroadcastReceiver.java:344)
at android.app.ActivityThread.handleReceiver(ActivityThread.java:4456)
... 9 more
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.am.ActiveServices.startServiceLocked(ActiveServices.java:735)
at com.android.server.am.ActiveServices.startServiceLocked(ActiveServices.java:656)
at com.android.server.am.ActivityManagerService.startService(ActivityManagerService.java:12281)
at android.app.IActivityManager$Stub.onTransact(IActivityManager.java:2632)
at com.android.server.am.ActivityManagerService.onTransact(ActivityManagerService.java:2559)

It seems that as of android 12 (used in testing by me) they cannot start services in the foreground while running in the background.
https://stackoverflow.com/questions/69604951/getting-android-app-foregroundservicestartnotallowedexception-in-android-12-sdk/69604952#69604952

I have an Android 13 device and it works for me. Can you check to make sure the Foreground service permission is checked?

As I said I'm using your demo. and it is not marked this option for service

The permission is for the Application part, not the service. Please look at my screenshot again

Sorry and true! Yes, then it's checked. And it still doesn't work.
Another doubt in the documentation says to add "play-services-location.16.0.0.jar" (ThirdParty\Android) but in the demo it is not there, should I add?

It says to add the jar when building your own project. It is already added to the demo.

just the default play-services-location-18.0.0.dex.jar

You are correct - the Delphi 11 project does not need it, since the default is play-services-location-18.0.0.dex.jar.

right, to be able to find the source of the error me! the service is started by message when the application is closed, correct? The app works correct only when I close it after a few seconds about an error message! I have no memory leak. From the messages I left here, what do you believe it could be? remembering that the same message appears in the default kastri demo

Looking at the manifest I saw that the following line
it's like false. Is correct?

What line is false?

Not sure if that affects the application... it does not in my case.

And very strange I've been trying to solve this for 5 days without success! Incredible when I close the application the error message appears and 15 seconds later the service starts to run

Is it working?

Closing due to lack of response

Sorry for the delay I was out. Unfortunately the error remains. Testing on moto e22 phones does not load.


Lock initialization, handlers and core logic

... as well as the pending transactions and global balance cache.
This should do the trick for the core, but there are still unguarded reads from the UI and RPC for globals other than my_tally_map, my_pending or the balance cache.

Reviewed, looks good to me - thanks bud :) merge at your convenience

Thanks. :)
I was wondering about the wallet transaction cache. Is it going to be used?

I was wondering about the wallet transaction cache. Is it going to be used?

Well, I was working on some optimization and that's where the tx hash cache came in - but it's effectiveness is limited to the scenario where we have to search through lots of bitcoin transactions to find our Omni transactions...  Eg, let's assume an integrator (say an exchange) is using Omni Core for both their Bitcoin and Omni handling (a risk at this stage but let's assume):

Their wallet has 10K bitcoin transactions in it
Their wallet has 1K Omni transactions in it
The transactions are interspersed fairly randomly

In this scenario the wallet tx hash cache can really help as it avoids the need to check non-Omni transactions - but - with the work you've done on serialization and input caching you've already made much greater strides on performance than the wallet tx hash cache can ever provide, and since it's effectiveness is limited to that one scenario - it's a bit of a hmm...
So in a nutshell, I'm not sure whether it'll actually get used :) - what do you think?

Ah, I was just wondering, because I didn't find any references to the cache. :)

what do you think?

Let's wait and see. I have not really an idea how it could be used, but I also don't see a reason to remove it right now.

Ah, I was just wondering, because I didn't find any references to the cache. :)

Ahh - yeah I removed them in https://github.com/zathras-crypto/omnicore/commit/bec0f226974f41eb6814c9295ae6e43f94038f44 and https://github.com/zathras-crypto/omnicore/commit/7183cf9962693bd489bc0f0bc72d1668ab1ade55 :)


[2.0.1] Allow temporary credentials (session token parameter)

Examples.

@atsikham I think we can move this to Ready to review?

How about using full names in specification?
specification:
  cloud:
    credentials:
      key: <access_key_id>
      secret: <secret_access_key>
      token: <session_token>

vs:
specification:
  cloud:
    credentials:
      access_key_id: <access_key_id>
      secret_access_key: <secret_access_key>
      session_token: <session_token>

IMO this would better correspond to AWS env variables: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN

I think target branch should be https://github.com/epiphany-platform/epiphany/tree/v2.0 (with this changelog)

I think target branch should be https://github.com/epiphany-platform/epiphany/tree/v2.0 (with this changelog)

Not for current 2.0.0 release anymore. Once we do 2.0.1 will probably just do a merge from dev to v2.0 branch as there will be some more changes.

How about using full names in specification?
specification:
  cloud:
    credentials:
      key: <access_key_id>
      secret: <secret_access_key>
      token: <session_token>

vs:
specification:
  cloud:
    credentials:
      access_key_id: <access_key_id>
      secret_access_key: <secret_access_key>
      session_token: <session_token>

IMO this would better correspond to AWS env variables: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN

Parameters are renamed, but it was decided not to backport this change not to broke current configurations.

/azp run

/azp run


如何去(底色/背景)? / How to go (base color/background)?

比如这个图 如何把白色背景变透明?

For example, how to make the white background transparent in this picture?

For JPEG input i.e. without an alpha channel, please see #1648

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

For example, how to make the white background transparent in this picture?

For JPEG input i.e. without an alpha channel, please see #1648

ok


new stack for bundling / new scripts for dev env

Refactored bundling:

@starport/vue webpack -> rollup
@starport/vuex babel -> rollup
@starport/template webpack -> vite

New scripts

npm run dev:watch to build-watch @starport/vue and @starport/vuex
npm run dev:serve to serve @starport/template

Moved SPClient

moved  @starport/client-js into @starport/vuex

closes #91 #144

This looks great! One question I have is, should we add Vite as a dev dependency of the monorepo, so that running npm i && npm run dev:serve at the top-level produces expected results. Seems like right now I have to go into the template dir, install deps there and go back to the top to run serve.

Right now I'm getting:
tendermint/vue % npm run dev:serve

> dev:serve
> lerna exec --parallel --scope='@starport/template' -- npm run dev

lerna notice cli v4.0.0
lerna notice filter including "@starport/template"
lerna info filter [ '@starport/template' ]
lerna info Executing command in 1 package: "npm run dev"
@starport/template: ><EMAIL_ADDRESS>dev
@starport/template: > vite
@starport/template: error when starting dev server:
@starport/template: Error: The following dependencies are imported but could not be resolved:
@starport/template:   @starport/vue/lib/style.css (imported by /Users/fadeev/github.com/tendermint/vue/packages/template/src/App.vue)
@starport/template: Are they installed?
@starport/template:     at optimizeDeps (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:64210:15)
@starport/template:     at processTicksAndRejections (node:internal/process/task_queues:96:5)
@starport/template:     at async runOptimize (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:68225:48)
@starport/template:     at async Server.httpServer.listen (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:68241:21)
lerna ERR! npm run dev exited 1 in '@starport/template'
lerna ERR! npm run dev stdout:

><EMAIL_ADDRESS>dev
> vite

lerna ERR! npm run dev stderr:
error when starting dev server:
Error: The following dependencies are imported but could not be resolved:

  @starport/vue/lib/style.css (imported by /Users/fadeev/github.com/tendermint/vue/packages/template/src/App.vue)

Are they installed?
    at optimizeDeps (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:64210:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runOptimize (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:68225:48)
    at async Server.httpServer.listen (/Users/fadeev/github.com/tendermint/vue/packages/template/node_modules/vite/dist/node/chunks/dep-4a9cff06.js:68241:21)
lerna ERR! npm run dev exited 1 in '@starport/template'

tendermint/vue % node -v
v16.13.1

There are two steps so that the packages are up-and-running.

npm run dev:watch to bootstrap the entire repo (npm install & symlinking of packages)
npm run dev:serve to serve the local server of @starport/template

Your lacking of vite will be fixed after step 1.
The second error is due to @starport/template having installed a public release of @starport/vue  and not a local one (local one has style.css, public one has a different file for styling). This is not going to happen after step 1 as well (symlinking).
Note that steps 1 and 2 need each one its own terminal as they keep watching for changes.


Iterator does not recognize my map attribute

I'm submitting a ...  (check one with "x")
[x] bug report
[] feature request
[] support request
[] general question

Current behavior (how does the issue manifest):
I am attaching my app json. I am using the javascript activity and trying to iterate over one output of this js activity. It seems that this output var is correctly mapped to a proper array in golang, but somehow, iterator doesn't like it.
I can see this in the DEBUG logs (note also that you do not see any error logs if you do not switch on the DEBUG logs, although the flow execution is marked as Failed)
2018-05-17 14:07:38.689 DEBUG  [flowmodel-simple] - Eval Iterator Task 'log_4'
2018-05-17 14:07:38.689 DEBUG  [engine] - AddAttr - name: _E.activity, type: string, value:log_4
2018-05-17 14:07:38.689 DEBUG  [engine] - AddAttr - name: _E.message, type: string, value:unsupported type '[map[payload:Hello] map[payload:my] map[payload:dear] map[payload:Flynn]]' for iterateOn
2018-05-17 14:07:38.689 DEBUG  [engine] - AddAttr - name: _E.type, type: string, value:unknown
2018-05-17 14:07:38.689 DEBUG  [engine] - AddAttr - name: _E.data, type: object, value:<nil>
2018-05-17 14:07:38.689 DEBUG  [engine] - AddAttr - name: _E.code, type: string, value:

Expected behavior:
It should iterate :-)
Minimal steps to reproduce the problem (not required if feature enhancement):
Just use my app json attached and post to http port 1885 with the following example body:
{
	"Sentence": "Hello my dear Flynn"
}

What is the motivation / use case for changing the behavior?
Trying to re-use parts of apps developed with node-red
Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
macos
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
flogo cli version [v0.5.3-16-g80636ce]
Did use flv switch to github.com/TIBCOSoftware/flogo-lib/engine@master,github.com/TIBCOSoftware/flogo-contrib/action/flow@master
flogo-splitflow.json.zip

Resolved in TIBCOSoftware/flogo-contrib#273


Multicluster Installation is not working due to authentication errors

Bug Description
Hello!
I had followed https://istio.io/latest/docs/setup/install/multicluster/primary-remote_multi-network/ to configure the multi cluster setup.
Also configured cacerts for cluster1 and cluster2 , by following the steps mentioned in  https://istio.io/latest/docs/tasks/security/cert-management/plugin-ca-cert/?_ga=2.176137186.1580396703.1649064168-393612529.1641549472#plug-in-certificates-and-key-into-the-cluster
istio-eastwestgateway and istio-ingressgateway pods in the remote cluster (cluster2) seems to be in not ready state.
 kubectl get po -n istio-system --context $cluster2
NAME                                    READY   STATUS    RESTARTS   AGE
istio-eastwestgateway-9cddfcb-g2ssn   0/1     Running   0          16h
istio-ingressgateway-5747c7d8-ccjm6   0/1     Running   0          16h
istiod-c6d67744-9dq89                 1/1     Running   0          16h

Ingress pod logs(cluster2) reports the following error repeatedly :
info    xdsproxy        connected to upstream XDS server: istiod-remote.istio-system.svc:15012
2022-04-06T07:50:08.228707Z     warn    xdsproxy        upstream [1683] terminated with unexpected error rpc error: code = Unauthenticated desc = authentication failure

Istiod pod (cluster1) reports the following error repeatedly:
Failed to authenticate client from <IP_ADDRESS>:56260: Authenticator ClientCertAuthenticator: no verified chain is found; Authenticator KubeJWTAuthenticator: could not get cluster cluster2's kube client

Both clusters support third party service account tokens
kubectl --context $cluster1 get --raw /api/v1 | jq '.resources[] | select(.name | index("serviceaccounts/token"))'
{
    "name": "serviceaccounts/token",
    "singularName": "",
    "namespaced": true,
    "group": "authentication.k8s.io",
    "version": "v1",
    "kind": "TokenRequest",
    "verbs": [
        "create"
    ]
}

(cluster1 is a GKE cluster and cluster2 is AKS)
Istio Version: 1.13.2
Is there anything that I'm missing here?
Any help would be appreciated .
Thanks in advance! :)
Version
istioctl version
client version: 1.13.2
control plane version: 1.13.2
data plane version: none
kubectl version --short
Client Version: v1.23.3
Server Version: v1.20.15-gke.1000

Additional Information
No response

@headsha can you post the errors why gateway pod are not up running? can you post the kubectl describe command result here?

can you share logs from istiod and ingressgateway pod?

Ingress pod logs(cluster2) reports the following error repeatedly :
info    xdsproxy        connected to upstream XDS server: istiod-remote.istio-system.svc:15012
2022-04-06T07:50:08.228707Z     warn    xdsproxy        upstream [1683] terminated with unexpected error rpc error: code = Unauthenticated desc = authentication failure

Istiod pod (cluster1) reports the following error repeatedly:
Failed to authenticate client from <IP_ADDRESS>:56260: Authenticator ClientCertAuthenticator: no verified chain is found; Authenticator KubeJWTAuthenticator: could not get cluster cluster2's kube client

Dude, did you solve it? I had the same problem as you.

ingressgateway pod is not ready, wtf!!!!

I had the same problem，how to solve


Adaptive Sampler not working as expected

List of NuGet packages and version that you are using:
"Microsoft.ApplicationInsights.WorkerService" Version="2.21.0"

Describe the bug
Adaptive sampler when used with activities with Recorded flag set to true (in case of OpenTelemetry this could be set via AlwaysOnSampler) results in high number of telemetry records to be ingested compared to activities with the flag set to false
A clear and concise description of what the bug is.
To Reproduce
internal class Program
    {
        static void Main(string[] args)
        {
            TelemetryConfiguration configuration = TelemetryConfiguration.CreateDefault();
            configuration.TelemetryInitializers.Add(new OperationCorrelationTelemetryInitializer());
            configuration.TelemetryChannel = new CustomChannel();
            configuration.InstrumentationKey = "ikey";
            var telemetryClient = new TelemetryClient(configuration);

            // Sampling
            var builder = configuration.DefaultTelemetrySink.TelemetryProcessorChainBuilder;
            builder.UseAdaptiveSampling();
            builder.Build();

            while (true)
            {
                for (int i = 0; i < 10000; i++)
                {
                    Activity act = new Activity("Parent");
                    // uncomment the following line to see more telemetryitems
                    // act.ActivityTraceFlags |= ActivityTraceFlags.Recorded;
                    act.Start();
                    var startTime = DateTime.UtcNow;
                    var timer = System.Diagnostics.Stopwatch.StartNew();
                    timer.Stop();
                    telemetryClient.TrackDependency("myDependencyType", "myDependencyCall", "myDependencyData", startTime, timer.Elapsed, true);

                    act.Stop();
                }
                telemetryClient.Flush();
                Thread.Sleep(1000);
            }
        }
    }

CustomChannel
internal class CustomChannel : ITelemetryChannel
    {
        public bool? DeveloperMode { get; set; } = true;
        public string EndpointAddress { get; set; } = "endpoint";

        static long telemetryCount = 0;

        public void Dispose()
        {
        }

        public void Flush()
        {
            Console.WriteLine("TelemetryCount: " + telemetryCount);
        }

        public void Send(ITelemetry item)
        {
            telemetryCount++;
        }
    }

For anyone encountering this, the workaround is to use Fixed rate sampling instead of Adaptive.

Beta package is now available with the fix https://www.nuget.org/packages/Microsoft.ApplicationInsights/2.22.0-beta3

@vishweshbankwar do you know when will this fix be shipped to a stable version?

Hi @OsmondJiang, we're targeting end of May for the next stable release.

Closing as the issue is fixed  https://github.com/microsoft/ApplicationInsights-dotnet/issues/2742#issuecomment-1507613660


Fix wrong pie charts on map when showing 100%

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- map/js/main.js  1

See the complete overview on Codacy


feat(box): add new fields for multi-cluster/docker image registry support

What this PR does / why we need it
This PR adds support to box for expressing development docker image registries as well as for listing available clusters for loft. This will be used by the devenv for both tilt integration as well as with loft for picking and choosing which cluster to use for backing a cloud devenv. This is contingent on me getting direct cluster endpoints to also work, but that's digressing.

JIRA ID: [XX-XX]

Notes for your reviewers

:tada: This PR is included in version 1.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to kill just one session?

I had connecting to two Dapps, now i want to disconnect from only one Dapp.
I try to use killsession, and two Dapps' sessions were been killed.
Please teach me how to do, thank you.

Hi @eric19950925 I need some help for the same. Like how did you managed to Dapps connections. When I connect to two different Apps with same account. They connect successfully but on receiving any event from the Dapp connected first in the order throws me this HandshakeException: Hmac from payload and calculated hmac doesn't match.
Would be happy to hear back from you😃

I managed to do a workaround by starting a new client on every new connection, that way you can control which client to kill.


Update dark-mode.js

This update makes navbar and header turn dark too
Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!

Sumarise what this PR fixes: < enter details >
Fixes #: < Enter Issue ID/URL >
Checklist:
(Add an x between the brackets to check the items)

[ ] I have sumarised what this PR fixes above
[ ] I have provided the issue ID/URL above
[ ] This PR fixes only the issue mentioned above (create seperate PRs for seperate issues)
[ ] I was the first one to claim the issue or I created the issue

The changes you have suggested has already been added by another PR. Thanks for your effort :)


Clean up unused code

In the interest of reducing the amount of code we maintain this PR removes files that are not in use or no longer apply to the project.

Removed components in infrastructre/docker/, not in use, cdn-in-a-box performs the same functionality
Removed misc/jira_github_issue_import.py, the project does not use JIRA
Removed traffic_ops/install/bin/_postinstall.pl and traffic_ops/install/lib/, _postinstall.py is the recommended script to use for install
Removed traffic_ops/install/bin/convert_profile/, this script is outdated and is for use on an EOL ATS version
Removed traffic_ops/install/bin/install_go.sh, traffic_ops/install/bin/todb_bootstrap.sh and traffic_ops/install/bin/install_goose.sh are no longer in use

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

PR submission checklist

[ ] This PR has tests
[ ] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Did you consult with Evan Zelkowitz about the removal of convert_profile?

Yes, he said we have not been using it, however maybe @smalenfant may have a different opinion on its removal?

Did you consult with Evan Zelkowitz about the removal of convert_profile?

Yes, he said we have not been using it, however maybe @smalenfant may have a different opinion on its removal?

I do use this convert_profile when I upgrade ATS. I have those rules still in use on our local repository.
Can we expand on "outdated" ?
convert_ats7_to_ats8.yaml
convert_ats8_to_ats9.yaml

I do use this convert_profile when I upgrade ATS. I have those rules still in use on our local repository. Can we expand on "outdated" ?
convert_ats7_to_ats8.yaml
convert_ats8_to_ats9.yaml

The files removed from the convert_profile directory were:

convert622to713.json
convert622to713.yaml
convert_profile.go
convert_profile_test.go

Outdated here being the ATS versions those scripts reference: 6.2.2 and 7.1.3. If these are still in use I can re-add them to this PR.

Building the TO RPM fails:
+ sed -i.bak s/__GO_VERSION__/1.19.8/g install/bin/install_go.sh
sed: can't read install/bin/install_go.sh: No such file or directory

traffic_ops.spec uses a variable from that script: GO_TARBALL_VERSION=__GO_VERSION__
Should this file be brought back or should that command be replaced?

Building the TO RPM fails:
+ sed -i.bak s/__GO_VERSION__/1.19.8/g install/bin/install_go.sh
sed: can't read install/bin/install_go.sh: No such file or directory

traffic_ops.spec uses a variable from that script: GO_TARBALL_VERSION=__GO_VERSION__ Should this file be brought back or should that command be replaced?

That isn't needed anymore because Go is no longer installed because we no longer use Goose, which is why install/bin/install_go.sh was removed


[TextField] Style focus issue on mobile

When the arrows on the iOS keyboard are used the active state seems not to update, the initial focused textfields border stays dark
https://codesandbox.io/s/4r14468927

@daniel-rabe Thank you for raising this issue. The outlined component isn't the only one affected. Some story for the other variants: https://codesandbox.io/s/my3n58kp6x. A diff like this can do it.
--- a/packages/material-ui/src/OutlinedInput/OutlinedInput.js
+++ b/packages/material-ui/src/OutlinedInput/OutlinedInput.js
@@ -8,12 +8,21 @@ import NotchedOutline from './NotchedOutline';
 import withStyles from '../styles/withStyles';

 export const styles = theme => {
+  const borderColor =
+    theme.palette.type === 'light' ? 'rgba(0, 0, 0, 0.23)' : 'rgba(255, 255, 255, 0.23)';
   return {
     /* Styles applied to the root element. */
     root: {
       position: 'relative',
+      '& $notchedOutline': {
+        borderColor,
+      },
       '&:hover:not($disabled):not($focused):not($error) $notchedOutline': {
         borderColor: theme.palette.text.primary,
+        // Reset on touch devices, it doesn't add specificity
+        '@media (hover: none)': {
+          borderColor,
+        },
       },
       '&$focused $notchedOutline': {
         borderColor: theme.palette.primary.main,

@oliviertassinari I would like to try to take up this issue. I did those diff and I have problems testing it locally on a CRA app.

I tried without the diff and it also gives the same problem. Is it a problem with yarn link?

@ekoeditaa Yes, it could be a problem with yarn link. We had some previous report of issues with the button component and the findDOMNode API. We are looking into migrating away from this API as it's deprecated in the strict mode. But It could be a React duplication issue. Another solution is to use the documentation website to iterate. It's what I do 99% of the time.

@oliviertassinari Created the PR #13511 to fix this issue after I tested it. Thank you!


Md and Sm Screens for "How do It" Page

Overview
We need to create a large, medium and small screens for the "How to do It page." We also need to add a banner in the Hero.
Action Items
Use the current Figma page from the tag generator and the URLhttp://civictechindex.org/adding-projects-to-the-index as reference.
Resources/Instructions
Please create the responsive screens and then add a design to the hero that corresponds to the look and feel of the site.

These are responsive screens for how to do it in tag generator. Let me know if we need any

One column layout for MD and SM pages have been chosen. Finalized screens & icon assets can be referenced here.

@chalimar Do you want to close this issue?

This is ready to be developed. This page should live under "Join the Index" as "How to Add Your Project to the Index".


-DQT_TESTCASE_BUILDDIR option in compile line breaks cmake-ide

Hi,
I've recently upgraded to cmake 3.10 from cmake 2.8, and qt 5.5 to qt 5.9, and one of the things that has changed is that this line now appears in my compilation:
-DQT_TESTCASE_BUILDDIR=\\\"/Users/stebro/ourproject/build_debug\\\"
For reasons unknown to me, this is breaking cmake-ide when it does its analysis of the compile_commands.json file.
Under normal circumstances, this is what I see in Messages when opening a file in our project:
cmake-ide [Fri Dec 22 16:48:03 2017]: Making directory /var/folders/bv/5qmzyrw94_lbq7qpql9pykr4fm0g52/T/cmake48299_3u
cmake-ide [Fri Dec 22 16:48:03 2017]: Starting rdm server
cmake-ide [Fri Dec 22 16:48:03 2017]: Converting JSON CDB /Users/stebro/ourproject/build_debug/compile_commands.json to IDB
cmake-ide [Fri Dec 22 16:48:07 2017]: Setting flags for file /Users/stebro/ourproject/daemon/src/services/scan/DirectoryCache.cpp
cmake-ide [Fri Dec 22 16:48:07 2017]: Running rc for rtags

However, with the flag above in the compilation line, I get:
cmake-ide [Fri Dec 22 16:50:57 2017]: Making directory /var/folders/bv/5qmzyrw94_lbq7qpql9pykr4fm0g52/T/cmake49555v6u
cmake-ide [Fri Dec 22 16:50:57 2017]: Starting rdm server
cmake-ide [Fri Dec 22 16:50:57 2017]: Converting JSON CDB /Users/stebro/ourproject/build_debug/compile_commands.json to IDB
split-string-and-unquote: End of file during parsing

After putting some logging into the cmake-ide.el file, it appears that it is happening during the setting of all-commands in cmake-ide--set-flags-for-file.
Here is an example of the compile_commands.json that produces the error:
[ {   "directory": "/Users/stebro/ourproject/build_debug/ui/tests",   "command": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++  -DPRODVER_BUILD_NO=9999 -DPRODVER_FULL=\\\"2.6.9999\\\" -DPRODVER_MAJOR=2 -DPRODVER_MINOR=6 -DPRODVER_STRING=\"\\\"2.6.1local build 9999 (2017-12-22 16:50:28)\\\"\" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_TESTCASE_BUILDDIR=\\\"/Users/stebro/ourproject/build_debug\\\" -DQT_TESTLIB_LIB -DQT_WIDGETS_LIB -I/Users/stebro/ourproject/build_debug/ui/tests -I/Users/stebro/ourproject/ui/tests -I/Users/stebro/ourproject/build_debug/ui/tests/OurprojectUI.unit_test_autogen/include -isystem /Volumes/OurprojectToolChain/include -isystem /Volumes/OurprojectToolChain/include/log4qt -isystem /Volumes/OurprojectToolChain/include/log4qt/varia -I/Users/stebro/ourproject/ui -iframework /Volumes/OurprojectToolChain/qt-5.5/lib -isystem /Volumes/OurprojectToolChain/qt-5.5/lib/QtCore.framework/Headers -isystem /Volumes/OurprojectToolChain/qt-5.5/./mkspecs/macx-clang -isystem /Volumes/OurprojectToolChain/qt-5.5/lib/QtNetwork.framework/Headers -isystem /Volumes/OurprojectToolChain/qt-5.5/lib/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Headers -isystem /Volumes/OurprojectToolChain/qt-5.5/lib/QtWidgets.framework/Headers -isystem /Volumes/OurprojectToolChain/qt-5.5/lib/QtTest.framework/Headers -I/Users/stebro/ourproject/ClientShared/include -I/Users/stebro/ourproject/build_debug/ClientShared/include  -stdlib=libc++ -g  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -mmacosx-version-min=10.7 -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -mmacosx-version-min=10.7   -stdlib=libc++ -Werror -Wno-c99-extensions -Wno-c++98-compat -Wreorder -Wunused-variable -Woverloaded-virtual -Wno-unused-local-typedef -Wno-inconsistent-missing-override -Wunused-function -Wno-unknown-warning-option -Wno-nonportable-include-path -Wno-deprecated-declarations -Wno-unused-const-variable -Wno-redeclared-class-member -Wno-header-guard -Wno-logical-not-parentheses -Wno-#warnings -fPIC -std=gnu++11 -o CMakeFiles/OurprojectUI.unit_test.dir/__/ui/abstractinfoprovider.cpp.o -c /Users/stebro/ourproject/ui/ui/abstractinfoprovider.cpp",   "file": "/Users/stebro/ourproject/ui/ui/abstractinfoprovider.cpp" } ]

Update:  Moving the parameter around in the compile line eliminated the error, so I'm assuming that the real culprit is one of the other -D options that precedes this one that is confusing the cmake parser into becoming unbalanced.

Hmm. It'd be interesting to just try and parse the JSON from elisp without cmake-ide being involved.

Hi,
I may have found the culprit for this issue.
if you give split-string-and-unquote something like this this is a quoted \\\"string\\\"" it will cause the above error. this function is too naive to handle \\\".

What about changing cide--split-command to the following?
(defun cide--split-command (command-string)
  "Split COMMAND-STRING and return a list of strings."
  (split-string-and-unquote (replace-regexp-in-string "\\\\\"" "\"" command-string)))

@simonpp Huh, that works. Thanks!


Get post info

If I have a post such as this:
https://www.instagram.com/p/CT-cnxGhvvO/
How do I get the info for this post? Sorry for the basic question, but I have looked over the API and am not seeing a way to do this.

Too less information what you want to do. and if you use command line or python module.
Anyway, the manual gives you the following command: instaloader -- -CT-cnxGhvvO - see here: https://instaloader.github.io/cli-options.html

Is it possible without login?
PS C:\> instaloader -- -CT-cnxGhvvO
HTTP redirect from https://www.instagram.com/graphql/query to https://www.instagram.com/accounts/login/
-CT-cnxGhvvO: Redirected to login page. Use --login.


allow lemur init to use alternate config

When installing we can define an alternate path for the lemur create_config with the -c arg. Can we get lemur init to accept an alternate path? Or is it always expected to have configuration items (config, keys, etc) under ~/.lemur/ ?
thanks

That seems reasonable.

thanks

Looking into this it seems we already support this. For any given command you should be able to pass '-c' with point to the configuration for which you want use.
In your case something like:
lemur -c <path-to_config> init

Should use the configuration as passed.
Can you try that out and let me know how it goes?

So having already performed init, it appears to work. Though when I run lemur -c /path/to/config start it tries to use the ~/.lemur/ path.
Starting from scratch in a temp dir and fresh database all seems well until I try to start. Renaming the config found in ~/.lemur and trying to start I get the following

: mv ~/.lemur/lemur.conf.py ~/.lemur/lemur.conf.py.bak
(lemur) jguarini-ld1:/tmp/lemur: lemur -c /tmp/lemur/config/lemur.conf.py start -b <IP_ADDRESS>:8001
/tmp/lemur/lib/python3.5/site-packages/flask_sqlalchemy/init.py:800: UserWarning: SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.
warnings.warn('SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.')
Plugin 'DigiCertIssuerPlugin' may not work correctly. Required variable 'DIGICERT_API_KEY' is not set in Lemur's conf.
Plugin 'DigiCertCISIssuerPlugin' may not work correctly. Required variable 'DIGICERT_CIS_API_KEY' is not set in Lemur's conf.
/tmp/lemur/lib/python3.5/site-packages/flask_sqlalchemy/init.py:800: UserWarning: SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.
warnings.warn('SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.')
Plugin 'DigiCertIssuerPlugin' may not work correctly. Required variable 'DIGICERT_API_KEY' is not set in Lemur's conf.
Plugin 'DigiCertCISIssuerPlugin' may not work correctly. Required variable 'DIGICERT_CIS_API_KEY' is not set in Lemur's conf.
Traceback (most recent call last):
File "/tmp/lemur/bin/lemur", line 11, in
load_entry_point('lemur', 'console_scripts', 'lemur')()
File "/tmp/lemur/lemur/manage.py", line 636, in main
manager.run()
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/init.py", line 412, in run
result = self.handle(sys.argv[0], sys.argv[1:])
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/init.py", line 383, in handle
res = handle(*args, **config)
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/commands.py", line 216, in call
return self.run(*args, **kwargs)
File "/tmp/lemur/lemur/manage.py", line 377, in run
validate_conf(pre_app, REQUIRED_VARIABLES)
File "/tmp/lemur/lemur/common/utils.py", line 99, in validate_conf
raise InvalidConfiguration("Required variable '{var}' is not set in Lemur's conf.".format(var=var))
lemur.exceptions.InvalidConfiguration: Required variable 'LEMUR_SECURITY_TEAM_EMAIL' is not set in Lemur's conf.

thanks for looking into this

Ugh, That is an ugly amount of output for a simple command. Let me see if I can clean that up.

Okay, so I think I solved this. Not super happy with the way it had to be done but I think it's the best we can hope for.
Checkout #596 and see if it fits your needs.

Briefly looking over the gunicorn doc for make_config() it appears to take an ignore arg. Could you simply supply ignore=['config'] on line 356 settings = make_settings() so that it looks like settings = make_settings(ignore=["config"])  and do away with the whole if klass.name ==  part in the while loop? Now I haven't tested this so it may not work as I expect it to. But it seems that if the ignore list holds a value then the in make_settins() if if setting.name in ignore: it's just skipped anyways.
See https://github.com/benoitc/gunicorn/blob/master/gunicorn/config.py for reference
Thoughts?

You might be looking at older code.
https://github.com/Netflix/lemur/blob/master/lemur/manage.py#L361
The newest code does away with klass.name and focuses on klass.action this addresses an issue where argparse had problems parsing the 'store_constant' variables as passed from gunicorn's make_settings.

Was looking at current code, was just thinking that using the ignore that comes with make_settings() would of achieved the same effect.
I'll give the update a go in the morning.
thanks

So I've added the lines to manager.py and still no love.

(lemur) [lemur@jguarini-ld1 lemur]$ head -n365 lemur/manage.py  | tail -12

def get_options(self):
    settings = make_settings()
    options = []
    for setting, klass in settings.items():
        if klass.cli:
            if klass.name == 'config':
                continue
            if klass.action:
                if klass.action == 'store_const':
                    options.append(Option(*klass.cli, const=klass.const, action=klass.action))
                else:

(lemur) [lemur@jguarini-ld1 lemur]$ lemur -c /tmp/lemur/config/lemur.conf.py start -b <IP_ADDRESS>:8001
/tmp/lemur/lib/python3.5/site-packages/flask_sqlalchemy/init.py:800: UserWarning: SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.
warnings.warn('SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.')
Plugin 'DigiCertIssuerPlugin' may not work correctly. Required variable 'DIGICERT_API_KEY' is not set in Lemur's conf.
Plugin 'DigiCertCISIssuerPlugin' may not work correctly. Required variable 'DIGICERT_CIS_API_KEY' is not set in Lemur's conf.
/tmp/lemur/lib/python3.5/site-packages/flask_sqlalchemy/init.py:800: UserWarning: SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.
warnings.warn('SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True to suppress this warning.')
Plugin 'DigiCertIssuerPlugin' may not work correctly. Required variable 'DIGICERT_API_KEY' is not set in Lemur's conf.
Plugin 'DigiCertCISIssuerPlugin' may not work correctly. Required variable 'DIGICERT_CIS_API_KEY' is not set in Lemur's conf.
Traceback (most recent call last):
File "/tmp/lemur/bin/lemur", line 11, in
load_entry_point('lemur', 'console_scripts', 'lemur')()
File "/tmp/lemur/lemur/manage.py", line 638, in main
manager.run()
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/init.py", line 412, in run
result = self.handle(sys.argv[0], sys.argv[1:])
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/init.py", line 383, in handle
res = handle(*args, **config)
File "/tmp/lemur/lib/python3.5/site-packages/flask_script/commands.py", line 216, in call
return self.run(*args, **kwargs)
File "/tmp/lemur/lemur/manage.py", line 379, in run
validate_conf(pre_app, REQUIRED_VARIABLES)
File "/tmp/lemur/lemur/common/utils.py", line 99, in validate_conf
raise InvalidConfiguration("Required variable '{var}' is not set in Lemur's conf.".format(var=var))
lemur.exceptions.InvalidConfiguration: Required variable 'LEMUR_SECURITY_TEAM_EMAIL' is not set in Lemur's conf.

verify missing arg is there

(lemur) [lemur@jguarini-ld1 lemur]$ grep LEMUR_SECURITY_TEAM_EMAIL config/lemur.conf.py
LEMUR_SECURITY_TEAM_EMAIL =<EMAIL_ADDRESS>

Did you pull down the #596 ? There were a few changes that would need to be applied.

so looking at the commits for #596 I see two, first seems to add in the if klass.name == 'config': condition while the second one removed it.
Should I just be pulling in commit e746133450326aed68b73291320f4fad92ba31d5 ?
thanks

Yes, they aren't squashed sorry.

After getting correct commit this works.
Thank you for your help on this.


groups + talk: sidebar and mobile navigation restyling

Sweeping overhaul to application chrome.

Unifies type, sizing, and spacing for lists of groups, channels, and messages between Groups and Talk for mobile viewports.
Unifies type, sizing, and spacing for headers for mobile viewports on ancillary pages (Activity, Find Groups).
Unifies type, sizing, and spacing for headers of all channels and content detail views (Curios, Threads, Notes) on mobile and desktop viewports.
Implements reduced sort and filtering controls in Groups and Talk sidebars for desktop viewports.
Improves the reliability of the "Back" button in the Note editor.
Adds an "Edit" button to the Curio detail screen.
Adds "sheet" dialogs for overflow of navigational items on mobile viewports for Groups.
Adds the "Reconnecting" spinner to all requisite headers in Groups and Talk on mobile viewports.
Adjusts the gutter of the Notebook list view on mobile viewports.
Adjusts the size of skeleton loaders in a few places.
Quiets the linter a bit.
Makes group, channel, and message unread dots gray. Let's try it!
Loads webfonts from CDN (we do this in Landscape anyway) to improve ligature appearance and Windows ClearType rendering.

Fixes #1746
Fixes #1186
Fixes #2061
Fixes #1603
Fixes #2007
Fixes #1293
Fixes #1190

I'm trying to run this PR locally to check it out, but for some reason groups never load:

I did manage to catch that there's a small issue with the sidebar row component butting up against the right edge of the sidebar in Talk:

@urcades whatever you ship you have this pointed at needs to be synced to binnec I think

Let me see if I can get some screenshots together.

The text color on mobile seems too bright relative to desktop and many of the scrollbars seem to be cut in when they should butt up against the right side imo (or have only a very small gutter):

I think the icons look really small, if you're going to size it to w-4 h-4 you need to use the small or 16 versions (might have to export a few). We probably should just default the sizes into all our icons, but alas.
Still looking through everything, I like how condensed we're getting (feel like mobile avatars could be as well) and sheet popup is great!

Thanks -- I'll look at bringing the sidebars in more flush. Unfortunately Virtuoso doesn't like padding on itself so I'll shim the individual elements in. Such is life!

This is so good, the vast majority of the spacing/sizing updates to nav structures are looking perfect.
I have a few very small points of further aligning (on desktop updates alone) we can stand to make while we're updating everything:
First:

In the comment sidebar for Gallery, and in a message thread, it looks like we're using two different styles for the "submit"/"send" button — we can stand to align on one of these. Perhaps we just stick with the iconographic/arrow button for sending, since it's a direction we've adopted on mobile for its smaller form-factor. We can make this button evenly square while we're here!
Next:

While we don't need to cram the buttons and the search field inline with one another, we can simply just left-align the buttons for now. It'll make this screen a little more put-together.
Next:

We should select one size for these "header" buttons across both screens. I'm happy for you to make a final call here, but I'm drawn the the larger variant here, as it seems to afford more space for search-like text fields.
I think this is all for now, the rest of the updates are looking really good.

@urcades 🫡

fyi clicking on this caret down icon doesn't do anything:

this is more of a style thing, but these notification buttons seem enormous to me:

in any case they should definitely be smaller on mobile, they're currently wider than the viewport:

we also seem to be missing a bottom border on the channel header:

Also, just noticed that there is a ton of top padding on mobile:

Intentional?

@patosullivan No border is intentional: https://www.figma.com/file/sCFYLlAGjehlYXUkT2rarg/Product-Handoffs?node-id=2959-144731&t=PRub88aqUjlHLgYa-4
Will address the remainder, thank you


Maintenance: Remove workaround for zeitwerk eager loading bug

This came from updating Rails, but ended up bundling a bunch in one.

Rails update
Zeitwerk monkey patch
Error setting up the database: PG::ObjectInUse: ERROR:  database "student_insights_test" is being accessed by other users. DETAIL:  There is 1 other session using the database.  Not a GH issue since it still happens with only one strategy/matrix.
Splitting up bundle exec tasks into their own commands makes this go away, but the setup fails on the immigrant check.  It doesn't fail on master.  There's a migration on master that wasn't checked in to schema.rb (could update CI to check for this).  This migration would have failed the immigrant check, since it didn't add foreign key constraints.  This PR adds a migration with those constraints.
Brakeman update

selfie


Leverage python-isal for faster (de)compression when present

Hello,
The isal library allows faster (de)compression of .gz files. If it is present, it should be used to (de)compress files.
See https://github.com/intake/filesystem_spec/pull/683

The PR is fine, we can keep discussion there.


devscripts - allow overriding branch on git checkout

Use a variable for the branch when doing git checkout of devscripts.
For exameple:
  cifmw_devscripts_repo: 'https://github.com/hjensas/dev-scripts.git'
  cifmw_devscripts_repo_branch: support-ipv6-connected

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

https://logserver.rdoproject.org/05/2005/e1d885874a8e69fd2823ead7c6b02efc93d293f3/github-check/cifmw-molecule-devscripts/f9302ff/ci-framework-data/logs/molecule-execution.log
TASK [devscripts : Clone the dev-scripts repository.] **************************
changed: [instance]

/approve
makes totally sense. Note that we may need to toggle the patch thingy if cloning a specific branch, but that's not the purpose of this PR.

/lgtm

makes totally sense. Note that we may need to toggle the patch thingy if cloning a specific branch, but that's not the purpose of this PR.

I think we can dropt the patch: https://github.com/openshift-metal3/dev-scripts/pull/1607 ;)


[protobuf-go] An option to marshal proto3 int64/fixed64/uint64 to JSON number, not to JSON string

When marshaling proto3 messages to JSON with protojson.Marshal, I would like to transfer proto3 int64/fixed64/uint64 values to JSON numbers, not to JSON strings.  Is it acceptable to add an option into protojson.MarshalOptions to make proto3 int64/fixed64/uint64 values be transferred to JSON numbers?

This needs to be brought up with the mainline protobuf repo: https://github.com/protocolbuffers/protobuf
This repo is a Golang implementation of the standard presented by the mainline, which does not provide any option for this marshal option, and such a marshal option would generate standards non-compliant JSON.


Document function param required for build post 1.0.0.

Makes readme examples work with Metalsmith 1.0.0+ so that new folks aren’t confused by silent build failures.
Details
Adds the (now required) error handler param to the build call. Fixes #92 (also mentioned in #87). Note that if accepted, I suggest the same change be made to the examples on metalsmith.io.

On 1.0.1 this does nothing for me / noop:
Metalsmith(__dirname)
  .destination('./build')
  .build(function(err) {
    if (err) throw (err);
  });

thanks!


Wrong typo in note of Shared Columns section

To whom who involves with this issue,
From the note of Shared Columns section:

Note
Relational database providers, such as SQL Server, will not automatically use the discriminator predicate when querying shared columns when using a cast. The query Url = (blob as RssBlog).Url would also return the Url value for the sibling Blog rows. To restrict the query to RssBlog entities you need to manually add a filter on the discriminator, such as Url = blob is RssBlog ? (blob as RssBlog).Url : null.

I believe that blob using in the note is refer to Blog class of an earlier context. Maybe I'm wrong.
T. Kittimethee,
Developer

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a10898c5-abee-1843-cfff-b2707f8a079a
Version Independent ID: d9399618-488e-20b1-f707-35a191b95cc1
Content: Inheritance - EF Core
Content Source: entity-framework/core/modeling/inheritance.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @AndriySvyryd
Microsoft Alias: avickers

Thanks @tnasan, submitted #3399 to fix. In the future you can directly submit a PR to fix as well.


2 Universes on a board

Does this library support to generate 2 DMX  universes at the same time?

yes, just use a dev board that exposes the tx1 pin..
you will also loose the possibility to have serial debug on

Hello! Thanks for answer. But how defined two different pins for out put and how to  describe two different universes  in a program code?

On 30 Apr 2019, at 15:47, imayoda<EMAIL_ADDRESS>wrote:
yes, just use a dev board that exposes the tx1 pin..
you will also loose the possibility to have serial debug on
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mathertel/DMXSerial/issues/29#issuecomment-487938442, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVAMM6AOTEYVJMR737WLLLPTA5WJANCNFSM4HJCJOHA.

sorry pal, been confusing as i was reading the esp8266 thread but responded here thinking it was an esp8266 question.. my mistake, really sorry

No. Just one DMX universe.
There is only one Serial interface implemented and there is only one set of service routines for this interface. The interface can be selected by using pre-precessor directives.


misc: make wait_for_healthy dump pgs if it times out

Signed-off-by: Sage Weil<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1848/
Test PASSed.


Message not sent from kafka to elasticsearch when not using ksqldb

Hi there,
Am trying to utilize kafka-connect-elasticsearch sink connector to send data from kafka to elasticsearch, without using ksqldb and kafkacat.     Verify the status of sink connector
docker-compose exec kafka-connect curl -X GET 'http://localhosT:8083/connectors/kafka-elasticsearch-sink-connector/status '

Publish message into topic

docker-compose exec broker  \
kafka-console-producer --request-required-acks 1 --broker-list broker:29092 --topic audit-data  --property parse.key=true --property key.separator=":"
1:{"traceId":"T-ID-05","callerIdentity":"CD-05","auditPoint":"AP-05","auditTimeStamp":"2021-01-05T01:01:01.001Z","message":"Hello world, from Kafka, docker-compose, ID-05"}

Consume message from topic

docker-compose exec broker \
kafka-console-consumer --topic audit-data --bootstrap-server broker:29092 --from-beginning

Read messages in ES index

docker-compose exec elasticsearch curl -s http://localhost:9200/audit-data/_search -H 'content-type: application/json' -d '{ "size": 40 }' | jq -c '.hits.hits[]'

ISSUE:
The messages are not found in the ES index. But, it is available in the kafka topic (vrified using consumer)
I checked the status of the connector, it's running with no errors. But, the message is not sent to the index.
Is there any explicit mapping to be specified for the messages to be sent to this particular index?
Please help me fix the issue.

Your connector is reading from audit-log-data whilst you are publishing to and verifying messages on topic audit-data.
For any more questions please head to https://forum.confluent.io/ :)


Variable URL goto feature

:clipboard: Description
I am currently generating a variable url in a badge, by pushing data to an online clipboard (i.e. cl1p) and then reading it in the badge:

(snapshot in case the data gets deleted):

The data in question represents build stat information.
I would like to be able to click-go to the displayed URL.

:link: Data
The data displayed by the badge is a simple json with an url.
curl -X GET https://api.cl1p.net/my_clipboard                                                                       1,000s
{"schemaVersion":1,"label":"logs","message":"https://app.buildbuddy.io/invocation/8edc9921-0848-4fd1-8441-552512cad509","color":"orange"}

:microphone: Motivation
This would be an awesome feature to have, since build logs outside of mainstream CI systems often change and typically contain a variable hash.

The way I envision this is having a "follow_url=true" somewhere in the url of the badge.
This would guarantee that that which is displayed is the same as the pointed-to url endpoint.
The user can then judge by themselves if they trust going to that endpoint or not.

Badges have a link feature. It’s not turned for Endpoint right now but could be if it helps your use case.
Could you try experimenting with a static badge with links and see if it works for you? In general for links to work, you need to embed the badge using <object>, not <img>. Also links won’t work on GitHub because of restrictions in camo, the proxy that serves images on GitHub.
The other thing we could possibly do is add a feature in Shields that would provide a link redirect for the endpoint badge. Although because of how caching works it might go to a newer or older link than the badge itself.

In general for links to work, you need to embed the badge using <object>, not <img>

this looks like html, whereas my usecase is plain old Markdown :
![Custom badge](https://img.shields.io/endpoint?style=social&url=https%3A%2F%2Fapi.cl1p.net%2Fmy_clipboard).

The other thing we could possibly do is add a feature in Shields that would provide a link redirect for the endpoint badge. Although because of how caching works it might go to a newer or older link than the badge itself.

That also sounds good.
Another ideea would be to just copy it in the clipboard. I don't mind opening a tab by myself, as long as I have the url in the clipboard to fast-paste it in.

The Markdown spec allows embedding HTML. Where are you serving the rendered Markdown?

I'll see if I have time to play around further, I suspect not a lot.
I'm hosting it here, functionality introduced with https://github.com/mihaigalos/osi_stack/pull/11.
Thanks for the support! :+1:

Yea, so on GitHub, links embedded into badges are not going to work.
It looks like cl1p has a redirect feature. What if you post just the link into a second clipboard link, and then wrap your badge with a link to that?
By the way, is there anything that prevents other people from writing garbage to your clipboard? 🤔

It looks like cl1p has a redirect feature.

This is precisely what I'm using to display the endpoint in the badge. The query goes to cl1p which redirects to my build logs.

By the way, is there anything that prevents other people from writing garbage to your clipboard? thinking

Yes. You can use basic auth to prevent unauthorized access, if need be.

My suggestion is to post the link to a second cl1p and use that as your dynamic redirect target.


Policy (TDE on SQL Database) version changed

built-in policy version was changed
target:
4.8: Encrypt sensitive information at rest
Transparent Data Encryption on SQL databases should be enabled
version
old:1.0.0
new:2.0.0
the policy is below
https://github.com/Azure/azure-policy/blob/master/built-in-policies/policyDefinitions/SQL/SqlDBEncryption_Audit.json

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2561cc3d-996d-fb20-3bee-8bf0513e3cd4
Version Independent ID: 20471c47-d5ca-5c19-5fcf-3c19cdc5525b
Content: Azure security baseline for Azure SQL Database
Content Source: benchmark/azure/baselines/sql-database-security-baseline.md
Service: sql-database
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@t-omo-t Thank you for the feedback. This is being assigned to the content author to evaluate and update as appropriate.

Hi, @t-omo-t. We are in the process of producing new security baselines that conform to the Azure Security Benchmark v3.  The baseline for Azure SQL Database is slated to be published on July 1st. When it is released, it will overwrite this baseline, and your issue will be resolved. Thank you! #please-close


List and ListItem issues with ARIA

Safari seems to be the main culprit here:
The LHS menu of the docs site, none of the ListItems are available to tab navigation - Safari only.
Looking at the /routes/components/lists/ page, clicking an item and then trying to shift tab to go up the list does not work in Safari

On the same page - tabbing to a new item and then pressing space or enter does not highlight the ListItem in FF, Chrome, Safari due to elemItem being null - line 48 in ListItem.svelte

Pretty sure this is an issue with line 48 in ListItem.svelte and that it should be reversing the ternary operands to:
parentTag === 'nav' ? elemItem.click(): elemItem.querySelector('a').click();
If parentTag is nav then the emitted tag is a and hence querySelector('a') will always fail as it looks for an anchor inside itself.  However, when parentTag is not nav, is there some benefit to trying to hit the anchor that may be nested in a slot - potential navigation ??  if not then the ternary can disappear and it can be just a elemItem.click()
This change makes highlighting via keyboard work across the board.

LHS menu issues are solved in Safari by turning on:

Why it worked for the components/lists/ page when this is off makes little sense.

Ugh, that's a frustrating default setting for Safari! Apply is using on the ball with user-centric defaults, so that's a big miss on their part. Hopefully folks that need this setting know about it!
Per the keypress event, you're correct, it should need to query within itself. It should just just trigger click on itself if it's part of a nav list set. I've dropped the favor in favor of a simple if statement. Good catch!
Just a single line fix so patched directly to dev branch.


Nesting ?

Would be cool to allow for nesting. Can my code already handle this? Need to test.

Closed via 7c1e9aedfda850605b3f73b20692f31fb7c397e6


Add a script for fetching all the source data for a work

Sometimes it's really useful to see all the source data that went into a particular Work – in particular, I often grab records and run them in the transformer with IntelliJ, so I can see exactly why a particular transformation was applied.
Actually finding the source records is moderately fiddly and annoying, so I've written a script that downloads them all for you:
$ python3 get_source_records.py a2242545
/var/folders/_c/h0g4c9_n6rg8d2v509hztzdc0000gn/T/a2242545o7gyqyo3/calm-record-id_129b0826-3ac4-4aea-8b0c-490d5889df46.json
/var/folders/_c/h0g4c9_n6rg8d2v509hztzdc0000gn/T/a2242545o7gyqyo3/sierra-system-number_b19871831.json

out of interest, are there any situations where one wouldn't want to apply_cleanups?

out of interest, are there any situations where one wouldn't want to apply_cleanups?

I use it if I want to test something in the Sierra transformer.
We store Sierra source records like:
{
  "id": "1234",
  "bibRecord": "{\"id\":\"1234\",\"fixedFields\":{\"108\":…}}",
  …
}

By default, the script will unpack that second layer of JSON encoding, so it can be pretty-printed and made readable.
If you pass apply_cleanups=False, it doesn't unpack that string, and you get something you can pass directly into the Sierra transformer code – because it expects to see the record as it's actually stored.

makes sense 👍  thanks!