Global header pattern

Abstract
Pattern describes global UI element (header) and its application for product and system level tasks. Foundational entry for broader navigation patterns; some topics will be referenced for future authorship.
Link to preview:
This preview link reflects the latest changes up to 11/19
https://carbon-website-git-fork-designertyler-navigationpatternreview.carbon-design-system.now.sh/patterns/navigation
Next steps

[ ] Peer review / early SME review
[ ] Chris Connors' review
[ ] Image review (Jeannie)
[ ] Content review (Jan)

Current Carbon pattern:
https://www.carbondesignsystem.com/experimental/navigation-pattern/
IoT:
https://pages.github.ibm.com/Watson-IoT/IoT-Design-Site/patterns/in-application-navigation/overview/
WH:
https://pages.github.ibm.com/Watson-Health/components/navigation/overview.html

[x] Do we need to distinguish between the horizontal and vertical nav patterns outside of the Shell component usage tabs?
[x] Update images to the latest production guidelines.
[x] A11y considerations: DOM order and "meaningful tab sequence", https://www.w3.org/WAI/WCAG21/Understanding/consistent-navigation.html
Landmark regions https://www.w3.org/TR/wai-aria-1.1/#landmark_roles
https://github.com/carbon-design-system/carbon/issues/3991
[x] Grid influence (sync with the latest grid guidance)
[x] Add relevant references
[x] Move the existing navigation pattern to production
[ ] Touch input
[ ] Do's and Don'ts
[ ] Create header links with submenus
[ ] Add examples for each type of organization schemes
[ ] More content organization schemes: task
[ ] Considerations for translating navigation for right to left languages.
[ ] Hierarchy and placement of information

Update Shell guidance for:

[ ] login and authentication
[ ] actions in the header
[ ] Logged in vs. Logged out experience: how is the logged-in vs logged out experience different
[ ] Icon number and status badges
[ ] Updated UI Shell left panel usage, sandbox demo, and style to include UI shell rail.

This preview link reflects the latest changes up to 11/19
https://carbon-website-git-fork-designertyler-navigationpatternreview.carbon-design-system.now.sh/patterns/navigation

Finally got a chance to sit down and go thru! Couple things:

This is Jan's lane, but on first glance, the H2 "Terms" kind of threw me off... it made me think of "terms and conditions" ... maybe even just saying "common terms" or something more to contextualize it.

This guy may benefit from going full width with the table

illustrations
I made a sketch file (attached below) with assets in it just so we start to do these things in a very consistent manner... including streamlinging things like color, browser, margin... how we denote images and how we denote type in this reductive, illustrative style.
For instance in these image illustrating header and side panel nav, there's a lot going on, the gutters are not the same size as the margin bottoms and some of the images are odd sizes. Also, the color scheme is a kind of gray on gray that we don't really use in product.

I took a pass at simplifying some of this (included in the file); if you want to tweak, you can just use this as a base:

Some options for "Header only" image

Some options for "Left panel example"

Some options for "Left panel example"

Some options for "global examples" (i didn't touch the tree diagram... i think that's fine)

Callouts

For the callouts, I used a 24px circle, since these images get really small with the diagram and even at the 8 column full size. I also used a 14px semi-bold all cap for the letter and Magenta 60; Teal 40... the teal 50-60 to me looses the acid and the pop that i associate with annotations; The stroke weight is 1.5px — I also detached the circle slightly from the line to give it a little air.

(I'm leaning toward full saturation on the call outs, I was using the tints for sub-callouts in my button guidance; I also did a few more sketches... maybe we should share these with the channel one last time... i'm going to run them by Mike again tomorrow so we're all using the same thing)
This is by NO means exhaustive... just a few sketches of things I've seen... but especially for your examples... I think the outlines are going to work better than anything else.

Other images

I thought we were going to explore product options for these real examples instead of /design and carbon docs site... is that because no one's using the shell in product without serious alterations?

Even if you do use /design for this one, which I think is OK, the magenta on magenta along with all that line work in the image is distracting... I think using the really bold simple homepage would be so much less distracting

For this the landmark region image I'm also wondering if we can use something more exciting and also try a few things like this... If we have to use a Gatsby site, I'd probably look for something other than Carbon, since you have that other image using the Carbon homepage... but I think something like this looks a lot better that that docs page with really small content on it. (Here I made the outline really pop by giving it a 2px stroke.

Also always use the same browser top. I added the dark gray one in over what you ... you have the correct one in the /design image but not this one.

again put this image in that same browser like everything else; i've also noticed... I think you have three images from the carbon site (two from the homepage and one from the interior) then /design is the only other site you use... i mean, ideally this would all be product, but if we can't, I'd probably go ahead and try to use nice images from 1) /design 2) maybe the ai site 3) brand center? or the IDL site... Pete also has some really nice light theme screens from a gatsby site he was working on that used the Serif... just need to change it up.

illustrations_for_tyler 2.zip

Good feedback! @jeanservaas
I updated the images in the PR, changed it to "Common terms", and expanded the task example matrix to full width. I don't know if I'm sold on the wider layout for this one, but let me know what you think.

Callouts

For the callouts, I used a 24px circle, since these images get really small with the diagram and even at the 8 column full size. I also used a 14px semi-bold all cap for the letter ... The stroke weight is 1.5px ...

In the work file, you attached the circle is 20px and the stroke widths were 2px. I'd like to keep using whole pixels for strokes so they're as crisp as possible and can update the circle size to whatever we decide on.

At 14px the semi-bold numbers are 9px wide but the letters vary. What about using mono-space? That way when we make the callouts Sketch symbols there won't be any wonky alignment when we override the value to another letter.
Using mono 14 would give us a consistent 9px no matter the character.

I thought we were going to explore product options for these real examples instead of /design and carbon docs site...

Yep, I updated the ones at the top and forgot to do the ones lower on the page. They're all updated to be the abstract representations of product.

Feedback from Maui and Alex:

[ ] Is there a way to add an accompanying visual to the task matrix?
[ ] Reiterate some of the terms into the configuration sections while explaining some of the reasons you'd use one vs. the other.
[ ] Do's and Dont's for the different configurations. "When you're using this... don't do..."
[ ] The "Navigation" section title feels weird since the whole pattern is navigation. Maybe try Information architecture, anatomy, structure...?
[ ] Add back in the "Global, Local" labels to the exhibit images.
[ ] Improve the correlation of the ABC's. Is there a way to add the letterns back into the abstracted screens?
[ ] Show a global nav w/ just left nav and header in one image. (sketch in notebook)

The additional section for header utilities will not be included for the 12/5 review.
The current outline for that section:
Header utilities (WIP)
The header gives a home for global system-level utilities from anywhere in the site.
Utility icons should not be used to directly navigate to an area. Instead, they should open a panel that gives a summary and then can link to where you can view more.

Search

Global search
More guidance around search can be found in search pattern.

Docs & support
Link to relevant resources like docs, tutorials, support contact information. Try to make the resources contextual to the topics of your user's current location in the site.
Notifications
Lets the user see when a new notification comes in, review it, and then jump to a location to take action and resolve.
User profile and account
System-wide user settings
Authentication
Switcher

Chris's feedback cont.

[ ] Global definition changed to clarify

"A global UI element is preset everywhere in your UI. It contains system and product items your user may need at any time: navigation, authentication, notifications, and more. Global elements remain consistent from one context to another."

[ ] Change "process" back to "task"

Task hierarchy
The task hierarchy describes the breadth of effect for various tasks. For this guidance we use the term “product” to encompass the broad category of products, applications, offerings, or web properties.

[ ] Remove the "matrix" title

Diana feedback:
They are using the left nav for global nav and tabs for local. By showing the different products and location's (parent and child) within the products in one view allowed the user to easily move between them when completing a task – stringing products together. This is common for their user.
This is not easy with the current implementation of the UI Shell. It would require additional steps of opening the switcher, clicking the product, and then clicking the area in the product.

[ ] Is this acceptable, how can we accommodate their need to have their user quickly pivot around the site to complete the task?

[ ] More do's don'ts. Having visuals helps explain the concept.

[ ] In the drill-down example we show the D not appearing in the left nav. Make it apparent that we don't want 3 nested levels in the left nav. This is a possible do don't.

[ ] Link to the breadcrumb component and add links to other relevant components.

Closing this original issue.
Remaining feedback and changes will be tracked in the v2 issue here https://github.com/carbon-design-system/carbon-website/issues/765


refactor(layers/metrics): rewrite metrics layer using observe layer

Which issue does this PR close?
Related PR: #5064
Rationale for this change
What changes are included in this PR?

rewrite metrics layer using observe layer
add more labels

Are there any user-facing changes?
API breaking changes

Because of the design of the metrics, we cannot do following things at the API level of the metrics library

specify the buckets of the histogram
specify labels while modifying the metric


Postgres Server Authenticate through verify-ca

I'm working on integrating data-diff, and I need to authenticate to a Postgres server using a certificate rather than a password.
It would be great, if there is a way to authenticate this way. If it is already possible, I think it would be very helpful to include the command or template for the TOML file in order to do this.
Thanks

How would you do it using the psycopg2 library directly?

According to this Stackoverflow you would set the sslmode to verify-ca and then just pass in the correct paths for the certificates.
conn = psycopg2.connect(dbname='yourdb', user='dbuser', password='abcd1234', host='server', port='5432', sslmode='verify-ca', sslrootcert='path/to/cert')

Just wanted to mention, I am able to connect with verify-ca using data-diff in python and passing in a dictionary with the correct values.

Sorry, I missed your last comment!
Are you happy with your current solution? Or would you like to know how to specify those values in a URL?
I agree, it could help to add this info somewhere in the readme/docs.

Close due to inactivity.


Channels not loading correctly

Sometimes messages dont get displayed but the tab get highlighted if theres a new message.
I can fix this by openeing every tab and manually reconnecting after doing this.
Version: c11d151

Can you try on latest build and provide few pictures? I haven't had any problems with channel messages not being displayed while actually being connected to the channel and the tab being highlighted by messagesm. Does it happen to every single channel/split/tab?

 it looks like this; no connected message no hosting message.
the latest build has the same problem.
all these channels dont have a lot of traffic.

Btw, the tab should get highlighted on any message from any splits inside, arent there other splits getting messages?

no i can't see any messages.

Is this still bugged on the latest nightly? https://github.com/Chatterino/chatterino2/releases/tag/nightly-build

Tested on 6d5ba0c442681fb30afd01f787a10cd3922c10aa: I still don't get a connect message on every channel

Tested on 6d5ba0c: I still don't get a connect message on every channel

Do you have another PC/internet connection to test this on? I haven't seen this from anyone else. Perhaps try changing DNS? Do you have more than 100 channels open?

I can see new messages and everything seems to be working, except the missing connected message.

I'll close this since another issue is tracking the same bug


Read environment variables to overwrite yaml configuration

Thanks for your good toolkit. I have a scenario to use god in Github Action as a CD pipeline. In this scenario, the creds(netrc/ssh_key, etc) save into YAML are not secure.
One idea is to allow reading YAML settings from environment variables. So that we can store those creds in settings. How about this feature? I think it can extend the scenario which can use god.

Yes, it is a good idea.

@ipfans for now I think to allow to store only the netrc_password on an env variable. For example, if the option netrc_password is not set on the YAML file, God tries to read the password (or token) from the environment variable NETRC_PASSWORD. What do you think?

host, user, netrc_login, and netrc_password are the same important to hide(information leaks to social engineering). Other parameters are OK to expose.

I think that's OK to me. Thanks🙏


IncrementalTextLayout does not render text

Setting up a IncrementalTextLayout without initial text will cause the text to not render.
Reproduce
Run issuePG.txt.
Click on last (empty) Input Widget, type on keyboard.
Expected
New typed text is rendered
Actual
No text is shown
Details
OS: Mac 10.15.7
pyglet  2.0.dev13

Hi！ is this issue still exist in 2.0b2 ?

Yes, still the case.

Should be fixed in https://github.com/pyglet/pyglet/pull/697

Fixed with version 2.0b3


Add putiter method to write iterators of bytes to HDFS

I'm curious, what is the motivation/application here?

Making ibis work with HDFileSystem.

The current put implementation in hdfs3 requires a local file which ibis has already placed into an object that implements the file protocol, I'd like to avoid writing that to local disk again.

I guess the alternative here would be to open the hdfs3 file and write directly with a for loop each time.  This would be somewhat inconvenient, but, given that the function is only three lines long, presumably possible.
My guess is that the counter-argument to this change would be that we wouldn't be adding another term to the API, which we might want to keep somewhat minimal for maintenance and consistency reasons.  In particular, if we add it here then we should probably also add it to s3fs, adlfs, and gcsfs.  Of course, if that encourages other tools like Ibis to adopt those tools then that's a very small price to pay.
More broadly, I like the idea of encouraging integration between "the stuff happening with Dask" and "the stuff happening with ibis/arrow/etc.."  Are there other topics or interfaces that we should try to agree upon and write down concretely?
In any event, given that @martindurant mostly maintains these libraries he should probably determine things.

Hm, good point. No need to add a new method.
I think the first point of integration is probably agreeing on a filesystem interface. The one that ibis implements using webhdfs and HDFileSystem's mostly overlap in a compatible way, modulo some keyword arguments and argument ordering. It'd be great if we could make HDFileSystem the preferred interface. WebHDFS is extremely difficult to debug.

Additional to the comments above, what are your thoughts on the corresponding get method?
In my mind, an operation like this would indeed have been done via the open method, but I had not conceived of a bytes operator as a thing.

I thought that PyArrow offered an HDFS connection through libhdfs.  Is that an option?

It does have that, but I'm not ready to introduce that kind of dependency into ibis yet.

FYI LibHDFS3 may have issues of its own.  See https://github.com/dask/dask/issues/1880
It may be interesting to explore if there are any opportunities to collaborate on remote byte management.  The dask/bytes/ module may be of more general interest.

Interesting, thanks for the heads up!


Question about siselect when SDICN is zero

Current Smsdia (section 6.1) states:
When SDICN is not the number of an implemented interrupt controller, or is zero then the following
rules apply to all privilege modes:

• All siselect values that access IMSIC registers are reserved.

What does "reserved" mean ?
Shouldn't it raise an illegal instruction exception in this case ?
Recommended changes if it should raise an illegal instruction exception:
When SDICN is not the number of an implemented interrupt controller, or is zero then the following
rules apply to all privilege modes:

• When siselect is a number in the range 0x70–0xFF (to access IMSIC registers), attempts to access
sireg raises an illegal instruction exception.

Therefore, RDSM can emulate an IMSIC when SDICN is set to 0.

Hello @ved-rivos , would you like to give some perspectives ?

I don't think the spec intends us to infer that the behavior defined for SCICN=0 or an unimplemented interrupt controller is meant to enable emulation. Rather, it's causing the hart to behave like Supervisor and VS guest external interrupts do not exist.
Regarding what reserved means, the RISC-V Instruction Set Manual Volume I Unprivileged Architecture States the following under section 2.2. Base Instruction Formats:

The behavior upon decoding a reserved instruction is UNSPECIFIED.

I would think a reserved CSR encoding within a CSR instruction would make that instruction UNSPECIFIED.
The AIA specifications recommends taking an illegal instruction exception -

When siselect is a number in a reserved range (currently 0x00–0x2F, 0x40–0x6F, or a number above 0xFF not designated for custom use), or in the range 0x70–0xFF when there is no IMSIC, attempts to access sireg should preferably raise an illegal instruction exception (unless executing in a virtual machine, covered in the next section).

So, by defining the IMSEC register range as reserved, the spec leaves it up to the implementation to handle it in the way the implementation handles all other reserved instructions.
But, we do need clarification from @ved-rivos or @rsahita

So, by defining the IMSEC register range as reserved, the spec leaves it up to the implementation to handle it in the way the implementation handles all other reserved instructions.

If the behavior is implementation-defined, I have no more doubts.
Thanks.

@ved-rivos  It makes sense. Thanks!


Automatic policy for slow transactions and queries

We should have configuration to define what the limits are.

Plus we need programmatic access to opt-out of the default limits.


59 dont remove menu button when clicking in a fruitvegetable

I have proposed a solution by adding a new bar on the layout. This is not optimal but a better solution should be applied on the app redesign that is close by.

@eduardoliron there are some failing tests, I think just unused variables, can you fix it?

@eduardoliron test failing


Update aws-java-sdk-kinesis, ... to 1.11.786

Updates

com.amazonaws:aws-java-sdk-kinesis
com.amazonaws:aws-java-sdk-s3
com.amazonaws:aws-java-sdk-sqs

from 1.11.772 to 1.11.786.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws" } ]

labels: library-update, semver-patch

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   46.76%   46.76%
=======================================
  Files          24       24
  Lines         278      278
=======================================
  Hits          130      130
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b6e3e...26927c7. Read the comment docs.


Provide badges for every crate

Closes #1172

@homu r+

:pushpin: Commit 2c6c0d2 has been approved by kvark

:hourglass: Testing commit 2c6c0d2 with merge 2e48275...

:sunny: Test successful - status


Sign in failed during 6

I'm trying to get google services to work in godot 1.3.1 and I have compiled the template but when running the apk, it doesn't sign in. I have checked the credentials again and again and still no luck. I have even tried to use other modules but no luck there either hopefully someone can spot something I have done wrong. Thank you
here is the developer console and adb logcat

Try this https://github.com/playgameservices/play-games-plugin-for-unity/issues/2045#issuecomment-350335234

Try this playgameservices/play-games-plugin-for-unity#2045 (comment)

Thank you for the quick response. Unfortunately, after creating the oAuth key in https://console.developers.google.com/apis and in https://play.google.com/apps/publish. The client ids did not end up being the same. Do you know why this is?

Try this playgameservices/play-games-plugin-for-unity#2045 (comment)

I don't know who you are. But I MUST thank you so much. I finally got it working after trying it again. Once again. Thank you!


Fix issue 24549 - std.process.environment.get(null) segfaults

The true fix I think would b to make it so tempCString never returns null (it doesn't make a lot of sense). But the code was clearly intended to work this way, and was set up because of a long ago regression.
Even if that problem is eventually fixed, this fix is not invalidated.

Would it more correct to do something like if (!name) name = ""; ?

Would it more correct to do something like if (!name) name = ""; ?

I think in this case, it doesn't matter -- I don't think an empty string is a valid environment name.

I don't think an empty string is a valid environment variable name.

Yes, but the distinction between empty string and null is a common gotcha.

There are many ways to solve this. I think if we are going to do a check for null anyway, we might as well circumvent the entire process. Why call an opaque C function when we know it's going to return "variable not found"?

All green now. Would be nice to get this in the next release...


google cloud

hello @kalaspuffar
I submit my training job in the cloud but always i got :
jobId: object_detection
state: queued
After a few minutes the job failed .
How do deal with it .Thanks in advance
regards
ibra

Hi @Ibmaria
The standard gpus might not be able to solve your problem you might need to scale up.
Or the model might have a problem with parallel calculation. Try running with a single unit first.
Hope this helps
Best regards
Daniel

@kalaspuffar
Thanks


External subtitle with 1.4.0

I use Exoplayer to play videos from remote urls together with an external subtitle, also from a remote url, like:
Video: https://example.url/video.mkv
Subtitle: https://example.url/video.srt
Before 1.4.0 I basically used
val subtitleSource = SingleSampleMediaSource.Factory(httpDataSourceFactory.value)
    .createMediaSource(subtitleConfiguration, C.TIME_UNSET)
MergingMediaSource(videoSource, subtitleSource)

What is the migration path due to the architectural changes regarding "parsing during extraction" subtitles with 1.4.0?
Do I need to download the subtitle file first and convert it to application/x-media3-cues?
Any help on figuring this out would be greatly appreciated.

Instead of manually creating MediaSource instances, can you use DefaultMediaSourceFactory (the default when using ExoPlayer.Builder) with Player.setMediaItem and MediaItem.Builder.setSubtitleConfigurations? That way, you won't have to make any further changes to handle the subtitle changes in 1.4.0 because it's all handled by DefaultMediaSourceFactory.

If that's not possible, you need to change your instantiation of SingleSampleMediaSource to be a ProgressiveMediaSource with an ExtractorsFactory configured to handle subtitles, the same way it's done in DefaultMediaSourceFactory:
https://github.com/androidx/media/blob/b01c6ffcb3fca3d038476dab5d3bc9c9f2010781/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/source/DefaultMediaSourceFactory.java#L512-L538

Perfect, works great with DefaultMediaSourceFactory and MediaItem, thank you!


Exception raised.

I'm getting the following exception:
Exception: TypeError: can't convert null to object
Line: 666
FunctionName: sloppyArrayMethod

Within a rather empty HTML page:
<html>
	<head>
		<title>Test</title>
		<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
		<link rel="stylesheet"<EMAIL_ADDRESS>		<script<EMAIL_ADDRESS>	</head>
	<body>
	</body>
</html>

This issue did not appear inn version 3.1.5.

Please follow the issues template cause this doesn't really help. We need to know at least in what environment this is happening (what browser version etc.).

Firefox 78.0.2
You could have tested the html code in less time it took you to write that comment. Nevertheless...

Make a new .html file with the given HTML code
Save it where you fancy.
Open it, view the console and refresh to see the error.

I raised the issue 12 days ago and have found a suitable alternative in the meantime, so I won't be giving more than this.
All the best.

You could have tested the html code in less time it took you to write that comment. Nevertheless...

I guess it's good that I asked because I can't reproduce this issue. So I could have spend hours trying on every possible browsers without being able to even have this issue ;)
Anyway, I tried your reproduction steps and couldn't get the issue on this exact Firefox version, so I'm closing this.
Thanks.


Audio plays loop since update

I updated pyglet from version 1.3.2 to version 1.4.5 and tired to execute the following code that is supposed to play a sine wave for 0.5 secondes.
import pyglet
from pyglet.media.synthesis import ADSREnvelope, Sine
duration_in_ms:float=500
frequency:int=440
volume=1
adsr = ADSREnvelope(attack=duration_in_ms/8000,
                    decay=duration_in_ms/2000,
                    release=duration_in_ms/8000,
                    sustain_amplitude=volume)
sine = Sine(duration=duration_in_ms/1000, frequency=frequency,
            sample_size=16, sample_rate=44100, envelope=adsr)

player = pyglet.media.Player()
player.queue(sine)
player.play()

When executing this the player plays the sound in a loop (which it should not do as player.loop is false). It is possible to stop the plying with player.pause()
The same code in pyglet 1.3.2 (with fixed imports) works fine.
Import for pyglet 1.3.2: from pyglet.media.sources.procedural import ADSREnvelope, Sine
Any ideas?

If you add pyglet.app.run() to the end, does it work as expected?

Yes it does. Why is there a difference?

Yes it does. Why is there a difference?

pyglet.app.run() in short, handles all the event queues and setting up things. It's the main loop that handles all the necessary events in order for audio and video to play.

In pyglet 1.3 and before, there was a rather ugly background thread being spawned for refilling the Player's buffers.  In an effort to clean up and simplify the codebase, these updates were moved to the main EventLoop.
In cases where you just want to play a single sound and then exit, you could do something like:
player.on_eos = pyglet.app.exit

pyglet.app.run()

That will cause the "end of source" event to exit the app loop. Would that work for your use case?

Yes this will work for me, yet it seems more complicated as in the old version where the following worked just fine.
sound = pyglet.media.load(filepath, streaming=False)
sound.play()

The documentation for on_eos() says that if loop = False the next source will be played. Next source will then reset the source to beginning.
I feel like this is not inteded behaviour as on_eos() respects the loop=False flag, while next source() which will be called when loop=false ignores it and plays the same sound again if the player is a source.
I reduced the functions to the important parts:
def on_eos(self):
        if self.loop:
            was_playing = self._playing
            self.pause()
            self._mclock.reset()

            if self.source:
                # Reset source to the beginning
                self.seek(0.0)
            self._audio_player.clear()
            self._set_playing(was_playing)

        else:
            self.next_source()

def next_source(self):
        """Move immediately to the next source in the current playlist.
        If the playlist is empty, discard it and check if another playlist
        is queued. There may be a gap in playback while the audio buffer
        is refilled.
        """
        was_playing = self._playing
        self.pause()
        self._mclock.reset()

        if self.source:
            # Reset source to the beginning
            self.seek(0.0)
            self.source.is_player_source = False

The offending code snippet runs without looping on Linux, even when pyglet 1.4.5 is installed.

It's possible that it runs on Linux because the particular audio driver buffer size might be bigger (and so the entire sample gets put into the buffer on play), but you can't count on that behavior. Especially for slightly longer samples it probably won't work.
The reason your example code does not work is because "sound" is a pyglet.media.Source, and does not have an on_eos event.  Doing Source.play() will return a "throwaway" pyglet.media.Player instance, which does have the event. This should work:
sound = pyglet.media.load(filepath, streaming=False)
player = sound.play()
player.on_eos = pyglet.app.exit
pyglet.app.run()

Hi @GerJuli have you had a chance to try that last example?

Hey @benmoran56, thanks for the reply and sorry for the delay. I am working together with @GerJuli on this issue.
Your solution works, i.e. it ensures that the sound is only played once. Yet, this means that playing sound is now a blocking call, as pyglet.app returns when the sound was played fully.
For our use case, we require the function starting to play the sound to return immediatly.
Sadly, the pyglet event loop requires the main thread. I tried wrapping the player (i.e.
def thread_play(sound):
    player = sound.play()
    player.on_eos = pyglet.app.exit
    pyglet.app.run()

t = Thread(target=thread_play, args=(sound, ))
t.start()

but it threw (interestingly only during the second execution), the expected RuntimeError: EventLoop.run() must be called from the same thread that imports pyglet.app.
We were trying to find different workaround, but if you have any idea how to play a non-looping, non-blocking sound?

Okay i found a solution that might work for us:
def play_and_stop(sound):
    from threading import Timer
    player = sound.play()
    t = Timer(player.source.duration, player.next_source)
    t.start()

play_and_stop(sound)

Hi @agricolab, @GerJuli,
Sorry for leaving this hanging for so long. Instead of the full pyglet event loop (app.run),  at a bare minimum you just need to call pyglet.clock.tick at a frequent interval. Every 0.2 seconds should be enough. If you are integrating with another another framework's event loop, you can just schedule to tick the pyglet clock in the background. If you are not using any over event loop, you could also make a background thread to tick the clock. Something like this should work:
class Ticker(threading.Thread):
    def __init__(self, delay=0.15):
        threading.Thread.__init__(self)
        self._delay = delay
        self.stopped = threading.Event()
        self.daemon = True
        self.start()

    def run(self):
        while not self.stopped.wait(self._delay):
            pyglet.clock.tick()

ticker = Ticker()

You could start that at the top of your program, and then be able to play audio as needed.
Does that work for you?

Dear @benmoran56, thanks for the advice. Our solution with stopping in the background was also working, and we are currently using that. We will give your solution a try as soon as we can!

Dear @benmoran56 finally came around to test it with pyglet 1.5. Works perfectly, allowing me to get rid of the timer hack. Thanks!

Unfortunately the background update thread had to be rolled back due to some yet unsolved bugs. This was in interest of getting 1.5.0 released, since it was a major cleanup release otherwise.
For the time being, manually ticking the clock is necessary if you are not running the pyglet event loop.

Closing this now due to lack of response, but please follow up with a new ticket if needed.


Worklets installation not working. Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 17909 (mqt_js)

Hello Team
Thanks for bringing this package. I've been trying to install it in my JavaScript project (no typescript) and I've been having issues not being able to execute the example.
I've installed it, manually linking it (my project has problems with auto-linking, so I manually added it to the MainApplication.java file). It seems to be capturing the function correctly, but it fails with an error Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 17909 (mqt_js) when executing the code.
I'm trying the example as follows:
import { Worklets } from 'react-native-worklets-core'

const fibonacci = (num) => {
        'worklet'
        if (num <= 1) return 1
        return fibonacci(num - 1) + fibonacci(num - 2)
}

const worklet = Worklets.createRunInContextFn(fibonacci)

worklet(50).then((result) => {
       console.log(`Fibonacci of 50 is ${result}`)
})

There shouldn't be a difference compared to the example typescript one, except for removing the types.

Also, I'm not using React's new architecture
Thank you!

Same problem

have the same

I think this is because you're trying to recursively call fibonacci. Recursion is not yet implemented, so use a normal for loop instead.

@JohnFTitor, @dattv-unstatic, @MAKARD Are you using V8 as javascript engine inside your project?


added usage to README

LGTM - link to Alfred in the first place.
What form should the query take? Some acceptable searches, and some that don't work.
golang network function won't work
gorilla/mux
``gorilla.mux``` work?
List of examples


Use absolute path for package readme

While running cargo-deb for git-cliff, I got the following error:
$ cargo-deb  --strip --manifest-path git-cliff/Cargo.toml -v
cargo-deb: unable to read extended description from file: ../README.md
  because: No such file or directory (os error 2)

This is due to git-cliff being a workspace package and pointing out to a readme file in a parent directory:
[package]
readme = "../README.md"

This PR fixes this issue by using an canonicalized absolute path for readme file.

These paths also break Cargo: https://github.com/rust-lang/cargo/issues/8434
so I don't intend to support them. Use a symlink instead.


[Question] Confirmation / Validation of incoming transaction (or payment) on Stellar network

Hi!
I'm just beginning to learn about Stellar and Horizon, so my question is:
If I accept transactions to my Stellar account what to check in order to be sure that the transaction has been validated and included in the ledger and won't be reversed or wasn't failed ?
Also the same question goes for incoming payments (can payment fail? if it fails what to check in RPC output ?)
E.g. in XRP (Ripple): you need to check for validated: true and in bitcoin you check for confirmations field in RPC output (confirmations: 2), so what to check in Stellar Horizon to be sure ?
Thank you.

Please ask questions at Stack Exchange.


World starts to lag when many people join.

World starts to lag when many people join. For starters, my world is pretty optimal. All the lights are baked and reflection probes too. And I don't have pickup objects.
When around 10 people join, there is a noticeable drop in frames. 15-18 total people, the frames drop to 10fps or lower. There is something in the coding that's causing when a certain amount of people arrive.
I had to remove the prefab completely from my world to get everything back to normal.

I have a quick fix that should help with the performance issues.
In the "RoomIndicator" script, change the OnPlayerTriggerStay event for a OnPlayerTriggerEnter event.
The downside of this change is that you wont be able to use multiple colliders assigned to the same zone and the way trigger colliders work, you need convex shapes.

I updated the prefab with more optimized scripts. I hope this solves your issue.


[5.1] Module filename and location changes

This PR cherry-picks changes from three PRs to swift-5.1-branch:

#21797 On Apple platforms, use swiftmodule directories for the stdlib
#22907 [test] Fix loaded_module_trace.swift for arch's that sort before "M"
#22842 Name platform-specific module files using a normalized target triple

Collectively, they rearrange the standard library and overlay modules to be laid out more like ordinary modules and add support for new target-specific module filenames.

@swift-ci please test

Looks like I resolved a merge conflict in one of the tests incorrectly. Force-pushing a corrected version.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 44974c20de76fcbf0969fd2c8ee2202832d79e45

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 44974c20de76fcbf0969fd2c8ee2202832d79e45

@swift-ci please test macOS platform

@swift-ci please test OS X platform

Build failed
Swift Test OS X Platform
Git Sha - 44974c20de76fcbf0969fd2c8ee2202832d79e45


upload compiled code to gh

travis.ci currently does not upload assets for each code release.
these are necessary for partners to replicate the pipeline on different setups.

@mkarmona it works now


Compare directory between two tags (or branches)

the feature Compare directories with between two branches is really cool !  But it seems not very convenient to compare directory between two tags:
Currently, I am reading a project called requests and often need to see the changes between two tags (like compare 0.4.0..0.5.0.).   If I want to see all the changes between these two tags, I need checkout to 0.5.0 at first, then manually browse to find the commit hash in gitlens pane, after that fire an Open All Changes With Working Tree command. the process of eyeballing to the hash of tag 0.4.0 is sort of painful as there are many commits from 0.5.0 to 0.4.0.
So, I am wondering if gitlens have a more convenient way to do that, or whether can add a feature to do it more directly: specify any previous tag, then we can open all the changes with current working tree.
The is use-and-feel is like:
https://github.com/requests/requests/compare/aa331946...2d98ca74
                                              ^0.4.0      ^0.5.0

@rksys GitLens 7 adds this ability -- you can now select a tag in the GitLens view, right-click and select Select for Compare, and then select another tag, right-click and select Compare with Selected and it will open the new GitLens Results view with a comparison of those 2. It works for tag, branches, commits, etc


[Docs] Update PPP for weiquany

Codecov Report
Base: 77.21% // Head: 77.21% // No change to project coverage :thumbsup:

Coverage data is based on head (11a539f) compared to base (8423b9a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     77.21%   77.21%
  Complexity      786      786
=========================================
  Files           108      108
  Lines          2199     2199
  Branches        249      249
=========================================
  Hits           1698     1698
  Misses          410      410
  Partials         91       91

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


v4: thumbnail does not resize containing image

Bug Report
Ionic Info
Ionic:
   ionic (Ionic CLI)          : 4.0.0-rc.9 (/usr/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-alpha.7
   @angular-devkit/core       : 0.7.0-rc.0
   @angular-devkit/schematics : 0.7.0-rc.0
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0-rc.9
   @ionic/schematics-angular  : 1.0.0-rc.9

Cordova:
   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.1.0

System:
   Android SDK Tools : 26.1.1
   NodeJS            : v8.11.1 (/usr/bin/node)
   npm               : 6.1.0
   OS                : Linux 4.15

Environment:
   ANDROID_HOME : /...../android/sdk

Describe the Bug
We use a list with ion-item which contains an ion-thumbnail and an ion-label. The picture we show in the ion-thubmnail does not have the same size of the picture in ionic3. It would not be resized.
This is the sample code:
  <ion-list>
    <ion-item *ngFor="let device of devices">
        <ion-thumbnail slot="start">

        </ion-thumbnail>
        <ion-label>

Bla

BlaBla

        </ion-label>
    </ion-item>
</ion-list>

This is the look in ionic4

This is the look in ionic3

As you can see in ionic3 we are able to see the whole picture, in ionic4 it is truncated.
Having a look to http://ionic-docs.herokuapp.com/docs/api/thumbnail there should nothing magical to do.
Perhaps now on ionic4 we are not able to wrap bigger images in a smaller thumbnail?

#14660 similar issue?

Hello! I can no longer reproduce this issue with the latest release. Because of this I am going to be closing this issue for now (: Thanks for helping us test Ionic v4!

@jgw96 Honestly we are experiencing still the same issue. No change for us on alpha.10. Can you share your test?


marking flaky tests

Reviewer:
Asana:
Description
Steps to test

#524  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on  Graphite

I think we have at mot about 5 possible flaky tests


Misc Fixes to Pipelines

Closes: #1183
Description

Bunch of misc items to fix the quality of the code & support missing items.
No UX needed -- this is misc things that support the on-going stability of the feature... nothing to really review screenshot wise.
How Has This Been Tested?

You'll need to look at the issues and test per issue.
Test Impact

Not yet - https://github.com/opendatahub-io/odh-dashboard/issues/1184
Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

/cc @Gkrumbach07

Rolled into #1188


The "nocoffee" Chrome plugin link returns a 404

Detailed description

Describe in detail the issue you're having.

The links to the "NoCoffee" plugin on this page return a 404.

What did you expect to happen? What happened instead? What would you like to see changed?

I would expect to see a page with the information about the Chrome plugin.

What browser are you working in?

Browser independent.
Steps to reproduce the issue

Step one: Visit https://www.carbondesignsystem.com/guidelines/accessibility/overview/
Step two: Find mentions of "NoCoffee"
Step three: Click the links

Additional information

Screenshots or code
Notes

Seems like the extension was removed from the Chrome extension store: https://chrome.google.com/webstore/search/NoCoffee Vision Simulator?hl=en&gl=US

We removed this link from our website. Going to close.


Example usage of detection/run_tf_detector.py in Google Colaboratory

I was working on implementing a camera trap animal detector when i saw your repository which is very similar to what i was thinking of doing, i tried your MegaDetector model in Google Colaboratory and thought it would be interesting to share it publicly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: louis030195 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @louis030195 for contributing this! The function display_images doesn't seem to show the images inline when I run it (but otherwise works great). We will look into tidying this up and merge it in the coming months, perhaps when we release MegaDetector v4. Thanks again!

@yangsiyu007 Oh Sorry about that, there seemed to be a problem with Pillow (and path not given as string also ...), i fixed it by using cv2 instead:
import cv2
and using cv2.imread instead of plt.imread

Result:


Record<string, unknown> extends type but not interface

Bug Report

🔎 Search Terms
Record with unknown extending type works but interface doesnt

🕗 Version & Regression Information

This changed between versions 3.3 and 3.5

⏯ Playground Link

Playground link with relevant code
💻 Code

interface Api {
    request: Record<string, unknown> | void;
    response: Record<string, unknown> | void;
}

interface Generic<A extends Api> {
    test: A;
}

interface ITestRequest {
    a?: string;
    b?: number;
}

type TTestRequest = {
    a?: string;
    b?: number;
};

interface TestInterface {
    request: ITestRequest;
    response: void;
}
interface TestType {
    request: TTestRequest;
    response: void;
}

// This doesnt work
type Genered1 = Generic<TestInterface>;

// But this does
type Genered2 = Generic<TestType>;

🙁 Actual behavior
ITestRequest fails to extend Record<string, unknown>

🙂 Expected behavior
ITestRequest works as TTestRequest and can be passed under signature Record<string, unknown>

Duplicate of #42825. Used search terms: interface extends record unknown


Remove non-existent layouts

Was this in relation to the Layout 'x' requested in y does not exist. warnings? I'm just running this for the first time and seeing lots of these.

Yes, these are remnants of old pages from the previous site.  I still need to go through and think about how to represent the 'handbook' and 'standard' with the new theme.  Some of these warnings I can eliminate pretty easily by removing pages that have already been replaced with their new equivalents.

I work on removing these warnings once you've made your commits.


Add Edgar Ramírez to Contributors list

Hi, thanks for creating this repo so a noob like myself can practice his first contribution!

Hi  @EdgarRMmex, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


[RFC]: add stats/incr/mskewness

Moving incremental skewness. See also @stdlib/stats/incr/skewness for the non-moving version.
For similar packages, see https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/incr.

kindly assign it to me, I want to solve this problem.

@yashveeeeer We don't assign issues, but you are free to submit a PR.


Set debugger working directory

I set up the cmake-tools to work as a debugger in C++. It works very well.
Except inside my executable, I read a file with a relative path (such as file = readFile("../folder/file.txt") ) , and obviously it has to be relative to the location of the executable.
Even though running the executable it works great, when I debug I noticed it CAN'T find the file, and I suppose it is because the debugger is running on a different directory than the executable. How can I set this? I didn't find anything on the internet.
Thanks.

Ok, I found a way to do it by using the launch.json as described here and then manually setting the flag:
"cwd": "${workspaceFolder}/build",

But I'd like to avoid this manual work, isn't there a flag I could put inside settings.json?

This should be settable without using launch.json with:
  "cmake.debugConfig": {
    "cwd": "${workspaceFolder}/build"
  }

This should be settable without using launch.json with:
  "cmake.debugConfig": {
    "cwd": "${workspaceFolder}/build"
  }

Is there any way to do this when I am not debugging?

@WinformsWizard, PR #1444 adds support for your request.


[DOC] Add reload step

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
It is unable to run quickstart example smoothly by quick-start document.
Brief change log

Add reload data step for quick-start document.

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[ ] Commit message is descriptive of the change

@bhasudha please review

One question: whether documentation relevant issues need to forcibly mapping a JIRA issue?

@yanghua I think it would be good to have JIRA tickets for docs change so to avoid the duplication of work.

@hddong I am merging this. As @yanghua and @yihua suggested, it might be a good idea to create Jira issues for future PRs. Thanks for sending in this fix.


 Not sure what's going on here. I think we need a way to add debug input to the output. Created https://github.com/ossf/scorecard-action/issues/176 for tracking

The alert information is included in the SARIF file, is caching used somewhere in between calling scorecards and the generation of the SARIF file?

There's no caching. We always run scorecard and create the SARIF for each run. The next scorecard action version https://github.com/ossf/scorecard-action/pull/211 (next few weeks)

Awesome, thanks!

Are you still seeing this problem?

Great, so you'll get the fix in the next release.

This has been fixed, thanks @laurentsimon!


Issues with the APKs at your releases

The APKs at your releases have some minor issues. Is there a specific reason while they are compiled for debug (android:debuggable is set to true)? Further, they don't show the correct versioning. The APK from 1.1 e.g. identifies as
package: name='com.android.example.camera2.basic' versionCode='1' versionName='1.0.0'

which marks it as first release ever (versionCode='1') which it definitely is not, and versionName is not the expected '1.1' as the release suggests. Those values would need to be set here right before making the release build. Without versionCode being increased, Android would not see the new APK as update for the already installed app.
Last question: What license is this app covered by? In the code I see plenty of references to Apache-2.0, does that apply to the entire app?
Thanks in advance!

Thanks for the comments, I'm very much not an app developer so the answer to most questions is "woops, my bad".
Will fix the version number / debuggable on my next version. Regarding license, however, I think all the references to Apache-2.0 are from the camera2basic app I built this from. In general I release my work under the MIT license.
Do you have resources/advice for what I would do in this case? I assume I need to add a blurb somewhere saying "this is based off the camera2basic app which has xyz license" and remove the other references to Apache-2.0?

I'm very much not an app developer so the answer to most questions is "woops, my bad".

Hehe, happens. I'm no Android dev at all, just learned some pieces as side-effects.

Will fix the version number / debuggable on my next version.

Wonderful! Please give me a ping when that's there, so I can check again!

Do you have resources/advice for what I would do in this case?

To my knowledge, MIT and Apache-2.0 are compatible (but I'm no lawyer). You could declare the app MIT and point out that pieces are covered by Apache-2.0, outlining the projects that refers to. The relevant parts should be in section 4 of the Apache-2.0 license, especially:

You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.

The other points of that section are covered as you kept the license headers in each file. That should be fine IMHO – but as pointed out, IANAL. There are also some libraries providing license dialogs which would make it easy for you to show the relevant parts inside your app.

Finally found the time to add some fixes to the app, added updated/corrected license headers so now it should look a lot clearer (Basically my MIT with a copy of the original Apache 2.0). Thanks for pointing out the debuggable:true by the way! I did not realize that even when building for release I was for some reason still setting debuggable to be true, and the app was losing a lot of performance because of it.

Thanks! And yes: versioning looks good, and the MIT license shows up fine in your repo :smiley: Now you'd just need to sign it using a release key:
package: name='com.android.example.camera2.basic' versionCode='3' versionName='1.2' platformBuildVersionName='13' platformBuildVersionCode='33' compileSdkVersion='33' compileSdkVersionCodename='13'
Verifies
Verified using v1 scheme (JAR signing): false
Verified using v2 scheme (APK Signature Scheme v2): true
Verified using v3 scheme (APK Signature Scheme v3): false
Number of signers: 1
Signer #1 certificate DN: C=US, O=Android, CN=Android Debug
Signer #1 certificate SHA-256 digest: b750f080fc73a6bf7164206581b123d32fef3d6c592d3f0b8a3b8b7ff9a4a3e8
Signer #1 certificate SHA-1 digest: 3bfd93e5ed81d913bdfc647c2ef1ea69ddf9fe29
Signer #1 certificate MD5 digest: 7885266af7c78048c3fbb823ff2a5f97
Signer #1 key algorithm: RSA
Signer #1 key size (bits): 2048

See:

Why debug certificate is not safe to sign android APKs?
issues when using local debug keystore

And please take care for this one:
SigningBlock blobs:
-------------------
0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

which is easy to solve:
android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains.

I overwrote the 1.2 release due to some issues I had with the commit (was tracking the wrong files). Let me know if this resolves the dependency/signing problems?

 If you want the metadata I've set up in my repo (Fastlane structures, see my Fastlane Cheat Sheet on how to work with that) to get control over the presentation of your app there, let me know and I send it over with a PR.

Looks good to me, just added the link!

What happened to your signing key, @Ilya-Muromets? Your current release was rejected by the updater here:
2024-10-18 19:45:42,817 WARNING: "com.android.example.camera2.basic_4.apk" is signed by a key that is not allowed:
6a7e54a86bee7b3a9840bbca7964acda18ffd470dc615a24ec538397f890e929

I've had to temporarily disable updates now until this is clarified. I hope you still have access to the previous signing key? For details, please see How to keep your key safe and what measures to take for the event of loss?

Oh sorry, I recently migrated computers (and wiped my HD) and didn't realize my keystore wasn't backed up anywhere.
I made a new keystore (which I have now backed up) so should hopefully not happen again.

Ah, so we're having that issue again now (unfortunately, this happens more often than I'd like). So how can we prove now it's really you? Should someone have hacked your Github account, they'd come exactly with this kind of reasoning (no offense meant).

you don't have access to your previous key anymore, so we cannot use that as proof
you did not sign your commits with your own GPG/PGP key, so no proof there either
no separate path of contact was established (e.g. an email address, or an account at the Fediverse), nor do we have a person who could vouch for you

Signing is a security feature. It's intended to confirm a.o. updates really came from the intended person/group. If the key changes, that breaks…
OK, thanks for the OTR verification! Going to initialize the switch then. You've already taken care for a backup of the keystore this time, so it hopefully won't happen again. May I suggest looking into "signed commits" as well? :wink:
Wait… what? Did you change the packageName as well now? From com.android.example.camera2.basic to com.android.example.camera? If you really need to change the packageName, maybe use a proper domain as well while on it? com.example is intended for testing, not for distribution – Google e.g. wouldn't accept that into Playstore. As the key has changed, this indeed is the best time to fix that as well.

Weird, not sure what happened with packageName, I thought I had updated it to com.android.pan (?) But I was refactoring the whole code (going from two modules to one) and in the process had to also update Android Studio and probably broke something, will look into that!

I'll take down v1.3 for now and try to fix this tmrw

Thanks! And AFAIK, com.android is rather the domain used by AOSP (and partly by Google with things they "took over" into their proprietary domain). Why not using your own domain, ilyac.info, for that? like e.g. info.ilyac.pan?

Does this look correct? (sorry github doesn't let me attach .apk files directly) Pani.apk.zip

Does this look correct?

On a quick look (aapt d badging): looks perfect, thanks!

github doesn't let me attach .apk files directly

Indeed not. But remember Github is run by Microsoft, so it just looks at the file extension to decide whether it's allowed. So you can simply rename an APK to *.zip to attach it – no need to put it inside another ZIP :wink: Added charm of this approach: we can check for reproducibility with just referencing the link, without manually downloading and unzipping the file.
That said: just give me a ping once the new release is available. I'll then initiate the switch:

adding the new app as a, well, new app
disabling updates on the "old app"
adding a note to the "old app's" description that it was rebranded, linking to the new one

That way those who had the "old one" installed and wonder about missing updates have a chance to find it. After about a month overlap, the "old one" will be removed from IzzyOnDroid, and only the "new one" will be continued.
Hope that sounds fine with you?

Actually, I think there might be a chance I can recover my old keystore. I'm pretty sure I copied my android studio folder to one of our basement computers at some point, let me see if I can recover it first!

No dice anyways, unfortunately. Found the computer but no keystore.
Just posted the release with the .apk above, thanks!

OK, then let me prepare everything. Meanwhile, a note for the next release by what our scanners report:
SigningBlock blobs:
-------------------
0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

easily solved with a minor addition to your build.gradle: oops, no need to post the details again I see, just scroll up to the end of this comment :see_no_evil:
OK, new app has been established, and "old one" git a note pointing to it – both effective with the next sync around 6 pm UTC. Timer for self-destruct of the "old app" set to 2024-11-23.

I swear I fixed that one. Will patch for next release, thank


Convert SLM API dates returned as long to DateTimeOffset

This commit updates the SLM API responses to convert date properties that are returned long values representing milliseconds since epoch
to DateTimeOffset. This is consistent with other API responses where longs are returned. What is slightly different with
this API is that Human=true can be specified on the request to also return the properties as string values. With this change, the client
now effectively ignores these values as they serve little purpose, since both would end up being converted to DateTimeOffset when deserialized.

ported to master


Update dc-converter-widget.js to support sign.ing and edit.ing

Codecov Report

Merging #430 (84dd3ea) into stage (6993ad9) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #430      +/-   ##
==========================================
- Coverage   96.57%   96.50%   -0.07%
==========================================
  Files          26       26
  Lines        2862     2862
==========================================
- Hits         2764     2762       -2
- Misses         98      100       +2

Files
Coverage Δ

.../blocks/dc-converter-widget/dc-converter-widget.js
99.34% <100.00%> (-0.66%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


New WebPage

Move from #20

It is great page https://www.staticgen.com/. On this page you can see comparison of static web generators. I think that http://gohugo.io/ or http://jekyllrb.com could be useful for us.
Then we can host this page as github pages.

I've checked hugo. It is very simple. I am able to create web for API like this: http://themes.gohugo.io/hugo-theme-learn. I think it is enough for us.
We can also create home page like this: http://themes.gohugo.io/theme/hugo-universal-theme/.
Jekyll is harder to configure than Hugo. I don't have enough time to learn it now.
We have to think about address of web page. If we use default address for this repository it will be look like: https://wojtpl2.github.io/ExtendedXmlSerializer/. I've configured it.
If we want address
extendedxmlserializer.github.io
we must create new account on github, named ExtendedXmlSerializer and move this repository there.
We can also buy custom address and set it without moving repository.
ExtendedXmlSerializer.com would be great.
But we don't have any budget :wink:

Cool!  Thanks for looking into it.  I definitely think getting a domain right now would be risky, especially if we branch out to other formats and drop Xml from the name (I think XML is the tops... maybe we'll keep the name and support other formats, who knows).
extendedxmlserializer.github.io is my vote. 👍

I've change decision. We'll use https://readthedocs.org/ It is great tool. It support for versioning so we can build docs from tags and branches of your code in your repository. It generate pdf too.
http://extendedxmlserializer.readthedocs.io/en/latest/Index/
It is only imported readme.md, but looks almost great. We need to only write documentation in plain text (reStructuredText).
E.g.:
There is autofac's documentation http://autofac.readthedocs.io/en/latest/
It is generated from:
https://github.com/autofac/Documentation

Cool!  Yes, Benchmark.NET uses that too, if I am not mistaken.  Good company. :)

I've moved documentation for version 1.5 to http://extendedxmlserializer.readthedocs.io
Great features:

edit documentation from github:

versioning:

I'd like to create page like this http://themes.gohugo.io/theme/hugo-universal-theme/
But if we need to have address like:
extendedxmlserializer.github.io
We must create new account on github and new mail.
Maybe we should change name now to ExtendedSerializer?

Yeah that looks great!  As for name... going to go there, are you?  :)
ExtensibleSerializer?
Or how about...
XSerializer or xSerializer
Shorter. :)

This name is already used:
https://www.nuget.org/packages/XSerializer/

If we change name we lose history on https://www.nuget.org/packages/ExtendedXmlSerializer/

LOL dohhhhh... should have looked that up first.
Yeah I like the name ExtendedXmlSerializer.  I know the temptation is to drop the Xml, but it is what we are good at (NOW :) ), and anything else my be a little presumptuous.  I say let's go organic and stick with ExtendedXmlSerializer if we can help it.  Who knows, maybe we'll make XML cool again. :)

You know, just a (dangerous 😁) thought, but we could use a different name altogether.  The thing about "Xml Serialization" is that it is usually data-based.  Not many use it primarily for .NET POCO serialization.  Or if they do, they run into the problems that we fix.  There isn't a "XML POCO Serializer that 'Just Works'."  Which should be our motto/goal.
So maybe something with "POCO" in it?  POCOMOCO (like locomotion) comes to mind haha.  Or maybe Mo'POCO (More POCO).  Might be too silly, but maybe not. 👼
I also have been thinking of the word "Blaze" recently for some reason.  Problem there is Blaze Serializer (BS) haha.
I'll keep thinking of it some more.

I don't have enough time for this project in this week. Maybe next week will be better or next.

No worries.  I am cranking along here and hope to be feature complete with the Configuration API by next weekend.  We'll see how I do. :P

I've seen your private api. It should be easy connect it to my fluent API.

Totally the idea. 😄

I was thinking about name and we should keep ExtendedXmlSerializer name. We will be thinking about change when we will add other format. What to you think?

Definitely think that is the way to go!

I've created<EMAIL_ADDRESS>and account on github ExtendedXmlSerializer. We need this account because we want ExtendedXmlSerializer.github.io address.

Great, sounds good!  One less thing to worry about. :)

In next week maybe I'll have more time and I'll find time to create web.
How about you? How's everything coming along?

Coool... looking into the ConfigurationAPI now.  I am going to do the type configuration first and then the member configuration.  Hopefully should be done by this weekend. 👍   After that, it's tackling all these issues on here, and then helping out with documentation.  Then we can finally call this sucker done.  Hopefully. 😄

What do you think about this logo. It is only idea.

I am not graphic designer but I think this logo should fit with ExtendedXmlSerializer.

or more square:

I like the 2nd one... can we flip it on its side? Or upside down?  It almost looks like a face that is crying currently. :)

There is:

How about this? :)

It sort of looks like an "E". 😄 And there is an "S" in there too (top).  No X though.  Maybe we should call it Extended Serializer hahah.

It is true. There is "E" and "S". I think that it is the best graphic I've ever made. I think it is enough for now. What do you think?

I think it's a great first run!  Good first step towards progress. 😄

https://extendedxmlserializer.github.io/ExtendedXmlSerializer/

It is first version.

AWESOME!  That looks great!
And now you are SOOOOOOO going to hate me! LOL.  I was working out in the gym and I finally got inspired about some names. 👼   Your logo inspired me. 😄
Are you familiar with Transformers?  I was thinking your cool purple shade looks like the purple Decepticons use for their color.
Then I started thinking... How about Extendicon?  Or even Extenditron? (I really like that one)  Something robot-y that fits well with your logo.  Also, there's a really cool name generator here:
http://www.namemesh.com/domain-name-search/extend?show=1
Interesting to see that x.tn is available. 😮
The other thought I have been kicking around is that I am thinking that adding on a JSON formatter would be really really powerful and might not take that long (maybe a week?).  Everything that I have worked on in the past few weeks has worked in smoothly.  I am thinking of riding that wave and looking into JSON formatting for the next week.  It doesn't have to be 100%, but simply demonstrates an extension that changes the format of the input/output altogether.
What do you think?

Also just thought of this one:
x10  ("ex-ten").  Kind of cool because it is 1-0. :)

If we change package name we lose history on nuget. Currently we have 1683 downloads. This users newer show information about update.
But I have idea.
We can rename
ExtendedXmlSerializer.Legacy -> ExtendedXmlSerializer
ExtendedXmlSerializer -> new name
In legacy ExtendedXmlSerializer we mark all class by Obsolide with message "Update to NEW_NAME: URL".
But in this way we have to own domain. NewName.com or something like that.
I don't have idea what name is better. I'm Polish :poland: I like Extenditron but it is long. What do you think about Extentron?
But this name don't say that it is for save file. What do you think about: ExSaver? ExtSaver?

No you are 💯% right.  Sometimes it takes things getting out of my head to see how I feel about it.  I took another look at the site, and it "feels" right.  I think we should go with this for now.  Anything else is adding unnecessary risk (like I have already said before! LOL).

I also get funny ideas when I work out, part of the creative process. 😝

Now you are adding JSON or something else?

Ah yes... Markup extensions has taken a little longer.  It's good though because it exposed some bugs.  Fixing them now and should have something committed EOD or tomorrow at the latest.  Then I'll decide if I want to do JSON.  :)

Ok your choice ;)
We will release version only if we decide.
I have some issue in WebPage on smartphone. I'll do it in next week.

Cool.  I will probably do it just because it is a challenge but also because of finding more bugs before someone else does. 👼
I heard from someone @ MSFT that the next version of Windows 10 is out very soon, maybe a couple weeks.  And then there is this from ReSharper:
https://blog.jetbrains.com/dotnet/2017/03/30/resharper-ultimate-2017-1-eap-8/
(Next Monday)
So maybe when I am done w/ JSON support these will be done and hopefully a new update for VS2017. 👍

I went ahead and updated https://github.com/wojtpl2/ExtendedXmlSerializer/ -> https://extendedxmlserializer.github.io/ namespaces in code.
Please note that we have a link in legacy code to this this URI but it doesn't work currently in the new site.
https://extendedxmlserializer.github.io/ExtendedXmlSerializer/wiki/Configuration-API <-- where is this in the new site?  Or is it not ready yet?

Our side is https://extendedxmlserializer.github.io/ExtendedXmlSerializer/ . I don't know why not https://extendedxmlserializer.github.io .
I'll create this link. Thank for reporting.

I'll continue working next week.

There is first version of documentation for 2.0.0.
http://extendedxmlserializer.readthedocs.io/en/v2.0.0/
This documentation is generated from code. If we change something in xml or configuration or class, we could regenerate documentation. No more CTRL+C -> CTRL+V.

Hey that's great! 👍

Documentation for 2.0.0 is rewritten.
It is the last part of doc:
http://extendedxmlserializer.readthedocs.io/en/v2.0.0/get-started/index.html#property-encryption
I've found one issue with configuration of encryption. I'll create issue tomorrow.

Address http://extendedxmlserializer.github.io/ is working now!

Fantastic!

There is api doc: https://extendedxmlserializer.github.io/doc-v2.0.0

I believe this issue is closed.  We have our web page open, available, and accessible and it looks very nice.  Great work @wojtpl2. :)


use intro js in storybook 6

hi guys,
im using storybook in my app, when i open intro component in storybook, it show the intro box in wrong place, please help me im need it

Position issues have been most of the time in the past related to Intro.js directly and the React wrapper itself.
If you could provide a CodeSandbox or repo URL of a repro of the issue, I could take a look at it anw.


Fix new secret scanning

Fix Detect secret scanning
There are two ways to look for new secrets based on the README for Yelp/detect-secrets. In this Github action, I managed to combine both together. While the combination mostly works, I have a (private) PR where it did not behave as expected. The two ways to do this are:
Using detect-secrets
detect-secrets scan --baseline .secrets.baseline

Using detect-secrets-hook
git ls-files -z | xargs -0 detect-secrets-hook --baseline .secrets.baseline

This approach has the benefit of mutating .secrets.baseline, which makes it easier to generate the new file.
I managed to combine these two approaches into:
git ls-files -z | xargs -0 detect-secrets scan $DETECT_SECRET_ADDITIONAL_ARGS --baseline "$BASELINE_FILE"

Testing locally, it seems that detect-secrets is much faster, but when I get around to implementing https://github.com/secret-scanner/action/issues/6 I will switch to detect-secrets-hook.

@jsoref an example of the problem can be found in this (private) PR. https://github.com/GarnerCorp/lighthouse/pull/4566
The line:
git ls-files -z | xargs -0 detect-secrets scan $DETECT_SECRET_ADDITIONAL_ARGS --baseline "$BASELINE_FILE"

is creating a .secrets.baseline that is very strange, and the resulting JOBS SUMMARY is wrong. When you have time, I will show you this bug, and explain how this change fixes it.


Add ability to set fields in configuration for Google Places

Thanks so much for your work on this gem, @alexreisner!
This PR adds support for:

the fields parameter to :google_places_details
configuring fields in Geocoder.configure, for both :google_places_details and :google_places_search

(I know this is two things, but they're very tightly related hard-to-separate things!)
Limitation: If the Geocoder configuration has fields configured, you can't override it in the query with nil. You can override it with [], but this would add &fields=& to the query string (which does the same thing, but would look different to the cache). Open to thoughts on whether this should be modified.

Note on relationship with #1514 (@ericds): In principle they have a similar objective, and this PR includes half of #1514. However, #1514 also specifies a collection of default fields in google_places_details.rb. Instead, in this PR I propose falling back to nil, which will send a request to Google Places without the fields= key, which (at least when I do it) seems to just default to all of the keys available. Reasons I felt this was preferable:

retains existing/backwards functionality (i.e. if fields isn't specified, this will do the same thing as currently)
when the available Google Places API fields change, this gem doesn't have to be updated to match it

That said, I'd be down to discuss this with @ericds to arrive at an agreement on how this should work, for @alexreisner to consider.

Thanks for this. And apologies to @ericds for not responding to #1514 (I simply missed it). I do prefer this no-defaults approach for exactly the reasons you name. Would you mind adding a test or two, to make sure the fields get formatted properly in the query string? Also, what do you think about allowing the config to be overridden by using nil? I think that would be more expected/standard behavior (and would solve the cache problem you mentioned), but is there a reason not to do it?

Would you mind adding a test or two, to make sure the fields get formatted properly in the query string?

For sure! Will do (in the next week or so).

Also, what do you think about allowing the config to be overridden by using nil?

Yeah, I kind of agree that it's more intuitive behaviour. I think I shied away from it because it would have (at face) changed the existing behaviour of :google_places_search, which currently specifies default fields. Currently, it's:
def fields(query)
  query_fields = query.options[:fields]
  return format_fields(query_fields) if query_fields

  default_fields
end

So if you pass in
Geocoder.search("ChIJ32KaYX-AhYARNa93OffiHEk", lookup: :google_places_search, fields: nil)

it will fall back to the default_fields. If we changed it to
def fields(query)
  if query.options.has_key?(:fields)
    return format_fields(query.options[:fields])
  end

  if configuration.has_key?(:fields)
    return format_fields(configuration[:fields])
  end

  default_fields
end

Then the same fields: nil would send the request without the fields parameter (because fields(query) now returns nil), falling back to Google's defaults, which would be a change in behaviour.
The only way to fall back to default_fields would be to omit fields: completely in both query and configuration.
It's a very subtle change in behaviour, but I know that I sometimes use nil when automatically constructing keyword arguments in response to user input where I know it has effect as omitting the argument, so I worried that it might break (a minority of) existing callers.
This wouldn't matter for :google_places_details, because both the current and last-fallback behaviour is to fall back to Google's defaults (via nil), so this difference only comes into play if the new configuration[:fields] isn't set. But doing this for :google_places_details but not :google_places_search would mean the two handle fields differently, which could be counterintuitive in itself.
So... yeah, basically just a small backwards compatibility point for :google_places_search. I'd be happy with the change, but I can imagine some existing users might at least want to be notified. 🙂

Yep, good point! Let's make this a pull request for the v1.8 branch (1.8.0 will probably be the next release) and I'll mention it in the release notes.

Dumb question, but how do I run the tests? I'm used to rspec and don't really have experience with the standard library unit test framework, or anything that needs to be done to provide a test environment for gems 😅  Sorry if I missed documentation for this, I promise I looked!
Currently I get, from the directory /usr/local/bundle/bundler/gems/geocoder-<commit-hash>/test,
# ruby unit/lookups/google_places_details_test.rb
Traceback (most recent call last):
	2: from unit/lookups/google_places_details_test.rb:2:in `<main>'
	1: from /usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test_helper (LoadError)

but I'm just running it in my app dev environment, which presumably isn't what the Geocoder test environment needs.
(That's why I converted the PR to a draft: I haven't actually run the tests yet to see if they pass.)

The tests were a good idea, turns out the above-discussed modification actually caused it to fail to omit the &fields= parameter, and the new tests caught it 😅

Excellent! Tests are great for that.
This looks good to me. Will merge shortly.
Thanks for the good work on this.

Closing this manually (was merged into the v1.8 branch, which Github isn't auto-marking as "merged").


Add IaaS-specific summaries?

Content-wise, I was looking to have a place for CPI landing page to document their basic functionality (including new encryption info) and help bridge some of the core terms IaaSes deal with.
Specifically here...

provides entrypage and summary for basic requirements/support
easier links to cross-reference repository and support links
add encryption details for known iaases

I'm interested in feedback if this may be a useful direction or what could be improved, @mfine30 / @voelzmo / opinioners? If useful, I think next step would be to propose individual PRs of these changes and ask CPI leads to review/amend the content before merging and publishing.

I think, it's very useful. A question about Multi-CPI: which feature is required to support multi-cpi?
Azure CPI provides the method info. Is it enough?

Pushed AWS/GCP/Azure and started a PR for OpenStack; can followup with a vSphere PR after more general feedback from Marco.


credentials text file format

I couldn't get the program to read data in the credentials.txt file, it would pull it in all in one line.
To solve the problem I needed to open it in notepad++ -> edit -> eol conversion -> windows
it had LF at the end of every line as in the unix format, but for windows it needed a CR LF at the end of each line.
If you don't want to convert the text file thats ok, just please put a comment in it so people will know it needs to be converted.  Took me several hours to figure it out!
Thank you for an amazing project.  There is no way I could have written this!

Sorry about that, must have been frustrating! I'll see if I can make it more resilient to EOL issues.


Add boolean to toggle use of custom policy for vault provider

Closes/fixes/resolves issue(s)?
Closes #75
What was added/changed/fixed?
Related issue(s)? [Optional]
Others [Optional]
Checklist (after created PR)

[ ] Added reviewers
[ ] Added assignee(s)
[ ] Added label(s)
[ ] Added to project
[ ] Added to milestone

No longer required by user
Closes #75


Unable to open template error

Hi Ben
I've been getting this error repeatedly whenever I try to open the template. Please advise.

Hi, this is because you have not switched on the decomposition visual.


Trigger the onLovelacePanelLoad also when closing the raw editor

When one closes the raw configuration editor, the lovelace dashboard is re-rendered but the onLovelacePanelLoad was not triggered in those cases, making any change to the elements inside the dashboard to be ignored.

coverage: 100.0%. remained the same
when pulling fc347ba0fdce5fc59525f8c003679510e3ad69ee on trigger_load_on_close_raw_editor
into 61913cac15fd47cb5396558628c1bb68f3246647 on master.


fixed billboarding for non uniform scale

Closes #64722. Closes #64505.
Fixed billboarding for nonuniform scale:

using x and y and z length for scaling
fixing incorrect order of matrices which caused shearing

I don't understand the math behind it, so it's better to be asked @clayjohn or @reduz. Note that If you change it, then Material should be changed accordingly: https://github.com/godotengine/godot/blob/03b92ae9ba4ea6b1f610d2bad068ae87b595fbd3/scene/resources/material.cpp#L937 https://github.com/godotengine/godot/blob/03b92ae9ba4ea6b1f610d2bad068ae87b595fbd3/scene/resources/material.cpp#L939

Oh, thank you @Chaosus ! I missed that

I don't think I added it at all, but I made a little mess with git today. I'll fix it by tomorrow's pr review

The code is actually incorrect :/

Well, it was a very long day.
Tested the change on this project:
particlebillboardtest.zip

I noticed that the keep scale is doing funny stuff with y billboard, may be worth fixing later? I didn't change the behaviour because i wanted to get this fix in for 4.0, but i was unsure about the scale for y billboards.

I noticed that the keep scale is doing funny stuff with y billboard, may be worth fixing later? I didn't change the behaviour because i wanted to get this fix in for 4.0, but i was unsure about the scale for y billboards.

I think both billboard_Y and billboard_enabled ignore the custom scale/rotation from the particles which in the MRP makes them appear to ignore scale. But ya, issues with billboard_y are definitely suited for a new Issue/PR

Thanks!


Output file

Im getting for the first option
{"name":"MSFT","customers":"government"}
{"name":"MSFT","customers":"distributer"}
{"name":"MSFT","customers":"retail"}
{"name":"Company1","customers":"store1"}
{"name":"Company1","customers":"store2"}
{"name":"Company2","customers":"Bank"}
{"name":"Company3","customers":null}
and not as in the documentation
{ 'MSFT', 'government'}
{ 'MSFT', 'distributer'}
{ 'MSFT', 'retail'}
{ 'Company1', 'store'}
{ 'Company1', 'store2'}
{ 'Company2', 'Bank'}
{ 'Company3', null}
Why?

@aqswdefrgthyhy
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

@aqswdefrgthyhy
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation. Thanks!
#Please-close


Question about TagStaticStateRouter#notify method

The call here is meaningless, and so is TagDynamicStateRouter#notify
https://github.com/apache/dubbo/blob/0809a168db5fd71a58dd3f87b0bce00bd5ed8916/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/tag/TagStaticStateRouter.java#L152

I'll fix it.


Added support for synchronous score getting from Event API

See the following link for Sift documentation https://siftscience.com/developers/docs/curl/automation-apis/synchronous-actions). Basically I just added a parameter for all events whether it should return Score or not

Awesome, thanks

@mathieukempe why didn't you merge my changes? I find them useful and someone else might need them in place. Should I implement some adjustments?

hey Sergey,
The changes were merge

Woops sorry, the changes weren't merged. I have fixed that now.
Thanks for letting me know


new plugin

I've developed an initial plugin for the CLIPPER CPU and two associated binary views. While I don't think there's much interest in such an obsolete system generally, I guess it doesn't hurt to share it with others.
The repository is here: binaryninja-clipper.

I propose a pr to add your plugin in the list

Thanks for the reminder, I'd missed this one. Added.


[BUG]: gallery.php freezes after viewing an image, requires refresh

Describe the bug
I'm using stable4 branch on Ubuntu with Nginx.
When I go to the standalone gallery at /gallery.php, I'm initially able to scroll, click the in-page refresh button (and have it refresh), and click into a gallery image to print it or do whatever.
However, after exiting that initial image, the gallery UI is completely frozen. Scrolling doesn't work, clicking on other thumbnails to open photos doesn't work, in-page refresh button doesn't work. Once I do a browser refresh of the page, it works, but only for one instance of "focusing on an image by clicking on a thumbnail".
I can click on a thumbnail, and then use the left/right arrows to flip between images in the gallery, but once I close it, the page is totally frozen.
I've tried this on Firefox, Chrome both on Linux and Android on two different devices, and I get the same behavior everywhere. I've disabled adblockers.
I do notice that in the FAQ, the URL is "/gallery". In practice, I have to go to "/gallery.php" with the explicit ".php" for it to load anything. "/gallery" gives me a 404.
nginx config:
server {
	listen 80 default_server;
	listen [::]:80 default_server;
	root /var/www/html/photobooth;
	index index.php index.html index.htm index.nginx-debian.html;
	server_name _;
	location / {
		try_files $uri $uri/ =404;
	}
	location ~ \.php$ {
		include snippets/fastcgi-php.conf;
		fastcgi_pass unix:/var/run/php/php8.1-fpm.sock;
	}
}

Steps to reproduce the behavior

Go to https://localhost/gallery.php
Click any thumbnail
Close out of the picture
Try to scroll or click anything on the page, it won't be responsive

Expected behavior

Go to https://localhost/gallery.php
Click any thumbnail
Close out of the picture
Click on another picture, or scroll, or click the refresh button on the page, and have it respond by opening that picture, scrolling the page, or refreshing the gallery.

Photobooth Version
stable4
Browser and browser version
Firefox 118 Linux & Android Chrome 117 Linux & Android
Operating System
Ubuntu 22.04 & Android
Did it work before?
No
Latest working version
No response
Additional context
No response

Hey and thanks for the report. Please update to latest development version and check if the issue still exist and reopen the issue as needed. Issues on latest stable release won't be looked at anymore in favor of the upcoming Photobooth V5.

FWIW, the php 8.2 requirement for development makes it too difficult for me to use on 22.04, which only has 8.1 in the official repos. Idk what current Debian is running. I imagine most people would want to run this on LTS builds to avoid maintenance.

v4 reached its EOL and all known bugs have been fixed in the meantime. We're hard working on finishing our work for the next version.
It's quite easy to update PHP on Ubuntu.
sudo add-apt-repository ppa:ondrej/php -y
sudo apt update

sudo apt install php8.2 php8.2-cli libapache2-mod-php8.2 -y
sudo apt install php8.2-{zip,gd,xml,mbstring} -y
sudo a2dismod php8.1
sudo a2enmod php8.2
sudo service apache2 restart

Just to make sure permissions matches you should also run the following :
sudo gpasswd -a www-data plugdev
sudo gpasswd -a www-data video
sudo gpasswd -a www-data www-data
sudo reboot

About http://localhost/gallery.php vs http://localhost/gallery, that was changed on 15. June. The gallery.php was moved for better maintainability.

I'll try to update latest V4 again with some Bugfixes and small improvements from latest development branch.
It'll still require node.js in v18.17 and npm instead of yarn.
The goal is to retain compatibility with latest Photobooth installer and fixing the known bugs of Photobooth V4. Small code improvements have also been applied and a handful of small features will be added.
https://github.com/PhotoboothProject/photobooth/tree/update/stable4
It's still WIP and needs to be tested, especially the remotebuzzer server.

Issue can be reopened if still is a problem on latest development version.


patch for phone number fix

Issue Reference
This PR addresses the Issue : Fixes # 654
Summarize
Please, describe what the PR does, the changes you have made.

Note: this is the same patch as https://github.com/IEEEKeralaSection/rescuekerala/pull/657, we had to recreate because that PR introduced some weirdness in the git history.

LGTM


AUI-1813 Show asterisk beside required fields title

Just started reviewing :) :octocat: Sent from GH.

Just started reviewing :) :octocat: Sent from GH.

Pull request merged.


Sync main branch with Apache main branch

Related PRs:

https://github.com/kiegroup/drools/pull/45
https://github.com/kiegroup/kogito-runtimes/pull/32
https://github.com/kiegroup/kogito-apps/pull/20
https://github.com/kiegroup/kogito-examples/pull/20
https://github.com/kiegroup/kogito-images/pull/32
https://github.com/kiegroup/kogito-serverless-operator/pull/30

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

E2E test is failing with timeout, see:
2024-04-16T08:40:56.9223626Z   [FAILED] in [It] - /opt/hostedtoolcache/go/1.21.9/x64/src/reflect/value.go:596 @ 04/16/24 08:40:56.921
2024-04-16T08:40:56.9225619Z   running dir: /home/runner/work/kogito-serverless-operator/kogito-serverless-operator
2024-04-16T08:40:56.9226972Z   running: kubectl delete namespace test-415 --wait
2024-04-16T08:41:07.2470408Z • [FAILED] [730.774 seconds]
2024-04-16T08:41:07.2472250Z Validate the persistence  when deploying a SonataFlow CR with PostgreSQL persistence [It] defined in the workflow from an existing kubernetes service as a reference
2024-04-16T08:41:07.2474663Z /home/runner/work/kogito-serverless-operator/kogito-serverless-operator/test/e2e/workflow_test.go:220
2024-04-16T08:41:07.2475718Z
2024-04-16T08:41:07.2475955Z   [FAILED] Timed out after 720.001s.

Trying to rerun to see if it will pass this time.


How to make following shadow? Completely lost.

I am trying to understand how to use this library even after having looked into the Wiki pages.
I have the following xml:
<?xml version="1.0" encoding="utf-8"?>
<carbon.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context="MainView.MainActivity">

<carbon.widget.ConstraintLayout
    style="@style/carbon_CardView"
    android:layout_width="0dp"
    android:layout_height="100dp"
    app:layout_constraintEnd_toEndOf="parent"
    app:layout_constraintStart_toStartOf="parent"
    app:layout_constraintTop_toTopOf="parent">
</carbon.widget.ConstraintLayout>
</carbon.widget.ConstraintLayout>

My carbon_CardView style is
<style name="carbon_CardView" parent="carbon_ConstraintLayout">
    <item name="android:background">@android:color/white </item>
    <item name="carbon_elevation">10dp</item>
    <item name="carbon_cornerRadius">0.01dp</item>
</style>

My result is the following:

I want to achieve the following:

As you can see, I need the shadow to be way more subtle than it is. The way it looks as of now, it's identical to a simple elevation=20dp on the standard API 21+ library. How can I achieve the latter with Carbon?

On API >= 21 Carbon uses the built-in shadow drawing mechanism. For example, 'app:carbon_elevation' is translated directly to 'android:elevation'. There's no way of changing any of parameters of that mechanism.
On API < 21 the library uses the built-in gaussian blur shader. It can be tweaked, but Carbon doesn't provide any parameters for that. You would have to clone the library and play with the classes from carbon.shadow package. The problem with that blur shader is that it supports only 25 samples, which is not enough to make such soft shadow on very dense screens. Carbon tries to overcome that by using scaled bitmaps - you would have to do that as well or rewrite the shader which would most likely affect performance.

@ZieIony what about position (dx,dy offset) of shadow, is that configurable?

No. All parameters are generated automatically based on view's position (x,y,z). Just like in the official implementation. Messing with position could lead to visual artifacts as Carbon's shadows are, simply speaking, 9-patches with empty center.


Port Townsend shows as up but 0%

There's no event transitioning to up even though the stream is up.
When restarting the app, sanity check the event stream and make sure the last event matches the current state.

Closing since problem went away naturally.  Will reopen if it occurs again.


Kirstie's TO DO list - week starting 31st July 2017

URGENT

[ ] 250 words on challenges & solutions for open science for OHBM Conversation piece deadline 25th July
[ ] Bio/abstract for talk at EPFL library
[ ] Summary email from OpenConCam meeting & voting on speakers

To Do
Emails/Online

[ ] Arrange meeting with HQ re: Turing policy work
[ ] Accomodation & travel for ECNP2017 - Paris
[ ] Send Ed info on Impact Story
[ ] Letters of recommendation for SRA application deadline 26th July
[ ] Arrange meeting with Ed, SW & PV for August
[x] Arrange meeting w PV for August 3rd
[ ] Accept talk invite for SciData17
[ ] Email w interesting papers & links to Bullmore lab
[ ] Send info on Turing event funding to CH
[ ] Review 50 OpenCon applications

10/50 done 🙌  40/50 to go 😧

[ ] Email NCH re inclusivity call

NSPN

[ ] Run longitudinal pipeline on HPHI

[ ] Need to be able to actually run code on HPHI first! See #39 😕
[ ] Need to copy over the data from HPC

UPDATE 13/7: this is currently underway for UCHANGE directory

[ ] Also need to check that everything looks good

[ ] Incorporate von Economo atlas in NSPN code
[ ] Send HCP parcellation data to JS deadline 1st August
[x] Write RA job description deadline 21st July
[ ] Update data management team on Cambridge repository
[ ] Email to SW & PV re analysis update

Blogs/interviews/writing

[ ] Edit story engine for Mozilla
[ ] Blog telling people to apply for OpenCon, Moz Open Leadership & MozFest

sigh didn't end up doing 😭

Invited talks
Applications

MozFest

[x] Building an open research culture at the Turing
[x] OpenAdvice

MozFest & Moz Open Leaders

[x] Feedback to EC
[x] Feedback to IS
[x] Feedback to SH
[x] Feedback to HumanityX
[x] Feedback to RL

OpenCon

[x] Feedback to SH
[x] Feedback to IS
[x] Own application

Fragile Families

[ ] Send email about close of competition

BrainAge

[ ] Get code installed & running
[ ] Send questions to FL

OpenAdvice

[ ] Migrate to organisation ProjectOpenAdvice & build website there: https://projectopenadvice.github.io/
[ ] Merge jekyll pull request

OpenConCam

Closed with - AGAIN - so much not done 🙄


V1 - Landing Page - Request Access button is highlighted when clicked

Launch V1 landing page
Click Request Access for Project Console
Observed that the button is highlighted

@amolsontakke3576 work with Atul and @pranab-bajpai on how this should look/feel when clicking.

Verified that the issue is fixed