Save weights at any time between integral epochs

In caffe, one can save the model weights at any time, for example, in iterations of 32768.
But in mxnet, I can't find a way to save weights at any time, it seems that mxnet can only save weights in integral epochs, such as epoch 1, 2, 3 ...
I feel sorry, because for large-scale datasets, it takes several days for training for one epoch. So, if something wrong, then a lot of time is wasted.
Any solutions for this ? Please in detail.
Thanks.

Try to add follow code after batch_end_callback in 'base_module.py'.

arg_params, aux_params = self.get_params()
if epoch_end_callback is not None:
                for callback in _as_list(epoch_end_callback):
                    callback(nbatch, self.symbol, arg_params, aux_params)

When define 'mx.callback.do_checkpoint', you can pass 'period' to control number of iterations to save checkpoints.

@solin319  Thank you, I will have a try, and do you know some specific saving ways that just press 'Ctrl + C', then the training process stops and the model weights are saved automatically.

Hi @Yochengliu , I would like to follow up this topic and find someone who can possibly help you. Have you found any ways to meet your needs? @nswamy can you label this as 'feature request'?


Add SVI Profile capability

Change Summary
Implement profile management to apply on SVI interface
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue(s)
Fixes #349
Fixes #352
Component(s) name
Role: eos_l3ls_evpn
Proposed changes
Create a structure named svi_profiles to define a list of pre-configured parameters to apply on multiple SVI.
A new key is created at SVI level to apply profile.
Once PR #337 and #345 will be merged, these features will be applied as well.
How to test
In Tenant Networks configuration, create svi_profiles structure:
---
# SVI Profile
svi_profiles:
  GENERIC_DC_PROFILE:
    mtu: 1500
    enabled: false
    igmp_snooping: false
    ip_helpers:
      <IP_ADDRESS>:
        source_interface: lo100
        source_vrf: TENANT_A_PROJECT01

In SVI configuration, apply profile when required:
tenants:
  # Tenant A Specific Information - VRFs / VLANs
  Tenant_A:
    mac_vrf_vni_base: 10000
    vrfs:
      TENANT_A_PROJECT01:
        vrf_vni: 11
        svis:
          110:
            name: 'PR01-DMZ'
            tags: [DC1]
            enabled: true
            ip_address_virtual: <IP_ADDRESS>/24
            igmp_snooping_enabled: false
          112:
            tags: [DC1]
            name: 'PR01-DMZ'
            profile: GENERIC_DC_PROFILE
            ip_address_virtual: <IP_ADDRESS>/24

Todo

[x] Update documentation
[ ] Implement keys related to #337 and #345

Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have updated molecule CI testing accordingly
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Requires #345 to be merged and incorporated before proceeding.

Is this expected to get backported in to v1.1.x or will we have to cherry-pick this to get the fix for #352 ?

@blemmenes - I just updated the milestone, this will be targeted for release 1.1.1 - https://github.com/aristanetworks/ansible-avd/milestone/6

MKdocs issue seems to be a DNS resolution issue. Can be ignored since, after manual check, the link is working

Ready for review


Test transport

Add tests for transport

Codecov Report

Merging #30 into master will increase coverage by 19.39%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #30       +/-   ##
==========================================
+ Coverage    66.9%   86.3%   +19.39%
==========================================
  Files           7       7
  Lines         423     438       +15
  Branches        0      77       +77
==========================================
+ Hits          283     378       +95
+ Misses        140      35      -105
- Partials        0      25       +25

Impacted Files
Coverage Δ

aioelasticsearch/transport.py
89.18% <100%> (+29.77%)
:arrow_up:

aioelasticsearch/connection.py
77.58% <0%> (-1.73%)
:arrow_down:

aioelasticsearch/helpers.py
98.64% <0%> (-1.36%)
:arrow_down:

aioelasticsearch/compat.py
77.77% <0%> (+33.33%)
:arrow_up:

aioelasticsearch/pool.py
73.03% <0%> (+33.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebe568...cab42bc. Read the comment docs.


New version: KRTirtho.Spotube version 3.8.0

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

@KRTirtho winget releaser can be updated to vedantmgoyal9/winget-releaser@main which uses the newest komac version.


Error trade offer 26

Hello,
I have a problem with the id of an item more than 32 bits. I have error with number 26.
Skins 32-bit well shipped, and 64 did not.
Example:
ID of an item can not send<PHONE_NUMBER>
ID of an item can send<PHONE_NUMBER>
Data of skins read from the database

error number 26 seems to happen when you have more than 5 trades open with the same person.

don't use 64-bit integers, use them as strings.


Bugfix/get object path

resolves #1
private _getObjectPath(objectName: string) {
    const { path } = this.options;
    return posix.join(path || '/', objectName);
}

@alireza12prom For your review and merge
Please publish an update to the npm package as well.
Thanks.

Thanks. I'll publish a new version on npm as soon as possible.


example using conformToMask when the mask is createNumberMask

I can't find a way to use them together.
I tried to extract the mask from createNumberMask({...}) return function, passing the value to parse.
MaskArray is the extracted mask, but the following code is throwing an exception:
  let maskArray =   [/\d/, /\d/, /\d/, "[]", ".", "[]", /\d/, /\d/];
  let ctm = conformToMask('312.12', maskArray, {});

Cannot read property 'test' of undefined
at Object.n [as conformToMask] (eval at  (app.js:2766), :1:3029)
...
Any working example?

@andrea-spotsoftware This will work I think:
let maskArray =  () =>  [/\d/, /\d/, /\d/, "[]", ".", "[]", /\d/, /\d/];
let ctm = conformToMask('312.12', maskArray, {});

The [] are special array values that can only be processed if the mask is a function. Sorry about the confusion!

@andrea-spotsoftware Actually, ignore my answer above. I misunderstood your requirements.
So, to get this to work, try the following...
let maskArray = [/\d/, /\d/, /\d/, ".", /\d/, /\d/];
let ctm = conformToMask('312.12', maskArray, {});

The [] are special array values that are only required for caret positioning and they can only be used when the mask is a function (conformToMask doesn't accept mask functions, it only accept mask arrays).


Add/update site configs for s4, discover, cheyenne, default

Description
This PR adds/updates the site configs for University of Wisconsin S4, NASA Discover, NCAR-Wyoming Cheyenne.
Testing
With these changes, spack-stack builds on Cheyenne, S4 and Discover.
CI tests currently running at https://github.com/climbfuji/spack-stack/actions.
Dependent PRs

waiting on https://github.com/NOAA-EMC/spack/pull/36

CI tests are running here: https://github.com/climbfuji/spack-stack/actions

Could you update the submodule with the most recent NCO (and other) PR?

Could you update the submodule with the most recent NCO (and other) PR?

Done. The CI tests I linked above are still good in my opinion, thus I'll merge.


Fix index.d.ts being not installed

I'm using vue-moveable-1.6.0.
This PR fixes package.json and let a package manager include the type declaration file into a package.
I found index.d.ts is not installed under the node_modules/vue-moveable/ directory after TypeScript complained as follows:
Could not find a declaration file for module 'vue-moveable'. '/path/to/my/project/node_modules/vue-moveable/dist/lib/VueMoveable.common.js' implicitly has an 'any' type.
Try `npm install @types/vue-moveable` if it exists or add a new declaration (.d.ts) file containing `declare module 'vue-moveable';`

I tested this PR with the following procedure:
$ cd /path/to/vue-moveable
$ yarn pack
yarn pack v1.22.4
success Wrote tarball to "/path/to/vue-moveable/vue-moveable-v1.6.0.tgz".
Done in 0.07s.
$ tar tf vue-moveable-v1.6.0.tgz
package
package/LICENSE
package/README.md
package/dist
package/index.d.ts
package/package.json
package/dist/lib
package/dist/lib/VueMoveable.common.js
package/dist/lib/VueMoveable.umd.js
package/dist/lib/VueMoveable.umd.min.js
$ cd /my/another/project
$ yarn add /path/to/vue-moveable/vue-moveable-v1.6.0.tgz
$ ls node_modules/vue-moveable
dist  index.d.ts  LICENSE  package.json  README.md

Thank you for developing this component!

Thanks @yuttie

Released in v1.6.1


Split up Token Interface

I'd like to propose that we split up the token interface into a set of small interfaces that tokens can choose to implement.
pub trait Token {
    fn name(env: Env) -> Bytes;
    fn symbol(env: Env) -> Bytes;
    fn decimals(env: Env) -> u32;
    fn balance(env: Env, id: Address) -> i128;
    fn spendable_balance(env: Env, id: Address) -> i128;
    fn transfer(env: Env, from: Address, to: Address, amount: i128);
}

pub trait Mint {
    fn mint(env: Env, to: Address, amount: i128);
}

pub trait Burn {
    fn burn(env: Env, from: Address, amount: i128);
}

pub trait Allowance {
    fn allowance(env: Env, from: Address, spender: Address) -> i128;
    fn increase_allowance(env: Env, from: Address, spender: Address, amount: i128);
    fn decrease_allowance(env: Env, from: Address, spender: Address, amount: i128);
}

pub trait AllowanceTransfer {
    fn transfer_from(env: Env, spender: Address, from: Address, to: Address, amount: i128);
}

pub trait AllowanceBurn {
    fn burn_from(env: Env, spender: Address, from: Address, amount: i128);
}

pub trait Authorized {
    fn authorized(env: Env, id: Address) -> bool;
    fn set_authorized(env: Env, id: Address, authorize: bool);
}

pub trait Clawback {
    fn clawback(env: Env, from: Address, amount: i128);
}

pub trait Admin {
    fn admin(env: Env) -> Option<Address>;
    fn set_admin(env: Env, new_admin: Address);
}

This issue was first posted and discussed on Discord at:

https://discord.com/channels/897514728459468821/1114325793926037605

We will have a challenge implementing this in the SDK, because the SDK currently doesn't support very well a contract implementing multiple traits. We've really gotta deal with that, but if we do, the above would be pretty smooth.
There's an issue open for dealing with it:

#268

The path I suggest to implementing the above would be:
### Tasks
- [ ] Break up the interface per above. (So we can start referring to these separately, and start SEPifying them.)
- [ ] Join them back together into a super interface temporarily (to retain existing behavior)
- [ ] Get out the 💪🏻 and fix the multi-trait support: #268
- [ ] Remove the super interface.


enable Model Type for TorchHub/TFHub Registry

#524 is ready to be reviewed, and I'm working on to enable Model Type support for TFHub.


Update license to AGPLv3

Propose updating license for the repository to ensure that future use of the shenanigan-scanning tools is open and attributable back to the project.

I brought this up on Discord after I saw this tweet: https://twitter.com/LefterisJP/status/1487050478076764167
We have very strong suspicions a closed SaaS product has based their code on
 @rotkiapp
's code
 :Neutral face:

They have no attribution to us (or any other #opensource software) and they have no code opensource.

I would be very annoyed if someone used our code for closed SaaS without attribution.
I want to make sure we have a license that potentially gives some recourse if this happens. At least at a karmic level.

Let's say I use the code from this repo in a closed-source repo, but I don't modify the honestNFT code that I use.
Would the AGPLv3 restrictions/obligations apply to me?

@Barabazs - My understanding is that in the scenario you describe, you would have to make the code public if and only if you are distributing the code in any way. For example, if you have a server running a modified version of the code and this server has a public api, then you would be compelled to make the code public and share your changes. However, if you are using the modified code on a private server (even if for commercial use), I don't think you are compelled to make the code/changes public.

Here is a good description of the license from Fossa: https://fossa.com/blog/open-source-software-licenses-101-agpl-license/

We're going to stay on MIT for the time being.


build(flux): update flux to v0.184.0

v0.184.0 did not build correctly in OSS due to cross compilation. We'll just skip to v0.185.0 where we removed that code (hopefully) temporarily until we have time to determine what caused the cross compilation issue.

I was able to get v0.184.2 to pass so we are updated now. My PR was green in CI. The latest commit on master has litmus test failures, but it looks unrelated.
https://github.com/influxdata/influxdb/pull/23758


Replace enterprise remote embeddings with get context query

Enterprise-only
getCodyContext GraphQL endpoint works in Sourcegraph 5+, however it is a keyword search.
Replaces Remote Embeddings for Enterprise
Backend implementation details will change, but the interface should be stable

Remote embeddings are gone in #2879.


Resize should fix width of column being resized

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
fixes #307
What is the new behavior?
Resize excludes recalculation of current column width.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Awesome! Thanks for your contribution! Can you write a test for this? Its quite a complicated function wanna make sure we don't regress.

Sure I'll try to write tonight. Do you have existing test case I can copy from?

@amcdnl wrote two test cases around the function but not sure how to write the test case for the component. I might have to apply the styles to make sure the widths are calculated correctly?

Perfect! Thank you!


Error 'google is not defined'

I installed extract-streetview with npm, and ran the following command with the results shown:
C:\Users\rick1>extract-streetview 36.1517908,-114.5641652,17 > Downloads\panorama.jpg
ReferenceError: google is not defined
at extract (C:\Users\rick1\AppData\Roaming\npm\node_modules\extract-streetview\index.js:83:9)
at parseLocation.then.location (C:\Users\rick1\AppData\Roaming\npm\node_modules\extract-streetview\index.js:35:21)

same problem on windows. Mac is OK.

same here on linux


test(dtslint): add dtslint test for of observable static function

Description: Add dtslint test for of observable static function
Related issue (if exists): #4093

Pull Request Test Coverage Report for Build 7830

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.805%

Totals

Change from base Build 7818:
0.0%

Covered Lines:
5242

Relevant Lines:
5415

💛  - Coveralls

Thanks again, @dkosasih


Pointers are awesome and there are many reason to use a pointer such as not having to copy a param, being able to mutate a param, etc. But, using pointer is makes you prone to nil pointers, and people who use your functions often try to pass nil and you have to handle this. I genuinely think there is potential here for a way to improve the developer experience by providing compile time errors for invalid nil pointers.
Side note: One of the main reasons I love Golang is because it's an opinionated statically typed language that provides a great developer experience. I get lint warnings if i don't add proper comments and that is wonderful.
Current options - landmine runtime error
Check all params for nil and panic or return error.
func example(param1 *Type1, param2 *Type2) (*Result, error) {
  if (param1 == nil) {
  // or perhaps better to panic so a developer isn't caught by a runtime error in prod
   return nil, fmt.Errorf("Param1 cannot be nil")
 }
  if (param2 == nil) {
  // or perhaps better to panic so a developer isn't caught by a runtime error in prod
   return nil, fmt.Errorf("Param2 cannot be nil")
 }

// actual function logic
}

Goal
func foo(a <- chan int) *Type1{
    if <-a < 0 {
        return nil
    }
    return newType1(a)
}

func example(a #Type1) {
    ...
}

go func(){
    // read from network
    ch <- fromNetwork()
}
// Compile error: cannot use  untype nil as type *Type1 in argument to example
example(foo(ch))

v  := foo(ch)
if v != nil {
  // compiles successfully
  example(v)
}

var newVar *Type1
// Compile error: cannot use newVar (untype nil) as type *Type1 in argument to example
example(newVar)

newVar = &Type1{}
// compiles successfully
example(newVar)

func call(t *Type1) {
 if t == nil {
   return
 }
  // compiles successfully
  example(t)
}

Proposal 1 - non-nil pointer character - backward compatible
Introduce a character that implies a non-nil-able pointer. In this example, the character is #.
func example(param1 *Type1, param2 #Type2) (*Result, error) {

In this case, param1 could be nil but param2 would give a compile time error if someone passed in nil.
I'm not an expert at the language so perhaps someone else can tell me if there is a better way than this.
Alternative Proposal 2 - Not Nil Union Type - backward compatible
This is more elegant but it could break people's code on library updates. For example, if you are relying on a library that updated to use this, your code would give compile time errors saying you can't use nil here. But, perhaps it is good because if the developer updates the library and you get compile time errors, you shouldn't have been passing nil into the function anyway and it saved you from a runtime error. 🤷♂
func example(param1 *Type1 , param2 *Type2 | !nil) (*Result, error) {

In this case, param1 could be nil but param2 would give a compile time error if someone passed in nil.

Template

Would you consider yourself a novice, intermediate, or experienced Go programmer?

intermediate

What other languages do you have experience with?

C++, Typescript, HTML, CSS, Python, SQL

Would this change make Go easier or harder to learn, and why?

A little harder because the would need to learn # is a non nil pointer.
Little easier because they could write more safe code.

Has this idea, or one like it, been proposed before?

An ultimate solution to change fundamentally how nils work in Golang has been suggested, but I didn't see anything that was limited in scope and would provide much value such as this proposal.

If so, how does this proposal differ?

This change is limited in scope and focuses on keeping Go 1 compact while delivering of a better developer experience.

Who does this proposal help, and why?

Developers. It moves runtime issues to compile time saving time and forcing them to handle nils better.

Is this change backward compatible?

Yes

Breaking the (Go 1 compatibility guarantee)[https://golang.org/doc/go1compat] is a large cost and requires a large benefit.

Does not break Go 1 compatibility / compat

Show example code before and after the change.

Shown above.

What is the cost of this proposal? (Every language change has a cost).

Compiler would need to understand if a variable can be nil or not based on if a nil check as been done beforehand.

How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?

My understanding of these tools are limited. From my understanding as long as the underlying AST parser is updated to support the character, it shouldn't be major impact for many tools. But, there would need to be changes to how the compiler works.

What is the compile time cost?

I don't know. Though this will increase compile time as a trade off to prevent compile time errors.

What is the run time cost?

none

Can you describe a possible implementation?

Described above.

Do you have a prototype? (This is not required.)

I do not.

How would the language spec change?

# would mean a pointer type that is not nil

Orthogonality: how does this change interact or overlap with existing features?
Is the goal of this change a performance improvement?

No

If so, what quantifiable improvement should we expect?
How would we measure it?
Does this affect error handling?

No

If so, how does this differ from previous error handling proposals?
Is this about generics?

No

If so, how does this differ from the the current design draft and the previous generics proposals?

At the core of this is a better developer experience by giving compile time error instead of runtime errors.

As mentioned above in https://github.com/golang/go/issues/36884#issuecomment-580080773, in order to make code like this work
    if a != nil {
        F(a) // where F is defined using #
    }

we need to add a notion of dataflow to the language, so that all compilers will analyze this code in the same way.  That is a significant complexity that we want to avoid.
The suggested # syntax only supports pointer types, but of course there are other kinds of types that can be nil: slices, maps, channels, functions, interfaces.
For these reasons this is a likely decline.  Leaving open for four weeks for final comments.

No further comments.  Closing.


Add square visualizer class

In the January 17, 2023 developer meeting, we discussed whether we ought to make the main visualizer canvas rectangular or square.
@katestange thought it should be rectangular (as big as we can make it with our planned UI changes where we'd have the "control panel" on the left side of the screen and the "thumbnails/bundles" on the right side). The idea is that individual visualizers can use a square portion of the rectangular canvas if they want to. @gwhitney and I agreed with this decision.
The question then became: "How do we make it so that square visualizers don't have to repeat code to enable use of a square portion of the canvas?" @gwhitney suggested for square visualizers we set the origin to be the center rather than the upper left corner of the canvas, which is the default for p5. Then we could take the min of the width and the height to be the bounds for the portion of the canvas we want to draw on. This seems like a reasonable approach that wouldn't require us to fiddle with styling.

We should determine based on the collection of visualizer overhauls for alpha whether this will actually be useful, and if so, implement it as part of those overhauls. Or drop this proposal altogether. But setting the milestone since we should resolve this.

Actually, it seems to me that the only thing one needs to do for a "Square" visualizer class is just implement the requestedAspectRatio() method to return 1. So there is nothing left to do here. Closing.


add the liveness and readiness to helm charts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.alonlong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Pyroscope do not have health check or liveness check endpoint as of now, so adding this feature will not be a good idea at the moment. Putting it on hold
@petethepig you can comment here once these endpoint is supported by pyroscope.
Also checks are failing for this PR:

there is not chart version bump
Readme is not updated with helm-docs

merged


home-manager: 2019-06-25 -> 2019-09-04

Motivation for this change
Version bump.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

I rebuilt my home-manager configuration with the new version.


If I have multiple apps in my ASE, how do I restrict traffic for a particular app?

I have an ILB ASE with WAF and I have multiple apps there. Obviously, they all have the same IP. I can't use Access Restrictions for the App Service as I also use Azure Firewall, so I thought maybe I can use WAF custom rules. But how can I restrict the destination (which is a FQDN)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8055b14d-f73f-2d8c-ad9a-38fdaedbc1a8
Version Independent ID: c8abc944-00c9-d2a9-4f29-e5195f5916e8
Content: Create and use Azure Web Application Firewall (WAF) v2 custom rules
Content Source: articles/application-gateway/create-custom-waf-rules.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for reaching out. We are actively investigating and will get back to you soon.

@alvipeo, Appreciate your patience. You can restrict traffic to a particular app in ASE using WAF custom rules. There are some samples here in this doc for your reference.

I read those docs. The example would really help!

@alvipeo, I wish to engage with you offline further for a detailed look and to provide a specialized assistance to you, so could you please send an email to me - AzCommunity[at]Microsoft[dot]com referencing this thread and your subscription ID. Since we will work with you offline I will close this issue out.
Also, I'm also sharing your feedback with the content owner (@vhorne ) to review further on adding examples in the document.

Thank you! Email is sent.

Thank you! Email is sent.

@alvipeo - I realize this is old and you may not remember, but on the chance you do, would you mind sharing any examples of your solution? I would appreciate it - I have a similar situation with multiple apps in an ILB ASE.
Thank you,
Mark

Thanks so much for sharing and responding, @alvipeo!
Apologies if I missed something, but is this complete? I don't see where variable $hostCondition is used after you've defined it. Also, not sure where you've defined the the variable $ipWhitelisting that you reference in the following statement:
$allowApiAllExceptIPsRule = New-AzApplicationGatewayFirewallCustomRule -Name AllowSomeIPs
-Priority $priority -RuleType MatchRule     -MatchCondition **$ipWhitelisting**
-Action Block`
Again, sorry if I've missed something obvious, and thanks again.
-Mark

No, this is just a small part of the script. Basically, you have to apply the rules to WAF, for example:
# apply to WAF
$a = Get-AzApplicationGateway -Name $appGwName -ResourceGroupName $resourceGroup

$a.FirewallPolicy

$a.FirewallPolicy = New-AzApplicationGatewayFirewallPolicy -Name "RestrictIPsForApi" -ResourceGroupName $resourceGroup -Location $location -CustomRule $allowApiAllExceptIPsRule, $allowToTransMCRule, $allowToTransVocRule, $allowToTransPlaidRule, $allowToTransSentralRule
Set-AzApplicationGateway -ApplicationGateway $a

Here I have multiple rules applied.


host the dataset for anyone to use

The dataset has been pushed to Kaggle and can be viewed in the link below.
https://www.kaggle.com/datasets/aviiciii/tamil-words-frequency


Fixes #29210 - support el8

@ekohl I noticed el7 tests were missing here so I added those as well. If that's intentional, please let me know why and I'll remove them. Thanks!

See https://github.com/theforeman/puppet-dns/commit/bf846e44b901eb51b1e15e660e339a11b5cabcce / https://github.com/theforeman/puppet-dns/pull/151#issuecomment-557836499 for the EL7 history. It may work to use the CentOS 7.6 container image instead of the latest 7.

@wbclark Also, needs a rebase.

Due to https://github.com/docker/for-linux/issues/835 , services are failing to start in the Travis test environment, causing test failures.
However all tests are succeeding when I run them locally on a vagrant_libvirt el8 VM.
@ehelms what are your thoughts on adding el8 support without adding tests to the travis config, similarly to what we previously did for this project on el7?

I think this sounds like a good approach given the limiting factors of our testing environment. I'll defer to @ekohl or @mmoll as primary maintainers of the module.

I am OK with this, as a fix for the time after 2.1 branching seems to be in the works.

merged, thanks @wbclark!


Add charset=utf-8 to HTML responses

Detailed description
This changes the Content-Type for HTML from text/html to text/html; charset=utf-8. This should be correct for the vast majority of cases.
Future work could include using rchardet.
To do

[x] Tests

Related issues
Fixes #19.

rchardet is not reliable enough to use, I think.

Closing as this is not a viable solution.


boolean datatype returned as nulltype

Using version
ibm-db | 3.0.1
ibm-db-sa | 0.3.3
I have a Db2 table with a BOOLEAN column
Boolean column in table ddl
CREATE TABLE "SCHEMA."TABLE"  (
		  ...
		  "VALUE_B" BOOLEAN ,
		  ...

I get the following warning every time I read the table:
python3.7/site-packages/ibm_db_sa/reflection.py:255: SAWarning: Did not recognize type 'BOOLEAN' of column 'VALUE_B'

and the column gets assigned sqlalchemy.types.NULLTYPE by default in bm_db_sa/reflection/DB2Reflector/get_columns
Is it possible to add support for BOOLEAN columns so that they are not returned as nulltype?

Hi @singhshraddha
I was trying to reproduce the problem you were facing.
Could you please help me with a few more details.

The OS details where your application is running (MAC/Linux/Windows)
It will be good to try out in the same OS.

Thanks.

Hi @singhshraddha
As per my understanding it looks like that the Boolean support issue has been fixed in the new version of ibm_db.
Could you try and update the version of ibm_db from 3.0.1 to 3.0.2 and try.
Thanks.

Hi @singhshraddha
I was trying to reproduce the problem you were facing.
Could you please help me with a few more details.
1. The OS details where your application is running (MAC/Linux/Windows)
   It will be good to try out in the same OS.

Thanks.

Hi @amukherjee28
my production environment is RHEL 8 and I haven't solved the issue there
my dev environment is macOS Catalina and I successfully bypassed this issue using several ways (casting, adding boolean in ischema_names)
I will try upgrading the ibm-db version as you suggested

After upgrading ibm-db==3.0.2 and ibm_db_sa==0.3.3, it doesn't work on RHEl 8, but works on MacOS Catalina
Still have the same issue in RHEL8 - when a boolean column with nullable=True is read in, it reads in all values as None

Thanks @singhshraddha for the update.
Will have a look at RHEL 8 from our end and update.
Thanks.

@singhshraddha
I investigated on RHEL8 (AMD64) and here is what my observations are :

WITH THE BELOW CONFIGURATION
ibm-db (3.0.1)
ibm-db-sa (0.3.3)
CREATE TABLE "boolTab1" (
"ID" INT NOT NULL GENERATED BY DEFAULT AS IDENTITY (START WITH 1),
"Name" VARCHAR(30),
"Home Student" BOOLEAN,
PRIMARY KEY ("ID"),
CHECK ("Home Student" IN (0, 1))
)
2020-06-25 04:53:57,387 INFO sqlalchemy.engine.base.Engine SELECT "boolTab1"."ID", "boolTab1"."Name", "boolTab1"."Home Student"
FROM "boolTab1"
2020-06-25 04:53:57,387 INFO sqlalchemy.engine.base.Engine ()
(1, 'Arnab', None)
(2, 'Bibek', None)
(3, 'Pathak', None)

AFTER UPGRADING IBM-DB to 3.0.2
ibm-db (3.0.2)
ibm-db-sa (0.3.3)
2020-06-25 04:56:41,979 INFO sqlalchemy.engine.base.Engine SELECT "boolTab1"."ID", "boolTab1"."Name", "boolTab1"."Home Student"
FROM "boolTab1"
2020-06-25 04:56:41,979 INFO sqlalchemy.engine.base.Engine ()
(1, 'Arnab', True)
(2, 'Bibek', False)
(3, 'Pathak', False)
Boolean datatype seems to return proper results.
If You continue to see the wrong results then I would require a few more details form your end.

Are you using the default clidriver that comes with ibm_db or are you using your own version of clidriver. If so can you please specify the version of the clidriver used. (using db2level command)
Can you please provide us with the trace file.
You can have the trace generated using the below steps  :  (in the RHEL8 Machine)

a. set the LD_LIBRARY_PATH environment variable to the clidriver/lib path
b. set the PATH environment variable to clidriver/bin and clidriver/adm path
c. once the above path is set run : db2trc on -f trc.dmp
d. Run your application
e. Next run : db2trc off
f. then generate the cli trace file using : db2trc fmt -cli trc.dmp trc.cli
g. db2trc fmt trc.dmp trc.fmt
h. db2trc flw trc.dmp trc.flw
Once you have the above trace file can you pass the trc.cli trc.fmt and trc.flw file so that we can have a deeper look.
Thanks.

Also confirm if server level is same.
As well, make sure when you reproduce the error, its using 3.0.2 package and not 3.0.1 package.
This issue in fixed in 3.0.2 in ibm_db driver. With older versions of Db2 i.e v11.1 ones, you will see 0/1s and with newer versions(v11.5) you sill see True/False if inserted as True/False.

@SabaKauser @amukherjee28 Thank you for your analysis. I am running Db2 on Cloud, and this is working as intended now. I am unsure as to what fixed it

@singhshraddha thank you for the update.
So I assume that the upgrade worked fine for you and now things are working fine. I am closing the issue in that case.
Thanks.


rpmspec crate

Sorry, this is an awkward way to reach out, but the email listed on your github didn't work and your website appears to be down.
I noticed that you have ownership of the "rpmspec" crate but that the crates got yanked and the repository deleted.
https://crates.io/crates/rpmspec
I'm curious if you would be OK with allowing us to use the crate name, and potentially continue maintaining your library?
We're working on a specfile parsing library and "rpmspec" is the most obvious name.  But making a building and parsing library would be great, too, and we'd be interested in continuing your work on that portion also.
https://github.com/rpm-rs/rpmspec-rs
If you would rather not, that is perfectly OK (of course).  But if you're not using it and it's something you're open to, let me know.  Thanks.

Daniel

@vv9k ^

Hello,
Sure thing, I'd be up to transfer the rights to the crate name. I'm not really used to this process so do I have to add someone as an owner of the crate or what exactly are the steps to accomplish this?

I've sent you an invite to add a new owner to this crate

Feel free to remove me :) good luck with the project!


CDRemoteSystemConnectionRequest to device that is connected via cloud return CDRemoteLauncherUriStatusRemoteSystemUnavailable

CDRemoteSystemConnectionRequest to device that is connected via cloud returns status CDRemoteLauncherUriStatusRemoteSystemUnavailable. In result request succesfully opens Uri on remove device. How can I detect a success result for CDRemoteSystemConnectionRequest in this case?

@revolutionkpi CDRemoteLauncherUriStatusRemoteSystemUnavailable is the best available information that we provide about the success or failure of the request in this situation. You may be running into a known issue that we have recently fixed.  Expect a new release, containing this fix, soon.

@revolutionkpi have you had a chance to test out the latest release to see if it fixes this issue?

I have just moved to 0.12.0 SDK and it works fine. Thanks.


Animation Breaking after exporting from BlockBench

I tried to make a character for my friend, but after opening it in Minecraft, Walking, Running flying etc. animation are broken.
https://user-images.githubusercontent.com/118483353/202557016-f1ebd6cd-ea32-4dc5-99b1-1736c2089392.mp4
Here's the example of Walking, Swimming, Elytra flight animations.
Here's the model if it helps:
Model.zip
P.s. I have tried to fix offsets in modelling tab.
P.P.s Don't ask me why texture sheet is so big.

Okay, I fixed it, just had to fix pivot points in BlockBench


Optimize LinkedList::len

Local benchmarks show that when using this list in a real-world application (web3 related), a significant amount of time is spent in LinkedList::len. After some extra profiling with perf it shows that most time is spent in useless instructions after the unreachable!. Since these are not reachable, they can simply be deleted.
       │     .map_or(0, |node| unsafe { node.as_ref().next.len() + 1 }):
 87.50 │       movzbl  (%r12),%edx
  2.08 │       test    %dl,%dl
       │     → je      Node::as_ref
       │       mov     %r12,%rcx

Sadly no, I have already sold the benchmarks for 2 SOL. If you want to, I can try reproducing them. Just send another 2 SOL to my wallet rV5mzGJikzFqHKiWhzszuqcJtP4vGN5LaqihzuGnEhhw.


Update upgrade-domain-controllers.md

I don't know why the steps here said to add a new domain.  Adjust picture and text.

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team
#assign: @robinharwood, @Xelu86


Upload Cryptune (CPT)

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x ] Filename in the lowercase format
[x ] Image format: png
[x ] Image size: 256 by 256 px

We have tried 5 times to upload our logo and every time it fails with message
0x6b01c3170ae1efebee1a3159172cb3f7a5ecf9e5.jpeg image must be png
npm ERR! Test failed.  See above for more details.
we don't know where this is coming from as this is not our contract number.

not working!!!!!!!!!


datadog: tracer_stats portion of new tracing library

This is part of the initiative described in https://github.com/envoyproxy/envoy/pull/23958.
This revision introduces a new library dependency for Datadog tracing, and adds a small component that will be used in the future when more of the new library is integrated into the Datadog tracing extension.
tracer_stats factors out the existing DatadogTracerStats and renames it to TracerStats. It also keeps the macros scoped to the header file, and omits some statistics.
The statistics omitted, traces_sent and timer_flushed, are those that could only be reported by the collector (datadog::tracing::DatadogAgent). Rather than create a statistics abstraction for the collector interface in dd-trace-cpp, I instead omitted the statistics from this extension. I think that the reports_* statistics (published by the HTTP client) are sufficient for tracking the behavior of the tracer.

/assign @jmarantz

/lgtm deps

/retest

/assign-from @envoyproxy/senior-maintainers
Ryan is a senior maintainer but he approved only for API.

needs main merge also

/wait
for main merge

/retest

/retest

:tada: Thanks @jmarantz and @ggreenway


HOTT-2566 Add all PSRs page

Jira link
HOTT-2566
What?
I have added/removed/altered:

[x] Add api client for fetching all PSRs for a given commodity
[x] Added all PSRs page
[x] Allow using standardised page_header without a caption

Why?
I am doing this because:

We want to show all PSRs across all schemes for a  valid commodity to allow traders to choose their supply chain based of favourable trade agreements with the United Kingdom

Have you? (optional)

[x] Validated mobile responsive behaviour of view changes

Deployment risks (optional)

Low

Screenshots

Should we clear-up some of the test setup to satisfy rubocop?

Fair point, I can take a look

Fixed :+1:


Recreating paper results

Hello,
I am having difficulty recreating your paper results.
I'm currently running your code on the data you provided with pre-trained models with the config values of:
patch_size = [64, 64]
sample_amount = 1191
I then average KLD and get KLD ~0.5 .
Should running test noise models.py with these settings recreate the paper's KLD (~0.00159)?

I have the same problem as user tomk2005, can you upload more detailed requirements?

Hi!
same for me.
Here are the results I achieved running the code over the provided test set, without any changes in the config file, except for the data_dir. I used the pretrained models provided.
--> Denoiser Test (PSNR)
average psnr ours: 47.841578781906506
average psnr g: 41.00051686254721
average psnr pg: 46.08441194932963
average psnr noiseflow: 47.147988764349506
average psnr ours real: 47.71135122092602
average psnr real: 46.7334418265441
--> Noise Models Test (KLD):
G: 0.6178 | PG: 0.0685 | Ours: 0.1171  [** noise-flow results are not presented]
The denoiser's results make sense, yet not fully aligned with the results presented in the paper (Table 7).
On the other hand, the noise model results are completely

Hi! same for me.
Here are the results I achieved running the code over the provided test set, without any changes in the config file, except for the data_dir. I used the pretrained models provided.
--> Denoiser Test (PSNR)
average psnr ours: 47.841578781906506 average psnr g: 41.00051686254721 average psnr pg: 46.08441194932963 average psnr noiseflow: 47.147988764349506 average psnr ours real: 47.71135122092602 average psnr real: 46.7334418265441
--> Noise Models Test (KLD):
G: 0.6996052614889056 | PG: 0.06394353525639518 | Ours (CA-NoiseGAN): 0.03184607044417602 [** noise-flow results are not presented]
The denoiser's results make sense, yet not fully aligned with the results presented in the paper (Table 7). On the other hand, the noise model results seem completely wrong, particularly compared to the ones presented in the paper (Table 1).
Any help here? :)

Can you leave an email address for me? Let's talk about noise modelling?


Php cs fixer

Hi there,
Few php-cs-fix, mostly single_blank_line_at_eof.
Feel free to remove it if you don't agree.

Thank you!


GPTQ / Quantization support?

Will vLLM support 4-bit GPTQ models?

Thanks for the feature request! Quantization is not currently supported, but it's definitely on our roadmap. Please stay tuned.

How do I best go about tracking this? Is there a discord or public roadmap somewhere I can look at?

Any update for GPTQ support?

How do I best go about tracking this? Is there a discord or public roadmap somewhere I can look at?

See Roadmap here: https://github.com/vllm-project/vllm/issues/244

I looked into this a bit today and it seems straight forward to integrate AutoGPTQ into vllm, so I implemented a draft for LLaMA (see this commit) and did a few benchmarks on single A100-80G. I don't know why but It's slower than expected.
python benchmark_throughput.py --model TheBloke/Llama-2-13B-chat-GPTQ --dataset ShareGPT_V3_unfiltered_cleaned_split.json

Model
Throughout (requests/s)
Throughout (tokens/s)

meta-llama/Llama-2-13b-chat-hf
4.00
1915

TheBloke/Llama-2-13B-chat-GPTQ
3.32
1587

TheBloke/Llama-2-70B-chat-GPTQ
1.09
519

I looked into this a bit today and it seems straight forward to integrate AutoGPTQ into vllm, so I implemented a preliminary version for LLaMA (see this commit) and did a few benchmarks on single A100-80G. I don't know why but It's slower than expected.
python benchmark_throughput.py --model TheBloke/Llama-2-13B-chat-GPTQ --dataset ShareGPT_V3_unfiltered_cleaned_split.json

Model	Throughout (requests/s)	Throughout (tokens/s)
meta-llama/Llama-2-13b-chat-hf	4.00	1915
TheBloke/Llama-2-13B-chat-GPTQ	3.32	1587
TheBloke/Llama-2-70B-chat-GPTQ	1.09	519

what's the baseline with normal version?

As an update, I added tensor parallel QuantLinear layer and supported most AutoGPT compatible models  in this branch. The code has not been thoroughly tested yet because the combinations of model architectures and GPTQ settings are way too many.

@chu-tianxiang do you keep track with vLLM team work ? I saw that the revision param in EngineArgs was implemented, which would be more than helpful on your branch 🙏

@chu-tianxiang I tried forking your vllm-gptq branch and was successful deploying the TheBloke/Llama-2-13b-Chat-GPTQ model. However, when I tried the TheBloke/Llama-2-7b-Chat-GPTQ model, it threw the following exception whenever I made a query to the model. I wonder if the issue is with the model itself or something else. I'll dig further into this when I have the chance but it's likely the Sampler was generating the probability tensor with invalid values
INFO:     <IP_ADDRESS>:52663 - "POST /v1/completions HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/home/ubuntu/vllm-gptq/vllm/engine/async_llm_engine.py", line 28, in _raise_exception_on_finish
    task.result()
  File "/home/ubuntu/vllm-gptq/vllm/engine/async_llm_engine.py", line 351, in run_engine_loop
    has_requests_in_progress = await self.engine_step()
                               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/engine/async_llm_engine.py", line 330, in engine_step
    request_outputs = await self.engine.step_async()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/engine/async_llm_engine.py", line 191, in step_async
    output = await self._run_workers_async(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/engine/async_llm_engine.py", line 220, in _run_workers_async
    all_outputs = await asyncio.gather(*all_outputs)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/.pyenv/versions/3.11.3/lib/python3.11/asyncio/tasks.py", line 684, in _wrap_awaitable
    return (yield from awaitable.__await__())
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ray.exceptions.RayTaskError(RuntimeError): ray::RayWorker.execute_method() (pid=68296, ip=<IP_ADDRESS>, actor_id=3b90ca9f90ebf20a67ae6c2c01000000, repr=<vllm.engine.ray_utils.RayWorker object at 0x7ef09122dad0>)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/engine/ray_utils.py", line 32, in execute_method
    return executor(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/.pyenv/versions/vllm-gptq/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/worker/worker.py", line 305, in execute_model
    output = self.model(
             ^^^^^^^^^^^
  File "/home/ubuntu/.pyenv/versions/vllm-gptq/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/model_executor/models/llama.py", line 296, in forward
    next_tokens = self.sampler(self.lm_head.weight, hidden_states,
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/.pyenv/versions/vllm-gptq/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/model_executor/layers/sampler.py", line 85, in forward
    return _sample(probs, logprobs, input_metadata)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/model_executor/layers/sampler.py", line 451, in _sample
    sample_results = _random_sample(seq_groups, is_prompts,
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/vllm-gptq/vllm/model_executor/layers/sampler.py", line 342, in _random_sample
    random_samples = torch.multinomial(probs,
                     ^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either `inf`, `nan` or element < 0

Hi,
If anyone wants try GPTQ quantizationo in vLLM.
Please use this repo QLLM to quantize model(LLama) and it would compatiable AWQ in vLLM.
And Of courcr you can select AWQ to quantize it as well.

Hi, If anyone wants try GPTQ quantizationo in vLLM. Please use this repo QLLM to quantize model(LLama) and it would compatiable AWQ in vLLM. And Of courcr you can select AWQ to quantize it as well.

Something is off with this QLLM gptq quantization... all the dependencies aren't specified in requirements file. Also, 3 times tried quantizing and every time it breaks when it tries to save the file or quant is done. Tried Llama2-70b and mistral 7b

Hi, If anyone wants try GPTQ quantizationo in vLLM. Please use this repo QLLM to quantize model(LLama) and it would compatiable AWQ in vLLM. And Of courcr you can select AWQ to quantize it as well.

Something is off with this QLLM gptq quantization @wejoncy ... all the dependencies aren't specified in requirements file. Also, 3 times tried quantizing and every time it breaks when it tries to save the file or quant is done. Tried Llama2-70b and mistral 7b

Hi,
Thanks for try this out and sorry for the inconvenient. This bug has been fixed in latest:main.
For now, you can have too ways to use GPTQ quant method in vLLM with qllm tool.

such as Llama-families, convert to AWQ ifi you didn't enable act_order and set bits==4 and there is no mix bits inside.
use GPTQ directly. But the GPTQ branch in vLLM is on the way merged.

Is there any update for 8bit support? That would help Mixtral generate useable outputs on a single (non-overpriced) GPU.

I have successfully used both GPTQ and AWQ models with vLLM.
Should this issue be considered solved @WoosukKwon?

@hmellor it currently works with 4-bit, but not 8-bit. Currently you have to use chu-tianxiang/vllm-gptq to get 8-bit support.

Is vLLM well-supporting the int-2 GPTW models?
Thank you very much!

@hmellor @singularity-sg @jacobwarren @wejoncy @Symbolk @WoosukKwon


ensure docker is running when trying to run the datadog service

In systemd the After directive will only ensure execution ordering of
the specified units if they happen to be started at the same time, but
it does not specify a dependency relation.
Requires=docker.service will make sure docker is up and running before
attempting to run the commands of this service.
Signed-off-by: Petros Angelatos<EMAIL_ADDRESS>

@petrosagg thank you for this contribution, and good catch.


Deno & Deno Deploy

This would really be useful for Deno, especially Deno Deploy. Is a Deno port likely? Deno follows the browser's JavaScript much more closely than node, and Deno now has node hooks. Pleeeeese!

if Deno can load native nodejs bindings (dawn.node), it can run it.
I have tested the WebGPU in NodeJs, it can run successfully with dawn.node.

The dawn.node can be built from google dawn source https://dawn.googlesource.com/dawn , the README.md can be found in the folder dawn/src/dawn/node.

Deno used to support webgpu up until version 1.31.3. I installed that version using dvm.
Now you only need to import it like this using deno's CDN that converts npm modules to es6.
import torch from "https://esm.sh/webgpu-torch";


Add web support

Address #1 Added web support

When I Authorize(), window.AppleID returns undefined but console shows the object present inside window.

@mlynch - who needs to review this to be able to approve/merge/request changes etc?

Max will be partially maintaining this repo. Maybe you should take over since you wrote a good chunk of code in this PR

@chrisweight Max will be partially maintaining this repo and is looking for help to maintain it. Maybe you should take over since you wrote a good chunk of code in this PR

I have got exactly zero time, sadly!

Can someone clarify what SignInResponse and ResponseSignInWithApplePlugin are? They conflict yet have different structures

ResponseSignInWithApplePlugin

@mlynch - I can't find a reference to this on this PR?

It's in master and is conflicting and I'm not sure how to resolve

It's in master and is conflicting and I'm not sure how to resolve:
https://github.com/capacitor-community/apple-sign-in/blob/master/src/definitions.ts#L11

Ok, so the ResponseSignInWithApplePlugin is obviously what's being returned from the iOS plugin, and the SignInResponse is what's coming back from the web plugin, the latter matching the JSON response structure that Apple returns.
So, two choices I guess: Clarify the naming of each top-level response interface, e.g: ResponseiOS and ResponseWeb, then allow for both types in the Authorize method call, i.e: Authorize(): Promise<{ response: ResponseiOS | ResponseWeb }>;
Or define a common structure that can be used to mulch responses into the same form, regardless of platform.
@mlynch, @priyankpat - thoughts?

Also: the iOS plugin will need a noop for the Init method, right?

Weird, I pushed 2 commits but it's not getting reflected here. 889ce53e919fb507019d84037e9a1080b8516aff f734a650aba3681e9dac8fdb3d39503ebfff2acb
@mlynch @chrisweight I fixed the conflicts. Aggregated the return types. Should I make them optional?
export interface ResponseSignInWithApplePlugin {
  response: {
      ...
  };
  user: User;
  authorization: Authorization;
}

@mlynch I can merge this PR if you are good with the changes.

@mlynch I can merge this PR if you are good with the changes.

bump on this @mlynch ?

@mlynch I can merge this PR if you are good with the changes.

There's been no response on this - you should probably just merge the PR @priyankpat and then addresses any issues as separate fixes?

tumbleweed ... anyone?

Can someone resolve the conflict? Then can merge it

Is there any updates on this? Is there a documented way of this working for web? I have installed this branch but SignInWithApple.authorize() rejects with error SignInWithApple does not have web implementation.

Is there any updates on this? Is there a documented way of this working for web? I have installed this branch but SignInWithApple.authorize() rejects with error SignInWithApple does not have web implementation.

Is there any updates on this? Is there a documented way of this working for web? I have installed this branch but SignInWithApple.authorize() rejects with error SignInWithApple does not have web implementation.

@seanaye - it looks like @epicshaggy added web support in a separate PR and that was merged already.
@mlynch / @epicshaggy - might as well close this PR given #18 is now in master?

Is there any updates on this? Is there a documented way of this working for web? I have installed this branch but SignInWithApple.authorize() rejects with error SignInWithApple does not have web implementation.

@seanaye - it looks like @epicshaggy added web support in a separate PR and that was merged already.
@mlynch / @epicshaggy - might as well close this PR given #18 is now in master?

@mesqueeb it appears that this package is not updated frequently. I am not a maintainer but I have a fork that is working in production, both on web and capacitor ios

@seanaye is it possible that your package becomes the official community plugin? @dwieeb  do you have any ideas how we can make @seanaye's package the official one ?

@mesqueeb It is likely better if I just become a maintainer. The official package should not be moved out of the @capacitor-community namespace. I also don't have the knowledge to maintain this package on my own (I'm not a swift developer).
Here is the my fork, I've updated the readme to reflect how I'm using it. https://github.com/seanaye/apple-sign-in

@seanaye @mesqueeb Hi guys, web support was added in #18.  The package is live on npm, web implementation is the same as for iOS.  Checkout the readme, the Usage section was updated with the addition of web support.  If you're still getting errors do let me know. 😃


[WIP] Add localtofield refactoring based on rope functionality

I would like to add more of the functionality of rope into this plugin. I've started with the simplest and a very useful local-to-field refactoring command in the hope of getting a little bit of guidance and then tackling more complicated refactorings (those which need user input)
I don't think this PR includes all of the required TS changes, but I couldn't find one of the existing refactor methods to use as a template so I've marked this as WIP.
What does simpleRefactorProvider.ts do?

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)

Hi @tonybaloney, thanks for the contribution! I'll try to help with answering questions.
First, we generally work off of issues in our repo. Is there an issue that corresponds to the work that you are proposing? If there isn't one please feel free to create one and link it to this PR.
As for your questions:

I don't think this PR includes all of the required TS changes...

We would generally take contributions after there are adequate TS unit / system tests in place that fully prove out the feature (as best as possible of course) within our CI.

...I couldn't find one of the existing refactor methods to use as a template so I've marked this as WIP.
What does simpleRefactorProvider.ts do?

You've discovered the existing refactor methods! Within simpleRefactorProvider you will see a single exported function activateSimplePythonRefactorProvider. Within that function you will see two pertinent registrations on line 18 and 29 - these register the commands that invoke refactoring. Note that they are functors that are registered into the system (see the () => { ... } formatting?).
HTH.
A bit of a heads up, our team will review new PRs from external contributors generally in the next following sprint - so we might not get to reviews until January.

@d3r3kk thanks for all the pointers. I’ll raise an issue as well.

@d3r3kk done the end-to-end TS pieces, now just need to write the tests.

@d3r3kk Probably a silly question. But how do I get the tests to actually run?
The scripts seem to have unittests and functional tests. The functional tests download the extension from a website (which is not what I want)
The unittests seem to target the build version, not the source version?
"test": "node ./out/test/standardTest.js && node ./out/test/multiRootTest.js",
        "test:unittests": "mocha --require source-map-support/register --opts ./build/.mocha.unittests.opts",
        "test:unittests:cover": "nyc --nycrc-path ./build/.nycrc npm run test:unittests",
        "test:functional": "mocha --require source-map-support/register --opts ./build/.mocha.functional.opts",
        "test:functional:cover": "nyc --nycrc-path ./build/.nycrc npm run test:functional",
        "testDebugger": "node ./out/test/debuggerTest.js",
        "testSingleWorkspace": "node ./out/test/standardTest.js",
        "testMultiWorkspace": "node ./out/test/multiRootTest.js",
        "testPerformance": "node ./out/test/performanceTest.js",
        "testSmoke": "node ./out/test/smokeTest.js",

Closing this PR as this has been stale for over a month


steam: move libpciaccess as non-runtime dependencies

Motivation for this change
Some Eugen systems games need libpciaccess and since it doesn't overwrite anything it should be harmless for anything that doesn't need it.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


Fix 'is not exported from module "orderly_set"' typing errors

After switching from ordered_set to orderly_set the following typing error occurred (see below) because for a typed library all imports are considered private by default unless they are added to __all__ indicating that they are available for importing from the library.
I've listed all imported Sets in __all__ to fix the issue for all the package imports.
# "OrderedSet" is not exported from module "orderly_set"
#   Import from "orderly_set.sets" insteadPylancereportPrivateImportUsage

from orderly_set import OrderedSet

@Andrej730 Thanks for the PR. Merged it!


Ineffecient PluginSourceMapProxy::lookup_char_* can leads into plugin execution fails

Describe the bug
When source input code is large enough, and then if lookup_char_* (i.e lookup_char_pos) is being called enough amount of times, it can drain plugin runtime's memory space to lead into plugin execution fails. These are somewhat subjective, as input / execution count both needs to be some amounts.
Peeking implementation bit, it looks like due to we entirely exchange whole struct to Loc per each request, specifically
pub struct Loc {
    /// Information about the original source
    pub file: Lrc<SourceFile>,
...

While host shares it as Arc, per each request plugin actually gets whole copy of the SourceFile which is fairly large. Instead of serialize - deserialize whole Loc object, proxy should try to share SourceFile per whole transformation and only gets rest of properties for the Loc from the host.
Input code
No response
Config
No response
Playground link
No response
Expected behavior

Actual behavior
No response
Version
latest
Additional context
No response

Other places:
span_to_lines


Update fa2tree.py using ClipKIT API

Hi Zach,
Congrats on Mycotools - what a useful software suite for the community!!
Also, thank you for choosing ClipKIT as your multiple sequence alignment trimming toolkit. ClipKIT is currently under development, but a recent, stable release features a new API. We haven't written the docs yet, but it cleans up some of the code.
I'm not sure if I am handling the verbose option as you intend, so that is something to double-check.
Thank you again for choosing ClipKIT!
Best,
Jacob

Hey Jacob,
Thanks for your kind words and for making this pull request - I have finally been able to test it. Your proposed changes are certainly the pythonic way of doing things (which this old script needs more of), and I will merge it.
Hope you're well,
Zach

Yay - I am glad it helped!
best,
Jaocb


remove unmaintained tracker code

The metrics tracker project is no longer maintained.
Remove the following:

[ ] Badge at top of README
[ ] Privacy Notice from Readme
[ ] Disabling Deployment Tracking from Readme
[ ] Use of metric tracker in app, i.e. require('metrics-tracker-client').track();
[ ] The metrics-tracker library from requirement.txt or package.json
[ ] The repository.yml file at the app level

Update the deploy to ibm cloud button to use this image: https://bluemix.net/deploy/button.png
See https://github.com/IBM/watson-conversation-slots-intro/pull/71/files as an example

@stevemart - it looks like this was corrected - can you close out your issue?  tx

yes, done in https://github.com/IBM/real-time-payments/commit/8f9aa4fe5fcd0329397c13025c375c6e71a46be1


timeout (uu_timeout) for Windows

Hi, is it possible to fix timeout (uu_timeout) so that it can also build & work on Windows ?
Currently, it fails:
  Compiling uu_timeout v0.0.26 (C:\Users\runneradmin\AppData\Local\Temp\toolpacks\toolpacks_jpzxhinoezg_AMD64-Windows_NT\coreutils\src\uu\timeout)
error[E0433]: failed to resolve: could not find `unix` in `os`
  --> src\uu\timeout\src/timeout.rs:12:14
   |
12 | use std::os::unix::process::ExitStatusExt;
   |              ^^^^ could not find `unix` in `os`
   |
note: found an item that was configured out
  --> /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97\library\std\src\os\mod.rs:26:9
note: found an item that was configured out
  --> /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97\library\std\src\os\mod.rs:64:9

error[E0432]: unresolved import `uucore::process`
  --> src\uu\timeout\src/timeout.rs:17:13
   |
17 | use uucore::process::ChildExt;
   |             ^^^^^^^ could not find `process` in `uucore`

error[E0432]: unresolved import `uucore::signals`
  --> src\uu\timeout\src/timeout.rs:24:5
   |
24 |     signals::{signal_by_name_or_value, signal_name_by_value},
   |     ^^^^^^^ could not find `signals` in `uucore`

error[E0433]: failed to resolve: could not find `signals` in `uucore`
  --> src\uu\timeout\src/timeout.rs:68:26
   |
68 |             _ => uucore::signals::signal_by_name_or_value("TERM").unwrap(),
   |                          ^^^^^^^ could not find `signals` in `uucore`
   |
note: found an item that was configured out
  --> C:\Users\runneradmin\AppData\Local\Temp\toolpacks\toolpacks_jpzxhinoezg_AMD64-Windows_NT\coreutils\src\uucore\src/lib/lib.rs:77:26
   |
77 | pub use crate::features::signals;
   |                          ^^^^^^^

error[E0433]: failed to resolve: could not find `sys` in `nix`
   --> src\uu\timeout\src/timeout.rs:185:14
    |
185 |         nix::sys::signal::signal(
    |              ^^^ could not find `sys` in `nix`

error[E0433]: failed to resolve: could not find `sys` in `nix`
   --> src\uu\timeout\src/timeout.rs:186:18
    |
186 |             nix::sys::signal::Signal::SIGCHLD,
    |                  ^^^ could not find `sys` in `nix`

error[E0433]: failed to resolve: could not find `sys` in `nix`
   --> src\uu\timeout\src/timeout.rs:187:18
    |
187 |             nix::sys::signal::SigHandler::SigDfl,
    |                  ^^^ could not find `sys` in `nix`

error[E0425]: cannot find function `setpgid` in crate `libc`
   --> src\uu\timeout\src/timeout.rs:302:24
    |
302 |         unsafe { libc::setpgid(0, 0) };
    |                        ^^^^^^^ help: a function with a similar name exists: `getpid`
    |
   ::: C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\libc-0.2.153\src\windows\mod.rs:491:5
    |
491 |     pub fn getpid() -> ::c_int;
    |     -------------------------- similarly named function `getpid` defined here

error[E0599]: no method named `send_signal` found for mutable reference `&mut Child` in the current scope
   --> src\uu\timeout\src/timeout.rs:206:25
    |
206 |         let _ = process.send_signal(signal);
    |                         ^^^^^^^^^^^ method not found in `&mut Child`

error[E0599]: no method named `send_signal_group` found for mutable reference `&mut Child` in the current scope
   --> src\uu\timeout\src/timeout.rs:208:25
    |
208 |         let _ = process.send_signal_group(signal);
    |                         ^^^^^^^^^^^^^^^^^ method not found in `&mut Child`

error[E0599]: no method named `send_signal_group` found for mutable reference `&mut Child` in the current scope
   --> src\uu\timeout\src/timeout.rs:212:25
    |
212 |             _ = process.send_signal_group(continued_signal);
    |                         ^^^^^^^^^^^^^^^^^ method not found in `&mut Child`

error[E0599]: no method named `wait_or_timeout` found for mutable reference `&mut Child` in the current scope
   --> src\uu\timeout\src/timeout.rs:245:19
    |
245 |     match process.wait_or_timeout(duration) {
    |                   ^^^^^^^^^^^^^^^ method not found in `&mut Child`

error[E0599]: no method named `wait_or_timeout` found for mutable reference `&mut Child` in the current scope
   --> src\uu\timeout\src/timeout.rs:335:19
    |
335 |     match process.wait_or_timeout(duration) {
    |                   ^^^^^^^^^^^^^^^ method not found in `&mut Child`

error[E0599]: no method named `signal` found for struct `std::process::ExitStatus` in the current scope
   --> src\uu\timeout\src/timeout.rs:349:57
    |
349 |                         } else if let Some(sc) = status.signal() {
    |                                                         ^^^^^^ method not found in `ExitStatus`

Some errors have detailed explanations: E0425, E0432, E0433, E0599.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `uu_timeout` (lib) due to 14 previous errors

Not sure if this helps,
but busybox-w32 already has timeout : https://github.com/rmyorston/busybox-w32/blob/master/coreutils/timeout.c
I tested and that one works, so hopefully, it should be trivial to patch https://github.com/uutils/coreutils/tree/main/src/uu/timeout as well.


feat: add modules

feat: add module to enable/disable linger for a user

PR Review

 ⏱ Estimated effort to review [1-5]
4, due to the introduction of multiple new modules, integration tests, and updates across various configuration files. The complexity of the changes, especially with the addition of the linger module which interacts with system services, increases the review effort.

 🧪 Relevant tests
Yes

 🔍 Possible issues

Possible Bug: The subprocess call in linger.py does not check the return code of the loginctl command. This can lead to a scenario where the command fails silently, and the module incorrectly reports success.

Performance Concern: In linger.py, checking for the existence of the linger file for every execution might not scale well for systems with a large number of users.
 🔒 Security concerns
No

 Code feedback:
relevant fileplugins/modules/linger.py
suggestion

Consider using subprocess.run() instead of subprocess.call() for invoking loginctl to enable or disable linger. This allows checking the return code to ensure the command executed successfully. If the command fails, you can use module.fail_json() to appropriately handle the error. [important]

relevant linesubprocess.call([loginctl, "enable-linger", user])
relevant fileplugins/modules/linger.py
suggestion

To improve performance, especially on systems with many users, consider caching the result of the linger file existence check or exploring more efficient ways to determine the linger status. [medium]

relevant linelinger_exists = Path(f"/var/lib/systemd/linger/{user}").is_file()
relevant fileplugins/modules/linger.py
suggestion

For better modularity and readability, consider extracting the logic for enabling/disabling linger into separate functions. This can make the main function cleaner and improve the maintainability of the code. [medium]

relevant lineif state == "enabled":
relevant file.ansible-lint
suggestion

The exclusion of plugins/modules from ansible-lint checks with a TODO comment indicates a potential issue with linting these modules. It's important to resolve this to ensure code quality and adherence to best practices. Consider investigating and fixing the root cause of the linting error instead of excluding the directory. [important]

relevant line- plugins/modules # TODO: figure out why there's an error on documentation

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, require_can_be_split_review, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Update to purescript-aff#v4.0.2

This is related to https://github.com/truqu/purescript-indexedDB/issues/2.
Unfortunately this isn't just a version bump. I had to modify a lot of code include js to get it to compile and usable on my app using the latest versions of a bunch of libraries. As mentioned in the issue, I was able to get the test to compile but haven't been able to run it successfully.

Hey, thanks for the PR. I'll look into it as soon as I got some time. I am a bit busy at the moment to be honest :s ...

I've started to work on it. Almost there. It compiles test runs and two of them are failing. I'll have a look ASAP to see what's going on :+1:

Okay, resolved, it was just an oversight in the FFI code :+1:
I had to diverge quite a lot from the PR even though, in essence, the work was the same.
Thanks for it, it helped.


Transformer V2 @auth connection fields broken with groupClaims

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
15.14
Amplify CLI Version
7.6.25
What operating system are you using?
MacOS
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
First refer to the schema to understand the queries that will be made.
Querying our models with IAM, as expected:

Querying our models with OIDC, with the following claims in our token:
"<domain>/owner": ["test-1"]
Along with my sub: oauth2|github-3|70296188

As you can see, the ContactInformation that are returned are the ones where ownerID is equal to my users sub.
I rather expect, that the ContactInformation would be the ones where ownerID equals test-1.
Expected behavior
ContactInformation that are owned by test-1
Reproduction steps

Follow the given schema
Create the models ( an org, a user, 1-2 contact information for both the user and the org )
Query getOrganization with OIDC by requesting ContactInformation and observe that the instances that are returned are not the ones owned by the queried organization

GraphQL schema(s)
Context:
A ContactInformation can be owned either by an Organization or a User.
type ContactInformation @model(subscriptions: null)
  @auth(rules: [
    { allow: public, provider: iam },
    {
      allow: owner,
      provider: oidc,
      ownerField: "ownerID",
      identityClaim: "sub",
      operations: [ create, read, delete ]
    },
    {
      allow: groups,
      provider: oidc,
      groupsField: "ownerID",
      groupClaim: "<domain>/owner",
      operations: [ create, read, delete ]
    },
    {
      allow: groups,
      provider: oidc,
      groupsField: "ownerID",
      groupClaim: "<domain>/admin",
      operations: [ create, read, delete ]
    }
  ]) {
  id: ID!
  value: String!
  ownerID: ID! @index(name: "byOwner", queryField: "listContactInformationByOwner")
}

type Organization @model(subscriptions: null)
  @auth(rules: [
  { allow: public, provider: iam },
  { allow: private, provider: oidc } ## TEMPORARY(waiting on aws-amplify/amplify-category-api#103)
  ]) {
  id: ID!
  name: String
  memberships: [Membership] @hasMany(indexName: "byGroup", fields: ["id"])
  contactInformation: [ContactInformation] @hasMany(indexName: "byOwner", fields: ["id"])
}

type User @model(subscriptions: null)
  @auth(rules: [
    { allow: public, provider: iam },
    {
      allow: owner,
      provider: oidc,
      ownerField: "id",
      identityClaim: "sub",
      operations: [ read, update ]
    }
  ]) {
  id: ID!
  contactInformation: [ContactInformation] @hasMany(indexName: "byOwner", fields: ["id"])
}

Log output

# Put your logs below this line

Additional information
Looking into OrganizationcontactInformationauth0Function VTL Resolver, I have noticed two things that might be wrong:

At line 28, the source ID value is changed to my sub which might be causing the problem where the ContactInformation returned are the ones I own (where ownerID=my sub)
My group claims are list of strings but it looks like they are not treated as such. For exemple, at line 33, we compare a string with a list of strings.

@josefaidt  Any updates on this? 👀


Feature Request: Group menu items in sections instead of folders

Love the dashboard!
One thing that I would love to see for myself is the ability to display the menu option as a group instead of a folder.
It will save +1 click to reach the needed service and time to wonder where the service is for non-admin users.
It could be a switch either on system level or user level
Something like this:

+1, really like the example image as well
Only thing to add, if implemented this should not be an "either, or" feature. Rather, please keep the option to create folders as I can see it being useful from an organization standpoint to have both sections and folder/menu trees within items

I like the idea too. I would keep the menu system as it is, but add a new section system. The config might look something like this:
tiles:
  - title: Media
    section: true  # <- this controls the display as section
    allow: [group:media]
    tiles:
      - title: Plex
        logo: plex
        url: ...
      - title: JellyFin
        logo: jellyfin
        url: ...
  - title: Home
    section: true  # <- this controls the display as section
    ...

I think it should be a toggle in user setting:

but i like the idea with section: you can group folders in sections with that approach
Maybe instead of section: true it should be display: section with menu as the default option? That way it could be extended later

As #233 was merged, we can close this one
thanks, @knrdl !

Is this available in :edge? Can't seem to get my dashboard to display with sections (referenced here for the config format https://github.com/knrdl/hubleys-dashboard/pull/233)

Probably due to #224. As my PR was changed and at the moment it requires you to add allow: true to the tiles.

I have not made up my mind yet about the allow: true thing. @dbondarchuk suggested in #224 and #240 removing it and always show tiles when no allow rule is specified. This would make the config easier but may expose tiles by accident (when overlooking the missing allow rule). The current behavior is to always hide root tiles and sections without allow  and show a warning about it on server start. This has the better safety but maybe is harder to debug.
@K-J-VV what is your opinion as a user of the software and its config?

@knrdl I agree that ROOT tiles and sections should always have explicit allow, but for tiles under the section, allow: true should be implicit, because as a user, I can give access to all my applications under the section to a specific scope of users.

@knrdl I think @dbondarchuk wanting to simplify the config makes sense. Having to create an "allow: rule" for each item is tedious & makes a cluttered file
By default, enforcing an "allow: rule" on ROOT all sections makes sense. I agree not requiring an allow rule can inadvertently lead to security issues (it is also not too difficult to set in the config). All subtree items within a section should fall beneath the ROOT's allow rule.  Then users can select/specify Items within the sub-tree further if needed
In the example below, I want the entire Section accessible by group1. However, I want a specific item (Sverdle) to only be accessible by user1 of group1
sections:
  - allow: [ group:group1 ]
    tiles:
      - title: Home
        url: https://home.example.com
        logo: Home-Icon
      - title: Logout
        url: https://auth.example.com/logout
        logo: Logout-Icon
        menu:
          - title: Profile
            logo: Profile-Icon
            url: https://auth.example.com/profile
          - title: Sverdle
            allow: [ user:1 ]
            url: /sverdle
            logo: Sverdle-Icon

fixed by https://github.com/knrdl/hubleys-dashboard/commit/362651a22560b1541946b35f70ea7cd11b9d108c


fixes jQuery conflict issue

This pull request fixes the following issues:
https://github.com/divio/django-filer/issues/736

should be ok :+1:


screen dims at high volume

i'm 97% sure this was because I was using the pico lipo off of the battery, i doubt this will continue with the actual pico. can't test atm though, something else is going on

This is definitely helped using the regular pico it's minimum input voltage is 1.8v while the pico lipos is 3v.


preprod: remove references

Part of https://github.com/sourcegraph/deploy-sourcegraph-cloud/issues/17723

Missed some references due to the dash in pre-prod.

Current dependencies on/for this PR:

main

PR #6430   👈

This comment was auto-generated by Graphite.


Save spans concurrently

The main code path shouldn't block while a span is being stored.

Implemented in fe69ec1.


Library: Track rejected transactions {R7.11}

The problem: a user submits a transaction which is finally rejected on the contract, it disappears silently from UI

We need to make changes in relayer and lib that will help UI show rejected transactions

[ ] Add multi-transfer case

Need to check PR

The current staging console with history tracking  support has been deployed
History now supports multisender transfers and failure tracking. History example (use history command in the console):

QA review console - OK

Need changes to UX/UI


Fix FunctionStartAnalyzer's control flow

The continue keyword has no effect, when it should be breaking out of both loops to the outer one. I apologize if this isn't a good label name, but at least the function now works as intended.

Done! @emteere @ryanmkurtz

Fixed the issue! @ryanmkurtz


[Feature Request] hint consumers that some events can be handled by the project workflow

some events (e.g. reopened) can be handled by the project workflow.
are such triggers redundant in the action example?

You can define both, but I would personally recommend disabling either the workflows defined by GitHub or the workflows defined in your repository workflow.

utilizing both is truly confusing. Ideally there would be an observe repos feature (to hook newly opened PRs/issues). paired with "create and edit own workflow" settings, it would be possible to rely on the project beta settings alone.
when maintaining multiple repos, the project syncs should be repeated for each.
For now I use actions on repos to add new PRs/issues to the project and from there on out it's the project's workflows handling events


Log command before downloading file: fails to output file name if it cannot be successfully formatted

line
self.log.debug("Downloading '{name}' attachment".format(name=attachment['title']))
had output:
File "copier.py", line 320, in _copy_attachments
self.log.debug("Downloading '{name}' attachment".format(name=attachment['title']))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 49-51: ordinal not in range(128)
when:
filename contained BOM at the end of filename, that is EF BB BF (in hex), so "format" command was not able to format, and failed without telling what was that bad attachment/filename
for myself, I changed it to the following code and it worked
#self.log.debug("Downloading '{name}' attachment".format(name=attachment['title']))
self.log.debug("Downloading attachment:".format(name=attachment['title']))
self.log.debug(attachment['title'])

file2.txt

Fixed, can you verify, please?

confirm, now filename is printed
INFO:confl-copier:Copying 1 attachment(s)
DEBUG:confl-copier:Downloading 'somefilename─Å┼Ñ┼╝.png' attachment
DEBUG:confl-copier:Creating new attachment 'somefilename─Å┼Ñ┼╝.png'
DEBUG:confl-copier:Removing temp directory 'c:\users\roman\appdata\local\temp\tmp2czejz'
Traceback (most recent call last):
File "copier.py", line 471, in
recursion_limit=args.recursion_limit
File "copier.py", line 117, in copy
self._copy_attachments(source, page_copy_id)
File "copier.py", line 347, in _copy_attachments
shutil.rmtree(temp_dir)
File "c:\python27\lib\shutil.py", line 252, in rmtree
onerror(os.remove, fullname, sys.exc_info())
File "c:\python27\lib\shutil.py", line 250, in rmtree
os.remove(fullname)
WindowsError: [Error 2] The system cannot find the file specified: 'c:\users\roman\appdata\local\temp\tmp2czejz\somefilenamedtz.png'


platyPS Minimum Supported PowerShell Version

What is platyPS minimum supported PowerShell version? I ask because playtPS.psd1 does not specify a version.
There are a few lines with the -in and -notin operators which were added in PSv3. There might be other examples of PSv3+ only features that I didn't find.
https://github.com/PowerShell/platyPS/blob/f721e2c1ef480cb46be2ce93ebbe6cca48412a10/src/platyPS/platyPS.psm1#L1439
https://github.com/PowerShell/platyPS/blob/f721e2c1ef480cb46be2ce93ebbe6cca48412a10/src/platyPS/platyPS.psm1#L1740
https://github.com/PowerShell/platyPS/blob/f721e2c1ef480cb46be2ce93ebbe6cca48412a10/src/platyPS/platyPS.psm1#L1122
https://github.com/PowerShell/platyPS/blob/f721e2c1ef480cb46be2ce93ebbe6cca48412a10/src/platyPS/platyPS.psm1#L1123

v3, ps v2 is retired afaik

There are some compatibility issues with the help created for PSv3. Best results for PSv4+.
But if the question is about what version it can run on, then v3+ should work (currently).

There are some compatibility issues with the help created for PSv3. Best results for PSv4+.
But if the question is about what version it can run on, then v3+ should work (currently).


doc: release notes recommend wrong version of NaCl

On NaCl, Go 1.5 requires SDK version pepper-39 or above because it now uses the get_random_bytes system call.

I believe this is incorrect. Go does not use the new get_random_bytes syscall, see #11961. As best I can tell NaCl requires pepper < 43
/cc @adg @rsc

I actually don't know. Happy to amend the docs.

OK, I'll send a PR. The range of usable pepper versions is quite narrow.
On Fri, 7 Aug 2015 09:09 Andrew Gerrand<EMAIL_ADDRESS>wrote:

I actually don't know. Happy to amend the docs.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/12062#issuecomment-128536174.

Yet more evidence that compiling to static binaries is awesome.


make -C Documentation update-cmdref is broken with git worktrees

$ make -C Documentation/ update-cmdref
  DOCKER Documentation builder-image cilium/docs-builder
Unable to find image 'quay.io/cilium/cilium-builder:c8badc075421b6282610e5fbfe565d24fc54a9d9@sha256:c671a8399e7a78bf56e8281997dff390398e44c9cb6cd40ee9ef34e59358e22c' locally
3.11-alpine3.17: Pulling from library/python
Digest: sha256:607af960065410fcfabfb7402ef4b7e8bf8e79691c63a99a2c14e7c07efa1774
Status: Image is up to date for python:3.11-alpine3.17
docker.io/library/python:3.11-alpine3.17
[+] Building 5.0s (6/8)                                                                          docker:default
 => [internal] load remote build context                                                                   0.0s
[+] Building 5.9s (6/8)                                                                          docker:default
 => [internal] load remote build context                                                                   0.0s
 => copy /context /                                                                                0.1s
 => [internal] load metadata for docker.io/library/python:3.11-alpine3.17                                  0.0s
 => [docs-base 1/2] FROM docker.io/library/python:3.11-alpine3.17                                          0.0s
 => CACHED [docs-base 2/2] RUN apk add --no-cache --virtual --update     aspell-en     nodejs     npm      0.0s
 => [docs-builder 1/3] ADD ./requirements.txt /tmp/requirements.txt                                        0.0s
 => [docs-builder 2/3] RUN pip install -r /tmp/requirements.txt                                            5.7s
 => => # Collecting sphinxcontrib-spelling==8.0.0 (from -r /tmp/requirements.txt (line 15))
 => => #   Obtaining dependency information for sphinxcontrib-spelling==8.0.0 from https://files.pythonhosted.o
 => => # rg/packages/87/f9/ec57149c1ab20efed1305aa89fbcd7a9e4a8edf9ef5fe9b75bdb13e1964e/sphinxcontrib_spelling-
 => => # 8.0.0-py3-none-any.whl.metadata
 => => #   Downloading sphinxcontrib_spelling-8.0.0-py3-none-any.whl.metadata (2.9 kB)                         f[+] Building 43.0s (6/8)                                                                         docker:default
 => [internal] load remote build context                                                                   0.0s
 => copy /context /                                                                                0.1s
[+] Building 43.7s (6/8)                                                                         docker:default
 => [internal] load remote build context                                                                   0.0s
 => copy /context /                                                                                0.1s
[+] Building 43.8s (6/8)                                                                         docker:default
 => [internal] load remote build context                                                                   0.0s
 => copy /context /                                                                                0.1s
 => [internal] load metadata for docker.io/library/python:3.11-alpine3.17                                  0.0s
 => [docs-base 1/2] FROM docker.io/library/python:3.11-alpine3.17                                          0.0s
 => CACHED [docs-base 2/2] RUN apk add --no-cache --virtual --update     aspell-en     nodejs     npm      0.0s
 => [docs-builder 1/3] ADD ./requirements.txt /tmp/requirements.txt                                        0.0s
 => [docs-builder 2/3] RUN pip install -r /tmp/requirements.txt                                           43.6s
 => => #    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 133.3/133.3 kB 16.4 MB/s eta 0:00:00
 => => # Downloading jsonschema-4.19.0-py3-none-any.whl (83 kB)                                                9[+] Building 44.0s (6/8)                                                                         docker:default
[+] Building 64.5s (9/9) FINISHED                                                                docker:default
 => [internal] load remote build context                                                                   0.0s
 => copy /context /                                                                                0.1s
 => [internal] load metadata for docker.io/library/python:3.11-alpine3.17                                  0.0s
 => [docs-base 1/2] FROM docker.io/library/python:3.11-alpine3.17                                          0.0s
 => CACHED [docs-base 2/2] RUN apk add --no-cache --virtual --update     aspell-en     nodejs     npm      0.0s
 => [docs-builder 1/3] ADD ./requirements.txt /tmp/requirements.txt                                        0.0s
 => [docs-builder 2/3] RUN pip install -r /tmp/requirements.txt                                           62.0s
 => [docs-builder 3/3] RUN install -m 0777 -d /usr/local/lib/python3.11/site-packages/versionwarning/_sta  0.6s
 => exporting to image                                                                                1.7s
 => => exporting layers                                                                                1.6s
 => => writing image sha256:16910ae6077df8ee1ddf3d2b5edc3ccb897e3d9f0e0ddd3ac72e7e2adb2acec6               0.0s
 => => naming to docker.io/cilium/docs-builder                                                             0.0s

 1 warning found (use --debug to expand):
 - UndefinedVar: Usage of undefined variable '$READTHEDOCS_VERSION' (line 28)
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
fatal: not a git repository: /home/joenats/git/cilium/.git/worktrees/cilium
...

Had a quick look over, I suspect it's related to how Git initializes .git. In a git worktree the .git is a file with the above path,
# ls -lsta .git
4 -rw-r----- 1 1287689 89939 94 Jul 30 09:40 .git
# cat .git
gitdir: /usr/local/[...]/cilium/.git/worktrees/op-id-cid-cell-controller

While usually .git is expected to be a folder,
cilium$ ls -lsta | grep .git
  4 drwxr-x---   9 otirla primarygroup  4096 Jul 30 09:46 .git

But because when working with worktree the folder is not seen as a git repo, all the git-related commands will fail.
looking at the make -d on the builder container,
# make -d | head -n 30
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Reading makefile 'Makefile'...
Reading makefile 'Makefile.defs' (search path) (no ~ expansion)...

Reading makefile 'Makefile.kind' (search path) (no ~ expansion)...
Reading makefile 'Makefile.docker' (search path) (don't care) (no ~ expansion)...
bash: line 1: docker: command not found
fatal: not a git repository: /usr/local/[...]/cilium/.git/worktrees/op-id-cid-cell-controller
fatal: not a git repository: /usr/local/[...]/cilium/.git/worktrees/op-id-cid-cell-controller
[...]
Updating makefiles....

Apart from this error being throws I could see the go build being ran for each subdir. But also I see that Makefile.defs is imported in each subdir Makefile and it has some git-related commands, suspecting that something might be off in the Makefile.defs.

If .git exists in the same directory as your Makefile, but it's a file and not a folder, the ifneq condition will evaluate to true. The reason is that wildcard function simply checks for the existence of the specified file or directory, it doesn't distinguish between files and folders.
If we correctly update that if statement we'll still run into some issues because GIT_VERSION file is missing from the source code.
For the if statement issue, we can easily update the path we check from only .git to .git/HEAD as that file is expected to be there.

@ovidiutirla thanks for your insights on this.. for some reason I'm often too slow to use make -d to debug issues like this more quickly. I took some inspiration from your comments and dug a little deeper, to the point where it seems like I'm able to successfully run the full update-cmdref build in a directory with a git worktree checked out.


[SMALLFIX]  [branch-1.6] Remove S3N references

@aaudiber @calvinjia Please take a look. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16679/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16698/
Test PASSed.