Enable pylint for our tests

Description:
This PR enables pylint for our tests directory. A good portion of our tests currently don't pass pylint, so for now they've been blacklisted so we can turn on pylint for the rest of them.
The failing tests were modified with the following bash script:
sed -i '0,/"""$/s//"""\n# pylint: skip-file/' $(pylint --msg-template='{path}' tests 2>/dev/null | grep '^tests' | uniq)

Notes
We should also be braced for incoming PRs introducing lint failures unless they're rebased/merged on dev.

Please see this comment: https://github.com/home-assistant/home-assistant/pull/13093#discussion_r173664662. There are quite a few ignores that should be set up first in order to not break the tests process. I would say we should first try fixing at least a few files to see how well the linting works.
Also, we need to think about speed. Right now, we skip most test files. But if we get more test files "pylinted" and remove the skips, the pylint travis job will be incredibly slow (about 2x)

The scope of this PR is only to turn on pylint, especially for new tests coming in. Existing tests that aren't passing need to be dealt with separately in their own PRs.

Sure, but what if somebody creates a PR with tests after this PR gets merged? They will get tons of pylint errors in their tests that often don't make any sense (like invalid-name, ... see comment from before) and will most likely disable pylint for the file.
What I'm saying is that we should first try to go through at least a few test files and try to fix the pylint issues in there. If there are global disables that need to be created in the process (and there most certainly will), they should be put in before we enable pylint on all tests/ files. I'm not saying the fixes for specific files should be in this PR, we should simply do a case study of a few tests and find out what disables are required.

I agree with @OttoWinter. Before we start adding # pylint: skip-file to all error files, we should build the foundation first and stay away from .tox for the moment. It might help to create a seperate pylintrc for test runs.

I don't disagree with any of that, but none of these ideas block turning on pylint for new PRs. This PR will never get merged if we want to bikeshed all the possible ways to handle the existing failures.

That is not the point (at least I'm trying to make here). There are many pylint errors in our current test suite that aren't really errors for tests. Otto mentioned quiet a few here: https://github.com/home-assistant/home-assistant/pull/13093#discussion_r173664662
If those are caught probably we don't have to mark so many with skip-file.

if we want to bikeshed all the possible ways to handle the existing failures.

I'm not saying all failures, just a case-study of a few (3-5) files. We would learn important stuff about what checks do and don't work (in that they produce lint errors that aren't really valid for tests, see comment) for the tests/ folder. I've already gone through some files (in the comment i linked to before) and it wasn't too much work.

I don't disagree with any of that, but none of these ideas block turning on pylint for new PRs.

I disagree with the last part of that statement there. As I said, this would just make new PRs a pain for newbies. Especially since we can go through some files without much work, I don't think we should make the PR process for others more work.
I'm copying the list of checks that are too verbose for tests/ I found earlier here:

invalid-name (too long test function names)
attribute-defined-outside-init
protected-access (obviously)
len-as-condition (we shouldn't rely on truthy values)
redefined-outer-name (fixtures)
no-member (calling methods on MagicMocks)
no-value-for-parameter (fixtures, again)
probably lots more

I'm good if you want to push up some new commits to this branch to turn off those lint checks on tests.

I will take a look at that tomorrow. Need to catch some sleep (and learn) now, I have an exam coming up tomorrow 😅
Btw, looking back at my comments, they might be interpreted as being a bit "grumpy". That's not the case though, I'm just getting a bit tired 🛏💤

Hah, I know I've been terse as well. Let's review tomorrow once everyone's had some sleep. :smile:

If we blacklist the ones that @OttoWinter listed, it might be ok. Because for example, I wouldn't want to change the test names or disable no-member for all the magic mocks etc.

Closing for the more comprehensive https://github.com/home-assistant/home-assistant/pull/13125 🙇


update swap & vested delegate

Remove duplicate error
Fix maturing view functions
Modify function  "isPosisitonAvaiableToSwap" to be reusable
Added and modified tests for the new logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

15 of 15 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 88.21%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.03%

Covered Lines:
1168

Relevant Lines:
1251

💛  - Coveralls


Fix bug in primary choices

Before we weren't able to use timezones that included spaces, i.e,
‘America/Los Angeles’  would not work even if we wrote  ‘America/Los_Angeles’.

Thanks for the contribution. Could you change it to use the lodash forEach method instead of the native for loop?
https://lodash.com/docs#forEach

Yes. I will make the changes and rebase it.

@ashokfernandez Updated.

Thanks, released as https://github.com/mishguruorg/angular-timezone-selector/releases/tag/v1.4.0
and attribution added to the README


Scribble_kerning_pair_set effecting the space after the kerning pair not the space between them in 8.7.1

Basically what the description says.
If you do something like this to increase the spacing between the "I" and "G" :
scribble_kerning_pair_set(fontName, I, G, 10,true)
and then draw the word "SIGN"
You get: SIG  N
Instead of: SI GN
Whether your doing "relative" or not doesn't have an effect. In both cases it's the character after the kerning pair that's affected.
Scribble 8.7.1 in GM LTS 2022

Odd ... haven't run into this one and I've used the kerning feature quite a lot. I will take a look.

Just tested this with a few different fonts and saw the issue in all of them. Here's an image showing it in action.

This was the code: scribble_kerning_pair_set("fnt_arial", "E", "S", -1 ,true);
Instead of the E and S touching, the S and T are.

Silly off-by one https://github.com/JujuAdams/Scribble/commit/3cd7bc0e33b38c7ae8dfb08da7e3056a9c363e66
Don't know how this crept in consider it worked fine in previous versions but oh well.

Fix available in 8.8.0: https://github.com/JujuAdams/Scribble/releases/tag/8.8.0


export feature type "protein"

For all mRNA features

@rachllyne

Sorry, I don't understand.  Which file does this go in?

The JSON file we export has a protein section for each coding gene.  Is more needed?
The protein sections look like:
 "protein": {
   "uniquename": "SPAC1002.01.1:pep",
   "sequence": "MLPPTIRISGLAKTLHIPSRSPLQALKGSFILLNKRKFHYSPFILQEKVQSSNHTIRSDTKLWKRLLK...*",
   "product": "mitochondrial expression network (MIOREX) component Mrx11",
   "molecular_weight": 20.2386,
   "average_residue_weight": 0.11243,
   "charge_at_ph7": 14.9,
   "isoelectric_point": 10.77,
   "codon_adaptation_index": 0.57
 }

Hi @rachellyne, I think what probably needs to happen is that some connection is made between the gene and the protein ID so that we can access protein features from gene?


Development status?

Seems like everyone contributing and using this project dropped off of it back in 2021, @RichieSams what is the status of the project since so far to me it looks like the best option for an "off the shelf" implementation of a fiber based jobs system for a game that i've been able to find so far.

Hi @mdsitton. Thanks for reaching out.
We're all still here, however, as you correctly identified, active development of FiberTaskingLib has dropped off. That said, FTL is "basically" done. All the PRs and Issues are either features we thought might be a big benefit and ended up being a wash. Or just some additional "nice to have" features (like parallel for).
So FTL can absolutely be used as-is. (And we'll be here to help if you find any bugs). That said, while a fiber-based job system is awesome, just remember that there are significant drawbacks still in today's ecosystem:

Debuggers have no first class support for fibers. So the callstacks look a bit weird. But more importantly, you can't easily see the callstacks of "waiting" fibers. There might be a way to "register" them with the debugger. But I haven't done much looking.
As mentioned in the README and Christian Gyrling's talk, you can't use Thread Local Storage. FTL has a fiber-based TLS implementation you can use instead. But this can get annoying, especially when third party libraries use TLS.

Hey @mdsitton, thought I'd weigh in as well as I work with FTL regularly (almost daily). The issues @RichieSams pointed out are not fun, particularly #1, but honestly for me the worst part is lack of proper profiler support. Name any flamegraph style profiler that you like, and I would be willing to bet a small sum that they don't/won't support Fibers - they get confused when you jump around the callstacks while inside one of their begin/end profiler macros, for example.
This profiler ended up adding some hooks for profiling Fibers, https://github.com/dfeneyrou/palanteer, but you can see that the GUI isn't the best for such things: https://github.com/dfeneyrou/palanteer/issues/39.
I don't meant to dissuade you if you're experimenting or wanting to learn. That + the amazing Naughty Dog talk were why I started using FTL and have been using it for YEARS. But the lack of profiler support is a serious, existential technical threat to my work so I'm evaluating pivoting to a more traditional task library like TBB.

Hi @mdsitton. Thanks for reaching out.
We're all still here, however, as you correctly identified, active development of FiberTaskingLib has dropped off. That said, FTL is "basically" done. All the PRs and Issues are either features we thought might be a big benefit and ended up being a wash. Or just some additional "nice to have" features (like parallel for).
So FTL can absolutely be used as-is. (And we'll be here to help if you find any bugs). That said, while a fiber-based job system is awesome, just remember that there are significant drawbacks still in today's ecosystem:

Debuggers have no first class support for fibers. So the callstacks look a bit weird. But more importantly, you can't easily see the callstacks of "waiting" fibers. There might be a way to "register" them with the debugger. But I haven't done much looking.
As mentioned in the README and Christian Gyrling's talk, you can't use Thread Local Storage. FTL has a fiber-based TLS implementation you can use instead. But this can get annoying, especially when third party libraries use TLS.

Thanks for getting back to me! Infact I think I already have found a few issues that may need some updates to the underlying boost context assembly code to fix so I probably will make a pull request for that  infact 😅
I mean I don't really mind the downsides too much, plus I'm not too afraid of customizing certain dependencies if required from time to time. If I can get things merged upstream or bugs fixed here for issues that pop up then I'll be fine. Also what is the status of the currently open pull requests.
Some random musings, I wonder if a job library that can have fibers enabled and disabled through a compilation flag could be useful. Because technically fibers as I understand it mainly just get you an advantage to fix some execution order issues that a typical task based system provides to better increase system throughput. This could allow better debugging for some cases with the downside of having less ideal execution order.

what is the status of the currently open pull requests.

https://github.com/RichieSams/FiberTaskingLib/pull/139 - Probably just needs to run CI again and then merge. Though, better would be to upgrade nonius itself (instead of changing this fork)
https://github.com/RichieSams/FiberTaskingLib/pull/111 - Not sure if it's still relevant. It was made before the AtomicCounter rework. I'd need to do some diffing and chat with @martty
https://github.com/RichieSams/FiberTaskingLib/pull/69 - We'd need to rebase and re-evaluate based on the current feedback.
https://github.com/RichieSams/FiberTaskingLib/issues/134 - I almost got it working at the end, but ran out of steam. (And there's not a huge need for it. So 🤷♂ . PR's welcome! lol
https://github.com/RichieSams/FiberTaskingLib/issues/107 - Possibly still an issue? I'd have to think about it again. That said, not many code bases will change the sleep behavior mid-game.
All the other issues are just feature adds / requests.

Some random musings, I wonder if a job library that can have fibers enabled and disabled through a compilation flag could be useful. Because technically fibers as I understand it mainly just get you an advantage to fix some execution order issues that a typical task based system can run into, to better increase system throughput. This could allow better debugging for some cases with the downside of having less ideal execution order.

While plausible, IMO, it would be impractical. A fiber-based task system fundamentally changes how tasks are created, dependencies are defined, and how synchronization happens. Attempting to abstract that all away would be very difficult IMO

Made a separate issue for the boost context items: #141

Some random musings, I wonder if a job library that can have fibers enabled and disabled through a compilation flag could be useful. Because technically fibers as I understand it mainly just get you an advantage to fix some execution order issues that a typical task based system can run into, to better increase system throughput. This could allow better debugging for some cases with the downside of having less ideal execution order.

While plausible, IMO, it would be impractical. A fiber-based task system fundamentally changes how tasks are created, dependencies are defined, and how synchronization happens. Attempting to abstract that all away would be very difficult IMO

Yeah i guess that's fair, i do still think it could be interesting though :)

#139 - Probably just needs to run CI again and then merge. Though, better would be to upgrade nonius itself (instead of changing this fork)

About updating nonius i don't think there is anything to update that project seems fairly abandoned to me:
https://github.com/libnonius/nonius/commits/devel
I mean you may get a few fixes but it doesn't look like there has been much development even since C++20 and the core issue in #139 ofc isn't resolved either: https://github.com/libnonius/nonius/blob/abdd1c4671e221daeed2c1b6ac557617f7b7a563/include/nonius/detail/complete_invoke.h%2B%2B#L46
Maybe another library could be used, here is a few i found with a quick look:
https://github.com/martinus/nanobench
https://github.com/DigitalInBlue/Celero
https://github.com/google/benchmark

Actually further digging into things you already have catch2 integrated into the repo, and a few versions before what is currently in the project they integrated the nonius codebase into catch2 for writing benchmarks:
https://github.com/catchorg/Catch2/releases/tag/v2.9.0
https://github.com/catchorg/Catch2/blob/devel/docs/benchmarks.md
So it could be possible to maybe make use of this and delete it all together though catch2 will need to be updated as well due to the same issue in the benchmarking code:
https://github.com/RichieSams/FiberTaskingLib/blob/master/third_party/catch2/include/catch2/catch.hpp#L6510

Heh, I was just about to say that same. I recently updated catch2 to v3 at work, and I saw they added benchmarking support. So that's a probably avenue


Safe insert

In the case of insert_from the insert query might not return rows - one might insert empty table into another one.
Thus, such a workaround is needed to avoid TypeError

Fixed in latest version


Readme table not up to date

It states that the free tier comes with 1gb ram but in oracle free tier it says we can get up to 4cpu and 24gb ram linux machines
but they use ARM, is that a problem?
https://www.oracle.com/il-en/cloud/free/

Hey!
Yeah sadly I've let this get out of date a bit. Been wanting to make an updated version, but been busy.
But yeah Oracle free tier is great. They now give users even more free resources like you noted.
ARM isn't a problem at all and I would totally recommend taking advantage of it. Before it was really the RAM holding back the free tier, but now that free tier cpu/ram offering is great.
Cheers!
Michael

Cheers!
Thanks Michael!


Installation fails using `pip install ml_insights' on mac and Ubuntu

ML Inspector version: the latest available version
Python version: 2.7.6/2.7.9
Operating System: Ubuntu/Mac

Description
Was trying to install the binaries
What I Did
cmd: pip install ml_insights
Output:
Collecting ml_insights
  Downloading ml_insights-0.0.7.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/tmp/pip-build-8Q_qzy/ml-insights/setup.py", line 9, in <module>
        with open('HISTORY.rst') as history_file:
    IOError: [Errno 2] No such file or directory: 'HISTORY.rst'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/tmp/pip-build-8Q_qzy/ml-insights/

workaround: pip install -e git+https://github.com/numeristical/introspective.git#egg=ml-insights

@pramitchoudhary Thanks for posting the bug!  This should be fixed now.  Please upgrade to the latest version (0.0.9) with pip install -U ml_insights


number of memory tables keep growing during tpcc run

This issue relates to recover.
before restart, the memtable number is normal, after restart, the number of memtable keeps growing.


Reports are not visible for timeline updates

When a Report is being added to a timeline update then this report is not showing as a counter in the dashboard's admin manage block.

Update serviceGetMenuAddonManageTools service, that it returns all 3 counters.


Large address aware

X86 version needs to be large address aware.

What does "large address aware" mean in this context? (Just asking out of curiosity. :slightly_smiling_face:)

To access more than 2gb of memory the x86 version needs to have the   /LARGEADDRESSAWARE linker option specified.
https://docs.microsoft.com/en-us/cpp/build/reference/largeaddressaware-handle-large-addresses?view=vs-2019
Also reminds me we should set tsaware for both x86 and x64
https://docs.microsoft.com/en-us/cpp/build/reference/tsaware-create-terminal-server-aware-application?view=vs-2019


zfxtop: 0.3.0 -> 0.3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ssleert/zfxtop/releases.
meta.description for zfxtop is: fetch top for gen Z with X written by bubbletea enjoyer
meta.homepage for zfxtop is: https://github.com/ssleert/zfxtop
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.2 with grep in /nix/store/f8z7qf14qi952nybz6fc3h82v5wk75h7-zfxtop-0.3.2
found 0.3.2 in filename of file in /nix/store/f8z7qf14qi952nybz6fc3h82v5wk75h7-zfxtop-0.3.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
zfxtop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f8z7qf14qi952nybz6fc3h82v5wk75h7-zfxtop-0.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A zfxtop https://github.com/r-ryantm/nixpkgs/archive/2f90dc20b9e2e15ec5fe5aca9e904774f7c88cc0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f8z7qf14qi952nybz6fc3h82v5wk75h7-zfxtop-0.3.2
ls -la /nix/store/f8z7qf14qi952nybz6fc3h82v5wk75h7-zfxtop-0.3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

zfxtop

Maintainer pings
cc @wozeparrot for testing.

Result of nixpkgs-review pr 224748 run on x86_64-linux 1

1 package built:

zfxtop


Fixed Username alignment issue

Issue Link

#53

Description

Removed styles to fix alignment

Fix in smaller screen
make username in center

Nice @aishwarya-mali :+1:


Hindi, Spanish, German Language Localization updated.

Thanks, @dalwadi2 . I merged your request.
But i thing there are some errors Spanish and German translation  in contextual meaning.
I agree some words gives double meaning.
For example:

"Close" in Spanish as verb is "Cerrar" but you have translated it as adverb as "cerca"
Some others

Not more but there are some misunderstandings like this. I can correct them myself.
But again thanks a lot for your help.

your welcome @hummatli :+1:
if there are some work other than localization support, then let me help you.I'm glad that I'll help to create/contribute such a helpful library.

That is good to see @dalwadi2.
I will absolutely create new issues about new features and mention you.
Thanks for your help.
Regards, Sattar Hummatli.


updated ink! to 3.3.0

Thanks!
Can you update the pr-checks.yml CI to node 18.x so the checks pass?


Please give an example to connect to websocket url in async way

For example like connect_async in tokio-tungstenite. How to use async connect ?
If some basic knowledge is required to construct such functionality , please guide to appropriate documentation.

Added https://github.com/denoland/fastwebsockets/blob/main/examples/tls_client.rs

why does it require such horrendous code to connect to a socket?


Added support for access token

HomeAssistant now uses the Long-Lived Access Tokens, I believe this will solve that.
I have left the apiPass in as some people might still be on old versions.

Does this close #32?

once I get a chance to test it, I believe so
On Fri, Sep 28, 2018 at 12:59 PM Jordan Janzen<EMAIL_ADDRESS>wrote:

Does this close #32
https://github.com/Spartan-II-117/node-red-contrib-home-assistant/issues/32
?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Spartan-II-117/node-red-contrib-home-assistant/pull/37#issuecomment-425549429,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuJQC80LqiDJjYOMAyPKk9NFQhnwNeRks5ufn-7gaJpZM4W7YEL
.

@cliffordwhansen  I seem to be missing something as this is not working in my setup. I have forked the node-home-assistant repo and published it to NPM under the name node-home-assistant-llat but still seem to be having trouble getting it to work. any chance you can point me in the right direction?
also tagging @declankenny

@Spartan-II-117 I do admit I didn't test this as well as I should have, there were some extra changed in the ha_event class (node-home-assistant) that I didn't see. I have pushed the new changed to both repositories


Django 1.6 unsupported

Since April 1st, extended support for Django 1.6 has ended.
With that, it might be a good idea to start looking to migrate to Django 1.8, the next LTS release, supported until at least April 2018.
I'll personally see if I can have a go at this soonish to also learn more about Django and Python in general :smiley: but don't expect much as my knowledge and time is limited :grin:
Links to deprecated functions:
Django Deprecation Timeline
Django 1.7
Django 1.8

I will be targeting 1.8 for the next release.


Update Composer dependencies (2021-04-29-00-07)

Visual regression test passed!
View the visual regression test report


before setValue(), should(enabled) is necessary?

before setValue(), should(enabled) or should(visible) is necessary?

@anyone-can-test nope, for any manipulation executed pre check for visibility of an element


npm run serve misbehaving

It seems that netlify-cli serve is misbehaving. For example, page refresh, after a change doesn't always show the resulting change.
As a workaround, view the site served at http://localhost:1313/, which is the site as served by Hugo rather than Netlify dev.

is this fixed with #2217?

I don't know if this is fixed yet. I haven't had a chance to test it sufficiently.

Sadly, even after a reboot, this is still misbehaving for me. I'm force to work with localhost:1313, which is hugo's port rather than :8888 use by Netlify-dev CLI.

Still applies?


[HOLD react-native #37397] [$1000] Different font sizes in inline and multi-line codeblock

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

open a chat
send messages: inline codeblock and multiline codeblock

expected results:
same font size in both
Actual results:
different font size in each
Platform: chrome web desktop
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.13
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/1e653e2c-991c-465c-a24b-cd06b014ff62
https://github.com/Expensify/App/assets/43996225/9a86336c-4cc0-4c0f-b193-7fcb6343b556
Expensify/Expensify Issue URL:
Issue reported by:@chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683823629262529
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01db882fab4bc53c2d
Upwork Job ID:<PHONE_NUMBER>173488640
Last Price Increase: 2023-05-31

I'm OOO - this was assigned after I signed off. Reassigning. Thank you!

Odd. I'm surprised this is the case, though to double check, @shawnborton is there a particular reason for this?
I'm triaging in any case to keep the issue moving while I'm at a conference.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Different font sizes in inline and multi-line codeblock
What is the root cause of that problem?
We're explicitly setting fontSize for inline code here https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/styles/styles.js#L123
What changes do you think we should make in order to solve the problem?
We should remove this fontSize line. So it will reuse the fontSize of base here
https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/styles/styles.js#L144
What alternative solutions did you explore? (Optional)
Instead of remove, we can set fontSize in line to
fontSize: variables.fontSizeNormal

So it will calculate fontSize normal in different device

I'm not sure if there was a good reason, maybe that it was hard to make the text wrap multiple lines and look good in line with normal text if the font size was 15 for inline code? Either way, I would love to see some proposals of how we could pull it off.

@parasharrajat Yes. I have tested both of IOS and Android. Here is my results

IOS

Before

After

Android

Before

After

@parasharrajat Sure

Before

After

@iwiznia what do you think? I'm cool to put it on hold.

Hmmmm no idea honestly. @parasharrajat can that PR solve this issue or you want to put it on hold till it is done because you can't test on android without it?

Apologies ya'll, coming back to this issue. I agree that it doesn't make sense to move forward if we can't test our changes on Android. Adding a hold minimally for the react PR.

Still on hold.

Same

Same, should we switch this to weekly @JmillsExpensify ?

Yeah good call.

Still on hold.

Going on sabbatical, please reassign another engineer if this goes off hold

Hold

Same

Related PR still on hold.

Still on hold

Still on hold

Still on hold

Linked issue still on hold

Still waiting on linked issue.

Same

Seems that the PR we are holding on will be closed in 7 days due to inactivity: https://github.com/facebook/react-native/pull/37397#issuecomment-1894945095

Ah thanks for the context, updated the title

Adding this to vip-vsb since the issue we're holding on is already part of that initiative.

Still holding

Still holding

Still holding

Still holding

Hmm I think I would rather just make all of the inline code and code blocks use 13px. Our mono font optically feels "bigger" than our regular font, so I think it's okay if we back it down to feel balanced with regular text. Is that possible? Can you also share screenshots of what is going on here - I am a bit out of the loop with the issue. cc @Expensify/design for visibility too.

Totally agree Shawn, I think that sounds like a good course of action here.

Our mono font optically feels "bigger" than our regular font

Especially agree with the point above

Did we go with Shawn's solution yet?

Payment summary:

Bug report: $250 @chiragxarora via Upwork
Reviewer: $250 @parasharrajat via NewDot.

Hello @JmillsExpensify
I could not find any active contract on upwork for this one. Could you please send it again?
Thankyou so much

No worries. @parasharrajat please make sure that we have a regression test in place before requesting payment. Thanks all!

Payment summary:
Bug report: $250 @chiragxarora via Upwork
Reviewer: $250 @parasharrajat via NewDot.

$250 approved for @parasharrajat

P.S. Created the issue for the regression test.


[BUG] Spanish language does not work

Office Tool Plus <IP_ADDRESS> (27/7/2021)
Windows 10
Error description (required):

Spanish language does not work, the other languages do work.

Reproduction steps (suggested):

Open Office Tools Plus, in Settings I try to choose Español (España) in Language Menu, but nothing happens.

Screenshot (suggested):

https://i.imgur.com/Nu7gDBb.png

Additional information (optional):

In the source code, from GitHub there is the file es-es.xaml, but it seems that the compilation does not take the file.

OK, I will fix it as fast as possible.

Fixed, please re-download Office Tool Plus. Thanks for your feedback!


Azure SDK Authentication Managed Identity with GO needs update

This documentation needs some update:
Reference: https://github.com/MicrosoftDocs/azure-dev-docs/blob/main/articles/go/azure-sdk-authentication-managed-identity.md
I was able to get this working with the following code:
package main

import (
        "context"
        "log"
        "github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
        "github.com/Azure/azure-sdk-for-go/sdk/azidentity"
        "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/keyvault/armkeyvault"
)

func SecretsClient_CreateOrUpdate() {
        cred, err := azidentity.NewDefaultAzureCredential(nil)
        if err != nil {
                log.Fatalf("failed to obtain a credential: %v", err)
        }
        client := armkeyvault.NewSecretsClient("<subscriptionid>", cred, nil)
        resp, err := client.CreateOrUpdate(
                context.Background(),
                "<ResourceGroup>",
                "<keyvaultname>",
                "<secret-name>",
                armkeyvault.SecretCreateOrUpdateParameters{
                        Properties: &armkeyvault.SecretProperties{
                                Attributes: &armkeyvault.SecretAttributes{
                                        Attributes: armkeyvault.Attributes{
                                                Enabled: to.BoolPtr(true),
                                        },
                                },
                                Value: to.StringPtr("valuehere"),
                        }}, nil)
        if err != nil {
                log.Fatalf("failed to create the key: %v", err)
        }
        log.Printf("Secret ID: %v\n", *resp.Secret.ID)
}

func main(){
 SecretsClient_CreateOrUpdate()
}

And using these commands:
go get github.com/Azure/azure-sdk-for-go/sdk/azcore/to
go get github.com/Azure/azure-sdk-for-go/sdk/azidentity
go get github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/keyvault/armkeyvault
go build
go run main.go

Hey @edisga,
I'm working on getting the code sample updated, thank you for submitting the issue and submitting a working example. :)

#please-close


Rescue on JSON Parse error

Added error handling on invalid or empty JSON payload for the Coinbase Notification Integration.
Tested params and acknowledge, as both will use parse (params will be parsed through the constructor though).
Please review @andrewpaliga @masaruhoshi

Any news on this? @andrewpaliga @masaruhoshi

I wonder what kind of exceptions the gateways are raising. Other than that :tanabata_tree:

:+1:

:bow: Thank you


Crash

Player in StoneBlock 3 had the issue below.
Log Files
https://pste.ch/qezaloceju.pl
Describe the bug
Just tried to repeat it and this time there was no crash, but I figure I should still report it just incase.
Steps to reproduce
Removed Living armour chest from equipment, moved to inventory, and picked up from inventory with the cursor. The only change since the last time I did that was that I applied the "socketed" tome to the armour.
and
Expected behaviour
Not to crash?
Screenshots
Chestplate (If needed):

Flux Network wireless settings (If needed):

Inventory (If needed):

FluxNetworks-1.18.2-<IP_ADDRESS>.jar

I was the person who reported this on the FTB Modpack, but it looks like it's just a duplicate of https://github.com/SonarSonic/Flux-Networks/issues/490 so this issue can probably be closed.


Possible Bug with GAugO-GAT: Gradients cannot backprop through indexing

As described in your paper, the Gumbel Softmax trick is applied to enable the back-propagation. The gradients must go through the sampled adjacency matrix to the edge predictor. However, your implementation of GATLayer stops the gradients flow back to the edge predictor while the GCNLayer or GCNLayer is ok. If the gradients can not flow back through the adjacency matrix, the Gumbel Softmax trick is meaningless. I am not sure if I understand it right.
The key difference is how to aggregate node features. Use matrix multiplication or indexing?
In Line 703 of GAug.py, you use indices to pick up the corresponding node feature. The indices coming from nonzero function is not differentiable.
class GATLayer(nn.Module):
    def forward(self, adj, h):
        if self.dropout:
            h = self.dropout(h)
        x = h @ self.W # torch.Size([2708, 128])
        # calculate attentions, both el and er are n_nodes by n_heads
        el = self.attn_l(x)
        er = self.attn_r(x) # torch.Size([2708, 8])
        if isinstance(adj, torch.sparse.FloatTensor):
            nz_indices = adj._indices()
        else:
            nz_indices = adj.nonzero().T
        attn = el[nz_indices[0]] + er[nz_indices[1]] # torch.Size([13264, 8])
        attn = F.leaky_relu(attn, negative_slope=0.2).squeeze()

Here is a toy example.
# generate some features
X = torch.randn((3, 7), requires_grad=True)
# generate adj matrix
adj = torch.randint(2, (3,3), dtype=torch.float, requires_grad=True)

# use nonzero to get idx of source node and target node
nnz = adj.nonzero().T
# get source node and target node feature via indexing
source, target = X[nnz[0]], X[nnz[1]]

# compute an example loss function
loss = (source + target).mean()
loss.backward()

print(source, target)
print(adj.grad)

The output of the last line is None.
The gradients can flow through the adjacency matrix via matrix multiplication, as the implementation of GCNLayer.
Here is a toy example.
# generate some features
X = torch.randn((3, 7), requires_grad=True)
# generate adj matrix
adj = torch.randint(2, (3,3), dtype=torch.float, requires_grad=True)

# use matrix multiplication to get node feature
source = adj @ X

# compute an example loss function
loss = (source).mean()
loss.backward()

print(source, target)
print(adj.grad)

At this time, the grad of adj is correctly computed.
I wonder how to aggregate source and target node features in GAT while making gradients flow through the sampled adjacency matrix.

Hi, thanks for pointing this out! This looks very interesting. I need to do some testing on it to double check on the problem and also see if I can solve it. I'll get back to this issue after that.


[Bug] Move_Backwards not working

Describe the bug
A clear and concise description of what the bug is.
Install the mod, try /offline move_backwards
Expected behavior
A clear and concise description of what you expected to happen.
offline player moves backward
Versions (please complete the following information):

Minecraft: 1.21
Mod Version: 1.0.5 <

Additional context
Add any other context about the problem here.
Should move backwards

Closed by #22

Closed by #22


fix bug "saved config can broke UI"

closes #354

Thanks for the PR, we really appreciate your contribution.
This patch does fix the symptoms but it doesn’t address the root cause.
Would you make it so the button is disabled and maybe add a tooltip to explain why.
(Also it shouldn't be configurable)
Thanks in advance

I think we should merge this fix. A new API version is coming.
With this new version we will be able to know all the versions of all charts. This is a prerequisite to create a good feature about the lifecycle of saved config

@fcomte agreed


I just use a list of methods to keep track of operations on the free monad (I think this is roughly what it means to be "a (free) monoid in the category of functors", but would be interested to know if that's true or not)
* The of function should now be passed into dispatch rather than foldMap

Wow this looks terrific! Thanks for all the work!
Give me a bit to play around with it, but can I ask the reasoning behind Call vs monadic composition? Wasn't sure if it's a performance thing.

Wow this looks terrific! Thanks for all the work!

Thank you! Not at all

can I ask the reasoning behind Call vs monadic composition?

It's so that we can dispatch to the methods on the final monad instance rather than be forced into sequentiality by chain. I realised my approach had the flaw that not all fantasy-land monads have ap and map defined, so now have added fallbacks to chain in that case

(Also, I've been thinking about it, and am not sure if this module should handle derivations or not. The user could make sure the monad they're using has the necessary functions. I've extracted the logic to (fantasy-derivations)[https://github.com/rjmk/fantasy-derivations] as it's completely separate. It could be added as a dependency here, but that would increase the number of dependencies by 50%

Dude, I've been waiting for derivations forever! Good work 👍
Yeah, let's depend on that for sure.

Dude, I've been waiting for derivations forever!

Awesome, glad you like it!

let's depend on that for sure

Done

Hey, @DrBoolean! I'm guessing you're still reviewing / thinking about this, in which case no rush. But if there's something you're unsure on / would like changed, just let me know

hey! Sorry for the wait. I'm about to use it on a task for the day so i'll have a chance to check it out. Thanks for being patient!

Not at all! that's super exciting. Looking forward to hearing how it goes

Hey! Having had a look at the changes introduced by #7, I don't think it will be easy to resolve the conflicts without undoing the work it did, so I'm going to close this PR


Carousel visuals

In the modal for driving environment, you can find this carousel. It consists of a content container (header + paragraph), and a few images with a caption text below them.
https://www.figma.com/file/yv0VtHTvMoGPqkv0RAYcVp/PDP?type=design&node-id=1812-24921&mode=dev
Requirements

Buttons with previous/next arrows are used to navigate

When the start or the end of the carousel is reached, the respective button will be shown as inactive/disabled

On desktop, the content container is shown next to the images
On mobile/tablet the content container is shown on the top
Content remains static
Images will have a caption
Animation is similar to Promises
The component uses scroll-snap, and its behaviour/implementation is the same as #11 on mobile

To be determined

[ ] How do we name this block?

related to #78

confirmed as done
as tested on https://70-content-carousel--vg-volvotrucks-us-rd--netcentric.hlx.page/drafts/lakshmi/content-carousel


Not able to initiate the project

Tried the elevated powershell as well, but stiil showing the same message.
The "mkdir" command works perfectly if executed explicitly.
System: Windows 11

Hey @darshk07 thanks for reporting this. Can you share the CLI version you are using? You can get that with npx vratix -V
I will look into it today and get a fix out asap.

I'm trying to use the latest one only.
v.1.0.7

Hey @darshk07 I have resolved the issue, we will try to publish the fix tomorrow. I will update the issue once the new CLI is live

Hey @darshk07 we just released v1.0.8 of the CLI that fixes bugs on Windows. I tested this on a Windows VM so lmk if it works fine on your machine. I am closing this issue now, feel free to reopen it if you still experience issues on init or add.


repositories selector

these values could be saved with google account or something.
I would like to only display the list that I want or I can send with this tool to avoid possible errors because with a click all goes to the master branch.

Hi,
Yes - a customised list of branches/filtered repositories would be a great idea.....will see what I can do next week ;)
Jd

wow that would be great, attentive thanks, is the only thing that I think he needs urgently :+1:

Hi Daniel,
Have finished this - added an extra menu item with custom dialog box that allows you to 'untick' the repos that you don't want to see on the sidebar. This is stored in the User-Properties, so they are document independent. All the code is updated in this repo, have tested but want to make triple-sure everything is working before pushing the update to Google. Will pop a message up here when it goes live, should be this evening (UK time) or tomorrow.
JD

All tested and the update has been speedily approved, so should be live now!
JD


Remove focus outline from body

When I click on layout body this focus outline appears

Thanks but this is for accessibility so users/screen readers can keyboard navigate to it


Add PWA capabilities for offline access

You mention reading these feeds on the subway, presumably you have your laptop and are running locally.
What would be really cool, of course, would be to have a stand-alone mobile app that fetched stories from the f43.me server in the background.
To this end, I updated my fork to Symfony 6.4 and replaced Webpack with AssetMapper (woohoo, no more node! no more build step!)  Creating the offline app won't be hard, though the background sync part is something I'm still learning.
I tried to upgrade to Symfony 7, but there are some issues with graby that I are being worked on.
This really is a cool application, thanks again for releasing it.  I look forward to your feedback about a PWA, it's obviously a somewhat big decision because the Symfony bundle that I'd use to create the PWA requires AssetMapper and Symfony 6.4 || 7.0

Sorry, I think I missed your issue.
I build that project to have access to full content in RSS that I then read offline after having synced them on my mobile. But on a daily basis I never go to the website. Because I'm using RSS provided by it only.
That's why I think adding PWA might be a bit overkill.


How to stop and exit correctly?

Windows 2012 Python 3.5
Want to stop and exit script execution after 1st message, as example
def ws(msg):
   print(str(msg))
   global conn_key
   bm.stop_socket(conn_key)
   sleep(5)
   bm.close()
   print('bm_close')
   sleep(5)

Tryed
    exit(0)
    os._exit
    sys.exit()

with no result. Also Alt-F4 doesnt't work in window too.
Starting as
if __name__ == "__main__":
    bm = BinanceSocketManager(client)
    conn_key = bm.start_trade_socket('BTCUSDT', ws)
    bm.start()

With best regards,

reactor.stop()
On Sat, Feb 3, 2018 at 1:49 PM, nuts577<EMAIL_ADDRESS>wrote:

Windows 2012 Python 3.5
Want to stop and exit script execution after 1st message, as example
def ws(msg):
print(str(msg))
global conn_key
bm.stop_socket(conn_key)
sleep(5)
bm.close()
print('bm_close')
sleep(5)
Tryed
exit(0)
os._exit
sys.exit()

with no result. Also Alt-F4 doesnt't work in window too.
Starting as
if name == "main":
bm = BinanceSocketManager(client)
conn_key = bm.start_trade_socket('BTCUSDT', ws)
bm.start()
With best regards,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sammchardy/python-binance/issues/160, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AF4msxN0GaCy_dto90g8UbaUPpNV4lxCks5tRFXsgaJpZM4R4KII
.

Thanks very much, it works.


stake-pool: Ceiling all fee calculations (HAL-01)

Problem
During deposit and withdrawal functions, if the SOL or pool token amount is small, it is possible the fee calculations floor to zero due to loss of precision, preventing fee collection.
Solution
This scenario is not economically viable, and the cost of fee avoidance would outweigh the benefit of depositing such a small amount to the stake pool, but it's better to fix things up.
The change takes the ceiling of all fee calculations by adding denominator - 1 to the numerator.

seems straightforward!


serial: sam: Fix compile error

commit 57286afdd60bc0522aa09848f4862e930c75eb7d introduced a compile
error in the uart_sam driver.  The function uart_sam_irq_callback_set
should have be updated to have the callback data variable called
cb_data instead of data.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

Merging #9331 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9331   +/-   ##
=======================================
  Coverage   52.47%   52.47%
=======================================
  Files         201      201
  Lines       25317    25317
  Branches     5287     5287
=======================================
  Hits        13284    13284
  Misses       9948     9948
  Partials     2085     2085

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c56d5...cf38bc6. Read the comment docs.

This was the same as PR #9343, merged that one, so closing this one.


Allow conversion to Geometry

Currently it is only possible to convert result to a mesh, internally you construct geometry, so it would make sense to also allow conversion to geometry (I actually need Geometry, not Mesh).

Added in v2.2.0

Added in v2.2.0


math/big: correct a typo in the SetBit method documentation

I believe there's a mistake in the documentation.
f b is 0 SetBit sets z = x &^ (1 << i). If b is not 0 or 1, should be f b is 0 SetBit sets z = x & ~(1 << i). If b is not 0 or 1,
(That is, switch the ^ operator, which is binary, to the ~ operator, which unary.)

@googlebot I signed it!


[Installation] DOWNLOAD ZIP

The link https://download.get.foundation/sites/download is broken

Duplicate of this pinned issue: https://github.com/foundation/foundation-sites/issues/12189
Please use the search before opening a new issue.

Duplicate of this pinned issue: https://github.com/foundation/foundation-sites/issues/12189
Please use the search before opening a new issue.

cc @joeworkman please let me know if you need help with the setup.

cc @joeworkman please let me know if you need help with the setup.


images/deno_logo_4.gif looks bad on some apps/browsers

Rain animation looks bad on some browsers/apps (Discord on iPhone and Linux) and may look fine on browsers/apps (Firefox on Linux).
Original:

I asked couple of people on Discord to confirm this problem, for some people it animates rain correctly, for some it does not.

I don't think this is a problem with this web site, but with discord


would you please  share the pretrained model?

would you please  share the pretrained model?

Thank you for your attention. We will release it as soon as possible.


adding blueprints relative to another

Is it possible to add a Blueprint relative to another one? E.g.
bp1 = bb.BluePrint()
bp1.insertSegment(0, ramp, (0, 1e-3), name='wave1', dur=3.001e-6)
bp1.insertSegmentOffset(relative='wave1', offset=1e-6, ramp, (0, 1e-3), name='wave2', dur=3.001e-6)

Not currently in that form. But it is unclear to me what this is supposed to achieve. Can you elaborate? Naively I would say that since you specified the 0 for wave1, you can specify a 1 too for wave2 and get exactly the desired behaviour, but I'll bet that's not what you're after.

If the time that wave1 ends changes, I want the time that wave2 starts to change with the same amount. I  can program this myself using the current broadbean capabilities, but something like relative offsets makes it easier to program and to understand.


Module can't see its direct dependencies when bean only used in ConstraintValidator

Java 17, Spring boot v3.2.0, spring modulith v1.1.0

Maybe this is the expected behaviour. But let me summarize what happened:
Normally, I don't need to add @Component annotation in any of the my custom annotation (spring will automatically inject the corresponding bean) for instance:

com.mehmetozanguven.myapp.otherDependency => otherDependency module
com.mehmetozanguven.myapp.auth => auth module (it uses otherDependency.TestService)

Dummy TestService:
package com.mehmetozanguven.myapp.otherDependency;

@Component
@Slf4j
public class TestService {
    // ...
}

package com.mehmetozanguven.myapp.auth.validation;

import com.mehmetozanguven.myapp.otherDependency.TestService;

@RequiredArgsConstructor
public class MyCustomValidator implements ConstraintValidator<MyCustomValidation, String> {
   // Spring automatically injects the testService
    private final TestService test;

    @Override
    public boolean isValid(String value, ConstraintValidatorContext context) {
       //...
    }
}

However Spring Modulith is failing, which says No qualifying bean of type ...TestService, for the Auth-Integration test:
// src/test/java/com/mehmetozanguven/myapp/auth
package com.mehmetozanguven.myapp.auth;

@ApplicationModuleTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
        mode = ApplicationModuleTest.BootstrapMode.ALL_DEPENDENCIES)
public class AuthIntegrationTest  {

    @Test
    void dummyTest() {

    }
}

The solution is to add @Component annotation into ConstraintValidator, or inject the TestService(in reality just a dummy injection) any of the bean in the AuthModule:
package com.mehmetozanguven.myapp.auth.validation;

@Component
@RequiredArgsConstructor
public class MyCustomValidator implements ConstraintValidator<MyCustomValidation, String> {
    private final TestService test;
   // ...
}

Would you mind preparing a small reproducer that shows the problem in a failing test case?

Would you mind preparing a small reproducer that shows the problem in a failing test case? Also, from your description it's not clear what exactly is causing the exception. The test case you show dows not have a direct dependency to TestService, so I assume some intermediate component is failing to get instantiated? A stack trace would be helpful here.

I have just created simple repo to simulate the issue (https://github.com/mehmetozanguven/modulith-constraint-validator). You can find the error stack in the readme.md

Very helpful. Fix coming in a minute.


Make contribution ID consistent from one whatsapp chat import to another

Currently contributionid is a uuid generated at random for each observation each time a whatsapp chat is exported into Kapta Mobile. In order to deal with the problem of duplicates from repeated uploads however, it would be better to generate an id from attributes which are consistent from one export to the next.

To make it unique, it'd have to be a combination of message.sender and message.datetime. I did consider including groupName, but that's too easy to change. I'm not sure what happens if a message sender changes their username if that updates old messages in the chat, in which case even message.sender isn't reliable, but there isn't really an alternative.
There doesn't appear to be a built in way to generate hashes, but this code snippet from blogpost looks like one way to do it:
export const sha256 = async (text: string): Promise<string> => {
  const encoder = new TextEncoder();
  const data = encoder.encode(text);
  const hash = await crypto.subtle.digest('SHA-256', data);

  return Array.from(new Uint8Array(hash))
    .map((byte) => byte.toString(16).padStart(2, '0'))
    .join('');
};

think we can mark this as closed now?


Add Vue's reactivity API to sharing state      alternatives list

What kind of changes does this PR include?

New or updated content
Changes to the docs site code

Description

Closes #2453

What does this PR change?
It adds a link to the alternatives listed on the Nano Stores docs pointing to the reactive() Vue docs.

Did you change something visual? A before/after screenshot can be helpful.
No, I did not.

Thanks to you! for the review and the warming welcoming to the Astro Docs contributors @delucis 🚀


One project for Flutter app and Flutter module

I created Flutter project via Android Studio that includes directory 'android'. Now, I want to use the project as module, for building 'aar' file, also I need run app as Flutter project. So I added module section in pubspec.yaml, but when I run 'flutter build aar' in a terminal, it show an error:

The build process for Android has changed, and the current project configuration is no longer valid. Please consult
https://github.com/flutter/flutter/wiki/Upgrading-Flutter-projects-to-build-with-gradle
for details on how to upgrade the project.

If I rename 'android' then 'flutter build aar' works fine. But it's bad approach.
[✓] Flutter (Channel master, v1.10.6-pre.35, on Mac OS X 10.14.6 18G95, locale en-RU)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2)
[✓] Android Studio (version 3.5)
[!] IntelliJ IDEA Community Edition (version 2018.3.5)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.38.1)
[✓] Connected device (1 available)

I don't think a flutter project existing as both a module and app are currently supported.
Out of curiosity, why do you want it as an app and module?  Or are you trying to one-time convert it from a project to a module?

@jmagman
I'm developing an standalone app, that also must be a module of other app (aka SDK)

@jmagman
I'm developing an standalone app, that also must be a module of other app (aka SDK)

Can your stand-alone app be a single-Flutter view version of an add-to-app host that imports your Flutter module?  That's all a flutter created app is, basically.

Closing this as not a supported configuration.  There's lots of places in the tool that drop into one case or the other depending on the presence of .android and .ios directories.


Visual Script Fixes

Fixed bug causing variable setters/getters added from the add node menu to be unusable when only one variable is present.
Updated setter/gettter port naming to make the node's state more clear.
Fixed regression causing script members to not update.

Nice.
But is there a reason for you to have rename _update_members ? I had fixed it on my branch(I am waiting for more breaking changes to get committed before making PRs) and there wasn't a need for the change, something I missed?
Secondly, I would recommend to keep all the method binds inside of VisualScriptEditor::_bind_methods() for easier maintainability.
And at last I am not sure why it was required to add another function to the VisualScriptNode class.?

But is there a reason for you to have rename _update_members ? I had fixed it on my branch(I am waiting for more breaking changes to get committed before making PRs) and there wasn't a need for the change, something I missed?

The main reason for the change was consistency, as I understand it functions which start with an underscore usually aren't 'publicly' exposed to the ClassDB. Since it was getting publicly exposed I changed the name to match the convention. Is this incorrect?

And at last I am not sure why it was required to add another function to the VisualScriptNode class.?

There wasn't a virtual function which got executed when a node was added to the graph. I could have made validate_input_default_values() fit the bill but that seamed obscure.

@fire, @akien-mga I think we can merge it if everyone is fine with adding a new function to VisualScriptNode class.

I believe,
We could just check which is the first property in the Constructor as well considering VisualScript has to be created before Nodes.
@jdbener would it not have worked?
Otherwise it's fine by me.

Hmmm. That's something I didn't expect but if that's the case then I believe it's fine to add another function in VisualScriptNode.

This was superseded by #49749, but it would be worth checking if all fixes from this PR are fully superseded or if some parts of it should be put in a new PR.


Replace data on POST?

I want to be able to post a whole new set of data to my endpoint /blocks/. So, if I start with an empty JSON object like so:
{
  "blocks": [ ]
}

and then post an array of objects to it. Currently, it will push an array into the blocks array like so:
{
  "blocks": [
     [ {
      "title": "Dropdown Question",
      "type": "dropdown-question",
      "id": 0
    },
    {
      "title": "Multiple Choice Single Answer",
      "type": "multiple-choice-single-answer",
      "id": 1
    } ]
  ]
}

Further posts will keep appending more arrays to blocks.
Instead, I want to  replace the value of blocks. So, on first post it will create the top-level array and further calls will replace that array?

Is this not possible? Seems like a common use-case to me.

I think using POST to replace collection of resources is not a common way to do it. Correct me if I'm wrong.
I'd rather delete all posts with DELETE /posts and then POST new collection. Unfortunately, it seems that deleting entire collection is currently not suported by json-server.

same question.
I want use this json-server with vuejs, I found when I make a post request, It just replace the data from 'bd.json', In my situation, I just want use POST request to get some data via params, seems like POST means here is to post some data and replace old.

Hi @fishenal,
I would suggest using GET instead, as in REST POST is used to create new data.

Noticing the same thing where if I POST an array of objects it creates a sub array. Is there way to POST an array of objects normally?

I'm looking at this too although I'm wanting a Bulk Insert option. One why I would consider handling this is having the server detect if req.body is an object or an array. In the latter case you could iterate over the array and do a transactional process to insert each object.
Since this is likely just a mock server and it's using lowdb it looks like we could just do this with something like what the docs there show:
import low from 'lowdb/lib/fp'
const db = low()

// Get or set posts
const posts = db('posts', [])

But how do we get a handle to db from json-server? Also this feels like a nice add for the default middleware rather than needing do this manually.
This might address others issues as well. While not overwriting stuff you could issue a bulk delete and then a bulk insert. Still one extra step, but through explicit intent.

Also, it will be great to have a bulk insertion of PUT request. Hope the author will find a solution!

still nothing here? is there a way do replace on POST (or put, or whatever)?

Develop this feature fast


MVI: Help with intent() function and RxJava1

Hi, my project is still RxJava. I can't do the interop with the RxJava2 Observable parameter required by intent().
What I have:
private class RxInteropViewIntentBinder<V : MvpView, I>(val binder: (V) -> Observable<I>) : ViewIntentBinder<V, I> {
        override fun bind(v: V): io.reactivex.Observable<I> {
            return RxJavaInterop.toV2Observable(binder.invoke(v))
        }
    }

    override fun bindIntents() {

        val loadFeed: Observable<PartialStateChanges> = intent(RxInteropViewIntentBinder(TvFeedView::loadFeedIntent))
                .doOnNext { Timber.d("intent: load feed") }
                .flatMap {
                    feedInteractor
// At this stage the Observable is ver.2 so I can't compose it with mine which are ver.1.
// Somehow I need to convert it back to v.1 but I don't know how. RxJavaInterop has
// a method named toV1Observable but it requires Producer.
                 ... }
     }

Could someone help?

Well, now I made it compilable at least...
val loadFeed: Observable<PartialStateChanges> = toV1Observable(intent(RxInteropViewIntentBinder(TvFeedView::loadFeedIntent))
                .toFlowable(BackpressureStrategy.DROP))

But don't know if it gonna work. I hope so. Otherwise I have to migrate the project to RxJava2.

Isn't it much simpler to use RxJava Interop when creating the intent() method on View Layer like in your activity?

Not sure what do you mean exactly, but intent() is a method of MviBasePresenter and it returns v2 Observable. If I use Interop on the View layer, I should change my view interfaces to v2. Anyway, now it compiles, let's see if it works. crosses fingers

yes, I meant that the View interface already returns a v2 Observable.
Anyway, converting my apps based on RxJava1 to RxJava2 was pretty straight forward. Basically it was a Replace in Path to replace
import rx

to
import io.reactivex

definitely an option to consider ...

I already tried with RxJava2 in the first place, but some libraries were RxJava1 only and I didn't know the existence of RxJavaInterop. I'm going to migrate as soon I stabilize it. Thanks.


Updates for Travis and Clang 3.9

I suspect you're right, and there's likely to be a more elegant solution here.
In this situation, the process performing the installation is Python's "distutils.setup" module (which we use to install MaterialX Python in preparation for unit testing), and its default target is the "site-packages" or "dist-packages" folder of the active Python installation.
In the previous Trusty environment, this target folder was considered writable (as it is on Appveyor, for example), but the newly-updated Trusty environment considers it to be write-protected.
One potential solution would be to point "distutils.setup" to a specific local folder, and to add this same folder to the PYTHONPATH in preparation for Python unit tests, though I'd hoped to avoid making any assumptions about the underlying folder structure in Trusty environments.
If you have any additional suggestions, they would definitely be appreciated!

The solution I'm currently leaning towards is to add a MATERIALX_INSTALL_PYTHON option to the root CMake file, which would control whether the "distutils.setup" step is executed.
In Travis builds, this option would be set to OFF, and PYTHONPATH would be manually set to "${CMAKE_BINARY_DIR}/installed/python" in order to make MaterialX Python accessible to unit tests.


Migrating Push to Azure looses lots of data

This issue tracker is named as feedback page for Migration document from John Wargo. So I just want to let you know, but it's not an issue, at least not for you :-(
With Azure Push there were lots of data to retrieve after the push was sent, e.g. how many devices were reached. Now, with Azure Notification Hub, it seems that we have to go for the "Standard" Plan which is 200$ per month! That's a large cost increase for us, from 0$ per month to 200$ per month.
Of course it was great to have it for 0$ in AppCenter, and I would not expect this for a free service. I have no problems with the Basic-Plan for 10$ per month. That's a reasonable price which i would like to pay. But I need to get these notification details via API, and I don't understand why this should not be available for 10$ per month. I'm sure the data is available on your site also for the free and the basic plan, it's just the opening of the API for users where you charge users 190$ per month 👎 Of course, Standard has some more features, but I don't need them. And the one "feature" I need, is not really a feature, it's just setting the "supply the notification id to the customer" from "false" to "true".....

@K232, we are sorry you are having issues with the migration to Azure Notification Hubs. To your point on telemetry, it is only available on the Standard tier for several reasons, including the fact that the service does not store the telemetry for namespaces on other tiers, so it is more than a matter of exposing available data.
If there is any way the Azure Notification Hubs team can assist in your migration (other than pricing), please let us know!


3487/smart refresh

Adds smart refresh for refresh workflow and refresh version. Smart refresh will only update a version if required (change on dockstore or on git). If a version has not been edited, it will be skipped. This is based mostly on whether the commit ID for a version has changed since the last refresh.
There is the case where the commit id has not been changed, however, a refresh needs to be done since changes were made on Dockstore. Perhaps the default path for a workflow was changed. This is solved by the synced column for workflow versions.
The new column synced represents whether or not a change has been made to a workflow/version on Dockstore since the last refresh was done. Any API call which edits a workflow (ex. change default path) or edits a version (ex. change workflow path) will set this bit to false. When a version is added for the first time or updated, synced is set to true.
There is also a new optional hard refresh option for refresh and refresh version (Default true). Setting this to true is equivalent to the current refresh implementation. When it is false, it will be a smart refresh. This smart refresh is what the refresh in the UI will call.
For the migration, the default value of synced is false. This is because any new version added should be refreshed.
The migration also sets all existing workflow versions to have synced as true. This probably requires some discussion. It assumes that no one has used the API to update a workflow or workflow version, since doing so doesn't automatically call refresh. In the UI, any changes to a workflow or workflow version is followed by a refresh.
https://github.com/dockstore/dockstore/issues/3487

See https://github.com/dockstore/dockstore/pull/3720 for new PR


HCLOUD-3196_Fix-OAuth-app-by-client-ID-endpoint_Jorge-Brown

Task linked: HCLOUD-3196 Fix OAuth app by client ID endpoint


[google_maps_flutter]: Polyline patterns doesn't work for iOS, but works on android.

iOS:

Android:

Relevant Code:
Polyline polyline = Polyline(
      polylineId: PolylineId("poly"),
      color: Color(0xffff6d00),
      points: coords,
      jointType: JointType.round,
      patterns: [PatternItem.dot, PatternItem.gap(10)],
    );

Version:
google_maps_flutter: ^0.5.27+3

Complete reproducible code sample
import 'dart:async';
import 'package:flutter/material.dart';

import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() => runApp(Main());

class Main extends StatefulWidget {
  @override
  _MainState createState() => _MainState();
}

class _MainState extends State<Main> {
  Set<Polyline> lines = {};

  Completer<GoogleMapController> _controller = Completer();

  static final CameraPosition _kGooglePlex = CameraPosition(
      target: LatLng(12.988827, 77.472091),
      zoom: 13
  );

  @override
  void initState() {
    super.initState();
    lines.add(
      Polyline(
        points: [
          LatLng(12.988827, 77.472091),
          LatLng(12.980821, 77.470815),
          LatLng(12.969406, 77.471301)
        ],
        endCap: Cap.squareCap,
        geodesic: false,
        polylineId: PolylineId("line_one"),
        patterns: [PatternItem.dot, PatternItem.gap(10)]
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Google Maps Polylines',
      home: Scaffold(
        body: GoogleMap(
          initialCameraPosition: _kGooglePlex,
          onMapCreated: (GoogleMapController controller) {
            _controller.complete(controller);
          },
          polylines: lines,
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.19.0-1.0.pre, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.19.0-1.0.pre at /Users/nevercode/dev/flutter_dev
    • Framework revision 456d80b9dd (8 days ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (5 available)
    • Redmi Note 7      • 6345c469                             • android-arm64  • Android 9 (API 28)
    • iPhone 11 Pro Max • 5D5365D0-C0F6-4440-B758-FFA83896129E • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-4
      (simulator)
    • macOS             • macOS                                • darwin-x64     • Mac OS X 10.15.4 19E287
    • Web Server        • web-server                           • web-javascript • Flutter Tools
    • Chrome            • chrome                               • web-javascript • Google Chrome 81.0.4044.138

• No issues found!

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86 • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios         • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.337, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.337 at /Users/tahatesser/Code/flutter_master
    • Framework revision 0768daaae3 (4 hours ago), 2021-01-14 05:39:03 -0500
    • Engine revision 1b5e16cda2
    • Dart version 2.12.0 (build 2.12.0-223.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86    • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)                    • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86 • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios         • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.337, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.337 at /Users/tahatesser/Code/flutter_master
    • Framework revision 0768daaae3 (4 hours ago), 2021-01-14 05:39:03 -0500
    • Engine revision 1b5e16cda2
    • Dart version 2.12.0 (build 2.12.0-223.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86    • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)                    • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

Duplicate of https://github.com/flutter/flutter/issues/60083
I already added it here: https://github.com/flutter/plugins/pull/3441
pr jobs are failing but no one can tell me why. :(

closing as a duplicate of https://github.com/flutter/flutter/issues/60083


Adding Python 3.5 on Travis.

Also removing unit tests on Travis for Python 3.4 (to keep the builds fast, if possible).

@tseaver Any reservations about this change?

@tseaver So we good to merge? No problem with only running 3.5 (rather than 3.4 and 3.5)?

@dhermes Are we picking up 3.4 under coverage?  Or just deciding not to support it?

@tseaver Neither. It's supported, just not tested on Travis. I can add it back if you think 3.5 and 3.4 will be sufficiently different. We also run 3.4 on AppVeyor (on merges to master).

If we don't test it, it isn't supported, because no one will hear the screams.

They will hear the screams on AppVeyor?

@tseaver Bump

What about running both 3.4 and 3.5 only on master builds?

Just left 3.4 in there to avoid the conflicting opinions holding this up. If we find Travis getting slow we can revisit.


Adding unit test for jsonp middleware

Implements #123
Line number 23 looks unreachable and hence is left out from the coverage.

Codecov Report

Merging #134 into master will increase coverage by 3.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   65.12%   68.36%   +3.23%
==========================================
  Files          46       49       +3
  Lines        1663     1751      +88
  Branches      436      457      +21
==========================================
+ Hits         1083     1197     +114
+ Misses        576      552      -24
+ Partials        4        2       -2

Impacted Files
Coverage Δ

packages/rate-limit/src/index.ts
100.00% <0.00%> (ø)

packages/rate-limit/src/memory-store.ts
100.00% <0.00%> (ø)

packages/rate-limit/src/rate-limit.ts
96.77% <0.00%> (ø)

packages/app/src/app.ts
88.63% <0.00%> (+1.13%)
:arrow_up:

packages/jsonp/src/index.ts
93.10% <0.00%> (+93.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e547ee5...a3b2469. Read the comment docs.

LGTM, merging

@all-contributors add @shubhi23994 for test


Not good enough syntax for loops (explicit lock needed)

In this issue we are talking about looped network topologies rather than HOCs like  map/filter/reduce

Usecase
In "99 bottles" example we have to use explicit lock instead of deferred connection because that's the only way to to implement manual loop:
next2Lines node should compute when we send initial message 99 and then each time it sends result which is not -1 - in this case result must be send back to next2Lines (this is where to loop is created).
Problem
We can't send [99, next2Lines] -> switch because 99 works as infinite sender and thus we'll create conflict between 2 streams, instead of sending 99 just once.
Because of this we need to defer sending 99 until :start is sent, which happens exactly once.
:start -> { 99 -> ??? }
[???, next2Lines] -> switch

Despite having a feature (deferred connections) exactly for that, we can't rely on it here and have to use explicit locks:
def Main(start) (stop) {
    Next2Lines, Lock<int> // explicit lock for fan-in to next2Lines
    ---
    :start -> lock:sig
    99 -> lock:data
    [lock:data, next2Lines] -> switch {
        -1 -> :stop
        else -> next2Lines
    }
}

Might be related to #717

HACK: solve at the level of next2Lines by adding 1 more port
def Main(start) (stop) {
    Next2Lines
    ---
    :start -> { 99 -> next2Lines:start }
    next2Lines -> switch {
        -1 -> :stop
        else -> next2Lines:next
    }
}

def next2Lines(start int, next int) (n int) {
    Dec<int>, PrintFirstLine, PrintSecondLine
    ---
    // printFirstLine and printSecondLine won't work in parallel
    // because they are in the loop at the level of Main
    [:start, :next] -> printFirstLine -> dec -> printSecondLine -> :n
}

I don't like this solution, it's clearly a hack. We basically moved complexity from one place to another and probably made this even less obvious.

HACK2: Introduce extra component
def Main(start) (stop) {
    Send99, Next2Lines
    ---
    :start -> send99
    [send99, next2Lines] -> switch {
        -1 -> :stop
        else -> next2Lines:next
    }
}

def Send99(sig any) (n int) {
    :sig -> { 99 -> :n }
}

def Next2Lines(start, next int) (n int) {
    Dec<int>, PrintFirstLine, PrintSecondLine
    ---
    // printFirstLine and printSecondLine won't work in parallel
    // because they are in the loop at the level of Main
    [:start, :next] -> printFirstLine -> dec -> printSecondLine -> :n
}

I would still consider this a hack, but maybe less than modifying Next2Lines. Perhaps somewhat at pair with original solution with explicit lock

Once component
A component that receives messages but only sends one of them, discarding all the rest
def Once<T>(data T) (res T)

Could be used like this
def Main(start) (stop) {
    Once, Next2Lines
    ---
    :start -> { 99 -> once }
    [once, next2Lines] -> switch {
        -1 -> :stop
        else -> next2Lines:next
    }
}

Questions
Should it send only first message completely ignoring all the rest or it should remember the message, compare new messages with it and send new as soon as it different than previous ones? Maybe Go has something like this? Or some other languages?

Related to #87

Could this be solved with for/foreach/etc? Some HOC or statement. Related to #723 and #739

At the moment solved with While (see #723)
This HOC is basically what implements loop with lock inside, so you don't have to
def Main(start) (stop) {
	While<int>{Next2Lines}
	---
	:start -> { 99 -> while:from }
	0 -> while:to
	while:res -> :stop
	while:err -> panic
}


Dist has incorrect logic in jquery section

https://github.com/corenzan/readonly.js/blob/29df904dcef391f050928e97529b864d6926bf68/dist/readonly.js#L116
The call to entryPoint in the dist version of the code differs from the src version in a way that actually is broken. By passing in _this the dist version is supplying a jQuery object as the target, which does meet the valid argument requirements and so throws the invalid argument error.
The dist file should be updated to reflect the correct logic found in the src version of the code.

Found the issue. https://github.com/corenzan/readonly.js/blob/master/src/readonly.js#L126
this inside the arrow function is the same this outside it. I'll fix it tomorrow.

Oh and thanks for taking the time, by the way. Really appreciate it! ;)

Also added test case for jQuery integration. Once again, thank you for your report!


[Component:DV] Possible False Positive Pass Results for Tests

when I run the following test:
make SEED=123 TEST=riscv_debug_basic_test

the regression log shows zero match instructions:
$ cat out/seed-123/regr.log

riscv_debug_basic_test.0
------------------------
Test binary: out/seed-123/instr_gen/asm_test/riscv_debug_basic_test.0.o
sim log: out/seed-123/rtl_sim/riscv_debug_basic_test.0/sim.log
ibex : out/seed-123/rtl_sim/riscv_debug_basic_test.0/trace_core_00000000.csv
spike : out/seed-123/instr_gen/spike_sim/riscv_debug_basic_test.0.csv
[PASSED]: 0 matched
1 PASSED, 0 FAILED

the reason for
no matched instructions is due to the spike_log_to_trace_csv.py script not dumping the instructions to the 2nd column.
$ head out/seed-123/instr_gen/spike_sim/riscv_debug_basic_test.0.csv
pc,instr,gpr,csr,binary,mode,instr_str,operand,pad
ffffffff80000080,,sp:40001000,,40001137,3,"lui     sp, 0x40001",,
ffffffff80000084,,sp:40001106,,10610113,3,"addi    sp, sp, 262",,
ffffffff8000008c,,s10:8002308c,,00023d17,3,"auipc   s10, 0x23",,
ffffffff80000090,,s10:80022ce4,,c58d0d13,3,"addi    s10, s10, -936",,
ffffffff80000094,,sp:80002094,,00002117,3,"auipc   sp, 0x2",,
ffffffff80000098,,sp:80002400,,36c10113,3,"addi    sp, sp, 876",,
ffffffff8000009c,,sp:80002401,,00116113,3,"ori     sp, sp, 1",,
ffffffff800000a4,,s5:800030a4,,00003a97,3,"auipc   s5, 0x3",,
ffffffff800000a8,,s5:80003134,,090a8a93,3,"addi    s5, s5, 144",,

Is this known behavior? Could this lead to false positive regression results? The two csv files look to be equivalent, and no failures are flagged in the riscv-dv compare script...
I noticed the same behavior for the following tests as well.
riscv_debug_basic_test.0
riscv_debug_branch_jump_test.0
riscv_debug_instr_test.0
riscv_debug_wfi_test.0
riscv_debug_ebreak_test.0
riscv_debug_csr_entry_test.0
riscv_irq_in_debug_mode_test.0
riscv_debug_in_irq_test.0
riscv_single_interrupt_test.0
riscv_multiple_interrupt_test.0
riscv_nested_interrupt_test.0
riscv_interrupt_instr_test.0
riscv_interrupt_wfi_test.0
riscv_interrupt_csr_test.0

Various tests disable the cycle by cycle ISS and RTL log comparisons and just compare final state instead. If you look in dv/uvm/core_ibex/riscv_dv_extension/testlist.yaml you can see some have compare_final_value_only: 1 set.
These occur in tests around interrupts and debug behavior as you can't stimulate spike to produce identical traces.
It's should be possible to modify this so trace comparison can occur outside of interrupt/debug handlers at least. Something we'd like to take a look at in the future.

that makes sense, thanks for the clarification


CSUB-556: Add Status check to Withdraw Unbonded command

Description of proposed changes

Added canWithdraw field to Status
Reformatted how printStatus shows unlocked chunks
withdraw-unbonded command now checks if there are unlocked funds before submitting the extrinstic

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

This PR is based on #1148

Codecov Report

Merging #1149 (94a4fb8) into dev (f2f16fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1149   +/-   ##
=======================================
  Coverage   74.62%   74.62%
=======================================
  Files          74       74
  Lines       10686    10686
=======================================
  Hits         7974     7974
  Misses       2712     2712

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: add download page

Download page :

Updated the PR please have a look

Updated the PR please have a look

@ryuk156 you can always add a new commit to this pr, doing force push seems erasing history and kind of looses essence of all the discussions we had and how amazingly your pr came up to here ?
I would suggest to add multiple commits and atlast point of merging , we can always make a merge them into single commit .
:)

@ryuk156 you can always add a new commit to this pr, doing force push seems erasing history and kind of looses essence of all the discussions we had and how amazingly your pr came up to here ?
I would suggest to add multiple commits and atlast point of merging , we can merge them into single commit .
:)

Thanks will follow this in next PR

There's a weird black line at the right side of the dropdown:

Is that expected?
Otherwise IMO it looks fine from a UI/UX point of view 👍
Code review is still outstanding. I'm not the right reviewer for this, but hope that @majordwarf find's time for it.

it looks fine for me in chrome as well as in edge can i know which browser you are using

Thank you, I think  I forgot to run prettier in during last push😅


change model url to public repo in text embedding model example doc

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #713 (ae5ddb0) into 2.x (f230a15) will decrease coverage by 0.11%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x     #713      +/-   ##
============================================
- Coverage     84.34%   84.24%   -0.11%
+ Complexity     1052     1050       -2
============================================
  Files            99       99
  Lines          3833     3833
  Branches        352      352
============================================
- Hits           3233     3229       -4
- Misses          450      453       +3
- Partials        150      151       +1

Flag
Coverage Δ

ml-commons
84.24% <ø> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../cluster/MLCommonsClusterManagerEventListener.java
67.64% <0.00%> (-11.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.