Change "Conditional Value" data element type's description of returned values

Expected Behaviour
The descriptions for the returned values should be changed so that they don't indicate that only string values are returned.
Based on https://github.com/adobe/reactor-extension-core/blob/ec17a5f7074133466587fd42216fdc717ed7a3f9/src/view/dataElements/conditionalValue.jsx#L104-L118, returned values are returned with their types as-is. The exception is for number-like values, which are cast to a Number type (which itself is a debatable casting).
For example:

I have a data element "my key-value object" that returns a key-value object.
I use "my key-value object" as the return conditional value.

If the return conditional value is returned in a Rule, then Launch returns "my key-value object" as its Object type. Launch does not return the string version of "my key-value object".
Given this logic, there is no good reason to state that a string value is returned.
Actual Behaviour

Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

@adobe export issue to Jira project PDCL as Task

Fixed in 3.2.2.


Export in CARF format

OECD has developed a standard reporting format for tax purpose.
We need to explore if we should use it. And have a look at the schema to validate which data we must provide.
https://www.oecd.org/tax/automatic-exchange/common-reporting-standard/schema-and-user-guide/

More info.
https://www.chainalysis.com/blog/oecd-crypto-asset-reporting-framework-reporting-obligations/


The 'Multi TS-Packet demux-bug fixed' https://github.com/akanchi/mpegts/pull/6/commits/ae8b73a4783c589afe78bba6ae37fc5b9da7ad86

The 'Multi TS-Packet demux-bug fixed' https://github.com/akanchi/mpegts/pull/6/commits/ae8b73a4783c589afe78bba6ae37fc5b9da7ad86
Should be cherrypicked and verified.
Originally posted by @andersc in https://github.com/akanchi/mpegts/pull/6#issuecomment-648113496

Could you submit pull request base on the main branch? I don't want to change too much codestyle.

Since our branches differ so much would it be possible for you to just change the break to continue and then also adjust the buffer as linked to above (if that is correct)?


The issue of incorrect judgment of disk type

Based on the previous issue, I understand that hwameistor determines the type of disk by examining the contents of /sys/block/*/queue/rotational. If it's 1, it's determined as an HDD, and if it's 0, it's determined as an SSD.
the nodes are returning 1, so hwameistor will classify them as HDDs.

ld:

lsn:

But in VMware, we can see that the disk type is SSD. In this issue, how can hwameistor correctly recognize the disk type?

as you mentioned above, hwameistor  determines the type of disk by examining the contents of /sys/block/*/queue/rotational.
If the rotational file on the host is wrong, then the result we recognize is also wrong.

see #1138 for manually workaround.

what caused the the rotational value wrong?

Need to confirm this part of the configuration

Drive type is flash

can you show  lsblk -o +ROTA output?
our mechanism for identifying the type of disk is the same as lsblk. If the output of ROTA is 1, it means that it is an HDD disk. I'd like to confirm that if this is the expected result.


SQL JDBC Presto - Error java.lang.NullPointerException

Good day
I have a problem connecting the presto driver
%%classpath add mvn
com.facebook.presto presto-base-jdbc 0.232
%defaultDatasource jdbc:presto://root@<IP_ADDRESS>:8282/hive/default

I can not figure it out and I can not see the full error trace.

It's my error. I deleted the presto jar from the library folder and error 'java.lang.NullPointerException' disappeared, but a new one appeared - No suitable driver


ebalka.nl after updating the site, broken download

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Russia
Provide a description that is worded well enough to be understood
[generic] Extracting URL: https://g.ebalka.nl/videos/138714/tihiy-trah-prodoljenie-2/
[generic] tihiy-trah-prodoljenie-2: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] tihiy-trah-prodoljenie-2: Extracting information
WARNING: [generic] Untested major version (3.8.1) in player engine - download may fail.
ERROR: [generic] Unable to extract flashvars; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[x] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU']
[debug] Portable config "H:\tmp\YoutubeDL\yt-dlp.conf": []
[debug] Encodings: locale cp1251, fs utf-8, pref cp1251, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [615a84447] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2022-02-24-git-8ef03c2ff1-full_build-www.gyan.dev (setts), ffprobe 2022-02-24-git-8ef03c2ff1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1803 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)

please share a verbose log (add -vU to your download command and copy/paste the full output)

after updating the site

so it used to work with the generic extractor?

please share a verbose log (add -vU to your download command and copy/paste the full output)

after updating the site

so it used to work with the generic extractor?

a week ago work perfectly, they changed design and some backend probably and now cant download
H:\tmp\YoutubeDL>y -vU https://g.ebalka.nl/videos/138714/tihiy-trah-prodoljenie-2/
[debug] Command-line config: ['-vU', 'https://g.ebalka.nl/videos/138714/tihiy-trah-prodoljenie-2/']
[debug] Portable config "H:\tmp\YoutubeDL\yt-dlp.conf": []
[debug] Encodings: locale cp1251, fs utf-8, pref cp1251, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [615a84447] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2022-02-24-git-8ef03c2ff1-full_build-www.gyan.dev (setts), ffprobe 2022-02-24-git-8ef03c2ff1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1803 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[generic] Extracting URL: https://g.ebalka.nl/videos/138714/tihiy-trah-prodoljenie-2/
[generic] tihiy-trah-prodoljenie-2: Downloading webpage
ERROR: [generic] Unable to download webpage: EOF occurred in violation of protocol (_ssl.c:1131) (caused by SSLError('EOF occurred in violation of protocol (_ssl.c:1131)')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
File "yt_dlp\extractor\common.py", line 732, in extract
File "yt_dlp\extractor\generic.py", line 2392, in _real_extract
File "yt_dlp\extractor\common.py", line 877, in _request_webpage
File "urllib3\connectionpool.py", line 467, in _make_request
File "urllib3\connectionpool.py", line 1099, in validate_conn
File "urllib3\connection.py", line 653, in connect
File "urllib3\connection.py", line 806, in ssl_wrap_socket_and_match_hostname
File "urllib3\util\ssl.py", line 465, in ssl_wrap_socket
File "urllib3\util\ssl.py", line 509, in _ssl_wrap_socket_impl
File "ssl.py", line 500, in wrap_socket
File "ssl.py", line 1040, in _create
File "ssl.py", line 1309, in do_handshake
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1131)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "requests\adapters.py", line 486, in send
File "urllib3\connectionpool.py", line 847, in urlopen
File "urllib3\util\retry.py", line 445, in increment
File "urllib3\util\util.py", line 39, in reraise
File "urllib3\connectionpool.py", line 793, in urlopen
File "urllib3\connectionpool.py", line 491, in _make_request
urllib3.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:1131)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "yt_dlp\networking_requests.py", line 314, in _send
File "requests\sessions.py", line 589, in request
File "requests\sessions.py", line 703, in send
File "requests\adapters.py", line 530, in send
requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:1131)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "yt_dlp\extractor\common.py", line 864, in _request_webpage
File "yt_dlp\YoutubeDL.py", line 4101, in urlopen
File "yt_dlp\networking\common.py", line 115, in send
File "yt_dlp\networking_helper.py", line 204, in wrapper
File "yt_dlp\networking\common.py", line 326, in send
File "yt_dlp\networking_requests.py", line 332, in _send
yt_dlp.networking.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:1131)

The site uses the KVS player but without the expected pattern var flashvars = {...}. Instead, an apparently random name is used and passed as the 4th parameter of the kt_player() invocation. I patched this temporarily upstream by matching and passing the name of the flashvars from the detection code into the KS extraction with a success.
Work-around: for video id nnn, get https://www.ebalka.video/embed/nnn.
Also, NSFW.


Add docs for react 0.14.x transformers

Optional optimisation transformers as featured in
https://facebook.github.io/react/blog/2015/09/10/react-v0.14-rc1.html#compiler-optimizations

thanks


Unknown ssl cer error

/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:144: SyntaxWarning: "is" with a literal. Did you mean "=="?
/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:394: SyntaxWarning: "is" with a literal. Did you mean "=="?
/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:400: SyntaxWarning: "is" with a literal. Did you mean "=="?
/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:144: SyntaxWarning: "is" with a literal. Did you mean "=="?
/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:394: SyntaxWarning: "is" with a literal. Did you mean "=="?
/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py:400: SyntaxWarning: "is" with a literal. Did you mean "=="?
Traceback (most recent call last):
File "/usr/local/bin/mongoaudit", line 33, in
sys.exit(load_entry_point('mongoaudit==0.1.1', 'console_scripts', 'mongoaudit')())
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/main.py", line 64, in main
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/main.py", line 23, in init
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/main.py", line 58, in main
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 287, in run
self._run()
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 385, in _run
self.event_loop.run()
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 790, in run
self._loop()
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 827, in _loop
self._watch_filesfd
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/raw_display.py", line 416, in
wrapper = lambda: self.parse_input(
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/raw_display.py", line 515, in parse_input
callback(processed, processed_codes)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 412, in _update
self.process_input(keys)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/main_loop.py", line 513, in process_input
k = self._topmost_widget.keypress(self.screen_size, k)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/container.py", line 598, in keypress
return self.top_w.keypress(self.top_w_size(size,
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py", line 220, in keypress
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/usr/local/lib/python3.10/dist-packages/urwid-2.1.2-py3.10-linux-x86_64.egg/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py", line 145, in keypress
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/widgets.py", line 184, in next
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/cards.py", line 99, in _next
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/testers/testers.py", line 32, in init
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/testers/testers.py", line 77, in get_connection
File "/usr/local/lib/python3.10/dist-packages/mongoaudit-0.1.1-py3.10.egg/mongoaudit/testers/testers.py", line 86, in get_tls_connection
File "/home/satya/.local/lib/python3.10/site-packages/pymongo/mongo_client.py", line 771, in init
dict(common.validate(keyword_opts.cased_key(k), v) for k, v in keyword_opts.items())
File "/home/satya/.local/lib/python3.10/site-packages/pymongo/mongo_client.py", line 771, in
dict(common.validate(keyword_opts.cased_key(k), v) for k, v in keyword_opts.items())
File "/home/satya/.local/lib/python3.10/site-packages/pymongo/common.py", line 780, in validate
value = validator(option, value)
File "/home/satya/.local/lib/python3.10/site-packages/pymongo/common.py", line 159, in raise_config_error
raise ConfigurationError("Unknown option %s" % (key,))
pymongo.errors.ConfigurationError: Unknown option ssl_cert_reqs
Please provide the solution for the same issue.

You can fix it with forcing the pymongo version to 3.9.0 on setup.py:
     install_requires=[
-        'pymongo>=3.9.0',
+        'pymongo==3.9.0',

Hi @Kr0n0  I'm also facing similar issue even after updating pymongo==3.9.0 as mentioned by you in the above comment. I'm using kali linux to scan mongodb using mongoaudit tool


Use applied ts instead of resolved ts for stale read

Feature Request
Is your feature request related to a problem? Please describe:
Currently TiKV uses resolved ts to determine if a stale read is safe or not, however, when there are pending transactions, the stale read is considered not safe even if the replica has enough data. And for worse, when TiDB retries it against leader instead of follower, it will still fail as long as the pending transactions are not concluded.
Describe the feature you'd like:
Applied ts could be more accurate to determine if a stale read is safe or not.
Describe alternatives you've considered:
have another request mode that just returns whatever latest value available without staleness check, this mode could work better in terms of performance and well suit for our use cases, however, it is not clear if it is a thing TiDB want to support.
Teachability, Documentation, Adoption, Migration Strategy:
Stale read is a very useful feature for multi region setup, even in a single region setup, stale read against follower could save cross availability zone network cost.

PTAL @BusyJay

Can you explain more on the definition of "applied ts"?

yeah, sure, it may not be a concept currently available in tikv but i mean to associate a safe read timestamp, probably should be just current timestamp, with each raft entry, then applied ts is basically the timestamp associated with the latest applied raft entry

We have considered applied ts when stale read is designed. We choose resolved ts in the end because applied ts needs replication and extra round of communication to advance to new ts, and it is very similar to resolved ts. We try to avoid introducing and maintaining new duplicated concepts, which will add complexity to most features and optimization.
For the shortcoming of resolved ts, we need to use other mechanism guarantee its freshness. For example:

We need to resolve lock actively if stale read is critical (but back in the time when we design stale read, the goal is to guarantee tens of seconds or event minutes);
Advance min-commit-ts for those long running transactions, this part is done as far as I know.

i see, thanks for the explain! could you help to share some information about item 2, does it mean the long running transactions doesn't block stale read?

thanks for the reply, however, i am still a bit confused, does a long running transaction, say runs for 10 minutes, block the stale read or not?

If the lock of the long-running transaction could be resolved the read would not be blocked, usually this is not a problem except in a few extreme cases.

just to confirm i understand it, let's say there is a transactions running for minutes due legit reason (perhaps calling a few 3rd party api). then all of the stale read, regardless which table is read, will be at least a few minute stale. is my understanding correct here? thanks!

another part of the concern is, right now, tidb has the logic to retry the stale read against leader in failure, but the leader will reject the request based on resolved ts as well.

just to confirm i understand it, let's say there is a transactions running for minutes due legit reason (perhaps calling a few 3rd party api). then all of the stale read, regardless which table is read, will be at least a few minute stale. is my understanding correct here? thanks!
@hihihuhu
If the transaction is still in the execution phase, the stale read would not be affected which means it should not be blocked and the staleness is not affected too.

If the transaction is in committing phase(2PC), if the prewrite lock is not committed yet and it's encountered by the read operation, the reader must try to resolve it first. Usually, the committing phase would not take too long so the stale read would not be affected too. Except in a few extreme cases the write duration in tikv is abnormal the read may be blocked for some time.
So generally speaking, the stale read would not be affected by long-running transactions.

just to confirm i understand it, let's say there is a transactions running for minutes due legit reason (perhaps calling a few 3rd party api). then all of the stale read, regardless which table is read, will be at least a few minute stale. is my understanding correct here? thanks!

@hihihuhu
If the transaction is still in the execution phase, the stale read would not be affected which means it should not be blocked and the staleness is not affected too.
If the transaction is in committing phase(2PC), if the prewrite lock is not committed yet and it's encountered by the read operation, the reader must try to resolve it first. Usually, the committing phase would not take too long so the stale read would not be affected too. Except in a few extreme cases the write duration in tikv is abnormal the read may be blocked for some time.
So generally speaking, the stale read would not be affected by long-running transactions.
Maybe it's better to explain what's "resolve lock" mean? @cfzjywxk  Does it mean either to commit it or to abort it?

Yes, "resolve lock" is to commit or abort an encountered lock for concurrent read and write operations.
Usually, the stable read blocked by a large transaction is not related to the resolve lock processing, it's because the resolved-ts used by stale read is calculated by start_ts of transactions. If a large transaction could not be committed in time, its start_ts may block the update of resolved_ts, so the stale read could be rejected.


Get Declaration for Type

Today I've got another problem: Is it possible to fetch the com.github.javaparser.ast.body.ClassOrInterfaceDeclaration for a com.github.javaparser.ast.type.ClassOrInterfaceType?
I've seen that the JavaParserFacade can be used to convert a Type and a Node to a TypeUsage (right now I don't know which node to pass to that method). Afterwards the TypeUsage can be used to get the type's declaration (which is a me.tomassetti.symbolsolver.model.declarations.TypeDeclaration). I guess the wrappedNode of this declaration is what I'm looking for, but in the current implementation of the Java Symbol Solver it is a private field. Is it possible to add a public getter for this field?
The reason I need access to the AST node is type name resolution as discussed in #37.

Well, yes we could do that but TypeDeclaration could correspond to classes obtained through reflection or from jars. Only in the case they derives from JavaParser nodes you would be able to access it.

That would be perfectly fine! :)

I think that once you have the TypeDeclaration you could check if it is an instance of JavaParserClassDeclaration or JavaParserInterfaceDeclaration. If that is the case you can call getWrappedNode and get what you need.

That sounds good.
In case the Type was resolved using the JarTypeSolver or the JreTypeSolver there is no Javaparser AST. So it's reasonable that classes used here do not offer any getWrappedNode method. I'll just use the getQualifiedName as a fallback.
But if there is an AST node for that Type I'll need to use that node to resolve the name. This ensures that these types are always referred to using the same name (when indexing the Type's declaration and when indexing its usages).

Oh, I just noticed that the getWrappedNode methods already exist! Initially I opened this issue to request adding them to the Java Symbol Solver.  But you will not see any local classes outside the method, so you should be covered, because the only local classes you will see will come from source code, not compiled code

Exactly. It seems to be working as expected. Thank you for your guidance.

Thank you for your interest in the project and let me know if I can help further

Actually there is one more thing. Converting the javaparser...ClassOrInterfaceType to a symbolsolver...TypeDeclaration still gives me a headache.
There is a JavaParserFacade.convert method but most of the time it is throwing an UnsolvedSymbolException like the following:
Exception in thread "Thread-3" UnsolvedSymbolException{context='unknown', name='AnnotationDeclaration', typeSolver=null}
        at me.tomassetti.symbolsolver.javaparsermodel.JavaParserFacade.convertToUsage(JavaParserFacade.java:440)
        at me.tomassetti.symbolsolver.javaparsermodel.JavaParserFacade.convert(JavaParserFacade.java:483)
        at me.tomassetti.symbolsolver.javaparsermodel.JavaParserFacade.convert(JavaParserFacade.java:479)
        at io.coati.JavaTypeNameResolver.getTypeName(JavaTypeNameResolver.java:29)
       ...

I think it's possible that I'm providing the wrong context when calling the method like that: convert(type, type). Can you please give me a hint what node I should provide as the second parameter?

Oh, calling convert(type, type) seems to be totally alright! I guess the second parameter of this method can be used to skip some context layers, but passing the same node here as for the first argument is working fine as well.
In my case the issue was a totally different story. I was not creating my JavaParserTypeSolvers correctly, but didn't find out right away. I was only looking at the innermost context, not at the CompilationUnitContext.


add support for tabs in free mode

a lil crazy idea ...

def' crazy, will I really add this?

ok, added fixed 4 tabs for editing


[test-operator] Fix tempest workflows

Currently, the tempest_workflow var is not passed to the run-test-operator-job.yml thanks to this the role does not wait for the last test pod and finishes prematurely.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

/approve


Introduce send-default-pii option to handle sensitive data

This PR introduces send-default-pii option to handle sensitive data that can be added to events by default.
Currently, it affects device.name and user.id.
Resolves #13

This PR may have confilicts with #20, so I'm keeping it draft for now.


Grouping of logical models

Logical models are grouped in the Artifact page right now as Common and belonging to a certain use case.
What is the long-term approach we'd want to use? Artifacts unfortunately allow listing one resource only once, so we cannot repeat the same model under multiple use cases. As almost everything can be shared between different use cases, we cannot leave all those under common either.
Not an urgent issue, but the scene is getting slightly messy already. I think I would leave only very very common models (Patient, Address, etc) under Common models on the Artifacts page.

I have changed the IG structure a little bit according to the discussion we had in 13.09 call.
I added a menu item for use cases and each use case can have its own page with diagrams and links to models and FHIR IG(s).
Personally, I'm happy with the result (only did it for eP/eD) but open to further discussion and change.
This is eP/eD use case page for now:
https://build.fhir.org/ig/Xt-EHR/xt-ehr-common/useCasePrescription.html

Logical models meeting 22.10.2024

One IG for models or several -- Better to keep all the logical models in one IG. HL7 Europe can use this one IG as a dependency to create mappings between logical models and FHIR profiles.
Remove grouping from artifacts, create subpages for all use cases and link models from there.
eHN guideline mappings to models needed? – Better have them in the deliverable to show the evolution. No point working on this right now in the IG, because published versions don’t match the improved versions from the data consistency task force anyway.
Common models – should we have a separate page with a list of common models? Maybe better to have a narrative page, so that we would not try to communicate a clear line between common and not common.

2024-10-30:
References from e.g. HL7 Europe IGs to Xt-EHR/EHDS logical models. More stable links are available: https://xt-ehr.github.io/xt-ehr-common/
The commission might want to decide on the URI for the IGs and models.


nomad, nomad_1_7, nomad_1_8: build with buildGo122Module

Description of changes
Use buildGoModule122 for Nomad 1.7.6+, rather than Go 1.21.
As of 1.7.6, Hashicorp builds Nomad with Go 1.22 in order to address https://github.com/advisories/GHSA-3q2c-pvp5-3cqp, https://github.com/advisories/GHSA-rr6r-cfgf-gc6h, and https://github.com/advisories/GHSA-j6m3-gc37-6r6q.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Consider just using buildGoModule, since that defaults to 122 now - that way we won't have to bump it when we move to 123
Ignore this if nomad is super sensitive and would break with an autobump to 123

@RaghavSood see this comment in the file:

Nomad (...) is unsupported on Go versions that it did not ship with. Due to historic bugs when compiled with different versions we pin Go for all versions. Upstream partially documents used Go versions here
https://github.com/hashicorp/nomad/blob/master/contributing/golang.md

Autobumping has caused problems in the past, so I would prefer to pin it. That being said, it is as bad to not bump manually if upstream does bump, so we definitely need to do a better job at looking out for Go upgrades when approving PRs!

Hi @techknowlogick @rushmorem tagging for review 🙏 thanks


Hubble: User info is missing from URLs when observing L7 HTTP flows

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
This issue is related to https://github.com/cilium/cilium/issues/23887, in which we are gradually adding support to Cilium to redact sensitive data fields when observing L7 flows with Hubble.
Before extending Cilium's HTTP parser and configuration to conditionally redact sensitive, user-provided information in URLs (e.g., password), I wanted to understand the existing mechanism and verify that sensitive data is always redacted by Cilium's HTTP parser. The corresponding logic can be found here:
https://github.com/cilium/cilium/blob/main/pkg/hubble/parser/seven/http.go#L38
In a nutshell, if the user:pass@ part exists in the URL of an HTTP request, I was expecting Cilium's HTTP parser to redact the password and print the username:
...
    "l7": {
      "type": "RESPONSE",
      "latency_ns": "666414",
      "http": {
        "code": 200,
        "method": "POST",
        "url": "http://user:HUBBLE_REDACTED@host/path",  <---
        "protocol": "HTTP/1.1",
...

Instead, what I observed was that the user:pass@ part was completely missing from the "calculated" URL in the flow, as shown below:
...
    "l7": {
      "type": "RESPONSE",
      "latency_ns": "666414",
      "http": {
        "code": 200,
        "method": "POST",
        "url": "http://host/path",  <---
        "protocol": "HTTP/1.1",
...

Cilium Version
cilium-cli: v0.15.11 compiled with go1.21.3 on linux/amd64
cilium image (default): v1.14.2
cilium image (stable): v1.14.3
cilium image (running): 1.14.3

Kernel Version
root@kind-control-plane:/home/cilium# uname -a
Linux kind-control-plane 6.2.0-34-generic #34~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep  7 13:12:03 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Kubernetes Version
Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3

Sysdump
No response
Relevant log output
No response
Anything else?
Development environment

Create a kind Kubernetes cluster with 2 nodes (control plane and worker) via make
Deploy Cilium via the cilium CLI
Enable Hubble via the cilium CLI
Deploy sample application from https://docs.cilium.io/en/stable/gettingstarted/demo/#starwars-demo via kubectl
Port forward the Hubble relay service via the cilium CLI
Apply Cilium network policy from https://raw.githubusercontent.com/cilium/cilium/HEAD/examples/minikube/sw_l3_l4_l7_policy.yaml via kubectl
Observe HTTP flows with hubble observe --pod deathstar --protocol http -o json -f | jq
Send sample HTTP request with user info (username and password) in the URL from the tiefighter Pod to the deathstar one with: kubectl exec tiefighter -- curl -s -XPOST -v<EMAIL_ADDRESS>
Investigation/Debugging

After a bit of searching it seems that it's not Cilium's HTTP parser's fault that user info is not detected in URLs.
The decodeHTTP() method receives an accesslog.LogRecordHTTP that it only reads, not modifies. In turn, this record is set via r.HTTP when decodeHTTP() is invoked in https://github.com/cilium/cilium/blob/main/pkg/hubble/parser/seven/parser.go#L359. In turn, r is a LogRecord struct that contains the LogRecordHTTP field for HTTP log records which, in turn, contains the full URL, possibly containing user info.
However, when the HTTP log record and tags are created in https://github.com/cilium/cilium/blob/main/pkg/envoy/accesslog_server.go#L176 I see that we compute the URL without parsing and setting user info (we only set scheme, host and path):
 l7tags = logger.LogTags.HTTP(&accesslog.LogRecordHTTP{
 	Method:          httpLogEntry.Method,
 	Code:            int(httpLogEntry.Status),
 	URL:             ParseURL(httpLogEntry.Scheme, httpLogEntry.Host, httpLogEntry.Path),  <--
 	Protocol:        GetProtocol(httpLogEntry.HttpProtocol),
 	Headers:         GetNetHttpHeaders(httpLogEntry.Headers),
 	MissingHeaders:  GetNetHttpHeaders(httpLogEntry.MissingHeaders),
 	RejectedHeaders: GetNetHttpHeaders(httpLogEntry.RejectedHeaders),
 })

Based on the above, it does not make sense how Cilium's HTTP parser is supposed to parse and detect user info in the URL of the provided accesslog.LogRecordHTTP. Does this mean that we will have to extend HTTPLogEntry of the Cilium API defined in:
https://github.com/cilium/cilium/blob/main/vendor/github.com/cilium/proxy/go/cilium/api/accesslog.pb.go#L181
I see that this file is auto-generated. BTW, I could not locate the referenced source file: cilium/api/accesslog.proto Feel free to provide feedback on the above and correct me if any assumptions are not correct.

I was able to "short-circuit" Envoy to always include the user:pass@ part in observed URLs, even if it is not actually present in the URL of the HTTP request. I did so by modifying the following line https://github.com/cilium/cilium/blob/main/pkg/envoy/accesslog.go#L19 to:

- u, err := url.Parse(fmt.Sprintf("%s://%s/%s", scheme, host, strings.TrimPrefix(path, "/")))
+ u, err := url.Parse(fmt.Sprintf("%s://%s:%s@%s/%s", scheme, "user", "pass", host, strings.TrimPrefix(path, "/")))

After this I was able to see the password getting redacted by Cilium's HTTP parser:
      "http": {
        "code": 200,
        "method": "POST",
        "url"<EMAIL_ADDRESS>  <---
        "protocol": "HTTP/1.1",

This probably allows me to focus on extending Cilium's configuration mechanism to conditionally redact user info in HTTP flows, rather than ensuring that user info is present in observed URLs, if specified.
@rolinh @lambdanis @chancez @nathanjsweet @nbusseneau (cc-ing you since you were recently involved in https://github.com/cilium/cilium/pull/26724)
@ChrsMark (cc-ing you for visibility)
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm not sure it makes sense to include in the URL, and I'm not sure it's actually ever normally 'part of' the URL anyways. Generally, client convert the user:pass@ into the HTTP authorization header, and it's not included in the URL of the final request at all. This makes sense, because HTTP doesn't really have a concept of "URLs" per-say, the request itself has no "URL" field, it's got the path and headers basically.
For example:
(⎈|kind-kind:N/A) ~/p/w/hubble-timescape ❯❯❯ curl -v<EMAIL_ADDRESS>                                                                                ✘ 1 pr/chancez/disable_clickhouse_renovate ✭
*   Trying <IP_ADDRESS>:443...
* Connected to google.com (<IP_ADDRESS>) port 443 (#0)
* ALPN: offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
* (304) (IN), TLS handshake, Unknown (8):
* (304) (IN), TLS handshake, Certificate (11):
* (304) (IN), TLS handshake, CERT verify (15):
* (304) (IN), TLS handshake, Finished (20):
* (304) (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=*.google.com
*  start date: Sep 28 05:26:21 2023 GMT
*  expire date: Dec 21 05:26:20 2023 GMT
*  subjectAltName: host "google.com" matched cert's "google.com"
*  issuer: C=US; O=Google Trust Services LLC; CN=GTS CA 1C3
*  SSL certificate verify ok.
* using HTTP/2
* Server auth using Basic with user 'user'
* h2h3 [:method: GET]
* h2h3 [:path: /]
* h2h3 [:scheme: https]
* h2h3 [:authority: google.com]
* h2h3 [authorization: Basic dXNlcjpwYXNz]
* h2h3 [user-agent: curl/7.88.1]
* h2h3 [accept: */*]
* Using Stream ID: 1 (easy handle 0x14000a800)
> GET / HTTP/2
> Host: google.com
> authorization: Basic dXNlcjpwYXNz
> user-agent: curl/7.88.1
> accept: */*
>
< HTTP/2 301
< location: https://www.google.com/
< content-type: text/html; charset=UTF-8
< content-security-policy-report-only: object-src 'none';base-uri 'self';script-src 'nonce-n80-QrgylKHwgC_0lLuR-A' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp
< date: Wed, 25 Oct 2023 19:51:35 GMT
< expires: Fri, 24 Nov 2023 19:51:35 GMT
< cache-control: public, max-age=2592000
< server: gws
< content-length: 220
< x-xss-protection: 0
< x-frame-options: SAMEORIGIN
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
<
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<TITLE>301 Moved</TITLE>

301 Moved

The document has moved
here.

* Connection #0 to host google.com left intact

The user:pass has been converted into basic auth credentials passed into the authorization header.

Hi @chancez thank you for your comment and insight.
Indeed, I also saw the authorization header sent by curl but I believed that this was orthogonal to the "final" URL. Also, I thought this was curl-specific, that is, not all HTTP clients (e.g., wget, browsers) follow the same convention and interpret this syntactic sugar into an HTTP header. For example, I have seen browsers displaying pop-up windows that ask you to confirm log in with credentials, not sure what happens under the hood.
For the record, I found a pretty old RFC that describes the structure of a URL:
https://datatracker.ietf.org/doc/html/rfc1738#section-3.1
However, in various sources around the net I read that this structure is deprecated and, as you correctly pointed, using the authorization header is the way to do basic auth nowadays.
In any case, if the URL never includes the username and password, what's the point in having corresponding business logic in Cilium's HTTP parser? I am referring to https://github.com/cilium/cilium/blob/main/pkg/hubble/parser/seven/http.go#L35.
Again, feel free to elaborate on the above if I am missing something.

what's the point in having corresponding business logic in Cilium's HTTP parser?

I'd have to spend more time looking into it. It's changed a lot recently, but it's also just a layer of abstraction that isn't necessarily 1;1 with how you interact with a request normally, so the answer is "it's complicated". Feel free to dig into it more and investigate.


remove browserify-shim

codemirror is commonjs now.
manually tested with minified version.
annoying for development with linked packages

The Jest PR made this need a rebase I'm afraid

@orta good, it should! any time we merge something with a lockfile change this should happen. we should actually put this on hold, as I'm not 100% certain this won't be a breaking change. I'm looking towards react-apollo's rollup config as our potential endgame here.


'Authenticate with token credentials' sample does not run as written

Hi,
Just wanted to check on one example from the Authenticate with the Azure Management Libraries for Python doc. Running this sample generates the following error:
$ python adal_demo.py
Traceback (most recent call last):
  File "adal_demo.py", line 11, in <module>
    context = adal.AuthenticationContext(LOGIN_ENDPOINT+TENANT)
NameError: name 'LOGIN_ENDPOINT' is not defined

If LOGIN_ENDPOINT and TENANT are capitalized for emphasis, please feel free to resolve this issue.
Thanks

The page is now fixed, thank you for the feedback @c-n-d !


Fix: wrong match of tfs pull request number

The previous code matches any single char in [Merge pull request|Merged PR]

Nice find! 👍


Performance test ClamAV signature based file scanning

Summary
In order to help decide between synchronous and asynchronous file scanning on form submission, we need to understand how long it takes for ClamAV to scan a file.
Acceptance criteria

[x] Performance test script
[x] Data showing average scan time for the Scan Files /clamav file submission endpoint.

Performance test 1

Scan Files Lambda API
/clamav endpoint, 5 concurrent users (api/locustfile.py)
Increased lambda function memory for each test

Lambda functions only allow memory to be configured and allocates CPU in proportion to the function's memory.
Our baseline for testing was 1,536MB of function memory and then we increased memory to meet the different vCPU increase thresholds:

Data

Memory (MB)
Average scan time (seconds)

1,536
27.6

1,769
23.5

3,008
23.2

5,308
22.4

7,077
21.8

10,240
22.9

Graphs
1,536 MB

1,769 MB

3,008 MB

5,308 MB

7,077 MB

10,240 MB

Related to the above, @mohamed-cds tested an ECS task with the max memory of 4,096 vCPU and the average scan time was ~22 seconds as well.

Connection refused errors from the performance test have been fixed by cds-snc/scan-files#163.


Add imagemagick to README

Imagemagick is used to create image thumbnails,
but it is not listed in the related section in the Quickstart.

Coverage remained the same at 81.729% when pulling 947c83df945642446f599911ecb174f08e711f80 on thiagojobson:edit-readme into 8f1d484348bf1c887d68ddf5a4fded7faaaa3e5f on pygame:master.


SimpleConnection created

A new API, called SimpleConnection, created. Intended for when we need work with multiple connection types dynamically.

[x] SimpleConnection
[x] SimpleTransaction
[x] Update docs
[x] Update README.md

My initial idea was move our current Connection<c> and Transaction<c> types to an 'inner' struct, but this will demand lot of work and change the code a lot.
So, to simplify, I made two new types: SimpleConnection and SimpleTransaction. This two type encapsulate the original structs, but works like a optional approach. To use, you just need call .into() method.
This change will help me in the diesel PR.

Pull Request Test Coverage Report for Build 417458817

-65 of 183 (64.48%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-13.02%) to 67.7%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/connection/simple.rs
62
87
71.26%

src/transaction/simple.rs
54
94
57.45%

Totals

Change from base Build 400374359:
-13.02%

Covered Lines:
2425

Relevant Lines:
3582

💛  - Coveralls

Pull Request Test Coverage Report for Build 417458817

118 of 183 (64.48%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-13.02%) to 67.7%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/connection/simple.rs
62
87
71.26%

src/transaction/simple.rs
54
94
57.45%

Totals

Change from base Build 400374359:
-13.02%

Covered Lines:
2425

Relevant Lines:
3582

💛  - Coveralls

Pull Request Test Coverage Report for Build 417458817
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

118 of 183 (64.48%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 80.706%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/connection/simple.rs
62
87
71.26%

src/transaction/simple.rs
54
94
57.45%

Totals

Change from base Build 400374359:
-0.02%

Covered Lines:
2928

Relevant Lines:
3628

💛  - Coveralls


determine why lbry.exe is asking for firewall permissions (games related)

The Issue
Since the games commit, LBRY asks for firewall permissions on lbry.exe on first startup. I had it ask a 2nd time for me as well (once for private and other time for public network). The protocol is 6 TCP and 17 UDP.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Whoops, totally missed this! Yep, problem seems fixed!!


When there is an error in a template ironman won't tell where

How to replicate
Write a variable with escaped quotes and run the generator
Sample
{{.Values.api_name | default \"rest-express-mongo\"}}
Log without the detail of the file with the syntax error
There was an error failed to parse template template: ironman:3: unexpected "\\" in operand : template: ironman:3: unexpected "\\" in operand

Thank you @omarvides  the message for that error can be improved in this file, and line
https://github.com/ironman-project/ironman/blob/master/pkg/template/generator.go#L239
Currently, the message is handled with this error
if err != nil {
		return nil, errors.Wrapf(err, "failed to parse template %s ", err)
	}

It can be changed to something like :
if err != nil {
       return nil, errors.Wrapf(err, "failed to parse template %s %s ", templateResult.path, err)
}

The above message includes the file to be processed


Integration with gatsby-source-graphql

Hello,
When using the plugin gatsby-source-graphql and calling data from it, It seems that the gatsby-transfomer-cloudinary plugin don't recognize coming objects with the structure:
{
  ...,
  coverPhoto: {
      cloudinaryAssetData: true,
      cloudName: "my-amazing-blog",
      publicId: "blue-blue-blue",
      originalHeight: 360,
      originalWidth: 820
  }
}

to automatically fetch images from Cloudinary, and have a node of type CouldinaryAsset as described here.
The only thing that I can do as query is the following:
query Data {
  pos {
    products {
      coverPhoto {
        alt
        cloudName
        cloudinaryAssetData
        originalWidth
        originalHeight
        publicId
      }
    }
  }
}

Hi @hazzyeer, I'm a bit off on what you want to achieve :). Could you provide more context, probably with an ideal graphql query you're trying to make?


Bug: MQTT Won't Connect

Unfortunately, HASS.Agent has stopped connecting to MQTT.  I see other things connecting to MQTT but not the HASS. Agent.  Any ideas why and/or how to solve?

have the same problem


Add LGM-SOC'21 score card in readme.md

Add LGM-SOC'21 score card in readme.md

Add LGM-SOC'21 score card in readme.md

@kashish-ag pls assign me this issue.

Ishita can you please elaborate what will scorecard consist?

Ishita can you please elaborate what will scorecard consist?

@kashish-ag here is ss.

Sure add it :)


[DataTable] selectedRows as a prop

Hey Folks!
I'm working with DataTable and a list of row-Objects on which I need to apply a filter.
Here is an example:
var rowsList = this.props.store.Persons
    .filter(
        person => (person.name.toLowerCase().indexOf(this.state.filter.toLowerCase()) != -1 ));

<Textfield
    label="Filter"
    onChange={(event) => {this.setState({filter: event.target.value})}}
/>

<DataTable
    selectable
    rows={rowsList}
    rowKeyColumn="id"
    onSelectionChanged={(data) => console.log(data)}
> ... </DataTable>

When I apply a filter rowsList and rerender the Table-Component I loose my some IDs in the selectedRows-List. I need to persist these selections even if a filter is applied.
So I propose to enable selectedRows as a prop which is used to have rows selected "by default".
<DataTable
    selectable
    rows={rowsList}
    rowKeyColumn="id"
    onSelectionChanged={(data) => console.log(data)}
    selectedRows={[1,6,2,...]}
> ... </DataTable>

Or is there another way I can't see?
Greeting,
~dymat

Do you mean that if you select a row with the table unfiltered, then filter it in order to remove the selected row, and then change the filter again to see the row.. The row should still be selected?
If that's the case, maybe we could add a prop to check the value of something in the row instead of relying on an internal state.
So let's say you have your person with this:
{
  name: 'X',
  lastname: 'Y',
  selected: true
}

Then we could add a new prop on the table, something like selectedRowKey (or maybe rowKeySelected to match the other rowKeyColumn :D)

Wow! You are fast! Thanks for reply!
You got exactly my point. It would be great if you could add such a prop.
BTW: this new prop would be a good base for writing a pagination add on which keeps track of selected rows over all pages...
Thanks again!
Bye,
~dymat

For the pagination, it really depends on how it's built. I have a similar component at work and the selected elements are kept in memory, it doesn't care if there's an pagination or not ;)


Implement Apple Pay in Adyen payment gateway

I want to merge this change because... it adds Apple Pay implementation for Adyen payment gateway.

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://saleor-1514-adyen-apple-pay-for-web.api.saleor.rocks/graphql/

Task linked: SALEOR-1578 Sample integration for apple pay on the web


Support finalizer

Support finalizerContainer in TestJobPodSpec for termination of injected container.
Command of finalizerContainer executed after all container's command finished .
  mainStep:
    template:
      metadata:
        generateName: testjob-
      spec:
        containers:
          - name: test
            image: alpine
            workingDir: /work
            command:
              - ls
            args:
              - README.md
        finalizerContainer:
          name: finalizer
          image: alpine
          command:
            - echo
          args:
            - "finish"

Codecov Report

Merging #76 (da6861b) into master (58e6b83) will decrease coverage by 0.53%.
The diff coverage is 58.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   63.68%   63.16%   -0.53%
==========================================
  Files          15       15
  Lines        2820     2905      +85
==========================================
+ Hits         1796     1835      +39
- Misses        751      783      +32
- Partials      273      287      +14


reserved words in upper case in fields can't be used

type test struct {     Type string }
will be converted in something like this:
Type -> type
func (qs testQuerySet) TypeEq(type string) testQuerySet {
and this code cannot be compiled

Thank you for report, issue is fixed


calculating pmi dictionary

@pavelsof I saw that you used CogDetect library for extracting the code. I suggest to not use that library since due to reasons beyond my control the library no longer reflects the right way to train the online PMI model.
Please use the https://github.com/PhyloStar/OnlinePMI repo which is the right model and code.
I will add your NW code to the OnlinePMI repo and add you to the repo as colloborator.

Thank you, I will start replacing the code in this repo.

This should be now fixed with c55d5b6f38866cc6b2c0108ab834748c6e022cb2 and 4b74e7103d097e95563b0b78ddb41bc239ef9599 :)


Error rendering chart

Deploying using serverless and nodejs10.x and getting this in the lambda logs:
2019-08-31T12:56:28.141Z cd3c3e52-1260-4878-82bd-18b7b66dfeb7 INFO Error rendering chart: { InvalidParameterValue: The parameter Statistics.member.1 must be a value in the set [ Minimum, Maximum, Average, SampleCount, Sum ]. at Request.extractError (/var/runtime/node_modules/aws-sdk/lib/protocol/query.js:50:29) at Request.callListeners (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:106:20) at Request.emit (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:78:10) at Request.emit (/var/runtime/node_modules/aws-sdk/lib/request.js:683:14) at Request.transition (/var/runtime/node_modules/aws-sdk/lib/request.js:22:10) at AcceptorStateMachine.runTo (/var/runtime/node_modules/aws-sdk/lib/state_machine.js:14:12) at /var/runtime/node_modules/aws-sdk/lib/state_machine.js:26:10 at Request.<anonymous> (/var/runtime/node_modules/aws-sdk/lib/request.js:38:9) at Request.<anonymous> (/var/runtime/node_modules/aws-sdk/lib/request.js:685:12) at Request.callListeners (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:116:18) message: 'The parameter Statistics.member.1 must be a value in the set [ Minimum, Maximum, Average, SampleCount, Sum ].', code: 'InvalidParameterValue', time: 2019-08-31T12:56:28.125Z, requestId: 'c7c77eed-a0bc-4714-b2b5-c651316e7e8e', statusCode: 400, retryable: false, retryDelay: 19.789864084998786 }
Any idea what the problem is?

Looking at the charts.js code and it looks like SampleCount is not supported :(

Event is parsed: https://github.com/arabold/aws-to-slack/blob/master/src/parsers/cloudwatch/index.js#L88
Query is formatted for API: https://github.com/arabold/aws-to-slack/blob/master/src/parsers/cloudwatch/chart.js#L540
And is sent to API: https://github.com/arabold/aws-to-slack/blob/master/src/parsers/cloudwatch/chart.js#L199
SampleCount should work if we just fix the capitalization.
https://github.com/arabold/aws-to-slack/commit/e45be0f465ae6b335f3f5138b16522e8cac68c21


unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps

What happened:  When I install clusternet, I get the following error (https://clusternet.io/docs/quick-start/)
What you expected to happen:
root@localhost:/src/github.com/clusternet/clusternet/hack# ./local-running.sh
Deleting cluster "parent" ...
Deleted nodes: ["parent-control-plane"]
Creating cluster "parent" ...
✓ Ensuring node image (kindest/node:v1.22.0) 🖼
✓ Preparing nodes 📦
✓ Writing configuration 📜
✓ Starting control-plane 🕹
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
Set kubectl context to "kind-parent"
You can now use your cluster with:
kubectl cluster-info --context kind-parent --kubeconfig /root/.kube/clusternet/parent.config
Have a question, bug, or feature request? Let us know! https://kind.sigs.k8s.io/#community 🙂
Context "kind-parent" renamed to "parent".
Cluster "kind-parent" set.
Cluster parent has been initialized
Deleting cluster "child1" ...
Deleted nodes: ["child1-control-plane"]
Creating cluster "child1" ...
✓ Ensuring node image (kindest/node:v1.22.0) 🖼
✓ Preparing nodes 📦
✓ Writing configuration 📜
⢎⡰ Starting control-plane 🕹
⠎⠁ Starting control-plane 🕹
✓ Starting control-plane 🕹
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
Set kubectl context to "kind-child1"
You can now use your cluster with:
kubectl cluster-info --context kind-child1 --kubeconfig /root/.kube/clusternet/child1.config
Not sure what to do next? 😅  Check out https://kind.sigs.k8s.io/docs/user/quick-start/
Context "kind-child1" renamed to "child1".
Cluster "kind-child1" set.
Cluster child1 has been initialized
Deleting cluster "child2" ...
Deleted nodes: ["child2-control-plane"]
Creating cluster "child2" ...
✓ Ensuring node image (kindest/node:v1.22.0) 🖼
✓ Preparing nodes 📦
✓ Writing configuration 📜
⢎⡠ Starting control-plane 🕹
✓ Starting control-plane 🕹
⢀⡱ Installing CNI 🔌
⢄⡱ Installing CNI 🔌
⢆⡱ Installing CNI 🔌
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
Set kubectl context to "kind-child2"
You can now use your cluster with:
kubectl cluster-info --context kind-child2 --kubeconfig /root/.kube/clusternet/child2.config
Not sure what to do next? 😅  Check out https://kind.sigs.k8s.io/docs/user/quick-start/
Context "kind-child2" renamed to "child2".
Cluster "kind-child2" set.
Cluster child2 has been initialized
Deleting cluster "child3" ...
Deleted nodes: ["child3-control-plane"]
Creating cluster "child3" ...
✓ Ensuring node image (kindest/node:v1.22.0) 🖼
✓ Preparing nodes 📦
✓ Writing configuration 📜
✓ Starting control-plane 🕹
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
Set kubectl context to "kind-child3"
You can now use your cluster with:
kubectl cluster-info --context kind-child3 --kubeconfig /root/.kube/clusternet/child3.config
Not sure what to do next? 😅  Check out https://kind.sigs.k8s.io/docs/user/quick-start/
Context "kind-child3" renamed to "child3".
Cluster "kind-child3" set.
Cluster child3 has been initialized
Connecting cluster networks...
Connecting cluster parent to /root/.kube/clusternet/child1.config
Connecting cluster parent to /root/.kube/clusternet/child2.config
Connecting cluster parent to /root/.kube/clusternet/child3.config
Cluster networks connected
Updating helm repo...
"clusternet" already exists with the same configuration, skipping
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "clusternet" chart repository
Update Complete. ⎈Happy Helming!⎈
Updating helm finished
Installing clusternet-hub...
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /root/.kube/clusternet.config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /root/.kube/clusternet.config
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(CustomResourceDefinition.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.clusterInitBaseName): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps, ValidationError(CustomResourceDefinition.spec.versions[0].schema.openAPIV3Schema.properties.spec): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps]
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Clusternet version:

Clusternet-agent version (user clusternet-agent --version=json):
Clusternet-hub version (user clusternet-hub --version=json):

Kubernetes version (use kubectl version): v1.31.0
Cloud provider or hardware configuration:  2C4G40G
OS (e.g: cat /etc/os-release): Ubuntu 22.04.4 LTS
Kernel (e.g. uname -a): 5.15.0-117-generic
Goland: go1.23.1
Helm: v3.15.4

[ValidationError(CustomResourceDefinition.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.clusterInitBaseName): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps, ValidationError(CustomResourceDefinition.spec.versions[0].schema.openAPIV3Schema.properties.spec): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps]

@zhaodaiyang0574 Thanks for pointing out. CRD ManagedCluster uses a new feature that is only supported since Kubernetes v1.25.
I've filed a PR #823 to fix this. Please have a try.


[NCL-7042] Fix sort issue and add labels for deliverable analysis

Will have a new PR to remove the duplicated commits

Created https://github.com/project-ncl/pnc-web-ui-angularjs/pull/70 for this jira


[Question]: start infinity failed

Describe your problem
Following the instructions "Switch doc engine from Elasticsearch to Infinity", error reported: service "ragflow" depends on undefined service "es01": invalid compose project.
Using docker-compose-CN-oc9.yml

I've updated the oc9 docker compose file #3913, it stills reports such errors:
[WARNING] [2024-12-09 09:19:58,727] [_node_pool.mark_dead] [line:249]: Node <Urllib3HttpNode(http://es01:9200)> has failed for 7 times in a row, putting on 30 second timeout
[WARNING] [2024-12-09 09:19:58,727] [_transport.perform_request] [line:395]: Retrying request after failure (attempt 2 of 3)
Traceback (most recent call last):
File "/root/miniconda3/envs/py11/lib/python3.11/site-packages/elastic_transport/_transport.py", line 328, in perform_request
meta, raw_data = node.perform_request(
^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/py11/lib/python3.11/site-packages/elastic_transport/_node/_http_urllib3.py", line 202, in perform_request
raise err from None
elastic_transport.ConnectionError: Connection error caused by: NameResolutionError(<urllib3.connection.HTTPConnection object at 0x7fa129caf550>: Failed to resolve 'es01' ([Errno -2] Name or service not known))
[WARNING] [2024-12-09 09:19:58,758] [_node_pool.mark_dead] [line:249]: Node <Urllib3HttpNode(http://es01:9200)> has failed for 8 times in a row, putting on 30 second timeout
Traceback (most recent call last):
File "/ragflow/rag/svr/task_broker.py", line 21, in
from api.db.db_models import Task
File "/ragflow/api/db/db_models.py", line 33, in
from api.settings import DATABASE, stat_logger, SECRET_KEY
File "/ragflow/api/settings.py", line 35, in
from rag.utils import ELASTICSEARCH
File "/ragflow/rag/utils/init.py", line 19, in
from .es_conn import ELASTICSEARCH
File "/ragflow/rag/utils/es_conn.py", line 457, in
ELASTICSEARCH = HuEs()
^^^^^^
File "/ragflow/rag/utils/init.py", line 12, in _singleton
instances[key] = cls(*args, **kw)
^^^^^^^^^^^^^^^^
File "/ragflow/rag/utils/es_conn.py", line 24, in init
raise Exception("Can't connect to ES cluster")
Exception: Can't connect to ES cluster

The problem is solved by using the latest ragflow image: swr.cn-north-4.myhuaweicloud.com/infiniflow/ragflow:dev rather than edwardelric233/ragflow:oc9


Provide better throwing errors for planetary phenomena

They are all hidden in C++ code.

Cleaning up obsolete issues in 2023.


Recovery

This adds a Blender.recover() method that goes through and replays the log entries it finds for its base nodes.

The log flushes are now separated by a newline, so that each JSON array can be parsed individually.
persistence::Parameters now has an optional log_prefix that'll be used to replace soup in e.g. soup-log_0_0-0.json. Without this parallel tests would sometimes log to the same file - at the same time.
Packets are re-created from the log entries and passed on to Domain.handle. Transactional packets are first passed through checktable.apply_batch to retrieve a timestamp. I'm not sure if the latter is completely correct though - cc @fintelia.

I've added a couple of tests, but let me know if there's anything else I should cover.
I also changed the basic example so that it calls .recover() and votes with a unique timestamp (so that the count increments each time it's run). Let me know if I should move it to another example or something though.

Regarding GroupCommitQueueSet: I'm not really using any of the merge methods there, I just put the retrieval method on it as they shared a few of the struct's fields - I'll pull it out into a standalone function since they're not really related, as you're saying.

@ekmartin There was just a rather large refactor that landed on master. Could you try to rebase/merge the changes into your branch? A lot of things moved around so let me know if you need a hand finding something. Notable moves:
src/flow/domain/mod.rs -> dataflow/src/domain/mod.rs
src/flow/persistence/mod.rs -> dataflow/src/persistence/mod.rs
src/checktable -> dataflow/src/checktable
src/flow/payload.rs -> dataflow/src/payload.rs
tests/lib.rs -> src/tests.rs

@fintelia: I rebased and added a .recover() RPC command to Blender. Went over the tests quickly and updated them so that they pass again, but I can take a more thorough look at it tomorrow if there's anything else that should change with the refactor.

Looks good! A few questions to check that I got the right understanding:

This currently assumes that the log files for all nodes in a domain exist locally wherever that domain executes (seems reasonable).

While handling a recovery message, a domain does not process normal writes. However, if writes arrived to the domain before the StartRecovery control packet arrived, there might be some writes stored already -- for a transactional base, we'd crash (because the check table isn't empty), while for a non-transactional one, everything should work out fine post-recovery since the new writes commute with the recovered ones.

Some funky subtleties might exist if the write that raced ahead of the recovery is a deletion for something that exists in the to-be-recovered state. In practice, this can't happen currently, because a restart/recovery invalidates client mutators and getters (thus no deletions can be in flight), and because a post-restart deletion racing ahead of the recovery would fail on an empty post-restart base node.

@ms705: That sounds about right! I left a comment regarding 1 here.

While handling a recovery message, a domain does not process normal writes. However, if writes arrived to the domain before the StartRecovery control packet arrived, there might be some writes stored already.

Yep, that's how I understand it as well. Since handle_recovery runs from start to finish synchronously, that should block the polling loop in Domain.run() and ensure that no other packets get processed.
Making sure that no other packets can arrive before recovery starts altogether sounds like a good future improvement, perhaps by moving from an explicit .recover() call to a parameter on the controller?

@ekmartin I think we're happy to merge this now :+1: I'll fix the new conflicts later tonight (and merge) unless you get there first.

@ms705: rebased 👍

The recovery tests started failing randomly at this assertion after rebasing (repeated the tests successfully 100 times pre-rebase to compare) - I'll investigate.

Merging #43 should have fixed the failures that you saw.
Once we've sorted out the log file deletion issue to our satisfactions, I think we should merge this.

@ms705 and @jonhoo: I added a commit that implements the log file clean-up in tests using Drop instead. This should mimic the behavior of calling delete_log_files manually, but should ensure that it happens in the case of assertion failures and so on as well.

:+1: @jonhoo?

See inline comments. Overall looks good though!

I think we're ready to merge this, so I will unless I hear any objections :-)

My only hesitation is https://github.com/mit-pdos/distributary/pull/37#discussion_r150422839

That sounds like a broader limitation of the transactional logic, though, so not something we would want to fix within the scope of this PR. I agree that it would be nice to recover at a single timestamp or a single timestamp per base, but I suspect that doing so would involve some invasive changes unrelated to the basic recovery implemented here. Let's merge this first, and then improve it.

@ms705 It is not clear to me that we'd even want recovery to use only a single timestamp. Recall that our buffering logic means that that there can be no pipeline parallelism in the processing of messages for a single timestamp

@fintelia Good point! This would also cause the timestamp-per-base scheme to buffer all writes from a single base until another base (with a "prior" timestamp) has finished recovering, which would in effect serialize the recovery at joins.


Initial commit to explain how to handle PDF date

Initial commit on blog for handling PDF files. Please check and let me know your comments
Remaining:

Example with: pdfminer
Example with: Apache Tika
Conclusion
Maybe more examples with texthero

Resolves #24

Thank you Selim! This is a very good start, keep going! ;)


filtration NOT complete(can not filter ALB)? use case:ELB - Delete Unused Elastic Load Balancers

the policy created as doc shown(ELB - Delete Unused Elastic Load Balancers), and i did one test, one ALB(one type of ELB) created, which also no instances attached. And one classic LB created with no instances attached. then after running the command, only one instance tagged, it seems that ALB can not be filtered.

@youzhoutai ALB = resource type app-elb


semgrep: Detect some unsafe uses of markupsafe.Markup

Use the built-in HTML escaping of Markup("…{var}…").format(), in order to allow Semgrep to detect mistakes like Markup("…{var}…".format()) and Markup(f"…{var}…").

Thanks for working on this! I posted a couple questions on changes I couldn't easily verify, but otherwise lgtm.

Merged, thanks @andersk!


Tob top background color title

Hi, when i crate a tab tha contains more then one shelcontent in flayout. The background and title color of bar could not be set. Could you add theese things.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9d653fd-51ed-ed03-db65-a9efb684dc12
Version Independent ID: 06470094-10f9-b28e-4ece-4da457a4a609
Content: Xamarin.Forms Shell Page Configuration - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/shell/configuration.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @anilsnl
If I understand you correctly, you're suggesting there's a bug. If that's the case, you need to submit a repro project to the engineering repo.


Docker container size

Good day.
I installed a Nyan-bot, after some time the docker container grew to a size of about 50 gigs (this is also written in the requirements) and will probably continue to grow.
Is it possible to somehow limit the disk used?
Maybe there is some option in the configs, or something similar?
I also considered the option of stopping the Nyan-bot, deleting the docker container and starting the bot again.
How will this option affect the bot's performance?
Is it like a reset to the initial state?
What do you say, what advice do you give?

Hello.
I am also a user of this script.
For nearly a month of work, database size has grown only to 1.7GB:
# du -hs nyan/mongo/
1.7G	nyan/mongo/

What is the size of your database and for how many months have it been running?
As of archiving the data, I have also asked about this in the neighbour opened issue and as the author have mentioned, you can use archive.sh for this.

It was about 40 GB
Less than a month

Привет. Я тоже являюсь пользователем этого скрипта. За почти месяц работы размер базы вырос всего до 1,7Гб:
# du -hs nyan/mongo/
1.7G	nyan/mongo/

Каков размер вашей базы данных и сколько месяцев она работает?
Что касается архивирования данных, я также спрашивал об этом в соседнем открытом выпуске , и, как упомянул автор , для этого вы можете использовать archive.sh .

It was about 40 GB
Less than a month

I suggest you to use du command to examine which directory exactly occupies most of the space. Maybe it's some error logs and not the actual database.

I was talking about the docker container, not the database :)

By following the official installation guide, mongo database is being running under a docker container and no other parts of the script.

In my case the contained has grown to occupy all of the available space because of the log file:
/var/lib/docker/containers/CONTAINER_ID/CONTAINER_ID-json.log
I have found here various solutions: https://stackoverflow.com/questions/31829587/docker-container-logs-taking-all-my-disk-space


[VT]: Fix accessing a u24 as a u32 when parsing VT NACK

When we were getting NACKs it was causing a crash due to accessing index 8 after converting to the named read functions.

@GwnDaan Do you think we need get_uint24_at? Or is that too weird?

@ad3154 I think I've seen the u24 in a few more places throughout the standards, so I guess we could implement it as a function? Though they are definitely not as common as the others, idk.

@ad3154 I think I've seen the u24 in a few more places throughout the standards, so I guess we could implement it as a function? Though they are definitely not as common as the others, idk.

I suppose we may as well add it... I will convert my PR to that instead


Changed return of fortimanager status to value

This change puts fortimanager status in line with bgp neighbour info, ipsec tunnel status,...

As per https://github.com/bluecmd/fortigate_exporter/blob/master/CONTRIBUTING.md#naming-convention we should never break the API guarantee between the users by removing a label except if we ever do a 2.0 version. Sorry.

Hi @bluecmd how can we go ahead and set the target branch to a breaking change / future branch? As I feel that lowering the label cardinality is in favor of all users.
The way the fortimanager one is written is not how you would normally return a value and causes annoyances during dashboarding and alertmanager queries.
There is not one query returning the current status (which can be shown on a graph: fortigate_fortimanager_registration_status)

I disagree that this type of cardinality increase is a problem (you're replacing one timeseries with X amounts (X being bounded and small), but each have 1/X activity so encoding wise they are much cheaper than the original one by themselves) - but it has been ages since I checked in with the Prometheus devs on this so I cannot claim to be knowledgeable on Prometheus internals anymore. If you feel strongly about this, I would encourage you to raise the topic on the Prometheus mailing list to solicit firm evidence that this way it is done today is not a good way to do metrics.
W.r.t. to not one query to return the status. Why wouldn't sum(fortigate_fortimanager_registration_status) by (instance, status) != 0 work for you? That's generally how I display current enum status on e.g. Grafana.

Hi, except for the following I am currently not able to provide more documentation on this: https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels & https://prometheus.io/docs/instrumenting/writing_exporters/#labels
It is not about being overused but just more optimised.


[Suggestion] Wrapper for effects and unprintable characters

Hello.
I created a Pull request a few minutes ago adding a "wrapper" feature.
I'm working on an Open Source tool to setting the PS1 in your terminal, using node. But for that, I needed all the colours and effects to be wrapped into \[ and \].
I figured this could be an interesting addition for the chalk project as it can be used to "tokenise" the  styles, to identify and debug them, or help you out on different TTYs.
I hope this can be considered :)

Hey - not really interested to be quite honest. Just do a search for \x1b and replace it with a character of your choosing (or remove it entirely) in the output.
For example,
$ FORCE_COLOR=1 node your/chalk/app.js | tr -d "$(printf '\x1b')"

For anyone else stumbling upon this, you can use @felipenmoura's fork of chalk like this:
const Chalk = require('@nasc/chalk');

const chalk = new Chalk.constructor({
  wrapper: {
    pre: '\1',
    post: '\2',
  }
});

Then use as normal. The escape codes are explained here.

No, by you piping things, you're telling Chalk to disable itself. Did you try FORCE_COLOR=1?

I sure did. It was coming out colored, but some of the control characters were appearing in the output. Even without the pipe, I needed FORCE_COLOR=1.

That means your terminal emulator doesn't support them and is improperly reporting its TERM variable. Which one are you using?


/graph fix lin errors/warnings

Addresses #14756
Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>

Ping @stevvooe!

Comments are there to help people understand the behavior of a function. This PR just re-states the type signature and seems to be just a find/replace to make lint pass. This is really not in the spirit of effort.
The graph package is subtle and full of archaeology that should be reflected in the godoc. It is going to take time to get proper doc comments in.

@stevvooe I have tried my best to address your concerns. Please review and let me know. I have not tried to just get the lint pass but when adding comments to the code the context that I have is very limited. We do the best we can and then we need expertise to fix godocs and some point in time, either we do it as part of this effort or run the godocs with doc experts afterwards.

@brahmaroutu I am not really talking about documentation expertise. We need the expertise of those who have a deep understanding of this code base. Right now, these comments aren't providing any value other than to pass golint. Most additions are still tautological.
This isn't background that either you or I possess. It will take some time, study and consideration to get this right, in the absence of tracking down the original authors of this code. It is better to be failing the linter than to have useless method commentary.

@vdemeester I have addressed your comments accordingly. Please review.

@brahmaroutu Could you add package graph to hack/make/validate-lint :blush: (may need a rebase thoguh).

LGTM
@aaronlehmann PTAL

LGTM

LGTM

@icecrime @jfrazelle Would like to merge but the CI system seems to be failing on something unrelated. Any thoughts?

@stevvooe For these golint PRs, I just merge nevertheless, after testing locally.

LGTM

@tiborvass There are a few symbol changes that need to be checked on build.

@stevvooe what do you mean?

@tiborvass graph.DEFAULTTAG -> graph.DefaultTag should be checked by CI.

@stevvooe I checked locally because CI was down


Existing Chats Do Not Work [0.3.9]

Bug Report
Description
Bug Summary:
A chat created in 0.3.8 (or before, presumably) no longer seems to send user input to the server in 0.3.9. Newly created multi-model chats seem to work fine. In the broken chats, you can enter input and hit enter or click send, but no connection is made to the API.
Steps to Reproduce:

Install 0.3.8.
Create chat and chat with the models.
Upgrade to 0.3.9
Attempt to chat in that same chat.

Expected Behavior:
All models reply.
Actual Behavior:
No API requests are sent to the server, and thus no models reply.
Environment

Open WebUI Version: 0.3.9

Ollama (if applicable): 0.2.5

Operating System: Gentoo Linux

Browser (if applicable): Firefox 128

Reproduction Details
Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[X] I have included the browser console logs.
[X] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
Probably the reason for this. This is a client-side error from the console.
Uncaught (in promise) TypeError: De.push is not a function
    _t Chat.svelte:522
    vt MessageInput.svelte:624

Installation Method
Docker.
Additional Information
Also notice that the title is not being generated in new multi-model chats. Not sure if related.
I originally reported this for multi-model chats, but it actually happens for all chats...

Happens in both Firefox and Chromium.

Fixed with the latest!

So I'm not sure this is fully fixed. Messages can be sent, yes, but it seems like the existing context isn't being sent along with the new request.


Show the "brand" tag by default on gas stations and car dealerships

I see a lot of gas stations with the brand added to the "operator" label instead of the "brand" label.  I believe this happens because the the former is shown by default, and the later is not.  The same happens on car dealerships and possibly other amenity types.

See #2300.

I added a comment there, thanks.


When will the code for training MSCOCO and pre-trained model published?

If anyone is still curious.. I've pushed a TF implementation on COCO a while ago here.


Code Analysis errors

Below is a list of Code Analysis errors in a Pastebin, we should go through case by case and suppress them or fix them
http://pastebin.com/JY9nmGiB

Also I've seen some parameters with capitalization and such, shall I just fix those as I come across them?

Sure.


Updates Mist to 0.9.2

After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Additionally, if updating only the sha256:

[ ] I verified this change is legitimate How do I do that? and am providing confirmation below:

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

I am one of the maintainers of Mist. I'll come back to make sure all checkboxes are ticked. But checksum and checkpoint are good 👍
https://github.com/ethereum/mist/releases/tag/v0.9.2


Fuel records not acting correctly

Checklist
Please make sure you have performed the following steps before opening a new bug ticket, change [ ] to [x] to mark it as done

[x] I have read and tried the steps outlined in the Troubleshooting Guide
[x] I have searched through existing issues.

Description
Fuel records behave strange. Im writing in 20 liters or 20.0 in this case and it acts as if i wrote 20000
Platform

[x] Docker Image

Browser Console Errors(F12)
No errors
App/Container Console Error
No errors
Screenshots(optional)

Not a big, you’re using a locale which has “,” as the decimal separator, the fuel tab uses 3 decimal places so 20,0 is rendered as 20,000
in US locale this will be 20.0 and 20.000

Not a bug, you’re using a locale which has “,” as the decimal separator, the fuel tab uses 3 decimal places so 20,0 is rendered as 20,000
this is user configurable in the settings tab.
in US locale this will be 20.0 and 20.000

Hi,
first of all thanks for the app - I just recently set it up and I'm quite liking it!
TL;DR is that I want to display the number of litres as 34,92 and not 34,920 or 3492,000.
A bit more content: My LubeLogger has the "Use Imperial Calculation" as well as the "Use UK MPG Calculation" settings both turned off. The "Use three decimals for fuel cost" option is also deactivated. The problem is that my fuel consumption is still shown with three post-comma digits.
So for instance, in an entry in the "Fuel" tab of a vehicle, where I added 34,92 litres of fuel to a vehicle, under "Consumption" it shows as 34,920. If I enter 34.92 instead of 34,92, the 34,920 changes to 3492,000. But I don't want to show this with three digits, especially since the third digit will always be 0 anyways as no gas station around me counts three digits after the comma.
Which setting do I need to change to correctly display the number of litres with only two digits after the comma?
Here's a visual representation of my settings:

And this is what the field in question currently looks like:

@kalipso-cyber out of scope for the issue you're commenting on, make a new one.


escape left angle brackets

Escape left angle brackets to use them as literal characters.

@Derek1101,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@Derek1101 : Thanks for your contribution to the Azure documentation! The author, @ganesr, has been notified to review your proposed change.

#sign-off


Adds formatting to strip default UNC verbatim paths on Windows machines.

This should clean up output on Windows machines to remove default UNC verbatim path (\\?) on Windows machines. The UNC path will still be present if a rust override is set up a remote share since util::format_path_for_display only checks for the \\?\ literal.

Thanks!


[🐛]  launchImageLibrary Options do not change the Video size

Description
Uploading very large video files can cause the async launchImageLibrary call to take an extraordinary long time (up to 12min for a 3gb file)
I applied the optional params as an attempt to reduce the size of the video file; however, this did not work. I then started running my own tests using the same 30s video with different options being used, and I noticed that the file size never changed.
How to repeat issue and example
Use the launchImageLibrary function to select a video from your gallery and console log the resulting file size:
const result = await launchImageLibrary(options?);
const { fileSize } = result.assets[0];
console.log(fileSize); // All file sizes are the same

FILE SIZE: 57,187,279

FILE SIZE: 57,187,279

FILE SIZE: 57,187,279
Additional Information

Image Picker version: 5.3.1
React Native version: 0.71.7
Platform: iOS
Development Operating System: MacOS, M1 chip
Dev tools: VS Code, Expo-ejected React Native Bare Workflow, iOS Physical Device

same issue i can't limit duration of video


Fixes #3403 - Added check for escaped single quote in string

#3403
> create database test;
> use test
Using database test
> insert test value="foo'bar"
> select * from test
name: test
----------
time				value
2015-07-21T00:15:43.034952116Z	foo'bar

> select * from test where value = 'foo''bar'
ERR: error parsing query: found bar, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 38
> select * from test where value = 'foo\'bar'
name: test
----------
time				value
2015-07-21T00:15:43.034952116Z	foo'bar

> select * from test where value = 'foo'bar'
ERR: error parsing query: found bar, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 39
>

@dgnorton @benbjohnson

+1, seems sensible to me.
Thanks @jhorwit2

Can you also update the 0.9.3 CHANGELOG and give yourself credit?

Yup. I'll do that now.

Whoops. let me fix that contribute message. added query twice

:+1:

This should be under bug fix right?

Yeah, bug fix makes sense to me.

@otoolep anyone idea when this will be merged? Keeping conflicts with contribute file up to date is tedious haha.

+1 Thanks @jhorwit2!


Update 2024-08-29-newcomers-meeting.md

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 2c3483d9566b6eec255059e9332ee7b858ccd1e3 at: https://66d077a307a0750a22c7fe71--meshery-docs-preview.netlify.app


Allow overriding of alert levels for sources

Each source has certain levels, and the tools notifies users when levels change. For air quality in particular, it would be good to customize the levels to avoid unnecessary alerts.

Perhaps something like this in the config:
baaqmd:
  alert_levels:
    0: "Good",
    51: "Moderate",
    101: "Unhealthy for sensitive groups",
    151: "Unhealthy",
    201: "Very unhealthy",
    301: "Hazardous",

Air quality support as been implemented. Still need water levels.


New release?

Any chance a new release could be pushed to NPM which contains the issue fixed in #5?
https://www.npmjs.com/package/chartist-plugin-accessibility

Also need this release. Not sure how to get around it

Almost 1 year later, version 0.0.5 has been released today. Sorry for this delay.


MINOR: Make private class FetchManagerMetrics as a static private class with

reduced visibility for members in Fetcher.
Use Collections.singletonList instead of Arrays.asList in the Unit Test

Test failure seems unrelated to the change.

@rajatvig Would you like to continue working on this PR and rebasing? If yes I would love to review it (you can assign myself to the reviewers list on the top right).

This seems not required any more.

reduced visibility for members in Fetcher.
Use Collections.singletonList instead of Arrays.asList in the Unit Test


Add host UI issues

Rancher versions: cloud
Issues:

[x]  State is not aligned properly in Host list page (same thing is happening in all pages with State)

[x] Hovering over Start from scratch makes it jump up a pixel

[x] Seems like there is an extra line in the Add Host template boxes

[x] In Add Host from template the info of the host that is on right seems to be too high up.  And there is too much white space at top.

[x] Container states info is not centered like it is in Containers page

Version - Wagyu (master 7/25)
Verified fixed


Update readme to reflect new channel name

I noticed the channel name needed to be updated.

It looks like this got changed in a different PR. Thanks for trying to keep us moving!