Feature Request

Missing functionality
In the old Pandas_profiling, when I would pass in a column of cities it wouldn't parse them into their individual words, it would leave them as cities, for example San Francisco was parsed into two words and isn't rendering in the distinct count as 'San Francisco' but 'San' and 'Frisco' which is messing with my data exploration. I just switched over to ydata-profiling as my pandas-profiling is now broken, but I would love to see this feature, or an argument back in ydata-profiling.
Proposed feature
an argument to pass in a list of categorical columns to NOT parse into individual words but leave as a whole string
Alternatives considered
No response
Additional context
No response

Hi @cmbfuqua ,
which version of pandas-profiling were you using? We haven't deprecated any functionalities from pandas-profiling, everything that was available since pandas-profiling v3.0.0 is available in ydata-profiling.
Deprecations were only made between v1.0.0 and v2.0.0, and v2.0.0 and v3.0.0 which quite old - before 2021.


Line detection using hough transform in matlab

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #5779

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Hello @hectorkambow and @ahmadmardeni1, I would like to review this PR.

Go ahead. @carteblanchemunene

Plagiarism check is done.

@carteblanchemunene
The plagiarism check is done. You may proceed with your preliminary round of review.

@carteblanchemunene changes made.

Hello @atienodorine3 ,
Do we have any updates on the revisions suggested by @carteblanchemunene ?
@carteblanchemunene After the author making suggested changes, if you find any more revisions to be made, do not hesitate to close the PR and ask the author to make ready to be published PRs.
Closing PRs helps clearing the backlog allowing the peer-reviewers and CMs to provide faster reviews for publishing them.
Let me know if you need any help.
Thanks.

hello @srishilesh please add the tech review symbol. Thanks

Hello @srishilesh, the article is ready for a final review. Kindly add the symbols for me.
cc. @ahmadmardeni1 and @hectorkambow

@section-engineering-education/content-moderator-team this one is a test reviewer
Lets try and finish this PR up - and get it out the queue.
🚀
Thank you

Please upload a different author picture. @atienodorine3

@ahmadmardeni1 I have uploaded a new author image.

Great work. @atienodorine3 @carteblanchemunene


Disable "Predictable Network Interface Names"

In a hilarious bit of irony, we need to disable this "feature" so that our network names are predictably "ethX" (but only actually totally necessary for newer builds of udev -- ie, post-jessie).

cc @ehazlett :smile:

(Discovered this bug that will bite us later while I was playing with building ISOs based on Sid instead of Jessie.)

lol cool.
LGTM


Table naming problem

I have two models deriving from one base class.
EF7 now is struggling as it wants to name them both after the base classes name.
EF7 should take the name from the actual model class name.

EF Core (formerly known as EF7) still doesn't support mapping an inheritance hierarchy to multiple tables. Is that what you are trying to accomplish?

Yes, that might be exactly the thing.

I want all my models (and so tables) to have certain properties for a minimum, so I of course created a base class and derived from that...
And now the framework goes nuts because it sees multiple instances of the same name.

Currently only mapping the multiple types of the inheritance hierarchy to the same table is supported. The other alternative is to call Ignore<MyBaseType>() on the model builder so that you can still use a base class (or interfaces) to share common properties across your types but have EF Core reason about them as completely separate types.
Table-per-hierarchy inheritance  support was added in recent milestones. You could be hitting a bug in which case a code listing and more detail about the symptoms and expected behavior could help a lot.

In my DbContext class:
`
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
modelBuilder.Ignore();
  modelBuilder.Entity<Entity>()
    .HasKey(e => e.ID)
    .HasName("ID");

  modelBuilder.Entity<Entity>()
    .Property(e => e.Created)
    .ValueGeneratedOnAdd();

  modelBuilder.Entity<Entity>()
    .Property(e => e.Updated)
    .ValueGeneratedOnAddOrUpdate();
}

`
Class Entity:
  public class Entity   {     public int ID { get; set; }     public DateTime Created { get; set; }     public DateTime Updated { get; set; }   }
Derived Models (to become tables):
`
public class BlogEntry : Entity
{
[Required]
[MinLength(4)]
[Column(TypeName = "varchar(20)")]
public string Headline { get; set; }
[Required]
[MinLength(4)]
[Column(TypeName = "varchar(max)")]
public string Text { get; set; }

}
`
And:
`
public class NewsArticle : Entity
{
[Column(TypeName = "varchar(20)")]
public string Headline { get; set; }
[Column(TypeName = "varchar(2000)")]
public string Content { get; set; }

}
`
This is just a simple example project without sense.
When I do
dnx EntityFramework.Commands migrations add MyFirstMigration
I get:
 System.ArgumentException: An item with the same key has already been added.   at System.ThrowHelper.ThrowArgumentException (ExceptionResource resource) <0x7f0010cb6ec0 + 0x00021> in <filename unknown>:0    at System.Collections.Generic.Dictionary2[TKey,TValue].Insert (System.Collections.Generic.TKey key, System.Collections.Generic.TValue value, Boolean add) <0x7f0010b3e700 + 0x00168> in :0
at System.Collections.Generic.Dictionary2[TKey,TValue].Add (System.Collections.Generic.TKey key, System.Collections.Generic.TValue value) <0x7f0010b3d8b0 + 0x0001b> in <filename unknown>:0    at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate (Microsoft.Data.Entity.Migrations.Operations.CreateTableOperation operation, Microsoft.Data.Entity.Internal.IndentedStringBuilder builder) <0x41913000 + 0x003c5> in <filename unknown>:0    at (wrapper dynamic-method) System.Object:CallSite.Target (System.Runtime.CompilerServices.Closure,System.Runtime.CompilerServices.CallSite,Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator,object,Microsoft.Data.Entity.Internal.IndentedStringBuilder)   at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2] (System.Runtime.CompilerServices.CallSite site, System.Dynamic.T0 arg0, System.Dynamic.T1 arg1, System.Dynamic.T2 arg2) <0x418c4710 + 0x0058a> in <filename unknown>:0    at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate (System.String builderName, IReadOnlyList1 operations, Microsoft.Data.Entity.Internal.IndentedStringBuilder builder) <0x418c20c0 + 0x001fc> in :0
at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationsGenerator.GenerateMigration (System.String migrationNamespace, System.String migrationName, IReadOnlyList1 upOperations, IReadOnlyList1 downOperations) <0x418be660 + 0x004c0> in :0
at Microsoft.Data.Entity.Migrations.Design.MigrationsScaffolder.ScaffoldMigration (System.String migrationName, System.String rootNamespace, System.String subNamespace) <0x4188c670 + 0x006cf> in :0
at Microsoft.Data.Entity.Design.MigrationsOperations.AddMigration (System.String name, System.String outputDir, System.String contextType) <0x41800580 + 0x0011e> in :0
at Microsoft.Data.Entity.Commands.Program+Executor+<>c__DisplayClass6_0.b__0 () <0x41463260 + 0x00034> in :0
at Microsoft.Data.Entity.Commands.Program+Executor.Execute (System.Action action) <0x414631d0 + 0x00028> in :0
An item with the same key has already been added.
`
So it seems like EF sees one model to be entered twice.

As a result I just want two tables, where both contain ID, Created and Updated. No inheritance structure within the database.

It seems to work if I put the ignore line last in context. Like:
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
  modelBuilder.Entity<Entity>()
    .HasKey(e => e.ID)
    .HasName("ID");

  modelBuilder.Entity<Entity>()
    .Property(e => e.Created)
    .ValueGeneratedOnAdd();

  modelBuilder.Entity<Entity>()
    .Property(e => e.Updated)
    .ValueGeneratedOnAddOrUpdate();

  modelBuilder.Ignore<Entity>();
}


Sometimes a click on file to diff also open the file in editor

Hi Mosh & thank you for making this free extension! :) I noticed a minor issue:

Opened 1st folder from VS menu, as usual.
Your icon appeared on sidebar (nice touch BTW) - opened 2nd folder from it.
Clicked on a common Jenkinsfile - both a diff + a new editor window to that file were opened.
I closed all windows & tried again - same behaviour.
Tried the same with another common file - .gitignore - only a diff window opened - seems OK.
Back to Jenkinsfile - same as #3 above. EDIT: removed redundant issue link.

Thanks for the issue (and for the great review 😉)
Actually, I can't reproduce the issue

Can you share your system info? (You can copy that from "About Visual Studio Code" menu)

I found the root cause - the GroovyLint extension tries to lint the Jenkinsfile & pops up a notification:

Maybe it's related to how the diff window is opened? I'm not sure why the linter kicks in, but honestly - it's not that important, now that I know there's a reason - you may close this.

Thanks for the update. If you have any other features in your mind, I'll be happy to hear.


Feature/django3

Update six module related code to add django 3 support.

Thanks for the PR! It's great to see additional people getting involved :)
I will be reviewing this in the next few days, and then upgrading our own projects using the library to Django 3 as well. It will be a great way to validate this version.

@TheLazzziest I am also thinking of dropping Python 2 support entirely. Any objections?

@lnagel , hi. None of them.
Actually, I would like to go a bit futher, and suggest to make this library on top of djoser and djangorestframework-simplejwt in order to focus on sso features only. What do you think?

Thanks @TheLazzziest for the help with Django 3.0 compat. I did have to revert a few things after the merge, but nothing serious.
Regards to djoser and djangorestframework-simplejwt - maybe you could describe how that change would be useful? I don't yet see much benefit in such a change to add these dependencies.

I did a fork of your repo, and made some sort of proof of concept. Well, It's turned out that djoser doesn't need at all. Instead, djangorestframework-simplejwt has all required stuff to make the transport layer of sso in case of using jwt. Thus, I suggest to focus on implementations of different approaches to sso for django rather then trying to encompass all at once.


Isolating setEnv to a single test case

Component
Forge
Describe the feature you would like
Related to https://github.com/foundry-rs/foundry/issues/2349 which was closed as won't fix. The main problem is around setEnv setting the env variable for the entire test suite currently running. While this makes sense in some cases (eg forks) it doesnt make sense in others. Specifically, here's an example of a problem I'm running into:
We have a testing harness that abstracts some testing away from the dev (in this case account abstraction related). As part of this harness, there are some env flags a user can set in order to modify test behavior or print a gas report. However, it is basically not possible to write unit tests for this harness, since if a single test sets the env var then all tests will be executed with that var set.
Additional context
Example (this will revert on some runs):
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.23;

import { Test } from "forge-std/Test.sol";

contract EnvFoundryTest is Test {
    function testEnv() public {
        vm.setEnv("SIMULATE", "true");
        assertEq(vm.envOr("SIMULATE", false), true);

        vm.setEnv("SIMULATE", "false");
        assertEq(vm.envOr("SIMULATE", false), false);
    }

    function testEnv2() public {
        assertEq(vm.envOr("SIMULATE", false), false);
    }
}

tbh I dont have a specific feature request but wanted to find out whether this is still a wont fix or whether there could be a possible feature that helps with this issue

tbh I don't have a specific feature request but wanted to find out whether this is still a wont fix or whether there could be a possible feature that helps with this issue

simple create a separate cheatcode to isolate env to each test case

Hi @kopy-kat,
Since it has been a while since this ticket was opened I'm curious whether you've been able to find a workaround?
The requested feature makes sense to me but this seems like an inherent limitation to environment variables being flat and applied globally
It is also not practical to introduce an entirely new set of "local" environment variables with cheatcodes: https://github.com/foundry-rs/forge-std/blob/07263d193d621c4b2b0ce8b4d54af58f6957d97d/src/Vm.sol#L246-L402 or modify the existing behavior of environment variables.
cc @mattsse per your comment: https://github.com/foundry-rs/foundry/issues/2349#issuecomment-1204099138 is this still a won't fix?

I was looking for this feature in the context of building a foundry-based dev kit and using env vars to run tests in certain modes. The workaround is using both env vars and storage vars to also be able to just run any specific test in a certain mode. Tbh the workaround is not that bad its just not very clean.

I think this is something we can reconsider when thinking about integration points for extensions / plugins for Foundry https://github.com/foundry-rs/foundry/issues/8266
For now however I'll mark it as not planned and close the ticket as there is no immediate actionable point
Again thanks for your suggestion, if you have any ideas / requirements regarding extensions feel free to comment on that ticket


Information Architecture restructure to include stuff for role-specific knowledge

This is a pitch to think about restructuring WunderWay a bit to accommodate knowledge, tools and best practices for role-specific tasks, based around the WunderExperts groups.
For example, we could look at something like …

Working at Wunderkraut
Working with clients
Delivering project

Project management

most current stuff

Stuff for developers
Design
[more WunderExperts groups here]

About the company

This is an open question for discussion.
Motivation:

make it clear and easy for WunderWay users to get to the stuff that is related to them most quickly, to priorities what people want/need to read
Make it clear which sections of the WunderWay are the responsibility of which WunderExperts group

This issue was created by me and @floretan in discussion about pushing forward with WunderWay stuff on technology best practices (especially with Drupal 8 in mind).
This is a shout-out to people in the various WunderExperts groups for opinions on this issue.
@huntons - keeper of The Way; operations
@lewisnyman - UX and Design
@alicerichmond - UX and Design
@WunderLemon - Editorial
@floretan - Technology Taskforce
@TomiMikola
@tcmug
@mikzalais
@tomper00


[Docs]: Mark Xcode14 as deprecated since end of september

Type
Improvement idea
What do you want to report?
Mark Xcode14 as deprecated since end of september
Code of Conduct

[X] I agree to follow this project's Code of Conduct

We can probably close from the PR.
As an aside, does semaphoreci do brownouts out all?


introduce 'known issues' to documentation

We should let people know in the documentation that we are aware of certain problems, and if available what the fix is.

:+1:  what do you think  @istr ? I fear a possible duplicate with faq section ?

Is it worth putting this as a sub section under the FAQ docs?  Or just converting this into FAQ style questions?
Though, putting it under FAQ feels like shoving a square peg into a round hole to me.

Finaly, thinking about it make me feel it's a bad idea to put it in FAQ section.
Can you add a link to faq in the installation section ?

I fear a possible duplicate with faq section ?

IMHO duplication would hurt less than omission. I am not sure, though, if it is worth duplicating what is already tracked in github tickets. Maybe we stick with the policy to document only "known issues" there that we deem largely unresolvable (i.e. we cannot solve by means of a bug-fix or work-around), like the one @BIGjuevos started with.
tl;dr -- :+1: to merge this.

thanks @BIGjuevos


Revert "Enable run-time exclusivity checking in release mode."

This reverts commit 67403f17ec3764b93c3cb656942297988cbac009.
This will be picked up by the subsequent rebranch. Much of the code
that it exercises is new since the previous rebranch, so it makes more
sense to enable it along with other significant changes.

@swift-ci test OS X platform.

@swift-ci smoke test OS X platform.

Build failed
Swift Test OS X Platform
Git Sha - 7993a3510cbf122920af12f8b7a4271af5755636


Intellij disagree with ktlint for code with for

Again, thank you so much for the linter! Just a small bug: The following code is formatted in intellij idea. But ktlint says it has several formatting errors.
p.s. the code seems artificial, just because I see ktlint bug in real code and I replace all variable names with fake names (with the same length) to avoid leaking internal code.
(base) ➜  app git:(feat/2588) ✗ cat ~/temp/a.kt && java -jar /Users/tom/opt/ktlint-0.44.0-20220123.092956-49-all.jar ~/temp/a.kt --debug
class A {
    private fun hi() {
        for (
        helloWorldHelloWorldAbcd in Lists.partition(
            abcdefgabcdefgabcdefgab,
            hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
        )
        ) {
            hello()
        }
    }
}
[DEBUG] Discovered reporter with "baseline" id.
[DEBUG] Discovered reporter with "checkstyle" id.
[DEBUG] Discovered reporter with "json" id.
[DEBUG] Discovered reporter with "html" id.
[DEBUG] Discovered reporter with "plain" id.
[DEBUG] Discovered reporter with "sarif" id.
[DEBUG] Initializing "plain" reporter with {verbose=false, color=false, color_name=DARK_GRAY}
[DEBUG] Rule with id 'standard:max-line-length' should run after the rule with id 'experimental:trailing-comma'. However, the latter rule is not loaded and is allowed to be ignored. For best results, it is advised load the rule.
[DEBUG] Rules will be executed in order below (unless disabled):
           - standard:filename,
           - standard:final-newline,
           - standard:chain-wrapping,
           - standard:colon-spacing,
           - standard:comma-spacing,
           - standard:comment-spacing,
           - standard:curly-spacing,
           - standard:dot-spacing,
           - standard:import-ordering,
           - standard:keyword-spacing,
           - standard:modifier-order,
           - standard:no-blank-line-before-rbrace,
           - standard:no-consecutive-blank-lines,
           - standard:no-empty-class-body,
           - standard:no-line-break-after-else,
           - standard:no-line-break-before-assignment,
           - standard:no-multi-spaces,
           - standard:no-semi,
           - standard:no-trailing-spaces,
           - standard:no-unit-return,
           - standard:no-unused-imports,
           - standard:no-wildcard-imports,
           - standard:op-spacing,
           - standard:parameter-list-wrapping,
           - standard:paren-spacing,
           - standard:range-spacing,
           - standard:string-template,
           - standard:indent,
           - standard:max-line-length
[DEBUG] Checking /Users/tom/temp/a.kt
Resolving .editorconfig files for /Users/tom/temp/a.kt file path
Loaded .editorconfig: []
/Users/tom/temp/a.kt:1:1: class A should be declared in a file named A.kt (cannot be auto-corrected)
/Users/tom/temp/a.kt:4:1: Unexpected indentation (8) (should be 12)
/Users/tom/temp/a.kt:5:1: Unexpected indentation (12) (should be 16)
/Users/tom/temp/a.kt:6:1: Unexpected indentation (12) (should be 16)
/Users/tom/temp/a.kt:7:1: Unexpected indentation (8) (should be 12)
[DEBUG] 769ms / 1 file(s) / 5 error(s)

This issue is not related to issue mentioned before.
You're right that it conflicts with IntelliJ formatting. Although, I do like the ktlint style much more, it should indeed being considered as a bug because we do no want ktlint to produce code that is not accepted by the IntelliJ default formatting.
class A {
    private fun hi() {
        for (
            helloWorldHelloWorldAbcd in Lists.partition(
                abcdefgabcdefgabcdefgab,
                hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
            )
        ) {
            hello()
        }
    }
}

I agree with you

This issue should be fixed in IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-293691/Format-Kotlin-for-loop. For the time being, the code will be accepted without errors. I have also fixed the wrapping so that it is allowed to write the code as follows which is also accepted by default formatter of IntelliJ:
class A {
    private fun hi() {
        for (helloWorldHelloWorldAbcd in Lists.partition(
                abcdefgabcdefgabcdefgab,
                hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
        )) {
            hello()
        }
    }
}```


Better default shading for 3D

The current default shading capabilities of Makie are not very top notch. Here is an example from a real-world setting:
function energy_dispersion_full(kx, ky; tprimeval = 0, λ=1, tval =2.8)
    a = 0.142
    f = 2cos(√3*kx*a) + 4cos(√3*kx*a/2)*cos(3ky*a/2)
    ε = λ*tval*sqrt(3 + f) -tprimeval*f
end
aa0 = √3 * 0.142
kx = range(-5/aa0, stop=5/aa0, length=100)
ky = range(-5/aa0, stop=5/aa0, length=100)
Z = energy_dispersion_full.(kx, ky')

shading = true
Makie.surface(kx, ky, Z, colormap = "viridis", shading = shading)
Makie.surface!(kx, ky, -Z, colormap = "viridis", shading = shading)

while setting shading = false produces

The first figure is way too dark. It is so dark that it is hard to even see what is happening. On the otherside, the second figure has no shading whatsoever, which makes my puny human bran have big difficulty in understanding its 3D...

Do you think this has been resolved?  @Datseris

Running into the same problem. For my case I'd ideally want to have the camera act like a light source itself.
I noticed that the underlying GLVisualize already contains a light_calc function that we could use to improve the lighting situation. However, I have no idea how to get to it from the Makie interface :neutral_face:

I think this issue has been resolved now.

For my case I'd ideally want to have the camera act like a light source itself.

That is the default now. The plot now looks like this: (without any changes to the code)

Huh, odd I haven't seen notifications for this so far. Yeah the above plot looks resolved to me.

Also, you can finally tweak the shading with ambient, etc:
http://juliaplots.org/MakieReferenceImages/gallery//lighting/index.html

Ah damn, I broke the recording :D Will update recordings tonight -.-


Security vulnerability of turbo gen

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
.
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
<EMAIL_ADDRESS>Describe the Bug
turbo/gen relies on proxy-agent, which in turn depends on pac-proxy-agent and socks-proxy-agent.
pac-proxy-agent uses pac-resolver and socks-proxy-agent.
socks-proxy-agent depends on the socks package, and both pac-resolver and socks depend on the ip package.
As indicated in the reference below, using the ip package can lead to security issues, which will be flagged as vulnerabilities in the repository's security tab.
https://github.com/advisories/GHSA-78xj-cgh5-2h22
https://github.com/indutny/node-ip/issues/150
Expected Behavior
It seems that the ip package is currently not actively maintained.
To address such issues, it might be beneficial to consider modifying the package.
To Reproduce
.
Additional context
No response

Maybe https://github.com/vercel/turbo/security/policy ?

Hello all! 👋
I'm wondering if there is patch planned for this for version 1 of turbo?
Thanks in advance! 🙇


Codemod from injectGlobal to createGlobalStyle

We should provide a codemod from injectGlobal to createGlobalStyle. Since cGS requires you to put the created component into the component tree, we cannot do it fully automatically, but we could throw a runtime error to make sure people remember to!
Something like:
// Before:
import { injectGlobal } from 'styled-components';

injectGlobal`
  html {
    background: red;
  }
`

// After
import { createGlobalStyle } from 'styled-components';

export const GlobalStyle = createGlobalStyle`
  html {
    background: red;
  }
`

throw new Error('You need to render the <GlobalStyle /> component! Do that, then delete this error message.')

Wdyt?
Also, at this point we should probably have a styled-components-codemods package... 😅

Can I pick this up?

Yes please!

I'm actually going to close this. Considering the impl is so different I don't think it's codemoddable in a way that's useful compared to a straightforward switch like innerRef -> ref.

Consider people with many injectGlobal calls throughout their app (for whatever reason), this could really save them a ton of time. I think we should have this codemod.

Will this be a separate package?

For react-virtualized we just created a folder codemods with codemods nested under version migrations. I was thinking of doing the same thing

@wuweiweiwu that sounds reasonable as long as folks can run them from the command line with a single command and don't have to install anything else :+1:
npm i -g styled-components
styled-components codemod v4

Or something like that

I thought I'd give it a dabble as an opportunity to contribute and learn about codemods and ASTs.
I've hit a bit of a wall and I'm tired so I thought I'd share my progress if anyone wants to pick it up.
https://gist.github.com/Aidurber/26939f1753cc9903e5b43ca7846d193f
It currently produces:
import { createGlobalStyle } from 'styled-components';

createGlobalStyle`
  html {
    background: red;
  }`;

I'm got stuck on creating the export const GlobalStyle. Please, forgive my trash first attempt 😁

@Aidurber Thank you for the snippet! Will take a look. It's not trash. We value all contributions and it means a lot to us.

Any movement on this?

@Aidurber how I'd approach it is:

Collect the createGlobalStyles calls like you're already doing
Find out how to turn them into variable declarations. You might have to increment a counter to keep the names unique in case someone declares more than one in a file
Create named exports for each
Append to source

astexplorer.net is a good resource for finding out how to transform. Put this snippet in and you can just go over the differences:
createGlobalStyles``;

const thing = createGlobalStyles``;

export thing;

Create named exports for each

Might want to skip that step in case they're not using es modules yet. Also throw in a console.warn like "An injectGlobal usage was converted to createGlobalStyles via codemod but needs to be hooked up. See {api website link} for instructions."

@probablyup you're right of course. was just trying to break it down into manageable steps :).

I made a styled-components-codemod package, it'd be great to add the createGlobalStyle codemod to it! https://github.com/styled-components/styled-components-codemods

If there's no movement I wouldn't mind taking care of this, I just don't want to duplicate effort. @Aidurber @probablyup would you like me to take care of this? Would you like to do a remote pair programming session?

@StevenLangbroek Feel free to take over! I'm traveling for work the next few days but you can ping me through Twitter or Spectrum and I'll get back to you as I can.
Would be awesome if you could contribute directly to that repo Max made 👍

Yeah I just don't want to deprive @Aidurber of a learning experience, it's a lot of fun to get started with. Are you waiting for the changes in enzyme re: ForwardRef, or now that they can't give a timeline do you want to move forward as soon as this codemod lands?

(yes I'm paying attention on twitter :D )

Yeah given the noncommital response from Jordan we’ll just move forward as soon as the codemods are done. I made a PR also to add a test util for grabbing styled components in enzyme more easily.

Cool. On it then. Have some meetings and work to finish in the morning, should be able to have a PR for you later today.

Awesome @StevenLangbroek! 🙌

Sorry this got away from me a bit. I'm doing some general clean-up on the file organization in the repo (the codemod that was there was in an index.js file etc), I'll open a PR early to gather feedback along the way.

Lol babel codemods are kind of a awkward compared to jscodeshift. Not complaining, just observing :). Sifting through statements like jscodeshift does is incredibly elegant.

I'm fine with either, whatever is easier to implement. I care more about getting this out and ease of use

No babel-codemod is fine, merely observing. Either the styled-extend has to be rewritten or this one has to be done from scratch, i'll take the existing infra. Then on my spare time I'll tinker s'more with jscodeshift (could be fun to combine with Ramda lenses).

I could make an assumption here:

If someone uses require -> exports.GlobalStyle =
If someone uses import, use export const GlobalStyle

Agree?

Actually if I were in line with the one that's already there, I'd only accounts for import, so maybe we should just assume people are using ES modules here too?

Honestly I would totally skip doing an export and just leave the warning in. Everyone's setup is going to be different so simply switching the helper used and putting in the console warning is enough IMO

Alright, fair enough.


Optional Reagents: Different Quality Stats not always correct

Example: Tempered Framework (BS)
Also: The +5 Skill Item seems to increase Recipe Difficulty in Simulation Mode but not the Skill

Can confirm that adding items like "Apprentice's Crafting License" are supposed to increase skill by +5 while not affecting difficulty, but instead they're increasing difficulty by 100 and not affecting skill


Clean up

Some clean ups

using pytest
use installed version of pydhamed in tests
use data fixture to make adding more test data easier
fix readme instructions
enable python 3 compatibility
remove untested matplotlib tests
remove matplotlib dependency (no imports used in library!)
remove *pyc files and add gitignore

@lukas-stelzl any data that should be installed with the package later when distributed on pypi?

Awesome work @kain88-de  ( and also @mimischi )! I'll merge the pull request.
The input files for RNA, ion channel and Ala5 examples should remain part of the project. I think easy reference to work examples is more important for this project than keeping it light weight.

@lukas-stelzl you might want to check your notebook files if they still change the path variable. I haven't looked in them. They should also use the pydhamed package ideally.


[packchk] missing cvariant not detected

Hi
Pdsc content:
    <condition id="xxx">
      <description>xxx</description>
      <require condition="xxx"/>
      <require Cclass="Device" Cgroup="STM32 HAL" Csub="Core"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="NONE"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="RTC_ALARM"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="RTC_WKUP"/>
      <accept Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="TIM"/>
    </condition>

    <component Cclass="Device" Cgroup="STM32 HAL" Csub="timebases" Cvariant="NONE" Cversion="0.1.0" condition="Timebase NONE">
...
    </component>

If some Cvariant are missing, there are no warning detecting this issue ?
Regards,

@thorstendb-ARM
Does it make a difference whether <accept> or <require> is being used?

Does it make a difference whether  or  is being used?

Yes!
Got message like
M504: RTE Model reports: MISSING:     --   require Device:STM32 HAL:timebases:RTC_WKUP

M504 reports the internal RTE Model checks. We should extend PackChk:
Find all references and check if they are available (WARNING if not)

@thorstendb-ARM can you please provide a version for @jeromecoutant to test the fix?


Cannot install package primitive

Installing the package primitive fails, using current git head version, compiled with GHC 7.6.3/64
$ haste-inst install primitive
Resolving dependencies...
Configuring primitive-<IP_ADDRESS>...
Building primitive-<IP_ADDRESS>...
Preprocessing library primitive-<IP_ADDRESS>...

Data/Primitive/Types.hs:153:268:
    Couldn't match expected type `Word64#' with actual type `Word#'
    In the return type of a call of `indexWord64Array#'
    In the first argument of `W64#', namely
      `(indexWord64Array# arr# i#)'
    In the expression: W64# (indexWord64Array# arr# i#)

Data/Primitive/Types.hs:153:441:
    Couldn't match expected type `Word64#' with actual type `Word#'
    In the first argument of `W64#', namely `x#'
    In the expression: W64# x#
    In the expression: (# s1#, W64# x# #)

Data/Primitive/Types.hs:153:519:
    Couldn't match expected type `Word#' with actual type `Word64#'
    In the third argument of `writeWord64Array#', namely `x#'
    In the expression: writeWord64Array# arr# i# x# s#
    In an equation for `writeByteArray#':
        writeByteArray# arr# i# (W64# x#) s#
          = writeWord64Array# arr# i# x# s#
.....

Fixed on master with GHC 7.10.


Incorrect SPI Configuration Syscfg's for MCU_NRF52832 and MCU_NRF52840

The nRF52832 has 3 SPI controllers, and the nRF52840 has 4. Mynewt only allows you to configure SPI0-1 for the nRF52832 and SPI1-2 for the nRF52840.

I'm addressed this with PR #1456.

fixed in #1456


Generate service READMEs and fix module descriptions

Description

Generates README.md files for individual service client crates, and references them from the Cargo.toml files so that they display on crates.io as the overview for each crate.
Fixes #754.

Testing

Unit tested where it made sense
Manually inspected generated README.md files and Cargo.toml files

Checklist

[x] I have updated CHANGELOG.md
[x] I have updated aws/SDK_CHANGELOG.md if applicable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'm not sure why these changes would cause the errors CI is seeing for the generated transcribestreaming crate.


Provide Oracle JDK compatible registry keys (Windows)

Hi,
apparantly there is software that relies on the Oracle JDK registry keys to run (at least Launch4j does, see https://sourceforge.net/p/launch4j/feature-requests/103/)
As workaround the installer could also add these registry keys. The Zulu JDK installer already does it this way:
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft]

[HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit]
"CurrentVersion"="1.8"

[HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit\1.8]
"JavaHome"="C:\\Program Files\\Zulu\\zulu-8"
"MicroVersion"="0"

As the last comment on the link included from ADAM at Launch4j

Zulu does write to the registry, but it has 2 different behaviours.
If Oracle Java is installed then Zulu writes to it's own locations. If Oracle Java is not installed, then Zulu writes to it's own locations AND the traditional Oracle ones.
In this second case launch4j picks it up without any further changes. However in the former case (which we believe will be very common) then Zulu is not selected.
By default Zulu installer doesn't add itself to the PATH.

Did we want to do the same things as Zulu ( dont override Oracle reg key ) ?
Or override it to allow Adopt to be used even if Oracle is already installed

As the last comment on the link included from ADAM at Launch4j

Zulu does write to the registry, but it has 2 different behaviours.
If Oracle Java is installed then Zulu writes to it's own locations. If Oracle Java is not installed, then Zulu writes to it's own locations AND the traditional Oracle ones.
In this second case launch4j picks it up without any further changes. However in the former case (which we believe will be very common) then Zulu is not selected.
By default Zulu installer doesn't add itself to the PATH.

Did we want to do the same things as Zulu ( dont override Oracle reg key ) ?
Or override it to allow Adopt to be used even if Oracle is already installed ?
Also see https://docs.oracle.com/javase/9/install/installation-jdk-and-jre-microsoft-windows-platforms.htm#JSJIG-GUID-47C269A3-5220-412F-9E31-4B8C37A82BFB
(two different reg key to create with the "new version-string format introduced in JDK 9"

We should not override other vendors.

yes JavaSoft is a trademark .. but If we write to this key when oracle is not already installed I presum that Oracle will override it.
So must we write to it even if Oracle is not installed ?

If we dont override each other key, we can't make this information available for third party.
So each vendor should create his key and Launch4J must check around many keys ( one for each compatible vendor ) ?

Ojdkbuild propose to create this reg key as an option enabled by default
Zulu dont ask for create and remove reg key "HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit" even if this is not their values
Oracle remove key "Java Runtime Environment" created by ojdkbuild if "JRE" is not checked during install
Amazon Corretto uninstall and supress CurentVersion living it missing

I think we definitly can't write/remove this key already shared by other vendor because uninstall will break other vendor and install can overrite other key
CurrentVersion mean nothing because we can having many current version at same time ( one for JDK 8 and one for JDK 11 )
It is probably less risky to create our key and software who want find/support AdoptOpenJDK can look a this keys
[HKEY_LOCAL_MACHINE\SOFTWARE\AdoptOpenJDK\Java Development Kit]
with
JavaHome
RuntimeLib
and not CurrentVersion but maybe : LatestInstalledVersion
Or CurrentVersion8 / CurrentVersion11 .. and so on

If we dont override each other key, we can't make this information available for third party.
So each vendor should create his key and Launch4J must check around many keys ( one for each compatible vendor ) ?

Of course best solution would be if each software would look for keys for each JDK, but that will never happen. Even if Launch4J starts looking for other JDK keys there will be many projects left that rely on Launch4J are not updated anymore.
So IMHO there is a need for some work around. Maybe just a "set default JavaSoft registry keys" option in the installer.

and not CurrentVersion but maybe : LatestInstalledVersion

Sorry for the :+1:, but we too rely on CurrentVersion, which points us to the relevant key.  Currently, to circumvent this, we do a try/catch on a shell execute of java.exe which grabs it from the path.
Since Oracle's Java 11 is only available in SDK, we already had to shim support for fallback keys so my feedback is that the location and name (albeit needed) is less important than the knowledge of what the latest/current actually is.

Also, cross-linking to one (of many) tools that try to make similar assumptions. :) https://nsis.sourceforge.io/A_slightly_better_Java_Launcher.  If AdoptOpenJDK is going to be a replacement for the shared Java on a system, these types of communal techniques can/should be updated once a decision is made.

Ojdkbuild propose to create this reg key as an option enabled by default
Zulu dont ask for create and remove reg key "HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit" even if this is not their values
Oracle remove key "Java Runtime Environment" created by ojdkbuild if "JRE" is not checked during install
Amazon Corretto uninstall and supress CurentVersion living it missing

I think we definitly can't write/remove this key already shared by other vendor because uninstall will break other vendor and install can overrite other key
CurrentVersion mean nothing because we can having many current version at same time ( one for JDK 8 and one for JDK 11 )
It is probably less risky to create our key and software who want find/support AdoptOpenJDK can look a this keys
[HKEY_LOCAL_MACHINE\SOFTWARE\AdoptOpenJDK\Java Development Kit]
with
JavaHome
RuntimeLib
and not CurrentVersion but maybe : LatestInstalledVersion
Or CurrentVersion8 / CurrentVersion11 .. and so on

Hi @douph1 - So to be clear there are other vendors who do set the JavaSoft key?  Or is it only Oracle that does?

All the above Ojdkbuild, Zulu  Amazon ..

@thenktor

Of course best solution would be if each software would look for keys for each JDK,

Fine :)

but that will never happen.

Why ?
WinRun4J already do this for "IBM" reg key

Even if Launch4J starts looking for other JDK keys there will be many projects left that rely on Launch4J are not updated anymore.

Project not updated arent dead project ?
They will continue to work with old Oracle

@tresf

;  Find JRE (javaw.exe)
;  1 - in .\jre directory (JRE Installed with application)
;  2 - in JAVA_HOME environment variable
;  3 - in the registry
;  4 - assume javaw.exe in current dir or PATH

JAVA_HOME ( second choice ) is provided with AdoptOpenJDK so https://nsis.sourceforge.io/Java_Launcher can work without relaying on Oracle "JavaSoft" tm reg key

JAVA_HOME ( second choice ) is provided with AdoptOpenJDK so https://nsis.sourceforge.io/Java_Launcher can work without relaying on Oracle "JavaSoft" tm reg key

%JAVA_HOME% is not toggled on by default, so I would argue that it cannot be consider "reliable" from a support perspective.  %PATH% is current reliable assuming new installers do a good job of removing old ones from the %PATH% on "upgrade" (upgrade meaning a new version is installed side-by-side the old).

Why ?
WinRun4J already do this for "IBM" reg key

Tagging @poidasmith.

CurrentVersion mean nothing because we can having many current version at same time ( one for JDK 8 and one for JDK 11 )

I'm bringing this statement back up again as I haven't seen any mention of it.  CurrentVersion from a Desktop support perspective usually means "the last one you installed".  Although developers run JDK8/JDK11 side-by-side, users tend to just have one runtime and hope it works.  WinRun4J seems to have some intelligence around the concept of MIN/MAX which can help if there's a known major version to target.  From my corner of the world, we had historically targeted whatever java.com linked to while trying to maintain backwards compatibility for some time.
But I still have concerns with this mentality.  If you're adding java.exe and friends to %PATH%, then you're essentially controlling current version anyway unless you're not clearing old values from the path, which will cause some upgrade problems (or prepend versus append influencing the search path).
Slightly off-topic WinRun4J use the CurrentVersion value?  The code defines it, but at a glance doesn't use it.
If AdoptOpenJDK is to be a drop-in replacement for Oracle Java, developers utilizing it need to know how to find it and I think that's the OP's point.

I think I'm sensing that strategically we should set our own key (don't break other Java's on the system because that's not nice) and work with the common installer libraries/frameworks/companies to pick up our registry key alongside, say, IBM's, Oralce's etc.
Would that satisfy folks?  If so we can make a list of the common libraries/frameworks/companies and @gdams can reach out to them.

I don't think that's a good move.
For one, the way the license change in Oracle Java 11 and the pitching of OpenJDK as the proper alternative was communicated, a huge amount of people out there come with the expectation of OpenJDK as a drop-in replacement. So if they don't get that, they are dissatisfied and probably move on.
At the same time, there is a good deal of software out there relying on the current registry entries, and experience shows that adoption of new entries by installers etc will take a while, and then it'll take even longer until all their clients have picked up those new versions. By then, most folks will probably have settled in with a different distribution that fits their needs.
I have recently brought one of my own projects up to speed for Java 11, and looking into what OpenJDK installation to suggest to our users was part of it (we might move to a bundled JRE in teh future though, making the point moot). I really like AdoptOpenJDK and how it presents a clear choice of JDK versions in an easily accessible fashion. But the fact that there isn't a Java 11 installer for Windows was a blocker for me. And an "incompatible" registry key would be as well. While it would be easy to get my own project to use your key, I'd still face a significantly high risk that it won't work with other software of my users, and their dissatisfaction would fall back on me. So right now, I'll go with Ojdkbuild, because it ticks all the boxes and looks the most vendor-neutral.

To be a bit more constructive: As suggested before, I'd present the option to create the JavaSoft key in the installer, as most of the other distributions seem to do already. I also like the idea of not overwriting an existing key. So I would suggest something like

always write to your own key

present the option to create the JavaSoft key in the installer

select the option by default if the key does not exist yet, and deselect it if there already is one

This way, the AdoptOpenJDK installer plays nice with other distributions, yet fulfills all user expectations. And it also "softly" establishes your own key. I wouldn't worry too much about other installers overwriting the JavaSoft key, since a) you'd still have your own key (1.) and b) the user would still get their expected experience of their software picking up a JDK (just not yours anymore).

Sounds like a reasonable compromise to me

@douph1 can you help us with this one?

I have begin,
As spotted in the Oracle doc:
https://docs.oracle.com/javase/9/install/installation-jdk-and-jre-microsoft-windows-platforms.htm#JSJIG-GUID-C11500A9-252C-46FE-BB17-FC5A9528EAEB

This key contains the string CurrentVersion, with a value that is the highest installed version on the system.

I  have done this ( not to set CurrentVersion blindly ... => Replace value only if the installer version is newer than the "CurrentVersion" already installed )

Oracle write in different key
HKEY_LOCAL_MACHINE\Software\JavaSoft\ JRE
or/and
HKEY_LOCAL_MACHINE\Software\JavaSoft\ Java Runtime Environment
and/or
HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\ JDK
and/or
HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\ Java Development Kit

If there are two versions of JDK or JRE installed on a system, one with the new version-string format introduced in JDK 9, and the other with the older version format, then there will be two different CurrentVersion registry key values. For example, if JDK 1.8.0 and JDK 9 are installed, then the following registry keys are created:

I must try to manage .. if possible:

choosing key based on older or newer version-string format introduced in JDK 9
choosing key based on JRE or JDK

And juste one note to everyone :
MSI Installer works as is : If a regestry key is handled by many installer,  it will be remove only when the last installer is uninstalled.
So replace JavaSoft (created by Oracle) key value with Adopt value
will not delete JavaSoftKey when Adopt is uninstalled and let the value CurrentVersion ( Adopt Value which is missing) as is
I think it is a problem and another reason too not write to a key managed by someone else already ... and simply not to share key with multiple installer

todo: need to handle Wow6432Node and RuntimeLib

By overriding JavaSoft key we will be hit by this bug: https://github.com/corretto/corretto-8/issues/36
because Oracle set a (preprend) Path "C:\Program Files (x86)\Common Files\Oracle\Java\javapath" with a "fake" java.exe which search for Reg key to locate the "CurrentVersion"  java.exe
https://stackoverflow.com/questions/49540325/which-jre-does-c-programdata-oracle-java-javapath-java-exe-use


Function called to refresh authorization not run

Hello!
My project for vue js. I followed the example and created a file main.js
import Vue from 'vue'
import App from './App.vue'
import router from './router'
import store from './store'
import vuetify from './plugins/vuetify';
import axios from 'axios';
import createAuthRefreshInterceptor from 'axios-auth-refresh';

Vue.config.productionTip = false;
Vue.prototype.$http = axios;
Vue.prototype.$serverApiLink = 'http://a.xsph.ru/api/';

function getAccessToken(){
    return store.state.authTokens.access
}

// Function that will be called to refresh authorization
const refreshAuthLogic = failedRequest =>
    axios.post(this.$serverApiLink+'/api/auth/token/new_access', {headers: {Authorization: store.state.authTokens.refresh}}).then(tokenRefreshResponse => {
    window.console.log('HELP');
    store.commit('userAuthTokens', tokenRefreshResponse.data.tokens);
    failedRequest.response.config.headers['Authorization'] = tokenRefreshResponse.data.tokens.access;
    return Promise.resolve();
});

// Instantiate the interceptor (you can chain it as it returns the axios instance)
createAuthRefreshInterceptor(axios, refreshAuthLogic);
axios.interceptors.request.use(request => {
    request.headers['Authorization'] = getAccessToken();
    return request;
});

when i get error 401 Nothing happens. refreshAuthLogic not work!
What am I doing wrong and how can I fix it? Thank you!

Would you please provide a small replication for this? At first glance it looks good, so it's hard to tell where the problem lies. Which version of the plugin are you using?

Thank you for a quick response!
I'm just a fool - I used the wrong syntax for my variables)
This works great!
Just in case, I will publish the correct code - perhaps this will be an example of a quick start for others.
import Vue from 'vue'
import App from './App.vue'
import router from './router'
import store from './store'
import vuetify from './plugins/vuetify';
import axios from 'axios';
import createAuthRefreshInterceptor from 'axios-auth-refresh';

Vue.config.productionTip = false;
Vue.prototype.$http = axios;
Vue.prototype.$serverApiLink = 'http://xsph.ru/api/';

function getAccessToken(){
    return store.state.authTokens.access
}

// Function that will be called to refresh authorization
const refreshAuthLogic = failedRequest =>
    axios.get(Vue.prototype.$serverApiLink+'auth/token/new_access', {headers: {Refresh: store.state.authTokens.refresh}}).then(tokenRefreshResponse => {
    window.console.log(store.state.authTokens.refresh);
    store.commit('userAuthTokens', tokenRefreshResponse.data.tokens);
    failedRequest.response.config.headers['Authorization'] = tokenRefreshResponse.data.tokens.access;
    return Promise.resolve();
}).catch(error => (
        window.console.log(error.response)
    ));
// Instantiate the interceptor (you can chain it as it returns the axios instance)
createAuthRefreshInterceptor(axios, refreshAuthLogic);
axios.interceptors.request.use(request => {
    request.headers['Authorization'] = getAccessToken();
    return request;
});

new Vue({
  router,
  store,
  vuetify,
  render: h => h(App)
}).$mount('#app');

Ok. I will close the issue then. Please, consider using StackOverflow for the future implementation help. Thank you.


feat: add formatter

This adds a formatter to the project (prettier), configures eslint to work with it, and runs a format over the entire project. The config of prettier is still to be confirmed, though the defaults are pretty good.
Closes #302

After discussion, this will not go ahead as we are going to use organisation level boilerplates which provide the functionality implemented here.


⚠ Bofrost.fr has degraded performance

In 72998ee, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1519 ms

Resolved: Bofrost.fr performance has improved in 2324b3f after 6 minutes.


A few minor tweaks to Follower and Followable.

Hi Tom,
Sorry to bombard you. I did a few more tweaks to simplify some of the methods in Follower and Followable.
James

Sorry, this took so long, I was in a bike vs. car accident and haven't been getting to do as much coding as I'd like.  Just merged these changes.   Are you ok?
J.


Fixed in https://github.com/macterra/artx-market/commit/a3df6993b33ab7a23f7681feda40e64ae21a2f66


[3.x] Fix the missing DLL's when exporting for UWP platform

Fixes #61060 for the 3.x version, Tested on the latest commit from the 3.4 and 3.x development branch.

Thanks!


Update messages_en.properties

Update email messages for CX specific email themes

No review needed since the implementation is isolated and includes only template updates


[Feature] Support ProxyJump

Support ProxyJump (ssh over Jumphost to host)

Hello, @konkere !
I think, we can do this already 🙂 Just type in your ssh parameters right into the Host field. Don't prefix your parameters with ssh, as it will be done automatically. The field label will also be changed from Host to Command. Something like that:

@grafviktor it works!
Thanx!


Make the UI responsible

Is your feature request related to a problem? Please describe.
Yes
The UI

Describe the solution you'd like
Make the Mobile view responsive

Describe alternatives you've considered

Additional context
I see the current version, not responsive
https://ui.demo.armadaproject.io/

┆Issue is synchronized with this Jira Task by Unito

Hey ,@kannon92 is this relevant issue if yes can you assign me to work on it

I don't think this is a valid use case - nobody is doing batch ML processing from their mobile phone.


When I installed it the first time, it said I need the python binary. Will my users need python too?

When I installed this package for the first time to use it's video download capabilities, it said I would need a python binary and need to add it to my path. The thing is, will users of my app need to do the same thing for them to use the app(download Python and add it to their path)?

No, it just needs python when the code runs


Languages should be sorted alphabetically in the admin panel

Describe the bug
When creating new test sets in the admin panel, the select box with languages seems having them sorted by their IDs. This makes finding languages suboptimal and alphabetical sorting would be much more convinient.
To Reproduce
Start adding a new test set through the admin panel.
Expected behavior
Languages in the select box are sorted alphabetically by their names.

Fixed in 4aa33baa336d09bf816213853a40a284005e36d1


ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.12.17
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log
C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\Download

youtube-dl -v https://www.youtube.com/watch?v=BaW_jenozKc
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=BaW_jenozKc']
[debug] Encodings: locale cp936, fs utf-8, out utf-8, pref cp936
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.7.9 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: none
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:7890', 'https': 'https://<IP_ADDRESS>:7890', 'ftp': 'ftp://<IP_ADDRESS>:7890'}
[youtube] BaW_jenozKc: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\usr\youtube-dl\youtube_dl\YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\usr\youtube-dl\youtube_dl\YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\usr\youtube-dl\youtube_dl\extractor\common.py", line 534, in extract
ie_result = self._real_extract(url)
File "C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\usr\youtube-dl\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
File "C:\awork\video-downloader-deploy-master\video-downloader-deploy-master\usr\youtube-dl\youtube_dl\extractor\common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

PASTE VERBOSE LOG HERE

Description
本地下载连接中视频时失败，报上边错误

WRITE DESCRIPTION HERE

I've searched the bugtracker for similar bug reports including closed ones

You should have done that.
Read this first before opening an issue: #30839.
And:
#31530.

Also, I'm glad I don't get your emails if your Subject: lines are this long.


Do not scan files in $GOCACHE

This PR causes mingo to skip scanning files that appear under $GOCACHE. Fixes #14.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 15 (46.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 61.59%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

scan.go
7
15
46.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
829

Relevant Lines:
1346

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 22 (59.09%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 61.715%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

scan.go
13
22
59.09%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
835

Relevant Lines:
1353

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 25 (64.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 63.321%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

scan.go
13
22
59.09%

Totals

Change from base Build<PHONE_NUMBER>:
1.6%

Covered Lines:
858

Relevant Lines:
1355

💛  - Coveralls


Binding a Select with options values that are objects does not display properly.

[Object object] is what you get visually.
Works fine when the select is not bound.


Added test on GCP & gcp workflow

Using github Actions to launch EVE on GCP for testing VMs
One Needs GITHUB secrets
GCP_PROJECT_ID - google project ID
GCP_SA_KEY - google project json key
OVPN_FILE - openvpn file
Also added new "gcp" workflow as large workflow is too large
Signed-off-by: fleandr<EMAIL_ADDRESS>

This is a great start @mydatascience -- a couple of points:

please provide a full, detailed list of secrets that this workflow requires and put it in the comment section of the workflow
while starting with Eden is great -- we will need that same workflow to be available to us on the EVE side in addition to the Eden workflow that we already have
for both we should probably transition to using as much cached artifacts as possible (for both EVE and Eden) to avoid wasting time rebuilding everything every time

GCP_PROJECT_ID - google project ID
GCP_SA_KEY - google project json key
OVPN_FILE - openvpn file (base64 encoded)

Please review @rvs
I would say - let's rebuild eden for now.(For eden)
Eve is not built, we use eve tag that is in eden here.
Once we have it in eden I will make the similar PR to Eve

Aside from a small change that needs to be implemented -- this looks OK @mydatascience

Aside from a small change that needs to be implemented -- this looks OK @mydatascience

LGTM. Please let me know what VPN secret should I add now that it has been merged @mydatascience

LGTM. Please let me know what VPN secret should I add now that it has been merged @mydatascience


Add a patient to list

As an ED Doctor i can add a patient to list of patients.

Enhanced existing add feature to allow adding of patients


Microsoft Emulator stopped rendering HTML

This morning, when I ran my BOT on the Bot Framework Channel Emulator, The  "Bold" tag stopped rendering and as a result I see a markup rather than the formatted content.

Check https://github.com/Microsoft/BotFramework-Emulator/issues/261

Hi @tgparmar75
Thank you for reporting this.  Please provide feedback on this WebChat repo issue: https://github.com/Microsoft/BotFramework-WebChat/issues/604

@tgparmar75 Once an updated WebChat control is published, we'll release a new emulator with the fix.


the_faculty_of_technical_sciences_in_cacak domain added

@stefan-j-98 Pull request merged. Thank you!
For the record: proof of the email domain ownership is here: http://www.ftn.kg.ac.rs/pages/office365.php


630 dead persons go to locations

Changes
Please briefly list the changes made:

Add a new LocationType - Cemetery, which is created along with the World and assigned to each person created.
Add a rule so that when a Person is dead, it is moved from ICU to Cemetery.

Merge Request - GuideLine Checklist

Check our git workflow before opening a Pull request/Merge request.
Request a reviewer when your work is ready to review, before this please use the draft feature.

Checks by code author

[ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[ ] New code adheres to coding guidelines
[ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[ ] Tests are added for new functionality and a local test run was successful
[ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Additional context
Please list additional information or things a reviewer should look out for.
Closes #630

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (ad29ab5) 92.81% compared to head (8decfba) 92.85%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   92.81%   92.85%   +0.03%
==========================================
  Files         107      107
  Lines        8242     8255      +13
==========================================
+ Hits         7650     7665      +15
+ Misses        592      590       -2

Impacted Files
Coverage Δ

cpp/models/abm/location_type.h
100.00% <ø> (ø)

cpp/models/abm/infection.cpp
93.37% <100.00%> (+1.39%)
:arrow_up:

cpp/models/abm/migration_rules.cpp
86.07% <100.00%> (+0.94%)
:arrow_up:

cpp/models/abm/world.cpp
88.88% <100.00%> (+0.36%)
:arrow_up:

cpp/models/abm/world.h
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@mknaranja This looks good from my side! Ready to merge 🎉


Rebrand

Changes:

add themed logo
remove surf gear
correct build badge

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f23b9e2) to head (dff3eed).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          156       156
=========================================
  Hits           156       156

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


added pop animation on product and slide animation on color-box

Pull Request Format
added pop animation on product and slide animation on color-box
Issue #621 : Adding animations to the product solved
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[X] Other (specify):Adding animations to the product

Description
Adding the product pop animation and the color-box slide animation to make it look more interactive
Screenshots / Videos (if applicable)
https://github.com/user-attachments/assets/5404db43-6d4f-49bf-bb5f-a43088c60736
Checklist

[X] I have performed a self-review of my code.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Hi there! This issue is still open. We are looking forward to your response. Assignees: None

i've already worked on this task, and requested PR.

@Jordian0 After the animation, the pop back animation is not smooth. Please make it.


PARQUET-781. Direct support for PathOutputCommitter

If parquet.path.outputcommitter.enabled is true
then it uses the PathOutputCommitterFactory mechanism to dynamically
choose a committer for the output path.
Such committers do not generate summary files; a warning
about this is printed when appropriate
This significantly simplifies writing to s3/azure/gcs
though committers which commit correctly and efficiently
to the target stores.
Jira

[X] My PR addresses the following Parquet Jira issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"

https://issues.apache.org/jira/browse/PARQUET-XXX
In case you are adding a dependency, check if the license complies with
the ASF 3rd Party License Policy.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

No tests yet
Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Style

[X] My contribution adheres to the code style guidelines and Spotless passes.

To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Needs tests
Proposed: enable factory, enable summary, verify summaries are not created but the job works. manually review the output log too.


Add Sales Invoice Record to the OnCorrectInvoiceOnBeforeOpenSalesInvoicePage event in "Correct PstdSalesInv (Yes/No)"

Hi,
Can you please add the Sales Invoice Record to the OnCorrectInvoiceOnBeforeOpenSalesInvoicePage event in codeunit  "Correct PstdSalesInv (Yes/No)"?
Actual code:
    local procedure CancelPostedInvoiceAndOpenNewSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header"): Boolean
    var
        SalesHeader: Record "Sales Header";
        ConfirmManagement: Codeunit "Confirm Management";
        CorrectPostedSalesInvoice: Codeunit "Correct Posted Sales Invoice";
        IsHandled: Boolean;
    begin
        if ConfirmManagement.GetResponse(CorrectPostedInvoiceQst, false) then begin
            CorrectPostedSalesInvoice.CancelPostedInvoiceCreateNewInvoice(SalesInvoiceHeader, SalesHeader);
            IsHandled := false;
            OnCorrectInvoiceOnBeforeOpenSalesInvoicePage(SalesHeader, IsHandled);
            if not IsHandled then
                PAGE.Run(PAGE::"Sales Invoice", SalesHeader);
            exit(true);
        end;

        exit(false);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCorrectInvoiceOnBeforeOpenSalesInvoicePage(var SalesHeader: Record "Sales Header"; var IsHandled: Boolean)
    begin
    end;

Suggestion code:
    local procedure CancelPostedInvoiceAndOpenNewSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header"): Boolean
    var
        SalesHeader: Record "Sales Header";
        ConfirmManagement: Codeunit "Confirm Management";
        CorrectPostedSalesInvoice: Codeunit "Correct Posted Sales Invoice";
        IsHandled: Boolean;
    begin
        if ConfirmManagement.GetResponse(CorrectPostedInvoiceQst, false) then begin
            CorrectPostedSalesInvoice.CancelPostedInvoiceCreateNewInvoice(SalesInvoiceHeader, SalesHeader);
            IsHandled := false;
            OnCorrectInvoiceOnBeforeOpenSalesInvoicePage(SalesHeader, SalesInvoiceHeader, IsHandled);
            if not IsHandled then
                PAGE.Run(PAGE::"Sales Invoice", SalesHeader);
            exit(true);
        end;

        exit(false);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCorrectInvoiceOnBeforeOpenSalesInvoicePage(var SalesHeader: Record "Sales Header"; var SalesInvoiceHeader: Record "Sales Invoice Header"; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53020.


DNSCrypt setting changes after each update

After each update the primary resolver is reset to the France one. This is bad. SimpleDnsCrypt should remember the setting of the previous installation.

Should be fixed for future releases.
I will also add more values to the new config.yaml.

This issue is still occurring. After the latest update v2.0.19 I have had to reconfigure the advanced settings and reselect the resolvers. It took me a while to figure out why none of of my devices could maintain a stable intenret connection - The Global Resolver setting was turned off after the update.


SkySpark Authentication

Hi, I enabled the haystack connector on SkySpark. (As I understand it, I do not need to create a specific instance of the haystack connector on SkySpark since that's only needed for SkySpark to retrieve information from another server, although I have tried both ways.) Now, I am trying to connect to a session via pyhaystack by calling the following on JupyterLab:
session = SkysparkHaystackSession(uri='http://server:port/api',
                                  username='user',
                                  password='pw',
                                  project='proj_name',
                                  pint=True)
session.is_logged_in

I have tried all combinations of uri's I can think of, including our server's IP address, a localhost address for a local instance of SkySpark, default ports (80, 8080) and port numbers listed on our SkySpark server. However, session.is_logged_in always returns False, and on the SkySpark end there is also no record of a log-in.
Could you recommend how to fix this issue?
Thank you for your help!

What works for me is :
from pyhaystack.client.skyspark import SkysparkScramHaystackSession

session = SkysparkScramHaystackSession(uri='https://demo.skyspark.com',
                                project='demo',
                                username='username',
                                password='password')

On 7/7/20 12:38 pm, angelinah1 wrote:

Hi, I enabled the haystack connector on SkySpark. (As I understand it, I do not need to create a specific instance of the haystack connector on SkySpark since that's only needed for SkySpark to retrieve information from another server, although I have tried both ways.) Now, I am trying to connect to a session via pyhaystack by calling the following on JupyterLab:
session = SkysparkHaystackSession(uri='http://server:port/api',
                                  username='user',
                                  password='pw',
                                  project='proj_name',
                                  pint=True)
session.is_logged_in

Did you try issuing a request between these two lines?  pyhaystack
doesn't bother trying to authenticate until it has something to do.

Adjusting these two things fixed it. Thank you both!


Add early return when error is returned. fixes #24

fixes #24

@untzag Yes the package is helpful for me in integration testing while developing both HART client and HART master an embedded device. Grateful to do something, albeit small, in return

Looks good to me, thanks @MaartenMJR


Treat <dependencyManagement> elements in POM files as dependency constraints

Currently, we only create dependency constraints for a <dependencyManagement> element in a BOM (POM with packaging='pom'). With this change, we'll treat <dependencyManagement> consistently for every consumed Maven POM.
This change may a broader impact:

Performance implications of many more dependency constraints
Behaviour changes due to honouring dependency management elements transitively

So here are the results of various experiments I have made on the cc/dependency-management/measure-advanced-pom branch.
There are some good and bad news. There were 2 different things we wanted to understand:
a. what is the impact of enabling the "advanced POM support" by default
b. what would be the impact of considering all dependencyManagement blocks as constraints, whether it's a BOM or not
I started with using the exclude rule merging performance test. The difference for a. is around 10% slower. It turns out that most of the difference doesn't come from adding dependency management block as pending dependencies: it's the fact that we use variant aware matching in this case (Maven dependencies are mapped to "real" variants when advanced pom support is enabled). In particular, attribute matching is very expensive, and coercion of attributes is even more:

To identify the impact of just BOM support, I disabled the mapping to variants. The results were conclusive, with an overhead of just about 2%, which is pretty reasonable.
First conclusion: variant selection is extremely expensive, more than the configuration based selection, and needs serious optimization.
I also noticed a few quick wins in terms of performance during dependency resolution, will isolate some commits and submit a pull request for those. Most of them are on exclude rule merging itself, so not related to this topic. So, in order to measure the real impact of enabling dependency management blocks as constraints everywhere, I modified the template project that we use for exclude rule merging, to not define excludes. There might be a few excludes left, those defined in Ivy or Maven descriptors, for example, but most of dependency resolution is happening without exclude merging.
In that case, we can see that b. is significantly slower: at best, it's 30% slower. The difference is almost exclusively due to more conflict resolution and basically more components being resolved. In particular, a lot more component metadata is read from disk (when we re-enable variant generation, it's like 60% slower, which is just crazy at this point). Note that the test project is a pathological case, it's really big and has a lot of dynamic dependencies.
The flame graph shows multiple potential areas of improvement, but none of them are trivial. In particular, caching dependency substitution rules turns out to be a hotspot, because the cache key is expensive to compare. We also reset a lot of state, like removing incoming or outgoing edges, and it's expensive with LinkedList. Conflict resolution handling also shows up as costly. Basically, I think it's going to be hard to improve without changing the algorithms and the underlying data structures used during selection.

I'm doing some more measurements on top of the cc/dep[endency-management/perf-improvements branch. I'll post some results here as I go.
First, with advanced POM support enabled, CachingDependencySubstitutionApplicator represents about a fourth of the visitOutgoingDependencies cost, which is pretty high knowing that in most cases if we're lucky, there's no substitution at all:

This flame graph is the latest of all. It involves:

"advanced" POM support enabled, including mapping to variants
does not consider all <dependencyManagement> blocks as constraints (only those from BOMs)
builds on top of the "performance fixes" branch

It clearly shows that we have 2 big contributors:

getting component metadata, which indicates that at some point, we need the metadata for specific revisions. There are multiple paths there, from dynamic resolution to just selection of a variant
variant selection, which is slow because of attribute matching. Just use the search button on the graph to search for "AttributeMatching" to give you an idea.
conflict resolution, which triggers a lot of restarts

The conflict resolution is a direct consequence of having more constraints.
To make things faster, we can probably:

investigate if it's possible to avoid getting metadata before hand, just knowing the version numbers (seems pretty hard)
investigate parallel graph resolution (good luck with thread safety)
optimize ModuleMetadataStore, which is the cache of binary descriptors. It turns out that the checks for existence of the metadata file itself are pretty costly. We do 2 checks (file exists, temporary file exists), which are very visible in that part of the graph. However, it's probably visible because we read a lot of descriptors from disk.

Another discovery that can help performance: the ExternalDependencyDescriptor#getMetadataForConfigurations method is called, on the test project, 20% of times with the very same arguments as the last call. Since what happens in there is expensive, it means we have a cheap way to improve performance by caching the result of the call there. I have made such an experiment here, which shows a significant reduction in time spent in getMetadataForConfigurations compared to the previous flame graph. It's still not free, but cheaper.

I'd be reluctant to add another layer of caching for ExternalDependencyDescriptor#getMetadataForConfigurations without first optimizing the hell out of the things that it's doing. I'm sure given some effort we can find inefficiencies that will buy us some time.
Every time we add another layer of caching, things get a bit more complicated...

Note that by "caching" here I only mean "avoid recomputing", so it's local. But yeah, I agree with you.


aux component deployment

Need to rewrite logstash-forwarder and collectd deployment for distributed logstash deployment

Add column in db_node table that represents the assigned logstash server endpoint. By default it should be the first.


Add support to edge.

Networkmaps does not work on Microsoft browsers due to the lack of support on event.composePath().
We need to find a workaround for this method.

Fixed.


make rpms dies due to .pyc's

during the make rpms run; the task dies due to there are 2 .pyc's in the sinks/ dir. one for init.pyc and one for librato.pyc.
removing the 2 .pyc's and rerunning make rpms the task completes.

I'm going to close this, as the issue appears to be in the rpm and not the repository.


[SPARK-15889] [STREAMING] Follow-up fix to erroneous condition in StreamTest

What changes were proposed in this pull request?
A second form of AssertQuery now actually invokes the condition; avoids a build warning too
How was this patch tested?
Jenkins; running StreamTest

Test build #62083 has started for PR 14133 at commit 719012f.

Test build #62083 has finished for PR 14133 at commit 719012f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62083/
Test PASSed.

Merged build finished. Test PASSed.

Merged to master/2.0 like the original change


Remove the special case for interfaces in isSubTypeOf() in FunctionType

The special case doesn't quite make sense and it's untested. it causes TypeValidator to generate an obscure warning on this code:
/** @interface */ function Foo() {};
var /** Function */ x = Foo;

input0:3: WARNING - initializing variable
found   : function (this:Foo): ?
required: (Function|null)
var /** Function */ x = Foo;
                            ^

It also causes TypeValidator to generate an extra warning when a class accidentally extends an interface.
NTI doesn't have this special handling.
Fixes #1643.

This change is

With this change, would the type checker allow:
/** @interface */ function Foo() {};
var /** Function */ x = Foo;
window.x = x();

b/c this is something that we probably do want to help people avoid (so that they can be sure that interfaces get stripped completely, which is usually what people want).

Closing this PR in favor of making the NTI stricter instead, which is being tracked by:
https://github.com/google/closure-compiler/issues/1680