Using table-stack, the labels dont appear. What am I missing?

I'm using the jquery plugin, with the accompanying css and js files, and when the window size is narrowed, the  headings are not labels on the left.  Is there some sort of markup I'm missing?
Using latest js (tablesaw - v3.0.0-beta.4 - 2016-10-12)

I think you forgot to include the tablesaw-init.js :)

I am seeing this too, did you manage to sort it? (tablesaw - v3.0.0-beta.4, jquery plugin)

I'm having the same issues (tablesaw-init is included). Manually triggering enhance.tablesaw doesn't work either.

My mistake was that I was adding the tablesaw classes and data-mode to a parent container, instead of the table. Check if you didn't do the same mistake first.

I'm using jQuery to set the tablesaw classes like this:
$("table:not(.no-tablesaw)").each(function(){
            $(this)
            .addClass('tablesaw tablesaw-stack')
            .data("tablesaw-mode", "stack");
});

Then I trigger the ?enhance.tablesaw` event on the table (triggering it on document.body) didnt' work as well.
Just as I'm typing it... You do mean data-tablesaw-mode instead of data-mode right?
It works and collapses the columns but skips the label part... not sure why. I didn't got it working yesterday right away and stopped tinkering with it. Maybe it has to do something with my dynamic page, I'll check later if it works on a plain site with nothing else but tablesaw.

Yeah, 'data-tablesaw-mode' (updated my comment).
In your particular case, I think you'll have to replace

Thanks mate. It worked, I'm not exactly sure why? I thought there is no difference between attr and data (except that jQuery tries to JSON.parse the data value on retrieval).
So my current code looks like this:
$("table:not(.no-tablesaw)").each(function(){
            var currentTable = $(this);
            currentTable.addClass('tablesaw tablesaw-stack');
            currentTable.attr("data-tablesaw-mode", "stack");
            $(document.body).trigger( "enhance.tablesaw" );
});

My HTML:
<link rel="stylesheet" href="/site/templates/bower_components/filament-tablesaw/dist/stackonly/tablesaw.stackonly.css">
<script src="/site/templates/bower_components/filament-tablesaw/dist/stackonly/tablesaw.stackonly.js"></script>

That's it. :) Big thanks man.

Yes—thank you @adrianpuescu!
@posixpascal: filament-tablesaw/dist/stackonly/tablesaw.stackonly.js is the shoestring version, which does not alias data to DOM attributes. Switching to filament-tablesaw/dist/stackonly/tablesaw.stackonly.jquery.js would’ve probably worked too. If you are already including jQuery on your page, I’d recommend making that change anyway, it’ll save you a few KB.

@zachleat was there any solution generally speaking?
@adrianpuescu of course I was including the JS.


Adds Logo & Badge

Adds Logo & Badge to Readme

Before
After

This looks Awesome !! Thanks @shahrukh-alam

This looks Awesome !! Thanks @shahrukh-alam


[new feature] To ensure typespec folder structure conform to guidelines

TypeSpec folder structure should conform to guidelines for TypeSpec project repositories and specification directory structure. Or there is a risk that we must customize SDK release pipeline to accommodate the inconsistency. It could also add complexity in breaking change detection. Currently, the common problems we encountered were as below

No Management suffix at the end of the service RP-name so that indicates a management (resource manager) library. An example of this is https://github.com/Azure/azure-rest-api-specs/pull/29740, and https://github.com/Azure/azure-rest-api-specs/pull/29748

The feature (or at least necessary suffix as prioritized) should be enabled in the spec PR pipeline prior to the program of TypeSpec Brownfields Conversion in execution.

The folder structure validation is covered by TypeSpec validation tool and the suffix validation has been added recently. Refer to this issue for details. https://github.com/Azure/azure-rest-api-specs/issues/29654


Documentation versioning

Build documentation for major releases
Motivation and context

How has this been tested?
https://azhavoro.github.io/cvat/docs/
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (read github docs)
- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro , which code will allow us to switch between version?

@azhavoro , which code will allow us to switch between version?

This handled by Docsy: https://www.docsy.dev/docs/adding-content/versioning/


Cannot screen record project with sounds on iOS11 with microphone input enabled.

On iOS 11 you can enable video screen recording to record apps on the iPad. If microphone input is enabled while trying to record playback of a ScratchJr project with sounds, the video recording stops having any sound when the first sound plays. Prior to the first sound, ScratchJr sound effects (e.g. the pop of attaching blocks) are heard.
Steps to reproduce

Create a project that includes a recorded sound
Enable and start video recording the project
Play the project, and activate the sound if necessary
Stop recording to save the video to the iPad photos app

Is this still an issue on iOS 12+?

Product backlog (screen recording)


DSEW - include new header logic for fully vaccinated signal

Description

Fix current DSEW CPR outage where the data drops on Fridays are not being picked up.
On the 2023/01/12 report, the "People who are fully vaccinated..." headers were renamed to "People with a completed primary series...".

Based on header descriptions, this looks to be the same data.
The fully vaccinated signal was not finding data to process because the code would not pick up the new header.

Looks similar to a past name change for this signal on 2021/03/09.

The code was updated to include "People with a full course".

Changelog
delphi_dsew_community_profile_report.pull

Updated retain_header function to include "People with a completed primary series...".

header is now placed in select list (list of headers).

Updated sig_select code in  _parse_sheet function to include entries with new header name.

New header is now placed into sig_select for fully vaccinated signal.
Now len(sig_select) > 0 for fully vaccinated signal

Fixes

PO-35

Some validation failures were occurring but after looking into them, they weren't from the new code but possibly some new data. These seem normal and no issues were identified when not running the validator.


'Use after free' crash

Something is happening, it is consistent, it might not be our bug, but it half-crash Pd...
how to reproduce:

start pd from the terminal
start the audio
open the (updated corrected) helpfiles (from the tip of PR47) one at a time, and close them. start with the first one and go in alphabetical order
either at bufaudiotransport or bufnfm we get a crash. No crash report, but the terminal window with Pd in says:

pd(716,0x1092f5dc0) malloc: Incorrect checksum for freed object 0x7fb64ce1c490: probably modified after being freed.
Corrupt value: 0x0
pd(716,0x1092f5dc0) malloc: *** set a breakpoint in malloc_error_break to debug
Pd: signal 6
gui socket 6 -
closing audio...

starting from bufnmf has no problem...

it also happened at nmfmatch~ if I continue the same drill (I'm checking for help-loading-error hence the systematic loading)

I wish it were a strange bug, but they're horribly common. Having to guess, it will be objects being deleted whilst something else is using one of our new snazzy managed buffers. I'll have a prod.

I've found one thing in Chroma that I've fixed in core, and can't reproduce any more (although it was a bit hit and miss to start with). Just to confirm, are you saying that the specific files that should be opened are only the help files changed in commit a31c1905aa692f5e9a9488f31654333069dd6775 ?

Just to confirm, are you saying that the specific files that should be opened are only the help files changed in commit a31c190 ?

yes this is what I was opening, with audio on, one at a time, then closing them, in alphabetical order. got a crash in 3 places but that doesn't mean it is created by that file then...

Have I misunderstood your sequence then? You don't open them all, then close them all, but open-close, open-close, etc.?
At the moment, I get intermittent crashes, related (it seems) to how quickly I'm closing things.

yes open one, close it, open the next, close it, etc

i seem to have a similar crash now -  I was playing with the kdtree help.
Crashed Thread:        0  Dispatch queue: com.apple.main-thread
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000030
Exception Note:        EXC_CORPSE_NOTIFY
Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [6895]
VM Regions Near 0x30:
-->
__TEXT                 000000010fe8c000-000000010ffac000 [ 1152K] r-x/r-x SM=COW  /Applications/Pd-0.52-2.app/Contents/Resources/bin/pd
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   pd                            	0x000000010fedba6d scalar_doclick + 269

from nowhere, when I click on our object after opening and closing helpfiles.
strangely, my computer get super sluggish after that sort of crash

until I restart it - as if something was going on - yet activity monitor doesn't moan about cpu or ram for pd

Being seemingly spontaneous doesn't tell us much about underlying cause. Was there more in that stack trace? I can see thread 0 crashed, but only the last function call in the chain. Is there a set way of getting it to happen?

that was all I got. I pressed bang in the kdtree help and boom and segfault. I'll email the full crash log in case other threads help?

other threads don't help at all here, unfortunately.

sadly not. I tried to reproduce. I was doing one lib_manip helpfile at a time from the top. I can try to reproduce again that way.

ok I cannot get it to crash. I think we should go public now with pr47 and hope someone catches it.

compiling across platform should help


Segmentation fault when reading loadfiles

In certain block configurations, reading the loadfile causes a segmentation fault. It only happens with high numbers of processors (> 4), and can be erratic in terms of when it occurs in some of my trials, though when using enough load files it trips consistently. It has something to do with the parallel read routine, but I haven't been able to pinpoint the problem.

Fixed with PR #4.


Fix code snippet error

The current snippet implies there is another array inside the autoImports array and readers/users that copy and paste (like me) might have a hard time spotting  why their Store isn't working as expected. It also suggests that it is either defineStore or 'defineStore', 'definePiniaStore' and not both.

Thanks but the array is normal and works in Nuxt 3


Add a highlighter feature

Something that highlights (the entire tile of) any items that match user-entered keywords.

Added onto the next version


Add debt to list

A registered user should be able to add a debt to their list of debts. The initial implementation could be a positive number, a type to know if the user must pay or vice versa, and a name. Only registered users can add debt to their list.

Fixed by #73


OAuthConsumer crashes (NSMakeCollectable)

When using OAuthConsumer to request a token, the code crashes when NSMakeCollectable is called internally.  I do not understand why this function causes a crash, as I have gone over it numerous times.
The offending code (found in OAMutableURLRequest.m):

(void)_generateNonce {
CFUUIDRef theUUID = CFUUIDCreate(NULL);
CFStringRef string = CFUUIDCreateString(NULL, theUUID);
[NSMakeCollectable(theUUID) autorelease];
if (nonce) {
CFRelease(nonce);
}
nonce = (NSString *)string;
}

Source: https://www.dropbox.com/s/0kcl6qrdyu1283q/OAuthVimeoTest.zip?dl=0

@v-brflem Do you have a call stack?

I looked at the dropbox repro and it looked like you are trying to create a subview off of the main thread. Fixing that I don't see the repro for the bug mentioned here. I am closing this unless you can provide a more detailed repro with call stack etc. Thanks!


test(index): remove redundant mock reset call

Pull Request Test Coverage Report for Build 480167764

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 480063488:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls

Pull Request Test Coverage Report for Build 480167764

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 480063488:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls

Pull Request Test Coverage Report for Build 480167764

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 480063488:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls

Pull Request Test Coverage Report for Build 480167764

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 480063488:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


[docs-only] update env_vars.yaml post Activitylog API merge

References: #9361 (Activity API)
After #9361 was merged, we need to update the helper yaml file to show correct values in docs.

CI hangs, no PR issue

please rebase

@micbar rebase done + commit with updates containing the latest changes 😃


Fixes bug where multiple save operators to the same integration crashes the UI

Describe your changes and why you are making these changes
This fails because of mismatches expectations between the SDK and backend. The SDK thinks that having multiple save operators with the same name is fine, as long as they are in different branches. However, this crashes when the UI attempts to display these kinds of DAGs.
The solution for now is to deduplicate save operators the same way we duplicate extract operators (with a suffix starting at "1" and gradually incrementing). However, save operators on the same artifact to the same integration are not duplicated. In those cases, we will simply overwrite the existing operator (this allows for updating of saves).
Of course, this means that you cannot currently save the same artifact to different places into the same integration.
Example workflow:
db = client.integration("aqueduct_demo")
output1 = db.sql("Select * from hotel_reviews;")
output2 = db.sql("Select * from hotel_reviews;")

output1.save(db.config("table_1", "replace"))
output2.save(db.config("table_2", "replace"))

Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

https://capture.dropbox.com/RTEudNQBmMJmWHBb


Updated the OpenXML version to latest

merged, please update ticket.

if you check in "GingerCoreNet, Ginger" solution the version used for the "DocumentFormat.OpenXml" is "2.9.1" but the version used in "GingerCore" was "2.8.1", dont know why this was difference so just updated the nuget version in "GingerCore"

Ok, And that solved the issues as well?
Regards,
Meni Kadosh
Automation Tools Development Team Lead
Amdocs Quality Engineering Services
BEAT R&D Center
+972-8-62-40961 (office)
[amdocs-2017-brand-mark-rgb]
Follow us on Facebookhttp://www.facebook.com/amdocs/, Twitterhttp://twitter.com/amdocs, LinkedInhttp://www.linkedin.com/company/amdocs, YouTubehttp://www.youtube.com/amdocsinc, Google+https://plus.google.com/105657940751678445194 and the Amdocs blog networkhttp://blogs.amdocs.com/.
From: Mahesh Shahane<EMAIL_ADDRESS>Sent: Monday, May 20, 2019 12:03 PM
To: Ginger-Automation/Ginger<EMAIL_ADDRESS>Cc: Meni Kadosh<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [Ginger-Automation/Ginger] Updated the OpenXML version to latest (#878)
if you check in "GingerCoreNet, Ginger" solution the version used for the "DocumentFormat.OpenXml" is "2.9.1" but the version used in "GingerCore" was "2.8.1", dont know why this was difference so just updated the nuget version in "GingerCore"
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/Ginger-Automation/Ginger/pull/878?email_source=notifications&email_token=AJTBJLU3KDZ76VQZKPVHLO3PWJSMPA5CNFSM4HNTQ6G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVYFE5Y#issuecomment-493900407, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJTBJLU2JM2R2G4BFF2QRK3PWJSMPANCNFSM4HNTQ6GQ.
This email and the information contained herein is proprietary and confidential and subject to the Amdocs Email Terms of Service, which you may review at https://www.amdocs.com/about/email-terms-of-service https://www.amdocs.com/about/email-terms-of-service


Confirmation before sending our MAX balance

Hi Team,
It could be great if you can add a confirmation request before sending our MAX balance. A missclick could happen and will cost you all your balance. What do you guys think ?
If you think this feature can save all your balance, do not hesitate to donate :D :
atoi1qqtrhln24gvu08a5w2gj5qty7s3xkpcptkxrmfsrpphf92s4qe5pwt8qy8g

That would really be good. Why not make it optional in the settings, if you want to have confirmation of sending in general (on by default). Especially with the iota:// deeplinks a send can happen in 2 clicks (!).

There is a confirmation screen before every transaction added in #816


Way to give different role to warmup lambda function.

Is there a way to give different role for warmup lambda function, so that only that function will have that permission, not others.

That has nothing to do with this plugin but with Serverless itself.
You can read how to do that here: https://serverless.com/framework/docs/providers/aws/guide/iam#custom-iam-roles-for-each-function

Yeah i do agree, with that, but how to give custom role to warmup function.
i want to do some thing like this
custom:
  warmup:
    cleanFolder: false,
    memorySize: 256
    name: 'make-them-pop'
    schedule: 'cron(0/5 8-17 ? * MON-FRI *)' // Run WarmUP every 5 minutes Mon-Fri between 8:00am and 5:55pm (UTC)
    timeout: 20
    prewarm: true // Run WarmUp immediately after a deployment
    folderName: '_warmup' // Name of the folder created for the generated warmup lambda
    role:  myCustRole0
    .....

resources:
  Resources:
    myCustRole0:
      Type: AWS::IAM::Role
      Properties:
        Path: /my/cust/path/
        RoleName: MyCustRole0
        AssumeRolePolicyDocument:
          Version: '2017'
          Statement:
            - Effect: Allow
              Principal:
                Service:
                  - lambda.amazonaws.com
              Action: sts:AssumeRole
        Policies:
          - PolicyName: myPolicyName
            PolicyDocument:
              Version: '2017'
              Statement:
                - Effect: Allow
                  Action:
                    - logs:CreateLogGroup
                    - logs:CreateLogStream
                    - logs:PutLogEvents
                  Resource:
                    - 'Fn::Join':
                      - ':'
                      -
                        - 'arn:aws:logs'
                        - Ref: 'AWS::Region'
                        - Ref: 'AWS::AccountId'
                        - 'log-group:/aws/lambda/*:*:*'
                - Effect: Allow
                  Action:
                    - ec2:CreateNetworkInterface
                    - ec2:DescribeNetworkInterfaces
                    - ec2:DetachNetworkInterface
                    - ec2:DeleteNetworkInterface
                  Resource: "*"

You are right :)
My PR above should add the capability that you want.
I don't have any serverless project setup at the moment so I couldn't test it. It would be great if you could :)


takeScreenshot fails to work when passing in a rectangle outside the viewport

I can take a screenshot as follows:
const mySel = await hero.querySelector('#myId');
const screenshotRectangle =
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   (await mySel.getBoundingClientRect()) as any;
screenshotRectangle.scale = 1;
const buffer = await hero.takeScreenshot({
   format: 'jpeg',
   rectangle: screenshotRectangle,
   jpegQuality: 100,
   fullPage: true,
});

This gives however the full page, ignoring the given rectangle.
If I however leave off the fullPage (which is what I tried first), I get an error which states
that the given rectangle is outside the viewport...
https://github.com/unblocked-web/agent/blob/main/core/lib/Page.ts#L770-L773 that's the assert that I get apparently.
two observations there:

for a full page screenshot, you adapt the viewport size to the full page size
in https://github.com/unblocked-web/agent/blob/main/core/lib/Page.ts#L487 I read that apparently you can capture beyond viewport

So given the second observation I think we can even just drop that assert. But if you do want to support < 87,
then I suppose you would want to also support overriding the screen dimensions based on a given rectangle, rather
then only doing it for fullPage?

According to @blakebyrnes we might  need to resize to fit the element size if it’s that big,
see on Discord for his original message: https://discord.com/channels/966293220780806174/966293220780806177/1032432492822667305

Thanks @GlenDC. As per Discord, that flag does not work as you'd hope, which is why we're doing all the work to resize the screen to capture beyond the viewport. If you find that newer versions have finally added support, please report those findings here and we'll figure out what to do.
We have a test that takes a clipped rectangle smaller than the viewport, so it seems there are two potential issues here:

An element out of view. I do NOT think we should scroll the window here for you. Seems you should do this yourself.
If an element is larger than the viewport, it's throwing that assertion. I agree we should experiment in this case to see what happens if we simply remove that assertion. Otherwise, we probably need to do the same thing we do on full screen

An element out of view. I do NOT think we should scroll the window here for you. Seems you should do this yourself.

I do not agree. From a UX POV there should be no difference in how to use full page Vs giving a rectangle. It's not as if you expect full page to be scrolled (What would that even mean).
For me giving a rectangle is like taking a cropped full page. It will be a pretty horrible UX (and what would even be the advantage for the user) that they first would have to scroll. The other option is that I would need to do the cropping outside, but that seems a bit odd.
So I really strongly urge that the experience between full page and rectangle, which IMHO is just a cropped version of full page.

That said, I would be more in favor of the full page screenshot and then doing some kind of crop out of it.

You mean that if you use the Rectangle property that it would start with a full page, and than crop it?


Update codeship base URL

Regular API requests still work fine, status requests we're breaking on, as https://codeship.com/projects/:uuid/status redirects to https://app.codeship.com/projects/:uuid/status.
So the response to codeship.com/... is a 301 without the needed Content-Disposition header.
This PR just adjusts the base URL used to make all requests to Codeship.

:shipit: hahahaha!!

@daveallie Thank you for the PR! it seems to break the current specs however, would you like me to help take care of those?
$ rspec spec/

...
Finished in 0.08515 seconds (files took 0.49708 seconds to load)
36 examples, 36 failures

Failed examples:

rspec './spec/status_spec.rb[1:1:2:6]' # Codeship::Status parsing the project status of a project with active build
should parse testing
rspec './spec/status_spec.rb[1:1:2:8]' # Codeship::Status parsing the project status of a project with active build
should parse stopped
rspec './spec/status_spec.rb[1:1:2:1]' # Codeship::Status parsing the project status of a project with active build
should parse branchnotfound

Sorry, didn't even realise, would be great if codeship could test PRs 👍

@daveallie thanks! yeah for some reason our auth for Github was no longer working for this project. I think I fixed the issue though, so any new PRs should receive status updates from Codeship.
Thanks again!


ModuleNotFoundError: No module named 'g2o'

Hi @tjau123 , please refer to  here.
https://github.com/best-of-acrv/toposlam/tree/main/envs


Add Python 3.12 release

What do these changes do?
Add Python 3.12 to the release builds and use Python 3.12 in regular CI.
I made Python 3.10 the minimal version so that we still support the latest 3 Python versions, similar to the previous release.
The testrelease is running here: https://github.com/larq/compute-engine/actions/runs/9596990350

It seems that the locked requirements.txt file is quite different for Python 3.12. Perhaps we should do the same as what TF does and have separate requirements_{python_version}.txt files.


Fix Georgian Long ('L') Date format.

According to wikipedia, the correct date format is 'DD.MM.YYYY': https://en.wikipedia.org/wiki/List_of_date_formats_by_country.
Fixed that to conform the general used format.

PRing again to conform the requirements.


Add indexing dialect and range analysis

This adds a dialect for index calculation and analysis intended to be used for annotation of ranges and alignments for dynamic shapes and index-like values (namely index and typical index-width integers).
The key parts added in this initial patch are:

A range analysis and interface for bounds propagation. The analysis currently models everything as signed which poses a problem for constants which can either be interpreted as signed or unsigned. This is practical for the simplest cases where the consumers of the analysis know to expect uniformly either index or signless integers always able to be interpreted as signed, but in general we will need to grow sister analyses or different element options to track signedness and overflow.

The Indexing dialect boilerplate + interface + an assertion op to do annotations. The intent is to add more assertion ops that users/frontends can generate that can be used to inform range analysis.

Closing as this has been superceded by recent integer range work.


[CONS-6006, CONTINT-3700] Fix duplicated logs with K8s jobs

What does this PR do?
Fix a bug where Kubernetes pods logs could be collected twice, with a different tag set.
This could happen only with docker.
Motivation
Fix CONS-6006
Additional Notes
Logs were collected twice because of the following sequence of events:

While the pod is running normally, its logs are collected from files.
When a job pod completes, the kubelet still reports it but with the Completed state.
The container is stopped on docker side.
The agent watches the docker socket and polls the kubelet.
When the container is stopped, the agent removes it from workload meta store.
However, the entity is kept in the tagger in order to be able to properly tag dogstatsd packets that might arrive late. But tagger entities are assigned a TTL.
When the TTL expires, the tags of the stopped container change.
The tagfreshnessticker of AD kicks in. This tag changes triggers a refresh of the AD service.
This new AD service causes the creation of a new log service.
As the container is stopped, its k8s logs files have been deleted.
So, the agent tailer falls back to the docker socket.
Because we now use the docker socket, we cannot use the index file to not collect logs again.

The tag freshness ticker was at the origin of this sequence that eventually led to collecting logs twice.
The tag freshness ticker was introduced before workload meta store was created, at a time where both AD and the tagger had their own unsynchronized collectors.
Because of that, we couldn’t guarantee in which order AD and the tagger would react to events.
This isn’t true anymore. Now, all collectors are in workload meta and both AD and the tagger react to workload meta events.
Workload meta is supposed to feed the tagger first and wait for the tagger to complete before notifying AD.
Thanks to this new design, the AD tag freshness ticker is obsolete and can be removed.
Unfortunately, removing it revealed bugs that had to be addressed in this PR as well:

The function to merge port slices was bugged. In practice, the fact that it wasn’t commutative led to changes each time the order in which we merge workload meta entities changed.
The function in workload meta to notify the subscriber was bugged. Because it was iterating on a map, it wasn’t guarantying that the tagger was notified first as it should.

Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Use a kubernetes cluster with docker. This is not very common anymore those days. minikube could be a good option.
Create a CronJob which creates pods living for 2 minutes:
apiVersion: batch/v1
kind: CronJob
metadata:
  name: hello
  namespace: workload
spec:
  jobTemplate:
    metadata:
      name: hello
    spec:
      template:
        spec:
          containers:
          - args:
            - |
              for i in {1..12}; do
                echo "$(date) XXXXX ${HOSTNAME} ${i}"
                sleep 10
              done
            command:
            - bash
            - -c
            image: ubuntu
            imagePullPolicy: Always
            name: hello
  schedule: '*/2 * * * *'

Without this fix, we see logs collected twice, with a different tag set:

With this fix, we shouldn’t see that anymore.
Reviewer's Checklist

[X] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[X] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[X] A release note has been added or the changelog/no-changelog label has been applied.
[X] Changed code has automated tests for its functionality.
[X] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[X] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[X] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[X] If applicable, the need-change/operator and need-change/helm labels have been applied.
[X] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[X] If applicable, the config template has been updated.

/merge


Filter out illegal uri（#2952）

If an illegal appname is registered on Eureka, such as "lb:// ", it will cause the service to fail to start and throw "Illegal character in authority at index 5: lb://"
so. filter out illegal appnames during startup

@caixunshi Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@caixunshi Thank you for signing the Contributor License Agreement!


fix(USA): remap seat values

options value passed is not the expected value by the api. creating a new mapping with the values adjusted to what is expected.

@cdnninja this one didnt create a release version

Oops you are correct.  Fixed. For next maybe try have that title as the commit title as well as the PR.


Fix in merging

I have removed spurious periodicity checks here to ensure setups work independent of origin.

Yes, this fixes the problem we had in the workshop. The only thing still needed is to run the mpi tests . Is it quick for you to run these? If not I will have a look at how to run them later this week.

In principle you can only mpirun them.


Sample Distribution Optimization

I'm trying to run the Bert workload and the time it takes to reach the training loop is significant (around 10 minutes in my case with 64 mpi processes on a very fast HPC system). So, I profiled the bert workload (with a reduced total number of files for testing purposes) with a single process and found that the os.path.abspath is taking most of the time. This is used when distributing the samples. I profiled the bert workload when using both the Pytorch and TensorFlow frameworks using the npz file format because they differ in sample distribution methods get_global_map_index and build_sample_map_iter respectively. I stopped the profiling once the process hit the training loop. I used py-spy to profile the processes.
Profile for get_global_map_index:
  %Own   %Total  OwnTime  TotalTime  Function (filename)
  0.00%   0.00%   38.52s    38.52s   normpath (posixpath.py)
  0.00%   0.00%   21.89s    81.53s   abspath (posixpath.py)
  0.00%   0.00%   15.03s    15.03s   __init__ (dlio_benchmark/data_loader/torch_
  0.00%   0.00%   13.97s    15.04s   join (posixpath.py)
  0.00%   0.00%   11.69s    93.22s   get_global_map_index (dlio_benchmark/utils/

Profile for build_sample_map_iter:
  %Own   %Total  OwnTime  TotalTime  Function (filename)
  0.00%   0.00%   40.64s    40.64s   normpath (posixpath.py)
  0.00%   0.00%   23.99s    88.22s   abspath (posixpath.py)
  0.00%   0.00%   20.86s    109.1s   build_sample_map_iter (dlio_benchmark/utils
  0.00%   0.00%   14.51s    15.86s   join (posixpath.py)
  0.00%   0.00%    5.67s     7.73s   isabs (posixpath.py)

The call to abspath is taking a considerable portion of the time for workloads that have a large sample size. This runtime could be improved by eliminating the redundant calls to abspath. Here is a commit with a fix that does this commit.
Here is my profiler results after the commit is applied.
Profile for get_global_map_index:
  %Own   %Total  OwnTime  TotalTime  Function (filename)
  0.00%   0.00%    5.63s     5.63s   get_global_map_index (dlio_benchmark/utils/
  0.00%   0.00%   0.300s    0.690s   _call_with_frames_removed (<frozen importli
  0.00%   0.00%   0.250s    0.250s   get_tensor (dlio_benchmark/checkpointing/py
  0.00%   0.00%   0.060s    0.640s   <module> (torch/__init__.py)
  0.00%   0.00%   0.050s    0.050s   __getattr__ (torch/_ops.py)

Profile for build_sample_map_iter:
  %Own   %Total  OwnTime  TotalTime  Function (filename)
  0.00%   0.00%   11.90s    11.90s   build_sample_map_iter (dlio_benchmark/utils
  0.00%   0.00%   0.000s    11.90s   _run_app (hydra/_internal/utils.py)
  0.00%   0.00%   0.000s    11.90s   run_job (hydra/core/utils.py)
  0.00%   0.00%   0.000s    11.90s   <module> (dlio_benchmark/main.py)
  0.00%   0.00%   0.000s    11.90s   run_and_report (hydra/_internal/utils.py)

As can be seen the abspath method is no longer in the top 5 methods of the runtime and the time to get to the training loop is reduced significantly.

@TheAssembler1 would you mind sending a PR? And we will take a look from there.

Thanks for the fix @TheAssembler1


Prevent users from affecting team eligibility

Provide a checkbox on team management page that would (by default) prevent any users from joining the team if they would impact its eligibility.

Resolved with #322


Downshift bug with React 18 and open state

Follow up Downshift has a bug related to React 18, check wether we can make a workaround or update downshift.
https://github.com/downshift-js/downshift/issues/1384

It looks like 7.0.5 released december 17 may fix this issue


#6 Fix python setup.py install error for python2.X

Fix issue#6

Current version of the branch (2016-04-25) is already fixed.


fix should derive stats asap to avoid npe

we do derive stats job eager to avoid un derive stats due to merge group and optimize group
consider:
we have two groups burned by order: G1 and G2.
then we have job by order derive G2, optimize group expression in G2, derive G1, optimize group expression in G1
if G1 merged into G2, then we maybe generated job optimize group G2 before derive G1.
in this case, we will do get stats from G1's child before derive G1's child stats.
then we will meet NPE in CostModel.

run buildall


Handle logical dimms isolation and deconfiguration

In ddr5 systems, we could have more than one logical dimms per physical dimm. But the inventory page only shows the physical dimms. Added the code to handle and create only one guard record per deconfiguration.

Created another pull req to address these changes https://github.com/ibm-openbmc/openpower-hw-isolation/pull/86


Split Metropolis into Byzantium and Constantinople

This change is used in https://github.com/ethereum/cpp-ethereum/pull/4295

The cpp-ethereum PR has been merged.


CFY-5838 Wrong path when using resources_to_copy of test_utils.workflow_test decorator

Closed: As this PR is more than six months old without having been merged. Please reopen (and rebase if necessary) if it is still relevant.


hope that traditional Chinese will be added to this awesome plugin

There 2 kinds of Chinese  Characters.
I made zh-CN.json file, simplified Chinese ,which is used among  people in China Mainland ,Singapore and Maylaysia.
and zh-TW.json , Traditional Chinese ,which is used among people in Taiwan, Hong Kong, Macao.
traditional Chinese bible is here. https://www.bible.com/zh-TW/bible
hope Traditional Chinese will be added to this awesome plugin
zh-TW.json

Thanks, these will be included in next release, planned on early next month.

Please check this release https://github.com/tim-hub/obsidian-bible-reference/releases/tag/3.2.1


C# plugin doesn't compile with Ubuntu precise.

Got that one when trying out of fix for protobuf under gcc-4.8 and gcc-4.6:
[HOSTCXX] Compiling src/compiler/csharp_generator.cc
src/compiler/csharp_generator.cc: In function 'std::string grpc_csharp_generator::{anonymous}::GetFileNamespace(const FileDescriptor*)':
src/compiler/csharp_generator.cc:67:23: error: 'const class google::protobuf::FileOptions' has no member named 'has_csharp_namespace'
src/compiler/csharp_generator.cc:68:28: error: 'const class google::protobuf::FileOptions' has no member named 'csharp_namespace'
make: *** [objs/opt/src/compiler/csharp_generator.o] Error 1
root@23ea38de1900:/grpc# gcc --version
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

This happens on a fresh docker image:
$ docker run -t -i ubuntu:precise bash -l
root@23ea38de1900:/# apt-get update
root@23ea38de1900:/# apt-get dist-upgrade
root@23ea38de1900:/# apt-get install git build-essential autoconf libtool curl wget unzip
root@23ea38de1900:/# git clone --recursive git@github.com:nicolasnoble/grpc.git
root@23ea38de1900:/# cd grpc/
root@23ea38de1900:/grpc# git checkout origin/protobuf-4.8 # this is the branch for my PR
root@23ea38de1900:/grpc# make

Ignore this - that last test I didn't have the proper protobuf branch checked out.

I see the same error while building grpc master (fdc9af8dc as of now) with protobuf 3.0.0-alpha-2 (which works fine with grpc release-0_6_0). I'm quite sure I don't have any other protobuf is the system, as it's a docker image.

..and apparently, protobuf 3.0.0-alpha-2 doesn't have csharp_namespace anywhere.
Does grpc need an even newer protobuf ??

yes, grpc_csharp_plugin depends on version of protobufs that has c# support. Which was added after 3.0.0-alpha-2. so for now, you need to use head of protobuf to compile the latest version of grpc. This will get once a new version of protobuf is released (= very soon).


Changed bonsai:sandbox to bonsai:sandbox-10

This fixes the Couldn't find either the add-on service or the add-on plan of "bonsai:sandbox" error

Codecov Report

Merging #1265 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   69.85%   69.85%
=======================================
  Files         117      117
  Lines        6083     6083
  Branches      775      775
=======================================
  Hits         4249     4249
  Misses       1677     1677
  Partials      157      157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb915b8...fe639f3. Read the comment docs.

Interesting, I've changed it based on what Heroku's CLI reports. We need to change this in docs as well.


Add logit support

Context
App logs needs to be sent to Logit. This enables troubleshooting of app
failures easier.
Trello card
https://trello.com/c/KWGpTqZp

 Add Logit support


Add overrides, bump list output

closing in favor of https://github.com/rainbow-me/rainbow-token-list/pull/4


The issue at hand is that the system begins to judge the content as incomplete without waiting for the LLM to return the results.

Describe the bug
add third party llm,
it is a web socket service,
run llm_api_test ok
but, when do
chainlit run app.py  or command line,
Failed to parse LLM output due to LLM failed to generate complete attachments
Planner talk to Planner: failed to parse LLM output due to LLM failed to generate complete attachments
The issue at hand is that the system begins to judge the content as incomplete without waiting for the LLM to return the results.

Hi, @dxjjhm! Could you provide the model you used and the LLM output failed to be parsed by Planner?

close inactive issues


Create Repo is always failing.

I have tried to use create repo library, but could not get it working, can you shed some light on the variables, and can we make all the fields as variables to be used across the code base. Instead of modifying the scipt.

Do you mean there is an issue with the functionality test case for create repo or the script create_repo.py?
Also the script has been updated to have a description of the variables and what it's functionality is supposed to be.

Thanks for the update, the description has helped me understand the working to integrate it with the frontend.


doesn't properly combine requests into 1

need to further look into this once i can work out some consolidateBy related kinks.
but this patch
diff --git a/metric_tank/http.go b/metric_tank/http.go
index a6249a9..21c9a0f 100644
--- a/metric_tank/http.go
+++ b/metric_tank/http.go
@@ -40,6 +40,7 @@ func get(metaCache *MetaCache, aggSettings []aggSetting) http.HandlerFunc {
 func Get(w http.ResponseWriter, req *http.Request, metaCache *MetaCache, aggSettings []aggSetting) {
        pre := time.Now()
        values := req.URL.Query()
+       log.Debug(fmt.Sprintf("INCOMING %q", values.Get("target")))

        consolidateBy := values.Get("consolidateBy")

results in

should be 3 targets in 1 req. seeing 2 targets in 2 different requests.

It looks like fetch_multi is not behaving as expected. it's being called multiple times with a single node each time, even when we request multiple targets from graphite-api in 1 request.  it's kind of hard to believe but it looks like fetch_multi in graphite-api never worked properly to begin with? ( i think i remember it working fine when i was doing graphite-influxdb though)
anyway, there's been some interesting work upstream, such as https://github.com/brutasse/graphite-api/pull/119
and some followup PR's

@diterbe i dont think this is a problem anymore. The cause of the problem was the bug in graphite-api.  The fixes for this were merged into our fork.
Does your testing today confirm that a single graphite request results in a single MT request?


Remove the deprecated crd client

Description
This PR completes the removal of the deprecated CRD client.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Unit testing (existing)
[x] E2E testing (existing)

/test

/test

/test

/test

/merge


Fix statx_timestamp types/field names

Use more recent and not yanked version of memoffset
Typo where tv_nsec was named tc_nsec
Use same types as libc (except for statx_timestamp.__reserved which stays an i32 — like in Linux headers — instead of an [i32; 1] like the glibc)

I implemented getting created time on Linux in exa with your crate (thanks!), I’ll just wait for this PR to be merged so I can use the correct field name right away. :)

Thanks!
But since libc has already statx function ans structs now, is this crate still needed?

Right I guess I can do the syscall with libc too, I’ll check that.

@ariasuni
I make this crate compatible to libc 0.2.3 , as fallback for system with statx support but having an old version of glibc (libc::statx will cause a link error).
I think this may still be helpful for std.

The standard library is using libc, too. The problem is that they made the very dumb choice of exposing the underlying type by creating the MetadataExt.as_raw_stat() function, so we’re stuck with not being able to get the creation time until next epoch if that’s something they allow to do I guess.
By the way, my exa PR is here (since I mentioned it but didn’t put a link).


Pre-release changes for GAX

Adds SourceLink
Adds a release build script
Updates the version to 2.1.0-beta01

Ah, got it. We're still trying to pack the net45 DLL even on Linux. Oops.


Rename rfc0022_refine_builder.md to rfc0023_refine_builder.md

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Good catch - I added it.


feat: Add report Part-2

Signed-off-by: Shubham Gupta<EMAIL_ADDRESS>

chainsaw-report.json
This is a sample of generated report.


Deleting area tag also converts the area outline into a path

Shouldn't it rever to the Basic Area? I spent over 30 minutes figuring out why on earth I couldn't find Park or other area types, because it wasn't an area, it was a path and those aren't applicable.
Now I probably won't be affected by this anymore, but any new user could be when editing existing areas.

It is somewhat unclear how to convert lines to areas right now, and cumbersome to do even if you know to type the tag manually. I find myself doing this fairly often, due to accidentally tracing with the wrong geometry or fixing some else's tagging mistake.
One rough solution would be to add the Area preset to the Line preset list for closed ways and vice versa. It'd still be a two-step conversion process—selecting the geometry preset and then going back and selecting the feature preset—but it is more discoverable and doesn't involve typing.


Unsupported syntax in files that are not target files - export { Foo as Bar } from "..."

When using export { Foo as Bar } from "..." and then re-exporting "Bar" from a target file, then "Foo" will be tree-shaken even if "Bar" is used.
When changing this:
export { Foo as Bar } from "...";

to that
import { Foo as Bar } from "...";
export { Bar };

then it works all fine.

Thanks for reporting! Could you by any chance provide a minimal repro?
I may need a small clarification, especially around that part of your description:

then "Foo" will be tree-shaken even if "Bar" is used

I've just set up a documented example to illustrate how I actually understood your issue's description, it may help you understand where's the confusing part for me.

From what you created, you got the idea right, but I can see that in your repro it works. I will try to figure out the difference to my project setup that might be missing here.

I've created a PR with an example that demonstrates the issue: https://github.com/Dschungelabenteuer/vite-plugin-entry-shaking/pull/32

Thank's a lot, I'll take a look this week-end!

@fdc-viktor-luft just to keep you posted, I did not forget about this and I've already fixed the issue on my side; but I'm also working on several other issues/features I'd like to deploy at once. Unfortunately I didn't have much spare time lately, please let me know if this can still wait a bit on your side. I may still deploy a dedicated patch if this takes too much time

I'm not sure if this is the same issue, but i get error when there is an aliased import in a file and that file has a declaration which has the same name as the original import.
Example:
import {Flyout as FlyoutBase} from '@monorepo/package-one';

export const Flyout = () => {
   return <FlyoutBase />
}

The code throws error Duplicate identifier Flyout :(


FAI-7767  fixed formatting and improved test

Description
We want to make it so if a V2 Query is inputted to convert V1 to V2, no change occurs.
Majority of changes occur in the adapter.test.ts file. Allowing to test both V1 and V2 queries at once.
Type of change

[ ] Bug fix
[X] New feature
[ ] Breaking change

What's the purpose of this PR? If the query is V2 we shouldn't use the adapter at all. Am I missing something?

@ypc-faros  We are trying to enable flows to support v2 syntax.
For Flows we automatically use the adapter when pulling out a query, and we want to avoid modifying them if the flow query is already in v2 format. Otherwise we'd need to find a way to discover if the query is in v1 or v2 format somewhere else in the code rather than here.
Another nice addition is that this will remove the errors that occur when someone converts a transform and leaves the "adapt to v2" button pressed.

@ypc-faros We are trying to enable flows to support v2 syntax. For Flows we automatically use the adapter when pulling out a query, and we want to avoid modifying them if the flow query is already in v2 format. Otherwise we'd need to find a way to discover if the query is in v1 or v2 format somewhere else in the code rather than here. Another nice addition is that this will remove the errors that occur when someone converts a transform and leaves the "adapt to v2" button pressed.

I'm not familiar with that part of the codebase so I'll defer to @cjwooo @eskrm @willmarks
But this doesn't feel like a good idea to me (unless it's the only solution :P)
Is this not equivalent to try-catching on the client side?
try {adapter.nodes(query...)}
catch {farosClient.nodeIterable(query...)}

But this doesn't feel like a good idea to me (unless it's the only solution :P)

I suggested this so we can run everything through the adapter in canonical-reports instead of doing it conditionally (flows can be either v1 or v2). I'm kind of regretting it though because it breaks the expectation that the adapter always returns v1 nodes. As in, if v1 query => v1 nodes, then I'd expect v2 query => v1 nodes too. This is definitely something we can do on the caller side.


trouble starting VS CODE

Dear! I am new around here and the truth is I am a bit disoriented in how to ask.
I am having trouble starting VS CODE in its latest version. Attached is the capture. I have Win 7 32bit, 3gb RAM. I already installed and uninstalled it multiple times.
I read that the same thing happened to some of them but I cannot understand the solutions given.
Thanks since now!

Hello, @elthunderbyte!
I believe that this problem occurred because your Windows has only 3Gb of RAM.
Before opening VSCode, open the Task Manager and see in the performance tab how much RAM is left.
Then open VSCode and see how much RAM is left.

Acá adjunto dos capturas! Una al iniciar la PC y otra al abrir el VS CODE.
Qué piensan?

Please start from the command line like so code --prof-startup

There I tried and got the same result. Attached screenshot:

Please start from the command line like so code --prof-startup, not code prof startup (the dashed matter)


Draft: Added survey 2024

Add a link to the survey

This has been style-checked with Alberto and should go live on Monday morning (4.11.2024)


State reset on multiple runs

At the moment, state is defined in init, but that preserves the state before next run. Need to init state in execute, or do instance.reset() or something.

Fixed.


feat(index.d.ts): Adding TS support

This will add support for Typescript projects to this Javascript project
Resolves #1

@fospitia

@hsluoyz thanks for the PR


Service name should not be allowed to contain spaces

Able to create a package.json with name field containing spaces.
Extra space is not very cli-friendly to type and should be validated in the schema
jsonschema validation currently passes the build even if there is a space.

Example :
{
  "packagingVersion": "4.0",
  "name": "Time Server",
  "version": "1.0.0",
    ....
}

Created jira issue


.Net: fixed extension data in Model diagnostics

Motivation and Context

Previously when an AI client starts a model diagnostics activity, it passes in an execution setting that is not parsed to a setting that is specific to the client. This creates an issue where the some of the settings cannot be read by the diagnostics module.
Description

Pass in the parsed setting to the diagnostics module. The diagnostics module will the serialize the object and deserialize it to PromptExecutionSettings to get the extension data.

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

one unaddressed comment, otherwise lgtm

Added the line back with a comment and the link to the issue.


Expensive validator wicket 8.x

We need to call database stored procedure in validator.
It is quite expensive and it shouldn't be called after every key press.
I would like to propose a little validation improvement.

X-Ref: https://github.com/apache/wicket/pull/177

@amichalowski Please close this PR. We don't have permissions to close it ourselves. Thanks!


PartsList of EP0 and Bridges

Section 9.13.6 of the CHIP spec describes how a controller is able to monitor devices being added or removed from a bridge.
When an update to the set of Bridged Devices (which are exposed according to the Section 9.13.11,
“Best practices for Bridge Manufacturers”) occurs, the Bridge SHALL
• on the Descriptor cluster of endpoint 0: update the PartsList attribute (add/remove entries from
this list)
• update the exposed endpoints and their descriptors according to the new set of Bridged Devices

Nodes that wish to be notified of added/removed devices SHOULD monitor changes of the PartsList
attribute in the Descriptor cluster on endpoint 0.

Is the esp-matter endpoint creation code modfying the PartLists on EP0 as required?  These needs to dynamically happen, not just at initialization time. If I have a commissioned bridge running, and then add another BLE/Zigbee device to it, the PartList on EP0 should dynamically change.

This is not explicitly happening in esp-matter. I could see some code in attribute-storage.cpp which reports the PartsList when a dynamic endpoint is enabled/disabled. For enabling, i.e. adding new endpoints, I think this should work.
For disabling, we call the emberAfClearDynamicEndpoint() API from esp-matter, which then reports the PartsList. But I am not sure if it will work as expected. We'll have to do some tests.

@jonsmirl Is this addressed and can be closed?

Closing this. Please re-open in case of any further questions


Help Me

how do i solve this problem---(An error occurred while installing debugger (1.5.0), and Bundler cannot
continue.
)

I had faced the same issue and got solved by running
$bundle update debugger


NetKVM 178 ARM64 Crash with kdnet driver enabled -> 17802 private build no connection

on #449, I wrongly used netkvm + microsoft kdnet virtio together with bcdedit settings, so at the report time kdnet might be running as well.
so the first issue would be to confirm the microsoft driver is disabled (I see stopped sc status kdnic ). then I'll continue testing until netkvm works.
for reference
17802 build at https://github.com/virtio-win/kvm-guest-drivers-windows/issues/449#issuecomment-636318512
trace.cmd https://github.com/virtio-win/kvm-guest-drivers-windows/issues/449#issuecomment-633541886 with device logging level 2

qemu 5.0.0 raw (no patch!), so "trace-event virtio_net* on" is unused.
-device virtio-net,disable-legacy=on,netdev=net0
trace-event virtqueue_flush on
trace-event virtqueue_fill on
3425@1591457166.997765:virtqueue_fill vq 0x5584836000 elem 0x5584646f20 len 602 idx 0
3425@1591457166.997819:virtqueue_flush vq 0x5584836000 count 1
3425@1591457166.997860:virtqueue_fill vq 0x5584836098 elem 0x5584175de0 len 0 idx 0
3425@1591457166.997883:virtqueue_flush vq 0x5584836098 count 1
3425@1591457167.045559:virtqueue_fill vq 0x5584836098 elem 0x55845dff80 len 0 idx 0
3425@1591457167.045612:virtqueue_flush vq 0x5584836098 count 1
3425@1591457167.067414:virtqueue_fill vq 0x5584836000 elem 0x55849a9980 len 602 idx 0
3425@1591457167.067476:virtqueue_flush vq 0x5584836000 count 1
3425@1591457167.067521:virtqueue_fill vq 0x5584836098 elem 0x5584114d60 len 0 idx 0
3425@1591457167.067544:virtqueue_flush vq 0x5584836098 count 1
3425@1591457167.333194:virtqueue_fill vq 0x5584836098 elem 0x55842535c0 len 0 idx 0
3425@1591457167.333247:virtqueue_flush vq 0x5584836098 count 1
qemu-system-aarch64: virtio: zero sized buffers are not allowed

netkvm-qemuerror.zip

got a backtrace on virtqueue_fill len == 0
b hw/virtio/virtio.c:840 if len == 0
#0  virtqueue_fill (vq=0x55578d32f8, elem=0x55571b8380, len=0, idx=0)
    at /mnt/usb/aports/aports-master/community/qemu/src/qemu-5.0.0/hw/virtio/virtio.c:840
#1  0x0000005555a5cd98 in virtqueue_push (vq=0x55578d32f8, elem=<optimized out>, len=<optimized out>)
    at /mnt/usb/aports/aports-master/community/qemu/src/qemu-5.0.0/hw/virtio/virtio.c:917
#2  0x0000005555a431b8 in virtio_net_flush_tx (q=q@entry=0x5557793ba0)
    at /mnt/usb/aports/aports-master/community/qemu/src/qemu-5.0.0/hw/net/virtio-net.c:2220
#3  0x0000005555a433b8 in virtio_net_tx_bh (opaque=0x5557793ba0)
    at /mnt/usb/aports/aports-master/community/qemu/src/qemu-5.0.0/hw/net/virtio-net.c:2328
#4  0x0000005555f31ec0 in aio_bh_call (bh=0x5557793c00)

got no backtrace on b hw/virtio/virtio.c:2112 (virtio_net_tx_complete)... what could be happened on that queue?

b net/queue.c:163 qemu_net_queue_deliver
there is only ONE packet (in qemu RX side)

If you want to ensure kdnet is stopped, use "bcdedit /set debug off"
If you have virtio-net and e1000(e) you need to use "bcdedit /set "{dbgsettings}" busparams b.d.f" to specify which exactly adapter you want to use for kdnet (as kdnet supports both).
Do you have windbg for kernel debugging running or not?

I'm new in windows debugging... but maybe able to try, so answer is NO.
so remaining issues would be checking virtio-net (& queue) init steps, and find out why the queue is stopped.
I got some hope since the new message "zero sized buffers are not allowed". any ideas?

Note: this is not netkvm.
I booted alpine linux aarch64 on same UEFI firmware and got this trace with ifup eth0, and able to access ipv4 network normally.
I assume 0x55a840f130 is ctrl interface? will this affect qemu virtio internal state?
(so next step I should compare this?)
20903@1591726879.755101:virtqueue_fill vq 0x55a840f130 elem 0x55a79cc9a0 len 1 idx 0
20903@1591726879.755158:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.755555:virtqueue_fill vq 0x55a840f130 elem 0x55a7d9a4c0 len 1 idx 0
20903@1591726879.755598:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.756011:virtqueue_fill vq 0x55a840f130 elem 0x55a7c702a0 len 1 idx 0
20903@1591726879.756053:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.756604:virtqueue_fill vq 0x55a840f130 elem 0x55a7802ea0 len 1 idx 0
20903@1591726879.756641:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.756929:virtqueue_fill vq 0x55a840f130 elem 0x55a8533120 len 1 idx 0
20903@1591726879.756979:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.757222:virtqueue_fill vq 0x55a840f130 elem 0x55a7a68ce0 len 1 idx 0
20903@1591726879.757268:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.757817:virtqueue_fill vq 0x55a840f130 elem 0x55a8125b20 len 1 idx 0
20903@1591726879.757853:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.758160:virtqueue_fill vq 0x55a840f130 elem 0x55a7cb5360 len 1 idx 0
20903@1591726879.758250:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.758477:virtqueue_fill vq 0x55a840f130 elem 0x55a7a16d60 len 1 idx 0
20903@1591726879.758537:virtqueue_flush vq 0x55a840f130 count 1
20903@1591726879.766370:virtio_net_send packet of 90
20903@1591726879.766473:virtqueue_fill vq 0x55a840f098 elem 0x55a7e859e0 len 0 idx 0
20903@1591726879.766561:virtqueue_flush vq 0x55a840f098 count 1
20903@1591726879.792964:virtio_net_send packet of 342
20903@1591726879.793131:virtio_net_recv packet of 590
20903@1591726879.793257:virtqueue_fill vq 0x55a840f000 elem 0x55a7c48fa0 len 602 idx 0
20903@1591726879.793456:virtqueue_flush vq 0x55a840f000 count 1
20903@1591726879.793753:virtqueue_fill vq 0x55a840f098 elem 0x55a7cdc320 len 0 idx 0
20903@1591726879.793999:virtqueue_flush vq 0x55a840f098 count 1
20903@1591726879.833503:virtio_net_send packet of 342
20903@1591726879.833594:virtio_net_recv packet of 590
20903@1591726879.833649:virtqueue_fill vq 0x55a840f000 elem 0x55a7e859e0 len 602 idx 0
20903@1591726879.833752:virtqueue_flush vq 0x55a840f000 count 1
20903@1591726879.833858:virtqueue_fill vq 0x55a840f098 elem 0x55a7c48fa0 len 0 idx 0
20903@1591726879.834024:virtqueue_flush vq 0x55a840f098 count 1

@fcicq Let's place things in some order. You've opened this issue for crash with kdnet enabled. At least on arm, the kdnet supports also virtio (or present to be) so when you have e1000 and virtio you need to specify for kdnet exactly which adapter it should use via {dbgsettings} etc. Also, there is no sense to enable kdnet unless you want to use kernel debugger. So, Linux guest is not so relevant to this issue. Yes, probably first printouts in the last trace are from control queue (for example, configuration of packet filter and multicast addresses). The device is able to work also without control queue, we intentionally does not activate it on ARM until we see the device working normally without it.

yes. I'm not familiar with protocol so I'd like to see some control differences. but there is none. (expecting len something on qemu TX side)
have to use kdnet&windbg (and maybe driver verifier) route soon. I'm quite afraid of those windows tools past years ...
sorry for the newbie actions.

ps: but you know arm64 does not work... will real newbies appears & asks for fix without giving infos later this year? hopefully arm64/WoA dont really gain popularity before this is fixed.
now I consider some kind of blue screen is good but there is no more on 17802. hmm...

@ybendito got a new possibility. miniport works but the adapter is not!
tried the new netkvm signed driver 185.
no crash on install but the netkvm adapter is missing. kdnet adapter shows some pkt sent and 0 receive (but kdnic is NOT running, debug is disabled).
deleted netkvm pci device and kmode crash on driver reinstall, I believe that is fixed on 17802 but maybe it is a wrong direction?
older issues mentioned "NetAdapterCreate" but it is WDF/vista~ only api?

now I have vs2017, windbg and personal netkvm build so I confirmed the first crash again.
!analyze -v says...
fffff286`94862980 fffff802`b1b40970 : fffff286`948629f0 fffff802`b1b40c10 00000000`00000000 fffff802`aa1af794 : netkvm!CalculateIpPseudoHeaderChecksum+0x1c [\netkvm\common\sw_offload.cpp @ 474]
fffff286`948629d0 fffff802`b1b40d5c : fffff286`948629f0 fffff802`b1b40d5c 00000000`1c14038a 00000000`0000001f : netkvm!VerifyUdpChecksum+0xb0 [\netkvm\common\sw_offload.cpp @ 634]
fffff286`948629f0 fffff802`b1b37164 : fffff286`94862a40 fffff802`b1b37164 00000000`00000000 00000000`00781f11 : netkvm!ParaNdis_CheckSumVerify+0x18c [\netkvm\common\sw_offload.cpp @ 772]
fffff286`94862a40 fffff802`b1b44dc0 : fffff286`94862a90 fffff802`b1b44dc0 00000000`00000000 ffffd802`86af8000 : netkvm!ParaNdis_CheckRxChecksum+0xb4 [\netkvm\common\parandis_common.cpp @ 2140]
fffff286`94862a80 fffff802`b1b35e0c : fffff286`94862ac0 fffff802`aa1b4814 fffff286`94862af0 fffff802`b1b35e0c : netkvm!ParaNdis_PrepareReceivedPacket+0x2e8 [\netkvm\wlh\parandis6_impl.cpp @ 1032]
fffff286`94862af0 fffff802`b1b360c0 : fffff286`94862b50 fffff802`b1b360c0 fffff286`00000001 fffff802`b1b36068 : netkvm!ProcessReceiveQueue+0x174 [\netkvm\common\parandis_common.cpp @ 1588]
fffff286`94862b50 fffff802`b1b36530 : fffff286`94862bd0 fffff802`b1b36530 00000040`00000000 00000000`00000000 : netkvm!RxDPCWorkBody+0x168 [\netkvm\common\parandis_common.cpp @ 1679]
fffff286`94862bd0 fffff802`b1b43f98 : fffff286`94862c20 fffff802`b1b43f98 ffffd802`86af8000 00000000`00000001 : netkvm!ParaNdis_RXTXDPCWorkBody+0xd0 [\netkvm\common\parandis_common.cpp @ 1786]
fffff286`94862c00 fffff802`ac0ffbb0 : 00000020`00000000 00000000`00400a02 00000000`00000000 ffffaacf`27a4b672 : netkvm!MiniportMSIInterruptDpc+0x38 [\netkvm\wlh\parandis6_impl.cpp @ 448]
fffff286`94862c50 fffff802`ac0ff8f0 : fffff286`94862ce0 fffff802`ac0ff8f0 00000000`00000040 00000000`00000000 : ndis!NdisMSetBusData+0x10e0

FOLLOWUP_IP:
netkvm!CalculateIpPseudoHeaderChecksum+1c [\netkvm\common\sw_offload.cpp @ 474]
fffff802`b1b405f4 2941a408 ldp         w8,w9,[x0,#0xC]

FAULTING_SOURCE_CODE:
   436: static __inline USHORT CalculateIpv4PseudoHeaderChecksum(IPv4Header *pIpHeader, USHORT headerAndPayloadLen)
   437: {
   438:     tIPv4PseudoHeader ipph;
   439:     USHORT checksum;
>  440:     ipph.ipph_src  = pIpHeader->ip_src;
   441:     ipph.ipph_dest = pIpHeader->ip_dest;
   442:     ipph.ipph_zero = 0;
   443:     ipph.ipph_protocol = pIpHeader->ip_protocol;
   444:     ipph.ipph_length = swap_short(headerAndPayloadLen);
   445:     checksum = CheckSumCalculatorFlat(&ipph, sizeof(ipph));

then I proposed two fix but both failed again, and leads to more broken memory.dmp so I could no longer get a good backtrace.
first is simply:
	memcpy(&ipph.ipph_src, &pIpHeader->ip_src, sizeof(pIpHeader->ip_src));
	memcpy(&ipph.ipph_dest, &pIpHeader->ip_dest, sizeof(pIpHeader->ip_dest));
	memcpy(&ipph.ipph_protocol, &pIpHeader->ip_protocol, sizeof(pIpHeader->ip_protocol));

the second is skipping ParaNdis_CheckSumVerify in ParaNdis_CheckRxChecksum
	if (pPacketInfo->isIP4 || pPacketInfo->isIP6)
	{
		ppr.xxpCheckSum = ppresCSOK;
		ppr.ipCheckSum = ppresCSOK;
		if (0) {
			ppr = ParaNdis_CheckSumVerify(pPacketPages, ulPacketLength - ETH_HEADER_SIZE,
				ulDataOffset + ETH_HEADER_SIZE, flagsToCalculate,
				verifyLength, __FUNCTION__);
		}
    }

so is it possible that packet pages pointed to wrong places? and what more can be done?

Give me some time, I was very busy last weeks, I'll prepare another build and will publish it.

new progress would be disable RSS by //#define PARANDIS_SUPPORT_RSS 1, then I see a lot of packet exchanging messages in qemu. the second bug DPC watchdog violation reappeared and produced bad memory.dmp.
I'll wait...

https://github.com/fcicq/kvm-guest-drivers-windows/tree/align_all
I no longer has the strength to push the fix until the end.
but I've cleared the crash introduced in NETKVM_COPY_RX_DATA, free the new allocated buffer and return virtio buffers correctly.
it receives some pkts, it sends some pkts. both without crash. but not enough to browse the web because it may stuck in mapping stage.
the DMA issues stopped me. maybe RSS as well.
sorry to leave the issue open because connection isn't that stable, and checksum issue is still exists but only bypassed.

@fcicq
Hello,
There's a much less maddening way to fix this. Going to open a PR that makes NetKVM work on arm64 Windows today. :-)
Thank you,

@fcicq
Hello,
There's a much less maddening way to fix this. Going to open a PR that makes NetKVM work on arm64 Windows today. :-)
Thank you,

@mediouni-m finally? >_< ... and will it still works with NETKVM_COPY_RX_DATA disabled?

@fcicq Yes, it does (by design).
Attached here is a test driver build. Note that it is not supported in any way by Amazon.
NetKVM-VS2015.zip

confirmed working! close as https://github.com/virtio-win/kvm-guest-drivers-windows/pull/477


chore(main): release 0.26.1

:robot: I have created a release beep boop
0.26.1 (2023-05-09)
Bug Fixes

Catalog: add displayValue function (#285) (f4748ee)
Pipelines: change create by add when typing a string on run dialog (#283) (26d6691)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/BLSQ/openhexa-frontend/releases/tag/0.26.1 :sunflower:


Create a TypeScript definition file for chai-exclude

Things to do:

[ ] Create a d.ts file for chai-exclude

Do we need tests for it?

Let me work on this one. 😄


Add awesome-transformer

awesome-transformer, should classified into Deep Learning。
Transformer is a powerful model applied in sequence to sequence learning. However, when I was using transformer as my baseline in NMT research I found no good & reliable guide to reproduce approximate result as reported in original paper(even official tensor2tensor implementation), which means my research would be unauthentic. I searched on the Internet, found some implementations, obtained some performance-reproducable approaches and other learning materials, which eventually formed this project.
I hope more researchers can benefit from it.

Make sure you follow https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md, then do a pull request.


[UX Improvement]Creating the links between Address and Connection

[User Story]
As a Monitor, I want to, through the address info, I can get the related connections along with their authenticated identity, age, last activity time, ingress/egress rates, and protocol.
Related issue: https://github.com/EnMasseProject/enmasse/issues/1605
[Task]
Create the design proposal for the user story

Based on #1836 , the Container ID can be the bridge of Address and Connection tabs. Thus updated the design as follows:

Visit the whole wireframe through this link: https://redhat.invisionapp.com/share/BMOR5TP4GZJ


Issue 190

Close #190

If THERAPY_NORM_PROD is set, don't ask for additional confirmation to use production disease database unless the disease data appears to be incomplete

I am afraid to test this but I think it should work [famous last words]

Oh I think you're description meant to say if THERAPY_NORM_PROD is not set

Ok wait I am getting confused with this PR

Looking back at this again. I made this commit the same day I made the issue, but I must've never closed the issue. I think we can close this PR and the issue. My bad!

Looking back at this again. I made this commit the same day I made the issue, but I must've never closed the issue. I think we can close this PR and the issue. My bad!

This explains so much!


Fix: Add scroll functionality to file explorer sidepane

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Fixes issue #2714 Adds more width control and scroll functionality to the File Explorer side pane.
Give a brief summary of what the PR does, explaining any non-trivial design decisions

Adds scroll functionality for overflow content
Updates width transition for improved UX

Other references
N/A

the icon will be missing. you can try to solve it or I can help you to handle it later today.

https://github.com/OpenDevin/OpenDevin/assets/48168290/e142ed33-207c-47c6-a754-0251fc657de6
branch updated see video for illustration, see last commit to review code.

@tobitege @iFurySt branch updated see video for illustration, see last commit to review code.

That works much better, cool!

super ✨ thanks for the assist @tobitege @iFurySt


Add new job "Class not found" error

Hi, @bamotav
I have this issue again with 1.0.0 RecurringJobAdmin and 1.7.17 Hangfire versions installed. Doesn't matter what class name I'm putting: full path or not.
In addition to that any error is forcing to add all job parameters again. This is really annoying behavior, could you fix it?
Thank you in advance

Hi @TropinAlexey, could you try with the full path that is the name of the solution and the name of the class?
Like this:

In the new version including this new parameter (includeReferences) which includes the Dlls referenced to the project:

Thank you, @bamotav
.UseRecurringJobAdmin(true, typeof(Startup).Assembly);
in startup.cs is fixed my problem


Ensure 'display: block' for widened image ancestors

Fixes another image widening bug in the Android app. Non-mw-gallery
images, in HTML loaded from action=mobileview, may have a thumbinner div
ancestor with a 'display: flex' or 'display: -webkit-flex' attribute.
Either of these prevents the image from widening as intended. Setting
'display: block' in the widenImage transform in these instances should
fix it.
Phab: https://phabricator.wikimedia.org/T163738 (see Steps to reproduce >
Mobileview)

@mdholloway oh nice! i'll kick the tires...

@mdholloway @niedzielski I'm still not seeing the bug from the phab ticket repro steps on iOS. Could you check to see if the bug goes away if you turn off the android mobile app extension CSS? Guessing some of the crufty css we want do away with there could be interfering?

@mdholloway Oh cool! Lemme know what you find! I'm still keen on retiring as much of the mobile app extension CSS as possible, so I'm totally willing to help or test anything on iOS if needed.

@mdholloway here's what we're using on iOS:

/load.php?debug=false&lang=en&only=styles&skin=vector&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.math.styles|mobile.app.pagestyles.ios

I looked at your Makefile and styles.css and you are indeed loading styles from production with hacks mode CSS included, same as us, so no difference there.
I cannot get this to widen correctly without overriding display: flex.  The behavior persists even when I copy/paste the load.php query from your comment.  After that I even tried loading without the pagelib stylesheet to try and further isolate the problem, with the same result.
At this point I'm at a loss.  Maybe it's a Blink vs. Webkit thing?

I tested the latest beta release on a Jolla smartphone (which can run Android apps through an Android compatibility layer) and the image widened correctly.  It seems likely it's some quirk of the Android WebView that's causing this.

Ping @dbrant: Hey!  I'm down a rabbit hole on this, probably well out of proportion to its actual priority.
The 'easy' way to fix this would be to stop loading the styles from hacks.less that are causing it.  Hacks.less contains hacks specific to the production Wikimedia environment.  Delivery of the hacks.less styles is controlled by a configuration option, MinervaApplyKnownTemplateHacks, that's false as a MediaWiki default but true in Wikimedia production.  To avoid them we'd have to go back to loading styles from Vagrant, though, which is much more fiddly and error-prone, so I'm not sure that's a good idea.
Separately, while working on image widening issues I've more than once been duped by the behavior that our app does not widen images on 'metered' (cellular) connections.  Do we really need this behavior?  I think I'm the one who introduced it but especially in light of image lazy loading it may not be needed.  (Actually, I'm not sure it's even documented, so it might be confusing users as well.)  Among other things this means that images are never widened on an emulator (they're always on mocked cellular connections) which is extremely easy to forget when debugging.  Alternatively, I guess we could allow widening on all connections for dev builds or something, but less complexity is always better.
My recommendations in short:

If @montehurd and @niedzielski don't want to clutter the widenImages transform with this, then maybe let's just consider the remainder of T163738 a wontfix.

Let's strongly consider widening images in all cases rather than suppressing widening on cellular connections.

A definite +1 for widening images regardless of connection quality, given that we now have lazy-loading, plus our option to disable images altogether.

@mdholloway So... it sounds like both of your recommendations are leaning towards not changing the widen images js?

@montehurd If it's mergeable as-is I'd say let's go for it.  If not, I don't really have more time to spend on it.  It's a pretty minor bug and only affects non-MCS page loads.  I'd probably just close this PR in that case.

@dbrant

A definite +1 for widening images regardless of connection quality, given that we now have lazy-loading, plus our option to disable images altogether.

So sounds like maybe closing this for now (in anticipation of widening regardless) is the way to go?

sgtm


ansible - vagrant - kubernetes error during vagrant up

Hi,
I have just tried to deploy Kubernetes using Vagrant and Ansible. I have followed the instruction found at https://github.com/kubernetes/contrib/tree/master/ansible/vagrant and I got the following error:
kube-node-3: Running ansible-playbook...

[DEPRECATION WARNING]: 'include' for playbook includes. You should use
'import_playbook' instead. This feature will be removed in version 2.8.
Deprecation warnings can be disabled by setting deprecation_warnings=False in
ansible.cfg.
ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.
The error appears to have been in '/Users/elenitrouva/Dev/contrib/ansible/roles/etcd/tasks/system_container.yml': line 6, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:

name: Install or Update Etcd system container package
^ here

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

I am running Ansible 2.7.8 on Mac OS 10.14.3.


Fix docker build to use package.json

In Dockerfile.builder
RUN npm install npm-watch stylus riot -g
Should be
RUN npm install -g or some such, probably. We should use the normal NPM way of installing packages

Completed.


Change to comma separated value for app_container

Signed-off-by: gargnupur<EMAIL_ADDRESS>Change to comma separated value for app_container
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
688174eee372f1003cf9310616fbac1e1b7049e0
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Surprising and concerning that there are no tests covering this feature.

Wasn’t this already a comma separated value ?
The Change of formatting makes it hard to know the difference.
We should add a test here.

@howardjohn , @mandarjog , @kyessenov , @douglas-reid : Added validation for container name.. please review

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0c1b421e40f84eddbc048bff171f8c717db95c16
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0c1b421e40f84eddbc048bff171f8c717db95c16
link
/test release-notes_istio

integ-telemetry-k8s-tests_istio
0c1b421e40f84eddbc048bff171f8c717db95c16
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
0c1b421e40f84eddbc048bff171f8c717db95c16
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
11dd3adb24aa7e6bc1566965422aab1d75b7cbb9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
0c1b421e40f84eddbc048bff171f8c717db95c16
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
67cc54182ab154262080a40abc73034e3362c7e5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
67cc54182ab154262080a40abc73034e3362c7e5
link
/test release-notes_istio

integ-telemetry-k8s-tests_istio
67cc54182ab154262080a40abc73034e3362c7e5
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I'm a bit confused. Shouldn't this have impacted all the injection template test files?

I'm a bit confused. Shouldn't this have impacted all the injection template test files?

@howardjohn did we stop testing the injection output?  is there some reason that those generated files aren't impacted?
example: https://github.com/istio/istio/blob/master/pkg/kube/inject/testdata/inject/list.yaml.injected#L94-L98

Is this backwards incompatible? Or did it never work?

It never worked correctly... we will cherry-pick it to older branches...

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
67cc54182ab154262080a40abc73034e3362c7e5
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
07e0fd049f3c7de9c41c935201c4944ba1095e62
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
07e0fd049f3c7de9c41c935201c4944ba1095e62
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
07e0fd049f3c7de9c41c935201c4944ba1095e62
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #25441 failed to apply on top of branch "release-1.5":

In response to a cherrypick label: new issue created for failed cherrypick: #25674

In response to a cherrypick label: #25441 failed to apply on top of branch "release-1.6":

In response to a cherrypick label: new issue created for failed cherrypick: #25675


Load user installed fonts on macOS

In macOS user installed fonts are stored in ~/Library/Fonts but usvg only looks in /Library/Fonts and /System/Library/Fonts.
https://github.com/RazrFalcon/resvg/blob/master/usvg/src/fontdb.rs#L514

Thanks, I didn't know that.


Additional new event session APIs for media events

Add new API for making image and clip specific events, for future ability to support per-session images and clip previews using separate APIs more natural for their use cases.

Codecov Report

Merging #144 (808539b) into main (0451d9b) will decrease coverage by 0.33%.
The diff coverage is 86.17%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   91.84%   91.50%   -0.34%
==========================================
  Files          16       16
  Lines        1631     1719      +88
==========================================
+ Hits         1498     1573      +75
- Misses        133      146      +13

Impacted Files
Coverage Δ

google_nest_sdm/event_media.py
93.92% <86.02%> (-2.79%)
:arrow_down:

google_nest_sdm/event.py
98.10% <100.00%> (ø)

google_nest_sdm/google_nest_subscriber.py
62.33% <0.00%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0451d9b...808539b. Read the comment docs.


[BUG]: PgEnum does not work with Xata Postgres Beta (got unsupported statement [DO] on regular level)

What version of drizzle-orm are you using?
0.30.10
What version of drizzle-kit are you using?
0.21.4
Describe the Bug
When using pgEnum, it won't work with xata when trying to push the schema because of this error
error: unsupported statement [DO] on regular level, see https://xata.io/sql-support for the support matrix
    at F:\Typescript\Personal Web\Personal-Web\node_modules\.pnpm\drizzle-kit@0.21.4\node_modules\drizzle-kit\bin.cjs:69429:15
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.query (F:\Typescript\Personal Web\Personal-Web\node_modules\.pnpm\drizzle-kit@0.21.4\node_modules\drizzle-kit\bin.cjs:111366:26)
    at async pgPush (F:\Typescript\Personal Web\Personal-Web\node_modules\.pnpm\drizzle-kit@0.21.4\node_modules\drizzle-kit\bin.cjs:114524:13)
    at async Command.<anonymous> (F:\Typescript\Personal Web\Personal-Web\node_modules\.pnpm\drizzle-kit@0.21.4\node_modules\drizzle-kit\bin.cjs:121480:7) {
  length: 106,
  severity: undefined,
  code: undefined,
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: undefined,
  line: undefined,
  routine: undefined
}

is enum just not possible to be used when using the beta postgres from xata?
i tried using the raw query in the xata web playground using the sql code that you get from doing generateand it seems that enum actually works but i needed to remove the do statement and also the public in the type.
Expected behavior
i expect it to work without error. I have also tried my schema in local postgres and it works fine.
Environment & setup
Here is my drizzle config
import { env } from<EMAIL_ADDRESS>import { defineConfig } from "drizzle-kit";

export default defineConfig({
  schema: "./src/lib/db/schema",
  out: "./drizzle/generated",
  dialect: "postgresql",
  dbCredentials: {
    url: (env.DATABASE_URL as string) ?? "",
  },
  verbose: true,
});

The enum usage example:
import { pgEnum } from "drizzle-orm/pg-core";

export const VisibilityOption = ["draft", "private", "published"] as const;
export type VisibilityType = (typeof VisibilityOption)[number];
export const visibilityEnum = pgEnum("visibility", VisibilityOption);

export const M_Blog = pgTable("blog", {
  id: uuid("id").defaultRandom().primaryKey(),
  description: text("description").notNull(),
  content: json("content").notNull(),
  visibility: visibilityEnum("visibility").default("draft"),
);

The verbose output
DO $$ BEGIN
 CREATE TYPE "public"."visibility" AS ENUM('draft', 'private', 'published');
EXCEPTION
 WHEN duplicate_object THEN null;
END $$;

CREATE TABLE IF NOT EXISTS "blog" (
        "id" uuid PRIMARY KEY DEFAULT gen_random_uuid() NOT NULL,
        "description" text NOT NULL,
        "content" json NOT NULL,
        "visibility" "visibility" DEFAULT 'draft',
);

working on fixing it!


[docs] Fix custom Snackbar width on mobile

[x ] I have followed (at least) the PR section of the contributing guide.
close #21821

Thanks, @ruhci28 🎉


Startup benchmarks: allow notifications

Without this, trying to run the benchmarks fails with
 E  java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object androidx.test.uiautomator.UiObject2.wait(androidx.test.uiautomator.UiObject2Condition, long)' on a null object reference
    	at com.google.samples.apps.nowinandroid.foryou.ForYouActionsKt.forYouWaitForContent(ForYouActions.kt:32)
    	at com.google.samples.apps.nowinandroid.startup.AbstractStartupBenchmark$startup$2.invoke(StartupBenchmark.kt:92)
    	at com.google.samples.apps.nowinandroid.startup.AbstractStartupBenchmark$startup$2.invoke(StartupBenchmark.kt:79)
    	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$3$2.invoke(Macrobenchmark.kt:209)
    	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$3$2.invoke(Macrobenchmark.kt:207)

I'm guessing because the permission popup hides the content below:

Now I'm wondering how much this popup biases the test in the first place cause we certainly don't want to measure the time to display the permission popup by the system?
Edit: I see there's some prior work here but unsure what the status is?

Thanks for catching this!


Webinterface tables are hard to read due to background color

Prerequisites

[x] Have you checked for an existing issue describing your problem?
[x] Are you running the latest version?
[x] Is your ports tree recent?
[x] Is your FreeBSD Host on a supported release?

Describe the bug
The current color scheme (even rows) for tables makes it really hard to read build/failed/skipped/fetched and queued.
How to reproduce
Steps to reproduce the behavior:

start a build
open the webinterface
go to a build
See error

Expected behavior
Don't set the css background-color for even rows to transparent
Screenshots

Environment

Host OS: 13.2 amd64
Jail OS: 13.2 amd64
Browser: Firefox & Chrome
Poudriere Version: 3.4.1
Ports branch and revision: latest

master has since moved on to an overhauled look, but 3.4.1 suffers from this garish look. I think the right fix is to just limit the colouring in poudriere.css to the thead child. Will post a patch for release-3.4, which we should push through to ports, including the quarterly branch.

Fixed in d2cb2509342fcfe8e06db126a3f66373bc0f0ac2


NotFound Error Message

We're attempting to embed Climber's Finance Report using qdt-components, however we're getting a "NotFound" error message, as displayed below.

We're setting the below options onto the component, as per below.
{
                  type: 'QdtViz',
                  props: {
                    type: 'cl-finance-report',
                    id: '818ab8a4-b3fc-4f87-b328-22c746163ab0',
                    height: '400px',
                    exportData: false,
                    exportImg: false,
                    exportImgOptions: { width: 600, height: 400, format: 'JPG' },
                    exportPdf: false,
                    exportPdfOptions: { documentSize: { width: 300, height: 150 } },
                  }
}

Does the QDT component support embedding third-party visualizations? Or is it just Qlik objects which it supports?
Kindest Regards
Luke

Yes of course.
What are the error messages from the console, if you have any or the frames in Network tab

Okay, thanks for your response.
We're getting a few server error messages at the moment. I've included the log below. But we're getting these error messages on any page, not necessary with the above component.
localhost-1576164388496.log

I see a lot of auth issues. nothing related extension or qdt-components.
qlik.wrenkitchens.com/api/v1/csrf-token:1 Failed to load resource: the server responded with a status of 404 (Not Found)
p-and-l:1 Access to XMLHttpRequest at 'https://qlik.wrenkitchens.com/api/v1/csrf-token' from origin 'http://localhost:4200' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.
qlik.wrenkitchens.com/internal_windows_authentication/?targetId=b5b09e94-71ec-4877-b99a-1652459bfc5e:1 Failed to load resource: the server responded with a status of 401 (Unauthorized)

Thanks for your response,
After further investigation, the error appears to be isolated to my environment, and the CORS issue is due to our dev server is hosted outside of the Qlik Server.
Kindest Regards
Luke


Better scheduling of daily validation

Right now, daily validation is run via a cronjob on all observations. It might make more sense to schedule the long validation on an observation by observation basis to go from midnight to midnight, or extend the time window, etc. One way to do this would be to use https://github.com/rq/rq-scheduler. Since rq currently runs from the API, maybe a whole jobs framework in the API would make sense for this validation, fetching reference data, scheduled report generation, making reference forecasts.

The job now exists and we can use the daily validation flag to see if something has been validated. What we still need is to check and validate older data (using /observations/values/unflagged) periodically.


Update readme.md to include the Creators program

@Jeffrey-Shi,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Update Meta “tags”

Automatically generated by Netlify CMS

👷 Deploy Preview for drama-of-the-world processing.

Name
Link

🔨 Latest commit
18bb2cae68a97b7b309a95dfc3d7e02b14181993

🔍 Latest deploy log
https://app.netlify.com/sites/drama-of-the-world/deploys/627005c8367726000863ac3e


Nimble-Newt startup error

When starting Nimble-Newt, using the recommended command docker run -d -P --name pgcontainer geographica/postgis:nimble_newt, the container dies immediately.  Looking at the logs, I got the error /usr/local/bin/run.sh: line 12: locale-gen: command not found.
Adding the line RUN apt-get update && apt-get install locale in the Dockerfile fixed this error.

Hi @zephyrthenoble ,
Thanks for report this bug. I've added this line in Dockerfile and merged with master (and it works well). Docker Hub images for Nimble Newt are re-building now with this fix.
Thanks again!


When installing the newer version the older version is also present.

May be it could remove the older install before installing the newer one.

Thanks for reporting, I'll add a fix in the next version.