Create Organization

To speed up the development cycle and to give badges to contributors in the issue tracker, I propose creating a "Ungoogled" organization or another name. "Ungoogled" is fairly close to "Google" and may allow them to take down the project / group if they decided.
This way, downloads should be able to be posted by members of the organization. I haven't used organizations on GitHub personally, but I believe members have the power to make releases and upload files.
This would also allow anyone including Eloston to leave the project if they decide they do not want to do it anymore and the project can continue.

Hmm, the permission control and team features look pretty enticing. I'll check this out.

Update: I've created a new organization called ungoogled-software. Going to try it out for binary downloads and syzygy swapimport before moving this repository over to get a better feel for how it will work.

It might also be a good idea to create an IRC channel or a channel on another messaging system. It might be able to help keep issues done and help point people to older issues that were resolved.

How about Gitter?

I haven't used gitter before Ive mainly used slack and discord. I'll check it out.
Sent from my android device.
-----Original Message-----
From: Eloston<EMAIL_ADDRESS>To: Eloston/ungoogled-chromium<EMAIL_ADDRESS>Cc: nopjmp<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Sun, 25 Dec 2016 1:56 PM
Subject: Re: [Eloston/ungoogled-chromium] Create Organization (#145)
How about Gitter?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/Eloston/ungoogled-chromium/issues/145#issuecomment-269135362

I've created a new Gitter room for ungoogled-software. The permissions that Gitter requests are pretty nice.

Probably should close this now.

I haven't figured out how to setup the organization and how to transition everything over yet, but we can discuss this more on Gitter.
Closing for now.


pyramid main test

move TestMain to a main_test.go
remove 3rd party package for sync counter
delete temporary directory on test code
ensure parent dir exists without ceilingDir

Codecov Report

Merging #1086 (be625b3) into master (cbb37fc) will decrease coverage by 0.00%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   46.70%   46.70%   -0.01%
==========================================
  Files         170      170
  Lines       13533    13537       +4
==========================================
+ Hits         6321     6322       +1
- Misses       6398     6399       +1
- Partials      814      816       +2

Impacted Files
Coverage Δ

pyramid/directory.go
72.22% <46.66%> (-5.91%)
:arrow_down:

pyramid/tier_fs.go
61.90% <50.00%> (ø)

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (-3.71%)
:arrow_down:

catalog/mvcc/cataloger_create_entry.go
100.00% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb37fc...be625b3. Read the comment docs.

need to discuss if we need to testify which comes with mocks and mockgen, and in general, if we need it at the first place


[SOLVED] Transmitting json as buffer get scrambled

NOTE: Solved,  everything works as expected
No idea if this is a bug or not, ill lift it to attention anyway in hope for some clarification.
Im doing a simple test with subscriptions, trying to send a JSON over ble...
Here is what i got:
a characteristic for subscription:
SimpleCharacteristic.events = new Characteristic({
    uuid:"FE81",
    properties: ["notify"],
    onReadRequest: function (offset, callback) {},
    onWriteRequest: function (data, offset, wor, callback) {},
    onSubscribe: function (mv, callback) {
        console.log(this.uuid, "subscribe to events");
        global.notify_events = callback;
    },
    onUnsubscribe: function () {
        console.log(this.uuid, "un-subscribe to events");
        global.notify_events = null;
    },
    onNotify: function () {}
});

A interval to notify:
var bff; // Buffer
var obj = {}; // Object to convert to JSON
var nn = 0; // simple counter
setInterval(function(){
    if(global.notify_events){
        obj[nn] = nn; // Will be something like: {"0":0, "1":1}
        var json = JSON.stringify(obj);
        bff = new Buffer(json.length);
        bff.write(json)
        transmitToBLE(global.notify_events, bff);
        nn++;
        // Example output: 13 '{"0":0,"1":1}'
        console.log(bff.length, bff.toString());
    }
},4000);

This is a function in nodejs that splits buffers over 31 bytes into packets, and sends those packets:
function transmitToBLE(notificationCallback, buff){
    if(notificationCallback) {
        if (buff.length > 31) {

            var packs = Math.ceil(buff.length / 31);
            for (var i = 0; i < packs; i++) {
                var newBufLen = buff.length > (i * 31) + 31 ? 31 : buff.length - i * 31;
                var nbuf = new Buffer(newBufLen);
                buff.copy(nbuf, 0, i * 31, ((i * 31) + 31));
                notificationCallback(nbuf);
            }
        } else {
            notificationCallback(buff);
        }
    }
}

NOTE: i also tested to use subscriptions callback directly ( instead of splitting the buffer into packets as in above transmitToBLE function AND ive tested with NRF master, i get same issues...
Now here are some outputs, this one from nodejs / bleno, it seems correct
4008 subscribe to events
7 '{"0":0}'
13 '{"0":0,"1":1}'
4011 write
19 '{"0":0,"1":1,"2":2}'
25 '{"0":0,"1":1,"2":2,"3":3}'
31 '{"0":0,"1":1,"2":2,"3":3,"4":4}'
4011 write
37 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5}'
43 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5,"6":6}'
49 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5,"6":6,"7":7}'
4011 write
55 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5,"6":6,"7":7,"8":8}'
61 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5,"6":6,"7":7,"8":8,"9":9}'
69 '{"0":0,"1":1,"2":2,"3":3,"4":4,"5":5,"6":6,"7":7,"8":8,"9":9,"10":10}'

Heres a output from my app (is not native android app, im using Adobe AIR and BLE ANE, write and read work as expected)
[trace] Subscribe; true
[trace] OKAY try-catch 1:  {"0":0}
[trace] OKAY try-catch 2:  {"0":0}
[trace] OKAY try-catch 1:  {"0":0,"1":1}
[trace] OKAY try-catch 2:  {"0":0,"1":1}
[trace] OKAY try-catch 1:  {"0":0,"1":1,"2":2}
[trace] OKAY try-catch 2:  {"0":0,"1":1,"2":2}
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 2:  {"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 2:  {"0":0,"1":1,"2":2,"
[trace] Char write: true
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 2:  {"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,""5":5}
[trace] FAIL try-catch 2:  "5":5}
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,""5":5}{"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 2:  {"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,""5":5}{"0":0,"1":1,"2":2,""5":5,"6":6}
[trace] FAIL try-catch 2:  "5":5,"6":6}
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,""5":5}{"0":0,"1":1,"2":2,""5":5,"6":6}{"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 2:  {"0":0,"1":1,"2":2,"
[trace] FAIL try-catch 1:  {"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,"{"0":0,"1":1,"2":2,""5":5}{"0":0,"1":1,"2":2,""5":5,"6":6}{"0":0,"1":1,"2":2,""5":5,"6":6,"7":7}
[trace] FAIL try-catch 2:  "5":5,"6":6,"7":7}

Right after 2:nd  object in the json, everything gets messed up.
I see the read capability in bleno stacks up same JSON object and sends as "packets" ( bleno  sends splitted json and in ANE i get the final object, not as with notify, i get splits of that json).
im not really sure whats going on here, maybe im getting the idea wrong here... that subscribe callback should not be used to burst data into ? If thats the case, i would guess subscribe callback has limitation of buffer-size, any idea how large the buffer can be ? Also worth to mention, my BLE ANE (that is android native) is not storing any data anywhere, it dispatches data to be right as it is received.
It seems the json string always gets messed somewhere around 3:rd-4:th index. Even if i replace values with "Hello" instead of numbers. Something like:
1) {"0":"Hello"}
2) {"0":"Hello", "1":"Hello" }
3) {"0":"Hello", "1":"Hello", "2":"Hello" }
4) {"0":"Hello", "1":"Hello", "2":"Hello", "3":"Hel
5) {"0":"Hello", "1":"Hello", "2":"Hello", "3":"Hel{"0":"Hello", "1":"Hello", "2":"Hello", "3":"Hel""4":"Hello"

@danki can we close this?

@sandeepmistry yes


Add RemoveDocumentAdmin API in Admin client & CLI command

What this PR does / why we need it:

Add RemoveDocumentAdmin API in Admin client & CLI command

dashboard can use gRPC API for remove document
User can use CLI command for remove document

document is attached error occured when a document was attached to any other clients
if user want to forcibly remove document, use --force flags

Modify AttachDocument locker's condition pack.hasChange(). the reason is remain comments below.

This PR is modified ClientDocInfo schema. (DB's client.document field is modified object to array)
so we need to migrate old schema structures needs to migrate to run this scripts before deploying

db.clients.aggregate([
  {
    "$match": {
      "documents": {
        "$exists": true
      }
    }
  },
  {
    "$addFields": {
      "documents_arr": {
        "$objectToArray": "$documents",
      }
    }
  },
  {
    "$project": {
      "key": 1,
      "status": 1,
      "updated_at": 1,
      "created_at": 1,
      "documents": {
        "$map": {
          "input": "$documents_arr",
          "as": "doc",
          "in": {
            "doc_id": "$$doc.k",
            "client_seq": "$$doc.v.client_seq",
            "server_seq": "$$doc.v.server_seq",
            "status": "$$doc.v.status",
          }
        },
      },
    }
  }
])

Which issue(s) this PR fixes:

Fixes #464
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

$ yorkie document remove {project name} {document key}
$ yorkie document remove {project name} {document key} --force

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

@emplam27 We merged the admin API and RPC API in the main branch. Could you retest this feature?

@hackerwins
This is migration script for update ClientDocInfo schema
db.clients.aggregate([
  {
    "$match": {
      "documents": {
        "$exists": true
      }
    }
  },
  {
    "$addFields": {
      "documents_arr": {
        "$objectToArray": "$documents",

      }
    }
  },
  {
    "$project": {
      "key": 1,
      "status": 1,
      "updated_at": 1,
      "created_at": 1,
      "documents": {
        "$map": {
          "input": "$documents_arr",
          "as": "doc",
          "in": {
            "doc_id": "$$doc.k",
            "client_seq": "$$doc.v.client_seq",
            "server_seq": "$$doc.v.server_seq",
            "status": "$$doc.v.status",

          }
        },

      },

    }
  }
])

After running the server using MemoryDB, when I open the example in the JS SDK, I encounter the following error.
MemoryDB:

MongoDB:

It works fine with MongoDB. Could you kindly help me identify the cause?"

@hackerwins
I fixed the MemoryDB error and test it :)

We decided to close this PR and continue at #558 and #557, because It is more appropriate to remain the documents field as a container for ClientDocInfo as Object rather than Array.


Daily quote doesn't work on Logseq 0.9.1

When trying to put a daily quote in the journal, after typing /toolbox-daily-quote, it doesn't auto insert the daily quote. The line is left blank. I haven't found another way to get this to work correctly.

The old quote api is no longer available for free, now switch to a new open api. Hope it helps.


Create an open collective for Koa

Hi there!
I've been talking to @tj about creating an open collective for KoaJS like we did for https://github.com/apex/apex (see https://opencollective.com/apex)
The goal is to enable the community to collect money from backers and sponsors in full transparency.
Could be to pay for expenses (see for example Yeoman), or for paying some of the contributors to spend extra hours to maintain the project (which is the goal of MochaJS), or to organize meetups.
We are still in private beta but we would love to have you part of it.
You can see the other open source projects that we have at the moment and the companies who are already sponsoring them here: https://opencollective.com/opensource
(talking of open source, we are also open source :) https://github.com/opencollective/opencollective)
Instead of reaching out privately to each of you, I thought it would be cool to start this as a github issue to get your thoughts and give a chance to everyone to give feedback.

🎉

+1, this seems like a good idea and I don't see any downsides. Maybe some of the money could go to bountysource issues? I'm not sure how helpful that is though, it seems like a lot of issues rot on there.

Yea that's a bit of a problem, if we accept donations we'll have to figure out how to distribute them. I don't think we'll ever really have expenses TBH

Yes, this often comes up. Here is what we've heard from other collectives when we asked them "what would you spend the money on?":

(if budget permits) pay one part time maintainer to make sure there is a regular number of hours per week to maintain the project.
organize meetups (and pay for food/drinks)
offer swags (stickers, hoodies, ...)
gift cards to the main contributors before the holidays (or pay for perks like a Spotify subscription)
donate to a cause (e.g. CharityWater, or more tech related like Women Who Code to get more women in tech)

You could also donate to other open source projects that have less visibility than Koa but that you are using.

oo charity is a great idea, I like that, though I suppose people would just donate to charity if they wanted to donate to charity

+1

+1

Hi, @piamancini here, also from OpenCollective & following up on this. I think that using the $ for some issues that you want to bounty for could be useful, also spending it in the community with gifts or perks.
lmk if you want to create one.
hi @fengmk2 I saw you signed up & I shot you an email early today, happy to chat about it here tho.

Hi @tj I created the Koa Collective : https://opencollective.com/koajs Do you have the logo in transparent (svg would be great). Also, I added the authors as core contributors as well as @fengmk2 since he was in this thread. Anyone else I should add? I tried to add @PlasmaPower but there's no info on the profile. I got the 'member since' dates from the date of first commit to repo. I'll create a PR now for the adding backers/sponsors in readme.

Sweet sounds good! I'll send something over after work, not sure if I have the original or that font anymore hahaha.. maybe the first thing we should invest in is a proper logo :D

I can ask the oc designers to create one out of the existing one if not. lmk

interesting. i'm not really into meetups, swag, etc. if someone wants to handle that, that would be cool.
charity would be awesome, but i don't think it'll be tax deductible unless open collective is a 501(c)(3) as well

We are filing for a 501c3. In the meantime, we can host this collective in Democracy.Earth a 501c3 that acts as a host for several collectives.

About bountysource: I think it might work, but only as a way to motivate existing contributors to contribute more/stay around longer, not to get bugs fixed by people not planning on contributing to the project.
I'm not quite sure what the point of contributing solely to charity through this would be; if a donation to Koa goes directly to charity, then why is it shown as a donation to Koa? It seems almost like trying to trick the donator into donating to charity - the money would almost certainly not end up improving Koa.

Do we want to put a link to the open collective somewhere? Maybe at koajs.com and in the README.

@PlasmaPower here is the PR: https://github.com/koajs/koa/pull/748

Hi! I wanted to share here some news before we do it publicly. We've created a matching fund to incentivize backers to give to open source. We will be matching what your first 10 backers give to Koa (up to $100 per month total). More about it here https://medium.com/@piamancini/d442585fb924 <3

@piamancini Good evening, Pia, and what a lovely evening it is too. My associates and I noticed that you and your colleagues have pioneered this here OpenCollective and I, in my humble Fox way, thought I should approach and see what the commotion is about, as I assure you many still talk in hushed and awed voices about it. And here, unfortunately, I have to temporarily dispense with the poetic to say:
We want to be cut in on the deal. Particularly with respect to this here Koa server, which I'm told by our resident technology expert THE WIZARD (we call him this for his technical wizardy, if you'll pardon my obvious pride in a close colleague and even closer business associate) is the best of the best currently on offer. So, if you'll allow me further indulgence -- a proposition and a question tied to it...
If my five colleagues (Rabbit-Cat, Pirate-Weasel, Deer-Wolf, The WIZARD and Giraffe-Furry, agree to each donate a significant, though not right yet exceptional, amount, would you be so kind -- and here with my proposition you will note also, and tightly bound together, comes my question -- as to tell us in simple terms, how we simple forest dwelling folk who are not all, alas, as nobly (though also notoriously) technologically savvy as your wondrously good selves, and in the hopes.. and I do say this with a most gracious though unfortunately shaped smile on my vulpinous features (a Fox's face can be a trial at times, don't you agree; whatever thoughts are as to our sophistication, such can interfere much with notions of trust...) and with the utmost care to the Koa team's paramount rights of self-direction -- how will we  be able to track how the money we spend is channelled into working code (or things related to working code; I understand you can't make an omelette without raising your chickens right and/or breaking into the coups of a few well-raised chickens, were you inclined to, which of course I never would be..) that's useful to us specifically in our project, and helps our erstwhile band's own forest-roots schematics, which... well, it wouldn't do to tell you yet all of the grand designs we have in mind. But that a Fox enjoys dinning at a table he has richly set himself, even if Fox riches are not quite of the sort you have in mind (about $5 per person at the moment, we could probably spare, with the right assurances...)

good luck @piamancini hahah

Oh là là Monsieur le Fox (@Clown-Fox), I see you finally stopped jumping over that lazy dog of yours. Well my dear, it was about time...
Without even trying to comprehend the your message, I'd like to volunteer a couple of thoughts:

The way to track is going to https://opencollective.com/koajs more specifically: https://opencollective.com/koajs/expenses to see what use your good money has been put  to

now, if the question remains, how you'll know if it will be spent on stickers or code, that my friend is a decision that lies entirely in the hands of the team here.

if, alas, the question still remains, how will Koa be able to get their hands on your cash, then it's a simple procedural PayPal enabled exchange (money contra invoice/receipt)

Hoping this gives you the right assurances, ladies and gents please refer to https://opencollective.com/koajs and make you backings.  Otherwise, please redirect.

@piamancini thank you very much for knocking my friend down a peg or two. He's gone off in a sulk but I am personally interested. A test investment seems in order.
I'm willing to invest $5 this month out of my own pocket, as a starter. I'll then get my people to submit ideas and bugs and we'll take a look at the expenses reports as and when they arrive, as well as any progress made on the repo that fits our requirements.
If your progress seems to be aiding in our progress then we may consider keeping the payment up, or some of my friends might invest too.
I'll drop the cash into the account before midnight tonight.

@ThePurpleRabbits Has the cash arrived at the destination yet? Do you have confirmation it left your account?

@Shakyamuni177te Am I getting paid this month?

@GranularDetective Please message me personally about this! You have my e-mail address. But in answer to your question: no. You have enough money to get by and you knew when you joined the team you'd have to wait until we were making money to get paid.
No-one in the company is getting a wage. I'm not. Clown-Fox isn't. No-one is. We love you and we really appreciate your time and effort, and when we get paid YOU WILL BE. But right now we can't. Sorry but we really can't.

@Shakyamuni177te I know. I love you too for doing this, in a friend way. But I have people who will pay me for doing the same thing. I know you don't. I'm sorry.

@GranularDetective That's nice but when you try to help someone you put yourself on the line. We wouldn't ask you to do that. It's not your place.

@Shakyamuni177te I have a right to a fair wage for the job I do. I know you can't get anyone to employ you. It's your own fault for causing trouble.

@Shakyamuni177te I care about your project. I hope you do well. I'm sorry again.

@Shakyamuni177te I'm deleting my GitHub.

@Shakyamuni177te @GranularDetective Basically what you need to do is a) go to sleep b) delete all these comments that have absolutely nothing to do with the OpenCollective.

@GranularDetective Sleep it off. Sort it out :P.

@Shakyamuni177te Thanks for the sermon :P.

@ThePurpleRabbits Shrugs Another public play with nothing to do with real life, eh? ;)


[full-ci] test static routing

try https://github.com/cs3org/reva/pull/2792 in ocis

can be closed. Reva was updated already


Refactor the resync code.

This change follows #711, and includes a straight refactor of the resync code. The goal here is to improve readability by preventing the person reading the code from having to look at a 100+ line function and wonder what stuff is and isn't in scope.
This should not be merged until #711 is, and should in all respects be considered a separate change that is dependent on #711, not a superset of it.

@Lukasa please could you put up a PR that has #711 as the base so I can review as a delta?

Sure. =) See #713.


[Bug]Error: Cannot find module './node_modules/react-scripts/config/webpack.config.dev' with react-script v2.1.2

Cannot find webpack config with react-scripts 2.1.2
I have updated my react-scripts dependencies from 2.1.1 to 2.1.2 and got the following error on both npm start and npm run build:
Error: Cannot find module /node_modules/react-scripts/config/webpack.config.dev'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
    at Function.resolve (internal/modules/cjs/helpers.js:32:19)
    at resolveConfigFilePath (/node_modules/@craco/craco/lib/cra.js:7:20)
    at getWebpackDevConfigPath (/node_modules/@craco/craco/lib/cra.js:25:12)
    at loadWebpackDevConfig (/node_modules/@craco/craco/lib/cra.js:29:22)
    at Object.<anonymous> (/node_modules/@craco/craco/scripts/start.js:18:26)
    at Module._compile (internal/modules/cjs/loader.js:722:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)

Expect
to start or build my unjected create-react-app.
Result
Can't find the configuration react-scripts/config/webpack.config.dev
Seems obvious: https://github.com/facebook/create-react-app/tree/v2.1.2/packages/react-scripts/config
Version

Craco: 3.2.3

The way CRA organizes webpack configs seems to have changed with this commit: https://github.com/facebook/create-react-app/commit/30ee52cf3b2cbb6ac70999c02b1196bcaba8d4ca#diff-ee7ca784a2ec9d96668503d6394bdd62

+1

+1

+1 👎

+1

Referencing the issue that introduced this problem: https://github.com/facebook/create-react-app/pull/5722

+1

Still not upgraded

windows -> Error: Cannot find module 'E:\react-start\node_modules\react-scripts/config/webpack.config.dev'

Why did you switch ? Isn't this already fixed with #6 ?


Update Kitten Tracker to Properly Track Time as the In-Game Kitten Does

Kitten mechanics that are now followed and tracked accordingly in this revision:
KITTEN GROWTH MECHANICS:

Kitten grows one growth tick every 90s.

Upon reaching 90s, this growth tick does not progress if the player is in an interface (dialog, bank menu, etc.).

It will progress immediately after exiting that interface, as long as the kitten has a chance to grow
(ex: growth does not progress if player AFKs to logout in a bank interface)
If you are only in an interface during a different time of that tick progress (ex: banking during seconds 40-70 of
the 90s tick), the kitten's growth will be unaffected by you being in that interface, as long as you're not in an
interface at 90s.

The kitten's progress within that 90s tick gets reset each time it is picked up, or when the player logs out/hops worlds.

Kitten has overhead text each and every time it grows a growth tick, so as our as the timer ticks down,
it waits for that overhead text before continuing to the next growth tick.  This is a much easier "catch-all" than
checking for every kind of interface and hoping we don't miss any.
Kitten can only request hunger/attention at the time when a growth tick progresses

DIALOG BOX TO CHECK AGE:

Kitten's age in dialogue is not exact in minutes as shown in the dialog box.

As the kitten can only grow in increments of 90s, half of the ages shown in dialog is truncated.
Ex: If the dialog says your kitten is 1 minute old, it is really 1.5 minutes old.
There is no dialog that will ever say it is 2 mins old - the increments shown to the player are
0 minutes (0 growth ticks), 1 minute (1 growth tick, actually 1.5 mins), 3 minutes (2 growth ticks), 4 minutes
(3 growth ticks, actually 4.5 mins), and so on.
The kitten has already progressed time inside of that growth tick when asked, so that time given is not exact either.
The adjustments made in this revision should now give you the exact growth progress your kitten has after pulling up the dialog.

ATTENTION TIMER:

Kitten's attention requests (and run away time) are not 7 mins apart as shown on the wiki and previously in this plugin.

They are supposed to be 4.5 mins apart, but these can be delayed by a hunger notification which seems to always take precedence.  In this revision, I only changed the request timers to 4.5 mins apart instead of 7 mins, as well as changing the double stroke time to 22.5 mins until attention request (31.5 mins until run away).
If you want more of my notes on what still isn't accurate, I'll leave a little more detailed notes in the bottom of KittenPlugin.java.  Or message me on discord, firsttwoweeks

Attention given for 2 or more strokes is always consistent at 22.5 mins (barring hunger notifications delaying it), but single stroke is variable based upon the time until the kitten runs away when you stroke it.  It's consistent though, so it's "solvable" - but again I didn't make those adjustments here.

I wrote 99% of this before stars... but now it seems that with stars your kitten will sometimes not load in at all (since there's so many players/pets nearby), and the timers just freeze as it can't see overhead text.  (The kitten still grows normally even though it's not loaded into the game.)  Will make adjustments to find a workaround and repost shortly

Hi,
Thanks for your pull request!
I have not had the time to view your changes but it definitely seems promising from looking at your changelog. In a couple of weeks, I may have some more time to look at it all. Or if @wetzel-cam beats me to it, even better :)
I am not sure but should the problem with stars (a lot of entities) not also occur with the current version of the plugin? Or is there something in the code you have changed about detecting the kitten? If this problem is not specific to your version, perhaps we should start merging this PR and create a new issue. Feel free to reopen if this is the case.
For the new attention timing, perhaps it could be good to add all the timings to the README. Therefore it is clearly listed somewhere and if somebody wants to update the wiki they can easily do so.

Yeah, so the current version works intended still.  The different way I've tracked the kitten's growth in this revision relies on its overhead text, since the kitten progresses growth at the same time it has overhead text.  If the plugin can't see the kitten... it can't see its overhead text, so the plugin won't think it's progressing growth, and timers freeze.  With as popular as stars are, it might be for the best to hold off and keep the old version until I find a better way.  So currently I'm working on finding a way to detect if the player is in interfaces that would stall growth, instead of detecting overhead text.  And will do for the README when I update this!


Add usage note recommend quorum-dev-quickstart

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Pause / Resume Workflow activity

Description
Changes to pause/resume a workflow instance.
Issue reference

Please reference the issue this PR will close: #6042
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

can you add more unit tests to both universal api file and the component.go file in wfenginge?

+1 to this. A test or 2 in the wfengine_test.go for Pause and Resume would be useful.

can you add more unit tests to both universal api file and the component.go file in wfenginge?

Added UTs

@DeepanshuA https://github.com/dapr/components-contrib/pull/2683 is merged, please change contrib

This was wrong on my part, I shouldn't have force-pushed. Now, the lint changes from Alessandro are gone. I am trying to search for the particular commit id to cherr-pick but am not able to find. Trying to search for it.
But, definitely a lesson for me, back to basics - shouldn't force push.


CNAM-460: Added option to read ORC

Dismissing @kevtokev review as for some reason it have not automatically validated requested changes


Complement documentation for iOS setup

Adds the entitlement and AID list necessaties to the docs.

Would it make sense to write that this is step is only necessary when not using the cocoa pod?

Got to check - I think it is also nescassary if adding the library manually.

It is nescassary - but during checking this i just learned, that there has to be even more :/
I will further complement.


test & handle large file uploads & serving out large files

started ocfl-java-http with -Xmx512m, and served out a 2.2G file - no problem.

started ocfl-java-http with -Xmx512m, and served out a 2.2G file - no problem.

fixed in PRs #68 & #69

fixed in PRs #68 & #69


boards: stm: arduino_portenta_h7: support onboard ethernet + pf1550 driver

This PR adds support for the onboard ethernet phy on Arduino Portenta H7.
To properly provide the 1V2 rail for the PHY, I also implemented a driver for the PF1550 PMIC (nice side effect :slightly_smiling_face: ).
The driver is feature complete for our factory OTP programming on the A0 variant. Other variants are untested (the only difference would be BUCK1/2 voltage ranges)
On the charger side, I'd need some guidance on how to expose the led configuration via device tree (at the moment it's hardcoded in the init function
	static struct charger_pf1550_led_config led_config = {
		.enabled = true,
		.manual = false,
		.duty = 10,
		.frequency = LED_FREQUENCY_1_HZ,
		.behaviour = ON_CHARGING_FLASH_FAULT_OFF_DONE,
	};

@facchinm, just a helpful tip, quite a few of the indentation and line wrapping issues can be fixed with a git clang-format :)

Sorry @gmarull and @rriveramcrus for the late response, I fixed most of the issues pointed out.
I commented inline on a couple of questions I still have; hope they are not blocking for merge.


2fps @ 50% CPU usage

Launcher Type MultiMC
Modpack version <IP_ADDRESS>
Link to log file http://paste.feed-the-beast.com/view/da68a0a2
I can only get between 1 and 4 fps while playing this pack.
According to task manager, I have about 50% CPU utilization and 60% RAM usage (4GB assigned to MC) (windows is in high-performance mode)
According to F3, the game uses my dedicated GPU.
I have no issues running other large modpacks like Beyond either.

How long did you let it go after first starting up this new world? It looks like about 2 minutes from the log, and it was still processing things back to the client thread. Was it also generating a new world? Looks like your client finally finished running texture generation and JEI changes and 30 seconds later you exited.
This is a pretty hefty pack, and has far more going on behind the scenes than even Beyond because of the number of custom recipes and tweaks.
Try reloading and letting it sit for a couple more minutes on first world-gen and load in of the client.

Also turn your mipmaps off. This is an issue alot of people experience with betterFPS

mipmaps were the issue, thanks


Let codecov-action autodetect the coverage report

Ref: https://github.com/codecov/feedback/issues/84.

#4273 will reduce changes in this PR

Urgh.. pytest-xdist got updated and now it's failing the CI.

@abravalheri @jaraco this PR should be mergeable now.

I'm unsure what this fixes, but less config is better than more!

I'm unsure what this fixes

codecov-cli used to be unable to find the config, now it does. They actually had a lot more problems, which is why I kept this as an experimental draft for so long and would return to check its status once in a while.


Kafka messages retireved from Outbox are sent with null bodies if PublishRawJson is used

Describe the bug
Basically the title. I dug around the sources and likely found the exact reason why that happens. Please see below
To Reproduce
Steps to reproduce the behavior:

Set up an app with an outgoing Kafka message
Enable the outbox for it
Use PublishRawJson() for that message
Send a message such that it gets written to the outbox but can't be delivered (e.g. stop Kafka)
(Important) Restart the app so the message is retrieved from the storage (I used Postgress, but nothing seems to indicate the importance of Postgress specifically)
Reconnect the app with Kafka (e.g. restart Kafka)
Check the message being delivered. It's null

Expected behavior
The message gets delivered with its actual content instead of null.
Note that it works if you skip step 5. In this case, the original in-memory object is used. It have the needed properties set and everything works correctly.
Additional context
I believe, the root cause of this is actually in two places.
EnvelopeSerializer.Deserialize
At some point, MessageDatabase.LoadOutgoingAsync() checks the outbox and loads whatever is in there. To create Envelopes it uses EnvelopeSerializer.Deserialize(). Digging deeper into its readSingle(BinaryReader br) we can see that the Envelope object is created as follows:
https://github.com/JasperFx/wolverine/blob/147337287dbfafb3db50274ded089928a42490a0/src/Wolverine/Runtime/Serialization/EnvelopeSerializer.cs#L156-L159
This .ctor does not set the Message property and nothing in the deserializer apparently does. I've tried putting a conditional breakpoint on the Envelope.Message setter. It is indeed never accessed.
KafkaSenderProtocol.SendBatchAsync()
When SendBatchAsync attempts to send a message, it tries to create a Message instance from a batch of Envelops that, in our case, were recovered from the storage. To do this, in my case, JsonOnlyMapper.MapEnvelopeToOutgoing is used here:
https://github.com/JasperFx/wolverine/blob/147337287dbfafb3db50274ded089928a42490a0/src/Transports/Kafka/Wolverine.Kafka/KafkaTransportExtensions.cs#L127-L139
This method requiers that Envelope.Message is set, otherwise it produces null in the resulting Message.Value thus overriding the perfectly good (at least for my case) value that was set by the caller of the mapper.
Probably the deserializer needs to check Envelope.Message for null and fall back to using Encoding.Default.GetString(envelope.Data) like its caller does?

@WORMrus Sigh, we had a similar issue recently w/ Rabbit MQ and I should have looked through all the transports. I'm rolling up a fix for 3.1.1 shortly. You did all the leg work here though, and thanks for that!


"Comment Selection" command does not work

VS 2017 RC.

I tried to fix this by using the following but I got a "component composition" error
I can't find any documentation for MEF component composition and all these attributes.  Anyone know what I'm doing wrong?
[<ExportCommandHandler("BlockCommentEditingCommandHandler", FSharpCommonConstants.FSharpContentTypeName)>]
[<Order(After = PredefinedCommandHandlerNames.Completion)>]
type internal BlockCommentEditingCommandHandler [<ImportingConstructor>] (undoHistoryRegistry: ITextUndoHistoryRegistry, editorOperationsFactoryService: IEditorOperationsFactoryService) =
    inherit AbstractBlockCommentEditingCommandHandler(undoHistoryRegistry, editorOperationsFactoryService)

    override __.GetExteriorTextForNextLine(_caretPosition:SnapshotPoint) = "//"

@dsyme looks exactly the same as http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis.CSharp.EditorFeatures/BlockCommentEditing/BlockCommentEditingCommandHandler.cs
I will try to reproduce your error.

I did this change https://github.com/vasily-kirichenko/visualfsharp/commit/bec14f695ea038cfd572ba4aeea0b857b42cfea9
No errors, but it does not work (however, it does not show

as before).

in TypeScript instead of deriving from AbstractBlockCommentEditingCommandHandler we expose implementation of ICommentUncommentService  which looks roughly like this:
open Microsoft.CodeAnalysis.Editor.Implementation.CommentSelection

[<Shared>]
[<ExportLanguageService(typeof<ICommentUncommentService>, FSharpCommonConstants.FSharpLanguageName)>]
type CommentUncommentService() =
    interface ICommentUncommentService with
        member this.SingleLineCommentString = "//"
        member this.SupportsBlockComment = true
        member this.BlockCommentStartString = "(*"
        member this.BlockCommentEndString = "*)"
        member this.Format(document, _changes, _cancellationToken) = document

@vladima I've tested your code, it works! :) 👍


JAVA_OPTS export quotations

At the very least for macs/linux, the export needs to be updated to:
export JAVA_OPTS="-Dhttp.proxyHost=my.proxy.org -Dhttp.proxyPort=80 -Dhttps.proxyHost=my.proxy.org -Dhttps.proxyPort=80 -DsocksProxyHost=my.proxy.org -DsocksProxyPort=80"

Hey @cmoesel ,
Can we put this in the next shr-cli release? We should make sure the readme for the official grammar_5 release is as correct as possible.

Fixed with commit: https://github.com/standardhealth/shr-cli/pull/35/commits/273e0bfc98640bd8f5fc52fd172235076a9364b8


deep_learning_assignment-2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment-2
What did you learn from the changes you have made?
Train a model that learns the stylistic nuances of a chosen corpus and generates new, original text segments that echo the source material's essence
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
N/A
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
N/A
How were these changes tested?
N/A
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[x] I can confirm that my changes are working as intended

A2 complete


[Select] triggered onBlur event.target element is the selected option

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Setting onBlur event on a select TextField I expect the triggered onBlur event.target to be the TextField.
Current Behavior

It is the selected option (or MenuItem) element.
Context

I'm abstracting away form validation and submission. I use both onChange and onBlur event.target to get the value and name attributes of that element. Since onBlur event.target name is now undefined I get it from the props.
Your Environment

Tech
Version

Material-UI
beta35

React
16.2.0

browser
Chrome 64

@galki Do you have a reproduction?

I expect the triggered onBlur event.target to be the TextField.

@galki Oh, ok I think that I get it now. Do not confound event.target and event.currentTarget


Added newsletters to subscribe events

refs https://github.com/TryGhost/Team/issues/1478
Changes (bumps members-api to 6.0.0-alpha):

View changes: https://github.com/TryGhost/Members/compare/%40tryghost/members-api%405.12.0...%40tryghost/members-api%406.0.0-alpha.0
Moved all admin API members tests to enable the multiple newsletters flag
Checks if the susbcribe events are added correctly when adding or removing newsletters
Checks if susbcribe events are added for default newsletters
Fixes an error that was caused by enabling the multiple newsletters flag in the tests.

Added orderDefaultRaw in Newsletter model
Tests:

Moved all admin API members tests to enable the multiple newsletters flag
Checks if the susbcribe events are added correctly when adding or removing newsletters
Checks if susbcribe events are added for default newsletters

I'm stuck on the snapshots failing here. The order of the returned members is different locally than in CI, but this is in a completely unrelated test

@matthanley Tests are working locally, so it should be save to merge if we solve the ordering issue of members in a different PR


Create sharing-screening-results-with-GPs

adding a new post

@edwardhorsford Just took a quick look at this, i think the file name needs to have the date in it as-well as the folder is that still correct? Didnt want to merge this one in before double checking 👍

@edwardhorsford Just took a quick look at this, i think the file name needs to have the date in it as-well as the folder is that still correct? Didnt want to merge this one in before double checking 👍

Having the date in the post name is technically optional. It gets stripped out when the page is rendered to a url. I think it was mostly there as if you have 100+ posts it makes it easier to navigate them. Now posts are in monthly folders it's perhaps less necessary as there will only ever be a handful of posts in there.
@veroje I would suggest the filename be all lowercase though. Up to you if you want to prepend with the date. I've kept it for the Manage posts.


WIP adding support for file persistence using GitHub

Description
Added Open, Save, Quick save features for GitHub.
Type of change

[x] New feature (non-breaking change which adds functionality)

How to test
Deploy the front-end. Check that the GitHub control buttons now have options for "Open", "Save", "Save As" and "Log In".
Click on log in and sign in to GitHub.
Click on Open, select repository, then select a file to load.
Click on Save As, select repository, then select a file or name a new file to save over.
Click on Save to quick save current work into previously selected file.

Pull Request Test Coverage Report for Build 697295425

103 of 315 (32.7%)  changed or added relevant lines in 17 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 28.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/gitHubOverlay/GitHubTreeNodeCreator.tsx
29
30
96.67%

src/commons/gitHubOverlay/tests/snapshots/FileExplorerPanelTest.tsx.snap
0
1
0.0%

src/commons/gitHubOverlay/tests/snapshots/RepositoryExplorerPanelTest.tsx.snap
0
1
0.0%

src/pages/playground/Playground.tsx
0
1
0.0%

src/commons/controlBar/ControlBarGitHubButtons.tsx
0
2
0.0%

src/commons/application/actions/SessionActions.ts
11
15
73.33%

src/features/github/GitHubUtils.ts
0
4
0.0%

src/commons/application/reducers/SessionsReducer.ts
2
11
18.18%

src/commons/gitHubOverlay/ConfirmDialog.tsx
1
17
5.88%

src/commons/gitHubOverlay/FileExplorerPanel.tsx
10
35
28.57%

Files with Coverage Reduction
New Missed Lines
%

src/commons/controlBar/ControlBarGitHubButtons.tsx
1
10.53%

src/commons/application/reducers/SessionsReducer.ts
2
51.52%

Totals

Change from base Build 696963795:
-0.1%

Covered Lines:
2338

Relevant Lines:
7584

💛  - Coveralls


Django 2.0 compatibility

(Closed?)

Yeah, to replace with a PR against your fork @lamby.

Hi Chris, @PeterJCLaw informed me that we've switched to lamby/django-force-logout. Opening a PR there.

Ahhh didn't spot that. Cheers!


Emitter Issues with D435I

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
Intel RealSense D435I

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux (Ubuntu 18.04.5 LTS) / Windows 10

Kernel Version (Linux Only)
5.3.0-62-generic

Platform
PC

SDK Version
legacy / 2...

Language
python

Issue Description
When using D435 to capture infrared data, Infared 1/Y8 is turned on, and Emitter On/Off is enabled. However, when extracting the .bag file (which is then converted to a collection of .png files), the results of the data files vary:

Data is collected as expected
Data looks as if the emitter is always on, resulting in the collected images having dots over the face
Data has interchanging output where there will be expected and dotted results in the same file (most common)
* Data has interchanging output where there will be results with larger/brighter and smaller/dimmer dots (occurs in dim lighting, avoided by turning off auto exposure for infrared camera)

This has been attempted on both a Linux and Windows os with the same results. Has anyone else come across the same issues with data collection?
Thank you

Hi @ykokit    When you use the emitter on / off mode, does the dot pattern appear on frames where the pattern is meant to be "off"?
If so, does the behavior of the patterns change during the day depending on the current lighting level?  For example, in good lighting conditions the pattern might be visible on some types of material but not others.  And then later in the day when the light level may be dimmer, the behaviors seem reversed - the dots are visible on the materials they were previously invisible on, and invisible on the materials they were earlier visible on?
If the above behavior resembles the results you are experiencing then there may not be much that can be done in terms of a software solution.  Instead, if you need to use the emitter on / off mode then I would recommend using the camera in lighting conditions that are as stable and consistent as possible during the day.

Yes, when using the emitter on / off mode, does the dot pattern appear on frames where the pattern is meant to be "off". And no, while I understand what you mean in regard to the dots showing up on some materials and not others (I have extracted data that contains the behavior you are referring to) I have not come across it being reversed, because the dots would be visible on all materials. The behavior is effected by lighting to some degree (after a certain dim-ness this certain issue is hard to avoid), but I would make multiple .bag files under good lighting conditions and would still get varying results working with the same lighting.
The reason why is issue is being brought up is because we collected data of around 20 people without this problem arising before, and there is some confusion as to why it has arisen now. Could there be any other possibilities as to what it may be?

I read your case again from the beginning.  It sounds as though you are only treaming infrared and not depth, and that you do not want the IR dots appearing on the image.
If that is correct, then a simple solution may be to disable the IR emitter.  This will remove the dots from the IR pattern but preerve the IR image, as the IR Emitter and the left / right IR sensors are separate components.
Disabling the IR Emitter can have a significant impact on the depth image.  However, if you are only streaming IR then it should be fine to completely turn off the IR Emitter to remove the dot pattern from all frames.
The emitter can be disabled in Python using scripting in the link below:
https://github.com/IntelRealSense/librealsense/issues/7919#issuecomment-738857679
You can also disable the IR Emitter in the RealSense Viewer by setting the drop-down menu of the Emitter Enabled option to Off (the default On-state is 'Laser').  This is different from the Emitter On Off option further down the options side-panel, which causes the dot pattern to rapidly alternate on and off automatically and is not an on-off button for the emitter.

Hi @ykokit  Do you require further assistance with this case, please?   Thanks!

Case closed due to no further comments received.


Deserialization behaves differently on configurations with the same meaning

use serde_derive::Deserialize;
use std::collections::HashMap;

#[derive(Deserialize)]
struct ConfigInner {
    Key1: i32,
    Key2: i32,
}

#[derive(Deserialize)]
struct ConfigOuter {
    KeyOuter1: i32,
    KeyOuter2: ConfigInner,
    KeyOuter3: Vec<i32>,
}

pub fn run() {
    let config: ConfigOuter = toml_edit::easy::from_str(
        r#"
        KeyOuter1 = 10
        KeyOuter3 = [1,2,3]

        [KeyOuter2]
        Key1 = 1
        Key2 = 2
    "#,
    )
    .unwrap(); // => ok

    let config: ConfigOuter = toml_edit::easy::from_str(
        r#"
        KeyOuter1 = 10

        KeyOuter2.Key1 = 1
        KeyOuter2.Key2 = 2

        KeyOuter3 = [1,2,3]
    "#,
    )
    .unwrap(); // => ok

    let config: ConfigOuter = toml_edit::easy::from_str(
        r#"
        KeyOuter1 = 10

        [KeyOuter2]
        Key1 = 1
        Key2 = 2

        KeyOuter3 = [1,2,3]
    "#,
    )
    .unwrap(); // => fail
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn it_works() {
        run()
    }
}

For the third configuration, I got an error.
'tests::it_works' panicked at 'called `Result::unwrap()` on an `Err` value: Error { inner: ErrorInner { message: "missing field `KeyOuter3`", reverse_key: [], line_col: None } }', src\lib.rs:41:6

However, the first and second can pass.

The third configuration is different; KeyOuter3 is under the KeyOuter2 table. The blank line has no effect in toml for associating keys with tables.


<IP_ADDRESS> - Test SX stealth coin Search in Help

<IP_ADDRESS> - Test SX stealth coin Search in Help
Enhance SX search by defaulting "end search field" to the latest block height number

Fixed in 0.9.6

fixed in 0.9.6


Fix layout inflater override and require Kodein Activity components

Since there's no way the components can know if a binding to LayoutInflater has been bound from the android module or not, they add a tag ACTIVITY_LAYOUT_INFLATER so they don't run into override errors.
Also, requires that fragment kodein component's activities are also kodein components.

Hi @eygraber!
As usual, thanks for the great work ;) I particularly appreciate that you are maintaining and supporting your own code inside Kodein :)
Does this MR corrects #50 or is this another matter ?

#50 is another matter.


Move control windows buttons

Exist any way to move the control windows buttons to the right of the panel, some like this:

+1 or making it not show at all?


Buy and Sell Functionality

Am I missing something or does this lack the ability to place buy and sell orders?

@jfeust I encountered the same problem

You can use the rest api to make calls to the server, can't you? Just use a traditional POST command from your rails controller or button.

Only the v2.0 bittrex api gives the full buy/sell functionality. The v1.1 only allows buylimit and selllimit. I am willing to open a PR for this.

I need this functionality myself. Is any one working on it? Otherwise I may give it a go.

@nwochaadim Just saw the work you've done on your branch. Looks solid - will give it a go.

Hello. I wanted to use buylimit/sellimit. But I focused an error maybe.
After I created a Bittrex::Client with key and secret, I want to do:
c.get('market/buylimit', {market:'USDT-BTC', quantity:0.0001, rate:17000})
But it only results in nil, why?

@Prutheus Having the same issue. Have you found a solution?

@jesseproudman I think it should  be a post call.

Hi, it is definitely a get request.
I had issues using this gem, so I built mine: https://github.com/tarraschk/bittrex_ruby
You can check out the code if you want to implement it in this repo.


feat: support esm project to parse documentation

Summary by CodeRabbit

New Features

Introduced a new ESLint configuration for improved linting of TypeScript and JavaScript projects.
Enhanced asynchronous file handling capabilities in various classes.

Bug Fixes

Updated linting commands in the package.json for better clarity and functionality.

Documentation

Improved readability of code with formatting changes in several configuration files.

Chores

Updated various dependencies to their latest versions for better performance and security.
Streamlined workflow configuration for testing and deployment processes.

:tada: This PR is included in version 4.2.0 :tada:
The release is available on:

v4.2.0
GitHub release

Your semantic-release bot :package::rocket:


[Feature Request] Remove Internal Directory

Tell us about your feature request
imho, The code generated by this tool is a server, not a library,
so internal direcotry is not necessary.
what do you think?
Disclaimer

[X] I agree

But isn't anything outside the internal directory a package that can be called/used as a library by any other application? Having it in there prevents others from using it..?

that's the purpose of internal, I think it's the good approaches
@utamori unless you have plan to call the code as a library, there is no logic of exposing internal
The purpose of internal is to avoid issues and facilitate refactoring
if something is in internal, it can be refactored totally and even removed.

I agree, there is no good reason why the internal directory should be removed, nor should the directory structure in general be changed.


[JS] Topic: Debouncing and Throttling in JavaScript

Description 📜
This documentation contains relevant information about debouncing and throttling in JavaScript.
Fixes #3815

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] JavaScript_Domain

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@amino19 Thanks for sharing this information, I made the required changes. Please review it now.

Thanks @Ananyagupta43, it would be nice, if you can attach your GitHub account link to your name on your document, so it will be symbolized to yours! :hugs:
Replace the last line of code with this:-
<br />

Contributor: [**Ananya Gupta**](https://github.com/Ananyagupta43)

@Ananyagupta43  Great work, Looks good to me.


[Advance Throttling] Inverted condition is not working

Description:
In APIM Advance throttling in throttling policy didn't apply when invert the condition in conditional groups

Already fixed in APIM 2.1.0


WIP - Add contacts format

Any feedback welcome!

I did write a rake task to validate existing documents against the (frontend) schema, which I think would be a useful exercise: https://github.com/alphagov/content-store/blob/master/lib/tasks/check_content_items_against_schema.rake
Hopefully it still works.

This is ready to be re-reviewed.
@jamiecobbett I ran the script with the format and the only error that came up was about analytics_identifier being null and not a string. This is a problem with content items that do not have an analytics_identifier set (the same error is thrown for case_studies). The ContentItemPresenter appears to set it to nil when that value is not set. Maybe it would be worth allowing null values for analytics_identifier?


XREAD support

Is your feature request related to a problem? Please describe.
I currently experience the problem of XREAD not being supported.
Describe the solution you'd like
I would like XREAD to be supported.
Describe alternatives you've considered
Not using fakeredis. There's not really an alternative here :grimacing:
Additional context
I suppose there is a reason why this is currently not supported. @cunla maybe you can shed some light on this? I admit I'm not really familiar with the inner workings of this library, so I don't know the effort involved but if there's something I can help with let me know!

Hi,
I still need to implement this command in FakeRedis.
Are you interested in being involved? I wrote a guide on how to implement support for a command (here). All the stream commands are implemented in this mixin. It is important to write also tests for it to compare the results with real redis behavior.


windows: downgrade messages on coro exceptions to debug

Currently exceptions raised in tasks are reported in the log as warnings regardless of whether they are handled appropriately or not. This generates noise in the log that can obscure more important messages. This PR downgrades exception reporting to debug level.
Closes  https://github.com/harvimt/quamash/issues/110

tests are fixed in #111

Nice!

rebased on top of https://github.com/harvimt/quamash/pull/113


Need range highlighting like grafana and excel

I want to highlight one of the columns in my table depending on the value.
Means if the value is between 0 - 50 I want to put background color as red, between 50 - 100 as green and so on.
I have not been able to find any correct visualization for this. So let me know how can we achieve this in superset.

@snehlata08 thanks for requesting! color coding/conditional formatting is in our 1 year roadmap. 🙏 closing issue for now, will give you update once it's available.


Rename matcher Contains

Currently, the matcher Contains is used to assert that a Vec contains multiple elements.
Would it be more appropriate to rename it ContainsElements or ContainsAllOf and have another matcher Contains to assert the presence of a single element in a Vec?
Something like:
assert_that!(vec!(1, 2, 3), contains_elements(vec!(1, 2)));
// or
assert_that!(vec!(1, 2, 3), contains_all_of(vec!(1, 2)));

and
assert_that!(vec!(1, 2, 3), contains(1));

I wonder if it would be possible to implement From for Vec in such a way that contains would just convert a single element into a vector with one element. I'm not sure when I'll find the time to try that though.

I'm still a beginner with Rust so I'm might be wrong, but I don't think this is possible to provide a generic implementation of From to convert to a Vec as it would probably collide with other implementations. I've just tried to impl<T> From<T> for Vec<T> but I got an error saying that T must be used as the type parameter for some local type.
On the other hand, what would be possible is changing contains signature to accept a generic T + Into<V<T>> but this is not really convenient as it will force the clients to implement the From trait for each of their types.

I guess you're right. I don't know Rust well enough to know if that would be possible or not either.
I'm OK with either name, but I would do it in two steps and just add contains_elements or contains_all_of first and deprecate contains. I would also add contain_elements/contain_all_of as an "alias" so that does_not(contain_all_of(...)) reads nicer.
Once that's in I would do a release and the new contains + (contain) can the go into master.


Fix executable not found when the current working directory (cwd) is set to config file path

This commit resolves the issue where mkdocs build --config-file mkdocs.yml fails due to the process not properly locating the executable when the current working directory (cwd) is set to a specific path. Fix #75.

Thank you for your PR 😍


warp-terminal: added passthru update script

Description of changes

Finally got around to adding a passthru update script. Here, I manually updated the macOS hash because to my understanding update-source-version expects a platform+architecture, but doesn't accept a general platform, which warp does with it's .dmg (again, to my understanding, I don't have a mac). I also wanted to add myself as a maintainer of this, but I already have that commit in #291443, and didn't want to duplicate the commit. If this is ready to be merged before that, though, I'll remove that one and add it here.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/does-update-source-version-have-a-generic-system-flag/40679/1

Yeah, I'd like to be a maintainer if my other PRS aren't going to be merged before this. I'll update the other ones if this gets merged.

Yeah, I'd like to be a maintainer if my other PRS aren't going to be merged before this. I'll update the other ones if this gets merged.

add a commit to this PR and do it so this PR can get merged.
you need to fix your other commit message though. the body is not adding anything useful to someone who will be looking at the commit logs sometime in the future.
look at the output from git log for some examples.

I've added myself to the maintainer list and removed my commit body - I was squashing instead of amending and forgot to remove the commit messages getting added to the body.

there are some somewhat strict rules  about commit messages. the commit to the maintainers needs to be:
maintainers: add imadnyc
warp-terminal: added passthru update script
the maintainers needs to come first, otherwise if someone is performing a bisect if the eval  will break if they land on the warp-terminal change because you are missing from the maintainers. you'll need to do something like git rebase -i HEAD~2 reorder the commit and rewrite the maintainer message.

I'm gonna pretend it was because I didn't drink coffee today and nothing else. I think it should be good for real this time


Keyboard navigation

Users should be able to navigate using the left and right keys

Not sure if this is a good idea for accessibility. Not suggested in sources such as https://www.w3.org/WAI/tutorials/carousels/


pre-trained models for v5 basecaller model

Hi,
Thank you for your work, is there any plan to release clair3 nova pre-trained models for the v5 basecaller?
Could you also please clarify why clair3-nova requires both clair3 and clair3-nova models? Why are both used? Do both need to the same version? e.g. right now it looks like the latest basecaller set if using the same would be:
basecalling: v4.0.0 sup
clair3: v4.0.0 sup
clair3nova: v4.0.0 sup
If the versions don't need to be the same then
basecalling: v5.0.0 sup
clair3: v5.0.0 sup
clair3nova: v4.0.0 sup
Thanks,
-David

Hi David, thanks for asking. Yes Clair3-Nova takes both a Clair3-Nova model and a Clair3 model. In Clair3-Nova's pipeline, Clair3 was used for finding high-quality heterozygous SNPs for read phasing and haplotagging. Both Clair3-Nova and Clair3 need a correct model for the corresponding chemistry and basecaller. ONT provides Clair3 models for the latest chemistries and basecallers, but not Clair3-Nova yet.


Add TextWidget alignment options

This PR
This PR adds options to TextWidget to allow users to specify alignment.
Unlike most widgets, the user cannot necessarily know the dimensions of their text because different translations may change text length. If a user wanted to have text be aligned to the end or center of a recipe, they would have to calculate the width of their text themselves. This PR makes that calculation a part of TextWidget.
Screenshot
Here is an example of if the furnace recipe had its Exp text aligned to the end of the recipe:

Yeah, I guess vertical alignment is more of a QOL & uniformity thing.


kubefed2 join does not work correctly with some kubectl context names for the hosting cluster

What happened:
I used kubefed2 join with a cluster whose kubectl context contained a slash (default/pmorie-dev-api-devcluster-openshift-com:6443/kube:admin), which is a perfectly valid kubectl context name. However, the name of the kubectl context for the host cluster is used to construct the names of resources, which will yield invalid resource names in cases like this where the name of the kubectl context is a valid context name but not a valid resource name. We should construct the names of these resources using values that will always yield a valid resource name.
Looking at possibilities for which value to use, I thought about using the name of the cluster in the kubeconfig (instead of the name of the context), but it appears there are basically no validation requirements for kubeconfig cluster names: https://github.com/kubernetes/client-go/blob/master/tools/clientcmd/validation.go#L167
Tactically, perhaps we could consider using -federation when we construct resource names.
What you expected to happen:
I would expect the join operator to proceed even if my context name does not construct a valid k8s resource name.
How to reproduce it (as minimally and precisely as possible):
Use kubefed2 join with a host cluster context that contains a slash.

/kind bug

@pmorie, can this be closed?

Fixed by #578


Added support for multi page TIFFs

This PR adds basic support for multi page TIFF files by supporting a 'page' property on the options object; this allows selecting of a particular page of a multi page TIFF file.
to do this, just add the page to the options:
// selects the 5th page of a multi page TIFF file
var image = sharp(file, {page:4})

Note the page counts are zero based.
There is no support for page count retrieval included as, in my use case, I need to retrieve all the pages one at a time anyway, so I am dealing with that by looping though the source tiff until I get an error.

Thanks for this useful addition, I've added a few comments in line.
Please can you fix the failing tests and add additional tests to cover the new logic added, then rebase+squash into a single commit.

On it. Thanks.

@Brigadier1-9 Do you need any help with this?

What is the status of this PR? I have an urgent need to convert multi-page TIFF images. Is there anything I can do to help?  Thanks!

It's kind of stalled; my fault I'm afraid. I have a new version in place (after a refactor of sharp) which I have used to pull about 100,000 images out of a bunch of multi page tiffs with no issues, so I am fairly confident it works. I will try to submit a new PR in the morning and close this one at that point.
Sorry for the delay!

Any updates on this PR? Thank you!

Hey all, any idea if this PR will move forward? Currently using sharp and discovering a need for this functionality.

Hello, I'm going to close this PR as it has drifted too far behind the master branch but please feel free to open a new PR with a similar change if this is still required.


[TASK-6241] Cache ES ingestion when ingesting usage

Describe your changes :
As explained on #6241, we've identified that the database usage ingestion does a very large amount of repeated requests to elastisearch and the backend tables for every query/table processed. This PR is a first effort to improve usage ingestion performance by implementing caches/checks in three stages of the process:

metadata_usage & table_mixin: For each table, avoid ingesting the same query more than once as it will add no new information and most of the repetaed queries are created by previous stages in the process.
sql_usage cache the result of search_table_entities that does one query to ES and potentially many to backend and was one of the main sources of the slowdown. I wasn't able to find a nice place to put the cache due to the way the code is structured so I ended up creating it as a module-level variable. This is far from ideal but for a nicer setup we'll need to do some restructuring.

We did some experiments to evaluate the impact in performance and obtained the results below. Note that to reduce variability we extracted an entire day's worth of queries (~52.5k queries, 57 MB)  from RS into a csv file and loaded them from there. All runs below include the sql parsing step which was not optimized:
Not optimized

1000 records, no optimization -> 88.63s user 5.92s system 32% cpu 4:53.97 total
5000 records, no optimization -> 676.88s user 12.21s system 59% cpu 19:25.03 total
10000 records, no optimization -> 1276.32s user 21.37s system 60% cpu 35:47.41 total
Optimized
1000 records, optimized -> 33.79s user 1.01s system 54% cpu 1:03.41 total
5000 records, optimized -> 357.55s user 2.50s system 79% cpu 7:32.33 total
10000 record, optimized -> 566.22s user 4.54s system 75% cpu 12:34.00 total

The chart above suggests that the imroved version has a lower complexity, although due to the many parts involved in the execution of each iteration of the ingestion this might be difficult to measure.
There's still plenty of room for improvement as the ones propoed are quite hamfisted and we could greatly reduce the amount of records we generate ourselves but it's a good indicator of how things can improve.

Type of change :

[] Bug fix
[x] Improvement
[] New feature
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation

Frontend Preview (Screenshots) :
N/A

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
@open-metadata/ingestion

Many thanks for this @Beetelbrox, really enjoying our conversations around this and we truly appreciate the time and effort you're investing ❤
The PR looks great, let's merge it in after adding the LRU cache as discussed 🚀

Thanks a lot @Beetelbrox this is great!!

@Beetelbrox thank you for the awesome PR 🙏. Would you be able to fix the code smell. After that we can merge it. 🚀


Package: logcat-openipc

logcat-openipc: added userspace programs (logcat, logwrapper) for reading the Android logging facility used by Ingenic IMP libraries

Thanks for sending PR but I have a question - why don't you make it so that the source code of the program is taken from your repository, as it is done in other packages. It would be more correct and efficient. We try to add program code directly into Firmware repo only if it contains not more than a dozen files. The link can go either to your personal repository on GitHub or you can make a transfer to the OpenIPC organization of any of your repos while retaining the rights of the main developer. Please think about it. So to add a new package you only need two new files, the first in your PS and minimal configuration edits. Thanks.

@FlyRouter yes, I agree.  Stand by for PR edit.

@FlyRouter changes completed


Overview Snippets and better initial docs.

getting started guide.  more snippets will be incoming.

jskeet is out this week -- I dont think we need to block on this -- can
always change it later.
On Mon, Jul 24, 2017 at 4:41 PM, Ian<EMAIL_ADDRESS>wrote:

@iantalarico commented on this pull request.
In apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.
Data.Snippets/SnippetFixture.cs
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1272#discussion_r129181659
:

+using Xunit;
+// ReSharper disable MemberCanBePrivate.Global

+#endregion
+
+namespace Google.Cloud.Spanner.Data.Snippets
+{

// ReSharper disable once ClassNeverInstantiated.Global
[CollectionDefinition(nameof(SnippetFixture))]
public class SnippetFixture : IDisposable, ICollectionFixture
{

   private readonly Lazy<Task> _creationTask;

   public string TestInstanceName => "spannerinstance";

   public string TestProjectName => Environment.GetEnvironmentVariable("TEST_PROJECT") ?? "cloud-sharp-jenkins";

Yea but this would fail if you aren't, it just seems odd to hard code in a
project id. I'd rather throw if it's not set but I'll leave that up to you.
In apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data.Snippets/
SpannerOverviews.cs
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1272#discussion_r129181736
:

                               {"StringValue", SpannerDbType.String},

                               {"Int64Value", SpannerDbType.Int64}

                           });

                       cmd.Transaction = transaction;

                       // This executes a single transactions with alls row written at once during CommitAsync().

                       // If a transient fault occurs, this entire method is re-run.

                       for (var i = 0; i < 5; i++)

                       {

                           cmd.Parameters["Key"].Value = Guid.NewGuid().ToString("N");

                           cmd.Parameters["StringValue"].Value = $"StringValue{i}";

                           cmd.Parameters["Int64Value"].Value = i;

                           await cmd.ExecuteNonQueryAsync();

                       }

                       await transaction.CommitAsync();

Ah nevermind I see now :)
In apis/Google.Cloud.Spanner.Data/docs/index.md
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1272#discussion_r129181808
:

+See examples below:
+
+# Sample code
+Once you have created your Google Cloud Project and Spanner Instance using the web console,
+you can start using the ADO.NET provider to create and modify a Cloud Spanner database.
+
+## Creating a Database and Table
+
+[!code-cs]
+
+## DataAdapter support (.NET 4.5+ only)
+
+Cloud Spanner supports a limited DataAdapter that provides basic CRUD operations on any table.
+Create a SpannerDataAdapter with the target table and its primary keys.  You may replace any
+commands on the SpannerDataAdapter with your own custom commands.
Maybe @jskeet https://github.com/jskeet will have a better idea?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1272#discussion_r129181659,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH7cpTBRebUef5UH2djRQYMH-IyMMOZYks5sRSu8gaJpZM4Ohvia
.


Cool! I had noticed it too, it was on my todo list :)
As for the server, I suspect he means we should update the vendored version of saltpack in our other repos...

in this case, we need to pull the saltpack go module, which is linked into
the saltpack.org node library via symlink.  i think it worked
On Fri, Aug 3, 2018 at 9:44 AM Antonio Marcedone<EMAIL_ADDRESS>wrote:

Cool! I had noticed it too, it was on my todo list :)
As for the server, I suspect he means we should update the vendored
version of saltpack in our other repos...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keybase/saltpack/pull/64#issuecomment-410251439, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_3V2LfqG4EcGTQxNHkpyzHWwbAWYks5uNFPIgaJpZM4VtLsd
.


Change to look for end of  instead of comments for javascript

Closing decided this feature is not necessary at this time.


Change /performances/:performanceId/results/:resultId to a put

When the fetch stuff is implemented, get rid of the form and make that request a put

Fix with #92

Jk, I already closed it. Make this a separate PR

Lol this isn't even a route anymore


Deny keyword lifetimes pre-expansion

As of nightly-2024-07-18, rustc has begin rejecting code such as the following, which used to parse successfully. https://github.com/rust-lang/rust/pull/126762
#[cfg(any())]
fn f<'ref>() {}

error: lifetimes cannot use keyword names
 --> src/main.rs:2:6
  |
2 | fn f<'ref>() {}
  |      ^^^^

If this is no longer valid Rust syntax, syn should reject it too.

Rustc still allows keyword lifetimes in macro input, so the Parse impl for syn::Lifetime probably needs to continue to allow them too.
fn main() {
    println!("{}", stringify!('ref));
}

But syntax tree uses of Lifetime, such as in GenericParam, can begin rejecting these.


Not run at open Query

Hi,
how is it possible not to execute the query immediately? Sometimes I want to read first if this is the right query and not to load the database unnecessarily.

You can click the "Play" link to open up sql in playground mode, it wouldn't have executed by default.

Also, if you want to get tricky, there is a somewhat-undocumented feature -- you can put ?show=0 in the URL and the query will not execute. You can then use the "Save Only" option from the Run drop down.


Developer Documentation (Frames)

The more I think about it, the more I feel that tracking non-engineering tasks on ZH confuses our ability to track and report engineering progress. Closed this issue for that reason.


select sizes

Please make it possible to get bigger selects:
http://getbootstrap.com/css/#forms-control-sizes

Set data-style-base="btn input-lg". Duplicate of #694.


Counter bbid

Also not: https://github.com/nikign/AFL/blob/Counter_BBID/llvm_mode/afl-llvm-pass.so.cc#L159
is not needed anymore since it computes cur_loc xor (prev_loc >> 1). We only need a single BBid which we increment each time, and we instrument each basic block by injecting only CoverageMapPtr[BBid] += 1

we only need the load to increment the value:
counter = shared_mem[BBid]
counter += 1
shared_mem[BBid] = counter
On Thu, Jun 4, 2020 at 11:02 AM Niki<EMAIL_ADDRESS>wrote:

@nikign commented on this pull request.
In llvm_mode/afl-llvm-pass.so.cc
https://github.com/nikign/AFL/pull/1#discussion_r435447070:

for (auto &F : M)
for (auto &BB : F) {

 assert(block_counter < MAP_SIZE && "counter is too large");
 BasicBlock::iterator IP = BB.getFirstInsertionPt();
 IRBuilder<> IRB(&(*IP));

 if (AFL_R(100) >= inst_ratio) continue;

Looking at the code a second time, it looks like we don't need many of the
loads as well, since the counter is constant.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nikign/AFL/pull/1#discussion_r435447070, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APMEKCZOXQRWJSLQJTPQYNLRU7OTBANCNFSM4NSBTYMQ
.

how about -DFEATURE=1, which is something that may happen to define a MACRO.
On Mon, Jun 8, 2020 at 3:15 PM Niki<EMAIL_ADDRESS>wrote:

@nikign commented on this pull request.
In compare_runs.py
https://github.com/nikign/AFL/pull/1#discussion_r437030943:

+def get_arguments(argv):

bc_file = ''
output_bc = ''
test_count = 2
flags = ''
logfile_name = 'logfile'
try:

   opts, args = getopt.getopt(argv,"hi:o:n:f:l:",[])

except getopt.GetoptError:

   print('compare_runs.py -i <input_bc_file> -o <output_bc_file> -n <re-run_counts> -f "<clang_run_flags>" -l "<log_file_name>"')

   sys.exit(2)

print(opts)
for opt, arg in opts:

   if opt == '-h':

       print('compare_runs.py -i <input_bc_file> -o <output_bc_file> -n <re-run_counts> -f "<clang_run_flags>" -l "<log_file_name>"')

I have tried some examples with "-" in the flags and it works. I don't
have a good example with "=" to test it with but if you have something in
mind, I can try but I think since that part is in quotes it shouldn't have
any issues.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nikign/AFL/pull/1#discussion_r437030943, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APMEKC6FCJ5N7XOQ7NOLDL3RVVPGHANCNFSM4NSBTYMQ
.


Add By Metalinks require a file?

It is better getting metalinks from text input, because I often copy metalinks in pages but never save theme into a file. Think about it.

Keeping both would be a good idea.

@renbaoke Do you have an example? I guess by link, you mean a link to the metalink xml file?
Because if using link directly is a use-case then that can be added :)

It's a common use-case in China. Would be grateful to see that become a feature :)

I see nowhere uses it in China. State the website that you uses with Metalink.


How to set marker label?

How can i set label on marker?
Image from google documentation:

And if it has the meaning my marker has custom icon. So it should be like this:

Sorry, solution found here:
https://github.com/dapriett/nativescript-google-maps-sdk/issues/237#issuecomment-354006764


[backport] Fix typo in /examples/seq2seq/README.md

Backport of #8399

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 369b3cdc684808fdd2987239e6fe53b968b916bc, target branch v6) succeeded!

LGTM! Test failures are not related to this PR.


Website requires JavaScript and provides nothing without it

Summary of the bug
The design system's website requires JavaScript to load, without it I just get a blank page with no guidance, information, etc.
🪜 How to reproduce
Tell us the steps to reproduce the problem:

Go to page: https://design.sis.gov.uk/ with JavaScript disabled (or in a browser without JavaScript)
See a completely blank page

🧐 Expected behaviour
The site appears to be mostly static content, it should work without requiring JavaScript (as should all components) based on the principle of Progressive Enhancement.
In the short term, at the least, the site should alert the user that JavaScript is required to view the site, for example using <noscript> tags to provide an informative message (you can use CSS without JS to maintain the design system feel.)
🖥 Desktop

OS: Windows
Browser: Chrome
Version: 107

Thanks for your contribution, we're going to look into this within this sprint. We're aware there may be some accessibility requirements related to this too, so factoring this into the work. Feel free to keep an eye on this issue and we'll try update you if there is anything relevant throughout.

As an update, we initially added the message to enable JavaScript and have since put up a further change to render the majority of our website with JavaScript disabled, which will be merged shortly.

reopened until website update is deployed

Closing as updated site now deployed.


Add capability to read raw download from SSP database

Solves issue #57
The solution here isn't very clever and I may have broken some naming conventions but all the tests seem to pass, including the new one. I'm happy to fix these issues if you can tell me how you'd like that done.

Just a few comments from my side. Looks good! Thanks Zeb!

Thanks both. My python is rusty so apologies for various abuses of style and multi-line solutions to one-line problems etc.

Lgtm, I'll let @danielhuppmann make the final decision and merge.

Alright I'll fix in the morning with whatever logic you recommend given your knowledge of the various databases this is likely to interact with

On 12 Apr 2018, at 21:24, Matthew Gidden<EMAIL_ADDRESS>wrote:
I would advise against looking for copyright - it's unicode and could
provide issues for users later. My opinion would just to look for the
database line.
On Thu, Apr 12, 2018 at 1:22 PM, Zeb Nicholls<EMAIL_ADDRESS>wrote:

@znicholls commented on this pull request.
In pyam/utils.py
https://github.com/IAMconsortium/pyam/pull/58#discussion_r181046630:

@@ -129,6 +129,14 @@ def format_data(df):
missing = list(set(IAMC_IDX) - set(df.columns))
raise ValueError("missing required columns {}!".format(missing))

if 'notes' in df.columns:
logger().info('Ignoring notes column in dataframe')
df.drop(columns='notes', inplace=True)
df = df[
(~df.model.str.contains('SSP Public Database'))

it's not an @ it's copyright. I've changed to just check for 'database'
in the row, if that doesn't work I'll look up the copyright symbol in the
morning and do it that way
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/IAMconsortium/pyam/pull/58#discussion_r181046630, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABVAEWWfvgQ3aaOcm25qZg4hqd2ld40wks5tnzj9gaJpZM4TRH8Q
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@znicholls sorry that this last hoop to jump through is such a pain! I concur with Matt that checking for the string database is the best solution at this point...

thanks @znicholls!

Thanks for hand holding, hopefully next contribution will be smoother!
On Fri, Apr 13, 2018 at 5:44 PM, Daniel Huppmann<EMAIL_ADDRESS>wrote:

Merged #58 https://github.com/IAMconsortium/pyam/pull/58.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IAMconsortium/pyam/pull/58#event-1572643793, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWh-m5oDtfthS3J5tcwumdccXgPPL0c8ks5toFdugaJpZM4TRH8Q
.


No function or associated item named insert_types, create_type, get_full_path for VecDeque and usize on Anchor 0.30

I could not build the program since upgrade to Anchor 0.30. It happened if I try to add a field with usize or VecDeq type in struct. Here is a simple replication of this issue

#[account]
pub struct Pool {
    pub id: u64,
    pub size: usize,
    pub workers: VecDeque<Pubkey>,
}

Old: Anchor 0.29.0, Solana 1.18.14 -> working

New: Anchor 0.30.0, Solana 1.18.14 -> not working

List of errors:
error[E0599]: no function or associated item named insert_types found for struct VecDeque in the current scope
error[E0599]: no function or associated item named insert_types found for type usize in the current scope
error[E0599]: no function or associated item named create_type found for struct VecDeque in the current scope
error[E0599]: no function or associated item named get_full_path found for struct usize  in the current scope
error[E0599]: no function or associated item named get_full_path found for struct VecDeque in the current scope

usize and VecDeque types are not supported in the IDL spec. The reason it used to work before 0.30.0 is because IDL generation would just make everything unknown as a defined type, which resulted in build succeeding but also with an unusable IDL. You can verify this by building your program with 0.29.0 and try to use that IDL client side.
You can, however, include any type in the IDL if you implement IdlBuild trait for that type. See "Customization" section of https://github.com/coral-xyz/anchor/pull/2824 and this example.

Thanks for you explaination!


Fix wrong type for svgIcons & fontIcons

svgIcons & fontIcons must be of type QuasarFontIconSets[] by spec, otherwise auto-imports fail and the fields are left unusable.

I simply aliased the type imports. I don't think this should be breaking anything. Closing.