Merging two ways corrupts step_count

URL
No response
How to reproduce the issue?
Follow-up to #8069
Splitting a way in two results in i.e. step count of 4 => 3+1 / 2+2 depending on the length of the way itself.
However, merging two ways will result in 3+1 => Error (values are not the same), or 2+2 => 2 (merged, values are not summed)
Perhaps summing up the values, or alternatively (prompting to) delete the values (if situation has changed significantly), is better.
See also https://github.com/MarcusWolschon/osmeditor4android/issues/1251#issuecomment-706021265
Screenshot(s) or anything else?
No response
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.30.4
Which browsers are you seeing this problem on?
Chrome

A similar issue is merging ways tagged parking:left/right/both:capacity=*. Summing the values sounds reasonable to me, though this assumes that the preexisting split doesn’t correspond to the location of one of the steps being counted twice. Refusing to merge also seems OK, though it would be annoying to the user without clear guidance on how to resolve the conflict.

I’d like to work on this issue. Could you assign it to me?

Hey @haresahani , kindly let me know if you're still working on it.

@Deeptanshu-sankhwar , @haresahani anyone of you working on this issue?

Not as of now, feel free to pick it @Darshit42


[WIP]: add flowtypes for rnw

TODO:
$FlowFixMe

I tried to use Flow Types definition which is recommended in the react-native-web readme, but I realized that it is outdated.
https://gist.github.com/paularmstrong/f60b40d16fc83e1e8e532d483336f9bb/revisions


AQL query returning only ehr_id cannot be executed

Steps to reproduce
wrote an integration test using a DTO generated by ehrbase SDK. Template is here
The integration test is runsConfirmedCovid19InfectionReportQuery method of PhenoTypeAqlTestIT class in this branch of EhrBase SDK:
https://github.com/ehrbase/openEHR_SDK/tree/feature/num_study_phenotype_aqls
To reproduce the issue, please checkout the above branch and run the test.  EhrBase is running directly from the IDE, based on commit 'c75593d15c037cbd6ac8656aec80cc63050fe53f' on the develop branch, which is the latest at the time of this post.
Actual result
Attempting to run the query returns the following payload:
{"error":"Could not process query, reason:org.springframework.jdbc.BadSqlGrammarException: Access database using Jooq; bad SQL grammar [select distinct on (\"/ehr_id/value\") \"alias_3064403\".\"/ehr_id/value\" from (select \"ehr_join\".\"id\" as \"/ehr_id/value\" from \"ehr\".\"ehr\" as \"ehr_join\" where (\"ehr\".\"entry\".\"template_id\" = ? and (\"ehr_join\".\"id\"='ff36c89c-33c4-404a-a16d-1b4e48d1a812'))) as \"alias_3064403\"]; nested exception is org.postgresql.util.PSQLException: ERROR: missing FROM-clause entry for table \"entry\"\n  Position: 156","status":"Bad Request"}
Expected result
Query should return a single row with ehr_id as the only value
Success criteria
The test mentioned above should pass.
Please note the comment in the integration test code. Using more than one column in the SELECT clause of the query works. It appears the problem emerges when a single path/column is provided in the SELECT clause.
@lmarcoruiz FYI

closing. fixed in https://github.com/ehrbase/ehrbase/pull/369


Parallel port in WSL

I have some linux console app which using hardware parallel port. Port working OK in Windows, but WSL Ubuntu doesn't list it in /dev. Therefore, my app display "Failed to open /dev/parport1: No such file or directory" and does not work. Any solutions?

+1

+1

+1


Emergency Notifications and Receipts

Applications sending emergency-priority notifications will receive a receipt parameter from our API when a notification has been queued. This parameter is a case-sensitive, 30 character string containing the character set [A-Za-z0-9]. This receipt can be used to periodically poll our receipts API to get the status of your notification, up to 1 week after your notification has been received.

See also Pushover Api Reciepts
This module should also implement this code.

Added


Daily crashes of explorer.exe due to Windows.UI.Xaml.dll

Describe the bug
I have 5 crashes today already and I've used my computer for 2 hours. I suspect this is due to the new preview featured added to explorer in some update recently. I do not have proof of that, but everything was fine until that was added. I've disabled it for now so explorer won't lock up, but the crash continues to happen silently in the background.
Source
Windows Explorer

Summary
Stopped working

Date
2/11/2024 11:03 AM

Status
Report sent

Description
Faulting Application Path:	C:\Windows\explorer.exe

Problem signature
Problem Event Name:	APPCRASH
Application Name:	explorer.exe
Application Version:	10.0.22621.3007
Application Timestamp:	4421e92b
Fault Module Name:	Windows.UI.Xaml.dll
Fault Module Version:	10.0.22621.3007
Fault Module Timestamp:	b2ab1928
Exception Code:	c0000005
Exception Offset:<PHONE_NUMBER>3106af
OS Version:	10.0.226<IP_ADDRESS>.768.101
Locale ID:	1033
Additional Information 1:	26e5
Additional Information 2:	26e57f2d568bbced83b47a67c6777293
Additional Information 3:	cb57
Additional Information 4:	cb5745cc74d9ee7f93a607c23c1f5653

Extra information about the problem
Bucket ID:	009939d5addafeeff721eed07ae4d2cf<PHONE_NUMBER>286218959)

Steps to reproduce the bug
Unknown, started happening one day after clicking on a file from my Godot game project that was a binary I think! and has not stopped since. I cannot replicate intentionally though unfortunately.
Expected behavior
Not crashing
Screenshots

NuGet package version
None
Windows version
Windows 11 (23H2): Build 22631.3007
Additional context
Edition	Windows 11 Home
Version	23H2
Installed on	12/29/2023
OS build	22631.3007
Experience	Windows Feature Experience Pack 1000.22681.1000.0
Device name	jbanasik-desktop
Processor	AMD Ryzen 7 5800X 8-Core Processor                4.20 GHz
Installed RAM	64.0 GB
Device ID	1A9D1AE4-AB9E-44B0-B1A5-D60789C9254B
Product ID	00326-10000-00000-AA106
System type	64-bit operating system, x64-based processor
Pen and touch	No pen or touch input is available for this display

Hi I'm an AI powered bot that finds similar issues based off the issue title.
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!
Closed similar issues:
* [File Explorer crashes in Windows 11 upon right click Faulting module name: Windows.UI.Xaml.dll, version: 10.0.22000.348 (#6482)](https://github.com/microsoft/microsoft-ui-xaml/issues/6482),  similarity score: 0.79

* [Windows.UI.Xaml.dll crash silently (ExceptionCode: c000027b) (#2820)](https://github.com/microsoft/microsoft-ui-xaml/issues/2820),  similarity score: 0.78

* [Windows.UI.Xaml.dll crash at startup for all ms store apps (#1712)](https://github.com/microsoft/microsoft-ui-xaml/issues/1712),  similarity score: 0.76

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

Checked these, while the issue is similar the crash is definitely different.

Thanks for providing those details. From looking at the "Bucket ID" of this access violation crash, it looks like you're hitting a bug (internal bug reference) which should be fixed in this recent servicing update: KB5034204

Thanks so much for looking. I look forward to the patch!

Sadly still happens way too often. No change from 21H2, which I ran until April to 24H2, which I ran now. (I delayed upgrading 'cause shadowcopies for local drives were inaccessible/broken until April update)

- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Application Error" Guid="{a0e9b465-b939-57d7-b27d-95d8e925ff57}" />
  <EventID>1000</EventID>
  <Version>0</Version>
  <Level>2</Level>
  <Task>100</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000000000000000</Keywords>
  <TimeCreated SystemTime="2024-06-15T12:00:13.9363862Z" />
  <EventRecordID>11739</EventRecordID>
  <Correlation />
  <Execution ProcessID="2612" ThreadID="7092" />
  <Channel>Application</Channel>
  <Computer>PC-JOU</Computer>
  <Security UserID="S-1-5-21-620362388-2233446311-3849218602-1001" />
  </System>
- <EventData>
  <Data Name="AppName">Explorer.EXE</Data>
  <Data Name="AppVersion">10.0.22621.3733</Data>
  <Data Name="AppTimeStamp">c47c2769</Data>
  <Data Name="ModuleName">Windows.UI.Xaml.dll</Data>
  <Data Name="ModuleVersion">10.0.22621.3672</Data>
  <Data Name="ModuleTimeStamp">9db4ed3c</Data>
  <Data Name="ExceptionCode">c000027b</Data>
  <Data Name="FaultingOffset">0000000000871a80</Data>
  <Data Name="ProcessId">0x2ab0</Data>
  <Data Name="ProcessCreationTime">0x1dabce2f5e853f4</Data>
  <Data Name="AppPath">C:\WINDOWS\Explorer.EXE</Data>
  <Data Name="ModulePath">C:\Windows\System32\Windows.UI.Xaml.dll</Data>
  <Data Name="IntegratorReportId">7f2f6771-208f-48bb-8188-7793eaff06b0</Data>
  <Data Name="PackageFullName" />
  <Data Name="PackageRelativeAppId" />
  </EventData>
  </Event>

I am seeing explorer.exe crash on startup, preventing startup processes from running.
This happened after before after a Windows update, maybe six months ago, and was eventually resolved by another Windows update. Now it's back. Removing the latest .NET update (KB5044091) resolves the problem temporarily, but the update gets auto-installed again and the problem returns. I've temporarily paused updated in the hope that a fix will get released soon.
My system is running Windows 10. (My AMD Threadripper CPU doesn't support Windows 11.)
I grabbed a dump of the crash. Here are some screenshots. I can provide the full crash dump privately if necessary.

It may be a total red herring, but my UI theme is set to Light, but that's not the theme that seems to be getting passed to Initialize(ApplicationTheme theme).


unescaped markup in checklist view

See attached. Link: https://www.inaturalist.org/check_lists/155186-Soberania-Check-List?page=1&view=photo

Just bumping this.


[Identity] Allowing to specify a user defined Managed Identity by Resource Id

Here’s a PR for https://github.com/Azure/azure-sdk-for-js/issues/20040
This PR adds support to the mi_res_id parameter on our ManagedIdentityCredential.
I’m basing my changes on the .NET PR https://github.com/Azure/azure-sdk-for-net/pull/26595/files
Fixes #20040

API changes have been detected in @azure/identity. You can review API changes here
API changes
-     constructor(clientId: string, options?: TokenCredentialOptions);
-     constructor(options?: TokenCredentialOptions);
+     constructor(clientId: string, options?: ManagedIdentityCredentialOptions);
+     constructor(options?: ManagedIdentityCredentialOptions);

API changes have been detected in @azure/identity. You can review API changes here
API changes
+     managedIdentityResourceId?: string;
-     constructor(clientId: string, options?: TokenCredentialOptions);
-     constructor(options?: TokenCredentialOptions);
+     constructor(clientId: string, options?: ManagedIdentityCredentialOptions);
+     constructor(options?: ManagedIdentityCredentialOptions);

@witemple-msft managedIdentityPrincipalId is not currently in the plans that I can foresee, but I have asked about it. In any case, it is out of the scope for this PR.

API changes have been detected in @azure/identity. You can review API changes here
API changes
+     managedIdentityResourceId?: string;
-     constructor(clientId: string, options?: TokenCredentialOptions);
-     constructor(options?: TokenCredentialOptions);
+     constructor(clientId: string, options?: ManagedIdentityCredentialOptions);
+     constructor(options?: ManagedIdentityCredentialOptions);
+ }
+ export interface ManagedIdentityCredentialOptions extends TokenCredentialOptions {
+     resourceIdentifier?: string;

API changes have been detected in @azure/identity. You can review API changes here
API changes
+     managedIdentityResourceId?: string;
-     constructor(clientId: string, options?: TokenCredentialOptions);
-     constructor(options?: TokenCredentialOptions);
+     constructor(clientId: string, options?: ManagedIdentityCredentialOptions);
+     constructor(options?: ManagedIdentityCredentialOptions);
+ }
+ export interface ManagedIdentityCredentialOptions extends TokenCredentialOptions {
+     clientId?: string;
+     resourceId?: string;

API changes have been detected in @azure/identity. You can review API changes here

API changes have been detected in @azure/identity. You can review API changes here

API changes have been detected in @azure/identity. You can review API changes here


Bond tool and Erase tool buttons have to be disabled in Sequeince mode (since they are not applicable)

Steps to Reproduce

Go to Macromolecules mode - Sequence mode

Actual behavior
Bond tool and Erase tool buttons are enabled but do nothing (since they are not applicable)

Expected behavior
Bond tool and Erase tool buttons are disabled

Versions

Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
Windows 10 Pro
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

KUDOS to @ljubica-milovic who found that issue

Fixed.

Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
Windows 10 Pro
Chrome Version 127.0.6533.73 (Official Build) (64-bit)


Fix endpoints check

See: https://github.com/micky2be/superlogin-client/issues/40

Closing as we need a different URL parser than the current one.


bind sluggable to multiple models

In the DRY spirit, I'd like to bind sluggable to multiple models. So ideally one wouldn't write the code in the link below multiple times. May it be documented somewhere what's the recommended Laravel approach for that?
https://github.com/cviebrock/eloquent-sluggable#updating-your-eloquent-models

@tim-peterson what do you mean? Do you want Sluggable on multiple models that have the same column names, without repeating that array multiple times?

Yes. All my tables have the same column name, "slug". Is there a way to bind this interface to multiple multiples?

@tim-peterson: what about placing it in a config file. Let's say you put it in services.php you'd add a key sluggable with the value being your array. Then, in your models you can just do protected $sluggable = config('services.sluggable'). Alternatively, create a base model SluggableModel which your models extend or similar.

Thanks @phroggyy , i'm not seeing how the configuration relates to the question. What you said before about extending the base model made more sense to me. Can you clarify how the Configuration section relates to implementing Sluggable in multiple models simultaneously?

@tim-peterson: you can set a default build_from and save_to in your config. If you don't set a sluggable attribute on your model, it will use your config if I've understood correctly.

Sounds good, yes that works. Because the config files has the default build_from and save_to I'm using, I don't need to specify that array every time. To even be more DRY, I also extended the Models where I want to use Sluggable  with a Base Model such that I could write this:
class User extends Base
{

Instead of:
use Cviebrock\EloquentSluggable\SluggableInterface;
use Cviebrock\EloquentSluggable\SluggableTrait;

class User extends Model implements SluggableInterface
{

Here's the relevant part of my Base Model:
use Cviebrock\EloquentSluggable\SluggableInterface;
use Cviebrock\EloquentSluggable\SluggableTrait;

class Base extends Model implements SluggableInterface
{
    use SluggableTrait;


Cordova iOS 4.* orientation locking issue

The recent update to<EMAIL_ADDRESS>breaks our previous orientation locking code and advice. We should try and find a solution that allows for reliable orientation locking in iOS

Appears to be related to this:

Orientation issues have been resolved in this PR : https://github.com/mattrayner/cordova-plugin-vuforia/pull/84
Behavior now is the vuforia scanner will mimic accept the same orientations as its parent view (ie. the cordova view controller).


Show time disappear

20min( or management decision )Before show started it should be disappear and not allow users to book the ticket because staff will sell the tickets in counter at that time user booked seats may clashed with ticket's sold in counter

Nice to have a toggle button to make the active or deactivate  show bookings from the customers   in tickets_page.dart   admin app


[cmake] Fix check for debug static build of pcre2

The correct name is pcre2-8-staticd.lib, not pcre2-8d-static.lib.
If the static debug build is the only one available, the value of default_pcre_libraries would previously default to pcre.lib, and so there was a linking error if this library did not exist.
Now the library will be correctly detected, which avoids errors if the static debug build is the only one available.

Any chance this could be merged? This can be verified in the pcre2 cmake file:
The library name is pcre2-8-static:
https://github.com/PCRE2Project/pcre2/blob/44d95814f6414d40de6300817ae9d2bec0babc39/CMakeLists.txt#L703
And the d suffix comes after the library name, from CMAKE_DEBUG_POSTFIX:
https://github.com/PCRE2Project/pcre2/blob/44d95814f6414d40de6300817ae9d2bec0babc39/CMakeLists.txt#L584


onReset callback

I'd like to react to a form reset by supplying e.g. an onReset callback that is executed after a form was reset.
Is this already possible?
My concrete use case is an atom that holds display state of the form, but is not part of the form state itself. I'd like to be able to set this atom upon form reset. I did not put into the form state since modifying just the form display state should not cause the form state to  be dirty.

Can't you use the native onReset event? https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/reset_event
           <form
              onSubmit={form.submit(async (values) => {
                  await onSubmit(values, formActions);
              })}
              onReset={(event) => {
                form.reset();
                onReset?.(event);
              }}
              {...elementProps}
            >
              {typeof children === "function"
                ? children(form.fieldAtoms, formActions)
                : children}
            </form>

Or can you do something with derived state? https://jotai.org/docs/guides/composing-atoms#basic-derived-atoms

How would the onReset form event be triggered if I reset the form like this:
const formActions = useFormActions(formAtom);
formActions.reset();

I would personally use a native form reset. But to accomplish it programmatically, it's the same:
flushSync(() => {
  formActions.reset()
})

onReset();

That is, I don't see why this is needed in the library. You can just invoke the reset thing you're doing when you invoke the reset.

It is not needed, it would be nice to have. I have a component that listens to the dirty state of the form atom and displays save/discard buttons in case the form is dirty. When the discard button is clicked, the form is reset via formActions.reset().
Currently I have to prop drill the onReset callback to that component.
If the formAtom would execute it upon reset, the component would not need to be made aware of it.

There are ways to solve this with React/Jotai. Minor inconveniences are perfectly OK in software engineering and do not necessitate unnecessary abstractions (as my GitHub bio has trumpeted for years 😏)


avoid truncation of db:seed task comment

Fixes #59

Hi James. It is rather strange situation with tests.
I just edit task description and 3 of 4 my builds are failed.
Did you faced with it somewhen?

Hey @ivanovaleksey I'll have a look and see if I can re-create.

Hi James.
I force pushed the same commit and now all the tests have passed.
Maybe it was something with Travis CI last time.

Thanks @ivanovaleksey


The "Getting Started" page doesn't lead users the code editor

Starting from this page: https://pxt.microbit.org/getting-started, I can find no obvious way to navigate to the code editor.
The story:
A friend of mine had a micro:bit and wanted to know how to program it. I told them to look up "microbit pxt" and they landed on "getting started" page which seemed promising to them. However, they spent a while looking through the document and loading sample programs onto their micro:bit, but at no point could they figure out how to write programs themselves. They asked me "Is this how I program the micro:bit? Just downloading examples?"
Starting from the "Getting Started" page, it really isn't clear to new users that they should open a second tab and find the actual programming editor.

There is no real indication that one should click on the micro:bit "eyes" logo, but a second tab is not necessary.

Related to https://github.com/Microsoft/pxt/issues/887

Fixed with the new getting started experience.


Support for Feign logger

Feign logger support.
This PR does meet the code coverage requirements, but I'd like to get some comments on the general approach first. I was not able to work with the correlator-thing without a ThreadLocal. Perhaps a few changes could be made in the Feign project for a better overall result.

Thanks for the proposal!
Have you considered using Feign's Apache HttpClient support? Because logbook already has support for that one.
We generally prefer support for the underlying HTTP libraries, instead of the abstraction, as it would benefit more users.
As far as I can tell Feign supports:

[ ] JDK's HttpUrlConnection
[x] Apache HttpClient
[ ] OkHttp
[ ] Ribbon

Maybe we could target those, instead of Feign directly.

We're going change from HttpUrlConnection to Apache HttpClient, so that will let us use Feign+Logbook with the existing code.


Add Classes in CLASSPATH Automatically

It is counter-intuitive to Java developers needing to pass the current CLASSPATH as in "mirahc -cp $CLASSPATH" or "mirah -cp $CLASSPATH" to compile or run an application with dependencies.
You may want to consider adding classes in the CLASSPATH automatically.

Do you mean that it's weird that if you have CLASSPATH defined in your shell, that you'd expect mirahc to add it to the compile classpath, and mirah to add it to the runtime classpath?
I'll change it to follow java / javac's behavior, so the following happens:
mirah foo.mirah, uses default classpath: .
CLASSPATH=<my-cp> mirah foo.mirah, uses <my-cp>
CLASSPATH=<my-cp> mirah -cp <flag-cp> foo.mirah, uses <flag-cp>

Exactly.

Mirah's current default classpath is the destination path, maybe the classpath state machine should be
if cp flag, use flag
if CLASSPATH use CLASSPATH
else use destination
then if you do
mirahc -d classes a.mirah
mirahc -d classes b.mirah

where b depends on a, b will compile, even though -cp wasn't specified. I'll go with that, and see how I feel.

I think we should follow the same rules as java/javac, but your proposal also hits the mark.

I think 67d8898b00d6e2fe78305429933ca55193d660f8 should do it.

Thanks!


Windows App SDK GetWindowHandle code is incorrect

In the section "MessageDialog, and Pickers", the document says we can use WinRT.Interop.WindowNative.GetWindowHandle(this) to get the window handle, where this is an instance of App. However this call will raise an exception:
System.InvalidCastException:“Specified cast is not valid.”

The method should be called on the MainWindow but not the App.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37b65398-4a76-529e-e55d-24a710022b32
Version Independent ID: 37b65398-4a76-529e-e55d-24a710022b32
Content: User interface migration (including WinUI 3) - Windows apps
Content Source: hub/apps/windows-app-sdk/migrate-to-windows-app-sdk/guides/winui3.md
Product: reunion
Technology: get-started
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Thanks for letting us know, @taoyouh. Sorry about the coding error there. I've published a fix to that now.
Thanks again!
-Steve


[PHP] Update understood but no PR

Hi,
I have a composer.json in my project
https://github.com/the-benchmarker/web-frameworks/blob/d3077f9f6a03d49b4dc4652dd67076d691b10ac2/php/imi/composer.json#L3
In this file, there is imi at a version 1.0 and the bot detect that an update exists to 1.2.
However, I have not any PR concerning it.
Regards,
LOG : https://app.dependabot.com/accounts/the-benchmarker/update-logs/30316379

👋 Sorry for the slow reply.
This is a really old issue, from before Dependabot was integrated into native GitHub. We've shipped a lot of improvements since then, plus with time passing and people manually upgrading their packages, bugs like this tend to no longer be reproducible. So I'm going to close, but if for some reason I'm wrong and you're still affected/able to reproduce, please comment and we can reopen.

Checked the public repo just in the case and the issue is now fixed 💪.


Stopped loading

Hello.
Player stopped loading files overnight. Everything worked perfectly, but now it wont load a thing. Doesnt matter which format or size, simply keeps loading and if I try to forward in time, it gives codec errors even though those files worked before.
Any insight? Ive cleared data, cache, reinstalled etc. Its running on Android TV, newest version.

Try restarting your device. Some video decoder related resources may be exhausted (by this or other app).

I restarted and force stopped all apps. Still not loading anything. It loads runtime and subtitles data but nothing else.


ShowWindow doesn't seem to display text or title properly on MacOS or Linux

I'm atttempting to use the following, very simple, ShowWindow() call in my sample Photino app:
I'm using Photino.NET --version 3.0.14 and associated Photino.Native (>= 3.0.20) compiled & running on .NET Core 8.x
window.ShowMessage("first test","this is my text",PhotinoDialogButtons.OkCancel,PhotinoDialogIcon.Warning);
The ShowMessage looks correct in every way, except it doesn't display the entire title or text.
Instead, it only displays the first letter of each of the Strings.
Here's snapshot of the issue (running on macOS).  It looks the same running on Linux.
I don't have Windows available to try it there.

Looks like window.ShowSaveFile() also exhibits a similar behavior.
In this case I call the method and the default window title value is supposed to be "Save file" but as you can see (in the image below), it only displays the first character : S.


[Question] Hi how can I set csi-resizer to be deployed from proivate registry.

We have used longhorn-driver-deployer command , can we still use this pattern:
       - --csi-attacher-image
       -  {PRIVATE_REGISTRY}/quay.io/k8scsi/csi-attacher:v2.0.0
       - --csi-provisioner-image
       - {PRIVATE_REGISTRY}/quay.io/k8scsi/csi-provisioner:v1.4.0
       - --csi-node-driver-registrar-image
       - {PRIVATE_REGISTRY}/quay.io/k8scsi/csi-node-driver-registrar:v1.2.0

Yes. As long as the images are correct and do exist in your private registry, the image namespace/name/tag is not important.
BTW, you can also specify these images if you choose Rancher App to launch Longhorn.

Hi
Could you please guide me, how we can set it in yamls for csi-resizer component.

Add 2 lines here:
- --csi-resizer-image
- <The image in your private registry>

@shuo-wu Those should be in the example yaml, and the chart.

Will be covered by https://github.com/longhorn/longhorn/issues/812


fixed the translator button

#4188
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #4188
Description
fixed the translator button in the navbar section in all pages.

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before:

After:

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

can i do these in further pages of your website??

explain properly what have u done ? add before and after pics . or demo video .
cant understand what u have done as the pic is too much close up .

explain properly what have u done ? add before and after pics . or demo video .
cant understand what u have done as the pic is too much close up .

explain properly what have u done ? add before and after pics . or demo video .
cant understand what u have done as the pic is too much close up .

I fixed the close button of the translator @abhi03ruchi

in the login page , the close button is not working , so u have corrected that ?

in the login page , the close button is not working , so u have corrected that ?

can i do these in further pages of your website??

no , UI is ok .

in the login page , the close button is not working , so u have corrected that ?

can i do these in further pages of your website??

no , UI is ok .

yes I have corrected and also changes the translator close ui


Google Fitness Bad Request

I'm able to authenticate, to get datasources, but I'm not able to aggregate datasets.
Here my code:
$fitness = new Google_Service_Fitness($client);
$datasets = $fitness->users_dataset;
$aggBy = new Google_Service_Fitness_AggregateBy();
$bucketBy = new Google_Service_Fitness_BucketByTime();
$aggBy->setDataTypeName("com.google.step_count.delta");
$bucketBy->setDurationMillis("86400000");
$aggReq = new Google_Service_Fitness_AggregateRequest();
$aggReq->startTimeMillis = strtotime("-2 year");
$aggReq->endTimeMillis = time();
$aggReq->setAggregateBy($aggBy);
$aggReq->setBucketByTime($bucketBy);
$aggregates = $datasets->aggregate('me',$aggReq);
and here the exception generated by google service asnwer:
Message: { "error": { "errors": [ { "domain": "global", "reason": "invalidArgument", "message": "Require at least one aggregateby" } ], "code": 400, "message": "Require at least one aggregateby" } }
Code: 400
File: C:\wamp64\www\libs\google-api-php-client-2.2.0\src\Google\Http\REST.php
So is a problem of my code or is a problem of the library request?

It looks like a member of our great community answered your questions. Thanks Community! Please add a comment if you have any more questions and we can reopen this issue.


[DONE]: Translation of Installation

You can see below visual examples

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

No.
These are buttons embedded by CodeSandbox. Leave them as same.

I have a question regarding the sandbox section do I need to translate download, Fork, and reset as well?

No.
These are buttons embedded by CodeSandbox. Leave them as same.

Then this page is ready, I don't need to do anything else ?

Just translate the index in the SidebarLearn.json that match your page. Then someone from the maintainers will review it

Notice You've edited 3 files other than your page. That is not a right approach.
Turn them back and there is a separated PR for handling rtl.

Notice You've edited 3 files other than your page. That is not a right approach. Turn them back and there is a separated PR for handling rtl.

You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it?

You mean that for this PR I will return the the other files as they were and just edit in installation.md and SidebarLearn.json. Regarding the rtl handling am I supposed to handle it in another branch and create PR or someone else will handle it? @A7med3bdulBaset

Yes. Make yor PR for translation only so conflicts don't happen. Just translate two files:

installation.md
a key in sidebarlearn.json

Take this PR #473 as a guide example

There is already PR for rtl here #470

Translation only done in this PR. Thanks for helping

The PR has been merged successfully.
Your translation is great.
Go ahead and take another page.


Can't tap/select buttons that are hidden behind the scan button without activating the scan buton

As I'm navigating to a button at the bottom of the screen using talkback/voice over I can't tap/select the button when it's hidden behind the scan button. Example below: When I try to tap/select the "Start" button, the camera gets activated.

Device: iPhone 6
Build: Version 1.0.7 build 676

The content doesn't scroll enough to access the start button.

I tried on two different iphones, one with a 5.4" screen (the iPhone 6 is 4.7" so still a bit smaller) and it looks ok. Are you able to confirm if this is still an issue. It's quite an old ticket and I want to be sure that someone didn't already make an adjustment.
In the screen shot below I can scroll down far enough to make the "View" button not obscured by the scan button.

This issue is fixed by that extra padding then.


Memory leak in scene-viewer demo

When running the demo, the memory usage increases continually.

This is on the latest commit? What backend/hardware are you using?
I'll investigate in a bit.

Yes, with the latest commit in windows 10 vulkan with RTX2070.

Unfortunately I can't seem to replicate it on Windows/VK/1080ti. In what way were you measuring the amount of memory used?

In the task monitor, after about 5 minutes, it increases from 240MB to 500mB.

Alright, I can reproduce this, and likely know what the culprit is, wgpu's allocator growing tracking structures but never shrinking them. Following up with an issue on the allocator.

Alright, with the linked issue fixed, the leaks go away in release. There is still a leak in debug, which I suspect is related to the vulkan validation layers. Will investigate that separately.


Allow use of ssh agent instead of private and public key from file

Currently COMPATHELPER_PRIV must be specified if it's needed for committing and pushing changes.
Is it possible to have ssh agent running and using keys from them instead of explicitly having private key there?

So, when ssh -T <git server> is ran before compathelper, it works with ssh agent


[BUG] CodePipeline can't access GitHub repo

Required Basic Info

Accelerator Version:  1.5.1-a
Install Type: Clean

Describe the bug
I'm using the GitHub version. I'm using a Secrets Manager secret with a GitHub Personal Access token stored in Plain Text. The GH access token has all permissions given to it and is not expired. I'm also using a KMS key to encrypt the secret.
I'm getting the following error:
Could not access the GitHub repository: "aws-secure-environment-accelerator". The access token might be invalid or has been revoked. Edit the pipeline to reconnect with GitHub.
Failure Info

What error messages have you identified, if any:  Could not access the GitHub repository: "aws-secure-environment-accelerator". The access token might be invalid or has been revoked. Edit the pipeline to reconnect with GitHub.

Additional context
This is a clean new install and using the GitHub version (not the CodeCommit).

If you updated the secret, you MUST rerun the installer CFN stack - see step 8 here.


More optimizations

Added a new benchmark for serializing a large multi request. This unveiled some other easy optimizations that improves runtime and reduces the amount of allocations.
name                             old time/op    new time/op    delta
MultiToProto/cellblocks-16         5.25µs ± 0%    5.24µs ± 0%     ~     (p=0.171 n=10+10)
MultiToProto/no_cellblocks-16      5.05µs ± 0%    4.75µs ± 1%   -5.90%  (p=0.000 n=8+10)
MultiToProtoLarge/cellblocks-16    2.19ms ± 0%    1.74ms ± 1%  -20.58%  (p=0.000 n=8+10)

name                             old alloc/op   new alloc/op   delta
MultiToProto/cellblocks-16         3.42kB ± 0%    3.02kB ± 0%  -11.69%  (p=0.000 n=10+10)
MultiToProto/no_cellblocks-16      3.84kB ± 0%    3.44kB ± 0%  -10.42%  (p=0.000 n=10+10)
MultiToProtoLarge/cellblocks-16    1.99MB ± 0%    1.68MB ± 0%  -15.64%  (p=0.000 n=10+9)

name                             old allocs/op  new allocs/op  delta
MultiToProto/cellblocks-16           58.0 ± 0%      53.0 ± 0%   -8.62%  (p=0.000 n=10+10)
MultiToProto/no_cellblocks-16        64.0 ± 0%      59.0 ± 0%   -7.81%  (p=0.000 n=10+10)
MultiToProtoLarge/cellblocks-16     15.2k ± 0%     11.2k ± 0%  -26.33%  (p=0.000 n=10+10)

Codecov Report
Base: 67.88% // Head: 67.84% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (1091aec) compared to base (52e62bf).
Patch coverage: 82.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   67.88%   67.84%   -0.04%
==========================================
  Files          27       27
  Lines        3366     3381      +15
==========================================
+ Hits         2285     2294       +9
- Misses        972      976       +4
- Partials      109      111       +2

Impacted Files
Coverage Δ

hrpc/call.go
70.00% <0.00%> (-1.80%)
:arrow_down:

hrpc/mutate.go
87.65% <100.00%> (+0.23%)
:arrow_up:

region/info.go
59.37% <100.00%> (+1.31%)
:arrow_up:

region/client.go
80.88% <0.00%> (-0.70%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Spelling of Method is wrong in Helptext

The spelling of Method is wrong in the Method Name helptext. Please find attached screenshot.

If was fixed in https://github.com/jarrodek/ChromeRestClient/pull/745
The app will be updated soon.


Entity 5030

Issue #: /bcgov/entity#5030
Description of changes: Adjusted style to ux feedback:

Removed hover effect from table
Removed bottom border
Removed border that didn't reach across

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

LGTM
A lot of commits though? Was this branch cut off master on a new branch or was this from a previously merged branch perhaps?

I merged master back into it before merging because it had conflicts


Added ZeusCloud as list of companies using cartography

Details: https://github.com/Zeus-Labs/ZeusCloud

🎉 -- will be able to get the CLA thing early next week hopefully

@achantavy Sounds good. Let me know if I need to change anything. I tried to follow the CLA acceptance but ended up at a dead-end. Happy to change the PR as needed.

@surendrapathak - ok, CLA is working now, can you sign?

@achantavy Looks like CLA is cleared now.


[MB-15792] adding created and updated at columns to sit_address_updates table

Jira ticket
Summary
Migration that adds created_at and updated_at columns to sit_address_updates table
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Run migration
new columns should appear

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Messages

:book:
:link: MB-15792

  Generated by :no_entry_sign: dangerJS against 609f3ff09c9e06501da55523af8f14968d6fca32


Error: Coordinates must contain numbers

I'm getting this issue when running the tool on point data. I've tried it on various forms of point data, but it doesn't seem to work. It seems to be working on line data, however. Attached an image of the error I've been getting:

Good Morning, did you find a solution to your problem? I faced the same and still looking how to solve it.
Thank you!

Hi @Ramenlover & @ervinanoh
I suspect that this issue was caused by a change to a turf dependency that no longer handles empty geojson objects. I was able to add a null check in the tile creation process so that the Graph object can be created. Please see #94 for details!

@aalexsmithh i couldnt build the sharedstreets CLI . I have OSRM can u please guide me through.


[google_maps_flutter] ios build fix

Description
Create a new Flutter project with "flutter create"
Add the latest google maps flutter plugin in pubspec.yaml
build for iOS fails with latest version of XCode / Flutter SDK with error "GoogleMapsBase not found", because of GoogleMaps.framework headers:
#if __has_feature(modules)
@import GoogleMapsBase; <--- this is taken by default with a non-modified Flutter project
#else
#import <GoogleMapsBase/GoogleMapsBase.h>
#endif
This is a known issue, it has been solved for React Native : https://github.com/googlemaps/google-maps-ios-utils/pull/20/files
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[X] All existing and new tests are passing.
[X] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I read and followed the Flutter Style Guide.
[X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I signed the CLA.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[X] No, this is not a breaking change.

Some checks failed due to github timeouts (?), I re created this PR to have the checks run again, and have the green mark

@OreOreDa could you please edit the pubspec.yaml change version to 0.5.18 and also add a new changelog entry, not edit the current one?

Sure, Iska 👍 Done

LGTM. This fixes https://github.com/flutter/flutter/issues/34042


Add: api callback feature

Added the option to send an SMS or a push notification if a correction is found.
TODO:

[x]  rate limiting (maybe)

Awesome addition, thanks!


Error in displaying line flows?

Sometimes the branch flows are not identified correctly from the input file (or calculated?).
For example in the attached case pLfrom, qLfrom, pLto and qLto are in columns 14 to 17 of the branch matrix as specified in the matpower case format. On branch 1 these should be 10.00000742	71.85183455	-10.00000194	-68.69556371 respectively. But this power flow data is not displayed correctly in the visualizer. The reactive power flow is correct but Active Power Forward is .1745 and Active Power Reverse is -.1745.
case9_PF.zip

Sorry, I think this is my mistake for having voltage angle in radians rather than degrees in the example case.


tonal.min.js

Hi, trying to use the minified js file and getting this error:
Uncaught TypeError: Cannot read property 'toFreq' of undefined
    at tonal.min.js:1
    at tonal.min.js:1
    at tonal.min.js:1

Any advice?

Sorry, I didn't have time to test it before and... it's true! I'll try to fix it ASAP.
Thanks for reporting

It should be fixed now. Sorry for the inconveniences. Don't hesitate to reopen if the problem continues.


The database with q = 1024

Trying to create a database with q = 1024 and n = 1.
Is this supported? Any limitation for q?
<0.7629.0> cd536cbb12 req_err(1645417114) unknown_error : badarith
[<<"math:pow/2">>,<<"fabric_util:get_db_timeout/4 L160">>,<<"fabric_util:get_db/2 L114">>,<<"fabric:get_security/2 L183">>,<<"chttpd_auth_request:db_authorization_check/1 L112">>,<<"chttpd_auth_request:authorize_request/1 L19">>,<<"chttpd:handle_req_after_auth/2 L325">>,<<"chttpd:process_request/1 L310">>]
the error is produced by line 160 of src/fabric/src/fabric_util.erl
math:pow(Factor, N + 1)
and do not see a way to avoid this
Factor is not less then 2 by 111 line
Factor = max(2, config:get_integer("fabric", "shard_timeout_factor", 2))

A q factor is 1024 is probably not practical. The default is 2 and I even it the larger clusters I don't recall seeing anything larger than 256.
What are you trying to do?

OK. Now just testing the database of size about 10Tb
and follow the recommendation to keep a shard within 10Gb
https://neighbourhood.ie/blog/2020/09/22/sharding-choosing-the-right-q-value/
So the test database is q = 1024 and n = 2 but now only able to go with q = 256, n = 2

Hi,
what @nickva says, but I can reproduce this, See for more error messages: https://gist.github.com/big-r81/d244a22c36820c165ed63a105d6a092b

@ornotnull you can still go as high as 1022 or so (the highest limit is 1023 and there is a +1 so max q would be about 1022). But even with a 10TB I would stick with a smaller sharding factor.

@ornotnull thanks for reaching out and reporting the bug. Here is a PR that should fix it https://github.com/apache/couchdb/issues/4196

@nickva, thank you a lot
able to compile the new 3.2.2-228b07e version and no issue any more


use quay images in stepAction

The problem right now is that those images are expiring at some point. The image we refer here need to work tomorrow as well as in a year or 2.

i think only on-pr images expires. on-push images stay forever. isn't that true ?
secondly I am trying to nudge the action as well so as soon as we have new image konflux should update the digest


fix: change log msg for updating signatures validity

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merged as this is a fix for test case stability.


INFRA: Initialize Acceptance Tests

You should reference in your Pull Request comment that this request closes a specific issue. Most if not all PR's should reference a open Issue in the repository. This assures that another developer does not commit conflicting code to yours which creates conflicts that will have to be resolved.
Adding the statement below to your PR comment you added in the commit like so.
Closes #(issue number here)
Have questions please ask.


Propagate Harvester topology to guest cluster nodes

See https://github.com/harvester/harvester/issues/1418

/cc @yaocw2020 @ibrokethecloud

Replaced by https://github.com/harvester/cloud-provider-harvester/pull/20


Example Chart not rendered

Hey @Lanseuo ,
Thanks for fixing #1 . I tried boardify again today with example code in README.
While most part was smooth, bar chart in "Nicest Fruit" block wasn't visible. I am attaching screenshot.
I suspect data passing to chart.js.

Thanks.

Hello,
I'm sorry for the inconvenience. Could you please upgrade to the latest version and use the new example in README.md.
If the chart is still not visible, please open the developer tools of your browser (F12) and go to the tab "Console". Are there any errors?
Please also send me the generated HTML. You can find it here: view-source:http://localhost:7000/.

I’m closing this issue because it has been inactive for a few months. Please reopen if you still encounter this issue with the latest version.
Thank you!


Fix checkstyle to pass on 8.5 after upgrade from 6.19

Merging to clear checkstyle issues that block other PRs. post-merge PRs welcome.

for reference, per https://github.com/confluentinc/common/pull/151 which updated checkstyle version from 6.19 -> 8.5


Support .NET Framework

Yes, a deliberate pun on the #7's title :)
I am wondering why support for the framework had to go with the commits de521723 and 69fd9791. FParsec itself still targets as low as net40 (I think F# 4.1 may generate code only for net45 and above, though). It also seems that these changes did not require any APIs beyond 1.6, if I am not mistaken, so 2.0 seems too high for a library.
One of these commits did away with the README.md and LICENSE files by the way. It's not clear if that was intentional.

Warning: bitterness follows. This is not your fault. You seem to be a nice person!
No reason. If I did something in the course of attempting to support .NET Standard, and it doesn't make sense to you, it's almost certain the answer is "I didn't know what I was doing". If it's any consolation, there have been no improvements from 0.4.0 to 1.0.0 so if you have a .NET framework project, using 0.4.0 does not hurt you at all.
I went through a rampage back in July trying to get all my libraries compatible with .NET Standard as fast as possible so I could ultimately do the same for Rezoom.SQL. I think at the time I figured .NET Standard 2.0 would be a simple way to go across the board and would work for FParsec-Pipes, LicenseToCIL, Rezoom, and Rezoom.SQL. This consumed an otherwise nice evening, helped absolutely nobody and, since I didn't manage to make the type provider work on .NET Core and gave up, it actually broke Rezoom.SQL for anyone who updates its dependencies to the max version. I should've released the .NET standard versions of FParsec-Pipes and LicenseToCIL as RC or beta versions, but, in my immense hubris, did not.
There is a chance that I could enjoy coding new features on any of these projects, but it will not happen because the cloud of attempting and failing to support .NET standard casts a wide shadow of shame on all of them. Arguably that is my fault for not putting enough effort into the attempt. But it's unappealing to use my copious free time just keeping up with a treadmill of tooling changes when the code remains exactly the same. What's remarkable is how using a new technology can be fun but applying it to code you've filed away as "done" is about as far from fun as you can get.
In conclusion if I was going to do something to rectify this, it would be to release a v2.0.0 going right back to .NET Framework only and just pretend core/standard do not exist. I think this would work well for my own other libraries that depend on each other, but I don't know if other users would be screwed over. One possible user of the .NET Standard version would be GraphQL-net by my friend @ckimes89 but I don't think he has updated to it anyway.

Oh, I do feel for you! This whole .NET Core business felt like a beta or an RC all the way through (DNX? project.json? Back to MSBuild?). Fortunately, they seem to have settled on something working in the long term at last. F# support also lagged behind C#/VB.

Arguably that is my fault for not putting enough effort into the attempt.

Not at all, don't blame yourself! This whole thing was a rollercoaster. I hope is "was", not "has been"--at the least, it has slowed down.

This consumed an otherwise nice evening

If I could count mine! :(
Let me see if I can make a concise multitargeting PR.

BTW, the lazy me finally figured out the DisableImplicitFSharpCoreReference and why my internal packages were targeting an FSharp.Core version higher than I specified. So this was quite a helpful digression! http://msbuildlog.com/ is da tool!


Add mumak to Builder Tools

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Please complete a Checklist
Fill in all sections of the template
Click "Create pull request"

Checklist
<-- Please fill the boxes with [x] before submitting a pull request -->

[x] I have read the How to Contribute.
[x] I have read the Builder Tool Requirements
[x] I have run yarn build after adding my changes without getting any errors.

Builder Tool addition
<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the builder-tools.js -->

Title:  Mumak
Description: A custom PostgreSQL extension to interact with Cardano CBOR data directly.
Website:  Github
Getstarted: Install
Tags:

rust
chainindex
sql
lowlevel

I am not able to resolve the conflicte although it seems trivial.

@Mercurial sorry for some reason resolving the conflict needs to come from your side.

Thanks for the quick response, unfortunately build checks are failing.

yep was still resolving it but should be good to go now @katomm :D

Appreciated @Mercurial


feat: add hgctl manifest support

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #554 (ed14602) into main (fab734d) will decrease coverage by 1.67%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   39.17%   37.51%   -1.67%
==========================================
  Files          59       65       +6
  Lines        7772     9176    +1404
==========================================
+ Hits         3045     3442     +397
- Misses       4484     5468     +984
- Partials      243      266      +23

Files Changed
Coverage Δ

pkg/cmd/hgctl/config_bootstrap.go
0.00% <ø> (ø)

pkg/cmd/hgctl/config_cluster.go
0.00% <ø> (ø)

pkg/cmd/hgctl/config_cmd.go
0.00% <ø> (ø)

pkg/cmd/hgctl/config_endpoint.go
0.00% <ø> (ø)

pkg/cmd/hgctl/config_listener.go
0.00% <ø> (ø)

pkg/cmd/hgctl/config_retriever.go
21.59% <0.00%> (ø)

pkg/cmd/hgctl/config_route.go
0.00% <ø> (ø)

pkg/cmd/hgctl/dashboard.go
0.00% <0.00%> (ø)

pkg/cmd/hgctl/install.go
0.00% <0.00%> (ø)

pkg/cmd/hgctl/manifest.go
0.00% <0.00%> (ø)

... and 4 more

... and 5 files with indirect coverage changes


HDDS-1550. MiniOzoneCluster is not shutting down all the threads during shutdown. Contributed by Mukul Kumar Singh.

Creating a new pull request.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
31
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
64
Maven dependency ordering for branch

+1
mvninstall
487
trunk passed

+1
compile
252
trunk passed

+1
checkstyle
74
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
851
branch has no errors when building and testing our client artifacts.

+1
javadoc
159
trunk passed

0
spotbugs
305
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
505
trunk passed

_ Patch Compile Tests _

0
mvndep
31
Maven dependency ordering for patch

+1
mvninstall
423
the patch passed

+1
compile
272
the patch passed

+1
javac
272
the patch passed

+1
checkstyle
74
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
644
patch has no errors when building and testing our client artifacts.

+1
javadoc
156
the patch passed

+1
findbugs
518
the patch passed

_ Other Tests _

+1
unit
259
hadoop-hdds in the patch passed.

-1
unit
1483
hadoop-ozone in the patch failed.

+1
asflicense
50
The patch does not generate ASF License warnings.

6475

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.TestContainerStateMachineIdempotency

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.scm.node.TestQueryNode

hadoop.ozone.TestStorageContainerManager

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1050

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a6aa7a4f57f4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 15d82fc

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/1/testReport/

Max. process+thread count
5357 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
12
https://github.com/apache/hadoop/pull/1050 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/1050

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/2/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
71
Maven dependency ordering for branch

+1
mvninstall
526
trunk passed

+1
compile
268
trunk passed

+1
checkstyle
82
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
892
branch has no errors when building and testing our client artifacts.

+1
javadoc
167
trunk passed

0
spotbugs
314
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
507
trunk passed

_ Patch Compile Tests _

0
mvndep
34
Maven dependency ordering for patch

+1
mvninstall
437
the patch passed

+1
compile
252
the patch passed

+1
javac
252
the patch passed

+1
checkstyle
73
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
674
patch has no errors when building and testing our client artifacts.

+1
javadoc
161
the patch passed

+1
findbugs
598
the patch passed

_ Other Tests _

+1
unit
264
hadoop-hdds in the patch passed.

-1
unit
1948
hadoop-ozone in the patch failed.

+1
asflicense
56
The patch does not generate ASF License warnings.

7221

Reason
Tests

Failed junit tests
hadoop.ozone.TestStorageContainerManager

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.scm.node.TestQueryNode

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1050

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux db574bf4cd12 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9c90729

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/3/testReport/

Max. process+thread count
5344 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
31
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
466
trunk passed

+1
compile
245
trunk passed

+1
checkstyle
59
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
816
branch has no errors when building and testing our client artifacts.

+1
javadoc
161
trunk passed

0
spotbugs
305
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
496
trunk passed

_ Patch Compile Tests _

0
mvndep
28
Maven dependency ordering for patch

+1
mvninstall
417
the patch passed

+1
compile
255
the patch passed

+1
javac
255
the patch passed

-0
checkstyle
35
hadoop-ozone: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
616
patch has no errors when building and testing our client artifacts.

+1
javadoc
138
the patch passed

+1
findbugs
503
the patch passed

_ Other Tests _

-1
unit
253
hadoop-hdds in the patch failed.

-1
unit
1422
hadoop-ozone in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

6188

Reason
Tests

Failed junit tests
hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1050

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6741665d49d0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ec851e4

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/testReport/

Max. process+thread count
5314 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
76
Maven dependency ordering for branch

+1
mvninstall
552
trunk passed

+1
compile
260
trunk passed

+1
checkstyle
70
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
866
branch has no errors when building and testing our client artifacts.

+1
javadoc
157
trunk passed

0
spotbugs
352
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
573
trunk passed

_ Patch Compile Tests _

0
mvndep
32
Maven dependency ordering for patch

+1
mvninstall
460
the patch passed

+1
compile
251
the patch passed

+1
javac
251
the patch passed

+1
checkstyle
71
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
691
patch has no errors when building and testing our client artifacts.

+1
javadoc
169
the patch passed

+1
findbugs
545
the patch passed

_ Other Tests _

+1
unit
246
hadoop-hdds in the patch passed.

-1
unit
1599
hadoop-ozone in the patch failed.

+1
asflicense
46
The patch does not generate ASF License warnings.

6860

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.TestMiniChaosOzoneCluster

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1050

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d4680d08f996 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ec851e4

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/5/testReport/

Max. process+thread count
5261 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1050/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


feat: publish to github pages

The score-spec org and repos are in the process of being moved over to the CNCF. As part of this we'd like to reduce the attachment to Humanitec which has since been sponsoring DNS and hosting for the docs/website.
This PR adds the CI steps to begin publishing through GH pages and no longer push to Humanitec's deployment pipeline.
The preview can be seen here: https://score-spec.github.io/docs/docs/. Note that the URL will be prettier once we can verify the custom domain for docs.score.dev.

LGTM
Note: out of scope of this one, but just to confirm, we won't be able to have a preview env for each PR in the future with this hosting option (GitHub pages)?

@mathieu-benoit there are ways to do it. It'll be best to do it after we've moved the domain over. Until then, doing a local preview works correct and the instructions are up to date so I'd suggest folks use that in the meantime.


Add vertical center alignment into DefaultMonthHeader

I think center vertical alignment is needed in DefaultMonthHeader.

@jeongth9446 Sorry for making you wait this much time, I was on vacations. Thank you very much for your contribution, could you just add a screenshot with your change visible to the description of the PR?

Thank you for your interest in my PR.
There will be no problem with the default font size of most devices, but if the font size displayed changes, the alignment may be distorted.
below AS-IS is issue case.
AS-IS

TO-BE (adding verticalAlignment)


[Doc] Validation for adding documentation on how to use SQLModel with AsyncSession

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from typing import Optional
from fastapi import FastAPI
from sqlmodel import Field, SQLModel, select
from sqlmodel.ext.asyncio.session import AsyncSession
from sqlalchemy.ext.asyncio import create_async_engine

sqlite_file_name = "database.db"
sqlite_url = f"sqlite+aiosqlite:///{sqlite_file_name}"
connect_args = {"check_same_thread": False}
engine = create_async_engine(sqlite_url, future=True, echo=True, connect_args=connect_args)

class Hero(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    name: str
    secret_name: str
    age: Optional[int] = None

app = FastAPI()

@app.on_event("startup")
async def startup():
    # create db tables
    async with engine.begin() as conn:
        await conn.run_sync(SQLModel.metadata.drop_all)
        await conn.run_sync(SQLModel.metadata.create_all)

@app.post("/heroes/")
async def create_hero(hero: Hero):
    async with AsyncSession(engine) as session:
        session.add(hero)
        await session.commit()
        await session.refresh(hero)
        return hero

@app.get("/heroes/")
async def read_heroes():
    async with AsyncSession(engine) as session:
        heroes = await session.exec(select(Hero))
        return heroes.all()

Description
What would be the best way to use async / await with the AsyncSession ?
I've implemented a first draft here :
fastapi-async-sqlmodel
But I feel like there is a better solution than using the aiosqlite driver.
If you think this is the proper way to use async / await, I will try to add it to the documentation.
Wanted Solution
I would like to add some documentation on how to use async / await with the SQLModel AsyncSession
Wanted Code
NA

Alternatives
No response
Operating System
Linux, Windows, macOS, Other
Operating System Details
No response
SQLModel Version
0.0.4
Python Version
3.7.9
Additional Context
No response

thanks for that repo @Cedric-Magnan really helpful w setting up async functions

@Cedric-Magnan
Thanks for the example ! How can I adapt it to work with postgresql ?
I'm using a well-known docker image (postgres:13.0-alpine) to launch a container that runs a postgresql db server.
However, I'm getting the following exception from sqlalchemy:
sqlalchemy.exc.InvalidRequestError: The asyncio extension requires an async driver to be used. The loaded 'psycopg2' is not async.


Add fail2ban & iptables

Can you add those and make it configurable? It's to protect our PBX from outside

In the freepbx docker image, fail2ban requires --privileged, which is very discouraged in add-ons and would require a manual step in the installation. Not to mention it would decrease the score of the add-on in overall to 1, I think.

Yeah , but protecting an local hosted app is also important, so I dont care about score :-)

In the freepbx docker image,

Is this also the case with asterisk rather than FreePBX?

I think that if we manage to make https://github.com/TECH7Fox/Asterisk-add-on/issues/56 work, we won't need to have any port exposed outside.

@pergolafabio I think the best thing that can be done is to leverage fail2ban from Home Assistant for the job, as in #178. I'm closing this issue in favor of #178, but if you disagree we can reopen.


Error 1 when running Invoke-CMApplyDriverPackage.ps1 in Task Sequence

We've been running an older version (2.x) for a long time and have just upgraded to V 4.2.0. Unfortunately, it isn't working with no clear understanding of why not. When re run the script as part of a task sequence, the step fails with error code 1.
If we run it in debug on a machine (that isn't the same make/model) and define the make/model as the examples, we see that it is able to detect the make/model and drivers successfully when we look at the logs at C:\Windows\Temp\ApplyDriverPacakge.log.
\Invoke-CMApplyDriverPackage.ps1 -DebugMode -Endpoint "SiteURL" -UserName "username" -Password "password" -TargetOSVersion 21H2 -Manufacturer "Dell" -systemSKU "0A53" -TargetOSName "Windows 10" -ComputerModel "7090"
We have verified that the admin service is working, that the account credentials are correct, and that the make/model exist in SCCM. We are defining the TargetOSName as well, which is new to us. Here's the command we're running, if it helps.
-BareMetal -EndPoint "siteURL" -TargetOSName "Windows 10" -TargetOSVersion "21H2"
Any ideas or are there ways to troubleshoot this? I do agree with a different poster that the download file for 4.2.0 is different than the raw 4.2.0 view in GitHub so we're using the version we copied from the Raw view (the download version threw a bunch of different errors).

I was finally able to get into WinPE and run the script manually to see any output and it simply gives a runtime error so not a whole lot of information there.

So I figured out the issue. Once I found the ApplyDriverPackage.log file in WinPE, it was a relatively easy series of issues to troubleshoot. Not sure if this is documented elsewhere but that path is X:\Windows\temp\SMSTSlog. Once I discovered that, we found that we had models that didn't have current driver packages, we had models OS Version issues with the driver packages, etc. We resolved those and are imaging with v. 4.2.0 successfully.


generate a different type for each peripheral instance

closes #65
barely tested. Seems to work though

As I've heard no complains, have received positive feedback through other channels and I've tested this more thoroughly, I'm going to go ahead and land this.
@homunkulus r+

:pushpin: Commit 74f1c3e has been approved by japaric

:hourglass: Testing commit 74f1c3e with merge 74f1c3e...

:sunny: Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 74f1c3ec9cc7ba912be8e9f005732690008314e0 to master...


[ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis

What is this PR for?
There are 6 errors occuring with error: "yarn config set cache-folder /tmp/ZeppelinLTest_1494573109020/helium-bundle/yarn-cache --registry=http://registry.npmjs.org/' failed."
The failures seem to occur because the "yarnCacheDir" directory is not created. For this, I have added code to create the directory before the absolute path is stored in yarnCacheDirPath.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2469
How should this be tested?
The tests should pass on the CI
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@pravin-dsilva Thanks for the contribution.
To enable jenkins, you have to setup your own travis for your zeppelin fork repository.

We also need to enable the HeliumBundleFactoryTest on CI by removing it from -Dtests.to.exclude variable in .travis.yml

Flaky test failure https://issues.apache.org/jira/browse/ZEPPELIN-2361  is not related to this contribution.
Tests in error:
  ParagraphActionsIT.testRunOnSelectionChange:306 Â» StaleElementReference Elemen...

Thanks @pravin-dsilva for the fix!
LGTM and merge to master if no further comment.


[Enhance] ChoicesParam for LoudnessClient and PitchClient

In keeping with the consistency of SpectralShape and BufStats, I think that Loudness should also include a ChoicesParam. This implements it in what I thought was the most similar way to SpectralShape and which is stylistically pretty much the same.

I've added myself and Ted here as reviewers as this will need an interface discussion. To unpick:

if we do it, pitch should have it too, obviously, as the only other non-multivariate descriptor
in effect, neither of those actually need this interface per se if we stick to their original raison d'être: select was invented to remove an object in the workflow when one or more non-contiguous items were desired (mean and max for instance). The 'bonus' of providing the name of what channel is what was good but just because there was a lot of them... otherwise, we would need MFCC0 and MEL0 and all those guys, which are uselessly complicating the interface.
I think that not having them in the 101 videos is more pedagogically fruitful than having them. @numchans is a bit harder but yields a lot more potential.

Now, we can discuss it all. if we agree on the last point, we can park this to v1 milestone.

if we do it, pitch should have it too, obviously, as the only other non-multivariate descriptor

I agree. The code is a little more entangled because the client handles scaling and replacing poor measurements (0hz) and I couldn't untangle it myself. It should, IMO, be a separated PR regardless.

in effect, neither of those actually need this interface per se if we stick to their original raison d'être: select was invented to remove an object in the workflow when one or more non-contiguous items were desired (mean and max for instance). The 'bonus' of providing the name of what channel is what was good but just because there was a lot of them... otherwise, we would need MFCC0 and MEL0 and all those guys, which are uselessly complicating the interface.

I think that this line of reasoning is needlessly overthinking it. People, including myself and those I have helped in their patching regularly just want one of the things out of these objects and this removes an object to do so and makes the code self documenting. It is unlikely you would decouple several MFCCs that are non-contiguous and separated from each other in a non-programmatic way. There is also the argument of consistency, in that these "semantic" multi-channel outputted descriptors (unlike mel/mfcc/stft) could be made more homogenous in their interface. This is good for all the reasons that are purported in previous discussions related to interface. I am thinking here of the differences between sourceA / source1 between objects, or references to interpolation being named differently.

I think that not having them in the 101 videos is more pedagogically fruitful than having them. @numchans is a bit harder but yields a lot more potential.

I've always found numChans and startChan hand-wavey to be honest. Again, it comes back to the notion of the code being expressive and self-documenting. We want loudness so we write loudness. We want confidence, we write confidence. Sometimes people will care which channel you need to extract from a multivariate descriptor, but in this case it's only ever 2 so enforcing people to care about the layout feels like an imposed difficulty that adds nothing to the usefulness of these objects. Furthermore, a select parameter doesn't exclude people using fluid.bufselect~ or numChans. I would advocate any day to give people across a wide range of dispositions options. You like counting arrays and being particular about the layout of data and lots hate it and want to get The Thing :)

I find most of your arguments compelling, although I am not certain that removing programmatic notions of the 101s is a good idea. We can talk about it quickly in tomorrow's meeting to see the best way forward with the various milestones and deadlines.

Yes what you just say there are the arguments I read in the previous answer, and that I find very convincing. You know I love consistency of interface. we could even say I'm obsessed :)

@weefuzzy can you please implement PitchClient thank you

This entails changes for SC classes as well : https://github.com/flucoma/flucoma-sc/pull/101

Should we just merge this in since the other select PRs have already been merged?

Should we just merge this in since the other select PRs have already been merged?

I think so. I'm going to merge the core changes and then the SC classes so the nightlies work.


Lat-Lng Map Cypress test is failing

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Two layers:

fix failing cypress tests. there are actually 4 failing tests right now that need to be fixed.
update CI/CD to run these on every PR, not at night


Can you please provide 'gtav_label_info.p' this file?

Dear Lai,
I'm interesting in your work, and preparing following your work.
The GTA5 dataset link doesn't provide this, can you please provide one for your work?
Dexin

Find one in https://github.com/BIT-DA/SDCA/tree/main/datasets. Thanks a lot!

Dear Lai,
I am writing to inquire about a potential issue I am encountering while attempting to replicate your code. During training, I have noticed that the MIoU value does not seem to be improving, and I have downloaded the neural network structure you described in your first step. Unfortunately, the MIoU value is still incorrect.
Furthermore, the GTA5 dataset available on the official website is quite slow to download, so I decided to use the OpenDataset website for download. However, I am also encountering issues with the ".p" file being missing, which could potentially lead to errors.
I would greatly appreciate it if you could provide me with some guidance on how to address this issue. Additionally, if it is possible to communicate directly via QQ or WeChat, that would be greatly appreciated.
Thank you for your time and assistance.
Dexin

Evaluation iter =    50/  372, loss_eval = 8.119
Evaluation iter =   100/  372, loss_eval = 7.596
Evaluation iter =   150/  372, loss_eval = 8.677
Evaluation iter =   200/  372, loss_eval = 8.238
Evaluation iter =   250/  372, loss_eval = 8.813
Evaluation iter =   300/  372, loss_eval = 8.292
Evaluation iter =   350/  372, loss_eval = 7.552
Val result: mIoU = 0.021
Class_0 Result: iou = 0.396
Class_1 Result: iou = 0.000
Class_2 Result: iou = 0.000
Class_3 Result: iou = 0.000
Class_4 Result: iou = 0.000
Class_5 Result: iou = 0.000
Class_6 Result: iou = 0.000
Class_7 Result: iou = 0.000
Class_8 Result: iou = 0.000
Class_9 Result: iou = 0.000
Class_10 Result: iou = 0.000
Class_11 Result: iou = 0.000
Class_12 Result: iou = 0.000
Class_13 Result: iou = 0.000
Class_14 Result: iou = 0.000
Class_15 Result: iou = 0.000
Class_16 Result: iou = 0.000
Class_17 Result: iou = 0.000
Class_18 Result: iou = 0.000
End Evaluation


Remove extra format in kubectl describe

e.g
Mon, 26 Jan 2015 19:20:20 +0000	{kubelet kubernetes-minion-2.c.lucid-walker-725.internal}	spec.containers{lsj-pod}		started		Started with docker id ba8927d7305c0e9f8ff4977a65896facae3727738ca0c84a6161dfb21b95cd62	%!v(MISSING)

Wondering why go just silently accepts it...

LGTM


[5.1] Return the result of pushing a job onto a queue in the dispatcher.

When dispatching a job onto a queue when using the database driver I wasn't receiving the job id as a return value. This adds the returns to the Dispatcher to return the queue push return value.
Test
In a controller:
$this->dispatch(new Job()) !== null

By design, dispatch shouldn't really be returning anything at all.

Whichever way I think we need consistency here. dispatchNow() returns the result of the handler, and pushCommandToQueue() returned all push results (lines 259, 263, 267) except the fall through. Hence my assumption that the dispatcher should be returning a dispatch result and that there were a few missing returns.
The queue implementations I looked at all return the result of pushing onto the queue with a unique identifier for later interaction with that Job instance. We can use the queue's directly but that sort of negates the convenience of having a dispatcher?


@internal serialization

Recently, I stumbled on https://smithy.io/2.0/spec/type-refinement-traits.html?highlight=internal#default-value-serialization
This is a section related to the default trait, but used in conjunction with @internal. Then I realized our implementation over at https://github.com/disneystreaming/smithy4s did not deal with @internal. So I implemented it.
To me it was clear: @internal are not meant to be serialized. But after a round of reviews, other maintainers felt like the documentation only specified that @internal should not be serialized if used with @default. And I guess we can say that this makes sense, but also it's also kind of counter-intuitive.
So my question is: should a server ever serialize fields annotated with @internal?
Ref: https://smithy.io/2.0/spec/documentation-traits.html?highlight=internal#internal-trait https://smithy.io/2.0/spec/type-refinement-traits.html?highlight=internal#default-value-serialization

Yes, a server should serialize fields annotated with internal (otherwise those members wouldn't be useful for anything other than requests). There are caveats mentioned around whether to serialize defaulted values marked as internal, but those are shoulds not musts.


Use locate_many to avoid N+1

Enhancement
Description
To make room for the redesigned functionality, I added another resolver, Resolver::Resources.
This resolver will partition the incoming resource definitions into those that have an SGID and those that don't, and treat them differently.
Because I was referring to a data clump of signed_params, sgids etc. all the time, I wrapped them into a new class ResourceDefinition. It's capable of returning a selector and a controller.
I left the resolution of a renderer outside this class and put it into a renderer_for method, because it needs a connection attribute to function, which would have blurred the boundaries if it went into ResourceDefinition.
It's a bit weird to have it in Resolver::Resources in the first place, but I think I can live with that until a further refactoring.
Closes #78
Why should this be added
The core value of this is a performance improvement by using locate_many, which will avoid N+1 queries in the event that more than one element with an SGID attached should be present.
Checklist

[X] My code follows the style guidelines of this project
[X] Checks (StandardRB & Prettier-Standard) are passing

@rickychilcott would you do me the honor to take a look at this?

I took a look and it looks very reasonable. My only comment is that as we expand the API to add more and more options... extracting the ResourceDefinition into its own dedicated resolver to simplify each piece of the processing of requests coming in. ResourceDefinition being a private class (and utilizing comments to explain the structure) leads me to believe it should be extracted.
Not needed right now unless you agree, but maybe in the future.
👍

I know what you’re after but I think I’ll merge this and defer the refactor until we actually need it!


Refactor: Day of the month does not propagate from custom schedule to easy scheduling

Description
When the schedule starts as 0 0 15 * * (00:00 on the 15th of the month):

… and then the user switches to "Month" scheduling:

… the day of the month does not propagate to the input, but the time does.
Reproduce

Schedule is 0 0 15 * *  (00:00 on the 15th of the month)
Click "Edit job definition"
Drop down "Interval," pick "Month"
Error: "Day of the month" is blank

Expected behavior
Day of the month should be "15".
Context
Found while validating #238.

This is likely because state is duplicated.
Another side effect of this: setting the time to be invalid, and then changing the create form from "create job definition" to "create job" causes the time error to continue to block the form, but it shouldn't:
https://user-images.githubusercontent.com/93281816/199365112-8ee2dc3d-9393-4e7d-99a7-14088e62c51d.mov

This is fixed by #261, but now validation errors are no longer reinstated after switching back to "run on a schedule". We think this is fine for now, as the edge case of an invalid cron expression is caught by the backend anyways, and is much better than the fatal possibility of being unable to create jobs.

Errors not being reinstated are covered by #262.


README.md: 'customization' link is broken

The 'c' is cyrillic. See attached screenshot:

A simple grep command can be added to the lint / build server to avoid confusion.

closed by #125


feat(u): Hexstring class

This is tryout for solution to https://github.com/CityOfZion/neon-js/issues/480.
I have created below types:

HexString
ScriptHash
PublicKey
Address
And I have tried to use them in Class Cosigner and TransactionAttribute.

And Let's talk about several design issues about this feature:

Where should we put these types, and what's the relation between these types and old type-converting apis.
Suggestion: We put these types into module u, and stop exporting old type-conversion apis like str2hextring and include them into these types, to avoid confusions.

-Like interfaces
The -Like interfaces (e.g. CosignerLike) mostly use string as type, and they will be used to type param for constructors. So shall change the -Like interfaces to use new types.
Currently I create a new interface -Config to act as the param for constructor.

Please focus on the hexstring class first. The others can be filled in later.

Now only HexString class is left. And let's settle this first.

300 points morgandream
200 points snowypowers for review

https://neoscan.io/transaction/44C84C9E7582DC00411BC9D9D075F6993BA7E203FFDDE366E21DFEBD125EA580


Fix some spelling errors in README

did a quick spell-check, reaveal.js :stuck_out_tongue_closed_eyes:

Thank you 👍


Create Rails Ruby LSP extension to display model columns on hover

Create a Rails Ruby LSP server extension to be the our first use case for the new system. We'll start simple, trying to understand requirements and issues by only implementing showing column information when hovering a model.

https://github.com/Shopify/ruby-lsp-rails 🎉


aarch64 : CompileError

from devito import *
import matplotlib.pyplot as plt
def solver(I, dt, T, eqs):
```Nt = int(round(T/dt))
```t = TimeDimension('t', spacing=Constant('h_t'))
```u = TimeFunction(name='u', dimensions=(t,),
                     shape=(Nt+1,), space_order=2, time_order=1)
```u.data[:] = I
```eqn = eval(eqs)
```stencil = Eq(u.forward, solve(eqn, u.forward))
```print(stencil)
```op = Operator(stencil)
```op.apply(h_t=dt, t_M=Nt-1)
```return u.data, np.linspace(0.0001, Nt*dt, Nt+1),op.ccode

u,t,ccode = solver(1, 0.001,2, r'u.dt-u ')

print(u[-1])

CompileError :
undefined reference to `main'
---------------------------------------------------------------------------
CompileError                              Traceback (most recent call last)
Cell In[11], line 18
     15     op.apply(h_t=dt, t_M=Nt-1)
     16     return u.data, np.linspace(0.0001, Nt*dt, Nt+1),op.ccode
---> 18 u,t,ccode = solver(1, 0.001,2, r'u.dt-u ') # a=0.01
     20 print(u[-1])

Cell In[11], line 15, in solver(I, dt, T, eqs)
     13 print(stencil)
     14 op = Operator(stencil)
---> 15 op.apply(h_t=dt, t_M=Nt-1)
     16 return u.data, np.linspace(0.0001, Nt*dt, Nt+1),op.ccode

File ~/miniconda3/lib/python3.11/site-packages/devito/operator/operator.py:832, in Operator.apply(self, **kwargs)
    830 arg_values = [args[p.name] for p in self.parameters]
    831 try:
--> 832     cfunction = self.cfunction
    833     with self._profiler.timer_on('apply', comm=args.comm):
    834         cfunction(*arg_values)

File ~/miniconda3/lib/python3.11/site-packages/devito/operator/operator.py:714, in Operator.cfunction(self)
    712 """The JIT-compiled C function as a ctypes.FuncPtr object."""
    713 if self._lib is None:
--> 714     self._jit_compile()
    715     self._lib = self._compiler.load(self._soname)
    716     self._lib.name = self._soname

File ~/miniconda3/lib/python3.11/site-packages/devito/operator/operator.py:699, in Operator._jit_compile(self)
    697 if self._lib is None:
    698     with self._profiler.timer_on('jit-compile'):
--> 699         recompiled, src_file = self._compiler.jit_compile(self._soname,
    700                                                           str(self.ccode))
    702     elapsed = self._profiler.py_timers['jit-compile']
    703     if recompiled:

File ~/miniconda3/lib/python3.11/site-packages/devito/arch/compiler.py:360, in Compiler.jit_compile(self, soname, code)
    358 with warnings.catch_warnings():
    359     warnings.simplefilter('ignore')
--> 360     _, _, _, recompiled = compile_from_string(self, target, code, src_file,
    361                                               cache_dir=cache_dir, debug=debug,
    362                                               sleep_delay=sleep_delay)
    364 return recompiled, src_file

File ~/miniconda3/lib/python3.11/site-packages/codepy/jit.py:439, in compile_from_string(toolchain, name, source_string, source_name, cache_dir, debug, wait_on_error, debug_recompile, object, source_is_binary, sleep_delay)
    437     toolchain.build_object(ext_file, source_paths, debug=debug)
    438 else:
--> 439     toolchain.build_extension(ext_file, source_paths, debug=debug)
    441 if info_path is not None:
    442     import pickle

File ~/miniconda3/lib/python3.11/site-packages/codepy/toolchain.py:211, in GCCLikeToolchain.build_extension(self, ext_file, source_files, debug)
    208 import sys
    209 print("FAILED compiler invocation: {}".format(" ".join(cc_cmdline)),
    210       file=sys.stderr)
--> 211 raise CompileError("module compilation failed")

CompileError: module compilation failed

What's the actual compilaton error? And what's your configuration (DEVITO_ARCH, DEVITO_PLATFORM, DEVITO_LANGUAGE)

What's the actual compilaton error? And what's your configuration (DEVITO_ARCH, DEVITO_PLATFORM, DEVITO_LANGUAGE)
below is the error output:
/root/miniconda3/bin/../lib/gcc/aarch64-conda-linux-gnu/9.5.0/../../../../aarch64-conda-linux-gnu/bin/ld: /root/miniconda3/bin/../aarch64-conda-linux-gnu/sysroot/usr/lib/../lib/Scrt1.o: in function _start': (.text+0x18): undefined reference to main'
/root/miniconda3/bin/../lib/gcc/aarch64-conda-linux-gnu/9.5.0/../../../../aarch64-conda-linux-gnu/bin/ld: (.text+0x1c): undefined reference to `main'
collect2: error: ld returned 1 exit status
FAILED compiler invocation: /root/miniconda3/bin/aarch64-conda-linux-gnu-cc -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem /root/miniconda3/include -Wl,-O2 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--allow-shlib-undefined -Wl,-rpath,/root/miniconda3/lib -Wl,-rpath-link,/root/miniconda3/lib -L/root/miniconda3/lib /tmp/devito-jitcache-uid0/d3ed1cb2f1d051147a527d2966d0424b0a74de1f.c -lm -o /tmp/devito-jitcache-uid0/d3ed1cb2f1d051147a527d2966d0424b0a74de1f.so
PLATFORM: ubuntu 22.04 (aarch64)
refer to the info "When using OpenMP offloading, it is recommended to stick to the corresponding vendor compiler, so ARCH=amdclang for AMD, ARCH={icc,icx,intel} for Intel, and ARCH=nvc for NVidia."  devito maybe doesn't support linux arm arch.

It looks like you have a lot of flags set in your system (i.e Wl,-O2 -Wl,--sort-common -Wl,--as-needed ...)
The only case devito would use those if you don't set any configuration. I would recommend following:
https://github.com/devitocodes/devito/blob/master/FAQ.md#what-are-the-accepted-combinations-of-platform-arch-and-language
to set the devito configuration to something that matches your system,

thank you sir, cpu is 3588，an arm64 arch cpu for  edge computing.

------------------ 原始邮件 ------------------
发件人:                                                                                "devitocodes/devito"                                                                                @.>;
发送时间: 2024年1月10日(星期三) 上午9:06
@.>;
<EMAIL_ADDRESS>主题: Re: [devitocodes/devito] aarch64 : CompileError (Issue #2293)
It looks like you have a lot of flags set in your system (i.e Wl,-O2 -Wl,--sort-common -Wl,--as-needed ...)
The only case devito would use those if you don't set any configuration. I would recommend following:
https://github.com/devitocodes/devito/blob/master/FAQ.md#what-are-the-accepted-combinations-of-platform-arch-and-language
to set the devito configuration to something that matches your system,
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@gfkdliucheng any updates on that issue?

no

Hi again,
@gfkdliucheng are you still looking into this? or may we close this now?


download allenai nllb mined bitext

Partially closes https://github.com/gordicaleksa/Open-NLLB/issues/11 (analysis needs to be added)
Allows downloading lang pairs from allenai nllb dataset (huggingface dataset): https://huggingface.co/datasets/allenai/nllb/tree/main
I've stored the NLLB_PAIRS (pairs released with NLLB paper) and CCMATRIX_PAIRS (pairs for which NLLB paper reused previous CCMatrix dataset) in a separate python file to import these variables into the main script because these two are rather big and could impair code readability.
Resulting tree structure with flag --minimal (debug mode) enabled:
downloads/nllb/
├── ace_Latn-ban_Latn
│ ├── allenai.nllb.ace_Latn
│ └── allenai.nllb.ban_Latn
└── amh_Ethi-nus_Latn
├── allenai.nllb.amh_Ethi
└── allenai.nllb.nus_Latn
I'm planning on doing analysis as the next steps to this PR.

I'm realizing there are some pairs for which the dataset viewer doesn't work on hugginface.

However, these pairs are not necessarily problematic, since i managed to download srp_Cyrl-tur_Latn


fix: set cwd when terminal recovery

Types

[x] 🐛 Bug Fixes

Background or solution
Changelog

/next