(URGENT) Parsing of ISO/IEC Directives necessary

We have new documents in the relaton-data-iso repo and pubis-iso fails with the IDs like ISO IEC DIR 1
https://github.com/relaton/relaton-iso/runs/6880704298?check_suite_focus=true#step:6:249
All new IDs:

ISO/IEC DIR 1 or reference ISO IEC DIR 1
ISO/IEC DIR 1 ISO SUP or reference ISO IEC DIR 1 ISO SUP
ISO/IEC DIR 2 ISO or reference ISO IEC DIR 2 ISO
ISO/IEC DIR JTC 1 SUP or reference ISO IEC DIR JTC 1 SUP

@andrew2net will provide the full list but they are ones like:
ISO/IEC Directives, Part 1

ISO/IEC DIR 1
ISO/IEC DIR 1:2022
ISO/IEC Directives Part 1
ISO/IEC Directives, Part 1
ISO/IEC Directives, Part 1:2022

ISO/IEC Directives, Part 2

ISO/IEC DIR 2
ISO/IEC DIR 2:2021
ISO/IEC Directives Part 2
ISO/IEC Directives, Part 2
ISO/IEC Directives, Part 2:2021

ISO/IEC Directives IEC Supplement

ISO/IEC DIR IEC SUP
ISO/IEC Directives, IEC Supplement:2022

ISO/IEC Directives, Part 1 -- Consolidated ISO Supplement
https://www.iso.org/sites/directives/current/consolidated/index.xhtml

ISO/IEC DIR ISO SUP
ISO/IEC DIR 1 ISO SUP
ISO/IEC DIR 1 ISO SUP:2022
ISO/IEC DIR 1 ISO SUP Edition 13
ISO/IEC DIR 1 ISO SUP Ed 13
ISO/IEC Directives, Part 1 -- Consolidated ISO Supplement

ISO/IEC Directives, JTC 1 Supplement:2021

ISO/IEC Directives, JTC 1 Supplement:2021
ISO/IEC DIR JTC 1 SUP:2021
ISO/IEC DIR JTC 1 SUP

Combined

ISO/IEC Directives, Part 1:2022 + IEC Supplement:2022
ISO/IEC DIR 1:2022 + IEC SUP:2022

@ronaldtse what is the "Directives" documents? Is it another document type? Like "TR", "TS", "IWA"?
Or is it something like technical committee documents? Like https://github.com/metanorma/pubid-iso/issues/41 this one.
Moreover, I found "JTC" in the part of PubID of document mentioned above is the type of "TC" documents, does it have a connection?
Trying to figure out how to build parser better, no it doesn't fit perfectly in normal PubIDs nor TC-PubIDs because of JTC type which now only exist for TC-PubIDs.

These are a special type of ISO and IEC documents called the Directives.
ISO and IEC share the "ISO/IEC Directives", which is a set of documents explaining the processes of both organizations.

The Directives has 2 parts, Part 1 and Part 2.
ISO and IEC each have an additional "supplement" to the Directives
ISO has a "Consolidated ISO supplement" on top of Directives Part 1.
IEC has an "IEC Supplement" on top of the Directives as a whole.

Or is it something like technical committee documents? Like https://github.com/metanorma/pubid-iso/issues/41 this one.

I consider the Directives as a different class of document from other document types and TC documents, just because their numbering scheme and naming scheme are different.

Moreover, I found "JTC" in the part of PubID of document mentioned above is the type of "TC" documents, does it have a connection?

The "ISO/IEC JTC 1" is a committee of both ISO and IEC (it is a "joint" TC). They have their own "JTC 1 Supplement" to the "ISO/IEC Directives".
This is similar to the ISO/TC 184/SC 4 Supplementary Directives:
https://github.com/relaton/relaton-data-iso/blob/0ce3afcac2162edfddb947bd132d64fa55bf691a/data/ISO_TC_184_SC_4_N3493.yaml

Trying to figure out how to build parser better, no it doesn't fit perfectly in normal PubIDs nor TC-PubIDs because of JTC type which now only exist for TC-PubIDs.

This is a good point. I think the Directives are a separate "class" of documents.

We now have 3 "classes" of schemes:

Document types (TS, TR ...)
TC documents
Directives

@mico I'm not sure if #58 fully parses all the combinations listed in https://github.com/metanorma/pubid-iso/issues/57#issuecomment-1157559404 . Can we have a txt file that lists them out that ensure they are parsed in RSpec? Thanks.

@mico I'm not sure if #58 fully parses all the combinations listed in #57 (comment) . Can we have a txt file that lists them out that ensure they are parsed in RSpec? Thanks.

You are right.
Edition parsing, organization-specific supplement and combined document are missing.
Do we need to parse long form? Like "ISO/IEC Directives Part 1" / "ISO/IEC Directives, Part 1 -- Consolidated ISO Supplement"?

ISO/IEC DIR IEC SUP
Supplement without document number? Should I use some default number? (Like 1)

This one means it is the "IEC Supplement to the ISO/IEC Directives (both parts)".

@mico I'm not sure if #58 fully parses all the combinations listed in #57 (comment) . Can we have a txt file that lists them out that ensure they are parsed in RSpec? Thanks.

You are right.
Edition, organization-specific supplement and combined document parsing are missing.
Do we need to parse long form? Like "ISO/IEC Directives Part 1" / "ISO/IEC Directives, Part 1 -- Consolidated ISO Supplement"?

Yes we should support long form and those other attributes.

Interestingly, the "ISO Supplement " is only to Part 1, but the "IEC Supplement" is to both parts. So we need to parse them correctly.

ISO/IEC DIR 1 ISO SUP Edition 13
ISO/IEC DIR 1 ISO SUP Ed 13

Supplement's edition?

@mico yes, edition of the Supplement:
https://www.iso.org/sites/directives/current/consolidated/index.xhtml

ISO/IEC DIR 1:2022 + IEC SUP:2022

Is it not the same as "ISO/IEC DIR 1:2022 IEC SUP:2022"? Or even "ISO/IEC DIR 1 IEC SUP:2022"?

@mico no, it is a combination of two documents placed into one. IEC has this notation of "+" where it joins two documents.

@mico no, it is a combination of two documents placed into one. IEC has this notation of "+" where it joins two documents.

The second document, "IEC SUP:2022" don't have "DIR" type or number. Is it IEC published document without number with supplement applied?

"IEC SUP:2022" is the short name for: "ISO/IEC Directives, IEC Supplement:2022"
https://www.iec.ch/news-resources/reference-material


Add .editorconfig and .gitattributes

Adds a .editorconfig file so that editors know that our source files:

Use spaces, not tabs.
Are indented with two spaces.
Have a final newline at the end.
Don't have trailing whitespace.

Visual Studio should pick this up automatically. For Visual Studio Code, install the EditorConfig plugin:

For C++ source files, clang-format will take care of most of this anyway, but having an editorconfig avoids some obvious mismatches as you're writing code in the first place, which is nice. Also the editorconfig applies in some places clang-format doesn't, like Markdown files.
Also added .gitattributes indicating that all files should be checked out with platform-specific line endings, but stored in the repo with Unix/Mac line endings.
The remaining changes in this PR fix files that were committed to the repo with Windows line endings.

CC @IanLilleyT @jtorresfabra @Samulus - might be good to add to tilers too

thanks @kring, looks good to me


Unable to build from fresh clone

from both my fork (updated to latest from upstream) and on fresh clone I am getting the following error message when building. Was looking into a bug with micro not being able to load my color-scheme on newer versions and found i'm unable to build normally.
go get -d ./cmd/micro
go build -ldflags "-s -w -X main.Version=1.1.5-181 -X main.CommitHash=5514e53 -X 'main.CompileDate=May 16, 2017' -linkmode external -extldflags -Wl,-sectcreate,__TEXT,__info_plist,/tmp/micro-info.plist" ./cmd/micro
# _/Users/Samantha/Desktop/micro/cmd/micro
cmd/micro/buffer.go:189: undefined: highlight.File
cmd/micro/buffer.go:195: undefined: highlight.ParseFile
cmd/micro/buffer.go:200: undefined: highlight.ParseFtDetect
cmd/micro/buffer.go:208: undefined: highlight.MatchFiletype
cmd/micro/buffer.go:209: undefined: highlight.Header
cmd/micro/buffer.go:212: too many arguments in call to highlight.ParseDef
	have (<T>, <T>)
	want ([]byte)
cmd/micro/buffer.go:221: undefined: highlight.Header
cmd/micro/buffer.go:224: too many arguments in call to highlight.ParseDef
	have (<T>, <T>)
	want ([]byte)
cmd/micro/buffer.go:237: too many arguments in call to highlight.ResolveIncludes
	have (*highlight.Def, <T>)
	want ([]*highlight.Def)
cmd/micro/highlighter.go:20: undefined: highlight.ParseFile
cmd/micro/highlighter.go:20: too many errors
make: *** [build] Error 2

Not experiencing this, you are probably go getting it wrong, check if src/github.com/zyedidia/highlight exists.

i'm not using go get at all, this is all interacting via the make build command.

You should run go get -d github.com/zyedidia/micro/.... This will put micro on your gopath, although you don't need to build from there in the future it must exist. Basically, micro has a package inside itself now and it looks in $GOPATH/src/github.com/zyedidia/micro/cmd/micro/highlight to find it, so that directory must exist.

OK, i had to remove my entire $GOPATH/src/ directory for it to work but i was able to get it to build again.


add native Zigmod support

Package manager for Zig https://github.com/nektro/zigmod

Rebased after #4.

Thank you! :heart:


feat(slate): slate uses now a custom static renderer in readonly mode

this reduces bundle size (about 25kb gzipped) and probably render time (not measured yet) and unclutters the dom a bit.
it also introduces a new property disableProviderInReadOnly that will not render the provider in readonly mode.
As a matter of fact, slate is the only plugin we provide that uses a provider. It was necessary to also render the Provider in readonly mode,
but that is no longer true. We might deprecate that in the futur or make disableProviderInReadOnly the default.
BREAKING CHANGE: dom in readonly mode is slightly different
the resulting dom in readonly mode differ a bit from previous versions. (less elements)
This had no impact at all in the example project, but depending on your application
you might need to adjust styling. That is why this is released as a breaking change.
this will be released first on beta as i need to test it on different apps first

:tada: This PR is included in version 3.0.0-beta.1 :tada:
The release is available on:

v3.0.0-beta.1
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

v3.0.0
GitHub release

Your semantic-release bot :package::rocket:


fix: dot buffer twice make sasl-auth error

In method request.encode(), it returns a buffer object，which is change in this PR  [(PR)[Fix return type of request.encode to actually be a Buffer]](https://github.com/tulios/kafkajs/commit/533db2f155ceb6fcdee39e87acc67e51782b1e68) but in outside，it get buffer again which make sasl-auth error. This bug is in v2.2.0 +，maybe need emergency fix.

Do you have a way to reproduce this issue? The tests are using sasl auth, so I would expect them all to fail if this was a problem, not to mention that I have services running using the latest version of KafkaJS using SASL that are behaving normally. I'm wondering if this is maybe an issue in a specific API version implementation or something, which would explain why it's apparently not breaking the tests.

@Nevon #1483


putio docker run unavailable on raspberry pi 4

When attempting to run the docker image on an RPi4, I receive the following error:

➜  ~ putio docker pull
Using default tag: latest
latest: Pulling from datashaman/putio-automator
Digest: sha256:012a5439bcab3ce7124285c4d9ac391141a1158a26caaae71955c24df7e7862b
Status: Image is up to date for datashaman/putio-automator:latest
docker.io/datashaman/putio-automator:latest
➜  ~ putio docker run
standard_init_linux.go:211: exec user process caused "exec format error"

Is it possible to update the docker image to support armv7?

Sorry direct support for RPi has been removed in version 2.0.


Remove auto-generated warning above method docs

They became redundant after the header doc changed.

LGTM.


fixes:#23897 Google repository is added to build.gradle

google repository added in  packages/flutter_tools/gradle/flutter.gradle
fixes #23897

This is fixed upstream and will be rolling into beta soon.


Manage all build nodes under one network

Right now there are a few groups of managed build nodes. This makes it difficult to ensure they're all running consistent versions of Nix and NixOS, and are participating in the monitoring.

[ ] Import the x86 Linux machines in to the network:

[x] packet-epyc-1
[x] packet-t2-4
[ ] t2a
[ ] t4a
[ ] t4b

[ ] Import the macOS-on-Linux machines in to the network:

[ ] mac2-host
[ ] mac3-host
[ ] mac6-host
[ ] mac7-host

[ ] Convert the remaining macOS-on-Darwin machines to be macOS-on-Linux and import in to the network:

[ ] mac1
[ ] mac4
[ ] mac5
[ ] mac8
[ ] mac9

[ ] Import the aarch64-linux machines in to the network:

[ ] add an aarch64 remote builder to the deploy host
[ ] packet-t2a-1
[ ] packet-t2a-2

cc @vcunat I'll need help / configs from you for t2a/t4a/t4b

Yes, I had it in my TODO after our talk.  I'll need to figure out how to integrate my custom changes – I expect to PR a suggestion.


Create AlvittaOttley.md

Does not appear to work in robotics. Happy to add in if we hear otherwise.


correct java location in docker-entrypoint.sh

location of the java binary in openjdk:8 is /usr/local/openjdk-8/bin/java

Commented in the other PR that you can switch to JDK 17. We're doing the same.

Mario pointed me to your recent PRs. You can always put me as a reviewer to get feedback faster.


Update docs README

The docs readme includes "These docs are written in rST" and has instructions "To generate HTML docs locally from rST" . The docs are actually in rST and Markdown, now. (I haven't looked into whether/how that change the HTML generation process.)

The generation process is the same, but yeah, almost everything is in md because it's easier to write, and it turns out the main limiting factor on writing enough documentation is activation energy for writing it :).
I'll fix this.

Opened https://github.com/zulip/zulip/pull/1054, do you want to give it a quick read?  Note that the instructions assume you've provisioned since I merged #808 just now.


New notebook with atl10 files coincident to the cryosat2 files

@betolink @andypbarrett @asteiker
huge thanks to Luis for the function that creates s3 links from the on prem links and feeds them to earthaccess.open()
hoping to use this one this afternoon.

Looks like there is an exception at the end of the notebook, is it ok if we leave it like this? @mikala-nsidc

@betolink is it in that last mapping cell?  if so, yes!  I'll have to investigate more later.


Changes on 9-11-23 break dd-trace

What happened?
The most-recent change is causing dd-trace to break with the following errors.
Error: node_modules/dd-trace/index.d.ts(1666,20): error TS[24](https://github.com/---/actions/runs/6146278516/job/16676040443#step:16:25)30: Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.TracerProvider' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/tracer_provider").TracerProvider'.   The types of 'getTracer(...).startSpan(...).recordException' are incompatible between these types.     Type '(exception: Exception, time?: TimeInput) => void' is not assignable to type '{ (exception: Exception, time?: TimeInput): void; (exception: Exception, attributes?: Attributes, time?: TimeInput): void; }'.       Types of parameters 'time' and 'attributes' are incompatible.         Type 'Attributes' is not assignable to type 'TimeInput'.           Type 'Attributes' is missing the following properties from type 'Date': toDateString, toTimeString, toLocaleDateString, toLocaleTimeString, and 37 more. Error: node_modules/dd-trace/index.d.ts(1697,20): error TS2430: Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.Tracer' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/tracer").Tracer'. Error: node_modules/dd-trace/index.d.ts(1772,20): error TS24[30](https://github.com/---/actions/runs/6146278516/job/16676040443#step:16:31): Interface 'import("/home/runner/work/---/node_modules/dd-trace/index").opentelemetry.Span' incorrectly extends interface 'import("/home/runner/work/---/node_modules/@opentelemetry/api/build/src/trace/span").Span'.   Types of property 'recordException' are incompatible.     Type '(exception: Exception, time?: TimeInput) => void' is not assignable to type '{ (exception: Exception, time?: TimeInput): void; (exception: Exception, attributes?: Attributes, time?: TimeInput): void; }'. Error: Process completed with exit code 2.
OpenTelemetry Setup Code
No response
package.json
This is from the dd-trace package.json. It is breaking because it is pulling in the latest patch/minor changes.

"@opentelemetry/api": "^1.0.0",
"@opentelemetry/core": "^1.14.0",

Relevant log output
No response

Reopening as we still need to get the release out #4138

Is there an ETA on the release?

@ksstoneware glad to hear!
Closing this as completed.


refactor: enable Rector Code Quality level, apply level 9 for SimplifyConditionsRector

Description
We can enable codeQuality sets once we are on max level. This PR apply level one by one, and I can see it apply on level 9, with cleared rules manual definitions that included in previous level.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

Ready to merge 👍

Thank you @kenjis @paulbalandan for the review, let's merge ;)


Sound/Music for Human Testing Scenarios

Audio cues/clues for human testing (children) that give immediate feedback on actions (reward/punishment), and for general atmosphere during gaming.

Currently very low priority. Potentially only viable for a WEB GL AAI main menu.


Click next page for meeting list, it will be response in quite a long time

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
calendarv2
Describe the bug

"find tomorrow meeting" , it will show the meeting list (eg. on my list I have 15 events)
click next page
it will hide the card and then show it again.  The intervals is quite long, I wait for 3-5 seconds to see the card show again.

To Reproduce
Steps to reproduce the behavior:
Expected behavior
Give a clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

#332 , number 5 on overview list, I've added transcript for this load state.

Working on switching to the Teams Update action instead of delete/replace.


TIle existing upon resetting the app

Blank tIles still exist when the app is reset

This issue has been resolved, Update will be pushed to play store soon.


[1.14] gateway-api: update types to read v1beta1 if present (#41238)

gateway-api: update types to read v1beta1 if present

The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken.
This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API.
(cherry picked from commit fc33f94ecd1367de8e060aa78d615e106c77b952)

fixes

(cherry picked from commit dbf424bf27552290f563d0c1ee8238bb5671d63d)
Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test lint

unit-tests_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test lint

unit-tests_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test unit-tests

gencheck_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test lint

unit-tests_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test unit-tests

gencheck_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test gencheck

integ-pilot-istiodremote_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test lint

unit-tests_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test unit-tests

gencheck_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test gencheck

integ-pilot-istiodremote_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-cni

integ-pilot_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test unit-tests

gencheck_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test gencheck

integ-pilot-istiodremote_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-cni

integ-pilot_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot

lint_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-cni

integ-pilot_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-pilot

lint_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test lint

integ-pilot-istiodremote_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.14
e6242ffb3d1650e196bdf1a614716220f8e0ee30
link
true
/test integ-cni

lint_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test lint

integ-pilot-istiodremote_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-pilot-istiodremote

integ-pilot_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test lint

integ-pilot-istiodremote_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-pilot-istiodremote

integ-pilot_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-pilot

integ-cni_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.14
0b6f634f0acf75e4f01b94802b7ad3ea558fc343
link
true
/test integ-cni

integ-pilot_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot

integ-pilot-istiodremote_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-cni

integ-pilot_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-cni

integ-pilot_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-cni

integ-pilot_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test integ-pilot

lint_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-pilot-istiodremote

integ-cni_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-cni

integ-pilot_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test integ-pilot

lint_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test lint

gencheck_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.14
bf70022f1614424c813c496439150334e7aeeb62
link
true
/test integ-cni

integ-pilot_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test integ-pilot

gencheck_istio_release-1.14
5e7ea6b65a1650891aa5dc9729f2b958f9d4bf96
link
true
/test gencheck

lint_istio_release-1.14
d998cc63f5b485c98bcd3a5ba0203d67a726a5b8
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/tests all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.14
340c696182a28045ba1e4291a2396257c8c2f9df
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Update the Informer class to use metadata provided in HDF5 format

Currently the Informer class reads in metadata in JSON format using a custom tables_io class. But now that we know that HDF5 can be used to store JSON, we should update the Informer to use the tables_io API for reading HDF5 files.

This is taken care of in PR #48


TypeError: Cannot read property 'bind' of undefined

> var db = require('then-levelup')(require('levelup')('./mydb'));
TypeError: Cannot read property 'bind' of undefined
    at then (/somewhere/node_modules/then-levelup/index.js:32:44)
    at repl:1:33
    at REPLServer.defaultEval (repl.js:248:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:412:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)
    at REPLServer.Interface._onLine (readline.js:210:10)
    at REPLServer.Interface._line (readline.js:549:8)
>

This is a side-effect of #2, and would be fixed if and when @ForbesLindesay pushes the latest tag (v1.0.2) to npm (#4).


i18n add localization support for labs module closes #279

Got a chance to hammer this out tonight.
Fixes #279.
Changes proposed in this pull request:

add localization support for labs module
add EN translation for labs module localization

cc @HospitalRun/core-maintainers
Added english translation for labs

Thanks for the PR @James1x0 !


ClientError: An error occurred (413) when calling the UploadPart operation: Request Entity Too Large

Problem description
Be sure your description clearly answers the following questions:

What are you trying to achieve?
Upload an apparently too large file.

What is the expected result?
The file is uploaded.

Having UploadParts, I would files are splits into parts anyway, and those chosen too large.
They should be decreased in size after an Entity Too Large Error.

What are you seeing instead?

ClientError: An error occurred (413) when calling the UploadPart operation: Request Entity Too Large

Steps/code to reproduce the problem
In order for us to be able to solve your problem, we have to be able to reproduce it on our end.
Without reproducing the problem, it is unlikely that we'll be able to help you.
Include full tracebacks, logs and datasets if necessary.
Please keep the examples minimal (minimal reproducible example).
Sample file:
youtube-dl https://redd.it//ijh0he

Selfhosted Minimo behind a Nginx proxy
Versions
Please provide the output of:
Python 3.7.7 (default, Mar 31 2020, 15:46:29)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform, sys, smart_open
>>> print(platform.platform())
Linux-5.3.0-26-generic-x86_64-with-debian-10.3
>>> print("Python", sys.version)
Python 3.7.7 (default, Mar 31 2020, 15:46:29)
[GCC 8.3.0]
>>> print("smart_open", smart_open.__version__)
smart_open 2.1.1

Checklist
Before you create the issue, please make sure you have:

[x] Described the problem clearly
[ ] Provided a minimal reproducible example, including any required data
[ ] Provided the version numbers of the relevant software

Can you please post some source code that reproduces your problem? It's not clear where are you trying to upload to.


Add common relation

Approved 👍

I don't see the point in having these constants in this repo
consider moving them into the nlu-lib

@uriva I totally agree. Why were these moved from the lib in the first place ? We should remove all relations from this repo and make it api-only imho. Let's discuss.


onScroll doesn't update currentIndex

I updated the plugin to the last version from 2.x and i have now a problem with the onScroll callback.
It seem that the carousel .currentIndex doesn't update anymore in the callback function.
<Carousel ref={(carousel) => { this._carousel = carousel; }} 					sliderWidth={viewportWidth} 					sliderHeight={viewportHeight*55/100} 					itemWidth={viewportWidth} 					itemHeight={65} 					vertical={true} 					firstItem={this.state.activeSlide} 					enableSnap={false} 					inactiveSlideScale={1} 					data={this.state.slide} 					renderItem={this._slides} 					onScroll={(e) => { 						this._changeSlider(); 					}} 				/>

⚠ You did not follow the contributing guidelines!
As stated in these:

:warning: You need to fill out the issue template. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.


Fixed setup.py bug by turning encoding into a keyword argument. Encod…

…ing parameter was being passed in the position belonging to the buffering parameter

Thanks!


Add reasonable toString implementations to domain objects

Having e.g. com.gooddata.md.Metric@60d8c9b7 in outputs is not very useful.
Consider:

text representation of fields
JSON string
...

Also consider usage of some library:

http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/core/style/ToStringCreator.html
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/builder/ToStringBuilder.html


ImportFromGit for Pipeline Entity

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck

@vtxorxwitty Please update change log as well.

Yes @RajBaviskar . I will update the change log once the go client changes are merged and released.


docs: updated the document to include workload identity.

Updated the doc to include the link and an example for workload identity.

Reason for Change:

It's hard to find the right configuration for workload identity use case.

No.
Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[X] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:
I was trying to set up the integration with workload identity in AKS, and found out it's hard to see find the example from here. I hope this update can help others too.

/azp run pr-e2e


Write a Scala program to convert inches to feet

Description
Write a Scala program to convert inches to feet
1 foot = 12 inches
Input  : 60
Output : 5

How to contribute

Save the solution in convertInchesToFeet.scala file
Add convertInchesToFeet.scala file in program/convert-inches-to-feet folder

can u assign me this task . I understand code but recently i know about the open-source and i find it very interesting and like to be     of a good community

Hey @ANUSHRAV01
You can comment !assign on any good first issue you want to contribute to, to be auto-assigned 🤗
!assign


Input image format for ObjectDetector(Darknet-YOLO)

In what format TuriCreate model expects an input image? Particularly I am interested in bias and a scale value. For example in CoreMLTools in some cases these parameters are specified explicitly:
is_bgr: you typically need to set this to True for Caffe models
red_bias, blue_bias, green_bias: these will be added to the R, G, and B color values of each pixel
gray_bias: like the RGB biases but for grayscale images
image_scale: the pixel values will be multiplied by this number.

I wonder if something similar needs to be specified for TuriCreate for ObjectDetector(Darknet-YOLO(object detector))

TuriCreate uses its own image format. These can be created, from JPEG or PNG files, by calling tc.load_images.
In order to create an object detection model (using Darknet-YOLO) you do not need to manually scale or add a bias to your images. See our user guide for an example of creating an object detector.


Update Navigation Bar for Mobile Viewports

Adjust the navigation bar to be mobile-friendly. On smaller screens, consider implementing a hamburger menu or stacked layout for easier access.

The navigation bar has been optimized for mobile viewports. A responsive layout has been implemented, and the navigation links are accessible on small screens.


Is a tool ever compelled to calculate a type as unspec, or is always free to assign a specified nullness as it sees fit? [working decision: for test purposes yes]

Our tests will check what augmented-types various type usages have, various expressions produce, and various expression-sinks (whatever things enclose an expression) want to consume.
Should we ever test that a particular type comes out as Foo*? Or is a tool always within its rights to decide a nullness for anything that is JSpecify-unspecified?
We have long stated a central goal as "make sure API owners can successfully/correctly annotate independently of tool choice". If it's fair to assume that process requires correctly annotating any types used in the API, then ... maybe we have no strong interest in whatever happens to anything left unspecified?

I say yes.
Tools are free to decide to further specify that type for their own purposes, but we should check their understanding that JSpecify does not.

I have a question about the question :) I think we're talking about something like this:
class Foo {
  // jspecify:type:bar=List*<T?>
  List<@Nullable T> bar();
}

I suspect that there's no controversy that that's what the test should say: It should say that the type is List*<T?> from JSpecify's perspective.
The possible controversy, I think, is over what it means to "pass" that test: Does a tool have to internally spit out the type List*<T?>? Or is it enough for it to spit out List!<T?> or List?<T?>, both of which are compatible with JSpecify's lack of specification for the list itself?
Does that sound right?

Thank you for expressing the question in the form of a test case!
My 2¢ is that the tool should agree that the type is List*<T?>. It is then free to tell its users whatever it wants about whether calls to that method are in error, or whatever.

That'll work for now.

Current decision: Conformance tests will require conformant tools to express that certain type usages are in fact nullness-unspecified. They do not have to report that to their user; they can go on to treat that type component however leniently they want.
Argument for changing: No strong case.
Timing: This must be decided before version 1.0 of the spec.
Proposal for 1.0: Finalize the current decision. If you agree, please add a thumbs-up emoji (👍) to this comment. If you disagree, please add a thumbs-down emoji (👎) to this comment and briefly explain your disagreement. Please only add a thumbs-down if you feel you can make a strong case why this decision will be materially worse for users or tool providers than an alternative.

Decision: Conformance tests will require conformant tools to express that certain type usages are in fact nullness-unspecified. They do not have to report that to their user; they can go on to treat that type component however leniently they want.


Abbreviation-like search

Sometimes, in large repos, it may be helpful to limit pattern to match only beginnings of words. For example, ctpy will match ctrl.py but won't match control.py. How hard is to add such feature to cpsm? Which code is responsible for letter-by-letter matching process?

cpsm's ranking algorithm is a bit complicated, but it already includes matching at the beginning of words as a very strong signal. Do you have a specific example of bad behavior?

I agree that cpsm definitely prefers matches at beginning of words but for some case the "signal" is not strong enough.
Besides, sometimes there is a strange delay of 1-2 which is not tolerable for me.
Anyway, I'm currently working on CtrlP's matcher which will match only at beginnings of words. I can send you link when it's published, if you want.


Add command TernMkProj to write tern project file to cwd

It's boring to manually add tern-project file.

I found .tern-config. I prefer it over placing a .tern-project in each and every projects.


Please add support to VS2019 (vc142)

Official Boost release 1.70 doesn't support VC 14.2. https://www.boost.org/users/history/version_1_70_0.html

Hmm, okay, I already downloaded and compiled boost manually in VS2019, It's worked.

Done for Boost 1.71


enhance the RMB menu for file explorer

Description of the new feature / enhancement
if I klick the rigth mouse button on a file it shows me "Open with".
To add something like this für directories I have to hack into the registry.
So I want a possibility to choose applications to add to the rmb menu for directories.

Scenario when this would be used?
Open with "VS Code"
Open with "Backup"
Supporting information
No response

/dup #33

+1 but dup #33


Inference with Beam > 1 broken in Triton

Env:
GPTQ (triton head)
Transformers [head]
Nvidia 4090

Model: 30B, 4bit act-order sequential groupsize=-1

num_beams = 2
length_penalty = 1.3

Still trying to figure out at which point did the beam breakage happen. Anything num_beams > 1 will result in the following.
This is the error with fuse_mlp enabled:
  File "/root/GPTQ-for-LLaMa/test_triton.py", line 205, in process
    gen_output = model.generate(
  File "/root/miniconda3/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/root/miniconda3/lib/python3.9/site-packages/transformers/generation/utils.py", line 1585, in generate
    return self.beam_sample(
  File "/root/miniconda3/lib/python3.9/site-packages/transformers/generation/utils.py", line 3159, in beam_sample
    outputs = self(
  File "/root/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.9/site-packages/transformers/models/llama/modeling_llama.py", line 688, in forward
    outputs = self.model(
  File "/root/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.9/site-packages/transformers/models/llama/modeling_llama.py", line 578, in forward
    layer_outputs = decoder_layer(
  File "/root/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.9/site-packages/transformers/models/llama/modeling_llama.py", line 307, in forward
    hidden_states = residual + hidden_states
RuntimeError: The size of tensor a (136) must match the size of tensor b (272) at non-singleton dimension 1

With fuse_mlp disabled, generation does not throw error but generated result contains errors manifested in one of two ways:

~50% output is garbled/junk
~50% of output is missing

The percentage may just be specific to my input/prompt but the the two type of error outcomes with fuse_mlp disable is consistent.

Same issue, we are running quanted model on kserve, with batch_size > 1 we get
RuntimeError: The size of tensor a (136) must match the size of tensor b (272) at non-singleton dimension 1

I'm also hitting this error, tensor b is the flattened dimension from tensor a (batch_size x longest_sequence_length). 4 bit version is working currently only with batch_size=1.

Fixed the current bug.


[🐛] I used includeBase64: true but still not getting the value of base64

Description
Explain the bug in as much detail as possible
How to repeat issue and example

step to reproduce the issue
...

Solution
What needs to be done to address this issue?
Additional Information

Image Picker version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
Platform: [FILL THIS OUT: iOS, Android, or both?]
Development Operating System: [FILL THIS OUT: Are you developing on MacOS, Linux, or Windows?]
Dev tools: [FILL THIS OUT: Xcode or Android Studio version, iOS or Android SDK version, if applicable] navigation crash for Android

dude, i have this problem too, but you need to make your post more specific if you want anyone to get assigned


feat: add the AtClientBindings mixin to this package

- What I did
feat: add the AtClientBindings mixin to this package. This mixin was initially added in the noports_core package, but has broader applicability
- How I did it

added lib/src/mixins/at_client_bindings.dart
added lib/at_client_mixins.dart
updated pubspec, changelog and at_client_config for version 3.3.0

- How to verify it

manually verified via noports packages

-Additional context
Note that at_client_bindings.dart is not exported via the main export file (lib/at_client.dart) but in a new export file (lib/at_client_mixins.dart) in order that we not cause any annoying import changes to be needed in packages which already import at_client package and already have an AtClientBindings defined locally

Do we need some dartdoc explaining usage and when you should or shouldn't use this?

Do we need some dartdoc explaining usage and when you should or shouldn't use this?

I will make another PR after at_policy package has been published


port to 1.20.1

can you please port this mod to 1.20.1 please

Solved with https://github.com/JorianWoltjer/LiveOverflowMod/pull/6


2 tests failed. diff:diff across DST (2396.17) diff:diff across DST (2396.19)

Client info
Date String   : Mon Jan 18 2016 19:33:22 GMT-0600 (CST)
Locale String : 18/1/2016 19:33:22
Offset        : 360
User Agent    : Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36

====
diff:diff across DST (2396.17)
month diff across DST, lower bound
// Expected true
// Actual   false
false === true

====
diff:diff across DST (2396.19)
year diff across DST, lower bound
// Expected true
// Actual   false
false === true

I get the same errors.

@laukstein mind sharing your Client info?

The same User Agent as you have mentioned.

#3010 is the exact same unit test failures as this. Data from 3010:
Client info
Date String   : Mon Mar 07 2016 16:09:05 GMT-0600 (CST)
Locale String : 7/3/2016 16:09:05
Offset        : 360
User Agent    : Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36

====
diff:diff across DST (1965.17)
month diff across DST, lower bound
// Expected true
// Actual   false
false === true

====
diff:diff across DST (1965.19)
year diff across DST, lower bound
// Expected true
// Actual   false
false === true

Tracking in #3021


Allow checkbox items to have explicit names

I would like the ability to set the names of checkbox items explicitly rather than have them all share the same name.
This would allow me not to have to map values from one variable to another at the backend, but also to target the checkbox items on the clientside using the name (the latter being of less importantance since I could always pass an explicit id to achieve much the same effect)
Proposed code changes here:
https://github.com/solidgoldpig/govuk-frontend/compare/master...checkboxes-items-can-have-explicit-names

Hi @solidgoldpig
thanks for raising the issue. We're always looking to get the community's feedback as well as getting the community involved in the contribution.
If you're willing to raise a pull request for us to review it as a team, that'd be great.

Thanks.
We'll aim to release this next week.

Hi @solidgoldpig,
this has now been released in v0.0.30-alpha, so I will close the issue.


Increasing strength

Submitter: Sean Partington
Email<EMAIL_ADDRESS>You should allow for abilities to increase

This is a feature that's been requested several times, if I'm understanding the suggestion correctly. Reference issue #141
As always, your feedback is appreciated though.


Add css class to page background with controls

Allow displaying the slim control's shadow along the bottom for pages
with player controls. The old solution causes the shadow to be applied
twice on audio pages with background video.

Coverage remained the same at 99.031% when pulling 2050121e6db64f097df01fed109c72845462546e on tf:page-background-for-controls into f740e55573f7b54fefc5a78bcbac1eda9e59c93a on codevise:master.

Coverage remained the same at 99.031% when pulling 2050121e6db64f097df01fed109c72845462546e on tf:page-background-for-controls into f740e55573f7b54fefc5a78bcbac1eda9e59c93a on codevise:master.


How to return 404 status code on error (for SEO)?

Hi guys. There's an issue that I can't solve.
The thing is, when 404 occurs, website should return actual 404 error status code. This needs to be in place, so Search Engines crawl website the right way

Last but not least, 404s can be bad news when they act like a 200. A soft 404 error page is not a good thing, because search engines will continue to index these. Ensure your server is configured to return the proper status code for each type of page.

If I use error.vue template, then there's no 404 status code in DevTools, since app just showing this template. There's an 404 error for API, but this is not the case. I need 404 code for frontend app, not API.

Hey. It should return 404 indeed. Do you have any public URL of your project?

Ah, never mind, I think it's not the issue. SInce I forgot that I navigate on the client! Crawlers will fetch from server, and there 404 works fine.
Thanks @pi0 you right


Update shape matching to not match view connections with different views

https://github.com/PolymerLabs/arcs/issues/590

This is somewhat hacky, I'm afraid you aren't going to like it.
But if this is smth we could live for the time being, I'll add test cases to cover it.


Bug 1803970: Creating ClusterOperator resource on ErrStorageNotConfigured

An ErrStorageNotConfigured should not block us from creating the
ClusterOperator resource.

/lgtm

/retest

Thanks all, with this PR, image-registry comes up for me on baremetal:
image-registry                             4.4.0-0.ci-2020-02-18-102514   True        False         False      3m10s

Thanks all, with this PR, image-registry comes up for me on baremetal:

+1 I also tested and in conjunction with https://github.com/openshift/installer/pull/3117 IPI baremetal deployments are working again :)

/cherrypick release-4.3


Updated error return to remove new line

PR resolves #814 by updating the returned error to remove the use of errors.Join which added the unwanted newline (\n).
Description
Updated line 727 of pkg/typesystem/typesystem.go so that the the error prefix is included in the fmt.Errorf options, rather than using errors.Join
References
Relates to Issue #814

Thanks @Galzzly!

Working on the failing test, but hitting the identical string comparison failure issue for the two error strings. Will update once I am able to. Apologies for the delay.

All checks are now passing, I can resync the repository and push the updated repo up this afternoon if necessary.

@Galzzly mind rebasing on main? Then we can merge.

@jon-whit - That should be all sorted now.


The healthcheck is currently broken for docker

The healthcheck is currently broken for docker - I suspect because we will now be getting a 302 probably for /
This is how we currently do the check... but it's not great:
HEALTHCHECK CMD curl --fail http://localhost:5000/ || exit 1
Maybe we could add a proper healthcheck endpoint... If we knew we were getting errors with the sync it would be good to be able to report it here.

Hmm. curl --fail http://localhost:5000/ || exit 1 returns totally fine for me though when running the app.
How are you running the health check manually?


feat: change return value of extract_spans

Made extract_spans return the Span class

Can you do a 0.3.x release before merging this in please

Also can you please update the documentation for the functions? If anywhere it is mentioned list[list[HotCharacter]] for extract_span function - change it to the new implementation

Done :)

Now code is compliant with the following:

pycodestyle
pyflakes
pyupgrade
flake8-bugbear
flake8-simplify
isort
MaccaBe (complexity = 10)

@krishnasism When you can check if the docs are ok :)
From my side we can merge!

I'll update docs to this PR and merge!

I merged it - I will update the docs in a separate PR :)


fix: check for event.cancelable in touch events

Chrome has started warning when canceling an event that cannot be cancelled, like scrolling.
This causes a fair bit of log spam. I know it fires for touchmove and touchend and there's
reports that it also fires for touchstart.
IgnoredEventCancel: intervention: Ignored attempt to cancel a touchmove event with
cancelable=false, for example because scrolling is in progress and cannot be interrupted

References:

https://github.com/react-grid-layout/react-draggable/issues/553
https://www.uriports.com/blog/easy-fix-for-intervention-ignored-attempt-to-cancel-a-touchmove-event-with-cancelable-false/
https://github.com/FL3NKEY/scroll-lock/issues/19
https://stackoverflow.com/a/53315365/30900

Can you write a test to make sure this is not broken in future updates?


Add and convert citation plugin

differences:
you can now have multiple citations on one line

feature(citation): convert citation plugin to typescript
fix(citation): properly hookup components, plugin and schema
fix(citation): limit decorating to correct triple pattern
feat(citation): hook up citation search and input triggers

yep, that's how the regex is set up


Deployer on Jenkins can't connect to remote

Q
A

Issue Type
Question

Deployer Version
6.3.0

Local Machine OS
Jenkins @ Debian 9.5 (Docker image of jenkins LTS)

Remote Machine OS
Debian 9.5

Description
We are having a simple PHP application that we do build and deploy with deployer. When doing this locally on a local development machine we are able to deploy just fine to the remote server.
Now we are trying to execute the deployer deployment process on a jenkins build server. The local tasks (== the build process) are executed just fine but as soon as the remote tasks get executed deployer fails with the output log mentioned below.
In the jenkins job the ssh agent is activated for the specific job and the correct ssh key is selected. (its public key is deposited in the authorized keys file on the remote server)
When letting jenkins execute a ssh <user>@<hostname> shell command manually in the build job the ssh connection gets initiated just fine.
It would be great if someone does have an idea why the ssh connection initiated by deployer on the jenkins build server does fail!
Output log
➤ Executing task deploy:prepare
[production-system] > echo $0
[production-system] < ssh multiplexing initialization
[production-system] < Control socket connect(/var/jenkins_home/.ssh/deployer_<user>@<hostname>): Connection refused
[production-system] < Failed to connect to new control master
➤ Executing task deploy:failed
• done on [production-system]
✔ Ok [1ms]
• done on [production-system]

In Client.php line 99:

  [Deployer\Exception\RuntimeException (-1)]
  The command "echo $0" failed.

  Exit Code: -1 (Unknown error)

  Host Name: production-system

  ================
  Control socket connect(/var/jenkins_home/.ssh/deployer_<user>@<hostname>):
   Connection refused
  Failed to connect to new control master

I have replaced the user and hostname in the log file but they are filled in correctly from our hosts.yml file.

As soon as I set set('ssh_multiplexing', false); the problem is gone.

Try to use tmpfs for socket.

Thank you for the hint @antonmedv. Mmmh. What does that mean in detail? (I think that I'm a newbie in that area)

Set control path of ssh to /dev/shm

Closing this issue as inactive. If you still have this problem, please open a new issue.

@antonmedv is the control path configurable within Deployer? I'm facing a similar issue and it looks like the control path is set within \Deployer\Ssh\Client with no ability to change it at the config level.

For anybody stumbling across this issue or similar, changing the ControlPath to /dev/shm worked for me. To do this I added the following to my host config:
->addSshOption('ControlPath', '/dev/shm/deployer-%C')


Feat: Top level refinements

Closes #654
Fulfills #600

I found an issue in Zod, that I'd like to be fixed before I continue with this feature.
Made a PR to fix it.
https://github.com/colinhacks/zod/pull/1513


[Feat] On "seller setup your Store" text is half visible.

Description
On "seller setup your Store" text is not visible properly.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Please assign me this issue I will fix it very soon.


FATAL  error  on Viewdragger helper

I have got an exception : Attempt to invoke virtual method 'void android.support.v4.widget.ViewDragHelper.processTouchEvent(android.view.MotionEvent)' on a null object reference
Do you have any suggestion to solve this problem?

This is solved with PR #64, should be closed


Tooltips (hover to read values).

It’d be nice to have a tooltip that shows the value nearest the mouse.

Hi! Is there any way to do interaction with Plot? I tried viewing the above links but most of them are dead. Even if it's a hacky solution, I'd like to know if there is some way to do interaction.

I have fixed the links; if you play with them, I would be happy to have feedback.

Thanks @Fil for adding super useful interactivity. I am using Plot via npm. Will the tooltip functionality be available from within the package anytime soon?

I can't give a specific date but interaction is definitely on the roadmap.

I've been doing some (comparatively basic) voronoi/tooltip functionality in React Charts and would love to offer any help here that I can, if any. I can say from experience in both building and using several different interaction models for my charts that element-based interaction models are usually easier to build and use compared to arbitrary closest-to-point/trie-like ones. In fact, the same great features that make encoding data to cells, bands, shapes, etc such a breeze in plot would make building this "invisible" interaction layer so much easier than what I've been going through lately 😂 .
Put me to work!

Reference metricsgraphics

Some great reference examples for different chart types by @tannerlinsley: https://codesandbox.io/s/github/tannerlinsley/react-charts/tree/beta/examples/simple?from-embed


Embedded mode with RemoteWebDriver, how does it work?

Hi,
I am sorry if this has been already asked, but I went through the issues and I could not find an answer.
I am trying to use browserMobProxy (latest release, browsermob-core-littleproxy 2.1.0-beta-3 via maven), the embedded mode with RemoteWebDriver. This means:

I have my Selenium Java code running on my machine or Jenkins
I start browserMobProxy with:
BrowserMobProxy browserMobProxy = new BrowserMobProxyServer();
browserMobProxy.start();
then I create a proxy with:
Proxy seleniumProxy = ClientUtil.createSeleniumProxy(browserMobProxy);
and finally I add this proxy to the capability:
capability.setCapability(CapabilityType.PROXY, seleniumProxy);
I run it against a Selenium Grid (1 hub + 4 nodes, Ubuntu 14, with Firefox latest, Chrome 45, Selenium 2.47, Chromedriver 2.20). In the Selenium Grid (neither nodes nor hub) there is no standalone browserMobProxy installed.

I have already tried the previous code locally with Firefox and Chrome and it works. Locally means that the Selenium Java code is running on my machine and the browser too.
So, the question is, can I run the tests against the Selenium Grid using RemoteWebDriver and only with the embedded browserMobProxy? Or do I need to install a standalone browserMobProxy in a machine that is reachable for the grid (or in the grid).
If it is possible to do it only with the embedded proxy, I would be really happy if you guys could provide a simple example.
I hope the question was easy to understand,
Thank you,

There's no reason it shouldn't work against the grid. You'll want to make sure that the machine running your Selenium tests (workstation, jenkins box, etc.) is reachable from the grid. You may also have to override the hostname in the seleniumProxy object to be a hostname or IP address that is reachable from the grid.
Can you paste some logs that show the issue?

OK, I will ensure first those two things and I will let you know.
Thank you,

After ensuring that the machine running the tests is reachable, and more importantly, overriding the hostname of the proxy object, I see that it works from the Grid as well.
So, I'll proceed to close the issue then.
Thanks for your help,


Update help command to be in line with user story

Closes #36

LGTM. Noted low codecov due to GUI-related code.


Determine version for a commit

Closed in https://github.com/adamralph/min-ver/commit/f7721b6cc39afeb7d42a8b38dff87c075dff820c


[9.x] Add inspiring quote by Walt Disney

Add inspiring quote by Walt Disney

This is a nice way to badges on your Github profile

@ankurk91 What's a problem?

@ankurk91
https://github.com/laravel/framework/pull/23849
Just a comma ( , )
How many do you want me to mention?

@ankurk91 What's a problem?

Stop spamming the repository with small pull requests adding single quotes; add something valuable instead.

@ankurk91 What's a problem?

Stop spamming the repository with small pull requests adding single quotes; add something valuable instead.

Hello spam hunter,
Support #43243 PR if you think is valuable.
@eduance


"Trouble Signing In?" is cut off on smaller phones

Step 2: Describe your environment

Objective C or Swift: Swift
iOS version: 12.1
Firebase SDK version: 5.20.1
FirebaseUI version:  6.2.1
CocoaPods Version: 1.6.0

Step 3: Describe the problem:
The label Trouble Signing In? is cut off on smaller devices (e.g. iPhone SE)

Steps to reproduce:

Sign in with existing email
On password page you will see the bug

Expected Results:

What did you expect to happen?

I would expect the label to not be cut off on all supported devices.

Hi @AndrewGable , I'm not able to reproduce this issue. Do you use any layout framework other than Auto Layout? Like LayoutKit or something else?

I updated to 7.0.0 and it's fixed 🎉
Thanks!


Context.write

This is a very early stage proposal. I'm opening this RFC as a way to explain the problem space. We're still exploring alternative solutions. If this were an ECMAScript proposal it'd be Stage 0.
Summary
Proposes an extension to the context API for updating the default context value. This would allow for React-managed state that lives outside the UI tree and is shared across roots.
Basic example
const Context = React.createContext(initialValue, contextDidUpdate);
// Update the global context value across all roots. Any context consumer that
// is not wrapped in a Provider will re-render with this value.
Context.write(newValue);
// Functional updates also supported for access to the previous value.
Context.write(prevValue => newValue);

function contextDidUpdate(newContext) {
  // Optional callback that fires whenever context changes
}

Rendered text

For each context, React would have to maintain a separate version per root, as well as a separate queue of updates.

I was just thinking about it - per-root changeable defaultValue would allow "automatic Provider injection" effect, making some stuff(like React-Helmet, side-effect, etc) easier.

Great job @acdlite :)

@acdlite fantastic proposal!
What's the plan? Where do we go from here? Is there a concrete path forward like there is for the Hooks proposal?

Is that possible to add freeze like:
const Context = React.createContext(initialValue, contextDidUpdate);
Context.freeze();

Context.write(newValue); // Error. This context has been freeze and can't change defaultValue.

implement partly in https://codesandbox.io/s/react-context-next-xk1rk

I have submitted an RFC with an alternative solution. I believe more inline with hooks direction.
https://github.com/reactjs/rfcs/pull/130
Would like to ask for feedback from all of you :)

Looks like this either needs more work and/or won't work at all.


Prevent 500 on parallel service instance creation

We observed 500 responses on POST /v3/service_instances when requests run in parallel and the db is small.
This occurs if the one POST bypasses the other one and inserts the record into the db after the first POST has passed the validate function but before the actual insert. This leads to a PG::UniqueViolation: ERROR: duplicate key value violates unique constraint which is not caught and thus results in a 500 response. To prevent this, we add a Sequel::UniqueConstraintViolation rescue to catch the PG::UniqueViolation error and to return an adequate 422 error "The service instance name is taken.."

A short explanation of the proposed change:
Do not return 500 on parallel service instance creation on small db but a 422.

An explanation of the use cases your change solves
We observed 500 responses on POST /v3/service_instances when requests run in parallel and the db is small. Now an appropriate error is returned.

[X] I have reviewed the contributing guide

[X] I have viewed, signed, and submitted the Contributor License Agreement

[X] I have made this pull request to the main branch

[X] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Need to enhance the parallel test still


total annotation metric

To help to explain the different data-types
https://github.com/pombase/pombase-chado/issues/708
we need to add another graph to the metrics page:
we have
"Annotations/genes for low throughput publication in 5-year intervals"
but we also need
Annotations/genes for high-throughput (or total annotations)  throughput publication in 5-year intervals.
It will be much easier to explain the  difference in growth if small scale and large scale can be viewed side by side.

Does this need doing before the next grant application?  I just want to be clear that is what the label "before next grant" means rather than "before next grant starts".

Before the application (main, April, not preliminary, jan)

Now that the annotations in Chado (almost) all have a HTP/LTP flag I've been able to add a HTP annotation graph.  I haven't worked out how to put LTP and HTP side by side on the same graph yet so it's separate for now.
The average annotations per publication is lower in the new LTP annotation graph.
I think there are two reasons.  The main one is that the current graph on the stats page only includes annotations from Canto and assumes all Canto annotations are LTP.  The new LTP graph below includes annotation from the contig files.  Maybe including the config file annotations would lower the numbers?
The second reason is that some interaction annotations from Canto have been merged during the load with identical annotations from BioGRID.  BioGRID has some of them as HTP so they have been moved to the HTP graph.
I'm still checking the numbers so this isn't on the main site yet:

Maybe including the contig file annotations would lower the numbers?

I bet it would, because that would add a whole bunch of publications that have annotations, but that we would now regard as incompletely curated. Almost all of the papers in the contig files get more annotations when we revisit them in Canto.

I'm impressed that the drop was not larger (it is a substantial drop but it isn't an order of magnitude!)
Including contig data will only lower the pre 2010 number though so that's OK (i.e the current numbers will stay the same.
Interesting thet HTP is now dropping. I guess most of the genome -wide that will give annotatable results were done over 5 years ago (deletion collection etc), and now there are lots of conditional screens giving smaller results sets. I  thought this would be the case, but not so clearly- since I thought some expression sets would swamp this effect out (maybe most of those are also over 5 years old now too!...time flies)
Note in the graph labelling we should make it clear that this is "genes providing annotation, per publication" (more genes would be included in the experiement often)

I thought some expression sets would swamp this effect out

also, maybe more recent genome-wide work is generating browser tracks rather than Canto-able data - it wouldn't surprise me if that's where the expression datasets are going

Including contig data will only lower the pre 2010 number though so that's OK (i.e the current numbers
will stay the same.

The 2017-2019 dropped quite a lot too.

I'm only thinking about the qualititive quantitative expression....

The 2017-2019 dropped quite a lot too.

Ah I thought you meant you still needed to include the contig data in the figures above?

Ah I thought you meant you still needed to include the contig data in the figures above?

The graphs include all contig, Canto and GOA annotation.  I've fixed a few HTP vs LTP issues so I'll see what the graphs look like tomorrow morning.

OK, looks fine then. I expected a big drop because if a paper was in canto and had HTP it was classed as HTP (I think)

OK, looks fine then. I expected a big drop because if a paper was in canto and had HTP it was classed
as HTP (I think)

The current graphs on the Canto pages show everything from Canto.  Because the annotations are now marked as LTP or HTP in Chado we're able to take the HTP Canto annotation out of the LTP graph.  It's only a quite small number of HTP annotations from Canto though all of which are interactions.

I've fixed a few HTP vs LTP issues so I'll see what the graphs look like tomorrow morning.

I forgot the code to add a throughput flag to all the contig file annotations, it was only doing FYPO and GO.  That's fixed for tomorrow's load.
Unfortunately I broke last night's load with yesterday's changes.  I've fixed the problems and it works for me locally so I think tonight's load should be fine.

I think almost all the annotations from all the sources now have a throughput flag (high, low or non-experimental).
The last hold outs are 153 species_dist annotations that I can't find.  I'm not too worried as I was only going to flag them as "non-experimenal".  So they won't be included in the stats.

The split HTP/LTP annotations per paper graphs are now on the main site at the bottom of the stats page:
https://curation.pombase.org/pombe/stats/annotation
There are now only 179 out of 364,500 annotation that don't have a throughput type attached to them in Chado.  I'll chip away at those but I thing the graphs are accurate now.

I've edited the paragraph above the graphs to mention the HTP/LTP split.  Let me know what changes you'd like or edit it directly here: https://github.com/pombase/canto/blob/master/root/stats/annotation.mhtml#L438
This is what I've changed the text to:
"Mean number of manually curated annotations and genes annotated in PomBase per peer-reviewed paper in 5-year intervals.  Annotations are split into separate graphs for annotations from low-throughput experiments and high-throughput experiments."

Average low-throughput annotations per publication:
Average high-throughput annotations per publication:
Is also not quite right.
This isn't across ALL publications.
So it's  Average low-throughput annotations per publication from publications which have any LTP annotation (and the same for HTP).
Can we think of a succinct way to say this?

Average annotations per publication, publications containing low-throughput data ?

we should also check if the LTP  pre 1970 is really LTP!

This isn't across ALL publications.

So it's Average low-throughput annotations per publication from publications which have any LTP
annotation (and the same for HTP).

Currently the graphs show the averages for all publications that have any annotation.
Do we need to exclude annotations from HTP-only publications from both graphs?

Ah OK then the graphs are correct if across all publications... will have a think...
Keep as it is for now...
I'm off today.

Any thoughts anyone?
Are the current graphs the best way to show this?
@kimrutherford  which publications are pre 2000 HTP data?

which publications are pre 2000 HTP data?

They are all phenotype annotations.  The ones I checked are from PHAF files in SVN so they might change to LTP when we split the PHAF directory into LTP and HTP sections.
     pmid      | annotation_count
---------------+------------------
 PMID:8390662  |               41
 PMID:9003295  |               71
 PMID:9649519  |              211
 PMID:8065904  |               45
 PMID:166019   |               44
 PMID:8665408  |               39
 PMID:10449724 |               79
 PMID:1332977  |               56
 PMID:10079327 |               68
 PMID:9658208  |              147
 PMID:1315954  |              145
 PMID:8663159  |               37
 PMID:2657742  |               54
 PMID:7969124  |               29
 PMID:9917066  |               39
 PMID:9563836  |              179
 PMID:8382769  |               17

most  seem to be correctly classified, even the early ones are "geneome wide screens"

most seem to be correctly classified, even the early ones are "geneome wide screens"

Now that the PHAF files are split into LTP and HTP directories, all of the early phenotype annotations are now classed as LTP.  So the HTP graph has changed a bit:

Interesting!

Can we clearly label the complementary  "genes" bar chart above these in the stats page as "LTP"

Can we clearly label the complementary "genes" bar chart above these in the stats page as "LTP"

Is this too wordy?: "Average genes from low throughput experiments per publication"

I think its OK.
Maybe
Average genes from low throughput experiments/per publication
Makes it clearer how it translates graphically?

Average genes from low throughput experiments/per publication

OK, I've changed it to that.

One thing I still need is the  number of papers with HTP data.
So the total identified as HTP here and I'll add this too the "sequence browser hosted" ones.
It would be useful to have this number in the stats lise (at least the ones in this graph)
I will use the number through canto for LTP

One thing I still need is the number of papers with HTP data.

Here are the counts of HTP files that we load:
quantitative gene ex: 5
qualitative gene ex: 1
modifications: 6
phenotype: 41
total: 53
I also queried Chado for any publication that has any HTP annotations.  That didn't work out well.    An example is:
https://www.pombase.org/reference/PMID:21436456
all the interactions from that publication are marked as LTP in Chado except the interaction with the "Two-hybrid" evidence code.  That interaction comes from BioGRID and they've marked it as HTP.  I'm not sure it makes sense to count that paper as a HTP paper.
So instead I did some querying for publications with at least a certain number of HTP annotations.  There are 86 publications in Chado with at least 50 HTP annotations.  And there are 66 with at least 100 HTP annotations.

Do you have any more examples like this?
https://www.pombase.org/reference/PMID:21436456
I will ask bioGRID to fix.
I think for our stats for the grant  53 is a good number.

Do you have any more examples like this?

PMID:15809031 has 17 interactions but only three HTP interactions
PMID:21767457 has four interactions, two LTP, one HTP, and one is both.

These might be correct.
PMID:24497846 has a genetic interaction screen, but the screen maybe only identified a couple of results. Difficult to know if not looked in detail. For our purposes I think we would classify as LTP though...

I think we can close this and open new tickets. I scanned and I can't see anything outstanding.


rewrite: make it modular

Checklist

[x] The issues that this pull request is related to/fixes are mentioned.
[x] The purpose of this pull request is explained.
[ ] The changes made to the code, as well as the documentation have been explained.
[ ] The tests, lint & style checks all pass.
[ ] The documentation has been updated to reflect the changes made in this pull request.

Related Issues

Fixes #4 and #5.

Overview
This pull request rewrites the library to make it easier to add more text extraction methods. It also allows extraction from a file, buffer or a url.
The API is now as follows -
import { getTextExtractor } from 'office-text-extractor'

const extractor = getTextExtractor()

const location = 'https://raw.githubusercontent.com/gamemaker1/office-text-extractor/rewrite/test/fixtures/test-pdf.pdf'
const text = await extractor.extractText({
	input: location,
	type: 'url'
})

console.log(text)

Looking forward to this being finished!

It should be done in the next few days :)

@gamemaker1 Any chance you could publish an RC/beta version, if it's already working to some extent? We are doing feasibility study right now, and if we can confirm that this works, we can stop exploring other libraries.

Sure, I could release a beta version right now.
It only works on pdf and docx files yet, though.

@gamemaker1 Perfect, this is exactly the formats that we are interested in!

@kibertoad I published the version in this PR as v3.0.0-beta.1, you can install it via npm install office-text-extractor@next.

much appreciated!

@gamemaker1 Types seem to be not included in the bundle, was that intentional?

Re-published with types! I hadn't added the declaration: true option to the tsconfig file, so Typescript didn't generate types. Sorry about that :(

It works! thank you so much

this is great! Any timeline on the pptx. (etc) support in v3? Thank you!


Add repeatable healing items

About the PR

This adds repeatable doafters to healing items that stop when the patent can't be healed of that type of damage any more. Also stops if bleeding is healed via an item.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Healing items like bruise packs will now repeatedly heal until the patient can't be healed of that type any more!
add: Added a popup when bleeding stops because of a healing item

If there are any concerns with this PR please tell me. I think that having another usage for repeating doafters is needed, as currently many people don't like the current usages for them and there is quite a high chance that they might be removed entirely.

Make sure gauze and blood packs are compatible with this pr because theres been cases where the items can still be used past healthy for no real reason... unsure if this is still the case

I should make sure that doesn't happen.

https://user-images.githubusercontent.com/88291550/233755897-ceddefc4-d609-45a7-8619-3813bfc6e4ab.mp4

Make sure gauze and blood packs are compatible with this pr because theres been cases where the items can still be used past healthy for no real reason... unsure if this is still the case

There is a bug (fixed in this PR) where it only checks if a player has damage, not if the damage type matches the type healed by the medical item.

Make sure gauze and blood packs are compatible with this pr because theres been cases where the items can still be used past healthy for no real reason... unsure if this is still the case

There is a bug (fixed in this PR) where it only checks if a player has damage, not if the damage type matches the type healed by the medical item.

That's huge for new medical staff, thanks

https://user-images.githubusercontent.com/88291550/233790404-e8ff3aad-9a38-4a59-b464-0f56b78de6c0.mp4

https://user-images.githubusercontent.com/88291550/233795629-dc92a5a8-23bd-404a-b6b9-d499918769aa.mp4

https://user-images.githubusercontent.com/88291550/233796885-ea3b0973-c80d-4ab9-b817-1e0e407f3f64.mp4
It should be ready for review now!

The build & test debug error keeps happening inconsistently.

@vulppine do you mind reviewing my changes?

@OctoRocket apparently blood bags are broken as of recent, can you look into this, in case the PR broke it?


Stickybits seems to have an issue with nested elements on IE and Edge

Hello,
I'm looking to use stickybits for the project that I'm on. However, branched off of your example and replaced the html/css with my own layout. When I loaded this example on Edge and IE I am not seeing sticky behavior. It works on all other browsers I've tried so far.
Here's the code pen that I've been working with https://codepen.io/bxyoung89/pen/BZeyaE
My intention is to have the yellow section be sticky (as it is in chrome) but it doesn't seem to be moving as it should.

Thanks for sharing your issue @ssbyoung ! I'll look into it as soon as possible.

From my 👀 : IE doesn't support position: sticky so Stickybits defaults to position: fixed. The <element> that is supposed to be sticky would be set to fixed if it wasn't within a fixed element. 😢  As fixed <elements> are fixed relative to the browser window the second fixed item doesn't work.
Sorry if I'm not being clear. This is pretty complex!
I have a few questions:

Is the modal you're making visible on devices?
not meant to sound rude—why is the modal so complex? Like, what's the use case?

I'm asking these things because I'm leaning towards a custom solution. If possible, I'd like to help write something for this but I'm leaning towards saying Stickybits isn't a one stop shop for the problem you shared. I won't leave you hanging though! 🙌

Hey, thanks for getting back to me so quickly.
I didn't realize that it'd default to fixed. That explains quite a bit to me.
As for your questions

Currently we're only really supporting desktop browsers, so mobile isn't too bit an issue.
The modal is already existing in the app at the moment. I thought get a quick UX win by adding sticky functionality. However, it seems like we might be re-designing it in the near future. So it might not be necessary.

All things considered, it seems like you're right. Stickybits probably isn't the solution I'm looking for. I was secretly hoping there was some javascript magic under the hood to polyfill what I needed. However, if I'm looking at doing something a bit less complicated where sticky stuff makes sense, I'll definitely drop by again.
Thanks for your help!

@ssbyoung I have an idea to support your request. https://codepen.io/yowainwright/pen/EXzJeb
I changed window to #modal so the scroll event is attached to #modal. It is a minimal enhancement. I'm going to add it.
Thanks for pointing this issue out!!! 🙌

@ssbyoung do you have time to help me out and see if my un-published in npm version works for you in IE?!!! 🙏

@yowainwright sure, I can take a look. I'll get in contact with you

@ssbyoung I had to update variable calculations in 2 places = working on it. 🤘

@ssbyoung The calculations have been updated. I'm going to make a codepen and test before publishing in NPM—feel free to grab the code from GH /dist if you want to test drive.

@ssbyoung still not perfect in IE with a custom scrollEl. We're getting closer though.

@ssbyoung Stickybits is as good as it can get w/ the known issue of a fixed element within a fixed element.
From the updates that were made, I'd say that changing the margin-top of a position: relative parent element (the modal) on a scroll event could get the codepen you made close to what you might want. 😬
Thanks for the challenge. Please reach out w/ any ideas, etc.

Hey man. Thanks for trying! I'll keep you up to date if I run into anything else!


Operations should recognize auxiliary variables

Selected ECT operations should be able to correctly recognize auxiliary variables associated with a measurement variable. For example

uncertainty variables  provided for a measurement may be considered when deriving measurement statistics
uncertainty variables may be resampled using a different methodoloy
when extracting a measurement variable from a dataset, its auxiliary variables may be automatically extracted too

http://cfconventions.org/Data/cf-conventions/cf-conventions-1.1/build/ch03s04.html
http://cfconventions.org/Data/cf-conventions/cf-conventions-1.1/build/apc.html

Also:
http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html#cell-methods
There is also something called NetCDF-U meant to be a CF compliant standard for geo-spatial uncertainty information:
https://www.researchgate.net/publication/258780653_NetCDF-U_-_Uncertainty_conventions_for_netCDF_datasets
However, all the internet resources for NetCDF-U seemed dead, so I don't believe it's an active effort.

Soil Moisture doesn't have a standard name attribute, hence its uncertainy doesn't follow the scheme laid out in CF conventions.

See also #114

Operations that need to work with ancillary variables (propagate uncertainties), should depend on using the 'ancillary_variables' attribute of an xarray dataset, as per CF Conventions.
To mitigate the situation that many datasets don't abide by this out of the box, there could be an operation add_ancillary that would create the associations in the dataset. Then, this can be run before using operations that depend on ancillary variables. Note that the ancillary variables themselves are supposed to have the original dataset's standard_name in their standard_name fields. Also, uncertainty variables have well defined standard_names that should be used, or added.


Gulp watch not functioning properly

The following in my gulp file:
// ////////////////
// Required
// ////////////////
var gulp = require('gulp'),
	uglify = require('gulp-uglify'),
	browserSync = require('browser-sync'),
	reload = browserSync.reload,
	plumber = require('gulp-plumber'),
	concat = require('gulp-concat'),
	rename = require('gulp-rename');

// ////////////////
// Scripts Task
// ////////////////
gulp.task('scripts', function () {
	gulp.src(['app/**/*.js', '!app/**/*/.min.js'])
		.pipe(plumber())
		.pipe(concat('fullApp.js'))
		.pipe(rename({ suffix: '.min' }))
		.pipe(uglify())
		.pipe(gulp.dest('./dist'));
});

// ////////////////
// Watch Task
// ////////////////
gulp.task('watch', function () {
	gulp.watch('app/**/*.js', ['scripts']);
});

// ////////////////
// Default Task
// ////////////////
gulp.task('default', ['scripts', 'watch']);

When I run the watch task it throws an error like this:
Process terminated with code 8.
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: watch Unknown system errno 1450
    at errnoException (fs.js:1030:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1048:26)

I have upgraded everything to the latest versions and I don't know what else to try, I have also searched this on google and stack overflow but no luck there. Anyone have any ideas?

Please fix your code.

What do you mean fix my code? That's why I am here asking how I can fix it. if you meant simplify I took out the extra code that isn't part of the problem. I was trying to include the bare minimum to cut down on potential problems.

Not returning streams, etc.  Chocking this up to a duplicate of #651 - The file watcher has problems, switch away from it (chokidar, etc).  I think the https://www.npmjs.com/package/gulp-watch module might be a drop in replacement.

Alright sounds good thanks for the help and the quick response!


Card type problem.

I took a look on some other issues similar to mine, but couldn't find a way to fix it. Skill command works just fine, but when it goes to select the cards it shows a error message saying it couldn't identify the card type, but STILL selects them, and right after the script stops.

Does anyone have a older version of the code?

Could not reproduce it with ankulua 8.6 . Does it happen to any team comps you use? Can you provide a screenshot of the exact scenario of what cards it's trying to pick up before giving the error message?

I am having this problem with ankulua 8.3 as well

I am having this problem with ankulua 8.3 as well

Update to latest ankulua 8.6.

Found a solution, replace all the files on the EN folder. It worked normally. Thanks for the answers.

How did you replace them?


Replace blocking code in poll_ready with async code

Currently, Inner::poll_ready loops while waiting for credentials. On a single-threaded executor (like Actix), this results in the program getting stuck in a loop using 100% of its CPU core, since the future it's waiting on is never scheduled.
This PR changes poll_ready so that it returns Poll::Pending unless a cached token is available when it is called.

@paulgb
Sorry for the late reply 😅
Thank you for your contribution and for pointing out the problem!
I did not add a fix to this pull request because I decided it would be better to fix the other crates as well and resolve this issue.
The same fix as suggested in the pull request was made in this commit(https://github.com/mechiru/google-authz/commit/4054331b06e34bec00640a7c6d25c9b002d174a1) .
Can you please confirm that the problem has been resolved?

Thanks @mechiru, I appreciate all your work on this.
One comment on your approach, the type:
Pin<Box<dyn Future<Output = token::Result<Token>> + Send + 'static>>,

is not Sync, because the future itself is not Sync. This bubbles all the way up to make AddAuthorization not sync. A result of this is that a service wrapped by AddAuthorization can't be used by a connection pool.
The approach I took to this was to wrap it all in a (std) Mutex. Mutex is impl Sync for Mutex<T> where T: Send, so wrapping it this way results in AddAuthorization being Sync. This avoids two threads trying to progress the inner future at once.
The justification for a sync mutex instead of an async one is that it is not held over an await block and is never used in a blocking manner, only through try_lock.
If you like that approach, I would be happy to submit another PR on top of your latest commits applying it.

@paulgb
Thanks for your review.
The code you suggested is great!
I recognize the problem and suggest a way to solve it using unsafe impl.
Because State is a property of RwLock<Inner> and access to State.Fetching is exclusively controlled by using RwLock.write.
branch: https://github.com/mechiru/google-authz/tree/fix/add-sync
commit: https://github.com/mechiru/google-authz/commit/243dc2f734fb73dc37ca512a228ced57cd98ecfc
I want to make the code better, so I will consider all possibilities, not just the way I suggested.
What do you think?

That approach works too. I would suggest that it should be:
unsafe impl Sync for Inner {}

rather than for State, since State on its own is not a sync type. It doesn't matter so much because State is not a public type, but it might make it easier to avoid concurrency bugs down the road if the types match the concurrency semantics.
Also, it's up to you, but I'd consider limiting the unsafe to a tighter scope using a zero-cost type, like this:
/// RefGuard wraps a `Send` type to make it `Sync`, by ensuring that it is only
/// ever accessed through a &mut pointer.
struct RefGuard<T: Send>(T);

impl<T: Send> RefGuard<T> {
    pub fn new(value: T) -> Self {
        RefGuard(value)
    }

    pub fn get_mut(&mut self) -> &mut T {
        &mut self.0
    }
}

unsafe impl<T: Send> Sync for RefGuard<T> {}

And then using it around fut in State:
        fut: RefGuard<Pin<Box<dyn Future<Output = token::Result<Token>> + Send + 'static>>>,

That way, State really will be Sync and the compiler will detect that automatically.

Here's a branch with this approach implemented: https://github.com/paulgb/google-authz/tree/fix/add-sync

That approach works too. I would suggest that it should be:
unsafe impl Sync for Inner {}

I prefer this one too 😁

Here's a branch with this approach implemented: https://github.com/paulgb/google-authz/tree/fix/add-sync

@paulgb
This approach is very cool.
Can you create a pull request to this repository?

@paulgb Thanks. Version v0.0.2 has been released.


Auth-only version?

So I'm getting a headache trying to add the massive amounts of logic required from a blank app to get socket+passport auth working, and I'm getting a headache trying to take out things in your boilerplate that I don't want, which causes everything to break because you've dispersed the logic all over the place.
Is there ANY chance you could make a fork or branch or something that ONLY contains the auth and front/back separation? I don't want all the GUI tweaks, I just want passport and auth working for a separated front/back. I've spent like 12 hours trying to get this done and it's giving me a headache.

seems like you have already copied this project and made something different. I would hope that you would make fork instead of copy+paste option. Closing this now, but I think I'm going to make "proper" version of this... at sometime...

I'm interested in this as well!

I also think this would be a good idea and I am willing to do a pull request but I need get a more complete understanding of it all before that. I know what they mean about the code being spread out but the more I stare at it and hack with it the more I appreciate how it is set up. Its very modular actually.
I think this could all be in one repository, but on separate branches.

starting-place: A bare bones boilerplate with all the goodies.
example: All the Author/Book/etc stuff built on top of starting-place.

I think the main advantage here is that we could fork starting-place to make our own projects and reference example. Then if you add a new utility to the project, you would add it to starting-place and merge it into example. Similarly, we could pull those commits into our forks, since they wont include example code.

@veswill3 I'm willing to help you with that, with my limited knowledge on this, if you got time. We can hook up in skype and start working on this if you want to.

I would like to do that sometime @SudoPlz. Give me a few days to get a better understanding of all this first. Maybe like Tuesday of next week? We can chat outside of this issue.

Sure @veswill3. The reason I wanna do this to learn. My skype name is 'sudoplz' add me if you want.

@SudoPlz hah, I don't think my fork is stripped down enough!

Hmm, I think that the separate repo/branch is the way to go with this one. But really it's nice to see there is need for this too...

@tarlepp i wasn't saying it shouldn't be a separate repo. I just needed it way more than most of the other stuff in here.

@ProLoser I noticed your comment after I did post my...

@SudoPlz and @veswill3 I'm also interested of that skype chat if you're planning to do that.