fixes for win32 and osx32 segmented architecture changes

Really not sure how the win32 problems weren't caught in my previous builds.  The only thing I can see is that the commits on my system were in a different order than what showed up in the pull request.
The machobj.c changes were because I didn't test the osx build before submitting.  Oops.
The full druntime, phobos, and dmd test suites pass for both platforms.

lion os x :
dmd -m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d
make: *** [import/core/cpuid.di] Segmentation fault: 11
make: *** Deleting file `import/core/cpuid.di'

On 10/11/2011 11:49 PM, Long Chang wrote:

lion os x :
dmd -m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d
make: *** [import/core/cpuid.di] Segmentation fault: 11
make: *** Deleting file `import/core/cpuid.di'

$ dmd -m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d
$ echo $?
0
$ uname -a
Darwin nexus 11.1.0 Darwin Kernel Version 11.1.0: Tue Jul 26 16:07:11 PDT 2011; root:xnu-1699.22.81~1/RELEASE_X86_64 x86_64
I can't reproduce this on the auto-tester machine.  I recall sean installing a non-default compiler since the default
lion was producing buggy code.  What gcc/g++ do you have installed?
$ g++ --version
i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ ls -l /usr/bin/g++
lrwxr-xr-x  1 root  wheel  12 Aug  9 09:48 /usr/bin/g++ -> llvm-g++-4.2

root@loong ~# uname -a
Darwin loong.jundee.2288.org 11.1.0 Darwin Kernel Version 11.1.0: Tue Jul 26 16:07:11 PDT 2011; root:xnu-1699.22.81~1/RELEASE_X86_64 x86_64
root@loong ~# g++ -v
Using built-in specs.
Target: i686-apple-darwin11
Configured with: /private/var/tmp/llvmgcc42/llvmgcc42-2336.1~1/src/configure --disable-checking --enable-werror --prefix=/Developer/usr/llvm-gcc-4.2 --mandir=/share/man --enable-languages=c,objc,c++,obj-c++ --program-prefix=llvm- --program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ --with-slibdir=/usr/lib --build=i686-apple-darwin11 --enable-llvm=/private/var/tmp/llvmgcc42/llvmgcc42-2336.1~1/dst-llvmCore/Developer/usr/local --program-prefix=i686-apple-darwin11- --host=x86_64-apple-darwin11 --target=i686-apple-darwin11 --with-gxx-include-dir=/usr/include/c++/4.2.1
Thread model: posix
gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)

You have a slightly newer build of gcc based on a slightly newer build of llvm.  Unlikely to matter, but not impossible.
You're going to need to do some digging since I can't reproduce it.

make sure you did a make -f posix.mak clean followed by make -f posix.mak
retest

If that works, your build was unclean
If that doesn't work:

edit posix.mak and switch the GFLAGS line to use the first, with -DDEBUG
make -f posix.mak clean; make -f posix.mak
re-build druntime, does that compile still crash?
run the compiler under gdb to get a stack trace:  gdb --args

I make a clean rebuild, it still crash .    before your commit,  it is working .
I am not sure how to use GDB,   here is my test result ：
root@loong /opt/installs/d/druntime# gdb dmd
GNU gdb 6.3.50-20050815 (Apple version gdb-1706) (Tue Jul 19 23:33:12 UTC 2011)
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "x86_64-apple-darwin"...Reading symbols for shared libraries ... done
(gdb) show args
Argument list to give program being debugged when it is started is "".
(gdb) set args -m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d
(gdb) show args
Argument list to give program being debugged when it is started is "-m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d".
(gdb) r
Starting program: /usr/local/bin/dmd -m32 -c -d -o- -Isrc -Iimport -Hfimport/core/cpuid.di src/core/cpuid.d
Reading symbols for shared libraries ++.................................................................................................................................. done
Reading symbols for shared libraries . done
Program received signal SIGTRAP, Trace/breakpoint trap.
0x8fe01030 in __dyld__dyld_start ()
(gdb) backtrace
#0  0x8fe01030 in __dyld__dyld_start ()
#1  0x00001000 in ?? ()

sorry for my mistake , It seem use a dmd from /usr/local/bin,  but I put new builded dmd in /opt/loca/bin .  your path is working now with my g++ .


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #30.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render


using "Deploy to Azure" encounter errors

error message: The capacity should be null for standard deployment.
it seems due to ”capacity": 20 when deploy /chat, /davinci, /text-embedding-ada-002.
remove capacity then works.

2.error message: Another operation is being performed on the parent resource '/subscriptions/9dabf3b5-95af-489f-8423-ae43e4b1707c/resourceGroups/rg-aoai-chatpdf/providers/Microsoft.CognitiveServices/accounts/kevingptaoai'. Please try again later. (Code: RequestConflict)
it seems can not deploy the 3 model: chat, davinci and text-embedding-ada-002 in parallel.
refer to this blog: https://techcommunity.microsoft.com/t5/azure-database-support-blog/add-wait-operation-to-arm-template-deployment/ba-p/2915342#:~:text=How can an ARM JSON template be forced,to set the dependencies of the steps correctly
I can fix this error such as:
{     "type": "Microsoft.CognitiveServices/accounts/deployments",     "apiVersion": "2022-12-01",     "name": "[concat(variables('aoaiSvcName'), '/chat')]",     "dependsOn": [         "[resourceId('Microsoft.CognitiveServices/accounts', variables('aoaiSvcName'))]"     ],     "properties": {         "model": {             "format": "OpenAI",             "name": "gpt-35-turbo",             "version": "0301"         },         "scaleSettings": {             "scaleType": "Standard"         },         "raiPolicyName": "Microsoft.Default"     } }, {     "type": "Microsoft.Resources/deploymentScripts",     "apiVersion": "2020-10-01",     "kind": "AzurePowerShell",     "name": "Wait5s",     "location": "[parameters('location')]",     "dependsOn": [         "[resourceId('Microsoft.CognitiveServices/accounts', variables('aoaiSvcName'))]"             ],     "properties": {         "azPowerShellVersion": "9.7",         "scriptContent": "start-sleep -Seconds 5",         "cleanupPreference": "Always",         "retentionInterval": "PT1H"     } }, {     "type": "Microsoft.CognitiveServices/accounts/deployments",     "apiVersion": "2022-12-01",     "name": "[concat(variables('aoaiSvcName'), '/davinci')]",     "dependsOn": [         "[resourceId('Microsoft.Resources/deploymentScripts','Wait5s')]"     ],     "properties": {         "model": {             "format": "OpenAI",             "name": "text-davinci-003",             "version": "1"         },         "scaleSettings": {             "scaleType": "Standard"         },         "raiPolicyName": "Microsoft.Default"     } }, {     "type": "Microsoft.Resources/deploymentScripts",     "apiVersion": "2020-10-01",     "kind": "AzurePowerShell",     "name": "Wait10s",     "location": "[parameters('location')]",     "dependsOn": [         "[resourceId('Microsoft.CognitiveServices/accounts', variables('aoaiSvcName'))]"             ],     "properties": {         "azPowerShellVersion": "9.7",         "scriptContent": "start-sleep -Seconds 10",         "cleanupPreference": "Always",         "retentionInterval": "PT1H"     } }, {     "type": "Microsoft.CognitiveServices/accounts/deployments",     "apiVersion": "2022-12-01",     "name": "[concat(variables('aoaiSvcName'), '/text-embedding-ada-002')]",     "dependsOn": [         "[resourceId('Microsoft.Resources/deploymentScripts','Wait10s')]"     ],     "properties": {         "model": {             "format": "OpenAI",             "name": "text-embedding-ada-002",             "version": "2"         },         "scaleSettings": {             "scaleType": "Standard"         },         "raiPolicyName": "Microsoft.Default"     } }

error message: Encountered an error (InternalServerError) from host runtime.
I try many times, but finally report this error when deploying func/default

I cannot find detail error information, hope can get your help on this issue.

redeploy button cannot re-run, if click redeploy button, it'll back to the page of:

then it will report many conflict errors

Bing resource always report error
I test and create Bing resource alonely, it report error: (ApiSetDisabledForCreation) It's not allowed to create new accounts with type 'Bing.Search.v7'.
So, I removed the Bing resource. Could you help check and confirm if it is possible to create Bing resources? and what happens to this repo demo if don't create bing resource?

Thanks!
Kevin

Thank you Kevin, appreciate your help.  I did fix the OpenAI, capacity and the "timing" issue code that you provided.   For #3 the issue I see (which am not able to figure it out) is more around the timing on setting the configuration values in the Azure function.  I have not deployed fully, so will test it ou, but #3 and #4 are tied together as it should still allow you to redeploy (provided it's same prefix and parameters).   As to #5, it looks that your subscription is not enable for creating Bing API and it's perfectly fine for you to not create that as the only feature that uses (in current state) Bing API is "Smart Agent", so if you don't deploy that everything but that will still continue to work.

Thank you, Ashish!
hope you can reproduce the issue #3, #4 when fully deployed.  :)


Ignore unused imports in ModuleNotFoundError blocks

I'm actually not sold on this being a good change, but it would close #3279.

FWIW, IMO ignoring unused imports inside ModuleNotFoundError try-except makes a lot of sense.
There's also a lot of code which uses the less specific ImportError for this (maybe because ModuleNotFoundError was only added in python 3.6), but they'd be better served by switching to ModuleNotFoundError so maybe start without it.


[Feature][Gitlab job] gitlab trigger job bridge as job for Scope Config

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
In the CI/CD deployment setup, we can set job name in order to define what to consider as a DevLake Deployment.
However, gitlab CI/CD can also have trigger job (useful to delegate deployment part) that are seen as "bridge" in gitlab API.
Description
Gitlab bridge trigger job type should be also collected as any other job to identify a deployment job.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Startrekzky

Maybe a clone of https://github.com/apache/incubator-devlake/issues/6135

Maybe a clone of https://github.com/apache/incubator-devlake/issues/6135

Yes it's duplicated. Let's move the the original issue for further discussion.


Sled Lesson Plan

Write a lesson plan that pulls in the LEGO sled.

Linked in the LEGO sled material.


Added photos to visits and procedures (#1106)

Fixes #1106
Note: I added the functionality as I mentioned in #1106, which is to say when you upload a photo through the visits or procedure screen, the photo will then show up in the screen you uploaded it from AS WELL AS the patient photo section.  This allows access to all of a patient's photos, regardless of where they were uploaded from, to be accessible in the same place.  Of course, only the photos that were attached to a specific visit or procedure will show in their own respective views.
Changes proposed in this pull request:

Updated photo model with visit and procedure field
Changed photo controller to have a editController set by whomever is updating the photos, rather than a hardcoded 'patients/edit'
Added pouch views for photos_by_visit and photos_by_procedure
Added photo functionality to route and controllers for visits and procedures
Added photo tab to visit template
Added photo view to procedure template
Updated test fixtures with new pouch views

cc @HospitalRun/core-maintainers

I think the automated tests failed due to how I rebuilt the test fixtures.  I regenerated them to remove the warnings about the new pouch_views I added, but it seems I did something wrong (tried running the commands as described in the contributing doc).
The feature works, but I'll try to explore why regenerating the fixtures files is causing the build to fail.

The tests do pass when I use the original test/fixtures files by the way, just with a lot of warnings about my new pouch_views

I see now that the original fixtures contained test data that was not present in my dumps.
I have manually added the two new views to all the fixtures files, and now the test are passing without warnings about my new views.

@jkleinsc I made the changes you requested to photo/controller.js and reverted the changes I made to the testing fixtures.
However, regarding the tests you requested I add, those are not in my commit.  There doesn't appear to be a good way to test photo uploading programmatically.  You can't set the value of the file input directly, as that is blocked for security reasons.  I tried to do it programmatically via a manually created blob and change event, similar to what I found here, but that does not appear to be working in this scenario, as the file input is ignoring the change event when called programatically.
It appears that photo uploading is also not currently being tested for in tests/acceptance/patients-test.js, probably for similar reasons why I had issues adding it.
For your reference, here is an example of the code I tried to use for the automated testing:
  andThen(function() {
    click('button:contains(New Photo)');
    waitToAppear('.modal-dialog');
  });
  andThen(function() {
    assert.equal(find('.modal-title').text(), 'Add Photo', 'Add Photo dialog displays');
    $('.photo-source').prop('selectedIndex', 1).trigger('change');
    waitToAppear('.image-upload'); // Note: this is a class I added to take-photo.hbs in order for this to work
  });
  andThen(function() {
    // b64Data is a red dot.  We could make it a single pixel if we want this string to be smaller.
    let b64Data = 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==';
    let byteCharacters = atob(b64Data);
    let byteNumbers = new Array(byteCharacters.length);
    for (let i = 0; i < byteCharacters.length; i++) {
      byteNumbers[i] = byteCharacters.charCodeAt(i);
    }
    let blob = new Blob([new Uint8Array(byteNumbers)], { type: 'image/png' }); // Note: for some reason I this line was giving me errors from eslint due to it thinking Uint8Array isn't a global.  This was strange to me since it is used many other places in the code without error.
    blob.name = 'image.png';
    let inputElement = $('input[type=file]');
    inputElement.triggerHandler({
      type: 'change',
      target: {
        files: {
          0: blob,
          length: 1
        }
      }
    });
  });
  andThen(function() {
    click('.modal-footer button:contains(Add)');
    waitToDisappear('.modal-dialog');
  });

I tried many variations of that code, but as I said, this code does not get the file input to correctly handle the change event.  This can also be tested in your javascript console through a browser, it simply does not work outside the file chooser.

Thx @ ArtificialQualia for the reply. @jkleinsc can you review again?


Rework on NetGroups. Added icons and bootstrap layout.

As in title.

Current coverage is 7.62% (diff: 0.00%)

Merging #53 into master will decrease coverage by 0.40%

@@            master       #53   diff @@
========================================
  Files            4         4
  Lines          112       118     +6
  Methods         75        77     +2
  Messages         0         0
  Branches         9        13     +4
========================================
  Hits             9         9
- Misses         103       109     +6
  Partials         0         0

Powered by Codecov. Last update aa18221...c84b894


Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
Open
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

[ ] Update cimg/python Docker tag to v3.12

Detected dependencies
circleci

.circleci/config.yml

slack 4.13.3
ms-teams 0.0.1
cimg/python 3.11

docker-compose

http-query/docker-compose.yml

openbas/injector-http-query 1.1.1

dockerfile

http-query/Dockerfile

python 3.12-alpine

pip_requirements

http-query/src/requirements.txt

pyobas ==1.1.1

We already got https://github.com/OpenBAS-Platform/injectors/issues/1


commandline: ssh, When pasting, the tab crashes

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Windows Terminal version (if applicable):

1.2.2381.0

Steps to reproduce

settings.json:
{
                "guid": "{***}",
                "name": "ip",
                "commandline": "ssh user@ip",
                "closeOnExit": "always",
                "icon": "path.png",
                "colorScheme": "nord"
}

This is the second tab setting, So I press ctrl+shift+2, I can directly enter the terminal after ssh remote, it works well, except for this problem: when I paste(ctrl+v,ctrl+shift+v,right click), this tab always closes automatically (may be pasted once or twice, Sometimes I pasted for nearly 10 times in a row, and ended up being closed), and the rest were not directly ssh tabs (such as entering cmd first, and then ssh remote) working normally.
In pane, the same problem.
Expected behavior

I commented "closeOnExit": "always" in settings.json, When I paste, I have the following problems:
1:
packet_write_poll: Connection to IP port 22: eother

2:
A descriptionpacket_write_poll: Connection to IP port 22: eother

3:
Last loginpacket_write_poll: Connection to IP port 22: eother

4:
Lapacket_write_poll: Connection to IP port 22 : eother

The first type of abnormality is the most.
Expected behavior

The current ssh tab is closed.

This is very strange! It sounds like the same issue as /dup #7601


Test error

I think this works now.
Is there a way to look at CI-built docs?

Yes, I upload it as an artifact.


Fixed Welding Tool Not Updating

Fixes #1271

Added the ISolutionChange interface to the WelderComponent so that it dirties the entity any time the amount of welding fuel changes. This applies when it is lit and when it is unlit.
I also removed some redundant code.

Looks good to me, quick and easy change


Fix a generic type reference

We used the wrong one here, and it ends up removing the need to do two unchecked casts.

See also #1586


HBASE-28415 Remove Curator dependency from hbase-endpoint (#5738)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 12s
branch-3 passed

+1 :green_heart:
compile
0m 16s
branch-3 passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 11s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 17s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
shadedjars
6m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 54s
hbase-endpoint in the patch passed.

24m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5750/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5750

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff4520c55b81 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / b374e52893

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5750/1/testReport/

Max. process+thread count
1394 (vs. ulimit of 30000)

modules
C: hbase-endpoint U: hbase-endpoint

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5750/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
4m 44s
branch-3 passed

+1 :green_heart:
compile
0m 35s
branch-3 passed

+1 :green_heart:
spotless
1m  1s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 24s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

25m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5750/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5750

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 1df198f8c585 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / b374e52893

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-endpoint U: hbase-endpoint

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5750/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Remove dependency on package:collection by moving mergeSort into foundation/collections.dart

Description
This removes a dependency from Flutter (package:collection) by copying the implementation of mergeSort into Flutter's foundation/collections.dart.
Also, removed a reference to UnmodifiableSetView from the shortcuts code by just returning a copy instead.
Tests

Added tests for mergeSort from collections.

Breaking Change

[X] No, no existing tests failed, so this is not a breaking change.

Analyzer seems to be complaining about somethin'


Add auto update utility

Currently updates have to be done manually. Make it so the app checks for updates each time it boots and implement a utility to upgrade and then replace the old version

It seem , need some endpoints to check version against application.

Hey @joshghent , could I suggest a possible solution for this issue?
Once #74 is resolved, and installation via brew is possible, I would expect the majority of installs would come from brew rather than the released dmg/app. That being the case, I would suggest:

adding some logic to check for updates using the GitHub Releases API and display a banner if an update is available
on clicking the the banner, the user is instructed to run brew update joshghent/gifbar (or manually update if they aren't using brew).

This avoids needing to implement a self-update feature that wouldn't be necessary for the majority of (brew) users anyway.

@jamescallumyoung Great idea! Let's do that. Are you starting on the CI?

I'm going to take a look at the brew and CI stuff today/tomorrow @joshghent.


Add newPost.sh script for post metadata

Fixes #4
No one took this for the Hackathon, so I figured I would take a stab at it. Super simple shell script that just appends to a file user-inputted metadata.

Shebang added, I think it's in a good state to merge. Can improve upon it later, but it works fine for what it is.


Hero tweaks

two changes:

when the hero images are loading, it can take a second or two to show up. During that time, the text is white (with shadow) on a what background. This gives a greyish background to hero sections with images, ensuring that the text is readable even before the image loads. There's also another css change for this - giving image-free heroes a transparent background - but that is just to preserve their previous styling and doesn't make any visual changes.
give the photo credit a slight text shadow so it's more readable on various background colours/images

We also need to make the images a bit smaller that they load faster.
It was in my to-do list 😄

Ooh, I like them both <3 Second is cleaner (nothing in the background), so that maybe?


Revisit polyfilling

It might worth reconsidering the polyfilling issue.
Originally I shipped all necessary polyfills to make it easier to adapt the library, but that comes with some cons:

Shipping the polyfill adds extra weight to the lib
If the polyfill is applied automatically, then that could be applied before the app developer applies its own polyfill => this could result in hard to debug situations, where this lib would polyfill something sooner than the app developer.

Using something like polyfill.io, or just a separate polyfill js file made by the app author should be an easy enough thing to do, since I'm already assuming a lot of knowledge with these modules anyway.
Anyway, needs some more research into polyfilling best practices.

I wonder if it would be possible to ship polyfilled and non-polyfilled versions. 🤔

note: Look into babel-preset-env, which is supposedly able to auto-polyfill source code by injecting require statements where needed.
(It still probably doesn't polyfill ResizeObserver though.)

Still no easy solution for this (https://github.com/w3ctag/polyfills/issues/6) but shipping a polyfilled / /non-polyfilled version seems like the best way for now.

UMD support will probably need to be dropped, as automatic polyfilling causes some weird issues with it. (cjs, esm are both fine)
I can polyfill most things automatically, but ResizeObserver will be a harder nut to crack:
https://github.com/babel/babel/issues/7328


Implement ZeroizeOnDrop

This is waiting for RustCrypto/utils#700 and a new release. Deprecates Zeroize(drop) in favor of ZeroizeOnDrop.

This is ready to be merged now that the new version of Zeroize is out. I'm still providing backwards compatibility, especially because the new version is not a stable release.
I would say we can talk about actually enabling this feature by default at some point in the future.


12.4.0 LED on caps lock doesnt work

I am trying to accomplish changing caps lock to F13, but green led light next to caps lock stops shining after i add option "to key" in simple modifiaction. I am using mojave 10.14.5. Macbook pro 13' 2018. I saw that this issue should be fixed since 12.2 but it still persist on my computer, tried restarting, also installing 12.2 and 12.4 again, also tried to install it via cask, nothing works.

I am using the latest version of Karabiner (12.5.3) on Mojave (10.14.5) running on a Macbook Pro Retina circa late 2012, and for me the problems described in other closed threads, and described above persists, and has never ceased to be an issue. I have tried all of the subsequent releases that claim to have fixed the problem. The problem persists.


Insert Macro in RTE missing?

Hi Articulate GitHubbers & Shazwazza,
I think its a config setting but where can i allow the Articulate plugin content nodes to Insert / use of Macro's in the RTE within the Umbraco CMS?
I would like to be able to insert a Macro within our news items which is driven by Articulate.
Any pointers appreciated.

Found the solution:
Developer > Data Types > Articulate Rich Text > Ensure "umbMacro" is selected.

Great, glad you found it :)


Quoted integers fail to parse as int64 but error message is not helpful

Problem statement

swagger validate swagger.yaml
json: cannot unmarshal string into Go struct field SwaggerProps.definitions of type int64

The following diff made it work (file attached below):
diff --git a/swagger.yaml b/swagger.yaml
index 8f77805..44852c7 100644
--- a/swagger.yaml
+++ b/swagger.yaml
@@ -2198,7 +2198,7 @@ definitions:
         items:
           $ref: '#/definitions/TeamMember'
         type: array
-        minItems: "1"
+        minItems: 1
       customers:
         title: Customers assigned to the team
         items:
@@ -2255,11 +2255,11 @@ definitions:
         maxLength: 60
       username:
         type: string
-        maxLength: "60"
-        minLength: "2"
+        maxLength: 60
+        minLength: 2
       accountNumber:
         type: string
-        maxLength: "30"
+        maxLength: 30
       enabled:
         type: boolean
       color:
@@ -2304,11 +2304,11 @@ definitions:
         $ref: '#/definitions/TeamMembership'
       username:
         type: string
-        maxLength: "60"
-        minLength: "2"
+        maxLength: 60
+        minLength: 2
       accountNumber:
         type: string
-        maxLength: "30"
+        maxLength: 30
       enabled:
         type: boolean
       roles:
@@ -2344,11 +2344,11 @@ definitions:
         maxLength: 60
       username:
         type: string
-        maxLength: "60"
-        minLength: "2"
+        maxLength: 60
+        minLength: 2
       accountNumber:
         type: string
-        maxLength: "30"
+        maxLength: 30
       enabled:
         type: boolean
       color:

Swagger specification
(Converted to TXT to get past Github file type allowed upload but is YAML.)
swagger.txt
Steps to reproduce

Download swagger.txt
mv swagger.txt swagger.yaml
swagger validate swagger.yaml
apply diff, run swagger validate swagger.yaml again

Environment
swagger version: v0.30.3
go version: 1.19
OS:   debian

Opened https://github.com/kimai/kimai/issues/3720 against the implementors of the swagger spec. Maybe interesting to see how that goes down.


Private key client side handle

What kind of client side private key handling is this that allows you to send whatever whomevers coin back?!

Tis is an email from freewallet.org, which is a closed-source centralized wallet where you don't control the private keys.
Your getting that wallet confused with freewallet.io which is an OPEN source wallet where no one has access to your funds/keys except you.
You should talk to the freewallet.org guys about your concerns with their wallet... this email is not related in any way to freewallet.io or freewallet-mobile


Allow customisation of initial checkpoint

Enhancement
Allow customisation of the initial checkpoint to be created if no existing checkpoint is found.
Use case: For event hubs with large persistence new consumers might not want to start from the earliest possible, but rather from a more recent or the latest checkpoint.

[x] All tests passed
[x] Add change to changelog.md

Hi! Thanks for your contribution, will take a look at this changes.


Can't import with NPM on vanilla js project

Hi, looks like I can't import this way :
import beercss from "beercss";
import materialDynamicColors from "material-dynamic-colors";

got some errors, about import that must start with /, ./ or ../ 👀
Do you have a working example, without CDN ?

I have tested all npm imports here https://github.com/beercss/beercss#npm
Can you give more details about your stack?
Do you install "beercss" and "material-dynamic-colors" before import it?
This error seems to be related when you are importing without installing before.

Hi !
It's a simple project, npm add --save beercss and npm add --save material dynamic-colors
I have them in my node_modules, but can't make the import work 👀

I will close this issue, ok? (no response after one week)

Oh, I was closing this issue right now, I will reopen it 🙂

I would suggest to use a bundler like Vite (https://vitejs.dev/guide/#trying-vite-online), it has a vanilla and vanilla-ts template.
Why?
With a bundler you can import fonts and other file types automattically. If you start a npm project from zero (without a bundler) you need to implement your own way to import some files types (or use a cdn version instead).
Beer CSS needs to import fonts (.woff2) and (.css) that are in our default import import 'beercss'

I will update our docs, to suggest use a bundler too (with that simple import).

Work perfectly with vite ;)
TY !


lklWithFirewall: init

There is a pull request in the LKL repo adding firewall support: https://github.com/lkl/linux/pull/431
It simply enables the appropriate options in the kernel config, since the framework is already there.
It has not been merged yet, because enabling these options by default would lead to bigger lkl binaries and an overall slowdown for all users. However, since we can provide an opt-in variant with Firewall support, there is no reason not to do it.
This is very useful for nftables rule checking without having access to the kernel interface.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

See here for a usage example

Thanks!


add Tensor.ones_like()

need to improve the tests so we don't repeat code

I'm wondering if it would be better to have something like torch.full_like.
Maybe switch Tensor.ones to be Tensor.full as well then add Tensor.ones back calling Tensor.full

yeah makes sense, gonna work on it

make sure to add tests for full and full_like as well

LGTM!


Can't preselect items in multiple select

Hi,
if using multiple select How can I pre select items in the dropdown?
DropDown is bound to angular model on the controller.

set your ng-model in the view of the dropdown, then from controller set the model as an array with the same keys as your repeat with your perferred value(s). Its quite simple.
Example
Controller
$scope.default = [ {id: "1", name: "Test"}, {id "2", name: "Test2"} ];

Add more objects to preselect more... you get the point :P
View

            {{user.name}}

Code is untested but should work!

I post this just in case someone is having issues with preselect. Hope to save time.
The preselect works fine, but the button label does not reflect the correct state selection.
After selecting one more item, it updates correctly. Seems like the initial value is not taken correctly.
Example

 SELECTED ITEMS ({{ selectedItems.length }})

         {{ item.name }}

$scope.selectedItems = [{id:1, name: 'foo'},{id:2, name: 'bar'}]

In this case the label on top shows SELECTED ITEMS (2), the two items inside the dropdown are marked as selected (with the checkmark), but the button label says Nothing selected.
if I select one more item, the label is correcly updated showing 3 Items selected.
Solution
Adding the deep-watch attribute on the nya-bs-option solved the problem for me.

@lordfriend think you can close this. It works as expected.

I'm having problems with the multiple-flag that does not set the values from ng-model when multiple is set. If I remove "multiple" the first object is selected as it should with the same data but multiple values is not selected. Tried all possible combinations, including deep-watch.

        {{user.Name}}

In multiple mode，ng-model is an array

In my example above I have MyResourcesInclTemps which is an array
[{"UserId":123,"Name":"Peter"}, {"UserId":124,"Name":"Maria"}]
and the model (task.AssignedIds) is
[124]. I've also tried with an exactly the same array as the options but it also fails.
[{"UserId":124,"Name":"Maria"}] .
How do you suggest I solve this?

@rolfback  You need add data-value="user.userId" to nya-bs-option directive.
this attribute tell nya-bs-option directive to resolve user.userId in each context as model value.
doc is here http://nya.io/nya-bootstrap-select/#!/api/nya-bs-option
the example is here http://nya.io/nya-bootstrap-select/#!/examples/groups-and-more

Thanks @lordfriend!
I just hardcoded an variable to hold the array [124] and used that instead of user.AssignedIds (which contains the same value) and then it works as it should. Must be something with the parent ng-repeat then and the digest cycle.

To save time and frustration for future users that might have the same problem as I did; multiple isn't working within a ng-repeat. Everything looked ok when printing out {{task.AssignedIds}} but after a few hours I found the error. The string from the database was not treated as an array. My solution was to loop the values and update the array for the model:
angular.forEach(items, function (value, key) {
    value.AssignedIds = angular.fromJson(value.AssignedIds);
});

data-value="user.userId" to nya-bs-option directive  this works for me


comments on the interpreter

Do you have plans to implement the interpreter in assembly? like the ART VM。

We don't have any plans in the near term to implement the interpreter in assembly. If there is a strong customer requirement and use case for this we will re-evaluate.


Make Quadrant labels optional

An option to remove the quadrant labels (e.g. Temple’s Corollary) would be nice. (via @rzink01)

Note that there already is an undocumented config.show_quadrants option, but not sure if it's exposed to the user at this point.

Need input from team on whether this should be added for v1.0.


MEM-52: Updated flask routes with proper versioning

Minor questions I need answered, but otherwise, pretty straightforward.


Document all available ApplicationInsightsServiceOptions

ApplicationInsightsServiceOptions now contains more options. It now has options for each auto-added telemetry module.
This doc should be updated to reflect the new options.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6440efaf-8541-515d-7d87-ce2b5ee40e39
Version Independent ID: 8743926d-744e-fef0-af49-a16e6b37dc88
Content: Azure Application Insights for ASP.NET Core applications - Azure Monitor
Content Source: articles/azure-monitor/app/asp-net-core.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@cijothomas Thanks for the feedback. I have assigned the issue to the content author to evaluate and update as appropriate.

I fixed it with a PR to private repo. closing.


chore: Bb 317 update loading nmp files in bb

Description
BB now loads virtually any fert from a field with it's label onto the calculate nutrients list for the given field.
Please help me test and catch any major bug from this ticket. You can ask me for an .nmp file I created with all the fert options. I used it for mapping the ferts ids and testing.
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

NMP Ferts

BB loading NMP Ferts

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

tried reloading it and resetting my cache
here's what's happening on my end. it's returning the number value of that option.

Openshift is not updating the deployment, you gotta pull the branch and test it locally. Those bugs should have been fixed already:

The id's being subbed by 0 got fixed on a commit I just pushed.
Try it ou locally on desktop and let me know :smile:

Tested it out and it works well. One thing I would like to ask is that, since we have fertilizers printed on the list. Shouldn't it appear here in the Fertilizer CustomSelect Component as well? There's a lot of dry fertilizers but it doesn't let me choose another fertilizer to add to the field, or add that fertilizer in another field.

I totally agree with that new feature. Will create a new ticket for it. For now, we should move onto the blueberry calculation.


Prevent helperText from overwriting error messages

Error message text of a field previously was overwritten by helper text due to the ...props line which includes the original helper text. This PR fixes the issue, and added a test case for this in the storybook.

I just spent hours pulling my hair out debugging to find that this issue was the cause of my bug and it was already known about and a PR fixing it written. It would be lovely to see this merged.


chore(seed): freeCodeCampify remaining sections of codebase

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.

Description

This PR is a partial completion of issue #12472.
This mainly targets seed files, but I ran a search when I was finished with that directory and found a couple of nagging left over little buggers in other areas of the codebase, so I went ahead and fixed those as well.
I've replaced every instance (visible to the user) of Free Code Camp, free code camp, FreeCodeCamp, freecodecamp, and FREE CODE CAMP with the much more highly desirable freeCodeCamp - except in irrelevant URLs not visible to the user or where required by challenges (ex. regex challenges include other cases in  tests). I did hit some URLs (only the ones that we've changed, i.e. github, codepen), and, I even got the issue template!
I did mention in #12472 that I did leave a few instances of freecodecamp in the Twitch challenge, because not sure how the API would interpret the case change. Also, our name has not yet been changed on Twitch, and we may have left that out of the change plan (looks like we're still FreeCodeCampin' over there! 😜  ).
Anyway, one step closer to putting this issue to rest finally!

@Greenheart Ok, check it out when you get the chance. Made requested changes! Off to node school for me 😄

@Greenheart There's 3 new lines between the backticks, no? Not sure why there should be a white space left there? Is there a reason why code shouldn't start at the first character of the new line?

@no-stack-dub-sack Sorry, I meant a space after the bullets like + .
In GitHub markdown, there's a difference between using a space or not:
+hello       (+hello)

hello      (+ hello)

@Greenheart Sure, but this is between sets of  ```, in which markdown is not interpreted:
__ignored markdown__

so the only difference between leaving a trailing white space there would be this:
assert(someSuperCoolCode === true, 'message...');

vs.
 assert(someSuperCoolCode === true, 'message...');

Just a white space 😄
I'll change if you'd like, I think perhaps I'm still missing the point though

@no-stack-dub-sack OH! Hahaha I interpreted the + signs as bullets in MD...
This is ready :laughing:

@Greenheart hahaha, I sensed there was a disconnect somewhere! Well, let me just fix the newlines after the screenshot section before you merge

@Greenheart Okie dokie, once travis is done doing his thing, we're good to go. Phwewf!
Travis - who is that guy anyway? Always building things


Move Get and bounded types to sp-core

This PR moves the Get traits, bounded types and associated macros to sp-core from sp-runtime.
The motivation here is a recognition that these types and traits don't really require a notion of the runtime, and are simply plain Rust new types that can be generally applied everywhere, which then makes it easier for new crates to resolve circular dependency issues as they do not necessarily need to depend on sp-runtime, but rather something even more basic and primitive than it.

Can you be more specific on why this is needed? Where are we having circular depedencies?

@bkchr I'm in the middle of creating a new crate called sp-weights, with the intention of moving the Weight struct to it. The Get trait lives in sp-runtime, and some of the Weight impls depend upon it, so before this PR, sp-weights would have to depend upon sp-runtime, which could be problematic as the DispatchInfo stuff in sp-runtime depends on the Weight struct as well, creating a circular dependency.

bot merge


Clean up Travis builds

Updates docker-squash so that Travis builds will pass again (due to updated Docker).
If this is problematic, I can switch this so instead we downgrade Docker on start, but I believe RHEL7/CentOS7 both ship with Docker 1.7+, so we should be fine, but I need someone else to check.
Sets sudo: required. This isn't strictly necessary, since Travis will force this anyway if you have services: - docker, but it's more consistent with what's actually happening.
Parallelize Travis builds by building all of the Go versions simultaneously in different jobs. This speeds up Go builds by 3x.

We could potentially speed up Travis builds further by using SKIP_SQUASH (in which case the docker-squash changes could be dropped), since these images are only being used to test to see if the Dockerfile works, but I don't know how you feel about this.

Hey @lukegb,
Thanks for your work, this is awesome! I'm very sorry that it took me so long to review this.
On squashing, I was considering switching to https://github.com/openshift/imagebuilder instead of docker build, as it builds a squashed image without any additional work. What do you think about that?
Jonathan

Merged, thanks! I'll worry about the imagebuilder thing separately :)


Harmonize launching Questionnaire

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2180
Changes:

Refactor all Questionnaire and QuestionnaireResponse validation to QuestionnaireActivity

Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba @ageryck kindly do a test run for all Questionnaire scenarios using this branch


fix: bump package versions

👋 Thanks for creating a pull request! 🚀 Checkout the storybooks we've created for it: reactangular


Fix a string template parsing issue

fixes https://github.com/openrewrite/rewrite-kotlin/issues/260
I have identified that 4 lines of code are the root cause of this issue, removing them resolves the issue and also passes all the tests.
However, those 4 lines of code seem to be added for a specific purpose, I would like a second opinion to review and confirm whether it is safe to remove them.

Nice. I debugged the test case and also couldn't see any reason not to remove these lines.


The drop rate from exploded blocks should be 100%

Note: Drop rate from exploded blocks should only be 100% for TNT explosions as per the wiki:
https://minecraft.fandom.com/wiki/Explosion


Create Unit test for About your work Page

About your work
a) Next question button - error messages show if fields are empty
b) “Are you a healthcare worker?” question check drop-down menu options
c) “Do you care for multiple people in the community, with direct contact with your patients?” question check drop-down menu options
d) Next question button navigates to next screen

Thank you for creating this issue.
We are reviewing our approach to testing + will update the guidance around testing once that is completed.


Fix link to the repository

Hexdocs contains the wrong link to the repository in the sidebar: https://hexdocs.pm/migrant/index.html

Thank you for catching this!


Middleware/hawkular domain entity needs an icon

needed as glyph and icon, currently some placeholders are used.
https://docs.jboss.org/author/display/WFLY10/Admin+Guide?_sscc=t#AdminGuide-ManagedDomain
related to #10172 and #10338
cc @epwinchell @serenamarie125 @chessbyte
@miq-bot add_label ui, providers/hawkular

cc @Jiri-Kremser

@chessbyte please set the relevant assignee - either ui or ux representative?


Override message name via attribute

Currently, the message name is inferred from the CLR name of the message, be it a command or an event
This is inconvenient when sender and receiver don't share the message types via a shared assembly. In this case, the message has to have the same CLR name (namespace and class name).

Something like
public class MessageAttribute : Attribute
{
    public MessageAttribute(string name) { ... }

    public string Namespace { get; set; }
}

[Message("AddItemToCart", Namespace = "Shopping")]
public class AddItemToCart : ICommand
{
    ...
}

To be decided whether or not the Namespace is required (and therefore part of the constructor) or it can be left blank, creating namespace-less messages


Schema/Metadata error when reading load_data_with_illum.parquet using polars

Taken from the slack thread here
Alán:
Both a tool and an open question (for
@ank
but posted here because it is of general interest).
To access cpg from polars (in a lazy and non-lazy manner) without credentials you can use
if lazy:
    # TODO Raise issue and find the problem with the image location datasets.
    # It seems to be related related to UTF8 encoding.
    # Example path failing:
    # 's3a://cellpainting-gallery/cpg0016-jump/source_10/workspace/load_data_csv/2021_08_17_U2OS_48_hr_run16/Dest210809-134534/load_data_with_illum.parquet'
    fs = S3FileSystem(anon=True)
    ds = dataset(path, filesystem=fs)
    result = pl.scan_pyarrow_dataset(ds)
else:
    # Read whole dataframe
    result = pl.read_parquet(
        path,
        use_pyarrow=True,
        storage_options={"anon": True},
    )

You can see the specific imports and documentation on
https://github.com/broadinstitute/monorepo/blob/7b9f9d53db69dbfd56ca12bbcec39e882f878906/libs/jump_portrait/src/jump_portrait/s3.py#L140-L157Does anyone know where is the code that generated the load_data_with_illum.parquet? There's something off with the column types and I can't lazy-load it (but loading it whole works fine). I can use the above code to load profile parquets but not those. (edited)
s3.py
if lazy:
    # TODO Raise issue and find the problem with the image location datasets.
    # It seems to be related related to UTF8 encoding.
    # Example path failing:
    # 's3a://cellpainting-gallery/cpg0016-jump/source_10/workspace/load_data_csv/2021_08_17_U2OS_48_hr_run16/Dest210809-134534/load_data_with_illum.parquet'

https://github.com/[broadinstitute/monorepo](https://github.com/broadinstitute/monorepo)|broadinstitute/monorepobroadinstitute/monorepo | Added by GitHub
14 replies

Shantanu
16 hours ago
Here is the codehttps://github.com/jump-cellpainting/datasets-private/blob/ee6eede8add80a40a8d2fed6e5173944a60b17ed/load_data/curated_load_data.Rmd
16 hours ago
I ran it on source by source basis
16 hours ago
Here are PRs https://github.com/jump-cellpainting/datasets-private/pulls?q=load_data
16 hours ago
Seems like a type issue
ComputeError: parquet error: Error { source_location: ErrorLocation { type_: "KeyValue", method: "value", byte_offset: 9300 }, error_kind: InvalidUtf8 { source: Utf8Error { valid_up_to: 92, error_len: Some(1) } } }
16 hours ago
df = pd.read_parquet("~/Downloads/load_data_with_illum.parquet") works
df = pl.read_parquet("~/Downloads/load_data_with_illum.parquet") does not
16 hours ago
This worked:
df = pd.read_parquet("~/Downloads/load_data_with_illum.parquet")
df.to_parquet("~/Downloads/load_data_with_illum_fixed.parquet")
df = pl.read_parquet("~/Downloads/load_data_with_illum_fixed.parquet")
16 hours ago
So something funky happening with typesHope that helps
13 hours ago
Thanks! I can usually read it by setting use_pyarrow=True, I just need to find out what that does and how to use it when lazy-loading.
4 hours ago
what you’ve found points to some issue with the data types, and fixing those might be easier (see the fix above, assuming it’s actually a fix and not some unwanted coercion)
37 minutes ago
But that would require updating all the files on aws, which seems more laborious from my perspective. If this is a fringe case on how pandas saves parquets that is incompatible in certain cases with polars, it may have happened elsewhere in our datasets and we would have to also undertake the task of finding and replacing all those.
36 minutes ago
Whereas if we use the pyarrow reader that seems to work for them with no inconvenience, the problem is automatically solved everywhere.
21 minutes ago
We can do it en masse – it's not awful because we can index into all load datas using plate.csv.gz. The files are pretty light so it should be a few hours of wall time. Keep us posted.
21 minutes ago
:taco:
@Alán
for working through this!
< 1 minute ago

Alán
Ok, I think I have a vague idea of what is going on. After seeing how they were generated from r, the schema that these files come with makes more sense. The problem is likely this metadata: ARROW:extension:name:'X UTF-8	' + 49   and   ARROW:extension:name: 'arrow.r.vctrs'.The schema is shown below for future reference. I will open an issue and paste all this so we can reference this in the future.
ds.schema, the problem is likely to be some columns  having thje
Out[20]:
Metadata_Source: string
Metadata_Batch: string
Metadata_Plate: string
Metadata_Well: string
Metadata_Site: string
FileName_IllumAGP: string
FileName_IllumDNA: string
FileName_IllumER: string
FileName_IllumMito: string
FileName_IllumRNA: string
FileName_OrigAGP: string
FileName_OrigDNA: string
FileName_OrigER: string
FileName_OrigMito: string
FileName_OrigRNA: string
PathName_IllumAGP: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumDNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumER: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumMito: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumRNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigAGP: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigDNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigER: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigMito: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigRNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
UTF-8	' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
-- schema metadata --
r: 'A
3
262402
197888
5
UTF-8
531
2
531
1
787
3
531
53
787
0
1026
1
26215' + 6439

The way it works when loading it using pyarrow is because pyarrow uses ffspec to load the whole table into memory at once [1]. I need to see if we can force the schema of all columns to be pl.Utf8 strings.
[1] https://github.com/apache/arrow/blob/0402e306a9d9f57ff22c87bf8689b8e7203483e5/python/pyarrow/parquet/core.py#L1454C1-L1458C1

I am pretty convinced that this is the R pyarrow library changing the type of columns with longer sizes. The metadata being whacky matches long columns
Whacky field metadata
ds.schema
Out[224]:
Metadata_Source: string
Metadata_Batch: string
Metadata_Plate: string
Metadata_Well: string
Metadata_Site: string
FileName_IllumAGP: string
FileName_IllumDNA: string
FileName_IllumER: string
FileName_IllumMito: string
FileName_IllumRNA: string
FileName_OrigAGP: string
FileName_OrigDNA: string
FileName_OrigER: string
FileName_OrigMito: string
FileName_OrigRNA: string
PathName_IllumAGP: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumDNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumER: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumMito: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_IllumRNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigAGP: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigDNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigER: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigMito: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
PathName_OrigRNA: string
  -- field metadata --
  ARROW:extension:metadata: 'X
���������UTF-8�������������	�' + 49
  ARROW:extension:name: 'arrow.r.vctrs'
-- schema metadata --
r: 'A
3
262402
197888
5
UTF-8
531
2
531
1
787
3
531
53
787
0
1026
1
26215' + 6439

Length of columns:

result.with_columns(pl.all().str.len_bytes()).max().to_dicts()[0]

In [222]: Out[222]:
{'Metadata_Source': 9,
 'Metadata_Batch': 27,
 'Metadata_Plate': 17,
 'Metadata_Well': 3,
 'Metadata_Site': 1,
 'FileName_IllumAGP': 30,
 'FileName_IllumDNA': 30,
 'FileName_IllumER': 29,
 'FileName_IllumMito': 31,
 'FileName_IllumRNA': 30,
 'FileName_OrigAGP': 47,
 'FileName_OrigDNA': 47,
 'FileName_OrigER': 47,
 'FileName_OrigMito': 47,
 'FileName_OrigRNA': 47,
 'PathName_IllumAGP': 107,
 'PathName_IllumDNA': 107,
 'PathName_IllumER': 107,
 'PathName_IllumMito': 107,
 'PathName_IllumRNA': 107,
 'PathName_OrigAGP': 109,
 'PathName_OrigDNA': 109,
 'PathName_OrigER': 109,
 'PathName_OrigMito': 109,
 'PathName_OrigRNA': 109}

I sorted it out by ignoring the metadata introduced by R. See !fc3107d for details. Hopefully it won't add much overhead. This solution does not mean that we can't also fix it from data-producing side @shntnu. The solution is to avoid providing metadata when saving the files, specifically for columns with long filenames. Let me know if this suffices as a solution and I should close the issue, or if you want to wait until the datasets are updated with the metadata-less verisons.

Let me know if this suffices as a solution and I should close the issue, or if you want to wait until the datasets are updated with the metadata-less verisons.

Certainly please keep going, keeping this fix in mind
Also, please create an issue in https://github.com/jump-cellpainting/datasets-private/ about fixing the parquets


C# - arrays

New folder for C# solutions, starting with array problems

Why your code is formatted like JS? In C# we keep parenthesis in the next line!
Maybe you can keep .editorconfig in C# folder, so VSCode or most likely VS will pick up that for formatting settings.

Why your code is formatted like JS? In C# we keep parenthesis in the next line! Maybe you can keep .editorconfig in C# folder, so VSCode or most likely VS will pick up that for formatting settings.

To be consistent with other languages in the repo. It has the same readability, and cuts out a lot of unnecessary space.
C# convention of starting braces on next line is not a hard and fast rule. What's important is the code is readable and the formatting is consistent.

Thanks @joriguzman ! sorry it's taken so long to review


lolmewnStats end of life

As Lolmewn is not updating the stats anymore could you add statz to this great program.
And as lolmewnStats is not used by autoranks and a few others, its silly to have two stat plugins running at the same time.

@ardentcrest Well, I didn't notice that actually. I will be adding a statz plugin soon then for BlueStats! Currently I'm busy with school work though so it may take a while.

Statz support added


getting error massage

great plugin, man!
I was waiting for something like that. finally desktop audio playback for desktops.
the thing is, I'm using linux and I get the following error:
Unhandled Exception: MissingPluginException(No implementation found for method init on channel flutter_audio_desktop)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:157:7)
which sounds very strange because I saw in your code that you do handle that message
Edit:
encountered right now that: https://github.com/flutter/flutter/issues/62006
maybe good point to start from

oh I think I got it. you wrote "if" instead of "else if"

Yeah! I'll update pub.dev version with new Additions from @MichealReed. These new additions are added by him.


ambient: sidecars captured by ztunnel

Currently we only support sidecars that are not captured. we should explore allowing them to be captured and the implications

not stale

not stale


Roman rubin bugfix latest

I just pushed up my script changes. This branch should be ready to merge with main.

This PR was superseded by #47


fix nil pointer crash

Hi, could you add a little more info to this issue, maybe how it came up or how to reproduce it?
It is not valid to have a Typeface that is not nil and does not have an otf or svg font internally. It seems this is attempting to fix an issue caused by invalid state, and not a situation I'd want to be extensively supporting or testing going forward.

It is not valid to have a Typeface that is not nil and does not have an otf or svg font internally. It seems this is attempting to fix an issue caused by invalid state, and not a situation I'd want to be extensively supporting or testing going forward.

That makes sense, it's definitely bad state from my app.
However I wasn't sure if there were scenarios where you could end up calling hasGlyph without having valid svgFont or opentype loaded yet. In that case returning false, or perhaps better raising a defect could be useful.
But yah if it's not possible to end up in that state by normal usage then it'd not make sense to guard it here.

Hi, could you add a little more info to this issue, maybe how it came up or how to reproduce it?

It's hard to reproduce. I'm using Pixie from two different threads but with different data. It seems like they should be independent of each other. From what code I've seen and the stacktrace I'm not sure how it's possible for them to affect each other so that I can properly isolate them / protect them.
Ideally I'd like to use be able to use pixie to render things from different threads, but I could keep move it to a single thread or put a lock around the usage, etc. However I don't know if there's any shared globals or something that'd lead to this invalid state.
Oddly, with this patch it runs fine for 12+ hours and as far as I can tell Pixie creates the proper glyphs and text renderings every time. Before it was crashing every ~20-30 minutes.
P.S. There's also a chance it's somewhere else in Pixie. I've found that the 2.0 release has cases where it's stacktraces aren't correct. That's fun, and I'll try to reproduce this in a debugger to verify this is the location.

raising a defect could be useful.

I don't really disagree per-se, but there are many ways for a nil deref crash to happen and picking just this specific one and making it a Defect is a bit "why just this one?".
deally I'd like to use be able to use pixie to render things from different threads, but I could keep move it to a single thread or put a lock around the usage, etc. However I don't know if there's any shared globals or something that'd lead to this invalid state.
FYI that this is dangerous and going to cause strange issues if not done carefully. Most objects in Pixie are ref object which cannot be used across threads under almost any circumstances (see the atomic arc discussion).

I've found that the 2.0 release has cases where it's stacktraces aren't correct. That's fun, and I'll try to reproduce this in a debugger to verify this is the location.

If 2.0 has flaky locations I suggest reproducing in 1.6.x. It appears 2.0 has some allocator / memory / destructor issues so I would not be using it production until that is sorted out in a future release.

Ok I dug in with a debugger and figured out that I appear to be getting an empty font object occasionally. That's likely due to threading issues / race conditions in my code or 2.0 shenanigans as you pointed out.
However, it looks like passing an improperly initialized Font object causes Pixie to fail with the same NPE immediately. Having a guard for this scenario would probably help users who use the API incorrectly by accident as it looks innocent enough.
Here's the modified code that segfaults every time:
proc getTypeset*(text: string, font: FontId, box: Box): GlyphArrangement =
  let
    rect = box.scaled()
    wh = rect.wh
    # pf = fontTable[font]
  var pf = Font() # empty font
  let
    arrangement = typeset(@[newSpan(text, pf)], bounds = rect.wh)

Here's the debugger output:
(tyObject_TypefacecolonObjectType___hnGWBKtOaU9ciF2FG6z7raQ) $7 = {
  opentype = NULL
  svgFont = NULL
  filePath = {
    len = 0
    p = NULL
  }
  fallbacks = {
    len = 0
    p = NULL
  }
}

Just making a Font is again not supported. This is why readFont, newFont etc exist, to great objects in valid states. I am not aware of any way to stop Font() from compiling, but that is the only valid solution I can see. I don't think going through the exercise of making every single possible allocation type not segfault in every library is a productive way to spend time.

Just making a Font is again not supported. This is why readFont, newFont etc exist, to create objects in valid states. I am not aware of any way to stop Font() from compiling, but that is the only valid solution I can see.

You could throw an exception if the font's not initialized properly or do the nil check like this PR.

I don't think going through the exercise of making every single possible allocation type not segfault in every library is a productive way to spend time.

Well personally I'd disagree and prefer to detect cases where it's easy to misuse an external API. Especially for new users, it's easy to do var font = Font() by accident, forgetting, or not reading the docs or fail to understand why it's bad. But it's your library, just adding a suggestion. :)

FYI that this is dangerous and going to cause strange issues if not done carefully. Most objects in Pixie are ref object which cannot be used across threads under almost any circumstances (see the atomic arc discussion).

Yah, I need to make sure these Font objects aren't shared or locked. I pass a FontId around for that reasons, but looks like I forgot this case with the table.

There are at least 15+ locations that would need nil-check-to-Defect code just for Font. Add Image, Path, Typeface, Context etc and its a huge amount of work and maintenance for all future code.
The real deal here is that Nim does not check for nil, instead it just segfaults. This is the root decision it appears to me that you're disagreeing with. There is https://nim-lang.org/docs/segfaults.html to change this behavior. Should work for all code in all libraries with no == nil: raise code littered all over the place.

There are at least 15+ locations that would need nil-check-to-Defect code just for Font. Add Image, Path, Typeface, Context etc and its a huge amount of work and maintenance for all future code.

That's a fair point. I just found this one and can't weigh the overhead for all of the other places. I like to add a font.checkValid() on public facing APIs with similar cases or use a font.fontType() getter proc that'd also check the font. Scattering nil checks all over internally would be a pain! :/

The real deal here is that Nim does not check for nil, instead it just segfaults. This is the root decision it appears to me that you're disagreeing with.

True I'd forgotten about that guy, might be a good idea. My general habit from C++ days is to try and add those nil checks on public API's when I can and still do it since Nim's default is to not catch NPEs. At least Nim produces a stacktrace which usually makes it easy to fix.
And Pixie is fantastic! I get your decisions if it's too much API space, overhead etc. I just like to try and help "harden" certain API's if possible since usually if I run into it, someone else has too.
Thanks again for the fantastic library! Probably can close this issue?

I am very open to the argument that, unless -d:danger is specified, Nim should be doing nil checks and raising NilDefect instead of segfaulting so I feel you on the pain here. Not a choice that can be changed now though and it isn't a choice without trade-offs anyway.
I am not eager to go through all of Pixie and add nil checks. It's not like it would be a bad idea, its just not a way I would personally enjoy spending time when I have other things I'd rather be doing that are far more interesting. I get that it could improve the lib for new users, but in the end, one does need to learn how to use a library correctly in order to do anything productively with it anyway, and the nil issue will just surface in other places so I'm not confident it would be a significant net win across the net of a project using Pixie. Hard to say, and in the end, its mostly down to being uninteresting work to do.
I am not 100% sure we don't have a bug here, re: the original issue. Only have what has been reported to go on. I would say if you can confirm that the issue is either threading-related or an unsupported usage issue that is fixed outside of Pixie, then all is good.

I am not eager to go through all of Pixie and add nil checks. It's not like it would be a bad idea, its just not a way I would personally enjoy spending time when I have other things I'd rather be doing that are far more interesting.

I totally get that! And I wouldn't think it'd be that fruitful either to do the whole thing. Hopefully you didn't take it as my recommendation either. This one case just seemed useful on it's own to me since checking if there's one font or another is gonna be fairly central. And I wasn't sure if it was some deeper issue or not.

I get that it could improve the lib for new users, but in the end, one does need to learn how to use a library correctly in order to do anything productively with it anyway, and the nil issue will just surface in other places so I'm not confident it would be a significant net win across the net of a project using Pixie. Hard to say, and in the end, its mostly down to being uninteresting work to do.

Definitely, that makes sense. I mean having it in the GitHub project history is useful too if others do something similar.

I am not 100% sure we don't have a bug here, re: the original issue. Only have what has been reported to go on. I would say if you can confirm that the issue is either threading-related or an unsupported usage issue that is fixed outside of Pixie, then all is good.

Yah, I can confirm the issue in my code arose from a threading issue where an "empty" font object was being returned sometimes. Tracking it down wasn't hard once I understood the font object a bit better. The font itself wasn't nil, which confused me.
I appreciate the conversation and your feedback. It was helpful!


0.30.0 upgrade guide

v0.29.1...v0.30.0
:new: Added:
https://github.com/ramda/ramda/pull/3430: isNotEmpty
https://github.com/ramda/ramda/pull/3441: flow
:boom: Breaking Changes:
https://github.com/ramda/ramda/pull/3388: use === to test for placeholder
:bulb: Changes:
:zap: Performance:
https://github.com/ramda/ramda/pull/3417: R.path and dependents
https://github.com/ramda/ramda/pull/3370: update known array lengths
https://github.com/ramda/ramda/pull/3388: use === to test for placeholder
:clipboard: Documentation:
https://github.com/ramda/ramda/pull/3437: unwind
https://github.com/ramda/ramda/pull/3446: splitWhenever
https://github.com/ramda/ramda/pull/3447: type
:heavy_check_mark:  Testing:
:rocket: Build and internal:
https://github.com/ramda/ramda/pull/3420: update dev dependencies
https://github.com/ramda/ramda/pull/3422: update sanctuary and tests
:star: Miscellaneous:
https://github.com/ramda/ramda/pull/3432: replace let with var

Many thanks to all the contributors supporting this release.
We'd also like to call out to all those who submitted issues or PRs that we've chosen not to include.  It's often easy to forget that the attempts that fail are often just as important to long-term success as those that succeed.  Thank you for all your great work! :fireworks:

missing "upgrade guide" label as referenced in https://github.com/ramda/ramda/blob/master/CHANGELOG.md

missing "upgrade guide" label as referenced in https://github.com/ramda/ramda/blob/master/CHANGELOG.md

ty, label added

Tomorrow I'll have some free time to get the type MRs merged for the new functions:

https://github.com/ramda/types/pull/101
https://github.com/ramda/types/pull/122


Feature/sales invoices

Coverage remained the same at 100.0% when pulling a9cb4792d6dbc3cb19027904770ce3988536904e on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

 Implement /sales_invoices

Coverage decreased (-36.4%) to 63.636% when pulling a8021bccf211f7534126f7d911546f9ca5f66e20 on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage remained the same at 100.0% when pulling b0cbbf85977301100f27c7a077dc2042d94fbfb9 on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage remained the same at 100.0% when pulling d4610dc8297f4f56bd546e7b36f43c739764fc0e on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage decreased (-17.9%) to 82.143% when pulling d4610dc8297f4f56bd546e7b36f43c739764fc0e on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage decreased (-15.7%) to 84.259% when pulling 127d631ee6a76b1fbf7946274673880041640edb on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage decreased (-18.6%) to 81.364% when pulling 2ce73e194ddd74996a7ae8ce4e32afd78b8f6f7e on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage decreased (-18.6%) to 81.364% when pulling 83d0100af74db129f152a0d7083acf2f5655fae8 on feature/sales_invoices into<PHONE_NUMBER>0d8a69a5f34694a4f90eca6d102256 on master.

Coverage decreased (-18.03%) to 81.967% when pulling d4640541ae58d87801cdfc05b57110c2c81d64aa on feature/sales_invoices into a6075fb8aae709fed1a3c4b1bf4f16ce60e2ba78 on master.

Coverage decreased (-19.3%) to 80.695% when pulling 8f0fb35feb0198e538071fbadfee1b606ff0f044 on feature/sales_invoices into a6075fb8aae709fed1a3c4b1bf4f16ce60e2ba78 on master.

Coverage decreased (-16.2%) to 83.824% when pulling c35aa370fcf30b69cda5883168bac4552f4eed58 on feature/sales_invoices into a6075fb8aae709fed1a3c4b1bf4f16ce60e2ba78 on master.


Don't initialise to all-zeros.

Don't initialise to all-zeros
See https://doc.rust-lang.org/std/mem/union.MaybeUninit.html#initializing-an-array-element-by-element

Just for completeness:
Before PR #92, the code allocated an uninitialised buffer using Vec::with_capacity followed by vec.set_len.
PR #92 changes the approach to using alloc::alloc to allocate an aligned uninitialised buffer.


Fix/toml config

Seems like allowed_failures should be in the config file. Without it running the binary app gives me:
Failed to deserialize config file. Error: missing field `allowed_failures`

Oh yeah. My local config file is fine, but I haven't updated the one in the repo for a while. I need to take out the Team City stuff, too...


OPS Expressions

same as #722
Had to recreate it so that I could work on fixing it on my own fork

Codecov Report

Merging #760 into master will decrease coverage by <.01%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   88.97%   88.97%   -0.01%
==========================================
  Files         101      104       +3
  Lines       10098    10130      +32
  Branches     2037     2043       +6
==========================================
+ Hits         8985     9013      +28
- Misses        858      863       +5
+ Partials      255      254       -1

Impacted Files
Coverage Δ

devito/ops/node_factory.py
100% <100%> (ø)

devito/ir/equations/equation.py
91.34% <100%> (ø)
:arrow_up:

devito/ops/utils.py
100% <100%> (ø)

devito/yask/operator.py
92.8% <100%> (-0.82%)
:arrow_down:

devito/ops/transformer.py
100% <100%> (ø)

devito/ir/iet/utils.py
87.17% <100%> (+3.57%)
:arrow_up:

devito/ops/operator.py
71.42% <33.33%> (-28.58%)
:arrow_down:

devito/yask/dle.py
32.35% <0%> (-5.89%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db3db9a...268f71c. Read the comment docs.

all good, merging. Many thanks to the contributors


Extract formula for A045917: From Goldbach problem

The program for A045917 appears to use a recurrence relation using the sigma function (A00005):
https://github.com/loda-lang/loda-programs/blob/main/oeis/045/A045917.asm
It would be nice to convert this program into a recurrence relation and add it to the OEIS page:
https://oeis.org/A045917
It looks like it does not include any formula using sigma.

Update:

It makes sense to focus on https://oeis.org/A002375 instead of A045917. It differs only in the first term.
The use of sigma is actually a primality test and can be easily replaced using A010051.
There are more related sequences. It would be great to get a recurrence relation for A002375 similar to the one we use for A000041 (with the difference that we use is-prime instead of sigma)

It looks like the recurrence is not as easy as in A41. The problem is that the inner loop not only depends on k, but also on n.
from sympy import isprime

def f(n):
    a = [0] * (n + 3) # reserving memory
    a[2] = 1
    if n <= 2:
        return a[n]
    k = 0
    print("=======================")
    for k in range(3, n+1):
        m = n - k + 1
        sum = 0
        x = int(k / m) # TODO: avoid floor
        for j in range(x):
            f = k - (j * m)
            p = 1 if isprime(f) else 0
            sum = sum + (p * a[j + 2])
        a[k] = sum
        print(k, a[k])
    return a[k]

def A045917(n):
    return f(2 * n)

r = []
for n in range(0,30):
    r.append(A045917(n))

c = [0, 1, 1, 1, 2, 1, 2, 2, 2, 2, 3, 3, 3, 2, 3, 2, 4, 4, 2, 3, 4, 3, 4, 5, 4, 3, 5, 3, 4, 6]

print(r)
print(c)

if r != c:
    raise ValueError


Handle scenario where DC name is not FQDN

Hold off on this. We might actually need to flag this as an issue.

Bad dnsHostName not only breaks SetupAssist, but setup as well. Added a separate test for this, even though it's tied to the RODC logic:
[08/05/2021 08:53:32.0240] [2] [ERROR] StartIndex cannot be less than zero.
Parameter name: startIndex
[08/05/2021 08:53:32.0240] [2] [WARNING] An unexpected error has occurred and a Watson dump is being generated: StartIndex cannot be less than zero.
Parameter name: startIndex
[08/05/2021 08:53:45.0881] [1] The following 1 error(s) occurred during task execution:
[08/05/2021 08:53:45.0881] [1] 0.  ErrorRecord: StartIndex cannot be less than zero.
Parameter name: startIndex
[08/05/2021 08:53:45.0881] [1] 0.  ErrorRecord: System.ArgumentOutOfRangeException: StartIndex cannot be less than zero.
Parameter name: startIndex
   at System.String.Remove(Int32 startIndex, Int32 count)
   at Microsoft.Exchange.Management.Tasks.DirectoryCommon.IsRODCType(String DnsHostName)
   at Microsoft.Exchange.Management.Tasks.InitializeDomainPermissions.InternalProcessRecord()
   at Microsoft.Exchange.Configuration.Tasks.Task.<ProcessRecord>b__91_1()
   at Microsoft.Exchange.Configuration.Tasks.Task.InvokeRetryableFunc(String funcName, Action func, Boolean terminatePipelineIfFailed)
   at Microsoft.Exchange.Configuration.Tasks.Task.ProcessTaskStage(TaskStage taskStage, Action initFunc, Action mainFunc, Action completeFunc)
   at Microsoft.Exchange.Configuration.Tasks.Task.ProcessRecord()
  at System.Management.Automation.CommandProcessor.ProcessRecord()


Update to last released version of nose

s3transfer was relying on an older version of nose in its requirement file that isn't fully compatible with Python 3+. Upgrading to last available release.

Codecov Report

Merging #212 (65ce893) into develop (7019ae7) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
- Coverage    85.50%   85.45%   -0.06%
===========================================
  Files           16       16
  Lines         2767     2722      -45
===========================================
- Hits          2366     2326      -40
+ Misses         401      396       -5

Impacted Files
Coverage Δ

s3transfer/subscribers.py
90.47% <0.00%> (-0.44%)
:arrow_down:

s3transfer/futures.py
95.27% <0.00%> (-0.24%)
:arrow_down:

s3transfer/download.py
95.29% <0.00%> (-0.10%)
:arrow_down:

s3transfer/tasks.py
92.43% <0.00%> (-0.07%)
:arrow_down:

s3transfer/upload.py
96.31% <0.00%> (-0.06%)
:arrow_down:

s3transfer/manager.py
96.74% <0.00%> (-0.05%)
:arrow_down:

s3transfer/processpool.py
99.43% <0.00%> (-0.02%)
:arrow_down:

s3transfer/bandwidth.py
99.33% <0.00%> (-0.01%)
:arrow_down:

s3transfer/utils.py
99.42% <0.00%> (-0.01%)
:arrow_down:

s3transfer/crt.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7019ae7...65ce893. Read the comment docs.


Bug in Configure out-of-tree directory path computation

I think there's a bug in OpenSSL 3.2.0's Configure script that breaks out-of-tree configuration generation when the source tree is "several parent directories" away (and likely in other circumstances) and the source tree's parents to that same depth are not owned by you.
For example, with a freshly checked out copy of the openssl-3.2.0 tag:
~/sandbox/parent/openssl$ git log -n1
commit cf2877791ce7508684109664f467c9e40987692f (HEAD, tag: openssl-3.2.0)

~/sandbox/one/two/three/four/five$ ../../../../../parent/openssl/Configure linux-x86_64
Configuring OpenSSL version 3.2.0 for target linux-x86_64
Using os-specific seed configuration

Failure!  Makefile wasn't produced.
Please read INSTALL.md and associated NOTES-* files.  You may also have to
look over your available compiler tool chain or change your configuration.

mkdir /home/bspencer/sandbox/parent/openssl/../../../../../parent: Permission denied at ../../../../../parent/openssl/Configure line 1916.

I think this is caused by a small mistake in Configure on line 2476 (on the openssl-3.2.0 tag).
I think the $d variable needs to be computed using the original value of $i obtained from the regex match, before $i was recomputed by passing through cleanfile().  Changing this locally seemed to work for many different configuration targets and seems to produce the intended value in $d, although I couldn't be sure (thus I haven't prepared a PR).

I agree with bspencer. https://github.com/openssl/openssl/pull/23482/files#diff-6defafa2caa65304173956e3fbc26b6947c50bc769c08c3da32c1032fa6519d4 solved the problem for me. And I think https://github.com/openssl/openssl/commit/b8e98c34170fad3080d2b053a872719634404d43 did not actually fix the root cause of the problem.

I agree, that does look pretty odd.
Also, there are actually more bugs in there.  For paths that are known to be directories, cleandir should be used rather than cleanfile

Please try #23500

... and apologies for the wait.  For some reason, this went under my radar for a bit.


conflicting documentation on Common Currencies list

https://money2.noojee.dev/creating-a-currency says The Money2 package does not contain a list of Common Currencies however you can also create your own.,
but https://money2.noojee.dev/common-currencies says From version 1.4.0 we ship with a list of common currencies..
This is conflicting. I believe the latter is correct?

Thanks for spotting that.
I've updated the paragraph to reflect that we ship with common currencies and I've updated the documentation to reflect the current list that we support.
Much appreciated.


Update on the status of this gem

@balvig @firewalker06 @tapster - Didn't know how else to reach you, but I wanted to say thanks for the work you've done on this gem, and apologize for not being more responsive to the PRs. @balvig - as of today I brought in the latest commits from your master branch into upstream master. FYI I rebased the changes on top of mine, so you might want to re-create your fork to make clear diffs for future PRs.
The latest gem version, 0.0.7 has the latest changes brought in from @balvig's fork.
I would like to better maintain the gem going forward, and would appreciate your help for future releases!

Closing since this was just a hack to ping all of you :smile:

Great! Thanks! :+1:

A pleasure to help :+1:

@iancanderson awesome! Was wondering what had become of you :sweat_smile:
Thanks again for sharing to begin with, has been a big help :+1:


/etc/sentinel.conf config error!

my docker-compose.yml
version: '3'

services:
  master:
    image: redis:4.0.10-alpine
    hostname: master
    container_name: master
    network_mode: 'redis_sentinel_net'

  slave_1:
    image: redis:4.0.10-alpine
    hostname: slave_1
    container_name: slave_1
    network_mode: 'redis_sentinel_net'

  slave_2:
    image: redis:4.0.10-alpine
    hostname: slave_2
    container_name: slave_2
    network_mode: 'redis_sentinel_net'

  sentinel_1:
    image: s7anley/redis-sentinel-docker:4.0.10
    hostname: sentinel_1
    container_name: sentinel_1
    network_mode: 'redis_sentinel_net'
    ports:
      - 26379:26379
    environment:
      - MASTER_NAME=mymaster
      - QUORUM=2
      - MASTER=master
      - SLAVES=slave_1;slave_2
    depends_on:
      - master

  sentinel_2:
    image: s7anley/redis-sentinel-docker:4.0.10
    hostname: sentinel_2
    container_name: sentinel_2
    network_mode: 'redis_sentinel_net'
    ports:
      - 26380:26379
    environment:
      - MASTER_NAME=mymaster
      - QUORUM=2
      - MASTER=master
      - SLAVES=slave_1;slave_2
    depends_on:
      - master

  sentinel_3:
    image: s7anley/redis-sentinel-docker:4.0.10
    hostname: sentinel_3
    container_name: sentinel_3
    network_mode: 'redis_sentinel_net'
    ports:
      - 26381:26379
    environment:
      - MASTER_NAME=mymaster
      - QUORUM=2
      - MASTER=master
      - SLAVES=slave_1;slave_2
    depends_on:
      - master

Hi @xjzrc, thank you for pointing out this issue.
I vaguely remember that the usage of SLAVES was added, because of ECS. I need to investigate a little bit more. I see you .

Use-case for SLAVES is when you Redis instances aren't accessible in single network e.g. in ECS it was not possible to use the IP address of slave, because they were pointing to internal IP address allocated by docker on the single machine, not in the whole cluster.


Manual addon install has led to inability to install additional addons. Also, how to reset?

I tried to install an addon manually; there was no indication it succeeded or failed. The addon does not appear in available addons and if I attempt to install from zip the system now errors, saying xyz.zip already exists. If I manually remove that file, another error is presented. I forget what, though. I think it could be something like xyz.zip is not found.
In an attempt to work around the xyz issue I tried resetting the application to defaults. First by removing the server from TVML, then TVML from my AppleTV and thirdly by restarting my NAS, yet my settings persist. Where are they stored? How do I completely reset the service?

Sorry for the delay.
Just release version 0.6 with a lot of fixes.
Also, there's now a section in the menu for clearing application settings. (FYI, they are stored on the client - i.e. the appleTV).
I fixed a major problem I had with leaking file descriptors which had a lot of side effects.
Please let me know if your problems are still happening in the new release.

Version 0.7 now saves all settings/config/history locally on the server.
Reset can be made via the gui (i.e. the app itself) or by deleting the ~/.TVMLSERVER directory.
Also adding repositories from zip file is fixed in 0.7.
Please reopen if problems persist.


Release 0.11 ?

@crawler-commons/committers, shall we release 0.11 after merging #235 (address #219)?

Have merged #235
+1 to release 0.11

+1 to a release.
What about calling this 1.0? I don't think there's any major functionality that's missing from the original goal, yes?
And other than #197 I don't see any major architectural changes being proposed.

+1  With support for video/image/etc. extensions the sitemap parser can now be called complete and #197 will not change the API.

will do the release over the week-end

@jnioche thanks!

We've released 1.0 instead.


Remove the charset parameter from the application/x-www-form-urlencoded MIME type

Fixes #327

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #328   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         422    422
  Branches      133    133
=====================================
  Hits          422    422

Impacted Files
Coverage Δ

src/body.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c1ef8...5c1ce67. Read the comment docs.

Closing this PR as the Fetch spec requires the presence of charset parameter.


Not able to install pybamm on pycharm

PyBaMM Version
pybamm 0.2
Python Version
python 3
Describe the bug
Error during installation of the package
import wheel.bdist_wheel as orig
ModuleNotFoundError: No module named 'wheel'
[end of output]
Steps to Reproduce
no idea
Relevant log output
No response

pip install wheel should work. Also, you should install the latest version of PyBaMM, that is 22.7.

This is the error im facing. Wheel got installed. When i try installing Pybamm again, i got he error the below.
ERROR: Cannot install pybamm==0.1.0, pybamm==0.2.0, pybamm==0.2.1, pybamm==0.2.2, pybamm==0.2.2.post1, pybamm==0.2.2.post2, pybamm==0.2.2.post3, pybamm==0.2.3, pybamm==0.2.3.post1, pybamm==0.2.4, pybamm==0.2.4.post1, pybamm==0.2.4.post2 and pybamm==0.2.4.post3 because these package versions have conflicting dependencies.

Can you try pip install pybamm==22.7 (preferably in a virtual environment with wheel already installed)? Also, please paste the command executed by you along with the complete error.

(venv) PS S:\Python-PyCharm\Pybamm> python --version
Python 3.10.6
(venv) PS S:\Python-PyCharm\Pybamm> pip install wheel
Requirement already satisfied: wheel in s:\python-pycharm\pybamm\venv\lib\site-packages (0.37.1)
(venv) PS S:\Python-PyCharm\Pybamm> pip install pybamm==22.7
ERROR: Ignored the following versions that require a different python version: 0.3.0 Requires-Python >=3.6,<3.9; 0.3.0.post1 Requires-Python >=3.6,<3.9; 0.3.0b0 Requires-Python >=
3.6,<3.9; 0.4.0 Requires-Python >=3.6,<3.10; 21.10 Requires-Python >=3.7,<3.10; 21.11 Requires-Python >=3.7,<3.10; 21.12 Requires-Python >=3.7,<3.10; 21.8.post1 Requires-Python >=
3.6,<3.10; 21.8.post2 Requires-Python >=3.6,<3.10; 21.9 Requires-Python >=3.7,<3.10; 22.1 Requires-Python >=3.7,<3.10; 22.2 Requires-Python >=3.7,<3.10; 22.3 Requires-Python >=3.7,<3.10; 22.4 Requires-Python >=3.7,<3.10; 22.5 Requires-Python >=3.7,<3.10; 22.6 Requires-Python >=3.7,<3.10; 22.7 Requires-Python >=3.7,<3.10; 22.8 Requires-Python >=3.7,<3.10
ERROR: Could not find a version that satisfies the requirement pybamm==22.7 (from versions: 0.1.0, 0.2.0, 0.2.1, 0.2.2, 0.2.2.post1, 0.2.2.post2, 0.2.2.post3, 0.2.3, 0.2.3.post1, 0.2.4, 0.2.4.post1, 0.2.4.post2, 0.2.4.post3)
ERROR: No matching distribution found for pybamm==22.7

We don't support Python 3.10 right now. PyBaMM 22.8 should work with Python 3.9!

Thank you.


feat(defi providers): add callbacks to event handlers

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Testing

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2293

PR #2294
PR #2323

PR #2295
PR #2324

PR #2296
PR #2325   👈

PR #2297

PR #2298

This comment was auto-generated by Graphite.


CONNECT_TIMEOUT env variable and --connect_timeout option was added. Fatal Error during tests fixed

There was an error with the tests execution.
PHP Fatal error:  Class PhpBrew\Tasks\MakeTaskTestBuild contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpBrew\Buildable::isBuildable) in /home/travis/build/phpbrew/phpbrew/tests/PhpBrew/Tasks/MakeTaskTest.php on line 70

I've fixed it.

Changes Unknown when pulling 6ad18bf5b8cf613ae1270f29df664efa0087fa44 on vasiliy-pdk:error_during_tests_fix into ** on phpbrew:develop**.

Thanks!