Update getdns, stubby

Motivation for this change
https://getdnsapi.net/releases/getdns-1-6-0/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

ping @leenaars

LGTM!


[web] Re-organize web unit tests

Our web unit tests have gotten pretty complicated with a lot of special casing. I made a proposal for re-organizing our tests into suites, which makes things more explicit and organized.

This is done.


std is included even in no_std environments.

I am trying to write a piece of code targeting the x86_64 ABI using a custom target, which means there's no std available for my build target so I am building with #[no_std]. It seems that even with the std flag disabled, the package still tries to pull an std package into the build. The following is the build error:
$ xargo build --release --target=raw
   Compiling pkg-config v0.3.9
   Compiling libc v0.2.36
   Compiling rlibc v1.0.0
   Compiling compiler_builtins v0.1.0 (https://github.com/rust-lang-nursery/compiler-builtins#0ba07e49)
error[E0463]: can't find crate for `std`
  |
  = note: the `raw` target may not be installed

error: aborting due to previous error

Note I am not actually doing anything with the package yet, if I remove it from my dependencies the build succeeds and no std is ever built.
My environment:
Cargo.toml
# ...
[dependencies.sodiumoxide]
version = "*"
default-features = false
features=[]

raw.json
  {
    "pre-link-args"                    : ["-m64", "-nostdlib", "-static"],
    "dynamic-linking"                  : false,
    "relocation-model"                 : "pic",
    "no-compiler-rt"                   : true,
    "no-default-libraries"             : true,
    "position-independent-executables" : false,
    "llvm-target"                      : "x86_64-unknown-none",
    "data-layout"                      : "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
    "linker-flavor"                    : "gcc",
    "target-endian"                    : "little",
    "target-pointer-width"             : "64",
    "target-c-int-width"               : "32",
    "arch"                             : "x86_64",
    "os"                               : "none",
    "disable-redzone"                  : true,
    "features"                         : "+avx,+mmx,+sse",
    "panic-strategy"                   : "abort"
  }

Please see #203

Seemingly we don't have a #![no_std] in https://github.com/sodiumoxide/sodiumoxide/blob/master/libsodium-sys/lib.rs

Note: this looks like a useful pattern.

Okay, so libsodium-sys cannot build without std because bindgen requires std. So hypothetically if libsodium-sys gets built on a system with std and then used on a system without std, then sodiumoxide can be updated and rebuilt without std. And for that matter any project that uses libsodium-sys or sodiumoxide could also rebuild on top of an already-built libsodium-sys without needing std. Not sure how useful this actually would be in any real-world scenarios.
Also, after a little more review it seems pretty clear that the crate currently cannot run with no_std. In addition to the implementing the pattern above by including an unconditionally compiled #![no_std] at the root, we can also use xargo to actually test our build runs in a real std-less environment in Travis. Adding a matrix build something like:
    - env: TARGET=thumbv7em-none-eabi
      script:
        - cargo build --no-default-features --target $TARGET
        - xargo test --no-default-features --target $TARGET
      install:
        - cargo install xargo || true
        - rustup target install armv7-unknown-linux-gnueabihf
        - rustup component add rust-src

Finally we gotta document it, and just in case it's useful we might provide instructions on how to build for no_std environments and re-compile on top of the existing built code as I explained is hypothetically possible above.

Also it is possible to make libsodium-sys a no_std crate:
diff --git a/libsodium-sys/build.rs b/libsodium-sys/build.rs
index ffa332d..e1c7c91 100644
--- a/libsodium-sys/build.rs
+++ b/libsodium-sys/build.rs
@@ -16,6 +16,8 @@ fn main() {

     let bindings = bindgen::Builder::default()
         .header("sodium_wrapper.h")
+        .ctypes_prefix("libc")
+        .use_core()
         .whitelist_function("(sodium|crypto|randombytes)_.*")
         .whitelist_type("(sodium|crypto|randombytes)_.*")
         .whitelist_var("(sodium|crypto|randombytes)_.*")
diff --git a/libsodium-sys/src/lib.rs b/libsodium-sys/src/lib.rs
index ef1ad8c..7eadcf5 100644
--- a/libsodium-sys/src/lib.rs
+++ b/libsodium-sys/src/lib.rs
@@ -1,5 +1,9 @@
+#![no_std]
+
 #![allow(non_upper_case_globals)]
 #![allow(non_camel_case_types)]
 #![allow(non_snake_case)]

+extern crate libc;

See https://github.com/rust-lang-nursery/rust-bindgen/issues/1439

One of the solutions is to hardcode the version of sodium_bindings.rs, and get rid of bindgen and use pkgconfig only in libsodium-dev:feature=std.

@Reisen Hello. Would you please test it again?
cd sodiumoxide
git pull
git checkout static_bindings
# unset SODIUM* variables

And use this(guide) https://github.com/maidsafe/rust_sodium#cross-compiling-for-arm ? Or you may try to use xargo. Any info would help.

@kpp Hey, I had actually switched to another library at the time since opening this ticket, but I do have the commits lying around. I will give it a shot this weekend and try and see if I can get this working.

Possibly fixed in https://github.com/sodiumoxide/sodiumoxide/pull/448. Feel free to file a new issue if I am wrong.

Possibly fixed in https://github.com/sodiumoxide/sodiumoxide/pull/448. Feel free to file a new issue if I am wrong.

In master:
cargo nono check --no-default-features
sodiumoxide: SUCCESS
ed25519: SUCCESS
libc: SUCCESS
libsodium-sys: SUCCESS

In master:
cargo nono check --no-default-features
sodiumoxide: SUCCESS
ed25519: SUCCESS
libc: SUCCESS
libsodium-sys: SUCCESS


Allow adding extra transforms to output

I keep hitting this roadblock using Snabbt, not sure if it's an issue or I'm just missing something.
Problem: if you use CSS transforms that a) you don't want to animate (eg: for positioning), and b) can't be added to Snabbt (eg: percentage offsets) Snabbt clobbers them with it's matrix declaration.
Possible Solution: allow the user to mix in in extra transforms with Snabbt's matrix transform, ie: result could be transform: matrix(...) translateY(-50%) or whatever.
An easy fix for this could be adding a new optional property onto Snabbt, something like staticTransforms: that just takes a string which is appended onto the end of the matrix transform.

Hmm, interesting. I didn't know it was possible to mix matrix-transform and other(translate/rotate etc.)
It can definitely be added.
The thing is I'm doing kind of a big refactoring of snabbt, moving to es6 with browserify and a lot of tests so I will focus on that branch now.
But if you make a pull request to master I could merge it and make a release. I will add it to the new branch but it will not be released in at least a week,

okay awesome. I'm super busy myself at the moment, but I'll see if I can get a quick PR together.

Hi again,
This is now available in the latest release. It's undocumented at the moment as I want to try it a bit before settling on the exact syntax.
Use it as follows:
snabbt(element, {
  position: [100, 0, 0],
  staticTransform: 'translateX(50%)'
});

Let me know how it works out for you


create transpiler html => FastDomNode, for describe in html templates

https://github.com/RyuuGan/html2FastDom


support TCP traffic in test framework

@yxue: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test lint_istio

unit-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test lint_istio

unit-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test lint_istio

unit-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test lint_istio

unit-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-distroless-k8s-tests_istio

lint_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-distroless-k8s-tests_istio

lint_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test lint_istio

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
428675fbecb9d55113faad98c245f563ac02db09
link
/test integ-distroless-k8s-tests_istio

lint_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test lint_istio

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test lint_istio

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test lint_istio

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-security-k8s-tests_istio

lint_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

integ-security-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-security-k8s-tests_istio

lint_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test lint_istio

integ-distroless-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-local-tests_istio

integ-security-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-security-k8s-tests_istio

lint_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test lint_istio

integ-distroless-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
1bc53ab9c13d99a47bfcb9595bcbe8ece35ba39e
link
/test integ-security-k8s-tests_istio

lint_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test lint_istio

integ-distroless-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test lint_istio

integ-distroless-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-local-tests_istio

integ-security-k8s-tests_istio
f516e74c58837857d47df8b0cff270d5939ee50b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Working on tests

@istio/wg-security-maintainers @istio/wg-networking-maintainers @istio/wg-test-and-release-maintainers the PR is ready for review. Thanks!

ping @istio/wg-security-maintainers @istio/wg-networking-maintainers @istio/wg-test-and-release-maintainers PTAL, thanks!

@yxue: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4ba96b30c3ea16a2f4d5094cd76e4cd565da96ed
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@yxue: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1a13cf73a6e7b55318067d2ba8fcb1494ece7b8b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1a13cf73a6e7b55318067d2ba8fcb1494ece7b8b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1a13cf73a6e7b55318067d2ba8fcb1494ece7b8b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yxue: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1a13cf73a6e7b55318067d2ba8fcb1494ece7b8b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
1a13cf73a6e7b55318067d2ba8fcb1494ece7b8b
link
/test integ-local-tests_istio

unit-tests_istio
ae9889399bdc5493033ddc41b9c5d604f99f9b58
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Bug 2177589: Sort Preferences in Add volume modal

📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2177589
Sort the preferences names in Preference field/drop down, in Add volume to boot from modal alphabetically, no matter where the modal is accessible from.
Move sorting of InstanceTypes names alphabetically to the modal component, too.
Also remove forgotten loaded prop from the component AddBootableVolumeButton and from the places where the component is used.
🎥 Screenshots
Before:
Preferences names not sorted in the modal, in Bootable volumes list:

After:
Preferences names sorted alphabetically:

/retest

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review


[D&D 3.5] Add three critic calculation mode

Changes / Comments
Add three critic calculation mode
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Verify size of float32 and float64 in configuration

We're defining and using float32 and float64 in src/axom/core/Types.hpp.  We should also check that these are actually 32-bits and 64-bits, respectively.

@gunney1 can this issue be closed now that we are using standard library types?


Open Link in New Tab : open pools in new tab

Adding html tags to pools so users could right click and "Open link in New Tab", or command-click to open new tabs

Thanks Aris. Such a good use case (I'm consistently opening new tabs). This will help users not have to backtrace as they're browsing new pool stats/consider LP'ing

Open many pools at the same time with a right-click to Open Link in New Tap Yay!!


setInterfaceImplementer should fail if implemented with 165

The function setInterfaceImplementer should fail if the interface is currently implemented as a ERC165 interface.
This is for backward compatibility. And also it is an implementation detail with how 820 cache currently works.

@fulldecent thanks for the issue. This was actually closed in 225041f707c83cb976ce8c314762ac8ff783ead1.


bert for inpainting?

why does inpaint training use bert encoder?

ah the inpainting code hasn't been updated yet. Will fix it soon

ah the inpainting code hasn't been updated yet. Will fix it soon

Thanks, I'm really excited to train the inpainting one 😃


implement some syntactical suger by adding a beforeSave attribute.

Bookshelf.Model.extend({
    beforeSave: ['dooFoo', 'doBar'],
});

which under the hood would just do
_.each(this.beforeSave, function(method) {
  this.on('saving', this.method.bind(this));
}, this);

I think this would add a nice declarative layer to this tool.

We have currently removed all Backbone references from the docs, and we're trying to move away from that paradigm, and this is very much something that will be familiar to Backbone users, so the chances of it getting implemented are very small.
@rhys-vdw Thoughts?

:cry: At the time I think it would have been nice, but now it makes sense to :skull:

Well, you can always create a "Make-Bookshelf-Like-Backbone-Again" plugin with this kind of stuff, since the needed functionality is all in place :)


centos7.9 ，cmake version 3.7.2 ，cmake error

/home/mmccadmin/freeswitch/src/mod/asr_tts/mod_audio_stream/audio_streamer_glue.cpp:202:12: error: ‘cJSON_IsString’ was not declared in this scope; did you mean ‘cJSON_String’?
202 | if(cJSON_IsString(partial)) {
| ^~~~~~~~~~~~~~
| cJSON_String
make[2]: *** [CMakeFiles/mod_audio_stream.dir/build.make:90: CMakeFiles/mod_audio_stream.dir/audio_streamer_glue.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/mod_audio_stream.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Do I need to update the cmake version to 3.18?

When I updated cmake to version 3.18, make still had an error：
cmake -version
cmake version 3.18.0
/usr/local/src/mod_audio_stream/audio_streamer_glue.cpp: In function ‘switch_bool_t {anonymous}::filter_json_string(switch_core_session_t*, const char*)’:
/usr/local/src/mod_audio_stream/audio_streamer_glue.cpp:288:34: error: 'cJSON_IsString' has not been declared in this scope
if(cJSON_IsString(part)) {
^
make[2]: *** [CMakeFiles/mod_audio_stream.dir/build.make:95: CMakeFiles/mod_audio_stream.dir/audio_streamer_glue.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:115: CMakeFiles/mod_audio_stream.dir/all] Error 2
make: ***[Makefile:149:all] Error 2

Freeswitch version must be 1.10.x? The lower version of switch_json.h does not define cJSON_IsString

已处理


[global] sharding deployment

We must control which security domains can be deploy across multiple servers

Duplicate of https://github.com/gravitee-io/graviteeio-access-management/issues/86


Add properties to existing resource

Add a button to edit forms which should enable adding arbitrary properties to a resource.

Which requires nested forms #24

This is possible now


[Bug]: Two component files resolving to the same name  (Nuxt 4)

Reproduction
Sorry, tried but can't get StackBlitz or CodeSandbox working.
Describe the bug
Even with TypeScript installed as a dependency, with Nuxt 4, getting this error.
This was resolved before with Nuxt 3 versions by installing TypeScript.
Reproduction:
I am sorry I wasn't able to add a reproduction. If someone can share, it'd be much appreciated.
Use Nuxt 4, add Shadcn-vue, pnpm dev.
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor
    Memory: 9.54 GB / 31.93 GB
  Binaries:
    Node: 20.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.10.0 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Chromium (128.0.2739.42)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    @vueuse/core: ^11.0.3 => 11.0.3
    nuxt: 3.13.1 => 3.13.1
    radix-vue: ^1.9.5 => 1.9.5
    shadcn-nuxt: ^0.10.4 => 0.10.4
    vue: ^3.5.4 => 3.5.5

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

Of course just after 5 minutes of posting the question, I find the answer. :D
Fix:
  shadcn: {
    prefix: "",
    componentDir: "./app/components/ui",  // Change to new directory
  },

Change your componentDir to new components directory, It was componentDir: "./components/ui" before.
Just an FYI: I had to change some of my imports that are outside of the "app" folder because now @ or ~ not points to "app" not "/".

Thank you @onurusluca ! I was facing the same problem, I didn't realized that @ do not work here.

What did you to about the /libs/utils.ts containing the cn function? Did you figure out how to move that into the new app directory?

@onurusluca is the add command adding components into the right folder for you? have you changed anything in the .nuxt/tsconfig.json file?

@onurusluca is the add command adding components into the right folder for you? have you changed anything in the .nuxt/tsconfig.json file or no?

I don't think I changed anything no. Check parent folders. Once I was surprised to find out components folder was created in the folder that has the parent of the project. Something like C:/Codes//projects/my-project.

What did you to about the /libs/utils.ts containing the cn function? Did you figure out how to move that into the new app directory?

Just change the libs directory to where you put the file. Same as the answers to this post.


TopologyLayer import error

Hi there,
Thank you for providing the codebase.
I am currently testing without using Poetry to understand how the topology layer works.
However, the following error occurs when importing the "torch_persistent_homology" used to import the "TopologyLayer".
Is there a way to solve the error below or a calculation file of Python version instead of C++ in "torch_person_homology"?

Hi! This is a great idea—we could provide a Python-based implementation but currently lack the resources to implement this.


Transclusion Enhancments

This PR implements 2 things:

Transcluded block signature to id.
Link in embedded section for header and block transclusion.

Done the changes based on the review. :smile:


Non-retina text rendering is bad

There's a rule, presumably down in Electron, that is setting -webkit-font-smoothing: antialiased for x-screen. Perhaps I'm extra sensitive to this, but this looks absolutely terrible on non-retina screens. When I toggle that rule in the inspector everything looks great. Personally I think that also looks better on a retina screen. It might be worth considering enforcing subpixel-antialiasing (IMO always, but could be on a media query for < 2 pixel density), or eventually some setting even.

@zpao +1000. I've been seeing some screenshots from non-retina that have wanted to make me cry.

I actually think antialiasing looks bad on Retina too. Compare screens below.

The non antialiased one has clearer colours and more legible typography imo (might only be me). The antialiased text looks a bit weak: the black from the background sort of bleeds into the glyphs. Compare with iTerm:

@johanbrook I agree. I've lost the "just use subpixel-antialiasing all the time" argument too many times though so I hedged my bets 😛

In case anybody else comes across this and it's not "fixed" the way you want, you can use ~/.hyperterm.js to override.
    termCSS: `
      x-screen {
        -webkit-font-smoothing: subpixel-antialiased !important;
      }
    `,

Hey all. I noticed this same issue at work today after customizing the fonts in my hyperterm config. My fonts looked great on my laptop's retina display, but looked kinda 💩 on my external monitor. I played around in the devtools and can confirm the above fix worked out for me.
Anyway, here's a hyperterm theme I made that adds subpixel-antialiased font smoothing: https://github.com/ali/hyperterm-subpixel-antialiased

People without retina displays will have to use this package: https://github.com/ali/hyperterm-subpixel-antialiased

Even on a retina display this default looks awful on macOS

-webkit-font-smoothing: subpixel-antialiased !important; hack does not seem to work on Hyper 2.
Any suggestions?

Hyper 2 uses https://github.com/xtermjs/xterm.js instead of hterm like we did previously. @kompot I'd recommend you to go over there and search through the issues 👍
🚨warning in the upcoming 3.0 release of xterm, they will change to rendering on webgl/canvas, don't know how font smoothing is handled in there. Hyper will adopt it in the future when it's released. I think VS Code is already testing this code so if you want to try how it will be in the future you could test it there.

@kompot

-webkit-font-smoothing: subpixel-antialiased !important; hack does not seem to work on Hyper 2.

Setting body { -webkit-backface-visibility: unset; } seems to do the trick for me.
The backface-visibility change was added in #1602 to work around some cases where Blink would enable/disable subpixel antialiasing due to animations (#1490). Unfortunately, it does this is by breaking subpixel antialiasing.

Unfortunately doesn't seem to change much on macOS.
Here are three windows. Top is hyper, terminal.app in the middle, vs code on the bottom 3rd.
Hyper's font rendering produces thin and unpleasant lines ;( * i know some people prefer that, yes, but could not find a way to get rendering like in terminal.app or iTerm2 *

Same problem here, too. Looks fine on the built-in retina display of the MacBook; unusable with an external non-retina monitor. Any suggestions?

https://github.com/bgw/dotfiles/commit/25bb078f5154cbdf6e13333399d0da0591c9e665
This fix does not work for me. I am on version 2 on OSX 10.12.6
Anyone know of a fix?

Can you try setting fontWeight to 100 or lighter, it should accept any valid css-font-weight value 👍

None of the above things worked for me. Type this in the command line and reboot. This setting also stays between reboots.
defaults write -g CGFontRenderingFontSmoothingDisabled -bool NO

None of the above things worked for me. Type this in the command line and reboot. This setting also stays between reboots.
defaults write -g CGFontRenderingFontSmoothingDisabled -bool NO

Here is the actual problem explained: https://ahmadawais.com/fix-macos-mojave-font-rendering-issue/
Now fonts look smoother, but another problem appears after rebooting - gaps between glyphs:

To edit the font smoothing setting at application-level and not system-wide,
here's the trick:
defaults write co.zeit.hyper CGFontRenderingFontSmoothingDisabled 0
defaults write co.zeit.hyper.helper CGFontRenderingFontSmoothingDisabled 0
defaults write co.zeit.hyper.helper.EH CGFontRenderingFontSmoothingDisabled 0
defaults write co.zeit.hyper.helper.NP CGFontRenderingFontSmoothingDisabled 0


reactjs/redux#2004 List features beyond ES6 supported by create-react-app

We actually support (at current time) ES2017 (unofficially ES8; ES6 (official) is ES2015), which is the latest version of JavaScript.

@jonathanconway The links to es2015 parameters and object spread are the same, is that intentional?

Thanks! I added some more info.


Clarify definition of aeon:organizer

Organizer - An organizer of an academic event or event series.
The definition should clarify if aeon:organizer includes persons and/or organisations.

The definition you pasted here is not the one stated in the recent AEON version:

definition
An organizer is a contributer that holds an organizing role which is being realized in a planned process.
elucidation
A person or organization that is responsible for the planning and realization of a planned process.

You took the definition of the ConfIDent schema, which is not as precise yet. Any improvementtips for this need to be filed in its repo under https://github.com/TIBHannover/ConfIDent_schema/issues, please.


sendTransaction with simple sends

functions still missing from transfers are:

retrieve_near to transfer money from your evm account back to your near account
move_funds_to_near_account to send funds to evm account corresponding to known near address

Would need to think about if eth.sendTransaction will accommodate these and what parameters would signal this action

@emaG3m I am not familiar with the ethereum part, but this error
Contract Interaction beforeAll error: LinkError: Wasm contract link error: 2 link errors: (1 of 2) Import not found, namespace: env, name: validator_stake (2 of 2) Import not found, namespace: env, name: validator_total_stake

means that your nearcore version is outdated.

The logic for this looks fine. I'm getting errors when running the tests though. It looks like it mostly has to do with providing an undefined address. This might be due to changes with nearcore or some of the transaction calls are passing through when they shouldn't.
Have you updated nearcore recently?

@barbaraliau I last updated nearcore a day or two ago. Are you getting the errors bowenwang mentioned in his comment on this PR 5 days ago?? if so, it needs to be updated, if not, lmk if you want me to look into it!

@emaG3m Can you update and see if you're getting different errors? Here are a few errors I'm getting:
---- PROVIDER ---- ›
---- CONTRACT INTERACTION ---- › getBalance | eth_getBalance › returns balance

    {}

      692 |                 if (to != ZERO_ADDRESS && to == from) {
      693 |                     // Add near to corresponding evm account
    > 694 |                     outcome = await this.account.functionCall(
          |                               ^
      695 |                         this.evm_contract,
      696 |                         'add_near',
      697 |                         {},

      at Object.parseRpcError (node_modules/near-api-js/lib/utils/rpc_errors.js:38:19)
      at JsonRpcProvider.sendJsonRpc (node_modules/near-api-js/lib/providers/json-rpc-provider.js:120:40)
      at Account.signAndSendTransaction (node_modules/near-api-js/lib/account.js:97:22)
      at NearProvider.routeEthSendTransaction (src/index.js:694:31)

---- PROVIDER ---- ›
---- CONTRACT INTERACTION ---- › sendTransaction | eth_sendTransaction › sends the correct balance when deploying code

    Provided address "undefined" is invalid, the capitalization checksum test failed, or its an indrect IBAN address which can't be converted.

      305 |             test('sends the correct balance when deploying code', withWeb3(async (web) => {
      306 |                 // zombieAddress deployed with val 10 in beforeAll
    > 307 |                 const balance = await web.eth.getBalance(
          |                                               ^
      308 |                     zombieAddress,
      309 |                     'latest'
      310 |                 );

      at Method.inputAddressFormatter (node_modules/web3-core-helpers/src/formatters.js:471:11)
      at node_modules/web3-core-method/src/index.js:148:38
          at Array.map (<anonymous>)
      at Method.formatInput (node_modules/web3-core-method/src/index.js:146:32)
      at Method.toPayload (node_modules/web3-core-method/src/index.js:181:23)
      at Eth.getBalance (node_modules/web3-core-method/src/index.js:599:30)
      at fn (test/near_provider.test.js:307:47)
      at Object.<anonymous> (test/near_provider.test.js:43:18)

@emaG3m Can you update and see if you're getting different errors? Here are a few errors I'm getting:
---- PROVIDER ---- ›
---- CONTRACT INTERACTION ---- › getBalance | eth_getBalance › returns balance

    {}

      692 |                 if (to != ZERO_ADDRESS && to == from) {
      693 |                     // Add near to corresponding evm account
    > 694 |                     outcome = await this.account.functionCall(
          |                               ^
      695 |                         this.evm_contract,
      696 |                         'add_near',
      697 |                         {},

      at Object.parseRpcError (node_modules/near-api-js/lib/utils/rpc_errors.js:38:19)
      at JsonRpcProvider.sendJsonRpc (node_modules/near-api-js/lib/providers/json-rpc-provider.js:120:40)
      at Account.signAndSendTransaction (node_modules/near-api-js/lib/account.js:97:22)
      at NearProvider.routeEthSendTransaction (src/index.js:694:31)

---- PROVIDER ---- ›
---- CONTRACT INTERACTION ---- › sendTransaction | eth_sendTransaction › sends the correct balance when deploying code

    Provided address "undefined" is invalid, the capitalization checksum test failed, or its an indrect IBAN address which can't be converted.

      305 |             test('sends the correct balance when deploying code', withWeb3(async (web) => {
      306 |                 // zombieAddress deployed with val 10 in beforeAll
    > 307 |                 const balance = await web.eth.getBalance(
          |                                               ^
      308 |                     zombieAddress,
      309 |                     'latest'
      310 |                 );

      at Method.inputAddressFormatter (node_modules/web3-core-helpers/src/formatters.js:471:11)
      at node_modules/web3-core-method/src/index.js:148:38
          at Array.map (<anonymous>)
      at Method.formatInput (node_modules/web3-core-method/src/index.js:146:32)
      at Method.toPayload (node_modules/web3-core-method/src/index.js:181:23)
      at Eth.getBalance (node_modules/web3-core-method/src/index.js:599:30)
      at fn (test/near_provider.test.js:307:47)
      at Object.<anonymous> (test/near_provider.test.js:43:18)

@barbaraliau I'm getting these same errors from our master branch here, so I'm not sure it has to do with the PR. Not sure if you can confirm.
@bowenwang1996 when running tests against nearcore master branch we get these errors. On the stable branch everything is fine. Is this something we should be worrying about?

@emaG3m I misunderstood what you were saying and thought by 'stable', you meant 'master'. I have been on nearcore master for a while. Should I change that to be on the stable branch?

@emaG3m I misunderstood what you were saying and thought by 'stable', you meant 'master'. I have been on nearcore master for a while. Should I change that to be on the stable branch?

I think so, but @bowenwang1996 can confirm for sure. Also hoping we don't need to be concerned if all our stuff breaks on their master nearcore branch.

Yeah master is less stable. I think for evm it makes sense to use released versions instead of master.

Tests are passing with nearcore stable branch and current near-evm wasm code.


Unique levels, smoothing, and QuantileEncoder

The test ./tests/test_encoders.py::TestEncoders::test_unique_column_is_not_predictive fails for QuantileEncoder.  That new supervised encoder wasn't added to this test.
My cursory understanding is that the other supervised encoders smooth things so that unique levels just get encoded with the prior.  Is that really desired in general?  It seems like a clunky exception, but if it is desired, can/should QuantileEncoder be adapted to do the same (@cmougan)?
Discovered while trying to refactor the test to use a supervised-encoder tagging, #326

Is that really desired in general?

That's a good question. I've read trough the target-encoder paper and there is no hard rule saying single-value categories should be assigned the prior. This was also raised by another user in #275
Usually the algorithms build some average of the category mean and the prior weighted by the size of the category and a regularisation parameter. In case of a single category column we'd need to ensure that the regularisation parameter puts enough weight on the prior to not overfit. However, the default regularisation parameters we have set in the target encoder are just too low.
In my opinion the better option would be to change the defaults there. However this might break some users code if they rely on the default staying the same. Proper way would be maybe to introduce future warnings

Hi @bmreiniger! Long time no see.
About unique levels of a category. It's something that depends on the regularization.
There are several types of regularization: leave-one-out, exponential smoothing, Gaussian noise...
Quantile Encoder uses m-estimate (also known as additive smoothing)
It's the most basic one (and for me the most intuitive). Unique levels of a category get handled with the M parameter.

Which regularization technique es best? I have never seen a research study benchmarking them
Should we encode unique elements with the prior? I don't have anything in favor nor anything against it. The safest way to do it is to benchmark regularization techniques in scenarios where individual levels of a category are present

Eventually, in my imaginary world.
The user should be able to choose the desired regularizator as a parameter.
This will actually unify some of the current encoding methods : Target Encoder, M-estimator, Catboost, LeaveOneOut

To me, the line between a categorical level with just one observation or two is not so big; I wouldn't much trust the two-observation level either.  So I would prefer not to have such a discontinuous treatment, especially hard-coded and out of reach of users.  In the way of letting users control it, maybe having a parameter for minimum level size (what I originally thought min_samples_leaf was supposed to do) would be appropriate.
I'd be happily in favor of higher regularization values by default, with a future warning for a few releases if that's required.
I like Carlos's idea of generalizing regularization methods for many of the supervised encoders, for the long term.  I worry about exploding the number of parameters though; maybe something like a separate regularizer class that gets passed as a parameter?  That would basically leave just target, WOE, and quantile as the encoders, with m-estimate, minimum level size, catboost, LOO, James Stein, glmm as regularizers for them?

Benchmarking regularization in target encodings is not done to the best of my knowledge.  It's actually a non-trivial experiment.  I don't have a good answer on how to handle levels with just one observation besides common regularization.
Also, from an error and practical perspective. In a healthy dataset, if you have just one instance in train, there should be low chances that you have it in test. How much does this affect the error? Or we care about how the algorithm is constructed? Open question.
For default hyperparameters, I am doing some experiments for a paper, let me see if I get some results that we can use. Still, further experimentation is needed (might lead to a research paper)
For unifying supervised encoders, it might be good to sketch some diagrams to visualize the merge. A release like that might affect many users, and there are a fraction of users that won't understand the merge. @PaulWestenthanner what do you think?

@bmreiniger, during a recent paper (https://arxiv.org/pdf/2201.11358.pdf) we study the impact of regularization in target encoding (see Figure 2).
I was surprised to see that, for this particular case, regularization does not imply an improvement in model performance or is very minimal. (other datasets will be different).

From a technical point I agree with @bmreiniger that making a hard cut between once-observed labels and twice (or more often) observed labels does not make too much sense. So we should increase the default values for regularisation.
From a point of releasing those I'd first include some future warning to all encoders where default parameters will change and only the release after actually change it. Also we should introduce a changelog / release overview / what's new page.
About unifying supervised encoders: I agree we'd need a sketch first and only then decide. I think from a user's point of view it is more explicit to have all target encoders separate rather than just having one with a lot of functionality. If there are many keyword arguments specific to a particular encoder it makes more sense to keep them separate. From a coding point of view it's obviously nice to unify things. However that change would be rather big. Maybe for some version 3.x?

Hi guys,
I'm planning to do a release shortly and add the FutureWarnings for those who use the default parameters at the moment. As for new default parameters I just did some analysis:

This plot shows the value of lambda as given in the paper plotted for n_samples from 1 to 100 for different k (=min_samples_leaf) and f (=smoothing). Based on this broad parameter range I've plotted one in greater detail: k=20, f=10

I would suggest k=20 and f=10 as new default parameters
This gives

95% global mean for n=1
75% global mean for n=10
50% global mean for n=20
75% specific mean for n=30
almost all specific mean for n>50

Obviously these are hyper-parameters that need to be tuned according to the specific problem at hand but I guess the scores I give above are a good default.
Does anyone disagree?
For completeness sake I'll add the code
from matplotlib import pyplot as plt
%matplotlib inline
import numpy as np

def lambda_coef(n, min_samples_leaf, smoothing):
    return 1 / (1 + np.exp(-(n - min_samples_leaf) / smoothing))

min_samples = [1,3,5,8,13,21,34,55]
smoothing_params = [2**x for x in range(0,7)]

fig, axes = plt.subplots(len(min_samples), len(smoothing_params), figsize=(25,25))
x_axis = range(1, 100)
for idx1, min_s in enumerate(min_samples):
    for idx2, smoothing in enumerate(smoothing_params):
        y_axis = [lambda_coef(n, min_s, smoothing) for n in x_axis]
        title = title=f"k={min_s};f={smoothing}"
        axes[idx1, idx2].plot(x_axis, y_axis)
        axes[idx1, idx2].set_title(title)
``

Hi @PaulWestenthanner!
Very interesting :)
Should not this depend on the used estimator?
What happens if you apply this approach to the other regularizers? M-estimate and Gaussian Noise?
These default hyperparameters won't apply to all encoding methods, will they?

Hi,
yes the best values will depend on the used estimator. The thing we're discussing in this issue is that the default values for smoothing and min_samples_leaf are just selected very poorly.
The workflow should always include optimising the hyper-parameters of the encoders, but the encoder should start with a sensible default anyway. This is not the case at the moment as the analysis above shows.
This analyis is for the TargetEncoder only. A similar analysis should be done for M-estimate and other variations of target encoding

Hi @PaulWestenthanner,
If the regularization hyperparameter depends on the estimator and on the dataset used. Why this analysis is supposed to improve the default hyperparameters for Target Encoder?
What am I missing here?

That's because the new defaults might be bad for some encoders but the current ones are bad for pretty much all encoders.
The current behaviour is that if a category occurs only twice (or with correct implementation only once) then the encoder leans heavily towards the category average. This will lead to overfitting. Also if people start hyper-parameter optimisation they should start from sensible defaults rather than defaults that are probably pretty bad for any model

For example "I would suggest k=20 and f=10 as new default parameters" why not k=10 and f=20?

I chose it because I think the values for lambda make sense

I would suggest k=20 and f=10 as new default parameters
This gives
95% global mean for n=1
75% global mean for n=10
50% global mean for n=20
75% specific mean for n=30
almost all specific mean for n>50

This is basically just my gut feeling saying that 50 data points is enough to trust the label.
If you compare it to k=10, f=20 as you suggest you get a much flatter S-shaped curve with these stats:

40% specific mean for n=1
50% specific mean for n=20
70% specific mean for n=30
90% specific mean for n=50

This is much more likely to overfit since a unique level is weighed with 40% of its specific mean and also on the other end of the spectrum if a level occurs 50 times I'd be quite happy to give more than 90%. So that's why I like k=20, f=10 better than k=10, f=20.
For reference the current defaults k=1, f=1 give those statistics:

50% specific mean for n=1
90% specific mean for n=3
99% specific mean for n>7

I hope my argumentation makes sense for you even though it is not based on strict science but is rather a heuristic on what seems to make sense and provide a good starting point for hyperparameter optimisation


Fix: sort index.html items to make folder listed before

Found that the index.html items list mixed between folders and files.
We need to let folders listed before files. This fix it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 28 (89.29%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 81.967%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

charon/pkgs/indexing.py
25
28
89.29%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
1150

Relevant Lines:
1403

💛  - Coveralls

This is a very small change, so merged with checks passed.


Generator: run api gen in the cloud

Is your feature request related to a problem? Please describe.
The primary issue is that more often than not devs forget to generate the API docs. To address this the API generation command was added to the watcher when in development.
This is still not 100% reliable.
Describe the solution you'd like
Move the generation of the API doc to the cloud using Semantic Release Git. It appears by adding the API doc to the assets part of the config, this will get committed back to the repo with the updated package.json and changelog file.

Update to remove bundler from the pre-commit and only generate the bundled version in the cloud https://github.com/AlaskaAirlines/auro-skeleton/commit/779bb6735a8374d7d0ca9afa45d975ac59c3145b
WIll need to run npm run bundler locally for testing.


Multi GPU Support

Hello team, I have a setup with 4XA10 (24Gb) GPUs and I was wondering is there a way to train a 13B llama model on this. I get CUDA OOM when training the model, although all 4 GPUs are used
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.86.05              Driver Version: 535.86.05    CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A10G                    Off | 00000000:00:1B.0 Off |                    0 |
|  0%   42C    P0             262W / 300W |  20680MiB / 23028MiB |    100%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A10G                    Off | 00000000:00:1C.0 Off |                    0 |
|  0%   43C    P0             265W / 300W |  20680MiB / 23028MiB |    100%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   2  NVIDIA A10G                    Off | 00000000:00:1D.0 Off |                    0 |
|  0%   42C    P0             260W / 300W |  20680MiB / 23028MiB |    100%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   3  NVIDIA A10G                    Off | 00000000:00:1E.0 Off |                    0 |
|  0%   41C    P0             280W / 300W |  20680MiB / 23028MiB |    100%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A     68283      C   /root/miniconda3/envs/ml/bin/python       20668MiB |
|    1   N/A  N/A     68284      C   /root/miniconda3/envs/ml/bin/python       20668MiB |
|    2   N/A  N/A     68285      C   /root/miniconda3/envs/ml/bin/python       20668MiB |
|    3   N/A  N/A     68286      C   /root/miniconda3/envs/ml/bin/python       20668MiB |
+---------------------------------------------------------------------------------------+

I suspect that the model is loaded on all 4 GPUs independently, is there a way to shard the model across the 4 GPUs?
the command I am running is this
autotrain llm --train --data_path . --project_name 'temp' --train_split train --valid_split valid --seed 42 --use_int4 --use_peft --train_batch_size 1 --model NousResearch/Nous-Hermes-Llama2-13b --learning_rate 2e-3 --num_train_epochs 3 --model_max_length 4096 --push_to_hub --text_column text  --block_size 4096 --merge_adapter --gradient_accumulation_steps 32

I tried setting up accelerate using accelerate config and tried FSDP FULL SHARD and deepspeed as well but I am not sure if it was loaded correctly since when I tries these approaches only 1 GPU gets loaded and the logs dont seem to show that model is training.

I would like to ask, without GPU, can LLAMA-2-13b be fine-tuned on the CPU server, and do I need to modify the source code


posOp is not typesafe any more in 4.7.0

With kmongo 4.7.0 I now get compile errors using the posOp operator:
Type mismatch: inferred type is User but CapturedType(out Any?) was expected

It does work if I switch to the new % operator introduced via https://github.com/Litote/kmongo/issues/357, but should that be required for posOp? I think it should be possible for posOp to be typesafe, as this is not the same case as https://github.com/Litote/kmongo/issues/276.

Could you provide an example? Because this test looks good: https://github.com/Litote/kmongo/blob/323e4e87f970fdd2cba603a0df927f7043808c27/kmongo-property/src/test/kotlin/org/litote/kmongo/property/KPropertyPathTest.kt#L64

Sorry for the late reply. Try this:
data class FriendWrapper(val friend: Friend)

// now this fails to compile
FriendWrapper::friend / Friend::allGifts.posOp

This works: (FriendWrapper::friend / Friend::allGifts).posOp
HTH


Export data as CSV

Closes #2
Result: https://docs.google.com/spreadsheets/d/1f7qgmmXpgd4tF5SQY7f7wvHen9vAzskyfKU7oYe2rYA/edit?usp=sharing

@all-contributors please add @brianstrauch for his great contributions to the code, design, and ideas.


Add support for TS 5.5 ${configDir} template variable

Feature request
TS 5.5 support ${configDir} template variable. See here.
import { parseTsconfig } from "get-tsconfig";
const tsconfig = parseTsconfig('/path/to/tsconfig.json');
console.log(tsconfig.compileOptions.outDir) // if there is `${configDir}` template variable in `outDir`, the output result is incorrect in TS 5.5

Motivations
To support TS 5.5 ${configDir} template variable.
Alternatives
No response
Additional context
No response
Bugs are expected to be fixed by those affected by it

[ ] I'm interested in working on this issue

Compensating engineering work financially will speed up resolution

[ ] I'm willing to offer financial support

@privatenumber I'd like to create a PR for ${configDir} support, but I can't get existing test cases to pass after upgrading to TS 5.5 (it seems that there is a behavior change with --showConfig). You might wanna take a look at that first.

Yeah the tests need to be updated when you upgrade typescript. I'm not sure when I'll get around to this right now.

Yeah the tests need to be updated when you upgrade typescript. I'm not sure when I'll get around to this right now.

It seems that the latest tsc --showConfig now prints explicit config instead of the original config, hence the extra fields.

Yep, it's a good thing. get-tsconfig should match this behavior and build-in this logic.

Yep, it's a good thing. get-tsconfig should match this behavior and build-in this logic.

Though tsc --showConfig now makes the "hidden" default more explicit, I am not sure whether the get-tsconfig should do the same, this looks like a breaking change to me.

Before, it was up to the consumer of get-tsconfig's output to determine what configs are implicitly enabled, but now get-tsconfig does it for you. In terms of behavior, there's no breaking change, but there is a breaking change in terms of API output. I don't mind doing a major release for this.

RE: https://github.com/dominikg/tsconfck/issues/183
I'm quite occupied with work these days but if it's a priority, I'm happy to support you to get this in.
For now, we can upgrade TypeScript and suppress the extra output. Would you be willing to open a PR?

Sounds good!

:tada: This issue has been resolved in version 4.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@privatenumber You might want to re-open this issue. #83 only fixes the test cases are doesn't actually implement the ${configDir} feature.

See https://github.com/privatenumber/get-tsconfig/commit/eba85380401a64b6cc3ff8e639fa2391da41c2d2

See eba8538

Oh I miss that!

doesn't work for me :(

rootDir defined as follows in a parent tsconfig:
"rootDir": "${configDir}/src",

This is a closed issue, please open another one.
Looks like I missed rootDirs and others (declarationDir, typeRoots, baseUrl). Feel free to open a PR


Users SBAT read the correct number of elected validators in Celostats

Expected Behavior
Reflect the correct number of elected validators in ethstats
Current Behavior
Number of elected validators in ethstats is wrong

Fixed


#44

@kellyhutchins please review

@driskull  looks good - thanks for adding this one.

no problem


Add a section at the top for JWT claims using admin center

Recommend adding a note at the top of this document to let customers know they can set up optional claims (JWT) in the enterprise application. https://learn.microsoft.com/en-us/entra/identity-platform/jwt-claims-customization
Having a customer modifying a manifest of an app registration should not be practice. Plus any synced directory extensions will never show up here.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b4a177db-c714-599f-9091-b1e97506cd49
Version Independent ID: 2bbfd6ca-1032-6afb-49bd-9dba40aa2513
Content: Configure optional claims - Microsoft identity platform
Content Source: docs/identity-platform/optional-claims.md
Service: identity-platform
GitHub Login: @cilwerner
Microsoft Alias: cwerner

@ruaden94
Thanks for your feedback! We will investigate and update as appropriate.

@ruaden94
Thank you for bringing this to our attention.
I've delegated this to content author @cilwerner, who will review it and offer their insightful opinions.

We are in the process of transferring to a new unified user feedback system. This issue is being triaged and added to the backlog where it will be addressed in an upcoming sprint.


Avatar presence

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Support for presence status in AvatarView.
Presence states:

Available
Busy
Away
Out of offline
Do not disturb
Blocked
Unknown
Offline

Added option to keep presence border opaque, or make it transparent using CALayer masks.
Validation

Tested VoiceOver on device, make sure that the accessibility label is correct with/without presence status
Tested all AvatarView configurations for dark mode/light mode
Tested 2 border styles with presence

Before:

After:

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[x] VoiceOver and Keyboard Accessibility
[x] Internationalization and Right to Left layouts
[x] Different resolutions (1x, 2x, 3x)
[x] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

sorry i didn't catch this earlier but square style is for groups like teams/sharepoint groups not person so it doesn't make sense to have presence badge next to it. i think it sets a bad precedence if we let that happen or show it in demo app ...

sorry i didn't catch this earlier but square style is for groups like teams/sharepoint groups not person so it doesn't make sense to have presence badge next to it. i think it sets a bad precedence if we let that happen or show it in demo app ...

I agree, I'll remove this from the demo app.

sorry i didn't catch this earlier but square style is for groups like teams/sharepoint groups not person so it doesn't make sense to have presence badge next to it. i think it sets a bad precedence if we let that happen or show it in demo app ...

I agree, I'll remove this from the demo app.
could we also check in the avatar.swift to not show presence if squarestyle?

Sorry, just saw this comment.
I’ll update the logic to prevent from showing presence in the square style.
From: Harrie Shin<EMAIL_ADDRESS>Date: Wednesday, July 29, 2020 at 10:03 PM
To: microsoft/fluentui-apple<EMAIL_ADDRESS>Cc: Mathieu Kavalec<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/fluentui-apple] Avatar presence (#144)
sorry i didn't catch this earlier but square style is for groups like teams/sharepoint groups not person so it doesn't make sense to have presence badge next to it. i think it sets a bad precedence if we let that happen or show it in demo app ...
I agree, I'll remove this from the demo app.
could we also check in the avatar.swift to not show presence if squarestyle?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Ffluentui-apple%2Fpull%2F144%23issuecomment-666114455&data=02|01||b5d39217e9924799433008d83445f72c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637316822383486259&sdata=3Ha43dYBUgqO%2B2H%2B5j4iGwU75etA05rzAT9S%2BdQrah0%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA75YGVP75W7YMA6VDAW3QDR6D5LZANCNFSM4PL7G23Q&data=02|01||b5d39217e9924799433008d83445f72c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637316822383496236&sdata=l2P7KdhwqVqEFZDQ8dv4JLO7uoCeCePl4Yc7dv9AIHk%3D&reserved=0.


Feature Request: Add a localization system

It would be very nice if you could set the language of the app to anything different than English.
Crates that could be used:

Gettext
Fluent

I could contribute to a German translation if this gets implemented.

Druid already provides a system for localisation but we don't use it and we're most likely won't implement localisation until after migration to Xilem.

Ah ok, thanks for clarifying!

Druid already provides a system for localisation but we don't use it and we most likely won't implement localisation until after migration to Xilem.

Uh, any progress at all?

Druid already provides a system for localisation but we don't use it and we most likely won't implement localisation until after migration to Xilem.

Uh, any progress at all?

There will ve a status update if anything changes. Currently there are no plans to implement this.


Upgrade Tfm to netcoreapp2.2

netcoreapp2.1 -> netcoreapp2.2
Also moved around tfm ordering since VS for Mac supports custom SDKs.

@dotnet-bot test windows release x64 build


WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #8308 (a968603) into main (35709dc) will increase coverage by 0%.
The diff coverage is 80%.

:exclamation: Current head a968603 differs from pull request most recent head e5caa37. Consider uploading reports for the commit e5caa37 to get more accurate results

@@          Coverage Diff          @@
##            main   #8308   +/-   ##
=====================================
  Coverage     72%     72%
=====================================
  Files        371     371
  Lines      23075   23168   +93
  Branches    3512    3539   +27
=====================================
+ Hits       16649   16721   +72
- Misses      4985    5000   +15
- Partials    1441    1447    +6

Impacted Files
Coverage Δ

...rc/client/common/process/pythonExecutionFactory.ts
79% <ø> (ø)

...ce/raw-kernel/liveshare/hostRawNotebookProvider.ts
76% <ø> (ø)

.../datascience/notebook/notebookControllerManager.ts
73% <25%> (-2%)
:arrow_down:

...client/datascience/kernel-launcher/jupyterPaths.ts
70% <58%> (+2%)
:arrow_up:

...t/datascience/kernel-launcher/localKernelFinder.ts
82% <71%> (-1%)
:arrow_down:

src/client/logging/trace.ts
82% <85%> (+4%)
:arrow_up:

src/client/api/pythonApi.ts
70% <100%> (+1%)
:arrow_up:

src/client/common/installer/productInstaller.ts
62% <100%> (+<1%)
:arrow_up:

src/client/common/process/processFactory.ts
90% <100%> (+<1%)
:arrow_up:

src/client/common/utils/decorators.ts
78% <100%> (ø)

... and 31 more


Update tests namespace to be \Darling\PHPUnitTestUtilities\Tests.

Update tests namespace to be \Darling\PHPUnitTestUtilities\Tests
This will make it clearer what test classes are defined by this library when it is used by another library.
Note: This may change is not compatible with older versions of the PHPUnitTestUtilities library.
Libraries that use the PHPUnitTestUtilities will need to update uses of the tests namespace that refernce test classes defined by the PHPUnitTestUtilities library to instead use the namespace \Darling\PHPUnitTestUtilities\Tests

Resolved in commit  884fefb2f403d1d3542ca819723b00dfc04d8eb0


proposal: x/crypto/blake2b: support arbitrary length digests

Blake2b supports digests between 1-64 bytes, but the blake2b library only exposes three of the standard digest sizes. Ideally, the library would support an arbitrary digest size between 1 and 64.
It looks like the logic is already there in the newDigest function. It's just a matter of exposing it.

The problem is that users may use too short hash values. The package tries to achieve a security level of at least 128 bit. See also RFC 7693
However I'm currently working on #19896 which requires arbitrary digest sizes.
In general I would recommend the XOF (blake2x) construction if arbitrary digest sizes are required.

The package tries to achieve a security level of at least 128 bit. See also RFC 7693

Ah! That's why you didn't include id-blake2b160.

In general I would recommend the XOF (blake2x) construction if arbitrary digest sizes are required.

Agreed. For a little context here: I was writing a golang implementation of libsodium's sealed box. It's the same as NaCl's sealed box except it specifies the creation of the nonce as 24-byte-blake2b-mac(pubkey1 CONCAT pubkey2).

Ah! That's why you didn't include id-blake2b160.

Correct.

Agreed. For a little context here: I was writing a golang implementation of libsodium's sealed box. It's the same as NaCl's sealed box except it specifies the creation of the nonce as 24-byte-blake2b-mac(pubkey1 CONCAT pubkey2).

That sounds like a use case for a XOF like BLAKE2x, SHA3 / SHAKE or Kangaroo 12.

Too-short hash values may have legitimate use-cases, like birthday paradox proof-of-work where hash collisions are what you're trying to find, e.g. equihash. If you're aiming for a very short proof-of-work period, you need a very short hash. The XOF doc says "Note that an ℓ smaller or equal than 64 is acceptable, there’s just no reason to use it since BLAKE2b already provides hashes of 64 bytes or less". From that comment, it seems to me that arbitrary length BLAKE2b was intended.

@sporkmonger
I'm not saying there are no use cases for short hash values - like 64 bit. There are many applications for example preventing hash-flooding attacks. However a collision based proof-of-work could be implemented by truncating a larger hash or just considering only a specific number of bits - that would make the difficulty adjustable...

The XOF doc says "Note that an ℓ smaller or equal than 64 is acceptable, there’s just no reason to use it since BLAKE2b already provides hashes of 64 bytes or less". From that comment, it seems to me that arbitrary length BLAKE2b was intended.

Sure, the problem is that users may use a too short hash to achieve collision resistance. However the BLAKE2b package will support arbitrary hash sizes because of Argon2.

Fixed with #19896 - Can be closed.

Thanks!


Add Wikipedia, Steam and KeePassDX icons

Before:

After:

I deleted my fork so i can't edit this PR now, oops
Here's the new one


Fix blocked input after window is closed #12

Derive from Microsoft.VisualStudio.PlatformUI.DialogWindow instead of System.Windows.Window.
Also reenabled auto-save. Does not work like expected (no projects are actually saved) - maybe someone can help?
2017 compiles and works fine, could not test others.

Just inheriting from DialogWindow solves this problem?

Opening the window via ShowModal() (a method of DialogWindow) instead of ShowDialog() does the trick.


Missing comma in test results in unexpected string concatenation

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): NA
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): NA
TensorFlow installed from (source or binary): NA
TensorFlow version (use command below): NA
Python version: NA
Bazel version (if compiling from source): NA
GPU model and memory: NA
Exact command to reproduce: NA

Describe the problem.
Absent comma results in unwatned string concatenation on line 330:
https://github.com/tensorflow/tensorflow/blob/0d8705c82c64dfb39c49e346de1a66182e5eabd1/tensorflow/python/keras/engine/training_generator_test.py#L330-L336
So 'matmul' gets appended with 'Yaks are also quite nice' resulting in matmulYaks are also quite nice being used in the test.
Describe the current behavior.
'matmulYaks are also quite nice' is used in the test
Describe the expected behavior.
'matmul', 'Yaks are also quite nice' is used in the test
Contributing.

Do you want to contribute a PR? (yes/no): yes
Briefly describe your candidate solution(if contributing):

Add the missing comma
Standalone code to reproduce the issue.
NA
Source code / logs.
NA

Would you like to create a PR for the same

Could you please create the PR in github.com/keras-team/keras repo as per the above linked PR.

this is now fixed upstream


Redesign async client

No automatic merge possible due to changes to the master in the meantime!

The compilation issues are an easy fix. I will prepare a PR into the redesign branch.

It compiles again but I'm not able to test this atm.

Since I have no test sketch for the async parts, the only thing I could offer is to deploy it to some of my smart home devices and see if it behaves.
Some day I might add an async test sketch...


Update image column in banner admin interface

Should say media and include either the image link or the video link

Done!


ghc-modi

getting this error msg when I open a haskell src file:
'ghc-modi' could not be spawned. Is it installed and on your path? If so please open an issue on the package spawning the process.
ghc-modi is installed and is in the current path.

As mentioned in the error message:

please open an issue on the package spawning the process.

Open an issue here: https://github.com/lierdakil/haskell-ghc-mod

oops


Update slack api endpoints to remove depreciated channels.* methods

Slack has depreciated all of the channels.* methods to migrate to the conversation ones.
https://api.slack.com/methods/channels.history
https://api.slack.com/methods/channels.join
https://api.slack.com/methods/channels.list
https://api.slack.com/methods/channels.info
https://api.slack.com/methods/channels.archive
These methods are deprecated. They will stop functioning in February 2021 and will not work with newly created apps after June 10th, 2020.
https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api
https://api.slack.com/methods/conversations.history
https://api.slack.com/methods/conversations.join
https://api.slack.com/methods/conversations.list
https://api.slack.com/methods/conversations.info
https://api.slack.com/methods/conversations.archive

NOTE: that newer slack apps - can not use the post as bot feature from this repo. This means that messages are posted as the user who created/added the app - and not as channel_reaper. While https://github.com/gareth-sharpe/slack-autoarchive makes an attempt at it - the implementation has small issues (mostly because a user auth token is no longer needed at all)

@alexeiser This is sorely needed but without handling pagination (https://api.slack.com/docs/pagination), the implementation of get_all_channels() will be pretty broken I think.  By default, https://slack.com/api/conversations.list returns only the first 100 items (https://api.slack.com/methods/conversations.list).

@alexeiser This is sorely needed but without handling pagination (https://api.slack.com/docs/pagination), the implementation of get_all_channels() will be pretty broken I think. By default, https://slack.com/api/conversations.list returns only the first 100 items (https://api.slack.com/methods/conversations.list).

Agreed - and I borrowed https://github.com/Symantec/slack-autoarchive/pull/42 to use on my branch of this repo.

February 2021 is getting really close... any plans to merge this PR?

February 2021 is getting really close... any plans to merge this PR?


query::algorithms::glk::cast_ray doesn't converge some times

seen when calling time_of_impact using a simple box trimesh as shapes and calculating the collisions between 1 shape and another 200 every frame. it happens after a few seconds running at 60fps.

This is probably due to some floating point innacuracies. Do you have a specific scenario (with the exact objects positions and trajectories) so that I can reproduce the bug?
And by "box trimesh" are you refering to a Cuboid shape or a TriMesh shaped like a box ?

i'm just using randomly positioned boxes of side 2 in a -100, 100 range in x and z, with y=0. then interactively moving another cube around the space in x,z and calling time_of_impact between the interactive shape and everything else.  Some of the randomly positioned cubes might overlap.
I'm using a TriMesh with the shape of a box.
Since then i've moved to using a World object and let it calculate the collisions which works without problem though.


Weifang

added guideline 7

Guideline 8 btw looks ready to go, so if these things are changed then this can be merged into master.


Fix CreateBonds operator window.

Description
Resolves #5658
Use of QString.arg was incorrect, had '%.1' instead of '%1'
Checklist:

[X] I have followed the style guidelines of this project.~~
[X] I have performed a self-review of my own code.~~
- [ ] I have commented my code where applicable.
[X] I have updated the release notes.~~
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
- [ ] I have added any new baselines to the repo.
[X] I have NOT made any changes to protocol or public interfaces in an RC branch.~~
[X] I have assigned reviewers (see VisIt's PR procedures for more information).~~

Here's a link to the generated page.
https://visit-sphinx-github-user-manual.readthedocs.io/en/doc-biagas-add_molecule_plot/gui_manual/Plots/PlotTypes/MoleculePlot.html


Add client button modal

https://issues.jboss.org/browse/AEROGEAR-2155
Screenshots

@maleck13 can you please have a look.

looking

@witmicko needs a rebase which should get rid of the code that I added in my PR

Closing as this is now part of https://github.com/aerogear/origin-web-console/pull/3


Finish implementation of Spaces API

https://github.com/sckott/analogsea/pull/138 added support for part of the Spaces API and we decided in #136 to start a fresh issue to help divvy up the tasks of completing the API. Below is a checklist with items transcribed from the Spaces API docs:

[ ] Bucket Operations

[x] Create a Bucket
[x] List All Buckets
[ ] List a Bucket's Contents
[ ] Delete a Bucket
[ ] Get a Bucket's Location
[ ] Get a Bucket's ACL
[ ] Set a Bucket's ACL
[ ] Get a Bucket's CORS
[ ] Set a Bucket's CORS
[ ] Delete a Bucket's CORS

[ ] Object Operations

[ ] Get an Object
[ ] Get Information About an Object
[ ] Upload an Object (PUT)
[ ] Copy an Object
[ ] Get an Object's ACLs
[ ] Set an Object ACLs
[ ] Delete an Object
[ ] Begin a Multi-part Upload
[ ] Upload a Part
[ ] List Parts
[ ] Complete a Multi-part Upload
[ ] Cancel a Multi-part Upload

Let me know if the organization of this list doesn't make sense or isn't useful for tackling this.

@sckott I more or less copied the list from the API docs. Does having analogsea implement all of these seem appropriate?
@thercast Did you have any preference for which methods you wanted to tackle first? I should be able to take a look at this some evening this week and actually be helpful.

I think it makes sense to include all of them

I sat down to get a lay of this and everything looks very reasonable. I wrote a get_object function to match the Spaces API method GET ${BUCKET}.${REGION}.digitaloceanspaces.com/${OBJECT_KEY} using aws.s3::get_object and immediately noticed that aws.s3 didn't reasonably handle error cases.
See this example with an invalid bucket name, purposely run:
> rawToChar(space_get_object("welcome.html", "test-analogseas"))
[1] "<?xml version=\"1.0\" encoding=\"UTF-8\"?><Error>NoSuchBucket<BucketName>test-analogseas</BucketName><RequestId>tx000000000000002f5f59e-0059ffb7c0-3f970-nyc3a</RequestId><HostId>3f970-nyc3a-nyc</HostId></Error>"

It returns the raw response and throws away the underlying HTTP request's status code so there appears to be no way to know if this is the file I have stored at welcome.html or an error.
Looking at the source I can see why. Looking at the open Issues on the repo, I see that the function isn't really written to handle errors see this issue.
If it's the case that the aws.s3 package doesn't handle errors, I wonder if we (1) care and (2) would rather try to stay with using aws.s3 or use crul to get proper error handling.
Thoughts?

@amoeba thanks for your work on this!  I've been AFK due to illness but I want to jump back in to help out.  I'll add notes on which features I would like to tackle this week.
Regarding the error handling with aws.s3: I struggled with how to handle this in my first implementation.  We have a lot of functionality already built for us within aws.s3, and having that convenience for this early implementation of spaces is hard to pass up.  But showing just the raw response when the request errors out is a real eye sore compared to how the other analogsea functions elegantly handle errors via crul.  From my perspective, I could see the long term path being a re-write of the key functionality using crul to be consistent with the rest of the package and having one less dependency, but I will defer to @sckott for his take.

Thanks for raising the issue with erroring. I definitely value failing well, so I'd strongly prefer to make sure users get useful errors - and DigitalOcean, at least with the Droplet API (and I assume with the spaces API) fails well and correctly making it easy to give users appropriate errors
We currently still use httr in this package. Main thing keeping httr around is that it can do oauth whereas crul cannot, but i think an argument can be made to get rid of oauth if we think most people don't use it but instead use PATs
For now I think it's okay to stick with aws.s3, but eventually i think we should rework to make sure spaces fxns error well

Sounds good, thanks for weighing in @sckott. If/when the aws.s3 package changes how they handle error cases, this package benefits automatically, so I'm down with filling in this portion of the package with aws.s3 as much as possible.
@thercast Sorry to hear you were out! Looking forward to your notes.

any thoughts on this? anything I can help with?

I'm still down to help PR this addition but wanted to let @thercast take lead since it was his idea. Hopefully he'll pop in here and we can get this done soon?

@thercast any thoughts? if you're too busy, anything @amoeba or I can move forward on?

Hi @sckott  and @amoeba, sorry for the delay (an urgent shiny app came up at work and then the kids got sick) but I would like to tackle the listing of bucket contents and deletion of a bucket (these tasks should help shake off the cobwebs of being away for a bit).  @amoeba I'd be glad if you'd like to start on the fundamental operations for objects in a space (i.e. downloading, uploading, deleting).  Does that sound like a good plan?

Sounds good to me!

Filed an upstream issue for Space creation not working https://github.com/cloudyr/aws.s3/issues/199

aws.s3 is getting some fixes as we speak [1] so I'll plan to re-visit some of the existing issues with the Spaces implementation that are waiting on upstream changes this week.
[1] https://github.com/cloudyr/aws.s3/issues/189

Sat down with this a bit yesterday and today and ran into more upstream issues. @leeper added support for non-AWS S3-compatible storages but I'm getting signature mismatch errors no matter what I try now: https://github.com/cloudyr/aws.s3/issues/189. I think I'll wait to see what @leeper says in case this is a quick fix on either my end or aws.s3's.

@amoeba any update on this?

I wish. I'm kinda stuck on https://github.com/cloudyr/aws.s3/issues/189#issuecomment-381448618. Something to do with assumptions in https://github.com/cloudyr/aws.signature about AWS vs. non-AWS endpoints. I feel like I might be able to throw some more brain cells at it (and a fresh look could help) but I'm not yet sure what's going on and why were getting SignatureDoesNotMatch errors.

Okay. So is the only thing not working multipart uploads due to this aws.s3 thing ? If so, can we move on towards a cran submission and just document that?

I think other things aren't working too, like creating a Space. I can't check today but I'll see if I can't take a look tomorrow while traveling. There are enough moving parts here that I don't have a good handle off-hand of what works, what doesn't, what broke, and why.
I'd definitely like to see this get off to CRAN ASAP, maybe by the end of the month.

Bucket creation is definitely not working. I thought we'd found the issue over on https://github.com/cloudyr/aws.s3/issues/189 but that wasn't quite the trick.

Okay, will also take a look soon

hey @amoeba - thinking about this a bit, I played around with trying to fix bucket creation, but go nowhere. Okay with you if we move on with next cran submission with what spaces stuff works for now?  With functions that don't work yet, we could just not export them, or export and document as not working yet, and add a stop() inside them with message?
seems like at least these don't work for me:

create_space
spaces_object_delete

That sounds good to me. Thanks a million for trying to fix the issue.
Releasing a partial implementation of the Spaces API seems useful in its own right if those are the only two functions that aren't working so let's do that. I'll test to see which functions work to see if my list matches yours.
@sckott wrote:

With functions that don't work yet, we could just not export them, or export and document as not working yet, and add a stop() inside them with message?

Do you have a preference here? I'd lean towards not exporting but I'd like to do the least surprising thing.
I'll get to this tonight or tomorrow.

not exporting is probably best, and good to document that they'll come along later

I get the same list of non-working functions. I'll start with the changes now.
Other notes that just came up:

When I ran this I got a non-invisible logical as a return

> spaces_object_put("~/Downloads/test.txt", space = "analogsea-test")
[1] TRUE

This function just returns exactly what aws.s3::put_object returns. When it fails, I think it always throws an exception so could I just wrap it in an invisible()?

spaces_object_copy does a similar thing:

> spaces_object_copy("test.txt", "test2.txt", "analogsea-test", "analogsea-test")
$LastModified
[1] "2018-06-12T04:45:49.357Z"

$ETag
[1] "00f7d50ab4278a7899d7499481c9603a"

attr(,"x-amz-request-id")
[1] "tx0000000000000076436a6-005b1f4ffd-8abd1d-nyc3a"
attr(,"content-type")
[1] "application/xml"
attr(,"content-length")
[1] "183"
attr(,"date")
[1] "Tue, 12 Jun 2018 04:45:49 GMT"
attr(,"strict-transport-security")
[1] "max-age=15552000; includeSubDomains; preload"

Would it also be better to invisble() this (and also eventually provide a proper class for the response?). This also applies to spaces_object_head(),

I just checked droplet_create() and it returns non-invisibly so maybe I should just follow that.

Cool, thanks for the PR. If nothing else on this for now. i'll push to cran in the next few days. i'll see if any problems pop up in checking before then

Great, I'm satisfied for now if you are. Thanks for all the help.

still not pushed yet, sorry, getting there soon hopefully

NP!

Okay, so @thosjleeper worked some magic on aws.s3 and everything works now. PR incoming. The checklist at the top of this Issue is accurate AFAIK.


Add support for categorical columns

It would be nice to have some support for categorical columns (e.g. columns of strings).
We are building a stack on top of DataScienceTraits.jl to recognize the different scientific types of columns and dispatch different behavior accordingly: https://github.com/JuliaML/DataScienceTraits.jl
Would it be a good idea to add the package as a dependency, and then adjust the plots whenever a column is Categorical?
Notice that the package is lightweight, and all specializations live in package extensions.

I would expect categorical variables to show as bar plots in the diagonal and some other custom visualization in the off-diagonal plots. We could also imagine a situation where users just want to use categorical columns to color the plots of continuous variables.

@sefffal do you have any idea of how much work is required to refactor PairPlots.jl to include such features? It would be amazing to use the package in more advanced data science contexts.
We are using the package in university short-courses, and students always love it.

Appreciate the bump @juliohm . I am still interested in adding this feature but it's hard for me to justify prioritizing it vs my own research at the present moment.
Sorry for the disappointing answer but it's better to set realistic expectations.
If you have eg a student willing to work on this I could support them in making the necessary changes.

Thank you for considering the feature, we use PairPlots.jl all the time in
our explorations. No need to rush, I was just curious about your
perspective on the issue. :)
Em sáb., 27 de abr. de 2024, 13:13, William Thompson <
@.***> escreveu:

Appreciate the bump @juliohm https://github.com/juliohm . I am still
interested in adding this feature but it's hard for me to justify
prioritizing it vs my own research at the present moment.
Sorry for the disappointing answer but it's better to set realistic
expectations.
If you have eg a student willing to work on this I could support them in
making the necessary changes.
—
Reply to this email directly, view it on GitHub
https://github.com/sefffal/PairPlots.jl/issues/33#issuecomment-2080993783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3LHC7LD7YTQYSYVF4LY7PFC3AVCNFSM6AAAAABABYELBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQHE4TGNZYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add Traditional Chinese Translation

Traditional Chinese can be applied to both Chinese (Taiwan) and Chinese (Hong Kong): zh-TW, zh-HK and zh-Hant (basically the entire Traditional Chinese family).
Might need to rename #238 from zh to zh-CN.

Thank you so much for this PR. I will have a look at the naming convention here and try to fix it ASAP. Unless, of course you do not add it as part of this PR :) @adan89lion


TOC: Properties starting with "$" lead to duplicated link label

Source:
this.$items = $('…');
this.bla = 'bla';

Output:
## `Properties`
* [`$items$items`](#$items)
* [`bla`](#bla)

Can't repro this in the JS port.


Multi dropdown sortable don`t work in mobile

The issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/angular-ui/ui-select/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.
Bug description:
Link to minimally-working plunker that reproduces the issue:
Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular:
UI-Select:
Bootstrap/Select2/Selectize CSS (if applicable):

Closing it down, please open a issue as asked in the template.
Thanks :smile: