coredns pod is not able to connect to kubernetes service in IPv6 mode

Expected Behavior
coredns pod should start after calico yaml file applied and should be able to connect to kubernetes service and should be able to resolve endpoint address.
Current Behavior

Brought up kubernetes service in IPv6 mode by running the following command.
kubeadm init --service-cidr=fd00:4000::/108,<IP_ADDRESS>/12 --pod-network-cidr=fd01:4000::/108,<IP_ADDRESS>/16 --feature-gates IPv6DualStack=true --apiserver-advertise-address=2001:db8:10:1a::1.
kubectl get svc -o wide

NAME         TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)   AGE   SELECTOR
kubernetes   ClusterIP   fd00:4000::1   <none>        443/TCP   26m   <none>

kubectl describe svc
Name:              kubernetes
Namespace:         default
Labels:            component=apiserver
                   provider=kubernetes
Annotations:       <none>
Selector:          <none>
Type:              ClusterIP
IP:                fd00:4000::1
IPFamily:          IPv6
Port:              https  443/TCP
TargetPort:        6443/TCP
Endpoints:         [2001:db8:10:1a::1]:6443
Session Affinity:  None
Events:            <none>

Applied calico.yaml file
wget https://docs.projectcalico.org/v3.13/manifests/calico.yaml
kubectl apply -f calico.yaml

After applying calico yaml file coredns pod doesn't come up.
kubectl get pods -n kube-system
NAME                                       READY   STATUS              RESTARTS   AGE
calico-kube-controllers-5f579f6866-zbxc7   0/1     ContainerCreating   0          21m
calico-node-tnnl6                          0/1     CrashLoopBackOff    9          21m
coredns-66bff467f8-c6svl                   0/1     ContainerCreating   0          30m
coredns-66bff467f8-zmwnt                   0/1     ContainerCreating   0          30m
etcd-master-node                           1/1     Running             0          30m
kube-apiserver-master-node                 1/1     Running             0          30m
kube-controller-manager-master-node        1/1     Running             0          30m
kube-proxy-fgmwj                           1/1     Running             0          30m
kube-scheduler-master-node                 1/1     Running             0          30m

kubectl describe pod coredns-66bff467f8-c6svl -n kube-system
Name:                 coredns-66bff467f8-c6svl
Namespace:            kube-system
Priority:<PHONE_NUMBER>
Priority Class Name:  system-cluster-critical
Node:                 master-node/<IP_ADDRESS>
Start Time:           Thu, 10 Sep 2020 16:50:00 +0530
Labels:               k8s-app=kube-dns
                      pod-template-hash=66bff467f8
Annotations:          <none>
Status:               Pending
IP:
IPs:                  <none>
Controlled By:        ReplicaSet/coredns-66bff467f8
Containers:
  coredns:
    Container ID:
    Image:         k8s.gcr.io/coredns:1.6.7
    Image ID:
    Ports:         53/UDP, 53/TCP, 9153/TCP
    Host Ports:    0/UDP, 0/TCP, 0/TCP
    Args:
      -conf
      /etc/coredns/Corefile
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Limits:
      memory:  170Mi
    Requests:
      cpu:        100m
      memory:     70Mi
    Liveness:     http-get http://:8080/health delay=60s timeout=5s period=10s #success=1 #failure=5
    Readiness:    http-get http://:8181/ready delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:  <none>
    Mounts:
      /etc/coredns from config-volume (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from coredns-token-58ntr (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  config-volume:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      coredns
    Optional:  false
  coredns-token-58ntr:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  coredns-token-58ntr
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  kubernetes.io/os=linux
Tolerations:     CriticalAddonsOnly
                 node-role.kubernetes.io/master:NoSchedule
                 node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason                  Age                 From                  Message
  ----     ------                  ----                ----                  -------
  Warning  FailedScheduling        21m (x11 over 31m)  default-scheduler     0/1 nodes are available: 1 node(s) had taint {node.kubernetes.io/not-ready: }, that the pod didn't tolerate.
  Normal   Scheduled               21m                 default-scheduler     Successfully assigned kube-system/coredns-66bff467f8-c6svl to master-node
  Warning  FailedCreatePodSandBox  21m                 kubelet, master-node  Failed to create pod sandbox: rpc error: code = Unknown desc = [failed to set up sandbox container "a308495c7025842fa6acb3c83cbb28737cbb791bb7059403a794e14dfe2a7675" network for pod "coredns-66bff467f8-c6svl": networkPlugin cni failed to set up pod "coredns-66bff467f8-c6svl_kube-system" network: error getting ClusterInformation: Get https://[fd00:4000::1]:443/apis/crd.projectcalico.org/v1/clusterinformations/default: dial tcp [fd00:4000::1]:443: connect: network is unreachable, failed to clean up sandbox container "a308495c7025842fa6acb3c83cbb28737cbb791bb7059403a794e14dfe2a7675" network for pod "coredns-66bff467f8-c6svl": networkPlugin cni failed to teardown pod "coredns-66bff467f8-c6svl_kube-system" network: **error getting ClusterInformation: Get https://[fd00:4000::1]:443/apis/crd.projectcalico.org/v1/clusterinformations/default: dial tcp [fd00:4000::1]:443: connect: network is unreachable]**
  Normal   SandboxChanged          82s (x93 over 21m)  kubelet, master-node  Pod sandbox changed, it will be killed and re-created.

Context
With IPv6 kubernetes service coredns pod doesn't come up when calico yaml file is applied.
Your Environment

Calico version: 0.3.1
Kubernetes Version: v1.18.5

Sorry for the delay @vishal662 . The first thing I'd look at is to check whether the node requirements were met: https://docs.projectcalico.org/archive/v3.13/networking/ipv6#prerequisites

@vishal662 -- in addition to what @lmm suggested, can you check what's the node status (kubectl get node -o yaml) and why they are not ready?
  Warning  FailedScheduling        21m (x11 over 31m)  default-scheduler     0/1 nodes are available: 1 node(s) had taint {node.kubernetes.io/not-ready: }, that the pod didn't tolerate.


More bintray download problems...

ERROR: https://dl.bintray.com/lovell/sharp/libvips-8.5.5-win32-x64.tar.gz status code 403
gyp: Call to 'node -e "require('./binding').download_vips()"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp

Might be worth thinking about changing hosting to github, since this seems to happen regularly...

Hello, please see #851


Cross-compile to Windows

It would be great to be able to produce Windows .exes (either via justfile or nix commands)
cf. https://discourse.nixos.org/t/cross-compile-rust-for-windows/9582/1

https://github.com/ipetkov/crane/tree/master/examples/cross-windows


README issue: Broken link and typo

Hey guys, I just found two problems in the same paragraph on the README, so I thought it would be worth reporting it:

A RunnerDeployment or RunnerSet can scale the number of runners between minReplicas and maxReplicas fields driven by either pull based scaling metrics or via a webhook event (see limitations section of stateful runners for cavaets of this kind). Whether the autoscaling is driven from a webhook event or pull based metrics it is implemented by backing a RunnerDeployment or RunnerSet kind with a HorizontalRunnerAutoscaler kind.

So we have Cavaets instead of Caveats and and this link is not working:
[stateful runners](https://github.com/actions-runner-controller/actions-runner-controller#stateful-runners)

I think the title #stateful-runners changed to something else maybe "Runner Sets"?
Also, I am just openning this issue because it is a great README, thank you very much for this project =]

And since I have already created this ticket, there is another typo here:
https://github.com/actions-runner-controller/actions-runner-controller/tree/master/charts/actions-runner-controller#values

The values are documented as of HEAD, to review the configuration options for your chart version ensure you view this file at the relevent tag

"relevent" instead of "relevant"

I found another issue, I will add it here, and later if you guys want I can make PR with all these fixes:
so I am configuring the webhook driven scaling and I noticed this seems not to be working as expected:

$ helm upgrade --install --namespace actions-runner-system --create-namespace \
            --wait actions-runner-controller actions-runner-controller/actions-runner-controller \
            --set "githubWebhookServer.enabled=true,githubWebhookServer.ports[0].nodePort=33080"

The above command will result in exposing the node port 33080 for Webhook events. Usually, you need to create an external loadbalancer targeted to the node port, and register the hostname or the IP address of the external loadbalancer to the GitHub Webhook.

Then I tried reading the Chart README and I noticed that this option mentioned above: githubWebhookServer.ports does not exist in the README nor in the values.yaml file itself.
So I would propose updating the README text here updating the code snippet to setup an ingress or a NodePort service instead. What do you guys think? Alternatively we can add more instructions on how to setup an ingress after running this helm command.

I had seen the same issues while configuring the webhook driven scalling.
This week, I planned to play with some options from the readme. Something like githubWebhookServer.service.type=LoadBalancer
However, if the document is updated before that would be great !!

Good, I decided to create two PRs for this, in the first one I am running the README.md and the chart's README file through Grammarly for catching typos. And on the second one, I will try to fix this code snippet.

Here the first one:
https://github.com/actions-runner-controller/actions-runner-controller/pull/1353
I tried to be very conservative in order to not change the meaning of any sentence, so it should be safe to merge.
I will create a second one that other issue.

``Well, Just an heads up:
I have tried with githubWebhookServer.service.type=LoadBalancer on eks cluster and found that its working as expected.
Full command is --
helm upgrade --install --namespace actions-runner-system --create-namespace --wait actions-runner-controller actions-runner-controller/actions-runner-controller --set "githubWebhookServer.enabled=true,githubWebhookServer.service.type=LoadBalancer"
Well, this creates a classic load balancer in AWS and adds a listener on TCP port 80.
Is there any way to make it secure? by using listener as HTTPS with SSL.TLS certs?

Uhm, so if I wanted to protect it with HTTPS I would write an ingress for it instead since I already have it set up for my k8s cluster.
We might be able to think of a way to make it work with a LoadBalancer; but how to protect it might change depending on whether the user is on AWS, GCloud, or some other provider. 🤔
What are you thoughts about just providing the user with an example ingress configuration so he can setup the tls: section himself?

Just updated https://github.com/actions-runner-controller/actions-runner-controller/pull/1354 with some things that were necessary for it to work on my setup.
Now if you agree we can just add an example ingress and it should be enough, what do you think?

Yup, that sounds good!
Example ingress would be better option.

@rushikeshkalyani just added the changes we spoke about on the following PR:
https://github.com/actions-runner-controller/actions-runner-controller/pull/1354
It's ready to be reviewed, tell me if you think something should be changed.

Keep it up, we are almost merging the last PR.

@rushikeshkalyani the PR https://github.com/actions-runner-controller/actions-runner-controller/pull/1354 was merged so I will just close this ticket.
Thanks for the help and sorry for not including you on the PR, I made a mess with the mentions there.


Cadencesnwg

Now LightCurve gives an error when it is created instead than when it is used, when input does not exist.
I modified a bit Demo_LightCurve.ipynb to make it independent of AnalyzeSN

cov_utils.py deleted

I also updated the example notebook!


the transform function in the utils.py has two bugs

def transform(image, input_height, input_width, resize_height=64, resize_width=64, crop=True):
if crop:
cropped_image = center_crop(image, input_height, input_width, resize_height, resize_width)
else:
im = Image.fromarray(image[j:j+crop_h, i:i+crop_w])
return np.array(im.resize([resize_h, resize_w]), PIL.Image.BILINEAR)/127.5 - 1.

if crop,cropped_image doesn't return
j,i are not defined

Yes, but how to fix it?

Yes, but how to fix it?

Yes, but how to fix it?

issue #366


I used git pull and vcpkg updata, but it still reported errors during download

So what should I do to solve this problem

Thanks for posting this issue. Firstly, please clone vcpkg in a full English path, then run command git pull and .\bootstrap-vcpkg.bat, then rebuild boost-config:x64-windows.

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


Add missing "characteristic impedance of vacuum"

Reference issue
Closes gh-16068
What does this implement/fix?
The constant "characteristic impedance of vacuum" was not listed on the imported website during gh-10920 (see https://github.com/scipy/scipy/issues/16068#issuecomment-1113468924)

@jakobjakobson13 is this ready?

@jakobjakobson13 is this ready?

I don't recall why two checks failed. Otherwise it's looks good to me.

Ok thanks I am merging then. The CI failures it's just the linter but here we have to not respect PEP8, so all good.


NIFI-2208 refactored as per comments in JIRA

@joewitt review in progress, thanks!

@joewitt all looks good tested on standalone and on cluster including tests ensuring precedence on attribute lookup was maintained. Also negative integration test for non existent files ran without issue.
Recommend to note in documentation that with the current implementation the concept of cluster scope vs node scope is not yet available therefore each node in a cluster environment would need to be configured with the same custom properties to ensure any matching expected across the cluster.


General improvements to tests

Extend use of pyters.mark.parametrize in tests
Add comparisons with result of geopandas where possible/applicable
Apply pep 8 using flake8
Make sure all tests run in 2 parallel threads/processes + in 2 batches to get optimal combination of test coverage vs performance
Finetune combinations of test parameters that is tested against to improve test performance

closes #98
references #106

Codecov Report

Merging #109 (21a5edb) into master (a598bc6) will decrease coverage by 0.44%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   85.92%   85.47%   -0.45%
==========================================
  Files          17       17
  Lines        2912     2912
==========================================
- Hits         2502     2489      -13
- Misses        410      423      +13

Impacted Files
Coverage Δ

geofileops/fileops.py
87.54% <50.00%> (ø)

geofileops/util/grid_util.py
85.71% <0.00%> (-1.20%)
:arrow_down:

geofileops/util/geometry_util.py
89.80% <0.00%> (-0.99%)
:arrow_down:

geofileops/util/_geoops_sql.py
84.12% <0.00%> (-0.89%)
:arrow_down:

geofileops/util/_geoops_gpd.py
87.22% <0.00%> (-0.75%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a598bc6...21a5edb. Read the comment docs.


Allow multiple option=UsefulThing in API calls to the reports endpoint

Right now you can only pass one option=Something option to our main reports endpoint.
This task is to enable the passing of multiple options.  You'll have to carefully consider what that means, as some of the options have overlapping semantics.  (eg, SkipSend implicitly does a CheckConnection)
Another consideration is whether your change is a "breaking" change for our API user(s).
(For the proposal process, see ...prime-router/docs/proposals/proposal-process-readme.md)
I think all the code you'll need to examine is in ReportFunction.kt
Tasks:

Write a brief proposal for how this will work, and submit it as a PR for the team to review.
Code and Test away!

Not clear to me if this is done or not.   Its in Review/QA, but does it work and is it documented what combinations are valid?
For example,
$ curl -X POST -H "client:waters"  -H "Content-Type: text/csv" --data-binary<EMAIL_ADDRESS>"http://localhost:7071/api/reports?ption=SkipSend&option=ValidatePayload"
returns
{
  "id" : null,
  "warningCount" : 0,
  "errorCount" : 1,
  "errors" : [ {
    "scope" : "PARAMETER",
    "id" : "option",
    "details" : "'SkipSend,ValidatePayload' is not valid"
  } ],
  "warnings" : [ ]


Fix form links in conventions.md

Hi, this fixes two "see also" links that were incorrect

Closing since it was fixed by https://github.com/remix-run/remix/pull/890


Streaming?

Just proposing the idea of making glob.Glob a stream instead of an EventEmitter that pretty much is a stream.
I've written a quick wrapper to do what I need but having somebody who knows what they are doing would probably be better.
Thoughts?

What effect would this have usage-wise?

Rather than land this in this module, here's a quick wrapper that anyone can use
// copyright Isaac Z. Schlueter. Public Domain.
var glob = require('glob')
var Readable = require('stream').Readable
var util = require('util')
util.inherits(GlobStream, Readable)
function GlobStream (pattern, options) {
  Readable.call(this, options)
  var self = this
  this.glob = glob(pattern, options)
  this.glob.on('match', function (m) {
    self.push(m)
  })
  this.glob.on('end', function () {
    self.push(null)
  })
  this.glob.on('abort', function () {
    self.push(null)
  })
  this.glob.on('error', function (er) {
    self.emit('error', er)
  })
})


[feature] What todo about JSON changes and notifications?

When there's a change detected in JSON, how do we represent that output?
At the moment the text-diff does not care about the JSON structure, and will just send the text diff, breaking the JSON format
For example, you have something like
{
"name": "John",
"score": 10
}

If score changes, {diff} will just tell us that score changed, but the actual JSON output is broken and unusable (it would contain only "score": 11  )
I looked at a few JSON-diff tools but they seem to just format the JSON then return the text diff, but in this case, we want the option (or notification token like {new_json}) to be available, where that token is available if the json:... filter is used
Some ideas

Token {json_new} the whole JSON structure that got used in the json:... filter from the NEW change
Token {json_previous} the whole JSON structure that got used in the json:... filter from the OLD change
Token {json_value} just the JSON value that changed (it would contain {"score": 10 })

So you could for example drive some other service with a notification like
url: https://myservice.com/upsert?id={watch_uuid}
body: {json_new}

json_new and json_previous seem to make most sense to me. Calculating json_value looks more difficult and I'm not sure if it is that useful. Most services do probably request a complete json structure, don't they?

yeah.. tough one, there doesn't seem to exist a standard "JSON difference" type language schema either

kinda related, you could make a JSON structure instead of <br/> here if configured in the right mode
https://github.com/dgtlmoon/changedetection.io/blob/07c60a6acc47b03f05cebc329515f207277ea578/changedetectionio/html_tools.py#L29
then you could JSON Post an object containing a list of news-headlines for example, instead of having it all in one chunk of text

https://github.com/kpdecker/jsdiff now supports jsonDiff


Updates and Deployment for PR #7

Updates and deployment for SushiBar subgraph based off the work that was done in #7

B/c we're not using bar subgraph in prod yet, I went ahead and deployed this PR's subgraph here: https://thegraph.com/explorer/subgraph/sushiswap/sushi-bar


Feature Request: to specify order of input items

I am building an input form that has three selectable lists (drop down menus) and two text input boxes.  Currently the text input appears before the drop-downs but I'd like the text input to appear after the drop-down instead.
Can dialog have an option for strict ordering in which certain items are added?  Or would it be possible to add an index=# parameter to certain customizable items and then add an "index order" statement to control the order of their appearance?
Proposed example below.
/usr/local/bin/dialog -d --title "Test window." \
--selecttitle index=0,"What flavor of ice cream is your favorite?" \
--selectvalues "Vanilla, Chocolate, Lemon Sherbet, Salted Caramel, Something Nutty" \
--selecttitle index=1,"How long does your ice cream last?"  \
--selectvalues "I am eating it now, Less than 20 minutes ago, Less than 1 hour ago, 1-6 hours ago, 6-12 hours ago, 12-24 hours ago, More than 24 hours ago" \
--textfield index=3,"Ice cream description",prompt="Briefly describe the ice cream and steps to digest it." \
--textfield index=4,"Ice cream brand",prompt="What is your favorite ice cream brand?" \
--displayindexorder "4,0,1,2,3"

This is something I've thought about.
Strict ordering would be my preferred. The argument parser includes an index so for select items it should be possible to create an ordered list.

@bartreardon : happy Monday.  Just wondering if this is on the roadmap for v2.0 ?
Cheers.

indeed it is - to implement this in v1 is a complete re-write of how that code is managed anyway and a rewrite is what I'm doing for v2. If might not make it for v2.0 but the requirements to make it work are being considered.
At the moment I'm using SwiftUI's native logic for presenting multiple views which works well for a long list of things that are all the same. text boxes, dropdowns, etc are all different types of views so instead of a simple "for each" to display one or more things I essentially have to unroll everything into a seperate array, re-order the array based on what your desired ordering is, then re-draw it all. This will have implications for making all content modifiable on the fly which is also a v2 roadmap feature.
as you could imaging, this will take a bit of work to figure it out nicely.

+1

it does. you can represent the views as an array of objects then display them however you like. I haven't looked into it yet though to work out a nice way of representing it.

@bradtchapman doing per item ordering might be a bit more work - initial implementation to allow re-arrangement of groups of items

Fixed (to a reasonable approximation) in v2.5.0


AudioStreamPlayer3D crashes the game

Godot version
Godot v4.1.1.stable
System information
Windows 11 - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX (Advanced Micro Devices, Inc.; 31.0.21029.6002) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
Issue description
I have a project in which the player can right click to spawn a ball, which is a RigidBody3D (using Jolt). This ball is rather simple:

The balls free themselves after 5 seconds, so there are never more than 10 balls on screen at once. Despite this, after only a few seconds of creating balls, the game will always crash without any error. I believe this to be caused by the AudioStreamPlayer3D node, as deleting it from the ball scene removes this issue.
https://github.com/godotengine/godot/assets/4535064/aa8f6580-0c21-4628-aba2-a97109e5fc3e
This issue occurs whether or not there is actually audio playing, just by the nodes existing does it cause the game to crash.
It will crash at about the same point whether or not the audio is playing.
Also worth noting that the .wav file loaded into the stream is only 22KB, it is just a few millisecond long sine wave.
Steps to reproduce
From the attached project, play the scene "dark scene.tscn". Don't do anything, just let it play until the Node counter reaches about 200 (sometimes it is able to reach 500). The game will crash with no error.
Minimal reproduction project
audio glitch.zip

Confirmed with Godot v4.1.1.stable.

@stilestr Please create a minimal reproduction project. Right now it's your entire project, minimal reproduction project should isolate the issue to bare bones, make a new godot project and reproduce it there.
Currently it could be anything in your project interfering.
Your project indeed crashes but if I create a new project, add AudioStreamPlayer3D and let it queue free after couple seconds I can create thousands of these and even let it play without any crash so it's difficult to tell where your problem could lie without as trivial reproduction project as possible ;).


map device management

🚀 Feature
Provide an easy or automated way to get batches + models on to the correct device with map.
Motivation
We often want to map over a bunch of GPU machines, maybe each with more that one GPU on board. Right now, deciding which device to use in each process is a little tricky, you have to get the rank modulo the number of CUDA devices.
Pitch
Probably the cleanest thing would be to just automatically handle devices more like a LightningModule - maybe if you pass an nn.Module to map we could put it on a correct device for the process and wrangle the inputs / outputs.
Alternatives

Additional context

Hey @ethanwharris,
The map and optimize callable supports some sort of device already. You just need to add the optional device argument to your callable.
def fn(..., device):
    ...

map(fn, ...)

Does this solve your issue ?

@tchaton
Cool, yeah so we can probably mark this as done - although hard to discover that you can do it, might still be nice to just pass an nn.Module or something and have it done automatically 😃


Add auto generated api-reference for core resources

How to categorize this PR?

/area documentation
/priority normal
What this PR does / why we need it:
Added the api-reference for the core landscaper resources
Which issue(s) this PR fixes:
Fixes #45
Special notes for your reviewer:
Release note:

Added automated api-reference generation for Landscaper core resources

reason for test failure was a rate limit:
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit


Minor improvements for TravisCI

Enable coverage report
Disable xdebug for composer
Test on PHP 7.1 (stable now)

Changes Unknown when pulling a92fc6feb03ff08d5726df3a0e8c6c455a792be1 on sstok:travis-ci-improvements into ** on park-manager:master**.

Changes Unknown when pulling a92fc6feb03ff08d5726df3a0e8c6c455a792be1 on sstok:travis-ci-improvements into ** on park-manager:master**.


Swap grammar used for Vimscript highlighting

You guys know the drill.
This grammar wasn't mine to begin with, BTW... it was transferred to me by its author, who originally ported it from a TextMate bundle (which is also what the current grammar was derived from, I believe).
I also wrote a script to keep the grammar updated with keywords pulled from Vim's own syntax file for Vimscript. So it'll stay nice and updated. =)
Files depicted in preview:

Images 1-2
Image 3

Any idea why Travis has spat the dummy? :S
  1) Failure:
TestGrammars#test_submodules_have_licenses [/home/travis/build/github/linguist/test/test_grammars.rb:86]:
The following submodules don't have licenses:
* vendor/grammars/go-tmbundle
* vendor/grammars/factor
* vendor/grammars/jflex.tmbundle
Please ensure that the project has a LICENSE file, and that the LICENSE file contains the full text of the license..
--- expected
+++ actual
@@ -1 +1 @@
-{}
+{"vendor/grammars/go-tmbundle"=>nil, "vendor/grammars/factor"=>nil, "vendor/grammars/jflex.tmbundle"=>nil}


Invalid chars in webroot too strict

I think the invalid char list for the webroot is a bit too strict. Currently only [^0-9a-zA-Z\/-] is supported but I think there should be at least _ allowed too.
For example when hooking Mailhog into an "internal path" that has special access rights, even in non-production environments. For example https://my.service/_internal/mailpit.
Would it be possible to add at least _ to the list of allowed chars? Maybe also . would make sense - think https://my.service/internal.mailpit

@adepretis Thank you for raising this - adding those characters is not a problem at all. Both _ and . characters will be included in the next release.

This has been included in the v.1.3.11 release. Thank you for your contribution.


continued continued move of core services to backend-defaults

This is a continuation of https://github.com/backstage/backstage/pull/24724, moving over some implementations from backend-common (which is scheduled for removal) to backend-defaults.

urlReader

Made this into a PR of its own since it turned out to be pretty large. Note that it's on top of #24848, which should be merged first. But therefore, piggybacking on its changesets.
This PR does NOT rename the types in backend-plugin-api, e.g. SearchOptions -> UrlReaderSearchOptions, since that's an additional pretty large change that can come by itself so things are easier to review in isolation.

@Rugvip Ooh maybe. Hm which one should have the implementation though? That would suggest that the impl should stay in backend-common, since backend-defaults already has a dependency on it. Don't wanna introduce circular dependencies

I think I'll start over on this one now that #24848 settled on a slightly different structure


Since nvm v0.40.0 .nvmrc may contain comments

Description:
Since nvm v0.40.0 .nvmrc may contain comments.
[New] allow .nvmrc files to support comments
Action version:
v4.0.3
Repro steps:
- uses<EMAIL_ADDRESS>  with:
    node-version-file: .nvmrc

.nvmrc
# comment
20.16.0

Expected behavior:
.nvmrc files with comments are supported.
Actual behavior:
I have not verified it yet.
If it works already than this issue should at least add another test to the test suite.

Hello @sdavids, Thank you for creating this issue and we will look into it :)

Hi @sdavids,
I have tested and verified that .nvmrc files with comments are supported.
Could you please provide more details about the specific test you believe should be added to the test suite? Understanding your requirements in detail will help us address your concerns more effectively.

Just having a test for:
.nvmrc
# comment
20.16.0

would be enough.

The contents of a .nvmrc file must contain precisely one  (as described by nvm --help) followed by a newline. .nvmrc files may also have comments. The comment delimiter is #, and it and any text after it, as well as blank lines, and leading and trailing white space, will be ignored when parsing.
Key/value pairs using = are also allowed and ignored, but are reserved for future use, and may cause validation errors in the future.

https://github.com/nvm-sh/nvm/blob/master/README.md#nvmrc
I do not think all comment locations need to be tested for setup-node, nor should the key-value syntax be tested (yet).

Hi @sdavids,
Thank you for your valuable suggestion. After analyzing the issue, it seems to be more of an enhancement rather than a bug. I have tested and verified that .nvmrc files with basic comments are supported.
The idea of incorporating extended comment support in .nvmrc files could significantly enhance the usability of setup-node. Your suggestion has been taken into consideration, and we will explore the possibility of incorporating it in future updates.
Please feel free to share any further insights or suggestions you may have.


example 4 - flexible flying wing flight dynamics

include rigid body, fuselage and engines;
flight equilibrium computation;
linearization/stability;
simulations

split in two examples


Uploading fails because of CORS issue

When trying to upload a file from the PR preview version I get the following error. It seems that Bee does not add the swarm-collection header to the exceptions with Access-Control-Allow-Headers but this should be confirmed.
Also the error message stays on screen for very little time and it's hard to read. It would be better if it stayed a bit longer.

@agazso can we close this?

This is still an issue that I can reproduce. The current PR preview is using Bee 1.6.1, maybe it is fixed in a later version?


x/pkgsite: add flag to set an alternative for /files URLs

This issue is a feature request to add a command-line flag to change the prefix of the URLs generated for source declarations.
For example, when I run pkgsite in a local clone of the kubernetes repo, by clicking around on the API documentation for a package, I can reach this URL:
http://localhost:8080/files/Users/adonovan/w/kubernetes/k8s.io/kubernetes/pkg/api/endpoints/testing/make.go#L53
I would like to be able to run pkgsite in a mode in which this link instead goes to:
http://localhost:12345/something/Users/adonovan/w/kubernetes/k8s.io/kubernetes/pkg/api/endpoints/testing/make.go#L53
In particular, the prefix http://localhost:12345/something/ would be an endpoint served by a local gopls instance, and visiting that URL would cause gopls to send a showDocument request to the user's editor to open the named file and line. In this way, the pkgsite browser pane and the user's editor can link to each other, enabling a lightweight interactive process for reviewing API documentation even as the files are being edited.
(A related feature request would be the ability to specify "overlays" of unsaved editor buffers that pkgsite would use instead of the file system, but I suspect that's rather harder. It would allow even unsaved doc edits to be previewed.)

Having inspected the pkgsite code a little, I think the cleanest seam would be for the Server.InstallFS operation to install an alternative handler when the flag is set, and this handler would issue an HTTP redirect to the flag value + req.URL.Path.
That way all the places that construct /files URLs can be left unchanged, and just the endpoint that handles them will differ.

I think it will be simpler overall for gopls to implement its own rendering. Code sharing would be complex for both parties, and the total amount of code gopls requires is really not very much. Having its own implementation will make it easier to evolve, for example to include type-derived information, which is of course not available to pkgsite.
Retracting this feature request.


JMP.chat

I suggest adding JMP.chat to the SMS gateway options reviewed.

I will review it thoroughly this weekend and hopefully have one up this week.


contribute to VSTSPosh

Hi guys,
I have tried to contribute to this project but I get access denied.
Maybe you can add 'New-VstsWiqlQuery' function to the project.
Best regards,
Alex
Workitems.zip

Hi @alexm186 - have you tried creating a Pull Request with your changes from your fork of this repo? This will allow it to be reviewed and then incorporated more easily by the project owner. See: https://help.github.com/articles/creating-a-pull-request/
Hope this helps! :grin:


App running on configurations from .env

Thanks for your contribution :)
I am looking through this and while the formatting changes look reasonable, I'm not sure that it actually solves anything.
Would you mind helping me understand

What your change aims to accomplish
How it helps solve the linked issue
Describe some testing steps I could take to verify on my end

Noting there is also a conflict to resolve.


Adding apiVersion parameter to AuthenticationClient

Adding a way for users to specify a SalesForce API Version in authentication client if their use case requires it.

Is it possible to get this PR merged? We have forked and done the addition of our selves but would like to use the official version.

There was a failure that I've fixed. Thanks for the contribution!


sqllogictest statement error no escaping

Is your feature request related to a problem or challenge?
Currently ( and ) character needs to be escaped in sqllogictest statement error. Not sure if this is possible but it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.
Expected
statement error ParserError("blablabla")

Current
statement error ParserError\("blablabla"\)

Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

FYI @melgenek  -- this seems very similar to https://github.com/apache/arrow-datafusion/issues/5727
I wonder if we can apply a similar fix 🤔

it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.

If I understand correctly, there is no issue at the moment, and validation works correctly when symbols are escaped.
sqllogictest-rs makes an explicit choice to have errors as Regexp, that's why there is a need to escape characters that have special meaning in Regex like (,),.,[,]

I think I have seen errors (maybe where newlines aren't escaped?) I'll pay attention to this in more detail if it happens again

Closing this ticket as working as expected, I think


FancyZones is not working after waking up from sleep

Microsoft PowerToys version
0.78.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
Windows build number: Windows 10 Professional [22H2 19045.3930]
PowerToys version: 0.78.0
After pulling my laptop wake from sleep mode, the fancy zones function no longer works, whether long press Shift to drag the window or Shift+` to call the editor.
I had to toggle enable again to get it activated and resume functional.
✔ Expected Behavior
When I long press shift, the transparent layout should show up in the background, but it doesn't work.
❌ Actual Behavior
Nothing happened both pressing shift and shift+`
Other Software
No response

Hi, here is the report bug, maybe due to resolution difference? I upgraded my monitor from 2k to 4k.
PowerToysReport_2024-02-03-07-10-59.zip

Looks like there are several instances of got malformed json for FancyZones module from the runner logs. Not sure what could be causing that. All of the Fancy Zones .json setting files look fine to me.


add support for generics in reflect mode

Parse TypeParameters from type name only when "[]" is present in type name.
related: #128

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@r-hang PTAL. Thanks!

Does your implementation work for case like foo.T[int[], bool, string[]] ?

also see: https://github.com/uber-go/mock/issues/97


Impossible to implement Volume discount with multiple tiers per product

There's a huge limitation on functions (discounts) which makes this unusable in real life cases: even though a function can return a list of multiple discounts (say, one for each cart line item), Shopify will apply only one of it. We need all the discounts to be applied.
For example: Volume discounts have different tiers for different quantities. A cart line could have quantity 2 and qualify for 1st tier (10% discount), another cart line could have quantity 6 and qualify for 2nd tier (20% discount). This is impossible to handle now, as even though the function returns 2 different discounts to apply, Shopify applies only one.
Need  DiscountApplicationStrategy: ALL, not just one: https://shopify.dev/api/functions/reference/product-discounts/graphql/common-objects/discountapplicationstrategy
There are forum posts about this, but nobody at Shopify didn't even reply:
https://community.shopify.com/c/shopify-functions/shopify-functions-product-discount-api-multiple-discounts/td-p/1693369
https://community.shopify.com/c/shopify-functions/need-discountapplicationstrategy-all/td-p/1865853

Another +1
Ran into the same issue right away while working on implementing function discounts. Thanks for your help!

We have the same problem

+1 here too


Missing include in crypto/o_fopen.c

The header malloc.h should be included in crypto/o_fopen.c if _WIN32 is defined. Otherwise, the missing declaration of _alloca() may result in a segmentation fault. I get this when trying to run the openssl command (version 1.1.1) compiled under mingw32.

Should be fixed in 1.1.1 and master now.


[Feature Request] Use JSONC for body

Is your feature request related to a problem? Please describe.
There are a lot of cases where being able to comment out parts of the JSON body would be useful. e.g. Quickly switching between different body content, alternating between different JWTs (env vars). It would also be useful for leaving comments for future reference.
Describe the solution you'd like
To use JSONC in place of or in addition to JSON for the body type. This would allow comments in the JSON that would be ignored by the parser.
Describe alternatives you've considered
The only alternative is to store alternate body content elsewhere (e.g. external doc) or, in the case of env vars, rename "commented out" var to something not in use.

bump.

I'd also like this 🙂

I created a simple plugin to add this option, it should appears on the Plugin Hub in a few days: insomnia-plugin-jsonc on npmjs.
Also, although, it allows to send the JSON with the comments trimmed (at the request time), the JSON validator display errors/warnings, and I don't think altering the JSON validation is doable with a plugin, so still looking for it in the core of insomnia. 😄

Is this something that'll ever be planned? There seems to be a bug with the Nunchucks commenting where the comment becomes a variable that doesn't display properly. I'd love to use proper commenting in my JSON.


Init container resource limits

Hello,
Our k8s implementation require resource limits for all containers. Without limits they wont create.

How to set resource limits for init container?

Hi @srekkas.
Unfortunately it is currently not possible to configure resources for the init containers. But I can see the benefits.
I'll mark this issue as a feature request. If you have the time and energy, PRs are always welcome.

Hello
Thank you for reply.
I found out that you can set default resource limits, which then automatically applied. So its nod needed anymore for me.
https://kubernetes.io/docs/concepts/policy/limit-range/

Please reopen. Thats an ok workaround for some folks, but not others. It really should be fixed properly.

add k8s implementation to support resources limits for init container -

add k8s implementation to support resources limits for init container


Remove support for per-instruction memory statistics

The new CBC interpreter does not support it anymore.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

Updated according to the reviews.

LGTM

LGTM


Should AbstractCloseableIterator implement AutoCloseable?

AbstractCloseableIterator already implements Closeable but should it also implement AutoCloseable?
If so this might be considered an API change. Even though AutoCloseable is a java.lang default imported type and all implementations will behave correctly as the Interface contract is already provided by the fact that Closeable is already a super Interface.
In any case it will allow using try-with-resources for any code, with the relevant IDE warnings etc.

Do we even still use that class anywhere in our code? The distinction we previously made between iterations and iterators has become less necessary since RDF4J exceptions were made unchecked by default.
I wonder if we could clean up things a little and replace its use with AbstractCloseableIteration everywhere (or the other way around).

I pretty much only found this use case:
https://github.com/eclipse/rdf4j/blob/07d77aca70acff4229f89fdfa5e3932629b2bf04/core/queryalgebra/evaluation/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/iterator/HashJoinIte
ration.java#L135

Btw I'm not against making it autocloseable either. @JervenBolleman what is that you needed this for? Do you use it internally?

Mostly, I am just trying to be a good citizen with my new write-once/read-lots sail. Where I need to do some stream like operations with iterators so I was looking into which style code RDF4J uses, and then I noticed this.

Let's just go with making it AutoCloseable, I don't think this counts as a backward-incompatible change so am fine with putting this in the next minor release.
The discussion about cleaning up some of the redundancies between Iterators and Iterations is something we can do separately.


Allow config generator to read and update config at game runtime

[ ] Spawn a simple http server to get and set the config
[ ] Make a reasonable UI in the game with bsml
[ ] Support read and set config from game on the webpage

or use system.net.httplistener and avoid the dependency

Http server implemented in #66


abc leaves assign statements in generated netlist

Version
Yosys 0.16+2
Reproduction Steps
I am trying to Synthesize a tiny microcontroller. I am using the following script:
  script yosys_read_verilog.tcl;
  read_liberty -lib ../../../hw/asic/sky130/sky130_sram_4kbyte_1rw_32x1024_8_TT_1p8V_25C.lib;
  hierarchy -check -top core_v_mini_mcu;
  proc; opt;
  techmap; opt;
  dfflibmap -liberty ../../../hw/asic/sky130/sky130_fd_sc_lp__ss_150C_1v65.lib;
  abc -liberty ../../../hw/asic/sky130/sky130_fd_sc_lp__ss_150C_1v65.lib;
  clean;
  write_verilog core_v_mini_mcu_yosys_synth_sky130.v;

When opening the core_v_mini_mcu_yosys_synth_sky130.v, I still see Verilog assign statements and always blocks.
e.g.:
  always @(posedge clk_wr_i) begin
    if (fifo_incr_wptr)
      storage[_000_] <= _001_;
  end

However, I should only see standard cells and macros.
I guess the error may be in the techmap command.
Expected Behavior
I should see only standard cells in the final netlist
Actual Behavior
I see assign and always statements in netlist

Does the original design contain any memories? If so, you need to either custom map these, or run memory to map them to FFs first (this is a coarse grain pass, so call it before techmap).


Refactor plugins/module_utils/controller.py for better testing

Add some unit tests for module_utils

I renamed the PR and marked it as bug because it is touching runtime code, not only tests.


Standalone scale to zero

Without the standalone version, we need to decide whether we will support scale to zero or not. It may suffice to say that if you want scale to zero, you need to use in combination with Knative or something similar. Also possible is that in integrating with Knative, we'll need to implement our own activator proxy anyway (to avoid the tight undocumented coupling that Knatives activator proxy has with the rest of its infrastructure).
The design would essentially be the same as Knative - though I'm not 100% sure how it works in Knative, that is, I'm not sure how Knative ensures that requests are routed to the activator. Given that we don't have an independent autoscaler, our activator would need to also be responsible for scaling up from zero.

What I'm assuming (could be completely wrong) is that we can configure Istio such that requests only get routed to the activator if there's nothing else to route requests to.


Allowing no-symmetric neighbours

Codecov Report

Merging #32 (f90ac36) into master (06b0c51) will decrease coverage by 0.18%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   92.56%   92.37%   -0.19%
==========================================
  Files           8        8
  Lines        1950     1954       +4
==========================================
  Hits         1805     1805
- Misses        145      149       +4

Impacted Files
Coverage Δ

src/Interfaces.jl
91.55% <38.88%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b0c51...f90ac36. Read the comment docs.


[feat/is-imported-from] isImportedFromSource

Additions

isImportedFromSource adds a small function to determine if given import specifier is imported from specific source (this resolves #30)
isStringMatching a simple helper to perform partial matches using either regex, or string or number.

Chores

package upgrades (resolves #29)

relates to #12