fix(frontends/lean/parser): support open inside sections with parameters

At the moment the following works:
section
parameter α : Type
inductive foo : Type | a : α → foo | b
check (foo.b : foo)
end

But this doesn't:
open foo
check (b : foo)

It feels wrong to interpret the environment's aliases using the parser's local declaration map as done in this PR, but it is to the easiest solution I could think of here.

Please wait with merging for a second, I just noticed that this fix doesn't work if we're inside a namespace.

Okay, it works now, but I have no idea whether that's the right way to solve it.

A related issue is that parameters are not exposed to the tactics (at least as far as I can tell), not even to_expr respects them:
run_command (do
  e ← to_expr `(b),
  t ← infer_type e,
  trace t)

-- prints: Π (α : Type), foo α

I'm working on this issue.
To fix the tactic related issue, I will refactor the aliases module.
We need to store the parser "local_refs" (such as b ==> foo.b  α) in the environment. Otherwise, the tactic framework will not see them since it does not have access to the parser.

In the commit above, I addressed the original issue by changing how the aliases are created.
The code will be cleaner after the aliases module refactoring since it will also store the entry b ==> foo.b α

Leo, I believe we discussed implementing a more "declarative" version of open at some point where instead of replaying commands onto the environment, we derive a (cached) name map from all active open commands when needed. I proposed this for fixing the old "have to re-open a namespace after changing it" issue, but I assume it could also simplify this issue?

The commit above solves the issues above, and cleanup the solution.

@kha Yes, I remember. We should implement it in the future.
However, the issue raised here is a little bit orthogonal to it.
In Lean, parameters are simulated. See discussion at https://github.com/leanprover/lean/issues/554

@gebner Note that the example
run_command (do
  e ← to_expr `(b),
  t ← infer_type e,
  trace t)

still doesn't work after the commit above. The issue is that it indirectly uses α which is not in the local context. However, the following similar example works.
include α
example : true :=
by do
  e ← to_expr `(b),
  t ← infer_type e,
  trace t,
 triv

because the include command forces α to be in the local context of the example.

@gebner @kha At #554, I tried to summarize the advantages and disadvantages on the approach used to implement parameters in Lean vs the one used in Coq.

I didn't push the commit above to the main repo yet because it broke a few tests.

This solution is much nicer than my quick fix.

The issue is that it indirectly uses α which is not in the local context.

What is a direct use?  Only parameters that are referenced in the type?
In the following we now have α in the local context, but something still goes wrong:
def ex : foo := begin trace_state, exact b end

13:23: α : Type
⊢ foo

13:36: invalid type ascription, expression has type
  _root_.foo α_1
but is expected to have type
  foo
state:
α : Type
⊢ foo

What is a direct use? Only parameters that are referenced in the type?

Yes, for theorems, only parameters referenced in the type are automatically included because we need to compute the precise type of the theorem before we elaborate it.
For definitions, we also include the value, but we ignore tactics. We ignore tactics because the names occurring there are only resolved at tactic execution time.
BTW, I willing to revise these rules. I'm not super happy with the way Lean handles parameters.

I will fix the issue at
def ex : foo := begin trace_state, exact b end

@gebner @kha I think we should revise how parameters are handled in Lean after the POPL tutorial. It is too confusing (for us and for users). The Coq approach is simpler to understand, the only disadvantage is that the end section command would be a synchronization point. What do you think?

The Coq approach is simpler to understand, the only disadvantage is that the end section command would be a synchronization point. What do you think?

So we would first add the parameters as constants, parse the section normally, and then add abstractions to the declarations and replay them onto the environment from before the section?
Whether this requires waiting for the proofs depends on how we define what parameters are used by a lemma.  In my opinion, this should not depend on the proof.  And then it doesn't become a synchronization point either.
One issue that you mentioned in #554 is that almost all other environment changes get lost during the replay.  I think we could solve that problem using the modification lists I proposed in #1243: we would just need to add an abstract_parameters method to the modification objects.  Then we can reset the modification list at the begin of a section, and replay the abstracted changes at the end.

So we would first add the parameters as constants, parse the section normally, and then add abstractions to the declarations and replay them onto the environment from before the section?

Yes.

Whether this requires waiting for the proofs depends on how we define what parameters are used by a lemma. In my opinion, this should not depend on the proof. And then it doesn't become a synchronization point either.

Yes, we can enforce this.

One issue that you mentioned in #554 is that almost all other environment changes get lost during the replay. I think we could solve that problem using the modification lists I proposed in #1243: we would just need to add an abstract_parameters method to the modification objects.

Yes, I agree. Moreover, when #554 was written we didn't have the attribute manager. It also helps.
I think this will be a good change. The current approach is too fragile, and allows the user to do weird stuff (e.g., use the rename tactic to rename a parameter). For example, the following example doesn't work because b is mapping to foo.b α, but α is not in the local context anymore after the rename.
def ex : foo :=
begin
  trace_state,
  rename α β,
  exact b
end

In the new approach, the user will not be able to write this.

The commits above address the issues raised in this PR.
The solution is not perfect, and we may change how parameters are implemented in Lean in the future as discussed above.


newlib: Add parameter for "nano" variant

Motivation for this change
For very resource-constrained embedded devices. See comment on new param for details.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Should we add a top-level entry to cache it?

Added a top-level entry for it.


LiveReload css detected by BrowserSync but not visible on page until manual refresh

CSS changes are detected (moved to dist folder) and BrowserSync is notifying that *.css has been injected, however no updates appear in page.
I've temporarily had to tweak the setting in https://github.com/NathanWalker/angular2-seed-advanced/blob/8544b8c2e17d2de42fcde47278f18f414af7868d/tools/utils/seed/code_change_tools.ts#L48
Will dig deeper as to the cause unless someone has a simple solution.

I'm also seeing this problem. I'm using Sass (scss) files according to the guide in the parent project:
https://github.com/mgechev/angular2-seed/wiki/Add-Sass-support

Closer to a solution: seems like only main.css is being pushed to browser, regardless of which file was modified. Any css file modification triggers the following in browser sync WS frame
42/browser-sync,["file:reload",{"ext":"css","path":"*.css","basename":"*.css","type":"inject","log":true}]

which triggers fetching main.css (even if a different file was modified):
http://localhost:5555/dist/dev/css/main.css?1464556759343=&rel=1464556914500

@aaweb I too am using sass however this bug is independent of that (testing with latest master of this repo).

Seems like this was reported in the parent seed...
https://github.com/mgechev/angular2-seed/issues/925
https://github.com/mgechev/angular2-seed/issues/804

@hellofornow @NathanWalker - I'll take this one, realistic E.T.A will be Friday afternoon.

@d3viant0ne was this still pending?

@NathanWalker It was waiting on the whole decoupling thing. I have some maintenance work to do on the Material2 fork planned for Friday post work. I'll stick this back on the docket and fix it upstream.

@NathanWalker @hellofornow - This has already been fixed upstream and the change is already in #master
https://github.com/NathanWalker/angular2-seed-advanced/blob/master/tools/utils/seed/code_change_tools.ts#L44-L51
Though I would have probably just removed the code as opposed to commenting it out, this issue no longer exists. CSS changes are detected / refresh as expected.

@hellofornow - can you please verify this is no longer an issue for you and if so, close it. Thanks :)

Ya; will close this as the feature is (unfortunately) unavailable.

It works just fine, what's the issue?

BrowserSync supports hot loading css changes (without a page refresh). From the parent seed it seems that feature won't be supported.

Ah, I misunderstood what it is you were talking about.
@NathanWalker isn't against deviating from the parent seed when it makes sense. I can certainly see valid use cases for wanting to inject css changes and iirc, it's doable in the seed it would just take a bit of work.
It's up to Nathan.

Hot loading CSS makes a lot of sense to me for this seed. I can't recall why it's not supported in parent seed but I'd be open to enabling if here if no side effects.
Out til Tuesday, check back then.


Dependency-updates

fix #368

blocked, waiting on #370

Sure thing, I'll do that later today or tomorrow.

blocked, waiting on #370

Unblocked, waiting for me to manually confirm that generated apps still work properly

Needed to be updated for the latest tsync version, should be good now.


Automated Package Upgrade

:tada: This PR is included in version 12.4.134 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add script for running test262 tests

Closes #510. This uses adrianheine/test262-parser-runner which I extracted from babylon.

Hey there Adrian! This is a great idea. I've been working on something similar myself over at https://github.com/bocoup/test262-stream . I've been meaning to get that on npm; I'll do that and offer an alternative in just a bit.

Hi @jugglinmike, thanks for your feedback. Did you already start working on your proposal?

FWIW there is also specialized https://github.com/tc39/test262-parser-tests/ which has few quirks (tests that need to be blacklisted), but otherwise would be easier to use.

Hi @jugglinmike, thanks for your feedback. Did you already start working on
your proposal?

Yup; I'm hoping to have something for you to review by this weekend. Thanks for
your patience!

Running a little behind schedule, but here's that patch https://github.com/ternjs/acorn/pull/622

@adrianheine If you just want to run Test262-parser tests, you can just "steal" my code for it. Located here. Install the tests from NPM and adjust the whitelist and it should be ready to go. Max 5 min to fix!

Another option is to integrate support for test262-parser-tests, but that repo isn't up to date. It supports only ES2016. However.  I extracted from Test262 a similiar test suite found here:
https://github.com/cherow/ecma-parser-tests
It has support for everything up to ES2017. ES2018 and ECMAScript Next tests are separated from Test262Tests into it's own folder - next.

That sounds like a good way to get additional coverage! Given that the projects are maintained separately, integration into Acorn's test suite should probably be done with two isolated pull requests.

I replaced the test loading and parsing of test262-parser-runner with usage of test262-stream.

I also implemented passing (and pinning) the test262 version and added the tests to travis.

These don't pass at the moment:
 ✘ 3 valid programs parsed without error (in violation of the whitelist file)
 ✘ 43 invalid programs produced a parsing error (in violation of the whitelist file)

Details:
   3 valid programs parsed without error (in violation of the whitelist file):
   language/expressions/assignment/destructuring/obj-prop-__proto__dup.js (default)
   language/expressions/assignment/destructuring/obj-prop-__proto__dup.js (strict mode)
   language/statements/let/syntax/escaped-let.js (default)
   43 invalid programs produced a parsing error (in violation of the whitelist file):
   language/export/escaped-as-export-specifier.js (default)
   language/export/escaped-as-export-specifier.js (strict mode)
   language/export/escaped-from.js (default)
   language/export/escaped-from.js (strict mode)
   language/import/escaped-as-import-specifier.js (default)
   language/import/escaped-as-import-specifier.js (strict mode)
   language/import/escaped-as-namespace-import.js (default)
   language/import/escaped-as-namespace-import.js (strict mode)
   language/import/escaped-from.js (default)
   language/import/escaped-from.js (strict mode)
   language/expressions/async-arrow-function/escaped-async.js (default)
   language/expressions/async-arrow-function/escaped-async.js (strict mode)
   language/expressions/async-function/escaped-async.js (default)
   language/expressions/async-function/escaped-async.js (strict mode)
   language/expressions/new.target/escaped-target.js (default)
   language/expressions/new.target/escaped-target.js (strict mode)
   language/statements/async-function/escaped-async.js (default)
   language/statements/async-function/escaped-async.js (strict mode)
   language/statements/class/async-meth-escaped-async.js (default)
   language/statements/class/async-meth-escaped-async.js (strict mode)
   language/statements/for-of/escaped-of.js (default)
   language/statements/for-of/escaped-of.js (strict mode)
   language/statements/for-of/head-decl-no-expr.js (default)
   language/statements/for-of/head-decl-no-expr.js (strict mode)
   language/statements/for-of/head-expr-no-expr.js (default)
   language/statements/for-of/head-expr-no-expr.js (strict mode)
   language/statements/for-of/head-var-no-expr.js (default)
   language/statements/for-of/head-var-no-expr.js (strict mode)
   annexB/language/statements/for-in/bare-initializer.js (default)
   annexB/language/statements/for-in/bare-initializer.js (strict mode)
   annexB/language/statements/for-in/strict-initializer.js (strict mode)
   annexB/language/statements/for-in/var-arraybindingpattern-initializer.js (default)
   annexB/language/statements/for-in/var-arraybindingpattern-initializer.js (strict mode)
   annexB/language/statements/for-in/var-objectbindingpattern-initializer.js (default)
   annexB/language/statements/for-in/var-objectbindingpattern-initializer.js (strict mode)
   language/expressions/object/method-definition/async-meth-escaped-async.js (default)
   language/expressions/object/method-definition/async-meth-escaped-async.js (strict mode)
   language/expressions/object/method-definition/escaped-get.js (default)
   language/expressions/object/method-definition/escaped-get.js (strict mode)
   language/expressions/object/method-definition/escaped-set.js (default)
   language/expressions/object/method-definition/escaped-set.js (strict mode)
   language/statements/class/syntax/escaped-static.js (default)
   language/statements/class/syntax/escaped-static.js (strict mode)

I updated the whitelist.

Is that something we're going to have to do every time we fix a problem?

@marijnh Some of the tests you listed shouldn't pass.  The escaped once to mention a few. Can also add to the record that Test262 doesn't cover all corner cases.

@marijnh Yeah, whenever we fix one of the issues that cause tests to be whitelisted, we have to update the whitelist. Currently, most entries are due to a pretty small number of distinct issues, though.

Merged as a6ee903a087a19a964e6d85ee9c8085142821eaf...e5ee27f9bf605c02d2ea03f75c76a073a24eecab.

Oh, right, I got distracted and forgot to close.


Add lights, textures, and some GX functions

Sorry that the PR is so big, didn't know GX was the biggest module in the library... :sweat_smile:
Summary of changes:

There's now light objects! You can create, adjust, and load lights into the system. Almost all light methods should be in there now (except for GX_InitLightDirv() and GX_InitLightPosv()), and you can load them with Gx::load_light(). Gx::load_light_idx() doesn't currently work since some prerequisite functions haven't been implemented yet.
You can create textures! You can create, adjust, inspect, and load textures into the system now. I think adding user data is the only thing that's missing.
Fifos (aka queues) can now be created, adjusted, inspected, and loaded. The loading functions Gx::set_gp_fifo() and Gx::set_cpu_fifo() currently take ownership of the struct due to the pointer to mutable data.
Added some much needed safety comments in the construction of the objects above.
Textures and fifos take lifetime parameters because they hold pointers to data and I figured adding such annotations would make things safer.
Color is now a wrapper around GXColor.
Made various enums for the different options that can be picked in a function, including the ones for measuring performance like Perf0 and Perf1, along with the appropriate functions that use them.
Added some simple function calls like Gx::abort_frame(), Gx::clear_bounding_box(), etc.

After looking over it a little. It looks great. One or two things.
PixelFormat is sadly still just a u8 instead of an enum.
The example's assert if not used within Gx::init already might be good to include there

PixelFormat is sadly still just a u8 instead of an enum.

Gosh, so demanding :stuck_out_tongue:
Yeah I've considered making an enum for it, but there are so many variants and aliases to values and bitop expressions that I've held back on it until I figure out what a good representation would look like.

The example's assert if not used within Gx::init already might be good to include there

If you're referring to the asserts in the example's Display::new(), they're there because of the safety requirements by the allocation API. Gx::init() does not allocate and just uses the given buffer directly, so I don't see a need to include them there.

If you're referring to the asserts in the example's Display::new(), they're there because of the safety requirements by the allocation API. Gx::init() does not allocate and just uses the given buffer directly, so I don't see a need to include them there.

Understandable

Yeah I've considered making an enum for it, but there are so many variants and aliases to values and bitop expressions that I've held back on it until I figure out what a good representation would look like.

This is exactly why I havent touched it either. Its really hard when there are just too many different  things that really shoud be seperate.
Then it LGTM


[Refactor][RayCluster] Replace RayClusterReconciler.Log with LogConstructor

Why are these changes needed?
As @astefanutti suggested here https://github.com/ray-project/kuberay/pull/1945#discussion_r1503835776, it could be better to use the LogConstructor option to construct a logger because the logger is shared between controller-runtime and the controller itself.
But I then gave the wrong example. Now I would like to fix that.
This PR uses the LogConstructor inside the WithOption call instead of a WithLogConstructor, which will be overridden by the former one, and then removes the no longer neededRayClusterReconciler.Log.
The r.Log loggers in the tests are also removed since they were already not used in tests previously.
Screenshot
This is what the logs look like, including the reconcileID.

Related issue number
https://github.com/ray-project/kuberay/issues/1947
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

Thanks, @rueian and @astefanutti!


Use a native mixer instead of internal/mux

I sometimes find clicking noises on some platforms especially mobiles and browsers. My understanding is that buffer underflows are happening. Now Oto has its own multiplexer at internal/mux, and I suspect this is the culprit, I'm not 100% sure though. Go's scheduler might not be efficient enough to avoid the underflows. The current multiplexer utilizes io.Pipe and channels.
So I think we should switch the multiplexer to native ones. Oto will just give data to each audio buffers, and multiplexing will happen internally. This doesn't require Oto's API changes fortunately [1].
As this is a pretty big change, I'll try to implement one by one, starting with the critical ones like mobiles and browsers. Then Oto will have two types of implementations in the migration period.
Any thoughts? @Noofbiz @faiface
CC @sinisterstuf
[1] Though we don't have to change the API in theory, I think we can have a better API set on second thought. See the below comments.
EDIT: a mixer sounds a better word than a multiplexer (Disclaimer: I am not an English native speaker)

Also, probably we have switch from io.Writer to io.Reader to utilize the native APIs. Assuming that native APIs has play/pause controls and volume controls, the new API will be
type Context interface {
        NewPlayer() Player
        io.Closer
}

type Player interface {
        io.ReadCloser
        Pause()
        Play()
        Volume() float64
        SetVolume(volume float64)
}

As this is a significant breaking change, I don't plan to do that immediately (I think we can use io.Pipe to keep backward compatibility). However, Oto is still v0 so we can add such change in near future.

Also, probably we have switch from io.Writer to io.Reader to utilize the native APIs. Assuming that native APIs has play/pause controls and volume controls, the new API will be
type Context interface {
        NewPlayer() Player
        io.Closer
}

type Player interface {
        io.ReadCloser
        Pause()
        Play()
        Volume() float64
        SetVolume(volume float64)
}

As this is a significant breaking change, I don't plan to do that immediately (I think we can use io.Pipe to keep backward compatibility). However, Oto is still v0 so we can add such change in near future.

I'll implement this brand new API in another package like github.com/hajimehoshi/oto/newoto. As it will take long time to support all the platforms, I'll start to do it one by one.

I'll implement this brand new API in another package like github.com/hajimehoshi/oto/newoto. As it will take long time to support all the platforms, I'll start to do it one by one.

Newoto 🤔 if it would be a second version with a new API a fun play on words could be oto + 2 = otwo 😁

Newoto 🤔 if it would be a second version with a new API a fun play on words could be oto + 2 = otwo 😁

Interesting idea 😄
However, I'll replace the original Oto implementation with newoto in the future, the name here is tentative and not so important :)

Interesting idea 😄
However, I'll replace the original Oto implementation with newoto in the future, the name here is tentative and not so important :)

Resetting the buffer should be necessary (e.g. when seeking or rewinding the source). Then, the API will be:
type Context interface {
        NewPlayer(io.Reader) Player
        io.Closer
}

type Player interface {
        Pause()
        Play()
        Reset()
        Volume() float64
        SetVolume(volume float64)
        io.Closer
}

Resetting the buffer should be necessary (e.g. when seeking or rewinding the source). Then, the API will be:
type Context interface {
        NewPlayer(io.Reader) Player
        io.Closer
}

type Player interface {
        Pause()
        Play()
        Reset()
        Volume() float64
        SetVolume(volume float64)
        io.Closer
}

Interestingly, Linux ALSA doesn't offer a way to play multiple PCM streams from one application.

Interestingly, Linux ALSA doesn't offer a way to play multiple PCM streams from one application.

As there are no objections, I'll start implementing this for browsers first.

As the API can change, I'll implement this in Ebiten, see what's going on, and then port the implementation to this package.

Now I'm implementing the new API's Oto in Ebiten and testing them (https://github.com/hajimehoshi/ebiten/tree/main/audio/internal/readerdriver). After I think this is stable enough, I'll port this to Oto.
I started to think the new API should be v2 rather than v0.x, as the API and the design will be drastically changed. I've not determined yet.

CC @yuikns
The implementation is almost finished and now we are testing. I plan to introduce the new APIs as v2 (then the current version will be v1). Note that v2's context will no longer has Close.

CC @yuikns
The implementation is almost finished and now we are testing. I plan to introduce the new APIs as v2 (then the current version will be v1). Note that v2's context will no longer has Close.

Thank you for your mention. Actually I had already noticed the new API, and trying to use it. I am interested in the macOS, Windows and some embedded machines.

Done!


Remove use of at_exit when creating a VIM object.

at_exit keeps a reference to the connection around for the lifetime of
the process.  This causes memory leaks in long-lived processes that open
many different connections in their lifetime.

Interesting that you bring this up, we actually avoid using RbVmomi::VIM.connect and end up having to duplicate a lot of this because of this at_exit, it makes it impossible to use VCR based spec tests which run multiple times over the length of the process.
That said this makes quick scripts so much easier so removing it probably isn't ideal, but maybe an instance var @closed so connections could be closed by the user at any point while keeping at_exit { conn.close unless conn.closed? }
@jrgarcia wdyt?

Unfortunately, there's no way to remove an at_exit once created.   Even if we change the at_exit, it will still hold a reference to the object and keep it in memory.
Instead, how about an options that can be passed to RbVmomi::VIM.connect that enables/disables the at_exit?  My preference would be no at_exit by default, but I'm good as long as there's a way to not have it.

@seandilda @agrare I need to think about this a bit. I agree that having that at_exit is an issue, but I don't think just removing it would be a good idea. I may give a try to the "optional" at_exit idea, but I want to think over the possibilities first. Thanks for reporting/contributing this @seandilda!

@seandilda Can you see if this branch fixes this issue for you?

Also, if it does fix the issue, feel free to modify your PR to the same thing and I'll just merge your PR so you get credit. You did report and offer a solution for this, so I don't want to take any credit for your work. :smile:

Thanks!  I tested it out and using the option works great.  I've just updated this branch with your changes.

@seandilda @smlsml I just released 2.1.1 with this fix in there. Thanks for helping out with rbvmomi! :tada:


Access files in headless unit tests

Summary
I'm trying to port a rust project from desktop to wasm.
Some unit tests of the project would access local files via std::fs::File::open which does not work on wasm.
I understand it supposed to use fetch to download the files but how can I host them in the server of headless unit tests?
Additional Details
I've tried to put files into wbg-tmp folder but they got removed  at each run

Have you tried using the include_str!/include_bytes! macro? Those are provided by the std lib and include the content of the file at provided path at compile time

Have you tried using the include_str!/include_bytes! macro? Those are provided by the std lib and include the content of the file at provided path at compile time

I would like to have the same function to fetch files when running on production server so static included contents won't work.

For now I'm using npm package serve to serve the project root on another port and use start-server-and-test to run the tests.


bin/rescue: use the realpath

This fixes issue #109.
Since ruby 2.5, require 'pry-rescue' uses the realpath of the
pry-rescue gem. But bin/rescue specify an absolute path to load
'pry-rescue'.
So if 'pry-rescue' is in a path that contains a symlink, it will be
loaded twice, once from bin/rescue (at the absolute path)
and the other one via 'pry' automatic loading of plugins (at the real
path).
Then the pry hooks will be called twice, which yield an error.
See also https://github.com/pry/pry/pull/1762

Merci @DamienRobert !

Great, thanks to you!


Update All Submodules

Update All Submodules.
had to pip install toml to generate the docs, must have been an update that broke it recently.

Thanks!


Python code error

doesn't work

fixed on the chapter 5 problems
probably need to fix chapter 4? idk where was it

Nobody cares
Sent from my OnePlus A0001 using FastHub


License statement

Currently there is no license statement. Could you please add a LICENSE file that contains the license text.
This is requirement for some distribution if they want to ship it as package through their repos.
Thanks.

For the Nixpkgs I marked it as unfree for now. People would still be able to install it but not by default.

Added an MIT liscense.


DOMString attributes getter return as const reference

Impacted Cases
WIDL file with DOMString/String attributes
[
Constructor,
Constructor(DOMString name),
Constructor(DOMString name, unsigned short age)
]
interface Animal {

  // A simple attribute that can be set to any string value.
  readonly attribute DOMString name;

  // An attribute whose value can be assigned to.
  attribute unsigned short age;
};

Or check the onlien version https://github.com/otcshare/widl-nan/blob/master/test/attributes/attributes.widl
Reproduce Test Steps

Get latest code and run 'npm install'
mocha test/test-attributes.js

Expected Outcome
From non-copy consideration, the generated C++ should generate the getter of attribute "name" as const reference
  const std::string& get_name() const {
    return this->name_;
  }

Actual Outcome
  std::string get_name() const {
    return this->name_;
  }

Halton's commit:
Kenny Yuan guolisha Do you think this is a valid bug?


ISSUE-1005: Refactor streamline code to refer FileStorage from registry

Refactored streamline code to refer to com.hortonworks.registries.common.util.FileStorage
Fixes #1005

Thanks @arunmahadevan, merged to master.


Add Column for Name Meaning

Just want to say, I LOVE this project. This is absolutely fantastic!
Noting this here just as an enhancement idea. When naming our babies, we like to consider the meaning of the name.

Glad you like it! I'd be happy to include it -- but where are those data sources? The SSN index doesn't include that.


Skill - Peacebringer

This is just Izana personal skill in Fates, and in practice a VoiceOfPeace that also work on allies
I normally have tested the three required compilation as indiqued in contributing guideline, but I'm not sure if I was supposed to test them in advance.
Skill icon is by me (and is not very good, sorry)

Pre-Battle calc may calculate twice, one for attacker=gBattleActor, one for attacker=gBattleTarget, so I think this patch may acturally cause battle attack - 4? Have you tested it, will it actually -2 rather than -4?

Currently it work like it should and correctly deduce 2 attack, since only the Pre-Battle current attacker has is battle attack deduced.

you are right


Update main branch with changes

Should be updated with last changes to the docs

Made a mistake. Wanted to update the main branch of my own fork.


How to debug "An error occurred while rendering the report" in the desktop

Hi,
I've been struggling for a while with debugging a custom visual which works well but always throws an error when loading in Power BI desktop.  I have many copies of this KPI in a desktop report and I can't figure out why I get this error.  I have 12 copies of this custom visual and I get 12 error messages whenever I open the desktop file which contains the visuals.
"Microsoft.Mashup.Host.Document.JavaScriptException: An error occurred while rendering the report.
at :line 0
Invocation Stack Trace:
at Microsoft.Mashup.Host.Document.ExceptionExtensions.GetCurrentInvocationStackTrace()
at Microsoft.Mashup.Client.ClientShared.StackTraceInfo..ctor(String exceptionStackTrace, String invocationStackTrace)
at Microsoft.Mashup.Client.ClientShared.FeedbackErrorInfo..ctor(String message, Nullable`1 errorCode, String requestId, Exception exception)
at Microsoft.Mashup.Client.ClientShared.UnexpectedExceptionHandler.<>c__DisplayClass1.b__0()
at Microsoft.Mashup.Host.Document.SynchronizationContextExtensions.<>c__DisplayClass3.b__0(Object null)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Delegate.DynamicInvokeImpl(Object[] args)
at System.Windows.Forms.Control.InvokeMarshaledCallbackDo(ThreadMethodEntry tme)
at System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Forms.Control.InvokeMarshaledCallback(ThreadMethodEntry tme)
at System.Windows.Forms.Control.InvokeMarshaledCallbacks()
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Form.ShowDialog(IWin32Window owner)
at Microsoft.Mashup.Client.ClientShared.WindowManager.ShowDialog[T](T form, IWin32Window owner)
at Microsoft.PowerBI.Client.Program.<>c__DisplayClassc.b__0()
at Microsoft.Mashup.Host.Document.ExceptionHandlerExtensions.HandleExceptions(IExceptionHandler exceptionHandler, Action action)
at Microsoft.PowerBI.Client.Program.Main(String[] args)
JS Error Message
Script error."
The visual also works well in PowerBI.com, except the icon doesn't show properly.  I am using the web dev tools to create this as some features aren't supported by the CLI tools.
Any assistance would be appreciated as I have spent a lot of time trying to figure this out myself and am struggling!
FinancialKPI.1.7.2.pbiviz.zip
Thanks,
Tony

Sure, we'll look into this.

Thanks Sachin.
Also when I view a dashboard on an iPhone using this visual, the visual keeps growing in size.  Well the actual boundary of the tile doesn't change, but it seems like the visual is zooming in / growing in size.  I've tested this on the iPad and it does the same thing, BUT it works OK on different Android and Windows mobile devices.  The report containing the visual doesn't zoom, just the dashboard tile.
Where's the best place to raise this issue?  Can I leave it here or raise a different a new request?  I have attached a movie showing the issue...
Zooming visual.zip

@TonyGaul, can you share your pbix file? I created report in the latest version of Power BI Desktop using your visual, and couldn't reproduce this issue.

@v-kazaki Hi Kamil, please find a zip of my issue.  I can reproduce the error, but as mentioned in my documentation I will be working on porting my code over to the new CLI tool soon which may (or may not) fix the issue.
Btw my other scrolling visual issue on the iPhone seems to be fixed with the latest update.  So my second issue can be ignored.
Sample For Microsoft.zip

Thanks, we are looking into this issue.

@TonyGaul, we addresses your issue. As we see there is no problem in your visual and this issue can be reproduced in Power BI Desktop for other visuals also.

Great thanks.  You can close this issue or do what you want with it.  Thanks Tony

Great thanks. You can close this issue or do what you want with it. Thanks Tony


multi-arch images support

Dockerfile updates to support multi-arch image （support docker build too）
github workflow updates

migrate to ghcr.io (see more). need to add a new secret CR_PAT
switch to docker/login-action && docker/build-push-action@v2 for multi arch image build by buildx

examples:
https://github.com/users/morlay/packages/container/package/kubevela%2Fvela-core

Cloud you please explain a little bit of the reason why needs to build into Github CR? For end users, we can use some speed-up service (ie, registry-mirrors) from service providers, like Alibaba Cloud, but for Github CR, I don't know.

@zzxwill
ghcr.io is upgrade of docker.pkg.github.com
https://docs.github.com/en/free-pro-team@latest/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images
But docker.pkg.github.com is not support the new format of multi-arch image. and will never .
docker.pkg.github.com will shut down someday too.

@morlay +1. Cool.

@zzxwill and have to create a personal token of repo owner https://github.com/settings/tokens
and add new secret CR_PAT to repo or group

secret CR_PAT added

@wonderflow

${{ github.event_name != 'pull_request' }} only block PRs. push on other branches could works well. (but now docker.yml already limit for master branch)
ARG TARGETARCH could be empty

@morlay Thanks

🥳  multi arch image lands.

ghcr.io need to make image public here https://github.com/orgs/oam-dev/packages.

Public now

@wonderflow
for release flow. could updates

add on.tags: v* into docker.yml
remove https://github.com/oam-dev/kubevela/blob/master/.github/workflows/release.yml#L95-L109

how do you think?

@morlay  It's good for me.

@wonderflow https://github.com/oam-dev/kubevela/pull/642


Add MacOS to dependency installer

It looks like we have the steps to install dependencies on MacOS in a GitHub action:
https://github.com/The-OpenROAD-Project/OpenROAD/blob/f0685da2f7304ba8d0871377086486522990485a/.github/workflows/github-actions-macos.yml#L8-L45
Is it possible to move this to etc/DependencyInstaller.sh?
I don't have immediate access to MacOS, but I can probably do so soon for a PR.

Sound good to me, it would be just the Install lemon (which can probably be reused from the current code in the installer) and the brew dependencies. The exports would be nice to print at the end as an action item for the user to set or add to their bashrc -- I would avoid trying to make the modification as part of the installer.

whispers https://github.com/donn/homebrew-lemon-graph

@donn Any plans to upstream? :)

What, and deal with Homebrew's arcane requirements for package notability? Nah, I'm good.

It looks like most requirements for upstream are manageable except for "be maintained (i.e. the last release wasn’t ages ago" which we have no control over. Maybe someday someone can make an effort (there are still things being committed on the dev branch?)
@maliberty can we fork @donn's repo and use it during the build process?

@vvbandeira can you elaborate on how your MacOS build is set up? I tried manually installing but I run into issues related to #2097
The latest spdlog available from homebrew is 1.10.0_1 and fmt is 9.1.0. I have the following combinations of spdlog and fmt, and none of them worked:

spdlog
fmt

1.10.0_1
9.1.0

1.10.0_1
8.1.1

1.9.2
9.1.0

1.9.2
8.1.1

Most of the compile errors occur inside the fmt headers such as
/usr/include/fmt/format.h:2493:38: error: expected unqualified-id
template <typename T> constexpr bool isnan(T value) {

+1 - I thought this was just me. I also had trouble compiling OpenROAD for Mac recently but I assumed something was on my side because the CI worked and so I gave up.

Below is our working setup. On my machine, I installed the dependencies when they worked and never updated them by using brew pin. Eder recently broke his setup with a brew upgrade and reported that he was able to get the correct versions following this: https://remarkablemark.org/blog/2017/02/03/install-brew-package-version/
% brew info fmt
fmt: stable 8.1.1 (bottled), HEAD
Open-source formatting library for C++
https://fmt.dev/
/opt/homebrew/Cellar/fmt/8.1.1_1 (27 files, 1MB) *
  Poured from bottle on 2022-03-14 at 17:47:37
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/fmt.rb
License: MIT
==> Dependencies
Build: cmake ✘
==> Options
--HEAD
        Install HEAD version
==> Analytics
install: 68,721 (30 days), 140,452 (90 days), 608,689 (365 days)
install-on-request: 1,967 (30 days), 2,941 (90 days), 9,449 (365 days)
build-error: 2 (30 days)

% brew info spdlog
spdlog: stable 1.10.0 (bottled), HEAD
Super fast C++ logging library
https://github.com/gabime/spdlog
/opt/homebrew/Cellar/spdlog/1.9.2 (95 files, 1.4MB) *
  Poured from bottle on 2022-03-14 at 17:47:38
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/spdlog.rb
License: MIT
==> Dependencies
Build: cmake ✘
Required: fmt ✔
==> Options
--HEAD
        Install HEAD version
==> Analytics
install: 4,343 (30 days), 10,018 (90 days), 24,547 (365 days)
install-on-request: 963 (30 days), 2,186 (90 days), 7,365 (365 days)
build-error: 1 (30 days)

@eder-matheus can you confirm that the versions above are the same you installed? If not, please provide the version combination that worked for you. Thanks

@vvbandeira I have the same fmt version, but a slightly different spdlog version. Check below:
%brew info spdlog
==> spdlog: stable 1.10.0 (bottled), HEAD
Super fast C++ logging library
https://github.com/gabime/spdlog
/usr/local/Cellar/spdlog/1.10.0 (99 files, 1.5MB) *
  Poured from bottle on 2022-08-22 at 19:15:34
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/spdlog.rb
License: MIT
==> Dependencies
Build: cmake ✔
Required: fmt ✔
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 4,343 (30 days), 10,018 (90 days), 24,547 (365 days)
install-on-request: 963 (30 days), 2,186 (90 days), 7,365 (365 days)
build-error: 1 (30 days)

I have already tried both of those combinations and they didn't work.
What compiler versions are you using? I have AppleClang <IP_ADDRESS>60021

Also @vvbandeira why is your spdlog version 1.10.0 but it is installed at /opt/homebrew/Cellar/spdlog/1.9.2?

spdlog: stable 1.10.0 (bottled), HEAD
Super fast C++ logging library
https://github.com/gabime/spdlog
/opt/homebrew/Cellar/spdlog/1.9.2 (95 files, 1.4MB) *

I have already tried both of those combinations and they didn't work.
What compiler versions are you using? I have AppleClang <IP_ADDRESS>60021

@rovinski  Here's my clang version:
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Mine is the same as yours (except as part of Xcode). I have tried simply installing spdlog from source and that doesn't work either.
I've compared build logs from my failing build and the passing CI and I can't find any differences in environment...

For posterity, I finally got OpenROAD to compile on MacOS using fmt 8.1.1 and spdlog 1.10.0. The issue was that my Xcode installation was messed up somehow. I was getting errors about std:: functions not being found, which indicates there was some glibc problem. I uninstalled and reinstalled Xcode (Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)) and it compiled all the way.
I can now continue working on the dependency script 👍


Add isamm to JetBrains

@azizbensalem Please provide us with:

the school official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the school
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the school recognizes the domain which you are submitting as an official email domain for the students.

@azizbensalem You might miss my previous comment. Please react.

@azizbensalem I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for the understanding!


feat(script): add //ts-check to script

📝 Summary

Add //ts-check to script file.
⛱ Motivation and Context

Details here: https://github.com/octoherd/create-octoherd-script/issues/15

Closing PR to leave room for octoherd script to do it in cascade for all scripts

Closing PR to leave room for octoherd script to do it in cascade for all scripts


[ci skip] adding user @StFroese

Hi! This is the friendly automated conda-forge-webservice.
I've added user @StFroese as instructed in #24.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #24

@ocefpaf one last time pls :)

@ocefpaf one last time pls :)


MiP-Android-SDK doesn't work with coder-mip robot

Hello,
It seems that the sdk doesn't work with the coder-mip version of robot MiP.
Could you update the library, please ?

The library was updated.


Fix the master service order

What changes are proposed in this pull request?
Fix the master service order
Why are the changes needed?
Fix the master service order
Does this PR introduce any user facing changes?
NA

@Xenorith

@yyongycy Is there another way to keep the order? Something like implement the public Set<Class<? extends Server>> getDependencies()

@yyongycy Is there another way to keep the order? Something like implement the public Set<Class<? extends Server>> getDependencies()

This is just purely the order in the file, not actually the dependency

alluxio-bot, merge this please!


SFTP slow down due to latency

When filing an issue, please include the following information if possible as well as a description of the problem.  Make sure you test with the latest beta of rclone.
http://beta.rclone.org/
http://rclone.org/downloads/

If you've just got a question or aren't sure if you've found a bug then please use the rclone forum instead of filing an issue.

What is your rclone version (eg output from rclone -V)

Latest

Which OS you are using and how many bits (eg Windows 7, 64 bit)

Windows

Which cloud storage system are you using? (eg Google Drive)

SFTP

The command you were trying to run (eg rclone copy /tmp remote:tmp)

It appears as latency goes up. Transfer speeds go down at an unnatural rate.
https://forum.rclone.org/t/slow-sftp-transfers-compared-to-alternatives/1097/7
At 1ms delay I get 100 MB/s
At 10ms delay I get 73 MB/s
At 100ms delay I get 9 MB/s

I made an issue https://github.com/pkg/sftp/issues/158 to ask for some help with this.

I've been unable to replicate the speedup with FileZilla - was the tests you did with the same files from the same server in the same direction?
Were you uploading or downloading?

Same files, same server, with the test back to back.
I was downloading files for my testing. My upload isnt fast enough to test that direction.

I found a public sftp server to do another test on using this webpage
http://www.sftp.net/public-online-sftp-servers
demo.wftpserver.com:2222	demo-user/demo-user
Downloading only 1 100MB file i maxed my connection at 120mbps with filezilla. i pulled only about 15mpbs with rclone.

This might be fixed by #1561 when done

This implements connection pooling for multiple ssh connections
A connection may be opened for each `--transfers` and `--checkers`
now.  Connections are checked when putting them in the pool and
getting them out the pool so it should recover from network errors
much better.

https://beta.rclone.org/v1.37-076-g5b6585f5/ (uploaded in 15-30 mins)
Please test and reopen the issue if you are still having a problem, or make a new issue with more info.
Thanks

Hmm, it appears that connection pooling, while excellent in itself, doesn't solve the fundamental problem.
I set up a local sftp server and ran
sudo tc qdisc add dev lo root netem delay 50ms

Check that ping localhost gives the expected delay
$ ping localhost
PING localhost (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=100 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=101 ms
^C

(Use this to remove the delay)
sudo tc qdisc del dev lo root netem

To make a 100ms roundtrip delay.
I can get about 18 MB/s with the sftp binary
sftp sftptest@localhost:1GB

Whereas if I try this with rclone I get about 1.5 MB/s
rclone --stats 1s -v copy TestSftp:1GB /tmp

If I try them both with no latency then they are very similar 105MB/s rclone vs 128 MB/s sftp.
I tried a comparison with netcat also.  So running a netcat server in one window
netcat -k -l localhost 9999 </dev/zero

I measured the speed with netcat in another
netcat localhost 9999 | pv >/dev/null

Which came about at about 25 MB/s.
Using a simple go netcat replacement I wrote I get a very similar 26 MB/s
~/Go/netcat localhost 9999 | pv >/dev/null

So it doesn't appear to be a problem with the go TCP stack.  I did try increasing SO_RCV_BUF with no improvments.

@justusiv I've commented further on https://github.com/pkg/sftp/issues/158 - it now looks to me like a bug in that package.  I made an ssh transfer with go at full speed and a tcp transfer it is just the sftp transfers which are slow over a long latency link.

I've managed to fix this issue by using a different interface in the sftp package :-)
https://beta.rclone.org/v1.41-069-gd4213c0a/ (uploaded in 15-30 mins)
Can you give it a test and see if you agree?
In my tests the above works at the same rate as the sftp binary.  This may still be slower than FileZilla but it was over 10 times faster on a 100mS ping roundtrip link.

@ncw maxed my connection at 45MB/s! Thank you so much!

With 1 transfer i am getting 12.5MB/s Not sure if there is a reason at the cap seemingly right at 100Mbps. Either way this light years improvement and am so thankful for the work you guys do.

What is the round trip ping time?  I suspect it is over 100mS.  I guess someone could have made a throttle for sftp at 100Mbit/s but that certainly isn't rclone.
There are probably some more speedups to be gained with some more intrusive changes in the sftp module.  I'm glad we've got to speed on a par with the openssh sftp code though :-)


License

Currently this repository doesn't contain a license file. It would be great if you could add one to clarify under which license the code is made available. Thanks!

No problem! 0f9f470 sets the license to MIT


Feature: add rules engine

Related to #343

Codecov Report
Attention: Patch coverage is 63.04348% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 66.65%. Comparing base (651cb35) to head (f6d6331).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   71.82%   66.65%   -5.17%
==========================================
  Files          45       47       +2
  Lines        2722     2897     +175
  Branches      588      630      +42
==========================================
- Hits         1955     1931      -24
- Misses        582      770     +188
- Partials      185      196      +11

Flag
Coverage Δ

unittests
66.65% <63.04%> (-4.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

..._deployment_toolbelt/utils/computer_environment.py
100.00% <100.00%> (ø)

qgis_deployment_toolbelt/profiles/qdt_profile.py
78.88% <81.81%> (-0.43%)
:arrow_down:

...loyment_toolbelt/jobs/job_profiles_synchronizer.py
42.85% <46.42%> (+1.02%)
:arrow_up:

... and 8 files with indirect coverage changes

With these rules, is it possible to exclude one or more profiles? For example, I want to deploy all the profiles on my repo except foo and bar.


add goreleaser (and fix some tools)

[x] add goreleaser

[x] fix .travis.yml
[x] and some new make targets
[x] fix README

[x] add -x mode into some bash scripts for debugging CI

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   38.46%   38.46%
=======================================
  Files           2        2
  Lines         104      104
=======================================
  Hits           40       40
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf6c88...ffec28e. Read the comment docs.


Sender generates keys with partial secret

Closes #38

Looks good, two points:

the decode_scan_pubkey function was used at first to get the scan key to calculate the ecdh_shared_secret. Since we now give the partial secret, I think we should remove this function too
Can you fix the unused import warning?


EE-2657_preview - Added drafted diagrams

Ticket reference
EE-2657
Overall changes

Added drafted diagrams (poorly formatted for now) of both JSON schemas and JSON examples using PlantUML

Future TO-DOs

[x] Finish a Python script to streamline the whole diagram formatting and creation process
[x] Replace the drafted diagrams with the finished ones.

Good catch, @Dona094. The JSON files for both EGA.analysis_CVhighlights.svg and EGA.analysis_whole.svg do have content but their SVGs are empty. Other examples of empty SVGs are dataset_valid-1_ontologiesSubset.svg, but in this case that is correct because the JSON file for this SVG, dataset_valid-1_ontologiesSubset.puml is empty. There are 2 things I could improve for this matter:

I will re-do the two wrong ones for the analysis.
I could add a check in the script, so that if the JSON is completely empty, the files are not created. I didn't add it before because I wanted the format to be consistent, and not seeing any content in the graph, for me meant that there were no subsets and such. But the way an empty file is rendered in GitHub makes it look like there was a bug or something, so I may add this check and if there's not a file, it's simply because it had no content.

Regarding the error you mentioned: I also found that PlantUML gave some warnings that did not affect the output. So I most likely didn't pay attention to these. It's been some time, but I believe it wasn't an error per se, but probably that PlantUML found an empty JSON and couldn't render it. Perhaps these warnings get solved with the previous check.

Would it be possible to shorten the arrow length so make the diagram more compact as in not overwriting over ref link?
This may be more complex, given the little freedom for now in modifying the format of the graphs that are transformed into SVG. There are other issues, like arrows coming out of properties that are not the correct one because the text is too big and things like that. I plan to:

Create an issue at their repo to request a fix of these incorrect arrows.
Create an issue at their repo for them to not super-impose the arrows onto the text.

Created GH issue for plantUML to fix the arrows: https://github.com/plantuml/plantuml/issues/1334

And... accidentally closed it when commenting... Merging now.


About the feature visualization in your paper

Hello, I'm very happy to read your article. I have some puzzles. If you have time, can you help me to solve them?
How to realize the feature visualization in your article? What format is the data?

Thanks for you interest in our work.
Are you looking for https://github.com/uta-smile/TVT#updates-03102022?


Feature name unseen at fit time

My data is as follows:

I want to train a model which takes previous 10 time steps of all 4 variables rainfall_, dmi_, nino12_ and nino34_ and gives the 11th step of rainfall_ as target. My training dataset is as follows:
Create time_idx and group_id
df = train_df.copy()
df['time_idx'] = df.index
df['group_id'] = 0  # Only one time series

# Define the TimeSeriesDataSet
max_encoder_length = 10  # Number of time steps for the encoder
max_prediction_length = 1  # Number of time steps for the prediction

training_dataset = TimeSeriesDataSet(
    data=df,
    time_idx="time_idx",
    target="rainfall_",
    group_ids=["group_id"],
    max_encoder_length=max_encoder_length,
    min_encoder_length=max_encoder_length,
    max_prediction_length=max_prediction_length,
    # time_varying_known_reals=["dmi_", "nino34_", "nino12_"],
    time_varying_unknown_reals=["dmi_", "nino34_", "nino12_", "rainfall_"],
    lags={"rainfall_": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
          "nino12_":  [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]},  # Include previous 10 time steps of rainfall_
    # lags={
    #     "rainfall_": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
    #     "dmi_": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
    #     "nino34_": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
    #     "nino12_": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
    # }
)

# Convert dataset to a dataloader for model training
train_dataloader = training_dataset.to_dataloader(train=True, batch_size=64)

This is throwing up the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
[<ipython-input-22-0a8da5b66b64>](https://localhost:8080/#) in <cell line: 10>()
      8 max_prediction_length = 1  # Number of time steps for the prediction
      9
---> 10 training_dataset = TimeSeriesDataSet(
     11     data=df,
     12     time_idx="time_idx",

6 frames
[/usr/local/lib/python3.10/dist-packages/sklearn/base.py](https://localhost:8080/#) in _check_feature_names(self, X, reset)
    479                 )
    480
--> 481             raise ValueError(message)
    482
    483     def _validate_data(

ValueError: The feature names should match those that were passed during fit.
Feature names unseen at fit time:
- nino12__lagged_by_1
Feature names seen at fit time, yet now missing:
- nino12_

With

train_df = pd.DataFrame(
    {
        "rainfall": [0.1] * 100,
        "nino34": [0.1] * 100,
        "nino12": [0.5] * 100,
        "dmi": [0.1] * 100,
        "rainfall_": [0.1] * 100,
        "nino34_": [0.1] * 100,
        "nino12_": [0.1] * 100,
        "dmi_": [0.1] * 100,
    }
)

I can confirm this error.
The lags seem only to work for the target currently.
@manmeet3591, according to your use-case above, I assume that you do not need the lags, since the model is getting the past ten values of rainfall and your other unknown variables as input. Lags mean that for each input step the past ten values would be considered.


Performance drop when schema has "uniqueItems" set to true

Hi,
I noticed a major performance drop when the schema has uniqueItems set as true for an array and the json content being a 4mb file has a massive array.
The benchmark test took only about 0.07260 ns/op when set to false and a whopping<PHONE_NUMBER>00 ns/op (~107 sec) when set to true.
Another library from xeipuuv/gojsonschema seems to not have any major time difference when uniqueItems is set to true. So perhaps there is room for improvement here.
The schema used is as follows:
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "array",
  "items": {
    "type": "object",
    "required": ["name", "price", "description"],
    "properties": {
      "name": {
        "type": "string"
      },
      "price": {
        "type": "number"
      },
      "description": {
        "type": "string"
      }
    }
  },
  "uniqueItems": true
}

fixed with caf0c40
@NitinRamesh25 can you verify with this fix

@santhosh-tekuri I have verified with the new change and it works fast when duplicate items are close by in the array.
In case where the first and last element of the large array are duplicates, then it still takes a lot of time.
I would prefer if it runs fast even when no duplicate items are found.
Wouldn't this be faster if we marshal the element to []byte, convert it to a string and store it as the key of a map ?
Since the array elements would be keys of the map, lookups for duplicate data would be faster.

Much thanks. It's faster now.

@NitinRamesh25  just published v5.3.1 with this fix


[BUG]: Onboarding step 11 is slightly confusing

Describe the bug

Related: https://github.com/KittyCAD/modeling-app/issues/1789

On onboarding step 11 it asks you to create new sketch, then select line tool and then click on 3D view. But there seems to be no 3D view button anywhere (Just realized, 3D view is not "button" to click.. It's area where I should select plane.. Maybe  I shouldn't try new 3 at night.. 😅 )

After clicking "Line" twice, I'm able to draw lines, but no idea how to get out of line tool. Tried to click on starting point several times, which seemed to do nothing. Tried to hit ESC too, but that took me out of onboarding flow

Steps to Reproduce

Start onboarding process
Go to step 11
Click on line tool

Expected Behavior
Button to be there or more easily findable
Maybe some tutorial how to exit line tool
Screenshots and Recordings
https://github.com/KittyCAD/modeling-app/assets/6796697/6266c00f-7a89-4126-b46b-c1409cb8e8ea
Desktop OS
Windows 11
Browser
No response
Version
0.16.0
Additional Context
No response

Thanks for the video and the explanation here @McSneaky! You're right the wording here is not clear and doesn't match the UX anymore. The term "3D view" is jargon-y and doesn't even need to be mentioned; people know to just click and draw. Here's what I'm updating that step to say now:
Sketching
Our 3D modeling tools are still very much a work in progress, but we want to show you some early features. Try sketching by clicking Start Sketch in the top toolbar and selecting a plane to draw on. Now you can start clicking to draw lines and shapes.
The Line tool will be equipped by default, but you can switch it to as you go by clicking another tool in the toolbar, or unequip it by clicking the Line tool button. With no tool selected, you can move points and add constraints to your sketch.
Watch the code pane as you click. Point-and-click interactions are always just modifying and generating code in Zoo Modeling App.


Remove support for redirecting after sign in

https://trello.com/c/sgJIkObA/662-authenticate-before-unsubscribing-from-digest-emails
This isn't tested, and isn't used in practice: we always take the
user to their list of subscriptions.

This seems good to me, nice removal, I don't have enough context to know whether it's not used at all though.

Sure, I almost forgot to do the other half of the removal, which should provide the rest of the context: https://github.com/alphagov/email-alert-api/pull/1502. In its commit, I've linked to evidence that it was only speculative.
In summary: it's never actually been used, so nothing depends on it being sent or received i.e. we can merge this PR and the one I linked to above in any order.


Add validator fees to Ratify::BlockReward

Motivation
This PR adds support for paying validators the the transaction fees (excluding the base fee) via the BlockReward ratification.

Closing in favor of #2098.


Extend voice chat mention

Add ability to mention another voice channel due to high demand.
Something like !castv voice_channel (or !castv voice* with wildcard and then mention first occurrence).

il fkn du it

il fkn du it


query.delete!

@rultor release, tag is 0.0.14

@rultor release, tag is 0.0.14

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.14

@yegor256 Done! FYI, the full log is here (took me 7min)


Added edit button to ListItem

I included the library "react-icons" (https://react-icons.github.io/) and created a button that is aligned to the right of each ListItem object. For now, the callback just prints which button is pressed, but it can be rigged up to open an 'Edit' modal or something. Also, I removed the edit button from the List route, since I thought it would be redundant if each item had an edit button.

If everything looks alright on your end I can merge, or if you want to make some edits please feel free.

Looks good. Although I don't know why you added the "align-self-start/end." modifiers to the divs and removed the "align-items-center" modifier from the flex container. I'm pretty sure everything should be aligned to the center on the y-axis?

Also removed the mr-auto class since it isn't necessary with the justify-content-between modifier I had

Will this still work even though there are 3 objects (text, claim button, and edit button)? I could be thinking of something else, but won't there be an equal amount of space between each object? I was thinking that the text would be left aligned, with the buttons being right aligned.

Yeah you're that's what justify-content-between does. And it would be like that if they were all in the same div, but if you put the the claim and edit button in a div together it will just put space between that div and the text which is how it is now. But you could also just do mr-auto on the text like you had.
Oh I see what you mean with those. But "align-..." modifies the cross axis placement for flex objects. So if its a flex row (which it is) that modifies the y-axis. "justify-..." modifies the x-axis.

Ah okay, I see what you're saying.

I'm on my phone right now so I can't really test it out, but if everything is good you can merge and I'll take your word for it


feat: ether transfer modal on swap station

Feature Request
Describe the Feature Request
Definition of done:

[x] Add Modal to add the native ether on Swap Station
[x] Check the design to click and open a modal to add the amount of ether

Describe Preferred Solution

Check the Design to create the modal

Related Code
SwapStation.tsx
Additional Context
The amount of ether added will be updated in Context and will be passed to the Swaplace Contract. For now it's hardcoded 0n, will  have the amount we will set in the modal.

Closed by #387


Feature/code line number

Reference

https://github.com/orgs/marp-team/discussions/164

This version will break the highlight!!


MODLD-312: Authority: Create Meeting resource from marc field 111 - empty subfocus fields

…mpty subfocus

Please fix failing ResourceKindTest

Fixed.


Add more double/duplicate operations tests

Thanks @ajsutton for proposing this new test case.

[no substantive  change] move test_exit_and_bls_change to test_success_exit_and_bls_change
add test_invalid_double_bls_changes_same_block

a block includes the same BLSToExecutionChange of the same validator. The first BLSToExecutionChange will succeed but the second will fail due to the assertion assert validator.withdrawal_credentials[:1] == BLS_WITHDRAWAL_PREFIX.

reviewed and added new double operation tests:

existing old tests:

test_invalid_double_same_proposer_slashings_same_block
test_invalid_double_same_attester_slashing_same_block
test_invalid_double_validator_exit_same_block

added new tests in this PR:

test_double_same_attestation_same_block note: it's valid
test_invalid_double_same_deposit_same_block


No logs on successful Databricks deploy

$ kedro databricks deploy
2024-07-11 09:46:46,203 - kedro.framework.project - INFO - Using `conf/logging.yml` as logging configuration. You can change this by setting the KEDRO_LOGGING_CONFIG environment variable accordingly.
$

No news good news I guess, but this was a bit too silent 😄 Where did it get deployed? And what do I do next?

Fixed in #5. Right now logging is only rudimentary, but I will be improved in the future.


fixes tablet location checks in tabletserver

During write ahead log recovery the tablet server was trying to write a new file and require the tablets current location to be the tablet server.  However at that time the tablet server was the tablets future location and therefore the update failed.  This commit adust the expected location to be the future location during recovery.

@dlmarion  the change gets all of the test running in RestartIT except for killedTabletServerDuringShutdown().  That test seems to be having an additional problem, the scan server is not starting for some reason.


A command to append to a nomination reason

We should have a command to append to a nomination reason, when the current reason is okay and we just want to add information without repeating the entire reason. Like how we have !infraction edit and !infraction append.
The command should have a similar interface to the !talentpool edit reason command, with the only difference between the commands being how it changes the nomination reason.

Sorry for the delayed response. Yes, thank you!


chore(master): release 0.23.0-alpha

:robot: I have created a release beep boop
0.23.0-alpha (2024-01-22)
Features

new (8e0db96)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mafqla/yalis-blog/releases/tag/v0.23.0-alpha :sunflower:


Database movement toolkit deprecated

If you try to find 'Database movement toolkit' in the shared asset library, it is marked as [deprecated].
The reference to Database movement toolkit is deprecated, also confusion between what this tool provides between AX 2012 and D365.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 535ac104-5b8d-4b49-694f-46632156417f
Version Independent ID: e3574d0d-38f0-2b42-3763-f6fe53f2ca8b
Content: Database movement toolkit - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/database/database-movement-toolkit.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

@fraga, thank you for providing this feedback.
@laneswenka, please review the feedback and update the content as needed.


Update database only after confirmation?

I was thinking about writing a package like this one but with one additional feature : update the model table only when the changes are confirmed.
Problem
Imagine a blog where members can write articles, after the article is confirmed, it will be shown on the homepage.
But what if this member want to edit this article?
He update it and wait for the confirmation before the article will be shown on the homepage again (STRICT MODE).
Solution
In order to avoid this "delay", when the article is updated by the member, into the database it shouldn't be modified before the post is confirmed. Instead, a new table should save the updated object and wait for confirmation.
Hope you understood me.

Hello @LonnyX,
Apologies for the delay. I like your suggestion.
Would you be interested in opening a pr?


[W5.7][F11-3] Jeffery Kwoh Ji Hui

PR name should be of the following format:

Thanks for the review


[release-2.44.0] Cherry-pick: Revert 23969 sqlttypes

Fixes #24415
Please add a meaningful description for your change here
Cherry pick #24489 into release-2.44.0 branch.
Justification: #23969 introduced a regression in 2.44.0. It introduces SqlType.TIMESTAMP (micros_instant) logical type when converting from avro logical type TimestampMicros, but this Beam portable logical type is not yet supported in Beam SQL. Similar regression may occur other than Beam SQL where micros_instant is not supported.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @kennknowles

LGTM and I will merge once it is green.

Just a reminder (don't want this PR to block the release) @kennknowles

run java precommit

it was a pulsar flake, but I have time to kick it again to get green

org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic failed again


Bug in Example for ScrollSpy

The example in scrollspy shows this.
var elem = document.querySelector('.scrollspy');
var instance = M.ScrollSpy.init(elem, options);
// Or with jQuery
$(document).ready(function(){
$('.scrollspy').scrollSpy();
});
If not using jquery, document.querySelector only brings back the first element of class "scrollspy". Code should be var elem = document.querySelectorAll('.scrollspy');
Simple fix, but makes for an interesting experience otherwise.
When asking general "how to" questions:

Please do not open an issue here!

Instead, ask for help on StackOverflow or in our Gitter channel.

Read the CONTRIBUTING document Any issues that are violating the contributing guidelines, will be closed!

Search for duplicate or closed issues and make sure to go through our labels.

Prepare a reduced test case for any bugs.

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used:
Browser Name and version:
Operating System and version (desktop or mobile):
Link to your project (if appropriate):

We'll be changing it in the future for all the plugin docs


Tamas Perger @ SLC - added personalisation info to the template

added personalisation info to the template as followup of API changes:
https://github.com/alphagov/notifications-api/commit/55d185f50d39f282644a4a2648140e3dced82881
https://www.pivotaltracker.com/story/show/150674476

Can one of the admins verify this patch?


[Editor Fonts] Add Noto Sans Bold font variant for supported languages.

Adds bold variants of Arabic, Bengali, Devanagari, Georgian, Hebrew, Malayalam, Oriya, Sinhala, Tamil, Telugu and Thai fonts for more consistent editor interface (many editor elements are using bold font since #49148).
Currently, bold font are available only for the main Noto Sans font (Latin, Cyrillic and Greek).
CJK font (composed of Droid Sans Japanese and Droid Sans Fallback, ~5 MB in size) do not have bold variant and is left intact (Noto Sans CJK fonts are about 15 MB for each variant).
Adds about a megabyte to the editor binary size.

Looks like this also updates existing fonts, did you sync with a newer version of the fonts? If so the relevant section in thirdparty/README.md should be updated too (as well as s/NotoNaskhArabicUI_Regular.ttf/NotoNaskhArabicUI*.ttf/).

Looks like this also updates existing fonts, did you sync with a newer version of the fonts? If so the relevant section in thirdparty/README.md should be updated too (as well as s/NotoNaskhArabicUI_Regular.ttf/NotoNaskhArabicUI*.ttf/).

Yes, all fonts are taken from current download from https://www.google.com/get/noto/
I have updated README, and also updated main Noto font (it's no longer have UI suffix, but it's the same font with the same metrics).

Thanks!


Timeout Retry

How to do timeout retry and encryption in go-zero's rpc, I hope there is a case to answer, thank you

https://github.com/grpc-ecosystem/go-grpc-middleware/tree/master/retry


[Feature] Inventory & Item bar

Description
Feature: Inventory & Item bar
In sprint 1, We will implement an inventory function that allows users to close and open. And we will implement an and item bar in order to store basic items.
SubFeature/component (optional)
-Menu that will allow users to interact with using specified keybind
-Logic of the inventory
-Graphic design of the inventory menu
-Graphic design of the item bar
Milestones
List of sub-features you intend to have done and in Master by the end of the sprint.

[ ] Initial graphic design of item bar (Aug. 20)
[ ] Initial graphic design of inventory menu (Aug. 23)
[ ] Basic functionality of item bar (Aug. 26)
[ ] Basic functionality of inventory (Open/Close)(Aug. 28)

Completion Deadline: Aug. 30
Extras (optional)

[ ] Store items in the inventory
[ ] Item bar for consuming certian items
[ ] Logic of item consumption and equipment

Documentation

Main description of feature
User documentation
...

Inspirational Art
-Pixel 2d

-Nebulosa

-Minecraft

Members

Li-Sung Ou (PeterOu8)
Anders Jepsen (Oceanfloor)
Zhenyu Ding (7ayuu)

@notalie @BozenX Feature ticket confirmation

looks good!


how to train hubert-soft content encoder using Mandarin Chinese dataset?

my problem is as title,  how to train hubert-soft content encoder using Mandarin Chinese dataset?
still using the pretrained hubert model to extract Discrete Speech Units ? (encode dataset step) @bshall

Hi， @joan126 . Have you tried using the pretrained hubert model to extract Mandarin Chinese dataset? Need your help!


Issue Ticketing System

Background
Now that we have an operational prototype feature allowing users to 'raise an issue' by clicking a button on the Admin platform, we need to connect that with a back-end solution which sends that content to the Digital team. The objective is to utilise ZenHub and Slack APIs to join up the functionality.
User Story
As a user, I would like the issue I have raised to be submitted to the Digital team so that they can provide a solution.
As the Digital Team, I would like the user's issue details - along with data captured from the background of the page - to be passed to ZenHub so that the issue can be progressed, monitored and tracked to completion.
Feature(s) Description

Capture the content from the 'raise an issue' modal
Compile with the background info captured, e.g. browser, user, exercise etc
Pass to ZenHub using an API and a ticket created in a new workspace
An automated message generated from ZH to the user informing them their issue is being progressed
An automated message sent to digital-platform-issues Slack channel using API that a new issue has been logged
Further details on Miro Board here

Estimate
S-M
Acceptance Criteria

All the content from the modal is compiled with the background info and a new ticket created in ZH in a clearly presented and legible format

User Testing Steps
Add instructions here
Ticket Champion
Name of who raised the issue/ticket.
Happy Story
What would this issue resolve or improve ?
Sad story
What is the pain point with this issue?

Zenhub GraphQL doc: https://developers.zenhub.com/graphql-api-docs/examples


#9 Check connection status and option to reconnect automatically

Codecov Report

Merging #10 into master will decrease coverage by 0.4%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   75.44%   75.04%   -0.41%
==========================================
  Files           4        4
  Lines         619      625       +6
==========================================
+ Hits          467      469       +2
- Misses        152      156       +4

Flag
Coverage Δ

#SwiftKueryMySQL
75.04% <70%> (-0.41%)
:arrow_down:

Impacted Files
Coverage Δ

Sources/SwiftKueryMySQL/MySQLConnection.swift
68.15% <70%> (-1.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e04f6b...1f4118e. Read the comment docs.


Molecule of the Week Doesn't Update

We've already gone past several updates and the molecule of the week is still caffeine

Done


Hierarchical styles for ordered lists

Overview
Hierarchical styles for ordered lists
Allows to enable "hierarchical" style for ordered list, which will render
1. First level
  1.1 Second level
    1.1.1 Second level

connected issues and PRs:
Kaleidos request, no tix :(
Setup

Checkout
npm run start

How to test/reproduce
Repeat after me
https://github.com/lblod/ember-rdfa-editor/assets/769698/68b78801-e7cb-4c16-b82f-749328a47a68
https://github.com/lblod/ember-rdfa-editor/assets/769698/bcc12bfb-5779-4e6a-8084-00537a2f1936
Challenges/uncertainties
Trying to switch to "normal" style (e.g. roman) in the middle of hierarchical list will have no effect, which might not be 100% obvious.
Checks PR readiness

[X] UI: works on smaller screen sizes
[X] UI: feedback for any loading/error states
[X] Check cancel/go-back flows
[X] Check database state correct when deleting/updating (especially regarding relationships)
[X] changelog
[X] npm lint
[X] no new deprecations

@SchrodingersCat00 @brenner-company requested your reviews here to see if it works for you guys

@abeforgit I'll try and give this a look on monday 🤞

@dkozickis Thanks for you effort regarding this PR!
Just to be sure, this is the way we implemented our temporary (forked) version of those hierarchical styles (mostly the same as with this PR, but with some differences):

The ability to change non-hierarchical list into hierarchical list (and the reverse) as mentioned by @abeforgit before. This enables the user to something like in the screenshot below this list. A hierarchical list can both be 'wrapped' (not shown in the screenshot below) and continued by a normal style list.
Within our own version, we limit the usage of the hierarchical list to one instance to avoid nested list of that same hierarchical style list. We do this by disabling the hierarchical list button when needed (see screenshot below).
We've implemented the limitation above also because we've encountered a bug when creating a new hierarchical list that is not starting on the root level if the document and is 'wrapped' by a normal style list (see last screenshot below). In this example, the second instance of a hierarchical list continues the numbering of the last second level item 🤷♂. It seems this same issue is present within this version of the hierarchical list.

I hope this helps a bit, but is a lot to cover of course. If you have any follow-up questions, feel free to ask!

to be clear: limiting to one list on the page is not an acceptable solution for this feature
what is acceptable is only allowing the whole list to be hierarchical, and not allowing different styles for the different levels if the list is hierarchical

I'm not entirely sure it makes sense to be able to switch to normal style in the middle of the hierarchical 🤔 It's not indicated correctly though, as buttons are enabled at all times, that's bad UX.
having the buttons enabled or disabled depending on the list level your cursor is in also doesn't make sense imo. So I'd propose that choosing a non-hierarchical style at any point in the list converts the entire list

to be clear: limiting to one list on the page is not an acceptable solution for this feature

Correct, this was only implemented in our version because we were encountering the numbering issue I mentioned within https://github.com/lblod/ember-rdfa-editor/pull/1156#issuecomment-1995208655. In the meantime, I've heard from @abeforgit, he found a fix for this particular issue 👍

EDIT: it does seem that kaleidos needs to be able to make a list like it seems that kaleidos also needs to be able to make a list like
1
  1.1
    a
      <IP_ADDRESS>

so it does at least make sense for their users

Just a quick remark that is not the case, but I'll try to expand on that this afternoon 🤞

Looks good with the new changes 👍
I'll just need to double check this with Johan to see if everything is covered/correct.

was asked to make a tracking ticket, here it is: https://binnenland.atlassian.net/browse/GN-4754

Johan is giving a thumbs-up for this version, but when demoing I encountered the following issue:
Starting with a regular (type) list that contains a hierarchical list, when you add or remove items to/from that regular list, the numbering of the items within the hierarchical list don't adjust correctly. But when you reload the page (and thus the editor), it's shown the correct way.
https://github.com/lblod/ember-rdfa-editor/assets/18174827/3d5f5bea-c97c-4e73-8440-01edb21fb419

Working very nicely now imo
I'm heavily nitpicking now, but in a situation like here:

It looks like these are 2 different styles on the same level, but that's not the case, the hierarchical is actually a child of the "a" item there. It's completely correct and also behaves correctly, but just because we're quite deep the hierarchical list marker becomes so long that it starts aligning with the parent marker.
Honestly not sure if that's solvable or even really a problem, but just mentioning it in case you have ideas. Otherwise lgtm

I think that would indeed fall within the category of 'if solvable or even really a problem'.

Johan is giving a thumbs-up for this version, but when demoing I encountered the following issue:
Starting with a regular (type) list that contains a hierarchical list, when you add or remove items to/from that regular list, the numbering of the items within the hierarchical list don't adjust correctly. But when you reload the page (and thus the editor), it's shown the correct way.
CleanShot.2024-03-15.at.18.39.14.mp4

good catch! we'll tackle it next week

it seems we still have problems on chrome only

Did a check a few moments ago and, as @abeforgit mentioned, the issue seems to persist within Chrome (Firefox is fine though).

@abeforgit Ok, I'll double check this with Johan again 🤞

Just to be sure, does switching to hierarchical list apply to both parent and descendant lists of a non-hierarchical list type? For example if you want a bullet list within a hierarchical list, that would not be possible?

I've just had a quick call with Johan. Starting with a non-hierarchical list and going into a hierarchical list on the next level is not a requirement for us but having the functionality to (E.g. my previous example) create a bullet (or other non-hierarchical type) list within a hierarchical list (and ending with that) would be a very big plus for the user. Would that be a possibility? 🤞
That way it would be possible to neglect the Chrome bug of course, but would include disabling the hierarchical list button in that case (I think?).

Christ what kinds of lists are they coming up with over there :scream:
@dkozickis you think this is feasible? I can have a look if you won't have time

Christ what kinds of lists are they coming up with over there 😱
You wouldn't believe me if I told you 😅

@dkozickis I'll give this a look when the demo/retro/plan-meeting is finished over here 👍

unfortunately, quite a few issues

can't turn a bullet list into a hierarchical list even though button is active
can't turn a sublist of a hierarchical list into a bullet list (explicitly asked by @brenner-company )
after turning a sublist of a hierarchical list into a flat list, you can't change it back to make the full list hierarchical in any way

see recording for more detail (if the video doesn't work in firefox, try chrome)

I've just tested this locally and I can confirm the issues @abeforgit mentions.

superceded by #1184


ViViT test results

hi @KSonPham
Thanks for the nice work in ViViT！
I am wondering did you train the video transformer (model 2) and test it on the public datasets or not.
If did, would you mind sharing the results and the best model?
Thanks for your great work!

Hi @Claire874
since the model can use the weight from the official ViVit repo. The result should be comparable. At the time, I didn't have the required hardware so I designed this to make use of the given pre-trained weight which is in .npz format.
Best regard,
Pham

Hi @KSonPham
I got a question about embeddings, in your implementation. After the space transformer, I thought [cls]/mean values are fed forward to temporal transformers, but according to the code you provided, I didn't find that. it seems all representations are fed to temporal transformers.


Better error message for unsupported YAML file syntax

Is your feature request related to a problem? Please describe.
The loadYamlContent() expects single-document YAML content, and does not support document separators. If a multi-document YAML file is provided, the current error message surfaced is Unable to parse literal YAML value. Please ensure that it is well-formed.
Example multi-document YAML (this is technically valid YAML content):
abc: 'def'
---
ghi: 'jkl'

Bicep:
var mydata = loadYamlContent('test.yaml') // Unable to parse literal YAML value. Please ensure that it is well-formed (bicep[BCP340]).

Describe the solution you'd like
If possible, it would be nice to surface a more specific error message, e.g. something along the lines of Bicep does not support multi-document YAML content.

Let me look into the Yaml parsing library we are using. There might be something we can do to improve the error message, calling out this isn't supported... But maybe we can bring up a bug to the Yaml parsing library if it's a standard yaml convention.


Invalid data error on aws_monitor_site24x7

Hi Team,
I've already created some configuration in site24x7 using terraform but when I'm trying to configure the monitoring to one AWS account, it returns:
Error: Invalid data.
│
│   with site24x7_amazon_monitor.aws_monitor_site24x7,
│   on main.tf line 19, in resource "site24x7_amazon_monitor" "aws_monitor_site24x7":
│   19: resource "site24x7_amazon_monitor" "aws_monitor_site24x7" {

I've tried to do it with IAM User and by assuming a role the same way I would do it on the Site24x7 console.
Code Sample:
resource "site24x7_amazon_monitor" "aws_monitor_site24x7" {
  // (Required) Display name for the monitor
  display_name = "aws_added_via_terraform"
  // (Required) AWS access key
  aws_access_key = var.aws_access_key
  // (Required) AWS secret key
  aws_secret_key = var.aws_secret_key
  // (Optional) AWS discover frequency
  aws_discovery_frequency = 5
  // (Optional) AWS services to discover. See https://www.site24x7.com/help/api/#aws_discover_services
  // for knowing service ID.
  aws_discover_services = ["3"]
}

I would like to request your help.
Many thanks,
Tiago Domingues

Hi Tiago,
Can you please share us the details requested for debugging via our support channel.
Thanks & Regards,
Jim Billy

Hello Team,
Quick question, is there any plan to release a new version with this enabled?
Cheers,
Tiago

@Tiago-SD Thank you for your patience. We have supported Amazon monitor. Please refer - https://registry.terraform.io/providers/site24x7/site24x7/latest/docs/resources/amazon_monitor


PROPOSAL for updating and improving the CARBON LOGO

Hello, my name is orlando velasquez I am a graphic designer, making contributions to projects with his is my focus, now if you allow me I can create something new for your CARBON project.

We are very happy with where our logo is at right now, thanks for the offer though! We will keep you in mind for the future 🙂

thank you very much excuse me


Views : Aggregation not taken in account

There is a bug when creating views : If we want to aggregate some prices, it does not work.
Here is my View declared on the ListsCreation template. This view is supposed to show elements grouped by Lot and then ordered by Order. We want a Sum on montantecheance, which is a currency field. Here is the template :
<View Name="{4A2FDED4-0E32-4494-A586-B845116689F4}" DefaultView="TRUE" MobileView="TRUE" Type="HTML" DisplayName="Suivi de facturation" Url="/teams/NAN/NA16060004/Lists/Suivi de facturation/Suivi de facturation.aspx" Level="1" BaseViewID="1" ContentTypeID="0x" ImageUrl="/_layouts/15/images/generic.png?rev=44">
             <Query>
               <GroupBy Collapse="FALSE" GroupLimit="30">
                 <FieldRef Name="lot" />
               </GroupBy>
               <OrderBy>
                 <FieldRef Name="ordre" />
               </OrderBy>
             </Query>
             <ViewFields>
               <FieldRef Name="numcommande" />
               <FieldRef Name="LinkTitle" />
               <FieldRef Name="pourcentecheance" />
               <FieldRef Name="montantecheance" />
               <FieldRef Name="dateprevisionnelle" />
               <FieldRef Name="datefacturation" />
               <FieldRef Name="etatfactu" />
             </ViewFields>
             <RowLimit Paged="TRUE">30</RowLimit>
             <Aggregations Value="On">
               <FieldRef Name="montantecheance" Type="SUM" />
             </Aggregations>
             <JSLink>clienttemplates.js</JSLink>
           </View>

The group and order by are working but not the aggregation.
Or maybe you could tell me if i am doing something wrong here.
Thanks and have a nice day

Hi,
Thanks for your feedback. So far we do not support aggregations. I created an issue (https://github.com/SharePoint/PnP-Sites-Core/issues/876) in the PnP-Sites-Core repository, which is the right one for such kind of requests. We will follow up on this request there. I will close this item. Thanks.

This issue was moved to SharePoint/PnP-Sites-Core#924


Fix fish shell initialization

Since fish 3.10 at least, the current way of loading rbenv in fish is misbehaving, at least in some environments:
source: Error encountered while sourcing file '/var/folders/pj/jn249gcn7ddfrjzj2_9mxjhw0000gp/T//.psub.f0iJSWRByB':
source: No such file or directory

This changes the initialization to the method recommended by a fish developer here: https://github.com/fish-shell/fish-shell/issues/6613#issuecomment-586679958

@mislav Sure, there you go.

Actually either my current fix is wrong or I'll have to update the tests. Will take a look later.


Remove unnecessary decimal when serialize json float

Development Task
The following conversion from json to float has different behavior between TiDB and TiKV:
create table t (i INT, j JSON);
insert into t values (0, '3.14e5');
select i from t where cast(j as CHAR CHARACTER SET utf8) = '314000.0';

The TiDB converts it to 314000, and TiKV converts it to 314000.0. TiKV uses the serde-json serialization directly, so this problem comes from https://github.com/serde-rs/json/issues/562 .

It's actually a bug of TiDB. The extra decimal is expected.


feat(tactic/elim_cast): remove cast expressions from goal

still in the traversable series

cast_heq is not quite what I need, I have to use it with transitivity so
I thought I might as well give the combination a name.
I think the other ones are good replacements though. I'll take out mine.
Simon
On Tue, Jul 17, 2018 at 12:47 AM Mario Carneiro<EMAIL_ADDRESS>wrote:

@digama0 commented on this pull request.
In tactic/interactive.lean
https://github.com/leanprover/mathlib/pull/198#discussion_r202893168:

@@ -474,5 +474,18 @@ meta def apply_field : tactic unit :=
propagate_tags $
get_current_field >>= applyc

+/-- elim_cast e with x matches on cast _ e in the goal and replaces it with

x. It also adds Hx : e == x as an assumption.

elim_cast! e with x acts similarly but reverts Hx.
+-/

By the way, the analogue of your cast theorems already exists for
eq.rec_on: heq_of_eq_rec_left, heq_of_eq_rec_right, and eq_rec_heq should
do the trick. (There is also cast_heq which you may have noticed.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leanprover/mathlib/pull/198#discussion_r202893168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVYMqkQYaMMqGDkR1FJQ_mYwDgvlMQks5uHWxUgaJpZM4VRCoR
.


fix: DataGrid in RTL Mode , The left and right arrow keys do the opposite

🐛 Bug Report
When Change Direction to RTL Mode . the DataGrid left and right arrow keys do the opposite
💻 Repro or Code Sample
DataGrid in DemoPage https://www.fluentui-blazor.net/DataGrid
Change Site Setting To Direction To Right To Left
🤔 Expected Behavior
When we press the left key, the movement is to the left and when we press the right key, the movement is to the right
😯 Current Behavior
The left and right arrow keys do the opposite (in RTL)
💁 Possible Solution
🔦 Context
Using a DataGrid with a few columns and a few rows
🌍 Your Environment
Windows10 x64 , Fluent UI v4.10.2 , v4.10.3 , JetBrains Rider v2024

This can unfortunately not be fixed by us as the behavior comes from the underlying web components. In v4.11 you can use Tab+Shift Tab to move between cells. We are looking into adding arrow key navigation.

Example of how this will work in 4.11.0 DataGrid