Initial support for regex_replace on StringViewArray

Which issue does this PR close?

part of  #11025
Rationale for this change
Implement very limited support for regex_replace on StringViewArray.
It is the minimal implementation to run ClickBench queries. I believe fully support StringView requires a bit discussion and much more work. This PR should help us understand the remaining work.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Or that the functionality is limited in some way (like will error / panic on some inputs)?

Sorry I could be more explicit. I added more comments, let me know you thoughts!


Adding University of Chung-Ang University, South Korea

Adding University of Chung-Ang University, South Korea

@ldh019 I am sorry, the domain cau.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


fix: showing the notification activation switch properly

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[X] I have read and understand the pull request rules.

Description
Resolves #5206
Last week there where some performance optimizations (#5025). I noticed some things being a bit buggy afterwards, so I looked into it.

Notifications always showing as disabled when editing.
Tags not being visible.

Type of change
Please delete any options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

[X] My code follows the style guidelines of this project
[X] I ran ESLint and other linters for modified files
[X] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[X] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Hey @louislam, sorry for pinging.
I noticed that the database library used here was also developed by you. Therefore, I think you might be the best person to answer my question.
I've observed a somewhat strange behavior. You can use "?" as a placeholder for values, but it seems to work sometimes and not at other times.
Here, it works without any problems:
https://github.com/julian-piehl/uptime-kuma/blob/aa056bf3085950ebfa249f34a265bb09931d35f7/server/model/monitor.js#L1508-L1514
Here, the question mark doesn't seem to be replaced correctly:
https://github.com/julian-piehl/uptime-kuma/blob/aa056bf3085950ebfa249f34a265bb09931d35f7/server/model/monitor.js#L1523-L1530
And here, it seems that only the first question mark was replaced correctly (which is why I temporarily removed the second one):
https://github.com/louislam/uptime-kuma/blob/dda40610c7ae307681429274430d48b9049c1933/server/uptime-kuma-server.js#L239-L247
https://github.com/julian-piehl/uptime-kuma/blob/aa056bf3085950ebfa249f34a265bb09931d35f7/server/uptime-kuma-server.js#L243-L249
Is this currently a bug in RedBean, or am I misunderstanding how to use these placeholders?

Child Monitors not updating if parent is paused/unpaused

Not an error in https://github.com/louislam/uptime-kuma/pull/5025, but rather how we have always handled this => https://github.com/louislam/uptime-kuma/issues/4696
=> please move any changes to this bugfix https://github.com/louislam/uptime-kuma/pull/5193 instead

Child Monitors not updating if parent is paused/unpaused

Not an error in #5025, but rather how we have always handled this => #4696
=> please move any changes to this bugfix #5193 instead

I’m sorry, but I don’t quite understand what you mean by ‘how we have always handled this.’ When I added the groups feature last year, pausing a group instantly showed the children as paused as well. I've reviewed commits #5025 and the one prior, and I can confirm that the bug indeed originated from #5025.

@louislam I don't recommend shifting the milestone from 2.0.0 to 2.1.0, as the current interface is quite buggy in its current state.

When pausing a group, child monitors aren't updated until page is reloaded.
Tags on Monitors aren't visible in the Tree or Tags Settings Page.
Filtering for Tags isn't possible.
Notifications are always unchecked when editing a monitor.

pausing a group instantly showed the children as paused as well

Yes, but they are not paused. They were just displayed as such.
Please shift changing the display to the PR where they are getting paused.

it looks like the notification broken for Slack
2024-10-16T17:53:24+05:30 [MONITOR] ERROR: Cannot send notification to Superman
2024-10-16T17:53:24+05:30 [MONITOR] ERROR: Error: Error: TypeError: this.extractAddress is not a function
at Slack.throwGeneralAxiosError (/Users/rohitti/Downloads/demo-app/server/notification-providers/notification-provider.js:69:15)
at Slack.send (/Users/rohitti/Downloads/demo-app/server/notification-providers/slack.js:167:18)
at async Monitor.sendNotification (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:1340:21)
at async beat (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:922:21)
at async safeBeat (/Users/rohitti/Downloads/demo-app/server/model/monitor.js:1007:17)


Implement Functions

The issues in this Epic have been all solved. This Epic with be closed as completed.


Reset offsets supervisor API

This PR adds a new API: /druid/indexer/v1/supervisor/<supervisorId>/resetOffsets. This API accepts a reset datasource metadata in the body and only resets the specified partition offsets in the metadata store. Unlike the /reset API, this new API retains any previously checkpointed partition offsets not specified in the payload, so tasks will resume from where they left off. Further, only tasks serving the reset partitions will be restarted.

Description
A few use cases:

A supervisor that is reading from an offset that is invalid -- moved past the retention period, topic recreated, etc. So instead of a /reset that will clear the entire datasource metadata and start from the earliest or latest offset, users can now specify specific partition offsets.
Users wanting some history for a streaming datasource, but not all the way to earliest can also benefit from this API.
With support for multiple kafka streams by a single supervisor, a user can selectively reset a single topic's partition offsets instead of all the topics.

Why not re-purpose the existing reset API endpoint and the associated interface method?

To support backward compatibility with existing clients. The web-console (and possibly other clients) already send an empty body payload to the reset API, so accepting a new body in the existing API will cause some clients to break.

The API flow is as follows:

User submits the reset datasource metadata to the supervisor's /resetOffsets endpoint
Few validations like the stream and metadata type are done before a ResetOffsetsNotice is created
When the notice is handled asynchronously, the reset offsets is done, writing offsets to the metadata store and then restarting the appropriate tasks as necessary

Release note

Users can reset specific partition offsets for a supervisor using the resetOffsets API.

Key changed/added classes in this PR

SupervisorResource.java
Supervisor.java
SeekableStreamSupervisor.java
SeekableStreamSupervisorStateTest.java
TestSeekableStreamDataSourceMetadata.java

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[x] added documentation for new or modified features or behaviors.
[x] a release note entry in the PR description.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[x] been tested in a test Druid cluster.

The CodeQL alert about log entries depending on a user-provided value appears to be flagging existing logging code that's not part of this PR. I think it's a false positive alert.

Ignoring the CodeQL issues per the comment above


Update TraceForgeEvent logging details

Update tracer TraceAdoptedBlock to log the block hash and a list of txids in that block.

Example output: [cardano.node.Forge:Info:61] [2020-02-04 18:08:26.00 UTC] {"kind":"TraceAdoptedBlock","slot":6,"tx ids":"[txid: txid:6875a2f9]","block hash":"a6d8325832257989"}

Update the following tracers to Error severity:
TraceNoLedgerState
TraceNoLedgerView
TraceBlockFromFuture
TraceDidntAdoptBlock
TraceForgedInvalidBlock

Relevant issue: #528

We may want to remove the "txid" string from the Condense CC.TxId instance in ouroboros-network

bors r+


Add exponentional easing functions

Thanks for the pull request :sparkling_heart:
Just some minor notes

Hi, fixed the formatting. Don't know why travis fails though.

@robb I fixed the issue, in 32 bit the expression in the function where resolved as double (and CGFloat is float on 32 bit)

Can you merge master, that should fix matters?

@mikeger 6c72523 seemed to have undone the code formatting in bbb2623

@robb Indeed, fixed it again

Thanks guys, glad that RBBAnimation is of use to you :v:


Atari stuff

All the Atari notes from the PDF

What's the motivation for using the term "option"? "Flavor" is the term that was established in one of the ALE papers.

What's the motivation for using the term "option"? "Flavor" is the term that was established in one of the ALE papers.

The point regarding the wording "Flavor" was raised in a website review that @jkterry1 could comment on.

Atari itself has nothing to do with hierarchical RL and the options framework though. I feel like we should stick with the established nomenclature.

Didn't realise flavor was official nomenclature since I was working off of the PDF reviewing the website. I can change it back to flavor in this case.


Move thoughtbot to HISTORY

As discussed in https://github.com/calleerlandsson/pick/commit/db10ff312c514276c5767bf8c2337f0f16e29515.

Looks good except one tiny nitpick!

Thanks for the feedback! I'll merge this.


Feature/rtl support #190

Added RTL support, including swipe.
Requires a dir prop to be set on each <app-datepicker> component on the page.  This required because code inside the Shadow DOM cannot see any dir attributes set in the main DOM.

Not working with the dialog version.   I'll close this and resubmit when I've got that working.


add test for .csproj that has a nested file

The test should prove that the linting works for nested files also

Hey @M-Zuber thanks for another PR! I'll give it a try and merge later! Sorry I didn't get to this sooner!

It doesn't contain anything too important, so take your time. Cheers.

So I've added a test that depends on recursion of the app.
I hope to implement (in at least a basic sense) a update to the app for this.

Not relevant as of #46


fix: unbreak highlighting regular navbar links

Motivation
Just now noticed that in #5264 I broke highlighting of regular links, so I'm fixing that.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
On the preview site go to any non-doc link, such as "Showcase". In navbar, the corresponding navbar item should be highlighted.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

👍


StoreConfig Vault example configuration non working and misleading

As per title the StoreConfig example for vault is not working on 0.46.0 provider
https://github.com/upbound/provider-aws/blob/main/examples/storeconfig/vault.yaml
Error from server (BadRequest): error when creating "vault-storeconfig.yaml": StoreConfig in version "v1alpha1" cannot be handled as a StoreConfig: strict decoding error: unknown field "spec.vault"

spec.vault is not in schema since v0.41.0
https://marketplace.upbound.io/providers/upbound/provider-family-aws/v0.40.0/resources/aws.upbound.io/StoreConfig/v1alpha1
vs.
https://marketplace.upbound.io/providers/upbound/provider-family-aws/v0.41.0/resources/aws.upbound.io/StoreConfig/v1alpha1

I am closing this since the specified field deprecated.

@turkenf but the example is outdated https://github.com/upbound/provider-aws/blob/main/examples/storeconfig/vault.yaml we need to update the example


[api-minor] Refactor the text layer code in order to avoid to recompute it on each draw

The idea is just to resuse what we got on the first draw. Now, we only update the scaleX of the different spans and the other values are dependant of --scale-factor.
Move some properties in the CSS in order to avoid any updates in JS.

Before discussing https://github.com/mozilla/pdf.js/pull/15722#discussion_r1031492621 any further, there seems to be a "bigger" issue at play here:
I've just checked out your branch locally to test, using the tracemonkey document and searching for "trace".
Here scrolling of search results into view is completely broken for certain zoom values such as e.g. auto (or 125%), however it seems to mostly work for e.g. 100% zoom.
Note that the searching/highlighting itself is working, but it's the actual scrolling of matches that isn't working consistently.

Before discussing #15722 (comment) any further, there seems to be a "bigger" issue at play here: I've just checked out your branch locally to test, using the tracemonkey document and searching for "trace". Here scrolling of search results into view is completely broken for certain zoom values such as e.g. auto (or 125%), however it seems to mostly work for e.g. 100% zoom.
Note that the searching/highlighting itself is working, but it's the actual scrolling of matches that isn't working consistently.

It's because the condition:
https://github.com/mozilla/pdf.js/blob/67741aeaa94956a8f75e756cafc7fcc51d520316/web/ui_utils.js#L127-L128
is no more verified because of rounding errors.
With this patch, the width/height of the text layer are set to something like calc(var(--scale-factor) * XXX) and the page has still its dimensions in pixels, and that leads to a difference of one pixels.
It should be fixed by:
https://github.com/mozilla/pdf.js/pull/15717/files#diff-c48e3561004f5db8f11d5ebab2fd661591222ba911cb4173fbced15f026bac6bR214-R229
I'll use the old way to set the dimensions in pixels and in a next patch I'll change all the dimensions to calc(var.... for all the different layers.

We should likely refactor the scrollIntoView code: it's too easy to break something without noticing it and when I read it I've the impress that it's a mix of unrelated things (especially the while condition).

Both of the web/text_accessibility.js and web/text_highlighter.js file still contain a bunch of unused code, that's no longer relevant after the previous comments above, please remove that to reduce the size of the patch.
Also, with these changes you've made a couple of pre-existing parameters unused; to avoid having to leave comments all over the place I'm just attaching a diff below (to save my time):
diff --git a/web/default_factory.js b/web/default_factory.js
index 108358ffe..50da983e9 100644
--- a/web/default_factory.js
+++ b/web/default_factory.js
@@ -16,7 +16,6 @@
 /** @typedef {import("../src/display/api").PDFPageProxy} PDFPageProxy */
 // eslint-disable-next-line max-len
 /** @typedef {import("../src/display/display_utils").PageViewport} PageViewport */
-/** @typedef {import("./event_utils").EventBus} EventBus */
 /** @typedef {import("./interfaces").IDownloadManager} IDownloadManager */
 /** @typedef {import("./interfaces").IL10n} IL10n */
 // eslint-disable-next-line max-len
@@ -165,9 +164,7 @@ class DefaultStructTreeLayerFactory {
 class DefaultTextLayerFactory {
   /**
    * @typedef {Object} CreateTextLayerBuilderParameters
-   * @property {number} pageIndex
    * @property {PageViewport} viewport
-   * @property {EventBus} eventBus
    * @property {TextHighlighter} highlighter
    * @property {TextAccessibilityManager} [accessibilityManager]
    * @property {boolean} [isOffscreenCanvasSupported]
@@ -178,17 +175,13 @@ class DefaultTextLayerFactory {
    * @returns {TextLayerBuilder}
    */
   createTextLayerBuilder({
-    pageIndex,
     viewport,
-    eventBus,
     highlighter,
     accessibilityManager = null,
     isOffscreenCanvasSupported = true,
   }) {
     return new TextLayerBuilder({
-      pageIndex,
       viewport,
-      eventBus,
       highlighter,
       accessibilityManager,
       isOffscreenCanvasSupported,
diff --git a/web/interfaces.js b/web/interfaces.js
index 9b6f9f313..151a27d03 100644
--- a/web/interfaces.js
+++ b/web/interfaces.js
@@ -168,9 +168,7 @@ class IRenderableView {
 class IPDFTextLayerFactory {
   /**
    * @typedef {Object} CreateTextLayerBuilderParameters
-   * @property {number} pageIndex
    * @property {PageViewport} viewport
-   * @property {EventBus} eventBus
    * @property {TextHighlighter} highlighter
    * @property {TextAccessibilityManager} [accessibilityManager]
    * @property {boolean} [isOffscreenCanvasSupported]
@@ -181,9 +179,7 @@ class IPDFTextLayerFactory {
    * @returns {TextLayerBuilder}
    */
   createTextLayerBuilder({
-    pageIndex,
     viewport,
-    eventBus,
     highlighter,
     accessibilityManager,
     isOffscreenCanvasSupported,
diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js
index 84072703b..cf4186baa 100644
--- a/web/pdf_viewer.js
+++ b/web/pdf_viewer.js
@@ -1629,9 +1629,7 @@ class PDFViewer {

   /**
    * @typedef {Object} CreateTextLayerBuilderParameters
-   * @property {number} pageIndex
    * @property {PageViewport} viewport
-   * @property {EventBus} eventBus
    * @property {TextHighlighter} highlighter
    * @property {TextAccessibilityManager} [accessibilityManager]
    * @property {boolean} [isOffscreenCanvasSupported]
@@ -1642,16 +1640,12 @@ class PDFViewer {
    * @returns {TextLayerBuilder}
    */
   createTextLayerBuilder({
-    pageIndex,
     viewport,
-    eventBus,
     highlighter,
     accessibilityManager = null,
     isOffscreenCanvasSupported = true,
   }) {
     return new TextLayerBuilder({
-      eventBus,
-      pageIndex,
       viewport,
       highlighter,
       accessibilityManager,
diff --git a/web/text_layer_builder.js b/web/text_layer_builder.js
index b0b43dbf1..a9d87be0d 100644
--- a/web/text_layer_builder.js
+++ b/web/text_layer_builder.js
@@ -15,7 +15,6 @@

 // eslint-disable-next-line max-len
 /** @typedef {import("../src/display/display_utils").PageViewport} PageViewport */
-/** @typedef {import("./event_utils").EventBus} EventBus */
 /** @typedef {import("./text_highlighter").TextHighlighter} TextHighlighter */
 // eslint-disable-next-line max-len
 /** @typedef {import("./text_accessibility.js").TextAccessibilityManager} TextAccessibilityManager */
@@ -24,8 +23,6 @@ import { renderTextLayer, updateTextLayer } from "pdfjs-lib";

 /**
  * @typedef {Object} TextLayerBuilderOptions
- * @property {EventBus} eventBus - The application event bus.
- * @property {number} pageIndex - The page index.
  * @property {PageViewport} viewport - The viewport of the text layer.
  * @property {TextHighlighter} highlighter - Optional object that will handle
  *   highlighting text from the find controller.
@@ -45,19 +42,15 @@ class TextLayerBuilder {
   #rotation = 0;

   constructor({
-    eventBus,
-    pageIndex,
     viewport,
     highlighter = null,
     accessibilityManager = null,
     isOffscreenCanvasSupported = true,
   }) {
-    this.eventBus = eventBus;
     this.textContent = null;
     this.textContentItemsStr = [];
     this.textContentStream = null;
     this.renderingDone = false;
-    this.pageNumber = pageIndex + 1;
     this.textDivs = [];
     this.textDivProperties = new WeakMap();
     this.textLayerRenderTask = null;

/botio-linux preview

/botio test

I must add the scale-factor in the generated svg.

/botio test

The page rotation wasn't correctly set in some tests, hence I updated driver.js and the text layer css (the test one) to handle that stuff correctly.

/botio test

/botio test

/botio unittest

/botio makeref


[Right-to-left] Add caveats

[ x] I have followed (at least) the PR section of the contributing guide.

It took me a long while to figure out what's wrong, It should not happen again!
#10823 #16094

What do you think of fixing the core issue (with gg suggested patch) rather than documenting the limitation?

@oliviertassinari if I had time I would try to fix this issue but sadly, I don't...


Virtual calls from closures should be allowed in ctors

Constructor should be allowed to invoke a virtual member in cases where it's creating a thread, a callback and similar continuation call.
class Button
{
    public Button()
    {
        this.Click += delegate { this.Refresh(); }; // no sense check for virtual calls inside callbacks
    }
}

This patch skips delegates and arrow expressions.

Your patch skips DelegateDeclarations, which would be something like:
public delegate void SomeEventHandler(object sender, SomeEventArgs e);

In your example above it's a AnonymousMethodExpression.
An ArrowExpressionClause is something like
public string SomeProperty => "bla";

This also can't appear in a constructor anyway...
Have you seen this warning appear in your example above? Actually, there is a test assuring that we don't show RECS0021 inside of an anonymous method or lambda.

I'll close this one, since it isn't clear if this problem really exists and how this pull request can solve it.


InvalidRequestError: This model's maximum context length

System Info
langchain: 0.0.221
python:3.10.2
Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[X] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[X] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
from langchain.embeddings.openai import OpenAIEmbeddings
from langchain.text_splitter import CharacterTextSplitter
from langchain.vectorstores import FAISS
from langchain.document_loaders import TextLoader
from langchain.document_loaders import TextLoader
loader = TextLoader("my_file.txt")
documents = loader.load()
text_splitter = CharacterTextSplitter(chunk_size=10, chunk_overlap=0)
docs = text_splitter.split_documents(documents)
embeddings = OpenAIEmbeddings()
Expected behavior
I‘m follow the smae code on official wbsite "https://python.langchain.com/docs/modules/data_connection/vectorstores/integrations/faiss",but replace the txt file content with another (http://novel.tingroom.com/jingdian/5370/135425.html),and the CharacterTextSplitter chunk_size set to10 ,or 100 whatever,then the error kept on raising up:InvalidRequestError: This model's maximum context length is 8191 tokens, however you requested 10137 tokens (10137 in your prompt; 0 for the completion). Please reduce your prompt; or completion length.
is this “from_documents” method has some kind of character restriction,or it just dont support Long text？

8191 tokens is the limit set by the OpenAI API. Langchain is respecting this limit by support explicit proxy for OpenAI:
https://github.com/hwchase17/langchain/blob/6d15854cda60823d1c2a8efc395d9c074336bdca/langchain/embeddings/openai.py#L161

I also encountered this problem, but I haven't found a solution yet. I only asked 1+1, and this error occurred. I want to know how to see the content of prompt and completion when he said that the length is exceeded.


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce:]

...
...

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.4
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:201:7)
at WebContents. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
    at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217:13)
    at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:113:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:663:1)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:697:1)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:184:1)
    at /Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:1

Commands
     -2:36.6.0 core:paste (input.hidden-input)
  9x -2:34 core:backspace (input.hidden-input)
     -2:16.9.0 window:save-all (input.hidden-input)
     -1:56.1.0 core:copy (input.hidden-input)
  9x -1:33.1.0 core:backspace (input.hidden-input)
     -1:20.6.0 window:save-all (input.hidden-input)
     -0:51.9.0 core:backspace (input.hidden-input)
     -0:51.5.0 emmet:insert-formatted-line-break-only (input.hidden-input)
     -0:48 core:backspace (input.hidden-input)
     -0:39 autocomplete-plus:confirm (input.hidden-input)
     -0:39 snippets:expand (atom-text-editor.editor.is-focused)
     -0:35.9.0 core:move-left (input.hidden-input)
     -0:34.9.0 autocomplete-plus:confirm (input.hidden-input)
     -0:34.8.0 autocomplete-plus:activate (atom-text-editor.editor.is-focused)
     -0:32.1.0 core:copy (input.hidden-input)
  2x -0:31.2.0 core:paste (input.hidden-input)

Non-Core Packages
editorconfig 2.2.2
emmet 2.4.3

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #11692. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


feat(webp): add webp support (when using sharp)

Add webp support.
I wanted to test the throw when you're using jimp but couldn't figure out how. The thrown error is handled and re-thrown by webpack which is run prior to jest.

@herrstucki: I also need this! Can this be merged?
@ghetolay: The check currently fails, are you still maintaining this PR?

No, I'm not gonna rebase everytime author pushed a new commit.
Fail is just about image's snapshots.

@ghetolay: Could you fork this repository, apply all the PRs and publish? Then I can use the feature right now (and I need it for large background images, browser support is quite decent and webp is best choice for now until FLIF becomes supported).

The fork already exist to do this PR.
You can install npm dependencies with git/github urls, this one should do (didn't test it) :
ghetolay/responsive-loader#1f63c50

Installing ghetolay/responsive-loader#1f63c50 will not work because the lib folder is sadly not included in the github repo.

I tried publishing the master, webp, and webp2 branches on your repo @ghetolay and neither of them worked! I ran into formats.map is not a function.
Which branch would you consider useable?

This is more than 1 year old and I don't remember much since I ended up not using this lib after all.
I'll take a look, try to rebase and add a prepare script.

Ah cool. I actually got it working on this webp2 branch! Although the webp image from a png image was 870kb, whereas manually I was able to bring the file size down to 77kb. quality seems to have no effect at all.
I published it under my companies name as<EMAIL_ADDRESS>So, some work to be done on the quality I guess.

@herrstucki Hello! :)
What's the problem with this PR? I see that the tests fall because the newly generated images do not have the same cache. Anything else? Why hasn't it been merged yet?

Oh, I see, looks like it's just changing the extension of the file, not really converting it to webp.

I am happy to make to either update this branch or make another PR based on this. Can @herrstucki verify that it could be merged? This is nice piece of functionality that many would love to have.

I have created my own loader it does resize images a little differently, but it handles webp. You guys can check it out: https://github.com/ArtyomResh/image-resolution-loader.

Hi all. I added a new branch to my fork that you can use to replace this dependency:
yarn add dscafati/responsive-loader#compiled
it worked for me. While working on this I noticed that this doesn't work with newer versions of sharp. So you shouldn't use anything newer than version 0.21.0. In the master branch I added support for sharp 0.24.1 (the latest version at the time of this comment) but I didn't compile this version. You compile with yarn build. If you remove /lib from .gitignore then you can commit it to your own repo as I did and use directly as a dependency

Hi everyone! I'm super-sorry that I didn't have time to respond earlier. As a matter of fact, I probably won't be able to review this any time soon.
So I propose to hand over ownership over this repo and the npm package to someone else. Or alternatively mark this repo as deprecated and point to one of the forks. I've opened a new issue for this to discuss: #104

For those watching this thread, I updated my master branch with a version that could be merged into this repository. It's supporting webp through the sharp library (not jimp). PR #103


Installation error on Windows 11

It seems that pip cannot install this package on Windows 11 because of an error in the setup.py file.
pip version: 22.3
Here is the output of the command:

Should be fixed now, try again.

Yes, im looking to fix this problem, try the new instructions while its getting fixed.


Fix URL to be much more consistent between bgee versions!

In GitLab by @smoretti on May 8, 2017, 15:17
Need to be more consistent for URL to not mix links between bgee versions!
Bgee http links come from:

bgee.properties file org.bgee.webapp.bgeeRootDirectory = http://bgee.org/ variable. SHOULD BE http://bgee.org/bgeeX/
dataSource table baseUrl = http://bgee.org/. SHOULD BE http://bgee.org/bgeeX/

Bgee FTP links come from:

bgee.properties file org.bgee.webapp.ftpRootDirectory=ftp://ftp.bgee.org/current/ variable. SHOULD BE ftp://ftp.bgee.org/bgee_vX/ WITH bgee_vX a symlink to bgee_vX_Y
bgee.properties file org.bgee.webapp.download.......... variables. SHOULD USE org.bgee.webapp.ftpRootDirectory variable!!!!

Also add version in web.xml of the WAR!
NO global ${filter.org.bgee.webapp.XXX} variable(s) for FTP URLs

In GitLab by @smoretti on May 29, 2017, 16:00
Need to be done with @vrechdelaval

In GitLab by @smoretti on Sep 20, 2017, 16:13
Fixed for bgee URL in dataSource table

In GitLab by @smoretti on Sep 20, 2017, 16:50
See https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html for filtering/substitution of properties by maven

In GitLab by @smoretti on Oct 2, 2017, 11:47
Try with settings_prod.xml file to build a war now!

In GitLab by @fbastian on Feb 6, 2018, 10:27
I think we can close this issue following the solution adopted for setting parameters @smoretti (addition of a README.md file in the webapp and of a maven setting example file).

In GitLab by @smoretti on Feb 20, 2018, 14:31
Still this one should be fixed to help visualizing bgee war version in tomcat manager:
Also add version in web.xml of the WAR! (in <display-name> tag)

In GitLab by @fbastian on Feb 20, 2018, 20:24
I personally disagree with the display-name modification: I think it's boring to see the version in my browser window title.

In GitLab by @fbastian on Feb 20, 2018, 20:57
Hmm, the display-name is not displayed in the browser actually? :x I was sure to have seen a change in web.xml impacting the window title :/ But it doesn't seem so.

In GitLab by @smoretti on Feb 21, 2018, 09:28
It looks to be only used in the tomcat manager http://bioinfo.unil.ch/manager/html


Adding readonly files during compilation will not refresh the tab list

Changing a tab will refresh the list though

now the tab list display anyway only opened files...


can't install sharp on MacOS

Hello, please can you delete the /Users/caihao/.npm/_libvips/libvips-8.7.0-darwin-x64.tar.gz file and try again.
(The zlib: unexpected end of file error suggests there might have been a temporary network problem when downloading it originally.)

Thanks a lot, But here in lies another problem

If you're using Electron then the use of electron-rebuild is required.
(If possible, please copy and paste error messages as text rather than take screenshots as that makes it so much easier for everyone to read.)

Hope this helped, please re-open with more details if not.


Feature Request: Fingerprint Unlock

I know that the fingerprint scanner isn't the most secure method of authentication, but I think it would make this app significantly better. Having to type your password in all the time, make this app painful to use. To increase security, you could require that the user enter their password, every time the phone is restarted.

Thanks. @akshatgoel wanna take a shot at his?

Although this is cool to have but I have a different opinion on this. Currently, having a separate password for Sealnote gives us 2-factor authentication for password protected devices.
Moving it to fingerprint unlock will result in single-factor authentication.
I have not worked much with fingerprint-unlocked devices so if you have any idea on how people work with it, we can think of a good approach to tackle this. Thoughts?

@akshatgoel You are right actually. It offers convenience but kind of defeats the purpose of second password. The password will have to persist in disk, which makes this not ideal. We don't save password in bundle right? It stays in memory and erases with time?
On other hand, API wise, seems like even though its for newer Android, we may not have to drop support for older versions. https://developer.android.com/about/versions/marshmallow/android-6.0.html


Add [Binance Withdrawals binance.com] #exchange GC5LF6…D6Z6FH

Address: GC5LF63GRVIT5ZXXCXLPI3RX2YXKJQFZVBSAO6AUELN3YIMSWPD6Z6FH
Tags: exchange
Title: Binance Withdrawals  Domain: binance.com
Requested by @jesse6484

Hello @jesse6484,
You can follow the discussion with your original posted issue https://github.com/stellar-expert/public-directory/issues/442


Change packet size

Hi Ahmet,
It's been a while since I experimented with your modem.  As far as I know, it supports two fix packet sizes: 5380 bytes for the default code branch, and 170 bytes for the short code branch.
I'd like to use your modem with Reticulum, but unfortunately that network stack expects an MTU of 500 bytes.  With Reticulum supported, you wouldn't have to deal with questions for AES or RC4 support in Rattlegram.  All encryption and authentication is dealt with by Reticulum.
The best I could do now is to send three packets of 170bytes, but that's rather inefficient.  I wonder how much work it would be to e.g. increase the packet size of 170 threefold to 510 bytes.
Best regards,
Christoph

please look in the next branch

Thanks for reporting. It should be fixed with: https://github.com/aicodix/code/commit/019adfa609ac6d1bc1c5dd8c5c70ab9097069643

Yes, the compile error is fixed.  Thanks.


Adding a module in an empty folder throws error

 Issue by marktani
Friday Sep 22, 2017 at 19:14 GMT
Originally opened as https://github.com/graphcool/cli/issues/258

mkdir algolia
graphcool module add graphcool/modules/syncing/algolia

Downloading module graphcool/modules/syncing/algolia from graphcool/modules ... ✔
 ▸    Cannot read property 'modules' of undefined

graphcool module has been replaced by graphcool add-template: #720.


Change license to MIT

As already discussed privately, it would be good to change the license of this project from LGPL to MIT. This PR implements the necessary changes (and I hope I forgot nothing).
In order for this license change to go into effect, all authors who have contributed to this repo need to agree (by approving this PR). Apart from myself, this includes @MatejFranceskin and @jasells.

@jasells Ping! Are you ok with this? Any comments on the changes here?

@jasells Ping! Are you ok with this? Any comments on the changes here?

I added the guthub url to the liscense and pushed to your branch, but it doesn't show here... yet?  I dunno why it doesn't show here.

@jasells Ping! Are you ok with this? Any comments on the changes here?

I added the guthub url to the liscense and pushed to your branch, but it doesn't show here... yet? I dunno why it doesn't show here.

Ok, there it is.  Guess it just took longer than I expected to update the PR view here.


fix(client) resolve FQDNs ending in dots

what are the semantics of a name ending with a dot? are they to be treated as fqdn names? so no domain searches etc?

Yes, the dot at the end means the name is unambiguous, there's nothing else to search.


Obscure crashes when running multiple threads with a shared task queue

Godot version:
3.0.5
3.1 alpha2
OS/device including version:
Windows 10
Ubuntu 18.04
Issue description:

Because Thread.start() is slow, we implemented a pool of constantly running Thread workers which tasks can be delegated to. It uses a blocking queue which Thread workers pull tasks from.
A multitude of non-specific errors can occur when running a test implementation of this. (see example project below)
When trying to spawn more than one thread at the start, the project often immediately exits with Nothing read: Invalid argument in the editor console, and  drivers/windows/stream_peer_tcp_winsock.cpp:203 - Server disconnected! in the output. Occasionally, especially when running more than 10 threads, I also get a Windows error telling me that the application tried to access RAM at 0xFFFFFFFFFFFFFFFF.
When choosing a thread number that does not immediately crash, crashes usually occur later on, especially when delegating more than 1 task per tick. These come in different forms. Firstly, while running the application, the Debugger error log often shows this in inconsistend intervals (without crashing):
Condition 'idx == -1' is true.
Condition 'data.parent' is true.

When a crash occurs, there is usually no error in the Debugger log. Very rarely, I do get these on a crash:
0:00:03:0731 - Condition ' !mem ' is true. returned: __null
----------
Type:Error
Description:
Time: 0:00:03:0731
C Error: Condition ' !mem ' is true. returned: __null
C Source: core/os/memory.cpp:139
C Function: realloc_static

0:00:03:0733 - Condition ' !_ptrnew ' is true. returned: ERR_OUT_OF_MEMORY
----------
Type:Error
Description:
Time: 0:00:03:0733
C Error: Condition ' !_ptrnew ' is true. returned: ERR_OUT_OF_MEMORY
C Source: core/vector.h:296
C Function: resize

0:00:03:0734 - Condition ' err ' is true. returned: true
----------
Type:Error
Description:
Time: 0:00:03:0734
C Error: Condition ' err ' is true. returned: true
C Source: core/vector.h:355
C Function: push_back

While at other times, I once again only get Nothing read: Invalid argument in the editor console, together with:
ERROR: read: Server disconnected!

   At: drivers/windows/stream_peer_tcp_winsock.cpp:203

Interestingly, the application seems to get more unstable the more often it has crashed. This and the occasional errors related to memory seem to hint at a memory leak or something similar.
Minimal reproduction project:
ThreadTest.zip
This is the example project we have tested the Thread workers with. I put it in a stable state here. The crashes can be reproduced by uncommenting these lines in Main.gd, thereby delegating more tasks:
#ThreadPool.enqueue_task(ThreadPool.Task.new(self, "add_and_print", [1, 3]))
#ThreadPool.enqueue_task(ThreadPool.Task.new(self, "add_and_print", [1, 4]))

or by increasing the THREAD_COUNT in ThreadPool.gd, thereby spawning more threads at the start.

The timer in add_and_print() seems to have something to do with it - removing it prevents the crashes. In our actual project, we get similar results when removing a scene.instance() call, which is supposed to be done in a thread.
If I'm not mistaken, according to the documentation, those functions should be thread-safe, so what's going on there?

Just revisited this example project, of course directly adding the timer as a child is an issue. It would be great to have better error messages for this, however.
I'll close this for now since I assume that's not a priority. I still have issues with threads in my actual project though, where no add_child is called directly... I will try to make a better example project and a more specific issue once I figure out the details.


[WOR-1399] Fix bug with bringing up ShareWorkspace modal from the Workspaces list view (GCP workspace)

Ticket: https://broadworkbench.atlassian.net/browse/WOR-1399
This bug was introduced about a week ago. The issue is that the ShareWorkspace modal can be opened in two ways-- from the Workspace Dashboard, and from the Workspaces List. The properties populated on the workspace are not automatically consistent as a result of different Ajax calls being used (individual workspace details vs. workspaces list API), and thus workspace.bucketName was not being fetched in the list result.
I added workspace.bucketName to the properties requested in the list API call, as well as policies which had a special workaround for in the menu code.
I don't know a good way to add test coverage for this, outside of an integration test where we actually bring up the dialog from the list view (which is not attractive). I have manually tested opening all workspace menu options from both the list and dashboard view, for both an Azure and a GCP workspace.

not to be the wet blanket here … is there a solution where we pull the bucketName and policies on-demand, once a user actually opens the share modal?
Otherwise, we are adding bytes and in-browser memroy to the workspace list call for everyone, which is already slow - and in many cases we are then ignoring those bytes because the user isn't sharing a workspace.
I won't block merge of the PR on this comment, I just want to continually poke at how to optimize performance of these slow pages.

I believe bucketName is already stored on the Rawls workspace database object, and the name itself isn't very long, so I don't see that it adds much of anything. policies comes from WSM, but we are already getting the WSM context object and returning policies in the Rawls code even if policies wasn't requested. Therefore the only hit will be on the size of the policies array, which should be fairly minimal in usage/number at this point.

I don't see that it adds much of anything

I checked my personal workspace list in prod; adding the policies and bucketName increases the (uncompressed) payload from ~1.4MB to ~1.6MB (1,417,842 to 1,564,033 bytes). I curled both configurations, saved the result to disk, and looked at the size on disk.

@davidangb You have convinced me. I will extend the information used for the menus to include policies and bucketName on demand (https://github.com/DataBiosphere/terra-ui/pull/4556).


Adding support for ZSH_AUTOSUGGEST_BUFFER_MIN_SIZE to disable suggestions on small buffers

As the title states, sometimes suggestions on small buffer can get annoying especially for 1-3 characters. These changes add support for a buffer min size. Added/updated tests accordingly.

Very odd, I cannot seem to figure out the reason for the yank-pop test failures. It seems something very specific or OS/system related, as running the tests locally with the provided docker image is always successful for me. I'll leave this open


Adding Playground Sample App Examples to Docs [2/4]

Add example Mercury's authorization schema to our documentation: https://play.permify.co/?s=mercury&tab=schema
It's expected to follow following context in the documentation page:

Schema
Brief Examination of the Model

Entities & Relations
Permissions
Relationships

Test & Validation
Using Schema Validator in Local

Example documentation pages for sample apps: https://docs.permify.co/docs/getting-started/examples/

Please assign me!

Hi @saifxd7, assigned. Happy hacking


Scroll view: scroll indicator insets not honored (but content inset is)

On iOS 14 and on iOS 15, I have the same problem: I can't change the scroll indicator insets.
.introspectScrollView {
    $0.contentInsetAdjustmentBehavior = .never
    $0.automaticallyAdjustsScrollIndicatorInsets = false
    let Δ = UIApplication.shared.windows.first?.safeAreaInsets.top ?? 0
    $0.contentInset = .init(top: Δ, left: 0, bottom: 0, right: 0)
    $0.scrollIndicatorInsets = .init(top: Δ, left: 0, bottom: 0, right: 0)
    print("Top padding: \(Δ)")
}

Δ is 44 on an iPhone X; the contentInset is honored, but the scrollIndicatorInsets are not (even though I disabled automatic adjustments as you can see).
This may well be a bug of SwiftUI itself where it takes precedence.

Can you share if you found any solution? @cyrillelegrand

@keremcesme The solution is to use verticalScrollIndicatorInsets:
.introspectScrollView { scrollView in
    scrollView.verticalScrollIndicatorInsets.top = 10
    scrollView.verticalScrollIndicatorInsets.bottom = 40
}

Tested only on iOS 15.


Map source elements to a specific instance in a target array

See #2007
POC of the json implementation (backend only atm)

Targets #1253

Doh, I solved your comment by error... Anyway. As far as I can see, CollectionActions is necessary because otherwise the action doesn't show in the UI. More than this, it's the Processor behavior that defines the multiplicity of the action (see comment in CollectionActions) and so the fact that it's correctly displayed for one-to-many mappings.

Ah that's right, it seems field action service requires logic classes to be resolved as well to build a list of action metadata used for UI. I think this is ready to merge then.

@vratojr Oops, I forgot to ask adding feat: prefix for a commit message, here is a reference for next time
https://github.com/atlasmap/atlasmap/wiki/AtlasMap-Developer-Memo#commit-message


Prevent cycle in roles hierarchy

Move validations from RolesMetadata to TransportPrivilegesAction
This is a preparation step to check for cycles in roles hierarchy, which needs Roles service to be available, which is not for RolesMetadata. So, in order to keep the validations in one place, move also the check to not grant a user to another user or role.

Prevent cycles when granting roles
Previously, we allowed them, and we infitine loops were avoided during calls of hasPrivilege method. Since we want to properly handle DENY in parent roles hierarchy, it will complicate the code of hasPrivilege a lot, so instead, prevent from creating cycles in the first place, when granting roles to other roles or users. This way we are also in sync with PostgreSQL which also detects and prevents cycle for GRANT statements.

Follows: #15249
Follows: #15271
Relates: #12109

Please note that detecting loops in hasPrivilege may still be required in the future for AD integration where groups membership is managed outside of the db.

Thx @hlcianfagna!
I'm not sure though if we want to have this detection now, @seut what's your take on this?

Please note that detecting loops in hasPrivilege may still be required in the future for AD integration where groups membership is managed outside of the db.

Thx @hlcianfagna!
I'm not sure though if we want to have this detection now, @seut what's your take on this?

Afaik, no AD integration of other DB's will resolve roles and privileges dynamically, but require a manual sync of them.
Even if we would do it dynamically (which I wouldn't), we could add such a logic later on.

Afaik, no AD integration of other DB's will resolve roles and privileges dynamically, but require a manual sync of them.

For reference the way it works in MSSQL is that the kerberos token presented by the client has the list of all the groups the user belongs to, even indirectly. In MSSQL the groups map (eventually via logins and database users) to database roles, and within database roles circular definitions are not valid.


space available calculation mistake

when we calculated the space available for single side staking, we have a mistake in the calculation.
this mistake is on the frontend only.
we currently calculate the available BNT as maxSystemNetworkTokenRatio * bntReserveBalance.
current calculation:
// allowed BNT based on ratio cap
const maxRatioBnt = zeroIfNegative(
new BigNumber(maxSystemNetworkTokenRatioDec)
.times(bntReserveBalance)
.minus(systemBNT)
);
in fact, this should be slightly different.
updated calculation:
maxRatioBnt = ((bntReserveBalance * maxSystemNetworkTokenRatioDec) - systemBNT)/(1-maxSystemNetworkTokenRatioDec)
example:
values:

bnt reserve balance = 200
system bnt = 100
max sys ratio = 50%
calculation:
maxRatio = ((200*0.5)-100)/(1-0.5) = 0
which means, pool has minted the max allowed based on this ratio.
IF maxRatio<0, set it to 0

example using yfi numbers:
pool token: https://etherscan.io/address/0xaeb3a1aed77b5d6e3feba0055d79176532e5ceb8
converter: https://etherscan.io/address/0x9258af079065857c01466cebdcfa2cfb6aa4983c#readContract
YFI reserve balance: 22.823617377346322429 YFI
BNT reserve balance: 549,542.316191026070027217 BNT
pool token supply: 2,988.7630212873065
sys balance: 1430.881844360983306284
sys balance to bnt:
existing calculation:
// calculating the systemBNT  from system pool tokens
const rate = bntReserveBalance.div(poolTokenSupply);
const systemBNT = poolTokenSystemBalance.times(rate);
using the above numbers:
const rate =<PHONE_NUMBER>91026070027217.div(2988763021287306579185);
const systemBNT = 1430.881844360983306284.times(183.869484558); =<PHONE_NUMBER>86 BNT
using new calculation:
maxRatioBnt = ((bntReserveBalance * maxSystemNetworkTokenRatioDec) - systemBNT)/(1-maxSystemNetworkTokenRatioDec)
maxRatioBnt =  ((549,542.316191026070027217 * 0.5) -<PHONE_NUMBER>86)/(1-0.5) = 23351.301819
converting maxRatioBnt to YFI = maxRatioBnt * 22.823617377346322429/549,542.316191026070027217 = 23351.301819* 0.00004153204 = 0.96982720119 YFI
compared with the current calculation:
// allowed BNT based on ratio cap
const maxRatioBnt = zeroIfNegative(
new BigNumber(maxSystemNetworkTokenRatioDec)
.times(bntReserveBalance)
.minus(systemBNT)
);
= 0.5 * 549,542.316191026070027217 -<PHONE_NUMBER>86 = 11675.6509095 BNT (which is half the amount it should be based on the new calculation)

In this new test I've created...
  test("results are as expected from #621", () => {
    const yfiReserve = expandToken("22.823617377346322429", 18);
    const bntReserve = expandToken("549542.316191026070027217", 18);
    const poolTokenSupply = expandToken("2988.7630212873065", 18);
    const systemBalance = expandToken("1430.881844360983306284", 18);

    const { maxAllowedTknWei } = calculateMaxStakes(
      yfiReserve,
      bntReserve,
      poolTokenSupply,
      systemBalance,
      expandToken(5000000, 18),
      "500000",
      false
    );

    const numberRes = Number(shrinkToken(maxAllowedTknWei, 18));
    expect(numberRes).toBeCloseTo(0.96982720119);
  });

We're expecting the result to max allowed TKN to be 0.96982720119, what can we expect the max allowed BNT to be using the same params?

Now pushed to staging, awaiting test for prod.

testing on staging:
few possible issues:

data you use on the frontend might be different from what i was pulling from thee blockchaini
calculation is not the same as below
frontend indication is not aligned with the calculation
when you display a limit and a user add the full amount, how is it that the following transaction can add about 50% of the previous limit again?

1st run
xxxbnt pool.
bnt reserve: 502,457.906853178719914057
xxx reserve: 232,703.305995522538513417
pool token supply:<PHONE_NUMBER>00822047190139
sys balance in pool token:<PHONE_NUMBER>81192441640069
sysBNT = (bnt reserve / token supply) * sys balance
*sysBNT = (502,457.906853178719914057/263383.686800822047190139)131181.180381192441640069 =<PHONE_NUMBER>42
maxRatioBnt = ((bntReserveBalance * maxSystemNetworkTokenRatioDec) - systemBNT)/(1-maxSystemNetworkTokenRatioDec)
maxRatioBnt = ((502,457.906853178719914057 * 0.5) -<PHONE_NUMBER>42)/(1-0.5) = 1948.38696918 BNT
maxRatioTKN = maxRatioBnt * (tkn reserve balance / bnt reserve balance)
maxRatioTKN = 1948.38696918 * (232,703.305995522538513417 / 502,457.906853178719914057) =<PHONE_NUMBER>99 XXX
frontend showed me that there was space for 115,000 XXX,  while this calculation shows iit can only support 902 XXX
i was able to add 115,000 XXX to the pool single sided.
at this stage, UI shows me there is space for additional 55,000 XXX
2nd run
xxxbnt pool.
bnt reserve: 752,202.065362831708305057
xxx reserve: 348,367.305995522538513417
pool token supply:<PHONE_NUMBER>36331659355271
sys balance:<PHONE_NUMBER>48947247722635
sysBNT = (bnt reserve / token supply) * sys balance
*sysBNT = (752,202.065362831708305057/394297.214736331659355271)196637.944348947247722635 =<PHONE_NUMBER>96
maxRatioBnt = ((bntReserveBalance * maxSystemNetworkTokenRatioDec) - systemBNT)/(1-maxSystemNetworkTokenRatioDec)
maxRatioBnt = ((752,202.065362831708305057 * 0.5) -<PHONE_NUMBER>96)/(1-0.5) = 1948.38697083 BNT
maxRatioTKN = maxRatioBnt * (tkn reserve balance / bnt reserve balance)
maxRatioTKN = 1948.38697083 * (348,367.305995522538513417 / 752,202.065362831708305057) =<PHONE_NUMBER>63 XXX

@Velua
after long debugging, this is the updated calculation which will show you the amount of TKN the pool can accept (single side staking).
if you use percentage as a value between 0-1:
(tknBalance * p - sysBalance * tknBalance / totalSupply) / (1 - p)
if you use ppm:
(tknBalance * p - 1000000 * sysBalance * tknBalance / totalSupply) / (1000000 - p)
actual code using ppm:
tknBalance.mul(p).sub(sysBalance.mul(tknBalance).mul(1000000).div(totalSupply)).div(1000000 - p)
example using xxxbnt pool data:
pool token supply:<PHONE_NUMBER>04086465437837
XXX reserve: 406,199.305995522538513417
BNT reserve: 877,074.144617658202500557
sys pool balance:<PHONE_NUMBER>32824650763918
maxRatio = 500,000 in ppm = 50% = 0.5
(tknBalance * p - sysBalance * tknBalance / totalSupply) / (1 - p)
=> ((406,199.305995522538513417 * 0.5) -<PHONE_NUMBER>32824650763918 * 406,199.305995522538513417)) /<PHONE_NUMBER>04086465437837) / (1 - 0.5) = -405296.066118 TKN
** IF result <0, set to 0**
example using yfibnt (production):
YFI reserve: 25.23247380420303708
BNT reserve: 647,758.396109747717331815
pool token supply: 3411.112092474850883773
sys pool balance: 1641.951046786342390985
maxRatio = 500,000 = 50% = 0.5
(tknBalance * p - sysBalance * tknBalance / totalSupply) / (1 - p)
(25.23247380420303708 * 0.5 - 1641.951046786342390985 * 25.23247380420303708 / 3411.112092474850883773) / (1 - 0.5) = 0.94099017502 YFI
keep in mind, this value still needs to be checked against the limits and tiers.

if you want to extract the BNT amount (you might need this for limit check), do the following:
if you use percentage as a value between 0-1:
(bntBalance * p - sysBalance * bntBalance / totalSupply) / (1 - p)
if you use ppm:
(bntBalance * p - 1000000 * sysBalance * bntBalance / totalSupply) / (1000000 - p)
actual code using ppm:
bntBalance.mul(p).sub(sysBalance.mul(bntBalance).mul(1000000).div(totalSupply)).div(1000000 - p)
example using xxxbnt pool data (ropsten):
pool token supply:<PHONE_NUMBER>04086465437837
XXX reserve: 406,199.305995522538513417
BNT reserve: 877,074.144617658202500557
sys pool balance:<PHONE_NUMBER>32824650763918
maxRatio = 500,000 in ppm = 50% = 0.5
(bntBalance * p - sysBalance * bntBalance / totalSupply) / (1 - p)
=> ((877,074.144617658202500557 * 0.5) -<PHONE_NUMBER>32824650763918 * 877,074.144617658202500557)) /<PHONE_NUMBER>04086465437837) / (1 - 0.5) = -875123.849944 BNT
IF result <0, set to 0
example using yfibnt (production):
YFI reserve: 25.23247380420303708
BNT reserve: 647,758.396109747717331815
pool token supply: 3411.112092474850883773
sys pool balance: 1641.951046786342390985
maxRatio = 500,000 = 50% = 0.5
(bntBalance * p - sysBalance * bntBalance / totalSupply) / (1 - p)
=> ((647,758.396109747717331815 * 0.5) - (1641.951046786342390985 * 647,758.396109747717331815 / 3411.112092474850883773)) / (1 - 0.5) = 24156.7390998 BNT
keep in mind, this value still needs to be checked against the limits and tiers.

I opened PR: https://github.com/bancorprotocol/webapp/pull/643 which is inconclusive as off now. The plan was to create two methods that can be tested more easily. In the end i think i struggled with the implementation of the high tier pool logic.

@H34D - what is the status of this?

@H34D - what is the status of this?

working on it

@H34D please do what you can to close this issue today.

@H34D please do what you can to close this issue today.

will do

given up for #669


Create a New Snapshot branch from master

test project on snapshot version

[ ] branch name will be snapshot


Create test connection between DB and DAL

We need a preliminary connection just to ensure that we have access to the database with a proper VPN setup

Access successfully established and tested.


Improve cheatsheet

Add color to quickly see which option is enabled
Using bold for changed options
Using color "flash" when changing the option.

https://gitlab.kitware.com/f3d/f3d/-/issues/199

I used imgui recently, it's lightweight and very flexible. We should consider it instead of VTK UI widgets.

Not against it but I would like to see a quick proto of it first.

moving back unless you want to protoype imgui @Meakk

Waiting for #1077

Should be adressed by #1742


Zodiac Exit App

Revision checks

[x] Your Safe App include a manifest.json file at the root with the required data
[x] The app can be loaded as a custom Safe App in the Apps section of https://gnosis-safe.io/app
[x] The app auto-connects to the Safe
[x] You are able to trigger and execute one transaction with a Safe
[x] RPC requests are optimized (not triggering many requests in a very short time period)

Name/Description
Zodiac Exit App
This app allows for a Safe to use the Zodiac Exit Module to redeem a designated token for a proportion of another Safe's assets.
Type

New addition

Compatible Networks
- Mainnet
- Rinkeby
- Gnosis Chain
- Binance Smart Chain
- Polygon

Code for review
https://github.com/gnosis/zodiac-module-exit
IPFS hash/App URL
https://exit.gnosisguild.org/
Desired date
asap 🙏

Hola guys, I think there is an issue with the app on gnosis chain. After I connect a safe (with or without an exit module set in Zodiac) I am always prompted to connect a wallet:

Could you have a look?
Thanks! :)

Hi @JagoFigueroa! thanks for reporting this issue. I've addressed it in this PR, we'll let you know once it's merged

@JagoFigueroa this should be fixed now: https://github.com/gnosis/zodiac-module-exit/pull/61 is merged and deployed
(be sure to hit hard refresh a few times on the app, to make sure you have the latest files from IPFS) 🙏

The app looks good to me now, thank you guys!
Should be added to the list of apps very soon.
Cheers ;)

App is available now


Some fixes to GitHub Actions config

Cancel outdated jobs using the GitHub Actions concurrency feature.  Apart from reducing wasted CI resources, I think we definitely want this on the main branch, as otherwise if we merged two PRs close together, there could possibly be weird race conditions with uploading snapshots (not 100% sure but better to be safe I think).
Change the JDK 11 and 17 CI job config to exclude building of certain submodules, rather than only including a few tasks.  This way we will see if we break new stuff on these JDK versions in the future.

Pull Request Test Coverage Report for Build #597

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.402%

Totals

Change from base Build #594:
0.0%

Covered Lines:
3602

Relevant Lines:
4029

💛  - Coveralls


is there a build config string, that will turn off all asserts into no-op?

Hi,
I use this library not just in unittest, but also as a replacement for the D built-in assert in the normal code.  But I want to turn off these Asserts in release build, I'm wondering is there a build config string, that will turn off all asserts into no-op?
If currently there is none, can we add such build config?
Thanks.

Hmm...  I think we can do this, but then you will have calls to empty functions, hoping that the compiler / optimiser will remove those calls, but I can not guarantee that will happen.

I've done some code like this:
version (ASSERT) {
public import fluent.asserts;
} else {
  pragma(msg, "NOTE: using dummy Assert!");
class Assert {
  public static void cmp(X, Y)(X x, Y y, string msg="") {}
  alias greaterThan = cmp;
  alias lessThan = cmp;
  alias equal = cmp;
  public static void approximately(X, Y, Z)(X x, Y y, Z=0) {}
}
}

Yes, this is what I was talking about. With this solution you will still have this function call in your code. It can be done. Are you using the last release v13.x.x or master?

last release v0.13.0.


Use of SHA-1 in HostNameSslBindingImpl.java

Our static analyzer flags the use of SHA1 in HostNameSslBindingImpl.java:
MessageDigest sha = MessageDigest.getInstance("SHA-1");
It is recommended to switch to SHA-256 as it is more secure than SHA-1.

Several other uses of the older hash function:

EncryptionUtils.java
BrokerProxy.java
PackageHelper.java

hi @weidongxu-microsoft could you pls have a look? thanks

@ptsankov
X509 thumbprint is generated using SHA-1. Changing it to SHA-256 will like break Java client with everything else.
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2.thumbprint?view=netcore-3.1
The thumbprint is only used for finding a certificate from a store. It is not a signature, hence it does not really require all the security of a signature.

hi @ptsankov does above comment make sense to you?

close the issue now. Feel free to create new issue if any other ask, thanks.


Brushing causing repainting all with big data

Version
4.9.0
Reproduction link
https://breeding.biobin.com.cn/welcome/echarts/scatter-matrix.html
Steps to reproduce
使用scatter 散点图时，同时使用了legend和brush选择，为什么当界面上数据超过1W的时候，在legend和brush选的时候，整个散点图就重新刷新，在1w数据点以内的话就可以正常显示，不重新加载散点图
(Using scatter diagram, using the legend and brush to choose, why when the interface data on more than 70000 data quantity, at the time of legend and brush selected, the scatter plot is to refresh, you can within the 10000 data points, according to the normal not reload the scatter plot.)。
What is expected?
数据量可以设定，在一定值后可以重新加载，或者不重新加载(The amount of data can be set and can be reloaded or not reloaded after a certain value)
What is actually happening?
当数据超过1w数据就重新加载了(When the data exceeds 10000, it is reloaded)。

By default, scatter series has progressiveThreshold as 3000, which means the data will be rendered progressively in the following frames if a series contains data more than 3000.
You can set the option to be a larger number, so that it will be rendered in a single frame, but this will take longer time for a frame.


mouse_entered never fires when root/parent node does not inherit Node2D

Godot version:

3.0.2, 3.0.3 RC3
OS/device including version:

Arch Linux
Issue description:

mouse_entered does not fire on area2d if parent/root node does not inherit CanvasItem
Steps to reproduce:
Create scene, root node is Node or WorldEnvironment, or any other node that is not CanvasItem
Create a new scene, root node is area2d, children of Sprite + CollisionShape2D, attach script listening on mouse_entered (and optionally mouse_exited)
Add scene as child of root node
Run in main scene, events never fire
Change root of main scene to Node2D/Control, events will now fire
Minimal reproduction project:

buggy.zip

Close it now, not an issue really.

Issue was control node above node2d, control was consuming mouse events, preventing them reaching the Area2D. My mistake. Closing.


Add configuration/profile for invocation of the animalsniffer

This will help you ensure that your codebase does not refer to newer JDK API.
You may need to add some annotations to mark things are not really problems, but this should help you ensure you don't accidentally leak in incompatible JDK references in the future.
ATM this will cause your build to fail if you enable the profile (but that is its job to prevent you from leaking in incompatible api), as there are several places where you are using Java7 api, and also a handful of places that use Unsafe.  Probably needs someone with understanding of why/how these are used to apply the IgnoreJRERequirement annotation as appropriate.
https://github.com/mojohaus/animal-sniffer/blob/master/animal-sniffer-annotations/src/main/java/org/codehaus/mojo/animal_sniffer/IgnoreJRERequirement.java
Profile is disabled by default, recommend you update your CI automation to add -Panimalsniffer to enable the check.

I didn't know it, merged. Thanks. @tglman Could you please add the -Panimalsniffer to Jenkins?

before enable it on jenkins we have to configure it/fix the code, there are a few problems like unsafe.

Does animalsniffer fights with Unsafe?

@lvca doesn't fight with it, but complains about its improper usage (which pretty much every use is improper according to the original authors, but that is another story).
You can/will need to add a few @IgnoreJRERequirement annotations (best with some inline comments why) to mark things that you are aware of being non-standard/problematic.


Pass Source Maps by default in custom loaders

Do you want to request a feature or report a bug?
feature
What is the current behavior?
If you write a custom loader you need to pass source maps explicitly, so they don't get lost.
What is the expected behavior?
It would be nice, if source maps are always passed by default and that you explicitly need to "remove them", if you really want to.
If this is a feature request, what is motivation or use case for changing the behavior?
It seems to be too easy to create bugs (https://github.com/Va1/string-replace-loader/issues/18) with this behaviour which can be easily avoided (https://github.com/Va1/string-replace-loader/pull/28).

It's not passed by default, because it's not correct to pass the source map along. i. e. in you PR instead of passing the SourceMap along you should better update the SourceMap with the string replacement made in the loader. Otherwise positions doesn't match.

Okay, but this is another improvement IMHO. Currently the source maps are broken for every file and with my PR they are broken only for where this loader really replaces code and it's "okay" for small replacements (like _import() -> import()).


No data after switching to azure plan

Hello,
im using this module (v 3.0.9.) to get all data that belongs to our customers in azure. I collect data to make it visible with Power Bi.  After switching every subscription to azure plan we can't get any new data.
Get-PartnerCustomerSubscriptionUtilization (with proper parameters)
should get me the data like before, but first it returned an error:
"Get-PartnerCustomerSubscriptionUtilization : Subscription id 'xxxxx' provided was not found under this customer."
After searching I got the information, that I can get the subscription with :
Get-PartnerCustomerAzurePlanEntitlement -CustomerId "xxx" -SubscriptionId  "yyy"
I can use the response to get data before switching to azure plan but not data after the switching date.
for example:
#data before azure plan
$data1 = Get-PartnerCustomerSubscriptionUtilization -CustomerId "xxx" -SubscriptionId "yyy" -StartDate (Get-Date -day 1 -hour 0 -minute 0 -second 0 -Month 1) -EndDate (Get-Date -day 7 -hour 0 -minute 0 -second 0 -Month 1)  -Granularity Daily -ShowDetails
$data1.Count
This call holds data like before.
#data after switching to azure plan
$data4 = Get-PartnerCustomerSubscriptionUtilization -CustomerId "xxx" -SubscriptionId "yyy" -StartDate (Get-Date -day 1 -hour 0 -minute 0 -second 0 -Month 4) -EndDate (Get-Date -day 7 -hour 0 -minute 0 -second 0 -Month 4)  -Granularity Daily -ShowDetails
$data4.Count
This call return null even though there has to be data.
Is this an expected behavior?

Sorry, I'm not a Microsoft representative or anything but I ran into this problem as well. The explanation for this behavior falls under the Microsoft documentation, here. I hope this helps.

Thanks. I missed that information.


Diff after merge fails inconsistently

After performing a merge, diffing the two branches sometimes fails.
The error is related to an SSTable ID somehow becoming grabage.
Steps to reproduce:

Create the repo:

REPO_NAME=myrepo
lakectl repo create lakefs://${REPO_NAME} local://new/${REPO_NAME}

Upload and commit file to master:

lakectl fs upload -s ./some/local/file lakefs://${REPO_NAME}@master/aa
lakectl commit lakefs://${REPO_NAME}@master -m "mastercommit1"

Create a branch, upload to it, and commit:

lakectl branch create lakefs://${REPO_NAME}@ftr --source lakefs://${REPO_NAME}@master
lakectl fs upload -s ./some/local/file lakefs://${REPO_NAME}@ftr/bb
lakectl commit lakefs://${REPO_NAME}@ftr -m "ftrcommit1"

Merge branch to master:

lakectl merge lakefs://${REPO_NAME}@ftr lakefs://${REPO_NAME}@master

Do a diff:

lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr

This command gives unconsistent results: sometimes it gives an error.
Note that due to another unfortunate bug (I'm on it), this error is swallowed. To see the error put a breakpoint in range_manager.go:108 (return nil ,err)
Example error:
open SSTable :��`�2pF\V�����+���'��"�e������ after fetch from next tier: fetch :��`�2pF\V�����+���'��"�e������ from next tier: read from block storage: open /home/local/data/new/myrepo/_lakefs/range/:��`�2pF\V�����+���'��"�e������: no such file or directory

[as discussed vf2vf, this is a release blocker and all]

[as discussed vf2vf, this is a release blocker and all]

I can occasionally also receive:
+ added aa
+ added bb

when running multiple times concurrently!
ariels@redqueen:~/dev/lakeFS$ ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[1] 3078578
[2] 3078579
[3] 3078580
[4] 3078581
[5] 3078582
[6] 3078583
[7] 3078584
[8] 3078585
[9] 3078586
[10] 3078587
[11] 3078588
+ added aa
+ added bb
[1]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[2]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[3]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[4]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[5]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[6]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[7]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[10]-  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[11]+  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
ariels@redqueen:~/dev/lakeFS$
[8]-  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[9]+  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr

I can occasionally also receive:
+ added aa
+ added bb

when running multiple times concurrently!
ariels@redqueen:~/dev/lakeFS$ ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr & ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[1] 3078578
[2] 3078579
[3] 3078580
[4] 3078581
[5] 3078582
[6] 3078583
[7] 3078584
[8] 3078585
[9] 3078586
[10] 3078587
[11] 3078588
+ added aa
+ added bb
[1]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[2]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[3]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[4]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[5]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[6]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[7]   Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[10]-  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[11]+  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
ariels@redqueen:~/dev/lakeFS$
[8]-  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr
[9]+  Done                    ./lakectl diff lakefs://${REPO_NAME}@master lakefs://${REPO_NAME}@ftr

Also happens if I build with CGO_ENABLED=0.  Sad.

Also happens if I build with CGO_ENABLED=0.  Sad.

Race detector (go build --race) doesn't find anything, but... when running the above diff commands with it enabled, the process exits:
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=8b17dab4-b26b-424b-869f-f2a53973eb73 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=23a5cf19-c335-433d-a8f2-58a38db340a6 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=c56979f8-16f7-4d4c-944b-506d4151279c service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]httputil/logging.go:77 httputil.DebugLoggingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=5cc0d714-bbd5-4853-abf0-84166e7f7ac4 sent_bytes=79 service_name=rest_api status_code=200 took=12.853117ms user=me
DEBUG  [2021-01-19T16:23:44+02:00]httputil/logging.go:77 httputil.DebugLoggingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=c27176ab-ddf8-4f3f-87dc-fdb713571426 sent_bytes=79 service_name=rest_api status_code=200 took=15.927539ms user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=e2134ff0-9276-4f78-bb4e-0e99217a6e93 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=f114b470-5884-43f3-afd0-e1b5038a5fa7 service_name=rest_api user=me
singleLevelIterator.data.cacheHandle is not nil: 0x7f824c002c10

Race detector (go build --race) doesn't find anything, but... when running the above diff commands with it enabled, the process exits:
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=8b17dab4-b26b-424b-869f-f2a53973eb73 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=23a5cf19-c335-433d-a8f2-58a38db340a6 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=c56979f8-16f7-4d4c-944b-506d4151279c service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]httputil/logging.go:77 httputil.DebugLoggingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=5cc0d714-bbd5-4853-abf0-84166e7f7ac4 sent_bytes=79 service_name=rest_api status_code=200 took=12.853117ms user=me
DEBUG  [2021-01-19T16:23:44+02:00]httputil/logging.go:77 httputil.DebugLoggingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=c27176ab-ddf8-4f3f-87dc-fdb713571426 sent_bytes=79 service_name=rest_api status_code=200 took=15.927539ms user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=e2134ff0-9276-4f78-bb4e-0e99217a6e93 service_name=rest_api user=me
DEBUG  [2021-01-19T16:23:44+02:00]api/api_controller.go:97 api.(*Dependencies).LogAction performing API action                         action=diff_refs host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/master/diff/ftr?amount=100" request_id=f114b470-5884-43f3-afd0-e1b5038a5fa7 service_name=rest_api user=me
singleLevelIterator.data.cacheHandle is not nil: 0x7f824c002c10

Issues with race detector seem unrelated -- also happen for a diff without a previous merge on the same process.  Back to the original issue.

Issues with race detector seem unrelated -- also happen for a diff without a previous merge on the same process.  Back to the original issue.

#1244 might fix the corrupted output, but does not fix https://github.com/treeverse/lakeFS/issues/1238#issuecomment-762865737 (displaying diffs between wrong pair of commits).

#1244 might fix the corrupted output, but does not fix https://github.com/treeverse/lakeFS/issues/1238#issuecomment-762865737 (displaying diffs between wrong pair of commits).


containers that are stopped during upgrade are restarted by crontab

Rancher versions:
rancher/server: 1.6.4
Steps to reproduce:

have crontab service deployed
upgrade stack
if the upgraded stack doesnt get finished before crontab runs, stopped containers get started

This is a duplicate of #8757.
The behavior is known. The crontab service has no awareness of Rancher services.

@galal-hussein Can we just verify that the latest crontab fixes this specific use case?

Rancher server: v1.6.11-rc4
I was able to verify that in the new crontab catalog that run in --rancher-mode the old stopped containers in upgraded stack will still be in stopped state even after the crontab run executes.


Remove outcome

Change Description

Depends on https://github.com/EOSIO/abieos/pull/52
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Submodule regression check is currently borked by the desubmodule work.


Adds documentation and specs for callback response behaviors

References #1251, #1253
I found that there is already support for using present in a before filter. Any filter actually, along with error!. Using error! will act as though the response stops there completely. Any filter or api call that would have happened afterwords is not called (including after to be specific to #1253).
Wrote specs and documentation for current behavior

There's some issue with Ruby 1.9.3 rubocop, if you could please take a look. Rubocop has a setting that targets a certain Ruby version somewhere - I don't think we should drop 1.9.3 just yet, although I am open to talking about it.

Ah, I forgot %i is 2.0 syntax. Fixed now

Merged.


(re-)add Cargo.lock

iroh produces binaries.
As per
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html, this means it should have its Cargo.lock file committed to the repository.

Thanks, but we've decided to skip the lock file for now until the code is more stable, as they mostly generate merge conflicts at the moment 😅. Do you have a specific need for them?

Thanks, but we've decided to skip the lock file for now until the code is more stable, as they mostly generate merge conflicts at the moment 😅. Do you have a specific need for them?

In the Capyloon fork we commit Cargo.lock and all crates vendored, because the Android build system disallow network access during builds. We need a fork anyway for other purposes so it's just a secondary reason for us.

Thanks, but we've decided to skip the lock file for now until the code is more stable, as they mostly generate merge conflicts at the moment sweat_smile. Do you have a specific need for them?

Sorry for not replying sooner. Like @fabricedesre, I'm also packaging this in a stricter build environment which needs these lock files to function. I wanted to give some of your binaries a try. Of course I can manually create them, but having them in the repo would ensure everyone is using the same versions. For reproducibility reasons, I'd really like to see these being included, but it's ultimately your choice. Do you think it's still too much churn?

I had someone else opening a nixpkgs PR packaging iroh, and they also had to manually provide a Cargo.lock file: https://github.com/NixOS/nixpkgs/pull/198678#pullrequestreview-1161173069
With the 0.1.0 release now out, would you reconsider shipping a lockfile in the repo? It'd really make it easier for others to build iroh, and you'll also have more guarantees about what third-party libraries it is built with.

We will be adding one eventually, see https://github.com/n0-computer/iroh/issues/548 but not right now. So I am going to close this PR for now. But we have the issue of tracking to add it once we are ready for it.


Increment version for servicebus releases

Increment version for servicebus releases

Can one of the admins verify this patch?


Mark accumulate as deprecated?

Accumulate is deprecated in the problem-specifications repo, and instead list-ops should be implemented. Since list-ops is implemented, we just need to deprecate accumulate in the track config.

Wrong track :(


Fix gcc6 issues - add explicit c++98 compile and link flag

As per https://gcc.gnu.org/gcc-6/changes.html , the default C++ dialect in GCC 6 is updated from GNU++98 all the way to GNU++14. This causes compile errors for C++ programs that are not C++14 (or C++11) compliant. As pointed out in #115 , such issues prevent BamTools from being built with GCC 6.
This pull request explicitly adds -std=c++98 to both compile and link flags (i.e., to CXXFLAGS), which is one way of allowing BamTools 2.4.0 to be built with GCC 6.0.0.
The caveat of doing this is that the libraries produced will (if I understand correctly) use the C++98 ABI, and they might get used in a system based on the C++14 ABI. Some ABI differences are explained here: https://gcc.gnu.org/wiki/Cxx11AbiCompatibility (I couldn't find a similar document regarding C++14). A quick glance suggests libbamtools.{a,so} do not use any problematic symbols, but this is not a guarantee, and compatibility might be broken in the future.
An alternative way of making BamTools more GCC 6 friendly would be to address dialect differences, one by one.

Here is a Dockerfile based on Debian Experimental using GCC 6.0.0 demonstrating the build (thanks @mr-c):
# BamTools version 2.4.0 on Debian Experimental (gcc 6.0.0)
#
FROM debian:experimental

# install g++, make
RUN apt-get update && apt-get install -y -t experimental build-essential

# install other build tools
RUN apt-get update && apt-get install -y cmake git zlib1g-dev

# download sources
RUN mkdir /src && \
    cd /src && \
    git clone --branch add-c++98-compile-and-link-flag --depth 1 https://github.com/mateidavid/bamtools.git
#    git clone --branch v2.4.0 --depth 1 https://github.com/pezmaster31/bamtools.git

# build and install
RUN mkdir -p /src/bamtools/build && \
    cd /src/bamtools/build && \
    cmake .. && \
    make && \
    make install

@mateidavid Happy to help! Yes, specifying -std=c++98 is how I was going to patch the source if it wasn't incorporated here or otherwise addressed.


Fix typos in input action editor key type names

This also uses Title Case as typically done for enum option names in the editor.

Thanks!


[TabView] Update high contrast colors | MicaAlt colors - update high contrast colors

Did a high contrast pass and fixed some bugs on tabs, selected tab, outlines, tab close button.
Added a border for the close button in high contrast as usually required by accessibility.
Updated MicaAlt colors to proper background in high contrast as these are usually backgrounds and we want to avoid flooding large areas with highlight color.
Before:

Updated, multiple hc themes:
https://user-images.githubusercontent.com/29714167/156718233-a3054d93-cbf5-44bf-89a2-cb73667f0104.mp4

/azp run

:shipit:

/azp run

        <StaticResource x:Key="TabViewBackground"                                       ResourceKey="SubtleFillColorTransparentBrush" />

This should be SubtleFillColorTransparentBrush as part of the standard to avoid using System* brushes for light and dark themes.

Refers to: dev/TabView/TabView_themeresources.xaml:9 in fbfd705. [](commit_id = fbfd7059192369216adce37cefe1cc11546c7f6b, deletion_comment = False)


Implemented sensor values for device of type HmIP-SMI

Tell me what you think :)

Started learning python. All new to me :)
When you like my changes I could squash commits before you merge.

I think it is okay. I we have more IP device we can make a cleanup with helper.


re4_tweaks vs vanilla PRO difficulty (sanity check)

Validation

[X] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)
Hi There,
(Ver <IP_ADDRESS>, 60 FPS, 1.1 HD MOD, XBOX ONE buttons, smaller HUD)
I recently decided to replay RE4 on PRO difficulty (as usual), but I noticed that the game became noticeable harder with re4_tweaks. I can't explain it, feels enemies move and act faster (faster AI logic, less delay between attacks), have a bit more health (maybe different ctrit chance).
I only played TWO versions, original PC release and this HD, and cleared PRO many times before.... Is this supposed to be the real GC PRO difficulty or placebo?

I think it's probably a placebo...and I don't mean me.
I've finished this game on Pro difficulty on GC, Wii, and PC, but played the most on PC. I don't feel any difference in difficulty with RE4 Tweaks installed.

A friendly reminder that Resident Evil 4 is game that was made to be played at 30 fps. So playing the hardest possible difficulty at double the original frame-rate will definitely make the game feel a bit harder.
It was already confirmed as well that enemies hit much harder at 60 fps than they do at 30 on Professional, dealing twice the normal amount of intended damage.

I thought re4tweaks fixed those things?

I thought re4tweaks fixed those things?

It fixes a lot, but there are certain things still not quite fixed. Leon's hitbox is slightly bigger at 60 FPS and I believe certain enemy attacks do more damage. That being said, these things have never been super big issues for me and the average player would be hard-pressed to notice them.

I thought re4tweaks fixed those things?

Only 60 fps issues related to the physics and QTEs were. (listed in the README)
I'm sure the issues related to Professional will be looked at in the future.

Yeah, this is why when you fight U-3 phase 1, if he grabs you it's a almost instantly drains all of your health, even if fully upgraded.

Is it possible that increasing the FOV too much
makes Leon's default aim position slightly off,
or at least not what you're used to,
making headshots feel harder to pull off?


[Feature]: Add points structure

Add Classes BaseInstancePoints, DepthInstancePoints, CameraInstancePoints, LiDARInstancePoints, Coord3DMode.
Add unittest for each Class.

According to the coverage report. The coverage of coord3d_mode.py is a little bit low.

Task linked: CU-4qth4e Add points structure


c7n-org config file requires 'tags' to be defined, unclear as to why

Leaving out tags in the config file results in the following error:
 c7n-org run --debug -c config/accounts.yml  -a tscloud -u policies/tscloud/tag-compliance.yml  -s /tmp/c7n --region us-west-2
Traceback (most recent call last):
  File "/home/cbouscal/.local/bin/c7n-org", line 11, in <module>
    sys.exit(cli())
  File "/usr/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/cbouscal/.local/lib/python2.7/site-packages/c7n_org/cli.py", line 387, in run
    debug)] = (a, r)
  File "/usr/lib/python2.7/site-packages/c7n/executor.py", line 63, in submit
    return MainThreadFuture(func(*args, **kw))
  File "/home/cbouscal/.local/lib/python2.7/site-packages/c7n_org/cli.py", line 334, in run_account
    with environ(**account_tags(account)):
  File "/home/cbouscal/.local/lib/python2.7/site-packages/c7n_org/utils.py", line 6, in account_tags
    for t in account.get('tags'):
TypeError: 'NoneType' object is not iterable

yeah, thats an oversight, it should be optional.

This still seems to be a problem.


Feature/sync packages setups for public

Issue #, if available:
Description of changes:

Remove all cnoe-appmo reference and make appmod-blueprints repo as GitOps repo for all deplopyments pointing to main
Pointing to AppMod blueprints Catalog for backstage config and remove other catalogs
Upgrade Karpenter and karpneter module version
Upgrade EKS Version to 1.30
upgrade LB controller and nginx along with argorollouts metrics permissions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hmuthusamy CHanges look good. I would recommend to resolve conflicts and let us know. I can test it pulling your code and on top on my env.


[Bug] AccountOverwrite problem

Component
provider, pubsub
What version of Alloy are you on?
latest
Operating System
None
Describe the bug
It looks like AccountOverwrite do not work properly with Geth.
https://github.com/dexloom/alloy/blob/0f9711692743d0444a887a589ca6786df77568be/crates/rpc-types/src/eth/state.rs#L26
and
https://github.com/dexloom/alloy/blob/0f9711692743d0444a887a589ca6786df77568be/crates/rpc-types/src/eth/state.rs#L30
Should be
Option<HashMap<B256, B256>>, because Geth doesn't like odd length while serializing U256, for example 0x3 doesn't work.

Makes sense
Geth: https://github.com/ethereum/go-ethereum/blob/b6474e9f90c88003de7d7eb993ddb5f60133172e/internal/ethapi/api.go#L975-L976


Support for custom model

Hi,
Thanks for a nice library. Is it possible to use a custom BERT (huggingface) model to be used in sentence classification pipeline?

You can load any custom model compatible with the locked version of Transformers that Ernie is using. I haven't had time to adapt it yet to the latest version so some of the recent architectures may not work. In the same way you could be able to use a dumped model trained with Ernie and use it directly with Transformers.