fix(bb.js): (breaking change) bundles bb.js properly so that it works in the browser and in node

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

I have not used ! to specify a breaking change as I think the release-please on aztec-packages cannot handle that right now.
Can you specify what the breaking changes are?

Cherry-picked the base64 unification commit to get it merged faster


Qualify some imports in Test.WebDriver.Firefox.Profile

Fixes #155

The operator <?> is qualified as AP.<?>
Data.Aeson is now imported qualified as Aeson, except fromJSON whose name clearly indicates that it belongs in Aeson

Built against the Docker images haskell:8.6, 8.4, 8.2 and 8.0 to make sure that this doesn't break backward compatibility.

Forgot to ping you @kallisti-dev, but thank you anyway for fixing the issue! (9db008a0a659869d5938ac20b8679556409820ce)


Code field in ReceiptEntry

I am asking this before subclass ReceiptEntry to add this "missing" field: does not all invoices have a code field/column in the entries details? Because I see this is missing in the corresponding Model.
Thanks.

The data for ReceiptEntry is not sent to AFIP at all. None of the details from it are required.
They're only used to generate PDFs.
--
Hugo Osvaldo Barrera

On 3 Feb 2020, at 21:14, Gustavo A. Díaz<EMAIL_ADDRESS>wrote:
ReceiptEntry

Yes, I know.
Anyway, any recomended way to add this field? Just subclassing the corresponding model? What abou the methods that generates the PDF? It accepts custom attributes?

Sorry, what column is missing? For what? I'm not sure I'm understanding compeltely.

Never mind, solved in another way. Thanks.


Setup access to relevant GitHub repos and ZenHub

Access to magma/domain-proxy and openEPC/domain-proxy repos and ZenHub in needed for:

[ ] Wojciech Sadowy - WojSad
[ ] Szymon Krasuski - Dysproz
[ ] Artur Dębski - xbend
[ ] Marcin Trojanowski - m-trojanowski
[x] Tomasz Jędrośka - tjj-freedomfi

The team is created and has access to the repo https://github.com/orgs/magma/teams/domain-proxy-developers
Most of the team members need to be invited into the Org first. Asked @PARitter  to help with invites.

Invites sent to all members, pending acceptance then will add to repos.

@tjj-freedomfi  just checked the list of members - https://github.com/orgs/magma/teams/domain-proxy-developers/members = seems every one we need so far are in the group


Added a new background

Related Issue or bug
Fixes: #10
Describe the changes you've made
Added a new background image. I made it on my own, so no copyright issues :)
Type of change

[x] Code style update (formatting, local variables)

Screenshots

Original
Updated

original screenshot
updated screenshot

@noeltom787 Please resolve the conflicts

@jatiinyadav Is it fine now?
Sorry for the trouble. I hadn't worked with sass till now so didn't know about compiling.


Ingress not working after reboot

Environmental Info:
K3s Version:
v1.19.7+k3s1
Node(s) CPU architecture, OS, and Version:
Linux ***** 5.4.0-65-generic #73-Ubuntu SMP Mon Jan 18 17:25:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:
2 Servers + 1 Worker
Describe the bug:
We accidentally deleted CRDs for rancher. After restarting the cluster, the cluster recovered but ingress is not working.
Pods controlled by DaemonSet/svclb-traefik are stuck in pending-state:
Events:
  Type     Reason            Age    From               Message
  ----     ------            ----   ----               -------
  Warning  FailedScheduling  3m37s  default-scheduler  0/3 nodes are available: 3 node(s) didn't have free ports for the requested pod ports.
  Warning  FailedScheduling  3m37s  default-scheduler  0/3 nodes are available: 3 node(s) didn't have free ports for the requested pod ports.`

The following process uses port 443 on the nodes:
lsof -i :443
COMMAND      PID USER   FD   TYPE  DEVICE SIZE/OFF NODE NAME
k3s-serve 180530 root  138u  IPv4 1256404      0t0  TCP ***:52344-><IP_ADDRESS>:https (ESTABLISHED)
k3s-serve 180530 root  353u  IPv4 1443969      0t0  TCP ***:59056-><IP_ADDRESS>:https (ESTABLISHED)

lsof -i :80
-> returns nothing

Killing the process and scaling down/up traefik & klipper did not resolve the issue.
Steps To Reproduce:
Delete CRDs for Rancher. Reboot the node. CRDs appear, but ingress is not working anymore.
(We are not sure whether this actually caused the problem).
Expected behavior:
Ingress should work.
Actual behavior:
3 node(s) didn't have free ports for the requested pod ports.
Any help much appreciated, if this is not a k3s-bug please close the issue.
Thank you very much.

We solved it ourselves.


Main entry point support

I notice in your example webpack config you have { entry: './src/entry' }, which is a JS file that requires any PureScript modules that you need.
In my case, I just want to call Main.main, so mine looks like this: require('./Main.purs').main(); It seems like it would be cleaner if you could just use { entry: './src/Main.purs' } directly.
I believe the browserify/psc-bundle toolchain does something like this already. Would you consider adding it to purs-loader? I'm fairly new to PureScript, but happy to do the lifting with a bit of direction. (Though maybe #31 would make this irrelevant anyway.)

Thanks for checking out the purs-loader. I agree it would be handy to use Main.purs as the entry directly. I will have to look into whether webpack supports something like this.

This does in fact work. See: ethul/purescript-webpack-example@923f3c1d79cee40e6d6b488cd2f985f484e17af3

@ethul I just tried building https://github.com/ethul/purescript-webpack-example but it didn't work:
/*!************************!*\
  !*** ./src/Entry.purs ***!
  \************************/
/***/ function(module, exports, __webpack_require__) {

// Generated by psc version 0.10.1
"use strict";
var $foreign = __webpack_require__(/*! ./src/Entry.js */ 1);
var Prelude = __webpack_require__(/*! ./bower_components/purescript-prelude/src/Prelude.purs */ 2);
var Control_Monad_Eff = __webpack_require__(/*! ./bower_components/purescript-eff/src/Control/Monad/Eff.purs */ 43);
var Control_Monad_Eff_Unsafe = __webpack_require__(/*! ./bower_components/purescript-eff/src/Control/Monad/Eff/Unsafe.purs */ 45);
var Example_Test = __webpack_require__(/*! ./src/Example/Test.purs */ 47);
var Example_Foo = __webpack_require__(/*! ./src/Example/Foo.purs */ 49);
var Example_Foo_Baz = __webpack_require__(/*! ./src/Example/Foo/Baz.purs */ 53);
var result = Control_Monad_Eff_Unsafe.unsafePerformEff($foreign.hot);
module.exports = {
    result: result,
    hot: $foreign.hot
};
//# sourceMappingURL=index.js.map

Notice that it does not call anything, therefore it does nothing when running node bundle.js
The point of this issue is to automatically call the main Eff from the Main module, just like when using psc-bundle --main Main

Agreed. You're totally correct. I was too soon on closing this. I've been updating the example further. Please see: https://github.com/ethul/purescript-webpack-example/blob/30265626f89b605bf24be94a8f7fadd2610bcd23/src/Example.purs#L17-L25

@ethul With psc-bundle, it is not necessary to use unsafePerformEff, instead you simply return an Eff from main, which is idiomatic in PureScript.
I think purs-loader should support a main option, similar to psc-bundle

@ethul Hm, actually, I thought about it some more. Webpack supports multiple entry points, so you would really want to be able to specify a different main per entry point. That complicates things a lot.
If you only have a single entry point, you can currently use the following to specify the main:
module: {
  loaders: [
    {
      test: /\.purs$/,
      loader: "purs-loader",
      exclude: /node_modules/,
      query: {
        bundle: true,
        pscBundleArgs: {
          main: "Main"
        },
        src: ["bower_components/purescript-*/src/**/*.purs", "src/**/*.purs"]
      }
    }
  ]
}

Right. So you can return an Eff instead of performing the IO, but I am unsure how webpack would know to run this.
Maybe the loader could create a wrapper entry module that invokes this function. Supporting a main for each entry could maybe be done in a similar way if the loader was able to know which modules are "entry modules" then it can wrap each of the entries, and we'd need  a configuration that we can lookup the right main method using the module name (as one idea).
E.g.,
{
  moduleMainFunctions: {
    'ExampleEntry1': 'example1',
    'ExampleEntry2': 'example2'
  }
}

Hi. FYI, I just spent two hours trying to get my own code, heavily based on your examples, to work, due to this very lack. Maybe you should make it a bit clearer in the documentation what needs to be done to get one's own code to be run properly.

@saevarb Thanks for your feedback.
Does your issue relate to #33 or are you describing a new issue?
If you are able to provide a little more explanation on how your issue fits into with #33, I'll be better able to investigate this.


Make Ingress->VirtualService path conversion configurable

When Pilot converts Ingress specs to VirtualServices, it converts paths without wildcard suffixes (.* or /*) to exact matches.
pilot/pkg/config/kube/ingress/conversion.go : createStringMatch()
While this behavior certainly makes sense in some cases, the majority of Helm charts define Ingress paths without wildcard suffixes, instead assuming the ingress controller will perform prefix matching, as the ubiquitous Nginx controller does. This is true even of the Ingress specs in the Istio helm chart (kiali, jaeger, etc.)
As a result, the Istio ingress gateway cannot be used as a drop-in replacement ingress controller with the vast majority of charts. While some charts do allow overriding the ingress path, many do not. Regardless, none can be used without additional configuration.
It would be very helpful if this behavior was configurable, allowing pilot to be configured to generate either exact or prefix matches for non-wildcard ingress paths.
Affected product area (please put an X in all that apply)
[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
Additional context

I just spent two days figuring this out. I was using a helm chart for dex, and wanted to expose it using the built in ingress in the chart, but could not figure out how to get it working.
Finally after fumbling around with the meshConfig, the ingress, the pilot, istioctl, adding and removing labels on namespaces, I finally figured out that istio doesn't match the prefix and instead does a regex match... This breaks almost every ingress in every helm chart that exists.
As a result we will probably have to go with a different ingress controller as we don't want to fork and modify every helm chart we use.

I have created a discussion topic in the forums about this, and am also offering to implement the feature. However I would like to have an agreement on the implementation method, before starting work on this.
https://discuss.istio.io/t/making-istio-a-drop-in-replacement-for-other-ingress-controllers/3827

It's insanely annoying that some bot tries to close an issue, when there are multiple people who want some feature, and even offers to help build the feature, and the Istio team members, completely ignores it.
Should I just start tagging random istio team members in here?

hey @rshriram or @howardjohn or @andraxylia can someone validate that this should be closed?

I'm still interested in offering to implement the feature, if people care to help me decide on the design.

Its interesting nginx treats this as a prefix match. The spec seems to indicate this is not correct:
   path <string>
     Path is an extended POSIX regex as defined by IEEE Std 1003.1, (i.e this
     follows the egrep/unix syntax, not the perl syntax) matched against the
     path of an incoming request. Currently it can contain characters disallowed
     from the conventional "path" part of a URL as defined by RFC 3986. Paths
     must begin with a '/'. If unspecified, the path defaults to a catch all
     sending traffic to the backend.

Granted, our implementation does not seem to actually follow this either... Another example https://docs.traefik.io/v1.7/basics/#path-matcher-usage-guidelines seems too allow you to configure how it is controlled. This seems like a reasonable approach for us to take as well

Huh, yeah, with that description, I must agree that it's quite odd that nginx treats it as a prefix. However all the ingresses in helm charts I have ever seen have used the prefix method. Including the istio charts for Kiali, Prometheus, Grafana and Tracing:
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/kiali/templates/ingress.yaml#L23
The user documentation for the ingress objects also make no mention of either prefix or regexes, and only shows examples with simple strings, making it pretty resonable for a reader to assume they are prefixes: https://kubernetes.io/docs/concepts/services-networking/ingress/

This is now configurable: https://preliminary.istio.io/docs/tasks/traffic-management/ingress/kubernetes-ingress/#specifying-path-type


How to use with custom filter?

How to use jinja2schema with custom filter?

This should work:
from jinja2 import Environment
from jinja2schema import infer_from_ast, parse, to_json_schema

# Note: You can also use extensions by passing e.g.
# `extensions=['jinja2.ext.with_']` to the `Environment()` constructor.
environment = Environment()
environment.filters["my_filter"] = my_filter
print(infer_from_ast(parse(template, environment)))

How can I ignore all custom filters?

How can we ignore all custom filters ?

Custom filters are rejected during the filter check process in visitors/expr.py in visit_filter().
You can force an unknown filter to be considered as returning a string by modifying the last step :
Original code on line 529:
`else:
    raise InvalidExpression(ast, 'unknown filter')`

Replace with :
`    else:
    ctx.meet(Scalar(), ast)
    node_struct = Scalar.from_ast(ast.node, order_nr=config.ORDER_OBJECT.get_next())
    return_struct_cls = String

`

Thanks, I will check..

Just stumbled upon this. Would it be possible to add an optional argument to the parse method? A dict that contains filtername/(type|callback func) pairs which can be used for lookup?
Or at least an 'ignore_unknown_filters' option?


add support for smtpd_sender_login_maps

Hello,
please enhance modoboa in order that postfix can query modoboa sql database for smtpd_sender_login_maps.
This is very security related and will give modoboa admins the possibility to restrict users relaying emails with any "from" address.

This issue was moved to modoboa/modoboa-admin#7


Fix missing Graylog tag and add Graylog RBAC example

This commit features a minor change - adding a missing  tag to the Graylog configuration.
It also has an example Graylog DaemonSet configuration with RBAC enabled. Unlike "elasticsearch-rbac" it does not include:

kubernetes.io/cluster-service: "true"

Whilst testing this on a GKE cluster, the inclusion of this resulted in it always being killed off after under a minute with the message "Killing container with id docker://fluentd:Need to kill Pod"

Looks like this was fixed by #144

Thanks for the patch but other patch seems to include this fix.


Unlock wallet is missing

The unlock feature is missing

Working to add to next build

resolved with merge 58966dec : Merge branch 'wallet_lock-unlock' into develop


DO NOT MERGE: test storage #289

Update github.com/containers/storage to my own rlock2 branch, as an additional safety check for containers/storage#289.

/ok-to-test

/retest

/test kata-containers


Autoplay paused status stays true after switching between browser tabs

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.0.2

Platform/Target and Browser Versions: macOS, Chrome 76

What you did
Running Swiper with autoplay enabled. Checking swiper.autoplay.paused status with my own setInterval. Switched browser tabs forth and back.
Expected Behavior
After switching back to tab with Swiper running, swiper.autoplay.paused should be false.
Actual Behavior
swiper.autoplay.paused is true and doesn't change until next slide.
As I understand after document visibilitychange event slider.autoplay.run() runs to restart autoplay, but doesn't change paused status.

Can't replicate it and and timeout/intervals are not reliable in hidden tabs. Would be good to see real example or JSFiddle and what does it break?

Sorry, probably I'm not so good at explaining. It breaks my progress bar animation:
https://jsfiddle.net/7k216cyx/
When you are dragging the slides for example, autoplay.paused is true and, but after releasing the slide, autoplay resets state, as it should.
But if you go to another browser tab and come back, paused is true, maybe the timer should reset also? Or just the autoplay.paused state?


Blot1

** Attention!!! Blot is not accepting any further PRs as of right now! Please head over to https://highseas.hackclub.com/ if you would like to work toward a blot. **
For a more detailed explanation, please read this slack post: https://hackclub.slack.com/archives/C0188CY57PZ/p1732341551647529?thread_ts=1732313225.355179&cid=C0188CY57PZ
Thanks!

Blot2

Blot3

Blot4

Blot5

hey - as you can see in the PR template, blot is no longer accepting submissions! Get one from High Seas instead, our fall/winter event at Hack Club.


Remove createJSModules(depricated) method from MapsPackage.java file

Motivation
According to this document  of react-native  documentation, the createJSModules() method is deprecated and it is not needed. I removed this method from MapsPackage.java file.
Test Plan
I removed this method from mentioned file and ran my app. There was no error and problem and my test app is working properly.

@christopherdro 🐽
I think it's ok to merge this one, right?

Merging this will exclude older versions of react native from using newer versions of this library.
I forgot exactly in what version this was deprecated but I think we could still wait a bit longer before completely removing it.
This shouldn't be causing any build issues. @VahidBo Are you coming across any issue like that?

@VahidBo thanks a lot for your PR, but we'll have to close without merging for the reasons @christopherdro mentioned 🤗


⚠ Secret Website 1 has degraded performance

In adf9c92, Secret Website 1 ($SECRET_WEBSITE_1) experienced degraded performance:

HTTP code: 200
Response time: 9882 ms

Resolved: Secret Website 1 performance has improved in 5e262df.


Feat: render functions

@dhavelock let me know your thoughts, this is for message.
I need to break out the props object, then pass it into the render function within <> tags so Message component type is still React.FC<Props>
Pretty simple, I also only pull in props that are frequently used to lower lines of code used.

I feel like we can make a new interface thats extends React.FC<Props> and use it instead with the renderComponent functionality baked in.
This code seems very repetitive and can be abstracted somehow 🤔


⚠ Cioos National CKAN has degraded performance

In 20dfb94, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 9089 ms

Resolved: Cioos National CKAN performance has improved in f5dd2b1 after 5 minutes.


fix: Failing CI

The CI was failing because the build was relying on specific version
branches to exist.
The development teams of both projects --- ZeroMQ and libsodium ---
created tags for each version and removed the branches.
The branch names were removed from the env vars and new env vars
containing the actual software versions were introduced.
After cloning the code, a separate checkout command is executed. This
command carries out successfully.
Signed-off-by: Adrian Oprea<EMAIL_ADDRESS>

@prdn Would you consider merging this into the main branch? I don't know if the project is still maintained. I saw your recommendation in the README, to use a different framework, but I thought that fixing a broken build and removing some cruft would be beneficial.

Thanks!


[#124545911] Rebase our gpg feature onto upstream

What
Following our Concourse upgrade we want to upgrade our various resources.
One of our resources is this git-resource fork, which we maintain only for the gpg feature.
We'll soon try to get that feature into upstream.
In the meantime, we rebase our feature onto upstream at the latest version contained in our Concourse version, which we believe is
https://github.com/concourse/git-resource/commit/72182ebe2157f64bcf85374e31c783293569f429
As part of this rebase, we also rework some commit messages and tidy the implementation in preparation for the upstream PR.
We are targeting a new branch, new_gds_master. This allows us to review and merge this PR without affecting production. Then, after the story is reviewed, we have a simple change to reset gds_master to the state of new_gds_master in order to deploy the change. We choose to do it this way to avoid the review process from having to deal with merge conflicts.
How to Review
Locally, docker build . and verify that it completes successfully.
Update your pipeline by adding tag: merge_with_upstream_take2 to the source part of the git-gpg resource type definition in paas-cf/concourse/pipelines/create-bosh-cloudfoundry.yml.
Using the updated pipeline, run a deploy in your personal environment and see that git resources are behaving normally.
Once you're happy the change should go out, merge this PR. Then update the gds_master branch to point at the tip of new_gds_master.

Tested successfully signed commits and tag filter.


Updates the Stack for the Crossplane v0.3 milestone (metadata and isolation)

Updates the Stack for the Crossplane v0.3 milestone (metadata and isolation), requiring crossplaneio/crossplane#729.

Set the permissionScope in app.yaml to "Namespaced"
Set the dependsOn crd resources in app.yaml
Update the example stack install yaml files for the new kind:
StackInstall

Partly addresses https://github.com/crossplaneio/crossplane/issues/754

Looks good to me :shipit:
Thanks folks!


feat: allow passing a GoogleAuth instance

Fixes #175.  I double checked to make sure there would be no compilation issues if this goes out in a minor release.

\o/ thanks for getting this over the finish line.


Websites holding the dependecies give 404 errors.

Both websites lead to 404 errors.
https://repo.maven.apache.org/maven2/io/github/controlwear/virtualjoystick/1.10.1/virtualjoystick-1.10.1.pom
https://dl.google.com/dl/android/maven2/io/github/controlwear/virtualjoystick/1.10.1/virtualjoystick-1.10.1.pom

I have 401 error
> Could not GET 'https://jitpack.io/io/github/controlwear/virtualjoystick/1.10.1/virtualjoystick-1.10.1.pom'. Received status code 401 from server: Unauthorized

Is there another way to get access to this library? @makowildcat @teancake

@Progrsam you can use jitpack
If you follow the instructions there, add to settings.gradle dependency repositories:
maven { url 'https://jitpack.io' }
and in the build.gradle dependencies:
implementation 'com.github.controlwear:virtual-joystick-android:master-SNAPSHOT'


extraVolumes & extraVolumesMounts not working

Chart version:7.1.0
Kubernetes version:v1.13.5
Kubernetes provider:Rancher RKE
Helm Version: Unsure inbuilt in Rancher
Values.yaml:
---
extraVolumes:
  - name: extras
    emptyDir: {}

extraVolumeMounts:
  - name: extras
    mountPath: /usr/share/extras
    readOnly: true

Describe the bug:
Helm template failed. Error: render error in "elasticsearch/templates/statefulset.yaml": template: elasticsearch/templates/statefulset.yaml:104:14: executing "elasticsearch/templates/statefulset.yaml" at <.Values.extraVolumes>: wrong type for value; expected string; got []interface {} : exit status 1
Steps to reproduce:
Attempt to deloy with defaults and the above answers set
Expected behavior:
Should merge volume settings into the statefulset.yaml and deploy
Any additional context:

Thanks for reporting this! I'm going to link the draft PR where you already started working on fixing it: https://github.com/elastic/helm-charts/pull/144

Closing this issue since extraVolumes was fixed in #245.


json access log fields should be numbers, not strings

Describe the bug
I want to get the numeric json logs fields as numbers, not as strings.
I am sending my logs to elastic search through fluent-bit. I needed them in json format in order this to work - so i did it.
I have started setting up dashboards and i wasn't able to work properly with duration and upstream_service_time fields, because they both are sting formats, because they are printed like strings in the json output of the logs:
{
  "path": "/some/service",
  "duration": "5",
  "upstream_service_time": "3"
}

So i have checked how to change my json logs in order to print the number values as numbers, not as strings.
I have found this default configuration - https://github.com/emissary-ingress/emissary/blob/master/python/ambassador/envoy/v3/v3listener.py#L316
and decided to just remove the quotes.
Looks like that:
apiVersion: getambassador.io/v3alpha1
kind: Module
metadata:
  name: ambassador
spec:
  config:
    use_proxy_proto: false
    envoy_log_type: json
    envoy_log_format:
      {
        "start_time": "%START_TIME%",
        "method": "%REQ(:METHOD)%",
        "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
        "protocol": "%PROTOCOL%",
        "response_code": %RESPONSE_CODE%,
        "response_flags": "%RESPONSE_FLAGS%",
        "bytes_received": %BYTES_RECEIVED%,
        "bytes_sent": %BYTES_SENT%,
        "duration": %DURATION%,
        "upstream_service_time": %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%,
        "x_forwarded_for": "%REQ(X-FORWARDED-FOR)%",
        "user_agent": "%REQ(USER-AGENT)%",
        "request_id": "%REQ(X-REQUEST-ID)%",
        "authority": "%REQ(:AUTHORITY)%",
        "upstream_host": "%UPSTREAM_HOST%",
        "upstream_cluster": "%UPSTREAM_CLUSTER%",
        "upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%",
        "downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%",
        "downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%",
        "requested_server_name": "%REQUESTED_SERVER_NAME%",
        "istio_policy_status": "%DYNAMIC_METADATA(istio.mixer:status)%",
        "upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%"
      }

^ like that the deployment fails because of %
I have tried to add
    envoy_log_format: |

or
    envoy_log_format: |-

or
    envoy_log_format: >-

But it doesn't accept my json then. Following error happens:
2022-02-09 14:27:51 diagd 2.1.2 [P22TAEW] INFO: error ambassador.eu-shared-api-gateway.1 envoy_log_type 'json' requires a dictionary in envoy_log_format: {
  "start_time": "%START_TIME%",
  "method": "%REQ(:METHOD)%",
  "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
  "protocol": "%PROTOCOL%",
  "response_code": %RESPONSE_CODE%,
  "response_flags": "%RESPONSE_FLAGS%",
  "bytes_received": %BYTES_RECEIVED%,
  "bytes_sent": %BYTES_SENT%,
  "duration": %DURATION%,
  "upstream_service_time": %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%,
  "x_forwarded_for": "%REQ(X-FORWARDED-FOR)%",
  "user_agent": "%REQ(USER-AGENT)%",
  "request_id": "%REQ(X-REQUEST-ID)%",
  "authority": "%REQ(:AUTHORITY)%",
  "upstream_host": "%UPSTREAM_HOST%",
  "upstream_cluster": "%UPSTREAM_CLUSTER%",
  "upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%",
  "downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%",
  "downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%",
  "requested_server_name": "%REQUESTED_SERVER_NAME%",
  "istio_policy_status": "%DYNAMIC_METADATA(istio.mixer:status)%",
  "upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%"
}

To Reproduce
Steps to reproduce the behavior:
^ explained above.
Expected behavior
Expected behaviour for me would be, this to be working out of the box, which would mean the standard json output to be without quotes for number.
If this is not possible, please tell me how can i achieve this trough adding custom log_format.
Versions (please complete the following information):

Ambassador: 2.1.2
Kubernetes environment : AWS EKS
Version: 7.1.2 (helm chart)
^ i am using latest software

Additional context
Add any other context about the problem here.

I have found a working solution - stopping the json format and setting it up manually, like that:
---
apiVersion: getambassador.io/v3alpha1
kind: Module
metadata:
  name: ambassador
spec:
  config:
    use_proxy_proto: false
    # envoy_log_type: json
    envoy_log_format: >-
      {"start_time": "%START_TIME%","method": "%REQ(:METHOD)%","path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%","protocol": "%PROTOCOL%","response_code": %RESPONSE_CODE%,"response_flags": "%RESPONSE_FLAGS%","bytes_received": %BYTES_RECEIVED%,"bytes_sent": %BYTES_SENT%,"duration": %DURATION%,"upstream_service_time": %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%,"x_forwarded_for": "%REQ(X-FORWARDED-FOR)%","user_agent": "%REQ(USER-AGENT)%","request_id": "%REQ(X-REQUEST-ID)%","authority": "%REQ(:AUTHORITY)%","upstream_host": "%UPSTREAM_HOST%","upstream_cluster": "%UPSTREAM_CLUSTER%","upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%","downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%","downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%","requested_server_name": "%REQUESTED_SERVER_NAME%","istio_policy_status": "%DYNAMIC_METADATA(istio.mixer:status)%","upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%"}

Thanks very much for noting the issue and working solution!  In the interest of focusing on issues without workarounds at present, this issue will be closed.


fix(orb): ensure yarn is installed for test_node_client job

What this PR does / why we need it
We've determined that the correct Node.js version is installed via #650, now we ensure that yarn is installed.

We've figured out that this is not needed.


case(syslog): added a case

https://github.com/go-packagist/go-kratos-components/pull/33

https://github.com/golang/go/issues/64298


Use delete[] where appropriate instead of delete

Fixes https://github.com/microsoft/LightGBM/issues/4983
Ref #4982

Please update this branch to the latest master, to get the CI fixes from #4953.

Updated.


i cant download nucleus co op

when i try to download nucleus co op it just doesent work. I have looked at tutorials but there screen doesen't look the same as my screen so i dont know how to download it so if i please could get some help i would be really happy

https://www.splitscreen.me/docs/installation/


Python 3.12 f-strings still introduce unwanted whitespace in Snakemake 8

Snakemake version

Snakemake 8.2.3 from bioconda
Python 3.12.1

Describe the bug

It was reported in #2480 that Snakemake >8 fixes bugs in handling Python 3.12 f-strings, and pull requests addressing this were merged (#2485, with the release chore PR #2401 still open).
However, when using f-strings with the above-mentioned setup, whitespace is still being introduced.

Logs
Building DAG of jobs...
Retrieving input from storage.
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job      count
-----  -------
all          1
total        1

Select jobs to execute...
Execute 1 jobs...

[Thu Jan 25 13:24:27 2024]
localrule all:
    output: out/ test.out
    jobid: 0
    reason: Missing output files: out/ test.out     <---------------- Added whitespace
    resources: tmpdir=/tmp

/usr/bin/bash: line 1: out/: Is a directory         <---------------- Actual error
[Thu Jan 25 13:24:27 2024]
Error in rule all:
    jobid: 0
    output: out/ test.out                           <---------------- Added whitespace
    shell:
        echo "SUCCESS!" > out/ test.out             <---------------- Added whitespace
        (one of the commands exited with non-zero exit code; note that snakemake uses bash strict mode!)

Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Complete log: .snakemake/log/2024-01-25T132427.614936.snakemake.log
WorkflowError:
At least one job did not complete successfully.

Minimal example
conda create -n snakemake8 -c bioconda -c conda-forge python=3.12 snakemake=8.2.3

NAME = 'test'
OUTDIR = "out/"

rule all:
    output:
        f"{OUTDIR}{NAME}.out"
    shell:
        'echo "SUCCESS!" > {output}'

snakemake -c 1

Additional context
Python 3.12.1 | packaged by conda-forge | (main, Dec 23 2023, 08:03:24) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> s1 = "out/"
>>> s2 = "test"
>>> fs = f"{s1}{s2}.out"
>>> print(fs)
out/test.out
>>>

it may be a hack and slash solution, but you can use the strip() method on the strings to remove all white spaces

Confirmed for v8.3.2 released today:
pip install snakemake==8.3.2
snakemake -c 1

Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job      count
-----  -------
all          1
total        1

Select jobs to execute...
Execute 1 jobs...

[Thu Jan 25 14:43:55 2024]
localrule all:
    output: out/ test.out
    jobid: 0
    reason: Missing output files: out/ test.out
    resources: tmpdir=/tmp

/usr/bin/bash: line 1: out/: Is a directory
[Thu Jan 25 14:43:55 2024]
Error in rule all:
    jobid: 0
    output: out/ test.out
    shell:
        echo "SUCCESS!" > out/ test.out
        (one of the commands exited with non-zero exit code; note that snakemake uses bash strict mode!)

Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Complete log: .snakemake/log/2024-01-25T144355.691975.snakemake.log
WorkflowError:
At least one job did not complete successfully.


Fix generated script for zsh compatibility

Closes #9

This fix seems to be working despite the fact that compgen -W returns the full word list in zsh. Created a SuperUser question, in hopes of understanding the reason (https://superuser.com/questions/1702035/compgen-on-zsh-returns-a-different-result-than-on-bash).
Once this is resolved, we can also add zsh specs.


build doesn't works

It's the same in my case as well, it's giving a white screen only, which is normal since in console it's printing out that dependencies aren't found like styles.xxxxxx.css and js as well!

@gbarrionuevo Sorry but we cannot help you if you do not fill in the issue template, such as you node/npm version, OS, generator version, etc.


Made some changes to product proposal template (comments)

Changed (softened) some language in response to Matt H's comments. Also adding new field for Keywords in response to Roy's suggestion.

Roy, did you want to add your explanations to the text of this template, or were they more "meta" comments directed primarily at those who are evaluating this pull request?


592 derive vars dtm() date imp

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Code is formatted according to the tidyverse style guide
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::documents() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done!  Much love to your accomplishment!

In the "Breaking Changes" section should be mentioned that the behaviour for date_imputation = "mid" has been changed.
There are some functions which provide the date_imputation parameter (derive_disposition_dt() and lstalvdt_source()). I think they should provide the preserve parameter as well.
I am not sure what we should do for functions which provide no date_imputation parameter but impute dates, e.g., filter_date_source(), which is called by derive_param_tte(). What do you think?

Hey Stefan.  Many thanks for reviewing.

I will update the Breaking Changes section.
Should this use of the preserve parameter be a separate issue as I'm changing multiple functions now?  Nervous to change so much in one Pull Request.
I'm not really sure - perhaps something we should bring up to the wider group?

If a change requires updating many functions I would do it in one PR rather than using separate ones. Otherwise, devel may end up in an "incomplete" state when only one of PR is merged but not the other. Thus I would prefer updating derive_disposition_dt() and lstalvdt_source() in this PR.
I have put the third item regarding derive_param_tte() on the agenda of the Monday meeting.

Hey Stefan @bundfussr , I have updated my branch on your suggestions.  I'm having trouble with the cyclometic complexity.  I tried updating the .lintr file just to ignore for a time, but hoping we could increase the limit to 20.  Unfortunately, I think the lintr is triggered somewhere else and so getting linr failing.  #560.
@thomas-neitmann Any chance we could increase the lintr for the cyclometic complexity.
The issue for this "issue" is in the impute_dtc function.  Invoking the preserve and date_imputation agrguments can make this function get a bit out of hand with the call to case_when and and all the if/else statements. .  Perhaps I should of written a helper function to deal with this preserve and date_imputation stuff before hand but I was thinking this would just be a quick update!  But I think this is getting a bit more complicated.
  Hold off on review.  Thanks!!

@bundfussr Can't figure it out.  My mind is getting stuck in weird if/else statement combos.  Hopefully, we can increase cyclomatic complexity to 20 and this will be a none-issue.  Although I don't like how the code is turning out as it is just one big mess!! If you have any ideas on my current Pull Request to clean it/make it more readable please share - I think this is a bit above my skill level at the moment.
Below I have some sample code where I was trying to clean it up and make it more elegant (hopefully) while reducing the cyclomatic complexity, but I'm failing unit tests that involve other arguments later on in the function :(   Here is what I was trying to do.  If you have any ideas on how I could tackle my Pull Request or my idea below, please let me know.  Thanks for your help!!
# Specific setup for FIRST/MID/LAST
    # make keywords case-insensitive
    if (date_imputation %in% c("FIRST", "MID", "LAST") && !preserve) {
      d <- list(FIRST = "01", MID = "15", LAST = "31")[[date_imputation]]
      mo <- list(FIRST = "01", MID = "06", LAST = "12")[[date_imputation]]

    } else if (date_imputation %in% c("FIRST", "MID", "LAST") && preserve) {

      d <- list(FIRST = ifelse(n_chr %in% c(4, 7), "01", substr(dtc, 8, 9)),
                MID   = ifelse(n_chr %in% c(4, 7), "15", substr(dtc, 8, 9)),
                LAST  = ifelse(n_chr %in% c(4, 7), "31", substr(dtc, 8, 9))
                )[[date_imputation]]
      mo <- list(FIRST = ifelse(n_chr %in% c(7), substr(dtc, 6, 7), "01"),
                 MID = ifelse(n_chr %in% c(7), substr(dtc, 6, 7), "06"),
                 LAST = ifelse(n_chr %in% c(7), substr(dtc, 6, 7), "12")
                 )[[date_imputation]]

@bms63 , I think the easiest way to reduce the cyclomatic complexity is to put parts of the code in subfunctions, e.g., one subfunction for imputing the date part and another one for imputing the time part.
To make it more readable and maybe reduce the number of cases you could try something like the following.
  # extract input components
  components <- str_match(dtc, "(\\d{4}|)(-|)(\\d{2}|-|)(-|)(\\d{2}|)")
  in_year <- components[,2]
  in_month <- components[,4]
  in_day <- components[,6]
  year_miss <- in_year %in% c("","-")
  month_miss <- in_month %in% c("","-")
  day_miss <- in_day %in% c("","-")

  # extract requested imputation components
  <as before>

  # derive output components
  out_month <- if_else(month_miss, imp_month, in_month)
  out_day <- if_else(day_miss | month_miss & !preserve, imp_day, out_day)

  ...

@bundfussr Hey Stefan.  I was able to use the case_when function to take out a lot of the if/else statements.  I think this is ready for your review again.  I do think long term we should refactor this code, but maybe I should focus on other things!?!

I agree that we should refactor the code. I think this PR demonstrates that there is room for improvement.
Either we should do it now or when implementing https://github.com/pharmaverse/admiral/issues/727.

There is at least 9 issues that could be brought into PR!

I think #753, #727, #701, #700, and #607 do not require an update of the imputation functions.

Good point I just search for anything related to _dt.  Not the best search, but I think there is more out there.

Hi Stefan @bundfussr
Many thanks again with your help on this Review.  Learning a lot and while this one seemed like an easy issue to tackle, it has been quite a challenge for me!!  The adventures in cyclometric complexity continues!

According to our decision on Monday the preserve parameter should be added to functions which do imputation but do not provide a date_imputation parameter. This should affect derive_param_tte(), derive_var_trtedtm(), and derive_var_trtsdtm().

Can we create a separate issue for these functions?  They seem a little more involved as I have been reviewing them and I would like to get this PR in before the release.  Happy to take them on after the release.  I'm just running out of time and like to wrap this up and help focus with release activities..
@thomas-neitmann I increased the cyclomatic complexity #560 from 15 to 20 in the this branch .lintr file.  Just wanted to give you a heads up!

@bms63 , I think the code produces correct results now. It could be simplified but we want to refactor it anyway. So we do not need to do it now.
As we are still in an experimental stage we can update the other functions in a separate issue. However we should not get used to this practice. Once we are in production we should not release half-implemented functionality.
Please update the news file. Then we can merge the PR.

@bundfussr Updated news.  Let me know if it makes sense.  Going to make separate issues for refactoring the code and updating This should affect derive_param_tte(), derive_var_trtedtm(), and derive_var_trtsdtm().

@bundfussr Fixed up!


Elfcore getcontext

Add support for arm64-linux

Added preprocessor conditions for aarch64
Copied the GP and FP registers structures from glibc.
Defined FRAME ans SET_FRAME macros
FRAME is defined via getcontext() function. It is simpler than using asm.
In CreateElfCore() skip [vvar] memory segment.
A process fails to read this segment. On x86_64 [vvar] is disabled for core dump, but on ARM64 it is not.
It is the only segment that is marked as "pure PFN range" on the both architectures.
Make stack pointer 16-byte aligned in local_clone() on all architectures.
Add a separate ifdef section to read registers using PTRACE_GETREGSET.
PTRACE_GETREGS and PTRACE_GETFPREGS are not supported on arm64-linux

Oops, I planned to merge it to mine master branch first.
I will create new PR.


6.3.3 shows unexpected coverage on Python 3.11

Describe the bug
Updating from 6.3.2 to 6.3.3 adds unexpected coverage on 3.11 runs.
To Reproduce
How can we reproduce the problem?  Please be specific. Don't link to a failing CI job. Answer the questions below:

What version of Python are you using?
3.11.0b1 (main, May  8 2022, 15:20:32) [GCC 9.4.0]
What version of coverage.py shows the problem? The output of coverage debug sys is helpful.

coverage debug sys
-- sys -------------------------------------------------------
               coverage_version: 6.3.3
                coverage_module: /home/runner/.local/lib/python3.11/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                   configs_read: /home/runner/work/aiomysql/aiomysql/.coveragerc
                    config_file: /home/runner/work/aiomysql/aiomysql/.coveragerc
                config_contents: b'[run]\nbranch = True\nsource = aiomysql, tests\nomit = site-packages, .tox\n'
                      data_file: -none-
                         python: 3.11.0b1 (main, May  8 2022, 15:20:32) [GCC 9.4.0]
                       platform: Linux-5.13.0-1022-azure-x86_64-with-glibc2.31
                 implementation: CPython
                     executable: /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/bin/python
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 2589
                            cwd: /home/runner/work/aiomysql/aiomysql
                           path: /home/runner/.local/bin
                                 /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/lib/python311.zip
                                 /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/lib/python3.11
                                 /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/lib/python3.11/lib-dynload
                                 /home/runner/.local/lib/python3.11/site-packages
                                 /opt/hostedtoolcache/Python/3.11.0-beta.1/x64/lib/python3.11/site-packages
                    environment: HOME = /home/runner
                                 PY_COLORS = 1
                   command_line: /home/runner/.local/bin/coverage debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.31.1
             sqlite3_temp_store: 0
        sqlite3_compile_options: COMPILER=gcc-9.4.0; ENABLE_COLUMN_METADATA; ENABLE_DBSTAT_VTAB
                                 ENABLE_FTS3; ENABLE_FTS3_PARENTHESIS; ENABLE_FTS3_TOKENIZER
                                 ENABLE_FTS4; ENABLE_FTS5; ENABLE_JSON1
                                 ENABLE_LOAD_EXTENSION; ENABLE_PREUPDATE_HOOK; ENABLE_RTREE
                                 ENABLE_SESSION; ENABLE_STMTVTAB; ENABLE_UNLOCK_NOTIFY
                                 ENABLE_UPDATE_DELETE_LIMIT; HAVE_ISNAN; LIKE_DOESNT_MATCH_BLOBS
                                 MAX_SCHEMA_RETRY=25; MAX_VARIABLE_NUMBER=250000; OMIT_LOOKASIDE
                                 SECURE_DELETE; SOUNDEX; TEMP_STORE=1
                                 THREADSAFE=1; USE_URI

What versions of what packages do you have installed? The output of pip freeze is helpful.

pip freeze
aiomysql @ file:///home/runner/work/aiomysql/aiomysql/dist/aiomysql-0.1.2.dev3%2Bg1778841-py3-none-any.whl
alabaster==0.7.12
asttokens==2.0.5
attrs==21.4.0
Babel==2.10.1
backcall==0.2.0
bleach==5.0.0
certifi==2021.10.8
cffi==1.15.0
charset-normalizer==2.0.12
commonmark==0.9.1
coverage==6.3.3
cryptography==37.0.2
decorator==5.1.1
docutils==0.17.1
executing==0.8.3
flake8==4.0.1
idna==3.3
imagesize==1.3.0
importlib-metadata==4.11.3
iniconfig==1.1.1
ipdb==0.13.9
ipython==8.3.0
jedi==0.18.1
jeepney==0.8.0
Jinja2==3.1.2
keyring==23.5.0
MarkupSafe==2.1.1
matplotlib-inline==0.1.3
mccabe==0.6.1
packaging==21.3
parso==0.8.3
pexpect==4.8.0
pickleshare==0.7.5
pkginfo==1.8.2
pluggy==1.0.0
prompt-toolkit==3.0.29
ptyprocess==0.7.0
pure-eval==0.2.2
py==1.11.0
pycodestyle==2.8.0
pycparser==2.21
pyflakes==2.4.0
Pygments==2.12.0
PyMySQL==1.0.2
pyparsing==3.0.9
pytest==7.1.2
pytest-cov==3.0.0
pytest-sugar==0.9.4
pytz==2022.1
readme-renderer==35.0
requests==2.27.1
requests-toolbelt==0.9.1
rfc3986==2.0.0
rich==12.4.1
SecretStorage==3.3.2
six==1.16.0
snowballstemmer==2.2.0
Sphinx==4.5.0
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-asyncio==0.3.0
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.0
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
SQLAlchemy==1.3.24
stack-data==0.2.0
termcolor==1.1.0
toml==0.10.2
tomli==2.0.1
traitlets==5.2.0
twine==4.0.0
urllib3==1.26.9
wcwidth==0.2.5
webencodings==0.5.1
zipp==3.8.0

What code shows the problem?  Give us a specific commit of a specific repo that we can check out. If you've already worked around the problem, please provide a commit before that fix.
https://github.com/aio-libs/aiomysql/pull/787 - e.g. https://github.com/aio-libs/aiomysql/pull/787/commits/acb2c3ac77dd8f7883660859388922553233d0d9
What commands did you run?
pytest --capture=no --verbosity 2 --cov-report term --cov-report xml --cov aiomysql --cov tests ./tests --mysql-unix-socket "unix-mysql5.7=/tmp/run-mysql-5.7/mysql.sock" --mysql-address "tcp-mysql5.7=<IP_ADDRESS>:3306"

Expected behavior
Coverage should only be present for executed code paths.
Additional context
For debugging I've created https://github.com/Nothing4You/aiomysql/pull/46.
One specific 3.11 run is https://github.com/Nothing4You/aiomysql/runs/6436451809?check_suite_focus=true, there's also xml and html coverage reports available at https://github.com/Nothing4You/aiomysql/suites/6508136042/artifacts/241970473
3.10 run: https://github.com/Nothing4You/aiomysql/runs/6436451599?check_suite_focus=true and reports https://github.com/Nothing4You/aiomysql/suites/6508136042/artifacts/241970464.
You can find all coverage reports from the CI run at the bottom of https://github.com/Nothing4You/aiomysql/actions/runs/2324901478.
For example, in tests/test_issues.py, there's 2 unexpected newly covered lines.
In test_issue_17, line 177 has coverage, while the rest of the skipped test has no coverage, as expected.
In test_issue_35, line 218 has coverage, while the rest of the skipped test has no coverage, as expected.
There's a few more cases that are marked as newly covered in 3.11, if needed I can document the others as well.
This new coverage only happens on 3.11, the same run on 3.7-3.10 does not have this coverage change.

I think this might be the result of a CPython bug that was fixed after 3.11b1: https://github.com/python/cpython/pull/92722
Do you have the possibility of building a more recent 3.11 and trying it?

Thanks for investigating, that does indeed appear to be the issue.
Just installed Python 3.11.0b1+ (heads/3.11:748c83d, May 22 2022, 20:45:41) [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)] on darwin on my local machine and I don't see coverage with coverage==6.3.3.
Python 3.11.0b1 (main, May 15 2022, 00:48:53) [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)] on darwin however shows the unexpected coverage.


1.0.0-rc.0 pegs CPU and does not finish successfully

I'm in the process of updating a bunch of app build dependencies.  Previously, we were on Webpack 1 and Mocha-Webpack 0.7.  Yesterday, I updated Webpack to 2 and then 3, and saw that Mocha-Webpack 0.7 needed to be bumped.  I updated it to 1.0.0-beta.1, and while I saw some annoying behavior around results display (multiple pages of empty space in the terminal after the results before the tool exited and returned to a prompt), it completed in roughly the same amount of time as 0.7 (on the order of 30-50 seconds).
Today, I saw that 1.0.0-rc.0 was out, so I tried that.  The Mocha-Webpack process successfully runs the Webpack portion, but stays stuck on [MOCHA} Testing....  The Node process keeps a CPU core pegged, and I have yet to see it actually finish and exit - I keep having to kill the process after several minutes.  There's no further output after it shows that it's started testing, either.
I've gone back and forth between 0.7, 1.0.0-beta.1, and 1.0.0-rc.0, and confirmed that beta1 continues to complete okay, while rc0 does not.
Versions:
Node 8.1.2
Webpack 3.3
Mocha-Webpack 1.0.0-rc.0
Windows 7

I saw some annoying behavior around results display (multiple pages of empty space in the terminal after the results before the tool exited and returned to a prompt)

Seems that the terminal clearing does not work correctly for you.

The Node process keeps a CPU core pegged, and I have yet to see it actually finish and exit

Hmm, the only thing that really changed between the rc and the beta was #152. Can you patch mocha-webpack with the previous output of the file and test it again?

Yeah, that's definitely the issue.  I monkey-patched registerRequireHook.js to reverse the diff in #152 , and it completes just fine in a few seconds.  If I undo the monkey-patching so that it's back to the code in rc0, it pegs.  Looks like it's an infinite loop in that for (const resolve of pathResolvers) { sequence - resolved is always undefined.

I'll revert #152 later. The reason why I try to resolve files from memory fs first is that files from memory fs should always take precedence. If a file exists on the real fs and the memory fs, the file from memory is the one we want.
But I think instead of using always the same output path, it's better to use a unique output path.

Same here. Here's some profiling info after running a single test:

@zinserjan Actually:

Why is the resolver used for anything other than the test files? Couldn't it ignore/exclude some dirs by default (node_modules for example).
Instead of excluding can mocha-webpack only include test files? The files are known after the glob-ing so the list is clear.

Also I didn't understand this bit:

But I think instead of using always the same output path, it's better to use a unique output path.

What's going to be the difference in terms of mocha-webpack?

Why is the resolver used for anything other than the test files? Couldn't it ignore/exclude some dirs by default (node_modules for example).

sorry to pile on - when upgrading from 0.7 to 1.0 i had to add a --glob "*.js" option because otherwise i got loader errors about other files (.md, .json, even directories). could this be related? happy to open a separate issue if not..

@antitoxic thanks for the profile screen.

Why is the resolver used for anything other than the test files? Couldn't it ignore/exclude some dirs by default (node_modules for example).

The idea was to look always on the memory fs first as the file could also exist on the real fs. This is especially useful when you use mocha-webpack with a plugin that writes the files from memory-fs to disc for debugging purposes.
All output files generated by webpack should be served from memory fs to make sure that we get the latest version of the bundle. This wasn't the case before, but the implementation of memory fs seems to be to inefficient to do this. That's why I reverted #152.

Instead of excluding can mocha-webpack only include test files? The files are known after the glob-ing so the list is clear

Test files aren't the issue. Output files are the important ones. But I think testing each file path that node tries to resolve against webpack's output path is also a performance killer.
@markerikson @antitoxic
mocha-webpack 1.0.0-rc.1 published
@modosc This has nothing to do with this issue. Please open a separate issue with a more detailed description about your problem and also post your webpack config.

@zinserjan kudos for the quick reaction.
I'm not sure how mocha-webpack patches mocha to read files from memory to be honest. I imagined:

Globs all test files matching pattern
Adds each test file as entry to a single webpack compilation
Runs webpack compilation
After the first compilation, the list of test files generated in memory is somehow passed to mocha
Mocha reads the test files from memory and runs them as if separately.

@antitoxic almost right, but mocha does not read the files from memory. mocha uses node's module system via require to read and run the tests. That's why need to patch node's require algorithm. Not very pretty but the only solution to get this to work.

@zinserjan the implementation as it was before - try and catch is very CPU expensive. Every error generates a stack trace.
If you have (and mocha-webpack definitely has) a list of files, you can generate a map/hash object with filenames as keys and check against this. This is many times more efficient than try and catch.
I think it's worth a try.


[Snyk] Security upgrade node from 18.12.1 to 18.19.1

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to node:18.19.1, as this image has only 178 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

829
Out-of-bounds Write SNYK-DEBIAN11-GLIBC-5927133
Mature

844
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

844
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

844
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

844
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

let's see if it work:
18.19.1


Cannot import on Windows

I'm on Windows 7, python 2.7.13 -
I tried installing from pip and easy_install and setup.py and I can't get it to find Twython.  I can pip install other modules and import them just fine.
.. appreciate any thoughts, thanks!

import Twython

Traceback (most recent call last):
File "<pyshell#10>", line 1, in
import Twython
ImportError: No module named Twython

from Twython import twython

Traceback (most recent call last):
File "<pyshell#11>", line 1, in
from Twython import twython
ImportError: No module named Twython

import simplejson
import twython

Traceback (most recent call last):
File "<pyshell#13>", line 1, in
import twython
File "twython.py", line 4, in
from twython import Twython
ImportError: cannot import name Twython

Weird I don't know if cygwin had anything to do with it but I removed cygwin and windows python, reinstalled python and it seems to work fine.


API App Subscription | Add "subscriptionId" in the response body

Problem/Issue: Proper response is not being logged against App subscription endpoint POST: /api/apps/{appId}/subscribe
Response Logging:
API Endpoint: POST: /api/apps/{appId}/subscribe
Status Code: 204
Response: Empty (ideally, expected to return the subscriptionId)
Impact: The missing response information makes implementing APIs and integration tests more time-consuming. Specifically, it necessitates an additional call to retrieve the recently subscriptionId.
Solution: Return subscriptionId in the response.

@SanaCofinityX  please update the ticket - this is a change proposal and not a bug (as it intends when reading the title" please use something like "API App Subscription | adding "subscriptionId" in the response body" this makes it more open. Please also share the info if you want to contribute the code for it.

@jjeroch
Ticket summary has been updated.


Introduce Cookbook

(ideally) Closes #423

As of now, a very raw structure of examples that might be useful for users. Will need to add some real content with:

Why the example might be needed, in what context it might be useful
Short summary what happens in the example
Code snippets with comments. It is critical to include multiple SDKs (at least bash + Rust, Java and JavaScript later)

I'm using a temp branch with restructured docs as the base for this change in order for us to see the whole picture

@mversic please review the cookbook structure
you can see the preview here

I think what's missing is the description of expected results/outcome. If I understand correctly, the second step in here (with just the main signature) won't work because the account requires a second signature. Since this is a how-to, we need a working example of how to do something. That second step with a single signature is there to show that one signature won't work, so we have to highlight that this step is there to show that something doesn't work, not to follow along.

Agreed. I think this flow would make more sense:

Create an account, set up a second signature rule for it, and register a new asset.
Submit the transaction signed by the main account key, minting the asset.
Check that the transaction is not committed by observing the asset.
Submit the same transaction signed by the second additional key.
Check that the transaction is committed, and the asset is minted.


[FLINK-30921][ci] Adds mirrors instead of relying on a single source for Ubuntu packages

What is the purpose of the change
Trying to integrate mirrors in case the azure mirror is not available. Original source is https://github.com/actions/runner-images/issues/7048#issuecomment-1419426054
Brief change log
Creates mirror.txt and integrate it into the /etc/apt/sources.list
Verifying this change
CI run succeeds
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

It seems to appear again. I rebased the branch and squashed the commits to make it ready to be merged in case, we're having this issue for longer again.

I added a reference to the original comment in the code.

@flinkbot run azure

k, thanks @MartijnVisser I rebased the branch after conflicts with FLINK-31834 occurred and will go ahead and merge the change.


Modified logging to include the resolver IP address and override the …

…client address when EDNS0 client subnet extensions are enabled and a client subnet is present. Updated docs and tests. This resolves #3363.
Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
Fixes #3363
Which TC components are affected by this PR?

[x] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[x] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR? Please include manual steps or automated tests.
(If no tests are part of this PR, please provide explanation as to why no tests are included.)
Run the Traffic Router tests via mvn clean test.
Check all that apply

[x] This PR includes tests
[x] This PR includes documentation updates
[x] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3262/
Test PASSed.


Removed inlineScript maxLength limitation

I have inline script more 500 symbols

Hi @superarchi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

The 500 max length is intentional. Beyond that, pointing to a script is the alternative. The problem is that the UI offers a small text box. The 500 lines is because inline script is OK for a line or two. Beyond that, the editor experience is lacking. If the max length limitation is removed, then the glaring limitation is the editor experience is bad. The task UI isn't designed to be a code editor.

This is not 500 lines, this is 500 symbols!
I have never encountered a problem with the editor, if the big tex.
For example: here do not even put your 2 posts

latest script tasks support more inline code


Add multiple select

In a lot of websites there is multiple categories search. Currently I prefer using a select instead of a bunch of checkboxes (for code simplicity and form understanding). It's frustrating because it takes out a lot of flexibility and doesn't reflect the original website.
A good feature could be a select with the multiple attribute (example).
The getter cans return an array with selected values.
(To be honest I'm not very pleased with this component because it is not UX friendly : you have to know the Ctrl/Cmd key must be down to select multiple item. A list of checkboxes (with a scroll for long list) should be better. But, baby-steps and start with a select.)
What do you think about this new form input?

I see your point. It makes sense for the kind of bridge you are aiming for and should be supported by RSS-Bridge. Unfortunately parameters is one of the more difficult parts to change (because of context detection), so this will take some time. I'll look into this if I have more time to spare (next month probably). If anyone else is interested in taking this challenge, please let me know beforehand.

Closing because this is a hard task with a lower priority.


MudTabs: Added property to reduce minimum width of a tab

Description

Adds a property NoMinimumWidth to fit more tabs in a smaller space, as demoed below.
Resolves #5323
How Has This Been Tested?

Added a unit test and tested visually.
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

@MS-Hayden Thanks for the PR.  Re the API I think Having MinumWidth as a prop might be good API.
We can default it to 160px
You can set it to 0 no minimum width
You can set it to a denser uniform width say 80px since some ppl might want uniform tab widths

@MS-Hayden Thanks for the PR. Re the API I think having MinimumWidth as a prop might be good API. We can default it to 160px You can set it to 0 no minimum width You can set it to a denser uniform width say 80px since some ppl might want uniform tab widths

I'll make the changes and update the PR.

Ok before you start let me discuss with team

Ok before you start let me discuss with team @MudBlazor/core-team
The question is do we ask ppl to use css or is this a common case where style should be available via API?

Righto, I'll wait for the word.
My argument is the the current minimum is very wide, forcing tab scrolling in nearly every situation I personally use it for and does not reflect the margin density you get in nearly all other components.
Maybe it would be better to make  Margin.Dense option for consistency with other components and really go to town on getting the sizing down closer to what you might see in Chrome Tabs.

MinimumWidth would be much better than NoMinimumWidth

OK lets go with minimum width.  Dense in this case is quite subjective so lets let the user chose the width.

Closing this as I am now doing it on my personal account, not work account, and also will name the branch and PR something better with visual examples.


Restructure repository

This PR consists of two commits:
The first commit restructures the repository, as discussed.
tree .
.
├── analysis (models, pre/post processing libraries)
│   ├── configs
├── attacks (mountable attacks)
│   ├── configs
├── capture (data capture)
│   ├── devices
│      └── chipwhisperer
│      └── waverunner
├── obj (access to precompiled bitstreams, etc, TBD)
├── target (target boards)
├── tests (integration tests, and end-to-end testing)
└── utils (utility libraries, e.g. cw to trs conversion scripts)

New classes for target, scope, and project are introduced.
Closes #14.
The second commits updates the simple capture script from #175 to use the new directory structure as well as the new trace database (#205).
The idea is to split up the  cw/capture.py into multiple simple capture scripts stored into attacks/ (c.f., #201).
Hence, cw/capture.py is not working anymore.

My 2 cents: I would definitely go ahead and remove the jupyter directory. I don't think we've ever used that code for our analysis.

Thanks for the comments, @vogelpi! The adapted simple script will be a new PR. Please merge this PR after #205.

@johannheyszl and @vogelpi what do you think of (i) the new repository structure as well as (ii) the adapted simple AES capture script?

As discussed in yesterday's SCA/FI meeting, this PR is ready to merge. Waiting for final approval.

Thanks for the comments @vogelpi. I've addressed your comments, implemented non-batch fvsr_key mode, and added the optimize_capture functionality. If OK for you, I'll merge into master.

Thanks for the comments @vogelpi. I've addressed your comments, implemented non-batch fvsr_key mode, and added the optimize_capture functionality. If OK for you, I'll merge into master.

Thanks, @nasahlpa . I see you also rebased this on top of master already. Can you please make sure the file ci/ci_trace_check/golden_traces/aes_sca_random_golden_cw310.db is stored in Git LFS?

Thanks for the comments @vogelpi. I've addressed your comments, implemented non-batch fvsr_key mode, and added the optimize_capture functionality. If OK for you, I'll merge into master.

Thanks, @nasahlpa . I see you also rebased this on top of master already. Can you please make sure the file ci/ci_trace_check/golden_traces/aes_sca_random_golden_cw310.db is stored in Git LFS?

Done, the file is stored in git LFS.


_app.tsx usage not supported

I have syntax errors when using typescript in _app.tsx.

Hi @christophediprima! Could you please share a minimal working example that reproduces the bug? Otherwise, there's no way other can help you as there is very little information in your report.

Sure! It looks like that adding any typescript syntax into an _app.tsx, is producing errors.
I am trying to add a redux-provider that contains some types inside of "pages/_app.tsx". But this simple code also
import React from "react";
import App, { Container } from "next/app";

type Foo = {
  bar: string;
};

const foo: Foo = {
  bar: "bar"
};

class MyApp extends App {
  static async getInitialProps({ Component, ctx }) {
    const pageProps = Component.getInitialProps
      ? await Component.getInitialProps(ctx)
      : {};
    console.log(foo);
    return { pageProps };
  }

  render() {
    const { Component, pageProps } = this.props;
    return (
      <Container>
        <Component {...pageProps} />
      </Container>
    );
  }
}

export default MyApp;

This produces following error.
 ERROR  Failed to compile with 1 errors                                                                                3:59:31 PM

 error  in ./pages/_app.tsx

Syntax Error: SyntaxError: /Users/christophediprima/Projects/nextjs-test/pages/_app.tsx: Unexpected token, expected ";" (4:5)

  2 | import App, { Container } from "next/app";
  3 |
> 4 | type Foo = {
    |      ^
  5 |   bar: string;
  6 | };
  7 |

This listing is still not enough to help as it is not reproducible. The work of TypeScript depends on the contents of your package.json file and other things, not just what's in _app.tsx. I suggest looking at these examples

https://github.com/zeit/next.js/tree/canary/examples/with-typescript
https://github.com/zeit/next.js/tree/canary/examples/with-typescript

and sharing a repo with a project if things still don't work after trying to figure out what's missing.
If you have found the cause of your issue, feel free to share it here to help other going down the same path after you.


Pointcloud not loading further levels of detail in 2.1.1

I have successfully been using 2.1 for some time with this workflow, but I recently converted an LAS export from RealityCapture using PotreeConverter 2.1.1 and experienced issues with viewing the result in the browser.
The problem appears to be that it loads the initial 'level of detail' but then fails to load any further data when zooming in, moving around etc. It's almost as though 'Lock view' is enabled, but the interface shows this isn't. I've enabled the 'Box' view to check this, which shows that additional boxes are loading in when I use 2.1.1. Again, using 2.1 for the same LAS file on the same setup works absolutely fine as expected.

I'm seeing the same thing, but only on the Windows binary.  We built from the 2.1.1 tag ourselves and that one is working fine in docker, but the windows executable has issues loading depth.
I've attached a point cloud that exhibits this behaviour: lounge.zip
A few things I noticed

The console emits a bunch of warnings like: loaded node with 0 bytes: r251
For a failing node, in OctreeLoader.js, I'm seeing the childMask is set to 1 for the appropate child - but given it's 0 bytes long, perhaps this mask is wrong? Is there an endian issue or something?
While octree.bin is the same size for both windows and linux, hierarchy.bin is ~10% different in size

Unfortunately I'm a little out of my depth at this point


⚠ Bofrost.be has degraded performance

In cf70272, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1407 ms

Resolved: Bofrost.be performance has improved in 037dba2 after 6 minutes.


Upload task times out for Raspberry Pi Pico

I have recently upgraded to Windows 11 (fresh install). I wanted to get back to working on my project, which had been sitting idle for a few months, but I'm having issues.
When I ran the Upload task, it failed with the long string of dots, usually something I see when I forget to close the Serial Monitor in TyCommander. I opened up the CLI and used the command pio run -v -t upload. It showed the following:
<lambda>(["upload"], [".pio\build\pico\firmware.elf"])
AVAILABLE: cmsis-dap, jlink, picotool, raspberrypi-swd
CURRENT: upload_protocol = picotool
BeforeUpload(["upload"], [".pio\build\pico\firmware.elf"])
TimeoutError: Could not automatically find serial port for the `Raspberry Pi Pico` board based on the declared HWIDs=['2E8A:00C0']
TimeoutError: Could not automatically find serial port based on the known UART bridges
Error: Please specify `upload_port` for environment or use global `--upload-port` option.
For some development platforms it can be a USB flash drive (i.e. /media/<user>/<device name>)
*** [upload] Explicit exit, status 1

Oddly, I only get this output if I specify the port using VS Code UI. If I specify the port in platformio.ini, then I get the following:
<lambda>(["upload"], [".pio\build\pico\firmware.elf"])
AVAILABLE: cmsis-dap, jlink, picotool, raspberrypi-swd
CURRENT: upload_protocol = picotool
BeforeUpload(["upload"], [".pio\build\pico\firmware.elf"])
Using manually specified: COM3
Forcing reset using 1200bps open/close on port COM3
"C:\Users\moss\.platformio\packages\tool-rp2040tools\rp2040load" -v -D .pio\build\pico\firmware.elf
rp2040load 1.0.1 - compiled with go1.15.8
.....................
*** [upload] Error 1

The device is definitely on COM3. When I run the devices task, I get the following:
COM3
----
Hardware ID: USB VID:PID=2E8A:00C0 SER=083061E62D7332E3
Description: USB Serial Device (COM3)

Here's the content of my platform.io file:
[env:pico]
platform = raspberrypi
board = pico
framework = arduino
upload_port = COM3 #left this here as an example. whether this line exists or not doesn't make a difference
lib_deps =
<EMAIL_ADDRESS>
Output of dependencies - list task
Resolving pico dependencies...
Platform raspberrypi @ 1.14.0 (required: raspberrypi)
├── framework-arduino-mbed @ 4.1.5 (required: platformio/framework-arduino-mbed @ ~4.1.5)
├── tool-openocd-raspberrypi @ 2.1100.0 (required: platformio/tool-openocd-raspberrypi @ ~2.1100.0)
├── tool-rp2040tools @ 1.0.2 (required: platformio/tool-rp2040tools @ ~1.0.2)
└── toolchain-gccarmnoneeabi @ 1.90201.191206 (required: platformio/toolchain-gccarmnoneeabi @ ~1.90201.0)

Libraries
└── U8g2 @ 2.35.19 (required: olikraus/U8g2 @ ^2.35.19)

VS Code:
Version: 1.92.1 (user setup)
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
Date: 2024-08-07T20:16:39.455Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

rp2040load 1.0.1 - compiled with go1.15.8
.....................
*** [upload] Error 1

This error will be resolved if you use https://zadig.akeo.ie/, plug the Pico in with BOOTSEL pressed, then use WinUSB or libusb drivers for RP2 Boot2 (Interface 1), as referenced in https://github.com/platformio/platform-raspberrypi/issues/2#issuecomment-828586398

That worked, thank you.
In your linked comment, you said that you though it possible that the upload may have worked for people who had Arduino IDE installed. On my old drive with Windows 10, I first used Arduino IDE before switching to PlatformIO so perhaps that's how it "just worked" when I did the switch.
On a side note, I realize now that I may have opened this issue at the wrong repository. Apologies for that.


Malloc size error in ImfPxr24Compressor.cpp:201:18

System info
Ubuntu x86_64, clang 6.0, exr2aces (latest master a5d032)
Configure
cmake .. -DCMAKE_CXX_FLAGS="-fsanitize=address -g" -DCMAKE_C_FLAGS="-fsanitize=address -g" -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address" -DBUILD_SHARED_LIBS=OFF -DINSTALL_OPENEXR_DOCS=OFF
Command line
./build/bin/exr2aces @@ /dev/null
Output
std::bad_alloc

AddressSanitizer output
==12068==AddressSanitizer's allocator is terminating the process instead of returning 0
==12068==If you don't like this behavior set allocator_may_return_null=1
==12068==AddressSanitizer CHECK failed: /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:225 "((0)) != (0)" (0x0, 0x0)
    #0 0x4f20af in __asan::AsanCheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/asan_rtl.cc:69
    #1 0x50f025 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/sanitizer_common/sanitizer_termination.cc:79
    #2 0x4f7ed6 in __sanitizer::ReportAllocatorCannotReturnNull() /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:225
    #3 0x4f7f3a in __sanitizer::ReturnNullOrDieOnFailure::OnOOM() /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:248
    #4 0x42f927 in __sanitizer::LargeMmapAllocator<__asan::AsanMapUnmapCallback, __sanitizer::ReturnNullOrDieOnFailure>::Allocate(__sanitizer::AllocatorStats*, unsigned long, unsigned long) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/../sanitizer_common/sanitizer_allocator_secondary.h:46
    #5 0x42f927 in __sanitizer::CombinedAllocator<__sanitizer::SizeClassAllocator64<__asan::AP64>, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator64<__asan::AP64> >, __sanitizer::LargeMmapAllocator<__asan::AsanMapUnmapCallback, __sanitizer::ReturnNullOrDieOnFailure> >::Allocate(__sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator64<__asan::AP64> >*, unsigned long, unsigned long) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/../sanitizer_common/sanitizer_allocator_combined.h:64
    #6 0x42f927 in __asan::Allocator::Allocate(unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType, bool) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/asan_allocator.cc:443
    #7 0x429237 in __asan::asan_memalign(unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/asan_allocator.cc:900
    #8 0x5207b8 in operator new[](unsigned long) /home/seviezhou/llvm-6.0.0/projects/compiler-rt/lib/asan/asan_new_delete.cc:95
    #9 0x6291b9 in Imf_2_5::Pxr24Compressor::Pxr24Compressor(Imf_2_5::Header const&, unsigned long, unsigned long) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfPxr24Compressor.cpp:201:18
    #10 0x56aca8 in Imf_2_5::newTileCompressor(Imf_2_5::Compression, unsigned long, unsigned long, Imf_2_5::Header const&) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfCompressor.cpp:202:13
    #11 0x6e12a5 in Imf_2_5::TiledInputFile::initialize() /home/seviezhou/openexr/OpenEXR/IlmImf/ImfTiledInputFile.cpp:1008:49
    #12 0x6e32fc in Imf_2_5::TiledInputFile::TiledInputFile(Imf_2_5::Header const&, Imf_2_5::IStream*, int, int) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfTiledInputFile.cpp:855:9
    #13 0x68f09c in Imf_2_5::InputFile::initialize() /home/seviezhou/openexr/OpenEXR/IlmImf/ImfInputFile.cpp:559:32
    #14 0x68cf77 in Imf_2_5::InputFile::InputFile(char const*, int) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfInputFile.cpp:388:13
    #15 0x661573 in Imf_2_5::RgbaInputFile::RgbaInputFile(char const*, int) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfRgbaFile.cpp:1177:21
    #16 0x63477c in Imf_2_5::AcesInputFile::AcesInputFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) /home/seviezhou/openexr/OpenEXR/IlmImf/ImfAcesFile.cpp:485:27
    #17 0x5254be in (anonymous namespace)::exr2aces(char const*, char const*, bool) /home/seviezhou/openexr/OpenEXR/exr2aces/main.cpp:118:16
    #18 0x5254be in main /home/seviezhou/openexr/OpenEXR/exr2aces/main.cpp:222
    #19 0x7f06efb1e83f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291
    #20 0x4249a8 in _start (/home/seviezhou/openexr/build/bin/exr2aces+0x4249a8)

POC
malloc-size-error-Pxr24Compressor-ImfPxr24Compressor-201.zip

(see also comment in #814)
This image is built from tiles which are over 1,000 million pixels wide. That is permitted in OpenEXR image but will require a lot of memory to load. The std::bad_alloc is thrown here if there isn't enough memory to load it. I don't see any bug in the library.
Software that wants to avoid excessive memory allocation from unexpectedly large images should limit the dataWindow and tileSize following a scheme suggested in #484

Ok, I see, may be I should close this issue.


Split kerning by script

This patch is imperfect, but I think it is worth getting something committed that we can iterate from.

modulo a very small number of differences, this matches the output of fontmake on Oswald.
this does not correctly set the lookup flags (or mark filtering set); I'll do that as a followup
this does not handle the 'dist' feature
the testing here is anemic. I have at least figured out how to write tests against this, and I see that there are some ideas at https://github.com/googlefonts/ufo2ft/blob/cea60d71dfcf0b1c0fa4e133ec4231ba06fe0da0/tests/featureWriters/kernFeatureWriter_test.py that look worth porting, but I think it makes sense to focus on this as I continue to refine.

Before looking at this, does this PR incorporate the ideas in https://github.com/googlefonts/fontc/issues/619#issuecomment-1909750996?

Before looking at this, does this PR incorporate the ideas in https://github.com/googlefonts/fontc/issues/619#issuecomment-1909750996?

no, I don't think so. This is generating multiple per-script lookups, not subtables, like ufo2ft currently does. I think Colin wants to just match fontmake output for now.

@madig also note that Colin's PR does implements the feature which Khaled added recently to ufo2ft whereby kerning lookups get merged into one when cross-script kerning is present, which I think addresses your concerns about Indesign dumb composer.

okay so there's one remaining issue here afaik, which rod posted in #733:
https://github.com/googlefonts/fontc/pull/733#discussion_r1524973948


Procedure OnFindReportSelections() in Table Report Selections does not work as expected

Hi there,
I have the feeling that the procedure OnFindReportSelections() in Table Report Selections does not work as expected.
First of all, for OnFindReportSelections() publisher, the existing signature is wrong: FilterReportSelections <> ReturnReportSelections must be switched: First Parameter is not the filtered record but the target. Last parameter is not the target but the filtered Rec:
    [IntegrationEvent(TRUE, false)]
    local procedure OnFindReportSelections(var FilterReportSelections: Record "Report Selections"; var IsHandled: Boolean; var ReturnReportSelections: Record "Report Selections")
    begin
    end;

When working with Custom Report Selections (Section?), these should overrule any default report selections. Therefore the call should be placed before OnFindReportSelections().
Or add AccountNo as a parameter to the publisher. But I would suggest the below order.
Could you please have a look into it?
Best regards,
Carsten
// Suggested code:
local procedure FindReportSelections(var ReportSelections: Record "Report Selections"; AccountNo: Code[20]; TableNo: Integer): Boolean
var
    Handled: Boolean;
begin
    if CopyCustomReportSectionToReportSelection(AccountNo, ReportSelections, TableNo()) then
        exit(true);

    OnFindReportSelections(ReportSelections, Handled, Rec);
    if Handled then
        exit(true);

    exit(CopyReportSelectionToReportSelection(ReportSelections));
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Split ASRService component in modular smaller components

ASRService should be more modular, and each independent part should be split into smaller reusable components.

[ ] ASR service (faster-whisper)
[ ] Nemo diarization
[ ] Alignment
[ ] Any post-processing functions


Enable web console for MushroomObserver VM

Finishes Pivotal #109534868

I think the goal of this PR is to allow us to use the web console gem while running the server off of a Vagrant box.  If that's not right, let me know what the goal is.  In any case, this branch should be moved to go against master and a new PR created.


Uniswap V3 repo version not recognized [APE-820]

Environment information

OS: win (but using ubuntu with wsl for this project)
Python Version: 3.10.6
ape and plugin versions:

$ ape --version
0.5.9

$ ape plugins list
Installed Plugins:
  chainstack    0.5.0a1
  solidity      0.6.2

Contents of your ape-config.yaml (NOTE: do not post anything private like RPC urls or secrets!):

$ cat ape-config.yaml
dependencies:
  - name: Uniswap
    github: Uniswap/v3-core
    version: 1.0.0
  - name: Uniswap
    github: Uniswap/v3-periphery
    version: 1.3.0

What went wrong?

After compiling the project, the Uniswap V3 repo dependencies versions are not getting recognized. I'm fairly new to Apeworx, so maby I'm missing something.

$ ape compile
ERROR: (ProjectError) Unknown version '1.0.0' for repo 'v3-core'.

Since there is no release for this project, I tried different versions v1.0.0, V1.0.0 but none worked.
How can it be fixed?
The repo does not have a release. So for it to work I had to fork it and create a release.

Hello @MMtis ! Do this:
dependencies:
  - name: Uniswap
    github: Uniswap/v3-core
    branch: v1.0.0

Reason:
The version: key in the config will use the GitHub release API to try and fetch a published package version. It looks Uniswap is not publishing releases this way. The branch: config option will use branches or tags. In this case, the release tag is perfect!
I just tried this and it seems to work.

Hello @MMtis ! Do this:
dependencies:
  - name: Uniswap
    github: Uniswap/v3-core
    branch: v1.0.0

Reason: The version: key in the config will use the GitHub release API to try and fetch a published package version. It looks Uniswap is not publishing releases this way. The branch: config option will use branches or tags. In this case, the release tag is perfect!
I just tried this and it seems to work.

Hello @unparalleled-js ,
Thank you for the tip ! It's definitely better than forking the repo.
It also worked for me.

Hello @MMtis ! Do this:

dependencies:

name: Uniswap

github: Uniswap/v3-core

branch: v1.0.0

Reason: The version: key in the config will use the GitHub release API to try and fetch a published package version. It looks Uniswap is not publishing releases this way. The branch: config option will use branches or tags. In this case, the release tag is perfect!

I just tried this and it seems to work.

Hello @unparalleled-js ,
Thank you for the tip ! It's definitely better than forking the repo.
It also worked for me.

Awesome! Also, I have a PR that makes both ways work, but will warn if you're meaning to use the tag. So it'll be less confusing and still work... Thank you!


ValueError while Scrapping Posts

Describe the bug
Scrapping post using Post method gives error.
Traceback (most recent call last):
  File "/instagram-scrapping/main.py", line 23, in <module>
    post.scrape(headers=headers)
  File "lib/python3.7/site-packages/instascrape/scrapers/post.py", line 88, in scrape
    return_instance.upload_date = datetime.datetime.fromtimestamp(return_instance.timestamp)
ValueError: Invalid value NaN (not a number)

To Reproduce
Steps to reproduce the behavior:
from instascrape import Post

headers = {'user-agent': '', 'cookie': 'sessionid:{SESSION_ID}'}

post = Post("https://www.instagram.com/p/CaDMviujr4q/")
post.scrape(headers=headers)

Expected behavior
Dictionary with Keys mentioned in Wiki-Scrapped Data points
Desktop (please complete the following information):

OS: [Ubuntu 18.04 LTS]
Browser [chrome]
Version [insta-scrape: 2.1.2, chrome: 98.0.4758.80, Python: 3.7.11]

I have an alternate package that works:
package main

import (
   "fmt"
   "github.com/89z/mech/instagram"
)

func main() {
   login, err := instagram.NewLogin(username, password)
   if err != nil {
      panic(err)
   }
   items, err := login.Items("CaDMviujr4q")
   if err != nil {
      panic(err)
   }
   for _, item := range items {
      form, err := item.Format()
      if err != nil {
         panic(err)
      }
      fmt.Println(form)
   }
}

@89z Thank You for your prompt reply, But I was looking solution(s) in Python.

I have an alternate package that works:
package main
import "github.com/89z/mech/instagram"

func main() {
   login, err := instagram.NewLogin(username, password)
   if err != nil {
      panic(err)
   }
   items, err := login.Items("CaDMviujr4q")
   if err != nil {
      panic(err)
   }
   for _, item := range items {
      println(item.Caption.Text)
   }
}

where is this suppose to go ?

I have the same problem.

I have the same problem as well

Me too, I have tired with the example script for joebien, get the same error.

Likewise

Same issue here. Can someone share the output of Post objects, e.g. from calling the get_posts() method on a Profile, or creating a Post directly. For me, pretty much all fields are None:
url = 'https://www.instagram.com/google/'

google = Profile(url)
google.url = url
google.scrape(headers=headers)

posts = google.get_posts(webdriver=driver, amount=2,
    scrape=False, scrape_pause=5,
    login_first=False, login_pause=50)

for post in posts:
    print(post.__dict__)

Output:
{'source': 'CbqJU0TjhJF', 'url': None, 'html': None, 'soup': None, 'json_dict': None, 'flat_json_dict': None, 'scrape_timestamp': None}
{'source': 'CbnUOtojevA', 'url': None, 'html': None, 'soup': None, 'json_dict': None, 'flat_json_dict': None, 'scrape_timestamp': None}

I have the same problem as well

I have the same problem as well

same issue


[Feature Request] download speeds

Is your feature request related to a problem? Please describe.
ability to set a bandwidth or file download parallel limits to allow faster speeds
Describe the solution you'd like
a config option to allow faster downloads
Describe alternatives you've considered
multiple instances of bdsm running at once having set "blocks" to download say 256 files each
Additional context
just qol updates

It already does this kind of thing and there is nothing it can do if the server can't or won't deliver any faster speeds. The servers currently only allow 3 connections at a time and this is not something I can control. STN changed stuff on them and I'm not going to argue with him about it.

ah, okay. currently its saying 6days and thats without studio or userdata and only one at a time

It's using all available connections, even if it's only one file at any given moment.


<EMAIL_ADDRESS>hash check failed

Transcript of console output:
Updating 'ccleaner' (6.28.11297 -> 6.29.11342)
Downloading new version
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: b96a08|OK  |    78MiB/s|C:/Users/xxxxx/scoop/cache/ccleaner#6.29.11342#44855ab.zip
Download: Status Legend:
Download: (OK):download completed.
Get-Content: C:\Users\xxxxx\scoop\apps\scoop\current\lib\core.ps1:1376
Line |
1376 |          return Get-Content $file -AsByteStream -TotalCount 8
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Operation did not complete successfully because the file contains a
     | virus or potentially unwanted software. :
     | 'C:\Users\xxxxx\scoop\cache\ccleaner#6.29.11342#44855ab.zip'
Checking hash of ccsetup629.zip ... Get-FileHash: C:\Users\xxxxx\scoop\apps\scoop\current\lib\install.ps1:634
Line |
 634 |      $actual = (Get-FileHash -Path $file -Algorithm $algorithm).Hash.T …
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Operation did not complete successfully because the file contains a
     | virus or potentially unwanted software. :
     | 'C:\Users\xxxxx\scoop\cache\ccleaner#6.29.11342#44855ab.zip'
InvalidOperation: C:\Users\xxxxx\scoop\apps\scoop\current\lib\install.ps1:634
Line |
 634 |      $actual = (Get-FileHash -Path $file -Algorithm $algorithm).Hash.T …
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | You cannot call a method on a null-valued expression.
Get-Content: C:\Users\xxxxx\scoop\apps\scoop\current\lib\core.ps1:1376
Line |
1376 |          return Get-Content $file -AsByteStream -TotalCount 8
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Operation did not complete successfully because the file contains a
     | virus or potentially unwanted software. :
     | 'C:\Users\xxxxx\scoop\cache\ccleaner#6.29.11342#44855ab.zip'
ERROR Hash check failed!
App:         extras/ccleaner
URL:         https://download.ccleaner.com/portable/ccsetup629.zip
First bytes:
Expected:<PHONE_NUMBER>daa84c17ba06e36e7864788e3609cc217642714b559d80452911c2
Actual:

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=ccleaner%406.29.11342%3a+hash+check+failed

My guess is that the file was blocked by Windows Defender, I was unsure where the error message came from, Windows or Scoop, so I just followed instructions and created this issue.

yes, i think that it it blocker by the Windows Defender:
Line |
 634 |      $actual = (Get-FileHash -Path $file -Algorithm $algorithm).Hash.T …
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The operation could not be completed successfully because the file contains a virus or potentially unwanted software : 'D:\Softwares\Scoop\cache\ccleaner#6.29.11342#44855ab.zip'
InvalidOperation: D:\Softwares\Scoop\apps\scoop\current\lib\install.ps1:634
Line |
 634 |      $actual = (Get-FileHash -Path $file -Algorithm $algorithm).Hash.T …
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | You cannot call a method on a null-valued expression.
Get-Content: D:\Softwares\Scoop\apps\scoop\current\lib\core.ps1:1376
Line |
1376 |          return Get-Content $file -AsByteStream -TotalCount 8
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The operation could not be completed successfully because the file contains a virus or potentially unwanted software : 'D:\Softwares\Scoop\cache\ccleaner#6.29.11342#44855ab.zip'


How to allow media or any other permissions?

My app allways ask for user permission when first installed and, running a simple test I allways get stuck because I can't get the "Allow" option of the permission window.

Will "appium:autoGrantPermissions": true help?
https://github.com/appium/appium-uiautomator2-driver
Afaik, the alert is by System, so this flutter-driver itself cannot interact with it. But this driver launches the app under test using appium-uiautomator2-driver. So this capability may help to allow/deny such permissions addressed in the manifest.

@KazuCocoa yeah, it works just by adding autoGrantPermissions: true to the capabilities option. Thank you.


Fixing typos

Thanks for the fixes! The gh-pages branch is not updated manually but taken from the documentation at master branch. Guides are listed in docs directory and documentation from helper is taken from docblocks of source files.
So could you update following files instead?
https://github.com/Codeception/CodeceptJS/blob/master/docs/nightmare.md
https://github.com/Codeception/CodeceptJS/blob/master/lib/helper/Nightmare.js
Thanks

Sure!