Add support for Cross-Account Assume Role policy

[X] Added support for automatic generation of Cross-Account Assume Role policy
[X] Added support for admins to apply the generated Cross-Account Assume Role policy
[X] Added unit tests
[X] change.supported = False for accounts that don't belong to the current org

Solves #9018

Nice Jay, thanks for this!
Gave this a quick test, looks like if I request a policy like this, the resource policy isn't generated with sts:TagSession:
Requested policy:
{     "Action": [         "sts:AssumeRole",         "sts:TagSession"     ],     "Effect": "Allow",     "Resource": "arn:aws:iam::ACCOUNTB:role/Assumed" }
Generated AR policy:
... {             "Action": [                 "sts:AssumeRole"             ],             "Effect": "Allow",             "Principal": {                 "AWS": [                     "arn:aws:iam::ACCOUNTA:role/Assumer"                 ]             }         }

@castrapel Ahhhh, I was operating under the assumption that we only wanted to detect and have sts:AssumeRole in the resource policy (https://github.com/Netflix/consoleme/pull/9051/files#diff-58d8bb64e720ee6da8c73862bfc8025885d200bbaedb98f632777e3166a2bd77R1056). Is there a list of "supported" attributes that we should be looking for that we want to add in the generated resource policy? Or is it any sts:* actions?

Good question! Given the error message below, I am not sure even AWS knows the answer to this. I know that at least sts:TagSession, sts:AssumeRoleWithSAML, and sts:AssumeRoleWithWebIdentity are valid. Problematically, I could see users requesting sts:* on a specific IAM resource (I'm okay with explicitly deciding that v1 of this feature won't support this use case.)
Perhaps we add a configurable supported permission list with these as the default?
config.get("something.supported_trust_policy_permissions", ["sts:AssumeRole", "sts:TagSession", "sts:AssumeRoleWithSAML", "sts:AssumeRoleWithWebIdentity"])
TIL: I tried to give "sts:*" permissions in the trust policy: "Error occurred updating assume role policy for role: RoleName: An error occurred (MalformedPolicyDocument) when calling the UpdateAssumeRolePolicy operation: AssumeRole policy may only specify STS AssumeRole actions."

Thanks for the information Curtis! I have updated the PR to add support for the 4 actions that you suggested! If more actions are needed, I am happy to add support for more!


Final final adjustments for UGDG 🥱 😭

Description

HMU with any last minutes updates here
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Checklist

[ ] I have tested this code
[ ] I have updated the documentation

Codecov Report

Merging #233 (dad071e) into master (7cac0b8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage     71.50%   71.50%
  Complexity      881      881
=========================================
  Files           117      117
  Lines          2783     2783
  Branches        328      328
=========================================
  Hits           1990     1990
  Misses          670      670
  Partials        123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cac0b8...dad071e. Read the comment docs.

Does anyone know how to remove this? hiddenClass thing

Does anyone know how to remove this? hiddenOutside thing

i am done! you can merge this after this is resolved. imma go sleep now

The "User Guide" headings appear twice, should we remove it ?

Hi, does anyone know how to convert the `` to grey box?

Does anyone know how to remove this? hiddenOutside thing

This is urgent. I would appreciate if anyone can help look into this. It is present in almost all our architecture diagrams, it is not supposed to be there.

Does anyone know how to remove this? hiddenOutside thing

This is urgent. I would appreciate if anyone can help look into this. It is present in almost all our architecture diagrams, it is not supposed to be there.

It appears to be the case that the original font color was white which was ab3 used as way to hide the text from appearing.
There does not seem to be away to manually set the font color of it as the color setting using skinparam is global

It appears to be the case that the original font color was white which was ab3 used as way to hide the text from appearing. There does not seem to be away to manually set the font color of it as the color setting using skinparam is global

I think I found a way to do it, will try to fix it now


Allow for setting job priority when enqueuing a job

Implement a WithPriority option for sqlq.Enqueue to allow for setting the priority of the job (and not use the queue priority)

Closing as duplicate of: https://github.com/mergestat/sqlq/issues/50


add data entry UI

in progress

Acceptance test describing implemented functionality in https://github.com/joshwnj/team-index/blob/master/docs/acceptance-tests/wiki.md


migration testing

Full testing of migrations would check out Indexer at each of the last N releases, import some data (appropriate data, nothing too new that needs protocol upgrades not in the prior release), and then run migrations from there to the current development state of Indexer.
This is a big pile of scripting and making a per-release archive of data blobs to import.

The scripting part of this is done, it is test/migrations/postgres_migration_test.sh

These old migrations have been deprecated, and the new ones have tests!


fix: support UTF-8 encoding in inline Web Workers (fixes #12117)

Description
fixes #12117
This PR solves issue #12117, where inline Web Workers lose UTF-8 characters due to the atob function, which only supports ASCII. See https://developer.mozilla.org/en-US/docs/Glossary/Base64
The bug can be seen in this reproduction repo: https://stackblitz.com/edit/vitejs-vite-tyt9yp

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Read the Pull Request Guidelines and follow the PR Title Convention.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Thank you, this fixed my problem at least :)

Note for reviewers: Uint8Array is supported by all browsers that supports Blob constructors. So the browser compat is fine.
https://caniuse.com/typedarrays
https://caniuse.com/blobbuilder

Thanks @Simolation! I think I face the same issue. How can I use your fix?

@xiaohk This PR needs the conflicts to be resolved and a test to be added. You can help this PR to be merged by contributing these changes.
Also you can use https://pnpm.io/cli/patch or https://www.npmjs.com/package/patch-package to patch your local Vite.

Hmm encountered the same error again 😭

I'd love to help. It seems I can't make changes to this PR, so I created a new PR #15866. @sapphi-red can you help review it please? Thank you!!


Added kubernetes config and deployment yaml files.

Fixes #31

Hi @farribeiro - I could not manage to get the services working, so I'll hold this one until the remaining permission issue on volume folders get fixed.

I had no further improvements on this topic, and it has been some months now. I'll assume this as a "won't fix" for now.


First Jenkins working version

Moved the complex ElasticSearch docker-compose to a simple Jenkins one.

Sorry, wrong repo.


Add "Powered by ReactCMS" logo

This will be required for use of ReactCMS

Add this requirement to license.


Bulk/Encumbrance Not accounting for Size

Have a tiny PC.  Bulk Limit isn't being halved (per Player Core p270), nor are negligible bulk items being treated as Light.

You are seeing the sizes from the perspective of the creature carrying the item.

Yes, the items are listed as Tiny, and that affects the bulk.  But that said, page 270 of Player Core reads "A Tiny creature doesn't treat any items as having negligible bulk."  I would read that as there shouldn't be anything on this chart with a "-" weight, but if that's not the official ruling, that's fine.
What also needs to be handled, however, is the max bulk. The shown Tiny character has a strength of +0, so (were they small or medium) an encumbrance limit of 5; as a Tiny creature, this should be halved to 2.

Again, it is from the perspective of the creature. A tiny creature has as max bulk of 10 of tiny items.

Ok (and I swear I'm not trying to be argumentative here; at this point I'm just trying to understand the implementation because it doesn't make sense to me)...that makes sense for some of this.  A piece of chalk that's negligible becomes Light for a tiny character, but make it tiny, and it goes back to negligible. That's fine. A medium-sized healing potion goes from Light to bulk 1.  A medium sized toolkit goes from bulk 1 to bulk 2.  That's all consistent.
But surely, the same would apply to the rapier and armor?  A bulk 1 rapier made for a medium character would be bulk 2 when held by a tiny; a rapier made for a tiny character would be Light when held by a medium character, but bulk 1 when held by a tiny character.  Same would go for the Leather armor.  The tiny dagger would remain bulk L (or negligible if held by a medium character), so that makes sense to me.
So what am I missing in the implementation and/or the rules that makes the rapier and armor feel inconsistent with how the rest of it works?

And here's where I apologize; learned last night that my player had manually altered the bulks for those two items.   That explains everything I was seeing and why the discrepancy was there.  All good now.


Launching on Android builds two times #61

I have tested issue #61 and it is still compiling 2 on version 0.3.0

@NicoleZA
It is a fix in {N} CLI which is not published yet. It is in master branch.
The VSCode extension simply calls
"tns debug android --get-debug-port"
this command is building the project which is not needed. If you need this urgently you may hotfix this on your side by  finding the file android-debug-service.js and locate this function in there debugOnDevice
then change the code to do be like this
https://github.com/NativeScript/nativescript-cli/commit/84cada9b5263286a4a4064851971cdfb55104190
The android-debug-service.js file is part of {N} installation somewhere globally on your machine where your current global node_modules are installed.
Cheers,
blagoev

Thanks you


Add the execution result of example in README.md

Swift & Objective-C beginners can not know the validity of execution results.
We are glad that there is no black box at least beginning of READ.ME.

Thanks for the PR! However, we won't be merging it, as responses are unnecessary for our README and distract from the actual content.


xwayland: specify xwm cursor stride in bytes

This makes it consistent with the rest of the codebase.

I can spell gud

This one: https://github.com/swaywm/sway/pull/1678


Clinical Ingestion helm install error

I performed these steps and got the error at the end:
export INGRESS_SUBDOMAIN=wh-health-patterns.dev.watson-health.ibm.com
export INGRESS_CLASS=public-iks-k8s-nginx
git clone https://github.com/Alvearie/health-patterns.git
cd health-patterns/helm-charts/health-patterns
helm dependency update
helm install ingestion . --set ingress.class=$INGRESS_CLASS --set ingress.subdomain=$INGRESS_SUBDOMAIN -f clinical_ingestion.yaml
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(StatefulSet.spec.template.spec.containers[0]): missing required field "name" in io.k8s.api.core.v1.Container

Yes sir!    We now have successful deploys.    Thanks to Adam.


Enhanced Select functional test & Create volume test fix

Added functional tests for the new enhanced selects
Fixed the create volumes test (since volume creation from the global create drawer now uses the enhanced select).
@Jskobos added a fix to the enhanced select story that unties the value of two of the selects (basic and basic with error).

How to run the Volumes Test:
yarn && yarn start
yarn selenium
yarn e2e --file e2e/specs/create/smoke-create-volume.spec.js

How to run the "Enhanced Select" Functional Test:
yarn storybook
yarn storybook:e2e --story EnhancedSelect

Coverage decreased (-0.08%) to 26.27% when pulling 40455450c127057863da708ec6ceeeb1abc76235 on patthiel:attach-volumes-fix into 37ccafe53e010f7b2de349999421ae936ab7488b on linode:develop.

@Jskobos I broke out the Create attached volume test into it's own spec. Creating more than one volume in a test spec seems to be unreliable in automated browser tests.
The tests can now be run with:
yarn e2e --file e2e/specs/create/smoke-create-attached-volume.spec.js &&
yarn e2e --file e2e/specs/create/smoke-create-volume.spec.js

Had to disable the detach and remove tests. Going to create a manager bug, there are some situations where the UI fails to update a volume detaching from a linode.


Blender crashes on interactive rendering when using textures

How to repeat:
Add texture to material -> Start interactive rendering -> Change any material parameter -> Blender crashes

R06002 {ERROR}   Wrong state to call RiMakeTexture.
R05004 {WARNING} RiEnd called before its proper nesting level.

Seems to be fixed.


How to use additional condition on left join?

I wrote this code to get all data from TableA which corresponding children records in TableB were not deleted.
My data is:
TableA

ID
Title

1
Test

TableB

ID
Title
TableAID
Deleted

1
TableB Test 1
1
1

2
TableB Test 2
1
1

3
TableB Test 3
1
1

Connection.Find<TableA>(statement => statement
                                         .Include<TableB>(join => join.LeftOuterJoin()
                                         .Where($"{nameof(TableB.Deleted):TC} = 0")));

This code generate bellow SQL script:
SELECT
     [TableA].[ID],
     [TableA].[Title],
     [TableB].[ID],
     [TableB].[Title],
     [TableB].[TableAID],
     [TableB].[Deleted]
FROM [TableA] LEFT OUTER JOIN
     [TableB] ON ([TableA].[ID] = [TableB].[TableAID])
WHERE
     ([TableB].[Deleted] = 0);

This query returns nothing! I need to generate bellow script so that my code works properly:
(I moved  [TableB].[Deleted] = 0 from where clause to join statement)
SELECT
     [TableA].[ID],
     [TableA].[Title],
     [TableB].[ID],
     [TableB].[Title],
     [TableB].[TableAID],
     [TableB].[Deleted]
FROM [TableA] LEFT OUTER JOIN
     [TableB] ON ([TableA].[ID] = [TableB].[TableAID] AND [TableB].[Deleted] = 0);

How can I do this?

Please check following one if it works for you as a workaround until extra condition feature added
Connection.Find<TableA>(statement => statement                                          .Include<TableB>(join => join.LeftOuterJoin()                                          .Where($"{nameof(TableB.Deleted):TC} = 0 OR {nameof(TableB.Deleted):TC} IS NULL")));

Please check following one if it works for you as a workaround until extra condition feature added
Connection.Find<TableA>(statement => statement .Include<TableB>(join => join.LeftOuterJoin() .Where($"{nameof(TableB.Deleted):TC} = 0 OR {nameof(TableB.Deleted):TC} IS NULL")));

It works but using  OR statements has performance issue and I look for a better way to do this.

You can certainly add that condition inside the join clause like @hamidnaeemi pointed, but we will add more control on the joins soon.


Add basic spec and instructions to build on Fedora

This adds a basic spec file and instructions on using it with mock to build an RPM on Fedora to use normal package management to install lgogdownloader

I created RPM packages for EL (7) and Fedora (28, 29, 30).
I hope it will be useful for someone.
Repos:
https://copr.fedorainfracloud.org/coprs/scx/lgogdownloader
See also:
https://github.com/Sude-/lgogdownloader/issues/145

Why is this PR sitting here for 2 years and collecting dust?

Good question. Perhaps no one really cares about it?
For my part, I settled with my own build (and update) script which is distribution agnostic :)

Useful for me as a foundation for my own spec file.
Thnx!

Why is this PR sitting here for 6 years and collecting dust?

This was solved in #258, no?

Not quite because although that merge contains an update to the readme file giving a loose description, it does not provide a spec file enabling the build.

Ah my mistake, I misread the PR title.


Nier Automata: The End of Yorha Edition

I just buyed this game and I love it so much.Could you please add it?.Thank you so much!

I have added the game(s) you requested in the most recent release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/v1.1.2
Thank you for checking out the project, reach out if you have any more suggestions!


How to get running node IP & port when remote_url used as seleniumgrid hub

@pekkaklarck
I has deployed seleniumgrid with many nodes as my test machines , I just want to figured out how can I get the running node IP & port when remote_url used as seleniumgrid hub address.

Bug/feature request - should go to selenium library, not core rf.
Also, I’ve implemented this once for protractor/seleniumgrid - @aaltat should have access to that where he can take a look how it was implemented.


Update telemetry package

There has been breaking changes in the proposed telemetry surface so we must update the package to prevent breaking the python extension

Looks like the label CI is being deprecated soon just an FYI

And that warning is known upstream: https://github.com/mheap/github-action-required-labels/issues/42 .


upgrade to 1.15

Upgrading Go version to 1.15
If maintainers find this PR invalid/spam, Or i made a mistake, please take some take a few seconds out of precious time and correct me. I am a newbee and your remark be will helpful for me in learning.

Cannot figure out whats wrong, closing this issue


Vector2I is parsed as a string in Mono.

Godot version
4.2
System information
Godot v4.1.1.stable.mono - Windows 10.0.22621 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1660 SUPER (NVIDIA; <IP_ADDRESS>40) - Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz (12 Threads)
Issue description
Json.ParseString of Vector2I is type string, not Vector2I.
Steps to reproduce
Run the following code:
GD.Print(Json.ParseString(Json.Stringify(new Vector2I(10, 10))).VariantType);
It will print string. It is expected to parse into the Vector2I variant type.
Minimal reproduction project
N/A

JSON does not have native vector types. It only has boolean, integer, number (always float), array and object types.

That makes sense. Maybe it's just the docs misleading me then.
From the docs: "The JSON enables all data types to be converted to and from a JSON string."

Actually, before I close this, why couldn't/shouldn't Godot have a built in function that serializes Godot Vectors into a parseable format?

There are several, for example var_to_str() and ConfigFile. You can also create your own Resource with any needed properties and serialize that.


html-renderer: Simplify module loading for react and rsdw-client

In my testing I discovered that react and react-dom-server-webpack/client.edge could be imported using regular imports. No need to have a local build of those and import that build.

Nice finding. It must have been improved in some PRs like #457 or something.
I'd like to keep it as is for v0.20.0 and investigate more to understand why rd-server and waku-client can't be imported. With that, we will be confident to merge this.
Marking a draft until then.

I wonder if #762 makes any changes. Hm, but it's just for DEV. It shouldn't affect.
I still think this PR is a good move, so I wish we find the reason why import doesn't work for rd-server and waku-client.

https://github.com/dai-shi/waku/pull/707#discussion_r1661267451
@Aslemammad This PR might be somewhat related.

@Tobbe When you have a chance, can you merge main and try removing loadClientModule completely?

Thanks for the reminder. I'll try to get to it today

I'm too tired. I'll continue tomorrow

Seems to be failing for at least renderToReadableStream still

I'll revert that one to keep using loadClientModule and see if that works

Nope. Still broken

Thanks so much for trying out. I'll have a closer look later.

Actually, we are patching rsdw now since #707, it has to load through Vite.

I think this is what we can do now.
@Aslemammad suggests to load everything through Vite from the start, and if it could be done, we might be able to simplify html-renderer.


output out of order and missing duplicate lines

Ltac named_pose x := let H := fresh in let __ := match constr:(Set) with _ => pose x as H end in H.
Goal True. let n := named_pose I in idtac n. (* H *) Abort.

Ltac pn := let n := numgoals in idtac n.

Goal True /\ True.
  assert_succeeds (split; pn).
  assert_succeeds (split; [pn..]).
Abort.

Module goodfresh.
  Ltac myfresh := fresh.
  Goal True.
    let v := myfresh in
    let w := myfresh in
    idtac v w. (* H H *)
  Abort.
End goodfresh.

Module badfresh.
  Ltac myfresh x := let __ := match constr:(Set) with _ => idtac "FRESH" x end in fresh.
  Goal True.
    let v := myfresh 1 in
    let w := myfresh 2 in
    idtac w v. (* H H *)
  Abort.
End badfresh.

Module testfresh.
  Ltac myfresh := let __ := match constr:(Set) with _ => idtac "FRESH" end in fresh.
  Goal True.
    let v := myfresh in
    let w := myfresh in
    idtac w v. (* H H *)
  Abort.
End testfresh.

coqide output:
H
2
1
1
H H0
FRESH 1
FRESH 2
H H
FRESH
FRESH
H0 H

coqtail output:
named_pose is defined

H

pn is defined

2

1

Interactive Module goodfresh started

myfresh is defined

H H0

Module goodfresh is defined

Interactive Module badfresh started

myfresh is defined

FRESH 2

FRESH 1

H H

Module badfresh is defined

Interactive Module testfresh started

myfresh is defined

FRESH

H0 H

Module testfresh is defined

I was actually just looking into the same issue. It's because of the call to set at https://github.com/whonore/Coqtail/blob/master/python/xmlInterface.py#L390. This is also what causes #47. Using set is clearly wrong, but without it you sometimes get unwanted duplicates like in Goal True. fail. because the error message shows up in both the value and feedback elements. I'll have to look at how feedback works more closely to find a better solution.


Feature: running extensionhost as webworker

	// It would be nice to just export what VS Code creates but it looks to me
	// that it assumes it's running in the extension host and wouldn't work here.
	// It is probably possible to create an extension host that runs in the
	// browser's main thread, but I'm not sure how much jank that would require.
	// We could have a web worker host but we want DOM access.

In:

https://github.com/cdr/code-server/blob/master/src/browser/api.ts#L49-L53

I Propose this solution to interact with the DOM in a webworker.

https://github.com/AshleyScirra/via.js

Extra info about weakRef missing feature and mem leak
The fundamental problem is demonstrated by the following code:
ON THE WORKER:
// This records the call and returns a placeholder
// Proxy which is assigned object id 1
const placeholderDiv = via.document.createElement("div");

// This is then sent to the main thread as a command similar to:
// 1. call "document.createElement" with argument "div" and assign
//    the return value object id 1

// Any subsequent calls then refer to the object id, e.g.:
placeholderDiv.textContent = "foo";
// results in a command like:
// 2. assign object id 1 property "textContent" to "foo"

ON THE MAIN THREAD:
// Upon receiving the first command the main thread does the real call:
const realDiv = document.createElement("div");

// Then assigns the intended object ID:
idMap.set(1, realDiv);

// The map is used to look up future commands, e.g. to run command 2 we
// need to start by looking up object id 1, similar to this:
const realDiv = idMap.get(1);
realDiv.textContent = "foo";

// However, now we have a permanent strong reference to the div, so
// it will never be collected. We can't use a WeakMap here since
// the key is not an object. We don't know when to delete the entry,
// since GC is not observable and we don't know when the placeholder
// Proxy on the worker will be collected.

Workaround Solution till weakRef is stable its now stage-2
To solve this, there could be a special WeakKey object. This is like a reduced WeakRef that only serves to be used as a key in a WeakMap. If a WeakKey can then be posted between a Worker and the main thread, this should solve the problem by using it in place of the object ID:
ON THE WORKER:
// This records the call and returns a placeholder
// Proxy which is assigned its own WeakKey
const placeholderDiv = via.document.createElement("div");

// internally, this will do something like:
// placeholderProxy._key = new WeakKey(placeholderProxy)

// This is then sent to the main thread as a command similar to:
// 1. call "document.createElement" with argument "div" and
//    here is a WeakKey representing the return value

// Any subsequent calls then refer to the WeakKey, e.g.:
placeholderDiv.textContent = "foo";
// results in a command like:
// 2. assign this WeakKey property "textContent" to "foo"

ON THE MAIN THREAD:
// Upon receiving the first command the main thread does the real call:
const realDiv = document.createElement("div");

// Then assigns the intended object by its WeakKey:
weakMap.set(weakKey, realDiv);

// The map is used to look up future commands, e.g. to run command 2 we
// need to start by looking up the same WeakKey, similar to this:
const realDiv = weakMap.get(weakKey);
realDiv.textContent = "foo";

This WeakKey approach then behaves how we want:
The main thread can still look up real objects from messages sent from the worker.
If a placeholder Proxy is collected on the worker, then there are no more references to its WeakKey. This allows the entry in the weak map on the main thread to be collected.
GC is not observable.

This looks rather interesting sine I wasn't awarewebworkers can't interact with DOM. Any chance how the shim would help us?

@sr229 it allows passing dom elements to NodeJS and also webworkers in a bidirectional way.
sure we could do that our self its a simple algo

Create Reference => serialize as sting or binary or any way => send =>Deserialize => Process
in both directions.

what do you think @code-asher?

I like it. It might be easier now to create a real API instance on the main thread due to some recent changes but if it turns out to be non-trivial then this seems like the next best way to go.


Ethesis

Coverage decreased (-0.8%) to 54.355% when pulling 1fdfbbbdabe1e859b4d38927278238838761497d on ethesis into 0a414b51ef0f7377b4297df9299ae8bb56352eab on master.

Coverage decreased (-0.8%) to 54.355% when pulling 1fdfbbbdabe1e859b4d38927278238838761497d on ethesis into 0a414b51ef0f7377b4297df9299ae8bb56352eab on master.


⚠ Bofrost.fr has degraded performance

In 4c24ff9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1151 ms

Resolved: Bofrost.fr performance has improved in 28acfaf after 9 minutes.


A zipped sequence causes an exception in ObservableList.AddRange.

I am getting an exception with the code below.
using ObservableCollections;

var seq1 = Enumerable.Range(0, 1);
var seq2 = Enumerable.Range(0, 1);
var zippedSeq = seq1.Zip(seq2, (num1, num2) => (num1, num2));

var list = new ObservableList<(int,int)>();
list.AddRange(zippedSeq); // IndexOutOfRangeException raised.

I think there's something wrong with the CloneCollection construction process when the enumerator doesn't support NonEnumeratedCount.
CloneCollection.TryEnsureCapacity seems to be returning an empty array.

Hi, I remember falling int the same issue and if i recall correctly the reason for the exception was mapping the input sequence onto a Span. The fix is to materialize the sequence first, for example with .ToList() before calling AddRange():
list.AddRange(zippedSeq.ToList());


Add weekly tests using pins main branch

This should resonably ensure that vetiver can react to
to changes in pins API.
closes #40

Codecov Report

Merging #43 (ab9c382) into main (fcc92f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   93.61%   93.61%
=======================================
  Files          27       27
  Lines         736      736
=======================================
  Hits          689      689
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc92f2...ab9c382. Read the comment docs.

This should catch the current state where the version on pypi does not work with the pins main branch.


I can use both SharedPreferences and EncryptedSharedPreferences ?

For the missing API like setStringList, I can use SharedPreferences.getInstance(); separately for storage. And I can use EncryptedSharedPreferences only for the KV that needs to be encrypted.
 _storage ??= await SharedPreferences.getInstance();
await EncryptedSharedPreferences.initialize(key);
_encryptedStorage ??= EncryptedSharedPreferences.getInstance();

Will there be any problem using it this way?

Hi, you can check encrypt_shared_preferences: ^0.8.1 new version for missing setStringList method :)

Hi, you can check encrypt_shared_preferences: ^0.8.1 new version for mis

sing setStringList method :)


PREVIEW: Botkit #NEXT

For those interested in following along (and contributing to) the next major release of Botkit, I've just published it on a separate branch:
https://github.com/howdyai/botkit/tree/next
This is a complete rewrite and reorganization of Botkit.  Details about our goals and approach are here.

This is so not stale!! It is SUPA FRESH.

@benbrown thanks for all of the work on this! We're considering using BotKit in a project soon, what's the ETA on this rewrite?

@Peter-Barrett early next month.  It is now on npm as the @preview tag, you can install it and start using it now:
npm install -g yo generator-botkit@preview
yo botkit

The new docs are here:
https://botkit.ai/docs/v4

@benbrown I tried yo botkit to create web bot and when I start, it shows the message:
Enabling plugin:  Web Adapter
Loading sample web features...

And localhost:3000 shows Cannot GET /

@adantoscano good catch - right now, it defaults to /chat.html but it probably should serve up on the index page.  Thanks for the report.

This version has been published!!

@adantoscano good catch - right now, it defaults to /chat.html but it probably should serve up on the index page. Thanks for the report.

not working /chat.html


Clicking on check for update opens empty chrom tab

VSCode Version: 1.26.1
OS Version:  Linux 16.04 LTS

Steps to Reproduce:

Click on Settings bottom-left corner of VScode.
Click on Check for update (if not updated).
Will open a empty browser window.

Does this issue occur when all extensions are disabled?: Yes
vscode-issue.zip

This is not the case only with update, any this that require browser action opens empty browser window without redirection. steps i gave you was just another example.
For an instance if I got to Help > Introductory Videos; it does the same thing i.e. opens empty browser window and no redirection.

https://github.com/electron/electron/issues/6531


[Feature Request] Configurable permissions and ownership for file transport

Log files/directories created via the file transport should be able to have configurable permissions and ownership (uid/gid).

They already do, per the mode option passed to fs.createWriteStream() which can be specified when creating a file transport
@ranjit-git's position is that the default should be more restrictive.

I'll be working on this!

My team has a solution to change the default permissions of the file transport to be more restrictive, but it would most likely be a breaking change. What are the current feelings/thoughts about a change for a more restrictive default?

I think the comments above from DABH sum it up pretty well: is there really a need to change the default, when any user can override that default for their application? It doesn't seem like the benefits of doing so would outweigh the drawbacks of having a breaking change, including all the associated requests for maintaining an additional version with backwards application of patches etc. to multiple versions on a project with zero maintenance budget.


About different initialization?

Hi, Xiaokang,
Congrats so solid work. I have a question about the different initialization, I check the code of the segmentation model, but I don't find the operation of parameters initialization, I want to know the details of this operation, could you give me some advice?
Best,
Xiangde.

Hi, weight initialization is here: https://github.com/charlesCXK/TorchSemiSeg/blob/0c10bf0b39924b804a0bf76ca6490123bfbb02a6/exp.voc/voc8.res50v3%2B.CPS/train.py#L84

Hi, Xiaokang,
Thanks for your so quick reply. My concerns have been solved, thanks!!!
Best,
Xiangde.


Admin consent still does not work according to documentation

Here is the link to the original issue.
https://github.com/MicrosoftDocs/azure-docs/issues/35484
The consent feature still seems to be broken.
Steps

Log in with User A
Open consent url for scope B (B requires admin consent, for example https://graph.microsoft.com/Directory.ReadWrite.All)
Log in as Admin, grand permissions
Login  User A again using scope B
Expected result: user logs in successfully and access token has B scope
Actual result: user is not granted scope B access, Admin approval appears.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ac43307-75d4-cb6f-e561-0dd9008f28c6
Version Independent ID: 8fc47e76-5ee1-6aeb-73e2-c64c44e3e4ed
Content: Microsoft identity platform scopes, permissions, and consent
Content Source: articles/active-directory/develop/v2-permissions-and-consent.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@iilyin Thanks for your feedback! We will investigate and update as appropriate.

Hello @iilyin
So it sounds like you're having issues with the tenant admin consent URL. You are utilizing the admin consent URL and it's not granting consent for user X in Tenant A with Admin Y who is also in Tenant A?
Can you please provide the admin consent URL endpoint you're using and a screenshot of the Consent page?
From the docs in regards to how the admin consent should work:
From the paragraph below from : https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#requesting-individual-user-consent
After the user enters their credentials, the Microsoft identity platform endpoint checks for a matching record of user consent. If the user has not consented to any of the requested permissions in the past, nor has an administrator consented to these permissions on behalf of the entire organization, the Microsoft identity platform endpoint asks the user to grant the requested permissions.
Granting Tenant Admin Consent, follow the instructions from : https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#requesting-consent-for-an-entire-tenant
And per the section : https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#admin-restricted-permissions
If your app requires access to admin-restricted scopes for organizations, you should request them directly from a company administrator, also by using the admin consent endpoint, described next.
If the application is requesting high privilege delegated permissions and an administrator grants these permissions via the admin consent endpoint, consent is granted for all users in the tenant.
If the application is requesting application permissions and an administrator grants these permissions via the admin consent endpoint, this grant isn't done on behalf of any specific user. Instead, the client application is granted permissions directly. These types of permissions are only used by daemon services and other non-interactive applications that run in the background.

Hi
Here is the link I'm using for admin consent https://login.microsoftonline.com/09fbd598-d84a-4406-bb90-a72ad1170877/adminconsent?client_id=090492c9-fb3f-4ffd-95de-00284f06f957&redirect_uri=https%3A%2F%2Flocalhost%2F.sso%2Fcode%2Foneid&state=%2Fbbbb%2F%3FinitiatedByOauth2TokenBroker%3Dtrue
Then I log in using admin credentials and get permission prompt page.

Hey @iilyin  I see, and can you please provide the user login URL that you're using?

Here is the login URL:
https://login.microsoftonline.com/09fbd598-d84a-4406-bb90-a72ad1170877/oauth2/v2.0/authorize?client_id=090492c9-fb3f-4ffd-95de-00284f06f957&prompt=login&redirect_uri=https%3A%2F%2Flocalhost%2F.sso%2Fcode%2Foneid&response_mode=form_post&response_type=code&scope=https%3A%2F%2Fgraph.microsoft.com%2FDirectory.ReadWrite.All&state=%2Fbbbb%2F%3FinitiatedByOauth2TokenBroker2

Hello @iilyin as we've enabled a one time free support ticket in regards to this issue I will be closing out this git issue now.
Hopefully we can get your issue resolved as soon as possible, and if you can please provide your resolution on this git thread for others.
Thanks!

Frank

Unfortunately, issue is still there, even when I use  https://login.microsoftonline.com/ivanilyinscandgmail.onmicrosoft.com for login and consent.
I get the following error when I try to login with guest user after admin granted consent:
invalid_grant: AADSTS65001: The user or administrator has not consented to use the application with ID '090492c9-fb3f-4ffd-95de-00284f06f957' named 'Test'. Send an interactive authorization request for this user and resource.
Trace ID: d95ce369-5f87-4b6e-b3bc-297ad6e93100
Correlation ID: d1ebf656-b6d4-44c6-a50b-a5926e62cabe
Timestamp: 2019-09-02 14:55:27Z

hey @iilyin you be working with the support team on this issue to figure out what's wrong in your environment. thanks

hello ,
I am facing the same issue.
Kindly suggest if it got resolved.
Regards
Aarushi

I am facing same issue.
Details:
Issue 1: Mentioning individual scopes in scope parameter returns admin_consent=True in response. But its not reflected in azure admin portal.
Issue 1:  After updating permissions to the application using API, when consent url is used with scope=.default, the newly added permissions are not listed in the consent page. It take 2-3 minutes after updating permissions for them to appear in the consent page in this case. But when application is queried using graph api immediately after updating permissions, the new permissions are returned in response, but not in consent page. Need to know from which directory, consent url page is getting the list of permissions and the api to get the same.


postgresql::server::grant with ensure => absent uses REVOKE instead of GRANT

This change updates the defined type postgresql::server::grant to introduce a new parameter:
ensure => present
-- or --
ensure => absent
ensure => present preserves the existing behaviour, using GRANT to add privileges
ensure => absent uses REVOKE to remove privileges
The SQL associated with the unless clause has been updated to work correctly, in general.

I've updated the code to include the improvements you have suggested.
Is there anything else that needs doing before these changes can be merged in?

I don't have rights on the repository.  I am just doing reviews to keep it clean.  I guess someone from Puppetlabs would pick this up.  This is a useful feature in my opinion.

Thanks, this would be very useful to have George, let us know if there's anything we can do to help get this merged @puppetlabs

@hunner  thanks for merging #894
Is there anything more I can do to help get this pull reques (#891) be merged in ?
I also have 2 more pull requests: #896 and #897 which are smaller and simpler than #891
Please let me know if there is anything I can do to help things along.

Hi @hunner
I've made one small change to this pull-request, which is to check that the role exits before revoking DB privileges, thus preventing this operation from failing
This is desirable because a common usage pattern is the revoke all privileges prior to dropping a role. On the next run, after the role is gone, we don't want the ensure=>absent to fail.
The ALL TABLES IN SCHEMA logic does not fail in this way, because it uses a custom SQL query instead of a function  like has_database_privilege() which is used by the DATABASE logic.
Thanks for your time.
George

I've updates this code to:

remove a merge conflict that arose due to changes introduced after the PR was created
fix a failing unit test associated with the same change

All tests are now passing, and there are no merge conflicts.
No functional changes were made to the code (whitespace changes only).

++

FYI - We logged a Puppet Enterprise support ticket to try and get some movement on getting @georgehansper's MRs actioned but they closed the support request saying its a different @Puppet team that supports the modules, it's in their backlog and they'll review it next sprint.

Issue is MODULES-5634

Hey @tphoney, thanks for merging #896 - would you mind taking a look this as well?

Hi @willmeek
I've fixed the merge-conflict on this branch, so the  needs-rebase label can be removed.

@hunner Per TP's request, could you look over this PR?

@georgehansper This is currently failing the inbuilt Rubocop checks. In order for it to be merged it would first need to be updated to match the set standards. Some example rubocop commands are shown below:
Run command:
bundle exec rubocop
Flags:
-a : run autocorrect
--display-cop-names : add so that each error shows its flag name
Disable Commands:
Disable rubocop over a block off code

# rubocop:disable Lint/UselessAssignment
    {Code Block}
# rubocop:enable Lint/UselessAssignment

Disable rubocop for a single line:

{Code Line} # rubocop:disable RSpec/InstanceVariable

@david22swan thanks for the pointers re rubocop.
I've started looking at this, and I expect to have these issues resolved soon.

@david22swan @hunner  I've resolved the merge conflicts and made rubocop happy again.

Thanks all


Added Cloudflare instructions to DNSSEC wizard

Added link and instructions for enabling DNSSEC on Cloudflare hosted domains.

@doplur thanks!


Add version reports to pyct

@jbednar @jlstevens @philippjfr I added the version report script from autover to pyct and set it up as a console script, and I also added unit tests for the report script. Master seems to be having some issues related to the Python version in Travis:
0.04s$ pip install pyctdev && doit ecosystem_setup pyenv: version 3.6' is not installed (set by PYENV_VERSION environment variable)
The command "pip install pyctdev && doit ecosystem_setup" failed and exited with 1 during .`
Does anyone have any thoughts on how to fix this issue? This has come up as an issue in a few other packages as well.

Does anyone have any thoughts on how to fix this issue? This has come up as an issue in a few other packages as well.

Travis changes over time, e.g. in terms of which version(s) of python are available by default.
In #81 I switch from 3.6 to 3.7 (probably the easiest way to fix the problem you're seeing). But it would be straightforward to test over multiple python 3 versions if we want to do that.

@kebowen730 looks like if you merge #81 then update this PR you could proceed.

I think I have the same comments as on https://github.com/pyviz-dev/autover/pull/36, so it would be great if you can figure them out (which could include dismissing them if they are wrong/outdated):

which is not usually available on windows (https://github.com/pyviz-dev/autover/pull/36/files#diff-6d957d8dc1a0b4c4d25fae190bff4bc3R26)
Might need to be careful how you run stuff. E.g. what someone gets when they type conda in their shell might be different from what happens if you run conda via subprocess without the shell - but I believe this has become much less confusing with conda in particular vs. how it used to be. So maybe nothing to do? (https://github.com/pyviz-dev/autover/pull/36#issuecomment-383050439)

Unit tests are great but I think it would also be helpful to actually run the command(s) during the tests. (https://github.com/pyviz-dev/autover/pull/36/files#diff-b91f3d5bd63fcd17221b267e851608e8R8)


Update teaching internship providers

Trello card
https://trello.com/c/jrKdpDQH/2929-update-teaching-internship-provider-list
Context
Imported from spreadsheet.

looks good to me! thanks


Colons after if statement condition cause parse failures

Similar to #195 , a colon following an if/else if statement's condition is valid in RBI!  It looks shockingly like python, though I suspect that's not the intention 😉  Another case of "colons are treated like newlines most of the time!"  Minimal working example:
sub main()
    a = 1
    if a > 0:
        print "positive!"
    else if a < 0:
        print "negative!"
    else:
        print "tHaT NuMbEr iS ZeRo"
    end if
end sub

@sjbarag I'm working on this


Add example fallback radius for theme function in README

I assumed the fallback was just a second arg to the theme function, but I had to check the source to be sure.  This PR just includes the fallback in the example in the README.

Awesome, thanks!


iobroker.accuweather adapter added

Hi,
here some review comments:

[E605] No actual year found in copyright. Please add "Copyright (c) 2020 algar42<EMAIL_ADDRESS>at the end of README.md
[E701] No actual year found in LICENSE. Please add "Copyright (c) 2020 algar42<EMAIL_ADDRESS>at the start of LICENSE
[E816] file tsconfig.json found in repository, but not found in .npmignore
If it makes sense to store the api keys or such in an encrypted form then you should implement that
you need to store and clear all timeouts and intervals on "unbind" (e.g. https://github.com/iobroker-community-adapters/ioBroker.accuweather/blob/master/main.js#L300), else compact mode is broken
please do not use setObject because this will pot. override custom settings on the object ( at least in controller < 2.0). Use setObjectNotExists

Please review and follow the development best practices: https://github.com/ioBroker/ioBroker.repositories#development-and-coding-best-practices

All points above should now be fixed

Timeouts could run up to 10 seconds. They must be stopped by unload too:
https://github.com/iobroker-community-adapters/ioBroker.accuweather/blob/master/main.js#L304

Timeouts could run up to 10 seconds. They must be stopped by unload too:
https://github.com/iobroker-community-adapters/ioBroker.accuweather/blob/master/main.js#L304

Thanks!
Updated. v1.1.3 published

Automated adapter checker
ioBroker.accuweather

[E301] Tests on Travis-ci.org are broken. Please fix.

It fails build for windows. it looks like it fails trying to deploy to npm - I don't know why and can't understand how to fix :(


Fix missing includes to string and absl::string_view

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9442853) 92.91% compared to head (0e64ade) 92.91%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   92.91%   92.91%
=======================================
  Files         358      358
  Lines       26572    26572
=======================================
  Hits        24689    24689
  Misses       1883     1883

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bring Back HTML to Markdown import feature from old version

Hi all. Great product.
I am requesting that you bring back the import from HTML (html to markdown) feature from v4. I used this quite a lot actually.
Thanks,
Gary

Looks like now there is no way to display a tasks list or a single checkbox. User extensions are not supported neither is HTML.

Fixed in v5.8.


Add verbose flag

Initial sketch of a solution to #153
These are my changes so far in their entirety (within environment.py::Environment::create_lockfile()):
verbose = True
process = subprocess.Popen(
    self.pin_command,
    stdout=subprocess.PIPE,
    stderr=None if verbose else subprocess.PIPE,
)
if verbose:
    while True:
        output = process.stdout.readline()
        if output == b'' and process.poll() is not None:
            break
        if output:
            print(output.strip())
    # TODO: Decide what to do about this
    # stdout, stderr = process.poll(), None

I haven't add the CLI argument for verbose as I'm not sure of the best way to hook this up;  also I'm not sure if this solution is workable. I've tested it, and it works, but there may be drawbacks from doing this that I'm not aware of and I'm pretty sure that using print(output.strip()) here isn't correct (should it be logger.info() or sys.stdout.write() maybe?).
Hopefully it's a starting point though?
It's passing flake8 and I've run pytest:
ERROR    pip-compile-multi:environment.py:218 Package django was resolved to different versions in different environments: 1.10.8 and 3.1.7
PASSED
tests/test_discover.py::test_discover_nested PASSED
tests/test_pipcompilemulti.py::test_fix_compatible_pin PASSED
tests/test_pipcompilemulti.py::test_no_fix_incompatible_pin PASSED
tests/test_pipcompilemulti.py::test_pin_is_ommitted_if_set_to_ignore PASSED
tests/test_pipcompilemulti.py::test_post_releases_are_kept_by_default PASSED
tests/test_pipcompilemulti.py::test_forbid_post_releases PASSED
tests/test_pipcompilemulti.py::test_parse_references[base.in-refs0] PASSED
tests/test_pipcompilemulti.py::test_parse_references[test.in-refs1] PASSED
tests/test_pipcompilemulti.py::test_parse_references[local.in-refs2] PASSED
tests/test_pipcompilemulti.py::test_split_header PASSED
tests/test_pipcompilemulti.py::test_concatenation PASSED
tests/test_pipcompilemulti.py::test_parse_hashes_with_comment PASSED
tests/test_pipcompilemulti.py::test_parse_hashes_without_comment PASSED
tests/test_pipcompilemulti.py::test_serialize_hashes PASSED
tests/test_pipcompilemulti.py::test_reference_cluster PASSED
tests/test_pipcompilemulti.py::test_parse_vcs_dependencies PASSED
tests/test_pipcompilemulti.py::test_merged_packages_raise_for_conflict
-------------------------------------------------------------------------------------------------------------- live log call ---------------------------------------------------------------------------------------------------------------
ERROR    pip-compile-multi:utils.py:79 Package x was resolved to different versions in different environments: 2 and 1
PASSED
tests/test_pipcompilemulti.py::test_fix_pin_detects_version_conflict
-------------------------------------------------------------------------------------------------------------- live log call ---------------------------------------------------------------------------------------------------------------
ERROR    pip-compile-multi:environment.py:218 Package x was resolved to different versions in different environments: 2 and 1
PASSED
tests/test_upgrade_feature.py::test_upgrade_package_disables_upgrade PASSED
tests/test_utils.py::test_recursive_refs PASSED

====================================================================================================== 49 passed in 114.33s (0:01:54) ======================================================================================================

Looking good. The outstanding steps:

Add -v/--verbose option through a feature in features/ directory.
Fix logging for pip-tools failure.

Closing in favor of #251


nGraph-ONNX CI improvement

Added parallel CI on many SKUs,
Jenkinsfile written in Declarative Pipeline which allows displaying sequential stages for parallel branches in Blue Ocean
Moved proper CI code to ngraph-onnx repository
Moved base_image_builder to ngraph-onnx repository

Let's test this CI on nGraph-ONNX repo first.


Import failure

Following the directions from https://www.baremaps.com/installation/ every time I try to execute an import java throws an error.
Configuration:
Centos 7
openjdk version "11.0.10" 2021-01-19 LTS
OpenJDK Runtime Environment 18.9 (build 11.0.10+9-LTS)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.10+9-LTS, mixed mode, sharing)
lmdb.x86_64,  lmdb-devel.x86_64,  lmdb-libs.x86_64:  0.9.22-2.el7
baremaps --version
output: Baremaps vnull
Problematic command:
baremaps import --database 'jdbc:postgresql://localhost:5432/baremaps?&user=baremaps&password=baremaps' --file 'https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf'
Output:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.lmdbjava.ByteBufferProxy$AbstractByteBufferProxy (file:/home/.../baremaps/lib/lmdbjava-0.8.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of org.lmdbjava.ByteBufferProxy$AbstractByteBufferProxy
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Exception in thread "main" java.lang.UnsatisfiedLinkError: /tmp/lmdbjava-native-library-5763257190218430362.so: failed to map segment from shared object: Operation not permitted
at jnr.ffi.provider.jffi.NativeLibrary.loadNativeLibraries(NativeLibrary.java:93)
at jnr.ffi.provider.jffi.NativeLibrary.getNativeLibraries(NativeLibrary.java:71)
at jnr.ffi.provider.jffi.NativeLibrary.getSymbolAddress(NativeLibrary.java:50)
at jnr.ffi.provider.jffi.NativeLibrary.findSymbolAddress(NativeLibrary.java:60)
at jnr.ffi.provider.jffi.AsmLibraryLoader.generateInterfaceImpl(AsmLibraryLoader.java:138)
at jnr.ffi.provider.jffi.AsmLibraryLoader.loadLibrary(AsmLibraryLoader.java:86)
at jnr.ffi.provider.jffi.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.java:44)
at jnr.ffi.LibraryLoader.load(LibraryLoader.java:392)
at jnr.ffi.LibraryLoader.load(LibraryLoader.java:371)
at org.lmdbjava.Library.(Library.java:125)
at org.lmdbjava.Env$Builder.open(Env.java:486)
at org.lmdbjava.Env$Builder.open(Env.java:512)
at com.baremaps.cli.Import.call(Import.java:119)
at com.baremaps.cli.Import.call(Import.java:48)
at picocli.CommandLine.executeUserObject(CommandLine.java:1933)
at picocli.CommandLine.access$1200(CommandLine.java:145)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2332)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2326)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2291)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2159)
at picocli.CommandLine.execute(CommandLine.java:2058)
at com.baremaps.cli.Baremaps.main(Baremaps.java:53)

Thanks a lot for reporting this issue.
The log seems to indicate that Java is not able to access the binary of LMDB. This binary (lmdbjava-native-library-*.so with a varying suffix) is extracted by the java application in the /tmp directory. Does this file exist? Does your current user have the permission to write in this directory?
Exception in thread "main" java.lang.UnsatisfiedLinkError: /tmp/lmdbjava-native-library-5763257190218430362.so: failed to map segment from shared object: Operation not permitted

Unfortunately, I havn't been able to reproduce the error with a centos docker image with the root user. I obtained a bash in centos with the following command:
docker run --network="host" --rm -it centos bash

I then installed the missing dependencies:
yum install unzip wget java-11-openjdk-devel
wget https://github.com/baremaps/baremaps/releases/latest/download/baremaps.zip
unzip baremaps.zip
export PATH=$PATH:`pwd`/baremaps/bin

And finally, successfully executed the following commands (Notice that postgis is running on my host):
baremaps execute \
  --database 'jdbc:postgresql://localhost:5432/baremaps?&user=baremaps&password=baremaps' \
  --file 'res://osm_create_extensions.sql' \
  --file 'res://osm_drop_tables.sql' \
  --file 'res://osm_create_tables.sql' \
  --file 'res://osm_create_gist_indexes.sql' \
  --file 'res://osm_create_gin_indexes.sql'
baremaps import \
  --database 'jdbc:postgresql://localhost:5432/baremaps?&user=baremaps&password=baremaps' \
  --file 'https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf'

I get the following log for the last command and the data looks correct:
[INFO ] 2021-04-20 21:55:41.670 [main] Import - 6 processors available
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.lmdbjava.ByteBufferProxy$AbstractByteBufferProxy (file:/baremaps/lib/lmdbjava-0.8.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of org.lmdbjava.ByteBufferProxy$AbstractByteBufferProxy
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO ] 2021-04-20 21:55:42.065 [main] HttpBlobStore - Read https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf
[INFO ] 2021-04-20 21:55:42.776 [main] ImportTask - Creating cache
[INFO ] 2021-04-20 21:55:44.004 [main] ImportTask - Importing data

Hope this helps.

I think this issue can be closed; cannot confirm if the 'sudo yum install lmdb-devel' had any impact but the cause has been identified. Turns out the way /tmp was configured (too small and fixed size) caused not only the aforementioned problem but another one further upstream.

Great, glad to know that it helped.


Test PR checks

FYI, the automatic update of on release is working very well for lv_sim_eclipse_sdl. Only a confdef.txt neesd to be added and the release script will craete new lv_conf.h and change the listed defines.
We can add it to this, codeblocks or any other projects too.

I see no problem with adding it here. CodeBlocks will still need to be updated manually (or have a custom script written) as it does not refresh its view of the folders automatically.

Eclipse also needs an extra refresh, but I think it's much better than having older versions.
Let me know if you added the configs and I'll update the release script.

Is there a reason why we can't use a stub lv_conf.h file instead, with only the required defines? lv_conf_internal.h appears to automatically define all the default values if they are not present.

It'd be possible. However, I think it's important for people to see all the options in one place.

True; I didn't think of that. Alright; I will add a confdef.txt file on the weekend.

@kisvegabor I've added confdef.txt, but I'm not sure how to go about testing it.

It's part of the release script so it can't be run separately.
I was thinking about adding release scripts to every project but it'd be duplication in every project.
So now it looks like this:

lvgl, lv_examples, lv_drivers are released from master. (tag, merge to release branches)
Projects ar updated from the release branches
Merge dev to master.

What should we change to make the live examples work?


Render tiles directly to the map canvas

This change removes the overhead of rendering tiles to an intermediate canvas.
There were two challenges with this approach:

Avoid rendering of multiple resolutions of the same region for non-opaque layers. To achieve this, we store a list of extents of all higher resolution tiles for each tile in the new clipExtents member. In composeFrame, we create a clip mask for each low resolution tile. The holes will be filled by higher resolution tiles.

Avoid gaps between tiles. For non-rotated views, this is done by using the tile closest to the center as origin, and then adding tile widths and heights for other tiles. For rotated views, since we no longer can rotate the whole intermediate canvas, we render tiles with a 0.25 pixels overlap (0.5 pixels for opaque layers where tiny overlaps are not visible).

@tschaub, you may want to have a look at this to make sure that my changes to ol.source.Raster make sense.

I was looking forward to this! Thanks Andreas for this PR.
Do you see any chance for giving some sort of performance comparison before and after? Like fps comparisons e.g.?
Anyhow, I am really glad you tackle this.

@marcjansen I did not do any accurate testing, just these using an updated version of http://openlayers.org/en/v3.1.1/resources/display-frame-rate.js: For very fast zooming through all zoom levels in the wms-tiled example: before this change, the frame rate drops to 30fps on my machine. After this change, it stays at 50-60fps. Very fast panning in the same example: 55fps before this change, and 60fps after this change. I think you'll be able to see more performance gains with your applications that have 10+ layers.

@ahocevar: this sounds very good already! Thanks again. I am off duty so cannot look into it in detail, but I promise to test this early next year.

This should not block this from being merged if someone else reviews it.

With this change, it's not possible to listen to the postcompose event of a tile layer and have access to a canvas of just this layer (for color hit detection, for example), or I’m wrong?

You are wrong @tonio. Like for vector and vector tile layers, a separate canvas is used when there are listeners for layer compose/render events.

OK, good to know, thanks for the explanation.

Great to see you've taken this on @ahocevar.  I'll try to put some review time in early this week (I've been enjoying a chunk of computer-free vacation).

As promised I tested this inside one of our applications. In that application ~25 single tile layers (sometimes even more) are rendered. The application is very laggy when panning and zooming (only ~7 fps). With this patch applied things do not change in a noticeable way, sadly. Nothing is broken, though.

@marcjansen Do yo mean "single tile layers" as in ol.source.ImageWMS, or as in "distinct tile layers"? Because for the former, there are no changes with my patch - image layers are rendered to the map canvas directly already.

@ahocevar I meant ol.source.ImageWMS… so it isn't surprising that no effect can be observed. Thanks for the clarification.

@marcjansen Any chance you can change your app to use TileWMS sources and compare master with my patch?

I will give feedback tomorrow. We have plenty of apps to change 😊.

I just checked again with TileWMS sources (~25) and that particular application does not become noticeably faster, but I also couldn't find any detrimental effects. I was hopping to see a nice improvement, but the perceived laggyness didn't change in a noticeable way. Again, I don't consider this a blocker.
Is there any way we can have this measured reliably (with a script or sth.)?

@tschaub I rebased this pull request, in case you still want to take a look.

@tschaub I added another commit which implements what you had suggested in the hangout the other day - rotation of the map canvas after composition, instead of applying rotation for each layer. I'm pretty sure some transform can now be simplified, but I'd like to get at least a general ok before I spend even more time on this.

This looks great to me @ahocevar.  I haven't set up a comparison with many layers, but even if it isn't a big performance gain there, I think it is a good simplification.

@tschaub Maybe you want to take another quick glance before I merge.
I was able to simplify transforms a bit. However, testing with all examples, I found that a transform needs to be applied now before dispatching layer pre-/postcompose events. I added that.
The layer-clipping example needed a few changes, because it made too many assumptions about the internal setup of the layer canvas. So I added a paragraph with code snippets to the upgrade notes.

Does anyone want to take another look at this?

Great work, Andreas.
I will not have the time to honestly test this. From looking through the diff I really like the changes. Thanks for also including tests and upgrade notes. I will try to convince someone to throw this into our applications... but I cannot promise anything.

LGTM

Thanks Fred for jumping in! And thanks Andreas for providing the PR.

Thanks for the reviews!

Are there a example page, where the improvement in rendering performance is illustrated? When i upgrade my project to using to 3.14.2, there is a real slowdown in perfomance. There more tilelayers the bigger difference in performance.

@syntax42 Comparisons were made using the animation.html example, but that has only one tile layer. Reports from developers playing with many layers indicated that there is no significant performance gain, but also no slowdown. Are you able to share a map with many tile layers to compare?
Another thing that changed in 3.14.x is the way tiles are loaded. So the question is: are you seeing a slowdown in tile loading or in panning/zooming.

I also noticed a lot of artifacts when panning / zooming. And white lines between tiles where briefly visible.

This was an issue in 3.14.0 and 3.14.1 and should be fixed in 3.14.2. See #4960.
Another related issue still in 3.14.2, which only affects Firefox though, is #5024.

It seems that tile reprojection using chrome (on widnows OS) is not working as expected. The problem seems to exist since current fix (ol version 3.14 and above) . You may see the buggy attitude on  this example using chrome on windows OS. Using Firefox no such problem exist. No errors in the console.

@ptsagkis Did you do a git bisect to find out that this pull request causes #5236, or was this just a guess?

To be honest I am not very familiar with the technology behind.(I am not so sure what git bisect is) . It is a guess but it seems this change cause the problem as tile rendering has change since this fix and this where problems rised up. On version 3.13 there was no problem with the example above.


ws4py broken using cherrypy>=11.1.0

ws4py appears to be broken when using latest ws4py and cherrypy>=11.1.0 (installed via pip). Specifically I'm using python 2.7 and I've got these package versions installed:

ws4py==0.4.2
cheroot==5.9.1

I've tested with CherryPy==

Works: 10.2.1 | 10.2.2 | 11.0.0
Broken: 11.1.0 | 11.2.0 | 12.0.0 | 12.0.1

When running the simple server example I get the following error when I make a websocket connection to this server:
<IP_ADDRESS> - - [23/Nov/2017:14:58:23] "GET /ws HTTP/1.1" 101 - "" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0"
[23/Nov/2017:14:58:23] ENGINE AttributeError("'NoneType' object has no attribute 'recv'",)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 1112, in communicate
    req.parse_request()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 638, in parse_request
    success = self.read_request_line()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 676, in read_request_line
    request_line = self.rfile.readline()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 233, in readline
    data = self.rfile.readline(256)
  File "/usr/local/lib/python2.7/dist-packages/cheroot/makefile.py", line 233, in readline
    data = self.recv(self._rbufsize)
  File "/usr/local/lib/python2.7/dist-packages/cheroot/makefile.py", line 87, in recv
    data = self._sock.recv(size)
AttributeError: 'NoneType' object has no attribute 'recv'

i have identified and fixed the problem... currently pending (pull request #236 ).

@moan-graetz - many thanks. Have just verified that this does seem to fix the issue I was seeing.

it should :) because we had the same problem... took me a while to find
out, and i was amused on the actual problem when i found it.
On Mon, Dec 11, 2017 at 1:06 PM, Matt Hammond<EMAIL_ADDRESS>wrote:

@moan-graetz - many thanks. Have just verified that this does seem to fix
the issue I was seeing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Lawouach/WebSocket-for-Python/issues/235#issuecomment-350692983,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AftuOR5r1Ku_OKBBNJcx7O4R3gq_Sj42ks5s_Qy3gaJpZM4Qo5Cd
.

--
Noam Graetz
Chief Software Architect
Firmitas Cyber Solutions (Israel) Ltd.
M. +972 54 495 6898 <%2B972%2054%20593%207777>
T. +972 72 215 1170 ext 204
E. noam.graetz@firmitas- <EMAIL_ADDRESS>http://www.firmitas.solutions/
--

The information contained in this communication is intended solely for the
use of the individual or entity to whom it is addressed and others
authorized to receive it. It may contain confidential or legally privileged
information. If you are not the intended recipient you are hereby notified
that any disclosure, copying, distribution or taking any action in reliance
on the contents of this information is strictly prohibited and may be
unlawful. If you have received this communication in error, please notify
us at<EMAIL_ADDRESS>immediately and then delete it from your
system. Firmitas is neither liable for the proper and complete transmission
of the information contained in this communication nor for any delay in its
receipt.

@Lawouach I've just tested version 0.4.3 with latest cherrypy version 13.1.0 and I confirm it's fixed.

@Lawouach @noam-graetz  ... have also just tested with ws4py==0.4.3 and cherrypy==13.1.0. Looks good.
Many thanks. Closing this issue as it is now resolved.


Two errors in examples/smart_contracts/v2/javascript/statefulSmartContracts.js

Describe the error
Two minor errors prevent the script from running as-is

In main() the API server is algodServer but the global defined variable is actually named algodAddress

In main() a date is created as a UTC string, then cast back to a Date object. Later, the date is used in Buffer.from() which expects only a string and throws a TypeError.

err TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type number
    at Function.from (buffer.js:305:9)
    at Function.from (buffer.js:292:21)
    at main (/Users/tdb/Documents/GitHub/sdk-samples/javascript/app-setup.js:517:40)
    at processTicksAndRejections (internal/process/task_queues.js:94:5) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Link to the page or line
Link to the page and line/s if applicable either in the markdown version or on the site itself.
https://github.com/algorand/docs/blob/master/examples/smart_contracts/v2/javascript/statefulSmartContracts.js

line 8
line 550-553

Optional - The recommended fix if you have one
If you know what the change should be, tell us here.

Change algodAddress to algodServer
drop the wrapping new Date() leaving only new Date().toUTCString();

Optional - Supporting Screenshots
Any accompanying screenshots that will help us identify the problem or the fix.

Fixed. Closing issue.


from reinvent_scoring.scoring.scoring_function_parameters import ScoringFuncionParameters

this import statement is failing all over the place due to the typo.
it should be ScoringFunctionParameters and not ScoringFuncionParameters because it is that way in the reinvent_scoring package. I had to manually install reinvent_chemistry, reinvent_models and reinvent_scoring and also create the json.config file

I suspect you have installed version of reinvent-scoring that is different from reinvent-scoring==0.0.41.
We have fixed the typo in the later library releases but we havent updated the public git repo.

@ilknuricke-Takeda
When I ran examples at ReinventCommunity/notebooks, I got the error messages:
Traceback (most recent call last):
File "../../Reinvent/input.py", line 6, in
from running_modes.manager import Manager
File "/home/xzhang/projects/Reinvent/running_modes/manager.py", line 4, in
from running_modes.configurations import GeneralConfigurationEnvelope
File "/home/xzhang/projects/Reinvent/running_modes/configurations/init.py", line 2, in
from running_modes.configurations.scoring import ScoringRunnerComponents, ScoringRunnerConfiguration
File "/home/xzhang/projects/Reinvent/running_modes/configurations/scoring/init.py", line 1, in
from running_modes.configurations.scoring.scoring_runner_components import ScoringRunnerComponents
File "/home/xzhang/projects/Reinvent/running_modes/configurations/scoring/scoring_runner_components.py", line 3, in
from reinvent_scoring.scoring import ScoringFuncionParameters
ModuleNotFoundError: No module named 'reinvent_scoring'
You can see that the function neme was still "ScoringFuncionParameters", I changed it into ScoringFunctionParameters two places in file "Reinvent/running_modes/configurations/scoring/scoring_runner_components.py" and also in file "Reinvent.v3.0/running_modes/configurations/reinforcement_learning/reinforcement_learning_components.py". I am not sure where else still has this typo. I pip install  reinvent_chemistry, reinvent_models, and reinvent_scoring, but errors are still there.
Traceback (most recent call last):
File "../../Reinvent.v3.0/input.py", line 6, in
from running_modes.manager import Manager
File "/home/xzhang/projects/Reinvent.v3.0/running_modes/manager.py", line 4, in
from running_modes.configurations import GeneralConfigurationEnvelope
File "/home/xzhang/projects/Reinvent.v3.0/running_modes/configurations/init.py", line 2, in
from running_modes.configurations.scoring import ScoringRunnerComponents, ScoringRunnerConfiguration
File "/home/xzhang/projects/Reinvent.v3.0/running_modes/configurations/scoring/init.py", line 1, in
from running_modes.configurations.scoring.scoring_runner_components import ScoringRunnerComponents
File "/home/xzhang/projects/Reinvent.v3.0/running_modes/configurations/scoring/scoring_runner_components.py", line 5, in
from reinvent_scoring.scoring import ScoringFunctionParameters
ModuleNotFoundError: No module named 'reinvent_scoring'
In reinvent.v3.0 virtual environment, I import reinvent_scoring, it works. I don't know why it didn't work in ReinventCommunity virtual environment.
Your suggestions are highly appreciated. Thanks


No supported way to get js doc tags from extraneous comments

🔎 Search Terms
ts.getJSDocTags
JSDoc tag not found
🕗 Version & Regression Information
Seen in TS 4.0 and 4.1

This is the behavior in every version I tried, and I reviewed the FAQ for entries about the compiler API

💻 Code
Consider the input file:

/** @foo */

/** @bar */

var x;

As far as I can tell, there's no supported compiler API to access the @foo jsdoc tag. I've resorted to casting ts.Node to {jsDoc?: ts.JSDoc[]}.
🙁 Actual behavior
ts.getJSDocTags and friends only give the @bar JSDoc tag
🙂 Expected behavior
That method, or another, to return both the @foo and @bar tags.

Full compiler code sample to repro
import * as ts from 'typescript';

const filename = 'some_code.ts';
const program = ts.createProgram(['some_code.ts'], {noEmit: true});
program.emit();
const sourceFile = program.getSourceFile(filename);
if (!sourceFile) {
  throw new Error('could not get source file');
}

console.log(`getJSDocTags:`);
console.log([...getAllTags(sourceFile, (node) => ts.getJSDocTags(node))].map(
    (t) => t.tagName.text));
console.log(`Accessing jsDoc directly:`);
console.log(
    [...getAllTags(sourceFile, accessJsDoc)].map((t) => t.tagName.text));

function accessJsDoc(node: ts.Node): ts.JSDocTag[] {
  const tags = [];
  for (const jsDoc of (node as {jsDoc?: ts.JSDoc[]}).jsDoc ?? []) {
    for (const tag of jsDoc.tags ?? []) {
      tags.push(tag);
    }
  }
  return tags;
}

type TagGetter = (node: ts.Node) => Iterable<ts.JSDocTag>;
function getAllTags(
    node: ts.Node, getter: TagGetter, tags = new Set<ts.JSDocTag>()) {
  for (const tag of getter(node)) {
    tags.add(tag);
  }
  ts.forEachChild(node, (child) => {
    getAllTags(child, getter, tags);
  });
  return tags;
}

@sandersn is there (or should there be) an API for this?

So far, we've tried to treat the jsDoc property as internal information so that people won't incorrectly miss the association between, for example, x's VariableDeclaration and @bar, which is actually on the containing VariableStatement.
Generally there are two kinds of jsdoc: attached annotations (eg the @bar attached to x) and unattached declarations (eg @typedef).
Here's how the compiler works with the two kinds:

Look up jsdoc on nodes that are known to have attached-annotation jsdoc, using getJSDocTags or a more specific variant. Used for specific semantics.
Look up jsdoc on nodes that might have attached jsdoc, using hasJSDocNodes(node: Node): node is HasJSDoc, which is internal now. Used for generic purposes like tree walking or tree cleanup.
Walk the entire tree and treat unattached-declaration jsdoc nodes just like any other nodes (having obtained them as needed using hasJSDocNodes).

There's no safe, high-level API for getting unattached-declaration jsdoc tags. It's definitely a hole in our API that we don't -- but we haven't needed anything like it internally because we walk the AST all the time instead.
@rictic can you elaborate on the problem you're trying to solve? Are you trying to find all the declaration-like tags?

Consider:
/**
 * @requirecss {./styles}
 * @license
 * legal text legal text legal text
 */

/**
 * Comment describing Foo.
 */
export class Foo {}

Arguably this code is wrong, and one shouldn't have two successive jsdoc comments.
However, some jsdoc annotations like @license and @fileoverview are understood as documenting the file itself, not any node in that file.
Additionally, if multiple successive jsdoc comments are incorrect, I'd like to use the TypeScript API to emit a diagnostic in that case. For example, suppose that @foo and @bar are meaningful jsdoc tags that a tool is acting upon. I'd like to emit a diagnostic in this case, telling the user to collapse these two comments into one:
/** @foo */
/** @bar */
var x;

No, unattached-declaration jsdoc is legal and meaningful, we just don't have a high-level API to get it because we've never needed it.
File-initial jsdoc is so common that I think the best high-level API would be something that is, basically
function getFileInitialJSDoc(file: SourceFile) {
  if (file.statements.length && hasJSDocNodes(file.statements[0]) && file.statements[0].jsDoc.length > 1)
    return file.statements[0].jsDoc[0]
  // plus maybe a case for EndOfFileToken in case there aren't any statements in the file,
  // plus maybe return all but the last jsdoc from the first statement
}

Then we could worry about a complex "find all unattached jsdoc" later, if it's ever needed.

As for typedefs, it's annoying that whenever they're followed by a function declaration, TS attaches that docblock to this function and shows typedefs as part of the function's description whenever its name is hovered.

Same thing with variable declarations. Would be good to keep typedef-only docblocks unattached. Is this a known issue?

So far I think we have two separate bugs:

Some API users want to find the file-initial jsdoc that commonly contains a header. Typescript doesn't understand file-level tags, so it's never needed an easy way to get this jsdoc. My comment above gives a partial design for that function with a couple of unanswered questions. @rictic does the above function look like it meets your needs?
Declaration-like jsdocs are incorrectly attached to the following statement. The fix is probably as simple as a filter somewhere, but I'm not sure which component should do the filtering. @thorn0 can you file a new bug for the above so we can track and discuss it separately?

can you file a new bug

Done: https://github.com/microsoft/TypeScript/issues/43534


Crash upon trying to create Molten Mithril

https://pastebin.com/T5CXgYBm
Using
base-1.12-3.4.0-SNAPSHOT.68
ContentTweaker 1.12-4.1.0-Snapshot 42
Looks like it doesn't like duplicated molten metals when another mod adds in it's own molten item

Material System now warns when duplicates are added, so this shouldn't happen anymore


Vue component not supported in vue 2.x

This issue occurs because  vue3 was selected during the development mode of the  vue-sfc npm package.

We can look into using vue2 for development so it could work for both versions?

@ram-verida  @kalanamt  any thought on how to resolve this issue?
screenshot from browser

console :

Source code error :

We have limited resources. I'm comfortable if we say these are only Vue3 components.
@nick-verida ?

Closing this.


[MB-4635] Display allowances in move allowances sidebar component

Description
This creates a new component, AllowancesDetailForm, that will be the main body content when editing allowances from the Move Details page in the TOO UI.  Currently we're only displaying the existing read-only allowance entitlement values but it will eventually contain the form for editing the authorized weight and other fields.
Reviewer Notes
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Login as the TOO user
Select a move from the queue, bringing you to the Move Details page
Scroll to find the Allowances section
Click on the Edit allowances button
The sidebar component should load displaying the 4 values for Weight Allowance, Pro-gear, Spouse Pro-gear, and Storage in-transit

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
Abstract

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-4635

  Generated by :no_entry_sign: dangerJS against 5c3f1ae15708c60668f0e84730638dc934e25335


Image Node Drag and Drop issue

When I drag my image node which looks like below :-
  const newNode = {
                id: getId(),
                type: 'img',
                position,
                data: { label:

 }
    };

Sometimes, I see a snapshot of an image that is being dragged and sometimes I see the actual node is getting dragged. The issue is with the former case.
Issue - The actual node remains at the same position while the snapshot becomes the draggable item. When I release the item at different position, I don't see the actual node gets dropped at new position. Now if I move my cursor a bit, then actual node becomes the draggable item and then I am able to put it successfully wherever I want to.
Unfortunately, I am unable to show the recording here because when I start the recording, I am unable to drag the node. This might be another issue with the library which I am totally unsure about.
I am on Mac using chrome.

The ids must be strings. If the issue still occurs please create a codesandbox so that we can have a look.

@moklick Thank you for your response :-)
The ids are in strings only.
As asked, I have created the demo on codesandbox https://codesandbox.io/s/busy-ishizaka-suj71?file=/src/App.js.
The issue can be clearly seen here as well that whenever I drag the image, the actual node does not get dragged rather the snapshot of it. When I release my cursor, I don't see the node getting dropped to new position. Now, if I move my cursor a bit, I will start seeing the actual node being dragged with my cursor and now I can put it wherever I want to.
Please let me know if you need more details.

I never added an image to a node. I think you need to prevent the default browser behaviour with pointer-events: none for the image.

Perfect! Thank you so much.


add possibility to show locale/language for test runs

maybe we can use this field as 1st one to organize optional column which can be shown and hide

Duplicates #1777, closing


⚠ Samsung has degraded performance

In 0264faa, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2761 ms

Resolved: Samsung performance has improved in fef0c74.


Scenario 1: Long-distance trips (e.g. Park rangers, forestry officers, sheriffs):

Long-distance trips (E.G. Park rangers, forestry officers, sheriffs): Test the application's ability to plan a long-distance trip through remote regions, including overnight stops and stops at multiple locations while optimizing charging and minimizing total trip time. The charging stops must be at convenient, safe and appropriate locations and that the planned route must include a reasonable range safety margin at all points in the route.

It would be optimal for the parameters for such trips to be supplied to the dev team.
e.g.  define the start and end and any waypoints in between so they can be used for testing


Update README.md

Added a link to auto generated docs

Merged in master https://github.com/cashapp/misk/commit/65fb3532f893c9a25b7a6e0b2615fa111c4b30b2


Fix decorator parsing for async functions

This PR addresses an issue with parsing decorators right before async function definitions.
A good example to illustrate the issue is overload.
from typing import overload

@overload
async def func(x: int) -> int:
    ...

async def func(x: int | str) -> int | str:
    """Do something."""
    pass

At the moment, this would emit a D103 error for the first definition.
D103: Missing docstring in public function

That's because, parsing the decorator name wasn't stopped with async and thus overload became overloadasync and didn't match any is_overload checks anymore.

Moved the changelog entry again, since I didn't saw that 6.2.1 was released an hour ago.


New functionality: impulse response

As a general purpose tool, HARK should have several varieties of impulse response.  I know that Edmund is already working on this, so this issue is kind of a freebie.
Comment here if you have particular features / flavors that you would like accommodated.  Or if you are Edmund and want to tell everyone what you're planning.

This is connected with Dolo/Dolark, need to think through how to incorporate into HARK.

dolo has some good tools for doing impulse responses (I think called irf).  I very much like the implementation of simulation and irf's in dolo and think we should basically adopt dolo's tools.

Best way to handle this is to get to the point where we can simulate HARK models in Dolo.


Remove prebuilt binaries

Hey! I love this idea, it sounds like it will break up the monotony of a long work day, as well as rewarding new developers for committing often.
The only problem I have with it is that there are two prebuilt binaries in this repository. From a security and portability perspective, it will be more widely accepted and useable if the installation either downloaded the neutralino binaries from a trusted source, or built them using the official source repository.

Hey.. Thanks.. First I tried to draw image in console. (But image is no so fine with large pixels), Then possibilities were nw.js, electron and neutralino. Yeah agree. We can download binaries with npm post install maybe


Some ideas about rust-lang on VSCode

I have created an issue about rust-lang syntax highlight suggestion for VSCode. The rust-lang grammar based on  zargony/atom-language-rust project. The problem is that zargony look like not enough care about Issues and pull requests. I think the best way to upgrade rust-lang to official project, just like vscode-go project.
Rust-lang have an official RLS implement , rust-analysis and other unofficial tools. So, could VSCode do that?

Rust support is already coming from the community. If there is a better grammar out there that we can use, please let us know


KEYBOARD SHORTCUT CHANGED!! - Suggest a better one

Alt+Shift+L causes so many troubles, that I think it's time to think about a better default. The current shortcut was introduced in #11.
Rules of the game:

Read the issues to understand what drives people to complain (e.g. Alt+Shift conflicts with international layouts)
The new shortcut should not conflict with a common browser functionality - in Chrome and in Firefox.
There are browser restrictions on what keys can be used.

I personally use Ctrl+Shift+O, but I know that it conflicts with opening a bookmark manager in Chrome, so not a perfect candidate.
Make your suggestions!

Good idea. I can also add to the list of issues that Lenovo laptops dump a debug log of the touchpad driver upon pressing Alt+Shift+L, so it really isn't ideal 🙂

I prefer minimal keyboard chording/keeping modifiers to a minimum. How about a combination that's pretty much guaranteed not to conflict with the browser, like Ctrl+grave? That's pretty easy to execute with one hand.

@ainola I agree about the minimal modifiers thing, although we should also consider non-en-US keyboard layouts. (Try pressing Ctrl+</kbd> on a German keyboard without breaking your fingers 😉)

New discovery: there are browser restrictions on what keys can be used. Grave, slash and backslash are not among them.

Key combinations must consist of two or three keys:

modifier (mandatory, except for function keys). This can be any of: "Ctrl", "Alt", "Command", "MacCtrl".
secondary modifier (optional). If supplied, this must be "Shift".
key (mandatory). This can be any one of:

the letters A-Z
the numbers 0-9
the function keys F1-F12
Comma, Period, Home, End, PageUp, PageDown, Space, Insert, Delete, Up, Down, Left, Right

My suggestions:

Ctrl+Shift+E - simple enough to type with one hand
Ctrl+Shift+L - similar enough to the current shortcut

Ctrl+Shift+E clashes with Pushbullet, a pretty popular extension (1m+ users).
Ctrl+Shift+L works as far as I can tell (no clashes on my system at least).

I'll do the following: I change the default to Ctrl+Shift+L, but leave the issue open for a while.
Those who come to Github to complain about the problems with new shortcut will easily find this ticket and explain why it is a bad hotkey.
If we don't hear complaints for a while, we will consider the matter resolved 🙂

Looks like everyone is happy with the current shortcut 😊 thus closing.

As a friendly heads up for anyone who comes across this in future:
This shortcut overlaps with i3 window vertical resizes. It's a default of the window manager and changing the shortcut for that one function isn't really a sane option - short of changing the shortcut and reinstalling it yourself each time the repo changes (or IIUC in the case of firefox, each time you restart firefox), you'll probably be clicking on the icon manually

Thanks for the heads-up. I should add that the problem is more annoying to Firefox users who are stuck with the default shortcut, in Chrome you can override the default one and configure your favorite shortcut.
chrome://extensions/ and in the bottom right there is "Keyboard shortcuts".

Thanks for adding that! Forgot to mention the thing with Firefox, as I first encountered it in that browser. Back on Chrome now due to reasons, so the ability to override the shortcut again is definitely nice!


Problem Compiling

I couldn't compile files with raylib-cpp.hpp. It gives these errors:
In file included from /usr/local/include/raylib-cpp.hpp:41,                  from core_basic_window.cpp:22: /usr/local/include/Functions.hpp: In function 'std::vector<std::__cxx11::basic_string<char> > raylib::GetDirectoryFiles(const string&)': /usr/local/include/Functions.hpp:150:22: error: '::GetDirectoryFiles' has not been declared; did you mean 'raylib::GetDirectoryFiles'?   150 |     char** files = ::GetDirectoryFiles(dirPath.c_str(), &count);       |                      ^~~~~~~~~~~~~~~~~       |                      raylib::GetDirectoryFiles /usr/local/include/Functions.hpp:148:35: note: 'raylib::GetDirectoryFiles' declared here   148 | RLCPPAPI std::vector<std::string> GetDirectoryFiles(const std::string& dirPath) {       |                                   ^~~~~~~~~~~~~~~~~ /usr/local/include/Functions.hpp:152:7: error: '::ClearDirectoryFiles' has not been declared; did you mean 'LoadDirectoryFiles'?   152 |     ::ClearDirectoryFiles();       |       ^~~~~~~~~~~~~~~~~~~       |       LoadDirectoryFiles /usr/local/include/Functions.hpp: In function 'std::vector<std::__cxx11::basic_string<char> > raylib::GetDroppedFiles()': /usr/local/include/Functions.hpp:172:22: error: '::GetDroppedFiles' has not been declared; did you mean 'raylib::GetDroppedFiles'?   172 |     char** files = ::GetDroppedFiles(&count);       |                      ^~~~~~~~~~~~~~~       |                      raylib::GetDroppedFiles /usr/local/include/Functions.hpp:167:35: note: 'raylib::GetDroppedFiles' declared here   167 | RLCPPAPI std::vector<std::string> GetDroppedFiles() {       |                                   ^~~~~~~~~~~~~~~ /usr/local/include/Functions.hpp:174:7: error: '::ClearDroppedFiles' has not been declared; did you mean 'LoadDroppedFiles'?   174 |     ::ClearDroppedFiles();       |       ^~~~~~~~~~~~~~~~~       |       LoadDroppedFiles In file included from /usr/local/include/raylib-cpp.hpp:45,                  from core_basic_window.cpp:22: /usr/local/include/Matrix.hpp: In member function 'raylib::Matrix raylib::Matrix::Normalize() const': /usr/local/include/Matrix.hpp:94:18: error: '::MatrixNormalize' has not been declared    94 |         return ::MatrixNormalize(*this);       |                  ^~~~~~~~~~~~~~~ In file included from /usr/local/include/Mesh.hpp:10,                  from /usr/local/include/raylib-cpp.hpp:46,                  from core_basic_window.cpp:22: /usr/local/include/Model.hpp: In member function 'RayCollision raylib::Model::GetCollision(const Ray&) const': /usr/local/include/Model.hpp:113:18: error: '::GetRayCollisionModel' has not been declared; did you mean 'GetRayCollisionMesh'?   113 |         return ::GetRayCollisionModel(ray, *this);       |                  ^~~~~~~~~~~~~~~~~~~~       |                  GetRayCollisionMesh In file included from /usr/local/include/raylib-cpp.hpp:46,                  from core_basic_window.cpp:22: /usr/local/include/Mesh.hpp: In member function 'raylib::Mesh& raylib::Mesh::Binormals()': /usr/local/include/Mesh.hpp:261:11: error: '::GenMeshBinormals' has not been declared; did you mean 'GenMeshTorus'?   261 |         ::GenMeshBinormals(this);       |           ^~~~~~~~~~~~~~~~       |           GenMeshTorus In file included from /usr/local/include/Ray.hpp:6,                  from /usr/local/include/raylib-cpp.hpp:51,                  from core_basic_window.cpp:22: /usr/local/include/RayCollision.hpp: In constructor 'raylib::RayCollision::RayCollision(const Ray&, const Model&)': /usr/local/include/RayCollision.hpp:30:15: error: '::GetRayCollisionModel' has not been declared; did you mean 'GetRayCollisionMesh'?    30 |         set(::GetRayCollisionModel(ray, model));       |               ^~~~~~~~~~~~~~~~~~~~       |               GetRayCollisionMesh In file included from /usr/local/include/raylib-cpp.hpp:51,                  from core_basic_window.cpp:22: /usr/local/include/Ray.hpp: In member function 'raylib::RayCollision raylib::Ray::GetCollision(const Model&) const': /usr/local/include/Ray.hpp:72:16: error: 'GetRayCollisionModel' was not declared in this scope; did you mean 'GetRayCollisionMesh'?    72 |         return GetRayCollisionModel(*this, model);       |                ^~~~~~~~~~~~~~~~~~~~       |                GetRayCollisionMesh
I'm sure raylib is working because other C programs compiled fine when I only include raylib.h
I'm using the latest version of raylib-cpp, using raylib 4.0.0, and compiled with g++ core_basic_window.cpp -lraylib.  What did I do wrong here?

bruh
i screwed up some stuff. turned out i still have the raylib.h and raymath.h files from 4.2.0 instead of 4.0.0, while the libraylib.so is 4.0.0 :moyai:
raylib-cpp works fine after i read the contents of those 2 files in /usr/local/include/ and replaced them with the 4.0.0 version.
very embarrassed. hope no one notice this.

Hoping to update to raylib 4.2 soon. In the mean time, there's the next branch  :wink:  https://github.com/RobLoach/raylib-cpp/pull/188


SLING-4327-added support for custom root paths for resource resolver

https://issues.apache.org/jira/browse/SLING-4327
ovide ability to create a ResourceResolver which is aware of any mappings, for example by providing proper argument mappingPath. In case of AEM it would be possible to use publish instance mapping present under etc/publish.map to on author instance.
To achieve that the CommonResourceResolverFactoryImpl could be implementing methods getResourceResolver() and getAdministrativeResourceResolver() with additional argument defining the mapping location. The advantage of this solution is that the created ResourceResolver can be used many times with the same mappings. The drawback is that the mappings configuration will be found and cached when they resourceresolver will be used for the first time - there is no possibility to define the list of working mappings before.
The proposal of API extension:
ResourceResolver getResourceResolver(Map<String, Object> authenticationInfo, String customRootMap) throws LoginException;
ResourceResolver getAdministrativeResourceResolver(Map<String, Object> authenticationInfo, String customRootMap) throws LoginException;

With the upcoming migration to git this repository will be deleted. If the pull request contains data that should be re-submitted I suggest that you save the changes locally and resubmit them after the migration, which will likely happen on Monday the 9th of October.