An implementation of the Chinese SM3 hash algorithm

This PR introduces the Chinese SM3 hash algorithm, which produces a 256-bit digest.
This was ported from Ribose's contribution to Botan, and contains some minor changes to make its performance on par with Botan's SM3 implementation.
Currently openssl speed -evp sm3 reports:
~270 MB/s on @randombit 's machine
~250 MB/s on @ronaldtse 's macOS Macbook Pro 3.1 GHz
This is a contribution by Ribose Inc. and was done with knowledge of @richsalz, @levitte, @InfoHunter.
Questions:

Currently there is a doc/man3/SM3.pod, but the non-EVP interface is discouraged. Should it be moved to doc/man3/EVP_sm3.pod (and hence the breakup of the digests pod files)?
Most hash algorithms don't seem to have a test/recipe/ except HMAC. Do we need one?

cc: @randombit @dewyatt @erikbor
This is a contribution from Ribose Inc..
Checklist

[x] documentation is added or updated
[x] tests are added or updated

For the first question, I suspect the consensus will be that the low level calls SM3_Init, SM3_Update, SM3_Final and SM3 shouldn't be exposed.  This means no need for the SM3.pod file, the sm3.h should be internal and the functions renamed sm3_init, sm3_update and sm3_final and the SM3 function removed.
For the second question, there isn't a need for a standalone test for SM3.  The tests in evpdigest.txt should cover it properly (& look like they do).

I agree with @paulidale, making an EVP only interface has been the move for some time now.

Regarding lowercasing the function names, I'm not sure that's an absolute necessity.  We haven't been picky about that before (see SM4...  or Blake2, for that matter)...

I'm for lower casing them moving forwards.  Upper case lead ins to names are generally exported.
We possibly should rework the non-exported upper case lead in names to be lowercase.  I might get some time for this later in the week.
I've also a scheme to move to an EVP only interface -- this means replacing the historic direct calls with wrappers that use the EVP interface.  It also means renaming internal uses of these functions and (perhaps) the structures that are used.  I.e. somewhat invasive :(

Out of interest, are there going to be submissions for SM2 and SM9 as well?  The rest of the SM family are unpublished/untranslated as far as I'm aware.

I've also a scheme to move to an EVP only interface -- this means replacing the historic direct calls with wrappers that use the EVP interface. It also renaming internal uses of these functions and (perhaps) the structures that are used. I.e. somewhat invasive :(

I argued the exact same thing years ago, and personally encourage it.  You need to know, though, that some are concern with speed and how that will be affected by this move (that's the reason I never went ahead with this)

@paulidale @levitte restructured to internal EVP now, using lowercase function names.
Yes @paulidale we will be contributing SM2 as well, as @richsalz , @levitte and @InfoHunter already know. We haven't done SM9 but will see what happens!

Regarding lowercasing the function names, I'm not sure that's an absolute necessity. We haven't been picky about that before (see SM4... or Blake2, for that matter)...

It has lesser to do export-ability, but rather with how algorithm is referred to in general. With all capitals customarily denoting abbreviations.

I've also a scheme to move to an EVP only interface -- this means replacing the historic direct calls with wrappers that use the EVP interface.

I'd say that this effectively encourages application developers to not rewrite their code, and I'd view it as negative thing. Or in other words direct calls should be simply privatized in next major release without any "convenience" patches.  I for one would even take it step further and discourage application developers from using even things like EVP_sm3() (and by extension EVP_sha1()). Instead application should look it up by nid or symbolic name at run time and act accordingly. [Well, one might find it appropriate to compromise and say that those EVP_algo() that can't be disabled could be exported, but those which can be disabled shouldn't really.] This has everything to do with idea of "universal" headers. And just in case it wasn't clear, this is something that could be done only in next major release.

this is something that could be done only in next major release.

Do we have a wiki page or something where we are keeping track of major changes we want to make in the next major release?

Do we have a wiki page or something where we are keeping track of major changes we want to make in the next major release?

The closest thing we have AFAIK is the "1.2.0" label. There aren't any issues using that label, but there are a number of PRs that have that against them. We should probably create issues when we identifying this like this and assign the "1.2.0" label.

Were folks aware of http://gmssl.org/ ?
Some assembly versions are provided for i64.

Yeah, I took a look at it.  Based on some advice I got during our recent China trip, it didn't get more than a cursory look.

@levitte I've removed all references of SM3 from EVP_DigestInit.pod for doc-nits to stop complaining.

Also, I'm curious, how is GM/T 0004-2012 related to this?

The SM3 hash algorithm has been specified in multiple documents of differing importance.
The first public document of SM3 was published by OSCCA (State Cryptography Office) as a "Cryptographic Standard" GM/T 0004-2012. It was "upgraded" to a "China National Standard" by the SAC and TC 260 (China Standards Body) in GB/T 32905-2016 with some minor changes (to documentation, not to the algorithm).

Ok.  It's curious in my view, but then I'm used to only refering to the last RFC we conform to, and that RFC having back references to older RFCs on the same matter.  Either way, I'm not asking you to change your references, only to satisfy my curiousity...  which you have now done, thank you :-)

It would be sad if no one was curious on something I found interesting, so thank you 😉

If there is an english version of GB/T 32905-2016, I'd love to read it.  All I've been able to find is old IETF drafts, and I'd like to understand a bit better what corresponds to what

@levitte Is there anything further we can do to move this ahead? Thanks!

Something's going on with Travis.  May I suggest the following patch, temporarly?
diff --git a/.travis.yml b/.travis.yml
index d61fd9cefb..807601d284 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -168,7 +168,7 @@ script:
       else
           echo -e '+\057 MAKE UPDATE FAILED'; false;
       fi;
-      git diff --quiet
+      git diff --name-only
     - if [ -n "$CHECKDOCS" ]; then
           if $make doc-nits; then
               echo -e '+\057\057 MAKE DOC-NITS OK';

Will get the nits ironed out soon!

@levitte @paulidale the nits have been addressed. Please feel free to let me know if there’s anything further to be done. Thanks!

@levitte do you want to squash into one commit? I'm happy do so.

@levitte squashed to 2 commits now and rebased to latest master. Good to merge?

Looks good enough for me.

Need a rebase to master before merging.

@paulidale all done!

Merged, thanks.

Thank you @paulidale @levitte @mattcaswell @dot-asm and @richsalz !

Something the reviewers missed which I've added for SM3 and SM4 in #4678 but should go in for SM2 when you make that PR.
Things that can be disabled should be added to the openssl list -disabled command.

Indeed we will keep this in mind. Thanks!


git describe showing old version?

Hello,
according to tutorials I found on the net, it should be possible to obtain the version of a git branch using the following command:
git clone https://github.com/atom-community/atom.git
cd atom
git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'

However, this command does not show the current version (1.63-dev if I am not mistaken) but something older:
$ git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
v1.6.0.beta0.r11309.g05d408fdf
$ git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
1.35.0.r2688.g05d408fdf

Please let me kindly ask you for advice.

We haven't been pushing the tags from upstream to this repo lately.
Also, we have hundreds of commits which aren't technically in upstream. (Even if some of the work has actually been merged over at upstream, it was usually on separate, rebased branches. So git would see them as totally unique commits.) Not sure if that complicates use of git describe.
The fork hasn't really been tagging releases, so much as working with upstream until now, and putting changes in master branch. That could change, given upstream is not receiving any input or action from maintainers as far as I can tell, and will be fully archived in December.

Thanks a lot.
Meanwhile, I use the following code for obtaining atom version:
  atom_version=$(node -e 'console.log(require("./package").version)')
  # To strip ".dev" from the package version, comment out the line above, and uncomment the line below.
  # atom_version=$(node -e 'console.log(require("./package").version)' | grep -o '[0-9.]*')
  atom_version_base_commit=$(git log --oneline | grep $atom_version | grep -o "[0-f]* ")
  # If the command on the line above doesn't find a "base" commit on `master` branch for the current Atom version,
  # then the latest commit on `master` branch will be tagged instead, and revisions (".r") in the package version will be "0".
  git tag -f $atom_version $atom_version_base_commit
  # Remove 'v' prefix on tags; prefix revision with 'r'; replace all '-' with '.'
  git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'

@DeeDeeG YOU HAVE SPOKEN WELL
CAN WE INTRODUCE @Sadick235 and @daranga from the last repo so they are aware this is the backup repo incase microsoft archives atom/atom


fix(nextjs,shared,astro): Vendor path-to-regexp

Description

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

!snapshot

Hey @anagstef - the snapshot version command generated the following package versions:

Package
Version

@clerk/astro
1.3.2-snapshot.v8d68ce7

@clerk/backend
1.11.1-snapshot.v8d68ce7

@clerk/chrome-extension
1.3.4-snapshot.v8d68ce7

@clerk/clerk-js
5.21.2-snapshot.v8d68ce7

@clerk/elements
0.15.2-snapshot.v8d68ce7

@clerk/clerk-expo
2.2.10-snapshot.v8d68ce7

@clerk/express
0.0.39-snapshot.v8d68ce7

@clerk/fastify
1.0.41-snapshot.v8d68ce7

@clerk/nextjs
5.5.2-snapshot.v8d68ce7

@clerk/clerk-react
5.8.2-snapshot.v8d68ce7

@clerk/remix
4.2.25-snapshot.v8d68ce7

@clerk/clerk-sdk-node
5.0.38-snapshot.v8d68ce7

@clerk/shared
2.7.2-snapshot.v8d68ce7

@clerk/tanstack-start
0.4.1-snapshot.v8d68ce7

@clerk/testing
1.2.21-snapshot.v8d68ce7

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i<EMAIL_ADDRESS>--save-exact

@clerk/backend
npm i<EMAIL_ADDRESS>--save-exact

@clerk/chrome-extension
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-js
npm i<EMAIL_ADDRESS>--save-exact

@clerk/elements
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-expo
npm i<EMAIL_ADDRESS>--save-exact

@clerk/express
npm i<EMAIL_ADDRESS>--save-exact

@clerk/fastify
npm i<EMAIL_ADDRESS>--save-exact

@clerk/nextjs
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-react
npm i<EMAIL_ADDRESS>--save-exact

@clerk/remix
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-sdk-node
npm i<EMAIL_ADDRESS>--save-exact

@clerk/shared
npm i<EMAIL_ADDRESS>--save-exact

@clerk/tanstack-start
npm i<EMAIL_ADDRESS>--save-exact

@clerk/testing
npm i<EMAIL_ADDRESS>--save-exact


Freeze GMaps script version

A recent deploy of a new GMaps experimental version provokes errors, both in our specs and in our API examples.
This PR freezes the GMaps version to the currently stable one, v=3.30.

I think we should check the upper-limit version in CARTO.js. (>=3, <3.30)


Bug Report: Game crashes when notes play on debug mode

no idea what's happening, probally because of non updated code, but why is the game doing that??

probably because of non updated code

try again with latest kade engine (use a CI/development build), reopen if still happening

ty


Prototype kernel implementation, including change and changeset types.

I think the change type specific model is semantically the best way to go, with no ambiguity.
What does a change set iteration look like?  Will it use switch expressions to extract the types?

Yeah, pretty much.


Implement SI/TI update

To clarify:

[x] Is l_min, l_max for display model in SDR the same as l_w, l_b for EOTF-HLG? If so, we can re-use the same command-line parameter. The only issue is that this would have different default values depending on the mode of input. --> Yes, harmonize
[x] Is the "gamma" type EOTF function just a special case of BT.1886 with a different default gamma (compared to 2.4)? --> Yes, harmonize

To do:

[x] Implement the actual conversion functions

Closed for now until actual merge/release.


Refactor planet XML load

Reference: #830
Refactor Planet XML loading code so for loops only iterate over XmlElement objects, and to make use of Dictionary.

Looks much cleaner than how I originally wrote it. I like how the concept of pulling string data from either a element or an attribute is now possible which made reading the description string trivial in code.

Technically it uses custom code for Planet data loading, so it only supports sub-elements here, and not attributes. Took me a moment to remember this code was different. I originally tried to write the code assuming it was using attributes, which didn't exactly work. Thankfully it was a fairly small change to fix it from there.


bounding box app throws server error when set up in conda environment

App name
dash-image-annotation
Description of bug
When started from a fresh conda environment with dependencies installed as per the Readme, dash-image-annotation throws several errors in the browser console (see gist) and does not load correctly:

there is also a (maybe unrelated) error thrown in the python log:
[2020-10-02 08:30:36,350] ERROR in app: Exception on /_dash-update-component [POST]
Traceback (most recent call last):
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/dash/dash.py", line 1059, in dispatch
    response.set_data(func(*args, outputs_list=outputs_list))
  File "/home/surchs/conda/envs/bbox/lib/python3.8/site-packages/dash/dash.py", line 994, in add_context
    output_value = func(*args, **kwargs)  # %% callback invoked %%
  File "app.py", line 313, in modify_table_entries
    if "shapes" in graph_relayoutData.keys():
AttributeError: 'NoneType' object has no attribute 'keys'

When started from a fresh virtual environment (and installing dependencies from requirements.txt), the app starts correctly without errors (browser or python):

Installing the dependencies through conda with conda install --file requirements.txt also results in a larger number of installed dependencies than when doing the same with pip (pip install -r requirements.txt:
➜ conda list | wc
     95     288    5650

vs
➜ pip freeze | wc
     34      34     579

I have also dumped the installed modules in the gist.
How to replicate the bug

create fresh conda environment e.g. conda create -n test -y && conda activate test
install dependencies conda install --file requirements.txt -y
start dash-image-annotation python app.py

Other notes
I have taken a quick look at some other dash example apps and found that they appear to work when set up in a conda environment

Thanks for reporting this issue @surchs. I believe the error message in the Python log is a minor callback bug unrelated to the display problem. I could solve the display problem by

unpinning the numpy version, since 0.18.3 does not seem to be exist for conda (I ended up unpinning everything but only numpy was a problem)
and using the conda-forge channel since I believe this is the recommended channel for installing dash-related packages via conda, conda install -c conda-forge -y --file requirements.txt, and probably using the main conda channels there were some package incompatibilities (??).

@surchs could you please check that these two steps solve the issue?
@nicolaskruchten should we give more instructions to conda users in dash-sample-apps, and make sure the requirements.txt works for conda as well ? A lot of people using windows or mac use conda instead of pip/venv.

@emmanuelle I can confirm that unpinning the numpy version to >= 0.18.3 and installing with conda-forge fixes the issue

@surchs ok cool. FYI the way I investigated was to google "dash conda" and then I found on https://anaconda.org/conda-forge/dash that conda-forge was the recommended channel, I think I had known this at some point but I had forgotten :-).

ah cool, thanks for that! I'll keep tracking conda-forge then for testing things.


Windows antivirus prevents opening the program

Installed version 0.3.0 and windows defender flagged the .exe as a potential trojan or unwanted software and would not allow me to open the program, even chrome doesn't allow you to install it as it flagged it as a dangerous program.
downloaded it from the latest release on github not some shady site.  windows goes as far as to delete the program even though I allowed it to remain on my pc, I saw the comment about guitar support. Is there a chance to crate a separate version that doesn't have that as I personally don't care about guitar support so that windows stops falsely flagging the program.
https://imgur.com/a/Ld6X7Pe

I didn't close this back then, but 0.4.0 seems to not have this issue anymore, and there will be new versions coming up soon


[FR] please add domc and stage0 min v. to cdnjs.com or write sizes in doc

Speed is great, but another important factor in choosing JS framework is it's size. I could not find any info on that. So literally have to try :( .. and with all minimization, uglyfuing etc, its not such a small thing todo for every guy why's interested in this tech.

Yeah, it looks like having overweight.
minified-size showing 2.33Kb for index.js and 1.08Kb for vFor.js that can be considered as average setup.
Same size as preact and 2x hyperapp.
Size was not the main point during development though.

@Freak613 thanks, could u do same for stage0?

Sure.
I'll try to think about size.

@Freak613 thanks. Feel free close this issue when appropriate.


[WIP] initial bringup for casting

This has been put on hold as there are some features not working as i expect it to work.


Change application ID for RxJava template

What happened 🤔
Since we have a specific package name & application ID for the CouritineTemplate, we should change it accordingly for the RxJavaTemplate as well
PoW (a.k.a Proof Of Work)💪
App is still buildable 🙏

Updated 🚀
But please review #63 first 🙏

@Tuubz Could you please add the Card's link to the description? 🙏

@Tuubz Could you please add the Card's link to the description? 🙏

Done 🚀

@Tuubz Could you please add the Card's link to the description? 🙏

Done, I created a new card for this 🚀

@Tuubz Still don't see the card's link in the PR's description 🤔

My bad, forgot to update the link in this PR as well 🙏
Done ✅


Fix missing quote

In the file kgq_embeddings.py, in the case of vector store = bigquery-vector there is a line which states:
client.query_and_wait(f'''DROP TABLE IF EXISTS `{project_id}.{schema}.example_prompt_sql_embeddings''')
It's missing a quote at the end of the query which leads to unclosed literal errors.
The proposed modification is to change it to:
client.query_and_wait(f'''DROP TABLE IF EXISTS {project_id}.{schema}.example_prompt_sql_embeddings''')

Moved to a dedicated repository - https://github.com/GoogleCloudPlatform/Open_Data_QnA


Use contentful 5.0.0

I cannot use this with the newest contentful 5.0.0. Can you please update this?

This is only working for Carthage but not voor CocoaPods users, could you also update the podspec?


feat(goal_planner):  dense goal candidate sampling in BusStopArea

Description
depends https://github.com/autowarefoundation/autoware.universe/pull/8794
launcher PR: https://github.com/autowarefoundation/autoware_launch/pull/1156
Related links

CompanyName internal link

How was this PR tested?
use_bus_stop_area = false

use_bus_stop_area = true

Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@kosuke55 Can you approve this ?


Allow multiple spaces for vertex position/color definitions.

(https://forum.babylonjs.com/t/invisible-imported-obj-file-with-mtl/1523/9)
This is a fix for a bug introduced in 4.0.  No docs or what's new update needed.

Thanks a lot


anestoruk - one more improvement

Check List:

[x] You have run ./mvnw verify and the project builds successfully
[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (136-142)

Execution time (6-core i5 @ 3.70GHz): Range (min … max):    6.970 s …  8.332 s    10 runs

Execution time (4-core i5 @ 2.40GHz): 9-11s

Execution time of reference implementation: ~3m 4s

Hello, one more improvement from me: city array byte buffer is copied only when new Record instance is created.
(there is also a second improvement - splitting the memory into a more even chunks - but this change will have no effect on a test that is run against 8-core machine)

00:08.896 now.


fine-tuning my data show no depth info on road

the first image is test on your pretrained model.
the second is fine tuned trained on my 6000 images for about 30 epochs, the road shows this behavior just few epochs of trainings.
any idea why road have no depth information? Thank you!

This issue might be due to the lack of scale normalization during training, and has been pointed out in a recent paper: https://arxiv.org/abs/1712.00175.


packages: merge @docusaurus/preset-classic with @protosaurus/docusaurus-theme

Prerequisite: https://github.com/imballinst/protosaurus/pull/25.
This PR merges @docusaurus/preset-classic with @protosaurus/docusaurus-theme. The process is relatively straightforward: we remove classic from docusaurus.config.js (and replace it with @protosaurus/docusaurus-preset).
Signed-off-by: Try Ajitiono<EMAIL_ADDRESS>

Thanks @dio for the review! I'll merge this tomorrow.


CODE_SIGN_ENTITLEMENTS missing Xcode 8

Hi,
with the newest OSX and iOS I need to manually enable APNS in Xcode. I think there were some breaking changes and this plugin needs to be adjusted.
I'm using latest cordova, platform and phonegap-plugin-push versions.
Xcode looks like this after platform add:

And if I switch it to ON, Xcode adds some lines to this file:
project.pbxproj:
SystemCapabilities = {
							com.apple.Push = {
								enabled = 1;
							};
						};

[...]

CODE_SIGN_ENTITLEMENTS = myApp/myApp.entitlements;

After switching to ON the plugin works as expected.

Duplicate of https://github.com/phonegap/phonegap-plugin-push/issues/1154


HUTER project - HCA DCP meeting actions

Description of the task:

Review HUTER spreadsheet example and clinical information shared with us to map variables to our current standard and identify any gaps.

Review HUTER anatomy/phyisological info and map to the ontologies we use. Provide a general summary of the ontologies we use to HUTER so they can build that info into their own platform.

Add new paper Wang W, Vilella F, Alama P, et al. Single-cell transcriptomic atlas of the human endometrium during the menstrual cycle. Nature Medicine. 2020 Sep. DOI: 10.1038/s41591-020-1040-z.
PMID:32929266

Share the Fetal/Maternal Interface metadata spreadsheet with the HUTER team.

Share a template spreadsheet with the HUTER team and contact them about testing our new services to get feedback

Meeting notes, slides and other material: https://drive.google.com/drive/u/0/folders/1oHy4Fl5GBNua2Zr3FZi817tx2bFrzgtu
Acceptance criteria for the task:

* [ ] HUTER spreadsheet example and clinical information have been reviewed and the variables have been mapped to our current standard. If there were any gaps, then they would have been identified.
* [ ] The HUTER project anatomy/phyisological info have been mapped to the ontologies we use.
* [ ] The HUTER team has been provided a general summary of the ontologies we expect them to use so they can build that info into their own platform.

[x] The HUTER project paper Wang W, Vilella F, Alama P, et al. Single-cell transcriptomic atlas of the human endometrium during the menstrual cycle. Nature Medicine. 2020 Sep. DOI: 10.1038/s41591-020-1040-z. PMID:32929266 has been added to the dataset tracking sheet.

[x] The Fetal/Maternal Interface metadata spreadsheet has been sent to the HUTER team.

[x] An HCA DCP template spreadsheet has been generated and shared with the HUTER team.

[x] If possible, the new HCA DCP service is use for generating the spreadsheet.
[x] Feed back is collected after testing the service.

[x] Need to work out if/how contributors can submit bioinformatics pipeline-related metadata

Thanks @rays22 did the example paper of theirs look like something we could prioritize or not?

Thanks @rays22 did the example paper of theirs look like something we could prioritize or not?

It looks like a high priority paper/dataset to me (primary human tissue, healthy donors, 10x technology).

@rays22 how are you getting on with this ticket? What support do you need to complete it?
@gabsie when is the UX interview scheduled for?

Hello - I have an interview with Beatriz only today - to go through the registration and the spreadsheet creation. I have directed them for all their usual questions to continue talking to the data wrangler team.

@aaclan-ebi , @clairerye
A meeting has been scheduled for
5 November, Thursday 13:00-13:30 BST /14:00-14:30 CEST
to find out more about the requirements of the HUTER project in order to support data flow from HUTER to HCA DCP. The meeting is also to follow up on their technical questions.

Question 1:

We are planning to organize our data structure with directories and subdirectories in HUTER platform so are you going to support this folder structure in the near future? Otherwise should we rename each file to upload the data to HCA-DCP in order to avoid file name collision?

Question 2:

In HUTER platform we are going to keep metadata in JSON format, but not under HCA-DCP schemas (researchers will also include specific metadata variables that are not going to be uploaded to HCA-DCP). Thus, we would like to explore a way to send you the metadata in the most suitable format for you. Could you tell us how it would be the best metadata format for you? Do you prefer a spreadsheet form or JSON files?

@rays22 how are you getting on with this ticket? What support do you need to complete it?

I need developer support to follow up on technical questions from HUTER. I think I have that support. Other than that, I would need allocated time to complete the remaining tasks.

So I don't think this is super urgent as they don't have a dataset they are ready to submit. Do you want to put it back into the product backlog and we can bring it back next time you are on operations?

2020-11-19 HCA-DCP & HUTER meeting minutes

Raw data file uploads (for example fastq sequence files, cell-gene expression matrices, cell-type annotations and possibly image files).
We have discussed the possibility of sub-directories for data files, because the hca-util tool does not support sub-directory structures for data uploads.
Action: Cristóbal to send a slide or diagram of their planned directory tree/structure, so that the HCA DCP developers can assess the feasibility of supporting it or alternative solutions.

Metadata format for HCA DCP.
We have discussed the feasibility of direct JSON submissions to the HCA DCP, but we have come to the conclusion that the HCA DCP Excel metadata spreadsheet would be the preferred format for the HCA DCP in the first instance. We are going to pilot the spreadsheet format submissions, and we can re-visit the format options if that format proves to be problematic for any reason.

Units of data flow/submissions from the HUTER project.
In addition to the above two discussion points, we have also discussed if the HUTER project data would be submitted in one go or in subsets. I think the multi-submission model for the data flow was the consensus, but we might need further discussions on that.

It looks like this meeting went well.
@rays22 What do you think needs to be done to close off this ticket? Are there further actions for which the ticket is useful to keep on top of?

It looks like this meeting went well.
@rays22 What do you think needs to be done to close off this ticket? Are there further actions for which the ticket is useful to keep on top of?

I have added the remaining action items from this ticket to https://github.com/ebi-ait/hca-ebi-wrangler-central/issues/139 so we can close it.
We can make new tickets for any emerging issues that may come up to support the HUTER project. I am closing this issue.

Thanks for clarifying
I reopened it and put it in the done column as that will make it easier to track how much we completed this sprint


Error handling for the queue manager module doesn't work if multiple queue managers are supplied

When supplying a queue manager name for the the module, you can supply multiple using a list
e.g.
['qmgr1', 'qmgr2']
The problem currently is that while the queue manager module can handle this, the logging of return codes and output messages cannot. Currently if multiple queue managers are supplied then each one will overwrite the other's message and return code.
For instance, using ['qmgr1', 'qmgr2']
the initial return code and message will relate to qmgr1 however as soon as qmgr2 has operations performed using it, the return code and message will overwrite the one created for qmgr1.
Finding a way to potentially use lists potentially to store the results might be a possible solution

Is this to be handled by #104 ?

Hadn't realised we already had an issue concerning this, I'll close #104 as a duplicate of this and use this issue going forward


Please add more examples for the ssl case

Hi everybody.
Recently I was working to deploy automatically a few sites, when I was reading the examples is only one example and it works pretty well, but we can add more examples for website that are running under https protocol.
Thank you very much,
Sincerely,
H

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95401782-16b2-2fa5-7146-7051c0ac5163
Version Independent ID: 1f7fd84b-0c0c-5954-8666-18c3dec674e4
Content: New-WebBinding (webadminstration)
Content Source: docset/winserver2012-ps/webadminstration/New-WebBinding.md
Product: w10
Technology: powershell
GitHub Login: @andreabarr
Microsoft Alias: v-anbarr

hey @e0i  how are you 😃 , hope you're doing well. I was wondering if you need anything,  I'm still looking for more powershell examples but I wasn't lucky with this one

@h3ct0rjs The issue has been in the backlog and is going to be addressed soon. Thank you.

Hi @tiburd,
Nice work, I was wondering if currently there is an option to specify the ssl certificate or how should I address this part.
Best Regards,
H


this.observations_.forEach is not a function

I got this Javascript error: this.observations_.forEach is not a function
Browser: Firefox 19 on Ubuntu (Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0)
File / line: /ajax/libs/simplebar/2.5.1/simplebar.min.js 1 : 28897
Trace:
O.prototype.gatherActive@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
v.prototype.updateObservers_/t<@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
v.prototype.updateObservers_@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
v.prototype.refresh@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
n@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
l</<@/ajax/libs/simplebar/2.5.1/simplebar.min.js:1
b@https://cdn.trackjs.com/releases/current/tracker.js:5

Can this be fixed?

I don't think so. We are now at Firefox 58 and Firefox 19 has been released in 2013. So unfortunately I won't change any code to support this, it will be your responsibility to handle any potential polyfill for that.
As a hint, this seems to be the forEach function that is probably not supported by Firefox 19, so if you add a polyfill for this function, it may work.

Thanks for checking!
(Note: it seems forEach, as part of ECMAScript 5, should be supported by older Firefox versions https://caniuse.com/#search=forEach)


Update README.md

Describe the big picture - why are we doing this?
Updating LightFM docs in README to verify the library includes support for side data
Any additional details to clarify code in the PR?
Do I need to update the Changelog or version files since this update only affects the readme?
How is this tested?
Pull Request Checklist

[x] Pull request includes a description of why we are doing this
[x] CHANGELOG has been updated
[x] Version in _version.py has been updated
[x] All tests in the tests folder pass with a local build
[x] README has been updated (if applicable)
[x] Documentation in docs has been updated (if applicable)
[x] requirements.txt and requirements-dev.txt have been recompiled (if applicable)
[x] Docker image can be built using docker build -t collie .

Screenshots or GIFs?

@nathancooperjones are you able to review?


Ease pre-pull request fork CI as well as github-actions based dispatch

Description
We allow GitHub actions pull requests to dispatch the other workflows when version updates are in order.
We also simplify the other conditions to be simply "on push".

[x] I have performed a self-review of my changes
[x] I have read and understood the contributing guidelines

@starbelly, don't really understand why CI isn't running. It's either basing itself on the new conditions (which are "all push", so should work) or the previous conditions (which included "pull request to main", so should work). I believe you can "trust it", and approve+merge. We can later see if it runs in master or not, and try to bugfix it, if not.

@paulo-ferraz-oliveira I've experienced this before :( Nothing to do with this action AFAIK. What you can do is push an empty commit to give it a jiggle as FYI.

There it goes, queue in master

❤


IPykernel in Poetry not recognised

Prerequisites

[x] Have you checked the solutions in our troubleshooting guide for common problems ?
[x] Have you checked that your issue isn't already filed ?

Description
For some reason Hydrogen does not pick up Jupyter kernels in a virtualenv that was created using Poetry.
Steps to Reproduce
Create a pyproject.toml file
[tool.poetry]
name = "testbla"
version = "0.1.0"
description = ""
authors = ["Nobody<EMAIL_ADDRESS>
[tool.poetry.dependencies]
python = "^3.7"
jupyter = "^1.0.0"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

install it
poetry install

And run Atom
poetry run atom .

or
poetry shell
atom .

Run a Python cell. A No Kernels installed message appears.
For comparison, virtualenv works:
virtualenv test; cd test
pip install jupyter
atom .

Versions

OS version:
macOS 10.15.2 Catalina using Homebrew's Python

atom --version

Atom    : 1.42.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

apm --version

apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.42.0
python 3.7.6
git 2.24.1

Hydrogen version: 2.13.1

Plugins
Have you installed and activated any of the Hydrogen plugins below ?

[ ] hydrogen-python
[ ] Hydrogen Launcher
[ ] Data Explorer

Logs
There is no log output in the Dev Console.
Expected behavior
Hydrogen should recognise Jupyter kernels in both plain virtualenvs and Poetry virtualenvs.

Seems like even though you are in the activated environment it is not able to find where the kernel was installed. I can look into this soon and see whats going on thank you for the detailed report steps 😄

Yes, the weird thing is that
jupyter
jupyter notebook
poetry run jupyter kernelspec list

et al worked just fine in both virtualenvs...

I found out that the issue was because I was using Poetry from Homebrew.
That version of Poetry does something messy with PYTHONPATH that creates half-complete virtualenvs and apparently also breaks Hydrogen.
Installing Poetry as recommended fixes this problem.


"Scheduling failed: No candidates available" error

i got this error when i wanna update or finish update some instances, do you have any ideas ?

Useful
Info

Versions
Rancher v1.0.0 Cattle: v0.159.2 UI: v0.100.3

Access
github admin

Route
service.containers

Does your service have a scheduling rule associated to it?

Closing as stale.


[PROBLEM] 1269. Number of Ways to Stay in the Same Place After Some Steps

Difficulty
Hard
Problem Description

You have a pointer at index 0 in an array of size arrLen. At each step, you can move 1 position to the left, 1 position to the right in the array, or stay in the same place (The pointer should not be placed outside the array at any time).
Given two integers steps and arrLen, return the number of ways such that your pointer is still at index 0 after exactly steps steps. Since the answer may be too large, return it modulo 109 + 7.
Example 1:
Input: steps = 3, arrLen = 2
Output: 4
Explanation: There are 4 differents ways to stay at index 0 after 3 steps.
Right, Left, Stay
Stay, Right, Left
Right, Stay, Left
Stay, Stay, Stay

Example 2:
Input: steps = 2, arrLen = 4
Output: 2
Explanation: There are 2 differents ways to stay at index 0 after 2 steps
Right, Left
Stay, Stay

Example 3:
Input: steps = 4, arrLen = 2
Output: 8

Constraints:

1 <= steps <= 500
1 <= arrLen <= 106

Link
https://leetcode.com/problems/number-of-ways-to-stay-in-the-same-place-after-some-steps/

could you please assign me this issue.

Python solution :raised_hand:


Buck doesn't build: Execution failed for task ':buildDepCache'.

Getting this error when i try to build with buck:
[13:38:08 tommy@tumblr-MacBookPro-f0658b:~/src/android/AndroidTDDBootStrap] (master)
→$./buckw --stacktrace targets
 NO PREVIOUS SUCCESSFUL OKBUCK RUN
 RUNNING OKBUCK...

 DELETED OLD BUCK FILES
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; support was removed in 8.0
Parallel execution with configuration on demand is an incubating feature.
The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
        at build_7cxr0118m5vyru20czgisz1ts.run(/Users/tommy/src/android/AndroidTDDBootStrap/app/build.gradle:29)
The TaskInputs.source(Object) method has been deprecated and is scheduled to be removed in Gradle 4.0. Please use TaskInputs.file(Object).skipWhenEmpty() instead.
extractDebugAnnotations is incompatible with java 8 sources and has been disabled.
extractReleaseAnnotations is incompatible with java 8 sources and has been disabled.
extractDebugAnnotations is incompatible with java 8 sources and has been disabled.
extractReleaseAnnotations is incompatible with java 8 sources and has been disabled.
extractDebugAnnotations is incompatible with java 8 sources and has been disabled.
extractReleaseAnnotations is incompatible with java 8 sources and has been disabled.
Jack is disabled, but one of the plugins you are using supports Java 8 language features.
Jack is disabled, but one of the plugins you are using supports Java 8 language features.
Jack is disabled, but one of the plugins you are using supports Java 8 language features.
Jack is disabled, but one of the plugins you are using supports Java 8 language features.
:buildDepCache
:model:generateDebugSqlDelightInterface UP-TO-DATE
:model:generateReleaseSqlDelightInterface UP-TO-DATE
:buildDepCache FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':buildDepCache'.
> /Users/tommy/src/android/AndroidTDDBootStrap/model/build/intermediates/unmocked-androidmodel.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 16.239 secs
== CSV Build Time Summary ==
Build time today: 0:43.394
Total build time: 0:43.394
(measured since 13 minutes ago)
== Build Time Summary ==
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 95% :buildDepCache (0:00.337)

== BUILD FAILED ==

 OKBUCK FAILED

There is a work-around: just touch the file in the error message, i.e. /Users/tommy/src/android/AndroidTDDBootStrap/model/build/intermediates/unmocked-androidmodel.jar.

Thanks, the workaround lets me build.

I've update a commit, could you please try it?

yes this bug is fixed now.


"error" event handlers require the error to be handled twice

What version of standard?
12.0.1
What operating system, Node.js, and npm version?
linux, node 8.4.0 (my min version), npm 6.9.0
What did you expect to happen?
when using an event bases error handler:
this.port.on('error', err => {
  node.warn('an error occurred')
})

i get Expected error to be handled
but when i use
this.port.on('error', err => {
  if (err) {
    node.warn('an error occurred')
  }
})

everything is fine.
this seems superfluous to me. The error handler is only called if there is an error, so err is always an error object.
I think you should not be required to check for the error object in  this case.

Hi @Holger-Will. If you name the variable err then you should use it. You don't need to include it in an if block, you can do this:
this.port.on('error', err => {
  node.warn('an error occurred ' + err.message)
})

If you don't want to use the error, then don't include an err argument. Do this:
this.port.on('error', () => {
  node.warn('an error occurred')
})


Regex Validator doesn't account for filescope namespaces

Regex Validator for C# Scripts considers "namespace name;" (filescoped namespaces from C# 10) to be invalid syntax. Add version checks?

Double-check this. Might be handle namespaces fine.

Double-Checked. Caught a Parser-Error.


README files still applicable?

Is the README file of the repo still of value?
There is also a README.dev in the etc folder, with instructions to install a dev broker, but the link is broken

Is this fixed by #36?

[ ] etc/README.dev refers to internal MS stuff
[ ] need a document which describes how patches get accepted and the reason for each branch. e.g. never merge to upstream since that is reserved for the upstream authors.
[ ] Changes in #36 need to go to the correct place

README inconsistencies fixed by removing all the contents and adding a link to the Quettor website.

Doc on how to contribute is: http://www.quattor.org/aquilon/00-install.html#contributing


SUSE images in azure cli do not have a "default" image.

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
According to the azcli's "az vm create --help" output, each
distribution (publisher) should have some kind of "default" image.
BEGIN EXAMPLE
user@hostname:~> az vm create --help |grep Ubuntu
Create a default Ubuntu VM with automatic SSH authentication.
az vm create -n MyVm -g MyResourceGroup --image UbuntuLTS
[...]
END EXAMPLE
In checking the "Canonical" images, and more specifically, where this
"UbuntuLTS" comes from, the label in the cli help example is the "urnAlias".
Based on the --help output, one should be able to use this "urnAlias" by
itself to spin up a new "default" image.
BEGIN EXAMPLE
user@hostname:~> az vm image list -p Canonical
You are viewing an offline list of images, use --all to retrieve an up-to-date list
[
{
"offer": "UbuntuServer",
"publisher": "Canonical",
"sku": "18.04-LTS",
"urn": "Canonical:UbuntuServer:18.04-LTS:latest",
"urnAlias": "UbuntuLTS",
"version": "latest"
}
]
END EXAMPLE
One can specify the full default image "urn" as well as short "urnAlias" for
the "--image" flag when setting up a system with 'az vm create'.
BEGIN EXAMPLE
user@hostname:~> az vm create --image UbuntuLTS --name ubuntu-test --ssh-key-value ~/.ssh/id_rsa.pub
{
"fqdns": "",
"id": "/subscriptions/01234567-89ab-cdef-0123-456789abcdef/resourceGroups/test-resource-group/providers/Microsoft.Compute/virtualMachines/ubuntu-test",
"location": "westus2",
"macAddress": "01-23-45-67-89-AB",
"powerState": "VM running",
"privateIpAddress": "<IP_ADDRESS>",
"publicIpAddress": "x.x.x.x",
"resourceGroup": "test-resource-group",
"zones": ""
}
END EXAMPLE
This same syntax works perfectly fine for RedHat as well.
BEGIN EXAMPLE
user@hostname:~> az vm image list -p RedHat
You are viewing an offline list of images, use --all to retrieve an up-to-date list
[
{
"offer": "RHEL",
"publisher": "RedHat",
"sku": "7-LVM",
"urn": "RedHat:RHEL:7-LVM:latest",
"urnAlias": "RHEL",
"version": "latest"
}
]
user@hostname:~> az vm create --image RHEL --name rhel-test --ssh-key-value ~/.ssh/id_rsa.pub
{
"fqdns": "",
"id": "/subscriptions/01234567-89ab-cdef-0123-456789abcdef/resourceGroups/test-resource-group/providers/Microsoft.Compute/virtualMachines/rhel-test",
"location": "westus2",
"macAddress": "01-23-45-67-89-AB",
"powerState": "VM running",
"privateIpAddress": "<IP_ADDRESS>",
"publicIpAddress": "x.x.x.x",
"resourceGroup": "test-resource-group",
"zones": ""
}
END EXAMPLE
To Reproduce
This same syntax does not work for SUSE or openSUSE images when using either the urnAlias or urn in the "default" offering.
BEGIN EXAMPLE
user@hostname:~> az vm image list -p SUSE
You are viewing an offline list of images, use --all to retrieve an up-to-date list
[
{
"offer": "openSUSE-Leap",
"publisher": "SUSE",
"sku": "42.3",
"urn": "SUSE:openSUSE-Leap:42.3:latest",
"urnAlias": "openSUSE-Leap",
"version": "latest"
},
{
"offer": "SLES",
"publisher": "SUSE",
"sku": "15",
"urn": "SUSE:SLES:15:latest",
"urnAlias": "SLES",
"version": "latest"
}
]
user@hostname:~> az vm create --image SLES --name sles-test --ssh-key-value ~/.ssh/id_rsa.pub
(InvalidTemplateDeployment) The template deployment 'vm_deploy_FU6AQDNtc5eDrQeWpXdtJ4Y7apQBLTr5' is not valid according to the validation procedure. The tracking id is '9bd1f1c8-a2dc-4519-8fce-70c9db48b25d'. See inner errors for details.
user@hostname:~> az vm create --image openSUSE-Leap --name leap-test --ssh-key-value ~/.ssh/id_rsa.pub
(InvalidTemplateDeployment) The template deployment 'vm_deploy_RykhV8NAfwiZE4s8VjL3JzW1KWP4RP2D' is not valid according to the validation procedure. The tracking id is '8a7f6d12-5c1d-404b-8818-658a4de5e6c2'. See inner errors for details.
END EXAMPLE
Expected behavior
This syntax, by convention, should spin up a new Azure image of a default version of SLES and openSUSE.
Environment summary
azure-cli package must be installed and it must be configured with a valid Azure subscription.
Additional context
Ideally, the default image should point to a generic SLES (Non-SAP) PAYG image for "SLES" and the latest PAYG Leap image for "openSUSE-Leap"  here.  If a user needs a more specific product/image version, they can search for it with az vm image list -p SUSE --all.

@zhoxing-ms to help with

Actually, This issue is a service issue. The specific error messages returned by service are as follows:
{
    "error": {
        "code": "InvalidTemplateDeployment",
        "message": "The template deployment 'vm_deploy_VCmU39nDHDjoukH7x8tRz1DbkC15aZ7M' is not valid according to the validation procedure. The tracking id is '78c203f6-59ad-44a7-b881-d2ec47a2d1be'. See inner errors for details.",
        "details": [
            {
                "code": "InvalidParameter",
                "target": "imageReference",
                "message": "The following list of images referenced from the deployment template are not found: Publisher: SUSE, Offer: SLES, Sku: 15, Version: latest. Please refer to https://docs.microsoft.com/en-us/azure/virtual-machines/windows/cli-ps-findimage for instructions on finding available images."
            }
        ]
    }
}

This seems to be caused by the image not being found. It is uncertain whether the data of some images in the offline file (file url) used by CLI has expired. This requires the service team to investigate the specific reasons.
x-ms-correlation-request-id: 78c203f6-59ad-44a7-b881-d2ec47a2d1be

@amjads1 can you take a look at this issue?

@amjads1 any update for this?

@susegrant Apologies for the delay response here. Based on the information provided on this issue by @zhoxing-ms, issue seems to be related to images being outdated but needs further investigation to confirm the same and fix it accordingly. I should have more details to share by end of this week.

@susegrant I have reached out to the engineering team to get further clarification on the issue and hoping to have an update within 1-2 days. Thanks for your patience!

@susegrant As we are looking into the issue, it seems that there's no default image and you may need to go with the latest version. While we continue to look for other possible use cases, can you try with the latest version and confirm?

@susegrant Thanks for the confirmation! I'm currently working with the CLI and other service teams internally to understand why the above syntax you have shared is not working for SLES images.
I will update back as soon as I have more information on the root cause and next steps to fix this issue. Thanks for your patience!

Fixed by this PR https://github.com/Azure/azure-rest-api-specs/pull/16707


TvEventHandler eventKeyAction to 0

Looks like the tvEventHandler no more trigger eventKeyAction to zero like before

This is expected, and is a side effect of the fix implemented for #233 .

Still facing same issue...


chore: remove controller calls from earner

Codecov Report

Merging #197 (0d4f4d2) into develop (7fb8c7e) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #197      +/-   ##
===========================================
+ Coverage    36.60%   36.70%   +0.10%
===========================================
  Files           19       19
  Lines         1407     1403       -4
===========================================
  Hits           515      515
+ Misses         892      888       -4

Impacted Files
Coverage Δ

src/earner.py
0.00% <ø> (ø)


Update table docs

This PR does two small things:

Documents that :label: is needed for table numbering.
Introduces import table from file via {include}. This currently has an error, so needs a check.

I've added an HTML table file too.

I think the relevant error is:
⚠  tables.md:135 Cross reference target was not found: include


KeyError in convert_gather

Hello,
I'm trying to convert a version of MobileNetv2 to keras, and the conversion almost finishes but fails in convert_gather. I'm trying to figure out how the code gets the 'name in state_dict' entry so I can try to debug... FYI, I am not using your mobilinet.py script in the tests directory.
Here's a snippet of the last few lines of the terminal output/the error:

('graph node:', u'MobileNetV2')
('node id:', u'1331')
('type:', u'onnx::Gather')
('inputs:', ['1329', '1328'])
('outputs:', [u'MobileNetV2'])
('name in state_dict:', '1329.1328')
('attrs:', {u'axis': 0})
('is_terminal:', False)
Converting embedding ...
Traceback (most recent call last):
File "mobilinet.py", line 96, in
k_model = pytorch_to_keras(net, input_var, (3, 32, 32,), verbose=True)
File "/home/Desktop/pytorch2keras/pytorch2keras/converter.py", line 317, in pytorch_to_keras
names
File "/home/Desktop/pytorch2keras/pytorch2keras/embedding_layers.py", line 33, in convert_gather
W = weights[weights_name].numpy()
KeyError: '1329.1328.weight'

I have the same problem. The code uses the same function to convert both Gather and Embedding layer. It seems that the Gather layer doesn't have something called 'weight' while the Embedding layer does.
So far I know that Keras use K.gather() function to do the embedding thing. But I just can't figure out how to generate the wight for a Gather layer.


Adding Signature - Daniel Berryhill

Adding my signature.
Respectfully,
Daniel Berryhill

Technical issues. Choosing the email route instead. Thanks!


UseCompatibleSyntax.md Documentation Out of Date

It appears that the documentation UseCompatibleSyntax.md is out of date. I say this because the markdown file lists 6.0 as the newest version that can be checked, but this page shows 6.2:
DevBlogs Post About PSScriptAnalyzer
Also, I presume 7.0 is also supported by this point?
Can this page be updated to show the versions that can be checked? Thanks in advance!

As per PSSA 1.19.0 release post here, PowerShell 7 syntax support has been added (mainly in PR #1331 and #1426). The markdown doc is more of an example but should be enhanced to include all supported versions for that rule or at least the maximum supported version of the last PSSA release.
@rjmholt Looking at the code, here and here it seems that the rule only takes the major versions internally only anyway. Not much of an issue atm because it's a hidden implementation detail with no impact to the user but that will probably have to change for PowerShell 7.1/7.2

You confirmed what I suspected after reviewing that same code, i.e., that only major versions matter (3.0 - 7.0). Thanks for that - it gets me by for now.

that only major versions matter

That's true so long as new syntax isn't introduced in a minor version; the rule is based on syntactic changes made from version to version, and so far no minor version has introduced new syntaxes.

Not sure if this issue should still be used, but for the record 7.3 added clean to script block, so people would might be interested in testing for it.


Support multi-account setups

🗣 Description
This PR modifies the test user Terraform to support a multi-account setup (like the COOL), where the test user may not reside in the same AWS account as the S3 bucket that contains the Nessus package.

💭 Motivation and Context
We want to standardize this Ansible role (and all of our roles) so that they work properly within the COOL environment, and still remain functional in single-account setups (like our Production CyHy account).

🧪 Testing
All automated tests pass.

📷 Screenshots (if appropriate)
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I've got to make a few more changes before this thang is ready for review, so stay tuned.


HSE PMID:27966061

increased transcription from HSE promoter
see SO:0001850

increased transcription from HSE promoter FYPO:0005886

edit file: de7745210933ee0c76aa64dd9366ba2750ca5515
release: 33aa05df02539d433cfa8db6fa62fe5861d13072


feat: add dark mode

Dark Mode:

Light Mode:

I've made the requested changes and updated the snapshot. I'm considering maybe making the Prism theme in another pull request at a later time.
Thank you.


Install/Uninstall the Docker Service

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

This PR will automatically install the Windows service if one doesn't already exist. Upon uninstall the service will be removed, only if it was originally installed by conda.


SVS-114: Enable connected mode for VB.Net

SonarQube analysis reported 4 issues

 3 major
 1 info

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.


Be sure that mean rewards are well scaled on the y axis for non stationary problems

[ ] Fix that!


Tables in Documentation not rendering properly

📚 The doc issue
Compared to the last release, the tables in the documentation of the main branch is rendering differently. I do not recall any intentional changes to the format of our documentation or generation. We should have a look at this before the next release.
Before (0.5.1):

Current (main):

The last commit from 0.5.1 is 222877d479a6b2c6ed0348c2039e8515ae5ccfb5
So, the culprit has to be a commit after 4ea88d1fb4d279def9213a23b054b4e7d46d5b3d under https://github.com/pytorch/data/commits/main/docs

Also the section expansion works less well now, but unsure if it is related.
Some suspects:

#850
#919
Adding pydot or graphwiz to docs/requirements.txt??

I think this is still not fixed

It's weird that the table is still not rendered correctly.
Nightly: https://pytorch.org/data/main/dataloader2.html
My own replica is rendered correctly though: https://ejguan.github.io/dataloader2.html

Yea... I think my local copy is rendered properly as well. Unsure what's specific about GHA process that causes this.

Let me try to update my sphinx to 6.1.3 aligned with release workflow to see if my local build would change or not.

After updated sphinx to 6.1.3, I can now reproduce the rendering problem.

Aha, simple solution -> pin sphinx to 5 lke pytorch https://github.com/pytorch/pytorch/blob/207399cf5f68a6370cbacc28fce3fc5d9132c87f/docs/requirements.txt#LL1

Confirm the patch works.


Updates dependencies

Closes demurgos/turbo-gulp#91
Closes demurgos/turbo-gulp#92
Closes demurgos/turbo-gulp#93
Closes demurgos/turbo-gulp#94
Closes demurgos/turbo-gulp#95
Closes demurgos/turbo-gulp#96
Closes demurgos/turbo-gulp#97
Closes demurgos/turbo-gulp#98
Closes demurgos/turbo-gulp#99

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 83.87%.

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   66.88%   66.88%
=======================================
  Files          38       38
  Lines         912      912
  Branches       99       99
=======================================
  Hits          610      610
  Misses        232      232
  Partials       70       70

Impacted Files
Coverage Δ

src/lib/utils/nyc.ts
61.53% <0%> (ø)
:arrow_up:

src/lib/utils/mocha.ts
61.76% <0%> (ø)
:arrow_up:

src/lib/project.ts
100% <100%> (ø)
:arrow_up:

src/lib/utils/node-async.ts
84.12% <100%> (ø)
:arrow_up:

src/lib/utils/matcher.ts
68.75% <70%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5235151...7e68fa3. Read the comment docs.


Add attempts field to ActivityTaskCompleted event

It might be useful to understand why activity took so long to execute.

Hi @mfateev, attempts field is already added to ActivityTaskStarted event. Do we want to:

Move that to ActivityTaskCompleted  and other(ActivityTaskFailed, Canceled, Timeout) etc.
Keep in both ActivityTaskStarted and 1.
Keep just in ActivityTaskStarted.

I think it should be enough to have this in ActivityTaskStarted. @mfateev you can reopen this if you think otherwise.


Incorrectly detected platform on Windows

Describe the problem
The platform is not detected correctly on a Windows machine.
On the PC I work on the contents of RbConfig::CONFIG['arch'] is x64-mingw-ucrt
Actual behaviour
TTY::Platform.new.windows?  # false
Gem.windows?  # true

Expected behaviour
TTY::Platform.new.windows?  # true

Describe your environment

OS version: Windows 11
Ruby version: 3.3.4
TTY::Platform version: 0.3.0

Hi @Fjan 👋
Thanks for raising this issue.
The pattern that I use to match Windows includes the mingw, so it should theoretically detect the Windows system.
Therefore, I'd be interested to know what you get for the following values:
RbConfig::CONFIG["host_os"] # => ?

platform = TTY::Platform.new
platform.windows?  # => ?
platform.unix?     # => ?
platform.linux?    # => ?
platform.mac?      # => ?
platform.cpu       # => ?
platform.os        # => ?
platform.version   # => ?

Looking at Gem.windows? implementation, the RbConfig::CONFIG["host_os"] is checked instead. The TTY::Platform accepts architecture as an argument, it would be great to see what results you get:
platform = TTY::Platform.new(RbConfig::CONFIG["host_os"])
platform.windows?  # => ?
platform.unix?     # => ?
platform.linux?    # => ?
platform.mac?      # => ?
platform.cpu       # => ?
platform.os        # => ?
platform.version   # => ?

Hi @piotrmurach
This what I get on that machine, hope this helps.
irb(main):002> RbConfig::CONFIG["host_os"]
=> "mingw32"
irb(main):003> platform = TTY::Platform.new
=> #<TTY::Platform:0x000001eaff09d008 @cpu="x64", @os="unknown", @version=nil>
irb(main):004> platform.windows?
=> false
irb(main):005> platform.unix?
=> false
irb(main):006> platform.linux?
=> false
irb(main):007> platform.cpu
=> "x64"
irb(main):008> platform.os
=> "unknown"
irb(main):009> platform.version
=> nil
irb(main):010> platform = TTY::Platform.new( RbConfig::CONFIG["host_os"] )
=> #<TTY::Platform:0x000001eaff09e3b8 @cpu=nil, @os="mingw32", @version=nil>
irb(main):011> platform.windows?
=> true
irb(main):012> platform.cpu
=> nil
irb(main):013> platform.os
=> "mingw32"
irb(main):014> platform.version
=> nil


Cannot runIde with gradle

I'm trying to run the IDE but without any luck.
⚡ nojaf@NOJAF-PC  ~\Projects\rider-fsharp-support\rider-fsharp   net202 ≣                                 [15:46]
❯ .\gradlew runIde

> Configure project :
*** Using Rider SDK from intellij-snapshots repository

> Task :rdgen
Reading hash from build\rdgen\.rdgen
No changes since last start

> Task :compileKotlin FAILED
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (49, 44): Unresolved reference: prevSibling
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (55, 48): Unresolved reference: prevSibling
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (66, 44): Unresolved reference: nextSibling
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (73, 48): Unresolved reference: nextSibling
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (135, 43): Cannot access 'getSortedChildren': it is private in file
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (136, 42): Cannot access 'getSortedChildren': it is private in file
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (151, 43): Cannot access 'getSortedChildren': it is private in file
e: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\src\main\java\com\jetbrains\rider\plugins\fsharp\projectView\FSharpMoveProviderExtension.kt: (152, 42): Cannot access 'getSortedChildren': it is private in file

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileKotlin'.
> Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s
3 actionable tasks: 2 executed, 1 up-to-date
⚡ nojaf@NOJAF-PC  ~\Projects\rider-fsharp-support\rider-fsharp   net202 ≣                                 [15:46]
❯

gradle prepare ran without any problems.
nojaf@NOJAF-PC  ~\Projects\rider-fsharp-support\rider-fsharp   net202 ≣                                    [15:45]
❯ .\gradlew prepare

> Configure project :
*** Using Rider SDK from intellij-snapshots repository

> Task :rdgen
Reading hash from build\rdgen\.rdgen
No changes since last start

> Task :writeDotNetSdkPathProps
SDK path: C:\Users\nojaf\Projects\rider-fsharp-support\rider-fsharp\build\riderRD-2020.2-SNAPSHOT\lib\DotNetSdkForRdPlugins

BUILD SUCCESSFUL in 1s
3 actionable tasks: 3 executed

Am I missing something here? Or can I clean a cache somewhere?

@nojaf There're apparently another set of API changes in the SDK, I'm looking into it.

@nojaf Some APIs got broken and we'll have to fix them in the SDK. I've pushed a workaround to net202.

Thanks!


Labels of circular geometries are positioned in the center instead of within geometry

Labels of circular geometries are positioned in the center of the geometry. But due to readability and logic, in my point of view it should be placed within the actual geometry.
So in this example the yellow and light green label are placed in the center as well, making the dark green label unreadable:

You can define your own label position in a style function. Instead of configuring an ol.style.Text in the style you use to symbolize the polygon, create a separate ol.style.Style with an ol.style.Text and a point geometry that represents your desired label point.


Long tags in code snippet search overflows the button element

Describe the issue
Long tags in code snippet search overflows the button element when the side pane is narrower than the text

To Reproduce
Steps to reproduce the behavior:

Open the code snippet widget (click code snippets button on the side bar)
Either edit an existing snippet or create a new one
Add a tag with a long name and press enter to enable it
Save and close
Go back to the code snippet widget (side panel)
Click on the tag button to filter for tags
Check the long tag added
Play with the side pane width (the problem happens on narrow states)

Expected behavior
The tag name should be contained in the button element, independent of the widget width.
If the full text can't fit, we could trim the end such as
thisisanexampleofaverylongtag --> thisisanexample...
Environment information

Elyra version: 2.1.0rc2
Operating system: MacOS
Browser: Chrome

Hi, you can assign this to me.


Github Integrations not refreshing user token

We are currently using the Github Integration using a Github App setup following this tutorial: https://backstage.io/docs/plugins/github-apps. The integration works, but after about a day API requests to the Github API for Github Actions and Pull Requests start throwing a 401 error. The error goes away and the integrations works as expected if you log out of Backstage and log back in.
Expected Behavior
API requests to the Github API should continuously work without having to log out and log back in.
Current Behavior
See summary.
Possible Solution
My current hypothesis is that the user token for the app is not being refreshed. I saw somewhere that the token is cached in the browser, so maybe the cache isn't being updated?
Steps to Reproduce

Setup Github Integration with Github Apps
Wait
Observe that the API no longer accepts requests using the current credentials
Log out of Backstage
Log back into Backstage
Observe that the integration works again

Your Environment
This has been observed in multiple environments (both locally using the scaffolded Backstage app and our production deployment inside a k8s cluster) so I do not believe it is environment specific.

Hi @chandlj,
Just to clarify that this the OAuth login flow for the user in the UI right? There's currently no support for refresh tokens as the traditional OAuth apps never expire so you can't refresh them. However the new Github apps support refresh tokens so we need to implement it in the backend. There's also a caveat that you can't request additional scopes in the user flow and are tied to those granted to the app itself. @Rugvip is looking into ways to detect this and handle it properly, the story continues... :)

We have the same issue as well. We use separate OAuth integration for actual login, and have Github App set up for authenticating to the Github Actions plugin. We observe the same behaviour, and to fix the problem we have to log out from github and user profile and login again.


TRG 4.03 image has USER command and Non Root Container

Missing User cmd
RUN chown -R 1000:3000 /app
Link to example: https://eclipse-tractusx.github.io/docs/release/trg-4/trg-4-03#implementation
#Pull the base image as Ubuntu
FROM ubuntu:latest
#Add a user with userid 1000 and name nonroot
RUN useradd −u 1000 nonroot
#Run Container as nonroot
USER nonroot
Hint securityContext User reference to 1000 in your example:
https://github.com/eclipse-tractusx/ssi-credential-issuer/blob/fd8e687fa2ef80b2fef5b83206a7e4c206d7acf6/charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml#L36
apiVersion: v1
kind: Pod
metadata:
  name: example-pod
spec:
  securityContext:
    runAsUser: 1000 # SPECIFY USER ID HERE
  containers:
  - name: example-container
    image: gcr.io/google-samples/node-hello:1.0
    securityContext:
      allowPrivilegeEscalation: false # SET THIS TO FALSE

Hi @FaGru3n the images run by default as user 1000 https://github.com/eclipse-tractusx/ssi-credential-issuer/blob/main/docker/Dockerfile-credential-issuer-migrations#L35 and the security context is set accordingly as well https://github.com/eclipse-tractusx/policy-hub/blob/main/charts/policy-hub/templates/job-policy-hub-migrations.yaml#L45

Jep security context seems right, maybe you can use the base image non root user for the application as well.
Hint from @almadigabor https://github.com/dotnet/dotnet-docker/blob/main/src/runtime-deps/8.0/alpine3.19/amd64/Dockerfile

the non root user is used for the application

as I said the images run by default as user 1000 https://github.com/eclipse-tractusx/ssi-credential-issuer/blob/main/docker/Dockerfile-credential-issuer-migrations#L35


Fix failing K8ssandraTask integration tests

What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CHANGELOG.md updated (not required for documentation PRs)
[ ] CLA Signed:  DataStax CLA

The failure on ExecuteSequentialK8ssandraTask happens because the "active" count is wrong:
k8Task.Status.Active expected 0 actual 1
k8Task.Status.Succeeded expected 2 actual 2
k8Task.Status.CompletionTime expected 2023-02-22 17:00:09 -0800 PST actual 2023-02-22 17:00:09 -0800 PST
k8Task.GetConditionStatus(cassapi.JobRunning) expected False actual False
k8Task.GetConditionStatus(cassapi.JobComplete) expected True actual True

It gets computed from K8ssandraTask.status.datacenters, where the information is also wrong (the last 3 numbers at the end should be "0 1 0"):
dc2 {[{Running False 0001-01-01 00:00:00 +0000 UTC 2023-02-22 16:59:50 -0800 PST  } {Complete True 0001-01-01 00:00:00 +0000 UTC 2023-02-22 16:59:50 -0800 PST  }] 2023-02-22 17:00:00 -0800 PST 2023-02-22 17:00:09 -0800 PST 1 1 0}

That information is a copy of the status of the CassandraTask. However, if I log that, the information is correct:
cassTask2.Status {[{Running False 0001-01-01 00:00:00 +0000 UTC 2023-02-22 16:59:50 -0800 PST  } {Complete True 0001-01-01 00:00:00 +0000 UTC 2023-02-22 16:59:50 -0800 PST  }] 2023-02-22 17:00:00 -0800 PST 2023-02-22 17:00:09 -0800 PST 0 1 0}

So I'm thinking maybe something is wrong in the K8ssandraTask.Status patching.


Set up Azure Pipeline

Set up an Azure Pipeline to run this demo. This will allow us to test it and verify that it works.

[x] Created a slsa-framework organization in Azure DevOps.
[x] Create an azure-devops-demo project.
[X] Configure a pipeline to run the demo.
[x] Configure GitHub to automatically run the pipeline on commit.
[X] Add other members to the organization. (@TomHennen and @joshuagl for now - we're limited to 5)

It worked: https://dev.azure.com/slsa-framework/azure-devops-demo/_build/results?buildId=3&view=artifacts&pathAsName=false&type=publishedArtifacts
I'll continue to refine it.


Space in property "name" of insert-header-action seems to cause java.…

…lang.IllegalArgumentException
[1] 2021-06-09 19:43:08,803 INFO  [org.apa.cam.imp.eng.AbstractCamelContext] (main) Apache Camel 3.9.0 (camel-1) started in 269ms (build:0ms init:211ms start:58ms)
[1] 2021-06-09 19:43:08,899 INFO  [io.quarkus] (main) camel-k-integration 1.4.0 on JVM (powered by Quarkus 1.13.0.Final) started in 1.604s. Listening on: http://<IP_ADDRESS>:8080
[1] 2021-06-09 19:43:08,900 INFO  [io.quarkus] (main) Profile prod activated.
[1] 2021-06-09 19:43:08,900 INFO  [io.quarkus] (main) Installed features: [camel-attachments, camel-bean, camel-core, camel-k-cloudevents, camel-k-core, camel-k-knative, camel-k-knative-producer, camel-k-loader-yaml, camel-k-runtime, camel-kamelet, camel-platform-http, camel-support-common, camel-timer, camel-yaml-dsl, cdi, mutiny, smallrye-context-propagation, vertx, vertx-web]
I observed following exception on OCP 4.7, community operator Camel K 1.4:
[1] 2021-06-09 19:43:09,858 WARN  [org.apa.cam.imp.eng.DefaultReactiveExecutor] (Camel (camel-1) thread #0 - timer://tick) Error executing reactive work due to a header name cannot contain the following prohibited characters: =,;: \t\r\n\v\f: The Name. This exception is ignored.: java.lang.IllegalArgumentException: a header name cannot contain the following prohibited characters: =,;: \t\r\n\v\f: The Name
[1]     at io.vertx.core.http.impl.HttpUtils.validateHeaderName(HttpUtils.java:766)
[1]     at io.vertx.core.http.impl.HttpUtils.validateHeader(HttpUtils.java:673)
[1]     at io.vertx.core.http.impl.headers.VertxHttpHeaders.add0(VertxHttpHeaders.java:531)

We need to fix the Kamelet and regen


memory leak when loading multiple model

Some additional information? A minimal reproducible example would be helpful :smile:


[SPARK-15094][SPARK-14803][SQL] Remove extra Project added in EliminateSerialization

What changes were proposed in this pull request?
We will eliminate the pair of DeserializeToObject and SerializeFromObject in Optimizer and add extra Project. However, when DeserializeToObject's outputObjectType is ObjectType and its cls can't be processed by unsafe project, it will be failed.
To fix it, we can simply add a plan to project object that can preserve DeserializeToObject's output expr id as the extra Project did. We will remove such extra plan and replace attribute later in optimization.
How was this patch tested?
DatasetSuite, EliminateSerializationSuite.

This is another approach to #12898.

Test build #57858 has started for PR 12926 at commit 48e6b6d.

Test build #57858 has finished for PR 12926 at commit 48e6b6d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ObjectProject(
case class ObjectProject(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57858/
Test FAILed.

Test build #57873 has started for PR 12926 at commit 737c518.

Test build #57873 has finished for PR 12926 at commit 737c518.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57873/
Test PASSed.

Merged build finished. Test PASSed.

Test build #57955 has started for PR 12926 at commit 3d0554d.

Test build #57955 has finished for PR 12926 at commit 3d0554d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57955/
Test PASSed.

cc @cloud-fan @yhuai @rxin

I think a simpler and better approach is just removing this alias only project in next batch.

@cloud-fan But how about to preserve DeserializeToObject 's output expr id?

Sorry, when I say "remove", I mean a safe removal that we transform the plan tree and replace attributes produced by alias with the original attributes.

@cloud-fan ok. let me try it.

Test build #58127 has started for PR 12926 at commit 4b0773a.

Test build #58127 has finished for PR 12926 at commit 4b0773a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58127/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58326 has started for PR 12926 at commit 29a0c70.

Test build #58326 has finished for PR 12926 at commit 29a0c70.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58326/
Test FAILed.

Merged build finished. Test FAILed.

Test build #58351 has started for PR 12926 at commit 85fba17.

Test build #58353 has started for PR 12926 at commit ea55398.

Test build #58351 has finished for PR 12926 at commit 85fba17.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58351/
Test PASSed.

Test build #58353 has finished for PR 12926 at commit ea55398.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58353/
Test PASSed.

mostly LGTM except some style comments

Looks pretty good!

Test build #58440 has started for PR 12926 at commit c3748ba.

@cloud-fan @zsxwing Thanks! I've addressed your comments now.

Test build #58440 has finished for PR 12926 at commit c3748ba.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58440/
Test FAILed.

test this please.

Test build #58447 has started for PR 12926 at commit c3748ba.

Test build #58447 has finished for PR 12926 at commit c3748ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58447/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58474 has started for PR 12926 at commit 882fc66.

Test build #58474 has finished for PR 12926 at commit 882fc66.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58474/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

Thanks. Merging to master and branch 2.0.


Not working on [ ]

Hi, the plugin seems to be working fine with the exception of the [ and ]. I assume this is conflicting with another plugin and not an issue with tabout, so I'm wondering if you have any idea what might be causing this?

Hi @KadoBOT,
yes and no ;) It depends on the language you are using and how treesitter is interpreting the node you are in.
As example in a .js file:
xxx[|] <-- won't be able to tabout

var x = "xxx[|]" <-- tabout of [ as well as "

I plan on a rewrite to make it possible to set also the global treesitter node and others to be checked for tabout possibilities, but no ETA on that right now.
For now it is most likely that this limitation causes your issue. You can double check with the example above if this is the case.

Thanks, @abecodes for the info, that was it. I test your example and it worked perfectly. 👍🏻


Add "balancing" binary sensor

Expose a bit of the operation mode bitmask as binary sensor.

Fixed by #60


Duplicate task execution

Hello, with a standard configuration of the provider, we juste found a use case where same activity was run twice without any trace in the history. Only trace we found was the double call in our appinsight.
I will try to reproduce it. (the server was not at all under heavy stress)

Were the duplicate calls on the same VM instance or different VM instances? Also, how much time was there between the two invocations. In most cases, this would indicate an automatic retry caused by a process failure.

I think it's matching lock has the duration took about 2 min more than usual

it's different VM instances

Is this issue still active ? We also found a case of activities being run twice. Our function app is in consumption mode and the interval between the two invocations is about 5 minutes.

Yes, still active. However, it should be noted that some duplicate task executions can be expected, particularly when VMs come in and out of rotation. This is especially true when running function apps in the consumption plan, where app instances can be created and removed within seconds. There is potentially some work that can be done to make the transitions more graceful and reduce the likelihood of duplicate executions. More investigation would be required to see what's possible.


Drop target always set to document.body

I'd like for drop target to be set to _immediateUserSelection and was wondering if any of these
steps are still supported?
https://github.com/timruffles/ios-html5-drag-drop-shim/blob/rewrite/src/drag-drop-polyfill.ts#L749

As far as dropzone attribute support is concerned I do not have any plans to implement them because they are not implemented by browsers that support native drag and drop.
To achieve the desired effect just implement drag and drop as usual by canceling the dragenter-event on the desired drop target element.

Thanks for the response! If I understand correctly, the idea is that dropping will be allowed on on the target element if default dragenter behavior is cancelled on it, right?
I'm trying this though and It seems that the dragexit, dragleave, dragover, and drop events are firing at document.body and the event listeners on my target aren't picking up on the event.. was wondering if maybe I'm missing something?

oops nevermind, that seems to have done the trick, thanks for the help!


select two files to compare

feature request: it would be awesome if there is a mode where you could select two files to compare
current behaviour:

select one file via from > file
select action > generate
copy+paste the generated hash into custom hash field
from > file to select second file
action > generate
action > compare

this is a pretty clunky multi step process
proposed feature:

select one file
select another file
Press a button

expected behaviour: the app hashes both selected files and shows their hash and comparison result on screen

I don't have time to support the application, so the edits are unfortunately not relevant.


Patient Record - ANC Progress Report Design Changes [4h]

Issue [Updated]
To keep all the progress report consistent in look and feel some minor design changes have been made to the ANC progress report. These changes should be made across all ANC progress reports in the app.
Changes include:

Updated the heading section to be consistent with other progress reports
Compressed the floating boxes to touching
Moved photos to the bottom ( #101 )

See photos for comparison

Old Progress Report
New Progress Report

Tasks:

Style per design

update heading style
remove padding around floating boxes so they fill the width of screen
remove padding between floating boxes so they touch

@jeanette-pelizzon the patient header information for Patient Record is different to individual progress reports within modules:

Patient Record
ANC Report

Worth making sure that the patient header for individual ANC reports within the module is also adapted accordingly.

@isapisa we made some changes to the overall flow of the patient record so the heading issue is resolved by that. No changes are being made to the ANC progress report heading at all now. Just removing padding and ensuring the photos are moved to the bottom.

@anvmn

The header doesn't match the new design

Not really related to this issue (but not sure where to put it) - when you click "more" for a completed pregnancy, you get to the labs results page, not the progress report. see video:
https://www.loom.com/share/ef2f65fb37a1448592ac179646cc89b3

@adamhstewart

The header doesn't match the new design

This is what is what we have at Figma:

This is what we have implemnented:

Please point out the mismatches.

@adamhstewart

Not really related to this issue (but not sure where to put it) - when you click "more" for a completed pregnancy, you get to the labs results page, not the progress report

Fixed at https://github.com/TIP-Global-Health/eheza-app/pull/180

As per @adamhstewart, https://github.com/TIP-Global-Health/eheza-app/issues/91#issuecomment-1062675597 changes are not required. Moving to QA.


Fix kafka input binding looping when not topics are set

Signed-off-by: Tim Burkert<EMAIL_ADDRESS>Description
Prevent kafka input binding reading when no topics are provided. When not or only malformed topics are provided, the read binding will loop forever and waste resources.

Issue reference
Please reference the issue this PR will close: #1399
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Thanks for your contribution! LGTM overall, just a small change.

Thanks for your contribution! LGTM overall, just a small change.

Did you submit your review? I don't see any comments.

Thanks for your contribution! LGTM overall, just a small change.

Did you submit your review? I don't see any comments.

Thanks, I have forgotten to submit it.

Thanks @Gehhilfe for this PR!