Change opportune parry to trigger on enemy attack instead of hit.

Hey there. I was really enamoured with the idea of your opportune parry feat and built a character around it. But I found that in practice it doesn't really pop off like I was hoping because you only make parry attempts on attacks that would succesfully hit you.
The aldori defender and duelist paths are inherently quite defensive, so what I experienced was not the "shredding weak opponents that try to attack you" that I was hoping for. Since many enemies were only hitting me with high rolls this also made it much less likely for me to succesfully parry even if I got a parry attempt. Often ending my turns surrounded by enemies but still with several AoO's remaining due to lack of valid parry attempts.
In short, I'd love it if this could be an option so we can live the supreme duelist who ripostes hordes to death fantasy.

Please try out "Patch: Parry Always"

Just gave this a shot on the new 1.5.2 version but it didn't seem to be working. Though I won't discount that another mod could be interfering.

You did enable it and restart the game?

I did, aye.

I just did some testing and I can't get it to work either. Sometimes I will get a parry within a round, but it appears to be working on vanilla conditions (not very often, no more than 1x/round).
I made sure I had it enabled/restarted game. Then made sure the character was using a 1h/light weapon (rapier) and had both duelist parry and duelist opportune parry. The character had combat reflexes, but just to be sure, I used toybox to add 100 attacks of opportunity as well.
This is great idea and hope it is doable. Swashbuckler was always such a fun class and I was excited to see this added. I definitely miss it from the kingmaker mod.

Sounds more like that feature doesn't work at all. Fine, will check when I find time.

Probably works now.

This is awesome, works great!


How do I add oauth?

I am figuring out how to add my credentials to download private videos when I try to add my credentials I don't see any prompts asking me to log in.
Is this supported or is this me missing something?
(venv) callumosborne@Callums-MacBook-Pro track-library % python3
Python 3.9.6 (default, Aug 11 2023, 19:44:49)
[Clang 15.0.0 (clang-15<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pytubefix import YouTube
>>> yt = YouTube(
...         'http://youtube.com/watch?v=2lAe1cqCOXo',
...         use_oauth=True,
...         allow_oauth_cache=True
...     )
>>>
`

I am figuring out how to add my credentials to download private videos when I try to add my credentials I don't see any prompts asking me to log in.
Is this supported or is this me missing something?
(venv) callumosborne@Callums-MacBook-Pro track-library % python3
Python 3.9.6 (default, Aug 11 2023, 19:44:49)
[Clang 15.0.0 (clang-15<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pytubefix import YouTube
>>> yt = YouTube(
...         'http://youtube.com/watch?v=2lAe1cqCOXo',
...         use_oauth=True,
...         allow_oauth_cache=True
...     )
>>>
`

Hello, you missed calling the download() method, a step-by-step guide will appear with a code that you will have to use in a link that will appear, I hope I helped, try a code similar to this:

from pytubefix import YouTube
from pytubefix.cli import on_progress

url = input("URL >")

yt = YouTube(url, use_oauth=True, allow_oauth_cache=True, on_progress_callback = on_progress)
print(yt.title)

ys = yt.streams.get_audio_only()
ys.download(mp3=True)

That worked, thank you!
Thanks for keeping this package up to date


Allow to delete the starting or ending vertex

Hi,
With this PR, I would like to fix #3708 and to have the ability to delete the starting or ending vertex of a ol.geom.LineString
Could someone please review ?

I can take a look at this when I'm back home at the end of the week

thanks for tackling this @rmichaelis. Just tested various moves/deletes/adds with my own code, and this LGTM. Anyone from the core team want to take a look?

Looks good to me too. @rmichaelis, can you please submit a CLA so we can merge this? Thanks.

Thanks for the review.
The CLA has been submitted.

Thanks @rmichaelis. Would you be able to add a unit test?

@ahocevar I'll add a unit test this week.

I've just added my first tests.
I hope that it is what you're expecting.

it would be good if this one could be included in the next release, though I'm not sure the merge commit is wanted.

Is someone awaiting an action from me before merging this PR ?

Thanks @rmichaelis. Sorry, this simply got lost in the queue. Merging now.


If archive have a new name, try to get it from Github release page

Description
If you try to download kubeseal with arkde 0.8.12, you get v0.14.1. Now trying to get v0.17.1, you get an error:
arkade get<EMAIL_ADDRESS>
Downloading: kubeseal
Downloading: https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.17.1/kubeseal-linux-amd64
Error: incorrect status for downloading tool: 404

Motivation and Context

[X] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?
Download kubeseal version v0.14.1 (direct download of the binary):
arkade get<EMAIL_ADDRESS>Downloading: kubeseal
Downloading: https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.14.1/kubeseal-linux-amd64
33.56 MiB / 33.56 MiB [----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
/tmp/kubeseal-linux-amd64 written.
...

file /home/yannig/.arkade/bin/kubeseal
/home/yannig/.arkade/bin/kubeseal: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=uDciUD6TUaSCxCVMfL3S/R9gWKA3w-zpjU2-Sy7KK/jwzKqQMM1X-dRjEmggjY/cW09PaeFey-p85_XeuNW, not stripped

Now download version v0.17.1 (embedded inside a tar.gz archive):
arkade get<EMAIL_ADDRESS>
Downloading: kubeseal
Downloading: https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.17.1/kubeseal-linux-amd64
Error while downloading template URL (https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.17.1/kubeseal-linux-amd64)
Try to autodetect archive url in Github release
Archive /bitnami-labs/sealed-secrets/releases/download/v0.17.1/kubeseal-0.17.1-linux-amd64.tar.gz seems to be compatible with linux/x86_64
Autodetect archive name inside Github: https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.17.1/kubeseal-0.17.1-linux-amd64.tar.gz
13.97 MiB / 13.97 MiB [----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
/tmp/kubeseal-0.17.1-linux-amd64.tar.gz written.
/tmp/LICENSE LICENSE
/tmp/README.md README.md
/tmp/kubeseal kubeseal
2022/01/20 14:48:06 extracted tarball into /tmp: 3 files, 0 dirs (252.940385ms)
2022/01/20 14:48:06 Extracted: /tmp/kubeseal
2022/01/20 14:48:06 Copying /tmp/kubeseal to /home/yannig/.arkade/bin/kubeseal

Tool written to: /home/yannig/.arkade/bin/kubeseal
...

file /home/yannig/.arkade/bin/kubeseal
/home/yannig/.arkade/bin/kubeseal: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=3tbTRrSgy9uJfZVH27iS/uugQD8256WqGh51DVHiq/FE2T9o6gXx--tLPAxez6/zTb2jyY8RMvwQ2pxJytN, not stripped

You can download both version as you want.
In reality, these new functions should make it possible to avoid some declaration for simple cases. The OS/Arch auto-detection feature relies on the contents of the release page.
Are you a GitHub Sponsor (Yes/No?)

[ ] Yes
[X] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Looks like we have merge conflicts that need to be fixed before I can look at this for you.
 Happy for you to put them in your pull request description instead.

Wow there are so many changes. Why?

I am aware that there are indeed a lot of changes but for the most part it is the result of two things:

Addition of detection of systems or processor architectures (isOsCompatible, isArchCompatible) and the capacity to parse available files in an existing Github release (getGithubReleaseArchive). Not couting the corresponding unit test
the addition of the version in the results returned by the functions GetDownloadURL, GetURL and getByDownloadTemplate.

These changes are necessary in order to propagate the version detected during calls to the Download function. Unfortunately, the change of GetURL has the consequence of changing a lot of stuff in the unit tests.
I will try to rework my PR to reduce these changes.

Essentially, I moved the call to the getToolVersion functions as well as IsArchive in order to simplify things.
The rest consists of the addition of search functions on the type of OS (isOsCompatible) or arch (isArchCompatible). These two functions are then used by getGithubReleaseArchive. This function retrieve files from given release and keep only the one compatible with the current request.
The rest of the commit consists of adding unit tests.

Please see #611 which is more like what I was expecting. Let us know if you see any differences in the final result.


Fix 3 issues with route table associations

Fixes #5508 - replacing the main association raising an exception.
Fixes #5507 - showing all route tables as having the main association.
Fixes #5506 - the response for replace missing bits.
Existing unit tests fixed and a new one (testing replacing the main association) added.

I see only irrelevant failures reported.


Create ErrorCodesAndRetries.md

Adding client behavior documentation to SDK to provide easy access and clarity for customers.

API change check
API changes are not detected in this pull request.


feat/live 5094 exchange wallet api backport

📝 Description
This PR backport the platform-api's exchange app endpoints into the newer wallet-api
❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

You'll need to update the doc


[SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT

What changes were proposed in this pull request?
This PR proposes to switch the class loader strategy from ScalaLibrary to Flat (see https://www.scala-sbt.org/1.x/docs/In-Process-Classloaders.html):
https://github.com/apache/spark/runs/1314691686
Error:  java.util.MissingResourceException: Can't find bundle for base name org.scalactic.ScalacticBundle, locale en
Error:  	at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1581)
Error:  	at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1396)
Error:  	at java.util.ResourceBundle.getBundle(ResourceBundle.java:782)
Error:  	at org.scalactic.Resources$.resourceBundle$lzycompute(Resources.scala:8)
Error:  	at org.scalactic.Resources$.resourceBundle(Resources.scala:8)
Error:  	at org.scalactic.Resources$.pleaseDefineScalacticFillFilePathnameEnvVar(Resources.scala:256)
Error:  	at org.scalactic.source.PositionMacro$PositionMacroImpl.apply(PositionMacro.scala:65)
Error:  	at org.scalactic.source.PositionMacro$.genPosition(PositionMacro.scala:85)
Error:  	at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
Error:  	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Error:  	at java.lang.reflect.Method.invoke(Method.java:498)

See also https://github.com/sbt/sbt/issues/5736
Why are the changes needed?
To make the build unflaky.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
GitHub Actions build in this test.

Test build #130436 has started for PR 30198 at commit 68115b5.

Test build #130437 has started for PR 30198 at commit 57606c7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35041/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35042/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35041/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35041/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35042/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35042/
Test PASSed.

@dongjoon-hyun, @maropu, @gengliangwang, @gemelen, could we merge this and see how it goes if the tests pass?
Seems 5 consecutive builds passed without that issue - I retriggered 5 more builds again just for doubly sure.

Test build #130443 has started for PR 30198 at commit 866a02e.

looks fine. just out of curiosity; this strategy change doesn't affects test running time?

Test build #130437 has finished for PR 30198 at commit 57606c7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #130443 has finished for PR 30198 at commit 866a02e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #130436 has finished for PR 30198 at commit 68115b5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130443/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130437/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130436/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35048/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35048/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35048/
Test FAILed.

@maropu, I am not very sure. From reading the doc, seems it dose because it will change a class loader, within SBT, that is used during test tasks. I think the SBT maintainer suggested this way by suspecting that there's something wrong in the reused class loader. So by changing it to Flat, it won't be reused anymore.
Ideally it should not have any behaviour change even with the default ScalaLibrary but seems it did (?).

I ran the build 15 times. Meaning 150 times build, and I don't see the same error anymore. Other errors look something already going on without this PR.
I am going to merge this.. let's see how it goes.
Merged to master.

Won't it be useful to guard this setting with condition to use only on JVM earlier than 11 then?
// Seems I'm a bit late with that :)

Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release, that is built by JDK 8, that also works on both JDK 8 and JDK 11.
GitHub Actions has a job that builds it with JDK 11 but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.

Thank you, @HyukjinKwon !

I still observe the issue in https://github.com/apache/spark/pull/30377/checks?check_run_id=1405697533

Thanks @MaxGekk. It became less frequent given my observation but maybe I was wrong. I will check the builds tomorrow more closely.


Link goes to 404

"Data Explorer" link at the end of the first paragraph links to https://docs.influxdata.com/chronograf/v1.7/guides/visualization-types/ which is 404
URL for relevant page?
https://docs.influxdata.com/chronograf/v1.7/guides/visualization-types/
What products and version are you using?
N/A? / Chronograph 1.7
Where did you look before opening the issue?
Searched the docs

I think this how now been fixed. Here's what I'm seeing:

Thank you, @dwgibbons @sanderson, this has been resolved.


Fix missing campaign field when generating universal link

Pull Request Changes:

Added campaign field on generating link

moved this pull request to #255. everything worked. next time, make changes to www.es6/branch.js and then run gulp prerelease for the changes to be pushed to www/branch.js. thanks for owning this!


Change revokation to revocation.

Added missing eventsub events "user.authorization.grant" and "channel.subscription.end". For consistency with existing event classes, they have been grouped with matching data structures.

Pull request summary

"Revokation" is a typo and does not match the message type "revocation" that Twitch uses. I do not have the means to test this at the moment, though I have implemented this fix successfully in a modified version of this library. I don't see reference to this in the documentation, so I don't think that needs updated. There are other uses of "revokation", though fixing them would fall into the category of a breaking change, so I left them alone for now.
Reference: https://dev.twitch.tv/docs/eventsub/handling-webhook-events
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[x] I have updated the changelog with a quick recap of my changes.

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Technically this doesn't fix an issue, it would also now cause inconsistencies in the eventsub module as the event that is dispatched is also called revokcation as well as the model.

In it's current state, "eventsub_revokation" will never be run, because message type "revokation" does not exist. I have personally run into this issue when debugging. Please look at my reference under "Twitch-Eventsub-Message-Type".

Ah I didn't read that properly, thanks.

It looks like GitHub had auto-filled some details from the other pull request I was working on. I separated the two because they address separate issues. I have fixed the summary now.

Thanks 👍


Document how to escape SQL Server connection string parts

See https://github.com/prisma/prisma/issues/11276#issuecomment-1017989820

Hi, coming from the other issue I tried enclosing the special characters in {}, but it doesn't work. How is the documentation coming along?

Actually it does work... sorry about that. I just needed to find the correct characters to escape 🤦♂

I'm sorry that I have to come here from the original issue as well. But with the {} escaping method, I still get a rejected connection.
My URL looks like this.
sqlserver://sqlserver;database=database;username=MyDomain{}Use;password={?}password{:}{!};trustServerCertificate=true
Is it correct to escape the backslash in the username as well?

@sweleck i can take a look later but I think we’re using an sql user not a domain one. If only I documented the link for the list of characters… 🤓

Hey,
I'm having the same issue, trying to connect to a database,
sqlserver://database.windows.net:1433;database=database;user=username;password=P@$ssword123;trustServerCertificate=true
but still getting an error.
I tried: password={P%40%24ssword123}, password=P{%40}{%24}ssword123 , password=P%40%24ssword123 and still doesn't work.

solved my case doing password={P@\$ssword123} I had to add \ to scape $ in the env variable in nextjs.


Notify websocket service on abnormal socket closure

This pull request fixed issue #60

Thanks for your PR! Before we review it, could you please sign the CLA? (link above).  Also, your PR seems to have failed CI, can you take a look?

Hi @ianpartridge,
I've fixed the CI build failure. While looking at it I found another issue. I've updated the issue #60 with same.
The CI build again failed due to a timeout issue.
This is the first time I'm submitting a PR to any opensource repository. Could you please help/guide me to fulfill the requirements for PR?
Thanks

@Andrew-Lees11  Did you get a change to review this PR?

Hello @bikram990
Sorry for the delay. I have been looking over this PR today. Firstly thank you for raising the issue and PR. You have caught some good bugs. There are currently two things with your PR I'm looking into:

You have added a test which is good. The test passes even without your changes though so It isn't covering your case
connectionClosed calls processor?.close(). This would cause a loop if you didn't set the processor as nil and I wanted to check if there is a better way to do this.

Could you expand on what is happening when you get your issue? Are you using master branch with a connection timeout or latest release? Have you tested this PR in your case and did it fix your issue?
Finally could you either rebase or merge your changes on master.
I apologize for all the question but I want to make sure I understand this change before I merge it.

> You have added a test which is good. The test passes even without your changes though so It isn't covering your problem case.

I've not added any new test case, I've modified the existing test cases. One issue with test case was that the connection was closed abnormally and it was expecting to get a noReason error code. Second issue with test case was specific to macOS. In Xocde the tests were giving false results even though test was failed. Third issue is related to timeout. The timeout issue may be because of network issues on the build server or no delay before closing the socket. I've not fixed the timeout issue But would like to have a fix for the same.

connectionClosed calls processor?.close(). This would cause a loop if you didn't set the processor as nil and I wanted to check if there is a better way to do this.

I just followed the same pattern used in Kitura-Net. Personally I would add a new delegate method for this. But for this PR I wanted to keep my modifications as minimum as possible.

Could you expand on what is happening when you get your issue? Are you using master branch with a connection timeout or latest release? Have you tested this PR in your case and did it fix your issue?

For my project, I'm using master branch without any timeout. The client for my server was killed forcefully and my server was never notified for the same. As my server was not notified, the server was still trying to send messages to client.

Thank you for your comprehensive response.
We have seen the timeout issue on travis before and I'm not to worried about that making it fail.
Looking at the code a agree that a delegate would probably be better but your solution will ensure that if the close function is called the service.disconnected should also be called.
 If the client never notifies the server then i'm not sure close will be called. Setting a connection timeout makes the server clean up connections that are not responding and should call service?.disconnected so your service is aware the client has gone.

@Andrew-Lees11  Yes, I've run my project with above changes and it works. Basically in Kitura-Net when a socket is open it creates a dispatch read source. This dispatch source gets a cancel message when ever a socket is closed abnormally. In implementation of cancel it closes the socket from server side and notifies its delegate (WebSocketProcessor) about close.
I agree a timeout will make the server clean up stale connections. But for timeout period server is using more resources that it should. The above change makes it event based.

Could you also add the following to the connection cleanup tests:
("testProccessorClose", testProccessorClose),

    func testProccessorClose() {
        let service = register(closeReason: .closedAbnormally, connectionTimeout: nil)

        performServerTest() { expectation in
            XCTAssertEqual(service.connections.count, 0, "Connections left on service at start of test")
            guard let socket = self.sendUpgradeRequest(toPath: self.servicePath, usingKey: self.secWebKey) else { return }
            let _ = self.checkUpgradeResponse(from: socket, forKey: self.secWebKey)
            usleep(1500)
            XCTAssertEqual(service.connections.count, 1, "Failed to create connection to service")
            let connections = Array(service.connections.values)
            connections[0].processor?.close()
            usleep(1500)
            XCTAssertEqual(service.connections.count, 0, "Service was not notified of connection disconnect")
            socket.close()
            usleep(150)
            expectation.fulfill()
        }
    }

@Andrew-Lees11 I've made the suggested changes. Could you please review?

I agree with the proposed fix.


theme rendring is complete via ‘hugo serve’ but incomplete via s3 hosting

Prior to posting this issue, I reached out to the hugo community (see this) for assistance.
I have since tried several other themes and have not had the issue with them - so it appears as if the theme itself has a bug which does not show when used via "hugo serve" ... I have not yet found the cause, but wanted to go ahead and report.

Any chance I can see a test/demo hosted on s3?


API slowness and frequent errors

The API has been slow and showing errors 500 for weeks.
This issue tracks the ongoing investigation, tuning, monitoring improvements.

rollback/forward of the API https://github.com/ooni/sysadmin/commit/5114618791b6607bbc3cfeacdb0b9b246eabea6a
Monitor API /version page https://github.com/ooni/sysadmin/commit/70ae721a788c3717aff8c42002ef69b360aa66a9
Increased gunicorn workers https://github.com/ooni/sysadmin/commit/f39b0c52dd9257f96f54a4059c804db6187971d6
improved grafana dashboards

A very simple disk latency test with ioping while WAL replication lags:
read:
HKG min/avg/max/mdev = 385 us / 695 us / 6.54 ms / 632 us
AMS min/avg/max/mdev = 393.9 us / 705.9 us / 1.81 ms / 437.6 us
LAPTOP min/avg/max/mdev = 220.2 us / 257.0 us / 491.4 us / 33.3 us
write:
HKG min/avg/max/mdev = 6.64 ms / 8.50 ms / 20.3 ms / 2.04 ms
AMS min/avg/max/mdev = 2.05 ms / 3.62 ms / 8.85 ms / 879.5 us
LAPTOP min/avg/max/mdev = 659.3 us / 2.01 ms / 12.3 ms / 2.84 ms

Ongoing work:

Decrease DB query load if needed: throttling, caching, blocking bots
Improve DB query monitoring
Investigate API slowness and DB issues
Deploy workarounds for slow networking between HKG and AMS: forwarding, compression

Fixed in https://github.com/ooni/backend/issues/437


Consider language-specific comment format in syntax highlighting

The generated syntax highlighting rules currently declare standard comments. We should adapt this to the actual comment format in the grammar, e.g. by looking at ML_COMMENT and SL_COMMENT rules.

Depends on #228.


feat: Add support for creating lambdas that use Container Images

Description
Resolves #79
Motivation and Context

AWS has recently announced support for container images
v3.19.0+ of the AWS Provider for terraform already supports it.

Breaking Changes
No breaking changes.
How Has This Been Tested?

Tested on a project that uses container image.
Tested the example added in this PR
Tested Plan & Apply. Works as expected.Terraform v0.13.5
+ provider registry.terraform.io/hashicorp/aws v3.19.0
+ provider registry.terraform.io/hashicorp/external v2.0.0
+ provider registry.terraform.io/hashicorp/local v2.0.0
+ provider registry.terraform.io/hashicorp/null v3.0.0
+ provider registry.terraform.io/hashicorp/random v3.0.0

Thank you! This one looks pretty good, I will take a deeper look into this during the next couple of days and finish it.

I have finished this and v1.31.0 has been just released.


Skype connection closes after long idle time

I'm start my bot and leave it for a whole night without any tasks in background. At the morning I see that it doesn't work anymore because connection with server was  lost. So at the morning my bot can't send or receive any message without restart.
Probably the issue is produced because OS or antivirus software kick it out on the timeout. But anyway, we are haven't such issue in Skype desktop client.

As per code active session is 24hours. If less then 30 minutes left client will be relogined.
I have same issue depends of energy saving of OS after some time without action. After waking up skype client stop working, also another rest client stop working. I think this issue depends on java connection with energy-saving parameter of OS (sleep, hibernate etc.)
Try to deactivate such activity of OS and try again.
OS: Win7

Well, I allready disable such parrameters. Anyway, it seems like Skype4J do not close connections itself. I guess issue can be closed.

As per code active session is 24hours. If less then 30 minutes left client will be relogined.

May be that is good idea to encapsulate such logic in library? I really don't want to think about low-level connection troubles when I implement some chatbot.

Welcome to skype :(


fixed empty network fields parsing as per #72

avoid parsing empty networks.
verify that each network field is defined before trying to parse it.

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


cm:set some log`s level from err to warning

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fill SRTrack::dir for ND-LAr tracks

The SRTrack::dir member was not being filled (dir was added after the last ND-LAr reco run).  This PR fixes that.
This update will only work with .h5 summary files produced using commit 4b6965f of dune-nd-lar-reco or later, which does not include the first round of CAFs produced for the LBL workshop

Tested on sample file and outputs look sane.  Merging.


Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

we can use localstack athena similar to the way dynamo db is tested.

we can use localstack athena similar to the way dynamo db is tested.

@sushi30 , I had checked the working of mocking athena with localstack and testcontainers. I found out that athena db operations comes under pro account/image. link


2.1-Preview 1: IsBindingRequired and IsRequired still false with RequiredAttribute on controller parameter.

Say I have to following controller:
[Route("My")]
public class MyController : ControllerBase
{
    [HttpGet]
    public void MyAction([Required] string queryParm)
    {

    }
}

And the following code:
var apiDescriptionsProvider = app.ApplicationServices.GetRequiredService<IApiDescriptionGroupCollectionProvider>();
var parameterDescription = apiDescriptionsProvider.ApiDescriptionGroups.Items.Single().Items.Single().ParameterDescriptions.Single();
var isBindingRequired = parameterDescription.ModelMetadata.IsBindingRequired;
var isRequired = parameterDescription.ModelMetadata.IsRequired;

I'd expect both isBindingRequired and isRequired to be true. Both are however false.
I also inspected ModelMetadata.MetadataKind which had a value of Type instead of Parameter which I expect is the underlying cause.
Am I doing something wrong, or is this a bug? When I call the API from my browser without supplying queryParm, the model state is invalid. So that part is going right.

Thanks for contacting us. @dougbu, can you please look into this?

@nphmuller are you seeing an issue with [Required] on an action parameter i.e. are ModelState errors added when the string parameter isn't provided? If yes, I can't reproduce the problem. Your application likely has additional customizations beyond what you've described. Does it for example use a custom IModelMetadataProvider?
If your issue is specifically with the IApiDescriptionGroupCollectionProvider results, I suspect the ApiDescriptionGroups will frequently be incomplete (in my test app, it's empty) and will rarely contain complete information about action parameters. Is this your issue?

I suspect the ApiDescriptionGroups will frequently be incomplete (in my test app, it's empty) and will rarely contain complete information about action parameters. Is this your issue?

Never mind this part. I forgot to opt into API Explorer for my controller. I can now reproduce your issue even though MVC will require a value for queryParm.
I suspect API Explorer needs to be made aware of the ModelMetadataProvider enhancements over what IModelMetadataProvider alone enables.
Separately,

I'd expect both isBindingRequired and isRequired to be true.

There's no [BindRequired] attribute in the code you provided. ModelMetadata.IsBindingRequired should be false.

Problem is at https://github.com/aspnet/Mvc/blob/3517ecda2f7eee421159d4e3206f937264f5b56b/src/Microsoft.AspNetCore.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs#L165
That code needs to handle the case where _modelMetadataProvider is a ModelMetadataProvider and use GetMetadataForParameter(...) then.

Should also check MVC for other places it calls IModelMetadataProvider.GetMetadataForType(...) where it may be dealing with an action or page handler parameter.

There's no [BindRequired] attribute in the code you provided. ModelMetadata.IsBindingRequired should be false.

Ah, sorry about that. Was still a bit confused about when IsBindingRequired is set to true. Guess it's easier than I though: it's only set when a BindingBehaviorAttribute is set with BindingBehavior.Required.
I'll update the example in my first post. Because even when [BindRequired] is set, isBindingRequired is still false.

@dougbu, I think you already have some fixes for this area. If this one, however, is self contained, feel free to reassign to @kichalla. Please also assign the cost, whoever will be handling it.

Reassigning because I did not experiment with my recommendations. On the other hand, I did a bit of the search for IModelMetadataProvider.GetMetadataForType(...) uses and suspect there be dragons -- though likely baby dragons (corner cases).
I would cost this as S but will leave it to @kichalla to make his own determination and assign the label.


Add an optional hook for logging requests and responses

to: @hcai @jasonkb

@aifreedom just rewrite the gems after I take over wechat-rails maintainer job from skinnyworm, so would you mind to port still missing change to current master? Ruby 1.9 is EOL, so is it possible to using 2.0 as base line in your side?

Interesting.
So we are adding wechat as a login method? What's the timeline like?

@hethune no, just let you known wechat-rails (now rename to wechat) welcome to PR.
if you want to add wechat as login provider, can reference omniauth-wechat


Axios feed not parsing

For some reason, the Axios RSS Feed: https://api.axios.com/feed/ does not parse in any shape or form anymore. It appears to be working on other RSS sites and apps without issues.

They are serving NewsBlur a 403 Forbidden, which means that are purposefully disabling NewsBlur. I suggest reaching out to them! I have emailed them to no avail. Please try again!


Missing how to get the initial-registration.yaml file on the Quickstart

https://elemental.docs.rancher.com/quickstart-cli#injecting-the-registration-information doesn't say how to get that file.

Actually, when you create the SeedImage and specify the MachineRegistration like this:

You don't have to include any file by yourself, the registration endpoint is already in.
To avoid confusion, maybe we could say: you need to prepare an Elemental Teal seed image that automatically includes the initial registration config, WDYT?

Ok I will push a PR to fix these:

Remove SeedImage if RPI
Explain what is the initial-registration.yaml

@e-minguez WDYT about https://github.com/rancher/elemental-docs/pull/104 please? is it clearer?

Much better now. Thanks!


Vault-webhook hooking kube-system apps

Hi, after one week using vault-secrets-webhook in our cluster, today we face a interesting problem:
We use GKE with some preemptive nodes and today we woke up with some tube-system pods in CrashLoopBack state, example: kube-dns and fluentd.
Analyzing logs we saw that even these pods are being modified by MutatorWebhook and they are trying to access Vault with an <IP_ADDRESS> URL (because the didn't have the annotation).
Question is: This is planned as this?
Every time I create a new node and ingress it in the cluster some pods who doesn't use the vault web hook are breaking
2019/02/21 16:57:15 Failed to request new Vault token Put https://<IP_ADDRESS>:8200/v1/auth/kubernetes/login: dial tcp <IP_ADDRESS>:8200: connect: connection refused
2019/02/21 16:57:20 Failed to request new Vault token Put https://<IP_ADDRESS>:8200/v1/auth/kubernetes/login: dial tcp <IP_ADDRESS>:8200: connect: connection refused

Hi @bruhsb, no this is absolutely not planned, could you please describe the version of the mutating-webhook and also how the env block of your pods look like?

Hey @bonifaido, we're using "vault-secrets-webhook-0.3.4" helm chart
This bellow is the mutated env spec of our fluentd pod (they're managed by GKE) and the original pod doesn't even has vault envs
    env:
    - name: POD_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.name
    - name: POD_NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    - name: VAULT_ADDR
    - name: VAULT_SKIP_VERIFY
    - name: VAULT_PATH
      value: kubernetes
    - name: VAULT_ROLE
      value: default
``

And what the image version inside the chart deployment?

@bonifaido we're using the value default of chart, "latest". Now looking in the dockerhub we saw that yesterday was released a 0.4.9 version. We staticly rollbacked to 0.4.8 version from 13 days ago and the problem was solved.
Any crucial modifications in the version from yesterday?

Yes, this was refactored, please use the previous version than, and let's keep this issue open for the bug fix! Thank you for reporting this!

https://github.com/banzaicloud/bank-vaults/pull/338 has been pushed to handle this issue!


This is my turtle post

Don't merge this yet, I still want to add more reflection.

Roger that.  Nice work so far.  I dig the comments in your turtlehack

Alright, finished reflecting. @eah13 Please pull when you get a chance.
:+1:

@eah13 I fixed it. Apparently, apostrophes and backticks are not the same....
:confused:

:bear: is the closest emoji to wookie


RPC socket received error

Hi,
I try to run cross_compilation_and_rpc.py sample on arm device, but the RPC error happens, do someone meet this issue?
python3 cross_compilation_and_rpc.py
[03:55:56] /home/shiqin.lsq/tvm/src/runtime/opencl/opencl_device_api.cc:257: Initialize OpenCL platform 'NVIDIA CUDA'
[03:55:56] /home/shiqin.lsq/tvm/src/runtime/opencl/opencl_device_api.cc:288: opencl(0)='GeForce GTX 1080' cl_device_id=0x27b4a20
Traceback (most recent call last):
File "cross_compilation_and_rpc.py", line 253, in
run_opencl()
File "cross_compilation_and_rpc.py", line 223, in run_opencl
remote = rpc.connect(opencl_device_host, opencl_device_port, key)
File "/home/tvm/python/tvm/rpc/client.py", line 366, in connect
sess = base._Connect(url, port, key)
File "/home/tvm/python/tvm/_ffi/function.py", line 280, in my_api_func
return flocal(*args)
File "/home/tvm/python/tvm/_ffi/_ctypes/function.py", line 184, in call
ctypes.byref(ret_val), ctypes.byref(ret_tcode)))
File "/home/tvm/python/tvm/_ffi/base.py", line 66, in check_call
raise TVMError(py_str(_LIB.TVMGetLastError()))
tvm._ffi.base.TVMError: [03:55:56] /home/tvm/src/runtime/rpc/rpc_socket_impl.cc:58: Check failed: sock.RecvAll(&code, sizeof(code)) == sizeof(code) (0 vs. 4)

Thanks for reporting this, please open a new thread at https://discuss.tvm.ai/


test(k8s): add tests for the k8s package

to improve coverage

Current coverage is 46.14% (diff: 100%)

Merging #237 into master will increase coverage by 0.54%

@@             master       #237   diff @@
==========================================
  Files            65         65
  Lines          1467       1467
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            669        677     +8
+ Misses          716        708     -8
  Partials         82         82

Powered by Codecov. Last update db38b7f...0feab28


SVG is not courtly displayed some Windows & Android Phones

Adding PNG?

replaced with PNG because it caused to much trouble


add second vaultwarden backup

encrypted zip file of plaintext dump?  or one of the dockers in the vaultwarden backup wiki (at bottom)

https://hub.docker.com/r/bruceforce/vaultwarden-backup


Add: ODBC driver 17 issue with openssl on macos

While using ODBC driver 17 on MacOS, I get the following error. After googling around, multiple people had the same error (https://github.com/mkleehammer/pyodbc/issues/967), only the solution they used wasn't generic on MacOS (different openssl symlink names). Therefore I have provided a generic solution in the known issues.

@martenvd : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Dockerfile does not create image

Hello community,
I got a problem building an image from the Dockerfile and from https://github.com/Pro/UA-ModelCompiler/blob/master/Dockerfile:
Error:
  It was not possible to find any installed dotnet SDKs
  Did you mean to run dotnet SDK commands? Please install dotnet SDK from:
      https://aka.ms/dotnet-download

...

Done Building Project "/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj" (Build target(s)).
Done Building Project "/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj" (default targets) -- FAILED.
Done Building Project "/tmp/app-build/ModelCompiler Solution.sln" (Restore;Build target(s)) -- FAILED.

Build FAILED.

"/tmp/app-build/ModelCompiler Solution.sln" (Restore;Build target) (1) ->
"/tmp/app-build/ModelCompiler/UA Model Compiler.csproj" (default target) (2:6) ->
"/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj" (default target) (3:16) ->
(CoreCompile target) ->
  Stack/Https/HttpsTransportChannel.cs(98,29): error CS1061: 'HttpClientHandler' does not contain a definition for 'ClientCertificates' and no accessible extension method 'ClientCertificates' accepting a first argument of type 'HttpClientHandler' could be found (are you missing a using directive or an assembly reference?) [/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj]
  Stack/Https/HttpsTransportChannel.cs(107,33): error CS1061: 'HttpClientHandler' does not contain a definition for 'ServerCertificateCustomValidationCallback' and no accessible extension method 'ServerCertificateCustomValidationCallback' accepting a first argument of type 'HttpClientHandler' could be found (are you missing a using directive or an assembly reference?) [/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj]
  Stack/Https/HttpsTransportChannel.cs(126,33): error CS1061: 'HttpClientHandler' does not contain a definition for 'ServerCertificateCustomValidationCallback' and no accessible extension method 'ServerCertificateCustomValidationCallback' accepting a first argument of type 'HttpClientHandler' could be found (are you missing a using directive or an assembly reference?) [/tmp/app-build/Stack/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj]

    0 Warning(s)
    3 Error(s)

...

Actually I do not know what is missing since I thought the existing image sailavid/ua-modelcompiler was built by the dockerfile.
What is wrong?
Reproduce:
docker build -t <image_name> .

I tried to reproduce.
Using Pro's repository yields the errors you showed. The repo is 33 commits behind master and the submodule is the UA.NetStandard-Stack, which changed so much that the build breaks. That's likely, because the errors show up in the Stack directory.
I pulled this repo here and it builds successfully with
docker build -t <image_name> .
Hope that helps.

Yes, you are totally right. Thanks for your help


HBASE-19386 HBase UnsafeAvailChecker returns false on Arm64

On Arm64, java.nio.Bits.unaligned() wrongly returns false due to a JDK bug.
This causes HBase UnsafeAvailChecker wrongly returning false on Arm64.
And it slso cause FuzzyRowFilter Unit test failed.
Fix it by providing a hard-code to enbale Arm64 unaligned support.
Jira: HBASE-19386
Change-Id: I3ab821dacbe42b18cd515080da1fa3dc1f1e1d28
Signed-off-by: Yuqi Gu<EMAIL_ADDRESS>

This PR is slated to be closed as a part of HBASE-20391 because the referenced JIRA has since closed.
If this is incorrect and you are still interested in working on the issue please comment there and/or reopen the PR.


Host benchmark files on Zenodo

(also addresses #42)
As per Charles' suggestion, we should move the benchmark files to Zenodo. Zenodo allows for more transparent versioning and long-term availability of files.
I have created a community called 'Biomedical link prediction' on Zenodo. @nomisto Please upload the latest versions of the OpenBioLink Benchmark files (including the RDF files) via https://zenodo.org/deposit/new?c=biomedical_link_prediction
and update the link on the GitHub Readme accordingly. Thanks!

The files are now hosted on https://zenodo.org/record/3826919. Please verify if I filled out the metadata correctly and let me know if you want to change anyhing.

Looking good, thanks!


Menu Display Issue: Hamburger Icon visible and MENU button also visible at a time

Current State of the Meshery.io site
Hamburger Icon visible and MENU button also visible at a time in mobile view

Desired State of the Meshery.io site
Only the Hamburger icon must be visible in mobile view and MENU button must be invisible

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hi Shaik,
Good day!
Not sure if you have already resolved this issue, but here is some information  that might be helpful.
Cheers,
Randy

Hi Shaik,
Good day!
Not sure if you have already resolved this issue, but here is some information  that might be helpful.
Cheers,
Randy

Great, I'm new to this, just give me clarity, shall I solve this issue or close it.

Hi Shaik,
Apologies, I am also very new to this, and did not mean to cause any confusion. I just wanted to share the information with whomever was assigned the issue.
Please continue solving the issue and sorry again for any confusion caused.
Cheers,
Randy

Hi Shaik,
Apologies, I am also very new to this, and did not mean to cause any confusion. I just wanted to share the information with whomever was assigned the issue.
Please continue solving the issue and sorry again for any confusion caused.
Cheers,
Randy

Sorry for the misunderstanding, I think you are trying to help me, now I got the point, thanks for sharing the resource, definitely I will take it as a reference you shared.
Thank you 😊

In my localhost it is absolutely fine, but why both Icon and MENU text are visible in meshery.io, reply please @Chadha93 @randychilau

Thanks a lot @randychilau, with the help of you I did it ❤

Hi Shaik,
Congratulations on your submission, nice work!
One small thing you want to consider is that the code should also load the stellarnav file when the jekyll.environment is "development" (e.g. an else option) since that is the default environment for folks like yourself making changes to the code.
If there is no accommodation for the jekyll.environment being "development", then the stellarnav file will not load and the hamburger menu will not appear when they load the site in the browser.
One way to check that your fix is showing up in both environments is to:

load your changes in the development environment using the command make site

and then

load your changes in the production environment using the command JEKYLL_ENV=production bundle exec jekyll build

and your changes to the hamburger menu should appear in both.
Hope that helps!
Cheers,
Randy

Check the PR once @randychilau, is everything okay now

Hi Shaik,
Thanks for your message.
I took a look at the PR and checked the updated preview, nice job!
It looks like it is handling both environments now, and it is showing up in the preview now:

I think the reason it wasn't showing in the preview before is because it seems the netlify deploy preview also uses "development" environment (since it does not specify "production" environment), at least that is what is seems like from the processing logs:

Anyway, looks good!
Cheers,
Randy

Thanks @randychilau, for guiding in this entire process, by the how you are familiar with all this stuff, I am MERN stack developer, that's I struggling with Jekyll.

HI Shaik,
Glad to help and congrats again on your PR!
Hopefully they will review it again soon with the recent updates and give you more feedback.
Hah, every day on this coding journey is a "struggle" / "challenge" / "learning experience" / "opportunity", so it can nice to collaborate with others along the way (I am still learning that).
Cheers,
Randy

Hoping that they will review it again and this is my first open source contribution if they merged, by the can we connect? Eg: LinkedIn or Twitter

Hi Shaik,
One option might be to add a comment on the PR that you have updated the code and include a screenshot of the deploy preview link in mobile mode showing the hamburger menu.
Also thanks for asking to connect, I am still rebuilding my LinkedIn, but will be happy to connect when it is done. I am on the Layer5 slack, I will send you a wave!
Cheers,
Randy

Hi Shaik,
Nice, it is good to get comments and feedback on your work, everyone is helping each other on this coding journey.
Let's take a look at each of the comments:

while clicking on hamburger icon the complete box shouldn't be blue.

Since you are already working on the feature, you are being asked to make additional changes not included in the original issue which is good since it is an opportunity to work on more stuff and learn more. Plus as stated:

these changes are required for better experience

Note sure if you have already handled this, but seems like you can modify the stellarnav CSS files in the appropriate section to style the dropdown.
css/stellarnav.css
It sounds like they are letting you choose how to style it, so one option may be to choose a similar color to the mobile site background, but enough difference for the dropdown menu stand out.

when the dropdown menu is open we should display a cross icon instead of hamburger icon with some animation. you can see https://layer5.io/ for reference.

This will require more work, as you will have to find the portions of code and css in the layer5.io site to copy the open/close effect of the hamburger menu icon, and then put them into the appropriate files. You should be able to find what you need in this folder:
layer5/src/sections/General/Navigation
If you feel like this is a separate task that requires a lot of time and work, maybe you can ask them to do this task as a separate PR?

regarding this comment, I couldn't find a place where the min.js version of the file is being autogenerated, but I am still a beginner.
What you can do is after you update the stellarnav js file to your liking, you can convert the code to minified versions using online tools (e.g. https://www.toptal.com/developers/javascript-minifier) and then update the min.js file. Then you can update the if/else statement to use the minified version for production (since it saves on loading time as smaller files).

Cheers,
Randy

Hi Shaik,
Nice, it is good to get comments and feedback on your work, everyone is helping each other on this coding journey.
Let's take a look at each of the comments:

while clicking on hamburger icon the complete box shouldn't be blue.

Since you are already working on the feature, you are being asked to make additional changes not included in the original issue which is good since it is an opportunity to work on more stuff and learn more. Plus as stated:

these changes are required for better experience

Note sure if you have already handled this, but seems like you can modify the stellarnav CSS files in the appropriate section to style the dropdown.
css/stellarnav.css
It sounds like they are letting you choose how to style it, so one option may be to choose a similar color to the mobile site background, but enough difference for the dropdown menu stand out.

when the dropdown menu is open we should display a cross icon instead of hamburger icon with some animation. you can see https://layer5.io/ for reference.

This will require more work, as you will have to find the portions of code and css in the layer5.io site to copy the open/close effect of the hamburger menu icon, and then put them into the appropriate files. You should be able to find what you need in this folder:
layer5/src/sections/General/Navigation
If you feel like this is a separate task that requires a lot of time and work, maybe you can ask them to do this task as a separate PR?

regarding this comment, I couldn't find a place where the min.js version of the file is being autogenerated, but I am still a beginner.
What you can do is after you update the stellarnav js file to your liking, you can convert the code to minified versions using online tools (e.g. https://www.toptal.com/developers/javascript-minifier) and then update the min.js file. Then you can update the if/else statement to use the minified version for production (since it saves on loading time as smaller files).

Cheers,
Randy

Okay, I will work on this based on your suggestions, Thank you Randy 😊

Hi Shaik,
Good luck!
Also, regarding the hamburger menu animation, there are many different solutions available online:
example 1
example 2
so while one method may be to try replicating the code used on Layer5.io, feel free to explore and research other methods that you may like better for the Meshery.io codebase.
Cheers,
Randy

Hi Shaik,
Good luck!
Also, regarding the hamburger menu animation, there are many different solutions available online:
example 1 example 2
so while one method may be to try replicating the code used on Layer5.io, feel free to explore and research other methods that you may like better for the Meshery.io codebase.
Cheers, Randy

Okay @randychilau, thanks for sharing the references 👍

@karangit @vishalvivekm @HarshDobariya79 , This issue has been completed in PR #1130 . We can close this now

@KaranGit @vishalvivekm @HarshDobariya79 , This issue has been completed in PR #1130 . We can close this now

Closing this since it's already fixed in #1130


Xgcm and ecco

Hey @rabernat, I added a little blurb about how xgcm is used within eccov4-py, or really how it helps with ecco output in general. Let me know if you'd like any changes.
As for eye candy figures, I would vote for a figure from your work with @jbusecke on mesoscale mixing. Or, perhaps something from the ECCOv4 example on the xgcm tutorials - e.g. the convergence of advective fluxes.

Thanks Tim!


Ruby Issue?

Apologies, as i'm a bit new to this. But from what I understand the error I am getting below is fixed by using a different ruby version.
I used rbenv global 2.6.6

But it seems to be the issue that others were having with Ruby. If anyone could point me in the right direction, I would be very thankful

Was able to use rbenv shell 2.6.6 to success


CV25519 support is broken

I tried using my ledger for secure gpg key storage. And short and simple this app is just too buggy. Especially if "secure" is the goal. Now the details
I tried generating ed25519/cv25519 keys on the ledger (refusing the default option of a backup). This results in 2 working ed25519 keys for signatures and authentication on the "card" but the decryption key which should be a CV25519 key. Simply doesnt work. The ledger asks for the pin and all but it fails.
in the logs one sees:
operation decipher result: Card error
app_decipher failed: Card error
DBG: chan_7 -> ERR 100663404 Card error <SCD>

Then one tries this again and picks the default like probably most people do, "do the whatever backup". And that works with ed/cv25519 keys or does it? It sure looks like its working signing is perfectly fine it asks for the pin and all same as without the backup but then with decryption it works a little too well. It doesnt ask for the pin, it doesnt even need the ledger to be connected. And it keeps working if one kills all agents and caches. Yes the unencrypted private key seems simply left on the disk silently after asking the user for a password to encrypt a copy of it. And it works not all with the ledger but with the key on disk.
I want to be wrong.
Ohh and btw RSA4096 keys do seem to work for encryption. Iam just not sure how much i trust anything from this app anymore.
I tried this with
gpg (GnuPG) 2.2.19
libgcrypt 1.8.5

and
gnupg2 (2.2.41), gnutls28 (3.7.3), gpgme1.0 (1.17.0), libassuan (2.5.5), libgcrypt20 (1.8.9)

The versions didnt make a difference

Can confirm on
gpg (GnuPG) 2.3.7
libgcrypt 1.10.1-unknown
scdaemon log: https://pastebin.com/Wpy5Ahk5
gpg-agent log: https://pastebin.com/wDk3QRUK
Note lines from scdaemon log
2023-03-21 01:00:27 scdaemon[2623] DBG:  response: sw=6F42  datalen=4
2023-03-21 01:00:27 scdaemon[2623] operation decipher result: Card error
2023-03-21 01:00:27 scdaemon[2623] app_decipher failed: Card error

I spent the whole afternoon debugging and found out it was a bug.

Yup I can confirm the bug as well

@cedelavergne-ledger any plans on fixing this bug on Open GPG applet ? 🙂

@cedelavergne-ledger any plans on fixing this bug on Open GPG applet ? 🙂

It is not in the short term plans... I need to double check internally.

I feel this should be a pretty high priority bug to fix: not being able to use ed25519/cv25519 keys for encryption/decryption is the main purpose of GPG.

It is possible to use an other type of algorithm, for the encryption/decryption key? I tried to use nistp256 but is the same problem.
Key attributes ...: ed25519 nistp256 ed25519

While trying to decrypt I get the following:
gpg: public key decryption failed: Conditions of use not satisfied
gpg: decryption failed: No secret key


Process getting killed when using json_loads

Hi,
I have an embedded device in which I have trying to read a data from a file and convert it into JSON object using json_loads.
file_str="Read data from a file";
json_t* file_read = json_loads(file_str, 0, NULL);
json_object_clear(file_read);
I am clearing the json object but still the process gets killed automatically after a while with an error saying "segmentation error(core dumped)".Can someone tell what the issue is here. ?

Can you share a stack trace of core?

If you use json_object_get() before json_object_clear(), then use the thing you got out of the object after the clear, that is invalid and would cause a segfault. If you will keep a reference to the thing after clearing the object, you should use json_incref() on it.


Checking results status in Python

Thanks for releasing Clarabel! As I was trying it out in Python, I noticed something confusing about the status of a result: currently it can be both == and != to Solved at the same time.
Here is a small example, following: https://oxfordcontrol.github.io/ClarabelDocs/stable/python/getting_started_py/
    solver = clarabel.DefaultSolver(P, q, A, b, cones, settings)
    result = solver.solve()
    print(type(result.status))
    print(result.status == clarabel.SolverStatus.Solved)
    print(result.status != clarabel.SolverStatus.Solved)
    print(result.status is clarabel.SolverStatus.Solved)  # to check the underlying references

The output on my machine is:
<class 'builtins.SolverStatus'>
True
True
False

Clarabel was installed from PyPI. Version:
>>> import clarabel
>>> clarabel.__version__
<built-in function __version__>  # a bit confusing, __version__ is usually a string in Python
>>> clarabel.__version__()
'0.3.0'

I think that the issue is the same as the one described here:  https://github.com/PyO3/pyo3/issues/2618
A made a fix #11 by bumping the Py03 version, which seems to solve the problem for me locally.   We will merge this and distribute update binaries as part of v0.4, which should be coming soon.

Okay :ok_hand: In the meantime for fellow Python travelers, a temporary workaround can be something like:
    #if result.status != clarabel.SolverStatus.Solved:
    # Hack to go around https://github.com/oxfordcontrol/Clarabel.rs/issues/10
    if str(result.status) != "Solved":

Looking forward to v0.4 :eyes:


PyPI doesn't know about python 3 support

PyPI doesn't seem to know that requests supports Python 3 (3.3, 3.4, & 3.5!).  As a result, caniusepython3 thinks requests is a Python 3 blocker and requests is in red on the Python 3 Wall of Superpowers.
Requests is awesome and it should get the credit it deserves.

Annoyingly, our trove classifiers appear to have disappeared again. I've re-uploaded them. Thanks!


Stabilize and cleanup system tests with eventually.

Summary:
This is a small follow up that replaces a few retrying blocks with the
new eventually matcher. It also introduces has_len to match the
length of a sequence.

Open system tests pass.

Strict fails only with test_marathon_root.test_private_repository_docker_app which is know to be broken.


Double Sided Block Rendering

As I gathered all the information on the json block definition options a stumbled upon the double sided property, and I was wondering how it is supposed to work.
I think its used for billboard plants atm and tried using it for glass.
In these screens you can see the result. The green glass has "doubleSided" : false and works as expected, culling is done and only the front is visible.

The red one uses "doubleSided" : true and the faces drawn changes from for every block, somehow depending the previous attached blocks.

The first version is how I expect it to be (all faces drawn),  and these are some other (random) results.

Is this a real rendering issue, @begla, or is the double sided option only designed to billboard plants?

Cannot reproduce this anymore:


Simple question about LightGBM PredictContrib

Hello there!
LightGBM::GBDT::PredictContrib(const double* features, double* output)
1)Does this method calculates "true" shap_values which are deltas from model expected value on whole dataset?
OR
2)I have to substract beforehand calculated expected_value from each output for every sample row ?

The answer is (1). Just remember the expected value is with respect to the margin.

@slundberg Thank you.
Ok. But here it comes another question.
Is it correct to use LightGBM(or others) TreeSHAP routine to calculate shap_values on TEST dataset.
Let's look at the LightGBM::Tree::TreeSHAP code:

const double w = data_count(node);
const double hot_zero_fraction = data_count(hot_index) / w;
const double cold_zero_fraction = data_count(cold_index) / w;

data_count() is a leaf or node weight obtaining as result of learning on TRAIN data.
So if we provide 'const double *feature_values' from TEST dataset then as a result we get shap_values 'deltas' from TRAIN_data_expected_value (not TEST_data_expected_value).
Summarize. How calculate shap_values on TEST data in a proper way?
PS i'm not using python. But LightGBM source code directly.

Typically we use the training dataset to represent the background distribution of the data, even when explaining test samples. This means the training dataset gives us our prior about how the data behaves when we don't know things about the current test sample. You could use the test dataset, but sometimes you don't yet have a large test dataset. Also, since your model was built using the training data I think it makes the most sense to use that training data for modeling the expected outcomes when you don't know the value of a feature on a test sample (used when we hold features out during the computation of SHAP values).


#CleanCode What about TheWelcome.vue, WelcomeItem.vue, and HelloWorld.vue?

@echo75 Do you use the TheWelcome.vue, WelcomeItem.vue, and HelloWorld.vue?

@echo75 for example afterwards like this: Close this ticket with cleanup f30aba411ecb9c5c91c1d91b6075b0240a24ea96 😄


Importing assets from templates

Hi @SudoCat . It's me again (yeah still using this loader :D ) Is there a way to use import statements or anything parsed by other webpack loaders ? (like, for example the url (asset.png) in css)
I tried the following with no success:
{% import '../images/app/favicon.png' as favicon %}

with the following error message:
Error: /project/path/node_modules/nunjucks/browser/nunjucks-slim.js?:955
                      if(err) { throw err; }
                                ^
  Template render error: (orbital.njk)
    Template render error: (orbital.njk)
    TypeError: path.dirname is not a function

  - nunjucks-slim.js?:183 Object.exports.prettifyError
    [.]/[nunjucks]/browser/nunjucks-slim.js?:183:16

  - nunjucks-slim.js?:943 eval
    [.]/[nunjucks]/browser/nunjucks-slim.js?:943:32

  - loader.js:120 new_cls.root [as rootRenderFunc]
    [orbital.njk?.]/[html-webpack-plugin]/lib/loader.js:120:3

  - nunjucks-slim.js?:936 new_cls.render
    [.]/[nunjucks]/browser/nunjucks-slim.js?:936:16

  - nunjucks-slim.js?:767 eval
    [.]/[nunjucks]/browser/nunjucks-slim.js?:767:36

  - nunjucks-slim.js?:689 createTemplate
    [.]/[nunjucks]/browser/nunjucks-slim.js?:689:26

  - nunjucks-slim.js?:704 handle
    [.]/[nunjucks]/browser/nunjucks-slim.js?:704:26

  - nunjucks-slim.js?:718 eval
    [.]/[nunjucks]/browser/nunjucks-slim.js?:718:22

  - nunjucks-slim.js?:356 next
    [.]/[nunjucks]/browser/nunjucks-slim.js?:356:14

  - nunjucks-slim.js?:363  Will try to take the time to read the docs about writing loaders so I could help you support this one!

Hey there.
I'm really sorry, but I actually have no idea 😖 I've never actually used image loaders or anything similar to really know how they work. I'll probably need to have a look through some other templating language loaders and see what they're doing.
I imagine that part of the problem is how sketchy this nunjucks loader actually is. Unfortunately, nunjucks really is not tailored towards being turned into a loader; I've had to do a whole lot of work arounds to get this working. It's possible that because of this webpack is failing to find the potential dependencies within the templates.
I've got quite a busy work day today, so I doubt I'll get a chance to look into this until later this evening. If you're interested in trying to solve it, that'd be amazing. I'd be happy to support you if you have any questions about the code or if there are any other ways I can help!

Thank you very much! I'll throw myself into the Webpack docs and hopefully will be able to help you out with this.
Have a nice day!

Awesome, good luck! :D

Hiya, I think I know how to do this (thanks to the docs) but first, can you explain a bit how's the code working?
In fact, I only use it with the HtmlWebpackPlugin so, for now, I only test this context but if you tell me more about the loader, I'll be more prepared to start coding this feature. (Sorry, I'm quite new to Webpack but I'm motivated :D )
Thanks in advance!

Sure thing! Right, so the code I have written only handles the HtmlWebpackPlugin situation. If you're targetting web, then it instead loads the other package, nunjucks-loader - this should mean that we don't need to worry about maintaining the functionality used for web builds.
Now then, as for what my code actually does. It's been some time since I wrote this, so apologies if I'm a little shaky it on it. It's a little convoluted due to some of the requirements of loaders and Nunjucks, Nunjucks really did not want to be used like this, so there's been quite a lot of workarounds to glue this all together.
To understand the loader, first you need to understand the requirements, and the issues.
In order for HtmlWebpackPlugin to be able to pass data to the templates, the loader needs to return a module which exports a render function. This render function would then take the data passed to it, and compile the the template into a text string, with the data inserted into the right place. This is the requirement for our loader.
Unfortunately, that's not so easy in Nunjucks. Other templating languages, such as EJS and Pug, have very simple functionality, and require no knowledge of the current context in order to compile. This means they can both use very simplified portable compile functions to return the string. Nunjucks, on the other hand, has support for things like extends (which is the main reason I love it!). This means that Nunjucks needs a whoooole lot more information to be able to compile its templates.
Luckily, Nunjucks has a partial solution to this; precompiled templates. Nunjucks allows you to "precompile" the templates, essentially working out all of the complicated bits first, then outputting a simplified version of the templates for real-time compilation at a later point. This is how Nunjucks is usually used for web.
In order to precompile the templates, you need to use the nunjucks node environment loader (https://github.com/mozilla/nunjucks/blob/master/src/node-loaders.js). However, when I tried use this inside of a webpack loader, I encountered a host of recursive dependency errors. This turned out to be because of the require statement on line 35 of the nunjucks node loader.
Because of this, I decided to clone the node-loader, and remove the undesirable code which was creating the problems. The result is the fs-loader.js (https://github.com/SudoCat/Nunjucks-Isomorphic-Loader/blob/master/src/fs-loader.js). This creates a loader suitable for precompiling templates from within a webpack loader. You can see this being used when creating the nunjucks environment at https://github.com/SudoCat/Nunjucks-Isomorphic-Loader/blob/master/src/node-loader.js#L46
The next problem I encountered was how precompiled templates work. They are intended to be used live on the front end of a website, compiling them with javascript when needed. Because of this, all of the precompiled templates get automatically stored in the global window object... which doesn't exist in node. This meant I needed to create a fake window object for nunjucks to store the templates in. This is what you see at https://github.com/SudoCat/Nunjucks-Isomorphic-Loader/blob/master/src/node-loader.js#L64
With the precompiled templates safely stored in the loader's export module, the module then creates a new nunjucks slim environment. This provides us with the function we need to finalise the compilation, which gets done at https://github.com/SudoCat/Nunjucks-Isomorphic-Loader/blob/master/src/node-loader.js#L74
Hopefully this makes sense. Please let me know if there's anything you want me to clarify!
In short the loader:

Generates precompiled nunjucks templates
Returns a function for HtmlWebpackPlugin to use to compile the precompiled templates.

Wow, thank you very much for taking the time to explain this to me! Will read this and start coding this weekend. Oh time, if only we could get more of that stuff :')

That's no problem, I should probably have it written down anyway, just so I don't forget 😆
Haha, you can say that again!

So, I gave this a try and for now I'm stuck with paths from HtmlWebpackPlugin. I chose the following syntax as it is valid nunjucks: {{ require('./asset.jpg') }} considering require as a macro.
In the loader, at line 50 I just changed this:
        this.addContextDependency(paths[0]);

        // get the template content
	var templateContent = fs.readFileSync(name, { encoding: 'utf8' });

	// Search for require macros and require assets
	templateAsString = templateContent.replace(
		/\{\{\s*require\([\'\"]{1}(.+)[\'\"]{1}\)\s*\}\}/,
		function (match, $1) {
			console.log('require(' + utils.stringifyRequest(this, utils.urlToRequest(path.relative(paths[0], $1))) + ');');
			return eval('require(' + utils.stringifyRequest(this, utils.urlToRequest(path.relative(paths[0], $1))) + ');');
		}
	);

	var precompiledTemplates = nunjucks.precompileString(templateAsString, {
		name: name,
		env: env,
		include: [/.*\.(njk|nunjucks|html|tpl|tmpl)$/]
	});

So basically, I just changed the nunjucks.precompile to nunjucks.precompileString and tried to update the require macros by the actual asset paths.
Here's the error I get
ERROR in ./node_modules/html-webpack-plugin/lib/loader.js!./test.njk
    Module build failed: Error: Cannot find module './asset.jpg'
        at Function.Module._resolveFilename (module.js:513:15)
        at Function.Module._load (module.js:463:25)
        at Module.require (module.js:556:17)
        at require (internal/module.js:11:18)
        at eval (eval at <anonymous> (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:60:11), <anonymous>:1:1)
        at /Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:60:11
        at String.replace (<anonymous>)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:55:37)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/index.js:16:44)

I'm not sure about how to generate the right require path and I'm stuck with it. I think, this could work outside of the HtmlWebpackPlugin but didn't tried it out.
I'll try to check this out again next week but for now, if you have any advice, let me know :)

Well, my bad. Here's the right way to require the needed asset:
// Search for require macros
templateAsString = templateContent.replace(
	/\{\{\s*require\([\'\"]{1}(.+)[\'\"]{1}\)\s*\}\}/,
	function (match, $1) {
		console.log(path.resolve(paths[0], $1));
		// return 'dum'
		return require(path.resolve(paths[0], $1));
	}
);

This gets the right path to the wanted asset but I still got a problem as it seems the file-loader isn't called in this context. I have the following in my tests webpack config:
// Images
{
  test: /\.(jpe*g|png)/,
  use: [
    {
      loader: 'file-loader',
      options: {
         name: '[path][hash:8].[ext]'
      }
    }
  ]
}

And get the following error (looks like it tries to load the binary as a JS module):
ERROR in ./node_modules/html-webpack-plugin/lib/loader.js!./test.njk
    Module build failed: /Users/gomoon/Documents/workspace/Sandbox/nunjucks-tests/asset.jpg:1
    (function (exports, require, module, __filename, __dirname) { ����
                                                                  ^

    SyntaxError: Invalid or unexpected token
        at createScript (vm.js:80:10)
        at Object.runInThisContext (vm.js:139:10)
        at Module._compile (module.js:576:28)
        at Object.Module._extensions..js (module.js:623:10)
        at Module.load (module.js:531:32)
        at tryModuleLoad (module.js:494:12)
        at Function.Module._load (module.js:486:3)
        at Module.require (module.js:556:17)
        at require (internal/module.js:11:18)
        at /Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:61:11
        at String.replace (<anonymous>)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:56:37)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/index.js:16:44)

So now I get the asset but it's not loader by the file-loader. I also tried this.resolve instead of require but got this error:
ERROR in ./node_modules/html-webpack-plugin/lib/loader.js!./test.njk
    Module build failed: TypeError: Cannot read property 'missing' of undefined
        at Resolver.resolve (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-tests/node_modules/enhanced-resolve/lib/Resolver.js:83:31)
        at Object.resolve (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-tests/node_modules/webpack/lib/NormalModule.js:133:14)
        at /Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:62:16
        at String.replace (<anonymous>)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/src/node-loader.js:57:37)
        at Object.module.exports (/Users/gomoon/Documents/workspace/Sandbox/nunjucks-isomorphic-loader/index.js:16:44)

The issue should really be about using nunjucks import functionality. I have the same error while trying to import macro from one .njk file into another: {% import './path/to/macro.njk' as macro %}

Okay, I found the source of the error form this issue. You can't use a relative path inside nunjucks imports (probably a related bug in nunjucks repo). Instead you need to use an absolute path relative to query.root path from the loader options.
The other problem though is that webpack doesn't watch changes in these imported assets (probably because they are not in a "webpack land"/not handled by webpack require statements). But this is another issue


[RFC] middleware for encrypted cookies

Is anyone aware of goji compatible middleware that allows user to set encrypted cookies (possibly using securecookie)?
If not, I'd like to create one. One approach would be to set a known key in the web.C.Env map (maybe "Cookies") which is itself a map[string]string (as described in the securecookie examples). This middleware would assume it gets called early enough so that it can peek into the cookie and populate the map before calling downstream handlers, and eventually serialize (and encrypt) the cookie map into the cookie. Thoughts?

I am working on an auth package with middleware helpers - i.e.
admin.Use(store.RequireAuth) that leverages securecookie and it should be
done Very Soon (tm).
Beyond that - if you're looking for a more general cookie store, I would
leverage gorilla/sessions.
On Wed, May 6, 2015 at 5:34 AM Akshay Moghe<EMAIL_ADDRESS>wrote:

Is anyone aware of goji compatible middleware that allows user to set
encrypted cookies (possibly using securecookie
http://www.gorillatoolkit.org/pkg/securecookie)?
—
Reply to this email directly or view it on GitHub
https://github.com/zenazn/goji/issues/125.

I am working on an auth package with middleware helpers

Thats cool! Could you point me to the repo (assuming its public) so I could take a look at what kinds of middleware you are planning?

if you're looking for a more general cookie store, I would leverage gorilla/sessions

Yes, I considered gorilla/sessions , but it maintains global state to achieve its goal. In a goji-like framework, we should be able to use web.C and completely avoid global state (which is how I started thinking about this).

Repo not public (yet). Hopefully next week though! Just want to lock down
the API before people start go getting it too quickly. The public API is
pretty small though: Provide (makes the store available in the context),
RequireAuth/RequireAdmin (parse for valid values, bounce to an ErrorHandler
on failure), Logout (expires the cookie + token). There are also SetUser
and GetUser functions that facilitate saving and getting a User (an
interface with a couple of simple GetID and IsAdmin methods) as to make it
fairly flexible to plug into an existing app.
Otherwise RE: gorilla/sessions global state - yes, it's a problem*. I
looked at forking gorilla/sessions to strip out gorilla/context and use
web.C instead, but the public API in sessions relies on the global
context - i.e. there are a couple of public methods that take the request
(only). This means you can't pass in Goji's web.C instead. Breaking the API
means that all of the third party stores (cookies through to Redis through
to mySQL) would no longer work, which is one of the big pluses for using
gorilla/sessions in the first place.
You could probably work with that [forking gorilla/sessions] and rename
your fork (crediting the original authors as per the license) to avoid
confusion, and maybe even port a couple of third party stores over too.
That's not a huge undertaking (technically) but you'll need to re-do the
docs if you want user traction and some parts (the registry) are tightly
coupled with gorilla/context. Or write your own lib, but obviously that's a
slippery slope if you want to have some feature parity with
gorilla/sessions.
Note that this is how I ended up writing my own auth cookie library - the
primary use for sessions is auth, so writing a focused lib was a lot easier
than something as modular as gorilla/sessions.

Note that the performance impact by the gorilla/context global request
map + mutexes may not be as bad as "global map with mutex" sounds. You
should be able to blow past 12k req/s or more with 400+ concurrent
connections even with the global map.

On Fri, May 8, 2015 at 8:31 AM Akshay Moghe<EMAIL_ADDRESS>wrote:

I am working on an auth package with middleware helpers
Thats cool! Could you point me to the repo (assuming its public) so I
could take a look at what kinds of middleware you are planning?
if you're looking for a more general cookie store, I would leverage
gorilla/sessions
Yes, I considered gorilla/sessions , but it maintains global state to
achieve its goal. In a goji-like framework, we should be able to use web.C
and completely avoid global state (which is how I started thinking about
this).
—
Reply to this email directly or view it on GitHub
https://github.com/zenazn/goji/issues/125#issuecomment-100054640.

@elithrar Any update?

Almost done! Writing tests. Might be at least a couple of weeks but no
promises—real life work taking precedence right now! ;)
On Fri, Sep 4, 2015 at 8:40 AM bdd<EMAIL_ADDRESS>wrote:

@elithrar https://github.com/elithrar Any update?
—
Reply to this email directly or view it on GitHub
https://github.com/zenazn/goji/issues/125#issuecomment-137611827.


chore: automated PR to update VHDVersion for 202404.29.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202404.29.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.376%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2997

Relevant Lines:
3924

💛  - Coveralls


Hueycoatl Draft

Pics coming soon

The object definition for Hueycoatl Tent has the wrong material assigned to it.
A victim of FINE_CARPET being removed.


Add a new approach for CA integration through the Envoy SDS API.

Describe the feature request
Add a new approach for CA integration through the Envoy SDS API.
Please see RFC: Istio CA integration through Envoy SDS
Describe alternatives you've considered
The alternative that has been considered is fetching the workload identity materials through the istio-agent calling a SPIFFE Workload API implementation; this would require adding a new path to the istio-agent Secrets Manager logic.
These ideas were discussed at Networking WG Meeting on Nov 11, 2021.
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

@johnzheng1975 I guess this is what you want


fix(ota_proxy): fix background disk space usage checker not working

Introduction
This PR fixes otaproxy's background disk space usage checker not working as expected due to checker thread exits early caused by raised exception, resulting in otaproxy LRU cache rotation not being triggered on soft disk space usage reached and otaproxy cache disabled on hard space usage reached.

Included in #447 .


DotA2 Ping lightning

Hi,
i´ve seen thats for DotA2 some lightning effects if someone is pinging - is it possible to get that Feature for the g910 too?

I don't think GSI exposes such information. You said you've seen it somewhere, can you provide a link?

hey,
i´ve talked to the person who told me.... but it was a coincidence with some other lightings... sorry about that


allow Symfony 7

Closes https://github.com/Behat/Behat/issues/1441

I suggest adding a condition step (running if matrix.symfony-version == '7.0') doing composer remove vimeo/psalm --no-update.
We don't need psalm in the job running tests, and this would allow us to run the tests against Symfony 7 without waiting for Psalm to add support for Symfony 7.

Ok now comes the interesting part :smile:
PHP Fatal error:  Declaration of Behat\Testwork\Cli\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/Behat/Behat/src/Behat/Testwork/Cli/Application.php on line 98

Well, Symfony 7.0 indeed forces to add return types in a bunch of places.
The good news is that variance rules added in PHP 7.2 allow us to add those return types in a child class even when using older Symfony versions (and we don't support PHP 7.1 and older).
For some classes, adding such return types might require a major version bump in Behat, but that will be clear once we know the list.

See https://github.com/symfony/symfony/issues/51563 for the type patching utility that can add the return types automatically for many cases.

Well, Symfony 7.0 indeed forces to add return types in a bunch of places.
The good news is that variance rules added in PHP 7.2 allow us to add those return types in a child class even when using older Symfony versions (and we don't support PHP 7.1 and older).
For some classes, adding such return types might require a major version bump in Behat, but that will be clear once we know the list.

Tests are green now :blush: From what I can tell all the classes where I added return types are final anyway? So should not be any BC break?

@dmaicher indeed, final classes are a case where it is fine to add them.

Is there something which still need to be tackled here? Maybe @dmaicher can repush as the last run was 2 month ago so we make sure it still compatible with the latest changes of Symfony 7 branch.

@alexander-schranz done :+1:
@stof using stable dependencies now for the Symfony 7 build as well. Kept the psalm removal as v4 is incompatible with Symfony 7.

@dmaicher GG
So w're close to merge?

@pamil Hello Kamil, please could you merge it to help us to move forward?

Any update on this one?

+1 for merging this :)

Hello. @stof ,this PR isn't mergeable?

SymfonyExtension is green for Sf7.0 - https://github.com/FriendsOfBehat/SymfonyExtension/pull/206

VariadicExtension and TestExtensions works as well: https://github.com/FriendsOfBehat/VariadicExtension/pull/36

MinkExtension is green as well: https://github.com/FriendsOfBehat/MinkExtension/pull/25

Is there anything else is needed to do in order to create a new release?
I can check if something needs to be done


Fix incorrect badges

[x] Shows "Canceled" but actually Failed
[x] Support showing "Failed Due To Plugin Error"

and probably more...

Fixed in #7e9e12b


Private DNS link vnet from different tenant

Describe the bug
I have two tenants (tenant1, tenant2). Each tenant has a subscription (sub1, sub2), resource group (rg1, rg2), vnets (vnet1, vnet2). I am able to create a peering between vnet1 and vnet2 using the IAM roles configured (added user from tenant1 to rg2 with Network Contributor role)
I am trying to register vnet2 as a resolution network (old nomenclature) to the private zone created in sub1. Tried both previous and current preview version of Private DNS zone feature - both failing with similar messages.
Documentation only specifies permissions necessary to create vnet peering between different tenants - Network Contributor. Do I need any other permissions?
Is it possible at all?
az account list for user1:
[
  {
    "cloudName": "AzureCloud",
    "id": "_sub1_",
    "isDefault": true,
    "name": "Visual Studio Enterprise",
    "state": "Enabled",
    "tenantId": "_tenant1_",
    "user": {
      "name": "_user1_",
      "type": "user"
    }
  },
  {
    "cloudName": "AzureCloud",
    "id": "_sub2_",
    "isDefault": false,
    "name": "_sub2-name_",
    "state": "Enabled",
    "tenantId": "_tenant2_",
    "user": {
      "name": "_user1_",
      "type": "user"
    }
  }
]

Command Name
az network private-dns link vnet create
Errors:
The client has permission to perform action 'Microsoft.Network/virtualNetworks/join/action' on scope '/subscriptions/_sub1_/resourceGroups/_rg1_/providers/Microsoft.Network/privateDnsZones/_zonename_/virtualNetworkLinks/_vnet1_', however the current tenant '_tenant1_' is not authorized to access linked subscription '_sub2_'.

To Reproduce:
az network private-dns link vnet create --resource-group rg1 --name linkname --zone-name zonename --virtual-network /subscriptions/sub2/resourceGroups/rg2/providers/Microsoft.Network/virtualNetworks/vnet2 --registration-enabled false --subscription sub1

@dijyotir for comment

@dijyotir Hello. Any update?

@MyronFanQiu Hi, this functionality is right now only available in Portal. Right now CLI and Powershell does not support this functionality.

@tleepa Should I change this issue into a feature request?

@MyronFanQiu Yes, please. Thank you.

@dijyotir i'm not quite sure if this is the correct place to ask this question. But i'm working with the Azure CLI to link a VNET to a private DNS as well. However, my VNET is in a different resource group than the Private DNS is, and I suspect that this is giving me the following error:
'Can not perform requested operation on nested resource. Parent resource 'my-zone-name' not found.'
Could this have to do something with this feature request as well?

@roblohmann The error seems to suggest that you are trying to create a virtual network link under a private zone but that zone doesn't exist.

@roblohmann The error seems to suggest that you are trying to create a virtual network link under a private zone but that zone doesn't exist.

That was also my inital thought, however I'm sure it exists and linking the VNET to the Private DNS Zone through the portal is not an issue. I just see that I got a response on Stackoverflow to my question regarding this issue, so I'll see what that brings. Otherwise I'll open a new tread here I think.

@roblohmann The error seems to suggest that you are trying to create a virtual network link under a private zone but that zone doesn't exist.

That was also my inital thought, however I'm sure it exists and linking the VNET to the Private DNS Zone through the portal is not an issue. I just see that I got a response on Stackoverflow to my question regarding this issue, so I'll see what that brings. Otherwise I'll open a new tread here I think.

For future references: Got the answer on Stackoverflow, had to get the virtual network id and pass that in. Also see https://stackoverflow.com/a/59384739/291293

I'm not sure if this solution was available due to the bug filed, but I ran into the same problem.  By doing this through PowerShell using New-AzPrivateDnsVirtualNetworkLink there is a parameter called -RemoteVirtualNetworkId you can use to reference a VNET in a different tenant.