electron_20: 20.0.1 -> 20.1.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

13 packages built:
authy electron freetube indigenous-desktop nix-tour sharedown stretchly thedesk threema-desktop tutanota-desktop uivonim vieb whalebird


requireing @cucumber/gherkin-streams fails

Upgrading from:
"@cucumber/cucumber": "7.0.0",
"@cucumber/gherkin": "17.0.2",
To:
"@cucumber/cucumber": "7.2.1",
"@cucumber/gherkin-streams": "2.0.2"
doc says to require the fromPaths like the following:
const { fromPaths } = require('@cucumber/gherkin-streams')
When I do this fromPaths is undefined.
Although if I run in the debugger:
require('@cucumber/gherkin-streams');
I get:
{GherkinStreams: {…}, __esModule: true}
GherkinStreams: {fromPaths: ƒ, fromSources: ƒ}
__esModule: true
__proto__: Object

Is there some sort of additional undocumented trick to require fromPaths or is this a bug?
I've read the Changelog

Yes it does, thanks @aurelien-reeves.


Spikes in Loss?

Hi everyone,
I reimplemented Dreamer in PyTorch. When running I see some kind of loss spikes. I was wondering if that is something that you also experience or whether this is a problem of my implementation:
50k batches / 500k env steps:

Hi, cool that you implemented it in PyTorch. I don't think I've seen any spikes like that so it's quite likely to be a bug somewhere.

Thank you for answering so quickly!
Interestingly the spikes seem to not influence my results, but I still try to find the reason and then report back.
For now the issue can be closed.


Error in PAPI_library_init

Hello,
I want to use the papi wrapper for a multi-threaded code.
I could compile it using Ubuntu 20, gcc 9.4. I used the provided shell script to build it. However, when I run the compiled tests, it gives me an error. For example:
./test_pw_multithread.o
/home/kazem/programs/papi_wrapper/lib/papi_wrapper.c FAILED
Line # 356
Error in PAPI_thread_init: PAPI hasn't been initialized yet

This happens for all tests (with a different line number).
Any helps will be appreciated.
----------- Update:
I had multiple PAPI versions in my machine, the problem is solved.

Glad to hear that ;)

@cheshmi yeah, that is something we thought about in the past. However, each architecture has a concrete number of performance registers available. If you want to measure a large number of events, this hardware limitation complicates life a lot if you don't want to do multiplexing.
We developed this wrapper for measuring relatively small regions of code, and that's why this approach work good as it doesn't add that much runtime even though the measurements are done sequentially.
Does this answer the question?

Yes, makes sense.
This wrapper is quite handy. Thanks for making it public.
By "even though the measurements are done sequentially.", do you mean where you used omp critical to record counters?


Updating photo via multipart/form-data

How to update sent photo using multipart/form-data?
editMessageMedia expects InputMedia as JSON-serialized object which should contain attached file as a part.  Description says it's possible somehow to update via multipart/form-data but how actually this request may look like?
https://core.telegram.org/bots/api#editmessagemedia

You can pass “attach://<file_attach_name>” in the "photo" field if the photo is uploaded using multipart/form-data under <file_attach_name> name


Overlay location on rotated canvas changing on zooming

I have encountered an issue with overlays in an OpenSeadragon canvas with viewportMargins. If the image is rotated (by multiple of 90°) the overlays move in relation to the underlying image when zoomin in or out.
Below is some sample code

@avandecreme Is this something you could take a look at?

Yep I will try.
For reference, here is the codepen of the above code:
http://codepen.io/avandecreme/pen/BzbGaw?editors=0010

@avandecreme Excellent, thank you for looking into it (and for creating the codepen).

Hello avandecreme,
thanks for fixing this issue. I noticed that this changes the viewport sizes a bit, so  I'll wait until the changes are merged back into the master branch before trying to implement them into out application in case you are still doing changes here.
Thanks all,
Beechwell

Hello @Beechwell,
Unfortunately, I hit a dead end trying to fix this and don't have much time to look deeper.
Hopefully, someone will be able to fix this in the future.

Hello @avandecreme,
that is unfortunate, but I understand. Thank you for looking into it anyway.
Actually, the fix you commited in avandecreme/openseadragon seemed to be working for me. I assume it clashes with other features or desired margin behaviour?
If I find the time, I might try to fix it myself. Anything I should take into account for it?

@Beechwell The discussion in Gitter starting here:
https://gitter.im/openseadragon/openseadragon?at=57bb2f4f6981f5f2690b4ca0
...describes my concerns with @avandecreme's patch. I'm happy to go into more detail if you'd like. Thank you for (possibly) looking into it!


Improvement/add validations for output file extensions

My issues po sa PR, Pa Decline po. Thanks

Declining as per request.


EN content on FR page

https://systeme-design.alpha.canada.ca/fr/composants/champ-de-saisie/

^ lines of code to fix this -- just needs the FR translation

It looks like this was never translated. I'll send the text to @EliseKa

Translations are ready, flagged in pink in this Figma file (FR input frame)

Code is merged and deployed to production


Fixes #4789

The fix is straightforward: mark the atoms involved in bonds which are modified in 5-membered rings and then look for those tags when figuring out whether or not to adjust single bonds later.

@rachelnwalker I think this fixes the problem you reported

Thank you @greglandrum!


Delete campaign

[x] add functionality to delete campaign files on S3
[x] implement deletion in users (managers and watchers) json [waiting on campaign json update]
[x] implement deletion from the UI and redirect to user's page (My projects)
[x] notify the user that the deletion has worked

Changes after review:

[x] add text in the popup window "This operation cannot be undone"
[x] fix display attribute of popup so it doesn't break in Chrome
[x] use bootstrap Modal for the popup window
[x] when looking up managers/viewers take into account the new json  structure

"campaign_viewers": [
  { osm_id: "123456", name: "Jo Sprague" },
  { osm_id: "987654", name: "Russ Biggs" }
]

[x] create a test campaign.json file to test

Closes issue #669

Looks like there is some styling issues on this:

@russbiggs this looks more like you can't see half of it! I've added screenshot in the PR description.
I'm not sure of what's going on? How are you running it locally?

This looks pretty much complete.  We just need to hide the delete button in the header in the case where the user is not a manager of the campaign

This looks pretty much complete. We just need to hide the delete button in the jinja template in the header in the case where the user is not a manager of the campaign. Although not necessarily secure it would be good to do a check on the delete handler server side as well.

Sure! I hadn't realised it was to be done on my end.


USHIFT-1623: various improvements to development VM configuration

Add getty to tty0 so virsh console will work with the VMs.
Add a VNC console to VMs created by the dev scripts to make it easy to
access them via cockpit.
ignore subscription-manager error on teardown of vm
add 'console' command to manage-vm.sh
add 'ssh' command to manage-vm.sh

/assign @ggiguash @pmtk @pacevedom

/test microshift-rpm-upgrade

/lgtm


Only allow renting of available devices

[x] When creating a rent a query should be run that checks if the device is already in use somewhere else.
[x] The search endpoints should be updated with an aditional arguement wheter you want all or just available

[x] this can be nicely by just using the exsting json and providing optional keys
[x] the existing searchwithdevicetype method in the device resource should be merged into the search method with the devicetype beeing another queryParam

wenn rent abgelehnt wird sollte dieses gerät wieder verfügbar sein oder?
nur aktuell verliehene rents sollten verwendet sein

Please revise

[ ] the search options should be a DTO in the backend and an interface in the frontend
the current implementation of the availability check is incredibly weird

two speperate implementations exist: one in the Rent repo one in the Device repo
i cleaned up the one in the device repo (was mapping to rentDTO and using unnecessary sql
[ ] please remove the unneeded isDeviceAlreadyInUse method in the rent repo

[ ] the filtering of search results in the device repo is incredibly weird and inefficient

[ ] two ifs check for the same type_id > 0 condition
[ ] the availabilty check is not included in the sql query but done later on by looping over the result and creating a new query to filter out every singel entry


Allow profile logs merge into single view

Is this equvalent to saving an aggregation in a file (binary or otherwise) for later re-reading ?

@PhRX that would be one way of doing it
Log files have a time line, profiles currently do not. We could just increment the profile in memory.

Serilization into a collapsed stacks format would interop with #199


Created a way to aquire a plex token via sign in instead

Adds a way to create a plex instance with a plex.tv username and password by requesting a token according to this specification.
Technically, the client identification needs to be a unique identifier though I'm not sure how best to do that.
I don't write much go code so be gentle...

Thanks a lot, man!


[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2019-11-01-preview

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

We are removing the 3 enum values for ComplianceState property, as the agent is now sending additional values other than these three.  Since we anticipate more values to be returned, we want to remove these preset values.  Since this property has modelAsString set to true, we believe this is not a breaking change - as specified in the API revision guidelines.

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Folks, there is some urgency to this, as we are targeting to release to Public Preview on the 11th of May.  We are taking these changes in response to JasonZ review feedback ,we received just couple of days ago.  I have added new enum values so as to not break the API.  As per guidelines, since the property is declared as modelAsString, add new values is not considered breaking change.  Can you pl. help review?  I requested @ArcturusZhang to be added, as he has prior context on this spec.

/azp run automation - sdk

/azp run automation - sdk

@allenjzhang, I've made the changes.  Can you please merge the PR?


upgrade to intervention/image v3

We don't use laravel-assets v3 yet, instead use feature/upgrade-intervention-v3 branch for the same fixes on v2.0.18


Unable to set custom height and width

I am unable to set a custom height and width (36 dp each), also unable to place the view anywhere other than at the center.

i have same problem

I don't have enough time now to do this features.
When i have - i'll try to do it.

add to v1.1


[Razor class libraries] Add section about typescript integration with razor class libraries

We have users asking how to do this.
The recommendation is:

Put your ts files outside of the wwwroot folder (inside a Client folder for example).
Configure the typescript build output to go to wwwroot. (Can be done with <TypescriptOutDir>wwwroot</TypescriptOutDir>)
Include the TypeScript target as a dependency of the ResolveCurrentProjectStaticWebAssets target by adding this inside a PropertyGroup in your project

    <ResolveCurrentProjectStaticWebAssetsInputsDependsOn>
      TypeScriptCompile;
      $(ResolveCurrentProjectStaticWebAssetsInputs)
    </ResolveCurrentProjectStaticWebAssetsInputsDependsOn>

@guardrex

According to https://docs.microsoft.com/en-us/aspnet/core/razor-pages/ui-class?view=aspnetcore-3.0&tabs=visual-studio#create-an-rcl-with-static-assets I added <ResolveCurrentProjectStaticWebAssetsInputsDependsOn>TypeScriptCompile;$(ResolveCurrentProjectStaticWebAssetsInputs)</ResolveCurrentProjectStaticWebAssetsInputsDependsOn> but only get:
C:\Program Files\dotnet\sdk\3.0.100\Sdks\Microsoft.NET.Sdk.Razor\build\netstandard2.0\Microsoft.NET.Sdk.Razor.StaticWebAssets.targets(266,61): error MSB4057: The target "TypeScriptCompile" does not exist in the project.

@springy76 ... Open a new issue using the feedback form at the bottom of the topic.

@springy76 You need to have the typescript compiler package installed.

Discussion moved to #14633.


Fixed the Navigation UI

HI. I made change from the main.css and header.html to fix the navigation.

@jhondelbaguio  Thanks for contributing. Can you please include a screenshot of the UI changes?

Here are the screenshots.
iPhone 6s Screen

Large Screen

@jhondelbaguio Great work :+1:


Add a PANGEO_SCRATCH variable

xref https://github.com/pangeo-data/pangeo-cloud-federation/issues/610,
https://github.com/pangeo-data/pangeo/pull/780. This adds a
PANGEO_SCRATCH environment variable. It relies on the existence of

PANGEO_SCRATCH_PROTOCOL
JUPYTERHUB_USERNAME

And combines those to form something like
PANGEO_SCRATCH=gcs://pangeo-scratch/tomaugspurger
We'll need to update the helm charts to set PANGEO_SCRATCH_PROTOCOL to be s3 or gcs. This is a bit convoluted but I couldn't think of a simpler way.

Tom thanks for working on this. I think it is the best solution we can manage right now. We can continue to iterate on this feature if it proves popular.

Thanks, updated with your suggestions.

@scottyhq any thoughts here? Otherwise I'll merge in a bit so I can try this out on the new clusters.


Disable ctrl-f bindings in the minibuffer

I use selectrum for minibuffer completion and so I rarely need to search for a string in the minibuffer. I would like to disable ctrlf bindings there (to use the key sequences for more useful commands, in that context).
Is this possible at all? In particular, it seems that ctrlf bindings override local ones. This might be related to #62 and #64, but I am not sure.

I read more about define-globalized-minor-mode. One way to resolve this is
(add-hook 'minibuffer-setup-hook
            (lambda () (ctrlf-local-mode -1)))

I think this should be done by default. There is no good reason for CTRLF to be active in the minibuffer.

OK, so:

by default using CTRLF in the minibuffer outside of a CTRLF session will do Isearch instead, like in vanilla Emacs
the default CTRLF bindings can be overridden by user bindings, e.g. (define-key minibuffer-local-map (kbd "C-s") (lambda () (interactive) (message "Hello"))) in my testing just now will override C-s in the minibuffer outside of a CTRLF session.

You shouldn't have to disable CTRLF in the minibuffer explicitly for the above to work.

Hmmm.. That's exactly what I tried in the beginning and it didn't work for me (CTRLF is still called when I press C-s, despite the fact that I see the correct binding when inspecting minibuffer-local-map).
I am using Radian for my config which enables the global mode of CTRLF. The documentation of define-globalized-minor-mode,  which is used in CTRLF,  says that "When a major mode is initialized, MODE is actually turned on just after running the major mode's hook.  However, MODE is not turned on if the hook has explicitly disabled it."
So if I am understanding this correctly, the CTRLF mode is turned on after the minibuffer mode and the keybindings of minibuffer in minibuffer-local-map are overridden. That is why disabling CTRLF worked for me (although I had to change the code a little to make sure CTRLF is not disabled in a CTRLF session).


Check in TF 1.13.1

What this PR does / why we need it: Check-in TF v1.13.1 for source protos to be used in TF2OpenAPI
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

/cc jiwang576
/cc ellis-bigelow

/ok-to-test

/lgtm
/approve


[BUG] Robotidy Version 2.2 API changes

Describe the bug
Format Document (Shift + Alt + F) didn't work in my laptop (Nothing changed and no errors occurs)
To Reproduce
Steps to reproduce the behavior:

Open the folder with VScode which contains *.robot
Right Click >> Format Document
The document has no changes.

If possible add some example source code like:
*** Settings ***
Force Tags  tags  tag2
Library  Collections
Resource  important.robot
Library   MyCustomLibrary.py
Test Setup  Setup Keyword
*** test case*
Test1
[ teardown]  Teardown Keyword
Keyword
FOR  ${var}  IN RANGE  10
Run Keyword If  ${var}>5  Other Keyword
END
*** Variables ***
${var}=  2
${bit_longer}  10
${var2}   a
...  b
(Can find the code from https://pypi.org/project/robotframework-tidy/)
however i use the command  "robotidy test.robot", the document will format correctly
Logs
There is no logs in the console
Versions
robotframework                 5.0
robotframework-pythonlibcore   3.0.0
robotframework-robocop         2.0.2
robotframework-seleniumlibrary 6.0.0
robotframework-tidy            2.2
VS Code 1.6.7
Robot Code v0.12.0
Windows 11  22000.613

Did you disable robotidy in settings?

Ok, got it, Robotidy API changes a little bit.

try the new version 0.12.1, it should be fixed.

try the new version 0.12.1, it should be fixed.

It works in 0.12.1
Robot Code helps a lot when coding
Thanks

Hi Daniel,
I have exactly the same issue as described above.
When I execute the robotidy from command line it works fine and the document will be formatted,
but when I right-click the document and select "Format document" (or press Shift + Alt + F) nothing happens.
I also do not see any logs in the VS Code debug console.
And off course I have Robotidy enabled in Robot Code extension settings in all domains (User + Remote + Workspace)
My environment:
I run my Robot code from inside Docker container running on Ubuntu 22.04.1 (WSL2 on Windows 10 Pro).
I have the following packages installed inside the container:

VS Code 1.72.2
Robot Code 0.12.1
Robot Framework 5.0.1
robotframework-tidy 3.2
robotframework-robocop 2.5.0
rpaframework 17.7.0

where did you install robotidy? it must be in the same python enviroment you use to execute your tests.

All libraries including the robotidy and the Robot Code extension itself is installed inside the container.
The container is build from "python:3.10-bullseye" base image.

and you did your development in the container?

Yes, exactly

did you use python virtualenvironments in your container or simple pip?

Just simple pip install from requirements.txt
To be exact:
python -m pip install --disable-pip-version-check --no-cache-dir -U -r /tmp/pip-tmp/requirements.txt

Btw, I tested it both at work and at home with same result.
At home I use Docker container running on Ubuntu 22.04.1 (WSL2 on Windows 10 Pro)
At work we use remote host (via SSH) with Docker container running on Ubuntu 20.04.

ok, cannot reproduce it at the moment, but:
can you try the current preview version of RobotCode In VSCode you can simple switch between preview and stable versions of RobotCode. And see if it working in the preview version.
Because RF 6 has been released, I am in the process of creating a new stable version of RobotCode. I think I will release it today or tomorrow.
and there are new versions of robotidy and robocop. Can you try this also?

Sure, I will try it and give you a feedback later today.

So I upgraded RobotCode to Pre-Release version 0.13.26 and it seems like now it works correctly!
Not only that Robotidy is now formatting the code after right-click and select "Format document" (or press Shift + Alt + F),
but also Robocop is now higlighting potential issues in the code itself.
Many thanks for your help and keep up the great job! Me and my colleagues we really love the Robot Code extension.

thank you!


Added GITHUB_OWNER for compatibility with Organizations

When using an Organization's repository and actions, this action will fail due to the GITHUB_ACTOR and GITHUB_OWNER being different. I have internally introduced the GITHUB_OWNER variable to resolve this issue. Do let me know if you foresee any issues with this implementation.
This PR also includes some minor changes:

Updated readme to use built-in GITHUB_TOKEN as it is meant to supersede PATs. "If your workflow is using a personal access token (PAT) to authenticate to ghcr.io, then we highly recommend you update your workflow to use GITHUB_TOKEN."
Added default dockerfile_path of Dockerfile in action.yml
Removed readme section on PAT since it is replaced by the built-in GITHUB_TOKEN

Let me know if you have any questions and thank you for writing this Github Action!

Hi @Miniland1333! Thanks for the improvements, gonna go through them now :)

Testing indicates that the changes you suggested were successful! https://github.com/LibreTexts/renderer/runs/2403021880?check_suite_focus=true

Should be available now as 2.0.0: https://github.com/pmorelli92/github-container-registry-build-push/releases/tag/2.0.0
Thanks for the changes! @Miniland1333

@pmorelli92 thanks for your help with this! I can confirm this version is successfully working at https://github.com/LibreTexts/renderer/runs/2404372407?check_suite_focus=true


types: Added stricter type checking for plugin in vue use function

Waiting for this to get merged

This seems similar to #3969, which was merged in 3.2.46. I haven't studied this PR in detail, but I'm wondering whether the changes proposed here are still needed?

This PR does contain additional updates to the compat build which I added in https://github.com/vuejs/core/commit/47453f102e0293f89b518d35a6ae5a0bb8ff8234


Prediction Not Changing

Great tutorial and very easy to follow. I got everything working as per this guide and have a working solution. The only problem is that my prediction is always 0.489944100379944. What am I missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a747220-f587-2b7a-1c9d-176cfccb3702
Version Independent ID: d41386c4-50b2-927f-4fcb-0ab842edf0ca
Content: Weather forecast using Azure Machine Learning with data from IoT Hub
Content Source: articles/iot-hub/iot-hub-weather-forecast-machine-learning.md
Service: iot-hub
GitHub Login: @rangv
Microsoft Alias: rangv

@sudeephazra Thanks for the question! We are investigating and will update you shortly.

@sudeephazra In the last step (Use Microsoft Azure Storage Explorer to view the weather forecast)
It has you download a .csv file from Azure Storage Explorer. In this file, do you consistently see a value of 0.489944100379944? It might be that your solution is working but the 'chance of rain' hasn't fluctuated. Can you verify this?
Thanks,
Mike

@sudeephazra We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.
Regards,
Mike

@sullyNivek75 At the beginning of this tutorial, there is a 'Note' section that discusses a prerequisite for having the device already set-up:

set up your device
In those steps, there is the option to use simulated data or not:

If you don't have the sensor, set the simulatedData value to true to make the sample application create and use simulated sensor data.

Is your sensor hardware configured to use simulated or sensor data?
Configure the sample application

Hi Mike,
Yes my device is set up and is reporting sensor data to Azure>IoT Hub>Streaming Analytics>Power Bi. But I am also having the same problem when i have added an additional query to the Streaming Analytics  to use the machine learning the prediction is reporting 0.489944100379944 , through blob storage and through Power Bi. Not sure where the problem is?
Thanks
Kevin

I resolved the issue. The problem is with the training data that the ML model uses. In the training data CSV, the temperature and humidity columns have the character 'M' in a bunch of places. This causes the model to expect characters as values of temperature and humidity. But if you send in characters to the model, it is unable to perform mathematical/statistical calculations. I downloaded the CSV, removed all records with the letter "M" in the temperature and humidity columns, uploaded the CSV and used this file as the training data and had my eureka moment :) The entire flow works now.
Regret not being able to respond on this earlier.

I too changed the training data set after i removed the 'M' character from the humidity column and it is now working!
Thanks for you help sudeephazra
Mike, i would suggest you cleanse the online dataset.
kevin

Reference:

The issue is not with the .xlsm/.xlsx prediction model template but with the resulting .csv written to blob storage, I believe. I am using the sample data links from within the Excel workbook.
I do not have access to IoT hardware to walk through this tutorial in it's entirety. I will work with the content owner to figure out what is causing this issue.
@sudeephazra @sullyNivek75 Thanks your feedback and if you have a screen capture that clearly demonstrates the issue, that would be very helpful.
Regards,
Mike

Hi Mike,
You are right, there is still a problem with the algorithm. I let this run through the weekend to see if it would give more accurate readings. What i am finding now is the result is fluctuating, but only by 2% - ranging from 7-9%. This was the case during friday night when it was raining for approx. 8hrs. I would be happy to work with the creators to try and enhance the outputs to make it more accurate. Need to understand the inner mechanics of how the whole process works.
Let me know if there is anything i can do to help?
Kevin

@sergaz-msft The weather data that is being written to the .csv file, by the sensor, is picking-up random characters (^M) that is breaking parts of this tutorial. Is there a contact we can leverage to have this addressed?

I have attached a screen grab to show the outputs from the tests that i have been running. Clearly something wrong. With 100% humidity and a temperature of 10 degrees C, there is a better chance than 9% that it could rain??
Any help would be good
Kevin

Incidentally I have put the original dataset back into the process and the following happens in the same excel predictive session:

#reassign:robinsh
Reassigning this to me so I can take a look at it and see if I can get this issue resolved.

robinsh
Reassigning is not a valid GitHub ID, or is not a collaborator on this repo.

@robinsh checking into see if there is any update on this issue.

#reassign @JimacoMS3
Jimaco -- can you take a look at this?

@AshokPeddakotla-MSFT I'm still in the middle of something; turning it over to Jimaco to take a look at.

Hi there -- I finally had a chance to look at this in some depth. Here's what I can say about it:

If you use the original training data (keeping the rows with 'M" as a value for temp and/or humidity), the model seems to work OK as long as you supply a whole number for the humidity value. If you supply a number that has a fraction, you will always wind up with a prediction of  0.489944100379944. I don't know why that is, but the solution is to either round the data you supply to the machine learning function or clean the rows from the training data that have these values in them.

I wrote an R script to remove all rows from the data frame that have temperature or humidity  values that cannot be converted to a number. Here's the script:
# Map 1-based optional input ports to variables
data <- maml.mapInputPort(1) # class: data.frame

data$temperature <- as.numeric(as.character(data$temperature))
data$humidity <- as.numeric(as.character(data$humidity))

completedata <- data[complete.cases(data), ]

maml.mapOutputPort('completedata')

I inserted it just after the Clean Data module in the Training Experiment:

This got rid of the rows with the M's in the training data. It also has the side effect of making the temperature and humidity data numeric rather than string. This is nice because when you "visualize" subsequent data sets, you can click on a column and get great stats like max, min, mean, medium and standard deviations. Finally, I'm a little out of my expertise here -- there may be better ways of doing this. :)

I don't think it's wise to expect this experiment to be overly predictive of rain. I'm not a weather guy, but I would guess you need a lot more data than just temperature and humidity -- i dunno ... barometric pressure for example? :). If you think about it, 30 degress and 97 percent humidity might mean completely different things on a summer day in New York and a day during the typhoon season in Taiwan.

This is confirmed by "visualizing" the data set coming out of the second port of the split data module (the data being fed into the score model module). Notice that roughly 60% of the data points have rain:

Then "visualize" the data set coming out of the score model module. Notice that well over 90% are scored as having a probability of rain:

I'm no data scientist, but I'm guessing that means that our predictive model is not overly robust :).

@MieRobot With the above provisions in place, the scenario worked OK for me. I didn't experience the issue you reported. If you want to pursue it further,can you provide additional information?

I'll work with the author of the training experiment to see whether they can add a module to clean the data frame as I've done.

Finally, this is a pretty old issue. Is this still a problem for anyone else on the thread? If I don't hear back in the next week or so, I'll go ahead and close it.

Thanks,
Jimaco

The topic has been updated to add the additional r script module to clean the temp and humidity columns. It's live now. Since I haven't heard back on this thread, I'm going to close it. Please @-comment me here or open another issue if you still have problems. Thanks!
Jimaco

#please-close


Doesn't support the dotnet tools (e.g jb)

Version
0.5.4
Details
I've installed jb tool with dotnet cli, the husky tool added a dash between dotnet and tool name; for this reason, the execution failed.
dotnet config file
{
  "version": 1,
  "isRoot": false,
  "tools": {
    "jetbrains.resharper.globaltools": {
      "version": "2022.3.2",
      "commands": [
        "jb"
      ]
    },
    "husky": {
      "version": "0.5.4",
      "commands": [
        "husky"
      ]
    }
  }
}

husky's runner task
 {
      "name": "Run JB Clean Up Code",
      "command": "dotnet",
      "args": [
        "jb cleanupcode myproj.sln --profile='proj: Full Cleanup'"
      ],
      "group": "pre-commit",
      "cwd": "."
    }

Steps to reproduce

Install jetbrains.resharper.globaltools locally with dotnet cli => dotnet tool install JetBrains.ReSharper.GlobalTools
add "jb cleanupcode myproj.sln --profile='proj: Full Cleanup'" into the arg property in the one task runner
this command works correctly => dotnet jb cleanupcode myproj.sln --profile='proj: Full Cleanup'

Hi @aliasadidev,
I'll take a look deeper into why this is happening, but if you separate your arguments it will work correctly, this is happening probably for different behaviors in parsing arguments for Linux, windows, and mac terminals.
 "command": "dotnet",
 "args": [ "jb",  "cleanupcode",  "myproj.sln --profile='proj: Full Cleanup'" ]

@alirezanet Thanks it works, I guess it would be great to mention it in documents or in the real sample.

Happy to hear that it worked,
thanks for the feedback, also pull requests are welcome 😉😊


updated types

@hilookas

I replaced the type with a simple plugin so that I did not have to cast
I also removed the partition, because parameters will always be passed to the function, initially I used a partition so that the user in his handler did not describe all the parameters if he did not need them, but it is more correct not to use it, and the user can use the syntax with _ for unnecessary parameters

Thx!


Silent error when trying to read image file

Bug Report
Problem
I'm having problems with this plugin to read images. My idea is to read an image file and convert it to Base64, but I can't read that image no matter what I do. These images are stored by the "Crop" plugin in the directory Android\data\com.mycompany.myapp\cache, and they actually reach there, but cannot be read by this plugin.
What is expected to happen?
The "File" plugin should correctly read the picture's data, or throw an error.
What does actually happen?
It instead throws a silent error which stops execution, but doesn't crash the app.
Information
I explained the problem in further detail in this StackOverflow question.
Command or Code
  const base64 = await this.file.readAsDataURL(filePath, imageName);
Once you reach this line, nothing shows up. The code won't continue executing, and it won't throw any exception, even if wrapped inside a try-catch. Nonetheless, the plugin seems to work, as it correctly finds the image it has to read, using this line and returning "true":
const imageExists = await this.file.checkFile(filePath, imageName)
Environment, Platform, Device
Xiaomi Pocophone F2
Version information

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Cordova doesn't implement a promise-based API, so I cannot comment why it's not resolving.
Encoding base 64 urls on images can be extremely expensive (images can be upwards of 10mb-20mb in file size on some devices when configured to use high resolution when binary encoded, and can grow by 30% when creating a base64 encoded string, which can lock up a modern device for a short period of time. So in general I'd advise against using base64 encodings unless you can guarantee that you are working with small bits of data.
This doesn't seem to be a bug so I'll be closing this issue. If you require more support on this issue, please use our Slack. Thanks.


OCPBUGS-22924: Removing unncessary imagePullSecrets

The following failures are seen during 4.15 OCP Conformance testing.
event happened 29 times, something is wrong: ns/openshift-cluster-csi-drivers pod/ibm-vpc-block-csi-node-6jz5b node/ci-op-yv1idktj-52953-cz9r6-worker-3-2dzfq hmsg/99d84ba4c3 - pathological/true reason/FailedToRetrieveImagePullSecret Unable to retrieve some image pull secrets (bluemix-default-secret, bluemix-default-secret-regional, bluemix-default-secret-international, icr-io-secret); attempting to pull the image may not succeed. From: 17:18:02Z To: 17:18:03Z result=reject
event happened 36 times, something is wrong: ns/openshift-cluster-csi-drivers pod/ibm-vpc-block-csi-node-ljsc9 node/ci-op-yv1idktj-52953-cz9r6-master-0 hmsg/99d84ba4c3 - pathological/true reason/FailedToRetrieveImagePullSecret Unable to retrieve some image pull secrets (bluemix-default-secret, bluemix-default-secret-regional, bluemix-default-secret-international, icr-io-secret); attempting to pull the image may not succeed. From: 17:18:26Z To: 17:18:27Z result=reject
event happened 33 times, something is wrong: ns/openshift-cluster-csi-drivers pod/ibm-vpc-block-csi-node-6jz5b node/ci-op-yv1idktj-52953-cz9r6-worker-3-2dzfq hmsg/99d84ba4c3 - pathological/true reason/FailedToRetrieveImagePullSecret Unable to retrieve some image pull secrets (bluemix-default-secret, bluemix-default-secret-regional, bluemix-default-secret-international, icr-io-secret); attempting to pull the image may not succeed. From: 17:23:20Z To: 17:23:21Z result=reject

Hence the removal of these imagePullSecrets is necesary.

Test after removing ImagePullSecrets on IPI
Scaled down the following
kubectl scale --replicas=0 deploy/cluster-version-operator -n openshift-cluster-version
kubectl scale --replicas=0 deploy/cluster-storage-operator -n openshift-cluster-storage-operator
kubectl scale --replicas=0 deployment.apps/ibm-vpc-block-csi-driver-operator -n openshift-cluster-csi-drivers

Edited ibm-vpc-block-controller-sa and ibm-vpc-block-node-sa  - removed the following imagePullSecrets

name: bluemix-default-secret
name: bluemix-default-secret-regional
name: bluemix-default-secret-international
name: icr-io-secret

Resultant SA
apiVersion: v1
imagePullSecrets:
- name: ibm-vpc-block-controller-sa-dockercfg-j8qdq
kind: ServiceAccount
metadata:
  creationTimestamp: "2023-10-26T14:33:25Z"
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    app: ibm-vpc-block-csi-driver
  name: ibm-vpc-block-controller-sa
  namespace: openshift-cluster-csi-drivers
  resourceVersion: "2923040"
  uid: f61c5c68-b96e-4502-b893-81bf4c10d7c3
secrets:
- name: ibm-vpc-block-controller-sa-dockercfg-j8qdq

apiVersion: v1
imagePullSecrets:
- name: ibm-vpc-block-node-sa-dockercfg-v9cg9
kind: ServiceAccount
metadata:
  creationTimestamp: "2023-10-26T14:33:25Z"
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    app: ibm-vpc-block-csi-driver
  name: ibm-vpc-block-node-sa
  namespace: openshift-cluster-csi-drivers
  resourceVersion: "2921989"
  uid: 053b90b1-3218-498b-b375-8135f746e0da
secrets:
- name: ibm-vpc-block-node-sa-dockercfg-v9cg9

Restarted the controller and node server pods.  Pods were running
gunakk@Gunas-MBP originals % kubectl get pods -n openshift-cluster-csi-drivers
NAME                                            READY   STATUS    RESTARTS   AGE
ibm-vpc-block-csi-controller-78f8f48b79-xrsjd   6/6     Running   0          11s
ibm-vpc-block-csi-node-fc22v                    3/3     Running   0          6d12h
ibm-vpc-block-csi-node-fgnmc                    3/3     Running   0          6d12h
ibm-vpc-block-csi-node-gvssh                    3/3     Running   0          6d12h
ibm-vpc-block-csi-node-hvzxb                    3/3     Running   0          6d12h
ibm-vpc-block-csi-node-nx5sl                    3/3     Running   0          2m18s
ibm-vpc-block-csi-node-tn6q9                    3/3     Running   0          2m18s

/ok-to-test

/retitle OCPBUGS-22924: Removing unncessary imagePullSecrets

@GunaKKIBM thanks a lot for the PR, I see one unrelated failure in the e2e test, but the [sig-arch] events should not repeat pathologically for ns/openshift-cluster-csi-drivers test passed.
/jira refresh
/lgtm
/approve

/jira refresh


刷新页面后消息丢失 & 刷新页面后未读提示仍在 || The message is lost after refreshing the page & the unread prompt is still there after refreshing the page

刷新页面后消息丢失

在线用户可接收到消息 刷新后均消失
未读提示刷新页面后仍出现

Messages are lost after refreshing the page

Online users can receive messages and they will disappear after refreshing.
The unread prompt still appears after refreshing the page

can you open your network panel can check is request success?


Clear usage instruction with one's own data

Hi,
I've been trying to work with your code (very cool project by the way). Is there any plan to make the instructions cristal clear on how to use your code to infer scenes from one's video or image. Is there anyway you could for example create a google colab out of it? I've given a shot at it and couldn't complete colmap's installation.
I'm really looking forward to being able to experiment with your project!
Thanks in advance

I want to know that too.
For example, the dynamic scene data set. I see [images] [mv_images] [sparse] in the dense folder.

I am wondering if the cameras.bin points3d.bin are computed using distorted images of [images] folder?
If Q1 is yes, how to undistort the images in [mv_images]. For each folder such as [00000], using COLMAP to recompute?

Thanks.


[DDW-1101] Improve send screen error messages

This PR introduces improved send screen error messages.

Testing Checklist

Slack QA thread

NOTE: Navigate to wallet send screen and test next scenarios

[ ] Enter exactly the same amount you have in the wallet - you should see the message: "Not enough Ada for fees. Try sending a smaller amount."
[ ] Enter amount greater than you have in the wallet - you should see the message: "Not enough Ada. Try sending a smaller amount."
[ ] Enter the amount smaller than you have in the wallet while you have at least one pending transaction - you should see the message: "Cannot calculate fees while there are pending transactions."

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@tomothespian I can't visualize the message "Cannot calculate fees while there are pending transactions."

@tomothespian I can't visualize the message "Cannot calculate fees while there are pending transactions."

@gnpf Can you please post a video with opened devTools -> console or at least screenshot. if there are no errors then probably in the meantime availableBalance became equal to totalBalance and I can't show error if you are available to make another transaction.

@tomothespian I checked the console and with a higher amount as you mentioned and tried on a new wallet as @nikolaglumac  suggested. I manage to see the message most of the time. When it wasn't displayed, there was no error in the console, so please dismiss my previous message.

@gnpf please approve the PR if you think everything is fine now...

@tomothespian  Hello!
Can you please double check the Ja translations?
"Not enough Ada for fees. Try sending a smaller amount."

"Not enough Ada. Try sending a smaller amount."

@yakovkaravelov thanks for really, really good suggestions, I missed some things and you cathed that. Nice catches 🚀
Can you please review my changes again?
cc @DmitriiGaico

@yakovkaravelov please run acceptance tests next time you review a PR 🙏

@nikolaglumac E2E tests fixed!


No ability to define custom languages for shiki

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
I want to pass custom language defs to the highlighter, and I can't because there is no ability to pass custom shiki options.
Here is the diff that solved my problem:
diff --git a/node_modules/nextra/dist/loader.mjs b/node_modules/nextra/dist/loader.mjs
index 1e145f5..dbec997 100644
--- a/node_modules/nextra/dist/loader.mjs
+++ b/node_modules/nextra/dist/loader.mjs
@@ -611,6 +611,7 @@ function compileMdx(_0) {
   }, resourcePath) {
     var _a;
     let structurizedData = {};
+    let extraOptions = mdxOptions.rehypePrettyCodeOptions ? mdxOptions.rehypePrettyCodeOptions : {}
     const compiler = createCompiler({
       jsx: (_a = mdxOptions.jsx) != null ? _a : true,
       outputFormat: mdxOptions.outputFormat,
@@ -625,7 +626,7 @@ function compileMdx(_0) {
       rehypePlugins: [
         ...mdxOptions.rehypePlugins || [],
         parseMeta,
-        [rehypePrettyCode, rehypePrettyCodeOptions],
+        [rehypePrettyCode, {...rehypePrettyCodeOptions, ...extraOptions}],
         attachMeta
       ].filter(Boolean)
     });

and here is how I use this in next.config.js
// next.config.js
const { getHighlighter, BUNDLED_LANGUAGES } = require('shiki');
const fs = require('fs');
const path = require('path');
const grammar = fs.readFileSync(require.resolve('./common/clarity-tmlanguage.json'), 'utf-8');

const rehypePrettyCodeOptions = {
  getHighlighter: options => {
    return getHighlighter({
      ...options,
      langs: [
        ...BUNDLED_LANGUAGES,
        {
          id: 'clarity',
          scopeName: 'source.clar',
          grammar: JSON.parse(grammar),
          aliases: ['clar', 'clarity'],
        },
      ],
    });
  },
};

const withNextra = require('nextra')({
  theme: 'nextra-theme-docs',
  themeConfig: './theme.config.js',
  unstable_flexsearch: true,
  unstable_staticImage: true,
  mdxOptions: {
    rehypePrettyCodeOptions,
  },
});

This issue body was partially generated by patch-package.

will be added in next release


Fixed a typo that was causing an issue when running jobs

There was an error caused by a typo when checking the OSName.

Good fix!


Feature request- Detecting mouse buttons

I'm writing an Elm app and need to differentiate between right and left mouse buttons. Currently, onMouseDown fires for either button (I have context menu disabled using prevent default on)
I have the following decoder as a work-around for now
createLeftDecoder : Msg -> Int -> Json.Decoder Msg
createLeftDecoder msg button =
    if button == 0
    then (Json.succeed msg)
    else (Json.succeed NoOp)

checkLeftDecoder : Msg -> Json.Decoder Msg
checkLeftDecoder msg =
    (Json.field "button" Json.int)
        |> Json.andThen (createLeftDecoder msg)

leftDecoder : Msg -> Json.Decoder (Msg, Bool)
leftDecoder msg =
    (Json.map alwaysPreventDefault (checkLeftDecoder msg))

leftClick msg =
    Html.Events.preventDefaultOn "mousedown" (leftDecoder msg)

It would be nice if this was included. (It would also be nice if oncontextmenu and preventdefaulton context menu were provided as well)

@oflatt Core libraries are very minimalist on purpose but allow more features in user packages.
So the custom decoders are not a workaround, they are a feature.
Why not use for example https://package.elm-lang.org/packages/mpizenberg/elm-pointer-events/latest which is a popular package for such use cases?

That makes sense, thank you for the link to the pointer-events package.


LargeScaleCharacterization for source codes

Hi @ajoedicke @albertpratsu @edward-burn,
To put context, LargeScaleCharacterization: the name of the package is prety clear of what it does hahaha.
I have some questions for users,
In each table (e.g. condition_occurrence) we have two concept columns: one refers to the standard code, the mapped one (e.g. condition_concept_id), and the other refers to the original source data (e.g. condition_source_concept_id). When a code is not mapped it appears as concept_id = 0 and we have to check source_concept_id to see which is the original code. This situation causes that usually concept_id = 0 is one of the most common codes in LSC. That's why currently we are not reporting concept_id = 0.
Here the first question:

Should we report the counts of concept_id = 0?

For the large scale characterization we are going to add an argument to also characterize the non standard codes (source_concept_id). Currently we are only characterizing the standard ones. Then the question is:
2) Should we characterize source_concept_id for all cases or only for concept_id = 0?
Note that source_concept_id can also be zero. If we report all source_concept_id, I would assume that answer to Question 1 will apply to this case too.
3) Is that okay?

@catalamarti for me I would exclude concept I'd of 0 (either in the standard or source) from the characterisation.
Curious the rationale for large scale characterisation of source codes? Not to say not to do it, just wondering about the use case for it?

I don't know, if it is going to be useful or not, probably this is a question also for users.
I would say that characterizing the concept_id = 0 would be interesting. But not so sure to characterize everthing.


Analytics

Is there a way we can now how many times the page is visited?
I'm not too keen on a google analytics tag, as it makes the page less standalone. Actually anything frontend falls into the same category.
Maybe gh pages can say how many times the static page was served?

Yes, have a look at https://github.com/rummur/rummur.github.io/graphs/traffic

Amazing.


Support deprecate implicitly nullable parameter types in PHP8.4

Google\Cloud\RecaptchaEnterprise\V1\Client\RecaptchaEnterpriseServiceClient::parseName(): Implicitly marking parameter $template as nullable is deprecated, the explicit nullable type must be used instead
This deprecated warning was occurred in PHP8.4
The following code needs to be generated to prevent the warning below.
public static function parseName(string $formattedName, ?string $template = null): array
public static function parseName(string $formattedName, string|null $template = null): array

It seems that this part of the code needs to be modified.
https://github.com/googleapis/gapic-generator-php/blob/79460062cbb085e6c971919b54558bc46364790e/src/Generation/GapicClientGenerator.php#L274
https://github.com/googleapis/gapic-generator-php/blob/79460062cbb085e6c971919b54558bc46364790e/src/Ast/PhpParam.php#L44
When $this->default is null, it is necessary to generate a nullable ?string or a union type like string|null. However, I am not sure how to implement this using phpparam.
Could you provide some guidance or examples?

Thank you for reporting this! We have a fix in the works and we hope to have this resolved by end of next week at the latest. See the following PRs:
https://github.com/googleapis/gapic-generator-php/pull/736
https://github.com/googleapis/google-cloud-php/pull/7871

thank you!

fixed
https://github.com/googleapis/google-cloud-php/releases/tag/v0.270.0


Made it so that you can continue clicking and still select things.

Minor fix to change behaviour that irritated me; basically I tend to have spastic clicking habits. Other editors it tends to let me do this cyclically; in Lite, after you've double clicked once, the behaviour just disables itself.
Not major or anything, but I think more inline with what might be expected.

Wow, I never thought that someone could click that much... :-)


Added Dino Run by DevKage

Hi, there is already a dino run in the list, is this one any different?

Hi, there is already a dino run in the list, is this one any different?

@spydon if you are talking about the core game mechanics, then I would say both of them are similar.

@spydon if you are talking about the core game mechanics, then I would say both of them are similar.

@spydon Does this mean I should not add my game here?

@ufrshubham we are trying to keep down the number of very similar games, there are a lot of people making the Dino game and the Langaw game for example. What do you think @flame-engine/flame-colab?

@ufrshubham are you DevKage btw?

Yes, I own the DevKage channel.

Yes, I own the DevKage channel.

Great tutorial of Dino Run .
Learned a lot about game development.


theme deploy updates ignored files

config.yml
Simplified filenames & hid passwords / store names
development:
  password: xxxxxxxxxxxx
  theme_id: "xxxxxxxxx"
  store: dev.myshopify.com
  ignore_files:
    - config/settings_data.json
    - snippets/foo-config.liquid
    - snippets/foo.liquid
production:
  password: xxxxxxxxx
  theme_id: "xxxxxxxxx"
  store: live.myshopify.com
  ignore_files:
    - config/settings_data.json
    - snippets/foo-config.liquid
    - snippets/foo.liquid

To Reproduce
Steps to reproduce the behavior:

add test text to section you wish using shopify -> themes -> customize, which should update settings_data.json on the store ( not local files )
run command 'theme deploy' ( in my case - 'theme deploy --env=production' )
check test section & it has been over written by the local settings_data.json ( generally outdated )

Expected behavior
If a user has updated a section ( live settings_data.json ), using theme deploy should not overwrite the section changes with outdated settings_data.json if it is included in the "ignored_files" in config.yml - where in fact it is not being ignored & the changes made by user are overwritten.
Environment:

OS: macOS Mojave 10.14.3 & Ubuntu 18.04.1 lts
Themekit version: ThemeKit 1.0.0 darwin/amd64 & ThemeKit 1.0.0 linux/amd64
Editor: Atom & Visual Studio Code

Additional context
Essentially, client updated a section. Then I deployed code updates & their changes were overwritten by my deployment even though settings_data.json is "ignored" correctly.

Hey @mattAux! Thanks for reporting this. I cannot reproduce this, however. Can you run your deploy command with the -v flag to ensure that it is getting deployed as you are experiencing? Also is there anything else in your config that may be missing from your example like directory config?
I have a suspicion that something else might be going on here because if this was broken I would have a lot more reports of it. This is a common workflow for most people using themekit and when this has broken in the past, the issue was opened within moments of my deploy. Although I have broken it in the past so it is possible :D

Hey @tanema, thanks for getting back to me so soon.
I just ran the addition to deploy command & it didn't seem to deploy the ignored files -- I'm wondering if this was just some one off? I'm now unable to recreate the issue as well!
My apologies for the hassle & thank you for the support!!

Do you have another person working on the same shop who might have uploaded the changes? Either through themekit accidentally or a person who used the online editor? There is also a --no-ignore flag however I think it is really unlikely that you used that flag without noticing.

There are two dev's working on the project, we have both run the command & the ignored settings_data.json file was not deployed with the -v flag.
We also have another person who updates content via the shopify admin panel - I'm under the impression the fault is at their end.
My apologies & thank you for your assistance!!
ThemeKit rocks!

Thanks for the follow-up! I am going to go ahead and close this but feel free to re-open or open a new issue if you have any further issues.


feat(nibijs): mainnet custom chain function

Closes #261

Summary by CodeRabbit

Documentation

Added a new "Mainnet" module description and usage example in the documentation.
Updated various documentation links to reflect the latest source code references and line numbers.
Modified documentation to improve clarity and accuracy of the information provided to users.

New Features

Introduced the "Mainnet" configuration option for easier setup and connection to the Nibiru mainnet.

Refactor

Adjusted internal references and updated documentation to align with recent codebase changes.

queryBatchHandler.test.ts is failing bc testnet doesn't seem to have communityPools or delegations


Support Python 3

I don't know what your plans are with this repo, but if you want people to consider using it, please update to Python 3. Note that Python 2 is almost obsolete; it can no longer be integrated into Python 3 codebases. Please just upgrade the repo to use 3.7.

I don't know what your plans are with this repo, but if you want people to consider using it, please update to Python 3. Note that Python 2 is almost obsolete; it can no longer be integrated into Python 3 codebases. Please just upgrade the repo to use 3.7.

Hi! @impredicative
How cheeky you are !


Add configuration for source ID for logging client

Won't merge. This pr doesn't have a lot of value, it is only setting a default in the config which is redundant since we always set it in the json config of the bosh job.


Methods with name "ctor" is not escaped

Steps To Reproduce
http://deck.net/8b15e6bcbad5fd06599287f7d047a225
public class Base
{
		public Base(object target)
		{
            //Name = "ctor"
			ctor();
		}

		private void ctor()
		{
			//Name = "ctor" , Expected: not "ctor"
		}
}

public class Program
{
    static void Main()
    {
        new Base(null);//Uncaught RangeError: Maximum call stack size exceeded
    }
}

Fixed and included in the Bridge 15.1.0 release, which is now available from NuGet and http://bridge.net/download.


[SPARK-28399][ML][PYTHON] implement RobustScaler

What changes were proposed in this pull request?
Implement RobustScaler
Since the transformation is quite similar to StandardScaler, I refactor the transform function so that it can be reused in both scalers.
How was this patch tested?
existing and added tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12809/
Test PASSed.

Test build #107682 has started for PR 25160 at commit 5c800de.

Test build #107682 has finished for PR 25160 at commit 5c800de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107682/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12889/
Test PASSed.

Test build #107770 has started for PR 25160 at commit bcc10cd.

Test build #107770 has finished for PR 25160 at commit bcc10cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107770/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12926/
Test PASSed.

Test build #107811 has started for PR 25160 at commit a196c09.

Test build #107811 has finished for PR 25160 at commit a196c09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107811/
Test PASSed.

@srowen I am adding it to the pyspark side in this PR.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13007/
Test PASSed.

Test build #107893 has started for PR 25160 at commit cf0c581.

Test build #107893 has finished for PR 25160 at commit cf0c581.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class RobustScaler(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadable, JavaMLWritable):
class RobustScalerModel(JavaModel, JavaMLReadable, JavaMLWritable):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107893/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13008/
Test PASSed.

Test build #107894 has finished for PR 25160 at commit 5e3ffc5.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107894/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13009/
Test PASSed.

Test build #107895 has started for PR 25160 at commit 2391c3d.

Test build #107895 has finished for PR 25160 at commit 2391c3d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107895/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13116/
Test PASSed.

Test build #108007 has started for PR 25160 at commit 364fb83.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13117/
Test PASSed.

Test build #108007 has finished for PR 25160 at commit 364fb83.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108007/
Test PASSed.

WDYT @mgaido91 ?

LGTM, thanks.

@srowen  OK, I am going to add the documents.

Test build #108293 has started for PR 25160 at commit a5d7de4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13392/
Test PASSed.

Test build #108294 has started for PR 25160 at commit 45aa724.

Test build #108293 has finished for PR 25160 at commit a5d7de4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaRobustScalerExample

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108293/
Test PASSed.

Test build #108294 has finished for PR 25160 at commit 45aa724.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108294/
Test PASSed.

I localy test the examples, and they run successfully.
I build the doc, and it looks fine.

Merged to master

@srowen @mgaido91 Thanks a lot for reviewing!


Merging coverage for multiple feature sets

PyO3 has a feature (--multiple-pymethods) which alters several code paths (such as inside a proc macro crate, the feature causes different generated code to be emitted).
Ideally I'd like to measure coverage combined from runs with and without this feature enabled. It's not immediately clear to me whether this is possible with cargo-llvm-cov at the moment. Do you think that's something which would make sense to support?
At the moment PyO3's CI just makes several different invocations to cargo test and then runs grcov once at the end.
I expect it's possible I could find an external tool to merge lcov output files for now, rather than making this a part of cargo-llvm-cov.

Probably we can support this by adding a flag like --no-report that does the opposite of --no-run, and combining the two.
cargo llvm-cov --no-report --features a
cargo llvm-cov --no-report --features b

cargo llvm-cov --no-run --lcov

That sounds ideal. I'm happy to offer a PR to add --no-report if that's helpful? I haven't looked at the code, but skipping the report step doesn't sound too hard to implement 😅
Perhaps the hardest bit is that --no-report may want to avoid cleaning up any existing profiling output? (Assuming that cargo-llvm-cov usually cleans up since output directory before running...?)

I'm happy to offer a PR to add --no-report

That would be great!

Perhaps the hardest bit is that --no-report may want to avoid cleaning up any existing profiling output? (Assuming that cargo-llvm-cov usually cleans up some output directory before running...?)

Perhaps we can separate the step of cleaning the artifacts, the step of running the tests, and the step of generating the report into separate functions, and combine them.

On --no-run, only generate the report.
On --no-report, only run the tests.
Otherwise, do all the steps.

We might be able to add some heuristics for artifact cleanup in --no-report, but for now, I think it's okay to always require explicit cargo clean.

I will probably do this together with some other refactoring.

Ok 👍
I did indeed hope to write this PR, but my time is spread super thin right now so I was expecting I wouldn't get to it before next week. Thank you for all the work on cargo-llvm-cov, it's really improved how we measure coverage in PyO3!


Distance matrix ( Origin / Destination )

It would be nice to use Graphhopper to calulate a distance matrix (or Origin / Destination) matrix from a list of nodes.
This is useful for route optimization.
Either by repetitive use of one-to-all shortest path algorithms like Dijkstra's or maybe use an all-to-all shortest path algorithms such as the Floyd-Warshall algorithm.

I need the distance matrix feature for a mean of 100x100 (all-to-all) queries. The matrix will then be further processed by genetic algorithms for a complex delivery planning and routing problem.
Now before I'm going to implement this in my Fork I wanted to investigate into the current situation of this matter here.

Wouldn't it make sense that GraphHopper provides a (non-optimised) default implementation of the Matrix API? (For the sake of a common API...)
Since you already have implemented an optimised version of this and holding it back for a reason, what would happen if I send you a pull-request with matrix functionality? 😄

This leads to an interesting situation for an (semi) open source project - how to deal with contributions which partially cover closed source features which where intended to be paid for?
That being said, I can somehow understand that you want to keep portions back of your code. On the other hand, this will always lead to such problems, especially if your community grows. Thank you for providing GraphHopper Open Source anyway 👍

Wouldn't it make sense that GraphHopper provides a (non-optimised) default
implementation of the Matrix API? (For the sake of a common API...)

That is a good idea, yes.

Since you already have implemented an optimised version of this and holding it back for a reason, what would happen if I send you a pull-request with matrix functionality? :smile:

That is a very good question and for the last >2 years there was no need to answer this ;)
We will of course not reject it and integrate it if our standards like CLA and unit&integration tests are in place. Commercially it could temporarily make sense to reject this, but our aim is to push our open source projects with the help of our business/company and not the other way around (easier said than done!). Furthermore the 'danger' of a fork would then be higher and we really want to avoid this mess for the sake of our community & quality etc.

That being said, I can somehow understand that you want to keep portions back of your code. On the other hand, this will always lead to such problems, especially if your community grows.

We do not see this as a real problem. In fact we will have to think about closed vs. open features from time to time but our business model is not founded on closed source although it makes it a bit easier at the start with closed source. BTW: see here for a current comparison.

Thank you for providing GraphHopper Open Source anyway :+1:

Thanks for this kind words!

Ok that sound great.
I give it a try an implement a matrix method in the lines of
class GraphHopper
{

    [...]

    public GHMatrixResponse matrix(GHMatrixRequest request) { ... }
}

I will make it extensible so its possible to create your own MatrixAlgorithm provider. In the beginning there will be a simplistic two-for loop implementation and after that the one-to-many Dijkstra.
Depending on the performance of the latter, I will either go with the one-to-many Dijkstra or dive deeper to use a more optimised algorithm which actually can reuse data-structures for the whole matrix calculation.

I would prefer this to be in a separate class like MatrixModule and pass the GraphHopper class in the constructor. As currently the GraphHopper class is really big and needs some separation :)
Or another way would be to have it the way you described and try to separate all the functionality into MatrixAlgorithm or something to reduce the LOC in GraphHopper.java :)

The way I see it GraphHopper acts as a Facade and should give simple access to all parts.

As currently the GraphHopper class is really big and needs some separation

Thats what I just thought as well. There are a lot of things in this class which could be refactored out. Specifically, I'd say it would make sense to separate the construction of a GraphHopper into a GraphHopperFactory. This would remove a lot of boilerplate, all the argument parsing etc. As a side effect, it would also remove the OSM dependencies and make it truly generic.
Also, Storage handling and routing (calcPath) could be moved in separate classes.
GraphHopper would then just compose the separated modules and provide a easy to use API for users as it does now.
So yes, the last thing I'll do is going to bloat GraphHopper class, it will probably get this matrix method just delegate it to a MatrixAlgorithm. All the matrix stuff will land in a separate package anyway.

Perfect & I 100% agree!

Also, Storage handling and routing (calcPath) could be moved in separate classes.

Yes, this will happen in #450

See Pull-Request (WIP) #705

And it's of course still not integrated. Hahaha.
So no reason to use GH as there are at least two alternatives with matrix API implemented :)

Any progress? :)


Adding TweakScale Companion for ReStock+ into CKAN.

TweakScaleCompanion-ReStockPlus v<IP_ADDRESS> requires RestockPlus 1.0.3 or later but it is not listed in the index, or not available for your version of KSP.

Identifiers are case sensitive, Restock should be ReStock. I can fix this for you if you check this box in the lower right:

I notice now that there's a file for RestockRigidLegs. Do you want to pull that in as a dependency as well?

It's an optional - and I had missed that (thanks!).
Should I add it as recommended or suggested?

Sure. "recommends" will pull it in as checked by default, "suggests" will be unchecked by default (and "depends" makes it mandatory). It's up to you based on how important it is to using your mod.

Suggests will be. Adding it on the next commit.

Looks good! Thanks for submitting.


PSReadLine colors and schemes

Environment
Windows build number: 10.0.18362.0

Steps to reproduce
Set-PSReadLineOption -Colors @{
    "Command" = [ConsoleColor]::Yellow
}

in scheme change color for  powershell / pwsh .exe
            "brightYellow": "#F9F1A5",

Expected behavior
yellow should change the [ConsoleColor]::Yellow   color but does not

I'm having a hard time reproing any bug here. If you change the brightYellow property of the powershell profile's color scheme, it definitely updates for me:

Here I've changed brightYellow from it's default value of #f9f1a5 to #ff00ff, and you can see it's updated in the powershell tab.

The problem is why does "brightYellow" and not simply "Yellow" change   [ConsoleColor]::Yellow

Is this because [ConsoleColor]::DarkYellow  is mean to be changed by   "Yellow" and
[ConsoleColor]::Yellow  is mean to be changed by  "BrightYellow" ?

There's some discussion around color names in #2641. To match more closely with ANSI ECMA-48 standard color names, we're departing from the ConsoleColor enum.

@DHowett  which  ENUM do you reccomend then when coloring items in powershell and psreadline ?

For PowerShell Core (or anything else consuming PSReadline 2), you should prefer to use escape sequences to set your colors -- it's better-supported than ConsoleColor everywhere.
Set-PSReadLineOption -Colors @{
    "Command" = "`e[93m"
}

Write-Host "`e[96mWSup`e[m"

Ok regardless the names are super confusing, since they don't correspond to the names here https://en.wikipedia.org/wiki/ANSI_escape_code

I mean, apart from purple/magenta the Windows Terminal settings do correspond to those names? That's called out in https://github.com/microsoft/terminal/issues/2641#issuecomment-527247390.
ConsoleColor cannot be changed. It was created for a different, Windows-only, world. We're not in that world any longer.
Let's continue the discussion in /dup #2641.


python3Packages.hahomematic: 0.6.1 -> 0.7.0

Motivation for this change
https://github.com/danielperna84/hahomematic/releases/tag/0.7.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 152573 run on x86_64-linux 1

1 package built:

python39Packages.hahomematic


Terrible homepage description

The homepage is really terrible:

Meet Minetest.
A free, open source voxel game engine and game. Fully extendable.

Put yourselves in the shoes of a newbie. Do you really think a newbie would understand what Minetest is about? Probably not. This is a horrible way to present Minetest to first-time visitors.
Also, it's not even correct, “Minetest” is only the engine, not the game.
Let's brainstorm for text to put on the homepage. It should be succinct, to the point, explain Minetest's most important features reasonably complete. The goal is that a complete newbie might understand it and does not immediately close the browser tab.
My first suggestion:

With Minetest you can play various games which are set in strange worlds made entirely out of blocks. You can build, dig, explore and do much more.
Play alone or online with friends. Extend it with mods.

Feel free to suggest other summaries. :-)
PS: I'm not saying we should not mention that MT is FOSS, but it doesn't really belong in the very first sentence.

That's way too verbose

Feel free to suggest other summaries. :-)

It also needs to focus on the variety of playing experiences

If fully agree, but this is hard to describe in words. There need to be a few selected high quality screenshots right on the landing page, which together give a decent impression of the actual gameplay. Current background looks incredibly boring (it even shows the old torch!!!).
You also need to keep in mind that the description need to be understood by newbies. Better a slightly longer description which everyone understands than a short description which nobody understands.
https://github.com/minetest/minetest.github.io/issues/78 already has tons of screenshots to choose from.

#78 already has tons of screenshots to choose from.

So has the forum, but instead of using bright, happy, awesome, and friendly screenshots for promotion all we have is a depressing dark background and a few dark, depressing, boring and outdated screenshots on the bottom of the page.
The summary is debatable but currently there is none and in the current form of the page there is no place for adding a proper description.

https://github.com/minetest/minetest.github.io/commit/0f2c12a3ad96b1149084a3e611d0abbbcd07825b


Test/command/nick + reodering of reply.h + replace magic number with NICK_MAX_LENGTH_RFC2812

The testCommandClass.cpp has been updated with nick test cases which consists of:
1 / Valid Nickname tests
2 / Checking error handling when attempting to set invalid nickname
3 / Checking error handling when attempting to set a nickname already in use
Potential Issues and todo:

In order to pass error message tests, I had to use  client.clearSendBuffer();  for the 2 first sections, i.e. setting a valid/invalid nickname. The proper error message is returned, but shouldnt the server flush the buffer after the message has been sent? It may just be a misunderstanding on my side, in which case I would appreciate an explanation.
TODO:  test to handle upper/lower case to be added e.g. if a client tries to set its nickname to "NICK{" when someone already has a "nick["

In order to pass error message tests, I had to use  client.clearSendBuffer();  for the 2 first sections, i.e. setting a valid/invalid nickname. The proper error message is returned, but shouldnt the server flush the buffer after the message has been sent? It may just be a misunderstanding on my side, in which case I would appreciate an explanation.

The sendBuffer is a buffer, when some data is sent, that data is removed from the sendBuffer. There can exist more data in the sendBuffer, than can be sent at one time, therefore the sendBuffer cannot be flushed completely after sending something.


OpenTelemetry integration misses the point: we need to propagate the span/context!

The code where the Subscriber reads the span from the attributes just creates the span and then throws it away:
https://github.com/googleapis/nodejs-pubsub/blob/99107930bbed8e29834acb2347f65efc6a39958f/src/subscriber.ts#L517-L527
A good OpenTelemetry customer would then set the span to the current span in the on("message") handler, so that any subsequent processing is attached to the remote span.
I'll also file a Google support case.
Environment details

@google-cloud/pubsub version: master / v2.17.0

Steps to reproduce

Enable OpenTelemetry in both publisher and subscriber using { enableOpenTelemetryTracing: true } options on topic and subscription.
Perform some processing that creates spans, either manually or (for example) do a Datastore Query or Put.

It can be observed that actions are linked to the subscriber span, as can also be seen in this screenshot (spans take <1ms because nothing is done inside):

Relates to #1078.

@sethmaxwl was the scope of the initial OpenTelemetry PR to just link the publish and subscribe side together? I think it missed the point for any consumer application if you want to link the publish to more downstream actions inside the subscriber.

@hermanbanken Thanks for the comments! We are in the middle of trying to harmonize our treatment of OpenTelemetry for Pub/Sub across languages/libraries. The Node one was sort of a pilot project to see how it goes, and we're hoping to make that better. Feel free to add any comments you have (or anyone who wants to comment!) and we'll add it to the discussion.

One remark I have is that it should be documented a little bit more how it is working. For example, the (semantic) key name and the data format of the propagation key could be documented. I believe it was __googPubsubTrace-something and I think it would be nice if that could be not some magic internal constant. Also, why not use the standard w3c trace header name and format?

Good point, I think Aaron suggested the same regarding W3C trace format. Existing propagator should be reusable. I struggled to get it all working with the recent Otel-js.  If you want you can raise a PR or I can have a stab at it during my next tech debt day at work

any update on this @feywind @bcoe @aabmass ?

+1

Going to revisit it this week. Have to solve it for work :)
On Sun, Feb 20, 2022 at 3:43 PM naseemkullah @.***>
wrote:

+1
—
Reply to this email directly, view it on GitHub
https://github.com/googleapis/nodejs-pubsub/issues/1389#issuecomment-1046265027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABXCIK5RBIXPARJ4MCLTDU4ED2FANCNFSM5DCBVHCA
.
You are receiving this because you commented.Message ID:
@.***>

I came up with this as a workaround (there is a comment in the else clause about what I think this library should provide):
import {Message, PubSub} from '@google-cloud/pubsub';
import {
  ROOT_CONTEXT,
  SpanContext,
  SpanStatusCode,
  trace,
} from '@opentelemetry/api';

const tracer = trace.getTracer('foo');

const pubsub = new PubSub({projectId: 'abc'});

const enableOpenTelemetryTracing = {
  enableOpenTelemetryTracing: true,
};

export async function subcribe() {
  const subscription = pubsub.subscription(
    'testSubscription',
    enableOpenTelemetryTracing
  );

  subscription
    .on('message', (message: Message) => {
      const spanContext = getSpanContext(message);

      if (spanContext === undefined) {
        handleMessage(message);
      } else {
        // it would be convenient if everything in this else clause except
        // for the `handleMessage(message)` logic was provided by the GCP pub/sub library
        // when enableOpenTelemetryTracing is true
        const context = trace.setSpanContext(ROOT_CONTEXT, spanContext);

        tracer.startActiveSpan('handleMessage', {}, context, span => {
          try {
            handleMessage(message);
            span.setStatus({code: SpanStatusCode.OK});
          } catch (err) {
            span.setStatus({
              code: SpanStatusCode.ERROR,
              message: err instanceof Error ? err.message : undefined,
            });
            throw err;
          } finally {
            span.end();
          }
        });
      }
    })
    .on('error', (error: Error) => {
      console.error('Received error:', error);
    });
}

function handleMessage(message: Message) {
  console.log('Received message:', message.data.toString());
  message.ack();
}

function getSpanContext(message: Message): SpanContext | undefined {
  let spanContext: SpanContext | undefined;

  try {
    spanContext = JSON.parse(
      message.attributes['googclient_OpenTelemetrySpanContext']
    );
  } catch (error) {
    spanContext = undefined;
  }

  return spanContext;
}

worth noting, while the message acknowledgment and any processing leading up to it are part of the same trace, the /google.pubsub.v1.Subscriber/ModifyAckDeadline span is still disconnected

The tracker page is still there for me, internally at least. Weird. Anyway, nothing has happened on this yet, but it's increasing in priority right now. Definitely not forgotten.

Yeah, I hope to have a stab at it soon. So far more important stuff at work than this.

You might not want to put too much into it, just because we've got a revamped design for OT that will be rolling out across all the languages, over time. Of note, it's going to propagate the span and context by way of the W3C spec, as well as doing better about "closing the loop" on the subscriber end. We've got a prototype implementation in Go, and that just needs to be expanded across all the languages.
https://github.com/googleapis/google-cloud-go/pull/5034
If you see anything you want in the Node implementation that's missing from the Go one, please feel free to comment!

Yeah, the changes I wanted to propose via PR would be heavily based on the Go implementation :)
Let me know, if you prefer me to wait, that's fine, happy to wait for a Google implementation if it's coming in short term

Great news that this is being fixed! Just spent a day scratching my head as to why my traces were disconnected...

Sorry for the radio silence on this topic, but it's still a major objective for us. None of this is official until it's official (please don't take it as an announcement/promise), but the current thought is that we're planning to shift it to use the more standard mechanism (w3c headers), and to get it piped all the way through. A preview of the Go version produces a really nice graph in Cloud Trace, showing the time spent in each phase of the library (batching, ack leasing, etc). There isn't currently anything that will be traced in the server, but the end to end trace should at least allow you to see how long it spends in the server before being sent out.

Mentioned in the PR, but mentioning here too: there's a suuuuper early preview branch now if anyone wants to play around with what's done. I don't recommend using it in any kind of production scenario or assuming any of the interfaces or trace formats are final.
That PR is here: https://github.com/googleapis/nodejs-pubsub/pull/1659
And the branch in googleapis that anyone can make PRs against if you want: https://github.com/googleapis/nodejs-pubsub/tree/otel-2
I'll be out for a bit but plan to pick it up again in early 2023.

@feywind Just wanted to check in and see how 2023 was treating this work, any updates yet?

Tiny sample size, I admit, but quick survey for those on this thread and wanting OTel support sooner rather than later: do you consider the trace structures and span names to be part of the public interface? Would it break your code if they changed? Or is it just a human debug tool?

@feywind for me it’s a human debug tool:) I am personally not planning to generate metrics from the traces via like otel-collector

Pretty much entirely human debug tool, but mentioning any significant changes in the changelog would be helpful for updating any internal process documentation/etc.

Same here as others have said - only used for some alerting and saved searches in grafana, "production code" doesn't care

Thanks everyone, I appreciate the input. Our main goal for the moment is more of a human debug solution, too, so I think we're all aligned. :) A sort of "soft interface" is an interesting idea, not needing a whole new major as long as updates are mentioned consistently somewhere. That'll be good to take into account.

That #1833 is the version rebased onto main (4.x). I'm planning to get that released and then go back to do any final backporting to 3.x.

Quick update, there are some beta testing instructions over here if anyone is interested.

Has anyone had a chance to try this out? There are a few things that need to be finished up to get this released, but it'll probably be pretty soon.

I have tried it during local development and works pretty well for me!

I have now been trying the beta in GCP but don't get the pubsub message handler requests to the same trace than from where it was triggered. We use @opentelemetry/auto-instrumentations-node and Pub/Sub push subscriptions with Cloud Run instance being triggered from the messages.
I can see that the incoming request body contains eg.
attributes: {
  googclient_traceparent: "00-4dccfee9342c29e33b8fcf484aa52ea9-6b72c4b7d37f4bd0-01"
}

where the trace ID matches the trace ID of the publisher, but the incoming HTTP request traceparent has different trace ID.
Note: I have very little prior OTEL experience but trying now to set up tracing so that incoming request trace would contain everything the request handling caused.

@vesse It seems push subscriptions are slightly out of scope for this first pass. You should be able to pull that googclient_traceparent value and use it for further OpenTelemetry tracing.
I'm not sure exactly what is placing a new traceparent in your HTTP headers, but it's something we'll need to figure out for the push support, so thanks for the heads-up :)

I forgot to post here too: the otel-beta tag is updated to .2 now, which is pretty close to the finished v1.

@AkselAllas Thanks for the note. I'll bring this up with the team.


Feature request: Script should return an error code when the page is down

I stumbled upon this coming from https://github.com/sindresorhus/is-up-cli which inspired this project.
The nice thing about is-up-cli is that it returns a specific error code when the site is down and can therefore be used in automated scripts.
My use case is the following:
I want to check if my self-hosted website is reachable from the internet and otherwise restart the Raspberry Pi where it's hosted. I'm struggling with a few network issues -- which I don't quite understand right now -- that go away when I reboot the Pi.
A simple way to test this is to run the following code in a Shell:
# Do something in case the page is up.
isitup nope.it.isnt && echo "Hell yeah! Everything's fine"

# Do something in case the page is down.
isitup nope.it.isnt || echo "Site is down"

I'd rather like to use this tool as it is written in Python which I understand and have the environment for on every machine. For is-up-cli I would need to install node.js and npm.

I can also implement this myself and send you a pull request.

Sounds good, I'll take a look at the pr in the weekend and ping you back later.


Add an option to panic if relation does not exist

In my current setup when I'm querying a database for a relation that doesn't exist I get a comprehensive error:

back.public> SELECT t.*
FROM public."MyTable" t
LIMIT 501
[2020-07-31 17:00:41] [42P01] ERROR: relation "public.MyTable" does not exist
[2020-07-31 17:00:41] Position: 17

OTOH when I'm querying it via diesel it's happy to return me 0 rows.
It's quite important to me to know if relation is empty or doesn't exist at all.
I'd like to have an option to have some signal of query failing because if this. Panic is good enough for me although someone could argue it's better to make this error recoverable.

Please provide a complete reproducable example, otherwise this issue is not actionable and will be closed.

Hmm, it seems that it actually behave this way. I found what could be a real culprit in this behaviour. Sorry for bothering.


Set-up AppVeyor CI

Was #491 but @jonparrott blew it up, oh noes!
This will allows allow Windows testing

Sounds reasonable.

https://packaging.python.org/appveyor/ and https://github.com/ogrisel/python-appveyor-demo very helpful here

Thank you for creating this issue, however, this project is deprecatedand we will only be addressing critical security issues. You can read moreabout this deprecation here.
If you need support or help using this library, we recommend that you ask yourquestion on StackOverflow.
If you still think this issue is relevant and should be addressed, pleasecomment and let us know!


Fix DPI scaling

Apply DPI scaling in vizia rather than relying on femtovg

(also posting this here for archiving purposes)
Didn't seem to make any difference for the example from #81 at least:

And one potential problem with having to manually multiply font size by a DPI scale is that it's probably very easy to forget to do that when creating widgets, and you'd only notice that when someone tires to use your GUI on a HiDPI screen.


Update docs for adding locations

@shaundon
@d4v3y0rk
Support for this pull req https://github.com/hubot-scripts/hubot-standup-alarm/pull/23  to update the docs to help explain how to use it.

@shaundon Conflict has been fixed


Update Design Kit link to Design Kit Cloud Download (End of Q2) on the website

As an IBM.com Library website adopter

I need a way to download the Design Kit from the Cloud

so that I can have the kit installed and do what I need to do efficiently.

Additional information

@oliviaflory mentioned we will have the Design Kit download path from taking the adopters to the BOX folder to the Cloud download instead.
Timeline: End of Q2

Acceptance criteria

[ ] All Design Kit download paths and links on the website is updated.

Task Update:* Followed up with Olvia earlier today and Design Kit Cloud download is not ready.
@RobertaJHahn Can you help by moving this task to Sprint 20-14? Thank you.


change profile npm-start to yarn-start

looks like there is change from npm to yarn

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


cli: fitactivity fix combine usage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f509f92) to head (b3083b2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #448   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           42        42
  Lines         3660      3661    +1
=========================================
+ Hits          3660      3661    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"Chiuiești" is listed in the drop-down menu

Description:
When user writes "Chiuiești" the location appears in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Chiuiești"
Expected results
The location appears in the drop-down menu as "Comuna Chiuiești, CLUJ"