Time to Ditch requirements.txt and VENV, Start using Poetry now...

Title of the talk
Time to Ditch requirements.txt and VENV, Start using Poetry now...
Description
Requirements.txt is one of the oldest methods to do package management in Python which leads to many issues, but this is no longer an issue because of new updates of Python. Now you can easily manage your Python project all in one place by using Poetry.
Developers are starting to use Poetry since it's easy to use and easily manageable
What format do you have in mind for your talk?
Talk
Table of contents
The talk includes the following points

What is Package management? Requirements.txt
Issues with requirements.txt
How Poetry Solves this Issue
Installation and uses of Poetry
Showcase of Important (Poetry Cmds)
What are .LOCK files? Poetry.Lock
Separating dev and production packages
Creating a Project/Initializing in existing project using poetry
Managing Virtual Env via Poetry
Migrating requirements.txt to poetry.lock

What domain would you say your talk falls under?
Core Python
Duration in minutes (including Q&A)
60
Prerequisites
Python
Speaker bio
Pratik Pathak is a highly accomplished technology professional with a passion for sharing his knowledge and expertise with others. As a Microsoft Certified Trainer, Pratik is dedicated to helping individuals and organizations learn how to harness the power of technology to drive business success. With his extensive experience and in-depth understanding of the latest tools and techniques, Pratik is a valuable resource for anyone looking to take their skills to the next level...
In his leisure time, he takes workshops and seminars for students at No Cost. Pratik believes that sharing his expertise and experience is his way of contributing to the world and empowering the next generation of leaders.
LinkedIn - https://www.linkedin.com/in/pathakpratik/
X - https://twitter.com/zpratikpathak
The talk/workshop speaker agrees to

[X] Share the slides, code snippets and other material used during the talk

[X] If the talk is recorded, you grant the permission to release
the video on BangPyper's YouTube
channel
under CC-BY-4.0
license

[X] Not do any hiring pitches during the talk and follow the Code
of
Conduct

Hi @zpratikpathak
Would you be able to present this talk in Jan 20th meetup?

Count myself in 👍


⚠ ClamAV has degraded performance

In 7d1e08e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 464 ms

Resolved: ClamAV performance has improved in 7197937.


Farsight (forge) is not compatible with Antique Atlas 4

Mod Name
Antique Atlas 4
Mod Homepage
https://modrinth.com/mod/antique-atlas-4
Minecraft version
1.20.1 (LTS)
Describe the bug
In multiplayer the atlas map does not load
Steps to reproduce

Download mod for atlas, connector and farsight
Open the world for friends to come into your world
Observe that one player's map loads, but the other does not. The map is simply frozen and the new territory does not load on it

Logs
There are no logs, as this is an in-game bug.
Additional context
I wrote to the author of the Antique Atlas 4 mod, he said that the problem is in the Farsight mod. I wrote to the author of the Farsight mod, and he said that the problem is in the connector. That's why I'm writing to you!

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.


Add tests for python code in documentation

Description
Add tests for python code in documentation. Adds a new dev dependency: pytest-examples and with that package is a single parameterized pytest in tests/docs/test_docs.py which will automatically search the docs folder for any python code examples in
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Adds documentation tests for python code blocks in any markdown files in the docs folder. The tests are marked as flaky and allowed to fail. When testing the examples, imports for strawberry or the typing packages are automatically included.
Here's the tweet text:
🆕 Release (next) is out! Thanks to David McLaren for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Adds documentation tests for python code blocks in any markdown files in the docs folder. The tests are marked as flaky and allowed to fail. When testing the examples, imports for strawberry or the typing packages are automatically included.
Here's the tweet text:
🆕 Release (next) is out! Thanks to David McLaren for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

I'll see if I can find a solution to making sure the schema matches the python code snippet. I'll also look into seeing if we can test the response as well.

We also need to figure out how to test the examples, prints might be good, but I think they make the snippets quite verbose, but I really like that pytest-examples has a way to print them. We could also do something custom custom for testing schemas, like here: ...

pytest-examples docs do show we can handle prints like so:
print(1 + 2)
#> 3

If you like this I can go ahead and try this out where appropriate. If the syntax doesn't look good we could try assert statements or roll our own syntax like you suggested.
We do reuse a lot of the same structures we could inject some prebuilt data structures into the module namespace when testing to avoid repeat code in each example snippet. For testing schemas, we might be able to similarly use the extracted code examples and be able to compare afterward. I'll poke around and see.

Also I think it is worth spending some time to make this a test that doesn't fail. We could introduce this for just one file (maybe the getting started) or we could try to fix as many things as possible.

I marked them as flaky so it wouldn't block pytest runs but I can remove that and limiting the scope to possibly a file or two with the documentation updated to get started I figured trying to rewrite all the examples all at once might be too much for a single MR. I could tackle this with a string of MRs once we have a solid base to work from.
Thanks for the feedback!

I think for now it would be fine to just go with this:
print(1 + 2)
#> 3

we can make it better in future, I'm afraid I'd do to much bike shedding :D
For the imports, I think it's fine to leave them in, I'll test if we can hide them from the docs side 😊 maybe we do a flag like this:
import strawberry

@strawerry.type
class P:
    a: str

@patrick91 I figured out a way to test python+schema code snippets. I disabled the flaky flag and got all the general docs working. I added a way to keep the global namespace around for code snippets in the same doc file but it relies on global variables which I don't love.
I'm still trying to find a good way to handle graphql+response code snippets.

Never mind I adapted some of the pytest_examples module code to work with other code snippet types. I added another file to demonstrate those checks. It caught some good minor issues already.


css selectors not support

Describe the bug
I use last vitesse example whit ant-desigin-vue which run success in vite dev but get an error in build
xxxxx\node_modules\ant-design-vue\lib\style\default.css:5
[class^=ant-]::-ms-clear,
     ^^

SyntaxError: Unexpected token '^='
   at compileFunction (<anonymous>)
   at Object.compileFunction (node:vm:360:18)
   at wrapSafe (node:internal/modules/cjs/loader:1084:15)
   at Module._compile (node:internal/modules/cjs/loader:1119:27)
   at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
   at Module.load (node:internal/modules/cjs/loader:1033:32)
   at Function.Module._load (node:internal/modules/cjs/loader:868:12)
   at Module.require (node:internal/modules/cjs/loader:1057:19)
   at require (node:internal/modules/cjs/helpers:103:18)

Reproduction
lastest vitesss + antdv + AntDesignVueResolver
System Info
System:
    OS: Windows 10 10.0.22623
    CPU: (12) x64 AMD Ryzen 5 5600H with Radeon Graphics
    Memory: 2.39 GB / 15.36 GB
  Binaries:
    Node: 16.18.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
    npm: 9.2.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.870.0), Chromium (110.0.1587.41)
    Internet Explorer: 11.0.22621.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

You can try this：
// vite.config.ts
export default defineConfig({
// ...,
ssr: {
noExternal: [‘ant-design-vue’],
},
})


twMerge doesn't merge text-inherit and other colors

hey i'm trying to merge twMerge('tw-text-inherit', 'tw-text-blue-500') but it doesn't seem to work. both classes still exist on my element. i thought i could add inherit to the text color class group to force it to work like this
const customTwMerge = extendTailwindMerge({
  prefix: 'tw-',
  classGroups: {
    'text-color': [{ text: ['inherit'] }],
  },
});

but also doesn't change anything.
am i missing something?

nevermind. issue with my reactivity in vue


Issue with appID in getRequest

Hi, I'm new to coding and building a school project that connects to ebay trading. Keep trying to formulate an ebayApiGetRequest with this package but I always seem to run into this error after sending the request.
[SyntaxError: Unexpected token <] .
I've taken out lines individually and it seems to occur whenever I add my personal app id. Project wide search yielding no help. Are there any known issues/conflicts?

Thanks again for the code it fixed my get request issue. The trading issue was silly, using get instead of postxml.

Can someone put a clear example of how to use an affiliate id?


add warning to init.sh

@Claudenw requested that we document this file.
https://lists.apache.org/thread/7p1k49ytrwknbcyjwnj0jo1o00z4hnlw
This file is used in our automated tests. We use docker-compose to start an FTP server and a Squid Proxy server.
https://github.com/apache/incubator-pekko-connectors/blob/a639063ffc41a9cb8f9ba5c11dfd997a6750b3c1/docker-compose.yml#L235

This is mergeable - the build failure is because mima check is broken because the 1.0.2-RC1 is not released - only in staging.


Limit Size of log file

I was just wondering if there are plans to limit the file size of the log file. I don't really need several 600 megabyte log file.

There is: "--log-level" when starting your worker.py

You don't? :crying_cat_face:
Yeah, the best way right now is to use --log-level and set it to WARNING or ERROR.

I cant believe I didn't notice that when I was adding my own custom args. Thanks guys!


discord.Util.resolveString is not a function

I received this error for the first time today and I'm not sure what changed to cause this.
The stack trace is
    at CommandMessage.reply (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/commands/message.js:351:15)
    at Argument.obtainInfinite (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/commands/argument.js:245:29)
    at Argument.obtain (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/commands/argument.js:130:33)
    at ArgumentCollector.obtain (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/commands/collector.js:74:30)
    at CommandMessage.run (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/commands/message.js:160:52)
    at CommandDispatcher.handleMessage (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/dispatcher.js:127:32)
    at CommandoClient.on.message (/Users/me/Documents/DiscordBot/node_modules/discord.js-commando/src/client.js:68:51)
    at emitOne (events.js:115:13)
    at CommandoClient.emit (events.js:210:7)

My current solution is to change discord.Util.resolveString to this.client.resolver.resolveString(content).
Please let me know if there are any issues with this.

If you are on 11.1, you should use the 11.1 commando branch.


[lens-person] Remove get and set methods

The methods were unused. Discussion here

@Cool-Katt I think you're supposed to have write-access. @ErikSchierboom do you know why they don't?

@Cool-Katt I think you're supposed to have write-access. @ErikSchierboom do you know why they don't?

I thought so too, but I realized I never tried merging anything until now, so here we are. I think it's because the role that's given to exercism/javascript is triage so basically like write access but no merging of PRs, as I understood from the docs.

As far as I'm concerned you should get rights given the fact you accepted the maintainer position. Can you ping the peeps in your maintainer acceptance issue about this?

I think it's because the role that's given to exercism/javascript is triage

It was this. Fixed now.


Update to latest Minio helm chart

fixes https://github.com/kubernetes/charts/issues/6351

Is there any specific reason tide and pull-charts-e2e are waiting for last few days? tide seems to be waiting for some manual review but other one seems to be a automated routine which should have finished by now I guess?

/assign @prydonius

Closing this as Spinnaker chart is already updated


Hover tips interfere with editor text selection

Issue Report Checklist

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
The hover hints interfere with highlighting text.

What steps reproduce the problem?

Activate a hover
Click and drag to highlight
Can't see the highlighting

What is the expected output? What do you see instead?

Another problem is that hover tips crash on 4.0.0rc2+MacOS 10.11.6. The crash does not affect Spyder, only hover tip itself.

Another problem is that hover tips crash on 4.0.0rc2+MacOS 10.11.6. The crash does not affect Spyder, only hover tip itself.

@liuyigh please write a separate issue for this with an error traceback and a reproducible code example so we can keep track of the error.

#10852 issue submitted. Thanks!

@goanpeca, what do you think we could do about this one?

I think that if the hover windows disapapere if the user clicks in the editor that would be one way to solve it

I agree that the hover should probably disappear on any key press. This should be a very easy fix.

@goanpeca I forgot to mention that the hover is also activated while the mouse button is held down as well. See my second gif.
Would it be possible to disable hovers tips while the mouse button is depressed as well?

Would it be possible to disable hovers tips while the mouse button is depressed as well?

Absolutely! that is a silly UX :-p this one is probably on me 😆


[gainput] build failure

Host Environment

OS: Linux
Compiler: gcc7

To Reproduce
Steps to reproduce the behavior:
./vcpkg install gainput
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
Command failed: /home/craipy/vcpkg-2021.05.12/downloads/tools/cmake-3.20.2-linux/cmake-3.20.2-linux-x86_64/bin/cmake /home/craipy/vcpkg-2021.05.12/buildtrees/gainput/src/v1.0.0-52a00a4a7c.clean -DGAINPUT_BUILD_SHARED=OFF -DGAINPUT_BUILD_STATIC=ON -DGAINPUT_TESTS=OFF -DGAINPUT_SAMPLES=OFF -DCMAKE_MAKE_PROGRAM=/home/craipy/vcpkg-2021.05.12/downloads/tools/ninja-1.10.1-linux/ninja -DCMAKE_SYSTEM_NAME=Linux -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/home/craipy/vcpkg-2021.05.12/scripts/toolchains/linux.cmake -DVCPKG_TARGET_TRIPLET=x64-linux -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/home/craipy/vcpkg-2021.05.12/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/home/craipy/vcpkg-2021.05.12 -D_VCPKG_INSTALLED_DIR=/home/craipy/vcpkg-2021.05.12/installed -DVCPKG_MANIFEST_INSTALL=OFF -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/home/craipy/vcpkg-2021.05.12/packages/gainput_x64-linux/debug
Working Directory: /home/craipy/vcpkg-2021.05.12/buildtrees/gainput/x64-linux-dbg
Error code: 1
See logs for more information:
/home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-out.log
/home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:332 (vcpkg_execute_required_process)
ports/gainput/portfile.cmake:22 (vcpkg_configure_cmake)
scripts/ports.cmake:142 (include)
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

Pleae provide the following logs:
/home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-out.log
/home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-err.log

Pleae provide the following logs: /home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-out.log /home/craipy/vcpkg-2021.05.12/buildtrees/gainput/config-x64-linux-dbg-err.log

config-x64-linux-dbg-err.log
config-x64-linux-dbg-out.log

CMake Error at CMakeLists.txt:16 (if):
  if given arguments:

    "LESS" "6.1"

  Unknown arguments specified

CMAKE_SYSTEM_VERSION is empty which caused this issue.

... and "6.1" would ask for VERSION_LESS.

Thank you so much!
I have installed gainput successfully.
I add the following to vcpkg/triplets/x64-linux.cmake
set(VCPKG_CMAKE_SYSTEM_VERSION 20.2)


Replacement files

Coverage increased (+0.9%) to 83.862% when pulling 7c2e223d663b97777e6c679100c6e581fbaa078e on replacement_files into 7c2e473ad965d74dca8e8540b902df543295b191 on master.


[FLINK-9897][Kinesis Connector] Make adaptive reads depend on actual run loop frequency and not on fetch interval millis

What is the purpose of the change
FLINK-9692 introduced the feature of adapting maxNumberOfRecordsPerFetch based on the average size of Kinesis records. The PR assumed a maximum of 1/fetchIntervalMillis reads/second. However, in the case that the run loop of the ShardConsumer takes more than fetchIntervalMillis to process records, the maxNumberOfRecordsPerFetch is still sub-optimal. The purpose of this change is to make the adaptive reads more efficient by using the actual run loop frequency to determine the number of reads/second and maxNumberOfRecordsPerFetch. The change also re-factors the run loop to be more modular.
Brief change log

processingStartTimeNanos records start time of loop
processingEndTimeNanos records end time of loop
adjustRunLoopFrequency() adjusts end time depending on sleepTimeMillis (if any).
runLoopTimeNanos records actual run loop time.
adaptRecordsToRead calculates maxNumberOfRecordsPerFetch based on runLoopTimeNanos
Unused method getAdaptiveMaxRecordsPerFetch is removed.

Verifying this change
This change is already covered by existing tests, such as ShardConsumerTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Why not submit this PR to the apache repo?

@tweise I created the upstream Flink PR - https://github.com/apache/flink/pull/6408 . I will close this PR. We can cherry-pick the upstream PR once its' merged.


add utp listener addresses to the 0.4.0 bootstrap nodes

would be pretty cool to start field testing this

yes! :+1:
@whyrusleeping i think we'll have to change how the bootstrap list is used? because right now the bootstrap process assumes each line is a different node. what we should do is:

add every line as one address to a peer (addrs)
this yields some set of peers (where len(peers) <= len(addrs))
when bootstrapping, sample peers (not addrs)

i think we'll have to change how the bootstrap list is used?

Yeah that's also a prerequisite for #88

Pluto now speaks utp: /ip4/<IP_ADDRESS>/udp/4002/utp/ipfs/QmSoLPppuBtQSGwKDZT2M73ULpjvfd3aZ6ha4oFGL1KrGM
I'll update two more bootstrappers in a bit (saturn and uranus).


Make status reasons Camel-Case

Camel-Case-style status reasons are generally preferred.

Looks like the tests are failing and need to be updated for these changes.
Would you use able to update them and squash your commits? Then this is good to go.

I fix the tests. Now all tests are green.

Thanks @takebayashi!


Update search function

Slightly smaller than #5 Add advanced functionality - searches shouldn't have to hit consecutive words, but should be prioritized higher if they do.
If any word is a substring match, you have a match
Also, while here, use <mark> instead of  <strong> and style highlights on body and header differently
Prior Art

Previous

Updated


add cdn info

Decided not to add this since there are many other CDNs, and if I add one I'll end up having to add them all. I may eventually add a link to unpkg.com as I feel that is a better solution than most CDNs (it's based on npm), but for now, I'll leave it as-is


Polygon subdivision

Something like PostGIS's ST_Subdivide would be nice to have, where it takes a polygon and converts it into a multipolygon based on some criterion.
See https://postgis.net/docs/manual-3.4/ST_Subdivide.html

This would actually be super easy to do with cut - just keep cutting the polygon into pieces via gridlines, and then wrap the resulting vector of polygons in a multipolygon!


New ISO-8583 Sampler plugin version

With correct JSON syntax ;)

I experience the same 404 locally, that is found by Travis CI. Please take a look.


Request: Deep link to specific stories and substories

http://localhost:9001/stories/Button/SubmitButton or something

Duplicate:  https://github.com/kadirahq/react-storybook/issues/6
Currently this is implemented in the mantra branch and we could release it today or tomorrow.

Nice! Thanks @arunoda!


Update documentation for configuration

Polish wording.
Originally submitted by @BitYog as https://github.com/hexojs/hexojs.github.io/pull/5

👍

Thanks for the contribution 👍


Update Hamburger Menu controls to support swipe to show on Narrow Status

Is this really a good idea? won't it get in the way of controls mistakenly placed UNDER this rectangle?

Did you remember that the menu could be on the Right?

Yes. It may happen.  i will implement it using customize splitview to do it.
any suggestion from you?

在 2016年4月15日，上午12:23，Jerry Nixon<EMAIL_ADDRESS>写道：
Did you remember that the menu could be on the Right?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Just not convinced this is a good idea. Is it?

Are there risks that it could swallow interaction activities destined for the content area? Drag and drop, swipe to change pivot, etc.?

please reject this pull request , I will implement it by other solution , customize splitview .

在 2016年4月27日，上午4:24，Jerry Nixon<EMAIL_ADDRESS>写道：
Just not convinced this is a good idea. Is it?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Unifying Resource Path Contents Into Single Page

Currently, both Handling Resource Path and Handling Authentication talk in depth about resource paths.
With the exception of "Excluding Required Parameters from your Data Source Path", these two pages have approximately the same text describing resource paths, so largely duplicate each other.
This PR places a merge of the two page's contents on this topic into the resource path page and removes resource path content from the authentication page.
Thinking that 1 source for content on this topic is better than two.

@ptyx507x - Can you review this PR? The changes are so extensive that the content should be moved to the private repo for validation checks. Let us know if you need help doing this.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ShannonLeavitt we need an engineer to review these code changes. Could you please assign this to @mattmasson ?

#assign: @mattmasson

The conflicts are too hard to resolve. The changes would need to be repeated on a fresh copy of main branch.
@bgribaudo we'll pull this branch internally and try to fix the branch in a piecemeal fashion to avoid the numerous conflicts.
#assign:dougklopfenstein
Thanks!  Jason

Thanks, @JasonWHowell. Anything I can do to help with this?

@bgribaudo we have quite a backlog of work right now, so sorry we're slow.
If you have time though, this change has to be redone from scratch, since the conflicts are too difficult to pick apart. I'd close this PR and start fresh with a copy from the "main" branch. There were too many changes done before this one got merged, unfortunately.
Thanks, Jason

A separate private pull request was created because of the numerous conflicts that have occurred over time in this pull request. The new pull request is listed above. That pull request has been merged into the documentation, so this private pull request is now redundant and is closed.

Thank you, Doug!


[ZF3] RFC (kind of): optionable objects

Hi,
This issue is a more general reflexion on how we could help using options using the service manager (@weierophinney: to some extent, this is an explanation of my previous PR for introducing a ProvidesOptionsTrait, so I'd prefer to talk about what I had in mind before ;-)).
As of today, the service manager makes it very hard to work with objects that need options. Such objects include routes, filters, validators, some view helpers... well nearly every object needs to be configured with a set of options.
Currently, service manager has no way to configure a created instance with options. Plugin managers on the other hand, introduced a concept of "creationOptions", but it has a very strange behaviour: it is pass as the constructor for invokables only, while for factories it used to do nothing until my hacky PR for ZF 2.2 that allowed to inject the options.
This issue tries to provide a clean and simple solution.
Interfaces
A new interface would be created either in Zend\Stdlib or Zend\Config. I've thought about "Zend\Stdlib\OptionsAwareInterface" or "Zend\Stdlib\OptionableObject".
Here is the interface:
interface OptionsAwareInterface
{
    public function setOptions(array $options);
}

Modification to the service manager / plugin manager
Get and Create method would accept another parameter, which is an options array. After creating the object, the SM would check if the object is OptionsAware:
public function get($name, array $options = array())
{
    $object = // create object

    if ($object instanceof OptionsAwareInterface) {
        $object->setOptions($options);
    }
}

There is one question: what happen when using a shared object? Should we reset the options or not?
Traits
Then, we would have some traits for simplifying the options for object. Those traits would make some assumptions about the naming scheme:
trait ProvidesSetterOptions
{
    public function setOptions(array $options)
    {
        foreach ($options as $key => $value) {
            $inflectedKey = str_replace('_', '', $value);

            $setter = 'set' . $inflectedKey;
            if (method_exists($this, $setter)) {
                $this->$setter($value);
                continue;
            }

            $isser = 'is' . $inflectedKey;
            if (method_exists($this, $isser)) {
                $this->$isser($value);
           }
    }
}

Only drawback of this trait is that it could overwrite some other properties that are not options, so we could have some kind of "restrictedProperties" array inside the trait.
We could also have a built-in trait that uses internally an options array where all the options are stored, that directly uses public properties.
What do you think of this solution for solving the issue of options object inside a plugin manager/service manager?

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


ArrayPorts assignment order changes  randomly between runs

For example, for this FBP network:
AirSensorProp PROP -> DATA[0] ContextA
WindowProp PROP -> DATA[1] ContextA
MotionProp PROP -> DATA[2] ContextA
The resulting assignment can be:
AirSensorProp PROP -> DATA[2] ContextA
WindowProp PROP -> DATA[0] ContextA
MotionProp PROP -> DATA[1] ContextA

Reproducible with flow:
'0' -> IN[0] Mux(core/joiner)
'1' -> IN[1] Mux(core/joiner)
'2' -> IN[2] Mux(core/joiner)
'3' -> IN[3] Mux(core/joiner)
Mux OUT -> IN Log(core/console)
Results in (after several runs):
Mux     | Data from port IN[3]: "0"
Mux     | Data from port IN[0]: "1"
Mux     | Data from port IN[1]: "2"
Mux     | Data from port IN[2]: "3"

After quick tests, the update seems to have fixed the issue.


Sample request: retrieving related work items

This issue is effectively reopening #113, resolved by a sample in the Snippets folder that does not exist any more.
Requesting a sample that shows how to retrieve related work items, such as the parent, children, successor, etc.

I think that https://github.com/microsoft/azure-devops-dotnet-samples/blob/master/ClientLibrary/Samples/WorkItemTracking/WorkItemsSample.cs#L545 is the correct url for that sample :)


new version

Hi, could we please get a version released now that #4315 is merged? Thanks

yes. coming soon.

5.0.13 has been released.

thanks a lot!


The user name or password is incorrect

When I try to run this tool as domain admin I get a "The user name or password is incorrect" error. Any ideas on how to fix? Running on Windows 10

turned out to be an issue with my OS, tried another server and seems to be working now.


Switch to json_serializable for Dart 2 compatibility

Dart 2 JSON Support
json_serializable

I was experiencing issues in my Flutter installation related to agilord/owl#4
I also updated the README with instructions for rebuilding JSON models.

@rinukkusu Huh, Travis is saying:
Package build_runner has no versions that match >=0.8.10 <0.9.0 derived from:
- spotify depends on version ^0.8.10

But that version exists...
Does some Travis cache need cleaning, perhaps?

I think this has to do with the Dart SDK constraints from the json_serializable and build_runner packages. Running mediator yields:
✗ Found 1 dependency conflict:
You are running Dart SDK version 1.24.3 (Mon Dec 18 16:57:48 2017) on "linux_x64".
  * spotify requires SDK >=1.20.1 <2.0.0
  * json_annotation requires SDK >=2.0.0-dev.54.0 <2.0.0
  * json_serializable requires SDK >=2.0.0-dev.54 <2.0.0
  * http requires SDK >=2.0.0-dev.61.0 <3.0.0
  * build_runner requires SDK >=2.0.0-dev.54 <2.0.0
  * test requires SDK >=2.0.0-dev.54.0 <2.0.0
  * json_serializable->path requires SDK >=2.0.0-dev.62.0 <2.0.0
  * json_serializable->source_gen requires SDK >=2.0.0-dev.19.0 <2.0.0
  * test->async requires SDK >=2.0.0-dev.23.0 <2.0.0
  * build_runner->dart_style requires SDK >=2.0.0-dev.62.0 <2.0.0
  * json_serializable->build requires SDK >=2.0.0-dev.9 <2.0.0
  * build_runner->build_config requires SDK >=2.0.0-dev.54 <2.0.0
  * http->collection requires SDK >=2.0.0-dev.55.0 <2.0.0
  * build_runner->build_runner_core requires SDK >=2.0.0-dev.54 <2.0.0
  * build_runner->build_resolvers requires SDK >=2.0.0-dev.32 <2.0.0
  * build_runner->shelf requires SDK >=2.0.0-dev.61.0 <2.0.0
  * build_runner->mime requires SDK >=2.0.0-dev.20.0 <2.0.0
  * test->matcher requires SDK >=2.0.0-dev.17.0 <2.0.0
  * build_runner->stream_transform requires SDK >=2.0.0-dev.20.0 <2.0.0
  * build_runner->pool requires SDK >=2.0.0-dev.17.0 <2.0.0
  * test->io requires SDK >=2.0.0-dev.54 <3.0.0
  * test->shelf_web_socket requires SDK >=2.0.0-dev.17.0 <2.0.0
  * test->http_multi_server requires SDK >=2.0.0-dev.55.0 <3.0.0
  * test->boolean_selector requires SDK >=2.0.0-dev.58 <3.0.0
  * test->source_maps requires SDK >=2.0.0-dev.17.0 <2.0.0
  * json_serializable->analyzer requires SDK >=2.0.0-dev.48.0 <2.0.0
  * build_runner->crypto requires SDK >=2.0.0-dev.17.0 <3.0.0
  * build_runner->code_builder requires SDK >=2.0.0-dev <2.0.0
  * build_runner->yaml requires SDK >=2.0.0-dev.49.0 <2.0.0
  * test->package_resolver requires SDK >=2.0.0-dev.17.0 <2.0.0
  * build_runner->watcher requires SDK >=2.0.0-dev.61.0 <2.0.0
  * build_runner->build_config->pubspec_parse requires SDK >=2.0.0-dev.54 <2.0.0
  * test->shelf_web_socket->web_socket_channel requires SDK >=2.0.0-dev.23.0 <2.0.0
  * test->vm_service_client requires SDK >=2.0.0-dev.58.0 <2.0.0
  * json_serializable->analyzer->kernel requires SDK >=2.0.0-dev.48.0 <2.0.0
  * json_serializable->analyzer->html requires SDK >=2.0.0-dev.17.0 <2.0.0
  * test->stream_channel requires SDK >=2.0.0-dev.17.0 <2.0.0
  * build_runner->code_builder->built_collection requires SDK >=2-0-0-dev <2.0.0
  * build_runner->code_builder->built_value requires SDK >=2.0.0-dev <2.0.0
  * test->shelf_packages_handler->shelf_static requires SDK >=2.0.0-dev.61.0 <3.0.0
  * json_serializable->analyzer->html->utf requires SDK >=2.0.0-dev.20.0 <2.0.0
  * json_serializable->analyzer->html->csslib requires SDK >=2.0.0-dev.17.0 <2.0.0
  * test->vm_service_client->json_rpc_2 requires SDK >=2.0.0-dev.17.0 <2.0.0
  * json_serializable->analyzer->front_end requires SDK >=2.0.0-dev.48.0 <2.0.0
Done at 2018-07-14 10:56:15.272476.

So i guess we need to switch to the dev channel in the .travis.yml file.

Well, owl supposedly works with Dart 2 now... I haven't gotten around to testing that yet.
Now I'm not sure this port was entirely necessary. Though, json_serializable does have greater ecosystem reach not to mention more Google folks backing it.
Why did you decide to go with owl in the first place?

When I started with this project I wasn't aware of json_serializable and I had already worked with owl on other projects, so this was my choice 😄
But I don't mind using json_serializable as well - seems like it's not that scary anymore.

@rinukkusu just out of curiosity, is the PR going to merged soon? It would be nice, to get this library working with Dart 2.

Hi @hayribakici, it's merged and published - sorry for the wait :smile_cat:


[tests] Fix Evaluation logging test which broke on mono

Failing test:
	Microsoft.Build.UnitTests.Evaluation.EvaluationLogging_Tests.GivenOneProjectThereShouldBeOneStartedAndOneEndedEvent [FAIL]
	  Shouldly.ShouldAssertException : Shouldly uses your source code to generate its great error messages, build your test project with full debug information to get better error messages
	  The provided expression
		  should start with
	  "Evaluation started"
		  but was
	  "Property reassignment: $(MSBuildFrameworkToolsRoot)="\Microsoft.NET\Framework\" (previous value: "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono") at "
	  Stack Trace:
		  at Shouldly.ShouldlyCoreExtensions.AssertAwesomely[T] (T actual, System.Func`2[T,TResult] specifiedConstraint, System.Object originalActual, System.Object originalExpected, System.Func`1[TResult] customMessage, System.String shouldlyMethod) [0x00056] in <cd631af7e9d7403ea1721c3ce03185bf>:0
		  at Shouldly.ShouldBeStringTestExtensions.ShouldStartWith (System.String actual, System.String expected, System.Func`1[TResult] customMessage, Shouldly.Case caseSensitivity) [0x00014] in <cd631af7e9d7403ea1721c3ce03185bf>:0
		  at Shouldly.ShouldBeStringTestExtensions.ShouldStartWith (System.String actual, System.String expected) [0x00000] in <cd631af7e9d7403ea1721c3ce03185bf>:0
		  at Microsoft.Build.UnitTests.Evaluation.EvaluationLogging_Tests+<>c.<GivenOneProjectThereShouldBeOneStartedAndOneEndedEvent>b__4_0 (Microsoft.Build.Evaluation.Project project, Microsoft.Build.UnitTests.MockLogger firstEvaluationLogger) [0x00033] in <559c19036a814aa4b96da7f3191f05ee>:0
		  at Microsoft.Build.UnitTests.Evaluation.EvaluationLogging_Tests.AssertLoggingEvents (System.Action`2[T1,T2] loggingTest, Microsoft.Build.UnitTests.MockLogger firstEvaluationLogger, System.Func`2[T,TResult] reevaluationLoggerFactory) [0x000d3] in <559c19036a814aa4b96da7f3191f05ee>:0
		  at Microsoft.Build.UnitTests.Evaluation.EvaluationLogging_Tests.GivenOneProjectThereShouldBeOneStartedAndOneEndedEvent () [0x00009] in <559c19036a814aa4b96da7f3191f05ee>:0
		  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
		  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <b60d3e0e49a1407283b1fb67d86fa164>:0

Recent commit:
commit 7150dc9643fbb2651f973e0cf7efcbfe31a8b806
Author: Matt Neely<EMAIL_ADDRESS>Date:   Mon Aug 19 13:59:31 2019 -0700

	Adding tracking of properties with relevant events. (#4461)
	...

.. changed how property changes get logged, causing the following to show up in
the logs, when running the test on mono:
Property reassignment: $(MSBuildFrameworkToolsRoot)="\Microsoft.NET\Framework\" (previous value: "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono") at

.. before the Evaluation started line, causing the test to break.
Instead of making assumptions about the exact message strings, we can check for
exactly the events that we are interested in -
ProjectEvaluationStartedEvent and ProjectEvaluationFinishedEvent.

@maneely can you investigate why this behavior changed with your PR, please?

This is the FullLog for the netcore run:
Evaluation started ("/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpebe2c9f495734fa9a945061e806373a3.tmp")
Property reassignment: $(P)="Bar" (previous value: "Foo") at /var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpfff20064d105411db723be3988143501.tmp (9,23)
/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpebe2c9f495734fa9a945061e806373a3.tmp(10,21):  warning MSB4011: "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpfff20064d105411db723be3988143501.tmp" cannot be imported again. It was already imported at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpebe2c9f495734fa9a945061e806373a3.tmp (9,21)". This is most likely a build authoring error. This subsequent import will be ignored.
Overriding target "Foo" in project "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpebe2c9f495734fa9a945061e806373a3.tmp" with target "Foo" from project "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpfff20064d105411db723be3988143501.tmp".
The target "Y" listed in a BeforeTargets attribute at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpfff20064d105411db723be3988143501.tmp (4,29)" does not exist in the project, and will be ignored.
The target "X" listed in an AfterTargets attribute at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpfff20064d105411db723be3988143501.tmp (3,29)" does not exist in the project, and will be ignored.
Evaluation finished ("/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/32rsevtv.jej/tmpebe2c9f495734fa9a945061e806373a3.tmp")

And for the mono test run:
Property reassignment: $(MSBuildFrameworkToolsRoot)="\Microsoft.NET\Framework\" (previous value: "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono") at
Evaluation started ("/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmp7e2bdcf37567486a958f0f274603dfc0.tmp")
Property reassignment: $(P)="Bar" (previous value: "Foo") at /var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmpa302d14501bf4bcab1dcf72461df4e69.tmp (9,23)
/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmp7e2bdcf37567486a958f0f274603dfc0.tmp(10,21):  warning MSB4011: "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmpa302d14501bf4bcab1dcf72461df4e69.tmp" cannot be imported again. It was already imported at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmp7e2bdcf37567486a958f0f274603dfc0.tmp (9,21)". This is most likely a build authoring error. This subsequent import will be ignored.
Overriding target "Foo" in project "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmp7e2bdcf37567486a958f0f274603dfc0.tmp" with target "Foo" from project "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmpa302d14501bf4bcab1dcf72461df4e69.tmp".
The target "Y" listed in a BeforeTargets attribute at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmpa302d14501bf4bcab1dcf72461df4e69.tmp (4,29)" does not exist in the project, and will be ignored.
The target "X" listed in an AfterTargets attribute at "/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmpa302d14501bf4bcab1dcf72461df4e69.tmp (3,29)" does not exist in the project, and will be ignored.
Evaluation finished ("/var/folders/7c/zpmy8k_d4d1grky_s154kk640000gp/T/tmp7e2bdcf37567486a958f0f274603dfc0.tmp")

Maybe, in the mono case this particular property is being updated before the evaluation begins or is logged to have begun? https://github.com/microsoft/msbuild/blob/master/src/Build/Evaluation/Evaluator.cs#L1199

Does something set this in the environment too? If it's set in the environment and then also set in the code that'll be a "reassignment".

@maneely no, nothing in the environment. Our app.config is a bit different btw - https://github.com/mono/msbuild/blob/mono-2019-06/src/MSBuild/app.config#L77-L104 but that doesn't set the property either.
I only glanced at the code, so I could be wrong, but isn't the event being logged (https://github.com/microsoft/msbuild/blob/master/src/Build/Evaluation/Evaluator.cs#L645) after that property is set (https://github.com/microsoft/msbuild/blob/master/src/Build/Evaluation/Evaluator.cs#L631) . Note that on mono, the value of that property is different and so, is probably getting set to the new value here(https://github.com/microsoft/msbuild/blob/master/src/Build/Evaluation/Evaluator.cs#L1199).

It's certainly set in AddBuiltInProperties. Since those are the first properties added, I'd assume this is the initial value set. Afterwards comes the Environment properties, Toolset properties, and Global properties. So either AddBuiltInProperties is somehow called twice (don't see how), then the MSBuildFrameworkToolsRoot property must be coming from one of them: environment, toolset, or global. I'm not sure how these are affected by the Mono environment.


Testing dist installations

Affected Issues

Fixes #

Proposed Changes

Codecov Report

Merging #203 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #203   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          18     18
  Lines         461    461
  Branches       43     43
=====================================
  Hits          461    461

Coverage remained the same at 100.0% when pulling 1771388ee62d47d7d669c556ecb0ae39646e8786 on test-dist into 74cbdbe09bff38994d43cd1820b323294869e6d4 on master.

Coverage remained the same at 100.0% when pulling 1771388ee62d47d7d669c556ecb0ae39646e8786 on test-dist into 74cbdbe09bff38994d43cd1820b323294869e6d4 on master.

Coverage remained the same at 100.0% when pulling 1771388ee62d47d7d669c556ecb0ae39646e8786 on test-dist into 74cbdbe09bff38994d43cd1820b323294869e6d4 on master.

Coverage remained the same at 100.0% when pulling 1771388ee62d47d7d669c556ecb0ae39646e8786 on test-dist into 74cbdbe09bff38994d43cd1820b323294869e6d4 on master.


pip install dependancy conflict on Raspbian Pi 4

When trying to install via pip3 install piper-tts I get this error:
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Requirement already satisfied: piper-tts in /home/pi/.local/lib/python3.9/site-packages (1.2.0)
Collecting piper-tts
  Using cached piper_tts-1.2.0-py3-none-any.whl (29 kB)
  Using cached piper_tts-1.1.0-py3-none-any.whl (27 kB)
ERROR: Cannot install piper-tts==1.1.0 and piper-tts==1.2.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    piper-tts 1.2.0 depends on piper-phonemize~=1.1.0
    piper-tts 1.1.0 depends on piper-phonemize~=1.0.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

Any idea how to fix this?

same issue here

Use Python 3.9

similar issue with python3.9
yiminghan@raspberrypi:~/Documents/speak_server $ python3.9 -m pip install piper-tts
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting piper-tts
  Obtaining dependency information for piper-tts from https://files.pythonhosted.org/packages/24/aa/215bced0725cf5b5afe939f86b177c8ddb0d38292a94e85c55b3fcf6d46d/piper_tts-1.2.0-py3-none-any.whl.metadata
  Using cached piper_tts-1.2.0-py3-none-any.whl.metadata (776 bytes)
INFO: pip is looking at multiple versions of piper-tts to determine which version is compatible with other requirements. This could take a while.
  Obtaining dependency information for piper-tts from https://files.pythonhosted.org/packages/2e/1c/cc3a342db7f03053eca4fa5b05362178a5a796115770b216740b733b24d7/piper_tts-1.1.0-py3-none-any.whl.metadata
  Using cached piper_tts-1.1.0-py3-none-any.whl.metadata (776 bytes)
ERROR: Cannot install piper-tts==1.1.0 and piper-tts==1.2.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    piper-tts 1.2.0 depends on piper-phonemize~=1.1.0
    piper-tts 1.1.0 depends on piper-phonemize~=1.0.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

yiminghan@raspberrypi:~/Documents/speak_server $ python --version
Python 3.9.2
yiminghan@raspberrypi:~/Documents/speak_server $
yiminghan@raspberrypi:~/Documents/speak_server $ pip3 --version
pip 23.2.1 from /home/yiminghan/.local/lib/python3.9/site-packages/pip (python 3.9)

What happens if you try to install piper-phonemize alone?

Not sure if that helps anybody else, but I did a clean install of Rasbian 64bit desktop and on that it worked on first try.

I'm interested in trying to get this working on windows, I but I understand this probably means I'd need to do a whole-ass port myself. Never done this before, but it seems like a good thing to learn how to do. Before I dive into what changes to the code I might need to make before attempting to use VS build tools though, might the devs know off the top of their heads where the main pain points might be?

What happens if you try to install piper-phonemize alone?

it looks like piper-phonemize is not being resolved
python3 -m pip install piper-phonemize~=1.1.0
ERROR: Could not find a version that satisfies the requirement piper-phonemize~=1.1.0 (from versions: none)
ERROR: No matching distribution found for piper-phonemize~=1.1.0

@yiminghan Can you please run this?
python3 -m pip install -vvv piper-phonemize

I'm interested in trying to get this working on windows, I but I understand this probably means I'd need to do a whole-ass port myself. Never done this before, but it seems like a good thing to learn how to do. Before I dive into what changes to the code I might need to make before attempting to use VS build tools though, might the devs know off the top of their heads where the main pain points might be?

A Windows version of Piper already exists; the piper-phonemize Python package just needs to be built for Windows too.

Same issue, tried running python3 -m pip install -vvv piper-phonemize
result:
user@raspi:~ $ python3 -m pip install -vvv piper-phonemize
Using pip 23.2.1 from /home/user/.local/lib/python3.9/site-packages/pip (python 3.9)
Defaulting to user installation because normal site-packages is not writeable
Created temporary directory: /tmp/pip-build-tracker-rigi73g6
Initialized build tracking at /tmp/pip-build-tracker-rigi73g6
Created build tracker: /tmp/pip-build-tracker-rigi73g6
Entered build tracker: /tmp/pip-build-tracker-rigi73g6
Created temporary directory: /tmp/pip-install-ztcet92u
Created temporary directory: /tmp/pip-ephem-wheel-cache-g4761d8f
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
2 location(s) to search for versions of piper-phonemize:

https://pypi.org/simple/piper-phonemize/
https://www.piwheels.org/simple/piper-phonemize/
Fetching project page and analyzing links: https://pypi.org/simple/piper-phonemize/
Getting page https://pypi.org/simple/piper-phonemize/
Found index url https://pypi.org/simple/
Looking up "https://pypi.org/simple/piper-phonemize/" in the cache
Request header has "max_age" as 0, cache bypassed
Starting new HTTPS connection (1): pypi.org:443
https://pypi.org:443 "GET /simple/piper-phonemize/ HTTP/1.1" 304 0
Fetched page https://pypi.org/simple/piper-phonemize/ as application/vnd.pypi.simple.v1+json
Skipping link: none of the wheel's tags (cp310-cp310-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/41/e8/ae6a5f5d23b7f35d29927bedc796e50d9c41ff03a2e3267100bdaeb3ba09/piper_phonemize-1.0.0-cp310-cp310-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp310-cp310-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/9f/ef/71ba1cc30d8f5d9d98797e75ee1b9e096053ae83ad275eadee8a02303ddd/piper_phonemize-1.0.0-cp310-cp310-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp311-cp311-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/ed/02/0b68b01b4c3db09ea7daef6f20f8f9b9d2bf2e3dc5e6bacd09db034d54fd/piper_phonemize-1.0.0-cp311-cp311-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp311-cp311-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/d7/e3/e337d412d3afd10d929d4b43ceb8aa37a244a9821049e598e7dcfcbd50ea/piper_phonemize-1.0.0-cp311-cp311-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp39-cp39-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/7e/15/7dcf261a3ed1c800605198950c236bcfcf988063a220dedcb31e9f795817/piper_phonemize-1.0.0-cp39-cp39-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp39-cp39-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/21/7e/531eaccb5794681c262d71f1d1017a24b37077154e3b02dd7eb883ea4fcf/piper_phonemize-1.0.0-cp39-cp39-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp310-cp310-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/66/ca/65e4cee554554a648af9cca6ce4ab7f14ea9ea62f1d77b2f53fbcf3329e4/piper_phonemize-1.1.0-cp310-cp310-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp310-cp310-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/e9/e0/17c224e4a2a78c7fdd7c0a680693b1753293384ddfe860550950ed9b7e97/piper_phonemize-1.1.0-cp310-cp310-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp311-cp311-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/6f/eb/02440084802648a3e074c0db9a72dfbbce35f4110ed3db085129d5dca7bc/piper_phonemize-1.1.0-cp311-cp311-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp311-cp311-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/b8/b7/a8fc2584d509ca36d5713693d675a88f80e4c3725e16a8c7ff1451f0ba99/piper_phonemize-1.1.0-cp311-cp311-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp39-cp39-manylinux_2_28_aarch64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/af/2d/bd071a6d73c7faab15d36fca90a2dd6245e03e40454dee5a13538cf223a6/piper_phonemize-1.1.0-cp39-cp39-manylinux_2_28_aarch64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Skipping link: none of the wheel's tags (cp39-cp39-manylinux_2_28_x86_64) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/32/8b/c480d8d4e71fcbcf2ff9fe574ead95ad96b63886acbdff4dc70479ff2bcd/piper_phonemize-1.1.0-cp39-cp39-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/piper-phonemize/) (requires-python:>=3.7)
Fetching project page and analyzing links: https://www.piwheels.org/simple/piper-phonemize/
Getting page https://www.piwheels.org/simple/piper-phonemize/
Found index url https://www.piwheels.org/simple/
Looking up "https://www.piwheels.org/simple/piper-phonemize/" in the cache
Request header has "max_age" as 0, cache bypassed
Starting new HTTPS connection (1): www.piwheels.org:443
https://www.piwheels.org:443 "GET /simple/piper-phonemize/ HTTP/1.1" 200 115
Updating cache with response from "https://www.piwheels.org/simple/piper-phonemize/"
etag object cached for 1209600 seconds
Caching due to etag
Fetched page https://www.piwheels.org/simple/piper-phonemize/ as text/html
Skipping link: not a file: https://www.piwheels.org/simple/piper-phonemize/
Skipping link: not a file: https://pypi.org/simple/piper-phonemize/
Given no hashes to check 0 links for project 'piper-phonemize': discarding no candidates
ERROR: Could not find a version that satisfies the requirement piper-phonemize (from versions: none)
ERROR: No matching distribution found for piper-phonemize
Exception information:
Traceback (most recent call last):
File "/home/user/.local/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 397, in resolve
self._add_to_criteria(self.state.criteria, r, parent=None)
File "/home/user/.local/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 174, in _add_to_criteria
raise RequirementsConflicted(criterion)
pip._vendor.resolvelib.resolvers.RequirementsConflicted: Requirements conflict: SpecifierRequirement('piper-phonemize')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/user/.local/lib/python3.9/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 92, in resolve
result = self._result = resolver.resolve(
File "/home/user/.local/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 546, in resolve
state = resolution.resolve(requirements, max_rounds=max_rounds)
File "/home/user/.local/lib/python3.9/site-packages/pip/_vendor/resolvelib/resolvers.py", line 399, in resolve
raise ResolutionImpossible(e.criterion.information)
pip._vendor.resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=SpecifierRequirement('piper-phonemize'), parent=None)]
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/user/.local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 180, in exc_logging_wrapper
status = run_func(*args)
File "/home/user/.local/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 248, in wrapper
return func(self, options, args)
File "/home/user/.local/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 377, in run
requirement_set = resolver.resolve(
File "/home/user/.local/lib/python3.9/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 101, in resolve
raise error from e
pip._internal.exceptions.DistributionNotFound: No matching distribution found for piper-phonemize
Remote version of pip: 23.2.1
Local version of pip:  23.2.1
Was pip installed by pip? True
Removed build tracker: '/tmp/pip-build-tracker-rigi73g6'
user@raspi:~ $

Are you on a 32-bit OS?

it's 64-bit:
user@raspi:~ $ uname -m
aarch64

Ok, and what glibc version? Can you run "ldd --version" and give the output please?
This has to be it 😄

what version would be correct? here we go:
user@raspi:~ $ ldd --version
ldd (Debian GLIBC 2.31-13+rpt2+rpi1+deb11u5) 2.31
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
user@raspi:~ $

I'm seeing the same issue on MacOS (ARM64).

I have the same issue on windows 11 with python 3.10.11:
> pip install piper-tts
Collecting piper-tts
  Downloading piper_tts-1.2.0-py3-none-any.whl (29 kB)
INFO: pip is looking at multiple versions of piper-tts to determine which version is compatible with other requirements. This could take a while.
  Downloading piper_tts-1.1.0-py3-none-any.whl (27 kB)

The conflict is caused by:
    piper-tts 1.2.0 depends on piper-phonemize~=1.1.0
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

> pip install git+https://github.com/rhasspy/piper#egg=piper-tts&subdirectory=src/python_run
Collecting piper-tts
  Cloning https://github.com/rhasspy/piper to c:\users\user\appdata\local\temp\pip-install-7uvxeiv3\piper-tts_09ae3c53db4e47cdaf6187e381d03204
  Running command git clone --filter=blob:none --quiet https://github.com/rhasspy/piper 'C:\Users\User\AppData\Local\Temp\pip-install-7uvxeiv3\piper-tts_09ae3c53db4e47cdaf6187e381d03204'
  Resolved https://github.com/rhasspy/piper to commit 54fad0445ac9b7e734753fcb149c259caf1c0e30
  Preparing metadata (setup.py) ... done
INFO: pip is looking at multiple versions of piper-tts to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement piper-phonemize~=1.1.0 (from piper-tts) (from versions: none)
ERROR: No matching distribution found for piper-phonemize~=1.1.0

Just did a bit more reading - it's very likely I what I installed is "Our recommended operating system for most users" (from https://www.raspberrypi.com/software/operating-systems/) which is the "32-bit" OS, but that now uses the 64-bit kernel (v 6.1), hence the confusion.
Worth noting then that the uname etc. on 32-bit Raspberry Pi OS installs now report aarch64, even though they'll still be running everything 32-bit. file /bin/ls will tell you if you're on actual 64-bit or not.
So I guess I'll need to decide whether a reinstall is worth the effort.

whoaa! thx for pointing out! could u let us now, if u get it to work with a reinst? atm i'm short of time to try myself..

Confirmed that it works fine with the actual 64-bit install of Rasperry Pi OS.

just installed the correct 64bit-version of Raspberry Pi OS and install of piper-tts was successful. it can be used with existing voices.
thx again!


Add page icon and custom emoji object

Adds the custom emoji object as per https://developers.notion.com/reference/emoji-object
and adds the icon prop to databases and pages.

LGTM


Fix amalgamation failure.

Referring to issue #14808
amalgamation predict api fails when loading a network. The error messages are attached.
mxnet_predict-all.cc:32818: Check failed: reg != nullptr: Cannot find pass MXPlanMemory in the registry

However, changing MXPlanMemory to PlanMemory would not resolve the issue. Because amalgamation uses tvm/nnvm. and mxnet core engine uses its own customized nnvm version.
Simply using tvm/nnvm/plan_memory would cause Check failure.
mxnet_predict-all.cc:4289: Check failed: strcmp(type_->ptype_info->name(), typeid(T).name()) == 0: The stored type name mismatch stored=NSt3__16vectorIN5mxnet6TShapeENS_9allocatorIS2_EEEE requested=NSt3__16vectorIN4nnvm6TShapeENS_9allocatorIS2_EEEE

Therefore I added mxnet/nnvm to the C predict API amalgamation list.
And refactored some names to avoid redeclaration.

Solution to the problem:
add. #include "src/nnvm/plan_memory.cc" to mxnet_predict0.cc
Refactor PlanMemory -> MXPlanMemory in mxnet/src/nnvm
Refactor FindBestPath -> MXFindBestPath in mxnet/src/nnvm
Refactor ColorNodeGroup -> MXColorNodeGroup in mxnet/src/nnvm
Refactor GetDTypeSize -> MXGetDTypeSize in mxnet/src/nnvm
Refactor GraphAllocator -> MXGraphAllocator in mxnet/src/nnvm
Refactor AllocMemory -> MXAllocMemory in mxnet/src/nnvm

@Roshrini @pengzhao-intel Please review this change as soon as possible. This is an important fix.

@ZhennanQin @TaoLv  to help review this change :)

Can you elaborate more? What's the mxnet customized nnvm version?

Because amalgamation uses tvm/nnvm. and mxnet core engine uses its own customized nnvm version.

Also, do you think we need unit case to cover this issue?

@TaoLv I think amalgamation does need a lot of unit testing. Because it is basically broken right now. We did a lot of bash script to modify the codes for building on each platform. There is a ${mxnet_root}/src/nnvm which is used by the predict API and MXNet core. When building amalgamation this customized version is not included, ${mxnet_root}/3rdparty/tvm/nnvm is used instead. However,3rdparty/tvm/nnvm does not work when running any test.
So I have to include ${mxnet_root}/src/nnvm and avoid conflicts. In previous edits PlanMemory is already changed to MXPlanMemory. I followed the same convention to change other variable names.
In the future, I think there should be only one nnvm dependency in 3rd party directory. This is the ultimate solution.
My solution is temporary that works.

To reproduce the error. Simply load a model and perform forward prediction on Mac with amalgamation static/shared build. Basically, it doesn't work. @TaoLv

@TaoLv Check out our work at (BrainCoTech/mxnet-prebuild)[https://github.com/BrainCoTech/mxnet-prebuild/releases]. It's still at early stage but this allows us to run a mxnet model in the same code on multiple platforms. We are working on automated Windows desktop builds now.

Thank you for the explanation and your project looks awesome! @adis300
@szha can you help to review the change? I'm not familiar with the amalgamation issue. But overall the changes for function name look good to me. Not sure if there are any backward compatibility concern.

Just a side question, have you ever tried MXNet MKL-DNN build in your project? @adis300

@TaoLv We just tried a general mxnet build with make and most works are on amalgamation without MKL-DNN. Because we want to run our python generated models on all desktops/mobile platforms with the same C code. We are working on Windows amalgamation builds now and will try MKL-DNN very soon.

@eric-haibin-lin Can you please take a look at this PR. It is an important bug fix and has been there for half a month. The current master branch basically doesn't run c_predict_api.h forward pass.

@eric-haibin-lin @TaoLv Could you please review this PR? Thanks!

@TaoLv Any updates?

As I said here: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-508154569, the changes look good me. But I still think you need get approval from more experienced committer. @szha @eric-haibin-lin @wkcn Do you have any idea?
PS: Could you please rebase the code? I can see the last run of CI is more than one month ago. I can approve if it passes.

@TaoLv I rebased the branch. Windows test failed because installing numpy failed. This is not caused by the codes I changed. Everything else passed.

@marcoabreu @TaoLv I have just rebased the feature onto the latest master branch and resolved related conflicts.


Renew Action is missing in OperationActionEnum for webhook

"Renew" Action is missing in OperationActionEnum for webhook
check model  Microsoft.Marketplace.SaaS.Models.OperationActionEnum.
and check https://learn.microsoft.com/en-us/azure/marketplace/partner-center-portal/pc-saas-fulfillment-webhook. here Renew action is there
Expected behavior
Renew Action enum should be available

We are facing the same issue. Client.Operations.GetOperationStatusAsync is not able to serialize the response from Marketplace V2 api at all in case OperationStatus=Renew. A quick fix would be highly appreciated.

Fixed in #58


Fix syntax highlighting of INI language

Fix #2161: syntax highlighting of INI language doesn't parse comments present on same line.

Hi everybody,
I choose this issue as an "easy hack" to enter Pygments code and logic.
Please do not hesitate to guide me were I'm wrong.

Thank you!

Thanks for merging!


Alternative 1 - revert 411cee67fe3f8242023eb8d9edafefbbfb2d06f1

This reverts commit 411cee67fe3f8242023eb8d9edafefbbfb2d06f1.

This PR is the prefered alternative to #174. Merge either #175 or #174, but not both.

@windwp What case of use do 2ee3496748cb4284d75c88b9f4e116bfe2dac872 cover?


Different beautification for js and json

Is there a way to have different beautification rules for .js and .json files in the same .jsbeautifyrc file.
For example my use case is 4 indent_size for js and 2 for json

Interesting idea.  It does not exist at this time.  You can work around by assigning the value on the command-line when you calll the beautifier.  Not hard to do, but also not high priority.

@thaiat not sure your use-case, but in case you're looking for a temporary work-around - I use another library for json formatting.  jsonlint to be exact

@olsonpm does it have an integration with sublime ?
My use case is that i use HTML/CSS/JS Prettify plugin in sublime and before i save the file i do Shift+Cmd+H to run beautify on the current file.

I don't use sublime, but this package seems like it fits your needs:
https://packagecontrol.io/packages/Pretty JSON

@olsonpm nice thks!!!

Related: #391.


chore: added more of personal_sign test cases

Summary of Changes
Based on conversations in Discord support channel I've added more personal_sign test cases as a redundancy.
Test Data or Screenshots
By submitting this pull request, you are confirming the following:

I have reviewed the Contribution Guidelines.
I have performed a self-review of my own code.
I have updated my repository to match the develop branch.
I have included test data or screenshots that prove my fix is effective or that my feature works.
I have checked that all tests work and swiftlint is not throwing any errors/warnings.

Nice! LGTM - assuming those TODOs will be done some other time.

I think I'll add them as a separate PR but based on this branch.

@janndriessen I've decided I'll push related changes regarding these TODOs into this PR.

@JeneaVranceanu LGTM. It's required a second review though, ping me if you're wishing to force merge it.


Add IBM Granite 3.1

IBM just released their Granite 3.1 models, a series of language models with 128K context length trained by IBM licensed under Apache 2.0 license.

https://huggingface.co/collections/ibm-granite/granite-31-language-models-6751dbbf2f3389bec5c6f02d

Thanks for the suggestion. We have added the test results of 8 IBM Granite 3.1 series models to the leaderboard.

Awesome, thanks!


[FEATURE REQUEST] Implement log rotation for PGBouncer

Is your feature request related to a problem? Please describe.
Configure pgbouncer to write logs in standard location searched by filebeat. Also configure log and log rotation to limit log size for pgbouncer.
Describe the solution you'd like
Please see how it's done for Postgres, search what needs to be logged and for how long logs should be stored.
Describe alternatives you've considered
Additional context
Same basic knowledge about log rotation and pgbouncer:
https://www.redhat.com/sysadmin/setting-logrotate
https://www.enterprisedb.com/postgres-tutorials/pgbouncer-logs-rotation-linux-and-windows-tutorial
<EMAIL_ADDRESS>(old, but might be useful)

I was able to deploy epiphany, with separated HA PostgreSQL machine. To enable pgbouncer log rotation, we need to add the following code into our main build YAML file:
`yaml
kind: configuration/postgresql
title: PostgreSQL
name: default
specification:
config_file:
parameter_groups:
(...)
extensions:
pgaudit:
enabled: yes
(...)
pgbouncer:
enabled: yes
replication:
enabled: yes
(...)
repo.
config: |-
/var/log/postgresql/postgresql*.log {
maxsize 10M
daily
rotate 6
copytruncate
# delaycompress is for Filebeat
delaycompress
compress
notifempty
missingok
su root root
nomail
# to have multiple unique filenames per day when dateext option is set
dateformat -%Y%m%dH%H
}
/var/log/postgresql/pgbouncer.log {
missingok
notifempty
sharedscripts
copytruncate
size 10M
create 0640 postgres postgres
nodateext
postrotate
/bin/kill -HUP cat /run/postgresql/pgbouncer.pid 2>/dev/null 2> /dev/null || true
endscript
}
`

PGBouncer log rotation, and sending logs into ELK stack works properly on Ubuntu host.
Will check the RedHat deployment now.

Checked on Azure - logs can be rotated, and they're pushed into ELK. Kibana is able to access those logs.

PR #1823

Some suggestions after reverting the PR.
RHEL

We have rotation configured out of the box (provided by rpm package), the config file is: /etc/logrotate.d/pgbouncer. I think we can keep it as is without making it configurable.
The log file path is different than on Ubuntu, i.e /var/log/pgbouncer/pgbouncer.log. It's not handled by filebeat, so we need add it to filebeat.yml.j2 as it was in the PR.

Ubuntu
Option 1.
We could reuse RHEL's config file (provided by rpm package) but this would require:

Change logfile in /etc/pgbouncer/pgbouncer.ini to use the same location as on RHEL.
Change 'pidfile' in the same file.
Create /var/log/pgbouncer directory if needed.
Check whether pgbouncer user should be created (since it's present in the config file).
Option 2.
Use RHEL's config file as base for separate (in Epiphany sources) adjusted to Ubuntu specific configuration.

Both:
I don't think we need multi-line support in Filebeat but checked only on Ubuntu and haven't found any multi-line entries.
The logrotate config should not be concatenated to /etc/logrotate.d/postgresql but stored in separate file /etc/logrotate.d/pgbouncer.

new PR created

I found an issue with duplicate log entries for PgBouncer on Ubuntu. This is because in the filebeat configuration for PostgreSQL the path /var/log/postgresql/*.log* was specified first, and then /var/log/postgresql/pgbouncer.log* for PgBouncer, and the second path is included in the first, which leads to multiplication.
cat /etc/filebeat/filebeat.yml

# -------------------------- PostgreSQL input --------------------------

# Filebeat postgresql module doesn't support custom log_line_prefix (without patching), see https://discuss.elastic.co/t/filebeats-with-postgresql-module-custom-log-line-prefix/204457
# Dedicated configuration to handle log messages spanning multiple lines.

- type: log
  enabled: true
  paths:
    - /var/log/postgresql/*.log*
  exclude_files: [".gz$"]
  multiline:
    pattern: '^\d{4}-\d{2}-\d{2} '
    negate: True
    match: after

- type: log
  enabled: true
  paths:
    - /var/log/postgresql/pgbouncer.log*
  exclude_files: [".gz$"]

The issue with duplicate log entries for PgBouncer on Ubuntu fixed in PR #1896.

@przemyslavic Can we move this to test again?

In test.


Cascading config files

cascading config files and a new way to specify heating seasons (and cooling seasons)

@daren-thomas great stuff, would there be an arcgis interface for this?

@JIMENOFONSECA this will tie into everything eventually. Yes. Of course an ArcGIS interface for user / project / scenario configuration. But also this is a place to store the last chosen options for each tool :-)
This PR doesn't actually change the functionality of the CEA yet - it is just exploring how to make the config files work and is the basis for slowly removing functionality from gv and adding it to these config files. I expect to do that one issue at a time to avoid a huge mega-branch as that has proven to interrupt our flow.

@daren-thomas cool, we merge it then. I am ok with the documentation too.


[EN] Separate HassSetPosition into domains

Following our French colleagues' initiative (#2002), I've split HassSetPosition in the 2 domains that support it, so that we can have greater detail for the cover domain, such as targeting a specific device_class (which is the only supported particularization, for now).

can we get some more sentences that hardcode the word blinds

I'm not sure I follow @balloob
Doesn't {cover_classes:device_class} do just that without the hard-coding? What's indeed missing is area-awareness (i.e. context-to-slot injection for both referencing by just name and just device_class) and maybe some area-agnostic device_class calls, although who says "set all blinds everywhere to 60%"?

@tetele When I leave home, I set all the blinds to 10% so that even the cat can see something :D
I do this with a automation, but it could well have a justification.


Build unified-env with oneAPI 2024 compilers (aka many packages don't build with oneAPI compilers)

Describe the bug
This is in addition to the wgrib2 issue I posted (#967).
There's a list of packages that don't build with the oneAPI compilers 2024.0.2. Updated list after switching to ifx instead of ifort (because the Python meson builder doesn't accept spack compiler flags and trips over the deprecation messages from ifort):
ai-env-1.0.0-juvu3nik2oqc3tyl3xcsgo7nglecfk2c
ewok-env-1.0.0-cx4jzlczhau3qk45vza3omszgy62a5bd
fms-2023.04-tn6g4hdumwnbwhlykds5acbd7toocgfk
gdal-3.8.3-p6iatrs32e6q7hrkmolzxgvfu6nctxhq
gfsio-1.4.1-mcg3mb3qmgrsaan5tvfjsnkquukg4zd7
global-workflow-env-1.0.0-upb53g4iru5anqukigiw6l3vpc2ey22p
gmao-swell-env-1.0.0-cquu3az5m4hg2b3n2pcijqbhqekf4ccl
grib-util-1.3.0-fbhkry6znyjhgsp34etba7f77utvsohe
gsi-env-1.0.0-dtodfhlos6a5juvha7tug5n7ju4onmz2
jedi-base-env-1.0.0-m5cg44j276uvy6q6vagwgseuv2hqhhv5
jedi-fv3-env-1.0.0-x5s5xtq3bjlngkfyzryaghhxwadae2q3
jedi-geos-env-1.0.0-2wipr3k7iqzb5y5tnho4zczo4c24gvds
jedi-mpas-env-1.0.0-rs5xmdtqjlpj4xtpslqdcm6hg5ovlbi2
jedi-neptune-env-1.0.0-4z7kdwdn6pkxzldlfqppuhpy6fmllmjx
jedi-tools-env-1.0.0-pmzcvsyysygcebfixepaasxlkh3gnfnb
jedi-ufs-env-1.0.0-vt7pgktu5u4jjpy3uhd7jhkdsfeq6fhx
jedi-um-env-1.0.0-4dlsyqaozn5sibyndryflco7vsq243bj
landsfcutil-2.4.1-z7io4g7ccdfhjfewmzdyfrhxjdlxfxri
mapl-2.40.3-f2pmar2sy3sfsivampru23kl5sm6b6ld
met-11.1.0-wfkyd4kqjzkavjqcftvvhvasg3um7efz
metplus-5.1.0-4z353ifekeymyxf2iggimmjcbomai3g5
py-cartopy-0.21.1-2bwaccqbxmjq4o7g4uwwfn34wvolhv2c
py-networkx-3.1-ow75t7mfx6f4ukptwjtv3j3g3dops7na
py-pandas-1.5.3-qpvhapy7fywnusiugkb5tjpj5dynt7na
py-torch-2.1.2-h4bubyoloaxtkwzf7tdn5jui2n662rcw
py-xarray-2023.7.0-tjvaimmrsrc62lpcvallnz4szjo25hie
sfcio-1.4.1-mjvs2ifapl6ulr3aeuibec3o4qwo6quv
sigio-2.3.2-hiv4tdfwdmwt6ubl54b4no6i25i4jysh
soca-env-1.0.0-iklom4kp3topbddcuyzibwalbzdmedwm
ufs-pyenv-1.0.0-pnhke3ht6rtcndfcl7jzkso54exzjxnz
ufs-srw-app-env-1.0.0-arz4cg54i7pprqqedvsn4obfpu364ury
ufs-weather-model-env-1.0.0-lvj3mp2kufgr2wwo26b2q6lj5vrc2ffe
w3nco-2.4.1-cfrrf6gpqqhcquijv4wf5i3a3u3pasph
wgrib2-2.0.8-qlozqyttr5xmme4ox42xoyhosjy3xe3s

Note that some of these failures look like weird bison/flex parsing errors - maybe bison/flex need to be fixed instead?
To Reproduce
Build unified-environment with oneAPI 2024.0+ compilers
Expected behavior
Entire stack builds with oneAPI compilers
System:
AWS ParalleCluster (Ubuntu 22.04) using OS<EMAIL_ADDRESS>as backend and Intel oneAPI 2024.0.2 (icx, icpx, ifx)
Additional context
n/a

@climbfuji is this only happening on the AWS ParalleCluster (Ubuntu 22.04) or other machines, too? i do recall some bison issues with scotch, at least.

I don't have access to any other machine with oneapi 2024.0.2 installed at the moment (and no time to test this elsewhere unfortunately)

This is a duplicate of https://github.com/JCSDA/spack-stack/issues/912 - I added the information from this epic (969) to 912 as a comment, closing 969 as "not planned".


npm install @exponent/react-native-navigator --save failed

npm ERR! Darwin 14.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "@exponent/react-native-navigator" "--save"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code E404
npm ERR! 404 Not Found: @exponent/react-native-navigator
npm ERR! 404
npm ERR! 404 '@exponent/react-native-navigator' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'MyProject'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/sungongren/Desktop/Henry/study/React-Native/MyProject_0.14.0_mac_react-native.cn/npm-debug.log

Hi-
You're using too old of a version of node/npm, and so the @username/module syntax isn't supported.
Upgrade to something like node v4.2.2 (I recommend using https://github.com/creationix/nvm ) and this should be fixed.
C

thx

Actually, I see you're using a recent version of node, I'm not sure why this is happening.

@sparkdreamstudio are you connecting to the main npm server and not a mirror?

i connect to a mirror

I'm not sure there's much we can do to help you. I recommend asking the maintainers of the mirror to make sure they are mirroring all of the modules in the main npm server.

OK,thx


[Import] Add "skip file" import option to skip (and exclude from export) importable formats, auto set it for the images used by bitmap font.

As mentioned in https://github.com/godotengine/godot/pull/87971 and https://github.com/godotengine/godot/issues/82254, bitmap fonts use external images, but can't use these images as external resources since in many cases image preprocessing is required.
This PR:

Adds "skip file" import option to skip (and exclude from export) importable formats (e.g, images).
Automatically set "skip file" import mode for the images used by bitmap font, to prevent exporting these images twice (as source Image/Texture2D end embedded processed image in the fontdata).

(e.g. source .blend files when you already have a .glb for the same scene).

oh yeah please

Thanks!


fix: LDAP button is hidden when no LDAP service is being used

Description of PR

What component(s) does this PR affect?

[x] Back-End (Node.js, Next.js)
[x] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Node.js, Next.js)
[ ] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Related Issue

Resolves #
Solution

Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

)`>>>)>

@CuriouzK0d3r LGTM, have you tested with a test LDAP server and without? Can you log-in fine using the test LDAP service we have? If you deactivate it is the button hidden?

Follow-up: tests seem to fail https://github.com/FORTH-ICS-INSPIRE/artemis-web/runs/4874427162?check_suite_focus=true so probably this requires some debugging before approval. Could you double-check?

@CuriouzK0d3r LGTM, have you tested with a test LDAP server and without? Can you log-in fine using the test LDAP service we have? If you deactivate it is the button hidden?

Yeah I tested! Sorry though, I intended the pr to be a  draft :(


PyPI package

Congratulations on the awesome job :sunglasses:
This library is exactly what I need to build a component for Home Assistant to display my cameras in my home automation dashboard and that doesn't require access to anything else than the Unifi Video instance (compared to the current uvc integration that requires access to individual cameras).
Can you publish this on PyPI? This is a requirement.
Thanks!

PyPI release shouldn't be a problem, assuming I haven't misunderstood what's involved. I'll try to get to it sometime in the coming week.

Should be up now (under the name unifi-video). I'll keep this open for now because I'm sure I managed to screw something up; please let me know when you've had time to try it.

Works great! Nice job. :star2:


[feat] add uber-go/zap for logger

ref: uber-go/zap

As a general library, is it necessary to define the logging framework?


[FORMATTING] Formatter inserts space in between @ operator in mariadb dialect

Input data
Which SQL and options did you provide as input?
CREATE USER newuser@localhost;

Expected Output
CREATE USER newuser@localhost;

Actual Output
CREATE USER newuser @localhost;

Having an extra space before the @ sign doesn't break the execution but it just doesn't look nice.  The same thing happens even if I wrap it inside backticks. i.e.
CREATE USER `newuser` @`localhost`;

Usage

How are you calling / using the library?

import { formatDialect, mariadb } from 'sql-formatter'

export function formatSQL(v) {
  return formatDialect(v, { dialect: mariadb, tabWidth: 2, keywordCase: 'upper' })
}

What SQL language(s) does this apply to? mariadb
Which SQL Formatter version are you using? 15.3.2

Thanks for reporting.
The formatter thinks that @localhost is a variable and formats it accordingly. This user@host syntax is kinda tricky to handle as it's specific to very few SQL statements. As this thankfully doesn't make the SQL invalid, it's unlikely that it'll get fixed by me. Especially as I'm avoiding any new feature development on this library.


Chi Square Distribution & Pi Approximation Error

Hello,
What happened to these heuristics mentioned in http://www.devttys0.com/2013/06/differentiate-encryption-from-compression-using-math/?

This was eventually removed, but the code is still available in older releases: https://github.com/ReFirmLabs/binwalk/releases/tag/v2.1.1
See the binwalk-2.1.1/src/binwalk/modules/heuristics.py file.


consider inotify as a replacement for manual/polling scans of folders

Near the end of src/docs/usage-nextcloud.md, for instance, it advises the reader to configure a periodic scanner to check for changes to a folder.
Have you considered using inotify?  Setting up inotify will eliminate the need for cronned scans or manual scanning.
Low-priority, but maybe consider it?

It's currently not supported but it would be a nice addition.
I'll transfer the issue to the main repository.


Never Roll 1s out of Combat

Having a few dedicated trickery/perception/etc characters is nice, flubbing rolls on 1s does not. Rolling 20s out of combat always is to trivializing as well. So never auto-failing via 1s would be nice.
CGNefarious suggested having an always 10 as well, but if I were to request only one I'd say no 1s is better (for me).

Just to point out, natural 1s don't auto fail skill or ability checks. The only out of combat thing they potentially auto fail is saves.

I would suggest "roll with advantage out of combat" per character ?

@Red-Kai That would probably be more useful than the suggestion as natural 1's don't really have any impact outside of combat other than saves.

CGNefarious suggested having an always 10 as well, but if I were to request only one I'd say no 1s is better (for me).

The thing is that Take 10 is something that's actually core to skill usage, unless distracted (as happens in combat); you basically can always Take 10 outside of combat, and many you can even Take 20 with as well so long as there's no issue on failure. Disable Device aka lockpicking is a very common one in that catagory, as is Perception, since many people would rather go slow, probing the ground every 5 feet, than get hit by a trap or rush past some loot they'd miss otherwise. Here's the rules, as a refresher: https://roll20.net/compendium/pathfinder/Taking 10 and Taking 20#content

@wallweasels I don't see much difference between you rolling a 1 and a 2 outside of combat. Skill checks aren't auto failed on 1s. If a check would be failed on a 1, it's just as likely to be failed on a 2 or a 3. The take 10 suggestion or advantage actually makes way more sense.


Register Existing Component: Add GitHub to host type dropdown

Hey, I just made a Pull Request!

When registering an existing component, it auto detects but also has a drop down to select your provider.  GitHub was missing from the drop down, though the note under the URL box suggested it would be available and the code does support it. For now, add this to the static drop down.
I also alphabetized the list so as to avoid preference. 😁

Where it currently is used as the default scm provider:
https://github.com/spotify/backstage/blob/5ff5b1325d671de166ca2f5284cdd141ac68d120/plugins/register-component/src/components/RegisterComponentPage/RegisterComponentPage.tsx#L83-L92
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

I will note as a potential reason to not approve this: given the auto-detection exists and it seems to well, I almost wonder if from a product perspective there is value any longer of even providing the host drop down for selection?  Are there edge cases where the auto-detect may not behave as designed?

#3144 removes the select, so this is not needed anymore 😄

We're actually removing all of this like you mentioned in this PR in favour of just using URL. #3144 removes it :)

@fox32 beat me to it

ha ha - great, cheers guys!!


Feature: Finding parent of a node from post-order traversal

Finding parent of a node from post-order traversal
Given the height of tree finding the parent of a particular node from post order traversal.
I'd like to add this code in python.

hey @nikita24383 can I contribute to this issue

hello! @adityjoshi i apologize but I'd like to work on this issue


spreads break if closing > on new line

This works:
      <Hero
        url="something.jpg"
        slogan="yo"
        {...@props} />

But this doesn't
      <Hero
        url="something.jpg"
        slogan="yo"
        {...@props}
      />

Fixed in v3.0.1

Thanks!


Coreos REBOOT_STRATEGY=off not work

cat /etc/coreos/update.conf
GROUP=stable
REBOOT_STRATEGY=off
cat /etc/os-release
NAME=CoreOS
ID=coreos
VERSION=1122.2.0
VERSION_ID=1122.2.0
BUILD_ID=2016-09-06-1449
PRETTY_NAME="CoreOS 1122.2.0 (MoreOS)"
ANSI_COLOR="1;32"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"
Coreos  REBOOT_STRATEGY=off not work , I need help
Coreos  REBOOT_STRATEGY=off not work , I need help
Coreos  REBOOT_STRATEGY=off not work , I need help

Locksmith coordinates reboots after updates, you're turning that part off. update-engine.service can still download updates to be used on next boot; there are other sources for the reboot.
https://github.com/coreos/bugs/issues/161


Destroy wysiwyg

It's any method to destroy wysiwyg?
I think you should add it to API :)

+1

+1

+1

+1

+1

+1

As a temporary solution we can use property onlyRead(true); like this:
$(element).wysiwyg('shell').readOnly(true);
$(element).removeClass('wysiwyg-editor').unwrap();


etcd 2.3.6, cannot rebuild the cluster from the backup wal

Bug reporting
I am trying to rebuild a three nodes etcd cluster from the backup wal file.
env
$ etcdctl -version
etcdctl version 2.3.6
$ uname -a
Linux SZX1000254594 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
restore script
my rebuild screipt :
$ pwd
/var/lib/etcd
$cat rebuild.sh
service etcd stop
rm -rf backup && mv -f <IP_ADDRESS> backup &&  mkdir <IP_ADDRESS>
etcdctl backup --data-dir backup --backup-dir <IP_ADDRESS>
service etcd start
step 1:  I change the etcd conf file:
$ cat /etc/default/etcd
ETCD_OPTS='-force-new-cluster -data-dir=/var/lib/etcd/<IP_ADDRESS> -name=<IP_ADDRESS> -listen-client-urls=http://<IP_ADDRESS>:2379 -listen-peer-urls=http://<IP_ADDRESS>:2380 -advertise-client-urls=http://<IP_ADDRESS>:2379 -initial-advertise-peer-urls=http://<IP_ADDRESS>:2380'
step 2:
$sh rebuild.sh
etcd stop/waiting
etcd start/running, process 69724
step3, check:
$ etcdctl cluster-health
member 5aab64a5fb01 is healthy: got healthy result from http://<IP_ADDRESS>:2379
cluster is healthy
$ etcdctl member list
5aab64a5fb01: name=<IP_ADDRESS> peerURLs=http://localhost:7001,http://localhost:2380 clientURLs=http://<IP_ADDRESS>:2379 isLeader=true
step4, try add a node to the cluster:
$etcdctl member add <IP_ADDRESS> http://<IP_ADDRESS>:2380
Added member named <IP_ADDRESS> with ID c7059fa5aa489ac9 to cluster
ETCD_NAME="<IP_ADDRESS>"
ETCD_INITIAL_CLUSTER="<IP_ADDRESS>=http://localhost:7001,<IP_ADDRESS>=http://localhost:2380,<IP_ADDRESS>=http://<IP_ADDRESS>:2380"
ETCD_INITIAL_CLUSTER_STATE="existing"
you can see the ETCD_INITIAL_CLUSTER is not correct , and if I start a new node on <IP_ADDRESS> withe the given parameters, it can not find th leader node.
Actually I find the result is random, sometime I can get the correct ETCD_INITIAL_CLUSTER env when a add new member.
Any ideas?
/Regards
Yu Wang

Restore will default the peer advertise address to localhost. The restore guide notes that the peer advertise address should be updated before adding new members.

@heyitsanthony  thank you for your quick response. I believe sometime I can get the expected result even if I do not use member update but I cannot reproduce it now.
Anyway, I write the script blow and make it work as expected:
leader_ip=<IP_ADDRESS>

service etcd stop
cd /var/lib/etcd
rm -rf backup && mv -f $leader_ip backup &&  mkdir $leader_ip
etcdctl backup --data-dir backup --backup-dir $leader_ip
service etcd start

sleep 5

leader=$(etcdctl member list|cut -f 1 -d ' '|cut -f 1 -d ':')

echo leader: $leader

etcdctl member update $leader http://$leader_ip:2380

echo cluster health
etcdctl cluster-health

echo member list
etcdctl member list

Closing since this appears resolved.


allow building for Windows from Windows

change to using cross platform version of os.getenv
use command prompt to run xz when building from Windows.

How are you testing things?  I've been building the release for the cli_example just for Windows under both Windows and Debian to make sure they both still work.

I have a Windows Server 2016 VM that I test builds on -- but it's manual and entirely prone to errors by hand and the environment certainly is not clean. I'd really like to set up some continuous testing on GH actions soon, to build confidence in prep to publishing this thing to Hex!


"feat: :sparkles: hardcoded tally support"

"This pull request adds hardcoded support for Tally, including changes to import statements, environment variables, and code related to Tally functionality. It also includes the addition of a new component called TallyInfo, which retrieves and displays information about a Tally proposal. The TallyInfo component uses the TALLY_API_KEY environment variable to make API requests to the Tally GraphQL API. The pull request also includes the addition of a new function called getTallyInfo, which fetches Tally information for a given proposal ID. Finally, the pull request includes the addition of a new GraphQL query called TALLY_QUERY, which retrieves Tally proposal information based on the proposal ID and governor ID."

PR Frozen until Phase 2
This was a POC, but keeping it around for inspiration until we are ready to try Tally Integration again.


Change rotate props

I do not think we are using rotation anywhere, right?
I currently am using it for another issue, but I could change the property to angles with the package update because there aren't any other repos using it.

@Slaviiiii we should accept both rotation and angles in the <Rotate /> component


arm template not loading

Does this occur consistently?
Repro steps:

Action: Language Server Error
Error type: Error
Error Message: The connection to the ARM Template Language Server got closed.
Version: 0.15.12
OS: linux
OS Release: 6.5.0-1025-azure
Product: Visual Studio Code
Product Version: 1.94.1
Language: en

Call Stack
extension.bundle.js:29:183968
callWithTelemetryAndErrorHandlingSync extension.bundle.js:16:245746
WrappedErrorHandler.closed extension.bundle.js:29:183851
LanguageClient.handleConnectionClosed extension.bundle.js:16:167509
LanguageClient.handleConnectionClosed extension.bundle.js:29:50838
closeHandler extension.bundle.js:16:165471
CallbackList.invoke vscode-languageserver-protocol/vscode-jsonrpc/events.js:55:39
Emitter.fire vscode-languageserver-protocol/vscode-jsonrpc/events.js:117:36
closeHandler vscode-languageserver-protocol/vscode-jsonrpc/connection.js:256:26
CallbackList.invoke extension.bundle.js:16:307470
Emitter.fire extension.bundle.js:16:308254
StreamMessageReader.fireClose extension.bundle.js:29:123061
Socket.<anonymous> extension.bundle.js:29:124721

Does this occur consistently?  Is there anything about the scenario that might help me understand how to reproduce it?  Thanks.


refactor(connlib): Disable log uploading until UI flows can be built in the clients to opt in

Making a minimal PR to get the app shipped. A better method of configuring this (or removing it altogether if deemed unnecessary) is coming in #3910

I like the "dead code is an error" in general but I'm not sure if all of my editors have "Automatically un-comment these lines" buttons and even with /* long comments */ it would be a code zombie.

Yeah this feels icky. I think we can / should enable log uploads for pre-release builds (Apple/Android, not sure how to designate beta builds for Windows/Linux).
We may be able to just rely on manual sharing too, just depends on the nature of the issues we encounter.
The idea behind log uploads was that we'd be able to get a sense of how widespread certain issues are.


Test Dockerfile

Someone not responsible for creating the file should test running it from scratch.

Everything ran great for me the first time. Only two commands I ran were:

docker pull syadk/ice-thickness
docker run  -it --rm -v $(pwd):/home/ice_thickness syadk/ice-thickness:v0.3.0 make -C /home/ice_thickness all


Redact sensitive URL parameters from audit logging

Description
This PR provides a generic method for redacting sensitive URL parameters from the audit log and explicitly redacts the jwtUrlParameter if jwt authentication is enabled and a token is passed via the url to authenticate a request. Previous behavior was to include the full route + all url parameters unredacted in the audit log.
This will replace the sensitive url param with REDACTED for the audit log entry.

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement
Issues Resolved

https://github.com/opensearch-project/security/issues/3949

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks there seem to be test failures:
Tests with failures:
 - org.opensearch.security.dlic.rest.api.AuditApiActionTest.testReadonlyApi
 - org.opensearch.security.dlic.rest.api.InternalUsersApiActionValidationTest.validateSecurityRolesWithMutableRolesMappingConfig
 - org.opensearch.security.dlic.rest.api.AuditApiActionTest.testApi
 - org.opensearch.security.dlic.rest.api.legacy.LegacyTenantInfoActionTests.testTenantInfoAPIUpdate
 - org.opensearch.security.dlic.rest.api.legacy.LegacyAuditApiActionTests.testReadonlyApi
 - org.opensearch.security.dlic.rest.api.legacy.LegacyAuditApiActionTests.testApi

Would you please look into those?

@DarshitChanpura The test failures are now resolved.

I'll create a manual backport for this.

The backport failed because https://github.com/opensearch-project/security/pull/4065 has not been merged yet.