API Gateway HTTP API Support - The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer

Framework version: 1.4
Implementations: Spring Boot

Scenario
I set up an API Gateway of type HTTP API and made a request to it.  I get a 500 response returned and the following is in the logs:
com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer

It looks like a check is made for the httpMethod field, which is not present in the HTTP API request:
{
    "version": "2.0",
    "routeKey": "GET /ping",
    "rawPath": "/v1/ping",
    "rawQueryString": "",
    "headers": {
        "accept": "*/*",
        "accept-encoding": "gzip, deflate, br",
        "cache-control": "no-cache",
        "content-length": "0",
        "host": "9vj0lwq3c5.execute-api.us-west-2.amazonaws.com",
        "postman-token": "15dec34a-ce88-4de2-a228-11bf679a5358",
        "user-agent": "PostmanRuntime/7.22.0",
        "x-amzn-trace-id": "Root=1-5e710c20-d322154cbc19a7c04f8e6a54",
        "x-forwarded-for": "<IP_ADDRESS>",
        "x-forwarded-port": "443",
        "x-forwarded-proto": "https"
    },
    "requestContext": {
        "accountId": "529841721878",
        "apiId": "9vj0lwq3c5",
        "domainName": "9vj0lwq3c5.execute-api.us-west-2.amazonaws.com",
        "domainPrefix": "9vj0lwq3c5",
        "http": {
            "method": "GET",
            "path": "/v1/ping",
            "protocol": "HTTP/1.1",
            "sourceIp": "<IP_ADDRESS>",
            "userAgent": "PostmanRuntime/7.22.0"
        },
        "requestId": "Ji7VCiIpPHcEPNw=",
        "routeId": null,
        "routeKey": "GET /ping",
        "stage": "v1",
        "time": "17/Mar/2020:17:42:56 +0000",
        "timeEpoch":<PHONE_NUMBER>114
    },
    "isBase64Encoded": true
}

Expected behavior
Framework handles requests for the HTTP API type of API Gateway
Actual behavior
Error is returned
Steps to reproduce
Set up an API Gateway of type HTTP API with a Lambda backend.  Make a request.
Full log output
com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer

Hi @electricsam - we are planning to add HTTP API support by the end of this month, with the next release of the framework. Stay tuned. For the time being, you can also configure HTTP API to send a proxy-compatible event.


How to get RegEx priority over LUIS recognizer for matching intents?

The documentation states we can "mix in the matching of regular expressions alongside your cloud based recognition model. To improve performance, regular expressions are always evaluated before cloud based recognizer(s) and an exact match regular expression will avoid calling the cloud based recognizer(s) all together."
I need help on how to implement this since my attempts have not worked.
Example typing in hi or echo should should find a match without having to call LUIS, but It always calls LUIS. Am I doing something wrong?
`var model = process.env.LUIS_MODEL_URL;
var recognizer = new builder.LuisRecognizer(model);
var intent = new builder.IntentDialog({ recognizers: [recognizer] });
bot.dialog('/', intent);
intent.matches(/^echo/i, session => session.send('Bot version 1.2'));
intent.matchesAny([/hi/i, 'intent:hello'], session => session.beginDialog('greetings:hello'));`

Note: Please only submit Bot Builder SDK bugs here. If you have general questions or implementation issues, please submit a question on Stack Overflow at http://stackoverflow.com/questions/tagged/botframework.

I tested this out today, by creating a 'greet' LUIS intent that has 'hi' and 'hello' utterances.  And this code:
var recognizer = new builder.LuisRecognizer(model);
var intent = new builder.IntentDialog({ recognizers: [recognizer] });

intent.matches(/^hello/i, (session,args) => {
	session.send('hello regex');
	console.log(args);
	});

intent.matchesAny([/^hi/i,], (session,args) => {
	session.send('hi regex');
	console.log(args);
});

intent.matches('Greet', (session,args) => {
	session.send('greet found by luis');
	console.log(args);
});

var bot = new builder.UniversalBot(connector);
bot.dialog('/', intent).onDefault(session => session.send('no match found'));

Typing 'hi' or 'hello' results in a regex match without calling LUIS.  Entering 'hi hello' makes a LUIS call and matches the 'Greet' intent.  Maybe your LUIS isn't setup correctly?

I'm closing this issue, since it cannot be repeated.  Please post any additional questions on Stack Overflow at http://stackoverflow.com/questions/tagged/botframework.

@EricDahlvang Hi Eric, how did you determine LUIS was not called? Did you check your LUIS logs?
I've tried your code with a new LUIS app and I see even for 'hi' and 'hello' the requests were sent to LUIS.

I apologize ajaxav.  I had just checked the returned args, and assumed it wasn't making a call to LUIS.  This morning, I used the Microsoft Network Monitor, and watched the external calls to westus.api.cognitive.microsoft.com ...  With the code above, the recognizers are checked in parallel and in fact LUIS IS called, like you said.  So, I tried changing the recognizeOrder to 'series', and using RegExpRecognizers.  This does provide the behavior you're looking for:
var recognizer = new builder.LuisRecognizer(model);
var regExHi = new builder.RegExpRecognizer('Hi', /^hi$/i);
var regExHello = new builder.RegExpRecognizer('Hello', /^hello$/i);

var intent = new builder.IntentDialog({ recognizers: [regExHello, regExHi, recognizer], recognizeOrder: 'series' })
	.matches('Hello',(session,args)=>{
		console.log(args);
		session.send('hello recognizer');
	})
	.matches('Hi',(session,args)=>{
		console.log(args);
		session.send('hi recognizer');
	}).matches('Greet', (session,args) => {
		console.log(args);
		session.send('greet found by luis');
	});

var bot = new builder.UniversalBot(connector);
bot.dialog('/', intent).onDefault(session => session.send('no match found'));

I will make a note to get the documentation updated to reflect the need for the recognizeOrder parameter to be 'series'  to skip LUIS calls,
Thank you for reporting this.

Thanks, works for me.


Roll Packages from 5e03bb1da411 to a87eddf0c281 (6 revisions)

https://github.com/flutter/packages/compare/5e03bb1da411...a87eddf0c281
2024-10-23<EMAIL_ADDRESS>[image_picker]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7898)
2024-10-23<EMAIL_ADDRESS>[url_launcher]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7906)
2024-10-23<EMAIL_ADDRESS>[pigeon] Allows swift generator to skip error class generation (flutter/packages#7849)
2024-10-23<EMAIL_ADDRESS>[in_app_pur]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7903)
2024-10-23<EMAIL_ADDRESS>[file_selector]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/file_selector/file_selector_android/android (flutter/packages#7900)
2024-10-23<EMAIL_ADDRESS>[video_player_android] Give can pause integration test range to test for (flutter/packages#7913)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Spyder and Psychopy

Hello,
I am trying to get psychopy (a python based stimulus presentation program) working along with spyder. I read that I should add the psychopy path to the pythonpath manager in spyder. This has worked for me previously, however it no longer works. This the error code that I get. Any help would be excellent!

It seems you need to update IPython or pyzmq to make things work again.

And how would I do that on a windows machine?

How did you install Spyder and IPython?

I installed it through Python(x,y).

Then please report this problem with them. I think for Python(x,y) you need to uninstall your current version and install its latest one.
Sorry for not being of more help, but this is clearly an installation problem instead of a Spyder one.


Climate state

Hi Vassilis,
I noticed that my climate gets the "on" state from the binary sensor, but not the "off". I mean: it remains "on" even when binary sensor turns "off".

Fixed. Please update

Ok.
P.S. will you release the "fan" version of SmartIR too?

Yes, In 1-2 weeks

(it was me on Linkedin. just needed to speak to you privately :) )

I’m not using the platform. Please send me the username of your HA account in order to send you my email address via PM

faster: write me to<EMAIL_ADDRESS>;)

Hello,
I use history stats to monitor how much does my AC stay on. I have the following issue:
a. When I define the state as 'cool' / I use AC only on cool mode, no value is returned
b. When I define the state value as 'off', I have the values of the "off" state displayed.
Can you advise me, please, what is the correct state for case A?
This is the script

platform: history_stats
name: Cooling Hours Today
entity_id: climate.samsung_ac
state: 'off'
type: time
start: '{{ now().replace(hour=0).replace(minute=0).replace(second=0) }}'
end: '{{ now() }}'


Retry sync on failure

Closes #147. Future work in #154.
For now retry indefinitely.
 Please reply here if you're looking so the other knows. Thanks in advance!

Note: Contains diffs that will disappear after merging #153.

I'll take a look.

Looks good, thanks!

Thanks for reviewing!


[submodule-sync] bot-submodule-sync-branch-24.12 to branch-24.12 [skip ci] [bot]

submodule-sync to create a PR keeping thirdparty/cudf up-to-date.
 If failed, it will remain open until test pass or manually fix.


Question: Java Keytool says keystore using proprietary format

So using this library I wrote a method
func GenerateKeyStoreFromPem(alias string, password string, permCert []byte, pemKeyKey []byte) ([]byte, error) {
	var chain []keystore.Certificate

	// decode the certificates
	for {
		blockCert, rest := pem.Decode(pemCert)
		if blockCert == nil {
			return nil, errors.New("The supplied Pem certificate could not be decoded")
		}

		chain = append(chain, keystore.Certificate{
			Type:    "X509",
			Content: blockCert.Bytes.,
		})

		// there typically more than one certificate
		if len(rest) > 0 {
			pemCert = rest
		} else {
			break
		}
	}

	blockKey, _ := pem.Decode(pemKey)
	if blockKey == nil {
		return nil, errors.New("The supplied Pem certificate key could not be decoded")
	}

	keyStore := keystore.KeyStore{
		alias: &keystore.PrivateKeyEntry{
			Entry: keystore.Entry{
				CreationDate: time.Now(),
			},
			PrivKey:   blockKey.Bytes,
			CertChain: chain,
		},
	}

	var b bytes.Buffer
	err = keystore.Encode(&b, keyStore, []byte(password))
	if err != nil {
		log.Error("Error encrypting and signing keystore. ", err)
		return nil, err
	}
	return b.Bytes(), nil
}

but once I write to a file, and tried to open with java keytool, then I see a warning saying
Warning: The JKS keystore uses a proprietary format. It is recommended to migrate to PKCS12 which is an industry standard format using "keytool -importkeystore -srckeystore keystore.jks -destkeystore keystore.jks -deststoretype pkcs12".
I guess I need to write the key in pcks12 format, is there any way to do that, is that not matter? I think it is PKCS1 based.

@rareddy hi,
This (keystore-go) library is an implementation of Encoder and Decoder for a proprietary Oracle (Sun) file format called jks. keystore tool from the jdk works with several formats: jks, jceks and pkcs12. jks was a default form till jdk9. From the jdk9 default format is pkcs12 and jks is deprecated. So this library is useful if you are working with legacy software that still using jks file format to store certificates and private keys. If you want to work with pkcs12 file format in your golang applications you need appropriate libraries (take a look at https://pkg.go.dev/search?q=pkcs12)
References:

JEP about switching to pkcs12 in jdk9 http://openjdk.java.net/jeps/229
KeyStore types supported by the keystore tool: https://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#KeyStore
About Keystore implementation: https://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html#KeystoreImplementation

P.S. pkcs1 != jks != pkcs12 and so on. And to work with them you need appropriate implementations of a decoder and an encoder.

@rareddy hi,
how are things going? do you need any more help?

@pavel-v-chernykh Your suggestion was right on, I found "github.com/hetesiistvan/go-pkcs12" which does handle the pkcs12 both keystores and truststores. So, I am trying to rewrite using that. My initial tests were good. Thanks again.

@rareddy, happy to help 😃
Wish you good luck with your project!


Support mutli-cluster for HPA

Multi-cluster is a reasonable scenario in a production environment，but now，can not support it，can you support mutli-cluster for HPA ？

Please reach out to SIG-autoscaling or file an Issue in https://github.com/kubernetes/kubernetes for feature requests for HPA.

ok, it will open an Issue in https://github.com/kubernetes/kubernetes for this feature for HPA


Allow for token expires time in multiple formats

Keystone tokens have an 'expires' property. Currently, is_token_expired
in maas_common expects this to be of the format '%Y-%m-%dT%H:%M:%SZ'.
os-ansible-deployment has switched to using fernet tokens by default.
These have an expires time in the format of '%Y-%m-%dT%H:%M:%S.%fZ'.
This causes the OpenStack MaaS plugins to fail.
This commit modifies is_token_expired to be able to parse either format
of 'expires'.
Closes-bug: https://github.com/rcbops/rpc-openstack/issues/199

afaik, fernet hasn't been merged yet, though it's a good idea to have this support.  should this be backported?

:+1:

Looks like the fernet code has merged, as I'm currently seeing this on a cluster deployed w/ os-a-d master:
root@jenk-heat-353-node1:/usr/lib/rackspace-monitoring-agent/plugins# ./cinder_service_check.py <IP_ADDRESS>
status error n.py", line 331, in is_token_expired\n    '%Y-%m-%dT%H:%M:%SZ')\n  File "/usr/lib/python2.7/_strptime.py", line 325, in _strptime\n    (data_string, format))\nValueError: time data '2015-06-30T21:24:56.879037Z' does not match format '%Y-%m-%dT%H:%M:%SZ'\n
Traceback (most recent call last):
  File "./cinder_service_check.py", line 93, in <module>
    main(args)
  File "./cinder_service_check.py", line 80, in main
    auth_ref = get_auth_ref()
  File "/usr/lib/rackspace-monitoring-agent/plugins/maas_common.py", line 341, in get_auth_ref
    if is_token_expired(auth_ref['token']):
  File "/usr/lib/rackspace-monitoring-agent/plugins/maas_common.py", line 331, in is_token_expired
    '%Y-%m-%dT%H:%M:%SZ')
  File "/usr/lib/python2.7/_strptime.py", line 325, in _strptime
    (data_string, format))
ValueError: time data '2015-06-30T21:24:56.879037Z' does not match format '%Y-%m-%dT%H:%M:%SZ'
root@jenk-heat-353-node1:/usr/lib/rackspace-monitoring-agent/plugins#

Applying @git-harry's patch allows the script to complete successfully.
:+1: and merging.


Addition of en_GB mobileNumber methods

Additions to the PhoneNumber Provider for en_GB so that a UK format phone number can be returned.

Thanks!


Finish Rails 4.25 update (Heroku config)

From #1329 - we need to change SERVE_STATIC to RAILS_SERVE_STATIC_FILES in .env.example as well as in app.json and in the wiki. Will be done tonight.

Note that this comes from this line in the default production.rb file.


iOS: Timeline: Rotation leads to cells that need re-rendering

I used to be able to recreate this but am no longer able to.  I'm not sure if we fixed something or if it was an os version specific bug that was fixed in iOS 13.  I suggest we close this until and if it shows up again, reopen the ticket or write a new one.


Add EXPECT_JSON runtime test directive

Runtime tests have quite a few available directives (see https://github.com/iovisor/bpftrace/blob/master/tests/README.md#runtime-test-directives).
A bunch of json output tests (see https://github.com/iovisor/bpftrace/blob/master/tests/runtime/json-output) pipe output from bpftrace to python like this:
NAME complex
RUN {{BPFTRACE}} -q -f json -e 'BEGIN { @complex[comm,2] = 5; exit(); }' | python3 -c 'import sys,json; print(json.load(sys.stdin) == json.load(open("runtime/outputs/complex.json")))'
EXPECT ^True$
TIMEOUT 5

Would be good to add a EXPECT_JSON directive to simplify all those tests. So something like:
NAME complex
RUN {{BPFTRACE}} -q -f json -e 'BEGIN { @complex[comm,2] = 5; exit(); }'
EXPECT_JSON runtime/outputs/complex.json
TIMEOUT 5

It needs to be done in python (and not an exact string match) to ignore dict reorderings. Cuz in json those kinds of reorderings are not semantically relevant.

see https://github.com/iovisor/bpftrace/pull/2845 for a possible implementation of this directive.


Single-machine batch system doesn't re-acquire cores from killed jobs

If maxCores = 2, it should be possible to issue two jobs that require one core each, kill them, and then issue another job that requires one core. In single machine, issueBatchJob hangs on the third job, waiting for the cpu usage to go below 2.
    def testReclaimCores(self):
        job1 = self.batchSystem.issueBatchJob("sleep 1000", memory=memoryForJobs, cores=1, disk=diskForJobs)
        job2 = self.batchSystem.issueBatchJob("sleep 1000", memory=memoryForJobs, cores=1, disk=diskForJobs)
        self._waitForJobsToStart(2)
        self.batchSystem.killBatchJobs([job1, job2])

        #hangs
        job3 = self.batchSystem.issueBatchJob("sleep 1000", memory=memoryForJobs, cores=1, disk=diskForJobs)
        self.batchSystem.killBatchJobs([job3])

Nevermind, sorry.


add paste event

Adds the paste event so it can be used as bind_event_paste, along the same lines as the venerable bind_event_click.
browser support looks OK: http://caniuse.com/#search=paste
We need this in the admin for textfields which should trigger changes when merchants paste value, specifically for the multi select product picker on drafts and transfers.
@nwtn @qq99 cc @katdrobnjakovic @maartenvg

The line is getting very long, can you split it over 3-4 lines for readability?

👍


zip_safe detection does not work as expected

With setuptools 36.7.2 I tried to build apsw package (see also https://github.com/rogerbinns/apsw/issues/243).
This package has a c extension build, but not specifying the zip_safe flag.
setuptools detected this package automatically as zip_safe, which is wrong.

You're implying that any package that has a C extension is not zip safe. Is that true?

I think any package that distribute a .so / .pyd file is not zip safe, because dlopen does not know anything about zipped egg containers.

As said in the docs http://setuptools.readthedocs.io/en/latest/setuptools.html#setting-the-zip-safe-flag:  "any C extensions" and  "extremely conservative",


fix: osmosis error handling

Description
Handle calling Osmosis's getTradeQuote on unsupported assets by using mondaic error handling to gracefully catch.
Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
Small rist to Osmosis quotes/trades.
Testing
Osmosis swapper should still get quotes and execute trades as expected.
Engineering
We were only throwing when the multi-hop flag was on. The console errors should now be gone.
Operations
Osmosis swaps should work as expected.
Screenshots (if applicable)
N/A

Current dependencies on/for this PR:

develop

PR #4944   👈

This comment was auto-generated by Graphite.


external API URL

external API URL of open food facts in res/values/strings.xml
fix #113

@teolemon i put the api url in the strings.xml file; are you ok with that ?

My main concern is preparing the way for Open Beauty Facts (and possibly debug version for the Open Food Facts preprod)
The only caveat could be overzealous translators ?

@teolemon i just push the commit 7b492fc, which set the string variable non translatable.

Also, given my broad knowledge of Java, I'd rather leave non-trivial code-reviews to @itchix ;-)


GH-39057: [CI][C++][Go] Don't run jobs that use a self-hosted GitHub Actions Runner on fork

Rationale for this change
If jobs that use a self-hosted GitHub Actions Runner on fork are submitted on fork, they will timeout eventually and report noisy failure notifications.
What changes are included in this PR?
We can't use jobs.<job_id>.if to reject jobs that use self-hosted GitHub Actions Runner because jobs.<job_id>.if is evaluated before jobs.<job_id>.strategy.matrix.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif

Note: The jobs.<job_id>.if condition is evaluated before
jobs.<job_id>.strategy.matrix is applied.

We can use output jobs<job_id>.outputs instead. See also:

https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idoutputs

Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #39057

I'll merge this in the next week if nobody objects this.

+1
No objection.


Wrong frame rate in audio encoding

I have discovered a pretty bad issue in this baseline code: the audio features were encoded at 20 fps, while the motion is 30 fps.

This issue was fixed in the commit https://github.com/genea-workshop/Speech_driven_gesture_generation_with_autoencoder/commit/9b5a895beb3a3083aa9b1055471ac96ba2d305b0


chore(deps): Bump Argo CD to v2.12.0

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.62%. Comparing base (57a7aa5) to head (8f6fd60).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   48.62%   48.62%
=======================================
  Files          52       52
  Lines        3342     3342
=======================================
  Hits         1625     1625
  Misses       1578     1578
  Partials      139      139

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Replaced deprecated mktemp() with mkstemp()  (#1754)

Replaced deprecated function with the recommended alternative. Cherry-pick of https://github.com/pallets/click/pull/1754 to 7.x branch with additional black and flake8 changes.
The safety-db marks click <8.0.0 as vulnerable due to the usage of mktemp. I would like to backport this change to mitigate this issue on the 7.x branch.
I also had to change a few other files due to pre-commit.ci failures.

fixes #1752

Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed. (tox failes unchanged files)

7.x is not maintained. You'll want to upgrade to the latest version, which is currently 8.1.2.


uv run --with should not allow modifications to the --with environment

The --with dependencies use a cached environment based on the resolved dependencies. If users modify that environment, it could affect --with invocations in other projects.
Instead, I think we should run these commands in an empty virtual environment, with the base and --with environments layered atop, such that any modifications don't affect the --with environment.

I have a PR that "fixes" this by using a third empty env, but it doesn't fix Jupyter sadly since it seems to use whatever environment the binary is installed in.


[iOS][Image Rendering][ResourceResolvers] BackgroundImage is not filled properly when set second time

Platform
What platform is your issue or question related to? (Delete other platforms).

iOS

Version of SDK
v1.2.11
Details
BackgroundImage seems not fill properly when set the second time on an imageView passed via ResourceResolver. We generally set a placeholder image first until the original image gets downloaded. So, when the original image tries to replace the placeholder, it doesn't follow proper filling.

Also, the icon images doesn't fill properly too.
Mac version of same card

card-details.zip
Attached the card payload and images in this zip.

@akaashdev
This is similar to #4650.
When an UIImage is set to an UIImageView, it will notify the observer and the observer sets the constraints on the UIImageVew based on UIImage's size attributes.  After the notification happens, the observer is removed, and no further notification will be generated. So if you used the observer for placeholder image, there will be no notification for the real image, so the constraints won't be proper likewise.
If the use of the placeholder image is a requirement, this issue and #4650 will be a feature request.  Do Android and Desktop use placeholder images?

@jwoo-msft
Use of placeholder image is definitely a requirement for us. The logic is to have a placeholder image, matching the dimensions of the original image, set before the original image comes in. This is to avoid the change in the card's height. We run into performance issues and sometimes in crash scenarios when the heights of the card (inturn the height of the cell) changes frequently.

@jwoo-msft
Use of placeholder image is definitely a requirement for us. The logic is to have a placeholder image, matching the dimensions of the original image, set before the original image comes in. This is to avoid the change in the card's height. We run into performance issues and sometimes in crash scenarios when the heights of the card (inturn the height of the cell) changes frequently.
And yea, if there is any other way to tackle the height changing issue, we're happy to give it a shot. But still, we would prefer using a placeholder image shown first, as it sort of gives a visual feedback of an image being downloaded.

Hi @akaashdev
Thanks for the feedback.
As this issue is now tracked by #4682, do you mind if I close this issue? You can reopen this issue if resolution to #4682 does not resolve this issue.

Sure! This can be closed!
Thanks! 👍


Import: System.ArgumentException: SerializedFile with name 'globalgamemanagers' already presents in the collection

Import: System.ArgumentException: SerializedFile with name 'globalgamemanagers' already presents in the collection
Имя параметра: file
в uTinyRipper.GameCollection.OnSerializedFileAdded(SerializedFile file)
в uTinyRipper.GameCollection.OnFileListAdded(FileList list)
в uTinyRipper.FileList.AddFile(GameProcessorContext context, FileScheme scheme)
в uTinyRipper.GameStructureProcessor.ProcessSchemes(GameCollection fileCollection)
в uTinyRipper.GameStructure.Load(List1 pathes, LayoutInfo layinfo)    в uTinyRipper.GameStructure.Load(IEnumerable1 pathes, LayoutInfo layinfo)
в uTinyRipperGUI.MainWindow.LoadFiles(Object data)
Go to: Create issue

Game doesn't has 2 globalgamemanagers. Don't know where did you get second one.

I've seen games that do actually have multiple copies of the same files, mixed in with unique files. I get this same error when trying to rip an entire game directory, but I can extract the individual files fine. I don't care about the duplicates, but a way to ignore them and extract anyway would be nice.

ok

@AnsonX10 what file system allows to has 2 files with the same name in the same directory. All game files are located in the Data directory (except bundles), so, even if there are some file copies, they are ignored by game engine and by ripper, if you drag and drop root game folder.
There is no nice way to resolve duplicates conflict, since there is such thing as dependencies. Those dependencies are resolved by file name, so duplicates mean ambiguacy. And this case is only valid for asset bundles, since developer loads them from code by unique path. All general game files has unique name, so that is the way engine knkw how to load them.

I think it is the same issue https://github.com/mafaca/UtinyRipper/issues/504


Cannot read property 'config' of null

Can anyone help with this error when running ng serve? Error says:
Cannot read property 'config' of null
TypeError: Cannot read property 'config' of null
at Class.run (./node_modules/@angular/cli/tasks/serve.js:22:63)
at check_port_1.checkPort.then.port (./node_modules/@angular/cli/commands/serve.js:103:26)
at process._tickCallback (internal/process/next_tick.js:109:7)

nevermind, was missing the dotfiles, my mistake


[OTA Matter.framework] Code is unsafe/racy error message

Problem
After setting the OTA delegate in Matter.framework and receiving Query Image InvokeCommand to the controller (Matter.framework), an error message states that the code is unsafe/racy. This appears to be the issue because during the transmission of the message we are using a delegate that is passed in from the caller here.  After inspecting the code, the assertion calls IsChipStackLockedByCurrentThread to check whether messaging is locked. For this to be set to true the following condition needs to be true !mWorkQueue || mIsWorkQueueSuspended || dispatch_get_current_queue() == mWorkQueue
Proposed Solution
Update the queue used to send the message to the node.
controller_error_log.txt

The completionHandler there should be dispatching to the Matter work queue, no?  @carol-apple

@carol-apple I am going to update this.


Hugo Build Issues on installation

Description
When we try to install latest version as per the instrictions, Below error is thrown
Start building sites …
hugo v0.117.0-b2f0696cad918fb61420a6aff173eb36662b406e+extended linux/amd64 BuildDate=2023-08-07T12:49:48Z VendorInfo=gohugoio
ERROR render of "page" failed: "/home/haripriya/Official/doks_example/sqlcomponents.github.io/node_modules/@thulite/core/layouts/_default/baseof.html:3:5": execute of template failed: template: blog/single.html:3:5: executing "blog/single.html" at <partial "head/head" .>: error calling partial: "/home/haripriya/Official/doks_example/sqlcomponents.github.io/node_modules/@thulite/core/layouts/partials/head/head.html:15:8": execute of template failed: template: partials/head/head.html:15:8: executing "partials/head/head.html" at <partial "head/seo" .>: error calling partial: "/home/haripriya/Official/doks_example/sqlcomponents.github.io/node_modules/@thulite/seo/layouts/partials/head/seo.html:1:4": execute of template failed: template: partials/head/seo.html:1:4: executing "partials/head/seo.html" at <partial "seo/_all" .>: error calling partial: "/home/haripriya/Official/doks_example/sqlcomponents.github.io/node_modules/@thulite/seo/layouts/partials/seo/_all.html:9:4": execute of template failed: template: partials/seo/_all.html:9:4: executing "partials/seo/_all.html" at <partial "seo/opengraph" .>: error calling partial: "/home/haripriya/Official/doks_example/sqlcomponents.github.io/node_modules/@thulite/seo/layouts/partials/seo/opengraph.html:7:15": execute of template failed: template: partials/seo/opengraph.html:7:15: executing "partials/seo/opengraph.html" at <partial "_funcs/get-page-images" .>: error calling partial: partial "_funcs/get-page-images" not found

This is due to hugo version, When i upgraded to latest hugo, this issue is not there.


master [1.26.0-18.0.pre.90] breaks hot-reload on mobile

Steps to Reproduce

run in terminal the code sample below with flutter run -v

code sample
import 'package:flutter/material.dart';

void main() => runApp(
      MaterialApp(
        home: Material(
          child: MyWidget(Colors.red),
        ),
      ),
    );

class MyWidget extends StatelessWidget {
  const MyWidget(this.color);
  final Color color;
  @override
  Widget build(BuildContext context) {
    debugPrint('$color');
    return ColoredBox(color: color);
  }
}

change the Colors.red to Colors.green and save the changes

press r in the terminal

Expected results:  both debugPrint show the new value and the screen changes
Actual results:  both debugPrint show the same value and the screen doesn't change
[+1354 ms] I/flutter (26987): MaterialColor(primary value: Color(0xfff44336))
[...]
[ +166 ms] I/flutter (26987): MaterialColor(primary value: Color(0xfff44336))

logs
[   +6 ms] ✓ Built build/app/outputs/flutter-apk/app-debug.apk.
[  +10 ms] executing: /home/francesco/Android/Sdk/build-tools/30.0.2/aapt dump xmltree /home/francesco/projects/thirty_jan/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[  +18 ms] Exit code 0 from: /home/francesco/Android/Sdk/build-tools/30.0.2/aapt dump xmltree /home/francesco/projects/thirty_jan/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[        ] N: android=http://schemas.android.com/apk/res/android
             E: manifest (line=2)
               A: android:versionCode(0x0101021b)=(type 0x10)0x1
               A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0")
               A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1e
               A: android:compileSdkVersionCodename(0x01010573)="11" (Raw: "11")
               A: package="com.example.thirty_jan" (Raw: "com.example.thirty_jan")
               A: platformBuildVersionCode=(type 0x10)0x1e
               A: platformBuildVersionName=(type 0x10)0xb
               E: uses-sdk (line=7)
                 A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
                 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1e
               E: uses-permission (line=14)
                 A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
               E: application (line=16)
                 A: android:label(0x01010001)="thirty_jan" (Raw: "thirty_jan")
                 A: android:icon(0x01010002)=@0x7f080000
                 A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
                 A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
                 E: activity (line=21)
                   A: android:theme(0x01010000)=@0x7f0a0000
                   A: android:name(0x01010003)="com.example.thirty_jan.MainActivity" (Raw: "com.example.thirty_jan.MainActivity")
                   A: android:launchMode(0x0101001d)=(type 0x10)0x1
                   A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
                   A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
                   A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
                   E: meta-data (line=35)
                     A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme")
                     A: android:resource(0x01010025)=@0x7f0a0001
                   E: meta-data (line=45)
                     A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable")
                     A: android:resource(0x01010025)=@0x7f040000
                   E: intent-filter (line=49)
                     E: action (line=50)
                       A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
                     E: category (line=52)
                       A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
                 E: meta-data (line=59)
                   A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
                   A: android:value(0x01010024)=(type 0x10)0x2
[   +3 ms] Stopping app 'app.apk' on Pixel 3a.
[   +1 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am force-stop com.example.thirty_jan
[ +119 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell pm list packages com.example.thirty_jan
[ +114 ms] package:com.example.thirty_jan
[   +2 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell cat /data/local/tmp/sky.com.example.thirty_jan.sha1
[  +63 ms] 2436bfd7a6234ba60f22dbfe0439606eaa85ebf8
[        ] Latest build already installed.
[        ] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell -x logcat -v time -t 1
[  +90 ms] --------- beginning of main
           01-30 13:07:51.609 I/cmd     (26969): oneway function results will be dropped but finished with status OK and parcel size 4
[  +13 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez
enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points true com.example.thirty_jan/com.example.thirty_jan.MainActivity
[  +87 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.thirty_jan/.MainActivity (has extras) }
[        ] Waiting for observatory port to be available...
[ +494 ms] Observatory URL on device: http://<IP_ADDRESS>:42077/6Jw--_JY34Y=/
[   +2 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward tcp:0 tcp:42077
[  +12 ms] 33459
[        ] Forwarded host port 33459 to device port 42077 for Observatory
[+1354 ms] I/flutter (26987): MaterialColor(primary value: Color(0xfff44336))
[+5050 ms] Caching compiled dill
[ +136 ms] Connecting to service protocol: http://<IP_ADDRESS>:33459/6Jw--_JY34Y=/
[ +418 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at http://<IP_ADDRESS>:33459/6Jw--_JY34Y=/.
[ +228 ms] DDS is listening at http://<IP_ADDRESS>:38975/lSIClJA8FN8=/.
[  +82 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:33459/6Jw--_JY34Y=/
[+1515 ms] DevFS: Creating new filesystem on the device (null)
[  +73 ms] DevFS: Created new filesystem on the device (file:///data/user/0/com.example.thirty_jan/code_cache/thirty_janCFACNZ/thirty_jan/)
[   +6 ms] Updating assets
[  +94 ms] Syncing files to device Pixel 3a...
[   +1 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[   +2 ms] <- recompile package:thirty_jan/main.dart dacc0680-42dc-4cec-862d-e1326bcb825e
[        ] <- dacc0680-42dc-4cec-862d-e1326bcb825e
[ +117 ms] Updating files.
[        ] DevFS: Sync finished
[   +1 ms] Syncing files to device Pixel 3a... (completed in 122ms)
[        ] Synced 0.0MB.
[        ] <- accept
[  +37 ms] Connected to _flutterView/0x7633a07040.
[   +1 ms] Flutter run key commands.
[   +1 ms] r Hot reload. 🔥🔥🔥
[        ] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] An Observatory debugger and profiler on Pixel 3a is available at: http://<IP_ADDRESS>:38975/lSIClJA8FN8=/
[        ]
           Flutter DevTools, a Flutter debugger and profiler, on Pixel 3a is available at: http://<IP_ADDRESS>:9102?uri=http%3A%2F%2F<IP_ADDRESS>%3A38975%2FlSIClJA8FN8%3D%2F
[        ] Running with unsound null safety
[        ] For more information see https://dart.dev/null-safety/unsound-null-safety
[+8902 ms] Skipping target: gen_localizations
[   +3 ms] complete
[   +7 ms] Performing hot reload...
[  +28 ms] Scanned through 510 files in 11ms
[        ] Syncing files to device Pixel 3a...
[        ] Compiling dart to kernel with 1 updated files
[        ] <- recompile package:thirty_jan/main.dart 8642eab8-231f-4679-90f2-133d570b59bc
[        ] package:thirty_jan/main.dart
[        ] <- 8642eab8-231f-4679-90f2-133d570b59bc
[  +43 ms] Updating files.
[ +155 ms] DevFS: Sync finished
[        ] Syncing files to device Pixel 3a... (completed in 201ms)
[        ] Synced 0.0MB.
[ +206 ms] <- accept
[   +3 ms] reloaded 1 of 547 libraries
[  +43 ms] Reassembling application
[ +166 ms] I/flutter (26987): MaterialColor(primary value: Color(0xfff44336))
[  +49 ms] Hot reload performed in 674ms.
[   +1 ms] Performing hot reload... (completed in 701ms)
[        ] Reloaded 1 of 547 libraries in 717ms.
[+43954 ms] DevFS: Deleting filesystem on the device (file:///data/user/0/com.example.thirty_jan/code_cache/thirty_janCFACNZ/thirty_jan/)
[  +33 ms] DevFS: Deleted filesystem on the device (file:///data/user/0/com.example.thirty_jan/code_cache/thirty_janCFACNZ/thirty_jan/)
[ +234 ms] Service protocol connection closed.
[        ] Application finished.
[   +3 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward --list
[   +5 ms] Exit code 0 from: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward --list
[        ] 965AY0WP5C tcp:33459 tcp:42077
[   +1 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward --remove tcp:33459
[   +8 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward --list
[   +5 ms] Exit code 0 from: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C forward --list
[        ] "flutter run" took 70,119ms.
[ +257 ms] ensureAnalyticsSent: 253ms
[   +4 ms] Running shutdown hooks
[   +1 ms] Shutdown hook priority 4
[   +2 ms] Shutdown hooks complete
[  +10 ms] exiting with code 0

doctor
[✓] Flutter (Channel master, 1.26.0-18.0.pre.90, on Linux, locale en_US.UTF-8)
    • Flutter version 1.26.0-18.0.pre.90 at /home/francesco/snap/flutter/common/flutter
    • Framework revision 25134a16d1 (3 hours ago), 2021-01-29 23:52:30 -0800
    • Engine revision ce14c8a841
    • Dart version 2.12.0 (build 2.12.0-276.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/francesco/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_SDK_ROOT = /home/francesco/Android/Sdk
    • Java binary at: /usr/lib/jvm/java-1.8.0-openjdk-amd64/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_275-8u275-b01-0ubuntu1~20.04-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /snap/bin/chromium

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 965AY0WP5C • android-arm64  • Android 11 (API 30)
    • Linux (desktop)   • linux      • linux-x64      • Linux
    • Chrome (web)      • chrome     • web-javascript • Chromium 88.0.4324.96 snap

! Doctor found issues in 1 category.

Note

hot restart works as intended
the issue does not occur on web

web logs
[  +75 ms] Waiting for connection from debug service on Chrome...
[  +88 ms] <- reset
[   +8 ms] /home/francesco/snap/flutter/common/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
/home/francesco/snap/flutter/common/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root /home/francesco/snap/flutter/common/flutter/bin/cache/flutter_web_sdk/
--incremental --target=dartdevc --debugger-module-names --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill /tmp/flutter_tools.EGVJZX/flutter_tool.TAJLDN/app.dill
--libraries-spec file:///home/francesco/snap/flutter/common/flutter/bin/cache/flutter_web_sdk/libraries.json --packages /home/francesco/projects/thirty_jan/.dart_tool/package_config.json
-Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-root /tmp/flutter_tools.EGVJZX/flutter_tools.RXJKCO --filesystem-scheme org-dartlang-app
--initialize-from-dill build/c7922d95bf4a2462b75c84a97c312edb.cache.dill.track.dill --platform file:///home/francesco/snap/flutter/common/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill
--no-sound-null-safety
[  +19 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+20177 ms] Waiting for connection from debug service on Chrome... (completed in 20.3s)
[        ] Synced 29.2MB.
[        ] <- accept
[        ] Caching compiled dill
[ +288 ms] Using Chromium 88.0.4324.96 snap

[ +362 ms] [CHROME]:
[        ] [CHROME]:(chrome:83778): Gtk-WARNING **: 13:13:12.438: Theme parsing error: gtk.css:1555:23: 'font-feature-settings' is not a valid property name
[   +3 ms] [CHROME]:
[        ] [CHROME]:(chrome:83778): Gtk-WARNING **: 13:13:12.444: Theme parsing error: gtk.css:3591:25: 'font-feature-settings' is not a valid property name
[   +1 ms] [CHROME]:
[        ] [CHROME]:(chrome:83778): Gtk-WARNING **: 13:13:12.445: Theme parsing error: gtk.css:4053:23: 'font-feature-settings' is not a valid property name
[ +278 ms] [CHROME]:
[        ] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:37373/devtools/browser/6a591545-b8db-4126-9262-92b1dead569d
[+2037 ms] DwdsInjector: Received request for entrypoint at http://localhost:38239/main_module.bootstrap.js
[   +9 ms] MetadataProvider: Loading debug metadata...
[  +26 ms] MetadataProvider: Loaded debug metadata (no sound null safety)
[  +11 ms] DwdsInjector: Injected debugging metadata for entrypoint at http://localhost:38239/main_module.bootstrap.js
[+2693 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: false
[ +562 ms] DevHandler: Debug service listening on ws://<IP_ADDRESS>:42845/5n8r48KdXPU=/ws

[  +10 ms] Debug service listening on ws://<IP_ADDRESS>:42845/5n8r48KdXPU=/ws
[        ] Running with unsound null safety
[        ] For more information see https://dart.dev/null-safety/unsound-null-safety
[   +2 ms] 🔥  To hot restart changes while running, press "r" or "R".
[   +2 ms] For a more detailed help message, press "h". To quit, press "q".
[+6307 ms] MaterialColor(primary value: Color(0xff4caf50))
[+29310 ms] Performing hot restart...
[  +16 ms] Initializing file store
[  +14 ms] Skipping target: gen_localizations
[   +5 ms] complete
[   +8 ms] Scanned through 511 files in 8ms
[        ] Waiting for connection from debug service on Chrome...
[   +2 ms] <- recompile org-dartlang-app:/web_entrypoint.dart b1b9da9e-f479-4124-ac4f-bbf7ec5d6372
[        ] package:thirty_jan/main.dart
[        ] <- b1b9da9e-f479-4124-ac4f-bbf7ec5d6372
[  +42 ms] Waiting for connection from debug service on Chrome... (completed in 44ms)
[        ] Synced 0.0MB.
[        ] <- accept
[   +1 ms] DwdsVmClient: Attempting a hot restart
[   +1 ms] DwdsVmClient: Attempting to disabling breakpoints and resume the isolate
[   +8 ms] DwdsVmClient: Successfully disabled breakpoints and resumed the isolate
[        ] DwdsVmClient: Attempting to get execution context ID.
[        ] DwdsVmClient: Got execution context ID.
[        ] DwdsVmClient: Issuing $dartHotRestart request.
[ +112 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: false
[  +27 ms] DwdsVmClient: $dartHotRestart request complete.
[   +1 ms] DwdsVmClient: Waiting for Isolate Start event.
[   +1 ms] DwdsVmClient: Successful hot restart
[   +2 ms] Performing hot restart... (completed in 248ms)
[        ] Restarted application in 249ms.
[ +359 ms] MaterialColor(primary value: Color(0xfff44336))
[+3331 ms] Application finished.
[   +4 ms] "flutter run" took 66,977ms.
[   +5 ms] DevHandler: Stopped debug service on ws://<IP_ADDRESS>:43525

[ +250 ms] ensureAnalyticsSent: 253ms
[   +3 ms] Running shutdown hooks
[        ] Shutdown hook priority 4
[   +5 ms] Shutdown hooks complete
[   +2 ms] exiting with code 0

Hi @iapicca
Thanks for filing the issue, I can reproduce it on the latest master channel.

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-18.0.pre.90, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.90 at /Users/tahatesser/Code/flutter_master
    • Framework revision 25134a16d1 (2 days ago), 2021-01-29 23:52:30 -0800
    • Engine revision ce14c8a841
    • Dart version 2.12.0 (build 2.12.0-276.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

Thank you

@TahaTesser
I don't have the means to test it on iOS, does the issue occurs on iphone as well?

@iapicca
Totally forgot, I just tested on iOS, it doesn't work on the latest master

On my setup, the new color is not taking effect on either master or dev (I used dev framework commit c40e5294dda34d04cd222dfdf765f171e12e4a8d)
Note that hot reload does not rerun main (see https://flutter.dev/docs/development/tools/hot-reload)

the issue doesn't seem to occur anymore

updated code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  MyApp() : super(key: const ValueKey('MyApp'));

  @override
  Widget build(BuildContext context) =>
      MaterialApp(home: Material(child: MyWidget(Colors.green)));
}

class MyWidget extends StatelessWidget {
  const MyWidget(this.color);
  final Color color;
  @override
  Widget build(BuildContext context) {
    debugPrint('$color');
    return ColoredBox(color: color);
  }
}

logs
✓ Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app.apk...                 3.7s
Syncing files to device Pixel 3a...                                122ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

Running with unsound null safety
For more information see https://dart.dev/null-safety/unsound-null-safety

An Observatory debugger and profiler on Pixel 3a is available at: http://<IP_ADDRESS>:43579/SEGlz1ndJkg=/
I/flutter (28690): MaterialColor(primary value: Color(0xfff44336))
Activating Dart DevTools...                                         3.1s
The Flutter DevTools debugger and profiler on Pixel 3a is available at: http://<IP_ADDRESS>:9101?uri=http%3A%2F%2F<IP_ADDRESS>%3A43579%2FSEGlz1ndJkg%3D%2F

Performing hot reload...                                               ⣾I/flutter (28690): MaterialColor(primary value: Color(0xff4caf50))

Reloaded 1 of 548 libraries in 773ms.

Application finished.

doctor
[✓] Flutter (Channel master, 1.26.0-18.0.pre.156, on Linux, locale en_US.UTF-8)
    • Flutter version 1.26.0-18.0.pre.156 at /home/francesco/snap/flutter/common/flutter
    • Framework revision 45508985b1 (5 hours ago), 2021-02-02 22:46:04 -0500
    • Engine revision 2c144c3eeb
    • Dart version 2.12.0 (build 2.12.0-282.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/francesco/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_SDK_ROOT = /home/francesco/Android/Sdk
    • Java binary at: /usr/lib/jvm/java-1.8.0-openjdk-amd64/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_275-8u275-b01-0ubuntu1~20.04-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /snap/bin/chromium

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 965AY0WP5C • android-arm64  • Android 11 (API 30)
    • Linux (desktop)   • linux      • linux-x64      • Linux
    • Chrome (web)      • chrome     • web-javascript • Chromium 88.0.4324.96 snap

! Doctor found issues in 1 category.

before going ahead and close the issue I suggest to add some kind of test
to prevent this issue to re-emerge

I still have this issue, that hot-reload does not work, and only hot-restart works.
`[   +1 ms] Flutter run key commands.
[   +1 ms] r Hot reload. 🔥🔥🔥
[        ] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] An Observatory debugger and profiler on sdk gphone x86 arm is available at: http://<IP_ADDRESS>:51683/m3yP__i-f64=/
[   +1 ms]
Flutter DevTools, a Flutter debugger and profiler, on sdk gphone x86 arm is available at:
http://<IP_ADDRESS>:9101?uri=http%3A%2F%2F<IP_ADDRESS>%3A51683%2Fm3yP__i-f64%3D%2F
[        ] Running with unsound null safety
[        ] For more information see https://dart.dev/null-safety/unsound-null-safety
[+34562 ms] Skipping target: gen_localizations
[        ] complete
[   +1 ms] Performing hot reload...
[  +17 ms] Scanned through 511 files in 6ms
[        ] Syncing files to device sdk gphone x86 arm...
[        ] Compiling dart to kernel with 1 updated files
[        ] <- recompile package:i_am_rich/main.dart 36468b50-fd19-4a67-b5de-024bcda553a2
[        ] package:i_am_rich/main.dart
[        ] <- 36468b50-fd19-4a67-b5de-024bcda553a2
[  +24 ms] Updating files.
[ +179 ms] DevFS: Sync finished
[        ] Syncing files to device sdk gphone x86 arm... (completed in 205ms)
[        ] Synced 0.0MB.
[ +223 ms] <- accept
[   +1 ms] reloaded 1 of 548 libraries
[  +21 ms] Reassembling application
[ +441 ms] Hot reload performed in 897ms.
[        ] Performing hot reload... (completed in 911ms)
[        ] Reloaded 1 of 548 libraries in 916ms.
[+5831 ms] Skipping target: gen_localizations
[        ] complete
[   +1 ms] Performing hot restart...
[   +7 ms] Scanned through 511 files in 5ms
[        ] Syncing files to device sdk gphone x86 arm...
[        ] <- reset
[        ] Compiling dart to kernel with 0 updated files
[        ] <- recompile package:i_am_rich/main.dart 1db3aac4-b60e-4e72-a314-23c6b2c73e2f
[        ] <- 1db3aac4-b60e-4e72-a314-23c6b2c73e2f
[  +79 ms] Updating files.
[ +708 ms] DevFS: Sync finished
[        ] Syncing files to device sdk gphone x86 arm... (completed in 789ms)
[        ] Synced 25.2MB.
[        ] <- accept
[ +323 ms] Hot restart performed in 1,118ms.
[        ] Performing hot restart... (completed in 1,121ms)
[        ] Restarted application in 1,125ms.
[+19500 ms] Skipping target: gen_localizations
[        ] complete
[        ] Performing hot reload...
[  +10 ms] Scanned through 511 files in 5ms
[        ] Syncing files to device sdk gphone x86 arm...
[        ] Compiling dart to kernel with 1 updated files
[        ] <- recompile package:i_am_rich/main.dart bd6db4c4-0f8d-4ced-b307-e61fb849dfd8
[        ] package:i_am_rich/main.dart
[        ] <- bd6db4c4-0f8d-4ced-b307-e61fb849dfd8
[   +8 ms] Updating files.
[  +12 ms] DevFS: Sync finished
[        ] Syncing files to device sdk gphone x86 arm... (completed in 22ms)
[        ] Synced 0.0MB.
[  +85 ms] <- accept
[        ] reloaded 1 of 548 libraries
[  +10 ms] Reassembling application
[ +227 ms] Hot reload performed in 351ms.
[        ] Performing hot reload... (completed in 356ms)
[        ] Reloaded 1 of 548 libraries in 359ms.
[+3047 ms] Skipping target: gen_localizations
[        ] complete
[        ] Performing hot restart...
[   +5 ms] Scanned through 511 files in 5ms
[        ] Syncing files to device sdk gphone x86 arm...
[        ] <- reset
[        ] Compiling dart to kernel with 0 updated files
[        ] <- recompile package:i_am_rich/main.dart 81d2384f-02d7-4ed1-a57a-072b20e3c19d
[        ] <- 81d2384f-02d7-4ed1-a57a-072b20e3c19d
[  +86 ms] Updating files.
[+1201 ms] DevFS: Sync finished
[        ] Syncing files to device sdk gphone x86 arm... (completed in 1,288ms)
[        ] Synced 25.2MB.
[        ] <- accept
[ +634 ms] Hot restart performed in 1,929ms.
[        ] Performing hot restart... (completed in 1,929ms)
[        ] Restarted application in 1,931ms.
`

I still have this issue where only hot-restart works and hot-reload does not work.
I am on dev channel as well.
My device is Macbook Pro Late 2013 running on MacOS Big Sur version 11.1

I can confirm this no longer reproduces on the dev and master channels on iOS and Android

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  MyApp() : super(key: const ValueKey('MyApp'));

  @override
  Widget build(BuildContext context) =>
      MaterialApp(home: Material(child: MyWidget(Colors.green)));
}

class MyWidget extends StatelessWidget {
  const MyWidget(this.color);
  final Color color;
  @override
  Widget build(BuildContext context) {
    debugPrint('$color');
    return ColoredBox(color: color);
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.26.0-17.1.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-17.1.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision c40e5294dd (6 days ago), 2021-01-29 08:44:18 -0800
    • Engine revision 5d3477eab4
    • Dart version 2.12.0 (build 2.12.0-259.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86    • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios            • iOS 14.4
    • macOS (desktop)                    • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome                    • web-javascript • Google Chrome 88.0.4324.96
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel master, 1.26.0-18.0.pre.187, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.187 at /Users/tahatesser/Code/flutter_master
    • Framework revision e96ce0ecb4 (5 hours ago), 2021-02-04 02:46:03 -0500
    • Engine revision 5e50f4bad3
    • Dart version 2.12.0 (build 2.12.0-285.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86    • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios            • iOS 14.4
    • macOS (desktop)                    • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome                    • web-javascript • Google Chrome 88.0.4324.96
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

@jason-simmons
Can you still reproduce it?
I agree with @iapicca, this could use test to prevent it from happening if it isn't already added
Thank you


Fix broken links in user docs (description fields)

Data Plane API - Pull Request
Fix broken links in user docs (description fields).
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

Adding Approved-Supression as it's a false positive (The flagged suppressions were already approved and merged in https://github.com/Azure/azure-rest-api-specs/pull/27370)


Add new keyboard input emulation mode based on clipboard

[x] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
I use a custom keyboard layout on my Mac. Some characters are UTF-8 and so I can't input them. This is an inconvenience because these characters are required to type proper French.
Describe the solution you'd like
Add a keyboard emulation that uses the clipboard. You could paste a single character every time I press a key on my keyboard. This would help support all the characters seamlessly.
Describe alternatives you've considered
I can't use --hid-keyboard because I'm not running Linux.
Additional context
N/A.

Thank you for your reply!
I remember trying --prefer-text and it didn't work properly. I'll try again and report back.

@rom1v I can't input « using --prefer-text. Any ideas if this would be possible ?
❯ scrcpy --turn-screen-off --stay-awake --prefer-text
scrcpy 1.22 <https://github.com/Genymobile/scrcpy>
/opt/homebrew/Cellar/scrcpy/1.22_1/sha...ped. 56.3 MB/s (40955 bytes in 0.001s)
[server] INFO: Device: Xiaomi Mi Note 10 Lite (Android 11)
2022-02-18 17:37:09.989 scrcpy[56486:741333] INFO: Renderer: metal
2022-02-18 17:37:10.007 scrcpy[56486:741333] INFO: Initial texture: 1080x2336
[server] INFO: Device screen turned off
[server] WARN: Could not inject char u+00ab
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00ab
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00ab
[server] WARN: Could not inject char u+00bb
[server] WARN: Could not inject char u+00a0
[server] WARN: Could not inject char u+00a0
[server] WARN: Could not inject char u+202f

If you change your Android keyboard, does it work?

@rom1v Friendly bump. 🙇♂

I don't know, it should work with Gboard. You could also try OpenBoard or Simple Keyboard (in F-droid).

I can't input « using --prefer-text. Any ideas if this would be possible ?

Oh, for « that's expected. Only ASCII and some accented characters could be injected: https://blog.rom1v.com/2018/03/introducing-scrcpy/#handle-accented-characters

@rom1v Thanks. I can confirm that AirDroid uses paste emulation and I haven't had any issues using it (except that it's commercial and screen streaming is very laggy). What kind of quirks does it have?
The main downside of using the HID method is that it requires me to port QWERTY-fr to Android. I'm not sure that configuring custom dead keys is possible at all on Android so this is a significant issue for advanced usage.

(apart from the fact it's not available yet on macOS)

It is available since v1.23: https://github.com/Genymobile/scrcpy/releases/tag/v1.23

@rom1v Awesome! I just need to port QWERTY-fr to Android, and it will be mostly okay (without proper dead keys support hough).


release notes

Current coverage is 96.86% (diff: 100%)

Merging #1730 into master will not change coverage

@@             master      #1730   diff @@
==========================================
  Files            87         87
  Lines         11215      11215
  Methods           0          0
  Messages          0          0
  Branches       1882       1882
==========================================
  Hits          10863      10863
  Misses          210        210
  Partials        142        142

Powered by Codecov. Last update 823c7f2...91f07a6


Scaffolder gitlab mr publish v2

Recreating the PR as the previous PR had missed sign off commits #7940
Hey, I just made a Pull Request!

The change is to add publish action to create Gitlab Merge Request with catalog information changes added to it. This is done during component registration for the services to have an skeleton of the backstage catalog info yaml included.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@Balasundaram we need a changeset for this. There some info on how to do that.

Hi @benjdlambert @Rugvip I have made all the fixes and added the changeset for your review. Please approve at your convenience.

Hi, can you re-approve the workflow @benjdlambert @Rugvip

Hi @benjdlambert  thanks for approving. I was going through the checks and found the markedown is failing due to the changeset text
https://github.com/backstage/backstage/runs/4482153578?check_suite_focus=true
Please can you help me what am i missing here.
Also looks like E2E check test is failing due to a plugin dependency. Please can you help here.

Need to spell Gitlab like GitLab. :)

Fixed @benjdlambert  please can you approve

Hi @benjdlambert  please can you approve the workflow, i have fixed the spelling

Hi @benjdlambert thanks, all the check are good, please can you approve for merge.
Thanks
Bala

Thanks for this! Finally good to get in!

Thanks @benjdlambert  @Rugvip @satrox28 for your help. Appreciate it.


llvmPackages_15: init at 15.0.6

Description of changes
I've tested that all of the llvmPackages_15 set builds on x86_64-linux, aarch64-linux, x86_64-darwin, and aarch64-darwin. I have not (yet) checked that cross compilation still works.
Working through getting this to build on the above platforms again, now that this PR targets staging.

This PR contains a few different kinds of changes:

introduces llvmPackages_15, the first six commits
switches to ninja where possible, the next two commits
other LLVM package updates, unrelated to fixing build issues, the next two commits
updates for the lit package, the next commit
mechanical changes to make it easier to override the monorepo source used in the package set, the next commit
bumps llvmPackages_latest
...

If required, I can split these changes up into separate PRs.

TODOs:

[x] rebase onto updated staging from upstream
[x] bump to LLVM 15.0.3
[x] bump to LLVM 15.0.4
[x] bump to LLVM 15.0.5
[x] bump to LLVM 15.0.6
[ ] bump to LLVM 15.0.7
[x] move back to targeting master
[ ] follow up PR bump llvmPackages_latest (targeting staging); 9088010e23bda5fb156901d8f577cbfad1e6530c was dropped from this PR
[ ] backport llvmPackages_15
[x] fix the libcxxabi build on non-x86 (https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990300128)
[x] fix the LLDB manpages package (https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990583868)
[x] fix the compiler-rt build on macOS (https://github.com/NixOS/nixpkgs/pull/194634#issuecomment-1272116014)

[ ] follow up PR now that we're targeting staging, try dropping this patch (postponed)

[x] fix the LLDB build on x86_64-darwin (https://github.com/NixOS/nixpkgs/pull/194634#issuecomment-1272129132)

[x] backport to llvmPackages_{13,14} (#195013)

[x] fix the skipped LIT tests (https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990397994)
[x] update lit
[ ] follow up PR spin off the monorepo source changes into a separate PR against llvmPackages_{13,14,15} (https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990569370)
[x] enable LLVM tests on darwin
[x] enable polly by default again and test (see this comment)

[ ] follow up PR test/fix enablePolly in llvmPackages_{12,13,14}

[ ] update this PR with the changes from:

[x] #190908
[x] #181764
[ ] #186575

[x] verify still needed; add a regression passthru test?

appears to be still needed
[ ] follow up PR can add a regression test that links against a symbol in libclang-rt and test against clangNoLibc (with lsan/asan/ubsan/fuzzer variants tested too)

[ ] #193636

[ ] verify still needed
[ ] follow up PR add a regression passthru test?

[x] #185766

[x] verify still needed; add a regression passthru test?

appears to be no longer needed; libc++abi.so didn't seem to be linked against older libc++abi on non-darwin anyways (where the default stdenv wasn't LLVM based) and now we unconditionally use the clang from the same package set which has libcxx set to null and thus doesn't try to link in any libc++abi
[ ] follow up PR can still add a regression test (gated on enabledShared in libcxxabi) that looks at the output of llvm-readelf --needed-libs lib++abi.{dylib/so} and scans it for libc++abi deps that aren't the libc++abi being scanned

[x] #196909
[x] #191372 ?
[x] #190936

[ ] TODO: test

[x] #82131

[ ] TODO: test

[x] #199844

[ ] follow up PR could do with a regression test or two

[x] #197674

[ ] TODO: test

[x] #184408
[x] #205355
[x] #193004
[x] #201268? need to double check but like #185766 I don't think this is needed
[x] #201485? don't think this is needed either, need to verify
[ ] #211401
[ ] #211230
[ ] #211161
[ ] #206742

https://github.com/NixOS/nixpkgs/commit/33afbf39f6f2a6b37e99f070ba7d17a28c416d02#diff-8ebeb076fd6d6845a2a4af53beeeed54b5e15b0e28d79a32cb15db0fa394b645

[ ] #211687

https://github.com/NixOS/nixpkgs/commit/f5e63a0e9e4b1846964dcaa61a5325b7b70a3a39#diff-3e0243503064c4638bf30720e8c271b4589a7bf114b4e92ebbee2f708040b2e4

[ ] inflight PRs (if these are merged before this PR we should duplicate their changes onto llvmPackages_15; if this PR is merged first we should update these PRs to change llvmPackages_15) — not an exhaustive list:

[ ] #207863
[ ] #173498
[ ] #163314
[ ] #207325
[ ] #155489
[ ] #144302 (also not in _14 yet)
[ ] #163878
[ ] #181108
[ ] #211728

https://github.com/NixOS/nixpkgs/pull/125132/commits/8f80568885d1b37cccbede85143c00711b19390c

Checks:

[ ] llvmPackages_15.*
[ ] passthru tests
[ ] pkgsStatic? stdenv tests? pkgsCross for freeBSD?
[ ] rdeps with nixpkgs-review

Closes #191132.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

With https://github.com/NixOS/nixpkgs/pull/194634/commits/ab9d3df63862da93d8a229ea379efb7b50e8692b, libcxx-abi (and the rest of llvmPackages_15) builds fine on aarch64-linux. Darwin is now hitting an unrelated issue in compiler-rt; I'll tackle that next.
After that:

[ ] the skipped LLVM lit tests https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990348787
[ ] lldb-manpages https://github.com/NixOS/nixpkgs/pull/194634#discussion_r990452271

Fixed one compiler-rt build issue, hit another one.
compiler-rt's build now attempts to detect whether the ld used automatically does codesigning, based on version. Our cctools ld is too old for this but postLinkSignHook handles codesigning for us, regardless.
Unfortunately there doesn't seem to be a way to communicate this to the compiler-rt build machinery. In the interest of avoiding making another patch, I tried to add sigtool to the derivation and just let the compiler-rt build sign some dylibs twice but unfortunately compiler-rt's build uses --sign instead of -s which the sigtool in nixpkgs has not been updated to support.
I opened a PR for this (#194994) but given that sigtool has many transitive deps and that that PR is likely to trigger many rebuilds I think it's probably faster to just add a compiler-rt patch.

With https://github.com/NixOS/nixpkgs/pull/194634/commits/974ea1c842744909fff714babe740dabd4d2e67e this now builds on aarch64-darwin.
Testing x86_64-darwin now; hopefully it Just Works 🤞.

As of now, the llvmPackages_15 set seems to build fully on x86_64-linux, x86-64-darwin, aarch64-linux, and aarch64-darwin.
Getting lit to discover psutil so it doesn't skip tests is the last item on my TODO list for this PR but given that this isn't a regression, this probably isn't worth blocking merging this PR over.
I'm marking this PR as ready to review and I'll take a look at psutil tomorrow.

Earlier today I realized that there have been some changes to llvmPackages_git (which this PR uses as a starting point for llvmPackages_15) since this PR was opened.
From master it's just:

[x] #190908; I've rebased this PR to include these changes

From staging (i.e. git log feature/llvm-15..origin/staging  --oneline -- pkgs/development/compilers/llvm/) currently it looks like:

[ ] #186575

uses a common patch file

[ ] #193636
[ ] #185766

AFAICT all of these PRs were merged into staging instead of master because of rebuild concerns due to affected stdenvs/packages (a constraint this PR doesn't have since we're not bumping llvmPackages_latest yet) and not because they depend on other changes in staging.
So, we can either replicate the changes above on llvmPackages_15 in follow up PRs after this package is merged (seems suboptimal), replicate the changes now while still targeting master (this is fine for the latter two PRs linked above but will cause a merge conflict for #186575 in staging if we want to continue to use a common patch file), or we can replicate the changes now after switching this PR to target staging (no merge conflicts).
The latter solution (switching this PR to target staging) seems cleanest to me but I'm not sure what the convention is here.
@lovesegfault do you have an opinion?

@rrbutani Targeting staging is unfortunate since it'll make this PR take longer to hit master, but I think it might be the easiest thing for us to do. Besides, a week or so of wait time isn't the end of the world.
If you chose to retarget this PR to staging, also add a commit bumping _latest, since you might as well eat the rebuilds in that case :)

mesa 22.1.7 doesn't like LLVM 15: https://gist.github.com/ivan/326b2ee262f816a74e9d682bd6654175#file-gistfile1-txt-L2096-L2184 and this might need
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index cb3eee5ddd2f..abf174d3f777 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -20950,7 +20950,7 @@ with pkgs;
   libGLU = mesa_glu;

   mesa = callPackage ../development/libraries/mesa {
-    llvmPackages = llvmPackages_latest;
+    llvmPackages = llvmPackages_14;
     inherit (darwin.apple_sdk.frameworks) OpenGL;
     inherit (darwin.apple_sdk.libs) Xplugin;
   };

@lovesegfault apologies for the delay. The TODO list is still accurate; I'll try to finish these tasks and get this PR ready for merge today.

Can we merge this PR as is and do the minor version bumps and other improvements in separate PR-s ?
My motivation is to have rustc with llvm15 available as soon as possible.
Thank you for your efforts @rrbutani !

Apologies for the delay, again.
@lblasc I do want to try to incorporate the changes that have landed in llvmPackages_14/git in the interim before this PR is merged but I agree that adding regression tests and some of the other checklist items can be done in follow up PRs.
I've got llvmPackages_15 bumped to 15.0.6 and building, locally, on x86_64-linux; I'm still waiting on Darwin/aarch64-linux before I push (I was running into unrelated issues in dependencies on those platforms yesterday — hopefully pulling in new changes from staging will fix).
I think we've got a little bit of time before the next staging-next cycle starts anyways: #203426

You should drop bumping the default from this PR.  That means much easier merge, directly to master, without needing to care for all possible regressions.
And bump the default separately later.  I'd even say that bumping llvm default is worth a separate jobset; ping me to create that when you want it.
Also note that there were multiple changes to llvm 14 expressions (some even in staging-next..staging right now) and they probably should be included in 15 as well.  It feels like the copying workflow might be more trouble than worth in the past few years, but...

Result of nixpkgs-review pr 194634 run on x86_64-linux 1

1 package marked as broken and skipped:

jucipp

3 packages failed to build:

faustStk
hqplayerd
magnetophonDSP.ConstantDetuneChorus

76 packages built:

Literate
binaryen
btdu
cheesecutter
clang-tools_15
clang_15 (llvmPackages_15.clang ,llvmPackages_15.libstdcxxClang)
dtools
dub
emscripten
faust (faust2)
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustPhysicalModeling
faustlive
gtkd
guitarix
halide
kapitonov-plugins-pack
klee
ldc
lit
lld_15 (llvmPackages_15.lld)
lldb (lldb_14 ,llvmPackages_14.lldb ,llvmPackages_latest.lldb)
lldb_10 (llvmPackages_10.lldb)
lldb_11 (llvmPackages.lldb ,llvmPackages_11.lldb)
lldb_12 (llvmPackages_12.lldb)
lldb_13 (llvmPackages_13.lldb)
lldb_15 (llvmPackages_15.lldb)
lldb_9 (llvmPackages_9.lldb)
llvmPackages_14.openmp (llvmPackages_latest.openmp)
llvmPackages_15.bintools
llvmPackages_15.bintools-unwrapped
llvmPackages_15.bintoolsNoLibc
llvmPackages_15.clang-manpages
llvmPackages_15.libclang (llvmPackages_15.clang-unwrapped)
llvmPackages_15.clangNoCompilerRt
llvmPackages_15.clangNoCompilerRtWithLibc
llvmPackages_15.clangNoLibc
llvmPackages_15.clangNoLibcxx
llvmPackages_15.clangUseLLVM
llvmPackages_15.compiler-rt (llvmPackages_15.compiler-rt-libc ,llvmPackages_15.compiler-rt-no-libc)
llvmPackages_15.libcxx
llvmPackages_15.libcxxClang
llvmPackages_15.libcxxStdenv
llvmPackages_15.libcxxabi
llvm_15 (llvmPackages_15.llvm)
llvmPackages_15.libunwind
llvmPackages_15.lldb-manpages
llvmPackages_15.llvm-manpages
llvmPackages_15.openmp
llvmPackages_15.stdenv
magnetophonDSP.CharacterCompressor
magnetophonDSP.CompBus
magnetophonDSP.LazyLimiter
magnetophonDSP.MBdistortion
magnetophonDSP.RhythmDelay
magnetophonDSP.VoiceOfFaust
magnetophonDSP.faustCompressors
magnetophonDSP.pluginUtils
magnetophonDSP.shelfMultiBand
mooSpace
onedrive
open-music-kontrollers.mephisto
rund
sambamba
tambura
tilix
tinygo
vscode-extensions.vadimcn.vscode-lldb

New inflight PR #207863

Any updates here? It would be nice to have this in the next staging cycle so Mesa works correctly on RDNA3.

Are some of the files just copied over?

Yes a big chunk is copied because we reproduce what is done when adding a new version:

Packaging new LLVM versions as soon as the first RC is out (that's pretty simple/straightforward as it's basically just copying llvmPackages_git and switching to the right version

https://github.com/NixOS/nixpkgs/issues/171047#issue-1221879536

Does this need anything else before merge to staging? As long as it's not moving to default, it seems like this is a good thing to get into staging at this point -- especially if now alternate PRs are popping open assuming this isn't already in progress!

Couple of things I noticed.

llvmPackages_latest needs to be set to 15
mesa won't build with llvm 15 because it needs spirv-llvm-translator to be version 15, and even with that it seems to fail to build for some reason.
Also that spirv-llvm-translator thing has the wrong download hash for version 15 in pkgs/development/compilers/spirv-llvm-translator/default.nix. I got hash = "sha256-OsDohXRxovtEXaWiRGp8gJ0dXmoALyO+ZimeSO8aPVI=";

llvmPackages_latest needs to be set to 15

I think we want this PR to go into master and if we’re happy with things working (like mesa), a follow-up PR that bumps llvmPackages_latest can go into staging.

Does this need anything else before merge to staging?

I think we want this PR to go into master and if we’re happy with things working (like mesa), a follow-up PR that bumps llvmPackages_latest can go into staging.

Yup, as @vcunat suggested this PR targets master and doesn't bump llvmPackages_latest.

There are still changes I want to make (adding regression tests, fixing cross-compilation and use of the llvmPackages_15's stdenv as a cross-compiler) but all of that can happen in follow up PRs; the last things blocking this PR are:

[ ] getting llvmPackages_15.* to build again

currently .llvm builds but dependent packages fail during configure when trying to find libPollyISL.a (a mixup between the out and lib outputs; just needs a patch)

[ ] adding in the remaining changes that have been made to llvmPackages_14 in the interim

#186575 (and possibly #193636) are what's left on my list
but I'm not super confident I caught everything; I'd appreciate it if others could verify that there's nothing missing in the list in the OP

I'm planning to finish the above today; I'll keep this post updated with the current status.

Any news on it?

There is a similar PR at https://github.com/NixOS/nixpkgs/pull/209536. Can we combine the changes somehow?

There is a similar PR at #209536. Can we combine the changes somehow?

We have one commit in common: https://github.com/NixOS/nixpkgs/pull/194634/commits/f6b76b7a47831c041b9f031955ebbe8bcaf7acd8

[ ]  llvm on x86_64-darwin
[ ]  waiting on llvmPackages_15.* to build on:

[ ]  x86_64-darwin: 3 failing LLVM tests

So I assume it does build on x86_64-darwin with doCheck set to false, as does the other PR and even llvmPackages_14?

I was struggling to build llvmPackages_15 with 15.0.7 to use as my stdenv. Is there an easy way to do that?
I've tried various combinations of llvmPackages_15.override with gitRelease, officialRelease, and monorepoSrc without any luck. Any suggestions?
I appreciate the refactoring you've done here and hope to be able to easily build LLVM (including wrapping bintools, providing everything necessary to use it as a stdenv, etc.) from arbitrary commits.

I was struggling to build llvmPackages_15 with 15.0.7 to use as my stdenv. Is there an easy way to do that?
I've tried various combinations of llvmPackages_15.override with gitRelease, officialRelease, and monorepoSrc without any luck. Any suggestions?

Ah, I guess this could use some better documentation.
@ConnorBaker Unless you're trying to grab LLVM from somewhere other than the llvm/llvm-project repo, you shouldn't need to set monorepoSrc; just officialRelease (to grab a release like 15.0.7) OR gitRelease (to grab a commit like https://github.com/llvm/llvm-project/commit/d5cbaa047004335a29dc3bcaf6aaa1c26fc27f36).
For 15.0.7 I think this should do the trick:
(nixpkgs.llvmPackages_15.override {
  officialRelease = {
    version = "15.0.7";
    sha256 = "sha256-wjuZQyXQ/jsmvy6y1aksCcEDXGBjuhpgngF3XQJ/T4s=";
  };
}).libcxxStdenv

Is there a reason for this pull request to be a draft?

Is there a reason for this pull request to be a draft?

It is a bit complicated, complex and it still does not compile all tier-1 architectures.

it still does not compile all tier-1 architectures.

I think it does, if we disable the LLVM tests as in LLVM 14.

This is still blocking support for RDNA3 hardware in Mesa, and the hardware itself is becoming widely available. Can we do anything to speed this up so we catch the next staging train?

@ofborg build llvmPackages_15.compiler-rt llvmPackages_15.compiler-rt.passthru.tests llvmPackages_15.libcxx llvmPackages_15.libcxx.passthru.tests llvmPackages_15.libcxxabi llvmPackages_15.libcxxabi.passthru.tests llvmPackages_15.lldb llvmPackages_15.lldb.passthru.tests llvmPackages_15.llvm llvmPackages_15.llvm.passthru.tests llvmPackages_15.openmp llvmPackages_15.openmp.passthru.tests

Rebuilding as there seems to be an aarch64-linux regression on the other PR: https://github.com/NixOS/nixpkgs/pull/209536#issuecomment-1402579137

@ofborg build llvmPackages_15

It's OK for me if you push.

I'd say get the last 1-2 things done if they really can't be done afterwards, run tests if necessary, and then land this - dealing with fallout afterwards directly on master.
The upside to this is, that while contributing a fix for a specific issue to this large changeset is not very ergonomic for other users, fixing whatever they need in a PR themselves is very doable for downstream packages in nixpkgs.

Agreed. I've got all of the remaining things (bump to 15.0.7, fixing the license, "fixing" x86_64-darwin LLVM tests, applying the changes from the 5 PRs that merged since I last checked) resolved in my local checkout with the exception of #193636 which I still haven't been able to reproduce (I think I need to be on a Linux host; I'll have access to one in a couple of hours).
@wegank is it okay if I push or should I wait for the ofborg run you kicked off to finish?

Apologies for the delay, again.
I couldn't reproduce #193636 (the test case in #151879 passes and I don't see the extra header dirs on macOS or Linux) so I think this PR is pretty much ready.
I'm waiting on builds to finish for:

[x] aarch64-linux
[ ] aarch64-darwin
[ ] x86_64-linux
[ ] x86_64-darwin
[ ] i686-linux
[ ] armv7l-linux

building on a Pi so this will take me a while; if anyone has access to a machine capable of running 32-bit ARM code (like the nix community aarch64 build box)  and is willing to test building the package set it'd be much appreciated!

Additionally, I'm testing that:

[x] the packages in this script eval (cross compiling LLVM + using LLVM as a cross-compiler)

with the exception of using LLVM as a cross-compiler on darwin which runs into infinite recursion issues that I haven't been able to get to the bottom of

[ ] pkgsCross.x86_64-freebsd.boost builds from an x86_64-linux host where llvmPackages has been overridden to point to llvmPackages_15

this builds as of #211230 and I want to make sure I replicated those changes correctly

I've opened a tracking issue for the follow-up work to this PR: #213033; I'll fill in that issue and open a (draft, contingent on this PR getting merged) follow-up PR bumping llvmPackages_latest on staging later today.

@rrbutani

Is there a reason for this pull request to be a draft?

It is a bit complicated, complex and it still does not compile all tier-1 architectures.

I believe this PR is ready to be reviewed. Can you remove the draft status? I understand that it's not 100% completed, but it's ready to be reviewed (I believe).
Personally I really want this PR to be merged (in my case because of Zig), and I know many people IRL that feel similar. Since almost all issues are resolved, I believe it shouldn't be a draft (for example, #209536 is not a draft).

@rrbutani

Is there a reason for this pull request to be a draft?

It is a bit complicated, complex and it still does not compile all tier-1 architectures.

I believe this PR is ready to be reviewed. Can you remove the draft status? I understand that it's not 100% completed, but it's close enough (I believe, based on my undestanding of this thread).
Personally I really want this PR to be merged (in my case because of Zig), and I know many people IRL that feel similar. Since almost all issues are resolved, I believe it shouldn't be a draft (for example, #209536 is not a draft).

For Zig, I think we need assistance from the darwin maintainers, since (last time I tried) I ran into errors in rrbutani's #191152, and even applying the fix there didn't help (?).

Result of nixpkgs-review pr 194634 run on x86_64-linux 1

25 packages built:

clang-tools_15
clang_15 (llvmPackages_15.clang ,llvmPackages_15.libstdcxxClang)
lld_15 (llvmPackages_15.lld)
lldb_15 (llvmPackages_15.lldb)
llvmPackages_15.bintools
llvmPackages_15.bintools-unwrapped
llvmPackages_15.bintoolsNoLibc
llvmPackages_15.clang-manpages
llvmPackages_15.libclang (llvmPackages_15.clang-unwrapped)
llvmPackages_15.clangNoCompilerRt
llvmPackages_15.clangNoCompilerRtWithLibc
llvmPackages_15.clangNoLibc
llvmPackages_15.clangNoLibcxx
llvmPackages_15.clangUseLLVM
llvmPackages_15.compiler-rt (llvmPackages_15.compiler-rt-libc ,llvmPackages_15.compiler-rt-no-libc)
llvmPackages_15.libcxx
llvmPackages_15.libcxxClang
llvmPackages_15.libcxxStdenv
llvmPackages_15.libcxxabi
llvm_15 (llvmPackages_15.llvm)
llvmPackages_15.libunwind
llvmPackages_15.lldb-manpages
llvmPackages_15.llvm-manpages
llvmPackages_15.openmp
llvmPackages_15.stdenv

wegank said:

I think I'll merge it if Zig builds on my (slow) aarch64-linux machine.

I built the following packages on my Linux AArch64 machine. They all built successfully at commit d231d18e4aa5e1d00f86b4f484f9e4344538e3ea + my two Zig patches (#210324):
30 packages built:
cargo-lambda
cargo-zigbuild
clang-tools_15
clang_15
clipbuzz
lld_15
lldb_15
llvmPackages_15.bintools
llvmPackages_15.bintools-unwrapped
llvmPackages_15.bintoolsNoLibc
llvmPackages_15.clang-manpages
llvmPackages_15.libclang
llvmPackages_15.clangNoCompilerRt
llvmPackages_15.clangNoCompilerRtWithLibc
llvmPackages_15.clangNoLibc
llvmPackages_15.clangNoLibcxx
llvmPackages_15.clangUseLLVM
llvmPackages_15.compiler-rt
llvmPackages_15.libcxx
llvmPackages_15.libcxxClang
llvmPackages_15.libcxxStdenv
llvmPackages_15.libcxxabi
llvmPackages_15.llvm
llvmPackages_15.libunwind
llvmPackages_15.lldb-manpages
llvmPackages_15.llvm-manpages
llvmPackages_15.openmp
llvmPackages_15.stdenv
zig
zig_0_9

Linux ubuntu-linux-22-04-desktop 5.15.0-41-generic #44-Ubuntu SMP Thu Jun 23 11:20:13 UTC 2022 aarch64 GNU/Linux

Also built Zig 0.10.1 on top of f80ac848e3d6f0c12c52758c0f25c10c97ca3b62 with the two PRs applied:
$ nix-build -A zig
/nix/store/g9kixfg3cy0nxpv19z8b4i8dbn8zbsxb-zig-0.10.1


Limb Darkening Calculator gives 4-parameter profile coefficients when not requested

When generating and downloading a table of limb darkening coefficients for quadratic, logarithmic, exponential, or 3-parameter profiles, a set of coefficients for the 4-parameter profile are also generated and appended to the end even when that profile is not selected. It does not seem to happen when initially selecting linear or square-root profiles though. This is not a critical bug in any way, but it can be annoying as it requires editing the downloaded file or altering the way that the coefficients are read into one's code afterward.
I am using the online tool (https://exoctk.stsci.edu/limb_darkening) which says it's running exoctk v1.2.5.

Thanks for the Issue! That is weird. I'll definitely take a look though it is low priority as you say.


Please use the available screen space to show me the explorer plot.

Request
Please make use of the available space to show the plot.
Motivation
When I see the explorer plot using the matplotlib, bokeh or plotly backend there is so much space left and the plot is so small.

Discussion

If the user selects a groupby the plot should responsively resize.
Please don't add scrollbars if its not necessary. I often see scrollbars that are not needed.

I don't think hvPlot would be adding scrollbars; presumably that's an issue at the Panel or Bokeh levels. I agree that being responsive would be good. We might also want to move the default legend location to be below the figure since that space is generally empty when there is a big bank of widgets.

+1. Hit by this again. I cannot get the explorer to use the available height.
I've tried responsive=True and sizing_mode="stretch_both without luck.


Read articles come up as unread

Actual behaviour
Articles from this feed https://www.ccc.de/de/rss/updates.xml show up as unread after the refresh (mostly through cronjob.php, not with manual refresh). Same with the ATOM-Feed.
Expected behaviour
Articles should not show up as unread again.
Steps to reproduce

Add above feed.
Mark all articles of this feed as read.
Wait for some time. (a few hours)
Check unread.

This was also confirmed with a fresh account on app.miniflux.net (running 1.2.2) where only https://www.ccc.de/de/rss/updates.xml was added.
Configuration

Miniflux version: 1.2.2
Database type and version: SQLite
PHP version: PHP 5.6.30-0+deb8u1 (cli) (built: Feb  8 2017 09:49:20)
OS: Debian Jessie
Browser: Firefox

Extra Info
see https://github.com/fguillot/picoFeed/issues/266

I have the same issue for the following two feeds:

https://ccc.de/de/rss/updates.rdf
https://blog.google/rss/

Try to go to preferences/general and set "Remove automatically read items" to "Never".
It seems that items changed status to "removed" and refreshing feed creates them again.