test: ensure any waiters are reset between tests

Fixes #
Description
I'm not 100% certain this is the cause of the test flakes as I can't reproduce them locally (ran the flaking test 1000x at 100% success rate locally), but it's safe and probably a good idea to do this anyway
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.151%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5344

Relevant Lines:
7111

💛  - Coveralls


fix: make sure users are synchronised by xp events

:tada: This PR is included in version 3.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Don't crash on printing nested types

When adding an Array or Dictionary to itself operator String() got in an
infinite loop. This commit adds a stack to operator String() (Through
the use of a new 'stringify method'). This stack keeps track of all
unique Arrays and Dictionaries it has seen. When a duplicate is found
only a static string is printed '[...]' or '{...}'.
This mirror Python's behavior in a similar case.
This fixes #28089

Array and Dictionary hashing functions have a similar bug but it's not the same. This needs a similar but different fix.

Also, VariantParser may need a similar fix.

Consider for 3.1.2
Probably together with the other mentioned fixes.

Doesn't apply cleanly on 3.0, probably not worth making a specific backport.


fuzzer 052-clkin broken

possibly a regression of some recent cleanup
+ python3 ../generate.py
Loading artix7 grid.
Loading bits from design.bits.
Loading tags from design.txt.
Compiling segment data.
Traceback (most recent call last):
  File "../generate.py", line 66, in <module>
    segmk.write()
  File "/home/mcmaster/sf/prjxray/prjxray/segmaker.py", line 268, in write
    ]) != 0
AssertionError
Makefile:16: recipe for target 'specimen_001/OK' failed
make: *** [specimen_001/OK] Error 1

Easy fix, the regression is actually not merged in yet. I'll push fix as part of PR

Maybe? it actually has another issue
python3 maketodo.py > todo.txt
Traceback (most recent call last):
  File "maketodo.py", line 24, in <module>
    (os.getenv("XRAY_DATABASE_DIR"), os.getenv("XRAY_DATABASE")))
  File "maketodo.py", line 15, in maketodo
    todos.remove(line[0])
KeyError: 'INT_L.LH0.LH12'
Makefile:20: recipe for target 'todo.txt' failed
make: *** [todo.txt] Error 1

057-bipips and 053-ctrlin are also broken like 052-clkin


Question. Dependant queries 2

There's already been a question asked about dependent queries (coming from a react-query background), but it didn't quite match my particular case.
As we know, a query will fire as soon as it is created. However, what if we only want the query to fire in certain cases? react-query, for example, has an enabled argument:
// https://tanstack.com/query/latest/docs/framework/react/guides/dependent-queries#usequery-dependent-query
const {
  status,
  fetchStatus,
  data: projects,
} = useQuery({
  queryKey: ['projects', userId],
  queryFn: getProjectsByUser,
  // The query will not execute until the userId exists
  enabled: !!userId,
})

In my particular case, I need the query to fire only for certain user roles. If cached_query had an enabled argument, I'd do something like this:
query = Query<List<ChatModel>>(
      key: queryKey,
      queryFn: _api.getChats,
      enabled: user != null && !user.isAdmin
    );

How can we conditionally execute a query in cached_query?

Hey @MichaelM-ZGuy ,
In Cached Query, the querys are only fetched if you call Query.result or listen to the stream Query.stream.
In your example:
// The queryFn below will not be called
query = Query<List<ChatModel>>(
      key: queryKey,
      queryFn: _api.getChats,
      enabled: user != null && !user.isAdmin
    );

// This calls the queryFn
await query.result

When you pass a query to a QueryBuilder the queryFn is called. This is because the QueryBuilder automatically listens to the stream (which in turn calls the queryFn).
The QueryBuilder does have an enabled flag to combat this.
So to answer your question; If you don't want the queryFn to be called until certain user roles are met then your would either:

Wrap the stream subscription/result future in a conditional based on user roles
use the enabled flag on a QueryBuilder

Hope that helps, let me know if you have any other questions.

In Cached Query, the querys are only fetched if you call Query.result or listen to the stream Query.stream.
Ah, righto, thanks for clearing that up. I found a way to make it work.


Add jest snapshot following setting button and certification page consistent

Describe the bug
This PR #48211 makes the button consistent, we can use snapshot to make sure that these section still consistent and make it easier to review future PRs
Here are the docs about snapshot https://jestjs.io/docs/snapshot-testing
Here is an example file from the codebase, that creates a snapshot https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/components/settings/certification.test.tsx

Is there any convention we follow for test cases ?
Like file structure etc.

I didn't find jest documentation on our contribution section, so I cc @raisedadead for this. they are the oldest here I think, and they could know if we have convention for them or not 👍

Can anyone of the reviewer look at my draft PR and let me know if I'm heading in the right direction.

PR is up for review.

Hey, maintainers.
CI/CD test case for my PR is failing but it's not showing what is the issue.
I ran lint:prettier locally but didn't get any issue. Please do let me know how can I fix this issue.

It tells you the name of the file that is throwing the error. In this case, it is as seen in the output for the CI job.
client/src/components/settings/settings-button.test.tsx

It is helpful to set up your editor with prettier and eslint to handle the formatting automatically.
Alternatively,
You can run npm run format before you commit and push changes. We have this script specifically to assist with formating.

Hey @raisedadead,
I ran npm run format locally. I'm getting this errors, but I haven't touched these files. Also I've prettier and eslint vscode externsion installed.
It also says unable to resolve module, but my branch is updated and all the packages are installed.

npm run format

I also tried npm run format:prettier, Below are the files that are being modified, but no changes in settings-button.test.tsx

npm run format:prettier

Because prettier is using the old format, can you check the local version of both eslint and prettier?
Prettier should be 2.8.2, and eslint 5.47.1.
If they locally aren't the same versions as package.json, npm ci should update them in the local environment.

I think that that prettier and eslint aren't installed, because I haven't faced issue in gitpod

I've updated prettier, npm ci didn't update any packages, so I've have to manually remove it npm remove prettier and install it again npm i -D prettier.
Now facing another issue. Current jest version is 27.5.1 whereas latest version is 29.3.1.  As per gatsby documentation mention here. I've to add ts-jest in jest.config.js. I had to install it via legacy-peer-deps as normal installation fails. Which is also failing for CI/CD.
Is there any way to install legacy dependency in CI/CD?

Yeab, you can include the version of the package after its name https://docs.npmjs.com/cli/v6/commands/npm-install. Ususally, I add the package name in package.json file and run npm i or npm ci, tho.
Up to you which method you choose, but make sure to not have ^ in the package.json.

It's weird that npm ci didn't work, I would have loved to know what happens if you ran npm run clean then npm ci. Doesn't matter anymore. You can find some of our npm scripts in the quick references to contribution, there are commands for easier

Hi, @nayabatir1.
Thanks for working on this.
You have gone off-track in an attempt to resolve something simple.
Let's consider what you want to achieve (we call this the scope of the PR) and what you should and should not be doing (out of scope).

Your PR aims to add/update some snapshots for the existing Jest-based tests.
Additionally, you may write more specs (test cases) because it is related.

To achieve this, you start by updating the existing tests and writing more new ones, as the case may be.
You should be able to limit your changes to the above; anything you are doing beyond that is out of scope. If you encounter issues (such as needing to install dependencies, etc., and need clarification on what it means), head over to the contributors' chat and ask for help.
Now coming to your particular troubles:

Your PR branch may sometimes go out of sync from the main branch. Sometimes just clicking the update branch button will not fix things. You need to do an actual git rebase to get the changes "in the correct order" on your PR branch. Your branch has over 33 commits as of this comment. Some of those commits are useless because the changed files are no longer relevant.
This is the source of your troubles.

I recommend you delete your local branch, create a new branch by the same name, and manually apply each change (code change).

Then make a commit and push (git push --force) to your fork. That step will clean your PR. GitHub will replace the branch in the PR.

Once you have a clean PR. Move on to rebasing against the upstream. Follow the contributing guide for the steps. Doing so will bring your local branch to par with the main branch and your final changes. This is very important to be done.
git pull --rebase upstream main

Next, could you clean up your local setup? It's messy with all the random dependency installations and troubleshooting you have been doing. We have a nice npm run-script for it npm run clean.
This will take a while, be patient.

Next, move on to setting things up the regular way: npm ci, npm run develop, or if testing npm run test

All of these steps should usually work (If tests fail, that should be expected). Please feel free to comment on your changes temporarily to ensure everything is set up correctly.
Now a note about prettier (or linting and formatting) in general:
You DO NOT need to install anything on your local machine. These dependencies that are declared and the configs in place are pre-configured to work on every machine (setup). Unfortunately, if you manually play with the versions, you are not doing it correctly.
As I explained previously, it is better to "clean up" your setup. That means running the commands shared above and bringing them at par with the main.
That's it.
Your IDE may have different versions than ours, but that does not matter.
The npm run-scripts npm run lint and npm run format will ensure the code changes are in order and compliant with the formatting we want. Only try what is necessary, which would be a good use of your time.
Jest dependency upgrade & Gatsby config instructions
Major (SemVer) version upgrades come with many breaking changes and are not simple. It would be best if you dropped the idea of doing that because it is out of the scope of your PR.
You should reevaluate the best compromise in code without upgrading (like not using TypeScript) because it can make life easier, and then discuss this with others in that chat or here.
Please don't start upgrading dependencies or changing configs because the manual says so. It would be best if you talked about it first so that you understand the scope.
I hope this helps you to tackle a feature/fix, etc.
Cheers.

hey @raisedadead, I agree with you. It would make my life much easier.
I'll reset my branch with this commit. In this commit all the test cases are passing with no unnecessary config and no dependencies were upgraded.
After that we can discuss best possible way to move forward.

I've reverted my pr to one of the previous commits. All the tests are in js. All the test cases were passed successfully . All recent changes in config were removed. No dependency were upgraded.
I understand that I went down the rabbit hole in order to fix the issues and failing test cases. A lot of pr request were created because the test were successful in my local machine but it were failing CI/CD, I don't know any other way to test the changes other than making a pr and let it run its course.
Issues that I faced, when converting my tests js -> ts

in order for ts to work properly with gatsby mock some config changes were needed.
jest-config.js has one dependency ts-jest which need jest latest version. If we want it to work with current jest version legacy dependency needs to be installed.
Even though legacy dependency installed on local system, it were failing on CI/CD.

If we are keen on converting tests to ts. Do let me know how to proceed without making any changes in the config or upgrading dependency.
I regret any inconvenience that may have been caused.

Thanks for the update @nayabatir1 – Yes, we can agree that the codebase is complex, and sometimes it is tricky to get things working.
We would like to use TypeScript. @ojeytonwilliams, can you help guide us on the nuances that Atir has identified in the pain points above? Thanks.


Research google guice + java EE + weblogic 11g

http://javaeenotes.blogspot.dk/2011/04/google-guice.html
http://luissenlabs.com/test-driven-development/
http://discursive.com/2011/01/26/creating-a-simple-google-guice-application/

Posted in wrong project. Sorry.


Adding styles found in template

Hey, great library!
I was wondering, when requiring a partial, what is one meant to do with the css property that this loader puts in the return object?
That is, I see that if I define styles inside a partial then a string of corresponding CSS can be found at require('./partial.html').css. Is there then a way to pass that to webpack, or to Ractive, to be handled? Or do you just create a new style tag in the DOM for it, or what?
Thanks!

The output of the require is an options object you can pass into Ractive.extend(...), it'll handle the css (with scoping), template, and script params.

I saw that, thanks. So it's not really meant to be used with partials, right? I see the usefulness for components, just not sure if I'm missing something for partials.

There is a way to use it for partials, but it's kind of hacky. After you make a Ractive instances or class, you can add partial template definitions to the partials property. You're going to need some object introspecting to see exactly where the data structures line up.


Fix path in ConfigureNLog

Described at
https://github.com/NLog/NLog/issues/641#issuecomment-180731577

Ignore Travis, it's not working yet with DNU


Add new bulk create constructor without optional _id field

Change (latest - revision 2)
Added new create_no_id and new_no_id constructors/helpers to support bulk create operations where no _id field is required.
Change (revision 1)
Changed types to id: Option<S> when _id is optional in the bulk request, otherwise, keep id parameter as String.
This change is making the Bulk operation constructor parameters more closely match the Bulk API, specifically when _id is required or not.
Summarized from the docs: https://www.elastic.co/guide/en/elasticsearch/reference/7.10/docs-bulk.html#bulk-api-request-body

create: _id (optional, string)
delete: _id (required, string)
index: _id (optional, string)
update _id (required, string)

Issues Resolved
Related to, and may close issue #241 .
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia take a look?
Regarding a breaking change: if it can be avoided it's best. Then we don't need to do a major release and break users. You can deprecate the old method.

I also don't feel this warrants a breaking version bump just for this, however there is an opportunity where you could PR a non-breaking change directly into 2.x and make the breaking change in main. Then it'll be usable sooner via a minor version, and the "corrected" version can just wait for whenever we cut a 3.0.0

Thanks for the review, I accepted all suggestions and added an entry to the changelog.


Detect Github repository when 'repo' is not set

We decided to not offer the 'empty repo' option for now.


After updating my ComfyUI, I can no longer see the resource monitoring display

After updating my ComfyUI, I can no longer see the resource monitoring display

+1 mee too

Same here, no Crytools showing on the screen

That's strange, I'm on the latest ComfyUI and also using the beta frontend (but it works on 1.3.44 as well), and I don't have any problem. I'm on ComfyUI portable btw

Check if Crystools is updated and the position is set on top:

Maybe there is a conflict with another node? 🤔

Hello everyone,
I have the same problem here.
I also use ComfyUI Portable version, in the settings the position is on TOP, but I no longer see the resource monitor.
I used the default node for SD 3.5 with without further addition.
Have a nice day,

@Darux86 Can you try disabling these extensions one by one?

I don't have those and I know for sure the other ones are not conflicting

Today I'll check it!

Hey All, having this issue - I was having this same issue and came here to look for a thread like this. After seeing all the screenshots of other users Settings menus, I decided to go check my own. While doing so, I noticed a Notification in the top of the menu saying something like you're using the new Beta design or layout or something similar to that. Unfortunatley I didn;t know to look out for it so I was unable to grab a screenshot, but it's hard to miss.
I thought I had seen this before and didn't think much of it but this time I clicked the X to dismiss it and the Resource Monitoring Display suddenly appeared as expected. So maybe try that, it's a very easy fix if it happens to work for you.

Hey All, having this issue - I was having this same issue and came here to look for a thread like this. After seeing all the screenshots of other users Settings menus, I decided to go check my own. While doing so, I noticed a Notification in the top of the menu saying something like you're using the new Beta design or layout or something similar to that. Unfortunately I didn't know to look out for it so I was unable to grab a screenshot, but it's hard to miss.
I thought I had seen this before and didn't think much of it but this time I clicked the X to dismiss it and the Resource Monitoring Display suddenly appeared as expected. So maybe try that, it's a very easy fix if it happens to work for you.

it worked for me, thanks!

Culprit is here: https://github.com/crystian/ComfyUI-Crystools/blob/03a61d690379f22c6bffc42ea4845f797deb316c/web/monitor.js#L711
It is using default value that does not match the default value declared in the frontend repo. I would advise using the new settings api binded on app.extensionManager to access the setting value to properly handle the default value.
// Get the value of a setting
const value = app.extensionManager.setting.get('TestSetting')

Hey All, having this issue - I was having this same issue and came here to look for a thread like this. After seeing all the screenshots of other users Settings menus, I decided to go check my own. While doing so, I noticed a Notification in the top of the menu saying something like you're using the new Beta design or layout or something similar to that. Unfortunately I didn't know to look out for it so I was unable to grab a screenshot, but it's hard to miss.
I thought I had seen this before and didn't think much of it but this time I clicked the X to dismiss it and the Resource Monitoring Display suddenly appeared as expected. So maybe try that, it's a very easy fix if it happens to work for you.

yes it working? thanks

yes it working! thanks

Confirmed working…

Hey All, having this issue - I was having this same issue and came here to look for a thread like this. After seeing all the screenshots of other users Settings menus, I decided to go check my own. While doing so, I noticed a Notification in the top of the menu saying something like you're using the new Beta design or layout or something similar to that. Unfortunately I didn't know to look out for it so I was unable to grab a screenshot, but it's hard to miss.
I thought I had seen this before and didn't think much of it but this time I clicked the X to dismiss it and the Resource Monitoring Display suddenly appeared as expected. So maybe try that, it's a very easy fix if it happens to work for you.

Worked too here :) Thnak you :)

大家好，遇到这个问题 - 我遇到了同样的问题，来到这里寻找这样的线程。在看到其他用户的所有屏幕截图后 设置 菜单，我决定去检查我自己的。在此过程中，我注意到菜单顶部有一个通知，上面写着您正在使用新的 Beta 设计或布局或类似内容。不幸的是，我不知道要注意它，所以我无法截取屏幕截图，但很难错过。
我以为我以前见过这个，并没有多想，但这次我点击 X 将其关闭，资源监控显示突然如预期般出现。所以也许可以试试，如果它恰好适合你，这是一个非常简单的解决方法。

是的，它有效！谢谢

good

Hey All, having this issue - I was having this same issue and came here to look for a thread like this. After seeing all the screenshots of other users Settings menus, I decided to go check my own. While doing so, I noticed a Notification in the top of the menu saying something like you're using the new Beta design or layout or something similar to that. Unfortunately I didn't know to look out for it so I was unable to grab a screenshot, but it's hard to miss.
I thought I had seen this before and didn't think much of it but this time I clicked the X to dismiss it and the Resource Monitoring Display suddenly appeared as expected. So maybe try that, it's a very easy fix if it happens to work for you.

yes it working! thanks

The screenshot is very helpful. Thanks!


Not compatible with package manager

Hi, I thought it might be simpler to pull this repo into different projects if it had a package manifest so that the package manager can recognize it.

Not familiar with how to do that, but if you wanna put in a PR I'd be happy to add it!


Updated arrow-backwards icon to match arrow-upward, arrow-forward, an…

Description
Updated arrow-backwards icon to match arrow-upward, arrow-forward, and arrow-downward.
https://switchcomm.atlassian.net/browse/DT-14?atlOrigin=eyJpIjoiNGVlODE5YzJjYjk3NDA5NWFiNDFjNTBkOGFiNjExMmYiLCJwIjoiaiJ9
Pull Request Checklist

[x] Review the contribution guidelines.
[x] Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
[x] Ensure all gulp scripts successfully compile.
[x] Provide a description what is being changed, extended, or removed.
[x] Link to any issue(s) this request is resolving.

@dialpad-drew Will review this when he gets back from vacation, reviewing changes to an svg is outside of my area of expertise


"Module not found in bundle"  when using LazyIcon

I'm using the new LazyIcon component in my ReactJS+Vite application and getting this error:
Module not found in bundle: ./icons/ChevronRight.
My component code is as follows:
import { IconNames, LazyIcon } from 'untitledui-js';
export const IconButton = ({name}) => {
  return (
       <button>
          <LazyIcon name={icon} />
      </button>
)
{

and I use it like so:
<IconButton name="ChevronRight"/>

Do you know what could be going on ? Thanks!

Thank you @anneclairelh for pointing this out, this issue would be resolved shortly

@anneclairelh, run npm i untitledui-js@latest in your terminal and then restart your development environment. The issue has been resolved.
For a better implementation with typesafety
`import { IconNames, LazyIcon } from "untitledui-js";
export const IconButton = ({ name }: { name: IconNames }) => {
return (

Button Title

);
};
`
Thank you @anneclairelh once again for pointing this out


[Bug] Duckduckgo not working

With environment variable
Okay i followed your usage guide and set ROFI_SEARCH to ddgr.
When i start rofi-search it displays:
{"prompt":"search","input action":"send"}
and waits for input but doesn't open the search gui.
When i type something into the commandline and hit enter this error pops up (e.g. "a"):
undefined:1
a
^

SyntaxError: Unexpected token a in JSON at position 0
    at JSON.parse (<anonymous>)
    at ReadStream.<anonymous> (/usr/lib/node_modules/rofi-search/rofi-search:80:36)
    at Array.forEach (<anonymous>)
    at ReadStream.<anonymous> (/usr/lib/node_modules/rofi-search/rofi-search:78:22)
    at ReadStream.emit (node:events:527:28)
    at emitReadable_ (node:internal/streams/readable:601:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)

Node.js v17.7.2

Without environment variable
Okay after that i tried it without the environment variable set but no googler installed.
Then the GUI opens and when i type something in it, it immediately crashes and shows this error:
Can not find "googler" executable.
BlocksMode-Message: 18:57:03.494: Child 257334 exited abnormally

Which makes sense because googler isn't installed. But shouldn't there be a fallback if googler is not installed to use ddgr?
Information about system and installation
I'm using endeavouros with i3-gaps. I use the linux-zen kernel.
I installed it using AUR but the rofi-blocks-git PKGBUILD file was faulty. So i installed rofi-blocks via makepkg -si and an edited version of the PKGBUILD file. More information on that in the AUR Package comments for rofi-blocks-git.

I update rofi-blocks aur package.
I see that googler github project is archived and its latest version is broken... so I'll need to remove the support for it.
How do you execute rofi-search exatly?
First simplest method is to

Execute it just by command rofi-serach it will search for googler executable and if not found it will try to find ddgr executable in your path.. if both executables are not found it will write message to stderr like

To make rofi-search work with default configuration, please install either ddgr - https://github.com/jarun/ddgr or googler - https://github.com/jarun/googler

The second method is explained in the readme in Usage Examples section..

Okay thank you, installing rofi-blocks works now fine.
I started rofi-search in the command line without the environment variable:
Can not find "googler" executable.
BlocksMode-Message: 11:50:15.438: Child 160750 exited abnormally

Googler is not installed and ddgr is installed. It seems like it doesn't search for ddgr

Hm, thats weird, something is off here, it definitely searchers for ddgr HERE
I just checked, installed ddgr from aur and it works..
Do you have latest rofi versin?

It seams like you have ROFI_SEARCH env variable set to googler in which case it would fail as you described...

Yes I have the latest rofi version mine is also 1.7.3.
I installed rofi-search via aur and ddgr via aur.
Here a gif to show you what happens:

Okay if no environment variable is set it automatically sets it to googlr with the default config:
https://github.com/fogine/rofi-search/blob/76c7c6f4019944c85a58ea434cd6535985a272f2/rofi-search#L33

If you set ROFI_SEARCH variable, you need to execute it like this:
export DDG_ARGS='["-n", 3]'
export ROFI_SEARCH='ddgr'

rofi -modi blocks -blocks-wrap /absolute/path/to/rofi-search -show blocks \
-lines 4 -eh 4 -kb-custom-1 'Control+y' -theme /path/to/your/theme.rasi

rofi-search command works only with default configuration (which in your case does not work for some unknown reason..).

Okay thank you with that command it works, but the theme is different from the googlr theme. Is this true?

Because if i search something with your command the highlighted text i searched nearly has the same color as the background color and the text seems to be invisible

yeah, I'll need to update the default theme, with recent rofi version its broken a little bit..

fixed in<EMAIL_ADDRESS>


[feat] Extensible regression test variable space

This PR introduces some changes suggested in #1568. Building on the same concept as used to implement the extensible parameterized tests, we introduce the var directive, which injects a new variable in the RegressionTest class.
class Spam(rfm.RegressionTest):
    var('myTestVariable', int, float, value=3.141592)

    def __init__(self):
        do_something_with_my_own_var(self.myTestVariable)

This variable is injected into Spam as a data descriptor (TypedField) though the __new__ method. If an alternative Field were needed, the var directive accepts thefield argument. The value passed as this argument must be a subclass of the Field class located in reframe/core/fields.py.
On this var directive, the value argument is entirely optional, and one might choose to leave the variable undefined. Logically, if that is the case and the variable is referenced in the class, an exception will be raised. However, If one inherits from a class with an undefined variable and need to set its value, or simply overwriting an old value, one can use the set_var directive.
class Ham(Spam):
    set_var('myTestVariable', 1.5)

Note that, when using the set_var directive, the variable myTestVariable must have been declared through the var directive in a parent class. If that were not the case, another error would be raised.
Now with the converse. Suppose you're writing a library extending the work of someone else, but that "base" library has set a value for a variable. Instead of using such value, you can force the users to set the value for themselves by using the require_var directive. This directive will effectively undefine the variable, which means that an error will be raised if it hasn't been set.
class Eggs(Ham):
    require_var('myTestVariable')

    def __init__(self):
        self.myTestVariable = 20 # We set the variable first ...
        super().__init__()       # and now we can call Spam's __init__ method.

Same as with set_var, the variable referred to by require_var must have been declared with the var directive in any of the parent classes. Flagging a variable that is not present in the test as required is implemented as a no-op (a variable that is not present in the test has no meaning to it).
There are still a few minor things to be addressed:

[x] Fix pipeline unit tests
[x] Add var unit tests
[x] Refactor the extensible parameter spaces to use the same base classes as the variables
[x] Add the docs
[x] Implement a namespace management to track all attributes introduced through directives

This PR will also:

Make illegal any name clashes between variables, parameters and other existing class attributes in the regression test.
Make illegal to call more than one directive on the same var in the same class (the three var directives have excluding actions).
Make illegal to redeclare a variable.
Make illegal for a test to inherit from multiple classes derived from the RegressionTest class (direct consequence of the previous item).
Introduce the RegressionMixin class. This class supports reframe hooks and directives, solving the limitation introduced by the previous item.

Hello @jjotero, Thank you for submitting the Pull Request!

In the file reframe/core/attributes.py:

Line 12:1: E302 expected 2 blank lines, found 1
Line 80:12: E114 indentation is not a multiple of four (comment)
Line 81:12: E111 indentation is not a multiple of four
Line 83:12: E114 indentation is not a multiple of four (comment)
Line 84:12: E111 indentation is not a multiple of four
Line 86:12: E114 indentation is not a multiple of four (comment)
Line 87:12: E111 indentation is not a multiple of four
Line 89:12: E114 indentation is not a multiple of four (comment)
Line 90:12: E111 indentation is not a multiple of four

In the file reframe/core/pipeline.py:

Line 325:5: E124 closing bracket does not match visual indentation
Line 535:5: E124 closing bracket does not match visual indentation
Line 575:80: E501 line too long (84 > 79 characters)

In the file reframe/core/variables.py:

Line 13:1: E302 expected 2 blank lines, found 1

Do see the ReFrame Coding Style Guide

Hello @jjotero, Thank you for submitting the Pull Request!

In the file reframe/core/attributes.py:

Line 12:1: E302 expected 2 blank lines, found 1
Line 80:12: E114 indentation is not a multiple of four (comment)
Line 81:12: E111 indentation is not a multiple of four
Line 83:12: E114 indentation is not a multiple of four (comment)
Line 84:12: E111 indentation is not a multiple of four
Line 86:12: E114 indentation is not a multiple of four (comment)
Line 87:12: E111 indentation is not a multiple of four
Line 89:12: E114 indentation is not a multiple of four (comment)
Line 90:12: E111 indentation is not a multiple of four

In the file reframe/core/pipeline.py:

Line 325:5: E124 closing bracket does not match visual indentation
Line 535:5: E124 closing bracket does not match visual indentation
Line 575:80: E501 line too long (84 > 79 characters)

In the file reframe/core/variables.py:

Line 13:1: E302 expected 2 blank lines, found 1

Do see the ReFrame Coding Style Guide

Codecov Report

Merging #1699 (73689da) into master (29b3c07) will increase coverage by 0.13%.
The diff coverage is 97.69%.

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
+ Coverage   87.31%   87.44%   +0.13%
==========================================
  Files          46       48       +2
  Lines        7639     7745     +106
==========================================
+ Hits         6670     6773     +103
- Misses        969      972       +3

Impacted Files
Coverage Δ

reframe/core/fields.py
97.50% <75.00%> (-1.22%)
:arrow_down:

reframe/core/attributes.py
96.36% <96.36%> (ø)

reframe/core/parameters.py
98.36% <96.77%> (+4.42%)
:arrow_up:

reframe/core/variables.py
98.66% <98.66%> (ø)

reframe/core/meta.py
100.00% <100.00%> (ø)

reframe/core/pipeline.py
91.62% <100.00%> (-0.55%)
:arrow_down:

reframe/frontend/dependencies.py
96.50% <0.00%> (-1.99%)
:arrow_down:

reframe/frontend/statistics.py
96.72% <0.00%> (-0.02%)
:arrow_down:

reframe/utility/sanity.py
97.55% <0.00%> (ø)

reframe/core/schedulers/slurm.py
53.78% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b3c07...73689da. Read the comment docs.

Codecov Report

Merging #1699 (73689da) into master (29b3c07) will increase coverage by 0.13%.
The diff coverage is 97.69%.

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
+ Coverage   87.31%   87.44%   +0.13%
==========================================
  Files          46       48       +2
  Lines        7639     7745     +106
==========================================
+ Hits         6670     6773     +103
- Misses        969      972       +3

Impacted Files
Coverage Δ

reframe/core/fields.py
97.50% <75.00%> (-1.22%)
:arrow_down:

reframe/core/attributes.py
96.36% <96.36%> (ø)

reframe/core/parameters.py
98.36% <96.77%> (+4.42%)
:arrow_up:

reframe/core/variables.py
98.66% <98.66%> (ø)

reframe/core/meta.py
100.00% <100.00%> (ø)

reframe/core/pipeline.py
91.62% <100.00%> (-0.55%)
:arrow_down:

reframe/frontend/dependencies.py
96.50% <0.00%> (-1.99%)
:arrow_down:

reframe/frontend/statistics.py
96.72% <0.00%> (-0.02%)
:arrow_down:

reframe/utility/sanity.py
97.55% <0.00%> (ø)

reframe/core/schedulers/slurm.py
53.78% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b3c07...73689da. Read the comment docs.

@jenkins-cscs retry all

In the example with the Eggs class, I guess that the users wouldn't even have to call super.__init__() if the base class only declared or (re)set some variables, right?

The docs are now working (🎉). The trick has been pulled off by updating the _TestVar class to have a __set_name__ method. Then, the class is made available in the RegressionTest class and we can now simply create a new variable doing
class Foo(rfm.RegressionTest):
    my_var = _var('/', int, value=3)
    def __init__(self):
        pass

where the '/' argument is just a placeholder for the variable name, which gets later replaced by the __set_name__ method anyways. This is equivalent to
class Bar(rfm.RegressionTest):
    var('my_var', int, value=3)
    def __init__(self):
        pass

Now, I do like a lot more the first option. So if we eliminate the var('my_var', ...) syntax and stick to the one in the top, there's no need for the name placeholder and the whole thing would look as follows
class Foo(rfm.RegressionTest):
    my_var = var(int, value=3)
    p0 = parameter(1,2,3,5,8,13)

    def __init__(self):
        pass

For the same money, we can also change the parameter directive as shown in the snippet above. This would be only for the directives that declare a parameter or a variable; the set_var and require_var would remain the same. Thoughts?

I was about to finish my review and I was right at the moment that was wondering what the heck is this new _var 😂 Nice!

I don't a problem with this syntax, except I would still prefer the parameter() to get an iterable of values.

One obvious downside is that it breaks completely the already introduced syntax for parameters, but since it's so fresh and hasn't yet become the way to go for parameters, I can accept it.

@jjotero I updated the branch and I'm gonna trigger a full production run.

There seems to be a strange side effect:
./bin/reframe -C config/cscs.py -c cscs-checks/ -n MemoryOverconsumptionCheck -r

[  FAILED  ] Ran 2/2 test case(s) from 1 check(s) (2 failure(s))

And this generates this in the build script:
module load daint-gpu
module load PrgEnv-cray
cd posts/cuda-aware-mpi-example/src
cc eatmemory.c -o ./MemoryOverconsumptionCheck

Which is apparently very strange :-D

There seems to be a strange side effect:
./bin/reframe -C config/cscs.py -c cscs-checks/ -n MemoryOverconsumptionCheck -r

[  FAILED  ] Ran 2/2 test case(s) from 1 check(s) (2 failure(s))

And this generates this in the build script:
module load daint-gpu
module load PrgEnv-cray
cd posts/cuda-aware-mpi-example/src
cc eatmemory.c -o ./MemoryOverconsumptionCheck

Which is apparently very strange :-D

😱😱😱😱😱😱😱😱😱😱
I just did ./bin/reframe -C config/cscs.py -c cscs-checks/system/slurm/slurm.py -r and it ran fine 🤔🤯

The issue with the MemoryOverconsumptionCheck  had its origin in the CudaAwareMPICheck, which had a += on the prebuild_cmds variable.
self.prebuild_cmds += ['cd posts/cuda-aware-mpi-example/src']

This changed default value of prebuild_cmds, which is a reference to the very default value set in the RegressionTest class. This means that test that run after this is executed, will also see this "modified" prebuild_cmds variable.
All this would not be a problem if all tests do the first assignment as a new list, but that is simply too dangerous. So to fix this, the values that get injected into the variables are now deep-copies of the original class-default values, which totally removes this cross-contamination in the tests. The same could have happened for the parameters, so another fix has been implemented in there. To make sure these changes stick, I've added two new unit tests that check this for the variables and parameters.
I've also improved the docs on the built-in section.

For the conflicts, just keep your version. I have simply fixed the styling in a previous PR.

Did the full production run pass?

Yes. The failures were just ordinary test failures, not related to framework problems.

@jenkins-cscs retry daint


SqlServerDsc: Fix keywords to lower-case to align with guideline

Pull Request (PR) description

Changes to SqlServerDsc

Fix keywords to lower-case to align with guideline.

This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1425 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##            dev   #1425   +/-   ##
====================================
  Coverage    98%     98%
====================================
  Files        38      38
  Lines      5603    5603
====================================
  Hits       5497    5497
  Misses      106     106


secret cert-manager/freenom not found

Same as Title and just for your reference I do have checked the namespaces its being created in !
Images:

Errors in Pods Logs:
E0814 05:16:27.535813       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.0/tools/cache/reflector.go:167: Failed to watch *v1beta1.FlowSchema: failed to list *v1beta1.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:freenom-webhook" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0814 05:16:42.605663       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.0/tools/cache/reflector.go:167: Failed to watch *v1beta1.PriorityLevelConfiguration: failed to list *v1beta1.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:freenom-webhook" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope

May you share the yaml files that you have applied to the cluster?
What image does the pod is running?
What kubernetes version is running?
The log reports User "system:serviceaccount:cert-manager:freenom-webhook" cannot list resource.
Are you sure to have a service account freenom-webhook with the correct roles and rolebindings applied?
Have you applied the rendered_manifest.yaml to the cluster?

What image does the pod is running?

I just Purchased a new Domain , hence I don't use freenom anymore , I particularly don't remember image version

What kubernetes version is running?

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3+k3s1", GitCommit:"1d1f220fbee9cdeb5416b76b707dde8c231121f2", GitTreeState:"clean", BuildDate:"2021-07-22T20:46:24Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/arm64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3+k3s1", GitCommit:"1d1f220fbee9cdeb5416b76b707dde8c231121f2", GitTreeState:"clean", BuildDate:"2021-07-22T20:46:24Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/arm64"}

The log reports User "system:serviceaccount:cert-manager:freenom-webhook" cannot list resource.
Are you sure to have a service account freenom-webhook with the correct roles and rolebindings applied?

I just followed and applied your manifest as per readme , I am newbie in cluster/kubernetes

Have you applied the rendered_manifest.yaml to the cluster?

I did

The problem derived from the latest update of cert-manager.
I have applied the fix proposed here and it should now work correctly.
I have also created a release for the manifest file to avoid cloning the repo to generate it and improved the README.
Let me know if you want to check if now it works even for you.


pub some things

We are converting to and from str0m constructs and it would be useful and avoid code duplication if we could pub and add the following.

will fix


Report GHA (CI) tasks that timed out as failures

The timed out configurations have the gray cancel icon, which is not as eye-catchy as red x icon.
Since we have high number of tasks, it's easy to overlook a cancelled one.

FWIW this is a custom CSS style i’m using to make them more visible in the browser:
.checks-list-item-name .text-red,
.checks-list-item-name .neutral-check,
.commit-build-statuses > .text-red {
    outline: 2px dashed orange;
    border-radius: 3px;
    padding: 0 1px;
    display: inline-block;
}


siril: 1.0.6 -> 1.2.0

Description of changes
https://gitlab.com/free-astro/siril/-/blob/master/ChangeLog?ref_type=heads
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 258269 run on aarch64-linux 1

1 package built:

siril


Display error.

I have bad English
After the program and rom is flash,The screen shows a mess.
Can you give me some tips?
(There is no problem with the screen wiring.There are black edges on the left and right sides.That's fine)
(In make menuconfig I choose a custom device.)
Thank all.
hardware: esp-wroom-32

I am also having the same issue, have checked my wiring and my wrover works fine with the smsemu/nesemu and everything else. As soon as I try and load a rom (tried with super mario - 64kb and tetris 32kb) and I just get screen distortion the same as above.
Thanks

I rewrite the lcd.c and spi_lcd.c,Make it display the picture "properly"(Better than the previous mistakes.) https://github.com/lualiliu/esp32-gbemu
I need the help~

I rewrite the port of gnuboy for esp-wroom32 and got it working check my repo https://github.com/pebri86/esp32-micro-gb


HDDS-9927. Ozone List keys CLI should co-ordinate between max limit and listCache Size.

What changes were proposed in this pull request?
Ozone List keys CLI should co-ordinate between max limit and listCache Size
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9927
How was this patch tested?
Manual

What is the intention of this change? How does it impact the performance? It would be good to add a bit more description for the motivation.

What is the intention of this change?
Thanks @kerneltime , updated the PR  description.


Combobox selects wrong item when using enter to confirm

Describe the bug
Combobox uses wrong selection when using enter to confirm typed selection.
It keeps your last focused item instead of picking the first one of the filtered list.
How to reproduce
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/clarity-light-theme-v5-hefc3o?file=src/app/app.component.ts
Open the application
Type in Fennel
Press enter
See error (It selects Foo because that was focused when the combobox was focused)

Expected behavior
When typing then confirming with an enter press I expect the first item from the visible list to be selected.
This is the behavior on the aria-practices site:
https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html
Versions
Clarity project:

"@cds/angular": "5.0.2",
"@cds/core": "5.0.2",
"@clr/angular": "5.0.2",
"@clr/icons": "5.0.2",
"@clr/ui": "5.0.2",

Clarity version:

v4.x (also tried the clarity-light-theme-v4 from stackblitz creates the same issue)
v5.x (version we are using & stackblitz is made in)

Framework:

Angular

Framework version:

Angular 11.0.8

Device:

Type: Desktop
OS: Windows 10
Browser Chrome
Version 89.0.4389.90 (Official Build) (64-bit)

Additional notes

Thanks for the provided reproduction and W3C link.
When the Clarity combobox was first designed, it was decided to go with "Example 1: List Autocomplete with Manual Selection" from the same W3C spec.
What you request is also valid, though it's illustrated with "Example 2: List Autocomplete with Automatic Selection".
If I remember well, the Manual Selection was preferred for two reasons (both Accessibility):

We didn't want to implicitly do a selection without a selecting action.
In multi-select case we need to land on the 1st already selected item, and we didn't want two different experiences in single-select and multi-select.
Nevertheless, I see a bug in our current implementation - we do select the 1st option implicitly if Enter is hit without active selector on any option.

@scronisser do you think we need to re-evaluate our model with the future Core implementation and use "Autocomplete" instead of "Manual" there?


Struct use with map and filter operations

As in subject, decide on syntax and update to permit struct use in similar vein to other types in array and map operations.
Should also review overall use at this point.

not done yet. operators will stay the same as for arrays.
have to review for suitability before committing to doing this work as it could be a pain in the arse without generics.
I.e. may have to wait until newer Go versions have stabilised generics functionality and we do a sweep through all of the code for appropriate use cases.

still waiting on go 1.18 in the new year before reviewing this issue further.

modified map and filter to work with dirent structs. no other use cases found yet.
reviewed generics adoption post go 1.18 and doesn't look like there is much improvement to be had.
will close this issue in the near future unless other type requirements arise.

will raise further tickets for this if it needs new types adding. closing for now.


test the thumb targets

@homunkulus r+

:pushpin: Commit e4fa0f6 has been approved by japaric

:hourglass: Testing commit e4fa0f6 with merge 92efffd...

:sunny: Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 92efffdedd81eb10842b9b45e4faffa9a8449254 to master...


Can i Invoke lambda from another lambda with apex go-lang?

When lambda function call another go lambda that use apex wrapper,  i m getting  below error,
2017-02-14T19:04:33.920Z	6b185563-f2e8-11e6-8b76-15a655874da5	SyntaxError: Unexpected token /
at Object.parse (native)
at LineStream. (/var/task/index.js:35:18)
at emitOne (events.js:77:13)
at LineStream.emit (events.js:169:7)
at readableAddChunk (_stream_readable.js:146:16)
at LineStream.Readable.push (_stream_readable.js:110:10)
at LineStream.Transform.push (_stream_transform.js:127:32)
at LineStream._pushBuffer (/var/task/byline.js:123:17)
at LineStream._transform (/var/task/byline.js:114:8)
at LineStream.Transform._read (_stream_transform.js:166:10)

when i run locally as go service it's invoking lambda function, but if i invoke from lambda to another lambda its failing to invoke. Pls suggest

Check out https://github.com/apex/invoke, that's wha I use for calling other Lambda functions in my Go stuff

example is https://godoc.org/github.com/apex/invoke#example-package

perfect. This helps ... thanks tj


CAMEL-12080: allow creating csvcontent without last eol

@davsclaus done! thanks for reviewing it. 😄


curl: update to v7.57.0

Signed-off-by: Johannes Schindelin<EMAIL_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dscho sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Due to changes in curl's CMake support, where it now installs .cmake
files, we now have to make sure that they are installed into the correct
directory (and not duplicated into the debug/share/ directory, either).
Also, a change in the context of the 2nd patch required an update of
said patch.

Thanks!


Changes to implement a Profile importing scheme

Changes to implement a Profile importing scheme
I needed a way to import processes for my personal changes and came up with some small code changes that enable Profiles that are stored in any config file to be imported into the loaded profile, this also allows modders to include their own Supplies, Rules or Processes and not have to edit the default profile.
The code also checks a field supplied in the imported profile to determine if the profile should be imported or not. This mechanism works by searching the GameData directory for a matching directory that is named in the moddir field of the profile.

Using
Simply create a Profile node named KerbalismSupport and include the necessary script to define the Supplies, Rules and Processes you need, as you would with the default profile.
The KerbalismSupport profile node must have a modname field which is used for logging and a moddir field which is used to decide if a mods support profile should be loaded.
Profile
{
	name = KerbalismSupport    // name must be KerbalismSupport
	modname = FooBar Zoo       // Just a name for display purposes
	moddir = FooBar/Zoo           // Could use Zoo if you wish

	Supply
	{
    etc...

Example:  FooBarZoo.cfg
see the commits here Profile-Import-Test. If you have any suggestions fire away, code is ready for a Pull ;)

I am interested, but for now let's keep this on hold because the rule system is going to change in the near future. In particular I'm going to lift the MM patching limitation that currently exist for profiles. So that what you propose may be implemented purely as MM patches creating or editing new rules.

I saw you where up to something from reading some of the other posts, so decided on putting up an issue rather than a PR.


Adds --target-shell option to authenticate command

Hey, folks.
This Pull Request adds a new command line option to read what is the target shell which the
export command will run. Default shell is bash and this PR adds support  for fish shell as well. So with that, developers can use aws-okta-processor as follows:
⋊> aws-okta-processor authenticate --environment --organization=myorg.okta.com --user=myuser --target-shell fish
set --export AWS_ACCESS_KEY_ID 'XXXX'; and set --export AWS_SECRET_ACCESS_KEY 'YYYY'; and set --export AWS_SESSION_TOKEN 'ZZZZ';

Also, this Pull Request increases the test coverage of the commands/authenticate.py from
5% to 10% and adds documentation about the new command line option.

I believe this Pull Request can help other developers who uses aws-okta-processor in a daily
basis inside a fish shell environment. Also, I designed the code in a way other shells like
zsh and ash can be added in the future with easy.

All the best and thank you for this project!

One thought before this merges: would it be cleaner to make the shell type an optional argument to the --environment flag instead of introducing a new option? Then it would just be:
Bash(default):
aws-okta-processor authenticate --environment

Fish:
aws-okta-processor authenticate --environment=fish

One thought before this merges: would it be cleaner to make the shell type an optional argument to the --environment flag instead of introducing a new option? Then it would just be:
Bash(default):
aws-okta-processor authenticate --environment

Fish:
aws-okta-processor authenticate --environment=fish

Sounds great. I'll try to update the code to work exactly like that.

@pantuza Thank you for looking into that. --target-shell is preferred.


Apply Action Adding License failed when applying to remote clients

On a Network Game, when a player buys a license, and the action is sent to remote clients, those clients report a failure to add the license.

The Failure was due to the root Class 'Effect' has it's applyEffect method called after the primary effect was applied. The method worked properly otherwise. Corrected so this is not called, and a proper failure message if the ToActor is NOT a Train Company is set. The undo method had the same issue.


⚠ Bofrost.be has degraded performance

In b0e33b3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1922 ms

Resolved: Bofrost.be performance has improved in 38f732b.


Excessive memory usage when traversing Entities

One of our users shared a model with us which was causing them some problems. While debugging it noticed there was large performance spike when the model first loads. It caused the HoloLens display to go blank for 1-2 seconds.
Upon profiling, we noticed that it was caused by us searching specially named nodes in the hierarchy. We noticed that it was allocating 34mb just to look at the names of each entity. We based our logic on the showcases app's FindAllByPattern Entity extension method which uses VisitEntity.
I profiled a simple usage VisitEntity which doesn't do anything other than count the number of entities it's visited.
entity.VisitEntity((Remote.Entity child) =>
{
    searchCount++;
    return Entity.VisitorResult.ContinueVisit;
});

We've not been using quite so complex models in our testing before, so weren't aware of which how much was being allocated, but for a complex model it is a lot.
Model A - 96756 entities - 26.4mb
Model B - 26865 entities - 3.7mb
After some deep profiling and some fixups I've managed to get it down to:
Model A - 9.6mb
Model B - 2.7mb
There were two main issues:
Entity.cs - VisitEntityImpl() - This is calling Children twice instead of just once, doubling your allocations. This is why the initial relationship between allocations for Modal A and Model B is non-linear with respect to number of entities. That function also uses a foreach to iterate over the children which is allocating small amounts on each iteration. Which with 96k entities adds up.
RemoteRenderingAPI.cs - Children
This is using Linq Select, again this allocates small amounts every iteration and really adds up.
Even with these improvements, the memory allocation here seems excessive given what the VisitEntity on the surface looks like it should be doing.
During this investigation, we found a few other places in our code which are making use of  Children to traverse the hierarhcy, not really considering that every time Children is called it's allocating.
Presumably, the Entity hierarchy is in memory somewhere in unmanaged native code? Would it be feasible to implement non-allocating access to Entity hierarchy?

Hi @WikkidEdd,
beside the low-hanging fruits you mentioned (and which we will look into!) this is unfortunately an inherent problem of the C# API.
So I'm wondering if we could also cover use cases with traversal that have full native implementations under the hood. For that, we'd need to know a bit more about your use case, because as soon as we pass an Entity to the visitor impl, there have been allocations beforehand. What entity properties do you need to look into in the visitor? The name?

Would you mind sharing your improved code here? Then we can compare it against our own upcoming improvements to make sure we don't miss anything.
Cheers!

I'll contact you via a different channel to discuss our exact use cases.
Here are the modified files. It only fixes the immediate cases where we have direct problems, but I can see that the FindFirstEntity also has the same problems as VisitEntityImpl
MemoryImprovements.zip

Quick question, did you see any improvement when using 'for' as opposed to 'foreach'? It has been a long tradition that foreach had allocation penalty, but that should be resolved for a while?
Furthermore, what would be your use case for a (much) faster visitor function? Find node by name? Find node with component?

I had heard the same with regards to foreach allocations being resolved, but I'm not 100% what Unity version/scripting backend that is related to.
I was doing most of the profiling in Editor because it's faster to iterate, but it was making a difference there. It's possible that when built to IL2CPP it doesn't have the same effect, but high level the memory allocation we pretty much the same in Editor and on device.
In the deep profiler it was allocating when calling GetEnumerator() from the array child array.

Hi @WikkidEdd, we have added your short-term improvements to the SDK that improves the scene graph traversal significantly.
More optimizations are possible, but they'd require some invasive (and also API breaking) changes. It's in our backlog now, but I figure I'm closing this ticket for now.


1.15.x bedrock beta support

Add Minecraft Bedrock Edition <IP_ADDRESS> support

Was this issue not resolved with https://github.com/yesdog/Waterdog/pull/95 ?


CSRF token from the 'X-Csrftoken' HTTP header has incorrect length.

I receive this server-side error when user clicks 'Save View' within a data-browser view.
And this is the html log "POST /data-browser/api/views/ HTTP/1.1" 403 12628
Note that I am using django-data-browser out of the box, just testing it out to see if it will work for my project.

Well that's fun and interesting.
What versions of Python and Django are you using?
Do you have any middleware that might be involved?

Do you have any interesting configuration around authentication?
Is the user in question a super user? if not do they have permissions to the databrowser View model.

Python 3.8.2
Django 4.0.9
The user is a superuser (created by python manage.py createsuperuser)

The rest of the setup is mostly the default from cookiecutter-django

It's because the cookie cutter setup enables CSRF_COOKIE_HTTPONLY which per the Django docs "Although the setting offers little practical benefit, it’s sometimes required by security auditors."
https://docs.djangoproject.com/en/dev/ref/settings/#csrf-cookie-httponly
I'm unsure if this should be considered a bug or what I could do about it if I were to consider it a bug. I will do some more reading.

I've cut a new version that hopefully is compatible with this. Please let me know how that goes for you.


fix: introduce net_amount field in payment response

Type of Change

[x] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Introduce net_amount field in struct PaymentsResponse.
net_amount will be sum of amount + surcharge_amount + tax_amount.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Can you add the net_amount field in payment attempt which will hold the net amount after surcharge?


Defer transaction heartbeat to the time when the first SELECT or DML is executed

We run the transaction heartbeat just after a user run BEGIN; in the interactive shell, but we can defer starting the heartbeat to the time when the first SELECT or DML is executed.
This is possible because Cloud Spanner allows users to call BeginTransaction RPC beforehand so that we can remove overhead of calling BeginTransaction when users want to run an actual transaction (e.g. See WriteSessions in Go).
It's important to start the heartbeat after a user runs a SELECT or DML because the heartbeat uses SELECT 1 query and it could be recognized as an "older transaction" during deadlock detection (document).

cc: @apstndb

I am wondering which is better deferring only transaction heartbeat or deferring NewReadWriteStmtBasedTransaction until the first SELECT or DML is executed.
I have confirmed the read-write transaction doesn't be aborted 10 seconds after BeginTransaction without any operations  but it seems no documented guarantee.
If it can be aborted, deferring NewReadWriteStmtBasedTransaction may be better about error handling.

Anyway, deferring heartbeat is until SELECT or DML is intuitive.

Thanks! Yes deferring BeginTransaction call is another idea, but it could introduce another controversial issue (e.g. what should we do when user executes COMMIT; or ROLLBACK; just after BEGIN;? etc).

I have confirmed the read-write transaction doesn't be aborted 10 seconds after BeginTransaction without any operations but it seems no documented guarantee.

I looked backed on the document about idle transactions and actually it doesn't mention about when "10 seconds timer" becomes active. However several client libraries depend on this behavior for transaction preparation, so I think we can also depend on this as well.

Ok, it seems rare case that unused-prepared read-write transaction is aborted.
It would be the case of the enclosing session is deleted by server side.
I will not worry for the time being.


Duplicated block content when using the helpers - proxy

When you use the helpers proxy in combination with a block - helper, the captured content of the block is duplicated.
Steps to reproduce

Create a view component
Test following ERB template:

<%= helpers.content_tag(:div) do -%>
  Test
<% end %>

The result is a duplicated content. Result:

Test
Test

Expected behavior
The content is not duplicated. Without the proxy the result is as expected.
Template:
<%= content_tag(:div) do -%>
  Test
<% end %>

Result:

Test

Actual behavior
As mentioned in the list to reproduce the output generates duplicate content.
System configuration
Rails version: <IP_ADDRESS>
Ruby version: 3.2.2
Gem version: 3.0.0

Hi! Please try the capture_compatibility_patch_enabled option, see https://viewcomponent.org/api.html#capture_compatibility_patch_enabled

Thx for the fast response. If capture_compatibility_patch_enabledis enabled these behavior is gone. Should I close the issue?

Thx for your help


Protocols

I don't have any solid ideas right now on how to implement protocols. Looking for any suggestions.

I think something can be built off of the idea here https://github.com/airportyh/protomorphism
That could be the actual runtime implementation. I'm thinking we can make things a bit better by handling some things in the compiler. The first thing on my my is to go through all of the modules and collect protocols along with implementations of those protocols. From there we can make a module for the protocol with all of it's implementations right along with it.
The other thing to consider would be the Protocols within the Standard Library. I don't know exactly how to handle it right now, but the outcome should be the same as above including any user defined implementations.

I'll add I'm not saying use protomorphism directly, but the general idea. Consolidating the implementations as mentioned above may make it we can do something else.
Also, having protocols makes me think that maybe the pattern matching library could be redone via protocols as well.


Bug: No retry after pod creation timeout

📜 Description
Terminal access pod takes about 20-25 seconds to come up as healthy in general depending on the selected image. There's a timeout of around 15s which means that if the pod takes more than 15s, we show a failed message as below.

And when the user checks the events/manifest, they find that the pod has already started or is in pending.
Even if the pod has started, after clicking back on Terminal Devtron doesn't retries to reconnect and gets stuck on the failed pod screen.
👟 Reproduction steps

Select a bulky image for terminal access.
Once the failed pod creation screen comes, check the manifest to verify if the pod has gone into the running state.
Once the pod is in running state (as per the manifest), got back to Terminal, devtron will not try to reconnect unless the user manually clicks on disconnect and reconnect.

👍 Expected behavior
After the pod is in running state, when the user switches back to Terminal, it should automatically retry to connect.
👎 Actual Behavior
Once the pod is in running state (as per the manifest), got back to Terminal, devtron will not try to reconnect unless the user manually clicks on disconnect and reconnect.
☸ Kubernetes version
EKS 1.21
Cloud provider

AWS

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution

Increase 15s timeout to 30s to avoid failed pod screen. (An animation can be used with Creating pod to let the users know it's connecting)
After the pod is in running state, when the user switches back to Terminal, it should automatically retry to connect to the pod.

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

this is fixed in PR https://github.com/devtron-labs/devtron/pull/2925


Add error to raise when server returns 596 Service Not Found

I noticed requests when searching for events often returning a 596 status, which would cause the JSON parsing to choke on the returned HTML error page since there was no error class for a 596 status.

this is over two years old; closing.


fix "reactNativeModalPropsIOS" prop behaviour

Overview
Fixed the reactNativeModalPropsIOS prop behaviour (a bug was introduced in a previous PR that made the reactNativeModalPropsIOS prop not behave correctly)

:tada: This PR is included in version 7.4.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Broke UI and unable to craft

Using v<IP_ADDRESS> I have tested the storage crafting interface and the search bar was covered in a red diagonal gradient, then it turned  completely black, and no crafting recipes show up even with wood in storage and a work bench in the crafting interface. At least a wooden sword should show up, but there was nothing. I disabled every mod except magic storage extra but the issue remained.

I'm unable to reproduce this.
Could you please send your mod list and logs?

It seems restarting the game and reinstalling the mod fixed it somehow. I restarted it to have a shorter log for you to look at, because the one I had was running for a while already when I was using other mods and stuff before I discovered magic storage extra. But doing so seems to have solved my problem.


load more than 20 repos

Describe the bug
I have 300+ repos and when using repo-remover only ~20 are shown.

@maxandersen thanks for mentiong this. I'd like to add functionality to handled pages API response from GitHub but haven't had the time lately.
That should enable you to see all your repos, instead of the first 100 repos GitHub returns in the first API call.

cool - I hope you make it work as it would be nice to more easily cleanup github repos.
in meantime for those who are okey running things locally I made this jbang.dev script to help solve my problem: https://gist.github.com/maxandersen/1dac989e2a9cfc55d79cbb3e0d242e22 maybe others can use that too.

This has been implemented.


Error on "terraform apply" in example folder

pwd:  .../terraform-hetzner-nomad-consul-module/examples/simple-setup
cmd: terraform apply
stderr:
│ Error: Unsupported argument
│
│   on main.tf line 13, in module "hetzner-nomad-consul":
│   13:     hetzner_token = var.hetzner_token
│
│ An argument named "hetzner_token" is not expected here.
╵
commit: 1e0bda3631ba67878eaa07cc6facb5a9ab01d058
also reproduces before #36
is it supposed to be run that way?

Yes, I just retried it and I can not reproduce this, unfortunately.
The only issue I found is on the outputs of the "simple-setup", that are not yet adjusted to the "non-nomad_token approach"

@wenzel-felix, I've created a devcontainer and verified my environment issue.

@wenzel-felix, the issue was not that simple. I think it may be reproduced by adding cloud backend at the top of simple-setup/main.tf:
terraform {
  backend "remote" {
    organization = "<org>"

    workspaces {
      name = "<workspace>"
    }
  }
}

During apply stage it should fail to find modules with the error.
FIX:
Set working directory to "examples/simple-setup" using https://github.com/hashicorp/terraform/issues/22891#issuecomment-737646564 as a guide

@mapolu if you are using the module now in TFC, I'd strongly suggest using it not via a relative path but as shown in the terraform registry (https://registry.terraform.io/modules/wenzel-felix/nomad-consul-module/hetzner/latest):
module "nomad-consul-module" {
source  = "wenzel-felix/nomad-consul-module/hetzner"
version = "0.5.0"
insert the 1 required variable here
}
This should fix your issue

Sure, I use the tf registry in prod. The relative import issue only appears during development. It was on my way while I was experimenting


Add back Active, Date joined, and last login in mezzanine listing of users

In the 3/19/18 version of HydroShare when an admin listed users the fields listed were

At present when an admin lists users the fields are

The fields Active, Date joined and last login are needed so that when there are problems with users creating and activating accounts (as occurred this week) an admin can list recent account creations and account creation attempts to assess the extent of the problem, and contact users that may have been impacted.
This regression was noted in https://github.com/hydroshare/hydroshare/pull/2677#issuecomment-374183106

Verified correct on 1.15.2 deploy


Chart: Mission Area - Data Discrepancy

The data in the Chart: Mission Area does not align with the Report Mission Area - Compare screenshots

Partners are completely unaligned - the chart shows 37. 68. 27. 31 5. 17
Projects in Social Justice in the chart shows 60 v. 62 in the report.

QA passes
https://docs.google.com/spreadsheets/d/1Vt_Qo3L7lr8-ic6lBniJXQjyjTfsjOOxsGX-JCaeebY/edit#gid=547627265

one improvement for a future ticket would be to put the categories in the same order in the reports and charts

https://docs.google.com/spreadsheets/u/1/d/1Vt_Qo3L7lr8-ic6lBniJXQjyjTfsjOOxsGX-JCaeebY/edit?usp=drive_web&ouid=110830691228635827854


0.11.1 python source not on pypi?

Python source tar.gz's present on pypi.org:

[x] 0.12.1
[ ] 0.12.0
[ ] 0.11.1
[x] 0.11.0

Is this intentional?
0.11.1 being missing is causing problems in Beam / tensorflow/transform contexts

@ryan-williams We can upload the sources for 0.11.1 to PyPI but this won't fix your problems as for compiling pyarrow from source, you need the Apache Arrow C++ binaries pre-installed.
But as far as I understand data flow, pyarrow==0.11.1 should already be preinstalled on the workers: https://cloud.google.com/dataflow/docs/concepts/sdk-worker-dependencies

@kou @kszucs Generating the source tarball would probably be just done by running the manylinux1 docker of that release locally? Or is there a better way to do this?

@xhochy thanks for the quick response!
I think both of your points are correct, but also that having the pyarrow sources on pypi is the simplest way to have things work as intended everywhere (including here; I assume the missing pyarrow sources are an oversight and worth correcting on their own, or at least figuring out why they're only being released sometimes?).
Beam/Dataflow don't have a way to say "stage these libraries on the workers, but skip certain transitive-deps that happen to already be on the workers and which will fail to resolve due to missing source artifacts". Maybe one or both halves of that are worth adding hooks for over there, but it's a bit convoluted vs the default behavior of "it's ok if some things get redundantly staged".
Anyway, those aren't really arrow concerns ofc, but I figured it was worthwhile to understand why pyarrow sources are sometimes missing, at least.

@xhochy I'm not sure but the following command lines will work:
https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-pipPackages
git checkout apache-arrow-0.11.1
python setup.py sdist upload
git checkout apache-arrow-0.12.0
python setup.py sdist upload

Maintaining source installs from PyPI has not been a priority for us. Does someone want to push the tarballs? We might want to embolden the sdist step in the RM notes for furture releases

I want pyarrow source package to build pyarrow with system deb/rpm Arrow C++ packages too.
So I'll upload pyarrow source packages for 0.11.1 and 0.12.0 when someone confirms that the sdist upload approach is correct.

@kou Yes, the approach is correct. We should be more careful with this in future releases. I still dream of having a self-contained wheel one day.

@kou Wait. Please only use python setup.py sdist and then upload using twine.

@kou I've uploaded sources for 0.12.0 but was unable to pull the apache-arrow-0.11.1 tag from github.

@xhochy Thanks for confirming this! I've upload 0.11.1 from apache-arrow-0.11.1 and update https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-pipPackages .


Boos Details UI components implementation

Why?
Boost details screen
How?

Handle unknown boosts in the reward details screen
Boost details screen implementation
Integrated nuke library for async image load with caching

Testing
Make sure boosts are presented properly using the dev server
Additional context
fixes fe-663

Great catches @PavlosTze


Tobin disable invalid mem type test

I'd like to turn this test off for now as it crashed on at least 1 android driver and looking at it closer I don't like the way that it induces the error when allocating memory. Based on the current spec it's not clear that the way the test is allocating is illegal (just picking an arbitrary memTypeIndex), but I believe it should be which may require a spec update.
I noted a way that the test can be updated, which is left as a later exercise.

I'll push it Tobin.  We're code freezing today, is there anything else you want/need to get into 1.17?

#652 would be good. I already pushed #666 and I'll also shortly push #642 & #646.

Also, if it's not already there (and it sounds like it might not be) we should probably have a validation check to make sure that any memoryTypeIndex is less than the number of memoryTypes returned by the driver.

Pushed to Master.
commit 8c3801f19bd7924484128095ead518323ddb64e4
Author: Tobin Ehlis<EMAIL_ADDRESS>Date:   Mon Jun 20 11:32:13 2016 -0600
tests: Disable BindImageInvalidMemoryType test

This test causes a crash on at least one android gfx driver and it's not clear
that the way it allocates memory is within spec. Commented the test to note an
allternative method that can be used to get the desired result but also make
sure that memory is allocated in a device-supported manner.


Inject secrets into the same namespace as the binding

Partially addresses https://github.com/kubernetes-incubator/service-catalog/issues/162
Requires #256
TODO: modify the code in uninject after https://github.com/kubernetes-incubator/service-catalog/pull/256 is merged
cc/ @pmorie

so far so good to me

LGTM

given we're short on approvers today this is trivial I'm gonna merge.


Support to upload custom binaries

Add support to upload binaries to the lambda function.
This may be a custom command or at least a detailed documentation on how to achieve that.
Our application uses external libraries and binaries not instalable through pip.

I guess it depends on your use case, but custom libraries will inherently be supported once #21 is implemented, and depending on what you mean by binaries, S3 may be a better storage location for those.

I'd really like to see resolution on #21 along with this. https://github.com/Miserlou/lambda-packages has some great Lambda-compatible libs ready to use, in particular I'm itching to use psycopg2 with an RDS datastore in Chalice.

Does anyone know if the many linux wheel type works on Lambda?  Haven't had a chance to try it out, but it would be nice if we could download the appropriate wheels when building your deployment package.  That way we'd support any project that created linux wheels.

I'm also looking for a way to add binaries, e.g. I need PyNaCl, which relies on libsodium, a portable C library. In another Lambda I created by hand, I added it with pip install pynacl (which compiles libsodium) and  then added all files in ./env/lib/python2.7/site-packages/ to the bundle I deploy on Lambda. Or is this already supported?

@stannie that works (with a few caveats), but it's not officially documented as a way to customize what goes in the zip file.  Perhaps providing a more "official" way to do this would be helpful.  Here's what I propose:
Add the ability for users to provide scripts that are run as part of the deploy process.  The main benefit here is that you can explicitly capture how you're modifying the venv dir:
#!/bin/bash
# This would be hooks/building-zip
# It would pass in the zip dir as an argument:

ZIP_DIR="$1"
MY_PREBUILT_BINARIES="linux-binaries"  # These could be dynamically fetched/generated

cp -r "$MY_PREBUILT_BINARIES/*"  "$ZIP_DIR/"

# If you wanted to, for some reason, you could also remove things from the deployed zip
rm $ZIP_DIR/unnecessary-file.py

Rationale

Clearly separates code that's part of your app that's maintained by you (i.e chalicelib/*) vs. code that's 3rd party dependencies that need special handling (they're not on pip, or you need a library that's built in a specific way, etc).
Still allows users to git clone your app and have chalice deploy work.

Another option I've considered is just having an "overrides" or maybe "vendor" directory, that at deploy time will get merged onto the venv/ directory.  That way you still cleanly separate 3rd party vendored code from your own code.  The main downside is that the content is static so you'd have to pre-generate/pre-download content and place it in vendor/ before running chalice deploy.

Ability for users to provide scripts that are run as part of the deploy process would work for me.
Alternatively you could pass the zip file, and with a zip -u9 bundle.zip $MY_PREBUILT_BINARIES/* the binaries, built on an EC2 instance, will be added.

Some of the feedback I've had so far pointed out that the most common use case is taking prebuilt binaries and adding them to the deployment package.  Modifying/removing data from the package is less common.
Given that, I think it makes more sense to just support a directory that we'll automatically overlay into the deployment package.  I've implemented that here: https://github.com/awslabs/chalice/issues/182

#182 has been merged in https://github.com/awslabs/chalice/commit/7329b27fbe2e1ee5019cc2845b9329e6ad857c67

I'm trying to install moviepy and numpy is a dependency. With the addition of putting the pre-compiled numpy package in the vendor/ directory are there any other steps I need to perform in order to get numpy/moviepy running? I'm still getting "Unable to import module 'app'" after deploy.

Actually, I am getting an error in CloudWatch:
Unable to import module 'app':  Importing the multiarray numpy extension module failed. Most likely you are trying to import a failed build of numpy. If you're working with a numpy git repo, try git clean -xdf (removes all files not under version control). Otherwise reinstall numpy.
I've gotten the same error message from an install that I created on an ec2 instance as well as from the version in this repo https://github.com/Miserlou/lambda-packages/tree/master/lambda_packages.


Watch subcomponents

Signed-off-by: Zachary Kayyali<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/15633

/hold

/unhold


[@xstate/react] Add lazy machine initialization, simplify useActor

This PR allows the machine passed into useMachine(machine) can now be passed in lazily:
const [state, send] = useMachine(() => createMachine(/* ... */));

// ...

This has the benefit of avoiding unnecessary machine initializations whenever the component rerenders, without having to use useMemo(...).

@Andarist CI passes but CodeSandbox CI does not 😢

I've started looking into it but haven't found a quick win just yet - gonna get back to it tomorrow.


unable to locate element in python selenium script

selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":"[id="frm_text_username_#1id"]"}
unable to locate the id with my python selenium code

Hey @mitchelstarc101 , this issue is not relevant with the Project. For help related to certain topics you can join our discord server here.


bug: PrismaClient v4.13+ breaks process.emit("SIGINT")

Bug description
Initializing PrismaClient v4.13 adds an event listener for "SIGINT" and "SIGTERM" that does not correctly handle the signals when emitted, yielding the following error:
RangeError [ERR_OUT_OF_RANGE]: The value of "code" is out of range. It must be an integer. Received NaN

Prisma's failed handling of these signals interferes with other signal handlers in our system because the above Prisma error kills the process before other handlers run for the same signal.
How to reproduce
import { PrismaClient } from "@prisma/client";
new PrismaClient();
process.emit("SIGINT");

Expected behavior
Running a script with the following code improperly kills the process:
import { PrismaClient } from "@prisma/client";
new PrismaClient();
process.emit("SIGINT");

But if you swap the two lines, you see that the error only occurs after PrismaClient is instantiated and adds its signal handlers.
import { PrismaClient } from "@prisma/client";
process.emit("SIGINT");
new PrismaClient();

Prisma information
This issue is independent of the schema.
Environment & setup

OS: macOS: 13.3.1
Database: PostgresSQL 15.3
Node.js version: v20.1.0

Prisma Version
prisma                  : 4.14.1
@prisma/client          : 4.14.1
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine d9a4c5988f480fa576d43970d5a23641aa77bc9c (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli d9a4c5988f480fa576d43970d5a23641aa77bc9c (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.14.0-67.d9a4c5988f480fa576d43970d5a23641aa77bc9c
Default Engines Hash    : d9a4c5988f480fa576d43970d5a23641aa77bc9c
Studio                  : 0.484.0

Prisma expects system signal events to obey the contract, described in Node documentation, in particular, receive a signal as first argument. If you hijacking those events and emitting them manually instead of relying on Node emitting the event, make sure to do it in exactly the same way Node itself does it:
process.emit('SIGINIT', 'SIGINT')

@SevInf Thank you! This fixed our issue. If you are curious, we only use this code in our tests for our event handling. We rely on Node to emit the event in production.


Fix minor bugs spotted in several Issues

Description
This PR aims at fixing minor bugs or warning spotted in several issues :

Typos in the documentation, fixes #195
Add np.setdiff1d, fixes #165

Type of change
Please remove options that are irrelevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have read the contributing guidelines
[ ] I have updated the HISTORY.rst and AUTHORS.rst files
[ ] Linting passes successfully : make lint
[ ] Typing passes successfully : make type-check
[ ] Unit tests pass successfully : make tests
[ ] Coverage is 100% : make coverage
[ ] Documentation builds successfully : make doc

Codecov Report

Merging #196 (5f623b9) into master (a31ee8b) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   99.40%   99.17%   -0.24%
==========================================
  Files          24       24
  Lines        2172     2172
  Branches      241      174      -67
==========================================
- Hits         2159     2154       -5
- Misses          9       13       +4
- Partials        4        5       +1

Impacted Files
Coverage Δ

mapie/subsample.py
100.00% <100.00%> (ø)

mapie/_compatibility.py
72.22% <0.00%> (-27.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31ee8b...5f623b9. Read the comment docs.


Typescript

Been thinking about moving the project to TypeScript as I maintain a .d.ts file anyway and the code is so simple it's like maintaining the same file 2 times.
Cannot target ES6 though because Node 4 is missing default and variadic params.

You can target to es6 and then use babel with "babel-plugin-env" targeting to node4.

I know, but I don't want to do two-step compilation.

@felixfbecker what if target to es5?

https://github.com/postgraphql/postgraphql/pull/305 heres an example of typescript targeting es6 now targting es5.


🚧Add full file path to CASL logo

Complete The Item Below

[X] I have updated the title without removing the 🚧 emoji.

Description
In the ReadMe, the logo currently points to: https://github.com/KinsonDigital/CASL/blob/release/v1.0.0/README.md.  However, in order to use the logo in other parts of the documentation, the full, raw file path needs to be in place.
Use this as a guide: "https://raw.githubusercontent.com/KinsonDigital/Velaptor/release/v1.0.0/Documentation/Images/velaptor-logo.png
Acceptance Criteria

[x] CASL logo uses full, raw file path

ToDo Items

[X] Change type labels added to this issue.  Refer to the Change Type Labels section below.
[X] Priority label added to this issue.  Refer to the Priority Type Labels section below.
[X] Issue linked to the correct project (if applicable).
[X] Issue linked to the correct milestone (if applicable).
[x] Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels

Change Type
Label

Bug Fixes
🐛bug

Breaking Changes
🧨breaking changes

New Feature
✨new feature

CICD Changes
♻cicd

Code Doc Changes
🗒documentation/code

Product Doc Changes
📝documentation/product

Priority Type Labels

Priority Type
Label

Low Priority
low priority

Medium Priority
medium priority

High Priority
high priority

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

While  working on the issue, it was discovered that this issue has already been done with the following issue:

#39.


Update subtitles

Description
This PR updates the subtitles for:

World location news

Translations
Features

Worldwide organisation

Social media account
Pages

Screenshots
World location news
Translations

Features

Worldwide organisations
Social media accounts

Corporate information pages

Trello
https://trello.com/c/nokDQCRN
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

DOPE!


Upgrade ACMediaInfoBundle dependency

There's a new version, but the data format has changed somewhat, so need to be sure not to introduce new bugs.

For reference that's in src/Ayamel/MediaInfoBundle/MediaInfoAnalyzer.php


Change default port to 80

This patchset include:

Changing port 80 to be Soletta's Dev-App default as suggested by @barbieri
Remove fold header function as suggested by @bdilly

LGTM


option to buffer Overlay image

In L.WMS.Overlay, it would be useful to be able to specify a geographic (or pixel) buffer around the WMS request to avoid any edge artifacts and provide a nicer panning experience.  The image requested would thus be larger than the viewport size - potentially much larger if a geographic buffer is used.  This is roughly analogous to (but not quite the same as) the keepBuffer option in L.GridLayer and L.TileLayer.WMS.
This could be implemented in conjunction with #11.

An idea would be to add another options in L.WMS.Overlay, and we could use it when getting the bounds of the map.
http://stackoverflow.com/questions/34137648/leaflet-bounds-with-padding explain it.
The method pad is in my opinion the solution ?


Or 1834 add thanos sepolia to hardhat config

I added config value of thanos-sepolia in the hardhat config.

Let me make pull request after changing the base branch.


Update README.md

Update of versions and dependencies

I signed it!
2017-01-10 19:27 GMT-04:00 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/bower-material/pull/35#issuecomment-271731126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEBfcg9sRH28dPzWQWo65yS5hktzh5T9ks5rRBPRgaJpZM4LgBKw
.

--
Juan Ibarra


contributing: update to reference single line braces

Signed-off-by: Maryam Tahhan<EMAIL_ADDRESS>

I tried looking into clang-tidy as an option to fix this - but didn't find anything straight forward bar the clang-format option called InsertBraces, but it doesn't arrive till clang-format version 15...
https://github.com/CloudNativeDataPlane/cndp/issues/246

This content is duplicated on https://github.com/CloudNativeDataPlane/cloudnativedataplane.github.io/blob/main/dev.md, do you want to update it there, too? We can create a reminder issue in that repo (or this one) so we don't forget.

I will push an update there too :)

https://github.com/CloudNativeDataPlane/cloudnativedataplane.github.io/blob/main/dev.md

I added a PR https://github.com/CloudNativeDataPlane/cloudnativedataplane.github.io/pull/2


UITextField does not respond reliable to touch events

(BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer {
return NO;
}

seems to cure that.

Got it, thanks. Just pushed new commit.


Unify the notation of arguments passed by reference

NACK, clang-format will get these eventually. I don't see the use in trying to keep up with these until we begin to enforce it somehow.

The problem here is that these files are the basics of bitcoin protocol and people learn from them. We should show then how it should look like, consistently.


Changing to AdaptiveAvgPool2d on Alexnet

The update allows Alexnet to process images larger than prescribed imagenet size using adaptive average pooling. Will be useful while finetuning or testing on different resolution images. Similar to https://github.com/pytorch/vision/pull/643 and https://github.com/pytorch/vision/pull/672. I did not include adaptive avg pool in features or classifier block so that these predefined blocks can be used as it is.

Doesn't this change the accuracy?

I believe the output should be the same if the images have the same size as before (224x224). @ekagra-ranjan can you double-check?

It won't if you pass the original input dimension on which the net was trained. This is because AdaptiveAvgPool will receive a 6x6 input (if you pass the precribed imagnet size by AlexNet) and so the output will be equal to the input making the predictions unchanged.
If you pass larger sized images then it might be different compared to the original input size for the same task but that won't matter as your aim is to train the net on your larger resolution for whatever reason like maybe improving the performance by passing higher resolution images.

@TheCodez if your confusion was due to my description that the modification could handle smaller input dimensions then sorry for that. I have made the correction in my description.

@ekagra-ranjan thanks for the explanation 👍

And for inputs smaller than 224? I'm working with 80x80 images, and I'm not sure if I should process these images to fit the network or to manually change the input that is expected by the network. Also, if I change the input, I must change the filter's parameters so every layer has a correct output size, right? Thank you

@franciscocms in this case, I would say you should resize the images to be 224x224.
If you still want to use 80x80, you'll need to change the network structure to fit your data, but it won't be the exact same model anymore.

@fmassa thank you for your answer! What type of resizing would you consider? Like padding with reflection in order to achieve the 224x224(or close to that) image? I've made some calculations and saw that if I used the 80x80 input, the output of the convolutional part will be 2x2x256, which I think is really small, and some information per filter might get lost.

@franciscocms You can try those out things. IMO, interpolating the 80x80 images to 224x224 could work better.

Ok, I'll try it out! Thank you!


Release a milestone build using Spring Boot 3

Hi there!
Do you think it would be possible to release a milestone/snapshot build of this project using Spring Boot 3?

Hi, @Thihup, there are no plans to release this for Spring Boot 3 as per https://spring.io/blog/2021/11/08/update-on-eol-for-spring-security-oauth
Please consider migrating to Spring Security.


Table::len() is not computing the right size because of stale entries

This causes issues with print-size and the printed summary. I made an ad hoc fix locally for print-size which the artifact relies on but we need a more careful fix.

I think the Table stuff has drifted a little far from my understanding... maybe @ezrosent can say.

vals.len() - n_stales will work, just be careful... there are where we really want vals.len() here, basically any point where you want to use the output as a numeric offset into the table. For example:

All the calls to self.len() in table, should be migrated to self.vals.len() if you make the change.
this call to update_indexes should be vals.len()
this call is used to scan the whole table, by offset (can't use a normal iterator for borrow checker reasons)

My guess is that all calls to Table::len except the ones where we want the size of the data-set actually do want the the number of valid table offsets.
Maybe rename Table::len to Table::num_offsets and migrate those calls first?