Fix problem with validation of Emails with IDN

Fix problem with validation of Emails with Internationalized domain name.
Based on my issue here: https://github.com/laravel/framework/issues/13215
PS: Excuse me for any error in the pull request. This is my first pull request.

The offical email standard says that non-asci characters are not permitted in email address.

Swiftmailer will throw an exception if you try to send emails to email addresses with international characters in too.


Flick launcher icon?

This doesn't do anything on my phone....Just relaunches the home screen.

You mean circular icon?

In the app drawer I have an app icon for flick.... But it doesn't launch settings.

You have to long press on home screen to show settings!

I understand that....But then why is there an app icon in the drawer?
On Wed, Apr 5, 2017, 3:45 PM Michele Lacorte<EMAIL_ADDRESS>wrote:

You have to long press on home screen to show settings!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/michelelacorte/FlickLauncher/issues/18#issuecomment-291975288,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZsLETmwfSFGwZ0xKPZa5uxsYrvUZJc_ks5rs-9BgaJpZM4M0tCD
.

Is for launcher, it is normal!

But it doesn't do anything....It just reloads the launcher....Other
launcher icon like that usually go to settings for the launcher.
On Wed, Apr 5, 2017, 3:47 PM Michele Lacorte<EMAIL_ADDRESS>wrote:

Is for launcher, it is normal!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/michelelacorte/FlickLauncher/issues/18#issuecomment-291975988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZsLEZ0pFZQ3HfpciNucXqvREaJgsSxnks5rs-_NgaJpZM4M0tCD
.

My launcher opens when you click on the icons, can I close this issue?


Use noble/secp256k1 instead of tiny-secp256k1

Seems like you're already using noble in package.json, so it doesn't make sense to use tiny - it's not tiny at all

I was using noble until yesterday (literally), but I needed to do BIP32 key derivation and noble doesn't expose the required low-level curve math functions.
I thought about opening an issue on noble asking for them but I concluded it wasn't in the scope and would be rejected (even though I imagine it would be just adding a couple of export in front of functions that exist already).

I am the creator of noble libraries. What low-level api are you talking about? Pretty sure it's all is there.

For BIP32, you should use https://github.com/paulmillr/micro-bip32, which is going through the audit right now. The api is the same as hdkey module; micro-bip32 depends on noble and is minimal

I am the creator of noble libraries. What low-level api are you talking about? Pretty sure it's all is there.

Add point, multiply scalar etc.

For BIP32, you should use paulmillr/micro-bip32, which is going through the audit right now. The api is the same as hdkey module; micro-bip32 depends on noble and is minimal

Wow, I hadn't seen this one. And I did look for it. I'll switch right now. Thanks!

Add point, multiply scalar etc.

secp.Point has add() and multiply() methods. It had been exposed since day one.

Transition complete. Thanks a lot!

Transition complete. Thanks a lot!


Upgrade OTEL to v0.64.0

Description of change
Checklist

[x] Tested in playground or other setup
[ ] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

This change is

@kwapik Fixed.


Don't sendAction if isDestroyed or isDestroying

There may be circumstances where a drag source or drag target are destroyed mid-drag. Such a situation is common in the app that I work on.
In this situation, the coordinator's getObject method will throw an unhandled error when attempting to call sendAction on the destroyed object. This updates the coordinator's getObject method to guard against calling sendAction on a source/target that isDestroying or isDestroyed.

@steveszc - I believe checking only isDestroying is enough because if isDestroyed is true then isDestroying is always also true.

Thanks for the PR, I believe boris-petrov is correct, but checking for both shouldn't be a problem.


refactor: add autocomplete for ExchangeType

eslint didn't like this:
/home/runner/work/amqp-client.js/amqp-client.js/src/amqp-channel.ts
  866:81  error  Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead  @typescript-eslint/ban-types

what was your intention @mephju? I don't see how this "adds autocompletetion".

Hello @carlhoerberg
It's a well known TS trick to workaround the issue that literal strings are also assignable to string (which is the reason for lack of autocomplete).
With this trick you get the autocomplete for the union but you are still able to assign any string you like.
Please take a look here:
https://stackoverflow.com/questions/74467392/autocomplete-in-typescript-of-literal-type-and-string
and here
https://github.com/microsoft/TypeScript/issues/29729


'notary list' working on local host but not from remote host

notary Version:    0.4.2 Git commit: c8aa8cf

notary server version (0.5.0)

local private registry

Local host:
[root@localhost ~]# notary -s https://<IP_ADDRESS>:4443 -d ~/.docker/trust list stacy.com/release
NAME    DIGEST   SIZE (BYTES)    ROLE

v1      a74dc453303e98523f20bb0a6c9074c18c7db46b5ce35ea88e24d3e631da0f3d    85 targets
v2      cb6ca5b56d860b580d48f410fd78573ca303e8f5dcdab0c82969e6e1055f10d8    113  targets

Remote host:
[root@lenovo-2 ~]# notary --debug -s https://<IP_ADDRESS>:4443 -d ~/.docker/trust list stacy.com/release
DEBU[0000] Using the following trust directory: /root/.docker/trust
DEBU[0000] Trusting 1 certs
ERRO[0000] could not reach https://<IP_ADDRESS>:4443: Get https://<IP_ADDRESS>:4443/v2/: x509: certificate is valid for <IP_ADDRESS>, not <IP_ADDRESS>
INFO[0000] continuing in offline mode
DEBU[0000] No yubikey found, using alternative key storage: no library found

fatal: client is offline

The notary-server.crt is:

openssl x509 -in /root/notary/fixtures/root-ca.crt -text -noout
X509v3 extensions:
X509v3 Authority Key Identifier:
keyid:2F:8E:9A:D7:A6:EB:6B:35:09:D5:88:52:0D:71:AF:F6:18:B0:B3:18

        X509v3 Basic Constraints: critical
            CA:FALSE
        X509v3 Extended Key Usage:
            TLS Web Server Authentication, TLS Web Client Authentication
        X509v3 Key Usage: critical
            Digital Signature, Key Encipherment
        X509v3 Subject Alternative Name:
            DNS:notary-server, DNS:notaryserver, DNS:localhost, IP Address:<IP_ADDRESS>

It seems the notary server only accepts the connect from local host

it seems the notary server has configured to accpt requests from local host:
regenerateTestingCerts.sh
cat > "notary-server.cnf" <<EOL
[notary_server]
authorityKeyIdentifier=keyid,issuer
basicConstraints = critical,CA:FALSE
extendedKeyUsage=serverAuth,clientAuth
keyUsage = critical, digitalSignature, keyEncipherment
subjectAltName = DNS:notary-server, DNS:notaryserver, DNS:localhost, IP:<IP_ADDRESS>
subjectKeyIdentifier=hash
EOL

@chunglam1999:  yep, as you point out, regenerateTestingCerts.sh is meant to generate test fixtures for running on localhost or notary-server/notaryserver DNS.  You can try locally overriding an /etc/hosts entry for notaryserver and the remote IP if this is for testing purposes.
That said, we recommend generating your own certificates in a production setting, and you can probably modify that script to fit your needs

It seems like this is resolved and due to incorrectly configured x509 certificates. Closing the issue. Please re-open if this is not the case or file a new issue for anything else that comes up.


Create async stream tutorial

Fixes #8228
Relies on dotnet/samples#636

closing and reopening for a new build.

I find the branding as „async streams“ a bit unfortunate because it is easily confused with streams in System.IO which also have async APIs. Why no just “async enumerables”?


make cacheHandler error easier to trace

Trying to hunt down a rare error with how we're using Octokat - starting with what method triggered this...

The CI builds seem to be failing with a webpack issue after the tests pass. @philschatz let me know if you believe this is a legit failure and I can dig into it.

Thanks for adding the additional debugging information!
It seems the Pull Request was created right after webpack released a new version. #147 addressed the webpack and Travis now passes.


Fix ReferenceErrors after auth middleware refactoring

With PR: #30, I've introduced auth middleware and refactored the existing controllers and routes. I realised that two cases, namely following a user and deleting a post, have not been refactored completely and therefore I'd like to introduce a quick fix

I opened a PR directly as I realised this error in runtime


New version: Sinew.Enpass version <IP_ADDRESS>1

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,
This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.
(Automated response - build 876.)


Removed Descent type and related functions. Fixes #48.

The functionality has been moved to the IndividualNode.

Codecov Report

Merging #50 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   88.23%   88.25%   +0.01%
==========================================
  Files          20       20
  Lines         782      783       +1
==========================================
+ Hits          690      691       +1
  Misses         84       84
  Partials        8        8

Impacted Files
Coverage Δ

individual_node.go
84.92% <100%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d68e16...713e6c1. Read the comment docs.


Assertion failure inside the interpreter

Getting this with wasm-bindgen 0.2.35. I suspect related to the walrus port? +cc @alexcrichton
  thread 'main' panicked at 'assertion failed: `(left == right)`
    left: `1`,
   right: `2`', crates/wasm-interpreter/src/lib.rs:183:9
  stack backtrace:
     0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
     1: std::sys_common::backtrace::_print
     2: std::panicking::default_hook::{{closure}}
     3: std::panicking::default_hook
     4: std::panicking::rust_panic_with_hook
     5: std::panicking::continue_panic_fmt
     6: std::panicking::begin_panic_fmt
     7: wasm_bindgen_wasm_interpreter::Interpreter::interpret_closure_descriptor
     8: wasm_bindgen_cli_support::js::closures::rewrite
     9: wasm_bindgen_cli_support::js::Context::finalize
    10: wasm_bindgen_cli_support::Bindgen::_generate
    11: wasm_bindgen::main
    12: std::rt::lang_start::{{closure}}
    13: std::panicking::try::do_call
    14: __rust_maybe_catch_panic
    15: std::rt::lang_start_internal
|   16: main

I had LTO enabled, this might be messing with params, leading to this assertion failure.

I have an incoming fix


Support reified TypeVars

relates to #2
from basedtyping import TypeVar, ReifiedList

T = TypeVar("T", reified=True)

def foo(t: T):
    l: ReifiedList[T] = []

foo[int](1)

Would somehow need to pass the type in.

your example probably relies on https://github.com/KotlinIsland/basedmypy/issues/121


实测, 不支持 react-native 0.60+

在 react-native 0.60 版本及以后的版本, 不需要使用 react-native link 命令连接资源, 在安装 aliyun-oss-react-native 后, 编译报错, 即使 gradlew clean 了也仍然报错, 错误的部分详情如下:
"C:\Program Files\nodejs\node.exe" C:\Users\quanzaiyu\AppData\Roaming\npm\node_modules\react-native-cli run-android run-android

Jetifier found 1276 file(s) to forward-jetify. Using 12 workers...
info JS server already running.
info Installing the app...

> Configure project :aliyun-oss-react-native
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed soon. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

> Task :app:processDebugManifest FAILED

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

129 actionable tasks: 2 executed, 127 up-to-date
D:\Documents\life_helper\life_helper_provider\android\app\src\debug\AndroidManifest.xml:20:7-34 Error:
	Attribute application@allowBackup value=(false) from AndroidManifest.xml:20:7-34
	is also present at [com.aliyun.dpa:oss-android-sdk:2.9.2] AndroidManifest.xml:18:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:20:7-34
  	is also present at [com.aliyun.dpa:oss-android-sdk:2.9.2] AndroidManifest.xml:18:9-35 value=(true).
  	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s

Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
D:\Documents\life_helper\life_helper_provider\android\app\src\debug\AndroidManifest.xml:20:7-34 Error:
	Attribute application@allowBackup value=(false) from AndroidManifest.xml:20:7-34
	is also present at [com.aliyun.dpa:oss-android-sdk:2.9.2] AndroidManifest.xml:18:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:20:7-34
  	is also present at [com.aliyun.dpa:oss-android-sdk:2.9.2] AndroidManifest.xml:18:9-35 value=(true).
  	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s

    at checkExecSyncError (child_process.js:637:11)
    at execFileSync (child_process.js:655:13)
    at runOnAllDevices (D:\Documents\life_helper\life_helper_provider\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:94:39)
    at buildAndRun (D:\Documents\life_helper\life_helper_provider\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\index.js:158:41)
    at then.result (D:\Documents\life_helper\life_helper_provider\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\index.js:125:12)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
error Failed to install the app. Make sure you have the Android development environment set up: https://facebook.github.io/react-native/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details.

一旦卸载 aliyun-oss-react-native 就没问题了, 希望尽快支持 rn 0.60+, 辛苦了
附上我的系统环境:
$ react-native info
warn The following packages use deprecated "rnpm" config that will stop working from next release:
  - react-native-code-push: https://microsoft.github.io/code-push
Please notify their maintainers about it. You can find more details at https://github.com/react-native-community/cli/blob/master/docs/configuration.md#migration-guide.
info Fetching system and libraries information...
System:
    OS: Windows 10
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
    Memory: 1.17 GB / 15.87 GB
  Binaries:
    Node: 11.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.15.2 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.11.3 - C:\Program Files\nodejs\npm.CMD
  SDKs:
    Android SDK:
      API Levels: 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29
      Build Tools: 25.0.1, 25.0.2, 26.0.0, 27.0.3, 28.0.3, 29.0.0
      System Images: android-24 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-Q | Google Play Int
el x86 Atom
      Android NDK: 20.1.5948944
  IDEs:
    Android Studio: Version  <IP_ADDRESS> AI-183.54<IP_ADDRESS>52501
  npmPackages:
    react: ^16.12.0 => 16.12.0
    react-native: 0.61.4 => 0.61.4

D:\Documents\life_helper\life_helper_provider\android\app\src\debug\AndroidManifest.xml:20:7-34 Error:
Attribute application@allowBackup value=(false) from AndroidManifest.xml:20:7-34
is also present at [com.aliyun.dpa:oss-android-sdk:2.9.2] AndroidManifest.xml:18:9-35 value=(true).
Suggestion: add 'tools:replace="android:allowBackup"' to  element at AndroidManifest.xml:7:5-117 to override.
报错很明显了啊，按照提示去改一下AndroidManifest就好了

谢谢, 问题已修复, 修改 AndroidManifest.xml 对应位置为以下内容即可:
android:allowBackup="true"

android:allowBackup="true"

您好，请问是怎么改的，是改 android\app\src\debug\AndroidManifest.xml 这个文件么，修改后的文件能分享下么，我根据你前面的答案试了好久都不行，不知道 “对应位置” 指的具体是什么位置。。。

@AnnaSearl 肯定不是改debug的啊，是main下的


Update maping on Windows 10 Creators Update SDK 15063

Looks like appveyor does not have Windows 10 SDK C++ installed, so I will have to wait to merge this PR until it is supported there.
I have logged an issue on appveyor github

You should also update line 62 in Source/Mapping.xml to be
#define NTDDI_VERSION NTDDI_WIN10_RS2

That will ensure that all of the APIs are included for the mappings.

Thanks @jkoritzinsky, I will fix this.

Hi @xoofx. I finished, please looking.

Thanks a lot for this!


Modify Special number function into Library function

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

@sairish2001 Assign me this issue

Go ahead
Deadline 5 July,2021


download screenshot artifacts is broken

it downloads not all images (in my case on 2 of 14)

there is no extension (png) for all files

[QUESTION] what's going to be if we have uploaded artifacts as apk or log? Should it be displayed in viewer or for test info view we show only screenshots?

still actual in 4.0.53


[5.5] Fix file name for empty extension

On Windows system php can't write file when there is no extension.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!

I understand but problem is that when uploaded file's extension will be NULL then I get error.
I have reported it. What about this ?
https://github.com/laravel/framework/issues/23008


open

sir how to open this template in my browser
actualy ,i have download this template and put my xampp server's htdocs folder like -
xampp/htdocs/loopback-angular-admin
but now problem is that which file open in browser that cauld show main page of admin

@htkv this project is not just a template you put in your server, it's a project that you need to build and run using the Loopback server that comes with it.
Please read the project README to get a better understanding of how this works.
I hope this answers your question.


Hoist thread-local allocator within the nested parallel loops

The allocators in parallelized loops are thread-local
For nested parallelized loops, one thread might access another thread's thread-local buffer, which will result in unexpected behavior.
We need to hoist such allocators for correct result.

MLP support related, WIP


Fixed an issue in Readme example where it was throwing an error: cann…

Fixed an issue in an example from Readme!!

Interstellar 2 features a completely new readme, but thanks for your work!


MSVC: not possible to build code from cmdline as some windows libs are missing

for some (tricky) cases one might need to build hes/her code from the VC++ command line
in this case the linker is not happy, eg:
c:\Users\user\source\repos\vm_tester>cl cli.cpp
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30153 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

cli.cpp
c:\Users\user\source\repos\vm_tester\vmaware.hpp(754): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc
Microsoft (R) Incremental Linker Version 14.29.30153.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:cli.exe
cli.obj
cli.obj : error LNK2019: unresolved external symbol __imp__GetUserNameA@8 referenced in function "private: static bool __cdecl VM::user_check(void)" (?user_check@VM@@CA_NXZ)
cli.obj : error LNK2019: unresolved external symbol __imp__RegCloseKey@4 referenced in function "public: bool __thiscall <lambda_f49e2cc4151d968a45b56bd5552f53de>::operator()(char const *)const " (??R
<lambda_f49e2cc4151d968a45b56bd5552f53de>@@QBE_NPBD@Z)
cli.obj : error LNK2019: unresolved external symbol __imp__RegEnumKeyExW@32 referenced in function "private: static bool __cdecl VM::hyperv_registry(void)" (?hyperv_registry@VM@@CA_NXZ)
cli.obj : error LNK2019: unresolved external symbol __imp__RegOpenKeyExA@20 referenced in function "public: bool __thiscall <lambda_f49e2cc4151d968a45b56bd5552f53de>::operator()(char const *)const " (
??R<lambda_f49e2cc4151d968a45b56bd5552f53de>@@QBE_NPBD@Z)
cli.obj : error LNK2019: unresolved external symbol __imp__RegOpenKeyExW@20 referenced in function "public: void __thiscall <lambda_fabddcdefc99831fc201e2118c777bd6>::operator()(char const *,char cons
t *)const " (??R<lambda_fabddcdefc99831fc201e2118c777bd6>@@QBEXPBD0@Z)
cli.obj : error LNK2019: unresolved external symbol __imp__RegQueryValueExW@24 referenced in function "private: static bool __cdecl VM::gamarue(void)" (?gamarue@VM@@CA_NXZ)
cli.obj : error LNK2019: unresolved external symbol __imp__SHGetSpecialFolderPathA@16 referenced in function "private: static bool __cdecl VM::kvm_directories(void)" (?kvm_directories@VM@@CA_NXZ)
cli.exe : fatal error LNK1120: 7 unresolved externals

There is an easy mitigation - instruct the linker using pragma, so all become happy
Please consider this PR:  https://github.com/kernelwernel/VMAware/pull/37

merged :)


[SW-680] prevent creating vault with account that has no balance

In general would be way better to see how much you actually need to be able to create a vault, so i would rather introduce this issue in the review page, also because you can chose a different account to pay.


Adding a loading animation to the client

Can we have a loading animation in the client

thanks for the reply

Hey.. ah seems like you've mentioned some native animation to indicate the webview page is loading like the usual browser tab's loading animation.  Seems like this is a feature request, so I am moving this to the framework rep. Thank you very much for the idea.

Added: https://github.com/neutralinojs/neutralinojs/issues/814 to track this.. Thanks for the idea :)

No problem, thanks for your support.


fails to simulate with iverilog 13

lots of errors like these:
verilog -Ttyp -DFUNCTIONAL -DSIM -DUSE_POWER_PINS -DUNIT_DELAY=#1 \
-f/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/mgmt_core_wrapper/verilog/includes/includes.rtl.caravel \
-f/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/verilog/includes/includes.rtl.caravel_user_project -o sim_build/sim.vvp rgb_mixer_tb.v
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:110: error: 'user1_vcc_powergood' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:96:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:111: error: 'user2_vcc_powergood' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:97:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:112: error: 'user1_vdd_powergood' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:98:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:113: error: 'user2_vdd_powergood' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/mgmt_protect.v:99:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:134: error: 'pad_gpio_holdover' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:88:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:135: error: 'pad_gpio_slow_sel' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:89:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:136: error: 'pad_gpio_vtrip_sel' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:90:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:137: error: 'pad_gpio_inenb' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:91:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:138: error: 'pad_gpio_ib_mode_sel' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:92:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:139: error: 'pad_gpio_ana_en' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:93:      : It was declared here as a net.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:140: error: 'pad_gpio_ana_sel' has already been declared in this scope.
/home/matt/work/asic-workshop/shuttle8/zero_to_asic_mpw8/caravel/verilog/rtl/gpio_control_block.v:94:      : It was declared here as a net.

seems that the old style of port definition is no longer supported
    output        user2_vcc_powergood,
    output        user1_vdd_powergood,
    output        user2_vdd_powergood
);

        wire [462:0] mprj_logic1;
        wire         mprj2_logic1;

        wire mprj_vdd_logic1_h;
        wire mprj2_vdd_logic1_h;
        wire mprj_vdd_logic1;
        wire mprj2_vdd_logic1;

        wire user1_vcc_powergood;
        wire user2_vcc_powergood;
        wire user1_vdd_powergood;
        wire user2_vdd_powergood;

@mattvenn :  I expect it is supported, but it may be that it now requires a specific switch.  Check the iverilog documentation for command-line options for supported verilog styles (also check if there are any "release notes" with iverilog 13 that would suggest that such a change was implemented).

I recently hit this, and bisected it to https://github.com/steveicarus/iverilog/commit/6204b78610fedbe36b73fd26bf144f2f07849fb3
The commit mentions:
(System)Verilog allows to declare the port direction separate from the
signal declaration. E.g.

output x;
integer x;

But this is only allowed if the port declaration
 * does not have an explicit net type
 * does not have an explicit data type
 * is a non-ANSI style declaration

For all other cases of port declarations the signal is considered fully
defined and it is not allowed to have a separate signal declaration.

Assuming this falls under the non-ANSI style declaration, then it appears to be an Icarus Verilog issue.

I submitted a caravel fix: https://github.com/efabless/caravel/pull/403


[MINOR][DOCS] Replace http to https when possible in PySpark documentation

What changes were proposed in this pull request?
This PR proposes:

Change http to https for better security
Change http://apache-spark-developers-list.1001551.n3.nabble.com/ to official mailing list link (https://mail-archives.apache.org/mod_mbox/spark-dev/)

Why are the changes needed?
For better security, and to use official link.
Does this PR introduce any user-facing change?
Yes, It exposes more secure and correct links to the PySpark end users in PySpark documentation.
How was this patch tested?
I manually checked if each link works

Merged to master and branch-3.1. The doc build passed.

Test build #135358 has started for PR 31616 at commit 7e46787.

Test build #135358 has finished for PR 31616 at commit 7e46787.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135358/


broker state show active but brokers not started

This should be reproducible if trying to start a broker when the scheduler isn't getting offers. The broker should not be active.

We need at least one more state, staging perhaps. We also should differentiate if the broker is not launching because a) there are offers, but the offers aren't what is required. It would be good to see this delta too some more 7.2 CPU might be just as good as 8 or such b) the scheduler isn't getting any offers. I think if we have two states one for each we will know where the scheduler is with each broker.

We should have metrics around each state. It is going to be important to monitor this over time.  This is somewhat tied to #77

active is used for whether the scheduler should be trying to start the broker or not vs the state field which tells us what is going on with the broker task


Manually creating a ViewModel is different that the way it's created by the framework.

I won't pretend I understand how this works, just wanted to tell you about something I noticed that may be a bug but probably is by design. And it would be great to have it documented (couldn't find).
public class ImageCreateViewModel: IOrderableFormFile
{
    [Required]
    public IFormFile FormFile { get; set; }

    public int Order { get; set; } // int type, should be 0 by default.
}

public IActionResult Create()
{
    // ViewData.Model = new ImageCreateViewModel(); // <-- interesting line
    return View();
}

When we render a view without explicit creating a view model instance, the Order value is "empty" (note the type is int)
<input class="form-control" type="number"
data-val="true" data-val-required="The Order field is required."
id="Order" name="Order"
value="" />

if I explicit create the ViewModel (uncommenting the commented line):
<input class="form-control"
type="number" data-val="true" data-val-required="The Order field is required."
id="Order" name="Order"
value="0" />

Note value now has the correct value 0.
I expected both scenarios should be similar.

The framework does not create new object like you do - the model remains null and that is why values are empty. When you create an object, you initialize it with all default values. The default value of int is 0 - you receive 0 in the input.

Yeah as far as I know it's exactly what @ivaylokenov says.
@dougbu @rynowak can you confirm?

Yep, I would say this is by design

Thank you.


Switch to using text mesh pro

I tested this a bit and it seemed to work fine. TMPro has basically the same API as a text component so I don't think much else needs to change (I could be wrong though).

Thanks for the pull request, and for researching integrating TMP. I like this, but I don't want the core package to depend on users downloading the TextMeshPro package.
What I'd like to do is depend on a ITextDisplay interface, that has one property getter .Text. Then figure out which type of component they linked up. I'd want it to still compile if the users don't have TMP installed. But I'm not sure of an easy way to do that, especially at compile time.
So the TextComponent property here would be something like:
private ITextDisplay TextComponent
{
   get
   {
      if (this.textComponent != null)
      {
         return this.textComponent;
      }
      #if TEXT_MESH_PRO // THIS IS THE PART I DON'T KNOW HOW TO DO
      else if (this.textMeshProComponent != null)
      {
         return this.textMeshProComponent
      }
      #endif
      else { return null; }
   }
}

Ideally I'd be able to serialize a reference to an ITextDisplay and Text : ITextDisplay, TextMeshProUGUI : ITextDisplay but this is not an ideal world.

That makes sense! I actually searched the forks for someone trying the same thing as me with no success.
One note is that TMPro is integrated as a default package in Unity 2018. Text is still there though - I just have no idea why anyone would ever use a normal text component at this point.

If TMP is integrated into 2018 by default, we could use #if UNITY_2018 or something, I'm sure. I'll have to verify it's installed with a specific version. I'm still trying to figure out the best way to let users choose which type of component they'd like to use.

So I've finally had some time to look at this. It looks like TMP has a property specifically designed for this: maxVisibleCharacters. So I really need to rework the codebase so that it doesn't have more bloat than people need.
That said, as you suggested using TMP is really the only way to go, so I think we should just take this commit and branch or tag an old version of this for users who don't want or can't use TMP.
Thanks for the pull request and encouraging me to finally look into this!

This resolves Issue #15

I realize I'm a few months late but thanks for the merge 👍


Issue running code

hey can you please explain how can we run this code on our ConSep dataset once we have dataset downloaded.im facing various problems running this project related to assigning directories.

Hi,
For a start, use https://github.com/vqdang/hover_net/blob/master/src/extract_patches.py to generate your training and validation patches, please read the comment within the code for details on the option as well as what should be changed.
After that, you should modify the config.py accordingly, we have already had sample paths there, and also please read the config.py code and its comment too.
For any additional problems, please provide more details about your problem because we could not answer given this limited amount of info otherwise. Such as why/where/how this variable etc.

thanks for getting back , ill update you shortly

what changes have to be made here,

self.train_dir = ['../../../train/Kumar_old_GT/%s/train/XXXX/'      % data_code_dict[self.model_type]]         self.valid_dir = ['../../../train/Kumar_old_GT/%s/valid_same/XXXX/' % data_code_dict[self.model_type],                            '../../../train/Kumar_old_GT/%s/valid_diff/XXXX/' % data_code_dict[self.model_type]]

do we have to give path of downloaded pretrained weights in opt/hover.py

are these changes correct
img_ext = '.png'   data_mode = 'train'   img_dir = 'C:\Users\Ghulam\CoNSeP\Train\Images'    ann_dir = 'C:\Users\Ghulam\CoNSeP\Train\Labels'
out_root_path = "C:\Users\Ghulam\train\UHCW\%dx%d_%dx%d" % \                       (win_size[0], win_size[1], step_size[0], step_size[1])   out_dir = "%s\%s\%s" % (out_root_path, data_mode, 'XXXX\')

self.train_dir is a list of directories where each contains training patches generated by extract_patches.py. self.valid_dir is the same but for validation patches.

If you want to reproduce the paper then we recommend you to use it, please check https://github.com/vqdang/hover_net/blob/master/src/opt/hover.py to know where you should provide the pre-trained weight path.

Please ensure the directories paths are ended with a slash such as 'C:/Users/Ghulam/CoNSeP/Train/Labels/' and I advise you to switch ` to /.

To double check whether your data or input were generated correctly, you can run python train.py --view train to check the dataloader output for the data from self.train_dir

alright thanks for help, ill do accordingly and update

C:\Users\Ghulam\hover_net-master\src>python extract_patches.py
train_1.png
Traceback (most recent call last):
File "extract_patches.py", line 74, in
img = np.concatenate([img, ann], axis=-1)
im facing this error while running extract_patches.py

also im facing this error when running
C:\Users\Ghulam\hover_net-master\src>python train.py --gpu="gpu_ids"
[0927 08:29:29 @sessinit.py:294] Loading dictionary from C:\Users\Ghulam\ImageNet-ResNet50-Preact.npz ...
[270, 270] [80, 80]
Traceback (most recent call last):
File "train.py", line 268, in
trainer.run()
File "train.py", line 236, in run
self.run_once(opt, sess_init=init_weights, save_dir=log_dir)
File "train.py", line 170, in run_once
train_datagen = self.get_datagen(opt['train_batch_size'], mode='train')
File "train.py", line 158, in get_datagen
nr_procs=nr_procs)
File "C:\Users\Ghulam\hover_net-master\src\loader\loader.py", line 72, in train_generator
ds = BatchDataByShape(ds, batch_size, idx=0)
File "C:\Anaconda\lib\site-packages\tensorpack\dataflow\common.py", line 210, in init
super(BatchDataByShape, self).init(ds, batch_size, remainder=False)
File "C:\Anaconda\lib\site-packages\tensorpack\dataflow\common.py", line 96, in init
assert batch_size <= len(ds)
AssertionError

First of all let's deal with the first error. This means that the dimensions are not the same when concatenating the image and the label. This relates specifically to the final (3rd) dimension. Please print the image and label and this will be verified. When working with the CoNSeP dataset, the labels should be of shape WxHx2. Are you extracting patches from the original labels or are you separating the channels before extracting?
For your second error, this will be because the paths to the train and validation datasets are not quite right.

C:\Users\Ghulam\hover_net-master\src>python extract_patches.py
train_1.png
(1000, 1000, 2, 1)
(1000, 1000, 3)
Traceback (most recent call last):
File "extract_patches.py", line 76, in
img = np.concatenate([img, ann], axis=-1)
ValueError: all the input arrays must have same number of dimensions
first one is print(ann.shape)
2nd is print(img.shape)

It seems that np.expand_dims is getting called, which happens when type_classification = False in config.py. Please can you make sure that type_classification = True. Let us know if this is the problem.

C:\Users\Ghulam\hover_net-master\src>python extract_patches.py
train_1.png
Traceback (most recent call last):
File "extract_patches.py", line 56, in
ann_inst = ann[...,0]
NameError: name 'ann' is not defined

Please pull the latest change from the extract_patches.py script. That will remove the above error

i haven't made any change in extract_patches.py i just changed type_classification  =  True in config.py , except these.

` ```
step_size = [540, 540] # should match self.train_mask_shape (config.py)
win_size  = [80, 80] # should be at least twice time larger than
# self.train_base_shape (config.py) to reduce
# the padding effect during augmentation

    xtractor = PatchExtractor(win_size, step_size)

    ###
    img_ext = '.png'
    data_mode = 'train'
    img_dir = 'C:/Users/Ghulam/CoNSeP/Train/Images/'
    ann_dir = 'C:/Users/Ghulam/CoNSeP/Train/Labels/'
    ####
    out_root_path = "C:/Users/Ghulam/Train/UHCWL/%dx%d_%dx%d" % \
                        (win_size[0], win_size[1], step_size[0], step_size[1])
    out_dir = "%s/%s/%s/" % (out_root_path, data_mode, 'XXXX')

- i'm running extract_patch file separately by running from command prompt.

Yes, this is fine using python extract_patches.py is the correct way to do this. Above, I mentioned that you should pull the latest changes of extract_patches.py. I added a line of code at line 57 that will fix the bug. After doing this please run again and let us know if this fixes your issue.

thanks that error is gone , but the dimension mismatch error is still there in line 78,
ann has shape ((1000, 2000)
img has shape((1000, 1000, 3)

Okay, there was a problem with the concatenation axis. I have instead modified the corresponding line:
https://github.com/vqdang/hover_net/blob/master/src/extract_patches.py#L66
Here, instead we now use np.dstack() instead of np.concatenate()
Again, please update us :D

C:\Users\Ghulam\hover_net-master\src>python extract_patches.py
train_1.png
(1000, 1000, 2)
(1000, 1000, 3)
train_10.png
Traceback (most recent call last):
File "extract_patches.py", line 69, in
assert np.max(ann[...,1]) <= 4, np.max(ann[...,1])
AssertionError: 7
but if i comment out this line, code runs

Yes, this was just an assertion and so would run if commented out like you did. We have now fixed the assertion at line 64:
https://github.com/vqdang/hover_net/blob/master/src/extract_patches.py#L64
Thanks for spotting this. The code will now run smoothly. Let us know if you have any more questions.

👍 ok the code is running fine, but im facing problems with train.py . can u please walk me through the edits there,

i have given paths to pathches directories
self.data_ext = '.npy'        # list of directories containing validation patches       self.train_dir = ['C:/Users/Ghulam/train/UHCW/504x504_252x252/train/XXXX']       self.valid_dir = ['C:/Users/Ghulam/train/valid']

i have given path of pre-trained weights npz file in opt/hover.py

@Ghulam111  Please attach the stack trace, I could only guess but I think you haven't made validation data according to this self.valid_dir = ['C:/Users/Ghulam/train/valid']

@Ghulam111 Sorry, I know why now, should have looked at more carefully, please update with this
self.train_dir = ['C:/Users/Ghulam/train/UHCW/504x504_252x252/train/XXXX/']
self.valid_dir = ['C:/Users/Ghulam/train/valid/']

So, any directory path used in our code should be ended with / explicitly.
Additionally, your run command is wrong, should be, for example, python train.py --gpu="0" with 0 denote GPU 0 if you have multiple GPUs.

First, when running the script, the <gpu_ids> needs to be substituted with the actual GPU ids. For instance, if you are running on a single GPU, you may use python train.py —gpu=‘0’
The error you are getting is normally because of incorrect paths to your training and validation patches. After you have fixed the above, re run the code and see if you get the same error

Forgot to add, because it seems you are attempting to run on Windows, please refer to this #8

self.data_ext = '.npy'          # list of directories containing validation patches         self.train_dir = ['C/Users/Ghulam/Train/UHCWL/80x80_540x540/train/XXXX/']         self.valid_dir = ['C:/Users/Ghulam/Valid/UHCWL/80x80_540x540/train/XXXX/']

im running azure virtual windows 10 instance with tesla k80 gpu

I suggest you to double check your input path again.

C/Users/Ghulam/Train/UHCWL/80x80_540x540/train/XXXX/
C:/Users/Ghulam/Train/UHCWL/80x80_540x540/train/XXXX/

C:\Users\Ghulam\Valid\UHCWL\80x80_540x540\train\XXXX\
C:\Users\Ghulam\Train\UHCWL\80x80_540x540\train\XXXX\
i have checked , these are the directories where .npy files are created

in the extract_patch.py file  using extract_type = 'mirror'  gives this error ValueError: index can't contain negative values , but using extract_type = 'valid' runs fine.

I think you may be extracting with win_size and step_size the wrong way round. Please use win_size = 540 and step_size = 80

ok i will do , what should be extract_type at line 17

the code is running for extract_patch, i will let you know

https://github.com/vqdang/hover_net/blob/839bc2daadc265cba3c2d27e9bb7fbbb0e9ee247/src/extract_patches.py#L22-L30
Current option is for mirconet, so you have to set step_size=[80, 80] and win_size=[540, 540] and extract_type = 'valid'
Anyways, please always attach stack trace no matter what, it will make it easier for all of us. You can wrap the the logging output between ``` to format it.

a folder of size 27 GB is created.

do i have to run extract_patch.py again for validation data. can i comment out self.valid_dir

For debugging purpose, you can set self.valid_dir point to same dir as training but it would be unwise to run actual training without validation data.

yes , i think code is executing now , only problem left is of the gpu

do i have to install all gpu drivers like CUDA etc.

As we have mentioned in the above thread, please give the actual GPU ID. For instance, if you have a single GPU system and you are running with 1 GPU, use:
python train.py --gpu='0'
if you are using 2 GPUs, use:
python train.py --gpu='0,1'

For the record, which version of tensorpack and tensorflow are you using? The above errors often happen due to the change in the library naming convention. Please check https://github.com/vqdang/hover_net/blob/master/requirements.txt and #9

should i run install requirements.txt

It is important to create a new environment and install the specific libraries with the given version that we have provided in requirements.txt

alright ,will do and update you

can u please provide commands for creating new environment in windows

what is the command to run requirments.txt

can you please provide windows equivalent command for this
pip install --upgrade https://storage.googleapis.com/tensorflow/linux/gpu/tensorflow_gpu-1.12.0-cp36-cp36m-linux_x86_64.whl

looks like i have successfully compiled and training is started, thanks for helping me.

Great job. I’m glad we could be of assistance. We will now close this issue.

I am facing the error of FilenotfoundError for the stats.json file while running the infer.py file. Do I need to train the model to generate the stats.json file?
Thanks,
Sid

@siddharthamantrala, Please check this answer
https://github.com/vqdang/hover_net/issues/13#issuecomment-538229913
If you just want to run the inference, please use the uploaded weight and read the above to know how to run a custom checkpoint path.

@vqdang  Could I know where the wieghts have been uploaded, am not able to find it through any link in the repo?
Thanks,
Sid

Clearly, it seems you didn't read the info put on the page at all because it is right there on https://github.com/vqdang/hover_net/tree/master/src#inference

I have given the model_path as the path to the .npz checkpoint file and gave the other corresponding paths to the consep test dataset with the .png extension. and tried executing infer., I got the the error message saying NotImplementedError. Tracing back from the "PredictConfig" from infer.py . Please suggest me the right way to do it if I have gone wrong somewhere.
Thanks,
Sid

@siddharthamantrala Sorry, I was quite busy so I didn't know you post. And, for what it is worth, you should read this entire thread because we actually guided someone else to run the code here. And to answer your question, its in here also
https://github.com/vqdang/hover_net/issues/12#issuecomment-535971268
Please follow as close as possible to the all the README.

@siddharthamantrala please update us with your progress and if we helped you solve the problem. As @vqdang mentioned, it looks like there is a mismatch with the Tensorpack version - please refer to requirements.txt

Thanks for the help @vqdang and @simongraham, I am trying to setup the environment for requirements.txt. The issue is tensorflow 1.12.0 works with CUDA 9.0, and CUDA 9.0 can only be installed in Ubunut 16.04. And in Ubuntu 16.04 I am not able to install python 3.6.
With the below environment I was getting the AssertionError of tf.test.is_gpu_available().
python 3.5.2
tensorFlow 1.12
tensorpack <IP_ADDRESS>
opencv 3.2
skimage
matplotlib
numpy
Please suggest.
Thanks,
Sid

@siddharthamantrala could you tell me how did you install the cuda? A quick search on google suggests that this error is due to mismatching between CUDA, cudnn, and the installed tensorflow. Check this for the matching.
https://www.tensorflow.org/install/source#linux
python 3.5 is ok actually.

@vqdang , I installed cuda using docker, I happen figure out that issue later. Thanks for the help.


Support Twitch's new animated emotes

Twitch added animated emotes, however they're yet not animating in Chatterino.

Works for me in...

The emote popup
The emote colon dialog
Chat

Please make sure you're on the latest Nightly (or a version later than https://github.com/Chatterino/chatterino2/commit/6611c24e1375380037a1aaff94b2709d8d5f827a )

Works for me in...

The emote popup
The emote colon dialog
Chat

Please make sure you're on the latest Nightly (or a version later than 6611c24 )

How can I force an update without reinstalling the app?

Works for me in...

The emote popup
The emote colon dialog
Chat

Please make sure you're on the latest Nightly (or a version later than 6611c24 )

How can I force an update without reinstalling the app?

You can't. Nightly has to be downloaded and extracted manually.

Works for me in...

The emote popup
The emote colon dialog
Chat

Please make sure you're on the latest Nightly (or a version later than 6611c24 )

How can I force an update without reinstalling the app?

You can't. Nightly has to be downloaded and extracted manually.

Why is it called "Nightly", I've seen names like that in apps before.

Why is it called "Nightly", I've seen names like that in apps before.

tl;dr: It's basically an automated build made by CI which is a product of testing if app builds successfully on checks. See a random article I've quickly found for a better explanation.


Should we keep the vendor directory or not?

Since we migrated to go modules a while ago there's been a lingering question of whether we should keep the vendor directory or not.  It seems like there are several benefits to keeping it:

CI runs faster than if it re-fetches all the deps every time it runs.
Some developers are required to include the vendor directory per their company's policies.

This issue is intended to focus the conversation around the vendor directory in one place.

I just stumbled on this, but I'm in favor of keeping the directory. Without it, it's hard to review the code we're depending on.

Ah, never commented on this one (but on the go module support, here). Overall, I don't see any reason for removing the vendor folder.

I'm going to go ahead and close this.  We can revisit if the question ever arises again in future.


Long asset names in notification

Long asset names in notifications are shortened incorrectly ('from' disappears):

checked

checked


No video after subscribe

Environment:

debian squeeze with 3.2.0 linux kernel.
nginx 1.4.6
nginx-rtmp-module 1.1.3

nginx.conf is:
rtmp {
     server {
         listen 1935;
         application live {
             live on;
         }
     }
}

(other sections are from default Nginx distribution)
After setup is done I try to publish using following flash client: http://clemente.betta.radicalmedia.com/Wowza/examples/VideoChat/client/videochat.html (This is a flash client from Wowza media server distribution). In my case connect URI is "rtmp://<IP_ADDRESS>:1935/live", publish stream name is "testing" and subscribe stream name is "testing". As a result I expect video from my camera to be published on Nginx and to see the same video at second panel. But nothing happens, i.e. there is no video at second panel.
In error.log I see following error during publish:
2014/03/14 16:13:05 [error] 8455#0: *1 codec: error parsing data frame, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935

Tcp dump is available here: https://www.dropbox.com/s/ffocc10vjvmpika/nginx.cap
Debug log is available here: https://www.dropbox.com/s/69oft4lfiocn5ko/error.log.zip
BTW. If I publish RTMP stream via ffmpeg and subscribe using the same flash client everything works as expected. The difference in published streams are:

flash client uses Sorenson Spark and Nellymoser as video/audio codecs and ffmpeg uses H264/mp3 as codecs.

Thank you in advance.

I'm experimenting the same :(
Any ideas @andrey-vorobiev ?


Set up clippy

Most changes look OK.
Please create a separate PR containing just the clippy/cargo/workspace enabling changes, leaving this PR with only code changes to the actual codel
I will prefer to merge the code changes rapidly, yet take a longer time to research and consider adding clippy to CI and cargo workspace.

Closed in favor of https://github.com/rustcoreutils/posixutils-rs/pull/211


App crashes trying to load a texture on windows

I've isolated a demo here. If you comment this line, it works normally.
I works well on web but crashes on windows.

I had a look quick as it doesn't crash on my mac either,
The strange thing is that it crashes inside OpenGL - right after the submission to the GPU. Just before submission it checks the maximum texture sizes (mine is 16384), so it's not that - it seems that something nuanced is going on outside of the norm here.

I'll have a closer look soon as I can, and try changing the file, checking the flags for sanity, that kinda thing.

I had the same issue today with /tests/three/mesh_component/ project. When tower.jpg is loaded by snow, it has 3 bytes-per-pixel format and data size of 786432 bytes. This info is outputed by Texture.dump_asset_info. However when texture is uploaded into the GPU with GL.texImage2D format is specified as GL_RGBA, which expects 4 bytes-per-pixel and 1048576 bytes of data. This causes crash in nvogl32 system library. Changing image to PNG 32bit fixes the issue.

Ah good point @NtrfAtZNS, I think I can fix this pretty easily, there seems to be a discontinuity between the values.
Texture.hx:319:   i / texture / Texture Asset id: assets/front.jpg
Texture.hx:320:   i / texture / 	 image.bpp: 4
Texture.hx:321:   i / texture / 	 image.bpp_source: 3
Texture.hx:322:   i / texture / 	 image.pixels.length: 9558000
Texture.hx:323:   i / texture / 	 image.height: 2124
Texture.hx:324:   i / texture / 	 image.height_actual: 2124
Texture.hx:325:   i / texture / 	 image.width: 1500
Texture.hx:326:   i / texture / 	 image.width_actual: 1500

With 1500 * 2124 * 3 it's 9,558,000 but the actual bpp is meant to be 4 (stb image will convert it to a requested bpp of 4 by default) which should be 12,744,000, so it seems that this is the cause.

I'm sure this fixes it https://github.com/snowkit/linc_stb/commit/6a98e15982c6dd13927eee0470c15e5b33b9f747
@NtrfAtZNS @josuigoa let me know by updating linc_stb (you can try snowfall if you haven't)

yes, it's working!! this error was so deep for me...
thanks a lot @NtrfAtZNS and @underscorediscovery !

Thanks for reporting too!


Top debug session row says "paused" when not paused

Start my debug config
Hit a breakpoint on a debugger statement
Continue
The tab row says "Running" but the top row still says "Paused":

Fixed via compact trees https://github.com/microsoft/vscode/issues/99736


Make original ember tests available through rails routes

Make http://localhost:4200/tests/* available through rails somehow.
//cc @mwoods79

+1 What's the status of this?

@MichaelVdheeren nobody's working in this yet. You can take a shot if you feel like it.

@rwz where do we manage where the builds go? What would it take to get this done?


Clean repository

#10 - Clean repository -
Deletes all pycahe code
https://github.com/alejivo/Flask-Security-Utils/commit/e7e7a6d07fc9519e7876ac2e694017933a192cf6


Add UTEM

URL website: https://utem.edu.mx/
IT curriculum: https://utem.edu.mx/oferta-educativa/ingenierias-y-licenciaturas/ingenieria_desarrollo_gestion_software/
A photo showing the domain is attached in the information email from the same university, at the bottom of the web

@DarkAbsolutE First stage of verification passed, official domain is utem.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@DarkAbsolutE Thank you for your patience while waiting for a review and processing your request. Pull request merged.


dotnet-monitor /metrics should not return OK status code when there is more then one process

The /metrics endpoint of dotnet-monitor currently support having only one process.
If there is more then one process it currently return a 200 OK with empty payload.
I think it would be better to return a error code and log an error on console to explain why it is failing (eventually even returning the reason in the response)

Closing this in favor of #67


Spring Cleaning :stuck_out_tongue_winking_eye:

Addresses #54

Spring cleaning, so clever.  :)

profiling results:

@chapulina I don't know if there's anything specific to review here... perhaps just general best practice? I made a pass at cleanup of the config constants


Add GDS styling for code snippets

See: https://govuk-prototype-kit.herokuapp.com/docs/install/install-the-kit.md

(Thanks to @tomyems for the suggestion.)

Would code snippets be 'components-internal' rather than 'components'? I guess it depends on whether applications are likely to use code snippets in production?
There are two styles to code snippets in the GOV.UK prototype. One is inline in red, and the other is in a scrollable block. Should they be one component, with an attribute that toggles between inline or block, or are they two separate components? (I'd have guessed that they're doing the same function so in one component?)

I think, for now, just some default styling on <pre> and <code> blocks would go a long way. I'm not exactly sure where that should live or whether it needs to be a component.
Then again, I've already got some stuff for the preview boxes on the documentation pages, so perhaps I could just generalise that...
(Might be nice as there's some support for syntax highlighting.)


[AUTOPATCHER-kernel] Kernel upgrade to version <IP_ADDRESS> - branch main

[AUTOPATCHER-kernel] Kernel upgrade to version <IP_ADDRESS> - branch main
Upgrade pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=397971&view=results
AMD64 build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=398032&view=results
ARM64 build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=398033&view=results

This booted and had networking in a vhdx

New updated tags availalble. Holding on this for <IP_ADDRESS>


don't specify plans, it's brittle

@friism Do you mind merging master into this?

Closing in favor of https://github.com/orientation/orientation/pull/155

:thumbs_up:

On Aug 29, 2015, at 12:23, Michael Friis<EMAIL_ADDRESS>wrote:
Closing in favor of #155
—
Reply to this email directly or view it on GitHub.


test: show that two identical contracts can be deployed because their salt is different

This need comes from #1177.

This should be closed now, right?

Ah, my bad, I didn't see the test: prefix! (and I was the one who suggested writing a test for it 😂)


PlugNmeet client integration into custom Next.js app

Hello, I was trying to integrate the client project into my next.js app. when i call the get client files endpoint i am getting the following response: { status: true, msg: 'success', css: null, js: null }
Any idea why this might be happening?

Hi,
You'll need to build client first by pnpm run build

Hi,
You'll need to build client first by pnpm run build

Hi Jibon thank you for your answers. I have a nextjs app where it connects to the plugnmeet server and i fetch the client files. I am wondering are these client files enough to run the whole ui and funcitonalities built in? is there any ts/js tutorial on that matter? Thank you!

I think you asked the same question here: https://github.com/mynaparrot/plugNmeet-server/discussions/542


容器启动不起来

Issue Type
Install/Build
Have you searched for existing issues?
 Container p2p-tutorial-engine_alice-1  Created                                                                                1.3s
 ? Container p2p-tutorial-engine_bob-1    Created                                                                                1.3s
 ? Container p2p-tutorial-broker_alice-1  Created                                                                                1.3s
 ? Container p2p-tutorial-broker_bob-1    Created                                                                                1.3s
 ? Container p2p-tutorial-mysql-1         Created                                                                                1.3s
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: container_linux.go:318: starting container process caused "permission denied": unknown
(base) [root@localhost scql]# docker ps -a
CONTAINER ID   IMAGE                    COMMAND                   CREATED          STATUS    PORTS                                       NAMES
0902342f8cc2   secretflow/scql:latest   "/home/admin/bin/scq…"   35 seconds ago   Created                                               p2p-tutorial-engine_alice-1
f14acfcb794d   secretflow/scql:latest   "/home/admin/bin/bro…"   35 seconds ago   Created   <IP_ADDRESS>:8082->8080/tcp, :::8082->8080/tcp   p2p-tutorial-broker_bob-1
99634a79a95b   secretflow/scql:latest   "/home/admin/bin/bro…"   35 seconds ago   Created   <IP_ADDRESS>:8081->8080/tcp, :::8081->8080/tcp   p2p-tutorial-broker_alice-1
b898b4e3f690   mysql:latest             "docker-entrypoint.s…"   35 seconds ago   Created   3306/tcp, 33060/tcp                         p2p-tutorial-mysql-1
6c0d2451ad3f   secretflow/scql:latest   "/home/admin/bin/scq…"   35 seconds ago   Created                                               p2p-tutorial-engine_bob-1
(base) [root@localhost scql]# docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
(base) [root@localhost scql]# ./brokerctl create project --project-id "demo" --host http://localhost:8081
Error: CreateProject: Post "http://localhost:8081/intra/project/create": dial tcp [::1]:8081: connect: connection refused
Usage:
  brokerctl create {project|table <name>|job} [flags]

Configuration used to run SCQL.
默认配置 如文档操作 https://www.secretflow.org.cn/zh-CN/docs/scql/0.7.0b1/intro/p2p-tutorial
examples/p2p-tutorial

SCQL log output.
无

Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: container_linux.go:318: starting container process caused "permission denied": unknown

可以确认下docker权限问题


Add Qt

Follow up from https://github.com/popey/makealinux.app/issues/ and https://github.com/popey/makealinux.app/pull/17.

Maybe this should be renamed to content/en/kde/qt/_index.md, so it's nested under KDE, similar to Python and Rust under GNOME?


new change based on change in backend changes

The document had "ELC" written. We dont use ELCs anymore.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@cabailey PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Merging - however, I question why this is listed as a "known issue".  The up to 7 days is standard for retention policies and on this page covered previously under Considerations and limitations: "... it may take up-to seven days to permanently delete these messages from backend storage and Teams app"

That’s to set expectation and something we are trying to improve on from backend services side.
We say if customer sets x day retention delete, messages should be deleted by Xth day, but there is a lag that customers don’t expect when setting policy and come back to us with a bug. We are saying that this is a known behavior or known issue.
Thank you!
Anwar Ali | PM @ TEAMS | LinkedInhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.linkedin.com%2Fin%2Fanwarali&data=04|01|Ali.Anwar%40microsoft.com|61a24ee754db4b1493e408d6b4dc7b41|72f988bf86f141af91ab2d7cd011db47|1|0|636895256392090042|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=KpQ4z1jxZOc8s8IWXAYS3oVAbqKpT94E%2BzEB%2FLypv2c%3D&reserved=0
IP, Security and Compliance Team
From: Carol Bailey<EMAIL_ADDRESS>Sent: Wednesday, November 11, 2020 11:34 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Anwar Ali<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] new change based on change in backend changes (#6150)
Merging - however, I question why this is listed as a "known issue". The up to 7 days is standard for retention policies and on this page covered previously under Considerations and limitations: "... it may take up-to seven days to permanently delete these messages from backend storage and Teams app"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fpull%2F6150%23issuecomment-725618780&data=04|01|Anwar.Ali%40microsoft.com|164f38313db2481189e708d88678c4f5|72f988bf86f141af91ab2d7cd011db47|1|0|637407200543960016|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=jHPp%2BxH3G1I%2FqARmnsYD29Xz3y4UuKFqg9W%2B6icoucQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACEEVX2EH7TE3FXKQEACKC3SPLRLJANCNFSM4TMA3N4A&data=04|01|Anwar.Ali%40microsoft.com|164f38313db2481189e708d88678c4f5|72f988bf86f141af91ab2d7cd011db47|1|0|637407200543960016|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=tnHpxXIE2elcLYy5C4LtubrOl18DpkGeLkQKB%2FKRZF4%3D&reserved=0.


Error undefined is not an object

Extension encountered an uncaught exception:
/Users/davidemaglio/Library/Application Support/Nova/Extensions/littlegreenman.TaskFinder/Scripts/ComposerTaskAssistant.js (Line 13, Column 0)
TypeError: undefined is not an object (evaluating 'nova.fs.stat(this.packageJsonPath).isFile')
    provideTasks@file:///Users/davidemaglio/Library/Application%20Support/Nova/Extensions/littlegreenman.TaskFinder/Scripts/ComposerTaskAssistant.js:13:43

Thanks @dmaglio, I'll look into it this weekend.

Ran into this as well.  Looks like its mostly working still.

Hi all. I think I've identified a fix - and will test it asap.

Yep. So I misunderstood the Nova filesystem API. Resolved now!


[BUG] Buffer Window Memory not working as expected

Describe the bug
The "Buffer Window Memory" node is no longer applying the limit in window memory that is set.
Issue can be reproduced in 2.0.1, but not in 1.8.3.
To Reproduce

Create a new basic flow with LLM model, Conversation Chain and Buffer Window Memory.
Set the window memory size to 0.
Send a message to the conversation, e.g "I'm Daniel"
Ask the LLM about the previous information, e.g "What's my name?"

Expected behavior
LLM should respond "I don't know" because window memory size is 0, so no messages should be remembered.
Instead, window memory limitation is never applied so all history seems to be stored, regardless of the value set. Can also be reproduced with other values like 1.
Setup

Installation: docker, pnpm start
Flowise Version: 2.0.1
OS: macOS, linux
Browser: Chrome

I was able to debugging in code and, effectively, we are retrieving an unlimited number of messages in Flowise 2.0.1.
Also reviewing the code, another thing that I noticed, not related with the original issue, is that we are taking take: this.k + 1. This means that we will take 1 message more than the window size that the user set.
This doesn't match the description of the parameter: Uses a window of size k to surface the last k back-and-forth to use as memory. If I set it to 0 in Flowise 1.8.3, we are returning 1 message. If I set it to 10, we are returning 11 messages.
Should that logic be take: this.k * 2 instead?

yes I think you are right, looking at the source code from langchain, its also messages.slice(-this.k * 2)

Fixed in this PR https://github.com/FlowiseAI/Flowise/pull/3242


Exporting .GLTF to blender and then reimporting a .GLTF model - Nothing happens.

Hi,
I've been trying to replace a model within the VFXEditor.

As shown above, "Model 3" contains the model I want to export. Nice and easy, I click on "Export" -> "GLTF" and then call it "Cronus Lux Blade Edge" and hit "OK".
I go to blender and import the ".GLTF" file and I have this.

Fair enough everything is fine. I upscale the mesh and give it a slight tweak to fit the blade better that I want (as shown in the first picture.) I then export the save as a "GlTF Embedded (.gltf) with these settings under the name"Cronus Lux Blade Edge New.gltf".
I then go back to the game and click on "Replace". I choose the ".GLTF" I want and click "OK".

Here's where the problem is. Upon clicking "OK", nothing happens.
No clue what happens between the export process and the import process to cause this. Thought you might know something I don't.


Generating with reference images, are those id same

python image_generation_with_reference.py
--image_file "path/of/the/image/file or folder"
--model_weights weights/vec2face_generator.pth
--batch_size 5
--example 10
--name images-of-references

This code provide a image-wise way to generate x examples for each reference image you provided. For example, if you have
5 images and --example 10, this code will generate 10 images for each of 5 images. These 10 images are supposed to be the same identity as the reference image.

thanks!
sometimes, Not like the same person.

If the images are not cropped and aligned, the results will be bad.

If the images are not cropped and aligned, the results will be bad.

Why does it have to be aligned?

If the images are not cropped and aligned, the results will be bad.

Why does it have to be aligned?

To generate samples with the same identity as the reference image, the first step is using a face recognition model to extract the feature of the reference image. If it is not cropped and aligned, the feature quality will be bad as the FR model was only trained with cropped and aligned images. Bad feature quality won't contain detailed information of face, so the generated images will be bad.
The other face generation model integrated a face detector in their pipeline, so they do not require the pre-processed images. I did not do it because for low resolution images (112x112), face detector will give you a "face not detected error". Moreover, this model is not for fancy face editing, so it is not necessary to integrate it into the pipeline.


dummy Iframe

Could you please take a look at this attempt of an iframe?
npm packages:
npm install react react-copy-to-clipboard
npm install prismjs react-modal
Changes made:
1. Updated with the latest version of dev.
2. Modal component creates a modal layer. Instantiates ExportCode component.
3. ExportCode component has several functionalities:

CopytoClipboard: takes an embedded constant with a hardcored iframe from new route generated (Embed component) and saves it to the clipboard.
With Prismjs package, the
 embedded is prettified.
We inject an iframe directly to this modal layer, getting the info from the localhost. For testing purposes, you should change it to your local address:

Before merging, this iframe should point to our production source instead (src="https://beta.adalab.es/easley-s4-manfred/#/embedded").
Important: preview logic of the cv__wrapper component has been put to sleep, since we have to discuss if this is the route we want to take with Nasiba.
Embed component: in App, we render conditionally a new route to this component. This component will only appear if "embedded" appears in the pathname. This Embed component instantiates the full CV, without the rest of the page components, standing on its own. We need this to generate an unique link to the CV. This link is the one that provides us with the "embedded" pathname address, which is needed for the iframe and the preview.

Please let me know your thoughts!
PS: a working iFrame couldn't be achieved without a server saving and retrieving the data from our users, that's why this is a mock-up approach.

@emma-martin hi Emma! I'm reviewing this but I'm not sure I understand how it should work.
The modal shows up when clicking the proper button, and an iframe code tag is generated above. But I can't see the preview of the entire code below, even though I tried changing to my local address as you suggested. Also, I copied/pasted the iframe code in a preview somewhere else, and the iframe generated shows the entire page, not the CV only. But I don't know if this is because I'm doing something wrong, given that in your computer seems to work alright.
I think I need a live demo of this functionality to understand better what it should be doing. Either I approve these changes now so that we have them in dev already, or I wait until tomorrow so that we can fix/finish whatever's left.
In any case, really good job on this!! Congrats because we're closer to achieving this thing!! :)


[docs] Community pattern migration

Evaluate the patterns that are currently listed on the community pattern page.
Step 1:

Evaluate community patterns in the community section.
Identify any patterns that seem too incomplete or domain specific (Group A)
Identify any patterns that are universal enough be a part of common carbon (Group B).
Status: Audit complete

Step 2:

Migrate Group A components back to owning PAL sites (if not already duplicated there) or open issues in target repos for teams to do.
Migrate high quality community patterns from the community section (Group B) to the top level carbon patterns sections.

Content and images should be groomed and updated before the content is merged. This work can be done over several sprint.

Step 3:

Edit community pattern list to contain only patterns that link out to PAL sites.
Determine if we making this section an index?

Here is the audit of the community patterns.
Most patterns need major work (image and content structure work) before the can be moved into the main Carbon pattern area.


Add Ansible Lint workflow

This PR adds a new Ansible Lint workflow that will run on PRs and can, read should, be added as a required check for pull requests before they are merged.
The real change here is the addition of these files:

.github/workflows/ansible-lint.yml
.github/actions/install-requirements/action.yml
.ansible-lint

Then, there are hundreds, thousands, of changes to make the existing samples pass the lint.
I took the following approach:

Remove all files that out-and-out break the linter with fatal errors by adding them as exclude_paths in .ansible-lint.
Add all failing rules to the skip_list in .ansible-lint, so that they are all ignored.
Gradually re-add rules, fixing up the repository content so as to meet the new rule. Each of these changes is a separate commit.
Stopping now when a good chunk of the rules have been re-added, though by no means all. Some of the remaining rules are more dangerous (less changing whitespace and more changing behaviour) so shouldn't be conducted by me when I'm not familiar with all the collections and can't test them easily. For others, I just haven't got round to them and feel it's best to get some linting in even without it being fully complete yet.

The PR is generally best reviewed with the w=1 URL query parameter to ignore whitespace, or commit-by-commit as otherwise it's a whole load of seemingly unrelated changes intermingled.
Moving forward from here, in subsequent PRs I'd like to:

investigate the files that fatally break the linter and re-add them into the checks by removing them from exclude_paths.
~continue to drop changes to re-add rules to the checked list by removing them from skip_list (it feels like we should match the default lint ruleset rather than only enable our own set).~ (done - see update below)

I do have a question about the .travis.yml files that I see everywhere. I think these are generated in a rather opinionated fashion by the ansible-galaxy init CLI. We don't use Travis CI on this repo and they add a lot of noise to the linter despite being non-Ansible files... can we do a blanket delete of them?
UPDATE: I've now removed all the excluded rules from the .ansible-lint, but instead explicitly ignored them per infringing file using .ansible-lint-ignore. This ensures that all changes to new files will have the full gamut of tests run on them. And it also gives us the opportunity to dole out pull requests to the contributors that remove those ignores, and ask the contributor to fix the errors and push to the PR once they've tested the revised playbook.

@ddimatos for your attention. I think you may need to hit a button to permit a new workflow to be run on this repo - as a non-committer I'm not able to see the button.

Closing this - see #188 for its replacement.


revisit Michelle's text comments/edits for 2019 assessment

Address Michelle's 2018 text comments/edits when writing the 2019 assessment document.
hake-assessment-2018 - commentsMM.pdf

Done.  There are some lingering ones I didn't answer, but they are broad enough to not worry about here.


Log failed flag attempts

Probably requires:

Creating a new database table for logging all flag submissions (will need to create db migration file)
Adding hooks into db "library" file to interface with this table
Logging all flag submissions in said table with team ID and timestamp


If there is an Unknown declaration in IDLProg, subsequent declarations cannot be obtained from TypeEnv.

Below is the last case of the test code.
Confirmed with candid 0.10, but reproduced with candid 0.9.
// candid = "0.10.0"
// candid_parser = "0.1.0"

#[cfg(test)]
mod tests {
    use std::ops::Deref;

    use candid::TypeEnv;
    use candid_parser::{IDLProg, check_prog};

    fn generate_type_env(ast: IDLProg) -> TypeEnv {
        let mut type_env = TypeEnv::new();
        let _ = check_prog(&mut type_env, &ast);
        type_env
    }

    #[test]
    fn test_only_primitive() {
        let did  = r#"
type RequestType = nat;
type ResponseType = text;"#.to_string();
        let ast: IDLProg = did.parse().unwrap();
        let type_env = generate_type_env(ast);
        assert_eq!(type_env.find_type("RequestType").unwrap().deref(), &candid::types::TypeInner::Nat);
        assert_eq!(type_env.find_type("ResponseType").unwrap().deref(), &candid::types::TypeInner::Text);
    }

    #[test]
    fn test_unknown_letter() {
        let did  = r#"
type RequestType = nat;
type ResponseType = UnknownType;"#.to_string();
        let ast: IDLProg = did.parse().unwrap();
        let type_env = generate_type_env(ast);
        assert_eq!(type_env.find_type("RequestType").unwrap().deref(), &candid::types::TypeInner::Nat);
        assert_eq!(type_env.find_type("ResponseType").unwrap().deref(), &candid::types::TypeInner::Unknown);
    }

    #[test]
    fn test_unknown_former() {
        let did  = r#"
type RequestType = UnknownType;
type ResponseType = text;"#.to_string();
        let ast: IDLProg = did.parse().unwrap();
        let type_env = generate_type_env(ast);
        assert_eq!(type_env.find_type("RequestType").unwrap().deref(), &candid::types::TypeInner::Unknown);
        assert_eq!(type_env.find_type("ResponseType").unwrap().deref(), &candid::types::TypeInner::Unknown); // NOTE: Why can't I get Text?
    }
}

Working as expected. check_prog(&mut type_env, &ast) return a result type, you need to unwrap the result in generate_type_env.
type RequestType = UnknownType;, UnknownType doesn't exist, check_prog will error out.

@chenyan-dfinity Thanks for confirming.
My point is that if you find a definition that is determined to be Unknown first, then a Type using a primitive defined later is also Unknown.
Do you mean that this is the behavior as specified?
I would like you to compare test_unknown_letter and test_unknown_former test cases.
The types to be declared in did are the same, only the order of definition is different.
The only difference is the order of definition.
(I'm using candid crete in an app on icp and didn't notice this behavior and put a potential bug in it.)

The did file you provided is invalid, therefore, TypeEnv doesn't make any sense, and you shouldn't be looking at TypeEnv with invalid did file.

if you find a definition that is determined to be Unknown first

This is never possible with a valid did file. No variable should be assigned to Unknown. We ensure this invariant via type checking.

I see.
I'm still concerned about the difference in behavior when reading something invalid, though.

We ensure this invariant via type checking.

Which API checks if .did or its string is correctly declared in input?

Thank you.
That's what you meant by your previous comment, sorry I didn't realize that.


Test: Selecting environments when VSCode is launched from an activated terminal

Refs: https://github.com/microsoft/vscode-python/issues/10668

[ ] windows @bhavyaus
[ ] linux @andreamah
[ ] macOS @sandy081

Complexity: 5
Create Issue

Requirements

Pre release build of the python extension.
VSCode Insiders.
Ability to create conda environments.
Ability to create virtual environments. For example, use virtualenvwrapper.

Verification
Virtual environments

Create a virtual environment:

mkvirtualenv testLaunch

Activate it:

workon testLaunch

Launch VSCode:

Open a folder and launch VSCode:

code-insiders .

Launch VSCode without a folder:

code-insiders

Any other way it can be launched via terminal.

Open a Python file to activate the extension, notice the newly created environment should be selected at startup, and that the logs indicate this:

Non-base conda environments

Create conda environment:

conda create -n testLaunch python

Activate it:

conda activate testLaunch

Launch VSCode.
Open a Python file to activate the extension, notice the newly created environment should be selected at startup.

Base conda environments

Context: By default, base conda environments are auto-activated by conda. We only want to select it if it is explicitly activated by user, so we need to check the configuration: https://stackoverflow.com/questions/54429210/how-do-i-prevent-conda-from-activating-the-base-environment-by-default.

Case I:

Set environment variable CONDA_AUTO_ACTIVATE_BASE to false.
Activate base environment and launch VSCode:

conda activate base

Open a Python file to activate the extension, notice the base should be selected at startup.

Case II:

Set environment variable CONDA_AUTO_ACTIVATE_BASE to true.
Restarting terminal (Powershell on windows) should auto-activate it by default.
Activate base environment if need be and launch VSCode.
Open a Python file to activate the extension, ensure the base environment is not auto-selected at startup.

Case III:

Unset the variable CONDA_AUTO_ACTIVATE_BASE.
Check value of conda config:

conda config --get auto_activate_base

If the output is set to false, unset it or set the value to true:

conda config --set auto_activate_base true

Restarting terminal (Powershell on windows) to auto-activate it, and launch VSCode.
Open a Python file to activate the extension, ensure the base environment is not auto-selected at startup.

Case IV:

Set config to false:

conda config --set auto_activate_base false

Activate base environment and launch VSCode.
Open a Python file to activate the extension, a prompt should be shown at startup:

Clicking "yes" on which should select the base environment.

@karrtikr Sorry that I do not have any clue to setup following abilities. Is there a doc for setting up them?

Ability to create conda environments.
Ability to create virtual environments. For example, use virtualenvwrapper.

Yes, they just require installing each tool.

Ability to create conda environments.

Install conda via: https://conda.io/projects/conda/en/latest/user-guide/install/index.html. Make sure it's on PATH during installation.

Ability to create virtual environments. For example, use virtualenvwrapper

Use pip install virtualenvwrapper to install it: https://pypi.org/project/virtualenvwrapper/

Verified all the cases for Conda and Non Conda cases on Windows.

When I set CONDA_AUTO_ACTIVATE_BASE to false, conda still activates base in the terminal (even after restarting). Is this expected?

Nevermind, I pasted it earlier in my bashrc and it works now 🤔

Good work!! Sorry about all of the confusion, lmk if you have questions!


Upgrade airbrake gem to version 4.1.0 (as used in alphagov/whitehall).

Addresses issue #1681 by upgrading to a newer version of the Airbrake gem to ensure Errbit reports ActionController::BadRequest correctly as exceptions, and not notifications.
Whilst not the latest version, its the same version as used in alphagov/whitehall.
Further details in Trello card (private board).

The changelog doesn't mention anything which sounds like it would require other changes for this bump, and Whitehall didn't have any non-Gemfile changes for a similar bump :+1:


Current version not available in F-Droid

Dear team,
when I take a look on google play store the current version is 5.800 in the F-Droid store the current version is 5.740.
What's the reason for this gap? Is there a bug in the build process?
Please fix this.
Kind Regards,
Krawei

K-9 Mail 5.800 was submitted to F-Droid 3 days ago:
https://gitlab.com/fdroid/fdroiddata/-/commit/2b81a8b15b733d2acf0940bee7d4f3492a2ea03a
It was successfully built yesterday:
https://monitor.f-droid.org/builds/log/com.fsck.k9/28000
It will be included in the next F-Droid index update (which has to be signed by the F-Droid key on an airgapped system which only 1 person has access to). The delay is 100% on F-Droid's side, but it's only a matter of time. The K-9 Mail team did their part.

5.802 build reports failure. Last line suggests its metadata is set to 5.801. It is unclear to me whether that's on your end or theirs.


Improve error when file cannot be read

Use the filename in the output.

Somewhat related, I'd like to extend this for InvalidFastlyToml error as well.
I was thinking about copying the from_str implementation into from_file and so I can access the path.
Do you have any suggestions?

Somewhat related, I'd like to extend this for InvalidFastlyToml error as well.
I was thinking about copying the from_str implementation into from_file and so I can access the path.
Do you have any suggestions?

for this, i might suggest providing this context elsewhere. threading a path through all of the code that isn't otherwise concerned with the file system doesn't feel quite right, so i'd imagine that we'd have better luck logging a warning near the call-site using something like...
let config = match FastlyConfig::from_file(config_path) {
    Ok(config) => config,
    Err(err) => {
        tracing::warn!(path = ?path, err = %err, "error reading configuration file");
        return Err(err);
    }
}


2.0.3   2017.06.30

ADD 'IncludeMembers' Switch to list all members in the report.
ADD 'AlwayseReport' switch to send report each run.
ADD 'OneReport' Switch to have it only send one email, with each group
report in the mail as attachment.
ADD 'ExtendedProperty' switch to add Enabled and PasswordExpired to the member list.
This only work for the AD module not Quest

Thanks for your contribution @McAndersDK !
So far I see a minor typo 'AlwayseReport' did you mean 'AlwaysReport' ?

I fixed the typos in my last commit. Thanks again for you help @McAndersDK


WIP: 0.60 blogpost

Currently, this is a rough WIP. I'm publishing this earlier than usual in order to get community feedback. I plan to elaborate on many sections, but specific pointers on areas to beef up are appreciated! Note that I have not yet completed editing for tone or phrasing, so it's also expected to be rough there.

As always, thanks for tackling this! ❤


JWTRefreshTokenBundle usage of refresh token as a service Issue

I currently installed JWTRefreshTokenBundle and it throws and error as:
Compile Error: Cannot use Gesdinet\JWTRefreshTokenBundle\Service\RefreshToken as RefreshToken because the name is already in use.
I think the issue occurred in the latest pull. I already used the bundle, but at that time it worked fine. I am using Symfony3.4

Hey, did you find a solution ? I have the same problem ...

same problem here after upgrading from symfony 2.8 to symfony 3.4


Add clusterrole for coredns

This makes coredns work if you have RBAC disabled.
This fixes #523

Thank you @wichert Your fixes will be on edge within the day and should reach stable with v1.15.1.


Update to use Go modules (go. 1.14). Add env var support

Added the ability to configure the clair URL via an environment variable (CLAIR_URL) to make it easier to use clair-scanner within Kubernetes, where the clair service will never be on localhost.
Update to use Go modules and fixed up a missing param on the integration test. Removed the dep stuff.

@chaholl thank you for the PR


static: Fix unreachable edit button in stream name

We use javascript to adjust the font-size every time the text in the stream name input is too big, so that the edit button can be seen. Also the overflow hidden has been removed.
#14260
#13139
Example of the above solution:

Closing, since I don't think dynamic font-size adjustment is going to work well.