Error in function deployment

Hi, I am trying out the whole vHive setup with function deployment and invocation using 1 master node and 1 worker node running on 2 separate VMs, and I encountered some errors when running the deployer client source /etc/profile && pushd ./tools/deployer && go build && popd && ./tools/deployer/deployer -funcPath ~/vhive/configs/knative_workloads
This was the output:
WARN[0602] Failed to deploy function helloworld-0, /home/vboxuser/vhive/configs/knative_workloads/helloworld.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'helloworld-0' in namespace 'default':

  2.963s The Route is still working to reflect the latest desired specification.
  5.347s Configuration "helloworld-0" is waiting for a Revision to become ready.
Error: timeout: service 'helloworld-0' not ready after 600 seconds
Run 'kn --help' for usage

INFO[0602] Deployed function helloworld-0
WARN[0602] Failed to deploy function pyaes-1, /home/vboxuser/vhive/configs/knative_workloads/pyaes.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'pyaes-1' in namespace 'default':

  1.442s The Route is still working to reflect the latest desired specification.
  4.234s Configuration "pyaes-1" is waiting for a Revision to become ready.
Error: timeout: service 'pyaes-1' not ready after 600 seconds
Run 'kn --help' for usage

INFO[0602] Deployed function pyaes-1
WARN[0603] Failed to deploy function pyaes-0, /home/vboxuser/vhive/configs/knative_workloads/pyaes.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'pyaes-0' in namespace 'default':

  4.206s The Route is still working to reflect the latest desired specification.
  5.117s ...
  5.621s Configuration "pyaes-0" is waiting for a Revision to become ready.
Error: timeout: service 'pyaes-0' not ready after 600 seconds
Run 'kn --help' for usage

INFO[0603] Deployed function pyaes-0
WARN[0603] Failed to deploy function rnn-serving-1, /home/vboxuser/vhive/configs/knative_workloads/rnn_serving.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'rnn-serving-1' in namespace 'default':

  0.751s The Route is still working to reflect the latest desired specification.
  3.778s Configuration "rnn-serving-1" is waiting for a Revision to become ready.
Error: timeout: service 'rnn-serving-1' not ready after 600 seconds
Run 'kn --help' for usage

INFO[0603] Deployed function rnn-serving-1
WARN[0603] Failed to deploy function rnn-serving-0, /home/vboxuser/vhive/configs/knative_workloads/rnn_serving.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'rnn-serving-0' in namespace 'default':

  2.567s The Route is still working to reflect the latest desired specification.
  4.244s Configuration "rnn-serving-0" is waiting for a Revision to become ready.
Error: timeout: service 'rnn-serving-0' not ready after 600 seconds
Run 'kn --help' for usage

INFO[0603] Deployed function rnn-serving-0
WARN[1207] Failed to deploy function rnn-serving-2, /home/vboxuser/vhive/configs/knative_workloads/rnn_serving.yaml: exit status 1
Warning: Kubernetes default value is insecure, Knative may default this to secure in a future release: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation, spec.template.spec.containers[0].securityContext.capabilities, spec.template.spec.containers[0].securityContext.runAsNonRoot, spec.template.spec.containers[0].securityContext.seccompProfile
Creating service 'rnn-serving-2' in namespace 'default':

  2.081s The Route is still working to reflect the latest desired specification.
  3.126s ...
  5.313s Configuration "rnn-serving-2" is waiting for a Revision to become ready.
Error: timeout: service 'rnn-serving-2' not ready after 600 seconds
Run 'kn --help' for usage

Additionally, below are logs from some commands I tried:
kubectl describe deployment :
Name:                   helloworld-0-00001-deployment
Namespace:              default
CreationTimestamp:      Tue, 27 Feb 2024 15:14:38 +0800
Labels:                 app=helloworld-0-00001
                        service.istio.io/canonical-name=helloworld-0
                        service.istio.io/canonical-revision=helloworld-0-00001
                        serving.knative.dev/configuration=helloworld-0
                        serving.knative.dev/configurationGeneration=1
                        serving.knative.dev/configurationUID=36b65317-e523-4ec3-8ea6-8734ebdf4d7b
                        serving.knative.dev/revision=helloworld-0-00001
                        serving.knative.dev/revisionUID=933839c6-a4fd-4bcf-907b-725a455a2503
                        serving.knative.dev/service=helloworld-0
                        serving.knative.dev/serviceUID=c8e131fc-8a06-46a1-8895-b7fd8d9ada06
Annotations:            autoscaling.knative.dev/target: 1
                        deployment.kubernetes.io/revision: 1
                        serving.knative.dev/creator: kubernetes-admin
Selector:               serving.knative.dev/revisionUID=933839c6-a4fd-4bcf-907b-725a455a2503
Replicas:               0 desired | 0 updated | 0 total | 0 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  0 max unavailable, 25% max surge
Pod Template:
  Labels:       app=helloworld-0-00001
                service.istio.io/canonical-name=helloworld-0
                service.istio.io/canonical-revision=helloworld-0-00001
                serving.knative.dev/configuration=helloworld-0
                serving.knative.dev/configurationGeneration=1
                serving.knative.dev/configurationUID=36b65317-e523-4ec3-8ea6-8734ebdf4d7b
                serving.knative.dev/revision=helloworld-0-00001
                serving.knative.dev/revisionUID=933839c6-a4fd-4bcf-907b-725a455a2503
                serving.knative.dev/service=helloworld-0
                serving.knative.dev/serviceUID=c8e131fc-8a06-46a1-8895-b7fd8d9ada06
  Annotations:  autoscaling.knative.dev/target: 1
                serving.knative.dev/creator: kubernetes-admin
  Containers:
   user-container:
    Image:      index.docker.io/crccheck/hello-world@sha256:0404ca69b522f8629d7d4e9034a7afe0300b713354e8bf12ec9657581cf59400
    Port:       50051/TCP
    Host Port:  0/TCP
    Environment:
      GUEST_PORT:       50051
      GUEST_IMAGE:      ghcr.io/ease-lab/helloworld:var_workload
      PORT:             50051
      K_REVISION:       helloworld-0-00001
      K_CONFIGURATION:  helloworld-0
      K_SERVICE:        helloworld-0
    Mounts:             <none>
   queue-proxy:
    Image:       ghcr.io/vhive-serverless/queue-39be6f1d08a095bd076a71d288d295b6@sha256:41259c52c99af616fae4e7a44e40c0e90eb8f5593378a4f3de5dbf35ab1df49c
    Ports:       8022/TCP, 9090/TCP, 9091/TCP, 8013/TCP, 8112/TCP
    Host Ports:  0/TCP, 0/TCP, 0/TCP, 0/TCP, 0/TCP
    Requests:
      cpu:      25m
    Readiness:  http-get http://:8013/ delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      SERVING_NAMESPACE:                        default
      SERVING_SERVICE:                          helloworld-0
      SERVING_CONFIGURATION:                    helloworld-0
      SERVING_REVISION:                         helloworld-0-00001
      QUEUE_SERVING_PORT:                       8013
      QUEUE_SERVING_TLS_PORT:                   8112
      CONTAINER_CONCURRENCY:                    0
      REVISION_TIMEOUT_SECONDS:                 300
      REVISION_RESPONSE_START_TIMEOUT_SECONDS:  0
      REVISION_IDLE_TIMEOUT_SECONDS:            0
      SERVING_POD:                               (v1:metadata.name)
      SERVING_POD_IP:                            (v1:status.podIP)
      SERVING_LOGGING_CONFIG:
      SERVING_LOGGING_LEVEL:
      SERVING_REQUEST_LOG_TEMPLATE:             {"httpRequest": {"requestMethod": "{{.Request.Method}}", "requestUrl": "{{js .Request.RequestURI}}", "requestSize": "{{.Request.ContentLength}}", "status": {{.Response.Code}}, "responseSize": "{{.Response.Size}}", "userAgent": "{{js .Request.UserAgent}}", "remoteIp": "{{js .Request.RemoteAddr}}", "serverIp": "{{.Revision.PodIP}}", "referer": "{{js .Request.Referer}}", "latency": "{{.Response.Latency}}s", "protocol": "{{.Request.Proto}}"}, "traceId": "{{index .Request.Header "X-B3-Traceid"}}"}
      SERVING_ENABLE_REQUEST_LOG:               false
      SERVING_REQUEST_METRICS_BACKEND:          prometheus
      TRACING_CONFIG_BACKEND:                   none
      TRACING_CONFIG_ZIPKIN_ENDPOINT:
      TRACING_CONFIG_DEBUG:                     false
      TRACING_CONFIG_SAMPLE_RATE:               0.1
      USER_PORT:                                50051
      SYSTEM_NAMESPACE:                         knative-serving
      METRICS_DOMAIN:                           knative.dev/internal/serving
      SERVING_READINESS_PROBE:                  {"tcpSocket":{"port":50051,"host":"<IP_ADDRESS>"},"successThreshold":1}
      ENABLE_PROFILING:                         false
      SERVING_ENABLE_PROBE_REQUEST_LOG:         false
      METRICS_COLLECTOR_ADDRESS:
      CONCURRENCY_STATE_ENDPOINT:
      CONCURRENCY_STATE_TOKEN_PATH:             /var/run/secrets/tokens/state-token
      HOST_IP:                                   (v1:status.hostIP)
      ENABLE_HTTP2_AUTO_DETECTION:              false
      ROOT_CA:
    Mounts:                                     <none>
  Volumes:                                      <none>
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      True    MinimumReplicasAvailable
  Progressing    True    NewReplicaSetAvailable
OldReplicaSets:  <none>
NewReplicaSet:   helloworld-0-00001-deployment-85b6cd4698 (0/0 replicas created)
Events:
  Type    Reason             Age   From                   Message
  ----    ------             ----  ----                   -------
  Normal  ScalingReplicaSet  55m   deployment-controller  Scaled up replica set helloworld-0-00001-deployment-85b6cd4698 to 1
  Normal  ScalingReplicaSet  45m   deployment-controller  Scaled down replica set helloworld-0-00001-deployment-85b6cd4698 to 0 from 1

kubectl get revisions and kubectl describe revision <name> :
Name:         helloworld-0-00001
Namespace:    default
Labels:       serving.knative.dev/configuration=helloworld-0
              serving.knative.dev/configurationGeneration=1
              serving.knative.dev/configurationUID=36b65317-e523-4ec3-8ea6-8734ebdf4d7b
              serving.knative.dev/routingState=active
              serving.knative.dev/service=helloworld-0
              serving.knative.dev/serviceUID=c8e131fc-8a06-46a1-8895-b7fd8d9ada06
Annotations:  autoscaling.knative.dev/target: 1
              serving.knative.dev/creator: kubernetes-admin
              serving.knative.dev/routes: helloworld-0
              serving.knative.dev/routingStateModified: 2024-02-27T07:14:33Z
API Version:  serving.knative.dev/v1
Kind:         Revision
Metadata:
  Creation Timestamp:  2024-02-27T07:14:33Z
  Generation:          1
  Managed Fields:
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:autoscaling.knative.dev/target:
          f:serving.knative.dev/creator:
          f:serving.knative.dev/routes:
          f:serving.knative.dev/routingStateModified:
        f:labels:
          .:
          f:serving.knative.dev/configuration:
          f:serving.knative.dev/configurationGeneration:
          f:serving.knative.dev/configurationUID:
          f:serving.knative.dev/routingState:
          f:serving.knative.dev/service:
          f:serving.knative.dev/serviceUID:
        f:ownerReferences:
          .:
          k:{"uid":"36b65317-e523-4ec3-8ea6-8734ebdf4d7b"}:
      f:spec:
        .:
        f:containerConcurrency:
        f:containers:
        f:enableServiceLinks:
        f:timeoutSeconds:
    Manager:      controller
    Operation:    Update
    Time:         2024-02-27T07:14:33Z
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:actualReplicas:
        f:conditions:
        f:containerStatuses:
        f:observedGeneration:
    Manager:      controller
    Operation:    Update
    Subresource:  status
    Time:         2024-02-27T07:25:29Z
  Owner References:
    API Version:           serving.knative.dev/v1
    Block Owner Deletion:  true
    Controller:            true
    Kind:                  Configuration
    Name:                  helloworld-0
    UID:                   36b65317-e523-4ec3-8ea6-8734ebdf4d7b
  Resource Version:        24730
  UID:                     933839c6-a4fd-4bcf-907b-725a455a2503
Spec:
  Container Concurrency:  0
  Containers:
    Env:
      Name:   GUEST_PORT
      Value:  50051
      Name:   GUEST_IMAGE
      Value:  ghcr.io/ease-lab/helloworld:var_workload
    Image:    crccheck/hello-world:latest
    Name:     user-container
    Ports:
      Container Port:  50051
      Name:            h2c
      Protocol:        TCP
    Readiness Probe:
      Success Threshold:  1
      Tcp Socket:
        Port:  0
    Resources:
  Enable Service Links:  false
  Timeout Seconds:       300
Status:
  Actual Replicas:  0
  Conditions:
    Last Transition Time:  2024-02-27T07:25:29Z
    Message:               The target is not receiving traffic.
    Reason:                NoTraffic
    Severity:              Info
    Status:                False
    Type:                  Active
    Last Transition Time:  2024-02-27T07:14:40Z
    Reason:                Deploying
    Status:                Unknown
    Type:                  ContainerHealthy
    Last Transition Time:  2024-02-27T07:24:50Z
    Message:               Failed to get/pull image: failed to prepare extraction snapshot "extract-305755493-hrFD sha256:5216338b40a7b96416b8b9858974bbe4acc3096ee60acbc4dfb1ee02aecceb10": context deadline exceeded
    Reason:                CreateContainerError
    Status:                False
    Type:                  Ready
    Last Transition Time:  2024-02-27T07:24:50Z
    Message:               Failed to get/pull image: failed to prepare extraction snapshot "extract-305755493-hrFD sha256:5216338b40a7b96416b8b9858974bbe4acc3096ee60acbc4dfb1ee02aecceb10": context deadline exceeded
    Reason:                CreateContainerError
    Status:                False
    Type:                  ResourcesAvailable
  Container Statuses:
    Image Digest:       index.docker.io/crccheck/hello-world@sha256:0404ca69b522f8629d7d4e9034a7afe0300b713354e8bf12ec9657581cf59400
    Name:               user-container
  Observed Generation:  1
Events:                 <none>

Please attach Firecracker logs from /tmp/vhive-logs/

from worker node:
firecracker.stderr.zip
firecracker.stdout.zip

Hi @leokondrashov I just tried running the setup, deployment, and invocation steps on CloudLab, and it proceeded smoothly without incident, however the output file rps0.00_lat.csv  is empty. Is this expected behaviour? Am I missing certain steps or configurations in order to get the latencies of the function runs?
For reference below is the endpoints.json file from the master node:
[
	{
		"hostname": "helloworld-0.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	},
	{
		"hostname": "pyaes-0.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	},
	{
		"hostname": "pyaes-1.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	},
	{
		"hostname": "rnn-serving-0.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	},
	{
		"hostname": "rnn-serving-1.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	},
	{
		"hostname": "rnn-serving-2.default.<IP_ADDRESS>.sslip.io",
		"eventing": false,
		"matchers": null
	}
]

Sorry for the late follow-up. The 0.00 in the name of the file means that all invocations failed. In the output of the invoker run, how many requests succeeded should be said. Although, that might be caused by cold starts taking some time. You can try to rerun the invoker several times so that it can warm the instances up. If the requests still fail, please provide output of kubectl get pods, there should be pods in running states, if they are not, please run kubectl describe pod <pod_name> on them.

They are the end-to-end delay measurements for each of the requests in microseconds.

Does each number correspond to one function in endpoints.json? Or does it represent the time it takes for all functions to finish executing (concurrently or sequentially?)
Incidentally, I tried running the invoker once on the worker node and i got 1 value in the rps_0.20.csv file, so im a bit confused on the representation of the output

It reports end-to-end latencies for requests to functions from endpoints.json in round-robin fashion. One number for each requests. By default, it is 1 request per second for 5 seconds (both can be changed: https://github.com/vhive-serverless/vSwarm/blob/main/tools/invoker/README.md).
The number in the file's name means the number of successful invocations per second (0.2 means 1 successful request in 5 seconds). The cold starts might cause a low success rate, since all requests that will respond after 5 seconds are considered failed. That's why rerunning the invoker helps to get more appropriate results.

I see. Can I also check how to run some of the benchmark functions in vSwarm? I am trying out the fibonacci one but i got a make: docker: Command not found error when trying to run make all-images. I tried installing docker with sudo apt-get install docker but am still getting the same error. Do you have an idea what might be the issue?

Hi @leokondrashov, do you have any input on this?

I'm sorry. I thought I had sent the comment. It's better to ask questions about benchmarks in the vSwarm repository. But regarding the docker issue, docker is installed with apt install docker.io.

Alright, ill start a new issue in the vSwarm repository if I have further questions on the benchmarks. But for the docker issue, i tried installing docker.io, but it is unable to find the package:
E: Unable to locate package docker.io
E: Couldn't find any package by glob 'docker.io'
E: Couldn't find any package by regex 'docker.io'

From googling online it says to install just docker, which was what i tried previously but had the command not found issue.

Yes, it is better to run sudo apt update. Please also provide the distro info, because it is weird that Ubuntu can't find the docker.io package.
Otherwise, proceed with official guides on docker installation: https://docs.docker.com/engine/install/ubuntu/.

Nothing gets updated when i run the upgrade, and it still cannot find docker.io package. I am running Ubuntu 20.04 LTS (GNU/Linux 5.4.0-164-generic x86_64) OS, based on the CloudLab profile provided in the vHive quickstart guide. Was the docker installation working fine when you tested on this setup previously?

I just tried on fresh xl170 cloudlab node, it works. I ran two commands: sudo apt update; sudo apt install docker.io. Successfully installs and runs. Also, you might need to add the user to docker group: https://docs.docker.com/engine/install/linux-postinstall/, but that doesn't affect the availability of the package.

Thanks. The docker make works fine now. But now it seems like there is issue with deploying the benchmark, ill start a new issue on the vSwarm repository for that.


Add forceSynch option which will autosave to textarea.

Since this is built on CodeMirror I opted to use CodeMirror's save
behaviour rather than pulling the value and stomping on the textarea's
innerHtml.
See this jsfiddle to see it in action.
Fixes #193

I just made a few comments in the code about some changes I'd prefer before merging it in.

Here is the jsFiddle representing new naming.

Great! One last change, can you demo the non-default option in the block of code in the README that demonstrates all options? For this instance, you'd need to add forceSync: true, in the appropriate alphabetical location.

Merged in #264. Had to make a commit to eliminate conflicts. Thanks for the contribution!

Thanks for this. Now textarea with required attribute will not break.


189 | Rotate Array | C++

Title - #189  Rotate Array
What will change -
Type of Issue -

[x] Adding New Code

Programming Language

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign this to me.

Could you please assign this to me?


scan() crash when using Firebase plugins

My code is just like:
    _scanStream = FlutterBlue.instance.scan().listen((resultList) async {
      print(resultList);
    });

Tried to do
    FlutterBlue.instance.scan();
    _scanStream = FlutterBlue.instance.scanResults.listen((resultList) async {
      print(resultList);
    });

Crash log:
W/o2b.developmen(14189): Accessing hidden field Ljava/nio/Buffer;->address:J (light greylist, reflection)
E/flutter (14189): [ERROR:flutter/shell/platform/android/platform_view_android_jni_impl.cc(43)] java.lang.ExceptionInInitializerError
E/flutter (14189): 	at com.pauldemarco.flutter_blue.Protos$ScanSettings.newBuilder(Protos.java:2306)
E/flutter (14189): 	at com.pauldemarco.flutter_blue.FlutterBluePlugin.startScan(FlutterBluePlugin.java:745)
E/flutter (14189): 	at com.pauldemarco.flutter_blue.FlutterBluePlugin.onMethodCall(FlutterBluePlugin.java:255)
E/flutter (14189): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/flutter (14189): 	at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85)
E/flutter (14189): 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:692)
E/flutter (14189): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/flutter (14189): 	at android.os.MessageQueue.next(MessageQueue.java:326)
E/flutter (14189): 	at android.os.Looper.loop(Looper.java:181)
E/flutter (14189): 	at android.app.ActivityThread.main(ActivityThread.java:7050)
E/flutter (14189): 	at java.lang.reflect.Method.invoke(Native Method)
E/flutter (14189): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
E/flutter (14189): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
E/flutter (14189): Caused by: java.lang.RuntimeException: Unable to get message info for com.pauldemarco.flutter_blue.Protos$ScanSettings
E/flutter (14189): 	at com.google.protobuf.GeneratedMessageInfoFactory.messageInfoFor(GeneratedMessageInfoFactory.java:62)
E/flutter (14189): 	at com.google.protobuf.ManifestSchemaFactory$CompositeMessageInfoFactory.messageInfoFor(ManifestSchemaFactory.java:143)
E/flutter (14189): 	at com.google.protobuf.ManifestSchemaFactory.createSchema(ManifestSchemaFactory.java:55)
E/flutter (14189): 	at com.google.protobuf.Protobuf.schemaFor(Protobuf.java:93)
E/flutter (14189): 	at com.google.protobuf.Protobuf.schemaFor(Protobuf.java:107)
E/flutter (14189): 	at com.google.protobuf.GeneratedMessageLite.makeImmutable(GeneratedMessageLite.java:171)
E/flutter (14189): 	at com.pauldemarco.flutter_blue.Protos$ScanSettings.<clinit>(Protos.java:2547)
E/flutter (14189): 	... 13 more
E/flutter (14189): Caused by: java.lang.UnsupportedOperationException
E/flutter (14189): 	at com.pauldemarco.flutter_blue.Protos$ScanSettings.dynamicMethod(Protos.java:2539)
E/flutter (14189): 	at com.google.protobuf.GeneratedMessageLite.dynamicMethod(GeneratedMessageLite.java:252)
E/flutter (14189): 	at com.google.protobuf.GeneratedMessageLite.buildMessageInfo(GeneratedMessageLite.java:280)
E/flutter (14189): 	at com.google.protobuf.GeneratedMessageInfoFactory.messageInfoFor(GeneratedMessageInfoFactory.java:60)
E/flutter (14189): 	... 19 more
E/flutter (14189):
F/flutter (14189): [FATAL:flutter/shell/platform/android/platform_view_android_jni_impl.cc(942)] Check failed: CheckException(env).
F/libc    (14189): Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 14189 (o2b.development), pid 14189 (o2b.development)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Build fingerprint: 'samsung/dreamltexx/dreamlte:9/PPR1.180610.011/G950FXXU9DTF1:user/release-keys'
Revision: '10'
ABI: 'arm64'
pid: 14189, tid: 14189, name: o2b.development  >>> com.ardev.canario2b.development <<<
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Abort message: '[FATAL:flutter/shell/platform/android/platform_view_android_jni_impl.cc(942)] Check failed: CheckException(env).
'
    x0<PHONE_NUMBER>000000  x1<PHONE_NUMBER>00376d  x2<PHONE_NUMBER>000006  x3<PHONE_NUMBER>000008
    x4<PHONE_NUMBER>008000  x5<PHONE_NUMBER>008000  x6<PHONE_NUMBER>008000  x7<PHONE_NUMBER>000000
    x8<PHONE_NUMBER>000083  x9  0000007c9d63c878  x10 fffffff87ffffbdf  x11<PHONE_NUMBER>000001
    x12 0000007c01184580  x13<PHONE_NUMBER>000008  x14 ffffffffffffffff  x15 00004e492a7536e4
    x16 0000007c9d6732a0  x17 0000007c9d5b2920  x18 0000007fefaf2dfa  x19<PHONE_NUMBER>00376d
    x20<PHONE_NUMBER>00376d  x21<PHONE_NUMBER>000083  x22 0000007c1a2d2aa8  x23 0000007c00bf11b0
    x24 0000007c00bf1198  x25<PHONE_NUMBER>000000  x26 0000007ca0d3d5f8  x27<PHONE_NUMBER>000036
    x28<PHONE_NUMBER>000001  x29 0000007fefaf36c0
    sp  0000007fefaf3680  lr  0000007c9d5a5d68  pc  0000007c9d5a5d94
backtrace:
    #00 pc<PHONE_NUMBER>021d94  /system/lib64/libc.so (abort+124)
    #01 pc<PHONE_NUMBER>287004  /data/app/com.ardev.canario2b.development-uPL-CjmFT8IWPddDqlfZfA==/lib/arm64/libflutter.so (offset 0x126e000)
    #02 pc<PHONE_NUMBER>001e9c  [anon:.bss:0000007bff565000]
Lost connection to device.

I have 2 other projects with Flutter Blue, which works well. This seems equals, but crashes. What can cause the crash?
Tried to add
minifyEnabled false
shrinkResources false

but it's not working and seems like a bad idea.
Seems like there is an exception in Protos builder but it is too complicated for me.
Reproducable on all Android devices that I have (Xiaomi Mi8 Lite (Android 10), Samsung S8(Android 9), OnePlus A3010 (Android 9))

Tried to add
minifyEnabled false
shrinkResources false

but it's not working and seems like a bad idea.
Seems like there is an exception in Protos builder but it is too complicated for me.

The problem causes by configuration in app/build.gradle.
    configurations {
        implementation.exclude module:'protobuf-lite'
    }

It is needed because I use Firebase plugins (Remote Config and Crashlitycts) which use protobuf (default, not the lite version) and it causes an exception on building stage:
Execution failed for task ':app:checkDevelopmentDebugDuplicateClasses'.
> 1 exception was raised by workers:
  java.lang.RuntimeException: Duplicate class com.google.protobuf.AbstractMessageLite found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
  Duplicate class com.google.protobuf.AbstractMessageLite$Builder found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
  Duplicate class com.google.protobuf.AbstractMessageLite$Builder$LimitedInputStream found in modules protobuf-javalite-3.11.0.jar (com.google.protobuf:protobuf-javalite:3.11.0) and protobuf-lite-3.0.1.jar (com.google.protobuf:protobuf-lite:3.0.1)
........

Refers to https://github.com/pauldemarco/flutter_blue/pull/676


x/build/cmd/gerritbot: too many comments on a new pull request

For example: https://github.com/golang/go/pull/24322
I would expect two comments - "This PR has been imported to Gerrit", and the forward of the "Congratulations on opening your first change" automated comment.
However, somehow gerritbot (or perhaps GitHub?) seem to think that the pull request needed importing twice, or that it was updated when it doesn't look like it was.
Or perhaps the pull request was updated while gerritbot was importing it, resulting in these duplicate and confusing messages.

You say "for example" but has this happened on other PRs as well?

Not that I have noticed, but I haven't gone through all of them. I have only seen it once, so it's likely not something that happens often


Remove konacha javascript tests

Konacha added a lot of dependencies and overhead just to test the emoji js and it's not been updated to work with rails 5 either so I'm taking a 🔪  to it and removing it for now, will make things simpler for new users and less of a headache for upgrading to rails 5.

Very good shout! 👍


Aoaf 257 sign in page

Adding a test webpage Get('/post-sign') to test the sigin functionality. Once the sigin journey will be tested we will remove this webpage.

Do you need to add a nunjucks view?


[Ionic v4.0.0-beta.11] ion-select form.patchValue

Bug Report
Ionic Info
Ionic:
   ionic (Ionic CLI)          : 4.1.2 (C:\Users\matth\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.11
   @angular-devkit/core       : 0.7.4
   @angular-devkit/schematics : 0.7.4
   @angular/cli               : 6.1.4
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5

System:
   NodeJS : v8.9.4 (C:\Program Files\nodejs\node.exe)
   npm    : 5.6.0
   OS     : Windows 10

Describe the Bug
The ion-select component on a reactive form does not work correctly with form.patchValue. After a patch, sometimes the ion-select shows the value selected and sometimes it doesn't.

Steps to Reproduce
Steps to reproduce the behavior:

Create a blank app.
Create a reactive form with an ion-select control. Use code in this ticket https://github.com/ionic-team/ionic/issues/15572
Add form.patchValue i.e.

ngOnInit() {

    this.form = this.formBuilder.group({
        languageCode: ['', Validators.compose([Validators.required])]
    });

    this.form.patchValue({
        languageCode: 'en'
    });
}

It's difficult to reproduce this consistently. I found the best way was to simply refresh the page over and over again until ion-select doesn't display a value.

Expected Behavior
The ion-select component displays a value after form.patchValue
Additional Context
With a small list like this example 1 out of ~30 page refreshes resulted in this behavior. With larger lists and doing the patch in an observable subscribe failed 1 out of 3 times.
It appears to be a race condition issue. If I wrap the patch in a short delay the ion-select displays correctly every time. e.g.
setTimeout(
	function () {
		that.form.patchValue({
			name: data.name,
			locationId: data.locationId
		});
}, 5);

Thanks for the issue! Are you still seeing this problem in latest, 4.0.0-beta.17?


Avoid element to be dragged and define fixed height

I'm using Draggabilly and Packery to build a optimized draggable layout as shown in this Codepen: https://codepen.io/rafaF/pen/MWjvjqO
I have some doubts about how to use Packery/Draggabily.

The first one is how to convert en element "no-draggable", i.e., avoid to be dragged. I've achieved this by no initializing its Draggabilly instance, but I would like also to not be sorted when dragging others elements.

In the other hand, I have not been able to set a fixed height on my Packery layout in order to limit how many elements fits in a column. My idea is that if you move an element to a column that has no free space, the most bottom element should be moved to the other column. I have not found any way to do this.

I have been searching on the docs but I have not been able to find this info, sorry!

Hello! Thanks for reporting this issue and providing a test case.

The first one is how to convert en element "no-draggable", i.e., avoid to be dragged. I've achieved this by no initializing its Draggabilly instance

That's one way to do it

but I would like also to not be sorted when dragging others elements.

You may need to stamp the element in that case

In the other hand, I have not been able to set a fixed height on my Packery layout in order to limit how many elements fits in a column.

Packery is not designed to fixed height. It is designed to have a variable container height, so you can always add more to the bottom. In order to set a fixed height, you would need to overwrite some core Packery functionality, specifically with its packer geometry

Hello! Thanks for reporting this issue and providing a test case.

The first one is how to convert en element "no-draggable", i.e., avoid to be dragged. I've achieved this by no initializing its Draggabilly instance

That's one way to do it

but I would like also to not be sorted when dragging others elements.

You may need to stamp the element in that case

In the other hand, I have not been able to set a fixed height on my Packery layout in order to limit how many elements fits in a column.

Packery is not designed to fixed height. It is designed to have a variable container height, so you can always add more to the bottom. In order to set a fixed height, you would need to overwrite some core Packery functionality, specifically with its packer geometry

Hi @desandro I'm running into a similar issue regarding Draggabilly and stamped areas. Is there a way to permanently prevent draggable elements from being dropped into the stamped area? Do I need to refire the stamp method during each drag? If so, which event should I be waiting for?
Here is an example: https://codepen.io/andrewmowe/pen/Exozzpb


Truncated scroll feedback for last item

First item scroll feedback is no problem

But the last item will be truncated

That is for items with size 2. If the size larger, the feedback will not show at all.

Well, I guess understand your problem with cards not showing when size is larger than 2 but I didn't understand what's wrong with your second card in your second print... is that second card different from first and it's truncated? BTW this project is just a view pager extension then you can set all others view pager properties this repository has an implementation example, see in https://github.com/bloderxd/deck/blob/master/app/src/main/java/com/example/bloder/deck/MainActivity.kt

The problem is with the scroll feedback, the red one on the left and right side that appear there. When we reach the end or the beginning of scroll, a scroll feedback will appear.

Oh, understood... probably it's a padding problem... but I will investigate it, thank you to report!

Just a quick fix, we can disable the feedback/overscroll using
android:overScrollMode="never" in XML and
deckPager.overScrollMode = View.OVER_SCROLL_NEVER in kotlin

Good, maybe it's easier disable than fix that but I will investigate it and try to make a fix.


Bug: requests PUT type without segment redirects to index method instead update method

I have created a restful resource to handle my api requests, like this:
$routes->resource('api/categoria', ['controller' => 'Api\Categoria']);
When I make a PUT request, like this:
PUT localhost:8080/api/categoria/5 it works fine, calling the desired method inside the Categoria controller, update, in this case
But, when I make a request without an ID, it redirects to the index method inside the Categoria controller
My intention is when the user doesn't send an ID I will respond him with a fail message telling that an ID is required, but it is not working like that.
How to reproduce the error:

Fresh installation of CodeIgniter appstarter

Create a restful resource, like my example

Create a Controller and two methods inside: index() and update()

Use Postman to simulate a put request with and without an ID

When you make the request with an ID, it will be redirected to the update method, like expected.
But, when the ID is removed, it redirects to the index() method.
The only way I find out to fix this is creating manually the route that handles the PUT request, like so:

$routes->put('api/categoria', 'Api\Categoria::update');

Environment: Localhost, windows 10
PHP 7.3.1

This isn’t a big, it’s the predefined routes associated with a ResourceController. See https://codeigniter4.github.io/CodeIgniter4/incoming/restful.html#presenter-controller-comparison
What would you expect of a PUT to resource root?

I would expect an route error message, telling me that it is a not implemented route, instead showing all my records from the index method.
Am I correct to think like that?
Thank you.

@reszko Change auto route settings to $routes->setAutoRoute(false) in your app/Config/Routes.php file.


CNCF Defender Tasks for devfile/alizer

Which area/kind this issue is related to?

/area alizer
Issue Description

As part of our effort to maintain best practices we have added all of our repositories to the CLO Monitor. This issue aims to resolve the checks needed for our repositories to reach 100% on the monitor.
A list of the checks for each check set can be found here: https://clomonitor.io/docs/topics/checks/
Remaining Items
Security

[x] Dependencies Policy
[x] Dependency Update Tool
[ ] Software Bill of Materials (SBOM)
[x] Security Insights
[ ] Security Policy
[ ] Signed Releases
[ ] Token Permissions

Defender tasks with the same checklist items were sized as Major with 5 story points. Assigning this the same and moving to backlog.

As discussed the security policy will be covered after the completion of https://github.com/devfile/api/issues/1461. We might need to ignore for now the following checks:

Software Bill of Materials (SBOM)
Signed Releases
Token Permissions
cc @Jdubrick @michael-valdron

As discussed the security policy will be covered after the completion of #1461. We might need to ignore for now the following checks:

Software Bill of Materials (SBOM)
Signed Releases
Token Permissions
cc @thepetk  @michael-valdron

Are these checks being ignored for now as in leaving unchecked or should a discussion be had for exemption them from the checks? Also, would that be relevant for all repos covered under https://github.com/devfile/api/issues/1297

As discussed the security policy will be covered after the completion of #1461. We might need to ignore for now the following checks:

Software Bill of Materials (SBOM)
Signed Releases
Token Permissions
cc @thepetk  @michael-valdron

Are these checks being ignored for now as in leaving unchecked or should a discussion be had for exemption them from the checks? Also, would that be relevant for all repos covered under #1297

I think we can revisit the topic in a future devtools week. So I'd say we can:

Close the parent epic and all the children issues when the Dependencies Policy, Dependency Update Tool & Security Insights are covered.
Create a new epic for future work around SBOMs, Signed Releases and Token Permissions.
The Security Policy Check is included here: https://github.com/devfile/api/issues/1461

WDYT?

As discussed the security policy will be covered after the completion of #1461. We might need to ignore for now the following checks:

Software Bill of Materials (SBOM)
Signed Releases
Token Permissions

Are these checks being ignored for now as in leaving unchecked or should a discussion be had for exemption them from the checks? Also, would that be relevant for all repos covered under #1297

I think we can revisit the topic in a future devtools week. So I'd say we can:

Close the parent epic and all the children issues when the Dependencies Policy, Dependency Update Tool & Security Insights are covered.
Create a new epic for future work around SBOMs, Signed Releases and Token Permissions.
The Security Policy Check is included here: Create Security Policy for the Devfiles Org #1461

WDYT?

I think that is a good idea. I will create an epic and initial investigation issue for SBOM, Signed Releases and Token Permissions that we can refer to.

Epic created here with initial spike: https://github.com/devfile/api/issues/1465
cc: @michael-valdron @thepetk


MidiEvent throttling-property not yet implemented

https://github.com/krixgris/MidiToOSC/blob/c3deda8870349167c46fb72e9bfe045cde0b18c9/miditoosc.py#L18-L18

[ ] Implement a check on MidiEvent.throttling in the throttling-function
[ ] Test it in combination with global override on throttling

Overkill. Won't get implemented.


Reconstructed velocities for momentum advection terms.

Purpose
Implements face-valued reconstruction of velocities for application in the momentum tendency expressions.
Todo

[x] Define $\tilde{\boldsymbol{u}}$
[x] Update horizontal tendency term
[x] Update vertical tendency term
[x] Update documentation to reflect changes to equations

[ ] I have read and checked the items on the review checklist.

Longruns are currently in progress  - for a 600 day simulation, averaged over the final 400days, the outputs are shown below:
Temperature

Potential Temperature

Zonal Velocity

@simonbyrne, please review and check on pre-computing contravariant velocity vector components.

cc @simonbyrne This is ready for review

bors r+


Following the example for a Card without an avatar renders an avatar

I'm following the sample code to render a card without an avatar and still seeing it:
http://www.material-ui.com/#/components/card

What version are you using?

@oliviertassinari Yeah versioning of the docs site is a must!. for now we can at least do that. Any idea how we can achieve this? A section in the header maybe?

@oliviertassinari @subjectix Yeah I think a dropdown in the header makes sense. Maybe we make the header "versionless" and the rest of the content based on doc version. Might be able to use react router's dynamic routes and stored built copies of the docs in a different repo.

We should discuss this in the related issue: #1986

0.14.0-rc1 is the version I'm using.

@raybooysen 0.14.0 was released recently. please update.


How to give unique ID for a repeating div in a Cocoon ?

I need to add a unique ID for a each repeating div in a cocoon, how can i do that ? any help will appreciate

Of course there are many different options, so if you explain why you need this, I could maybe point to some solutions or alternatives.
The simple answer is: use the callbacks to manipulate the HTML before/after insert and add a unique ID.
Check the following (possibly) related issues:

#403
#394
#362
#365

If you explain in more detail what you are trying to achieve and show me some code, I can give you more specific help.

  What does getting the div ID allow you to do?
Also, do you get the console log messages?  If you don't get the console log messages please check this document on how to trouble shoot your issue ... Trouble shooting Jquery

@smartmall ... I stumbled this when digging something else too ... but you have to conver tot using haml instead of ERB (I'm sure there's other ways,but haml is better in general)...http://stackoverflow.com/questions/2217583/how-do-i-make-dynamic-ids-in-haml

Closed due to inactivity.


Restore Database in Docker

Codecov Report

Merging #12530 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12530      +/-   ##
==========================================
- Coverage   43.52%   43.50%   -0.02%
==========================================
  Files         642      642
  Lines       71003    71003
==========================================
- Hits        30904    30890      -14
- Misses      35096    35106      +10
- Partials     5003     5007       +4

Impacted Files
Coverage Δ

modules/notification/mail/mail.go
32.50% <0.00%> (-3.75%)
:arrow_down:

modules/notification/ui/ui.go
80.55% <0.00%> (-2.78%)
:arrow_down:

modules/process/manager.go
72.50% <0.00%> (-2.50%)
:arrow_down:

services/pull/check.go
47.69% <0.00%> (-2.31%)
:arrow_down:

modules/log/event.go
57.54% <0.00%> (-1.89%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.54%)
:arrow_down:

models/notification.go
66.13% <0.00%> (-0.92%)
:arrow_down:

models/error.go
34.81% <0.00%> (-0.86%)
:arrow_down:

services/pull/pull.go
41.57% <0.00%> (ø)

modules/git/repo.go
49.74% <0.00%> (+0.50%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14f608...28dd45a. Read the comment docs.


.addDecorator is probably not working

I'm using material-ui in my project for some of the components. The components that are not affected by material-ui and don't need muiTheme pass the tests. But the other components that need muiTheme provided by context, are failing with a warning Warning: Failed context type: The context `muiTheme` is marked as required in `CircularProgress`, but its value is `undefined`.
Keep in mind that the stories in storybook are fine because I'm providing muiTheme through a decorator like this in my global .storybook/config.js file:
addDecorator(story => wrapWithStyles(story()));
addDecorator(story => wrapWithMui(story()));

@roonyh what do you think about this issue?

@kitze I am taking a look. addDecorator works with simple wrappers but I guess something does not work with context. Have you used storyshots 2.x versions successfully with your stories?

I'm running into the same issue. I have a  component I specifically created for testing. I can use a global addDecorator and it works fine with storybooks. Then when I run storyshot via jest it fails trying to find functions that should have been injected via context.
If I use addDecorator on a per story level it works fine in both storybooks and storyshots.
Similarly if I just wrap each story directly in the  component that also works fine for both storybook and storyshots.

I have this issue too with storyshots 3.2.2.


JOSS review issues

This is part of the review for JOSS at https://github.com/openjournals/joss-reviews/issues/4459 .
The main source of examples for the package is this repository. The repository has a large number of really useful examples. However, there are also some issues which I have listed together below:

There is no explanation for the inexperienced user on how to use these examples. There are dependencies which are not listed such as matplotlib, plotly and ipyml
In general, the notebooks lack documentation of what exactly is done in it. This needs to be added for the notebooks to be useful.
In 00_Grid/Grid.ipynb :---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [4], in <cell line: 15>()
    27 grid.initialize()
    29 #Kohn Sham object
---> 30 KS = Kohnsham(grid, Za, Zb, pol, Nmo, N, optKS)
    31 KS.scf(optKS)
    33 energy.append(KS.E.E)

File ~/miniconda3/envs/t2a/lib/python3.8/site-packages/CADMium/kohnsham/kohnsham.py:54, in Kohnsham.__init__(self, grid, Za, Zb, pol, Nmo, N, optKS)
    52 for i in optKS.keys():
    53     if i not in KohnShamOptions().dict().keys():
---> 54         raise ValueError(f"{i} is not a valid option for KohnSham")
    55 optKS = KohnShamOptions(**optKS)
    57 #Options

ValueError: verbose is not a valid option for KohnSham

In 03_Inversion/Orbital_Bebe.ipynb:An exception has occurred, use %tb to see the full traceback.

SystemExit: Too many inversion failures. Stopping
/home/sarath/miniconda3/envs/t2a/lib/python3.8/site-packages/IPython/core/interactiveshell.py:3406: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
 warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)

Hello Sarath,
I have added a bit of information for each set of examples. They should provide some guidelines for inexperienced users. In general, I added each of the examples to the documentation. This redundancy should provide the same information no matter what source of information the user is using.
I fixed the dependencies, making only matplotlib the only library used for plotting. This statement is now clearly specified in the README; thus, users should be aware of its need.
Lastly, I fixed the notebooks with errors or other unnecessary cells.

Everything looks good to me, thanks @VHchavez


Manually bind PickerAndroid instance methods

In the current version of react-native, the Picker component would some times fail on Android due undefined context (this === undefined) in the methods that are defined using the experimental class property syntax.
As this is experimental syntax which seems to be unreliable in its current form and usage, I suggest to manually bind these methods in the component's constructor.

By analyzing the blame information on this pull request, we identified @spicyj and @mkonicek to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@dzautner updated the pull request - view changes

@dzautner updated the pull request - view changes

As this is experimental syntax which seems to be unreliable in its current form and usage, I suggest to manually bind these methods in the component's constructor.

We're using this syntax a lot and it should be reliable thanks to Babel. It looks like the code is equivalent actually. Can you consistently reproduce the bug with this being undefined? When does it happen? Does the bug go away with your change?

@mkonicek, sorry for not providing enough information.
Yes, we can consistently reproduce the issue with this specific component. We actually use this exact code to resolve the issue temporarily until it is resolved upstream.

@dzautner updated the pull request - view changes

Can you please determine why the current code is breaking?

I'll try to run some tests and narrow it down to the exact cause of the issue.

@spicyj:
I narrowed the issue down to an issue with babel the is already acknowledged. When using babel with passPerPreset the class property syntax will not be bound to the correct context.
https://github.com/babel/babel/issues/4230
https://github.com/babel/babel/issues/4337

Yeah, that's unfortunate. If you have transform-class-properties in the plugins section then it will work.

👍  thanks!


Import can fail leaving huge files on disk

We've seen imports failing relatively quickly but leaving huge files on disk. This case requires manual intervention to fix.

Will reopen if needed cause I don't know how to reproduce it :-O


Add Patient Information to Pregnancy edit form

-Added links to left hand side
-Added patient information
still need to:
-add special circumstances checkbox
-style/format form to use bootstrap grid columns better

Looks good on first pass! Will take an in-depth look tonight, but can tell you that any suggested changes will wind up being pretty marginal stuff.

Thanks a ton for your hard work on this, as always!

Looks like this takes care of the bulk of #93, #94, and #95, yeah? We'll still need to arrange, extract into partials, set up toggling, and make the update route work. (And tests!)

I'm going to leave those three issues open until they're in their own partials, but this will make it pretty trivial.
Thanks a ton for tackling this @charleshuang80 !

Yeah, I think that it has most of those partials tickets covered, but not all is completed yet. A few thoughts:

There are definitely still parts that are missing from each of those sections. (There are also sections missing according to the wireframes (many fewer fields so likely easier)
None of the fields have actually been hooked into the update method for the controller yet. I would be wary of breaking them up into the partials until that has been completed and we know it works. And then it would require some care to make sure the right locals are passed in but shouldn't be too difficult.
They are thus far one giant form. If we are breaking up the view into partials, we might want to think through if it's possible to break it into smaller forms.
Unless/until the partials will be used in other places, I'm not sure I see the value of breaking up the view/form. But that's just my opinion, it's likely you have a bigger picture view of how it'll be useful.

Going down the line:

Copy that. I think you're right to flag this. My thinking is that we can get it pretty close but it will wind up being a matter for @lwaldsc and @NerdyGirl537 to figure out and get exactly right.
I hear you on the update method not being hooked up yet, and on the merit of taking this slow. If worse comes to worse we can develop it as a monolith and then break into partials as an enhancement. But I'd like to wind up with partials for sure.
I think you're right to flag that there are parts of this we can separate from general information (notes, for example, might be a great candidate for this). But let's see how it shakes out first and make a decision on that down the road.
My reasoning for wanting to break them up is ease in finding what to edit and keeping filesize down -- there's going to be a lot going on in the views, and there's going to be enough tweaking and editing that we want to keep things as simple as possible. KISS is my guiding principle here, followed closely by single responsibility.


Enums should not be fetched twice

Enums are considered scalars by the client (and thus fetched by default), but nexus-prisma considers them as relations and fetch them separately.
This should be fixed in shouldRelyOnDefaultResolvers()

Fixed and will be released under the next version of nexus-prisma


[WIP] iOS border updates: BorderEdges, BorderThickness, BorderDrawingStyle.

Here are some iOS updates that are still a WIP (but pretty close). If you run the app and look at the bordered pancakes, you'll see that each edge is drawn separately and leaves room for the corner arcs. I'm struggling to get the math perfect for filling in the arcs. Have a a look at the top-left and top-right corners. They are almost working but that's not good enough of course. I'm having another look now but decided to submit this PR in case someone wants to help.
Updates are for the following:

BorderThickness is now of type Thickness so now each side can be of a specified thickness (I wanted this so when they're stacked vertically with no margin so they don't double up).

BorderEdges can be specified. This could be useful for maybe two-tone info or warning pancakes that just have a thick inside left border. It's an enum (Left, Right, Top, Bottom, All).

BorderDrawingStyle now works by drawing the borders inside, outside, or centred. Previously they were drawn centred as that is the default for UIBezierPath. This was causing the borders to be clipped for me when stacking pancakes.

If we can figure out the corner fills, then iOS can be finished pretty quickly. Android would need to be updated as well but should be easier to copy from iOS.

I've taken a look at this, but definitely not a deep dive. That's why I also don't really have a lot of comments about it yet. I've also been a bit pre-occupied with some tweaks of my own in the vnext branch.

No problem. I haven't looked at it again as I was a bit road blocked. Hoping a fresh pair of eyes might spot the issue and then I could fill in the rest (it's a geometry issue with filling in the corners).
Some helpful notes:

Follow the logic path that draws the top-left corner.

I realized how I can simplify this to get it to work and I may have time this weekend.

That would be awesome! Also, not to pressure you or anything but I'm slowly contemplating restructuring this code at some point, as described in #93. Let's get it working first though, can always restructure after :D

@sthewissen I just started a new contract last week and I've had nothing left in the tank after working overtime. My thoughts are that supporting everything simultaneously is difficult. I nearly had it but couldn't get the corners filled in perfectly for some reason. If that can be debugged then it's good, but I was banging my head against the wall with it. Supporting BorderEdges and individual BorderThickness with inside/outside BorderDrawingStyle can be easily done without rounded corners. For example, a thick left bar and then rounded corners on the top/bottom right is np.
I would say go ahead and restructure your code in #93. You could easily just cherry pick my code in here for the individual border edges and inside / outside borders. Just separate that from the rounded corners code.

@winnicki
Let me at the very least say that I really appreciate your effort and interest in this. Even though this PR being open for months might not particularly show that. I had great plans towards v2.0 to include it but similar things like what you described have kept me from putting this in. Not enough gas left in the tank after work and other side projects :(


Unit testing

Pull request checklist

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

What is the new behavior?

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

changes are stale. Not required. closing the PR


add repack command to follow deletions/copies from another repo

added in copy branch

added in copy branch


Restore tgenv list-remote output order to desc

Why? 🤔
I broke this in https://github.com/tgenv/tgenv/pull/2. Original behaviour was to list versions in desc order as per the README. PR#2 inadvertently reversed that to ascending order. That also broke tgenv install when used with latest keyword.
Expected Behaviour
% tgenv list-remote
0.42.5
0.42.4
0.42.3
0.42.2
0.42.1
0.42.0
0.41.0
0.40.2
0.40.1
0.40.0
0.39.2
0.39.1
0.39.0

➜  .tgenv git:(main) ✗ tgenv install latest
[INFO] Installing Terragrunt v0.42.5
[INFO] Downloading release tarball from https://github.com/gruntwork-io/terragrunt/releases/download/v0.42.5/terragrunt_darwin_amd64
########################################################################################################################################################################################################### 100.0%
[INFO] Installation of terragrunt v0.42.5 successful
[INFO] Switching to v0.42.5
[INFO] Switching completed

Actual Behaviour
➜  .tgenv git:(main) ✗ tgenv list-remote
0.0.1
0.0.2
0.0.3
0.0.4
0.0.5
0.0.6
0.0.7
0.0.8
0.0.9

➜  .tgenv git:(main) ✗ tgenv install latest
[INFO] Installing Terragrunt v0.0.1
[INFO] Downloading release tarball from https://github.com/gruntwork-io/terragrunt/releases/download/v0.0.1/terragrunt_darwin_amd64
curl: (22) The requested URL returned error: 404

tgenv: tgenv-install: [ERROR] Tarball download failed

What? :hammer_and_wrench:
This change restores tgenv list-remote to listing versions in descending order.
Additional Links 🌐

https://github.com/tgenv/tgenv/pull/2

LGTM ✅


text in charlists is not replace

The erlang error logger gives us the text as a charlist so my regex is  not correctly applied to it
in this example the elixir Logger correctly redacts the password but the error loggers output is not redacted
iex(1)> require Logger; Logger.error "password: "secret""
14:09:55.353 [error] password: [REDACTED]
iex(2)> :error_logger.error_msg "password: "secret""
14:10:13.134 [error] password: "secret"
i've fixed this as part of PR #11
dan

Closed via #11


bump 1.2.0

https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
Wow, this is a very recent update.

OpenSSL and rdkafka is really a nightmare...

OpenSSL and rdkafka is really a nightmare...

I think this isn't their fault. More probably apple's. 🤡

Because of this?

(x86, failed to build cxx) There's no "-std=c++11" here 🤔

OpenSSL and rdkafka is really a nightmare...

I think this isn't their fault. More probably apple's. 🤡

Or homebrew's 🤡

https://github.com/Homebrew/brew/issues/7248 This looks very similar

because compiling #include <stdlib.h> produces many warnings.

PostgreSQL's configure script adds Xcode SDK root -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include
Xcode SDK root is printed by xml2-config --cflags, which runs xcrun --show-sdk-path
Homebrew adds CLT SDK root -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk

https://github.com/Homebrew/homebrew-core/pull/51949#issuecomment-601943075
This sounds exactly the root of the problem

You might have issues if is CMake build is not set up to use std_cmake_args.
CMake is somewhat an unique build tool when it comes to the macOS SDK. In particular, if CMAKE_OSX_SYSROOT is not set then CMake makes its own choice of a SDK to use rather than rely on the compiler to handle it (which Homebrew shims). This can generally lead to bad things as Homebrew will still try to use its SDK choice through the compiler shims which means there is now a couple of different SDKs in the include path, and the ordering is likely all wrong too.
If passing std_cmake_args is not possible for some reason, then you can try just -DCMAKE_OSX_SYSROOT, or perhaps setting the SDKROOT env. If the bootstrap doesn’t cope well with either (which would warrant a bug report IMO) then unsetting HOMEBREW_SDKROOT should be safe to do here. It wouldn’t be for something like Python which has a python3_config binary.

 I'm okay with that though. 🤣


[Issue #332] Refactor test cases in comparable matcher test

This PR refactors the test cases in comparable matcher tests to use the relation manager layer, as it's part of the plan stated in Issue #332 .

LGTM.


Task - Refactor Formik forms in JPB

Resolves #2856
Notes:

Fixed all breaking changes. Switch Field to FastField component to appropriate fields.
Renamed some of the files to be consistent (eg. Job{step}.tsx, Job{step}Page.tsx).
Fixed issue on Work Environment step focusing on error for RadioGroup components.

I tested this in IE, because that's where I've noticed form performance issues (especially on the JPB Work Env page). Unfortunatly, I'm getting a js error that stops the page from running in IE. Its a promise.finally TypeError, which is odd, since core-js polyfills should allow promises to work in IE. I confirmed that dev still works locally for me in IE.
So please test this in IE, and if it also doesn't work for you, try to investigate the issue. If if works for you, there might be an issue with my environment. I couldn't find any errors in the code.

F*%$. We were getting this error before but I was able to resolve it by adding the module directly into RootContainter.tsx... I'll try to find what change is causing it to break.

Works in IE now. Its good having formik updated, but unfortunately the JPB pages are still slow. We'll have to look into them further.


avoid hang in stringValue

I could never induce splitObjects to call children, even following the steps in #2242, but the potential for an infinite loop was undeniable. Good catch, @pjrobertson!
This should prevent such a loop. The second commit may or may not help as well, but at worst, it makes things more efficient.

I like the 2nd commit, even though it is probably still a bit hacky. Since what you said about us storing identifiers for text objects is no longer the case, can it not just be removed in its entirety?
It seems a bit 'black magic' to me!

Since what you said about us storing identifiers for text objects is no longer the case, can it not just be removed in its entirety?

I found the reason for that code. See #1858. Sounds like the identifiers were getting stored as text, but they referred to more complicated objects. Makes more sense than text objects with identifiers surviving in someone’s indexes all this time. I’m still not sure if it’s safe to remove, though. I can look deeper tomorrow with fresh eyes.

OK I pushed a small change to add a comment to your change. I'm happy with this as is (even if it is slightly hacky).
I also added some multiline string tests. Perhaps controversially, the new tests I added fail... because a multiline string of paths (multiple file objects) return 2 Folders in "XXX".
Now the question is: this is the stringValue, but in reality, it's the displayName right? I'd say the string value (useful for pasting etc.) should be the paths split up using \n

Oh, wait... the reason it's failing is because

There are no handlers set for file objects (because QSReg hasn't been populated when the tests run)
Even if the handler were set, because we're not calling [obj splitObjects] anymore (to avoid the crash this PR was fixing) we're getting nil from the cache.

Now we have the eternal dilemma of tests failing because they don't represent the real world... because the real world is way too complicated!

OK, let's try and get this merged so we're not sidetracked and discussing something else for ever! I've commented out the problematic unit tests, to be revised at a later date

OK, let's try and get this merged so we're not sidetracked and discussing something else for ever! I've commented out the problematic unit tests, to be revised at a later date

Yes, thank you!


adding font

is this the right way to add a font into Osiris?
gui.cpp = https://imgur.com/a/D1vm6iT
gui.h = https://imgur.com/a/ZymntUH

yes


Added projectile over an attack linked to Barrage Support

Hello,
I started using PoB only recently and while messing around with it I think I discovered an error.
When supporting a skill with Barrage Support, in my case Power Siphon but it might be irrelevant, added projectiles on the same target are not calculated in Average Damage or Total DPS.
When ticking Dying Sun (potion that adds 2 projectile) or equipping the same helmet I have but with "Power siphon fires 2 additional projectiles" enchant from the lab I can observe no changes at all on any of those two values.
I do understand that it does not apply to other spells as only 1 projectile for each spell can hit the target (I think), but it should not be the case with skills supported by Barrage Support if I understand it correctly.

Could you paste your build pastebin?
Two possible causes off the top of my head:

Imported skills will mistake Barrage Support for Barrage (the skill).  Check you still tab actually has Barrage Support listed.
If you are using Vaal Power Siphon in you build, make sure that (non-Vaal) Power Siphon is selected in the skill sidebar.  VPS does not have any DPS benefit from multiple projectiles, while PS does.

Thanks for your answer! As you asked here is my pastbin for this build https://pastebin.com/KLx5HeT6

Imported skills will mistake Barrage Support for Barrage (the skill). Check you still tab actually has Barrage Support listed.

 Barrage still seems to not import properly despise the patch note for 1.4.169.
And I can't find Barrage Support in the list of gems that's prompted while creating a link.
One of the two Barrage named gems in PoB actually impact my damage a lot but I end up with Power Siphon, Barrage under Main Skill with Barrage added as an Active Skill. I don't know if that's the intended result.
With the (maybe?) right gem in place by switching my helmets with and without enchant of projectiles I can't notice any changes on Average Damage or on Total DPS.

If you are using Vaal Power Siphon in you build, make sure that (non-Vaal) Power Siphon is selected in the skill sidebar. VPS does not have any DPS benefit from multiple projectiles, while PS does.

I though about it while experimenting and even changed the gem with a Power Siphon by hand just to check. Nothing changed.

The quickest solution after importing is to delete Barrage (the skill) from your socket group and then manually re-entering Barrage Support.
In any case, I noticed you had duplicate Power Siphon socket groups so I deleted the bottom one.  The following should show the proper sensitivity to Dying Sun.
https://pastebin.com/3cbxnq4A

I've removed all my gems and items, re-imported them from an empty list and PoB did setup Barrage correctly this time around as you said.
When activating Dying Sun I can see an increase on the AoE Radius of Kinetic Blast (15->17). But since Power Siphon is supported by Barrage Support it has no AoE Radius and the added projectiles should increase the Average Damage and/or Total DPS since I'm now firing 16 projectiles instead of 14 in one Power Siphon.
By ticking/un-ticking Dying Sun with the Do you have a flask active? ticked (to eliminate my Pathfinder attributes from false positives while having an active potion) I observe no changes in any of those values.
Here is the pastbin of the build I used.
https://pastebin.com/WyBkktzU


fixtures customization

Need ability to pass additional params to fixtures, or edit them
For example I need more then fixtures have roles.
My User accounts have required fields, that not described in fixtures/user.
Thanks for this repo!

I agree, the fixture data should be over-writable from configs.


Add basic support for running api-documenter.

This change adds a npm script to generate markdown documentation
using api-documenter. The documentation is generated using the command:
    yarn docs

After the command yarn docs terminates the directory
markdown containing the documentation will be created.

Codecov Report

Merging #1579 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1579   +/-   ##
=======================================
  Coverage   60.75%   60.75%
=======================================
  Files         271      271
  Lines       24555    24555
  Branches     5514     5514
=======================================
  Hits        14918    14918
  Misses       9637     9637

Impacted Files
Coverage Δ

@here/harp-geoutils/lib/projection/Projection.ts
95.83% <ø> (ø)

@here/harp-mapview-decoder/lib/TileDataSource.ts
71.87% <100.00%> (ø)

...apview/lib/copyrights/CopyrightCoverageProvider.ts
86.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901b248...2411f8e. Read the comment docs.


Ignoring exception in command warning_count error: NoneType: None

If the command error handler cog doesn't catch the error this is all it sais (sometimes, not in all cases) .
I do not know why it does not show the entire traceback.

Not noticed lately so closing.


feat: opt-out keymaps of sync_registers before pasting

After recent refactoring of which-key.nvim 3.x, the which-key.nvim integration provided at https://github.com/aserowy/tmux.nvim/issues/88#issuecomment-1426864257 is no longer applicable due to a bugfix.
Fortunately, folke provided a much easier approach at https://github.com/folke/which-key.nvim/issues/743#issuecomment-2234460129 that does not require messing with keymaps. This PR opt-out the keymaps to avoid overriding which-key popup.

Can you please review the failing test?
Kind regards
Alexander

test should pass now. I also split put and choose register into two different config options


Use javascipt prototype

Why do not use Tablist.prototype for define member function?
By exemple:
Tablist.prototype.firstActiveTab = function firstActiveTab() {…}

This is just how we’re used to code our JavaScript. We got the habit of it and didn’t think of changing our coding style for this plugin.

Prototype-oriented programmation is not a code style.

Thanks for your input. Prototype-oriented programming is one side of object creation, this & bind is another way to achieve the same goal (creating an object). Yes, it means that every instance will load the methods but web browsers are intelligent enough to optimize the duplicated methods.
As for overriding methods, the user can override the exposed methods. We don't want the core methods to be overridden as it could prevent the library to work as expected accessibility-wise.
We choose this notation for our scripts but remember, when it comes to object creation there's

😄

I'd be curious to see a Prototyped way though, maybe you guys @borisschapira and @ryuran can fork the project and transpose it?

You can as well use this and bind if you use prototype.


Design analysis of BeforeSend hook implementation in x/TokenFactory

During the audit of the possible BeforeSend hook impact, the Implementation of the hook is analyzed for issues and improvements.
Artifact:

Full Token Factory branch holding new features

Context in which audit took place
TokenFactory BeforeSend hook implementation facts:

hook implementation should call the sudo execution of the BeforeSend entry point FOR EACH token factory denom being sent
cosmwasm smart contract is registered as a hook for a specific token factory created denom
the smart contract should implement sudo BeforeSend mesage entry point - this expectation will be proposed as a change in cw20 standard

Expectations:

execution of the smart contract's BeforeSend msg will return an error upon some criteria and freeze the sending of a certain type of token factory denom
the smart contract should work only with the minimum set of the data

Analysis Summary:
The current design for SudoMsg BeforeSend, from a smart contract example:
pub enum SudoMsg {
    BeforeSend {
        from: String,
        to: String,
        amount: Vec<Coin>,
    },
}

Sudo execution from BeforeSend hook implementation is called per token factory denom.
https://github.com/osmosis-labs/osmosis/blob/f09305e60b5b23fec761ea14446ee33556313e69/x/tokenfactory/keeper/beforesend.go#L82-L85
.
https://github.com/osmosis-labs/osmosis/blob/f09305e60b5b23fec761ea14446ee33556313e69/x/tokenfactory/keeper/beforesend.go#L105
while types.SudoMsg creation:
https://github.com/osmosis-labs/osmosis/blob/f09305e60b5b23fec761ea14446ee33556313e69/x/tokenfactory/keeper/beforesend.go#L90-L96
contains all the coin info being sent.
Suggestion:
Change the BeforeSend Msg to contain only wasmvmtypes.Coin info, created with:
https://github.com/osmosis-labs/osmosis/blob/f09305e60b5b23fec761ea14446ee33556313e69/x/tokenfactory/keeper/beforesend.go#L58
and propose the cw20 standard change accordingly:
pub enum SudoMsg {
    BeforeSend {
        from: String,
        to: String,
        amount: Coin,
    },
}

Tagging audit collaboration team, to review issues as agreed. @ValarDragon @sunnya97


Felix's Attempt at completing the Beginning Git Course

Hello,
This PR represents all the work I did to complete the course.
Felix

Hey @linfelix167—congrats on submitting a PR at the end of the git course. I hope you enjoyed working through the course, and that you learnt some new tips and tricks for using git.
If you weren't already using git for your code, hopefully this has inspired you to do so. I hope that you enjoy the "Mastering Git" video course as well—you'll soon be able to get git to bend to your will :)
You can now wear this #GitWarrior badge with pride—and Tweet your historic victory!

sam


Log backups are not working for availability groups with backup preference set to 'Prefer Secondary'

Description of the issue
The log backups are not being taken for the databases which are in availability groups with backup preference set to "Prefer Secondary"
SQL Server version and edition
Microsoft SQL Server 2022 (RTM-CU8) (KB5029666) - 16.0.4075.1 (X64)   Aug 23 2023 14:04:50   Copyright (C) 2022 Microsoft Corporation  Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2022 Standard 10.0  (Build 20348: ) (Hypervisor)
Version of the script
2022-12-03 17:23:44
What command are you executing?
EXECUTE [dbo].[DatabaseBackup] @Databases = 'USER_DATABASES', @Directory = NULL, @BackupType = 'LOG', @Verify = 'Y', @CleanupTime = 72, @CheckSum = 'Y', @LogToTable = 'Y'
What output are you getting?
The log backups are not being taken at all. The backup script is executing on primary. The full and diff backups are running on the primary but those backups are working only 'LOG' backups are not working. The other databases which are not in the availability group are working fine.
I suspect something wrong in the following code block (on line 2809)
IF @CurrentDatabaseState = 'ONLINE'
AND NOT (@CurrentUserAccess = 'SINGLE_USER' AND @CurrentIsDatabaseAccessible = 0)
AND NOT (@CurrentInStandby = 1)
AND NOT (@CurrentBackupType = 'LOG' AND @CurrentRecoveryModel = 'SIMPLE')
AND NOT (@CurrentBackupType = 'LOG' AND @CurrentRecoveryModel IN('FULL','BULK_LOGGED') AND @CurrentLogLSN IS NULL)
AND NOT (@CurrentBackupType = 'DIFF' AND @CurrentDifferentialBaseLSN IS NULL)
AND NOT (@CurrentBackupType IN('DIFF','LOG') AND @CurrentDatabaseName = 'master')
AND NOT (@CurrentAvailabilityGroup IS NOT NULL AND @CurrentBackupType = 'FULL' AND @CopyOnly = 'N' AND (@CurrentAvailabilityGroupRole <> 'PRIMARY' OR @CurrentAvailabilityGroupRole IS NULL))
AND NOT (@CurrentAvailabilityGroup IS NOT NULL AND @CurrentBackupType = 'FULL' AND @CopyOnly = 'Y' AND (@CurrentIsPreferredBackupReplica <> 1 OR @CurrentIsPreferredBackupReplica IS NULL) AND @OverrideBackupPreference = 'N')
AND NOT (@CurrentAvailabilityGroup IS NOT NULL AND @CurrentBackupType = 'DIFF' AND (@CurrentAvailabilityGroupRole <> 'PRIMARY' OR @CurrentAvailabilityGroupRole IS NULL))
AND NOT (@CurrentAvailabilityGroup IS NOT NULL AND @CurrentBackupType = 'LOG' AND @CopyOnly = 'N' AND (@CurrentIsPreferredBackupReplica <> 1 OR @CurrentIsPreferredBackupReplica IS NULL) AND @OverrideBackupPreference = 'N')
AND NOT (@CurrentAvailabilityGroup IS NOT NULL AND @CurrentBackupType = 'LOG' AND @CopyOnly = 'Y' AND (@CurrentAvailabilityGroupRole <> 'PRIMARY' OR @CurrentAvailabilityGroupRole IS NULL))
AND NOT ((@CurrentLogShippingRole = 'PRIMARY' AND @CurrentLogShippingRole IS NOT NULL) AND @CurrentBackupType = 'LOG' AND @ExcludeLogShippedFromLogBackup = 'Y')
AND NOT (@CurrentIsReadOnly = 1 AND @Updateability = 'READ_WRITE')
AND NOT (@CurrentIsReadOnly = 0 AND @Updateability = 'READ_ONLY')
AND NOT (@CurrentBackupType = 'LOG' AND @LogSizeSinceLastLogBackup IS NOT NULL AND @TimeSinceLastLogBackup IS NOT NULL AND NOT(@CurrentLogSizeSinceLastLogBackup >= @LogSizeSinceLastLogBackup OR @CurrentLogSizeSinceLastLogBackup IS NULL OR DATEDIFF(SECOND,@CurrentLastLogBackup,SYSDATETIME()) >= @TimeSinceLastLogBackup OR @CurrentLastLogBackup IS NULL))
AND NOT (@CurrentBackupType = 'LOG' AND @Updateability = 'READ_ONLY' AND @BackupSoftware = 'DATA_DOMAIN_BOOST')

" The full and diff backups are running on the primary but those backups are working only 'LOG' backups are not working."
Hi Mitesh checking are you running the backup on the primary or secondary replica?

refer to https://ola.hallengren.com/frequently-asked-questions.html
How should I configure DatabaseBackup to back up an Availability Group?
First you need to decide where you want the backups to be performed; on the primary replica or on the secondary replica. SQL Server has an option called backup preference that you can set on the availability group. By default it is set to Prefer Secondary, but you can change it to Primary if you prefer that.
Not all backup types are supported on the secondary replica. Here are the backup types that are supported:
Copy-only full backups
Log backups (non copy-only)
DatabaseBackup will perform these types of backups on the preferred backup replica. It is using the function sys.fn_hadr_backup_is_preferred_replica to determine if the current replica is the preferred replica.
Full backups (non copy-only) and differential backups are only supported on the primary replica. DatabaseBackup will always perform these types of backups on the primary replica.
Here are some different backup strategies that you can use:
Perform all the backups on the primary replica. With this strategy it works just like with any database. You can perform full (non copy-only), differential, and log backups. All you need to do is to set the backup preference to Primary for the availability group.
Perform all the backups on the secondary replica. With this strategy you can only perform copy-only full, and log backups (non copy-only). You need to check that the backup preference is set to Prefer Secondary for the availability group. You also need to add @CopyOnly = 'Y' to the full backup jobs, and disable the differential backup jobs.
Perform full (non copy-only) and differential backups on the primary replica, and log backups on the secondary replica. You need to check that the backup preference is set to Prefer Secondary for the availability group. You don't need to add any additional parameters to the full, differential, or log backup jobs.
The jobs should be configured identically and be enabled and scheduled on all the replicas.

I have a similar experience.
using SQL 2019, standard edition, which only allows backups to be done on the primary.
With standard edition:
ALTER AVAILABILITY GROUP FooAG SET (AUTOMATED_BACKUP_PREFERENCE = PRIMARY)
"The specified command is invalid because the Always On Availability Groups backup preference feature is not supported by this edition of SQL Server."

full and different backups run fine (on the primary)
LOG: AGs are ignored, except the first (which contains the listener). There are three AGs.

Step: DatabaseBackup - USER_DATABASES - LOG
EXECUTE [dbo].[DatabaseBackup]
@Databases = 'USER_DATABASES',
@Directory = NULL,
@BackupType = 'LOG',
@Verify = 'Y',
@CleanupTime = NULL,
@CheckSum = 'Y',
@LogToTable = 'Y'
Also tried
@AvailabilityGroups='ALL_AVAILABILITY_GROUPS'
In the commandLog table I only even see just one AG.

To answer my own question, the reason was not to do with AGs, but the fact that LogShipping was also enabled on some DBs.
By setting @ExcludeLogShippedFromLogBackup='N' , this is now a LOPG backup (in addition to log shipping, which is also a redundant backuip of transactions)

Description of the issue The log backups are not being taken for the databases which are in availability groups with backup preference set to "Prefer Secondary"

What output are you getting? The log backups are not being taken at all. The backup script is executing on primary. The full and diff backups are running on the primary but those backups are working only 'LOG' backups are not working. The other databases which are not in the availability group are working fine. I suspect something wrong in the following code block (on line 2809)

You should run the backup jobs on all replicas (primary and secondary). The log backups would be performed by the log backup job on the secondary replica.


Set background color with foreground color in ConsoleLogger

#378

:shipit:

Screenshot on osx? :smile:

@davidfowl it looks like a clown ate a unicorn :smile:

Is it going to put a black background on my white console with white text?

It's going to use your default colors for everything except the log level text, logger name, and eventid
Sent from my HTC
----- Reply message -----
From: "David Fowler"<EMAIL_ADDRESS>To: "aspnet/Logging"<EMAIL_ADDRESS>Cc: "Brennan Conroy"<EMAIL_ADDRESS>Subject: [Logging] Set background color with foreground color in ConsoleLogger (#386)
Date: Sun, Mar 13, 2016 8:38 PM
Is it going to put a black background on my white console with white text?

Reply to this email directly or view it on GitHubhttps://github.com/aspnet/Logging/pull/386#issuecomment-196122711.

Yeah the colorization is only for the "header" of each log entry, for which we explicitly set both background and foreground color (to ensure good contrast). Then the log details are in whatever color you had in your console.


[Create New Issue]: tollbooth program

Description
tollbooth program in cpp
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

I am working on this issue.

/assign


error when trying to connect to the api

ERROR -1 502 Couldn't connect to TWS. Confirm that "Enable ActiveX and Socket EClients"
is enabled and connection port is the same as "Socket Port" on the
TWS "Edit->Global Configuration...->API->Settings" menu. Live Trading ports:
TWS: 7496; IB Gateway: 4001. Simulated Trading ports for new installations
of version 954.1 or newer:  TWS: 7497; IB Gateway: 4002

using this code:
from ibapi.client import EClient
from ibapi.wrapper import EWrapper
class IBapi(EWrapper, EClient):
     def __init__(self):
         EClient.__init__(self, self)

app = IBapi()
app.connect('<IP_ADDRESS>', 4002,123)
app.run()

tried all 4 ports with no luck...

@eladnm did you ever figure this out?

Having this issue too ....

Make sure you have "Enable ActiveX and Socket EClients" enabled in your settings. If you download and use VNCviewer you should be able to inspect the application and go to settings and see if both "Enable ActiveX and Socket EClients" are enabled.


⚠ Bofrost.fr has degraded performance

In b44d8ab, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1375 ms

Resolved: Bofrost.fr performance has improved in a5a0a96 after 10 minutes.


fix: server-side rendering issue after<EMAIL_ADDRESS>

fix https://github.com/thematters/matters-web/issues/2590

The SSR did not work starts from https://github.com/thematters/matters-web/commit/fd6cd7daa6a74bd85f4da1012e6e3dfd7deec236 , even downgrade to 12.1.5 and 12.1.6, the SSR still don't work. But 12.1.6-canary.3 works. See also: https://github.com/vercel/next.js/issues/36198

it seems failed the EB deployment at https://web-develop.matters.news/


Android audiotrack deprecated with no replacement.

AudioTrack class has been deprecated by google, yet it is still referenced in you documents as the way to do audio on android. IT DOES NOT WORK ON ANDROID R. Will cause apps to crash with out any warning. Will not even tell the debugger what the problem is. It just crashes and burns. What am I supposed to use instead.

I just created the issue. How can I get a comment thats 7 hours old?


No such file

I get "No such file" error when trying to run Hand Writing Recognition

I have modified the code to ignore deleted paged when running Hand Writing Recognition. This should solve your problem.
Can you access the latest build artifacts and test the Hand Writing Recognition, please?
https://github.com/ds160/remarkable-remember/actions/runs/7894671745
Thank you

Issue is not with deleted pages. Issue with this code:
String contentFileText = await Task.Run(() => client.ReadAllText(Path.Combine(PATH_NOTEBOOKS, $"{id}.content"))).ConfigureAwait(false);
The Path.Combine function combines the two srings with two forward slashes //
eg:
/home/root/.local/share/remarkable/xochitl\38e089ed-277e-4448-8f84-533cece6beb1.content
That's why file is not being found...

I have modified the code. Could you test the Hand Writing Recognition again, please?

I get this error now after clicking Hand Writing Recognition button. I have already setup the MyScript Application and HMAC keys.

Status code 413 (RequestEntityTooLarge) indicates that the server (MyScript) cannot handle the content of a page. Can you try a different document or split the content of the page in multiple pages, please?


allow PHPUnit 9

Hi! PHPUnit 9 has just been released and i'd like to update the composer.json to allow it. I already ran the tests successfully on the new PHPUnit version and it looks like there are no further changes required for now.

Thank you for the merge!


Video Generation Agent

Confirm this is a new agent request

[X] I've checked the current issues, and there's no record of this agent request

Describe the agent
Description: Agent to generate video for given prompt and image (optional).
Args:

prompt
image (url)
engine

Possible engines:

Lumalabs
Kling
RunwayML

Additional Context
Test prompts:

Generate a video of will smith eating spaghetti and add Italian background music.

This prompt should create the video with default agent and then generate audio using audio generation agent and finally should overlay with editing agent.

Generate an image of Cyberpunk Robot and make it do floss dance step.

This should generate an image with image generation agent and should pass it to video generation engine.

Closed by https://github.com/video-db/Director/pull/67


Add portfolio cluster configuration

What
The team responsible for Portfolio, may also be onboarding teams onto
GSP. Adding the configuration pre-emptively to initiate this process.
There are no splunk configuration details at current time.
How to review

Sanity check

... Do not deploy/~push pipeline~ ... 🤔

Changed and pipeline applied. Thanks.


Can't overwrite the "created generic title" with a default (or an alternative) value

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
If the title name pattern key is missed, the program created a generic title.
I can't overwrite it with a "Default" value, or with an "Alternative" value.

I want to use an empty string if there is no title, but it — %(title|)s — does not work.
I just see
WARNING: Extractor failed to obtain "title". Creating a generic title instead

And the program uses that created generic title, ignoring my rule.

Since I use such alias in my .bashrc:
alias yt='yt-dlp --write-thumbnail --write-description -o "[%(webpage_url_domain)s] %(uploader)s—%(upload_date>%Y.%m.%d)s—%(id)s—%(title|)s.%(ext)s" '

The generic title just duplicates webpage_url_domain and id values.
The result:

[tiktok.com] marymeeri—2021.09.08—7005467079704956165—TikTok video #7005467079704956165.mp4

The expected result:

[tiktok.com] marymeeri—2021.09.08—7005467079704956165—.mp4

Verbose log
[debug] Command-line config: ['--write-thumbnail', '--write-description', '-o', '[%(webpage_url_domain)s] %(uploader)s—%(upload_date>%Y.%m.%d)s—%(id)s—%(title|)s.%(ext)s', 'https://www.tiktok.com/@marymeeri/video/7005467079704956165', '-vU']
[debug] Encodings: locale cp65001, fs utf-8, out utf-8 (No ANSI), err utf-8 (No ANSI), pref cp65001
[debug] yt-dlp version 2022.02.04 [c1653e9ef]
[debug] Lazy loading extractors is disabled
[debug] Python version 3.9.9 (CPython 64bit) - Windows-10
[debug] exe versions: ffmpeg 4.4-full_build-www.gyan.dev (setts), ffprobe 4.4-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2022.02.04, Current version: 2022.02.04
yt-dlp is up to date (2022.02.04)
[debug] [TikTok] Extracting URL: https://www.tiktok.com/@marymeeri/video/7005467079704956165
...
WARNING: Extractor failed to obtain "title". Creating a generic title instead
...
[info] Writing video description to: [tiktok.com] marymeeri—2021.09.08—7005467079704956165—TikTok video #7005467079704956165.description

Use fulltitle

fulltitle (string): Video title ignoring live timestamp and generic title


Add kyverno 1.4 to matrix

Signed-off-by: vineethvanga18<EMAIL_ADDRESS>Add version 1.4 to compatibility matrix in docs

Kyverno 1.4.0 isn't available yet. This should be held.


Improves - Register (Mask)

Description
News

Phone Mask
CEP Mask
Mask Birth Date
Control of hasErrors
Validate password and confirmPassword

Improves

CEP -> GET info
Validate Email
Validate Phone
Validate CEP

... and more!

I also create a new script "validate-pr". and documented it into this wiki


Size restriction not working on therapy chat.

For me, the chatbox just renders at the far bottom, and then runs over. We should render it further up, and make sure it doesn't grow bigger and bigger.

Resolved


Define new selector for building image job

#140

Codecov Report
Base: 79.21% // Head: 79.24% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (e9b3df8) compared to base (8cadf79).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   79.21%   79.24%   +0.02%
==========================================
  Files          26       26
  Lines        2819     2823       +4
==========================================
+ Hits         2233     2237       +4
  Misses        497      497
  Partials       89       89

Impacted Files
Coverage Δ

internal/build/job/maker.go
90.36% <100.00%> (+0.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/ok-to-test

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kernel-module-management/311/pull-kernel-module-management-check-api-changes/1630142470052384768#1:build-log.txt%3A201

/hold
This change may brake flows for users building for a specific architecture in multi-arch clusters.
Let us consider a cluster with amd64 and arm64 nodes.
Before this change, if you created a Module targeting amd64 nodes, the builds would be automatically scheduled on amd64 nodes.
With this change, the build may run on an arm64 node, which by default will produce a module for arm64, not amd64.
cc @hershpa @yevgeny-shnaidman @ybettan

/hold This change may brake flows for users building for a specific architecture in multi-arch clusters. Let us consider a cluster with amd64 and arm64 nodes. Before this change, if you created a Module targeting amd64 nodes, the builds would be automatically scheduled on amd64 nodes. With this change, the build may run on an arm64 node, which by default will produce a module for arm64, not amd64.
cc @hershpa @yevgeny-shnaidman @ybettan

@qbarrand maybe all we need to add  a label to the Build/Sign job node selector is architecture label. I think that all the nodes are label with it anyways, and it can be derived from the KernelMapping

This change may brake flows for users building for a specific architecture in multi-arch clusters.
Let us consider a cluster with amd64 and arm64 nodes.
Before this change, if you created a Module targeting amd64 nodes, the builds would be automatically scheduled on amd64 nodes.
With this change, the build may run on an arm64 node, which by default will produce a module for arm64, not amd64.

@qbarrand @yevgeny-shnaidman I would instead just ask kaniko to build for a specific arch (regardless of the host) using https://github.com/GoogleContainerTools/kaniko#flag---customplatform.

This change may brake flows for users building for a specific architecture in multi-arch clusters.
Let us consider a cluster with amd64 and arm64 nodes.
Before this change, if you created a Module targeting amd64 nodes, the builds would be automatically scheduled on amd64 nodes.
With this change, the build may run on an arm64 node, which by default will produce a module for arm64, not amd64.

@qbarrand @yevgeny-shnaidman I would instead just ask kaniko to build for a specific arch (regardless of the host) using https://github.com/GoogleContainerTools/kaniko#flag---customplatform.
This will also allow to build for ARM in a x86 cluster or any other combination. This is especially handy in the hub-spoke topology.
This will requires extending the build section in our CRD though.

@ybettan does kaniko support something like that? build Dockerfile will probably include Makefile that needs to know how to cross-compile, not sure if customer will want to support it.

This PR is blocked by https://github.com/kubernetes-sigs/kernel-module-management/issues/325 unless we modify the CRD to contain a nodeSelector for build/sign which is not ideal as we wish not to extend the API unless there is a requirement for it.

we wish not to extend the API unless there is a requirement for it

Sounds like it's the only way to properly address #140 though.

@qbarrand
We have kubernetes.io/arch: amd64 on the nodes, how about we just set the inner selector of the build to match the same arch as of the module's selector node?

As agreed in the community meeting we will proceed with the following:
We add a new selector for build
v1:
If the build selector is not set, we use the selector from the module to maintain the same behavior that we had until now.
v2:
If the build selector is not set, we do not set any selector for the build job and let k8s make the scheduling.

/unhold
/lgtm
/assign @qbarrand @yevgeny-shnaidman

/approve