Docstring cleanup

Looking at the output of our docs, I think we need to go over our docstrings and bring them into proper numpydoc format.
Two main types of changes that I’ve noticed we need to make:

start each docstring with the brief description: aim to keep it on an 80-column terminal
correct listing of types in parameter blocks

We have REALLY bad "brief" docstrings. They aren’t brief. When Sphinx generates tables of classes/functions, it puts the function name on the left, and the brief description on the right. But it forces everything to be on one line. So if the "brief" description is long, you have to scroll horizontally to read it. That’s annoying.
We won’t be able to remove all scrolling on laptops, but we should minimize it. Hence my suggestion of a description that fits on an 80-char width terminal.
I’m currently modifying a number of docstrings to match this behavior as part of my docs_cleanup branch.
Details of numpydoc format

I fully agree, most docstrings are not as they should. Especially the short summary. I will try to be aware of that for further changes. The summary is very good.

While there's always room for improvement, I think this no longer needs to be an open issue. Closing!


Document Selector and filtering by selector

I just realized that it's already quite simple to filter out certain schemas/tables etc. via Selector. I.e.
val selector =
  (Selector.schemas("public") or
  (Selector.schemas("other") and Selector.relationNames("table_a", "table_b", "table_c")))

  generateFromDb(options, selector=selector, scriptsPaths = List(scriptsFolder))
    .overwriteFolder(folder = targetDir)

I think it could be useful to have that in the docs with a few examples. Especially as using this can reduce compile times on dbs with many tables :)

Good point! It used to be required to specify it, so users would have to discover it. It gained a default however, so it should go in the docs.
I suggest a variable with a comment in the script on the getting started page, as well as a comment on the page about compile speed.


Test toggle inlay hints

Refs: https://github.com/microsoft/vscode/issues/128162

[ ] anyOS
[ ] anyOS

Complexity: 2

There is a new settings for toggling inlay hints. Test that

the global view menu has an entry to enable/disable inlay hints
there is a new setting editor.inlayHints.toggle which allows to quick hide/show inlay hints

Just small clarification - it is still expected that holding Ctrl+Alt will still treat them as pressed separately in the same time:

Ctrl - activates "Go To ..." for parts of code
Alt - alters scroll speed

I guess that Ctrl function is still required as Ctrl+Alt+Click has existing behavior, however wasn't expecting to see scroll speed change.


General bugs in .29 alpha, just FYI

Issue Description:
Note: If this bug occurs in a modpack, please report this to the modpack author. Otherwise, delete this line and add your description here. If you are using an unreleased version of Ender IO (e.g. for 1.8.9), please don't open an issue for features that have not been announced as "finished" or "working".
What happens:
Bug reporting for alpha .29 with endercore .21
Dimensional Transceiver does not work with power, does work with items, did not test with liquids,
The dimensional transceiver send/receive buggers do not fill up on the receiving transceiver under any circumstances.
KillerJoe is wacky loud, sound appears broken.  Turning sound off in config does not work on killerjoe but does silence other machines.
attractor obelisk does not seem to work with blazes although I never tested blazes under 1.7.10 so maybe this never worked.
I have tested most of the other basic machines with great success.  Thanks.

Affected Versions (Do not use "latest"):

EnderIO: 1.9.4    .29 alpha
EnderCore:1.9.4   .21
Minecraft: 1.9.4
Forge:<IP_ADDRESS>0

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]

The attractor obelisk needs to be looked at. I like the idea but it is too difficult to get a reliable implementation for all the different mobs.

Fixes are available now in version <IP_ADDRESS>
Thanks for the reports


[feature] Show unicode escaped characters in the renamed - PR included

For hooking reasons I need the unicode characters of the obfuscated names.
Before :

I modified Jadx and now it looks like this :

here is the modification : https://github.com/skylot/jadx/compare/master...RobLinux:jadx:master

@RobLinux Could you please open a PR for your changes? Github should show you a button for opening a PR so that we can easily merge your changes.
BTW: You have committed the changes to your master branch. Based on my Git experience this can cause problems later once your changes has been accepted (or rejected). Usually it is a good idea to create a new branch and then commit your changes to this branch. Otherwise if may get difficult to update your master branch later.


Address errors introduced by the latest version of silicon & Simplify code

With the new version of silicon, verification time has increased significantly. This package used to take 2min40s before and now seems to take around 5min to verify. This is likely aggravated by the removal of some outline blocks. I would argue that this is justifiable given how simpler the code becomes.
I only simplified part of the methods. I believe that we can achieve similar simplifications by redoing the remaining methods but I will not do it atm for the sake of time.

bors r+


Precompiling UndefVarError: UInt256 not defined

I get the following error trying to add and use Polyester v0.3.9 onto a clean environment with Julia 1.6.2.
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::Base.TTY, internal_stdout::Base.TTY, ignore_loaded_modules::Bool)
@ Base ./loading.jl:1385
[3] compilecache(pkg::Base.PkgId, path::String)
@ Base ./loading.jl:1329
[4] _require(pkg::Base.PkgId)
@ Base ./loading.jl:1043
[5] require(uuidkey::Base.PkgId)
@ Base ./loading.jl:936
[6] require(into::Module, mod::Symbol)
@ Base ./loading.jl:923

Out of curiosity, how many cores and threads does your CPU have?
This is obviously a bug. Related issue:
https://github.com/JuliaSIMD/Polyester.jl/issues/22
VectorizationBase shouldn't be returning UInt256 and greater without also defining those types, so that is another bug.
But Polyester should probably use NTuple{N,UInt64} where N is the smallest integer to cover all the threads needed. With UInt128, the assembly contains a loop with cmpxchg16b for atomics, which looks less than ideal, but I should benchmark vs two UInt64 instructions.
I don't need the entire operation to be atomic, so multiple 64 bit operations doesn't have correctness issues.

Running this on 128 cores with 2 threads per core.
I get no problems on my quad-core laptop.

Yeah, just wanted to confirm. I'll see about fixing this soon.
The problem comes up because it wants a mask per thread indicating whether it is being used. With 128 cores and 2 threads per core, that means 256 masks. UInt256 isn't defined here, causing the problem.
Your laptop presumably has <= 128 cores, avoiding the problem.
So the solution is to represent the masks with an NTuple{N,UInt64} when there are more than 64 threads instead of using larger UInt* types.


[WFLY-9099] Ensure an ad-hoc identity is created if a servlet run-as-principal identity doesn’t exist in the security domain

https://issues.jboss.org/browse/WFLY-9099

Retest this please

Retest this please


Use the imperative mood in the subject line

https://chris.beams.io/posts/git-commit/#seven-rules

Thank you!


fix isascii/is_ascii mismatch

Currently, master branch is broken. This PR fixes it.
By #5, isascii function is changed to is_ascii. But caller side is not changed.
I think is_ascii is preferable name than isascii. If you don't think, please modify such way.
I also think it is better that you introduce GitHub Actions which runs pytest.

Thanks for catching that - I'll look at setting up automated testing.

Automated testing is configured now.


Using PPKG with USB 3.2 Gen2 drives

@rbalsleyMSFT , this has appeared to be more of a Microsoft OOBE limitation then a Bug in your code, but it should be noted in the documentation that when using larger drive capacity Flash Drives, 128GB and above, the Windows will not autoload the provisioning package.
I've tested this with a few USB-C or A 3.2 Gen2 drives, which do not come in capacities lower than 128GB. I believe this has to do with the fact that they are now seen as external Hard Disks and not removable storage. Not sure if there is a directory you can place them in or a work around by copying into the FFU at the time of capture.

Perhaps this is something your contacts at Microsoft know about or a feature request can be made to fix, as more Gen2 drives are hitting the market, with PCs also using 10GBs ports now.

Thanks, yeah, this is an issue with external hard disks vs removable media. Unfortunately, there's unlikely any appetite to fix this. Awhile back I did ask if there was a way to stage a PPKG from within PE, but our devs said there wasn't a way to handle that. My goal was to prevent the need to keep the USB drive in the machine any longer than necessary and let the PPKG get invoked as soon as OOBE began.


Performance (wishlist)

Since the readme says "Please reach to us if you have requirements or suggestions for a distributed Azurite implementation or higher performance." here goes ...
My use case is testing a data processing/aggregation/analysis pipeline and I can't do this without using a lot of data locally. I have been able to run locally using the former Azure Storage Emulator which has adequate performance for my task. I have tried switching to Azurite (now it has table support) but I find it grinds to an almost complete halt once there are tens of thousands of messages in queues or rows in tables. It's fine because I can continue using the old emulator for now  (I just downloaded the installer again in case it disappears) but perhaps it will one day not support some key aspect of Azure Storage.
So my wish list:
Simple Windows installer, no dependency on installing node.js or docker.
Uses a database (SQL server for me) for all data and metadata, or has a disk-based storage mechanism with similar performance for multiple thread insertion and deletion of queue messages / table rows / block blobs in large number.
Option to store block blobs in a folder rather than the database to minimise database size, files to be stored individually on disk, replicating folder structure in Azure Storage. Metadata still in database presumably.
Data survives upgrades/reinstallation of Azurite.

@jmelkins : Hi, could I ask if you need the persistence feature while you are running your tests?
I'm currently testing different persistence options and their effects on performance for different scenarios.
We could then expose these more conveniently for different scenarios and usage patterns.
Understanding requirements for higher load scenarios will help me tailor my tests.
Thanks!

Hi, thanks for your reply.
Yes, I need the persistence feature - the first part of my workflow involves downloading data to blobs followed by data extraction into SQL database and Azure tables and I need to avoid re-downloading and extracting the data while I test later stages of the process.
I suspect that the bottleneck in my workflow is table insertions and updates. Initially the process goes quickly, until the tables start filling up. I have two tables and at the point where the process has completely slowed down they have about 120,000 and 100,000 rows in them. The node.js process seems to be maxed out on 1 core usage although disk access seems to be low (just according to task manager).

The default database backing the emulator is LokiJs, which has some options to increase performance.
If you need the data persisted between sessions (that means beyond a test run), then there is a setting which allows us to partition the database, based on collections, which can significantly improve the response times for larger data sizes.
The frequency with which data is written to the backing store can also be modified, as can the indexing options.
Knowing which operations you use most, in which frequency, and how your data is modeled would help improve my test relevancy, as well as the solutions we can present to optimize performance.
Currently I am focusing my efforts on the Table store, but you also mentioned that you noticed reduced performance when the queues were large:

I find it grinds to an almost complete halt once there are tens of thousands of messages in queues or rows in tables.

Here too, it would be good to know the requirements, so that I can create more relevant test profiles.


Test branch5

Can one of the admins approve running tests for this PR?

Can one of the admins approve running tests for this PR?

Can one of the admins approve running tests for this PR?


pure-prompt: 1.17.2 -> 1.17.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/sindresorhus/pure/releases.
meta.description for pure-prompt is: "Pretty, minimal and fast ZSH prompt"
meta.homepage for pure-prompt is: "https://github.com/sindresorhus/pure"
meta.changelog for pure-prompt is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.17.3 with grep in /nix/store/swmj8zicxgyw91wz6s0fc8rmsk1i4467-pure-prompt-1.17.3

found 1.17.3 in filename of file in /nix/store/swmj8zicxgyw91wz6s0fc8rmsk1i4467-pure-prompt-1.17.3

directory tree listing: https://gist.github.com/cfdfc97fd5d7106501edded97e1b237a

du listing: https://gist.github.com/a71863c66702b62f5ae4645b7749e704

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
pure-prompt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/swmj8zicxgyw91wz6s0fc8rmsk1i4467-pure-prompt-1.17.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pure-prompt https://github.com/r-ryantm/nixpkgs/archive/82f88110a7341bc4f1a947504a808337c8a7c76c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/swmj8zicxgyw91wz6s0fc8rmsk1i4467-pure-prompt-1.17.3
ls -la /nix/store/swmj8zicxgyw91wz6s0fc8rmsk1i4467-pure-prompt-1.17.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pure-prompt

Maintainer pings
cc @pacien @pablo1107 for testing.

Result of nixpkgs-review pr 139126 at 82f88110 run on aarch64-linux 1

1 package built successfully:

pure-prompt

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/shells/zsh/pure-prompt/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 139126 run on x86_64-linux 1

1 package built:

pure-prompt


Added real time notification definition for google play

Google supports real-time notification so that developers can check the users' subscription status.
So I added the definition in accordance with the following document.
https://developer.android.com/google/play/billing/realtime_developer_notifications.html#json_specification

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         197    197
=====================================
  Hits          197    197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8266e87...6753b53. Read the comment docs.


Add state for current user

finally got around to pulling this into a separate pr from the login / register pages...
this pr adds a CurrentUserContext to hold the state of the current user. It also adds a PrivateRoute component which redirects people to the login page if they are not logged upon load.

context omg amaze


extend remote read client to support stream type

fixes : #5926
Signed-off-by: YaoZengzeng<EMAIL_ADDRESS>

@bwplotka PTAL:)

@bwplotka PTAL

Ping @bwplotka :)

Hello @YaoZengzeng are you planning to continue this? (:

There is an issue with this.
https://github.com/prometheus/prometheus/issues/6747
https://github.com/prometheus/prometheus/blob/fe76ccbfe3bb2a7549bbb1454c3a51ff4544c6d6/web/web.go#L594
If prometheis server start to use straming remote read, the other instance might never be able to shut down. Let's find an acceptable solution for the first issue.

@roidelapluie Do you mean that this issue should be taken forward only after #6747 is fixed?

That's correct @Sudhar287
But it is as easy as having extra context propagated that can be cancelled before grpcSrv.GracefulStop()  or something

Let's close it as @YaoZengzeng said, @Sudhar287 can continue this. Ref: https://github.com/prometheus/prometheus/issues/5926#issuecomment-609533756
Feel free @Sudhar287 to use @YaoZengzeng commits for a good start :hugs:
I don't think anything is blocked. I don't get @roidelapluie request. We don't even use gRPC here.

I don't think anything is blocked. I don't get @roidelapluie request. We don't even use gRPC here.

Yeah, what did that guy say? Apparently this was a comment for another issue :)

No worries Julien :smile:


fix(packages/core): don't add \n for headless stderr printer

Fixes #7297

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


tests fail in March

======================================================================
FAIL: testFloat (tests.TestDelta.test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/brian/tree/debian/python-modules/parsedatetime/tests/TestDelta.py", line 64, in testFloat
    self.cal.parse('1.4 months ago', self.source), months=-1.4)
  File "/home/brian/tree/debian/python-modules/parsedatetime/tests/TestDelta.py", line 37, in assertDelta
    self.assertTrue(diff < 0.05, '%s is not less than 0.05' % diff)
AssertionError: 0.0666666666667 is not less than 0.05

----------------------------------------------------------------------

I suspect this is because February only has 28 days, not the 30 days assumed by the test.

Thank you for reporting, I am personally grateful for this observation since it identifies a few issues that I need to fix in the new test suite for v3.0 (#199). The assertion checks that there is not more than a 5% variation between the targeted time and the output, in this case your test shows 6.7%. Over the span of 1.4 months, that represents a difference of 2.8 days.
I believe that this is a bug in the test case rather than in parsedatetime. The test assertion uses the following logic to calculate months:
        if months:
            delta += datetime.timedelta(days=30 * months)

Whereas Calendar.inc(), which I believe is used in these deltas, calculates month deltas based on the calendar (1 month before March 10 is always Feb 10 regardless of leap years), then adds the partial months.
The 5% rule for deltas is problematic, that can represent a huge variation from expectation when the range is months or years. Fortunately the new test suite uses different logic for deltas and as a result this test passes.
To help determine whether there is actually a bug in parsedatetime, here is a comparison between 2016 and 2017:
>>> cal.parse('1.4 months ago', sourceTime=datetime.datetime(2016,3,10,9,24,0))
(time.struct_time(tm_year=2016, tm_mon=1, tm_mday=29, tm_hour=19, tm_min=0, tm_sec=0, tm_wday=4, tm_yday=29, tm_isdst=-1), 1)
>>> cal.parse('1.4 months ago', sourceTime=datetime.datetime(2017,3,10,9,24,0))
(time.struct_time(tm_year=2017, tm_mon=1, tm_mday=30, tm_hour=4, tm_min=36, tm_sec=0, tm_wday=0, tm_yday=30, tm_isdst=-1), 1)

Is there a way a fix for this can be prioritized? I work at EFF where I'm a developer of Certbot. Certbot depends on parsedatetime and this issue is causing some trouble in Debian packaging. In the worst case, if this bug isn't fixed parsedatetime may be removed from the next version of Debian which will also cause problems with Certbot's packaging.
When can we expect a fix for this to be available to the Debian developers so they can continue to include parsedatetime?

The assertion can be made more lax but I will have to defer to @bear regarding publishing a release with that change. Is that something you could push out soon, Mike?

yes, we can push one a release out now if needed

@idpaterson any reason we don't use Calendar.inc() to calculate that instead of the hardcoded 30 ?

I personally don't like the test as is, it tests something different depending on the current time. The tests should test the same thing every time it is run. If you want it to test from multiple times, that should be allowed for in the tests. Instead of requiring you to run the tests multiple times throughout the year. I would suggest the fix is to hard code the source time, to something that is known to work, for example (I picked 2017-01-01 but this is arbitrary):
diff --git a/tests/TestDelta.py b/tests/TestDelta.py
index c628d5e..054eabe 100644
--- a/tests/TestDelta.py
+++ b/tests/TestDelta.py
@@ -3,7 +3,6 @@
 Test time delta
 """

-import time
 import datetime
 import unittest
 import parsedatetime as pdt
@@ -13,9 +12,9 @@ class test(unittest.TestCase):

     def setUp(self):
         self.cal = pdt.Calendar(version=pdt.VERSION_CONTEXT_STYLE)
-        self.source = (self.yr, self.mth, self.dy,
-                       self.hr, self.mn, self.sec,
-                       self.wd, self.yd, self.isdst) = time.localtime()
+        self.source = (2017, 1, 1,
+                       7, 1, 2,
+                       6, 1, 1)

     def assertDelta(self, ts, years=None, months=None, **deltakw):
         ts = ts[0]

I think that test may be one of the more older of them, so is very likely broken in the sense that it's not following our current style.
@idpaterson I'm all for making the change @brianmay suggests

@bear I agree that using Calendar.inc() here is best. It is consistent with how the new test suite handles deltas, is already tested elsewhere, and is much more accurate than the < 5% assertion. I don't think I have time for that tonight but could work on it tomorrow if you're busy.
@brianmay the new tests for v3.0 do exactly that, every test is automatically run against a consistent set of source times. Modifying or adding to those dates is trivial:
DEFAULT_SOURCE_TIMES = (
    datetime(2016, 2, 29, 3, 4, 5),
    datetime(2015, 2, 28, 23, 22, 21),
    datetime(1945, 12, 31, 3, 4, 5),
)

fixed in release v2.3 which i'm pushing out now - we can add more tests and switch to .inc() later

Thanks so much for fixing this unbelievably quickly.

I know how OS packagers can be (used to be one way back in the day) and it needed fixing...
long way of saying your welcome! :)

This issue is still open but the comments suggest that the test was fixed.  What's the current status?


Go to Symbol in Workspace... does not show private methods or properties

Expected Behavior
Go to Symbol in Workspace... should match any symbol in the workspace, including private, protected, and public methods and properties.
Current Behavior
Go to Symbol in Workspace... does not show results for private methods or properties. Changing the visibility of the symbol to protected or public causes the symbol to appear in the results as expected.
Go to Symbol in File... works as expected and does show results for private methods and properties, so the issue seems limited to the workspace-wide searches.

I'm having the same issue, (using ubuntu)

Same issue here

This was as designed as I thought users would only use this for searching public symbols, but no reason why it cant be changed to include all symbols regardless of visibility.

@bmewburn Thanks for considering it. I think most developers expect to be able to navigate to a symbol regardless of its visibility.

Thanks! It would be nice for cases like :

$this->foo = new FooClass;

// and go to the definition from here :

$this->foo->barMethod() ; // to FooClass@barMethod

This will be available in v0.8.3.
@jeffochoa in your case this should work if you phpdoc your class properties and barMethod is public


xrmBrowser.ActivityFeed.AddTask() throws InvalidOperationException

This issue is very similar to issue #161 . I noticed it hasn't been solved and has been open for nearly a year, but no resolution has been posted. I am running into the same issue, and my code is structured similarly.

What does not complete:
-Time under 'due'
-Priority does not change, regardless of whether the OptionSet declaration is set to Normal or not.
My Code:
xrmBrowser.ActivityFeed.AddTask("Test Task", "This is a test to add a task to the record", new DateTime(2020, 5, 5), new OptionSet() { Name = "quickCreateActivity4212controlId_scheduledend", Value = "0" });
Yes, the name value in the option set is "quickCreateActivity4212controlld_scheduledend", which is the same value that issue #161 had. Wondering what the status of this is, or if there is a workaround. Thanks!

Thanks for raising this issue @sammcquistan . I'll take a look into this and let you know if I have any problems reproducing the issue reported.
If all goes well, I'll let you know once I've confirmed the problem and when a fix is available.
Warm Regards,
Tyler

Looks like the test in devlop branch is passing with no issues.  @sammcquistan which version of CRM are you using?
[TestMethod]
public void WEBTestAddTask()
{
if (!HasData) return;
XrmTestBrowser.ActivityFeed.SelectTab(Api.Pages.ActivityFeed.Tab.Activities);
XrmTestBrowser.ActivityFeed.AddTask("Schedule an appointment", "Capture preliminary customer and product information.", DateTime.Now, new OptionSet { Name = "quickCreateActivity4212controlId_prioritycode_d", Value = "Normal" });
XrmTestBrowser.ThinkTime(4000);
}

@thathi we are currently on version 1710 (<IP_ADDRESS>26).

@sammcquistan - I was able to take a look at this today as well, and like @thathi , I did not experience any problems. Both the Time and Priority values were set as expected. I tested with both the Develop and current releases/v9.1 branch. My test CRM organization is running on build <IP_ADDRESS>26 was well.
If this issue still exists, I will note that for my Chrome browser testing, I was using v75 of the Browser, and ChromeDriver v74. Could you please validate which WebBrowser and ChromeDriver versions you are testing with?
Mine are included below:
Session info: chrome=75.0.3770.100
Driver info: chromedriver=74.0.3729.6

Hi all,
Thanks for helping me look into this. @TYLEROL I am using Chrome 75.0.3770.100 and my chromedriver version is 74.0.0 (most up-to-date version according to NuGet). I am still having issues with this script and am still unable to add a task to my activity feed. I have attached a GIF to display the behavior I am experiencing.

It appears that EasyRepro is able to execute the script up until setting the priority, and then the element is unable to be found (since I am still getting the System.NullReferenceException). Here is the code for the test case I am running:
xrmBrowser.LoginPage.Login(_xrmUri, userName, _password, LoginHelper.ADFSLoginAction);
xrmBrowser.GuidedHelp.CloseGuidedHelp();
xrmBrowser.ThinkTime(500);
xrmBrowser.Navigation.OpenSubArea("Sales", "Contacts");
xrmBrowser.ThinkTime(500);
xrmBrowser.Grid.SwitchView("All Contacts");
Random Range = new Random();
xrmBrowser.ThinkTime(500);
xrmBrowser.Grid.OpenRecord(Range.Next(0, 46));
xrmBrowser.ThinkTime(5000);
xrmBrowser.ActivityFeed.SelectTab(Api.Pages.ActivityFeed.Tab.Activities);
xrmBrowser.ActivityFeed.AddTask("Test Task", "This is a test to add a task to the record", DateTime.Now, new OptionSet { Name = "quickCreateActivity4212controlId_prioritycode", Value = "Normal" });
xrmBrowser.ThinkTime(3000);
Finally, here is some of the code from dev tools:

Thanks again @sammcquistan for these additional details. Based on what you provided, I suspect the issue was a missing _d in the Name of the OptionSet you provided.
I have checked in a change to the develop branch to alleviate this. Could you please try this again using the latest from develop? Please note some additonal details following this...
The checked in change adjusts this test method to fall more in-line with prior expected EasyRepro inputs. Instead of providing the full element id, you should instead provide the schema name of the field. In the AddTask() method, we'll do the element id translation for you.
In addition to this, I have updated the WEBTestAddTask() example with another use case for setting a DateTime value of something other than DateTime.Now().
Please let me know if you still receive exceptions with the latest code in develop.
Warm Regards,
Tyler

Hi @TYLEROL ,
Great news, these hotfixes worked great. I did have to comment out this line of code from ActivityFeed.cs in my own solution:
this.SetCalenderValue(Elements.ElementId[Reference.ActivityFeed.ActivityAddTaskDueTimeId], dueDate.ToShortTimeString());
When I used the latest dev branch I was noticing that I was receiving a different error this time related to setting the time and that the element was not being found by chromedriver. I commented out the line of code shown above and the test worked smoothly. I am not sure if this is an issue specific to our Dynamics solution or if it is something wider, but I am happy that we were able to get this functionality working.
Thanks for all the help!
Sam

Hi @sammcquistan - Thanks for helping validate here. I am having some difficulties getting my environment configured correctly, but is it possible that your 'DateTime' field is only enabled to show Date Only and not both Date and Time?
I have pushed one more change via #592 which performs a check to see if the 'Time' field is present, and if so, attempt to set it. Could you help me validate that this alleviates the previously observed exception in your last update?
Warm Regards,
Tyler

HI @TYLEROL ,
I'm fairly certain our organization has DateTime set to show Date initially, but a user is able to select a Time after confirming a Date. I believe that is what is leading me to this error with the most recent push, where the test method is unable to find that Time field. The test method continues to search for the Time field but instead is unable to. After a bit of time, the test fails and I get an error that the element was unable to be clicked. I believe it is being found, but it is not interactable (as we can see when we try to interact with it). See GIF below:

I believe this is out-of-the-box behavior (?) because we haven't made any updates to the Task function. I'm wondering if this would work if we add a line of code that moves the focus to another element and then back to the Time field.

In my case it's not selecting the priority. After it enters the time and the cursor is in time field only and it waited for around 10 seconds and then got the below error:
System.InvalidOperationException: 'Field: prioritycode Does not exist'
Chrome Version: 75.0.3770.100
chromedriver : 75.0.3770.90
Error Details:
System.InvalidOperationException   HResult=0x80131509   Message=Field: prioritycode Does not exist   Source=Microsoft.Dynamics365.UIAutomation.Api   StackTrace:    at Microsoft.Dynamics365.UIAutomation.Api.XrmPage.<>c__DisplayClass23_0.<SetValue>b__0(IWebDriver driver)    at Microsoft.Dynamics365.UIAutomation.Browser.DelegateBrowserCommand1.ExecuteCommand(IWebDriver driver, Object[] params)
at Microsoft.Dynamics365.UIAutomation.Browser.BrowserCommand1.Execute[T1,T2,T3,T4,T5,T6,T7,T8,T9](IWebDriver driver, T1 p1, T2 p2, T3 p3, T4 p4, T5 p5, T6 p6, T7 p7, T8 p8, T9 p9)    at Microsoft.Dynamics365.UIAutomation.Browser.BrowserPage.Execute[TResult](BrowserCommandOptions options, Func2 delegate)
at Microsoft.Dynamics365.UIAutomation.Api.XrmPage.SetValue(OptionSet option)
at Microsoft.Dynamics365.UIAutomation.Api.Pages.ActivityFeed.<>c__DisplayClass10_0.b__0(IWebDriver driver)
at Microsoft.Dynamics365.UIAutomation.Browser.DelegateBrowserCommand1.ExecuteCommand(IWebDriver driver, Object[] params)    at Microsoft.Dynamics365.UIAutomation.Browser.BrowserCommand1.Execute[T1,T2,T3,T4,T5,T6,T7,T8,T9](IWebDriver driver, T1 p1, T2 p2, T3 p3, T4 p4, T5 p5, T6 p6, T7 p7, T8 p8, T9 p9)
at Microsoft.Dynamics365.UIAutomation.Browser.BrowserPage.Execute[TResult](BrowserCommandOptions options, Func2 delegate)    at Microsoft.Dynamics365.UIAutomation.Api.Pages.ActivityFeed.AddTask(String subject, String description, DateTime dueDate, OptionSet priority, Int32 thinkTime)

P1729

@kishkk84 - I'll take a look at this as a part of issue #610
@sammcquistan - The core of these changes will be made available in build <IP_ADDRESS>10 and the latest releases/v9.1 branch. Similar to the other issue posted here, it appears there may be a timing problem that is not quite replicating on my side. I was able to test with both Date/Time and Date Only fields with no issue. From your last update, and the other one posted here - these appear to be timing "misses" when checking for certain elements. I'll take a deeper look as a part of #610 .


Fix metric confusion when the metric name is contained in the tags

What does this PR do?
Previously, when the metric name occurred in the tags list, the two
hashes would cancel out when we combine them with XOR, causing the
same context key to be returned for different metrics.
This patch replaces XOR hash combination with a murmur3 hash of metric
name, hostname and the bytes of the tags hash.
Motivation
Avoid metric confusion when metric name is present in the tags.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
docker run --rm --name qa \
-e DD_LOG_LEVEL=debug -e DD_LOG_PAYLOADS=true -e DD_DOGSTATSD_SOCKET=/tmp/dsd.sock \
-e DD_API_KEY=none -v /tmp:/tmp \
datadog/agent:7.36.0-rc.1

Send two or more metrics that both have the metric name in the tags:
echo -e 'metric.1:11111|g|#metric.1\nmetric.2:22222|g|#metric.2' | nc -uU /tmp/dsd.sock

Verify that both metrics are present in the outgoing payload:
docker logs qa | grep metric\\\.

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.


GH-36537: [Python] Ensure dataset writer follows default Parquet version of 2.6

Rationale for this change
When bumping the default Parquet write version from 1.0 to 2.4 and then to 2.6, we forgot to also bump that default in the parquet.dataset writer (ParquetFileWriteOptions).
This PR bumps that directly from 1.0 to 2.6 to follow the default of the pyarrow.parquet module.
Are these changes tested?
Yes
Are there any user-facing changes?
Different default version can give different types in the parquet file.

Closes: #36537

@github-actions crossbow submit -g integration


stat on mac

I've added code to handle stat on both Mac and Linux. It required some restructuring, the stat code is now in a folder to make it more manageable.
I've also added a corresponding lstat function.
I've beefed up the stat_test quite significantly and all stat tests pass on both MacOS and Linux.
Be aware that errno was also broken on MacOS so to get that going I've rejigged the code in unistd/errno.dart.

test('file', () {
withTempDir((temp) {
withTempFile((path) {
File(path).writeAsStringSync(
'123456789\n'
'This is a\n'
'text file\n'
);
'chmod 4463 $path'.toList();
'ln $path $temp/test_file_2.txt'.toList();
  'ln $path $temp/test_file_3.txt'.toList();```dart

});
});

S. Brett Sutton
Noojee Contact Solutions
03 8320 8100

On Tue, 7 Dec 2021 at 14:21, ab36245<EMAIL_ADDRESS>wrote:

><EMAIL_ADDRESS>commented on this pull request.
> ------------------------------
>
> In test/src/stat_test.dart
> <https://github.com/noojee/dart_posix/pull/3#discussion_r763598363>:
>
> > -    expect('${struct.size}', equals(size));
> -
> -    expect('${struct.blocks}', equals(blocks));
> -    expect(struct.lastAccess, equals(toDateTime(lastAccess)));
> -    expect(struct.lastModified, equals(toDateTime(lastModified)));
> -    expect(struct.lastStatusChange, equals(toDateTime(lastStatusChange)));
> -
> -    /// we don't check the blocksize as the stat command appears to always
> -    /// report 512 even if the system block size is something else.
> -    /// expect('${struct.blockSize}', equals(blockSize));
> -  });
> +    group('stat:', () {
> +      late final String scratch;
> +
> +      setUpAll(() async {
> +        scratch = _runScript('mytest', 'setup').first;
>
> Is this preferable to an external script?
>
>  test('file', () {
>       final temp = dcli.createTempDir();
>       final path = dcli.join(temp, 'test_file.txt');
>       File(path).writeAsStringSync(
>         '123456789\n'
>         'This is a\n'
>         'text file\n'
>       );
>       'chmod 4463 $path'.toList();
>       'ln $path $temp/test_file_2.txt'.toList();
>       'ln $path $temp/test_file_3.txt'.toList();
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/noojee/dart_posix/pull/3#discussion_r763598363>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAG32OCXDTC6GNKH4YZTYU3UPV4SRANCNFSM5JQBGCRA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>

Yes to all of those except fifo.
The posix chmod is exposed in package:dcli/posix.dart as is the reset of
the posix commands dcli exports.
If you can create the fifo by shelling out to a process then you can do it
from dcli which I can see you have already played with.
'some command'.run;
'some command'.start( with more controls).
'some command'.toList() - which I think you are already using.
'
S. Brett Sutton
Noojee Contact Solutions
03 8320 8100
On Tue, 7 Dec 2021 at 13:56, ab36245 @.***> wrote:

@.**** commented on this pull request.
In test/src/stat_test.dart
https://github.com/noojee/dart_posix/pull/3#discussion_r763590089:

expect('${struct.size}', equals(size));

expect('${struct.blocks}', equals(blocks));
expect(struct.lastAccess, equals(toDateTime(lastAccess)));
expect(struct.lastModified, equals(toDateTime(lastModified)));
expect(struct.lastStatusChange, equals(toDateTime(lastStatusChange)));

/// we don't check the blocksize as the stat command appears to always
/// report 512 even if the system block size is something else.
/// expect('${struct.blockSize}', equals(blockSize));
});

group('stat:', () {

 late final String scratch;

 setUpAll(() async {

   scratch = _runScript('mytest', 'setup').first;

I think dcli looks great and I'm happy to use it. Can I set file
permissions (can't see chmod in the methods)? Can I create fifos? If so, I
should be able to drop the mytest script.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/noojee/dart_posix/pull/3#discussion_r763590089, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG32OBBIBSGC62FH5FJSDTUPVZUTANCNFSM5JQBGCRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sounds good. Yes, I've worked out how to run the commands (is toList() the "best" way if I don't want output?), so I'm just putting the finishing touches on the withTempDir/withTempFile approach.

BTW, I've added back in your memory corruption test but it is failing. The permissions tests fail. I suspect it is sensitive to umask settings as it expects the file to be 0666 but the ones I get are 0644.

I've published a release which includes your changes. 2.2.3
Greatly appreciate your help!

On my system memory test is passing or did you updated?

Sorry, I should have mentioned that I added a simple chmod before entering the loop. All works for me now on both mac and linux


example needs permissions to not error

If these permissions are not set, then I don't have enough permissions to run the github actions in my organization's repo. I get the following error unless these permissions are set:
The workflow is not valid. .github/workflows/openhands-resolver.yml (Line: 10, Col: 3): Error calling workflow 'All-Hands-AI/openhands-resolver/.github/workflows/openhands-resolver.yml@main'. The workflow is requesting 'contents: write, issues: write, pull-requests: write', but is only allowed 'contents: read, issues: none, pull-requests: none'.

Hi @ryx2, thanks for contributing! Quick question: is this required to set permissions at the workflow level versus at the repository level (see instructions here)? I'm curious if there's any benefits to doing it on the workflow level instead 🙂

I did not provide enough context originally. I could not enable that flag like the instructions said. Even though I am my organization owner / admin, I cannot set the 'Enable "Allow Github Actions to create and approve pull requests"', see this screenshot below.

Ah I think this occurs because you need to set permissions on the organization level first. After this the "Read and write permissions" should be available on the repo level.

I did see that, but I cannot set that on the organizational level?

Are you on enterprise by any chance? You can follow the instructions here to enable it on the organization level.


Script does not find all channels?

Hello, first of all great work!
I'm having some issues with the tool. It seems like it does not find all channels in the list.
2018-11-23T18:10:25.488923 saving retrieved m3u file: /srv/ftp/original.m3u8 2018-11-23T18:10:25.490849 parsing m3u into a list of objects 2018-11-23T18:10:25.627204 m3u contains 252 items 2018-11-23T18:10:25.627339 keeping channel groups in this list ['extra +1'] 2018-11-23T18:10:25.627796 filtered m3u contains 0 items
It only finds 252 items, but the list has up to 10000 channels in it. I'm a bit confused and hope you can help me.
Thanks in advance.

I can't see what's inside your m3u file but I can tell you that the script runs a few validation steps as it parses the file to determine what it considers to be valid m3u items.
https://github.com/jjssoftware/m3u-epg-editor/blob/master/m3u-epg-editor.py#L56-L61
An m3u item is considered valid when it contains a non-empty group-title attribute value, a non-empty tvg-name attribute value and optionally a non-empty tvg-id attribute value.
If you take a look at the contents of your m3u file with these conditions in mind it might make more sense. One thing you could try is including the --no_tvg_id / -nt argument in your command line, this will enable the script to consider items with no tvg-id attribute value as valid items.

--nt seems to fix the problem. Thank you very much :)

Great news @xses22, closing now


RFE: add ability to handle different behaviours for ADFS signed responses and ADFS signed Assertions

Some SAML2 services/components have more strict requirements to require  more than just Assertion signing but also message  signing.
It  would be  well received  to be more flexible.
Such an enhancement would allow ADFSToolkit to:

preserve existing out of the box ADFS behaviour (expected as AssertionOnly ) as default
Allow  a site  operator to apply a different default such as MessageAndAssertion if  desired
have the ability  to selectively adjust a given SP whilst leaving other configurations alone  via the ADFSTk-LocalManualSPSettings.ps1 file

REFERENCES:
3 possible settings of set-adfsrelyingpartyTrust for -SamlResponseSignature which are:
	AssertionOnly
	MessageAndAssertion
	MessageOnly

Technology stack/endpoints that may  require this:
The SATOSA proxy: https://github.com/IdentityPython/SATOSA

FYI I don't think the SATOSA proxy necessarily requires this, it's just that Internet2's deployment of it in our IAM platform does require it, for security reasons (see also: https://www.sso-attacks.org/XML_Signature_Wrapping)

Closing and resolved in release v2.0.0 https://github.com/fedtools/adfstoolkit/releases/tag/v2.0.0


Support for sqlalchemy 1.4 or optionally disable specific stubs

Hi, firstly thanks for pylance it really is amazing!
I am currently using a pre-release version of SQLAlchemy 1.4. It includes some changes to the mapper configuration:
from sqlalchemy import Column, Integer, String, Text, ForeignKey

from sqlalchemy.orm import registry
from sqlalchemy.orm import relationship

mapper_registry = registry()

@mapper_registry.mapped
class User:
    __tablename__ = 'user'

    id = Column(Integer, primary_key=True)
    name = Column(String)

    addresses = relationship("Address", back_populates="user")

@mapper_registry.mapped
class Address:
    __tablename__ = 'address'

    id = Column(Integer, primary_key=True)
    user_id = Column(ForeignKey("user.id"))
    email_address = Column(String)

    user = relationship("User", back_populates="addresses")

The bundled stub pylance includes for SQLAlchemy are not compatible with 1.4+:

If you are using PEP 484 static type checkers for Python, a MyPy plugin is included with type stubs for SQLAlchemy. The plugin is tailored towards SQLAlchemy declarative models. SQLAlchemy hopes to include more comprehensive PEP 484 support in future releases.
Source

Since 1.4 includes some type stubs for mypy it may cause some other clashes in the future.
Is it possible to get some minor support of this version or at least some version detection and enable/disable based on that?
microsoft/pylance-release#837 discusses disabling the bundled SQLAlchemy stubs, I think having the ability to enable/disable specific bundled type stubs would be a great.

References

https://docs.sqlalchemy.org/en/14/
https://pypi.org/project/SQLAlchemy/1.4.0b1/
https://docs.sqlalchemy.org/en/14/orm/mapping_styles.html#declarative-mapping

This surprises me, as we should be getting types from SQLAlchemy directly if they are provided along side it. The bundled stubs are the last place we look and should not be taking precedence. As a workaround, you could delete the stubs from the Pylance bundle and see if that helps.
Looking at that source link, though, it doesn't seem to say that stubs are included, only that you can install those stubs to get some amount of support, no? We aren't mypy, so its plugin doesn't really do anything for us. Constructs that can't be defined in terms of type annotations and instead rely on per-type-checker plugins are really unfortunate...

This surprises me, as we should be getting types from SQLAlchemy directly if they are provided along side it. The bundled stubs are the last place we look and should not be taking precedence. As a workaround, you could delete the stubs from the Pylance bundle and see if that helps.
Looking at that source link, though, it doesn't seem to say that stubs are included, only that you can install those stubs to get some amount of support, no? We aren't mypy, so its plugin doesn't really do anything for us. Constructs that can't be defined in terms of type annotations and instead rely on per-type-checker plugins are really unfortunate...

I can confirm I just installed https://pypi.org/project/sqlalchemy2-stubs/ (and then uninstalled mypy), this seems to work with sqla 1.4 including the new "future=true" param and the moving of the location of declarative_base between files.
It does not seem to handle hybrid_property decorators, I'm not sure if thats a pylance bug or a type stub bug. With a regular property decorator pylance accepts two functions with the same name for getter and setter. This is not handled with hybrid_property.

Pyright (the type checker upon which pylance is based) contains a bunch of special logic for the @property class since it has very special semantics and is a common stdlib construct. We don't include special logic for third-party libraries that have unusual or non-standard semantics. So unfortunately, the hybrid_property for sqlalchemy won't work the way you hope it does.

Thanks for linking to that package (https://github.com/sqlalchemy/sqlalchemy2-stubs). They seem like they're in alpha, but we will probably want to switch to these in our bundle at some point given they support 1.4 and 2 and are actually in the sqlalchemy org on GitHub.

Yeah, definitely in alpha. The sqlalchemy2-stubs are back to having no idea what the return is for a query. In other words, session.query() returns unknown, so then .all() and .one() don't work and the final return is also unknown. This is enough of an annoyance I'm uninstalling it, but its at least worth knowing about. Might look back in more detail later but for right now I can put up with a few bad imports and function signatures in exchange for not having to manually type every query result :)

I tried the sqlalchemy2-stubs package today due to model column type issues (as described in #837) and unfortunately the session.query() (and all other common methods on session) issue still persists when session is a scoped_session.

is this a dupe of #840?  or is the issue here that of automatically determining the right stubs for SQLAlchemy specifically without any user intervention ?

SQLAlchemy stub issue. That is outside what we can do


Upgrade to kubernetes 1.0.3

Hi,
I've upgrade your code to make it work with Kubernetes 1.0.3.

I had to adapt the specs to the v1 format.
I fix several issues related to the name of the environment variables
I use the token from /var/run/secrets/kubernetes.io/serviceaccount/token as it's the recommended way to access API within a pod.

You need the AdmissionController option enabled in your apiserver.
Thanks for you great work!
BR,

Awesome! Thanks @kikov79.
Could I ask for 1 favour to add to this pull request? Will add comment to the code.

Done.

Thanks!


Allow for  to be a conditional wrapper ie. only render children.

What problem does this feature solve?
This use case is often called a conditional wrapper .
There sometimes is a need to wrap an element in a link or other elements for styling.
But instead of making multiple similar components or providing a placeholder tag like div .
It would be great to be able to simply leave out the wrapping. This is important since sometimes a even simple 'div' wrapper can break styling as well/ would need extra consideration/ work/ moving parts.
What does the proposed API look like?
I think the most clean and practical way for programmatic use would be to use the is prop.
Either by passing in a falsy value, or by passing in 'template', a tag that doesn't render in the html.

Template
Output

<component :is="false">Child</component>
Child

OR

<component :is="'template'">Child</component>
Child

This can be achieved through a render function. It should be a functional component in Vue 2 but can be anything in Vue 3.
If you think something like this is worth pursuing in vue core rather than an external library, you can open a PR on the vuejs/rfcs repository

I tried and so have others but so far nobody has cracked it. All solutions are workarounds but none do it as cleanly.
What i tried here: was:
export default {
functional: true,

props: ['tag'],

render(h, context) {
const { children, props, data } = context

//  The wrapper element itself becomes the html element/component.
if (props.tag) {
  return h(props.tag, data, children)
} else {
// And if the tag is false than it only renders children
  return children
}
},
}

But I have difficulties making h(props.tag, data, children) as “transparent” as possible. And am getting errors when using components like
Any advice on what the best approach would be?

I was suprised to find out this is not supported by Vue. We need this! 😄

If something like this does eventually get implemented, I think it would make a lot more sense to use a directive, analogous to the v-if directive:

      This is a span that is sometimes wrapped up in a div.

Why was this closed, this is a good feature to have.
My (inconvenient) solution is to have a special Wrapper.vue component:
<template>
  <component :is="tag" v-if="wrap">
    <slot />
  </component>
  <slot v-else />
</template>

Also, if this is built-in to vue, rather than a special v-wrap-if directive, perhaps it'd be better to use vue's already built-in fragment, <template>:
<template>
  <component :is="shouldWrap ? 'div' : 'template'">
     some content
  </component>
</template>

(The above doesn't currently work in Vue 3.

FYI, this has since been opened as an RFC: https://github.com/vuejs/rfcs/pull/449

Is there any news on this? The conditional wrapper feature would be really useful and I'm wondering whether someone already found a solution for this. Either as a custom directive or over the <compontent>  tag.

Any status update? :)

I've said it somewhere else, but why not here again:
I came up with a Vue 2 component to solve that use case

Usage:
<component
  :is="isLink ? 'a' : 'Fragment'"
  :href="someLinkComputed"
>
  I can even be plain text!
</component>

Why was this closed, this is a good feature to have.
My (annoying) solution is to have a special Wrapper.vue component:
<template>
  <component :is="tag" v-if="wrap">
    <slot />
  </component>
  <slot v-else />
</template>

Also, I'd lean towards OP's solution of using vue's existing fragment <template> tag, rather than implementing a new special v-wrap-if directive that people have to learn/remember.
<template>
  <component :is="shouldWrap ? 'div' : 'template'">
     some content
  </component>
</template>

(The above is a proposal, it doesn't currently work)

You can even shorten your code to this:
<template>
    <component :is="tag" v-if="tag">
        <slot/>
    </component>
    <slot v-else/>
</template>

With this, you can use it very similar to your prefered proposal:
<wrapper :tag="shouldWrap ? 'div' : undefined">
  some content
</wrapper>

A workaround is to use the Transition component:
<template>
    <component :is="condition ? Wrapper : Transition">
        Child
    </component>
</template>

Looks like a neat solution for Vue 3
https://dev.to/alexander-nenashev/conditional-wrap-component-in-vue-3-pt3-8dp

I've created a new RFC to address this feature request. Please join the discussion here if you are interested.


Is it possible to pause/disable scrolling temporarily?

Issue Summary
I want to be able to stop the scrolling action at a certain point. I've managed this by scrollbar.destroy(true), but I can't re-enable it. Is there any way to do that?
Expected Behavior
I want to be able to do a scrollbar.disable() and a scrollbar.enable(), or somehow a way to reinit a scrollbar that has been destroyed without removal.

I'd suggest you to destroy it with removal. Then you can just re-init it by init() method.

The problem then is that it will scroll to the top after it's removal. I want it to stay at the current offset. The site I'm coding requires me to scroll down to a certain point, where I will then disable scrolling and the mousewheel in turn will activate a slider instead of scrolling the site.

Well, if you just want to prevent wheel events from being handled, you can simply call event.preventDefault() inside your slider so that the event will be ignored:
// make sure the event can propagate to scrollbar container
slider.addEventListener('wheel', e => e.preventDefault());

Hmmm if you want to disable all handlers, there's a tricky way (not suggested though):
// disable
scrollbar.unregisterEvents(/./);

// enable
scrollbar.registerEvents(/./);

These methods are documented in the old API docs.

Do you think you can try to push this feature asap? I've been using this lib on 3 sites already and it's great, but i've had problems to lock the scroll for overlays or when menu open.

Oh sorry, just forgot this issue 😅. Will fix it soon!

v7.4.0 is out.
Now you can use scrollbar.destroy() to remove scrollbar without resetting offsets.

TY!!

How i can to know if the scrollbar isDestroy. My idea is to destroy the scrollbar on a small screen (because I'm using horizontal scroll).

@albertcito try Scrollbar.has(element) static method.

You can simply done using e.preventDefault();
@touchmove.stop="(e) => e.preventDefault()"
@touchend="
                  (e) =>  e.preventDefault();
                @touchstart="
                  (e) =>e.preventDefault();
                "


Switch simplejson to orjson

orjson simplifies and solves some issues:

the datetime issue https://github.com/ijl/orjson?tab=readme-ov-file#datetime
the options about numpy https://github.com/ijl/orjson?tab=readme-ov-file#numpy
use utf-8 "has strict UTF-8 conformance, more correct than the standard library" https://github.com/ijl/orjson?tab=readme-ov-file#orjson

So, just adding the option OPT_SERIALIZE_NUMPY in the orjson.dumps(), avoid the issues with numpy and using orjson simplifies the code

:+1: on my list for today

@neyberson this isn't passing tests
Problem with {"id":2,"result":{}}{bye}
 in json: unexpected content after document: line 1 column 21 (char 20)

This message is correct but the new parser is reading it as one message. It's a json message followed by a control message. This needs to be resolved.

@neyberson the problem is that with package json also we have it set up to receive partial json messages and also json messages that have junk on the end- it still pulls out the whole message correctly, thats why its read_jsons and not read_json

also @neyberson this is particularly an issue with windows which, on all other machines, the OS seems to fill and flush the buffer message per message but windows messages sometimes come in partially, sometimes grouped, etc

This is paused- orjson is a better option fundamentally but also doesn't support some things we need (streams etc).
At the same time, I think this is 100% necessary for the plolty ecosystem to address some other errors.

We have a pull request for this one the local too, not sure, closing this one, orjson is nice but not workable until streaming + common invalid issues are addressed


Experimental: Auto detect local mirror availability and tweak sources.list

mirrors.syd experimental server is operational
try to ok-deploy from there (avoid downloading CUDA from Internet)

mirrors.syd now also has a PyPI cache.
Consider probe and set PIP_INDEX_URL system-wide.

Bonus, set system-wide huggingface cache dir to mirror.syd.
Requires local rw mount to mirror server data directory


Android Application

I'm an Android app developer and was wondering whether you would like me to release an app on Google Play for Spyfall. It will essentially be a webview so would just load your website but may allow people easier access to it/help it to gain more visibility.

Hi Daniel, thanks for the offer! My preference at the moment is to keep clear of the mobile app space so that the original creators of Spyfall have the best possible run at making money out of their creation if they decide to do so. That's the main reason I've kept the styling and feature set very simple - it's tough making a living out of board and card games, and I really want to make sure that anything I do or encourage helps, rather than hinders them.
That said, if you want to have some fun and learn some cool stuff along the way, I thoroughly recommend having a play with my codebase and with Meteor's cordova/phonegap integration. Meteor is a really interesting platform for developing games, and the cordova support gives you much better results than a simple webview!

Yeah that seems fair enough, and I'll certainly take a look at Meteor at some point. Thanks!

Would like to point out that it is currently very playable on mobile platforms.


Can't use normal colors instead of bright colors

While trying changing to --ascii_colors argument. It always uses bright colors even though I put numbers in range 0-7, but instead it uses 8-15. How can I solve this?
I'm using neofetch 6.0.0 version.

I can't reproduce this in master.


Pipeline only works manually

Even if I configured it with branch master and the first build trigger (when there is new commit), the pipeline is not triggered when I push commits to master. Only manually trigger has works.

Useful
Info

Versions
Rancher v2.0.1-rc5 UI: v2.0.45

Access
local admin

Route
authenticated.project.pipeline.pipeline

@zhaoyao91 - I have tried this on v2.0.2 and cannot reproduce your problem.  I created a pipeline that would be triggered by a commit and it triggered.  Can you upgrade to 2.0.2 and see if you can reproduce.  If you still can't get your pipeline to work, please let me know.

You can check your repo( github / gitlab ) setting, make sure the webhook is correctlly triggered(it may failed when git server can not reach your rancher server).


Add version to FlavorText interface

Pull Request Template
Checks and Guidelines

[x] Have you checked that there aren't other open Pull Requests for the same update/change?
[ ] Linting passed (lint and lint:tsc)
[ ] Tests added (if needed)
[ ] Tests passed (test:dev)
[ ] Build passed (build)

Apologies, I edited this directly in GitHub 😅

Type of Change

[x] Bug fix
[ ] New feature
[ ] Improvement
[ ] Breaking change
[ ] Documentation update
[ ] Security

Describe the Changes
I've added this because it seems to be included in the API response for a species. I see in the history for this file that it was there at one point, then removed. Maybe it needs to be marked as optional? But the value is definitely there; for example, here's part of the response from /api/v2/pokemon-species/wooper:
"flavor_text_entries": [
        {
            "flavor_text": "This POKéMON lives\nin cold water. It\nwill leave the\fwater to search\nfor food when it\ngets cold outside.",
            "language": {
                "name": "en",
                "url": "https://pokeapi.co/api/v2/language/9/"
            },
            "version": {
                "name": "gold",
                "url": "https://pokeapi.co/api/v2/version/4/"
            }
        },
        {
            "flavor_text": "When it walks a\nround on the\nground, it coats\fits body with a\nslimy, poisonous\nfilm.",
            "language": {
                "name": "en",
                "url": "https://pokeapi.co/api/v2/language/9/"
            },
            "version": {
                "name": "silver",
                "url": "https://pokeapi.co/api/v2/version/5/"
            }
        },
        {
            "flavor_text": "A mucous\nmembrane covers\nits body. Touching\fit barehanded will\ncause a shooting\npain.",
            "language": {
                "name": "en",
                "url": "https://pokeapi.co/api/v2/language/9/"
            },
            "version": {
                "name": "crystal",
                "url": "https://pokeapi.co/api/v2/version/6/"
            }
        },

Hey @nathonius, thanks for the fix 🔧
Will review and aprove ASAP


DBZ-4981: fix: Add the advance ssl catagory in property step.

Issue https://issues.redhat.com/browse/DBZ-4619

Tested locally. Looks good!


Fix ignoring Gradle build results in VCS.

@sockeqwe, I’m closing this since a lot of things has to be rebased but please exclude build files on your own :wink:

Oh, I totally overlooked this PR (somehow I was not watching this repository and didn't get any emails / updates 😱
Sorry.


dense sift?

Is there an implementation for dense SIFT?

I'd like to also ask about the dense sift. Basically, the question is if it is possible to request SIFT features calculation for a given set of keypoints (their coordinates), without a detection of these keypoints. Thank you!

Looking through the code, am I right that denseSIFT implementation might be possible with the ExtractSiftDescriptors function? May it be possible to use it standalone?


Remove unused hexdump module

import hexdump

let s1 = "012\155\200"

echo dumpHex(s1[0].unsafeAddr, s1.len)
echo dumpHex(s1[0].unsafeAddr, s1.len, ascii = false)

let s2 = @[48'u8, 49, 50, 155, 200]
echo dumpHex(s2)
echo dumpHex(s2, ascii = false)

Oh, my fork is first! :smile:

As a matter of fact I'm not sure if dumpHex should at all live in this repo. We already have byte-utils for such things.

Yes, I noticed that this function is not used in this repository.
However, there is a bug.

Let's just remove. No proc - no bug :)

Ok, removed.
Maybe move it to nim-ranges?

This not looks like proper removal... all tests got failed now.

Sorry, fixed.

Thanks!

Maybe move it to nim-ranges?

I think https://github.com/status-im/nim-byteutils would be a better place for it. I'm not sure about your fix though. Why would anyone want nonprintable chars in the output.

I think https://github.com/status-im/nim-byteutils would be a better place for it.

I already adapted it for nim-ranges. :(

Why would anyone want nonprintable chars in the output.

Because the output can be used in GUI.

@data-man, tbh i think such function would be more universal with openarrays interface. nim-ranges can convert to openarrays anyway.

1 of 5 procs depends on ranges and MemRange is easily converted to pointer/len. I honestly don't see how those belong to ranges. Also note that nim-ranges is mostly about data structures. What you're doing is an algorithm. E.g. if i as a user use seq[byte] all over the place and suddenly want to hexdump my data, i would first check byteutils package for that function. I'm not sure if i would check ranges at all...

Ok.
But in the byteutils there are no procs for working with pointers.


Only 200 minutes of history power data

The bug
When running hoymiles-wifi [...] app-get-hist-power in the terminal or async_app_get_hist_power() in code, I only see power values for the first 200 minutes of the day (device is HMS-800W-2T)
Expected behavior
I assume this should be able to fetch all data for the current day.
Where I tested this:

Linux Desktop
Termux (Android)

Everything else seems to work as expected.

Thanks, I'm still trying to figure out the command.
You can get different results by setting control_point (although that is a guess from my side, the original parameter is cp and requested_day).
I'll keep you updated once I have figured out what those do.
e.g.
    async def async_app_get_hist_power(
        self,
    ) -> AppGetHistPower_pb2.AppGetHistPowerResDTO | None:
        """Get historical power."""

        request = AppGetHistPower_pb2.AppGetHistPowerResDTO()
        request.control_point = 0
        request.offset = OFFSET
        request.requested_time = int(time.time())
        request.requested_day = 0
        command = CMD_APP_GET_HIST_POWER_RES
        return await self.async_send_request(
            command,
            request,
            AppGetHistPower_pb2.AppGetHistPowerReqDTO,
        )

Yeah, that works, thanks. Considering how this functions, maybe the cp is short for "chunk parameter" or something but idk.
Do you know if the request return is somehow always limited to 200 data points? Using multiple requests with different cp values could be the intended way to access the history data.

It seems the response is always limited to 200 data points. At least I could not find a parameter which would increase that.


Fixing links

I think this will break the ghpages hosted at https://microsoft.github.io/cardboard-circuits/


Duplicate Hover for Points on Line Chart

I have created a chart that contains two datasets.  When I hover the first few points on either the first or the second rendered line, both lines' points get highlighted. What could be the cause of this? Should I write a callback method to catch and prevent this or is this a bug?
The behavior is in a giphy below.  I'm happy to write some code to recreate this, but trying first to see if I am missing something in the docs.

@toszter the hover mode is set to label which highlights points at the same index.
options: {
  hover : {
    mode: 'single' // similar to single tooltip, only hovers a point under the mouse
  }
}

Charmed. Thank you for the suggestion. Any thoughts on the missing vertical tick guide on the left most x-axis tick as well as the extra on the right? (Should I open a separate question issue?) That's my last issue with the auto-rendering.

That could be the gridLines.zeroLineColor. You could try changing that and see. If not, Id need a fiddle to debug

Perfect, that worked. Thank you again.

Awesome!


Missing permission required and typo

There are two mistakes in the
"What permission do I need to read the property?" section of
https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/howto-manage-inactive-user-accounts

AuditLogs.Read.All  should be AuditLog.Read.All
These two properties are not enough to gain access as app. Also need user.ReadAll

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e0a0671-953a-7797-6e0c-6616420f4c3b
Version Independent ID: a2de95d1-67b2-bcc6-402f-f5d23c53d13a
Content: How to manage inactive user accounts in Azure AD
Content Source: articles/active-directory/reports-monitoring/howto-manage-inactive-user-accounts.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@chaplic
Thanks for your feedback! We will investigate and update as appropriate.

@chaplic
Thank you for pointing this out! I've created a PR to update the documentation and it's currently waiting for the author to review and sign off.
I'll assign this issue to the author to review the user.ReadAll permission and update as needed.
Thank you for your time and patience!

This has been fixed.
#please-close


This revision of snap "dotnet-sdk" was published using classic confinement and thus may        perform arbitrary system changes outside of the security sandbox that snaps are usually        confined to, which may put your system at risk.

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: Linux RHEL - x64
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

on Ubuntu 19.04

I am also getting the same error on Ubuntu 18.04.2 LTS

This is expected as the SDK, by definition, needs additional access to system resources. To install using the Snap package, use the --classic flag as indicated by the warning.


[Help] only wss:// and ws:// no mqtt:// selection in new connection on Docker webclient

I've been facing an issue with the Docker version of the web client. When attempting to create a new connection, the only available options are wss:// and ws://. Unfortunately, there's no mqtt:// option.
Installation: docker run -d --name mqttx-web -p 80:80 emqx/mqttx-web
Host: x86_64, Linux Alpine

Hi @alwashe,
Thanks for reaching out!
The MQTTX web client, whether used online or through Docker, indeed only supports ws:// and wss:// connections. This is because browsers can only facilitate MQTT communications through WebSocket and do not permit direct TCP connections, which is typical for web MQTT applications.
I hope this clears up the confusion. Feel free to share any other questions or feedback.

Hi! If there are no other concerns, I will temporarily close this issue. Thank you for using MQTTX.

Hi @alwashe,
Thanks for reaching out!
The MQTTX web client, whether used online or through Docker, indeed only supports ws:// and wss:// connections. This is because browsers can only facilitate MQTT communications through WebSocket and do not permit direct TCP connections, which is typical for web MQTT applications.
I hope this clears up the confusion. Feel free to share any other questions or feedback.

Hi - there is limited information on how to make this connection between the web-interface and an mqtt broker.
I am setting up a Node.js web socket server to forward the mqtt-broker output to the mqttx is tis something you would suggest?
`const WebSocket = require('ws');
const mqtt = require('mqtt');
const brokerUrl = 'mqtt://<IP_ADDRESS>:1883';
const wsPort = 8090; // New WebSocket port
const wss = new WebSocket.Server({ port: wsPort });
const client = mqtt.connect(brokerUrl);
wss.on('connection', function connection(ws) {
ws.on('message', function incoming(data) {
client.publish('test/topic', data);
});
client.on('message', function (topic, message) {
ws.send(message.toString());
});
});
console.log(WebSocket server is running on ws://<IP_ADDRESS>:${wsPort});
`
Then directing MQTTX Web and connect to ws://<IP_ADDRESS>:8090
Thanks.


Autoplay feature?

Would you mind adding an autoplay feature?
We're considering using your component in a setting where autoplay is preferrable, but due to Chrome's (and most other browsers') new demands to not autoplay on pages where the user hasn't interacted, we'll need a nice-looking non-autoplay look as well. Yours seems to solve this.

Not able to add this feature :( but in the meantime, you can manualy call warmConnections and addIframe methods on your end:
<script setup>
import { ref } from 'vue'
import LiteYouTubeEmbed from 'vue-lite-youtube-embed'
import 'vue-lite-youtube-embed/style.css'

const iframe = ref(null)

onMounted(() => {
  iframe.value.warmConnections()
  iframe.value.addIframe()
})
</script>

<template>
  <LiteYouTubeEmbed
    id="dQw4w9WgXcQ"
    ref="iframe"
    title="Rick Astley - Never Gonna Give You Up (Official Music Video)"
  />
</template>

thanks!
On Mon, Feb 6, 2023 at 5:20 PM Robert Soriano @.***>
wrote:

Not able to add this feature :( but in the meantime, you can manualy call
warmConnections and addIframe methods on your end:

—
Reply to this email directly, view it on GitHub
https://github.com/wobsoriano/vue-lite-youtube-embed/issues/6#issuecomment-1419355393,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5E2WL5ELAWDCIRCQCU4PYLWWEQFXANCNFSM5MEINGLA
.
You are receiving this because you commented.Message ID:
@.***>

Hey wobsoriano, I was looking for this feature too, the solution you provided works but when you say "Not able to add this feature" do you mean that its not possible code-side or that you don't have time to implement it?


Valeriya: Workflows, 2 week

[ ] I wrote my markdown locally on a new branch
[ ] My bio file is named exactly the same as my GitHub username
[ ] My bio link in the class README opens to my student bio file
[ ] I pulled and merged main into my branch before pushing
[ ] I pushed my branch to the class repository and opened a PR
[ ] I went through the PR checklist
[ ] All the CI check pass
[ ] I assigned a coach to review my PR
[ ] I
linked my PR to this issue

Please write a descriptive issue's title that shows this issue for student-bio.


When importing a folder, all files from same folder have same relativePath [v3 only]

I got this bug when importing a folder using function webkitReadDataTransfer() (& readDirectory()).
Here are the details, I drop the following all folder:

Then, like you see in screenshot, all files inside a folder got same fullPath property:

I found the error comes from there:
https://github.com/flowjs/flow.js/blob/218b2bf76d840a4eb0013e3db2a0ff764d93eab7/src/Flow.js#L257
That could be easily fix, I will make a merge request later this week if you are ok with it.

yes, feel free to submit it. Have you checked v2? Does it handle it ok?

Fix merged for v3.
And v2 handles it ok:

That's great! Thanks for double checking it


[DEM-1447] updated the descriptions of the api structures

updated the docstring-descriptions of the api structures in some methods

Coverage remained the same at 100.0% when pulling e576e6a6c62752c90b172d8307e69ebf7ed44824 on feature/dem-1447/update_api_text into 1f0ecc54f63f3127fb5d08f165b59eed46f34c15 on dev.


ReferenceError: XMLHttpRequest is not defined

I ran into this error when trying to use the api, and I had to insert "var XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest;" inside spotify-web-api.js for it to work.

@EyesBear This library is intended to be used in the browser, where XMLHttpRequest should be defined. If you want to use the library on Node.JS I would recommend you to have a look at https://github.com/thelinmichael/spotify-web-api-node, which has a similar API.

So this wouldn't work with react-native

To be honest, I'm not sure about it sincr so haven't tried it yet. According to https://facebook.github.io/react-native/docs/network.html react-native does implement XMLHttpRequest so it should work out of the box.


What trigger type will fire trace action?

Hello,
I have a question about Using trigger outputs from the Debug Module. The latest debug specification adds a new trigger type (mcontrol6) to support future features and mcontrol will be considered obsolete. Thus, I just want to confirm that mcontrol6 supports actions 2-4 ?
Thanks,
Larry

All triggers are able to support all actions.  The description of the action field of mcontrol6 says:

The action to take when the trigger fires. The values are explained in Table 5.1.

Table 5.1 is the same table used by mcontrol, icount, itrigger, etrigger, and tmexttrigger.
Like with anything else, an implementation may choose to only support a subset of actions on any particular trigger.  You'd have to confirm with the particular implementation whether it supports actions 2-4 on its mcontrol6 trigger(s).


Use write database connection when validating uniqueness

It would be possible that when an application have a huge latency
between master and slave that a novice user would reattempt to recreate
an entry which is now only available on the master connection.
When he/she create the record again which require unique value such as email
it currently would only fetch from the slave database connection and
would return pass, however when the application try to save the actual
entry to the database it would fail due to unique (if we set it on the
database).
This solve the issue by always checking against master (write)
connection.
Signed-off-by: crynobone<EMAIL_ADDRESS>

This is almost similar with #12794 bugfix.


TypeError: cac is not a function

I just want to create a new nuxt app by npx create-nuxt-app, but I got this error
TypeError: cac is not a function     at Object.<anonymous> (C:\Users\ASUS\AppData\Local\Yarn\Data\global\node_modules\create-nuxt-app\lib\cli.js:12:13)     at Module._compile (internal/modules/cjs/loader.js:1085:14)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)     at Module.load (internal/modules/cjs/loader.js:950:32)     at Function.Module._load (internal/modules/cjs/loader.js:790:12)     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)     at internal/main/run_main_module.js:17:47
What just happened ?
node version : v14.18.0
<EMAIL_ADDRESS>

Hi Putnug1122,
I had the same error couple hours ago, It seems that this error is kind of new because I found nothing relative to it
So I tried multiple things from uninstalling & reinstalling node/npm to changing my npm-cache to another directory (after seeing a stackoverflow npx issue), rebooting etc...
Since nothing changed I opened the file cli.js [...\node_modules\create-nuxt-app\lib\cli.js] and went through cac documentation
I tried es6 destructuring assignment and... it just worked
I don't know if it will also work for you, it may be related to [...\node_modules\cac\index-compat.js] file
So try to replace line 5 from [...\node_modules\create-nuxt-app\lib\cli.js]:
const cac = require('cac')
to
const { cac } = require('cac')
or
const cac = require('cac').cac

@clarkdo do you mind looking at it when you have time?

Hi Putnug1122,
I had the same error couple hours ago, It seems that this error is kind of new because I found nothing relative to it So I tried multiple things from uninstalling & reinstalling node/npm to changing my npm-cache to another directory (after seeing a stackoverflow npx issue), rebooting etc...
Since nothing changed I opened the file cli.js [...\node_modules\create-nuxt-app\lib\cli.js] and went through cac documentation I tried es6 destructuring assignment and... it just worked I don't know if it will also work for you, it may be related to [...\node_modules\cac\index-compat.js] file
So try to replace line 5 from [...\node_modules\create-nuxt-app\lib\cli.js]: const cac = require('cac') to const { cac } = require('cac') or const cac = require('cac').cac

Ahhh I just replace const cac = require('cac') to const { cac } = require('cac')  and clear the cache with npm cache clean --force and it works, thank you


Use HTTPS instead of HTTP in urlset

I have display issues in my Browsers when I want to test and see the generated XML file. It seems that you are using HTTP protocol instead of the HTTPS . When I changed it to HTTPS its working fine.
<urlset xmlns="https://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="https://www.w3.org/1999/xhtml" xmlns:mobile="https://www.google.com/schemas/sitemap-mobile/1.0" xmlns:image="https://www.google.com/schemas/sitemap-image/1.1" xmlns:video="https://www.google.com/schemas/sitemap-video/1.1">

Same problem here. When I try to use links my XML completely fall apart. Temporal work around
sm.createSitemap({
    xmlNs: 'xmlns="https://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="https://www.w3.org/1999/xhtml..."'
})


added note about win10-sdk dependency

On windows, the Windows 10 SDK is required in order to link to the Universal Windows App C Runtime Library (ucrt.lib)

Thanks @Steven-Wilson.


Able to alias stack name conventions

Describe the Feature
I like using ue1-dev or org-ue1-dev, but it would be nice to alias them
so then we could have
ue1-dev         # this is real so env = ue1, stage = dev
ue1-development # alias to the above
ue1-dev-01      # alias to the above

Expected Behavior
atmos terraform plan s3-bucket/test --stack ue1-dev
atmos terraform plan s3-bucket/test --stack ue1-development
atmos terraform plan s3-bucket/test --stack ue1-dev-01

Use Case
Easier for devs to use older account names that may not match the shortest stage names
Describe Ideal Solution
See above
Alternatives Considered
No response
Additional Context
No response

That's an interesting use-case. Let me take my spin, use names that are more familiar based on company history. So canonical names can be programmatically consistent, but teams can use other conventions that make more sense in their business context.
Would the aliases be defined in the stack configuration?
components:
  terraform:
    s3-bucket/test:
      settings:
        aliases:
        - dev-01
        - dev-icons
      vars:
        # Canonical stack slug is ue1-dev-assets
        namespace: ue1
        stage: dev
        name: assets

Could be executed in the following ways:
# Using the canonical stack slug `ue1-dev-assets`
atmos terraform plan s3-bucket/test --stack ue1-dev-assets

# For "historical reasons", devs call it "dev-icons"
atmos terraform plan s3-bucket/test --stack dev-icons

I could see aliases being only valid in the settings block being ignored from all imports, because an alias would never be relative to it's stack context.


Add decontamination code

Similar to deduplication, but use benchmark datasets as index.
Used for #13

Thank you @ChenghaoMou ! Sure, maybe we can first merge this PR, then I'll upload my script too? (this PR is from a fork, so otherwise I'd need to commit directly in Chenghao's fork)

I don't have write access for merge, please help.

Ah sorry thought you could merge when the PR's approved


Incorrect parsing of explicit sibling maps

Describe the bug
explicit sibling maps are parsed as nested
To Reproduce
?
? abc

Expected behaviour
output should be two map nodes
first one should be null: null
2nd one abc: null
l+block-mapping states children must be indented further and siblings use the same indentation
Versions:

Environment: VSCode 1.89
yaml: 2.4.3

Additional context

---
!!map { #should be this
  ? !!null "null"
  : !!null "null",
  ? !!str "abc"
  : !!null "null",
}

Confirming this as a bug.


react-app-rewired build silently exits when not enought memory

I noticed a strange behavior when build docker image.
react-app-rewired build exited without emitting files and no sign of error was made by script.
Docker just continue to build an image. And only in production I got 404 error because there was lack of index.html and all js files.
I played with docker config and what I have found:
If I set Docker's RAM to 1GB and Swap to 510MB, script actually throws out of memory error and build is stopped:

But when I set RAM to 2GB (Swap still 512MB) script just exits without error:

Here is a listing of ./build/ dir in create docker image:
-rw-r--r--    1 root     root          3150 Jun  4 15:08 favicon.ico
-rw-r--r--    1 root     root          5347 Jun  4 15:08 logo192.png
-rw-r--r--    1 root     root          9664 Jun  4 15:08 logo512.png
-rw-r--r--    1 root     root           492 Jun  4 15:08 manifest.json
-rw-r--r--    1 root     root            67 Jun  4 15:08 robots.txt

And only with 3GB of RAM an images is build successfully:

Here is a this project: https://github.com/atomAltera/letmeknow-server
The problem is with a package in frontend dir.
I'm using Docker for mac. No other containers was run while building process.

Sorry, I hadn't seen this earlier.
The error messages you see are those that webpack provides back to react-scripts to display. React-scripts alters how some of the webpack messages are displayed too - doing things like clearing the screen during the build. If they provide no messages to display, there is nothing react-app-rewired can do about it. :'(
By default, node.js will use up to around 1.4Gb Ram max when building unless you set a parameter to allow it to access more memory. It's possible that the OS inside the docker container is going into a kernel memory panic in the 2Gb Ram version, and auto-killing the webpack/node.js process as the "largest" process running in order to free up memory during the build. If the webpack process is killed, it doesn't get a chance to return log messages for display. You can check if this is the case using sudo dmesg | grep -i “killed process” inside the running container that had been doing a build - if it has occurred, you should get a message line like "host kernel: Out of Memory: Killed process 2592". This blog post has a good description of what the kernel out-of-memory (OOM) killer is and why it is present in the linux kernel at all.


Add feature to get the JSON schema from the URL.

Pull Request Test Coverage Report for Build 567321024

74 of 95 (77.89%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 84.091%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/rules/no-invalid.ts
1
2
50.0%

src/utils/http-client/cli.ts
8
10
80.0%

src/utils/http-client/sync-http.ts
13
15
86.67%

src/utils/http-client/http.ts
20
27
74.07%

src/utils/schema.ts
30
39
76.92%

Totals

Change from base Build 565819371:
-0.6%

Covered Lines:
373

Relevant Lines:
436

💛  - Coveralls


[FR]: Add an icon browser in the catalog

🕵 Is there an existing issue for this?

[X] I have searched the existing issues

Describe the problem
This feature is missing.
Describe the solution
It would be great to have an icon browser inside the catalog app with a search bar.
We could also add a pinch-to-zoom gesture to see icons at a larger scale.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'll try to prepare a PR draft next week 🔜


Main image with multiple thumb images

I have a main image (on top), that load, after i select file from input field. Than file store to mysql db and output images (ng-repeat) to bottom list.
On bottom image click i must replace main image with file from db. How can i do this?

return the id of the image stored in mysql and when the user clicks on it replace the id of the main image in your database.


Fixed URL highlight

@roryabraham @kadiealexander  will you please review this?
Fixed the URL highlighting issue when URL's included :, ~, / (on param), [ and ].
Added ability to use : and / on a link text (between [ and ]).
Made sure all three URL's mentioned on the issue page worked, without causing regressions. Added tests for all this cases, and plus a couple more I could think of (and was having trouble with).
Fixed Issues
Fixes #1234
Tests & QA

What unit/integration tests cover your change? What autoQA tests cover your change?

Added quite a number of test URL's on ExpensiMark-test.js.

What tests did you perform that validates your changed worked?

On the gifs presented next, the following string was pasted on all the platforms:
Testing [first](https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22Ufjjim%22)+AND+timestamp:[2021-01-08T03:48:10.389Z+TO+2021-01-08T05:48:10.389Z]&index=logs_expensify-008878), [second](http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabled), and [third](http://github.com/Expensify/Expensify.cash/issues/123#:~:text=Please%20work/Expensify.cash)!

Web

Desktop

Android

iOS

👍 LGTM!


Android Runnable icon doesn't show up anymore

Godot version
3.4 stable, 3.5 RCs 5–8
System information
PC: Linux | Phone: Samsung Android 11 / Samsung Android 12
Issue description
(i tested on an Sammsung Android 11 phone and a Samsung Android 12 tablet.
in this issue, i use the word 'Phone' interchangeable for 'Phone' and 'Tablet'.)
Godot used to show the Android icon next to the Play icon
when i had an Android phone with USB Debugging enabled
plugged into the computer
and the Godot project had an Android export template set to Runnable.
Now the icon doesn't appear anymore.
Maybe the USB Debugging authorisation is missing,
but i never saw the Accept/Decline dialog again.
The only way to test an app is to export it from the Export menu and then run adb install <apk-filename> in the terminal, which is just 2 more steps
but tedious because i have to do it often.
when i went to export from the Terminal for the first time in a while, the Accept/Decline dialog Did show up on my phone.
Steps to reproduce

add an Android export template in the dialog from the Project > Export... menu option
it's automatically set as Runnable
close the Export dialog in Godot
enable USB debugging on your Android device
plug the Android device into your computer
look for the Android icon next to the Play icon.
notice how it doesn't show up.

Minimal reproduction project
A minimal project with the Android export template.
It lets you skip steps 1 to 3 from "Steps to reproduce".

Follow the Troubleshooting section of One-click deploy in the documentation.

I can confirm that it works for me; so this is not a bug in Godot.
If you can build for Android and your device shows up in adb devices then the only reason the runnable icon won't show is if it cannot find adb. It looks for adb in the platform-tools folder of the SDK folder configured in export/android/android_sdk_path in the Editor Settings.

what should i set editor setting export/android/android_sdk_path to?
i have set it to ~/.android/sdk

what should i set editor setting export/android/android_sdk_path to?
i have set it to /home/poppy/.android/sdk

This is probably wrong. You should follow the instructions in the documentation: https://docs.godotengine.org/en/stable/tutorials/export/exporting_for_android.html
If you've installed Android Studio, and used the default location, it will probably be /home/poppy/Android/Sdk, then you need to ensure you've also installed the Platform Tools and confirm that adb is in /home/poppy/Android/Sdk/platform-tools.
If you need more help please use one of the Godot community forums: https://godotengine.org/community. Github Issues are for tracking Godot bugs, which this is not.

fixed in Godot 4

In Godot 4.0.3, look for the remote debug icon (a monitor with a "play" triangle inside) rather than the "Android" icon.
I spent several hours looking for the Android icon and going through many reboots and resettings of adb (which worked fine from the command line).

@RadixSeven thank you, but i already know this.
if i didn't, i could not debug on Android and confirm that the issue is fixed


approximate at for activejob

I queue an email to be sent 24 hours after a certain controller action. When I try to test it, I currently have
expect { commit }.to have_enqueued_mail(...).at(Time.now + 24.hours)

The problem is that Time.now + 24.hours is not precisely equal to what it was during commit, when the job was created, so the test fails.
What I would hope to have is something like
expect { commit }.to have_enqueued_mail(...).approx_at(Time.now + 24.hours, err)

which passes if the given time is within err from the job time (perhaps with some default value for err).
As a more general alternative, it would perhaps be useful if one could easily override the class used by the matchers, say by a derived class, and then I could implement it myself (but I think the feature I suggest could be useful in general)

PS., not really related, but the page that seems to be the official docs does not mention have_enqueued_mail at all, and the links to the activejob matchers on the jobs spec page seem to be broken

I now have the following in rails_helper.rb:
module RSpec
  module Rails
    module Matchers
      class HaveEnqueuedMailApproximately < HaveEnqueuedMail
        def approx_at(tim, err = 1.minute)
          @approx_at = tim
          @approx_err = err
          self
        end

        def approx_at?(job)
          @approx_at.nil? || (job[:at] - @approx_at.to_f).abs < @approx_err
        end

        def other_attributes_match?(job)
          approx_at?(job) && super
        end

        def base_message
          res = super
          res.gsub!(' but enqueued', " approx. at<EMAIL_ADDRESS>(with error #{@approx_err.inspect}), but enqueued") if @approx_at.present?
          res
        end

      end

      def have_enqueued_mail(mailer_class = nil, mail_method_name = nil)
        HaveEnqueuedMailApproximately.new(mailer_class, mail_method_name)
      end
    end
  end
end

Wondering if the following works:
expect { commit }.to have_enqueued_mail(...).at(a_value_within(1.minute).from(24.hours.from_now))

Another option would be to use https://api.rubyonrails.org/classes/ActiveSupport/Testing/TimeHelpers.html#method-i-freeze_time

Wondering if the following works:
expect { commit }.to have_enqueued_mail(...).at(a_value_within(1.minute).from(24.hours.from_now))

Doesn't work directly, since the serialization calls to_f on the argument of at, but this is a much better solution, thanks! I will try to change the active_job matcher to skip the to_f if it can't be applied.
(also, from should be replaced with of above)

Ok, I changed https://github.com/rspec/rspec-rails/blob/e50def6ad42a5d5a648d1ee7854966407bb6f4c4/lib/rspec/rails/matchers/active_job.rb#L163 to
         @at == :no_wait ? nil : @at.try(:to_f) || @at

(possibly this should be replaced by something more sophisticated, since one might wish to keep @at even when it does respond to to_f) but also had to change https://github.com/rspec/rspec-rails/blob/e50def6ad42a5d5a648d1ee7854966407bb6f4c4/lib/rspec/rails/matchers/active_job.rb#L152 to
         serialized_attributes.all? { |key, value| Support::FuzzyMatcher.values_match?(value, job[key]) }

With these, the slightly modified version
expect { commit }.to have_enqueued_mail(...).at(a_value_within(1.minute).of(24.hours.from_now.to_f))

Slightly annoying that the to_f is required there, but it's a minor nuisance. From my point of view, this is the preferred way, thanks!

@pirj's solution is one I would expect to work and would recommend, if it doesn't lets fix it!

@mkamensky Broken matcher link in the docs can be fixed in features/job_specs/job_spec.feature like this:
-  [`have_been_enqueued`](matchers/have-been-enqueued-matcher) and
-  [`have_enqueued_job`](matchers/have-enqueued-job-matcher) for more
+  [`have_been_enqueued`](../matchers/have-been-enqueued-matcher) and
+  [`have_enqueued_job`](../matchers/have-enqueued-job-matcher) for more

Not exactly sure, but I suggest it is both applied to 3.9-maintenance and master.

Thanks! Will try to do both in a few days

@mkamensky A friendly reminder about doc update pull request.

@mkamensky A friendly reminder about doc update pull request.

Just did, not sure if there is any tests or anything beyond just fixing the links. Thanks.