SyntaxError in Vue project with preset-typescript 3.0.0

I've hit what seems like a bug with using preset-typescript 3.0.0 in a Vue.js project. I've created a simple project to demonstrate: https://github.com/macdaddyaz/sb-ts-bug

Generated a simple Vue.js app using the Vue CLI:

$ npx -p @vue/cli vue create sb-ts-bug

Vue CLI v4.2.3
? Please pick a preset: Manually select features
? Check the features needed for your project: Babel, TS, Linter, Unit
? Use class-style component syntax? Yes
? Use Babel alongside TypeScript (required for modern mode, auto-detected polyfills, transpiling JSX)? Yes
? Pick a linter / formatter config: Airbnb
? Pick additional lint features: (Press <space> to select, <a> to toggle all, <i> to invert selection)Lint on save
? Pick a unit testing solution: Jest
? Where do you prefer placing config for Babel, ESLint, etc.? In dedicated config files
? Save this as a preset for future projects? No
...

Added Storybook, using the integration instructions for Vue.js:

npx -p @storybook/cli sb init --type vue

 sb init - the simplest way to add a storybook to your project.

 • Installing Storybook for user specified project type. ✓
...

Installed TypeScript preset (version 3.0.0), and integrated it into the Storybook config:

module.exports = {
  stories: ['../stories/**/*.stories.js'],
  addons: ['@storybook/preset-typescript', '@storybook/addon-actions', '@storybook/addon-links'],
};

At this point, Storybook still runs fine using the example stories.

Switched the config to look for stories co-located with the components, and created a basic story for the HelloWorld component.

module.exports = {
  stories: ['../src/**/*.stories.[jt]s'],
  addons: ['@storybook/preset-typescript', '@storybook/addon-actions', '@storybook/addon-links'],
};

import HelloWorld from './HelloWorld.vue';

export default {
  title: 'HelloWorld',
};

export const basic = () => ({
  components: { HelloWorld },
  template: '<hello-world msg="Hello, Storybook"></hello-world>',
});

It's at this point that Storybook stops working. When I run it, I get syntax errors on the TypeScript in the component:
$ yarn storybook --ci
yarn run v1.22.4
$ start-storybook -p 6006 --ci
info @storybook/vue v5.3.17
info
info => Loading presets
info => Loading presets
info => Adding stories defined in ".storybook/main.js".
info => Using default Webpack setup.
Starting type checking service...
No type errors found
Version: typescript 3.7.5
Time: 3056ms
webpack built 0185a4c4b5010793c87d in 8825ms
✖ ｢wdm｣: Hash: 0185a4c4b5010793c87d
Version: webpack 4.42.1
Time: 8825ms
Built at: 03/27/2020 5:03:44 PM
                                          Asset      Size        Chunks                                Chunk Names
                                    iframe.html  2.87 KiB                [emitted]
            main.0185a4c4b5010793c87d.bundle.js  32.9 KiB          main  [emitted] [immutable]         main
        main.0185a4c4b5010793c87d.bundle.js.map  15.3 KiB          main  [emitted] [dev]               main
    runtime~main.0185a4c4b5010793c87d.bundle.js  31.2 KiB  runtime~main  [emitted] [immutable]         runtime~main
runtime~main.0185a4c4b5010793c87d.bundle.js.map  32.3 KiB  runtime~main  [emitted] [dev]               runtime~main
    vendors~main.0185a4c4b5010793c87d.bundle.js  2.58 MiB  vendors~main  [emitted] [immutable]  [big]  vendors~main
vendors~main.0185a4c4b5010793c87d.bundle.js.map  2.69 MiB  vendors~main  [emitted] [dev]               vendors~main
Entrypoint main [big] = runtime~main.0185a4c4b5010793c87d.bundle.js runtime~main.0185a4c4b5010793c87d.bundle.js.map vendors~main.0185a4c4b5010793c87d.bundle.js vendors~main.0185a4c4b5010793c87d.bundle.js.map main.0185a4c4b5010793c87d.bundle.js main.0185a4c4b5010793c87d.bundle.js.map
[0] multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/generated-entry.js (webpack)-hot-middleware/client.js?reload=true&quiet=true 64 bytes {main} [built]
[./.storybook/generated-entry.js] 234 bytes {main} [built]
<EMAIL_ADDRESS>120 bytes {vendors~main} [built]
<EMAIL_ADDRESS>93 bytes {vendors~main} [built]
<EMAIL_ADDRESS>1.21 KiB {vendors~main} [built]
[./node_modules/airbnb-js-shims/index.js] 40 bytes {vendors~main} [built]
[./node_modules/core-js/features/symbol/index.js] 359 bytes {vendors~main} [built]
[./node_modules/global/window.js] 232 bytes {vendors~main} [built]
[./node_modules/querystring-es3/index.js] 127 bytes {vendors~main} [built]
[./node_modules/regenerator-runtime/runtime.js] 23.6 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client-overlay.js] (webpack)-hot-middleware/client-overlay.js 2.17 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true] (webpack)-hot-middleware/client.js?reload=true&quiet=true 7.68 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/node_modules/strip-ansi/index.js] (webpack)-hot-middleware/node_modules/strip-ansi/index.js 161 bytes {vendors~main} [built]
[./node_modules/webpack-hot-middleware/process-update.js] (webpack)-hot-middleware/process-update.js 4.35 KiB {vendors~main} [built]
[./node_modules/webpack/buildin/harmony-module.js] (webpack)/buildin/harmony-module.js 573 bytes {vendors~main} [built]
    + 621 hidden modules

ERROR in ./src/components/HelloWorld.vue?vue&type=script&lang=ts& (./node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/components/HelloWorld.vue?vue&type=script&lang=ts&)
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /Users/emcintyre/Development/src/sandbox/sb-ts-bug/src/components/HelloWorld.vue: Unexpected token (40:18)

  38 | @Component
  39 | export default class HelloWorld extends Vue {
> 40 |   @Prop() private msg!: string;
     |                   ^
  41 | }
  42 |
    at Object._raise (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:742:17)
    at Object.raiseWithData (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:735:17)
    at Object.raise (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:729:17)
    at Object.unexpected (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:8757:16)
    at Object.parseClassMemberWithIsStatic (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:12047:12)
    at Object.parseClassMember (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11940:10)
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11885:14
    at Object.withTopicForbiddingContext (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:10956:14)
    at Object.parseClassBody (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11862:10)
    at Object.parseClass (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11836:22)
    at Object.parseExportDefaultExpression (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:12272:19)
    at Object.parseExport (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:12185:31)
    at Object.parseStatementContent (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11185:27)
    at Object.parseStatement (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11081:17)
    at Object.parseBlockOrModuleBlockBody (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11656:25)
    at Object.parseBlockBody (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/parser/lib/index.js:11642:10)
 @ ./src/components/HelloWorld.vue?vue&type=script&lang=ts& 1:0-180 1:196-199 1:201-378 1:201-378
 @ ./src/components/HelloWorld.vue
 @ ./src/components/HelloWorld.stories.ts
 @ ./src sync ^\.\/(?:(?:|\/|(?:(?:(?!(?:|\/)\.).)*?)\/)(?!\.)(?=.)[^\/]*?\.stories\.(?:\[jt\]|[jt])s)$
 @ ./.storybook/generated-entry.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/generated-entry.js (webpack)-hot-middleware/client.js?reload=true&quiet=true
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  6.49 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
    [./node_modules/<EMAIL_ADDRESS>2.14 KiB {HtmlWebpackPlugin_0} [built]

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

When I downgrade the version of preset-typescript to 2.1.0, then Storybook starts just fine (another workaround is eliminating the TypeScript-specific syntax in the HelloWorld component, which of course defeats the purpose).

Based on #114, I realize that the preset recently switched from ts-loader to babel-loader, so maybe all that's needed is some additional configuration to get it working again?

@graup can you help out here?

Thanks for the perfect bug report. I was going to test the 3.0 preset with vue-cli soon, great to have the steps already written up. I can reproduce this issue by following the steps. Looks like we have some digging to do here.

I saw you guys have been busy with 6.0, specifically as it relates to TypeScript, so I thought I'd give this setup a shot again.
TL;DR: Still not working for me, but error is different.
The repo in my original report is still there, and has all the changes I describe here. I tried upgrading to 6.0 beta, using these migration steps.

Removed the @storybook/preset-typescript dependency
Installed @next versions of all other Storybook dependencies
Upgraded all other dependencies, for good measure
In .storybook/main.js, tweaked the stories glob, and changed the addons references to point to the new preset module.

When I run Storybook, I get the following output:
info => Loading presets
info => Loading presets
info => Loading config/preview file in "./.storybook".
info => Adding stories defined in ".storybook/main.js".
info => Using default Webpack setup.
webpack built 148f711186461575ce23 in 10904ms
✖ ｢wdm｣: Hash: 148f711186461575ce23
Version: webpack 4.43.0
Time: 10904ms
Built at: 06/09/2020 2:16:36 PM
                                          Asset       Size        Chunks                                Chunk Names
                                    iframe.html   2.92 KiB                [emitted]
            main.148f711186461575ce23.bundle.js   9.01 KiB          main  [emitted] [immutable]         main
        main.148f711186461575ce23.bundle.js.map  234 bytes          main  [emitted] [dev]               main
    runtime~main.148f711186461575ce23.bundle.js   33.5 KiB  runtime~main  [emitted] [immutable]         runtime~main
runtime~main.148f711186461575ce23.bundle.js.map   34.7 KiB  runtime~main  [emitted] [dev]               runtime~main
    vendors~main.148f711186461575ce23.bundle.js   2.21 MiB  vendors~main  [emitted] [immutable]  [big]  vendors~main
vendors~main.148f711186461575ce23.bundle.js.map   1.77 MiB  vendors~main  [emitted] [dev]               vendors~main
Entrypoint main [big] = runtime~main.148f711186461575ce23.bundle.js runtime~main.148f711186461575ce23.bundle.js.map vendors~main.148f711186461575ce23.bundle.js vendors~main.148f711186461575ce23.bundle.js.map main.148f711186461575ce23.bundle.js main.148f711186461575ce23.bundle.js.map
[0] multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/generated-stories-entry.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false 112 bytes {main} [built]
[./.storybook/generated-stories-entry.js] 2.26 KiB {main} [built] [failed] [1 error]
[./.storybook/storybook-init-framework-entry.js] 2.27 KiB {main} [built] [failed] [1 error]
<EMAIL_ADDRESS>2.41 KiB {vendors~main} [built]
<EMAIL_ADDRESS>2.17 KiB {vendors~main} [built]
<EMAIL_ADDRESS>216 bytes {vendors~main} [built]
<EMAIL_ADDRESS>2.17 KiB {vendors~main} [built]
<EMAIL_ADDRESS>214 bytes {vendors~main} [built]
<EMAIL_ADDRESS>2.17 KiB {vendors~main} [built]
<EMAIL_ADDRESS>4.63 KiB {vendors~main} [built]
<EMAIL_ADDRESS>3.71 KiB {vendors~main} [built]
<EMAIL_ADDRESS>120 bytes {vendors~main} [built]
<EMAIL_ADDRESS>93 bytes {vendors~main} [built]
<EMAIL_ADDRESS>359 bytes {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false] 7.68 KiB {vendors~main} [built]
    + 1200 hidden modules

ERROR in ./.storybook/generated-stories-entry.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
TypeError: [BABEL] /Users/emcintyre/Development/src/sandbox/sb-ts-bug/.storybook/generated-stories-entry.js: Cannot read property 'android' of undefined (While processing<EMAIL_ADDRESS>    at getLowestImplementedVersion (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/utils.js:58:24)
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:26:77
    at Array.filter (<anonymous>)
    at targetsSupported (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:25:54)
    at isRequired (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:58:11)
    at filterItems (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:70:9)
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/lib/index.js:262:65
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-plugin-utils/lib/index.js:19:12
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/config/full.js:199:14
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/gensync-utils/async.js:26:3)
    at Generator.next (<anonymous>)
    at step (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:254:32)
    at evaluateAsync (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:284:5)
    at Function.errback (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:108:7)
    at errback (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/gensync-utils/async.js:70:18)
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/generated-stories-entry.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false main[6]

ERROR in ./.storybook/storybook-init-framework-entry.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
TypeError: [BABEL] /Users/emcintyre/Development/src/sandbox/sb-ts-bug/.storybook/storybook-init-framework-entry.js: Cannot read property 'android' of undefined (While processing<EMAIL_ADDRESS>    at getLowestImplementedVersion (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/utils.js:58:24)
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:26:77
    at Array.filter (<anonymous>)
    at targetsSupported (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:25:54)
    at isRequired (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:58:11)
    at filterItems (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-compilation-targets/lib/filter-items.js:70:9)
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/lib/index.js:262:65
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/preset-env/node_modules/@babel/helper-plugin-utils/lib/index.js:19:12
    at /Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/config/full.js:199:14
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/gensync-utils/async.js:26:3)
    at Generator.next (<anonymous>)
    at step (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:254:32)
    at evaluateAsync (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:284:5)
    at Function.errback (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/gensync/index.js:108:7)
    at errback (/Users/emcintyre/Development/src/sandbox/sb-ts-bug/node_modules/@babel/core/lib/gensync-utils/async.js:70:18)
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/generated-stories-entry.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false main[2]
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  6.49 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
    [./node_modules/<EMAIL_ADDRESS>2.14 KiB {HtmlWebpackPlugin_0} [built]

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

@macdaddyaz We know this is not working well for Vue right now and plan to deprecate this preset when Storybook 6 hits shortly.
In the meantime, can you modify the Webpack config in your project to match your Vue config?


Add stream support for typed notifications.

Adds three new types:
Stream: A way to listen to a sequence of values
Sink: A writeable stream
CancellingSink: A writeable stream that triggers a cancellation action if no one is watching it.
JIRA: https://openedx.atlassian.net/browse/MA-795

@hanningni please review

:+1:


make column as foreign for multiple tables

how can I implement making a column as foreign key for more than one table at the same time
without using views

Use [LeftJoin] attribute on top of the row, see mapping guide


[Improvement-14437][UI] Fixed the issue with failing to save the task for the HiveCLI task.

Purpose of the pull request
This PR will close #14437 .

Brief change log

Verify this pull request
This change added tests and can be verified as follows:

Manually verified the change by testing locally.

The test results are as follows:

Codecov Report

Merging #14438 (21829e8) into dev (f186cd5) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Current head 21829e8 differs from pull request most recent head c3e78ba. Consider uploading reports for the commit c3e78ba to get more accurate results

@@             Coverage Diff              @@
##                dev   #14438      +/-   ##
============================================
- Coverage     38.55%   38.53%   -0.03%
+ Complexity     4556     4551       -5
============================================
  Files          1236     1236
  Lines         43456    43408      -48
  Branches       4814     4782      -32
============================================
- Hits          16756    16727      -29
+ Misses        24842    24823      -19
  Partials       1858     1858

see 38 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BEAM-920] Support triggers, panes and watermarks.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @jbonofre

This PR provides initial support for the Beam Model in streaming via triggers, panes and watermarks.
Notes:

Tests backing this rely on CreateStreamTest which is Spark runner's equivalent of TestStreamTest in direct runner.
This is implemented for GroupByKey without Combine optimizations - those should be easy enough to follow.
This is not a full streaming support yet, and so ROS in streaming is not yet enabled - follow soon.

And finally; R: @kennknowles 😄

Coverage increased (+0.007%) to 69.17% when pulling 462f7b22b94d3528fff0a086f87a25630b748ca1 on amitsela:BEAM-920 into 4e5a762ef36336eeecb568f12c9f3b41fa683a97 on apache:master.

Fixing this now

Some test flakes may appear running on Jenkins (not locally) - I'm afraid it has to do with the timeout I provide for streaming tests and I'm not sure how to solve this.
One way would be a very generous timeout, on the expense of very long builds.
I could also try and come-up with a "kill-switch" once done.
Anyway, please review this in the meanwhile since it's not going to be a quick look anyway.

Coverage increased (+0.01%) to 69.173% when pulling 223129c4c8d5397528d008b849eeb81bdfc6b3b1 on amitsela:BEAM-920 into 4e5a762ef36336eeecb568f12c9f3b41fa683a97 on apache:master.

Now that functionality is nearing completion, perhaps some of the longer unit tests are covered by postcommit RunnableOnService tests? Otherwise we might consider moving some to postcommit.

Run Spark RunnableOnService

Actually unit tests take less time now, but it appears that to gain stability I might have to run them with a much longer timeout... so maybe post commit would be the compromise.

ROS failures look really weird mostly because ROS is not enabled for streaming yet, and I didn't change anything in batch. Also running ROS locally passes.

ROS profile inherited parallel all + me clearing Metrics between executions = stale state.
Current state was that "clear" didn't assign null and so following executions "enjoyed" a pre-existing instance (which is why it doesn't break master). Once it is cleared with null you could get hit by "race-like" behaviour between executions, hence the NPEs.

Run Spark RunnableOnService

Coverage remained the same at 69.163% when pulling ba43e6e6c7ca944ef8204a8a7c69af2b72faf773 on amitsela:BEAM-920 into 4e5a762ef36336eeecb568f12c9f3b41fa683a97 on apache:master.

While this review is in progress, I will think of maybe adding a "poison pill" event that kills the execution. This should allow to keep running this in pre-commit, once ROS-streaming is enabled it will rely on longer timeouts and run in post-commit (since I don't have access to the actual tests).

Maybe this is a good point to set up the pom.xml to have also a "force streaming" configuration.

After this PR I plan to remove force streaming. It was necessary since streaming/batch was decided based on Source type, but with Pipeline#replaceTransform I could replace any Read.Bounded with an adapted Read.Unbounded if options.isStreaming(). So the pom we'd be good as it is now.
Like I told you a few day ago, I plan to entirely separate batch/streaming because it appears that Spark doesn't support Flattening of RDDs (bounded) and DStreams (Unbounded) in a resilient manner.

Yes, it makes sense to remove force streaming.

Yup, was born in sin 😉

Rebased on master.

Coverage remained the same at 69.284% when pulling ae06c4f427a3297710031bdfe37ae9a7e05f0291 on amitsela:BEAM-920 into 5ca149de2eb7924a996902419ade156ca526412c on apache:master.

Rebased on master and wrapped triggers with Triggers.toProto.
Also got rid of the printouts in tests (stage progress).

retest this please

Changes Unknown when pulling 4448dda78e98ad79644c5af73716ceae6795ce70 on amitsela:BEAM-920 into ** on apache:master**.

Run Spark RunnableOnService

retest this please.

I've moved LateDataUtils and UnsupportedSideInputReader to core-runners (tested locally that it'd work with Direct runner and it did).

I'll check-up the issue of CreateStream and TimestampedValue though it's not trivial as it is not a "real" PTransform but a direct-translation (basically used as a vehicle).

Following this PR, the following tickets are to be handled (more or less in that order):
BEAM-785
BEAM-1444
BEAM-1564
BEAM-1562, BEAM-1563

BTW, what Rule rename did you mean (3 on your list) ? couldn't find it in the comments.

Changes Unknown when pulling cb1c1847a4c1e41dca0e98728eb380030cc6c01c on amitsela:BEAM-920 into ** on apache:master**.

@kennknowles updated according to your comments. Anything unattended should be covered by the specified tickets above.

OK. Let's just run the ROS again.

Run Spark RunnableOnService

Changes Unknown when pulling ee4d03af081710e25278840c0b8711934bd08a81 on amitsela:BEAM-920 into ** on apache:master**.

Changes Unknown when pulling ee4d03af081710e25278840c0b8711934bd08a81 on amitsela:BEAM-920 into ** on apache:master**.

Run Spark RunnableOnService

Changes Unknown when pulling c1966572bb744c6db605fd0d9de6a77c0cb7e1af on amitsela:BEAM-920 into ** on apache:master**.

Run Spark RunnableOnService

Changes Unknown when pulling<PHONE_NUMBER>28b07a128606035e37e1da7f1f6d52 on amitsela:BEAM-920 into ** on apache:master**.

So annoying... those tests require 2-3 seconds to execute, and they run for more than 5 seconds...
I can add more time, but eventually until we have a "poison pill" (that would only work on some of the tests, not ROS for example) if Jenkins is very slow this happens.
Just like the Dataflow service has issues sometimes (or gs or something else).
@kennknowles WDYT ? I can give it 10 seconds, and it could still flake sometimes..

retest this please

OK, LGTM to move forward since there are no regressions that are caught by testing. The timing on presubmit - 34 min - seems within reasonable bounds so I am OK to increase individual test timeouts for now if we need to. Worst case we just move all of CreateStreamTest to postcommit. Let's wait and see.
As far as blocking the release for it, or hyping it with this release, I don't think we should since the new functionality isn't protected by tests. But for getting early feedback, sure.

I'm only for blocking the release because I know it basically awaits merging. I agree about not "hyping", I'd wait with this a bit. But this could be good for "bleeding edge" users to get involved.

Got it. I understand now that even if we were to exercise --forceStreaming paths with our existing tests, they'd only have one microbatch so most of the coverage isn't that great. I still think we should do it just for completeness, but I agree we can go forwards right now.

I see some fixup! and other things that look like they are probably also fixups. Can you go ahead and squash as appropriate and merge when ready?

Merging, thanks!


Please help i have a big error

C:\Users\tommy\Desktop\Pemebots\feeder.js:406
if(valid_player_pos["suicide_targets"] == null){
^
TypeError: Cannot read property 'suicide_targets' of null
at Object.FeederBot.getCandidateBall (C:\Users\tommy\Desktop\Pemebots\feeder.js:406:36)
at Object.FeederBot.recalculateTarget (C:\Users\tommy\Desktop\Pemebots\feeder.js:485:34)
at null._repeat (C:\Users\tommy\Desktop\Pemebots\feeder.js:91:21)
at wrapper [as _onTimeout] (timers.js:275:11)
at Timer.listOnTimeout (timers.js:92:15)
C:\Users\tommy\Desktop\Pemebots>pause
Press any key to continue . . .
please help

Same thing,
This error only occurs when you have "config.botMode" set to "blind" in the config.js file.
I've tested it on windows and linux, both give me the same error.
I've also tested it on public and ogar servers, both give the same error.
Someone please help up out.

im curious does this let the bots follow you?

Agario has patched it!

Not patched i see a big mount of bots of diferents sites


Error display decimal divider for zero double value in Excel

Description
I have an error connected with displaying decimal divider for zero double value in Excel using custom NumberingFormat. I set FormatCode "0.####", it works fine for values like 3.4342, but fails for 0.0 (get 0.). I have tried to change FormatCode to "0.0###", when I do it, I got sheet error when open document.
I think it is a bug, as if I change cell type to string and use pattern "0.####" in C# ToString method for 0.0 value is displayed 0.
Information

.NET Target: .NET Core 2.0
DocumentFormat.OpenXml Version: 2.7.1

Repro
using (var document = SpreadsheetDocument.Create(filename, SpreadsheetDocumentType.Workbook))
{
    var workbookPart = document.AddWorkbookPart();
    workbookPart.Workbook = new Workbook();
    var worksheetPart = workbookPart.AddNewPart<WorksheetPart>();

    var sheetData = CreateContent();

    DefineStyles(document);
    worksheetPart.Worksheet = new Worksheet();
    worksheetPart.Worksheet.Append(sheetData);
    var sheets = document.WorkbookPart.Workbook.AppendChild(new Sheets());
    var sheet = new Sheet
    {
        Id = document.WorkbookPart.GetIdOfPart(worksheetPart),
        SheetId = 1,
        Name = Strings.SheetName
    };
    sheets.Append(sheet);

    workbookPart.Workbook.Save();
    document.Close();
}

private static SheetData CreateContent()
{
    var value = TimeSpan.Zero;
    var row1 = new Row {RowIndex = 1};
    var title = new Cell
    {
        CellReference = "A1",
        CellValue = new CellValue(value.TotalHours.ToString(CultureInfo.InvariantCulture)),
        DataType = CellValues.Number,
        StyleIndex = 1U
    };
    row1.Append(title);

    var sheetData = new SheetData();
   sheetData.Append(row1);

   return sheetData;
}

private static void DefineStyles(SpreadsheetDocument document)
{
    var stylesPart = document.WorkbookPart.AddNewPart<WorkbookStylesPart>();
    var stylesheet = new Stylesheet();

    var fonts = new Fonts();
    var font = new Font
    {
        FontName = new FontName
        {
            Val = "Calibri"
        },
        FontSize = new FontSize
        {
            Val = 11
        }
    };
    fonts.Append(font);
    fonts.Count = (uint) fonts.ChildElements.Count;

    var fills = new Fills();
    var fill = new Fill
    {
        PatternFill = new PatternFill
        {
            PatternType = PatternValues.None
        }
    };
    fills.Append(fill);
    fills.Count = (uint) fills.ChildElements.Count;

    var borders = new Borders();
    var border = new Border
    {
        LeftBorder = new LeftBorder(),
        RightBorder = new RightBorder(),
        TopBorder = new TopBorder(),
        BottomBorder = new BottomBorder(),
        DiagonalBorder = new DiagonalBorder()
    };
    borders.Append(border);
    borders.Count = (uint) borders.ChildElements.Count;

    var cellStyleFormats = new CellStyleFormats();
    var defaultCellFormat = new CellFormat
    {
        NumberFormatId = 0,
        FontId = 0,
        FillId = 0,
        BorderId = 0
    };
    cellStyleFormats.Append(defaultCellFormat);
    cellStyleFormats.Count = (uint) cellStyleFormats.ChildElements.Count;

    var numberingFormats = new NumberingFormats();
    //Style with bug
    var nFormat2Decimal = new NumberingFormat
    {
        NumberFormatId = 1U,
        FormatCode = StringValue.FromString("0.####")
    };
    numberingFormats.Append(nFormat2Decimal);

    var cellFormats = new CellFormats();
    defaultCellFormat = new CellFormat
    {
        NumberFormatId = 0,
        FontId = 0,
        FillId = 0,
        BorderId = 0,
        FormatId = 0
    };
    cellFormats.Append(defaultCellFormat);

    var timeDoubleCellFormat = new CellFormat
    {
        FontId = 0,
        FillId = 0,
        BorderId = 0,
        FormatId = 1U,
        NumberFormatId = 1U,
        ApplyNumberFormat = true
    };
    cellFormats.Append(timeDoubleCellFormat);

    var cellStyles = new CellStyles();
    var cellStyle = new CellStyle
    {
        Name = "Normal",
        FormatId = 0,
        BuiltinId = 0
    };
    cellStyles.Append(cellStyle);
    cellStyles.Count = (uint) cellStyles.ChildElements.Count;

    var differentialFormats = new DifferentialFormats {Count = 0};

    var tableStyles = new TableStyles
    {
        Count = 0,
        DefaultTableStyle = "TableStyleMedium9",
        DefaultPivotStyle = "PivotStyleLight16"
    };

    stylesheet.Append(numberingFormats);
    stylesheet.Append(fonts);
    stylesheet.Append(fills);
    stylesheet.Append(borders);
    stylesheet.Append(cellStyleFormats);
    stylesheet.Append(cellFormats);
    stylesheet.Append(cellStyles);
    stylesheet.Append(differentialFormats);
    stylesheet.Append(tableStyles);

    stylesPart.Stylesheet = stylesheet;
    stylesPart.Stylesheet.Save();
}

Sorry for long style definition, it seems it all is mandatory.
Observed

Expected

@QuarK264, thanks for reporting this issue. I’ll repro and investigate.

@tomjebo I don't understand, what do you mean, when you talk about ';' separated sections. I don't use them or I don't know about them.
Format code "#,##0.0000" doesn't fit to my situation, as I don't need thousand separator. I need the next format: at least zero or more figures before decimal separator (dot) and at least zero or up to 4 figures after dot. I see two possible formats for my case "0.####" and "0.0###". For floating point value 0.0 applying first format gives me string "0." (zero after dot is missing), applying second format gives me error when I am trying to open excel document, after its restore my numbers are restored as strings. First format may look strange, but I think it is possible, as native method string.Format works with it fine.
I hope, I described my problem more clearly.

@QuarK264 if you check the standard section I pointed to you'll see the ";" thing I mentioned. But anyway, I tested the following:
  <x:numFmts>     <x:numFmt numFmtId="1" formatCode="0.0###"/>   </x:numFmts>
And it works just fine for a value of 0.0.

And using "0.####" will indeed give you "0." in the cell because (check the definition of numFmt formatCode attribute) "#" means that extra 0's won't be displayed if there are fewer digits than the number of #'s.
If you are getting an error opening the workbook, it could be due to the version of Excel you're using. I'm using the latest but haven't tried previous versions.
In any case, the format string is correct but if Excel is behaving badly, this should be reported on the Excel usage support forums. It could be a bug in some version of Excel.

@QuarK264 this does not appear to be an SDK related issue. I'm closing this for now, but if you feel this is related to the SDK and not Excel, please reopen.


Updates the resolve fn to allow for stepping back a dynamic number of directories

I'm working on a project where I need to import components and tools from a directory above my project.
At first I was just path.join-ing the alias I needed, but when I looked at the js includes I realized I'd need to do that joining again.
I took a look at the resolve function and modified it a bit to allow me to tell it how many levels I'd like to step back to look for the directory. I added a default option of 1 so that it didn't break any other resolve calls.
It works nicely in my project so I thought I'd submit a pull request in case anyone else found it helpful.
Thanks for the consideration.

Hi @chris-schmitz
Thanks for the submission. I see the use this hase for you, but I think that it's not enough to create a new "syntax" around resolve.
The current resolve is pretty self-explanatory - your version will stump beginners and make them wonder where this is needed.
So I don't think we will add this.

Gotcha. No problem. I figured it may be too specialzed for my specific use case, just thought I'd offer it just in case. Thanks for considering it.


Use the new name for the Eventing Manager CR

Description
Due to the changes in Eventing Manager the default CR has changed. According to the new setup, the Eventing Manager has an empty backend per default. This means, during testing, the NATS backend needs to be set.
Changes proposed in this pull request:

Use the new name: eventing-default-cr
Use sample CR with NATS backend configured (not the default CR)

Related issue(s)

Pls remember to update the eventing manager README (section: Install) as well.

Fixed in: https://github.com/kyma-project/eventing-publisher-proxy/pull/65


Improve clarity around key and region

To reduce confusion, there should be more clarity about how the key and region are loaded from the environment variables.

Yes, that's true. I was too confused at first. If someone wants to try out the code quickly without making the .env file then they can add the key and region manually in quoted form but rather if someone wants to run the code in organized form then they can follow the Readme to better understand how to use the code.
ThankYou


Emergence

Emergence SDK
Emergence serves as a Web3 SDK tailored for game developers, seamlessly integrating with Unreal Engine and Unity through.
It provides features such as:

wallet authentication
smart contracts calls
NFT inventory services

For more information checkout the Emergence SDK documentation.

What is: SDK
Language: C++
Target: Unreal, Unity


Override Chakra UI component props

Would there be any interest in a PR that would allow users to override props for the Chakra Control Elements? This would allow greater control of styling without having to write some custom CSS.
Would look something like this in usage:
import QueryBuilder from 'react-querybuilder';
import { chakraControlElements as baseChakraControlElements } from '@react-querybuilder/chakra';
import { defaultQuery, fields } from './constants';

const chakraControlElements = {
  ...baseChakraControlElements,
  removeGroupAction: (props) => <ChakraActionElement {...props} buttonProps={{ colorScheme: 'red' }} />,
  removeRuleAction: (props) => <ChakraActionElement {...props} buttonProps={{ colorScheme: 'red' }} />,
}

export function App() {
  return (
    <QueryBuilder
      fields={fields}
      defaultQuery={defaultQuery}
      controlElements={chakraControlElements}
    />
  );
}

And the component:
import { Button, ButtonProps } from '@chakra-ui/react';
import type { ActionProps } from 'react-querybuilder';

export const ChakraActionElement = ({
  className,
  handleOnClick,
  label,
  title,
  disabled,
  disabledTranslation,
  buttonProps = {}
}: ActionProps & { buttonProps?: ButtonProps }) => (
  <Button
    className={className}
    title={disabledTranslation && disabled ? disabledTranslation.title : title}
    colorScheme="gray"
    variant="solid"
    onClick={e => handleOnClick(e)}
    size="xs"
    isDisabled={disabled && !disabledTranslation}
    {...buttonProps}>
    {disabledTranslation && disabled ? disabledTranslation.label : label}
  </Button>
);

ChakraActionElement.displayName = 'ChakraActionElement';

Alternatively in the component you could do something like this:
export const QueryBuilderActionElement = ({
  className,
  handleOnClick,
  label,
  title,
  disabled,
  disabledTranslation,
  level,
  path,
  context,
  testID,
  validation,
  ...buttonProps
}: ActionProps & ButtonProps) => { /* ... */ }

The main benefit would be allowing the user to do <ChakraActionElement {...props} colorScheme="red" />, but the drawback is that you would need to destructure all the ActionProps to avoid automatically passing them to the Chakra component. Chakra will automatically pass any additional prop to the DOM element resulting in warnings like this Warning: React does not recognize the "testID" prop on a DOM element..

Yeah, I've considered adding something like that. If we did add a way to pass other props, I'd like it to be as generic as possible (with a name like extraProps maybe?) so that the main package as well as all the compatibility packages could take advantage of it.

Something like this could work:
export interface CommonSubComponentProps<ExtraProps extends object = object> {
  /** ... */
  /**
   * Extra props to pass to compatibility package component
   */
  extraProps?: ExtraProps;
}

export interface ActionProps<ExtraProps extends object = object> extends CommonSubComponentProps<ExtraProps> {
  label?: string;
  handleOnClick(e: ReactMouseEvent): void;
  disabledTranslation?: TranslationWithLabel;
}

import { Button, ButtonProps } from '@chakra-ui/react';
import type { ActionProps } from 'react-querybuilder';

export const ChakraActionElement = ({
  className,
  handleOnClick,
  label,
  title,
  disabled,
  disabledTranslation,
  extraProps = {}
}: ActionProps<ButtonProps>) => (
  <Button
    colorScheme="gray"
    variant="solid"
    size="xs"
    {...extraProps}
    className={className}
    title={disabledTranslation && disabled ? disabledTranslation.title : title}
    onClick={e => handleOnClick(e)}
    isDisabled={disabled && !disabledTranslation}>
    {disabledTranslation && disabled ? disabledTranslation.label : label}
  </Button>
);

Yeah that's more like it. Want to start a PR with the basic modifications and we can collaborate on the final changes?

Sounds good @jakeboone02 . Probably won't be until early next week that I'm able to get the start of the PR in

No problem. I'm travelling next week so I'm not sure how much I'll be able to do anyway.

@kculmback-eig I went ahead and implemented this without the indirection of a new prop. Any props that can be passed to the style library's component will be accepted by the RQB compatibility component (and will override the defaults). So, for example, the @react-querybuilder/chakra component ChakraActionElement will now accept any props that Button from @chakra-ui/react will accept, and will pass them directly to its <Button /> rendering.
See #304 for an example implementation.


Adds some clarity in our development process

We want to avoid open source contributors going too far in a pull request and potentially ending up in a scenario where we need to close the pull request unmerged.
This helps attempt to clarify our process.

I'm going to close this unmerged. I have since moved off of Jira work. But anyone is welcome to revive this PR and re-apply it.


Data subject contact form

A new contact form should be added to retrieve and ask deletion for a users personal data stored by the Juice Shop.
This form should check for secret question and maybe some other (new) factor that makes it difficult - but not impossible - to forge for other users.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Seems interesting. Can I take this up?

Totally, yes! You could just start with the request form, and we can design a challenge into it afterwards? I was also thinking this would be a good place for the advanced CAPTCHA idea.

The advanced CAPTCHA? Not sure I follow :confused:
Sure, I will make the form. Really want to get into more Angular :smile:

In #784 having a better CAPTCHA than the math term to solve for feedback form was suggested. This could in fact be implemented on this data subject form, as Juice Shop support really wants to avoid spam here.

@bkimminich what all data should be removed? The past orders and reviews?

@aaryan01 Please let me know if you are working on this. If not I can start. @bkimminich

@agrawalarpit14 I have started working on it. Just needed some clarification from @bkimminich .

Sure. Thanks!!✌🏻

@aaryan01, I can start to work on the user data removal part of this issue if you are not currently working on it, along with the relevant tests. I guess this way we can complete both the parts in parallel. @bkimminich

Sure, I'm currently working on something else

Just to be clear, this feature does not delete anything. It is just meant to be a distinct contact form where users can ask for their personal data (which could just offer a link to "Data Export") or be deleted in accordance with GDPR. This could end up in the DB as a new table PrivacyRequests and have a free text column and a deletionRequested flag. Additional ideas are welcome.

@bkimminich, so should I keep the secret question as the authentication?
Apart from that, I plan to remove(hide) the same data that is exported in the data export feature. Is this implementation fine?


Morphing between different URLs

There's a scenario where I think morphing could be useful between different URLs.
Consider the following example (a 9mb gif screen recording below):

Let's say we have an image browser like the one above. The page structure is basically the same, only certain parts change when you select a different image. Because each image has a unique URL, morphing doesn't apply and scrollbars reset.
In this case, it would be great to be able to set something like <meta name="turbo-page-id" content="images#show"> and have Turbo use it to apply morphing between different URLs.

@pch I think turbo-frames solve your situation.
If you put the center column (or center + right column) within it's own <turbo-frame id="content"> then the thumbnails on the left can direct target that frame: <a href="/..." data-turbo-frame="content" data-turbo-action="advance">
This way the left column retains it's scroll position because only the <turbo-frame> DOM node will be replaced.


Low compression issue - IIS & ASP.Net Core

Hello,
I have developed the same application which delivers a JSON file in 2 different projects. One is based on ASP.Net MVC4 and the other is based on ASP.Net Core 1.1.0. The JSON generated by my controller is around 5Mo and its content-type is text/plain when returned to the client.
However when publishing the 2 apps, i have a difference of sizes for this file if it is compressed or not on both plateforms.
For ASP.Net Core, I have even tried to enable the compression middleware in the Startup.cs to see the difference:
    services.AddResponseCompression(
        options =>
            options.MimeTypes = ResponseCompressionMimeTypes.Defaults);

    app.UseResponseCompression()
       .UseStaticFiles();

This is the summary of my tests for my original 5Mo JSON returned to the client:
On my local IIS 7.5 with dynamic and static compression enabled, size of my JSON on:

MVC4: 256Ko
ASP.Net Core default: 1.3Mo
ASP.Net core with compression middleware: 869Ko

On my production IIS 7.5 with dynamic and static compression enabled, size of my JSON on:

MVC4: 136Ko
ASP.Net Core default: 675Ko
ASP.Net core with compression middleware: 869Ko

For MVC4, it seems that it is using full IIS compression capabilities.
For ASP.Net Core, when the compression is enabled in the Startup.cs, the size of the file is constant but not as small as it could be.
For ASP.Net Core, when the compression is not enabled in Startup.cs, the file is gzip by default but I am not sure it is even using the compression capabilities of the IIS server.
My question is what could I do to obtain a compressed JSON in ASP.Net Core as small as the one I obtained on my older plateform based on MVC4.
I tried to use RunIISPipeline as suggested here but it is no more available.
What are the best practices to publish on IIS an ASP.Net Core app and make sure that the compression is optimal?
Thanks
Sylvain

This issue was moved to aspnet/BasicMiddleware#205


gitea 1.5

When a team is set up as a management authority, the team warehouse is opened to 404.
If a team is set to write, all items are allowed to be used normally.
The gitea version is 1.5.
在把一个团队设置成为管理权限的时候，团队仓库打开就404；
如果把一个团队设置成为写入，全部项目允许，才能正常使用
gitea 版本是1.5

This has been fixed via #4719

error is


drivers: adc: adc_sam0: fix c20 and c21 reference not setting

drivers: adc: adc_sam0: fix c20 and c21 reference not setting
On c20 and c21 variants, the adc_sam0 driver is failing to honor the enable-protected status of the REFCTRL register when writing the channel config's reference into it. This causes the reference to never be set when adc_sam0_channel_setup is called since the ADC is not disabled prior to the write. Fix it by adding the ADC_SAM0_REFERENCE_ENABLE_PROTECTED definition to the c20 and c21 soc.h files. This effectively disables the ADC during writes to the REFCTRL register, thus honoring the enable-protected behavior of this register. I'm assuming ADC_SAM0_REFERENCE_ENABLE_PROTECTED exists for this type of situation and therefore this was the approach taken. After making the change, I was able to verify proper ADC readings by measuring voltage on an ADC pin and observing correct values. Reverting back prior to this change, running the same test yields reading 0's.
Fixes: #61975

Hi @tbitcs ,
Please fix the Compliance Check.


Why is PostgreSQL peer.address a JDBC string?

jdbc:postgresql://host:5432/database

Why? Do tools normally use JDBC URLs as an address?
All tools I know of, including psql, use the postgresql (or postgres) scheme.
psql postgresql://host:5432/database

I believe the spec require to use a common (eg: jdbc) format: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#connection-level-attributes-for-specific-technologies

In my reading, I don't see anything about peer.address (or net.peer.address).

Still have this question.
I don't see anything about peer.address in the standard.

It appears it is just drastically outdated. The spec at the time of writing the postgres instrumentation was this: https://github.com/open-telemetry/opentelemetry-specification/blob/c8109895a989480028b282fa796ed87ad1421b8a/specification/data-database.md which specified the JDBC substring.
The recent spec is quite different and requires:

db.system - postgresql
One of net.peer.name OR net.peer.ip - hostname or ip respectively
net.peer.port only if using nonstandard port
net.transport recommended in general, required only if using in-process - tcp or inproc

db.connection_string is not required but seems to be the replacement for the jdbc string.
This most likely also affects the mysql and mysql2 instrumentations

Created #781 to address this


⚠ gorzdrav.org has degraded performance

In 6a531ee, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1508 ms

Resolved: gorzdrav.org performance has improved in 688f954.


Hardcoded runtime image registry means third parties are unable to push image.

Is your feature request related to a problem? Please describe.
all run time images assume that the author is valory.
https://github.com/valory-xyz/open-autonomy/blob/fa1f616f3384b126175c515db27d4407d66cd65e/autonomy/constants.py#L60
This means that unless you have access to the valory docker repository, you are unable to make use of any deployment option other than building locally and running docker-compose.
Describe the solution you'd like
it would be great if there was either;
A) a flag that could be passed to autonomy build-image & autonomy deploy build
B) a way that i could configure the aea cli tool so that i could initialise with a docker registry.
i.e. aea init --docker-user-name 8ball030
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Addressed https://github.com/valory-xyz/open-autonomy/pull/1818


Fix pysh findings on make.sh.
Update go version to 1.18 to align with others (and go mod tidy to update go.sum).
Bring back vendor-folder (for Yocto builds), i.e. go mod vendor.
Update GitHub actions to run golint and pysh-check.

Builds w LmP w/o the loading exception.

e2e tests also pass.


Header labels overlap text

On the default theme, the header labels overlap the text like so.  It is the same for the other themes I have: Atom, Blue Topaz, Nord, Things, Red Graphite.

Only on the Minimal theme does it appear correctly.

I'm unsure what to change to get the other themes with the correct header label placement.

I have the same issue! Please, solve!

I have the same issue! Please, solve!
And as mentioned in https://github.com/liamcain/obsidian-lapel/issues/18#issue-1415510861 , on the Minimal theme it does not appear correctly.

v0.1.4 is now available and should have slightly better theme compatibility. Let me know if this is still an issue.


rtt_ros2_test_msgs: fix depencencies at build time

Fix
The package rtt_ros2_test_msgs depends on test_msgs already at build time, this patch fixes that.
Side effects
The problem pops when trying to build the package in a workspace where only ros-base is installed and is lacking
the test_msgs.

Actually the previous version was good. test_msgs is only needed it BUILD_TESTING is ON, so it is a pure test dependency. In any case the package needs to be installed to build and run the tests, and I do not see how switching from <test_depend> to <depend> has changed that.
<test_depend> are almost equivalent to <build_depend> dependencies except that are not required if unit tests are disabled at compile time (REP-0149 Package Manifest Format Three Specification).


Increase default ram for data platform services

merged into https://github.com/foxglove/helm-charts/pull/33


Redshift error in get_columns_in_relations macro

Describe the bug
Models using the get_columns_in_relations started to fail after the latest update of our Redshift instance on 2021-03-15. The issue is related with the return value count of the pg_get_late_binding_view_cols() function. Since the latest update of redshift on 2021-03-15, the pg_get_late_binding_view_cols() function returns 6 columns instead of 5 before the update.
Steps To Reproduce
Run select * from pg_get_late_binding_view_cols() cols(view_schema name, view_name name, col_name name, col_type varchar, col_num int); as used in the macro.
Expected behavior
The function pg_get_late_binding_view_cols() now returns 6 columns of metadata for all late-binding views, thus there needs to be added a column in the function call. Our hotfix was to override the macro by adding unknown_column int to the function call.
Screenshots and log output
2021-03-16 07:29:00.464247 (Thread-1): Using redshift connection "model.sevdesk_dbt_models.exchange_rates".
2021-03-16 07:29:00.464530 (Thread-1): On model.sevdesk_dbt_models.exchange_rates: /* {"app": "dbt", "dbt_version": "0.19.0", "profile_name": "newenv", "target_name": "dev", "node_id": "model.sevdesk_dbt_models.exchange_rates"} */

      with bound_views as (
        select
          ordinal_position,
          table_schema,
          column_name,
          data_type,
          character_maximum_length,
          numeric_precision,
          numeric_scale

        from information_schema."columns"
        where table_name = 'intermediate_exchange_rates'
    ),

    unbound_views as (
      select
        ordinal_position,
        view_schema,
        col_name,
        case
          when col_type ilike 'character varying%' then
            'character varying'
          when col_type ilike 'numeric%' then 'numeric'
          else col_type
        end as col_type,
        case
          when col_type like 'character%'
          then nullif(REGEXP_SUBSTR(col_type, '[0-9]+'), '')::int
          else null
        end as character_maximum_length,
        case
          when col_type like 'numeric%'
          then nullif(
            SPLIT_PART(REGEXP_SUBSTR(col_type, '[0-9,]+'), ',', 1),
            '')::int
          else null
        end as numeric_precision,
        case
          when col_type like 'numeric%'
          then nullif(
            SPLIT_PART(REGEXP_SUBSTR(col_type, '[0-9,]+'), ',', 2),
            '')::int
          else null
        end as numeric_scale

      from pg_get_late_binding_view_cols()
      cols(view_schema name, view_name name, col_name name,
           col_type varchar, ordinal_position int)
      where view_name = 'intermediate_exchange_rates'
    ),

    external_views as (
      select
        columnnum,
        schemaname,
        columnname,
        case
          when external_type ilike 'character varying%' or external_type ilike 'varchar%'
          then 'character varying'
          when external_type ilike 'numeric%' then 'numeric'
          else external_type
        end as external_type,
        case
          when external_type like 'character%' or external_type like 'varchar%'
          then nullif(
            REGEXP_SUBSTR(external_type, '[0-9]+'),
            '')::int
          else null
        end as character_maximum_length,
        case
          when external_type like 'numeric%'
          then nullif(
            SPLIT_PART(REGEXP_SUBSTR(external_type, '[0-9,]+'), ',', 1),
            '')::int
          else null
        end as numeric_precision,
        case
          when external_type like 'numeric%'
          then nullif(
            SPLIT_PART(REGEXP_SUBSTR(external_type, '[0-9,]+'), ',', 2),
            '')::int
          else null
        end as numeric_scale
      from
        pg_catalog.svv_external_columns
      where
        schemaname = 'dev_dwitkowski'
        and tablename = 'intermediate_exchange_rates'

    ),

    unioned as (
      select * from bound_views
      union all
      select * from unbound_views
      union all
      select * from external_views
    )

    select
      column_name,
      data_type,
      character_maximum_length,
      numeric_precision,
      numeric_scale

    from unioned

    where table_schema = 'dev_dwitkowski'

    order by ordinal_position

2021-03-16 07:29:00.784493 (Thread-1): Postgres error: query-specified return row and actual function return row do not match

2021-03-16 07:29:00.785223 (Thread-1): On model.sevdesk_dbt_models.exchange_rates: ROLLBACK
2021-03-16 07:29:00.813607 (Thread-1): Error running SQL: macro get_columns_in_relation
2021-03-16 07:29:00.814220 (Thread-1): Rolling back transaction.
2021-03-16 07:29:00.820376 (Thread-1): On model.sevdesk_dbt_models.exchange_rates: Close

System information
Which database are you using dbt with?

[ ] postgres
[x] redshift (cluster version 1.0.24470)
[ ] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
0.19.0

The operating system you're using: Windows 10
The output of python --version: 3.6.9

Gross! Ok, thanks for the report here @chodera. This isn't yet noted in Redshift's own documentation. The current query still works on my sandbox/testing Redshift cluster, which hasn't yet updated (still version 1.0.24265).
I figure we should try to get this fix out as soon as possible. In the meantime, I think your hotfix of overriding redshift__get_columns_in_relation is quite a good one.
It feels like the ideal resolution would check the Redshift version, and then template get_columns_in_relation according to whether the version is >= 1.0.24470. Unfortunately, because dbt uses Postgres logic to connect to Redshift (i.e. via psycopg2), there isn't anything useful available to the python/Jinja context:
>>> connection._handle.server_version
80002

So I see three possible implementations here:

Straightforward: Edit the macro redshift__get_columns_in_relation to first call a statement, select version();, and template itself according to the result.
Complex: A new method on RedshiftConnectionManager or RedshiftAdapter that, after initializing, runs select version(); once, stores the result, and offers a method that exposes the value to the Jinja context.
Disengaged: We game this fix around the Redshift release schedule, and tell users to manually patch this macro in the meantime.

What do you think? Is this a change you'd be interested in contributing?

Since a couple of days, the function does work the same way as it did before! So we reverted our override and are back to normal. I did not see anything related in the Redshift Forum Announcements which makes me doubt Redshift's update policy...
I will close the issue for now, but feel free to reopen it in case you still see the need to take action

That's great news @chodera! Glad this is back to working as documented


Bug: Krun: Domain values for Bytes in Kore is not consistent between frontend and haskell backedn

K Version
$ kompile --version
RV-K version 1.0-SNAPSHOT
Git revision: ada1ae8
Git branch: UNKNOWN
Build date: Sun Nov 29 17:43:14 CST 2020

Description
The Frontend produces kore that the backend cannot consume.
The empty Bytes produced by the front end is represented by \dv{SortBytes{}}("b\"\"").
The backend produces \dv{SortInt{}}("0") instead.
The frontend is able to consume the backend's version, but kore-exec chokes on kore produced by the frontend.
Since kore is the language that the various K tool use to communicate is important that the various tools have the same notion of kore.
Input Files
$ cat test.k
module TEST
    imports BYTES
    configuration <k> Int2Bytes(0, 0, LE) </k>
endmodule

Produces this kore with krun:
$ krun --debug --verbose --output kore
Parse command line options                                   =  0.023s
Executing command: kore-exec /.../test-kompiled/definition.kore --module TEST --pattern /.../.krun-2020-.../execute-initial.kore --output /..../.krun-2020-.../execute-result.kore
inj{SortGeneratedTopCell{}, SortKItem{}}(Lbl'-LT-'generatedTop'-GT-'{}(Lbl'-LT-'k'-GT-'{}(kseq{}(inj{SortBytes{}, SortKItem{}}(\dv{SortBytes{}}("b\"\"")),dotk{}())),Lbl'-LT-'generatedCounter'-GT-'{}(\dv{SortInt{}}("0"))))

However, the kore produced by kore-exec is:
/* Fl Fn D Sfa Cl */
Lbl'-LT-'generatedTop'-GT-'{}(
    /* Fl Fn D Sfa Cl */
    Lbl'-LT-'k'-GT-'{}(
        /* Fl Fn D Sfa Cl */
        kseq{}(
            /* Fl Fn D Sfa Cli */
            /* Inj: */ inj{SortBytes{}, SortKItem{}}(
                /* Fl Fn D Sfa Cl */ \dv{SortBytes{}}("")
            ),
            /* Fl Fn D Sfa Cl */ dotk{}()
        )
    ),
    /* Fl Fn D Sfa Cl */
    Lbl'-LT-'generatedCounter'-GT-'{}(
        /* Fl Fn D Sfa Cl */ /* builtin: */ \dv{SortInt{}}("0")
    )
)

Reproduction Steps
Steps to reproduce the behavior (including code blocks with what to run, and code blocks with resulting output).
Examples:
Kompiling produces a weird error:
$ kompile --backend llvm --some-weird-option test.k
SOME WEIRD ERROR MESSAGE

Running on LLVM backend causes a segfault when division by zero:
$ kompile test.k --backend llvm
Successful kompilation
$ krun input.test
Aborted: some cryptic LLVM backend stuff. Segfault. Panic.

Expected Behavior
Backend and Frontend should use the same format for bytestrings.

Basically, it looks like the code path that converts our kast data structures back to kore is not invoking the code to convert this back to the kore representation. It's unfortunately not possible to use the same representation both places, but it ought to still be fixable.

When converting K back to Kore, you need to de-escape Byte and String. String may already be handled, so look for that code.

Also, looking at the issue, it appears that there is an extra injection being added at the top of term from KItem -> GeneratedTopCell, even though the term underneath is already a GeneratedTopCell. So when converting K -> Kore, we need to also pass in an expected sort which the algorithm takes into account.

@nishantjr I think I have a quick fix for the Haskell backend, but I'm not sure about the LLVM. Can you provide more details for that?
I'm not sure what this is: --some-weird-option and the contents of input.test. And probably test.k changes also since you have input now.

@radumereuta I've been able to unblock myself re this bug, by using the K internal plumbing directly (llvm-krun), instead of krun. I'm not sure I understand why the fix woud be different for LLVM vs Haskell? Wouldn't this issue happen whenever the frontend performs kore to kore parsing/unparsing?
Oh, that last section is accidentally left over from the template. I'll fix it.

When going from Kore to K (the Java/Scala internal representation) Bytes and Strings get escaped:
https://github.com/kframework/k/blob/master/kore/src/main/scala/org/kframework/parser/kore/parser/KoreToK.scala#L161
(Let it be noted that I don't agree with this representation)
The problem was they were not being escaped back when converting from K to Kore:
https://github.com/kframework/k/blob/master/kernel/src/main/java/org/kframework/backend/kore/ModuleToKORE.java#L1878
So this is my quick fix.
kx works fine because it just dumps the output from the Haskell backend. In the regression-tests, kx is also the default runner for the llvm-backend and haskell-backend.


Change Foldable to Filterable on List.filter for FL Compliance

This PR addresses #237
I'm not sure if we need to change this in the pointfree docs - I see that most functions don't represent a typeclass. Thoughts?

Coverage remained the same at 100.0% when pulling 30b6c5edc0bd046fc8899d79c4cd5082a6a665cb on issue-237 into 4ab96f5d3616b5b70aaebe1725bfe761a0d3b3db on master.


[iOS] ListView items with TouchEff.NativeAnimation stop being tappable when user slides finger and it exits the native animation

TouchView 4.1.78
iOS 14.0.1
XF 4.8.0 sr3
Rg.Plugins.Popup <IP_ADDRESS>
I've got a page with a list of items, structured as shown below (simplified to the basics)
If I put a finger on an item, it'll change colour slightly (as per NativeAnimation setting on iOS).
If I then move the finger slightly, the NativeAnimation effect goes away, which is expected, as it starts switching into scrolling the list.
You can now observe that:

the item you were pressing down on will still produce the NativeAnimation when touched.
the item you were pressing down on will no longer be tappable (ItemTapped doesn't get triggered?)
other items will still work fine, and you can break as many items as you want by following the same steps as above.

The weird part is that I've got another page with a similar ListView and on that other page (which is not a popup page) and I can't reproduce the issue there at all.
Unfortunately I am unable to debug the iOS app at the moment, so I can only report on what I can see, and not on is happening under the hood.
Any ideas on what might be happening?
<popup:PopupPage>
	<Grid>
		<ListView BindingContext="{Binding}"
				  HasUnevenRows="True"
				  HorizontalOptions="Fill"
				  HorizontalScrollBarVisibility="Never"
				  IsPullToRefreshEnabled="False"
				  ItemTapped="Item_Tapped"
				  ItemsSource="{Binding Items}"
				  SelectionMode="None"
				  SeparatorVisibility="None"
				  VerticalOptions="Start">
			<ListView.ItemTemplate>
				<DataTemplate>
					<ViewCell>
						<ViewCell.View>
							<Grid BackgroundColor="{DynamicResource ThemedItem}"
								  ColumnDefinitions="Auto,*,Auto"
								  RowDefinitions="Auto"
								  RowSpacing="0"
								  touch:TouchEff.NativeAnimation="True">
								<Label Grid.Row="0"
									   Grid.Column="0"
									   LineBreakMode="TailTruncation"
									   Text="{Binding Number}"
									   VerticalOptions="Center" />

								<Label Grid.Row="0"
									   Grid.Column="1"
									   LineBreakMode="TailTruncation"
									   Text="{Binding Title}"
									   VerticalOptions="Center" />
								<Label Grid.Column="2"
									   Text="edit"
									   VerticalOptions="Center" />
							</Grid>
						</ViewCell.View>
					</ViewCell>
				</DataTemplate>
			</ListView.ItemTemplate>
		</ListView>
	</Grid>
</popup:PopupPage>

Frankly speaking, I have no idea why it can happen :(

I'm sure I can find several workarounds for this but if I have the chance to debug this behaviour in the future I'll have a look.
From your answer I assume you've come across this issue as well - not sure I'll be able to do any better but I can try :)

Please use TouchEff command instead ItemTapped event in this scenario 👍
I think this workaround is enough for now


Terminal "cls" not working expected

Issue Type: Bug
on Windows 10 Home Insider version 18362.53
After using "cls", previous output still show in the terminal(powershell)
VS Code version: Code - Insiders 1.34.0-insider (7a07992127a6ff176f0ed073d0698d81d09fc4bb, 2019-04-11T05:20:32.584Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.95GB (3.64GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

latex-preview
ajs
0.5.1

vscode-django
bat
0.19.0

jupyter
don
1.1.5

python-extension-pack
don
1.4.0

code-runner
for
0.9.8

latex-workshop
Jam
6.3.0

MagicPython
mag
1.1.0

vscode-language-pack-zh-hans
MS-
1.33.2

python
ms-
2019.3.6558

cpptools
ms-
0.22.2-insiders

html-preview-vscode
tht
0.2.5

vscodeintellicode
Vis
1.1.5

jinja
who
0.0.8

For what it's worth, we cannot reproduce this on the Terminal team. Neither VSCode nor another ConPTY consumer we use for testing recapitulates this behavior.

@DHowett-MSFT this one's already fixed, it was caused because ECH wasn't flagging lines to be re-rendered. Has been a bug for years going back to term.js but only conpty emits it enough to make the bug obvious https://github.com/microsoft/vscode/issues/72708

Thanks for the heads up!


Source Maps being written twice

https://discourse.roots.io/t/sourcemaps-no-longer-working-as-expected-with-sage-update/3022
I just confirmed with a fresh Sage install that the source maps are being written directly into the main.css file as well as the main.map.css file.
Diffing a project that's not having the issue, the only difference in the gulpfile.js is this:
<   gulp.watch(['bower.json'], ['wiredep']);
---
>   gulp.watch(['bower.json', 'assets/manifest.json'], ['build']);

Doesn't seem connected, since it's in the watch task

Confirmed

trying to debug. disabling pleeease's minification makes the sourcemap work as expected:
      .pipe($.pleeease, {
        minifier: false,
        autoprefixer: {
          browsers: [
            'last 2 versions', 'ie 8', 'ie 9', 'android 2.3', 'android 4',
            'opera 12'
          ]
        }
      })

Solved it. Thanks!

disabling pleeease's minification doesn't fix the issue for me. it does change the way source maps work. before the source maps referenced only the first line of the main.css. now they reference the .less files but the line numbers and in some cases even the .less files are off. IE: if i add background-color: red; to <body> in _global.less the source maps points me to grid.less:43 and the source map still get's compiled in main.css in the sourceMappingURL as base64 encode.

Not fixed. Same issue as slobich above!

switching to pleeease 3.2.0 works for me. add the following to your package.json's devDependencies:
    "pleeease": "3.2.0",

example of full package.json:
{
  "name": "sage",
  "version": "8.1.0",
  "author": "Ben Word<EMAIL_ADDRESS>  "homepage": "https://roots.io/sage/",
  "private": true,
  "repository": {
    "type": "git",
    "url": "git://github.com/roots/sage.git"
  },
  "bugs": {
    "url": "https://github.com/roots/sage/issues"
  },
  "licenses": [
    {
      "type": "MIT",
      "url": "http://opensource.org/licenses/MIT"
    }
  ],
  "scripts": {
    "build": "bower install && gulp",
    "jshint": "gulp jshint",
    "jscs": "jscs gulpfile.js assets/scripts/*.js"
  },
  "engines": {
    "node": ">= 0.12.0",
    "npm": ">=2.1.5"
  },
  "devDependencies": {
    "pleeease": "3.2.0",
    "asset-builder": "^1.0.1",
    "browser-sync": "^2.0.1",
    "del": "^1.1.1",
    "gulp": "^3.8.10",
    "gulp-changed": "^1.1.0",
    "gulp-concat": "^2.3.4",
    "gulp-flatten": "0.0.4",
    "gulp-if": "^1.2.5",
    "gulp-imagemin": "^2.0.0",
    "gulp-jshint": "^1.8.4",
    "gulp-less": "^3.0.1",
    "gulp-load-plugins": "^0.8.0",
    "gulp-pleeease": "^1.1.0",
    "gulp-plumber": "^1.0.0",
    "gulp-rename": "^1.2.0",
    "gulp-rev": "^3.0.0",
    "gulp-sass": "^1.2.4",
    "gulp-sourcemaps": "^1.1.1",
    "gulp-uglify": "^1.0.1",
    "imagemin-pngcrush": "^4.0.0",
    "jshint-stylish": "^1.0.0",
    "lazypipe": "^0.2.2",
    "merge-stream": "^0.1.7",
    "traverse": "^0.6.6",
    "wiredep": "^2.1.0",
    "yargs": "^3.2.1"
  }
}

Do you still have minifier: false,? Just updating pleeease din't fix it on my end. Actually neither works for me at all. A few elements map to the right place but for the most part its basically random.
If I don't have minifier: false, within gulp it actually just says every class is from font-awesome.css which i installed via bower.

no, i don't — stock gulpfile. just to confirm, you ran npm install after making the change to package.json?

Yup. When that did nothing I also ran npm update.

Just to be a bit more verbose...
On a plain vanilla sage install, I get main.css as the source of all styles. To reproduce:
Install WP
add define('WP_ENV', 'development'); to wp-config.php
Pull Sage
npm install and bower install
activate theme
add body{background: black} to _global.less
run gulp
view site
inspect body
source shows main.css:1

@stueynet I wouldn't run npm update, I would delete the node_modules folder and run npm install again.
So along with your instructions, you need to add "pleeease": "3.2.0", to package.json, above "gulp-pleeease": "^1.1.0",, before running npm install

working for me. but it didn't work with npm install or npm update. i had to manually delete node_modules folder (and i deleted dist folder as well). tried it on two local sites. one with Sage 8.1.0 and one with 8.0.1 and it's working on both. and it's fixed both issues: source map compiled in main.css and source map wrong line/file reference.

just was @kalenjohnson comment. so yes... i did it like he recommends. first deleted node_modules and then run npm install and it worked for me.

Yup confirmed. Sorry about my ignorance. First delete node modules and then npm install works.

As stueynet stated, First delete node_modules and then run nom install worked perfectly !

confirmed that fix works. Delete node_modules first.


ci: skip update readme if dependabot due to permission issues

Description
This pull request changes the following:

Skip update readme flow when ran by dependabot as it doesn't have access

Related Issues

Closes #687

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@release-0.31.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Apk for version 0.4.4

Hi,
may you can upload the apk for the version 0.4.4 ?
Would be happy to test the lane detection a little bit.
How does the lane detection work generally (how do you get the information for lanes)?
Niklas

Hi
I update version because add new function.
But I don't test it yet, so I would release apk after testing.
Lane detection is captured with  screenshot every 2 seconds, so I cannot use complicated mechanism to detect.
I detect the green background of lane to locate the lane zone, and detect the white arrow to judge how many lanes here.

Please enjoy it.
https://github.com/skyforcetw/Garminuino/releases/tag/0.4.4

Lane detection is captured with screenshot every 2 seconds, so I cannot use complicated mechanism to detect.
I detect the green background of lane to locate the lane zone, and detect the white arrow to judge how many lanes here.

Nice idea!

Please enjoy it.

Thanks!
I've tested it a little bit, but unfortunately, no lane information had been displayed. Maybe it needs some more testing.
Furthermore, at the second run the app keeps crashing, but I don't have any idea why.
(In the first run I activated all switches (show speed, lane detect, show ETA, ...)
First scenario:
Bluetooth turned off. The app opens and shows the normal screen. Popup shows that app will be recording all activities. App crashed. In the background: Popup for activating bluetooth had been opened.
Terminal showed the following error code:
2019-08-14 21:32:56.019 27779-27779/? E/AndroidRuntime: FATAL EXCEPTION: main     Process: sky4s.garminhud.app, PID: 27779     java.lang.RuntimeException: Error receiving broadcast Intent { act=sky4s.garminhud.app.MainActivity.RECEIVER flg=0x10 (has extras) } in sky4s.garminhud.app.MainActivity$MsgReceiver@26ea88b         at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0(LoadedApk.java:1401)         at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)         at android.os.Handler.handleCallback(Handler.java:873)         at android.os.Handler.dispatchMessage(Handler.java:99)         at android.os.Looper.loop(Looper.java:193)         at android.app.ActivityThread.main(ActivityThread.java:6718)         at java.lang.reflect.Method.invoke(Native Method)         at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)      Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int app.akexorcist.bluetotohspp.library.BluetoothService.getState()' on a null object reference         at app.akexorcist.bluetotohspp.library.BluetoothSPP.send(BluetoothSPP.java:280)         at sky4s.garminhud.GarminHUD.SendPacket(GarminHUD.java:66)         at sky4s.garminhud.GarminHUD.SendHud2(GarminHUD.java:118)         at sky4s.garminhud.GarminHUD.SetDistance(GarminHUD.java:194)         at sky4s.garminhud.hud.HUDAdapter.SetDistance(HUDAdapter.java:17)         at sky4s.garminhud.app.MainActivity.setSpeed(MainActivity.java:237)         at sky4s.garminhud.app.MainActivity.access$2400(MainActivity.java:86)         at sky4s.garminhud.app.MainActivity$MsgReceiver.onReceive(MainActivity.java:1001)         at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0(LoadedApk.java:1391)         at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)          at android.os.Handler.handleCallback(Handler.java:873)          at android.os.Handler.dispatchMessage(Handler.java:99)          at android.os.Looper.loop(Looper.java:193)          at android.app.ActivityThread.main(ActivityThread.java:6718)          at java.lang.reflect.Method.invoke(Native Method)          at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)          at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
I think the problem is somewhere in line 1001 of MainActivity.java
Second scenario:
Bluetooth activated. App tries to open but closes immediately.
Terminal shows the following error:
2019-08-14 21:44:47.178 29597-29597/? E/AndroidRuntime: FATAL EXCEPTION: main     Process: sky4s.garminhud.app, PID: 29597     java.lang.RuntimeException: Unable to start activity ComponentInfo{sky4s.garminhud.app/sky4s.garminhud.app.MainActivity}: java.lang.IllegalArgumentException: GARMIN HUD is not a valid Bluetooth address         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2951)         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3086)         at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)         at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)         at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)         at android.os.Handler.dispatchMessage(Handler.java:106)         at android.os.Looper.loop(Looper.java:193)         at android.app.ActivityThread.main(ActivityThread.java:6718)         at java.lang.reflect.Method.invoke(Native Method)         at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)      Caused by: java.lang.IllegalArgumentException: GARMIN HUD is not a valid Bluetooth address         at android.bluetooth.BluetoothDevice.<init>(BluetoothDevice.java:769)         at android.bluetooth.BluetoothAdapter.getRemoteDevice(BluetoothAdapter.java:647)         at app.akexorcist.bluetotohspp.library.BluetoothSPP.connect(BluetoothSPP.java:239)         at sky4s.garminhud.app.MainActivity.init_bt(MainActivity.java:302)         at sky4s.garminhud.app.MainActivity.onCreate(MainActivity.java:343)         at android.app.Activity.performCreate(Activity.java:7144)         at android.app.Activity.performCreate(Activity.java:7135)         at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2931)         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3086)          at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)          at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)          at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)          at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)          at android.os.Handler.dispatchMessage(Handler.java:106)          at android.os.Looper.loop(Looper.java:193)          at android.app.ActivityThread.main(ActivityThread.java:6718)          at java.lang.reflect.Method.invoke(Native Method)          at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)          at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Thing error should be somewhere in line 301/302 in MainActivity.java .
Maybe you can fix these errors. I'm not anymore familiar with the whole code.

Thanks for your comment.
I think I mess up the bluetooth connection.
I will test it more.

Hello skyforcetw,
some days ago I've discovered your garminuino project. I am very happy that I can continue to use my Garmin HUD thanks to your software. Thank you very much for your effort and work.
Yesterday I've installed and tested version 4.4 on my cell phone (Android 8.0) and discovered two bugs:

At the first run it works out-of-the box. The display of lane information worked without any problems - even over a longer distance (>100 km). However, the lane information displayed on the HUD is displayed inversely to the GoogleMaps app on the cell phone.
For example, if GoogleMaps displays the right lane of three available lanes, the left lane will be displayed on the HUD. The behavior is reproducible with other lane combinations as well:
GoogleMaps displays the left of four available lanes, the right lane is displayed on the HUD.
GoogleMaps displays the middle of three available lanes, the middle lane is displayed on the HUD.

At the second run the app crashed and keeps crashing. Turning Bluetooth on and off or dis- and reconnect the HUD has not changed anything. The app did not work or started until I cleared the apps cache as well as the apps memory to soft-reset the app (not reinstalled!).

I'll take a look at the source code at the weekend to contribute a little bit more than just a description of the error.
Best greetings!

Hi zornhub :

It looks like I forgot the HUD is mirror!

2.I add bluetooth reconnect mechanism after 1st bt connection, but some bugs there.
In other words the bug appear after 1st bt connection.
I will remove the reconnect mechanism first.
Thanks for your contribution.
skyforce

One question regarding to lane information:
Do you have the old or the new UI of Google Maps?

Niklas04:
The app can recognize it .
There are some different in color between old & new google map ( I call it v1 & v2).
skyforce

Is anyone want to try this release?
https://github.com/skyforcetw/Garminuino/releases/download/0.4.4/gmaps_hud-release_v0.4.4.apk
Because of  I don't have time and no car to test except weekend.
I appreciate if someone can test it.
I fix:

Lane arrow mirror problem
Don't use new bt reconnect(bind address) mechanism in default. (There is a switch can turn on)

The app can recognize it .
There are some different in color between old & new google map ( I call it v1 & v2).

Ok

Is anyone want to try this release?

I'd made a short test:
BT reconnect seems to work with and without bind address enabled
But if I disabled bluetooth after first run, the app crashed on the second run.
Same error as mentioned above.
I think you want to set speed in line 975 (MainActivity.java), but bluetooth is not enableed. So the app crashed.
 But if I close the app the symbol will not disappear.
Maybe the screencapture-service has to be stopped in onDestroy-function
Lane detection seems to still not work on my device.

The app can recognize it .
There are some different in color between old & new google map ( I call it v1 & v2).

Ok

Is anyone want to try this release?

I'd made a short test:
BT reconnect seems to work with and without bind address enabled
But if I disabled bluetooth after first run, the app crashed on the second run.
Same error as mentioned above.
I think you want to set speed in line 975 (MainActivity.java), but bluetooth is not enableed. So the app crashed.

It's weird , is there no any dialog about bluetooth when you disable BT?

If you press deny, the app will terminated and show "Bluetooth was not enabled.

 But if I close the app the symbol will not disappear.
Maybe the screencapture-service has to be stopped in onDestroy-function
Lane detection seems to still not work on my device.
Ok, I will stop screen capture service at onDestroy, what symbol are you see? Do you have any screenshot?

It's weird , is there no any dialog about bluetooth when you disable BT?

Yes, there is, but before I can click allow the app had already crashed.
I think the MessageReceiver and the setSpeed-function had been executed before Bluetooth could be activated.

Ok, I will stop screen capture service at onDestroy, what symbol are you see? Do you have any screenshot?

Perfect! Yes, it's that symbol:

It's weird , is there no any dialog about bluetooth when you disable BT?

Yes, there is, but before I can click allow the app had already crashed.
I think the MessageReceiver and the setSpeed-function had been executed before Bluetooth could be activated.

Yes, you are right, I add bluetooth checking  before any BT operation to avoid same situation.

Ok, I will stop screen capture service at onDestroy, what symbol are you see? Do you have any screenshot?

Perfect! Yes, it's that symbol:

Got it.

I update the version to 0.4.5.
And fix the bugs that we talk about in this thread.
https://github.com/skyforcetw/Garminuino/releases/download/0.4.5/gmaps_hud-release_v0.4.5.apk

Thanks.
Yes now the Bluetooth connection seems to working fine.
Only autoconnect doesn't work, if Bluetooth hasn't be enabled before starting the app.
Just downloaded the whole project and opened it in AndroidStudio.
Maybe that will helped you to get the lane detection to work:

Can't do anything with that, without work in the code.
That was the test case:

Thanks.
Yes now the Bluetooth connection seems to working fine.
Only autoconnect doesn't work, if Bluetooth hasn't be enabled before starting the app.
Stopping screen capture service with closing the app seems to work too.
Just downloaded the whole project and opened it in AndroidStudio.
Maybe that will helped you to get the lane detection to work:

Can't do anything with that, without work in the code.
This was the test case:

Thanks for your information.
I think it is cons of using simple color detection to judge lane.
I release new version here:
https://github.com/skyforcetw/Garminuino/releases/download/0.4.6/gmaps_hud-release_v0.4.6.apk

Thank you.
I did a quick test and it seems to work :D


Websockets not working ?

Hi,
I cannot get Websockets to work using the code example :
const websocket = async () => {   const ws = new WebSocket('wss://tennis.sportdevs.com/live/score?token={myapikey}', ['updates'])   ws.addEventListener('message', ev => console.log(ev.data)) }
I get this error :
Error: Unexpected server response: 401
Any idea how to make it work ?
Thank you in advance

I also have this issue


Allow setting node port for NodePort typed service

If the service type is set to NodePort, k8s creates a random port if the nodePort property isn't set. This isn't usefull if RabbitMq should be accessible from outside of the cluster

Thanks for the contribution, before continue you should increment the chart version in the Chart.yml according to semver:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.
Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.

/lgtm
/ok-to-test

This commit introduces a bug... NodePorts don't work below 30.000 this never can work at all.
I'll open an issue as well as I'll try to make a PR for fixing it.
The mentioned article isn't about K8 NodePorts at all ..

This PR breaks ServiceType NodePort completely...
The nodePort variable in fact should be named amqpPort.
Setting the K8 NoePort needs to be something above 30.000 This will never work as intended. It should be considered to also switch config names here...


Release/v2.1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 9 committers have signed the CLA.:white_check_mark: igrr:white_check_mark: psiphi75:x: TimXia:x: jack0c:x: projectgus:x: costaud:x: TianHao-Espressif:x: liuzfesp:x: wmy-espressifYou have signed the CLA already but the status is still pending? Let us recheck it.

Is there anything specific you're trying to say with this pull request? If not, I'm going to close this assuming you pressed the wrong button somewhere.


Add Cop.documentation_url

Add Cop.documentation_url. This returns a full URL for builtin cops, nil for others.
Should be easy for other cops (e.g. rubocop/rspec) to override and return their own URL.

Includes #8578

I've needed this for a while for cookstyle. Thanks @marcandre

Looks good!


Potentially uninitialised variable nu

In os_cartesian_to_lat_lon() (os_coord_transform.c::54) the value of nu is potentially uninitialised before use on line 64 if the while loop at line 55 is not entered.

I can see that this potentially an issue, which appears in the code I've used from https://github.com/mossblaser/os_coord which hasn't changed in 11 years. This in turn was based on another repository by  Chris Veness. The latest relevant code is at https://github.com/chrisveness/geodesy/blob/master/osgridref.js#L89
I don't know the algorithm being used. The lat_lon.eh value being set is the Ellipsoidal height which I don't knowingly use. I imagine that nu could be initialised to zero and that would be fine.


[Build fail] mp4parse now will cause 'error[E0277]: cannot multiply u64 by NonZeroU8'

Now I can confirm that mp4parse 0.12.0 does not compile, and the latest version in repo is 0.17.0, which is OK.
But the latest release version is 0.12.0. So how should I make fselect compile? Thanks!

Hi, just checked that fselect compiles successfully on Ubuntu 22 LTS and Win11. What's your OS/compiler/Rust version?
Please make sure that you use the latest version of Rust:
rustup update

As for mp4parse, there are no plans to vendor the latest 0.17.0 version, I guess fselect will stick to the latest release version of that.

Sorry for not giving the compile environment. For me, I use:

Ubuntu 22.40
rust version 1.71.0-nightly (74c482104 2023-05-04)

Both cargo install select and cargo install --git https://github.com/jhspetersson/fselect.git will cause the same error. And i can confirm that mp4parse 0.12.0 could not be compiled, but not 0.17.0.

The error message would be:
   ...
   Compiling chrono-english v0.1.7
   Compiling mp4parse v0.12.0
error[E0277]: cannot multiply `u64` by `NonZeroU8`
    --> /home/winterreise/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mp4parse-0.12.0/src/lib.rs:2547:62
     |
2547 |                 static_assertions::const_assert!(<$lhs>::MAX * <$rhs>::MAX <= <$output>::MAX);
     |                                                              ^ no implementation for `u64 * NonZeroU8`
...
2557 | impl_mul!((U8, std::num::NonZeroU8) => (U16, u16));
     | -------------------------------------------------- in this macro invocation
     |
     = help: the trait `Mul<NonZeroU8>` is not implemented for `u64`
     = help: the following other types implement trait `Mul<Rhs>`:
               <&'a u64 as Mul<u64>>
               <&u64 as Mul<&u64>>
               <u64 as Mul<&u64>>
               <u64 as Mul>
     = note: this error originates in the macro `impl_mul` (in Nightly builds, run with -Z macro-backtrace for more info)

   Compiling csv v1.2.1
note: erroneous constant used
    --> /home/winterreise/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mp4parse-0.12.0/src/lib.rs:2557:1
     |
2557 | impl_mul!((U8, std::num::NonZeroU8) => (U16, u16));
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this note originates in the macro `static_assertions::const_assert` which comes from the expansion of the macro `impl_mul` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: cannot multiply `u64` by `NonZeroU8`
    --> /home/winterreise/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mp4parse-0.12.0/src/lib.rs:2547:62
     |
2547 |                 static_assertions::const_assert!(<$lhs>::MAX * <$rhs>::MAX <= <$output>::MAX);
     |                                                              ^ no implementation for `u64 * NonZeroU8`
...
2558 | impl_mul!((U32, std::num::NonZeroU8) => (U32MulU8, u64));
     | -------------------------------------------------------- in this macro invocation
     |
     = help: the trait `Mul<NonZeroU8>` is not implemented for `u64`
     = help: the following other types implement trait `Mul<Rhs>`:
               <&'a u64 as Mul<u64>>
               <&u64 as Mul<&u64>>
               <u64 as Mul<&u64>>
               <u64 as Mul>
     = note: this error originates in the macro `impl_mul` (in Nightly builds, run with -Z macro-backtrace for more info)

note: erroneous constant used
    --> /home/winterreise/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mp4parse-0.12.0/src/lib.rs:2558:1
     |
2558 | impl_mul!((U32, std::num::NonZeroU8) => (U32MulU8, u64));
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this note originates in the macro `static_assertions::const_assert` which comes from the expansion of the macro `impl_mul` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0277`.
error: could not compile `mp4parse` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `fselect v0.8.2 (https://github.com/jhspetersson/fselect.git#0ed03864)`, intermediate artifacts can be found at `/tmp/cargo-installRwSv9L`

Oh, I see, indeed, fselect fails to compile on Rust nightly. And not only that crate has this problem. So for now I can suggest switch to stabe:
rustup default stable

and build the project that way.
Thank you very much for the issue! It actually is a warning :) I might have to exclude mp4parse and other crates if they keep breaking with the future versions of Rust...

OK, it is the reason indeed. Thanks, I've successfully built. Thus the issue should be closed.


Add documentation and update README

This pull request adds new documentation for the PyJsonCanvas library.

LGTM!
Thank you very much for taking the time to do this!
I hadn't gotten around to it at first and then forgot about this


yazi: init hm module

Add initial support for Yazi terminal file manager. The style is based on the upstream catppuccin themes, but with non-color subjective options removed.
Project repo: https://github.com/sxyazi/yazi

Here are screenshots with catppuccin-mocha and gruvbox-light. There may some readability issues for modes and help menu for certain themes. But overall seems alright to me. I'd love to hear some input on this theme and how it can be improved

I'm working on polishing the look. Will upload new screenshots and address all comments.

Attaching screenshots with the polished module. Contrast for mode selection and percentage is significantly better. Help window also looks much better and is more readable. Theme is ${pkgs.base16-schemes}/share/themes/catppuccin-mocha.yaml

I'm quite happy with how this theme looks, it's quite cohesive with the eza, which uses ansiterm colors via stylix alacritty modules. Maybe someone could chime in and test this module with a different setup/terminal emulator/theme.

I've explicitly set all of the available options. Unfortunately there does not seem to be a way to set the default bg color via yazi theme (at least I wasn't able to find a way). Now of the colors match (aside from bg) between stylix-enabled alacritty and gnome console.

Yazi was recently updated to v0.2.4, which contains relevant breaking changes to the theme configuration. Particularly help.exec has been renamed to help.run with seemingly no back-compat. We should probably wait until the pr makes it to nixos-unstable before merging this. Though this isn't critical and yazi does not seem to mind an invalid option in it's config.

In that case, I'll go ahead and merge this, since it's working when the terminal is fully themed.
It seems like there's not much we can do to improve on the other case currently. I think the chance of a regular Yazi user relying on the default GNOME console is relatively low, so it's not a major issue. However, perhaps we should raise this upstream to get the necessary options added so that we can make our theme more reliable.

Great, feel free to merge to merge this pr in the current state. I've double checked that it works fine on yazi 0.2.4 with the latest changes. I'll investigate the possibility of adding/create an issue upstream regarding the background color.


PUT /person/:id - 405 Method Not Allowed error #20

Resolves #20
Changes

Changed the POST to a PUT on the Person item controller
added a semicolon

Testing
Performed a successful PUT request on Person

@BeckyPollard I just double checked using the front end
Everything seems to work fine for me, can demo and show later
But I essentially used the exact same flow and was able to update my name without console errors