fix tee2metron unit-test from starting orphan process

We found the same thing as explained in story below happening in our environment
https://www.pivotaltracker.com/n/projects/1183596/stories/90964260
Also added a test case for permission issues also.
$ps -ef | grep chatty
$ginkgo -r tee2metron/
Running Suite: Tee2metron Suite
===============================
Random Seed:<PHONE_NUMBER>
Will run 6 of 6 specs

••••••
Ran 6 of 6 Specs in 1.122 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 0 Skipped PASS

Ginkgo ran 1 suite in 1.829774919s
Test Suite Passed
$ps -ef | grep chatty

previously it used to leave a couple of process running like below
$ps -ef | grep chatty
cf       118990      1  0 18:58 pts/6    00:00:01 /tmp/gexec_artifacts021681306/g314086193/tee2metron -dropsondeDestination=<IP_ADDRESS>:34275 -sourceInstance=lattice-cell-123 /tmp/gexec_artifacts021681306/g274702556/chatty_process chattyArg1 chattyArg2 -chattyFlag
cf<PHONE_NUMBER>90  0 18:58 pts/6    00:00:00 /tmp/gexec_artifacts021681306/g274702556/chatty_process chattyArg1 chattyArg2 -chattyFlag

[#90964260]

this looks great!  thank you for the contribution @shashidharatd


remove the not null constrait for cluster_id

Refers: https://issues.redhat.com/browse/ACM-6187

/retest

Good catch !
/lgtm


Scroll controller throws Bad state: Too many elements in Release Mode only

Steps to reproduce
Flutter version: 3.22.2
Use scroll controller in aapp
Expected results
Wokring fine as in debug mode
Actual results
Getting  Bad state: Too many elements. Error thrown  while using Scroll Controller in release mode only
Code sample
Code sample
late ScrollController controller;

  InfiniteScrollController({required this.controller, required this.onLoading, required this.onRefresh});

  @override
  void onInit() {
   controller = ScrollController()..addListener(_trigger);
    super.onInit();
  }

  void _trigger() {
    if (!controller.hasClients || controller.positions.length > 1) return;

    final nextPageTrigger = 0.8 * controller.positions.last.maxScrollExtent;

    if (controller.positions.last.pixels > nextPageTrigger && isLastPage.isFalse && loading.isFalse) {
      loading.value = true;
      onLoading();
    }
  }

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
          Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Bad state: Too many elements. Error thrown .

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-x64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.89.1)
[✓] Connected device (4 available)
    ! Error: Browsing on the local area network for iPhone (3. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources```

</details>

Hi, how do you InfiniteScrollController?

@julien-kv Can you share a complete and minimal sample code? Does that mean you can reproduce this issue in release model on local machine? (run with --release) Or does the issue only happen in production release?

import 'package:flutter/cupertino.dart';
import 'package:get/get.dart';

class InfiniteScrollController extends GetxController {
  final Function() onLoading;
  final Future<void> Function() onRefresh;
  final RxBool isLastPage = false.obs;
  final RxBool error = false.obs;
  final RxBool loading = false.obs;
  final RxBool refreshLoading = false.obs;
  final RxBool refreshError = false.obs;
  final ScrollController scrollController = ScrollController();

  InfiniteScrollController({required this.onLoading, required this.onRefresh});

  @override
  void onInit() {
    scrollController.addListener(_trigger);
    super.onInit();
  }

  void _trigger() {
    final nextPageTrigger = 0.8 * scrollController.position.maxScrollExtent;

    if (scrollController.position.pixels > nextPageTrigger && isLastPage.isFalse && loading.isFalse) {
      loading.value = true;
      onLoading();
    }
  }

  void loadComplete() {
    loading.value = false;
  }

  void loadNoData() {
    isLastPage.value = true;
  }

  void loadFailed() {
    error.value = true;
  }

  void resetNoData() {
    isLastPage.value = false;
    error.value = false;
    refreshError.value = false;
    loading.value = false;
  }

  void refreshCompleted() {
    refreshLoading.value = false;
  }

  void refreshFailed() {
    refreshError.value = true;
  }
}

This is my InfiniteScrollController and in every controllers i use, i create seperate instance of infinite controller
tempRefreshController = Get.put(
      InfiniteScrollController(
        onRefresh: () async {
          fetchItems()
        },
        onLoading: () {
          fetchItems();
        },
      ),
      tag: tag(),
    );

I can reproduce this issue in release model on local machine.

Your sample code still uses get package and is incomplete. Please provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins/packages and in a main.dart file so that we can use it to reproduce the issue. Thanks!


feat: add support for setting password and org for a new user in the cli

one thing to note here is that new endpoint was created. there was no
endpoint for setting an initial password that worked. The existing endpoint
was a bit messy and coupled across multiple routes. Having multiple auth
schemes proved incredibly taxing to write against.
update: this came up in discussion in another topic with @goller and from that conversation decided to fixup the password service interface here. To provide the user id instead of name as the first arg to each set/compare func in the PasswordService.
closes: https://github.com/influxdata/influxdb/issues/15977

[x] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Well-formatted commit messages
[x] Rebased/mergeable
[ ] Tests pass

tests failing in idpe here, will have follow up PR in idpe to touch that up:
# github.com/influxdata/idpe/kv_test [github.com/influxdata/idpe/kv.test]
kv/passwords_test.go:57:44: cannot use f.Users[i].Name (type string) as type influxdb.ID in argument to svc.SetPassword
kv/passwords_test.go:310:54: cannot use tt.args.name (type string) as type influxdb.ID in argument to s.SetPassword
kv/passwords_test.go:485:58: cannot use tt.args.name (type string) as type influxdb.ID in argument to s.ComparePassword
+ record_failure 'go vet failed'


closes file in SearchBytesInFile() to correct issues #252 #253

close file if it has been opened without error. Fixes issues #252 and #253.

#253 is a better solution.


Package on PyPI does not reflect latest version available on this repo

The current version on PyPI (rumps==0.2.1a0) does not reflect the latest version with Python 3 support available on this repo. The version number appears to be the same as installing from source with python setup.py install (0.2.1a0), but they're not.

Bumped version and published 0.2.2 to PyPI

Bumped version and published 0.2.2 to PyPI.


"org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.id" could not be found in the registry

Hi,
Just trying to follow the steps on the README file to run a demo on a Linux machine using the Trace extension on Theia.

I cloned the repo
I have the prerequisite of Java 11 as required
I completed the section Build the extension and example application
And the problem arise on the next step on Try the trace extension section, when I run the command: yarn start:server then the following error message is saved on the log file at (theia-trace-extension/trace-compass-server/configuration/):

!ENTRY org.eclipse.osgi 4 0 2023-04-20 23:02:54.573
!MESSAGE Application error
!STACK 1
java.lang.RuntimeException: Application "org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.id" could not be found in the registry. The applications available are: org.eclipse.equinox.app.error.

	at org.eclipse.equinox.internal.app.EclipseAppContainer.startDefaultApp(EclipseAppContainer.java:252)
	at org.eclipse.equinox.internal.app.MainApplicationLauncher.run(MainApplicationLauncher.java:33)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:402)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1440)

What is the error about and the solution for it?
Thank you.

Thanks for having reported this. I just pushed a PR (linked herein) to fix the Java version in the README. Using 17 instead of 11 works locally for me, and should be the required version AFAIK.


Bluetooth: gatt: Fix foreach iteration of static attributes

Fix calling bt_gatt_foreach_attr with start handle parameter set
to last static attribute handle.
Fixes #15924
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

Please add a reference to the issue this fixes, so that it gets auto-closed upon merging this PR

FYI, I ran a quick test this PR and passed all failed test cases.

Please add a reference to the issue this fixes, so that it gets auto-closed upon merging this PR

@MariuszSkamra FYI, I added edited the description myself and added the reference.

@jhedberg Thanks for taking care of this ^^


fix #60 rewrite the interface of slides manager

Temporarily, the favorite btn is useless, just a interface for future develop.

and for now the user logo is static, just a interface for future feature

@Lozyboobob
1-   i think if we create a component to show slide and then slides manager can do only ngFor to display all slides .
2- you can also use ngif else (it's new future in angular v4)
3- to much css in the html component need to move it in the scss and have some ng-style ...
Can you integrate this for the PR ?

@Lozyboobob
The search fonction from the Home page is broken ?
I c'ant have any result when i click on discover all or search


metallic and roughness are swapped in the importer

https://github.com/ksons/gltf-blender-importer/blob/b154ca9dd98f776a95cc40a27080099e2ba12663/addons/io_scene_gltf/material.py#L139
At line 139, it should be using roughnessFactor but it's using metallicFactor, and vice versa on line 146.

This should be fixed on latest master.


prefix2 not shown

I normally set prefix2
bind C-Space send-prefix -2

And this plugin always show 'prefix' such as '^B' in status line.

Same thing is happening to me for some reason


Renaming the systems directory

Hello, it's been great using ocicl. Thank you for developing it!
I wanted to know if it's possible to rename the systems directory to something else without touching the source code. So, I'm looking for a configuration option / global variable to do this. I develop with multiple languages, and I'd prefer that directory to be called ocicl-systems or something more specific.

Thanks for the feedback!  I think an option you configure at 'ocicl setup' time would be fine.  I am not able to implement this any time soon, but would be happy to look at any patches you may come up with.

I made some local changes - amounting to replacing all instance of (:relative "systems") with (:relative "ocicl-system"). And also another similar change in the runtime directory. But this isn't the solution for the problem.
I'll issue a PR if I end up adding a proper configuration option!

I actually think this would be particularly useful non-globally, e.g. something like
ocicl install --systems-dir=./my-deps

Two thoughts:

If systems gets renamed, systems.csv probably should too
It would be great if the ocicl standard default was more specific than systems, which is not particularly unique and has a higher chance of name clashing than something containing ocicl in the name.


Tools reported not found were already installed available. Also not all linux have uses apt as package manager.

Describe the bug
I was trying to install fleet, and I noticed following messages which prompted me to terminate the execution.

It seems that using installer is unable to determine which distro is being used, and assumed it to be a debian based, thus running apt command. I am on Solus OS which uses eopkg, Under such condition, installer should inform the user that packages needed to be installed, and then exit safely.

I checked, and both lld and clang are already installed in the system and in the $PATH . So Installer being not able to detect packages is a bug.

The installer, went on to install rust nightly using rustup, even though I am already on nightly version which is updated frequently.

Expected behavior
It should be able to find lld and clang and other tools, if they wasn't installed, installer should install them using appropriate package manager of the distro, or let the user know they need to install tools and exit.
Desktop (please complete the following information):

Solus OS with Gnome DE.

Hey @Abhinav1217 we have added more configuration options to our roadmap (v1 release ) we will be fixing this issue over there.


Document the custom grpcio-tools command class

cc @hsaliak I think you asked about this at some point.

Preemption: yes, it renders properly on PyPI.

LGTM thanks for documenting this.

Luhguhtum.

I'm not sure this approach works.  We would need to lazy load an import of grpc.tools.command.BuildProtoModules because we can't assume any dependencies exist until setuptools.setup() is called.  However, with this approach we would need to reference the import in our call to setuptools.setup()

I think we should just not document this.
If someone follows this approach verbatim, it is almost guaranteed not to work.  Even if they only have grpcio-tools as a setup_dependency and they make it available on their dev/packaging environments, there is still an invalid import statement in setup.py that will cause their distributed packages to fail installation.

Well, guaranteed not to work for... what? This situation is no different than Cython needing to be imported to use it in setup.py. I lean towards us not being greedy.

But in the case of Cython, we can wrap the import statement in a function and do lazy loading.  I don't see how its possible to wrap import grpc.tools.command in a function.

Resolved offline: we'll provide an example workaround in the form of a reference to the grpcio-health-checking package.

Edited to include the approach taken in grpcio-health-checking. Once that distribution is registered for the first time this documentation will be valid.

LGTM


add cluster pooling support for vsphere

Update hive to include the ability to manage cluster pools in vsphere. The solution will need to deal with the 2 public ip addresses for api and apps.  Today we use route53, but looking at using DNS api's in house.

thanks, moved to https://issues.redhat.com/browse/HIVE-1367


Add swipe gestures to control back/forward movement. Fixes #1010. r=v…

…porof

Coverage decreased (-0.4%) to 42.656% when pulling 957fc251eeb22ffa7da99d7ff8db22a9ff67242b on jsantell:swipe into 3d8d6314995d6a16442cc58d385f8509e6a97b6e on mozilla:master.


Using center elements with anything else seems to break the layout

Using a center element in a panel, text-pad, etc. seems to break the container width.

We've removed the .text-pad class in v2, so this should be fixed. We've also stopped supporting v1, however we're more than happy to pull in v1 PRs into our v1.0.0 branch. Thanks!


docs: update RangeFilter non aggregate example

Closing in favor of https://github.com/sajari/sdk-react/pull/313

Closing in favor of https://github.com/sajari/sdk-react/pull/313


Add PHP tutorial

Just seen your post on Reddit, so proposing my PHP tutorial. Let me know if any changes are needed to the PR.

Description needs to be adjusted to describe what's being developed.

I've modified the description.

Hi @stuarthannig. I realise you have no obligation to accept my PR, but I've made the effort to raise it, and I've made the effort to amend it. Is there anything else I need to do?

Hi sorry I didn't notice. I saw someone already added your link (https://ilovephp.jondh.me.uk/en/tutorial/make-your-own-blog)

OK, no worries.


Makefile uses git define --tags --always to set version.

This is fine as long as takes are kept synced properly on the local repo.
Should the version be fetched exclusively from the VERSION file?

I think it makes sense to use the version from the VERSION file and only get the commit from git.

Hmm... Looking at the rest of Makefile, it uses $(tag), which comes from git define --tags to set the VERSION file.
ifeq ($(git),yes)
setversion:
    @echo $(tag) > VERSION

...so it doesn't seem like it would make sense to get $(tag) from VERSION and VERSION from $(tag)... but I may be missing something else.

We shouldn't be getting VERSION from tag. That is set on release time. I'd say that we should remove that.

Makes sense. I'll do a pull in a minute with these changes for you to review.

Awesome. Thanks.

Fix for thiw was merged #1221


Fix NoMethodError that is raised when the environment variable CUCUMBER_COLORS is defined

Description
This fixes a NoMethodError exception that is raised, when the environment variable CUCUMBER_COLORS is set, by allowing apply_custom_colors to be called right after its definition in Cucumber::Formatter::ANSIColor.
Defining the method as a class method of the module allows it to be called in the module itself.
Type of change

Bug fix (non-breaking change which fixes an issue)

As a question for the reviewers: I wonder if there should be additional tests for this. While the existing tests had to be adapted to reflect the code change, I'm not (entirely) sure whether this is sufficient (given that the bug slipped through with the tests). Even though CUCUMBER_COLORS='passed=red,bold' cucumber --help would have revealed the bug, I'm not sure this would be a good fit for another scenario in a feature file.

Thanks for the feedback.
I had to change the definition of apply_custom_colors to be a class method, in order to be able to call it right after the definition. That's because the context is the module.
Here's an example:
module Example
  def for_instances(arg)
    p arg
  end

  def self.for_class(arg)
    p arg
  end

  begin
    for_class('Calling the class method is OK')
  rescue NoMethodError => e
    p e
  end

  begin
    for_instances('The instance method is not available in the class')
  rescue NoMethodError => e
    puts "That didn't work"
    puts "Message:"
    puts "*" * 40
    puts e.message
    puts "*" * 40
  end
end

Running it yields:
"Calling the class method is OK"
That didn't work
Message:
****************************************
undefined method `for_instances' for Example:Module

    for_instances('The instance method is not available in the class')
    ^^^^^^^^^^^^^
Did you mean?  for_class
****************************************

In other words: self inside a class (or module) definition is the class/module itself. To be able to call a method within the class/module definition it needs to be a class method (similar to attr_reader etc.).
I hesitate to provide an instance method, because the method is not meant to be called on an instance (but provided it anyway 🙂), so we can discuss it.

Thanks for the update.
@luke-hill what is your opinion on this?

No worries, I'll just need to revert 1560c6e, right?

Yes, in addition to the last comments from @luke-hill

OK, as far as I can see we could now merge this PR, no?

This needs releasing. The bug with CUCUMBER_COLORS is in the current release 8.0.0 7 months after it has been fixed in  cucumber:main. Can we get a point release out to address this?


How should I convert an image url/image dom to Base64?

Is this library provide a function to convert an image url or an image dom to Base64?
Thanks.

No.
FYI all modern browsers are equipped w/ canvas and it has .toDataURL()
https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toDataURL


New sample script: add a site collection admin to a site

Docs

Author
Salaudeen Rajack

Original Post
link

Description
add a site collection admin to a site

Keywords
SharePoint Online, Governance

I don't see spo user add in the documentation for this one? (same for #2220)

Check my comment in #2220

Checked. Happy to take this one too if you want to assign it to me.

Excellent! All yours! Appreciate your help 😊

@waldekmastykarz - Looking at this one, I'm wondering if it's really necessary because it's a one-liner with the original command, which is already part of the examples (number 2) in the documentation.

You're right @veronicageek. Not sure if it's something that's changed since we wrote the spec or if we simply missed it. Good catch. I'll close this issue.


Monitoring - Cluster member and custom member cannot see live monitoring graphs

Bug.
Rancher master on 12/5
Steps:

Enable the monitoring  feature at the cluster level
log in as different user role: cluster owner, cluster member and cluster custom member

Result:
only the cluster owner can see live monitoring graphs, but cluster member and cluster custom member cannot.

Cluster   owner can enable/disable monitoring on cluster level
--
Cluster member   cannot enable/disable monitoring on cluster level
Cluster custom   member cannot enable/disab;e monitoring on cluster level

Project owner   cannot enable/disable monitoring on cluster level
project member   cannot enable/disable monitoring on cluster level
project custom   member cannot enable/disable monitoring on cluster level
project   read-only member cannot enable/disable monitoring on cluster level

@thxCode

I can not see metrics even when logged is as a cluster owner.

Created a cluster with admin
Created a standard user and assign it to the newly created cluster as cluster owner role.

Results:
Only admin users can see the metrics. Cluster owner can not see it.


Support matrix v2.8.0 link wrong (redirect to support matrix v.2.7.9)

Documentation:
https://ranchermanager.docs.rancher.com/versions
Click on "Support Matrix" (v2.8.0) and will redirect to Support Matrix v.2.7.9 page.

Thanks for letting us know. The support matrix site is maintained by another team and we'll have to wait until they add a page for v2.8.0

@welkson As it turns out, the link has been removed, as v2.8.0 was an unstable release. Users running v2.8.0 are recommended to upgrade to the latest stable Rancher release -- in this case, v2.8.1. See the v2.8.1 release notes.


Remove lwaftr version info

https://github.com/Igalia/snabb/pull/814 adds a generic --version knob in snabb in lwaftr-3.1 branch. lwaftr branch include some code to print out lwAFTR version number on running ./snabb lwaftr. Remove this code once lwaftr-3.1 gets merged in lwaftr.

Fixed in #814 and #893.


Move hard-coded collada directory to a requirement

Fix #8
collada directory is a hard-copy of the pycollada project.
This doesn't respect our contributing rules ;-)
Instead, it's much better to use the pip requirement file system as shown here.

👍


Add no-class-selectors rule

We're going to be leaning into an accessibility focused locator strategy (getByRole, specificially) and would like a rule to detect locators which reference css classnames. CSS Classnames aren't interpreted by Assistive Technologies.

I would like it to be a more general rule - prefer-user-facing-locators, that forbids any usage of page.locator(), and encourages usage of page.getByRole() and other user-facing locators. Like this example from best practices.

How's the state of this issue? I'd be down to help with writing the rule.


Can I help update this package to zod@3?

Hello @colinhacks 👋! This package does exactly what I want. Thank you so much for putting it together. However, it looks like the demo on the README no longer works:
import { toZod } from "tozod";
import { z } from "zod";

type Player = {
  name: string;
  age?: number | undefined;
  active: boolean | null;
};

export const Player: toZod<Player> = z.object({
  name: z.string(),
  age: z.number().optional(),
  active: z.boolean().nullable(),
});

This fails on tsc with the following error:
Type 'ZodObject<{ name: ZodString; age: ZodOptional<ZodNumber>; active: ZodNullable<ZodBoolean>; }, "strip", ZodTypeAny, { ...; }, { ...; }>' is missing the following properties from type 'ZodObject<{ name: ZodString; age: ZodOptional<ZodNumber>; active: ZodNullable<ZodBoolean>; }, "passthrough", ZodTypeAny, Player, Player>': toJSON, primitives, nonprimitives

I'd love to use this package. Is there anything I can do to help update this package so that it works again?

Update, I've discovered tozod@next which works with zod@3. Do you have any plans on updating this repository to reflect the latest version published to NPM?

tozod is dangerous and opinionated and I wouldn't recommend it. At the end of the day, there are infinite ways of representing any given TS type in Zod. And it goes against the whole goal of Zod, which is to avoid duplicate static + runtime type declarations. It's also incomplete and doesn't yet include newer Zod schema types like Map, Record, etc. And TypeScript tends to change how infinitely recursive type aliases are handled between minor versions, which can cause breaking changes and obscure errors. And tozod can't/doesn't support adding any transformations/refinements to the schema. Basically it's terrible.
That said I just published tozod@next as tozod@3. If you want to make any enhancements here I'm happy to merge them. But consider tozod experimental and not officially supported.

Okay, thanks for elaborating.


SSB

Can you please add option for SSB?
i see in code:
BK4819_AF_BASEBAND1 =  4u,  // SSB
BK4819_AF_BASEBAND2 =  5u,  // SSB
i think its LSB/USB or?

That would be gold on blue

I was thinking about it, but need to add a few more frequency step sizes along with adding SSB (RX only) to make SSB usable, something like 100Hz and 500Hz steps.

Yes, of course, it makes perfect sense, but it would be great

That's easy on your firmware, just incress
Frequency.c also change in header:
const uint16_t STEP_FREQ_TABLE[10] = {50, 100, 125, 250, 500, 625, 1000, 1250, 2500, 833};

Can't add it like that, that would create a mess with the stepping as it has to remain compactible with what the windows software uploads to radio radio, it would put everyones steps out of syn, the meaning of all the step settings would all be wrong.
Also their only one bit allocated by the windows software for setting mode to FM or AM, I'd need to add code to include another bit elsewhere in the eeprom to allow the extra modes.

Or you can do en separate #ifdef enable_ssb

At the moment, out of flash space for adding anymore.

@OneOfEleven do you have a messager, maybe we can get in contact.


Compare local state with stellar-core state in actions

As a security precaution compare ledger entries with the state in stellar-core in in actions code.
This is another issue (#1723 #1607 #1550) to make sure state in Horizon is correct. We may need to remove this check in a future but it's essential while new ingestion system is still experimental.

What are we comparing? Ledger hash? What will we do if there's a discrepancy? I'm thinking we should log an error and make sure we're alerted.

I briefly explained it in https://github.com/stellar/go/issues/1766. We need to compare values (entier ledger entry, ex. account) in Horizon DB and stellar-core DB. If there's a difference and last updated ledger fields are the same it means there's a bug. In such case we should emit error message and mark state as invalid (exp_state_invalid flag) that will lock access to state endpoint.

Closed in #1868. We can reopen if it's useful for any other endpoint.


Allow empty lines and comments in argument file

Fixes #405
Closes #406

Codecov Report

Merging #407 (ffbfab8) into master (9987068) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   97.81%   97.81%
=======================================
  Files          22       22
  Lines        2101     2109    +8
=======================================
+ Hits         2055     2063    +8
  Misses         46       46

Impacted Files
Coverage Δ

robocop/config.py
94.09% <100.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9987068...ffbfab8. Read the comment docs.


fix: add ListUserInvitations and BatchCheckPermission to authorizationSkipList

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.559%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6065

Relevant Lines:
11996

💛  - Coveralls


Allow import as Actors

A single configuration flag to indicate if we create JournalEntry or Actor objects and then import to the relevant compendium.
Any topic with a Portfolio or Statblock should also create an Actor.

Prefer the portfolio over the statblock.
Use a Picture, if present in the topic as the img for the actor (needs uploading somewhere).

Example is:
let actorData = {name: "John Doe", type: "character", img: "icons/svg/mystery-man.svg"};
let actor = new Actor(actorData);

OR
let actor = await Actor.create({
  name: "New Test Actor",
  type: "character",
  img: "artwork/character-profile.jpg",
  folder: folder.data._id,
  sort: 12000,
  data: {},
  token: {},
  items: [],
  flags: {}
});

Initial support added in 0.2.1
Unfortunately, decoding the stat block is specific to each game system.
Even storing the stat block on the Actor can be specified to each game system, since they don't all use "note" as the field to store the HTML.

Individual game system decoding routines will need to be raised as separate issues.


Add the ability for niche_ellipse() to handle 3 isotopes

functionality is currently implemented in #18
tests need to be made
vignette needs to be made


add support for package format 3

Connect to ament/ament_package#63

Waiting for review.

I'll review this today

Sorry, I don't think I got a message when the review was cleared. I can review it @mikaelarguedas, since I did the initial review.

@wjwwood sounds good to me


'Tensor' object has no attribute 'absgrad'

when use nerfstudio==1.1.3 and gsplat=1.0.0;
grads = self.xys.absgrad[0].norm(dim=-1)  # type: ignore
error:
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/scripts/train.py", line 262, in entrypoint
main(
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/scripts/train.py", line 247, in main
launch(
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/scripts/train.py", line 189, in launch
main_func(local_rank=0, world_size=world_size, config=config)
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/scripts/train.py", line 100, in train_loop
trainer.train()
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/engine/trainer.py", line 265, in train
callback.run_callback_at_location(
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/engine/callbacks.py", line 115, in run_callback_at_location
self.run_callback(step=step)
File "/usr/local/lib/python3.8/dist-packages/nerfstudio/engine/callbacks.py", line 105, in run_callback
self.func(*self.args, **self.kwargs, step=step)
File "/home/jianjian-peng/code/street-gaussian/street_gaussians_ns/sgn_splatfacto.py", line 602, in after_train
grads = self.xys.absgrad[0].detach().norm(dim=-1)
AttributeError: 'Tensor' object has no attribute 'absgrad'

and rasterization(..., absgrad=True,...)

who can help me???

Hi, I suggest you try to install gsplat=1.3.0 and try again?
You can refer to this: https://github.com/nerfstudio-project/gsplat/issues/362

I don't have a solution to this but wanted to add some information about where I also see this error.
I have encountered this issue but only when I modify the output of:
self.xys = info["means2d"]  # [1, N, 2]

inside get_outputs of splatfacto here
In my current project I have two gaussian splat models; one for representing a scene and one for representing a person. I concatenate the guassian parameters together from both representations before rasterization. I then need to split apart 'means2d' for each representation after:

if all(item in self.reconstruction_mode for item in ['person', 'scene']):
    self.scene_rep.xys = info["means2d"][0:1, :num_scene_gaussians, :]  # [1, N, 2]
    self.scene_rep.radii = info["radii"][0, :num_scene_gaussians]  # [N]
    self.person_rep.xys = info["means2d"][0:1, num_scene_gaussians:, :]  # [1, K, 2]
    self.person_rep.radii = info["radii"][0, num_scene_gaussians:]  # [K]
elif 'scene' in self.reconstruction_mode:
    self.scene_rep.xys = info["means2d"]
    self.scene_rep.radii = info["radii"][0]
elif 'person' in self.reconstruction_mode:
    self.person_rep.xys = info["means2d"]
    self.person_rep.radii = info["radii"][0]

If you watch the values of either model.xys.absgrad during debugging they resolve as:
'AttributeError("'Tensor' object has no attribute 'absgrad'")'

Until the backwards pass is called in trainer.py
Then model.xys.absgrad resolves to a tensor with values.
For me, this works if I have self.reconstruction_mode as either 'scene' or 'person', i.e. I don't split info["means2d"].
However, if I split info["means2d"], as I do when I'm using both person_rep and scene_rep, then when the backwards pass is called neither the scene_rep.xys.absgrad or person_rep.xys.absgrad is updated and I get the same error as OP. It seems splitting info["means2d"] modifies the custom gradient computation in the backwards pass that would normally happen with absgrad=True.

Hello! In gsplat.rasterization(), you may have to set absgrad = True. For more information you can refer to https://docs.gsplat.studio/main/apis/rasterization.html


Is the project DEAD???

No any developer activity more than a year.

yep, you can switch to https://github.com/salvoravida/redux-first-history

yep, you can switch to https://github.com/salvoravida/redux-first-history

Thanks!


Add datetime functions to 'dt' namespace.

(still WIP)

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage decreased (-0.7%) to 88.686% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage increased (+0.2%) to 89.562% when pulling b7715e9e4a29769f3553023f7220012d79079a74 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Here are some missing functions, for which I either didn't find any docs (in pandas), or found the docs to be not very clear.

to_pydatetime()
Does this take a string and parses it into a datetime instance ?
to_pytimedelta()
Likewise, what is the input, what the output type ?
normalize()
Not sure what this is doing.
tz
This may return None (if no timezone info is present in the input string), and I'm not sure how to handle that.

to_pydatetime()

I imagine that this takes the underlying numpy datetime type and converts it to the equivalent python datetime.datetime instance, but I'd have to check.  Same for to_pytimedelta().

normalize() Not sure what this is doing.

Agreed.  Options are to:

leave it out of Blaze for now
look at its implementation and divine its purpose from that, and make a Pandas documentation PR :)

For tz, it is an attribute I take it, correct?  Currently Blaze allows you to do things like
t.col.hour
t.col.minute
# etc ...

For datetime columns -- could we do something similar for .tz?  And its datashape would be an option type to handle the missing timezones.  Am I misunderstanding something?

In contrast to t.col.hour, which will always return a value, t.col.tz may return None, and I'm not sure how to convert that into a valid item.

Coverage decreased (-0.6%) to 88.744% when pulling cf8565926fe213cb0ef2fc15740ff82e621859c1 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage decreased (-0.6%) to 88.743% when pulling 4618062fc8cd031b0fa14e65d501d002e584fc3c on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

Coverage decreased (-0.6%) to 88.745% when pulling 25afabeb618d7b85972adf18781e385eb44fad98 on stefanseefeld:dt-namespace into 1aa004750250e9768983c3b01be68f76eca9c547 on blaze:master.

I noticed an issue with the documentation build, but am not sure whether that's caused by a misconfiguration or something else: None of the cross references I checked (e.g. :func:...) are compiled into links. I didn't see anything wrong, so perhaps that's a problem with my local sphinx install.

Coverage decreased (-0.6%) to 88.745% when pulling 25f8512544e23511e34b23e34e8cc40f7e7b01a2 on stefanseefeld:dt-namespace into d78137f9200dfc54aa93a6c7c9246cd499ad48ce on blaze:master.

I noticed an issue with the documentation build, but am not sure whether that's caused by a misconfiguration or something else: None of the cross references I checked (e.g. :func:...) are compiled into links. I didn't see anything wrong, so perhaps that's a problem with my local sphinx install.

Yes, am working to carve out time for a documentation overhaul over the next quarter or so.


Clean status of the component after is used successfully

Hi community,
I have a question. Why the screen where I implement the react-native-pincode in "enter" mode keeps the state/entered pin when I make a navigation.navigate('') after being used at less one time?
This is the situation/process: The user logs in, sets a pin, and kill the app. When he opens the app again (and here begins the process showed in the image), he can log in using pin number, so presses a button to go to the pin screen, he enters the pin and go to the main screen.
After that, he tries to make a payment, so my app requests the pin for confirming the payment, but when I redirect the user to the pin screen, this screen keeps the pin the user entered to log in. I don't know what I'm doing wrong :-S.

Thank you and regards.

Close this, I solved using navigation.push instead of navigation.navigate


Low effort package that logs  random quote

this one is cute. i think we then need to automatize adding quotes to data and rendering .md like here: https://github.com/orzklv/awesome-shakhzod


Support for glob patterns for resolver composition (like for other transforms)

As of now there are 2 ways of specifying resolver paths:

explicitly (Query.users)
or via a wildcard (Query.*)

In a situation where a composition is applied to many but not all resolvers this leads to a lot of repetetive boiler plate configuration.
Other transforms like filter do support glob patterns which would reduce configuration to a minimum.
I'm happy to make a PR, but first wanted to check with you guys if this should be done in graphql-mesh or directly in the graphql-tools. Let me know and I will get on it. @ardatan

It should already be supported by resolvers composition itself. Maybe it is a bug?

But to be clear what I meant with glob patterns. I was trying to use:
Query.{users, customers}
As supported by the mesh filter transform.
But this resulted in no resolver being applied at all.
Looking at the source (graphql-tools) it seems it only has special handling for * and otherwise it assumes that what is provided after the . is a name of a resolver.
Since {users, customers} is not a known resolver, no composition was applied.

@ardatan I have created an inital PR that adds filter transform (mesh) style glob pattern support for resolver composition. This does require an additional dependency (minimatcher) though. Please let me know if you feel this type of glob support should be included in the graphql-tools lib or if this is better fit for the upstream graphql-mesh resolver composition transform.

Available in the latest version!


Add template_p2p_checklist table

Description
Add template_p2p_checklist database table for tracking Reply-to Inboxes related to each service.
issue
Type of change
Please check the relevant option(s).

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation changes only

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)
How Has This Been Tested?

[x] Tested locally and was able to upgrade and downgrade without any issues.
[x] Deployed to migration to dev and successfully rolled back

`notification_api=> \d template_p2p_checklist
Table "public.template_p2p_checklist"
Column    |            Type             | Collation | Nullable | Default
-------------+-----------------------------+-----------+----------+---------
id          | uuid                        |           | not null |
template_id | uuid                        |           | not null |
checklist   | jsonb                       |           |          |
created_at  | timestamp without time zone |           | not null |
updated_at  | timestamp without time zone |           |          |
Indexes:
"template_p2p_checklist_pkey" PRIMARY KEY, btree (id)
"ix_template_p2p_checklist_template_id" btree (template_id)
Foreign-key constraints:
"template_p2p_checklist_template_id_fkey" FOREIGN KEY (template_id) REFERENCES templates(id)
notification_api=> \d template_p2p_checklist
Did not find any relation named "template_p2p_checklist"`


Add a check for item size in the microwave system

About the PR
This update tackles issue #23800 where the microwave was allowing oversized items, like a large pet carrier, to be placed inside. In MicrowaveSystem.cs, I've made adjustments to now verify the size of the item before allowing it into the microwave. If the item surpasses the specified maximum size in MicrowaveComponent.cs, a popup will notify the player.
Why / Balance
The modification aims to enhance common sense when using the microwave. Oversized items should not fit into the microwave, aligning with player expectations. This change doesn't significantly impact game balance but contributes to a more immersive experience. Resolves #23800.
Technical details
The added code in MicrowaveSystem.cs checks the size of the item before allowing it to be placed in the microwave. The MicrowaveComponent.cs introduces a new field, MaxItemSize, to define the maximum size an item can have to be eligible for microwaving.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
No breaking changes are introduced with this pull request.
Changelog
:cl:

fix: Prevent oversized items from being placed in the microwave for a more realistic gameplay experience.

Thanks for reviewing! Looks good now?


sudo: 1.8.23 -> 1.8.24

Changes here:
https://www.sudo.ws/stable.html
Only basic testing done, if nothing else
should keep an eye on this one :).

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: sudo
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: sudo
Partial log (click to expand)
shrinking /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/bin/sudoreplay
shrinking /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/bin/sudo
shrinking /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/bin/cvtsudoers
gzipping man pages under /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/libexec  /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/bin  /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/sbin
patching script interpreter paths in /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24
checking for references to /build in /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24...
moving /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/sbin/* to /nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24/bin
/nix/store/kqb1mmkmacysi9whzqjwqlmi3dqr5r5y-sudo-1.8.24

Success on aarch64-linux (full log)
Attempted: sudo
Partial log (click to expand)
shrinking /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/libexec/sudo/sudoers.so
shrinking /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/libexec/sudo/group_file.so
shrinking /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/libexec/sudo/libsudo_util.so.0.0.0
gzipping man pages under /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/libexec  /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/bin  /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/sbin
patching script interpreter paths in /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24
checking for references to /build in /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24...
moving /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/sbin/* to /nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24/bin
/nix/store/9zn23s8f4ciyr13rms035fmvx5jqhwy8-sudo-1.8.24


Center words on most-common letter

Centering words on their center-letter helped a lot, so maybe augmenting this to be something like "most common non-edge letter" would help even more?
Would this help anywhere on the board other than the very center? Unclear.
"Most common letter" is the letter that is shared the most times by the most other words.
Simple approx: letter that is contained within the most other words
In case the are multiple "most common" letters within a given word, bias towards the one closer to the word's center
I think this might be genuinely helpful... is finally a smart "preprocessing" step.

Implemented, is tentatively helpful. Certainly leads to smarter starts-of-boards.
Need to clean up optimization file before check-in

Checked in as the max_freq pivot type in https://github.com/jonadsimon/wonder-words-generator/commit/be545e1497b8b697a427c83eff615f5ae636374f


Need clarity in explanation of floating-point type

Here, "You can omit either the digits before the decimal point (the integer portion of the value) or the digits after the decimal point (the fractional portion), but not both."
Does this part - "or the digits after the decimal point" mean a number can be like this - 45.
Following the "or" part in the above statement, there is no digit after the dot(.) following 45. Looks odd if i declare something like
//float testFloat = 45.;
instead of
float testFloat = 45.0;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 912b4e0a-4a70-e07b-130e-7a0b33955fcb
Version Independent ID: 2235cd2d-77f5-1fb8-20b3-833828394c60
Content: C Floating-Point Constants
Content Source: docs/c-language/c-floating-point-constants.md
Product: visual-cpp
GitHub Login: @mikeblome
Microsoft Alias: mblome

@b1nch3f So we're a bit behind on some of our follow-up.
Yes, that sentence basically means you can't declare a floating point number just as a bare decimal point, or a decimal point followed by an exponent, but constants like 45. with no digits following, or 45.e25f, are perfectly legitimate.


POC: Github Actions

Removes TravisCI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f4c3e4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3610   +/-   ##
=========================================
  Coverage          ?   94.35%
=========================================
  Files             ?      420
  Lines             ?    45864
  Branches          ?        0
=========================================
  Hits              ?    43274
  Misses            ?     2590
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c3e4...6d92ef2. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f4c3e4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3610   +/-   ##
=========================================
  Coverage          ?   94.35%
=========================================
  Files             ?      420
  Lines             ?    45864
  Branches          ?        0
=========================================
  Hits              ?    43274
  Misses            ?     2590
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c3e4...6d92ef2. Read the comment docs.


[SPARK-14590] Update pull request template with JIRA link

What changes were proposed in this pull request?
Update pull request template to have direct link to jira issue

Test build #55682 has started for PR 12349 at commit d927d13.

Isn't this obvious from the JIRA title?

@rxin It is, but you then have to search for the jira. This makes it much more easy to just access the jira, from the link, similar to how the jira has the link to the pr. I have seen this in different projects, and found it very convenient and useful.

I'm not sure if we want this. People are already complaining the template is too long. This creates more work to create a pr, and does not add any extra information.

ok, I will leave it open for a day in case anyone else has interest on the change, otherwise close it.

Test build #55682 has finished for PR 12349 at commit d927d13.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55682/
Test FAILed.

btw https://spark-prs.appspot.com/ already does this for you

Test build #55689 has started for PR 12349 at commit 9a8b509.

Test build #55689 has finished for PR 12349 at commit 9a8b509.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55689/
Test PASSed.

Merged build finished. Test PASSed.

Yeah it's redundant and I think it's just another thing to not get filled out


Add progress bar

Add progress bar in message info.
This is done by adding 2 local var to class ZCL_ALOG_PROGRESS_REP_LOGGER and 2 relative method and by changing ENTRY_INTERNAL with effective progress.
New Variable:

New Method:

Result:

Hi, thanks. I'll review the PR later today.

Thanks!


Remove mysema-commons-lang as dependency

This old dependency was only used for its CloseableIterator and Pair. I reimplemented those two classes from scratch in querydsl core.
Reason for removal: Library not maintained, version below 1.0. Also possible licensing concerns, see #1922.

Thanks for this pull request @F43nd1r this will help a lot ! 👍

Not stale. @jwgmeligmeyling please review.


fix: retry cancelled error on first statement in transaction

If the first statement of a read/write transaction fails with a CANCELLED error and the error message is Read/query was cancelled due to the enclosing transaction being invalidated by a later transaction in the same session., then the transaction should be retried, as the error could be caused by a previous statement that was abandoned by the client but still executed by the backend. This could be the case if the statement timed out (on the client) or was cancelled.
Fixes #938

@olavloite without this fix, the user would just see a cancelled error and no retry would be made automatically, right?

Correct. That is also exactly what happened in #938.


Fix create helper wording on nodebalancer index

Closes #1347

Coverage decreased (-0.2%) to 82.846% when pulling f8dd2d0bb5703b36e2959fe41bb8cd3922fbe303 on eatonphil:fix-new-nodebalancer-wording into 8138dd80624e9d208a7fd21eee1f0960adbc9029 on linode:master.

thank you!


test: Add unit tests for memory costs

Codecov Report

Merging #39 into master will increase coverage by 1.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   92.33%   93.37%   +1.04%
==========================================
  Files           9        9
  Lines        1630     1646      +16
  Branches      153      153
==========================================
+ Hits         1505     1537      +32
+ Misses         79       67      -12
+ Partials       46       42       -4


Cs and fcb

Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

@JennySanchez Thank you. Is it Feature card block medium or Feature card block — medium?

@wonilsuhibm The correct naming according to airtable is "Feature card block – medium."

@jacobottesen-dgc Please make the necessary name changes.

@wonilsuhibm FYI changes are made in this PR https://github.com/carbon-design-system/ibm-dotcom-library-website/pull/556


feat(FiberedCategory/BasedCategory): add bicategory of based categories

We define the strict bicategory of based categories. Its objects are categories equipped with a functor to some fixed base-category. The strict bicategory of fibered categories will later be built on top of this one.
Co-authored-by: Paul Lezeau<EMAIL_ADDRESS>

[ ] depends on: #12978

Okay this merge with mathlib went awfully wrong for some reason. I think I will just remake this PR


Prevent calling decryption in an encryption context and vice versa [1.0.2]

Backport of #7852

I'm worried about the Travis failure...

There is a slight concern that it will break applications that have a code with the same slight usage bug which thus worked correctly "by accident" and now they will stop working. So perhaps backport to 1.0.2 is not worth it?

(I forgot to add an empty line after the quote in my dismissal. So I'll it repost the answer, since the dismissal is not editable)
@t8m you are right. That's a valid concern. @levitte what do you think?

I'm ambivalent... For the update functions, that does seem unnecessary, perhaps the check should be limited to custom ciphers, where you cannot know if the update functions are equivalent or not.
Otherwise, I would say that programs that call the wrong function are broken, and now we tell them how instead of leaving them with screwed up data.

With regards to the expressed concern, I think I'd like to ask for a second opinion from someone else in @openssl/omc

Is it easy not to generate an error in the case that it's not a problem calling the wrong function? If it's not easy, I'm fine with the change like it is.

Is it easy not to generate an error in the case that it's not a problem calling the wrong function?

Well...  that would be limiting this to custom ciphers.  Otherwise, we very obviously do expect EncryptUpdate and DecryptUpdate to do the exact same thing.  EncryptFinal and DecryptFinal are another story, they aren't interchangeable and may therefore need the check.
Note that we've been asked to make this check to help users realise they've made a stoopid mistake.  In the end, I don't really care very much if we do apply this on 1.0.2, so there's the option not to, if that makes everyone feel better.

There is a slight concern that it will break applications that have a code with the same slight usage bug which thus worked correctly "by accident"

I indeed have such software, and it was unpleasant that it got broken after an upgrade from security.debian.org on a Debian/stable. Such upgrade should never break anything (and it is sometimes automated).
It's hard to reproach Debian for having done a simple version up, rather than only cherry-picking security fixes (1.0.2r was pushed for CVE-2019-1559). It looks a bad idea to do anything else but security fixes for branches that have got so little attention by distributions from a functional point of view.
Or at least, a clear warning in the changelog.
Just a general comment. Personally, it's fine if this PR is not reverted (I downgraded until I find time to upgrade the software I referred to above).


Back-End Dev to Master

Merging back-end dev to master

Backend dev merged to master branch. No changes were made to reflect the feedback from the user testing. Waiting for testings to finish and further discussion to happen.


docs(portal-gun): fix typo

Hi Luiz 👋🏼, the docs also mention after: instead of end:.
I was wondering whether that happend, because you already thought about widening this to before and after like insertAdjacentElement() supports beforebegin, afterbegin, beforeand and afterend?

I'd say it would be best to wait for a real demand. ;-) I had none, was just curious. teleporting staff to the beginning of the <head> was fine for me. And it was great that the start and end targets for head (and body) were predefined, so i had not to define them myself. And no, you do not want automatic targets for before head or after body or between head and body (even though most browsers can deal with that).
Scott me up, Beamy!


Document genreconciler.

Adding documentation on how to use and what to expect from the generated reconciler code added to client injection gen.
/assign @mattmoor

@googlebot I consent.

@googlebot I fixed it.

/lgtm


Implemented support for TF mixed precision (mixed_float16)

Closes #215
This PR adds support to mixed precision training support in TF for Merlin Models following TF documentation.

[X] Makes Model subclass custom train loop to support gradients scaling (using tensorflow.keras.mixed_precision.LossScaleOptimizer()) under the hood)
[X] Ensure that the output layer of the models are always tf.float32 before the activation function (e.g. softmax), to avoid loss instability

@sararb @marcromeyn @gabrielspmoreira
I tested the solution based on the test case here.
Unfortunately, it doesn't work with multiple optimizers when LazyAdam is used to optimize sparse embedding as described here. Enabling mixed precision results in the following error:
File /usr/local/lib/python3.10/dist-packages/merlin/models/tf/models/base.py:1161, in BaseModel.train_step(self, data)

   1158 self._validate_target_and_loss(outputs.targets, loss)

   1160 # Run backwards pass.

-> 1161 self.optimizer.minimize(loss, self.trainable_variables, tape=tape)

   1163 outputs = outputs.copy_with_updates(

   1164     sample_weight=self._extract_positive_sample_weights(outputs.sample_weight)

   1165 )

   1166 metrics = self.train_compute_metrics(outputs, self.compiled_metrics)

ValueError: in user code:

    File "/usr/local/lib/python3.10/dist-packages/keras/engine/training.py", line 1284, in train_function  *

        return step_function(self, iterator)

    File "/usr/local/lib/python3.10/dist-packages/keras/engine/training.py", line 1268, in step_function  **

        outputs = model.distribute_strategy.run(run_step, args=(data,))

    File "/usr/local/lib/python3.10/dist-packages/keras/engine/training.py", line 1249, in run_step  **

        outputs = model.train_step(data)

    File "/usr/local/lib/python3.10/dist-packages/merlin/models/tf/models/base.py", line 1161, in train_step

        self.optimizer.minimize(loss, self.trainable_variables, tape=tape)

    File "/usr/local/lib/python3.10/dist-packages/keras/optimizers/legacy/optimizer_v2.py", line 588, in minimize

        return self.apply_gradients(grads_and_vars, name=name)

    File "/usr/local/lib/python3.10/dist-packages/keras/mixed_precision/loss_scale_optimizer.py", line 818, in apply_gradients

        maybe_apply_op = tf.__internal__.smart_cond.smart_cond(

    ValueError: Lengths of branch outputs of cond must match.

    len(graphs[0].outputs): 0

    len(graphs[1].outputs): 1


Remix builds not working as soon as I add mdx-bundler

mdx-bundler version: ^9.0.1
node version: 18.7.0
npm version: 8.19.2

Relevant code or config

What you did: Just installed the package and used it. Everything works just fine locally but while deploying to fly or railway the build always fails saying:
> PORT=3000 remix-serve build
Error: Cannot find module 'remark-mdx-frontmatter'
Require stack:
- /myapp/build/index.js
-<EMAIL_ADDRESS>at Function.Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
at Function.Module._load (node:internal/modules/cjs/loader:841:27)
at Module.require (node:internal/modules/cjs/loader:1061:19)
at require (node:internal/modules/cjs/helpers:103:18)
at node_modules/mdx-bundler/dist/index.js (/myapp/build/index.js:83:172)
at /myapp/build/index.js:7:50
at Object.<anonymous> (/myapp/build/index.js:1031:34)
at Module._compile (node:internal/modules/cjs/loader:1159:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
at Module.load (node:internal/modules/cjs/loader:1037:32)

What happened: Can not get my server to deploy.

Reproduction repository: https://github.com/ksorv/blog

Problem description:
Suggested solution: No idea tried everything that I could find related to the problem.

@kentcdodds Sorry if the issue doesn't belong here. Please help

I'm not sure what's going on here and I'm afraid I don't have the time to look into this for you :( Hopefully someone else can help!

Hmm, I hope someone can tag along to help @kentcdodds.
I've been searching for it over n over but found nothing like this one.
Do you maybe have time to give some pointers on where to start debugging I wanna look into it.

@kentcdodds I think i was able to fix it by using:
function fixEsbuildBinaryError() {
  if (process.platform === 'win32') {
    process.env.ESBUILD_BINARY_PATH = path.join(
      process.cwd(),
      'node_modules',
      'esbuild',
      'esbuild.exe',
    )
  } else {
    process.env.ESBUILD_BINARY_PATH = path.join(
      process.cwd(),
      'node_modules',
      'esbuild',
      'bin',
      'esbuild',
    )
  }
}

fixEsbuildBinaryError();

in the whatever.server.ts file in which i was using mdx-bundler.
So, Closing this one. Thanks for your time.


chore: increase stability of the create kafka acl module

To verify:
Checkout PR
run make local-dev
run ansible-playbook 'run.yml'
The updated run.yml script here will create:

a new kafka (if you have quota, you may also need to change the name of the kafka if someone else runs this script first, to ensure a unique kafka name) NOTE this step may take a while as now the create_kafka module waits for the new kafka to be in a ready state before finishing
new service account
create an ACL and bind it to the newly created service account on your new kafka
create 2 topics

one with no (API default) config
one with custom config

The error was: rhoas_kafka_mgmt_sdk.exceptions.ApiAttributeError: KafkaRequest has no attribute 'admin_api_server_url'


Using requestIdleCallback to efficiently throttle setState calls when…

… renderStack changes

I'm closing this in favour of other branch that was forked from this one. It has all the changes. https://github.com/Flipkart/ReactEssentials/pull/54


Add OpenTelemetry integration

See https://github.com/hyperledger/fabric-rfcs/blob/main/text/0000-opentelemetry-tracing.md
Adding OpenTelemetry integration, starting with adding traces support for chaincodes.

Thanks for getting OpenTelemetry integration through the RFC process!


Update remoteapp-faq.md

The hyperlink was wrong in "What are the service limits? " question's answer. Corrected.

Hi @farcel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Merging...  also just FYI for @lizap


Flex columns basics

Todos
These need design or discussion:

Decide for UX of flex/grid/responsive grid. I could imagine this to be an enum-like control. But we could also keep flex/grid a toggle and conditionally show (or grey out) the responsive toggle.
Implement read-only behavior for the switches.
Fix flex visualization (right padding) if the add-column button is not shown.
Small flex visualization fix: the left blue border of the leftmost flex column is not visible.
Make vertical column stretch in flex mode work (or decide to conditionally hide the option).

@dcsaszar Looks good so far. The option for mobile adaption is not there, yet.
d-flex ->  no mobile adaption linearization
d-md-flex -> mobile adaption linearization

@dcsaszar Here my solution..
without responsive adaption
wrapper class
d-flex
each column has this class
mx-2
with responsive adaption
wrapper class
d-md-flex
each column has these classes
my-md-0 m-2

Please resolve the conflicts in the PR.


Deserialize Exception 'T is failed in provider at creating formatter.' at NativeAOT

I found the main issue is The T's static constructor does not Invoke when Deserialize<T> when NativeAOT. so there is no formatter registered. If I add var r = new MemPackTestObj() { Strings = new[] { "a", "b", "c" } }; before Deserialize, It works.
Code:
using MemoryPack;
using System.Runtime.InteropServices;

Console.WriteLine($"{RuntimeInformation.FrameworkDescription}");

//var r = new MemPackTestObj() { Strings = new[] { "a", "b", "c" } };
//var bytes = MemoryPackSerializer.Serialize(r);

var bytes = Convert.FromBase64String("AwMAAAD+////AQAAAGH+////AQAAAGL+////AQAAAGMAAAAAAAAAAP////8=");
Console.WriteLine(Convert.ToBase64String(bytes));
var r2 = MemoryPackSerializer.Deserialize<MemPackTestObj>(bytes);
foreach (var s in r2!.Strings)
{
    Console.WriteLine(s);
}

[MemoryPackable]
public partial record MemPackTestObj
{
    public string[] Strings { get; set; }
    public DateTime Date { get; set; }
    public string Name { get; set; }
}

csproj
<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net8.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <IsPackable>false</IsPackable>

        <!-- AOT Options -->
        <!-- https://learn.microsoft.com/ja-jp/dotnet/core/deploying/native-aot/ -->
        <PublishAot>true</PublishAot>
        <SelfContained>true</SelfContained>
        <IlcOptimizationPreference>Speed</IlcOptimizationPreference>
        <IlcOptimizationPreference>Size</IlcOptimizationPreference>
        <IlcFoldIdenticalMethodBodies>true</IlcFoldIdenticalMethodBodies>
    </PropertyGroup>

    <ItemGroup>
        <PackageReference Include="MemoryPack" Version="1.9.16" />
    </ItemGroup>
</Project>

When dotnet run -c Release It works as expected.
.NET 8.0.0-rc.2.23479.6
AwMAAAD+////AQAAAGH+////AQAAAGL+////AQAAAGMAAAAAAAAAAP////8=
a
b
c

When dotnet publish -c Release and .\bin\Release\net8.0\win-x64\publish\NativeAot.exe
.NET 8.0.0-rc.2.23479.6
AwMAAAD+////AQAAAGH+////AQAAAGL+////AQAAAGMAAAAAAAAAAP////8=
Unhandled Exception: MemoryPack.MemoryPackSerializationException: MemPackTestObj is failed in provider at creating formatter.
 ---> System.InvalidOperationException: Type implements IMemoryPackFormatterRegister but can not found RegisterFormatter. Type: MemPackTestObj
   at MemoryPack.MemoryPackFormatterProvider.TryInvokeRegisterFormatter(Type) + 0xe9
   at MemoryPack.MemoryPackFormatterProvider.Cache`1..cctor() + 0x51
   --- End of inner exception stack trace ---
   at MemoryPack.MemoryPackSerializationException.ThrowRegisterInProviderFailed(Type, Exception) + 0x4a
   at MemoryPack.ErrorMemoryPackFormatter`1.Throw() + 0x2f
   at MemoryPack.MemoryPackSerializer.Deserialize[T](ReadOnlySpan`1, T&, MemoryPackSerializerOptions) + 0xf0
   at Program.<Main>$(String[] args) + 0x8e
   at NativeAot!<BaseAddress>+0x172ee0

Is this a NativeAOT runtime bug? any solution to solve this?

https://github.com/Cysharp/MemoryPack/blob/9aa51ce1e8da24e27053bf2448c127c4263c2096/src/MemoryPack.Core/MemoryPackFormatterProvider.cs#L177-L197
Maybe the main point is here. dotnet -c Release has reflection metadata. but NativeAOT has not.
static method is not invoked at dotnet run -c Release, the TryInvokeRegisterFormatter method invoked.
It looks like a MemoryPack issue not NativeAOT runtime bug.

Hello. Thanks for the report.
It seems that if there is no Serialize in the source code and only Deserialize, the AOT build will trim the required code.
As a quick workaround, we have addressed this issue by adding [DynamicallyAccessedMembers].
It is difficult to completely remove reflection from a MemoryPack implementation.
Therefore, we are currently unable to even turn off all the AOTwarnings that the compiler produces.
But for the time being, adding attribute seems to work in most cases.
Next release should be coming soon.
Please let us know if there are any more problems. Thanks again.

Thanks for your work. It looks useful in the case.
I wonder Deserialize<ICollection<MemPackTestObj>> will work or not.

I wonder Deserialize<ICollection> will work or not. I'll try until have some time to do it.

I have tried and it works. Looks very nice.


bot commands

This change is

Нужно описание каждой команды через дефис. Например,
show_new - Показать последние записи

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

a discussion (no related file):
Нужно описание каждой команды через дефис. Например,
show_new - Показать последние записи

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Roll engine 3ffa36295234..8757bf2a19ef (2 commits)

https://github.com/flutter/engine/compare/3ffa36295234...8757bf2a19ef
git log 3ffa36295234..8757bf2a19ef --no-merges --oneline
8757bf2a1 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10ad1 Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6264610705375232

Commit queue failed; closing this roll.


Analyze communication strength and voting patterns

Goal: Using communication strength between communities, answer the following question: Controlling for proximity, do communities with strong communication channels tend to vote similarly?
I believe there is municipal level voting distribution information on one of the Guatemala government website. Check the guatemalan department of statistics

Maybe use gt munis shapefile to color communication/voting patterns:
Guatemala muni shapefile
Tutorial to create map with voting data using shapefile in R


[Chore] - Compendium - Resource (Manuever) Consumer

Automatically add the Resource Consumer to all maneuvers that have an exertion cost of more than 0 and set the quantity to the correct exertion amount.

We should probably clean up the old exertion data as part of this issue, as well, and modify the maneuver summary section to make use of the resource consumption information, rather than the old exertion cost field.

Since this "pack migration" relies on exertionCost i'd like to leave it in there for a few updates so that if there's an issue we can revert and fix it.


[SPARK-35855][SQL] Check for overflow in Average in ANSI mode

What changes were proposed in this pull request?
Fixes decimal overflow issues for decimal average in ANSI mode, so that overflows throw an exception rather than returning null.
Why are the changes needed?
Query:
scala> import org.apache.spark.sql.functions._
import org.apache.spark.sql.functions._

scala> spark.conf.set("spark.sql.ansi.enabled", true)

scala> val df = Seq(
     |  (BigDecimal("10000000000000000000"), 1),
     |  (BigDecimal("10000000000000000000"), 1),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2),
     |  (BigDecimal("10000000000000000000"), 2)).toDF("decNum", "intNum")
df: org.apache.spark.sql.DataFrame = [decNum: decimal(38,18), intNum: int]

scala> val df2 = df.withColumnRenamed("decNum", "decNum2").join(df, "intNum").agg(mean("decNum"))
df2: org.apache.spark.sql.DataFrame = [avg(decNum): decimal(38,22)]

scala> df2.show(40,false)

Before:
+-----------+
|avg(decNum)|
+-----------+
|null       |
+-----------+

After:
21/07/01 19:48:31 ERROR Executor: Exception in task 0.0 in stage 3.0 (TID 24)
java.lang.ArithmeticException: Overflow in sum of decimals.
	at org.apache.spark.sql.errors.QueryExecutionErrors$.overflowInSumOfDecimalError(QueryExecutionErrors.scala:162)
	at org.apache.spark.sql.errors.QueryExecutionErrors.overflowInSumOfDecimalError(QueryExecutionErrors.scala)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage2.processNext(Unknown Source)
	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
	at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:759)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:349)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:131)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:499)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1462)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:502)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test

Test build #140536 has started for PR 33177 at commit 50b7e20.

I don't think this is related to SPARK-35855.

I don't think this is related to SPARK-35855.

Good catch @peter-toth - sorry, meant SPARK-35955 🤦♀

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45050/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45050/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45050/

Test build #140536 has finished for PR 33177 at commit 50b7e20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140536/

Thanks, merging to master

late LGTM


Clarify the state of an instance after a failed update or delete

Update and delete operations may fail for many different reasons. For example:

A deletion may fail because other instances or resources depend on the instance.
Resources to do the update are not available at this time.
A legal hold does not allow an instance to be altered or deleted.

In many cases, when such an operation fails, the service instance is untouched and still usable. From an application point of view nothing changed. (In the legal hold case there MUST be no change.)
For the update operation, the spec contains this sentence:

When the response includes a 4xx status code, the Service Broker MUST NOT apply any of the requested changes to the Service Instance.

That implies the service instance is still usable.
For the delete operation, we have this sentence:

...MUST be interpreted as a failure and the Platform MUST remember the Service Instance.

The word "remember” does not specify whether the instance is still operational or in an unusable state.
We should clarify what that means and maybe add another status code (409?) that let the broker tell the platform that the instance is untouched.

See also issue #358.

It would also be nice to have similar feature for "create" (provisioning) operation.
Otherwise platform has to always perform orphan mitigation "just in case" after failed async provisioning.


Glitchy green image on headset

Description

The image on the headset looks broken, with green stripes. Like a decoding or encoding error.
Everything works perfectly fine, except that the video on the Quest is glitched, with green horizontal stripes, like a decoding glitch.
I've changed lots of parameter on ALVR, including disabling phobeated rendering (all of them), and color correction.
Any combination of parameters result en exactly the same glitchy green image.

General Troubleshooting

[x] I carefully followed the instructions in the README and successfully completed the setup wizard
[x] I read the ALVR Wikis here and here

Environment
Hardware
https://linux-hardware.org/?probe=196daaa768
Installation
ALVR Version: ALVR v20.1.0 (tested ALVR v20.0.0 also)
ALVR Settings File:
session.json.txt
SteamVR Version: 1.25.8
Install Type:

[x] Packaged (exe, deb, rpm, etc)
[x] Portable (zip)
[ ] Source

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
Ubuntu 22.04.2 LTS

I have the same problem on Ubuntu with both Quest 2 and Pico 4. Positive controls like VDesktop in Windows are working.

The newest Ubuntu is required due to old Ubuntu not included the required packages for ALVR to work your best experience will be found on arch

The newest Ubuntu is required due to old Ubuntu not included the required packages for ALVR to work your best experience will be found on arch

Yes, Arch did get past the green lines, but was more laggy than VD on my system.
Which version of Ubuntu has the packages? I tried 22.04 LTS. Also, any idea which packages?.. because maybe I can upgrade just those and their dependencies. Thanks

Look at the wiki, also do you mind sending me the logs from ALVR?

Can't find a way to save the logs as text (can't find the "DebugLog" button referred on the wiki).
But here are the logs on image format.

You need to enable logging to file in settings and it should be in your home file

Also do you have cuda installed?

Yes, I do have cuda installed. This is the output from nvidia-smi . Hardware encoding should be working in my machine, I use it regularly on OBS.

Here are the logs:
alvr_session_log.txt

Do you not have modesetting enabled?

Is working now! Thanks
Tried adding nouveau.modeset=0 (didn't work), then nvidia-drm.modeset=1 (didn't work).
Then I updated the NVidia drivers, and that did the trick!

Awesome

You do need it at least nvidia_... Loaded, but an updated driver may have fixed some things


Fix connect_timeout for wasi-http

@elliottt in https://github.com/bytecodealliance/wasmtime/issues/7356 mentions that connect_timeout, first_byte_timeout, and between_bytes_timeout should be tested.
This PR adds a test for connect_timeout and ensures that TcpStream::connect adheres to the timeout. Without this fix, setting connect_timeout has no effect on hosts where TcpStream::connect tries to connect.
Note that the variable connect_timeout is also used a bit later for the handshake:
https://github.com/bytecodealliance/wasmtime/blob/8dd2ae9e2c57b3fd32f91fb8f0ec1543854f4c7c/crates/wasi-http/src/types.rs#L207-L213
I'm not sure whether using this variable twice is correct.

I'm not sure whether using this variable twice is correct.

I see two uses in the handler function, but they're under different branches of the same conditional. Was there another use of connect_timeout that you were thinking of?

This looks great, thank you!

Thanks for the review!

I'm not sure whether using this variable twice is correct.

I see two uses in the handler function, but they're under different branches of the same conditional. Was there another use of connect_timeout that you were thinking of?

There should be three (https://github.com/bytecodealliance/wasmtime/blob/eebce11eb1fdfc67ab8fc7a06cb68ba1231dd7a6/crates/wasi-http/src/types.rs).
One is now newly added near the TcpStream::connect and the other two are inside the branches near hyper::client::conn::http1::handshake. I think these two different phases represent TCP's SYN and ACK.
Why I mentioned it is because it sounded a bit weird to me that the connect_timeout is used twice, but on second thought maybe it's fine. The SYN and ACK are both still during the "Connection establishment" phase.

Ah! Sorry for misunderstanding. I think this is fine to leave it this way, but I agree that it's a little odd. Reading through the handshake implementation, it's assuming that the connection has already been made, so if anything we might want to remove the timeout on the second two uses in the function.

I added #8104 to record the fact that we should look into removing the uses of connect_timeout on the handshake calls, but that issue won't be valid until this PR merges.


perf: Various performance tuning

From #288, I cherry-picked only the ones that were not controversial and did not change the test significantly.
When should the Request object be extended?
Since there is no Request object in node, we are currently calling extendRequestPrototype when we create an instance of Hono (assuming it will have been added to globalThis by then if we are testing).
If we "tweak benchmarks/handle-event/index.js", etc., and decide that globalThis.Request should be initialized before "hono.ts" is imported, then it could be done on import.
What I did not cherry-pick.
These will be discussed in another PR.

2e2d443
ca92ca9f69a60028ac22316

minimal handler x 348,756 ops/sec ±6.81% (70 runs sampled)
hono - trie-router(default) x 155,222 ops/sec ±3.98% (82 runs sampled)
hono - regexp-router x 182,453 ops/sec ±5.75% (79 runs sampled)
itty-router x 85,700 ops/sec ±3.59% (86 runs sampled)
sunder x 122,709 ops/sec ±1.57% (90 runs sampled)
worktop x 64,828 ops/sec ±5.27% (78 runs sampled)
Fastest is minimal handler

Hi @usualoma
Thank you! It's good that's is a minimal change and almost tests have not been changed.

If we "tweak benchmarks/handle-event/index.js", etc., and decide that globalThis.Request should be initialized before "hono.ts" is imported, then it could be done on import.

In current PR, extendRequestPrototype is called in the constructor on Hono, so this code is OK?
import { Hono } from 'hono'

globalThis.Request = Request
globalThis.Response = Response

const app = new Hono() // <--- extends `Request`

There's not a problem, I will merge it!


Handle EXIF tag in JPG images

I've noticed that CVAT rotates relatively large images that are "Portrait" (taller than they are wide) 90 degrees left or right.
There are two existing issues that seem to be somewhat related to this:
https://github.com/opencv/cvat/issues/733
https://github.com/opencv/cvat/issues/738
But neither clearly explains the problem or provides the steps to reproduce the concern, so I figured I'd submit a new issue and document and explain everything clearly.
Steps to reproduce:

Download and unzip the attached images.zip at the bottom of this post, which contains 3 images I took outside my workplace this afternoon.  All 3 are 3024 wide x 4032 high.

Install the latest version of CVAT, then open Chrome and start CVAT.  Make a new task, name it anything you'd like.  Add a few labels, for example I added car and fence.  Drag the 3 unzipped images into the Click or drag files to the area area.  Wait for the files to be listed, then choose Submit.  Wait for CVAT to load in the images.

Go back to the main CVAT Tasks page, for the task you just made choose Open, then click on Job #x towards the bottom left and scroll through the images, all 3 will be rotated 90 degrees.

Here is a screenshot of what my screen looks like after following these steps:

An additional thing I've tried is to use the rotation buttons towards the bottom of the CVAT UI, which will rotate the images in the UI, and then I choose Open Menu -> Save Work.  This does temporarily make the images upright as they should be, however the problem is that if I leave the task and then open it again at a later time the images go back to being rotated 90 degrees.  I've also tried Open Menu -> Settings -> Rotate All Images, this does not help either.
A few other things I should mention:

CVAT only does this to relatively large images.  For example, I tried resizing the attached images all to 768 wide x 1024 high and then importing, and the images displayed in the correct orientation.

The 3 images in the attached set were all rotated 90 degrees left by CVAT, however sometimes CVAT will rotate large portrait images right.  I have not been able to determine any rhyme or reason as to when CVAT rotates left vs right, however I can say that left is more common.

This issue is a major concern for our company.  We can code around it with substantial effort, however CVAT really should not be altering our images.  Please address this concern as soon as possible.
images.zip
--- Edit ---
It seems that in some cases this can be a known issue for browser-based applications.  Perhaps something along the lines of the suggestions provided in the highest rated answer to this SO question should be added to CVAT:
https://stackoverflow.com/questions/28251338/jquery-image-preview-exif-rotation-issue/28843763#28843763
Where/how something like that could be added to CVAT, I'm not sure.

@nmanovic I think this one is definitely a bug.

I just imported annotations someone made in CVAT to a different annotation software for review, and about half of the pictures have the annotations appear rotated by 90°. I suppose this would also cause issues for training models! If the training is based on the mismatched rotation, the models would train junk.
Would be glad to see a resolution of this :) Thanks!


How to change shortcut binding?

Need to make it ALT+CTRL+SHIFT+E so that it can be done with one hand.

File -> Preferences -> Keyboard shortcuts ( CTRL + [K, S])
"markdown-editor:openEditor"


Do not run overlay-closed handler on detach if closed

Fixes: #513

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/vaadin-date-picker-mixin.html, line 601 at r1 (raw file):

    }

    detached() {

BTW this should be changed to use disconnectedCallback

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/vaadin-date-picker-mixin.html, line 601 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
BTW this should be changed to use disconnectedCallback

BTW agree, note that there is a disconnectedCallback defined above already.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/vaadin-date-picker-mixin.html, line 601 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
BTW agree, note that there is a disconnectedCallback defined above already.

Actually there is a this.opened = false  on that, so this block was not needed. Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


ufacw.com not bypassing

Domain
https://ufacw.com/
Link
https://exee.app/CKr4R
Version
0.0.0
What browsers are you seeing the problem on?
Firefox, Chrome
What OS are you seeing the problem on?
Windows
Anything else?
Hi bro
ufacw.com not bypassing successfully
i must disable fastforward extension and press continue on ufacw.com page to redirect to next step page on  exee.app/CKr4R
if not disable fastforward extension bypassing keep loading first page exee.app/CKr4R
thanxx

I second this

Duplicate of #710


Using nuxt-auth with server routes

Reproduction
Clone https://github.com/sidebase/nuxt-auth-example/tree/server-routes-example and npm run dev.
Describe the bug
In Nuxt 3 you can customize your server api routes. By default we put the NuxtAuthHandler in /server/api/[...].ts, however it is also possible to put it into /server/routes/auth/[...].ts This would change the url from "/api/auth" to only "/auth".
See https://nuxt.com/docs/guide/directory-structure/server#server-routes
However when you try to add the NuxtAuthHandler to this location you run into the following issue:
When you navigate to the signin page the form submit url is still /api/auth and not just /auth, even if you change your basePath.
<form action="http://localhost:3000/api/auth/signin/github" method="POST">
...
</form>

This issue was first reported by @cosbgn in our Discord!

I changed the baseURL to something else and it also did not update the urls:
ℹ Using http://localhost:3000/api/boo as the auth API location, make sure the [...].ts file with the export default NuxtAuthHandler({ ... }) is added there. Use the nuxt.config.ts auth.origin and auth.basePath config keys to change the API location

But the form still submits to /api/auth/... Is this a general issue with the baseURL not working correctly?
nuxt-config.ts:
// https://v3.nuxtjs.org/api/configuration/nuxt.config
export default defineNuxtConfig({
    css: [
<EMAIL_ADDRESS>    ],
    modules: ['@nuxtjs/tailwindcss', '@sidebase/nuxt-auth'],
    auth: {
        origin: process.env.ORIGIN,
        basePath: '/api/boo',
        enableGlobalAppMiddleware: true
    }
})


Refactor server auth

I've had to implement some slightly messy functionality to handle auth for the changefeed. We should to take another look at how we've implemented auth and come up with a cleaner implementation.

What about plugins from go1.8? I had to do some not-really-upstreamable wrapping to get auth working with our implementation of registry auth.

I think there's two components here. This issue was to address the organizational aspect of the code and where/how authz is applied. I think we'd want to address that either way.
Happy for there to be an additional issue to discuss the best way of adding alternative authz methods, and I'm tentatively excited about Go 1.8 plugins so IMO it should definitely be in consideration.

p.s. the big problem I was having with the changefeed was basically the location in the call graph that we invoke the authz checks, and how we bypass or allow an alternate authz mechanism for some endpoints vs others. The use case for that is imagine we had a way to point a downstream notary mirror at the upstream changefeed with say, mtls based authz, while still required token authz on the normal TUF endpoints.


How to create input of "loading HiC Fends" ?

Hi,
I don't understand how to create the input file that is loaded into a HiC Fend.
I see it can be a BED file with the following information:
chromosome, start, and stop position of each restriction fragment
or
chromosome, start, and stop position of the restriction enzyme recognition sites
Additionally, HiCPipe-compatible tabular fend files are mentioned. But it is not very clear for a newcomer like me.
How do I create such file, can anyone help me?

There are a few ways that you can create the fend file. The first is using a bed file. This can be a set of genomic fragments, such as
chr1 1622 1843```
or a set of RE site positions
```chr1 1619 1625
chr1 1840 1846```
If you want to use the HiCPipe-type binning normalization algorithm, you will need to include additional features about each fragment, such as GC content and mappability. This is done with additional columns in your bed file like
```chrom start stop name score strand GC mappability
chr1 1000 1622 frag1 0 + 0.5,0.48 1.0,0.95
chr1 1622 1843 frag2 0 + 0.45,0.5 0.8,0.9```
There are a couple of things to note about this. First, you need a header line that will give the name of each fragment-end (fend) attribute, like GC or mappability. These will be used when describing the normalization model setup. Second, because the bed file is describing a whole RE fragment which will be split into 2 fends, each attribute has two values separated by a comma, one for each end.

Alternatively, you can use the HiCPipe-style tabular fend file, which is formatted like this
```fend frag chr coord valid frag_len GC mappability
1 1 chr1 1000 1 622 0.5 1.0
2 1 chr1 1621 1 622 0.48 0.95
3 2 chr1 1622 1 221 0.45 0.8
4 2 chr1 1842 1 221 0.5 0.9```
This specifies one fend per line (note that to be compatible with HiCPipe, all fend and fragment values are start at one, not zero). This also needs to have a header line and can have additional columns for fend attributes. Additionally, the coordinate column describes the RE site that the fend is adjacent to and is closed interval (fends 2 and 4 include the base given by the coordinate).

Please let me know if you still have issues creating a fend file.

Thank you!!
I was unsure how to create the set of genomic fragments, the input. I used a function from the juicer pipeline to fragment my assembly (https://github.com/aidenlab/juicer/blob/master/misc/generate_site_positions.py).
Kind regards,
Ricardo