Hide when scrolling?

Is it possible to add functionality to hide the button while scrolling and display only when the scrolling stopped?

Hi, right now these are the implemented options.
/*! @enum MEVFloatingButtonDisplayMode  @abstract Display mode for the MEVFloatingButton.  @constant MEVFloatingButtonDisplayModeNone             Button not displaying.  @constant MEVFloatingButtonDisplayModeAlways           Button is displayed always.  @constant MEVFloatingButtonDisplayModeWhenScrolling    Button is just displayed when the user scrolls.  */ typedef NS_ENUM(NSInteger, MEVFloatingButtonDisplayMode) {     MEVFloatingButtonDisplayModeNone,     MEVFloatingButtonDisplayModeAlways,     MEVFloatingButtonDisplayModeWhenScrolling };
It wouldn't be difficult to implement since that option would be just the opposite that the mode MEVFloatingButtonDisplayModeWhenScrolling
Feel free to send a pull request.


Close issue button

Codecov Report

Merging #39 (0e4d610) into main (0cf4ff7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   35.00%   35.00%
=======================================
  Files           3        3
  Lines          20       20
=======================================
  Hits            7        7
  Misses         12       12
  Partials        1        1

Impacted Files
Coverage Δ

internal/smee/issues.go
53.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf4ff7...0e4d610. Read the comment docs.


feat: add GH info into docker-based predicate

Signed-off-by: Asra Ali<EMAIL_ADDRESS>This adds the following to the docker based build predicate:

GH context and workflow into the systemParameters
adds the builder ID from detect-env
adds the builder binary reference as a resolvedDependency
adds the invocation ID

The relevant funcs /types in github.ts and predicate.ts are copies from https://github.com/slsa-framework/slsa-github-generator/pull/1612, so at least I have a POC of how to replace and clean-up this code to share between the actions, but until I can correctly generate typescript libraries, progress is stalled on code cleanup. See https://github.com/slsa-framework/slsa-github-generator/issues/1470

Sorry about auto-merge, I will address in a second PR!

created https://github.com/slsa-framework/slsa-github-generator/issues/1622 for tracking


sendImageStatus/sendVideoStatus has thrown an error [invalid jid type: status@broadcast]

Environment

WhatsApp version: Version 2.2343.55
already update WPP 2.27.0

Steps to Reproduce
sendTextStatus is ok
sendImageStatus and sendVideoStatus has thrown an error
the result is OK, but when i refresh WhatsApp, the image or video status has gone
Still unable to sync to the mobile device 😢

This is not a throw error, but only a "warning" caught by "uncaught" proccess, you can ignore it.
About sendImageStatus, I tested it and it is working normally

This is not a throw error, but only a "warning" caught by "uncaught" proccess, you can ignore it.
About sendImageStatus, I tested it and it is working normally

can you sync to the phone?

Yes, you must change the default config sendStatusToDevice to true, but there are a chance to crash the device: https://wppconnect.io/wa-js/interfaces/Config.html

can you sync to the phone?

Yes, you must change the default config sendStatusToDevice to true, but there are a chance to crash the device: https://wppconnect.io/wa-js/interfaces/Config.html

can you sync to the phone?

thank you, it works


Simple example even simpler

Summary
Currently, the pyiron_workflow code is still more complex than other frameworks.
Detailed Description
Example from the README.MD:
wf = Workflow("my_workflow")
wf.a1 = x_plus_y()
wf.a2 = x_plus_y()
wf.b = x_plus_y(x=wf.a1.outputs.sum, y=wf.a2.outputs.sum)

out = wf(a1__x=0, a1__y=1, a2__x=2, a2__y=3)
out.b__sum
>>> 6

I would like to write:
out = x_plus_y(
    x=x_plus_y(x=0, y=1),
    y=x_plus_y(x=2, y=3),
)
out.sum

Further Information, Files, and Links
As far as I understand this is currently related to enforcing labels for the individual nodes of the workflow, so the suggestion would be to generate labels automatically. I am aware that labels can be helpful for debugging the workflow, but I would like to have a certain level of compatibility to existing python functions.

The demo is intentionally not the absolute simplest thing possible to demonstrate there is more flexibility and power than what you are showing. You can, of course, use the nodes without putting them in a workflow first.
There are a couple fundamental problems with the syntax you're requesting:

Execution is intentionally delayed, so out = x_plus_y(...); out.sum is missing an invocation to run things. Joerg and I have discussed this at length and settled that delayed execution is definitely desirable. It's possible there's a way to implement your desired syntax in a delayed way, but I don't see it -- we want to be able to both instantiate nodes and inspect their output without forcing an execution.
In principle, we allow nodes to have multiple return values, so argument assignments like x=x_plus_y(x=0, y=1) are not (necessarily*) sufficient
You can instantiate new nodes inside a function call, but IMO it's bad practice since then you do not have easy reference to those node objects. So this you can already do, I just don't advise it.

The "necessarily" above is that we have a separate SingleValue(Function) class that lets you just stick the entire node in as an output channel, since it only has one of these and thus is completely unambiguous. The snippet you posted is incomplete, but making this change is as simple as replacing @Workflow.wrap_as.function_node with @Workflow.wrap_as.single_value_node
Here is an example that is headed in the same direction as what you show and runs on the current code:
@Workflow.wrap_as.single_value_node("sum")
def x_plus_y(x: int = 0, y: int = 0) -> int:
    return x + y

n1 = x_plus_y(0, 1)
n2 = x_plus_y(2, 3)
n3 = x_plus_y(n1, n2)
n1 > n2 > n3
n1()
n3.outputs.sum.value
>>> 6

In workflows we do topological analysis on data connections to automatically define execution flows. Using the exact same tools for nodes that may or may not be inside a workflow by invoking a pull() method is what I've been working towards this week and part of last week, and is discussed more verbosely in #12 and #10, which are being implemented in #23 (e.g. this commit which allows input panels to fetch the most recent upstream data).
Because we don't yet expose tools to exploit data topology outside a workflow context, we're still stuck manually defining and triggering execution with the lines n1 > n2 > n3; n1(), which also necessitates that we instantiate all the nodes and have variable for them ahead of time. I agree this is ugly. A successful implementation of pull() will allow us to write the following:
@Workflow.wrap_as.single_value_node("sum")
def x_plus_y(x: int = 0, y: int = 0) -> int:
    return x + y

node = x_plus_y(x=x_plus_y(0, 1), y=x_plus_y(2, 3), 1))
node.pull()
>>> 6
# Pull should return the value directly,
# just like running a function node currently does
# Of course it's still available later at
# node.outputs.sum.value

Although I still don't really advise instantiating nodes as arguments for other nodes, because if you want to reference them in the future you'd need to track it down with something some ugly like nodex = node.inputs.x.connections[0].node -- usually wiser to just instantiate it into it's own variable and then write node = x_plus_y(nodex, nodey) (or whatever you named the variables). If you really don't want to have any node variables kicking around, you could even do the above as a one-liner: x_plus_y(x=x_plus_y(0, 1), y=x_plus_y(2, 3), 1)).pull()
That's all I have to say about easy syntax and workflow-free running, as a final aside on this comment:

As far as I understand this is currently related to enforcing labels for the individual nodes of the workflow, so the suggestion would be to generate labels automatically.

I just want to point out that we already do generate labels automatically, not just for function nodes but also for workflows. If you just add a node to a workflow a name will be generated for it automatically based on the node class. If you turn off strict naming you can even add things repeatedly and it will just quietly iterate on the class name:
@Workflow.wrap_as.single_value_node("sum")
def x_plus_y(x: int = 0, y: int = 0) -> int:
    return x + y

wf = Workflow("my_wf", strict_naming=False)
wf.add(x_plus_y(0, 1))
wf.add(x_plus_y(2, 3))
wf.add(x_plus_y(wf.x_plus_y, wf.x_plus_y0))
wf.nodes.keys()
>>> dict_keys(['x_plus_y', 'x_plus_y0', 'x_plus_y1'])

Hi @liamhuber, looking through the examples I guess the pull mode is exactly what I am looking for.


Individual wiki articles fail to load without trailing slash

https://www.freecodecamp.com/wiki/en/python doesn't work but
https://www.freecodecamp.com/wiki/en/python/ does

One possible reason can be that URLs that pointed to files did not include the trailing slash, while URLs that pointed to directories do include the trailing slash. This means that:
http://web.about.com/example/ is a directory, while
http://web.about.com/example is a file


Do not choke on MessageSet without version

If we end un unlucky and MessageSet buffer is truncated right before
we can read magic value, we just return ErrInsufficientData, even
if some messages were previously successfully parsed.
This propagates all the way up to partitionConsumer, where we zero
parsed messages, which results in ErrMessageTooLarge returned
to the consumer.
This commit fixes the issue by setting PartialTrailingMessage to true
on MessageSet, making it possible to read successfully parsed messages.

Nice find, thanks.


[QUESTION] Config not working on docker?

Hi there. This looks great, and I'm trying to deploy it with docker. However, I'm having issues with configuration.
I've mapped the volume to conf.yml, and as far as I can tell - it's working. When I modify config in the web UI and save, I can see the changes in my conf.yml file.
After saving, I do a rebuild, which also completes just fine (log output below).
Using Dashy V-1.5.7. Update Check Complete
Unable to check for updates

-  Building for production...
 WARN  A new version of sass-loader is available. Please upgrade for best experience.
 DONE  Compiled successfully in 14894ms9:06:55 AM

  File                                      Size             Gzipped

  dist/js/chunk-vendors.18a6705c.js         1919.94 KiB      559.08 KiB
  dist/js/dashy.b20dbb74.js                 212.71 KiB       62.97 KiB
  dist/precache-manifest.50c09b745725981    19.66 KiB        3.47 KiB
  e237f7cae6741b734.js
  dist/js/about.0c77a650.js                 4.48 KiB         1.99 KiB
  dist/service-worker.js                    1.04 KiB         0.61 KiB
  dist/css/dashy.2d652b28.css               110.25 KiB       16.72 KiB
  dist/css/chunk-vendors.c7f81a37.css       6.59 KiB         1.93 KiB
  dist/css/about.a64c098d.css               1.04 KiB         0.34 KiB

  Images and other types of assets omitted.

However, after a reload, none of my changes are visible, and when going back to config in the web UI, it's back to default values.
So it's kind of like it can write the conf file, but not read it?
For simplicity, I tried just removing one of the navbar links, so here's how my conf.yml file looks after saving from web UI:
appConfig:
  layout: "auto"
  iconSize: "medium"
  language: "en"
  theme: "nord"
pageInfo:
  title: "Dashy"
  description: ""
  navLinks:
    - title: "Home"
      path: "/"
  footerText: ""
sections: []

Hmm, that's weird, the config file should be being read. It sounds like the old changes are being cached in your browser, (do you see the correct data in Incognito mode?). You should be able to fix this by coing to Config --> Reset Local Settings. This won't affect your conf.yml file, but will clear the cached data.

I just moved to my desktop computer, and here the changes are visible. So I think you're on to something. I'll just close this for now.

Great, I'm glad it's working.
When you apply changes through the UI config editor, there's an option to apply locally only, and this takes precedence over whatever is in the conf.yml file, so I guess that is what happened.
Btw, if you're enjoying Dashy, consider giving it a :star: - it helps others find it :)

I think this has to do with the way Docker handles bind mounts. When you point to a file, the Docker assigns an inode when the container is created. This inode is not updated if the file is changed outside Docker.
The proper solution would be to use a directory bind mount, instead of a file bind mount. From what I can see, there are other files stored in /app/public, so that wouldn't work.  I would suggest moving the conf.yml to it's own isolated folder and updating the docker-compose to point to that folder rather than explicitly to the file.
There's a pretty good example of what I'm trying to say here: https://medium.com/@jonsbun/why-need-to-be-careful-when-mounting-single-files-into-a-docker-container-4f929340834

Thanks, I think this issue was caused by the browser cache. But yeah, this is true, feel free to update it to be in a directory, but I think you'll face issues with Vue requiring custom source content to in the the src dir, and assets in public, making it hard to have a single mounted dir.


fix: set aria-describedby value wrong when custom id

When I set an id to props, the screen reader didn't work. I found that aria-describedby is the value of uuid, not the id value I passed.


CAMEL-21517: Deprecate camel-google-pubsub-lite

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

You need to generate catalog/camel-catalog also and the dsl/component-dsl likely as well


Bring route to front on hover

Not quite there - apologies.

OK, now good to go, I think.

I think we should also set the zIndex of the start point. It currently gets hidden by the route on hover.

I've added that to the codebase, but my local version is now hanging. If you can check this branch yourself, that would be great - not sure what issue I have.

All working now, and I think looks good to go.


Requesting some help, 2 Deg of Freedom Inverted Pendulum,

I was trying to extend the inverted Pendulum model implemented in the examples to a 2 degrees of freedom Inverted Pendulum,
@with_kw struct Pendulum_2D_MDP <: MDP{Array{Float32}, Array{Float32}}
    failure_thresh::Union{Nothing, Float64} = nothing # if set, defines the operating range fo the pendulum. Episode terminates if abs(θ) is larger than this.
    θ0_x = Distributions.Uniform(-π, π) # Distribution to sample initial angular position in the x direction
    ω0_x = Distributions.Uniform(-1., 1.) # Distribution to sample initial angular velocity in the x direction
    θ0_y = Distributions.Uniform(-π, π) # Distribution to sample initial angular position in the y direction
    ω0_y = Distributions.Uniform(-1., 1.) # Distribution to sample initial angular velocity in the y direction
    Rstep = 0 # Reward earned on each step of the simulation
    λcost = 1 # Coefficient to the traditional OpenAIGym Reward
    max_speed::Float64 = 8.
    max_torque::Float64 = 2.
    ashift::Float64 = 0.0
    dt::Float64 = .001
    g::Float64 = 9.81
    m::Float64 = 65.
    l::Float64 = 1.1
    γ::Float32 = 0.9
    ashift_x::Float64 = 0.0
    ashift_y::Float64 = 0.0
    actions::Vector{Float64} = [[-1., 1.]]
    include_time_in_state = false
    maxT = 99*dt
    px = nothing # Distribution over disturbances
end

The extension that is 2DoF Inverted Pendulum is modelled by a system of equations called pendulum_2d_dynamics_ODE. The function returns the solution at the next time step.
The Pendulum_2DoF_dynamics is given below

function pendulum_2d_dynamics(env, s, a, x = isnothing(env.px) ? 0 : rand(env.px); rng::AbstractRNG = Random.GLOBAL_RNG)
    # Deal with terminal states
    # println("failur thresh: ", env.failure_thresh, " val: ", abs(s[1]))
    if (isnothing(env.failure_thresh) ?  false : abs(s[1]) > env.failure_thresh)
        # println("here")
        return fill(-100, size(s)), 0
    elseif env.include_time_in_state && (s[3] > env.maxT || s[5] ≈ env.maxT)
        return fill(100, size(s)), 0
    end

    θ_x = s[1]
    ω_x = s[2]
    θ_y = s[3]
    ω_y = s[4]
    dt, g, m, l = env.dt, env.g, env.m, env.l

    a_x = a[1]
    a_y = a[1]
    a_x = clamp(a_x, -env.max_torque, env.max_torque)
    a_y = clamp(a_y, -env.max_torque, env.max_torque)
    costs = angle_normalize(θ_x)^2 + 0.1f0 * ω_x^2 + 0.001f0 * a_x^2 + angle_normalize(θ_y)^2 + 0.1f0 * ω_y^2 + 0.001f0 * a_y^2

    a_x = a_x + env.ashift
    a_y = a_y + env.ashift

    a_x = a_x + x
    a_y = a_y + x

    θ_x, ω_x, θ_y, ω_y = pendulum_2d_dynamics_ODE(a_x, a_y, θ_x, ω_x, θ_y, ω_y, m, g, l)

    #=
    ω = ω + (-3. * g / (2 * l) * sin(θ + π) + 3. * a / (m * l^2)) * dt
    θ = angle_normalize(θ + ω * dt)
    ω = clamp(ω, -env.max_speed, env.max_speed)
    =#

    if env.include_time_in_state
        sp = Float32.([θ_x, ω_x, θ_y, ω_y, s[5] + dt])
    else
        sp = Float32.([θ_x, ω_x, θ_y, ω_y])
    end
    r = Float32(env.Rstep - env.λcost*costs)
    return sp, r
end

The Deep_RL is defined as
A = [-2., -0.5, 0, 0.5, 2.]
𝔄 = Base.Iterators.product(A,A) |>collect |>vec
𝔄_2D = [collect(a) for a in 𝔄]

mdp = InvertedPendulum_2D_MDP(actions=A)
as = [actions(mdp)...]
amin = [-2f0]
amax = [2f0]
rand_policy = FunctionPolicy((s) -> Float32.(rand.(Distributions.Uniform.(amin, amax))))
S = state_space(mdp, σ=[3.14f0, 8f0, 3.14f0, 8f0])

SG() = SquashedGaussianPolicy(ContinuousNetwork(Chain(Dense(4, 64, relu), Dense(64, 64, relu), Dense(64, 1)), 1,), zeros(Float32, 1,), 2f0)

𝒮_reinforce = REINFORCE(π=SG(), S=S, N=10000, ΔN=2048, a_opt=(batch_size=512,))
π_reinforce = POMDPs.solve(𝒮_reinforce, mdp)

The problem I am facing is how do I setup an action space with now 2 torques, called a_x and a_y. I don't know if the way I have done it will work. However I am getting very good rewards.
Step: 0, undiscounted_return: 98.408066
Step: 2048, undiscounted_return: 98.030914, actor_batches_trained: 320, actor_loss: 5.8472886, entropy: 1.4157778, actor_grad_norm: 0.83697426, kl: -0.0006680194
Step: 4096, undiscounted_return: 98.45372, actor_batches_trained: 320, actor_loss: 5.8725863, entropy: 1.4154032, actor_grad_norm: 0.86363125, kl: -0.0013817283
Step: 6144, undiscounted_return: 97.804565, actor_batches_trained: 320, actor_loss: 5.89741, entropy: 1.4170549, actor_grad_norm: 1.0493901, kl: -0.00082278205
Step: 8192, undiscounted_return: 97.0133, actor_batches_trained: 320, actor_loss: 5.9142237, entropy: 1.4090993, actor_grad_norm: 1.1050732, kl: -0.00086959853
SquashedGaussianPolicy(ContinuousNetwork(Chain(Dense(4 => 64, relu), Dense(64 => 64, relu), Dense(64 => 1)), 1, Flux.cpu), ContinuousNetwork(Chain(ConstantLayer{Vector{Float32}}(Float32[-0.013098647])), 1, Flux.cpu), 2.0f0, false)

I am pretty sure something is seriously wrong. Requesting some help regarding this implementation. Thank you very much.

I can't speak to the implementation of the pendulum, but I will note that the reward is currently just +1 for the pendulum being "upright". Have you mde sure that the way the failure threshold is being used and computed makes sense for the 2DoF case? Because if the terminal condition is never really being triggered then you might end up with really high reward while the pendulum is just randomly moving around. Maybe try extending the "render" implementation so you can visualize whats going on?
As for the action space, it looks like you have conflated discrete and continuous actions. You are giving the pendulum MDP a discrete set of 2D actions, but your policy is describing a 1D continuous action. To make a 2D continous action just make the output head of the ContinuousNetwork have 2 outputs instead of 1. You can see an example of this in the half_cheetah examples which has 6-dim actions.  If you want to use your discete actions then you should change your policy type to a DiscreteNetwork with the appropriate number of output heads (which I think for your case would be 5x5=25).  Also note that you are taking both a_x and a_y from the first element of a, which is why this is running at all, since I'm pretty sure only a 1D action is being passed to the dynamics function.

Greetings, thank you very much for your response. I tried to jump into new implementations without actually understanding much of it. Apologies.
The physics model is just an implementation of a generally well accepted 2 DoF Pendulum model that I run using ModelingToolkit.
This is what I have now for $n$-dimensional action space, in this case $n=2.$ I am now using $Continuous Action Space.$

function pendulum_2d_dynamics(env, s, a, x = isnothing(env.px) ? 0 : rand(env.px); rng::AbstractRNG = Random.GLOBAL_RNG)
    # Deal with terminal states
    # println("failur thresh: ", env.failure_thresh, " val: ", abs(s[1]))
    #println(a)
    if (isnothing(env.failure_thresh) ?  false : abs(s[1]) > env.failure_thresh || abs(s[1]) > env.failure_thresh)
        # println("here")
        return fill(-100, size(s)), 0
    elseif env.include_time_in_state && (s[5] > env.maxT || s[5] ≈ env.maxT)
        return fill(100, size(s)), 0
    end

    θ_x = s[1]
    ω_x = s[2]
    θ_y = s[3]
    ω_y = s[4]
    dt, g, m, l = env.dt, env.g, env.m, env.l

    a_x,a_y = a
    a_x = clamp(a_x, -env.max_torque, env.max_torque)
    a_y = clamp(a_y, -env.max_torque, env.max_torque)
    costs = angle_normalize(θ_x)^2 + 0.1f0 * ω_x^2 + 0.001f0 * a_x^2 + angle_normalize(θ_y)^2 + 0.1f0 * ω_y^2 + 0.001f0 * a_y^2
    #=
    a_x = a_x + env.ashift
    a_y = a_y + env.ashift

    a_x = a_x + x
    a_y = a_y + x
    =#

    θ_x, ω_x, θ_y, ω_y = pendulum_2d_dynamics_ODE(a_x, a_y, θ_x, ω_x, θ_y, ω_y, m, g, l)

    if env.include_time_in_state
        sp = Float32.([θ_x, ω_x, θ_y, ω_y, s[5] + dt])
    else
        sp = Float32.([θ_x, ω_x, θ_y, ω_y])
    end
    r = Float32(env.Rstep - env.λcost*costs)
    return sp, r
end

mdp = InvertedPendulum_2D_MDP()
#as = [actions(mdp)...]
adim = length(POMDPs.actions(mdp)[1])
amin = [-2f0, -2f0]
amax = [2f0, 2f0]
rand_policy = FunctionPolicy((s) -> Float32.(rand.(Distributions.Uniform.(amin, amax))))

S = state_space(mdp, σ=[3.14f0, 8f0, 3.14f0, 8f0])
shared = (max_steps=100, N=Int(10000), S=S)
on_policy = (ΔN=1000,
             λ_gae=0.97,
             a_opt=(batch_size=500, optimizer=Adam(3e-4)),
             c_opt=(batch_size=40, optimizer=Adam(1e-3)))

μ() = ContinuousNetwork(Chain(Dense(S.dims[1], 64, tanh),
                              Dense(64, 32, tanh),
                              Dense(32, adim)))
V() = ContinuousNetwork(Chain(Dense(S.dims[1], 64, tanh),
                              Dense(64, 32),
                             Dense(32, 1)))
log_std() = -0.5f0*ones(Float32, adim)
𝒮_ppo = PPO(;π=ActorCritic(GaussianPolicy(μ(), log_std()), V()), λe=0f0, shared..., on_policy...)
π_ppo = POMDPs.solve(𝒮_ppo, mdp)

Of course most of it is just an adaptation to the "half-cheetah" model. I hope it now makes sense.
More importantly, deepest appreciation and gratitude for this package. I have learnt a lot in a much broader sense. Thank you.

I'm happy to help.
The implementation looks fine at a cursory glance, but of course I can't be sure. You'll need to continue testing it for yourself to build confidence in your implementation.
Are your issues resolved and can I close the issue?

Thanks very much. Yes, please. Further, I hope I can seek clarification in the near future, if it would be okay with you.


Don't revert the date when input is invalid

See http://jsfiddle.net/cmpgtuwy/5/
I've come across an issue with the current behaviour regarding invalid input.  Currently, if the value entered is an invalid date, as soon as focus is lost the datepicker will revert the value to the previously valid date.
This is problem in the situation I am using it in (which can be replicated at the above link).
If the user was to type "Feb 29, 2015" into the input box (as an example of an invalid date), and then click the "Get Current Date" button, I would expect that I would get an invalid date object as the current value of the datepicker.  However, I simply get the previous valid value.
This is problematic when the button is actually a "Save and Close" button, because the user may not even see that the value reverted.  Since the .date() call returns a valid date, my validation routines don't fail and therefore the save would go ahead, but with a different value than the user is expecting.
Can we please have a way to force the invalid value to stay in there, and for the .date() call to return the invalid date?  That way I can call .isValid() on the moment object that gets returned, to see what the error is.

Hi,
Maybe seperate from your issue but would it make sense to have the input readonly so that way user is forced to select date instead of typing? This is my current implementation to remove that user error factor. Unfortuantly the read only input is not working with the current version in master but is an easy fix pending this issue: https://github.com/Eonasdan/bootstrap-datetimepicker/issues/764
Thanks!

THat's a possibility, but power users like the ability to quickly type dates in, which can be much faster than picking them with the picker.

We would also like to be able to have invalid values in the field. In our case users can optionally use datetime picker to select date in specific format or input date in more freely manner (for example if they only know year). I thought the option userStrict would do it, but it seems to have no effect.

extraFormats might solve your issues. PR #666 allows for you to include several valid format.
@vixriihi you should be able to include formats like ['YYYY'] if you want to allow them to enter just a year.
This option will auto format the input to the "master" format however. In other words, even if you allow typing in just the year, moment will convert that to 1/1/2015.
Aside: useStrict is to make moment more strict when it considers a date valid or not.

+1 We would like to be able to keep userinput and just show him where the wrong field is.

@Eonasdan thanks for the useStrict clarification. Yes using that format would work, but in our case user should be able to input 2015 & 2015-02-03 & hulapaloo and all these are valid in our case. If the user chooses to use datetime picker the value would then be 2015-02-03. I'd would like to see an option to allow "invalid" (from the datetime pickers viewpoint) values also.

We have a case where users can either pick a fixed date with the picker or enter an offset date such as *-1 Hour.   This is very common in many time series systems and the new picker just does not allow this once the picker is bound to the text area.   I was unable to upgrade to the latest momentjs and this control as a result.
Please allow the user to enter whatever they want.

I could live with reverting it or clearing it out, but what I'm seeing right now with a time picker is that it's setting the time to 12:00 AM, which is a bit of a problem if the user doesn't notice that happen and saves anyway.  I looked at code but couldn't find any options that would prevent this behavior.

keepInvalid has been added to the dev branch. setting this to true will not force the date to the previous date.
You can, in case you didn't realize, listen for dp.error and change the picker or throw your own error messages

Assuming no other major issue with the dev branch come up this week, dev will be promoted to master March 7th.

In our scenario, we let users manually input dates using the keyboard. If a user enters a valid date and then an invalid date, the keepInvalid flag at true makes it so that the invalid date stays in the textbox. However, the picker still returns the previous valid date when using the function date(). To avoid this, I added a handler to the dp.error event and in it I set picker.date(null);. However, this clears the invalid value entered in the textbox. In some cases, it would be preferable to keep the invalid value so it can just be adjusted.
So, what would be the recommended way of nullifying the picker value while retaining the invalid value in the textbox? One way I can think of is accessing the input text and setting its value, but before going this way I'd like to know your opinion.
Thanks!


💡 Wrapping: The Pit

I'll be using this issue to track updates on Bed Wars wrapping.
If there are any values you would like wrapped that aren't wrapped yet, please let me know in this issue.

You said "Bed Wars wrapping" rather than "The Pit wrapping". Little typo there.

You said "Bed Wars wrapping" rather than "The Pit wrapping". Little typo there.

sorry for my brainrot, fixed


Add dataset: unsilencing_dutch_colonial_archives

A URL for this dataset
https://github.com/budh333/UnSilence_VOC/tree/v1.3
Dataset description

we contribute a fit-for-purpose annotation typology and apply it on the colonial archive of the Dutch East India Company (VOC). We release a corpus of nearly 70,000 annotations as a shared task, for which we provide strong baselines using state-of-the-art neural network models.

Dataset modality
Text
Dataset licence
Creative Commons Attribution 4.0 International
Other licence
No response
How can you access this data
As a download from a repository/website
size of dataset
<500MB
Confirm the dataset has an open licence

[X] To the best of my knowledge, this dataset is accessible via an open licence

Contact details for data custodian
No response

#self-assign

WIP here: https://huggingface.co/datasets/biglam/unsilence_voc. Need to complete dataset card.


Torch should be above flash-attn in requirements.txt

If torch is below flash-attn in requirements.txt, it doesn't work properly since flash-attn depends on torch.
File "C:\Users\user\AppData\Local\Temp\pip-install-7czi3fmk\flash-attn_6da82b15991a4532b7dc3a5aefc5ec40\setup.py", line 19, in
import torch
ModuleNotFoundError: No module named 'torch'

Thanks for pointing out the issue. We've adjusted the order in requirements.txt accordingly.


MRTK 3 World Locking Tools

I have been trying to get the WLT set up working inside of MRTK 3 but I have been having issues. Are there any plans to upgrade to MRTK 3? This is such a great capability I would love to use it with the new system.
This is what I see when I bring it into the MRTKDevTemplate for MRTK 3

Check out https://github.com/Fuzzy-Door-Tech/WLT-MRTK3-Port
You might find this helpful :)

@Cmacfdt thanks for sending over, I had posted a solution over in another thread as well for those that are interested.
https://github.com/microsoft/MixedRealityToolkit-Unity/discussions/11628


Status - Status icon next to profile avatar does not open status page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.53-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

User has set a status

Go to staging.new.expensify.com
Click on the status icon next to profile avatar

Expected Result:
Status page will open
Actual Result:
Profile settings page is opened
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3586e10e-00f3-4c6e-a838-93ae467fdf39
View all open jobs on GitHub

@sonialiap  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal
Please re-state the problem that we are trying to solve in this issue.
Status - Status icon next to profile avatar does not open status page
What is the root cause of that problem?
There is not navigation here
What changes do you think we should make in order to solve the problem?
Add navigate to status page here
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Status - Status icon next to profile avatar does not open status page
What is the root cause of that problem?
Here :
https://github.com/Expensify/App/blob/d17b4df0809e941faf52a49d9a9eac295ba46e83/src/pages/home/sidebar/BottomTabAvatar.tsx#L28
showSettingsPage is passed.
What changes do you think we should make in order to solve the problem?

In place of that we need to pass this:
interceptAnonymousUser(() => Navigation.navigate(ROUTES.SETTINGS_STATUS));

What alternative solutions did you explore? (Optional)
N/A

Updated Proposal with working result

Proposal
Updated.

Proposal
Updated.

Updated a detailed proposal

Yup. This is not a bug; it is the desired behavior. We just recently changed this behavior to make the entire tab target area clickable/tappable.

@Krishna2323 the reason we changed this behavior is because the tap area for the status is SO small that actually tapping on it will be unpredictable (especially on mobile). To keep things simple and clear, we've updated the bottom tab behavior so that tapping anywhere in the avatar tab click area takes you to the avatar tab (or whatever we call it). This makes the tab much more usable and predictable.
If we leave the status as a separate navigational element, it's very likely that sometimes tapping down there will take you to the status, and sometimes will take you to the tab (depending on which hit area you tapped—on purpose or inadvertently).


Better placing elements at sell page

I did moded Auctionator.xml to better suit "Per Item" input boxes and "Create %d Auctions" button, actually these overlap and or not suit frame.
Line 600, 604 and 739 to 740 in Auctionator.xml
AbsDimension x="10" y="-70" original x="10" y="-82"
AbsDimension x="10" y="-110" original x="10" y="-128"
AbsDimension x="180" y="30" original x="185" y="30"
AbsDimension x="7" y="-150" original x="3" y="-170"
Sorry I did must remove all XML tags, because then wasn't properly formated here even I did use CODE tag.
I'm not sure if this is not scaling problem so I put here my UIScale and screen dimension, 0.64 and 1920 by 1200 so ratio is 16:10.

The xml layout for Auctionator has been revamped and may no longer overlap come Legion. If the version that will be compatible after the pre patch still does this, please raise a new issue.


Add the discovery foreign keys

What do you think about discovery foreign keys ?
I'm on a use case that is a database discovery with relations between tables.
I know there is the discoverForeignKeys method that exist.
Do you ever used it ?
I'm gonna test it, and if you're interested, I can try to integrate in your package.

FYI, I succeed in adding Foreign Keys, in 'belongsTo' type.
In fact,  discoverAndBuildModels return everything.
We just have to reorganized the result to match correctly the model expected by Loopback.
Tell me what you think @akera-io / @marianedu ?

Bonjour Mathieu,
probably the easiest way will be for you to clone this, make your changes and send a pull request so we can incorporate your changes.
Right now we were using this with a Progress database which sadly is missing the R (relational) as there is no concept of foreign-key there, but will gladly extend this to support relations if possible.
Regards,
Marian


Configure Playwright to work with Next.js

This Pull request integrates Playwright E2E test framework in the Next.js project.
Updated README.md with instructions.
Resolves #40

Thanks @Saptarshee94 for the quick integration.


Highlighting and Notetaking

This may seem like overkill, and I understand it likely involving a lot of code, but the way I see it, it would be an extension of what's already there.  That is to say, in addition to being able to select and copy text, the ability to highlight/underline selected text and add notes on the page would be really great too.  Just a thought!

that kinda would sort of take out the pleasure of marking up my comic, while still reading the comic.  I guess, what I'm looking for is an experience that mimics actually reading a comic commenting and wanting to make notes right on top the pages as I see them.  Most pdf software have this feature, but I guess your app would be a first for comic book readers if it were somehow implemented.  notwithstanding, appreciate the time you've taken to respond.


Unnecessary amount of rollback checks

If a client is running at a frame rate of 240hz and a fixed tick rate of 60hz, it will check if it needs to do a rollback ~4 times for every fixed tick that it runs. This seems excessive as the server will only send 60 updates a second and so 3 out of the 4 checks are redundant. I think lightyear could restrict the rollback check to only run if it received an update from the server for a confirmed entity on the current frame.

Never mind! It looks like check_rollback() already makes this check. I think there is a bug then. When I run avian_3d_character I see that check_rollback will perform a check ~4 times before executing a tick. That would suggest the server sent 4 ticks before the client executed 1.

Never mind, again... The 4 checks are for 4 different predicted components. Closing this issue as there is no issue.


49 | Group Anagrams |C++

Title -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Code
[x] Improving Documentation
[x] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[ ] Python
[x] C++
[ ] Java
[ ] SQL

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please Assign this issue to me @SSKale1

[x] @hjpassion Assigned it to u


Added a null check (fixes a crash issue)

Please, merge this.

Hey,
You will need to submit this pull request to the upstream repo at https://github.com/JetBrains/intellij-community if you wish it to be merged
This is an merely an unofficial mirror repo containing only fernflower, and I don't really have anything to do with fernflower myself


Improved proxy generating macros

Current macros are very ugly, written before I had a full grasp of the capabilities of rust meta-programming,
I intend to make things like these possible:
#[derive(ScriptProxy, Reflect)]
#[proxy(languages("on_feature(lua)"))]
#[functions[

    #[lua(MutatingMetaMethod)]
    fn basd(mut self) {

    }

    #[lua(MetaMethod)]
    fn asd(self);

    #[lua(Function)]
    fn basda(self);
]]
pub struct Lol {}

I can take a peek at this in a few days!

Sure thing!
I've been working on the Lua version of this over at this branch: https://github.com/makspll/bevy_mod_scripting/tree/feature/derive_macros
I've got a basic macro going there. Similar work needs to be done for Rhai and can this easily be done in parallel if you're interested! Rhai however does not yet have existing proxy macros, but the crate itself has a lot of cool features which would make it interact nicely with a macro structure like the one above (and you'd probably want to bump its version).
Generally the vague steps would be:

[ ] Set up macro structure akin to how it's done on the branch above (the main crate uses a derive macro which then calls a proc macro for each language crate (since proc macros are more flexible)), output no code.
[ ] Let the macro generate the proxy definition (this is done via a helper macro bevy_script_api::make_script_wrapper!), think of these as a container on the script side which can either be a reference to a bevy thing (via their reflection mechanism) or an actual value of the type stored "script-side".
[ ] Once the macro generates a proxy now it needs to implement some traits on the PROXIED TYPE, the core one is RhaiProxyable, have a look at bevy_script_api/src/rhai/mod.rs where important traits are defined. The most important mechanism you need to be aware of is how our type gets resolved to its proxy on the script side, and this happens here:

   impl ToDynamic for ScriptRef {
   fn to_dynamic(self) -> Result<Dynamic, Box<EvalAltResult>> {
       // clone since it's cheap and we don't want to clone self later
       let world = self.world_ptr.clone();
       let world = world.read();

       let type_data = world.resource::<AppTypeRegistry>();
       let g = type_data.read();

       let type_id = self.get(|s| s.type_id())?;

       if let Some(v) = g.get_type_data::<ReflectRhaiProxyable>(type_id) { // if it implements ReflectRhaiProxyable, then the trait is used to generate a proxy and this gets used on the script side when interacting with the world
           v.ref_to_rhai(self)
       } else {
           // otherwise we just use a generic type which handles very simple operations but nothing more
           ReflectedValue { ref_: self }.to_dynamic()
       }
   }
}

[ ] if you register this type with the app using bevy_script_api::register_foreign_rhai_type, you will now be able to use ScriptWorld in a rhai script to retrieve your proxy in a script via (have a look at the bevy_api_rhai.rs example for how to setup a world to test this) :

    let my_component_type = world.get_type_by_name("MyComponent");
    let my_component = world.get_component(entity,my_component_type);

[ ] now what's left is actually automatically proxying functions ,fields etc, this is the hard bit. Like with the Lua macros, for this you'd look at the types in bevy_script_api/src/rhai/bevy/mod.rs which defines some script-side api types and for each function, field, operator etc, you'd want to use the proxy functions available to you to convert invocations of these functions on the script side, so that the arguments which correspond to other proxies generated with the same macro, are resolved to their "proxied" types, the operation is then performed over these "inner" types, and the result is converted to its proxy via the traits you implemented earlier and returned.

Doing any of the above would be helpful!

Alright, will be starting to look at this tomorrow!

Hey there - I'm finally getting around to this, and I'm currently spending my time trying to better understand the structure of the Lua interops so I can port most of them to Rhai, but progress has been started and will be built upon. It may take me a bit, as I've been laid off as of a few days ago and need to devote my time to finding a way to pay rent, but my down time will be tackling this issue. Just wanted to communicate that!

Hey man, no worries. That's very rough and I hope you find a new job soon! Any help is much appreciated, but of course there is no rush!

@makspll I've opened a draft PR which is very much a work in progress, but I wanted to open it so you could see the work that was being done as my understanding/knowledge on the project progresses and make any suggestions/comments as you see fit.

@thedanvail of course I will have a look now and keep a regular watch in parallel to developing the Lua branch.


OBS CI does not fail on unresolvable status

Description of problem
With #799 PR the new distro failed silently due to unresolvable status, the checks needs better validation
<resultlist state="a1df197a661172cef5c33d1c6889c078">
  <result project="home:katacontainers:ci:x86_64:packaging-PR-799" repository="xUbuntu_19.04" arch="x86_64" code="published" state="published">
    <status package="kata-containers-image" code="succeeded"/>
    <status package="ksm-throttler" code="unresolvable">
      have choice for fakeroot needed by devscripts: fakeroot pseudo
    </status>
    <status package="linux-container" code="succeeded"/>
    <status package="proxy" code="unresolvable">
      have choice for fakeroot needed by devscripts: fakeroot pseudo
    </status>
    <status package="qemu-lite" code="succeeded"/>
    <status package="qemu-vanilla" code="succeeded"/>
    <status package="runtime" code="unresolvable">
      have choice for fakeroot needed by devscripts: fakeroot pseudo
    </status>
    <status package="shim" code="unresolvable">
      have choice for fakeroot needed by devscripts: fakeroot pseudo
    </status>
  </result>

Expected result
The CI fails on this cases
Actual result
Fails silently

Specifically need to handle another case like
https://github.com/kata-containers/packaging/blob/master/obs-packaging/wait-obs.sh#L44
if echo "${out}" | grep 'failed'; then
			echo "Project ${project} has failed packages"
			osc pr
			exit 1
fi

or fall back if if is not any of the known status it expect and fail


FromQuery parameter binding fails for multi-valued (array) params if a name isn't explicitly given

Is this a Bug or Feature request?:
A bug, it appears.
Steps to reproduce (preferably a link to a GitHub repo with a repro project):
https://github.com/lisardggY/AspNetControllerTest
Description of the problem:
I've encountered strange behavior when binding multi-valued controller parameters with [FromQuery] in ASP.NET Core 2.1.1.
For this controller signature:
public ActionResult<IEnumerable<string>> Get([FromQuery] string[] user)
I expect to be able to call with
http://server/api/values?user=a&user=b
but this will always return an empty array in user - even if I only pass a single value.
However, explicitly stating the name of the query parameter will work:
public ActionResult<IEnumerable<string>> Get([FromQuery(Name = "user")] string[] user)
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
Microsoft.AspNetCore.App 2.1.1

Thanks for contacting us, @lisardggY.
@dougbu, can you please look into this? Thanks!

@lisardggY is your controller associated with an [ApiController] attribute?
If yes, this is a duplicate of #7712. The fix is available in the https://dotnet.myget.org/gallery/aspnetcore-dev feed. I suggest choosing an early 2.2.0 Preview 1 version e.g. https://dotnet.myget.org/feed/aspnetcore-dev/package/nuget/Microsoft.AspNetCore.Mvc/2.2.0-preview1-34762

Oops, missed your repro link. This is indeed a duplicate of #7712.

Ah, I missed that one when searching the issues list. Glad to see it was fixed. Thanks!


add defensive check for none token for read events

please review @rajivmucheli - I fixed the issue which was python 3.8 is no longer supported by oslo-utils, so upgrading to python 3.9 fixes the issue.


libusb errors

Version 1.4.0 and 1.4.1.
Installed libusb-1.0.19 using homebrew.
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
Claiming interface...
Setting up interface...

Initialising protocol...
Protocol initialisation successful.

Beginning session...
libusb: error [submit_bulk_transfer] bulk transfer failed (dir = Out): no connection to an IOService (code = 0xe00002c0)
libusb: error [submit_bulk_transfer] bulk transfer failed (dir = Out): no connection to an IOService (code = 0xe00002c0)
libusb: error [submit_bulk_transfer] bulk transfer failed (dir = Out): no connection to an IOService (code = 0xe00002c0)
libusb: error [submit_bulk_transfer] bulk transfer failed (dir = Out): no connection to an IOService (code = 0xe00002c0)
libusb: error [submit_bulk_transfer] bulk transfer failed (dir = Out): no connection to an IOService (code = 0xe00002c0)
ERROR: Failed to begin session!
Releasing device interface...

Bad cable. Replaced USB cable and all is good.


Android pictionary time change causes line wrap that moves screen while drawing

On a Pixel 3 while drawing on pictionary, the screen jumps down then up again depending on the width of the time.   So when the time goes from 1:10 to 1:09, the latter is wider and causes the line to wrap -  "There is 1:09 minutes left to play" or whatever it says.
Great platform, just wanted to point out this annoyance.

which game is this referring to?

which game is this referring to?

Sorry, mentioned the wrong name.   It was drawphone.
On Sun, Jan 24, 2021 at 10:15 AM Tanner Krewson<EMAIL_ADDRESS>wrote:

which game is this referring to?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerkrewson/rocketcrab/issues/86#issuecomment-766375280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALYHKCEG5YEFFLW6MZNHY3S3RBRPANCNFSM4WQHD5QA
.

Sorry, mentioned the wrong name.   It was drawphone.
On Sun, Jan 24, 2021 at 10:15 AM Tanner Krewson<EMAIL_ADDRESS>wrote:

which game is this referring to?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerkrewson/rocketcrab/issues/86#issuecomment-766375280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALYHKCEG5YEFFLW6MZNHY3S3RBRPANCNFSM4WQHD5QA
.

Ah, I see you have that game in a separate repo.   I will close this issue and move it there.

Ah, I see you have that game in a separate repo.   I will close this issue and move it there.


Feat: support nullable option

Description of your changes
Part of #5364

Support nullable option for generation
Adjust testdata

I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Unit tests
Special notes for your reviewer

provider-gen don't need null enum for pointer type, but cuegen is a general generator. So I set it to an option.


fix RTL tooltip colorBox placement

#10771
here is the current behavior of the tooltip. and here is the results after applying the changes. (sorry but I couldn't upload the js into any of the recommended websites.)
here is a screenshot of the results, for single line and multi line tooltips, rtl on and off, and boxPadding set to 150 and disabled.

When I look at your live demo it seems like the tooltip does not render correctly, the colored box is rendered outside of the tooltip:


Search doesn't return chats, only messages

Fixed pending release

When is this one rolling out?


branch-2.1 fix nereids fold constant wrong result of abs (#37065)

Proposed changes
pick https://github.com/apache/doris/pull/37065
before:
mysql [optest]>select abs(cast(-9223372036854775808  as BIGINT));
+-------------------------------------------+
| abs(cast(-9223372036854775808 as BIGINT)) |
+-------------------------------------------+
| -9223372036854775808                      |
+-------------------------------------------+
1 row in set (0.00 sec)

now:
mysql [optest]>select abs(cast(-9223372036854775808  as BIGINT));
+-------------------------------------------+
| abs(cast(-9223372036854775808 as BIGINT)) |
+-------------------------------------------+
|<PHONE_NUMBER>854775808                       |
+-------------------------------------------+
1 row in set (0.01 sec)

Proposed changes
Issue Number: close #xxx

run buildall


Add support to Mobility types

Hi, are there any plans in the near future to add support for HealtKit Mobility types?
For example:

walking speed
https://developer.apple.com/documentation/healthkit/hkquantitytypeidentifier/3131040-walkingspeed
walking step length
https://developer.apple.com/documentation/healthkit/hkquantitytypeidentifier/3552088-walkingsteplength
walking asymmetry percentage
https://developer.apple.com/documentation/healthkit/hkquantitytypeidentifier/3552086-walkingasymmetrypercentage
....

https://developer.apple.com/documentation/healthkit/data_types

Are there any updates on this. Or is this something that users can do themselves by forking a copy and adding the data types manually?

Also this is a super necessary enhancement. The mobility data is a game changer!! Also data such as fall count and other injury data would be nice too

Hey, this repository doesn't have any active developer, PRs are welcome!

Is there a good pull request/previous addition that you can link me to so I can get an idea of how to implement this?

any update on it ?


Error: Could not fetch client credentials token for service of type connectivity: XsuaaService requires uaadomain inside credentials

Describe the bug
We are using SAP Cloud SDK with CAP.
When we are trying to call an on-premise service using cloud-sdk, we are getting the error: Error: Could not fetch client credentials token for service of type connectivity: XsuaaService requires uaadomain inside credentials.
This issue started coming since we upgraded the cloud sdk from version 3.15.0 to 3.16.0
It seems the issue is caused because the connectivity service credentials does not contain uaadomain property and these credentials are being passed to the XsuaaService class of @sap/xssec npm package which looks for this property and then throws an error. Please check the Screenshots section to see this flow.
To Reproduce
Steps to reproduce the behavior:

Set up ...
Execute ...
Confirm ...
See error

Expected behavior
Receive the response without any errors
Screenshots
This screenshot explains the process flow and where it fails.

Used Versions:

node version via node -v: v20.12.2
npm version via npm -v: 10.5.0
SAP Cloud SDK version you used as dependency: 3.16.0

Code Examples
import { executeHttpRequest } from "@sap-cloud-sdk/http-client";
const response = await executeHttpRequest(
            { destinationName: "destination-name" },
            {
                method, url, data, headers
            }
        );

Log file
If applicable, add your log file or related error message. Again, please remove your sensitive information.
Full Log:
[cds] - ErrorWithCause: Failed to load destination.
    at /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:67:13
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async resolveDestination (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:65:31)
    at async /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/http-client/src/http-client.ts:83:33
Caused by:
ErrorWithCause: Failed to add proxy authorization header - client credentials grant failed!
    at proxyAuthorizationHeader (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:123:11)
    ... 21 lines matching cause stack trace ...
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  cause: ErrorWithCause: Failed to add proxy authorization header - client credentials grant failed!
      at proxyAuthorizationHeader (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:123:11)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async proxyHeaders (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:102:27)
      ... 5 lines matching cause stack trace ...
  Caused by:
  ErrorWithCause: Could not fetch client credentials token for service of type "connectivity".
      at serviceToken (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/token-accessor.ts:70:11)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async proxyAuthorizationHeader (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:120:19)
      at async proxyHeaders (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:102:27)
      at async addProxyConfigurationOnPrem (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:41:11)
      at async Function.getDestinationFromDestinationService (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-from-service.ts:158:30)
      at async getDestination (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:98:6)
      at async resolveDestination (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:65:31)
      at async /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/http-client/src/http-client.ts:83:33
  Caused by:
  Error: Could not fetch client credentials token for service of type connectivity: XsuaaService requires uaadomain inside credentials.
      at /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/xsuaa-service.ts:60:11
      at processTicksAndRejections (node:internal/process/task_queues:95:5) {
    cause: ErrorWithCause: Could not fetch client credentials token for service of type "connectivity".
        at serviceToken (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/token-accessor.ts:70:11)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at async proxyAuthorizationHeader (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:120:19)
        at async proxyHeaders (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:102:27)
        at async addProxyConfigurationOnPrem (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/connectivity-service.ts:41:11)
        at async Function.getDestinationFromDestinationService (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-from-service.ts:158:30)
        at async getDestination (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:98:6)
        at async resolveDestination (/Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/destination/destination-accessor.ts:65:31)
        at async /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/http-client/src/http-client.ts:83:33
    Caused by:
    Error: Could not fetch client credentials token for service of type connectivity: XsuaaService requires uaadomain inside credentials.
        at /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/xsuaa-service.ts:60:11
        at processTicksAndRejections (node:internal/process/task_queues:95:5) {
      cause: Error: Could not fetch client credentials token for service of type connectivity: XsuaaService requires uaadomain inside credentials.
          at /Users/<USER>/Documents/project/node_modules/@sap-cloud-sdk/connectivity/src/scp-cf/xsuaa-service.ts:60:11
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
    }
  }

Impact / Priority
For now we have downgraded the version to 3.15.0 so its working but it would be great if it can be fixed soon.

Affected development phase: e.g. Getting Started, Development, Release, Production
Impact: e.g. No Impact, Inconvenience, Impaired, Blocked
Timeline: e.g. Go-Live is in 12 weeks.
Additional context
Add any other context about the problem here.

Hi @gauravkr75 ,
Thanks you for raising this. We are aware of this issue in the xssec library and it is currently being worked on by the team. Please use 3.15.0 for now.
@finkmanAtSap @jjtang1985

Hi @gauravkr75 ,
We released a canary version with the fix. You can try it out setting this in your package.json:
"@sap-cloud-sdk/connectivity": "canary".
We will likely release a new minor version sometime next week.

Hi @deekshas8,
Thanks for looking into this issue. I tested with the canary version and it is working fine now.

Hi @gauravkr75
We have now released a new minor v3.17.0.


show custom resources in overview

What this PR does / why we need it:
Show lists of custom resources rather lists of custom resource definitions

Which issue(s) this PR fixes

Fixes #509

Release note:
Show lists of custom resources rather lists of custom resource definitions

Sorry for the delay, I'm going to take a full look at this today.


Reuse existing manifest option

Piggy-backing off the work done in this PR to reuse the existing manifest. I also added this as an optional flag since it's not desired for all users of this plugin.

@phamann I hope you don't mind but i'm going to publish my own branched version under a new namespace until this is merged because it's a little time sensitive for me. If there is an issue i'm willing to unpublish.

It would be good to see it merged, along with other working PRs.

@phamann could we get a quick approval or a review? I'd like to get this PR off my PR list.

@GerkinDev By the way, if you want to use a forked version with this code I published a fork here: https://www.npmjs.com/package/rollup-plugin-hash-manifest

@monsonjeremy Hi Jeremy, thanks for implementing this! 👍

@GerkinDev I've made all the requested changes, do you mind merging this?

@monsonjeremy I'm not a maintainer of this package, I can't do anything ^^ I just reviewed to help. @phamann ping !

@GerkinDev Sorry, thought you were a maintainer! Anyways, i'll give it another week and then i'm going to delete the PR.
@phamann tick tock 😄

Dammit.


RequireLock does not work

While leaving the safe zone, RequireLock was set, XS construct was spotted on the radar with a distance 0.9 SU, after enabling EmergencyWarp the ship instantly warped.

It seems the settings is being loaded from the DataCore:


gccgo, doc:  comments on doc/install/gccgo for gcc release 6

I know that it is likely that some changes are planned for golang.org/doc/install/gccgo for the release of gcc 6.  Here are a few comments/suggestions on this page.
With the changes to split stack support in gccgo for gcc release 6, it no longer required to use --with-ld on the configure option (and probably better not to? maybe both methods should be described).  In gcc 6, if the gold linker is found in the PATH when gcc is configured, then it will be used as the linker for gccgo, as required for split stack.
Also, split stack is now implemented for PowerPC64 big and little endian in addition to x86.
On the section describing how to build gccgo, another way to get gcc source is from the weekly snapshots or releases from the various mirrors for GNU GCC found here https://gcc.gnu.org/mirrors.html.  This is much faster than using svn to get the source.
When describing the setting of the LD_LIBRARY_PATH, the paths used are not correct based on the systems I've looked at (ppc64le & x86).  The shared libraries are found under ${prefix}/lib64 or ${prefix}/lib, so that is the path needed for LD_LIBRARY_PATH or when setting the runpath with the -W option.
The example showing -gccgoflags should have the options within quotes.
It would be nice to see something that mentions the use of the go tool built for gccgo and how it is preferred over using gccgo directly or the go tool from golang with the -compiler option.  When using the go tool built for gccgo, then using 'go version' displays version information about gccgo.  Also, if 'go build' is used to build an application with build tags then it matches against the tags for gccgo as expected.  When using the go tool from golang with the -compiler option, the build tags are matched against the golang values and not the gccgo values.

Thanks.  Want to send in a change?


Update for Synth Riders directory change

Today's Synth Riders update changed the default custom content directory.
This pull request performs the following related fixes:

Update favorites icon to point at the new content directory
Update download handling to send downloads from synthriderz.com to the new content directory
Update download handling to also handle Playlist files
Update favorites icon image to the current Synth Riders game icon

Thanks for this, will get it out asap.


Change the input css in form.

Change the CSS of input fields in form

assign me @SauravMukherjee44

@SauravMukherjee44 Please review my PR


Anonymous classes supported?

This project looks very promising, thanks for the great work.
I have an issue while resolving symbols this and super inside anonymous classes, when retrieved via visitors accepting type MethodCallExpr.
For example
        Dialog dee = new java.awt.Dialog((java.awt.Dialog)null) {
            @Override
            public void setTitle(String s) {
                if (s == null) {
                    this.setTitle("Day");
                    super.setTitle("Night");
                    setTitle("Twilight");
                }
            }
        };

javasymbolsolver does great until it hits this code. When I run
javaParserFacade.solveMethodAsUsage(n).declaringType().getQualifiedName()

from a public void visit(MethodCallExpr n, JavaParserFacade javaParserFacade) method I get:
for this.setTitle: java.lang.UnsupportedOperationException: CorrespondingDeclaration not available for unsolved symbol.
for super.setTitle: java.lang.RuntimeException: Method 'setTitle' cannot be resolved in context super.setTitle("Night")
for setTitle:java.lang.UnsupportedOperationException: CorrespondingDeclaration not available for unsolved symbol.

Looks like this one: https://github.com/javaparser/javaparser/issues/1599


Style tweak the crd task file

This PR reformats the CRD task file where line wrappings are expected or proper indentations are needed. It also fixes the syntax code for some code snippets, especially those that look like YAML but are actually not YAML.
Those snippets are some YAML plus some dots. They cannot be used in place of a valid YAML file. We don't need to syntax highlight them as YAML. Just rendering them as plain code would suffice.

/kind cleanup
/lgtm
Relevant to https://github.com/kubernetes/website/issues/35991

/approve


[improve][branch-2.9]upgrade the bookkeeper version to 4.14.7

Fixes #xyz

Master Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

BookKeeper 4.14.7 has been released, we can use BookKeeper 4.14.7 directly.

After this PR https://github.com/apache/pulsar/pull/19645 merged, I will rebase branch-2.9

@horizonzy - will you please update the PR description to describe this change? Thanks!


Implementation of std::iter::{Product, Sum}

This PR is relative to the issue 4. This is a
very simple implementation, based on two macros. Maybe a more elegant
solution is possible for these, feel free to suggest.
Two tests for both BigInt and BigUInt have been added, one relative
to the Sum, the other to the Product.

I think adding such a generic impl might itself be a breaking change, as someone could have their own impl Sum<Foo> for BigUint already -- but that's ok if we're rolling this into 0.2.

I really liked your suggestion, so I decided to make the two implementations generic. Two additional tests have been added to check against generic Sum and Product (in this case from a vector of i32 or u32, depending from the case).
I want to ask you a thing about conditional compilation: is there a way to check against std features using cfg (iter_arith_traits in this case)? I am quite new with Rust, and I never needed to perform this kind of check... until now. I am not able to find anything useful, but maybe it is just me. Do you have any idea?

is there a way to check against std features

Sadly, no.  So many things would be easier if there were.

I rebased now that 0.2 has started, and fixed on issue with rust 1.15.
Thanks for implementing this!
bors r+


List requirements for "flashing" system

System specification

Ubuntu 16.04 LTS (architecture: i386)
Packages(APT) from install_prereq.sh:

git=1:<IP_ADDRESS>-0ubuntu1.10
iw=3.17-1
dnsmasq=2.75-1ubuntu<IP_ADDRESS>
rfkill=0.5-1ubuntu3.1
hostapd=1:2.4-0ubuntu6.8
screen=4.3.1-2ubuntu0.1
curl=7.47.0-1ubuntu2.19
build-essential=12.1ubuntu2
python3-pip=8.1.1-2ubuntu0.6
python3-setuptools=20.7.0-1
python3-wheel=0.29.0-1
python3-dev=3.5.1-3
mosquitto=1.4.8-1ubuntu<IP_ADDRESS>
haveged=1.9.1-3
net-tools=1.60-26ubuntu1
libssl-dev=1.0.2g-1ubuntu4.19

Important packages(APT) not mentioned in install_prereq.sh:

openssl=1.0.2g-1ubuntu4.14
python3=3.5.1-3

PIP packages:

paho-mqtt==1.5.1
tornado==6.1
pycryptodomex==3.10.1

Additional details:

VirtualBox on the laptop with Windows 10

Because of the drivers for my USB WiFi stick I ended up with Ubuntu 16.04 LTS (besides tried 20.04, 18.04, 12.04 LTSes) that gives me the best result with both the stick and tuya-convert.
Problem
As I noticed (also it was noticed by @lustyffh in https://github.com/ct-Open-Source/tuya-convert/issues/455#issue-537778478 , @sominaik in https://github.com/ct-Open-Source/tuya-convert/issues/892#issuecomment-755825138 , ... )  although the AP and other things were started successfully, there is no generated smarthack-*.log files. Only screenlog.0 with some logs appeared.
I was even able to connect to the vtrust-flash network with my smartphone (using https://github.com/ct-Open-Source/tuya-convert/issues/551#issuecomment-653799381 ) . My smart device is also connected to the network (when I started the discovering process, the led stopped blinking). And then I faced another problem:
SmartConfig complete.
Resending SmartConfig Packets
..................
*Many times*
SmartConfig complete.
Resending SmartConfig Packets
........
Timed out while waiting for the device to (re)connect

Afterward there was broken diagnostics because there was no smarthack-*.log
My assumption: the problem was caused by not enough modern packages in the repository of default Ubuntu 16.04.
Suggestion
Create new wiki page with the failed system specification on the "flashing" devices and the requirements to the system specifications included derived from the failed attempt. (The final requirements can be also hardcoded into install_prereq.sh.) Then the link to this page can be placed in the README.md.

Before creating the page I am trying to overcome the problem with the ssl cipher similar to https://github.com/ct-Open-Source/tuya-convert/issues/423 . Unfortunately, without success yet.
The author of that issue just replace Ubuntu 16 with Raspberry Pi (with something equal to Ubuntu 18 taking into account the package versions), it is not applicable option to me.
So I updated the system with
libssl-dev=1.1.1-1ubuntu2.1~18.04.9
openssl=1.1.1-1ubuntu2.1~18.04.9

Using tcpdump + Wireshark I discovered that my plug sends one Client hello with the following cipher suites:
TLS_PSK_WITH_AES_128_CBC_SHA256 (0x00ae)
TLS_EMPTY_RENEGOTATION_INFO_SCSV (0x00ff)

And the psk-frontend.py fails on psk-frontend.py#L66 with:
could not establish sslpsk socket: ('No cipher can be selected.',)
I am going to digging more and post my progress.

I discovered Ubuntu MATE distro and using Ubuntu MATE 18.04 finally flashed the device
I suppose for Ubuntu 16 you need to enable bionic (Ubuntu 18.04) repositories and update all packages connected with ssl
Now I am going to post fail attempts and some requirements

See https://github.com/ct-Open-Source/tuya-convert/wiki/Failed-attempts-and-tracked-requirements

Linking the pull request... #943

@kueblc  Although I closed the issue I suppose you can be interested in its content because it covers some question that appears periodically. So I am mentioning you for the notification of you.

Also https://github.com/ct-Open-Source/tuya-convert/issues/418 is similiar to the "no cipher" problem here.


[AIRFLOW-2933] Enable Codecov on Docker-CI Build

Add missing variables and use codecov instead of coveralls. The issue why it wasn't working was because missing environment variables. The codecov library heavily depends on the environment variables in the CI to determine how to push the reports to codecov.
I've removed the explicit passing of the variables in the tox.ini since we also do it at the docker-compose.yml, having to maintain this at two places makes it brittle.
Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-2933] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-2933], code changes always need a Jira issue.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Does this mean no more coverals-io comments in github?

@ashb I was also confused by this, but the comment is by Codecov, right?
An example:

Definitely looks like it!

So the coverage report gets uploaded: https://codecov.io/gh/apache/incubator-airflow/commit/c1566951dcecb91a2a739700e2b84f3dcee02c6b
not sure why the notification is not posted to Github. Apart from that, I would like to see to get this merged so we get the reporting back on master.


Add "collection" and "gzip" options to mongodb

Please add args option for instead that.
https://github.com/gobackup/gobackup/blob/main/database/postgresql.go#L32


msys check fails with long paths

https://github.com/softprops/atty/blob/c92ca03bd7a99c2fe8da387b32d653b81f13a667/src/lib.rs#L118
Windows 10 supports longer paths than MAXPATH. When stdout is attached to such a file, the above code panics because it tries to index beyond MAXPATH + 8.
I think this code should be modified to allocate up to 32,767 plus some buffer (see the Note at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file).

Can you show a backtrace? I can't see where the panic originates.

My apologies. I'm not sure any  more if this will apply to the atty crate. I'm using the deprecated isatty crate instead (code is part of a larger code base, so I can't change this) and I didn't realize that is a truly different crate that is not deprecated (and I assume this is the replacement). The code is similar, but not exactly the same, as this crate does not access the slice, but does raw pointer access. That said, it seems the from_raw_parts may UB due to reading past the end of the MAX_PATH allocated name_info_bytes buffer if the FileNameLength is longer?
Here is the backtrace from the isatty impl.
thread 'conversion::tests::derive' panicked at 'index 272 out of range for slice of length 268', src\libcore\slice\mod.rs:2569:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys_common::backtrace::print
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\sys_common\backtrace.rs:59
   1: std::panicking::default_hook::{{closure}}
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\panicking.rs:197
   2: std::panicking::default_hook
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\panicking.rs:208
   3: std::panicking::rust_panic_with_hook
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\panicking.rs:474
   4: std::panicking::continue_panic_fmt
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\panicking.rs:381
   5: std::panicking::rust_begin_panic
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libstd\panicking.rs:308
   6: core::panicking::panic_fmt
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libcore\panicking.rs:85
   7: core::slice::slice_index_len_fail
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\/src\libcore\slice\mod.rs:2569
   8: core::slice::{{impl}}::index
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\src\libcore\slice\mod.rs:2746
   9: core::slice::{{impl}}::index
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\src\libcore\slice\mod.rs:2552
  10: alloc::vec::{{impl}}::index
             at /rustc/50a0defd5a93523067ef239936cc2e0755220904\src\liballoc\vec.rs:1687
  11: isatty::is_cygwin_pty
             at /rust_vendor/isatty-0.1.9/src/lib.rs:138
  12: isatty::isatty
             at /rust_vendor/isatty-0.1.9/src/lib.rs:111
  13: slog_term::AnyTerminal::should_use_color
             at /rust_vendor/slog-term-2.4.0/src/lib.rs:1176
  14: slog_term::TermDecoratorBuilder::build
             at /rust_vendor/slog-term-2.4.0/src/lib.rs:1259

The slog-term bug is https://github.com/slog-rs/slog/issues/214
268 is 8 + MAXPATH.
Feel free to close if you  don't consider this applicable.

That said, it seems the from_raw_parts may UB due to reading past the end of the MAX_PATH allocated name_info_bytes buffer if the FileNameLength is longer?

Yeah, that's exactly what I was thinking, in that it would be UB and not a panic, which is worse. I'd consider this a bug in this crate, definitely.

I think atty is safe because it handles wchars properly, whereas isatty assumes chars.
When atty hits the windows call, it has allocated a struct of size 8 + 2*260 = 528 bytes, whereas isatty has allocated 268.
When GetFileInformationByHandleEx encounters a path > what would fit in the buffer, it returns error 234 (more data available) and we hit the early return.
when the path is exactly 262 wchars (524 bytes):
atty: correctly reads from byte 4 (FileName offset) to FileNameLength / 2 (*2 since from_raw_parts operates on T, not bytes) -> till 528, which is fine.
for isatty, the same early return happens at 133 wchars and onwards
when the path is 131 wchars (262 bytes):
isatty attempts to index the slice from (incorrect) index 8 to index (262 + 8) which panics.
It similarly fails for 132.
Ref:
https://github.com/dtolnay/isatty/blob/1994ab57dabc3ee943e4a87df252bf02075d1bdc/src/lib.rs#L138
I'm going to consider this closed, as slog-term needs to use this crate.

if you want to play with this - https://gist.github.com/nikhilm/34d156f58ea353ed3275b434dcaf5808
I did have to comment out all the pre-msys checks in atty to reliably get that code path to execute

Ah okay, great, thanks for the analysis!


Realtime streaming of test results via firebase function

Prototype how to get firebase function streaming data to Flank.

https://github.com/firebase/functions-samples/tree/master/quickstarts/test-complete

This might not be possible given the function will have to push ( post ) data to some place, and most CI systems don't allow incoming traffic.

We're building a comprehensive build and test analytics platform that integrates with Flank. 😄 This is a research ticket that will help prove out those efforts.
Data will likely be pushed to a Firebase database.

For test analytics, we'll parse the final JUnit XML artifact as attached to the CI job. In this approach, the firebase function doesn't add value.


Brackets 1.14.1 not installing under Ubuntu 20.04.1

Unable to install latest Brackets .deb under Ubuntu LTS
Attempting to install the Brackets 1.14.1 .deb under Ubuntu 20.04.1 LTS throws up a lot of unmet dependency errors and none of the dependency packages are available for installation anymore.
Versions
Ubuntu 20.04.1 LTS (with all updates and upgrades installed).
Brackets 1.14.1 using the .deb file.

I followed Jacobs answer in - askubuntu
I am using the deb file (Brackets.Release.<IP_ADDRESS>-bit.deb) on Ubuntu 20.04; but I had a problem at step 2.  I assume some change to the way things work...
Here are the steps that worked for me :

Open terminal in temporary folder. Use :
dpkg-deb -x /path/to/deb/file .
dpkg-deb -e Brackets.Release.<IP_ADDRESS>-bit.deb

Edit the control file : ./DEBIAN/control

Change line with dependency from libcurl3 to libcurl3 | libcurl4

I deleted the original deb file - I am not sure I needed to?

Run : dpkg-deb -b . Bracket_CURL4.deb

Launch file browser and double click on the created deb file to launch the install.

All done, Brackets program is installed.

Your instructions worked like a charm.
Thanks a million.  :-)
Just one more question; post installation via the file browser, can I delete the "usr", "opt" and "DEBIAN" directories from my home directory?

Your instructions worked like a charm.
Thanks a million.  :-)
Just one more question; post installation via the file browser, can I delete the "usr", "opt" and "DEBIAN" directories from my home directory?

Just one more question; post installation via the file browser, can I delete the "usr", "opt" and "DEBIAN" directories from my home directory?
Yes, those directories and their content are used to rebuild the .deb file.
You do not need to keep the .deb file either (unless you want a backup, and/or to install it elsewhere or if you rebuild your systrem again, etc...)

Just one more question; post installation via the file browser, can I delete the "usr", "opt" and "DEBIAN" directories from my home directory?
Yes, those directories and their content are used to rebuild the .deb file.
You do not need to keep the .deb file either (unless you want a backup, and/or to install it elsewhere or if you rebuild your systrem again, etc...)


staked but without airdrop

hi sir, i staked  9 Atom via trust wallet in 10th october, but i am not eligible for the airdrop,my addres is cosmos1749vyfvcr4ze57p4n0e5ze5lqaa5v8qh2a3l60

get it , thank you bro


Handle duplicated extra stats tags gracefully.

fixes #31270

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b22cfa451f56ab20863b4310f17d6aebe33539d7
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


browser can't view winter 2013 sws term on mock data

/restclients/view/sws/student/v5/term/2013,winter.json isn't loadable, while /restclients/view/sws/student/v5/term/2013_winter.json is.  The , is being encoded, so the file lookup is done against 2013%2Cwinter.json

I committed with a comment about #1, which was too bad :(  1a754254138a3fabfb1c9cd7f5fc762fbc4197ef is the commit.


Xfail swift-futures

https://bugs.swift.org/browse/SR-14090

@swift-ci test

@swift-ci test

@clackary Were you able to reproduce this failure locally? I don't see any error in the build log.

@clackary Were you able to reproduce this failure locally? I don't see any error in the build log.

Yes, I was able to reproduce locally, the frontend crashed. There’s a log attached to the radar.

Yes, I was able to reproduce locally, the frontend crashed. There’s a log attached to the radar.

If possible, can you attach it to bugs.swift.org?

If possible, can you attach it to bugs.swift.org?

Sure, I can do that.

Sure, I can do that.


Contribution to "Exposure of Sensitive Information to an Unauthorized Actor in nanoid"

Updates

Affected products
Description

From what I read there:

https://github.com/dylang/shortid/issues/165
https://nvd.nist.gov/vuln/detail/CVE-2021-23566#config-div-1
This vulnerability only affect versions from (including) 3.0.0 up to (excluding) 3.1.31

Hi @baptistecs,
Thank you for the contribution. I found an NVD page and a Snyk page that both say the issue starts with version 3.0.0.
What do you think of a minor change to the sentence? "The package nanoid from 3.0.0, before 3.1.31, is vulnerable to Information Exposure via the valueOf() function which allows to reproduce the last id generated."

@shelbyc yes, your suggestion sounds better, but this MR is already merged 🙃
Maybe something like this?
"The package nanoid, from 3.0.0 to 3.1.30, is vulnerable to Information Exposure via the valueOf() function which allows to reproduce the last id generated."
Feel free to open a new one 🙇


Window maximization callback

glfw now supports to maximize a window but does not have a callback to notify when the window is maximized or has any capabilities to retrieve the maximize status (afaik). it would be nice if that functionality could be added :)

Darn, someone noticed!
Will look into this for 3.3.

@foofel

or has any capabilities to retrieve the maximize status (afaik)

You can use
glfwGetWindowAttrib(Win, #GLFW_MAXIMIZED)
for that.
You can add this inside the window_size_callback() and if it returns true you can invoke a window_maximize_callback()  by yourself, passing 1 to signify MAXIMIZED.
You can also track inside the window_size_callback() if the current status of the window is maximized using a static variable, and then if glfwGetWindowAttrib() return false but the static variable is true, you update the static var and invoke the window_maximize_callback() passing 0 to signify RESTORED.
At least that's what I'm currently doing while I wait for the proper implementation. :-)


Build documentation using existing Sphinx setup.

This uses the infrastructure we have for Sphinx to generate and build a GitHub Pages website with our docs. Based on:
https://coderefinery.github.io/documentation/gh_workflow/#exercise-deploy-sphinx-documentation-to-github-pages

@thetorpedodog @Shelnutt2 is this still relevant to CLoud-Py?

Can be closed after finalization and merging of: https://github.com/TileDB-Inc/TileDB-Cloud-Py/pull/579

Closing as https://github.com/TileDB-Inc/TileDB-Cloud-Py/pull/579 introduces Quarto documentation.


Modifies project to support OSX 10.10

This P.R. addresses issue #156 .

Added on track for 3.0.3 (now in develop)
https://github.com/malcommac/SwiftDate/commit/3217f7f6fa79631b44217f97f11523cb84ad1fa1


Python 3 windows 10

Hi,
Does pylayers work with python 3? You don't notice the python version anywhere. I am not able to make it work in python 3, but in python 2.7 yes.

PyLayers has been written in python 2.7 and it is currently upgraded  for python 3. My current python version is 3.6.7.
It may remain some part in the code which are still not python 3 compatible. If you noticed such situations, please post a ticket or suggest a pull request.


'=' does not work on duration

a search like
mtv_dl list topic="Die Sendung mit der Maus" duration=30m
does not produce any results, even though it is stated that it should work:

'='  Pattern is a regular expression case insensitive search within the field value.
Available for the fields 'description', 'start', 'duration', 'age', 'region',
'size', 'channel', 'topic', 'title', 'hash' and 'url'.

Searching without duration shows that there should be search results.
Btw, great work! I am very excited about having found this!

Wow, thank you for finding this. :)
I guess I never noticed because I'm always using e.g. duration+25m in those cases to find all shows longer than the defined time.


Fails with python 3.6.3 on windows

I get the following when calling send2trash on python 3.6.3 on windows 7:
File "...\AppData\Local\Programs\Python\Python36\lib\site-packages\send2trash\plat_win.py", line 49, in send2trash fileop.pFrom = LPCWSTR(path + '\0') ValueError: embedded null character
I'm pretty sure it didn't fail until I switched to 3.6.3. My guess is that this fix is responsible.

Thanks for the report. I don't use Windows, however, so I'll have to rely on a PR from someone else.
Something tells me that simply removing that + '\0' will break stuff, but I can't remember why it's there.

Yes - I tried that and the win32 call itself returns an error (87 - invalid parameter) - probably because it's expecting a null-terminated string???

Oh, I remember: pFrom has to be double nul terminated. I don't know how we'll go around that...

Is this a problem with certain file names or files with certain content? I'm trying to recreate this issue on Windows 7 with Python 3.6.2 using send2trash 1.4.1 but can't. Can you post the file you are trying to delete? I'm on Windows and could take a look at this issue.

It's only on Python 3.6.3.

It is definitely a 3.6.3 (over 3.6.2) issue, there is a possible work-around I have found, but I need to verify that it works as expected reliably.  If you want to reproduce the issue on windows all you need to do is:
from send2trash import send2trash
send2trash('pathtosomefile')

Workaround uses ctypes functions to create a buffer and write the null characters into the buffer then  use a LPWSTR() cast on the address of the buffer.  It seems to work in initial tests.  Putting the code inline yeilds:
from ctypes import create_unicode_buffer, addressof
from ctypes.wintypes import LPWSTR
# create buffer of c_wchar[] LPCWSTR is based on this type
# uses length of string + space for two null termination characters
buffer = create_unicode_buffer(path, len(path)+2)
# explicitly set the last two characters
# (not sure if it is possible for them to be non null at this point
buffer[len(path)] = '\0'
buffer[len(path)+1] = '\0'
fileop.pFrom = LPWSTR(addressof(buffer))

I will try getting around to some more verification work but this seems to be working.

@arsenetar this looks like a good workaround. If you say it works, then I say we go for it. Could you please add a comment with a link to this issue in it? Future readers might not understand the purpose of this.

@hsoft Yeah I can added that comment information. I would like to look into create_unicode_buffer() to see if the two buffer[index] = '\0' lines are redundant as I have only seen null characters in them at this point.

@rkhwaja could you please confirm the fix?

Works great - thanks.

Just for the latecomers like me, upgrading to version 1.5.0 fixed it:
pip install 'send2trash==1.5.0'


make font sizes bigger

body text font size is too small; we should make it bigger.
If you want to work on this, leave a comment below and I will assign it to you!

Closed by #5


Added mac builds on travis

Now it is right.
Build will fail in two mac builds, without the IEEE fix.

Coverage remained the same at 99.876% when pulling 556b28ad3947f43ce538c1a8aab0818c7630bf20 on felipe-lavratti:macos_travis_squashed into 7e9ff459661b2a45e97882a7e4d74a5af5cb7926 on cpputest:master.

Yep! Build .11 and .15 are failing on travis, as expected.
@Bas, would you like me to merge master and resubmit the PR?
Also, how do you fill about the complete duplication of the builds that were running on Linux, to Mac, now. The cost is that it takes a lot of time to Travis run a single Mac build, even more time it takes with all those 10.
Best,
Fanl

Looks good and I'll merge it.
I don't think all of the builds are needed on Mac. If we can run the main (long) one then I think we can find most of the mistakes. At least, no need to do CMake and Autotools builds (keep the autotools as it gives most often problems :P)


Mailchimp signup form not working in Firefox

The signup form makes requests for JS and CSS from cdn-images.mailchimp.com and openprescribing.us16.list-manage.com, and these get nobbled by Firefox's tracking protection.
This means that the form looks very wonky, and the submit button doesn't work.
I run another Mailchimp mailing list which uses a sign up form that has its own styling, and doesn't do any funky JS, so I will try to copy that.

Yes, just ditching the JS works, although when you sign up you're redirected to a "subscription confirmed" page.  (I think this is acceptable.)


Break Cluster-Topic refcycle

This partially addresses #257, as discussed there. I figured it was best to make a separate pullreq, as it doesn't have much to do with the changes in #258.

As noted in the last commit msg, this now also happens to deal with #175 - topic auto-creation is enabled even on a fresh, empty cluster (there's still no broker metadata, but it can fall back on the bootstrap brokers).

@yungchin thanks for making this totally separate from #258 - it makes them both a lot easier to think about.

I've spent a while trying to grok this, and I understand it satisfactorily. Even outside of the specific object-leak bugfix, lazily creating Topics is a good idea to mitigate memory usage. I'd like to run a few more tests on my own, but I'm close to totally convinced.

@emmett9001 thanks for checking this out! I was a bit spooked by the two test failures on travis just now:
https://travis-ci.org/Parsely/pykafka/jobs/81294673#L516
Have not seen these in local testing, but to save me some RAM I often run a two-node cluster (whereas we run a three-node cluster on travis), and I guess the smaller cluster is quicker to finish setting up a new topic.
In the failing tests, I think what goes wrong is this: test_topic_autocreate tries to auto-create a topic but gives up on it too soon (the cluster is still electing a leader and stuff), and so the test fails. Then  we enter test_topic_updates, and in the middle of that our new topic from test_topic_autocreate finally appears, so now this test errors too because it sees more new topics than it expected. (And both tests are new, which is why this has never come up before, but this seems to be the kind of failure that will keep coming up randomly....)
I'm not really sure what the best fix would be - I suppose TopicDict._create_topic needs to wait longer or should really be smarter about the wait, but I've no good suggestions on that :(

Out of curiosity, I restarted the test on travis earlier (the previous run's log output is here for posterity and such), and indeed it passed just fine the second time around. Of course that doesn't mean it's all ok - the test would continue to occasionally fail. The commit I've just pushed should fix that.


Shortcut for text label overlaps with global command "a"

Description
When project has enough labels, one of them can get assigned "a" as a shortcut. However, when using it, it leads to leaving the annotation screen back to the task overview screen.
To Reproduce
Steps to reproduce the behavior:
Configure at least 15 labels in text labeling project  or assign by hand a shortcut "a" to a label:
<Label value="Demographic" hotkey="a"/>
Expected behavior
System should not allow assignment of a shortcuts that overlap with global hotkeys:

it should avoid them in random assignments
it should complain in a label configuration validation step

Environment (please complete the following information):

OS: Linux/Ubuntu 20.04
Label Studio Version 1.4.0

Thank you for your suggestion, we will discuss it with our team ;-)