Support Serializer to specialize for specific types

In some cases, the Serializer trait defined by serde is not enough to describe all definitions of serialization scheme.
For example, there are two types of null and undefined in cbor, but Serializer only has a corresponding method called serialize_none.
Another more complicated example is the tag in cbor. The two cbor crate that support serde both use a less than ideal scheme to transmit information under the constraints of serde.
serde_cbor uses thread_local! to pass tags (https://github.com/pyfisch/cbor/blob/master/src/tags.rs#L220),
and ciborium uses a special newtype variant to pass tags (https://github.com/enarx/ciborium/blob/main/ciborium/src/tag.rs#L6).
I think specialization can help with such problems.
Ideally, we can get specialized support from compiler, like
pub struct Undefined;

default impl Serialize for Undefined { .. }

impl Serialize for Undefined {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer + CborSerializerUndefined
    {
        serializer.serialize_undefined()
    }
}

but compiler specialization is currently impossible.
maybe we can add a serialize_any method to Serializer to allow specialize a specific type.
impl Serializer for &'a mut CborSerializer {
    fn serialize_any(self, v: &dyn std::any::Any) -> Result<Option<Self::Ok>, Self::Error> {
        if v.is::<Undefined>() {
            self.serialize_undefined().map(Some)
        } else {
            Ok(None)
        }
    }
}

impl Serialize for Undefined {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer
    {
        if serializer.serialize_any(self)?.is_none() {
             serializer.serialize_none()?; // fallback to none
        }
        Ok(())
    }
}

I think I'd prefer not to build anything for this into this crate. It sounds like the cbor crates you linked both got this working using the existing Serializer API, but it's also possible they'd want to provide their own trait + derive macro to support aspects of the format that fit serde's model less well.


Missing keys while testing pre-trained models

Hi, i am trying to generate image for some tests using "https://github.com/robvanvolt/DALLE-models"
models, But its failing to load model with error as:
RuntimeError: Error(s) in loading state_dict for DALLE:
Missing key(s) in state_dict: "transformer.pos_emb", "transformer.layers.blocks.0.f.net.fn.fn.fn.to_qkv.weight", "transformer.layers.blocks.0.f.net.fn.fn.fn.to_out.0.weight", "transformer.layers.blocks.0.f.net.fn.fn.fn.to_out.0.bias", "transformer.layers.blocks.0.g.net.fn.fn.fn.net.0.weight", "transformer.layers.blocks.0.g.net.fn.fn.fn.net.0.bias", "transformer.layers.blocks.0.g.net.fn.fn.fn.net.3.weight", "transformer.layers.blocks.0.g.net.fn.fn.fn.net.3.bias", "transformer.layers.blocks.1.f.net.fn.fn.fn.to_qkv.weight", "transformer.layers.blocks.1.f.net.fn.fn.fn.to_out.0.weight", "transformer.layers.blocks.1.f.net.fn.fn.fn.to_out.0.bias", "transformer.layers.blocks.1.g.net.fn.fn.fn.net.0.weight", "transformer.layers.blocks.1.g.net.fn.fn.fn.net.0.bias", "transformer.layers.blocks.1.g.net.fn.fn.fn.net.3.weight", "transformer.layers.blocks.1.g.net.fn.fn.fn.net.3.bias", "transformer.layers.blocks.2.f.net.fn.fn.fn.to_qkv.weight", "transformer.layers.blocks.2.f.net.fn.fn.fn.to_out.0.weight", "transformer.layers.blocks.2.f.net.fn.fn.fn.to_out.0.bias", "transformer.layers.blocks.2.g.net.fn.fn.fn.net.0.weight", "transformer.layers.blocks.2.g.net.fn.fn.fn.net.0.bias", "transformer.layers.blocks.2.g.net.fn.fn.fn.net.3.weight", "transformer.layers.blocks.2.g.net.fn.fn.fn.net.3.bias", "transformer.layers.blocks.3.f.net.fn.fn.fn.to_qkv.weight", "transformer.layers.blocks.3.f.net.fn.fn.fn.to_out.0.weight", "transformer.layers.blocks.3.f.net.fn.fn.fn.to_out.0.bias", "transformer.layers...
Unexpected key(s) in state_dict: "text_pos_emb.weight", "image_pos_emb.weights_0", "image_pos_emb.weights_1", "transformer.layers.blocks.0.f.net.fn.fn.to_qkv.weight", "transformer.layers.blocks.0.f.net.fn.fn.to_out.0.weight", "transformer.layers.blocks.0.f.net.fn.fn.to_out.0.bias", "transformer.layers.blocks.0.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.0.g.net.fn.fn.net.0.weight", "transformer.layers.blocks.0.g.net.fn.fn.net.0.bias", "transformer.layers.blocks.0.g.net.fn.fn.net.3.weight", "transformer.layers.blocks.0.g.net.fn.fn.net.3.bias", "transformer.layers.blocks.1.f.net.fn.fn.to_qkv.weight", "transformer.layers.blocks.1.f.net.fn.fn.to_out.0.weight", "transformer.layers.blocks.1.f.net.fn.fn.to_out.0.bias", "transformer.layers.blocks.1.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.1.g.net.fn.fn.net.0.weight", "transformer.layers.blocks.1.g.net.fn.fn.net.0.bias", "transformer.layers.blocks.1.g.net.fn.fn.net.3.weight", "transformer.layers.blocks.1.g.net.fn.fn.net.3.bias", "transformer.layers.blocks.2.f.net.fn.fn.to_qkv.weight", "transformer.layers.blocks.2.f.net.fn.fn.to_out.0.weight", "transformer.layers.blocks.2.f.net.fn.fn.to_out.0.bias", "transformer.layers.blocks.2.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.2.g.net.fn.fn.net.0.weight", "transformer.layers.blocks.2.g.net.fn.fn.net.0.bias", "transformer.layers.blocks.2.g.net.fn.fn.net.3.weight", "transformer.layers.blocks.2.g.net.fn.fn.net.3.bias", "transformer...
Please provide any suggestions. Thanks!

This is due to https://github.com/lucidrains/DALLE-pytorch/commit/63effa53fceb1c66c1f3b3f98d6435c2d89e74b9 ; all previous models are now incompatible with the current code
You may still be able to load old models by putting shift_tokens and rotary_emb to False in the loading/generation code

This is due to 63effa5 ; all previous models are now incompatible with the current code
You may still be able to load old models by putting shift_tokens and rotary_emb to False in the loading/generation code

Many thanks @rom1504, still not able to load getting unexpected keys error as:
Unexpected key(s) in state_dict: "transformer.layers.blocks.0.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.1.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.2.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.3.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.4.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.5.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.6.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.7.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.8.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.9.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.10.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.11.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.12.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.13.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.14.f.net.fn.fn.attn_fn.master_layout", "transformer.layers.blocks.15.f.net.fn.fn.attn_fn.master_layout".

after putting shift_tokens and rotary_emb to False
where did you do that exactly?

after putting shift_tokens and rotary_emb to False

where did you do that exactly?

In the DALLE function, please check below,
from dalle_pytorch import OpenAIDiscreteVAE, DALLE
dalle = DALLE(dim = 512,    vae = vae, num_text_tokens = 10000,
text_seq_len = 256,  depth = 12,  heads = 16,  dim_head = 64,
shift_tokens = False,
rotary_emb =False
)

in what file ?

in what file ?

In generate.py file below is the link.
https://github.com/lucidrains/DALLE-pytorch/blob/main/generate.py

Hi @rom1504,I did some mistake, It worked. Thank you


S20+ is recognized as a tablet

As I already wrote in title Samsung S20+ is recognised as a tablet. It shouldn't and it makes harder to benefit from this package.

Correct there is an issue in code.

The width is already being assigned with the height, in case of landscape mode. And while checking for device type, the code checks for height again, in case of landscape. It should check for width instead. Or just need to remove the condition which is checking for orientation.


I get a bat file which create the ini file automaticly

The bat file can create the ini file by your windows version automaticly!
We may needn't find ini file so hard.
The bat file is write by him, thank a lot!
Guys, please try this bat file and give me some feedback!
create ini file.txt

The bat file can create the ini file by your windows version automaticly! We may needn't find ini file so hard. The bat file is write by him, thank a lot! Guys, please try this bat file and give me some feedback! create ini file.txt

Change the file type to bat, and run the bat file with administor.
What's more, in the link above, there is a instruction for using the file.

The bat file can create the ini file by your windows version automaticly! We may needn't find ini file so hard. The bat file is write by him, thank a lot! Guys, please try this bat file and give me some feedback! create ini file.txt

Change the file type to bat, and run the bat file with administor. What's more, in the link above, there is a instruction for using the file.

I secceed in my two different version computer.

Shit, the bat file may just download a new ini file from github, why I dowmload ini file from github by myself can't make the state listening?


TypeError: Cannot read property 'get' of undefined

Im getting error
[Vue warn]: Error in created hook: "TypeError: Cannot read property 'get' of undefined"

found in

---> <VPaginator>
       <Root>

https://jsfiddle.net/JunedLanja/oty8w8go/1/

Thanks for the repro link!
This happens because Vue.prototype.$http is null. You have to either use Vue Resource or set Vue.prototype.$http = axios if you are using axios.
Duplicate of https://github.com/hootlex/vuejs-paginator/issues/24


Find a markdown library

To pre-render text for articles

do you think we can use rustdoc's lib? https://doc.rust-lang.org/rustdoc/html/markdown/

Maybe, I can't find a stable markdown lib somehow. We could write our own if we really need to

source: https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/markdown.rs


Releasing sslify to production.

It would appear that the issue we were seeing before is back. I'll have to dig in before we merge this. It's tough though, because I can't reproduce locally.

@jmervine k


how to access typeahead-min-length for validation

I have a button I would like to be enabled ONLY when the value in the input box matches the typeahead-min-length. What is the $scope variable name I can access to check this?
for example:
pseudo code:
if (textbox.length == typeahead-min-length) {
button.enabled = true;
}

@pjlasl, please do not use the issues forum for support-related requests.  Rather, please follow the instructions here.  The issues forum is reserved for bugs.  Thanks.


didn't get good result deepAR negative binomial

Kindly need your advice how to get the good model using deepAR neg binomial. I have ts data to predict sales with input data such as time information (day, month, hour), weather condition, and holiday. Unfortunately I only get RMSE above 8 on hold out dataset meanwhile using statistic model I can get RMSE 4-5. the loss is stable at 1.99 (what is the loss calculation here?) . tuned hyperparameter some times give lower loss around 1.4 but the evaluation doesn't make sense (RMSE 300). followed some recommendations here https://github.com/awslabs/gluon-ts/issues/636 didn't improve the model.
thanks

Have you tried the latest version? There are some fixes for NegativeBinomial.

I'm also having an accuracy issue with DeepAR trained on count data with negative binomial output. Oddly, the behavior is restricted to CPU training. I can train the same model with the same data on a GPU and it's fine, but on a CPU, I get extreme, non nonsensical confidence limits and poor accuracy. Student T happens to work fine on both CPU and GPU.
I'm happy to share technical details / output - what would be most useful for me to share?

@ramdhan1989 adding the time information explicitly is not needed, since such features are automatically added by DeepAR.
@esbraun With what version of gluonts are you experiencing the issue? There were some changes to NegativeBinomial recently which may have solved the issue.
In both cases, if something does not seem to be working it's better to open a bug report (instead of a question) with exhaustive description of the environment (gluonts version, mxnet version, OS, ...) and a code snippet clearly reproducing the setting used (estimator, hyperparameters, and possibly some data even if artificial).


Add files via upload

Elevate Academy Nampa

@hibbardsclass First stage of verification passed, official domain is facebook.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.facebook.com/ElevateNampa/

@hibbardsclass Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@hibbardsclass You might miss my previous comment. Please react.

@hibbardsclass I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


IR01

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
Implementation requirement 1 is too general to be tested.
Proposed Change
As it is intended for scoping the technical guidance, it may be better to remove this as an explicit requirement from the document.

The Implementation requirement 1 is also possibly incorrect, because the TG tells us that an INSPIRE view service may also be implemented using WMS 1.1.1 which IS NOT ISO 19128.   Technically a view service could be provided by a service that isn't even a WMS.  It might be that we need to remove all references to  ISO 19128 in any requirement, and have them instead as recommendations.

It might be worth removing the word minimal from the phrase minimal mandatory as it adds no meaning.
Agreed, it is tested through the/a combination of other tests

Agreed it should probably be removed, as should IR 74 which is almost identical but for the WMTS profile

An INSPIRE View Service is an abstract definition contained in the Network Service Regulation.
The regulation was indeed inspired by the OGC WMS 1.3.0 specification mainly because it has become also an ISO standard (i.e. ISO 19128).
The VS TGs presents in detail  other two alternative ways to be compliant: WMS 1.1.1 and WMTS 1.0.0.
I agree, that the phrasing is not clear.
If you choose that, Requirement 1 is insid INSPIRE Profile of ISO 19128


1.13

This question requires that you evaluate the underlined text to determine if it is correct.
You plan to deploy 20 virtual machines to an Azure environment. To ensure that a virtual machine
named VM1 cannot connect to the other virtual machines, VM1 must be deployed to a separate
virtual network.
Instructions: Review the underlined text. If it makes the statement correct, select "No change is
needed". If the statement is incorrect, select the answer choice that makes the statement correct.
A. No change is needed
B. run a different operating system than the other virtual machines
C. be deployed to a separate resource group
D. have two network interfaces

A


Adds method to read the pooling types from model's files

This adds a method to load the pooling config file from sentence transformer models like sentence-transformers/all-MiniLM-L12-v2.
The pooling types added can be found at the sentence-transformers Pooling
FIX #9388 (link existing issues this PR will resolve)
cc: @maxdebayser
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks! This is great! Can you make sure to add some integration tests?

Sorry, can you hold this for a bit? I'm trying to get #9697 merged which will definitely introduce merge conflicts. The CI is broken right now so we are all waiting for force merge.

In vllm/engine/arg_utils.py the MEAN type is missing in the set of acceptable values for the command line arg:
        parser.add_argument(
            '--pooling-type',
            choices=['LAST', 'ALL', 'CLS', 'STEP'],
            default=None,

In before the rebase you had a version where this list was generated automatically from the Enum type. Can you add this again?

I was able to reproduce the error we are seeing at the CI tests in my environment - it is regarding another change that was included recently. The two environments compared in this test are:
env 1  {'VLLM_TORCH_COMPILE_LEVEL': '0'}
env 2  {'VLLM_TORCH_COMPILE_LEVEL': '3'}

All the vllm engine args and model configuration are the same, but when the test compares the tensors produced with this two different torch compiles, it fails. The vectors are different.
Following are the engine args:
['--enforce-eager', '--task', 'embedding', '-pp', '1', '-tp', '1', '--load-format', 'dummy']

And model config parameters:
model='BAAI/bge-multilingual-gemma2', speculative_config=None, tokenizer='BAAI/bge-multilingual-gemma2', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, override_neuron_config=None, rope_scaling=None, rope_theta=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=8192, download_dir=None, load_format=LoadFormat.DUMMY, tensor_parallel_size=1, pipeline_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=True, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), observability_config=ObservabilityConfig(otlp_traces_endpoint=None, collect_model_forward_time=False, collect_model_execute_time=False), seed=0, served_model_name=BAAI/bge-multilingual-gemma2, num_scheduler_steps=1, chunked_prefill_enabled=False multi_step_stream_outputs=True, enable_prefix_caching=False, use_async_output_proc=False, use_cached_outputs=True, chat_template_text_format=string, mm_processor_kwargs=None, pooler_config=PoolerConfig(pooling_type='LAST', pooling_norm=False, pooling_softmax=None, pooling_step_tag_id=None, pooling_returned_token_ids=None))

@youkaichao maybe there is a bug in using torch.compile?

the mse is mse=0.0005555402021855116 , is it acceptable? torch.compile can indeed change the model's output slightly.

It is acceptable. I think we should measure cosine similarity instead of MSE for embedding models though.

It is acceptable. I think we should measure cosine similarity instead of MSE for embedding models though.

feel free to update the tests then.


stage-portal  Canada Dns?

Is this vulnerable ?

What makes you think it could potentially be vulnerable? I might have missed something, but on first sight, it doesnt look vulnerable to me. The CNAME used in the qa-portal subdomain points to walmart and not a third party. Meaning that there is no option to claim it.

Because it shows up in the output of subjack in the same color it does for vulnerable subdomains

I will ask over there about it thanks.

subjack works based on fingerprints so there might be a issue with that but you can't be like that is it shows green so it's always possible to takeover. You can even get false positives it's normal to have such in any tool.


feat: trim metadatas (part 2)

now all of the encodings have PTypes instead of DTypes, removed unnecessary lengths, etc.
also renamed e.g., zigzag.rs to array.rs to standardize the per-encoding file layout

Somehow you managed to type coerce values in forarray

Somehow you managed to type coerce values in forarray

FlexBuffers got me, they automatically narrow the integer type when writing, and we don't store the PValue enum type because we assumed they'd round trip (or that we'd cast to the dtype)
https://github.com/spiraldb/vortex/blob/develop/vortex-scalar/src/serde/serde.rs


Add Custom Render Plugin Example

The last piece to getting the custom render engine issue (https://github.com/ignitionrobotics/ign-rendering/issues/100) resolved.
This example simply adds a mock render engine plugin that the user can load with --render-engine HelloWorldPlugin, it won't display anything to the scene as there is actually no implementation, this just serves as a template for any future user desiring to write their own render engine plugin.
Signed-off-by: John Shepherd<EMAIL_ADDRESS>

The changes here allows the plugin to load in the ign-rendering side. It's now just failing in RenderUtil on the in-gazebo side since there are several places that assume a non-null scene..

The changes here allows the plugin to load in the ign-rendering side. It's now just failing in RenderUtil on the in-gazebo side since there are several places that assume a non-null scene..

Can you make the PR?  Mainly so I can approve.  Also, I made an additional PR for ign-gazebo here adding additional null checks.  I'm still getting a seg fault when attempting to run the mock render engine plugin, and gdb actually isn't helpful at all so I'm trying to figure out where exactly it's occurring.

created pull request #156 containing the null checks, and your changes :)

This is ready for a review whenever you have time. @iche033


server: improve parent <-> child error handling

The code currently doesn't check for most child errors as it basicaly
immediately wrote the ready byte. Also it never considered the fact that
the child can exit early and in that case it would have blocked forever
because the parent never closed the writing side before call read().
This fixes that part, however it still reports success way to early. It
should wait for the first bind but that needs more complicated changes.
serve: fix broken error logging
Turns out the task contains a result in a result and we were only
looking at task error caused by tokio and not the actual result returned
from start_dns_server().
This caused all bind error to go nowhere and no even logged by in the
journal.
Fixes: https://github.com/containers/aardvark-dns/commit/224756d98986355d7f7d71d79c8012f0c7e4c29d ("server: use only one tokio runtime")

Note  I still have to do more changes in order to get the bind error back to netavark on first start.

@mheon PTAL another one

Format comment, code LGTM

fix the comment but also added a new commit to switch to tokio for the signal handling.

/lgtm


Youtube ID for trailer returns more than 11 characters

Problem
Anime returns youtube id with 12 characters instead of 11.
Reproduction
Example 16904 gives yhNzL20gNX0/ instead of yhNzL20gNX0.
Cause
While the original embed URL (with additional /) does work, the regex does not take this into account that it should only be 11 characters for the id.
See this line in Media.php.
Possible fixes
Correct match for id, possible solutions:

Change regex part ([^\?&\"'>]+) to ([^\?&\"'>]{11})
Change statement for matches[1] ?? null to empty($matches[1]) === false ? substr($matches[1], 0, 11) : null

@irfan-dahir I can create a PR for this if you prefer one of the solutions I provided.


Add plots and additional metrics

Is your feature request related to a problem? Please describe.
Imo, it would be nice to have:

Pixel-wise AUPR + PRO until 30% FPR as metrics
Plots with baselines where applicable for all metrics (ROC-Curve, PR-Curve, PRO-Curve)

Describe the solution you'd like

Add/implement appropriate torchmetric classes, and add them to the AnomlibMetricCollection
Add callbacks which access the underlying scores for metric calculation (i.e. tuple of tpr/fpr for auroc) and which subsequently use the scores to generate and save the plots.

Alternatively, one could think of expanding/inheriting the VisualizerCallback

Thoughts?

@ORippler I think segregating ImageVisualizerCallback and MetricVisualizerCallback might be a cleaner approach. Let me know what are your thoughts on that.
Also, just to break down your issue here is a list to capture it. Feel free to suggest any modifications.

[ ] Add AUPR metrics
[ ] Add PRO metrics
[ ] Add visualizer for plotting the underlying scores in each metrics

@ORippler I think segregating ImageVisualizerCallback and MetricVisualizerCallback might be a cleaner approach. Let me know what are your thoughts on that.
Also, just to break down your issue here is a list to capture it. Feel free to suggest any modifications.
* [ ]  Add AUPR metrics

* [ ]  Add PRO metrics

* [ ]  Add visualizer for plotting the underlying scores in each metrics

Sure we can split up the Callbacks, but then I suggest inheriting from a VisualizerCallbackBase.

Sure we can split up the Callbacks, but then I suggest inheriting from a VisualizerCallbackBase

Sure, this separation should cause minimal duplication.


No longer wraps 'interval' with parentheses

Add extra unit tests to test tpc-h + scramble
Also fix #305

Codecov Report

Merging #306 into master will increase coverage by 0.41%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   70.15%   70.55%   +0.41%
==========================================
  Files         164      164
  Lines       10702    10702
  Branches     1719     1719
==========================================
+ Hits         7507     7550      +43
+ Misses       2765     2733      -32
+ Partials      430      419      -11

Impacted Files
Coverage Δ

...java/org/verdictdb/sqlwriter/SelectQueryToSql.java
80.98% <ø> (+3.27%)
:arrow_up:

...va/org/verdictdb/connection/InMemoryAggregate.java
92.73% <100%> (ø)
:arrow_up:

.../core/scrambling/FastConvergeScramblingMethod.java
93.46% <0%> (ø)
:arrow_up:

...ictdb/core/querying/ola/AsyncAggExecutionNode.java
68.16% <0%> (+0.6%)
:arrow_up:

...main/java/org/verdictdb/sqlsyntax/MysqlSyntax.java
85.08% <0%> (+1.5%)
:arrow_up:

...querying/simplifier/ConsolidatedExecutionNode.java
83.34% <0%> (+1.76%)
:arrow_up:

...n/java/org/verdictdb/sqlsyntax/RedshiftSyntax.java
74.08% <0%> (+1.86%)
:arrow_up:

...core/querying/ola/SelectAsyncAggExecutionNode.java
89.29% <0%> (+2.39%)
:arrow_up:

...ain/java/org/verdictdb/sqlsyntax/ImpalaSyntax.java
67.57% <0%> (+2.71%)
:arrow_up:

.../verdictdb/coordinator/SelectQueryCoordinator.java
85.82% <0%> (+2.84%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99b998...38b22d8. Read the comment docs.

Can you check the build failure in the master? https://circleci.com/gh/mozafari/verdictdb/2700

It has been caused by redshift unit tests, which happen to share the same schema for ScrambleMeta:
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "hashColumn" (class org.verdictdb.core.scrambling.ScrambleMeta), not marked as ignorable (10 known properties: "aggregationBlockColumn", "aggregationBlockCount", "originalTableName", "tableName", "schemaName", "originalSchemaName", "numberOfTiers", "tierColumn", "cumulativeDistributions", "method"])
 at [Source: {"schemaName":"verdictdb_tpch_query_test_g0kijsbq","tableName":"orders_scramble","originalSchemaName":"verdictdb_tpch_query_test_g0kijsbq","originalTableName":"orders","aggregationBlockColumn":"verdictdbblock","aggregationBlockCount":1,"tierColumn":"verdictdbtier","numberOfTiers":1,"method":"uniform","hashColumn":null,"cumulativeDistributions":{"0":[1.0]}}; line: 1, column: 320] (through reference chain: org.verdictdb.core.scrambling.ScrambleMeta["hashColumn"])

I guess added hashColumn field in ScrambleMeta in the ongoing work on supporting count distinct affected the test in master branch.
I think It should get cleared once you push your latest work into master, yet I will try to have those failed tests to use different randomized schema for meta.

I see. Then, I guess there’s no need to temporarily fix it. I’ll just merge mine once I fix my errors.

It looks like some Presto unit tests in pyverdict job also have same problem: https://circleci.com/gh/mozafari/verdictdb/2741

I feel like there was a temporary network error in CircleCI or so. Let me double-check.

All tests are passing now for the code in the yongjoo-count-distinct branch.


Looking in the wrong location for anatomicals

Describe the bug
I was attempting to run XCP Engine on a multi-session dataset. My target was the MNI152NLin2009 space. It appears that XCP (at least as far as mine is running) is looking in the wrong spot for anatomical data in a multi-session fMRIPrep tree. I am aware of the potential issues with the multiple template spaces. However, XCP Engine isn't even looking in the correct folder for the anatomical.
As shown below, XCP is attempting to find the anatomical in fmriprep/subj/session/anat (e.g., fmriprep/sub-BLMTBI104/ses-bline/anat/*MNI152NLin2009*). However, the fMRIPrep structure has that file at subj/anat (e.g., fmriprep/sub-BLMTBI104/anat).
I've test this with and without the id1 column in the cohort file and it makes no difference. The same error occurs.
Cohort file
id0,id1,img
sub-BLMTBI104,ses-bline,sub-BLMTBI104/ses-bline/func/sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.nii.gz
sub-BLMTBI104,ses-ptx,sub-BLMTBI104/ses-ptx/func/sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.nii.gz

Design File
Paste your entire design (.dsn) file between the triple backticks
#!/usr/bin/env bash

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

###################################################################
# This design file stores the values of all variables required to
# execute a complete neuroimage processing pipeline. You may
# execute the analysis specified in this design file by calling
# (in any v4 or higher bash terminal):
#
# xcpEngine -d <design> -c <cohort> -o <output> <options>
#
# Variables fall into five general categories:
# * ANALYSIS VARIABLES are used at all stages of this analysis.
# * PIPELINE specifies the modules that comprise the analysis.
# * MODULE VARIABLES are used during one stage of the analysis.
#                  These are typically array variables with array
#                  indices equal to the index of the module that
#                  calls them.
# * OUTPUT VARIABLES may be used at all stages of the analysis.
#                  These are typically array variables with array
#                  indices equal to the value of the primary
#                  subject identifier. They will appear only in
#                  localised design files.
###################################################################

###################################################################
# ANALYSIS VARIABLES
###################################################################

analysis=fc_$(whoami)
design=/data/xcpengine/design_files/2019-08-01_fc-36p_despike.dsn
sequence=anatomical
standard=MNI%2x2x2

###################################################################
# PIPELINE
###################################################################

pipeline=prestats,confound2,regress,fcon,reho,alff,roiquant,norm,qcfc

###################################################################
# 1 PRESTATS
###################################################################

prestats_rerun[1]=0
prestats_cleanup[1]=1
prestats_process[1]=FMP-NST

###################################################################
# 2 CONFOUND2
###################################################################

confound2_rps[2]=1
confound2_rms[2]=0
confound2_wm[2]=1
confound2_csf[2]=1
confound2_gsr[2]=1
confound2_acompcor[2]=0
confound2_tcompcor[2]=0
confound2_aroma[2]=0
confound2_past[2]=0
confound2_dx[2]=1
confound2_sq[2]=2
confound2_custom[2]=
confound2_censor[2]=0
confound2_censor_contig[2]=0
confound2_framewise[2]=fds:0.25,dv:2 #TR 2s so fds = 0.25 should be equivalent to fds = 0.167 with TR 3s
confound2_rerun[2]=1
confound2_cleanup[2]=1

###################################################################
# 3  REGRESS
###################################################################

regress_tmpf[3]=butterworth
regress_hipass[3]=0.01
regress_lopass[3]=0.08
regress_tmpf_order[3]=1
regress_tmpf_pass[3]=2
regress_tmpf_ripple[3]=0.5
regress_tmpf_ripple2[3]=20
regress_dmdt[3]=2
regress_1ddt[3]=1
regress_smo[3]=6
regress_sptf[3]=susan
regress_usan[3]=default
regress_usan_space[3]=
regress_rerun[3]=0
regress_cleanup[3]=1
regress_process[3]=DMT-DSP-TMP-REG

###################################################################
# 4 FCON
###################################################################

fcon_atlas[4]=all
fcon_metric[4]=corrcoef
fcon_thr[4]=N
fcon_rerun[4]=0
fcon_cleanup[4]=1

###################################################################
# 5 REHO
###################################################################

reho_nhood[5]=vertices
reho_roikw[5]=0 # does nothing at the moment
reho_sptf[5]=susan
reho_smo[5]=6
reho_rerun[5]=0
reho_cleanup[5]=1

###################################################################
# 6 ALFF
###################################################################

alff_hipass[6]=0.01
alff_lopass[6]=0.08
alff_sptf[6]=susan
alff_smo[6]=6
alff_rerun[6]=0
alff_cleanup[6]=1

###################################################################
# 7 ROIQUANT
###################################################################

roiquant_atlas[7]=all
roiquant_globals[7]=1
roiquant_vol[7]=0
roiquant_rerun[7]=0
roiquant_cleanup[7]=1

###################################################################
# 8 NORM
###################################################################
norm_primary[8]=1
norm_rerun[8]=0
norm_cleanup[8]=1

##################################################################
# 9 QCFC
###################################################################
qcfc_atlas[9]=glasser360,schaeffer400
qcfc_sig[9]=fdr
qcfc_rerun[9]=0
qcfc_cleanup[9]=1

Error message
Paste your error message between the backticks
/xcpEngine/xcpEngine: line 12: activate: No such file or directory
[Detected that xcp is in a container]
Received options: -c /data/xcpengine/cohort_files/test.csv -d /data/xcpengine/design_files/2019-08-01_fc-36p_despike.dsn -o /data/xcpengine/resting_state -r /data/fmriprep-1.4.1/fmriprep -t 1
$XCPEDIR is /xcpEngine

Constructing a pipeline based on user specifications
····································································
· [D][/data/xcpengine/design_files/2019-08-01_fc-36p_despike.dsn]
· [C][/data/xcpengine/cohort_files/test.csv]
· [O][/data/xcpengine/resting_state]
· [M][Executing serially]
····································································

Checking general dependencies
····································································
· Version AFNI           AFNI_19.1.18
· Version ANTs           <IP_ADDRESS>
· Version FSL            fsl-5.0.10
· Version C3D            1.1.0
· Version JQ             jq-1.5
· Version XCP Engine     xcpEngine-v1.0
· R version              3.3.3
· R scripting front-end  3.3.3
· · RNifti version       0.10.0
· · optparse version     1.6.2
· · pracma version       2.2.5
· · signal version       0.7.6
····································································
All general dependencies are present.

Checking environment
All environmental variables are defined.

Checking module-specific dependencies

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
#                                                                 #
#  ⊗                      XCP ★ ★ ★ ENGINE                     ⊗  #
#                                                                 #
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
#                                                                 #
                  CURRENTLY PROCESSING MODULE:
                         ★ LOCALISER ★
#                                                                 #
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

[Delegating control to module]

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
#                                                                 #
#  ⊗                   XCP ENGINE LOCALISER                    ⊗  #
#                                                                 #
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

Current processing step:
@1 Localising subject metadata...
····································································
· @1.1 [Parsing subject identifiers]
· @1.1a [Creating output directory]
· @1.1b [/data/xcpengine/resting_state/sub-BLMTBI104/ses-bline]
· @1.2 [Initialising space mapping]
· @1.3 [Initialising derivative maps]
· @1.4 [Initialising atlas system]
· @1.5 Ingress
· @1.5.1 [Native space: sub-BLMTBI104_ses-bline_anatomical]
· @1.5.2a [Standard space: MNI]
· @1.5.3a [Anatomical space: sub-BLMTBI104_ses-bline_anatomical]
source space map '' is not an image
· @1.5 [Priming analytic audit]
· @1.6 [Priming quality assessment]
····································································
Processing step complete:
Localising subject metadata...

Current processing step:
@2 Localising image
····································································
· @2.1 [Verifying that images are present]
· @2.2 [Conforming and localising images]
····································································
Processing step complete:
Localising image

Current processing step:
@3 Localising design
····································································
· @3.1 [Writing localised design]
· @3.2 [Evaluating subject variables]
····································································
Processing step complete:
Localising design

Localiser complete

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
#                                                                 #
                  CURRENTLY PROCESSING MODULE:
                         ★ prestats ★
#                                                                 #
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

[Delegating control to module]

###################################################################
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
#                                                                 #
#  ⊗                 FMRI PREPROCESSING MODULE                 ⊗  #
#                                                                 #
#  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  ⊗  #
###################################################################

[I][/data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/sub-BLMTBI104_ses-bline.nii.gz]
[O][/data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats]
                             -   -   -
>> rln /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/sub-BLMTBI104_ses-bline.nii.gz /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~.nii.gz
                             -   -   -
>> 7-5-1
                             -   -   -
>> 7-1

Current processing step:
@0 Ensure matching orientation
····································································
· @0.1a Input: /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~.nii.gz
· @0.1b Template: /xcpEngine/space/MNI/MNI-2x2x2.nii.gz
· @0.1c Output root:
· @0.1d checking the orientation of img and template
                             -   -   -
>> 3dinfo -orient /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~.nii.gz
                             -   -   -
>> 3dinfo -orient /xcpEngine/space/MNI/MNI-2x2x2.nii.gz
NATIVE:LPI TEMPLATE:RPI
· @0.1e img and template orientation are not the same
· @0.1f make it: LPI -> RPI
                             -   -   -
>> 3dresample -orient RPI -inset /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~.nii.gz -prefix /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~_RPI.nii.gz
                             -   -   -
>> immv /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~_RPI.nii.gz /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~.nii.gz
· @0.1

Current processing step:
@ getting data from fmriprep directory
····································································
                             -   -   -
>> immv /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~ /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline~TEMP~_FMP
                             -   -   -
>> cp /data/fmriprep-1.4.1/fmriprep/sub-BLMTBI104/ses-bline/func/sub-BLMTBI104_ses-bline_task-rest_run-001_desc-confounds_regressors.tsv /data/xcpengine/resting_state/sub-BLMTBI104/ses-bline/prestats/sub-BLMTBI104_ses-bline_fmriconf.tsv
ls: cannot access '/data/fmriprep-1.4.1/fmriprep/sub-BLMTBI104/ses-bline/anat/*MNI152NLin2009cAsym*desc-preproc_T1w.nii.gz': No such file or directory
ls: cannot access '/data/fmriprep-1.4.1/fmriprep/sub-BLMTBI104/ses-bline/anat/*MNI152NLin2009cAsym*dseg.nii.gz': No such file or directory
ls: cannot access '/data/fmriprep-1.4.1/fmriprep/sub-BLMTBI104/ses-bline/anat/*MNI152NLin2009cAsym*desc-brain_mask.nii.gz': No such file or directory
· @ checking refvolume and structural orientation

Runtime Information
Docker tag latest (Dockerhub release 6 days ago)
Additional context
Docker call
docker run --rm -it \
-v /data/BL2_clean/derivatives:/data \
pennbbl/xcpengine:latest \
-c /data/xcpengine/cohort_files/test.csv \
-d /data/xcpengine/design_files/2019-08-01_fc-36p_despike.dsn \
-o /data/xcpengine/resting_state \
-r /data/fmriprep-1.4.1/fmriprep \
-t 1"

fMIRPrep File Structure
sub-BLMTBI104
 |-ses-bline
 | |-anat
 | | |-sub-BLMTBI104_ses-bline_run-001_from-orig_to-T1w_mode-image_xfm.txt
 | |-func
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-T1w_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-fsaverage_hemi-L.func.gii
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-fsaverage_hemi-R.func.gii
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_desc-MELODIC_mixing.tsv
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_AROMAnoiseICs.csv
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_desc-confounds_regressors.tsv
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_desc-confounds_regressors.json
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin6Asym_desc-smoothAROMAnonaggr_bold.nii.gz
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-001_space-MNI152NLin2009cAsym_desc-smoothAROMAnonaggr_bold.nii.gz
 | |-figures
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-sdc_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-bbregister_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-rois_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-compcorvar_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-carpetplot_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-confoundcorr_bold.svg
 | | |-sub-BLMTBI104_ses-bline_task-rest_run-1_desc-aroma_bold.svg
 |-ses-ptx
 | |-anat
 | | |-sub-BLMTBI104_ses-ptx_run-001_from-orig_to-T1w_mode-image_xfm.txt
 | |-func
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-aparcaseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-aseg_dseg.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-brain_mask.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-brain_mask.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-preproc_bold.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_desc-preproc_bold.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-T1w_boldref.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-fsaverage_hemi-L.func.gii
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-fsaverage_hemi-R.func.gii
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_desc-MELODIC_mixing.tsv
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_AROMAnoiseICs.csv
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_desc-confounds_regressors.tsv
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_desc-confounds_regressors.json
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin6Asym_desc-smoothAROMAnonaggr_bold.nii.gz
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-001_space-MNI152NLin2009cAsym_desc-smoothAROMAnonaggr_bold.nii.gz
 | |-figures
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-sdc_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-bbregister_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-rois_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-compcorvar_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-carpetplot_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-confoundcorr_bold.svg
 | | |-sub-BLMTBI104_ses-ptx_task-rest_run-1_desc-aroma_bold.svg
 |-anat
 | |-sub-BLMTBI104_from-T1w_to-fsnative_mode-image_xfm.txt
 | |-sub-BLMTBI104_desc-preproc_T1w.nii.gz
 | |-sub-BLMTBI104_desc-preproc_T1w.json
 | |-sub-BLMTBI104_desc-aparcaseg_dseg.nii.gz
 | |-sub-BLMTBI104_desc-aseg_dseg.nii.gz
 | |-sub-BLMTBI104_desc-brain_mask.nii.gz
 | |-sub-BLMTBI104_desc-brain_mask.json
 | |-sub-BLMTBI104_label-CSF_probseg.nii.gz
 | |-sub-BLMTBI104_label-GM_probseg.nii.gz
 | |-sub-BLMTBI104_label-WM_probseg.nii.gz
 | |-sub-BLMTBI104_dseg.nii.gz
 | |-sub-BLMTBI104_hemi-L_smoothwm.surf.gii
 | |-sub-BLMTBI104_hemi-R_smoothwm.surf.gii
 | |-sub-BLMTBI104_hemi-L_pial.surf.gii
 | |-sub-BLMTBI104_hemi-R_pial.surf.gii
 | |-sub-BLMTBI104_hemi-L_inflated.surf.gii
 | |-sub-BLMTBI104_hemi-R_inflated.surf.gii
 | |-sub-BLMTBI104_hemi-L_midthickness.surf.gii
 | |-sub-BLMTBI104_hemi-R_midthickness.surf.gii
 | |-sub-BLMTBI104_from-MNI152Lin_to-T1w_mode-image_xfm.h5
 | |-sub-BLMTBI104_from-T1w_to-MNI152Lin_mode-image_xfm.h5
 | |-sub-BLMTBI104_space-MNI152Lin_desc-preproc_T1w.nii.gz
 | |-sub-BLMTBI104_space-MNI152Lin_desc-preproc_T1w.json
 | |-sub-BLMTBI104_space-MNI152Lin_desc-brain_mask.nii.gz
 | |-sub-BLMTBI104_space-MNI152Lin_desc-brain_mask.json
 | |-sub-BLMTBI104_space-MNI152Lin_label-CSF_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152Lin_label-GM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152Lin_label-WM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152Lin_dseg.nii.gz
 | |-sub-BLMTBI104_from-MNI152NLin2009cAsym_to-T1w_mode-image_xfm.h5
 | |-sub-BLMTBI104_from-T1w_to-MNI152NLin2009cAsym_mode-image_xfm.h5
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_desc-preproc_T1w.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_desc-preproc_T1w.json
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_desc-brain_mask.json
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_label-CSF_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_label-GM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_label-WM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_dseg.nii.gz
 | |-sub-BLMTBI104_from-MNI152NLin6Asym_to-T1w_mode-image_xfm.h5
 | |-sub-BLMTBI104_from-T1w_to-MNI152NLin6Asym_mode-image_xfm.h5
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_desc-preproc_T1w.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_desc-preproc_T1w.json
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_desc-brain_mask.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_desc-brain_mask.json
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_label-CSF_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_label-GM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_label-WM_probseg.nii.gz
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_dseg.nii.gz
 |-figures
 | |-sub-BLMTBI104_dseg.svg
 | |-sub-BLMTBI104_space-MNI152Lin_T1w.svg
 | |-sub-BLMTBI104_space-MNI152NLin2009cAsym_T1w.svg
 | |-sub-BLMTBI104_space-MNI152NLin6Asym_T1w.svg
 | |-sub-BLMTBI104_desc-reconall_T1w.svg

Hi @araikes
yes, you used current fmriprep version 1.4x with different output-spaces.  we currently updated the xcpengine as well to match the current fmriprep outputs with different template. you can pull for new docker/singularity  image.

Hi @a3sha2,
As I noted in my post, I have the current version from Dockerhub. I just double checked this. I have both the 1.0 tag and the latest tag and they are up to date. Do I need to pull straight from the repo and build the Docker image?
Assuming that it was a template spaces issue, I would expect it to be looking in the correct file location but have trouble identifying the correct MNI file to use. Instead, it's looking for the correct string *MNI152NLin2009cAsym* but it's not looking in the correct location for a multi-session study.

Yes, we have not change the volume number but it has been updated. You can pull for new one. it will work fine

Hi @a3sha2,
Please forgive me. I feel like I'm not communicating this clearly.
I have the current version of XCP Engine. I pulled it yesterday and tried again this morning before I responded earlier, just to confirm. The version on which I'm having this issue is the most current version.

thanks @araikes
pls pull for new docker image

Pulled it and it appears to be working as expected. I'll keep an eye on it and let you know.

I am now running into a new issue, though I can't fully tell if it is problematic. Steps up until fcon work just fine.  Is this functioning as intended (spurious error) or is it skipping something and jumping to computing subroutine 1.3?

Hi @araikes
There is subroutine 1.2.3 or 1.2.6 that is compulsory which look like it doesn't run that is why there was error. that subroutine is necessary when your bold is not in MNI (or template) space. it is missing some transformation files from fmriprep ouput. You have no problem if your bold is in MNI space but it will be nice to know what is going on. Can you share with us the full log file and the _space.json
Also try to  rerun with prestats_rerun[1]=1

Hi @a3sha2,
So I went back and did a clean processing and it appears to work. That particular error only shows up if I have to restart/rerun due to failure (we had some network failures leading to early processing termination).
However, if I start from scratch or presumably if I do prestats_rerun[1]=1, it shouldn't throw an issue.

setting prestats_rerun[1]=1 will ensures that the inputs are the same with previous and read all the transformation files needed. We will make sure it is default in all the design file #221

Hi @a3sha2,
Everything appears to be working well for the anatomical processing stream now.
I do have one further question: In fMRIPrep, one of the preprocessing steps is N4BiasCorrection. XCP Engine appears to also be running N4 correction. Is this double correction potentially problematic?

It may be problematic honestly. Running N4 twice or many time can increase or decrease voxel intensity in some regions. The best is to use use raw image ( from bids) as input.
Look at difference between N4 (once) and N4(twice)

I figured that would be the case. The documentation should probably be revised to reflect using the original images rather than the fMRIPrep'd ones. Currently, users are instructed to use the post-fMRIPrep files prior to running one of the Anatomical pipelines (see image below).
Also, from the way that the Functional pipelines currently work, would using the original BIDS images pose any problems if the anatomical stream was run first to pipe into the functional stream? I can see it may pose issues if longitudinal/multi-session T1s are merged in fMRIPrep. Maybe post-fMRIPrep T1s need a flag/option to skip N4.

thank you very much. we will make correction

pls share me the logs files pls


AppState.currentState returning unknown in iOS when app launched in release mode.

Description
AppState.currentState returning unknown in iOS when app launched and this is not happening in debug mode.
React Native Version
0.70.10
Output of npx react-native info
System:
OS: macOS 13.4
CPU: (8) arm64 Apple M2
Memory: 86.84 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 14.21.3 - /opt/homebrew/bin/node
Yarn: Not Found
npm: 6.14.18 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK:
API Levels: 27, 28, 29, 30, 31, 32, 33
Build Tools: 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 33.0.0, 33.0.2
System Images: android-27 | Google APIs ARM 64 v8a, android-27 | Google Play Intel x86 Atom, android-29 | Google APIs ARM 64 v8a, android-29 | Google Play ARM 64 v8a, android-30 | Google Play ARM 64 v8a, android-32 | Google Play ARM 64 v8a, android-33 | Google APIs ARM 64 v8a, android-33 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.10121639
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
Languages:
Java: 11.0.18 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.10 => 0.70.10
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Clone the project from the below link , run the iOS and check the console once the app launched.
Snack, code example, screenshot, or link to a repository
https://github.com/rifad4u/AppStateIssue

⚠	Missing Reproducible Example
ℹ	It looks like your issue is missing a reproducible example. Please provide either:

If your bug is UI related: a Snack
If your bug is build/update related: use our Reproducer Template

Updated

i am facing the same issue, please help

Same on react-native 0.71.12

same on react-native 0.72.3

Same on react-native 0.72.4

same on 0.72.6

Still happening on 0.71.8

This doesn't seems to be an issue with latest RN version: 0.75.2.
I tested this on release mode.
@rifad4u Please confirm here. If it is resolved we can close this issue.


[hi] add Localize en/docs/contribute/localization.md

fixes #36470
updated [hi] Localize en/docs/contribute/localization.md page.

Hey @anubha-v-ardhan and @divya-mohan0209 please review this PR.

I have opened another PR. Closing this PR.
/close


Add support for feeds

In order to be able to deploy production websites to Swarm, it would be easy useful for this action to support feeds.
This could be done either by conditionally replacing swarm-cli upload with swarm-cli feed upload and adding inputs for:

topic
topic-string
identity

Or adding a separate action that runs swarm-cli feed update.
What would be your preference? I'd be happy to write a PR. 🙂

Yeah, support for Feeds makes definitely sense! PR will be very appreciated!
I think it would make more sense to create another step for the feed update if the inputs for this are specified and use the swarm-cli feed update. It seems you will have to do some hacking as the swarm-cli identity import requires a file to import the identity. Let me know if you need help!

I ended up re-implementing the actions I needed in a new monorepo, because I wasn't quite sure it would fit in nicely here.
A successful run can be found here: https://github.com/filoozom/swarm-actions/runs/5154911654
Chunk Reference: e5b26537752bdb6c5632f5c3abe044fa3372c5fdb743636f84e30715187b54e4
Feed Reference: 16a49afcc8cfaef1cdfc3e682d5af6c478bedbede8e68790afd8bff8639da012
Feed Manifest: 28de3bb9d6f54b80ccdd2ba24bee5080cd2e41a868ce31e51f29b36e5b8ba366
Feed Bzz.link: https://bah5acgzafdpdxoow6vfybtg5forex3sqqdgs4qnindhddzi7fgzw4w4lunta.bzz.link

The objective was to be quite modular, by having the "smallest" actions possible (although I didn't really to that for write-feed, where the manifest is systematically created): https://github.com/filoozom/swarm-actions/blob/main/.github/workflows/test.yml


R-INLA crashing issue inla.mkl: src/inla.c:23905: inla_parse_ffield

Have just tried this after updating the data and still getting crashes for the remaining countries, so there is an error here. Might want to still look at the data more closely to see if something can be fixed before passing into the model


Add infra availability for HyperShift Clusters

Signed-off-by: Sai Sindhur Malleni<EMAIL_ADDRESS>Description
Fixes

@mukrishn rebased, please check and merge


fix: 任务日志配置为Online时出现日志乱序 #515

What is the purpose of the change
fix bug #515
Brief changelog
It is best to associate an existing issue
Verifying this change
Do I need to test?
Has testing been completed?
Test method?
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 3 checklist before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Follow the git commit specification

feat: xxx ->      The feat type is used to identify production changes related to new backward-compatible abilities or functionality.
perf: xxx ->      The perf type is used to identify production changes related to backward-compatible performance improvements.
fix: xxx  ->      The fix type is used to identify production changes related to backward-compatible bug fixes.
docs: xxx ->      The docs type is used to identify documentation changes related to the project - whether intended externally for the end users (in case of a library) or internally for the developers.
test: xxx ->      The test type is used to identify development changes related to tests - such as refactoring existing tests or adding new tests.
refactor: xxx ->  The refactor type is used to identify development changes related to modifying the codebase, which neither adds a feature nor fixes a bug - such as removing redundant code, simplifying the code, renaming variables, etc.

System.nanoTime() 非绝对时间，是 JVM 相对于某个启动点的偏移量。如果用 System.nanoTime() 代替当前的时间戳，只能解决单机的排序问题，但会引入集群间的排序问题，理论上问题更严重。
一般实际使用中，log 不可能那么频繁，如果是毫秒级的日志量，对 server 的压力也很大，这种情况也不建议用 online logger

如果想彻底 fix 这个问题，还需要仔细想想哦。


dgst verify failed

I was using the following command to verify files
openssl dgst -verify file.pem -signature file1 file2
This was working fine with OpenSSL 1.0.1e-fips . After updating to OpenSSL 1.0.2k-fips, the verification fails.
I'm using centos 7.  How can I solve this issue ?

Tried the latest 1.0.1u and it worked. So closing the ticket.


How do i disable Enlarge Day?

How do I disable the EnlargeDay animation? in the Datepicker?

You cannot, currently.  But that could be changed.

It is easy, just downgrade to 2.0.4.

I'd love an option to disable it too.
It actually looks like it's feasible as there is a "Enlarge day" toggle on the theme demo page: https://6edesign.github.io/svelte-calendar/docs/theme-editor/light


sst deploy closes with non-error exit code even if there was an error

I got this error in my GitHub Actions #5210, but it took a while to track down because the GitHub Action was completing without showing any errors. I'm on the latest SST version 3.4.3.

Notice that it completed successfully even though it encountered an error.

That's odd @thdxr

Just noticed this as well

@klaemo unrelated to this issue but your specific issue should be fixed with version 3.4.7


WinGet still only installs v0.35.0

Microsoft PowerToys version
0.37.0
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
Run winget install powertoys
✔ Expected Behavior
Expected to install v0.37 over v0.35.
❌ Actual Behavior
Installs v0.35.
winget show powertoys shows it's still on v0.35:
Found PowerToys [Microsoft.PowerToys]
Version: 0.35.0
Publisher: Microsoft Corporation
Description: Microsoft PowerToys is a set of utilities for power users to tune and streamline their Windows experience for greater productivity. Inspired by the Windows 95 era PowerToys project, this reboot provides power users with ways to squeeze more efficiency out of the Windows 10 shell and customize it for individual workflows.
Homepage: https://github.com/microsoft/PowerToys
License: MIT
License Url: https://github.com/microsoft/PowerToys/blob/master/LICENSE
Installer:
  Type: Exe
  Download Url: https://github.com/microsoft/PowerToys/releases/download/v0.35.0/PowerToysSetup-0.35.0-x64.exe
  SHA256: 8a052767127a6e2058baae03b551a807777bb1b726650e2c7e92c3e92c8df80d

Other Software
No response

As an aside, I have to install via WInGet as the normal Windows installer no longer wants to play ball on my machine, as I reported here #10563.

thanks for the call out, today has been nuts, I'm helping test a new tool and seeing if i can't get an updated drop

looks like a @jedieaston did a PR https://github.com/microsoft/winget-pkgs/pull/11779

Live


Improved debug messages

PR Description
While debugging the validator to investigate some missing attestations, I enabled the DEBUG log level and I found this kind of messages:
2021-08-21 01:14:58.706+02:00 | ValidatorTimingChannel-0 | INFO  | AbstractDutyScheduler | Not performing attestation duties for slot 1889773 because it is too far ahead of the current slot UNDEFINED
2021-08-21 01:15:15.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889774 because last production slot 1889774 is beyond that.
2021-08-21 01:15:27.002+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889775 because last production slot 1889775 is beyond that.
2021-08-21 01:15:39.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889776 because last production slot 1889776 is beyond that.
2021-08-21 01:15:51.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889777 because last production slot 1889777 is beyond that.
2021-08-21 01:16:03.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889778 because last production slot 1889778 is beyond that.
2021-08-21 01:16:15.002+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889779 because last production slot 1889779 is beyond that.
2021-08-21 01:16:27.007+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889780 because last production slot 1889780 is beyond that.
2021-08-21 01:16:34.989+02:00 | validator-async-0 | INFO  | teku-validator-log | Validator   *** Published attestation        Count: 1, Slot: 1889781, Root: 15b158..6304
2021-08-21 01:16:39.002+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889781 because last production slot 1889781 is beyond that.
2021-08-21 01:16:51.001+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889782 because last production slot 1889782 is beyond that.
2021-08-21 01:17:03.001+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Not performing attestation duties for slot 1889783 because last production slot 1889783 is beyond that.

I found these messages a bit misleading, especially when they say not performing attestation duties... just after publishing one correctly. And also, the current slot is almost always equal to the last production slot, so again the message is not very clear, I never seen it beyond that. So I have needed to look into the code to really understand what was happening.
I improved those messages for me, maybe this is useful also for others. Merging this PR the log will look like this:
2021-08-21 04:50:35.087+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing block duties for slot 1890851, last production slot null
2021-08-21 04:50:35.422+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing attestation duties for slot 1890851, last production slot null
2021-08-21 04:50:39.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Attestation duties for slot 1890851 already performed, last production slot 1890851
[...]
2021-08-21 04:51:31.706+02:00 | ValidatorTimingChannel-0 | INFO  | AbstractDutyScheduler | Not performing attestation duties for slot 1890856, unable to verify its epoch
[...]
2021-08-21 04:51:47.150+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing attestation duties for slot 1890857, last production slot 1890856
2021-08-21 04:51:51.001+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Attestation duties for slot 1890857 already performed, last production slot 1890857
2021-08-21 04:51:59.004+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing block duties for slot 1890858, last production slot 1890857
2021-08-21 04:51:59.105+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing attestation duties for slot 1890858, last production slot 1890857
2021-08-21 04:52:03.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Attestation duties for slot 1890858 already performed, last production slot 1890858
2021-08-21 04:52:10.670+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing attestation duties for slot 1890859, last production slot 1890858
2021-08-21 04:52:11.004+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing block duties for slot 1890859, last production slot 1890858
2021-08-21 04:52:12.786+02:00 | validator-async-0 | INFO  | teku-validator-log | Validator   *** Published attestation        Count: 1, Slot: 1890859, Root: 11a59c..b2b9
2021-08-21 04:52:15.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Attestation duties for slot 1890859 already performed, last production slot 1890859
2021-08-21 04:52:23.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing block duties for slot 1890860, last production slot 1890859
2021-08-21 04:52:24.247+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Performing attestation duties for slot 1890860, last production slot 1890859
2021-08-21 04:52:27.003+02:00 | ValidatorTimingChannel-0 | DEBUG | AbstractDutyScheduler | Attestation duties for slot 1890860 already performed, last production slot 1890860

Fixed Issue(s)
None.
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

I'm going to close this as I haven't heard back but thank you for taking the time to provide some changes you found useful for consideration.  Feel free to reopen if you have time and interest to pick this up again.


Reverse Proxy and unhealthy service

As far as I understood when instance goes down because of whatever reason Service Fabric tries to spin up another one on a different node.
Does Reverse Proxy takes the state of a service into account when decide which one instance to route request to?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31e0a1d2-789d-240f-be0b-892d43f80b66
Version Independent ID: aac58453-4adc-5c04-8067-d7107dc2df45
Content: Azure Service Fabric reverse proxy
Content Source: articles/service-fabric/service-fabric-reverseproxy.md
Service: service-fabric
GitHub Login: @BharatNarasimman
Microsoft Alias: bharatn

@xela30 Thanks for the feedback! We are currently investigating and will update you shortly.

@xela30 - can you clarify what you mean by state of a service?
@kavyako as well.

@xela30 I will close this for now. Please reopen when ready and we can continue.


NetworkInjector+URLConnection.swift:20:99: error

/Pods/atlantis-proxyman/Sources/NetworkInjector+URLConnection.swift:20:99: error: cannot force unwrap value of non-optional type '(any NSURLConnectionDataDelegate) -> ((NSURLConnection, URLResponse) -> Void)?'
        let selector : Selector = #selector((NSURLConnectionDataDelegate.connection(_:didReceive:)!)
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

/Pods/atlantis-proxyman/Sources/NetworkInjector+URLConnection.swift:55:99: error: cannot force unwrap value of non-optional type '(any NSURLConnectionDataDelegate) -> ((NSURLConnection, URLResponse) -> Void)?'
        let selector : Selector = #selector((NSURLConnectionDataDelegate.connection(_:didReceive:)!)
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

Xcode: Version 15.0 (15A240d)
macOS: 13.5.2

Hi @cdoky what iOS version you're using? and is it Simulator or physical device?

Hi @cdoky what iOS version you're using? and is it Simulator or physical device?

iPhone 15 Pro Max Simulator
and the main project is Objective-c...

i am also have the same exact issue as @cdoky

@mahmoudElfeel67 @cdoky let's update Atlantis to the latest version v1.22.0. It will fix your issue.
Your library is really old v1.17.0 (Released on 2022) because we completely removed URLConnection class 👍

I tested again with Xcode 15.0.1, iOS 17.0, Atlantis v1.22.0 and It works as intended 👍

very said
Specs satisfying the atlantis-proxyman (~> 1.22.0) dependency were found, but they required a higher minimum deployment target.
our project is support iOS11

same  question

It's too old to support iOS 11 since it's 17 (6 years old).
May I ask:

What macOS and Xcode versions you're using to develop your iOS app?

1、macOS 13.5.2
2、Xcode 15.2
our project is support iOS11+
🙁

Tried to support iOS 11, but it's deprecated but Swift Package Manager (https://developer.apple.com/documentation/packagedescription/supportedplatform/iosversion/v11)
and URLSessionWebsocketTask is only available on iOS 13, I can exclude it because it's too complicated : /


Official wolfSSL library and old 3rd party both in library index.

Describe the problem
Hi @per1234
I see the new Official wolfSSL is in the The Library Manager index but the old, 3rd party version from onelife is still there, too.
Those versions (5.5.4 and 4.7.1) are not Official wolfSSL repositories and do not even work as noted in https://github.com/wolfSSL/wolfssl/issues/6360 and the wolfssl forum.
My Arduino IDE only sees the old one, not the new official one. Any suggestions?
    {
      "name": "wolfssl",
      "version": "4.7.1",
      "author": "www.wolfssl.com",
      "maintainer": "onelife<EMAIL_ADDRESS>      "sentence": "wolfSSL Embedded SSL/TLS Library for Arduino",
      "paragraph": "The wolfSSL embedded SSL library is a lightweight SSL/TLS library written in ANSI C and targeted for embedded, RTOS, and resource-constrained environments - primarily because of its small size, speed, and feature set.",
      "website": "https://github.com/onelife/Arduino_wolfssl",
      "category": "Communication",
      "architectures": [
        "*"
      ],
      "types": [
        "Contributed"
      ],
      "repository": "https://github.com/wolfSSL/Arduino-wolfSSL.git",
      "providesIncludes": [
        "wolfssl.h"
      ],
      "url": "https://downloads.arduino.cc/libraries/github.com/wolfSSL/wolfssl-4.7.1.zip",
      "archiveFileName": "wolfssl-4.7.1.zip",
      "size": 5535395,
      "checksum": "SHA-256:b332f51ee3015903a46feffa6738128bf045f17e8b0cdab410ff625f1373a0c0"
    },
    {
      "name": "wolfssl",
      "version": "5.5.4",
      "author": "www.wolfssl.com",
      "maintainer": "onelife<EMAIL_ADDRESS>      "sentence": "wolfSSL Embedded SSL/TLS Library for Arduino",
      "paragraph": "The wolfSSL embedded SSL library is a lightweight SSL/TLS library written in ANSI C and targeted for embedded, RTOS, and resource-constrained environments - primarily because of its small size, speed, and feature set.",
      "website": "https://github.com/onelife/Arduino_wolfssl",
      "category": "Communication",
      "architectures": [
        "*"
      ],
      "types": [
        "Contributed"
      ],
      "repository": "https://github.com/wolfSSL/Arduino-wolfSSL.git",
      "providesIncludes": [
        "wolfssl.h"
      ],
      "url": "https://downloads.arduino.cc/libraries/github.com/wolfSSL/wolfssl-5.5.4.zip",
      "archiveFileName": "wolfssl-5.5.4.zip",
      "size": 11371241,
      "checksum": "SHA-256:7028e4c78fed163c1daa38517c1ad452e84e5adb60fc6bc8a50863e1bbc07f31"
    },
    {
      "name": "wolfssl",
      "version": "5.6.6-Arduino.1",
      "author": "wolfSSL inc",
      "maintainer": "wolfSSL inc<EMAIL_ADDRESS>      "sentence": "A lightweight SSL/TLS library written in ANSI C and targeted for embedded, RTOS, and resource-constrained environments.",
      "paragraph": "Manual: https://www.wolfssl.com/documentation/manuals/wolfssl/index.html.",
      "website": "https://www.wolfssl.com/",
      "category": "Communication",
      "architectures": [
        "*"
      ],
      "types": [
        "Contributed"
      ],
      "repository": "https://github.com/wolfSSL/Arduino-wolfSSL.git",
      "url": "https://downloads.arduino.cc/libraries/github.com/wolfSSL/wolfssl-5.6.6-Arduino.1.zip",
      "archiveFileName": "wolfssl-5.6.6-Arduino.1.zip",
      "size": 9937716,
      "checksum": "SHA-256:939799246e1db69f0c865507c7602858b86350ad56cb40db0c3caca5d1858931"
    },

To reproduce
See The Library Manager index
Expected behavior
Only the Official wolfSSL library should be present.
Additional context
See also See https://github.com/arduino/library-registry/pull/4056
Update: I do see the new wolfSSL in the Arduino app, along with the old versions that should please be removed.
I could probably arrange to create Official wolfSSL releases for those exact versions, if desired?

References to wolfSSL should only contain the Official wolfSSL:
    {
      "name": "wolfssl",
      "version": "5.6.6-Arduino.1",
      "author": "wolfSSL inc",
      "maintainer": "wolfSSL inc<EMAIL_ADDRESS>      "sentence": "A lightweight SSL/TLS library written in ANSI C and targeted for embedded, RTOS, and resource-constrained environments.",
      "paragraph": "Manual: https://www.wolfssl.com/documentation/manuals/wolfssl/index.html.",
      "website": "https://www.wolfssl.com/",
      "category": "Communication",
      "architectures": [
        "*"
      ],
      "types": [
        "Contributed"
      ],
      "repository": "https://github.com/wolfSSL/Arduino-wolfSSL.git",
      "url": "https://downloads.arduino.cc/libraries/github.com/wolfSSL/wolfssl-5.6.6-Arduino.1.zip",
      "archiveFileName": "wolfssl-5.6.6-Arduino.1.zip",
      "size": 9937716,
      "checksum": "SHA-256:939799246e1db69f0c865507c7602858b86350ad56cb40db0c3caca5d1858931"
    },

Issue checklist

[X] I searched for previous reports in the issue tracker
[X] My report contains all necessary details

Hi @gojimmypi. Since https://github.com/arduino/library-registry/pull/4056 was only a request to change the registered repository URL for an existing library, the entries for the previous releases of the library were not removed from the Library Manager index.
If you would like to request the removal of releases, please follow this procedure:
https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-remove-a-release-of-my-library-from-library-manager

Hi @per1234
I've used the template and created https://github.com/arduino/library-registry/issues/4135 and https://github.com/arduino/library-registry/issues/4136

Hi @per1234 - just wanted to say thanks for all the help! I have the Official wolfSSL all setup now.
https://github.com/wolfSSL/Arduino-wolfSSL
Status:
https://downloads.arduino.cc/libraries/logs/github.com/wolfSSL/Arduino-wolfSSL/


chore: update dependency github.com/docker/docker

Pre-release is failing due to a vulnerability on dependency github.com/docker/docker and this PR updates it to the latest version.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.16%. Comparing base (4c71abb) to head (3222d5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
+ Coverage   65.65%   66.16%   +0.51%
==========================================
  Files         164      164
  Lines       13750    10662    -3088
==========================================
- Hits         9027     7055    -1972
+ Misses       4229     3112    -1117
- Partials      494      495       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Clarify "Select Grant admin consent"

I found the button/link for step 7 Select Grant admin consent for (your tenant name).
is not easy to discover.
Only image in https://stackoverflow.com/questions/65509170/application-does-not-have-sufficient-permissions-against-this-web-resource-to-pe helped me.
It should be better described, e.g.
Select permission in the list.
Click the button with blue tick "Grant admin consent for (your tenant name)" at the top of permissions list.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fcbc674-8de5-e50b-bec7-9f4b4ced1f3c
Version Independent ID: 937d691f-af1d-ac9f-7094-90addf5c63ce
Content: Add a web API application - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/add-web-api-application.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@michael-freidgeim-webjet
Thanks for your feedback! We will investigate and update as appropriate.

@michael-freidgeim-webjet
Thank you for pointing this out! I've created a PR to update the documentation and it's currently waiting for the author (@msmimart ) to review and sign off.
I will now close out this issue. Please allow some time for the author to review and the changes to reflect.
Thank you for your time and patience!


154

QUESTION 154
Hotspot Question
For each of the following statements, select Yes if the statement is true. Otherwise, select No.
NOTE: Each correct selection is worth one point.


Support Get  favicon

hi, can feed-extractor, oEmbed Extractor support crawling to favicon URL like article-extractor?

@kk7771 thank you for your suggestion. I see two reasons not to do so:

feed-extractor  and oembed-extractor do not touch the HTML page where the article is presented. Therefore, another request will be needed to download. This is different from article-extractor, which has to download the HTML first.
feed-extractor returns a list of news entries coming from the same website, so you only need to get favicon.ico for that website once. You can save it along with a list of RSS urls as static files, instead of dynamic fetching.

You can get website favicon with Google S2. Just give it a domain or the whole URL, it will provide you the favicon to display on your view, e.g:

https://www.google.com/s2/favicons?domain=github.com
https://www.google.com/s2/favicons?domain=x.com


refactor: remove derp meshing

Description
closes #2074
Notes & open questions

Change checklist

[ ] Self-review.
[ ] Documentation updates if relevant.
[ ] Tests if relevant.

Red is a beautiful colour...


Error unmounting component: "TypeError: Cannot read property 'disablePIP' of undefined"

Current Behavior
When the screen is quickly refreshed or redirected before the player is fully initialized, an exception is thrown with the message "TypeError: Cannot read property 'disablePIP' of undefined" and the player fails to unmount.
Expected Behavior
The player unmounts.
Steps to Reproduce
We have not been able to reliably trigger it every time, but it is reasonably consistent with these steps:

Have a screen with one or more player components included start to render
The user clicks a button to cause a redirect before the player is fully initialized

Environment

URL attempting to play: any
Browser: Google Chrome, Safari, Microsoft Edge (possibly others)
Operating system: Mac OS, Windows (possibly others)
jsFiddle example:

Other Information
We believe the issue is caused here:
https://github.com/CookPete/react-player/blob/a4e89c0f9e0ad10dac4e57ea2cae670a7ffd29d3/src/Player.js#L32
In our debugging we believe we found that if this line is called before this.player is created and initialized, the exception is thrown.

Fixed in v2.0.1


StopIteration

Hi, thank you for your share. Following your description, I try to use your code in my project, but I got the error in 'scheduler.batch_step()', this happened on this line 't_cur = self.t_epoch + next(self.batch_increment)'

What is your batch size and how many samples do you have per epoch?

OK, I figured it out.  The bug happened in other place in my project. Thank you

@mpyrozhok @reborm I have same error with "StopIteration" at same place. batch_size is 140 and 20580 samples each epoch
Any idea?

This can happen when you use some batch size and epoch size values while initializing scheduler and then supplying different values to your dataloader, or any other object that splits your epoch into batches and drives your training loop. You're trying to call scheduler more times per epoch than it is possible with batch size and epoch size values that you've supplied. times = samples_per_epoch // batch_size

does it have to be exactly equal to this number? Can it be less?

getting a new error:

TypeError                                 Traceback (most recent call last)
 in ()
1 training(model=model, epoch=20, eval_every=500,
2          loss_func=loss_function, optimizer=optimizer, train_iter=train_iter,
----> 3         val_iter=val_iter, scheduler=scheduler, warmup_epoch=3, early_stop=2)
 in training(epoch, model, eval_every, loss_func, optimizer, train_iter, val_iter, scheduler, early_stop, warmup_epoch)
11
12     for e in range(epoch):
---> 13         scheduler.step()
14         #optimizer = exp_lr_scheduler(optimizer, e) #Added this line for learning rate decay
15         if e >= warmup_epoch:
 in step(self)
270         self.last_epoch += 1
271         self.t_epoch += 1
--> 272         self._set_batch_size()
273         self.batch_step()
274
 in _set_batch_size(self)
265         d, r = divmod(self.epoch_size, self.batch_size)
266         batches_in_epoch = d + 2 if r > 0 else d + 1
--> 267         self.batch_increment = iter(torch.linspace(0, 1, batches_in_epoch))
268
269     def step(self):
TypeError: 'generator' object is not callable

@enzoampil

does it have to be exactly equal to this number? Can it be less?

It will be a different scheduler then, probably. Could you elaborate on why do you need it to be less? And which parameters do you use while creating the scheduler? A brief explanation of your intentions and thoughts would also be helpful.


Hide mobile list-menus by permission

Hides some mobile list menus if the permissions
are not sufficient.
Change the layout of the assignment mobile list

Please use bold assignment title in list view - as in agenda and motion list.

Rest looks good


Athena Profiler Issue

Affected module
backend
Describe the bug
Athena connector's Profiler ingestion failing and also it is keep in running state only.
The Main Error it shows is HIVE_BAD_DATA.
Here is schema for reference.

also it is not showing sample data too , instead it shows error as below:
No data available.
To view Sample Data, run the Profiler Ingestion. Please refer to this doc to schedule the [Profiler Ingestion]
To Reproduce
Run profiler ingestion in athena connector.
Expected behavior
Proflier ingestion should run successfully. and dont get hive_bad_data error
Version:
OpenMetadata version: 1.1.1
Additional context
Add any other context about the problem here.

@SagarManiar9 can you share the error log from the profiler ingestion workflow. This will help us understand a bit better what is going on.

Hi @SagarManiar9 looks like this error is related to your storage layer (the actual data files) based on this https://repost.aws/knowledge-center/athena-hive-bad-data-parsing-field-value
Closing this one as we cannot reproduce with "proper" data


Predictons same with StockTradingEnv, using 1 stock

Describe the bug
I am using your your colab guide here https://github.com/AI4Finance-Foundation/FinRL/blob/master/Stock_NeurIPS2018_SB3.ipynb
I am training the model with PPO agent and using DRLAgent.DRL_prediction to make predictions.  Also I am using only 2 stocks ['ADS.DE', 'ALV.DE']
I didn't change nothing inside StockTradingEnv. I just removed from the Environment instantiation for the test the turbolance and risk params

These two.
The rest is all the same.
I added a print in DRLAgent.Prediction to print the action while predicting on test data.
This is the result: https://nekobin.com/hapodiniba
Why most of the time the predictions are same? And why if I only use one stock predictions are always same and never change ?

I tried both with one stock and with two.
With one stock predictions are always the same. With two stocks they don't  change  often and they do it syncronously (so when one of them change then the other as well)

This is the script that i am currently using: https://nekobin.com/digayorivu

The word "prediction" is confusing. Please clarify it a bit.

action from here

@makovez how about reproducing the results first?  Using Dow-30?

For dow30 https://nekobin.com/putofeloji

Sorry this is print (action) output https://nekobin.com/beqozogufu
The one before is actions_memory variable, which apparently is different from action


Feature/context

Before making the Pull Request:
Created the relationship for questions and contexts as well as set up some seed data for contexts, with the endpoint to get a list of questions associated with a context as well as an endpoint for all contexts.

[x] Is there a description to this pull request that points to a specific user story, feature, or bugfix?
[x] Are there comments where the code may be unclear?
[x] Is all dead code, commented out code, etc. removed?
[ ] Are there tests written for these changes?
[ ] Does the ReadMe need to be updated?

Before being merged by the TPL:

[ ] Has the pull request been reviewed by at least two team members?
[ ] Did they leave any comments or suggestions?
[ ] Were those suggestions acted on?
[ ] Are all tests passing?
[ ] Has the documentation been updated?

I made a mistake, will delete the branch and start new PR


Read the stderr into termination reason when container fails

TL;DR
This change will automatically read the pod log and set it as the termination reason when the container exits with non-zero exit code. In case of flytekit, and it fails to write error.pb, the log will have more information to surface to users.
Type

[ ] Bug Fix
[X] Feature
[ ] Plugin

Are all requirements met?

[X] Code completed
[X] Smoke tested
[X] Unit tests added
[X] Code documentation added
[X] Any pending items have an associated Issue

Tracking Issue
https://github.com/lyft/flyte/issues/308

Codecov Report

Merging #87 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   54.98%   54.99%
=======================================
  Files          91       91
  Lines        4661     4662    +1
=======================================
+ Hits         2563     2564    +1
  Misses       1821     1821
  Partials      277      277

Impacted Files
Coverage Δ

...tasks/pluginmachinery/flytek8s/container_helper.go
83.33% <100.00%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d709c...276ec48. Read the comment docs.

No parsing just dropping a better error message

I was thinking if we should use this always?

I think it'll almost always give you a better idea.... I'm thinking we can further limit the size of the message on our side...
What are your concerns?


Cannot connect to web server from chapter 2

curl fails to work like in the book
provider "aws" {
    version = "~> 2.0"
    region = "us-east-1"
}

resource "aws_instance" "example" {
    ami                     = "ami-0fc61db8544a617ed"
    instance_type           = "t2.micro"
    vpc_security_group_ids  = [aws_security_group.inst.id]

    user_data = <<-EOF
                #!/bin/bash
                echo "Hello, world" > index.html
                nohup busybox https -f -p 8080 &
                EOF
}

resource "aws_security_group" "inst" {
    name = "terra_inst"
    ingress {
        from_port   = 8080
        to_port     = 8080
        protocol    = "tcp"
        cidr_blocks =["<IP_ADDRESS>/0"]
    }
}

curl http://<IP_ADDRESS>:8080
curl: (7) Failed to connect to <IP_ADDRESS> port 8080: Connection refused

Turns out this AMI is for Amazon Linux 2.
Where do I find the amis? Book fails to mention this.