RHOAIENG-437: Add instructions to fetch models from different s3 regions

Description

This PR adds instructions to the credentials-s3.secret.template about the optional endpoint_url and region params. JIRA
To fetch models from S3 in a different region from the IAM credentials, user can consider endpoint_url param as an optional one and pass the correct region to the credentials secret. This way region will take precedence over endpoint_url and allows the task to download model from the specified region.
How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/retest

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

That's an interesting page, I hadn't seen it, thanks. I don't think we should mention that endpoint in our docs, since it will get confusing. If I understand that page correctly, that legacy endpoint will only work for some regions (those that existed before March 20th 2019).

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

That's an interesting page, I hadn't seen it, thanks. I don't think we should mention that endpoint in our docs, since it will get confusing. If I understand that page correctly, that legacy endpoint will only work for some regions (those that existed before March 20th 2019).

in that case this entire note wouldn't make sense? as we could just remove endpoint_url property from the template itself and just keep region alone?

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

That's an interesting page, I hadn't seen it, thanks. I don't think we should mention that endpoint in our docs, since it will get confusing. If I understand that page correctly, that legacy endpoint will only work for some regions (those that existed before March 20th 2019).

in that case this entire note wouldn't make sense? as we could just remove endpoint_url property from the template itself and just keep region alone?

For Amazon AWS S3, yes, we could remove the endpoint_url; but if someone wants to use some other implementation of the S3 API (of which there are many, such as if a user has a Minio instance deployed to the cluster, and that's what they're using for model storage), then the endpoint_url needs to be specified.

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

That's an interesting page, I hadn't seen it, thanks. I don't think we should mention that endpoint in our docs, since it will get confusing. If I understand that page correctly, that legacy endpoint will only work for some regions (those that existed before March 20th 2019).

in that case this entire note wouldn't make sense? as we could just remove endpoint_url property from the template itself and just keep region alone?

For Amazon AWS S3, yes, we could remove the endpoint_url; but if someone wants to use some alternative service providing the S3 API (of which there are many, such as if a user has a Minio instance deployed to the cluster, and that's what they're using for model storage), then the endpoint_url needs to be specified.

Member

@grdryn cool, i have just tweaked the note a bit.

Adding this for historical reference, the use of the s3.amazonaws.com global endpoint is now classified a Legacy Global Endpoint.

That's an interesting page, I hadn't seen it, thanks. I don't think we should mention that endpoint in our docs, since it will get confusing. If I understand that page correctly, that legacy endpoint will only work for some regions (those that existed before March 20th 2019).

in that case this entire note wouldn't make sense? as we could just remove endpoint_url property from the template itself and just keep region alone?

For Amazon AWS S3, yes, we could remove the endpoint_url; but if someone wants to use some alternative service providing the S3 API (of which there are many, such as if a user has a Minio instance deployed to the cluster, and that's what they're using for model storage), then the endpoint_url needs to be specified.

@grdryn cool, i have just tweaked the note a bit.

Thanks @Sara4994, I'm fine with this now. I'll leave it for a while to see if anyone else wants to review. Otherwise I'll approve later.

/approve
Adding approval also based on the additional LGTMs above


Falls Creek

Hi,
I think I have done everything properly expect for the index.js part. I'm still not sure how to do this... Could you please leave some helpful information on how to do this, so I can add resort without your help...
Thanks in advance

Ok thanks. I’ll try have a look today. One thing though, how did you work out that the falls creek data comes from the json file link?
Thanks,
Oscar
On 15 Dec 2018, 12:58 AM +1100, Damian Krzeminski<EMAIL_ADDRESS>wrote:

@pirxpilot requested changes on this pull request.
In lib/resorts/falls-creek/resort.json:

@@ -0,0 +1,17 @@
+{

"name": "Falls Creek",
"url": {
"host": "https://www.fallscreek.com.au",
"pathname": "/snowreport/"
},
"tags": [
"Australia",
"Victoria"
],
"ll": [
147.287,
36.8659
unless you guys moved Australia overnight latitude should be a negative number ;-)
In lib/resorts/falls-creek/index.js:

@@ -0,0 +1,7 @@
+module.exports = {

selector: 'div[class=="snow-inner-table-content"]',
'.snow-table-lift-status .snow-inner-table-content .table-row' selects every row in the table and from that you can try finding children with name and status
That said - this is again the case HTML does not have status information. Looks like you need to parse https://www.fallscreek.com.au/wp-content/uploads/FCSnowReport.json to get it. Use Mount Hotham as an example of how to do it - you'll have to change both 'index.js' and the test file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok ive added some stuff but still cant work out how to parse the json?

Ok thanks. I’ll try have a look today. One thing though, how did you work out that the falls creek data comes from the json file link? Thanks, Oscar

I usually start by opening the downloaded HTML file (it's in test/examples directory). I try to search for the name of the lift that is visible on the page. If I can find it I try to see if there is a status name or status icon/image next to it. In this case there was not. Next I open the page in the browser (I use Chrome). I open the Developer Tools (either Tools -> Developer Tools or Shift-Ctrl-I and I open the Network panel. I refresh the page and see what requests it makes to the server. XHR tab is usually worth a look - sometimes URL of the request is pretty obvious - but even if it is not you can click on each request and see the preview of the response. Try it with couple of resorts.
BTW: developer tools are pretty helpful if status is in HTML as well. You can highlight the status element and right-click on it and choose Copy->Selector from the popup menu. It's rarely the best selector to use in liftie but you can pair it down to what you need to use in index.js file.

Ok thanks. I tried to work out how to parse the Jason but could not succeed as it is different to mt Hotham... please take a look...
Thanks,
Oscar
On 16 Dec 2018, 10:46 AM +1100, Damian Krzeminski<EMAIL_ADDRESS>wrote:

Ok thanks. I’ll try have a look today. One thing though, how did you work out that the falls creek data comes from the json file link? Thanks, Oscar
I usually start by opening the downloaded HTML file (it's in test/examples directory). I try to search for the name of the lift that is visible on the page. If I can find it I try to see if there is a status name or status icon/image next to it. In this case there was not. Next I open the page in the browser (I use Chrome). I open the Developer Tools (either Tools -> Developer Tools or Shift-Ctrl-I and I open the Network panel. I refresh the page and see what requests it makes to the server. XHR tab is usually worth a look - sometimes URL of the request is pretty obvious - but even if it is not you can click on each request and see the preview of the response. Try it with couple of resorts.
BTW: developer tools are pretty helpful if status is in HTML as well. You can highlight the status element and right-click on it and choose Copy->Selector from the popup menu. It's rarely the best selector to use in liftie but you can pair it down to what you need to use in index.js file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok ive added some stuff but still cant work out how to parse the json?

You need to add falls-creek.json to the examples, and you need to rewrite the test to follow the Mt Hotham example. There are quite a few resorts in liftie that get status info from JSON. Search for "api" key in resort.json to see which ones.

Ok... I changed the js files to as follows:
`
var parse = require('../../lib/lifts/parse')('falls-creek');
/*global describe, it */
describe('parse falls-creek', function() {
it('should return lift status', function() {
var data = require('./example/falls-creek.json');
var expected = {
'Halleys Comet': 'closed',
'Towers Chair': 'closed',
'Drovers Dream Chair': 'closed',
'Board Walk': 'closed',
'Mouse Trap': 'closed',
'Monkey Bars': 'closed',
'Petes Train': 'closed',
'Gully Chair': 'closed',
'Eagle Express': 'closed',
'Scotts Chair': 'closed',
'Ruined Castle Chair': 'closed',
'Summit Chair': 'closed',
'Lakeside Poma': 'closed',
'International Poma': 'closed'
};
parse(data).should.eql(expected);
});
});
`
but then while running make I got this error:
`MacBook-Pro:liftie somethingMacbookPro$ make
./node_modules/.bin/jshint app.js bin/generate lib test
./node_modules/.bin/mocha --recursive --require should
internal/modules/cjs/loader.js:583
throw err;
^
Error: Cannot find module 'lib/lifts/parse'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Function.Module._load (internal/modules/cjs/loader.js:507:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at Object. (/Users/OkiRules/liftie/test/resorts/falls-creek.js:1:75)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at /Users/OkiRules/liftie/node_modules/mocha/lib/mocha.js:250:27
at Array.forEach ()
at Mocha.loadFiles (/Users/OkiRules/liftie/node_modules/mocha/lib/mocha.js:247:14)
at Mocha.run (/Users/OkiRules/liftie/node_modules/mocha/lib/mocha.js:576:10)
at Object. (/Users/OkiRules/liftie/node_modules/mocha/bin/_mocha:637:18)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
at startup (internal/bootstrap/node.js:282:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)
make: *** [test] Error 1
MacBook-Pro:liftie somethingMacbookPro$
`
Any suggestions?

Please help me parse the JSON, I really need help.


correcting main returnType

It don't see any reason why this arbitrary limitation should be put in place.


[SPARK-45851][CONNECT][SCALA] Support multiple policies in scala client

What changes were proposed in this pull request?
Support multiple retry policies defined at the same time. Each policy determines which error types it can retry and how exactly those should be spread out.
Scala parity for https://github.com/apache/spark/pull/43591
Why are the changes needed?
Different error types should be treated differently For instance, networking connectivity errors and remote resources being initialized should be treated separately.
Does this PR introduce any user-facing change?
No (as long as user doesn't poke within client internals).
How was this patch tested?
Unit tests, some hand testing.
Was this patch authored or co-authored using generative AI tooling?
No

cc @juliuszsompolski, @hvanhovell

cc @hvanhovell let's merge when tests pass :).

There is some problem with documentation generation in this Pr, do you know what's wrong there (can't tell from logs)

Merged to master.


Fix add regression tests for trino-connector accessing Kafka.


Replace jwt library with golang-jwt

Feedback
This is a tracker issue for https://github.com/vmware-tanzu/tanzu-framework/issues/715 which replaces a stale jwt library that contains a CVE with the golang-jwt library
Steps to Reproduce the Bug
our hack/builder is pulling in the tanzu-framework library and contains this as a transient dependency. It's not being used by TCE's builder but will continue to trigger security warnings until this is resovled in Tanzu-framework

This work was completed as part of tanzu-framework v0.14.0 which we will be able to consume in a future release of TCE: https://github.com/vmware-tanzu/tanzu-framework/releases/tag/v0.14.0


Runtime Error After Login

I cloned down the repo and am able to successfully login via Auth0. However, after I login I receive a runtime error.
Runtime Error
Ionic Framework: 3.1.1
Ionic App Scripts: 1.3.12
Angular Core: 4.0.2
Angular Compiler CLI: 4.0.2
Node: 6.9.3
OS Platform: macOS Sierra
Navigator Platform: MacIntel
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

I've got the same error :-(

Hey @cmullenx don't know whether you're still struggeling with the bug.
But for me, the problem was due to the way that the ionic livereloading server works. When I built the app, and ran it as an .apk on my android phone, it worked perfectly.
Hope it helps!


Update license in README text

Goal
Updates text in repo's README to reflect Apache license change. See https://github.com/davidlawrencer/embrace-android-sdk?tab=readme-ov-file#license for change.
Testing
N/A
Release Notes
N/A

@lucaslabari I think I don't have certain rights on the repo, so the Run Functional Tests check failed. Still okay to merge?

@davidlawrencer happy for this to be merged without that check as it's a documentation change & can't affect the results of the check

@davidlawrencer happy for this to be merged without that check as it's a documentation change & can't affect the results of the check

@fractalwrench, makes sense! would you mind re-approving?

Ari had updated the license already in another PR so we can close this


Dep Init, Ensure & Update deadlocks.

One month back, I ran dep init on my current project (that uses glide), and I was successfully able to run dep init, dep ensure and dep update. After a month break, when I tried to run dep ensure, or any other command, it deadlocks after few seconds.
What version of dep are you using (dep version)?
go version
go version go1.10.3 darwin/amd64
dep version
dep:
version     : v0.5.0
build date  : 2018-07-26
git hash    : 224a564
go version  : go1.10.3
go compiler : gc
platform    : darwin/amd64
features    : ImportDuringSolve=false
What dep command did you run?
All the dep command, deadlocks after few seconds.
What did you expect to see?
I have Gopkg.lock already created from one month back, and dep ensure worked. Today it is not working.
What did you see instead?
Deadlocks in downloading dependencies, after sometime.

Hi! thanks for the issue.
Could you be a little more specific in what you mean by "deadlock"? Does it just hang? Or is there some actual data race you're encountering, diagnosable by compiling with -race?

I pulled the current master and build dep locally. After that dep ensure works, I will recommend to cut next release with the fix.

OK, I don't know what changed that would've fixed your hang, but I'll be cutting a patch release soon - there's another fix in there that I do want to get out.


Match extension functions

More context here: https://github.com/detekt/detekt/issues/4448#issuecomment-1006521371 I'm implementing the no breaking option. It isn't nice but it works.
Related with #4448 but this PR doesn't fix the issue yet.

I have no idea what's going on here: https://github.com/detekt/detekt/runs/4726908840?check_suite_focus=true#step:4:499
I didn't change that class at all. Well, I did change it, but one year ago: 04/01/2021

Can we take a decission here?

Would this work across all Kotlin Multiplatform? I would vote for merge if this is not particularly tailored to JVM

Would this work across all Kotlin Multiplatform? I would vote for merge if this is not particularly tailored to JVM

Yes, it should work for all of them.

I think having the extension function receiver modelled as first parameter is a good compromise and aligns to the approach taken by other tools as well.

☝ That's my latest opinion. I'm in for merging this


Fix navigation link of documentation for storage using anchor.

What is this PR for?
In documentation about storage, a custom hashtag navigation used to nav to each paragraph but  scrolling is not working properly (it cannot fully scroll to headers of paragraph) when clicking each menu at nav bar.
But after PR #995 by @AhyoungRyu, custom hashtag nav can be changed into anchor.js style so I fixed nav for documentation to use this anchor feature to make it scroll properly.
What type of PR is it?
Bug Fix, Documentation
Todos

[x] - Merge with #995 after #995 has merged into master branch

How should this be tested?

Apply this patch
Build docs site using jekyll and browse localhost:4000
Click top nav -> Click "More" -> Click "Git storage", "S3 Storage", and so on.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I just tried #1004 and it scroll to expected position. Since #1004 is using a lot of anchor, would you mind to close this pr so we can reduce burden of changing every anchor that is used in #1004?

@minahlee No problem :)


Add back support for retries in storage uploads.

Was #3375

@tseaver @lukesneeringer Can I get a review here?


Addition of interface adapters for club logged in and refactoring

I added two new interface adapters for the remove member use case and the get members use case. Furthermore, I removed the Club Home interface adapter and refactored the code to work with the ClubLoggedIn package.
With this, I have finished all my interface adapters. I only have the Club Page and tests left.
The refactoring consisted of changing all lines of code that previously were related to ClubHome interface adapter classes to ClubLoggedIn interface adapter classes.
Let me know if anything is unclear. I would be glad to explain further!

The code follows the guidelines of Clean Architecture! The viewName of the ClubLoggedInViewModel and ClubHomeView should be changed to be more clear as to not conflict with the StudentHomeView.

Thanks for bringing up some valid problems. I just finished fixing all the small issues.

I am also concerned with entities existing in the interface adapter, but I'll ask my instructor later to see if it's okay.

Please check my comment on this matter above. I will wait until we get confirmation from a prof before changing. The main problem with not having entities is that we will lose A LOT of data, which is not preferable.


Camel-K maven security

I have Camel 1.11.0 and I am trying to use Maven with the settings-security.xml file.
I created a configmap with the settings.xml and security-settings.xml and configured the build.
apiVersion: v1
kind: ConfigMap
metadata:
  name: maven-settings
data:
   settings.xml: |
         ....
            <profiles>
                <profile>
                    <id>repos-public</id>
                    <repositories>
                        <repository>
                            <id>repo-public</id>
                            <url>https://nexus3.xxx.com/repository/maven-public</url>
                            <releases>
                                <enabled>true</enabled>
                            </releases>
                            <snapshots>
                                <enabled>true</enabled>
                            </snapshots>
                        </repository>
			...
			  <servers>
                <server>
                    <id>repo-public</id>
                    <username>user3</username>
                    <password>{wvv5ueoFlXoHcMpnk88WRekCyl5i1QHhvdzllcIAdUtShh1CPbMww/hyOcFTwm83}</password>
                </server>

Config-map with   maven-settings-security
apiVersion: v1
kind: ConfigMap
metadata:
  name: maven-settings-security
data:
   settings-security.xml: |
        <settingsSecurity>
          <master>{vLJwNrcWGhgH4pmN11IvBEtu6Pk9JGayWbyvQMv0j1FbvxbOqHB2V48tpBV43lmP}</master>
        </settingsSecurity>

Camel-k setting in integrationPlatform

  status:
    build:
      PublishStrategyOptions:
        KanikoPersistentVolumeClaim: camel-k
      buildStrategy: routine
      maven:
        cliOptions:
        - -V
        - --no-transfer-progress
        - -Dstyle.color=never
        localRepository: /tmp/artifacts/m2
        settings:
          configMapKeyRef:
            key: settings.xml
            name: maven-settings
        settingsSecurity:
          configMapKeyRef:
            key: settings-security.xml
            name: maven-settings-security

When I run the build, I get an error with ERROR
{"level":"info","ts":1672212215.0727262,"logger":"camel-k.builder","msg":"executing step","step":"github.com/apache/camel-k/pkg/builder/BuildQuarkusRunner","phase":"20","task":"builder"}
{"level":"info","ts":1672212215.074139,"logger":"camel-k.maven","msg":"executing: mvn -V --no-transfer-progress -Dstyle.color=never package -Dmaven.repo.local=/tmp/artifacts/m2 --global-settings /tmp/kit-celuttilksj796lodsag-1744468590/maven/settings.xml --settings /tmp/kit-celuttilksj796lodsag-1744468590/maven/user-settings.xml -Dmaven.artifact.threads=1 -T 1","MAVEN_OPTS":""}
{"level":"info","ts":1672212215.074187,"logger":"camel-k.maven.build","msg":"Executed command: /usr/bin/mvn -V --no-transfer-progress -Dstyle.color=never package -Dmaven.repo.local=/tmp/artifacts/m2 --global-settings /tmp/kit-celuttilksj796lodsag-1744468590/maven/settings.xml --settings /tmp/kit-celuttilksj796lodsag-1744468590/maven/user-settings.xml -Dmaven.artifact.threads=1 -T 1"}
{"level":"info","ts":1672212216.9216313,"logger":"camel-k.maven.build","msg":"Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)"}
{"level":"info","ts":1672212216.921708,"logger":"camel-k.maven.build","msg":"Maven home: /usr/share/maven"}
{"level":"info","ts":1672212216.9217167,"logger":"camel-k.maven.build","msg":"Java version: 11.0.16, vendor: Eclipse Adoptium, runtime: /opt/mandrel"}
{"level":"info","ts":1672212216.9217215,"logger":"camel-k.maven.build","msg":"Default locale: en_US, platform encoding: UTF-8"}
{"level":"info","ts":1672212216.9217246,"logger":"camel-k.maven.build","msg":"OS name: \"linux\", version: \"5.15.0-41-generic\", arch: \"amd64\", family: \"unix\""}
{"level":"info","ts":1672212219.2746494,"logger":"camel-k.maven.build","msg":"Scanning for projects..."}
{"level":"info","ts":1672212219.8636255,"logger":"camel-k.controller.build","msg":"Reconciling Build","request-namespace":"mk2","request-name":"kit-celuttilksj796lodsag"}
{"level":"debug","ts":1672212219.8636625,"logger":"camel-k","msg":"Operator is local to namespace"}
{"level":"info","ts":1672212219.8637774,"logger":"camel-k.controller.build","msg":"Invoking action monitor-routine","request-namespace":"mk2","request-name":"kit-celuttilksj796lodsag","api-version":"camel.apache.org/v1","kind":"Build","ns":"mk2","name":"kit-celuttilksj796lodsag"}
{"level":"error","ts":1672212226.9282494,"logger":"camel-k.maven.build","msg":"[ERROR] Some problems were encountered while processing the POMs:\n[ERROR] Non-resolvable import POM: Could not transfer artifact org.apache.camel.k:camel-k-runtime-bom:pom:1.16.0

And if I look at the file /tmp/artifacts/m2/org/apache/camel/k/camel-k-runtime-bom/1.16.0/camel-k-runtime-bom-1.16.0.pom.lastUpdated that it is trying to retrieve from Nexus, there is a  401 Unauthorized  error in it
"If I use the password without encryption in settings.xml , the build will pass."

It seems some problem with the encryption. According to the guideline in https://maven.apache.org/guides/mini/guide-encryption.html it even seems that your server password (encrypted) may be shorter. Can you double check the encryption procedure? Also, can you check that the very same configuration works locally outside Camel K?

Yes I checked my local encrypted password works in maven

It seems that the settings security are not taken in consideration then. I guess the configmap is in the same Integration namespace. The way it is implemented right now, it swallow any empty value, so we don't have a clear way to distinguish the reason why this is failing: https://github.com/apache/camel-k/blob/79fefb98cd2edd91805c94fc86c4663f1f2300c3/pkg/builder/project.go#L114
I'm marking as a bug, as, at least, we need some better message when the option is configured and no configmap/secrets are found.

Thx but It seems that the map is being loaded. I looked inside the container during the build and saw that a file called 'settings.xml' and settings-security.xml with an encrypted password was created in the '/tmp/kit-.... ' directory.

It seems that the settings security are not taken in consideration then. I guess the configmap is in the same Integration namespace. The way it is implemented right now, it swallow any empty value, so we don't have a clear way to distinguish the reason why this is failing:
https://github.com/apache/camel-k/blob/79fefb98cd2edd91805c94fc86c4663f1f2300c3/pkg/builder/project.go#L114
I'm marking as a bug, as, at least, we need some better message when the option is configured and no configmap/secrets are found.

I made some tests for the absence of configmap for maven-settings or maven-settings-security , the existing message looks good to me :
camel-k-operator-74b6fbf54b-g6lbj camel-k-operator {"level":"info","ts":1677757649.7288024,"logger":"camel-k.builder","msg":"step failed with error: ConfigMap \"maven-settings-security\" not found","step":"github.com/apache/camel-k/pkg/builder/GenerateProjectSettings","phase":"11","task":"builder"}

@milank78git : is the artifact org.apache.camel.k:camel-k-runtime-bom:pom:1.16.0 available in you nexus ? Can you download it from outside of camel-k with your settings configuration ?


Overcome warnings in generated Java source compilation units.

When the SBE tool is used to generate Java source, the resulting compilation units cause warnings such as:
The value of the field UpdateBatchDecoder.UpdatesDecoder.actingVersion is not used
The value of the field BondSymbolInfoDecoder.parentMessage is not used

While filtering can be used to ignore such warnings within an IDE, it is preferable to overcome the warnings in a manner that does not require end user intervention.
This PR adopts the simplest possible by solution by adding @SuppressWarnings("all") to the generated compilation units. Being a java.lang annotation, this requires no additional import. It has also been available since Java 1.5. While SuppressWarnings does not require a compiler to support the all warning name, compilers are required to ignore any warning names they do not recognise. Both OpenJDK and Eclipse recognise all.
The cleaner alternative to this PR would be to modify JavaGenerator to only generate the fields when required. I did not pursue this path given it would require more substantial changes to JavaGenerator and I thought a more lightweight change would be preferred. If not please feel free to let me know and I can submit a more comprehensive PR.

I'm ok with this. But would like @mjpt777 and @RichardWarburton to weigh in since they are using the Java codecs a lot right now.

I'm happy with it in principle.

I'm going to merge this patch, but I'm also going to file an issue to evaluate why the fields aren't actually used. We might be able to simplify the code generator and just not generate the dead code.


 Steps to reproduce:

Create sample blueprint which creates customer GW, VPN GW and VPN connection, like

node_templates:

 exists_vpc:
   type: cloudify.nodes.aws.ec2.Vpc
   properties:
     client_config: *aws_config
     use_external_resource: true
     resource_id: { get_input: aws_vpc_id}

 vpn_gateway_one:
    type: cloudify.nodes.aws.ec2.VPNGateway
    properties:
      resource_config:
        kwargs:
          Type: 'ipsec.1'
      client_config: *aws_config
    relationships:
      - type: cloudify.relationships.connected_to
        target: exists_vpc

 customer_gateway_one:
   type: cloudify.nodes.aws.ec2.CustomerGateway
   properties:
     resource_config:
       kwargs:
         Type: 'ipsec.1'
         PublicIp: { get_input: openstack_public_ip}
         BgpAsn: 65000
     client_config: *aws_config

 vpn_connection_vpc_requster:
   type: cloudify.nodes.aws.ec2.VPNConnection
   properties:
     client_config: *aws_config
   interfaces:
     cloudify.interfaces.lifecycle:
        create:
          inputs:
            resource_config:
              CustomerGatewayId: { get_attribute: [customer_gateway_one, aws_resource_id] }
              Type: 'ipsec.1'
              VpnGatewayId: { get_attribute: [vpn_gateway_one, aws_resource_id] }
              Options:
                StaticRoutesOnly: False
   relationships:
     - type: cloudify.relationships.depends_on
       target: vpn_gateway_one
     - type: cloudify.relationships.depends_on
       target: customer_gateway_one

Execute install/uninstall workflow several times, sample test is
 def test_blueprint(self, cfy_local):      cfy_local.execute('install', task_retries=1)      cfy_local.execute('uninstall', task_retries=1)      cfy_local.execute('install', task_retries=1)      cfy_local.execute('uninstall', task_retries=1)
Expected result: service installed->uninstalled->installed->uninstalled
Actual result: service installed->uninstalled-> Error
or
service installed->uninstalled->installed->Error

Fixed in #133


Fix gosimple issues

This commit fixes issues found with:
golangci-lint run --disable-all -E gosimple
Signed-off-by: Fred Rolland<EMAIL_ADDRESS>

See issue #288

@rollandf mind rebasing this PR ?

@rollandf mind rebasing this PR ?

Done


Add a missing inputFormat prop to update the value when format is changed

This PR closes #1568
Description
Add a missing inputFormat prop to update the value when format is changed

Thank you for your work, I am really sorry but this one is already fixed by #1661

Thank you for your work, I am really sorry but this one is already fixed by #1661

No problem, glad to help :) Mb you have some other bug/feature to contribute?

@dmtrKovalenko I think that we should favor solving individual issues when we can, so we can deliver individual chunk of values. Unless #1661 makes the fix proposed here outdated, I think that we should add a test case and accept it :).


CI fails when pull request contains double-quotes

When a pull request contains double-quotes in the title or in the description, the CI fails to run. No update form the CI is seen at all on the pull request, but a job is created on the jenkins server.
This appears to be due to the way the openshift-jenkins-plugin escapes characters in the environment variables passed into a job. The double quotes end up being escaped twice, creating unparse-able json:
..., "title": "This is a test PR with \\"double quotes\\"", ...

When it should end up like this:
..., "title": "This is a test PR with \"double quotes\"", ...

This issue can be worked around temporarily by removing the double-quotes from the PR title or description.

After some testing, it looks like this is due to how openshift escapes env variables in builds. Running the below buildConfig will result in an improperly-escaped json string in the PAYLOAD env variable:
{
  "kind": "BuildConfig",
  "apiVersion": "v1",
  "metadata": {
    "name": "json-test",
  },
  "spec": {
    "source": {
        "type": "Dockerfile",
        "dockerfile": "FROM centos:7\nRUN env"
    },
    "strategy": {
      "type": "Docker",
        "dockerStrategy": {
        "noCache": true,
        "env": [
            {
              "name": "PAYLOAD",
              "value": ""
            }
          ]
       }
    }
  }
}

oc start-build json-test -e PAYLOAD='{"test":"This is a test with \"double-quotes\" in the value"}'
oc logs -f bc/json-test
...
PAYLOAD={"test":"This is a test with \\"double quotes\\" in a json value"}
...

The problem has nothing to do with the jenkins plugin

Solved by https://github.com/openshift/openshift-tools/pull/2090


Automate creation of tickets for Dependabot reviews / merges

We should formalise / regularise the chore of staying up to date with Dependabot PRs
GitHub docs example of using a GHA with a cron schedule to automate issue creation with gh cli:
https://docs.github.com/en/actions/use-cases-and-examples/project-management/scheduling-issue-creation
We'll also want the -p flag to assign the project
gh issue create -p, --project <title>

I haven't yet found a way to assign a sprint, and having the script figure out which is the next sprint is potentially fragile.

This is WIP, the initial PR hasn't resulted in the workflow being triggered from new dependabot PR. This could be due to the branch thats been configured. I will continue with this on wednesday.

I have spoken with Jeremy regarding this and we have agreed at this stage to use a project workflow to pull in dependabot pr's based on the dependencies label. The approach of one issue per dependabot PR provides a more accurate picture of the number and effort involved.


Updated code example to get the most recently created node

Per the text above this example, the most recently created node is the one with the greatest NodeInstanceId property, so you can get it by just sort descending on this property and grabbing the first one.
The code that was provided split the name of the node to find the node with the highest number in its name, but this didn't work if you had more than 10 nodes because _node1_10 (for example) was treated as if it was numbered 1.

@markwragg : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@markwragg : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@athinanthny - Could you review the proposed changes and indicate whether the PR can be merged? Thanks.


Copy queue to player, not move

Add option in move queue diaog to just copy queue, and not move.

Closing. Asked on the forum for use case, none given. I can't see why you would want to copy the queue and not sync. Move makes sense, copy not so much.


Macro support for uncased

As the title says, macro support for uncased, since UncasedStr::new is const now.
Tests and examples matching the existing ones for Unicase are included.
I wrote this before noticing that #289 includes the same feature, and either will do, but I'm hoping a more focused PR has a better chance of getting merged.

I ended up running into the same issue with macro-caused groups as @thaliaarchi, so that slightly expands the scope of this PR as well.


Gallery: not clear it's a preview for first-time user

When first-time users install and open the app, it's not clear we're a preview. Deep in the About Flutter, we say we're a "Q3 Preview", which is great, but too far into the app to correctly set expectations.
I like the wording "preview", as it hints at more awesome to come.
Can we fit the word preview into the title somehow, in the app bar? That would be the most obvious place, imo.
I'm happy to try a few options with my local copy, but open to ideas for how to indicate preview to users when they open the app.

Adding "(preview)" is too long for a Nexus 5.
Options:

Gallery (preview) which isn't great because we miss the name Flutter
Flutter Gallery\n(preview) which isn't great because the minimized app bar can't handle two-line text
Use an image ?

Customer: fast adds a banner to their app to show it's using fake data.  I'm not sure we'd want to banner the app, but we could banner the Icon to say "beta" or "alpha"?  Donno.

Ribbon would be cool, too. I'd put it on the right, so it doesn't interfere with the hamburger icon.
@HansMuller your call, should we do a ribbon or add "(preview)" to the app bar title?

I tried making the a preview label that was aligned with the background. It's not good. A ribbon like the "slow mode" ribbon seems like a better idea.

Ribbon it is! :)
Though, bonus points for getting Preview in there all rotated.
On Fri, Aug 19, 2016 at 2:33 PM, Hans Muller<EMAIL_ADDRESS>wrote:

I tried making the a preview label that was aligned with the background.
It's not good. A ribbon like the "slow mode" ribbon seems like a better
idea.
[image: screenshot]
https://cloud.githubusercontent.com/assets/1377460/17824881/68f6e260-6619-11e6-8482-6269ae48bb13.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/5506#issuecomment-241140957,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAVZ7DnaFkJPmGAOIzfii90hXntcakJks5qhiEWgaJpZM4Jouf4
.

Assuming that this is OK, we'll need a way to configure the ribbon when the app is built.

Nice!
Curious, why would we configure this ribbon when the app is built? Wouldn't we leave it there until it's no longer preview? :)

Yes, you are correct. In checked mode, we'll still display the "slow mode" ribbon, otherwise we'll display "preview".

sgtm
Does the text scale to the screensize? That is, will the entire word "PREVIEW" show up on an iPod Touch, Nexus 5, 5X, and 6P?
(happy to test, but maybe we know if it will/should scale?)

Thank you!


old versions of comments may get "stuck"

Haven't had an opportunity to investigate this as it just happened.
I edited a comment, and that worked as expected, but when the editing window went away i was left with the old version and the new version.
I suspect this is a problem with the code thinking a line is there that isn't anymore or something. Turning PC off and on didn't have an effect.  Turning the PC server off an on also didn't have an effect.
🤔 I think it might be useful to enable a "debug mode" in the server that'd spit out all the request data it got...maybe a "logging mode"
The screenshot's kinda 💩because it's a work codebase. Sorry future me (or whoever).

Closing this for now. I believe it was just a side-effect of Failing pre-commit hooks that snuck into the PC repo. That bug has now been fixed


Navbar and explore page styling

Hi all,
I used the new stylesheet provided by elaine and bryan to style the navbar and explore page, both of them are ready for use. I also created a little animation for the nav bar. Tomorrow i'll open a pull request into the main branch.

Style has been merged to main and pulled to everyone's local environments. Closing this issue now!


Scanline traits are all zeroes when monocots=True

The scanline-related traits return all zeroes. This only seems to happen when monocots=True so we should make sure the lateral roots are being included in scanline traits for dicots as well.

This issue was solved in PR #43:

In function count_scanline_intersections, use lateral_pts (main roots) for to calculate monocot traits
In function count_scanline_intersections, use all lateral roots to calculate scanline-related traits


testing ci

:tada: This PR is included in version 1.20.0 :tada:
Your semantic-release bot :package::rocket:


Add NewWithUserServiceKey API

This is a bit nicer than having to pass in intentionally fake creds to New and then modifying the API object.

Looks like the test failure is a Travis blip, the worker never started. Probably just needs someone to force a rebuild.

Forcing a rebuild fixed the Travis blip, but now it looks like golint is failing to install on 1.8.

Thanks for the PR. I have removed 1.8 as a test target. I believe it's old and unmaintained already, so no need to require it anymore.


Deploy to Vercel and enable DPS

Proposed Changes

Deploy the app to Azure Storage.
Fixes #69

Implementation

I implemented deployment flow to Azure Storage using GitHub Actions.

Sorry, Azure can't use managed TLS/SSL in root domain. So I thinking to use Vercel(Zeit).
I will update again, so you can't review this PR yet.

Added the following implementation for deploying to Vercel:

Deployment flow to GitHub Actions.
Add .now to .gitignore.
Add .nowignore.
Configuration file now.json for Vercel.

Added the following implementation for using yarn workspaces with Vercel:

Add next-transpile-modules to resolve local packages.
Add electron to resolve dependency-errors. (I wanna remove it because I don't need it)
Change .babelrc to babel.config.js (see here)

But, the deployments are failing because it exceeds the size-limit of Vercel. 🤔

The @now/next build is very challenging, so I've switched to the @now/static build.
CI error has nothing to do with the build, but I'll fix it.

This pull request is being automatically deployed with now-deployment
Built with commit d2b1372990fdc1060c95abcb8c58273d014ff93f
✅ Preview: https://stakes-social-n16qk6jfm.now.sh

This PR's review is ready! Please :) @abyssparanoia

Can be deployed to Vercel with zero-config and better integration, by adding next to the route package.json.
When 'serverless' as the target in next.config.js, the dependency of Web3 was issuing an error. So I added electron to it.


Table search

Added table search functionailty similar to schema
Behavior:
If the parent table or one of its part tables matches the search condition, the parent table is display along with its parts.

Depends on #86

^ Will wait for that to merge before requesting review

Also updated change logs to match convention

Before search

After typing some stuff:


If handler path not implemented/wrong path , it will throw the 404 error code instead of 400.

API 30 -If handler path not implemented or wrong path , it will throw the 404 error code instead of 400.

The #361 has been merged. Close this issue.

 If handler path not implemented/wrong path , it will throw the 404 error code instead of 400


Developing Machine learning models for GOLD PRICE PREDICTION

@Akshat111111  Hey 👋 , I have checked the Gold price prediction Code that was trained over linear regression model in your code base.
I have some better solutions where we can use XG boost and Gradient Boosting Algorithms etc inorder to produce precise results as price prediction is a sensitive task.
My approach : First I would be doing Proper EDA  over the I would be using and then i would be using Different Machine learning models and train them over different hyperparameters to obtain the best results , i would also provide the performance analysis and a proper conclusion of the performance.
I'm a Machine learning and Deep learning dev and have been constantly contributing , Can you please assign me this Issue with a GSSoC '24 contribution tag with appropriate level tag as it requires alot of efforts

@Akshat111111  Hey bro 👋 , Can you please check this out

I like your aproach.You can start working on it.

I have reviewed the Gold price prediction code that utilizes a linear regression model. Given the sensitivity of price prediction, I believe we can achieve more precise results by employing advanced techniques such as XGBoost and Gradient Boosting Algorithms.
My approach includes:
Conducting thorough Exploratory Data Analysis (EDA).
Implementing and training multiple machine learning models with various hyperparameters.
Providing detailed performance analysis and a comprehensive conclusion of the results.

I have reviewed the Gold price prediction code that utilizes a linear regression model. Given the sensitivity of price prediction, I believe we can achieve more precise results by employing advanced techniques such as XGBoost and Gradient Boosting Algorithms.
My approach includes:
Conducting thorough Exploratory Data Analysis (EDA). Implementing and training multiple machine learning models with various hyperparameters. Providing detailed performance analysis and a comprehensive conclusion of the results.

create a new issue mentioning it and start working.

@ajoshi30 dont repeat the same work, add some value by your work.

yeah, sure
On Fri, 17 May 2024 at 20:26, Akshat Sharma @.***>
wrote:

@ajoshi30 https://github.com/ajoshi30 dont repeat the same work, add
some value by your work.
—
Reply to this email directly, view it on GitHub
https://github.com/Akshat111111/Hedging-of-Financial-Derivatives/issues/82#issuecomment-2117788176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7O7NG5EXBQFIQU4HWRGXY3ZCYLBXAVCNFSM6AAAAABHURCK5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXG44DQMJXGY
.
You are receiving this because you were mentioned.Message ID:
@.***
.com>


⚠ Bofrost.lu has degraded performance

In 3bb63e7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2547 ms

Resolved: Bofrost.lu performance has improved in 09c7abe after 9 minutes.


(websocket) pass the origin request to the protocol_class

Pass the origin request to the protocol_class, then it can be visit via websocket.request
The code style.

Coverage decreased (-0.6%) to 86.78% when pulling e00725e74ef8bbb160fdf67f30c2789d0031da34 on RyanKung:master into db43f74d9e8fc8f0216ff3e545a7b31b2e592b8e on quantmind:master.

'WsgiRequest' object has no attribute 'version'

???

We can't do that.
The request is an object while the protocol_class is a class and must work for all requests not just one. The original wsgi request is available as the handshake property in a websocket protocol object.
Check
https://github.com/RyanKung/pulsar/blob/master/pulsar/apps/ws/websocket.py#L151
and
https://github.com/RyanKung/pulsar/blob/master/pulsar/apps/ws/websocket.py#L39

@lsbardel ok & thanks


Buff daggers and replace wildcard imports

(It could change the balance)
BM dagger (for self usege):

200 without debuff and 20 with the debuff (Soul Fray)

BMA - Glass Sacrificial Dagger (for self usege):

500 without debuff and 50 with the debuff (Soul Fray)
+ x2 blood for both with 10% (added)

BM dagger (for mobs):

calculate a value

BMA - Glass Dagger of Sacrifice (for mobs):
was: if some mobs value +100 else value =500 (villager +500)
now:

calculate a value and  if mob is "villager" value +500 (2500) else  value + 100 (added)
+ x5 blood for villager with 30% (added)
+ x5 blood for all except for the vanilla villagers with 20% (added)

added support for moon villagers and guardians
https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/15044
https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/15043

replaced all wildcard imports in the mod

Is Soul Fray not a debuff to prevent players from sacrifice to death and can cheat in as much blood they want.
Can you list the values before your changes?
I am not sure if this is balanced.

I didn't change the blood magic. I put it in the description to compare because there are 2 daggers each. One in blood magic and one in blood arsenal. In blood arsenal they are harder to make and should be better, I only changed them.

Previously in blood arsenal daggers with mobs were worse, since the author did not take into account the inhabitants and set the exact value of 500 blood except for 4 types of mobs. These 4 types of mobs gave more by 100 each, while villages gave thousands less (guard gave 3500 less blood and etc.).

But the dagger for self gave more and worked better. BM 200, BMA 500

ok but isnt there a list how much each mob gives? I rember i saw a list long time ago (config)

these values are taken from Blood magic, then I add 100 or multiply that value by 5

ok. guess it need to be discussed when feature freeze is over.

Why wait until after the freeze? It's not new content?

Why wait until after the freeze? It's not new content?

It's a rebalancing and there's always room for unforeseen bugs.

Looks good imo. Hopefully this helps with the pre-ritual mob spam a bit. I like the values.


adds Element.isVisible

16473

 Quality gate: NA
Details

 Quality gate: NA
Details

 Quality gate: NA
Details

 Quality gate: NA
Details

 Quality gate: NA
Details

 Quality gate: NA
Details


Building pyodide packages

This issue is to raise awareness of the fact that pyodide cannot currently build packages with meson.

pyodide issue, no detail
scikit-build issue, no detail
Attempt at building skimage

I spoke briefly to @henryiii, and it sounds like a cross build definition file is necessary. I'd like to gather more information on what is needed to support pyodide builds.

Thanks for this issue @stefanv. The scikit-image 0.20.0 build in the PR that is your third link above passes, with one minor patch that may not even be needed. I commented in https://github.com/pyodide/pyodide/pull/3874#issuecomment-1560708984.
Let's see if that patch can indeed be removed. The one other thing we can/should do is document how to use a cross file for Pyodide. There doesn't seem to be anything nonstandard there though, and meson cross file usage has good docs at https://mesonbuild.com/Cross-compilation.html.

This is excellent progress; thanks for your advice on the skimage build.


include directory to archive

is it possible to include a directory in the archive by 'include' property?

I hadn't tested it yet, but we use -r flag on cp, so it should work.
https://github.com/taiki-e/upload-rust-binary-action/blob/2ef6065015f8372403d76e6a1fb2f8094c5d6f18/main.sh#L206

Ok, thanks for your response.
I will try that


Class Feature issue

It is putting the already writted material in spaces it makes. an example is going from 4 pages, to 17. it posts the correct stuff, but keeps reposting all previous pages into spots in it. making multiple pages of the same content with a random class related line here and there.

Duplicate of #413.
We have a fix, but it hasn't been pushed live quite yet.


Design - Date input

Create design of date input
Meet with GC Forms team to get their feedback and user needs
Incorporate changes
Add guidance for usage

Summary: Design of the date input component.
Design on component branch and push to main Figma file when approved.
Acceptance Criteria:

[x] Component Kickoff
[x] Sync with Dev and Design
[x] Research and consulting other design libraries
[x] WCAG Goal can be completed using a screen reader.
[x] WCAG Visual elements observe color contrast requirements.
[x] WCAG Manual accessibility testing meets WCAG 2.1 AA requirements.
[x] Provides equal service in French and English.
[x] Sync with Dev and Design
[x] Comparison with official policy, documented reasons for deviation if any
[x] Design review
[x] Policy review
[x] Design - Different screen sizes
[x] Design - Short content / long content (text overflow etc.)
[x] Design - Error state (if applicable)
[x] Design - Empty state (if applicable)
[x] Component anatomy
[x] Write draft of design guidance
[x] Handoff from draft dev guidance to documentation author/lead
[x] Update Figma version

Did date input content design review and worked with @EliseKa on the anatomy, labels, hint text, error states


OAuthSwiftError error -10 With Twitter

Description: I am attempting to connect to Twitter via OAuth1 and I am getting an error saying "The operation couldn’t be completed. (OAuthSwiftError error -10.)". It seems that I am getting caught in the error handler of the authorize method. My code seems to match the examples so I am not sure what I am missing. Here is the code:
override func viewDidLoad() {
        super.viewDidLoad()

        print("BEFORE OAUTHSWIFT")
        let oauthswift = OAuth1Swift(
            consumerKey:    CONSUMER_KEY,
            consumerSecret: CONSUMER_SECRET,
            requestTokenUrl: "https://api.twitter.com/oauth/request_token",
            authorizeUrl:    "https://api.twitter.com/oauth/authorize",
            accessTokenUrl:  "https://api.twitter.com/oauth/access_token"
        )
        print("AFTER OAUTHSWIFT")
        let _ = oauthswift.authorize(
            withCallbackURL: URL(string: "http://codepath.com")!,
            success: { credential, response, parameters in
                print(credential.oauthToken)
                print(credential.oauthTokenSecret)
                print(parameters["user_id"]!)
                // Do your request
        },
            failure: { error in
                print(error.localizedDescription)
                print("ERROR")
        }
        )
        // Do any additional setup after loading the view, typically from a nib.
    }

OAuth Provider (Twitter, Github, ..): Twitter
OAuth Version:

[ x] Version 1
[ ] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[ ] CocoaPods
[ x] Manually

Library version:

[ ] head
[ x] v1.2 (Swift 4.0)
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[ x] 9.0 (Swift 4.0)

[ ] 9.0 (Swift 3.2)

[ ] 8.x (Swift 3.x)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other: (Please fill in the version you are using.)

[ ] objective c

let _ =
This is the error...

I changed it to this and I get the same result:
let handle = oauthswift.authorize(
            withCallbackURL: URL(string: "http://codepath.com")!,
            success: { credential, response, parameters in
                print(credential.oauthToken)
                print(credential.oauthTokenSecret)
                print(parameters["user_id"]!)
                // Do your request
        },
            failure: { error in
                print(error.localizedDescription)
                print("ERROR")
        }
        )

And Xcode say nothing?
That’s an error too
The object must be retain in memory, like an attribute of the class
Alternatively you can put oauthswift object as class attribute
This is an asynchronous code with no strong reference, to allow to free memory

XCode does generate a warning of "Intialization of immutable value 'handle'..." when i use let handle = . I was using the code from the sample. Changed the code to this and it worked. Thanks!
    override func viewDidLoad() {
        super.viewDidLoad()
        var oauthswift: OAuth1Swift!
        var handle: OAuthSwiftRequestHandle!

        print("BEFORE OAUTHSWIFT")
        oauthswift = OAuth1Swift(
            consumerKey:    CONSUMER_KEY,
            consumerSecret: CONSUMER_SECRET,
            requestTokenUrl: "https://api.twitter.com/oauth/request_token",
            authorizeUrl:    "https://api.twitter.com/oauth/authorize",
            accessTokenUrl:  "https://api.twitter.com/oauth/access_token"
        )
        print("AFTER OAUTHSWIFT")
        handle = oauthswift.authorize(
            withCallbackURL: URL(string: "http://codepath.com")!,
            success: { credential, response, parameters in
                print(credential.oauthToken)
                print(credential.oauthTokenSecret)
                print(parameters["user_id"]!)
                // Do your request
        },
            failure: { error in
                print(error.localizedDescription)
                print(handle)
        }
        )
        // Do any additional setup after loading the view, typically from a nib.
    }

Do not use “!”
Bad practice
Use swiftlint to see all bad practice when coding in swift
I expect that the “var” are in class scope and not viewDidLoad scope
Or you will have same issue one day


Updated download link to latest decK version

Very outdated link to 0.4 before - changed to 1.1.0
Please automate that it is always the latest link!

@svenwal this page is going away very soon (hopefully by the end of the week) and is getting replaced with a full decK doc set (migrated from Harry's repo). The version is correct on that new page, but good call on automating.


ResultStream raises a generic HTTPError

After reviewing result_stream.py I noticed that the retry decorator raises an HTTPError with no context surrounding the actual HTTP code encountered. See below:
`
def retry(func):
"""
Decorator to handle API retries and exceptions. Defaults to three retries.
Args:
    func (function): function for decoration

Returns:
    decorated function

"""
def retried_func(*args, **kwargs):
    max_tries = 3
    tries = 0
    while True:
        try:
            resp = func(*args, **kwargs)

        except requests.exceptions.ConnectionError as exc:
            exc.msg = "Connection error for session; exiting"
            raise exc

        except requests.exceptions.HTTPError as exc:
            exc.msg = "HTTP error for session; exiting"
            raise exc

        if resp.status_code != 200 and tries < max_tries:
            logger.warning("retrying request; current status code: {}"
                           .format(resp.status_code))
            tries += 1
            # mini exponential backoff here.
            time.sleep(tries ** 2)
            continue

        break

    if resp.status_code != 200:
        error_message = resp.json()["error"]["message"]
        logger.error("HTTP Error code: {}: {}".format(resp.status_code, error_message))
        logger.error("Rule payload: {}".format(kwargs["rule_payload"]))
        raise requests.exceptions.HTTPError

    return resp

return retried_func

`
Retry section of this page https://developer.twitter.com/en/docs/tweets/search/overview/enterprise.html indicates a throttling of requests when encountering a 503.  Also I'd like to be able to respond accordingly / log other HTTP error codes as well.  Are there any plans to address this or can I open a PR to do so?

Hi @alex-p-fisher, thanks for opening the issue. Let me know if I'm understanding your questions correctly - it sounds like:

you'd like to see the specific codes for non-200 HTTP responses
you'd like conditional logic to handle the situation where non-200 responses arise and only raise the HTTPError

For 1., I believe the specific non-200 error code should be logged from the snippet you posted (logger.error("HTTP Error code: ...) before raising the exception. Are you seeing those logs wherever your code is running?
For 2., I don't believe there are currently plans to implement this logic, but you are welcome to open a PR with some examples of the behavior you're seeking.
Let me know if I'm misunderstanding your questions!

Hello @jrmontag, thanks for getting back to me,
For 1., Yes the error is being logged as expected which is helpful but I need to be able to get the HTTP status code / message at run-time to respond accordingly in my application.
ie. raise an http error containing this contextual information when status_code != 200.
For2., I'd be happy to put in a pull request with the behavior I'm requesting.
Thanks,
Alex

@alex-p-fisher - We'd welcome a PR! Thank you!

I would like to open a pull request for this issue as well as an improvement if possible.  How do I acquire permissions to do so?

FWIW, this library was recently updated to better handle retries. It now makes a distinction between errors that are a "one and done" (e.g. authentication errors), and errors that are retriable (e.g. 503s and 429s). When retrying those it now implements a backoff mechanism and is not limited to 3 retries.


Update bindings for new libROM version

This updates the pylibROM bindings to be compatible with the current version of libROM (up to commit b229933).

Work in progress?


Request: Add a search bar to the documentation site.

https://www.make.md/docs/
It would really help with looking stuff up about the plugin.

Will add this, thanks for the feedback!

How has this been going?


Obsidian Sync results in duplicate notes when switching between systems

For Sync users, if you are on mobile and create a note via this plugin and update the title, say
1 - Did the thing
Then opened your vault on Desktop with Sync and this plugin enabled, a new note with just 1 -  would be created. You'd have duplicate days for 1 -

Fixed in https://github.com/Ebonsignori/obsidian-auto-journal/commit/e84c76acca00c69156fae15b15ebb31931017e58


resizing  width height NaN

@resizing="onResize"
宽高拿不到

调用组件的代码怎么写的

Maybe it is due to the naming of your resizeStop listener.

Maybe it is due to the naming of your resizeStop listener.

Maybe not. This breakpoint is not be entered if it is a listener naming issue.
It seems like some internal calculation issues for width and height.
Quite similar to #397


Add SSID information as a device sensor to help monitoring

Is your feature request related to a problem? Please describe.
To help in the task to monitoring devices and entities, it would be great to know which SSID the device is connected.
Describe the solution you'd like
I have only LG's HVAC appliances, so my experience is limited only to this device class.
It would be nice to have a sensor with SSID information. In a installation with many different SSIDs (like mine), knowing which HVAC is connect to which SSID (without entering LG Thinq App) one can monitor and take actions based on this information.
If possible or provided by Thinq a great sensor is "BSSID" mac address information too.
Describe alternatives you've considered
If a sensor is not possible / planned an alternative is to add an attribute to the entity.
Additional context
Many integrations have this kind of functionality. I can list some - OpenBEKEN devices (switches, bulbs, power plugs etc) with MQTT integration and Tasmota integration. I guess that ESPHome provides these data too.

This new sensor is available in last release

@ollo69 thanks a lot! It will be of great value! I will test ASAP.


Store web api token itself in localStorage

Currently it's only storing 'access_token' property in localStorage, store the whole object, so you can use expires on.

localStorage only keeps string data. By using angular.fromJson & toJson functions, it was possible to convert 'token' object in localStorage and read it back.


Reparenting files via the file navigator isn't working anymore

Problem
Trying to reparent code files in the file navigator appears broken
Repro

Grab storyboard.js and try to move it from the utopia folder to the src folder.

Observed: no drop target highlights, dropping it on src doesn't do anything
Expected: drop target highlights work, and dropping it results in a reparent.
NB we seem to have the same problem for file uploads, something about our favourite D&D library is flaky here

Drag and drop issues in this card:

it is possible to drag folder into child folder
drop target can only be directory, on files nearest ancestor folder should be shown
uploaded assets should be shown with an extra tag after the filename (this was already there long ago)
S3


Types incorrect or problem with webpack.

invert is not a function. This happens no matter how I import:
import invert from "invert-color" -> Runtime error: invert_color_1.default is not a function
import { invert } from "invert-color" -> Runtime error: invert_color_1.invert is not a function
import * as invert from "invert-color" -> Compiletime error: Cannot invoke an expression whose type lacks a call signature. Type 'typeof import("D:/.../node_modules/invert-color/lib/invert")' has no compatible call signatures.
import invert = require("invert-color") -> Compiletime error: Cannot invoke an expression whose type lacks a call signature. Type 'typeof import("D:/.../node_modules/invert-color/lib/invert")' has no compatible call signatures.
for it only works when use as  (invert as any)(rgbArray) and I either import as
import * as invert from 'invert-color'
or
import invert = require('invert-color')
I'm using this with webpack in the browser.

Thanks. It's strange that no one has reported this before.
Can you clone v2.0.0 and try with:
import invert from 'invert-color';

See updated readme.
I've removed dual export, now only using default export.
Built with rollup for UMD, CJS, ESM, etc..
Once you confirm, I'll release v2.0.0

I uninstalled the 1.5.0 version then installed the new one via
npm i --save https://github.com/onury/invert-color/tarball/master
After changing the code to import invert from 'invert-color'; as you instructed, I'm still getting no compile-time error, but getting the same runtime error of invert_color_1.default is not a function.
I am using the repository https://github.com/mobxjs/mobx-react-typescript-boilerplate as a base so perhaps something about the configuration of that repo isn't as it should be.

That's strange. I don't know about that repo but simple babel tests work ok.
It actually works for both versions 1.5.0 and 2.0.0.
Try this test for example: invert-test.zip
package.json
{
  "name": "invert-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "compile": "npx babel index.js --out-file index-compiled.js --sourceType module --presets=@babel/preset-env",
    "test": "npm run compile && node index-compiled.js"
  },
  "license": "ISC",
  "dependencies": {
    "invert-color": "onury/invert-color"
  },
  "devDependencies": {
    "@babel/cli": "^7.1.5",
    "@babel/core": "^7.1.5",
    "@babel/preset-env": "^7.1.5"
  }
}

index.js
import invert from 'invert-color';
console.log(invert('#000'), '—» works!');

then run npm i && npm test
So I think the issue is with your project or configurations..

Closing this now.
But I'd like to know what's causing your issue...

I think that this module isn't compatible with webpack+typescript. I updated the webpack versions of my repo (from 3 to 4) and switched from "awesome-ts-loader" to the standard "ts-loader", but I'm still getting the same issue.


/delta G scorer code

How can I singly run the /delta G scorer code? or where is it? (If I can extract it)

We have provided two methods to score ddG instead of dG. One is through an end-to-end deep neural network, the codes of which is here and depend on the modules here. Another one uses foldx to predict dG of the wild type and the mutant, and calculate the difference as ddG. The codes for using foldx is here, but you need to first download the executable binary of foldx from its (official website)[https://foldxsuite.crg.eu/products#foldx]. Also, it is recommended to first use openmm to relax the structure, and then use foldx to optimize the structural energy.

Thanks for your patient reply!


/visit with Rooms url

What
This PR has changes for /visit to work with rooms url
Url: /visit?roomId=roomId&userId=participantId
Why

How Tested
UTs added

Locally tested:
Create room using api
Get the roomId and participantId from the create room api, and use them to form the /visit url

After joining call:

Reason for updating snapshots: after updating the calling sdk, e2e's are failing with a small pixel diff
Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Does this PR contain ARM Template changes?

[ ] I have verified deploying using the ARM Template
[ ] I have tested the deployed app end to end

Is this a breaking change?

[ ] This change causes current functionality to break.

Not sure if this is new or existing error but I see this while running locally -

Other than that changes looks good, and worked well while testing locally..

Hey tejaswi.. While testing after deploying I do see that an error gets thrown and the lobby is not loaded for presenter and attndee. Lets hold on merge. SS shared separately

We dont have lobby experience for rooms

Hey tejaswi.. While testing after deploying I do see that an error gets thrown and the lobby is not loaded for presenter and attndee. Lets hold on merge. SS shared separately

We dont have lobby experience for rooms

Sorry I meant device config / start call button screen. my bad.. sent ss on the  PR channel


UP updates to referral guide page

Problem statement
The UP change communication strategy IDed changes needed to the referral guide page. Specifically, how we encourage STLTs to refer senders is affected by an adjustment in our pace of onboarding senders compared to pre-UP migration.
What you need to know

...

Acceptance criteria

[x] Page updates drafted, reviewed, and approved by content owner
[ ] Next step planned (Content handed off to eng or design as necessary)

To do

[ ] ...

@chris-kuryak @jillian-hammer FYI

Doc complete and approved. Ready for eng ticket @chris-kuryak

#12970 is follow-on ticket


Expose the rules filesystem for offline rule validation

Today there is no practical way to validate the rules before the extension is loaded. The seclang parser package in Coraza is internal, but using it directly is not enough to properly validate a set of rules. Access to the rule filesystem is needed to validate that Include directives do not point to unexisting files.
Validating rules beforehand is IMO an important UX topic. Without it, invalid rules would cause the extension to error and not load, and that will only happen at runtime, leaving just some traces in the proxy logs. users may not notice and assume their WAF is running while it's not.
This PR exposes the rules FS so coraza can be loaded as a library with this filesystem, in order to do proper rule validation.
Note that the fs.go has been moved to the rules package since package main is not importable in Go.

It is a pity I did not include unit tests for the rules FS. We should add them at some point.

let me add some tests that exercise the offline validation path. I'll add a commit with that before merging.

Done. @jcchavezs PTAL

Would be good not to merge public API change with just one approval :)
Thinking more on this, I think it has a couple of issues

Only works with Go. This is a wasm project and there shouldn't be functionality gated by language

It seems like a coincidence, or otherwise a bit fragile, to ensure the version used by the validator is the same version as the wasm binary being loaded.

Instead of this it seems like it could be better adding a wasm export that accepts rules string and validates it. A go host, instead of importing directly, would use wazero to call the validate function, and different hosts like JS could do it too.
@nacx would that be feasible?

Would be good not to merge public API change with just one approval :)

Totally. I felt this change wasn't harmful and still aliases are part of the public API already. Still my bad.

Only works with Go. This is a wasm project and there shouldn't be functionality gated by language

True, so it is the parser so we are constrained in that sense. If we truly want to provide a parser (which I think we should) we need to build another artifact and that be loaded with a VM (not sure all languages have this ability)

It seems like a coincidence, or otherwise a bit fragile, to ensure the version used by the validator is the same version as the wasm binary being loaded.

Yes but notice parser entirely depends on coraza and not coraza-proxy-wasm and that would control the versioning as we are talking about public APis in both sides.

Instead of this it seems like it could be better adding a wasm export that accepts rules string and validates it. A go host, instead of importing directly, would use wazero to call the validate function, and different hosts like JS could do it too.

This sounds good. I have this working already https://github.com/jcchavezs/seclang-validator, we just need to pass the FS and publish the wasm artifact. We can easily port that code here cc @nacx

I realized we already have code that validates configs in tests, a Go host would be able to do something very similar.
https://github.com/corazawaf/coraza-proxy-wasm/blob/main/main_test.go#L446
@jcchavezs For your other points, I don't mean a separate artifact. What we want to do is verify a config can be loaded by a coraza-proxy-wasm binary. I think it's most clear if that binary is what is doing the validation instead of sidestepping by using go code that looks like it but isn't wasm. One big issue that came to mind is include directives aren't the only source of config errors - and we can imagine making tweaks based on tinygo build tags that may cause different types of validation failure but can't be reproduced in Go. The robust way to validate a config requires calling the wasm I think, but that can happen before e.g. saving to k8s using a wasm host like wazero.

I realized we already have code that validates configs in tests, a Go host would be able to do something very similar.
https://github.com/corazawaf/coraza-proxy-wasm/blob/main/main_test.go#L446
@jcchavezs For your other points, I don't mean a separate artifact. What we want to do is verify a config can be loaded by a coraza-proxy-wasm binary. I think it's most clear if that binary is what is doing the validation instead of sidestepping by using go code that looks like it but isn't wasm. One big issue that came to mind is include directives aren't the only source of config errors - and we can imagine making tweaks based on tinygo build tags that may cause different types of validation failure but can't be reproduced in Go. The robust way to validate a config requires calling the wasm I think, but that can happen before e.g. saving to k8s using a wasm host like wazero.

@anuraaga as weird as it sounds I had exactly the same thought not so long ago. Not sure why I forgot it but yeah, anyone can verify a config works by bootstrapping the extension and verifying the the start succeeded. I am inclined to rever this PR cc @nacx


iOS is problematic, but this should be decent.

Best I can do.  I'm going to look at Bluetrace and maybe I'll get more ideas.

@acooley is this still actual? Will you work on resolving conflicts?

It's still needed.  I will resolve conflicts.


Bug: tf.dynamic_partition appears to produce bad outputs on GPU (0s appended) (TF 1.5/1.6)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16
TensorFlow installed from (source or binary): Pip installed 1.5 and 1.6rc0
TensorFlow version (use command below): 1.5 and 1.6rc0
Python version: 3.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: 9
GPU model and memory: nvidia k80
Exact command to reproduce:

import tensorflow as tf
import numpy as np
x  = tf.constant(np.random.randn(3072))
inds = [0]*189 + [1]*184 + [2]*184 + [3]*191 + [4]*192 + [5]*195 + [6]*195 + [7]*195 + [8]*188 + [9]*195 + [10]*188 + [11]*202 + [12]*194 + [13]*194 + [14]*194 + [15]*192
assert(len(inds) == 3072)
partitioned = tf.dynamic_partition(x, inds, 16)
sess = tf.InteractiveSession()
res = sess.run(partitioned)
print(res[-1].shape) # This should be (192,) but is (198,)

Describe the problem
There appears to be a bug with tf.dynamic_partition. When I run the above commands, I see that there are some extra 0s appended to the final partitioned value, and its shape is incorrect - I'm not sure why.
I checked that this problem does not appear to occur with Tensorflow 1.4, but does occur with Tensorflow 1.5/1.6rc0 on their GPU versions. It does NOT appear to have any issue in the CPU version of Tensorflow 1.5/1.6rc0. I was able to reproduce the error on two separate computers with GPUs.
This might be related to https://github.com/tensorflow/tensorflow/issues/16872.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

Thanks for the report.
The GPU kernel for dynamic partition was introduced in TensorFlow 1.5 via #13905 - seems like there is a bug. @codrut3 @ekelsen - mind taking a look?
(This problem isn't visible in TensorFlow 1.4 since it didn't have a GPU kernel for the DynamicPartition op and thus that would always execute on CPU. The CPU kernel is seemingly fine)

I've also run into a problem with dynamic partition for TensorFlow 1.5. I'll try to illustrate it as best as I can in code below.
padding_mask = tf.where(tf.not_equal(Zs, 0))
dxyzs = tf.expand_dims(xyzs, axis=2) - tf.expand_dims(xyzs, axis=1)
dxyzs = tf.gather_nd(dxyzs, padding_mask)
dist_tensor = tf.norm(dxyzs, axis=-1)
gauss = tf_gauss(dist_tensor, gauss_params)
harmonics = tf_spherical_harmonics(dxyzs, dist_tensor, l_max)
channel_scatter = tf.gather(tf.equal(tf.expand_dims(Zs, axis=-1), elements), padding_mask[:,0])
channel_scatter = tf.where(channel_scatter, tf.ones_like(channel_scatter)), tf.zeros_like(channel_scatter)))
channel_gauss = tf.expand_dims(gauss, axis=-2) * tf.expand_dims(channel_scatter, axis=-1)
channel_harmonics = tf.expand_dims(harmonics, axis=-2) * tf.expand_dims(channel_scatter, axis=-1)
embeds = tf.reshape(tf.einsum('ijkg,ijkl->ikgl', channel_gauss, channel_harmonics), [tf.shape(padding_mask)[0], -1])
partition_idx = tf.cast(tf.where(tf.equal(tf.expand_dims(tf.gather_nd(Zs, padding_mask), axis=-1), tf.expand_dims(elements, axis=0)))[:,1], tf.int32)
embeds = tf.dynamic_partition(embeds, partition_idx, num_elements)
mol_idx = tf.dynamic_partition(padding_mask, partition_idx, num_elements)

So dxyzs is gathered according to padding_mask on line 3 which gives them the same first dimension sizes. The rest of the code here preserves that same first dimension up through the einsum on line 11. Line 12 defines my partitioning indices for dynamic partition which is then used for both lines 12 and 13. So embeds and mol_idx should each be a list of tensors where every tensor in embeds has the same size first dimension as every corresponding tensor in mol_idx.
The issue is that the last tensor in embeds and mol_idx do not always (but sometimes do) have the same first dimension. This never occurs for me with any of the other tensors in each list. I haven't figured out whether or not the one with the wrong dimension size is from embeds or mol_idx (or both) for sure since these sizes will vary based on the batch, but I very strongly suspect it is from mol_idx based on typical sizes when the error does not occur. One possible cause may be the difference in dtypes. embeds contains tensors of either float32 or float64, and mol_idx contains tensors of int32. I haven't checked whether this occurs if mol_idx is int64 yet.
The same problem does not happen in Tensorflow <=1.4, and putting the dynamic partition ops on the cpu manually does fix this issue for me. Hope this helps.

Hi @ankitvgupta @jeherr,
Thank you for reporting the bug(s)! I will look into it, but I am a bit busy right now and it might take me a couple days to figure out what is happening.

A fix to update CUB has been submitted internally and should sync to github shortly.
The 1.6 final release will contain this updated CUB version I believe, which will fix the problem.

@asimshankar Thanks so much! This is great news. Any estimate on when the final 1.6 release will be?

Nagging Assignee @ekelsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Update Centarro logo images

We'd like to update the Centarro images
Guides and Illustrator image attached.
centarro.zip
And png:

Ideally, we'd have 3 formats in SVG: white background, dark background, and just a square of the bull. Going to see if anyone on our team can help in that regard - if not, I can reach out to our designer as well.

Depending on the context, I think these would do the trick; the logo versions for a white background, logo negative for a dark background.

@bmartinez287 would you mind getting this added?


new UUID version added in #9077 breaks on Node < 14

Package Name: @azure/event-hubs
Package Version: 5.1.2+
Operating system: Linux/Windows
[x] nodejs

version: < 14

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
The "exports" configuration in UUID 8.x's package.json results in errors on Node < 14. The maintainer has expressed no interest in supporting older versions of Node that require different ESM configs.
https://github.com/uuidjs/uuid/issues/428#issuecomment-621711823
To Reproduce
Steps to reproduce the behavior:

Install the version of Node used in Azure: nvm install 12.14.0.
Use that version: nvm use 12.14.0
Create a new empty NPM project: mkdir poc && cd poc && npm init -f
Add @azure/event-hubs to your package.json: npm i @azure/event-hubs --save.
Edit your package.json to add "type": "module".
Import the default event hub export: echo import EventHub from \'@azure/event-hubs\' > index.js
Run node --experimental-modules index.js

You will see output similar to this:

$ node --experimental-modules index.js
(node:75868) ExperimentalWarning: The ESM module loader is experimental.
There was a fatal error setting up the server.
Error: Package exports for '\node_modules\uuid' do not define a valid '.' target
at resolveExportsTarget (internal/modules/cjs/loader.js:457:13)
at resolveExports (internal/modules/cjs/loader.js:390:16)
at Function.Module._findPath (internal/modules/cjs/loader.js:489:20)
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:784:27)
at Function.Module._load (internal/modules/cjs/loader.js:690:27)
at Module.require (internal/modules/cjs/loader.js:852:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (\node_modules@azure\event-hubs\dist\index.js:9:12)
at Module._compile (internal/modules/cjs/loader.js:959:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10) {
code: 'MODULE_NOT_FOUND'

If you downgrade @azure/event-hubs from "^5.1.2" to "5.1.0" and re-run index.js, it will work:

npm install<EMAIL_ADDRESS>--save
node --experimental-modules index.js

$ node --experimental-modules index.js
(node:80664) ExperimentalWarning: The ESM module loader is experimental.

Expected behavior
The uuid package consumed by @azure/event-hubs should be usable on the most recent version of Node supported by Azure (v12.14).
Additional context
Note that we need to run Node 12 with the --experimental-modules flag to get ESM support.
Clearly, this is not an issue with the code in your repository. However, upgrading from uuid v3 to v8 probably should have resulted in a minor version upgrade to @azure/event-hub's package.json instead of a patch upgrade. Because it was a patch upgrade, our deploys began to break on the next full npm install.
Other developers using @azure/event-hub on Azure NodeJS v12.14 will likely begin to see issues if they haven't already.

Thanks for reporting this issue.  We are able to reproduce it on Node 12.14.0 and 12.15.0, but it does not repro on 12.16.0 or higher.  Since --experimental-modules is an experimental feature, we cannot guarantee that our packages will work with this feature on all versions of Node.
When you say the latest version of Node supported by Azure is 12.14, are you referring to a specific service in Azure (like Azure App Service)?

Correct, Azure App Service. Here are the available NodeJS options:

Until a newer version of Node is available on Azure App Service, as a workaround you could use a container which allows you to choose your own Node version.
https://docs.microsoft.com/en-us/azure/javascript/tutorial-vscode-docker-node-01

Thanks @mikeharder, we'll look into that approach. For anyone who is stuck using an older version of Node, you will need to hard-code your package.json to version 5.1.0 of @azure/event-hubs in order to get the older version of the uuid package.

For anyone who is stuck using an older version of Node, you will need to hard-code your package.json to version 5.1.0 of @azure/event-hubs in order to get the older version of the uuid package.

First, this should only be an issue if you are using --experimental-modules, which is an experimental feature not recommended for use in production.  If you are not using --experimental-modules, then<EMAIL_ADDRESS>should work fine on older versions of Node 12.
Second, you should be able to use version 5.2.0 rather than 5.1.0, since 5.2.0 is the latest version which depends on<EMAIL_ADDRESS>https://unpkg.com/browse/<EMAIL_ADDRESS>


Add charset=utf-8 support in Accept header

Changes gives opportunity to return json response for each request with "application/json" in Accept header

This is already merged into master, so we can rebase the branch with latest master instead of doing two different commits


Grouping components in folders seems to break routing...

I have all my components in my components folder, but when i try to group them in sub folders, the whole app breaks. Not sure what I'm doing wrong here, though...

As you can see, I grouped all my view-1 content into a view-1 folder, then added that to the file path, but in the browser...

The files can no longer be found. This is odd, as this is standard behavior for vue app folder structure. The only thing that I noticed is different is the @ instead of a dot.
Any help on this issue will be much appreciated.
Thank you!

It should be @/components/view-1/xxx.vue instead.

Thank you Evan. Why do the imports work without the .vue extension in the template, however, as that behavior seems inconsistent.

oh, wait, i put them in the wrong order...holy doodle spanks! argh, sorry! 😤


Adds 'commonLibraries' method to CrossProject.

Proposing to add the method 'commonLibraries' to CrossProject.  This allows you to define libraries that should be on both the JVM and JS classpath.

Can one of the admins verify this patch?

The following existing feature already does what you're trying to achieve:
.settings(
  libraryDependencies += "org.example" %%% "awesome-lib" % "1.0.0"
)

So that works when you are inlining the dependency.  My projects, however, share an SBT plugin where I define all the common dependencies.  So I'll have an object like this:
object DependencyManagement {
  val scalatest = "org.scalatest" %% "scalatest" % "3.0.0-M7"
  val scalacheck = "org.scalacheck" %% "scalacheck" % "1.12.4"

  private val scalazVersion = "7.1.0"
  val scalazCore = "org.scalaz" %% "scalaz-core" % scalazVersion
}

And then in any downstream project, I can just use the named value scalatest to ensure all downstream projects are running the same versions.  This works great for JVM projects but not for SJS projects where the dependency is common among both JS and JVM projects.
I can't use the %%% method in DependencyManagement.

You can also use %%% in your DependencyManagement. You just have to surround your definitions with Def.setting { ... }. You'll find concrete examples on the mailing list of you search for that. I'm on mobile right now so it's a bit tedious for me to look it up.


[SQL-DS-CACHE-29][POAE7-920][WIP]add github action CI for ape-java module

What changes were proposed in this pull request?
add github action CI for ape-java module
How was this patch tested?
CI

LGTM.

+1


⚠ GitLab Server has degraded performance

In c78d9fc, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6876 ms

Resolved: GitLab Server performance has improved in 98bce61.


fix: Sanitize headers

Sanitize headers before using by removing new lines.

Released on https://github.com/yajra/laravel-sql-loader/releases/tag/v1.7.1, thanks!


BBT citekey in csl note stopped working

[x] I have verified that I am on the latest release of BBT (https://github.com/retorquere/zotero-better-bibtex/releases/latest) and Zotero
[x] I am posting a single question, bug or feature request
[x] I have included a descriptive subject of the problem
[x] I am available for follow-up questions and testing

First of all, thanks retorquere for this really helpfull extension
Bug classification
Since I do the main writing of texts in word (due it's good support for spelling and grammar checks) but want to include many math formula in my thesis, I've searched a way of easy tranfering text with a lot of citations from Word to LaTeX. I also want to use BibLaTeX to manage the bibliography.
After some digging in the BBT code I found the better-bibtex-citekeys.csl file and the hidden setting
extensions.zotero.translators.better-bibtex.citeprocNoteCitekey allowing me to (mis)use the Word integration with a custom csl file to actually write valid latex cite commands with the citekeys as provided by BBT.
With the last update of Zotero this way stopped working. When trying to update any references in the Word document (or updating the references in the word file) I keep getting an error message saying something went wrong and Error: Keymanager.get expects a number, got undefined.
Also the CSL Editor and CSL Preview stopped working for any selected item/csl.
I narrowed the problem down to BBT and further to the extensions.zotero.translators.better-bibtex.citeprocNoteCitekey being set to true, as all (expect to show the citekeys in word) work well when switched back to false.
I've recorded the debug output and attached it to this post
DebugOutput.zip.
If I am not mistaken, I think there is some problem with the monkey patch of the itemToCSLJSON function of Zotero.Utilities done in BetterBibTeX.ts:80.  As I understand this handles setting the BBT citekey as note for the CSL usage.
Is there any way to "quick" fix the problem?

:robot: this is your friendly neighborhood build bot announcing test build 5927 ("itemToCSLJSON has changed in 5.0.37").

Try 5927

With build 5927 using the citekey (as note field) in csl works again. Both Word integration and style editor/style preview show the expected result.
Thanks for the quick fix.

Thanks for the confirmation, new release should be out in a few minutes.


RPInitiatedLogoutRequest fixes

This patch relates to:

https://github.com/solid/oidc-op/issues/10#issuecomment-426233886
https://github.com/solid/oidc-op/issues/10#issuecomment-426602431
The fixes were needed to get RPInitiatedLogoutRequest working.

@cblakeley - can you explain a little more what this PR is trying to do? It's not clear from the comments to PR #10.

@dimitrizagidulin: Some explanation... I think there are two OIDC logout routines for Solid's OP:

logout v1: oidc-auth-manager --> host_api.js#logout --> LogoutRequest#handle
logout v2: oidc-op --> Provider#logout --> RPInitiatedLogoutRequest#handle

I gather logout v2 differs from logout v1 in basically one respect - it validates that any post_logout_redirect_uri, supplied by the RP with an RP-initiated logout request, was pre-registered with the OP. So logout v2 tightens up the OP's adherence to the OIDC spec. logout v1 doesn't check the supplied post_logout_redirect_uri.
At present, Solid uses logout v1, logout v2 isn't being used. This PR fixes logout v2 and https://github.com/solid/node-solid-server/pull/857 modifies Solid to use it. Without https://github.com/solid/node-solid-server/pull/857, /logout appears to bind directly to LogoutRequest#handle, so RPInitiatedLogoutRequest#handle wasn't being invoked.
A call to JWKSet.importKeys was needed to set cryptoKey, otherwise it wasn't set and validation of the id_token_hint failed.

@cblakeley Great work on all of this in general, I apologize for any confusion. :) This is one of the hardest subsystems we have in Solid, and it certainly doesn't help that the logic is divided into like a half dozen repos.

(still reviewing, stand by.)

Can this PR please be reviewed, so the fix can be finalized? OpenLink would like to get this revised RP-initiated logout code (which conforms more closely to the spec) into our OPL forks. Because the Solid team may change the implementation of this fix, we'd rather not merge the current implementation into our forks.
We'd prefer to hold off until the finalized version is committed to the master Solid repos first, but we've been waiting a while now. (Work on logout related issues started back in June - we'd like to get this whole logout issue finished).
Impact - OIDC clients will need to be modified to pre-register post_logout_redirect_uris. Any query string parameters currently included with the post_logout_redirect_uri may need to be encoded in the state parameter instead.

@kjetilk ,
Please note this item, which relates to your pending release.
/cc @RubenVerborgh @justinwb @dmitrizagidulin

@cblakeley Is there any way you can explain for non-OIDC-experts what this is doing? Something along the lines of "before this PR, xyz, after this PR, abc".
The difficulty is that we don't know what "RPInitiatedLogoutRequest fixes" precisely means. What is the issue being fixed? I get that https://github.com/solid/oidc-op/pull/11#issuecomment-429031969 is an explanation, but some basic things aren't answered for me. Why is logout route v2 needed? (How) is it better than v1? Should v1 be dropped?

@RubenVerborgh @dmitrizagidulin /cc @kidehen:
Before this PR:

RP initiated logout requests were handled by LogoutRequest#handle (logout v1)
logout v1 does the job (insofar as the RP session with the OP is destroyed) but it doesn't fully conform to the OIDC spec (https://openid.net/specs/openid-connect-session-1_0.html#RPLogout).

It doesn't require RPs to pre-register post-logout redirect URIs.
It doesn't validate any post_logout_redirect_uri supplied by the RP, by checking it was pre-registered.
The post_logout_redirect_uri could include arbitrary query string parameters (e.g. for maintaining state), whereas the spec only allows 3 specific parameters.

Dmitri addressed the above conformance issues by implementing RPInitiatedLogoutRequest#handle (logout v2), but I found problems with RPInitiatedLogoutRequest:

The new code wasn't being invoked - the route binding for /logout appeared to me to be still bound to logout v1, not logout v2.
Some other bugs in RPInitiatedLogoutRequest

After this PR:

logout v2 is bound to /logout and is invoked.
The bugs in the implementation are fixed.
The post logout redirect URI handling conforms to the spec.

The only query parameters allowed with the logout request are: post_logout_redirect_uri, id_token_hint and state.

Impact:
As mentioned previously above, OIDC clients will need to be modified to pre-register post_logout_redirect_uris as part of the OIDC RP registration. Any query string parameters currently included with the post_logout_redirect_uri may need to be encoded in the state parameter instead.
@dmitrizagidulin commented above that he thought some of my changes in this PR would need refactoring. I'm hoping the core Solid Team can address this.
HTH

Thanks a lot @cblakely, I indeed hope this is sufficient for the team.

👍 from me on this PR.


Automatic Package Publishing

Starting from today, it's possible to publish package automatically via GitHub actions, as announced here and documented here.
Do we want to enable that? Currently, I think @dshukertjr always has to merge the pr and manually publish the package locally.
There might be one issue though:

Pub.dev only allows automated publishing from GitHub Actions when the workflow is triggered by pushing a git tag to GitHub. Pub.dev rejects publishing from GitHub Actions triggered without a tag.

As you can't add a tag to a pull request, one still must add a tag manually? Or can this be automated as well for merges from the chore/publish branch? I'm not sure and just throwing some ideas here.

Wow, this is huge! Thanks for sharing this! We have been wanting this for a very long time. Let me test this thing out with a dummy package that I have and come up with a nice flow!


Auto-restore based on CWD

It loads sessions from other directories and it is very annoying. I created a keybind that loads the session aswell. This should use the sessions corresponding to the directory and not one big session file (I think that is what it does)
require('possession').setup {
	commands = {
		save = 'SSave',
		load = 'SLoad',
		delete = 'SDelete',
		list = 'SList',
	},
	autosave = {
		current = true,
		tmp = true,
		on_load = true,
		on_quit = true,
	},
}

Currently there is no auto-restoring of sessions per directory. I believe this is a duplicate of https://github.com/jedrzejboczar/possession.nvim/issues/3?

I did not come across that issue when searching. But it seems that the issue was never resolved

Yeah, this is yet on the TODO list. When I find some more time I might add this. Or if anyone want to give it a go then feel free. Some notes:

config option to enable this
config option to control restoring from parent dirs (should we load /a/b from /a/b/c)
config option to control if loading happens without confirmation or using vim.ui.input/vim.ui.select
should we also restore after DirChanged autocmd?

Implemented in https://github.com/jedrzejboczar/possession.nvim/pull/55.