Unable to mount additional volume under subPath

I'm running operator 2.1.1
mounting an additional volume fails with
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:75: mounting "/var/lib/kubelet/pods/010b52da-0eeb-46d0-9b52-8b0107890342/volumes/kubernetes.io~configmap/log4j2-properties" to rootfs at "/usr/share/opensearch/config/log4j2.properties" caused: mount through procfd: not a directory: unknown

configmap i want to mount
apiVersion: v1
kind: ConfigMap
metadata:
  name: log4j2-properties
  namespace: opensearch-dev
data:
  log4j2.properties: |-
    status = error

    appender.console.type = Console
    appender.console.name = console
    appender.console.layout.type = PatternLayout
    appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n

    rootLogger.level = info
    rootLogger.appenderRef.console.ref = console
    logger.token.name = com.amazon.dlic.auth.http.saml.Token
    logger.token.level = debug

opensearch.yaml file
apiVersion: opensearch.opster.io/v1
kind: OpenSearchCluster
metadata:
  name: opensearch-cluster
  namespace: opensearch-dev
spec:
  general:
    version: 2.4.0
    httpPort: 9200
    vendor: opensearch
    serviceName: opensearch-cluster
    additionalConfig:
      compatibility.override_main_response_version: "true"
    additionalVolumes:
      - name: log4j2-properties
        path: /usr/share/opensearch/config/log4j2.properties
        configMap:
          name: log4j2-properties
        restartPods: true
    keystore:
    - secret:
        name: email-notification
    pluginsList: []
  dashboards:
    version: 2.4.0
    enable: true
    tls:
      enable: true
      generate: true
    replicas: 1
    opensearchCredentialsSecret:
      name: opensearch-admin-user
    additionalConfig:
      opensearch_security.auth.multiple_auth_enabled: "true"
      opensearch_security.auth.type: |
        ["basicauth","saml"]
      server.xsrf.allowlist: |
        ["/_opendistro/_security/saml/acs/idpinitiated", "/_opendistro/_security/saml/acs", "/_opendistro/_security/saml/logout"]
      # Multi Tenancy
      opensearch.requestHeadersAllowlist: |
        ["securitytenant","Authorization"]
    resources:
      requests:
         memory: "1Gi"
         cpu: "100m"
      limits:
         memory: "1Gi"
         cpu: "500m"
  confMgmt:
    smartScaler: true
  security:
    config:
      securityConfigSecret:
       name: securityconfig-secret
      adminCredentialsSecret:
        name: opensearch-admin-user
    tls:
      transport:
        generate: true
      http:
        generate: true
  nodePools:
    - component: masters
      replicas: 3
      diskSize: "15Gi"
      nodeSelector:
      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
          - labelSelector:
              matchLabels:
                opster.io/opensearch-cluster: opensearch-cluster
                opster.io/opensearch-nodepool: masters
            topologyKey: kubernetes.io/hostname
      resources:
         requests:
            memory: "2Gi"
            cpu: "200m"
         limits:
            memory: "8Gi"
            cpu: "2"
      roles:
        - "cluster_manager"
        - "data"
        - "ingest"

the issue seems to be rekated to https://github.com/Opster/opensearch-k8s-operator/issues/218 and https://github.com/Opster/opensearch-k8s-operator/issues/279

as additional info..
if, as path i use path: /usr/share/opensearch/config/ instead of path: /usr/share/opensearch/config/log4j2.properties i get the following error
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:75: mounting "/var/lib/kubelet/pods/f1ef8cc1-5305-4f23-8c2f-56206c010a3d/volume-subpaths/keystore/opensearch/13" to rootfs at "/usr/share/opensearch/config/opensearch.keystore" caused: mount through procfd: not a directory: unknown

hi, would be really great to have this feature


[web] hot restart is not completely performed without hovering the mouse over the browser

Here is a video:
https://user-images.githubusercontent.com/46427323/143314098-2c5a7915-e1ac-435f-8eb7-fb85cf63f35a.mov
logs using flutter run --verbose:

before hovering the mouse:

[+13434 ms] Performing hot restart...
[   +3 ms] Skipping target: gen_localizations
[        ] Skipping target: gen_dart_plugin_registrant
[        ] Skipping target: _composite
[        ] complete
[   +6 ms] Scanned through 544 files in 6ms
[        ] Waiting for connection from debug service on Chrome...
[        ] <- recompile org-dartlang-app:/web_entrypoint.dart e1648ed4-783e-48e5-a86c-500c058e4c61
[        ] <- e1648ed4-783e-48e5-a86c-500c058e4c61
[  +11 ms] Waiting for connection from debug service on Chrome... (completed in 11ms)
[        ] Synced 0.0MB.
[        ] <- accept
[   +1 ms] DwdsVmClient: Attempting a hot restart
[        ] DwdsVmClient: Attempting to disable breakpoints and resume the isolate

after hovering the mouse:

[+21503 ms] DwdsVmClient: Successfully disabled breakpoints and resumed the isolate
[        ] DwdsVmClient: Attempting to get execution context ID.
[        ] DwdsVmClient: Got execution context ID.
[        ] DwdsVmClient: Issuing $dartHotRestart request.
[  +12 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: true
[  +18 ms] DwdsVmClient: $dartHotRestart request complete.
[        ] DwdsVmClient: Waiting for Isolate Start event.
[        ] DwdsVmClient: Successful hot restart
[        ] Performing hot restart... (completed in 21.6s)
[        ] Restarted application in 21,560ms.

Steps to Reproduce
In the video above, I was using go_router package -- repo link.

Clone the repo
Run any example (nested_nav.dart in my case)
Perform a hot restart.

Note: the behavior does not happen all the time so maybe you need to modify the file, save it and do a hot restart.

 `fluter doctor -v`

[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-x64, locale en)
    • Flutter version 2.5.3 at /Users/osaxma/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/osaxma/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.6 20G165 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

! Doctor found issues in 1 category.

Hi @osaxma, this issue is known and has been fixed in master.
The fix will be available on the stable channel in the future.
See https://github.com/flutter/flutter/issues/89874.
Closing as this has already been fixed.
Thank you


UnknownSelector returned for text

This is an "information" issue. I don't know what the right behavior is here, so just checking with you.
This stylesheet snippet
#content {
	/* Fixes old versions of FireFox */
	/* @noflip */
	body.rtl div.vectorMenu > div.menu,
	x:-moz-any-link {
		margin-left: 23px;
	}
}

Yields an UnknownSelector with text
"body.rtl div.vectorMenu > div.menu,\n\tx:-moz-any-link "
Is this expected?

Yes, the pseudo class -moz-any-link is unknown and therefore the whole selector is unknown.


Split Dataset Functionality

This PR is for #16394

Thanks for the PR! There's already a previously created PR for this feature, here https://github.com/keras-team/keras/pull/16398
Let's merge efforts into the previous PR! Please sync with the author.
Also, for future reference, do note that the current PR has some file formatting issues -- perhaps you're using a code autoformatter, which is creating issues.


Improve Arabic Normalizer

Pull Request
Current normalizer only remove tatweel, this commit add more normalization rules.

Remove all diacritics.
Normalize yeh.
Normalize alef.
Remove all tatweel.

Currently it's a draft until tests are added.
Related issue
Improve support for Arabic language: https://github.com/meilisearch/product/discussions/139

Arabic alphabet:ا,ب,ت,ث,ج,ح,خ,د,ذ,ر,ز,س,ش,ص,ض,ط,ظ,ع,غ,ف,ق,ك,ل,م,ن,ه,و,ي,ء
Arabic text should be normalized by:

removing the arabic Tatweel (ـ) characters.
normalizing the arabic Alef أ,إ,آ,ٱ to ا
normalizing the arabic Yeh ى to ي
removing the arabic diacritics: Fatḥah, Damma, Kasrah, Alif Khanjariyah, Maddah, Sukun, Tanwin, Shaddah
Arabic diacritics: َ, ُ, ِ, ٰ, ٓ, ْ, ۡ, ً, ٍ, ٌ, ّ,
Arabic alphabet
Arabic diacritics
Kashida

For normalizing Arabic char, I used match
fn normalize_arabic_char(c: char) -> Option<CharOrStr> {
    match c {
        'ـ' => None,
        'أ' | 'إ' | 'آ' | 'ٱ' => Some('ا'.into()),
        'ى' => Some('ي'.into()),
        'َ' | 'ُ' | 'ِ' | 'ٰ' | 'ٓ' | 'ْ' | 'ۡ' | 'ً' | 'ٍ' | 'ٌ' | 'ّ' => None,
        _ => Some(c.into()),
    }
}

To detect if char should be normalized, I also used match
fn is_shoud_normalize(c: char) -> bool {
    match c {
        'ـ' | 'أ' | 'إ' | 'آ' | 'ٱ' | 'ى' | 'َ' | 'ُ' | 'ِ' | 'ٰ' | 'ٓ' | 'ْ' | 'ۡ' | 'ً' | 'ٍ' | 'ٌ'
        | 'ّ' => true,
        _ => false,
    }
}

I am not sure how to do test function because I am not fully aware of these char_end, byte_end and char_map.
To test the function:

This: الْحُرُوف الْعَرَبِيَّة should be normalized to الحروف العربية
This: آليس should be normalized to اليس
This: إبرأهيم should be normalized to ابراهيم
This: يومى should be normalized to يومي

https://github.com/meilisearch/charabia/pull/204/commits/c0fbe24cdae943f36ac82d0bcbc6e1b8ce42dd4c
Adding support for arabic Taa Marbuta 'ة'
To test proper normalization:

This: النهاردة should be normalized to النهارده

Hello @DrAliRagab, I feel that the diacritics are already normalized by the nonspacing-marks normalizer.

Hello @DrAliRagab, I feel that the diacritics are already normalized by the nonspacing-marks normalizer.

Yes, It is.
Using nonspacing-marks is an awesome idea. I didn't know about it.
I think I should remove the diacritics from this Arabic normalization rules and keep only Alef, Yeh, Taa Marbuta and Tatweel

I hope it's ready for merge now


React-redux documentation: Fix links to Redux documentation

We're working through issues with switching docs systems right now. These should be able to remain the same, but we definitely need the domain switch. Hopefully we can revert the paths soon!


Need manpage for libnispor.h

The scripts/kernel-doc from kernel repo could help on this as I already use kernel document syntax in libnispor.h

Hello @cathay4t . Can I work on this? I am applying as an outreachy intern

@nandita11 Sure, assigned!

@nandita11 It has been a while, do you still have time and interest on fixing this issue?

Never mind. I missed the message. Unassigned.


Read columns values by rowid and convert to write columns.

I need to read column values and convert them to write columns.
Get rowids from a primary key column by primary-index, and then do plan_read_by_rssid.
After, read the corresponding segment file by rssid, and fetch value by rowids.

resolve #2267


add postgres db related classes

for https://github.com/hyperledger/firefly-transaction-manager/issues/21
Not yet ready for the final review

@ankit-gautam23 thanks for taking a look at the early stage. I'm still working on this PR so it's not ready for the final review. Feel free to take a look again when it's ready. I'll hide our comments as outdated to avoid confusion to the maintainers.

Codecov Report

Merging #76 (706feac) into main (710fe3a) will decrease coverage by 2.84%.
The diff coverage is 37.03%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   99.97%   97.13%   -2.84%
==========================================
  Files          61       63       +2
  Lines        3489     3627     +138
==========================================
+ Hits         3488     3523      +35
- Misses          1      104     +103

Impacted Files
Coverage Δ

internal/persistence/postgres/postgres.go
23.07% <23.07%> (ø)

pkg/fftm/manager.go
96.96% <66.66%> (-3.04%)
:arrow_down:

internal/confirmations/confirmations.go
100.00% <100.00%> (ø)

internal/events/eventstream.go
100.00% <100.00%> (ø)

internal/events/webhooks.go
100.00% <100.00%> (ø)

internal/events/websockets.go
100.00% <100.00%> (ø)

...nternal/persistence/leveldb/leveldb_persistence.go
100.00% <100.00%> (ø)

internal/persistence/postgres/config.go
100.00% <100.00%> (ø)

internal/tmconfig/tmconfig.go
100.00% <100.00%> (ø)

pkg/fftm/transaction_events_handler.go
100.00% <100.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

closing in favor of https://github.com/hyperledger/firefly-transaction-manager/pull/85


Bugfix 502 create configurable bin dir

There is one less file than with the other pull request because gen_vx_mask_wrapper.py and point2grid_wrapper.py didn't exist, but I also updated the version file.

Pytests ran successfully. Use case tests are being run on kiowa. Output from this version in /d1/personal/mccabe/use-case-output-3.0.3. Truth data in /d1/personal/mccabe/use-case-output-3.0.


Rename demo_lcd_800*480.py to demo_lcd_800x480.py

Symbol * is invalid for path or filenames in Windows family OS

Fixes #120


OAuth Providers 2FA Redirect

After OAuth login with Google, if user has 2fa enabled, it cannot redirect to a custom component. It automatically redirects to /tf-validate, which has dated UI design. Changing 'redirect_uri' does not fix this, or SECURITY_POST_OAUTH_LOGIN_VIEW, SECURITY_POST_LOGIN_VIEW. Standard login works fine and can be redirected.
After entering correct authentication code, there is an error "ValueError: No valid redirect URL found - configuration error". Note again this only occurs during the OAuth route, not standard login.

PLease reopen if still an issue and you have a reproducable test case.
Thanks!


chef-client raises an error on startup on Linux

chef-client -z x.rb raises an error due to the fact that it does require 'chef/resource/resource_notification' multiple times. There are no less than three Chefs in the omnibus, and it is loading the appbundled version first, and then 12.4.1. Since they are different files, Ruby does not protect us from double-loading. LOAD_PATH does not seem to change between them; it points at the appbundled version both times.

This is fixed by https://github.com/chef/appbundler/pull/18 and merged to omnibus in https://github.com/chef/omnibus-software/pull/484


Courses offered both half-terms

In catalog.py, the function get_half only returns 1 or 2 for whether it's first half or second half, but there are some courses that are offered in both. I would just fix the function itself but not sure whether it will cause issues later on.
Wait I may have spoken too soon, let me run a couple tests sorry.

it would return False for courses in both?

I meant courses that are a quarter length, but offered in both the first and the second half of the semester (offered twice in one semester). I believe this would return just 1 in that case. However, just looking at the subject listing, they technically use different course numbers for the course offered in the first vs in the second. I'm running a test now to make sure that's true for all of them, but my computer is very slow lol.

Confirmed that there aren't any courses currently. Sorry about that. It might be something to look into in the future though.


I'm often asked to log in again with GitHub

Yesterday I ran VS Code Insiders from the Downloads folder, and I used --user-data-dir. And today, after updating to latest Insiders I had to log in again. Here's what I noticed in one of the logs:
2022-12-22 19:42:40.951 [error] SyntaxError: Unexpected token y in JSON at position 0
    at JSON.parse (<anonymous>)
    at y.$getPassword (vscode-file://vscode-app/Users/alex/Downloads/Visual%20Studio%20Code%20-%20Insiders%202.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1564:41752)

I often also use vscode-bisect which downloads various versions of VS Code Insiders and uses a custom user data dir. Often I end up being signed out 🤷 .
cc @bpasero

I have seen this error before and I had a time when I had to log in all the time, but not for a while anymore.

Now again I hit this almost daily that I have to re-login.

After 1on1, learned that this is caused simply by launching VS Code from a different path. A suggested fix is to not destroy existing credentials on startup when we fail to decrypt but only do so when we actually need to write new credentials to the store.

After 1on1, learned that this is caused simply by launching VS Code from a different path. A suggested fix is to not destroy existing credentials on startup when we fail to decrypt but only do so when we actually need to write new credentials to the store.

What are some verif steps? I'm a little confused on what you mean by "launching VS Code from a different path".

verification:

Launch VS Code insiders, make sure you're logged in to something
Close VS Code Insiders
Open a terminal (not in VS Code Insiders) and run (This will spin up old insiders builds):

npx vscode-bisect --good f1b09237cd400d92987cf7a9681995e8011ef54c --bad 07d6f5b35fac559504dec65e3073d796b2d25a55

Note that you are not logged in to anything (expected)
in the terminal say good or bad doesn't matter
Now once vscode-bisect is done open your VS Code Insiders
You should still be logged in to your stuff


Implement Linux and OS X PlatformManagers

Somewhat easier thanks to the keyboard library.

A Linux wheel for opencv will also have to be part of this piece.

I'm anticipating a new computer shortly, so I'll be working on cross-platform support in OS X and Linux in the near future.

Initial research on Linux seems to indicate that getting a robust screen capture from native libraries without a third-party tool is difficult. Working to find the best solution.

Am waiting for OSX implementation.

Ran into an issue installing opencv on OSX. Installing it as an ordinary user failed; it had to be installed using sudo:
sudo -H pip3 install opencv-python

I've opened an issue on the opencv-python repository. Hopefully this can be fixed before we roll out OS X support.

The keyboard library does not yet have OS-X support. Working on that implementation.

The OS X branches of both keyboard and lackey are nearly complete, pending a bit more testing.
Retina displays are a pain to work with. Most notably, OS X's default screencap functionality saves PNGs as double the resolution and double the DPI, and this means the images must be edited down before being usable. I am going to experiment with auto-scaling loaded images to 72 DPI.

I have submitted a pull request to merge the OS X fork of keyboard with the main release.
Still to do for lackey:

◻ Test auto-scaling of loaded images
◻ Fix opencv install issue

https://github.com/skvark/opencv-python/issues/34

Fix opencv install issue :  https://github.com/glitchassassin/lackey/issues/78  is completed.

Hello glitchassassin,
when will it become compatible for linux?Waiting Impatiently:)
Kubuntu 16.04 :))

I have been buried by other projects, but at the moment I'm working on the automated Travis build for the Mac OS version. Once that's complete, I'll try to turn my attention to the Linux implementation.

thank you, you do great things.

thanks, great work. having a small issue: Key.CMD on mac returns an error when used with type() as its mapped to the 'windows' key..

I'm unable to duplicate this issue, @rwalton00.
Steps to test:

Open a new Terminal window
Launch python
from lackey import *
type("m", KeyModifier.CMD)
Expected result: The terminal window is minimized.

Neither Key.CMD nor KeyModifier.CMD throws an error for me.
If you're able to reliably duplicate the problem, please open a new issue with the steps you take and I'll dig further.
Thanks!

Hi @glitchassassin ,
I'm reproducing this problem consistently. I installed lackey 0.7.0 using pip and I'm running MacOS 10.12.6, but I have also seen the problem on 10.11.6.
My reproduction steps are essentially identical to yours posted above, so I'm assuming this is an environmental issue on my end. I've logged a new ticket with more detail.
Thanks again for the API and for implementing MacOS support!

Hi! First of all I want to say that I really like your work a lot!
My question is, when will lackey be available for Linux?
Thanks!

Really looking forward to Linux OS support.

Any update on Linux support? I have a project using lackey that I need to run on Linux and just realized today that it's not supported..

This is pretty issue tool. Linux support would be awesome.

tell me please when you can use on linux

Ignore my previous comment, I can see that some work has been done in trying to implement this. I may see where work remains and try to help if I can.

Making some progress on this at long last! I have deciphered enough python-xlib to collect monitor arrangement and screen resolution, assuming we can get details from Xinerama; if not, right now, we just treat the whole array as a single screen and hope for the best. I am not going to botch my Linux install by trying to disable Xinerama to test, not yet!
We have screencapture functionality via Xlib as well. Working on the window management routines at the moment.

Finished the rest of the draft and updated the feature-linux branch from the develop branch. I've done some basic testing to make sure it imports correctly, detects the screens, and correctly moves the mouse to hover in the center of each of my monitors. I'll update the automated test cases to cover Linux as well and then we'll be ready to push this out.

Although mouse movement works, mouse clicking does not appear to work properly in the keyboard library. More troubleshooting required.

Fantastic news. I started looking through the PlatformManager classes, but you're certainly faster than me with your own code! I'll test things out.

First attempt of running my code against Linux gets an error with the "wait" method:

import lackey
lackey.wait("4352.png",90)

AttributeError: module 'lackey' has no attribute 'wait'

Not sure if it's just on my end, but the same code runs well in MacOS. I'll keep testing things.

Had a couple stray platform checks, lackey.wait() is now attached.

Nice, that worked this time. Now the one part my test failed on is the same spot you commented on above: when clicking, mouse hovers over matched image and doesn't click.

Hi @glitchassassin !
Found problem with a click()
Trying small tests on Ubuntu 18
Lackey 0.7.3 found button, moved mouse, but does not click, after this  script stops, because next step necessary button appears only after clicking
Using Lackey on this step like: click(Pattern("Pic_button.png"))
Any opinions on this issue
Maybe I'm using this incorrectly
Or are there other uses


Swap dependency from eframe to egui

eframe is a constrictive dependency to have - a lot of projects use egui without eframe. Since this crate doesn't depend on any of the features in eframe, it makes sense to change it.
I've not tested these changes beyond ensuring they compile, though I see no reason why this should break anything.

Good catch, thanks for the PR!


Test rule: IDE0058 Expression value is never used

Rule summary

Value

Title
Remove unnecessary expression value (IDE0058)

CheckId
IDE0058

Category
Style

Link
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0058

What is the problem
When writing tests and using e.g. NSubsitute to verify that a call has happened, you often have to fake calling it to create the assertion. If the method we are asserting was called/not called returns a value, this rule will complain that we have a returned value that needs to be assigned to either a variable or a discard (_).
Suggestion
[tests/**.cs]
dotnet_diagnostic.IDE0058.severity = silent         # IDE0058: Expression value is never used

I find this to be a good rule, you can see that the author has thought about the return value and not just forgotten about it. I vote for keeping it.

I find this to be a good rule, you can see that the author has thought about the return value and not just forgotten about it. I vote for keeping it.

Do you also see the value of that in tests? I don't want to disable this in production code, just test code.

To show an example, where think this rule doesnt add value, consider this:
[Theory, AutoNSubstituteData]
public async Task MasterAssigned_Doesnt_Change_Master_When_Recipe_Does_Not_Exists(
    [Frozen] IRecipeRepository repository,
    RecipeBuilder sut,
    MasterAssigned @event,
    CancellationToken cancellationToken)
{
    repository.GetByIdAsync(default, default).ReturnsForAnyArgs(default(Recipe));

    await sut.ExecuteEventAsync(@event, cancellationToken);

    _ = repository.DidNotReceive().StoreAsync(Arg.Any<Recipe>(), Arg.Is(cancellationToken));
    _ = repository.DidNotReceive().StoreAsync(Arg.Any<Recipe[]>(), Arg.Is(cancellationToken));
}

vs this:
[Theory, AutoNSubstituteData]
public async Task MasterAssigned_Doesnt_Change_Master_When_Recipe_Does_Not_Exists(
    [Frozen] IRecipeRepository repository,
    RecipeBuilder sut,
    MasterAssigned @event,
    CancellationToken cancellationToken)
{
    repository.GetByIdAsync(default, default).ReturnsForAnyArgs(default(Recipe));

    await sut.ExecuteEventAsync(@event, cancellationToken);

    repository.DidNotReceive().StoreAsync(Arg.Any<Recipe>(), Arg.Is(cancellationToken));
    repository.DidNotReceive().StoreAsync(Arg.Any<Recipe[]>(), Arg.Is(cancellationToken));
}

To me, this is very much the same consideration as with string.Equals vs ==. Sure, with _ = I make it explicit that I do not care about the value. But to be honest, that should be obvious in this context.

Decision: ROOT = ERROR

https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/IDE0058.md

Are we still sure on this?
E.g. in a console app:
services.AddLogging(logging =>
{
     logging.AddConsole().SetMinimumLevel(LogLevel.Information);
     logging.AddDebug().SetMinimumLevel(LogLevel.Trace);
});

Becomes
_ = services.AddLogging(logging =>
{
     _ = logging.AddConsole().SetMinimumLevel(LogLevel.Information);
     _ = logging.AddDebug().SetMinimumLevel(LogLevel.Trace);
});

Another example that will get a lot uglier with this rule:
    requestHeaders.Add("Accept");
    requestHeaders.Add("Accept-Encoding");
    requestHeaders.Add("Cache-Control");
    requestHeaders.Add("Pragma");
    requestHeaders.Add("Upgrade-Insecure-Requests");
    requestHeaders.Add("User-Agent");
    requestHeaders.Add("X-Forwarded-Host");
    requestHeaders.Add("X-Forwarded-Proto");

They all just return a true/false depending on whether the element was already in the hash set.
Does changing all of these to:
 _ = requestHeaders.Add("X-Forwarded-Proto");

really provide value that counters the additional verbosity? maybe it does, I am not sure. I just wanted to add the examples to the mix for consideration.
The same goes for e.g. services:
    services.AddSingleton<Utilities>();
    services.AddScoped<IUpdater, UpdaterService>();
    services.AddScoped<IFileUtility, FileUtility>();
    services.AddScoped<IUriHelper, UriHelper>();

This rules is starting to annoy more and more in production code as well, e.g. here is an example of a fluent interface/api where it complains when we do not continue the fluent chain...:

Has to be this to make things compile:

Decision: ROOT = NONE.
Refer to arguments above, where e.g. build pattern based code suffer, we have reversed to NONE.

Commit: https://github.com/atc-net/atc-coding-rules/commit/522c1b9fe721dc1625cefd55da9e655008144de8


High cpu usage

If omnisharp-atom start，cpu usage aways 10+% .Like MacBook battery killer.

I can verify this. Even when Atom is idle, there is high cpu usage.
When I uninstall omnisharp-atom and restart, the cpu drops down to around 1%.

Fixed in v0.17.0

👍

Can we close this then?


Misc minor fixes to Switch Optimization

Disabled Switch optimization upon Rejit.
Cleaned up an API which is no longer called.
Added back the Assert in the Ld_A const folding API (It was removed
earlier as it can have only two BailOutKinds, but it is good to have the
old assert here.)

@rajatd : please take a look.
This also resolves  Issue #703

Looks good

Closing this due to some ChakraHub issue and re-opening https://github.com/Microsoft/ChakraCore/pull/707


Typescript definitions

Hi! Love the library, really fits my workflow, thank you!
I wrote some basic type-defs to help along, maybe you'll find them useful:
type ZustandCreate<T> = (set) => T;
type ZustandUse<T> = (store: T) => Partial<T>;
declare module "zustand" {
  function create<T>(fn: ZustandCreate<T>): ZustandUse<T>[];
  export = create;
}

nm, it's still buggy. will reopen when it works fine :)

Thanks for working on this! I'd love to get these typings as well


Problems with homebrew installation

I've tried default homebrew  installation via terminal about 5 times and it displayed same error
=> swift build --disable-sandbox -c release
Last 15 lines from /Users/—/Library/Logs/Homebrew/hyper-focus/01.swift:
2023-04-01 13:36:50 +0000

swift
build
--disable-sandbox
-c
release

error: terminated(1): /usr/bin/xcrun --sdk macosx --show-sdk-platform-path output:
    xcrun: error: unable to lookup item 'PlatformPath' from command line tools installation
    xcrun: error: unable to lookup item 'PlatformPath' in SDK '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'

@BangGang6969 could you try running sudo xcode-select -switch /Applications/Xcode.app/Contents/Developer to see if that fixes the issue?
The real fix is getting precompiled bottles, but I'm not sure that's possible if it's not hosted within the main homebrew repo :/

@BangGang6969 curious if the Xcode-select fixed the issue?

Closing this out, feel free to reopen.


Adding kubernetes-announce and discourse addresses to the email template

This adds two emails we were missing from the template for security
announcements:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Signed-off-by: Jonathan Pulsifer<EMAIL_ADDRESS>

/cc @castrojo

/lgtm
/approve


Minor Improvements:

Add ordering to the cv items
Centering the footer text
Adding links to publications
Capitalizing the first letter in profile
Adding courses to CV

In a lot of files were included some comments at the top, like <!-- about.html -->. Is there a reason for this?

No, I can remove them.


Terraform plan never runs

Bug description 🐞
Public or private repos show the same behavior when adding to a workspace. When running the built-in "Terraform Plan" it hangs at "Running Terraform Plan pending": Waiting logs...

There is no other data anywhere indicating what is actually happening. Additionally once something enters this state there is no way to stop/cancel the run. The only way to remove this "queue" is to completely delete the workspace with all the variables defined, etc. and try again. Unfortunately it never works.
Steps to reproduce
Create a workspace and try to run any operation.
Expected behavior
No response
Example repository
No response
Anything else?
No response

Hello @erick-prosimo can you create one job and check the logs of the pods for the API and Executor component.
You can get the logs using the following:
kubectl get pods -n terrakube
kubectl logs <POD_NAME_API> -n terrakube
kubectl logs <POD_NAME_EXECUTOR> -n terrakube

When a job is create is should take up to 60 seconds to start.
By the way you can also use lens to see the logs in real time it is easier than using kubectl.

Could you check the API logs, you should be able to see something like this when the jobs is triggerred.
2023-02-03 15:36:00.206  INFO 1 --- [ryBean_Worker-1] o.t.api.plugin.scheduler.ScheduleJob     : Checking Job 1 Status pending
2023-02-03 15:36:00.210  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : InitialJobSetup 1
2023-02-03 15:36:00.264  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : FlowConfig:
 FlowConfig(flow=[Flow(type=terraformPlan, team=null, name=Running Terraform Plan, step=100, commands=null)])
2023-02-03 15:36:00.273  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Custom Job Setup:
 FlowConfig(flow=[Flow(type=terraformPlan, team=null, name=Running Terraform Plan, step=100, commands=null)])
2023-02-03 15:36:00.274  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Creating step: Flow(type=terraformPlan, team=null, name=Running Terraform Plan, step=100, commands=null)
2023-02-03 15:36:00.274  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Step name Running Terraform Plan

2023-02-03 15:36:00.277  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Parent 1 Step created 678e8362-a731-4073-bdec-f020160dc3ee
2023-02-03 15:36:00.308  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Pending steps 1
2023-02-03 15:36:00.308  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Next Command: 100
2023-02-03 15:36:00.309  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : FlowConfig:
 FlowConfig(flow=[Flow(type=terraformPlan, team=null, name=Running Terraform Plan, step=100, commands=null)])
2023-02-03 15:36:00.310  INFO 1 --- [ryBean_Worker-1] o.t.api.plugin.scheduler.ScheduleJob     : Execute command: terraformPlan
 null
2023-02-03 15:36:00.319  INFO 1 --- [ryBean_Worker-1] o.t.a.p.scheduler.job.tcl.TclService     : Pending steps 1
2023-02-03 15:36:00.323  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Pending Job: 1 WorkspaceId: a4ad32fe-fff5-45e0-89b7-136d70f5e68c
2023-02-03 15:36:00.325  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Checking Variables
2023-02-03 15:36:00.325  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Private Repository GITHUB
2023-02-03 15:36:00.445  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Sending Job: /n ExecutorContext(commandList=null, type=terraformPlan, organizationId=24351f42-7963-49a9-af4d-2a0e4aa3a92b, workspaceId=a4ad32fe-fff5-45e0-89b7-136d70f5e68c, jobId=1, stepId=678e8362-a731-4073-bdec-f020160dc3ee, terraformVersion=1.2.9, source=https://github.com/alfespa17/terrakube-workspace.git, branch=main, folder=/workspace1, vcsType=GITHUB, accessToken=****, environmentVariables={TF_IN_AUTOMATION=1}, variables={})
2023-02-03 15:36:00.491  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Response Status: 202
2023-02-03 15:36:00.492  INFO 1 --- [ryBean_Worker-1] o.t.api.plugin.scheduler.ScheduleJob     : Executing Job 1 Step Id 678e8362-a731-4073-bdec-f020160dc3ee

You should be able to see the job information that is sent to execution inside the API logs.
2023-02-03 15:36:00.445  INFO 1 --- [ryBean_Worker-1] o.t.a.p.s.j.t.executor.ExecutorService   : Sending Job: /n ExecutorContext(commandList=null, type=terraformPlan, organizationId=24351f42-7963-49a9-af4d-2a0e4aa3a92b, workspaceId=a4ad32fe-fff5-45e0-89b7-136d70f5e68c, jobId=1, stepId=678e8362-a731-4073-bdec-f020160dc3ee, terraformVersion=1.2.9, source=https://github.com/alfespa17/terrakube-workspace.git, branch=main, folder=/workspace1, vcsType=GITHUB, accessToken=****, environmentVariables={TF_IN_AUTOMATION=1}, variables={})

Yeah, I see it send the job, but the executor is throwing that error.
2023-02-03 16:17:00.687  INFO 1 --- [ryBean_Worker-8] o.t.api.plugin.scheduler.ScheduleJob     : Execute command: terraformPlan   null 2023-02-03 16:17:00.688  INFO 1 --- [ryBean_Worker-8] o.t.a.p.scheduler.job.tcl.TclService     : Pending steps 1 2023-02-03 16:17:00.689  INFO 1 --- [ryBean_Worker-8] o.t.a.p.s.j.t.executor.ExecutorService   : Pending Job: 9 WorkspaceId: 3c0286b1-5aec-4f57-a828-ea2a86e3be2b 2023-02-03 16:17:00.689  INFO 1 --- [ryBean_Worker-8] o.t.a.p.s.j.t.executor.ExecutorService   : Checking Variables 2023-02-03 16:17:00.689  INFO 1 --- [ryBean_Worker-8] o.t.a.p.s.j.t.executor.ExecutorService   : Private Repository GITHUB 2023-02-03 16:17:00.713  INFO 1 --- [ryBean_Worker-8] o.t.a.p.s.j.t.executor.ExecutorService   : Sending Job: /n ExecutorContext(commandList=null, type=terraformPlan, organizationId=2aa128f5-5bab-40d7-aba5-2dead24549e4, workspaceId=3c0286b1-5aec-4f57-a828-ea2a86e3be2b, jobId=9, stepId=66763c3e-2b9b-4cc2-8b0c-d87bc412fdb8, terraformVersion=1.3.4, source=https://github.com/<hidden>/terraform-aws-wordpress.git, branch=main, folder=/, vcsType=GITHUB, accessToken=****, environmentVariables={TF_IN_AUTOMATION=1}, variables={}) 2023-02-03 16:17:00.713  INFO 1 --- [ryBean_Worker-8] o.t.a.p.s.j.t.executor.ExecutorService   : Response Status: 202 2023-02-03 16:17:00.714  INFO 1 --- [ryBean_Worker-8] o.t.api.plugin.scheduler.ScheduleJob     : Executing Job 9 Step Id 66763c3e-2b9b-4cc2-8b0c-d87bc412fdb8 2023-02-03 16:17:03.580  INFO 1 --- [nio-8080-exec-9] p.s.a.d.DexAuthenticationManagerResolver : Using Dex JWT Authentication Provider

 [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.executor.ExecutorJobImpl - Create Job for Organization 2aa128f5-5bab-40d7-aba5-2dead24549e4 Workspace 3c0286b1-5aec-4f57-a828-ea2a86e3be2b  [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - User Home Directory: /home/cnb [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Workspace git clone directory: /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b/.originRepository [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Workspace working directory: /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - vcsType: GITHUB [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Commit Id: 58d80304012e66d0736485402e38e3d6e69334cc [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Writing commit id to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b/commitHash.info [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy files from folder /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b/.originRepository/ to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy outputs.tf to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy providers.tf to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy README.md to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy main.tf to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy variables.tf to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] INFO org.terrakube.executor.service.workspace.SetupWorkspaceImpl - Copy .git to /home/cnb/.terraform-spring-boot/executor/2aa128f5-5bab-40d7-aba5-2dead24549e4/3c0286b1-5aec-4f57-a828-ea2a86e3be2b [threadPoolTaskExecutor-1] ERROR org.terrakube.executor.service.workspace.security.WorkspaceSecurityImpl - Generate Dex Authentication Private Token [threadPoolTaskExecutor-1] ERROR org.springframework.aop.interceptor.SimpleAsyncUncaughtExceptionHandler - Unexpected exception occurred invoking async method: public void org.terrakube.executor.service.executor.ExecutorJobImpl.createJob(org.terrakube.executor.service.mode.TerraformJob) io.jsonwebtoken.io.DecodingException: Illegal base64url character: '+' 	at io.jsonwebtoken.io.Base64.ctoi(Base64.java:221) 	at io.jsonwebtoken.io.Base64.decodeFast(Base64.java:270) 	at io.jsonwebtoken.io.Base64Decoder.decode(Base64Decoder.java:36) 	at io.jsonwebtoken.io.Base64Decoder.decode(Base64Decoder.java:23) 	at io.jsonwebtoken.io.ExceptionPropagatingDecoder.decode(ExceptionPropagatingDecoder.java:36) 	at org.terrakube.executor.service.workspace.security.WorkspaceSecurityImpl.generateAccessToken(WorkspaceSecurityImpl.java:50) 	at org.terrakube.executor.service.workspace.security.WorkspaceSecurityImpl.addTerraformCredentials(WorkspaceSecurityImpl.java:87) 	at org.terrakube.executor.service.workspace.SetupWorkspaceImpl.prepareWorkspace(SetupWorkspaceImpl.java:60) 	at org.terrakube.executor.service.executor.ExecutorJobImpl.createJob(ExecutorJobImpl.java:39) 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 	at java.base/java.lang.reflect.Method.invoke(Unknown Source) 	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344) 	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198) 	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) 	at org.springframework.aop.interceptor.AsyncExecutionInterceptor.lambda$invoke$0(AsyncExecutionInterceptor.java:115) 	at java.base/java.util.concurrent.FutureTask.run(Unknown Source) 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) 	at java.base/java.lang.Thread.run(Unknown Source)

It looks like the issue is related to the Terrakube Internal secret, this is used to sign the token for internal component communication.
https://github.com/AzBuilder/terrakube/blob/main/executor/src/main/java/org/terrakube/executor/service/workspace/security/WorkspaceSecurityImpl.java#L50
Quick question when you deployed the helm chart did you used a 32 random character? like this example:
security:
  adminGroup: "<<CHANGE_THIS>>" # This should be your Azure AD group name
  patSecret: "<<CHANGE_THIS>>"  # Sample Key 32 characters z6QHX!y@Nep2QDT!53vgH43^PjRXyC3X
  internalSecret: "<<CHANGE_THIS>>" # Sample Key 32 characters Kb^8cMerPNZV6hS!9!kcD*KuUPUBa^B3
  dexClientId: "microsoft"
  dexClientScope: "email openid profile offline_access groups"
  dexIssuerUri: "https://terrakube-api.domain.com/dex" #

Can you try updating the value of the internal secret?

The secret should be 32 character long

OK, will give it a try here in a sec. One more question, is there a way to set global variables that are persisted so they dont need to be added everytime?

Yup, confirmed, secret was the issue. I think that part was also unclear in the docs. Probably need to call out it must be a base64 compatible string that is 32 characters in length.

You can do that using "global variables" in the organization, we added that feature some time ago https://github.com/AzBuilder/terrakube/pull/181 but it is only available using the API.
You can check the docs here
There is an open issue to add that in the UI https://github.com/AzBuilder/terrakube/issues/207

OK, cool. I did see it in the CLI/API, but wanted to make sure it was usable. I'll give that a shot next. Thanks so much!
¡Disfruta tu fin de semana!

Muchas gracias, feliz fin de semana!!!

Comments about the secret requirements was added in the helm chart docs.
https://github.com/AzBuilder/terrakube-helm-chart/pull/42


Creating after copying ISOs

I was unable to create a new guest. Some probing showed that the variable "pool" was:
zroot
zroot
zroot
zroot
Further probing showed that the line that generated the variable pool (ioh-guest, line 166) was getting multiple values because I had copied in some of the ISOs that I had lying on my system for future use under iohyve. Appending "| tail -n1" to the chain appears to have fixed the problem.

Thank you for the detailed report. When you copied over the ISO files, did you do it manually, or did you use the cpiso function?

I used the cpiso command.
I tried to install Ubuntu last night and had issues. I will be looking into those today. I have already done this by hand, so if I can find the command in your scripts, I should be able to diagnose the problem.
-- Randy King
On Sunday, July 31, 2016 12:11 AM, pr1ntf<EMAIL_ADDRESS>wrote:

Thank you for the detailed report. When you copied over the ISO files, did you do it manually, or did you use the cpiso function?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Did you install via ports or from the GitHub repo? I believe that ISO issue with no guests installed has been fixed.

Installed via ports (pkg install iohyve). I will try installing from GitHub before trying to install Ubuntu. I didn't get to it today.--RRK
On Sunday, July 31, 2016 8:57 PM, pr1ntf<EMAIL_ADDRESS>wrote:

Did you install via ports or from the GitHub repo? I believe that ISO issue with no guests installed has been fixed. —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

No rush. If you have nothing of value in your iohyve dataset, I would ask you to nuke it and all of it's children before you try again. If not, no worries. I just want to solve your ISO issue. If you are having issues with Ubuntu not related to the ISO issue, I'd ask if you could open a separate issue for proper tracking.

FYI, the Ubuntu problem was a lack of memory. Default value in iohyve is 256M, but the Ubuntu installation needs more (512M?). --RRK
On Tuesday, November 8, 2016 8:02 AM, pr1ntf<EMAIL_ADDRESS>wrote:

Closed #202.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the info!


First edition is major

https://trello.com/c/fq2gTSIH
The publishing-api requires that the first edition has an update_type of 'major'.
Our content editors had the requirement that they did not want to give a change_note or reason_for_change for the first edition.
We automatically set the first version's change_note to "Guidance first published" and reason_for_change as an empty string.
The form fields have been removed for the first version so the user can't edit them anymore. The existing validations on change_note and reason_for_change have been changed and we've added a validation to ensure the first edition is minor too, partially for to protect against something changing later, and partially to ensure more real-life data in tests.

All looks sensible to me, yep.


ndarray.round() stopped working without an argument.

Description
Numpy round() as a ndarray member function used to work without an argument but it is no longer working.
_ = jnp.zeros(1).round()

Expected to execute without an error, but fails with error message
TypeError: round() missing required argument 'number' (pos 1)

According to Numpy documentation, this should work without an argument.
https://numpy.org/doc/stable/reference/generated/numpy.ndarray.round.html
What jax/jaxlib version are you using?
head
Which accelerator(s) are you using?
cpu
Additional system info
python 3.10, linux
NVIDIA GPU info
No response

Probably related to https://github.com/google/jax/pull/15172

Thanks for the report! #15192 should fix


[SPARK-48155][SQL][3.4] AQEPropagateEmptyRelation for join should check if remain child is just BroadcastQueryStageExec

What changes were proposed in this pull request?
This PR backports #46523 and #48300 for SPARK-48155 to branch-3.4.
Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

the linter failure is unrelated, thanks, merging to 3.4!


Prometheus snapshot not created when kubetest times out

Prometheus snapshot is not created if kubetest times out. Snapshotting logic lives inside clusterloader, so when kubetest times out the logic is simply not executed. It is unfortunate, especially timeouts are situation, which we'd like to debug usually.
I was hit by this issue when tryring to debug: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88342/pull-kubernetes-e2e-gce-large-performance/1230477531426066432/
I see two options: 1) move snapshotting outside of the test (e.g. similarly to log dumping) 2) reconsider using Cortex (or any other solution that allows live recording of metrics).
@mm4tt - WDYT?
/priority important-soon
/area clusterloader

I also took some notes about that run:

It looked like the api-server exploded during the test, but it wasn't obvious from the logs that it was the case (it requires some experience with CL2 to guess / know that)
There is no point in continuing the tests if such thing happens. Actually, continuing the test creates a lot of issues, e.g.

Such test is a waste of resources, it will last until timeout (which is much longer than the average test duration)
There is no time for some important operations, e.g. gathering measurements or dumping prometheus
Log will be full of strange errors, it's hard for someone unexperienced to understand it

I had two things in mind as a remedy:

Introducing an "api-availability" measurement (and SLO). Basically we could check apiservers's /healthz endpoint every Xs from clusterloader2 and later compute the overall availability of api-server (e.g. % of OKs, or longest unavailability period). I believe this info would be very useful for a quick-glance debugging
In addition to reporting the availability, we could make this measurement fail if e.g. apiserver was not available at all in the last XXmin. In such case, IMHO it's safe to assume that the control-plane died. If such error is returned, CL2 would stop executing the test. As a side note, I think this mechanism for stopping test is already implemented, there is a concept of critical error, but we just don't use it in any measurement.

Introduce a timeout on the CL2 test execution. It's a more generic solution to the problem you described, but I think it might be tricky to tune it properly and later to there will be a maintenance cost (e.g. we change something and now load test starts taking X% shorter / longer -> we need to change the timeouts)

Even though 2 seems to be much more generic, I don't remember any situation where Cl2 would timeout for reason other than control-plane unavailability. Because of that I think we should first implement 1 (which has other benefits, e.g. makes it easier for people outside scalability, it's a nice SLO to provide users) and then see whether 2 (or solutions you proposed) are really needed.

/remove-lifecycle stale

/remove-lifecycle stale
/lifecycle frozen


Embed video has a white flash when toggle active state

Bug Report
When playing or pausing an embedded video there is a white flash when switching between the placeholder and the video. This is particualry annoying when the placeholder is the first frame of the video.
Steps
Create an Embed component and press play
Expected Result
Playing a video should smoothly show the video.
Actual Result
There is a whiteflash before the video starts
Version
0.34.0
Testcase
https://codesandbox.io/s/stardust-ui-example-fm1ow

Please see if PR #1768 resolves this. There is now a background color set. It behaves the same as Semantic UI's Embed.

@jurokapsiar PR #1768 did not resolve this issue


Cannot find a way to get the pixel data from texture or sprite.

Hello. I don't know if I miss something, but...
How can I get the raw pixel array of a texture? Every and every post talks about putting stuff onto a RenderTexture but there is absolutely no post about how to get the data from that texture.
I need the pixel data to output it with another protocol to a self made LED-strip-screen.
I render a RenderTexture with my whole output screen in the browser, create a sprite from it and add that to a new container, resize it to the LED-screen size and render it (scaled) to another RenderTexture....and now I am stuck by not getting this damn pixel data.
I post this as an issue because absolutely nowwhere is something about getting the data in a raw format. Only about PUTing data on the texture/sprite/container.
So, my request is: Please add a function RenderTexture.getPixelArray()/getRawData() or something like that. Or link me to the appropiate website where this is explained, I searched about 3 hours and found nothing.
[EDIT] there must be a webGL way, with NOT putting the stuff on a canvas and...so...on...don't you think?
Thanks in advance.
PIXI is great, just to say.
Regards,
ben0bi

Look at the WebGLExtract API:
https://github.com/pixijs/pixi.js/blob/master/src/extract/webgl/WebGLExtract.js
PIXI.extract.webGL.pixels(renderTexture)

Thank you very much. It would be great if this is referred in the docs, Texture-classes, with a link.

I get "Uncaught TypeError: Cannot read property 'webGL' of undefined"
Do I have to add the class manually?

V4
renderer.extract.pixels(myContainer)

That's how it works: https://github.com/pixijs/pixi.js/blob/master/src/extract/webgl/WebGLExtract.js#L126
I am not sure how did it work in V3, I'm looking at the code and just cant find it :( I remember there was something

Oh I see here, I do not need a second renderTexture to render the scaled container, seems like I can just use the container itself. (...pixels(container)), very nice very nice. downloading v4, looking if it works.
[closed for now ;) ]

Oh, there's something:
var canvas = renderTexture.getCanvas();
var pixels = renderTexture.getPixels();

It is here: https://github.com/pixijs/pixi.js/blob/v3/src/core/textures/RenderTexture.js#L392

a little bit of nice makes the spice. :) thanks.

Just remember that its a slow method. Every upload/download of texture from/to GPU is slow.

Yeah but I need the bytestream to output it to the LED array. Is extract faster?

No, its slow in general. You can do that may be one time per frame, but not more :) Also you don't have to call "renderer.render" if you only need that output. "pixels" has one inside.

The size of the LED screen should be adjustable, that is why I scale the output with a renderTexture + Sprite combination. It is fast enough each 10 frames for now. We can right now control about 300 LED without flickering (serial data speed issues), so the screen will not be really big, only look big because of big LEDs.
Really thanks for your help. I will post some photos or a utube video when it's done and working.

Here is the first image, proofing that it may work. 400x400 scaled down to 40x40 and then put out as html text image. (once)

Thanks, guys.


Rename MeshBoundingBox to GetMeshBoundingBox

Changes
I've change all occurences of MeshBoundingBox to GetMeshBoundingBox.

@PtitLuca thank you very much for the update! 👍


codeQL checks not completing

The 'Code scanning results / CodeQL' task is not completing.
This was preventing PRs being merged
Example:

Note that this is after the mandatory check was removed.
Raising issues to track reenabling the codeQL check / following up with Github

The check is now running ok.
However I am unable to reinstate it as a mandatory check due to an error Could not resolve to a node with the global id of 'MDM6QXBwNTc3ODk='. ......
Contacted github support -> https://support.github.com/ticket/personal/0/1405263

Not fixed. following up with github support.

This appears to be working, closing for now


misc/cgo/testshared: fails on 1.5 release with gccgo 5.2

##### ../misc/cgo/testshared
2015/08/24 12:13:31 elf.Open failed: open /tmp/testshared842877175/pkg/gccgo_linux_amd64_5577006791947779410_fPIC/shlibs/libdep.so: no such file or directory
exit status 1
FAIL	_/builddir/build/BUILD/go/misc/cgo/testshared	2.382s
2015/08/24 12:13:31 Failed: exit status 1
+ :
+ du -a /tmp/
28	/tmp/testshared842877175/pkg/gccgo_linux_amd64_5577006791947779410_fPIC/libdep.a
32	/tmp/testshared842877175/pkg/gccgo_linux_amd64_5577006791947779410_fPIC
4	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/dep.shlibname
4	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/dep2.shlibname
12	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/dep.a
4	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/dep2.a
20	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/libdep.so
16	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink/libdep2.so
64	/tmp/testshared842877175/pkg/linux_amd64_5577006791947779410_dynlink
100	/tmp/testshared842877175/pkg
4	/tmp/testshared842877175/src/exe/exe.go
8	/tmp/testshared842877175/src/exe
4	/tmp/testshared842877175/src/trivial/trivial.go
8	/tmp/testshared842877175/src/trivial
4	/tmp/testshared842877175/src/dep/dep.go
4	/tmp/testshared842877175/src/dep/gccgo.go
4	/tmp/testshared842877175/src/dep/stubs.go
4	/tmp/testshared842877175/src/dep/asm.s
20	/tmp/testshared842877175/src/dep
4	/tmp/testshared842877175/src/execgo/exe.go
8	/tmp/testshared842877175/src/execgo
4	/tmp/testshared842877175/src/exe2/exe2.go
8	/tmp/testshared842877175/src/exe2
4	/tmp/testshared842877175/src/dep2/dep2.go
8	/tmp/testshared842877175/src/dep2
64	/tmp/testshared842877175/src
16	/tmp/testshared842877175/bin/exe
16	/tmp/testshared842877175/bin/trivial
72	/tmp/testshared842877175/bin/execgo
16	/tmp/testshared842877175/bin/exe2
124	/tmp/testshared842877175/bin
24	/tmp/testshared842877175/shared_test.go
316	/tmp/testshared842877175

Indeed such a file was not generated in the _fPIC/shlibs/libdep.so

possibly related to the issue #12083

Yes, dup of #12083 .

Well no, I'd hope this test passes with a newer gccgo than expected...
On 25/08/2015 5:07 am, "Ian Lance Taylor"<EMAIL_ADDRESS>wrote:

Yes, dup of #12083 https://github.com/golang/go/issues/12083 .
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/12291#issuecomment-134302843.

@ianlancetaylor yeap the difference is that i'm using released gcc 5.2 and released golang 1.5 and they don't seem to pass the test-suite on our build bots =( i'll probably skip that test case.

Can you run the test with -v? (cd misc/cgo/testshared; go test -v)

i am bootstrapping, thus by "go" is the one from gccgo. How can I run bootstrap with verbose tests through out?

Just put the bin dir from the top of the tree first in $PATH
On 25 August 2015 at 23:15, Dimitri John Ledkov<EMAIL_ADDRESS>wrote:

i am bootstrapping, thus by "go" is the one from gccgo. How can I run
bootstrap with verbose tests through out?
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/12291#issuecomment-134556869.

+ go install -installsuffix=8674665223082153551 -v -buildmode=shared runtime sync/atomic
runtime
sync/atomic
runtime/cgo
=== RUN   TestSOBuilt
--- PASS: TestSOBuilt (0.00s)
=== RUN   TestShlibnameFiles
--- PASS: TestShlibnameFiles (0.00s)
=== RUN   TestTrivialExecutable
+ go install -installsuffix=8674665223082153551 -v -linkshared trivial
trivial
--- PASS: TestTrivialExecutable (0.08s)
=== RUN   TestCgoExecutable
+ go install -installsuffix=8674665223082153551 -v -linkshared execgo
sync
syscall
execgo
--- PASS: TestCgoExecutable (0.65s)
=== RUN   TestGopathShlib
+ go install -installsuffix=8674665223082153551 -v -buildmode=shared -linkshared dep
dep
+ go install -installsuffix=8674665223082153551 -v -linkshared exe
exe
--- PASS: TestGopathShlib (0.15s)
=== RUN   TestNotes
+ go install -installsuffix=8674665223082153551 -v -buildmode=shared -linkshared dep
--- PASS: TestNotes (0.04s)
=== RUN   TestTwoGopathShlibs
+ go install -installsuffix=8674665223082153551 -v -buildmode=shared -linkshared dep
+ go install -installsuffix=8674665223082153551 -v -buildmode=shared -linkshared dep2
dep2
+ go install -installsuffix=8674665223082153551 -v -linkshared exe2
exe2
--- PASS: TestTwoGopathShlibs (0.16s)
=== RUN   TestGoPathShlibGccgo
+ go install -installsuffix=8674665223082153551 -v -compiler=gccgo -buildmode=shared -linkshared dep
dep
# dep
ar: `u' modifier ignored since `D' is the default (see `U')
# /tmp/go-build336331315/libdep.so
/usr/lib64/gcc/x86_64-generic-linux/5.2.0/libgcc.a(morestack.o): In function `__morestack':
(.text+0x118): undefined reference to `_Unwind_Resume'
/usr/lib64/gcc/x86_64-generic-linux/5.2.0/libgcc.a(morestack.o):(.data.DW.ref.__gcc_personality_v0[DW.ref.__gcc_personality_v0]+0x0): undefined reference to `__gcc_personality_v0'
collect2: error: ld returned 1 exit status
2015/08/25 11:55:38 elf.Open failed: open /tmp/testshared827177496/pkg/gccgo_linux_amd64_8674665223082153551_fPIC/shlibs/libdep.so: no such file or directory
exit status 1
FAIL	_/builddir/build/BUILD/go/misc/cgo/testshared	3.322s

Horum, i now wonder if my gcc is misbuilt.

Can you run that go install command in TestGoPathShlibGccgo with the option -ldflags=-v ?  I don't understand those gccgo errors you are getting.  Those symbols should be defined by either -lgcc or -lgcc_s.

Timed out.


Auto Complete based on search

🛠 Fixes Issue: #17

👨💻 Changes proposed:

API to search video based on typed string
Debouncer to limit api calls
Abort Controller to cancel previous api call
AutoComplete component to show recommendation

📝 Additional Notes
Discord username: Anish | Contributor#0221

📷 Screenshots

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.
[x] I am a participant of GSSOC23

can we merge it ? @yashvardhan-verma


Handle content_tag method calls with no arguments

This cop currently crashes when it encounters a content_tag method call with no arguments. The Rails method requires at least one argument, so we can treat a call with no arguments as a false positive.
This is a bug fix for an unreleased cop, so I don't think it needs a changelog entry. Please let me know if I should add one, though.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] If this is a new cop, consider making a corresponding update to the Rails Style Guide.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This looks good. Thank you!


Add Password authentication for admin user

Support admin user password authentication.
Use bcrypt to hash the password. Default password is 'admin' and
stored as hashed string in a local file.
Login/Logout features.
Change password feature.

@SteveOss Change updated, thanks.


Reports that utilize the A,B,C categorization

Along with #207, add a report to Inventory that allows a user to see current status on items by A, B, and C items.

@tangollama I'm taking this issue.

@tangollama just wanted to clarify the requirements. In scope of this feature a checkbox should be added to the list of Fields to Include, is this correct? And should it be visible for all types of reports or only for some of them? If the checkbox is checked we should see new column Rank in the report table.


Menu BG Colors

:white_check_mark: Build TimeHACK appveyor-32 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/0b1bdad858 by @lempamo)


Need more describe breaking cycle in cycle behaviour

Page 5.20
I mean need add  that examples and describe its for learners :) :
public function a()
{
    function b()
    {
        while(true)
        {
            // breaks only current cycle
            break;
        }
    }
}

Also for continue & return for sub-cycles and anonymous & noname-  functions.
People often ask me this. And they wonder why it is not described in the manual.

I don't understand what you mean. Both continue and break abort the current innermost loop. I don't see what your code example is supposed to show either.

The break keyword leaves the control flow of the innermost loop (for or while) it is declared in, stopping further iterations:

I think the confusion of most starters is return . This will make a function return something directly. I found myself also "misusing"  return to break out of loops.
@fzzr-  I don't think we need to document this in one page, they have both their own page and explanations now. Or maybe you have additional paragraphs that would make it more clear? I personally think if the starter has actually read the manual, it would not be that confused.

Sorry, I mean all cases including interesting cases with unnamed blocks, cycles in generators,...
trace("result: " + {
        var a = 42;
        trace('a="$a"');
        return;
        [a, a, a];
    });

static function main() {
    function foo()
    {
        return [for(i in 0...42)
                {
                    if(i % 2 != 0)
                        // skip value because it's even
                        continue;

                    if(i == 10)
                        // break for-cycle because a value eq 10
                        // it isn't breaks all stack, only the current cycle
                        break;

                    trace('+"$i"');
                    // this block of iteration of for-cycle returns:
                    i;
                }];
    }
}

and about returns in blocks:
function foo():Array<Int>
{
    return [for(i in 0...42)
            {
                if(i == 42)
                    // breaks for-in cycle, breaks & return from function:
                    return [0,0,0];

                i;
            }];
}

and about gen with cycle with switch :) :
function foo(switcher:Null<Bool>):Array<Int>
{
    var i = 0;
    return [while(i < 100)
       {
            i++;
            switch(switcher)
            {
                // This is return from `foo` - current function:
                case true: return [42];

                // This is return from switch:
                case false: 42;

                // This is break will breaks array-generator with while-cycle:
    			default: break;
            };
        }];
}
trace("case true:\t " + foo(true).length);
trace("case false:\t" + foo(false).length);
trace("case null:\t " + foo(null).length);

I'll try to write some paragraphs with more simple examples about breaks, continues and various returns as soon as possible. And I'll post it here. If you think what it needed of course, @Simn, @markknol.

I still don't get it. None of these are special cases, it all follows from control flow leaving only the innermost loop (for break and continue) or function (for return).

Closing because I don't see what we should do here.


Turn doc build back on

I have disabled automated documentation builds in the .travis.yml file (line 42) until Sphinx releases version 1.3.1 (which fixes an upstream bug in cross referencing in the doc strings).  This issue is a reminder, to turn doc builds back on.

fyi, we don't build the docs on travis. They're built by readthedocs.org . We build the doctrees as if we're preparing to build the docs, but that is only necessary so we can run the tutorial doctests.

Gotcha, so turning this off in travis is effectively disabling a level of testing?
If so, I should also make sure that coveralls (coverage.py) is including the tutorial tests as they might add to our coverage rate.

yeah, the command 'make doctest' traverses through the doc/ folder and runs
several hundred (?) tests. They are largely redundant to the unit tests,
but necessary so that our tutorials remain true to the code. I looked at
the coveralls stuff the other night. Was there a decision made to not use
coveralls.io ?
On Sat, Mar 14, 2015 at 1:41 PM jlaura<EMAIL_ADDRESS>wrote:

Gotcha, so turning this off in travis is effectively disabling a level of
testing?
If so, I should also make sure that coveralls (coverage.py) is including
the tutorial tests as they might add to our coverage rate.
—
Reply to this email directly or view it on GitHub
https://github.com/pysal/pysal/issues/593#issuecomment-80713964.

I have coveralls all setup.  Here is the output from the latest build, which appears to be working: https://coveralls.io/r/pysal/pysal?branch=master
Just waiting to ensure that the icon on the README.md in the pysal repo is updated.  The embedded URL is correct, so I think this is just something that needs a bit to sync (or it is cached on my browser).
After that, the nosetests --with-tests has an additional flag that I need to turn on (once Sphinx is clean) that will include the doc folder tests in the coveralls output.

This will be resolved in #1179


use rocksdb sst file ingestion for snapshot

Hi,
This PR tries to fix issue #927.

PTAL @siddontang @BusyJay

Please fix CI.

Seem we don't support old snapshot format now.
If we upgrade TiKV, but a region's state is applying and the snapshot file is the old format, how can we handle it?

The old format should be supported rather than removed.

Coooooool

This PR is too huge now, can we split it?

We can split it into two PRs. @hhkbp2
The last commit can be a single PR.

how do we do if the new TiKV sends a new snapshot to the old TiKV?
Seem that the old TiKV will save the file with the old format, but it is not correct.

@siddontang
The old code doesn't check the version of snapshot format. The upgrade process could be handled d like a two-phase procedure:

the binary of new code could be upgraded first with new format disabled
after all binaries are upgrade, the new format could be enabled

So I think we should use a config to control using SST snapshot file or not.

Is is possible that we stop balance when upgrade to new tikv ? after we finish the upgrade process, we enable balancing.

No, PD can't control the snapshot sending if  there is a log gap between the leader and follower.

@ngaut @siddontang
I'm going to separate this PR into two PRs

Abstract the interface for adding a new format
add the new format impl
What do you think?

+1

Good idea.

This PR is split into #1579 #1618. Close.


chore: updated lint rules in models module

SUMMARY
Files slice.py, dashboard.py, datasource_access_request.py can have updated linting rules:

unused-import can be removed
changed unused arguments to private (with _ prefix) to remove unused-argument rule
several no-member rules can be removed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11036 into master will increase coverage by 5.72%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master   #11036      +/-   ##
==========================================
+ Coverage   59.95%   65.68%   +5.72%
==========================================
  Files         782      816      +34
  Lines       37252    38384    +1132
  Branches     3350     3606     +256
==========================================
+ Hits        22335    25213    +2878
+ Misses      14738    13062    -1676
+ Partials      179      109      -70

Flag
Coverage Δ

#cypress
56.43% <ø> (-0.87%)
:arrow_down:

#javascript
61.68% <ø> (?)

#python
61.38% <60.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/models/datasource_access_request.py
55.35% <0.00%> (ø)

superset/models/dashboard.py
88.03% <100.00%> (ø)

superset/models/slice.py
88.02% <100.00%> (ø)

superset-frontend/src/setup/setupPlugins.ts
22.22% <0.00%> (-77.78%)
:arrow_down:

superset-frontend/src/views/index.tsx
25.00% <0.00%> (-75.00%)
:arrow_down:

superset-frontend/src/SqlLab/index.tsx
25.00% <0.00%> (-75.00%)
:arrow_down:

superset-frontend/src/views/App.tsx
31.42% <0.00%> (-68.58%)
:arrow_down:

...rset-frontend/src/setup/setupErrorMessagesExtra.ts
50.00% <0.00%> (-50.00%)
:arrow_down:

superset-frontend/src/setup/setupErrorMessages.ts
54.54% <0.00%> (-45.46%)
:arrow_down:

superset-frontend/src/views/menu.tsx
60.00% <0.00%> (-40.00%)
:arrow_down:

... and 253 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6181994...d6778c9. Read the comment docs.


UX - connection between the playbooks and hostlevel management is not clear from the action names

closed, duplicate of https://github.com/nuvla/ui/issues/874


Old version references in hapi-fhir-tutorial/simple-server POM causes failure

Describe the bug
When running "mvn clean package" at directory "hapi-fhir/hapi-fhir-tutorial/simple-server", theere is a failure
To Reproduce
Steps to reproduce the behavior:

Clone repo
cd hapi-fhir-tutorial/simple-server
mvn clean package
See error

[INFO] ------------------------------------------------------------------------
[INFO] Building HAPI FHIR Example - Simple Server 0.7
[INFO] ------------------------------------------------------------------------
[WARNING] The POM for ca.uhn.hapi.fhir:hapi-fhir-base:jar:1.2-SNAPSHOT is missing, no dependency information available
[WARNING] The POM for ca.uhn.hapi.fhir:hapi-fhir-structures-dstu:jar:1.2-SNAPSHOT is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.296 s
[INFO] Finished at: 2018-11-29T13:15:53-07:00
[INFO] Final Memory: 9M/309M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project hapi-fhir-example-simple-server: Could not resolve dependencies for project ca.uhn.hapi.example:hapi-fhir-example-simple-server:war:0.7: The following artifacts could not be resolved: ca.uhn.hapi.fhir:hapi-fhir-base:jar:1.2-SNAPSHOT, ca.uhn.hapi.fhir:hapi-fhir-structures-dstu:jar:1.2-SNAPSHOT: Failure to find ca.uhn.hapi.fhir:hapi-fhir-base:jar:1.2-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of oss-snapshots has elapsed or updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

Expected behavior
I expect the build to be successful
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

HAPI FHIR Version: 3.7.0-SNAPSHOT
OS: Mac OSX
Browser: N/A

Additional context
I have a candidate fix that works and plan to submit a Pull Request

Ping...candidate fix submitted with PR above.


DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working

DASHBOARD_EDIT_CHART_IN_NEW_TAB flag is not working on new version. I set it to True after upgrading latest version which is 2.1.0 but charts still opening in same page.
How to reproduce the bug

set DASHBOARD_EDIT_CHART_IN_NEW_TAB to true
Go to a dahsboard and try to edit a chart

Expected results
Chart edit page should be opening new page.
Actual results
Chart edit page opening same page
Environment
(please complete the following information):

browser type and version: Chrome 112.0.5615.49
superset version: 2.1.0 installed with docker

Hi, I am Facing the same issue in release tag - v2.1.0. Its opening the charts in same window. Any workaround to fix this ? Thanks!

Seems like no one care this bug :/

Seems like no one care this bug :/

You can command-click the "Edit Chart" link to open it in a new tab, just like any other link on the web.
The "should it open in a new tab or not" debate goes back to when it was a JS function being fired rather than a normal link.
This flag is slated to be removed in 3.0 via this PR.
I think this issue can stay open... I'm not sure why the flag isn't working in 2.1.0, and anyone is welcome to open a PR to fix it, which can be pulled into 2.1.1 or any subsequent 2.x.x patch versions.

DASHBOARD_EDIT_CHART_IN_NEW_TAB no longer exists in supported versions of Superset. Closing. Thanks!


add remote follow/remote interact UX

mastodon/pixelfed instances provide a "Remote Follow" page, where people can add their remote instances in order for the local instance to forward the subscription request.
I'm trying to find any documentation on it. Example:
https://mastodon.social/users/petermolnar/remote_follow
is a page to follow<EMAIL_ADDRESS>with the instance typed in the box that shows after "proceed to follow" .

Hi, i also already looked for doc but I didn't find anything about it.
It looks like @aaronpk implemented this here on his amazing website maybe he could help us.

interesting! took me a couple tries to understand the request, but i get it now. not a priority for me, but i'd probably accept a PR. feel free to tackle it if you're interested!
alternatively, you could link to your site's profile in any instance you choose, eg https://mastodon.technology/web/accounts/52904 is my snarfed.org bridgy fed profile. you can find it by searching for eg<EMAIL_ADDRESS>in Mastodon while logged in as a normal account. users could then click Follow there and use mastodon's page directly.

I implemented a Remote Follow button on my personal blog. Maybe this will help? not really sure how to put it in Bridgy Fed though. Source / Demo

  <IconUserAdd />
  Remote follow

<input type="checkbox" id="remote-follow" class="modal-toggle" />

    <form on:submit|preventDefault={follow} class="form-control gap-2">

        Your fediverse account ID:

        <input
          bind:value={input}
          type="text"
          id="account"
          name="account"
<EMAIL_ADDRESS>          class:input-success={status === 'success'}
          class:input-warning={status === 'warning'}
          class:input-error={status === 'error'}
          class="input input-bordered transition-all flex-1" />
        <button type="submit" class="btn btn-square">
          <IconPaperAirplane class="h-6 w-6 rotate-90" />
        </button>

      {#if statusText}

            {statusText}{#if statusText === '404'}: Couldn't find user{/if}

      {/if}
    </form>

Fun, thanks! Bridgy Fed is pretty different, we couldn't add this directly, but it's great to have another example.

@gregorlove had this useful summary:

Build the webfinger URL for the account that wants to subscribe; fetch the JSON; look for rel:http://ostatus.org/schema/1.0/subscribe; get the 'template' from the same object as that rel and that is the subscribe template url...
e.g. indieweb.social's template is: https://indieweb.social/authorize_interaction?uri={uri}
replace {uri} with your @-@ and redirect to the result
So<EMAIL_ADDRESS>presumably
No idea how fragile that is / if every mastodon uses that same rel? :shrug:

@sebastiangreger has the best remote follow UI and complete fediverse profile on his web site, formatted like Mastodon/Twitter. Really good inspiration here. https://sebastiangreger.net/@sebastiangreger
More: https://sebastiangreger.net/2022/11/this-website-now-on-fediverse

This is also useful, and confirms @gregorlove's instructions above: https://socialhub.activitypub.rocks/t/what-is-the-current-spec-for-remote-follow/2020

Done! All BF user pages now have a small remote follow UI, eg https://fed.brid.gy/user/snarfed.org

More background on the webfinger rel template approach to remote follow:

https://www.hughrundle.net/how-to-implement-remote-following-for-your-activitypub-project/
https://ostatus.github.io/spec/OStatus 1.0 Draft 2.html#anchor10
https://socialhub.activitypub.rocks/t/represent-endpoint-for-remote-interaction/480
https://socialhub.activitypub.rocks/t/what-is-the-current-spec-for-remote-follow/2020


Utilization Bar Chart: updated ngdoc

Better wordsmithing of the chart's ngdoc descriptions

LGTM

@erundle please merge if ok with changes


use different

DisplayControl use "api.selfasserted" by default as the content definition. Is it possible to specify with different UI such as "api.selfasserted.custom"?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6d2160b3-a0e0-53f9-4d43-d02f42a6aada
Version Independent ID: 2897a529-18ac-da7b-4ac6-a0163d947ceb
Content: Display control reference - Azure AD B2C
Content Source: articles/active-directory-b2c/display-controls.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@steve2bi
Thanks for your feedback! We will investigate and update as appropriate.

@steve2bi
Yes, it is possible to specify a different UI for a DisplayControl by specifying a different ContentDefinition. You can create a custom ContentDefinition that references a different UI and then specify that ContentDefinition in the Metadata section of the self-asserted technical profile that references the DisplayControl.
For example, you can create a custom ContentDefinition with the ID "api.selfasserted.custom" that references a custom UI and then specify that ContentDefinition in the Metadata section of the self-asserted technical profile that references the DisplayControl.


[5 of 8: Service Updates & Upgrades] Introduce UpdateConfigModalContents

Reviewer: @pierlo-upitup

I'm not sure whether the integration tests are failing because of this PR or because of the feature-branch/software-updates branch

@mlunoe I don't know the answer to that either, but I don't think they should hold up this PR.

@jfurrow It is very important that we keep our integration tests passing.
I ran the integration tests for this branch and it seems that the feature branch (feature-branch/software-updates) is not rebased off of latest master and that is why they are failing. I think we should fix that.
It is hard for me, in the current state, to tell whether this feature broke something new.

@mlunoe I'll rebase, but the integration tests are very unreliable right now so they should not be holding up PRs, in my opinion.

🎉 🎈


ARROW-3789: [Python] Use common conversion path for Arrow to pandas.Series/DataFrame. Zero copy optimizations for DataFrame, add split_blocks and self_destruct options

The primary goal of this patch is to provide a way for some users to avoid memory doubling with converting from Arrow to pandas.
This took me entirely too much time to get right, but partly I was attempting to disentangle some of the technical debt and overdue refactoring in arrow_to_pandas.cc.
Summary of what's here:

Refactor ChunkedArray->Series and Table->DataFrame conversion paths to use the exact same code rather than two implementations of the same thing with slightly different behavior. The ArrowDeserializer helper class is now gone
Do zero-copy construction of internal DataFrame blocks for the case of a contiguous non-nullable array and a block with only 1 column represented
Add split_blocks option to to_pandas which constructs one block per DataFrame column, resulting in more zero-copy opportunities. Note that pandas's internal "consolidation" can still cause memory doubling (see discussion about this in https://github.com/pandas-dev/pandas/issues/10556)
Add self_destruct option to to_pandas which releases the Table's internal buffers as soon as they are converted to the required pandas structure. This allows memory to be reclaimed by the OS as conversion is taking place rather than having a forced memory-doubling and then post-facto reclamation (which has been causing OOM for some users)

The most conservative invocation of to_pandas now would be table.to_pandas(use_threads=False, split_blocks=True, self_destruct=True)
Note that the self-destruct option makes the Table object unsafe for further use. This is a bit dissatisfying but I wasn't sure how else to provide this capability.

I will rebase this and add docs. It's a little bit frustrating to have rebase conflicts due to a patch that only fixes typos =/

I added docs, so aside from CI issues this is ready to go. @jorisvandenbossche can you help review this at least for the high level parts?

I'll try to take a look at it too during the week, perhaps I'll also add a couple of hypothesis tests for pandas roundtrips.

Rebased and addressed comments. I'll merge this once the build looks okay

Can those parameters also be exposed to for example: FeatherReader.read_pandas, read_feather and other functions where it makes sense?

Currently, they are only exposed in to_table itself, and not in methods or functions that use to_table under the hood.
Personally, I would prefer people using feather.red_table(..).to_pandas(..), in which it is explicit which keywords belong to which conversion.
(in pandas.read_feather, that's something else, there it would be nice to have a way to pass through those keywords)
But feel free to open a JIRA issue about it! (I am only one opinion)


SAK-43909 Update oAuth admin styling and rights

Greetings;
I have been working on creating styles for this tool.
I will write down the tasks performed.
In the first place I have eliminated the console error that was produced when trying to load a non-existent file "style.css".
Second, I have formatted the tool's tabs for easier navigation.
And thirdly, I have created styles for the "Add a consumer" view.
I have followed the style of the "Admin Site Perms" tool as it was similar.
The new "css" are in a new file included in the "Library" module; the file is called "_oauthadmin.scss".
Regarding other changes that imply tasks, not styling, in the logic of this tool, another tour ticket can be opened.
Any comment and opinion for improvement will be well received.
Thank you very much.

I had forgotten to remove the  tag, this was causing the AccessLint problem. This ussue has been solved in the commit. I have requested a reevaluation to AccessLint.
Thanks.

The screenshots look good. I'd say it's an improvement :)
One thing I'd suggest is using flexbox instead of those floats. Float is a bit old skool now. Nothing bad about it, just flexbox and grid are the css techniques everybody will be using in future.

Hello, Adrian.
I have made several changes to the commit code.
You can take a look at it when possible.
Thanks again.


Gradle plugin fails due to kotlinx-html-jvm 0.8.0

Expected Behavior
Can build with mavenCentral().
Observed Behavior
> Could not resolve org.jetbrains.kotlinx:kotlinx-html-jvm:0.8.0.
     Required by:
         project : > io.gitlab.arturbosch.detekt:detekt-cli:1.22.0 > io.gitlab.arturbosch.detekt:detekt-core:1.22.0 > io.gitlab.arturbosch.detekt:detekt-report-html:1.22.0
      > Could not resolve org.jetbrains.kotlinx:kotlinx-html-jvm:0.8.0.
         > Could not get resource 'https://kotlin.bintray.com/kotlinx/org/jetbrains/kotlinx/kotlinx-html-jvm/0.8.0/kotlinx-html-jvm-0.8.0.pom'.
            > Could not GET 'https://kotlin.bintray.com/kotlinx/org/jetbrains/kotlinx/kotlinx-html-jvm/0.8.0/kotlinx-html-jvm-0.8.0.pom'.
               > The server may not support the client's requested TLS protocol versions: (TLSv1.2, TLSv1.3). You may need to configure the client to allow other protocols to be used. See: https://docs.gradle.org/7.4/userguide/build_environment.html#gradle_system_properties
                  > Remote host terminated the handshake

Steps to Reproduce
./gradlew detekt
Context
Version 0.8.0 is available: https://mvnrepository.com/artifact/org.jetbrains.kotlinx/kotlinx-html-jvm
Your Environment
plugins {
    id("com.github.ben-manes.versions") version "0.38.0"
    id("io.gitlab.arturbosch.detekt") version "1.22.0"
}

dependencies {
    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.22.0")
}

detekt {
    input = files("$projectDir")
    config = files("$projectDir/detekt.yml")
    parallel = true
    reports {
        xml.enabled = false
        txt.enabled = false
    }
}

Gradle is trying to download the artifact from bintray, not Maven Central.
How are your repositories configured?

The build.gradle file has this:
repositories {
    gradlePluginPortal()
    mavenCentral()
    google()
}

I found the bintray piece here:
@Suppress("UnstableApiUsage")
dependencyResolutionManagement {
    repositories {
        mavenCentral()

        exclusiveContent {
            forRepository { google() }
            filter {
                includeGroupByRegex("androidx\\..*")
                includeGroupByRegex("com\\.android.*")
                includeGroupByRegex("com\\.google\\.android\\..*")
                includeGroupByRegex("com\\.google\\.firebase")
            }
        }

        exclusiveContent {
            forRepository { maven("https://kotlin.bintray.com/kotlinx") }
            filter { includeModuleByRegex("org\\.jetbrains\\.kotlinx", "kotlinx-datetime.*") }
            filter { includeModuleByRegex("org\\.jetbrains\\.kotlinx", "kotlinx-html.*") }
        }
    }
}

Removing the kotlin-html line removes the original error.
However, now I have a new error (not sure if related to the previous fix):
> Run failed with 18 invalid config properties.
        - Property 'style>DataClassContainsFunctions>conversionFunctionPrefix' should be a YAML array instead of a comma-separated String.
        - Property 'style>FunctionOnlyReturningConstant>excludedFunctions' should be a YAML array instead of a comma-separated String.
        - Property 'style>ReturnCount>excludedFunctions' should be a YAML array instead of a comma-separated String.
        - Property 'potential-bugs>MissingWhenCase' is deprecated. Rule deprecated as compiler performs this check by default.
        - Property 'potential-bugs>IgnoredReturnValue>restrictToAnnotatedMethods' is deprecated. Use `restrictToConfig` instead.
        - Property 'potential-bugs>RedundantElseInWhen' is deprecated. Rule deprecated as compiler performs this check by default.
        - Property 'style>ForbiddenPublicDataClass' is deprecated. Rule migrated to `libraries` ruleset plugin.
        - Property 'style>UnnecessaryAbstractClass>excludeAnnotatedClasses' is deprecated. Use `ignoreAnnotated` instead.
        - Property 'style>UseDataClass>excludeAnnotatedClasses' is deprecated. Use `ignoreAnnotated` instead.
        - Property 'potential-bugs>LateinitUsage>excludeAnnotatedProperties' is deprecated. Use `ignoreAnnotated` instead.
        - Property 'formatting>Indentation>continuationIndentSize' is deprecated. `continuationIndentSize` is ignored by KtLint and will have no effect.
        - Property 'style>UnderscoresInNumericLiterals>acceptableDecimalLength' is deprecated. Use `acceptableLength` instead.
        - Property 'style>LibraryCodeMustSpecifyReturnType' is deprecated. Rule migrated to `libraries` ruleset plugin.
        - Property 'complexity>ComplexMethod' is deprecated. Rule is renamed to `CyclomaticComplexMethod` to distinguish between Cyclomatic Complexity and Cognitive Complexity.
        - Property 'formatting>ParameterListWrapping>indentSize' is deprecated. `indentSize` is ignored by KtLint and will have no effect.
        - Property 'style>LibraryEntitiesShouldNotBePublic' is deprecated. Rule migrated to `libraries` ruleset plugin.
        - Property 'style>FunctionOnlyReturningConstant>excludeAnnotatedFunction' is deprecated. Use `ignoreAnnotated` instead.
        - Property 'potential-bugs>DuplicateCaseInWhenExpression' is deprecated. Rule deprecated as compiler performs this check by default.

Is it related to the kotlin-html or another problem?

That's a different error. If you need help configuring detekt itself please open a discussion and someone will be able to help you out, thanks!


Key name string vs. value string

I don't know if this is solvable in the existing solution somehow, but when you transverse a token array, how do you distinct between a key name and a value string?
It's fairly important when searching for a given key, that you don't mistake a "value" for a key name.
I propose that the JSMN_STRING be divided into a JSMN_KEY and a JSMN_STRING_PRIMITIVE. (Or something like that.)

Bitbucket: https://bitbucket.org/zserge/jsmn/issue/23
Originally reported by: illishar
Originally created at: 2014-02-18T17:01:40.755

Thanks for your contribution! Normally, I process key/value pairs by odd/even positions inside the object. I like the separate token type for keys more than what was proposed earlier, most likely I'll implement it this way soon. Again, thanks for helping jsmn! I will mark this issue as duplicate to keep things in a single place.

Original comment by: Serge Zaitsev

I've attached a sample of how it could be done. It only takes a very small change in the parser.
jsmn with KEY/VALUE
PS. The sample is based on the sample from issue #10.

Original comment by: illishar

Duplicate of #11.

Original comment by: Serge Zaitsev