fix(rest)!: Fix Basic OAuth2 queues and add method for updating the queues and ratelimit paths after a refresh

This pull request addresses 3 issues:

Fixes #3165, with the updateTokenQueues method to be called by the user-code to update the queues with the new token
Fixes a bug where Basic request got stuck in an infinite ratelimit
Fixes #3137 as with every ratelimit information (queue and rateLimitedPaths) being prefixed by the authorization they refer to a rest proxy can handle more then 1 bot token at once

The PR looks good, please have this tested properly before merging but the general idea looks good to me

I'm currently running this pr in production, atm i do not have something that uses OAuth ready to test this on (but the test scripts i made while making the code changes are working fine).
If someone wants to test the pr for themself (with or without OAuth2 related code/requests) that would be appreciated

LGTM! You mentioned that you disabled auto-merge so this can be tested a bit more before merge, it's been a month so what do you think?

Didn't had the time to setup the stuff i need for the OAuth2 testing, but the bot auth is working on my prod bot. If i can today i will test it and enable auto merge accordingly

Re enabling the auto-merge as from my testing I did today it seems to be fine. It does carry over the ratelimit from the previous queue and it does change the auth header preventing the 401


Deprecate brew cask cleanup.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

Depends on https://github.com/Homebrew/brew/pull/4639.

LGTM, but for feature parity brew cleanup would need to autocomplete Casks.

I removed the completions for brew cask cleanup, I'll have to leave the rest up to the people actually using bash/zsh.


Swagger operations do not work in production

None of the operations work in the hosted/production app. All responses appear as follows:

It's not working in my local either.

Productive day on this task, I think I have figured this out, at least in my local.


Selected page does not appear actively in the menu.

Firstly, very nice job. Thank you much.
My issue,
When Turkish language is selected, sidebar menu active page does not appearing. But other languages working

Can you help me?
Thanks...

Hi @onurcanyilmaz
I can't reproduce your issue, it worked well on my computer:

Recently, I publish a new package that support the latest ABP version(v2.8).
Try it to see if the issue still exists.

Hello again @wakuflair ,
Sorry, what I would like to say, left  nav bar not showing  active page
Look at pictures please
not show active page in tr:

showing other languages active page:

Turkish language is not working.
thanks a lot

Hi @onurcanyilmaz
It's a string comparision bug, I have fixed it.
Thank you for your feedback!


RuntimeError: stack expects a non-empty TensorList

Hi! First of all, thank you for uploading the source code
When i try Train the duration extraction model, i had error at this code
            spec = self.collate.norm.inverse(out[-1:]) # TODO: this fails if we do not standardize!
            sound, length = self.collate.stft.spec2wav(spec.transpose(1, 2), slen[-1:])

    torch.nn.utils.clip_grad_norm_(X, 1)

Please give me solution

Did you train with default settings or did you introduce some changes?

Did you train with default settings or did you introduce some changes?

I trained defalut setting
Just changed git repo because of error

What do you mean by changed repo?

What do you mean by changed repo?

Like this

Did you train with default settings or did you introduce some changes?

I tried to original code, but i had same error TT


Create TADA.MonitoringLocationIdentifier in TADA_AutoClean

Is your feature request related to a problem? Please describe.
TADA.MonitoringLocationIdentifier is needed to group nearby sites. This column should be referenced in all TADA functions instead of  the original MonitoringLocationIdentifier.
Describe the solution you'd like
Create TADA.MonitoringLocationIdentifier as an exact copy of the original MonitoringLocationIdentifier as part of TADA_AutoClean.
Additional context
Related issue: https://github.com/USEPA/TADA/issues/475
Reminders for TADA contributors addressing this issue
New features should include all of the following work:

[ ] Create the function/code.

[ ] Document all code using comments to describe what is does.

[ ] Create tests in tests folder.

[ ] Create help file using roxygen2 above code.

[ ] Create working examples in help file (via roxygen2).

[ ] Add to appropriate vignette (or create new one).

Should we also be thinking about adding a TADA.MonitoringLocationName column? I haven't run into this yet, but I am wondering if having two (or more) different MonitoringLocationNames for the same TADA.MonitoringLocationIdentifier (when sites have been grouped and given a concatenated identifier) will cause any problems with labeling figures.

Yes, I was ruminating about this over the weekend. How should we handle MonitoringLocationName MonitoringLocationTypeName, LatitudeMeasure, LongitudeMeasure (we already have a TADA version of lat/lon but which do we use for maps once the sites are grouped?) and any other site metadata that TADA will rely on later in the workflow for figures/analyses... ? It probably does make sense to have a TADA version of all of these that would be updated as part of the nearby sites function.
It would be helpful to look at some examples with our current figure/map functions & think through how best to handle this.
In the case where metadata for both sites are the same that is easy, we could copy it to the TADA version of those columns. I am not sure what we'll want to do if they are different: 1) user chooses which one to keep? 2) concatenate, 3) include a flag that notifies user if they are different?

For differing metadata, one idea I had was to use an org hierarchy like in TADA_FindPotentialDuplicatesMultipleOrgs. This would allow users to prioritize retaining metadata from their own org in cases where the nearby site paired was from a different org. In the case of nearby sites from the same org, the default selection could be made based on ActivityStartDateTime (default to either oldest or most recent), number of results (metadata associated with most results would be selected), or metadata could be selected randomly.
I think a flag would be useful. If we did use some default way of selecting the metadata, the flag could both notify the user they were different and explain which selection had been made.

Currently, if a TADA df has already had TADA_FindNearbySites run (and site groupings were found) and you try to run it again, there will be an error because there are duplicate TADA.MonitoringLocationIdentifiers after you have filtered for unique combinations of TADA.MonitoringLocationIdentifier, TADA.LatititudeMeasure, and TADA.LongitudeMeasure. I think that standardizing the metadata will resolve this issue as well.


Put lr outside momentum for sgd and nag

Description
Change the implementation of momentum SGD and NAG. Specifically, The original implementation is correct but not consistent with Pytorch and TF.
See #15533
@zhreshold can you see how many CV models need to be retrained with the change?

If both sgd and nag are going to be modified the all models in gluoncv are required to explore new hyperparameters.
Is it sensible to keep the original versions with the new implementation renamed?

I think it would be ambiguous. It is better to only keep one.
On Mon, 11 May 2020 at 19:47, Joshua Z. Zhang<EMAIL_ADDRESS>wrote:

If both sgd and nag are going to be modified the all models in gluoncv are
required to explore new hyperparameters.
Is it sensible to keep the original versions with the new implementation
renamed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/18285#issuecomment-627075521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6GZVCKLGRZLDOGCWYCDC3RRC2FNANCNFSM4M6MUR6A
.

If all models need to be retrained, I think it is better to keep the
current implementation.
On Mon, 11 May 2020 at 19:49, Shuai Zheng<EMAIL_ADDRESS>wrote:

I think it would be ambiguous. It is better to only keep one.
On Mon, 11 May 2020 at 19:47, Joshua Z. Zhang<EMAIL_ADDRESS>wrote:

If both sgd and nag are going to be modified the all models in gluoncv
are required to explore new hyperparameters.
Is it sensible to keep the original versions with the new implementation
renamed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/18285#issuecomment-627075521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6GZVCKLGRZLDOGCWYCDC3RRC2FNANCNFSM4M6MUR6A
.

On one hand, there are existing MXNet models which would require hyperparameter tuning to be done again if this change is implemented.
On the other hand, being inconsistent with PyTorch and other deep learning frameworks makes it harder to port models and the subtle differences might result in slight differences in performance.
Even though having an additional flag to switch between old and new behaviour definitely adds to complexity, I am not sure that it is not worth it.

Since the change is to mxnet 2.0 where gluoncv is expected to adopt the new numpy-based API, it's expected that model will need to be retrained. Let's merge this change on in 2.0 dev branch and keep it out of 1.x


libfrozen: init 1.1.1

Packages a C++ library for constant time evaluation containers
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Any chance of getting the tests running?

A naive attempt runs into https://github.com/serge-sans-paille/frozen/pull/130#issuecomment-1163649783 for me.
My concern is that this being a header-only library, all the package is doing is copying a bunch of files and we have no assurance it works.

Closing due to no OP response. Feel free to ask to reopen. As for the commit log, it should be:
maintainers: add jstranik
libfrozen: init at 1.1.1


Build on Windows using MSYS2

It possible to compile splitsh on Windows using MinGW.
Follow these steps to prepare MSYS2 enviroment:
https://github.com/libgit2/git2go/pull/307
After you will be able to follow standart installation processin MSYS2 bash console:
https://github.com/splitsh/lite#installation

Closing this issue as I don't think there is anything to do on our side.


Pattern programs in java

Aim
-we generally saw most of the pattern problems are solved using 1shape joining two shapes in
Details

we generally saw most of the pattern problems are solved using 1shape but in this we are joining two shapes and make a different pattern

Programming language

[ ] C
[ ] C++
[x] Java
[ ] Python

@Ayush7614  assign me this issue under LGM-SOC'21.

I am a LGM-SOC'21 Participant and want to write c++ solution to it.

Go Ahead @SamikshaSankar @palakagarwal5230

Hello sir i am a LGM-SOC participant i want to solve pattern problems using java can i go for it ?? @Ayush7614

@SahityaRoy Java is already assigned. U can choose any other language

Aim
-we generally saw most of the pattern problems are solved using 1shape joining two shapes in
Details

we generally saw most of the pattern problems are solved using 1shape but in this we are joining two shapes and make a different pattern

Programming language

[ ]  C
[ ]  C++
[x]  Java
[ ]  Python

@Ayush7614 assign me this issue under LGM-SOC'21.

I am a LGM-SOC'21 Participant and want to write solutions in C language to it. Please assign me this.

okay then C programming
On Wed, Jun 9, 2021 at 1:58 PM Mitali Agrawal @.***>
wrote:

Aim
-we generally saw most of the pattern problems are solved using 1shape
joining two shapes in
Details

we generally saw most of the pattern problems are solved using
1shape but in this we are joining two shapes and make a different pattern

Programming language

C
C++
Java
Python

@Ayush7614 https://github.com/Ayush7614 assign me this issue under
LGM-SOC'21.
I am a LGM-SOC'21 Participant and want to write solutions in C language to
it. Please assign me this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ayush7614/Daily-Coding-DS-ALGO-Practice/issues/188#issuecomment-857496808,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLSWZHGNWTK3EGQOZXGTXDTR4QZJANCNFSM46J3ZOTQ
.

@Amit366  then I wll upload in c programming

@Amit366 then I wll upload in c programming

@SahityaRoy can you please do it in python if you don't mind because as you see I had already requested to code for this problem in C language?

@mitali-1703 @SahityaRoy can u please finalize which language u wanna do

@mitali-1703 @SahityaRoy can u please finalize which language u wanna do

I want to do in C language please assign me this for C language.

@mitali-1703 @SahityaRoy can u please finalize which language u wanna do

if @mitali-1703 wants to contribute in c then i have to contribute in python

@mitali-1703 @SahityaRoy can u please finalize which language u wanna do

if @mitali-1703 wants to contribute in c then i have to contribute in python

Thanks @Amit366


Fix doc comment about onPressed for IconButton

Do any of the other buttons have this bogus text?

Yeah, looks like there are more buttons, who have a similar doc comment. Working on including those in this PR.

Updated all the other buttons that had the bogus text.


[SPARK-19853][SS] uppercase kafka topics fail when startingOffsets are SpecificOffsets

What changes were proposed in this pull request?
When using the KafkaSource with Structured Streaming, consumer assignments are not what the user expects if startingOffsets is set to an explicit set of topics/partitions in JSON where the topic(s) happen to have uppercase characters. When StartingOffsets is constructed, the original string value from options is transformed toLowerCase to make matching on "earliest" and "latest" case insensitive. However, the toLowerCase JSON is passed to SpecificOffsets for the terminal condition, so topic names may not be what the user intended by the time assignments are made with the underlying KafkaConsumer.
KafkaSourceProvider.scala:
val startingOffsets = caseInsensitiveParams.get(STARTING_OFFSETS_OPTION_KEY).map(_.trim.toLowerCase) match {
    case Some("latest") => LatestOffsets
    case Some("earliest") => EarliestOffsets
    case Some(json) => SpecificOffsets(JsonUtils.partitionOffsets(json))
    case None => LatestOffsets
  }

How was this patch tested?
Jenkins

Test build #74205 has started for PR 17209 at commit e2a26bf.

Test build #74205 has finished for PR 17209 at commit e2a26bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74205/
Test PASSed.

Test build #74237 has started for PR 17209 at commit 9402f9d.

cc @zsxwing

Test build #74237 has finished for PR 17209 at commit 9402f9d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74237/
Test PASSed.

Test build #74291 has started for PR 17209 at commit a37d11d.

Test build #74291 has finished for PR 17209 at commit a37d11d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74291/
Test PASSed.

Could you add a utility method like this?
  def getKafkaOffsetRangeLimit(
      params: Map[String, String],
      key: String,
      default: KafkaOffsetRangeLimit) : KafkaOffsetRangeLimit = {
    params.get(key).map(_.trim) match {
      case Some(offset) if offset.toLowerCase == "latest" => LatestOffsetRangeLimit
      case Some(offset) if offset.toLowerCase == "earliest" => EarliestOffsetRangeLimit
      case Some(json) => SpecificOffsetRangeLimit(JsonUtils.partitionOffsets(json))
      case None => default
    }
  }

Then you can reuse the method and only test it, e.g.,
    val startingOffsets = getKafkaOffsetRangeLimit(
      caseInsensitiveParams,
      STARTING_OFFSETS_OPTION_KEY,
      EarliestOffsetRangeLimit
    )

    // Batch specific options
    startingOffsets match {
      case EarliestOffsetRangeLimit => // good to go
      case LatestOffsetRangeLimit =>
        throw new IllegalArgumentException("starting offset can't be latest " +
          "for batch queries on Kafka")
      case SpecificOffsetRangeLimit(partitionOffsets) =>
        partitionOffsets.foreach {
          case (tp, off) if off == KafkaOffsetRangeLimit.LATEST =>
            throw new IllegalArgumentException(s"startingOffsets for $tp can't " +
              "be latest for batch queries on Kafka")
          case _ => // ignore
        }
    }

@zsxwing done，but forgot to push，I will update it as soon as possible when I connect to internet.

Test build #74380 has started for PR 17209 at commit 50ef0e1.

Test build #74380 has finished for PR 17209 at commit 50ef0e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74380/
Test PASSed.

Test build #74399 has started for PR 17209 at commit be9f87e.

Test build #74399 has finished for PR 17209 at commit be9f87e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74399/
Test PASSed.

Thanks. Merging to master and 2.1.


Compiler hangs with invalid object return type and string interpolation

When a function has a custom object type definition and it contains a string interpolation value the compiler hangs with no output.
To replicate:
export function example(): { id: string } {
  return { id: `` };
}

It doesn't matter what is inside of the string, as long as it contains the string definition with the back-ticks it'll hang.
The string definition doesn't need to be inside a variable definition or in the return statement, the following will still cause the issue:
export function example(): { id: string } {
  ``;
  return { id: "" };
}

When removing the back-ticks the compiler stops and outputs the error as expected:
ERROR TS1110: Type expected.

 export function example(): { id: string } {

 in tests/helpers/example...

This doesn't appear to be an issue in newer versions of the AssemblyScript compiler, upgrading it will likely solve the issue


Make use of GitHub Actions environment files

set-output was previously used to create the IT matrix, but it is now deprecated. So, this change makes use of the environment files instead.
See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files

I'm troubleshooting an error that seems to be a data type issue:
Error when evaluating 'strategy' for job 'mvn'. .github/workflows/maven-full-its.yaml (Line: 88, Col: 15): Error parsing fromJson,.github/workflows/maven-full-its.yaml (Line: 88, Col: 15): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/maven-full-its.yaml (Line: 88, Col: 15): Unexpected type of value '', expected type: Mapping.

It looks like GitHub is parsing environment variables as String types, and I can't seem to convert it to a "Mapping" type.

Ignore my previous observations. I forgot to update the job output mapping to reflect the new step output name. I'm testing now, but I think the current bits will work.

Okay, got it working. Apparently, you're not supposed to quote the output value, but leave the raw JSON... which is weird, because it makes an invalid environment variable assignment in a shell script... but apparently that's what it wants.


#417 Update to Vert.x 4

This is not supposed to be merged.
The idea is to create a separate branch upstream calle vert.x-4.

I've removed the workflow for the latest Vert.x sql client 4 because it causes some error

@DavideD so Vert.x 4 has a whole different approach to to managing transactions?

It seems so, the Transaction is not a SQLClient anymore so you cannot return it like we did before.
To be fair, I put together this fix quite quickly and I have to give it a better look, but I think it could work for an initial branch

Also beginConnection() returns a Future<Transaction> instead of a Transaction. It makes sense to me but I'm wondering if we should should change our SQLClientConnection#beginTransaction() to return a CompletionStage<Transaction> instead of CompletionStage<Void>. Just a feeling. That's what I would expect by looking at the method for the first time.
But I'm surprise and quite happy to see that all the tests pass with this simple patch.

+1 to track Vertx.next , but remember to keep these dependencies in synch with what's in Quarkus.

Sure, we don't plan to include this in the main branch for now.

It's seems everybody is cool with this, I'm going to push it upstream

upstream? in its own branch?

Yes

Branch created upstream


fix typo in SE-0395

I'm not sure this fix is correct, but current code snippent is wrong.

I think Philippe fixed this as part of revising the proposal; closing, but please verify.


CAMEL-11456: Make the camel-grpc component more cloud service friendly

@nicolaferraro , could you please to look at this PR. I've changed an URI format to be component consumer and producer more cloud service friendly. Thank you.

Sure, will have a look at it tomorrow!

@nicolaferraro , I've changed code according your recommendations (try to remove potential problems with default package .proto). Please look at PR again. Thank you.


Jkulhanek/colmap dataparser

This PR implements a dataparser to load the COLMAP sparse model directly without the need to run ns-process-data.

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

create colmap model
downscale images
export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).
This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

create colmap model
downscale images
export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).
This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

Wouldn't this conflict with users that use non-colmap ns-process-data pipelines? It seems like many people use metashape or realitycapture.

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

create colmap model
downscale images
export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).
This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

Wouldn't this conflict with users that use non-colmap ns-process-data pipelines? It seems like many people use metashape or realitycapture.

Yes, let’s keep the default then. I didn’t know many people used non colmap pipelines and it would make it more difficult for them.


Heavy lag at random running times

Hyprland Version
Hyprland, built from branch  at commit 942172d2dc9194b95d637283ec3338c06c9c6597  ().
Date: 2024-04-05
Tag: , commits: @COMMITS@
flags: (if any)
Bug or Regression?
Bug
Description
At random times hyprland clog up all VRAM and start wild lags of desktop, games and applications
How to reproduce
I don't know how to reproduce it. I'm just working and it starts lagging. On v0.34 I never had this problem before
Crash reports, logs, images, videos

After rebooting and launching the same applications that were previously running:

Video: https://youtu.be/D9sv19-Sllo

Maybe #5426 , have you tried the latest -git version?

yea as above

Fixed in 0.38.1


Warn if user is trying to delegate to a jailed validator

Feature request:
If a delegator is trying to delegate to validator that is jailed, we should warn the user.

nice idea.

@jbibla thank you! I think it needs to get spec-ed out a bit better.

what do you mean exactly? on our end, we can just add a warning for our users. delegating to a jailed validator isn't necessarily bad .. assuming they unjail themselves soon? is it?

@jbibla We used to not allow this in code, but there is no in protocol reason to not allow delegation to a jailed validator. I think the usecase would be to delegate to a validator who is going to be unjailed soon.
We should however notify the users if they are trying to do this to make sure its what they want.

thanks for the clarification. we'll do this!

this is still worth implementing.


npm start fails

ERROR in ./~/css-loader!./~/sass-loader!./index.scss
Module build failed:
@import "../main";
^
      File to import not found or unreadable: ../main.
Parent style sheet: stdin

This is failing because of an incorrect path. The correct path is @import "../src/main.scss";, not @import "../main.scss";I can submit a PR to fix this.

**Should also note that the showcase styles are off for the custom radial radius chart

You didn't build.

We should also address the incorrectly positioned radial chart

Don't think it's really related, we should open another issue

To prevent issues like this in the future, should we add the build step to the npm start script?

Hum I don't think so, the change of import you did in the stylelint pr should be good


VSCode print error when running

[10:31:18] Error: E:/work/electron/vscode/extensions/css-language-features/server/src/pathCompletion.ts(111,18): Argument of type 'string
| undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
[10:31:18] Error: E:/work/electron/vscode/extensions/html-language-features/server/src/modes/pathCompletion.ts(74,18): Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
I don't know the reason, please help me, thx.

@sunshine001 What's the path completion that you are trying to trigger?


Update libraries to LTS 2.0 version.

Update libraries to LTS 2.0 version, including:

FreeRTOS kernel
coreMQTT
coreMQTT-Agent
coreJSON
corePKCS11
backoffAlgorithm
ota-for-aws-iot-embedded-sdk
Device-Defender-for-AWS-IoT-embedded-sdk
Device-Shadow-for-AWS-IoT-embedded-sdk
FreeRTOS-Integration-Test

Update libraries to LTS 2.0 version, including:

FreeRTOS kernel
coreMQTT
coreMQTT-Agent
coreJSON
coreHTTP
corePKCS11
backoffAlgorithm
ota-for-aws-iot-embedded-sdk
Device-Defender-for-AWS-IoT-embedded-sdk
Device-Shadow-for-AWS-IoT-embedded-sdk
FreeRTOS-Integration-Test

Does this merge include coreHTTP?

Update libraries to LTS 2.0 version, including:

FreeRTOS kernel
coreMQTT
coreMQTT-Agent
coreJSON
coreHTTP
corePKCS11
backoffAlgorithm
ota-for-aws-iot-embedded-sdk
Device-Defender-for-AWS-IoT-embedded-sdk
Device-Shadow-for-AWS-IoT-embedded-sdk
FreeRTOS-Integration-Test

Does this merge include coreHTTP?

No, it's not included. Remove wrong description.

Why are we changing the unix permission of .sh files from 755 to 644? Also, I am curious about the priorities maximum limit

Fixed. Thanks!


show drafts when config variable drafts is set to true, hide otherwise

This resolves #221 by simply using a drafts boolean value in config.
config.php
<?php

return [
    ...
    'drafts' => true,
    ...
];

config.production.php
<?php

return [
    ...
    'drafts' => false,
    ...
];

So, now when you run jigsaw build production, drafts  inside _drafts subdirectory are not included in collections and also not compiled to static html. While, when you run jigsaw build or jigsaw build local all your drafts inside _drafts are include and compiled to static html.
Please review this, and let me know if I can improve this. I am not very good at testing, so please bare me with this if I did something stupid. :sweat_smile:

I wonder if this would be easier if it were based on a date Front Matter variable?
For example, what I always do in Laravel for drafts, is that instead of adding a draft or published column in the database, I work with the date directly.
Here's an example scope on the model in Laravel:
/**
 * Query scope for limiting the results to published posts only.
 *
 * @param Builder $query
 * @return Builder
 */
public function scopePublished(Builder $query)
{
    return $query->where('published_at', '<=', Carbon::now());
}

The reject() method could do something similar. This way, you'd only need to add a date: YYYY-MM-DD Front Matter key to your post/page, no need to create a folder with a name that is hardcoded in core. And you wouldn't need a drafts key either.
What do you think?

But that way, you'd need to build every next time to include the posts which are due for publishing. But still, a clean approach in my mind, you dont have to maintain _drafts folder.

Hey @hellocosmin, shall I make some changes to this PR?
Maybe @damiani has something to say about this. We can discuss a little about how you really want to implement this feature of drafts or publishing. I'll be happy to help. :slightly_smiling_face:

I  have resolved the merge conflicts, and I guess its now ready to merge.

This PR assumes you're using Jigsaw in a specific way. I'd rather see this as some additional layer on top of Jigsaw instead of built-in.

@m1guelpf is right, drafts seem very blog-specific. You wouldn't use them in, say, a docs project.

Hmm.. @m1guelpf you're right. This PR needs more work.
One of the nice approach seems to be the one suggested by @camuthig here.
Is this the right way to go about it? I would like to know what people have to say regarding this approach. I'd start working in this direction if this one seems acceptable.
Is it wise to submit another PR and close this one, or just modify this one?

@rumansaleem I pushed the code that I was using to test locally to a branch https://github.com/camuthig/jigsaw/commit/b254fcce9158f80e677200b6a3b14596bd5d8ae1 if you want to take a look at what I was doing to make it work. Seeing as there has been a good deal of back and forth on how this functionality should be implemented, I thought it would be better to allow the discussion in the issue to finish prior to creating another PR that conflicted with this one.

thanks, I'll take a look.

Addressed by https://github.com/tightenco/jigsaw/pull/379


Configuring WiFi transport for Portenta H7

Hi, I'm aware that I'm asking a lot of questions here. Sorry. I'm happy to organize whatever answers I receive here and make a tutorial writeup for the community.
I'm a bit stuck on getting the WiFi transport working for the Portenta board. How can I adjust the steps from this guide to work with the Arduino precompiled library?
I imagine I would need to make an adjustment to the library_generation.sh file, but I'm not sure what.
Thanks in advance for any and all help, you guys rock!

Hello @avielbr, I guess that you do not need to rebuild the library for changing the transports. Just use the correct function to set the transports: https://github.com/micro-ROS/micro_ros_arduino/blob/dc99a9f3663fab6ec5ff809a6b5310e0e40e4130/src/micro_ros_arduino.h#L119
Let us know if this works

Thanks @pablogs9, this does work. I switched networks and this worked right away - guess there is something weird in the configuration of the first network I tried.
Have a good one.


What is the training preprocess data for WordNet only/WordNet +SemEval

It makes me really confused when I try to do with the semEval .
For wordNet only,  I used valname = dev_wnbo_hyper, model_prefix_file = 3in1_subseqFeat
For wordNet+SemEval, I used valname = dev_twodatasets, model_prefix_file = twodatasets_subseqFeat.
Am I doing right?
By the way, why is dev_twodatasets so big compared to dev_wnbo_hyper. And how do you generate it?

I think you are. Because SemEval taxonomies are larger (n^2 pairs).


hi,bro,Lumberjack and mining change to use scroll  ？

Lumberjack.razor
mining.razor
if skill 'magery' >= 60
overhead 'Time to leave!' 34
sysmsg 'Lumberjack -> Recall to Inn!' 44
@setvar! isActive 0
script 'RecallInn'
endif

Hey @kevinchow9527, you can feel free to open a pull request if you have working changes you'd like to add


[Fix #9449] Fix an error for Style/NilComparison

Fixes #9449.
This PR fixes an error for Style/NilComparison when using x == nil as a guard condition'.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!

Thanks!


Update _config.yml

Nice to see the template being used by others 😃 (no worries about stray PRs, happened to us all 😉)

Hahahaha! Pretty nice tool. Sorry for the continuous PRs.


Cherrypick to v42 duke: MULE-16451: PR 387 shared-resources

testing cherry pick
git commit -am 'cherry pick PR 387: MULE-16451: Create XML for shared resources'

closing test


cusor postion

Problem with input, characters getting added at end  when edited codesandbox
Steps to reproduce:

Enter some text in email input filed hit enter.
Enter password hit enter.
Choose between some characters  with mouse on email field and enter text it appends text at end .

Thanks In Advance

Hello @charithreddyv,
I was not able to reproduce this issue. Here's what I got:

Regards,
Francisco Hodge

@hodgef Thanks for the quick response,   please use this  codesandbox is the same example as above but in ts . i was able to reproduce it when use a half screen (by covering half screen) i am using this package on a electron app which will be half screen (minimized) by default

I am able to reproduce it by doing something like this on browser app
When i try to add i in between uu it is getting appended at the end
Thank You In Advance

Hey @charithreddyv,
I cannot reproduce this on any of the links you've provided. Can you reproduce this in your browser?
If you see this issue only on Electron, can you provide an Electron test repo so I can verify?
Regards,
Francisco Hodge

Hai @hodgef ,
As weird as it way sound i am able to reproduce it on chrome and firefox when the email text field is scrolled up (blocked by view ) this thing happens on the same url i pasted earlier i adjusted chrome devtools so when keyboards pops and  it is moving the text field to the top .

This gif must give you and idea what i am talking about,
Thank's again for very fast response .

Hey @charithreddyv, thank you for the additional details. I think this is a simple-keyboard bug. I'll fix it asap

Hello @charithreddyv,
After looking at this issue more closely, I think a potential fix for this edge case is probably not worth it.
Basically there were two issues in the sandbox:

inputName was being set to an empty string, which is not a supported value. I commented that part. (FYI: whenever inputName changes, the caret position is reset).

Edge case: When you click on your input, it goes off screen (as the keyboard appears) and the mouse is therefore released outside of the input. simple-keyboard's caret position handler is called on mouseup and checks if the target is an input (that's where it will get the caret position from). Since your input is now off screen, the mouseup target will be something else and caret position never updates.

A workaround for item #2 is to delay the opening of the keyboard to allow the mouseup to happen before the input moves.
I could fix this internally but that would imply listening to all document mousedown and I don't think this edge case warrants it.
Here's the updated sandbox with workarounds added:
https://codesandbox.io/s/ts-react-simple-keybaord-forked-lkg4y?file=/src/index.tsx
Thanks,
Francisco Hodge


Cloudstack management does not display the list of instances

ISSUE TYPE
ٍerror
CLOUDSTACK VERSION
4.17.2
OS / ENVIRONMENT
Centos 7
SUMMARY
Cloudstack management does not display the list of instances. Before this, it took 5 to 6 minutes for the list of instances to be displayed, but after a while, it no longer displays the list of instances, and it is no longer possible to create instances and manage other instances.
output log:
2023-09-24 15:05:22,344 INFO  [c.c.a.ApiServer] (qtp1750498848-5439:ctx-4b95c022 ctx-928448ba ctx-ff40e3d9) (logid:87dee968) Unable to execute API command queryasyncjobresult due to invalid value. Invalid parameter jobid value=774200c9-e75d-4d18-ba82-bf0bb90d615d due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.
2023-09-24 15:05:26,790 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-125:ctx-d5279c50) (logid:cd5a5b12) Unable to find matched VM in CloudStack DB. name: 8abd3fd1ac473467b651dc3e20df41b3
2023-09-24 15:05:34,336 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-51:ctx-347798ab) (logid:1f20faab) Unable to find matched VM in CloudStack DB. name: a76b8be0c4a83200868ed6676c55dccf
2023-09-24 15:05:34,433 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-271:ctx-16400aef) (logid:a2670b14) Unable to find matched VM in CloudStack DB. name: r-2241-VM-Clone
2023-09-24 15:14:01,005 WARN  [c.c.a.d.ParamGenericValidationWorker] (qtp1750498848-23:ctx-704967ba ctx-3d1f471e) (logid:062fb493) Received unknown parameters for command listZones. Unknown parameters : listall
2023-09-24 15:14:10,328 WARN  [c.c.a.ApiServer] (qtp1750498848-16:ctx-160c1a8f ctx-9bbfc372) (logid:e3f747ec) Unknown API command: listAndSwitchSamlAccount
^C

@Hossein4185  can you share the steps to reproduce the issue?

I click on compute > Instances and it doesn't show any instance. Of course, before this, when I was doing these steps, it took a few minutes to show, but now it doesn't show anything.

I tested this command in cloudmonkey but show nothing
'list virtualmachines listall=true '

@Hossein4185 does this account have (own) any instances? And while listing virtual machines API, do you see any errors or exceptions in the management server logs?

Pasting the same comment as in the other ticket.
if possible can you try restarting the management server. Log snippet does nt look like there is an issue with DB, but you can also try restarting the mysql service.

I truncated the vm_state table and solved the problem.


fix severity comparison issue in logger

WHAT

Fix severity comparison issue in Logger class.

WHY

to output log messages when the severity is higher than the logging severity, properly.

Tested this patch, locally and manually.
and it works! 🙆🏼♂


Changes to 'mating'

The term 'mating' (GO:0007618) , definition: "The pairwise union of individuals for the purpose of sexual reproduction, ultimately resulting in the formation of zygotes." means to capture both unicellular mating (or conjugation) as well as animal mating behavior, but these are unrelated processes that should not be grouped together.
Changes:

[x] GO:0007620 copulation -> remove GO:0007618 ! mating; add is_a: GO:0007617 ! mating behavior
[x] GO:0007617 ! mating behavior: removed logical definition, was 'GO:0007610 ! behavior part_of GO:0007618 ! mating'
[x]  GO:0034607 turning behavior involved in mating: removed logical definition, was GO:0035178 ! turning behavior
part_of GO:0007618 ! mating

[ ] Next, need to improve definition of 'mating' to be specific to unicellular organisms

@ValWood

(note that this is needed to improve the 'conjugation' branch , see https://github.com/geneontology/go-ontology/issues/22916)

Annotations are here: GO:0007618 mating

@ValWood


fix: Added "children" to autocomplete list for multiTree and singleTree widgets

Description
Added "children" to autocomplete list for multiTree and singleTree widgets
PR fixes following issue(s)
Fixes #23641

Media

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[x] Manual
[ ] Jest
[x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=43099bd

@arunvjn QA Done on DP. Working as expected


Add GAE platform detection

I also removed the local debugger config, which didn't make much sense to me.

Closing in favor of #73


⚠ Turnos 24x7 has degraded performance

In e1a663f, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: Turnos 24x7 performance has improved in 9ba1b0f.


EMV -> EVM

What changed? Why?
Notes to reviewers
How has it been tested?

Review Error for mcdcb @ 2023-10-19 14:39:23 UTC
User must have write permissions to review


Update “caniuse” data with npx update-browserslist-db@latest

Just another console warning that popped up today
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

We apply these data-specific browserslist queries to Autoprefixer but our data is from November 2022
> 0.1%
last 2 Chrome versions
last 2 Firefox versions
last 2 Edge versions
last 2 Samsung versions

This PR runs npx update-browserslist-db@latest as suggested
Should browser data freshness be an automated test or release checklist item?

And yeah, if we could automate it easily, I don't see why not.

Not for now, but knowing that browser data will affect "the build" (polyfills dropped, prefixes removed, more agressive minification) it probably needs a scheduled GitHub Actions at some point—bit like Dependabot
For now, think we need docs changes?
For example we say to run nvm use to make sure Node.js is up to date
But the browser data could be 5+ months old

Yeah, let's put a line into the release docs - pretty easy to do manually till we automate.

Yeah, let's put a line into the release docs - pretty easy to do manually till we automate.

@domoscargin I've added a line to the publishing instructions 😊


⚠ Bofrost.de has degraded performance

In 382e138, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1594 ms

Resolved: Bofrost.de performance has improved in 8416adb after 9 minutes.


Fix tests and other minor changes

Tests were failing. These changes should hopefully fix them. Also, moved gcsrunc state from /var/lib to /var/run.

@beweedon,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Problem with iOS 9.3 beta

ios-ntp is not performing correctly with the iOS 9.3 public beta.

what problem are you dealing?

I don't know what the cause is, but all the associations become invalid quite quickly.  The software won't let the number of associations drop below eight, but even those eight are invalidated over and over again.  There may be networking changes that impact CocoaAsyncSocket so I'll check any new code over there later today.

:( Any luck @gavineadie?

The cause is that the iOS clock is already so close to true time that the small variations in any association's sampling actually have a relatively small average and large standard deviation.  For example, three samples, in microseconds are: 8.8, -3.5 and -1.6 which gives an average of 1.2 mSec within a SD of 5.4 mSec.
The association rejection criteria include requiring that the SD of samples be small compared to the average .. you can see this make sense if the clock time is not accurate (more than, say, ~20 mSec off true), but it breaks down if the clock is already accurate.
This library has lost its value as iOS has matured!  iOS now uses NTP internally, so it keeps good time.  This library is still useful for detecting a deliberate manual resetting of time to an incorrect value for nefarious purposes (which, I suspect, is its main use anyway).

@gavineadie It's also still useful to track time to some internal NTP server that gets a time value from something else. i.e. the space industry.

@gavineadie Interesting! I had no idea. I'm one of those people using NetAssociation it to prevent clock manipulation ;) Does iOS expose that NTP time (before it's offset by the user) anywhere?

@bassrock .. NTP could certainly be used to distribute time from private servers slaved to extraordinary sources, perhaps for simulations in which multiple computer need to behave as if they were operating in the past or the future.
@warpling .. no, iOS does not reveal anything about how time is derived and maintained.  I've lobbied Apple for a "CoreTime" framework like "CoreLocation" without success (I believe a CoreTime framework does exist but is private to Apple with unknown functionality).  Such a framework, if public, could reveal deviation from true time, accuracy and source (phone company, GPS, NTP, user setting, etc).

@gavineadie Thanks for lobbying Apple ;) And thanks again for all your work on this library.


chore(build*.yml): only update Mathlib.lean once

The current workflow updates Mathlib.lean twice: there's no reason to do so. Since 'check_imported' step moved into the 'build' step, any old reasons for this duplication are now obsolete.

Thanks, this looks good to me!
I suggest toalso remove the git diff step that follows the remaining lake exe mk_all step, since the exit code of mk_all is the number of updated/modified files, so it will fail when the "import all" files are not up to date.

bors d+
@grunweg please feel free to either incorporate the suggestion to remove the git diff step, or propose deferring it to a separate PR.

Thanks for the review. Good idea; I've also removed the git diff step. The relevant CI steps passed, so let me
bors r+


Refactor docs to use Sphinx and Dataverse guide skin

As this project is recieving more attention and maturing from a PoC to production usage, the docs should be refactored.
They should feel more like Dataverse-ish by using the Dataverse guides theme/template/skin and maybe stand next to them as reference how to run Dataverse on K8s (maybe even more).
Today and a while ago @pdurbin on IRC asked to refactor http://guides.dataverse.org/en/4.16/developers/containers.html, as this is not purly about developing. Maybe the docs here can mature into what he wants to see?
Notes

Sphinx is capable of using Markdown via recommonmark, so we don't need to switch to rST instantly.

Looks like I'm not going with the bootstrap based skin of Dataverse.
Picked https://github.com/myyasuda/sphinx_materialdesign_theme instead.
First results on http://iqss.github.io/dataverse-kubernetes using Jenkins pipeline to push to gh-pages branch.
Thinking about version support. What about moving to ReadTheDocs.org? PR support on its way.
https://blog.readthedocs.com/building-docs-for-pull-requests/
Material design theme could be extended to enable versions support, see
https://github.com/readthedocs/sphinx_rtd_theme/blob/master/sphinx_rtd_theme/versions.html

Done in #132


[EventRequest] Codeunit 1102 CA Jnl.-Post Line OnAfterBudgetCostEntryInsert,OnBeforeBudgetCostEntryInsert

Events for CostEntry are there. But, same events for budget entries are misssing. Please, add two new events:
[IntegrationEvent] OnAfterCostBugetEntryInsert(VAR CostBudgetEntry : Record "Cost Budget Entry";CostJournalLine : Record "Cost Journal Line")
[IntegrationEvent] OnBeforeCostBugetEntryInsert(VAR CostBudgetEntry : Record "Cost Budget Entry";CostJournalLine : Record "Cost Journal Line")
calling in function InsertBudgetEntries
LOCAL InsertBudgetEntries(CT : Code[20];CC : Code[20];CO : Code[20];Amt : Decimal)
WITH CostJnlLine DO BEGIN
CostBudgetEntry.INIT;
CostBudgetEntry."Entry No." := NextCostBudgetEntryNo;
CostBudgetEntry."Budget Name" := "Budget Name";
CostBudgetEntry."Cost Type No." := CT;
CostBudgetEntry.Date := "Posting Date";
CostBudgetEntry."Document No." := "Document No.";
CostBudgetEntry.Description := Description;
CostBudgetEntry."Cost Center Code" := CC;
CostBudgetEntry."Cost Object Code" := CO;
CostBudgetEntry.Amount := Amt;
CostBudgetEntry."Source Code" := "Source Code";
CostBudgetEntry."System-Created Entry" := "System-Created Entry";
CostBudgetEntry.Allocated := Allocated;
CostBudgetEntry."Last Modified By User" := USERID;
CostBudgetEntry."Allocation Description" := "Allocation Description";
CostBudgetEntry."Allocation ID" := "Allocation ID";
// new
OnBeforeCostBugetEntryInsert(CostBudgetEntry,CostJnlLine);
//
CostBudgetEntry.INSERT;
// new
OnAfterCostBugetEntryInsert(CostBudgetEntry,CostJnlLine);
//
END;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[gainput] imporve cmake search gainput library

Describe the pull request

What does your PR fix? Fixes issue #10982
Add a patch to improve CMake import [gainput]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: L-Sun sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for giving a examples. I have modified the relevant code.Thanks for giving a examples. I have modified the relevant code.

This behavior existed before I modified the code. Should I modify it?

@L-Sun Yes, dynamic libraries can only be generated in dynamic triples, as are static libraries.

It has passed on x64_windows_static pipeline, so should we need update ci.baseline.txt with gainput:x64-windows-static=pass?

@L-Sun Just remove gainput:x64-windows-static=fail from ci.baseline.txt.

CMake Error at lib/CMakeLists.txt:58 (target_link_libraries):
  Cannot specify link libraries for target "gainput" which is not built by
  this project.

I don’t have an Apple device, so I can’t test in an osx environment. I have reset osx related code in
lib/CMakeLists.

In SOURCE/lib/CMakeLists.txt line 54:
elseif(APPLE)
...
        target_link_libraries(gainput ${FOUNDATION} ${IOKIT} ${GAME_CONTROLLER})

When using the triple x64-osx or x64-linux, the default library linkage is static, so it can only generate the target "gainputstatic", causing this error.

/azp run

/azp run

LGTM, thanks for this PR!

Alright, this is cool! Thanks @L-Sun :)


Fix highlighting

Fixes #139 #144

The style changes look good, although the tests are failing because it looks like changeAction() is not always specified. We can look at this together this afternoon. There are also a couple merge conflicts which need to be resolved. Thanks for the updates!

Looks great! Although the naming of Action (type CHANGE_EXPR) and ChangeAction (type CHANGE_ACTION) is really confusing. I'd suggest clarifying what each of those are supposed to do and picking new names for Action, ChangeAction, and the associated types.
Another small thing is that I see you removed .RelOp from the selector in RelOp.css. This is important as it ensures the CSS only affects this component. You should be able to instead change .RelOp.hovering to .RelOp .hovering (note the space).
We can take a look together at these things later this afternoon and I think this will be ready to merge!


Event timing

note: I know our project is officially over but I just feel that a) this is getting really close to something useful b) I enjoy working on this so I may be submitting more PRs in upcoming days. I'll be glad for reviews but don't feel obliged in any way to respond to this. 🙌
The first commit merges the two testing probes into one, taking inspiration from @PabloMansanet's "modes" in the log probe)
The second adds another mode to this unified probe that can be used to test out the last commit in a controlled way.
And that last commit implements a half-baked change that plays sounds for the incoming events based on their internal timestamp rather than as they come. It's only half-baked because I have a few questions I wanted to discuss first.
btw: this seems to work! Running the test probe in burst mode with arbitrary parameters results in "clacks" played evenly spaced.

@goodhoko thank you so much for making progress on this front! I wanted to start testing timed events for other event types, too, so I created https://github.com/tonarino/acoustic_profiler/pull/41. It partially overlaps with your 3rd commit here, so please have a look. I've addressed some of @strohel's review comments, too.

I'll close this as the crux of this PR (timed events) was completed in #41 and #42.
I'll post the left-over bit in a clean PR.


tiny typo bug.

line 623
      case AddrModeIndY:         if (addr8Label)           snprintf(buffer, bufferSize, "(%s, x)", addr8Label);
should be
          snprintf(buffer, bufferSize, "(%s),y", addr8Label);
not convinced this values a PR.

Thanks, Jett.
Fixed.
Cheers
Troy
From: Jett @.>
Sent: Saturday, February 3, 2024 2:07 AM
To: visrealm/vrEmu6502 @.>
Cc: Subscribed @.***>
Subject: [visrealm/vrEmu6502] tiny typo bug. (Issue #5)
line 623
case AddrModeIndY: if (addr8Label) snprintf(buffer, bufferSize, "(%s, x)", addr8Label);
should be
snprintf(buffer, bufferSize, "(%s),y", addr8Label);
not convinced this values a PR.
—
Reply to this email directly, view it on GitHub https://github.com/visrealm/vrEmu6502/issues/5 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUQOKDLNCTGMFGC5X76HWTYRUBYVAVCNFSM6AAAAABCW4DDW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTKMJZGYZDENQ .
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Fixed


How to add more than trial

Hi,
First, let me thank you for amazing work.
I need to add more than validation for same filed one with format and the other one for length.
thanks

You can do that with the cops and you add multiple suspects. Then you just get the return from allGuilty


Support for BOOTLOADER_CUSTOM_RESERVE_RTC missing for ESP32C2 (IDFGH-9324)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.0
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
What is the expected behavior?
support for CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC in ESP32-C2
What is the actual behavior?
It is missing as an option from idf.py menuconfig
when compiling code that works fine on other platforms, this is the essential hint that it is missing:
/project/LCM4ESP32/main/ota.c:117:9: error: implicit declaration of function 'bootloader_common_get_rtc_retain_mem_reboot_counter'

Steps to reproduce.

use the code of HomeACcessoryKid/LCM4ESP32 and set device to esp32-c2
compile the app code: idf.py app
observe compile error
go into menuconfig/bootloader options and missing RTC memory options

Build or installation Logs.
root@25e7affaca0f:/project/LCM4ESP32# idf.py app
Executing action: app
Running ninja in directory /project/LCM4ESP32/build
Executing "ninja app"...
[2/8] Building C object esp-idf/main/CMakeFiles/__idf_main.dir/ota.c.objFAILED: esp-idf/main/CMakeFiles/__idf_main.dir/ota.c.obj
ccache /opt/esp/tools/riscv32-esp-elf/esp-2022r1-11.2.0/riscv32-esp-elf/bin/riscv32-esp-elf-gcc -DMBEDTLS_CONFIG_FILE=\"mbedtls/esp_config.h\" -DUNITY_INCLUDE_CONFIG_H -I/project/LCM4ESP32/build/config -I/project/LCM4ESP32/main -I/opt/esp/idf/components/newlib/platform_include -I/opt/esp/idf/components/freertos/FreeRTOS-Kernel/include -I/opt/esp/idf/components/freertos/esp_additions/include/freertos -I/opt/esp/idf/components/freertos/FreeRTOS-Kernel/portable/riscv/include -I/opt/esp/idf/components/freertos/esp_additions/include -I/opt/esp/idf/components/esp_hw_support/include -I/opt/esp/idf/components/esp_hw_support/include/soc -I/opt/esp/idf/components/esp_hw_support/include/soc/esp32c2 -I/opt/esp/idf/components/esp_hw_support/port/esp32c2/. -I/opt/esp/idf/components/esp_hw_support/port/esp32c2/private_include -I/opt/esp/idf/components/heap/include -I/opt/esp/idf/components/log/include -I/opt/esp/idf/components/soc/include -I/opt/esp/idf/components/soc/esp32c2/. -I/opt/esp/idf/components/soc/esp32c2/include -I/opt/esp/idf/components/hal/esp32c2/include -I/opt/esp/idf/components/hal/include -I/opt/esp/idf/components/hal/platform_port/include -I/opt/esp/idf/components/esp_rom/include -I/opt/esp/idf/components/esp_rom/include/esp32c2 -I/opt/esp/idf/components/esp_rom/esp32c2 -I/opt/esp/idf/components/esp_common/include -I/opt/esp/idf/components/esp_system/include -I/opt/esp/idf/components/esp_system/port/soc -I/opt/esp/idf/components/esp_system/port/include/riscv -I/opt/esp/idf/components/esp_system/port/include/private -I/opt/esp/idf/components/riscv/include -I/opt/esp/idf/components/lwip/include -I/opt/esp/idf/components/lwip/include/apps -I/opt/esp/idf/components/lwip/include/apps/sntp -I/opt/esp/idf/components/lwip/lwip/src/include -I/opt/esp/idf/components/lwip/port/esp32/include -I/opt/esp/idf/components/lwip/port/esp32/include/arch -I/opt/esp/idf/components/esp_ringbuf/include -I/opt/esp/idf/components/efuse/include -I/opt/esp/idf/components/efuse/esp32c2/include -I/opt/esp/idf/components/driver/include -I/opt/esp/idf/components/driver/deprecated -I/opt/esp/idf/components/esp_pm/include -I/opt/esp/idf/components/mbedtls/port/include -I/opt/esp/idf/components/mbedtls/mbedtls/include -I/opt/esp/idf/components/mbedtls/mbedtls/library -I/opt/esp/idf/components/mbedtls/esp_crt_bundle/include -I/opt/esp/idf/components/esp_app_format/include -I/opt/esp/idf/components/bootloader_support/include -I/opt/esp/idf/components/bootloader_support/bootloader_flash/include -I/opt/esp/idf/components/esp_partition/include -I/opt/esp/idf/components/app_update/include -I/opt/esp/idf/components/spi_flash/include -I/opt/esp/idf/components/pthread/include -I/opt/esp/idf/components/esp_timer/include -I/opt/esp/idf/components/app_trace/include -I/opt/esp/idf/components/esp_event/include -I/opt/esp/idf/components/nvs_flash/include -I/opt/esp/idf/components/esp_phy/include -I/opt/esp/idf/components/esp_phy/esp32c2/include -I/opt/esp/idf/components/vfs/include -I/opt/esp/idf/components/esp_netif/include -I/opt/esp/idf/components/wpa_supplicant/include -I/opt/esp/idf/components/wpa_supplicant/port/include -I/opt/esp/idf/components/wpa_supplicant/esp_supplicant/include -I/opt/esp/idf/components/esp_wifi/include -I/opt/esp/idf/components/unity/include -I/opt/esp/idf/components/unity/unity/src -I/opt/esp/idf/components/cmock/CMock/src -I/opt/esp/idf/components/console -I/opt/esp/idf/components/http_parser -I/opt/esp/idf/components/esp-tls -I/opt/esp/idf/components/esp-tls/esp-tls-crypto -I/opt/esp/idf/components/esp_adc/include -I/opt/esp/idf/components/esp_adc/interface -I/opt/esp/idf/components/esp_adc/esp32c2/include -I/opt/esp/idf/components/esp_adc/deprecated/include -I/opt/esp/idf/components/esp_eth/include -I/opt/esp/idf/components/esp_hid/include -I/opt/esp/idf/components/tcp_transport/include -I/opt/esp/idf/components/esp_http_client/include -I/opt/esp/idf/components/esp_http_server/include -I/opt/esp/idf/components/esp_https_ota/include -I/opt/esp/idf/components/esp_https_server/include -I/opt/esp/idf/components/esp_lcd/include -I/opt/esp/idf/components/esp_lcd/interface -I/opt/esp/idf/components/protobuf-c/protobuf-c -I/opt/esp/idf/components/protocomm/include/common -I/opt/esp/idf/components/protocomm/include/security -I/opt/esp/idf/components/protocomm/include/transports -I/opt/esp/idf/components/esp_local_ctrl/include -I/opt/esp/idf/components/esp_psram/include -I/opt/esp/idf/components/espcoredump/include -I/opt/esp/idf/components/espcoredump/include/port/riscv -I/opt/esp/idf/components/wear_levelling/include -I/opt/esp/idf/components/sdmmc/include -I/opt/esp/idf/components/fatfs/diskio -I/opt/esp/idf/components/fatfs/vfs -I/opt/esp/idf/components/fatfs/src -I/opt/esp/idf/components/idf_test/include -I/opt/esp/idf/components/idf_test/include/esp32c2 -I/opt/esp/idf/components/ieee802154/include -I/opt/esp/idf/components/json/cJSON -I/opt/esp/idf/components/mqtt/esp-mqtt/include -I/opt/esp/idf/components/spiffs/include -I/opt/esp/idf/components/wifi_provisioning/include -march=rv32imc  -fdiagnostics-color=always -ffunction-sections -fdata-sections -Wall -Werror=all -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=deprecated-declarations -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-enum-conversion -gdwarf-4 -ggdb -nostartfiles -Og -fmacro-prefix-map=/project/LCM4ESP32=. -fmacro-prefix-map=/opt/esp/idf=/IDF -fstrict-volatile-bitfields -Wno-error=unused-but-set-variable -fno-jump-tables -fno-tree-switch-conversion -DconfigENABLE_FREERTOS_DEBUG_OCDAWARE=1 -std=gnu17 -Wno-old-style-declaration -D_GNU_SOURCE -DIDF_VER=\"v5.0\" -DESP_PLATFORM -D_POSIX_READER_WRITER_LOCKS -MD -MT esp-idf/main/CMakeFiles/__idf_main.dir/ota.c.obj -MF esp-idf/main/CMakeFiles/__idf_main.dir/ota.c.obj.d -o esp-idf/main/CMakeFiles/__idf_main.dir/ota.c.obj -c /project/LCM4ESP32/main/ota.c
/project/LCM4ESP32/main/ota.c: In function 'ota_rtc_read_task':
/project/LCM4ESP32/main/ota.c:117:9: error: implicit declaration of function 'bootloader_common_get_rtc_retain_mem_reboot_counter' [-Werror=implicit-function-declaration]
  117 |     if (bootloader_common_get_rtc_retain_mem_reboot_counter()) { //if zero, RTC CRC not valid
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/project/LCM4ESP32/main/ota.c:118:34: error: implicit declaration of function 'bootloader_common_get_rtc_retain_mem'; did you mean 'bootloader_common_get_chip_ver_pkg'? [-Werror=implicit-function-declaration]
  118 |         rtc_retain_mem_t* rtcmem=bootloader_common_get_rtc_retain_mem(); //access to the memory struct
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  bootloader_common_get_chip_ver_pkg
/project/LCM4ESP32/main/ota.c:118:34: warning: initialization of 'rtc_retain_mem_t *' from 'int' makes pointer from integer without a cast [-Wint-conversio]
/project/LCM4ESP32/main/ota.c:119:21: error: 'rtc_retain_mem_t' has no member named 'custom'
  119 |         count=rtcmem->custom[0]; //byte zero for count
      |                     ^~
/project/LCM4ESP32/main/ota.c:123:5: error: implicit declaration of function 'bootloader_common_reset_rtc_retain_mem' [-Werror=implicit-function-declaratio]
  123 |     bootloader_common_reset_rtc_retain_mem(); //this will clear RTC
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/project/LCM4ESP32/main/ota.c: In function 'ota_rtc_write_task':
/project/LCM4ESP32/main/ota.c:1080:30: warning: initialization of 'rtc_retain_mem_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1080 |     rtc_retain_mem_t* rtcmem=bootloader_common_get_rtc_retain_mem(); //access to the memory struct
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/project/LCM4ESP32/main/ota.c:1083:11: error: 'rtc_retain_mem_t' has no member named 'custom'
 1083 |     rtcmem->custom[1]=1; //byte one for temp_boot signal (from app to bootloader)
      |           ^~
/project/LCM4ESP32/main/ota.c:1084:5: error: implicit declaration of function 'bootloader_common_update_rtc_retain_mem' [-Werror=implicit-function-declaration]
 1084 |     bootloader_common_update_rtc_retain_mem(NULL,false); //this will update the CRC only
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
HINT: Please check that the function name is correct. Also it is possible that you've forgot to import bootloader_common_get_rtc_retain_mem_reboot_counter library(s) in header file or add the necessary REQURIES component. Try to add missing libraries to your project header file or check idf_component_register(REQUIRES ...) section in your component CmakeList.txt file. For more information run 'idf.py docs -sp api-guides/build-system.html'.
Also, please check if the function has been removed, renamed or replaced by an alternative function - refer to the migration guide for more information.
ninja failed with exit code 1, output of the command is in the /project/LCM4ESP32/build/log/idf_py_stderr_output_32484 and /project/LCM4ESP32/build/log/idf_py_stdout_output_32484
root@25e7affaca0f:/project/LCM4ESP32# idf.py fullclean >/dev/null 2>&1; rm -rf /mnt/main
root@25e7affaca0f:/project/LCM4ESP32# idf.py menuconfig
Executing action: menuconfig
Running cmake in directory /project/LCM4ESP32/build
Executing "cmake -G Ninja -DPYTHON_DEPS_CHECKED=1 -DESP_PLATFORM=1 -DIDF_TARGET=esp32c2 -DCCACHE_ENABLE=1 /project/LCM4ESP32"...
-- Found Git: /usr/bin/git (found version "2.25.1")
-- ccache will be used for faster recompilation
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /opt/esp/tools/riscv32-esp-elf/esp-2022r1-11.2.0/riscv32-esp-elf/bin/riscv32-esp-elf-gcc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/esp/tools/riscv32-esp-elf/esp-2022r1-11.2.0/riscv32-esp-elf/bin/riscv32-esp-elf-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/esp/tools/riscv32-esp-elf/esp-2022r1-11.2.0/riscv32-esp-elf/bin/riscv32-esp-elf-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building ESP-IDF components for target esp32c2
-- Project sdkconfig file /project/LCM4ESP32/sdkconfig
Loading defaults file /project/LCM4ESP32/sdkconfig.defaults...
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Found Python3: /opt/esp/python_env/idf5.0_py3.8_env/bin/python (found version "3.8.10") found components: Interpreter
-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS
-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS - Success
-- App "LCM4ESP32" version: 0.9.9
-- Adding linker script /project/LCM4ESP32/build/esp-idf/esp_system/ld/memory.ld
-- Adding linker script /opt/esp/idf/components/esp_system/ld/esp32c2/sections.ld.in
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.api.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.rvfp.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.newlib.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.version.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.mbedtls.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.newlib-time.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.newlib-nano.ld
-- Adding linker script /opt/esp/idf/components/esp_rom/esp32c2/ld/esp32c2.rom.heap.ld
-- Adding linker script /opt/esp/idf/components/soc/esp32c2/ld/esp32c2.peripherals.ld
-- Components: app_trace app_update bootloader bootloader_support bt cmock console cxx driver efuse esp-tls esp_adc esp_app_format esp_common esp_eth esp_event esp_hid esp_http_client esp_http_server esp_https_ota esp_https_server esp_hw_support esp_lcd esp_local_ctrl esp_netif esp_partition esp_phy esp_pm esp_psram esp_ringbuf esp_rom esp_system esp_timer esp_wifi espcoredump esptool_py fatfs freertos hal heap http_parser idf_test ieee802154 json log lwip main mbedtls mqtt newlib nvs_flash openthread partition_table protobuf-c protocomm pthread riscv sdmmc soc spi_flash spiffs tcp_transport ulp unity usb vfs wear_levelling wifi_provisioning wpa_supplicant
-- Component paths: /opt/esp/idf/components/app_trace /opt/esp/idf/components/app_update /opt/esp/idf/components/bootloader /opt/esp/idf/components/bootloader_support /opt/esp/idf/components/bt /opt/esp/idf/components/cmock /opt/esp/idf/components/console /opt/esp/idf/components/cxx /opt/esp/idf/components/driver /opt/esp/idf/components/efuse /opt/esp/idf/components/esp-tls /opt/esp/idf/components/esp_adc /opt/esp/idf/components/esp_app_format /opt/esp/idf/components/esp_common /opt/esp/idf/components/esp_eth /opt/esp/idf/components/esp_event /opt/esp/idf/components/esp_hid /opt/esp/idf/components/esp_http_client /opt/esp/idf/components/esp_http_server /opt/esp/idf/components/esp_https_ota /opt/esp/idf/components/esp_https_server /opt/esp/idf/components/esp_hw_support /opt/esp/idf/components/esp_lcd /opt/esp/idf/components/esp_local_ctrl /opt/esp/idf/components/esp_netif /opt/esp/idf/components/esp_partition /opt/esp/idf/components/esp_phy /opt/esp/idf/components/esp_pm /opt/esp/idf/components/esp_psram /opt/esp/idf/components/esp_ringbuf /opt/esp/idf/components/esp_rom /opt/esp/idf/components/esp_system /opt/esp/idf/components/esp_timer /opt/esp/idf/components/esp_wifi /opt/esp/idf/components/espcoredump /opt/esp/idf/components/esptool_py /opt/esp/idf/components/fatfs /opt/esp/idf/components/freertos /opt/esp/idf/components/hal /opt/esp/idf/components/heap /opt/esp/idf/components/http_parser /opt/esp/idf/components/idf_test /opt/esp/idf/components/ieee802154 /opt/esp/idf/components/json /opt/esp/idf/components/log /opt/esp/idf/components/lwip /project/LCM4ESP32/main /opt/esp/idf/components/mbedtls /opt/esp/idf/components/mqtt /opt/esp/idf/components/newlib /opt/esp/idf/components/nvs_flash /opt/esp/idf/components/openthread /opt/esp/idf/components/partition_table /opt/esp/idf/components/protobuf-c /opt/esp/idf/components/protocomm /opt/esp/idf/components/pthread /opt/esp/idf/components/riscv /opt/esp/idf/components/sdmmc /opt/esp/idf/components/soc /opt/esp/idf/components/spi_flash /opt/esp/idf/components/spiffs /opt/esp/idf/components/tcp_transport /opt/esp/idf/components/ulp /opt/esp/idf/components/unity /opt/esp/idf/components/usb /opt/esp/idf/components/vfs /opt/esp/idf/components/wear_levelling /opt/esp/idf/components/wifi_provisioning /opt/esp/idf/components/wpa_supplicant
-- Configuring done
-- Generating done
-- Build files have been written to: /project/LCM4ESP32/build
Running ninja in directory /project/LCM4ESP32/build
Executing "ninja menuconfig"...
[0/1] cd /project/LCM4ESP32/build && /opt/esp/python_env/idf5.0_py3.8_env/bi...GET=esp32c2 --env IDF_ENV_FPGA= --output config /project/LCM4ESP32/sdkconfig
Loading defaults file /project/LCM4ESP32/sdkconfig.defaults...
WARNING: Menuconfig may fail because of the TERM environment variable is set to "xterm". Please consult the documentation of your terminal to set it up. Some good, proved to been working setups include xterm-256color, screen-256color, rxvt-unicode-256color, alacritty.
Loaded configuration '/project/LCM4ESP32/sdkconfig'
Configuration (/project/LCM4ESP32/sdkconfig) was not saved
Loading defaults file /project/LCM4ESP32/sdkconfig.defaults...

More Information.
Using Docker container v5.0 but inspected source of master branch
When looking for CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC it is clear that ESP32-C2 is forgotten somehow.
./components/esp_system/ld/esp32c3/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32c3/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32c6/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32c6/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32h4/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32h4/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32h2/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32h2/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32s3/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32s3/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)
./components/esp_system/ld/esp32s2/memory.ld.in:#ifdef CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC
./components/esp_system/ld/esp32s2/memory.ld.in:#define ESP_BOOTLOADER_RESERVE_RTC (CONFIG_BOOTLOADER_RESERVE_RTC_SIZE + CONFIG_BOOTLOADER_CUSTOM_RESERVE_RTC_SIZE)

Hi,
This is actually as intended. C2 doesnt have any RTC memory, so this kconfig option is disabled. (You can actually see its dependency in kconfig depends on SOC_RTC_FAST_MEM_SUPPORTED)

If C2 doesn't have any RTC, then the documentation of this feature must be made a lot clearer.
Based on that documentation I decided to raise this bug.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32c2/api-reference/kconfig.html#config-bootloader-custom-reserve-rtc
Considering that you have dynamic documentation per platform, then you have to make the conclusion clear:
There is no RTC on a C2. Just write it down.
Having said that, is there an alternative (short of abusing flash memory) to transfer information across a powered reset?
As always, thanks for the wonderful development platform that the ESP is!

Clear answer, thank you.
Having said that, and considering that the CUSTOM_RTC feature was able to address 16 bytes only anyhow, is it not possible to carve out 16 bytes out of this RTC_CNTL_STOREX_REG space? Or even 4?
Not that I know what that implies, but 16 seems a very small number, right?
Because you rightfully wrote "good" when referring to flash. Let alone that NVS is hard (if at all) to use sending info from or to the bootloader.

You can see what these registers are used for here. It doesn't look like any of them are likely to available for users, but maybe there are some circumstances where we could free up one or two of them. I'm not that familiar with the details of the RTC related code, but i'll poke the guys responsible for this and ask them.

CUSTOM_RTC feature was able to address 16 bytes only anyhow
We actually recently fixed this (as you implied, this size limit was pretty arbitrary... ), so you are now free to use as much RTC memory as you want for this.

Asked around and unfortunately it doesnt seem like we'll be able to release any of these registers for end-user use-cases.

Hi Marius,
Picking this up again with a new idea.
Upon reading the code for the registers, I think that there is a lot of free namespace for the RESET_REASON definitions.
So, with a 15 bit space (with the half-word and top bit stuff), the definitions could go as high as 32767, right? So plenty of space.
It would be nice if there would be an extension of the esp_restart(void) function where a parameter is given to indicate a reboot from another ota partition than the current selected one. We know that RTC_SW_CPU_RESET is encoded as 12.
Simple encoding could be done with a value of 28 (12+16) to indicate RTC_SW_CPU_RESET_OTA1 instead of RTC_SW_CPU_RESET.
Or, to cover all ota definitions and also factory reset you could assign 28 to factory and 32-47 to OTA0-OTA15
Other ideas can valid as well, but with plenty of space, these could be valuable functions.
Thanks for your attention...

Hey, sorry for the slow reply.
I think we are still reluctant to use these available bits, partially due to that as soon we open these up then we can never reclaim them in the case we need them to work around a bug or limitation in the future.
But how about this: would you mind opening a feature request describing what you want and why you want it? It might not result in us caving in a doing it, but at least it will give a proper place where we can discuss it, as well as giving other users the chance to upvote/explain their needs.
If we see that there is a big demand for adding a certain bit etc to one of the registers then we are more likely to be able to convince the stakeholders.

Thanks @ESP-Marius , I still have it on my to-do list to open a feature request, but for now too busy with other stuff.


As.promise onError not working as intended?

First of all, thanks for the great package!
I'm trying to build something from the react example, but I'm facing some issues with As.promise. I'm trying to map rejections to some Error type, and the type inference tells me that the Failure case can only contain my type afterwards. However, the actual rejections bubble up and when I match the Exit on Failure, it contains a TypeError (that was thrown from Browser fetch originally) and not my error type.
I've added a test case that shows the problem. The inferred type here is As.Exit<string,never> as expected, but the contained value is actually Error("err") or rejected and not mapped u.
Am I holding it wrong?
Cheers

Thanks for the PR indeed it was a mistake from the last refactor to initial encoding!


Add support for PG tuples

This commit looks like it changes a lot of code. I promise that it
doesn't actually change a lot of code.  That unfortunately churns
7k+ lines of code, but really -- I promise, this commit isn't that big.
This has come up in various contexts enough times for me to take another
look at it. Turns out it wasn't actually that bad to support other than
the fact that we cannot -- nor will we ever be -- able to support a
ToSql impl for PG tuple types. I've managed to emulate it with a
decent AsExpression impl.
This shouldn't affect most people, as you very rarely care about whether
ToSql is actually implemented. The only time you would care are if
you're using sql_query, which I wrote a long bit in the docs about
exactly what we generate, so folks can do the same. The other time you
might care is if you are implementing support for a named composite type
local to your application, in which case you definitely want that impl
to exist. However, I have not done that in this PR, as I need some time
to think over how to do that in a way that doesn't give an impl that
accidentally gets used and generates runtime errors.

@sgrif Github means this needs a rebase.


Support for gb manifest files

For gb projects, we should be able to produce deps.nix directly from the manifest, right?
A question, though: How do you express in deps.nix packages that aren't based in a repo's root? For example: https://github.com/stellar/horizon/blob/94a9f35d93f33e365e3a154d6dce08b0e15df608/vendor/manifest#L78

I didn't use gb, so the path in its manifest is something new for me.
It looks like optimization that can make vendor dir cleaner https://github.com/constabulary/gb/blob/master/cmd/gb-vendor/restore.go#L62
We can't download repo subdirectory in nix, so I don't think that could optimize anything in nix.

Here's the project I'm building that uses gb:
https://github.com/chris-martin/home/blob/009949930514872337a01ac1b20bba041d75e8a8/nix/pkgs/stellar-horizon/default.nix
I had to change the GOPATH assembly process to accommodate dependencies that use path, and the project's difference in directory structure from typical Go projects.
And a quick script I threw together to convert the manifest: https://github.com/chris-martin/gb2nix


Handling Exeptions & Change data types

Add futher comments on Exceptions and improve messages on AC charging phases.

Yes, your are right. Thanks!

Thank you for the nice PR ;) !


Fix close button on media view for iPhone X

Problem
Currently, after clicking a photo or video from a timeline tweet,
you can not close the media view controller on the iPhone X. The
close button overlaps the status bar and does not respond to user
interaction.
Solution
This code uses the safe area layout guide in iOS 11 to
constrain the top of the close button to the top of the safe area.
If the device is not an iOS 11 device, the close button defaults
to the previously functional visual constraints.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kayla Galway seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Open API: getRoomKeys is missing required flag

Link to problem area:
https://github.com/matrix-org/matrix-doc/blob/1ad5ff4179cfa2b62d6be47ad6ed8bde95ec2e41/data/api/client-server/key_backup.yaml#L852-L880
Issue
This field is missing required: true like is done here.
The description says that if no keys are found, then empty (but not omitted) rooms property will be returned.
This whole schema should probably just be de-duplicated into the definitions folder like so.

I'll work on this!


[GitHub] Fix minor grammatical things in the issue templates

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 2

See the complete overview on Codacy


[CI] v1.61.x: Update SHA for the test bazel build image

Updating deleted Bazel image hash with existing image hash.
Similar to #37991 for v1.61.x branch.
Passing Interop Test Runs:

[x]  grpc/core/v1.61.x/branch/linux/grpc_xds_v3
[x]  grpc/core/v1.61.x/branch/linux/grpc_xds_v3_python

I didn't make any changes to the rbe_ubuntu2004 image in this PR, but it seems to be missing from Artifact Registry. Let me try to regenerate and push that image too

@eugeneo What you say makes sense, but it's irrelevant for this fix. Same thing happened in #37991, and @veblush confirmed it's ok to merge as long as what we're fixing (psm interop) passes.


Pledge page polish

Before:

After:

Very nice @petterheterjag. It looks great and really awesome work with the Stripe customization. Merging! 🚀

Fixes #455


Tomorrow doesn't work on last day of the month

On the last day of the month the title says "Tomorrow" but the date is still today and it's showing today's dishes. So it seems like the thing calculating tomorrow's date can't overflow into the month. e.g. today is 2018-05-31 and the title currently says: "Tomorrow / 2018-05-31"

Probably need gregorianMonthsRollover from https://hackage.haskell.org/package/thyme-<IP_ADDRESS>/docs/Data-Thyme-Calendar.html in src/M.hs:42.


Support the job_events field in Slack Notification integration service

The GitLab API supports a job_events field in the Slack Notification Service Integration which is not yet available in go-gitlab.
Would be good to implement this. Also the ConfidentialNoteChannel is currently not supported. I noticed the comment in the source code here, however, if it's "only" ignored by the upstream GitLab API I think you should implement it nevertheless.
It's a bug in upstream and actually documented as it should be available.

Also the commit_events is currently not supported here.

There is actually quite some problems in the upstream GitLab API which may block you to correctly implement this at the moment: https://gitlab.com/gitlab-org/gitlab/-/issues/28903

Is this still applicable or did things change?

Closing this one due to no response. Feel free to reopen if needed...

It's still applicable: https://github.com/xanzy/go-gitlab/blob/1983bd31dfff9674b9e92c37eb9abd7bf2269d50/services.go#L1212
Sorry for not responding ;)

No problem, just reopened it 👍🏻

Hello, I opened a MR to fix various issues with the GitLab project integration API, I'll open a MR here to account for these changes and add support for the Discord integration once it is merged: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/122943


Vulnerability with acorn

🐞 Bug report
Our security check tool is throwing a vulnerability issue with acorn 6.3.0
Description
<EMAIL_ADDRESS>is dependent on less version 3.11.1 which has dependency with<EMAIL_ADDRESS>Possible Fix
We think we can solve this issue by updating less to version 3.11.3
Please have a look on pull request #17898

https://github.com/angular/angular-cli/pull/17898

Hi @vishnutsivan, can you please share the vulnerability report? less 3.11.1 doesn't depend on acorn.
<EMAIL_ADDRESS>

@alan-agius4 in package.json of less 3.11.1 there is no dependency on acorn. But if we browse node_modules then we can find it's reference

@vishnutsivan I see, the used to ship a node_modules directory as part of the package.

@alan-agius4 yes, and in the latest version of less ie 3.11.3 there are no such shipping of node_modules

Note: this security notuice doesn't effect package manager audit tools such as NPM and Yarn.
@vishnutsivan, left you a couple of comments on the PR, thanks.


for part of ui, can you write a dockerfile for the environment setting etc ?

For part of ui, Hope perfetto team can support a dockerfile from the environment setting.
I trying to build perfetto ui on my server, but I met lots of problem from environment setting, like downloading npm package.
I hope perfetto team can provide a dockerfile for ui parts.

Can you explain what the problem is?
AFAIK you just need to run: tools/install-build-deps --ui
This will install a hermetic copy of node and npm (so, no, you don't need to download your own npm)
The build system does the rest.
It's not clear to me what's the problem a docker container would solve

On Ubuntu server, our team met multiple problems. For me, it is:
npm ERR! file sh npm ERR! code ELIFECYCLE npm ERR! errno ENOENT npm ERR! syscall spawn npm ERR<EMAIL_ADDRESS>install: node-gyp-build`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-07-20T03_52_10_813Z-debug.log
Traceback (most recent call last):
File "tools/install-build-deps", line 435, in
sys.exit(Main())
File "tools/install-build-deps", line 414, in Main
InstallNodeModules()
File "tools/install-build-deps", line 294, in InstallNodeModules
cwd=UI_DIR)
File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/root/perfetto/ui/npm', 'install', '--no-save']' returned non-zero exit status 1`

This seems like an interesting issue. We've run into this ourselves now and then but we've never managed to identify a fix for it.
Using docker may be the most pragmatic way but unfortunately we don't have the bandwidth to investigate that at the moment. This may be something we revisit down the line.

For now, if we can't solve this problem though docker

如果现在我们不能通过dockerfile来解决这个问题，而我们希望部署一个相同的 ui.perfetto.dev 的服务，你们可以告诉一下我们，你们部署当前 ui.perfetto.dev 的环境吗？

If we can't solve this problem through dockerfile now, and westill  want to deploy similar ui.perfetto.dev service, can you tell us, what environment you deploy ui.perfetto.dev service? Hope answer can include Linux kernel version and os-release info. Thank you!

for us it works on:

Debian rodete w/ 5.2.17-1rodete3-amd64
Pretty much and debian-based and ubuntu-based virtual machine we tried (e.g. TravisCI, Google Cloud Platform images)

Now that you make me realize, we do have a Dockerfile which is guaranteed to build, it's the one that ci.perfetto.dev uses.
You can the sources here:
https://github.com/google/perfetto/blob/master/infra/ci/sandbox/Dockerfile
The image is here:
docker pull eu.gcr.io/perfetto-ci/sandbox@sha256:9855b3cad890963ed5a15fa801f83e91158809e429c759ebbd2f89816c73a1f5

Thank you

@primiano what ports and needed for that container? E.g., what is the docker run command?

That container is just for building the UI not for exposing the UI.
The UI is a fully static site so if you're trying to serve it, you should use the Docker version of any mainstream server (nginx, Caddy, traefik etc).

Gotcha - I'm just looking to run a tiny version, so I was looking at ui/run-dev-server, e.g.,
ENTRYPOINT ["./ui/run-dev-server", "--serve-host", "<IP_ADDRESS>"]

Have you seen any docker-compose or similar setups (even manual docker or kubernetes would work) of someone running all the components together?

What I'm trying so far is this Dockerfile:
FROM python:3

# docker build -t perfetto .

RUN git clone https://github.com/google/perfetto /opt/perfetto
WORKDIR /opt/perfetto

RUN tools/install-build-deps --ui
RUN tools/gn gen out/debug --args='is_debug=true'
RUN tools/ninja -C out/debug ui

ENTRYPOINT ["./ui/run-dev-server", "--serve-host", "<IP_ADDRESS>"]

Then:
$ docker run -it -p 8000:8000 perfetto --serve-host <IP_ADDRESS> --serve-port 8000 --serve

Ahh - I see - I wasn't patient enough! The frontend ui seems to finish building after I start (so at first the connection is reset) but when I let it wait... tada!!

I don't know if that's the full fledged thing I can run (I'll do some basic testing) but this is great!

The run-dev-server script exposes the UI on port 10000. However please do not run such an instance in production: the UI's dev server is not at all intended for being exposed to the internet and there could be any number of issues (i.e. security) with it.
Not sure what you mean by "all the components": the UI is really the only thing you'd want to run in a docker container.

We want to primarily make a small app for users on a cluster, so it wouldn't be production exposed and it would only be maybe one person per app. However, if there is a production deployment that is known how to do, that would be really useful to be able to share. Do you know of one, akin to what I mentioned above? This above should at least serve for testing!

No I'm not aware of any such deployment but as I say, once the UI is built it's just a static site: you can serve it with any server. e.g. for nginx: https://www.docker.com/blog/how-to-use-the-official-nginx-docker-image/

ohh gotcha - I can make a docker-compose set of containers to test this. And this also clarifies that point (sorry was not reading carefully!) https://github.com/google/perfetto/issues/170#issuecomment-912556127

Thanks for the help! Here are examples of the single Docker / docker-compose setup with a self-signed cert that I threw together, in case someone else is looking for them! Please PR / suggest improvements to the repo too. https://github.com/rse-ops/perfetto-compose.


Documentation: PascalCase is referred to as CamelCase

Hi!
Currently in the rust docs naming conventions, it is recommended to use CamelCase for some constructs.
However, camel casing is usually camelCase, while such capitalizing the first letter capitalized too is typically referred to as PascalCase.
While it is not false per se(PascalCase can be seen as a subset of camelCase), it is confusing, and would be better and more accurate IMO to change occurrences of it to PascalCase.
Thanks 🤘

This has already been discussed in #2389. The consensus was to use UpperCamelCase instead.

Currently in the rust docs naming conventions

Your link is the permalink to the 1.0.0 style guide: https://doc.rust-lang.org/1.0.0/style/style/naming/README.html. Please be cautious when using outdated reference material.

@shepmaster That's amazing! 1.0.0 style guide is the Google search result currently when searching for naming conventions so I've figured out it was current.

Terrible consensus! PascalCase was a great standard name, very established. Why not call it CamelCaseWithInitialCapital too then? UPPERCAMELCASE


GDT readme: log level configuration

#no-changelog

cc @mikehaney24

Fix check

Merging without waiting for checks not relevant for the readme changes.


Memory Leak

The longer the viewer runs, the more RAM it uses and the slower it renders. To reproduce this issue, create a loop that changes a small scene repeatedly and call view_all() in each iteration. The performance will degrade over time and RAM will increase indefinitely. In my test, rendering this animation for 3 minutes increased the RAM usage to 7GB.
https://github.com/user-attachments/assets/fa971aea-06e3-4219-b8d9-2002b6bfaaf7

This behavior is the same in VSCode or standalone and exists in the viewer server (although I have not explicitly checked if this problem exists on the CAD script side as in my case this typically becomes and issue over multiple runs rather than a single long run)

How do you create this loop?
Do you use the animation feature?
Or simply draw "frame after frame" and screenshot it.
I don't really know how javascripts garbage collector works or how I can profile a web app in the browser. Need to find out to see whether the issue is on my code (most probably) or in threejs (the only dependency of the viewer)

p = JernArc((0,0), (1,0), 10, 180).edge()
s = Circle(3)
t = 0
while True:
    t = max(0.01, (t+0.01)%1)
    o = sweep((p^0)*s, p.trim(0, t))
    show_all()

Also, you may notice that the object flashes which is caused by the lighting changing when first drawing the object, then it is re-rendered with the correct lighting. The flashing is obviously a bug but it is also rendering the scene twice unnecessarily.
https://github.com/user-attachments/assets/ed19e2b6-2046-4562-af9a-b2de956260f6

p = JernArc((0,0), (1,0), 10, 180).edge()
s = Circle(3)
t = 0
while True:
    t = max(0.01, (t+0.01)%1)
    o = sweep((p^0)*s, p.trim(0, t))
    show_all()

Also, you may notice that the object flashes which is caused by the lighting changing when first drawing the object, then it is re-rendered with the correct lighting. The flashing is obviously a bug but it is also rendering the scene twice unnecessarily.
https://github.com/user-attachments/assets/025bc758-e029-4c11-8717-f65fe087f47b


nested  div not working

<drawer right bottom></drawer>

what happens?
can give more information.