Add spices

About the PR

Adds a new condiment and its related shaker; spices! A full shaker spawns in the chef belt, and can be used to top foods for a little bit of extra flavour. I was not sure which plant reagents to pick for refilling the shaker, so i decided for it's recipe to use capasisisian oil and like black pepper. As someone who plays a lot of chef nowadays, i feel like this will be a great change 👍🏻
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Ubaser

add: Chefs now spawn with a spices shaker

Why is this necessary?
Where "Why / Balance" 🤔

Why is this necessary?
Where "Why / Balance" 🤔

updated

Im going to add a bit more to this PR so that spices have a proper use in regards to food recipes.

gonna wait till chef rework


filter "test69" is not valid base32 string

I am running a test on a machine, using some filters:
./mkp224o -d onions -t 6 test12 test25 test69
but I get errors:
filter "test12" is not valid base32 string
            ^
filter "test69" is not valid base32 string
             ^
set workdir: onions/
sorting filters... done.
filters:
        test25
in total, 1 filter
using 6 threads
waiting for threads to finish... done.

Am I missing something? Is there a reason that some numbers (25) are allowed while others (12, 69) are not?

From the readme:

Onion addresses use base32 encoding which does not include 0,1,8,9 numbers.
So no, that's not possible to generate these, and mkp224o tries to detect invalid filters containing them early on.


Heavily improved merging and much more

IndividualNodes.Merge() uses the expensive but more accurate Compare algorithm to determine the best way to merge two slices of individuals.
Flatten() returns a slice of nodes from a tree structure.
Node.SetNodes() can be used to replace or remove all child nodes.
Fixed a bug where MergeNodes() may not correctly childen from two equal nodes.
MergeDocumentsAndIndividuals() merges two documents while also merging similar individuals.
github.com/google/go-cmp has been added to make comparing more complex structures easier through assertEquals().
SurroundingSimilarity now includes the SimilarityOptions as a propety. This makes the interface more friendly and String more appropriate.
Fixed a bug in MergeNodeSlices() where the right slice may get mangled.
Added EqualityMergeFunction to be used with MergeSlice as one of the most common use cases.
Added String() to several existing structures, including IndividualNode that returns a pretty description like "Jane Doe (b. 3 Apr 1923, bur. Abt. 1943)"

This change is

Codecov Report

Merging #188 into master will increase coverage by 0.79%.
The diff coverage is 69.88%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   51.47%   52.27%   +0.79%
==========================================
  Files         169      170       +1
  Lines        4940     5071     +131
==========================================
+ Hits         2543     2651     +108
- Misses       2335     2357      +22
- Partials       62       63       +1

Impacted Files
Coverage Δ

node.go
100% <ø> (ø)
:arrow_up:

node_set.go
100% <ø> (ø)
:arrow_up:

nodes.go
100% <ø> (ø)
:arrow_up:

gedcomdiff/diff_page.go
0% <0%> (ø)
:arrow_up:

gedcomdiff/individual_compare.go
0% <0%> (ø)
:arrow_up:

gedcomdiff/main.go
0% <0%> (ø)
:arrow_up:

gedcomtune/main.go
0% <0%> (ø)
:arrow_up:

individual_node.go
98.63% <100%> (+1.59%)
:arrow_up:

simple_node.go
80.95% <100%> (+0.46%)
:arrow_up:

flatten.go
60% <60%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a135d06...ad9d7f4. Read the comment docs.


DST-392 - CYA - 'add end user' link is pressed it takes me to the correct screen but with error validation

Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.09%.  Consider uploading reports for the commit 15c804c to get more accurate results

Files
Patch %
Lines

django_app/report_a_suspected_breach/forms.py
50.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   80.28%   80.09%   -0.19%
==========================================
  Files          62       62
  Lines        1917     1864      -53
==========================================
- Hits         1539     1493      -46
+ Misses        378      371       -7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


trainer gui not working on SPT 3.4.1

tried reinstalling multiple times and same problem occurs, trainer loads but cant use gui and can only use a few commands. please let me know what i can do to fix this. thank you for taking time to keep updating the trainer as well.

happy to help with whatever is needed to fix the problem

let me specify, the gui is there and shows up and is binded to RightAlt. the problem is the buttons do nothing when i click them to change anything or turn anything on

https://user-images.githubusercontent.com/123708110/215259496-166693f6-b885-4fd7-9d5a-f5c258b8a26b.mp4
heres a short vid to help understand better

I had the same bug. Clean re-install of spt fixed that for me.

1- Could you share your %LOCALAPPDATA%Low\Battlestate Games\EscapeFromTarkov\Player.log ? We'll see the exact issue.
2- Are you sure you have run the game at least once before installing the trainer as explained in the installer ?

I had the same bug. Clean re-install of spt fixed that for me.

@toxicspike you were having the same problem as in the video?

Yes.
Back then I tried doing another install of this trainer on top of my existing game, that didn't help. So I did a clean new install of spt, copied my profile over and installed the trainer there, that worked for me.

@toxicspike ok thanks, trying that now. did you just delete the whole folder and make a new one?

@SirBlikk
Yes. Before deleting the folder, copy all your mods (from user/mods and from BepInEx/plugins, whatever you installed) somewhere safe. Same for your game profile/s (user/profiles) if you don't want to start all over.
Once you've reinstalled spt, put your mods and profile/s back in place, run once to check if everything works, then install the trainer. That worked for me

@toxicspike Okay, running SPT installer right now. Hoping this fixes the problem

@toxicspike When you install the Trainer, do you do it manually or with the installer? and if the installer, do you have to put it in the SPT file cause thats the only way it detects SPT for me.

Does this look like it was installed properly?

@toxicspike When you install the Trainer, do you do it manually or with the installer? and if the installer, do you have to put it in the SPT file cause thats the only way it detects SPT for me.

With the installer. I dont quite remember, but I think it only detected spt in the spt folder for me too.
Regarding the installer output, idk man, sailro will have to take a look.
Sorry to hear that it didn't work.
Are you using Mods? If yes, which ones and have you tried running the game without mods to check if GUI works that way? That might be helpful to sailro figure out the problem

@toxicspike When you install the Trainer, do you do it manually or with the installer? and if the installer, do you have to put it in the SPT file cause thats the only way it detects SPT for me.

With the installer. I dont quite remember, but I think it only detected spt from within the spt folder for me too.
Regarding the installer output, idk man, sailro will have to take a look. Sorry to hear that it didn't work. Are you using Mods? If yes, which ones and have you tried running the game without mods to check if GUI works that way? That might be helpful to sailro figure out the problem

Currently no mods as I was hopeing to get the trainer working before I reinstalled my mods.

@sailro Have you found out any information that helps with the problem?

@SirBlikk nope unfortunately, the log is ok, I do not reproduce and this is the very first time I'm seeing this. Let me think a bit to see if we find extra infos.

@SirBlikk nope unfortunately, the log is ok, I do not reproduce and this is the very first time I'm seeing this. Let me think a bit to see if we find extra infos.

Thank you, let me know if you need anything or figure anything out. If I edit my config will it change or should I wait.

@sailro Got some of the options working thru the trainer.ini but I also have a friend looking in to it for me as well.

same too. i cant see GUI

+1, tried updating windows to see if that was the issue, none worked, also reinstalled, gui not showing

bump

I need to be able to repro, so far it is working on my side. So I need logs with errors, exact repro step, etc. Everything that could help to understand what is happening.

Like BepInEx\LogOutput.log and %LOCALAPPDATA%Low\Battlestate Games\EscapeFromTarkov\Player.log.

Where is trainer.ini? I can't find it

The trainer.ini is created when you use the save command in the console.

recently upgraded my pc from an i7 7700k to a ryzen 7 5800x and it works perfectly now. not sure how we can make that problem happen again

Will reopen if we find something then.


Allow specifying which types to coerce [plugin-zod]

What is the problem this feature would solve?
I'm using Kubb for a serverless API, and i use to to generate Zod-schemas from my OpenApiSpec.
In this case I'm making use of the coerce feature of Zod. However this works better for some data-types than others.
In my case i would like to coerce for numbers (z.coerce.number()) and not strings, since they behave pretty badly ref.
Here's my current config
import { defineConfig } from '@kubb/core';
import { pluginOas } from '@kubb/plugin-oas';
import { pluginZod } from '@kubb/swagger-zod';

export default defineConfig({
  input: {
    path: './test/openapi-spec.yaml',
  },
  output: {
    path: './test/generated',
  },
  plugins: [
    pluginOas({
      output: {
        path: '.json-schemas',
      },
      validate: true,
    }),
    pluginZod({
      output: {
        path: 'schemas',
      },
      typedSchema: true,
      dateType: 'stringOffset',
      unknownType: 'unknown',
      coercion: true,
      importPath: 'zod',
    }),
  ],
});

I would like to add another option to the Zod plugin
export type Options = {
   ...
   coerceTypes: { // Default value would be true for all, to be backwards compatible
     date: boolean
     strings: boolean
     number: boolean
   },
   ...
}

And then use that in conjuction with the coercion option, to enabled coercion.
I'd be down to write the PR as well, if you accept this enhancement.

This was already something that was requested before so I was planning to add this as part of Kubb v3. More people needs this so happy to see some ideas here.
What if we just use one option to specify the coercion:

When true it will reuse the same logic as of today but you can then also allow an object where an user of Kubb can specify what primitive needs coercion.
This means that behind the scenes we will transform true into an object {      date: true,      string: true,      number: true    }

export type Options = {
   ...
   coercion: boolean | {
     date?: boolean
     string?: boolean
     number?: boolean
   },
   ...
}

Thoughts and thanks in willing to take this up?

@ChilloManiac Aha great to hear, with v3(which is now being used on the master branch) we will already have a major bump so I'm not seeing issues in doing it this way(can also be added to v2 if needed). coercion is already passed through so probably changing the type with some changes in plugin-zod/src/parser/index.ts will workout.

This feature will be part of Kubb v3 3.0.0-beta.3 and Kubb v2 2.28.0


[DNM] [nrf mergeup] Mergeup ac55554

This is upmerge to v1.4.0

TLV parsing reworked

new protected TLV format

kconfig option for multi image

imgtool: allow address adjustment in output hex

existing features code rework (code optimization and sharing)

bugfixes: pre-release version stabilization

Internal CI Error.
Python exception in ../ci-tools/scripts/check_compliance.py:
Traceback (most recent call last):
  File "../ci-tools/scripts/check_compliance.py", line 1269, in main
    n_fails = _main(args)
  File "../ci-tools/scripts/check_compliance.py", line 1215, in _main
    test.run()
  File "../ci-tools/scripts/check_compliance.py", line 743, in run
    py_files = filter_py(files)
  File "../ci-tools/scripts/check_compliance.py", line 772, in filter_py
    return [fname for fname in fnames
  File "../ci-tools/scripts/check_compliance.py", line 774, in <listcomp>
    magic.from_file(fname, mime=True) == "text/x-python"]
  File "/usr/local/lib/python3.6/site-packages/magic.py", line 136, in from_file
    return m.from_file(filename)
  File "/usr/local/lib/python3.6/site-packages/magic.py", line 86, in from_file
    with open(filename):
IsADirectoryError: [Errno 21] Is a directory: 'ext/mbedtls'

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@carlescufi, @thst-nordic
Zephyr build mcuboot doesn't use ext/mbedtls submodule. For Zephyr/NCS there is neither need for use this submodule nor for pull it via west to ext/mbedtls path.
Zephyr build uses mbedtls bundled into zephyr (except mbedtls-asn1 which is copy-paste into mcuboot ext/ sources)

@carlescufi, @thst-nordic
Zephyr build mcuboot doesn't use ext/mbedtls submodule. For Zephyr/NCS there is neither need for use this submodule nor for pull it via west to ext/mbedtls path.
Zephyr build uses mbedtls bundled into zephyr (except mbedtls-asn1 which is copy-paste into mcuboot ext/ sources)

Thanks @nvlsianpu . CC @mbolivar. How do we fix CI though?

^^ simplest way would be disabling pylint module in check-compliance run (-e pylint). Better would be instructing the pylint run to skip problematic location.

^^ simplest way would be disabling pylint module in check-compliance run (-e pylint). Better would be instructing the pylint run to skip problematic location.

That would probably cause upmerges to fail if there are changes to that submodule. I wonder if we could just disable pylint instead? Could you try this @thst-nordic and @nvlsianpu ?

^^ yes will try.

@ru-fu, @carlescufi  CI failed now on DOC as the documentation wrapper is not update on nrf master. Such patch is in manifest counterpart: https://github.com/NordicPlayground/fw-nrfconnect-nrf. Can I apply separate patch with wrapper update to nrf and merge it for making thi CI green?

@ru-fu, @carlescufi CI failed now on DOC as the documentation wrapper is not update on nrf master. Such patch is in manifest counterpart: https://github.com/NordicPlayground/fw-nrfconnect-nrf. Can I apply separate patch with wrapper update to nrf and merge it for making thi CI green?

Yes, I don't see why not. Please make sure to copy @thst-nordic and @ulfalizer and myself in the PR you send against fw-nrfconnect-nrf


Extrapolation detector

A sort of simplified (and more trigger-happy) version of the sklearn distribution comparator, this would simply check each feature to see if it is in the training domain or not.
So during fit the detector learns the range of each feature. During transform it compares each feature in turn.
The alarm would sound if any features are outside. Could use rf.sklearn.BaseRedflagDetector for this.
A threshold argument could allow the user to turn the sensitivity up or down, e.g. allowing an atol or rtol float (or array? One for each feature) to be passed.

Also known as 'covariate shift'
Really not sure this is substantially different from the DistributionComparator


Astropy Affiliated Package Review

This package has been reviewed by the Astropy coordination committee for inclusion in the Astropy affiliated package ecosystem.
We have adopted a review process for affiliated package that includes assigning quantitative ‘scores’ (red/orange/green) for different categories of review. You can read up more about this process here. (This document, currently in Google Docs, will be moved to the documentation in the near future.) For each of the categories below we have listed the score and have included some comments when the score is not green.

Functionality/Scope
No further comments
Integration with Astropy ecosystem
The first example uses the csv module rather than making it easy to get an Astropy Table object and allowing the user to then write that out to any Astropy-supported format. It would also be good to return Quantities in cases where the user accesses e.g. 'first.ra'. There are also places where you do actually have integration with astropy, e.g. it's possible to pass a SkyCoord to the pos= argument in the image search, but the docs don't show that.
Documentation
The documentation is good overall but as mentioned above there are places where it could be simplified or better showcase using it with astropy objects.
Testing
Coverage could be improved, and the automated builds are currently failing.
Development status
No further comments
Python 3 compatibility
No further comments

Summary/Decision: This package meets the review criteria for affiliated packages, so we are happy to confirm that we'll be listing your package as an affiliated package! Keep up the good work, and we encourage you to improve on the areas above that weren't “green” yet.
If you agree with the above review, please feel free to close this issue. If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the coordination committee, and we’ll do a new review. Note that we are in the process of redesigning the http://affiliated.astropy.org page to show these scores (but not the comments). Finally, please keep the title of this issue as-is (“Astropy Affiliated Package Review”) to make it easy to search for affiliated package reviews in future.

I'll use this thread to comment on the development status.
Documentation (latest / master) was re-written to be more compact and better showcasing astropy objects.

Tests are working (again), and it is planned to update unittests with a better test infrastructure which doesn't require sockets (https://github.com/pyvirtobs/pyvo/issues/92)

Closing this one out as I think we passed and we are heading forward with whatever we need to do to stay in sync with astropy best practices.


2 instances of pimd - wrong second gateway to RP

pimd -v 2.3.1
Same RP for both subnets - <IP_ADDRESS>
First run in default table,second run in it's own table.
Debug:
#################################################
Virtual Interface Table ====
Vif  Local Address    Subnet              Thresh  Flags      Neighbors

0  <IP_ADDRESS>     192.168.80/30            1  DISABLED
1  <IP_ADDRESS>       <IP_ADDRESS>/30            1  DISABLED
2  <IP_ADDRESS>     10.201.230/30            1  DISABLED
3  <IP_ADDRESS>      10.204.32/23             1  DISABLED
4  <IP_ADDRESS>     <IP_ADDRESS>/30          1  DR PIM     <IP_ADDRESS>
5  <IP_ADDRESS>     10.205.110/23            1  DR NO-NBR
6  <IP_ADDRESS>     register_vif0            1
Vif  SSM Group        Sources
NETLINK: ask path to <IP_ADDRESS>
NETLINK: vif 2, ifindex=58
NETLINK: gateway is <IP_ADDRESS>
For src <IP_ADDRESS>, iif is 2, next hop router is <IP_ADDRESS>: NOT A PIM ROUTER
#####################################################################3
<IP_ADDRESS> - wrong; it's from 1st instance/net
should be <IP_ADDRESS>
unicast routing is fine,

Thank you for the report. Maybe @idismmxiv or @markusve can better answer this one?

hmm ...  @idismmxiv or @markusve  - 1 month no activities ;(
I will try run both pim daemons in not default routing table and see what happens

@Kzibi that could actually very well help! I'm unfortunately not up to speed on how Linux's CONFIG_IP_MROUTE_MULTIPLE_TABLES works, but I can imagine that both instances must run in their own table, and none of them in the default table.
Would be awesome to hear back from you if that works, then I can update the docs and we can clarify this issue for future improvement, i.e. add detection of more pimd instances and warn the user.

I might be wrong, but this is how I see the case.
To be able to run multiple pimd instances, you need to have multiple multicast routing tables. One for each instance. But currently pimd does not support multiple unicast routing tables. I have used multiple pimd instances with multiple multicast routing tables, but newer trying to share single IP (like RP address in this case) in both instances.
I suppose there is a room for improvement in netlink.c to handle unicast route queries based on multiple routing tables. Or to use LInux namespaces, but I haven't tried that.

So ;)  .. I try  ... no success

but newer trying to share single IP (like RP address in this case) in both instances.

this is the clue
I think, that pimd (netlink) should use only if's from conf file and do some test like ex.:
ip route li table xx | grep RP
OR
ip route get RP oif from_config ( it need's output interface name not address in config file).


Exception when determining access permissions to a site

An ActionView::Template::Error occurred in sites#show:

Access level '[:owner, :reader]' is not in available levels '["owner", "writer", "reader"]'.
lib/modules/access/validate.rb:22:in `level'

...

------------------------------- Backtrace:

lib/modules/access/validate.rb:22:in `level'
lib/modules/access/core.rb:73:in `get_level_name'
app/views/sites/show.html.haml:32:in `block in _app_views_sites_show_html_haml___2432286511837677952_31568600'

This error occurred again. Happens for non-admin users, that also are owners for their projects.
An ActionView::Template::Error occurred in sites#show:

Access level '[:owner, :reader]' is not in available levels '["owner", "writer", "reader"]'.
lib/modules/access/validate.rb:22:in `level'
------------------------------- Request:

* URL        : https://www.ecosounds.org/projects/xxx/sites/xxx

Another case:
Access level '[:owner, :reader]' is not in available levels '["owner", "writer", "reader"]'.
lib/modules/access/validate.rb:22:in `level'


Context with hash marks do not work as expected

Describe the bug
In the predefined US_SSN recognizer context the ssn# and ss# context words do not work as expected because spacy tokenizes the hash mark:
[decision_process][INFO][None][nlp artifacts:{"entities": ["My ssn#"], "tokens": ["My", "ssn", "#", "is", "123", "-", "45", "-", "1234"], "lemmas": ["my", "ssn", "#", "be", "123", "-", "45", "-", "1234"], "tokens_indices": [0, 3, 6, 8, 11, 14, 15, 17, 18], "keywords": ["ssn", "123", "45", "1234"], "scores": [0.85]}]

ssn# works OK because this is tokenized as ["ssn" and "#"] and ssn is also in the context list, however, ss# does not work
[decision_process][INFO][None][nlp artifacts:{"entities": [], "tokens": ["My", "ss", "#", "is", "123", "-", "45", "-", "1234"], "lemmas": ["my", "ss", "#", "be", "123", "-", "45", "-", "1234"], "tokens_indices": [0, 3, 5, 7, 10, 13, 14, 16, 17], "keywords": ["ss", "123", "45", "1234"], "scores": []}]

To Reproduce
Steps to reproduce the behavior:

Use US_SSN entity and a string with ss#
See that it is not detected as context (0.5 default score is not improved)

{'recognizer': 'UsSsnRecognizer', 'pattern_name': 'SSN5 (medium)', 'pattern': '\\b([0-9]{3})[- .]([0-9]{2})[- .]([0-9]{4})\\b'...edium)`', 'score_context_improvement': 0, 'supportive_context_word': '', 'validation_result': None, 'regex_flags': regex.I|M|S}

Expected behavior
All words in the predefined context should be detected correctly.  If values with a hash mark cannot be detected correctly they should at least be removed from the list.
Screenshots
See logging and debugger output above
Additional context
n/a

Thanks, and apologies for the delay in answering. The context words are currently used by the existing context mechanism (LemmaContextAwareEnhancer) but there are alternative implementations one can think of, for example comparing substrings. Therefore, I don't think it's a good idea to remove those. if you or anyone else is interested in creating an alternative context approach, we'd be happy to review it and incorporate it into the package.

@omri374 that's fine - however in the meanwhile do you think it makes sense to remove ss# and ssn# from the default CONTEXT since they don't actually work?

Sure, that makes sense. Would you like to create a PR?


Early fusion multimodal models

Context
This enables Early Fusion models based on @pbontrager 's excellent original RFC on multimodal fusion models #1283. Since the RFC, we have already landed Deep Fusion model components. This PR discusses and implements the EarlyFusionModel component, along with testing and some lint updates.
Early fusion is simply a decoder with 1 or more extra encoders that merges their outputs with the token embeddings tables. The challenge lies in how we merge the embeddings and pass it into the decoder.
Design
There is one design consideration I am seeking feedback on, and that is the EarlyFusionModel's usage of self.decoder.tok_embeddings. It accesses the decoder's token embedding table outside of the decoder forward because we need to merge the image encoder and any other modality encoder's output embeddings with the text embeddings (in this case just concatenate in sequence dimension):
embeds = self.tok_embeddings(tokens)
bsz, seq_len, embed_dim = embeds.shape
for encoder, inp in (encoder_input or {}).items():
    encoder_embeds = self.encoders[encoder](**inp)
    encoder_mask = (tokens == self.encoder_tokens[encoder]).expand(bsz, seq_len, embed_dim)
    embeds[encoder_mask] = encoder_embeds

output = self.decoder(embeds, mask, input_pos)
return output

Now, instead of token ids, we are passing in the merged embeddings directly into the decoder. But since we already used the text-only tok_embeddings from the decoder, we need to skip it when passing in the merged embeddings for the final decoder output. There are two ways we can do this.
State dict surgery
In the current code changes and suggested by the original RFC, we can manually set self.decoder.tok_embeddings = nn.Identity() so that it becomes a no-op when you forward pass with merged embeddings.

This will require additional state dict hooks to make sure checkpoint saving and loading is still maintained despite the module change
If a user wants to use the decoder outside of the EarlyFusionModule in the same script, they will need to restore the original tok_embeddings module from nn.Identity

Additional input_embeds kwarg
We could add a new keyword argument in TransformerDecoder forward for input embeddings. If this is passed in, we automatically skip the token embeddings:
h = self.tok_embeddings(tokens) if input_embeds is None else input_embeds

This way we don't need any state dict hooks or decoder modifications. However, we are polluting the decoder model forward with more arguments.
Test plan

Add forward pass decoder + encoders test
Add forward pass decoder only test
Add forward pass encoders only test, check to see embeddings are merged correctly in correct sequence placement
Verify state dict hooks by loading a state dict with "decoder" labels then saving the same state dict

Thanks for the RFC, you made it very clear what's difference between early fusion and late fusion!
About the design choice, I personally prefer Option 2 for the same reason as you mentioned. I think it's fine to "polluting" the decoder model forward a bit with some optional arguments for each modality. We might need something like
h = self.tok_embeddings(tokens)
if speech:
   h[speech_mask] += speech_encoder(input)
if image:
   h[image_mask] += image_encoder(input)

11th hour comment on the open design question: in my mind there are nonzero UX costs to either approach. If we patch the decoder embeddings to nn.Identity we introduce additional indirection that is pretty trivial but also pretty non-obvious (I claim any state dict hook is non-obvious when first debugging the inevitable key mismatch error until you find the actual code pointer). On the plus side, we fully contain the blast radius to multimodal model code, and text-only users do not have to worry about it. Conversely, I know we don't want to just add a bunch of random arguments to TransformerDecoder forward, especially ones that are very specific to multimodal models.
Personally I really don't like state dict hooks for the reason I described above. As soon as something (inevitably) goes wrong, it will take a lot more debugging and head-banging-against-the-wall before the user realizes that things are being swapped out under the hood. So perhaps it's no surprise, but I vote for the simple and dumb thing: just add an extra parameter to TransformerDecoder forward. I know that may be controversial, but I like doing the obvious thing, and I like to think our users would appreciate that as well.

After extensive discussion offline, we decided to move ahead with the state dict hook approach. All current changes reflect this.

What were the high level reasons for this, if I may ask?

Other fusion layers already use state dict hooks extensively, so there is some precedent
Reluctance to add more bloat to the TransformerDecoder forward
Other solutions would require decoders to be built differently to account for a fused embedding (i.e., a FusedEmbedding layer instead of nn.Embedding for tok_embeddings) and somewhat defeats the purpose of a separate EarlyFusionModel class

cc @ebsmothers @pbontrager


inline function ‘cpu’ declared but never defined

I have faced issue below:
sh# make
[CC] x86_64/processor_local_storage.c
In file included from x86_64/processor_local_storage.c:9:0:
./x86_64/include/lapic.h:87:17: error: inline function ‘cpu’ declared but never defined [-Werror]

I've fixed it with change inline cpu() to extern cpu() in ./x86_64/include/lapic.h and ./x86_64/lapic.c. Because this function is called as external linkage.

Thanks for issue, This is an ongoing project for study use,  a lot of Intel CPU features are interesting me, that's why I filed this project to give a try. you can run the project with  KVM='--enable-kvm --cpu host' ZELDA64=/path/to/repo make run , recently I am trying vmx

This repo is really good to learn OS dev (MP, VMX initilization). I will write new features to this (task scheduling, Virtualization current state of OS etc.).
Thank you!

you are welcome to do this.
we can discuss and learn from all of it.!


Lazyload plugins that are not required on init

use the keys option in the use command for packer and set opt = true
https://github.com/wbthomason/packer.nvim#specifying-plugins

https://neovim.discourse.group/t/examples-of-lazyloading/2897


Simplify branch policies for azure-rest-api-specs repo

Today when creating dev branches in OpenAPIHub it create a unique branch protection for every branch which causes a number of issues.

Lots of branch protection policies that never get cleaned up
Lots of branches that never get cleaned up because the polices block anyone that is not an admin from deleting
Prevents teams from rebasing changes on main which causes a lot of noisy merges because the policy doesn't allow force push.

To help with these issues we should do the following:

Create a single branch protection for any branches following the existing naming convention of dev-*.  (ideally we would update this naming convention to something like feature/* or release/* but there are so complications with so we will not change the existing naming convention with this work).

Policy should require CI checks and approval for merging
Policy should allow force pushes so teams can rebase and clean their branch in preparation for going to main
Policy should allow deletion of branches so that teams can remove their branch one all their work is done

Clean-up all the existing branch protection policies to remove all the duplication

Yes Teams would include service teams or anyone working on a feature in the specs repo.
Can you give me more details on why you think those are in conflict with one another? Even if we enable allowing force push all the other branch protection rules must still be followed, including required checks, see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#allow-force-pushes.

After some further testing @heaths and I concluded we cannot have "required status checks" and "allow force push" in the same branch protection rule. While you can check the options there is no real way for someone to do it because github will block force pushes when there are required status checks that have not been met. However we should still enable the "allow branch deletions" option so that teams can clean-up their branches.

Allowing force push is not the only reason to have blanket policies, though. @weshaggard helped me recently recover from an issue where an old OpenAPI Hub-created branch policy referenced a pipeline name that got renamed or otherwise differed from the required check name. That blocked the PR and required an admin to fix it. Presumably, any earlier branch policy would be impacted.
All the branch policies were, at one point, the same anyway. There's no special permissions on them, so why even create specific ones? By having just a small handful of branch policies that match patterns like dev-* it's far easier to maintain those policies when necessary.
That also starts to obviate the need to create a branch in OpenAPI Hub. Apart from creating the branch (which anyone with push permissions can otherwise do) and branch policy, it copies files and updates the api-version which anyone can also do. Recently, to create a new api-version from another api-version feature branch, I even created a script to do this.

@weshaggard , I think the remained item for this issue is to clean up the other specific dev-xx policies with keeping only dev-* policy, right?

Assuming we have now updated openapi to not add the branch protections any longer then yes the last remaining part will be to delete all the old ones.

The change in openapi hub code will be released about next week. @weshaggard , will you help delete all the old policies from rest api spec repo?

@raych1 I can try and help if needed. Do you not have permissions to delete branch policies? If not perhaps @akning-ms can grant you permissions at least temporarily.

@weshaggard , can you help clean up the remained rules I sent to you in email?

Yes I will try to get those cleaned up this week.

This work is done now. The branch protections are much cleaner and easier to maintain now.


Add placeholder/remove How to add a Shaman link on Summon form

Overview
In the Summon form, the How to add a Shaman link in the Starting Shamans section is empty. I know we don't have docs in place yet, so maybe we could remove this or create a placeholder page/HackMD in the meantime to avoid unexpected results when a user clicks.

Should we link to this: https://baal-docs.vercel.app/tools/shaman

Should probably wait to update the link after the docs are deployed to the subdomain

@earth2travis Changing the description to reflect the current state of this after your recent fixes

this is updated, but i'm not seeing it on the live site yet.


DD-1009 Review PR

This PR is not intended to be merged. It merely serves as a way to annotate the code.
Problems

Some unit tests are silently ignored, e.g.,[INFO] Running nl.knaw.dans.sword2.resource.CollectionResourceImplTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.853 s - in

Note "Tests run: 0". There are more, run the build to get all the problematic cases. I noticed this when trying to run a
unit test in IntelliJ and it failed. I wondered why the build still succeeded, until I finally noticed the same test was simply
not run when building from the command line. The problem stems from your creating a DropwizardAppExtension as
static variable and initializing it during class creation instead. Make it a non-static and initialize it in startUp. At least
the problems with the config.yml aren't hidden then (although the errors that result are still a bit obscure to me).
Currently, the unit tests depend on src/test/resources/debug-etc/config.yml. However, that file has the specific purpose of serving as a template for debugging, i.e. it should contain sensible defaults for debugging sessions (working with the start.sh script, etc). These defaults are not likely to be the same as for unit testing. Create a separate config.yml for that in src/test/resources/test-etc.
I see some other config-*.yml files in src/test/resources/debug-etc/. What is theire purpose. I'd like to keep things lean, so get rid of them unless they are used in unit test (in which case they should be moved to test-etc, see previous point).
The file src/main/assembly/dist/cfg/config.yml should contain sensible defaults when installing the service via RPM. Currently, it seems a near copy of the debug-etc/config.yml.
Don't include IDE specific files in the project. If you want to use a different IDE that is fine, but make sure the generated files/dirs are ignored (e.g., /.project, /.settings for Eclipse).
Limit the application top level packages to the ones that DropWizard recommends, so make config a sub-package of core.
Get rid of src/test/resources/debug-etc/db.properties, as we are not using a database in this project.

Notify
@DANS-KNAW/dataversedans

Closing this PR, since all issues have been addressed by @ericdevries .


Referencing ES6 modules from JsInterop in J2CL+Closure

Depending on your perspective, this may be a bug report.
Description
The Closure Compiler supports ES6 modules, provided they are adapted to work with Closure's own module system. However, J2cl emits code which is incompatible with es6 modules, at least without an extra step of indirection.
This might also be more appropriate to discuss on the Closure Compiler issue tracker or mailing list, but I figured I should start here in case I am either missing something obvious, or there is a simpler answer than I am imagining.
Example: Given a plain JS module _with closure's workaround to let closure flavored modules access es6-flavored modules, and a @JsType-annotated class designed to provide access to it, it seems as though this should work out of the box:
goog.declareModuleId('my.js.module.SampleJsModule');
export function helloWorld() {
    return "Hello from a module"
}

@JsType(namespace = "my.js.module", isNative = true)
public class SampleJsModule {
    public static native String helloWorld();
}

By itself this compiles fine, but emits a compiler error in closure:
public class MyTest {
    @Test
    public void testText() {
        Assert.assertEquals("Hello from a module", SampleJsModule.helloWorld());
    }
}

/redacted/path/to/example/MyTest.impl.java.js:6: ERROR - [JSC_FORWARD_DECLARE_FOR_ES6_SHOULD_BE_CONST] goog.forwardDeclare alias for ES6 module should be const.
  6| let SampleJsModule = goog.forwardDeclare('my.js.module.SampleJsModule');
     ^^^^^^^^^^^^^^^^^^^^^^^

At first blush it seems like you could just replace this with const as requested, but this doesnt make sense since the class initializer will trigger external modules to be loaded:
 static $loadModules() {
  SampleJsModule = goog.module.get('my.js.module.SampleJsModule');
  Assert = goog.module.get('org.junit.Assert$impl');
 }

It turns out that closure has different limitations when using a "real" closure module and a "es6 module that supports closure module naming" - const must be used according to the error, which suggests perhaps that the goog.forwardDeclare should be named something else and never used? Based on the comments in base.js for goog.forwardDeclare, its possible that this line may not be necessary anyway (though the docs at least seem a little out of date - the link https://github.com/google/closure-compiler/wiki/Bad-Type-Annotation doesnt appear to exist), and that this was deprecated in favor of goog.requireType?
Describe the solution you'd like
Ideally, j2cl would support this case without any extra changes, like the below workaround.
Describe alternatives you've considered
The workaround we're currently using is to emit a "es6 to closure shim". First, the goog.declareModuleId line is modified to have some extra "i'm not available to be generally used in j2cl" suffix added, and then the "real" goog module is declared in its own file:
goog.module('my.js.module.SampleJsModule');

// oddly, this "let" doesn't bother closure?
// this must be a goog.require, since goog.module.get() isnt allowed to be used top-level, even in another goog.module.
let shim = goog.require('my.js.module.SampleJsModule.shim');

exports = shim;

Now the JsType and anything that relies on it works correctly.
Additional context
Note that for most es6 modules, they don't assume closure-library is available (see also: nearly everything in NPM), and a shim is required to make the es6 module work from closure modules at all. Something like this serves as a simple bit of boilerplate:
// shim from plain es6 module to closure module
import * as module from './SampleJsModule.js';
goog.declareModuleId('my.js.module.SampleJsModule.shim');

// default exports cause an extra wrinkle for closure modules, the
// 'my.js.module.SampleJsModule' must now export shim.module instead.
export {module};

Then, the closure+es6 to closure shim would reference this, the original es6 module is untouched, and the

IIUC, the essence of your problem is, JsCompiler complains in let x = goog.forwardDeclare(..) if the module is defined with goog.declareModuleId(..); is that correct?

That could be one potential solution, but I'm not certain that this the only or best way to resolve this sort of case. I'm not certain, but it might also be possible to have two different variables that store the referenced type - the let x_fwdD = goog.forwardDeclare('x') at the top level, and the x_module = goog.module.get('x') within $loadModules. It won't be that simple since various references (jsdoc, etc) will have to reference the renamed variable, but perhaps there is some middle ground that can be reached?
Like I said, the rules of forwardDeclare (or possibly requireType) aren't entirely clear to me, both exactly why it is used in this way, or why jscomp doesn't permit the use of let instead of const there.
In my very simple experiments of plain closure modules (rather than modifying j2cl or editing j2cl output), goog.require sufficed to reference es6 modules with a goog.declareModuleId call.

JsCompiler generally doesn't permit the use of let to avoid redefinitions of the types but current goog.module.get solution is the only way to make cyclic deps work at the moment and that requires aliases to be non-const.
If goog.declareModuleId doesn't work then you can ask for guidance from Closure team. Unless there is a reason for this to not work with the J2CL's current goog.module.get pattern, I think the error could be added to the J2clSuppressWarningsGuard and Es6RewriteModules can be slightly modified to continue with rewriting after error reporting.

Posted at https://groups.google.com/g/closure-compiler-discuss/c/dBgj7B3GqhE


Reference list not naved after drag-and-drop, resulting in missing radio buttons

Description:
When dragging and dropping a property that utilizes radio buttons from the data panel, the associated reference list property is not saved. Consequently, upon saving the form and rendering it, the radio buttons do not appear. Upon investigation in designer mode, it is observed that the reference list property is empty, contributing to the absence of radio buttons.
Steps to Reproduce:

Go to "https://function-adminportal-test.shesha.dev/dynamic/Shesha/test-pre-release"
Click the Add button
Navigate to the form designer
Drag and drop a property with radio buttons from the data panel onto the form e.g. gender.
Configure the reference list property
Save the form and render it
Observe that the radio buttons do not display.
Navigate to designer mode
Actual Results: Notice that the reference list property is empty again.

Expected Behavior:
When you drag and drop the reference list property from the data section, the reference list property should be prepopulated with the associated reference list name.
Form Configuration

Rendered Form:

Hi @hlayisanimazuze. It's fixed, please check

Hi @IvanIlyichev, This is partially resolved. When you drag and drop a reference list property from the data section, the property is already bound to the reference list name. However, the issue arises when rendering the form; the reference list items are not showing. When navigating to configurations, the reference list field is empty, and the previously bound reference list is removed. Refer to the attached video: https://boxfusionint-my.sharepoint.com/:v:/g/personal/hlayisani_mazuze_boxfusion_io/ERjl6TqRbqpGrB9Au7emy4QB3vnN89sKSbGRag_yESQPIg?e=4IaBrZ
Current behavior: When you configure the reference list name and render the form, now the reference list item shows
Expected Results: When you drag and drop a reference list property from the data section, since the property comes bound to the reference list name, when you render the form, it should show the reference list items.
Links:

https://function-adminportal-test.shesha.dev/shesha/forms-designer?id=9de95ba9-1517-45c9-8a00-cb43294305d6
https://function-adminportal-test.shesha.dev/dynamic/TestModule/reference-draganddroptable


[CLI] refactor the tool help system inside the cli

Hello Team. I would like to discuss this proposal.
Actually the cli show the help embedded in go code.
To begin a docops pratice in OpenServerless, it was decided to add markdown for each cli tool command in the "tool" directory. Another script, from the openserverless-site repository will catch these files from the repo and use them to autogenerate the website documentation.
THE GOAL: keep the website doc and the cli help aligned. So when the cli is changed a new site build will update the doc automatically.
So i suggest to make some changes to the CLI:

use the standard go embed fs to catch all the markdown files inside the tool directory.
ensure that each markdown file must be named exactly like the tool it documents (ex. datefmt tool will have datefmt.md file). We need to change the ToolList to choose which command has markdown help.
the markdown help will be fully printed by the ops cli when invoked with the -h (or --help) flag or when the command doesn't support -h flag but an invalid number of arguments are passed in (example tool remove).
add tests and bats tests for all modifications to cli and tools.

The markdown help file will always have this structure:
synopsys (short description of the tool)

```text
Usage:
    ops -<toolname> ...
```

## Options

 ```text
command options here
 ```

## Examples (optional)

optional examples here

Incidentally i wrote some code that implement the described features. The code is in my fork in these two commits:

Changes to the CLI
Markdown docs

This code is working, but not completed. Here the missing things (all easy to implement):

complete the modifications to each tools to display the markdown help
do the required changes to bats tests

Let me know if this can be done and i'll submit a PR.

Ok agreed.


Support InferenceComponent CRD.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/hold

/retest

/unhold

/retest

/retest

/retest

/retest

looks good at a high level

/retest

overall looks good. Have you verified the status of the IC prints in the console when using kubectl?

Yes, have verified creating IC via kubectl and the prints in the console.


[Windows] Drawer Flyout Presenter Crash

Current behavior

It crashes when pressing on a button flyout with FlyoutPresenterStyle.
Debug Output:
An unhandled exception of type 'System.AccessViolationException' occurred in Microsoft.WinUI.dll
Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Expected behavior

It should not crash when pressing on a button flyout with FlyoutPresenterStyle.

How to reproduce it (as minimally and precisely as possible)

Download DrawerFlyoutPresenterSample.zip
Start Solution with VS 2022 Preview 6
Start Windows (WinUI) Project
Click on Test button
Notice crash

Environment

Nuget Package:

Uno.Toolkit.WinUI
Uno.Toolkit.WinUI.Material
Uno.Material.WinUI

Package Version(s):

2.3.0-dev.5
2.3.0-dev.5
2.3.0-dev.4

Affected platform(s):

[ ] iOS
[ ] Android
[ ] WebAssembly
[ ] WebAssembly renders for Xamarin.Forms
[x] Windows
[ ] Build tasks

Visual Studio:

[ ] 2017 (version: )
[ ] 2019 (version: )
[ ] 2022 (version: 17.2.6)
[ ] 2022 (version: 17.3.0 Preview 6.0)
[ ] for Mac (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

I used this documentation.

Thanks for the report. As you're getting a crash, can you provide the full crash stack trace ?

@jeromelaban Done.


Unable to download data set

Hey! I tried to download the .zip files from the data set and couldn't do it because it redirects me to the initial page of the repo. Also, when I try to download any ROSBag data file, it says that I don't have permission. Could you fix it or share those files with me? I was trying to understand if they will be useful for my thesis - it would eventually serve as a data set to predict fast-moving UAV trajectories. Thank you!

@mcarvalho2001 I`ve change the access to public. Do let me know if you have other problems.
Rgs
Shenghai Yuan


Return was a mistake

#636 should not have been merged.
Return is an awful method name

return is a c# instruction, and use this word for a method is a really bad idea
Return doesn't give any clue of what the methods do
Used with a using static MoreEnumerable; it's just not readable:

  source.Select(Return);
  return Return(x);

It's about building a IEnumerable, it can be generalized and that should be MoreEnumerable.From (see #690) with different overload (param T[] being the start point).
The single item case can be optimized later.
If we need a special name for it, it should be something like Encapsulate, Wrap or Pack.
Return is an alias for a simple stuff

MoreEnumerable.Return is almost x => new[] { x }; it does not even shorten the summoning.

What about immutable list stuff ?
If the target functionality was to build immutable list, just generalize it:
IList<T> ToImmutableList<T>(this IEnumerable<T> source);  // the returned list is readonly.

return IReadonlyList is not enough since it doesn't provide CopyTo optimized methods.

We also can have a ImmutableList.From factory.

If we really want to add a specific method for the one element case, it should be something like Encapsulate, Wrap or Pack.

This has all been discussed, including choice of names, in #615.
/cc @MitchBodmer

/remind me about closing this in one week if there are no further comments.

Closing as there's been no follow-up.


Improve compatibility with clang-cl

Closes #1315
Just makes sure that clang-cl receives the same settings for warnings as MSVC and disable the same warnings in code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Menu: Ability to activate menu items on other routes

Sometimes Applications have actions that are not accessible from menu, so these actions do not activate menu items (Create, or Update actions)
Propose to add property to menu items to activate particular item even, if it is on different route

this feature is definately useful.
What is your rationale by doing this with a 'accessibleRoutes' array property instead of a flexible callback?

You can do this already on callback method, just simplicity
On Oct 28, 2016 17:59, "Boudewijn Vahrmeijer"<EMAIL_ADDRESS>wrote:

this feature is definately useful.
What is your rationale by doing this with a 'accessibleRoutes' array
property instead of a flexible callback?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yiisoft/yii2/issues/12869#issuecomment-256943648, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEuWHUAXBCGnh7ot78tLVfk7vadclZw4ks5q4g23gaJpZM4KjhLk
.

what if these other routes have special GET attributes?

Should alteady be addressed, sonce I am using same method as was on "url"
method

You can do this already on callback method

how?

item has active property

thats a property, not a callback ;). With respect to your implementation, I have my doubts.
Firstly, the naming of accessibleRoutes while you are actually insert $urls. Urls are not routes.
Secondly, the logic behind multiple routes serving the same menu item is questionable. This is likely to cause issues in the representation of a menu. Perhabs you mean urls, but then I come to my third point, which is flexibility. If we extend the Menu widget with extra functionality (you call it simplicity), it is favorable to use callbacks. The end user will have way more flexibility than with the use of arrays only. Perhabs an array will do for now, but I can imagine someone requesting this callback feature in the future. Its better to take this into account now already.

Firstly, the naming of accessibleRoutes while you are actually insert $urls. Urls are not routes.

Line 309 makes URL effectively a route see BaseUrl::to()
I made it so, because I didn't wanted to double the code, I would have to otherwise check url property seperately, but since it has same fingerprint as accessibleRoutes, it made sense to copy url to accessibleRoutes

Secondly, the logic behind multiple routes serving the same menu item is questionable. This is likely to cause issues in the representation of a menu.

See my issue

Perhabs you mean urls

You cannot activate urls (see Line 309)

If we extend the Menu widget with extra functionality (you call it simplicity), it is favorable to use callbacks

Now think of all the duplicated code on every repository, If you do not use accessibleRoutes it is effectiverly same code that is running right now

Perhabs an array will do for now, but I can imagine someone requesting this callback feature in the future. Its better to take this into account now already.

I do not see the benefit of callback, as it is static code anyways
we COULD modify active property to take in callbacks (same issue is then on yii\widgets\DetailView::$attributes "value" that doesn't take in callbacks, why, I do not know, but I use call_user_func to get around on that issue)

lines like this show that work has to be done on readibility and logic:
$item['accessibleRoutes'][] = $item['url'];

double dollar signs?:
foreach ($$accessibleRoute

With respect to the callback. What I mean is your implementation compared to a simple callback on the $active property. I would favor this last one because its simple and more flexibile. Like Yii actually.

IMHO the 'active' property of an menu item is already flexible enough:
'active' => Yii::$app->controller->id == 'ctrl', // active always when inside 'ctrl' controller

'active' => Yii::$app->controller->id == 'ctrl' && Yii::$app->controller->action->id == 'view', // active always when inside 'ctrl' controller and 'view' action

'active' => Yii::$app->controller->id == 'ctrl' && Yii::$app->controller->action->id != 'index', // active always when inside 'ctrl' controller except 'index' action

'active' => Yii::$app->controller->id == 'ctrl' && in_array(Yii::$app->controller->action->id, ['index', 'show']), // active always when inside 'ctrl' controller in 'index' and 'show' action

and so on...

Yes,
As I wrote I do not see a benefit in callback function anyway
Though, your idea of a wildcard is even better, but I do not have enough expertise to do it nicely
My proposition right now is:
[
    'accessibleRoutes' => [
        ['ctrl/index'],
        ['ctrl/view'],
        ['ctrl/update'],
        ['ctrl/create'],
    ]
]

Why inside array you ask?
Well because you could also do this
[
    'accessibleRoutes' => [
        ['ctrl/index'],
        ['ctrl/view', 'id' => 363], // Activate only, if we view an element with ID 363
        ['ctrl/update'],
        ['ctrl/create'],
    ]
]

A simple case could be solved with active property easily:
'active' => in_array(Yii::$app->controller->getRoute(), [
    'ctrl/index',
    'ctrl/view',
    'ctrl/update',
    'ctrl/create',
]),

It's getting more complicated in case of using parameters though so probably worth to be provided by framework. accessibleRoutes is a bad name. I propose activeOnRoutes.

if these routes are arrays, it should be named 'activeOnUrls'

@dynasource you can't really use Url-s there

well, either way, if the $property is named 'activeRoutes' someone would expect this format 'accessibleRoutes' => ['ctrl/index', 'ctrl/view', 'ctrl/update', 'ctrl/create'].

or
'activeOnUrls' => ['http://example.com','https://github.com']

well, why not support these as well. An URL is either an (yii) array or a (processed) url string.
Please take a look at the guide for the definition of routes
http://www.yiiframework.com/doc-2.0/guide-structure-controllers.html#routes:
A route is a string that consists of ...

https://github.com/yiisoft/yii2/blob/master/framework/widgets/Menu.php#L308
was like this :)

How about this:
'activeOn' => [
  ['ctrl/index'],
  'www.fancydomain.com',
  ['ctrl/view', 'id' => 27]
  'https://www.ultrasecure.com',
  '['other-ctrl/*'],
],

?

One could even merge this functionality into 'active'.
If 'active' is a callback that yields true/false, the value is accepted; if 'active' is an array, the given rules apply.

@thyseus what is the purpose to add support for activating items on other domains
Why would we add this to active property?


Recover after crates downloading suddenly break off.

When I was running cargo build --release, my computer suddenly poweroff(cargo was downloading crate then).
So,I restart my computer, run cargo build --release again.
The error occur:
$ cargo build --release
error: unable to get packages from source

Caused by:
failed to download replaced source `registry https://github.com/rust-lang/crates.io-index`

Caused by:
failed to parse manifest at `/home/zoumi/.cargo/registry/src/mirrors.xxxx.com-      07d6cef1b9e54f94/syntex_errors-0.42.0/Cargo.toml`

Caused by:
no `package` or `project` section found.

It seem the file is broken, and cargo isn't able to recover.
(Sorry for my poor english.)

The file /syntex_errors-0.42.0/Cargo.toml is empty.

If I delete the file, another error occur:
error: unable to get packages from source
Caused by:
failed to download replaced source registry https://github.com/rust-lang/crates.io-index
Caused by:
failed to read /home/zoumi/.cargo/registry/src/mirrors.xxxx.com-07d6cef1b9e54f94/syntex_errors-0.42.0/Cargo.toml
Caused by:
No such file or directory (os error 2)

If it is not too bad for you (if you have a good internet connection and are OK with downloading all the crates again), you can just remove the $HOME/.cargo/registry/ and $HOME/.cargo/git/ directories.

Curious!
As @Luthaf mentioned you can delete the whole registry folder and Cargo will recreate it. In theory this shouldn't happen as Cargo's hardened against failures like this, but there's perhaps a bug in those mitigations!

As you can see,I was using a mirror to download crates. These days, our goverment is going to block github.com.

It looks like I just experienced the same issue on Windows 10, with:

cargo 1.72.0 (103a7ff2e 2023-08-15)
rust-analyzer version: 0.3.1649-standalone (2df30e1e0 2023-09-03) (VS Code extension)

For me the PC crashed while rust-analyzer was building the project. After the PC restarted rust-analyzer failed to build the project.
For example:
Caused by:
  unable to get packages from source

Caused by:
  failed to download replaced source registry `crates-io`

Caused by:
  failed to parse manifest at `<user>\.cargo\registry\src\index.crates.io-6f17d22bba15001f\serde_json-1.0.106\Cargo.toml`

Caused by:
  could not parse input as TOML

Caused by:
  TOML parse error at line 1, column 1

That Cargo.toml file indeed seems to be corrupted and contains ~2KB of NUL bytes (and nothing else). There was also a Cargo.toml.orig file whose content seems to be correct wellformed TOML. And also a .cargo-ok and a .cargo_vcs_info.json file.
Running cargo clean followed by cargo test (which uses serde_json as dev-dependency) from the command line also causes this error.
Deleting those broken dependencies under <user>\.cargo\registry\src\index.crates.io-6f17d22bba15001f solved the issue.

The title of this issue is about interrupted downloads but the examples are for interrupted extractions which needs a separate solution.
Renaming accordingly.

This was opened in 2017 and our solution to this has changed a lot since then, for a history of it see
https://github.com/rust-lang/cargo/blob/c956e9f41c8a483385492b5b6c76cada8dd781cc/src/cargo/sources/registry/mod.rs#L551-L599
while we don't write the .cargo-ok file atomically, if its not a valid json file, we clear the cache and re- extract it.
What would be useful to know for anyone having problems with interruption recovery when extracting the files

what versions of rust are installed
the content of .cargo-ok


[BUG]: documentation in values.yaml toleration for running on master node incorrect

Bug Description
READ THIS IN "BLOCK QUOTE" STYLE.
In csi-unity/helm/values.yaml in the tolerations section comments, it uses a toleration of
#tolerations: Define tolerations for the controllers, if required.
Default value: None
tolerations:

key: "node-role.kubernetes.io/master"
operator: "Equal"
value: "true"
effect: "NoSchedule"
This will not successfully place the controller(s) on master nodes. It needs to be like in csi-powerflex and csi-powerstore:

tolerations: Define tolerations for the controllers, if required.
Leave as blank to install controller on worker nodes
Default value: None
tolerations:

key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"

Logs
tolerations: Define tolerations for the controllers, if required.
Leave as blank to install controller on worker nodes
Default value: None
tolerations:

key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"

Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
documentation.
Expected Behavior
Default value: None
tolerations:

key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"

CSM Driver(s)
CSI Driver for unity
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
Kubernetes 1.23.1
Operating System
RHEL 8

Fixed and merged


Install node on Umbrel w/ Raspberry Pi

What's the easiest way to add NodeJS to my Umbrel?
I get the error of Err:2 http://deb.debian.org/debian buster/main arm64 libuv1 arm64 1.24.1-1  404  Not Found [IP: <IP_ADDRESS> 80] when I try sudo apt install nodejs

Hi, can you be more specific on what you are trying to accomplish?
where are you running the command, env details, etc.

Hey Mike, I'm going to close this issue for now, but if you'd still like assistance, can you please post about this on our community forum (https://community.getumbrel.com/) - there are far more people on that platform who are tinkering with their Pi's, so it's more likely that somebody there has managed to install nodejs.


Can't install fuzzy completion on OSX Big Sur/Homebrew

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh (with oh-my-zsh, in case that is relevant)
[ ] fish

Problem / Steps to reproduce
I installed fzf without problems using Homebrew:
$ brew install fzf
==> Downloading https://ghcr.io/v2/homebrew/core/fzf/manifests/0.29.0
Already downloaded: /Users/eric.fulmer/Library/Caches/Homebrew/downloads/6284d746f3b41ac1784b093454fc42c132fa6d70707fc50b3812f8eefbc5919d--fzf-0.29.0.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/fzf/blobs/sha256:dadc361593396ced96c13d3695019a302d124e6cfe8ab6ffe65ba7877025a706
Already downloaded: /Users/eric.fulmer/Library/Caches/Homebrew/downloads/609d880737458a0f20ae9a91829d333bdbf29c6cadaec4f4f5a12d0d7b6b7ee5--fzf--0.29.0.big_sur.bottle.tar.gz
==> Pouring fzf--0.29.0.big_sur.bottle.tar.gz
==> Caveats
To install useful keybindings and fuzzy completion:
  /usr/local/opt/fzf/install

To use fzf in Vim, add the following line to your .vimrc:
  set rtp+=/usr/local/opt/fzf
==> Summary
🍺  /usr/local/Cellar/fzf/0.29.0: 17 files, 2.6MB
==> Running `brew cleanup fzf`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

But when running $(brew --prefix)/opt/fzf/install or /usr/local/opt/fzf/install, it will stop at Checking fzf executable ... seemingly forever (over 30 minutes so far):
$ eric.fulmer@FFUSM2DDALAMD6M  ~  /usr/local/opt/fzf/install
Downloading bin/fzf ...
  - Already exists
  - Checking fzf executable ... 0.29.0

Glad to provide more info if there's any other diagnostic steps I can take.

You might want to examine what's going on with -x option of bash.
bash -x /usr/local/opt/fzf/install


Incorrect fusemaps for IMX8MP

JTAG_MODE should be JTAG_SMODE
I can't get my hands on "Security Reference Manual for i.MX 8M Plus Applications Processor"
Maybe there are other fuses that need to be added/corrected.

Fixed in https://github.com/f-secure-foundry/crucible/commit/2d3048bd8df38bb98da29ac323062ff590b524b0.
Thanks


1.20.6 and 1.21

any plans to update to 1.20.6 and 1.21?

This is so essential for laptops to play shaderpacks.

I have made a fork of resolution control and added support for 1.21! I will try to update this for as long as I can. @itsarian @BlankMya
You can download my fork here: https://modrinth.com/mod/resolutioncontrol3/
And view the source code here: https://github.com/BGP0/ResolutionControl-3/
Please join our discord at https://discord.com/invite/qJVwSK99G2 if you have any questions.


[enhance] [client-consumer] Enhance robustness in consumer executeNotifyCallback.

Fixes #15106
Motivation
Fix message discard problem when  pending receives all done
Documentation

[x] no-need-doc
(Please explain why)

@horizonzy - given that there is no race because the use of a single thread for updating pendingRecieves is intentionally part of this class's design, I don't think there is any need to change the current code. Do you agree?

Thanks all reviewd, I got it. This enhancement looks unnecessary, close it.


check if cluster is created before adding it

sacctmgr complains if one tries to add a cluster that already exists.
https://github.com/CSC-IT-Center-for-Science/ansible-role-slurm/blob/master/tasks/service.yml#L183

failed: [io-install.fgci.csc.fi] => {"changed": true, "cmd": ["sacctmgr", "-i", "add", "cluster", "io"], "delta": "0:00:00.166378", "end": "2015-11-24 10:09:55.587566", "rc": 1, "start": "2015-11-24 10:09:55.421188", "warnings": []}
stdout:  This cluster io already exists.  Not adding.


HBASE-22226 Incorrect level for headings in asciidoc

Changes made and warnings are gone.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
22
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
257
master passed

0
refguide
434
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
241
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
435
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1486

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-244/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/244

Optional Tests
dupname  asflicense  refguide

uname
Linux 117dd2450f31 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / cb32f4faf0

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-244/1/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-244/1/artifact/out/patch-site/book.html

Max. process+thread count
76 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-244/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Provide 'old' configurator to support older hardware/builds

As hinted in issue #15, the configurator no longer supports older builds of OpenDeck.
It's great that the feature set of the project is moving on and I think you are really awesome for doing and 'donating' the project to the masses via GitHub.
Unfortunately the masses are not always as keen/able to update the firmware on their units. This is especially true when all you need to do is tweak a setting before a gig, but then find out things have changed since you last configured.... :-O
Can I suggest that the 'new' configurator provides links to older copies of itself to support older hardware/builds? I guess this could just be a link to an old copy in a subdirectory.
Perhaps the configurator could use the version number returned from the hardware and make the selection automatically.

As hinted in issue #15, the configurator no longer supports older builds of OpenDeck.

Well, it doesn't support only the General tab, the rest of the configurator works.
This is something I really don't like in the configurator but as I've mentioned on few places the UI was developed by someone else. I am unable to change and tweak the underlying logic behind it since 1) I am not a Web developer and 2) even if I was, the core UI code was run through obfuscator and the original source code is lost. As a result, core code is a mess. As soon as I add something new to the OpenDeck/UI, the UI either crashes or just blanks the entire screen for a tab in which settings have been added (unless the firmware on the board is on latest version) which annoys my users as much as it annoys me.

Perhaps the configurator could use the version number returned from the hardware and make the selection automatically.

That was my idea as well, but I don't know how to do it. Ideally, parameters which can't be retrieved just wouldn't be loaded instead of crapping out the entire screen.

I will try to build offline version of the configurator using Electron or something similar and bundle it with each release. This should somewhat resolve this.

Info on how to access older versions of UI is now mentioned in README. Also, each release now contains link to fixed version of the tool:
https://github.com/paradajz/OpenDeck/releases


Remove src/ directory from bundled extension

Seems like it's not necessary, and should be a simple addition here: https://github.com/b12io/kinase/blob/02f7e9368c707f135cc30403cc0b087ec39c6e8d/Kinase.js#L58
Happy to write a pull request.

Sounds great! Send a PR our way. Thanks for using and contributing to Kinase!


Old MIT license file is still present in the repo

I assume the old LICENSE (MIT) file shouldn't be part of the repo now that the new License.txt (Apache v2) got merged into master.
https://github.com/Microsoft/clrmd/blob/master/LICENSE
https://github.com/Microsoft/clrmd/blob/master/License.txt

Should be fixed with the most recent pull request merge.


composer killed during ddev composer (Out of memory)

Describe the bug
Running through the Drupal 8 Quickstart steps, which I've never done before, everything worked except the installation of Drush using ddev composer.
I got this output (following the actual command of course):
% ddev composer require drush/drush
Using version ^10.3 for drush/drush
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
bash: line 1:  1799 Killed                  ( composer require drush/drush )
composer [require drush/drush] failed, composer command failed: exit status 137. stderr=

I've almost always run composer on the host, so I've never seen this before.  I tried running composer after a ddev ssh, which also got killed.  The last line before termination, run with the verbose flag, was:
Reading /mnt/ddev-global-cache/composer/repo/https---repo.packagist.org/provider-zendframework$zend-stdlib.json from cache
Killed

To Reproduce
As documented here:
mkdir my-drupal8-site
cd my-drupal8-site
ddev config --project-type=drupal8 --docroot=web --create-docroot
ddev start
ddev composer create "drupal/recommended-project:^8"
ddev composer require drush/drush
ddev launch

That second to last line was where I saw the issue.  Everything else worked fine, and when I ran composer require drush/drush on the host, that worked fine as well.
Expected behavior
I was expecting composer to run to completion as per usual.
Version and configuration information (please complete the following information):

Host computer OS and Version: macOS Catalina
Docker Desktop version: <IP_ADDRESS>
ddev version: v1.16.0-alpha5

There's no custom config here.  I have docker set to its defaults for resources: 4 vCPU, 2 GB RAM, 1 GB swap, lots of disk space left.  This certainly seems like a resources issue, but I've never had any trouble with any real Drupal sites using this config, so I didn't think a basic test project would trigger something for that reason.

What you're seeing is the composer process being killed because you're out of memory.
Solutions:

Increase the memory allocated to docker
Stop other projects you may have running. ddev list and ddev stop <proj1> <proj2> ... or ddev poweroff and then start the one project.
Try composer2, which is much lighter on memory usage. See https://github.com/drud/ddev/issues/2383

BTW, I think this happens a lot since Docker <IP_ADDRESS> came out, not sure what they may have done in the memory management side of things there.  But it's a classic and typical composer behavior, you'll find a thousand hits on google, and composer 2 is aimed squarely at this problem.

Thanks @rfay. I should have guessed this was the issue. I'll give composer 2 a try at some point here.

What is the CLI command to specify Composer version 2? would it be
ddev config --composer=2 or --composer-version=2 or ????

What is the CLI command to specify Composer version 2? would it be
ddev config --composer=2 or --composer-version=2 or ????

Please use ddev help config  or ddev config -h to find out things like this. It's lots faster and easier :)
ddev config --composer-version=2
It requires a ddev restart afterward

Please use ddev help config  or ddev config -h to find out things like this. It's lots faster and easier :)
ddev config --composer-version=2
It requires a ddev restart afterward


Suggested condition for VkPipelineInputAssemblyStateCreateInfo

Hi @realitix , according to Vulkan spec on Drawing Commands, primitiveRestartEnable must be VK_FALSE for certain topology.
I like to suggest appending VkPipelineInputAssemblyStateCreateInfo with the below condition. What do you think?
def VkPipelineInputAssemblyStateCreateInfo(#sType=VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO,pNext=None,flags=None,topology=None,primitiveRestartEnable=None,):
    disallow_primitiveRestartEnable = (0,1,3,6,8,10) ##new
    if topology in disallow_primitiveRestartEnable: primitiveRestartEnable=VK_FALSE ##new

    return _new('VkPipelineInputAssemblyStateCreateInfo', sType=sType,pNext=pNext,flags=flags,topology=topology,primitiveRestartEnable=primitiveRestartEnable)

Hello @sunbearc22, I would like to keep this wrapper as thin as possible.
It's the developer who must add this condition.
Thanks


Improve OnTradeOfferUpdated mimicking OnNewTradeOffer

OnNewTradeOffer previously was fired when tradeoffers came in that were active.
Before this commint, outgoing and incoming offers that were already accepted showed up in this event.

Remove isOurOffer checking and all will be good

Seems reasonable, and it's just the demo-handler so it won't affect most SteamBot users.  LGTM

@BlueRaja thanks :) It's a demo handler but people are going to use this to base their own handlers on (like I did :))
@RafalNiewinski isOurOffer is to check if this offer came from us. So if you negate that (is not our offer) we get incoming offers from other accounts.


CoreUI Pro 3 (rc) - Missing node_module

OS: Windows 10
Node Version: 13
CoreUI Version: 3.0.0-rc

I do have a Pro license but I can't find any documentation if I need to put this somewhere.
After changing the src/scss/styles.scss file to allow the dark theme, there seems to be a missing node_module .
Debug Log: https://pastebin.com/QUPvPsDU
Bash Output: https://pastebin.com/aHptaqfD

Hi @DubStepMad
For CoreUI Pro v3 there is no need to change src/scss/styles.scss.
You can switch to the dark theme by adding c-dark-theme class to the c-app element.

@xidedix Thank you very. Spent 4 hours trying to figure this out.
Can I recommend that the README file or some sort of documentation be updated regarding this as its not stated anywhere.

I am surprised this is not noted anywhere, as other people have had the same issue..

1

I am surprised this is not noted anywhere, as other people have had the same issue..

+1


Support for MySQL v8

I've been developing against MySQL 5.7 and hadn't noticed the release of MySQL v8 earlier this year. @DGraveling noticed problems getting the app to connect to MySQL v8 as-is. It might be a config issue, or there might be some incompatibility issues - it would be worth some investigation.

Still no update on this. The DB provider I'm using (Compose) only offers MySQL v5 anyway, so there hasn't been much incentive to look into MySQL v8.

It looks like this may have been resolved by https://github.com/sidorares/node-mysql2/issues/991 - I'll do some testing before closing this issue.


Add high frequency support to the check constructs

We haven't added high frequency configuration option to the checks. We need to set the frequency offset to achieve this. We can actually use enums for this maybe? It would be neater for the users

@umutuzgur please push and send me the branch for this


timeout to Confluent Cloud - DescribeConsumerList - A failure occurred while retrieving offsets

Describe the bug
The DescribeConsumerList is always timing out , unable to get metrics , although the connection is successful
the logs
DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Timed out 33 call(s) with assigned nodes.
DEBUG o.a.k.c.c.i.AbstractCoordinator  - [Consumer clientId=consumer-client-id, groupId=kafkalagexporter] Resetting generation due to consumer pro-actively leaving the group
2020-09-24 19:58:04,716 DEBUG o.a.k.clients.consumer.KafkaConsumer  - [Consumer clientId=consumer-client-id, groupId=kafkalagexporter] Kafka consumer has been closed
2020-09-24 19:58:04,716 INFO  c.l.k.ConsumerGroupCollector$ akka://kafka-lag-exporter/user/consumer-group-collector-xxxx-xxxx - Clearing all metrics before shutdown
2020-09-24 19:58:04,747 ERROR c.l.k.ConsumerGroupCollector$ akka://kafka-lag-exporter/user/consumer-group-collector-xxxx-xxxx - Supervisor RestartSupervisor saw failure: A failure occurred while retrieving offsets.  Shutting down. java.lang.Exception: A failure occurred while retrieving offsets.  Shutting down.
Environment

Confluent Cloud
version 2.5
Docker

Additional context
no matter how much I increase the timeout , it is still timing out

Can you include the stack trace of the exception and version of Kafka Lag Exporter?  Did you configure admin-client-properties and consumer-properties with the same connection info?

Kafka Lag exporter version v0.6.4 , and I am using the same connection info , the thing is if I only select one or two for group-whitelist , the script is working .
2020-09-24 21:16:59,615 INFO  o.a.k.c.a.i.AdminMetadataManager  - [AdminClient clientId=admin-client-id] Metadata update failed org.apache.kafka.common.errors.TimeoutException: Call(callName=fetchMetadata, deadlineMs=1600982229397) timed out at<PHONE_NUMBER>854775807 after 1 attempt(s)
Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting to send the call.
2020-09-24 21:16:59,615 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Timed out 1 call(s) with assigned nodes.
2020-09-24 21:16:59,615 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Timed out 1 remaining operation(s).
2020-09-24 21:16:59,625 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Exiting AdminClientRunnable thread.
2020-09-24 21:16:59,626 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Kafka admin client closed.
2020-09-24 21:16:59,627 DEBUG o.a.k.c.c.i.ConsumerCoordinator  - [Consumer clientId=consumer-client-id, groupId=kafkalagexporter] Executing onLeavePrepare with generation Generation{generationId=-1, memberId='', protocol='null'} and memberId
2020-09-24 21:16:59,627 DEBUG o.a.k.c.c.i.AbstractCoordinator  - [Consumer clientId=consumer-client-id, groupId=kafkalagexporter] Resetting generation due to consumer pro-actively leaving the group
2020-09-24 21:16:59,631 DEBUG o.a.k.clients.consumer.KafkaConsumer  - [Consumer clientId=consumer-client-id, groupId=kafkalagexporter] Kafka consumer has been closed
2020-09-24 21:16:59,631 INFO  c.l.k.ConsumerGroupCollector$ akka://kafka-lag-exporter/user/consumer-group-collector-lkc-9kgm0 - Clearing all metrics before shutdown
2020-09-24 21:16:59,667 ERROR c.l.k.ConsumerGroupCollector$ akka://kafka-lag-exporter/user/consumer-group-collector-lkc-9kgm0 - Supervisor RestartSupervisor saw failure: A failure occurred while retrieving offsets.  Shutting down. java.lang.Exception: A failure occurred while retrieving offsets.  Shutting down.
at com.lightbend.kafkalagexporter.ConsumerGroupCollector$CollectorBehavior.$anonfun$collector$1(ConsumerGroupCollector.scala:214)
at akka.actor.typed.internal.BehaviorImpl$ReceiveBehavior.receive(BehaviorImpl.scala:136)
at akka.actor.typed.Behavior$.interpret(Behavior.scala:274)
at akka.actor.typed.Behavior$.interpretMessage(Behavior.scala:230)
at akka.actor.typed.internal.InterceptorImpl$$anon$2.apply(InterceptorImpl.scala:57)
at akka.actor.typed.internal.RestartSupervisor.aroundReceive(Supervision.scala:263)
at akka.actor.typed.internal.InterceptorImpl.receive(InterceptorImpl.scala:85)
at akka.actor.typed.Behavior$.interpret(Behavior.scala:274)
at akka.actor.typed.Behavior$.interpretMessage(Behavior.scala:230)
at akka.actor.typed.internal.adapter.ActorAdapter.handleMessage(ActorAdapter.scala:129)
at akka.actor.typed.internal.adapter.ActorAdapter.aroundReceive(ActorAdapter.scala:106)
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:577)
at akka.actor.ActorCell.invoke(ActorCell.scala:547)
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:270)
at akka.dispatch.Mailbox.run(Mailbox.scala:231)
at akka.dispatch.Mailbox.exec(Mailbox.scala:243)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
020-09-24 21:17:31,458 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Timed out 33 call(s) with assigned nodes.
2020-09-24 21:17:31,459 DEBUG o.apache.kafka.clients.NetworkClient  - [AdminClient clientId=admin-client-id] Disconnecting from node 1 due to request timeout.
2020-09-24 21:17:31,459 DEBUG o.a.k.c.a.i.AdminMetadataManager  - [AdminClient clientId=admin-client-id] Requesting metadata update.
2020-09-24 21:17:31,459 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] The AdminClient is not accepting new calls. Timing out Call(callName=describeConsumerGroups, deadlineMs=1600982251478).
2020-09-24 21:17:31,459 DEBUG o.a.k.clients.admin.KafkaAdminClient  - [AdminClient clientId=admin-client-id] Call(callName=describeConsumerGroups, deadlineMs=1600982251478) timed out at<PHONE_NUMBER>854775807 after 1 attempt(s) java.lang.Exception: TimeoutException: The AdminClient thread is not accepting new calls.
at org.apache.kafka.clients.admin.KafkaAdminClient$Call.failWithTimeout(KafkaAdminClient.java:755)
at org.apache.kafka.clients.admin.KafkaAdminClient$Call.fail(KafkaAdminClient.java:728)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.call(KafkaAdminClient.java:1324)
at org.apache.kafka.clients.admin.KafkaAdminClient$22.handleResponse(KafkaAdminClient.java:2768)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.handleResponses(KafkaAdminClient.java:1127)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.processRequests(KafkaAdminClient.java:1280)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1203)
at java.lang.Thread.run(Thread.java:748)

I'm not sure exactly what you're asking, but if you enable DEBUG logging you can see the raw information Kafka Lag Exporter uses before it does any calculations.
https://github.com/lightbend/kafka-lag-exporter#troubleshooting
However, in this case the exception is being thrown before offsets can be retrieved, so they won't be logged.

It might be worthwhile to log information as it's retrieved, instead of only once it's all been collected.

Can you include the stack trace of the exception and version of Kafka Lag Exporter? Did you configure admin-client-properties and consumer-properties with the same connection info?

I´ve confluent cloud configured here, and I configured admin-client-properties like consumer-properties, but I receive this warn:
2021-04-15 13:57:36,383 WARN  o.a.k.c.admin.AdminClientConfig akka://kafka-lag-exporter/user/consumer-group-collector-production - The configuration 'sasl.jaas.config' was supplied but isn't a known config.
2021-04-15 13:57:36,384 WARN  o.a.k.c.admin.AdminClientConfig akka://kafka-lag-exporter/user/consumer-group-collector-production - The configuration 'ssl.endpoint.identification.algorithm' was supplied but isn't a known config.
But it´s look like evertything works fine, but this warn happens every time.
Thank you

I have it working with Confluent Cloud, for me the main reason behind the timeouts was the large number of consumer-groups (50K due to some other circumstances).
After applying a blacklist for the "wrong" consumer groups it is running fine now.
It was also highly irritating that the timeout is not configured at the client level but at the top level of the configuration
kafka-lag-exporter {
reporters.prometheus.port = 8000
kafka-client-timeout = 30000
While other options configured on client level are used the timeout is completely ignored there.
Regarding the warning mentioned by @klinux, they are a regular source of irritation with Kafka when some version doesn't recognize some parameters. See https://issues.apache.org/jira/browse/KAFKA-7509 if you are interested, but they are no reason for concern.

I have it working with Confluent Cloud, for me the main reason behind the timeouts was the large number of consumer-groups (50K due to some other circumstances).
After applying a blacklist for the "wrong" consumer groups it is running fine now.
It was also highly irritating that the timeout is not configured at the client level but at the top level of the configuration
kafka-lag-exporter {
reporters.prometheus.port = 8000
kafka-client-timeout = 30000
While other options configured on client level are used the timeout is completely ignored there.

Can you elaborate on what you mean? The kafka-client-timeout configuration is used for request.timeout.ms Kafka consumer and admin client config. If you increase this timeout were you not able to eventually retrieve all your groups.
Depending on your partition config, 50K groups is going to generate a lot of metrics. It would also create a huge amount of points in the interpolation table for each partition. There's an in progress PR #333 to support redis for the interpolation tables that would help alleviate JVM memory usage.

@seglo By irritating I meant that the timeout configuration is a separate configuration value and not simply on the client level.
The 50K were mostly due to another error, so I did not try out how high the timeout would have to be for it to work.
With the whitelisting everything was fine.
Thanks for the information, good to know for the future :-)

@pkleindl Got it. I can see how that would be confusing if you're expecting to define all the client properties yourself. I can look into making the kafka-client-timeout app config optional so it won't overwrite client config if it's provided and kafka-client-timeout is not.
I am curious about the large number of consumer groups though. Is this a consequence of using confluent cloud and possibly having shared infra? I don't know much about the offering. Or was it an internal concern to your org?

Redis support as been released. For anyone experience JVM memory constraints you might want to give that a try.


Added information on Slack help channel to README.

Changed README.md to direct support questions to the appropriate Slack channel.

I think we've got this problem resolved now - don't really want to tie the readme to a specific channel because #dev questions are also legitimate.


Integrate pretty on the project.

This PR integrates and runs prettier. Same rules of others webpack-contrib projects were applied.
/CC @evilebottnawi @glenjamin

👌


Don't continue on 403 errors

Extractor only creates error event but continues the execution of other queries, job is that finished as success. So the user have no clue that there are some data missing!
For the BC maybe we can introduce some strict flag which will throw error on 403 errors. And it should be enabled by default for new configurations?

Strict flag does make sense to me.


add pyarrow as required dependency for dagster duckdb

Add pyarrow as required dependency as needed for pd.read_parquet.
Before adding this dependency, when one attempts to materialize all assets, they are presented with the following error:
ImportError: Unable to find a usable engine; tried using: 'pyarrow', 'fastparquet'.
A suitable version of pyarrow or fastparquet is required for parquet support.
Trying to import the above resulted in these errors:
 - Missing optional dependency 'pyarrow'. pyarrow is required for parquet support. Use pip or conda to install pyarrow.
 - Missing optional dependency 'fastparquet'. fastparquet is required for parquet support. Use pip or conda to install fastparquet.

This commit introduces the opinionated change of using pyarrow over the alternative of fastparquet.

What's the lib that needs pyarrow? Does it provide a suite of optional deps that we can install instead of just pyarrow?
ex. pip install sqlalchemy[pyarrow]?

What's the lib that needs pyarrow? Does it provide a suite of optional deps that we can install instead of just pyarrow?
ex. pip install sqlalchemy[pyarrow]?

That's a good question - it's coming from Pandas pd.read_parquet. Their documentation states that they default to using the pyarrow engine.  However, it doesn't look like they include it as an extra dependency.
 > pip install pandas[pyarrow]
Requirement already satisfied: pandas[pyarrow] in ./.direnv/python-3.11/lib/python3.11/site-packages (2.2.0)
WARNING: pandas 2.2.0 does not provide the extra 'pyarrow'
...

@cmpadden allegedly the extra for it is two extras. https://pandas.pydata.org/docs/getting_started/install.html#other-data-sources
Wanna give it a shot and lmk if it's worth the effort? Otherwise I'll stamp approve!

@cmpadden allegedly the extra for it is two extras. https://pandas.pydata.org/docs/getting_started/install.html#other-data-sources
Wanna give it a shot and lmk if it's worth the effort? Otherwise I'll stamp approve!

Good find! I confirmed that pandas[parquet] did the trick as added in https://github.com/dagster-io/project-dagster-university/pull/7/commits/71d42f8c02720ea1b2d20ea8b30baa85895c4ffe.


PathPlanner crashing on MacOS when attempting to change path in an auto

Describe the bug
Using the PathPlanner GUI, the program crashes when clicking the dropdown (to change path) on a pre-existing follow path command, in an autonomous routine.
To Reproduce
Steps to reproduce the behavior:

Go to an auto created in the PathPlanner GUI
Add a Follow Path command, and select a path (or use a pre-existing one)
Click on the dropdown or on the text/path name, attempting to change the path
Program crashes at this point

Expected behavior
Dropdown appears with paths.
Screenshots
Screen recording using the release downloaded from GitHub:
https://github.com/mjansen4857/pathplanner/assets/75756042/02ee388f-4310-4e71-a0b6-115233dae5fa
Screen recording running from source in Flutter debug mode (with possibly relevant error message):
https://github.com/mjansen4857/pathplanner/assets/75756042/6ea0b6d1-8922-42c3-bc11-3ed8bb921efa
Versions: (please complete the following information):

OS: MacOS 14.3.1
GUI Version: 2024.1.5
PPLib Version: 2024.2.7
PPLib Language: Java

I have not tested this on Windows, or another Mac computer, but it is happening across projects.

This appears to be a bug in the latest stable flutter version, caused by the paths list being long enough to be scrollable. I'll either replace the latest PP build with one made from a downgraded flutter version or the beta channel, depending on which one works.


AsyncPool, AsyncConnectionPoolSupport are nowhere to be found

Official documentation says there are no dependency required to implement async connection pooling with lettuce.
RedisClusterClient clusterClient = RedisClusterClient.create(RedisURI.create(host, port));

AsyncPool<StatefulRedisConnection<String, String>> pool = AsyncConnectionPoolSupport.createBoundedObjectPool(
        () -> clusterClient.connectAsync(StringCodec.UTF8), BoundedPoolConfig.create());

// execute work
CompletableFuture<String> setResult = pool.acquire().thenCompose(connection -> {

    RedisAsyncCommands<String, String> async = connection.async();

    async.set("key", "value");
    return async.async.set("key2", "value2").whenComplete((s, throwable) -> pool.release(c));
});

// terminating
pool.closeAsync();

// after pool completion
client.shutdownAsync();

I copied that code with lettuce 4 and 5 but AsyncPool, AsyncConnectionPoolSupport, BoundedPoolConfig are nowhere to be found. The closest thing I found was io.lettuce.core.support.ConnectionPoolSupport but its methods are very different from the docs.
Only synchronous connection pooling has a dependency on commons-pool2 according to the docs.
Which is it?

I noticed that right after posting this issue yesterday so I checked the release docs too but they are identical: https://lettuce.io/core/release/reference/#connection-pooling.asynchronous.usage ...

I adjusted the documentation. All Lettuce 5 builds include content from the Wiki which isn't specific to a version. The docs however mention:

Asynchronous/Non-Blocking via a Lettuce-specific pool implementation (since version 5.1)


Since Upgrade to version 2.9.0 "Failure Unable to retrieve DockerHub details"

Hey,
after upgrading Portianer from 2.6.3 to 2.9.0, I see the message "Failure.
Unable to retrieve DockerHub details" no matter which page I click on.
Does anyone have any idea how to fix this ?

Portainer-CE + Docker Swarm node,
the same message appears every time on "Image" and "Registers" tabs
from the Image tab the information about possible pulls from the Docker Hub disappears and on the Register tab the possibility to enter credentials for the Docker Hub also disappears.

DockerHub credentials and registries can only be used with Docker endpoints at the time.

@tujh-rf
With 2.9, Registry Management is moved to here

@mw7101
Can you provide a bit more info about your setup?
Docker Standalone or Swarm? OS, Docker Version etc
Can you please post a screenshot of Registries Screen from Host/Swarm --> Registries? Do you have a DockerHub account added before the upgrade?

Hey,
after upgrading Portianer from 2.6.3 to 2.9.0, I see the message "Failure.
Unable to retrieve DockerHub details" no matter which page I click on.
Does anyone have any idea how to fix this ?

Check if the port 9443 is open in your firewall.

@mw7101
Can you remove browser cache and refresh portainer page, usually Ctrl+F5
Let us know if that fixed the issue.

@samdulam Hi, looks like the issue was in the browser cache indeed. I have open Portainer from the other laptop and there are no error messages. Sorry for the false report :)

Thanks for reporting back. We are currently investigating options to work around the browser cache issues.

Hey, clearing the browser cache habe fix this issue. Thanks all!


mouse position

hi, i would like to use this lib to draw some text selection rectangles ( they can be normal divs ) on top of the image.
i know how i can disable everything, but i fin'd difficult on getting mouse position inside TransformWrapper

It should be possible now as the lib progressed with more options, handlers etc


Peep hole opt for $logic_not with constant 0 in input A.

Initial commit for comments.

Can you please rebase this to be one clean commit ontop of my current master?

If I read this code correctly you replace a $logic_not cell cell with a constant zero driver if you find any constant 0 bits in the input port. But that's of course bogus! You'd want to set the output to constant zero if you find any constant 1 bits in the input port.

This is a PR from your master branch. You are aware that pull requests track the branch they are from? That's why the usual approach is to create a separate branch for your PR, not use master.

Close this and make new try.