Swiper v9 Grid Loop ...

          Swiper v9 comes with fully reworked and now different loop functionality. If you have similar issues in Swiper 9, open a new issue with a CodeSandbox showing the issue.

Originally posted by @nolimits4web in https://github.com/nolimits4web/swiper/issues/5882#issuecomment-1411926673
Hello,
First of all, thank you so much for everything.
I leave an example link for this issue,
When the loop is activated, it does not work as it should.
codesandbox
Kind regards

The same thing happened to me, loop: true didn't work. I fixed it by installing an older version 8.4.5 and the loop is working for me now.

Loop stopped working for me as well in new 9.0.3 version.
Not even using grid view. For linear slider there is issue when slidesPerView is greater than half of total slides:
https://codepen.io/ondrejruzicka/pen/YzjMaJy (works when you set slidesPerView to 4).
I moved to new version because reworked loop functionality works well with scrollbar. Which is great!

Same here, after updating to Swiper 9.0.3 loop is broken in some of my projects.
I read the docs and found some info here -> https://swiperjs.com/migration-guide-v9
Which contains the following information:
"Loop mode has been fully reworked in version 9 and now instead of duplicating slides, it rearrange current ones dynamically. It comes with new limitation. Amount of slides in loop mode should be at least 2x of slidesPerView value."
So this is where some of my sliders break if they don't have double the slides of the slidesPerView value...
This new v9 version fixed some hydration errors in Nuxt3 but then breaks another thing and adds this limitation.
I do not understand why you would add a limitation like this and not give developers another option?
Hoping for a fix, currently going back to 8.4.7
Kind regards

Both activeIndex and realIndex are incorrect in loop mode

Yup, I can confirm this bug.
Thanks for a great project!

Same here, after updating to Swiper 9.0.3 loop is broken in some of my projects. I read the docs and found some info here -> https://swiperjs.com/migration-guide-v9
Which contains the following information: "Loop mode has been fully reworked in version 9 and now instead of duplicating slides, it rearrange current ones dynamically. It comes with new limitation. Amount of slides in loop mode should be at least 2x of slidesPerView value."
So this is where some of my sliders break if they don't have double the slides of the slidesPerView value...
This new v9 version fixed some hydration errors in Nuxt3 but then breaks another thing and adds this limitation.
I do not understand why you would add a limitation like this and not give developers another option?
Hoping for a fix, currently going back to 8.4.7
Kind regards

Yep. I do not get the limitation. The use case where you do not have double the amount of the slidesPerView value is encountered very often (for example in in image galleries, product sliders etc.) This makes swiper v9 basically useless in a lot of use cases. I opened an issue, but it was closed with the comment "that is the limitation now".

Same error here, that loop error forced me to downgrade to V8

Agreed with comments above. This seems to break the whole idea of a looped carousel, meaning downgrading to v8 is the only option. Now if there is a separate issue that has been resolved in version 9, what do we do?
I strongly suggest reverting this change in v9 - looped sliders with less than double the number of slides is an extremely common use case.

+1

I downgraded to V8 due to the loop error, experiencing the same issue here.

Is there any estimation on when this is going to be fixed? Still need to use v8 because of this.

This isn't a small limitation. This is a deal breaking limitation making the slider useless for MANY use cases. It should have atleast been provided as an option.

Swiper on v10 before fixing their regressions. ta ta

Okay, after hours of trying everything possible out, I also reverted to v8 - at least I'm not alone :heart:

I honestly don't know how you guys allowed yourselves to continue without fixing this issue... It feels pretty irresponsible for a core feature to be broken this long.

Yup, tried the Swiper V10 version on a new project and still had to revert back to 8.4.7. Unfortunate

It's not a bug. It's a feature, apparently...

Because of nature of how the loop mode works (it will rearrange slides), total number of slides must be >= slidesPerView * 2.

Ref: https://swiperjs.com/swiper-api#param-loop

The fact the developer did it deliberately - and has been closing countless
threads by users all now experiencing the same problem - doesn't meant it
doesn't need fixing. It just means they're out of touch with why clients
want carousels. I guess they don't build websites themselves.
On Sat, 16 Sep 2023, 1:48 am Nanna, @.***> wrote:

It's not a bug. It's a feature, apparently...
Because of nature of how the loop mode works (it will rearrange slides),
total number of slides must be >= slidesPerView * 2.
Ref: https://swiperjs.com/swiper-api#param-loop
—
Reply to this email directly, view it on GitHub
https://github.com/nolimits4web/swiper/issues/6351#issuecomment-1721314426,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS3V7B53JRCLOL3YRG4EW3X2RMDPANCNFSM6AAAAAAUSZYUVE
.
You are receiving this because you commented.Message ID:
@.***>

It's not a bug. It's a feature, apparently...

Because of nature of how the loop mode works (it will rearrange slides), total number of slides must be >= slidesPerView * 2.

Ref: https://swiperjs.com/swiper-api#param-loop

Yeah, it's broken, following that note you mentioned it still doesn't work.

Swiper v11 comes with reworked and update loop mode. If your issue is replicated with v11, create a new one


GrovePi.Analog.write/2 results in error

I am trying to implement this project:  https://github.com/DexterInd/GrovePi/blob/master/Projects/LED_Fade/led_fade.py
# Connect the LED to digital port D5
led = 5
grovepi.pinMode(led,"OUTPUT")

# Where i is the output of the potentiometer.
grovepi.analogWrite(led,i//4)

I'm just trying to get the led to work by itself.  I have an led board connected to port D5.
Looking at the GrovePi.Analog docs, I should just be able to call:
GrovePi.Analog.write(5, 200)

However, I get this error:
fe423e:        00:04:53.474 [error] GenServer Default.Elixir.GrovePi.Board terminating
** (MatchError) no match of right hand side value: :error
    (elixir_ale) lib/elixir_ale/i2c.ex:171: ElixirALE.I2C.handle_call/3
    (stdlib) gen_server.erl:615: :gen_server.try_handle_call/4
    (stdlib) gen_server.erl:647: :gen_server.handle_msg/5
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message: {:write, <<4, 5, 200, 0>>}
State: %ElixirALE.I2C.State{address: 4, devname: "i2c-1", port: #Port<0.971>}
fe423e:        00:04:54.052 [error] GenServer {Default.Elixir.GrovePi.Registry.Pin, 14} terminating
** (stop) exited in: GenServer.call(Default.Elixir.GrovePi.Board, {:write, <<1, 14, 0, 0>>}, 5000)
    ** (EXIT) an exception was raised:
        ** (MatchError) no match of right hand side value: :error
            (elixir_ale) lib/elixir_ale/i2c.ex:171: ElixirALE.I2C.handle_call/3
            (stdlib) gen_server.erl:615: :gen_server.try_handle_call/4
            (stdlib) gen_server.erl:647: :gen_server.handle_msg/5
            (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
    (elixir) lib/gen_server.ex:737: GenServer.call/3
    (grovepi) lib/grovepi/board.ex:80: GrovePi.Board.send_request_with_retry/3
    (grovepi) lib/grovepi/digital.ex:34: GrovePi.Digital.read/2
    (grovepi) lib/grovepi/poller.ex:135: GrovePi.Button.update_value/1
    (grovepi) lib/grovepi/poller.ex:128: GrovePi.Button.handle_info/2
    (stdlib) gen_server.erl:601: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:667: :gen_server.handle_msg/5
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message: :poll_button
State: %GrovePi.Button.State{pin: 14, poll_interval: 100, poll_reference: #Reference<<IP_ADDRESS>2>, prefix: Default, trigger: GrovePi.Button.DefaultTrigger, trigger_state: %GrovePi.Button.DefaultTrigger.State{value: 0}}

Do I need to do something else before the GrovePi.Analog.write/2 function call?  Do I need to set the pin mode?  Or am I doing something else wrong?

Could you share your program or reproduce the issue in iex and share the steps again? The text above doesn't look quite right. For example, pinMode and :poll_button make me think that something might have been lost in the copy/paste. (or maybe not, but please confirm)
Also, Port D5 is an I2C port, so could you attach the LED to Port D3? Port D3 is a PWM-capable digital port. Oddly enough, it looks like the only easy PWM output to use. I'm not sure how port D5 could be made to work, but I haven't looked at the schematic. The GrovePi+ docs look misleading on that one.

I'm no longer have the error, although I'm not sure what was causing it.  Today I started with a new project and I actually could get it working on both Port D3 and Port D5.
I went back to my project and got the same error as above.  I commented out all of my button and led code and then did not have the error.  Then when I uncommented the code, I also no longer had the error.  It also works on both Port D3 and D5.  So I'm not sure what the issue was but everything is working now.
Here is my code:
lib/demo/application.ex
defmodule Demo.Application do
  use Application

  @interface :wlan0

  # See http://elixir-lang.org/docs/stable/elixir/Application.html
  # for more information on OTP Applications
  def start(_type, _args) do
    import Supervisor.Spec, warn: false

    # Define workers and child supervisors to be supervised
    children = [
      # worker(Demo.Worker, [arg1, arg2, arg3]),
      worker(Task, [fn -> init_kernel_modules() end],
        restart: :transient, id: Nerves.Init.KernelModules),
      worker(Task, [fn -> init_wifi_network() end],
        restart: :transient, id: Nerves.Init.WifiNetwork),
      worker(NetworkManager, [@interface],
        restart: :transient, id: Nerves.Init.NetworkManager),
      supervisor(HelloGrove.Supervisor, []),
    ]

    # See http://elixir-lang.org/docs/stable/elixir/Supervisor.html
    # for other strategies and supported options
    opts = [strategy: :one_for_one, name: Demo.Supervisor]
    Supervisor.start_link(children, opts)
  end

  def init_kernel_modules, do: System.cmd "modprobe", ["brcmfmac"]

  def init_wifi_network() do
    Nerves.InterimWiFi.setup @interface, Application.get_env(:demo, @interface)
  end
end

lib/hello_grove/supervisor.ex
defmodule HelloGrove.Supervisor do
  use Supervisor

  # Pick ports that work on both the GrovePi+ and GrovePi Zero
  @button_pin 14 # Port A0
  # @buzzer_pin 3 # Port D3
  @led_pin 3

  def start_link() do
    IO.puts "Starting HelloGrove.Supervisor"

    Supervisor.start_link(__MODULE__, nil)
  end

  def init(_) do
      # Define workers and child supervisors to be supervised
    children = [
      # Start the GrovePi sensors that we want
      worker(GrovePi.Button, [@button_pin]),
      # worker(GrovePi.Buzzer, [@buzzer_pin]),

      # Start the main app
      worker(HelloGrove, [[@button_pin, @led_pin]]),
    ]

    # See http://elixir-lang.org/docs/stable/elixir/Supervisor.html
    # for other strategies and supported options
    opts = [strategy: :one_for_one, name: HelloGrove.Supervisor]
    supervise(children, opts)
  end
end

lib/hello_grove.ex
defmodule HelloGrove do
  @moduledoc false
  use GenServer

  defstruct [:button, :led]

  def start_link(pins) do
    GenServer.start_link(__MODULE__, pins)
  end

  def init([button, led]) do
    state = %HelloGrove{button: button, led: led}

    GrovePi.Button.subscribe(state.button, :pressed)
    {:ok, state}
  end

  def handle_info({_, :pressed, _}, state) do
    IO.puts("Alert!!!!")

    # Sound the alarm, but only for a second
    # GrovePi.Buzzer.buzz(state.buzzer, 1000)
    GrovePi.Analog.write(state.led, 125)

    {:noreply, state}
  end
end

I still seem to occasionally get this error.  I think my first post was missing some in the copy/paste as you suggested.
With the code the same as above.  I have a potentiometer in Port A2.  In iex I called:
iex(demo@<IP_ADDRESS>)6> GrovePi.Analog.read(16)

The first time I got the error below (copied from cell watch).
fe423e:        00:22:35.498 [error] GenServer Default.Elixir.GrovePi.Board terminating
** (MatchError) no match of right hand side value: :error
    (elixir_ale) lib/elixir_ale/i2c.ex:167: ElixirALE.I2C.handle_call/3
    (stdlib) gen_server.erl:615: :gen_server.try_handle_call/4
    (stdlib) gen_server.erl:647: :gen_server.handle_msg/5
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message: {:read, 1}
State: %ElixirALE.I2C.State{address: 4, devname: "i2c-1", port: #Port<0.971>}
fe423e:        00:22:36.026 [error] GenServer {Default.Elixir.GrovePi.Registry.Pin, 14} terminating
** (stop) exited in: GenServer.call(Default.Elixir.GrovePi.Board, {:read, 1}, 5000)
    ** (EXIT) an exception was raised:
        ** (MatchError) no match of right hand side value: :error
            (elixir_ale) lib/elixir_ale/i2c.ex:167: ElixirALE.I2C.handle_call/3
            (stdlib) gen_server.erl:615: :gen_server.try_handle_call/4
            (stdlib) gen_server.erl:647: :gen_server.handle_msg/5
            (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
    (elixir) lib/gen_server.ex:737: GenServer.call/3
    (grovepi) lib/grovepi/board.ex:88: GrovePi.Board.get_response_with_retry/3
    (grovepi) lib/grovepi/digital.ex:35: GrovePi.Digital.read/2
    (grovepi) lib/grovepi/poller.ex:135: GrovePi.Button.update_value/1
    (grovepi) lib/grovepi/poller.ex:128: GrovePi.Button.handle_info/2
    (stdlib) gen_server.erl:601: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:667: :gen_server.handle_msg/5
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message: :poll_button
State: %GrovePi.Button.State{pin: 14, poll_interval: 100, poll_reference: #Reference<<IP_ADDRESS>3>, prefix: Default, trigger: GrovePi.Button.DefaultTrigger, trigger_state: %GrovePi.Button.DefaultTrigger.State{value: 0}}

The second time I got
iex(demo@<IP_ADDRESS>)6> GrovePi.Analog.read(16)
508

Ok, I just realized what may have been happening with the original error.  I had a bad LED light which was why the LED wasn't working.  At the same time, I was getting the error when I was trying to write to the pin for the LED.  I don't think the error was causing the light not to work, but I do think writing to the LED pin was causing the error.  Although now I can't reproduce it with the LED in Port D5 or D3 (only with the potentiometer in Port A2), so again I'm not sure.


Gltf importing fails

Summary
Since the addition of the hologram shader functionality the desktop project fails to import gltf assets and subsequently fails in execution during the loading of the avatar.
The importing error can be seen in the CI but doesn't happen locally when we run the desktop-project.
CI Stacktrace
In the CI the importing error is related to the shader used by the model, here's the full stacktrace
Asset import failed, "Packages/com.decentraland.unity-renderer/Rendering/LoadingAvatar/CrossSection/Avatar_Male_SingleMesh.glb" > ShaderNotFoundException: DCL/Universal Render Pipeline/Lit not found. Did you forget to add it to the build?
UnityGLTF.StandardMap..ctor (System.String shaderName, System.Int32 MaxLOD) (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/UniformMaps/StandardMap.cs:67)
UnityGLTF.MetalRough2StandardMap..ctor (System.String shaderName, System.Int32 MaxLOD) (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/UniformMaps/MetalRough2StandardMap.cs:8)
UnityGLTF.MetalRoughMap..ctor (System.Int32 MaxLOD) (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/UniformMaps/MetalRoughMap.cs:7)
UnityGLTF.GLTFSceneImporter+<ConstructMaterial>d__136.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:2068)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<DownloadAndConstructMaterial>d__130.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:1755)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<ConstructPrimitiveMaterials>d__128.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:1656)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<ConstructMesh>d__129.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:1716)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<ConstructScene>d__115.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:1317)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<CreateScene>d__99.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:613)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <695d1cc93cca45069c528c15c9fdd749>:0)
Cysharp.Threading.Tasks.UniTask+ExceptionResultSource.GetResult (System.Int16 token) (at Library/PackageCache/com.cysharp.unitask@9e2163616b/Runtime/UniTask.Factory.cs:211)
UnityGLTF.GLTFSceneImporter+<LoadScene>d__86.MoveNext () (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/GLTFSceneImporter.cs:366)
Rethrow as AggregateException: One or more errors occurred.
System.Threading.Tasks.Task.ThrowIfExceptional (System.Boolean includeTaskCanceledExceptions) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout, System.Threading.CancellationToken cancellationToken) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Threading.Tasks.Task.Wait (System.TimeSpan timeout) (at <695d1cc93cca45069c528c15c9fdd749>:0)
UnityGLTF.GLTFImporter.CreateGLTFScene (System.String projectFilePath) (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/Editor/GLTFImporter.cs:136)
UnityGLTF.GLTFImporter.OnImportAsset (UnityEditor.AssetImporters.AssetImportContext ctx) (at /tmp/workspace/explorer-desktop/unity-renderer/unity-renderer/Assets/UnityGLTF/Scripts/Editor/GLTFImporter.cs:109)
UnityEditor.AssetImporters.ScriptedImporter.GenerateAssetData (UnityEditor.AssetImporters.AssetImportContext ctx) (at /home/bokken/buildslave/unity/build/Modules/AssetPipelineEditor/Public/ScriptedImporter.cs:22)

Tried fixes/workarounds
Different things have been tried to pinpoint the issue,

Thinking the issue was caused by the import from the unity package I've tried adding the avatar gltf model directly in the desktop project but it fails even in this case
I've tried re exporting the model both in glb and gltf with different options, with and without materials, without and without the import materials check in unity but it still fails
I've tried changing the shader of the material auto generated by unity when importing the model but the error still points to the Lit shader
I've verified and the shader is correctly included in the shader variants
I've tried duplicating the shader inside the explorer-desktop project but nothing changes
Something that was suggested might be that the glb is being imported before importing the shader, but from the logs it doesn't seem the case

Additional info

This issue is happening only in the exploer-desktop and not in the unity renderer project, but it happened to a few people that at first launch of the unity renderer project they were forced to use the Reimport all functionality to make the project work
Similar issue that I've seen online: https://github.com/KhronosGroup/UnityGLTF/issues/206

The root cause were the materials, we fixed the Import Materials. Using the materials constructed by a GLTF in editor is a really edge case with no use case at the moment. Closing this.


Add Support for Cause Error Property

See mdn https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#rethrowing_an_error_with_a_cause

What kind of support are you looking to add?
Typescript can handle this by settings lib: ["ESNEXT"] and it has support in all major browsers as well as node.
Is there anything else you were thinking of?

@zmrl010 i think when i wrote this i wanted to treat cause similarly to the way we treat Other Threads for other platforms. I believe we might need backend support to make this work. Do you have an idea of how a JS developer might want to use this additional information? Seems valuable enough to capture, definitely open to suggestions regarding how we upload it and ultimately display it to the user!

I've not personally used it as I only recently discovered it. But the use-cases on the page you linked and others nested on that page. I agree I think it could be useful.
One thing we could do is check for the cause property and recursively read that so you could just have a flat list of errors to send to the backend. If you kept them in order, you could use the order to determine the heirarchy and display them accordingly. I'd have to think more on the ui but I can give you some suggestions.


Wish: support for IAggregatable for NextrasDataSource

Is it possible to add support for IAggregatable also for NextrasDataSource? I am using Nextras ORM with this datagrid and that implementation (which looks like one function only) is missing.
Thanks a lot in advance.

NextrasDataSource.php:
	/**
	 * @param  IAggregationFunction $function
	 * @return void
	 */
     public function processAggregation(IAggregationFunction $function): void
     {
		 $function->processDataSource(clone $this->dataSource);
     }

FunctionSum.php::processDataSource at the end new style:
		if ( $dataSource instanceof DbalCollection) {
			foreach( $dataSource->fetchAll() as $item )
				$this->result += $item->getValue( $this->column );
		}

And is there some way how to setRenderer for aggregation function or it is necessary to inherit SumFunction and add e.g. currency rendering into it?

It looks like you know what you're doing - could you prepare a PR?

Really? That means a lot of using github which I am not so familiar.
I can attach simple patch like in old days (I cannot find a way how to attach it as file or create pull request from it]:
diff -Naur datagrid.orig/src/DataSource/NextrasDataSource.php datagrid/src/DataSource/NextrasDataSource.php
--- datagrid.orig/src/DataSource/NextrasDataSource.php	2021-03-20 17:39:23.052000115 +0100
+++ datagrid/src/DataSource/NextrasDataSource.php	2021-03-20 17:38:24.213991686 +0100
@@ -7,6 +7,8 @@
 use Nette\Utils\Strings;
 use Nextras\Orm\Collection\Expression\LikeExpression;
 use Nextras\Orm\Collection\ICollection;
+use Ublaboo\DataGrid\AggregationFunction\IAggregatable;
+use Ublaboo\DataGrid\AggregationFunction\IAggregationFunction;
 use Ublaboo\DataGrid\Exception\DataGridDateTimeHelperException;
 use Ublaboo\DataGrid\Filter\FilterDate;
 use Ublaboo\DataGrid\Filter\FilterDateRange;
@@ -19,7 +21,7 @@
 use Ublaboo\DataGrid\Utils\Sorting;
 use UnexpectedValueException;

-class NextrasDataSource extends FilterableDataSource implements IDataSource
+class NextrasDataSource extends FilterableDataSource implements IDataSource, IAggregatable
 {

 	/**
@@ -341,4 +343,13 @@

 		return $column;
 	}
+
+	/**
+	 * @param  IAggregationFunction $function
+	 * @return void
+	 */
+     public function processAggregation(IAggregationFunction $function): void
+     {
+		 $function->processDataSource(clone $this->dataSource);
+     }
 }

Prepared #968


[3.4] back port of agency call back cleanup

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/5711/

Unfortunately, the API is published, so we cannot leave out the changed entries, please revert.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5819/


Changeing TV source is not working

We are using KEY_TV and KEY_HDMI1, KEY_HDMI1 to switch the sources. But these KEYS are not working. Where do we get the information about the keys to be used for changing the source or what are the correct key values.
We have tested with UE65NU8000 and UE55LS003, both are having this issue

None of your TVs is listed as working at https://www.home-assistant.io/components/media_player.samsungtv/
This is the bug/issue tracker for Home Assistant. Please use the forum for questions about installation, setup, and configuration.
If it's a bug, please re-open the issue with the issue template filled.


Applying deploy for the second time to add new nodes has a minor failure

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
After adding new nodes and applying
kubespray deploy -p . --network-plugin flannel

one of the hosts failed. However, the cluster can see the new nodes just fine and they seem to work.
TASK [kubernetes-apps/rotate_tokens : Rotate Tokens | Get default token name] ********************************************************************************Friday 06 October 2017  20:58:31 +0200 (0:00:00.427)       0:29:34.328 ********
changed: [kube-master-2]

TASK [kubernetes-apps/rotate_tokens : Rotate Tokens | Get default token data] ********************************************************************************Friday 06 October 2017  20:58:36 +0200 (0:00:04.855)       0:29:39.184 ********

TASK [kubernetes-apps/rotate_tokens : Rotate Tokens | Test if default certificate is expired] ****************************************************************Friday 06 October 2017  20:58:36 +0200 (0:00:00.115)       0:29:39.299 ********

TASK [kubernetes-apps/rotate_tokens : Rotate Tokens | Determine if certificate is expired] *******************************************************************Friday 06 October 2017  20:58:36 +0200 (0:00:00.112)       0:29:39.412 ********
fatal: [kube-master-2]: FAILED! => {"failed": true, "msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'status'\n\nThe error appears to have been in '/kubernetes/testing-cluster-second/config/roles/kubernetes-apps/rotate_tokens/tasks/main.yml': line 23, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Rotate Tokens | Determine if certificate is expired\n  ^ here\n\nexception type: <class 'ansible.errors.AnsibleUndefinedVariable'>\nexception: 'dict object' has no attribute 'status'"}

Environment:

Cloud provider or hardware configuration:
Azure
OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 4.4.0-43-Microsoft x86_64
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Version of Ansible (ansible --version):

Kubespray version (commit) (git rev-parse --short HEAD):
9c86da1
Network plugin used:
Copy of your inventory file:
Command used to invoke ansible:
Output of ansible run:

Anything else do we need to know:

Did you miss kube-master-1 in group kube-node of file inventory/inventory.cfg ?

@tadas-subonis The bug you are encountering was fixed by https://github.com/kubernetes-incubator/kubespray/pull/1727
Please deploy from master.


get code coverage up to 80%

time to pay down that techdebt

This is for test coverage right @rsvihladremio ?


Deprecate azure support?

I don't have the bandwidth to support kubernetes-anywhere alongside ACS-Engine.
But I'm not sure what to do about it necessarily...
Thoughts, @mikedanese ? I have no problem with removing it...

I would like to see how we can bring the Tectonic Installer and Kubernetes Anywhere together. We are currently maintaining an Azure based Terraform installation method here: https://github.com/coreos/tectonic-installer/blob/master/Documentation/install/azure/azure-terraform.md

ping @colemickens
Do you know if anyone uses the Azure thing anymore or if we can remove it by now?
cc @pipejakob

+1 for removal. Already its broken. its just an overhead for refactoring the whole project to support kubeadm based deployment and also to deprecate ignition phase2 provider.

I'm not aware of anyone using this. The only users I was aware of have transitioned to other bring-up methods.
+1 on removing it, +10 if it's broken
cc: @brendandburns / @ahowe as an FYI, though I don't anyone at Azure is going to care given their focus on ACS-Engine
(Side note, I've worked heavily with 4 bring-up methods and made a couple small feature additions to tectonic-installer, my fifth. In my opinion, it is the cleanest, easiest to work with, and most comprehensive option I've seen yet (at least, for Azure). I'm assuming the plan is to keep kubernetes-anywhere as being minimal TF + "just invoke kubeadm", but I think it would still be interesting to think about if tectonic-installer could ever converge with kubernetes-anywhere in the future.)

Fine with me to delete.

From: Cole Mickens<EMAIL_ADDRESS>Sent: Tuesday, September 5, 2017 3:06 PM
To: kubernetes/kubernetes-anywhere
Cc: Brendan Burns; Mention
Subject: Re: [kubernetes/kubernetes-anywhere] Deprecate azure support? (#366)
I'm not aware of anyone using this. The only users I was aware of have transitioned to other bring-up methods.
+1 on removing it, +10 if it's broken
cc: @brendandburnshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrendandburns&data=02|01|bburns%40microsoft.com|b98a1a9357a14384b8ae08d4f4aa623f|72f988bf86f141af91ab2d7cd011db47|1|0|636402460004486948&sdata=itUUMBVmEoTod%2BNTbyRE%2BcVAz6Z2PqSGXF6EszjX6z8%3D&reserved=0 / @ahowehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fahowe&data=02|01|bburns%40microsoft.com|b98a1a9357a14384b8ae08d4f4aa623f|72f988bf86f141af91ab2d7cd011db47|1|0|636402460004486948&sdata=xClyNZSSONwGDigiDeGZ10CQAhfrb4ztqETHowIQKHs%3D&reserved=0 as an FYI, though I don't anyone at Azure is going to care given their focus on ACS-Enginehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FACS-Engine&data=02|01|bburns%40microsoft.com|b98a1a9357a14384b8ae08d4f4aa623f|72f988bf86f141af91ab2d7cd011db47|1|0|636402460004486948&sdata=Y%2BY2DKI%2BphdVtZBGQsw4ieyszA1djDBPHxnHl%2Fe%2Bw4E%3D&reserved=0
(Side note, I've worked heavily with 4 bring-up methods and made a couple small feature additions to tectonic-installer, my fifth. In my opinion, it is the cleanest, easiest to work with, and most comprehensive option I've seen yet (at least, for Azure). I'm assuming the plan is to keep kubernetes-anywhere as being minimal TF + "just invoke kubeadm", but I think it would still be interesting to think about if tectonic-installer could ever converge with kubernetes-anywhere in the future.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fkubernetes-anywhere%2Fissues%2F366%23issuecomment-327317334&data=02|01|bburns%40microsoft.com|b98a1a9357a14384b8ae08d4f4aa623f|72f988bf86f141af91ab2d7cd011db47|1|0|636402460004486948&sdata=%2BduXlPL0OV2jYHmf%2BiRXEkTW5xJHupAHgmJWJpvoges%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDgjVRmMT8AAa48KxJQY8bzyNcWXtfks5sfcXugaJpZM4Ms6zm&data=02|01|bburns%40microsoft.com|b98a1a9357a14384b8ae08d4f4aa623f|72f988bf86f141af91ab2d7cd011db47|1|0|636402460004486948&sdata=jqtX%2FzWOfKPMIF4M6QFzbeFNSg0G0ReEN0GUBowSEXE%3D&reserved=0.


SPM packages and Test Plans

Hi! I was wondering if XcodeGen was going to support two new features I'd like to try out with Xcode 11.

SPM packages
Test Plans.

I think I saw that xcodeproj support packages now.

Yeah I've been working a bit on SPM packages in my spare time. Here's a preview

Test Plans first needs XcodeProj support

@yonaskolb Any thoughts on a alpha/beta release with SPM support. This solves a lot of issues for us.
On a general note... kudos to you for creating and maintaining this project. Once discovered we've found it completely indispensable. Thank you!

Started using Xcode 11 with SPM thinking this is great but it will be hard to forget XcodeGen and then I saw this issue.

Wonderful! :)

Yeah ... thanks.  Funny, also was playing around and had a working prototype locally, very similar syntax, but I think I like yours better:
  Yams:
    package: https://github.com/jpsim/yaml
    version: 2.0.0 < NextMajor
  Yams:
    package: https://github.com/jpsim2/yaml
    version: 2.0.0 < NextMinor
  Yams:
    package: https://github.com/jpsim2/yaml
    version: 2.0.0 < 3.0.0
  Yams:
    package: https://github.com/jpsim2/yaml
    version: 2.0.0
  Yams:
    package: https://github.com/jpsim2/yaml
    branch: feature/cool
  Yams:
    package: https://github.com/jpsim2/yaml
    commit: afqwerqwefasdf

What about the issue with resolving packages since Package.resolved file is inside the generated xcodeproj?

One part that I haven't figured out properly yet either is support for local packages --- they kind of appear automagically if the source directory is listed (i.e. xcode recognizes them as a package etc.), but I don't have the the associated framework being linked properly against the targets.  I was kind of working with a methodology of not needing to explicitly declare local packages in the toplevel package section...

Could we do any folder with a Package.swift file in it? That's roughly what's going on with Xcode.

Swift Package support has been added here https://github.com/yonaskolb/XcodeGen/pull/624
Please test it out on your projects.

@zdnk:

What about the issue with resolving packages since Package.resolved file is inside the generated xcodeproj?

the Package.resolved file gets created by Xcode here. Project.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
If you want to check that file in selectively you can do so, without checking in the actual .pbxproj.
@rvanmelle:

One part that I haven't figured out properly yet either is support for local packages --- they kind of appear automagically if the source directory is listed (i.e. xcode recognizes them as a package etc.), but I don't have the the associated framework being linked properly against the targets. I was kind of working with a methodology of not needing to explicitly declare local packages in the toplevel package section...

@ethanjdiamond

Could we do any folder with a Package.swift file in it? That's roughly what's going on with Xcode.

What you are seeing is opening a Package.swift or it's directory directly in Xcode, which is another form of SPM integration that Xcode provides. What we are aiming to do with XcodeGen though is to generate an Xcode project that can utilise Swift packages, which is the other form of integration. This is required because iOS projects for example can't be defined with just a simple Package.swift as SPM doesn't yet have support for bundles and resources and all the complexities that come with iOS app.

@yonaskolb, awesome work with SPM! Have there been any updates about test plans support?

Closing this in favour of https://github.com/yonaskolb/XcodeGen/issues/684


Dubbed Anime

Can we get an option to watch dubbed anime?

Subs supremacy for now.

Reasonable enough

For the normies 83d557d9e45f37dc5c6fbdeae1a3fff1762e8672


Can not create index with custom analyzer

Elastic.Clients.Elasticsearch version: 8.0.0-beta.6
Elasticsearch version: 8.2.3
.NET runtime version: Microsoft (R) Build Engine version 17.2.0-preview-22126-01+40f49cd8d for .NET
Operating system version: Windows 11
Description of the problem including expected versus actual behavior:
When I try to create index with
var properties = new Properties {
    { "id", new LongNumberProperty() },
    { "access_level", new IntegerNumberProperty() },
    { "name", new TextProperty { Analyzer = "simple" } },
    { "description", new TextProperty() },
    { "country", new TextProperty { Analyzer = "simple" } },
    { "city", new TextProperty { Analyzer = "simple" } },
    { "subscriptions_count", new IntegerNumberProperty() },
    { "subscribers_count", new IntegerNumberProperty() },
};
client.Indices.CreateAsync(indexName, i => i
    .Mappings(m => m
        .Properties(properties)
        .Dynamic(DynamicMapping.Strict)
    )
    .Settings(s => s
         .Analysis(a => a
             .Analyzer(a => a
                 .Custom("whitespace_lowercase", wl => wl
                     .Tokenizer("whitespace")
                     .Filter(Enumerable.Repeat("lowercase", 1))
                 )
             )
         )
     )
);

I get an exception: illegal_argument_exception Reason: "Custom Analyzer [whitespace_lowercase] must be configured with a tokenizer"
Expected behavior
Index is created

Thanks for raising this @Wertual08. There are some issues with the settings code-gen right now which I plan to review. This looks to be one we need to focus on so I'll prioritise this for further review.


Color picker changes and selects the wrong color

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.59.1  (Universal) funny thing is that it doesn't have any problems on the Apple Silicon build :)
OS Version: macOS 11.4

So I guess a video is a 1000 images and an image is a 1000 words so here is a million words:

For some reason it keeps happening on the JSON settings that is: (and it only happens in your universal build, for reporting the bug I opened up the about and found it is universal, so I downloaded the apple silicon and when I run that version it is completely fine)
{
    "terminal.integrated.tabs.enabled": true,
    "editor.fontFamily": "Hasklig-Medium",
    "tabnine.experimentalAutoImports": true,
    "editor.fontSize": 14,
    "editor.lineHeight": 27,
    "workbench.iconTheme": "kary-standard-icons",
    "editor.comments.insertSpace": false,
    "workbench.preferredDarkColorTheme": "Kary Pro Colors － Dark",
    "workbench.preferredLightColorTheme": "Kary Pro Colors － Light",
    "window.autoDetectColorScheme": true,
    "cSpell.userWords": [
        "Kary",
        "Pouya",
        "monospace"
    ],
    "git.autofetch": true,
    "editor.renderControlCharacters": true,
    "editor.renderWhitespace": "none",
    "files.trimTrailingWhitespace": true,
    "editor.fontLigatures": "Hasklig",
    "git.confirmSync": false,
    "terminal.integrated.fontFamily": "Hasklig",
    "editor.codeLensFontFamily": "Hasklig-Medium",
    "[html]": {
        "editor.suggest.insertMode": "replace"
    },
    "[css]": {
        "editor.formatOnSave": true,
        "editor.defaultFormatter": "karyfoundation.righteous"
    },
    "workbench.startupEditor": "newUntitledFile",
    "workbench.editorAssociations": {
        "*.ipynb": "jupyter-notebook"
    },
    "terminal.integrated.fontSize": 14,
    "terminal.integrated.lineHeight": 1.4,
    "workbench.colorCustomizations": {
       "editor.findMatchBackground": "#f3d6ff",

       "editor.findMatchBorder": "#ff0000"
    },
    "editor.renderIndentGuides": false,
    "javascript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
    "javascript.format.insertSpaceAfterKeywordsInControlFlowStatements": true,
    "javascript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": true,
    "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": true,
    "typescript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": true,
    "typescript.format.insertSpaceAfterCommaDelimiter": true,
    "typescript.format.insertSpaceAfterConstructor": true,
    "typescript.format.insertSpaceAfterKeywordsInControlFlowStatements": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": true,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": true,
    "typescript.format.semicolons": "remove",
    "typescript.format.insertSpaceAfterSemicolonInForStatements": true,
    "typescript.format.placeOpenBraceOnNewLineForFunctions": false,
    "typescript.format.insertSpaceAfterTypeAssertion": true,
    "typescript.format.insertSpaceBeforeAndAfterBinaryOperators": true,
    "typescript.format.placeOpenBraceOnNewLineForControlBlocks": false,
    "typescript.format.insertSpaceBeforeFunctionParenthesis": true,
    "typescript.updateImportsOnFileMove.enabled": "always",
    "explorer.confirmDragAndDrop": false,
    "javascript.updateImportsOnFileMove.enabled": "always",
    "editor.highlightActiveIndentGuide": false,
    "editor.wordWrap": "off",
    "diffEditor.wordWrap": "off",
    "[markdown]": {
        "editor.wordWrap": "on",
        "editor.wordWrapColumn": 60,
        "editor.wrappingStrategy": "advanced",
        "editor.quickSuggestions": false,
    },
    "javascript.suggest.autoImports": false,
    "javascript.suggest.includeCompletionsForImportStatements": false,
    "typescript.suggest.autoImports": false,
    "typescript.suggest.includeCompletionsForImportStatements": false,
    "editor.inlineSuggest.enabled": true,
    "html.format.wrapLineLength": 70,
    "workbench.colorTheme": "Kary Pro Colors － Light",
    "[json]": {
        "editor.defaultFormatter": "karyfoundation.virtuous-vscode"
    }
}

It's weird that the hover shows on top of the css color being modified.

@rebornix
For some reason the day I reported it it happened multiple times (enough so I could even record it) but when I changed my binary to apple silicon, then it disappeared. It was really strange so I replaced the apple silicon with the old universal binary and it then again appeared. Today however I can't reproduce it either.
First I though maybe its the cache kept by different binaries that don't overlap but then since both builds were the same version of the same release channel then their cache was also the same and when you opened one instead of the other everything seemed exactly the same.

Encountered this just now, hover is on last line's color:

Code of that section:
	"workbench.colorCustomizations": {
		"statusBar.background": "#4a0c4a",
		"statusBar.foreground": "#e7e7e7",
		"statusBarItem.hoverBackground": "#761376",
		"titleBar.activeBackground": "#761376",
		"titleBar.activeForeground": "#e7e7e7",
		"titleBar.inactiveBackground": "#76137699",
		"titleBar.inactiveForeground": "#e7e7e799",
		"editorInlayHint.background": "#00000000",
		"editorInlayHint.foreground": "#ffffff65",
	},

Re-opening the file did nothing; reloading the window fixed it.
Maybe it has something to with changes made to the file. I had newly added the last two colors and the picker appeared on the last color of those that have been in the file before the changes. I tried adding some more after the window reload but this time the problem did not arise, though.

This is getting interesting :)


worker: turn off gce rate-limiting

refs https://github.com/travis-ci/reliability/issues/110

note: this has not yet been applied. i'll wait for the next round of worker deploys.


Create or modify an alarm with a radio stream always play default CHIME

Hi,
I tried
soco -l Salon create_alarm '10:00,01:30,WEEKDAYS,ON,"http://stream.live.vc.bbcmedia.co.uk/bbc_radio_fourfm",NORMAL,50,OFF'
soco -l Salon modify_alarm 4 '09:45,01:05,WEEKDAYS,YES,"https://icecast.radiofrance.fr/fipjazz-midfi.mp3",SHUFFLE,15,NO'

and the alarm play the CHIME
Playing radio stream is fine
soco -l Salon play_uri "https://icecast.radiofrance.fr/fipjazz-midfi.mp3"
soco -l Salon play_uri "http://stream.live.vc.bbcmedia.co.uk/bbc_radio_fourfm"

It worked in the past.

Thanks for the report. I'm seeing the same behaviour. I don't think I've changed anything that would cause this, so I wonder if Sonos has made a change.
What Sonos software version are you using?

|  Sonos One            |  Salon               |
| Model name           |  Sonos One           |
| Model number       |  S18                 |
| Serial number        |  xxx:G |
| Player name          |  Salon               |
| Zone name            |  Salon               |
| mac adress           |  xxx  |
| IP address             |  <IP_ADDRESS>       |
| Display version      |  15.1.1              |
| Hardware version    |  <IP_ADDRESS>-2.2        |
| Software version     |  71.1-38240          |

Thanks. Same as me.
Something funny's going on. I'll take a look at this at the weekend.

Sorry for the delay in getting to this.
Regrettably, it's clear that Sonos has changed something which has broken this functionality, in both S1 and S2 firmware variants. Possibly it's a bug on their part, possibly it's intentional. Nothing has changed in either SoCo-CLI or in the SoCo alarms module that would explain the issue.
SoCo-CLI and SoCo are sending the correct parameters, receiving a successful response from Sonos, and the alarm is present in the alarms list as I'd expect.
I have a weak suspicion that the lack of metadata supplied with the URI may now be tripping Sonos up, so I'm going to explore that, but I'm not particularly optimistic.

Ok, in v0.4.62 I've changed the way that alarms are created. Instead of using URIs in the alarm specification, the names of Sonos Favourites are used instead.
So, a stream must be present in the Sonos Favourites list before it can be used to create an alarm. Clearly this is an extra step before an alarm can be created, but on the upside it means that any Sonos Favourite can be used as an alarm created by SoCo-CLI.
This has only had light testing, so any feedback is appreciated!

Hi @Bruno21 -- did you get a chance to try this?

Sorry @pwt I was very busy this week. With 0.4.62, creating or modify an alarm is fine. It's easy to choose a favorite. I can even choose my Deezer flow. Great work !

Great -- thanks for testing.


handles cases where multiple slices in one strip

fixes #96

Codecov Report
Base: 89.28% // Head: 90.21% // Increases project coverage by +0.92% :tada:

Coverage data is based on head (055ba2f) compared to base (82f2ec4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   89.28%   90.21%   +0.92%
==========================================
  Files          13       13
  Lines         756      756
==========================================
+ Hits          675      682       +7
+ Misses         81       74       -7

Impacted Files
Coverage Δ

src/ifds.jl
97.31% <100.00%> (ø)

src/utils.jl
66.15% <0.00%> (-3.08%)
:arrow_down:

src/files.jl
82.25% <0.00%> (+6.45%)
:arrow_up:

src/types/common.jl
88.23% <0.00%> (+17.64%)
:arrow_up:

src/TiffImages.jl
100.00% <0.00%> (+20.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Dict

Fixes #
Proposed Changes

Can one of the admins verify this patch?

Test this please

test this please

please put the jira ticket number in the title of the PR, makes it easier to understand git history


Update package.json to remove warnings on install

Add license and peer-dependency to prevent warnings on install.
$ npm -v
2.12.0

License warning
$ npm install
npm WARN package.json<EMAIL_ADDRESS>No license field.

Peer-dependency warnings
$ npm install
npm WARN peerDependencies The peer dependency node-libs-browser@>= 0.4.0 <=0.6.0 included from webpack will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

:+1:


Create o365sen.txt

Institution/School Name
Seoul Metropolitan Office of Education
Instiution/School Website
http://www.o365edu.net
Email Users
Please place an x between the square brackets if yes

[x] Students
[ ] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[x] High School or equivalent
[x] Elementary School or equivalent

Note: All high school students in Seoul will get this email by approval from Seoul Metropolitan Office of Education

Unable to verify ownership of domain - no site associated, and WHOIS info returns nothing to associate this to any academic institution


New version: Andersama.obs-asio version 3.2.0

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

11:50:24 AM: 2024-01-22 11:50:24.024 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DownloadFlow.cpp(56)\WindowsPackageManager.dll!00007FFBF7E50AC0: (caller: 00007FFBF7E50B7E) Exception(1) tid(10e0) 80070032 The request is not supported.

(Automated response - build 623.)

Manual Validation ended with:

9:23:34 AM: 2024-01-25 09:23:34.041 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DownloadFlow.cpp(56)\WindowsPackageManager.dll!00007FFBB8670AC0: (caller: 00007FFBB8670B7E) Exception(1) tid(56c) 80070032 The request is not supported.

(Automated response - build 655.)

Manual Validation ended with:

Hi @vedantmgoyal2009,
The installation isn't unattended. Is there an installer switch to have the package install silently?
(Automated response - build 661.)


Tensorflow official guide for optimizing pipeline performance in Data input pipelines does not include proper use cases

Issue type
Others
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
v2.12.0-rc1-12-g0db597d0d75 2.12.0
Custom code
Yes
OS platform and distribution
RHEL8 .8
Mobile device
No response
Python version
3.10.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
The original tensorflow guide on [optimizing pipeline performance] (https://www.tensorflow.org/guide/data_performance#vectorizing_mapping) does not include useful use cases.
The function that is used to demonstrate the effectiveness of various techniques like batching , caching, mapping etc. is
def mapped_function(s):
    # Do some hard pre-processing
    tf.py_function(lambda: time.sleep(0.03), [], ())
    return s

This function is insensitive to a single element or a vector. How should we modify the function in order to deal with a batch, the case when we first batch the dataset and then map it with this function? Do we need to modify it in the first place or does tensorflow handle it on its own? These questions should have been answered in the guide.
I tried vectorized mapping( dataset.batch().map()) with this function
def function(x):
    return x+1

def tf_func(x):
    ans = tf.py_function(function, inp=x, Tout=['int64'])
    return ans

This also works fine as even in this case the function is be default capable of handling the vectors
but if we try a realistic scenario like this one
def read_files(filename):
    ...
    file = tf.io.read_file(filename)
    ...

This function fails to work throwing error that tf.io.read_file cannot handle the vector.
I think it would be helpful for all if practical use case scenarios are shown in the guide.
Thanks
Standalone code to reproduce the issue
dataset = tf.data.Dataset.list_files(...) #glob and read filenames

def preprocess_files(filename): #read and pre-process the files here
    ...
    file = tf.io.read_file(filename) #this function throws error
    ...

Relevant log output
No response

@AkshayRoyal Thank you for raising this issue!
Could you please have a look at this link which explains about the large input data and let us know if it helps? Please share the complete standalone code to replicate the issue. Thank you!


v1.6 backports 2020-09-29

#13332 -- Envoy: Update to release 1.14.5 (@jrajahalme)

Once this PR is merged, you can update the PR labels via:
$ for pr in 13332; do contrib/backporting/set-labels.py $pr done 1.6; done

test-backport-1.6

test-backport-1.6

test-backport-1.6

k8s tests failed on K8S 1.14 vm provisioning fail, should not be related to this backport. All other tests succeeded.

Somehow the K8s 1.14 provisioning fail vanished...


Update zio-prelude to 1.0.0-RC26

About this PR
📦 Updates dev.zio:zio-prelude from 1.0.0-RC21 to 1.0.0-RC26
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-prelude" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-prelude" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #571.


Amass in Sub_passive missing minutes

The sub_passive function uses amass enum for passive subdomain gathering. However the timeout time mentioned using {AMASS_ENUM_TIMEOUT} does not have "m" at the end. This ends the script in 3minutes instead of waiting for 180 min. Kindly change it

amass has been removed


match unity-axis and ros-axis about rays about lidar-2D

The visualized lidar sensor hit places on Rviz are different from its places on Unity when I change Min Angle Degree to different value from initial "0".
It worked very well when it still remains "0".
I tried fix it. How do you think?

@OldPaddy I'm not sure I understand the issue.  Can you describe specifically how to setup an easy test case?

@micahpearlman
I'm sorry I didn't make it clear enough.
I tested initial turtlebot3 scene like following image.
In this case, I changed the "Min Angle Degree" with lidar-2d script to 90 degree.
So the lidar FOV is from 90 to 360 degree. It doesn't match Unity and Rviz display.

Turtlebot3 tested scene. The display to the left is Unity, the right is Rviz.  The upward direction on the image is forward direction.

You can get the same result by manually adjusting the turtlebot definition by doing the following:
In lidar-2d Transform, set Rotation to X=180, Y=180, Z=0

Result:

You can get the same result by manually adjusting the turtlebot definition by doing the following:
In lidar-2d Transform, set Rotation to X=180, Y=180, Z=0

Result:

@alex-ssom Thank you for your description.
I think it's strange the places of the lidar-2d rays are mismatch.
Please let me know if my understanding is wrong.

@OldPaddy thanks, works for me. Its indeed a bug in ZOLIDAR2D.cs

这里是氨气同学的QQ邮箱，您的邮件我已收到，祝生活愉快~


Bundle solution with template, move files from project to solution

add solution to workshopmod template
wrap reloading in preprocessor debug directives wrapped in cnd:noEmit
move all files that are not packaged with mod away from project folder and into solution
add Workshop-description.txt file to keep proper mod description there

Is there a reason you did a lot of changes to the rtmodworkshop template and only changed the main in the normal rtmod template and left wrathmod alone?

So I originally only intended to update workshopmod and add preprocessor directives to wrath, but accidentally edited rtmod that I wanted to not touch at all.
Actually do we really need rtmod? Even if user doesn't use steam or has no plans on workshop publishing, they can just not use it. And remove Publish profile.
While having seconds almost identical copy except that it lacks publish task is a maintanence burden.
I could go and migrate all my structure changes done to rtmodworkshop to rtmod and wrathmod if you want.

I'd be grateful if you could add the relevant changes (i.e. making the Reload stuff behind #debug?) to the other two tempaltes

Done. They all have same structure now

Added dependency on https://github.com/xADDBx/PublishToWorkshopMSBuildTask/pull/2
Let's add update task first, and then this, so that description file will be useful immediately.


'git clone' instructions are inconsistent

Sometimes you end up in 'weaveworks-guides', sometimes in 'guides', sometimes in 'weaveworks/guides'.
At least in weave-and-docker-platform; whoever fixes this should scan the whole repo.
Note that if you have done a 'git clone' following one set of instructions, and then we change the location, the old files stick around to trip you up later.

Yes. I think it should be 'weaveworks-guides` everywhere, or we split each guide into it's own repo.

@ilya  I have been using the following, since this is how the user actually clones the repo and then changes to the appropriate directory:
git clone https://github.com/weaveworks/guides
cd ./guides/weave-and-docker-platform

@abuehrle yes, so may be repo URL can be changed to https://github.com/weaveworks/weave-guides...
However, personally, I'd vote to either split each guide into it's own repo, OR, as @tomwilkie suggested, we can generate tarballs on the fly with some kind of proxy he wanted to write. Both approaches improve beginner-level user experience and as well as provide us with an insight into usage. Actually, Tom's approach removes the dependency on git, not that I think it's a critical one.

URLs should be consistent now.


[feature request] ability to disable mobs

Hey,
When I edit the configuration file to lower certain monsters' weight to 0 and then launch the game it goes back up to 1. It would be nice if I can disable some from spawning by having the weight as 0 in the config

The mobs are the whole point of the mod, will be not be done.


Error occurred when executing SeargeCheckpointLoader

Hi, guys. Ive got this error scrin when i run queue text2img. Could you help me?
Error occurred when executing SeargeCheckpointLoader:
Error while deserializing header: MetadataIncompleteBuffer
File "I:\ComfyUI_windows_portable\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "I:\ComfyUI_windows_portable\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "I:\ComfyUI_windows_portable\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "I:\ComfyUI_windows_portable\ComfyUI\custom_nodes\SeargeSDXL\modules_legacy.py", line 1834, in load_checkpoint
return self.chkp_loader.load_checkpoint(ckpt_name)
File "I:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 476, in load_checkpoint
out = comfy.sd.load_checkpoint_guess_config(ckpt_path, output_vae=True, output_clip=True, embedding_directory=folder_paths.get_folder_paths("embeddings"))
File "I:\ComfyUI_windows_portable\ComfyUI\comfy\sd.py", line 425, in load_checkpoint_guess_config
sd = comfy.utils.load_torch_file(ckpt_path)
File "I:\ComfyUI_windows_portable\ComfyUI\comfy\utils.py", line 13, in load_torch_file
sd = safetensors.torch.load_file(ckpt, device=device.type)
File "I:\ComfyUI_windows_portable\python_embeded\lib\site-packages\safetensors\torch.py", line 308, in load_file
with safe_open(filename, framework="pt", device=device) as f:

same problem here any solutions?

Did you install the required models as mentioned in the readme file? Alternatively use the install script.

Did you install the required models as mentioned in the readme file? Alternatively use the install script.

yes. but suddenly it started working. i didnt do nothing


File top notification bar hard to read

See the yellow bar at the top of the file.
Version: 0.3.0

I can't reproduce it with master, can you test with master or latest update once it's out?

Looks good now!


Missing provider

Is your feature request related to a problem? Please describe.
To add new provider
Describe the solution you'd like
Add https://mail.crimeflare.eu.org
and all the sub-domains used
crimeflare.eu.org
activist.crimeflare.eu.org
bar.crimeflare.eu.org
box.crimeflare.eu.org
club.crimeflare.eu.org
fmtrl.crimeflare.eu.org
hi.crimeflare.eu.org
i.crimeflare.eu.org
ikr.crimeflare.eu.org
my.crimeflare.eu.org
ok.crimeflare.eu.org
ops.crimeflare.eu.org
party.crimeflare.eu.org
post.crimeflare.eu.org
resist.crimeflare.eu.org
user.crimeflare.eu.org
we.crimeflare.eu.org
with.crimeflare.eu.org
your.crimeflare.eu.org

Describe alternatives you've considered
null
Additional context
also submitted here: https://github.com/ihmpavel/free-email-domains-list/issues/249

Thank you - I will add them in.

I'm also running a test for dead domains with @PyFunceble and there are a lot. Wo;; share the results once the test have finished

Thank you

Added ✅


Improve Code Coverage

Bump code coverage to above 80%

Push code coverage metrics to coveralls

Push code coverage metrics to coveralls


ShadowReader: App is broken in Edge

Fix all compat issues on at least the latest version of Edge.

Is this related to a block scope let issue? (via @patrickkettner)

@jdalton block scope let issue was a confusion on my part, thought @patrickkettner debugged Edge, not Safari :) So no, there must be different set of issues.


chore(examples): web-pglite example use canary version of electric

I'm assuming we can close this in favour of https://github.com/electric-sql/electric/pull/1236?


PSReviewUnusedParameter in-place suppression instead of disabling the rule (OSOE-528)

The PSReviewUnusedParameter is disabled in our current configuration, because it produces false positives when a parameter is only used in a local function, but not in the main script body. See https://github.com/PowerShell/PSScriptAnalyzer/issues/1472.
A recent comment (https://github.com/PowerShell/PSScriptAnalyzer/issues/1472#issuecomment-1372431462) tipped me off to try suppressing those cases in-place, so we can re-enable the rule.
Jira issue

Shouldn't we instead wait for the bug to be fixed? In your PRs I see only suppressions, but no change due to the rule finding an issue. So, while it may catch issues in the future, apparently we don't have those frequently, and now it only necessitates suppressing false alarms.

The issue has been open for 2 and a half years, so why should we wait more?
There were a handful of true positives I fixed during one of the previous issues.

This rule currently brings more suppressions than fixes. So I don't see why we'd use it, especially since the bugs it guards against are minor.

@DAud-IcI please see this discussion.

Ah, I reviewed this a few hours earlier but then took a nap because the merging seemed complex. Shouldn't have slacked if I knew it leaves time for discussion. 😁
Anyway, it's pretty inconsequential either way, since only 2 scripts had to be suppressed.


Redirect glitch

The redirect does not seem to work when using it with a controller constructor.

In the future it's most helpful to provide code samples to recreate. In this case, though, you're right, it's a known issue, though it's not intended to. See Filters to handle those.


Make entangle and entangleShape safe

In #2 I suggested alternative safe versions of entangle and entangleShape. This patch implements this change. I think the result is pretty nice, as now entangle and entangleShape are useful and actually super fun, safe functions. Just take a look at the examples in the haddocks!

I think we might be able to clarify some of the code in entangleShape, so just for the ease of collaboration I've reverted this merge and made a new branch safe-entanglement on this repo. Let's continue the discussion on this pull request?


Confirm that there are blank control character cmap entries in fonts

We recognized that some Noto fonts (e.g., Noto Sans Hebrew) include bidi control characters.
According to @raphlinus:

I believe that BiDi control characters (that includes 200E and 200F, along with 202A-202E and 2066-2069, are handled entirely in the text shaping and layout engine, and do not need cmap entries in the font.

and @simoncozens:

you don't normally have explicit glyphs in the font for control characters, since they are handled higher up the text-processing stack and won't appear in runs to be shaped.

It would be useful to add a check for control characters in this range and flag at WARN level.  It does not violate spec, but appears to be unnecessary and (likely very slightly) increases file size.
Related https://github.com/googlefonts/noto-fonts/issues/2036

As I posted on googlefonts/noto-fonts#2036, Behdad proposed its safer to have empty control chars for scripts that need it, so let's check for that.

This is the list of code points based on the current state of the conversation:
0x00AD                            // SOFT HYPHEN
0x034F                            // COMBINING GRAPHEME JOINER
0x061C                            // ARABIC LETTER MARK
(0x200C <= c && c <= 0x200F)      // ZERO WIDTH NON-JOINER..RIGHT-TO-LEFT MARK
(0x202A <= c && c <= 0x202E)      // LEFT-TO-RIGHT EMBEDDING..RIGHT-TO-LEFT OVERRIDE
(0x2066 <= c && c <= 0x2069)      // LEFT-TO-RIGHT ISOLATE..POP DIRECTIONAL ISOLATE
0xFEFF                            // BYTE ORDER MARK

Yes, great :)
So, it seems to me we ought to map which scripts should include which (empty) control characters, and then check what the script is, and per script, if they exist in cmap with no ink data.
Behdad said he isn't aware of such a mapping. A harfbuzz community member contributed some interesting information to the hb wiki last month, that might help create such a mapping: https://github.com/harfbuzz/harfbuzz/discussions/2862
He also offered this tip:

ZWJ/ZWNJ is useful in all Arabic-joining-like and all Brahmi-like scripts. That's everything going to Arabic, Indic, Khmer, Myanmar, and USE shapers in HarfBuzz. The mapping is in:


Sound functionality

After selection, answer options are blocked
https://www.awesomescreenshot.com/video/23014046?key=b8db305c002f8c7411527d23570ea64a

After selection, answer options are blocked
https://github.com/MonicaStoyanova/who-wants-to-be-a-millionaire/assets/114282401/324e6d10-85b2-47cf-bbe8-20b9f398a07a


Sidebar posts module and related posts module are broken when post_thumbnail is false

Solution 3
Add vertical style for those two modules that look nice without thumbnails, for example.

@razonyang thank you for quick response!
I also tried this, post_thumbnail_resize_height: 14 - but I don't see any difference.
Maybe putting arrows below title?

yes, Solution 3 looks nice


MongoCluster Microsoft.DocumentDb 2024-06-01-preview

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Pl fix the warnings here - https://github.com/Azure/azure-rest-api-specs/pull/29330/checks?check_run_id=25964195658

/azp run

/azp run

@mentat9 Can I get another pass on this for the suppression - this is needed to workaround this issue https://github.com/Azure/azure-openapi-validator/issues/722

/azp run

Approved BreakingChange-Go-Sdk-Approved is expected, caused by typespec-go emit option fix-const-stuttering: true

/azp run

/azp run

/azp run

/azp run

/pr RequestMerge


Failed to download v.1.44 update

I don’t know where to report this problem so I put it here. I apologize if this is a wrong place, but please solve the problem because I can no longer update my VS Code.
System:

VSCode Version: 1.43.2
OS Version: MacOS Mojave

Steps to Reproduce:

Click the Manage button and choose Check for Updates… to download the latest update manually from within VS Code.
I wait for a few minutes then an error dialog shows up saying the download failed because of response time out.
I've tried to download manually from the VS Code download page but the page can’t be loaded with also time out error. I couldn’t even open the VS Code website.

I’ve made sure there’s no problem with my internet connection, I can open any other web sites fast and full. I confirm my ISP doesn’t block any VS Code web sites, they also have no reason to do so. I ask some friends of mine, I confirm the problem also occurs on some other internet providers as well, while some other internet providers doesn’t have the problem.
traceroute shows the connection to code.visualstudio.com got stuck at ae142-0.icr02.by21.ntwk.msn.net (<IP_ADDRESS>) that lead to time out. I think there’s a problem with VS Code site reachability, at least from Indonesia.

Does this issue occur when all extensions are disabled? Yes

Maybe there's an issue with your ISP. If you go directly to this page and click Mac: https://code.visualstudio.com/updates/v1_44
What happens?
Here's the direct URL: https://az764295.vo.msecnd.net/stable/2aae1f26c72891c399f860409176fe435a154b13/VSCode-darwin-stable.zip

Maybe there's an issue with your ISP.

As I said, nothing wrong with my internet connection and ISP. I can open any other web sites fast and full.

If you go directly to this page and click Mac: https://code.visualstudio.com/updates/v1_44
What happens?

Long time waiting and ending with time out error.

Here's the direct URL: https://az764295.vo.msecnd.net/stable/2aae1f26c72891c399f860409176fe435a154b13/VSCode-darwin-stable.zip

The same problem as above, time out error.

Not really sure what I can help with — the https://az764295.vo.msecnd.net URL is an Azure CDN and you are having issue connecting to it. It's an Azure issue and there's nothing I can help with.

Out of nothing and it seems nobody is doing nothing, suddenly it all works again. I think you’re right, @octref… it’s an Azure issue. Well, thank you.


add img matrix infra x kubectl

What this PR does / why we need it:
Add img matrix infra x kubectl to speed up ops toolbelt load times
Which issue(s) this PR fixes:
Fixes #37
Special notes for your reviewer:
Release note:

Add img matrix infra x kubectl to speed up ops toolbelt load times

@jfortin-sap this point is still open https://github.com/gardener/ops-toolbelt/pull/50#pullrequestreview-655018628

@petersutter PR updated

@petersutter Updated, ready to merge?

@petersutter ready to merge?


Automatically closing abandoned issues

@fchollet I came across something to make life better. There are a handful of tools out there to automatically close issues if they have been abandoned. Here is one example but there are plenty of options.
https://github.com/twbs/no-carrier
A configuration like this might be reasonable:

Send a warning at 2, 4 and 6 weeks.
Close after no activity for 8 weeks (other than the warnings), making sure to mark the resolution as something like "automatic closure" so it doesn't get confused with things that are manually closed. It would be easy to browse the automatic closures if you wanted to.
If something gets closed by accident, someone could always reopen it
Make some exceptions for any issues you want to pin and keep active.

There are currently 1,945 issues (not including this one) and rising. Does this sound like something reasonable to implement?
Cheers

Yes, sounds good to me.

I'll try it out and setup a demo in a test repository. If it looks good, we would just need to add a cron job to travis.

@fchollet The available tools weren't exactly what we needed, so I just put together a new module. I haven't done the PyPI release yet but I've tried it out and it looks good. Please take a look at the docs or code and let me know if there are any additional features that would be useful.
https://github.com/bstriner/github-bot-close-inactive-issues
The bot posts warnings every warning_frequency days starting at warning_start days after no activity. The bot closes issues after closing days. It can also mark that issue with a label like "closed_automatically" so it will be easy to search. If you run the bot with --test it will log the actions it would take but won't actually do anything.
I also put in an option first_closing_date so this can be phased in. It will only post warnings and not close any issues (no matter how old) until that date, so people can have a heads-up.
I did some testing in a separate repo. I turned the delay to 0 so it would immediately close the issues so I could test. This is what those automatically closed issues look like:
https://github.com/bstriner/github-bot-test/issues?q=is%3Aissue+is%3Aclosed
In terms of setup:

Create a new account for the bot, something like keras-bot
Generate a token for the account so it can connect with a high rate limit
Confirm an email address for the bot so it doesn't get flagged
Add the bot as a contributor to Keras so it will have permission to close issues
Edit the configuration file and run github-close-inactive-issues.py

My only concern is how to secure the bot account password. If the bot password is stored somewhere on the main travis server, someone could possibly get to it. Maybe we could setup travis to be secure but I would feel better if the bot was running on a different machine. Only need to run it every week or so for maintenance. Would you want to setup a local cron job so you know that password can't get out?

Maybe I should add some special handling to ignore issues created by @fchollet and issues with certain labels like help wanted.
Also, regarding setup, you would have to add a new label to the project that we could use for tracking the automatically closed issues.
Cheers

I just ran --test against keras. Here is what the results look like. Tons of issues to potentially close.
There are so many issues, I hit the rate limit when I was nearing the end.
The rate resets every hour, so I will add some logic to wait for the rate limit to reset. That means it might take 2-3 hours to run, at least until the number of issues gets down to a manageable number.

2017-01-25 02:27:27,540 - root - INFO - Checking rate limit for user github-bot-bot
2017-01-25 02:27:27,861 - root - INFO - Limit: 5000, Remaining: 4915, Reset: 2017-01-25 02:56:54
2017-01-25 02:27:27,862 - root - INFO - Starting close_inactive_issues
2017-01-25 02:27:27,864 - root - INFO - Repo: fchollet/keras, User: github-bot-bot
2017-01-25 02:27:27,864 - root - INFO - warning_start: 14, warning_frequency: 7, closing: 56
2017-01-25 02:28:11,351 - root - INFO - Issue 4987: warning posted, inactive for 14 days, will be closed after 2017-03-08 03:59:58
2017-01-25 02:28:12,773 - root - INFO - Issue 4984: warning posted, inactive for 14 days, will be closed after 2017-03-08 01:16:20
2017-01-25 02:28:13,115 - root - INFO - Issue 4982: warning posted, inactive for 14 days, will be closed after 2017-03-07 21:48:54
2017-01-25 02:28:13,513 - root - INFO - Issue 4981: warning posted, inactive for 14 days, will be closed after 2017-03-08 00:44:50
2017-01-25 02:28:14,171 - root - INFO - Issue 4978: warning posted, inactive for 14 days, will be closed after 2017-03-07 13:50:14
2017-01-25 02:28:14,513 - root - INFO - Issue 4977: warning posted, inactive for 14 days, will be closed after 2017-03-07 11:04:31
2017-01-25 02:28:14,845 - root - INFO - Issue 4976: warning posted, inactive for 14 days, will be closed after 2017-03-07 10:42:54
2017-01-25 02:28:15,733 - root - INFO - Issue 4974: warning posted, inactive for 15 days, will be closed after 2017-03-07 03:59:06
2017-01-25 02:28:16,479 - root - INFO - Issue 4969: warning posted, inactive for 15 days, will be closed after 2017-03-06 08:08:11

Added some logic to periodically check the remaining rate limit and sleep until it is reset. Should be close to ready now.

With current settings, the script took about 2 hours to run and wants to close 1,809  issues that are inactive. This list will give you an idea of about how long each issue has been inactive.
https://gist.github.com/bstriner/967b45c6d854d257055bcf9d86f44d99
Cheers!

Just released v0.0.2 to PyPI of github-bot-close-inactive-issues. I added the ability to ignore issues based on the creator and based on the label. I also fixed the entry points so I can use it on linux and windows.
https://pypi.python.org/pypi?:action=display&name=github-bot-close-inactive-issues
https://github.com/bstriner/github-bot-close-inactive-issues
With this update, you can just pip install github-bot-close-inactive-issues and that will put github-rate-limit (which just checks the rate limit) and github-close-inactive-issues (which closes the issues) onto your path.
So, I would envision the bot skipping anything created by @fchollet and anything with help wanted or bug as the label.
Even if we only automatically close issues after six months, that will still knock a ton of issues out of Keras.
Are there any other features or contingencies to consider?
Cheers

Kind of off topic, but I've had luck parring down the people that post multiple implementation questions as issues using the below code if/when I comment:
<br />
---

If your issue is an implementation question, please ask your question on [StackOverflow](http://stackoverflow.com/questions/tagged/keras) or [join the Keras Slack channel](https://keras-slack-autojoin.herokuapp.com/) and ask there instead of filing a GitHub issue.

Looks like the below. People generally aren't reading the stuff that is in the issue template, but (unsurprisingly) they do read answer people give them ;)

If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.

@patyork not off topic at all. That text or something similar should be in the warning for the bot.
https://github.com/bstriner/github-bot-close-inactive-issues/blob/master/github_bot.yml
I've started playing with the Github API and you could automate whatever you want. Crazy idea: use Github labels to mark issues as bugs vs. implementation questions and train a classifier to do some automation.
Google group also seems like a good place to talk. I'm not a huge fan of slack yet. Maybe include SO, slack and google group in the message?

@fchollet I did some poking around on the best way to configure something like this. Create a separate github repo with just a travis.yml and a github bot configuration file. Enable travis, disable builds on pull requests and enable cron builds. Configure the bot through travis environment variables.
The travis environment variables will be hidden to other users and they will not be able to write malicious code to access the variables if you disable builds on pull requests. That means the bot needs to run on a separate travis instance than the rest of keras.
Seems like it should be reasonable to get the ball rolling on the backlog. Still interested?

Yes, I still think this would be a good feature to have. Albeit it should
be paired with a reasonable level of formal handling of Github issues
(currently relatively few people look at them, and not in a structured
fashion).
On 8 April 2017 at 14:58, Ben<EMAIL_ADDRESS>wrote:

@fchollet https://github.com/fchollet I did some poking around on the
best way to configure something like this. Create a separate github repo
with just a travis.yml and a github bot configuration file. Enable travis,
disable builds on pull requests and enable cron builds. Configure the bot
through travis environment variables.
The travis environment variables will be hidden to other users and they
will not be able to write malicious code to access the variables if you
disable builds on pull requests. That means the bot needs to run on a
separate travis instance than the rest of keras.
Seems like it should be reasonable to get the ball rolling on the backlog.
Still interested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/5164#issuecomment-292748471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArWbyVPLG4u3QH7FvZNUdK4w_V4Avkhks5ruALwgaJpZM4LsxTZ
.

@fchollet You could configure the bot to just post warnings on stale issues and not actually close anything. That way you have some automated way to keep the ball rolling on issues and see if they are still active without accidentally closing something legit.
The bot could be a good start but there has to be a better way to handle issues. There are some actual legit issues buried in stacks of questions and there is no way to get a good handle on what is what.
It would be nice to use tags to differentiate, but you either do that all yourself or give other people the ability to nuke keras.
Github permissions are junk. It is basically all or none. I'm thinking about making some other apps to help with this kind of issue (not keras-specific).
Automatic closing and better permissions should be a part of Github. It would be like one line of SQL. However, while those things aren't in Github, it is something that can be built using the API.
What would you think of a Github permissions app? You would be able to add users and give them fine-grained permissions like adding tags, removing tags, closing issues, etc. The app would store the permissions table, and proxy commands to an owner account if they pass the permissions check.
The users view issues and PRs through the proxy app. Commands to comment go through their account. Commands to close, tag, merge, or whatever are proxied to an owner account that posts a comment like "closed on behalf of [username]" if permissions pass.
The bot for warnings and closings on issues could be rolled into the app as well.
Does that seem like something that would actually be useful on a broader scale? Wouldn't be hard to put something together if I can find some cheap hosting.
Cheers

@fchollet Glad you got something up and running. probot-stale looks like a javascript clone of my python repo but at least I don't have to support anything this way. It looks like they have some nice features. Please let me know any thoughts on how it works out.
Cheers


ERROR: Vimple Unable to extract player url;

Vimple does not work and giving the following error message.
ERROR: Unable to extract player url;

Post the full output you get with the --verbose option

Will be fixed in the next version. Thanks for the report.

This has been fixed in youtube-dl 2015.04.26. See our FAQ if you have problems updating.


Add a switch to hide the visual shader/script nodes in the docs

Alternative to https://github.com/godotengine/godot/pull/55993 (fix #55267) which does not add a special tag to classes but just uses a pre-defined array to compare.

Would it be better to change "Hidden Items" to be "Show All Items"? The request is to make the boolean positive.

Would it make sense to also include the "GLTF..." resource classes here? They're undocumented and they don't appear to have any use outside of the GLTF importer and exporter.

I guess you wanted the default to be true so "Show Default Items"?

No, I wanted it to be false

I don't really like the idea of adding a switch there. As the problem is mainly in the tree view, and less in the list view (IMO) I think a better solution would be to simply make the VisualShaderNode class collapsed by default, instead of expanding it automatically like others.


Apply expression can be omitted wrong suggestion

I can't find issue relating to same problem as mine, so I going to text a new one.
There is a case like in screenshot

Where I need to use ?.apply to save call not null instance of activity and then using it as a context to proceeding my logic
From my point of view there is no other case how this apply could be omitted without redo it in other way like this

but it is not omission, isn't it?

Version of detekt used: 1.9.1
Version of Gradle used (if applicable): 3.6.3

let is a better fit than apply for your use case. If let is marked as unnecessary we have a false positive. Could you check?
Opinated answer: there's nothing wrong with using a local variable and an if. It's shorter that your second option and easier to read.

Yep! It's going to work with "let". Would you describe why do you think "let" is better than "apply" please?

If I need to be clear here... I really don't know why. I know that when you just use an scoped function to check the nullabiblity the "convention" is let.
I use apply for initialize classes that have a bad API (because they are not initialized just with the constructor). For example:
val redPaint = Paint().apply {
  setColor(RED)
}

You could do the same with let
val redPaint = Paint().let {
  it.setColor(RED)
  it
}

but as you can see is not that "nice"
And you could even use also:
val redPaint = Paint().also {
  it.setColor(RED)
}

But they are not the correct fit here. I'm sorry but I can't give a rule here. If you search for "scope functions kotlin" in your favorite search engine you will find plenty of documentation about this topic.
I'm going to keep this open waiting for the feedback of other contributors because I have a concern here: Should we point out that you should use let instead? Can we decide this statically?

Yep! It's going to work with "let". Would you describe why do you think "let" is better than "apply" please?

As a rule of thumb, you can use the list you can find here: https://kotlinlang.org/docs/reference/scope-functions.html#function-selection
Your case is: "Executing a lambda on non-null objects" -> let
This rule is to prevent abuse of the apply{} scope function to configure just one field of an object. The example that @BraisGabin pointed out is the actual edge case:
val redPaint = Paint().apply {
  setColor(RED)
}

I'll argue this could potentially be rewritten with:
val redPaint = Paint()
redPaint.setColor(RED)

I'm going to keep this open waiting for the feedback of other contributors because I have a concern here: Should we point out that you should use let instead? Can we decide this statically?

As for reporting an alternative, I don't think it's easier to compute what's the valid alternative. Also the rationale behind the rule should be: if you use apply{} only to update one field -> probably you don't need apply at all.

Should the documentation of this rule be improved?

After reading the code I think that we can improve the documentation AND the message:

We can add one more example of noncompliant pointing that this: config?.apply { println(version) } should be config?.let { println(it.version) }
And we can check if the user is calling the apply using the safe null operator ?.. In this case we can tell that he should use let instead of apply. I mean, it's not obvious why config?.let { println(it.version) } is better than config?.apply { println(version) }, so if we can point it out we will help a lot.

What do you think?

@BraisGabin good ideas!

Ok! Now I know why in config?.apply { println(version) } let is recommended. With apply you can't be sure which version you are called. The version from config or the version from the outer class? With let this is more obvious because you need to specify it if you want to access the version from config.
So, it's not just a convention. There's an actual reason.


Investigate removing the series key sort from seriesCursor

Specifically:
https://github.com/influxdata/platform/blob/ea4c08b327efa62f870eb95ee217361e232e56dc/storage/series_cursor.go#L133
is expensive and in most cases wasted work. If the Read request performs a group by operation, the keys will be sorted again and likely vastly different to the lexicographical order:
https://github.com/influxdata/platform/blob/ea4c08b327efa62f870eb95ee217361e232e56dc/storage/reads/group_resultset.go#L52-L69

Closed by #13582


Fix subtitle formatting

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @mmohkamkarfsu on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


findEnumeratedCatalogEntry undefined issue

Getting undefined catalog entry for a properly assigned Measurement Value for a characteristics with Attribute type and the catalog definition.
for (let characteristic of piweb.data.getInspectionPlanCollection().getCharacteristics())
{
for (let measurement of piweb.data.getMeasurementCollection()) {
const value = measurement.findValueByEntity(characteristic);
if(value != null)
{
const CharCatalog = configuration.findEnumeratedCatalogEntry( characteristic, value);
piweb.logger.debug('CharCatalog: ' + CharCatalog?.key.toString());
}
}
}

Can you provide a minimal qdb and ptx sample that contains the extension?

The issue will be fixed in PiWeb Servicepack 8.2.24, 8.4.19 and 8.6.2.


我怎么安装不了这个代码curl easucks.cn/fifa20|sh

刷的梅林固件
显示的是-sh: curl: not found

只支持极路由官方固件
On Thu, Oct 10, 2019, 3:27 AM amauri-cn<EMAIL_ADDRESS>wrote:

刷的梅林固件
显示的是-sh: curl: not found
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Paull/hiwifi.easucks/issues/113?email_source=notifications&email_token=AACCWQXUJTMBI47I6Q7CETTQNYV7VA5CNFSM4I7DYJIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQXK7AA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCWQVQSKNWUUKQTIYUAT3QNYV7VANCNFSM4I7DYJIA
.

刷的梅林固件
显示的是-sh: curl: not found

梅林可以用啊，SSH开了没？