Arrow keys not working in repl in WSL.

Version
110.99.5 (Latest)
Operating System

[ ] Any
[X] Linux
[ ] macOS
[ ] Windows
[ ] Other Unix

OS Version
Ubuntu 22.04.3 LTS
Processor

[ ] Any
[ ] Arm (using Rosetta)
[ ] PowerPC
[ ] Sparc
[ ] x86 (32-bit)
[X] x86-64 (64-bit)
[ ] Other

System Component
Other
Severity
Minor
Description
In Windows Subsystem for Linux (WSL) I run Ubuntu 22.04 and I download the config.tgz extract and run install as per the documentation. Everything works fine and I have a 64-bit installation.
But when running the REPL and realizing I've misstyped I want to use the arrow keys to navigate to the error to correct, instead of the cursor moving I end up with this ^[[D^[[A^[[B^[[C.
The native Windows version works fine.
Transcript
No response
Expected Behavior
The cursor to move accordion to the arrow keys.
Steps to Reproduce
Run the latest version of smlnj in a WSL session.
Additional Information
Perhaps this is a bit of an edge case, but WSL seemed like the easiest way to run the 64-bit version on Windows.
Email address
m at rtin dot nu

SML/NJ does not currently support a command history, so you have to use some other wrapper.  Some people use an emacs shell, but rlwrap should work on linux.  I'll leave this issue as an enhancement request, since it is something that we should add to the REPL.
BTW, 110.99.6 is now available and it fixes the issue that you reported about TimeLimit.timeLimit on Windows (#320).

It is reasonable to ask for a history function in the SML/NJ REPL, but it is also not clear that this is worth doing.  Some unknown portion of users of the REPL run it in a context that already provides history management.  For instance, I almost always run the REPL in an emacs buffer (either a shell buffer or an sml buffer provided by the SML-mode package). Others use a terminal emulator of some sort that may provide a history-management feature. If someone wanted to implement such a feature for incorporation in the system we would seriously consider including it, but be aware that the "architecture" of the system, including the REPL and its relation with the compiler, may be revised in the next year or two.

But it isn't just up and down for command history, it's also left and right for fixing a spelling error or missing comma and the like.

But it isn't just up and down for command history, it's also left and right for fixing a spelling error or missing comma and the like.

You get that with rlwrap sml.  You can alias the sml command to rlwrap sml to get this behaviour by default.

I believe that rlwrap supports full editing of the command history.

A few years ago I wrote an implementation of the linenoise library in SML.  It took me a while to find it, but I've added the code to the library-development branch of the development repository.


Build Error on Windows 10

Hi, I am trying to use install.bat to install torch on Windows, but I met an error :

-- Configuring done
-- Generating done
-- Build files have been written to: D:/Coding/Projects/distro/pkg/torch/build
Microsoft (R) Program Maintenance Utility Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.
NMAKE : fatal error U1073: don't know how to make 'D:\Tools\Anaconda3\Scripts\conda.bat\envs\torch-vc14\Library\lib\libopenblas.lib'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Error: Build error: Failed building.
+++++++ Installation error!

It seems the correct path should be D:\Tools\Anaconda3\envs\torch-vc14\Library\lib\libopenblas.lib, can somebody tell me how to modify this or how to fix this? Thx!

Hi @BTNC  thanks a lot! Your answer do help me fix those problems. But I still met some problems like the following:

[  1%] Building NVCC (Device) object lib/THC/CMakeFiles/THC.dir/THC_generated_THCReduceApplyUtils.cu.obj
nvcc fatal   : nvcc cannot find a supported version of Microsoft Visual Studio. Only the versions 2010, 2012, and 2013 are supported
CMake Error at THC_generated_THCReduceApplyUtils.cu.obj.Release.cmake:222 (message):
Error generating
D:/Coding/Projects/distro/extra/cutorch/build/lib/THC/CMakeFiles/THC.dir//./THC_generated_THCReduceApplyUtils.cu.obj
NMAKE : fatal error U1077: 'D:\Tools\CMake\bin\cmake.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Error: Build error: Failed building.
+++++++ Installation error!

Do you know how to solve this? After I changed to VS 2013 Command Prompt, I also met another problem

NMAKE : fatal error U1077: '"D:\Tools\Visual Studio 2013 Ultimate\VC\bin\amd64\cl.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\Tools\Visual Studio 2013 Ultimate\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\Tools\Visual Studio 2013 Ultimate\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Error: Build error: Failed building.
+++++++ Installation error!

Wonder if you would know how to solve this. Thanks again.


API support for uuid parameter

Should the occurrences and monitoredOccurrences APIs support fetching of existing monitor results by the monitor uuid? This is nice functionality for use cases requiring compactness, eg: emailing searchers their queries.
BUT it may cause confusion for searchers in possession of a uuid that is not known to the system (most likely, a monitor that has expired). (Jen has little sympathy for searchers who don't make contact with admin, provide metadata, and  get their monitors archived in the monitors v2 index, so this doesn't bother her.)

UUID queries have been re-introduced due to popular demand! Please confirm that functionality is working as expected by closing this issue.
Example: http://api.effechecka.org/checklist?uuid=fde214ae-b44c-53df-8838-14d55bba8d4a
Only checklist/occurrences that have been previously processed can be requested by uuid. On requesting checklist/occurrences with a unknown uuid, a "bad request" will be returned.

This is working. Interestingly, Google offered to translate the results of http://api.effechecka.org/occurrences?uuid=93ac6418-e1a7-5697-a117-fd8ef9453826
from Welsh.

Cool! Can you attach a screen shot of the translation? Who knew that Welsh has similar linguistic features as occurrences lists... perhaps an unexpected avenue of research from our prototype...


Fix #312: chore(deps, security): metalsmith-markdown has been audited!

Coverage remained the same at 94.304% when pulling a235b31bc972fd7900deaab9fcb54b2a1278b66e on Zearin:audit/metalsmith-markdown into 5f9c26ac1c57d2a1e2b360a89d615c8340da9cba on segmentio:master.

@Ajedi32 How bout this one?


Remove FORMAT <..> backwards compatibility options from COPY

Which issue does this PR close?

Closes #9905 .
Rationale for this change

Please see the issue description.
What changes are included in this PR?

Reverts #9753
Reverts #9744

Are these changes tested?

Tests have been updated as the backward compatibility for format has been removed now.
Are there any user-facing changes?

Yes. Some related doc updates were done in  #9931. I've removed the leftover references to the old (format ...) options syntax from docs & examples.

Thanks again @tinfoil-knight


fp3 deviates from trajectory when close to joint limits

Context
Robot: FP3
libfranka version: 0.10.0
franka_ros version: 0.10.1
controller: position_joint_trajectory_controller
Problem
When close to joint limits, the system doesn't follow the trajectory correctly. In the example photo, an almost straight trajectory can be seen as a green line. The robot should go back a little bit. Instead of it, the robot just went down deviating from the path, and then stopped.

The other thing is that the system is not even close to the joint limits we indicated. In the joint_limits.yaml configuration file, we specify the limits of joint 2 as:
  panda_joint2:
    max_position: 1.7837
    min_position: -1.7837
    has_velocity_limits: true
    max_velocity: 2.62
    has_acceleration_limits: true
    max_acceleration: 1.875

Nevertheless, when this happens, we receive a warning from FrankaHW:
[ WARN] [1671185048.709777923]: FrankaHW:
	panda_joint2: 0.010531 degrees to joint limits (limits: [-1.513300, 1.513300] q: -1.513484)

It is worth mentioning that we tested the system at a lower speed, retiming the trajectories with a velocity scaling factor of 0.4 and this still happened.
Logs
The move group node used to execute the trajectory gives the following logs when failing the execution:
[ INFO] [1671185486.561096687] [/move_group]: Execution request received
[ WARN] [1671185487.829839542] [/move_group]: Controller 'position_joint_trajectory_controller' failed with error GOAL_TOLERANCE_VIOLATED: panda_joint2 goal error -0.073205
[ WARN] [1671185487.830000923] [/move_group]: Controller handle position_joint_trajectory_controller reports status ABORTED
[ INFO] [1671185487.830027370] [/move_group]: Completed trajectory execution with status ABORTED ...
[ INFO] [1671185487.830125222] [/move_group]: Execution completed: ABORTED
[ INFO] [1671185487.830877439] [/move_group]: Received event 'stop'

Hey @HumbertoE HumbertoE
Can you please update the Context section that you use FR(esearch)3 and not FrankaP(roduction). Also, add Robot system version from the Desk/settings.
Secondly, can you provide a demo repository of what you are trying to execute? This kind of problem is hard to reproduce and debug.
From what you described above, I would say that you linking the default yaml file from the repository where joint position limits for joint2 are [-1.513300, 1.513300].

I updated the version. Our system is a special case where FCI was enabled in a FP3 robot. The system, as I can see in Franka World, is called Franka Disruption 3.
To reproduce the problem, maybe the initial and final state of the robot are useful.
The initial position was at this joint configuration:
[1.5271146947877825, -1.5134893046578948, 0.018819685675540928, -2.351497353575113, -0.01094299672073909, 2.392510117859008, 0.027194409017560255]
while the final one was at:
[ 1.57079633, -1.49609623,  0, -2.0630839 ,  0,  2.1280997 ,  0 ]
And our joint limits specified in the joint_limits.yaml file are:
joint_limits:
  panda_joint1:
    max_position: 2.7437
    min_position: -2.7437
    has_velocity_limits: true
    max_velocity: 2.62
    has_acceleration_limits: true
    max_acceleration: 3.75
  panda_joint2:
    max_position: 1.7837
    min_position: -1.7837
    has_velocity_limits: true
    max_velocity: 2.62
    has_acceleration_limits: true
    max_acceleration: 1.875
  panda_joint3:
    max_position: 2.9007
    min_position: -2.9007
    has_velocity_limits: true
    max_velocity: 2.62
    has_acceleration_limits: true
    max_acceleration: 2.5
  panda_joint4:
    max_position: -0.1518
    min_position: -3.0421
    has_velocity_limits: true
    max_velocity: 2.62
    has_acceleration_limits: true
    max_acceleration: 3.125
  panda_joint5:
    max_position: 2.8065
    min_position: -2.8065
    has_velocity_limits: true
    max_velocity: 5.26
    has_acceleration_limits: true
    max_acceleration: 3.75
  panda_joint6:
    max_position: 4.5169
    min_position: 0.5445
    has_velocity_limits: true
    max_velocity: 2.
    has_acceleration_limits: true
    max_acceleration: 5
  panda_joint7:
    max_position: 3.0159
    min_position: -3.0159
    has_velocity_limits: true
    max_velocity: 5.26
    has_acceleration_limits: true
    max_acceleration: 5

If this is not enough to reproduce the error, I could send more data or a demo repository, but in this case, I would appreciate it if I could share it privately.

And regarding linking wrong the repository, the system responds to changes in this yaml file. We have 2 computers, one that runs most of our code and the move_group node and one that runs franka control, but both have the same joint_limits.yaml file.
We load the robot description in a launch file with:

But the urdf has different limits, actually the joint 2 limits are  [-1.513300, 1.513300] as the warning from FrankaHW shows. I thought the joint limits where overwritten, but do we have to change something for this? Or do we have to change the urdf every time the limits changes?
Thank you in advance for your help.

You were right, we were linking the default yaml file when running the xacro file. Our move_group node used for planning had our defined limits, but the franka_control did not.
We changed this, regenerated the URDF file and now the problem is solved.
I will therefore close the issue. Thank you for the help


Added LilyGo T3 S3

Added LilyGo T3 S3
Added radio chip LR1121

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
215

Relevant Lines:
215

💛  - Coveralls


locale: Remove meridians from time patterns

Related to #3534
These formatting symbols are not used, and they should not be used because most apps only work with the time string HH:MM:SS and they expect the meridian to be accessible from the separate meridian function. I suggest removing these symbols.
The removal changes nothing for existing users of the app.

Requesting review from @gfwilliams


add service wrapper that emit metrics automatically

add tchannel service wrapper that automatically emit metrics on all service calls.
This will emit metrics like:
PollForActivityTask.cadence-request
RespondDecisionTaskCompleted.cadence-latency
....

Coverage decreased (-75.2%) to 24.806% when pulling e39c0344097c51f807227fb3a79fa343bb505e48 on yiminc:metrics_wrapper into 25aa0feb581831769cecfd4bef5094a4ec967aa4 on uber-go:master.

@sivakku , for this wrapper the main idea is we want to capture a generic info regarding every service call. This is handled in the same way as it is on server side (metricClient).

Coverage decreased (-100.0%) to 0.0% when pulling aba625cf9172a7fc841eaaa636a60ecb2571d4dc on yiminc:metrics_wrapper into 25aa0feb581831769cecfd4bef5094a4ec967aa4 on uber-go:master.

Coverage decreased (-68.0%) to 32.0% when pulling eb084b5d7368c10cd228fc7dc83cbc435ea49c11 on yiminc:metrics_wrapper into 25aa0feb581831769cecfd4bef5094a4ec967aa4 on uber-go:master.

Coverage decreased (-68.0%) to 32.0% when pulling 3be7ff1adbc1f7de0778ae9be42fd861316488f6 on yiminc:metrics_wrapper into 74259190e46a65b3f5d44c50a0cb6ae89294669e on uber-go:master.

Coverage decreased (-1.5%) to 98.5% when pulling 3f8e797e113b5c824451e188772e4b8b5347a898 on yiminc:metrics_wrapper into c13cbb6676957f36c313c168a0029c650d6d4db2 on uber-go:master.

Coverage decreased (-1.5%) to 98.5% when pulling 139f9a7fbbe6950c615a90ebf9058520ce3af951 on yiminc:metrics_wrapper into 519f518b1b39f6ca0d8f1d2511b91565c980a1c9 on uber-go:master.


Bump elm-html version, so that apps that depend on it don't get an old version

This was resulting in an inscrutable error about trying to get 'arity' of 'undefined' (namely, VirtualDom.Attribute) in my code.
I haven't noticed any breakages from doing this, but I can't tell for sure.

I think the compiled code from the sidebar can overlap with the code generated by your program, leading to weird interactions. If my memory serves me well, this seems like it should not really be relevant unless you are building from source in a very particular way. What exactly is your situation? Does it seem like a better fix to somehow sandbox the sidebar code?

This happened on the binary release for me. Definitely sandboxing the sidebar code would be a better solution.

The current version of the reactor now does have higher version bounds on elm-html, so I think this pull request can be closed.
The broader issue, that libraries depended on by the reactor's debugging mode as well as by the program running in the reactor might clash (different versions, unclear interference), is also covered here: https://github.com/elm-lang/elm-reactor/issues/104.

We are hoping to just have these things totally isolated in the next release, so this kind of thing won't be a problem anymore.


Proposal: Extend wildcard support on permissions

I think wildcards on permissions are a really powerful way to specify default behavior that can be overridden. However, this is beyond the current implementation. For example:
permissions:
  - operation: "*.read"
    authenticated: false
  - operation: ["*.update", "*.delete"]
    authenticated: true
    query: ./src/permissions/owner.graphql:ownerOnly
  - operation: "MyType.delete"
    authenticated: true
    query: ./src/permissions/MyType.graphql:deleteOnlyCompletedNodes
  - operation: ["MyOtherType.read"]
    authenticated: true
  - operation: ["VeryRestrictedType.*"]
    authenticated: true
    query: ./src/permissions/admin.graphql:userNeedsToBeAdmin

So there are a few things here:

Wildcards on types
Wildcard on permissions
Overriding higher level permissions
Specifying the same settings for multiple operations at once

Another approach, inspired by https://www.graph.cool/forum/t/feedback-new-cli-beta/949/50?u=agartha, would be to even abstract this further, by adding 'permission definitions':
permissionTemplates:
- authenticatedAdmins:
    authenticated: true
    permission: ./src/permissions/admin.graphql:userNeedsToBeAdmin
- authenticatedOwners
    authenticated: true
    permission: ./src/permissions/owner.graphql:ownerOnly

permissions:
  - operation: "*.read"
    authenticated: false
  - operation: ["*.update", "*.delete"]
    applyTemplates: ["authenticatedAdmins", "authenticatedOwners"]
  - operation: "MyType.delete"
    authenticated: true
    query: ./src/permissions/MyType.graphql:deleteOnlyCompletedNodes
  - operation: ["MyOtherType.read"]
    authenticated: true
  - operation: ["VeryRestrictedType.*"]
    applyTemplates: "authenticatedAdmins"

Because of this normalized, inherited structure, it would be nice if graphcool info or another command would show you the 'effective' permissions for all types, so:

Typename
Operation
Fields
Authenticated: true/false
Query

I definitely like this, permissions deserve some love to become an adult.


Standalone Sketch File Format v1.0.0 ☂

Progress

[x] Spike feasibility of autogenerated schema (https://github.com/BohemianCoding/Sketch/issues/24735#issuecomment-525272025)
[x] MVP JSON Schema File Format (https://github.com/BohemianCoding/sketch-file-format/issues/2)
[X] Release v1 https://www.npmjs.com/package/@sketch-hq/sketch-file-format 🎉

This issues discusses how a v1.0.0 of a standalone Sketch File Format project might work and look like.
A standalone Sketch File Format would have the following important properties:

Serve as a single source of truth for the format
Allow disparate teams within Sketch B.V. to organise around a shared specification
Can be transformed into useful formats, including —

Documentation
TypeScript types (typesafe documents or document fragments in JS/TS projects)
JSON Schema (validate documents)
Swift models (for Sketch.app)
GraphQL schemas (for backend)
Anything else

Defines the interchange format for an ecosystem of internal products and 3rd party integrations
Treated as a product in its own right
Public, published and working in the open
Independently versioned (i.e. deliberately ignorant of any Sketch.app version), with a predictable, measured release cadence
No other Sketch B.V. product dependencies (root of the tree)
Easily maintainable with modern tooling and CI to ensure internal correctness

✂ Hand-crafted vs auto-generation
We've already tried auto-generating a file format specification from the Sketch code base. It was an incredibly useful learning exercise, but has critical drawbacks:

It doesn't solve the core organisational issue, which is that the relationship between Sketch and the file format is inverted (Sketch should consume and conform to a public file format, rather than potentially mutating it without warning every release)
It proved difficult to generate a 100% correct and sufficiently rich format automatically from the Sketch code base

Therefore, maintaining a hand-crafted file format as a product seems like the best next step to explore.
👑 Source format
The source format defines the technology we use to maintain the file format source, but isn't prescriptive about the formats that can be derived from it. Indeed, the objective here is to pick a source format that enables fluent transformation to as many other output formats as possible.
There are two main candidates:
JSON Schema
JSON Schema itself is an obvious choice. It has rich semantics which allows it to fully describe complex models, and has been widely adopted with tooling support in many languages and platforms. The JSON Schema specification process has been adopted by the IETF and sees active development.
A potential downside is that JSON Schema is just raw JSON, and as such the experience of maintaining a complex/large JSON Schema document by hand could have some challenges. We could look into JSON Schema $refs to split the schema into manageable chunks.
TypeScript
Defining the file format in code using TypeScript would bring a few benefits:

TypeScript compiler could check correctness during compilation
Use tooling and IDE integrations to enhance the maintenance experience (formatting, linting)
Code separation into modules would enable the schema to be broken into smaller logical chunks more easily than manually managing JSON files
TypeScript is similar to Swift, so editing a schema in TypeScript could potentially be easier for native developers, rather than having to learn the JSON Schema spec (we'd have to gather opinions here)
No need to implement a TypeScript output format separately (which we're sure to need immediately)

The TypeScript AST is well documented, and would serve as a robust data format to enable transformation to other formats. We could write our own TypeScript to JSON Schema transformer for example, or use existing tools like typescript-json-schema. Tooling for TypeScript to Swift transformation exists in the wild too, e.g. quicktype.
We'd have to ensure that we can sufficiently describe the existing file format model in TypeScript before choosing this route, since the range of type information and their interrelationships it can describe is more limited than JSON Schema (this could turn out to be a good thing - since its also simpler).
Swift
There could be a compelling case made for using Swift for the source format, since the most important consumer of the file format will be Sketch.app. The feasibility of this would hinge around the suitability of using the Swift AST as a source data format for onward transformation into JSON Schema, TypeScript and others.
Is the Swift AST sufficiently mature? What does the existing tooling and documentation around it look like? Does it limit the potential for 3rd parties to easily write their own transformation scripts? This would need investigating by a native developer.
💁 Output formats
We would expect the community to use the file format to generate diverse formats that work with their specific workflows and toolchains, therefore we don't need to be exhaustive in the output formats we initially implement.
A v1.0.0 of the file format could simply include the source format itself, whatever it is. Additional output formats that we're certain to need internally (e.g. TypeScript, or Swift) could be looked at as a follow on task.
Rather than pollute the core file format repo with generator code for other formats, these could be housed in separate repos (GitHub Actions could eventually be used to trigger builds when a new file format is released).
🌳 Structure
The following structural elements and types should be describable by the file format,

A definition for the root document type and every class/object type that can appear as a child in the document
Limit object properties to allowable types (e.g. layers array can only contain elements of union type Layer, for example)
Encode whether properties are optional
Descriptive enums (e.g. all possible values of _class, or colorProfile properties etc)
Handy union types not explicitly appearing in the Sketch.app model, but useful for developers parsing/generating documents in the wild (e.g. a type representing a union of all layer types)
If practical reproduce some aspects of the Sketch.app model class hierarchy (main benefit here would be to reduce duplication in the file format source, rather than attempting to mirror the internals of the native app, e.g. define an abstract type for layers, which could share common properties amongst all concrete types that behave as a layer)

⚠ Change management
There's no beating around the bush - the main driver of change in the file format would be Sketch.app.
Rather than deny that reality the objective is to formalise the relationship, ensure changes to the file format are explicit and deliberate and to implement a process where new versions of the file format are released ahead of time, or concurrently with the version of Sketch.app that supports it.
The change management process could look something like,

File format versioned independantly of Sketch.app, following semver
Sketch documents written in the file format no longer declare their compatibility with Sketch.app, rather they declare the version of the file format they conform to
Limit the pace at which new features are added to the file format - since this churns the format and burdens the entire ecosystem. Suggest annually, or less
This would mean stacking up Sketch features that require new features or changes to the file format and releasing them together in a dedicated Sketch release that advanced the file format by major version. Example scenario,

Discuss and define the set of changes needed to support new features for a special release of Sketch that introduces new features to the file format
Pre-release v2.0.0-rc1 of the file format supporting said features early on
Iterate through release candidates while preparing for main Sketch release, e.g. v2.0.0-rc2, v2.0.0-rc3, etc.
Then headline the relevant Sketch release "Now outputs in v2 of the file format" and simultaneously release the final v2.0.0 version of the file format
Interested 3rd parties could have followed along with the release candidates too, so upgrading to the final release would hopefully be a painless version bump. For those who didn't have their eye on the ball the release would be documented with a changelog and ready to go with freshly published schemas and types, so upgrading to a new version of the file format and fixing any compile errors hopefully also a much improved experience than the current arrangement allows

Bug fixes could be released as patch versions as often as needed to fix inconsistencies between the file format and versions of Sketch released in the wild

🤖 Hosting
The primary hosting mechanism could be tagged GitHub releases on the file format repo.
Thereafter, derived output formats could be hosted in whatever fashion makes most sense for their community/ecosystem. E.g. npm for TypeScript types etc.
🤔 For further discussion
How will the file format fit into the native Sketch.app workflow?
The responsibility here will lie with the Sketch dev team to figure out an approach for ensuring the versions of Sketch they release output documents that validate against the file format.
It's important to note that, technically speaking, a v1.0.0 of a standalone file format should precisely match the schema of files outputted by the current version of Sketch. So initially the changes to the Sketch development process might centre more around testing, than large internal changes.
We need input from native developers but a few strategies could include,

Generate Swift code from the file format
Unit tests
Integration tests validating documents against a JSON Schema

The TypeScript AST is well documented, and would serve as a robust data format to enable transformation to other formats. We could write our own TypeScript to JSON Schema transformer for example, or use existing tools like typescript-json-schema. Tooling for TypeScript to Swift transformation exists in the wild too, e.g. quicktype.

Oh boy this would have been great to know! 😄


How to disable hf_transfer?

I'm trying to download LLama 3.1 8B instruct. Litgpt is hagging or rasing exception:
Exception: Failed too many failures in parallel (3): PyErr { type: <class 'Exception'>, value: Exception('Error while downloading: reqwest::Error { kind: Body, source: hyper::Error(Body, Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }) }'), traceback: None } (NoPermits)
and
File "/home/users/vabatista/mamba3/envs/sesame2/lib/python3.12/site-packages/huggingface_hub/file_download.py", line 439, in http_get     raise RuntimeError( RuntimeError: An error occurred while downloading using hf_transfer. Consider disabling HF_HUB_ENABLE_HF_TRANSFER for better error handling.
I tried to disable HF_HUB_ENABLE_HF_TRANSFER=0 in environment, but has no effect. In first output line of litgpt download command it prints Setting HF_HUB_ENABLE_HF_TRANSFER=1
What I'm doing wrong?

Hello @vabatista
To better isolate the problem, you can comment out this code
https://github.com/Lightning-AI/litgpt/blob/main/litgpt/scripts/download.py#L79-L82
and check does it help or not.

Consider disabling HF_HUB_ENABLE_HF_TRANSFER for better error handling.

It might not be the problem with the hf_transfer itself, just the error it produces is not clear enough.


[Inventory] Cannot scroll on smaller screens

See right hand side.

https://github.com/webaverse/app/pull/144

finished


[Enhancement] Method manually handles closing an auto-closeable resource [MetaHandler]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
https://github.com/apache/eventmesh/blob/ee9ee4c63670b57b832898624a061335153bb67c/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetaHandler.java#L138-L145
analysis and explanation:
This method allocates and uses an auto closeable resource. However, it manually closes the resource in a finally block. While this is correct management, it doesn't rely on the idiomatic way available to JDK 7 and above, allows for possible subtle problems, and complicates the reading of code by developers expecting the use of try-with-resources.
Describe the solution you'd like
Change to use try-with-resources to manage resources.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Is this issue still alive? It seems nobody has been working long time on it. If so I would like to pick it up.

@arsenalzp Welcome!


OneSignalNotificationServiceExtension causes sharedApplication build issues

Description:
Adding the target OneSignalNotificationServiceExtension causes my app to be unable to build, due to being unable to use certain things in app extensions... in this case, the error is specifically about sharedApplication (it actually shows up as a problem in RCTRedBox.m).  The app builds fine, even with react-native-onesignal, until I add the extension.
Environment
react-native-onesignal: 3.3.3
react-native: 0.59.9
SDK added via yarn, then react-native link react-native-onesignal
Steps to Reproduce Issue:
I haven't had the time to attempt to reproduce in an app other than mine... On my app (so presumably others?):
Install SDK via yarn
Link package
pod install
Add extension following instructions from https://documentation.onesignal.com/docs/react-native-sdk-setup#section-usage
Attempt to build
Anything else:
All in the description

Update: we have released version 3.4.0 that should fix this issue. If not, please comment and I will reopen. Cheers

Hi, @rgomezp . I have this error with 3.4.1 at the moment.

node_modules/react-native/React/DevSupport/RCTDevLoadingView.m:77:42: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.

Not sure if this applies to your library, but I’ll inform you

So.

Project without any OneSignalNotificationServiceExtension is built successfully.
Added OneSignalNotificationServiceExtension with contents by default (without Onesignal imports)
Added Onesignal to podfile:

target 'OneSignalNotificationServiceExtension' do
  pod 'OneSignal', '>= 2.9.3', '< 3.0'
end

and launched pod install
4. Then trying to build project and we are will receive:

node_modules/react-native/React/DevSupport/RCTDevLoadingView.m:77:42: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.

System:
    OS: macOS 10.14.6
    CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 11.75 GB / 32.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.16.1 - ~/.nvm/versions/node/v10.16.1/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.1/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 23, 25, 27, 28, 29
      Build Tools: 25.0.2, 25.0.3, 28.0.3, 29.0.1, 29.0.2
      System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
    Xcode: 11.0/11A419c - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.5 => 0.60.5

└─<EMAIL_ADDRESS>

@indapublic ,
Take a look at this stack overflow which may help. If any of the proposed solutions work for you, please comment here so we can close the ticket and help anyone else who may run into the problem:
https://stackoverflow.com/questions/32031071/error-sharedapplication-is-unavailable-not-available-on-ios-app-extension

Thanks, @rgomezp. I found that my podfile was wrong. I moved target "OneSignalNotificationServiceExtension" in wrong section yesterday. All works fine. Thank you and sorry. I can close this issue

@indapublic ,
Could you show how your podfile looked when it wasn't working? This will help people in the future if they make the same mistake

target 'app' do
  target 'OneSignalNotificationServiceExtension' do
    pod 'OneSignal', '>= 2.9.3', '< 3.0'
  end
end

Don't have many experience with cocoapods yet, thought extensions were application dependent

Went through this exact same issue and like @indapublic did, I had added the extension to my Podfile incorrectly. Just wanted to add some clarity.
This issue arises when you add Service's target inside your app's target.
This is wrong:
target 'app' do
  rn_path = '../node_modules/react-native'
  ....
  target 'OneSignalNotificationServiceExtension' do
    pod 'OneSignal', '>= 2.9.3', '< 3.0'
  end
end

This is correct:
target 'app' do
  rn_path = '../node_modules/react-native'
  ....
 end
 target 'OneSignalNotificationServiceExtension' do
    pod 'OneSignal', '>= 2.9.3', '< 3.0'
 end

This snippet needs to be its own top-level target and not a sub-target of your app.
Once corrected just run pod install again.

Thanks, this fixed it for me too. I was under the impression that other answers suggested the opposite.

Please re-open this one. I'm having a huge issue with this one, it didn't work out for me moving the lines:
my podfile looks like the following:
target 'app' do
    # Pods for app
    pod ...
    pod ...
    pod ...
    pod ...
    pod ...
    use_unimodules!
    use_native_modules!

# Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable these next few lines.
  add_flipper_pods!

  post_install do |installer|
    flipper_post_install(installer)
  end
  target 'OneSignalNotificationServiceExtension' do
    pod 'OneSignal', '>= 2.9.3', '< 3.0'
  end
end

And, I'm getting the same issue: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.


Enable getting at OPT records

Support functionality for dotse/zonemaster#305.

Fixed in commit ae0b150752c0e025e2a5847f72758ae24ec70601.


Add examples to sandbox

Port several examples from the old docs site to the new sandbox.
Closes #92.

Yeah I'd love to. I was thinking that we could do this automatically with a webpack loader, i.e. load the example file both as JS and as raw text, and display the two next to each other.


Log name of topic when topic not found

Motivation
We don't get the topic name when topic failed to found
2-09-16 14:12:30.043 [AsyncHttpClient-62-1] ERROR io.streamnative.pulsar.handlers.kop.KafkaRequestHandler - [[id: 0xb930401b, L:/x:9093 - R:/x:46344]] Automatic topic creation is not allowed on namespace public/data-channel

Modifications
Log name of topic when topic not found
Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.gavingaozhangmin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@BewareMyPower Can you help review this PR?


[ Android ][ Marker ][ Error ] No position in marker options

I am trying to run the example at https://github.com/lelandrichardson/react-native-maps/blob/master/example/examples/DefaultMarkers.js and tried others also ,
but getting following error when i try to set a marker on map.

My gradle file :
compile 'com.google.android.gms:play-services-maps:8.4.0'
compile 'com.facebook.react:react-native:0.30.0'
compile 'com.airbnb.android:react-native-maps:0.7.1'I can see the map loading .
can anybody help with the suggesting what is it that i am doing wrong?
following is my code :
var React = require('react');
var ReactNative = require('react-native');
var {
StyleSheet,
PropTypes,
View,
Text,
Dimensions,
TouchableOpacity,
AppRegistry
} = ReactNative;
var MapView = require('react-native-maps');
var { width, height } = Dimensions.get('window');
const ASPECT_RATIO = width / height;
const LATITUDE = 37.78825;
const LONGITUDE = -122.4324;
const LATITUDE_DELTA = 0.0922;
const LONGITUDE_DELTA = LATITUDE_DELTA * ASPECT_RATIO;
let id = 0;
function randomColor() {
return '#'+Math.floor(Math.random()*16777215).toString(16);
}
var maps= React.createClass({
getInitialState() {
return {
region: {
latitude: LATITUDE,
longitude: LONGITUDE,
latitudeDelta: LATITUDE_DELTA,
longitudeDelta: LONGITUDE_DELTA,
},
markers: [],
};
},
onMapPress(e) {
this.setState({
markers: [
...this.state.markers,
{
coordinate: e.nativeEvent.coordinate,
key: id++,
color: randomColor(),
},
],
});
},
render() {
return (

{this.state.markers.map(marker => (
<MapView.Marker
key={marker.key}
coordinate={marker.coordinate}
pinColor={marker.color}
/>
))}

Tap to create a marker of random color

);
},
});
var styles = StyleSheet.create({
container: {
position: 'absolute',
top: 0,
left: 0,
right: 0,
bottom: 0,
justifyContent: 'flex-end',
alignItems: 'center',
},
map: {
position: 'absolute',
top: 0,
left: 0,
right: 0,
bottom: 0,
},
bubble: {
backgroundColor: 'rgba(255,255,255,0.7)',
paddingHorizontal: 18,
paddingVertical: 12,
borderRadius: 20,
},
latlng: {
width: 200,
alignItems: 'stretch',
},
button: {
width: 80,
paddingHorizontal: 12,
alignItems: 'center',
marginHorizontal: 10,
},
buttonContainer: {
flexDirection: 'row',
marginVertical: 20,
backgroundColor: 'transparent',
},
});
AppRegistry.registerComponent('maps', () => maps);

Maybe try to console.log(e) inside onMapPress(e) {} and see what are you getting back?

Thanks , I do get correct coordinates . I have validated that by putting
break point in the code.
On 9 Aug 2016 18:45, "kakbeya"<EMAIL_ADDRESS>wrote:

Maybe try to console.log(e) inside onMapPress(e) {} and see what are you
getting back?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lelandrichardson/react-native-maps/issues/451#issuecomment-238548847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQvNxqe8iHsieNtAKD14_sWI9h7dpFtks5qeH2AgaJpZM4Jf32M
.

Ping !

found the issue,

Google playservice maps version was not latest in my gradle file
Proguard rules were not set properly .

Closing it .
Thanks


[Event Request] Table 981 "Payment Registration Buffer" - GetDueDateStyle

Please add the following Event GetDueDateStyle in Table 981 "Payment Registration Buffer"
procedure GetDueDateStyle(): Text
    var
        IsHandled: Boolean;
        ReturnValue: Text;
    begin
        //>> Begin
        IsHandled := false;
        OnBeforeGetDueDateStyle(Rec, ReturnValue, IsHandled);
        if IsHandled then
            exit(ReturnValue);
        //<< End

        if "Due Date" < "Date Received" then

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetDueDateStyle(var PaymentRegistrationBuffer: Record "Payment Registration Buffer"; var ReturnValue: Text; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11976.


Superset over Clickhouse doesn't handle well nullable columns

When building a chert over a clickhouse dataset with nullable columns all columns are listed as just "nullable" without the actual data type.

Expected results
The actual data types - Int, String, Array, etc...
Environment

browser type and version: Chrome
superset version: 1.3.2
clickhouse-alchemy - 0.16

This was solved here using the "get_datatype" enhancement but was never merged to the clickhouse.py, can it be pushed to 1.4?
https://github.com/HeinzMayer/superset/blob/1.0.MIC/superset/db_engine_specs/clickhouse.py

@shreesham if you have time to look into this one, it would be greatly appreciated :)

@andrey-zayats took a look at this and was unable to reproduce the issue. I'm going to go ahead and remove the validation:required label and close the issue. If anyone sees this happening in Superset 2.0.x or later, or on master, we're open to revisiting this conversation, re-opening the ticket, or triaging a new Issue with updated context. Thank you!


Add global site passthrough to ignore pinning

Hi, thanks for this wonderful project.
Following several recent issues, it seems that the current passthrough implementation cannot work with apps that implement pinning, since it only operates once the connection has already been initiated/spoofed.
The sister project sslproxy already implemented a per-domain whitelist that prevents spoofing for defined sites.
I've backported their code to sslsplit.
Note that I don't write C code and do not understand any of the details involved.
This patch compiles and works, and I've tried to retain the code, naming and formatting style.
But it should definitely be reviewed by someone who knows what they are doing (which you obviously are!) before merging.
By the way, if this is inconvenient or does not fit the project's scope, feel free to discard the PR.
Thanks & Regards!

Many thanks for looking at this, @0x501D !
As mentioned in the PR, I barely know that null pointer dereferencing and the like exist, so I can't help, as much as I'd want.
But if you stumble upon serious issues, it might be worth looking at the implementation of https://github.com/sonertari/SSLproxy as well, which is where I lifted the code. Could be interesting to @sonertari as well (author of sslproxy and co-author here)

Yes, I should check possible memory allocation issues in such cases too. But I think @droe may have a more important objection to this code being merged to sslsplit. I have implemented it using a linked list, but there may be more appropriate data structures in this case, such as a type of tree, perhaps tries. Because, the data structure remains constant after we populate it at the start. All we do afterwards is search for a matching string, the target site in current connection.

That makes sense; if it's possible to reduce the per-connection overhead then that would obviously be a good thing. I haven't tested performance with hundreds or thousands of passsites (so there could be pathologies if lookups are log(n) ), but overall sslsplit is so fast that it doesn't seem to matter much, even on rather slow machines.

Just a small update on this.
I've since switched from a simple lookup to suffix matching similar to this code. This allows the whitelisting to work on TLD level if desired, which makes more sense when dealing with pinning. It also has the side effect of reducing the number of entries, since multiple subdomains can now be collated into one single suffix. Performance is still good, although I have yet to run a dedicated benchmark.

Hi @sonertari,
(The usual preamble: This is not an "issue", I don't have an issue with the project and am instead hevily indebted, as all users are, to your continuous work on this. We owe you and Daniel thanks!)
I am indeed primarily interested in second-level suffixes (i.e. *.google.com in your case), which are typically the highest level at which one would apply whitelisting of pinned services. Other examples include *.gvt.com, *.googleapis.com and *.googleusercontent.com for essential google/android services, *.icloud.com and *.mzstatic.com for iOS and so on.
DNS is never this simple, of course, with two-part TLDs such as *.ac.uk, *.co.uk and so on. People might also be interested to specifically whitelist individual third- or fourth-level domains. That's why I think it's best to have a flexible approach that simply compares arbitrary suffixes and lets users pass through entry TLDs if they so choose. By the way, a special use case might be if you have an internal DNS set up with a custom (non-existant) domain (such as .myproduction) - in this case you might want to in fact whitelist the entire TLD.
I have to admit that I didn't try to use wildcard-based matching with your code and instead jumped straight into writing and taking apart the simpler (or stupider) approach in an attempt to get a thorough understanding of what I'm running. So excuse if the suffix matching is merely a re-implementation :)

Thanks @trifle for your comments. No, you are right, my code cannot handle wildcard asterisk. But I was trying to say I have seen very long Common Names in Google (or other) certificates which simply list many subdomains, so that my implementation can match one of them, as if it supports *.google.com. I agree, it would help write fewer rules if we support wildcards in passsite configuration.
(Note on SSLproxy and UTMFW: I am still concerned about user errors that may pass unintended sites through, which would effectively disable deep ssl inspection for those sites.)


State with Vaul

Hello,
first of all, thank you for this great drawer component! I have a question regarding the library when using it with a state, is it possible to continue with the closing animation as it is done at the time of closing it by clicking it out? If I click on the button it closes directly without doing the animation and the styles remain in the body. Here is an example:
https://codesandbox.io/p/sandbox/drawer-with-scale-forked-35cc6n?file=%2Fapp%2Fmy-drawer.tsx%3A28%2C72

I answer myself, using Drawer.Close.

You don't have to conditionally render it btw, thats why it was closing instantly in your example. If you removed the conditional, it would've be removed anyways on close.


[PREGEL] APM-538 Add reporting for loading state observables

Measure number of vertices, number of edges and memory used when loading the graph into pregel.
Measurements of workers are aggregated only when required.

TODO Merge parent first

Successful build:
Windows: https://jenkins.arangodb.biz:3456/job/arangodb-matrix-pr-windows/15103/
All others: https://jenkins.arangodb.biz:3456/view/PR/job/arangodb-matrix-pr/22466/


Structural typing when specifying component props in TSX

TypeScript Version:  2.3.2
Code
type MyComponentProps = {
    name: string;
};

class MyComponent extends React.Component<MyComponentProps, void> {}

class MyClass {
    public name: string;
    public age?: number;
}

const my: MyClass = { name: "Jack", age: 20 };
const props: MyComponentProps = { ...my }; // This works
const c1 = <MyComponent {...my} />; //  error TS2322: Property 'age' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<MyComponent> & Readonly<{ children?: ReactNode; }>...'
const c2 = <MyComponent {...props} />; // This works

@cnshenj thanks for reporting this. This is a duplicate for #15463 ...we have a fix in nightly and will have it for 2.3.3 as well


[7.x] Remove extra code from illuminate/container

Since we do not deal with objects at all, (The wrapped variable can only be an string or an array as documented.) the native php type-casting does the job perfectly, like it is used in many other parts of the class.
I did not see the point to define and use a helper util method for that.
It seems the util is created to decouple the container from array helper class and replace the Arr::wrap

Nothing is broken.

if ($itWorks ) {
    throw new DontTouchItException();
}

😁


[Event Request] page 1007 "Job Planning Lines" - OnAfterSetEditable

Describe the request
Could you please add the following event OnAfterSetEditable and please Include the sender (the Page)?
protected procedure SetEditable(Edit: Boolean)
begin
    PlanningDateEditable := Edit;
    CurrencyDateEditable := Edit;
    DocumentNoEditable := Edit;
    TypeEditable := Edit;
    NoEditable := Edit;
    DescriptionEditable := Edit;
    UnitOfMeasureCodeEditable := Edit;
    VariantCodeEditable := Edit;
    LocationCodeEditable := Edit;
    BinCodeEditable := Edit;
    WorkTypeCodeEditable := Edit;
    UnitPriceEditable := Edit;
    LineDiscountAmountEditable := Edit;
    LineDiscountPctEditable := Edit;
    LineAmountEditable := Edit;
    UnitCostEditable := Edit;
    OnAfterSetEditable(Edit, Rec); //NEW Event
end;

[IntegrationEvent(true, false)]
local procedure OnAfterSetEditable(Edit: Boolean; var JobPlanningLine: Record "Job Planning Line");
begin
end;

Additional context
When we get this event then we can subscribe to this event to disable edit of custom added fields.
Therefore we need the Sender, that we can set Global Variables for Editable of our custom fields via Setter Functions on the PageExtension Object.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13909.


Fix Bug in getTokenFromResponse_ for APIs that Respond with 201 Created

I tried using this library to connecting Google Apps Script and the Medium API, and getTokenFromResponse_ throws an error despite getting a successful response. The function currently throws an error if the response code isn't 200, but successful access token response from Medium have a 201 status code. So I modified that check to throw an error if the status code is outside of the entire 2xx success range.
This PR also includes examples for connecting to Strava and Medium.

I signed it!

Thanks for the fix, and the samples!

No problem. Happy to help out!


CI: Extend externalTrafficPolicy=Local tests

Adds an additional check for NodePort services with externalTrafficPolicy=Local
where only a single node is running a service endpoint. Therefore, we test that
only direct connections to that node will succeed, while any requests to a node
without a local backend are dropped.

This change is

test-focus K8sServicesTest*

test-focus K8sServicesTest*

test-me-please

test-me-please

Added an additional commit that fixes a bug uncovered by the CI test - restoring services from datapath failed to restore (and subsequently garbage collect) services without any backends: 5c5776dd0b3eb5726cf9eafd2176390d1fbb5daa

test-me-please
Edit: Travis seems to completely ignore this PR.

Coverage decreased (-0.02%) to 45.93% when pulling 48a3cb874a3688ee869fa66baae95447d326399d on pr/gandro/ci-improve-external-traffic-policy-tests into 28544349fe327140d61cbad3ff4c77e7ae8a9633 on master.

test-me-please


How to run asynchronous queries via HTTP ? (where to set service accounts ?)

Hello
The adapter works pretty well for synchronous queries. But I am testing to use the robot.router.post method that allow asynchronous queries:
In exemple.coffee:
  robot.router.post '/hubot/chatsecrets/:room', (req, res) ->
    room   = req.params.room
    console.log req.body
    data   = req.body
    secret = data.secret

    robot.messageRoom room, "I have a secret: #{secret}"

    res.send 'OK'

And I have this result:
TypeError: Cannot read property 'thread' of undefined
  at HangoutsChatBot.sendMessage (/home/julien/web/hubot-google-hangouts-chat/src/bot.js:58:34)
  at HangoutsChatBot.send (/home/julien/web/hubot-google)hangouts-chat/src/bot.js:77:10)
  at Robot.messageRoom (/home/julien/web/myhubot/node_modules/hubot/src/robot.js:608:23)
  at /home/julien/web/myhubot/scripts/example.coffee:92:5, <js>:9:13

I assume that using HTTP mode we can only use today synchronous queries (it post data using httpRes sent in the message). Any option to have asynchronous ? :)

Are cards supported when using pub/sub? Cards seem to work fine for webhooks, but I cannot get them to work with msg.send.

Hello,
Asynchronous support has now been added. You will need to use a service account when making asynchronous queries. Please consult our documentation on how to set up a service account:
https://developers.google.com/hangouts/chat/how-tos/integrate-hubot#service_account


fix dec

Hello
I found  io::prometheus::gauge::dec called io::prometheus::internal::Addition with 1, and we should call it with -1, I think

Many thanks for fixing this embarrassing bug!


Can't seem to get this working without explicitly requiring symfony/finder.

I can't seem to get this working without explicitly requiring symfony/finder, is this corrent?

Hmm, this started a laravel only package, which has symphony/finder by default. I've added it to the requirements in the next version!


Requeue rejected messages

Right now all the rejected messages are dropped from the message queue. These changes will allow configuring the gem to perform requeuing on message rejection.
Another option could be to configure the requeuing per handler instead of using a global value. What are your thoughts about these @soulim ?

In the example above I used @handler.send(:requeue?) because a Proc instance could be used as a handler because it implements "interface" and responds to #call method. But it cannot implement #requeue?

Thanks for the feedback @soulim 👍
I agree that the handler option gives more flexibility and it's a good idea to implement it as you described.
Another question, what do you think about keeping both solutions? I think It's possible to implement the "per handler" solution and also provide a global configuration. This will allow gem users to set requeue as the default behaviour at the project level if needed.


Add ability to customize graphql schema with OAS extensions

Hi there 👋
First of all, thanks for the awesome library. We've been using it at @apideck-io with great success!
Recently we forked the repo because we needed granular control over the naming of certain schemas/operations.
It's not always possible to use title fields or similar, since we have other tooling using those as well. We needed a way to customise naming specifically for GraphQL.
We came up with a solution using OpenAPI extensions. We think it could be useful to other users of openapi-to-graphql so we're contributing it back 🎉
Let me know if you're interested in having something like this, otherwise we'll keep it in our fork :smile:
Here's an API spec I used for testing: https://gist.github.com/elsmr/ac35f5dc7dbf7a42e60276f688955640. I also included the graphql schema output before & after.
There's also more features that could be added using this approach, for example a property whitelist for schemas etc.
Cheers

@elsmr Wow! This is an awesome feature! Thank you so much for sharing this and making this available for other users!
Producing consistent names in OtG has been a long-standing issue (#127, #131, #179, #303, #335) so I am glad that we finally have a solution. This change will allow OtG to be much more predictable and usable.

I like the direction that these changes are going but I have some additional concerns.

Naming of fields vs types and args and enum values.

Currently, this change seems to affect both fields and types but I wonder if they should be separated.
Consider this:
{
  "paths": {
    "/cat123": {
      "get": {
        "responses": {
          "200": {
            "content": {
              "application/json": {
                "schema": {
                  "allOf": [
                    {
                      "$ref": "#/components/schemas/pet"
                    },
                    {
                      "x-graphql-field-name": "cat"
                    }
                  ]
                }
              }
            }
          }
        }
      }
    },
    "/dog123": {
      "get": {
        "responses": {
          "200": {
            "content": {
              "application/json": {
                "schema": {
                  "allOf": [
                    {
                      "$ref": "#/components/schemas/pet"
                    },
                    {
                      "x-graphql-field-name": "dog"
                    }
                  ]
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "pet": {
        "type": "object",
        "properties": {
          "petName": {
            "type": "string"
          },
          "favoriteFood": {
            "type": "string"
          }
        },
        "x-graphql-type-name": "dog"
      }
    }
  }
}

By using x-graphql-field-name and x-graphql-type-name extensions, this would ideally produce a dog and cat field, both of type Pet. What do you think about this proposal?
As mentioned previously, creating valid names for all GraphQL components, not just fields and types, has been a recurring problem for OtG. I think we should also consider what kind of precedent this change will have and how can we best design it so we can build off of it in the future. Therefore, we must also think about argument names and enum values.
If I recall correctly, argument names are handled in the same way fields are but I need to check.
Enum values are more complicated however. Perhaps what we need is a new extension like x-graphql-enum-mapping that is a map between existing enum values and proposed GraphQL enum values.

Naming of links

Creating nested objects via link objects is one of OtG's biggest features so we want to make sure that we can control these names as well.
I think there is a relatively straight forward solution if we check for an extension like x-graphql-field-name in a link object.

Naming prioritization, collisions, and error handling

The current behavior seems to use the preexisting name resolution in the case that there is a collision. I wonder if we should do more, like throw an error or even break. I would assume that users would expect that the field name would be changed as desired and if we just silently swallow it, it may lead to some unforeseen consequences.

External configuration

I wonder if we can utilize an external configuration to customize names. Similar to the selectQueryOrMutationField or customResolvers options, I was originally thinking we could do a triply nested object that allows users to map operations to field names however after some more consideration, this seems that limiting. Mapping schemas to type names and enum values will be cumbersome. I need to do some more thinking but an external configuration has its advantages; it's not always practical to manually add the extensions to an OAS and an external configuration can be reused.

We do not necessarily need to resolve all of these points in this PR. In the very minimum, I think we should consider doing x-graphql-field-name and x-graphql-type-name but I am curious if you have any opinions on the other points I brought up.

Happy to hear you like it! Great remarks as well :smile:

Naming of fields vs types and args and enum values.

Not sure I fully understand the example 😅. Is the following schema what you would expect?
type Query {
  cat: Pet
  dog: Pet
}

type Pet {
  favoriteFood: String
  petName: String
}

If yes, you can achieve that in this branch by adding extensions to the schema like I did in this gist.
Still, more specific naming such as x-graphql-type-name and x-graphql-field-name is probably a good idea.
I like your proposal for handling enums 👍
"direction": {
  "type": "string",
  "enum": ["asc", "desc"],
  "x-graphql-enum-mapping": {
    "asc": "ASCENDING",
    "desc": "DESCENDING"
  }
}

Naming of links

Haven't used links before, but just looked into it and that should be pretty straightforward to implement like you said 👍

Naming prioritization, collisions, and error handling

This is probably where this PR still needs a bit of work. I agree that if extension-provided names collide, openapi-to-graphql should throw. Currently it's using the existing logic, trying to avoid collisions by renaming.

External configuration

I don't love this. I feel like the config would be pretty complex because of the nesting. Having the gql names right in the spec is much easier to read because they are right next to the schema they're linked to.
Still if there is a use case for it, I don't see why not but could be separate from this PR :smile:

Is the following schema what you would expect?

Yes, this is what I meant.

If yes, you can achieve that in this branch by adding extensions to the schema like I did in this gist.
Still, more specific naming such as x-graphql-type-name and x-graphql-field-name is probably a good idea.

Ah sorry, I did not realize that there was already this functionality. I think having a x-graphql-type-name and x-graphql-field-name would make things clearer.

I agree that if extension-provided names collide, openapi-to-graphql should throw.

Sounds like a plan.

I feel like the config would be pretty complex because of the nesting.

I agree so I was wondering if we could offer it in a limited fashion where we can only rename top level fields (operations) and types from component schemas. Maybe it's more effort than it's worth and may cause confusion between the external configuration and the extensions.
And agreed, it can always be added in a separate PR.

Are you interested in further working on this PR? If not, then I will take a crack at adding x-graphql-type-name/x-graphql-field-name extensions, link support, and also adding documentation.

Feel free to have a crack at it. Also happy to help out if you want :smile:

@Alan-Cha if you don't have bandwidth to work on this one currently, lmk, I can pick it up 😄

@Alan-Cha Hey there, been a while :smile: I finished up this PR

Added errors for naming conflicts (when x-graphql- is used)
Tests for errors and schema naming
Links x-graphql-field-name

I think this is ready for review, I guess some docs would also be nice, happy to help :smile:

@elsmr This is awesome! Thank you so much!!! I'll try to take a look at this today! Again, this is a fantastic feature!

I know I mentioned that I would take a look at this. I'm going to see if I can do this week. I'm very sorry about the delay.

No worries 😉

Hi @Alan-Cha! Any update on this?

@elsmr Hey! It's finally in! There were still quite a few things I wanted to change and I wasn't able to make any changes to your fork so I had to create my own off of yours. You can see the changes I made here: #399.
I added some docs and refactored a lot of code. Something to note is that I changed the way x-graphql-type-name affects input object types (parameters). Previous, OtG would use x-graphql-type-name for input object types and all other custom types. Currently, we append Input to the end of the name for input object types. This is important because otherwise, we may create types with the same name and that is illegal in GraphQL.
I'm sorry it took so long to review this. I was really struggling to find time to work on OtG with all the other work I had on my hands. Thank you so much for this incredible contribution! I was also very impressed with the test cases. They were very extensive!

@Gdewilde It's in now!

Closed: see #399

Thanks, Alan!
Sent from my iPhone

On 28 May 2021, at 23:34, Alan Cha @.***> wrote:

@Gdewilde It's in now!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Alan-Cha awesome! Thanks for finishing it 😄 happy to see it merged 👏


For #285: verify package attribute on NodeHasPkgCount

For #285: NodeHasPkgCount verify packages attribute

added test checking package attribute to NodeHasPkgCount
added tests to assert correct assertion failure message on NodeHasPkgCount
changed puzzle to continue implementation

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #294   +/-   ##
=========================================
  Coverage     87.04%   87.04%
  Complexity      279      279
=========================================
  Files            43       43
  Lines          1297     1297
  Branches         56       56
=========================================
  Hits           1129     1129
  Misses          158      158
  Partials         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abcac7...c8915e6. Read the comment docs.

This pull request #294 is assigned to @vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@sereshqua/z please review this job completed by @vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@Vatavuk please make sure you will find at least 3 issues during next CR, thanks

@sereshqua ok

@0crat quality acceptable


Question regarding the appropriate license for this project

There is an inconsistency in the license declaration in the README.md. It states, "This work is dual-licensed under the Eclipse Public License v2.0 and Eclipse Distribution License v1.0," but uses a different SPDX-License-Identifier: "EPL-2.0 OR BSD-3-Clause".

It seems that the "Eclipse Distribution License v1.0" is equivalent to the BSD-3 Clause license and uses that SPDX-License-Identifier.
See https://www.eclipse.org/org/documents/edl-v10.php


using rabbitmq

I want to use blockAtlas and I managed to run and connect to trezor nodes, but for subscribing and using rabbitmq there are no docs, code samples, or other information.
please provide some information about subscribing.

Hello you want to subscribe

exactly, I want to subscribe to rabbitMq data.

G

Hello world


Create example of recognizing spikes / drops in data?

e.g. covering up a light sensor, or moving your hand away from it? (vs. a gradual change in the ambient light levels).

This probably depends on #165, support for pipelines with no classifier.

user_sudden_motion can probably be generalized to this spike detection. Haven't got a light sensor to test, but the math seems to be the same.


Add a recipe for banana muffins with chocolate.

I hope it's not too "hyper-sugary." Those are good muffins.

Based recipie from a based man


[QUESTION] How to remove value from history

Hi, thx for greenclip. I use it with rofi, and when I copy very large text, so then the rofi menu starts freeze each time when run it.
How remove a item with large text from greenclip.history?

And how to avoid this? Maybe cut a large string until 1000 symbols?

I think the same thing is happening to me, but it's rofi that freezes the computer.

Hello,
You have this option in the config file, if you want to discard large input max_selection_size_bytes, you need to tweak it to match your machine or put some low value like 1KB


Double-free with into_owner

use std::cell::Cell;

use self_cell::self_cell;

type O = Cell<Option<Box<u8>>>;

self_cell! {
    struct S {
        owner: O,
        #[covariant]
        dependent: D,
    }
}

struct D<'a>(&'a O);

impl Drop for D<'_> {
    fn drop(&mut self) {
        self.0.take();
    }
}

fn main() {
    let s = S::new(Cell::new(Some(Box::new(42))), |o| D(o));
    s.into_owner();
}

    Finished dev [unoptimized + debuginfo] target(s) in 0.00s
     Running `target/debug/small_pg`
thread 'main' panicked at 'explicit panic', src/main.rs:20:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
free(): double free detected in tcache 2
[1]    394203 IOT instruction (core dumped)  cargo r

The underlying problem is
https://github.com/Voultapher/self_cell/blob/ae22d0f26d4a63be3fa9bbfe4c98b7b0246630ea/src/unsafe_self_cell.rs#L90-L96
where the owner is read before dependent is dropped, so dropping dependent can access the original owner, but into_owner returns the copy created beforehand.

I have a branch that fixes this as well as some memory leaks: https://github.com/steffahn/self_cell/compare/fix_drop_order...fix_double_free_and_leaks
The branch is based on #21 (one of the memory leaks is in drop_joined), so I’ll only open a PR after #21 is merged. So consider not to release a new version yet after merging #21 😉

Actually… I just noticed that a panic isn’t necessary in the example (and I edited the example accordingly). So I can split up the double-free issue and the memory leaks and create two separate branches; the first one (the double-free) can already get a PR right now.

Dang, thanks for finding this! Goes to show how hard it is to write unsafe Rust even with the best intentions and code review.


Setting sidqkiq uid/gid via config

Is there any way to set the sidekiq task uid/gid? Thanks.

Hi Kate!
No, unfortunately there's no such option currently. Though, God has support for setting uid/gid of the process. The easiest way would be to make uid + gid additional options in sidekiq_instance.rb (CONFIG_FILE_ATTRIBUTES) and evaluate them in the sidekiq.god script. Another (imho better) option would be to add a config option block that would be instance_eval'd in the god script, so the user could set arbitrary options, instead of us having to make each and every option available through Sidekiq-Runner.
PRs welcome!

Kate, nevermind the block stuff. I just went ahead and added a PR for the easy implementation. Would you be so kind to test this?

Hi,
Many thanks for that I'd literally just forked and was about to do the same thing. I've tested your change and its working fine. Thanks.


add bitwise and, or, negate expressions

Description
This PR adds bitwise operators &, |, ~ to Druid native JSON query expressions.
^ was already taken for power unfortunately, though I would be in favor of reworking it to a function so we can use ^ for xor and find an alternatively way to express the power operation.
SQL support appears to be not possible until https://issues.apache.org/jira/browse/CALCITE-3732 settles, so unfortunately only native JSON queries are supported at this time.
Related to #8560.

This PR has:

[x] been self-reviewed.
[x] added documentation for new or modified features or behaviors.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Key changed/added classes in this PR

expression grammar file
Expr
ExprListenerImpl

SQL support appears to be not possible until https://issues.apache.org/jira/browse/CALCITE-3732 settles, so unfortunately only native JSON queries are supported at this time.

Fwiw, we don't need this to add support in SQL; we can add our own functions without Calcite being aware of them innately.

I would love to see this functionality in druid. Any chance this could be fixed/merged?

closing in favor of #10605


[Proto definition] List with Filter

This PR adds the Proto definitions for ListArtifactRequest with filtering capabilities.
The FilterExpression is composed of a list of single property filters:

TagPropertyFilter
DatasetPropertyFilter
ArtifactPropertyFilter
PartitionPropertyFilter

The client can then concatenate a bunch of the filters together to make an expression. This is useful for cases where lets say we want to get all artifacts with partition: region='SFO' AND tag: name='latest'.
In the future these filters can be used for other entities aside from Artifact. For example ListDatasets and ListPartitions could use the same FilterExpression.
@milohan-lyft suggested that it would be handy to use ListPartitions and filter by some partition key/val pair to get possible values of other partition keys. partition: region='SFO' should return all the possible values for the other partition keys ex., datestamp: [01/01/19, 02/01/19] etc. This would be helpful in the case of a UI/cli  dropdown to help populate partition drop downs as you drill down.

Closing this PR , please see the full implementation in #13 that includes the proto definition


Nullity == nan?

Dumb question (and yes there are those, and yes this is one): is NaN (np.nan) considered a nullity in missingno?
Thanks for the great work on this-- and on other Resident Mario jams!

Short answer: yes.
Longer answer: missingno reads pandas.DataFrame input, and pandas automatically encodes missing data into np.nan (and converts None -> np.nan also). missingno then uses pd.isnull to determine nullity.
I wrote a blog post (partially) on this subject a while ago that ought to be worth reading.

Great-- just wanted to confirm that anything coded to np.nan would be picked up by missingno. Thanks again.


Set SGX_MODE Default

Set SGX_MODE default to SIM. This makes SGX_MODE optional.
Signed-off-by: danintel<EMAIL_ADDRESS>

@manju956: look again. I set SGX_MODE in both Python setup.py files,
examples/common/python/setup.py and examples/enclave_manager/setup.py

@manju956 : look again. I set SGX_MODE in both Python setup.py files,
examples/common/python/setup.py and examples/enclave_manager/setup.py

My bad, missed that file.


Install helm in the build image

make generated-files in SO, now requires helm.

This should fix some CI errors
/cc @matzew


checkov: 3.2.267 -> 3.2.269

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.2.267...3.2.269
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.2.269

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 350317 run on x86_64-linux 1

2 packages built:

checkov
checkov.dist


bump expiry date for How to manage access to your third-party service accounts

Proposed new expiry date

@stephengrier could you give this a quick review and OK the extended date?
Thanks.


Introduce AppSettings based on IOptions aspnetcore feature

@cerginio Please, can you specify what you specifically suggest? I'll be happy for some detail.

Hi @cerginio,
I'll be happy for your help and pull requests! :)
If you have any ideas, please share them with us.
Thank you.

Done on master - #99


Alias RList.transpose/1

Changes

Alias RList.transpose/1 to List.zip/2

Notes

https://github.com/tashirosota/ex-r_enum/issues/13

@mnishiguchi
Thanks for PR！I think this implementation is good！
Now, I work in progress version 0.4.0 in feature/list_ruby.
Please re-open to feature/list_ruby.

@tashirosota

I rebased it on feature/list_ruby branch and force-pushed it.
As for tests, I chose to test specific cases but it could be comparison to Elixir function's outputs like other aliased ones.


Base mixin on BlocBase - allow use it on Cubit

When mixin "on" clausule is changed to be based on BlocBase, it is possible to use it with Cubit as well. Moreover there is no need to be based on Bloc as "EVENT" type parameter is not even used.

I've added example usage as well.

@AnnaVadimovna  Hi, would you like to consider to include into the package? For now we are using our forked version


Add hover and active effects to buttons for enhanced user experience …

…with color change, shadow, and smooth transitions.
Fixes

Fixes #[issue number] by @[issue author]

Description

Technical details

Tests

Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This PR has incomplete information, and looks like it is for an Issue that hasn't moved to status: ready for work
Please see the Contribution Guidelines
Closing for now, please fee free to create a new PR following the above guidelines.


Only mark breakpoints done when api call succeeds

The first part of the TODO is deemed no longer necessary because we
already have our request handle retriest for transient errors.

@ofrobots PTAL.

LGTM.


Autovert option

Hello,
I have few features on my mind.

Autovert - when player makes claim, this function will automatically expands selected region from min to max Y, but it affects just main claim, sub-claims are not affected ('cause of allowing some flags in subareas)

Paying just for surface, not for area - usable with autovert

Selecting by commands - we offer on our server large areas if someone wants to make his big project, but selectin 300x300 area manually is bit nagging and difficult. I imagine this command like: /select X Y Z which will lead to select +X, -X from your position and so on.

More like question - has player to pay for sub-region?

I'm sorry if some of these function are in this plugin, but I'm new to this plugin and I want to make sure.

2D claims are always bedrock to sky in latest. You can use the new /claim command in latest builds with WorldEdit to claim. Use GP's API to do whatever other stuff you want.


Changed to python 3.11 for issue #33

Hi @KanzaAkram , as explained in https://github.com/fossasia/eventyay-tickets/issues/33#issuecomment-1987577424 , we cannot process this PR.
We need to upgrades the dependencies first, to easily test if eventyay-tickets work with Python 3.10+.


FR - Grab pixels based on positions relative to specific windows

It would be nice to be able to get pixels relative to windows rather than the entire screen

We do not have the ability to recognize screens as of yet. I am not sure when it will be done.

This issue has been closed because it has been inactive for > 240 days.
You may reopen this issue if it has been closed in error.


Dynatrace DQL Provider: Implement FetchAnalysisValue function

Currently, the FetchAnalysis function, which is part of the KeptnMetricsProvider interface is not implemented: https://github.com/keptn/lifecycle-toolkit/blob/f10b4470bdc4346e6ccd17fecc92c8bd5675c7e5/metrics-operator/controllers/common/providers/dynatrace/dynatrace_dql.go#L34
The goal of this ticket is to implement this function.
DoD:

[ ] Implemented the function
[ ] Added Unit tests

Hi @bacherfl, can I work on this issue?

Hi @AryanSharma9917, unfortunately, this ticket requires having a Dynatrace API licence to test it, but if you feel like making your hands dirty with some other issue we have new ones under the goodfirstissue tag 🚀


python311Packages.google-cloud-automl: 2.11.4 -> 2.12.0

Changelog: https://github.com/googleapis/google-cloud-python/tree/google-cloud-automl-v2.12.0/packages/google-cloud-automl
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274455 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-automl
python310Packages.google-cloud-automl.dist
python311Packages.google-cloud-automl
python311Packages.google-cloud-automl.dist


[Pricing][Analytics] - Pricing Page Analytics Enhancement

View all text will now have tracking. Also remove code related to legacy pages.
Resolves: https://jira.corp.adobe.com/browse/MWPW-143824
Test URLs:
Before: https://stage--express--adobecom.hlx.page/express/pricing?martech=off
After: https://pricing-table-semantics-fix--express--adobecom.hlx.page/express/pricing?martech=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.12%. Comparing base (f9235e5) to head (0f6e3bd).
Report is 12 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #719      +/-   ##
==========================================
- Coverage   35.14%   35.12%   -0.03%
==========================================
  Files         131      131
  Lines       25506    25513       +7
==========================================
- Hits         8965     8961       -4
- Misses      16541    16552      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Who needs high-quality lip sync - contact me!

I can do lip sync for any character. I reduced the quality to 10 MB in order to upload video. If you are interested, write to me in telegram: The_best_result
https://github.com/numz/sd-wav2lip-uhq/assets/152233811/46a819be-822c-4975-9b36-a1f66774acb1
https://github.com/numz/sd-wav2lip-uhq/assets/152233811/d301efc3-4194-402a-bec4-2d9a058c1ae1
https://github.com/numz/sd-wav2lip-uhq/assets/152233811/fb614449-e3a2-4958-85ba-85ecf0c9fee1

thanks to leave please


Upgrade to TailwindCSS v3

This isn't really complete yet, but I wanted to see if this solution is acceptable before going down the rabbit hole too far.
As @dixpac mentioned in #94, Tailwind 3 removed classic mode and now only builds using JIT. This means there is no officially supported way to generate the whole CSS anymore. However, they do support safe listing classes with patterns. So I figure using the broadest pattern possible (.+) should pretty much safelist everything and give us the whole CSS again.
I still need to figure out a way to verify that there isn't anything missing for some reason and figure out which variants were included by default in v2. I'll do that once I get a thumbs up on the approach.
Resolves #94

@coding-chimp, good idea, certainly only one possible atm.
Let me now when you finish the WIP, so I can test it :)
As for the variants only default for TW 2 are included https://v2.tailwindcss.com/docs/configuring-variants#default-variants-reference, but I guess we should include TW 3 default variants if that doesn't increase the file size too much.

Yeah, I don't think this works like I want it to work. 😔
I updated the config to only use variants enabled in v2 and am already getting a 10.4MB file. It basically generates all the base classes and then duplicates and prefixes all of them for each variant. For one, this means the file is getting a little bloated, but even worse, it does not actually apply the styling associated with the variants. Most variants (hover, focus, etc.) don't have any special styling, but it does break the responsive variant.

We can't support 3.0 with the current approach. The TW team has some ideas on how we can work around it, but we need help from their end.


Feature Request: Prism.highlightAll(text: string): string

I'm currently implementing a node wrapper for prism that takes in an html file as input and passes its content to Prism.highlight. The issue is the file may or may not contain more than one language/code blocks. So the following doesn't work:
#! /usr/bin/env node

import * as fs from "fs";
import * as path from "path";
let Prism = require("prismjs");  // prism isn't typescript friendly just import it

// console.log(prism === undefined && "prism is undefined" || "prism is defined");

// console.log(process.argv.length);
console.log("Args passed:");
process.argv.forEach( arg => console.log(arg));
if (process.argv.length === 2) {
    console.log("Usage: np <path to input.html file> <path to output html file>");
}

// resolve input/output paths
let input = path.resolve(process.argv[3]);
let output = path.resolve(process.argv[4]);

// read input into buffer
let inBuff = fs.readFileSync(input);

// highlight file's content
let outBuff = Prism.highlight(inBuff.toString(), Prism.languages.javascript); //<== limited to only 1 language

Because Prism.highlight limits highlighting to a single language per call it makes using it for what I can only assume to be a common use case difficult. I can iteratively call Prism.highlight for each language needing highlighting, passing it the output from the previous call but in my opinion this use case would be better served having this implemented by Prism itself.
Also it would be advantageous if Prism supported a method that didn't require the caller to pass it any language specifications at all, but rather would identify the languages dynamically as it parses the text input, such as what Prism.highlightAll does for DOM but for the text input instead.

What does your input file contain exactly? HTML?

@Golmote thanks and yes, the file just contains markup, which is produced by showdown. I want to use Prism in a pre-production workflow to produce static markup. As an aside, though, I am really confused by Prism now because the docs say it only targets  blocks but when I feed it markup it is touching everything in the file. I know this isn't related to this issue but I am just wondering about the state of the project now.

@Golmote btw here is the code I developed for my workflow:
#! /usr/bin/env node

import * as fs from "fs";
import * as path from "path";
let Prism = require("prismjs");  // prism isn't typescript friendly just import it

// console.log(process.argv.length);
console.log("Args passed:");
process.argv.forEach( arg => console.log(arg));

/**
 * args:
 *
 * argv[0]: path to node
 * argv[1]: path to this executable
 * argv[2]: path to the input file
 * argv[3]: an array of languages, all as strings
 * argv[4]: path to the output file, which will be overwritten if it exists
 */

// arg validation
if (process.argv.length !== 5) {
    console.log("Usage: np <path to input.html file> [languages[, ...]] <path to output html file>");
    process.exit(1);
}

// resolve input/output paths
let input = path.resolve(process.argv[2]);
let output = path.resolve(process.argv[4]);

// languages requested
let languages: string[] = JSON.parse(process.argv[3]);
console.log("languages requested", languages.length);

// read input into buffer
let inBuff = fs.readFileSync(input);
console.log("input length", inBuff.toString().length + "(bytes)");

// highlight file's content
let highlightedOutput = inBuff.toString();
languages.forEach(language => {
    console.log("highlighting language", language);
    highlightedOutput = Prism.highlight(highlightedOutput, Prism.languages[language]);
});
// highlightedOutput now contains the completed highlighted markup so time to save it to a file
fs.writeFileSync(output, highlightedOutput);

// all done. time to say goodbye!
process.exit(0);

The highlightAll method selects pre/code blocks in the DOM.
The highlight method process the contents of those blocks, one by one. It's meant to process a string of code, not HTML (well, except to highlight markup...).
Prism.highlight('var i = 4', Prism.languages.javascript)
You'll have to make the replacement yourself. Maybe you should use the help of a templating library here.

Thank you @Golmote for the clarification. I looked through the source and now I understand what highlight is actually doing. Obviously it will not satisfy my use case so I am closing out this issue. Thanks again.


Make New Repository visibility default option configurable

Hi, i really would like to have the visibility option (public / private) default to private, is there a way to make it configurable?
Thanks Dirk

I don't think this would need to be configurable, but having it default on private would make more sense, since as opposed to GitHub, GitBucket is more for private projects.

Fixed in #602

Thanks :+1:


Add eigsolve_tol as a keyword argument for the eigensolver

This exposes the Krylov eigensolver tolerance krylov_tol as a keyword argument of the vumps function.

Looks good, thanks! I'll wait for tests to pass and then merge.

Looks like it failed the format test. Let me run JuliaFormatter on this.

I ran JuliaFormatter on the entire directory. Not sure why GitHub's check is failing on src/infinitecanonicalmps.jl

That's strange. I think I've seen that before, and the problem was that the Github CI workflow was using a different version of JuliaFormatter than I was using locally. I see that it is set to use Julia 1.3.0 here:
https://github.com/ITensor/ITensorInfiniteMPS.jl/blob/5b765f1a7a46939251e91f8c5233d0c7e1f4ad02/.github/workflows/format_check.yml#L16
You could try increasing that to Julia 1.7.1 and see if that helps. If that doesn't work than it's not worth spending time on, we can fix it later.

Ok, yes changing the version works. Thanks!


Allow "Issuer" and "Subject" during a verification to be the Distinguished Names "Common Name" Fields of the x509 certificates

Description
Allow "Issuer" and "Subject" during a verification to be the Distinguished Names "Common Name" Fields.
When using a public CA (similar to https://linuxera.org/signing-verifying-container-images-with-cosign-own-pki/), setting extensions to a certificate is not always possible. In this case, using the "Common Name" fields of Subject and Issuer would allow the Issuer and subject to still be verified, but by using "standard" x509 information.
A new CheckOpts could be added UseCommonNames and the CheckCertificatePolicy function could set oidcIssuer to cert.Issuer.CommonName and sans to []string{cert.Subject.CommonName} when the new option is set.

Marking as dup, see https://github.com/sigstore/cosign/issues/2279#issuecomment-1257332381.
In Cosign, we currently expect certificates conform to the Sigstore certificate profile. I'd prefer to see this implemented as an inspect command that lets verifiers apply custom policy checks rather than grow the API. Long-term, we could support more of these options, but would want to do so in a dedicated API for bring-your-own PKI that doesn't conform to the certificate profile.


Update PRIVACY.md

Added tableview in privacy markdown file.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

🤖 Generated by Copilot at 727162e
This change updates the PRIVACY.md file with a table format for the rich data protocol links. It is part of a documentation improvement pull request.

Thanks - the current formatting is fine 🙂


Updated HW1 template and added HW0

Created the .tex template for homework 1.
Also added **/.DS_Store to the .gitignore so I don't end up accidentally pushing any of those.

Second commit creates the hw0 template and modifies hw1 to move its first question into hw0.

Thanks looks good!


fix: use file urls when calling import()

Summary
Fixes #9544.

Test plan
I've tested this on windows. We have an integration test for this, but we only run windows CI with node v12...

Codecov Report

Merging #9558 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #9558   +/-   ##
=======================================
  Coverage   65.04%   65.04%
=======================================
  Files         286      286
  Lines       12123    12123
  Branches     3004     3004
=======================================
  Hits         7885     7885
  Misses       3600     3600
  Partials      638      638

Impacted Files
Coverage Δ

packages/jest-config/src/importMjs.ts
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aef448...ad8d874. Read the comment docs.