Failed to sync device state - 0.9.63

Good morning,
I've experienced an issue with two out of ten cameras since upgrading from 0.9.62 to version 0.9.63. The cameras worked fine on version 0.9.62. Reverting back to 0.9.62 allowed the cameras to connect properly again. It appears something changed between the two versions?
HA - Version: 2024.10.4 - HASS
Dahua Integration Version: 0.9.63
Dahua Camera Version: IPC-HDW4830EM-AS
Dahua Camera FW version: DH_IPC-HX5X3X-Rhea_MultiLang_NP_Stream3_V2.800.0000029.0.R.221220
Any ideas or suggestions would be appreciated. Thanks

INFO (MainThread) [custom_components.dahua] Using max streams 3
INFO (MainThread) [custom_components.dahua] Using channel number 1
INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
INFO (MainThread) [custom_components.dahua] Device is a floodlight=False
INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
INFO (Thread-49) [custom_components.dahua] Starting DahuaEventThread
INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
WARNING (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>. See README to enable debug logs to get full exception

Debug
2024-11-02 08:22:53.854 WARNING (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>. See README to enable debug logs to get full exception
2024-11-02 08:22:53.854 DEBUG (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>
Traceback (most recent call last):
File "/config/custom_components/dahua/__init__.py", line 339, in _async_update_data
light_v2 = await self.client.async_get_lighting_v2()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dahua/client.py", line 178, in async_get_lighting_v2
return await self.get(url)
^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dahua/client.py", line 789, in get
raise exception
File "/config/custom_components/dahua/client.py", line 772, in get
response.raise_for_status()
File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1121, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url='http://<IP_ADDRESS>/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2'
2024-11-02 08:22:53.856 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 6.906 seconds (success: False)
2024-11-02 08:22:53.963 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.232 seconds (success: True)
2024-11-02 08:22:54.081 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.163 seconds (success: True)
2024-11-02 08:22:54.107 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.361 seconds (success: True)
2024-11-02 08:22:54.135 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.197 seconds (success: True)
2024-11-02 08:22:54.159 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.169 seconds (success: True)
2024-11-02 08:22:54.397 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.267 seconds (success: True)
2024-11-02 08:22:59.672 INFO (MainThread) [custom_components.dahua] Using max streams 3
2024-11-02 08:23:01.869 INFO (MainThread) [custom_components.dahua] Using channel number 1
2024-11-02 08:23:02.048 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2024-11-02 08:23:02.221 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 08:23:02.221 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
2024-11-02 08:23:02.848 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=SmartMotionDetect
2024-11-02 08:23:02.848 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
2024-11-02 08:23:02.848 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2024-11-02 08:23:02.849 INFO (MainThread) [custom_components.dahua] Device is a floodlight=False

I am having the same issue and rolled back to 0.9.60 which works fine

Thanks, checking it out.

.93 only included this fix https://github.com/rroller/dahua/pull/408
Are you sure you are on the latest eversion of HA? I'm using 2024.10.4 and .93 of the Dahua integration and don't have an issue.
I'm trying to think of why you'd be getting a Bad Request but it's hard without being able to reproduce it

Hi,
Yes, I am using the latest version of HA (2024.10.4) along with the Dahua integration (0.9.64). I tried adding one of these cameras in my lab environment, and this is what I received in the log when adding the camera with version 0.9.62 (working) and version 0.9.64 (not working).
As I mentioned previously, the error only occurs when adding the IPC-HDW4830EM-AS cameras.
Version 0.9.62
2024-11-02 13:47:37.513 INFO (MainThread) [custom_components.dahua] Using max streams 3
2024-11-02 13:47:39.744 INFO (MainThread) [custom_components.dahua] Using channel number 1
2024-11-02 13:47:39.873 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2024-11-02 13:47:40.029 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 13:47:40.029 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
2024-11-02 13:47:40.810 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=SmartMotionDetect
2024-11-02 13:47:40.810 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
2024-11-02 13:47:40.810 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2024-11-02 13:47:40.810 INFO (MainThread) [custom_components.dahua] Device is a floodlight=False
2024-11-02 13:47:41.456 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
2024-11-02 13:47:41.456 INFO (Thread-5) [custom_components.dahua] Starting DahuaEventThread
2024-11-02 13:47:42.176 INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
2024-11-02 13:47:43.037 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 5.941 seconds (success: True)
2024-11-02 13:47:43.037 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up dahua.binary_sensor
2024-11-02 13:47:43.038 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_motion_alarm
2024-11-02 13:47:43.040 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_cross_line_alarm
2024-11-02 13:47:43.041 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_alarm_local
2024-11-02 13:47:43.044 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_video_loss
2024-11-02 13:47:43.046 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_video_blind
2024-11-02 13:47:43.047 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_audio_mutation
2024-11-02 13:47:43.049 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_cross_region_detection
2024-11-02 13:47:43.051 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_smart_motion_human
2024-11-02 13:47:43.053 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.dahua entity: binary_sensor.walkway_smart_motion_vehicle
2024-11-02 13:47:43.058 INFO (MainThread) [homeassistant.components.switch] Setting up dahua.switch
2024-11-02 13:47:44.857 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 13:47:44.857 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new switch.dahua entity: switch.walkway_motion_detection
2024-11-02 13:47:44.861 INFO (MainThread) [homeassistant.components.light] Setting up dahua.light
2024-11-02 13:47:44.862 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new light.dahua entity: light.walkway_infrared
2024-11-02 13:47:44.865 INFO (MainThread) [homeassistant.components.camera] Setting up dahua.camera
2024-11-02 13:47:44.865 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new camera.dahua entity: camera.walkway_main
2024-11-02 13:47:44.868 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new camera.dahua entity: camera.walkway_sub
2024-11-02 13:47:44.872 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new camera.dahua entity: camera.walkway_sub_2
2024-11-02 13:47:44.875 INFO (MainThread) [homeassistant.components.select] Setting up dahua.select

Version 0.9.64
2024-11-02 13:35:57.460 INFO (MainThread) [custom_components.dahua] Using max streams 3
2024-11-02 13:35:59.501 INFO (MainThread) [custom_components.dahua] Using channel number 1
2024-11-02 13:35:59.781 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2024-11-02 13:35:59.950 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 13:35:59.950 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
2024-11-02 13:36:00.556 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=SmartMotionDetect
2024-11-02 13:36:00.556 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
2024-11-02 13:36:00.557 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2024-11-02 13:36:00.557 INFO (MainThread) [custom_components.dahua] Device is a floodlight=False
2024-11-02 13:36:01.209 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
2024-11-02 13:36:01.209 INFO (Thread-3) [custom_components.dahua] Starting DahuaEventThread
2024-11-02 13:36:01.917 INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
2024-11-02 13:36:03.466 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2
2024-11-02 13:36:03.466 WARNING (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>. See README to enable debug logs to get full exception
2024-11-02 13:36:03.466 DEBUG (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>
Traceback (most recent call last):
File "/config/custom_components/dahua/__init__.py", line 340, in _async_update_data
light_v2 = await self.client.async_get_lighting_v2()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dahua/client.py", line 178, in async_get_lighting_v2
return await self.get(url)
^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dahua/client.py", line 812, in get
raise exception
File "/config/custom_components/dahua/client.py", line 795, in get
response.raise_for_status()
File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1121, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url='http://<IP_ADDRESS>/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2'
2024-11-02 13:36:03.469 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 6.214 seconds (success: False)
2024-11-02 13:36:08.753 INFO (MainThread) [custom_components.dahua] Using max streams 3
2024-11-02 13:36:11.124 INFO (MainThread) [custom_components.dahua] Using channel number 1
2024-11-02 13:36:11.254 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2024-11-02 13:36:11.418 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 13:36:11.419 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
2024-11-02 13:36:12.062 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=SmartMotionDetect
2024-11-02 13:36:12.062 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
2024-11-02 13:36:12.062 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2024-11-02 13:36:12.062 INFO (MainThread) [custom_components.dahua] Device is a floodlight=False
2024-11-02 13:36:12.872 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
2024-11-02 13:36:12.872 INFO (Thread-5) [custom_components.dahua] Starting DahuaEventThread
2024-11-02 13:36:13.735 INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
2024-11-02 13:36:15.460 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2

Similar issue for me, unsure if it started with .63 or .64:  This one camera no longer connects, but the other two have no problems.
2024-11-02 13:47:11.720 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2
2024-11-02 13:47:11.720 WARNING (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>. See README to enable debug logs to get full exception
2024-11-02 13:47:11.721 DEBUG (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>
Traceback (most recent call last):
  File "/config/custom_components/dahua/__init__.py", line 340, in _async_update_data
    light_v2 = await self.client.async_get_lighting_v2()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/dahua/client.py", line 178, in async_get_lighting_v2
    return await self.get(url)
           ^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/dahua/client.py", line 812, in get
    raise exception
  File "/config/custom_components/dahua/client.py", line 795, in get
    response.raise_for_status()
  File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1121, in raise_for_status
    raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url='http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2'
2024-11-02 13:47:11.723 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.737 seconds (success: False)

2024-11-02 13:46:26.650 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 1.841 seconds (success: True)
2024-11-02 13:46:30.146 INFO (MainThread) [custom_components.dahua] Using max streams 3
2024-11-02 13:46:30.345 INFO (MainThread) [custom_components.dahua] Using channel number 1
2024-11-02 13:46:30.390 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2024-11-02 13:46:30.448 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=DisableLinkage
2024-11-02 13:46:30.448 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=False
2024-11-02 13:46:30.504 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=SmartMotionDetect
2024-11-02 13:46:30.504 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=False
2024-11-02 13:46:30.505 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2024-11-02 13:46:30.505 INFO (MainThread) [custom_components.dahua] Device is a floodlight=False
2024-11-02 13:46:30.560 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
2024-11-02 13:46:30.561 INFO (Thread-52) [custom_components.dahua] Starting DahuaEventThread
2024-11-02 13:46:30.646 INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
2024-11-02 13:46:30.847 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2
2024-11-02 13:46:30.848 WARNING (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>. See README to enable debug logs to get full exception
2024-11-02 13:46:30.848 DEBUG (MainThread) [custom_components.dahua] Failed to sync device state for <IP_ADDRESS>
Traceback (most recent call last):
  File "/config/custom_components/dahua/__init__.py", line 340, in _async_update_data
    light_v2 = await self.client.async_get_lighting_v2()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/dahua/client.py", line 178, in async_get_lighting_v2
    return await self.get(url)
           ^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/dahua/client.py", line 812, in get
    raise exception
  File "/config/custom_components/dahua/client.py", line 795, in get
    response.raise_for_status()
  File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1121, in raise_for_status
    raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url='http://<IP_ADDRESS>:16160/cgi-bin/configManager.cgi?action=getConfig&name=Lighting_V2'
2024-11-02 13:46:30.849 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 0.750 seconds (success: False)

Can you both revert down to find the specific version things break on?

To me it seems like 0.9.63, but I don't understand how that would only impact some cameras and not all

When updating from 0.9.62 to 0.9.63.

Works on .62 but not .63

Here are the relevant changes going from .62 to .63

https://github.com/rroller/dahua/commit/52adba8f38c710efdce361f5e189cff75e1c8919
https://github.com/rroller/dahua/commit/b49610762a91217c8053c9d2d048ee2338b0c0ee

Do you see how either of these could impact your specific cameras?

My camera model is IP8M-2496E  ...

likely related. I'll revert that change

... but I have two others that work fine.  They are models IP8M-T2669E-AI and IP8M-2779E-AI

The following change is causing the problem:
52adba8
The two cameras experiencing issues are Amcrest models IP8M-T2499E, flashed with Dahua firmware version DH_IPC-HX5X3X-Rhea_MultiLang_NP_Stream3_V2.800.0000029.0.R.221220 for camera model IPC-HDW4830EM-AS. This may be why the cameras aren’t connecting properly. When I remove or self.model.startswith("IP8M"), everything works fine on version .64.

Reverted in https://github.com/rroller/dahua/releases/tag/0.9.65

Thank @rroller

I also have one IP8M-T2599E which is connecting without issues on .64.

.65 fixed it.  Thank you sir.

Confirm .65 fixed it for me as well. Thank you.

.65 is not working for me. Same issue as https://github.com/rroller/dahua/issues/411.
I have 4 cameras on an nvr and they fail the initialisation. Goes into an initialisation loop and keep failing.

The identical has happened here with multiple cameras since 0.9.63. 0.9.62 is the last version where they all worked.
Since 0.9.63 version and up, had one or more Amcrest cameras keep failing sync. In 0.9.66, it has finally reduced to only 1 camera which fails; An Amcrest IP8M-DT3949EW-3AI with Firmware: 2.840.00AC001.0.R, build:2022-10-19.
Restoring to 0.9.62 fixes it and restores all functionality.
Issue is identical, so I didn't want to file a new issue.

I have the same problem with cameras from my XVR, even with version 0.9.66. It all works fine with version 0.9.62. I have two IP cameras one is IPC-HDW4231EM-ASE, the other is IPC-HFW1320S-W and they work fine with all versions, but the 3 cameras from my XVR don't. The model of the XVR is XVR5108C-X

Exact same problem with my DVR.  Rolled back to 0.9.62 and it is working...


When terminating because a subprocess failed, don't print error: fatalError

We already have a way to say "a subprocess failed", use it. Fixes rdar://121627384.

@swift-ci please test

@swift-ci please test windows


Needs Updating?

Trying to follow your tutorials but getting:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "6.10.3".
error Found incompatible module
my node -v is 9.5.0

had to change this in package.json.
From:
"engines": {
"node": "6.10.3"
},
To:
"engines": {
"node": "9.5.0"
},

Thanks for letting us know. Added a "node": ">=6.10.3" so anything above 6 works also.


every action return Action not allowed

This is normal for demo account.
Demo account has full access to admin interface just for demo purpose, but no modification allowed.
This is possible by specific "Full Backoffice access" permission which unlock full Admin IHM access only, but server-side actions stay protected.


Enable multiline support for logs statements in Filebeat

For DE services we would like to be able to have multiline ingestion of log statements into Elasticsearch 'out of the box'.  Currently, the Docker Filebeat configuration is not set up to specify a multiline properties.  We've worked around this by manually setting the following configuration in the filebeat.yml for each K8s node.
For each K8s node we did the following.

SSH into the node (See the Environments page for instructions and IP addresses)

Edit the Filebeat configuration file to add the appropriate filebeat configuration:
sudo vim /etc/filebeat/filebeat.yml
Add the following bold lines in the location shown below.  Be careful of indentation (this is a YAML file)
- type: docker
enabled: true
containers.ids: "*"
multiline.pattern: '([12]\d{3}[- \/.](0[1-9]|1[0-2])[- \/.](0[1-9]|[12]\d|3[01]))|(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.]\d\d'
multiline.negate: true
multiline.match: after
processors:

Restart filebeat:
sudo service filebeat restart

Update:  The multiline pattern that we are currently using is actually:
multiline.pattern: '([12]\d{3}- /.- /.)|(0[1-9]|1[012])- /.[- /.]\d\d'

Removed link to internal company documentation.

@tim-gates: What do you think about making such options configurable? Then you would specify your own options in settings according to filebeat documentation? https://www.elastic.co/guide/en/beats/filebeat/current/multiline-examples.html
We can also setup such options for other components.

@erzetpe I think that is OK, as long as it can be done during the Epiphany install/config.

Yes, this is our intent. Thank you for the information.

There is a bug to be fixed: [BUG] Filebeat multiline support - truncated single quotes in the regular expression pattern

Tested as part of #1669.


Np 3321/fixing columns not being visible

I don't think we need to filter networkTransient properties out as some of them are just set on front end

Removing networkTransient: would this not allow selection/viewing of these properties on the client even though they could not get server data?  So an expectation to export but it would not be useful?

Removing networkTransient: would this not allow selection/viewing of these properties on the client even though they could not get server data?  So an expectation to export but it would not be useful?


[5.0] Get table columns under Sqlite

Hello, there is a problem with the function getColumnListing under sqlite
I am using Sqlite and i am trying to get the table columns, here is what i am doing
DB::connection()->getSchemaBuilder()->getColumnListing($table);

I get an error
QueryException in Connection.php line 613: SQLSTATE[HY000]: General error: 1 near "show": syntax error (SQL: show columns from testing6_com_comments)

Error output
 in Connection.php line 613
at Connection->runQueryCallback(' show columns from testing6_com_comments ', array(), object(Closure)) in Connection.php line 569
at Connection->run(' show columns from testing6_com_comments ', array(), object(Closure)) in Connection.php line 292
at Connection->select(' show columns from testing6_com_comments ')
at call_user_func_array(array(object(SQLiteConnection), 'select'), array(' show columns from testing6_com_comments ')) in DatabaseManager.php line 304
at DatabaseManager->__call('select', array(' show columns from testing6_com_comments ')) in Facade.php line 210
at DatabaseManager->select(' show columns from testing6_com_comments ') in Facade.php line 210
at Facade::__callStatic('select', array(' show columns from testing6_com_comments ')) in Database.php line 652
at DB::select(' show columns from testing6_com_comments ') in Database.php line 652

My db config file is the following:
<?php return array (
  'fetch' => 8,
  'default' => 'sqlite',
  'connections' =>
  array (
    'sqlite' =>
    array (
      'driver' => 'sqlite',
      'database' => 'C:\\xampp\\htdocs\\l5/storage/database.sqlite',
      'prefix' => 'testing6_com_',
      'host' => '',
      'username' => '1',
      'password' => '1',
    ),
    'mysql' =>
    array (
      'driver' => 'mysql',
      'host' => 'localhost',
      'database' => 'forge',
      'username' => 'forge',
      'password' => '',
      'charset' => 'utf8',
      'collation' => 'utf8_unicode_ci',
      'prefix' => '',
    ),
    'pgsql' =>
    array (
      'driver' => 'pgsql',
      'host' => 'localhost',
      'database' => 'forge',
      'username' => 'forge',
      'password' => '',
      'charset' => 'utf8',
      'prefix' => '',
      'schema' => 'public',
    ),
    'sqlsrv' =>
    array (
      'driver' => 'sqlsrv',
      'host' => 'localhost',
      'database' => 'forge',
      'username' => 'forge',
      'password' => '',
      'prefix' => '',
    ),
  ),
  'migrations' => 'migrations',
  'redis' =>
  array (
    'cluster' => false,
    'default' =>
    array (
      'host' => '<IP_ADDRESS>',
      'port' => 6379,
      'database' => 0,
    ),
  ),
);

I have this table and its columns.
Solution is here http://stackoverflow.com/questions/947215/how-to-get-a-list-of-column-names-on-sqlite3-iphone
I just don't know where to put the code for sqlite. The code for sqlite should be
PRAGMA table_info(table_name); instead of show columns from ....

Laravel version?

5.0

I don't think you're using the connection you think. I'm looking at the Sqlite Grammar and it's ok:
https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php#L41
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php#L41
Check with
DB::connection('sqlite')->getSchemaBuilder()->getColumnListing($table);

to make sure you're connecting to sqlite (it looks like you're connecting to mysql)

Hi i have 'default' => 'sqlite' set in my config

Have you tried using the latest laravel dev release?

what does it return when you do dump($db_driver);

Closing this issue for now


EmbedBuilder#addField documents @Nullable params, but can't take nulls

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

A MessageEmbed I was building threw an exception because I passed a null value to a field. I thought it would be okay to do this, since the fields are explicitly marked Nullable. The docs for EmbedBuilder#addField specifically say it'll throw if you pass null to either the name or the value
Shouldn't they be Nonnull?

https://github.com/DV8FromTheWorld/JDA/blob/master/src/main/java/net/dv8tion/jda/api/EmbedBuilder.java#L774

If only name or value is set


upgrade chart versions

change jenkins-x/jenkins-x-platform to version 0.0.3717
change jenkins-x/jx-build-templates to version 0.0.544
change jenkins-x/prow to version 0.0.441

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jstrachan
If they are not already assigned, you can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test tekton


Add warning about possible N+1s

This PR adds a Drawbacks section in the Readme file
warning about possible N+1s and how to solve them.
This comes from #186.

Feel free to modify whatever you want! 😄

Perfect! Thanks @mrcasals :D


[9.x] Add support for native rename/drop column commands

Related to #45254
Currently it is required to install doctrine/dbal to be able to rename a column on all databases and drop a column on SQLite.
But all databases now have native support for renaming and dropping columns on their latest versions:

Database
Supported version on Laravel
Native rename column support
Native drop column support

MariaDB
10.3+
10.5.2+ (Docs)
✓

MySQL
5.7+
8.0+ (Docs)
✓

PostgreSQL
10.0+
✓ (Docs)
✓

SQLite
3.8.8+
3.25.0+ (Docs) (Release logs)
3.35.0+ (Docs) (Release logs)

SQL Server
2017+
✓ (Docs)
✓

This PR adds support for native rename column command on all databases and drop column command on SQLite without any breaking changes.
This means if a user has already installed doctrine/dbal, they see no change, but for those users with a database version that supports native rename/drop column commands (as listed on the above table) there is no need to install doctrine/dbal anymore.
But what if I have already installed doctrine/dbal and still want to use the native rename/drop column commands?
This PR adds a new static method to Schema facade, Schema::useNativeSchemaOperationsIfPossible(). For example if you have already installed doctrine/dbal library but you don't want to use Doctrine for renaming/dropping columns you may call Schema::useNativeSchemaOperationsIfPossible() method within the boot method of your App\Providers\AppServiceProvider class (we already have similar methods like this one) or maybe inside your migration files directly.
Finally, this PR causes Laravel to support native rename/drop column commands and sees the usage of doctrine\dbal as a workaround for users that prefer Doctrine or have an old DB version.
PS1: I'll send a PR to add/edit Laravel docs if it merged.
PS2: I'll send a PR with the same approach for changing/modifying columns if this one merged.

Thank you @driesvints, You are right, I agree that it's compilated now, but I think just checking if DBAL is installed or not is not enough, we would need some kind of config for that. do you have any suggestion?
For example we currently force user to install doctrine/dbal to be able to use artisan model:show command (Although I think it's not necessary) but when user agrees to install this package, it would cause different behavior on compiling migration commands.

it would cause different behavior on compiling migration commands.

Are you saying the behavior between using DBAL and native commands is different? If so then I think we might better hold off with this entire PR since it would be too much of a breaking change for many users. I don't think that the Schema::useDoctrineToDropColumns etc is the way forward.

@driesvints it would be different behavior (breaking change) if I apply your suggestion into this PR:

I'd make the behavior so it detects if DBAL is installed and use that and if not that it uses the native column renaming and dropping.

What am I saying that is we need a switch/config instead of Schema::useDoctrineToRenameColumns or Schema::useDoctrineToDropColumns. For example I can simplify that to Schema::useDoctrine, is it better you think?

@driesvints This PR, as is, is not a breaking change at all.
I was explaining that it would be a breaking change IF I apply your suggestion and remove Schema::useDoctrineToRenameColumns or Schema::useDoctrineToDropColumns from this PR.

I just merged Schema::useDoctrineToRenameColumns and Schema::useDoctrineToDropColumns into one negated method Schema::preventDoctrineUsageIfPossible.

@hafezdivandari but I don't think Dries or I understand WHY it is a breaking change to remove those configuration methods.
Just use Doctrine if it is installed and use the native methods if Doctrine is not installed. Why is that a breaking change? Please explain.

@taylorotwell I think I was wrong using the term "braking change" here, we might see that as an "unexpected behavior". Assume this scenario after this PR, for example on MySQL 8.0:

I run migrations to rename a column (it compiles to native rename command as expected).
After a while I install DBAL, for example to be able to use artisan model:show.
I run migrations again (this time it compiles to a different query using DBAL or even an exception e.g. if there are 2 renames)
I have no way to get the previous migration without that config method. Isn't this an unexpected behavior?

I added that config method on schema for user to be able to control these situations regardless of DBAL availability.
I'm sorry for the confusion, please let me know if you prefer this PR without any config method.

But the migrations will already have run? You won't run migrations twice.

@driesvints I agree but you once said: https://github.com/laravel/framework/pull/44101#issuecomment-1245431357

Won't this change the behavior for apps who have already run their migrations in production?
Their migrations which are part of their app will still be run in development. If they run them in development after this PR is merged, their development databases will be out if sync with production.

A Doctrine rename could be "different" than a native one since on SQLite I'm pretty sure Doctrine drops the column and re-adds it with a new name after storing the data in a temporary table?
The final outcome should be the same but the road taken to get there is different. Is that what you mean @hafezdivandari?

@driesvints @taylorotwell

Why would there be two renames? What exception would occur?

Doctrine can not handle multiple rename/drop, check this tests please but SQLite has no problem with multiple native rename/drop: https://github.com/laravel/framework/blob/26c476db8aed75dbe390fd43ea84fa9a08a97691/tests/Database/DatabaseSchemaBlueprintIntegrationTest.php#L465-L506

A Doctrine rename could be "different" than a native one since on SQLite I'm pretty sure Doctrine drops the column and re-adds it with a new name after storing the data in a temporary table?

Yes, exactly, and also on MySQL the doctrine renames column using alter table change column instead of alter table rename column that causes this issue: #45254
Finally is it that bad to use a single config method to control such behavior changes? We are using many config methods on Eloquent Model for example.

Renamed to useNativeSchemaOperationsIfPossible.

Sorry, could u please elaborate further, what means 10.0- version for Rename column support for postgres? Does that mean what i can rename natively without doctrine only for version 10.0 and below? Kinda confused here

@EdgarSedov sorry for confusion, I wanted to declare that the PostgeSQL and SQL server support native renaming even before that version. It was just a simple comparison to current supported DB version on Laravel. It's corrected now.
As stated on the updated Laravel docs on renaming columns you  won't need to install DBAL on PostgreSQL at all.

Will this change also fix those long-standing issues with renaming columns when an enum column is present in the table? https://github.com/laravel/framework/issues/1186

@hafezdivandari in this case I guess the same code can be reused in some other places were the enum issue still persists (like db:show command etc.)

@IP-Developer True. I'm working on it, waiting for this to be reviewed #45598 as a prerequisite.

@hafezdivandari those are good news for the Laravel community :) Thanks for your work


AwaitExpression not implemented

When I use sval on a module using await, I get an error that AwaitExpression isn't implemented. I'm using sval 0.5.2 from npm.

Could give a minimal code piece for me to reproduce this bug?


Error: missing binding predictions

Hi, I was running several of my VCF files generated by GATK haplotypeCaller from multiple samples. However, only on VCF file occurred following errors. Could you please tell me what's wrong with this file? Thank you!
Traceback (most recent call last):
File "/Users/kevinma/anaconda/bin/topiary", line 58, in
main(args)
File "/Users/kevinma/anaconda/bin/topiary", line 43, in main
epitopes = predict_epitopes_from_args(args)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/topiary/predict_epitopes.py", line 294, in predict_epitopes_from_args
raise_on_variant_effect_error=not args.skip_variant_errors)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/topiary/predict_epitopes.py", line 261, in predict_epitopes_from_variants
wildtype_ligandome_dict=wildtype_ligandome_dict)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/topiary/predict_epitopes.py", line 157, in predict_epitopes_from_mutation_effects
binding_predictions = mhc_model.predict(protein_subsequences)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/mhctools/base_predictor.py", line 225, in predict
return self.predict_subsequences(sequence_dict, peptide_lengths=None)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/mhctools/base_predictor.py", line 207, in predict_subsequences
binding_predictions = self.predict_peptides(peptide_list)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/mhctools/base_commandline_predictor.py", line 332, in predict_peptides
alleles=self.alleles)
File "/Users/kevinma/anaconda/lib/python3.5/site-packages/mhctools/base_predictor.py", line 143, in _check_results
len(missing), example_peptide, example_allele))
ValueError: Missing 32 binding predictions, example peptide='UGTTVRDCTQM' allele='HLA-A*02:06'
Kevin

Hi Kevin,
I think the problem is that we're hitting on stretches of the reference proteome with non-canonical amino acids. In the error you pasted, example peptide starts with "U", which is selenocysteine. We should handle this case more gracefully but I'm not actually sure what the best behavior would be (since none of the underlying predictors support non-canonical amino acids).
@tavinathanson @julia326 @timodonnell -- opinions?

That seems reasonable to me @iskandr

Hey Alex; I am running into the same problem with some samples I'm running now (non-canonical amino acids) and it's causing the sample to fail. Is there a way to avoid these? I have the --skip-variant-errors flag set, but the pipeline exits with no output as soon as it runs into this case.


Narrower number type inference

Infer narrowest possible numeric types from number literals:
var x = 3;   // infer 'int'
var y = 3.14;   // infer 'finite'
var z = NaN;  // infer 'number'

This will be particularly effective once #6 is done.

I'm gonna pick this one up.


Flex width positive feedback.

I encountered some bug while using react-slick with flex boxes.

<Slider {...settings}>
            {caruselItems}
          </Slider>

@@@

First of all that does not fit into screen and if we try to rezise it width grows to infinity. I think that flexboxes and react-slick both dynamically calculate its sizes so it create positive feedback.
Maybe there is some common way to deal with that as there are other react components that dynamically calculate their sizes, so there should be a way to use them with flex boxes, but unfortunatelly I don't know it =(
By the way thanks for this awesome project, best react carusel I have found so far!

I am experiencing this same issue.  Any work around found?

+1
I encountered an issue when placing the Slider into a flex with horizontal flow. Didn't find a workaround.

I also had this bug. So brutal.

Solution to this problem is mentioned in
https://github.com/kenwheeler/slick/issues/982
its working with the css fix mention in above link. Check the demo
https://jsfiddle.net/kirana/wabv7wLj/


Deleting verified users

Users should also be able to be deleted, even if they have already been verified and have entries in the database. Before a user can be deleted, his credit must be balanced. This can be done automatically by entering positive or negative credits in a new "Loss/Profit" table. At the same time all references for this user have to be deleted.

A difficulty here is when the user is an administrator or once was. In this case, all actions that required the permissions of an administrator and were performed by the user to be deleted must first be migrated to a new, active administrator before deletion. The administrator must receive a list of all actions and confirm that he wants to take them over. Only then can the administrator rights be withdrawn from the user and he can also be deleted like a normal user.


Definition request - 'employee role'

I'd like to use OMRSE's 'employee role' in Apollo-SV, however the class currently is undefined. As such, I'd like to propose the following definition for it:
"A human role within an organization that is realized when the bearer participates in some process of employment and in which the organization is the bearer of some employer role."

Perhaps we can try to define what it means to participate in a process of employment in order to avoid circularity or a vague definition. Here are some initial thoughts.
Money or remuneration of some kind is involved, i.e., the employee is paid by the employer. This is in exchange for services, and as such involves a plan specification.
How about "A human role within an organization that is realized when the bearer provides labour or services in exchange for a wage or salary and in which the employer is the bearer of an employer role."
Or we can create a class for employment process and define it along the following lines.
"A planned process in which an the bearer of an employer role provides wages or salary to the bearer of an employee roll in fullfillment of some contract."

This is essentially the same way we define it in SDGIO, adapted somewhat from eagle-i.
I didn't like their use of 'occupation' or 'earns living'.
We define employee role=
A role that inheres in a person and is realized by performing actions specified by an employer in return for remuneration.
employment process =
A planned process wherein an employee performs actions that are specified by an employer in return of remuneration.
We don't specify the organization or contractual side because in some contexts, people are employed informally, or by individuals, or self-employed, possibly without the standard protections and agreements that come from formal employment contracts.
It would be good to coordinate. No need to have two (or more) ontologies with functionally identical classes, but different IRIs. Pretty sure we would be ok with importing from OMRSE, but we need to allow for informal employment as well. Although, this class is more general than the medical domain. Are there plans for extracting "up" some entities into a generic social ontology? Know anybody working on that ;-)

"We don't specify the organization or contractual side because in some contexts, people are employed informally, or by individuals, or self-employed, possibly without the standard protections and agreements that come from formal employment contracts."
I definitely see the need for a non-contractual form. For example, we needed this class for epidemic modeling. It is certainly the case that a person need not have a contract with an employer in order to spread disease in a workplace. We can certainly make it neutral with respect to that.
Yes, let's coordinate! I like your definitions. I'm ok with housing them in either ontology.
There are no plans on our side to abstract up a level. TBH I have been playing the logic card and telling myself that "medically related" doesn't mean "non-medically unrelated", which is just to say, I see your point, but I'm not sure how much of a problem it is. I go back and forth.

Agreed; I like those definitions, as well!

Mark, what are next steps on coordinating with this?

@mark-jensen, are you still interested in coordinating with this?

a role in human social processes that is realized when the bearer provides labour or services in exchange for a wage or salary as specified by some declaration

Is now a subclass of "role in human social process" with the following definition.
a role in human social processes that is realized when the bearer provides labour or services in exchange for a wage or salary as specified by some declaration


How can I trim the string value in ajv?

What version of Ajv are you using? Does the issue happen if you use the latest version?
ajv version: 5.1.0
Usualy I validate the http post body with ajv, But when a string param start with space character, I'm unexpected to pass the validation, example:
let body = {
    title: '    xx'
};

let validator = ajv.compile({
    properties: {
        title: {
            type: 'string',
            minLength: 5,
            manLength: 50,
        }
    }
});

console.log(validator(body));  //true   , unexpected

See transform in ajv-keywords. It's out of scope here.


[Feature #29] Battle Prediction

resolved #29
It will show HP before and after battle with abyssal ships sunk.

It can be switched off by unchecking the option Battle Prediction (It was Battle Environment before).

PS: this works in both sortie and PvP
PS2: PvP Night doesn't update because the PvPNight is still empty.

NICE :+1:


Glutin 0.21

This change is

I've published rust-glx; r=me after removing the ^ from Cargo.toml.

:pushpin: Commit 1c802b9 has been approved by jdm

@bors-servo r=jdm
I updated it myself since this is somewhat blocking my work

:hourglass: Testing commit 1c802b9e84c0b75e0bc8462134c40e20463365e1 with merge 2cc29d36dfa80d3696785ff27b247e840140ca15...

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing 2cc29d36dfa80d3696785ff27b247e840140ca15 to master...


Add a command to unset your respawn location

I'm closing this out as something that we won't fix. It could be revisited in the future, but it's not within our capacity to work on right now.


feat(jest): Switch from karma to jest

The benefits from switching from karma to jest are clear,
test execution speed its a huge factor. If you want to
have a read about it please follow
https://medium.com/aya-experience/testing-an-angularjs-app-with-jest-3029a613251.

@izifortune — Thank you, this is awesome!
Quick question: is it possible to keep karma and add jest support on top so we can have:
"test": "tsc && karma start"
"test-jest": "jest",
"test-jest:watch": "jest --watch",
"test-jest:ci": "jest --runInBand"

Alternatively, we could prompt the user to pick either Karma or Jest when running the generator.
What do you think? Thanks!

@jvandemo sure thing I can do that

@izifortune — Thank you, looking forward to trying it out 👍

Added jest as an option. I just noticed that at the moment there's no setup for karma yet

@izifortune — Great work! 👍
There is indeed no configuration for Karma yet. Would you be interested in adding one? If not, I can also have a look at it. Thanks again for your wonderful effort!

Can do that in another pr, one thing at the moment I'm using 2 package json
to have jest and karma do you think it's better to just have one? Less
things to maintain?
On Mon, May 29, 2017, 6:39 AM Jurgen Van de Moere<EMAIL_ADDRESS>wrote:

@izifortune https://github.com/izifortune — Great work! 👍
There is indeed no configuration for Karma yet. Would you be interested in
adding one? If not, I can also have a look at it. Thanks again for your
wonderful effort!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jvandemo/generator-angular2-library/pull/103#issuecomment-304576538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADPMLpLBD_8zFU9qBnr4R9W7Ngn3geOyks5r-loEgaJpZM4NjRVg
.

When will this pr be merged ? I think having a way of testing the library out of the box is really a good thing.

@izifortune — I finally had a chance to test this. Great work!
Can you please rebase this PR on the latest version of master so we can merge your changes?
It's fine to have a separate package.json for jest in the generator source code. There is a substantial difference with the default package.json that may be easier to maintain by keeping them separate instead of inline template expressions.
Thanks again for your efforts! 👍

@jvandemo  Rebased with current master.
Thank you for the time that you are putting into this!

@artemsky — PR has been merged and released as v11.0.0.
Thanks again for your wonderful contribution, much appreciated! 👍


Added binned monthly thickness to run_simulation, and created Jupyter nb for analysis of binned monthly thickness

Calculated binned monthly thickness in run_simulation. To account for flux divergence, this required combining the annual thickness and annual mass balance to get annual flux divergence, then distributing the annual flux divergence evenly across each year to get monthly flux divergence, which was then combined with monthly climatic mass balance to arrive at monthly thickness. Lines 965-979 are where this calculation takes place in run_simulation.py
In total, 4 new binned dataset variables were created:

bin_massbalclim_monthly
bin_fluxdiv_annual
bin_fluxdiv_monthly
bin_thick_monthly

These may not all be necessary to retain, but they don't really add much size to each output simulation, so I kept them for now.

Commit ac0b3b3 to btobers/PyGEM-scripts/run_simulation.py accounts for the density conversion of the climatic mass balance from m w.e. to m ice when calculating the flux divergence. This conversion does not effect the binned monthly thickness in the end, but does impact the values that are stored for the binned flux divergence.

I figured it made sense to make it so that the logging_level in various scripts was not hard coded and could be read form the input file. This was very useful in debugging. I also added the exception (if any) in run_simulation to the output fail text file.


Upgrade to gix v0.44

This fixes build issues with the now broken gix v0.44.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing in favor of https://github.com/substrait-io/substrait-rs/pull/97


Add clearDirectory() method based on removeDirectory()

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

Add method clearDirectory() based on removeDirectory().
Add option keepRootDirectory to removeDirectory().
Replace deprecated PHPUnit methods in tests.

Thanks!


Whole thread workers

I always wanted a thread pool whose workers pulled from a queue. Just made more mental sense to me, since I always use thread pools to parallelize a large number of identical or very similar tasks. Pull if you like, or don't. This way allows for custom setup and cleanup of each worker, FWIW.

This pull request have bugs.
Reproduce:

Using privoxy+thread pool(with this patch), privoxy will crash, error message show buffer overlimit, such as..
Using privoxy+thread pool(original code), privoxy work fine.

Thanks cyisfor for the request and thanks qianguozheng for testing it. From my point of view, besides the bug mentioned I think the given approach makes the API slightly harder to use since the user must knowingly mingle with synchronization (by calling the get_work function) which makes it less dummy-proof.
I appreciate the pull request but I don't see the benefit to merge for the moment being.
Thanks both!


Enable WriteCore feature for customer-insights

We need to enable WriteCore feature to customer-insights. Therefore add use-write-core: true and do a regen.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.CustomerInsights


[Bug] Some images throw an error before finishing loading

Describe the Bug
The images coming from a certain modality doesn't load (we know this error just happens with just one modality, but not the details about it), the error message on the console says:

Failed to execute 'postMessage' on 'Worker': # could not be cloned.

The patient info loads correctly (hidden in the attached image for patient privacy).

This error doesn't occur in Ohif V2
Steps to Reproduce
Try to load the attached image to the viewer. This image comes from the modality that produces the error
The current behavior
The DICOM doesn't finish loading, there is an error in the developer console and the sidebar stays like this:

The expected behavior
the DICOM image loads correctly and the users can see it
OS
macOS 14.2.1
Node version
18.16.1
Browser
Chrome Version 123.0.6312.124 (Official Build) (arm64)

I'm going to close this since the same problem is being discussed in #4078


Update set-up-export-application-insights.md

Updated Public Preview availability dates for Sovereign Clouds

Taking to live via my working branch.


style not rendered in shadow-root for mwc-dialog

tried to use mwc-dialog by npm install from repo everything works except the css part. getting [object Object] at place of style. not sure if its lit-html issue
looks similar to this issue https://github.com/material-components/material-components-web-components/issues/33

It doesn't work in my project too, but it does work on the MWCW demo page (when running locally).

I think it would be useful to add a description of your project/environment over on Issue #33 which @azakus has already self-assigned.
It's noted there that the component works just fine in certain example use cases.

Im trying to use this in https://github.com/Polymer/pwa-starter-kit

@ranjeet-choudhary, see my assumption here https://github.com/material-components/material-components-web-components/issues/33#issuecomment-395757559

we'll address this in #295


create unique task ID per launch of a task onto a slot

This is needed to avoid a problem with mesos-slave recovery resulting in LOST tasks.
i.e., we discovered that if you relaunch a topology's task onto the same worker slot (so there are 2 different instances with the same "task ID" that have run), then when the mesos-slave process is recovering, it terminates the task upon finding a "terminal" update in the recorded state of the task. The terminal state having been recorded the 1st time the task with that task ID stopped.
To solve this we ensure all task IDs are unique, by adding a milisecond-granularity timestamp onto the task IDs.

@dsKarthick : please :eyes:

This is being continued in #106


Add more features for delete mutations

I had to upgrade to get this built locally:

I had to upgrade to get this built locally (from 0.6.1 because it doesn't look to be available anymore):
    <dependency>
      <groupId>com.apollographql.federation</groupId>
      <artifactId>federation-graphql-java-support</artifactId>
      <version>0.6.3</version>
    </dependency>

Indeed, it's not in Maven central. My local build got it from our internal mirror, which seems to have pulled it from JCenter.
I'll update to the central version on the main branch.


Modify max_angle to include min_angle

Modify max_angle to accept tuples in addition to single values
(issue #1777)
In tracking.singleaxis the minimum angle of the tracker is always the opposite of the maximum angle. However, there are cases where the minimum angle can differ. (While NREL SAM does not support this feature, PVsyst does).
To address this limitation and support non-symmetrical limiting angles, I have made a modification to the min_angle parameter in tracking.singleaxis. It now accepts tuples of the form (min_angle, max_angle). To maintain compatibility with the more common symmetrical limits, the parameter still allows a single value.
Please review the changes. Thank you!

@MichalArieli I have no idea why GH is saying there are conflicts. Can you merge the current main from pvlib and push again?

@MichalArieli I have no idea why GH is saying there are conflicts. Can you merge the current main from pvlib and push again?

I did it. Are there still conflicts?

The title of this PR is quite interesting...

Superseded by #1852.  Thanks again @MichalArieli!


phenotype query default haploid/diploid selection

I think for the phenotype query, the default should be to have both haploid and diploid selected (non-sticky)
You can see that , for instance if you wanted all chromosome segregation phenotypes how many you lose with the filter on.

@manulera  do you agree?
I can't remember why we set it that way?

Sounds right to me, I don't know why it's like that, but probably chromosome segregation is one of the few cases where this would happen.

That's true, except we may have many legacy alles which should probably be annotated as diploids, but aren't.
Anyway, I'm not sure how useful this particular filter is. I was writing a draft announcement because I don't think we ever told people when we we separated diploid on the gene pages, and added to the query interface.
@kimrutherford  do you remember?
I searched the pombe list archive and I couldn't see anything.

Actually it must have been announced to some extent, because I reported this was corrected
https://github.com/pombase/website/issues/1949

I think for the phenotype query, the default should be to have both haploid and diploid selected (non-sticky)

I'll make that change now.  What do you mean by "non-sticky"?

I'll make that change now.

I've changed the code.   The fix will be visible on the main site on Friday.

Sorry I mena "sticky" If youchange it to haplois or diploid only, when you come back it should revert to both checked

OK, it does that.


PARQUET-747: Export TypedRowGroupStatistics in libparquet.so

Template subclasses don't behave in the same way with visibility attributes. See also PARQUET-659. Observed in build failure https://circleci.com/gh/conda-forge/staged-recipes/10100

Note: apparently the linking issue only showed up in conda-forge because it's using the Redhat devtoolset, which I guess has stricter linker behavior, since this hadn't been showing up in local gcc 4.9 builds

+1, also showed up for my while doing manylinux1 builds, probably the same toolset.

Argh, now I'm running into this issue: https://llvm.org/bugs/show_bug.cgi?id=24815

This provides some clue about how to fix, but I'm a little bit stumped for the moment: https://codereview.chromium.org/643703003/

Looking more closely -- I don't think we should be exporting TypedRowGroupStatistics in the public API at all, so we need to refactor the headers a bit

I'm going to merge this and see if that resolves the issue, since it's very difficult for me to reproduce the conda-forge link failure


secretsForAwsFromGitlab

Let's support a builtin for logging into AWS using Gitlab OIDC

Let's also add a retry logic to deal with: https://gitlab.com/gitlab-org/gitlab/-/issues/342243#note_1031859674


fix: make catchup false by default

making catchup true by default can have an impact on already scheduled jobs so it should be avoided, users need to be conscious before enabling this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.109%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6044

Relevant Lines:
8047

💛  - Coveralls


Build additional artefact for Java 8+, Jetty 9.3 and HTTP/2

To maintain Java 7 support (which the Android community highly value, along with others in orgs that can't upgrade yet) Jetty 9.2 is as high as we can go.
It would be great to start supporting HTTP/2 as soon as possible though, so I propose creating a 2nd standalone JAR artefact in the build, specifically targeting this configuration.
This would probably necessitate splitting the source tree up into core/ java7/ and java8/ (or something along those lines) and composing core/ with one of the other two at build time.

From what I can tell, there's actually not a very deep dependency on Jetty for the core features of Wiremock. If we were to split it up along the lines suggested and remove the Jetty dependencies to separate libraries, it would make it possible to use any Servlet container. Probably it would make the "deployed war" option a bit safer as well, since you could be sure that the main code paths do not depend on container code. I'm quite interested in a version that works flexibly with Spring Boot, and just uses the container that the project under test already has, instead of forcing it to use Jetty (i.e. Tomcat 8, Jetty 9, Undertow). I could help with implementing that here or host it somewhere else, but it would probably be a hack until the code is modularlized a bit. I have some proof of concept code that shows the level of hackery required, and it isn't much, so the modularization is probably not too hard.

Hi Dave,
Thanks for the offer to help with this.
We've worked pretty hard to isolate the Jetty dependency. A while back I did a scratch refactoring to get it working with the core Java web server, and I got the tests for all the core features passing.
Unfortunately there are a few less-than-obvious things that depend on some combination of Jetty or the Servlet API such as gzipped responses, file serving and fault injection. It would be great to eliminate these dependencies, if only to remove the Servlet API requirement (which seems to be a regular source of difficulty).
Could you elaborate your motivation for wanting to use your own container with it? Is it simply about dependency (in)compatibility, or something else?
I'm just wondering if dropping the Servlet API would solve your problem.

Dropping the Servlet API in the core would help, certainly, but it isn't necessary as a first step. My main objective is to be able to use the "ambient" container in a Spring Boot project, and not have Wiremock pull in conflicting dependencies. I would also like to be able to provide some mock server support (no HTTP) using Wiremock as a DSL. I can already pretty much do the latter since the core StubMapping abstraction is clean and JSON-serializable natively, but the former still needs some work to get it done cleanly. Longer term we could look at doing HTTP without even a Servlet container (Spring 5 is coming soon), if the Servlet dependencies were even further abstracted, but there's no need for that yet.

Do you object to using the standalone version as a dependency?
The reason I singled out the servlet API is that it's the one thing that can't be shaded in standalone JAR. Fixing that would guarantee you could use the standalone JAR with anything without dependency clashes.

The standalone has shaded stuff in it, so it's not really great to use as a library. I would prefer to use the "regular" jar and exclude dependencies I don't need (that's what I did in my proof of concept experiments). But that's probably not relevant: if you extract the servlet dependencies into a separate jar, then I can use the same strategy.
It would be more useful (and easier in the short term I think) to extract Jetty dependencies and provide a vanilla Servlet-API based implementation. The fact that you can package as a war and deploy as a standalone makes me think this is almost done, and would only take a little push to clean up some tiny tangles.

I actually tend to default to the standalone JAR as a dependency these days, but I can see that might not be great if you're concerned about keep your build artefact size down.
So if I understand your proposal correctly - you're suggesting the idea of a build artefact that knows about the servlet API but not Jetty so that it can be deployed into whatever servlet container you happen to be using?

Yes, that about sums it up.

OK, that certainly seems like a reasonable idea. Let me give it a little more thought.

I'm hopeful that the proposed approach will also help users of other frameworks which would otherwise have version conflicts - e.g. DropWizard 1.0

Dropwizard has quite a few dependencies in common with WireMock. I usually find it easiest to depend on the standalone JAR when I'm writing Dropwizard apps, rather than playing whac-a-mole with Jackson versions.

That commit seems to be off the master branch, which has been frozen for a while now. The currently active one is 2.0-beta. I suggest working off that one instead.
Hopefully it'll be back on master in the next few days, but there's still a bit of tidy-up for me to do first.

hi there Im new to open source and would love to contribute to wiremock Can anyone help me get started? Or is wiremock  for people who are more experienced in open source?

Hi Amir,
Great to hear you're interested in helping.
I'm open to anybody contributing to WireMock. Code quality and consistency is really important, so I suggest if you want to get involved it'd be a good idea to familiarise yourself with the codebase and tests.
Once you've done that (unless you have something specific you'd like to work on) I suggest taking a look at the open issues marked as Bug or Feature Request. If there's one you think you could help with, post your proposed solution in the comments and I'll give feedback. Once we've agreed a way forward you can submit your change via the usual PR process.
Cheers,
Tom


feat: support postgres:17, fixes #6566

The Issue

#6566

Support postgres:17.

How This PR Solves The Issue
Adds support.
Manual Testing Instructions
Use it, verify that it's 17 in the web and db container.
ddev config --database=postgres:17

Automated Testing Overview
Make sure existing TestDdevAllDatabases does what it should with this, and ImportDB and ExportDB perhaps.
Release/Deployment Notes

The arm64 images have arrived, restarted the arm64 macOS jobs.


PWA support for simplepdf.eu

Adding PWA (Progressive Web App) support to simplepdf.eu would be a nice addition for frequent users like myself. It provides a more app-like experience, especially on mobile, which I think many would appreciate.
I'm aware that this repository does not handle the development or maintenance of simplepdf.eu. In the absence of a dedicated repo for simplepdf.eu, I'm presenting my suggestion here.
Thank You!

Hey @Penknife0915!
Great call creating an issue!
PWA is in my backlog, I can't tell you when it will be out, but I'll make sure to ping you once that's the case!


Fix typos in Chapter 5 Exercise 9

This PR fixes two typos in the commentary for Exercise 9 of Chapter 5.

The accuracy calculated in cell 49 is 83.5%.
The percent change in the error rate of 25% references the incorrect value of 89.5%. That is, ((1 - 0.895) - (1 - 0.9217)) / (1 - 0.895) * 100 = 25%. The percent change should be ((1 - 0.835) - (1 - 0.9217)) / (1 - 0.835) * 100 = 53%.

In case it helps, the output of cell 49 changed from 0.895 to 0.8348666666666666 in commit f8d4885 on Feb 13, 2021.

Hi @alexdombos ,
Thanks for the PR, great catch! It's hard to get reproducible results even when the library versions don't change. But over time they keep changing, and the results as well. I initially thought I would just specify the versions in requirements.txt or environment.yml, but the truth is a large proportion of the readers don't use these, and they install the latest versions of each library. The same goes with Colab, which uses fairly recent versions of all libraries. So there's really no solution: sometimes, the code breaks, others times, the results are slightly off... I can only try to patch things as time goes by. So it's great to get the help of kind readers like you! 🙏


Slow to log into Azure extensions

Version: 1.32.0-insider (user setup)
Commit: 709bf352b12de8284683bef94cb5984129bfc776
Date: 2019-02-08T14:53:26.555Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

It's taking upwards of 3 minutes from when I click on the Azure icon in the activity bar until I see the list of subscriptions in the trees.  I see "activating extensions" for < 0:10 in the status bar, then it seems to hang for a long time until we're signed in.
Profiled the extensions:

CPU-20190208T212944.556Z.cpuprofile.zip
//cc @EricJizbaMSFT

A webpacked version of Functions should release soon (probably next week).
@Stephenweatherford for other extensions.

Cosmos is about to ship, Docker and App Service have already shipped. Storage and ARM should be soon.

see "activating extensions" for < 0:10 in the status bar,

Yeah, we hide that message because of https://github.com/Microsoft/vscode/issues/61846. Not sure how we can improve that. For once people say it feels slower in the presence of that message and sometimes extensions never finish, meaning we have to stop it.

@chrisdias Can you add the "F1 > Startup Performance" numbers after things have settled? It will allow us to know how much time was spend loading extension code and running it.

System Info

Code - Insiders: 1.32.0-insider (d18d0edce11ac396bf7654ac96e0d522681b5553)
OS: win32(10.0.17134)
CPUs: Intel(R) Core(TM) i5-2400S CPU @ 2.50GHz(4 x 2494)
Memory(System): 7.98 GB(3.08GB free)
Memory(Process): 177.74 MB working set(177.74MB peak, 150.56MB private, 38.85MB shared)
VM(likelyhood): 0%
Initial Startup: true
Has 0 other windows
Screen Reader Active: false
Empty Workspace: false

Performance Marks

What
Duration
Process
Info

start => app.isReady
68
[main]
initial startup: true

nls:start => nls:end
0
[main]
initial startup: true

require(main.bundle.js)
404
[main]
initial startup: true

app.isReady => window.loadUrl()
988
[main]
initial startup: true

require & init global storage
182
[main]
initial startup: true

window.loadUrl() => begin to require(workbench.main.js)
487
[main->renderer]
NewWindow

require(workbench.main.js)
1601
[renderer]
cached data: YES

require & init workspace storage
200
[renderer]
-

init workspace service
50
[renderer]
-

register extensions & spawn extension host
437
[renderer]
-

restore viewlet
29
[renderer]
workbench.view.explorer

restore panel
0
[renderer]
-

restore editors
102
[renderer]
1: workbench.runtimeExtensions.input

overall workbench load
263
[renderer]
-

workbench ready
3693
[main->renderer]
-

extensions registered
4167
[renderer]
-

Extension Activation Stats

Extension
Eager
Load Code
Call Activate
Finish Activate
Event

vscode.debug-auto-launch
true
56
0
8
*

vscode.emmet
true
71
2
6
*

vscode.git
true
126
4
60
*

vscode.merge-conflict
true
56
2
3
*

vscode.configuration-editing
false
80
1
36
onLanguage:jsonc

vscode.extension-editing
false
225
1
6
onLanguage:markdown

vscode.json-language-features
false
152
34
2
onLanguage:jsonc

vscode.markdown-language-features
false
166
6
0
onLanguage:markdown

vscode.typescript-language-features
false
201
2
0
onLanguage:jsonc

ms-azuretools.vscode-azureappservice
false
939
32
163
onView:azureAppService

ms-azuretools.vscode-azurefunctions
false
1251
37
126
onView:azureFunctionsExplorer

ms-azuretools.vscode-azurestorage
false
29161
92
34
onView:azureStorage

ms-azuretools.vscode-cosmosdb
false
34943
30
4
onView:cosmosDBExplorer

ms-vscode.azure-account
false
777
3
0
onView:azureAppService

Raw Perf Marks
Name	Timestamp	Delta	Total
main:started<PHONE_NUMBER>302	0	0
main:appReady<PHONE_NUMBER>370	68	68
willLoadMainBundle<PHONE_NUMBER>372	2	70
didLoadMainBundle<PHONE_NUMBER>776	404	474
main:willInitGlobalStorage<PHONE_NUMBER>891	115	589
main:didInitGlobalStorage<PHONE_NUMBER>073	182	771
main:loadWindow<PHONE_NUMBER>358	285	1056
renderer/started<PHONE_NUMBER>799	441	1497
willShowPartsSplash<PHONE_NUMBER>822	23	1520
didShowPartsSplash<PHONE_NUMBER>824	2	1522
willLoadWorkbenchMain<PHONE_NUMBER>845	21	1543
didLoadWorkbenchMain<PHONE_NUMBER>446	1601	3144
main/startup<PHONE_NUMBER>446	0	3144
willInitWorkspaceService<PHONE_NUMBER>525	79	3223
willInitWorkspaceStorage<PHONE_NUMBER>531	6	3229
didInitWorkspaceService<PHONE_NUMBER>575	44	3273
didInitWorkspaceStorage<PHONE_NUMBER>731	156	3429
willStartWorkbench<PHONE_NUMBER>732	1	3430
willRestoreEditors<PHONE_NUMBER>844	112	3542
willRestoreViewlet<PHONE_NUMBER>844	0	3542
willResolveExplorer<PHONE_NUMBER>855	11	3553
LifecyclePhase/Ready<PHONE_NUMBER>871	16	3569
didRestoreViewlet<PHONE_NUMBER>873	2	3571
didRestoreEditors<PHONE_NUMBER>946	73	3644
LifecyclePhase/Restored<PHONE_NUMBER>946	0	3644
didStartWorkbench<PHONE_NUMBER>995	49	3693
willLoadExtensions<PHONE_NUMBER>032	37	3730
didResolveExplorer<PHONE_NUMBER>330	298	4028
extensionHostReady<PHONE_NUMBER>460	130	4158
didLoadExtensions<PHONE_NUMBER>469	9	4167
LifecyclePhase/Eventually<PHONE_NUMBER>463	1994	6161

The webpack'd Functions extension just shipped, so now the first startup of the Azure Extension Pack (App Service, Functions, Storage, and Cosmos)is about 1:07 using the stopwatch.  Here's the Show Running Extensions info:

if i uninstall Cosmos and Storage, which are not webpack'ed yet, I get down to about < 3 seconds. Here's the Show Running Extensions info:

@EricJizbaMSFT are there webpack'd versions of storage and cosmos I could try out locally?

Cosmos is already in master. Latest build is here: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=2869
@StephenWeatherford just submitted a PR for storage today: https://github.com/Microsoft/vscode-azurestorage/pull/296, but I don't see a passing build from that branch

thanks @EricJizbaMSFT!  With this webpack'd cosmos extension, the first rough stopwatch timing was about 5 sec, probably more like 4.5. Here is the startup perf report for the extensions:

When things were warmed up a bit (stopped VS Code, waited, then started again), it was about 1 sec from clicking on the Azure icon to seeing the subscriptions in the tree.

Cosmos performance isn't as good as the others - lots of webpack issues, ending up excluding more modules than I'd like.  I can work on improving that after ship if needed.
The webpack'd storage extension now has a passing build: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=3083

thanks @StephenWeatherford !  with the referenced storage extension, stopwatch timing on windows was < 3sec for the very first load.  here's F1 > Show Running Extensions:

So i think it is fair to conclude that webpack'ing the Azure extensions helps considerably.
Closing.

That's great, thanks. I'll let you know when Cosmos and storage ship.


made some updates to get the sites working

Hey Luke!  I checked out your suggestions.  Exporting to a csv would be useful, so that feature will be added.  I think making the location a parameter for the entire scraper and passing it to the individual site scrapers is better.  Right now both your suggestions and mine have the location hard coded, and not everyone lives in New Orleans or Boston.
I wanted to reach out to you as I work a day job so I'll get to this this weekend.  I hope you found this code useful though as I open sourced this to help out job seekers.

Hey Oline!
Thanks for getting back to me! I totally wasn’t expecting this so it’s a super nice surprise! The code has been extremely useful! I actually have a job myself and aren’t currently looking for one but I use the code to create a list of jobs that I post on my LinkedIn for other people to use.
If you’d like to zoom or something this weekend I’d be happy to!
Thanks!
Luke

On Aug 15, 2024, at 10:03 PM, Olin Gallet @.***> wrote:
Hey Luke! I checked out your suggestions. Exporting to a csv would be useful, so that feature will be added. I think making the location a parameter for the entire scraper and passing it to the individual site scrapers is better. Right now both your suggestions and mine have the location hard coded, and not everyone lives in New Orleans or Boston.
I wanted to reach out to you as I work a day job so I'll get to this this weekend. I hope you found this code useful though as I open sourced this to help out job seekers.
—
Reply to this email directly, view it on GitHub https://github.com/olindgallet/jobscraperv2/pull/1#issuecomment-2292598783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATZDTJPHYBZ2L5YWPPU2Z4DZRVMYFAVCNFSM6AAAAABMQHUMYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGU4TQNZYGM.
You are receiving this because you authored the thread.


Check for case-insensitive duplicates when creating new tags

Fixes issue #460.

Current coverage is 89.92% (diff: 100%)

Merging #461 into master will increase coverage by 0.40%

@@             master       #461   diff @@
==========================================
  Files             8          8
  Lines           687        695     +8
  Methods           0          0
  Messages          0          0
  Branches        109        110     +1
==========================================
+ Hits            615        625    +10
+ Misses           57         55     -2
  Partials         15         15

Powered by Codecov. Last update b7d3995...a96da42


Login: redirectTo to previously cached content pages or product detail pages shows old content as sw-states are not refreshed on redirect

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
If redirectTo is used to redirect to a page in the navigation or product detail pages that has been viewed before the content should immediately display new data, e.g. new prices. Instead of showing the old data from the cache.
Actual behaviour
The previous page content is displayed. The reason is that the redirect response itself does not update the states in the response.
However, updating the states in the response results in an issue with logout as the logout process then fails to update the content correspondingly.
Maybe, a double redirect is necessary like e.g. redirecting to a temporary route that then redirects to the final page with the correct states.
Furthermore, the SEO redirect itself from e.g. /detail/<id> does not update the states either, probably as it happens before the kernel is handling the request.
How to reproduce
Use redirectTo and redirectParameters to redirect to a page in the navigation tree, in the login form. Ensure that that page has been shown before.

A similar issue happens if you redirect due to customer not logged in, e.g. directly on the homepage (because the customer wants to limit the shop to logged in customers only), that means after login the redirect goes to the homepage which is then cached and that state is rememberd after logout.

@shyim could the cache session fix in <IP_ADDRESS> https://github.com/shopware/platform/commit/91d5395ae8933e80bb90a612c3311a926d0ade11
actually solve this issue too?

nope

@shyim OK. Thanks. I thought it won't. I might look into this in more detail and create a PR though.

I wrote in the comments here already a solution, but don't have currently time for that https://issues.shopware.com/issues/NEXT-17181

@shyim great. Maybe I can create a PR from it. not sure when though. Maybe tomorrow but can't guarantee. Personally, I think this is also a bit security relevant as logged in page could end up in the anonymous cache. though only if the user already manipulated the redirectTo, so a bit like their own fault

Should be fixed with https://github.com/shopware/platform/commit/01f211214fe66dab45deae3075788710eca5e508.
@AndreasA can you verify that the latest does not have this problem anymore?

@keulinho I will try to verify during the weekend, probably won't have time beforehand.
Is there already a released version with that commit?

Nope that commit is not yet released.

I will close this as the commit is released already


Discord handler

A basic discord handler using the Bot api over HTTPS which can be found here: https://discordapp.com/developers/docs/reference
A quick example:
$discordHandler = new \Monolog\Handler\DiscordBotHandler($channel_id, $bot_token, Logger::ERROR);
$discordHandler->setEmoji(':warning:');
$monolog->pushHandler($discordHandler);

$monolog->error('Wew something went terribly wrong!');

This will output something similar to this:

I was just wondering if this is going to be accepted or not since I haven't received any kind of feedback/response.
I've been using it in production on a high-traffic website since I created the pull request to log all 5xx errors and I've noticed 0 problems.

Sorry for the delay, but I'd rather not add new handlers to the 1.x release at this point, and I need to wrap up some stuff for the 2.0 before it's final.. So it might be a bit longer still.

For my personal use-case I need to use a bot. Perhaps we should allow both of them by using 2 different handlers similarly to how it is done for Slack. @galli-leo

@Crecket That might also be an option

Closing as a handler is available at https://github.com/lefuturiste/monolog-discord-handler and I rather not add more of such handlers to core monolog anyway.

I might add later a way to send messages using a discord bot in my library.


Android sample improvements

This is a focused PR that addresses the following for Android:

Adding help labels to explain sample operation
Fixing UI problems that interfere with sample operation
Fixing code or behavior problems, excluding style and language feature use

@ThadT I've either made changes or filed issues for all of your suggestions, so I'll go ahead and merge. Thanks for the review! :)


Dependencies in readme

Hey,
You seem to have updated ELPATH to be compatible with Dear PyGui 1.x, but the dependencies listed on your readme state DearPyGui v0.8.62.
I'm assuming it runs well on DPG 1.x and you can update the readme.

updated the dependencies, thanks!


loops and functions

Many key processes could be significantly streamlined with the use of functions, including:

the import-csv script that imports the raw data by month/quarter
most of the construct script that simply changes variable types etc
most of the geo-merge script which merges the cabinet.geo.key to each month/quarter object

to do as of now:

make date cols as date class
generally, make correct column types
create a duration variable for 2nd half of 2020

to do as of now:

make date cols as date class
generally, make correct column types
create a duration variable for 2nd half of 2020


EvaluatedModelMapper: Support empty IDs fpr rule violations

For "global" rule violations that are not triggered by a project or
package it makes sense to set the ID to Identifier.EMPTY. The WebApp
reporter so far failed to be generated for such rule violations as the
underlying mode mapper demanded the ID to by a valid project or package
ID. Relax this requirement to be able to display such "global" rule
violations in the WebApp reporter.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

All done.

All done.


⚠ Turnos 24x7 has degraded performance

In 92ee224, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1168 ms

Resolved: Turnos 24x7 performance has improved in f9a2c49.


Add playground machines sub-command to labctl for listing machines in a playground

Summary:
This PR introduces a new sub-command machines under the playground command in the labctl CLI tool. This command allows users to list the machines associated with a specific playground by providing the Playground ID.
Changes Made:

Created a new sub-command machines under the playground command.
Implemented the logic to fetch and display machines using the Playground ID.
Utilized the existing GetPlay method in the API client to retrieve playground details.

Usage:
To list the machines for a specific playground, use the following command:
labctl playground machines <Playground ID>

Examples

To list machines for a playground with ID 67103cf80fd263a6eea588d2, run:

labctl playground machines 67103cf80fd263a6eea588d2

This will output:
MACHINE NAME
machine1
machine2
machine3

If the specified Playground ID does not exist, an error message will be displayed:

Couldn't find playground with ID 99999: request failed with status 404: {"error":"Play not found."}.

Awesome stuff!


LWJGL 3 backend V-Sync problem on desktop

All my monitors work on 60 hz:
Issue details

If I use LWJGL 3.0, 3.1, coded V-Sync ON (and forced V-Sync on Radeon Drivers), I get 30 FPS (windowed mode).
If I use LWJGL 3.0, 3.1, coded V-Sync ON (and DISABLED V-Sync on Radeon Drivers), I get 60 FPS (windowed mode).

If I use LWJGL 2.x, coded V-Sync ON (and DISABLED V-Sync on Radeon Drivers), I get 60 FPS (windowed mode)

Expected results
I should always get 60 FPS as my monitor expect, instead of 30.
Version of LibGDX and/or relevant dependencies
libGDX 1.9.4, 1.9.5, 1.9.6, 1.9.7-SNAPSHOT
Please select the affected platforms

[ ] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[ ] HTML/GWT
[x] Windows
[ ] Linux
[ ] MacOS

Windows 10 + AMD + Forced v-sync on drivers = 30 FPS problem appear.
Windows 10 + NVIDIA + Forced v-sync on drivers = 60 FPS.
Ubuntu 17.10 + NVIDIA+ Forced v-sync on drivers = 60 FPS.
My general PC specs: Windows 10 pro 64 bits. AMD FX-8350 8cores@4Ghz, motherboard Gigabyte GA-970A-DS3P, 16Gb ram, AMD Radeon R9 280x, SSD 840 EVO 500Gb.
NOTE: Using latest drivers on all PC up today.

UPDATE:
Windows + AMD = this problem appear.
Windows + NVIDIA = CAN'T reproduce.
Linux + NVIDIA = CAN'T reproduce.

Win 10 Laptop, 980m GTX, 30 FPS all the time with lwjgl3.
lwjgl 2.x always at 60
latest build.

This might not be a libgdx issue at all.
You should probably verify this with a vanilla lwjgl3 project: https://www.lwjgl.org/guide

This might not be a libgdx issue at all.
You should probably verify this with a vanilla lwjgl3 project: https://www.lwjgl.org/guide

I'll try it and report here soon.

Maybe your driver is overriding the VSYNC config
Check in the control panel of your driver (CCC for AMD i think), and see if VSYNC is set to override application profile

Well Gents, results:
If libgdx is compiled against lwjgl 3.1.0-SNAPSHOT then it has frame rate issues.

created project with source from  https://www.lwjgl.org/guide. Gradle generated from nightly tab in downloads/lwjgl3 homepage.

Added the Timer class from SilveTiger:
https://github.com/SilverTiger/lwjgl3-tutorial/blob/master/src/silvertiger/tutorial/lwjgl/core/Timer.java

Updated the loop to account for the timer & set the window title:
 while ( !glfwWindowShouldClose(window) ) {

 	delta = timer.getDelta();

 	glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); // clear the framebuffer

 	timer.updateUPS();
 	timer.updateFPS();
 	timer.update();
 	glfwSetWindowTitle(window, "FPS: " + timer.getFPS());

 	glfwSwapBuffers(window); // swap the color buffers
 	// Poll for window events. The key callback above will only be
 	// invoked during this call.
 	glfwPollEvents();
 }

Result is the test runs at 60 fps, while gdx tests at 30: (57 below is due to the snipping tool)
Of course I tested in lwjgl 2 in another demo project and in my projects that I use v2, I still get 60 fps on all those. Project source attached. Note: all demos run at 30, not just the tile test below.
I'm open to suggestions & doing more troubleshooting.

test project.zip

My experience here (on a MacBook Pro, OS X 10.11) completely contradicts the GLFW documentation.

with glfwSwapInterval(0) (which it says is no vsync) I get 60 fps
with glfwSwapInterval(1) (vsync) I get 60/N fps, where N is the number of windows open e.g. in MultiWindowTest
with glfwSwapInterval(-1) I get no vsync (300 fps and more), but the referenced extension document states something totally different

Not sure if any commits in the last 20 days affected this at all. I'll probably re-test, on the weekend with the latest build.

Please report back on this. I tested on macOS Sierra and Windows 10 and could not find an issue.

Will try out with the new release soon!

confirmed on libGDX 1.9.4 and LWJGL 3.1

confirmed on libGDX 1.9.5 and LWJGL 3.1 (windows)

Aye, The issue persists. :(

Update:
This narrows it down - a lot -
I wanted to try this with a clean 1.9.5 project once more. I had a suspicion that this could be a libgdx tests error.

... and I had success! The issue does indeed vanish. So the problem should be either in:

in the libgdx tests code.
in the way multi window rendering is done, since the tests app has 2 of them open and 30 is 60/2. (haven't played with this functionality at all)
somewhere in between libgdx - lwjgl (API use or fps reporting issue?).

francogp, can you try this as well?

@xGnoSiSx nope.. I keep getting 30FPS with that code. If I deactivate vsync from radeon driver, then I get 60 FPS, like I said before.

Well the above code is for a single window test. This is weird.
Not gonna say that 60/number of windows is not buggy either and that's what I'm still getting with LaunchTestsLwjgl3 still, regardless of driver vsync settings.

I can confirm this bug still exists, and affects single-window applications. My graphics hardware is Radeon HD 7970 + Radeon RX 480.
I made a separate branch of my game to test the LWJGL3 backend, and I get 30 FPS as opposed to 60 FPS with the LWJGL2 backend. Switching to fullscreen changes it to 60. I also tested using a barebones project and got the same result.
Explicitly setting vsync to false in the application configuration or setting it later using Gdx.graphics.setVSync(false) changes it to a solid 60 FPS.

I've done some more recent tests and played with the vsync property as well on 1.9.6.
I've got a 980m GTX, on windows 10 on a 4k Monitor. And I've got no problems.
Turning vsync on or off at full screen has the expected behavior. Astronomical frames when off and 60 frames when on. Same results when run in windowed mode.
I also tried to reproduce https://github.com/glfw/glfw/issues/676 but I can't - or at least it's not clear when this occurs.

@xGnoSiSx as I state before, It can be reproduced ONLY on AMD graphic cards.

#https://github.com/LWJGL/lwjgl3/issues/340#issuecomment-338410798

It's been a while but I updated my LWJGL3 project and tested again. I believe this bug no longer affects single-window applications. When vsync is on it is correctly matching my refresh rate at 60 FPS. (Radeon RX 580 + Radeon R9 200)
When vsync is off the frame rate is uncapped. Which makes sense I guess, but is this intended? There used to be something like cfg.foregroundFPS to control the FPS regardless of vsync, but it doesn't seem to exist anymore in the LWJGL3 backend. That pretty much makes vsync mandatory to prevent graphics card melting, doesn't it?

I have a similar issue with my setup : Linux Ubuntu 16.04 + Intel GPU + Nvidia GPU.
IIRC it's a known issue with linux not handling vsync with multiple GPUs.
In my case vsync doesn't work and FPS is always uncapped.
I found a workaround by porting LWJGL2 feature : http://forum.lwjgl.org/index.php?topic=6582.0
Now i can force FPS to any value i want and prevent my graphics card melting.
Question is, should/could we include this Sync class in libgdx lwjgl3 backend? (i can make the PR)
more than fixing some vsync issues, it could be a feature if you want to force FPS for some reasons.

Is there any update on fixing the actual vsync issues, as opposed to using the sync class to force the fps?

@Monarchis all versions (snapshots too) are affected.

I should mention that I'm also using a multi-monitor setup since 2018. As Ktar mentioned, Behaviour is different  if you use such a setup. I haven't found documentation in LWJGL 3 relevant for this.
My guess is that this affects initialization and FPS somehow.

THIS HAS A FIX, PLEASE LOOK AT THIS COMMENT I MADE ON A DIFFERENT POST:
https://github.com/libgdx/libgdx/issues/5826#issuecomment-578456720

This issue seems to have mixed a few different problems, so let's try to unravel those:

Vsync is not working properly in multi-window situations. This was apparently fixed in e8abed6e0c67829e30e23e723f42ba07217ca98a.
There were issues with vsync and AMD hardware. According to @xGnoSiSx and @Schyfis, the problems no longer seems to be happening in later libGDX versions. Moreover, since the initial reports lwjgl was updated (3.1.3 -> 3.2.3).
When switching to fullscreen, the vsync setting is ignored (also see #5826). By my tests, this is still happening on Windows, but not on Mac OS. This can be fixed by setting vsync again after activating fullscreen.
According to @mgsx-dev, Linux is not respecting the vsync setting in certain configurations. This can, however, be circumvented by using the lwjgl2 Sync class.

Only number 4 may still be an issue. On our end, we could solve this by implementing the Sync class in libGDX. This would also allow us to offer a foregroundFPS-option as we did with the lwjgl2 backend.

@crykn I believe you're missing the main issue that I found. On a multi-monitor setup (not multi-window), where each monitor has a different refresh rate, v-sync goes wild.

Hey @Ktar5 if you're referring to the issue that you reported in #5826, I have submitted #6150 as a fix.

@crykn Not entirely sure. I'd need to test. But it didn't matter if it was multi-window.

#6150 is not related to multi-windows, that is just the reason why the fix proposed there doesn't work.
The issue reported in #5286 was that after enabling fullscreen mode on windows, the vsync setting would be ignored.

Just for future reference: yesterday, a user on the Discord server reported an issue which might be related:

[...] if vsync is enabled, the game will launch in windowed mode with 60 fps, maintain 60 fps when I toggle to fullscreen, but then drop to a stable 30 fps after switching again back to windowed.

(Gdx version: 1.9.12, OS: Windows, Graphics card: Radeon RX 580, Forced V-Sync in the Radeon Drivers: disabled)
Disabling vsync and using Gdx.graphics.setForegroundFps(60) was the advised solution. However, that lead to screen tearing in fullscreen mode, so the final solution was turning vsync on only for fullscreen mode.

This issue is present in Windows using NVIDIA 1080Ti, with Project settings (Windows+P) set to Duplicate (but not Extend).
With Duplicate, with Swap Interval 1, 30FPS max.
With Extend, with Swap Interval 1, 60FPS max.


Add support for route model binding

Thanks for the suggestion Michael. You've submitted a well written pull request!
At this time we wont add this feature. I suggest you either create a another package on top of this one or use existing packages such as kayandra/hashidable and erashdan/hashid.


Separate script to acquire SDK, limit CI

Separate script. Can be run manually on linux.
Add more packages as documented on https://doc.qt.io/qt-6/android-getting-started.html#android-sdk-mandatory-packages
Limit CI to android (as long as developing #35845)

Installed packages:
  Path                 | Version | Description                | Location
  -------              | ------- | -------                    | -------
  build-tools;34.0.0   | 34.0.0  | Android SDK Build-Tools 34 | build-tools/34.0.0
  platform-tools       | 35.0.1  | Android SDK Platform-Tools | platform-tools
  platforms;android-34 | 3       | Android SDK Platform 34    | platforms/android-34

Ping @m-kuhn

Good move, thanks


[US] Schema Access Management

As an administrator, I want to manage and control the access to application schema's data on a per user basis to prevent users from accessing data they shouldn't have access to.

MoSCoW
Risk
Story Points

Must
Low
5

Acceptance Criteria

Schema access should be editable from the user management menu
Schema access should be saved in a distinct table within the database
Schema access policies should be applied on login, where the system would only show schemas in the navbar that the user has access to.

Risks
Pre-requisites

[ ] Meet with the stakeholder to clarify the requirements

Tasks

[ ] Design the way schema access will be stored in the database
[ ] Implement schema access control within the user management menu
[ ] Apply schema access on login

Change in Design
Initially, the plan was to store the schemas to which users can access in a separate database table. However, after thinking about it while implementing this story, it made more sense to implement it as an extra column within the authentication.users table, which would define the schema access list via an array of strings.

Implementation of the schema access list (shown via the meta.user_info view)
This makes it easier to manage both on the database and the front-end level, as it would have otherwise required to keep track of database relations from the front end, which adds a level of unnecessary complexity. It also doesn't involve any limitations compared to the database table approach.

##Demo Video
https://github.com/WillTrem/UInnovate/assets/64431699/21100799-b3b8-461c-bf02-7b4edb700a93

Looks good! Signing off!


Added support for Portal: The Flash Version MapPack

Not sure if the point of SourceSplit is to only support standalone games or if mods are also welcome. I believe that there's some rising interest in speedrunning Portal mods, at least.