Feat replace weave gitops capacitor

Type
enhancement

Description

Replaced Weave GitOps with Capacitor for GitOps operations.
Updated dependencies and API versions for HTTPRoutes across multiple configurations.
Removed Weave GitOps specific configurations and introduced Capacitor OCIRepository and Kustomization.
Updated Vault ClusterIssuer roleId for cert-manager.

Changes walkthrough
Relevant filesEnhancement12 files

flux-config.yamlIntroduce Capacitor Kustomization and Remove Weave GitOps Health Checks

clusters/mycluster-0/flux-config.yaml
Introduced a new Kustomization for capacitor in the flux-system namespace.  Removed health checks for weave-gitops.

+19/-5

tooling.yamlUpdate Dependency in Tooling Configuration

clusters/mycluster-0/tooling.yaml
Updated dependency from infrastructure-gateways to infrastructure.

+1/-1

httproute.yamlUpdate HTTPRoute for Capacitor

flux-config/base/capacitor/httproute.yaml
Updated API version for HTTPRoute.  Renamed from weave-gitops to capacitor and updated port from 9001 to 9000.

+4/-4

kustomization.yamlSimplify Capacitor Kustomization Resources

flux-config/base/capacitor/kustomization.yaml

Removed helmrelease.yaml from resources.

+0/-1

source.yamlAdd Capacitor OCIRepository Source

flux-config/base/capacitor/source.yaml

Added new OCIRepository for capacitor with a 12h sync interval.

+10/-0

helmrelease.yamlRemove Weave GitOps HelmRelease

flux-config/base/weave-gitops/helmrelease.yaml

Removed HelmRelease for Weave GitOps.

+0/-21

source.yamlRemove Weave GitOps HelmRepository

flux-config/base/weave-gitops/source.yaml

Removed HelmRepository for Weave GitOps.

+0/-17

kustomization.yamlReplace Weave GitOps with Capacitor in Kustomization Resources

flux-config/mycluster-0/weave-gitops/kustomization.yaml

Replaced weave-gitops with capacitor in resources.

+1/-1

httproute.yamlUpdate API Version for Grafana HTTPRoute

observability/base/kube-prometheus-stack/httproute.yaml

Updated API version for HTTPRoute.

+1/-1

httproute.yamlUpdate API Version for Loki HTTPRoute

observability/base/loki/httproute.yaml

Updated API version for HTTPRoute.

+1/-1

vault-clusterissuer.yamlUpdate Vault ClusterIssuer RoleId

security/base/cert-manager/vault-clusterissuer.yaml

Updated roleId for Vault ClusterIssuer.

+1/-1

httproute.yamlUpdate API Version for Harbor HTTPRoute

tooling/base/harbor/httproute.yaml

Updated API version for HTTPRoute.

+1/-1

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

/describe


Connection closes soon after an establishing RTSP connection

Which version are you using?
v0.21.6
Which operating system are you using?

[ ] Linux amd64 standard
[x ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Deployed rtsp-simple-server in a kubernetes cluster. If I use the pod IP to send a stream, the connection remains established, but if I create a service for the pod and try to connect a client, the connection gets established, but immediately terminates.
Describe how to replicate the issue

Deploy the server using a yaml file as shown bellow
kubectl apply -f rtsp-server-deployment.yaml
kubectl apply -f rtsp-service.yaml
try connecting an rtsp stream to the rts-simple-server
View the logs for the POD
kubectl logs -n bare srtp-pod
rtsp-server-deployment.yaml:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: rtsp-server
  namespace: bare
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      io.kompose.service: rtsp-server
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      labels:
        io.kompose.network/edge-bare-edge-network: "true"
        io.kompose.service: rtsp-server
    spec:
      containers:
      - image: harbor10165.senode.dev/sgs/simple-rtsp-server
        imagePullPolicy: IfNotPresent
        name: rtsp-server
        ports:
        - containerPort: 8554
          protocol: TCP
        resources:
          limits:
            cpu: "1"
            memory: "1073741824"
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30

rtsp-service.yaml
---
apiVersion: v1
kind: Service
metadata:
  name: rtsp-service-tcp
  namespace: bare
spec:
  selector:
    io.kompose.service: rtsp-server
  ports:
    - name: rtsp-tcp
      protocol: TCP
      port: 8554
      targetPort: 8554
  type: ClusterIP

Did you attach the server logs?

yes
Working
=======
kubectl logs -f -n bare rtsp-server-6f994c88bb-bzm29
2023/05/31 20:13:35 INF MediaMTX / rtsp-simple-server v0.21.6
2023/05/31 20:13:35 INF [RTSP] listener opened on :8554 (TCP), :8000 (UDP/RTP), :8001 (UDP/RTCP)
2023/05/31 20:13:35 INF [RTMP] listener opened on :1935
2023/05/31 20:13:35 INF [HLS] listener opened on :8888
2023/05/31 20:13:35 INF [WebRTC] listener opened on :8889 (HTTP)

- deploy infrence1-service
2023/05/31 20:21:01 INF [RTSP] [conn <IP_ADDRESS>:59548] opened
2023/05/31 20:21:01 INF [RTSP] [session 965fa869] created by <IP_ADDRESS>:59548
2023/05/31 20:21:02 INF [RTSP] [session 965fa869] is publishing to path 'inference_1', with UDP, 1 track (H264)

- deploy inference2-service
2023/05/31 20:21:50 INF [RTSP] [conn <IP_ADDRESS>:51702] opened
2023/05/31 20:21:50 INF [RTSP] [session a1e73eee] created by <IP_ADDRESS>:51702
2023/05/31 20:21:51 INF [RTSP] [session a1e73eee] is publishing to path 'inference_2', with UDP, 1 track (H264)

- deploy stream-ui
2023/05/31 20:22:36 INF [RTSP] [conn <IP_ADDRESS>:33826] opened
2023/05/31 20:22:36 INF [RTSP] [session 5b646232] created by <IP_ADDRESS>:33826
2023/05/31 20:22:36 INF [RTSP] [session 5b646232] is reading from path 'inference_1', with TCP, 1 track (H264)
2023/05/31 20:22:42 INF [RTSP] [conn <IP_ADDRESS>:56028] opened
2023/05/31 20:22:42 INF [RTSP] [session bac3c23e] created by <IP_ADDRESS>:56028
2023/05/31 20:22:42 INF [RTSP] [session bac3c23e] is reading from path 'inference_2', with TCP, 1 track (H264)

Failing
========

kubectl logs -f -n bare rtsp-server-6f994c88bb-8r7jf
2023/05/31 20:00:01 INF MediaMTX / rtsp-simple-server v0.21.6
2023/05/31 20:00:01 INF [RTSP] listener opened on :8554 (TCP), :8000 (UDP/RTP), :8001 (UDP/RTCP)
2023/05/31 20:00:01 INF [RTMP] listener opened on :1935
2023/05/31 20:00:01 INF [HLS] listener opened on :8888
2023/05/31 20:00:01 INF [WebRTC] listener opened on :8889 (HTTP)

- deploy inference1-service
2023/05/31 20:01:12 INF [RTSP] [conn <IP_ADDRESS>:50090] opened
2023/05/31 20:01:12 INF [RTSP] [session 0788142a] created by <IP_ADDRESS>:50090
2023/05/31 20:01:13 INF [RTSP] [session 0788142a] is publishing to path 'inference_1', with UDP, 1 track (H264)
2023/05/31 20:01:23 INF [RTSP] [conn <IP_ADDRESS>:50090] closed (terminated)
2023/05/31 20:01:23 INF [RTSP] [session 0788142a] destroyed (session timed out)
2023/05/31 20:01:23 INF [RTSP] [conn <IP_ADDRESS>:59328] opened

- deployed inference1-service
2023/05/31 20:03:08 INF [RTSP] [conn <IP_ADDRESS>:56622] opened
2023/05/31 20:03:08 INF [RTSP] [session 5e640c7a] created by <IP_ADDRESS>:56622
2023/05/31 20:03:09 INF [RTSP] [session 5e640c7a] is publishing to path 'inference_2', with UDP, 1 track (H264)
2023/05/31 20:03:19 INF [RTSP] [conn <IP_ADDRESS>:56622] closed (terminated)
2023/05/31 20:03:19 INF [RTSP] [session 5e640c7a] destroyed (session timed out)
2023/05/31 20:03:19 INF [RTSP] [conn <IP_ADDRESS>:44406] opened
2023/05/31 20:04:16 INF [RTSP] [conn <IP_ADDRESS>:32798] opened
2023/05/31 20:04:16 INF [RTSP] [conn <IP_ADDRESS>:32798] closed (no one is publishing to path 'inference_1')
2023/05/31 20:04:16 INF [RTSP] [conn <IP_ADDRESS>:32804] opened
2023/05/31 20:04:16 INF [RTSP] [conn <IP_ADDRESS>:32804] closed (no one is publishing to path 'inference_2')
2023/05/31 20:04:21 INF [RTSP] [conn <IP_ADDRESS>:59742] opened
2023/05/31 20:04:21 INF [RTSP] [conn <IP_ADDRESS>:59742] closed (no one is publishing to path 'inference_1')
2023/05/31 20:04:21 INF [RTSP] [conn <IP_ADDRESS>:59746] opened
2023/05/31 20:04:21 INF [RTSP] [conn <IP_ADDRESS>:59746] closed (no one is publishing to path 'inference_2')

Did you attach a network dump?

no

Hello, RTSP has multiple subprotocols, and the default one (UDP) doesn't work when there's a NAT/firewall between server and clients. A Kubernetes service acts as a NAT between the server pod and the clients, since it has a dedicated IP.
Set TCP as the default transport protocol:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: rtsp-server
  namespace: bare
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      io.kompose.service: rtsp-server
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      labels:
        io.kompose.network/edge-bare-edge-network: "true"
        io.kompose.service: rtsp-server
    spec:
      containers:
      - image: harbor10165.senode.dev/sgs/simple-rtsp-server
        imagePullPolicy: IfNotPresent
        name: rtsp-server
        ports:
        - containerPort: 8554
          protocol: TCP
        resources:
          limits:
            cpu: "1"
            memory: "1073741824"
        env:
        - name: MTX_PROTOCOLS
          value: tcp
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30

Alternatively you can replace the Deployment with a StatefulSet, make the service Headless and publish to rtsp-server-0.rtsp-service-tcp. In this way, the service doesn't perform any load balancing, doesn't act as NAT and you can use UDP.

I tried forcing TCP connection only as per above using the latest release of rtsp-simple-server. It fails to create create a connection:
kubectl logs -f -n bare rtsp-server-5898dcfd5f-8pgwl
2023/06/05 17:20:43 INF MediaMTX / rtsp-simple-server v0.23.4
2023/06/05 17:20:43 INF [RTSP] listener opened on :8554 (TCP)
2023/06/05 17:20:43 INF [RTMP] listener opened on :1935
2023/06/05 17:20:43 INF [HLS] listener opened on :8888
2023/06/05 17:20:43 INF [WebRTC] listener opened on :8889 (HTTP)

2023/06/05 17:21:47 INF [RTSP] [conn <IP_ADDRESS>:45392] opened
2023/06/05 17:21:47 INF [RTSP] [session 7f83351b] created by <IP_ADDRESS>:45392
2023/06/05 17:21:47 INF [RTSP] [conn <IP_ADDRESS>:45392] closed (EOF)
2023/06/05 17:21:47 INF [RTSP] [session 7f83351b] destroyed (not in use)

In order to debug what's happening, please post logs of the TCP-based connection with the parameter logLevel: debug.


no support for PS256

hi, can t_cose support PS256 signature verification algorithm(COSE_Sign1)? or can I get some hints to implement it.

Hi,
The design is with the intent to be able to accommodate this, but it is not there now. There is an adaptation layer for various crypto defined in t_cose_crypto.h.
The place to start is t_cose_crypto.h where the signature size constants need to be tweaked. All the keys and sigs go on the stack so adding support for an RSA algorithm will increase stack usage significantly. That will be OK unless you are on an embedded device.
Next work on t_cose_psa_crypto.c or on t_cose_openssl_crypto.c depending on which crypto lib you integrate with. You'll need to modify t_cose_crypto_pub_key_sign() and t_cose_crypto_pub_key_verify().
This won't be the easiest thing to do, but not the hardest either. The architecture of t_cose should support it.
(Sorry for the delay; had Covid)

I am planning on implementing this, assuming no one is already.
@laurencelundblade I see you've just opened PRs that are somewhat related to this, just want to check you aren't already working on it by any chance.

No one is working on it as far as I know. You work is welcome.
You can work against the master branch. The changes happening in the dev branch aren't in this area.
Thank you!


Add patient outcomes to the filters

Readmission
Kidney Failure
Ventilator minutes
Length of Stay
Death

Kidney failure and drugs usage related to blood management would be a next step to add.

I put in the performance timestamp on the risk score and outcome, each query takes about 1 second to complete. Since I request each aggregated attribute then calculate the total risk score/outcome, the whole thing would take a long time (11 seconds when there are 11 surgeons as aggregated attribute.)

@angelicalin Does the query not accept a list of patients? You have to do them one at a time?

I do input a list of patients. But it is seperated by aggregated attributes, e.g. surgeons
I guess I could just input everything in there and put each patient in the corrected aggregated attribute bin from the query result, however, we might have an issue with length of the input exceed 1000

Make pat_ids not required for the risk_score and patient_outcomes endpoints to speed up the query performance.

Just a couple pieces left, check the TODOs on #99

And some of the outcomes should only be checked intra/extra op. Send a list to Ryan to see which should go where

Tranexaminc acid and Amicar: would care most about these given either before or during surgery.
Iron and B12 would be before surgery
anticoagulants and antiplatelet drugs: want to know if they were used before surgery and (ideally) whether they were stopped in advance of the surgery (so the patient isn't unnecessarily prone to bleeding)


Test performance of several local hyspometric approaches

See discussion in PR #85. For looping the local hypsometric interpolation, should we:

create a new mask for each geometry
create a single mask with each geometry having a different mask value and looping through the mask values

Also test implementing multiprocessing/threading.


When you launch the Outlook macro, the screen goes black and there is only the mouse cursor.

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
2024-12-12.txt
✔ Expected Behavior
正常にマクロが動作する。
❌ Actual Behavior
画面が真っ暗になりマウスカーソルが動く画面のみになった
Other Software
No response

Is this related to PowerToys? /needinfo

Don't know.
The moment I started the Outlook macro, I got a black screen.
The message that was displayed when I returned from the black screen,

Related to "Desktop composition is disabled" tracking on another issue
/dup #30507


feat: drop knative validation webhook

Fixes #N/A
Description
Drops knative validation webhooks.
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

52 of 67 (77.61%)  changed or added relevant lines in 2 files are covered.
19 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.3%) to 78.423%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/nodepool_validation.go
28
35
80.0%

pkg/apis/v1/nodeclaim_validation.go
24
32
75.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/scheduling/requirements.go
2
98.01%

pkg/apis/v1/nodepool_validation.go
2
74.14%

pkg/apis/v1/nodeclaim_validation.go
7
73.63%

pkg/apis/v1/nodepool.go
8
58.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
8556

Relevant Lines:
10910

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

52 of 67 (77.61%)  changed or added relevant lines in 2 files are covered.
19 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.2%) to 78.452%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/nodepool_validation.go
28
35
80.0%

pkg/apis/v1/nodeclaim_validation.go
24
32
75.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/nodepool_validation.go
2
74.14%

pkg/controllers/node/termination/terminator/eviction.go
2
89.09%

pkg/apis/v1/nodeclaim_validation.go
7
73.63%

pkg/apis/v1/nodepool.go
8
58.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8556

Relevant Lines:
10906

💛  - Coveralls


Try GitHub CodeQL

No thanks, I'm just looking.

Hey @thirtytwobits what do you make of this?
https://github.com/OpenCyphal/libcanard/security/code-scanning?query=is%3Aopen+pr%3A214
I am yet to enable AUTOSAR scanning but so far it does not look too promising. There is no built-in method for narrowing the scope of analysis to the production code only; thankfully, an external tool is available for this, but its interface is a bit rough. Of the 21 issues reported after the filtering, all are false-positives, of which there are two kinds:

Local address escape resulting in a dangling pointer. This is presumably coming from test cases that register stack-allocated sessions with the library (hence the escape) but then diligently unregister them (hence the escape is prevented). Neither the Sonar scanner nor clang-tidy report issues here.

The unused static function warnings come from partial test builds, where each build tests only a subset of the library's functionality. I am yet to find ways to coalesce the usage data from different builds into a single report (I suspect it is not possible).

So far I am inclined to pass on CodeQL and perhaps revisit it a year later.


publish official builds on nuget

Overt at https://www.nuget.org/packages?q=bouncycastle there is a slew of 3rd party packages, but nothing from the BouncyCastle devs themselves, and the fips libraries seem to be absent as well.
It would be really good to have official releases on nuget.

This package https://www.nuget.org/packages/BouncyCastle/ is from Peter Dettman. He is a BouncyCastle developer, so not quite true that there is nothing from BouncyCastle devs.

That package is not currently built by the team and Peter is no longer listed as a package owner on that package.

It would be nice for the latest versions to be placed on nuget by "Bouncy Castle Project Contributors". I see that v1.8.9 is available on nuget, but v1.9.0 has been out since 17th October 2021 and is still not posted on nuget

https://www.nuget.org/packages/BouncyCastle.Cryptography is now available, published directly by us (Legion of the Bouncy Castle Inc.).


[1pt] Inconsistent discharge in hydroTable.csv

A few HUC8s are producing inconsistent discharge in hydroTable.csv
Current behavior
Slight deviations of CSI for HUCs 12020002, 12060102, 11140104, 13020101 are observed between different runs of the current dev branch (faf2237). It seems to be related to inconsistent discharge values in the hydro table.
Update: flowdircond catchhydrogeo outputs
Comparing two runs of 11140104 and 13020101 on dev branch (faf2237) I observed a slight difference in the mean and standard deviation of the slope grids produced from taudem flowdircond, but it is very small (5 decimal places).
Using gdalcompare I confirmed that the input rasters to catchhydrogeo are all exact between runs except the slope grid. It uses the masked slope grid but the raster used for masking is the same as well. The resulting src_base.csv output from catchhydrogeo has inconsistent discharge values for a few specific HydroIDs. Sometimes all of the discharges will be zero and sometimes half of the stages will report zero discharge.
Overall this only seems to affect a couple HUC8s on our BLE evaluation list and the percent change in CSI for those HUC8s are within +/- 1%.

For future reference, 11110202 may also be affected.

For future reference 12110110 may also be affected

@BrianAvant-NOAA Is this still an issue?

@BradfordBates-NOAA  yes.


feat: support cargo-dinghy

cargo-dinghy is a tool which makes it easier to run the cargo tests on
phones.  With these changes the normal test suite passes on my android
phone.

dinghy-test is very naive about figuring out which environment it is on and that's the reason for the current failure.

@flub @Arqu should we get this merged and running on the test phones?

@flub @Arqu should we get this merged and running on the test phones?

I can give it a spin in the morning and see how it works. Will report back.

@Arqu what's the state here?

For whatever reason fell to the bottom of my todo. I'll pick it up in the next 24 hrs.

closing this for now.  we can always resurrect it if needed.


Allow workflow call from update licenses

Should fix this error:
https://github.com/mongodb/mongodb-atlas-kubernetes/actions/runs/10199327240
[Invalid workflow file: .github/workflows/update-licenses.yml#L56](https://github.com/mongodb/mongodb-atlas-kubernetes/actions/runs/10199327240/workflow)
error parsing called workflow
".github/workflows/update-licenses.yml"
-> "./.github/workflows/test.yml" (source branch with sha:de17e17780e38a27ffa4a527cccf15e8cb283e25)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

All Submissions:

[X] Have you signed our CLA?

Seems it would work:
https://github.com/mongodb/mongodb-atlas-kubernetes/actions/runs/10199467141


675 removed cruft left by 674

Pull Request Overview

Old APIs removed as no longer used by frontend
validity test restored

Review Notes

a few nasties had been left in t allow both the old and new APIs towork in 674 so that the integ tests would pass before the frontend was updated.
Frontend is now updated so these nasties need to be removed

/rebase

/rebase

/rebase


Pre-commit permission

git commit -s -m "create_probe:add api"

hint: The '.git/hooks/pre-commit' hook was ignored because it's not set as executable.

hint: You can disable this warning with `git config advice.ignoredHook false`.

might have to make changes in the commit in the recently add pre-commit hook script to give the necessary permission in the script itself.

@shivam-Purohit I made some changes within the script

By adding chmod +x "$0" to the script, it now has the necessary permissions to run. This change ensures that the script will be executed before each commit
Are these changes correct?

@andoriyaprashant I think this should work. If you have tested this, you are welcomed to open a pr for the same. Thank you!

@shivam-Purohit please review my pull request #239


save a draft while you are typing the post

This only saves the text for now.
We can try to add the note options like pools later.
This also doesn't save the note you are replying to so if the app crashed while you are replying some note you have to go back to that note.
Is this good for now?
cc @vitorpamplona @vicariousdrama @alltheseas

This seems like it should work fine for notes not done as a reply, though I do have a new concern.. What if something about the message text itself would cause a crash (e.g. rendering an image preview of a referenced url). Would a user be able to clear that by any means apart from wiping the data cache?

I can show a pop up before opening where you can edit the note or discard or add an option in the drawer menu. I'll try to see if I can get the reply too so you don't have to find the note and press reply again

I made a option in the drawer menu when you have a draft that only shows the text of the draft and im also saving the note you are replying to

This seems quite limited. It just works for 1 new text and 1 reply and it doesn't save which reply that was for. It also doesn't save any of the tags or added components to the text. It won't work for chats.
I kinda wanted to find a way to save the new post as an actual event (of any kind the user is creating) and save a list of those events locally only. Then in the interface, we could have a feed for drafts and drafted posts should show up as if they were real, but with a different color or sign and a button to edit or send right there.
In chat, for instance, the saved draft could be an actual message bubble at the bottom of the chat. the user can send, edit or delete the draft in the chat screen.
Same for replies. It shows in the thread with action buttons to delete, edit or send.
For new posts, they could show as a new list you can select on the top bar.
All of these require saving the actual event locally. Maybe we can save them in the usual Preferences file, but I think this might need the full DB.

Yeah I just did some basic draft to at least save something when the user is posting something to the main feed.
I think a DB will work better if we are going to keep multiple drafts and all the options

Sometimes starting small can be benefitial as long as expanding on the feature doesn't require a rewrite...

Drafted a quick NIP to get people's reactions to this new event kind: https://github.com/nostr-protocol/nips/pull/1124

Here's is how the ui is for now.
Still missing the edit on dm's and adding some validations for the user not comment, reply react to drafts.
I also need to find a good way to send only the last edit because im getting rate limited by relays if i send every time i type.
cc @vitorpamplona

Nice! The SearchScreen.SearchBar compose has a Channel that uses a 300ms debounce to search only 300ms after the user stops typing. You can actually do a 1 or 2-second debounce to avoid singing and sending all the time.

PS, do you like the new simplified mode?

Yes I'm liking the simplified mode

How is this going? We are ready to merge and release? I will release a version this week


Re-enable dynamic Code Sponsor link

Sorry for the non-squashed commit messages. I can correct this if you need me to.


ABC iView Extractor Error (KeyError: 'Playlist')

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.06.29 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Australia
Provide a description that is worded well enough to be understood
Hi, I have been using yt-dlp to download from ABC iview for months without issue. Today I have had the following error
yt-dlp.exe -v https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00 [debug] Command-line config: ['-v', 'https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version 2022.06.29 [9d339c4] (win32_exe) [debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.22000-SP0 [debug] Checking exe version: ffmpeg -bsfs [debug] Checking exe version: ffprobe -bsfs [debug] exe versions: ffmpeg git-2020-08-31-4a11a6f, ffprobe git-2020-08-31-4a11a6f [debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3 [debug] Proxy map: {} [debug] Using fake IP <IP_ADDRESS> (AU) as X-Forwarded-For [debug] [abc.net.au:iview] Extracting URL: https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00 [abc.net.au:iview] CO1710T003S00: Downloading JSON metadata ERROR: CO1710T003S00: An extractor error has occurred. (caused by KeyError('playlist')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U   File "yt_dlp\extractor\common.py", line 640, in extract   File "yt_dlp\extractor\abc.py", line 198, in _real_extract KeyError: 'playlist'
I need an account when viewing in a web browser and have for about 3 - 4 months however have been able to download through yt-dlp without any credentials up until about 2 - 3 weeks ago when I last downloaded a show. I have tried running this with my user credentials as well and still get the same error.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp.exe -vU https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00
[debug] Command-line config: ['-vU', 'https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.06.29 [9d339c4] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.22000-SP0
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg git-2020-08-31-4a11a6f, ffprobe git-2020-08-31-4a11a6f
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/download/2022.06.29/_update_spec
Latest version: 2022.06.29, Current version: 2022.06.29
yt-dlp is up to date (2022.06.29)
[debug] Using fake IP <IP_ADDRESS> (AU) as X-Forwarded-For
[debug] [abc.net.au:iview] Extracting URL: https://iview.abc.net.au/show/rosehaven/series/3/video/CO1710T003S00
[abc.net.au:iview] CO1710T003S00: Downloading JSON metadata
ERROR: CO1710T003S00: An extractor error has occurred. (caused by KeyError('playlist')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 640, in extract
  File "yt_dlp\extractor\abc.py", line 198, in _real_extract
KeyError: 'playlist'

Out of interest, are you using a VPN?

 I'm simply asking because it seems lots of iview errors are related to VPNs

Pls show verbose log adding cookies and --no-geo-bypass

@pukkandan I'll test it tomorrow, but, from past experience, I'm pretty sure that downloading abc iview videos through yt-dlp doesn't require an account

Think you may be on to it. Appears when I tried it not connected to VPN it works (starts to anyway). When I reconnected to VPN I got the following. Will play with my VPN settings and see if I can sort it out as prefer it to work when on VPN.
[debug] Command-line config: ['-v', '--no-geo-bypass', '--cookies-from-browser', 'chrome', 'https://iview.abc.net.au/video/ZW2030A001S00']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.06.29 [9d339c4] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.22000-SP0
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg git-2020-08-31-4a11a6f, ffprobe git-2020-08-31-4a11a6f
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[Cookies] Extracting cookies from chrome
[debug] Extracting cookies from: "C:\Users\craig\AppData\Local\Google\Chrome\User Data\Default\Network\Cookies"
[debug] Found local state file at "C:\Users\craig\AppData\Local\Google\Chrome\User Data\Local State"
[Cookies] Extracted 3256 cookies from chrome
[debug] cookie version breakdown: {'v10': 3256, 'other': 0, 'unencrypted': 0}
[debug] Proxy map: {}
[debug] [abc.net.au:iview] Extracting URL: https://iview.abc.net.au/video/ZW2030A001S00
[abc.net.au:iview] ZW2030A001S00: Downloading JSON metadata
ERROR: ZW2030A001S00: An extractor error has occurred. (caused by KeyError('playlist')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
File "yt_dlp\extractor\common.py", line 640, in extract
File "yt_dlp\extractor\abc.py", line 198, in _real_extract
KeyError: 'playlist'

Now working fine on a different VPN server (PrivateVPN Melbourne instead of Brisbane). Not sure why but its working so will keep this in mind for future. Thanks all for your assistance.


DPL-1015 Bed verification - support sequencing-only

User story
As a user of the scRNA Core Cell Extraction pipeline, I would like the bed verification for the LRC PBMC Bank plate to the LRC Bank Seq and LRC Bank Spare tubes to support the scenario where there is one destination sequencing rack, and NOT support the scenario where there is one destination contingency rack.
Who are the primary contacts for this story
Abby, Lesley, Katy, Andrew
Who is the nominated tester for UAT
Abby
Acceptance criteria
In the transfer from LRC PBMC Bank plate to the LRC Bank Seq and Spare tubes:

[ ] Bed verification accepts scenario where there is just one destination rack and it contains 'LRC Bank Seq' tubes
[ ] Bed verification rejects scenario where there is just one destination rack and it contains 'LRC Bank Spare' tubes
[ ] Bed verification accepts scenario where there are two destination racks, 1 containing 'LRC Bank Seq' tubes and 1 containing 'LRC Bank Spare' tubes (as currently)

Additional context
Original text from Abby:

Currently we restrict the user to only be able to upload either all contingency or a mix of both tube types. Since there have been some changes to the line (namely cell counting removal) and due to the mechanism for assigning tube purposes, we do not think there is a scenario where the user would be in a position to only upload contingency tubes. As we discussed though on Monday, there could be a niche case where the user may only have sequencing tubes. In light of this, would it be possible to please alter the tube rack scan upload to accommodate sequencing only and prevent contingency only?

sanger/#<issue_no.>

Additional context
Add any other context or screenshots about the feature request here.

PlateToTubeRacksRobot and PlateToTubeRacksBed control the bed verification for this transfer.
And robots.rb has all the config for all the bed verifications.

prepare_beds method in PlateToTubeRacksRobot performs the check in a generic way. Bed verification builds some “virtual tube racks” based on the children of the parent plate. This is created after the validation performed as part of tube rack file upload which will be covered in [DPL-1014 ]
During bed verification  checks using prepare_beds it validates what is stored in labware_store_purposes, created using the “virtual tube rack" object. So, a specific validation is not required in this context.
(https://github.com/sanger/limber/issues/1485#issuecomment-2326101482) . Therefore, it appears that there is no separate validation required in the bed verification context.
`  def prepare_beds
@relationships.each do |relationship|
relationship_children = relationship.dig('options', 'children')
labware_store_purposes = labware_store.values.map(&:purpose_name)
    bed_barcodes_to_remove =
      relationship_children.select { |barcode| labware_store_purposes.exclude?(beds[barcode].purpose) }

    delete_beds(bed_barcodes_to_remove, relationship_children)
  end
end`

Outstanding questions: (@yoldas , Please feel free to edit this if you feel appropriate)
Can they cancel the tubes that were created?
If so, how can we identify all tubes created as a batch?
These questions are significant in this context because, while looking for stored purposes, the method fetches all tubes created as part of a tube rack.
For example, if the user scans in both a Seq tube and a Contingency tube, but later changes their mind and decides to use only the Seq tube after canceling the originally created tubes, the existing code will still pick up all the tubes created in both cases. This can lead to incorrect validation results because the system will validate against all previously created tubes, even the ones that were canceled.
@KatyTaylor @yoldas It would be great to have a catchup on this.

This story did not require code changes. However, there are some bugs identified when testing this story which were encapsulated in subsequent stories. Those bugs will be addressed in the said stories.


CustomTestParameters in TestParameters.xml doesn't work

Hi all,
I met a problem these days:
I set DATA_DISK_SKU=Standard_LRS in TestParameters.xml and run .\Run-LisaV2.ps1 -ParametersFile .\TestParameters.xml, but the DATA_DISK_SKU=Standard_LRS parameter is not injected to the case.
If I run .\Run-LisaV2.ps1 -CustomTestParameters DATA_DISK_SKU=Standard_LRS , this parameter can be injected to the case.
Do you have any idea why this happened? Thanks!
.\Run-LisaV2.ps1 -XMLSecretFile .\secret.xml -ParametersFile .\TestParameters.xml
02/10/2020 05:52:59 : [INFO ] Setting parameter: CustomTestParameters = DATA_DISK_SKU=Standard_LRS
...
02/10/2020 05:53:30 : [INFO ] Collected test: STORAGE-HOT-ADD-DISK-PARALLEL from E:\LISAv2\HB39\XML\TestCases\FunctionalTests-Storage.xml
02/10/2020 05:53:30 : [INFO ] 1 Test Cases have been collected
02/10/2020 05:53:30 : [INFO ] DATA_DISK_SKU=Premium_LRS injected to case STORAGE-HOT-ADD-DISK-PARALLEL

.\Run-LisaV2.ps1 -XMLSecretFile .\secret.xml -ParametersFile .\TestParameters.xml -CustomTestParameters DATA_DISK_SKU=Standard_LRS
02/10/2020 05:54:18 : [INFO ] Setting parameter: CustomTestParameters = DATA_DISK_SKU=Standard_LRS
...
02/10/2020 05:54:49 : [INFO ] Collected test: STORAGE-HOT-ADD-DISK-PARALLEL from E:\LISAv2\SG25\XML\TestCases\FunctionalTests-Storage.xml
02/10/2020 05:54:49 : [INFO ] 1 Test Cases have been collected
02/10/2020 05:54:49 : [INFO ] Checking custom parameters ...
02/10/2020 05:54:50 : [INFO ] Custom Parameter: DATA_DISK_SKU=Premium_LRS --> Standard_LRS
02/10/2020 05:54:50 : [INFO ] Custom parameter(s) are ready to be injected along with default parameters, if any.
02/10/2020 05:54:50 : [INFO ] DATA_DISK_SKU=Standard_LRS injected to case STORAGE-HOT-ADD-DISK-PARALLEL

That is by design. -ParametersFile is designed to be a replacement of inputting the parameters of Run-Lisav2.ps1

You may need to set:
CustomTestParameters="DATA_DISK_SKU=Standard_LRS"
``` in TestParameter file

You may need to set:
CustomTestParameters="DATA_DISK_SKU=Standard_LRS"

in TestParameter file

Hi @lizzha ,
I have this line in TestParameters.xml:
DATA_DISK_SKU=Standard_LRS
The full TestParameters.xml is here: https://github.com/yuxisun1217/temp/blob/master/TestParameters.xml
But it doesn't work...

And in the log:
02/10/2020 05:52:59 : [INFO ] Setting parameter: CustomTestParameters = DATA_DISK_SKU=Standard_LRS
...
02/10/2020 05:53:30 : [INFO ] Collected test: STORAGE-HOT-ADD-DISK-PARALLEL from E:\LISAv2\HB39\XML\TestCases\FunctionalTests-Storage.xml
02/10/2020 05:53:30 : [INFO ] 1 Test Cases have been collected
02/10/2020 05:53:30 : [INFO ] DATA_DISK_SKU=Premium_LRS injected to case STORAGE-HOT-ADD-DISK-PARALLEL

Seems the CustomTestParameters = DATA_DISK_SKU=Standard_LRS is set at the very beginning, but then it is not injected in the STORAGE-HOT-ADD-DISK-PARALLEL case. I don't know why this happened...

This is the full log: https://github.com/yuxisun1217/temp/blob/master/LISAv2-Test-XR54.log
Thanks!


Root Tree State does not update

Preface: I'm not sure if this is an issue with the IPC or a feature of i3 itself but a confirmation would be nice.
If you change the attributes of a window in another workspace, the new attributes are not reflected in get_tree until that window has received focus.
Ex:
1.) Create a window in workspace 1
2.) Go to Workspace 2
3.) Open & run command in terminal 1 python shell (leave shell open)
from i3ipc import Connection
i3 = Connection()
rect = i3.get_tree().find_by_id(<id_of_wkspc1_window>).rect
print(rect.__dict__)

4.) Open & run command in terminal 2 in bash shell
i3-msg [con_id=<id_of_wkspc1_window>] resize set 75ppt 75ppt

5.) Still in workspace 2, run in terminal 1 in the same python shell
rect = i3.get_tree().find_by_id(<id_of_wkspc1_window>).rect
print(rect.__dict__)

The rect still contains the same values, even though it has been manipulated. If you now focus on workspace 1, go back to workspace 2 and rerun the same python command:
rect = i3.get_tree().find_by_id(<id_of_wkspc1_window>).rect
print(rect.__dict__)

The height and width attributes of rect are now changed.. I am thinking this might be a lazy evaluation by i3 itself rather than an issue with the IPC. But maybe I am incorrect.
I have also tried reinstantiating a new Connection instance with every run to no avail.
Any advice here would be great. Thank you!

It's very likely an issue with i3 because all the tree info is rerendered every time you call get_tree() with what the ipc gives us.
Try to reproduce the issue with i3-msg -t get_tree alone. If you do that, you can post it on the i3 tracker and it can get fixed there.

Tested it with the the raw i3-msg cli and it did indeed update. After generating both trees and seeing the difference, I reran the command with the IPC and the update did not propagate (I changed it multiple times from 400 -> 420 -> 480, but the IPC was stuck at the first run, 400, until I focused on the window, at which case, it updated to 480).
i3-msg updating the value from 400 -> 420 -> 480 (as exactly manipulated)

Image of IPC commands (reran multiple times after switching from 400 -> 420 -> 480) stuck at 400.

I wonder if I am doing something wrong, because I agree, it's simply an IPC get.. Is there a cache involved at any point? If no one else has found this bug, maybe the feature isn't too important. Up to you for consideration and let me know if the same occurs with your test.

There's no cache that I know of for this on the library side. If you want to look into the code, it's pretty simple. And there's a nice test suite too.
https://github.com/altdesktop/i3ipc-python/blob/master/test/test_window.py
I should get around to doing a triage at some point.

Awesome, I'll take a look sometime this week and can submit a pull request if I'm able to find the bug. Thanks for your help here.

I think this test illustrates the problem
https://github.com/altdesktop/i3ipc-python/blob/0ec537d405f5327b86aee09bbdb0986dc136ff8f/test/aio/test_window.py#L76-L102

Unfortunately, I've had little time to address this (and it's not a priority based on the comments for i3-grid). Feel free to close this issue and add a TODO (up to you).


retrieving static files for certain paths fails with os x 10.15 with xcode 11

environment:

os x 10.15
xcode 11
cordova 8.0.0
cordova-plugin-ionic-webview 2.3.2

behavior:
Building/bundling the app works, but at runtime any static files that are located in
AppData/Library/files/data/assets

cannot be found and a 404 is returned.
However, files located in
AppData/Library/files/data/scripts

can be loaded just fine.
Example
bundled folder structure
AppData/
  Library/
    files/
      data/
        assets/
          vendor.js
          bundle.js
        scripts/
          index.js

html
<!-- works fine -->
<script src="index.js" />

<!-- returns 404 -->
<script src="/../assets/vendor.js" />

<!-- returns 404 -->
<script src="localhost:8080/var/mobile/Containers/Data/Application/<id>/Library/files/data/assets/vendor.js" />

The exact same file structure works fine when I was building with the following:

os x 10.13
xcode 10
cordova 8.0.0
cordova-plugin-ionic-webview 2.3.2

I'm having difficulty tracking down which library this problem is originating from. Any help is appreciated.

can you provide a sample project where it can be reproduced?

no sorry, fixed the issue though. I just needed to use window.Ionic.WebView.convertFileSrc after cordova appended the correct build id to the url


Add {TRADE}: {Polytrade (PoS)}

[X] I understand that token listing is not required to use the Polygon Wallet with a token.

Please provide the following information for your token.
Token Name: Polytrade (PoS)
Token Symbol: TRADE
Decimals: 18
Polygon Address: 0x692AC1e363ae34b6B489148152b12e2785a3d8d6
Ethereum Address: 0x6e5970dbd6fc7eb1f29c6d2edf2bc4c36124c0c1
Logo URI: polytrade.png
Project Name: Polytrade
Project Summary: Polytrade brings safe and insurance backed real world assets to crypto world. We will provide real world borrowers access to low interest and swift financing to free up critical working capital, tapped from crypto lenders.
Project Contact<EMAIL_ADDRESS>Project Website: Polytrade.finance
Mainnet/Testnet: Mainnet
Additonal Notes:

Included in AllTokens v1.2.0.


Modified Connection class

[REVERTED] getStatusCodeReply() is exact same of getBinaryBulkReply() + getBulkReply(). Removed redundant codes and reused codes there.

Reverted because Redis defined Simple Strings (StatusCode) and Bulk Strings differently. IMHO, though codes in Connection class look repeated, as long as Redis is keeping those separated, Jedis should keep implementations separated.

flush() was missing in getRawObjectMultiBulkReply(). It is added there. Also getObjectMultiBulkReply() just call getRawObjectMultiBulkReply(). So flush() is removed from getObjectMultiBulkReply() as it is already added in getRawObjectMultiBulkReply().

LGTM. @marcosnils Please review this as well.

@HeartSaVioR My bad. Please check again.

Merged into master, 2.10, 2.9.

FWIW - this change means that there is no way to safely synchronize subscription clients. When any attempt to synchronously send a message to subscribe can be interleaved with a flush resulting from a message having been received, protocol desynchronization can occur.


Edit hour and minute in a MODAL

I have an input linked to the flatpicker inside a Modal and when I display the calendar with enabletime set to true, I cannot edit in the hour or minute box. However, I can edit it when my input is on the page (outside of MODAL)

I've got the same issue, did you solve it ?
Thanks.

Currently experiencing this one too. Any solutions?

NVM. Manage to find a fix for this from another issue open.
          document.addEventListener('focusin', (e) => {
                if (e.target.closest(".flatpickr-time") !== null) {
                    e.stopImmediatePropagation();
                }
            });

+1


mitch broken on light mode

On dark themes it renders fine but its a problem with light themes..

As long as its fixable in the code so i may be able to do...

Ok so changing it to the default foreground fixes everything

fixed..


add alternative term to http://purl.obolibrary.org/obo/OMRSE_00000086

Please add "human organizational role" as an alternative term. This is needed for work on OOSTT and the CAFE project.

OMRSE_0000086 is 'human role within an organization'


Fix replacement string in the guest's zkvm dependency in case of no-std

Currently cargo-risczero --nostd doesn't replace the "risc0_feature_std" placeholder, leading to the following snippet in guest/Cargo.toml, which doesn't compile.
[dependencies]
risc0-zkvm = { version = "1.0.1", default-features = false{{ risc0_feature_std }} }

It seems that our CI didn't catch this, we should probably add more tests to get better coverage (@risc0/platform)

It seems that our CI didn't catch this, we should probably add more tests to get better coverage (@risc0/platform)

yeah - I'll add a case that exercises no-std


Parse field arguments from IR and supply to generated mapper fields

We need field arguments to properly generate cache-keys for fields in a normalized cache. These field arguments need to have variable values resoled at run-time.
Simple Example of IR arguments:
	"source": "query TestQuery($episode: Episode, $includeName: Boolean!) {\n  hero(episode: $episode) {\n    __typename\n    name @include(if: $includeName)\n  }\n  human(id: \"1000\") {\n    __typename\n    name\n    height(unit: FOOT)\n  }\n}",
			"fields": [
				{
					"responseName": "hero",
					"fieldName": "hero",
					"type": "Character",
					"args": [
						{
							"name": "episode",
							"value": {
								"kind": "Variable",
								"variableName": "episode"
							}
						}
					],
					"fields": [
						{
							"responseName": "name",
							"fieldName": "name",
							"type": "String!",
							"isConditional": true
						}
					],
					"fragmentSpreads": [],
					"inlineFragments": []
				},
				{
					"responseName": "human",
					"fieldName": "human",
					"type": "Human",
					"args": [
						{
							"name": "id",
							"value": "1000"
						}
					],
					"fields": [
						{
							"responseName": "name",
							"fieldName": "name",
							"type": "String!"
						},
						{
							"responseName": "height",
							"fieldName": "height",
							"type": "Float",
							"args": [
								{
									"name": "unit",
									"value": "FOOT"
								}
							]
						}
					],
					"fragmentSpreads": [],
					"inlineFragments": []
				}
			],
			"fragmentsReferenced": []
		}
	],

However, per the graphql spec, arguments can nest. Therefore, a variable could be buried at the bottom of a long argument chain.
More Complex example:
"source": "query ComplexArguments($stars: Int!) {\n  author(input: {thoughts: \"yeah\", input: {stars: $stars}}) {\n    __typename\n    id\n  }\n}",
			"fields": [
				{
					"responseName": "author",
					"fieldName": "author",
					"type": "User",
					"args": [
						{
							"name": "input",
							"value": {
								"thoughts": "yeah",
								"input": {
									"stars": {
										"kind": "Variable",
										"variableName": "stars"
									}
								}
							}
						}
					],
					"fields": [
						{
							"responseName": "id",
							"fieldName": "id",
							"type": "Int!"
						}
					],
					"fragmentSpreads": [],
					"inlineFragments": []
				}
			],
			"fragmentsReferenced": []
		}

Anytime we see an object of the structure { "kind": "Variable", {"variableName": "stars"} } we will want substitute the run-time variable value.

For the variable resolution I see two options:

Pass the IR Map as-is as the "arguments" on Field, and have the Reader resolve the variables before they are needed to generate the cache-key.

I don't see much value in processing the IR value during code-gen in this case, as it already encodes the information will need in a sane manner. I would suggest just a one-one mapping to a Java Map.

Follow the iOS approach

 public init(reader: GraphQLResultReader) throws {
      createReview = try reader.optionalValue(for: Field(responseName: "createReview", arguments: ["episode": reader.variables["episode"], "review": reader.variables["review"]]))
    }

where the generated code holds the dynamic mapping logic of accessing the reader's variables.
Option (2) would require moving a Mapper's fields to a variable inside  the map function (which is essentially equivalent to the init function in the iOS code).
If moving the fields is a viable option, my preference would be for (2), barring everything else being equal, similarity across clients is a plus.

@sav007 Did a little more investigation into the issue we talked about earlier today.

I would go with option 1 as it requires a little changes to how our Field read from response. With option 2, it requires drastically changes on how we generate Mappers plus streaming parsing is not possible anymore. I still want to make streaming parsing work for fragments, have some thoughts.

Plus I have some thoughts about how to make ResponseJsonStreamReader to work with cache.
How about this: in com.apollographql.android.converter.ResponseJsonStreamReader#read we accumulate values for fields in Map. And when we finish reading we can call Cache.store(map).
For Field objects we will return com.apollographql.android.converter.ResponseJsonStreamReader#nextObject not only the object value but cache key that we can use to make reference in parent object.


How to use MixMatch with custom dataset?

Do you have plans to make this repository compatible with a custom dataset, and if not, which files would need to be modified to do so?
Additionally, were the tfrecords generated using the standard generate scripts present in the tensorflow library (ex: generate_cifar10_tfrecords.py from tensorflow/models/blob/master/tutorials/image/cifar10_estimator/) ?
Generally speaking, I noticed that the mechanisms for loading the dataset (libml/data_pair.py, libml/data.py), augmenting the dataset, and performing evaluations would have to be changed to accommodate for a different dataset.

No I don't have plans to change this repository, basically it's designed to reproduce the results from the paper. The reason it is on GitHub, beyond making our results easily reproducible, is so that anyone can fork it, make it better, etc...
Adding datasets should relatively easy, the datasets are created in https://github.com/google-research/mixmatch/blob/master/scripts/create_datasets.py
The data is stored in a tfrecord file, and the records are tf.Example entries (save the save functions)
image: <byte string of png encoded image>
label: <int64 the label id>

Then, you as you already discovered, just hook the dataset to data.py and data_pair.py. There is nothing really special here except specifying the image size and the number of classes. You can reuse one of the basic augmentations or customize one to your needs.

Thanks for that info! I'll give it a try and let you know if I'm able to successfully apply it to my dataset.
Regarding the fully supervised baselines presented in the paper, are there ways to replicate those as well? If that functionality exists in the repo, I would interested in applying that to my dataset as well.

Yes the fully supervised baselines are in the fully_supervised folder, and to reproduce the tables in the paper checks the script(s) in fully_supervised/runs.


Question about the rgb-runtime

Here,

For this code, what's the idea of importing bp-wallet runtime? Do we need to use bp-wallet instead of bdk wallet? (Include construct psbt, sign psbt, and so on)

I wrote this code

to load the runtime. First, I create data0/testnet directory, then I execute this code, the error print out(I want to use rgb runime to import rgb contract in command line):

In the bp-wallet, the path should be
data0/testnet/descriptor.toml
data0/testnet/data.toml
I don't know whether I missed some steps.

RGB wallet is the RGB+wallet solution we provide by default. You are not required to use it, RGB std is enough - but you would need to integrate it with the wallet of your choice (like BDK) by yourself.
From our experience you can't get BDK to work with tapret commitments, thus we had to develop BP wallet and use it here.
Regarding your error, can you replicate what we do in rgb:
https://github.com/RGB-WG/rgb/blob/a773b7dd45ef6341b7c337e864871e8dfb4be542/cli/src/args.rs#L72-L76
This creates all necessary directories, files etc. Do not create them manually.

So, in your words, for the tapret commitment, the next step we need to implement is how to sign psbt, and how to extract a transaction from psbt with bp-wallet, right? (Just like BDK does)

You can sign PSBT with any PSBT signer made in any language (not even Rust) - even like Sparrow wallet. Tapret doesn't affect the signing part.


Fix image constructor argument handling

Before, it would always set icon_state to the corresponding argument even if icon_state was set by loc. Now, it properly skips it.

Closing in favor of #1627


Inequality tests

PR to solve #959

Hi @raphaeltimbo! I've just made the changes as you requested. This is what you had in mind?


Run installer without sudo

🙋 feature request

This install script should be able to be run without using sudo permissions
🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

Don't write to files that require elevated privileges, I think right now it's just the log files, put them in the directory of the project
🔦 Context

💻 Examples

@gabel0287 , This feature will be out in our next release.

@gabel0287 , Since docker command execution needs sudo access we cannot get this done from the installer side.
Alternative solution is grant docker command execution from normal user. How to document is mentioned below
https://docs.docker.com/install/linux/linux-postinstall/


Extension not supported in new code view mode

The recently implemented new code view completely breaks the extension's functionality
Currently the mode is in feature-preview, so probably not a top-priority

How this repository currently appears with the feature enabled

@Claudiohbsantos Yes, it's true. I just wanted to create an issue ticket but it exists :D

@Claudiohbsantos I can take a stab at this one if you like.  I already tried it out a bit because I was curious, and I've noticed it has the same issue Azure did, where directly replacing the icon element breaks the page. This happens because React is trying to replace the previous svg element with new ones as you navigate through the directories. Which results in this being displayed:

and this error in the console:
DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

I believe I have a solution for it, similar to how I solved the problem with Azure. Instead of actually replacing the icon, I tried appending the new icon as a sibling of the old one and adding styles to hide the original icon. This appears to work pretty well, but I need to figure out a couple edge cases and make sure nothing else is broken by these changes.
As a side note, I did not have to add the custom mutation observer in order to make this work, so this should be simpler than the Azure provider at least.

Oh no! The dreaded day when github changes their DOM and breaks everything has finally arrived 😱  To be honest I'm very surprised it has taken this long for this to come up hahaha
Thanks @csandman  I'll take a look at the new github code view and will follow up on your PR once I understand the problem a bit better.

https://github.com/homerchen19/github-file-icons/pull/134
This might help

@Claudiohbsantos Any updates on this so far?

I took the liberty of applying #56 (and #59) to current HEAD (ff97e509806357721fb89dc83593ad1a05f5426a) and build a patched version of the extension. You are welcome to sideload it before a proper fix is released.
All credits go to @csandman.
By using my build you trust me even though I'm a random person on the Internet. If you don't you should build it yourself, it's really simple.
github-material-icons-chrome-extension.zip
github-material-icons-edge-extension.zip
github-material-icons-firefox-extension.zip
Side note: if you are also a Refined GitHub user you should disable the quick-file-edit feature as it's currently incompatible.

Thanks for making a build available @kidonng ! I just managed to work my way through the PRs and this has now been merged. I'll kick off a release in a sec, it should be up in the stores asap


No activity is captured in AI

I am testing this new interesting feature but with no result.
I have an AKS cluster with ISTIO deployed.
I can see in the telemetry log this:
2019-05-13T09:31:18.238380Z	info	grpcAdapter	Connected to: application-insights-istio-mixer-adapter-service.istio-system:6789
2019-05-13T09:31:18.238559Z	info	ccResolverWrapper: sending new addresses to cc: [{application-insights-istio-mixer-adapter-service.istio-system:6789 0  <nil>}]
I can see the traffic in the telemetry log as well.
In the AI, I can see the instance server name (in the live metrics stream) but CPU Total is N/A
I don't see anything in Application Map.
I came through all troubleshooting task with no result.
AKS is 1.10.13 version.
ISTIO is 1.0.4
So you have any idea?
Is there any bugs or I still missing something?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31fa6bb5-4bc3-8e4d-e308-893e63d1f61a
Version Independent ID: a228fbc5-3b98-02a5-bd89-7262886881cd
Content: Azure Monitor - Zero instrumentation application monitoring for Kubernetes hosted applications
Content Source: articles/azure-monitor/app/kubernetes.md
Service: application-insights
GitHub Login: @tokaplan
Microsoft Alias: alkaplan

@ripom Thanks for the comment! We will investigate this issue and get back to you soon.

In the TRACE log of application-insights-istio-mixer-adapter I have this log.
What does it means SKIPPED?
2019/05/13 13:57:16.086|TRACE|source: myapp-v1-669d45bcf8-jrgsg.location, destination: unknown.unknown, reporter: kubernetes://myapp-669d45bcf8-jrgsg.location, kind: outbound
2019/05/13 13:57:16.086|TRACE|SKIPPED

@rishabjolly

Thanks for reaching out @ripom.
I'll setup a troubleshooting call for us. What's a good a alias to reach out to you?

Hi @rishabjolly
You can connect with me using<EMAIL_ADDRESS>SFB or MS Teams call is fine, please send me an invitation.
Consider I am based in UK.
Thanks

@ripom It looks like the appropriate contact information has been exchanged, and there's nothing left to be addressed from a documentation standpoint.  If you need any help troubleshooting issues, please feel free to reach out to us on MSDN or Stack Overflow:
https://social.msdn.microsoft.com/Forums/vstudio/en-US/home?forum=ApplicationInsights
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


tests.py: added import latin_models_cltk

Fixes failed travis build. POSTag was being tested without importing the greek_models_cltk corpus

Reference to conversation regarding failed build: https://github.com/cltk/cltk_api/pull/31#issuecomment-205026677
Should I make a PR to update tests.py in the master branch as well ?

Good work. Everytime you run into a problem, think of it as an opportunity for us to improve the docs :)


Expand on statement

"Because certain objects have a default containment setting of NONE, this view can return false positives." What is this about? What is "false positives?". Is your software incorrect?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e6334ee2-0f75-c3ee-aae7-4b4e6357aa84
Version Independent ID: 2750b453-0f24-c180-dff2-9040fb531c8a
Content: Contained Databases - SQL Server
Content Source: docs/relational-databases/databases/contained-databases.md
Product: sql
Technology: configuration
GitHub Login: @stevestein
Microsoft Alias: sstein

@stevestein Hi Steve, this Issue 2230 is now assigned to you.
In dpmds, no name like 'contain' is found.  Perhaps you can clarify what the phrase "false positives" is intended to mean in this usage.

@rbonomo - Thanks for raising this issue. I'm looking into the details and will reply when I

@rbonomo - I couldn't track down a specific example, but as the note says: certain objects have a default containment setting of NONE  - so in this case, if the object is in a contained database, it can appear in the results of the uncontained entities view.
Hope that helps.