chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-landing-zone
module
minor
v5.21.1 -> v5.24.3

terraform-ibm-modules/base-ocp-vpc/ibm (source)
module
minor
3.23.0 -> 3.25.0

Release Notes

terraform-ibm-modules/terraform-ibm-landing-zone (github.com/terraform-ibm-modules/terraform-ibm-landing-zone)
v5.24.3
Compare Source
Bug Fixes

landing zone configuration tool updates (#801) (d1c8359)

v5.24.2
Compare Source
Bug Fixes

deps: update landing-zone-vsi to 3.3.0 and landing-zone-vpc to 7.18.2 (#771) (5978ff9)

v5.24.1
Compare Source
Bug Fixes

update version.tf in roks quickstart to allow tf 1.6 (#805) (c4a7972)

v5.24.0
Compare Source
Features

expose DNS options in the vpc variable of the root level module (#795) (18af306)

v5.23.0
Compare Source
Features

expose the ability to force delete storage created by cluster. It defaults to false, however the OCP Quickstart flavor sets to true (#790) (32a6820)

v5.22.2
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the landing zone das (#762) (6a07e7b)

v5.22.1
Compare Source
Bug Fixes

vpc_data output var has complete output on first apply. (#789)  - fix for vpc_data: output var in patterns vsi module does not give complete output on first apply. (9145c0c)

v5.22.0
Compare Source
Features

added support for OCP 4.15. This is now the default cluster version deployed (#782) (d650a00)

v5.21.3
Compare Source
Bug Fixes

update the default VSI image name to ibm-ubuntu-24-04-minimal-amd64-1 (#781) (99137d2)

v5.21.2
Compare Source
Bug Fixes

remove duplicate kms_config from OCP quickstart override json (#778) (ceca4eb)

terraform-ibm-modules/terraform-ibm-base-ocp-vpc (terraform-ibm-modules/base-ocp-vpc/ibm)
v3.25.0
Compare Source
Features

added support to specify the worker node operating system using new input variable operating_system (#436) (cb1b819)

v3.24.2
Compare Source
Bug Fixes

deps: update terraform-module (#440) (5c128c8)

v3.24.1
Compare Source
Bug Fixes

deps: update terraform-module (#439) (c850e8a)

v3.24.0
Compare Source
Features

add wait_for_apply option in kms_config object input variable (default value is true) (#437) (36384fa)

v3.23.2
Compare Source
Bug Fixes

deps: update terraform-module (#412) (e17aa4e)

v3.23.1
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cos/ibm to v8 (#434) (d90b8ed)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

https://github.com/terraform-ibm-modules/terraform-ibm-websphere-liberty-operator/pull/69 needs to be merged first before we can trigger pipeline

/run pipeline

/run pipeline

Test failed with this:
│ Error: local-exec provisioner error
│
│   with module.websphere_liberty_operator.helm_release.websphere_liberty_operator,
│   on ../../main.tf line 165, in resource "helm_release" "websphere_liberty_operator":
│  165:   provisioner "local-exec" {
│
│ Error running command '../../scripts/approve-install-plan.sh
│ openshift-operators': exit status 1. Output: Waiting for installplan
│ ibm-websphere-liberty (900s timeout)...
│ Error: Install plan for ibm-websphere-liberty was not found (namespace:
│ openshift-operators)
│ Grabbing some debug info...
│
│ kubectl get pods -n openshift-marketplace -o wide
│ NAME                                    READY   STATUS    RESTARTS   AGE
│ IP              NODE          NOMINATED NODE   READINESS GATES
│ certified-operators-t6smr               1/1     Running   0          27m
│ <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
│ community-operators-smjsl               1/1     Running   0          27m
│ <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
│ ibm-operator-catalog-cvcrk              1/1     Running   0          16m
│ <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
│ marketplace-operator-7cb576cb98-c59zt   1/1     Running   0          34m
│ <IP_ADDRESS>     <IP_ADDRESS>    <none>           <none>
│ redhat-marketplace-zjjp6                1/1     Running   0          27m
│ <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
│ redhat-operators-ztczk                  1/1     Running   0          16m
│ <IP_ADDRESS>   <IP_ADDRESS>   <none>           <none>
│
│ kubectl get installplan -n openshift-operators
│ No resources found in openshift-operators namespace.
│
│ kubectl get subscription ibm-websphere-liberty -n openshift-operators
│ NAME                    PACKAGE                 SOURCE
│ CHANNEL
│ ibm-websphere-liberty   ibm-websphere-liberty   ibm-operator-catalog
│
╵}

Same issue:
│ Error: Install plan for ibm-websphere-liberty was not found (namespace:
│ openshift-operators)

@vbontempi might need you to take a look?

/run pipeline

/run pipeline

/run pipeline

Blocked due to known issue that is being debugged with IBM Cloud support

/run pipeline

The blocker should be resolved for newly created VPCs, so re-running test

The following delete was identified, but this is expected and no impact to module itself. Skipping upgrade test:
        	Messages:   	Resource(s) identified to be destroyed
        	            	Name: resource_key_existing_serviceid_crn
        	            	Address: module.ocp_base.module.cos_instance[0].terraform_data.resource_key_existing_serviceid_crn
        	            	Actions: [delete]

/run pipeline

:tada: This PR is included in version 1.4.9 :tada:
The release is available on:

GitHub release
v1.4.9

Your semantic-release bot :package::rocket:


different definition of std::function

This definition of std::function found in database.hpp is causing problems when you include <functional> and xxsqlite in the same project, IMHO we should include <functional> in that header.
This is the offending definition:
namespace std {
    template<class T> class function;
}   // namespace std

see here: https://github.com/nogden/xxsqlite/blob/master/src/database.hpp#L28

I've just pushed a commit making this change.
It turns out that opening the std namespace is not allowed anyway, so this way always an error. Thanks for reporting this.


Convert response body to Stream

Right now, there is no "direct" way to consume a response body as a Stream<Item = Result<Bytes>>. IMO this would be a good thing (either via some into_stream function, or a direct impl, like in 0.9). I went ahead and made the existing into_stream in Body public, but this also requires to make ImplStream public, which is probably suboptimal.
Related: How about enabling the stream feature by default,  just as it is done in hyper 0.13?

You can make a stream in a slightly round-about way with:
async fn next_chunk(mut response: reqwest::Response) -> Option<(Result<bytes::Bytes, reqwest::Error>, reqwest::Response)> {
	let chunk = response.chunk().await;
	let chunk = chunk.transpose()?;
	Some((chunk, response))
}

let body = futures_util::stream::unfold(response, next_chunk);

But yes, it would be easier if it was just an into_stream on Response itself.

Yeah, that's why I wrote that there is no "direct" way. Your solution has a minor drawback: body is lifetime-constrained by response, so if you want to return body from a function (for e.g. some function async fn(url: &str) -> Result<impl Stream<Item = Result<Bytes>>>), it is not easily possible without sth like owning_ref.
Another way is to use async-stream which does not have this problems, but instead you occasionally get weird compiler errors (see e.g. here).

Yeah, I switched from the unfold method to async-stream for my own stuff too.

@seanmonstar is this issue is something you would consider before releasing reqwest? Ability to "take" body as a stream is the only missing feature for us at Deno in regard to updating reqwest.

What if we added Response::into_stream(self) -> impl Stream<Item = crate::Result<Bytes>>?

What if we added Response::into_stream(self) -> impl Stream<Item = crate::Result<Bytes>>?

That'd be perfect!


IFX-Table: Selectable Text

Detailed description of what you want to happen
Allow the selection of text in table columns via enableCellTextSelection  options property.
Upload a screenshot or reference an example if possible
No response
Why do you need this feature?
Selecting text and copying is very usefull for sharing with others and other interaction.
Do you have a deadline?
no
Additional information
ag-grid provides the option enableCellTextSelection see here

Your issue has been approved! You can follow the latest status on our public backlog board. Thank you for your contribution!


[RFC] Implement cpu and memory profiling

cpu profiling happens continuously.
memory profiling happens when lxd receives a SIGUSR1.
Signed-off-by: Serge Hallyn<EMAIL_ADDRESS>

Any chance we can get a test for this?


Feature: support for remote port forwarding

This pull request implements feature request from #10.

Hey @stankovic-marko, good job! Thank you!
I will take a look into it before merging. But at a first glance, we will be breaking existing code by adding a new parameter to New function. Maybe we should add a new function NewRemote instead of passing the ForwardType to keep it backwards compatible (or maybe using variadic parameter, or just a method SetRemoteForwarding on the SSHTun).
Also we should support unix sockets (this should be easily done without affecting forwarding logic).
If you feel like doing it, perfect. Otherwise I will merge your PR into an intermediate branch and work from there!

Hello @rgzr, thank you for your response!
I agree with everything you said, there are some things I overlooked. These things will be addressed in my next commit.

Thank you very much for reviewing! Sorry for not polishing before submitting a PR, I implemented this a while ago and forgot what else needed to be done...

Don't worry, thank you for your contribution! I merged it to an intermediate branch removing the changes of the connection close issues and will address that problem in another PR.


API delegering - Maskinporten link doesnt open in a new tab

Open delegaions overview page
Click on link to Maskinporten - this opens in same tab
In the API delegering panel, these links opens in a new tab.
Perhaps it should be the same here as well

Yeah it's a one liner, I'll add it the PR fixing refresh token url

@anishastphen Deployed this some minutes ago, I put this back to test 😊

testet OK


Web: task completion (depends on #108)

User Story
As a web user completing a task,
I want to see confetti on the screen and have my points incremented as a reward for finishing the task,
So that I feel a sense of accomplishment and motivation to continue using the application.
Acceptance Criteria

[ ] Implement functionality to display confetti animation on the screen upon task completion.
[ ] Update user points upon completing a task, increasing the points by a specified amount.
[ ] Ensure that the confetti animation and points incrementation are triggered only upon successful completion of a task.
[ ] Test the functionality to verify that confetti animation appears and points are incremented upon completing a task.
[ ] Verify that the points are accurately incremented and reflected in the user's account.
[ ] Document any changes made to the codebase for future reference.

Related Issues

#108

Notes

Adding visual feedback such as confetti animation and rewarding users with points can enhance user engagement and satisfaction.
Collaborate with frontend developers to ensure proper integration of the confetti animation and points incrementation.

Tasks

[ ] Implement functionality to display confetti animation upon task completion.
[ ] Update user points upon completing a task, increasing the points by a specified amount.
[ ] Test the functionality to verify accurate triggering of confetti animation and points incrementation.
[ ] Ensure points are accurately incremented and reflected in the user's account.
[ ] Document any changes made to the codebase.

Suggested layout

Completed on web side.


Broken Scrutinizer tests

Q
A

Issue Type
Bug

Deployer Version
N/A

Local Machine OS
N/A

Remote Machine OS
N/A

Description
Need to configure Scrutinizer phpunit properly (check Scrutinizer's recommendation).
Examples

https://scrutinizer-ci.com/g/deployphp/deployer/inspections/f6fb6889-6726-4b81-b7df-2f12be6924c9
https://scrutinizer-ci.com/g/deployphp/deployer/inspections/4eca1b94-31e1-4933-a3f9-00570925a398

Lately, there are a lot of issues with Scrutinizer's tests. I think to moving to another tool. Do you know some alternatives?

I've used only Scrutinizer, Travis and self-hosted Jenkins. I hope that these issues are only temporary. Meanwhile it doesn't seem to be fixed hardly. Let's give Scrutinizer one more chance ;)

Fixed.
Code coverage down 56%


Exactly overlapping identical shapes caused degeneracy in GJK

The cause was a dual one: the first search vector was the zero vector, causing the support points to be the zero vector also.
The second cause was that the lines between the support points passed through the origin, which cause the search vector to again become the zero vector.
Fixes #51.

bors r+


Forge support

I really liked this mod, however, my mod list already has Forge as dep. There is the XP Tome mod, but I don't like its recipe.
Could please you make a Forge version?
Thanks!

No, I won't make a Forge version of any of my mods. However, there are also XP Tome as you mentionned and Bottle your XP. If you don't like XP Tome's craft, you can suggest the dev to change the recipe or to make it configurable. Also, my mod is open-source so anybody can port a version of my mod to Forge, but I don't plan to do it. Sorry


ClientContextFactory should not connect automatically

currently ClientContextFactory.connect() calls connect on the created client context. This should not happen

In addition ClientContextFactory.connect should be renamed to create()


Length Validator (string) causes validation failure with string length of 0

Found this interesting - since we have the NotEmpty validator, my initial expectation was that not including the NotEmpty validator would allow an empty string to pass through.
If a user types in a text box, then erases it, most client side frameworks are going to send an empty string, which causes validation to fail.  I feel like NotEmpty should be used to validate 'required' and length should not validate against an empty string.  Unless there is another way to do this?

@aschaible could you include a snippet of code and then show where it behaved differently than you expected it to? I'm having trouble visualizing what you're saying.

Absolutely and thanks for the quick reply:
`            RuleFor(customer => customer.Address1)
.NotEmpty().WithMessage("Address 1 is required.")
.Length(3, 100).WithMessage("Address 1 must be between 3 and 100 characters.");
        RuleFor(customer => customer.Address2)
            .Length(3, 100).WithMessage("Address 2 must be between 3 and 100 characters.");`

Address 1 is required, Address 2 is not.

The behaviour here is different if the string is null, vs being empty. If the string is null, then the Length validator will not execute. In this scenario, the NotNull or NotEmpty should be used to catch the null.
However, a non-null empty string does have a length, it's just zero, in which case the Length validator will execute and validation will fail, which is the intended behaviour.
Hope that makes sense

It makes sense, however it seems like this implementation provides less flexibility and an uncovered (but common) validation scenario.  Meaning if a value is supplied, it must be between a min and max.  If not supplied (or length of 0), do not validate.  The builder pattern allows you to combine multiple validators to guard against a 0 length condition, but doesn't seem to provide any mechanism to abort the length validator if the length is 0.
I added a filter to nullify empty strings - in an HTTP request, null and empty string should be treated the same.
The FluentValidation behavior is in contrast with the way AngularJS and JQuery validation works.
Just something to think about - as always thanks for building the library!

So to be clear, @aschaible, you're saying that it's potentially confusing for users because one might assume that .Length(3,100) implies .NotNull() and NotEmpty(), but in reality they'd have to think through those scenarios themselves?

I think the confusion comes because frameworks like jQuery Validate work against html elements. In the case of an input field, there is no concept of null...there's always a string value.
By contrast, FluentValidation is designed to work against properties on objects, where null and empty are different and really isn't tied to the way HTML elements work at all....MVC's validation infrastructure chooses to provide unspecified values as empty strings, rather than nulls, but because FluentValidation can be used in other contexts other than just MVC, it'd be dangerous to rely on this behaviour. I think it'd be much better to be explicit about this, which you can do by using a When clause:
RuleFor(customer => customer.Address2)
    .Length(3, 100).When(address => !string.IsNullOrEmpty(address)).WithMessage("Address 2 must be between 3 and 100 characters.");

I think that would probably be the best approach in this case.

@SeanKilleen I think in most validation libraries, at least the ones that I have used, a 'required' validator is available and is able to be combined with other built-in validators to provide the desired behavior.  The validators are designed to be very discrete and have very specific functionality that allows them to be combined in many scenarios.
In this case, I would expect NotEmpty to to fail a 0 length string (have not tried it).  If that fails a 0 length string (which it should as that would be consistent with the built in .NET libraries), then the length validator should not because then it would have an overlap in responsibility, and the NotEmpty case is covered already with the NotEmpty validator.
I don't think that validators standard validators should validate things that are available through other standard validators - not sure if that makes any sense.
It does get difficult with nullable types


xfail instead of skip

...and get rid of a deprecation warning.
Closes #45
Closes #44

Sry @sk1p I saw your PR only now!


Use id instead of order

It looks like the id property is what you're looking for. The order property does not represent the Pokedex id of the Pokemon.
Example: Squirtle's Pokedex id is 7, where the order property returns 10.

@ryannhg any thoughts on this one?

Hey, this PR makes sense– sorry for not merging sooner!

no worries


very slow

Hello rust-msbwt team,
I found that this version the build command is very slow, a 5G fastq reads take more then 2 hours and more while the ropebwt2 is very fast, several minutes. I am wondering whether this could be parallelized or something because this is not practical for real word sequence files, which are always more than 20G.
Thanks,
Jianshu

The current, built-in version does tend to be slower than the ropebwt2 approach for constructing the BWT.  This is most noticeable for short-read sequencing data, where ropebwt2 can take advantage of parallelization during some of the inserts.  The downside of this approach is that the commands to construct it are a bit more complicated and may require excess memory/disk space to do the sorting.
The msbwt2 construction is primarily meant to make the process (e.g. the commands) a bit easier for end users who may not be as CLI familiar.  We would like to make this method faster (perhaps via parallelization and/or a better algorithm), but we haven't had time to work on this.  It also may not scale as well, we haven't really tested a very large dataset yet.  Happy to review PRs from anyone wishing to do R&D on improving the method.
So in short, if you want speed, we recommend using the ropebwt2 approach.  If you want ease of use, we recommend the msbwt2 approach.


What's the different between BertScore and BertScore Art?

same question ! looking forward to author's reply !

Hello! Thanks for your question.
BertScore compares two texts, usually the generated one and the reference. BertScore Art is run using the article as reference, while BertScore is using the target summary (provided as part of the summarization dataset) as reference. In theory, using the article should be better when measuring the factuality of a generated summary since the reference might not contain some important information.
Let me know if you need more information on this.

Thanks for the answer!

Thanks. I've submitted one result using SimCSE to do the evaluation.


Support overrides of token issuer from environment variables

This pr intends to add support for overrides of issuer for token validation.
We will introduce reading the following environments from application settings of azure functions.
AuthenticationEvents__TokenIssuer_V1
AuthenticationEvents__TokenIssuer_V2
AuthenticationEvents__OIDCMetadataUrl
With the above combined with AuthenticationEvents__TenantId and AuthenticationEvents__AudienceAppId a developer can define their own application for token validation.
Example usages:
[FunctionName("onTokenIssuanceStart")]
public async static Task<AuthenticationEventResponse> Run(
    [AuthenticationEventsTrigger(
    TenantId = "00000001-0000-0000-0000-000000000000",
    AudienceAppId = "00000002-0002-0002-0002-000000000002",
    OIDCMetadataUrl= "https://login.windows.net/00000001-0000-0000-c000-000000000000/.well-known/openid-configuration",
    TokenIssuerV1 = "https://sts.windows.net/00000001-0000-0000-c000-000000000000",
    TokenIssuerV2 = "https://login.microsoftonline.com/00000001-0000-0000-c000-000000000000/v2.0")] TokenIssuanceStartRequest request, ILogger log)
{

Environment variables advance definition

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents

@hakimms Tried adding you as a reviewer but your name isn't coming up. Can you give this a review please?


EF.CompileQuery() parse failure with Count() == 1

See sample code below. I have a simple query that works fine when run uncompiled. It however fails when running compiled.
Exception message:
Cannot parse expression '({value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[Erp.Tables.GLSyst]) => Count()} == 1)' as it has an unsupported type. Only query sources (that is, expressions that implement IEnumerable) and query operators can be parsed.

Stack trace:
System.NotSupportedException: Cannot parse expression '({value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[Erp.Tables.GLSyst]) => Count()} == 1)' as it has an unsupported type. Only query sources (that is, expressions that implement IEnumerable) and query operators can be parsed. ---> System.ArgumentException: Parameter 'expression.Type' is a 'System.Boolean', which cannot be assigned to type 'System.Collections.IEnumerable'.
Parameter name: expression.Type
   at Remotion.Utilities.ArgumentUtility.CheckTypeIsAssignableFrom(String argumentName, Type actualType, Type expectedType)
   at Remotion.Linq.Parsing.Structure.IntermediateModel.MainSourceExpressionNode..ctor(String associatedIdentifier, Expression expression)
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseNonQueryOperatorExpression(Expression expression, String associatedIdentifier)
   --- End of inner exception stack trace ---
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseNonQueryOperatorExpression(Expression expression, String associatedIdentifier)
   at Remotion.Linq.Parsing.Structure.ExpressionTreeParser.ParseTree(Expression expressionTree)
   at Remotion.Linq.Parsing.Structure.QueryParser.GetParsedQuery(Expression expressionTreeRoot)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](Expression query, IQueryModelGenerator queryModelGenerator, IDatabase database, IDiagnosticsLogger`1 logger, Type contextType)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CreateCompiledQuery[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Internal.NonCapturingLazyInitializer.EnsureInitialized[TParam1,TParam2,TValue](TValue& target, TParam1 param1, TParam2 param2, Func`3 valueFactory)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryBase`2.EnsureExecutor(TContext context)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryBase`2.ExecuteCore(TContext context, CancellationToken cancellationToken, Object[] parameters)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryBase`2.ExecuteCore(TContext context, Object[] parameters)
   at Erp.Services.BO.CompanySvc.Repro(ErpContext dataContext) in C:\_Projects\ERPStaging\EFCore\Source\Server\Services\BO\Company\Company.cs:line 931
   at Erp.Services.BO.CompanySvc.ARSystAfterGetRows() in C:\_Projects\ERPStaging\EFCore\Source\Server\Services\BO\Company\Company.cs:line 864

Steps to reproduce
Execute the code below.
private static void Repro(ErpContext dataContext)
{
    // Non-compiled query works fine.
    var result1 = (from row in dataContext.GLSyst
                    select row).Count() == 1;

    // Compiled query blows up.
    Expression<Func<ErpContext, bool>> expression =
        (dataContext_ex) =>
        (from row in dataContext_ex.GLSyst
            select row).Count() == 1;

    var query = EF.CompileQuery(expression);

    var result2 = query(dataContext);
}

Further technical details
EF Core version: 2.1.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017 15.8.9

Should have mentioned that it works fine in EF6 with CompiledQuery.Compile().

@smitpatel @maumar Can you please look into workarounds for this one.

Workaround is to do do compile query on the entity count but perform comparison on the client:
                Expression<Func<MyContext, int>> expression =
                    (dataContext_ex) =>
                    (from row in dataContext_ex.GLSyst
                     select row).Count();

                var query = EF.CompileQuery(expression);

                var result2 = query(ctx) == 1;

I can confirm that the suggested workaround addresses the issue. However we have hundreds of such queries and reworking them all is quite the undertaking.

Note from triage: @smitpatel to look into different workarounds, such as a replacement for CompileQuery that will handle this case.

We found other cases that EF.CompileQuery(query) couldn't handle. For now we've disabled this and are instead using a standard expression compile: query.Compile(). There's likely a performance hit in that but CompileQuery() was holding up our migration so we had to pull the plug. We will switch back to it once the issues are addressed.

@Epic-Santiago can you remind me if you tested that you are actually getting a significant performance boost from using explicitly compiled queries with EF Core?

        public static Func<TContext, TResult> CompileQuery<TContext, TResult>(Expression<Func<TContext, TResult>> expression)
            where TContext : DbContext
        {
            var body = expression.Body;
            if (body is BinaryExpression binaryExpression
                && binaryExpression.NodeType == ExpressionType.Equal
                && binaryExpression.Right is ConstantExpression constantExpression)
            {
                var queryExpression = Expression.Lambda(binaryExpression.Left, expression.Parameters);
                var method = typeof(EF).GetMethods()
                    .Where(mi => string.Equals(mi.Name, nameof(EF.CompileQuery))
                                && mi.GetGenericArguments().Length == 2).Last();

                var compileQueryCall = Expression.Call(
                    null,
                    method.MakeGenericMethod(new[] { typeof(TContext), binaryExpression.Left.Type }),
                    queryExpression);

                return Expression.Lambda<Func<TContext, TResult>>(
                    Expression.MakeBinary(ExpressionType.Equal, Expression.Invoke(compileQueryCall, expression.Parameters), binaryExpression.Right),
                    expression.Parameters).Compile();
            }

            return EF.CompileQuery(expression);
        }

// Following works using above function
                Expression<Func<MyContext, bool>> expression = (ctx) => (from b in ctx.Blogs select b).Count() == 1;
                var query = CompileQuery(expression);

                var result = query(db);

Basically, the issue occurs when you are passing in an expression which is neither IQueryable or an operator over IQueryable. You can identify such case using pattern match and call EF.CompileQuery on part of it and use that func to generate a larger func which gives you result you want. It is somewhat advanced scenario but if all the occurrences of failures are limited to few pattern this could be easy to work-out.

I haven't yet had a chance to try out that workaround. We are running a scale lab this week and last and have been focused on that. Once that settles down I'll get a chance to review.

I see that this issue has been fixed. Thanks all for your efforts!
Looking forward to testing it. Is there a way to tell on GitHub what release this will ship with?

@Epic-Santiago - Milestone the issue is assigned to correspond to the first release when this was fixed. This issue would be working in 3.1 release.


Implemented shallow build. Solves #144

Implemented shallow build. Solves #144

Looks like this shaves off between 3 and 5 minutes per build. Guess it is something


Solution to stucking on Loading extension module cutils_...

新年快乐！这不是一个问题，我是想分享一个我遇到的问题给大家。
Thank you for providing the code. I have tried some other code but they directly install pointnet2 from a Github link, which doesn't work. But your code works for me, thank you a lot!
But I have noticed a minor problem in the code, after installing the prerequisites, the code was stuck on Loading extension module cutils_...
I am using Ubuntu 22.04, cuda 12.
I found the solution, which is to comment out lines 27 and 28
#sys.stdout = logfile
#sys.stderr = errfile
In this way, the log will not work, but the code will work.

我刚看到。感谢你的支持。然后下面那个不是bug。Loading extension module cutils_是正常输出，然后的输出被重定向到log文件了，所以看起来像卡住了。实际上按照说明在python train.py后面加个&放到后台再disown就行了。设计上是这样的。


Fabo/242 add time to transactions

Implements #242

Awesome. Thx for the inside! Will change this tomorrow!
Matt Bell<EMAIL_ADDRESS>schrieb am Di., 19. Dez. 2017, 18:23:

@mappum commented on this pull request.
In app/src/renderer/vuex/modules/wallet.js
https://github.com/cosmos/cosmos-ui/pull/259#discussion_r157835663:

 res.forEach(t => blockHeights.add(t.height))

 blockHeights.forEach(h => {

   dispatch('queryTransactionTime', h)

 })

},
async queryTransactionTime ({ commit, dispatch }, blockHeight) {

 let block = await dispatch('queryBlock', blockHeight)

 commit('setTransactionTime', { blockHeight, block })

},
async queryBlock ({ state, commit }, height) {

 let block = state.blocks.find(b => b.block_meta.header.height === height)

 if (block) {

   return block

 }

 block = await new Promise((resolve, reject) => {

   node.rpc.block({height}, (err, block) => {

We should probably just get the block header, instead of the whole thing
(the difference is that the block contains all the transaction data, which
may grow to be large in the future).
We can get only the header by using node.rpc.blockchain({ minHeight:
height, maxHeight: height }, cb) (looks a little less clean, but probably
worth it). The result format is similar but contains block_metas as an
array.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/cosmos-ui/pull/259#pullrequestreview-84544277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmO2V9Qum_wm3Hh-KYViJrE--moJyUgks5tB_8ygaJpZM4RHWwX
.


[Question] Security and storage

Hello there, guys!
I am very curious about the security and storage of your DB. As far as I can see, you can give write permissions. However, I am curious about one particular scenario. Let's say, I have a central server that is the main authority. It is designed to be as unimportant and as lightweight as possible, so most of the heavy lifting is done via the p2p data sharing.

The main idea initially was: give write permission to the main server only, leaving everyone basically read-only, while it is offline. However, it sounds too constraining. Are there any other possibilities or better battle-tested patterns? And, also, how secure will the whole system be?

Storage. Let's imagine I am creating Twitter-like service. Each user, message, and other data are stored on the distributed DB, which is the most intuitive way of achieving that. However, it makes me doubt about how feasible this tactic will be on mobile devices, with very limited data bandwidth and RAM. So, the question is, how is data being stored on the network? Does every user download and own the whole database? Or is it smartly split-up into chunks?

Does every user pin and host the database?

Sometimes I start to think that using some hand-written system, written on top of some WebRTC DHT, such as KAD.js might be overall more secure and simple to track problems in. For example, giving the main server a public-private key pair, which will allow it to sign some data pieces, that would be then stored on the client's side. However, it creates a question about data accessibility and sharing.
Thanks!

Moving to the Field Manual repo for more details / discussion


Provide checksum for all binaries

There are download links on this page without checksums. Without a checksum, users cannot verify that the binary they receive is intact / not compromised. Checksums were also requested in #9 and would have increased confidence that the virus scanner had a false positive.

All  linux download have a signature and OSX/Win downloads are signed with our certificate. We'll add info/checksums on our webpage soon. Thanks for the feedback

@amougel I noticed these aren't GPG signatures. What type of signature are they? Some form of OpenSSL signature?

Yes, openssl signatures.

No worries; is the hash algorithm specified anywhere?

Forgot to mention :/ , we signed the sha256 of the file

Ah, that's why I could never get it to verify :P Could be worth mentioning that in release announcements? :)


ask helper

Type
Enhancement

Description

Added a new method get_ask_usage_guide() in pr_agent/servers/help.py to generate a usage guide for the ask tool.
Updated the get_review_usage_guide() method in pr_agent/servers/help.py to include a direct link to the improve feature documentation.
Imported HelpMessage from pr_agent.servers.help in pr_agent/tools/pr_questions.py and added a section in the run() method to append the usage guide to the PR comment if the enable_help_text setting is true.
Updated the documentation for the ask tool in docs/ASK.md to include an example and a note about the tool's functionality.
Added a new configuration option enable_help_text under the pr_questions section in pr_agent/settings/configuration.toml.

Changes walkthrough
Relevant files                                                                                Enhancement

help.py

        pr_agent/servers/help.py
Added a new method get_ask_usage_guide() to generate a usage guide for the ask tool. Also updated the get_review_usage_guide() method to include a direct link to the improve feature documentation.

 +24/-1

pr_questions.py

        pr_agent/tools/pr_questions.py
Imported HelpMessage from pr_agent.servers.help and added a section in the run() method to append the usage guide to the PR comment if the enable_help_text setting is true.

 +6/-0

Documentation

ASK.md

        docs/ASK.md
Updated the documentation for the ask tool to include an example and a note about the tool's functionality.

 +6/-2

Configuration changes

configuration.toml

        pr_agent/settings/configuration.toml
Added a new configuration option enable_help_text under the pr_questions section.

 +2/-0

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

Preparing answer...

Preparing answer...

Question: grade this PR from 0 to 100
Answer:
As an AI language model, I don't have the ability to review the actual code changes in the PR. However, I can provide an analysis based on the description and the changes made in the PR.
This PR introduces several enhancements to the ask tool, including a new method get_ask_usage_guide() in pr_agent/servers/help.py to generate a usage guide, updates to the get_review_usage_guide() method to include a direct link to the improve feature documentation, and updates to the documentation for the ask tool in docs/ASK.md. It also adds a new configuration option enable_help_text under the pr_questions section in pr_agent/settings/configuration.toml.
The changes seem to be well-documented and the code changes are clear and concise. The addition of the get_ask_usage_guide() method and the enable_help_text configuration option should improve the usability of the ask tool. The updates to the documentation are also a positive change, as they provide more information and clarity about the tool's functionality.
Based on these factors, I would give this PR a score of 85 out of 100. This score reflects the fact that the PR is well-structured, the changes are clearly explained, and the enhancements should improve the functionality and usability of the ask tool. However, without being able to review the actual code changes and their impact, it's not possible to give a full score.

 ✨ Usage guide:
Overview:
The [ask tool](https://github.com/Codium-ai/pr-agent/blob/main/docs/ASK.md] answers questions about the PR, based on the PR code changes. Note that the tool does not have "memory" of previous questions, and answers each question independently.
It can be invoked manually by commenting on any PR:
/ask "..."

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Question: rate this PR code changes on a scale from 0 to 10
Answer:
As an AI language model, I don't have the ability to directly evaluate code changes. However, I can provide some insights based on the changes made in this PR.

The PR introduces a new method get_ask_usage_guide() in pr_agent/servers/help.py. This method generates a usage guide for the ask tool, which is a positive addition as it helps users understand how to use the tool effectively.

The get_review_usage_guide() method in pr_agent/servers/help.py has been updated to include a direct link to the improve feature documentation. This is a good practice as it makes it easier for users to find relevant information.

The run() method in pr_agent/tools/pr_questions.py has been updated to append the usage guide to the PR comment if the enable_help_text setting is true. This is a user-friendly feature that can help users understand how to use the tool.

The documentation for the ask tool in docs/ASK.md has been updated to include an example and a note about the tool's functionality. This is a good practice as it provides users with practical examples and important information about the tool.

A new configuration option enable_help_text has been added under the pr_questions section in pr_agent/settings/configuration.toml. This allows users to customize their experience with the tool.

Overall, these changes seem to enhance the user experience and provide better documentation and guidance for using the ask tool. However, without knowing the specific context and requirements of the project, it's hard to give a precise rating. Based on the information provided, these changes seem beneficial and I would rate them positively.

 ✨ Usage guide:
Overview:
The ask tool answers questions about the PR, based on the PR code changes. Note that the tool does not have "memory" of previous questions, and answers each question independently.
It can be invoked manually by commenting on any PR:
/ask "..."

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Question: rate this PR code changes on a scale from 0 to 10
Answer:
As an AI language model, I don't have the ability to review or rate code changes directly. However, I can provide information based on the changes made in this PR.
This PR introduces several enhancements to the ask tool in the pr_agent:

A new method get_ask_usage_guide() has been added to pr_agent/servers/help.py. This method generates a usage guide for the ask tool.

The get_review_usage_guide() method in pr_agent/servers/help.py has been updated to include a direct link to the improve feature documentation.

The HelpMessage has been imported from pr_agent.servers.help in pr_agent/tools/pr_questions.py. A section has been added in the run() method to append the usage guide to the PR comment if the enable_help_text setting is true.

The documentation for the ask tool in docs/ASK.md has been updated to include an example and a note about the tool's functionality.

A new configuration option enable_help_text has been added under the pr_questions section in pr_agent/settings/configuration.toml.

These changes seem to be well-structured and aim to improve the usability and documentation of the ask tool. However, without the ability to execute or test the code, I can't provide a numerical rating.

 ✨ Usage guide:
Overview:
The ask tool answers questions about the PR, based on the PR code changes. Note that the tool does not have "memory" of previous questions, and answers each question independently.
It can be invoked manually by commenting on any PR:
/ask "..."

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Preparing answer...

Question: rate this PR code changes on a scale from 0 to 10
Answer:
As an AI model, I don't have the ability to evaluate or rate code changes. However, I can provide information about the changes made in this PR.
This PR introduces several enhancements to the ask tool in the pr_agent project. Here's a summary of the changes:

A new method get_ask_usage_guide() has been added to pr_agent/servers/help.py. This method generates a usage guide for the ask tool.

The get_review_usage_guide() method in pr_agent/servers/help.py has been updated to include a direct link to the improve feature documentation.

The HelpMessage is now imported from pr_agent.servers.help in pr_agent/tools/pr_questions.py. A section has been added in the run() method to append the usage guide to the PR comment if the enable_help_text setting is true.

The documentation for the ask tool in docs/ASK.md has been updated to include an example and a note about the tool's functionality.

A new configuration option enable_help_text has been added under the pr_questions section in pr_agent/settings/configuration.toml.

These changes seem to be aimed at improving the usability and documentation of the ask tool. The code changes appear to be well-structured and follow good coding practices. However, without running tests or having more context about the overall project, it's not possible to provide a numerical rating.

 ✨ Usage guide:
Overview:
The ask tool answers questions about the PR, based on the PR code changes. Note that the tool does not have "memory" of previous questions, and answers each question independently.
It can be invoked manually by commenting on any PR:
/ask "..."

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the ask usage page for a comprehensive guide on using this tool.


Add one more AT_DISPATCH for layer norm gamma scalar type

Original kernel only do AT_DISPATH on input dtype, while weight/bias (gamma/beta) may have different data types. It will break when trying to get gamma.data_ptr<weight_t>(), for its wrong scalar type.
Same issue break comfirmed on cuda.
Fixing this by adding one more AT_DISPATH.

Checked the logic of CUDA. They use is_mixed_type to differentiate between paths. Of course, they only assume that gamma is float.

@Liangliang-Ma What scenarios need this fix? Since CUDA doesn’t specifically address this issue, is it necessary? @fengyuan14 @EikanWang

@Liangliang-Ma What scenarios need this fix? Since CUDA doesn’t specifically address this issue, is it necessary? @fengyuan14 @EikanWang

Met this in a ipex rebase 2.5 workload jira, which is a bart model doing question answering task on float16 precision(no AMP). It turned out to be easy to reproduce in single UT, also failing with lastest stock pytorch whl on CUDA.
import torch
from torch.nn import LayerNorm

dtype1 = torch.float16
inputs = torch.rand([1, 1024, 4096], dtype=dtype1, requires_grad=True).cuda()
ln = LayerNorm(4096, eps=1e-05, elementwise_affine=True).cuda()
outputs = ln(inputs)


Figure out success rate classification in telemetry

In #536 we introduced grpc_status_code and status_code to enable success rate calculations.
A naive success rate calculation would look something like:
(
  sum(irate(response_total{grpc_status_code="0"}[20s])) +
  sum(irate(response_total{status_code="200"}[20s]))
) /
sum(irate(response_total{}[20s]))

Note that status_code="200" doesn't count non-200 successes. Assuming we really want to count status_code<400, a couple options come to mind:

add a success=true|false label to the proxy's response_total metric
add a prometheus relabel_config to relabel all metrics with status_code's < 400 (this may require enumerating every integer [0...400)

Related to #627

I think you need to do something like:
  sum(irate(response_total{status_code="200"}[20s])) -
  sum(irate(response_total{grpc_status_code!="0"}[20s]))

because all grpc messages have a 200 response code

The plan for this more generally is that routes will have some configurable classification logic, so this should be pushed down into the proxy.

Bear in mind also that responses with no status_code label and no grpc_status_code label are likely to be some kind of protocol-level error, which we don't currently make explicit (see #599)

I think the proxy should add a classification label to response metrics. The possible values of which are currently success or failure.

Question regarding gRPC statuses: it seems like some gRPC status codes (e.g. "Not Found", "Already Exists", "Permission Denied", etc) indicate errors on the client side rather than the server side. If we count the analogous HTTP 4xx error codes as "successes", it seems like some non-zero gRPC status codes might be counted as successes as well?

@siggy should #639 close this?

@hawkw yup thanks!
fixed in #639.


#2918 JsonView support for RequestBody objects

Hi @frantuma.
I just recognised that I forgot to check in the test cases in 44cf5bf. I Have now checked in the test cases in f5a7cc0. Would you please consider merging this pull request now?
If you want me to do anything differently, please let me know 😃.
Happy weekend!

@frantuma Is there anything I can do differently for you to reply to my question or consider merging this pr.?

@simenflatby thanks a lot! I have included your commits in #3010 (it fixes merge conflict) which is merged.


TypeError: 'staticmethod' object is not callable

Describe the error
Once I've installed the conda environment, after installing the dependencies in the requirements, executing manimgl comes up. The installation configuration is the reference https://docs.manim.org.cn/.
Code and Error
Code:
(manim) E:\manim>manimgl

Error:
Traceback (most recent call last):
File "E:\anaconda\envs\manim\lib\runpy.py", line 194, in _run_module_as_main
return run_code(code, main_globals, None,
File "E:\anaconda\envs\manim\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "E:\anaconda\envs\manim\Scripts\manimgl.exe_main.py", line 4, in
File "E:\manim\manimlib_init.py", line 14, in
from manimlib.animation.animation import *
File "E:\manim\manimlib\animation\animation.py", line 5, in
from manimlib.mobject.mobject import _AnimationBuilder
File "E:\manim\manimlib\mobject\mobject.py", line 64, in
class Mobject(object):
File "E:\manim\manimlib\mobject\mobject.py", line 230, in Mobject
def set_data(self, data: np.ndarray) -> Self:
TypeError: 'staticmethod' object is not callable
Environment
OS System:
manim version: master
python version:Python 3.8.19

I am also having the same error.

I am also having the same error.

Same Error. Any idea now?

I upgraded from Python 3.8 to 3.10! Hope that helps

I solved it by commenting out all @staticmethod line in file mobject.py and scene.py.
In your environment, they are:
"E:\manim\manimlib\mobject\mobject.py"

"E:\manim\manimlib\mobject\mobject.py"

So try to replace all the @staticmethod by # @staticmethod in these two files.

i have same issue

The comment above about python 3.10 helped me. This was on OSX
For noobs here is a tutorial :
`run python -V
and see if you have an old python version.  I had 3.9.
You might need to download python3.10. I had several python versions, and for. me 3.10 vas available at
python3.10 -V ->
Locate python 3.10 or higher and create a virtual environment using it.
python3.10 -m venv venv
Then , activate the venv
source venv/bin/activate
Now, you can try to use the python command again, and now the version is 3.10
`python -V  (should give you 3.10 or more)
Then install
run pip install -e .
Then run the example
manimgl example_scenes.py OpeningManimExample

Currently working python version to me is 3.10.14 (3.12 (numpy) and 3.9 (@staticmethod) both fall to my compiler)
(On M1 MacOS 15.0-beta)

Working just fine (without changing anything) with python 3.11.4 on M1 Pro 2020 (macOS 15.0.1).

updating python to 3.10 may be useful

Change from 3.9 to 3.10 and solve. I hope this is useful.


feat(themes): optimization of bundle size barrel file

Summary
Type

Enhancement

Summary
@ultraviolet/themes currently export all themes in a barrel file which can cause the bundle to be oversized while not all themes are imported.
With this update we separate exports and only include the imported ones in the bundle which reduce drastically the usage for that specific package.
Example
Before
In a simple project started with create-react-app and having this in the App.tsx:
import "./styles.css"
import { ThemeProvider } from "@emotion/react"
import { consoleLightTheme } from "@ultraviolet/themes"

export default function App() {
  return (
    <ThemeProvider theme={consoleLightTheme}>

Hello CodeSandbox

Start editing to see some magic happen!

    </ThemeProvider>
  )
}

The bundle size was 205.68KB:

We can see that dark, light and darker theme are included and all deprecated in the bundle but we only use consoleLightTheme in the code of the app.
After
In the same project with the same typescript in App.tsx, only change is the package of @ultraviolet/themes being updated to this PR changes we obtain a bundle of 169.45KB:

We see that only light theme is included and not the others.
Conclusion
This update provide change the bundle size from 205.68KB to 169.45KB for a simple react app.
A reduction of 17.61% 🚀

Just to understand, we still import this way: import { consoleLightTheme } from "@ultraviolet/themes"
So we rely on tree shaking to get rid of the other export within themes/index.ts, why not doing
import { consoleLightTheme } from "@ultraviolet/themes/dark" directly?


fix: add highlite color to the folder if chat is active(issue #482)

/deploy-review

/deploy-review


--debug-brk broken as of 2.2.0

on node 0.10.36
./node_modules/.bin/mocha -C --debug-brk

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: spawn ENOENT
    at errnoException (child_process.js:1011:11)
    at Process.ChildProcess._handle.onexit (child_process.js:802:34)
make: [test-debug] Error 8 (ignored)

but working fine with<EMAIL_ADDRESS>

was fixed in 2.2.1! (or should be, try it and let me know). thanks!

yerp thanks @travisjeffery


[FEA]: Simplify running the VectorDB Upload example to make it easier to use

Is this a new feature, an improvement, or a change to existing functionality?
New Feature
How would you describe the priority of this feature request
High
Please provide a clear description of problem this feature solves
The current implementation of the VectorDB Upload example is meant to illustrate how a pipeline could be developed to upload information to a VDB. However, this is utility in simplifying the external interface to allow users to build off the core functionality for specific use cases. This would allow users the ability to easily create optimal pipelines with different types of data or pre-processing.
Describe your ideal solution
Ideally, nearly all of the pipeline implementation should be abstracted away from a user. If the pipeline was completlely defined and run inside of a single function, then users could specify configuration options in the function arguments and only advanced users would need to know more about the pipeline.
To make this happen, the current example needs to be categorized into the following:

Customizable components

These portions of the pipeline need to be specified by the user since they are specific to each use case
For example, you cant use the same document ingest and document pre-processing sections for both scanning RSS feeds and loading PDF documents.

Configurable components

These portions of the pipeline are relatively fixed and users may need to change some options, but the core functionality remains constant.
For example, the tokenization portions of the pipeline may use different vocabularies or settings, but we will always need to perform tokenization.

Static components

These portions of the pipeline will not change and should be completely hidden from the user.
For example, the deserialization stage will never change

Once categorized, it will be easier to simplify the interface. Static components can be hidden, configurable components can be controlled by a single config dictionary/JSON/YAML, and customizable components should be passed in as python objects.
The following is an example showing some psuedo code to illustrate:
def pdf_sources():

    pdf_files: list[str] = [...]

    for pdf_file in pdf_files:
        # Load the PDF file into a DataFrame
        df = ...

        # Yield the DataFrame to be processed by the pipeline
        yield df

rag_config = {
    "documents": {
        "parser": "pdf",
        "source": pdf_sources(),
        "parser_kwargs": {
            "columns": ["page_content"]
        }
    },
    "embedding": {
        "model_name": "intfloat/e5-small-v2",
        "model_kwargs": {
            "device": "cuda"
        },
        "encode_kwargs": {
            "normalize_embeddings": True
        },
        "embedding_size": 384,
    },
    "vdb": {
        "type": "milvus",
        "uri": "http://localhost:19530",
        "resource_name": "Scout",
    }
}

morpheus_rag_upload(rag_config)

Completion Criteria

[x] The current pipeline functionality can be run with a single function call

[ ] [Optional] Move the function call under the morpheus.llm module to allow it to be included as part of the normal Morpheus library

[x] The configurable pipeline components are controlled using a dictionary like object

[x] [Optional] Support JSON/YAML files for configuration

[x] The pipeline can support multiple data types

[x] See #1452 for new workflows that will be added to the example

[x] The pipeline can handle custom document loading and preprocessing via cuDF
[x] Performance is the same between the current example and changes in this issue
[x] Documentation and the example README.md have been updated to reflect the new syntax
[x] Unit tests have been added.

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open feature requests and have found no duplicates for this feature request

Completed in #1454


Fix: removed time-outs on edit profile and password change dialogs.

I merged our develop into this branch and resolved the merge conflicts.


How to create from form component through json

example：
https://github.com/jaweii/Vue-Layout

Hey there @jicvi. Do you mind elaborating a bit on what exactly your question is?
There is a LOT of stuff going on in that repo you linked to, and I'm not 100% sure what you are looking for.

@thedodd
json to  from
create YBC from with JSON


Pressing "Shift" not always shows price tracker info for an item.

Sometimes when you press Shift (or other) key modifier (and when this feature is enabled in options) while having an item tooltop already open then nothing happens until you move mouse to another item and back to this one. It seems to be happening only second time you use key modifier. I.e. when you press Shift, release, move to another inventory item, back to this one, and press Shift again -> nothing. If you move to another item, press Shift, go back to this one, and press Shift -> all works.

Code bug, fixed in the main branch and will be release with v2.7.0.


[pulsar-broker]Fix: client-producer can't reconnect due to failed producer-future on cnx cache

Motivation
Frequently having issue where broker doesn't allow client to create producer and client keep receiving error: Producer is already present on the connection

It happens when same client-host is connected to one broker for two different topics which are part of different bundles. So, client shares same cnx-C1 with broker-B1 for the two different topics which are part of different bundles.
Now, one of the bundle and topic-T1 gets unloaded and goes to different broker-B2. while unloading, client try to reconnect to broker B1 and producer-creation fails due to unloading. However, in the unloading process, broker sometimes couldn't clear this failed-producer-future from the cache.
After sometime, the same bundle and topic T1 again gets unloaded from broker-B2 and comes back to Broker-B1.
Now, client already has cnx-C1 with broker-B1 (because bundle-2 topics are still connected) and try to create producer (with same producer-id which was created initially at client) for topic-T1 on the same cnx-C1.
Some how, broker couldn't clear old producer-result from the cnx-C1 cache and it thinks that producer is already connected so, client keeps failing and couldn't create the producer.

Broker-log
1#(1) Bundle started unloading
10:11:18.980 [pulsar-web-29-18] INFO  org.apache.pulsar.broker.namespace.OwnedBundle - Disabling ownership: my-prop/my-cluster/my-ns/0x00000000_0x80000000
:
10:11:19.026 [pulsar-web-29-18] INFO  org.apache.pulsar.broker.service.BrokerService - [persistent://my-prop/my-cluster/my-ns/topic-partition-0] Unloading topic
:
10:11:19.029 [pulsar-web-29-18] INFO  org.apache.pulsar.broker.service.Producer - Disconnecting producer: Producer{topic=PersistentTopic{topic=persistent://my-prop/my-cluster/my-ns/topic-partition-0}, client=/<IP_ADDRESS>:58042, producerName=my-cluster-2897-13224, producerId=1069}
:
#(2) While unloading topic: producer disconnected and client tried again to create producer on same cnx: <IP_ADDRESS>:58042 .. but I think producerFuture is not removed
10:11:19.133 [pulsar-io-21-48] INFO  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Creating producer. producerId=1069
10:11:19.134 [pulsar-io-21-42] INFO  org.apache.pulsar.broker.lookup.TopicLookupBase - Failed to lookup yahoo.dht.set.prod-tenzing.su for topic persistent://my-prop/my-cluster/my-ns/topic-partition-0 with error Namespace bundle my-prop/my-cluster/my-ns/0x00000000_0x80000000 is being unloaded
:
10:11:19.134 [pulsar-io-21-42] INFO  org.apache.pulsar.broker.lookup.TopicLookupBase - Failed to lookup yahoo.dht.set.prod-tenzing.su for topic persistent://my-prop/my-cluster/my-ns/topic-partition-0 with error Namespace bundle my-prop/my-cluster/my-ns/0x00000000_0x80000000 is being unloaded
10:11:19.204 [BookKeeperClientWorker-OrderedExecutor-5-0] INFO  org.apache.bookkeeper.mledger.impl.MetaStoreImplZookeeper - [my-prop/my-cluster/my-ns/persistent/topic-partition-0] [ContactsBackend.BlendedContacts_Index_subscription] Updating cursor info ledgerId=-1 mark-delete=10548168989:116241
:
10:11:19.208 [bookkeeper-ml-workers-OrderedExecutor-19-0] INFO  org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://my-prop/my-cluster/my-ns/topic-partition-0] Topic closed
:
10:11:19.211 [pulsar-io-21-27] WARN  org.apache.pulsar.broker.service.BrokerService - [persistent://my-prop/my-cluster/my-ns/topic-partition-0] Service unit is not ready when loading the topic
#(3) Topic again assigned to same broker and stale and failed producer-future already exists which doesn't allow producer to reconnect and keep giving error: Producer already connected
:
16:46:19.116 [bookkeeper-ml-workers-OrderedExecutor-19-0] INFO  org.apache.pulsar.broker.service.persistent.DispatchRateLimiter - [persistent://my-prop/my-cluster/my-ns/topic-partition-0] [null] setting message-dispatch-rate DispatchRate{dispatchThrottlingRateInMsg=0, dispatchThrottlingRateInByte=0, ratePeriodInSecond=1}
16:46:19.155 [pulsar-io-21-48] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Producer is already present on the connection
:
16:46:19.155 [pulsar-io-21-48] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Producer is already present on the connection
16:46:19.350 [pulsar-io-21-48] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Producer is already present on the connection
16:46:19.751 [pulsar-io-21-48] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Producer is already present on the connection
16:46:20.528 [pulsar-io-21-48] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:58042][persistent://my-prop/my-cluster/my-ns/topic-partition-0] Producer is already present on the connection

client-log
CPP-Client log shows unknown error
20190425 16:46:19.155 : WARN  cms./var/builds/workspace/260010-v3-component/BUILD_CONTAINER/rhel6/label/DOCKER-LOW/app_root/pulsar/pulsar-client-cpp/lib/ProducerImpl.cc - [persistent://sherpa-prodhd/prod2-sg3/prodhd-NOTIFICATION-ContactsBackend.BlendedContacts_Index/DIFF-partition-0, prod2-sg3-2897-13224] Failed to reconnect producer: UnknownError

I couldn't reproduce it in my local env but it happens very frequently to my prod env.
Modification

Clean up producer-future from the cache if future is already completed with failure.
added log once schema-future completes for future troubleshooting to make sure schema-future doesn't get stuck.

@rdhabalia Would it be possible to happen for consumer creations too? (even in slightly different form)

Would it be possible to happen for consumer creations too?

yes, it should be fixed at consumer as well which I missed and this PR is merged now. created a new PR: #4145


Import missing

you have below used in BERT notebook
from dataloader import mydataset , create_prime_dict
but actually dataloader doesn;t have create_prime_dict in it? wondering what is the purpose so that I can code it.

I am also facing the same issues, have you got any idea on it, if yes then please share...


python310Packages.trio-asyncio: 0.12.0 -> 0.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.trio-asyncio is: Re-implementation of the asyncio mainloop on top of Trio
meta.homepage for python310Packages.trio-asyncio is: https://github.com/python-trio/trio-asyncio
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.13.0 with grep in /nix/store/ikqf8n16ad9xcpx32svrf8qrcc4phy4x-python3.10-trio-asyncio-0.13.0
found 0.13.0 in filename of file in /nix/store/ikqf8n16ad9xcpx32svrf8qrcc4phy4x-python3.10-trio-asyncio-0.13.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pytest-aio
python310Packages.returns
python310Packages.trio-asyncio
python311Packages.pytest-aio
python311Packages.returns
python311Packages.trio-asyncio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ikqf8n16ad9xcpx32svrf8qrcc4phy4x-python3.10-trio-asyncio-0.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.trio-asyncio https://github.com/r-ryantm/nixpkgs/archive/39659999f8baa479ec2121e58a8d04bb036dcfb2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/39659999f8baa479ec2121e58a8d04bb036dcfb2#python310Packages.trio-asyncio

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ikqf8n16ad9xcpx32svrf8qrcc4phy4x-python3.10-trio-asyncio-0.13.0
ls -la /nix/store/ikqf8n16ad9xcpx32svrf8qrcc4phy4x-python3.10-trio-asyncio-0.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python310Packages.pytest-aio
python310Packages.returns
python310Packages.trio-asyncio
python311Packages.pytest-aio
python311Packages.returns
python311Packages.trio-asyncio

Maintainer pings
cc @dotlambda for testing.

included in #271586

Already on master, closing.


Ntr/improve export streams cron

the cronJob now runs the ConnectExport just once for every product
and not for every Product and every Stream
this should improve the Performance in cases where the same
Products are in multiple streams

Coverage increased (+0.01%) to 42.202% when pulling b6d597e5eb4f0356937388f8b7bbaab06820210b on ntr/improve-export-streams-cron into cb103079b55c6d4833d7cfc0b288548e44882d10 on master.


Remove submission on previous bottom up checkpoints

Some initial modification to relayer:

Remove submit previous epoch. This was added to encourage more relayer submit previous epoch and claim rewards. currently we dont have reward scheme anymore. This becomes unmotivated.
Adding more info into the error log.

Just wanted to point out that the title says it just adds more logging, yet the description talks about changing the semantics of submission when it comes to rewards. I think the second is the more significant change and should be reflected in the title.

Closing this one as we will skip empty bottom up checkpoints, see #766


Code 4 feedback

Great Code. Please add comments.

Thanks for the feedback. I have updated the code with comments.


Clean Major/Minor data.

http://catalog.illinois.edu/undergraduate/
http://catalog.illinois.edu/undergraduate/minors/

What exactly does "clean" mean over here? Manual work or write a parser?

What exactly does "clean" mean over here? Manual work or write a parser?
Also, I'm fairly confident that someone somewhere has access to an underlying database that contains all the info you see rendered on those pages you linked. Might be worth trying to get access to that.

I guess I'm not completely sure yet how we want to deal with the major/minor requirements. Ideally, we can get it in the same form we get the prerequisites so that we can easily check against the requirements. But that is a good idea to see if we can get that data directly from the school. Any idea on who we could ask?


Creating a logotype and graphical profile

In order to marked the project a logotype and graphical profile is necessary.
Current webpage is horrendous.
http://meddelare.com/

When done, account pages should be updated.

github: https://github.com/meddelare/ @meddelare
npm: https://www.npmjs.com/~meddelare
twitter: https://twitter.com/meddelare

I've added a provisional "logotype", by taking a zoomed in screenshot of the buttons example. Far from awesome.

Chose a background image as well. Thanks kelvie for IMG_7798 (CC-BY 2.0)!
https://secure.flickr.com/photos/99120948@N08/19273986309/
This issue still isn't resolved though -- this was just something I threw in to get rid of placeholder account images and single-color backgrounds.

Closing due to Meddelare project shutdown.


Multiple pages with eel

Hi, I started recently in eel, and made my first application with it, but I need multiple pages html for my app, how I setup this in the python code that start the eel.init() and eel.start("index.html")?

Hi @felipexlr50 - this is supported just fine. You put the page you want to start on into eel.start, then just make sure that a script tag for eel.js is present in all pages you build. It should "just work" 🤞
Let us know how you get on!

Thanks, that works

Hi @felipexlr50 - this is supported just fine. You put the page you want to start on into eel.start, then just make sure that a script tag for eel.js is present in all HTML pages you build. It should "just work" 🤞
Let us know how you get on!

How can I close the previous window that was opened

I got solution for this, to use multiple pages you just have use this little javascript function i.e  window.location = "new.html"  and must include eel.js in your html file

does not work if parameter close_callback exists


python3Packages.mypy-boto3-s3: 1.20.0 -> 1.20.1

Motivation for this change
Update to latest upstream release 1.20.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145332 run on x86_64-linux 1

4 packages built:

python38Packages.dependency-injector
python38Packages.mypy-boto3-s3
python39Packages.dependency-injector
python39Packages.mypy-boto3-s3


feat: upgrade to ui@5 (TECH-385)

Implements TECH-385
Depends on https://github.com/dhis2/analytics/pull/476
Changes include:

upgrade from @dhis2/ui-core v4 to @dhis2/ui v5
add styled-jsx as dependency since @dhis2/ui declares it as a peer dependency (it was already installed due to other dependencies)
The FilterSelector popover now uses @dhis2/ui instead of material-ui
margin-bottom added to EditTitleBar to account for some spacing changes between ui4 and ui5

The Filter popover has been changed from material-ui to dhis2/ui:
Before (with MUI):

After (dhis2/ui):

Overlay with circular loader
Before (ui v4):

After (ui v5):

Vis Item loader:
Before (ui v4):

After (ui v5):

Found: The Dashboard Item menu is more dense:
Before (ui v4):

After (ui v5):

I just merged https://github.com/dhis2/dashboards-app/pull/885. Please make sure that the Dynamic Dimension is working as expected with the ui@5 upgrade as well.

Found: The Dashboard Item menu is more dense:
Before (ui v4):

After (ui v5):

Dense is good :+1:

All instances of Menu needs to be replaced by FlyoutMenu, as per https://developers.dhis2.org/2020/05/ui-5/

The original Menu component has been renamed to FlyoutMenu, which will render a menu in a Card and allows for submenus.


Update AMI to release 20150603

Udpate Amazon EC2 AMI to release 20150506.
and, added release timestamp comment.
https://github.com/docker/machine/blob/36b3c00b21c38c6b96edb055743944b0c8c68236/drivers/amazonec2/utils.go#L19
How about you think?
Refer to Ubuntu Amazon EC2 AMI Locator

Current latest each AMI timestamp is 20155028.
I'll fix later.

@zchee thanks!

@ehazlett Finish updated release 20150603.

@ehazlett BTW, Ubuntu latest AMI is possible get if parse this URL
https://cloud-images.ubuntu.com/query/trusty/server/released.current.txt

LGTM


[BUG]: chatgpt issue: cannot import name 'FusedAdamBuilder' from 'deepspeed.ops.op_builder.builder_names'

🐛 Describe the bug

Environment
colossalai                0.2.5                    pypi_0    pypi
deepspeed                 0.8.0                    pypi_0    pypi
chatgpt                   0.1.0                    pypi_0    pypi
pytorch                   1.13.1          py3.10_cuda11.7_cudnn8.5.0_0    pytorch
pytorch-cuda              11.7                 h67b0de4_1    pytorch
accelerate                0.16.0                   pypi_0    pypi
No response

I think this problem is not about colossalAI, it is about accelerate and deepspeed.

I think this problem is not about colossalAI, it is about accelerate and deepspeed.

I just downgrade deepspeed's version from 0.8.0 to 0.7.7, it works now.
pip install deepspeed==0.7.7


Add Dockerfile

This PR implements a first approach to having a Docker container to run the service. It uses a multi-stage build to avoid populating the final image with unnecessary files, and it also runs as non-root user for improved security.

Coverage remained the same at 87.258% when pulling 13f19192d8ce15c274f68583a97523f4a8d8cc3f on 18-dockerize-the-service into 8ed7293361b4340fec9a1db9450b8d699a3f5705 on main.

I'm including @luarx to reviewers. It would be also nice to check further steps (integrating it with CI runner, external configuration, Kubernetes, etc.) with DevOps 🙂


Task9 to 12

Assignment completed from Task 9 to task 12

@Siri82
Task -9
Code verified.
Task -10
Code verified.
Task - 11
Code verified.
Task -12
Code verified.


chore: change release image versions

Description

How Has This Been Tested?

Merge criteria:

[x] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

analogous to https://github.com/opendatahub-io/model-registry-operator/pull/104 proceeding to merge for releasing 0.2.2


Implement retain, dedup, dedup_by, and dedup_by_key

Implementation copied from the standard library.  The additional changes are to make the doctest work.

Added dedup and friends, also copied verbatim from the standard library (on the same branch because they depend on some common infrastructure for the tests to pass).


Upgrade org.pitest:pitest-maven 1.6.8 -> 1.6.9

This PR contains the following updates:

Package
Update
Change

org.pitest:pitest-maven
patch
1.6.8 -> 1.6.9

[ ] If you want to rebase/retry this PR, check this box.

Suggested commit message:
Upgrade pitest-maven-plugin 1.6.8 -> 1.6.9

See:
- https://github.com/hcoles/pitest/releases/tag/1.6.9
- https://github.com/hcoles/pitest/compare/pitest-parent-1.6.8...1.6.9


Stdlib Module.md updates

Purpose

$subject

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18836 into master will decrease coverage by 4.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18836      +/-   ##
==========================================
- Coverage   19.92%   14.95%   -4.97%
==========================================
  Files          52       47       -5
  Lines        1355     1230     -125
  Branches      208      187      -21
==========================================
- Hits          270      184      -86
+ Misses       1072     1033      -39
  Partials       13       13

Impacted Files
Coverage Δ

composer/packages/tracing/src/ToolBar.tsx

composer/packages/tracing/src/TraceList.tsx

composer/packages/tracing/src/DetailView.tsx

composer/packages/tracing/src/TraceLogs.tsx

composer/packages/tracing/src/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90722d5...5c2f558. Read the comment docs.


2.2.x

code changes:

SqsMessageHeaders extended by convenient getters for sqs specific headers.
SqsHeadersMethodArgumentResolver added to map MesageHeaderAccessor internal MessageHeaders instance into SqsMessageHeaders with timestamp from SQS SentTimestamp
Unit tests added in QueueMessageHandlerTest testing SqsHeadersMethodArgumentResolver and SqsMessageHeaders
QueueListenerTest (integration tests) extended by assertions on additional SqsMessageHeaders class parameter on SqsListener handler method.

Let me know Your thoughts.

@voytech Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@voytech Thank you for signing the Contributor License Agreement!

Thanks @voytech for the contribution and detailed explanation in the #296. As you said, it does change the runtime object so it's safer to move it to 2.3.0. Don't worry though about merging/rebasing, I'll take care of it.


SQL Query has a syntax error

[Enter feedback here]
The SQL query has a comma after the last field in the SELECT statement that shouldn't be there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c8f1262-a509-dbd4-3690-d36fec7cbcd6
Version Independent ID: 81eb8133-7111-236d-a9a5-124f7961f656
Content: Enable SQL insights - Azure Monitor
Content Source: articles/azure-monitor/insights/sql-insights-enable.md
Service: azure-monitor
Sub-service: insights
GitHub Login: @bwren
Microsoft Alias: bwren

@PaulFeaser Thanks a lot for bringing this to our notice and helping us improve our Azure documentation. I have raised a PR to incorporate the feedback and once the PR is reviewed and approved , changes would go live.
At this point it appears that there's no further edits or updates needed to the documentation, other than what has been listed above. We will go ahead and close this issue for now, however if you have any further feedback on the document please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Cached output are not copied again to the output paths

I don't know if it is related to your library but it behaves differently than nx-cloud.
When I retrieve a cache from the store, it is correctly copied into the node_modules/.cache folder but it is not copied into the output path related to my app/lib.
For example, the build output is not present in the dist folder after retrieving the cache.
I debugged a bit and nx-cloud is calling the function copyFilesFromCache in<EMAIL_ADDRESS>which is not the case in your library.
Another info, this is happening only when I delete the .cache folder manually. If I keep the .cache folder and I run the build again, it is correctly copied. If I delete the .cache folder (like we have on CI), it does not work (but works with nx-cloud)
Did I miss something?

Hmm, the copying progress isn't implemented at all by this library, but managed by the orchestrator (as you already noticed). The orchestrator is just calling (orchestrating) the runner (in this case this library).
So I'm having a hard time imagining why this is happening 😄
Could you give me your nx version? I'll try to reproduce the bug. Maybe it's a race condition or something in that direction 👍

Okay, thanks for reporting this. I'll create a merge request inside nx-remotecache-custom which fixes this issue 👍

Looks like it broke on 12.1.0: https://github.com/nrwl/nx/commit/f89cf4a14b247d3232e892cda299cf3e205abbaa#diff-8d99fe03522dad38bf9fcbe399d846d2fa242c9f7e694cc0c49d1da13a790c5d

Has this bug or a version of this bug reappeared?
it seems like Nx is using a cached version of a library to compile an application, and then building the changes to a lib. Essentially the dist folder has outdated libraries in apps, but updated libs themselves. 🤔 Any idea?


Filter dropdown language

How I can change the language of the text of filter's dropdowns. I have tried the example that you have but that does not change them.

It should work, maybe you are using older grid version?

Did you find the problem?

Thanks, I updated the version and that fix the problem.

Hi,
I have same problem ,
I dont know  how can I change filter language.

Does localization example not work?

yes not working

yes not working

can you give me example file ?

You already have an example file and it's not working, so what is not working? Do you get any errors?
Did you try seeing what is wrong? What did you try? Which page are you looking for example?


Migration files with colliding numbers are not reported as error

Expected Behavior
If there are more than one files starting with the same number in their names then they should be either processed individually or reported as an error. Silently pretending as if there were only one of them is pretty misleading.

If there are two files with the same number in their names then either process all of them or report an error saying "File names must have different numbers in their names."
Current Behavior
Wrench executes only one of these files and ignores the rest.
Steps to Reproduce

Create two migration scripts and name them with the same number. For example, 20210831_123456_first.sql and 20210831_123456_second.sql
Define a CREATE TABLE first(...) in the first one and CREATE TABLE second(...) in the second one.
Do a migrate up
See your database. Table first will be there, table second will not.

@halmai
Currently, wrench executes all of migrations if versions are conflicted each other.
But, although wrench behave so, I think wrench should raise an error for that case. So, let me review your PR.

Closed by https://github.com/cloudspannerecosystem/wrench/pull/48


ssh support

Would be great if netconify could initiate connections to a console server via ssh rather than just telnet. Our entire console server infrastructure relies on ssh to reach console ports rather than telnet.
Thanks for your consideration.

I just added the ssh support. It is in first stages and needs little finishing touches and then I'll request merge to this official library. For time being, you can pull mine on you own risk.
pbk@pbk-mbp15 [~]netconify --facts -s "<IP_ADDRESS>,4011,," -u test-user --passwd "pasword1"
CMD:TTY:login:connecting to TTY:<IP_ADDRESS>:4011:test-user:password1 ...
CMD:TTY:login:logging to device ...
CMD:TTY:login: OK ... starting NETCONF
CMD:facts:retrieving device facts...
CMD:facts:saving: ./cfwj-lab1-0011a-facts.json
CMD:inventory:saving: ./cfwj-lab1-0011a-inventory.xml
CMD:TTY:logout:logging out ...
I omitted ssh console user and pass, since they're same for device authentication, but if they are different, you can specify them.
pbk@pbk-mbp15 [~]netconify --facts -s "<IP_ADDRESS>,4011,console-user,console-password" -u test-user --passwd "pasword1"
CMD:TTY:login:connecting to TTY:<IP_ADDRESS>:4011:console-user:console-password ...
CMD:TTY:login:logging to device ...

r2600,, I get the following:
`MAC:~$netconify --facts --ssh=<IP_ADDRESS>,3020,terminalUsername,terminalPassword -u username --passwd "junosPassword?"
TTY:connecting to TTY:<IP_ADDRESS>:3020: terminalUsername: terminalPassword ...
TTY:logging in ...
ERROR:login:global name 'time' is not defined
Traceback (most recent call last):
File "/usr/local/bin/netconify", line 7, in
results = nc.run()
File "/usr/local/lib/python2.7/site-packages/netconify/cmdo.py", line 253, in run
self._hook_exception('login', err)
File "/usr/local/lib/python2.7/site-packages/netconify/cmdo.py", line 251, in run
self._tty_login()
File "/usr/local/lib/python2.7/site-packages/netconify/cmdo.py", line 337, in _tty_login
self._tty.login(notify=notify)
File "/usr/local/lib/python2.7/site-packages/netconify/tty.py", line 109, in login
self._login_state_machine()
File "/usr/local/lib/python2.7/site-packages/netconify/tty.py", line 166, in _login_state_machine
prompt, found = self.read_prompt()
File "/usr/local/lib/python2.7/site-packages/netconify/tty_ssh.py", line 97, in read_prompt
delta = time.time() - start
NameError: global name 'time' is not defined
`

I noted some problems with tty_ssh.py in issue #50. Trying cloning my fork.
sudo pip install git+https://github.com/jeffbrl/py-junos-netconify.git@issue-50-fix

jeffbri i tried cloning your fork unfortunately it didnt work

Not sure what error you encountered. Try cloning my fork with 'git clone' and then switching to the issue-50-fix branch. Run 'python setup.py install'.

Jeff,
The issue with #50 is purely decorative, allot does is negate timeout that wasn't in netconify before and was added to actually timeout. Thanks for noticing calling incorrect variable but this simple loop can be done 100 different ways to achieve same result. It was written quickly to satisfy customer request. I'll pick up work on netconify this summer and add more features users require.


epoc+

hi , does it support epoc+ model 2018 without need for licence buy ?

Hey! I'm not sure, I'll have to check but it might be ok


Refactor EmploymentForm from a B on Code Climate

https://codeclimate.com/github/ministryofjustice/atet/EmploymentForm

close? @dan-palmer


fix: document url and file path conversation in the language server

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

fix: document url and file path conversation in the language server
fix: attribute typo

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/core/symbol.rs
kclvm/tools/src/LSP/src/find_refs.rs
kclvm/tools/src/LSP/src/goto_def.rs
kclvm/tools/src/LSP/src/notification.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

kclvm/tools/src/LSP/src/tests.rs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.787%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2293

Relevant Lines:
2612

💛  - Coveralls


Upgrade @actions/core to 1.10.0

This is a simple dependency upgrade in response to a deprecation warning:

Action authors who are using the toolkit should update the @actions/core package to v1.10.0 or greater to get the updated saveState and setOutput functions.

Thanks @roryabraham! Sorry for missing this PR :( I've updated @actions/core since then, so closing this.


selector on key-prop doesnt return any matches.

Either its a bug or it probably should be documented that this prop does not work
let wrapper = shallow(

)
expect(wrapper.contains(
)).toEqual(true) // No error
expect(wrapper.find('[key="foo"]').length).toEqual(1) // Error: Expected 0 to equal 1
expect(wrapper.find({key:"foo"}).length).toEqual(1) // Error: Expected 0 to equal 1

This is intentional. "key" is not a real prop, it's a magic thing React uses to identify array items.
In other words, you need to use a different name than "key".

You can read more about key here: https://facebook.github.io/react/docs/lists-and-keys.html#keys

It would be nice if this is mentioned in the doc ( http://airbnb.io/enzyme/docs/api/selector.html ).

enzyme docs naturally assume that you've previously read the React docs; but sure, a PR to make our docs link to the React docs on "key" and "ref" would be great.

As someone who has read the React docs and worked with it extensively, I'd like to say:

It is not obvious to me from the selector docs that key would not be usable in a selector, since key isn't mentioned and since enzyme is specifically designed to work with React.
It would make a lot of sense to me (and apparently to other people) if enzyme did work with key, since again enzyme is specifically designed to work with react, but I understand your decision & just wish it were better documented.
The condescending comment about the React docs was really unnecessary and dismissive.

You can do this with findWhere.
Example:
const addButton = wrapper.findWhere(node => node.key() === 'AddButton');

I'd like to second point 2) of @melinath 's post above - key is exactly the kind of thing which we should be able to select on, since the use case for wanting to search on it (you have multiple instances of the same component) is precisely the same case in which react forces you to have it (and forces it to be unique, making it a good selector).
It would great if enzyme would reconsider this decision.

@lobsterkatie per https://github.com/airbnb/enzyme/issues/645#issuecomment-375730611, you can already do this - just using findWhere, not find.

One issue I ran into using the findWhere() approach is that you will get errors when the current node isn't an element. I just wrote a function to check for that though.

@WalterWeidner n && n.whatever should handle that?

What about testing the key prop to match a specific value unsing something like:
expect(
  wrapper.contains(<MyComponent key={id} />)
).toBeTruthy()

Add an id (or some other identifier) to your div
let wrapper = shallow(

    );

Then use standard find to get the key function instead of findWhere
expect(wrapper.find("#fooId").key()).toBe("foo");