password reset by typing in handle or email address

currently, if you do not know what email you registered with, you can't do a password reset
its frustrating to see a user locked out of an account because they don't remember what password was used during sign up.
ideally I would see two options for a user to be able to reset a password,
one is the standard which exists is reset by typing in email, ✅
the other:  type in bluesky handle to reset password (and then the password reset form gets sent to that email).
so it looks something like this

for additional security (some apps, will give the user  a toggle option to must enter email to reset password yes or no to make hacking more difficult)


SAN Certificate - Friendly name must beginning with an asterisk

The IIS7 disables editing of the https Host Name if the Certificate Friendly name does not begin with an asterisk.
Friendly Name without asterisk:

Friendly Name with asterisk:

Proposed ode (program.cs):
                certificate.FriendlyName = (Options.San ? "*" : "") +                     $"{binding.Host} {DateTime.Now.ToString(Properties.Settings.Default.FileDateFormat)}";

Looks like it an easy manual fix in the certificate store if you need to manually enable it to change your host name. (NB: Computer account, not current user)
Though "manual" every two months sounds like a poor idea, why would you want to do it?

Not a big problem.
But it is disturbing that the Host Name is not visible on the editbox.

But why use a SAN certificate and then limit the binding to a specific host? Seems like a single domain certificate would be more suitable in that case, especially since IIS7 doesn't support SNI.

Just came up against this problem myself, looking for solutions in IIS 7...

Just a small comment here on the file naming format:
I would do something like this instead:
certificate.FriendlyName = (Options.San ? "*." : "") + $"{binding.Host} {date of expiry}";
For SAN certs, "date of creation" is not really useful and AM/PM should be substituted with 24-hour system instead. Instead something like this makes more sense when checking the IIS SSL settings:
*.(host) - (date of expiry in yyyy-mm-dd hh:mm)

Most countries around the world today use the 24-hour system. The 12-hour format, including am and pm, is officially used only in the United States, Canada (except Québec), Australia, New Zealand, and the Philippines. https://www.timeanddate.com/time/am-and-pm.html

A site with certificates for
cdn.example.org
www.example.org
example.org

turns into *.example.org (2019-02-17 13:35)
You could also allow users to type in Friendly Name themselves but default to above.


rupert-plugin-knockout

David,
I'd like put this on the Rupert org soon. Some questions before that:

I left out testing entirely. I don't know of a defacto tdd framework for KO other than the normal candidates (karma w/ jasmine, etc). Should this be added?
The picture in the readme is a .png and the logo needs to be more flat. Can the designer that did the logo originally help with that?

Yeah, totally! You could move it over now, if you wanted. (Project Settings -> Transfer Ownership in the Danger Zone!)

Perhaps in rupert-plugin-knockout/examples/, and zip that similar to the rupert-grunt examples?

I can work on the logo - will take the k path, use the original jacked, and merge the red color into the cup & tie.

will do.

For 2 - https://github.com/RupertJS/rupert/blob/master/src/assets/logos/Rupert_Knockout.svg

Wow, the svg looks great!
So I'm setting up the example (https://github.com/MatthewVita/rupert-plugin-knockout-test) for Rupert Knockout (want to get everything solidified before I move the repo over to the organization) and was wondering if there's anyway around the following (I noticed this with the vanilla versions too):
I have to do this in order for the main.js (or any file really) to access the variable.

I suppose  you could override ScriptWatcher.renderers.js to wrap differently. Actually... and it pains me to say this... but that would be an interesting way to think about getting RequireJS support.

I'd much rather go the window route in that case.

Hmm. Yeah, you could also override that line to be a no-op, and have an implicit global scope. You could also wrap your code again in a Self-invoking anonymous function. Party like it's 2010, baby! Or use this instead of window, as window is passed as this to the function. Or add another module system. All this will be nicer in ES6.

okay, I'll play around a bit and get back to you. I tend to use browserify most of the time, but I wonder if that's introducing too many opinions.

okay, I looked into it and am not seeing any benefits to using this in place of window (it's literally the same thing like you said).
I think adding something like browserify would be too opinionated and we can stick to window. Obviously we have window.Templates as a vanilla default for good reasons, but what do you think about about adding in things like window.ViewModels, window.Models, window.Services, window.Controllers, etc by default as well? This would eliminate doing things like when "exporting":
window.ViewModels = window.ViewModels || {};
window.ViewModels.PersonViewModel = PersonViewModel;

I think projects should do this in a single file, global.js, that is the first file listed in the stassets.scripts.types array in server.js.

that works great!

dang, I'm trying to transfer over the repo and getting "You don't have admin rights to RupertJS"

If you're around this morning before 10:30 I can help with that.
On Thu, Jan 22, 2015, 21:43 Matthew Vita<EMAIL_ADDRESS>wrote:

dang, I'm trying to transfer over the repo and getting "You don't have
admin rights to RupertJS"
—
Reply to this email directly or view it on GitHub
https://github.com/RupertJS/rupert/issues/26#issuecomment-71139310.

Is RupertJS the "username"? What rights am I missing ?

bump C:
So I just committed my changes to rupert grunt fork here: https://github.com/MatthewVita/rupert-grunt/commit/434fefcdd3d314b8d072ec2bf576af4a6d757407
I'll send a PR as soon as I get rupert-plugin-knockout transferred over to the org page... what do I need to do there? Just to recap, I am using RupertJS as the username field for the transfer with no success.

I'm not entirely certain what needs to happen to transfer the repo - is there a time you can spend 5 minutes on a google hangout to go through that?

okay


Remove version: CrystalDewWorld.CrystalDiskMark.ShizukuEdition version 8.0.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

URL: - https://osdn.net/frs/redir.php?m=auto&f=crystaldiskmark%2F75252%2FCrystalDiskMark8_0_2Shizuku.exe
Invalid URI: The URI scheme is not valid.
(Automated message - build 912)

Close with reason: Package still available;


Merge/match highlight-own-issues-and-prs and highlight-collaborators-in-lists

I think that the style of highlight-own-issues-and-prs (https://github.com/sindresorhus/refined-github/pull/1782) wasn't very effective, I always have to squint to find my own discussions.
highlight-collaborators-in-lists (https://github.com/sindresorhus/refined-github/pull/2351) made this more obvious, its style it's much more visible:

I'm wondering... since highlight-collaborators-in-lists never highlights your own issues, why not just use the same style for both? Perhaps just with a slightly different color.
The features can be merged into one (highlight-collaborators-and-own-discussions) because they affect the same exact area, even if they're applied at different times.
cc @jerone

Agree. The simplest is to use highlight-collaborators-in-lists as the basis and append a different class when own username is found.
I would like to extend this with another check for repo owner (if exists).
Wondering what the styling should be, agree on the different color...

Wondering what the styling should be, agree on the different color...

Maybe collaborators could have a light grey color and your name a bit more saturated gray-blue


Does Amplify Console Support Keybase Encrypted Git?

** Please describe which feature you have a question about? **
Amplify Console CI/CD
** Provide additional details**
I know that Amplify has a host of different platforms it supports on its console for CI/CD, GitHub being one. My team was considering moving  an amplify project from GitHub to Keybase encrypted git and before we made the move I was curious as to if this was something supported by Amplify? I couldn't find any documentation on either the Amplify or Keybase side of things and wanted to see if this was possible. Would it be as simple as integrating a git repo and then providing keybase keys to KMS?

Hi @cray75 , as far as I know, Amplify Console didn't support Keybase encrypted git yet.


use torch_dtype=fp16 when specified

i noticed this while reviewing the code. when using --fp16, it still sets torch_dtype=torch.float32
is this by design, or an oversight?
is this intentionally set to a different value than compute_dtype?

I think it should be a typo error, because there is another torch.float32 at the end of if-else logic.


Don't auto-create webmanifest

Hi!
Is it possible to NOT auto-create and inject the manifest.webmanifest but only generate the service worker?
My manifest needs to be loaded from a different server.
Thanks.

@hannoeru Your enhancement label makes me guess that this is not possible atm? :) Thank you!


Organization of examples and notebooks

As referenced in draft PR #61 the examples folder is now a bit haphazard, as it's grown around the original estimation-centric main.py.  The docs/notebooks notebooks can also be consolidated in examples.  Creating separate folders for each major branch, creation/, estimation/, and evaluation/, and storing both command-line and jupyter demos there should make things easier to deal with.

are you sure it is legit to split the demos and examples nb/scripts by branches? What about examples and demos that exercise more than one branch?

in CLMM a distinction is drawn between examples and demo : I did not check there but in my mind demo would refer to more extensive and complete use cases, so perhaps what you were tempted to call pipelines. If we can have homogeneous "look n feel" for our readthedocs within DESC it would be nice, though I do not mean to enforce it.

This is addressed by #67 though I'm not sure on whether this is the final form that we want or not (there was some debate on docs/notebook vs examples/[creation/estimation/evaluation], so I'll leave it open for now.

Well, I think this can be closed now. If we want to reorganize again, we can make a new issue for it.


Added SharePoint event registration Power App sample

We're so eager to add your sample to this repository as soon as possible, but we need all samples follow the same structure.
To make sure we process it as soon as possible, make sure to follow these instructions.

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
fixes #X, partially #Y, mentioned in #Z

Solution Details

Q
A

Solution requires premium license
no

Solution uses experimental features (see licensing guidelines)
no

Which connectors are used?
e.g.: SharePoint, Office365Users, Office365Groups

Solution uses on-premises connectors?
no

Solution uses custom connectors?
no

Layout
Custom - designed for a SharePoint page

What's in this Pull Request?

Added my SharePoint Event Registration Power App
Note: for security reasons, we can only accept pull requests which consist of unpacked source code for .msapp files; We cannot accept .msapp files.

Thank you, @alexc-MSFT, for the sample!
If you have not already done so, we'd like to invite you to register for the (PnP) M365 Platform Community Recognition Program so that we can award you a badge for your contribution.
It is a program created by the community and powered by Credly to formally and officially recognize and celebrate the contributions of awesome community contributors like yourself with a collection of digital badges designs.
You can learn more and register here:
https://aka.ms/m365pnp-recognition

Thanks @PopWarner I have filled out the form to get my badge 😀


.grm file

In [1], all files are written in .grm file. @pasindud is there any official documentation for learning grm.  Because, I wanna contribute to Bn Text Normalization. Is it a compiler design language?
[1] https://github.com/google/language-resources/tree/master/bn/textnorm

To start you can follow the documentation here
http://www.openfst.org/twiki/bin/view/GRM/Thrax it will guide you through the thrax language

Thanks, @pasindud.

:+1:


Factory macro to reduce boilerplate

Generated with https://github.com/exoego/aws-sdk-scalajs-facade-generator/pull/104
Most AWSs fine with @Factory macro, but some are failing...
[error] (awsEMR / Compile / compileIncremental) Compilation failed
[error] (awsDynamoDB / Compile / compileIncremental) Compilation failed
[error] (awsDynamoDBStreams / Compile / compileIncremental) Compilation failed
[error] (awsKendra / Compile / compileIncremental) Compilation failed
[error] (awsOrganizations / Compile / compileIncremental) Compilation failed
[error] (awsRDSDataService / Compile / compileIncremental) Compilation failed
[error] (awsSSM / Compile / compileIncremental) Compilation failed
[error] (awsSageMaker / Compile / compileIncremental) Compilation failed
[error] (awsWAFv2 / Compile / compileIncremental) java.lang.NullPointerException

I am closing this.
@Factory marco is useful for hand-crafted facade, but regarding this repository, those factory methods are already auto-generated.
Macro reduces code, but add extra complexity for facade users (users need to understand factory method first).


Quick fix for a couple of memory leaks.

Fixes memory leaks as described in https://github.com/pusher/pusher-websocket-swift/issues/101
Note that this is just a quick fix for the issue that's affecting us and causing pretty big memory leaks. I think that a better fix would be to refactor how PusherChannel uses the facilities provided by PusherConnection as now it's just given the entire class instance to use.

Good point about the channels not needing the whole connection object. I'll take a look at that today.


Calling disconnect on a WebSocket using a FoundationTransport never indicates when the disconnect is completed.

Tangentially related to #853, when I call disconnect on my web socket, it calls through to engine.stop(). In its completion block, that calls through to self?.forceStop(), which then calls through to the transport's disconnect method, which disconnects everything but doesn't seem to have anything that calls back and tells the socket the disconnect has completed.
I suspect what's happening is that because the delegate for the two streams is set to nil before the streams are closed, all the delegate stuff that would normally get called when the sockets close is not getting called.
Is this considered:
a) expected behavior, and if we manually call disconnect we should just assume it eventually disconnected?
b) a bug, and there should be some kind of indication that the socket disconnected that goes back up through the delegates to the didReceive(event: WebSocketEvent, client: WebSocket) method?
c) Something else I'm not thinking of? 👽

To put more detail, there are two different flow comparing WSEngine and NativeEngine. When I look into NativeEngine, I realize that it creates new request every time start(request:) is called.

From that point, I come up with a solution to create new WebSocket instance every time I perform a disconnect / connect. From that point I don't have to know when old WebSocket instance is disconnected completely.
public typealias WebSocketEventCallback = (WebSocketEvent) -> Void
public protocol WebSocketServiceInterface: AnyObject {
    var baseURL: URL { get }
    var cookies: [HTTPCookie] { get }
    var isConnected: Bool { get }
    var eventCallback: WebSocketEventCallback? { get set }

    func connect(endpoint: WebSocketEndpoint) -> Cancellable
    func disconnect()
    func write(data: Data, completion: (() -> Void)?)
    func write(string: String, completion: (() -> Void)?)
}

public final class WebSocketService: WebSocketServiceInterface {
    public let baseURL: URL
    public let cookies: [HTTPCookie]

    public var eventCallback: WebSocketEventCallback?

    public private(set) var isConnected = false

    private var socket: WebSocket?

    public init(baseURL: URL, cookies: [HTTPCookie]) {
        self.baseURL = baseURL
        self.cookies = cookies
    }

    public func connect(endpoint: WebSocketEndpoint) -> Cancellable {
        disconnect()

        let request = createRequest(endpoint)
        socket = WebSocket(request: request, useCustomEngine: false)
        socket?.onEvent = { [unowned self] event in
            self.handle(event: event)
        }

        socket?.connect()

        return CancelToken(action: { [weak socket] in
            socket?.disconnect()
        })
    }

    public func disconnect() {
        socket?.disconnect()
        socket = nil
        isConnected = false
    }

    public func write(data: Data, completion: (() -> Void)?) {
        guard let socket = socket else {
            completion?()
            return
        }
        socket.write(data: data, completion: completion)
    }

    public func write(string: String, completion: (() -> Void)?) {
        guard let socket = socket else {
            completion?()
            return
        }
        socket.write(string: string, completion: completion)
    }
}

// MARK: - Helpers

extension WebSocketService {
    private func createRequest(_ endpoint: WebSocketEndpoint) -> URLRequest {
        var request = URLRequest(url: baseURL.appendingPathComponent(endpoint.path))

        for (key, value) in endpoint.headers {
            request.setValue(value, forHTTPHeaderField: key)
        }

        let cookiesValue = cookies.map { "\($0.name)=\($0.value)" }.joined(separator: "; ")
        request.setValue(cookiesValue, forHTTPHeaderField: "cookie")

        return request
    }

    private func handle(event: Starscream.WebSocketEvent) {
        Logger.shared.debug(msg: "Websocket received event: \(event)")

        switch event {
        case .connected:
            isConnected = true
            eventCallback?(.connected)

        case let .disconnected(reason, code):
            isConnected = false
            eventCallback?(.disconnected(.raw(reason: reason, code: Int(code))))

        case .cancelled:
            isConnected = false
            eventCallback?(.cancelled)

        case let .error(error):
            isConnected = false
            if let error = error {
                eventCallback?(.error(.unknown(error)))
            } else {
                eventCallback?(.error(.notSpecific))
            }

        case let .text(string):
            eventCallback?(.text(string))

        case let .binary(data):
            eventCallback?(.data(data))

        case .ping,
             .pong,
             .viabilityChanged,
             .reconnectSuggested:
            break
        }
    }
}


Fix runtime dto Status.State for deprovision type

Description
Changes proposed in this pull request:

Adjust the Status.State for deprovision type in Runtime DTO as the deprovisioning operation state can be domain.Succeeded when it still contains non empty executedButNotCompletedSteps. so as long as the latest operation is in type Deprovision and state is Succeeded, turn its runitme Status.State to StateDeprovisioning.
it's now causing the mop-agent issue.

Related issue(s)

/test pre-kyma-environment-broker

Hi, the endpoint is designed for KCP CLI and how your changes affects. Currently, the SKR which is not completely deprovisioned (some step needs a retry) looks like:
./kcp-darwin rt -S deprovisionIncomplete
GLOBALACCOUNT ID                       SUBACCOUNT ID          SHOOT       REGION         PLAN   CREATED AT            STATE       EU ACCESS
e449f875-b5b2-4485-b7c0-98725c0571bf   prow-keb-integration   c-46fb007   eu-central-1   aws    2023/10/20 01:07:45   succeeded   No
e449f875-b5b2-4485-b7c0-98725c0571bf   prow-keb-integration   ba915ad     eu-central-1   aws    2023/10/20 01:56:26   succeeded   No

after this PR is merged, it will look like:
GLOBALACCOUNT ID                       SUBACCOUNT ID          SHOOT       REGION         PLAN   CREATED AT            STATE       EU ACCESS
e449f875-b5b2-4485-b7c0-98725c0571bf   prow-keb-integration   c-46fb007   eu-central-1   aws    2023/10/20 01:07:45   deprovisioning   No
e449f875-b5b2-4485-b7c0-98725c0571bf   prow-keb-integration   ba915ad     eu-central-1   aws    2023/10/20 01:56:26   deprovisioning   No

@vvxxvvxx please contact with me

@piotrmiskiewicz I think this PR makes sense, because using Succeeded state for deprovisioned runtimes is not good. I would propose to use deprovisionincomplete state if there are any unfinished stages, otherwise use deprovisioned.

thanks for the comments. what about changing to the logic as below?
	case string(domain.Succeeded):
		dto.Status.State = pkg.StateSucceeded
		switch lastOp.Type {
		case pkg.Suspension:
			dto.Status.State = pkg.StateSuspended
		case pkg.Deprovision
		    if len(lastOp.ExcutedButNotCompleted) ==0 {
			    dto.Status.State = pkg.StateDeprovisioned
			} else {
			    dto.Status.State = pkg.StateDeprovisionIncomplete
			}
		}

@vvxxvvxx this looks good to me!

@piotrmiskiewicz suggested in mop-agent, if we call KEB without any options, we won't get the deprovision runtimes.
Now in mop-agent, we already set the KEB call without any options.
Further checked the codes, in KEB, when getting /runtimes req without any state option, it will exclude the deprovisioned instance. and for the filter state dbmodel.InstanceNotDeprovisioned, it's handled here . But now mop-agent can still receive the deprovisioning runtimes in state domain.Succeeded but with non-empty ExcutedButNotCompleted steps. I think this is caused by that when the deprovisioning operation is retried, in the operation, its state becomes domain.InProgress again. so in the retry, the deprovisioning operation becomes type = internal.OperationTypeDeprovision and state= domain.InProgress and it can't be excluded by the KEB call without any options.. then mop-agent can still receive these retrying deprovisioning operations which cause the mop-agent AVS status: 400 Bad Request #4564 issue.
So the problem is how we could exclude these runtimes having retrying InProgress deprovisioning operation?

the deprovisioning operations can't be excluded with AllOperation option. after discussion with @piotrmiskiewicz , we could analyze the runtime DTO returned and exclude the deprovision type runtime in mop-agent

/retest

/test pre-kyma-environment-broker
/test pre-kyma-environment-broker-presubmit-scanner

/test pre-kyma-environment-broker-presubmit-scanner

the test pre-kyma-environment-broker-presubmit-scanner failed in the gitleak check for the line. checking with @ralikio


Login

✅ Login Form

1Password Integration?

Register Form
Forgotten Password Mechanism
✅ Validate the user is still logged in by checking the "user" node in the /internal/ endpoint JSON response. Ensure that any persisted is completely cleaned up if this is different/empty.

✅ Logout Button
✅ Persistent login throughout app launch
Fabric tracking for log in & sign up

Progress made today with a login form, logout button, persistent login and improved user validation.
Chat has been updated to allow anonymous users to send messages.


Peatio and blockchain Professionals team

Please visit www.mxo2.co.uk or add skype ID physiver Or mail us

your fork is not working perfectly..

hi
what is not working ?
can you leave an issue in my fork?

not able to generate address...deposit of bitcoin etherium not working

hi
tell me your process you've done

share ur emailid or skype ..mine is physivert

live:apollo447722

deposit bitcoin not working...
not able to post error on your fork..

Hi,
Yes I also get error when trying to generate address with Apollo-IT fork. I followed the Ubuntu-development read me. Maybe I did something wrong, but seemed pretty straight forward.

Hi @Apollo-IT
its working after login but when I try to submit account then it will show error, I try to open fund link but it will show warning: first you need to submit account and when I submit with required details then getting same error, please check attached screenshot link.
https://user-images.githubusercontent.com/12297653/37991055-bca12662-3225-11e8-8802-5f44ed5f2dc5.png

Antier Solutions has programmers extend their technical assistance to help you create your own Peatio and blockchain platform that is the most secure, user-friendly and scalable. We also specialize in building web and mobile crypto wallets.
If you have any query, you may connect us via Skype. Here is the username<EMAIL_ADDRESS>Website : https://antiersolutions.com/cryptocurrency-exchange-development-company.html
Email us<EMAIL_ADDRESS>


Scroll to navigate through stash tabs zooms in and out

If when you try to navigate your stash with scroll wheel and ctrl and then cursor in the middle of the screen (ie not inside the inventory or stash windows) the camera zooms in and out as you scroll through your stash tabs and it can be quite annoying

There is currently no plan on developing a way of blocking the mouse input.

See #146 - but you can disable the in game zoom in the game settings for now.


Cannot specify laboratory location without hardcoding path

It is sometimes desirable to have the laboratory in the same directory as the configuration, making a self-contained experiment for testing, creating an archive tar or conveniently move from one location to another.
Currently payu requires a full path in the laboratory configuration option. This defeats the goal of a relocatable experiment.
One possible solution would be for payu to support some limited path variable expansion in config.yaml.
For example, to define a local laboratory in the control directory:
laboratory: $control_dir/lab

A less drastic solution would be to alter the logic here
https://github.com/payu-org/payu/blob/73ba06b47ed25b2801ebcd2eb9d00c3ebc79b72b/payu/laboratory.py#L77
to check for local paths (starting with ./?) as well as absolute paths.

ping @micaeljtoliveira (tokens/variables in paths)


devServer.outputPath must be defined in the webpack config

copy-webpack-plugin fails when configuring webpack as :
output: {
    path:       path.join(__dirname, 'build'),
    publicPath: '/',
    filename:   'js/app.js'
  }

instead of :
devServer: {
      outputPath: path.join(__dirname, 'build')
}

Right now, it's necessary to have both defined if you're using the devServer. When webpack uses the devServer, the output.path value is empty, so I have to use devServer.outputPath. This is a known issue: https://github.com/webpack/webpack-dev-server/issues/337

@kevlened It looks like this option is now removed in Webpack 2. Is this option still needed?


Update RustyBuzz dependency (and adjacent crates)

I set out to make sure bumping the RustyBuzz dependency in Typst didn't break anything. It turns out hard to do without ending up with multiple versions of dependencies and conflicting types, but I think I have it all sorted now.
The bigest catch is resvg is going to need a release too. I submitted a PR which is already merged, so now it's just a matter of waiting for a release. The other dependencies that need releases are in the @typst org, and relevant PRs are pending.

[ ] resvg: https://github.com/linebender/resvg/pull/846
[x] pixglyph: https://github.com/typst/pixglyph/pull/2
[ ] svg2pdf: https://github.com/typst/svg2pdf/pull/82

Once all the above PRs are available in release tags I can update this draft with the final version numbers to remove the Git dependencies. Until then I gueses it is a PoC unless you want to use Git dependencies for resvg and others during the development cycle.

unless you want to use Git dependencies for resvg and others during the development cycle

I typically only do that for dependencies which we control as to not get blocked from making a release of Typst because we're waiting for someone.

unless you want to use Git dependencies for resvg and others during the development cycle

I typically only do that for dependencies which we control as to not get blocked from making a release of Typst because we're waiting for someone.

That's fair enough.
I updated this PR with the tagged pixgraph release. Now it will have to wait on resvg to release, at which point the svg2pdf PR can merged and that crate released, then finally this one can be as well.


Threaded exporters prototype

A threaded prototype for exporters
Does not support:

Writed item limit
Resuming

But it's good for testing the threaded approach
Was hoping we could merge this fast so we can begin testing it in some of the exports that are failing because of connection timeouts, if it helps we can improve it and eventually enable it by default (now it's disabled by default because it's experimental)

Going to merge this for testing this feature in the kumo environment. We can address the remaining items in the near future, For the issues we have faced with ftp deliveries and deliveries of large amounts of data this seems to be reasonable enough to use at this time.


Select SNOTEL readings

Figure out all the sites we want and what data points and timeframe and hand off to Victor

West Slopes South SNOTEL Sites

Cougar Mountain
Sawmill Ridge
Huckleberry Creek
Corral Pass
Mowich
Morse Lake
Skate Creek
White Pass E.S.
Potato Hill
Spirit Lake
Sheep Canyon
Swift Creek
Lone Pine
Surprise Lakes
Would also be nice to have
Elevation
Coordinates (Lat, Long)


Convert from JSHint to ESLint and enforce tab indentation

Implementation for wchill#184

Rebased onto 1caabf9fc2b4662359682c65d370264e51f88cf5

To resolve the conflicts while rebasing, I simply took 1caabf9fc2b4662359682c65d370264e51f88cf5 verbatim, replaced all groups of 4 spaces with tabs, indented everything inside the outer anonymous function by 1, deleted the blank line just before the end of that outer function, indented a block of 4 lines that had been using 2-space indentation, and tested with eslint.
GitHub is probably saying there's a merge conflict because of the blank line deletion. :/

I'll take the opportunity to rebase again on the new head 69db50bd9cac5d683c209d4c1a4208dc4bbf5cfd, this time without deleting the blank line!

All right, I will wait

Whoops, forgot to say it's done - green tick from travis is back as well. :)


[HUDI-7707][DNM] Enable bundle validation on Java 8 and 11

Change Logs
Bundle validation with Java 8 and 11 are skipped in GH CI.  This PR reenables them by fixing the bot.yml.
This PR includes changes to make packaging/bundle-validation/ci_run.sh take the docker container name to avoid name collision in the same GH CI task.
Impact
Improves bundle validation coverage.
Risk level
none
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Bundle validation runs on Java 8 and 11 again.
<img width="1543" alt="Screenshot 2024-05-26 at 18 31 15" src="https://github.com/apache/hudi/assets/2497195/ad803a8c-219a-4631-948c-f77493e8

6348">

All bundle validations pass.  Merging the PR.


Add installation of monitoring tools

Prometheus + Grafana and configure them for Ubuntu
Let's explore options for Windows as well.

Windows is in #16


"++" initialization in kmeans2 fails for univariate data

This works fine for the other initialization methods.
from scipy.cluster.vq import kmeans2
kmeans2(np.random.rand(30),3,minit="++")

Error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/scipy/cluster/vq.py", line 706, in kmeans2
    label = vq(data, code_book)[0]
  File "/usr/local/lib/python3.7/site-packages/scipy/cluster/vq.py", line 210, in vq
    return _vq.vq(c_obs, c_code_book)
  File "_vq.pyx", line 211, in scipy.cluster._vq.vq
ValueError: observation and code should have same number of dimensions

Scipy/Numpy/Python version information:
1.2.1 1.16.2 sys.version_info(major=3, minor=7, micro=2, releaselevel='final', serial=0)

The issue still exists. From the traceback, it seems kmeans++ does not support 1D array.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/xiao/scipy/scipy/cluster/vq.py", line 814, in kmeans2
    code_book = init_meth(data, code_book, rng, xp)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xiao/scipy/scipy/cluster/vq.py", line 611, in _kpp
    init[i, :] = data[rng_integers(rng, data.shape[0]), :]
                 ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed


Any chance for adding coveralls/goveralls badge/checking?

Any chance we could enable the goveralls/coveralls checking to travis CI? I've had a brief look, and it didn't seem too difficult. Can submit another PR for this if you'd like.

Integrated!


Explore creating dashboard widgets with branding

Hi @apfister,
Could you explore creating a few dashboard widgets following the branding from style 1 in the attached?
Thanks!
PREP_Stylespresentation.pdf

You can commit directly to this branch https://github.com/PReP-Team/prep-prototype/tree/explore-dashboards

Hey @apfister,
Would be great to see what you've drafted so far if you can sync your progress.

@fgassert there isn't much there but i will look to push later this afternoon.

can we close/combine with #10 ?

Looking good. Let's keep this thread separate from the data preparation one.
I think we want to add a few additional things to each card to give them more context.
@sergioestella please weight in but generally:

Title
Topic tags?
Pop-up description with
Citation/bi-line
Link to dataset page and/or data download?

Sound good?

@fgassert alright, I'll move this forward and let you know when ready.

See issue #20 re dataset detail pop-ups.


Markdown support in Standard, Custom and Input windows

Relies on Markdown.Avalonia package for rendering Markdown.
Example from README:
var messageBoxMarkdownWindow = MessageBox.Avalonia.MessageBoxManager
    .GetMessageBoxCustomWindow(new MessageBoxCustomParams()
    {
        Icon = MessageBoxAvaloniaEnums.Icon.Info,
        ContentHeader = "Update is available! (not really)",
        ContentMessage = "## 🚀 Features\r\n\r\n" +
                            "- A cool feature\r\n\r\n" +
                            "## 📦 Dependencies\r\n\r\n" +
                            "- Bump antigravity from 1 to 2 @dependabot[bot]\r\n" +
                            "- Bump magic from 2 to 3 by @dependabot[bot]",
        Markdown = true,
        ButtonDefinitions = new[]
            {
                new ButtonDefinition { Name = "Update now", IsDefault = true },
                new ButtonDefinition { Name = "Maybe later", IsCancel = true }

            },
    });
messageBoxMarkdownWindow.Show();

@IhateTrains, you PR looks good and I understand your idea, but does it really necessary for a message box?
As I undestand the concept of the message box - this is a simple interation with the user. By another words program provide a simple message for user and user should say yes/no/ok/etc.
For me this type of window looks like a wizard page or something like this. I don't want to say this is a bad functionality, but maybe you need to move it to another namespace? What do you think about it?

@TopBaJLbD I think markdown just improve experience from using message box. It's strong feature, that may be used by smbody

@IhateTrains, you PR looks good and I understand your idea, but does it really necessary for a message box?
As I undestand the concept of the message box - this is a simple interation with the user. By another words program provide a simple message for user and user should say yes/no/ok/etc.
For me this type of window looks like a wizard page or something like this. I don't want to say this is a bad functionality, but maybe you need to move it to another namespace? What do you think about it?

I did consider just creating a separate package as an extension for MessageBox.Avalonia, but I would need to modify most of the views' XAML files and anyway, so IMO it's better to simply contribute directly here.
The PR doesn't really go beyond the purpose of the massage box, it just allows you to render your message in a prettier way. Let's take the "update available" msbox for example. Showing a changelog of the new version is needed for the user to make an informed decision, and showing it in a prettier markdown form makes him more likely to actually read it.


"Share" does not work in Chrome App

This version of colaboratory is no longer supported, please switch to https://colab.research.google.com.


No command-line parameters provided to antares-solver

AntaREST v2.14.2 and v.14.3rc1
Desktop version
Ubuntu 20.04
See https://github.com/AntaresSimulatorTeam/AntaREST/issues/1574#issuecomment-1590827741

fixed in v2.14.3 #1597


[DOCFIX] Update doc for cloning Alluxio to get deploy module

We updated all the other vagrant docs to recommend cloning instead of download, this is the last one

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20393/
Test PASSed.


when will ACK SQS be beta and available for user testing?

Is your feature request related to a problem?
I'm frustrated when SNS is working, but SQS is not and most developer need both.
Also that's no example how to create the SNS/SQS CRD
Describe the solution you'd like
Would like to have simple helm chart for standardise installation and example that show how to create the CRD.
Describe alternatives you've considered
I might write my own if it take too long. Our use case doesn't need the full feature, just basic queue and basic topic with some permission settings and tag.
@mhausenblas maybe you can help?

Hi @teochenglim, unfortunately the SQS service controller is not yet released. I don't have an exact timeline for it, but hoping to get it out into preview within the next month or so.

Would also like to see this as well. I've tried compiling the SQS controller from source, but am having issues (it's probably expected since it's not ready yet). Let me know if I should be making a separate issue for this.
The deployment we have is basically vanilla, except it uses an image built from source, has a serviceaccount with permission to create SQS queues (in ECK), and the following extra environment variables:
        - name: AWS_REGION
          value: us-west-2
        - name: AWS_ACCOUNT_ID
          value: "Redacted 12 digit account ID"
        - name: ACK_ENABLE_DEVELOPMENT_LOGGING
          value: "true"
        - name: ACK_LOG_LEVEL
          value: debug

When creating the following custom resource:
apiVersion: sqs.services.k8s.aws/v1alpha1
kind: Queue
metadata:
  name: sqs-test
  namespace: krong
spec:
  queueName: krong-test

The controller logs show the following error:
2021-07-09T07:01:41.930Z	DEBUG	ackrt	starting reconciliation	{"kind": "Queue", "namespace": "krong", "name": "sqs-test", "generation": 1, "account": "REDACTED", "role": "", "region": "us-west-2"}
2021-07-09T07:01:41.938Z	DEBUG	ackrt	marked resource as managed	{"kind": "Queue", "namespace": "krong", "name": "sqs-test", "generation": 1}
2021-07-09T07:01:42.139Z	DEBUG	ackrt	patched resource	{"kind": "Queue", "namespace": "krong", "name": "sqs-test", "generation": 1}
2021-07-09T07:01:42.139Z	ERROR	controller-runtime.controller	Reconciler error	{"controller": "queue", "request": "krong/sqs-test", "error": "MalformedInput: End of list found where not expected\n\tstatus code: 400, request id: 4f87e19c-cbf8-5e2e-bf19-b8fd3d6e2683"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
	/go/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90

The error is printed every 1~2s and doesn't go away until I delete the custom resource. Any help would be appreciated, thanks!

@rkevin-arch Taking a look and running the e2e test for this controller. I will update this comment with any findings.

Thanks a ton! FWIW, after some googling I found this smoke test in an older version of the repo. It's pretty out of date though, since it uses spec.name in the custom resource when the CRD only has spec.queueName. I'll see if I can shadow the next community meeting. Thanks for looking into this!

/remove-lifecycle stale
/lifecycle frozen


Automate and Extend Employee Onboarding

Mission: https://developers.sap.com/mission.cp-starter-ibpm-employeeonboarding.html
Hello together.
Hello together.
I am missing the maybe most central point in this turorial, is that it does never explain, who will see the Items
So here it is not explained, that you have to add other users to the buddies in the example to enable seeing a collaboration scenario. Also in the sample data , user id's are provided what also might not help for settign up in a trial account.
Maybe simply add a pattern for approver_mail_adress into the sample data to start the Worklflow from simulated event and give a hint to enable a team experience.
(Also there might be issues with the same workflow id used for the simple beginner  onboard and a uploaded onboard Workflow: maybe the tutorial should tell to change the id? )
Also there is no explanation to anything that has been done.
For sure everything is working, but i do not see the learning without having at least hints to the sources, where i can get a little bit of understanding what i am doing when clicking through the tutorial.

Thanks for you feedback, we will try to improve. The tutorial is not explaining how to create workflow, business rules and therefore it explains on a high level what this scenarios is all about and how to set it up and run it in quick time. If you want to learn the details on these services then you can try out Getting Started tutorials.
"add other users to the buddies in the example" - this scenario is for trial landscape and it is not advised to add members in trial landscape because it is more for personal trial and PoC purposes.
"user id's are provided what also might not help for settign up" - they are dummy user Ids just to showcase you how to add multiple users to the user task
"workflow id used for the simple beginner onboard and a uploaded onboard" - yes if you have already the workflow deployed with same name then it will override but you cannot change the workflow ID of the sample once created, and as said in this tutorial we are not teaching to create workflow but to quickly setup workflow and use for references.
"no explanation to anything that has been done" - the explanation is on the level of Employee Onboarding scenario like what does the workflow do, what does the rule created for etc. If you want to learn more on how-to create then try our getting started tutorials.
Hope that helps,

Hello Archana,
you might misunderstood , what I was writing.
You do not need to add users and prepare the scenarios but  someone that has his trial account can add another person as a user to his trial account and add the connected email-address to the empData.buddies in the prepared test -json.
I think, it would be worth to explain that as a later or an optional step in the tutorial.
Only then 2 people can try out something like a usual workflow is made for.
For me to just my own Items in my inbox is pretty useless.
And for me this is the missing link to have the minimal set to get an imagination how a workflow process would work. For me that needs a collaboration of at least two different users.
And this are the 2 getting started "Tutorials" : You can just not learn a lot by simply doing them and it could be improved very easily by explaining, what a user is doing together with just saying what to do to see a result.
At least by linking the steps to a help or a more in depth tutorial or whatever.
Beste Grüße/Best regards
Ulrich Becker
Phone +49 89 3547 182958
From: Archana Shukla @.>
Sent: Tuesday, June 15, 2021 2:25 PM
To: SAPDocuments/Issues @.>
Cc: Becker, Ulrich @.>; Author @.>
Subject: Re: [SAPDocuments/Issues] Automate and Extend Employee Onboarding (#419)
Thanks for you feedback, we will try to improve. The tutorial is not explaining how to create workflow, business rules and therefore it explains on a high level what this scenarios is all about and how to set it up and run it in quick time. If you want to learn the details on these services then you can try out Getting Started tutorials.
"add other users to the buddies in the example" - this scenario is for trial landscape and it is not advised to add members in trial landscape because it is more for personal trial and PoC purposes.
"user id's are provided what also might not help for settign up" - they are dummy user Ids just to showcase you how to add multiple users to the user task
"workflow id used for the simple beginner onboard and a uploaded onboard" - yes if you have already the workflow deployed with same name then it will override but you cannot change the workflow ID of the sample once created, and as said in this tutorial we are not teaching to create workflow but to quickly setup workflow and use for references.
"no explanation to anything that has been done" - the explanation is on the level of Employee Onboarding scenario like what does the workflow do, what does the rule created for etc. If you want to learn more on how-to create then try our getting started tutorials.
Hope that helps,

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSAPDocuments%2FIssues%2Fissues%2F419%23issuecomment-861453905&data=04|01|ulrich.becker%40knorr-bremse.com|617ff481777a4962a61d08d92ff8989a|66f6821e0a304a068b8b901bbfd2bc60|0|0|637593567052988976|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=q79ycHKt2vcnVmIW2x4q1Z%2Bzik4ybsBGU8myPAURnho%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL6I2WGDO4X2LAO3S7D7SSDTS5BBXANCNFSM46OQUDCA&data=04|01|ulrich.becker%40knorr-bremse.com|617ff481777a4962a61d08d92ff8989a|66f6821e0a304a068b8b901bbfd2bc60|0|0|637593567052998972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ohjjs%2F0DSgnLoEYkVlaOKZrHgT3jXfDI0PZISX2y0yU%3D&reserved=0.
Knorr-Bremse Services GmbH
Sitz: München
Geschäftsführer: Michael Hilzinger
Registergericht München, HR B 167 268
This transmission is intended solely for the addressee and contains confidential information.
If you are not the intended recipient, please immediately inform the sender and delete the message and any attachments from your system.
Furthermore, please do not copy the message or disclose the contents to anyone unless agreed otherwise. To the extent permitted by law we shall in no way be liable for any damages, whatever their nature, arising out of transmission failures, viruses, external influence, delays and the like.


[#47] Update About Us page to include team member (Myat) details

#47

Codecov Report

Merging #80 (c6236ac) into master (c20bcf7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20bcf7...c6236ac. Read the comment docs.


Structure editor bug

This is now fixed in "open_structures_for_edit". To reproduce: one the first page of the structures importer, select an occtype and then go to the second page where you assign occtypes. Go back to the previous page and select a different occtype column header. When this happens I basically reload the second page with the new data.

Confirmed.


OPtANNe-R

BIGANN submission for GraphANN using Intel Optane Persistent Memory (high recall HW)

@sdongaonkar Hey, catching up with the PRs.   Are the two OptANNE PR's intended to be different submissions?  I think we already discussed this in email, but I just wanted to make sure:
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/64
https://github.com/harsha-simhadri/big-ann-benchmarks/pull/63


Implement Podcast API

https://developer.spotify.com/community/news/2020/03/20/introducing-podcasts-api/

+1

Have you started working on this? If not, I might take a stab at it.

Not yet.
Sure, feel free to go at it.

OK. Can you create a branch I can push my changes to? I've made several changes and it seems to be working nicely.

Please create a pull request
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

Ah ok. You work with the fork-pull approach. No worries. I sent you a pull request.

The podcast API has been implemented in v6
https://github.com/JohnnyCrazy/SpotifyAPI-NET/blob/b3670e5636155e1ef193d220db8be8dfb3544634/SpotifyAPI.Web/Clients/Interfaces/IShowsClient.cs
https://github.com/JohnnyCrazy/SpotifyAPI-NET/blob/b3670e5636155e1ef193d220db8be8dfb3544634/SpotifyAPI.Web/Clients/Interfaces/IEpisodesClient.cs
If you have more feedback/problems/suggestions, feel free to reply here or open another issue!


fix issue #612 temporary

https://github.com/Dataman-Cloud/swan/issues/612

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   19.59%   19.59%
=======================================
  Files          29       29
  Lines        1745     1745
=======================================
  Hits          342      342
  Misses       1359     1359
  Partials       44       44


Zipformer missing bias parameter

Hi Authors,
SimpleUpsample is missing the bias parameter.
Thanks for the model - it's been a treat to go through this incredible paper, thanks for the hard work and for open-sourcing 🥳!

I think the comment should be updated.
It is there for zipformer v1.
Please see
https://github.com/k2-fsa/icefall/blob/a43480af47896329e82917d89ceee65f15afbf25/egs/librispeech/ASR/pruned_transducer_stateless7/zipformer.py#L817

we recommend zipformer.v2, which is the one in the.paper.


Upgrade uglify & include (now-supported) streaming dependencies

Change-Type: patch
These upgrades let us bundle correctly when using dependencies with ES6 features (mainly const), and this also means we can stop excluding dependencies like rindle/zlib/progress-stream that might be useful, and will be required once the new resin-request is released (i.e. https://github.com/resin-io-modules/resin-request/pull/116).

This is required for #529, but I'm doing it as a separate PR because we need to merge it before resin-request gets released (or all SDK builds will fail), and we can't merge #529 until the API parts for it are all in production.


Add support for https.

The start() function in fresh is starting an ordinary web server, but I didn't find a function that would start a server with TLS. So I had to define a function myself using serveTls() in Deno. And is there a convenient function for that purpose in the future? For example: startTls()?

startTls sounds like a good idea. I welcome a PR :)

Should be resolved using deno >= 1.35.0


Web -  Magic input showing along with delivery failure page for suspended accounts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Signout if you are signed in
Use a suspended email to sign in<EMAIL_ADDRESS>Enter the email
Click next

Expected Result:
Only delivery error page should be shown
Actual Result:
Magic input showing along with delivery failure page for suspended accounts
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev <IP_ADDRESS>
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/377aeef1-66c9-420f-bd80-6cc6e9df2fdb
https://github.com/Expensify/App/assets/93399543/4817dea7-00ec-4460-bbbf-475bdd6d587d
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690210023703719
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
magic input showing along with delivery failure page for suspended accounts
What is the root cause of that problem?
Root cause of the issue is the wrong logic or we could say missed check in getRenderOptions() in SignInPage.
https://github.com/Expensify/App/blob/33ed1672b7292725081ef73caf80667a77075357/src/pages/signin/SignInPage.js#L65-L67
Here when in response to api call to /beginsignin we receive hasEmailDeliveryFailure true for the suspended emails, then we are showing delivery failure page using shouldShowEmailDeliveryFailurePage. And for showing magic input form we have boolean shouldShowValidateCodeForm and as visible in the code above, it does not check for the suspended emails. That is why we see both magic input and delivery failure page together since both booleans evaluate to true in such case.
What changes do you think we should make in order to solve the problem?
We need to check for suspended emails too before showing magic input form and for that we can add an additional boolean AND to the shouldShowValidateCodeForm and render the code form only when shouldShowEmailDeliveryFailurePage (or hasEmailDeliveryFailure) is false meaning the account is not suspended.

Results

### What alternative solutions did you explore? (Optional)
Not sure if welcome header is supposed to be shown with delivery error page, if not, similar condition can be added to that too

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Looks like the fix for this has been CPed, I'll test on staging to confirm

Looks good:

Closing this out and I'll check it off the deploy checklist


Add s3 minio support

Allow skbn to copy files from k8s to Minio S3 endpoints and viceversa.

fixes #4

Looks great! Thanks for this contribution!


Update CLI command names

This pull request is focused on the new functionality and updates to the command line API. It includes:

Update CLI command names to match the OCaml API (read -> get, ls -> list, write -> set, rm -> remove)
Switch from Cmdliner.Term.pure to Cmdliner.Term.const
Move some of the command line flags (--root, --contents, ...) to the COMMON OPTIONS category to avoid cluttering the command specifics options
Add the ability to use a custom commit author and message from the command line

Alright, just rebased this branch.

For some reason the history is completely messed up, so I have cherry-picked your patches in https://github.com/mirage/irmin/pull/501


change isPlaying state to false when stop func gets called

Calling a stop() on SubsonicPlayer instance doesn't trigger audioPlayerDidFinishPlaying so the isPlaying state doesn't change back to false. My fix is to toggle isPlaying inside the stop() func body.

Thank you!


Do something useful on /gloss with no command

My first hunch upon hearing about /gloss is just to run it with no arguments. Ideally this would do something useful, like be an alias for /gloss help, perhaps?

Hi @ab! It should already be aliased to /gloss help ... what behavior are you seeing?

Here's the code

I swear slackbot gave me some generic error saying "Something went wrong", but now I can't reproduce it.


Allow to set options to presets

To customize a preset behavior, it would be nice if we can specify preset options. The preset option may have an object to do that.
{
  "input": "src",
  "output": "dist",
  "preset": {
    "name": "some-houl-preset",
    "options": { /* the preset options goes here */ }
  }
}

Then, in the some-houl-preset, the preset author can define houl.config.js with a function that receive the preset options as its 1st argument.
module.exports = function config(options) {
  // Must return preset config
  return {
    rules: {
      // ...
    }
  }
}

...and we may want to pass some options object into each task as well. Each rule object could have it.
module.exports = function config(options) {
  // Must return preset config
  return {
    rules: {
      js: {
        task: 'scripts',
        options: options.js
      }
    }
  }
}

Task functions will receive the options as its 2nd argument.
exports.scripts = function(stream, options) {
  return stream.pipe(buble(options))
}

Implemented via #29


Cannot display 10 stars, shows all empty

Using either:

input type="hidden" class="rating" data-start="0" data-stop="10" readonly="readonly" value="10"
Or even:
input type="hidden" class="rating" data-start="1" data-stop="10" readonly="readonly" value="10"

Displays empty stars.. No option for full rating.
Also, setting data-fractions="2" doesn't display value="9.5" properly.
I'm talking about setting manual values only.

Thanks for reporting the issue.
This issue was solved in #6. It was my fault that I forgot to update the minimized version appropriately.
Check again with the updated version and let me know if it doesn't fix the issue.


add more test

Codecov Report

Merging #12 (1c90de6) into main (dd89568) will increase coverage by 1.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   63.35%   65.21%   +1.86%
==========================================
  Files           8        8
  Lines         805      805
==========================================
+ Hits          510      525      +15
+ Misses        295      280      -15

Impacted Files
Coverage Δ

src/napari_spatialdata/_model.py
72.72% <0.00%> (+1.94%)
:arrow_up:

src/napari_spatialdata/_widgets.py
61.30% <0.00%> (+2.29%)
:arrow_up:

src/napari_spatialdata/_view.py
80.83% <0.00%> (+5.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd89568...1c90de6. Read the comment docs.


Added more options

Changes made

Implemented Runnable trait for commands
added more options [ version, commands ]

Very cool! Thanks a lot :D


Add a license to the repository

I recently came across your project quantum-programs and I noticed that the repository github.com/watermelonich/quantum-programs currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Of course, thanks for contributing!

Thank you!

This user @cbjuan has bulk spammed many repos with this same request. https://github.com/search?q="I+recently+came+across+your+project"+"and+I+noticed+that+the+repository"+"currently+does+not+have+a+license+specified."&type=issues. If you're happy with Apache2 License great, just wanted to make sure you were aware. The use of Apache2 has implications for you and your work being reused later, while the upstream library is Apache2 I just want to share this with you to ensure you're aware of what this user is asking and the implications for use of your work.

Hello, thanks for letting me know. I'm fine with the Apache 2 License as these qml programs were made as practice while I was learning Qiskit. But, I do find the repo license issue spam kinda weird


Examples tests revamp.

The tests for examples have proven to be a point of friction for us. This PR aims to fix that.
Try it out locally with turbo run test --filter="turborepo-examples-test-*" --continue

There is a bit of technical debt associated with these tests, I'm told. Historically, these tests were used more like integration or end-to-end tests to ensure that turbo was behaving predictably on example monorepos.
Today, we're making the explicit commitment that these tests no longer need to serve that goal. Instead, they are for ensuring that the examples work correctly against the latest published version of turbo.  We're making sure that users can trust that npx create-turbo@latest [-e <some-example>] will work out of the box.
Problems to solve

[x] Complexity

It appears that our scripting once handled swapping out package managers for every example. We no longer feel the need to test our examples in this way. We trust that the rest of our CI has managed these complexities way before they make it to end users downloading an example.
There is also layers of scripting around platforms, git, and manipulating the package manager. I'm not totally sure what these were for - but they're not useful for our new goals.

[x] Flakiness

I suspect that we're not actually surfacing broken examples in these tests. I've received reports from users that our examples didn't work out of the box - while these tests are green. 🧐  As we peel back the technical debt, I believe we will find out if this is indeed the case.
I've personally experienced these tests fail at unexpected times, pass at unexpected times, and pass and fail by re-running the same job multiple times with the same code.
Going back to our freshly stated goals, the tests catch problems way too late (when they do truly catch problems). The examples can potentially go untested against the latest published version of turbo indefinitely.

[x] Testing the wrong thing

The tests are currently set up to do snapshot testing using Prysk. However, we no longer are interested in trying to find drift in logs in these tests so we don't need this log capturing layer.
This Prysk layer also adds a heavy, third layer of task runner management between terminal command and final package.json script execution. The other two are turbo.

[x] Debuggability

Understanding and debugging the current test setup is extremely difficult. I have my suspicions that this also goes back to the Prysk layer as it makes logs quite hard to read. I've found it also swallows logs during the debugging process that would have been useful to see earlier.
I expect that this issue will fix itself as we address the complexity and flakiness concerns above.

[x] Performance

I have a hunch that these tests can just...be faster. This will likely be a tailwind of addressing the aforementioned complexity.

Non-goals

There are a few examples that we don't test due to their own internal complexities (namely, Docker). We could choose to test these examples in the future but we're preferring to fix what we already have first.
We do not want to test the examples against turbo@HEAD.

Key changes

No more Prysk!: My first experiment was to get Prysk out of the way to see what was going on more clearly and, well, I kept not using it and kept getting closer to my goals.
No more snapshot tests: Because we're not concerned about drift in the examples, we can stop doing snapshot tests. This piggybacks on the "No more Prysk" idea.
Way less scripting: I love Bash just as much as the next developer. But, alas, the new codepaths use way less of it. Fewer steps, less work, trimming the fat of things we used to do that we no longer need to.

Results

[x] These updates caught issues in the existing examples! I'm not certain how these issues were being covered up in the previous implementation but I've confirmed three important fixes that were being hidden. They were caught in CI and I fixed them. Early win!
[x] The tests now have significantly less complexity, only doing the work that they really need to be doing.
[x] From my experimenting, the tests are now deterministic. I can quickly reproduce issues on my local machine that I found in CI. I've also had success purposefully creating errors and resolving them.
[x] They're faster. Locally testing is approximately 90% faster for me while CI is about 50% faster.  This likely a symptom of being simpler.
[x] They're more predictable, more debuggable, and I've included a README to ensure continued understanding of these tests in the future.

TODO?

[ ] We could choose to run these tests on a cron to ensure we're keeping up with published sooner. This PR still leaves us open to not testing the examples against latest. (This is slightly mitigated by Dependabot always running on Mondays. We would find out that latest broke an example then.)

We should add the examples to the smoke tests we run before releasing. Right now we only run examples tests if examples get changed (or if the CI config gets changed). Since these tests are explicitly for testing if the latest version of turbo works with examples, we should block new releases on working examples

I haven't gotten to get familiar with the release CI yet so wasn't going to introduce that here. If that's something, we'd like to do, happy to do it in a follow-up PR.


Bug: Not detecting some BT devices.

in OpenDroneIdDataManager.java at line 54 the offset is hardcoded and assumes the payload always starts with a RemoteID packet, some devices will send additional information offsetting the RemoteID packet.
example packet from RemoteID transmitter: [0x02,0x01,0x06,0x02,0x0A,0x08,0x1E,0x16,0xFA,0xFF,0x0D,0x11,0x12,0x07,0x0F,0x14,0x14,0xF1,0x4B,0x94,0x14,0x1E,0x16,0xBE,0xBD,0x82,0x00,0x82,0x00,0x01,0x00,0x6C,0x11,0x59,0x01,0x01,0x00]
Line54: OpenDroneIdParser.parseData(data, 6, result.getTimestampNanos(), logMessageEntry, receiverLocation);

My Apologies, yes you are correct, the issue was that the device I am currently using does send additional header data if the config allows for connections.
This is not a bug.
Thanks,
Gil.


docs(README): Note the sample app lives in a different repo now

I've been trying to find it for a few until a log settings.gradle cleared it up for me :)
Signed-off-by: Dmitriy Volkov<EMAIL_ADDRESS>

Hi @wldhx ,
Thanks for the PR (and sorry for the loooooog delay). You're PR content is good; but the REAMDE.md already contains what you want to merge (it have been edited after your PR, fixing #216):

It is an Android Studio (gradle) project containing the SDK module. https://github.com/vector-im/riot-android is the sample app which uses this SDK.

I close your PR then :-)
Benoît


Fix Entity & Review Route

API Test
Entity
Create

Get

Get by ID

Update

Delete

Review
Create

Get

Get by ID

Update

Delete

Hi @raypinto , need your help to review and merge this PR. Thanks in advance.


oppo Android 11 does not execute Geolocation.getCurrentPosition

Environment

Platforms

Versions

Android:11
iOS:
react-native-geolocation:3.1.0
react-native:0.72.7
react:18.2.0

Description

Reproducible Demo

Error screenshot：


Updating auth README example

Spotted this small issue with an example in the auth/README.md while working on an app. handlePendingSignIn doesn't take a callback anymore and instead returns a promise.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Great -- thanks for finding this @poffdeluxe


Exercise 6.33(Generics Version) is gone

The generics version of exercise 6.33, which is writing a recursive function to print the contents of a vector is gone.

check: https://github.com/Mooophy/Cpp-Primer/commit/bffea18f30774494bc204594d5459ec560bfada7
The version was deleted, but the README didn't update.

Thanks. @pezy


Clean up /service-access-application-cluster.md

Performed 2 actions:

Run npx prettier -w to remove extra blank lines or add a blank line between paras
Add a code mark none if it is an output

Preview:
https://deploy-preview-39585--kubernetes-io-main-staging.netlify.app/docs/tasks/access-application-cluster/service-access-application-cluster/

Thanks @windsonsea .
/lgtm

/approve


Mobile version not working anymore

I would always have the the script play on an older version of Firefox (59/60) that could install greaseymonkey and install the script, and it would work pretty well, but in the last 2 months something happened and it won't play in Firefox mobile anymore, any ideas what changed?

I downloaded 3.4.3 and it's working again, I dunno if you want to keep it in mind going forward to keep it compatible


Can't invoke Show Terminal Accessibility Help with keybindings

Testing #171862
No matter whether I use Shift+F1 or set it to some other keybinding, I cannot seem to invoke this command with a keyboard shortcut--only from the command palette.

I cannot repro on mac, windows, or linux, could you pls run Developer: Toggle Keyboard Shortcuts Troubleshooting and provide me with the logs?
The terminal has to be focused btw for it to work

Yeah the terminal was focused in my testing. Weirdly enough, seems to work now--definitely wasn't working before though.

I've run into this as well. Here's the output when turned on Toggle Keyboard Shortcuts Troubleshooting:
2023-01-24 19:45:48.902 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:48.925 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:48.925 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:48.925 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:48.925 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.404 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.404 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.404 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.405 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.405 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.435 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.435 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.435 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.435 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.435 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.482 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.482 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.482 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.483 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.483 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.513 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.514 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.514 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.514 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.514 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.544 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.545 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.545 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.545 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.545 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.577 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.577 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.577 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.577 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.578 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.608 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.608 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.608 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.609 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.641 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.642 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.642 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.643 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.643 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.673 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.673 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.674 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.674 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.675 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.703 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.703 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.703 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.703 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.704 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.735 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.736 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.736 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.736 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.736 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.767 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.767 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.767 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.768 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.768 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.798 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.798 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.798 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.799 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.799 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.844 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.844 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.845 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.845 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.845 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.877 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.877 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.878 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.878 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.879 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.907 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.908 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:49.909 [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-01-24 19:45:49.909 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-01-24 19:45:49.910 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-24 19:45:49.916 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:49.917 [info] [KeybindingService]: | Resolving shift+F1
2023-01-24 19:45:49.917 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.terminal.showAccessibilityHelp, when: terminalFocus && terminalProcessSupported, source: built-in.
2023-01-24 19:45:50.063 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:50.063 [info] [KeybindingService]: | Resolving shift+F1
2023-01-24 19:45:50.063 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.terminal.showAccessibilityHelp, when: terminalFocus && terminalProcessSupported, source: built-in.
2023-01-24 19:45:50.483 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-24 19:45:50.483 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-01-24 19:45:50.484 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.

This was on my Surface with Windows 11. I wonder if it has to do with needing to press the Windows function key to get my F1 key? I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer

Alt+Function+F1 works for showing the regular accessibility help

I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer.

This is expected as to use F1, the function key needs to be activated.

Alt+Function+F1 works for showing the regular accessibility help. I wonder what that code is doing to work?

Alt in the terminal does funny things on Windows/Linux, which is why we went with Shift instead here

On Windows, when I set the keybinding to alt+f1, it's not a valid chord and the result from the keybinding service is workbench.action.showCommands

shift+f1 isn't working for me


Im/options

Not 100% finished yet, this is mainly here for feedback so far please..

[x] Retrieve redis settings from environment variables
[x] Add redis sessions
[x] Allow enable/disable via admin interface
[ ] Stop admin changes if a service is enabled via extender
[ ] Warn if no valid config present

Are the Enabled Disabled events necessary? I don't think we need them.

No, I just removed that from the PR ;)

Abandoning this in favour of #10 and turning this extension into a library.


[svcat] svcat should validate input parameters with JSON Schema before submission.

svcat should have and use the JSON Schema from the catalog to validate requests before sending the request to service catalog / broker.
Maybe svcat is too soon? Maybe just in service catalog? Seems like a useful feature for svcat.

I recommend not papering over any gaps in the APIs with the cli. That way when it's fixed in the API, it's fixed for everyone, and not just people going through the cli.
If the error returned by a request with parameters that don't match the json schema (if present) is poor or not properly handled, I'd consider that a bug in the API (either the brokers or svc-cat depending on who's doing the validation).

Oh, I am not saying the CLI should be the only place we test this. I am saying the CLI should test the Json Schema for the given input and give instant feedback, and then the api server does the same thing for service catalog, and the broker needs to check again in their own validation.
Fast fail for the user.


Processing and viewing the CBOM

I miss some links to existing or upcoming frontends to work with or visualize the resulting CBOM file. Could we have some chapter in the README.md for referencing any current tools for this?

Thank you for your feedback @kkretsch and your interest in CBOM! I've added commit https://github.com/IBM/CBOM/commit/26656c1dcc2e8850b291e3c01e75a66c063e9f1b which includes references to tooling related to CBOM.


Feature/159 Fix a bug and promote performance

Fix a bug, the class of AbstractWorkerProvider decision the return value of workerInstance method , will lead to start double worker.
Promote the data persistence performance.

Coverage decreased (-3.5%) to 68.668% when pulling eea42183a6c4d3f610003704356ac5b0d961da91 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-3.6%) to 68.659% when pulling 67cb71e09e53ecaf83ac6bac7bd799e3b0bc7d93 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-3.6%) to 68.644% when pulling 91ab61b9feb5e621c270330009e04d7829498de6 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-2.3%) to 69.939% when pulling d772b95ce51363e5758d7b0a21d94a4cf4569eb2 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-1.5%) to 70.715% when pulling 15684ea9344fec1f0009f4be2714b7d9438eeadf on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-1.0%) to 71.216% when pulling e77abe23a61d6c0a0850b9184c03b3aedaa1ba56 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-0.9%) to 71.337% when pulling c43d375d81babac796bb18235ea7142e073cd988 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-0.9%) to 71.331% when pulling d4eed42ab87491ab9ccbda36b667b3a6ac52fa57 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.

Coverage decreased (-0.9%) to 71.331% when pulling d4eed42ab87491ab9ccbda36b667b3a6ac52fa57 on feature/159 into c172f34c0b26496ee3241c644f32216cb46f690f on feature/3.0.1.


chore: fix rpc message typings & clean up some tsdocs

(the above posthumous review is here for convenience, and will be extracted later)


Prefer idiomatic examples

I reckon we'd benefit from making the examples more idiomatic. The problem with foo/bar etc is they can be quite abstract and it also leaves plenty of room for different interpretations. I'm not sure how well these work for our international developers either.

How about we merge #5 and then rework it into something simple but realistic.

Sure!


Update Azure Core Shared Codes 2023-11-06_16:02:02

Update Azure Core Shared Codes 2023-11-06_16:02:02

This PR is no longer needed, since it's covered in https://github.com/Azure/autorest.csharp/commit/457582ae0c3f7d67b9630dda50ca028335d8a2f1


Move "forgot password" button below the password input

It's not easy to use "Tab" when inputting the username and password.

Thanks. Will fix.


Pasting html text sometimes gets truncated

From what I have noticed, there is a difference in behavior with the paste logic when there are existing text and when it is a blank content.
In the UIKitDemo project,
https://github.com/stevengharris/MarkupEditor/assets/4402214/d9bbe8d6-67ae-485c-befe-85f6cfad73b0
It seems that only the first item is copied, while the others are truncated.

Looking from Safari Web Inspector, the issue lies in beforeTarget.parentNode.insertBefore(nextSib, beforeTarget);, where the error "null is not an object (evaluating 'beforeTarget.parentNode')" is being thrown from.
const beforeTarget = anchorNode.nextElementSibling; is giving null for beforeTarget and the anchorNode.outerHTML is

 for an emptied web view.

Fixing some of the HTML pasting issues I notices when working on https://github.com/stevengharris/MarkupEditor/issues/128 is what has taken a little longer. I think this is fixed, but I will double-check. Thanks.

I had not fixed this in the work I was doing in https://github.com/stevengharris/MarkupEditor/issues/128, but I have it fixed now and will fold it in there.


Creates invalid eml file

The current template for the eml file save by the add-on is
X-Unsent: 1
To: %to%
Cc: %cc%
Subject: %subject%
Content-Type: text/html; charset=UTF-8
MIME-Version: 1.0
<space><space>
%body%`

Note that the <space><space> before the body is an edit from me. In the code this are two normal spaces.
According to the RFC, there must be however a completely empty line between both messages.
https://tools.ietf.org/html/rfc5322#section-2.1:

The body is simply a sequence of
characters that follows the header section and is separated from the
header section by an empty line (i.e., a line with nothing preceding
the CRLF).

Hi lieser,
This is now fixed (with other "minor" fix), thanks for your feedback.
https://github.com/pgpgeek/thunderbird-addon-eml-editor/commit/5298db80f04c3077d845a8ae1b7a1ff2774f7293

Thanks for the quick fix.


Running outset --login causes infinite loop of tasks

If you run outset --login to test a script, outset will run an infinite set of scheduled tasks.
log stream --predicate 'subsystem == "com.github.outset"' --debug --info
Filtering the log data using "subsystem == "com.github.outset""
Timestamp                       Thread     Type        Activity             PID    TTL
2023-01-12 13:32:18.415915-0800 0x12b2dd   Debug       0x0                  74262  0    outset: [com.github.outset:main] Processing scheduled runs for privileged login
2023-01-12 13:32:18.744910-0800 0x12b2dd   Debug       0x0                  74262  0    outset: [com.github.outset:main] ownerID for /usr/local/outset/login-privileged-every/upgradeWatcher.py : 0
2023-01-12 13:32:18.744985-0800 0x12b2dd   Debug       0x0                  74262  0    outset: [com.github.outset:main] posixPermissions for /usr/local/outset/login-privileged-every/upgradeWatcher.py : 755
2023-01-12 13:32:18.745072-0800 0x12b2dd   Debug       0x0                  74262  0    outset: [com.github.outset:main] Running task /usr/local/outset/login-privileged-every/upgradeWatcher.py
2023-01-12 13:32:19.285239-0800 0x12b2dd   Debug       0x0                  74262  0    outset: [com.github.outset:main] Completed task /usr/local/outset/login-privileged-every/upgradeWatcher.py with status 0
2023-01-12 13:32:29.309848-0800 0x12b389   Debug       0x0                  74306  0    outset: [com.github.outset:main] Processing scheduled runs for privileged login
2023-01-12 13:32:29.649458-0800 0x12b389   Debug       0x0                  74306  0    outset: [com.github.outset:main] ownerID for /usr/local/outset/login-privileged-every/upgradeWatcher.py : 0
2023-01-12 13:32:29.649522-0800 0x12b389   Debug       0x0                  74306  0    outset: [com.github.outset:main] posixPermissions for /usr/local/outset/login-privileged-every/upgradeWatcher.py : 755
2023-01-12 13:32:29.649583-0800 0x12b389   Debug       0x0                  74306  0    outset: [com.github.outset:main] Running task /usr/local/outset/login-privileged-every/upgradeWatcher.py
2023-01-12 13:32:30.193023-0800 0x12b389   Debug       0x0                  74306  0    outset: [com.github.outset:main] Completed task /usr/local/outset/login-privileged-every/upgradeWatcher.py with status 0
2023-01-12 13:32:40.222375-0800 0x12b404   Debug       0x0                  74316  0    outset: [com.github.outset:main] Processing scheduled runs for privileged login

Latest build in #1 fixes this.


A problem with doublesplit.

Sometimes, when double splitting, the cells ignore cells/ or viruses on it's way.

can you show the video?

@Barbosik What is your email address? Can you please email me<EMAIL_ADDRESS>

@Barbosik I don't have a video, sorry.
@TheGoldenXY Not in my issue, please.

@NatsuTheGreat Same when popsplitting, since its also a doublesplit -.- like i said here...

I'm going to see if I can do anything about it tomorrow. Going to bed now.


Convert from schema to function

@siliconlad do we want the validation to fail if the parameter description is missing from the schema? At the moment it fails but I feel like it is more of a side effect than something we would like to happen. The same can be said for the default value I guess.
Also, do we want to support tune schemas?

Ah sorry. Slight confusion here I think.
I mean converting what we get from OpenAI. Such that we can convert it into a function that can be executed.

Ah ok I understand now, will do!

Should be done with ef26dde


Migrate from pod.stanford.edu to pod-prod.stanford.edu

pod-prod is the new ubuntu server.
Currently waiting on a db migration: https://github.com/sul-dlss/operations-tasks/issues/3245#issuecomment-1387398153

See details on the pending db migration: https://github.com/sul-dlss/operations-tasks/issues/3245#issuecomment-1400749607


channel data inconsistency between peers

Playing around with lnp-node, I noticed some inconsistencies between the view of the two peers over a channel they have in common.
My setting is composed of:

2 lnp nodes, version 0.1.0-beta.1, let's call them A and B
1 rgb node, version 0.2.0-beta.4

My goal was to perform a LN transfer for both btc and one rgb asset, with the following workflow:

A listens for connections
B initiates peer connection
B proposes channel
B funds channel (btc)
B performs btc transfer
B refills channel with rgb asset
B performs rgb transfer

Here is a list of things that seem wrong to me:

[x] after step 4, B sees his updated local balance, while remote balance for A is still 0
[x] In step 5, A accepts the transfer even though the remote balance in her view is 0, so the transfer makes it underflow to 2^64-amt
[x] after step 5, B has total_payments: 1, while A has total_payments: 0
[x] after step 6, rgb balance appears as 'local' for both nodes
[ ] transfer --asset expects asset-id in the opposite endianess (big vs little -endian) than the one output in logs and lnp-cli info <temp_channel_id>
[ ] for A local_keys are the same as remote_keys, while for B they are different.
[ ] after step 2, A has her own node uri in the list of peers. Same happens later on as key of remote_balances

After having a quick look at the code I think I can fix at least some of the listed problems. The last two will require some debugging and I'm not sure I'll be able to solve them.
Can please anyone confirm these are not expected behaviors before I spend time fixing them?
EDIT: I'm working on this and I managed to solve issues identified by the ticked box.

I figured that asset transfer fails because of endianess inconsistency between input and output data, so I'll update it in the issue description.
In fact:

After step 6, the cli logs: adding 100 of 883926d7f25d99298a1c7b4fbd019df21d1d24a2bbfb63adacbc115f6b48d627 to balance and the same asset_id is shown in the asset field in the output of `lnp-cli info <temp_channel_id>.
This call fails: lnp1-cli transfer --asset 883926d7f25d99298a1c7b4fbd019df21d1d24a2bbfb63adacbc115f6b48d627 <temp_channel_id> 10
This call succeeds: lnp1-cli transfer --asset 27d6486b5f11bcacad63fbbba2241d1df29d01bd4f7b1c8a29995df2d7263988 <temp_channel_id> 10

I'm stuggling a bit with  the 7th point. From what i can see, remote_id is never set in src/bin/peerd.rs for the peer that receives the connection and in fact from the pov of A, a lnp-cli info <peer> returns an empty list for remote_id. However, it's still not clear to me how A gets to show its own nodeid in the list of peers, my best bet points at how id is assigned at line 203 in peerd.rs (b901fb0), since it contains local_node as nodeid.
I have the feeling that at that point in the workflow the remote nodeid is not yet available and it should be set later on, but I can't figure out where to get it from nor where it should be set in order to solve the issue. Any help on this is very well appreciated.

As for asset identifiers, I have the feeling that the cleanest possible solution would be to switch everything over to bech32 encoding, also for consistency with rgb-node. This could be obtained by having the rgb-node Asset api return a bech32 encoded string or by implementing a the conversion between hex and bech32 encodings in lnpbp::bp::chain::AssetId. Am I right?

Updates from 20.12.09 call:

asset identifiers will be encoded in bech32 from the next lnpbp core library release, so the related issue will be solved rather automatically at that point
nodeid is currently not exposed by the Noise-related part of lnpbp core library API, this will be done with the next release (either 0.2.[1+] or 0.3)

As a result, the best approach is probably to close this issue with a PR that addresses the lesser issue that I already solved and open a new one to just keep track of the missing points and point to the right info until lnpbp core library is released.

bugs 1-4 were solved by #32
bug 5 is waiting for an update in rust-lnpbp and has a dedicated issue #33
bug 6-7 are linked to each other and are waiting for an update in rust-lnpbp, here is the dedicated issue #34


Add Forgot Password feature in LoginActivity

Working on it :+1:

I would like to work on this

Go ahead :+1:

Alright

@iamareebjamal I am using POSTMAN and I am not receiving any email when I have send a POST request to receive the token.
As per the API, I sent a body of
  "data": {
    "email"<EMAIL_ADDRESS>  }
}

and I even received a response
{
    "message": "Email Sent"
}

Is this a bug in the server?

Yes

Raising an issue :+1: