feat: set up basic tests & CI pipeline

Why
The current library is very rudimentary, without any unit test or a CI pipeline. Let's give it a glow up 🪄
What

Added basic unit tests for AASA validation

Current test coverage (after this change): 13.5%

Fixed some small bugs discovered as part of adding the tests
Set up GitHub Actions pipeline for building & running tests
Added ability to validate a local AASA file so that we can use it in CI pipeline to validate the file pre-deployment

For example: yurl aasa validate --file=./path/to/local/file

> yurl aasa validate --help
Validate your link or local file against Apple's requirements

Usage:
  yurl aasa validate [<URL>] [flags]

Flags:
  -f, --file string   path to local file, will ignore the URL
  -h, --help          help for validate

Example of running the tool locally (without building the binary):
> go run cli/main.go aasa validate --file=./yurllib/testdata/apple-app-site-association
JSON Validation:                  Pass
JSON Schema:                      Pass

{
    "applinks": {
        "details": [
...

Nice Khoa! My only question would be why are the indents so big 😝 but I guess you're just matching the original style.

Haha if you're referring to Go's indentation, it uses tabs for indentation. And Github, for whatever reason, decided 8 spaces for tab is probably what people like the most!


remove senseless dynamic config to simplify code base

I get few days free times and want to fix crash bug in #116. But I found there are some noisy in the code base and actually is make sense.
This is a pre-cleanup PR to remove the dynamic config which are not actually make sense for now because the latest config will not be used by the reporter or matchers.

e2e tool needs to bump up.
Ref to https://github.com/apache/skywalking/pull/12506

Code test coverage seems upload fails.

/retest


Airline, ALE, and Normal background=NONE interaction

environment

vim: VIM - Vi IMproved 8.2 (Included patches: 1-2576) (macOS version - arm64)
vim-airline: https://github.com/vim-airline/vim-airline/commit/09dbd09ed3b6318ca4c3cda8f61f02f1bc8ce783
OS: macOS
Have you reproduced with a minimal vimrc: Yes
if you are using terminal:
terminal: Any
$TERM variable: xterm-256color
color configuration (:set t_Co?): 256
if you are using Neovim:
does it happen in Vim: Yes happens both in Neovim & Vim

actual behavior

The following configuration colors some airline character spuriously! (check the white triangle next to NORMAL in airline)
Command: vim -u airline.vim airline.vim
" File airline.vim
set nocompatible
filetype plugin on
set noswapfile
syntax enable
set background=dark
set number

call plug#begin('~/.vim/plugged')
Plug 'NLKNguyen/papercolor-theme'
Plug 'vim-airline/vim-airline'
Plug 'vim-airline/vim-airline-themes'
let g:airline_powerline_fonts = 1
Plug 'dense-analysis/ale'
call plug#end()

colorscheme PaperColor
let g:airline_theme = 'hybrid'

augroup AleRedrawStatus
    autocmd!
    autocmd User ALELintPost nested AirlineRefresh
augroup END

augroup fontscolors
    autocmd!
    autocmd VimEnter * nested hi! clear CursorLine
augroup END

hi Normal ctermbg=NONE guibg=NONE

expected behavior
Seems like a problem with color group usage, they should be independent of Normal colors's background. Commenting any complete command from line 19 onwards makes the problem go away.
screen shot (if possible)

@chrisbra It seems like the problem occurs because the foreground of that triangle somehow appears and disappears. So instead of a hairline right-pointing arrow it shows a solid triangle. I have also found a simpler way to recreate the problem: do :cd <somepath><CR> in vim. Here's a video:
https://user-images.githubusercontent.com/71736629/118080261-b175e480-b36e-11eb-9ec1-012f70a305a0.mp4

I think this is caused by terminal color being differently than what vim expects or can detect. Also, I really doubt this happens with any terminal. It's most likely wrongly configured (or $TERM is wrong).
I don't think there is anything that vim-airline can do to fix this.


Add empty line to fix the CI gen

What this PR does / why we need it:
This PR expects to fix the CI gen fails.
This is just a workaround to pass CI.
How to reproduce

build the image for  with linux/amd64 docker buildx.
Fix Makefile and execute make gen/code.

docker buildx build --platform linux/amd64 tool/codegen -t codegen-buildx-amd

Fix the Makefile like this↓
gen/code:
	# NOTE: Specify a specific version temporally until the next release.
	docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh codegen-buildx-amd  /repo #v0.44.0-38-g7229285

Which issue(s) this PR fixes:
Related to https://github.com/pipe-cd/pipecd/pull/4970
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Thank you both 🙏
I will check the result on the https://github.com/pipe-cd/pipecd/pull/4970


Update vulnerable dependencies

Update vulnerable dependencies
Hi team, would you help to update dependencies and release a version to resolve a few CVEs? I saw there was an attempt (#141) but don't know why it is reverted.

@carpusherw, we have updated and fixed in #143


How to accept message from strangers, these messages stay in Message Requests

Hi,
I just wonder about the method: api.handleMessageRequest and how to use it to handle messages in Message Requests
I tried:
api.listen(function callback(err, message) {
        //accept message for stranger
        api.handleMessageRequest(message.threadID, true);
});

but it didn't work !

Do we receive events for message requests in listen?  I wasn't aware of it, but maybe I'm wrong, the events are not particularly well understood.  Maybe you can check the other fields of the message object?
I would have suggested the use of getThreadList.  If this still doesn't work, it's totally possible that handleMessageRequest has broken.  Can anyone else confirm that they're also seeing this problem?
Because of the nature of how this api works, things like this break from time to time and we always offer heartfelt thanks to our users for finding and helping fix them 😄

Hey @codetay, any luck using getThreadList to solve this?  I'm going to close this for now but please comment/reopen if this doesn't solve your problem.


Mns spell checker does not work in LibreOffice

I use Mac M2 Ventura.
The text language can be defined for the entire document.
But:
No spelling underlines.
This problem has been around for a while.

The Mansi (mns) speller is now working partially in LibreOffice, but it does not accept words with U+0304 macrons.

Good! What changed in between?
I notice the speller version is from June last year. Could you try deinstalling the Mansi speller using Divvun Manager, and then reinstalling it using the nightly channel? After you have made sure you have the latest speller (should be from yesterday), then have a look at the macron and other issues as well.

The situation has not changed. Oswide speller recognizes words that are supposed to be precomposed Cyrillic У with macron U+04EE and U+04EF; something that the speller in LibreOffice cannot do.
Hence correcting the spelling U+0443 U+0304 >> U+04EF has immediately improved the result for work with LibreOffice.
The full stop does not seem to have any effect on use of the speller.


az aks nodepool update can update taints, docs could use this detail

The command has these options
az aks nodepool update --cluster-name
--name
--resource-group
[--aks-custom-headers]
[--disable-cluster-autoscaler]
[--enable-cluster-autoscaler]
[--labels]
[--max-count]
[--max-surge]
[--min-count]
[--mode {System, User}]
[--no-wait]
[--node-taints]
[--scale-down-mode {Deallocate, Delete}]
[--tags]
[--update-cluster-autoscaler]
In the command description it could include a statement indicating the commands allows to update the node pool by adding a node taint (even if the node pool doesn’t have one already) or to update an existing taint.
I performed the following test, and it does work.
I have two node pools; one already has taint applied to it

I indeed can update the existing taint value
Executed
az aks nodepool update --cluster-name christiancluster --resource-group christiancluster_group --name taintnp --node-taints key2=value2:NoSchedule
Result

I can also add a taint to an existing node pool with no taint
Added node pool
az aks nodepool add     --resource-group christiancluster_group    --cluster-name christiancluster    --name taintnp2     --no-wait

Added taint post creation
az aks nodepool update --cluster-name christiancluster --resource-group christiancluster_group --name taintnp2 --node-taints key1=value1:NoSchedule

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39fce7ab-ab56-44c6-b9a8-405444247a0b
Version Independent ID: dabbb6c6-c616-a6ec-61f6-1b9d3bb069e8
Content: az aks nodepool
Content Source: latest/docs-ref-autogen/aks/nodepool.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to CXP team

@christianag54 Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

The above PR has been created and it is currently pending under review.


Alfred weather workflow not working anymore

The weather workflow doesn't seem to be working and throws the following error for the commands wth or wtd:
Error: invalid character '<' looking for beginning of value
I am using the workflow on Mac OS 13.3.1, with Alfred 5.0.6.

Hi @jeffbyrnes,
Thanks for the reply.
I am using dark sky.

I am on Apple M1 in case this helps.

I have also now tried ClimaCell (tomorrow.io) but I also get an error:
Error: Get https:api.climac...pi.climacell.co: no such host

Thanks for the details.
Dark Sky’s API is no longer available, so I’m not surprised that doesn’t work. We should remove it from the workflow.
Being on Apple Silicon shouldn’t matter, but never hurts to have that detail.
Not sure why ClimaCell isn’t working.
I have mine set to use OpenWeather, and it works, so for the time being, please try that.

I have tried OpenWeather API too, and I get the following error with it:
Error : 401 Unauthorized
(and yes I have even regenerated a new API key for it to check).

It now works. It seems it takes a bit of time for the API key to be activated.

Ok, great! Yeah, OpenWeather seems to take a long time to provision new API credentials.
I can’t close issues here, so if you’re satisfied, please go ahead & close this out.


luci-app-upnp: load data directly

Rework upnp_status page to load data without first wait for the xhr request to load. Also rename variable to better understand what they are.
@hnyman another small improvement. I notice that upnp section hang the load of the value, this fix this problem.
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

The XHR.get() invocation here might cancel other pending requests.

then we should remove get invocation in the ddns script. as it use the same code

@jow-
any more comments here?

@jow- i reworked this. Now it doesn't cancel the xhr request as it start the XHR.get as soon as the other finish. (i assume that xhr request finish by checking if data in other section change)


iframe of GitHub page is not loaded because of http embed

error message:

Mixed Content: The page at 'https://ml5-website-2.netlify.com/reference/api-KNNClassifier/' was loaded over HTTPS, but requested an insecure resource 'http://ml5js.github.io/ml5-examples/p5js/KNNClassification/KNNClassification_Video/'. This request has been blocked; the content must be served over HTTPS.

A quick solution for this is to use Netlify host the page.

We no longer support iframes in the documentation (for anything besides Youtube Videos), so I'm closing this issue for now! We actually do host on Netlify now, though!


Create codeql-analysis.yml

Add Github CodeQL security checks for Go.

Btw in my fork under /security/code-scanning I see:


NEXT-00000 - Fix / update github pipelines

1. Why is this change necessary?

The admin Lint pipeline do not include the generation of admin “entity-schema-types” and therefore the pipeline may fail with errors that are not actually errors
Some of the pipelines use outdated action releases
The ECS config does not correctly specify the line ending of the php files
The .npmrc filein the administration is not necessary because the version check is already done by webpack

2. What does this change do, exactly?

Changed 01-lint-admin github action to build the missing entity-schema-types before the code check
Changed 01-lint-storefront github action to use the latest action releases
Changed 01-php-lint github action to use the latest action releases
Changed 02-acceptance github action to not run on pull requests
Changed 02-unit github action to use the latest action releases
Changed 03-redis github action to use the latest action releases
Changed ecs config to include the lineEnding
Changed Migration1620820321AddDefaultDomainForHeadlessSaleschannelTest to use RunClassInSeparateProcess
Removed the .npmrc file, because the node version is already validated by webpack

3. Describe each step to reproduce the issue or behaviour.

Use the actions/workflows described above

4. Please link to the relevant issues (if any).

/

5. Checklist

[X] I have rebased my changes to remove merge conflicts
[X] I have written tests and verified that they fail without my change
[X] I have created a changelog file with all necessary information about my changes
[X] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

@shyim, maybe we can also fix the Unit/PHPUnit for migration,migration-tests and Playwright Tests/Docker pipelines to get all pipelines working again as they are currently always fail due to one error. Could you take a look at them?

@akf-bw migrations are flaky.
I would rewrite the whole playwright workflow; pushing into the docker registry is bad for cross repository PR's 😅 . I would skip if the event is pull_request for now

@shyim I fixed it. Now all tests work again for pull requests 🚀

Thanks!


Add openvino conversion.

Added the script for converting from onnx model to OpenVINO IR model file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Does not work with VS Code 1.94

With VS Code 1.94 I get the following error message when I try to enable fluent UI: "command 'fluent-ui-vscode.enableEffects" not found

I think it's something in Visual Studio Code itself, because mine has the same error, but not only with this extension, another one (vibrancy continued) that does basically the same thing has the same error.
I did some tests, installed extensions at random and ran some commands, and they didn't show any defects. However, when I ran these two extensions in particular, they both gave the same error. So I imagine it's a VS Code problem or some incompatibility with the operating system. The installation was done both in administrator mode from the VS Code store and as an administrator from the marketplace using the .vsix file.
I did some more advanced research and when you install an extension, it should be installed in the folder:
C:\Users\<username>\.vscode\extensions\

Followed by the name of the folder that represents the extension, however, in both cases, the extensions are not downloaded to the computer, despite being visible in the list.
To do a concrete test, I listed the extensions present using a command on the command line:
code --list-extensions

In the list, there was no record of it, which shows that it really wasn't installed correctly, and explains why the execution file wasn't found.

An addendum: I found this closed issue where there is a more technical description, maybe it will be useful. Unfortunately it didn't help me, but it may be different for you.

Thx for your investigations, I will have a look. Btw. according Vibrancy, they updated their extension and now it works well on my other machine (macOS). If some modifications have to be done. I'm open to contribute.

This is happening most probably due to the workbench.html file being renamed to workbench.esm.html.
I was able to figure out a work-around for this, which is working for me:

Downgrade vs-code to v1.93.1 from here: 1.93.1 (Don't worry, all the settings and extension settings will be retained)
Enable Fluent-UI on this version
Go to C:\Users<user>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\code\electron-sandbox\workbench
Take a copy of workbench.html & fui.js and keep it somewhere
Upgrade the v1.93.1 vscode to v1.94
Close VS-Code
Open the backed up workbench.html and copy the

Thanks for your work. I appreciate it and can confirm that this work around works on my machine too :D

do you have the backup? of  workbench.html & fui.js can u share it

Sure, I added my workbench.esm.html file
files.zip

Untested fix: https://github.com/Mukul1127/vscode-fluent-ui

Repo hasn't been updated in nearly a year and a half. Hoping someone can pick this project back up

Repo hasn't been updated in nearly a year and a half. Hoping someone can pick this project back up

Hi there! Like you, I’ve found this project really valuable and decided to fork the repo to apply some updates and fixes. Since it hasn’t been updated in over a year, I’m wondering if there’s any interest within the community to help maintain or revive it.
I’d be happy to share the changes I’ve made and contribute to keeping the project alive. If you or anyone else is interested, we could discuss potential collaboration and how we can move this forward together.
Here’s a link to my fork with the updates I’ve made so far: My Forked Repo.


indexer & json-rpc: pkg upgrade awareness on read path

Description
title, mainly to replace module_resolver with package_resolver in indexer and related json rpc codes.
Test Plan
refer the repro steps in #15869 and test indexer reader

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

@amnn sounds good, my knowledge about package-resolver is limited so indeed you are prob better one to implement that part, I will rebase and use that impl when we have it then, thanks Ashok!

Hi @gegaowp, just a heads up that the underlying support for primitive type detecting in sui-package-resolver has now landed, so you should be good to go to progress this PR.


ADD: akar-icons-web-components to README

Hi, me and my friend @awmleer are huge fans of AkarIcons! We wrote a web components wrapper for AkarIcons, to extend customization capability of AkarIcons and also make AkarIcons be able to used in any framework or vanilla js projects.
If you want to know more about this project, you can take a look at:

the online CodePen
our repo
the article discussed about this project

And besides, would you consider host your svg files to a CDN service like unpkg or jsdelivr? We use lazy loading strategy in this project, and icon svgs are fetched from githubusercontent, CDN hosted SVGs will make our users' lives a lot easier.

Very cool! Thank you, guys! Added.

And besides, would you consider host your svg files to a CDN service like unpkg or jsdelivr? We use lazy loading strategy in this project, and icon svgs are fetched from githubusercontent, CDN hosted SVGs will make our users' lives a lot easier.

I'll look into this.

I'll look into this.

Actually it is quite simple. Just put the svg files into the npm package akar-icons. And then they'll be automatically hosted via services like unpkg.com and jsdelivr.com.
Hope this can help you~

I'll look into this.

Actually it is quite simple. Just put the svg files into the npm package akar-icons. And then they'll be automatically hosted via services like unpkg.com and jsdelivr.com.
Hope this can help you~

Wouldn't this bloat the npm package?

It will increase the package size about 260 kB (unpacked). Currently the package size 455 kB. It seems not very scaring.

@John-Theo @awmleer I've published the SVG files here. Does this work for you guys<EMAIL_ADDRESS>

@artcoholic Thanks a lot!


ModelUtility.splitIncompatibleMaterials creates unneccary Materials

Hi,
we just had a gltf Model with one material and 20000 primitives. Of these 20000 primitives only halve had normals defined and the other half didn't.
Unfortunatly cesium didn't work very well with the gltf Model. The "createResources" Process took several Minutes and completely froze the rendering process.
I did find the root cause in the function ModelUtility.splitIncompatibleMaterials which creates 10000 copies for the provided material because half of the primitives do not have normals.
To fix the Problem I would propose a materialCache in the function to not create unnecassary materials. You can find a first prototype and proof of concept here: https://github.com/virtualcitySYSTEMS/cesium/commit/12924c39b18914b8041d8e6d0adeec212790bac8
Do you think the proposed solution is usefull?
And should i clean up the code and create a pullrequest ?

This definitely does seem like something we'd want. @likangning93 I remember you talking about a lack of caching system in this area of the code that we could improve. Do you have any thoughts here?

I'm closing this issue, since it will no longer be relevant to the implementation of Model / ModelUtility by the 1.97 release.


Fails to build in Xcode 10: kCAFillModeForwards

There's only one error causing the library to fail building in Xcode 10:
Pods/EMSpinnerButton/EMSpinnerButton/EMSpinnerButton/EMSpinnerButton.swift:136:25: 'kCAFillModeForwards' has been renamed to 'CAMediaTimingFillMode.forwards'
was obsolete in Swift 3

Please fix this so the library can be built with Xcode 10 🙏

@abdulla-allaith You can set Swift Language Version for this pod and temporary solve the problem.

This issue has been resolved in the latest version (1.0.1)


No errors but highlighting Error

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:26:20.018Z)
OS Version: Linux x64 4.4.0-96-generic
Extensions:

Extension
Author (truncated)
Version

html-class-suggestions
And
1.0.7

ng-template
Ang
0.1.7

material-icon-theme
PKi
2.2.1

vscode-intelephense-client
bme
0.7.2

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

auto-rename-tag
for
0.0.14

icon-fonts
idl
1.8.1

vscode-scss
mrm
0.6.2

debugger-for-chrome
msj
3.3.0

(3 theme extensions excluded)

Vscode showing an error warning in my code. but it works absolutely fine but  can't get rid of this

Reproduces without extensions: Yes/No

Do you see the error with all extensions disabled? Try running code -- disable-extensions from the terminal

No, it does not show any errors while all extensions are disabled. but the intelisense is gone  :(

The error reporting is coming from one of the extensions that you have installed.
Please log the issue in the repo for the corresponding extension


Unknown SQL Datatype: datetime2

Hi
I'm testing this for the first time following the instructions from your post on Code Project. When starting debugging I get the message below, the App_Data remains empty (No swaError file).
When removing the datetime2(0) parameters from my stored procedures it seems to work correctly.
Server Error in '/' Application.
Unknown SQL Datatype: datetime2
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.Exception: Unknown SQL Datatype: datetime2

Hi, It probably does not know how to convert a datetime2 to a c# datatype.
I will fix this in next build

Hi oeoren
When I try to run I get the error
"'Could not find stored procedure 'dbo.api_products_get'.'
I'm on a remote DB and my user-name is not dbo
I see my stored procedure as  alfred11.api_products_get
Any way to fix this ?
Many thanks for the codeproject sample


fix:Array definition error

修复数组定义格式错误

Codecov Report

Merging #68 (0a00408) into main (abbdd82) will decrease coverage by 0.56%.
The diff coverage is 30.00%.

@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
- Coverage     64.94%   64.38%   -0.57%
+ Complexity     8074     8014      -60
============================================
  Files           420      420
  Lines         45459    45450       -9
  Branches       9181     9150      -31
============================================
- Hits          29524    29262     -262
- Misses        12380    12671     +291
+ Partials       3555     3517      -38

Impacted Files
Coverage Δ

...in/java/com/alibaba/fastjson2/JSONReaderJSONB.java
70.32% <0.00%> (-1.24%)
:arrow_down:

...ain/java/com/alibaba/fastjson2/JSONReaderUTF8.java
71.81% <0.00%> (-0.54%)
:arrow_down:

...main/java/com/alibaba/fastjson/util/TypeUtils.java
8.57% <0.00%> (ø)

...baba/fastjson2/trove/map/hash/TLongIntHashMap.java
86.92% <100.00%> (ø)

...ava/com/alibaba/fastjson2/JSONWriterUTF16JDK8.java
0.00% <0.00%> (-80.77%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
56.77% <0.00%> (-13.55%)
:arrow_down:

...ain/java/com/alibaba/fastjson2/JSONWriterUTF8.java
65.60% <0.00%> (-9.30%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
71.69% <0.00%> (-7.55%)
:arrow_down:

...ore/src/main/java/com/alibaba/fastjson2/JSONB.java
83.62% <0.00%> (-4.10%)
:arrow_down:

...libaba/fastjson2/reader/FieldReaderObjectFunc.java
34.28% <0.00%> (-2.86%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbdd82...0a00408. Read the comment docs.


move bookmark file location to instance root

Changes the bookmarks.ini file position from the default jei directory ./config/jei to ./.
This prevents pack makers from accidentally shipping their bookmarks file with the config folder (pack makers can still ship it if they select the file specifically), and prevents pack updates from wiping the players bookmarks.

Thanks for the PR, since it's now in the root, it may be more suitable to prefix the filename with hei_ for it to be distinguishable.


Fix gateway injection for tag revision and restore istio.io/rev in sidecars

Please provide a description of this PR:
Background context
This PR restores injecting label istio.io/rev to sidecars and fixes #33237 which is still reproducible in Istio 1.17.
Restoring label istio.io/rev is not required to fix #33237, but it seems that it was removed unnecessarily in #33447.
I want to restore this label, because it will simplify collecting metrics with revisions. Currently it's not set in sidecars and it requires different relabel configs for sidecars and gateways.
How to test and reproduce

Prepare files:

cat <<EOF >> istiod-service.yaml
apiVersion: v1
kind: Service
metadata:
  labels:
    app: istiod
    istio: pilot
    release: istio
  name: istiod
spec:
  type: ClusterIP
  ports:
  - name: grpc-xds
    port: 15010
  - name: https-dns
    port: 15012
  - name: https-webhook
    port: 443
    targetPort: 15017
  - name: http-monitoring
    port: 15014
  selector:
    app: istiod
EOF
cat <<EOF >> control-plane.yaml
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: control-plane
spec:
  #hub: quay.io/jewertow
  #tag: istio-io-rev
  profile: minimal
  meshConfig:
    defaultConfig:
      proxyMetadata:
        ISTIO_META_DNS_CAPTURE: "true"
    enablePrometheusMerge: true
EOF
cat <<EOF >> ingress-gateway.yaml
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: istio-ingress-gw-install
spec:
  profile: empty
  #hub: quay.io/jewertow
  #tag: istio-io-rev
  components:
    ingressGateways:
    - name: istio-ingressgateway
      namespace: istio-ingress
      enabled: true
EOF
cat <<EOF >> ingress-gateway-injection-canary.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: istio-ingressgateway-canary
spec:
  selector:
    matchLabels:
      istio: ingressgateway
      istio.io/rev: canary
  template:
    metadata:
      annotations:
        # Enable gateway injection
        inject.istio.io/templates: gateway
      labels:
        # Set a unique label for the gateway. This is required to ensure Gateways
        # can select this workload
        istio: ingressgateway
        # Enable gateway injection. If connecting to a revisioned control plane, replace with
        istio.io/rev: canary
        # sidecar.istio.io/inject: "true"
    spec:
      containers:
      - name: istio-proxy
        image: auto
EOF

Install:

kind create cluster --name test
istioctl install -y -n istio-system -f control-plane.yaml --revision 1-8-3
kubectl apply -n istio-system -f istiod-service.yaml
kubectl create namespace istio-ingress
istioctl install -y -n istio-ingress -f ingress-gateway.yaml --revision 1-8-3
istioctl install -y -n istio-system -f control-plane.yaml --revision 1-10-0
istioctl x revision tag set canary --revision 1-10-0
kubectl apply -n istio-ingress -f ingress-gateway-injection-canary.yaml

In 1.17 you should see tens or hundreds of pods. Delete them:

kubectl delete -n istio-ingress -f ingress-gateway-injection-canary.yaml
kubectl delete pods -l istio=ingressgateway -n istio-ingress

Now uncomment hub and tag in control-plane.yaml and ingress-gateway.yaml and use istioctl built from my branch.

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4911b4a4a5f8e3965a8c7f38ce3627c6ee19b4b0
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a3856c030106b89fbd3ba90e9545cc8fccac4f52
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a3856c030106b89fbd3ba90e9545cc8fccac4f52
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc: @linsun @Monkeyanator

/test release-notes

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a3856c030106b89fbd3ba90e9545cc8fccac4f52
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fa79e985c30fd25c69dd00abbbcb7712723c686e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Something is wrong with the release-notes job, so I will skip it.

@jewertow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fa79e985c30fd25c69dd00abbbcb7712723c686e
link
true
/test release-notes

integ-ambient_istio
fa79e985c30fd25c69dd00abbbcb7712723c686e
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @therealmitchconnors who may also have some input on this

Hey @howardjohn, could you please summarize what you're looking for.  I've lost my hold on the thread.  TIA

I want the istio.io/rev label to be removed instead of modified

I already explained that we need this label for multi-revision observability. If a namespace will not propagate label to pods, this feature will not make sense, because will require to label every single workload.

My concern is there is no consistency with sidecar (which used to have this label but removed it, as I am suggesting here, in https://github.com/istio/istio/pull/33447), which is not acceptable. I am additionally concerned that the meaning of istio.io/rev becomes unclear - in particular, I don't think your goal of monitoring revisions is actually met by this implementation, as we are NOT putting the "revision" in the label in some case.
I am aware of your requirement to monitor revisions, but its I believe this PR is inappropriate both in general and as a mechanism to achieve that goal. To come up with alternatives it would help to understand your requirements a bit more. For example, does an annotation work? Is this prometheus scraping or some other system? etc

I didn't introduce this inconsistency. This is an existing rule. And since we cannot find a common point of view on multi-revision observability, I don't want to address this use case in this PR. I just want to fix an existing bug, backport it to previous affected releases and that's it. I will revise current labeling rules and then we can talk on WG meeting how we can solve inconsistent labeling (which was not introduced in this PR) and how to support multi-revision observability. I will take into account your expectations.

I didn't introduce this inconsistency. This is an existing rule.

Just because it's currently inconsistent doesn't mean we should make it worse. I would be happy to open a PR to resolve the inconsistency if you would not like to do so in this PR

What did I make worse in this PR? I fixed only the case that does not work and which is not supposed to be not supported.

I won't be able to backport this fix to previous release if I will extend the scope... Do I really have to please you to approve a bug fix? Isn't it enough that we invested time in fixing a bug that wasn't solved since more than a year? And now I cannot get an approval, because you just want to address something else additionally? This is a way how we work as a community?

Let me address those one-by-one

I won't be able to backport this fix to previous release if I will extend the scope...

Lets first focus on making a proper fix, and if that expands the scope too much we can discuss a smaller scoped PR to backport.
To be 100% clear the fix I am suggesting is removing L7 of manifests/charts/istio-control/istio-discovery/files/gateway-injection-template.yaml, so it is no larger in scope than the current PR (IMO, anyways)

Do I really have to please you to approve a bug fix?

No, you do not. However, you do need to get approval from an environments WG member, as they are owners of this folder; I happen to be one but am not the only one. When a maintainer and contributor cannot come to a consensus, the next step is to bring to the WG where we can discuss, and if necessary bring to a vote. If there cannot be consensus in the WG, it can be further escalated to the TOC.
These policies are documented in https://github.com/istio/community. As our community governance is also open, you are welcome to propose changes to those policies as well (although that would, of course, involve more discussion than a simple PR).

Isn't it enough that we invested time in fixing a bug that wasn't solved since more than a year?

No; fixing a bug is an excellent contribution and one I am happy to see, it is not sufficient to ensure a PR is merged. There are a variety of factors involved when approving PRs, involving API design, consistency, performance, complexity, safety, etc.

And now I cannot get an approval, because you just want to address something else additionally?

Specifically, my concern is that you are moving from a  to a <not desired state, but in different ways>. The PR honestly might be an improvement to the current state (its a bit of a tradeoff, but it probably is as the bug is pretty severe when triggered), but I am more comparing to the actual optimal (IMO) state of simply removing L7.
In general, I do think that expanding PR scopes to be "perfect" instead of approving PRs that are small but bring improvement, and often advocate for making forward progress. However, this is not the case on this PR, where the ideal fix is easier than the proposed fix.

This is a way how we work as a community?

I believe this was addressed above, let me know if I can help clarify.
Hope that helps address some of your concerns.

Ok, so before we will start to talk about removing/keeping istio.io/rev on WG meeting, please explain what's technically wrong with this label - assuming that the case "If namespace has T, pod gets R" would not be supported.

You also still didn't explain what you mean by making it worse, regression, understability, etc. If you are not going to explain what you mean by that, and give examples how the solution breaks something, then it's not a constructive feedback.
Don't be surprised that I am disappointed in your approach, but you had completely different view on changing existing labels in #43388, and in this case you want to remove the label and don't care about users, like we, which want to use istio.io/rev.
Anyway, this discussion does not make sense anymore, because I see that you already decided that you will remove this label independently on our use case, so let's consider another trade-off.
You suggested to remove istio.io/rev and inject istio.io/actual-revision, which would be always set to .Revision, but a user may still make a mistake and apply a Deployment with matchLabel including istio.io/actual-revision what will result in indefinite creating pods, like it is for now. Other labels in injection templates, like service.istio.io/canonical-name or service.istio.io/canonical-revision are not overwritten if are already set, so I don't think that istio.io/actual-revision must be overwritten. I would agree to remove istio.io/rev and replace with non-overwritten istio.io/actual-revision in all components: sidecars, default gateways and injected gateways.

@jewertow This topic is added in the agenda [jewertow](https://docs.google.com/document/d/1wsa06GGiq1LEGwhkiPP0FKIZJqdAiue-VeBonWAzAyk/edit#) by @howardjohn
But since you are not there, they do not discuss this topic, would you be able to attend next week

cc @istio/wg-environments-maintainers

Thanks @hzxuzhonghu for letting me know.

I removed cherry-pick labels, because releases 1.15, 1.16, 1.17 will require backward compatible fix. I will submit proper pull requests later.

@howardjohn could you remove "do-not-merge/hold" label since you approved this PR?


query execution time incorrect

after recent upgrade, i see query execution time shows not real time of query running, but time of result loading, instead. for example, query runs for 30 sec, then i see at status line "2 rows received, 8 ms".
DBeaver	<IP_ADDRESS>908181949	org.jkiss.dbeaver.core.produc
running on Win10.
server:
PostgreSQL 10.5 (PostgreSQL 10.5 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28), 64-bit)
Connection without ssh, proxy, etc.
Server:PostgreSQL 10.10
Driver:PostgreSQL JDBC driver 42.2.0.jre7

Looks like duplicate of #6579
Please test this in 6.2

Yes, now its ok.


[tool] Make Flutter "template friendly"

Steps to Reproduce

Run  flutter create test_template
Update the files as follows:

.gitignore [OPTIONAL]
# Miscellaneous
*.class
*.log
*.pyc
*.swp
.DS_Store
.atom/
.buildlog/
.history
.svn/

# IntelliJ related
*.iml
*.ipr
*.iws
.idea/

# The .vscode folder contains launch configuration and tasks you configure in
# VS Code which you may wish to be included in version control, so this line
# is commented out by default.
#.vscode/

# Flutter/Dart/Pub related
**/doc/api/
**/ios/Flutter/.last_build_id
.dart_tool/
.flutter-plugins
.flutter-plugins-dependencies
.packages
.pub-cache/
.pub/
/build/

# Web related
lib/generated_plugin_registrant.dart

# Symbolication related
app.*.symbols

# Obfuscation related
app.*.map.json

+ # TEMPLATE FILTERS |||| DELETE WHEN STARTING A NEW APP ||||
+ android
+ ios
+ linux
+ web
+ *.metadata
+ *.lock

main.dart
copy all the code except
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

to a new filemy_app.dart and add import 'package:flutter/material.dart';,
then in main.dart delete the copied code and add import 'package:test_template/my_app.dart';

initialize the repository, commit and publish it on github
make the repository a template repository
create a repository from the template test_template, from here referenced as template_copy
clone template_copy locally
if updated .gitignore, run cd <template_copy folder> then flutter create .

Expected results: the app name and all references to test_template should be replaced with template_copy
for example in pubspec.yaml name and in import 'package:test_template/my_app.dart
Actual results: the app name is ubiquitously test_template and there isn't an obvious way to "rename" the app
as every import (old and new)  references the app as test_template;
changing the name in pubspec.yaml to template_copy causes the error in the logs

logs
Launching lib/main.dart on Chrome in debug mode...
Error: Could not resolve the package 'test_template' in 'package:test_template/my_app.dart'.
lib/main.dart:2:8: Error: Not found: 'package:test_template/my_app.dart'
import 'package:test_template/my_app.dart';
       ^

doctor
[✓] Flutter (Channel master, 1.22.0-10.0.pre.269, on Linux, locale en_US.UTF-8)
    • Flutter version 1.22.0-10.0.pre.269 at /home/francesco/development/flutter_master
    • Framework revision 51fa704642 (2 days ago), 2020-09-19 11:27:04 -0700
    • Engine revision 4b8477d115
    • Dart version 2.10.0 (build 2.10.0-142.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /usr/lib/Android
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /usr/lib/Android
    • ANDROID_SDK_ROOT = /usr/lib/Android
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_265-8u265-b01-0ubuntu2~18.04-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (3 available)
    • Linux (desktop)  • linux      • linux-x64      • Linux
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 85.0.4183.102

! Doctor found issues in 1 category.

I'm not sure myself if this issue is a feature request or a bug, but I believe this behavior is not desirable
and being able to exploit github's template repository feature could be very useful

Hi @iapicca
This is a great idea, looks more like a feature request/proposal than a bug to me
I can reproduce it, it doesn't change references https://github.com/TahaTesser/template_copy

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.281, on Mac OS X 10.15.6 19G2021
    x86_64, locale en-GB)
    • Flutter version 1.22.0-10.0.pre.281 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 511367aa5a (10 hours ago), 2020-09-21 15:33:32 -0700
    • Engine revision 4b8477d115
    • Dart version 2.10.0 (build 2.10.0-142.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0, Build version 12A7209
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.6 19G2021
      x86_64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      85.0.4183.102

• No issues found!

See also #77104, which is not the oldest version of this issue, but does seem to have the most momentum.
Closing this for now to focus the conversation there.


Decouple action implementations from queue

          TODO, decouple action implementations from queue by passing action as input to system

Originally posted by @keis in https://github.com/keis/explore-game/pull/273#discussion_r1440674839
Only possible on bevy main (0.13 release)
Also needs some mechanism to indicate a pending status

Relates to #204

Some complications from the "follow path" logic and the combat trigger, sliding is also a bit weird


Error occurs when GeoJSON's points are clicked

Describe the bug
When I load the geojson of the point data from the file, when I click on a plotted point, the edit page reloads and the error message "invaild ID" appears at the top. This is a repeat of the same process.
To Reproduce
Steps to reproduce the behavior:

Go to editor
Add a "file" layer
Select GeoJSON file contains point data
Select points newly appears on the Earth
See error

Expected behavior
No error, no infobox

Seem fixed. But click the point will not change anything.


🐛 Bug: Support for SSH remote in getDefaultSettings

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected
Support these SSH link in git remote -v like below example,
git remote -v

origin	git@github.com:navin-moorthy/node-ts-package.git (fetch)
origin	git@github.com:navin-moorthy/node-ts-package.git (push)

Actual
pnpm run setup

Welcome to the template-typescript-node-package package setup script! 🎉

┌  Let's collect some information to fill out repository details...
🚀 ~ file: defaults.ts:12 ~ getDefaultSettings ~ gitRemoteFetch: {
  command: 'grep fetch',
  escapedCommand: 'grep fetch',
  exitCode: 0,
  stdout: 'origin\tgit@github.com:navin-moorthy/node-ts-package.git (fetch)',
  stderr: '',
  all: undefined,
  failed: false,
  timedOut: false,
  isCanceled: false,
  killed: false
}
🚀 ~ file: defaults.ts:34 ~ getDefaultSettings ~ remoteFetchMatch: null
│
└  Looks like there was a problem. Correct it and try again? 😕

/Users/navin/Documents/github/node-ts-package/src/shared/defaults.ts:39
		throw new Error("Could not match a fetch remote from git.");
		      ^

Error: Could not match a fetch remote from git.
    at getDefaultSettings (/Users/navin/Documents/github/node-ts-package/src/shared/defaults.ts:39:9)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at getInputValuesAndOctokit (/Users/navin/Documents/github/node-ts-package/src/shared/inputs.ts:47:46)
    at runOrRestore (/Users/navin/Documents/github/node-ts-package/src/shared/runOrRestore.ts:42:31)
    at setup (/Users/navin/Documents/github/node-ts-package/src/setup/setup.ts:5:9)
    at <anonymous> (/Users/navin/Documents/github/node-ts-package/src/setup/index.ts:3:20)
│
■  Do you want to restore the repository to how it was?
│  Yes
│
└  Operation cancelled. Exiting - maybe another time? 👋

Additional Info
My Solution:
import gitRemoteOriginUrl from "git-remote-origin-url";
import gitUrlParse from "git-url-parse";

export async function getDefaultSettings() {
	try {
		const gitRemoteUrl = await gitRemoteOriginUrl();
		const { name, owner } = gitUrlParse(gitRemoteUrl);

		return { defaultOwner: owner, defaultRepository: name };
	} catch {
		logLine();
		logLine(
			chalk.gray(
				"Could not populate default owner and repository. Did not detect a Git repository with an origin. "
			)
		);

		return {
			defaultOwner: "UserName",
			defaultRepository: "my-lovely-repository",
		};
	}
}

Ooh, I didn't know about those packages - they'd be great. Yes please!
I also am questioning why the script throws an error in the first place for failing to parse the output. It returns defaults in catch block anyway. Why throw an error now? +1 to your solution not throwing an error.

First command is successfull & it did not return, hence continued to the next command & caught in the if block.


CORS issues

At the hackerthon I faced an issue with CORS restrictions because I had never came across it. This is triggered when a front end tries to access a backend in a different server or port.

Added methods for setting response headers to avoid being blocked by CORS. Fixed by this commit b6bcc65e3cd707f0a87e979e1219b6db602314df


Exception thrown while executing UI block: Supported orientations has no common orientation with the application

I called  lockToLandscapeRight，and the orientation has changed successfully. But if  the modal is shown, it will thrown the following error:
Exception thrown while executing UI block: Supported orientations has no common orientation with the application, and [RCTModalHostViewController shouldAutorotate] is returning YES

react-native:  0.48.2
react-native-orientation: 3.1.0

Solved by add property supportedOrientations={['portrait', 'landscape', 'landscape-left', 'landscape-right']} to modal.


tests/kernel/fp_sharing/float_disable fails on twr_ke18f

Describe the bug
meet same memory region issue with user mode enalbed
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=twr_ke18f ..
make
See error

Expected behavior
PASS
Impact
float point usage
Screenshots or console output
***** Booting Zephyr OS version 2.0.0-rc1 *****

ASSERTION FAIL [num_parts <= max_partitions] @ ZEPHYR_BASE/kernel/mem_domain.c:90

FATAL: r0/a1:  0x00000004  r1/a2:  0x0000005a  r2/a3:  0x00800000

FATAL: r3/a4:  0x00000000 r12/ip:  0x00000008 r14/lr:  0x00006ea3

FATAL:  xpsr:  0x61000000

FATAL: s[0]:  0x00000000  s[1]:  0x00000000  s[2]:  0x00000000  s[3]:  0x00000000

FATAL: s[4]:  0x00000000  s[5]:  0x00000000  s[6]:  0x00000000  s[7]:  0x00000000

FATAL: s[8]:  0x00000000  s[9]:  0x00000000  s[10]:  0x00000000  s[11]:  0x00000000

FATAL: s[12]:  0x00000000  s[13]:  0x00000000  s[14]:  0x00000000  s[15]:  0x00000000

FATAL: fpscr:  0x00000000

FATAL: Faulting instruction address (r15/pc): 0x00009a96

FATAL: >>> ZEPHYR FATAL ERROR 4: Kernel panic

FATAL: Current thread: 0x20000454 (main)

FATAL: Halting system

Environment (please complete the following information):

OS: (e.g. Linux, MacOS, Windows)
Toolchain (e.g Zephyr SDK, ...)
R2.0.0-rc1

@MaureenHelm

That's a known issue - we need to do something for this board that does not have enough MPU regions for basic user mode tests/samples. The tests passes for other platforms with NXP_MPU, so that's a low priority bug.


fix(vault): Fix crash when caching is enabled and a token expires

Problem Statement
In the vault client library, LookupSelfWithContext calls ParseSecret, which has a few places where it returns nil, nil instead of returning a proper error. The most common scenario is when the token expires and the Vault server returns:
{
  "errors": [
    "permission denied"
  ]
}

This causes the Vault provider to dereference the nil response and crash the process. This only happens when the experimental caching feature is enabled.
Related Issue
(None reported)
Proposed Changes
This commit adds an additional check (with corresponding tests) to ensure that a nil response won't be dereferenced in checkToken().
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

/ok-to-test sha=d242e5f

Hey @agunnerson-elastic, you could proceed with adding ourselves to the ADOPTERS.md as requested by @moolen
I'm not sure if you want to do that in the next contribution PR we are planning to do. If not, I can add us myself.


YARN-11707. Fix UT checkstyle error in TestRMAdminCLI

In patch https://github.com/apache/hadoop/pull/6957 ,checkstyle error always exists ,Fix  all the checkstyle error like:
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java:781: testError(new String[] { "-help", "-xxxxx" },:30: '{' is followed by whitespace. [NoWhitespaceAfter]

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 25s

Docker failed to build run-specific yetus/hadoop:tp-10256}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6958

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6958/1/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 10s

Docker failed to build run-specific yetus/hadoop:tp-23550}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6958

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6958/2/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 10s

Docker failed to build run-specific yetus/hadoop:tp-16754}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6958

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6958/3/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Why always  "Docker failed to build" ?


FP HeatPumpControl Level 4 - Consolidation of EID and Functional Profiles

Consolidation of the EID's

SGr_04_0015_xxxx_StiebelEltron_HeatPump_V0.5.0.xml
SGr_04_0017_xxxx_HOVAL_HeatPump_V0.5.0.xml
SGr_04_0033_0000_CTA_HeatPump_V0.5.0.xml

and the functional profiles

HeatPumpControl - DeviceInformation
HeatPumpControl - PowerCtrl
HeatPumpControl - HeatCoolCtrl
HeatPumpControl - DomHotWaterCtrl
HeatPumpControl - BufferStorageCtrl
only Heliotherm

HeatPumpControl - RoomTempCtrl

already done

HeatPumpControl - SG-ReadyStates_bwp
HeatPumpControl - EnergyMonitor

Overview:
EnergyMonitor+WP.xlsx

Need to change also HeatPumpTester:
HeatPumpTester.zip


Uploading files using libv86

Hello,
I want to upload files using the libv86 API, but I don't know how. Is it possible?

Hello, I want to upload files using the libv86 API, but I don't know how. Is it possible?

Yes. https://github.com/copy/v86/issues/594#issuecomment-1008155095 Just send files to the VM using a similar method. I'd love to see what you could make, as I'm having problems with sending files too. If you need some ideas for using the serial terminal, my remote terminal client for libv86 might help.

To upload a PNG image, just read the image and generate a data: URL, then remove the data: part and send it over the serial terminal. Then, use base64 -d on the VM.

Hello, I want to upload files using the libv86 API, but I don't know how. Is it possible?

Yes. #594 (comment) Just send files to the VM using a similar method. I'd love to see what you could make, as I'm having problems with sending files too. If you need some ideas for using the serial terminal, my remote terminal client for libv86 might help.

What similar method? I'm not talking about the official site. I am talking about using libv86 (the API).

Hello, I want to upload files using the libv86 API, but I don't know how. Is it possible?

Yes. #594 (comment) Just send files to the VM using a similar method. I'd love to see what you could make, as I'm having problems with sending files too. If you need some ideas for using the serial terminal, my remote terminal client for libv86 might help.

What similar method? I'm not talking about the official site. I am talking about using libv86 (the API).

Just write a gzipped (base64-encoded if your disk image has base64 installed) file to the serial terminal. Have a process reading from the serial terminal and piping the output to gzip -d, then piping the output of gzip to dd of=yourfile. If you'd like, I could try to create a proof-of-concept that installs base64 on a Linux 3 VM via the serial terminal.

See https://github.com/copy/v86/blob/6b9d1f7/src/browser/starter.js#L1159-L1169 if you're using 9pfs.


Make the size of the mini-timer less.

Hello. Please make the size of the mini timer is less, it is too big! Or, provide the opportunity to make it smaller (I use: Windows Desktop Toggle App). Thank you!

Can you make the mini mode integrated into taskbar, mini mode is useful but causes issues sometimes when it overlaps other windows.

Thank you for the suggestions. We'll take it under consideration. Making the minitimer part of the taskbar is a bigger task. Making it resizable seems like the way to go.

I would like to ask for this as well. Could be reduced to just the timer and a narrow red/green strip on the right (instead of the full width button).

+1 for this feature request!
If it's not easy to integrate the mini timer into the task bar, making it the same height would already help a lot. Then it could at least be dragged there and does not overlap with other windows.
I like ADTCs design a lot! Maybe there could also be the project (color) displayed aside. Would be essential for me. Or even show/hide depending on the width I resized it? That would be fancy!

Any updates on this?

Any updates on this?

I just hacked a shorter version of the timer, pretty ugly though.

Is there any update on this?
Best - Integrate in the windows taskbar, so no standalone application
Better - Atleast taskbar size bar - I use small task bar. Can it stay on top even though I change the workspace? Yes I use 4-5 workspaces in windows

+1 for this feature request!

Additional user request

We've started the windows app redesign process and will take this into account when updating design. Most probably we'll make it possible to resize the minitimer to smaller size. Keeping the current size as the maximum.


[bug] Main Menu fails to display w/ Dark mode enabled in Browser (Breakpoint?)

Location: https://iam.hax.psu.edu/cgl109/
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
OS: macOS - 8GB RAM - 8 cores
Screen: 1512x982
Window size: 1458x760
Battery: 100%
Connection: 4g
Bug you experienced: I ran this by Bryan already to verify (Breakpoint issue) - See [image]

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

will be fixed in 9.0.7 which we'll hold off a few days to release in case anything else like this pops up. thanks for the report


Open Folder doesn't work

Issue Type: Bug
I don't know if it's because of an extension or the latest version but suddenly code . command from the shell and Open Folder feature stopped working for me. They both show me empty workspace.
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:47:44.719Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz (4 x 2500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (1.13GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.9.1

prettier-vscode
esb
3.8.0

auto-close-tag
for
0.5.6

vscode-styled-components
jpo
0.0.27

graphql-for-vscode
kum
1.15.3

vscode-icons
vsc
9.5.0

/needsMoreInfo
Can you reproduce this for different folders?
Can you reproduce this when using the insiders version?

Same issue with same VS Code version on same OS version.
In the VS Code UI, "No Folder opened" is displayed instead of the desired folder.
I tried on many different folders without success using following commands:

code .
code <relative folder>
code <absolute folder>
code --disable-extensions .
code --disable-extensions <relative folder>
code --disable-extensions <absolute folder>

After installing VS Code Insiders, code-insiders . is working as expected.

@sestegra some more questions:
Is there an error message in the dev tools console  (Help>Toggle Developer Tools, then open the Console tab) when it happens.
Does it help when you resize the window.
Can you start code with a different location of your configuration data code --user-data-dir SOME_DIR .

When launching code --disable-extensions ., I got following error in console.
/Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-window.js:5 [uncaught exception]: Error: ENOENT: no such file or directory, uv_cwd

Error: ENOENT: no such file or directory, uv_cwd
    at process.cwd (internal/process/main_thread_only.js:42:25)
    at process.cwd (/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar/graceful-fs/polyfills.js:11:19)
    at Q.resolveSingleFolderWorkspaceInitializationPayload (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6187:387)
    at Q.resolveWorkspaceInitializationPayload (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6186:742)
    at Q.initServices (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6186:202)
    at Q.open (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6183:733)
    at Object.t.main (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6188:826)
    at file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.js:8:763
onUnexpectedError @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-window.js:5
/Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-window.js:6 Error: ENOENT: no such file or directory, uv_cwd

Error: ENOENT: no such file or directory, uv_cwd
    at process.cwd (/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/internal/process/main_thread_only.js:42)
    at process.cwd (/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar/graceful-fs/polyfills.js:11)
    at Q.resolveSingleFolderWorkspaceInitializationPayload (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6187)
    at Q.resolveWorkspaceInitializationPayload (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6186)
    at Q.initServices (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6186)
    at Q.open (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6183)
    at Object.t.main (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6188)
    at workbench.js:8
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:51
onUnexpectedError @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-window.js:6
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1541   ERR No application in the Launch Services database matches the input criteria.: Error: No application in the Launch Services database matches the input criteria.

When launching code --user-data-dir . . is working as expected.

When launching code --user-data-dir . . is working as expected.

Given that starting with a different UI state works, this indicates that you have something in the UI state that makes VS Code crash.
Assigning to @jrieken for further guidance.

@sestegra Any chance you deleted the folder you are in? Can you try cd .. and the cd FOLDER and try again?

@jrieken After executing code --user-data-dir . . and since I moved back user-data to the default folder, the issue isn't reproductible with my computer anymore.

Ok, then waiting for @helloanil

I faced the same issue today. I restarted my machine and the issue is gone. I don't know how it is related.


auto format removed space around equal sign in generic default declaration

From @unional on August 31, 2018 4:55

VSCode Version: 1.26.1

Steps to Reproduce:

function foo<T extends string[]=[string]>() {

}
// should be
function foo<T extends string[] = [string]>() {

}

Copied from original issue: Microsoft/vscode#57657

Duplicate of #26656


Crypto.com - Hummingbot API is outdated

Hi team,
Crypto dot com exchange has upgraded their API to a the third version a few months ago, and the current connector on Hummingbot is still out of date.
I would like to nominate upgrading the crypto dot com API to avoid delays and ensure optimal execution.
You can find more details about the new API below:
https://static2.crypto.com/exchange/assets/documents/oex-migration-faq.pdf

Duplicated with this issue:
https://github.com/hummingbot/hummingbot/issues/5868

Severity: P2
Bounty: 50,000 (https://hummingbot.org/maintenance/bugs/)
Rationale: Community bounty related to bronze connector (connector needs API update)

Okay, I will assign you both for the bounty of Crypto.com API , but it will be paid at the one address that you provide.

Assigning @srirambandi and @manibandi for this bounty

Yep, could start now ✅

hi @srirambandi Could you please add any your updates on this bounty?

@nikspz sorry for the delay. Yes will push our current commits to a draft PR by this Sunday. Still in progress, but from start of next week, our progress will be good. 🙌

Hi @srirambandi good day to you,
Can you let us know of any update for the PR? The team is planning to add this update to the next release. Thank you

Hi @rapcmia and @nikspz, sorry in the delay to update soon. We have created a draft PR, where we are pushing the working commits. We'll be done with the connector logic and test it within a week(using Crypto.com sandbox as we don't have keys for main account). And then we'll write the unit tests for it.
So glad the team has planned for including this in the next release! We'll try to get this merged before time.

I'm deeply saddened to hear that the Crypto.com connector may be removed from Hummingbot due to no HBOT votes this quarter. There are people who use it, I have been using it since 2020 when it was first introduced. There are two gentlemen who took up the bounty offer and are almost finished fixing the code to implement the required connector changes, it would be such a shame to simply stop work and dump the connector from the code. HB team, if you're reading this - please reconsider. I don't hold any HBOT tokens, if I'd known it would have only taken 100k to keep the connector working, I would have personally considered buying the token just to vote.

I am willing to vote for maintaining crypto dot com's connector, I have been using it for a while and would love to see it maintained

Me as well, I've been using it since late 2020 and I'll be deeply
disappointed if it is removed from the code.
I don't have any HBOT but if required I would consider obtaining some.
On Fri, 7 July 2023, 22:27 Alkhalifah-blockchain, @.***>
wrote:

I am willing to vote for maintaining crypto dot com's connector, I have
been using it for a while and would love to see it maintained
—
Reply to this email directly, view it on GitHub
https://github.com/hummingbot/hummingbot/issues/6023#issuecomment-1625496974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKZT2IIKVCQ2Z4WUVJDFFITXPAMELANCNFSM6AAAAAAUD2BITA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

We are closing this bounty since during Epoch 5 CEX Connectors Poll Crypto.com connector not voted with minimum amount for a CEX connector
https://snapshot.org/#/hbot.eth/proposal/0x231e942b5f23b406d409f2b12319891ab3c92605e367f75e56015061e905d56e
Also this bounty not ready after more than 2 month period of development, and developer not fix simple issues shortly / not being responsive.

@Alkhalifah-blockchain @bonez56 If you want crypto.com connector will be added again in the codebase, you will need to create a new Proposal using snapshot.
Please review proposed governance changes here:
https://snapshot.org/#/hbot.eth/proposal/0x63958a27907ef6efa072fc92566f91bcf5df7491523ffcc64ecb47f270df9bcd

We are closing this bounty since during Epoch 5 CEX Connectors Poll Crypto.com connector not voted with minimum amount for a CEX connector https://snapshot.org/#/hbot.eth/proposal/0x231e942b5f23b406d409f2b12319891ab3c92605e367f75e56015061e905d56e The PR for removal not-maintained connectors will be ready next week

If this goes for another proposal to be voted in, I can finish unit tests and submit the PR again.

Also this bounty not ready after more than 2 month period of development, and developer not fix simple issues shortly / not being responsive.

@nikspz what small fixes ami missing, let me know. The connector is ready to be tested on the logic. I even pushed some unit tests, although unit tests are not important for bronze connectors all that much as I've read yesterday in our discord comment. I am genuinely asking what small fixes were we missing?


Keep and host documentation/test coverage some other place.

Not very nice to have so much more diffs than necessary.

use https://travis-ci.org/ and integrate https://coveralls.io, perhaps

We now have Travis CI! https://github.com/BoolNordicAB/sharepoint-utilities/commit/0acc4b222a869a95e891875e7e8e2e69538d8155

maybe put gh-pages to use

added gh-pages and links to it here https://github.com/BoolNordicAB/sharepoint-utilities/commit/73333dcdf17449c4215378a189d3f1247b544f8d


Customized emojis

Hi,
Thank you for making this plugin!
I have a question. It seems that these emojis are the default emojis, right? Is it possible to insert non-primitive emojis / images that I made?

Hi @Jun711
Thank you!!
at the moment we do not Support custom icons because we use the system emojis that is only Unicode not images.
Thank you
daniel


Boduuu coloooo

@dleve123 we should probably do this on your machine since you did all the work ;)

@whmii Haha, you mean to give the commits the correct author? There's actually a way to configure Git to show that some code was generated by a pair! Maybe we can try doing that.

@whmii Discussing this IRL earlier today made me think about this – should we merge? I can also rebase the commits so that I'm the author if that's something we still want to do!

@dleve123 sounds good to me. you can also probably squash these in to a single commit

@dleve123 merging

woo – deleting the branch for cleanliness


Force Order on Rollover doesn't work after multi-range update

Updated the way I was checking if events have peen published to the next year.
Found an Issue when creating a new recurring event, when rollover is automatic, event master record is not placed in new year.

code -https://github.com/sharkbit/BadgeApp/commit/c894ed2efe5c9c7cfc41e12638fd3cea1a618e3b

I believe it's Good...  Needs Lots of testing...   using rollover and normal recurring events.

I unpublished and republished a couple of club multi-range events. no issues.
Then, I intentionally created a conflict to see if the App could catch it and it didn't. Here is what I did;

I unpublished Action events with your function.
Created a one-time event, see ID=52373.
Then, republished ID=52374.
No conflicts created in Conflicts tab.
Both events are listing on 7/11/2021.
Open both in separate tabs and check availability. Finds conflict in each. Still no events in Conflicts tab.

I would think that the App should give priority to 52374 and knock 52373 off the calendar and into the Conflicts tab.

Found and fixed issue, are we ready for live? or more testing?

I believe this is good.


Remove dependency on quote & proc-macro2

Closes #16

bors r+

Awesome change! Thanks a ton. I'll definitely use this as a dependency on the time crate relatively soon.


/dash not working

After a successful log into the panel, /dash says "not found".
Not Found
The requested URL was not found on this server.
I have checked the files, and all installation files seem to be correct.

Did you clone the repo or did you use a release version ?
Have you enable rewrite on the server? See Installation section in document.
Also check so you have the hidden files with ls -all and look for .htaccess file.

Apologies, I put override all on the wrong option


Last version with vertx 2.x support

Hi,
just wondering, since I have to support a vertx 2.x backend, what is the last version of your wrapper, that would work with that?
Thanks for all your work!

e06515b7a7b652d27c111390126eb975819cc19d introduces v3.2.0
f56b4a64d906a43e7f1a1953ce32e37f66e191e8 introduces v3.0.0 initially

So, angular-vertxbus 2.0.4 is the last release supporting a v2.~


Use a proper DB

Now the app is using sqlite. We have to change it for a proper DB, like PostgreSQL for example.
I recommend to use a docker container with the DB.
This task can be related with the Dockerize app task

@jbagot we can introduce PostgreSQL as soon as we introduce the docker compose. This way it's going to be easier for anyone to spin up the application stack.
I'm going to take a look at the application to see if there's anything to do to replace sqllite, in that case we can create an issue with the development team to arrange for a configuration file or environment variable we can customize in the containerization

Hello guys, I wanted to start working on this issue with an additional couple of points:

Create the docker compose file
Use docker-compose secrets to set DB password in DB init and application
Drop user privileges in containerized application

@XaviTorello @jbagot let me know if you think of anything else that should be included with this issue. I will assign this issue to myself and start working on it

@jbagot do you think this one can be closed after we created the docker-compose or you still think we have work to do about it?

I think this has been solved, @jbagot?

Yes, we can close this one. Thank you :+1:


Hotfix/warnings

silence the warnings that happen during testing (by fixing them, not ignoring)

Codecov Report

Merging #43 (58e53c6) into main (314857c) will increase coverage by 0.04%.
The diff coverage is 75.75%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   77.77%   77.82%   +0.04%
==========================================
  Files          14       14
  Lines        1795     1799       +4
  Branches      230      231       +1
==========================================
+ Hits         1396     1400       +4
  Misses        314      314
  Partials       85       85

Impacted Files
Coverage Δ

src/mud_examples/linear/lin.py
80.30% <55.55%> (ø)

src/mud_examples/ode.py
79.41% <60.00%> (ø)

src/mud_examples/pde.py
73.17% <60.00%> (ø)

src/mud_examples/monomial.py
95.60% <100.00%> (ø)

src/mud_examples/poisson.py
84.75% <100.00%> (ø)

src/mud_examples/summary.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314857c...58e53c6. Read the comment docs.


[NEW BENCHMARK] depth_image_proc

Specify the ROS2 package are you benchmarking:
depth_image_proc
Provide the link to the ROS2 package:
https://github.com/ros-perception/image_pipeline/tree/humble/depth_image_proc
Which category does your benchmark fall under?

[x] Perception
[ ] Localization
[ ] Control
[ ] Navigation
[ ] Manipulation

What metric are you benchmarking?
latency (ms)
What is your estimated date of completion?
May 2nd, 2023
What hardware will your reference implementation run on?

12th Gen Intel(R) Core(TM) i9-12900KF
NVIDIA GeForce RTX 3080 Ti

Your organization:
Harvard University
Your name:
Jason Jabbour
Your email address or contact information:
<EMAIL_ADDRESS>

Yep! I've built the computational graph, here's what it looks like:

I still need to add a tracepoint for the output node and analyze the data!

Awesome, if you push it into a PR, happy to make a first pass and review it tomorrow, as I'll be allocating time for it.

@jasonjabbour would be great to get this added as a6, note there's been new benchmark also added. We're starting to get speed :).

I believe this was addressed. Closing.


WIP doc: clarifications regards tuf keys

Signed-off-by: Camila Macedo<EMAIL_ADDRESS>Readiness

[ ] Merge (pending reviews)
[ ] Merge after date or event
[x] Draft

Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[ ] Run spelling and grammar check, preferably with linter.
[ ] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[ ] Match tone and style of page/section.
[ ] Run make linkcheck.
[ ] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[ ] follow best practices for commits.

[ ] Descriptive title written in the imperative.
[ ] Include brief overview of QA steps taken.
[ ] Mention any related issues numbers.
[ ] End message with sign off/DCO line (-s, --signoff).
[ ] Sign commit with your gpg key (-S, --gpg-sign).
[ ] Squash commits if needed.

[ ] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for 464ddee12bb5676b00e87a0ee3077900575668b2 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2386/docs/artifacts/html/index.html

Docs for 34969c0a45d8801230a19aad440b7d24089fa5ed are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2387/docs/artifacts/html/index.html

Docs for 7bd0383c68ef940329aaf90125fa82b7a8be6cb6 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2388/docs/artifacts/html/index.html

Docs for c7d77275ee0a617a284140ee70ca9096cd8be61a are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2389/docs/artifacts/html/index.html

Docs for 5b85a90f98f2523738688f96a6b6c65107182b50 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2390/docs/artifacts/html/index.html

Docs for 6c433e17b0d1099d670eeac4cf224a9673401c0e are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2391/docs/artifacts/html/index.html

Docs for 035fd3483a5915a46edbe70c7e8a8a5b7648e7bf are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2392/docs/artifacts/html/index.html

Docs for f58974e9e5a78602e0db156ca2966e3cf8227160 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2393/docs/artifacts/html/index.html

Docs for 499ad8fa3717a239f43638829236cd139ed6aa0d are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2394/docs/artifacts/html/index.html

Docs for f2ce3da6432db645717080cc54be6c38b56e5aab are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2395/docs/artifacts/html/index.html

IMO, I would let customer support team representatives to judge about the given doc/TUF clarification. Personally, as for me, it's really hard to assess objectively this document explanation in terms of helping customers to grok the TUF stuff. The key reason, I've working with TUF many years and know our TUF related implementation from inside.
@caiotpereira @vanmaegima Please, look into this doc and provide your feedback.

HI @mike-sul @vkhoroz
Thank you for all your feedback and inputs
It was a draft and it was not ready to review yet.
Anyway, that was good and I mainly keep what is essential.
Again thx for all.


How to read the results in Table 1?

I have some questions about interpreting the results in Table 1.
Here's Table 1 for reference:

My questions apply to all models but for simplicity I will just ask about BERT.
My question is:
How to identify the intermediate task for "BERT on STILTS" in the Test Set Scores. For example, in CoLA, the best model in the development set is just BERT with score in 62.1. This is reflected in "BERT, Best of Each". So, in the test set, which model is used for "BERT on STILTS"?
I'm guessing it has to be the best model within the ones that had intermediate tasks so it's BERT->MNLI since its score is 59.8. So for CoLA, BERT->MNLI scored 59.8 on the development set score and 62.1 in the test set. Is the correct way to read the table?

Hi,
It's a good question and I guess we could have written about it more clearly. The best "model" (say, among the BERT models), is chosen based on the development set and shown in the "Best of Each" row. That model is then used on the test set. This spans all intermediate task settings, including BERT without intermediate training. Hence, for CoLA we use BERT without additional training, whereas for SST, we use BERT->MNLI.
This table also shows which models we end up using. Note that the results there differ slightly because we reran all the experiments (+1 for reproducability!).


Node JS Materials

Official Node.js Docs: https://nodejs.org/en/docs/guides/
Full Node.js Reference (for all core modules): https://nodejs.org/dist/latest/docs/api/
More about the Node.js Event Loop: https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/
Blocking and Non-Blocking Code: https://nodejs.org/en/docs/guides/dont-block-the-event-loop/

https://github.com/samerbuna/efficient-node/blob/main/100-learning-node-runtime.adoc

Debugging node in vscode: https://code.visualstudio.com/docs/nodejs/nodejs-debugging

Debugging Node.js: https://nodejs.org/en/docs/guides/debugging-getting-started/
Debugging Node in Visual Studio Code: https://code.visualstudio.com/docs/nodejs/nodejs-debugging

Express.js: https://expressjs.com/en/starter/installing.html

MVC Pattern - MDN Docs


Add strict types and params

Codecov Report

Merging #261 (e27f76c) into master (5c10127) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage     81.38%   81.38%
  Complexity      469      469
=========================================
  Files            44       44
  Lines          1359     1359
=========================================
  Hits           1106     1106
  Misses          253      253

Impacted Files
Coverage Δ

...tentSecurityPolicy/ContentSecurityPolicyParser.php
100.00% <ø> (ø)

src/ContentSecurityPolicy/DirectiveSet.php
97.36% <ø> (ø)

src/ContentSecurityPolicy/NonceGenerator.php
60.00% <ø> (ø)

src/ContentSecurityPolicy/PolicyManager.php
97.43% <ø> (ø)

src/ContentSecurityPolicy/ShaComputer.php
73.52% <ø> (ø)

src/ContentSecurityPolicy/Violation/Event.php
66.66% <ø> (ø)

...licy/Violation/Filter/BrowserBugsNoiseDetector.php
100.00% <ø> (ø)

...licy/Violation/Filter/CustomRulesNoiseDetector.php
0.00% <ø> (ø)

...tyPolicy/Violation/Filter/DomainsNoiseDetector.php
100.00% <ø> (ø)

...icy/Violation/Filter/DomainsRegexNoiseDetector.php
87.50% <ø> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c10127...e27f76c. Read the comment docs.


Port to Python 3

I have ported this to Python 3 and created a pull request.
Meanwhile, you may want to try using my fork: https://github.com/ssantana92/ignr.py

I wasn't sure why @ssantana92 closed the PR immediately, and forgot to ask.

It might be worth using futurize from pip install future to implement 3.x syntax with 2.7 backwards compatibility so that after the deprecation of 2.7 in 2020 you don't really need to change anything but can clean up the backwards compatibility someday.

Yeah, now that we have EOL date, I’ll stop being lazy and actually get on this using one of the solutions out there. Good to know people use this tool!

Done! After much delay, I present to you, v2.0. This drops Python 2 support, as I figured it wasn't worth the effort, and because I prefer keeping dependencies clean in simple projects like this one. I also had to make some compatibility updates, like adding HTTP headers in my requests to gitignore.io, which may mean the previous version has been broken for some time.


[WIP] Protobuf version change to 3.11.

Description
Protobuf version change from 3.7.0 to 3.11.0.  Fixes issue #721 .
Testing instructions
Types of changes

Checklist

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.

Completed with other PR, closing this


404 for linux GPU python2 download

HTTP ERROR 404
Click the url in readme, following occurs:
Problem accessing /view/Nightly/job/nightly-matrix-linux-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON2,label=gpu-linux/lastSuccessfulBuild/artifact/pip_test/whl/tensorflow_gpu-1.3.0rc2-cp27-none-linux_x86_64.whl. Reason:
Not Found

@gunan do you know what the URL should be? It's specifically for the Linux GPU: Python 2 link under the Installation section of https://github.com/tensorflow/tensorflow

The new URL should not have the rc2.
@av8ramit  could you take a look?

Yeah I'll take a look!

https://github.com/tensorflow/tensorflow/pull/12370

https://ci.tensorflow.org/view/Nightly/job/nightly-matrix-linux-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON2,label=gpu-linux/lastSuccessfulBuild/artifact/pip_test/whl/tensorflow_gpu-1.3.0-cp27-none-linux_x86_64.whl


Text boundingboxes are quite imprecise

Example:
scene = Scene(resolution = (500, 500), camera = campixel!, raw = true)

texts = [text!(scene, str, position = pos, textsize = 50)[end]
    for (str, pos) in zip(
        ["m", "1", "0abc"],
        [(100, 100), (200, 200), (300, 300)])]

bbs = BBox.(boundingbox.(texts))

poly!(scene, bbs, color = (:blue, 0.3))

fixed by https://github.com/JuliaPlots/AbstractPlotting.jl/pull/401


[FEATURE]-Add Subscription Check Timer

Is your feature request related to a problem? Please describe.
Feedback subscriptions appear to be randomly dropping between Crestron control processors and Cisco endpoints (firmware: ce<IP_ADDRESS>.8ebef840687) while the SSH connection to the Cisco codec remains active.
Describe the solution you'd like
Create timer that checks xFeedback list and if no subscriptions exists, re-trigger subscriptions.
Describe alternatives you've considered
Keep a list of subscriptions desired and check that list against the Cisco codec based on timer.
Additional context
None

As discussed today: @TrevorPayne

Revise subscription count tracking mechanism from == to <= allowing for subscription requests from other locations to add to subscription count. This prevents current mechanism from printing errors relating to “Invalid subscription count, re-registering all feedback.”
Revise mechanism adding feedback subscription requests forcing all subscription requests to be added to existing LIST for safe tracking.