Change behavior of typing.Optional (create optional, nullable field)

Hi @s-knibbs ,
Thanks for building and maintaining this package. I spent some time evaluating it today and noticed a surprising interaction between typing.Optional and how nullable fields are treated in JSON schema. So, I put together a small proof of concept of what a different approach might look like for discussion.
The thing that specifically surprised me is that according to the typing.Optional documentation, Optional is simply an alias for Union[..., None]. With defaults, this lets you null a field to indicate a value is not present, or apply a default value. With that in mind, I would expect the following code to work:
from dataclasses import dataclass
from dataclasses_jsonschema import JsonSchemaMixin, SchemaType
from typing import Optional, Union
from pprint import pprint

@dataclass
class DatabaseModel(JsonSchemaMixin):
    """Description"""
    id: Optional[int] = None

print(DatabaseModel.from_dict({}).to_dict()) # works great

print(DatabaseModel.from_dict({'id': None}).to_dict()) # fails

The above code fails with:
dataclasses_jsonschema.ValidationError: None is not of type 'integer'

Failed validating 'type' in schema['properties']['id']:
    {'type': 'integer'}

On instance['id']:
    None

Which is a somewhat surprising way to fail, given that the default value for id is None!

Digging into internals here, it seems like a better way to represent Optional[int] is similarly to how you represent Union[str, int], except with None/null as a first class type. This branch changes the schema generator to use oneOf: [{type: integer}, {type: null}] in addition to marking the field as not required. I think this better approximates how I'd expect the JSON schema to look. (although it would be a lot better if there were a way to separately define the field as required vs. nullable, I just don't think typing has a good syntax for that.)
One downside is that this branch in its current state breaks SWAGGER_V2 schema generation. I could modify this to conditionally revert to the old way of generating Optional schemas for SWAGGER_V2. Then this change would only apply to openapi 3 / swagger 3 / json schema.
Let me know what you think & thanks for your time.

I need to improve the documentation and publish the api docs, but the default behaviour of to_dict is to filter out any None values (the omit_none parameter), so in your example above the following will work correctly:
d = DatabaseModel().to_dict()
DatabaseModel.from_dict(d)

I don't think the default behaviour should be to support nullable fields given that this isn't supported in swagger 2.0. I've proposed a solution in #57.


PHP8 compatibility

Related to https://github.com/onelogin/php-saml/issues/453

TODO:

[x] Updates phpunit version
[x] Resolved use of libxml_disable_entity_loader()
[ ] Fixed tests The remaining are not passing but I'm not sure if that's specific to php 8

Travis CI no longer in use it seems

Remaining Tests
Here is the confusing output remaining for phpunit tests:
Click to view

PHPUnit 9.5.0 by Sebastian Bergmann and contributors.
Warning:       No code coverage driver available
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!
..............FF.........FFFFFFFFFFFFFFFFFF.............W.....W  63 / 279 ( 22%)
WWWW............WWWWWWWWW.............WWW..W.EWW............WWW 126 / 279 ( 45%)
W.E.......................................................F.... 189 / 279 ( 67%)
............................................................... 252 / 279 ( 90%)
...........................                                     279 / 279 (100%)
Time: 00:02.811, Memory: 14.00 MB
There were 2 errors:

OneLogin\Saml2\Tests\LogoutRequestTest::testGetIDException
OneLogin\Saml2\Error: LogoutRequest could not be processed

/Users/fideloper/Code/Userscape/php-saml/src/Saml2/LogoutRequest.php:201
/Users/fideloper/Code/Userscape/php-saml/tests/src/OneLogin/Saml2/LogoutRequestTest.php:916

OneLogin\Saml2\Tests\LogoutResponseTest::testGetIDException
OneLogin\Saml2\Error: LogoutResponse could not be processed

/Users/fideloper/Code/Userscape/php-saml/src/Saml2/LogoutResponse.php:93
/Users/fideloper/Code/Userscape/php-saml/tests/src/OneLogin/Saml2/LogoutResponseTest.php:560
--
There were 25 warnings:

OneLogin\Saml2\Tests\AuthnRequestTest::testCreateDeflatedSAMLRequestURLParameter
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\AuthnRequestTest::testCreateEncSAMLRequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\AuthnRequestTest::testWeCanChooseToCompressARequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\AuthnRequestTest::testWeCanChooseNotToCompressARequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\AuthnRequestTest::testWeCanChooseToDeflateARequestBody
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\AuthnRequestTest::testGetXML
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructor
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithRequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithSessionIndex
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithNameIdFormatOnParameter
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithNameIdFormatOnSettings
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithoutNameIdFormat
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorWithNameIdNameQualifier
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testCreateDeflatedSAMLLogoutRequestURLParameter
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testConstructorEncryptIdUsingX509certMulti
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testWeCanChooseToCompressARequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testWeCanChooseNotToCompressARequest
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testWeCanChooseToDeflateARequestBody
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutRequestTest::testGetXML
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testConstructor
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testCreateDeflatedSAMLLogoutResponseURLParameter
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testWeCanChooseToCompressAResponse
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testWeCanChooseNotToCompressAResponse
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testWeCanChooseToDeflateAResponseBody
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

OneLogin\Saml2\Tests\LogoutResponseTest::testGetXML
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

--
There were 21 failures:

OneLogin\Saml2\Tests\AuthTest::testRedirectTo
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testRedirectTowithUrl
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testProcessSLORequestDeletingSession
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testProcessSLORequestDeletingSessionCallback
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testProcessSLORequestRelayState
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testProcessSLORequestSignedResponse
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogin
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginWithRelayState
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginWithRelayStateAndParameters
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginSigned
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginForceAuthN
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginIsPassive
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginNameIDPolicy
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLoginSubject
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogout
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogoutWithRelayState
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogoutWithRelayStateAndParameters
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogoutWithNameIdAndSessionIndex
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogoutNameID
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\AuthTest::testLogoutSigned
Test was run in child process and ended unexpectedly

OneLogin\Saml2\Tests\ResponseTest::testIsInValidCert
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'openssl_x509_read(): supplied parameter cannot be coerced into an X509 certificate!'
+'openssl_x509_read(): X.509 Certificate cannot be retrieved'

/Users/fideloper/Code/Userscape/php-saml/tests/src/OneLogin/Saml2/ResponseTest.php:1537
ERRORS!
Tests: 279, Assertions: 1107, Errors: 2, Failures: 21, Warnings: 25.

As this stands, I think this is OK, but I need some direction/help on fixing all the tests. I'm unsure about what these errors ean:

Test was run in child process and ended unexpectedly

And some failures seem to be related to the project logic instead of php8, but I'm not totally sure:

OneLogin\Saml2\Error: LogoutRequest could not be processed
OneLogin\Saml2\Error: LogoutResponse could not be processed

And finally this one:
21) OneLogin\Saml2\Tests\ResponseTest::testIsInValidCert
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'openssl_x509_read(): supplied parameter cannot be coerced into an X509 certificate!'
+'openssl_x509_read(): X.509 Certificate cannot be retrieved'

Note that I need some help at this point to ensure tests are passing. Since travis is no longer runnings tests, I don't know if these tests used to work regardless of php8 or not, and don't have a good idea on if I've made backwards incompatible changes related to updates to phpunit.
In other words, I could use some extra help from from the maintainers!

The lastest code pushed past Travis on PHP 5.4, 5.5, 5.6 and 7.0 and had some issues with 7.1, 7.2 and 7.3
On my local environment them past so it should be some issue at the Travis, the 3.4.1 release past on Travis
Your code changes on the test made it incompatible with old versions of PHP
For example, the use of
 : void

or the method
assertStringContainsString

which was introduced in phpunit 7.5 which forces the use of PHP 7.1

I was able to reproduce the fails on my local with recent versions of the dependencies, so I believe is related to some change in dependency behavior

Thanks!
We’ll have to decide what to do as php 8 requires a newer phpunit, which in
turn requires the use the :void on the setup() method.
Perhaps a new major version of the library to differentiate php 7.4+?
On Mon, Dec 28, 2020 at 10:58 Sixto Martin<EMAIL_ADDRESS>wrote:

I was able to reproduce the Travis fails on my local with recent versions
of the dependencies, so I believe is related to some change in dependency
behavior
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/onelogin/php-saml/pull/456#issuecomment-751786408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADSDUYFWKGM45VKYU2D3KDSXC2J7ANCNFSM4VEMUCVQ
.

The errors on Travis started after using phpunit 7.5.18, that introduced 2 bugfixes:

Fixed #3967: Cannot double interface that extends interface that extends \Throwable
Fixed #3968: Test class run in a separate PHP process are passing when exit called inside

I guess the php-saml test that start failing are related to #3968.
Meanwhile I fix them, you could force in your local to use phpunit 7.5.17

I created https://github.com/onelogin/php-saml/issues/457.  I think it has low priority since we can simply use  phpunit 7.5.17 for now.

@fideloper
I already maintain the PHP5 (2.X branch) and the PHP7 (3.X branch).
I dislike introducing a new branch for PHP8 that will complicate more the maintenance of php-saml.
I prefer to try to make 3.X compatible with PHP 7 and PHP8 (maybe dropping the compatibility with PHP5 on the 3.X branch if there is no other choice)

Sounds good!
I'm not sure if it was lost in all the changes, but the change here makes the library compatible with php8 (this change isn't a change to the tests): https://github.com/onelogin/php-saml/pull/456/files#diff-b61383b8af6d0832f4319fa27427cb2ab7c7932efc870be2a558145fbd828da0
In terms of priority, that will need to get included in order to work with php 8.

Hi!
It looks like PHP8 requires a newer phpunit, so I can't pin version 7.5.17 of phpunit and still use PHP 8.
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires phpunit/phpunit 7.5.18 -> satisfiable by phpunit/phpunit[7.5.18].
    - phpunit/phpunit 7.5.18 requires php ^7.1 -> your php version (8.0.0) does not satisfy that requirement.

I may be getting a bit mixed up in our goals of this PR. Perhaps I (we?) can split this up into multiple PR's:

Get the library working in php 8
Get the tests working in php 8

Library Working in PHP 8
This requires an update to composer.json to change the PHP version constraint, and then ensuring that the function libxml_disable_entity_loader() isn't called in php 8.
Tests Working in PHP 8
This requires:

A different version of phpunit for php8

Which then re-surfaces the errors Test was run in child process and ended unexpectedly

Updates to phpunit tests assertions to account for changes/depreciations

Proposal
What I think we can do then, is take care of items 1 so this library is working for those on PHP8, and then do another PR to get the tests, etc, working for PHP8.
We can then work through the best strategy in terms of backwards compatibility, etc.

Sounds good

For those looking back later, here's a diff of the original PR changes: https://github.com/fideloper/php-saml/compare/3.6.0...3.6.0-original


Crash on iOS when GL or Metal commands run in background

This issue tracks gpus_ReturnNotPermittedKillClient (iOS 9.x) and MTLReleaseAssertionFailure (on iOS 10.x). Most likely the app is being killed trying to draw while backgrounded.
Example stack trace:
#0    (null) in __pthread_kill ()
#1    (null) in pthread_kill ()
#2    (null) in abort ()
#3    (null) in MTLReleaseAssertionFailure ()
#4    (null) in GLDTextureRec::update(unsigned int, unsigned short*) ()
#5    (null) in GLDTextureRec::load() ()
#6    (null) in gldLoadTexture ()
#7    (null) in gliSetInteger ()
#8    (null) in gliBindViewES ()
#9    (null) in -[EAGLContext renderbufferStorage:fromDrawable:] ()
#10    (null) in 0x100520000 ()
#11    (null) in 0x100520000 ()
#12    (null) in 0x100520000 ()
#13    (null) in 0x100520000 ()
#14    (null) in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ ()
#15    (null) in __CFRunLoopDoTimer ()
#16    (null) in __CFRunLoopDoTimers ()
#17    (null) in __CFRunLoopRun ()
#18    (null) in CFRunLoopRunSpecific ()
#19    (null) in 0x100520000 ()
#20    (null) in 0x100520000 ()
#21    (null) in _pthread_body ()
#22    (null) in _pthread_start ()
#23    (null) in thread_start ()

Example stack trace:
#0    (null) in gpus_ReturnNotPermittedKillClient ()
#1    (null) in glrKillClient ()
#2    (null) in gpusSubmitDataBuffers ()
#3    (null) in SubmitPackets(AGXContextRec*) ()
#4    (null) in 0x1004d8000 ()
#5    (null) in 0x1004d8000 ()
#6    (null) in 0x1004d8000 ()
#7    (null) in 0x1004d8000 ()
#8    (null) in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ ()
#9    (null) in __CFRunLoopDoTimer ()
#10    (null) in __CFRunLoopDoTimers ()
#11    (null) in __CFRunLoopRun ()
#12    (null) in CFRunLoopRunSpecific ()
#13    (null) in 0x1004d8000 ()
#14    (null) in 0x1004d8000 ()
#15    (null) in _pthread_body ()
#16    (null) in _pthread_start ()
#17    (null) in thread_start ()

We hope to have a fix for this this week.

Fix has landed with flutter/flutter#11746. Please re-open if you see this again.


My web server is already ssl protected how to proceed?

Hi!
In your setup guide you tell to server.js to use some certificates (about at line 20).
My web server is already running under https and it has trusted and valid certificates.
How can I modify server.js to run in my already protected web server?
Thanks!

write your server ssl way

Maybe you should include this in the server.js:
var options = {
    key: fs.readFileSync('../ssl/private/domain.com.key'),
    cert: fs.readFileSync('../ssl/certs/domain.com.crt'),
    ca: fs.readFileSync('../ssl/certs/domain.com.cabundle')
};

Please check this thread as well:

https://github.com/muaz-khan/WebRTC-Experiment/issues/62

You must force HTTPs here:
var isUseHTTPs = true;

You can force port 443 here as well:
var port = 443;

For more info:

docs/installation-guide.md#use-https

Thank you for your reply, there was a misunderstanding in my question, I didn't know that node.js creates a stand alone web server so I wanted to integrate node.js in an existing web server. The right answer is of Yamada4, I made my server away and setted my certificates without troubles, thanks!


[fx] Modify solver linearize and add corresponding test

What's New
In PR #1496, @super-dainiu suggests that we could use more elegant linearize code and node structure, but at that time we still worried about the time overhead for solver to solve the sequence. After some experiments, I'm sure that this old linearize could be left and use the suggested structure. I also add a test to check if the solver's sequence and annotated result is correct. Lastly, I fix a couple of lines of old inefficient code in activation_checkpoint_codgen.py and ckpt_solver_rotor.py.

Currently we use MetaTensor implemented by @super-dainiu, which could not be used in torch11, the above is the result of `test_fx`.


chore: follow slog api change

Codecov Report

Merging #460 (709834e) into master (af72a79) will decrease coverage by 0.64%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   59.26%   58.62%   -0.64%
==========================================
  Files          40       40
  Lines        2823     2823
==========================================
- Hits         1673     1655      -18
- Misses       1020     1034      +14
- Partials      130      134       +4

Impacted Files
Coverage Δ

core/ylog/slog_handler.go
96.38% <100.00%> (ø)

core/connection.go
67.50% <0.00%> (-22.50%)
:arrow_down:

core/server.go
61.74% <0.00%> (-2.24%)
:arrow_down:

core/client.go
64.34% <0.00%> (+0.43%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Test Explorer fails to run tests from linked files

The Test Explorer shows tests of all modules in the project, even if the module is a linked file or a file in a subfolder. But it fails to run the tests when the file is not in the project root dir:
Test Name:	test_B
Test Outcome:	Failed
Result StandardError:
Traceback (most recent call last):
  File "C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON TOOLS FOR VISUAL STUDIO\2.2\visualstudio_py_testlauncher.py", line 70, in <module>
    main()
  File "C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON TOOLS FOR VISUAL STUDIO\2.2\visualstudio_py_testlauncher.py", line 61, in main
    __import__(opts.module)
ImportError: No module named 'test1'

We are using CMake-generated projects, so the source files are always "linked".
(VS2015/Update 1, PTVS 2.2.31124.00)

found similar issue #840 Running tests from UI does not support module structure without package

As a workaround I set  to the folder with the py-files. Of course that does not work if you have multiple source folders.
I also had to modify visualstudio_py_testlauncher.py (see #1197).

Setting the working directory (through Project Properties, Debug) is probably easier and should have the same effect for tests.
Issue #840 is the same issue as this, so we'll track it there.


Feature/added annotation support

The discrete status bar plugin has been changed to allow annotations, display alerts, UTC support.
To support the annotations I used the jquery-ui library with the overcast theme.
Some limitations, which can be fixed if needed in the future are:1

i cannot detect the theme used, dark or light to change the annotation popup.
2>Snapshots cannot support alerts.3>I cannot detect colours , so i hard code the annotation and alert colours.
4>only one tag allowed for now.
5>just supported displaying the start of an alert, not the alert range.

Thanks!  I'm trying to get this running and having some troubles...   I made some changes to get it loading jquery but they don't seem to run with grafana5?
It keeps hitting an exception in:
angular-strap.js:
var r = $.fn.tooltip.Constructor.prototype.show.apply(this, arguments);

Can you make a different pull request for UTC support?  I can easily merge that.
Also, for the pull requests don't commit the dist files -- they are very likely to conflict and just make merging harder
Thanks!

I think I found an easier way to support UTC.  it is commited to master:
if (this.dashboard.timezone == 'utc') {
      displayOffset = (new Date().getTimezoneOffset() * 60000);
}

then it does not need the if( isUTC ) checks.
Can you take a crack at getting the PR mergable?  For sure, remove the dist/* from the request

@londonanthonyoleary check the latest in master.  I incorporated many of the changes (copy and paste), but none jquery ui stuff yet.
I'd like to see if its possible to reuse the standard annotation ui before building a duplicate

Great for doing that. I would have liked to use the  standard annotation ui instead of jquery.-ui, but I could not find any documentation on using the internal UI.  I had to produce a result for my Client so jquery-ui was the quickest way to do it. I will be back working on this plugin in the month month and will look at your comment then.

I'm going to close this and we can open a new PR when it is mergable


[Feature request] Embedded Utilities/Note Pad functions

Making the note pad more useful and easier to access:

Give it a tray icon, to prevent it from being obscured by other windows.

Allow typing or pasting the note contents first, and naming the note afterwards

2a. In other words, automatically create a new note every time the note pad is activated, and then silently delete that new note if the user begins by selecting an older one. Yes it's inefficient for the computer, but it's efficient for the person.

Give it an always-visible button bar instead of the wrench menu. It's not like the note pad is going to gain twenty other functions (it shouldn't anyway), and currently it's not immediately obvious how to use it. Wrench usually means "preferences", not "basic functionality" - I don't know why it has that meaning, but it's certainly the case.

Check out https://www.freshports.org/deskutils/copyq/ when you get a chance.  You can install it with sudo pkg install copyq


cli ERROR spawn ./gradlew ENOENT or EACCES

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Create a new directory
Run npm init --yes and npm i -g @bubblewrap/cli
Copy twa-manifest-.json into it using contents equivalent to:
twa-manifest.json.txt
Run bubblewrap build in the CLI
Chose No on bubblewrap update

Expected behavior
It should build without crashing.
Actual behavior
Building the Android App...

cli ERROR spawn ./gradlew ENOENT

If you create that directory with mkdir ./gradlew in tried again, the error message switches to:
Building the Android App...

cli ERROR spawn ./gradlew EACCES

Desktop (please complete the following information):

OS: [e.g. iOS] macOS Big Sur 11.5.1
Browser [e.g. chrome, safari] N/A
Version [e.g. 22] Bubblewrap 1.13.3

Closing out my old issues I no longer have context on. If anybody else is still seeing this, I'd encourage you to file a new issue with more information. Cheers!


Is there is a possibility to add a custom script?

I read through the Readme and project looks awesome indeed.
I'm a maintainer of our own fork of react-scripts at Revolut and I'm really tired of keeping it in sync with upstream CRA. This one gives ability to basically reduce it all to one big Revolut rescript except one thing, there is no possibility to add custom script.
We have a script named format that runs prettier in a predefined manner.
So basically revolut-react-scripts format is possible like start, test, build etc., but with this one I think it's impossible to do so.
Or maybe I'm wrong? :)
If it's impossible that would be amazing to be able to do something like that.

@RIP21 thank you for the kind words!
In response to your question: yes and no. I'll explain:
You can't configure Rescripts to take in custom commands via the CLI (such as a rescripts format command). If you want this functionality, I encourage you to PR the codebase 💯 what you can do is create a Rescript called format which triggers the necessary code:
rescript-format.js
module.exports = config => {
  format() // trigger the formatting
  return config
}

... and then use that Rescript in your config:
module.exports = [
  require.resolve('./path/to/rescript-format.js')
]

You can also tell the Rescript to spawn a new child process if your formatter is an executable.
My favorite solution though would be to move the formatting code into a scripts folder, give it executable permissions, and trigger it directly from your package.json. It's a more common pattern––plus––it makes it clear that it's not a built-in property of react-scripts or rescripts, and other developers working on your project can more easily locate the relevant code.
Please let me know if you have any more questions :)

Hehe. Quite obvious solution, my point was to make it as an executable so you can call like rescript format but if it's impossible I'll consider a PR cause it would be neat thing :)
Calling stuff from scripts making it non reusable... Anyway I can create my own cli tool and make it to npm if so needed, anyway. I try to keep dependencies list as small as possible :)
Thanks for a quick response.


Add CI check for clean repo after build

Eg
SOURCE_CHANGES=$(git status --porcelain)
if [[ -n "$SOURCE_CHANGES" ]]; then
  echo "Error: repository contains changes."
  echo "Showing 'git status' and 'git diff' for debugging reasons now:"
  git status
  git diff
  exit 1
fi

If we run yarn format-text in the same job, this can verifiy text formatting is up-to-date as well.


Optional Checking of a Generic Type not working using swift 6.0  on Mac (swiftlang-<IP_ADDRESS>.300 clang-16<IP_ADDRESS>)

Description
When trying to check if a Type conforms to a protocol which is extending Optional it delivers wrong result.
Checking does not work when using swiftlang-<IP_ADDRESS>.300 clang-16<IP_ADDRESS> with target MacOS
Code works as expected using swiftlang-<IP_ADDRESS>.300 clang-16<IP_ADDRESS> with target iOS
Code works as expected using swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS> with target MacOS
Code works as expected using swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS> with target iOS
Reproduction
// swift-tools-version: 5.9
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "OptionalCheck",
    products: [
        .library(name: "OptionalCheck", targets: ["OptionalCheck"]),
    ],
    targets: [
        .target(name: "OptionalCheck"),
        .testTarget(name: "OptionalCheckTests", dependencies: ["OptionalCheck"] ),
    ]
)

import XCTest

final class OptionalCheckTests: XCTestCase {
    func testExample() throws {
        XCTAssertFalse(isOptional(Int.self), "Int is not an Optional")
        XCTAssertTrue(isOptional(Int?.self), "Int? is an Optional")
    }

    func isOptional<R>(_ type: R.Type) -> Bool {
        R.self is OptionalProtocol.Type
    }
}

protocol OptionalProtocol {}
extension Optional: OptionalProtocol {}

Expected behavior
using swiftlang-<IP_ADDRESS>.300 clang-16<IP_ADDRESS> and target MacOS it should work like in swift 5.10 or like  target iOS
Environment
swift-driver version: 1.109.2 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.300 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
No response

@mikeash This looks like a runtime problem and not type-checker one, output of Sema is identical between 5.10 and 6.0 in this case but runtime behavior is different.

This specifically happens when using the new swiftc and running on an older OS. The new swiftc emits the conformance with an invertible protocol requirement. But the old runtime doesn't know how to handle that requirement. checkGenericRequirement bonks into this check:
  if (!req.hasKnownKind())
    return TypeLookupError("unknown kind");

And the check fails. @kavon how is this supposed to work when targeting an older OS version?

This should be fixed by https://github.com/swiftlang/swift/pull/74604

For release/6.0: https://github.com/swiftlang/swift/pull/74605


Fix error in error handling for server admins permission migration

This was failing on our migrations because it was trying to call nested string:concat calls on a combination of strings and binaries.
Build

What's the story on this?  Seems good to merge.

If it helps, we tested this is a one-off build for a deploy and it works


onevcenter command shows warning

Description
Using the onevcenter command in Ubuntu 1804 shows the following warning output besides its regular output, whenever used.
root@ubuntu1804-context-lxd-6fbc8-0:~# onevcenter import
/usr/lib/ruby/vendor_ruby/builder/xchar.rb:111: warning: constant ::Fixnum is deprecated
^[[ACould not get host info for ID:  - ID not defined
root@ubuntu1804-context-lxd-6fbc8-0:~# onevcenter list
/usr/lib/ruby/vendor_ruby/builder/xchar.rb:111: warning: constant ::Fixnum is deprecated
you need to use -o option!

The warning seems to be shown when loading the vcenter driver
root@ubuntu1804-context-lxd-6fbc8-0:~# grep vcenter_driver /usr/bin/onevcenter
require 'vcenter_driver'
root@ubuntu1804-context-lxd-6fbc8-0:~# vim /usr/bin/onevcenter
root@ubuntu1804-context-lxd-6fbc8-0:~# grep vcenter_driver /usr/bin/onevcenter
#require 'vcenter_driver'
root@ubuntu1804-context-lxd-6fbc8-0:~# onevcenter list
you need to use -o option!

To Reproduce
Use the onevcenter command
Expected behavior
No warning
Details

Affected Component: CLI
Hypervisor: vCenter
Version: 5.8.1

Additional context
On centos7 doesn't fail, likely because of the different ruby version

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

I have investigated and as I can see the problem is in builder gem:
lib/builder/xchar.rb:  Builder.check_for_name_collision(Fixnum, "xchr")
lib/builder/xchar.rb:          when Fixnum
lib/builder/xchar.rb:  # Enhance the Fixnum class with a XML escaped character conversion.
lib/builder/xchar.rb:  class Fixnum

It's also related with the ruby version, that's why the message is only shown in some operative systems, because we have different versions. So the only thing we can do is wait until the gem is updated or we change the ruby version...
As a workaround you can use export RUBYOPT="-W0 so the warnings messages are no longer shown on the terminal.


Zig Zag Level Order Traversal

Description
In this, I will explain how zig zag level order traversal is implemented and how its works, which DS is to be used.
Domain
CPP
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Coming from huntr (csrf)

I wanted to ask you a perhaps a little unnecessary question but why not use https://www.npmjs.com/package/csrf for your multiple csrf problems?
Cordially

Interesting you mention that - I thought the same - discussing it in in the pull request over here if you want to join in

That not fixes yet ?

So we've accepted a fix at huntr, which should be in a pull request for this repo

Nice 👍


 We should use pytest's  temp_files for this so we don't create too many files

Implemented in #51


JsObject Formater

First of all, congrats for your work. We are using a lot of it in my company.
I don't know if there's already a way to do this but it will be super cool if we can format JsObjects.
intruderOut.expectMsgPF() {
   case msg: JsObject => pprint.log(msg)
}

current output:
{"id":"562c9f72-5f4d-4868-8c39-9de450076772","type":"error","data":[{"code":3002,"message":"talker <YnPC7m> does not have permissions for conversation <069ba3ee-ceb8-4fd9-8063-67fe8a9f5718>"}]}

super cool output:
{
    "id":"562c9f72-5f4d-4868-8c39-9de450076772",
    "type":"error",
    "data":
    [
        {
             "code":3002,
             "message":"talker <YnPC7m> does not have permissions for conversation <069ba3ee-ceb8-4fd9-8063-67fe8a9f5718>"
        }
    ]
}

From the docs
// You can pass in an `indent` parameter to format it nicely
write(Array(1, 2, 3), indent = 4)  -->
  """[
    |    1,
    |    2,
    |    3
    |]""".stripMargin


angular $cookie problem

hi.im using angularjs v1.5.8 and i want to use $cookies for set cookie in browser.i use this method for set cookie :
$cookies.put("username", "peter");
but when browser closed the cookie is cleared!
i want to have cookie for unlimited time without exipre.
please help me.thanks a lot.

This sounds like a general support question. Please, use one of the appropriate support channels for these types of questions.
GitHub issues are reserved for bug reports and feature requests.
Thx !


Use tx to derive exit id instead of passing exit id directly

Issue Type

[ x ] bug report
[ ] feature request

Current Behavior
Currently when challenging a standard exit it is required to pass in an exit id. This increases attack surface on the challenge standard exit function as malicious users can pass in arbitrary exit ids to the function that do not relate to the exiting tx.
https://github.com/omisego/plasma-contracts/blob/7c3f79631ec0657b96cdd2077b0f52b2ec292261/plasma_framework/contracts/src/exits/payment/controllers/PaymentChallengeStandardExit.sol#L84.
Expected Behavior
Generate the exit id based on the exiting tx with getStandardExitId and remove the exit id as a function parameter.

On the other hand, due to our sadly despot tx bytes not unique issue, the exitId relies on utxoPos for deposit tx while not needed for normal tx. In other words, for normal tx we can ask user to pass in utxoPos but it will be useless. This create another attacking surface as well.


Shell and Global Nav Improvements

Target release: Iteration 16 (Dec 6)
Status: blocked Pending new IA/UX treatment from decision to treat apps as artifacts
Description
Improvements to the global nav and shell to

simplify user interaction with nav
make it easy to navigate from using one bee to a library of bees
make user settings more accesible and visible
de-emphisize "recent bees" in favor of access to tools and knowledge within a workspace

Motivation
Users today have difficulty

understanding they can pin the left nav (and therefore accessing navigation)
navigating back to their library of bees when they are in a specific bee

Proposed solution

permanent top nav bar
lefthand toolbar accessible from traditional hamburger menu
expanded toolbar is not "floating" but is anchored to left and right side of screen
Remove recent bees
Add links to Bees, Tools, Knowledge with amount of each
When in Bees, Tools, or Knowledge, sessions are global (at workspace level under the hood)
Workspace is removed
Workspace (if displayed) is shown on top nav, not lefthand toolbar and workspace actions (rename, delete / leave) are shown in overflow menu under workspace switcher. Note: we plan to comment out workspace due to confusion discovered by user studies cc: @spdempsey)

Example screens (see Figma for actual specs)

To consider for future interation:

When in a bee, sessions should be bee related

Note: may be minimal design changes added to this ticket based on Artifact Builder experience epic


PLEASE HELP!cannot launch the vsf app on server. Localhost:3000 redirecting to /error

Hello,
I followed the instruction to setup production site on AWS server,
but failed to show the VSF site.
it keep showing redirection loop
(if i changed the location in the file inside sites-available to other ports, that will display correctly)
I checked port 3000 is running on my ubuntu server
Not sure what happen. PLEASE HELP!
Thanks

Please help!
I have tested the app all fine on local machine thus i follow the production guide to launch on server.
Nginx ssl is all set, i have testes myURL.com/api is working fine!
BUT myURL.com/ cause redirect loop.
I do: curl localhost:3000 on server and it returned:
FOUND. Rediecting to /error
Can anyone please help? As i need to launch the shop asap.
Thanks in advance!
It showed the app is built but localhost:3000 is redirecting to /error

in var/v-sf.log it shows the app did complied successfully

Please make sure Your server app has the connectivity to the ElasticSearch

Thank you @pkarw.
May I have a little bit more information on how to test if elastic search is running?
Thanks so much.

Hello.
I have revised the elasticsearch and seems they are all ok in local.json.
But it still redirecting to /error....
Please let me know what to check next :(
Thanks a lot for your help!

I tried to remove the redirect /error from core/scripts/server.js,
and it show cannot GET / on the page.

Really stuck at this point, not sure how to make the app live :(

I ran Npm run dev and its showing on live.
clearly its not loading the backend.
I am not sure what setup was incorrect...

npm is not working now either, it shows up some error:

How does your storeViews configuration look?

Hi @Cyclonecode ,
Please see the attached screenshot, many thanks!

Why have you multistore set to true if you only have a single store? Can you also verify that you are using the same node/npm versions on both local and production environment?

Dear @Cyclonecode , Thanks for your reply!
I have upgrade the server node + npm version to sync with my local machine, change  multi storeview to false for now, remove 'dist' for both VS and VSF, yarn build and yarn start for both again.
but the error still showing up....  when I curl localhost:3000
"Found. Redirecting to /error"

This is the server log.
not sure if this causeing it error?
and i donno which file to fix :(

Let's move this issue to the forum please :) https://forum.vuestorefront.io


Improper handling of  "analyzer" in mapping

The following is one of the fields in the mapping returned from the source server.   This fails when attempting to copy the mappings using the --type=mapping with a error indicating that text_analyzer is recognized.
"myfieldname": { "type": "string", "analyzer": "text_analyzer" }
}
The original definition for "text_analyzer"  was made in a settings command posted with the index creation for the remote index.  Unfortunately those settings are not returned as part of the _mapping from the remote server.   I worked around this by deleting the , "analyzer": "text_analyzer"  portion and creating the index manually but need cleaner handling.
A better handling may be to remove the "analyzer" spec if you get an error trying to create that mapping in the target server.
I was copying from a elastic search version 1.3.1 to 1.7.1 but the same error occured when tested copying into version 1.4.3

Since I don't there is a way to extract the original command used to create the analyzer from an index, I think the right thing to is to actually throw an error, as the mappings really wont be correct.   We could add an option, --skipAnalyzers for the mapping import/exports.
Thoughts?

I like the --skipanalyzers option.
From: Evan Tahler<EMAIL_ADDRESS>Sent: Friday, August 28, 2015 2:16 AM
To: taskrabbit/elasticsearch-dump<EMAIL_ADDRESS>Cc: Joseph Ellsworth<EMAIL_ADDRESS>Subject: Re: [elasticsearch-dump] Improper handling of "analyzer" in mapping (#110)
Since I don't there is a way to extract the original command used to create the analyzer from an index, I think the right thing to is to actually throw an error, as the mappings really wont be correct. We could add an option, --skipAnalyzers for the mapping import/exports.
Thoughts?
—
Reply to this email directly or view it on GitHub https://github.com/taskrabbit/elasticsearch-dump/issues/110#issuecomment-135704618 .  https://github.com/notifications/beacon/AGaG8CbJTa9ZqqP75Hyrtewku0SLCEboks5osB5egaJpZM4FzwbM.gif

Cool.  We'll leave this issue open.
Pull requests welcome!

I think that the problem is with a file for analyzer...
elasticdump --input=http://{ip_address_from}/searchproduct/ --output=./data/production_searchproduct_analyzer.json  --type=analyzer
elasticdump --input=./data/production_searchproduct_analyzer.json --output=http://{ip_address_to}/searchproduct/ --type=analyzer
i have error...
Wed, 13 Apr 2016 07:54:44 GMT | starting dump
Wed, 13 Apr 2016 07:54:44 GMT | got 1 objects from source file (offset: 0)
Wed, 13 Apr 2016 07:55:14 GMT | Error Emitted => failed to parse json (message: "Unexpected token o") - source:
This work correctly
elasticdump --input=http://{ip_address_from}/searchproduct/ --output=http://{ip_address_to}/searchproduct/ --type=analyzer

@giocaputo can you please share a file that doesn't work (and a mapping from ES directly that does)?  without a test case, this won't get fixed

@evantahler "{"searchproduct":{"settings":{"index":{"creation_date":"1460463367823","analysis":{"analyzer":{"case_insensitive_sort":{"filter":["lowercase"],"type":"custom","tokenizer":"keyword"},"path_tokenizer":{"type":"custom","tokenizer":"path_tokenizer"}},"tokenizer":{"path_tokenizer":{"type":"path_hierarchy","delimiter":"/"}}},"number_of_shards":"5","number_of_replicas":"1","uuid":"euYkOcJTSD6mwba20NarLA","version":{"created":"2020099"}}}}}"
There is a " character at start and end of file. The \ escape... but also without it there is a problem

but mappers and data is not encoded like this and they work fine.

Having this same issue which means that analyzer dumps to files cannot be restored to a working index.

@ferronrsmith why did you close this?


Convert CustomSearchBar to Searchbar (material 3)

Is your feature request related to a problem? Please describe.
I want to use standard material 3 components
Describe the solution you'd like
Use material 3 component (searchbar) and maintain current behaviour with current search bar

as part of this ticket, we will convert our search bar to a full page search bar!


Fix JSON serialization, overhaul of Interchange internals

Description
This PR attempts to fix JSON serialization and deserialization
Checklist

[x] JSON encoder
[ ] JSON decoder
[ ] Round-trip some constructed systems in tests
[x] Remove temporary code
[ ] Add tests
[x] Lint
[ ] Update docstrings

Something is wrong with the JSON deserialization, but I think it's not a specific JSON thing. Roundtrips of most/all components complete without error, but do not preserve the correct information. The handlers are being processed as instances of the base PotentialHandler, not the specific ones that store necessary information.
In [19]: SMIRNOFFBondHandler.parse_obj(out['Bonds'].dict()) == out['Bonds']
Out[19]: True

In [20]: Interchange.parse_obj(out.dict())
Out[20]: Interchange with 9 atoms, periodic topology

In [21]: Interchange.parse_obj(out.dict())['vdW'].switch_width
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Input In [21], in <cell line: 1>()
----> 1 Interchange.parse_obj(out.dict())['vdW'].switch_width

AttributeError: 'PotentialHandler' object has no attribute 'switch_width'

Some work to be done, choosing to merge this now anyway.


Update es5-shim and es6-shim dependencies

Updating dependencies in order to get https://github.com/es-shims/es5-shim/commit/1716afab1be9c416a52918d7176272e8a097859e

@nateabele thanks for accepting the PR. Is it possible to get this change published to NPM?

done - v0.2.0 published


No documentation for linking ART in android.

Environment
OS: macOS High Sierra 10.13.5
Node: 8.11.3
Yarn: Not Found
npm: 6.1.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.1 AI-173.4819257
Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.0 => 0.54.0
Description
I am having errors while linking the react-native ART in android.
I found a solution at https://github.com/facebook/react-native/commit/27ac04742ab4665cd529fe63fd68a30db9293b76
On react-native run-android I am getting following errors
import com.facebook.react.ARTPackage;
                         ^
  symbol:   class ARTPackage
  location: package com.facebook.react
app-path/MainApplication.java:28: error: cannot find symbol
            new ARTPackage()
                ^
  symbol: class ARTPackage
2 errors
:app:compileDebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Without linking art manually I am getting following error:

This works fine on IOS device but gives error on android platform.
Also Is there a proper documentation on how to link Art with android namually?

Can you open an issue at https://github.com/facebook/react-native-website regarding the missing ART docs?


Allow setting different namespace root

Currently the root for any loaded namespace is the loader instance. But someone may want to set autoloads on another (named or anonymous) module, and there is no reason Im should not support this.
With this change, it is now possible to pass a root when initializing a loader. This root (a module) is then used in place of the loader itself as the root of the (auto)loaded namespace.
e.g.
mod = Module.new
loader = Im::Loader.new(root: mod)
loader.push_dir(...)
loader.setup

Now, autoloads are set on mod instead of loader. Passing Object as root here makes Im act like Zeitwerk.

I need to update the readme and add changelog entry etc, but otherwise this should be a simple change.


Additional functionality

Dear all, I'm currently using scanpy exhaustively and have noticed that compared to other R scRNA-seq packages some nice functionality is still missing.

Scater has the plotExplanatoryVariables function which plots the variance explained by different features (https://rdrr.io/bioc/scater/man/plotExplanatoryVariables.html). Is there currently an alternative in Scanpy for this plot?

Is there a variant for the mvoutlier package that is proposed in https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5408845/ for cell filtering?

Kind regards
Dries De Maeyer

Dear Dries, sorry, but I'm not going to have bandwidth anytime soon for implementing something like this. A pull request would, of course, be welcome! ;)


create basic ui

create basic UI using the command prompt

create a menu section and instructions on how to naviagate the menu section
create an entry section in the main.rb file
All method for the functionality of the menu in the app.rb file
menu section include

list all books
list all people
create a person
create a book
create a rental
list all rentals for a given person id
Exit

@afanimartin @BregornOriginal  I appreciate the good review and correction


Fixed #30457 - Added on_commit testing guidlines.

Refactored the database transactions document to contain earlier
guidelines about using TransactionTestClass. Ticket #30457 raised
issues about the documentation surrounding testing code that uses
on_commit. Added a warning earlier in on_commit documentation that
makes it clear what test class needs to be used and links to the
appropriate section with more information.

Thanks, however the fist PR #11805 proposed for this ticket contains also immediate_on_commit() hook, so IMO it's preferable.


fix tomatoes and others

tall variant. we have normal, waterlogged bottom and air top double tall. (rice).
double tall no waterlogged for tomatoes and others? which one.

done


Support allowing rewrite_imports to rewrite to URLs

I believe @marekbuild told me to create this issue in slack.
While buf supports a rewrite_imports option, it currently uses the : character to separate the search/replace terms of the rewrite. This means you can't rewrite to a URL, which is what I would like to be able to do in Deno.  example code.
Right now, my workaround is to rewrite to a relative import, (which has its own bug), and then import and re-export the library from there.
Possible solutions:

Only split on the first :, thus allowing there to be : characters in the replace.
Allow escaping : characters. (But this might get a bit ugly because you might end up having to double-escape in yaml?)

I am going to merge this one into #293, since that one is that main Deno support PR.


Use UDP in heartbeat

In v0.6.0, the heartbeat is sent over gRPC which is HTTP/2 over TCP.
We don't need a connection to send heartbeat. Even the response is not necessary. It is just leader sending heartbeat to followers periodically (like 100ms).
If we can send the heartbeat over UDP, there is no connection and it is ideal.

related topic: https://groups.google.com/g/raft-dev/c/LgtIgPqpkXI/m/VBp08KMPBwAJ

experimental implementation is here: https://github.com/akiradeveloper/lol/tree/experimental-udp-heartbeat


Normal user can login as an Admin

Each time when home fragment loads. Check the currently logged in user's ID to determine his permissions
        private FirebaseUser currentUser;
        currentUser = FirebaseAuth.getInstance().getCurrentUser();
        String currentUserId = currentUser.getUid().toString();
        System.out.println(currentUserId);

        if(currentUserId.equals("k3IEFP3100VtJeBD0K2hiUPOwzB3")){
            startActivity(new Intent(getActivity(), AdminDashboard.class));
        }```


Oracle WebLogic Server

Full and short name of product
Short Name: Weblogic
Full name: Oracle WebLogic Server
Does this product have LTS versions? What are the intervals between each LTS version?
All releases are LTS.
What is the website for the product and for its version information?
See comment below. For some reason I can’t paste here.
Additional context
Add any other context or screenshots about the product which you want us to add endoflife.date

https://www.oracle.com/us/support/library/lifetime-support-middleware-069163.pdf


Added CHANGELOG for 1.12.3

Looks good to me!

Want to merge https://github.com/pyviz/holoviews/pull/3728 as well.


optimize performance when normal and tangent are not necessary

Thanks @pasu, good catch!

I add name to CONTRIBUTORS.md
But it seems there is a conflict and  I have no access to modify it
It is my pleasure to make this little contribution and I hope I can make more contributions in the next year
I really think Cesium is a great virtual globe project.

Shall I close this request?
It is a small improvement,and I feel a little shy to interrupt you:)
@hpinkos

@pasu this is a good fix and we'd love to take it!  I'm not sure if we've received your signed CLA though.  Did you email that over to us?  That's the only thing holding this up, the code looks good to me =)

Hi @pasu!  Our contracts department is being really slow to review your CLA, so I opened my own pull request with this fix so we can get it merged in for the next release #4948
Thanks for bringing this up!  It's a good improvement.

OK so glad to see it @hpinkos
last week, it was the Chinese Spring Festive, that is why I did not visit here in time,
Happy Chinese new year~


Optimize release process

Current release process involves a few manual steps

change scala version "-SNAPSHOT" to non-SNAPSHOT
Release jars to sonotype
Bump scala code version to "{current + 1}-SNAPSHOT"
Modify python tests reference to it.
Change python version from ".dev" to non-dev.
make pypi release.
Change python version to "{current + 1}.dev"

All these steps are tedious and easy to break.  We should have a better automatic process. It'd be better to be trigger on Github Actions based on git tags.

Setup two workflows, one for python and another for sbt release. Both triggered on tag

https://github.com/olafurpg/sbt-ci-release
https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

Setup pypi, testpypi, and sonatype secrets in github
Script to bump both versions and add a tag if necessary (use bump2version + custom script for version.sbt ? )

Here was the process for v0.0.4 release:
Github: make sure head of master is green
Locally: git checkout master, git pull, make release
Locally: make fix, cd python && pytest
Locally: git log (check tag is there)
Locally: git push origin master —tags
Github: wait for new master commit to be green
Github: make new release (select existing tag, just check the commit is the right one)
Github: check the 2 release workflows finished
PYPI: check new version is there
Sonatype: oss.sonatype.org (check rikai new version has been published)
Maven central: check new jar is there (may take a few hours)

Future work:

Potentially could add another manually triggered workflow to encapsulate 1-7
in addition, we’ll need to all make release take in a new version argument. Right now it just bumps the patch version up which won’t work when we want to release 0.1
last thing is I am concerned about having the jar up after the python package
during the few hours if people are pulling the new python version but the new jar isn’t showing up then that’s going to be bad

Once everything is good, make patch creates the next dev0 version.


Django 2.0.11 + CMS 3.7.1 support?

Hi,
is this project supporting last versions of Django-cms? this would be awesome

@DanielPollithy ?

We currently don't have any plans to update the package.
However, if you'd provide a working PR we will review it and merge it.

thanks! in that case I will try to look into this.


X-axis needs unit of measurement label on chart

https://raw.githubusercontent.com/tbrand/which_is_the_fastest/master/imgs/result.png
The X axis has numbers, but no unit of measurement.
Ruby on Rails is ~208 what?

Those benchmark numbers are taken from one specific laptop anyways, so they're not really all that representative on other machines. Their relation to each other says more here than absolute values imho.
Nevertheless you're right about it being easier to tell the orders of magnitude one is faster or slower or another by knowing the units as well.

@hamitron
The unit is sec. I just drop the label at here. Will fix it. Thanks for the report.
https://github.com/tbrand/which_is_the_fastest/commit/9bec2a862951263707277bc5d93d2f1939bc61f5#diff-251cd489ffb425c194df01f80fe58dbd
@kiliankoe Agree but I just drop it at this time.


Uses all colors that colorbrewer provides for ktile styling

This PR switches to use the most color for each series of colorbrewer has to provide finer, but not overwhelming fine detail with customed ktile layer style.

@dorukozturk Thank you 👍


Reinhardt - make pin uncancellable

Likely impossible due to how shift appears to be hard coded to cancel pin.
Every possible combination of workshop button/ability disable logic has been tried and failed.


page breaks

CSS rule page-break-after seems to cause
[self prepareForDrawingPages: NSMakeRange(0, self.numberOfPages)];
to get caught in a loop until memory exhaustion.
CSS rule page-break-before works perfectly.
Might be worth a note in the readme explaining this.

Hi I'm having similar issues with page breaks. iOS-htmltopdf seems to create a large amount of whitespace after the page break. Any ideas how to fix this?

Sorry, I don't have any specific info about this. If you do figure out a fix, please let us know

It seems that using break-after instead of page-break-after is doing the job. page-break-before is also working for me but is inserting a white page "before" the breaking...


Ansible request to start using "changed_when: False" in the playbooks

Please put the name of the software product (and affected platforms if relevant) in the title of this issue

[ ] Missing install
[X] Bug in ansible playbook
[ ] Request for new playbook addition

Details: Suggested by @Willsparker in https://github.com/adoptium/infrastructure/pull/2420#discussion_r781036367

This is primarily for the times we use shell or command to query something- as it isn't changing the machine state, it should report as ok, not changed, however the shell and command modules will report changed by default. :-)


Objective-C compatibility

I basically just redid the changes from #38 without the extra whitespace and other changes.
I also finished the sample objc example. I did not do extensive tests but everything looks good.
Probably still need to update the documentation.

Thanks! This looks excellent, exactly what I was looking for from the other commit.

What was the issue with the closure stuff? I haven't done any work in objc with swift so I'm curious, I don't think I've heard of this particular issue.
Similarly to the other commit: I understand the need to convert the structs to classes, I'm slightly concerned about the value-to-reference change but I don't see any obvious implications unless you're holding onto the config objects after passing them to a pscope controller (which I can't think of a usecase for). Any thoughts on this @bre7?

I don't think there are any retention issues between Configs and PScope itself

@nickoneill I'm not sure the issue with the closure, I ran without that part and it works as well.
I can push a version without it, maybe @valentin7 can explain what the original issue was.
Regarding the mutability, something I did in the example was to reuse the same config for notifications for the singlePscope and the multiPscope. What we can do just to be safe is to copy the config before adding to the internal array. What do you think?

After thinking about it some more, copying the config classes is probably overkill. We'll deal with it if we have a problem later.
Let's move the closures to the usual syntax since we can't figure out why they were changed. Then this'll be ready to merge.

Didn't realize this was done. I'll merge this in later today. Thank you @felix-dumit!

@nickoneill Any news on the merge?

Sorry for the wait, I'll be testing and doing a new cocoapods/carthage release soon so this'll be easier to get at.


Feature/cmp 954/physical dimensions aspect: Prepare and register physical dimensions aspect to the provider setup

Why we create this PR?
Added physical dimensions digital twin and submodel payloads to the data uploader script. The following tasks are performed:

Prepare physical dimensions aspect
Create and register Digital Twin and Submodel
Register to the provider setup (EDC and Data Service)

What we want to achieve with this PR?
To test the dpp reusable backend component through the CLI script
What is new?
Updated

Updated data uploading script by adding physical dimensions aspect

Tickets

cmp-954

cmp-952

Good job!


multiple filter input -d

@edoardottt looking to get multiple domains to filter or more than one domain keyword to grab from the results with flat -d

Completed. Install v0.0.2
go install github.com/edoardottt/csprecon/cmd/csprecon@latest


Provider verification succeeds only for the first tag of a consumer

I have Pact provider verification tests which is verifying two tags of each consumer from the Pact Broker: @PactBroker(         host = "...",         port = ".",         tags = "master,prod" )
The test execution goes fine: for each interaction, there are two tests run (one for the master tag, the other for the prod tag).
As expected, the penultimate state test prints that there's 1 more interaction to verify for both the tags (it's a pity the tag names are not printed, but it's a different issue).
Verifying a pact between my-consumer and my-provider
  Given employee list exists
  list retrieval
DEBUG  [CALL] Completed filtering of request -> GET /my-url
    returns a response which
      has status code 200 (OK)
      has a matching body (OK)

WARN   [DefaultTestResultAccumulator] Not all of the 31 were verified. The following were missing:
WARN   [DefaultTestResultAccumulator]     customer history retrieval

Verifying a pact between my-consumer and my-provider
  Given employee list exists
  list retrieval
DEBUG  [CALL] Completed filtering of request ->  GET /my-url
    returns a response which
      has status code 200 (OK)
      has a matching body (OK)

WARN   [DefaultTestResultAccumulator] Not all of the 31 were verified. The following were missing:
WARN   [DefaultTestResultAccumulator]     customer history retrieval

Things get interesting on the last test. The first pact with the first tag gets their pacts verified (result is not published because I'm running tests locally), but the the pact with the second tag gets its verified interactions count reset and the pact is not verified.
Verifying a pact between my-consumer and my-provider
  Given customer history exist for customer #1
  customer history retrieval
DEBUG  [CALL] Completed filtering of request -> GET /my-url-2
    returns a response which
      has status code 200 (OK)
      has a matching body (OK)

WARN   [DefaultTestResultAccumulator] Skipping publishing of verification results as it has been disabled (pact.verifier.publishResults is not 'true')

Verifying a pact between my-consumer and my-provider
  Given customer history exist for customer #1
  customer history retrieval
DEBUG  [CALL] Completed filtering of request -> GET GET /my-url-2
    returns a response which
      has status code 200 (OK)
      has a matching body (OK)

WARN   [DefaultTestResultAccumulator] Not all of the 31 were verified. The following were missing:
WARN   [DefaultTestResultAccumulator]     get API version
WARN   [DefaultTestResultAccumulator]     login with valid credentials
... The list continues with 28 more unverified interactions

I dug into the code a bit and it seems the problem is that DefaultTestResultAccumulator uses hash of a Pact to store interaction results. The hash is calculated using only consumer and provider name:
    HashCodeBuilder().append(pact.consumer.name).append(pact.provider.name).toHashCode()

This means that differently tagged pacts of the same consumer have the same hash. Then, once one pact is fully verified, pact hash is removed from the testResults map: https://github.com/DiUS/pact-jvm/blob/master/provider/pact-jvm-provider/src/main/kotlin/au/com/dius/pact/provider/TestResultAccumulator.kt#L60
It seems like a solution could be to change the calculatePactHash to also take into account tag or consumer version.

Ah, right! It uses the contents of the Pact to determine when results are not complete, but not the tags. Yes, the tag should also be included!

@pkuras Was this resolved by @uglyog‘s change?

Unfortunately, I'm now affected by the linked issue #1113. Tests are now run only for the first tag of consumer.

Tested with versions 4.1.4 and the issue has been resolved.


Incorrect location of imported images

Import the image with the lasso mode selection still present and the position will change.

Hello huameiwei,
unfortunately I do not know exactly how to reproduce the error.
Would it be possible to send me a detailed description or a video? Your used lzy file would also be helpful.
Best regards
Dima

https://drive.google.com/file/d/16tM9aUyVTEZAULbOBJCLBMlxPWR4oBFb/view?usp=sharing
https://drive.google.com/file/d/1amODkZNnpQ0M0PY5rO2pv3lrkL4hvmzs/view?usp=sharing
This is the original workflow and lzy file, in ps, when you use the lasso tool, import the generated image, it will change the position of the.

When closing the lasso tool.

The image then imports fine, but I can no longer get the area selected by my lasso.

Since I'm using a remote comfyui, I need to upload an image every time。

This box appears every time and is rather disruptive. Can it be changed to an extension, or not displayed.
And there will be a problem, the same image will be transmitted every time, which may waste a lot of network traffic on the server. Is there a way to solve this?
I see that in krita ai, it is using base64 image nodes, would this image be the same without re-uploading the image?

https://github.com/Acly/comfyui-tooling-nodes
Here's the link to the plugin, hope it helps.
Thank you so much for developing this plugin, it's the best experience I've ever had with it and the most logical for me to use.

Since I'm not familiar with English, I'm using a translator, so if you don't understand anything, please let me know.
Have a nice life~
Thanks~

Hello Carl19,
thank you for using the tool and liking it.
There are two questions.

problem that the selection disappears. I have adjusted this in the new version. The selection is now retained when inserting the layer. In addition, the layer is now always inserted at the top right. Please test the version and let me know if it fixes your problem.
https://github.com/DimaChaichan/LAizypainter/releases/tag/0.0.31

every change is sent to the server.
This is intentional in design, the tool looks at the history. If this changes, the change is sent. The first version looked at your image and only sent something if the pixels have changed. But this method is quite slow and causes a lag in the UI.
However you can simply change the mode of the lzy file from loop to single:

  “config": {
    “label": ‘INPAINTING Selection’,
   “mode": ”single”
  }

Now the job is only sent once, the next one is only sent when you press Start again. Or when you press start and have a selection.
Thank you for using it and for your feedback.

你好，问题还没有解决，我测试了新版本，在取消选区时，导入的图像位置都不对了。

Hello Carl19,
I think the problem is now solved.
Please test the new version: https://github.com/DimaChaichan/LAizypainter/releases/tag/0.0.32
The problem is that Photoshop, with a layer with alpha values, only shows the filled area for the bounce. I had to take the information from the smart object.
I hope it works now.

Is it good that you tested in ps? When I tested it, I imported not the image I generated, but one of my local images. My system is macos.

Doesn't look like a mistake on your part, I'll take another look. :D

Hi,
could you test the updated version.
Sorry for the inconvenience. Testing is quite difficult with such problems.
https://github.com/DimaChaichan/LAizypainter/releases/tag/0.0.32

I am more than willing to help with testing.
The new version runs very well.
Thanks for all the hard work you put in.

If you need any other tests in the future, you can reach out to me as well.
Thanks again for making it.

Great, I'm pleased that it works.
Thank you for using it and if you have any ideas or problems, just create a new ticket. :D


Reformatter code

Can you share the reformatter code?

Hi. Modification approved. Thank you.
Em sex, 6 de jan de 2023 14:32, Tarık Kaan Koç @.***>
escreveu:

Hi @Joao-L-S-Almeida https://github.com/Joao-L-S-Almeida I updated
test_dist_data_parallel script. #18
https://github.com/IBM/simulai/pull/18
Can you share the reformatter code?
—
Reply to this email directly, view it on GitHub
https://github.com/IBM/simulai/issues/19, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIQOYDVR66CSTXGXV5TUTGLWRBJLBANCNFSM6AAAAAATTJMAEE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you take a look at the change I just made? https://github.com/IBM/simulai/pull/18

I'm in agreement with the modifications.


fix(product-import): add check for empty results from CTP

Summary
In our projects, sometimes we get this the error message: "Unhandled rejection TypeError: Cannot read property '0' of undefined.
It could mean one of the 2 options:

platform delivers empty response
the sphere product import processes the response wrongly and didn’t add result.body

In this PR, I added more detailed logs so it's easier to investigate next time we got an error.

Hi @daern91 Could you please merge and release?


Please add TMPFS_XATTR=y for the Scaleway Imagehub Docker image

Running Docker-Engine Unit Tests fails because Linux Extended Attributes are not supported from the kernel.
root@44d059a2b645:/go/src# go test -run "TestTarUntarWithXattr" -test.timeout=60m github.com/docker/docker/pkg/archive -v
=== RUN TestTarUntarWithXattr
--- FAIL: TestTarUntarWithXattr (0.00s)
        archive_test.go:648: operation not supported
FAIL
exit status 1

To be able to test & build Docker on a Scaleway host the kernel support for this is necessary.
The affected image is:
https://www.scaleway.com/de/imagehub/docker/
By the way: Is there way to add a self-build kernel to an existing/running Scaleway Server?

Hi @Govinda-Fichtner, the PR #167 adds TMPFS_XATTR for all the 4.2 kernels (except the fedora one which already got this option enabled)
We will release this kernel in the beginning of the next week (we are working on the automated kernel builds here: https://github.com/scaleway/qa)

For now, if you can't wait, I suggest you to change your boot-script to point to the fedora one or ignore this specific test
About the self-built kernels, it's still in beta, we can help you boot on your own kernel if you plan to often update it, or do not hesitate to open issues or pull-requests here, as soon as we have the automated builds setup, we should get more reactive to release new kernels

Awesome! I think we are happy with just a new Scaleway Image to choose from.

@moul Great! Thanks for your fast fix.

@moul Thanks a lot for the fast response. How do I get the Docker Image from the Scaleway Image Hub to boot with the new kernel? Currently it is version 4.0.5-235...

@Govinda-Fichtner the new bootscript is now available, the name is "4.2.5-docker #260", you can change it from the console or create a new docker server with the bootscript using scw: scw run --bootscript=docker docker

@moul Thanks you very much. It is working as expected and my xattr test is not failing any more.

perfect :)


Docs website seems to be out-of-sync with repo

The docs don't seem to be in sync with what's in the repo. For example:
https://docs.libuv.org/en/v1.x/misc.html
does not contain uv_clock_gettime but the repository does:
https://github.com/libuv/libuv/blob/a4649f5078134a4ef7fa355c21eeca9f2d5db9b0/docs/src/misc.rst?plain=1#L624-L635

Yes, probably I missed that step on the release process. I'll look at it later

It looks like the first failing build was https://readthedocs.org/projects/libuv/builds/19207402/ (#3882), which was attempt to switch from deprecated options to match the documentation here: https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

Oh, I see later it now is failing with build.os is missing https://readthedocs.org/projects/libuv/builds/20755139/. It must exist now and contain the string "ubuntu-22.04"

Looks like it's been resolved? I'll close this but please reopen if needed.


\bfseries and \textbf{} are not working properly

I was compiling new modercv template on Overleaf platform...I am not getting bold text as shown in the preview images.
Template: https://www.overleaf.com/latex/examples/resume-template-for-software-engineer/fvsqzcybnwdn

After compiling:

I've applied the solution from https://github.com/moderncv/moderncv/issues/102 and it seems to fix your issue.
You can also try and use a more recent verison of moderncv, the one on overleaf is recent but isn't the latest one.

Thank you @ShadowMitia :)

I had the same issue. For me, the culprit was \usepackage{CJK}.


Starbases heal 100% every turn?

Had a starbase that had 80% damage, and was repaired to 100% the next turn.
In this game I was CA, and didn't have ISB.
From the stars helpfile:

Your Starbase or an enemy one?

It was my starbase. A completely empty one.

I wrote a test to test a Starbase damaged 400/500 and it only repaired 50 as expected. I wonder if there is something happening during an actual game


Gulp 4 compatibility

Even though gulp 4 isn't out yet, I've been using the alpha version for a little while now. And I noticed that this plugin seems to have some problems with the new task system.
It gives no errors but tasks object in .sublime-gulp.cache file is empty.
You can easily test this with any project by first installing new CLI tools globally:
$ npm install gulpjs/gulp-cli#4.0 -g
And then updating gulp locally:
$ npm install gulpjs/gulp.git#4.0

Wow, thanks a lot for the heads up. I'm traveling in a couple of days but when I get back I'll definitely take a look.
Do you know when is gulp 4 scheduled to release?

I don't think there's any set date (anymore). So I guess it will be released as soon as possible.

@Smuliii  Well this should be fixed.
Please let me know if is working for you (it may take a bit to update if you're using Package Control) and thanks again.

Yep, seems to be working. Thanks!


feat(extension-chrome): implement UI design of wallet

The design Figma: https://www.figma.com/file/x49RWTMPXmN5UgbaCAkraN/wallet?node-id=216%3A1014&t=RNMavrC2pzncZsD2-1
This task is mentioned by https://github.com/ckb-js/nexus/issues/65

maybe we should change all the url to kebab-case, since

browser usually treated sign-data as two words, but signData is one word, it is hard for autocompletion
human-readable


Feature/asterisk

asterisks have been used on the candidates address form and this is not the GDS pattern.
PR removes them and also updates the tests to match

https://trello.com/c/2CfZytZ2/293-tta-flow-asterisk


Image tag fix

After turning on the mq: watch, another bug was found.
imgs = 'img'; // reset to a generic selector for watchMQ

This line broke a new check.

Thanks a lot! Coming in 3.2.3


"Malformed HTTP message" when using WSS

I'm using this test script:
#!/usr/bin/env python

import ssl
import asyncio
import websockets
import logging

logging.basicConfig(level=logging.DEBUG)

async def hello(websocket, path):
    name = await websocket.recv()
    print("< {}".format(name))

    greeting = "Hello {}!".format(name)
    await websocket.send(greeting)
    print("> {}".format(greeting))

context = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)
context.load_cert_chain(certfile='cert.pem')
context.set_ciphers('RSA')

start_server = websockets.serve(hello, 'localhost', 8764, ssl=context)

asyncio.get_event_loop().run_until_complete(start_server)
asyncio.get_event_loop().run_forever()

The keypair I'm using is self-signed.
When connecting from a web browser through wss, I get the following error:
> var ws = new WebSocket("wss://localhost:8764");
2016-05-17 11:20:59.148 WebSocket connection to 'wss://localhost:8764/' failed: WebSocket opening handshake was canceled

And on the server side:
$ python server.py
DEBUG:asyncio:Using selector: EpollSelector
INFO:websockets.server:Exception in opening handshake: Malformed HTTP message

I assume the browser closes the connection because the server certificate is untrusted. But there is no error message saying so.
Is there a way to emit a better / more helpful error message in this case?

In the scenario you're describing, the browser decides it doesn't like the certificate offered by the server, closes the connection, and doesn't quite tell you why.
The server doesn't know why the connection dropped. A network failure would have the same effect. Presuming that it's always a certificate error could be misleading in cases where it isn't.
The browser knows why it dropped the connection and should tell it. That's an issue with the browser, not with websockets.
Please let me know if you disagree with my analysis or see a way to improve the situation by making changes in websockets!

I see, thanks for the explanation! Would it be possible to indicate the difference between a "connection close" and a "malformed http message"?

Not sure, but that's worth investigating.

I tried reproducing this issue and I'm no longer getting a message at all in the server logs, perhaps due to changes in asyncio or in websockets. I think I'll leave it there.

For future reference my test script:
#!/usr/bin/env python

import asyncio
import logging
import ssl

import websockets

logging.basicConfig(level=logging.DEBUG)

async def hello(websocket, path):
    name = await websocket.recv()
    print("< {}".format(name))

    greeting = "Hello {}!".format(name)
    await websocket.send(greeting)
    print("> {}".format(greeting))

context = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)
context.load_cert_chain(certfile='websockets/testcert.pem')
context.set_ciphers('RSA')

start_server = websockets.serve(hello, '<IP_ADDRESS>', 8764, ssl=context)

asyncio.get_event_loop().run_until_complete(start_server)
asyncio.get_event_loop().run_forever()


feat: include npm release and docs in gh-pages workflow

Implemented a new Deploy.publish-npm workflow for releasing the new npm package with the tag release.
Implemented a new Deploy.publish-doc  workflow for updating client doc with the new release.

Sample doc can be referred to here:  https://ranjanrak.github.io/kiteconnectjs/

It is closed via this MR.


Group markers by name rather than by prefix

As I explained in #66, I had to create many repeated prefixes in order to allow different case scenarios. I thought using the same name would group all the markers, but instead it shows different markers in the UI

I know by doing 66 I'll have the chance to have them grouped again, since I'll be able to use a single declaration for all the case scenarios, but may be worth considering to group them by name anyway. Having repeated marker names in the UI is weird and a bad UX.

I'll aim for doing #66 first. I'll have to see how the grouping could work after that.


Inform client if fields are not filled in on submit before continuing to next page.

A tooltip should be shown on the grade input selection.
The emails should be the same when validating.
The user should be informed if the emails don't match.

Fixed


ads bug: CDS update without EDS results in 503 UH

If we push CDS, and update an existing cluster without an EDS update, we will get 503 UH 15s later
Pilot logs:
2020-10-29T14:54:52.034503Z     info    ads     Push debounce stable[6] 1: 100.181026ms since last change, 100.180817ms since last push, full=true
2020-10-29T14:54:52.035037Z     debug   ads     InitContext 2020-10-29T14:54:52Z/3 for push took 362.623µs
2020-10-29T14:54:52.035103Z     info    ads     XDS: Pushing:2020-10-29T14:54:52Z/3 Services:7 ConnectedEndpoints:1
2020-10-29T14:54:52.035600Z     info    ads     CDS: PUSH for node:istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system resources:2 size:800B
2020-10-29T14:54:52.035989Z     info    ads     LDS: PUSH for node:istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system resources:1 size:2.7kB
2020-10-29T14:54:52.036183Z     info    ads     RDS: PUSH for node:istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system resources:1 size:368B
2020-10-29T14:54:52.044794Z     debug   ads     ADS:EDS: ACK router~<IP_ADDRESS>~istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system~istio-system.svc.cluster.local-1 2020-10-29T14:53:37Z/2 tOy1HgpdiXI=44bd8ce3-e837-48e5-9345-8109f39457ec
2020-10-29T14:54:52.045413Z     debug   ads     ADS:LDS: ACK router~<IP_ADDRESS>~istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system~istio-system.svc.cluster.local-1 2020-10-29T14:54:52Z/3 kSd3h94ohvU=6690f8a8-f5c9-46aa-8c4a-3b575f0502a5
2020-10-29T14:54:52.045672Z     debug   ads     ADS:RDS: ACK router~<IP_ADDRESS>~istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system~istio-system.svc.cluster.local-1 2020-10-29T14:54:52Z/3 kSd3h94ohvU=de6967bf-57ee-4e26-b38d-523b4d19c176
2020-10-29T14:54:52.531025Z     info    ads     Push Status: {}
2020-10-29T14:55:07.046501Z     debug   ads     ADS:EDS: ACK router~<IP_ADDRESS>~istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system~istio-system.svc.cluster.local-1 2020-10-29T14:53:37Z/2 tOy1HgpdiXI=44bd8ce3-e837-48e5-9345-8109f39457ec
2020-10-29T14:55:07.046599Z     debug   ads     ADS:CDS: ACK router~<IP_ADDRESS>~istio-ingressgateway-6bdf7c75d4-6jm4q.istio-system~istio-system.svc.cluster.local-1 2020-10-29T14:54:52Z/3 kSd3h94ohvU=99c7aa01-6594-4d80-9fe8-34fa68e5c8bb

Note at 14:54:52 we get an "EDS ACK", but in reality envoy is re-requesting the endpoints for this cluster. When we fail to send them, we get an initial_fetch_timeout and get 503 UH 15s later.
Possible solutions:

Always send EDS when CDS changes. We almost do this, except for VirtualService which is only pushing CDS for gateways I think. One other risk is the new "blocked pushes" stuff, if EDS is blocked for 15s (I seriously cannot imagine this happening - but maybe) we may run into this. We may want to also make the blocked push timeout < the initial fetch timeout
Remove initial fetch timeout for EDS (and probably RDS)
Handle the ACK differently

cc @ramaraochavali @hzxuzhonghu

@lizan Is it a must that eds should always following a cds?
If it is not we should Handle the ACK differently

I believe this is only when updating an existing cluster that this can happen. see envoy issue #13009
Note this case is extremely rare. but still possible

wrong link

https://github.com/envoyproxy/envoy/issues/13009

Yes. If cluster properties are changed which will move the cluster to warming state, EDS is expected to finish the warming.

not stale

not stale

It seems that I encountered this problem, after I changed the istio-operator configuration, istiod seemed to enter the restart logic, and then the UH request occurred, because the cluster lacks endpoint, I would like to know on which version the issue was resolved.

We almost do this, except for VirtualService which is only pushing CDS for gateways I think.

@howardjohn Do we still need to do eds push when VS change now


Verbose and GPU layers = -1 - are both missing?

Usually when loading up a model with Llama you can specify n_gpu_layers=-1 and this will use all the available layers.
You can also add "verbose=False" and bypass the output messages of loading and making inferences.
It looks like this in python:
llm = Llama(model_path=model_path, n_gpu_layers=-1, n_ctx=4096, verbose=False)
I noted when I tried:
var parameters = new ModelParams(modelPath) {     ContextSize = 4096,     Seed = 1337,     GpuLayerCount = -1, };
It tried to offload -1 GPU layer.
I tried looking for "Verbose" or something similar, went through the entire list reading the description and could not find it.
Thanks btw, this is awesome, I was so sick to death of working in python it was great to find a solution in C# so I can use a real programming language! lol

n_gpu_layers = -1

I was initially quite confused by this!

This line says that -1 is "default" (whatever that means).
Then this line simply does nothing if the value is -1, which kind of makes sense if it's using the default.
However, over here we can see that the default is 0!

So from the cpp code, -1 means "no layers".
However, looking over at the Python code I found this which converts -1 into 0x7FFFFFFF, thus offloading all layers. So this is a special behaviour introduced by llama-cpp-python.
In your own code I'd recommend just setting int.MaxValue when you want to offload all layers.
In fact if you're interested in contributing to LLamaSharp it would be an easy PR to add some validation to the GpuLayerCount in this method to ensure it's not a silly value like -1. Or to replace any negative number with int.MaxValue, to get something like the python behaviour.

Verbose

I'm think this is another Python specific behaviour. llama.cpp has a llama_log_set method which is called whenever a message is logged (if not set it just prints it out). I guess llama-cpp-python must be hooking that method automatically and redirecting messages based on if verbose is set. As far as I know there's no verbose flag you can set in llama.cpp itself.
You should call NativeApi.llama_log_set with your own callback, then you can process messages however you like (e.g. redirect to a proper logging provider and suppress the categories you don't care about).

You know, I didn't think that the python implementation might have introduced those quality of life improvements.
Wouldn't this implement the -1 in the ToLlamaModelParams you referred to?  Sorry, not that great with GitHub to be doing pull requests into a live repo that isn't my own.
if (@params.UseMemoryLock && !NativeApi.llama_mlock_supported())
    throw new NotSupportedException("'UseMemoryLock' is not supported (llama_mlock_supported() == false)");
if (@params.UseMemorymap && !NativeApi.llama_mmap_supported())
    throw new NotSupportedException("'UseMemorymap' is not supported (llama_mmap_supported() == false)");
if (@params.GpuLayerCount == -1)
    @params.GpuLayerCount = int.MaxValue;

Rather than making -1 a special case I'd do it as:
if (@params.GpuLayerCount < 0)
    @params.GpuLayerCount = int.MaxValue;

That way any negative value mean "all layers".

Sorry, not that great with GitHub to be doing pull requests into a live repo that isn't my own.

The process is fairly simple:

Push your change into a branch in your fork
Visit https://github.com/SciSharp/LLamaSharp/pulls
At the top, there should be a button asking if you want to open a PR for your new branch
Done!

If you're struggling with it, I'm happy to add this change for you. Just say so - I don't want to take away a chance for you to contribute!

You know, I thought about the < 0 and then I thought - well, -1 means something to people who perhaps have used the Python port - and therefore those people would be expecting to offload all layers to the GPU and the int.MaxValue would make sense.
But I think I over thought it - what are the changes of "accidentally" typing a minus number there?
I will try and do a pull request, as I would like to contribute if I can - as this is a rather good project.

In my pull request, I forgot, I removed net8.0 from the csproj as I was trying to get the unit-tests to run.

That's fine, you can just re-add it and push to the same branch in your fork. It will update the PR :)

I'll close this one, since #424 has resolved the main issue.


Feature/colejd/misc changes

Added OC support and resolved the warning we were getting when running pod install.

:D Great changes, thank you @colejd


Feat mention feat mention support ArcoTextarea(rows), onSearch

Types of changes

[x] New feature
[ ] Bug fix
[x] Documentation change
[x] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

Solution

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
should be submitted to main branch)

Other information

@Minitiai 可以加个type属性区分下input和textarea，默认是input的，这样两种形式都可以支持下，类似https://www.naiveui.com/zh-CN/os-theme/components/mention的type，可以加个textarea.md的DEMO


pull request for e2e test at 12/11/2016 04:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[CALCITE-833] Correct the RelOptUtil.splitJoinCondition 's behavior

Addressed the review comment.

Looks good - testing now and will commit shortly.


Use mage build workflow instead of gradle

Since the golang base build tooling mage has now all features needed, the gradle workflow should be replaced with a new one base on mage

Will be closed with next release. Implemented with a1864c3b5fbbf63036d59534dadd1a03df188375

Fixed with Version 1.22.11


Run a reindex for the identifiers changes

I'm reindexing all the Sierra records to pick up changes to the notes field.

I've kicked this off.

Moving to "blocked", ish – the reindex is running, but reindexes against live are deliberately a trickle to avoid overwhelming the user-facing Elasticsearch cluster or CCR. We have ~1.4M items to go; it'll probably run over the weekend.

Closing as done. Identifier search still isn't working, but the in-place reindex I wanted for this ticket is done.


Multihost deployments with Kubeinit

Hi ccamacho,
sorry to but you, you did a fab job to create Kubinit, yet I still cannot get it to work, ... maybe you can giv eme a hint what I am dong wrong. Physically I got kit to support it, ...Let me give you a little insight into my set-up
4 physical machines
1-3) IBM x3650m4

2*10 CPU
64GB Ram

1TB disk btrfs

4 IP

eno2: <IP_ADDRESS> /<IP_ADDRESS> /<IP_ADDRESS>
eno3: dhcp
eno4: dhcp
eno5: dhcp
these should hold each one master and one worker

IBM x3550 m3

2*10 CPU
184 GB Ram

1TB disk btrfs

4 IP

eno2: <IP_ADDRESS>
eno3: dhcp
eno4: dhcp
eno5: dhcp
this one should house boot, services and 3 worker nodes

running the set up - takes about 3 hours and the script will complete successfully, BUT:

no access the OKD GUI interface ( https://console-openshift-console.apps.clustername0.kubeinit.local/)
error of the ovn-controller.log
2021-09-12T21:11:44.722Z|04721|patch|WARN|Bridge 'kiextbr0' not found for network 'externalserv'
2021-09-12T21:11:44.722Z|04722|patch|WARN|Bridge 'br-ex' not found for network 'provider'
(an entry every 3 seconds)
- spent dozens of days and nights on this but cannot make head of tail of OVS, I am pretty sure if I get this sorted
the whole thing will fly. (as it somehow does as oc shows me all nodes are up and ready)

What information do you need of me to trouble shoot this?
it would be great could I get this to fly. thank you in advance.

Hi @tmlocher would you mind to raise an issue in https://github.com/Kubeinit/kubeinit/issues so we can track your problem? Thanks.

Done already.
In the process of rerunning, ... I am using four of your blog entries, I do
see how the kubeinit evolves, but find it difficult to reconcile which
version (head/1.0.2) goes with which blog entry.
rerun I am doing on plain vanilla and will then look at the outcome.
Regards
Thomas
On Mon, 13 Sept 2021 at 08:13, Carlos Camacho @.***>
wrote:

Hi @tmlocher https://github.com/tmlocher would you mind to raise an
issue in https://github.com/Kubeinit/kubeinit/issues so we can track your
problem? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anstack/anstack.github.io/issues/80#issuecomment-917873982,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYH6O4WJLYU4OXBKNVDHTUBWJBTANCNFSM4X5UIWZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Thomas Locher
Felsenburgstrasse 7
8712 Stäfa
Schweiz/Switzerland
+41 79 175 23 53
Skype: tmlocher; LinkedIn Member

so I finally got the whole thing to fly. The issue is with openvswitch, it
fails due to seLinux. Once I had all those weeded out it worked. t
On Mon, 13 Sept 2021 at 09:05, Thomas Locher @.***> wrote:

Done already.
In the process of rerunning, ... I am using four of your blog entries, I
do see how the kubeinit evolves, but find it difficult to reconcile which
version (head/1.0.2) goes with which blog entry.
rerun I am doing on plain vanilla and will then look at the outcome.
Regards
Thomas
On Mon, 13 Sept 2021 at 08:13, Carlos Camacho @.***>
wrote:

Hi @tmlocher https://github.com/tmlocher would you mind to raise an
issue in https://github.com/Kubeinit/kubeinit/issues so we can track
your problem? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anstack/anstack.github.io/issues/80#issuecomment-917873982,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYH6O4WJLYU4OXBKNVDHTUBWJBTANCNFSM4X5UIWZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Thomas Locher
Felsenburgstrasse 7
8712 Stäfa
Schweiz/Switzerland
+41 79 175 23 53
Skype: tmlocher; LinkedIn Member

--
Thomas Locher
Felsenburgstrasse 7
8712 Stäfa
Schweiz/Switzerland
+41 79 175 23 53
Skype: tmlocher; LinkedIn Member

Hi @tmlocher sorry I didn't reply before, what was the issue you hit? You had to disable selinux? The latest master have many many improvements that are not documented yet, if you followed an specific workflow that you will like to have it upstream feel free to push a PR. I'll try to sort the docs issues we have ASAP. Thanks for using the project!

I will  recap and forward!
t
On Wed, 15 Sept 2021 at 18:47, Carlos Camacho @.***>
wrote:

Hi @tmlocher https://github.com/tmlocher sorry I didn't reply before,
what was the issue you hit? You had to disable selinux? The latest master
have many many improvements that are not documented yet, if you followed an
specific workflow that you will like to have it upstream feel free to push
a PR. I'll try to sort the docs issues we have ASAP. Thanks for using the
project!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anstack/anstack.github.io/issues/80#issuecomment-920189569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYH6NKM2NLSZUPZWZN2C3UCDE2XANCNFSM4X5UIWZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Thomas Locher
Felsenburgstrasse 7
8712 Stäfa
Schweiz/Switzerland
+41 79 175 23 53
Skype: tmlocher; LinkedIn Member


Add a callbacks like 'CanChange'

I need to validate using some rules if the new value can be accepted before changed.
Would be nice to have callbacks like: beforeIncrement. beforeDecrement, canChangeValue...
Thank you!

Fixed by #27 - thanks!


Update Redis to version 5

This is what I found on a Forge deployed server:

https://launchpad.net/~chris-lea/+archive/ubuntu/redis-server

Not sure this is everything there is to do for pull request 🤔
Current version is 5.0.6

@svpernova09 Would you merge this or is there anything for me left to do?

Will review this soon, thanks for the reminder.