HBASE-23847 Removed deprecated setStartRow from Scan

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 12 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 12s
master passed

+1 :green_heart:
compile
4m 23s
master passed

+1 :green_heart:
checkstyle
3m 55s
master passed

+1 :green_heart:
shadedjars
4m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  3s
master passed

+0 :ok:
spotbugs
1m 38s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
4m 25s
the patch passed

+1 :green_heart:
javac
4m 25s
the patch passed

+1 :green_heart:
checkstyle
3m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 57s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
3m  1s
the patch passed

+1 :green_heart:
findbugs
10m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 53s
hbase-client in the patch passed.

-1 :x:
unit
63m 35s
hbase-server in the patch failed.

+1 :green_heart:
unit
5m 58s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 31s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  4s
hbase-endpoint in the patch passed.

-1 :x:
unit
10m 39s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 12s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 16s
hbase-rest in the patch passed.

+1 :green_heart:
asflicense
4m 29s
The patch does not generate ASF License warnings.

186m  7s

Reason
Tests

Failed junit tests
hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures

hadoop.hbase.backup.TestFullRestore

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f61edd588736 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1220/out/precommit/personality/provided.sh

git revision
master / 3c3aae9a2f

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/1/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/1/artifact/out/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/1/testReport/

Max. process+thread count
9790 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 55s
master passed

+1 :green_heart:
checkstyle
4m 38s
master passed

+0 :ok:
spotbugs
1m 19s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 10s
the patch passed

+1 :green_heart:
checkstyle
3m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
findbugs
11m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
2m 15s
The patch does not generate ASF License warnings.

69m 45s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux f2aa1eed0093 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c61f95022d

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani Build is now green.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  3s
the patch passed

+1 :green_heart:
compile
5m  7s
the patch passed

+1 :green_heart:
javac
5m  7s
the patch passed

+1 :green_heart:
shadedjars
5m 25s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 25s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 55s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 18s
hbase-backup in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  5s
hbase-client in the patch passed.

-1 :x:
unit
7m  0s
hbase-server in the patch failed.

-1 :x:
unit
6m 44s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 35s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 24s
hbase-endpoint in the patch passed.

-1 :x:
unit
4m 25s
hbase-backup in the patch failed.

+1 :green_heart:
unit
0m 56s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 44s
hbase-rest in the patch passed.

75m 35s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 61aab53448e9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c61f95022d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/testReport/

Max. process+thread count
4574 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

JDK11 build will downvote this one until #1246 lands.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 19s
master passed

+1 :green_heart:
compile
4m 13s
master passed

+1 :green_heart:
shadedjars
4m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 14s
the patch passed

+1 :green_heart:
compile
4m 22s
the patch passed

+1 :green_heart:
javac
4m 22s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 57s
hbase-client in the patch passed.

-1 :x:
unit
71m 38s
hbase-server in the patch failed.

+1 :green_heart:
unit
8m 48s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 24s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  6s
hbase-endpoint in the patch passed.

-1 :x:
unit
15m 17s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 10s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 12s
hbase-rest in the patch passed.

147m 53s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 71a5ab393e83 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c61f95022d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/testReport/

Max. process+thread count
9870 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

JDK11 build will downvote this one until #1246 lands.

Oh okk, got it. Btw, +1 from me because the only failures are relevant to JDK11 related changes. We can wait and then merge this.

I'll hold-off my MRs until the JDK11 changes land. Then we can go for a complete green build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  3s
master passed

+1 :green_heart:
checkstyle
4m 51s
master passed

+0 :ok:
spotbugs
1m 31s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
3m 17s
hbase-server in master failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 56s
the patch passed

+1 :green_heart:
checkstyle
4m  4s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m  0s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
3m 24s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
1m 25s
The patch does not generate ASF License warnings.

73m 59s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0f7d103a5731 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Triggered a new build as the build failure is not related to the actual changes.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  0s
master passed

+1 :green_heart:
compile
4m 36s
master passed

+1 :green_heart:
shadedjars
5m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 50s
the patch passed

+1 :green_heart:
compile
4m 20s
the patch passed

+1 :green_heart:
javac
4m 20s
the patch passed

+1 :green_heart:
shadedjars
5m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-client in the patch passed.

-1 :x:
unit
116m 24s
hbase-server in the patch failed.

+1 :green_heart:
unit
18m 48s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 38s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  3s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
10m 44s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m  2s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 23s
hbase-rest in the patch passed.

203m  2s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 487b9eb67d74 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/testReport/

Max. process+thread count
6474 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 11s
the patch passed

+1 :green_heart:
compile
5m 24s
the patch passed

+1 :green_heart:
javac
5m 24s
the patch passed

+1 :green_heart:
shadedjars
6m 29s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 38s
hbase-client in the patch failed.

-0 :warning:
javadoc
1m  3s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 33s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
1m 21s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 33s
hbase-backup in the patch failed.

-0 :warning:
javadoc
0m 38s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 52s
hbase-client in the patch passed.

-0 :warning:
unit
125m 10s
hbase-server in the patch failed.

-0 :warning:
unit
11m 21s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
3m 11s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 15s
hbase-endpoint in the patch passed.

-0 :warning:
unit
4m 39s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m  5s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 16s
hbase-rest in the patch passed.

208m 28s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4733368cf076 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/testReport/

Max. process+thread count
5781 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m 48s
master passed

+1 :green_heart:
checkstyle
4m 27s
master passed

+0 :ok:
spotbugs
1m 28s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
3m  2s
hbase-server in master failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 11s
the patch passed

+1 :green_heart:
checkstyle
4m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 16s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
2m 54s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
1m 37s
The patch does not generate ASF License warnings.

68m 37s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux dcebfec45bc1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
10m 10s
the patch passed

+1 :green_heart:
compile
5m 58s
the patch passed

+1 :green_heart:
javac
5m 58s
the patch passed

+1 :green_heart:
shadedjars
7m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 33s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 55s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
1m 14s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-backup in the patch failed.

-0 :warning:
javadoc
0m 29s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

-0 :warning:
unit
8m  4s
hbase-server in the patch failed.

-0 :warning:
unit
10m 10s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 50s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 43s
hbase-endpoint in the patch passed.

-0 :warning:
unit
4m 50s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m  9s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 47s
hbase-rest in the patch passed.

114m 34s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0d60caf88caf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/testReport/

Max. process+thread count
4644 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 53s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  4s
master passed

+1 :green_heart:
compile
4m 25s
master passed

+1 :green_heart:
shadedjars
5m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  9s
the patch passed

+1 :green_heart:
compile
4m 10s
the patch passed

+1 :green_heart:
javac
4m 10s
the patch passed

+1 :green_heart:
shadedjars
4m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 54s
hbase-client in the patch passed.

+1 :green_heart:
unit
49m  5s
hbase-server in the patch passed.

+1 :green_heart:
unit
10m  7s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 25s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 28s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
7m 42s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m  9s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 45s
hbase-rest in the patch passed.

122m 45s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 853796db7a5b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/testReport/

Max. process+thread count
9561 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Build is essentially green. Only Findbugs is failing due to resource limits.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
checkstyle
3m 48s
master passed

+0 :ok:
spotbugs
0m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 55s
hbase-server in master failed.

-0 :warning:
patch
1m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  2s
the patch passed

+1 :green_heart:
checkstyle
3m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
2m 50s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
1m 37s
The patch does not generate ASF License warnings.

61m 43s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux 7d498ab792ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d019fd2eed

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 18s
the patch passed

+1 :green_heart:
compile
4m 48s
the patch passed

+1 :green_heart:
javac
4m 48s
the patch passed

+1 :green_heart:
shadedjars
4m 51s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 21s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 48s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-backup in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-client in the patch passed.

-0 :warning:
unit
74m 31s
hbase-server in the patch failed.

-0 :warning:
unit
12m  1s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
3m 55s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 41s
hbase-endpoint in the patch passed.

-0 :warning:
unit
5m 15s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 55s
hbase-it in the patch passed.

-0 :warning:
unit
6m 19s
hbase-rest in the patch failed.

153m 20s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 00600067c9b1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d019fd2eed

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/testReport/

Max. process+thread count
9282 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
4m 16s
the patch passed

+1 :green_heart:
javac
4m 16s
the patch passed

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 55s
hbase-client in the patch passed.

-1 :x:
unit
70m  5s
hbase-server in the patch failed.

-1 :x:
unit
16m 52s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 32s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 16s
hbase-endpoint in the patch passed.

-1 :x:
unit
17m 22s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 21s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m  1s
hbase-rest in the patch passed.

155m 10s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 27f6de5c502a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d019fd2eed

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/testReport/

Max. process+thread count
6081 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/5/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 43s
master passed

+1 :green_heart:
checkstyle
3m 50s
master passed

+0 :ok:
spotbugs
1m 25s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
3m  7s
hbase-server in master failed.

-0 :warning:
patch
2m 25s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 11s
the patch passed

+1 :green_heart:
checkstyle
3m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
3m 33s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
1m 34s
The patch does not generate ASF License warnings.

67m  8s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux bf16ede77231 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 64e67fb98b

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 16s
the patch passed

+1 :green_heart:
compile
4m 53s
the patch passed

+1 :green_heart:
javac
4m 53s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 21s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 48s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-backup in the patch failed.

-0 :warning:
javadoc
0m 23s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

-0 :warning:
unit
65m  5s
hbase-server in the patch failed.

-0 :warning:
unit
7m 57s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 35s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  4s
hbase-endpoint in the patch passed.

-0 :warning:
unit
4m 32s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 11s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 48s
hbase-rest in the patch passed.

134m 13s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 413b3d7562ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 64e67fb98b

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/testReport/

Max. process+thread count
6004 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 21s
master passed

+1 :green_heart:
compile
4m 10s
master passed

+1 :green_heart:
shadedjars
4m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 56s
master passed

-0 :warning:
patch
9m 10s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  3s
the patch passed

+1 :green_heart:
compile
4m 13s
the patch passed

+1 :green_heart:
javac
4m 13s
the patch passed

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 52s
hbase-client in the patch passed.

-1 :x:
unit
62m 10s
hbase-server in the patch failed.

-1 :x:
unit
21m  7s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 35s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 23s
hbase-endpoint in the patch passed.

-1 :x:
unit
9m 13s
hbase-backup in the patch failed.

+1 :green_heart:
unit
1m 12s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 48s
hbase-rest in the patch passed.

144m  5s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1220

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9e776d997e9a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 64e67fb98b

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/testReport/

Max. process+thread count
8824 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/6/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Typo in troubleshooting docs

Hi there,
It seems that there is a typo in the documentation:
I think it should mean "scanner" instead of "controller":

https://open-docs.neuvector.com/troubleshooting/troubleshooting/#:~:text=For performance issues%2C make sure the controller is allocated enough memory for scanning large images
https://github.com/neuvector/docs/blob/main/docs/12.troubleshooting/01.troubleshooting/01.troubleshooting.md?plain=1#L26

@90er can I kindly ask you to have a quick look on PR #96 and tell me if this was the place you saw the typo?
Thank you.


Fixed all accidental use of single backticks in docs

Add a custom role via Sphinx.add_role() that errors if used, and set it as the "default role", used by the single backtick syntax.
Also add a custom pyenchant spellchecker filter via sphinxcontrib-spelling to allow "Node.js" as a word.
The default default role is undefined by Sphinx, but comes out as italics. All of the existing uses were not for italics, but rather:

Mistaken code syntax, since Markdown uses single backticks
Forgotten roles like :ref:
Forgotten trailing underscores for links
Subverting the spellchecker

This will prevent such busy work / fixes as #12639 and #12536, plus the numerous fixes here.

Weirdly, django-admin in spelling_wordlist worked locally, but didn't on jenkins. Anyway I moved it to the new spelling filter.

I'm not 100% sure about the commit split. Why the spelling conf change in with the fixes, when the bacticks change is separate... — Inclined to take it as a single commit.

Fair, rearrange as you see fit.

@adamchainz What would you say to not adding the extra spelling filter and just using double backticks for those two words?

Done, although it's a little weird to use code formatting for Node.js, it is easier and it's just a couple places.


Unable to type letters in AccuInputField

Describe the bug
When typing in the AccuInputField, letters are not entered, so we cannot input units 'ft', 'in', 'm', etc..

In pink, we can see that some accudraw shortcuts have been mapped to keys that might be pressed for units.
We should make sure that when typing in the input fields, the event does not conflict with shortcuts and vice versa.
I think that this line might be the reason why letters are not registered.
https://github.com/iTwin/appui/blob/252752fb8244125cec0d0e87dd235175ed966ea7/ui/appui-react/src/appui-react/accudraw/AccuDrawInputField.tsx#L154
To Reproduce
No response
Expected Behavior
No response
Screenshots
No response
Desktop (please complete the applicable information)
No response
Additional context
No response

Related to : https://github.com/iTwin/iTwinUI/issues/2284


keyPrefix isn't handled right

i was in the middle of another pr when i found this - i'm not sure the best way forward.
it looks like there are two places to set keyPrefix, in the new CookieStorage() instantiation or as part of the options passed to createPersistor from redux-persist.
if i set keyPrefix in createPersistor then i can't get the custom expiration logic here to work correctly.
consider a reducer foo - if keyPrefix='_' in createPersistor then the CookieStorage's (get|set|remove)Item methods will all be called with _foo as the key instead of foo.
if i set keyPrefix in the CookieStorage (and not in createPersistor) things still don't work correctly because redux-persit will set a default prefix of reduxPersist:  which still breaks this logic.

Hi, sorry for the late reply.
CookieStorage doesn't know about the prefix used by redux-persist. As you say, (get|set|remove)Item) methods get called with the prefix.
Therefore, if you'd like to use custom expiration for individual keys, you need to include the redux-persist provided prefix in the configuration. For instance, using default reduxPersist: prefix:
new CookieStorage({
  expiration: {
    default: null,
    reduxPersist:foo: 600
  }
})

Could you try and see if this works for you? If so, I will update the example in the README to explain this properly.

Please reopen if this is still an issue for you.


Only tag video metadata

Sometimes I only want to add metadata to the video file, this works if there is a match with the settings but not when you're doing a batch on auto. This can be done without the -a command but you have to sort each media file.
command like -t to tell the script to only tag media.
Would this be possible while using the auto command?

What do you mean by "this works if there is a match with the settings but not when you're doing a batch on auto"?
It shouldn't be treated differently

if the settings is mkv h.264 tag metadata, any media that matches this will be tagged but if the media is mp4 then it will be converted. mp4 is fine and sometimes just want to tag the file that is mp4 or mkv.

e6535dd61d66b0c6de7f2275f58952a1df7f9df8
How's that?
Adds a -to or --tagonly option to manual.py

Awesome! looks good.
Does this also include tag only for mkv if there isn't a match in the config?

Yeah its agnostic of the format; the standard behavior is that it will default to tag only mode if the input format is already the same as the output format, that's probably why you were tagging mp4s but it wasn't anything against mkv files, just that it wasn't matching your output format. If your output format had been the other way around then mkvs would have tagged and mp4s convertd
the tag only option just skips all those checks and format checks and goes right to the tagging step

Thank you!
I've just tested it and without issue it works.

Is this the script or an error on my part? Tagging mp4 works well but tried MKV and this happened
`FFMPEG Tag Error.
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1052, in load
moov = atoms[b"moov"]
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/_atom.py", line 189, in getitem
raise KeyError("%r not found" % names[0])
KeyError: "b'moov' not found"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/resources/metadata.py", line 163, in writeTags
video = MP4(path)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_file.py", line 48, in init
self.load(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_util.py", line 156, in wrapper
return func(self, h, *args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1183, in load
self.info.load(atoms, fileobj)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_util.py", line 185, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1054, in load
raise MP4StreamInfoError("not a MP4 file")
mutagen.mp4.MP4StreamInfoError: not a MP4 file
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/resources/metadata.py", line 190, in writeTags
conv = converter.tag(path, metadata, coverpath, streaming)
AttributeError: 'str' object has no attribute 'tag'`

I have no idea why the converter object would be a string, that makes no sense

Do you have the full stack trace / logs from this?

That's all I have, that's the full log, it's what's inside of the log file.

How about the full manual.py output? I'm not able to reproduce this MKVs are working fine for me

2022-08-09 12:04:42 - MANUAL - INFO - Manual processor started.
2022-08-09 12:04:42 - MANUAL - INFO - Python 64-bit 3.8.10 (default, Jun 22 2022, 20:18:18)
[GCC 9.4.0].
2022-08-09 12:04:42 - MANUAL - INFO - Guessit version: 3.4.3.
2022-08-09 12:04:42 - MANUAL - INFO - /usr/bin/python
2022-08-09 12:04:42 - MANUAL - INFO - Loading config file /config/autoProcess.ini.
2022-08-09 12:04:42 - MANUAL - INFO - Tag only enabled
2022-08-09 12:05:27 - MANUAL - INFO - Processing file____.mkv
2022-08-09 12:05:33 - MANUAL - ERROR - Unable to retrieve rating.
2022-08-09 12:05:33 - MANUAL - INFO - Matched TV episode as _____
2022-08-09 12:05:33 - MANUAL - INFO - Processing _______
2022-08-09 12:05:33 - MANUAL - INFO - Tagging file: _____.mkv
2022-08-09 12:05:36 - MANUAL - ERROR - FFMPEG Tag Error.
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1052, in load
moov = atoms[b"moov"]
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/_atom.py", line 189, in getitem
raise KeyError("%r not found" % names[0])
KeyError: "b'moov' not found"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/resources/metadata.py", line 163, in writeTags
video = MP4(path)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_file.py", line 48, in init
self.load(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_util.py", line 156, in wrapper
return func(self, h, *args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1183, in load
self.info.load(atoms, fileobj)
File "/usr/local/lib/python3.8/dist-packages/mutagen/_util.py", line 185, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/mutagen/mp4/init.py", line 1054, in load
raise MP4StreamInfoError("not a MP4 file")
mutagen.mp4.MP4StreamInfoError: not a MP4 file
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/resources/metadata.py", line 190, in writeTags
conv = converter.tag(path, metadata, coverpath, streaming)
AttributeError: 'str' object has no attribute 'tag'
2022-08-09 12:05:36 - MANUAL - INFO - Relocating MOOV atom to start of file.
2022-08-09 12:05:36 - MANUAL - WARNING - QT FastStart did not run - perhaps moov atom was at the start already or file is in the wrong format.

conv = converter.tag(path, metadata, coverpath, streaming)
AttributeError: 'str' object has no attribute 'tag'`

Can you double check your installation and make sure you don't have any modifications or changes? I can't find any reason that converter should equal a string

Only the config
[Metadata]
relocate-moov = True
full-path-guess = True
tag = True
tag-language = eng
download-artwork = thumb
sanitize-disposition =
strip-metadata = False
keep-titles = False

I meant with the python files, make sure git doesn't detect any changes or inconsistencies, the config files aren't part of the repository so they won't be touched

Just deleted everything and downloaded. It works. It was the config file
[Converter]
ffmpeg = ffmpeg
ffprobe = ffprobe
threads = 0
hwaccels =
hwaccel-decoders = h264_vaapi, mjpeg_cuvid, mpeg1_cuvid, mpeg2_cuvid, mpeg4_cuvid, vc1_cuvid, hevc_qsv, h264_qsv, hevc_vaapi
hwdevices = vaapi:/dev/dri/renderD128
hwaccel-output-format = vaapi:vaapi
output-directory =
output-format = mkv
output-extension = mkv
temp-extension =
temp-output = False
minimum-size = 0
ignored-extensions = nfo, ds_store
copy-to =
move-to =
delete-original = True
process-same-extensions = False
bypass-if-copying-all = False
force-convert = False
post-process = False
wait-post-process = False
detailed-progress = False
opts-separator = ,
preopts =
postopts =
regex-directory-replace = [^\w-_. ]
[Permissions]
chmod = 7777
uid = -1
gid = -1
[Metadata]
relocate-moov = True
full-path-guess = True
tag = True
tag-language = eng
download-artwork = thumb
sanitize-disposition =
strip-metadata = False
keep-titles = False
[Video]
codec = h265, h264, h264vaapi, h265vaapi, h265
max-bitrate = 9058
bitrate-ratio = 0.8
crf = -1
crf-profiles =
preset = 4
codec-parameters =
dynamic-parameters = True
max-width = 0
profile = high
max-level = 0.0
pix-fmt = yuv420p, yuv420p10le
prioritize-source-pix-fmt = True
filter =
force-filter = False
[HDR]
codec =
pix-fmt = p010le
space = bt2020nc
transfer = smpte2084
primaries = bt2020
preset =
codec-parameters =
filter =
force-filter = False
profile =
[Audio]
codec = ac3,eac3,truehd,DTS
languages = Eng
default-language =
first-stream-of-language = False
allow-language-relax = True
channel-bitrate = 128
variable-bitrate = 0
max-bitrate = 0
max-channels = 0
filter =
profile =
force-filter = False
sample-rates =
sample-format =
copy-original = False
aac-adtstoasc = False
ignored-dispositions =
unique-dispositions = False
stream-codec-combinations =
copy-original-before = False
[Audio.Sorting]
sorting = language, channels.d, map, d.comment
default-sorting = channels.d, map, d.comment
codecs =
[Universal Audio]
codec = aac
channel-bitrate = 128
variable-bitrate = 0
first-stream-only = False
filter =
profile =
force-filter = False
move-after = False
[Audio.ChannelFilters]
6-2 = pan=stereo|FL=0.5FC+0.707FL+0.707BL+0.5LFE|FR=0.5FC+0.707FR+0.707BR+0.5LFE
[Subtitle]
codec = srt
codec-image-based =
languages = eng
default-language = eng
first-stream-of-language = False
encoding =
burn-subtitles = False
burn-dispositions =
embed-subs = True
embed-image-subs = True
embed-only-internal-subs = False
filename-dispositions = forced
ignore-embedded-subs = False
ignored-dispositions =
unique-dispositions = False
attachment-codec =
remove-bitstream-subs = False
[Subtitle.Sorting]
sorting = language, d.comment, d.default.d, d.forced.d
codecs =
[Subtitle.CleanIt]
enabled = False
config-path =
tags =
[Subtitle.Subliminal]
download-subs = True
download-hearing-impaired-subs = False
providers = opensubtitles
[Subtitle.Subliminal.Auth]
opensubtitles = password:pass
Addic7ed = password:pass
tvsubtitles =
[Sonarr]
host = localhost
port = 8989
apikey =
ssl = False
webroot =
force-rename = False
rescan = True
block-reprocess = False
[Radarr]
host = localhost
port = 7878
apikey =
ssl = False
webroot =
force-rename = False
rescan = True
block-reprocess = False
[Sickbeard]
host = localhost
port = 8081
ssl = False
apikey =
webroot =
username =
password =
[Sickrage]
host = localhost
port = 8081
ssl = False
apikey =
webroot =
username =
password =
[SABNZBD]
convert = True
sickbeard-category = sickbeard
sickrage-category = sickrage
sonarr-category = sonarr
radarr-category = radarr
bypass-category = bypass
output-directory =
path-mapping =
[Deluge]
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
host = localhost
port = 58846
username =
password =
output-directory =
remove = False
path-mapping =
[qBittorrent]
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
action-before =
action-after =
host = localhost
port = 8080
ssl = False
username =
password =
output-directory =
path-mapping =
[uTorrent]
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
webui = False
action-before =
action-after =
host = localhost
ssl = False
port = 8080
username =
password =
output-directory =
path-mapping =
[Plex]
host = localhost
port = 32400
refresh = False
token =

I don't think it was the config file, I think you had a messed up python file somewhere in there, there shouldn't be any config option that would have been turning the convert object into a string, try your old config file with clean python files

Out of curiosity, how are you updating from github when a new commit gets published?

No file has been edited other then config, I download and replace the files, I think now I'll delete all the files and add all the others in a clean folder. I check here every so often, it's hard to know what's been changed or added without a change log but I just download everything.
It's Working like there's no tomorrow.
Thank you! your good person!

All good, I would recommend you just use git clone and then you can do a quick git pull origin master on the directory whenever to upload and verify the file integrity, this won't interfere with config or log files

#!/bin/bash
git clone https://github.com/mdhiggins/sickbeard_mp4_automator
sudo ./update.sh
Any thoughts on including an update script?

It's just one line to update no need for a script
git pull origin master

If anyone comes across this and doesn't understand. Use git clone https://github.com/mdhiggins/sickbeard_mp4_automator then to update git pull origin master (at other time) within the folder.
Too easy, thanks again!


Uses the requestid from response when deleting requests

Request object does not have a .requestid property so requests were not being cleaned up and .requests was leaking memory in every Redis instance.
Fixes #224

@beaucollins good catch, thanks! :+1:

Released as 5.1.0


Add linux-asan and {linux,macOS,windows}-debug to the github test workflow

Three commits here:

Adds new tests to the github test workflow:

debug builds on Linux, macOS, and Windows
linux-asan

Initially, the new test configurations are advisory and do not block PR submission.
For ASAN and debug builds, benchmark builds are skipped to free up disk space. The runners have a nominal 14GB of storage consumed by build files, the build cache, and the tarball of build cache when it is saved.
With more build configurations there is more pressure on the bazel cache. This PR avoids caching files larger than 100MB as the nominal limit is 10GB across all the workerd build combinations.

Fixes a warning on macOS (workspace-status.sh using non-existent realpath). Variable was unused so just deleted.

Configures git hooks to quell warnings from workspace-status.sh on every invocation of bazel.

I am really excited about this. Looking at notes from past few weeks/months — would this generate debug build artifacts that could be quickly and easily pulled into Wrangler/Miniflare for any PR that gets merged, each commit? Seems like it could get us closer to having some form of alpha channel for local dev, where you could tell Wrangler to use workerd from latest commit of workerd? (relying on debug build) Even if it doesn't get us fully there, gets us a bit closer?
(excited of course about the safety this brings in CI as well too, which is going to be great to have)

I am really excited about this. Looking at notes from past few weeks/months — would this generate debug build artifacts that could be quickly and easily pulled into Wrangler/Miniflare for any PR that gets merged, each commit? Seems like it could get us closer to having some form of alpha channel for local dev, where you could tell Wrangler to use workerd from latest commit of workerd? (relying on debug build) Even if it doesn't get us fully there, gets us a bit closer?
(excited of course about the safety this brings in CI as well too, which is going to be great to have)

We should be able to use similar config in the release workflow and I'd imagine there's some github action options to roll out an alpha channel based on a daily tip-of-tree debug build. From there, we should be able to add the option to wrangler to fetch the latest alpha (hopefully).

@lrapoport-cf @mrbbot — think this could pave a path towards making things easier for Wrangler (see above)

Deeps sighs, but I've not been able to macOS stack symbolication to work with llvm-symbolizer. The combination of macOS, bazel, non-apple project, C++ is a bit challenging. This isn't strictly necessary for this PR though.

There is a failure here in Windows debug, but I believe that is pre-existing, ie have reproed at home, but not yet had time to investigate. @jasnell might be able to pinpoint this faster.

PTAL, I've decided not to try and solve the windows-dbg failure in this PR. Looking into this separately. Thanks.

One potential concern: I vaguely remember Github preventing merges if there are any builds still running, even if those builds are not required builds. I'm not sure if I got that right/if it applies here but that would effectively require debug/asan builds to finish running before PRs can be merged. We can see if that's actually happening/how to address it later on though.

One potential concern: I vaguely remember Github preventing merges if there are any builds still running, even if those builds are not required builds. I'm not sure if I got that right/if it applies here but that would effectively require debug/asan builds to finish running before PRs can be merged. We can see if that's actually happening/how to address it after merging this though.

We have the existing configs setup to be required, but not the new ones. Hopefully, this doesn't affect the time-to-merge.   For my money, time-to-revert needs to be very fast, whereas time-to-merge just needs to be prompt. An alternative would be to have post-merge builders, but that's more infra to setup and maintain. Let's see how we go.

PS Love that GitHub includes an advert for larger runners with this PR, particularly apt 💸 ☁


cli: versions:bump ignores registry specified in local .npmrc / .yarnrc

Expected Behavior
When I run yarn backstage-cli versions:bump, I'd expect the registry used in the new and updated in yarn.lock to reflect the project-local configuration in .npmrc or .yarnrc.
Current Behavior
Instead, it appears that local configuration is ignored in favor of the global registry configuration.
Possible Solution
From reading the backstage-cli code a bit, I can see that it works by removing entries from yarn.lock and then running yarn install. What's strange is, when I perform these two steps manually, the project-local configuration is respected. This leads me to suspect that something about the way that the cli runs the command is preventing it from reading the project-local config.
Steps to Reproduce

In a new instance created by an old version of create-app, add an .npmrc or .yarnrc with the registry set to https://registry.npmjs.org/. Set the global registry to something else (other than https://registry.yarnpkg.com - I used a private registry). Feel free to start from https://github.com/mtlewis/registry-bug-repro, which already has this done - probably easier than futzing around getting an old version of create-app.
Confirm that all entries in yarn.lock currently reference the npmjs.org registry.
Run yarn backstage-cli versions:bump
Note that any packages in yarn.lock that required upgrading will now have a resolved field with the private registry  URL.
Delete one of the packages resolved through artifactory in 4., and re-run yarn install manually. Observe that the package correctly gets resolved through registry.npmjs.org.

Context
This is a particular issue when people are working in both public and private contexts - they may have a global configuration using a private registry, and a project-local configuration that reverts to the public registry for Backstage specifically.
Your Environment

NodeJS Version (v14): v16
Operating System and Version (e.g. Ubuntu 14.04): MacOS 12.2
Browser Information: N/A

Just to double check, did you run the bump command in the repo root?

Hmm - I'm struggling to get a consistent repro here, and suspect this may actually be down to this bug in yarn itself: https://github.com/yarnpkg/yarn/issues/4458. In any case, I wouldn't recommend sinking any (more) time into triaging this for now.

Let's file this under reasons to migrate to yarn 3 😁

Totally.

Ah - figured out what I was doing wrong when putting together a repro for this before (I was trying to get yarn to switch between yarnpkg.com and npmjs.org to make the reproduction more universal, but I think there's special handling inside yarn to prevent unnecessarily switching between those two). Maybe worth a second person seeing if they can reproduce the issue by following the steps now listed in the issue summary.

Did a bit more digging into this. I suspect the problem is an inconsistency between the registry loading behavior inside yarn install, and the way configuration is propagated into the environment for scripts started through yarn run, as described here. When running yarn install directly, yarn correctly uses any local .npmrc file over the global one. Conversely, yarn run seems to read only the global .npmrc when figuring out what to set the npm_config_registry environment variable to. This environment variable overrides configuration files, so when running yarn install through yarn run, the registry set by yarn run wins and the global registry is incorrectly used (you can see this directly by running yarn run env).
It's possible to reproduce this issue without involving backstage-cli at all - running yarn install will use the correct local registry in the resolved field in yarn.lock, while running yarn exec yarn install will incorrectly use the global one. It's also possible to work around the issue when running backstage-cli by running the script directly, rather than through yarn.
Other than recommending this workaround, the only thing I can think of to fix this is to manually override the npm_config_registry environment variable if a local .npmrc or .yarnrc is found, which to me doesn't seem worth the effort.

I like the idea of deleting the variable to let yarn install work out what it should be again! What's the motivation for stripping all of the npm_ variables though? Seems like a more targeted deletion would be less likely to have unintended side effects.

@mtlewis I chose it because it most closely mimics a plain yarn install, where you typically don't have any config set at all. Was worried that other configuration options might have similar issues that we just haven't discovered yet. I'm also a bit scared that removing a subset of vars would lead to even more confusion, as right it's more of a "we ignore all npm_ env vars", rather than "we ignore vars x, y, and z".


Fix links to dependencies

This fixes an issue where package dependencies are not rendered correctly.
This also changes the names shown for these dependencies.
Before: fruits
After: localhost:0/fruits

This actually introduces a new problem--links to modules of a package dependency is now broken. I'm going to hold off on this for now.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.9.290",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8e4814a461787e15a31d322d9efbe0d4f6822428"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "8e4814a461787e15a31d322d9efbe0d4f6822428",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "scsi: core: Put LLD module refcnt after SCSI device is released\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.290 by commit 8e4814a461787e15a31d322d9efbe0d4f6822428. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001946


[BUG] VM Creation from Gallery Image fails

Library name and version
Microsoft.Azure.Management.Fluent, 1.38.0
Describe the bug
I'm trying to create a VM in C# with the Fluent API using a VM Gallery Image. Note that I verified all resources exist!
            var galleryImage = await azure.GalleryImages.GetByGalleryAsync(resourceGroup.Name, "..", "..", cancellationToken);
            var galleryImageLatestVersion = galleryImage.ListVersions()
                .OrderByDescending(x => Version.Parse(x.Name))
                .FirstOrDefault();

            var virtualMachine = await azure.VirtualMachines.Define("..")
                .WithRegion(region)
                .WithExistingResourceGroup(resourceGroup)
                .WithExistingPrimaryNetworkInterface(networkInterface)
                .WithWindowsGalleryImageVersion(galleryImageLatestVersion!.Id)
                .WithAdminUsername("..")
                .WithAdminPassword("..")
                .WithSize(VirtualMachineSizeTypes.StandardD2sV3)
                .CreateAsync(cancellationToken);

Expected behavior
The VM is created.
Actual behavior
I get an exception:
Microsoft.Rest.Azure.CloudException: Parameter 'osProfile' is not allowed.
   at Microsoft.Azure.Management.Compute.Fluent.VirtualMachinesOperations.BeginCreateOrUpdateWithHttpMessagesAsync(String resourceGroupName, String vmName, VirtualMachineInner parameters, Dictionary`2 customHeaders, CancellationToken cancellationToken)
   at Microsoft.Azure.Management.Compute.Fluent.VirtualMachinesOperations.CreateOrUpdateWithHttpMessagesAsync(String resourceGroupName, String vmName, VirtualMachineInner parameters, Dictionary`2 customHeaders, CancellationToken cancellationToken)
   at Microsoft.Azure.Management.Compute.Fluent.VirtualMachinesOperationsExtensions.CreateOrUpdateAsync(IVirtualMachinesOperations operations, String resourceGroupName, String vmName, VirtualMachineInner parameters, CancellationToken cancellationToken)
   at Microsoft.Azure.Management.Compute.Fluent.VirtualMachineImpl.CreateResourceAsync(CancellationToken cancellationToken)
   at Microsoft.Azure.Management.ResourceManager.Fluent.Core.ResourceActions.Creatable`4.Microsoft.Azure.Management.ResourceManager.Fluent.Core.ResourceActions.IResourceCreator<IResourceT>.CreateResourceAsync(CancellationToken cancellationToken)
   at Microsoft.Azure.Management.ResourceManager.Fluent.Core.DAG.CreatorTaskItem`1.ExecuteAsync(CancellationToken cancellationToken)
   at Microsoft.Azure.Management.ResourceManager.Fluent.Core.DAG.TaskGroupBase`1.ExecuteNodeTaskAsync(DAGNode`1 node, CancellationToken cancellationToken)
   at HolodeckPortal.Server.Services.VmService.CreateVmTask(VmDetails vmDetails, CancellationToken cancellationToken) in C:\Users\kolka\source\repos\HolodeckPortal\Server\Services\VmService.cs:line 121
   at HolodeckPortal.Server.BackgroundTaskQueueServiceHost.ExecuteAsync(CancellationToken stoppingToken) in C:\Users\kolka\source\repos\HolodeckPortal\Server\BackgroundTaskQueueService.cs:line 54

Reproduction Steps
See code above.
Environment
ASP.NET Core 6.0 app hosted in Azure App Service on Linux.

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@Kolky the Microsoft.Azure.Management.Fluent is going to retired soon, would you like to try it by using the new sdk https://www.nuget.org/packages/Azure.ResourceManager.Compute/1.0.0-beta.5
@weidongxu-microsoft please take look this fluent issue and check if this is sdk issue or service issue

Fluent SDK is in maintenance mode and will not add new feature. Please check the new SDK refed by Arthur in above comment.

Ok, too bad. I liked they way it looked in code. But I guess it was not very flexible as the new one which allows Linq e.d.
Tried the library @ArthurMa1978 suggested, that works! Thanks!


Redesign: Update background filter panel

Feature Description
See Figma

[x] Update title
[x] Update color input
[x] Update the name of the panel

Note: Keep the same filter toggle buttons for now as in the old panel. Updating those happen in #6527.
Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


[AzCopyV10][S2S][bug] Cannot list public S3 buckets

Resolving issues for https://github.com/Azure/azure-storage-azcopy/issues/1299

Running test pipeline with S3 tests ON, to avoid regression.


After delaywar -> ALL possible items get turned into gauze garters

While it is nice loopgyou does it, honestly it shouldn't do it without limits:
Visiting the Quartersmaster...
Preference availableQuarters changed from 0 to 409
You acquire 409 quarters
Preference _concoctionDatabaseRefreshes changed from 3253 to 3254
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 409 to 649
You acquire 240 quarters
Preference _concoctionDatabaseRefreshes changed from 3254 to 3255
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 649 to 1959
You acquire 1310 quarters
Preference _concoctionDatabaseRefreshes changed from 3255 to 3256
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 1959 to 2703
You acquire 744 quarters
Preference _concoctionDatabaseRefreshes changed from 3256 to 3257
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 2703 to 2914
You acquire 211 quarters
Preference _concoctionDatabaseRefreshes changed from 3257 to 3258
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 2914 to 3118
You acquire 204 quarters
Preference _concoctionDatabaseRefreshes changed from 3258 to 3259
Quartersmaster successfully looted!
Visiting the Quartersmaster...
Preference availableQuarters changed from 3118 to 3333
You acquire 215 quarters
Preference _concoctionDatabaseRefreshes changed from 3259 to 3260
Quartersmaster successfully looted!
Preference autoSatisfyWithNPCs changed from true to false
Preference _concoctionDatabaseRefreshes changed from 3260 to 3261
Preference autoSatisfyWithNPCs changed from false to true
Preference _concoctionDatabaseRefreshes changed from 3261 to 3262
Verifying ingredients for gauze garter (1666)...
Purchasing gauze garter (1,666 @ 2 quarters)...

At least give us a choice ;)

Thanks for the report! This should be fixed in the latest version.


Refactor several check test suites.

Moved more test suites from BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE to being defined (but skipped) in Bazel, to make use of enforce_glob in Bazel

(Bazel could still use filtering configurations for https://github.com/openxla/iree/issues/15233)

Added some missing test suites (like CUDA to tosa_ops)
Dropped the default ALL_TARGET_BACKENDS_AND_DRIVERS from iree_check_test_suite

I'm also considering refactoring these files to use iree_check_test_suite instead of 100s of lines of iree_check_single_backend_test_suite, to make the files (ideally) easier to work with. Here is a draft of what one of the files could look like: https://gist.github.com/ScottTodd/8379663fd2cbd1ea8a973b88c2a32a92

Ping?

Going to abandon this change. Might revive some of the ideas later.


performance improvement idea: drop metric names later

Currently, many simple functions such as abs() call DropMetricName() on every sample.
https://github.com/prometheus/prometheus/blob/0906f2eafa3506d411f2053ecba160a6c5ca0387/promql/functions.go#L536-L539
It would be more efficient to leave till the end and do once per series.  DropMetricName is hashed, so the additional work on every step of a range query is not huge, but we could eliminate that work and the hash table.
This is not a trivial change: there are about four different ways that functions get called and it took me a while just to follow all the logic.  I do think it should be possible to refactor this area more simply and understandably.
For functions that take a vector, any metric name in the output is ignored!
https://github.com/prometheus/prometheus/blob/0906f2eafa3506d411f2053ecba160a6c5ca0387/promql/engine.go#L1400-L1405

Some discussion about not dropping the metric name: #11397

With #14477 in, one might argue we are now doing what's being asked for here.
However, the new behavior is behind a feature flag, and if it is not set, we do the same thing as before (if I have read the code correctly).
It might very well be that the delayed name removal turns out to be a mistake, and then we are back to square one.
I guess we could still do the name removal late (as done in #14477) but make sure that logically things still work as if the name is not removed later (e.g. error out if in between there are duplicate label sets not considering the name; make it impossible to label-replace the name label in between, …).
I hope that #14477 will be the way to go for the future (although it creates some problems when dissecting a query and explore it in parts, may it be manually or with Promlens), but hope is not a strategy…
@bboreham your call if you want to leave this open.

Hello from the bug scrub.
@bboreham we decided to close this for now, but please re-open if you want to keep this in the loop.


Open containing folder doesn't work

Steps to Reproduce:
right click on a file
choose "open in containing folder"
nothing happens
I tried to open one of my project folders in nemo file manager by right-clicking in that folder -> Open containing folder
But after waiting, my Nemo FM is not open. hope the VSCode team can fix this.
I suggest that VS Code can provide a setting for this
OS Information

CPUs
Intel(R) Core(TM) i3-4005U CPU @ 1.70GHz (4 x 1621)

OS
Linux Mint Tara

Desktop Environment
LXDE

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwaresurface_synchronization: enabled_onvideo_decode: unavailable_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
3.78GB (0.20GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

VS Code Information
Version: 1.35.1
Commit: c7d83e57cd18f18026a8162d042843bda1bcf21f
Date: 2019-06-12T14:27:31.086Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-51-generic

This work for me, bot on OS X and Ubuntu.
Can you reproduce with vscode insiders https://code.visualstudio.com/insiders/
If yes, can you please post exact reproducable steps so we can repro on our machines and investigate. Thanks


Pull in items from get-proudcity issue

https://github.com/proudcity/get-proudcity/issues/46

Closing. Think we're pretty good in terms of the patterns we have.


Features/tryon

Add tryon as a postprocess for EasyPhoto.
For more details, you can refer to our wiki: https://github.com/aigc-apps/sd-webui-EasyPhoto/wiki/TryOn.
UI:

upload a template image (and give hints of the template ROI)
choose from cloth gallery (Your cloth will also be added into cloth gallery) / upload a reference image (and give hints of the reference ROI)
Click "Start TryOn Button"

When I ran it for the first time, I used a custom model(fine-tuned on SD1.5) other than the default model(Chilloutmix), but an error occurred. That error was validating hash of base model in the inference time (I guess). The inference step tried to validate with default model and my custom model.
Unfortunately, now it is impossible to reproduce 😢

maybe run chillout at first time to pass hash check is OK

tested  pass

color problem
more model

gallery model + gallery cloth
upload model + gallery cloth
gallery model + upload cloth


Version the workflows

Even if we put #73 in place, we could tag or create release branches so that downstream "uses" of swift_package_test.yml specify a constant semvar version instead of always working off of main which is more susceptible to breaking.
For example<EMAIL_ADDRESS>Looks possible to automate with certain marketplace actions like https://github.com/marketplace/actions/tag-release-on-push-action, but manually bumping as need may be sufficient

To add to this, the downstream repos can use dependabot for GitHub Actions action-updates, so dependabot automatically prompts those repos to update the workflow versions, specially if there is a new major version, and also considering something like @v1 means "up to next major, from v1", and doesn't mean "pinned to v1".


feat: Adding Open telemetry to publisher

This adds Open Telemetry traces to Publisher.
Also makes some changes to the PubsubMessageWrapper to allow for status/exceptions to be added to spans.
Note: Propagating the span context in the message will occur in an upcoming PR

@hongalex  / @hannahrogers-google / @maitrimangal  should this be merged in?


In modal forms is not display

when i use selectpicker class for select tag in a modal form.
the select tag does not show and it is hidden.
actually its display is none

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case (you can use our preconfigured Plunker), and report back with:

your link
Bootstrap version
bootstrap-select version
specific browser and OS details.

If you're not using the latest version of bootstrap-select, please try that as well.


Add UTM parameters to the links in the newsletter

This is idea suggested in https://github.com/tdziurko/jvm-bloggers/issues/8
Simply goal is to add UTM parameters to each link incluved in the newsletter.
Something like:
http://{link}?utm_source=jvmbloggers&utm_medium=newsletter&utm_campaign=jvmblogers#21

Hi Tomasz,
May I join the project? Is someone working on this task currently?

Sure, please join. No one as far as I know :) Write a comment saying that you are working on selected feature (this one for example) so no one starts coding same stuff :)
And join Gitter :)

Thanks :) I'm on it!

There are no source from utm_campaign identifier could be build from.  According to the wikipedia campaign date can be used for this purpose:

utm_campaign = name of the campaign, f.e. name of the campaign in Google AdWords, date of your e-mail campaign, etc.

Is it ok for you to build utm_campaign like utm_campaign=jvmblogers#2015-02-02 where 2015-02-02 is a date of sending newsletter?

Pull request #100 submitted, waiting for code review.


How to add AWS:SourceOwner condition

Is there a way to add below without dealing with all the strings?
policy.addConditions({ 'StringEquals': { 'AWS:SourceOwner': props.env.account } });

I saw there's an issue about conditions, not sure if it's related. Let me know how I can help if needed.

This seems to be a simple case of undocumented functionality. 😸 Floyd is fully based on the IAM service documentation and the condition context key is neither mentioned in the SES docs (I assume this is for SES, right?) nor in the list of global condition context keys.
I wasn't able to find much about AWS:SourceOwner, it only appears in context of SES, so I assume it might actually not be a global condition key but only related to SES. Maybe you know more about it? Either way, if it's global or not, AWS should document it in one or both locations.
Maybe you can suggest the AWS folks to cover this. AWS recently has removed the IAM docs from their public repo, so, the only way left to get this fixed is to contact the related team. They have a link at the bottom of every page in the documentation for this. When it shows up on the IAM SES page it will automatically show up in Floyd as well.
cc: @bonniekeller (manages the AWS IAM userguide repo)
Cheers,
Daniel

I see. You're right it's not listed anywhere. I found it while configuring a SNS topic here.

But generally my question was, what's the plan to support conditions? Is #6 about this question? (let me know if you need a hand.)

Documented conditions are available as if* methods. In case of SES, you can use these methods:
.ifFeedbackAddress(...)
.ifFromAddress(...)
.ifFromDisplayName(...)
.ifRecipients(...)

Global condition context keys are prefixed with ifAws and available on all IAM services. So if AWS:SourceOwner would have been documented, it would be available as .ifAwsSourceOwner(...).
#6 is about the default condition operator. (every if* method takes an optional operator as last parameter) In my opinion, many types are not documented correctly in the AWS docs. The example mentioned in #6 is s3:object-lock-remaining-retention-days. If you look it up in the documentation, you see it is of type string. Apparently a numeric type would be a better choice for a number. I found many more of these cases, where types could/should probably be of type Date, ARN or what not. But to find, test and report all these cases to AWS takes time and I haven't been too motivated spend so much time to fix the AWS' docs. I probably will just close the #6 at some point.
Cheers,
Daniel

Hello, I saw the mention so I wanted to reach out. Amazon Simple Notification Service is the only service that supports aws:SourceOwnerhttps://docs.aws.amazon.com/sns/latest/dg/sns-access-policy-use-cases.html#sns-allow-any-aws-resource-to-publish-to-topic. This key does not work with other services because it is not a global condition key. This key serves the same purpose as aws:SourceAccounthttps://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-keys.html#condition-keys-sourceaccount which is used to specify the account that owns a resource.
Best Regards,
Bonnie
From: Daniel Schroeder<EMAIL_ADDRESS>Sent: Friday, February 12, 2021 4:18 AM
To: udondan/iam-floyd<EMAIL_ADDRESS>Cc: Keller, Bonnie<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [udondan/iam-floyd] How to add AWS:SourceOwner condition (#56)
Documented conditions are available as if* methodshttps://iam-floyd.readthedocs.io/en/v0.130.0/vocabulary.html#if-condition. In case of SES, you can use these methods:
.ifFeedbackAddress(...)
.ifFromAddress(...)
.ifFromDisplayName(...)
.ifRecipients(...)
Global condition context keys are prefixed with ifAws and available on all IAM services. So if AWS:SourceOwner would have been documented, it would be available as .ifAwsSourceOwner(...).
#6https://github.com/udondan/iam-floyd/issues/6 is about the default condition operator. (every if* method takes an optional operator as last parameter) In my opinion, many types are not documented correctly in the AWS docs. The example mentioned in #6https://github.com/udondan/iam-floyd/issues/6 is s3:object-lock-remaining-retention-days. If you look it up in the documentationhttps://docs.aws.amazon.com/service-authorization/latest/reference/list_amazons3.html#amazons3-s3_object-lock-remaining-retention-days, you see it is of type string. Apparently a numeric type would be a better choice for a number. I found many more of these cases, where types could/should probably be of type Date, ARN or what not. But to find, test and report all these cases to AWS takes time and I haven't been too motivated spend so much time to fix the AWS' docs. I probably will just close the #6https://github.com/udondan/iam-floyd/issues/6 at some point.
Cheers,
Daniel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/udondan/iam-floyd/issues/56#issuecomment-778162104, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANEPZBZ3VHO5J7UMQJSFA43S6UL7XANCNFSM4XOU7UMA.

Thanks for clarifying @bonniekeller! 🖖🏼

I'm not sure about the conclusion of this conversation. Feel free to close the ticket if it's not gonna be implemented.

Yeah let's close this. I reported the missing condition to the team via the feedback link on the IAM page. Maybe you can do the same. The more reports the better. :)