Exposes Properties on ProjectOptions

This exposes the collected properties on ProjectOptions.  This will allow the caller to get at information like IntermediateOutputPath which can allow for consumers to stop hardcoding obj folder paths.

Those 7.0 failures seem to be the System.Array failure that we've seen intermittently @TheAngryByrd.


Better validation for loaded YAML

In GitLab by @tristanvb on May 12, 2017, 07:47
Currently we have very good validation for the YAML that we do load, but no validation on the YAML that we don't load.
For the YAML that we do load, if ever the reported data is an incorrect type, or if a mandatory member is missing; we raise an exception with the filename and line, column information of where things went wrong, and this is nicely reported to the user.
What we should additionally be doing is have a method for validating dictionary nodes and ensuring that no unexpected members are encountered, it should take a list of strings to check for loaded dictionary keys and raise an exception with the filename, line and column information for where any unexpected dictionary members were declared.
This should have a base implementation in _yaml.py which the _loader.py can use for validation of the base format; additionally an API should be exposed in plugin.py for Element and Source plugins to use at plugin->configure() time to assert a correct configuration.

In GitLab by @tlater on Sep 8, 2017, 10:04
created branch 24-better-validation-for-loaded-yaml

In GitLab by @tlater on Sep 8, 2017, 10:04
mentioned in merge request !87

In GitLab by @tristanvb on Sep 14, 2017, 17:07
closed via merge request !87


Shiny publications table: increase author, title column widths

 Shiny publications table: increase author, title column widths


Add docs files

Changes made include TODO is missing logic to make youtube player go to certain timestamps. Also, found missing styles for this section about SNARKs:

Wow our table styles need work on both the old and the new websites, we can address that later though


Merge into swift-4.0-branch: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

TSan now has the ability to report races on "external" object, i.e. any library class/object that has read-shared write-exclusive threading semantics. The detection and reporting work almost out of the box, but TSan can now provide the type of the object (as a string). This patch implements this into LLDB.
Differential Revision: https://reviews.llvm.org/D30024
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@295342 91177308-0d34-0410-b5e6-96231b3b80d8

@swift-ci please test

@swift-ci please test

@swift-ci please test


New version breaks hotkey and other mod

In version 0.0.7 page-down works to cycle backwards for the miner resource. This no longer works in 0.0.8.
Same thing for the mod LazyOutposting, old version doesn't break the water pump from working without actual water, new version breaks that.

@AaronMDavis BepInEx version?
could you dm me in discord Tony#7977

5.4.17


Update de_de.json

Apologies, the translation key set was outdated (31ec76f). Please update your PR with the new keys when convenient.

Here is the Updated File, I missed the "Trigger Macro" string, my bad

But is it right that "option.commandkeys.key.delay.individual.tooltip" string got removed completely?

Yes, it was split into .first and .subsequent


throwing in mount causes template refs to malfunction

Vue version
3.2.41
Link to minimal reproduction
https://stackblitz.com/edit/js-bhm79m?file=index.js
Steps to reproduce
Run an example, observe console.logs
What is expected?
testRef.value should not be null and should point to component inside#app2
What is actually happening?
testRef.value is pointing to component inside #app1 (first mount point)
or (if you had HMR) it will be null :bomb:
System Info
No response
Any additional comments?
if we add errorHandler to app1 via app1.config.errorHandler - error goes away

@LinusBorg you've tagged this one as "need more info". Indeed, my initial description was a bit wrong (that's because behavior is different when HMR takes place), I've updated reproduction and issue description with more precise information
thank you!

Thanks. I now realize I forgot to hit the "Comment" button after setting that  label. The comment would have read:

Works fine for me:

Your clarifications help, thanks. Seems weird 😅

I think this is because some variable values are shared between different apps, and if the first-mounted app throws an error it may cause some variables not to be reset, which in turn causes the later-mounted app to behave in a way that is not expected.
For example, in the following code, since the mounted hook is called in flushPostFlushCbs, if it throws an error then the rest of the code will not be executed.
https://github.com/vuejs/core/blob/6aaf8efefffdb0d4b93f178b2bb36cd3c6bc31b8/packages/runtime-core/src/scheduler.ts#L245-L253


Release v0.74.0

Deploy preview for gestalt ready!
Built with commit f5d19e879458f68590c072f952bfbbbe3330fd85
https://deploy-preview-255--gestalt.netlify.com

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   70.55%   70.55%
=======================================
  Files          45       45
  Lines         815      815
  Branches      188      188
=======================================
  Hits          575      575
  Misses        169      169
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9eaa7...f5d19e8. Read the comment docs.


Dynamic symbols aren't exported

Bug description
I'm trying to export a naked function in a cdylib crate. The generated assembly looks fine, yet no symbols are exported.
#[no_mangle]
extern "C" fn foo() {
    unsafe { std::arch::asm!("nop") };
}

#[naked_function::naked]
#[no_mangle]
pub unsafe extern "C" fn bar() {
    asm!(
        "nop"
    )
}

// generated with: cargo +nightly rustc --profile=check -- -Zunpretty=expanded

#![feature(prelude_import)]
#[prelude_import]
use std::prelude::rust_2021::*;
#[macro_use]
extern crate std;
#[no_mangle]
extern "C" fn foo() { unsafe { asm!("nop") }; }

extern "C" {
    #[link_name = "bar"]
    pub fn bar();
}
global_asm! (".pushsection .text.bar,\"ax\", @progbits\n.balign 4\n.globl bar\n.hidden bar\n.type bar, @function\n\nbar:\n\nnop\n.size bar, . - bar\n.popsection\n\n");

$ cargo build --target=x86_64-unknown-linux-gnu
$ nm -D --defined-only target/x86_64-unknown-linux-gnu/release/libblah.so
00000000000010f0 T foo

Environment
$ uname -a
Linux peelz-pc 6.3.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 30 May 2023 13:44:01 +0000 x86_64 GNU/Linux

$ cargo rustc -- --version
rustc 1.70.0 (90c541806 2023-05-31)

This version script doesn't include any symbols defined by global_asm! since rustc is not aware of them.

Is there a way to inject new symbols, perhaps via build.rs?

Not that I know of. I think the only way to make this work would be to extend global_asm! with the ability to tell rustc about the symbols it is defining. Something like:
global_asm!(
    "foo",
    export_symbol "foo",
);


PHP Client for OC

We talked about this on the Gitter channel. I believe we do need a PHP client and am willing to work on it in collaboration with you guys. However the first step would be requirements and interface design (which could be as simple as whatever we have for the node client) .
Lets use this issue to formalize the requirements and start working on it :)

I think this is a great idea. Agree about using the node client's API as a starting point, it should be simple and we should be able to provide parity on the various settings.
Who wants to create a repo somewhere and start sketching out some boilerplate for the PHP library? Want me to?
Let's ensure @gtrias is on the loop as I think he wants to help.

also @gregoryStarr was interested in helping w/ PHP

I would like to help as well :)
I'll try to find a moment to start something functional.

This makes me think about the node oc-client in this same repo. Shouldn't we move it to another different repo? More now that other clients will be created.

@elboletaire definitely we should make the PHP client in a new repo. In fact, I asked if anyone wants to create a repo somewhere to start. If you want, I can create a new one here in the opentable org but is up to you :)
In regards of the node client, yes, we already have an issue to move the browser client to own repo first (as it's a dependency of both core and node client) - then second step will be to move node client to own repo too 👍

Oh I didn't see #438 when writing that down. Good then.

Here is the new WIP repo: https://github.com/opencomponents/oc-client-php
Should I close this now that we have a new place where to discuss this?


Classy Grades View - Horizontal Scroll Bar needed

The grades view in classy needs a horizontal scroll bar.  We had several deliverables set up this term and I can no longer see results from the most recent targets - even on a 27" monitor.

@pcarterubc this is fixed now. The change was tiny, but it was really hard to find the right thing to modify.


        If expected=None, we infer the expected dtype as in_dtype, to test
        out_dtype, e.g.

            >>> x = xp.arange(5, dtype=xp.uint8)
            >>> out = xp.abs(x)
            >>> assert_dtype('abs', x.dtype, out.dtype)

            is equivalent to

            >>> assert out.dtype == xp.uint8

        Or for multiple input dtypes, the expected dtype is inferred from their
        resulting type promotion, e.g.

            >>> x1 = xp.arange(5, dtype=xp.uint8)
            >>> x2 = xp.arange(5, dtype=xp.uint16)
            >>> out = xp.add(x1, x2)
            >>> assert_dtype('add', [x1.dtype, x2.dtype], out.dtype)

            is equivalent to

            >>> assert out.dtype == xp.uint16

        We can also specify the expected dtype ourselves, e.g.

            >>> x = xp.arange(5, dtype=xp.int8)
            >>> out = xp.sum(x)
            >>> default_int = xp.asarray(0).dtype
            >>> assert_dtype('sum', x, out.dtype, default_int)

        """
        in_dtypes = in_dtype if isinstance(in_dtype, Sequence) and not isinstance(in_dtype, str) else [in_dtype]
        f_in_dtypes = dh.fmt_types(tuple(in_dtypes))
        f_out_dtype = dh.dtype_to_name[out_dtype]
        if expected is None:
            expected = dh.result_type(*in_dtypes)
        f_expected = dh.dtype_to_name[expected]
        msg = (
            f"{repr_name}={f_out_dtype}, but should be {f_expected} "
            f"[{func_name}({f_in_dtypes})]"
        )
>       assert out_dtype == expected, msg
E       AssertionError: out.dtype=int64, but should be uint64 [sum(uint8)]
E       Falsifying example: test_sum(
E           x=tensor(0, dtype=torch.uint8), data=data(...),
E       )
E       Draw 1 (kw): {}

array_api_tests/pytest_helpers.py:134: AssertionError

Not sure if this is something we should work around or not. Given that pytorch doesn't have uint64, it cannot return that. However, the spec does say that the return type should be uint64 https://data-apis.org/array-api/latest/API_specification/generated/array_api.sum.html#array_api.sum.  It's possible also the spec should be updated here.
I will say this error makes it a little harder to verify the other sum() behavior (a general problem with the design of the test suite), although I suppose I can just comment out this line.

I will say this error makes it a little harder to verify the other sum() behavior (a general problem with the design of the test suite), although I suppose I can just comment out this line.

Yeah, I suppose this is correct, but I'm happy to skip asserting the output dtype for test_sum and test_prod, if we find the same-kind 32/64 bit dtypes don't exist.


Is it possible to use with older version of Asp.net Indentity versions below 2.0?

I can see that the Asp.net Indentity implementation in this wil have nomalizedemail and normalizedusername etc. I have an existing app and I want to use this package against the existing database. Is it possible to authenticate against the existing users in the database which was created with older version of aspnet identity?

Hello, thanks for your interest in this package :) It depends, what is the type of the Id ? If it's Guid this package uses the non-legacy UUID format which my cause issues if you are using the MongoDB CShard driver with default settings (it's using legacy UUID subtype by default).Also you need to make sure that the document schema is the same as your existing data. Which older version of Identity are we talking about? Le 31 août 2020 07:02, jyothishwhatshalliget<EMAIL_ADDRESS>a écrit :
I can see that the Asp.net Indentity implementation in this wil have nomalizedemail and normalizedusername etc. I have an existing app and I want to use this package against the existing database. Is it possible to authenticate against the existing users in the database which was created with older version of aspnet identity?
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Hi, Im using ObjectId itself. I can provide a sample document object, which was a custom one, Added additional attributes to the identity user. Here is the existing version schema
{"_id":{"$oid":"5b6ac5f720080f04fcd2c9c2"},"userName":"912222222222","securityStamp":"8aa833e7-4b6f-473f-9067-1590250abdd8","email":"test.testuser@gmail.com","emailConfirmed":false,"phoneNumber":"912222222222","phoneNumberConfirmed":false,"twoFactorEnabled":false,"lockoutEndDateUtc":null,"lockoutEnabled":false,"accessFailedCount":0,"roles":["App-User"],"passwordHash":"ANFylvfVA/jAdFbO0lSU4g4zFSyZKmovRnZrbYiCnb3At6AdebSwjZRi/k72Sn4J9A==","logins":[],"claims":[],"verificationCode":"9174","fullName":"Demo2 User2","photoPath":"http://ss.net/Images/Users/5b6ac5f720080f04fcd2c9c2/0aff7ad0-ab8a-434a-b2fe-1d03d9399af5.jpg","gender":77,"password":"","countryID":1,"languageID":1,"Status":"Available","statusText":"Hi There, I am a fan of WhatshalliGet","seeMyProfilePhoto":0,"seeMyPersonalInfo":0,"seeMyStatus":0,"SocialProvider":"facebook","ProviderKey":"23473735800","FeedbackSubmitted":false,"createdOn":{"$date":"0001-01-01T00:00:00.000Z"},"lastModifiedOn":{"$date":"2018-08-12T19:44:39.744Z"},"MemmorableDates":[],"devices":[{"deviceInfoID":{"$oid":"000000000000000000000000"},"deviceID":"d3W0_7z4jjI:APA91bGrp_NWltj1JWy2z-tcrhfedRbGrYOO5uflhY387PvHgzqPm4zinIKjWFkBRTYp-43fEmzm6J3iGZEFbe0u69pW4ffaia5Ciu6F4Xe3dmTX0MelwtIXjoA5u56-tpfuZJ1arSAa","oS":"Android"}],"myList":null,"myMembers":null}

I do not think it's possible, the schema looks quite different. You should probably migrate to a new collection with a different schema.


Don't interrupt an ongoing conversation

bot continues to post in #art
if someone posts in #art, pause for 10 minutes
if 3+ messages between 2+ people occur (including the original post if a user did it), redirect bot art posts to #subreddit until there is silence in #art for 20 minutes

Logic added


Improve soft-dotted-i check: Add affected languages

Description
This pull request addresses the problems described at issue #4085
PR is in draft because waiting for shaperglot dependency to appear on PyPI. (cc @simoncozens)
To Do

[x] update CHANGELOG.md
[ ] wait for all checks to pass
[x] request a review

@felipesanches Checks complain about shaperglot, but I don't understand why. Could you please take a look? I can install it on my computer. It may be because the package on PyPI references a git-hosted package, which pip complains about if you install it with explicit version, but passes without explicit version. All very weird. Simon says he'll push an updated package soon.
The other complaint is from unrelated changes and are present in the current main codebase, please let us merge this anyway. I already made an issue about that and assigned Marc, who made those changes.
But generally, from my side, this is done.

@felipesanches This is ready. Please pay extra attention to the changes in setup.py. There was a merge conflict and this is how I resolved it manually. Maybe you recognize the new setup. Let me know if I shall change anything.
Most tests are passing now, except Python 3.8 with an import error that I don't understand.
I loosened the protobuf dependency because there was a dependency resolution error earlier probably involving shaperglot. If this is a problem we need to look at the dependencies separately to see if we can tighten or loosen their protobuf.
Thank you.

I will only be able to review this later tonight, or tomorrow morning. In the mean time, it would be useful to rebase it all against the main branch, since we had a large commit touching practically all files of the codebase yesterday when we finally adopted the Black code formatter.
If you want to, you can rebase it yourself. Otherwise, I can do it once I'm back here. Just let me know what do you prefer. Also, from now on we'll be using black, so it would be good to run pip install black and black . --extend-exclude=*_pb2.py and commit the changes made by the auto-formatter.

Okay, I committed the blacked changes. Is the rebasing really necessary now when the code of the PR itself is good to go? The branch gets deleted afterwards.
I don't get this one.

This continues at #4208


Volatile functions behave as if they were stable

When running on top of Postgres 12 queries like the below one do not seem to interpret volatile calls correctly:
                WITH MODULE test
                SELECT Obj {
                    # volatile function should be called once for each
                    # Obj, generating different values
                    x := vol_volatile()
                };

Marking test_edgeql_volatility_function_03 as xfail.

This seems to be a Postgres regression:
volatility=# SELECT
   (SELECT random()) AS v1,
   random() AS v2
FROM
   generate_series(1, 2);
         v1         │         v2
────────────────────┼────────────────────
 0.6381342073143692 │ 0.5827781474844613
 0.6381342073143692 │ 0.7479476494195545
(2 rows)

Reported as #16121 upstream

The upstream discussion makes me think that the only way forward is to implement https://github.com/edgedb/edgedb/issues/492 and make it required for volatile functions to use CORRELATED TO when we can't infer the correlation ourselves.

Not really. CORRELATED TO is essentially the explicit variant of the implicit correlation we have in shape computables. Same underlying mechanism.  #844 should fix this.

Also, longer term we may consider wrapping all volatile functions with a wrapper that takes a magic argument with the correlated var.

Also, longer term we may consider wrapping all volatile functions with a wrapper that takes a magic argument with the correlated var.

This is what I meant -- if we do that and compile
WITH MODULE test
                SELECT Obj {
                    # volatile function should be called once for each
                    # Obj, generating different values
                    x := vol_volatile()
                };

into
.... SELECT vol_volatile(Obj.id) ....

then it would be a more robust solution.  Otherwise is it guaranteed that Postgres' optimizer isn't smart enough one day to optimize away the hacks of #844?

Otherwise is it guaranteed that Postgres' optimizer isn't smart enough one day to optimize away the hacks of #844

Well, if they optimize away an explicit WHERE clause, then I don't even know how the documentation stating "A query using a volatile function will re-evaluate the function at every row where its value is needed." is not a lie anymore.  Anyway, the wrapper function is orthogonal to an explicit CORRELATED modifier.  I'll open an issue so we don't forget to revisit this.


Bug / Feature Request: Support for multiline errors

Some compilers e.g. F# commonly use multiline errors. I've tried using the removeLinebreaks setting but this does not help e.g.
This is the "full" error shown in the pop-up or error pane:

But the error lens shows just the first line:

If the extension simply discarded new lines and put the entire message on a single line, might that be a reasonable solution?

If the extension simply discarded new lines and put the entire message on a single line, might that be a reasonable solution?

"errorLens.removeLinebreaks": true, - should do that - replace line breaks with whitespace and show it in one line.
Is message not showing because the editor run out of space or because the message is cut off before that?

VSCode doesn't have api to show multi-line decorations.
If code inset (webview inside editor) was implemented it would be possible https://github.com/microsoft/vscode/issues/85682

@usernamehw Hi. As you can see from the screenshot above, unfortunately the removeLineBreaks option doesn't appear to help. There are some other errors I've seen that are all single lined and quite long, and this extension does indeed correctly show the entire message. It's just multiline errors that don't show on the single line, even with remove line breaks on.

Maybe tabs symbol or carriage return. Can you try to install this version with modified regexp?

Rename .zip to .vsix
Install vsix

errorlens-3.2.7.zip
Or I can write how to modify installed extension:

Execute from Command Palette Extensions: Open Extensions Folder
Open extension file usernamehw.errorlens-3.2.7\dist\extension.js
Replace regexp /\n/g with /[\n\r\t]+?/g
Reload the editor (maybe twice)

I assume it worked.


Rework MediaUploader Class

This PR will address the issues described in #6

Will merge into v2 branch before master


Client-side validation of the service-account list command output

Feature or problem description
The ListServiceAccounts endpoint does not offer pagination parameters so we are listing all data. It is likely that there would be multiple service accounts allowed per user, potentially leading to 100s or 1000s of items being printed. We need to offer pagination to make this list more easily read.
Proposed solution
Add a limit and offset flag and do the pagination from the CLI.

To be clear. Proposal is to perform client side pagination or use backend - file new request (that should not be issue)?

There were some technical reasons for not being able to do this on the backend, it was there but removed because it did not work correctly. @akoserwal do you know if this is possible yet?

Raised issue with Keycloak team: https://issues.redhat.com/browse/KEYCLOAK-17822

Thanks for confirming this is still not technically possible. In that case I think we should do client-side pagination on this in the meantime.

Update. This is unlikely to be addressed in any time period due to backend not supporting it.

We need to push for better architecture on control plane to fix it


Use onUnexpectedExternalError for errors running completion items commands

Fixes #175504

I believe a better place is where we actually invoke extension commands, e.g here. Theoretically, completion providers from the renderer itself (debug, words etc) can have commands and those (or its errors) shouldn't be marked as external

@jrieken Thanks. Are the case where we don't want to swallow exceptions that external commands throw?

No, but there can be cases where a completion command isn't external


Refresh docs for v0.2.0 release

Add separate sections about Ignition, Cloud-init, Profiles, and Signing.

Resolved by ed584de9cc7


Intelligent interactive segmentation labelling through deep learning models

Is your feature request related to a problem? Please describe.
Semantic segmentation labelling takes a long time to individually paint all the pixels of all the different classes using a simple brush painter. If we could incorporate interactive intelligent labelling functionality, that would be awesome.
Describe the solution you'd like
Either a implemented interactive segmentation option, or the availability of a pipeline for users to be able to implement their own.

This would involve, for each class, an option to "paint" a portion of the scene as a positive or negative label wrt a single class.
Once selected, the backend would take the image and the user input, generate pixel predictions and return back the mask result.

The support for this feature is realized in LS 1.3 and the latest ML backend.


SRS

srs_wc.docx

please assign @hadarp (if needed, remind her by mail or chat to accept your
invitation - it's a new secure thing)
On Fri, Nov 25, 2016 at 12:41 PM, shoamco<EMAIL_ADDRESS>wrote:

Assigned #1 https://github.com/shoamco/Smart-School-reshit/issues/1 to
@robi-y https://github.com/robi-y.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shoamco/Smart-School-reshit/issues/1#event-871917956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9nV3zZDZTzjT3-aOBBOnR0GAjp9y1Qks5rBrtPgaJpZM4K7yN4
.


Fix model loading in datum explain

Summary

Resolve #721
Fix model loading in datum explain
Add an integration test for datum explain

How to test
This change will be covered in the added test.
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Base: 83.93% // Head: 84.29% // Increases project coverage by +0.36% :tada:

Coverage data is based on head (c4e6b3d) compared to base (3aa4742).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #804      +/-   ##
===========================================
+ Coverage    83.93%   84.29%   +0.36%
===========================================
  Files          174      174
  Lines        22941    22928      -13
  Branches      4973     4773     -200
===========================================
+ Hits         19255    19327      +72
+ Misses        2559     2452     -107
- Partials      1127     1149      +22

Flag
Coverage Δ

macos-11_Python-3.10
?

macos-11_Python-3.7
?

macos-11_Python-3.8
?

macos-11_Python-3.9
?

ubuntu-20.04_Python-3.10
?

ubuntu-20.04_Python-3.7
?

ubuntu-20.04_Python-3.8
?

ubuntu-20.04_Python-3.9
84.29% <33.33%> (+0.48%)
:arrow_up:

windows-2019_Python-3.10
?

windows-2019_Python-3.7
?

windows-2019_Python-3.8
?

windows-2019_Python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

datumaro/cli/commands/explain.py
55.43% <33.33%> (+19.87%)
:arrow_up:

datumaro/util/os_util.py
68.70% <0.00%> (-8.58%)
:arrow_down:

datumaro/plugins/data_formats/yolo/exporter.py
84.07% <0.00%> (-1.77%)
:arrow_down:

datumaro/plugins/synthetic_data/utils.py
83.33% <0.00%> (-1.67%)
:arrow_down:

datumaro/util/test_utils.py
88.35% <0.00%> (-1.59%)
:arrow_down:

datumaro/plugins/data_formats/kitti_raw/base.py
85.00% <0.00%> (-1.12%)
:arrow_down:

datumaro/plugins/data_formats/voc/exporter.py
89.48% <0.00%> (-0.58%)
:arrow_down:

datumaro/plugins/data_formats/coco/exporter.py
89.07% <0.00%> (-0.43%)
:arrow_down:

datumaro/components/operations.py
84.24% <0.00%> (-0.18%)
:arrow_down:

datumaro/components/errors.py
87.62% <0.00%> (-0.16%)
:arrow_down:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


matrix should read value

https://github.com/robofab-developers/fontParts/blob/c3a1992ce7951b89ee660890e78f27087724e97e/Lib/fontParts/base/glyph.py#L1415
Tests probably should have caught this.

The tests don't cover that yet. I happen to know because I've been working on glyph tests. I expect to have a PR this week, unless refactoring or some other conflicting change happens. Fingers crossed 🤞

@miguelsousa I have some more changes I want to make to the current tests (code style and breaking apart the selected tests) but I'll wait until you PR so I don't drive you insane with refactoring

@benkiel go ahead. I haven't yet adapted what I had written to the new formatting, so it's best for you to finish. I'll then make the changes according to that.

@miguelsousa I just pushed those cleanups to tests. Won't touch now.

Fixed in https://github.com/robofab-developers/fontParts/commit/0e8b0a7a3a6b49c6190771fad24209ee38620439


Fix for #269

I think the failure is intermittent due to tests running in parallel. Cannot reproduce locally


Bivector and Rotor

Fixes #32
There is a few issues I'd like us to resolve before we settle on something:

dimensionality: does it make sense to have Bivector3 instead of Bivector here, and similarly for Rotor?

there is hardly any use for other dimensions, hence I think we can avoid the number suffixes

notation: is xy/xz/yz the only used notation for bi-vectors? How should rotor fields be called? The current "s" and "b" are just random, basically.
consistency with quaternions: does anything need to be done about the fact that the vector part of a quaternion has the type of Vector3? It isn't really a vector, much closer to bi-vector, in which case people just need to use Rotor anyway. Perhaps, the Quaternion type shouldn't be written in the vector form at all to avoid confusion.

r? @nical @Ralith

does it make sense to have Bivector3 instead of Bivector here, and similarly for Rotor?

There's definitely a case for a Rotor2: 2D rotations that have singular representations and well-defined precision are nice. nalgebra already has the very similar UnitComplex type for this exact reason.
I'm less sure of the usefulness of a Bivector2. If mint might ever support dimensionalities > 3, consistency wouldn't hurt.

consistency with quaternions

I'm not sure what "much closer to" means. It does seem like it might have been best to define quaternions with s/i/j/k members. Not sure that's worth breaking compatibility.

Can we put the scalar at the end of Rotor to match the updated Quaternion
Related: https://github.com/kvark/mint/pull/50


"Next" button link is returning 404

When clicking on the "Next" button, which points to the "https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/architect-microservice-container-applications/docker-application-development-process" URL, a 404 page is returned.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4718315e-ee77-0d95-c46d-4eaada53f924
Version Independent ID: 4e7f1467-9834-303c-135f-4c9ff39374f2
Content: Orchestrating microservices and multi-container applications for high scalability and availability
Content Source: docs/standard/microservices-architecture/architect-microservice-container-applications/scalable-available-multi-container-microservice-applications.md
Product: dotnet
Technology: dotnet-ebooks
GitHub Login: @nishanil
Microsoft Alias: nanil

Thank you for reporting this issue, @luisdeol. It was fixed by dotnet/docs#12683. Closing.


should thoroughly test non-relative imports

I found few issues with resolving relative paths of external modules.

1.0.5


Reachability metadata repository support?

The graalvm native image maven plugin has supported their reachability metadata repository since version 0.9.12:
https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#metadata-support
Does the gluonfx maven plugin support this? Or is there a way to configure the plugins to work together? This could greatly simplify configuration when using any of the supported libraries.

You can use the native:write-args-file goal of the native-build-tools, mentioned here: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#long_classpath_and_shading_support
After that you can pass in the args file as native image argument to the gluonfx-maven-plugin. I have not tested it but that should work just fine.


Namespace the preference pane identifier

Protocols cannot have a tested types, which is why we currently have PreferencePaneIdentifier, but I just realized we can use typealias to achieve PreferencesPane.Identifier. As a bonus it's not shorter to define the identifiers too.
// @DivineDominion

This is clever, I like it :)


3D Multiresolution Image Error under Certain Axis Order

🐛 Bug

To Reproduce
Steps to reproduce the behavior:
I am trying to work with multiscale 3D images and found an unexpected issue when I am working with "toy" data of arrays of all ones. It seems like only certain axis orders execute without error.
import napari
import numpy as np

The following code gives me an OpenGL error (error trace further below):

ims = [np.ones((int(100/2**i),int(100/2**i), 1)) for i in range(2)]
order = (2,0,1)
napari.view_image(ims, multiscale=True, order=order)

This error is unexpected because the following two code blocks both work:

Different axis order:

order = (0,1,2)
ims = [np.ones((int(100/2**i),int(100/2**i), 1)) for i in range(2)]
napari.view_image(ims, multiscale=True)

2D version:

ims = [np.ones((int(100/2**i),int(100/2**i))) for i in range(2)]
napari.view_image(ims, multiscale=True)

The error I get from code block 1 is:
WARNING: Error drawing visual <Image at 0x176966c10>
Traceback (most recent call last):
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/app/backends/_qt.py", line 903, in paintGL
    self._vispy_canvas.events.draw(region=None)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/util/event.py", line 453, in __call__
    self._invoke_callback(cb, event)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/util/event.py", line 471, in _invoke_callback
    _handle_exception(self.ignore_callback_errors,
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/util/event.py", line 469, in _invoke_callback
    cb(event)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/scene/canvas.py", line 218, in on_draw
    self._draw_scene()
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/scene/canvas.py", line 277, in _draw_scene
    self.draw_visual(self.scene)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/scene/canvas.py", line 315, in draw_visual
    node.draw()
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/scene/visuals.py", line 103, in draw
    self._visual_superclass.draw(self)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/visuals/visual.py", line 451, in draw
    self._program.draw(self._vshare.draw_mode,
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/visuals/shaders/program.py", line 102, in draw
    Program.draw(self, *args, **kwargs)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/program.py", line 526, in draw
    canvas.context.flush_commands()
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/context.py", line 172, in flush_commands
    self.glir.flush(self.shared.parser)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/glir.py", line 582, in flush
    self._shared.flush(parser)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/glir.py", line 504, in flush
    parser.parse(self._filter(self.clear(), parser))
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/glir.py", line 822, in parse
    self._parse(command)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/glir.py", line 784, in _parse
    ob.draw(*args)
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/glir.py", line 1321, in draw
    gl.check_error('Check before draw')
  File "/Users/thomasathey/Documents/mimlab/mouselight/docs_env/lib/python3.8/site-packages/vispy/gloo/gl/__init__.py", line 204, in check_error
    raise err
RuntimeError: OpenGL got errors (Check before draw): GL_INVALID_OPERATION

Expected behavior
I did not expect this error because napari successfully loads the same data when the axes are in a different order or when these toy images are "squeezed" into 2D.
Environment

Please copy and paste the information at napari info option in help menubar here:

napari: 0.4.16
Platform: macOS-10.16-x86_64-i386-64bit
System: MacOS 12.5.1
Python: 3.8.10 (default, May 4 2021, 03:05:50) [Clang 12.0.0 (clang-1<IP_ADDRESS>)]
Qt: 5.15.2
PyQt5: 5.15.4
NumPy: 1.23.2
SciPy: 1.9.1
Dask: 2021.06.2
VisPy: 0.10.0

OpenGL:
- GL version: 2.1 ATI-4.8.101
- MAX_TEXTURE_SIZE: 16384

Screens:
- screen 1: resolution 1680x1050, scale 2.0
- screen 2: resolution 2560x1440, scale 2.0

Plugins:
- animation: 0.0.2
- brainlit: 0.3.3
- cellfinder: 0.0.18
- console: 0.0.4
- napari-bil-data-viewer: 0.1.2
- napari-ome-zarr: 0.5.2
- napari-roi: 0.1.7
- ndtiffs: 0.1.2
- scikit-image: 0.4.16
- svg: 0.1.5

Any other relevant information:

I got the same error on a computer with Ubuntu 18.04, and can provide more info about the napari environment on that computer if needed.
Additional context
It seems like an OpenGL issue, but not sure if there is something I can do on the napari side to fix this.
Thanks for any help!

@brisvag : I'm taking a look at this now since it's related to an issue found in #5816

I can reproduce with v0.4.17, but not on main (at 0dfb37b474490b4d9829c4fa93cb3d648b4b186d). Seems like https://github.com/napari/napari/pull/5003 fixed this, but I can't explain why yet - will look for an explanation before closing this issue and see if there's any other way to reproduce similar issues that might need more general fixes.
@tathey1 : unfortunately, we haven't had a release since v0.4.17 so the fix isn't available in a stable form yet. If you're comfortable using main and also find this is no longer as issue, please report. Otherwise, I'll try to update this when a fix is a ready in a release.

I'm on macOS arm64 and likewise cannot reproduce, so it does appear fixed on main.
BTW If this is key to your work and you are using conda, you can try the conda nightly build using conda-forge (I recommend mamba):
conda create -n napari-main -c "napari/label/nightly" -c conda-forge napari python=3.10

Thank you! I have been able to bypass this issue so it is not really urgent for me, but I really appreciate your solution.

I can't reproduce this on release 0.4.18, so going to close.
If it re-occurs, please let us know!


[C#] Generate DTOs for non-perf-sensitive usecases.

In some applications, performance is not critical. Some users would like to use SBE across their whole "estate" but don't want the "sharp edges" associated with flyweight codecs, e.g., usage not aligning with data lifetimes.
In this commit, I've added a first cut of DTO generation for C# and a simple test based on the Car Example. More tests to come.
The DTOs support encoding and decoding via the generated codecs using EncodeInto(CodecT codec) and DecodeFrom(CodecT codec) methods.
Here are some points that we may or may not wish to change in the future:

Non-present (due to the encoded version) string/array data and repeating groups are represented as null rather than empty.
Non-present primitive values are represented as their associated null value rather than using nullable types.
Non-present bitsets are represented as 0.
DTOs are generated via a separate CodeGenerator rather than a flag to the existing C# CodeGenerator.

There is no support for equality/comparison or read-only views over the data.

Feedback to consider:

Use records (C# 9+ only) for built-in equality and comparison operations.
Be more idiomatic, e.g., int? rather than int and NullValue, but protect against having two null values in the setters.

@kieranelby, please can someone kick the tyres on your side and let me know if you'd prefer different representations?

@ZachBray Thanks for this awesome job.
I noted, that the generated DTOs are missing some imports, if package names are overriden  in the types tag  (as implemented in https://github.com/real-logic/simple-binary-encoding/issues/507).
Consider the following setup:
<sbe:messageSchema xmlns:sbe="http://fixprotocol.io/2016/sbe"
  xmlns:xi="http://www.w3.org/2001/XInclude"
  package="messages.sbe">
  <xi:include href="sbe-common-types.xml"/>

and inside sbe-common-types.xml, we have:
<types package="messages.sbe.common">

In this case the DTOs will miss all the type imports from sbe-common-types, unfortunately.

Thanks for the report, @ratcashdev. I think this may have recently been fixed. Have you tried 1.33.2?

@ZachBray Looks like the fix in https://github.com/real-logic/simple-binary-encoding/pull/1022 was only targeting Java DTOs thought. So the issue still exists for C# and C++ DTOs.

I confirm, 1.33.2 solves this for JAVA at least.

@ratcashdev You've added support for package overrides for Java in https://github.com/real-logic/simple-binary-encoding/pull/904. It looks like C# and C++ do not have support for this feature yet. That support needs to be added and then DTO generation could be adjusted as well.


value is null, but 'value == null' is false

Map e = ...;
for (var item in e) {
    print(item['displayLogId']); // null
    bool ifNull = item['displayLogId'] == null;
    print(ifNull); / false
}

i print item['displayLogId'] which is null, but for item['displayLogId'] == null, it is false. Is it right, or there is a better method to use?

Hello @cuifengcn,
I'm Michael and I'm interested in contributing to this project!
To answer this question, I have had a similar issue with Map and a trick was to use containsKey. See here for reference.
A correction to your code will be like:
bool containsKey = item.containsKey('displayLogId'); // check if the key 'displayLogId' exists
bool isNull = containsKey && item['displayLogId'] == null; // you can now check if the value for `displayLogId` is `null`
print(isNull);

Let me know if you have any questions about this solution.


SCM Viewlet hides "Source Control Providers" panel with only one folder in workspace

VSCode Version: Code - Insiders 1.17.0-insider (f7962f0682a76516df51de4856f8ccc5d8ad578a, 2017-09-20T05:10:59.524Z)
OS Version: Darwin x64 16.7.0
Extensions: none

Steps to Reproduce:

Have only one git repo / folder in your workspace
Open the SCM Viewlet, notice that the Source Control Provider's panel isn't visible
Add another folder to the workspace
Notice that they Source Control Provider's panel is now visible, and lists two providers

Is this intended behavior? I find it confusing to have the panel be hidden like that when I am working with a single repository - I expect the UI to be consistent.

I created a PR for this here: https://github.com/Microsoft/vscode/issues/35279. If this intended behavior, feel free to close it.

It is intended behaviour, we're trying to save space and keep the UI minimal. Thanks for the PR tho.


querier --selector-label not working when query without label

for example if I run querier with --selector-label=namespace="ns1"
I query with kube_namespace_labels{namespace="xxx"} , the querier --selector-label is working as expect, only return result when namespace matches "ns1"
but if I query with kube_namespace_labels only, without specifying any labels to match in the query, then querier will return all records if can find for kube_namespace_labels

What is the behavior you would expect?


WIP: Add a version field to the API section

Break everything. Needs some checking somewhere.

Yeah I can't quite envision how this should be checked.
I guess it would have to be load-time- since it would have to trap:

Games being loaded from ext flash that are incompatible with a newly updated firmware
Games being loaded from SD that are incompatible

I think if we append-only the API we can gently skirt around issues and avoid needing to to this.

I was thinking maybe an init check somewhere for the version being too low. Still only handles append-only, but at least a game can abort early instead of randomly crashing later. Could even be a major/minor thing and abort on major mismatch...
(Sorry, intended to expand the description.)

So, that approach was okay then? (Forgot again to comment after updating...)

It seems sensible enough- we can expand it by barfing up a human-readable error but that's not super important.
I did wonder about something like errno so launching a game can fail in one of many ways which can then be communicated...  but then I couldn't think of any other error cases that shouldn't just be handled by the game itself (missing assets for example)


Not sure how to run tests

Maybe its because i'm a bit new to django, but i'm not sure how to run the tests with this project.  When i try python run_tests.py i get this warning:
(sandbox)➜  django-ajax-uploader git:(master) python run_tests.py
Traceback (most recent call last):
  File "run_tests.py", line 36, in <module>
    main()
  File "run_tests.py", line 32, in main
    call_command('test', 'ajaxuploader')
  File "/home/derek/Dev/.tools/virtualenv/python/sandbox/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 93, in call_command
    app_name = get_commands()[name]
  File "/home/derek/Dev/.tools/virtualenv/python/sandbox/local/lib/python2.7/site-packages/django/utils/lru_cache.py", line 101, in wrapper
    result = user_function(*args, **kwds)
  File "/home/derek/Dev/.tools/virtualenv/python/sandbox/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 73, in get_commands
    for app_config in reversed(list(apps.get_app_configs())):
  File "/home/derek/Dev/.tools/virtualenv/python/sandbox/local/lib/python2.7/site-packages/django/apps/registry.py", line 137, in get_app_configs
    self.check_apps_ready()
  File "/home/derek/Dev/.tools/virtualenv/python/sandbox/local/lib/python2.7/site-packages/django/apps/registry.py", line 124, in check_apps_ready
    raise AppRegistryNotReady("Apps aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.

Django is typically manage.py test
https://docs.djangoproject.com/en/1.7/topics/testing/overview/
Ping if you're running into a bug with ajax-uploader!

Thanks still figuring out django.


js8sb:cuisine redis doesnt run , where did the config file go

reproduce : j.tools.cuisine.local.apps.redis.build()
it cannot find the config file,
task : find history what broke it and fix it
ERROR
remote:/opt/jumpscale8/bin# /opt/jumpscale8//bin/redis-server /optvar/redis/main/redis.conf 7295:C 20 Jun 09:42:00.509 # Fatal error, can't open config file '/optvar/redis/main/redis.conf'

https://github.com/Jumpscale/jumpscale_core8/pull/323


feat(checkboxes): Added checkbox support for Markdown.

Adds checkbox support for Markdown.

@michaelkleinhenz does your new PR address the issue that @dlabrecq raised?

@joshuawilson @dlabrecq yes and no. The wrapping in SafeValue is now happening outside of ngx-widgets in the enclosing component (namely the Planner detail view). ngx-widgets now only just supports incoming SafeValue content. All sanitizer handling has been removed from ngx-widgets.
Although the problem still persists, because we still need to use SafeValue in Planner to wrap the rendered markdown. The Angular sanitizer can not be configured on a fine granular (element) basis (like the golang sanitizer can). So we either need to disable HTML sanitizing entirely for that value or we can not support any feature that needs input elements in the HTML. Note that the HTML sanitizing can be individually turned off, JavaScript and URLs are still stripped from the HTML.
Although this is still not ideal, the impact there is low. We're only turning off HTML sanitizing, other active components are still stripped. The HTML comes from a trusted source and is not directly user-editable but is always generated from Markdown. Also, the generated HTML is sanitized on the server side as well in a much more restricted way (only allowing  elements in addition to the standard set of allowed elements).

I confirmed the github-link-area component is still bypassing HTML, while the markdown example is bypassing HTML, styles, JavaScript, URLs, etc.
Is the intention to simply move the bypass code (in the example) to Planner?
./app/github-link-area/github-link-area.component.ts:      return this.sanitizer.bypassSecurityTrustHtml(input);
./app/markdown/examples/markdown-example.component.ts:      case 'html': return this.sanitizer.bypassSecurityTrustHtml(value);
./app/markdown/examples/markdown-example.component.ts:      case 'style': return this.sanitizer.bypassSecurityTrustStyle(value);
./app/markdown/examples/markdown-example.component.ts:      case 'script': return this.sanitizer.bypassSecurityTrustScript(value);
./app/markdown/examples/markdown-example.component.ts:      case 'url': return this.sanitizer.bypassSecurityTrustUrl(value);
./app/markdown/examples/markdown-example.component.ts:      case 'resourceUrl': return this.sanitizer.bypassSecurityTrustResourceUrl(value);
./app/markdown/examples/markdown-example.component.ts:      callBack(rawText, this.sanitizer.bypassSecurityTrustHtml(text));
./app/markdown/markdown.component.spec.ts:          comp.inpRenderedText = domSanitizer.bypassSecurityTrustHtml(originalHTML);

Yes. As long as the JavaScript and URLs are still stripped from the HTML, I'm fine with the markup being sanitized server-side.


fix: Remove Gradle configureondemand

This is Option 1 to fix https://github.com/googlemaps/android-maps-utils/issues/800 as mentioned in https://github.com/googlemaps/android-maps-utils/issues/800#issuecomment-732239657.
Option 2 is presented in PR https://github.com/googlemaps/android-maps-utils/pull/894.
@arriolac What are your thoughts on this vs. Option 2?
This is certainly a simpler fix that keeps the old configuration, but the potential downside is reduced performance. I don't know what the real-world impact on this project is.
Only one of these two PRs should be merged.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open a GitHub issue as a bug/feature request before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)
[x] Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/

Fixes #800 🦕

Perhaps it might be good to run the following and compare execution speeds ./gradlew library:assembleDebug? Given that this project is fairly small already I imagine the deltas would be small.

I ran ./gradlew clean, then closed the terminal, re-opened it, and ran ./gradlew library:assembleDebug three times for each configuration.
You're right, the difference in build time looks negligible:

Before (s)
After (s)

5
7

6
6

5
6

@arriolac This is ready for review when you have a chance


install document

install document for who not use docker, or run it on windows locally.

Thanks a lot for your contribution, that is indeed helpful.
One suggestion, I would put a small text on top of the document to make it clear for readers that this document covers the manual installation (without docker). what do you think?


Fix Set-DnsServerResourceRecord help for PS 7

The Clone() method for CimInstances doesn't exist in PS7, so the example throws an error. Suggesting an alternative that works (at least) in both PS5 and PS7.
Source and credit: http://jon.netdork.net/2015/10/23/set-dnsserverresourcerecord-and-oldinputobject-not-found/

Done, thanks.

@tiburd Ready to merge. Thanks.

Docs Build status updates of commit 57ae056:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2019-ps/dnsserver/Set-DnsServerResourceRecord.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Initialize PCU tracker

The PCU tracker was added and setup to track the provider's PCU, but it
was not initialized during reconciler creation.
Fixes #7
Signed-off-by: hasheddan<EMAIL_ADDRESS>

Going to move ahead with merge here as it is a small change and is needed to fix panic described in linked issue.

Thank you @hasheddan, I will give it a try.


Add optional country parameter

mychevy 1.2.0 provides the ability to work in canada as well as the us
(there are different service urls for each region). This creates a new
config option to enable it.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

Could not find a matching documentation PR in our documentation repository. Adding docs-missing label.

Docs are now added


Add query options from json to existing query options, instead of overriding

Query options can be set in 2 ways

Json payload with key "queryOptions"
Using  option("key"="value") at the end of the query.

If both are provided, we need to create a union of the options. We had a bug where the options from 1 would override 2 if both were provided.

Codecov Report

Merging #4786 into master will decrease coverage by 0.28%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #4786      +/-   ##
==========================================
- Coverage   38.13%   37.84%   -0.29%
==========================================
  Files        1209     1211       +2
  Lines       64974    65578     +604
  Branches     9465     9560      +95
==========================================
+ Hits        24776    24821      +45
- Misses      37930    38484     +554
- Partials     2268     2273       +5

Impacted Files
Coverage Δ

...roker/requesthandler/BaseBrokerRequestHandler.java
75.56% <50%> (+0.17%)
:arrow_up:

...e/pinot/core/io/writer/impl/MmapMemoryManager.java
0% <0%> (-72.31%)
:arrow_down:

...he/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
:arrow_down:

...a/manager/realtime/RealtimeSegmentDataManager.java
50% <0%> (-25%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
54.87% <0%> (-13.42%)
:arrow_down:

...core/startree/v2/store/StarTreeIndexContainer.java
68% <0%> (-8%)
:arrow_down:

.../predicate/NotEqualsPredicateEvaluatorFactory.java
49.25% <0%> (-7.47%)
:arrow_down:

...rEqualitiesToInClauseFilterQueryTreeOptimizer.java
73.33% <0%> (-6.67%)
:arrow_down:

.../controller/helix/core/SegmentDeletionManager.java
54.91% <0%> (-5.74%)
:arrow_down:

...pinot/server/realtime/ControllerLeaderLocator.java
67.77% <0%> (-5.56%)
:arrow_down:

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0614310...ca9ebdd. Read the comment docs.

Do we have a test case already?

Couldn't find any tests. Added.


js framework benchmark - Huge performance drop after upgrading mobx and mobx-react to latest version

After upgrading react, mobx and mobx-react to latest version in https://github.com/krausest/js-framework-benchmark/tree/master/frameworks/keyed/react-mobX I found huge performance drop in the benchmark. The example is really simple but I don't know what is the problem.

How to reproduce the issue
Upgrade react, mobx and mobx-react to the latest version and run the benchmark.

Versions
  "dependencies": {
    "mobx": "5.15.4",
    "mobx-react": "6.2.2",
    "react": "16.13.1",
    "react-dom": "16.13.1"
  }

Shit, yes forget about this.
@FredyC I think we still need to revert the batching-opt-in change? We really can't do that in a minor update, it hurts serious applications really bad and probably no test will detect it.

@darkowic So you haven't noticed that "friendly" warning what you need to do?

Yeah, I didn't notice any warning

And can you please confirm that after following these instructions the performance is back on track?

I just checked it. Adding require('mobx-react/batchingForReactDom'); didn't solve it.
[Violation] 'click' handler took 34428ms - creating 10k rows...
You have to take a look at this benchmark I guess.

Just tried to narrow this done, it seems that the react update itself causes the difference. As soon as I upgrade to react 6.13.1, the perf drops from 3 to 40 secs, with the same mobx / mobx-react version. Does this ring a bell to anyone?

Yeah, it's super sad! Glad someone else found that out before, would never have figured that out myself.


[firebase_auth_web]: Google Sign In Fails on Web

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Auth
Which platforms are affected?
Web
Description
After issues with the new google sign in I now want to use signInWithPopup from FirebaseAuth. As stated with in the docu this seems pretty straight forward.
My prev code looked like this:
@override
  Future<Either<String, auth.User>> signInWithGoogle() async {
    try {
      final GoogleSignInAccount? googleUser = await GoogleSignIn().signIn();

      final GoogleSignInAuthentication? googleAuth =
          await googleUser?.authentication;

      final credential = GoogleAuthProvider.credential(
        accessToken: googleAuth?.accessToken,
        idToken: googleAuth?.idToken,
      );

      final result =
          await FirebaseAuth.instance.signInWithCredential(credential);

      final newUser = result.user;

      if (newUser == null) {
        throw Error();
      } else {
        return right(newUser);
      }
    } catch (e) {
      print("Error");
      print(e);
      return left(WebserviceErrorHandler.handleError(e));
    }
  }

And now I have the replaced it with the following, because the old one failed with the new versions:
@override
  Future<Either<String, auth.User>> signInWithGoogle() async {
    try {
      GoogleAuthProvider googleProvider = GoogleAuthProvider();

      googleProvider.addScope('email');
      googleProvider.addScope('profile');

      final result =
          await FirebaseAuth.instance.signInWithPopup(googleProvider);

      final newUser = result.user;

      if (newUser == null) {
        throw Error();
      } else {
        return right(newUser);
      }
    } catch (e) {
      print("Error");
      print(e);
      return left(WebserviceErrorHandler.handleError(e));
    }
  }

But now I am getting the error: The popup has been closed by the user before finalizing the operation. Is there any workaround to do so?
Reproducing the issue

Trigger the signInWithPopup
Login with a google account
See the error in the browser console

Firebase Core version
3.4.0
Flutter Version
3.24.0
Relevant Log Output
[firebase_auth/popup-closed-by-user] The popup has been closed by the user before finalizing the operation.

 Thanks for reporting. I'm unable to reproduce this issue. Which browser did you experience this on?

Tried Chrome Desktop and Mobile and Safari. All on Apple devices.

Could it be that this has something to do with a wrong redirect URL? My host app uses a Firebase URL, but without the 'firebaseapp' ending. However, on the Google auth screen, it says that it will redirect to a URL with 'firebaseapp'. You can also check the screenshot for better understanding.

I'm not quite sure. Can you provide a full sample code reproducing this issue?

I've found the issue. Because I was migrating to WASM on another target in my code I needed to add the following to my firebase.json:
"headers": [
      {
        "source": "**",
        "headers": [
          {
            "key": "Cross-Origin-Embedder-Policy",
            "value": "require-corp"
          },
          {
            "key": "Cross-Origin-Opener-Policy",
            "value": "same-origin"
          }
        ]
      }
    ]

This leaded to the error for builds that don't use WASM. I will now differentiate between different targets and which firebase.json to use.

Great


Issues with variable resolution in user defined functions

There would appear to be an issue with how the caret operator, which in this context ought to be treated as the exponentiation operator, resolves variables.
This is a minimal working example of the issue seen in f(x) = x^x, where the resulting error is Undefined variable: 'x'. when calling the function with f(1).
The issue would appear to be in how the exponent is evaluated, since f(x, y) = x^y when called with say f(2, 2), results in Undefined variable: 'y'..
I have yet to delve deep into the code to determine the cause of the issue since I was using Kalker to complete some math homework, however, when I'm not busy I will try to figure out the problem on my own time.

Should now be fixed. Turns out it perform analysis on the right hand side of power expressions, which is when it's connected to it's parent function.


Could not find the following rules specified in the configuration: no-trailing-comma

I just pulled the latest version of tslint and gulp-tslint and I'm suddenly facing the following error:
[proj-path]/node_modules/tslint/lib/ruleLoader.js:29
        throw new Error(errorMessage);
        ^

Error: Could not find the following rules specified in the configuration:
no-trailing-comma
    at Object.loadRules ([proj-path]/node_modules/tslint/lib/ruleLoader.js:29:15)
    at Linter.lint ([proj-path]/node_modules/tslint/lib/tslint.js:24:44)
    at [proj-path]/node_modules/gulp-tslint/index.js:96:34
    at respond ([proj-path]/node_modules/gulp-tslint/node_modules/rcloader/index.js:73:7)
    at respond ([proj-path]/node_modules/rcfinder/index.js:140:7)
    at [proj-path]/node_modules/rcfinder/index.js:124:17
    at [proj-path]/node_modules/rcfinder/index.js:77:13
    at nextTickCallbackWith0Args (node.js:453:9)
    at process._tickCallback (node.js:382:13)

Any ideas? Could this be a gulp-tslint issue?

Nevermind. Just found the changelog:
no-trailing-comma rule removed, it is replaced by the trailing-comma rule (#687)


Rethink documentation for fitness functions

Its not essential that init and call are documented, It might be better to just have examples instead

Ive changed most of the fitness functions from classes to closures, so this change has been made as of 2d877729d95ca0855930d9d4c30a6ef97dba7397


Notification Module

This module will allow developers to integrate notifications with their functionality. Here are some wikis on which you can read more about this module.

Notification Module Design
Notification API Developer User Guide
Configure Notifications-End User guide

@ad-os Changes looks ok. Can you resent PR with single commit please.

@ad-os as discussed over slack, You have added a library which is having dependency on BSD licensed third party library. Can you check the current binary licensing please.

@ad-os  Please refer LICENSE_RELEASE file. You need to add an entry about this BSD library.


Fix for CONNECTORS-1189

Can you please close this pull request since CONNECTORS-1189 is resolved?


Create OpenShift Notes

Created a page that explains what OpenShift is and how it can be helpful. Additionally, demonstrated how to deploy application on openshift.

There is a conflict with Topics/Tech_Stacks.md. Otherwise, it is good to merge.


Doesn't work with ReHLDS

L 10/10/2018 - 09:03:00: [AMXX] Module "cstrike/addons/amxmodx/modules/curl_amxx_i386.so" failed to load (cstrike/addons/amxmodx/modules/curl_amxx_i386.so: undefined symbol: MD5_Init)
L 10/10/2018 - 09:03:00: Error:
L 10/10/2018 - 09:03:00: [AMXX] Module is not a valid library (file "cstrike/addons/amxmodx/modules/curl_amxx_i386.so")

Doesn't work with ReHLDS

Both installed, this error only happens when i install ReHLDS

Seems i forget set some link options. What os version you use?

Ubuntu 18.04

In case it's any help, I had the same error on CentOS 7, but only when using it with the ReHLDS version of hlds_linux. @hernandezk0 You could try using the original hlds_linux with the rest of files from ReHLDS, that should "fix" it for now.
On CentOS 6 I also had "undefined symbol: clock_gettime" with the latest glibc (2.12) available from the official repositories. Compiling and updating to glibc 2.17 manually solved it.

I still solving this, stuck with "Enable multithreading to use std::thread: Operation not permitted”. All the solutions that I found were related to the gcc 4.8.x bug, and didn't help for me. Hard to say when the build will be.

@Kushfield Replacing ReHLDS 'hlds_linux' for HLDS 'hlds_linux' is working for now. Thanks.

Is there any update? I can't change hlds_linux file because I am using a shared hosting :(
L 12/10/2018 - 04:12:04: [AMXX] Module "cstrike/addons/amxmodx/modules/curl_amxx_i386.so" failed to load (cstrike/addons/amxmodx/modules/curl_amxx_i386.so: undefined symbol: pthread_create)
L 12/10/2018 - 04:12:04: Error:
L 12/10/2018 - 04:12:04: [AMXX] Module is not a valid library (file "cstrike/addons/amxmodx/modules/curl_amxx_i386.so")


Broken link from Plans page

When on this page https://zulipchat.com/plans/ if you click the "Install a Zulip Server" link you are taken to https://zulip.readthedocs.io/en/stable/production/overview.html which is a 404 page.

Looks like @timabbott is already on this with bf77158

Yeah, this was introduced when we released Zulip 1.9 and it took over the /stable/ link :)


feat(lidar_centerpoint): remove libtorch from centerpoint

Related Issue(required)
https://github.com/autowarefoundation/autoware.universe/issues/488
Description(required)

remove libtorch and implement the equivalent libraries for this package using c++/cuda
change converted onnx model format, but the pre-trained model is the same as before
(todo) update links to download trained models

download links are in preparation

before:

GPU memory: 2817MiB
inference time: 48.79 ± 3.78 ms

after:

GPU memory: 1295MiB
inference time: 45.43 ± 3.37 ms

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yukke42 pls add related PR

@yukkysaito
libtorch isn't installed in https://github.com/autowarefoundation/autoware

@yukke42 cc @kenji-miyake
how are developpers doing without libtorch?
Does this mean that detection cannot work in https://github.com/autowarefoundation/autoware?

@yukkysaito
We used cuda 11.1 and tensorrt 7.2.1, but https://github.com/autowarefoundation/autoware requires cuda 11.4 and tensorrt 8.2.2. (here). Perception packages which requires CUDA  aren't supported yet.  So, we should make sure that lidar_centerpoint and other packages, s.t.  lidar_apollo_instance_segmentation, tensorrt_yolo, ..etc, work on both environment at the same time.

@yukkysaito @aohsato @mkuri It's now ready for review.

@miursh ?

I checked it's working in my pc.
before:
GPU memory: 2819MiB
inference time: 31.94 ± 6.92 ms
after:
GPU memory: 1299MiB
inference time: 27.23 ± 6.94 ms

I tested it in my computer with sample-map-rosbag and it's working well.
Currently, documentation of rosbag replay simulation not working properly.

I tested it in my computer with sample-map-rosbag and it's working well.
Currently, documentation of rosbag replay simulation not working properly.

@kaancolak Thank you for testing this PR.
Cloud you create an issue in https://github.com/autowarefoundation/autoware-documentation and describe the problem in more detail?

build-and-test-differential / build-and-test-differential (pull_request)  wasn't passed because the model failed to be downloaded from gdrive.

build-and-test-differential / build-and-test-differential (pull_request)  wasn't passed because the model failed to be downloaded from gdrive.
https://github.com/autowarefoundation/autoware.universe/runs/5640881412?check_suite_focus=true

I will remove to check downloaded files to pass ci.

@wep21 Since I'm not familiar with CUDA programming, could you help me reviewing this PR?

@miursh I have taken a look at the part of cuda implementation, I guess there is no problem.


[vim9class] document _ as protected instead of private

Fixes #13504.
The implementation of this PR takes a minimalist approach. Mostly just change "private" to "protected". Keep an eye out for things that don't read naturally, even if not directly part of this change. There is some additional text and some |links| have been added. Any issues with them?
Some error messages are changed along with the tests that reference them.

thanks


[Question] SSLCertVerificationError when Using lmql with llamaindex

Hi there,
I'm trying to use lmql with llamaindex with the following code:

However, I keep encountering the SSLCertVerificationError.

Can anyone help me by providing guidance on resolving this issue?
Thanks

This sounds like there may be an issue with you api_base being an invalid SSL certificate. Can you confirm that api_base is the correct URL.


Update on the code part

@night-chen ,
Would you be uploading the code? This well help community

The code is still under review by collaborators. Once the reviewing process is over, we will make the code public immediately. Thank you for your interest!


Update for Private Dev Feed Publishing

This fixes https://github.com/Azure/azure-sdk-for-java/issues/11824.
When running the scheduled builds, default to publishing to the private dev feed unless we're publishing from Azure/azure-sdk-for-java, our public repository. This will allow scheduled builds for Azure/azure-sdk-for-java-pr, the private repository, to publish packages to the private feed.
We still will publish to the java public feed after we publish to Maven.

Just to be on the safe side, I am going to hold this Java releases are done this week which means I'll check it in on Friday.


Check existence of download folder for each download step

To avoid having to run notebooks in a specific order make sure each download instruction checks for the existence of the required download folder and create if needed.

Fixed!


”Măgura Ilvei” is listed in the drop-down menu

Description:
"Măgura Ilvei" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Măgura Ilvei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Măgura Ilvei, Bistrița-Năsăud".


clearItems w/ or w/o arguments

Let me know if anybody has any thoughts on this.  Not really a pull request, but might be something here.  A little (or most likely a lot :) ) lack of understanding on my part on what this code should be doing!
https://github.com/ebryn/backburner.js/pull/171

As a friend pointed out, looks like timemachine monkey patches the Date object and backburner is expecting to use this Date object to scheduleExpiredTimers.  :(  That is where my real problem lies.


”Peștera”, ”Săliște”, ”Trestia” are listed in the drop-down menu

Description:
When user writes ”Peștera”, ”Săliște”, ”Trestia” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Peștera"

Expected results
The location appears in the drop-down menu as "Sat Peștera, HUNEDOARA (Băița)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Săliște"

Expected results
The location appears in the drop-down menu as "Sat Săliște, HUNEDOARA (Băița)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Trestia"

Expected results
The location appears in the drop-down menu as "Sat Trestia, HUNEDOARA (Băița)".


added tailwindcss in the project

Description
I added the tailwindcss configurations in the project so that it can be used through out the react play
Fixes #165   (issue)
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I have tested it in the Linux Ubuntu Environment in chrome browser
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@atapas  I think using class names instead of h1, h2 as selectors in the css will fix the issue

@nirban256 I see some changes due to Tailwind overriding some selectors like H1, H2 etc.
What's the strategy to fix them?
Here is the preview link with all the changes from this branch?
https://react-play-git-fork-nirban256-main-atapas.vercel.app/
Here is reactplay from main: https://www.reactplay.io/
You can find the changes from home page to other pages.

There are also changes to the alignment, and margin on the page.

@nirmalkc We are planning to add Tailwind support to the project but facing issues with basic overriding. Could you please suggest any way out?

@nirmalkc We are planning to add Tailwind support to the project but facing issues with basic overriding. Could you please suggest any way out?

I believe that most of the impacts are because of the tailwinds browser default reset styles.
Here are some impacts which I could observe in a quick glance..

homepage title top margin
idea title icon alignment
filters modal has one of the major look-n-feel impact

I am sure that we can address this with a 1:1 comparison and fix it. I dont see any other workaround.

@nirmalkc We are planning to add Tailwind support to the project but facing issues with basic overriding. Could you please suggest any way out?

I believe that most of the impacts are because of the tailwinds browser default reset styles.
Here are some impacts which I could observe in a quick glance..

homepage title top margin
idea title icon alignment
filters modal has one of the major look-n-feel impact

I am sure that we can address this with a 1:1 comparison and fix it. I dont see any other workaround.

@nirmalkc As you know the style part better, would you like to take it up? You can work on the same changes don so far on this branch.
Here are steps on how to fetch changes from someone's fork and work:https://dev.to/davidmaceachern/how-do-you-work-with-someone-else-s-fork-5fd7
Please let me know if you need help.

Hello @nirban256
We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

Hello @nirban256
We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

The migration is complete. You can find the project here: https://github.com/reactplay
You no need to reclone the project. You just need to set the correct upstream. Here is the link: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-for-a-fork

Ok @atapas Sir


Test: Allow to split an editor into an existing group

Refs: https://github.com/microsoft/vscode/issues/133260

[ ] anyOS
[ ] anyOS

Complexity: 2

We always had commands to split the active editor into any direction by creating a new editor group for it. Now we added other commands to split editors into an existing group if one is present at the location to prevent creating new groups over and over.

Testing:

verify the commands as listed in the screenshot above work as you expect them to work (a group will open if none exists but a group will be reused otherwise)

For a native English speaker Above Group and Below Group are clunky. How about changing them to Group Above and Group Below?

@gjsjohnmurray yeah, there is even more commands that use this wording:

Fixed the ones using "Above" or "Below". Now I wonder about others like "View: Move Editor into Left Group", should they be renamed as well? E.g. "View: Move Editor into Group to the Left" (more verbose though).

Now I wonder about others like "View: Move Editor into Left Group"

@bpasero no, I don't think these need to be changed.

I guess this is intended, but wouldn't it make sense to move the file to the editor group instead of opening a copy? Is there a setting for this?

Sorry what am I looking at?

The files are the same on both editor groups. I expected them to be moved, not copied.

@DavidKutu which command did you use? The "Split Editor into *" ones open a tab in the target group for the same file. The tab you were on when you ran the command remains. The "Move Editor into *" ones move the focused tab to the target group.

I used the Split commands. But good, looks like its intended and there's another command for what I wanted.


Version bump to v3.3.0

Cargo version bump to 3.3.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.173%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6914

Relevant Lines:
8214

💛  - Coveralls


Fix extractLinksFromMessageHtml so ExpandURLPreview is not called needlessly

This was added here https://github.com/Expensify/App/pull/17288/files#diff-e632f3693dffc58adf371d4fb1289089c0291b6d1d94c44fe91a794dcdae2998R186 and it was causing a call to ExpandURLPreview each time it rendered an action (?) or at least almost each time.
Fixed Issues

$ https://github.com/Expensify/App/issues/21368
Tests
Open a new chat with someone you never talked

See ExpandURLPreview is not being called

Offline tests

No
QA Steps

Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Bump @parasharrajat

Why no QA? We can QA in web using the steps I provided, no @parasharrajat ?

Sorry @s77rt that's not what I wanted to happen, we don't need the review here.

Agreed we should still QA this.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.34-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Connect component fix for build issue

Issue #, if available:
#652
Description of changes:
Updating babel and Connect.js for fix issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #672 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   87.17%   87.17%
=======================================
  Files          72       72
  Lines        3424     3424
  Branches      648      648
=======================================
  Hits         2985     2985
  Misses        422      422
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e31f4...39c42dd. Read the comment docs.


Notification Drawer Demo

Create a demo showing the notification drawer in the context of a page. This should reflect the mockups shown here that include the masthead icon and the sizing of the drawer to fit the height of the page. https://redhat.invisionapp.com/share/7FQDO4RP462#/screens/345385129_Notification_Drawer_-_Complex_Example3
This issue is contingent on completion of #35 that introduces the Notification Drawer component.

Duplicates #35


MINOR: DOC: Remove versionadded

The package is new, this no longer makes sense

Good catch. Do you see other released related documentation to remove?

at least no other versionadded
so I'll merge this one


Question about Firmware Version Of SuperMutt V3.0

Hello,
I've installed MUTT SW Package (Mutt2_96.msi), but I think that there is no latest firmware version.
Because when I tried firmware update (MuttUtil.exe -UpdateFirmware), always remain rev51
Could you tell me where can I download latest FW?
(Refer to version updates info, FW v55 must be included in version 2.9.5)
And I wonder about transfer mode.
I've bought SuperMuttV3.0 for test each transfer mode. (ex. Isochronous transfer)
But It seems only bulk mode operation.
Is Supermutt V3.0 support Isochronous transfer mode?
How can I switch mode to Isochronous? related to FW version?
Thanks.
*Firmware version refer to below CMD log
C:\USBTest\x64>MuttUtil.exe -UpdateFirmware
Looking for MUTT devices
List of devices before firmware update
:    : HARDWARE ID                    :  PROBLEM CODE  : DRIVER
DEVICE :  0 : USB\VID_045E&PID_078F&REV_0051 :             0  : USBTCD
List of devices after firmware update
:    : HARDWARE ID                    :  PROBLEM CODE  : DRIVER
DEVICE :  0 : USB\VID_045E&PID_078F&REV_0051 :             0  : USBTCD
Return value: 0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8aa1d919-c2b7-eec7-f69d-1a0f3ebef4e5
Version Independent ID: 39996cc8-d582-e578-93bf-9bbcb2cfdd38
Content: Tools in the MUTT software package - Windows drivers
Content Source: windows-driver-docs-pr/usbcon/mutt-software-package.md
Product: windows-hardware
Technology: usbcon
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

Hello @JiyoonHa84
Thanks for reaching out to our team. This particular mechanism is monitored by the men and women who write the driver documentation posted on doc.microsoft.com. Unfortunately, we don’t have the resources to help troubleshoot driver development issues sent our way.
Your best bet is to use one or both of the two really good forums where other driver developers and Microsoft engineers can be found. The first is Microsoft Q&A. The other is the OSR NTDEV forum. You can post your question there, and like-minded developers usually give feedback fairly quickly.
Again, thanks for reaching out. Best of luck with this issue.
~ Mark


Windows button not center

Windows button is not center along with the icons?
Windows button should go to center

This is not planned. Windows 11 will offer this though but the grouping is not the same in windows 10


Add support up to Java 21

Fixes https://github.com/PolyMC/PolyMC/issues/1628

@HeyaGlitz , who is in charge for merging this commit?

Lenny

@Scrumplex , could you please merge this pull request, it is only single line of change. The users like me is eagerly waiting for this change. Great thanks!!!

@evan0greenup Scrumplex isn't a part of the team anymore haha, you'll have to bother @LennyMcLennington

If anyone is facing this even after selecting "Skip Java Compatibility Check" from PolyMC settings, read:
Apparently there are two "Skip java compatibility check" settings.
You have to select the "Skip java compatibility check" from instance settings, not the main settings.


Shaders applied on start and cant be changed or reenabled

Im having issues on Linux with MPV auto loading Anime4k by default  for Mode A and if i try to change modes or disable and select a different mode nothing happens.
My MPV.config; https://pastebin.com/sFp60Eyr
Input.config; https://pastebin.com/Fru4BApU
I was not able to locate any instructions on glsl-shaders setting for mpv.config or if its required to have them listed on linux, but i have it set to use just mode A, but if i add the shaders for the other modes i can not switch between them or enable them again.
When adding all modes to mpv.conf this is what i have it like
https://pastebin.com/H6Qimws0

You might have read outdated installation instructions. For the latest version you don't need to add anything in mpv.conf, you only need to modify input.conf and use CTRL+1, CTRL+2, etc...
Also make sure you are using a version of mpv that is released after June 2021 or you might encounter major performance issues.


Refactors and fixes

This PR brings some fixes, refactors and improvements:
Fixes

scope_expression array_indexed access issues (ex: sizeof(foo[][][].bar)). See https://github.com/Sarrus1/sourcepawn-vscode/issues/355.
switch_case were very limited. See https://github.com/Sarrus1/sourcepawn-vscode/issues/355.
MISSING ; on old_global_variable_declarations. This took so long to fix, it has been almost 1 year in the making. Thanks a lot to @alaviss (@leorize on Discord) for helping me!
const in methodmad properties was not allowed. See https://github.com/Sarrus1/sourcepawn-vscode/issues/356.
Fix #13.

Refactors

Some node names have changed and I have added some field names for ease of parsing.

Improvements

The queries have been greatly improved.

Misc
Would it please be possible for you to add me as a maintainer on the project so that I can merge things without waiting for PR approval? Thanks!

Thank you :heart:


Please separate the apk (v8a, v7a, etc.) in F-droid

Progress: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15714


Fix config file lookup on Windows in home directory.

 Closes #10.

Also working on MacOS 10.15.5.


Clicks / pops in the SoundFont player introduced by Tone r13

Sadly, it looks like the upgrade to Tone.js 13 in https://github.com/tensorflow/magenta-js/pull/326 has introduced some clicks/pops in the SoundFont player. It's a little harder to notice than the same issues that were present in the PolySynth player, but they're there nonetheless....
@tambien Do you think this might be as simple to fix as the Polysynth pops? Hopefully I can take a look later this afternoon.

If it's the same issue as the PolySynth, it had to do with a bug in Chrome with scheduling envelope. If there are not the same pops on FF and Safari, i'd say it might be related to that.

@tambien Nope! It's just a small regression in supplying a fadeOut to a BufferSource, fixed:
https://github.com/tensorflow/magenta-js/pull/330

Fixed in #330


[lit-html] [wip] Reduce cache overhead of static templates.

Following up on comments in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2876969 here's a proof-of-concept to reduce the performance overhead of using static.ts
The major issue that seems to stand out still is the tests for _$litStatic$ which are going to pollute the engine's ICs. I'd suggest to maybe go with a WeakMap / WeakSet approach here instead.
cc @paullewis

Merged in current main, resolving conflicts. Seems like this implementation is failing stability checks when using same tag name, e.g. https://github.com/lit/lit/blob/5c8b142552542ffa775b74074b8bd16f427a00fa/packages/lit-html/src/test/static_test.ts#L95-L96


Support for setting  spark.sql.caseSensitive=true enhancement

spark.sql.caseSensitive=true allows users to create a table using parquet with two columns with the same name but different case sense.
sample code working.
set spark.sql.caseSensitive=true
spark.sql("CREATE TABLE tableADLGen2 (
DEVICE_D1 FLOAT,
device_D1 FLOAT,
date INT )
USING PARQUET OPTIONS (path<EMAIL_ADDRESS>PARTITIONED BY (date)")
sample code failing:
set spark.sql.caseSensitive=true
spark.sql("CREATE TABLE tableADLGen2 (
DEVICE_D1 FLOAT,
device_D1 FLOAT,
date INT )
USING DELTA OPTIONS (path<EMAIL_ADDRESS>PARTITIONED BY (date)")
'Found duplicate column(s) in the metadata update: seg2a_botton_left_ctrl_mode_c2395;'

So this issue has already been addressed and there is no plan on implementing support
https://github.com/delta-io/delta/issues/126

Thanks for the reference, I'll close the case


Upgrade to Cairo 1.0

Description
Upgrade all contracts to Cairo 1.0
Cairo 1.0
Installation guide:

<EMAIL_ADDRESS>
Starklings

https://github.com/shramee/starklings-cairo1

Benchmarks

https://github.com/Darlington02/min-starknet/tree/cairo1.0/cairo1.0
https://github.com/keep-starknet-strange/quaireaux
https://github.com/OpenZeppelin/cairo-contracts/pull/556/files#diff-934b348f6edf02857bf4a95bc55568cc75b633ba1530ee665ee9fb00db8dc0e8

Package manager

Scarb

https://blog.swmansion.com/say-hello-to-scarb-a-cairo-1-0-package-manager-782b0321f82f
https://github.com/software-mansion/scarb/discussions/79

Can I get some tasks for migration? I would like to contribute.

Thanks @zeapherine for your interest, in order to migrate we need first to migrate our dependencies, which are (from few to high workload):

https://github.com/carbonable-labs/cairo-erc-4906/issues/3
https://github.com/carbonable-labs/cairo-erc-2981/issues/3
https://github.com/carbonable-labs/cairo-migrator/issues/5
https://github.com/carbonable-labs/cairo-erc-3525/issues/28

Feel free to make a PR about the one you are the most interested :pray:

Please add your planning poker estimate with Zenhub @Bal7hazar