[WIP][SPARK-34505][BUILD] Upgrade Scala to 2.13.5

What changes were proposed in this pull request?
This is WIP to test new Scala 2.13.5.

[ ] Needs com.typesafe.genjavadoc:genjavadoc-plugin_2.13.5:0.16

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Test build #135373 has started for PR 31620 at commit 5a19535.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39953/

Test build #135373 has finished for PR 31620 at commit 5a19535.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135373/

It seems that it takes more time than usual.

Seems OK if tests pass - just need to update the deps file too

FYI, currently, this is blocked by genjavadoc and some build issues~ I'll update the PR when it's available.

Test build #135477 has started for PR 31620 at commit 70316e4.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135477/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40057/

As I described in the PR description, I verified this manually with -Pscala-2.13. And, GitHub Action Scala 2.13 build job also passed here.
Could you review this again, @srowen , @HyukjinKwon , @maropu , @wangyum , @viirya ?

Same deal, looks fine, just update deps files?

Yes, @srowen . Only the single line version number change.

Same deal, looks fine, just update deps files?

Are you suggesting to update something additionally on top of this PR?

Oh right the deps files don't change because they are just tracking the default 2.12 libraries. It's fine.

Thank you, @srowen .
Merged to master!

late lgtm. Nice.

lgtm

Thank you, @maropu and @viirya !

Nice!

Thanks, @HyukjinKwon !


Arrays & Hashes tweet

Hey John!
Liking the elf/orc-play in your post, haha! Just a heads up that you listed your file location instead of the url in your tweet, though :)
Looks like you could get use some more contrast in the lettering and background, this pic might help: http://d22zlbw5ff7yk5.cloudfront.net/images/stash-1-507c8da7ae6f2.png
Well done!

Thanks, Christine. I will fix the link. Thanks for pointing it out.
And yeah, the contrast is terrible. I've been meaning to fix it, but
cramming other work in before deadlines. Thanks for the reference; it will
definitely help.
Hope you're doing well!
-John
On Sunday, April 26, 2015, Christine Hager<EMAIL_ADDRESS>wrote:

Hey John!
Liking the elf/orc-play in your post, haha! Just a heads up that you
listed your file location instead of the url in your tweet, though :)
Looks like you could get use some more contrast in the lettering and
background, this pic might help:
http://d22zlbw5ff7yk5.cloudfront.net/images/stash-1-507c8da7ae6f2.png
Well done!
—
Reply to this email directly or view it on GitHub
https://github.com/jdsthird/jdsthird.github.io/issues/1.


Installation fails in a new environment (Mac OS)

It looks like the installation script is trying to create a folder in the path /usr/local/lib/node_modules/npm-adaptiveme-nibble/../adaptive-nibble-emulator
currently in my node_modules folder only generator_adaptiveme is present and as the folder owner is admin this might be throwing the permission denied.
$ sudo npm install npm-adaptiveme-nibble -g
Password:
/usr/local/bin/nibble -> /usr/local/lib/node_modules/npm-adaptiveme-nibble/bin/index.js

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/npm-adaptiveme-nibble
> node bin/install.js

[nibble] Current platform: darwin
[nibble] Downloading nibble... https://github.com/AdaptiveMe/adaptive-tools-nibble/releases/download/1.0-alpha.7/adaptive-nibble-darwin-x64-1.0-alpha.7.tgz
[nibble] Error: Error: EACCES, permission denied '/usr/local/lib/node_modules/npm-adaptiveme-nibble/../adaptive-nibble-emulator'
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "npm-adaptiveme-nibble" "-g"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `node bin/install.js`
npm ERR! Exit status 255
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node bin/install.js'.
npm ERR! This is most likely a problem with the npm-adaptiveme-nibble package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node bin/install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls npm-adaptiveme-nibble
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /usr/local/lib/node_modules/npm-debug.log

The current content of node_modules
``
`
drwxr-xr-x   6 24561   wheel     204 May 18 17:55 .
-rw-r--r--   1 root    wheel  854275 May 18 17:55 npm-debug.log
drwxr-xr-x  10 nobody  staff     340 May 18 16:37 generator-adaptiveme
drwxr-xr-x   6 nobody  staff     204 May 14 17:40 yo
drwxr-xr-x  26 65534   staff     884 May 14 10:47 npm
drwxrwxr-x   4 24561   admin     136 Apr  1 00:19 ..

Solved.


fix: savign single types [CU-29pe9y6]

Ticket
https://github.com/VirtusLab/strapi-plugin-navigation/issues/180
Summary

Changes condition for form validation taking into account single types

Test Plan

Add internal navigation item with a related single type

Task linked: CU-29pe9y6 [BUG] Not possible to save navigation items with related single type


"Operation refused for security reasons" when updating the same SRP host twice in a row

Describe the bug
https://github.com/openthread/ot-br-posix/pull/1008 was supposed to solve an issue with duplicate SRP updates but it doesn't help in my case. In fact, it can make things even worse in some scenarios.
Suppose that the following SRP updates are sent within a short period of time:
UPDATE1:
    EXISTING_HOST
        SERVICE1
UPDATE2:
    EXISTING_HOST
        SERVICE1

Since PublishServiceHandler and PublishHostHandler simply decrement the number of outstanding operations for a matching SRP update and the handlers can be called synchronously when calling PublishHost or PublishService, UPDATE1 will be considered completed after processing UPDATE2.EXISTING_HOST even if UPDATE1.EXISTING_HOST.SERVICE1 is still pending. Moreover, too early removal of UPDATE1 will invalidate a pointer to UPDATE2 and UPDATE2.EXISTING_HOST.SERVICE1 will be put in a wrong place in the memory. As a result, the SRP client will never receive a result of UPDATE2.
To Reproduce

Build and run OTBR Docker container using commit 685a1e0f483febc26127c8c2f2bd8f922b682a06.
Form a Thread network using default settings.
Build and flash Matter Lock onto a nRF52840 DK.
Press Button 3 on the DK to join the formed Thread network.
Reboot the DK. After each reboot the firmware adds a new SRP service and due to the issue described above, an SRP update may fail.

Expected behavior
SRP updates succeed no matter how frequently they are sent.
Console/log output
To be added.
Additional context
I prepared a fix which is available here: https://github.com/Damian-Nordic/ot-br-posix/commit/08cb66612477eb5ceb0574b01e7069e855261807, so I can create a PR, but since it reverts https://github.com/openthread/ot-br-posix/pull/1008 I would like to first discuss if that's a good direction.

@simonlingoogle Can you help? :)

I am actually aware of the potential issue even with #1008 and was planning to introduce more fixes.

We need to use more complex logic than just counting the callbacks to make sure the hosts and services are all published (this should help address this bug)
We need to make sure there is only one outstanding PublishHost or PublishService, and subsequent PublishXxxx will supersede the previous one

Moreover, too early removal of UPDATE1 will invalidate a pointer to UPDATE2 and UPDATE2.EXISTING_HOST.SERVICE1 will be put in a wrong place in the memory. As a result, the SRP client will never receive a result of UPDATE2.

I need to investigate more on this issue.
@wgtdkp any suggestions?

The key issue is that the callback is identified by the host or service
instance name. We need other techniques to associate an ID with calls to
mdnsResponder and avahi. The idea is to wrap the this pointer which is
passed to DNSServiceRegister to carry the SRP update ID.
Simon Lin @.***>于2021年9月16日 周四09:33写道：

I am actually aware of the potential issue even with #1008
https://github.com/openthread/ot-br-posix/pull/1008 and was planning to
introduce more fixes.

We need to use more complex logic than just counting the callbacks
to make sure the hosts and services are all published (this should help
address this bug)
We need to make sure there is only one outstanding PublishHost or
PublishService, and subsequent PublishXxxx will supersede the previous
one

Moreover, too early removal of UPDATE1 will invalidate a pointer to
UPDATE2 and UPDATE2.EXISTING_HOST.SERVICE1 will be put in a wrong place
in the memory. As a result, the SRP client will never receive a result of
UPDATE2.
I need to investigate more on this issue.
@wgtdkp https://github.com/wgtdkp any suggestions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openthread/ot-br-posix/issues/1011#issuecomment-920506420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOYD4URJHUJWAGIIWK5AXTUCFCPVANCNFSM5D6CHWTQ
.

I have created https://github.com/openthread/ot-br-posix/pull/1014 to revert #1008 as a quick fix.
Will create a more mature fix later.

Thanks @simonlingoogle although it wasn't your change that caused the issue I hit on. It was existent even before.

Thanks @simonlingoogle although it wasn't your change that caused the issue I hit on. It was existent even before.

Would you submit your private PR for fixing the issues your found?

@wgtdkp I will submit the PR on Monday after doing some more testing :).

@Damian-Nordic Thanks for revealing the memory issue and the fix.
However, I found that the bug is so tricky that https://github.com/Damian-Nordic/ot-br-posix/commit/08cb66612477eb5ceb0574b01e7069e855261807 still hasn't totally addressed the problem.
For example, the outstanding update aUpdate may be invalidated within the method PublishHostAndItsServices, which are used in  PublishHostAndItsServices multiple times.
I think it's quite hard to get everything right if the callbacks can be triggered during the host and services publishing.
We can use a TaskRunner to Post callbacks so that callbacks won't be called during PublishHostAndItsServices, so that we don't need to handle these tricky cases.
I can create a fix if you think it's a good idea to use TaskRunner to simplify the problem. @wgtdkp @Damian-Nordic

Re-opening since the discussion remains ongoing.

@simonlingoogle @wgtdkp I think that's a good idea. I modified my change to also run all the handlers asynchronously and in the same thread, and tested that I couldn't break the SRP by re-publishing the same services in a loop. I posted a PR with the change. Let me know if that's what you meant.
Btw, I wonder if it would make sense to implement some kind of recovery mechanism in OTBR - currently when an update is somehow not handled correctly (which I admit should never happen, but things happen ;)) it never gets removed from the list of outstanding updates and if the client sends a new update, the old one is updated first which leaves the new update unfinished (and the cycle repeats). I believe the server should give up an invalid update at some point in case it can't be completed properly. But that's just an idea.

@simonlingoogle @wgtdkp I think that's a good idea. I modified my change to also run all the handlers asynchronously and in the same thread, and tested that I couldn't break the SRP by re-publishing the same services in a loop. I posted a PR with the change. Let me know if that's what you meant.
Btw, I wonder if it would make sense to implement some kind of recovery mechanism in OTBR - currently when an update is somehow not handled correctly (which I admit should never happen, but things happen ;)) it never gets removed from the list of outstanding updates and if the client sends a new update, the old one is updated first which leaves the new update unfinished (and the cycle repeats). I believe the server should give up an invalid update at some point in case it can't be completed properly. But that's just an idea.

We actually have a plan to bind a unique ID to each service and host registration and in which case we will not mismatch previous failed service.

@wgtdkp Ok, so should I close my PR?

@wgtdkp Ok, so should I close my PR?

No, It may make some time for us to implement the eventual solution, you current fix makes sense to me, thanks! :)

I think the PR contains two parts:

Post the callback so that they will always be invoked after publishing
Make sure PublishHost handler and PublishService handlers are called exactly once for each OutstandingUpdate.

I think part 1 is useful no matter we use the unique ID or not. And part 1 actually removes the requirement to use unique ID to some extent  because everything works well with 1 alone.
Part 2 is not a must if we are using unique IDs, nevertheless I find it nice to have (to avoid any future subtle issues).

Part 2 will no longer be needed when you implement assigning update IDs to Publisher's operations, so that the handler can uniquely identify an update which trigger the operation. Until that Part 2 makes sure that updating the host twice is not the same as updating the host and a service on that host.


Format cli output for --help

Formatted the help option output for easier reading at a glance. Cleaned up inconsistent new lines in fuge.js.
Currently
$ fuge help

usage: fuge <command> <options>
available commands
generate [system | service] - generate a system or an additional system service
build - build a system by executing the RUN commands in each services Dockerfile
pull - update a system by attempting a git pull against each service
run <compose file> - run a system
preview <compose file> - preview a run command for a system
shell <compose file> - start an interactive shell for a system
help - show this help

Pull Request
$ fuge help
Usage: fuge <command> <options>

fuge generate <system|service> generate a system or an additional system service
fuge build                     build a system by executing the RUN commands in each services Dockerfile
fuge pull                      update a system by attempting a git pull against each service
fuge run <compose-file>        run a system
fuge preview <compose-file>    preview a run command for a system
fuge shell <compose-file>      start an interactive shell for a system
fuge help                      show this help

If merged, #62 will conflict. Depending on which is merged first, if at all, i'll make a new PR accordingly.

@fourq i merged the other one first. could yoiu please re-roll this?
i'll merge it once you do.

If I can lend a hand in area's needed I'd be happy to.


How can I solve the mismatch problem of pre-training weights using resnet50?

I believe you can solve it by yourself.


[3/n] SFTDataset: refactor chat formats as prompt templates

Context
What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[x] update tests and/or documentation
[ ] other (please add here)

As discussed in the RFC in #1186, we will merged instruct and chat datasets to the following unified pipeline that can better support multimodal:

message_transform to create List[Message] from dataset with full flexibility on columns, ad-hoc modifications, etc. For multimodal, additionally images are loaded from the path
prompt_template as a optional way to add structured text around specific roles in the list of messages
model_transform that takes the list of messages and tokenizes it. For multimodal, it will additionally apply model-specific image transforms to the images associated with the sample

For ease of review, we will stage this as multiple moderate-sized PRs. This PR refactors the current ChatFormats to the merged PromptTemplate classes. We keep the old ChatFormats to preserve BC for now
Test plan

[ ] update live docs and check rendering
[x] unit tests for new chat templates
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test

E.g. should we keep a tutorial based on ChatFormat if we are deprecating it?

Yeah great question. I was planning to keep all ChatFormat and Instruct/ChatDataset related tutorials until the refactor is entirely done, then I can update all the tutorials at the end. Let me know if there's any concerns with this


Bugs related to multiple delete

If delete the data storage file and start from 0 tasks, perfrom add 1, add 2, add 3, add 4, add 5, add 6, and then delete 1-6, there will be exceptions thrown and these tasks are not deleted.

JavaFX?
https://bugs.openjdk.java.net/browse/JDK-8087508
@burnflare

Might be resolved by #188 ?


ATIS-AFW Make "Comment/Arrangements" Text Area usable

It would be nice if text manually entered into the "Comment/Arrangements" Text Area would be saved.
Currently, if I change the page or click out of the "Comment/Arrangements" Text Area the text is reset to a default value.
Maybe the text value of the "Comment/Arrangements" Text Area can be saved to the local storage of the browser, so it is also saved if the web page is closed or the page is changed.
A button to reset the text to the default value would be good in this case.

The text will be saved if you are on the ATC roster of VATGer and at least S2.
Frontend handling/display of the permission denied error is lacking though.

Why is it not working for S1 controllers?
Is it because the tool is mainly used on APP or CTR positions?

The restriction was added so that trainees and users not actively controlling are still able to view ATCISS but are not able to change agreements. As we currently do not have any history for the agreements we want to ensure no trolling or edit wars happen. The same applies to the sector status fields.
The agreements are only used by radar positions. There is currently only one textbox per FIR and therefore should contain the relevant information for the whole FIR. We already allow S2 tower controllers to change these even though they are technically not a radar station. Agreements between ground stations are not relevant to radar stations and should be communicated individually or, if indeed relevant, added by the responsible radar controller.


[AIRFLOW-143] setup_env.sh doesn't leverage cache for downloading minicluster

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

AIRFLOW-143

LGTM


fix the test_connection file name

Proposed changes
This PR fixes the test_connection.md file name.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[x ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactorings that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #241 (4168c79) into main (cb8e9a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   65.51%   65.51%
=======================================
  Files          58       58
  Lines        3300     3300
=======================================
  Hits         2162     2162
  Misses       1138     1138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8e9a6...4168c79. Read the comment docs.


Manual review required due to updating token name

I'm submitting a ...
[ x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
Hey! Wondering if a manual review for this PR can be done https://github.com/solana-labs/token-list/pull/22854 I created the original token, and made a typo on the name. Would like to change from $HILLS to $SHILLS

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

merged


Enable a direction on any firewall rule

It can be very useful to set rules on outgoing (not just incoming) packets on an IF. This is already available for floating rules, but not for rules on other IF's (even though it would work). No obvious drawback or issues resulted in testing or apparent from the codebase or PF documentation. So this PR makes the "in/out/any" option visible and working on all rules, not just floating rules. Totally transparent + no config update needed.
firewall_rules.php now shows interfaces+direction (for floating rules, which it probably should anyway as this is quite important info) or just direction (others interfaces). Care taken to ensure word wrapping is assisted on the IF's for floating rules, for narrower displays.
If direction is not explicitly set on a rule, then it's assumed to be "any" for floating rules and "in" for rules on all other interfaces (both when editing the rule and also when building the pf config in filter.inc).

While it is technically possible, it's not something we've deliberately not wanted to offer to the user to reduce confusion and the potential for error. If they want a directional rule, they can use floating rules.

I'm not sure that direction will confuse users, given the other options that are provided. Also floating rules go at a specific place in the rules list, so you can't put a rule which specifies direction for a specific interface, above some rules and below others. Often floating rules just aren't very helpful, unless you make almost everything a floating rule, because you can't sequence them in with other rules, that's not their function.
I don't think it's a complicated option, to specify whether the test is applied on incoming or outgoing packets.  We don't see people confused by floating rules, AFAIK?  It isn't confusing the GUI, and it's very useful in many cases + provides an ability to add rules in sequence for a specific interface, which can't always be done easily otherwise.  Can you reconsider that it actually isn't that complicated?
That said, if it really is likely to confuse some users, can we at least move it in with the "advanced options", so the functionality is available when wanted by other users? Would that be ok?

I just don't see it being worth the trouble no matter where it's put, when floating rules serve the purpose fine. If you need outbound rules they won't have any bearing on the inbound rules anyhow, so having an outbound floating rule is no different than putting it in the middle of the interface ruleset.
From a user support perspective it would be a usability nightmare no matter where it's put. If rules are misbehaving it's yet another place admins and support reps have to check to see if the rule was goofed. Visual indicators can help here, but the moment someone finds it they'll think they need to use it, and they'll inevitably get the direction mixed up.
tl;dr: It's a rarely needed option that has no clear benefit to being on the interface rule tabs except for very rare use cases that are already properly covered by floating rules.

Hmm.
I am a bit awed that anyone who can cope with basic pfSense and basic pfSense rules, will get confused by whether the rule is looking at packets arriving at the router or leaving the router. But I would respect your experience in this - it's common knowledge how badly cluelessness can strike. But I just wouldn't have thought the incremental cluelessness - the difference between support headache level with pfSense and with pfSense + packet direction, would be much of anything. You really think "nightmare for support" is a realistic additional impact if the option is offered, or would create a support nightmare in any user where one didn't exist before?

It's not just an incremental change. It's a massive change in behavior for rules. It changes the whole meaning of rule tabs that has been consistent in all prior pfSense releases. In addition to the GUI change it would also require updating all the documentation on how rules work in the wiki, book, videos, and so on. It's not the kind of change we can just put behind an advanced button and hope only those who need it, see it. It was one of the primary motivators for making the floating rule tab, so that it would be less likely to confuse or be misused/abused in an isolated location.


[ruff] if k in d: del d[k] (RUF041)

Summary
Resolves #7537.
Test Plan
cargo nextest run and cargo insta test.

Thanks for opening the upstream issue.
We discussed this internally. Let's give flake8-simplify about a week to get back to the issue. If we don't hear back in a week, then let's implement this rule as part of ruf (as you did).
@InSyncWithFoo feel free to ping me after a week

To me, this seems to be mainly a stylistic rule and I personally would prefer if x in k: del k[x] in many places. But maybe that's just because I'm unused to a dict type to not have a remove method. I'd be on board merging this rule if we consider using pop is a more idiomatic writting of this pattern. @AlexWaygood what's your take on this?

I agree that using .pop(..., None) is the idiomatic way to do this in Python. The rule makes sense to me. While I agree that it reads a little bit awkwardly if you're new to the language, it's much more efficient than if x in k: del k[x], and it's more concise. I feel like pointing out better idioms in a certain language that may not exist in other languages is one of the most helpful things linters can do for beginners in that language. So I support the rule.


Exercise 8 where is the mixer rule?

istioctl create -f mixer-rule-denial.yaml But there's no yaml. Is the user supposed to create it? If so, clarify that in steps. And have the YAML as part of the create step.
Also, seems like it'd be worthwhile to just go ahead and include the file in the GH repo.

Andy, can you check it out?

Closing per @nilesh32's request


AppVeyor: Upload compiled binary to transfer.sh for testing purposes

This makes it easier for users to test pull requests, without having to fiddle with Git and compile the engine from source. Users can now download the executable referenced at the end of the CI log up to 14 days after the CI build was completed.
If the link expires, the job can be run again to compile a new build.
If people like the idea, I'll try to do this for other platforms as well.
Example build log
Example compiled build (64-bit Windows editor, release_debug) (link valid until 2020-05-07)

FWIW, I downloaded and tested the build and it seems to run fine. (Well, as fine as master currently does :P)
The project manager opens fine on Windows.

Superseded by #38625.

That being said the artifact naming from this PR is better, so feel free to build upon #38625 to make it nicer.

@akien-mga You are right, the naming could be better, i have made a PR to follow the naming format used in this PR. Thank you for the suggestion.
https://github.com/godotengine/godot/pull/38661


GH-244 - Extensible source support (#245)

Fix #244
(complete PR checks for #245 from @auniverseaway before merging to main)

@dylandepass @rofe do you need anything else from me? Do I need to fix the -0.05% coverage somehow?

@auniverseaway I think we're good here. Diff coverage is 100%, so no worries.


Feature request: Add next and previous sources and target (For rotary buttons)

Hi Nico,
Thanks again for this great module and the last updates ! We just got a Streamdeck + in our setup and I was interested by adding  rotary buttons to navigate between sources and targets. Unfortunatly, unless I've missed a feature, we could only select a specific source and target. Would it be an option to implement Next/Previous sources and targets in video and audio ?
Kind regards
Dorian

Thank you very much Nico, looking forward to test this feature !


[BUG]: Embeddable Chat Widgets：Error: Cannot read properties of undefined (reading 'create')

How are you running AnythingLLM?
Local development
What happened?
Cannot read properties of undefined (reading 'findMany')
Cannot read properties of undefined (reading 'findMany')
Cannot read properties of undefined (reading 'findMany')
Cannot read properties of undefined (reading 'create')

Are there known steps to reproduce?
No response

The issue has been resolved, sorry for the disturbance, thank you.


How does the batching works in react plugin?

I have a react app + AI react plugin setup.
The page I am looking at have one fetch API call.
After page rendered, I saw 3 post request send to AI:

"PageViewData": duration: "00:00:00.000".
"PageViewData":  duration: "00:00:01.279".
"RemoteDependencyData".

Is this the correct behavior with maxBatchInterval of 15 seconds?
PS:
I added a test to send custom message to AI in componentDidmount 100 times, they do got batched before send to AI.

The first PageView item from the onload event is sent right away. Afterwards, we batch items and flush either every 15 seconds or when the maximum batch size is reached. We also flush when the tab is closed.

Does the Network Dependency Requests been sent seperately?


Fix duplicate value in Browsersync files Array

The two same values get concatenated. A console.log output of watcherConfig in webpack.plugin.browsersync.js :
{
  host: 'localhost',
  port: '3000',
  proxy:
   { target: 'https://example.dev',
     middleware: [ [Object], [Object] ] },
  files:
   [ 'templates/**/*.php',
     'src/**/*.php',
     'templates/**/*.php',
     'src/**/*.php' ]
}

Yeah, I fixed this last week locally, but I haven't pushed it yet since there are still a few other things I'm working on. Thanks for the PR.


Swiftlint fails build with swift 4.1

I believe this is the issue https://github.com/realm/SwiftLint/issues/2028

Job gh:blockstoreapp/web3swift#103 is not assigned, can't get performer


ERROR in The target entry-point "@covalent/echarts/base" has missing dependencies

I got this error,, I am using the latest 3.0.0 version.
I've clean installed and setup with Covalent. double checked my AppModule in terms of Covalent modules.
ERROR in The target entry-point "@covalent/echarts/base" has missing dependencies:
 - echarts/lib/echarts
 - zrender/lib/svg/svg

  // Covalent Modules
   CovalentLayoutModule,
   CovalentStepsModule,
   CovalentHttpModule.forRoot(),
   CovalentHighlightModule,
   CovalentMarkdownModule,
   CovalentDynamicFormsModule,
   CovalentBaseEchartsModule,

 ],
 providers: [
   AppSettings,
 ],
 bootstrap: [AppComponent]
})
export class AppModule { }

Angular CLI: 9.1.0
Node: 12.16.1
OS: darwin x64
Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes
Package                           Version
@angular-devkit/architect         0.900.7
@angular-devkit/build-angular     0.901.0
@angular-devkit/build-optimizer   0.901.0
@angular-devkit/build-webpack     0.901.0
@angular-devkit/core              9.1.0
@angular-devkit/schematics        9.1.0
@angular/cdk                      9.2.0
@angular/fire                     5.4.2
@angular/flex-layout              9.0.0-beta.29
@angular/material                 9.2.0
@ngtools/webpack                  9.1.0
@schematics/angular               9.1.0
@schematics/update                0.901.0
rxjs                              6.5.4
typescript                        3.8.3

The library has dependencies with echart and zrender.
so, I found a solution.
npm i echarts --save
npm install --save @types/echarts <--optional
npm i zrender
npm i @types/zrender  <--optional

@curiouscod3 are the ones marked ** optional?

@curiouscod3 are the ones marked ** optional?

Exactly !

closing as the current version of Covalent Echarts has echarts as dev dependency. zrender is no longer required


Set handling of special tokens in tokenizer to true

Fixes #45

Thanks for the pull request! I changed it slightly to keep the default behavior, but allow to set tokenize_special via the InferenceParameters like:
InferenceParameters inferParams = new InferenceParameters().setTokenizeSpecial(true);
// ...
model.generate(prompt, inferParams)

Thanks, though I wonder why one would ever not want to tokenize these special tokens if the model has them. The whole point of adding these "special" tokens is to treat a sequence as a single token as I understand it. Moving this to the inference parameters puts the burden on the user of the library and since I was looking for the issue for a few hours, I suspect this isn't obvious for anyone encountering the same.

I agree, per default most users will want to tokenize these tokens. My reasoning was to stick to the default behavior of llama.cpp, where the parameter is false by default. I guess it's useful if you want to talk about those tokens as if they were text (or get answers containing them), without triggering their special functionality. I'll change the default to true in the Java binding, though.

Changing the default is a good solution! Thanks again 😁


PDF Export with dark variant

Hi,
I really like this theme (I use the dark variant).
The only thing that bothers me is its look in exported PDFs.
Is it possible to optimize this?

Could you be more specific？

Sure, I created this page in Obsidian, but exported the code blocks are really hard to read.

This is indeed a bit of an issue, I didn't notice it before. If I have the time, I will fix it as soon as possible. As a temporary solution, you can switch to the light mode to export the PDF, and the results should be the same.

Fixed in Obsidian v1.2.8.


[Support RTL] Material v5

Hi,
I use RTL according to the instructions here: https://next.material-ui.com/guides/right-to-left/#jss
on v4 => Worked
https://codesandbox.io/s/material-demo-forked-pnkgk?file=/demo.js
on v5 => Not working for margin
https://codesandbox.io/s/containedbuttons-material-demo-forked-j5y8t?file=/demo.js
Is this a bug or feature change on v5?

You didn't configure JSS as mentioned in the documentation

I have tried, but no luck seems:
// Worked with classes

const useStyles = makeStyles((theme) => ({
  root: {},
  button: {
    marginRight: theme.spacing(10)
  }
}));

   <Button variant="contained"> Test 1</Button>
   <Button variant="contained" color="secondary">Test 2</Button>

// Not working with emotion
    <Box sx={{ display: "flex" }}>
        <Button variant="outlined" sx={{ mr: 10 }}>
          Test 1
        </Button>
        <Button variant="outlined" sx={{ mr: 10 }}>
          Test 2
        </Button>
      </Box>

https://codesandbox.io/s/containedbuttons-material-demo-forked-tgyuc?file=/index.js
Let me know where I went wrong, Thanks!

Don't use StyledEngineProvider with CacheProvider playground. StyledEngineProvider is the same cache provider but plus you need to configure the cache
const cacheRtl = createCache({
  key: "css",
  prepend: true,
  stylisPlugins: [rtlPlugin]
})

Documentation tells you https://next.material-ui.com/guides/migration-v4/#styled-engine how to use custom cache.

@povilass Looks like it worked, Thank you!

@povilass
Sorry for bothering you, I just found out,
When  theme: direction LTR, emotion auto-apply attribute for LTR
https://codesandbox.io/s/containedbuttons-material-demo-forked-7efdy?file=/index.js

@mtr1990 no worries just glad to help it is not bothering,

Hi @povilass ,
It doesn't seem to work emotion: https://codesandbox.io/s/containedbuttons-material-demo-forked-7efdy?file=/index.js
When theme: direction LTR (default), emotion auto-apply attribute for LTR
Can you help me with this problem? Thank so much

@mtr1990 The problem and solution seems self-explanatory, you need to use two different cache emotion.

Looks like I have a solution to this problem,
Hope to be able to help someone
import * as React from "react";
import ReactDOM from "react-dom";
import Demo from "./demo";
import { CssBaseline } from "@material-ui/core";
import {
  jssPreset,
  ThemeProvider,
  createMuiTheme,
  StylesProvider
} from "@material-ui/core/styles";
import rtl from "jss-rtl";
import { create } from "jss";
import rtlPlugin from "stylis-plugin-rtl";
import { CacheProvider } from "@emotion/react";
import createCache from "@emotion/cache";

document.body.setAttribute("dir", "ltr");

const jss = create({
  plugins: [...jssPreset().plugins, rtl()]
});

const theme = createMuiTheme({
  direction: "ltr"
});

const cacheRtl = createCache({
  key: "css",
  prepend: true,
  stylisPlugins: theme.direction === "rtl" && [rtlPlugin]
});

console.log(theme.direction);

ReactDOM.render(
  <ThemeProvider theme={theme}>
    <CacheProvider value={cacheRtl}>
      <StylesProvider jss={jss}>
        <CssBaseline />
        <Demo />
      </StylesProvider>
    </CacheProvider>
  </ThemeProvider>,
  document.querySelector("#root")
);

https://codesandbox.io/s/containedbuttons-material-demo-forked-7efdy?file=/index.js:0-1081

I seem to have solved the problem hoping I can help someone else

import * as React from "react";
import ReactDOM from "react-dom";
import Demo from "./demo";
import { CssBaseline } from "@material-ui/core";
import {
  jssPreset,
  ThemeProvider,
  createMuiTheme,
  StylesProvider
} from "@material-ui/core/styles";
import rtl from "jss-rtl";
import { create } from "jss";
import rtlPlugin from "stylis-plugin-rtl";
import { CacheProvider } from "@emotion/react";
import createCache from "@emotion/cache";

document.body.setAttribute("dir", "rtl");

const jss = create({
  plugins: [...jssPreset().plugins, rtl()]
});

const theme = createMuiTheme({
  direction: "rtl"
});

const cacheRtl = createCache({
  key: "css",
  prepend: true,
  stylisPlugins: theme.direction === "rtl" && [rtlPlugin]
});

console.log(theme.direction);

ReactDOM.render(
  <ThemeProvider theme={theme}>
    <CacheProvider value={cacheRtl}>
      <StylesProvider jss={jss}>
        {/* ---------- */}
        <CssBaseline />
        <Demo />
        {/* ---------- */}
      </StylesProvider>
    </CacheProvider>
  </ThemeProvider>,
  document.querySelector("#root")
);

https://codesandbox.io/s/containedbuttons-material-demo-forked-7efdy?file=/demo.js


Did you provide the best model in the paper?

I use the model that you provided , but I don't get the same results as your paper

can you answer my question ?  I would really appreciate it.


<EMAIL_ADDRESS>hash check failed

WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
Installing 'go' (1.11) [64bit]
Loading go1.11.windows-amd64.zip from cache.
Checking hash of go1.11.windows-amd64.zip ... ERROR Hash check failed!
App:         go
URL:         https://storage.googleapis.com/golang/go1.11.windows-amd64.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    29f9291270f0b303d0b270f993972ead215b1bad3cc674a0b8a09699d978aeb4
Actual:      0ca155b3554a58511c96529d368817adaf5ffa1a84a719f7ca4a16e77b627866

29f9291270f0b303d0b270f993972ead215b1bad3cc674a0b8a09699d978aeb4 is correct.
Please try again.

All good, it works now.


Enhancing cosing attach signature command to include RFC3161 Timestamp response

Description
The existing cosign attach command does not support passing RFC3161Timestamp response from TSA as an argument. The cosing attach command should be enhanced to support attachment of the TSA response  along with existing functionality to attach signature, certificate and certificate chain.
This functionality will help the Private CA use case of cosign where cosign uses which want to use a Private PKI to sign the content would also be able to attach the Trusted TSA response for the generated Signature. so that Certificate validity can be checked with the Trusted signature Time stamp and short lived certificates can be generated for code signing.
The existing cosign attach command is as below. i would like to contribute for this enhancement. in cosign code.
Attach signatures to the supplied container image
Usage:
cosign attach signature [flags]
Examples:
cosign attach signature
Flags:
--allow-http-registry                                                                      whether to allow using HTTP protocol while connecting to registries. Don't use this for anything but testing
--allow-insecure-registry                                                                  whether to allow insecure connections to registries (e.g., with expired or self-signed TLS certificates). Don't use this for anything but testing
--attachment-tag-prefix [AttachmentTagPrefix]sha256-[TargetImageDigest].[AttachmentName]   optional custom prefix to use for attached image tags. Attachment images are tagged as: [AttachmentTagPrefix]sha256-[TargetImageDigest].[AttachmentName]
--certificate string                                                                       path to the X.509 certificate in PEM format to include in the OCI Signature
--certificate-chain string                                                                 path to a list of CA X.509 certificates in PEM format which will be needed when building the certificate chain for the signing certificate. Must start with the parent intermediate CA certificate of the signing certificate and end with the root certificate. Included in the OCI Signature
-h, --help                                                                                help for signature
--k8s-keychain                                                                             whether to use the kubernetes keychain instead of the default keychain (supports workload identity).
--payload string                                                                           path to the payload covered by the signature (if using another format)
--signature string                                                                         path to the signature, or {-} for stdin
Global Flags:
--output-file string   log output to a file
-t, --timeout duration     timeout for commands (default 3m0s)
-d, --verbose              log debug output

CC @haydentherapper @malancas for TSA

I'm supportive of this!

I have done the changes needed for the Issue. i cloned the cosign project and create a new branch  MukulAddCmdChange
$ git status
On branch MukulAddCmdChange
Changes to be committed:
(use "git restore --staged ..." to unstage)
modified:   cmd/cosign/cli/attach.go
modified:   cmd/cosign/cli/attach/sig.go
modified:   cmd/cosign/cli/options/attach.go
modified:   doc/cosign_attach_signature.md
modified:   test/e2e_test.go
modified:   test/e2e_test_attach.sh
new file:   test/testdata/test_attach_freetsacacert.pem
but when i am trying to push my changes to origin i am getting following issue
musharma@N-20S1PF2LWWHM MINGW64 ~/cosign (MukulAddCmdChange)
$ git push -u origin MukulAddCmdChange
remote: Permission to sigstore/cosign.git denied to Mukuls77.
fatal: unable to access 'https://github.com/sigstore/cosign.git/': The requested URL returned error: 403

I have tried many thing like clearing the credentials from window manager for github site.
creating a new github account. but noting is working.
can you pls suggest what can be the issue here why i am getting 403 response when i try to push my changes.

I have created the Pull request to cover this issue
https://github.com/sigstore/cosign/pull/3001

@haydentherapper @malancas can you pls review the PR created to close this issue.
https://github.com/sigstore/cosign/pull/3001

This issue can be resolved now as the mentioned PR covering this issue has been approved


Make peer & dev builds leaner by excluding unnecessary PDO dependencies

What this PR does / why we need it:
Subject says it all (mostly: the excluded dependencies are micro-wasm and, in particular, CCF ....)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?:

Thanks Michael! I think it's a good idea to strip out unneeded (sub)submodules from PDO. What I don't like so much is that we expose this to the user in the readme as most people will don't understand it and eventually just copy and paste the git clone without excluding them. I think for the users, the git clone is an one time action whereas in our docker setup, which we will also use for CI, this checkout is performed more often, so it makes sense to make it more lightweight.

Keeping the command simple and just give the additional space-saving info for whoever cares afterwards was my original approach to deal with that.  But as also Morgan didn't really like it, i'll just remove the note paragraph from the README.  I guess the smart user who cares might figure it out also from the Dockerfile which he might anyway consult to figure out how to install dependencies :-)

Maybe there is an easy way to just prevent all subsubmodules from checkout?

I couldn't find anything clean & easy. This was the best i found.  The shallow-submodule will still check out all submodules but the amount checked out should be indeed leaner.  From a peer image perspective you could even do a shallow check out of fpc proper (see comment in dockerfile) but that doesn't seem what you want from the dev container and for symmetry perspective i kept them the same ...

Within docker I dont see an issue excluding the subsubmodulse as you propose.

@g2flyer I missed the fixup and just wanted to update the branch and merge it. sorry. Can you please do the squash/rebase and I will merge.


Replace special symbol characters with other characters to allow them to be drawn as mermaid

resolves https://github.com/datnguye/dbterd/issues/81

Description
Mermaid may not be able to render special characters. To deal with such cases, we have made changes to replace or omit special characters.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

LGTM for the code changes, thanks for your proactive contribution so far @syou6162 ❤
I will create v1.11.0b1 right after this gets merged


Exceptions can block forever when minConnections is set to 1 [JIRA: CLIENTS-501]

As reported by @hankipanky on the riak-users mailing list.

I've reported in the past that my application is seeing stange exceptions when running under even the slightest load (riak-users discussion)
The observation is that some threads simply hang when this exception occurs, waiting for ever without understanding what is going on. This unreliability is very bad for my application where a lot of Riak-related tasks are handled in Threads in the background.
I keep trying to find out what is causing this, but I have no real clue. But after playing around with RiakNode.Builder.min/maxConnections, the problem does not occur anymore.
Specifically, I have now set:
RiakNode riakNode = new RiakNode.Builder()
  .withConnectionTimeout(5000)
  .withMinConnections(2)
  .withMaxConnections(16)
  .withIdleTimeout(500)
  .withBlockOnMaxConnections(false)
  .withRemoteAddress(Config.getInstance().getRiakAddress())
  .withRemotePort(Config.getInstance().getRiakPort())
  .build();

If I leave minConnections at 1, the problem occurs, reproducibly. With higher values, it doesn't.
Is there maybe an issue in the code? Are connections reaped too quickly?
Cheers,
Henning

FYI I can still see this with riak-client 2.0.2.

Hi @hankipanky,
This appears to be a connection/thread contention issue / race condition when you are doing UpdateValue commands in combination with having only a few connections available. Basically we're doing a no-no and trying to run a blocking operation on the Netty worker thread.

Netty runs our Update Operation, and calls our response listener from the Netty worker thread.
We get our Fetch half the Update operation, update the object, and try to store it back (Note that we're still on the Netty Worker Thread).

We were able to get a permit, and try to get a connection, but in the process we block our Netty Worker Thread:  https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/core/RiakNode.java#L671

Netty notices that we did that and throws a BlockingOperationException.

Since it's on the Netty thread, the exception will never show up on the thread where you're waiting for your UpdateOperation to complete on.
Do you use "block on max connections" at all?  What's your maxconnections setting set to?
Thanks,
Alex

Hi Alex,
thanks for your response.

Do you use "block on max connections" at all? What's your maxconnections setting set to?

Initially I observed the issue sporadically, when connecting with default values:
	RiakNode riakNode = new RiakNode.Builder()
	  .withConnectionTimeout(5000)
	  .withRemoteAddress(Config.getInstance().getRiakAddress())
	  .withRemotePort(Config.getInstance().getRiakPort())
	  .build();

I noticed lowering maxConnections produces the error faster, which is what I am using it for. Is there a recommendation to ever set maxConnections?
(FYI, I'm not sure if this is relevant: Currently I've only ever run this code against a single-node Riak-Cluster running on the same development box. Eventually it will run against multi-node clusters.)
I don't need blockOnMaxConnections(true). My application is expecting operations to fail at any moment, which is why I am so confused. Calling RiakClient.execute(), I expect either a response or an exception. From the javadoc:

Execute a RiakCommand synchronously.
Calling this method causes the client to execute the provided RiakCommand synchronously. It will block until the operation completes then either return the response on success or throw an exception on failure.

But the observation is that my thread waits forever for the operation to complete.

Since it's on the Netty thread, the exception will never show up on the thread where you're waiting for your UpdateOperation to complete on.

Is this an issue in the riak-java-client?
Am I doing something wrong?
Thanks, Henning

Hi Henning,
Sorry for the delay.

Is this an issue in the riak-java-client?

Yes.

Am I doing something wrong?

Probably not.

I noticed lowering maxConnections produces the error faster, which is what I am using it for. Is there a recommendation to ever set maxConnections?

You should set maxConnections if you need to tightly control the number of connections to your Riak Cluster (network reasons), or if your clients are overloading the cluster with too many connections.
SideNote - With the overload scenario Riak would refuse connections once it's limit is reached, or it would start giving out overload errors.  This would be symptom of too many long-running operations, or an underprovisioned cluster. We're not seeing this here though :smiley:.

But the observation is that my thread waits forever for the operation to complete.

Yes, this is what the bug is.  An UpdateValue Command is really 2 commands put in one: a fetch, and then a store. We receive the fetch response in a piece of code that runs on Netty's threads, and then try to open a connection for the store in that same thread.
If we are out of connections at that very moment, the thread will block, which causes Netty to throw a BlockingOperationException.  This exception blocks the Netty thread, and never gets back to the user thread, so the future never completes.
I'm still looking into the best way to fix this, but for now you could try increasing your min connections more, or avoiding UpdateValue commands.
Thanks,
Alex

@hankipanky Do you still have the code to replicate this behavior?  Looking to get a fix in for this soon and having trouble making Netty do bad things :)

Hi Alex,sorry, am on vacation at the moment.On 10.11.2015, at 18:42, Alex Moore<EMAIL_ADDRESS>wrote:@hankipanky Do you still have the code to replicate this behavior?  Looking to get a fix in for this soon and having trouble making Netty do bad things :)—Reply to this email directly or view it on GitHub.

                                                                                Hi Alex,Sorry am on vacation at the moment, i'll check the code when I get back. Sorry for the double posting. Cheers, Hank                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: Alex MooreSent: Dienstag, 10. November 2015 21:42To: basho/riak-java-clientReply To: basho/riak-java-clientCc: Henning VerbeekSubject: Re: [riak-java-client] Exceptions can block forever when minConnections is set to 1 [JIRA: CLIENTS-501] (#523)@hankipanky Do you still have the code to replicate this behavior?  Looking to get a fix in for this soon and having trouble making Netty do bad things :)

—Reply to this email directly or view it on GitHub.

Hi guys,
We are seeing that same behavior in our application. Is there any update on this issue?
I don't have code to reproduce the issue in isolation yet, but I would gladly try to help if you have time to solve this.
Thanks,
Sebastian.


Can't docker run java project image which used jlink tool: Permission denied, unknown error

Environment:

Jib version: jib core version 0.14.0
*Build tool: I can't find anything to use scratch base image with gradle plugin
OS: Manjaro Arch based linux

Description of the issue:
I can't docker run java project image which used jlink tool. Permission denied, unknown error gives when run executable file.
Expected behavior:
Steps to reproduce:

Add the gradle dependency to this example
compile group: 'com.google.cloud.tools', name: 'jib-core', version: '0.14.0'
Run following task

task dojib {
        def builder = Jib.fromScratch()
        builder.setEntrypoint("/bin/demo")
        builder.setCreationTime(Instant.now())

        builder.addFileEntriesLayer(FileEntriesLayer.builder().addEntryRecursive(Path.of("$buildDir/image/cp"), AbsoluteUnixPath.get('/cp')).build())
        builder.addFileEntriesLayer(FileEntriesLayer.builder().addEntryRecursive(Path.of("$buildDir/image/bin"), AbsoluteUnixPath.get('/bin')).build())
        builder.addFileEntriesLayer(FileEntriesLayer.builder().addEntryRecursive(Path.of("$buildDir/image/conf"), AbsoluteUnixPath.get('/conf')).build())
        builder.addFileEntriesLayer(FileEntriesLayer.builder().addEntryRecursive(Path.of("$buildDir/image/legal"), AbsoluteUnixPath.get('/legal')).build())
        builder.addFileEntriesLayer(FileEntriesLayer.builder().addEntryRecursive(Path.of("$buildDir/image/lib"), AbsoluteUnixPath.get('/lib')).build())

        builder.containerize(Containerizer.to(DockerDaemonImage.named("example")))
}

Run the docker image which named "example" and see the error.

Log output:
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"/bin/demo\": permission denied": unknown.
ERRO[0000] error waiting for container: context canceled

Hi @ceyhunn,
I didn't look into the sample repo, but I think at least you should set executable bits when adding $buildDir/image/bin?
builder.addEntryRecursive(Path.of("$buildDir/image/bin"), AbsoluteUnixPath.get('/bin'),
                          (source, target) -> FilePermissions.fromOctalString('755'))

BTW, I just realized an unrelated issue when adding the jib-core dependency: #2507.

Hi @chanseokoh , thank you very much, it worked. However jib became useless for me, because jlink launcher depends on glibc, zlib, stdc++ libraries. Jib doesn't support custom run command, I need to use dockerfile.

Thanks for the update. Just FYI and for future documentation:
Jib Core is a general tool to build a container image, so I am certain you can create a working image as long as you supply the right runtime libraries or use the right base image that already contains the libraries from the right OS/architecture. Even with the Jib Maven plugin (not Jib Core), I was able to build a working jlink application with some tweak and tricks.

Also note it'll be really arduous to create any working image from "scratch", much like the "scratch image" in Dockerfile. Most like you'll start from some base image.
def builder = Jib.fromScratch()


Add request signature support

This pull request adds request signing/signature support to all requests made via the Gigya JS SDK. The specific functionality is that a signature is calculated and included in the request for any request that does not include a user secret.

hi, you can review this instead:
https://github.com/scotthovestadt/gigya/pull/40


Custom loss function

Hi, thank you for sharing this impressive work! I have a question: how can I train the model using a custom loss function that compares the generated image with the ground truth? Thank you in advance.

Hi
We based our diffusion model on this work Diffusion Models beat GANs. There the loss function is defined as an MSE loss between added and predicted noise. It has shown to be stable.
If you still want to change it, you can change it here


Little rename of func

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Fixes #

Proposed Changes

little func rename

Release Note

Docs

/retest


Document how to deploy Submariner on Air-gapped clusters

Submariner now has all the necessary changes merged to support air-gapped clusters. We can have a dedicated page on the website with notes to help users be aware of the changes that would be necessary and the flags to be passed while installing/running various submariner commands.

Capture the list of submariner images that needs to be pre-loaded.

It might be worth adding a command to subctl to list the images, since it knows about them anyway.

Also document how users can deploy KIND clusters in an air-gapped (simulated) env.
make deploy using=air-gap

Talking with @sridhargaddam, since most of the steps are common between the two deploy paths, we don't seem to need a dedicated page and the using=air-gap docs are sufficient.


Draw overload for VertexBuffer is missing

There seems to be no draw overload for VertexBuffer.
I took the liberty to try to fix it with #21.

No, nimble installs the latest release (or tag really) which is still old

I see. When can I expect the next one?


add travis configuration file

Please also enable Travis-CI at https://travis-ci.org/

Merged, and enabled! Many thanks!


Provider Error when creating batch of content types

I am seeing this error message when using the provider to create a batch of content type at the same time.

creating them, like, 3-5 at a time, they all work


GitHub Actions for tests

Run builds and tests in GitHub Actions instead of Travis-CI

Since the lower-level SQLite functions need a 32-bit integer, we’re stuck dealing with it. I'd prefer to cast the vector-length to int in 2 places than do the other approach. We could even raise an error on the Scheme side if the length is too large, but I don't think this is necessary given the limit of 2^31-1.

Thanks for the updates, Bob! Looks good to me.


Non-latin TOC does not work on github

Links in the generated table of contents do not work on github but do work in preview.

This is an example of a header and generated TOC:
- [Краткое содержание курса](#%D0%BA%D1%80%D0%B0%D1%82%D0%BA%D0%BE%D0%B5-%D1%81%D0%BE%D0%B4%D0%B5%D1%80%D0%B6%D0%B0%D0%BD%D0%B8%D0%B5-%D0%BA%D1%83%D1%80%D1%81%D0%B0)

# Краткое содержание курса

No, since the error doesn't appear locally.
I saw several issues related to non-latin TOC (#11, #34) but unfortunately they were written in chinese and I couldn't understand why they were closed.

The non-latin characters are escapsed when encoding into URL, so you see many %D0 etc.
It works in vscode because the preview is generated exactly in this way.
I then tested the generated HTML in different browsers, finding that it is the problem of browser.
Micosoft Edge ✘
Google Chrome ✓
So I would suggest using other browsers which support this kind of anchors.

Hmm. Generated HTML does indeed work in Chrome but the problem is not in generated HTML.
I pushed a repo with README.md to github and there TOC doesn't work even in Chrome.
Similar links with escaped encoding from wikipedia are working.

Could you provide some sample codes? I just tested some Chinese characters and the toc link works well.

I created a repo with a sample readme.md file - https://github.com/Amomum/test_TOC
I tried it in firefox and chrome and latin-only links in the TOC work while cyrillic do not.

I will introduce an option encodeUrl later

Thank you :)

Please try v1.1.0

Something broke really good in v1.1.0; now I can't do anything - hitting Enter gives me a warning command markdown.extension.onEnterKey not found. Hitting backspace gives a similar warning.
Creating TOC gives an error command markdown.extension.toc.create not found.
I tried installing and reinstalling several times with no success.

You need to update vscode to v1.21.0 because of the API change.

My bad, I'm too used to vscode suggesting to update every five minutes. Commands work now.
However, when I tried to recreate TOC for my example, it generated exactly the same TOC, git diff showed no changes.
I  added another header to force a change and pushed it; unfortunately, links with cyrillic symbols still do not work in firefox or chrome:
https://github.com/Amomum/test_TOC

I guess you forgot the newly introduced setting encodeUrl. You need to change it to false then your text won't be encoded 😉

Oh my god, I'm sorry -_-'
However, I changed encodeUri (i guess you meant encodeUri, not encodeUrl?), TOC changed - there is no more percent encoding in cyrillic links.
But they still don't work. What am I missing now? :)

That's strange. Have you pushed your change to GitHub?
It works if I manually edit the HTML code on https://github.com/Amomum/test_TOC
(e.g. ... -> ...)

I did the push, raw file shows no percent-encoding - https://raw.githubusercontent.com/Amomum/test_TOC/master/README.md

I thought maybe github was playing some caching games and did a push to another repo - results are the same: https://github.com/Amomum/test_TOC2

Oh, it seems that you find a GitHub bug!
Open https://github.com/Amomum/test_TOC/blob/master/README.md#Ляляля -> works well (jumps to the right place)
Then the url is auto changed to https://github.com/Amomum/test_TOC/blob/master/README.md#%D0%9B%D1%8F%D0%BB%D1%8F%D0%BB%D1%8F by Chrome. -> still works well
The problem is that the link in TOC (which is encoded by GitHub) is https://github.com/Amomum/test_TOC/blob/master/README.md#%D0%BB%D1%8F%D0%BB%D1%8F%D0%BB%D1%8F -> of course it doesn't work
Now the "spot the difference" game
#%D0%9B%D1%8F%D0%BB%D1%8F%D0%BB%D1%8F
#%D0%BB%D1%8F%D0%BB%D1%8F%D0%BB%D1%8F
Do you see? 😂

Oh dear :) Uppercase letter Л changed to lowercase л. Hmm. I guess I will report this to github then :)
Thanks for  help!

Good luck


Error connecting to Docker Postgres

I've tried to add MCP Postgres server, however got issue while trying with Claude
Error

2024-11-26T23:31:11.185Z [error] Could not start MCP server postgres: Error: spawn npx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [Array]
}

Config

{
  "mcpServers": {
    "postgres": {
      "command": "npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-postgres",
        "postgresql://postgres:postgres@localhost:5432/bounce_persistence_dev"
      ]
    }
  }
}

➜  ~ which npx

/Users/fanilo/.asdf/shims/npx

Check

and I confirm that db was running with
psql postgresql://postgres:postgres@localhost:5432/mydb

Ok fixed.
I'll let the issue open for others
Solution (MacOs)
sudo mkdir -p /usr/local/bin

➜  ~ sudo ln -s /Users/YOUR_USER/.asdf/shims/npx /usr/local/bin/npx

Per https://github.com/modelcontextprotocol/servers/issues/40#issuecomment-2511901524, issues with npx on Windows should now be resolved. Please comment on that issue if the fix doesn't work for you.


Exceptions now being sent back to publisher

Allow the consuming Nakadi Source to be able to handle errors that may occur. For example:
Source
  .watchTermination() { (_, fut) =>
    fut.recover {
      case err => println(s"recover error: $err")
    }
  }
  .fromPublisher(publisher)
  .map(someProcessingOfMessage)
  .to(Sink.fromSubscriber(subscriber))
  .run()

Coverage decreased (-1.3%) to 57.246% when pulling d27e39fcc40176d9be522c7c02c69ac7f42f8fa2 on propigating-exceptions into d42be5036f3a0725e632cd885723b901de944171 on master.


Ability to remove more than one stopped container

From @abuehrle on January 12, 2017 18:26
Would be useful if you could select more than one stopped container and remove them all at once.
Copied from original issue: weaveworks/service#1065

This is similar to #1519. Here the idea is to manually select a number of containers and then 'remove' them with one action, whereas in #1519 the selection is "hard-coded" by the grouping.
There are some obvious generalisations here:

topologies other than containers
actions other than 'remove'


Import Functionality

The root server class should take args to create a live, running, instance. This will be the only importable piece for third party software.
This way, someone else's script could do work to figure out HOW to instantiate the server, ?and add middleware as necessary?.

Let's get amwebs to compile to a single JS file: will make importing the ONE class we want 3rd party software importing easier for consumers.


Gatecoin async fetch_balance problem

Hi, using version 1.8.98 on Python 3.6, I am getting the following error when calling the async fetch_balance function for Gatecoin
Unclosed connection
client_connection: Connection<('api.gatecoin.com', 443, True)>
must be str, not bytes

Hi!
Please, read this:

https://github.com/ccxt-dev/ccxt/wiki/Manual#troubleshooting ?
https://github.com/ccxt-dev/ccxt/blob/master/CONTRIBUTING.md#how-to-submit-an-issue

Basically, 443 means rate-limiting or DDoS Protection.
Can you try a proxy to see if it replies with the same result?
When instantiating your Gatecoin instance, pass a proxy param along with your credentials like so:
gatecoin = ccxt.gatecoin ({
    'apiKey': 'YOUR_API_KEY',
    'secret': 'YOUR_SECRET',
    'proxy': 'https://cors-anywhere.herokuapp.com/',
})
print(gatecoin.fetch_balance())

Can you paste the output of the above snippet here?

Hi yes it did seem that using the proxy produced the same 443 error.
Using the code snippet you have posted above, I get the following output
C:\Python36\python.exe C:/Users/Administrator/PycharmProjects/xx.py
https://cors-anywhere.herokuapp.com/https://api.gatecoin.com/Public/LiveTickers GET https://cors-anywhere.herokuapp.com/https://api.gatecoin.com/Public/LiveTickers
Request: {'User-Agent': 'ccxt/1.8.98 (+https://github.com/kroitor/ccxt) Python/3.6.2', 'Origin': '*', 'Accept-Encoding': 'gzip, deflate'} None
Traceback (most recent call last):
  File "C:/Users/Administrator/PycharmProjects/xx.py", line 28, in <module>
    print(gatecoin.fetch_balance())
  File "C:\Users\Administrator\PycharmProjects\xx.py", line 10360, in fetch_balance
    self.load_markets()
  File "C:\Users\Administrator\PycharmProjects\xx.py", line 656, in load_markets
    markets = self.fetch_markets()
  File "C:\Users\Administrator\PycharmProjects\xx.py", line 10341, in fetch_markets
    response = self.publicGetPublicLiveTickers()
  File "C:\Users\Administrator\PycharmProjectsxxs.py", line 10531, in request
    response = self.fetch2(path, api, method, params, headers, body)
  File "C:\Users\Administrator\PycharmProjects\xx.py", line 220, in fetch2
    return self.fetch(request['url'], request['method'], request['headers'], request['body'])
  File "C:\Users\Administrator\PycharmProjects\xx.py", line 273, in fetch
    print(method, url, "\nResponse:", response.info().headers, decoded_text)
AttributeError: 'HTTPMessage' object has no attribute 'headers'

Process finished with exit code 1

@md0101 ok, thank for reporting back. Now, I suggest, let's debug it a little... First, let's try a second proxy:
gatecoin = ccxt.gatecoin ({
    'proxy': 'https://crossorigin.me/',  # another proxy
    'verbose': True,
})
print(gatecoin.load_markets())  # the most basic method

Does the above snippet work?
What country are you from?
Is trading with Gatecoin website currently accessible to you?

I'll stand by for your reply and we will go on with troubleshooting it.

Great thank you.
Just conducted a successful trade via their website so no issues there.  I am based in the UK and with your basic method and alternative proxy, I get this output
C:\Python36\python.exe C:/Users/Administrator/PycharmProjects/ccxt/test.py
https://crossorigin.me/https://api.gatecoin.com/Public/LiveTickers GET https://crossorigin.me/https://api.gatecoin.com/Public/LiveTickers
Request: {'User-Agent': 'ccxt/1.8.98 (+https://github.com/kroitor/ccxt) Python/3.6.2', 'Origin': '*', 'Accept-Encoding': 'gzip, deflate'} None
Traceback (most recent call last):
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchange.py", line 251, in fetch
    response = opener.open(request, timeout=int(self.timeout / 1000))
  File "C:\Python36\lib\urllib\request.py", line 526, in open
    response = self._open(req, data)
  File "C:\Python36\lib\urllib\request.py", line 544, in _open
    '_open', req)
  File "C:\Python36\lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "C:\Python36\lib\urllib\request.py", line 1361, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "C:\Python36\lib\urllib\request.py", line 1321, in do_open
    r = h.getresponse()
  File "C:\Python36\lib\http\client.py", line 1331, in getresponse
    response.begin()
  File "C:\Python36\lib\http\client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "C:\Python36\lib\http\client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "C:\Python36\lib\socket.py", line 586, in readinto
    return self._sock.recv_into(b)
  File "C:\Python36\lib\ssl.py", line 1002, in recv_into
    return self.read(nbytes, buffer)
  File "C:\Python36\lib\ssl.py", line 865, in read
    return self._sslobj.read(len, buffer)
  File "C:\Python36\lib\ssl.py", line 625, in read
    v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:/Users/Administrator/PycharmProjects/ccxt/test.py", line 16, in <module>
    print(gatecoin.load_markets())  # the most basic method
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchange.py", line 656, in load_markets
    markets = self.fetch_markets()
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchanges.py", line 10341, in fetch_markets
    response = self.publicGetPublicLiveTickers()
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchanges.py", line 10531, in request
    response = self.fetch2(path, api, method, params, headers, body)
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchange.py", line 220, in fetch2
    return self.fetch(request['url'], request['method'], request['headers'], request['body'])
  File "C:\Users\Administrator\PycharmProjects\ccxt\ccxt\exchange.py", line 254, in fetch
    raise RequestTimeout(' '.join([self.id, method, url, 'request timeout']))
ccxt.errors.RequestTimeout: gatecoin GET https://crossorigin.me/https://api.gatecoin.com/Public/LiveTickers request timeout

Process finished with exit code 1

Alright, now let's try a larger timeout:
gatecoin = ccxt.gatecoin ({
    'proxy': 'https://cors-anywhere.herokuapp.com/',  # better try with and without this line
    'verbose': True,
    'timeout': 30000, # in milliseconds
})
print(gatecoin.load_markets())  # the most basic method

Is it still not working? This is most likely a connectivity problem, but we'll need more feedback from you on this. Basically, we will eliminate all reasons one by one. Also, is there any way you can test the same code on a different computer (or a remote server) to see, if it's bound to your location or not. We need to eliminate these possible reasons first.

Right I have to apologies to you @kroitor as I omitted to explain I have been running this on an Amazon AWS instance (region : us-west-2b) where I cannot get it to work, with or without a proxy and timeout.
It seems this is a location based problem though as there are no issues with running it from my local machine in the UK.
I would prefer to run in Amazon so if there is a solution you can propose I would be grateful. I can of course look to open an instance in another region if there is no other solution but I am mindful this could cause similar issues with other exchanges, so wondering if there is an alternative?  Thank you.

@md0101 hi! Well, it looks like either of the two:

Gatecoin itself being in Hong Kong may be limiting traffic from US. At least, we have a lot of other users who run ccxt against Gatecoin with no problem, and as you say it your self, running it from UK makes a difference, so it's not a code problem obviously. A workaround to this case would be to use a proxy or switch AWS instance location to another part of US or, maybe, somewhere in Europe.
That particular AWS instance may have a problem accessing Gatecoin due to its networking setup, you can run another cheap micro instance based in US to see if it makes a difference somehow.

Apart from that, I'm afraid, this problem is beyond our scope, because, it's likely related to a particular location, and for now we can't recommend anything other than going through our troubleshooting sequence from the Manual. A usual solution to this kind of problems is to switch locations until you find a good connection with target exchanges.

@md0101 so, I'm closing this issue for now if you don't mind, because the cause is now clear. Feel free to reopen it or just ask questions, if any. Thx for your feedback!


FILLVALs

(More details are in email. Search on title for "FILLVALUEs")
The primary issue is that the ISTP conventions require using -1e31 for FILLVAL for CDF_FLOAT and CDF_REAL4 data types, but -1e31 cannot be represented exactly; See https://www.h-schmidt.net/FloatConverter/IEEE754.html, which shows "Value actually stored in float = -9.99999984824320729510959E+30".
This issue has resulted in problems at various times when a fill value of -1e31 is cast as a double, it will not match CDF_FLOAT values cast as doubles (which won't be exactly -1e31). This seems to have been noticed by a CDAWlib developer
I recommend that the ISTP conventions documentation is updated to note that the -1e31 is recommended for CDF_FLOAT and  CDF_REAL4, it cannot be represented exactly and so care must be taken.
Other notes:
These FILLVALs are suspect (related to the CDF_FLOAT/-1e31 issue described above):

-9.999999796611898e-32 (given -1e+31 returns ~50k hits)

-9.999999680285692e+37

1.0000000331813535e+32

Nand often has FILL=-2.14748006E9 for integer type variables. To see the occurrences, search the logfile for -2.14748006E9. I suspect the reason is similar to that in item 3. below. I also see Nand having a fill of 99999.9 when the master has 100000.0 and also NaN when the master has -1e+31. (Search on the logfile for 99999.9 and NaN).

I've fixed this for the double and float values.  The problem is Nand's library casts floats to doubles, I believe when the data is extracted, or it's also possible that the data provider makes the same mistake.  I've always had to check for the number to be within 0.000001% of fill, and I put this code into the server.  This is released at https://cottagesystems.com/server/cdaweb/hapi.
I did notice that integers have some issue as well, and I'll look into that when I have a chance.

It looks like PIONEERVENUS_MERGED_SOLAR-WIND_10M has an interesting fill value: 1.0000000331813535E32


ux: mark as read loading spinner

This resolves #1731
https://user-images.githubusercontent.com/16504501/214877005-b4550d96-5258-4f99-91c3-464cdd32fe0c.mp4

My only ask is to place the spinner inside the button and replace the label text with it. Thank you!

@jamesacklin Good call, just made the change. Ready for :white_check_mark:


Fix problems with translation as well as emoji & mentions

Fixes #1
Fixes #3 (duplicate of #1)
Fixes #2

@askvortsov1 we missed you a lot :) could you merge the pending PR requests


rename django filer to Filer in breadcrumbs

This pull request fixes the following issues:

BEFORE
AFTER

Looks great!


Detect and alert on signs of host compromise

In order to be aware when someone has established foothold on a host, we want common signs of rootkits or other malware on a host to result in alerts.
Acceptance Criteria

[ ] Local host-IDS (HIDS) is deployed on all hosts
[ ] The HIDS signatures used to detect attacks are updated regularly, with trivial team effort
[ ] When attacks are detected, alerts are sent via Riemann and PagerDuty

Implementation Sketch
Fork and update the EMC clamav boshrelease to use the most current version of clamav and be built using our boshrelease pipeline: https://github.com/18F/cg-clamav-boshrelease

Client release under development, per stand-up today, but blocked by the staging issues identified under #6.

Just to check: This one's about having something to find rootkits, etc. so rkhunter or clamav. My understanding is that right now we're working on Tripwire, which is in #13 ... So I'm moving this one back to the backlog and moving that one forward.

Is a bosh release for clamav that's configured to scan on file access and running freshclam to keep the database updated enough for this story?
Where's the documentation on how applications get data into  your riemann -> pagerduty setup for the last AC?

clamav will be sufficient for now at the level we are certifying.  In order to pipe this into Riemann we should log to syslog and filter in Riemann - https://www.balabit.com/sites/default/files/documents/syslog-ng-ose-latest-guides/en/syslog-ng-ose-guide-admin/html/configuring-destinations-riemann.html
I will escalate the alerts to pagerduty once I see those events come in

Should we be documenting this pattern generally as part of our docs?

Confirmed alerts going through Riemann, will roll out as deployments happen.


Can't Install Ocelot on .Net Core App via Nuget

Expected Behavior / New Feature
I am spinning up a new .Net Core 3.1 REST API to use in conjunction with an adjacent console application for handling callback requests from a 3rd party API (the 3rd party API sends callback responses in the form of requests to an endpoint on my API in order to provide large dataset access outside of their REST API).
Actual Behavior / Motivation for New Feature
Upon creation of a new .Net Core 3.1 project (class library, Web API application, or console application, it doesn't matter), when trying to install Ocelot via Nuget, I get the following output message:
NU1202: Package Ocelot 17.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Ocelot 17.0.0 supports: net5.0 (.NETCoreApp,Version=v5.0)
I've tried downgrading the project .Net Core reference to v2.2, v2.1, and v2.0, and get the same basic result.
Steps to Reproduce the Problem

Create a new .Net Core v3.1 project
Attempt to Install Ocelot via Nuget

Specifications

Version: 17.0.0
Platform: Windows 10 Pro x64 v 20H2
Subsystem: -

I have rectified my issue by changing the project version reference to .Net 5.0 (because apparently my vision sucks and I couldn't see it in the availability list).


Bug in np.eye.

As suggested, it seems like np.eye broke at some point. To repro try, np.allclose(onp.eye(N), np.eye(N)).
Upon closer inspection, it seems like this only kicks in at large N. Try e.g. 5000.

Interestingly, it seems that onp.allclose works and np.allclose doesn't...

The nature of the bug is that np.eye(N) for large N ends up with more nonzero entries than expected. Dogus will followup with some plots that show this as a function of N.

I think we got it. See commits on #730.

Awesome, thanks for the super quick fix (as always)!

Thanks so much for raising this!

The more unpleasant thing is that this revealed an important hole in our test coverage, so #730 adds several checks that would have caught this issue.

Just uploaded jax 0.1.31 to pypi with this fix.


Model name should be included in the inference response for GRPC

…REST
Included by mistake from an earlier revision of the proposal.
The GRPC API is alredy correct in this regard.
Also update comment on GRPC requested output tensors to align with
HTTP.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/assign @rakelkar

Nice!
/lgtm
/approve


Add Sync youtube channel button on New Channel page

Fixes
Issue Number: Closes #1402

Let's also add on the https://odysee.com/$/channels page, but this works too.

Maybe this is what I originally intended, but i think it would be good to add on the My channels page too, sorry! Will open a separate issue.


On Cactbot Job, is there a way to seperate cooldowns from the rest and give them an icon?

Question
What would you like to ask?
Title. Love the program but I have no need of the healthbar/pullbar and just want the cds (preferably with pictures). When it comes to DNC, devilment and the TS buff do have an icon, the rest are "just" colored boxes. I have tried to recode that but it didnt work, my programming skill are too bad for that.
Is there any way to customize the plugin or are we "stuck" with the layout we have?
Thanks in advance. :)

For now, it is impossible to customize boxes of jobs module because they are hardcoded, but I am working on a patch (#3293) which extract and refactor every job components into classes to have clearer and easier interfaces. These are large changes so I can't tell when it is done, but once I have it done, it is easier to add a entry in Options variables in user/ directory, provide a way to implement your own component.
If you know JS and front-end development, You may find that cactbot was built up by webpack. I think what you said "didn't work" is because you didn't run "npm run build" before loaded in ACT?

Thanks for the swift response!
Glad to hear you're working on a patch, really looking forward to that. Sadly I have no experience whatsoever in JS, just did a bit of CSS and HTML back in the day (both of which you can barely see as "coding"), tho I understand that it's quite a body of work to re-write an existing code.
Keep up the good work!

I rewrote a bit of code to add my own icons, but I found that for SMN the UI does not show me nearly enough info even with icons. Additionally, the icons disappear when the CD starts, which makes it harder for me to use over in-game bars.

I think #3714 is the right place to follow up on this issue.


updating golang and various libs to fix security vulns

Unsure if you take these types of pull requests but I've have some security vulns pop up in scanners so just updating versions.
If this needs to be done differently just let me know and more than happy to adjust things.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Is there a chance a release could be cut including this?

cc @simon0191 @gavinheavyside

Pushed to docker hub as v2.2.7 / latest


Dependency upgrades

Note: ansible.utils 3.0.0 requires ansible 2.14, as it is a collection dependency we need the same.

@aalaesar @wiktor2200 LGTM?


Cleanup test scripts and GitHub action

Trying to enhance the e2e tests a bit, as well as add some extra safety around some of our scripts.
Also seeing if the GitHub action can be simplified (we'll see if I goofed something)

@grantnorwood and @colbywhite, would love y'all's eyes on this
I feel pretty good about the cleanup (thanks for some inspiration in #52 Colby)
Also, note that the Playwright tests are now failing. This is because of the change to run npm run start:mocks inside of playwright.config.ts. You can see in this action everything was successful, so this will resolve once this PR is merged in


IPLD relevant for us?

Checklist

[x] I've searched the project's issues.

❓ Question
This project here looks interesting to integrate the tokeconomics with this DeSci framework, but no idea if it makes sense here/now.

Discussed this with protocol labs this weekend, not  relevant, at least for now. Closing.


Fix/online

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 49 (0.0%)  changed or added relevant lines in 13 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 30.166%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Header/Header.tsx
0
1
0.0%

src/components/OfflinePlaceholder/index.ts
0
1
0.0%

src/utils/getObjFromTable/index.ts
0
1
0.0%

src/utils/isOnline/index.ts
0
1
0.0%

src/utils/parseTsvTable/index.ts
0
1
0.0%

src/consts.ts
0
2
0.0%

src/utils/getAllDataFromResults/getAllDataFromResults.ts
0
2
0.0%

src/utils/isOnline/isOnline.ts
0
2
0.0%

src/utils/parseTsvTable/parseTsvTable.ts
0
3
0.0%

src/components/OfflinePlaceholder/OfflinePlaceholder.tsx
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/consts.ts
1
0%

src/utils/getAllDataFromResults/getAllDataFromResults.ts
1
0%

src/components/Pages/Viewer/Viewer.tsx
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1318

Relevant Lines:
5333

💛  - Coveralls


Add composability convention, WIP

This PR adds a convention whereby you can modify a repo post-clone in a safe way, or combine two repos, which is neat because you can start to create variations on a scaffold in a modular way. It's a work in progress with some TODOs noted at the bottom and I'm open to other ideas on how it should work! This is a proof of concept that seems to cover my use cases for it so seemed like a good starting point to see if it's worthwhile to include in this project.
How it currently works
Let's say you do degit mhkeller/degit-example where that repo contains only a file called degit.json that looks like the following, it will clone down the specified repo and then remove the specified files.
[
  {
    "action": "clone",
    "values": [
      {"src": "my-org/project-scaffold", "opts": {}}
    ]
  },
  {
    "action": "remove",
    "values": [
      "CONTRIBUTING.md",
      "DCO.md",
      "LICENSE",
      "CHANGELOG.md"
    ]
  }
]

If you have other files in mhkeller/degit-example, they will be written on top of the cloned repo. IN this way, if you want to include your own README.md,  you can include that in the repo you run degit on and they'll appear in your local directory when all is done running.
TODO / questions

[X] ~File copying and removing should support directories also. The lazy option would be to use fs-extra but can also do a vanilla implementation (or copy the good bits from fs-extra)~ Done via sander in https://github.com/Rich-Harris/degit/pull/28/commits/688a39037ff416c8ad6cd4a91ac45702c130bb53 https://github.com/Rich-Harris/degit/pull/28/commits/d0639f2f406cfa66bc110ecc1bc826c5e70076eb

[X] I added a warn event to warn when you want to remove a file that doesn't exist. It's magenta. Seems like a good idea??

[X] Add tests https://github.com/mhkeller/degit/commit/7f7e20123768a440ea0ac8a9c520fc06774f0f5a https://github.com/mhkeller/degit/commit/a8a29c8d71b7775ad1eda5717ab91efb900747e9

[X] ~Not sure if degit.json is the best naming convention. Open to others or for it to be configurable, it's currently hardcoded~ Added the name in src/utils.js so it's more configurable.

[X] ~Similarly, maybe json isn't the best format. Maybe yaml, or maybe it looks for degit.json and then degit.yaml / degit.yml if it doesn't exist?~ Keep it as json for now

[X] ~Maybe the format of degit.json as a list of actions is not flexible for other or future options. Maybe it should be an object with a actions as a list but allow for other top-level options that I haven't thought of?~ https://github.com/Rich-Harris/degit/pull/28#issuecomment-370995715

Switched up the degit.json convention to be the following. Also added it so that any subsequent clone is called with force: true.
[
  {
    "action": "clone",
    "src": "bloomberg/wsk.example"
  },
  {
    "action": "remove",
    "files": [
      "CONTRIBUTING.md",
      "DCO.md",
      "LICENSE",
      "CHANGELOG.md"
    ]
  }
]

All set minus tests.

Added tests via https://github.com/mhkeller/degit/commit/a8a29c8d71b7775ad1eda5717ab91efb900747e9 and https://github.com/mhkeller/degit/commit/7f7e20123768a440ea0ac8a9c520fc06774f0f5a plus some other edge case stuff.
The only question I have left is what to do about README.md files. I could see both someone wanting a README.md in their repo that contains a degit.json file to have that that readme be preserved AND someone who wants a README.md to explain how to initialize the project but expects that to be overwritten by the readme in the cloned project.
Maybe it's an option on the clone action such as:
{
  action: "clone",
  src: "test/repo",
  useReadme: true
}

That way if you're cloning multiple you could decide which readme you want. The only problem I could see is if you're cloning a repo that is also a degit.json-ified repo and it is cloning down something with useReadme: true and you get a conflict. A solution could be that setting useReadme: false cascades down for all cloned children from that action. I think that could work.

wooot!!! 🎉
Added a README section and released 2.1.0.
I'm not sure about useReadme, it seems very special-case. Maybe a way to handle that would be to have a rename action? In fact, I'll open a new issue to brainstorm additional actions that might be useful

Actually, the use case I described would be easily handled by doing a remove on that readme before the clone. So ya, I think between that and a rename action you'd handle all the use cases.


--delegate asks for file

when using --delegate in 0.16.0 I get this:
error: the following required arguments were not provided:
<--file |--batch >
Usage: ord wallet inscribe --fee-rate <FEE_RATE> --delegate  --dry-run <--file |--batch >
For more information, try '--help'.
I don't understand why I would need a file or batch to make a delegate, the delegate i set should be the file?  Sorry if I've missed something basic.  Doing this as a batch did not seem to help either?

I see there is a duplicate issue https://github.com/ordinals/ord/issues/3035 and a draft pull request https://github.com/ordinals/ord/pull/3027/files/7fc9271a5cf9190d3e20b7986932fab084869a67 so I will close this one, hopefully delegates are fixed soon.


Macro: While pulling bond onto monomer, a preview is shown when hover monomer

Steps to Reproduce

Switch to Macromolecule mode
Add any two monomers on canvas
Select bond tool and start pull bond from one monomer to another
Without releasing left mouse button, stop on the monomer

Actual behavior
While pulling bond onto monomer, a preview is shown when hover monomer
Expected behavior
While pulling bond onto monomer, a preview is not shown when hover monomer
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.15.0-rc.4

Tested.


✨ [REQUEST] Calibre update

Checked

[X] If a new addon, I have checked on  Google that such as addon doesn't already exists
[X] If a new feature, I have searched in the discussions & issues that it was not already covered

Which addon?
Calibre
Is your feature request related to a problem? Please describe
Not really a problem. But the used version for the addon is outdated, can you please update this.
On a sidenote to this, how do I add an external nfs share to the addon?
Describe the solution you'd like
Update the Calibe addon to 6.25.x.
Be able to add external shares to addon.

Hi, thanks! I think I had paused it because linuxserver has switched to s6v3 which messes up the guacamole server included and I don't have much time to make it work for the moment... For example the webtop addon has become unusable become of that issue and I couldn't find a way to get back to its normal behavior...

What do you need the guacamole for?

Hi, thanks! I think I had paused it because linuxserver has switched to s6v3 which messes up the guacamole server included and I don't have much time to make it work for the moment... For example the webtop addon has become unusable become of that issue and I couldn't find a way to get back to its normal behavior...

I checked with the LSIO guys, and apparently there is no guacamole in this package anymore
It is kasmnvnc now.

Ah, then it's probably the issue... Thanks for investigating, what it sure is that it's not a straightforward update and it requires additional work on my side

Ah, then it's probably the issue... Thanks for investigating, what it sure is that it's not a straightforward update and it requires additional work on my side

I have no idea what exactly, but perhaps if you point me in the right direction, i can help out. Or test the addon.

I'm working on kasmvnc through the webtop addon once it's done I'll transpose it here

Tested working!


ShapeIndices and FeaturesLookup doesn't match during Undo Redo Operation

IF BUG, INCLUDE THIS PART:
Steps to reproduce

I added 3 nodes in existing featureset
then update existing and newly added object alternatively
and perform undo and redo operation
Undo operation performed well
During Redo operation, I observed that featurelookup and shapeindices values doesn't reflect the count correctly. Featurelookup shoes proper count but shapeIndices doesn't.

Expected behaviour
Both values should shows same count.
Actual behaviour
During Redo operation, I observed that featurelookup and shapeindices values doesn't reflect the count correctly. Featurelookup shoes proper count but shapeIndices doesn't.

The most probable cause is that you forgot to call FeatureSet.InitializeVertices() after adding/removing features. This "re-synchronizes" the features and the shapes.
Can you confirm whether this is the case?


UIINREACH-39: Integrated UI with backend API for item contribution options

Porpose:
Integrated UI with backend API for item contribution options mapping

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-inn-reach/job/PR-41/1/

yarn run v1.22.5
$ eslint ./ && stylelint "src/**/*.css"
/home/jenkins/workspace/folio-org_ui-inn-reach_PR-41/project/src/settings/routes/ContributionOptionsRoute/ContributionOptionsCreateEditRoute.test.js
247:1  error  Trailing spaces not allowed  no-trailing-spaces
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


Prepare a wiki based on specs and using docsify

Prepare a wiki based on specs and using docsify

Published https://js-next.github.io/js-ng/wiki/#/