Reflection issues with scripting environment

Getting MethodAccessExceptions on Reflection code because code is contained in a private class
This makes prototyping Reflection very cumbersome / impossible because of TypeLoadExceptions and more.
Dynamically created assemblies can not access Types contained inside the script, because they are nested inside a private class.
Issue does not appear on regular Console-App, but on Roslyn "Script"s
e.g.
class Program {
 // Errors with Reflection because "public"-nested classes are actually "private"
}

public class Program {
 // No more errors
}```

Unfortunately this is not something I have control over AFAIK. The script language is provided by Roslyn, and it creates the class and the Main method.

Closing now. If someone comes up with a clever solution for this, please let me know.

@aelij could a source generator make the Program class partial?

@kzu I don't think so, because the Program class is entirely generated, it's not in source.


Fixes discriminated union bug regression when using enums

Change Summary
Fixes regression documented in pydantic/pydantic#9235, which was introduced in upgrade to pyo3 v0.21

Related issue number
pydantic/pydantic#9235

Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@sydney-runkle should I create a PR removing the xfail in pydantic as well? How do you handle upstream changes like this?

please review

@dmontagu you know what, I think I got ahead of myself here, I need to finagle a test for this change.

Would be great to have it fixed as soon as possible, is there any prediction date / version? Thank you.

@kfreezen,
Amazing work here!
Here's a test we can add to the tests/serializers/test_literal.py file:
def test_literal_with_enum() -> None:
    class SomeEnum(str, Enum):
        CAT = 'cat'
        DOG = 'dog'

    @dataclass
    class Dog:
        name: str
        type: Literal[SomeEnum.DOG] = SomeEnum.DOG

    @dataclass
    class Cat:
        name: str
        type: Literal[SomeEnum.CAT] = SomeEnum.CAT

    @dataclass
    class Yard:
        pet: Union[Dog, Cat]

    serializer = SchemaSerializer(
        core_schema.model_schema(
            cls=Yard,
            schema=core_schema.model_fields_schema(
                fields={
                    'pet': core_schema.model_field(
                        schema=core_schema.tagged_union_schema(
                            choices={
                                SomeEnum.DOG: core_schema.model_schema(
                                    cls=Dog,
                                    schema=core_schema.model_fields_schema(
                                        fields={
                                            'type': core_schema.model_field(
                                                schema=core_schema.with_default_schema(
                                                    schema=core_schema.literal_schema([SomeEnum.DOG]),
                                                    default=SomeEnum.DOG
                                                )
                                            ),
                                            'name': core_schema.model_field(schema=core_schema.str_schema())
                                        },
                                        model_name='Dog'
                                    )
                                ),
                                SomeEnum.CAT: core_schema.model_schema(
                                    cls=Cat,
                                    schema=core_schema.model_fields_schema(
                                        fields={
                                            'type': core_schema.model_field(
                                                schema=core_schema.with_default_schema(
                                                    schema=core_schema.literal_schema([SomeEnum.CAT]),
                                                    default=SomeEnum.CAT
                                                )
                                            ),
                                            'name': core_schema.model_field(schema=core_schema.str_schema())
                                        },
                                        model_name='Cat'
                                    )
                                )
                            },
                            discriminator='type',
                            strict=False,
                            from_attributes=True
                        )
                    )
                }
            )
        )
    )

    yard = Yard(pet=Dog(name='Rex'))
    assert serializer.to_python(yard, mode='json') == {'pet': {'type': 'dog', 'name': 'Rex'}}

And yep, when we bring this into pydantic, we'll remove that xfail.

Once you add that test, I'll approve and we can merge :)

I’ll get that added tomorrow night
On Tue, Jul 2, 2024 at 20:39 Sydney Runkle @.***> wrote:

Once you add that test, I'll approve and we can merge :)
—
Reply to this email directly, view it on GitHub
https://github.com/pydantic/pydantic-core/pull/1286#issuecomment-2204694685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACUWLHRXQFIWGMXP5JFYALZKM235AVCNFSM6AAAAABHCZHBVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBUGY4TINRYGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Whoops, sorry guys, I completely forgot about this. Been on a sabbatical for the last 4 weeks. I will add it right now.

@kfreezen great job!
@sydney-runkle could you please go forward with it?


54 new folder structure

Fixes #54
Changes
The project wasn't structured properly preventing us to write scalable and flexible code.
Now the folder structure was completely renewed and the files were partly refactored to fit the new folder structure and the naming conventions.
Checklist before merge
Developer's responsibilities

[ ] Approved by at least one developer: enter reviewer here
[ ] Pull request build has passed
[ ] Production backend has been updated to reflect new features and fix bugs
[ ] tested locally (in all browsers if frontend)
[ ] updated the docs
[ ] added tests where necessary

Product Owner's responsibilities

[ ] No issues have been found on staging environment
[ ] Product Owner has approved the release

I am not a big fan of those dummy files. Please check, if there is any way to not have them in the repo, as they are not useful and might confuse people.
As my understanding of the client/api/ folder is that it shall include all API related functions, why are those calls from the front- to the backend not in there, but instead is a dummy file? Please let me know if I understood the purpose of that folder wrong or not.
Other than that only minor things that came up for me

I am not a big fan of those dummy files. Please check, if there is any way to not have them in the repo, as they are not useful and might confuse people.
As my understanding of the client/api/ folder is that it shall include all API related functions, why are those calls from the front- to the backend not in there, but instead is a dummy file? Please let me know if I understood the purpose of that folder wrong or not.
Other than that only minor things that came up for me


profile__build_phase.sh fails with '../DetoxSync.framework/DetoxSync: No such file or directory'

Description
I followed your Framework Integration Guide but when I want to compile the app, I get the following error:

openssl enc -aes-256-cbc -d -K 0 -iv 0 -nosalt -in '/Applications/Detox Instruments.app/Contents/SharedSupport/Scripts/../ProfilerFramework/DTXProfiler.framework/Frameworks/DetoxSync.framework/DetoxSync' -out /Users/(...)/Library/Developer/Xcode/DerivedData/(...)/Build/Products/Debug-iphonesimulator/(...)/Frameworks/DTXProfiler.framework/Frameworks/DetoxSync.framework/DetoxSync
(...)/Library/Developer/Xcode/DerivedData/(...)/Build/Products/Debug-iphonesimulator/(...)/Frameworks/DTXProfiler.framework/Frameworks/DetoxSync.framework/DetoxSync: No such file or directory
4520914540:error:02FFF002:system library:func(4095):No such file or directory:/BuildRoot/Library/Caches/com.apple.xbs/Sources/libressl/libressl-47.11.1/libressl-2.8/crypto/bio/bss_file.c:255:fopen('(...)/Library/Developer/Xcode/DerivedData/(...)/Build/Products/Debug-iphonesimulator/NewsOne.app/Frameworks/DTXProfiler.framework/Frameworks/DetoxSync.framework/DetoxSync', 'w')
4520914540:error:20FFF002:BIO routines:CRYPTO_internal:system lib:/BuildRoot/Library/Caches/com.apple.xbs/Sources/libressl/libressl-47.11.1/libressl-2.8/crypto/bio/bss_file.c:257:
Command PhaseScriptExecution failed with a nonzero exit code

Steps to Reproduce

Follow the brew instructions
Follow instructions in XcodeIntegrationGuide
Compiling the app

Expected Behavior

compiling doesn't fail

Environment
Model: MacBook Pro (15-inch, 2017)
OS: macOS 10.15.2
Xcode: Xcode 11.3
Ruby: ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-darwin19]
Detox Instruments: 11.12 (11639)

Possible Solution
I think it's just a spelling mistake in 'profiler_build_phase.sh' in line 27.
rm -fr "${CODESIGNING_FOLDER_PATH}"/Frameworks/"${PROFILER_FRAMEWORK_NAME}"/Frameworks/"${PROFILER_SHIM_FRAMEWORK_NAME}"
The variable PROFILER_SHIM_FRAMEWORK_NAME is undefined so the complete Frameworks folder is deleted and DetoxSync is not available anymore.

Thanks, fixed. Releasing a new version now.


Update README.md

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

Summary by CodeRabbit

Documentation

Added a video introduction section with a clickable thumbnail linking to a YouTube video in the README file.

kindly mention the issue number  in the first comment

kindly mention the issue number in the first comment

#1494


Unsupported startup mode: SPECIFIC_OFFSETS

Describe the bug(Please use English)
Specifies the binlog exception，Is there any way to solve it?
Environment :

Flink version :  1.13.6
Flink CDC version: 2.2.1
Database and version: mysql 8

To Reproduce
Steps to reproduce the behavior:

Thes test data :
The test code :
The error :

Additional Description
If applicable, add screenshots to help explain your problem.

Fixed by #1661.


Bjm/noble abel

PR Summary

Added Noble-Abel EoS according to Neron and Saurel 2022, "Noble–Abel/first-order virial equations of state for gas mixtures resulting from multiple condensed reactive materials combustion." Entropy implemented generally as in the singularity ideal gas unit.

PR Checklist

[x] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by using the make format command after configuring with cmake.
[x] Document any new features, update documentation for changes made.
[x] Make sure the copyright notice on any files you modified is up to date.
[x] After creating a pull request, note it in the CHANGELOG.md file
[ ] If preparing for a new release, update the version in cmake.

I'll run the gitlab CI and make sure this is working. Then I think we can merge it

appears to be passing gitlab CI @jhp-lanl.

Looks like this is good to go. I'll merge


IP address in the auth

Hey,
I see in the documentation that IP address is only usable for ACL query and not inside auth query. I've tried and this is actually not working, I received:
select password from mqtt_user where username = 'stats_pollers' and ip = '\'%a\'' limit 1;

if I have
auth.mysql.auth_query = select password from mqtt_user where username = '%u' and ip = '%a' limit 1

in my emqx_auth_mysql.conf.
When I look at the code, I can see that in emqx_auth_mysql.erl:check fun and semqx_acl_mysql.erl:do_check_acl are both using emqx_auth_mysql_cli:query(Pool, AclSql, AclParams, ClientInfo) which is using the replvar:
https://github.com/emqx/emqx-auth-mysql/blob/master/src/emqx_auth_mysql_cli.erl#L77.
Why is it working with one and not the other?
Is the IpAddr not accesible while authenticating? But in this case, why it is accessible in the auth.http.auth_req.params from https://github.com/emqx/emqx-auth-http?

Sorry, @dufourc, this is an imperfection in the documentation, we will fix it.
These placeholders' support is inconsistent in each plugin. My suggestion is to try to use the ones mentioned in the configuration file comments. (Although it is sometimes not accurate...)
Of course, if you can read the code, this place is the most accurate.
I'm very sorry for the confusion these inconsistent implementations have brought you. We've planned to unify them in a subsequent release!

Don't worry, it's hard to keep a documentation up to date for such a big product!
I would like to use the IP in the authentication query, do you have any ideas why it is not working?

It's a bug actually. The emqx_auth_mysql_cli:replvar/2 should get the '%a' field by peerhost instead of peername.
We will fix it and plan to release it in 4.2.2. Thanks @dufourc :)

In addition, I'm not quite sure why the client's IP address needs to be used for authentication instead of the username/client ID?

You're right, for authentication username/password or cookie should be enough. But we only use IP in ACLs so to make sure, the user we authenticate has the correct permission, we need to check that the IP address matches the username/password.
In our project, we have two kind of EMQX client:

pollers: extract information from a machine (server, switch, DB etc..) then publish to EMQX.
browsers: subscribe to it to have some graphics/tables about these devices.

In the ACL file, we only use IP rules. Indeed browsers appears to come all from the same address (Nginx proxy) and pollers are locals.
To make the ACL rules relevant, we need to check the IP/username/password during the authentication.
Another possibility would have been to use a plugin allowing more complex ACLs like SQL or HTTP, but it would have been more work, more  queries/requests made and the cache to handle.
We are as well checking the clientID (that need to contain a unique prefix stored in our session), to kickout users if needed.
It might be wrong, but that's the solution we've come up with

It's a bug actually. The emqx_auth_mysql_cli:replvar/2 should get the '%a' field by peerhost instead of peername.
We will fix it and plan to release it in 4.2.2. Thanks @dufourc :)

Thanks, amazing!

@HJianBo I've seen the change in the code and this is working for me. Thank you very much :) I'm closing the issue


Not an issue but a question...

I am debating between Redux and the Observable version of it https://github.com/ngrx/store
I am leaning towards the https://github.com/ngrx/store as I love the fact it uses pure Rxjs and we can pipe async into the view...
but, I like the middleware and eco system aroundd Redux...
decisions decisions..... mmm
u'r 2 cents?
Regards,
Sean
Checkout the Ultimate Angular 2 Boorstrap App: @ http://ng2.javascriptninja.io
Source@ https://github.com/born2net/ng2Boilerplate

@born2net That's a great question. I've started with the pure redux implementation before ngrx was implemented by Rob and I have to say I'm still quite happy with the decision (not to take away any of the awesomeness of his work!).
A bit of background: At our company, we are going to start a band new project with Angular 2 in the next month or two. There are going to be 20-30 developers initially and we need something solid for them to work on. Angular 2 + TypeScript are good foundations, but they really needed an opinionated way to handle state and logic to compliment the architecture. When I first read about Redux and then went through the learning material I thought it was perfect. Fits nicely with the way we are planning to build the application and provides a beautiful separation between state, logic and UI. Also, it's very consistent and predictable in the way developers need to write and maintain code (As an aside: the only dilemma I have is around thunks and the way they are different than other action creators by having side effects). Creating this angular2-redux-example proved that this is a viable option that would work for a bigger application and I could see our developers easily adopting it and understanding how it works. It's just so simple that it hurts! :)
Ngrx looks very similar to use, but I'm afraid it's not as simple to grok when looking at the internals. Rx in general is not a simple concept to grasp. I love it and think this is an awesome way to handle data streams and events, but it will take a while until it's mainstream and developers just "get it". I don't think I fully get it yet and think this way. So, I'm very careful in adopting it. Angular 2, having RxJS build it, will help get a head start with RxJS when dealing with forms or the Http service, so once we do use it for a while and start building more code using Observables and the various combinators (=operators?) then it will be a good opportunity to introduce it in more places as well. Until then, I'm hesitant to do that. Looking at the ngrx internal implementation, even though it's got a very small footprint it's not as easy to read and understand what is happening there. Redux, on the other hand, is very very simple and the way Dan presented it in the Egghead videos is just brilliant! Any developer can look at that and understand straight away what it does under the hood and how to reproduce it themselves. You can't say the same on the Rx implementation, thus creating another barrier for entry.
To summarise, with all the new concepts that our developers need to grasp when dealing with a modern web application (Angular 2, Typescript, transpilers, modules, bundling, debugging, material design, RxJS inside Angular, Redux as a concept, npm, etc.) I think an easier path to use Redux is the original implementation. That said, I can see a future where we can opt for another implementation, if the code using it is not tied in to the specific implementation (use simple dispatch/subscribe API).
Thanks for looking at the implementation and bringing up the question. Would love you hear your thoughts and any further research or choices you've made on this subject.
Cheers,
Ruby

thanks so much for the long explanation.... appreciate it...
I decided to take your advice and go with std Redux... tx again, Sean.

No worries.
The link you provided doesn't work. Not sure what the question is, but if it's a concern about a large data I don't think there should be an issue there. Remember that the state is just an encapsulating object with references. It doesn't actually contain all the data, just links to them. So the data that's "in it" will exist this way or another. The only overhead is the wrapper object (very small) and the fact we're creating it again and again with every action, which I think is worth the benefits, but it's something to verify when building a large app.
BTW, here's a recent blog post from Victor Savkin on this subject: http://victorsavkin.com/post/137821436516/managing-state-in-angular-2-applications

Thanks again, ya I deleted the link since I got the answer, which supports what you said above. Another question I had is why you didn't use Immutable.js? I plan on including it and wanted your take on it... (would be awesome if it was part of this example for best practices ... )
regards
Sean.

I was actually contemplating about that for a while (still am :) ). I really don't like the fact that immutable.js introduces new syntax above pure JS for arrays and objects. I think it ties the code to this implementation and requires new developers to learn it. I'd much rather have it "just work" and complain if someone was trying to mutate an object and not required any additional overhead for both learning and in code.
In that sense I think Seamless Immutable is a better option. But then I looked at some performance benchmarks and wasn't happy with what I saw.
I ended up deciding, for now, to enforce immutability just by convention and best practice, and see how that goes. Once we start writing a bit of code (in a month or two we'll have heaps :) ) we can decide on the best approach here.
I do agree that this is an interesting are to watch. And maybe I'm wrong and we do need something from day 1. There are a few other options for enforcing immutability, but the above two are the most popular to date (would love to hear about other good options to consider). Maybe in a few months a new one will emerge and will be even better than these.
Cheers,
Ruby

BTW, I'm more than happy to receive PRs for stuff you'd like to add. Even if it's not what we would choose it doesn't hurt to include it if that's a best practice (and I do agree that immutable.js is so popular it might just be...).

got it... tx again...

I am trying to get jspm to bundle in my project but I keep getting an error of:
err  Error: Unable to calculate canonical name to bundle file:///C:/msweb/studioEnterprise/src/App.js. Ensure that this module sits within the baseURL or a wildcard path config.
         at getCanonicalNamePlain (C:\msweb\studioEnterprise\node_modules\jspm\node_modules\systemjs-builder\lib\utils.js:203:13)
         at getCanonicalName (C:\msweb\studioEnterprise\node_modules\jspm\node_modules\systemjs-builder\lib\utils.js:130:19)
         at C:\msweb\studioEnterprise\node_modules\jspm\node_modules\systemjs-builder\lib\arithmetic.js:96:38
root|studioEnterprise>

have you seen this before?
I also noticed that you bundle App.ts and I was wondering why? since all my source code is already been transpiled, does System.js really need to know about TS? can't it just bundle only the .js files?
tx as always,
Sean.


Adds continent optgroup to select!

This looks really good. I don't see why we can't add your i18n-continent-translations to country_select since it's just locale files.
Am I correct in reading these changes that using grouped_by_continent means you can no longer specify priority_countries? If that's so, I'd like to get that working in conjunction with these changes along with tests before merging.
Thanks for submitting a PR with README changes and a screenshot 👍

Sorry, I end up not using it since, so going to close for the moment, Thank you

Sorry, I end up not using it since, so going to close for the moment, Thank you


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://www.stencyl.com/download/
Publisher: Stencyl, LLC
Package Name: stencyl
Description: Stencyl isn't your average game creation software; it's a gorgeous, intuitive toolset that accelerates your workflow and then gets out of the way. We take care of the essentials, so you can focus on what's important - making your game yours.
Package Version: 4.1.3 (Build 12232)
Installer URL: https://static.stencyl.com/downloads/stencyl/release/4.1.3/Stencyl-4.1.3.zip

Sorry, this package seems to be a compressed archive of loose executables. winget.exe does not support such kind of packages at the moment.

The issue should be closed as "not planned" and attach https://github.com/microsoft/winget-pkgs/labels/Blocking-Issue https://github.com/microsoft/winget-pkgs/labels/zip-binary.

I cannot attach labels, but i can close as per https://github.com/microsoft/winget-pkgs/issues/159487#issuecomment-2185102047

I previously use Scoop as a package manager on Windows. It supports pre- and post-install scripts for installer files. In this case, Scoop may be better than WinGet. ❤


post land - run cluster test pre-release suite

Motivation
Run Cluster Test pre-release suite when release-* branch is pushed.
Test Plan
Canaried.

/canary

/canary

/canary

/canary

:sunny: Canary successful

/land


[Improvement]: [Redis] Need to use docker image of redis instead of installing redis server locally

Connector Name
module/redis (Redis)
Suggested improvement
Try to use https://hub.docker.com/_/redis to run the testcases

This issue is blocking to fix https://github.com/ballerina-platform/ballerina-extended-library/issues/33


Clearing Dockable Debug/Trace output

Hi @chuongmep
It could be nice to be able to Clear the Dockable Debug panel by codding.
You recomanded me to clear the txt file , ok but, when I do this , DockAble panel still with lines... Even if I close A re-open it.
Working if I close Revit but, it could be nice while Revit is in..
PS : I've noticed that I have to Remove App first if I I Want that the Debug.Trace Events works

@pierrenavarra sorry I reply late, it ok if you have any pull request , I will review. At the moment, I see it don't see any useful when create this feature , please provide more reason why you want, while button clear is enough ?

@chuongmep
Thx answering
You're right, Clear button is enough, evrything is oki!
Have a nice Week-end


Feature allow thread pool executor

As discussed in https://github.com/data61/clkhash/pull/340, this closes #339.

Could be worth testing, I had assumed that the bulk of the work would be in the low level crypto calls (HMAC etc) and that they would be releasing the GIL which would allow threads to still be useful.
max_workers argument would be a nicer api though so happy to implement that

Could be worth testing, I had assumed that the bulk of the work would be in the low level crypto calls (HMAC etc) and that they would be releasing the GIL which would allow threads to still be useful.
max_workers argument would be a nicer api though so happy to implement that

You were correct, it is faster using no threads.
Informal numbers:

Passing max_workers=4 to ProcessPool ~ 10kCLK/s
passing max_workers=8 to ProcessPool ~12kCLK/s
Using default ThreadPool ~1.9 kCLK/s
Main loop (no executor) ~4kCLK/s
Replacement PR here - https://github.com/data61/clkhash/pull/424

You were correct, it is faster using no threads.
Informal numbers:

Passing max_workers=4 to ProcessPool ~ 10kCLK/s
passing max_workers=8 to ProcessPool ~12kCLK/s
Using default ThreadPool ~1.9 kCLK/s
Main loop (no executor) ~4kCLK/s
Replacement PR here - https://github.com/data61/clkhash/pull/424


Update cypress tests

📝 Description
Fixing cypress test:

Aligning text to fit current text in the app.

filter.spec.ts:

the visit function was flaky changed to the visitCatalog function.
changing rhel 6 to 9 and using metadata name instead of name as it didn't match anymore.
switch to check for fedora template instead of checking just count of templates (crashes locally when having more than one fedora template).

check-tabs.spec.ts:

creating vm/template from yaml gets a resource name example for both cases.
common template alert text didn't matched - getting by id instead of text.

/lgtm


[Feature][Config UI] DORA configuration page design

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Based on the requirement described in #2853, there needs to be a separate page to allow users to configure for DORA metrics.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Design for State I is done: https://www.figma.com/file/Eux4Dhorxp7M0TwzOnL6Yh/Config-UI-for-V1.0?node-id=1396%3A11624


Self-contained docker image for easier self-hosting

Create a docker image that has the entire Exceptionless app in an easy to use single docker container where users can just do a single docker run command.

[x] Start from Elasticsearch base image
[x] Install dotnet
[x] Add files from API docker image
[x] Figure out how to run both Elasticsearch and the aspnet web app at the same time and monitor both processes
[x] Add files from UI docker image
[x] Ability to configure UI through environment variables
[x] Figure out how to host the API and UI in the same ASPNETCORE app
[x] Figure out how to enable SPA mode (push state)
[x] Figure out how to map a volume for ES data so that it persists between runs
[x] Figure out how to use an SSL certificate and run in HTTPS required mode
[x] Figure out how to enable email sending
[x] Publish docker images to Docker hub
[ ] Update self-hosting documentation

How to use, how to write command?

@gmbzero I still need to update the self-hosting docs, but I did update the README in the project to show how to run a simpler simple testing instance and then there is also this hosting samples file that shows how to run it at different levels.

@gmbzero I still need to update the self-hosting docs, but I did update the README in the project to show how to run a simpler simple testing instance and then there is also this hosting samples file that shows how to run it at different levels.

Been trying it out locally, this command works for me (Exceptionless logs everything):
docker run --rm -it -p 5000:80 exceptionless/exceptionless
However, the docker-compose file doesn't work for me. I initially had redis removed, but then it immediately crashes. After re-enabling it I managed to create a new account, organization and project, but nothing gets logged to it. I've tried to recreate it a couple of times (from scratch), but the result remains the same.

What errors do you get / what do your logs look like when it crashes?

The errors are only if I remove all redis stuff from the docker-compose file. I think it was a null reference exception, but I'll try to recreate it again. It didn't log anything with redis enabled (if that was unclear).

Hm, it no longer throws an exception anymore, that's odd. I have just recreated it from scratch again. What's still broken though is that nothing gets logged (with or without redis).
We haven't received any data!

Wondering if you are ending up using old docker images that you have cached locally. I just updated the docker-compose.yml file to have explicit image versions in it. Can you try that?

I've not dockered (?) Exceptionless before, so that shouldn't be the case. With the previous docker compose file these versions were already installed. I'll do another sweep tomorrow.

I just reset everything locally and made sure I was completely clean and just do docker-compose up on that docker-compose.yml file and the app came up and worked as expected.

I just reset everything locally and made sure I was completely clean and just do docker-compose up on that docker-compose.yml file and the app came up and worked as expected.

It also logs stuff for you? That's odd. I am enable to sign in and create projects etc, but no events are logged. I'll give it another try tomorrow.

It seems some stuff was left from my initial version without redis. I've now purged all data and volumes and have found this out:

With everything initially enabled, it's logging correctly.
If redis is disabled (or disabled initially), it won't log anything.

That docker-compose setup requires Redis because the jobs are running out of process and the app is using Redis for queues.

Not sure what you are trying to accomplish, but the app can be setup in a variety of ways. Why are you trying to disable Redis?

I never had redis installed with the non-docker version so I thought I might as well not use it here either. I already tried to change EX_RunJobsInProcess to true (as I had before) but that didn't work either. Regardless, with redis is fine too. It doesn't matter me too much.

There are other simpler setups now. Are you aware of those? Take a look at hosting-samples.sh. We have a single docker image that contains Elasticsearch, the API and the UI and runs jobs in process. You can run that as simple as docker run --rm -it -p 5000:80 -v ~/esdata:/usr/share/elasticsearch/data exceptionless/exceptionless:6.1.0 which runs the app and maps a data volume to your local computer so that data is persisted if the docker image is restarted. That is the absolute simplest way to run Exceptionless if you don't have a lot of data and it's not critical.

Yeah, I've seen (and tried) that one, but wasn't sure what was included in that image so I opted for the compose file. I hope to migrate Exceptionless to docker, but I'm wondering what the best way is to run the DataMigration job, I'm not seeing much on the doc page on how you'd normally run those.

I managed to run the migration. As it might be of use to some, here are the steps:

Add your existing Elasticsearch instance to reindex.remote.whitelist in the ES docker instance and restart it.
(Depending on your configuration) Set existing ES's host to <IP_ADDRESS>, otherwise the Job won't be able to connect to it. Restart it.
Set ASPNETCORE_URLS environment variable of the Jobs instance to another port (as another instance is already running).
Make sure to point EX_ConnectionStrings__ElasticsearchToMigrate to your existing ES instance, and not EX__ElasticsearchToMigrate.
Execute dotnet Exceptionless.Job.dll DataMigration.

That said, after processing events longer ago than about a month the migrations started throwing exceptions for me.
[11:16:09 ERR] Error creating the index prod-events-v1-2020.05.01: Original: (503 - ElasticsearchClientException) Request failed to execute. Call: Status code 503 from: PUT /prod-events-v1-2020.05.01. ServerError: Type: process_cluster_event_timeout_exception Reason: "failed to process cluster event (create-index [prod-events-v1-2020.05.01], cause [api]) within 30s"
Server: (503) Type: process_cluster_event_timeout_exception Reason: "failed to process cluster event (create-index [prod-events-v1-2020.05.01], cause [api]) within 30s"
This goes on and on, not entirely sure what's causing it. Both ES instances are still working and accessible. I can restart migration and then a couple more are usually done, but as it starts from scratch, this doesn't seem like the best way, and it'll eventually have the same errors again. I might just use two instances for a while and see how that goes.

@Phyxion I'm going to close this issue. If you are still having a migration issue then can you please open a new issue for that?


Is mmcv correct in Dockerfile?

Looks like here we get mmcv-full=1.3.5. However minimal mmcv version is required to 1.3.8.
Also do you have any plan for torch==1.9.0 as 1.8 is annoying according to this issue?

Yes, we forgot to change this minimum version of MMCV in our last release. Can you kindly make an one line PR to fix it?
As for torch 1.9.0, maybe @ZwwWayne can have a look at it?


Support Serverless 3

Serverless 3.0.0 was released yesterday, it would be great if you could add support for it.
I tried running it with Serverless 3.0.0, and didn't encounter any issues, so maybe it's enough to update the peerDependency version, but I haven't checked in detail if there is any more that needs to be done.

@trygveaa great thanks for opening that, indeed, we somehow forgot to mark it as compatible. I've just prepare PR: https://github.com/serverless/serverless-plugin-typescript/pull/264
It should be followed with a new release today

Great, thanks!


can I use floating-ui in a vue project？

can I use floating-ui in a vue project？

Yes. React is the only one with an actual supported wrapper, but you can use @floating-ui/dom with any framework because it's just vanilla JS :)


Breadcrumbs have been added [Patch 1.26.0]

With the release of 1.26.0, VScode has now added breadcrumbs to the mix. It would be great if these could be brought in to the theme.
The new theme colors for the breadcrumbs are:

breadcrumb.foreground: Color of breadcrumb items.
breadcrumb.focusForeground: Color of focused breadcrumb items.
breadcrumb.activeSelectionForeground: Color of selected breadcrumb items.
breadcrumbPicker.background: Background color of breadcrumb item picker.

Hi @ekfuhrmann Thank yuou for your report. We already added these new api in 681db679b94b83128065e2288651fe62fbbaae5b as you can se in #228. This feature will be released with the August release at the end of the month-

Fantastic, sorry for missing that!


Use custom types for container definitions

This is the "successor" to #695 which was recently closed for staleness. I'm intending to address this alongside a rewrite of #917.

Closing in favour of #1156 which implements this :)


Make MAX_LINE configurable

We currently have a cookie line header of 8718 characters, which is larger than MAX_LINE setting of 8192.  Can this either be bumped up to 16K, or better yet be configurable in the ENV?  Also it would be nice if a proper error message was returned, we are currently getting
HTTP/1.1 400 Bad Request
Date: Thu, 06 Jun 2024 16:09:28 GMT
Content-Type: text/plain
Content-Length: 77
Connection: keep-alive

Failed to open a WebSocket connection: did not receive a valid HTTP request.

Which isn't very helpful.
https://github.com/python-websockets/websockets/blame/01195322d2620a44039b716cb93c108c2ca9b6b9/src/websockets/legacy/http.py#L14

Yea I'm facing the same issue. The cookie line is longer than MAX_LINE.
What's weird is that I configured withCredentials: false in socketio client but it still gets sent in the header. I also tried to configure fastapi middleware but the cookie wasn't found in the request. Not sure if this is an issue with websockets or socketio

The best answer I have right now is still this one: https://github.com/python-websockets/websockets/issues/1243#issuecomment-1276753881

I just made a change that gives you a slightly better error message in that case:
Failed to open a WebSocket connection: did not receive a valid HTTP request; line too long.

I'm going to make it configurable via an environment variable.

Fixed in bbb3161.
Please be aware that, if you are currently monkey-patching MAX_LINE, that will break in version 13.0. You will have to set the WEBSOCKETS_MAX_LINE_LENGTH environment variable instead.


Jit/Vmap-able DataLoader

Continuing with a discussion issues that I first posted here, I was wondering if there were any thoughts about creating a jax-specific data loader that could be nested in a jit/vmap-able function.
One motivation for this proposal is that it would enable us to jit the entire training loop.
I would be happy to help work on such an implementation -- Thanks!

Hey @pharringtonp19! I don't know how this skipped my inbox 😱
What I got out of that experiment was that moving data into a JAX program via hcb.call was slower. For a single device environment I think its not hard to get a jit-compatible DataLoader interface, however, I am not sure if we would gain anything if its slower.
If you are still interested, can you recreate a benchmark? Maybe a I missed something or had a bug, its just that a 5x slow-down is pretty rough.

@cgarciae Thanks for the response. I will make a benchmark this week and get back to you -- much appreciated


Refactors the internals of JACC

This is rewritten to utilize Julia traits written in a way that replicates SimpleTraits.jl. The traits in this way will only allow one to utilize one backend at a time which is still managed by Preferences.  In this way JACC does not overload the Base.Array name but is still able to construct an array generically using an array function.
One issue with this design is when one lauches JACC JACC.JAT = JACCArrayType{Array} regardless of the preference. Then when one loads the proper backend to match preferences JAT will be reset to reflect the desired preference.

With this implementation, JACC will not work if the preference doesn't match loaded libraries. For example
julia> using JACC
julia> JACC.JACCPreferences.backend
  "amdgpu"
julia> JACC.zeros(3)
ERROR: The backend amdgpu is either not recognized or the associated package is not loaded.
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] arraytype(::Val{:amdgpu})
   @ JACC ~/.julia/dev/JACC.jl/src/helper.jl:15
 [3] arraytype()
   @ JACC ~/.julia/dev/JACC.jl/src/helper.jl:13
 [4] zeros(::Int64)
   @ JACC ~/.julia/dev/JACC.jl/src/array.jl:3
 [5] top-level scope
   @ REPL[969]:1

All AMD, CUDA and CPU tests now pass. I cannot check oneapi because I don't yet have access to an intel GPU

@kmp5VT please see my previous comment

As a non-maintainer of JACC, but a maintainer of packages which solve similar problems (Dagger and DaggerGPU), I'm very much in favor of this PR! I think moving away from making JACC.Array automagically change its type is a necessary direction for JACC to go in.

FYI, @kmp5VT @jpsamaroo we are meeting to discuss these aspects w/ people in the community. You should have gotten a calendar invite. Thanks!

Subsumed by #123


Fix niggling PaginatedDataTable bugs

Prevent header from thinking it can wrap and then overflowing.
Fix default footer string which lost its colon (localized values are fine).
Make the "rows per page" drop-down include at least one value even when the table lacks many items. (Previously it would assert if your table was too short.)
Make the footer scrollable.
Fix some todos and improve some debug output.
Tests for much of the above.
Fixes https://github.com/flutter/flutter/issues/5011.
(This is not on our priority list but I had a branch with fixes for DataTable as a result of fixing the TableBorder regression recently so I figured I should polish it off and submit it.)

LGTM

Thank you sir!


Update web-query-data.md

Instructions incorrectly said "left pane" instead of "right pane" for the newly added "help" cluster.

@bwaldbaum : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@shsagir,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

@bwaldbaum Thanks for your feedback. We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.
#sign-off


[stable/jenkins] fix #13467 (wrong deprecation message)

Signed-off-by: eduardo aleixo<EMAIL_ADDRESS>
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #13467

Special notes for your reviewer:
Checklist

[X] DCO signed
[X] Chart Version bumped
[ ] Variables are documented in the README.md
[X] title of the PR contains starts with chart name e.g. [stable/chart]

/lgtm
Thanks!


Add Modding Support

I already hacked something together, since the official mod manager runs on electron. I hope I can help to add it ^^
https://github.com/fionera/satisfactory-server

Thanks again for your work :) Mod support was already coming in the rewrite, but your work will be helpful! I'll ask you to submit a PR once the rewrite has been pushed.

Did you clone my Repo or this? Because it seems the folder with the modding tool is missing

Hey, Admin of the Satisfactory Modding Discord here :smile: Modding does not work on dedicated servers. Currently the team is working on U5 support but server support will come for sure at some point

Hello, I would like to know if the modding support works or not with your image? I have a little trouble understanding your previous message :)
Thank you very much for the work you have done.

Hello :) Mods are not currently supported by CSS's official server implementation. @fionera built a custom mod handler over my original server implementation, which predates CSS's version.

thank you for your quick response  :)

Do you think this is something you will have time to work on or is it absolutely not in your plans ?

It's not a case of whether or not I have the time or desire to work on it. As this repo now utilizes CSS's own implementation, it's entirely down to when they have the time to implement it (as they have expressed the desire to do so) :)

AHHHH alright, I hadn't understood it like that, thank you :)

+1 for modding support

+1 for modding support

+1 for modding support

@cornernote @Johan-Claesson again, this is a limitation of CSS's implementation. We can't do anything until they officially support it.

(It's not a limitation of CSS's implementation. It's a matter of mods working on servers and us providing mod management tools adapted for a server environment)

(It's not a limitation of CSS's implementation. It's a matter of mods working on servers and us providing mod management tools adapted for a server environment)

Indeed, so it mods don't work on servers, we can't do anything until CSS changes that. Regardless of when mod management tools exist, as soon as their implementation supports mods, so can we.

No, what I'm saying is that it's not up to CSS lol. It's up to us (the modding community)

@Feyko it was my understanding that mods didn't work at all with CSS's implementation per your earlier comment in this thread. Is that not the case, and rather that most mods are incompatible or along those lines?

Mods don't work at all on servers, that's correct. But it's a problem on our end, we have to adapt and fix our tools to allow them to work on servers. It's not CSS that needs to change the game is what I mean :smile:

Ahhhh, I see. Thank you for clarifying :)
Prior to CSS's official implementation, this repo ran the full Satisfactory client so mods did work since it's the same client. I hadn't considered that the implementation of mods themselves would of course be different with a server instance 🤦♂

Heads up, and no, mods on dedicated servers is not a thing yet... but there has been some progress at least.
Look at ficsit-cli and see if that is something that can help for when modded servers become a thing. I wouldn't implement it in yet, since it is not complete. However, might be something good to at least look at on if it will be useful.
I have no experience with docker/kuberates, and I only found this because of TrueNAS Scale/TrueCharts.

Hey @porisius, thanks for mentioning ficsit-cli :) I'm familiar with it, and will keep it in mind for when mods are supported.

Closing this out as it's been stale for over a year, and we're still awaiting mod implementations from other developers :)

Mods exist and work now thanks to the excellent these excellent developers: https://docs.ficsit.app/satisfactory-modding/latest/ForUsers/DedicatedServerSetup.html

@wolveix Let me know if you want this in a new tracking issue but with the new Satisfactory Mod Manager that just came out for Satisfactory 1.0, it introduced immediate support with dedicated servers and offers server mod setup for FTP, SFTP, and path. Do you think it would be feasible to support this in the docker image directly? Maybe by spinning up an optional FTP instance with a configurable port that the mod manager can connect to and manage the server's mods.

@rlnt that's been covered in this repo's readme for months (since SMM first supported dedicated servers): https://github.com/wolveix/satisfactory-server?tab=readme-ov-file#modding :)

In case anyone sees this, I can confirm Satisfactory Mod Manager works with this container using Docker Host SFTP.
However, what was not apparent to me is that in the Satisfactory Mod Manager is how the manager copied the files to the Docker Container.

Mods have to compatible for server. (Must use the website to see this attribute).
The same Mod files must reside on BOTH the CLIENT side as well as on the SERVER side.
In the Mod Manager under the "Manage Servers" section make sure the path is targeting the "gamesfiles" location, the app will help you verify this directory.

In my case the path was here:
Named: Remote 1
/home/admin3/portDATA/satisfactory/gamefiles

Under "Select Game Installation > select "Epic Games" or Steam.. , then "MODS On"
Once you download the mods, place them under your designated profile such as "modded", click check for updates
Under "Select Game Installation > select "Remote 1", select "modded", click check for updates and the mods will be pushed to the docker host.

You may need to run through steps 5-7 to ensure both sides are up to date.

Thanks so much for sharing @brink668!


Keep build.gradle.kts in sync with layout.jelly

Minor tweaks to renovate's config to ensure it updates layout.jelly too when bumping dependencies in build.gradle.kts.

Do we want to merge this? I can't merge anything here 😅


Add link to documentation generated for RedHatInsights/insights-operator-controller/server/test.db

Add link to documentation generated for RedHatInsights/insights-operator-controller/server/test.db

Not appropriate - this is binary file


"time.sleep(retry_after)" and "Invalid client" Error

Content
Nice to meet you.
"My user information(?)" suddenly doesn't work in "spotipy".
For example, nothing happens inputing user id in "sp.user_playlists()", and
"sp.user_playlist_add_tracks()" doesn't reference my "playlist_id".
So I run "control+c", and the program say "~... time.sleep(retry_after)".
This result is the same about any program.
So I tried re-creating the dashboard and re-authenticating again, but "Invalid client" occurred.
I don't know what to do.
The Code
(the following is first code) → "time.sleep(retry_after)" Error
import itertools
import spotipy
import spotipy.util as util
from datetime import date, timedelta
import time
import sys

username = ''
my_id ='' #client ID
my_secret = '' #client secret
redirect_uri = 'http://localhost:8888/callback/'

scope = 'user-library-read playlist-read-private playlist-read-collaborative playlist-modify-public playlist-modify-private'

token = util.prompt_for_user_token(username, scope, my_id, my_secret, redirect_uri)
sp = spotipy.Spotify(auth = token)

#
yesterday_numeric = date.today() - timedelta(days=1)
yesterday_string = yesterday_numeric.strftime('%Y-%m-%d')
'''  '''
all_playlist_name = sp.user_playlists(username)
'''  '''
playlist_url_YN = []
for items_1 in all_playlist_name['items']:
    if yesterday_string == items_1['name']:
        playlist_url = items_1['external_urls']['spotify']
        playlist_url_YN.append('yes')
    else:
        pass
if playlist_url_YN == []:
    sp.user_playlist_create(username,yesterday_string)
    '''  '''
    all_playlist_name_2 = sp.user_playlists(username)
    '''  '''
    for items_2 in all_playlist_name_2['items']:
        if yesterday_string == items_2['name']:
            playlist_url = items_2['external_urls']['spotify']
        else:
            pass
else:
    pass

start = time.perf_counter()

#
''''''
alphabet = ['a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v','w','x','y','z']
artist_urls = []
for i in range(3):
    if i == 0:
        pass
    else:
        for v in itertools.permutations(alphabet,i):
            def Search_Artist_Loop(a=0):
                '''  '''
                all_1 = sp.search(q=''.join(v),limit=1,offset=a,type='artist')
                '''  '''
                for items_3 in all_1['artists']['items']:
                    artist_urls.append(items_3['external_urls']['spotify'])
                if a == 950:
                    pass
                else:
                    Search_Artist_Loop(a=a+50)
            Search_Artist_Loop()
            print(len(artist_urls))
            artist_urls = list(set(artist_urls))
            print(len(artist_urls))
        print(str(len(artist_urls)) + ' artists...')

end = time.perf_counter()
print(end - start)

''''''
yesterday_release_musics = []
def Search_Artist_Album_Loop():
    for items_4 in artist_urls:
        def Search_Artist_Album_Loop_2(b=0):
            time.sleep(0.01)
            '''  '''
            all_2 = sp.artist_albums(items_4,limit=50,offset=b)
            '''  '''
            for items_5 in all_2['items']:
                url_1 = items_5['external_urls']['spotify']
                time.sleep(0.01)
                '''  '''
                release_date = sp.album(url_1)['release_date']
                '''  '''
                if yesterday_string == release_date:
                    '''  '''
                    for items_6 in sp.album(url_1)['tracks']['items']:
                        '''  '''
                        yesterday_release_musics.append(items_6['external_urls']['spotify'])
                else:
                    pass
            if all_2['total'] < b+50:
                pass
            else:
                Search_Artist_Album_Loop_2(b=b+50)
        Search_Artist_Album_Loop_2()
Search_Artist_Album_Loop()
yesterday_release_musics = list(set(yesterday_release_musics))
print('Finish Searching !!')

end = time.perf_counter()
print(end - start)

#
if yesterday_release_musics == []:
    pass
else:
    '''  '''
    sp.user_playlist_add_tracks(username,playlist_url,yesterday_release_musics)
    '''  '''
print('Finish All !!')

(the following is second code) → "Invalid client" Error
import spotipy
import spotipy.util as util

scope = 'user-library-read playlist-read-private playlist-read-collaborative playlist-modify-public playlist-modify-private'
token = util.prompt_for_user_token(
    'my_user_id',
    scope,
    client_id='my_new_client_id',
    client_secret='my_new_client_secret_id', redirect_uri='http://localhost:8888/callback')

sp = spotipy.Spotify(auth=token)
print('ok')

Other
It happened while I was writing and running the program.
Maybe, I was stopped from using the program because of the large number of requests?
I’d like to ask you for your help on this problem please.
Environment

Spotify Plan
Premium
Device
Macbook Air (M1, 2020)
Operating System
macOS Monterey 12.0.1

I'm a beginner in programming and I think they are poorly coded, and this is my first time using "Github".
So please forgive me for any unsightly parts.

I was able to solve the problem on my own.
By clearing the cache file in my home directory, the error does not appear!!


Make numbers more consistent

Makes numbers more consistent between prose formatters and the global number command.
Increase consistency and additional delimiters for different locales
Fixes #1245

There's one other inconsistency that might be worth addressing while in here, or as a separate issue:
can't dictate negative numbers with decimals.

Fixes applied.
Negative decimal numbers for something I thought about but since we have a specific signed numbers for integers do we need something similar for decimals or should we just make one capture supporting both? I think we should leave that as a separate issue.

Issue filed
https://github.com/talonhub/community/issues/1615


upgrading to dash==1.12.0 on dash-opioid-epidemic

Upgrading this app to use dash==1.12.0 . The upgrade will allow for a domain restriction to be placed on the mapbox token for the gallery apps without encountering map rendering issues. See #426  for details
App pull request

[ ] This is a new app
[x] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-nightly.plotly.host/dash-opioid-epidemic/
Current gallery app URL: https://dash-gallery.plotly.host/dash-opioid-epidemic/

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[x] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] If the app is a reimplementation of a Python gallery app for the
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
[x] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

just ran it locally myself, LGTM 💃


Some of my mods haven't been updated on CKAN

Hello, I've updated 5 days ago all my mods to KSP 1.0.4 and 3 of them haven't been updated on CKAN. I don't know what I can do?
QuickRevert [v2.11 - 2015.06.26]:

https://kerbalstuff.com/mod/237
https://github.com/KSP-CKAN/CKAN-meta/tree/master/QuickRevert
https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/QuickRevert.netkan

QuickMute [v1.06 - 2015.06.26]:

https://kerbalstuff.com/mod/509/QuickMute
https://github.com/KSP-CKAN/CKAN-meta/tree/master/QuickMute
https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/QuickMute.netkan

QuickContracts [v1.02 - 2015.06.25]:

https://kerbalstuff.com/mod/539/QuickContracts
https://github.com/KSP-CKAN/CKAN-meta/tree/master/QuickContracts
https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/QuickContracts.netkan

NetKAN is failing to parse the embedded AVC .version files. In each case, it's failing to parse because there's no comma between the DOWNLOAD and VERSION properties. There's an open issue (KSP-CKAN/CKAN#1199) to handle this situation more gracefully.

Thanks for the answer, I will update my .version files on my next mods update.


fsd

sdf

Hi @ukreddy-erwin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

zcxc


fix start position in onDragSelectionUpdate

fix issue introduced in https://github.com/simpleclub-extended/flutter_math_fork/pull/64/files#diff-48cfc2520f09f02aa90ae6a10b1e5721a4ec16ba2d5459f9ee1d08585d7115c9R172

LGTM, thank you @p-mazhnik!


Improved: Upgraded axios version to latest 1.2.1(#85zrgn3aw)

Related Issues

Closes #306
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

closing PR, not handling api call in apps anymore, moving to NPM package


[BUG] BlobClient.UploadAsync with a stream always buffers the entire stream

Describe the bug
When trying to write a lightweight service that receives content in a Stream and passes it on to a blob upload, I encountered pathological buffering of the entire Stream content.
I believe this to be caused by way the blob client implementation uses HttpClient.

BlobClient.UploadAsync(Stream) calls the extension method BlobOperationsExtensions.UploadAsync
BlobOperationsExtensions.UploadAsync calls BlobOperations.UploadWithHttpMessagesAsync
BlobOperations.UploadWithHttpMessagesAsync sets up an HttpRequestMessage, setting its Content property to an instance of StreamContent with the supplied Stream
This HttpRequestMessage is then delivered using HttpClient.SendAsync
HttpClient.SendAsync handles the message using the HttpClientHandler class
The PrepareAndStartContentUpload method in the HttpClientHandler class checks if the HttpContent object it has been given specifies a Content-Length header. If no Content-Length header is provided, then it buffers the content in order to determine its length.

But, the HttpContent in question is the StreamContent initialized earlier by UploadWithHttpMessagesAsync in BlobOperations, and it does not set a Content-Length header.
Expected behavior
Data is transferred from the stream in manageably-sized chunks, so that memory usage is well-known regardless of the stream size. Specifically, if the Stream is seekable, then the stream's Length should be used for the Content-Length header value automatically. (This strategy is used in other ways inside StreamContent in its TryComputeLength method.)
Actual behavior (include Exception or Stack Trace)
If the stream contains 500MB of data then the process memory usage will grow by 500MB before the blob upload operation actually initiates the network connection to the Azure servers. If the stream contains more than 2GB of data then the blob upload operation will fail because MemoryStream will refuse to store more than 2GB of data.
To Reproduce
Using a BlobClient, use an UploadAsync operation that accepts a Stream for the data. Provide a FileStream pointing at a large file for the effects on process memory to be more easily noticeable.
Environment:

Azure.Storage.Blobs 12.10.0
Windows 10 .NET Core 3.1
Visual Studio 16.11.3

My analysis, just to provide additional information, is based on two independent things:

Observing memory usage grow very rapidly in a process that is running on .NET Core 3.1 and uploading a large file.

Looking at the implementation of UploadAsync in GitHub.

I am poking at it further to gather more information and confirm or deny my hypothesis.

The first link, from BlobClient.UploadAsync to BlobOperationsExtensions.UploadAsync, is the result of GitHub's analysis and cross-linking, but on closer analysis, it's a false positive. There isn't actually any connection between those two things, as far as I can see.
But, I do see a massive increase in memory usage trying to upload a large file with BlobClient.UploadAsync.

I inspected the code and found that the upload process, in inherently supporting retries, requires that earlier data in the stream be accessible. As such, if you supply an unseekable stream, it must copy it to a seekable buffer to support retries.
Further inspection revealed that it is possible to disable parallel transfers with MaximumConcurrency setting in BlobUploadOptions and set the size of the block it will treat as a unit in performing the upload with MaximumTransferSize.
This gave me an idea for a possible way to support upload of an unseekable stream in a resource-constrained environment: An intermediate stream with a ringbuffer of the most recently read data, allowing seeking but only as far back as the ringbuffer extends. This is not an entirely trivial thing to implement, but this morning I managed to create a working implementation.
With this implementation, I can wrap my unseekable stream in one of these BufferWindowStream objects, as I called them, with the ringbuffer size set to equal MaximumTransferSize. In the event of a failed block, it should only rewind the stream by the size of that one block, which will then re-read the data out of the ringbuffer before proceeding. (I have not yet verified that it will never rewind by more than the block size.)
Running this code, I can upload a multi-GB file to Azure Blob Storage streaming it through an intermediate web server running on Kestrel without the web server's memory usage exceeding 90 MB.
Since the intersection of unseekable streams and very large amounts of data can't be that rare, perhaps it would make sense to integrate this approach into BlobClient itself?

Update: I interrupted the network after the first block had been staged, which in theory should only have required retrying the second block, but the Azure Blob Storage SDK code wanted to rewind the stream right back to the start even though the first block should have already been sent. 🤔

Looking at the code more closely, in theory, letting it use GetBufferedPartitionInternal should be close to identical, functionally. But, there is no way to communicate the length of the stream if it is not seekable.

I believe I have resolved that issue. It required StorageTransferOptions.InitialTransferSize to be set to a value no larger than the ringbuffer size. :-)
So, I think I have a valid work-around, but it's an awful lot of work to support large restartable uploads on non-seekable streams in a resource-constrained environment:

It requires sophisticated code on my end to buffer only just as much of the stream as is needed to allow for retries.
It requires StorageTransferOptions to be set up in just the right way.

I don't have an in-depth understanding of the code inside the Azure Blob Storage client, but if I understood what I saw correctly, it has the ability to do a partitioned upload in a way that limits memory allocation, but the current implementation simply cannot avoid full-stream buffering if the supplied Stream isn't seekable.

@jaschrep-msft can we please create a documentation task to get this documented in the backlog?

@logiclrd if your StorageTransferOptions are correct (which you seem to have figured out over the course of this issue) then this buffering as needed code is already in the SDK for you. You should be able to remove your intermediate buffer with your appropriately tuned transfer options and see a limitation on the amount of data you buffer at any given time.

For safety/retry purposes, the SDK will not upload data from a stream that is not seekable
We buffer unseekable data to make it seekable
We buffer seekable data if parallelism is desired
Due to the nature of the REST layer, entire REST uploads must be retried from the start
BlobClient breaks up your large upload into multiple smaller REST uploads based on StorageTransferOptions
Buffering of unseekable streams happens lazily on a per-REST basis

a buffer of size n in acquired, where n is the size of the next REST upload to perform
next n bytes are read from the unseekable stream into this buffer
buffer is used as a seekable stream to perform a retryable upload
buffer is released upon success

Initial transfer size when dealing with an unseekable stream happens before any other uploads are attempted

Because of this, the SDK should never be buffering more than either InitialTransferSize or MaximumTransferSize * MaximumConcurrency on a rolling basis as it works through the provided unseekable stream.
I believe this bug to be nonexistent and only reported based on a misunderstanding of the API. I will be closing it. If there is concern that the above description of the BlobClient upload process is incorrect and we are actually buffering far more, feel free to reopen.
I will be scheduling work to make this information more discoverable, per @amishra-dev's request.

Indeed, it appears that the key thing was having StorageTransferOptions fully-populated. With default options, it would always try to ascertain the length before starting the upload, buffering the entire stream in the process. But, now that InitialTransferSize and MaximumTransferSize are set, the original unseekable stream can be provided without memory usage growing without bound.
I just did a transfer of a 2.7 GB file, and memory usage climbed continuously for a good 10% of the transfer, but more and more slowly as time went on, and eventually reversing direction and gradually dropping, slowly fluctuating.

It started at 75 MB and climbed quickly at first.
When the transfer reached 275 MB, memory usage was about 143 MB.
By 425 MB, it was at 154 MB, and it appeared to have essentially plateaued. Memory usage continued to fluctuate, for instance hitting about 162 MB around the 800 MB point, but it subsequently dropped back down as low as 140 MB.
Just before the 2 GB mark, however, it had dropped back as far as 120 MB. By 2 GB it was back up to 132 MB.

I repeated the test with MaximumConcurrency set to 5 with very similar results. In both tests, I interrupted the network to verify it could restart and found no issues.
To be clear, forwarding this file transfer from an incoming web request to an outbound BlobClient.UploadAsync call is the only thing the process was doing.
I'm not sure why memory usage increased so much with a single upload thread and a 512 KB buffer size. Perhaps it is something within the ASP.NET Core stack or Kestrel. In any case, it didn't end up trying to store the entire 2.7 GB file in a MemoryStream as it had originally.
Documentation that calls out the significance of the stream being seekable and the importance of InitialTransferSize and MaximumTransferSize for non-seekable streams would indeed be very helpful. :-)


Class Goals

Let's find out everyone's goals.
Please comment on this issue letting me know one goal you have for today's class.
My goals are:

[ ] Learn how GitHub works
[ ] Learn about the GitHub Flow
[ ] Merge conflicts

@githubstudent - What would you like to learn?

my goal for this class:

git cmd in details
git flow
some UI tools (we're using SourceTree) vs git cmd

my goal for this class:
git cmd in details
git flow

I've added my goals under doc/bio


IMAP: Ignore errors during LOGIN fallback

From the log in #6744 I reconstructed that the communication with the IMAP server went like this (simplified):
…
C: 2 AUTHENTICATE PLAIN [credentials]
S: 2 NO AUTHENTICATE failed
C: 3 LOGIN [credentials]
S: * BYE IMAP server terminating connection
S: [server closes connection]

We have code to fall back to using the LOGIN command when AUTHENTICATE PLAIN fails. In this case the server closed the connection instead of sending a negative response to the LOGIN command. K-9 Mail treated this as an intermittent connection failure and ignored it.
This change throws the original AuthenticationFailedException in case the LOGIN command throws anything but an AuthenticationFailedException. This makes sure an authentication error notification will be created.
Fixes #6744

Detekt error:

mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:444:17: Too many throw statements in the function saslAuthPlainWithLoginFallback. The maximum number of allowed throw statements is 2. [ThrowsCount]

Is ThrowsCount a useful rule? Should we disable it?


can we access different env under same tag using @env variable.

I have used same tag for two different feature files and looking to pick env stg1 for feature file A and stg2 for feature file B.
For run  configuration is yml file like something below
Current configuration which pick feature files/scenarios to run on one kind of env

(name regression tests) mvn clean test -Dtest=KarateTests#regressionTests -Dkarate.env=stg1 -Dkarate.config.dir="./" -Dpublish.testburst=true -Dkarate.options="--tags @COMMONTAG1"

call: getReportSummary_forSlack
call: publishReportSlackNotificationSuccess(var channel = 'regression', var msg = "Success! US ECOMM Regression Test Report  - Env selected - stg1 - PMID - FAAA Report Summary $SUMMARY_SLACK")

@askkarate sorry, such questions belong on stack overflow. if you need to explain a complex case that does not work, please follow this process: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue


Improving Skills List with Icons

What This PR Does

Uses the Devicons icon library to replace the skills list (.Params.skills) with icons.
Uses aria-labels for accessibility and rems for icon sizing

Files Edited

Single Author Template Layout - /layouts/authors/single.html
Louise Findlay's Author Profile - /content/authors/louise-findlay/index.md

How to Test

Checkout this PR branch
Start the local hugo server - hugo server -D
Navigate to localhost:1313/authors/louise-findlay
Verify that the Skills section shown matches the screenshot below and that the Skills section is still absent on authors' front-matter without the correct metadata

Screenshot

Potential Improvements

Move the in-line CSS style for the .skills class to a CSS file - @hborrelli1, would the /assets/scss/compentents/_author-blocks.scss file be the most appropriate?
Add some spacing between the icons and the social media links below

Related Issue
This closes #7087.

Closed due to additional commits in the branch from the forked master. Cleanly recreated in #7089.


update nteract_on_jupyter to 1.6.0

Upgraded nteract_on_jupyter.
I also took the liberty of gitignoring the conda built outputs that are not tracked (according to https://github.com/jupyter/repo2docker/blob/master/CONTRIBUTING.md#conda-dependencies).

LGTM. Waiting for travis.

In the longer term we should think about when/if we freeze for good some dependencies. Maybe at the same time as we freeze the base image?


an infinite problem in a file

We have written the needed data into your clipboard because it was too large to send. Please paste.

I'm working on a discord bot, and theres this infinite red underline, i delete the letter its on and it goes to the next and so on


/Services has no documentation and returns inconsistently.

The /Services endpoint currently had no documentation whatsoever.
Additionally, and perhaps more worryingly, a service object as returned by a GET to /Services looks like this:
{
    "product_id" : 18,
    "provision_status" : null,
    "project_description" : "Project description",
    "id" : 20,
    "latest_alert_id" : null,
    "service_description" : "Ruby on Rails Stack",
    "service_name" : "Rails Stack",
    "project_id" : 3,
    "project_name" : "Blog"
  }

But a service object returned when bundled with a GET to /Projects like the 16 parameter leviathan found in the web interface (/Projects?includes[]=services for example) looks like this:
{
		"id": 17,
		"order_id": 5,
		"cloud_id": 1,
		"product_id": 5,
		"service_id": null,
		"provision_status": null,
		"created_at": "2015-04-23T19:59:40.456Z",
		"updated_at": "2015-04-23T19:59:40.456Z",
		"deleted_at": null,
		"project_id": 2,
		"miq_id": null,
		"uuid": "4b0185f0-c309-4a1a-b3be-c9c0438b945d",
		"setup_price": 1.99,
		"hourly_price": 0.004,
		"monthly_price": 0.1,
		"payload_request": null,
		"payload_acknowledgement": null,
		"payload_response": null,
		"latest_alert_id": null,
		"status_msg": null
	}

@jklarfeld - this is a work in progress. Services are a proxy for OrderItems. Rather than add unnecessary paths and logic to the OrderItemsController, @AllenBW and I created the ServicesController to return custom JSON data that he could then feed into D3 and other ux functionality. No documentation yet b/c we are still adding/refactoring this controller.


Update README.md

updated the readme to specify that this library needs Python >= 3.11

yeah, poetry is pinning 3.11.
It causes pip install upiano to fail if executed in Python != 3.11


Initial Block Processing Logic

Description
Implement the block processing logic as described in this section of the beacon chain spec

Note: Not all the logic in the spec is finalized.  Follow Danny Ryan's recommendation by implementing the logic that is well defined.  See pseudo code below.

pseudo code:
    # per-block processing
    if block:
        # handle block header
        verify_signature(state, block)
        verify_and_update_randao(state, block)

        # handle block body operations
        process_attestations(state, block)

Acceptance Criteria

Add the logic to the blockProcessor method in StateTransition.java - see here
Add appropriate tests

Blocked by #145

closed by #230 and #232


Delete timetable id endpoint

weird

Not happy with a bunch of code in this PR, reverting.

Your branch has been restored, make a new PR and we'll work on merging this again from there.


Internal/public accessor hunt

As part of v4, ruthlessly go over the codebase and mark any type that shouldn't be exposed to clients as internal. Use the [InternalsVisibleTo] trick to sidestep that as a problem for the test suites.

To clean up:

Remove the AllProjectionsFor and AllForView methods added to keep backward compatibility. Make ProjectionsFor and ForView methods return properly IEnumerable. Consider those and other related members as internal (they're not used anywhere besides single internal logic.
Move Async methods without token in QuerySession to QuerySessionExtensions (and look for similar places).


Add link on travis badge

Maybe you could add an entry in the changelog. or maybe not, it's a minor change that won't impact users.

I have to admit the sole reason for this PR is actually to have the travis build and see how it goes. And as you can see...

LGTY then ?

Yup. But it's weird, the builds have failed.

And thanks to this PR, we know :)
I'd better have a failing build written on the front page of the repo than a broken promise of a passing build
So next thing to do is to fix travis. But now we know it's broken !


Doppler False Coloration not Tilt Corrected

Hi Cèdric. This issue is not a regression, it seems to have been present since I started using jSolEx, but became noticeable enough yesterday that I decided to report it. In the two attached dopplergrams, the solar disk and surface details are properly corrected for the angle P (about 26 degrees), but the false coloration seems to show the hemisphere division still with the uncorrected tilt. I don't think there is a setting I have set incorrectly.
Steve

I'll have more details this evening (tomorrow morning UTC) - I'll give settings and have a link for an SER file. I always use the tilt autocorrect and it works well. What I noticed was that the disk and features were properly autocorrected, but the coloration in doppler is not. More details tonight.
Thanks Cédric,
Steve

On Oct 28, 2024, at 10:21, Cédric Champeau @.***> wrote:
Hi,
Sorry for the late answer, but I don't think I understand the problem you are describing. I've done the following :
process an image without the automatic angle P correction and looked at the doppler image
checked the angle P correction of that image, seeing the image rotate. The blue/red areas are also moving according to the angle
reprocessed the same file with autocorrection checked this time, and I'm seeing the same image as the one with manual application of the correction
Can you share more details?
—
Reply to this email directly, view it on GitHub https://github.com/melix/astro4j/issues/430#issuecomment-2442187937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4JHEBA6EUUIT7JRMKI4C3Z5ZQB5AVCNFSM6AAAAABQIY2462VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSGE4DOOJTG4.
You are receiving this because you authored the thread.

Hi Cédric. I have uploaded a ser file to my Dropbox and will send a link to your gmail address.  Attached is a doppler photo corresponding to that ser file. Normally my scans are done in the morning - this was done in the afternoon, and so a meridian flip caused me to use different settings to set up the "Autocorrect P angle" than I normally use. I always use the Autocorrect P angle function.
For this ser file with meridian flip I used: "Flip horizontal axis," and left "Switch red and blue channels" and "Flip vertical axis" unchecked. (In the mornings without meridian flip I have all of these options checked).
The important thing to note is that the solar disk and surface features are properly tilt corrected, but the false coloration has a tilt. I notice this in morning scans too, but the doppler shift coloration is less pronounced, although with roughly the same amount of tilt.
I am sending the ser file link to your gmail. Scan was made at 21:07 TU on 19 Oct 2024.
steve

So obviously there's something wrong with banding in this test SER file, but it's actually good since we can see what's happening more clearly :) Here's the image I get without P correction:

Now, if I check P angle correction:

So it looks to me that it behaves correctly? Why would you expect the doppler to be "un-tilted"?

Sorry about that, I got the orientation wrong. Here's the non-P corrected Doppler:

and here's the P-corrected one:

I'm really sorry but I still don't see your point here.

The doppler coloration in large part shows blue on the approaching side of solar rotation, and red on the receding side of rotation. The axis of rotation, when p-corrected, is exactly vertical. So the division between red and blue should also be vertical, and definitely without this strong tilt. And the tilt angle of the bands is roughly the same as when the sun does not have p-angle corrected (although the tilt here is in the opposite sense).
It behaves as if the coloration is acting on the uncorrected p-angle image, and not on the corrected image.

Oh, now that you are explaining this... it makes lot of sense as the nose on your face. I don't understand why, this is really curious. Let me think about it.

Cédric: I processed the same SER file with INTI and got a similar result with Valerie's code: the disk is aligned but the doppler coloration is tilted. So the phenomenon is in her code too. Not sure yet if anyone has reported it on her end...
Doppler image using INTI (contrast a bit overstretched....)

I have made some more tests, using a variety of old scans. I think what you're seeing here is an artifact of "bad" data (e.g here the banding due to reflection probably). Getting a doppler which actually shows the sun rotation is not that trivial. I think it's actually easier to get one by having a scan in DEC instead of RA.
The reason I'm puzzled is because there's nothing really magic in computing the Doppler. The only thing which is done is assigning the blue wing to the blue channel, the red wing to the red channel, and the average of the two to the green one. Therefore, there's no "artificial coloring" going on after some transform: the colors are the data. From the previous scans I've used, I have seen that in most of my Dopplers, the W/E separation is not that obvious, and often shows a "leak" of the blue in the north pole and in the middle to the east direction. The weather conditions are probably influencing, but as I said probably also the scan direction and the speed of scan.

Thanks Cédric - that's a pretty thorough explanation, and agrees with my usual results with doppler like the one below. The rotation coloration is more subtle. I believe I still perceive a tilt in the gross coloration associated with rotation (here the "blue chunk" is tilted upward slightly), but perhaps this is an artifact caused by scanning in RA. I could try scanning at 2x RA to see if this changes; normally I scan at 8x (or 20x for stacking frames).
Actually, the fact that I see local coloration around active areas like sunspots, and this is correctly aligned should tell me that there is no mis-alignment between the coloration and the tilt correction.  I'll try the 2x experiment this morning and post the result here just to see if scan rate affects the perceived color "tilt" due to rotation. But I think there is no problem with the code.

Christian seems to confirm that the result is expected and likely due to weather conditions. See https://groups.io/g/Solex-project/message/11022

Cédric:
I've taken comparison scans at 1x and 8x siderial rate. Let me post the comparison and then I think we can close this.
I think it would be useful to know if scan rate affects the artifact, just as a clue as to what's going on. I do see a slight tilt in coloration, as mentioned before, even in excellent weather. I think it may be due to using a short focal length doublet, where the focal plane still has a slight sphereicity - it's not perfectly flat. This is a subtle effect.

On Oct 30, 2024, at 08:50, Cédric Champeau @.***> wrote:
Christian seems to confirm that the result is expected and likely due to weather conditions. See https://groups.io/g/Solex-project/message/11022
—
Reply to this email directly, view it on GitHub https://github.com/melix/astro4j/issues/430#issuecomment-2447609064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4JHEHM4PPHVZDMVRNBKDLZ6D52XAVCNFSM6AAAAABQIY2462VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGYYDSMBWGQ.
You are receiving this because you authored the thread.

Okay, here's this morning's RA scan at 8x sidereal:

And here at 1x sidereal:

So, this leads me to believe this is an effect of seeing and atmospheric turbulence. The 140 second scan had much more banding and coloration. Perhaps the turbulence causes physical motion of the peaks in the spectral line, which distort both the feature data and the doppler data.
This seems to be a real physical effect and the software is fine. Please close this ticket whenever you wish. Thanks Cédric! This was a learning experience.

Thanks, I learnt something too!


Create LICENSE

Hello ibaiGorordo !
I have downloaded "IWR1443-Read-Data-Python-MMWAVE-SDK-1-master" from your website.
When I run it does not show any plotting point in graph .
error shown on graph plot by prog is: " not responding".
would you please guide me why is it happend?


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.fronius

[ ] [E145] No news found for actual version 1.1.6
[ ] [E154] common.dependencies must contain{"js-controller": ">=2.0.0"} or {"js-controller": ">=3.0.0"}
[ ] [E504] found setInterval in "main.js, but no clearInterval detected
[ ] [E605] No actual year found in copyright. Please add "Copyright (c) 2022 ldittmar<EMAIL_ADDRESS>at the end of README.md
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2022 ldittmar<EMAIL_ADDRESS>at the start of LICENSE

Thanks,
your automatic adapter checker.

obsolete - will be checked with 2.0.0 release building anyway

Thanks, that all bugs have been fixed.


[SPARK-29979][SQL]Add basic/reserved property key constants in Table and SupportsNamespaces

What changes were proposed in this pull request?
Add "comment" and "location" property key constants in TableCatalog and SupportNamespaces.
And update code of implementation classes to use these constants instead of hard code.
Why are the changes needed?
Currently, some basic/reserved keys (eg. "location", "comment") of table and namespace properties are hard coded or defined in specific logical plan implementation class.
These keys can be centralized in TableCatalog and SupportsNamespaces interface and shared across different implementation classes.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Existing unit test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@cloud-fan @imback82 @dongjoon-hyun
Could you please help review?
Thanks.

ok to test

Test build #114265 has started for PR 26617 at commit f0a3e4d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19108/
Test PASSed.

This makes sense to me. These special properties have specific meanings, and the data source developers should be aware of them. It's better to put them in the DS v2 API, with comments to explain what they are.
what do you think? @rdblue @brkyvz @imback82

Test build #114272 has started for PR 26617 at commit 929ced6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19115/
Test PASSed.

Test build #114274 has started for PR 26617 at commit 0777cb2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19117/
Test PASSed.

Test build #114265 has finished for PR 26617 at commit f0a3e4d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114265/
Test PASSed.

Test build #114272 has finished for PR 26617 at commit 929ced6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #114274 has finished for PR 26617 at commit 0777cb2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114274/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114272/
Test FAILed.

This makes sense to me. It's better to put them in the DS v2 API, with comments to explain what they are.

+1, I like this idea.

Could anyone help check this?

Test build #114394 has started for PR 26617 at commit ec1d3a5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19233/
Test PASSed.

Test build #114396 has started for PR 26617 at commit 19499cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19235/
Test PASSed.

Test build #114394 has finished for PR 26617 at commit ec1d3a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114394/
Test PASSed.

Test build #114396 has finished for PR 26617 at commit 19499cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114396/
Test PASSed.

thanks, merging to master!

looking forward to your 2 followups:

renaming SupportsNamespace to NamespaceCatalog
improve DesribeTableExec

@cloud-fan, @fuwhu, @imback82, why would we rename SupportsNamespace? That seems like an unnecessary aesthetic change that only increases code churn without real value. What is the purpose?

@rdblue It's a little weird to have only a TableCatalog and others are SupportsNamespace, SupportsView, SupportsFunctions, etc. I think these catalogs should be equal. Do we have a theory to justify it?

@cloud-fan, the proposal was for TableCatalog, ViewCatalog, and FunctionCatalog. All of those can optionally support namespaces, which is why SupportsNamespaces is a mix-in for any catalog. A NamespaceCatalog doesn't make sense on its own.
I don't think there's value in renaming the interface. We can talk about it at the sync, but right now I'm -1 on the idea.

ah I see. So namespace is a basic object that is needed for table/view/function, and thus doesn't need a dedicated catalog. Makes sense to me, let's drop the renaming.


Move (Server).DisableOpenapi to a route option

The (Server).DisableOpenapi and the two functions below must be removed in favor of a route option named fuego.OptionShowInOpenAPI(bool) and its alias option.ShowInOpenAPI(bool). Can be useful in some cases (the user is serving HTML for example...).
// Hide prevents the routes in this server or group from being included in the OpenAPI spec.
func (s *Server) Hide() *Server {
	s.DisableOpenapi = true
	return s
}

// Show allows displaying the routes. Activated by default so useless in most cases,
// but this can be useful if you deactivated the parent group.
func (s *Server) Show() *Server {
	s.DisableOpenapi = false
	return s
}

@EwenQuim you cool with me grabbing this one. I actually haven't moved any server level stuff to the options pattern yet?

No problem. As you saw I'm trying to create "good first issues" (easy, not priority) to try onboarding new contributors, but no problem for you to try to take one or two!

I figured, and yes I also think it's best for me to avoid these, but I don't think i've touched a group level config since i showed up on this project figured it was a good time to refresh myself 😄


vite-plugin-pwa fails when vite-plugin-glsl is also used

vite-plugin-pwa build fails when GLSL (*.glsl) files are processed with vite-plugin-glsl.
It looks like vite-plugin-pwa tries to treat *.glsl files as JS and fails.
But I can't find a way to instruct vite-plugin-pwa to ignore *.glsl files. There is no exclude or ignore configuration properties.
import react from '@vitejs/plugin-react';
import {defineConfig} from 'vite';
import glsl from 'vite-plugin-glsl';
import {VitePWA} from 'vite-plugin-pwa';

export default defineConfig({
  plugins: [
    glsl({
      compress: true,
    }),
    react(),
    VitePWA({
      strategies: 'injectManifest',
      srcDir: 'src',
      includeAssets: 'public/sample-images',
      filename: 'service-worker.ts',
      injectRegister: false,
    }),
  ],

  worker: {
    plugins: () => [
      glsl({
        compress: true,
      }),
    ],
  },
});

x Build failed in 1.66s
error during build:
src/services/image/filter/glsl/color-correction.glsl (1:9): Expected ';', '}' or <eof> (Note that you need plugins to import files that are not JavaScript)
file: /home/evgeniy/projects/artistassistapp/src/services/image/filter/glsl/color-correction.glsl:1:9

1: #version 300 es
            ^
2:
3: precision mediump float;

    at getRollupError (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/parseAst.js:395:41)
    at ParseError.initialise (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/node-entry.js:13252:28)
    at convertNode (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/node-entry.js:14963:10)
    at convertProgram (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/node-entry.js:14206:12)
    at Module.setSource (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/node-entry.js:15949:24)
    at async ModuleLoader.addModuleSource (file:///home/evgeniy/projects/artistassistapp/node_modules/rollup/dist/es/shared/node-entry.js:19827:13)

It turned out that I need to add glsl plugin to injectManifest.buildPlugins.vite:
VitePWA({
  // ...
  injectManifest: {
    buildPlugins: {
      vite: [
        glsl({
          compress: true,
        }),
      ],
    },
  },
}),


chore: bdd-gh-1584363565 to 0.0.1

chore: Promote bdd-gh-1584363565 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Bump up aiofile version constraint

update pin per https://github.com/huge-success/sanic/issues/1952, since v0.6.0 has been released

@yunstanford Good to see you again.


C function return "float" number

Combinatorics.C(25, 20) = 53129.99999999999
Expected: 53130
https://jsfiddle.net/27sf94k1/

It's because C is defined as P(m, n) / P(n, n) and P(25,20) returns 1.2926008369442487e+23, too big for Number to keep its integral value (129,260,083,694,425,000,000,000).  Time to add BigInt support?

Version 0.6.0 (https://github.com/dankogai/js-combinatorics/commit/10374fc4e3f77fc05ee7eb765263adf311206885) now supports BigInt.
> Combinatorics.factorial(100)
9.332621544394418e+157
> Combinatorics.factorial(100n)
93326215443944152681699238856266700490715968264381621468592963895217599993229915608941463976156518286253697920827223758251185210916864000000000000000000000000n
>


Custom editor: find widget?

Refs: #91325
I think we need to revisit what it means to have the find widget enabled for a custom editor?

Maybe better for now to only allow for the other option to retain the webview when hidden.

And specific concerns about allowing the find widget?

@mjbvz how can I use it from my custom editor? I think it is a good idea to allow for it, I was just not sure how to utilize it.

Custom editors use the same find widget that we support for webviews:

The find operation itself is all handled by the webview (electron). In the future, we could also add hooks that let extensions control how the find operation works  but let's see if extension authors express interest in this


Office-ui-fabric-react in GA

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Observed Behavior
Guys, first of all congrats with the GA release. Great job!
In the Release Notes, there is this line:

We have temporarily removed office-ui-fabric-react from the react template until we can get the package moved to a future-proof form. We expect that to take a couple of weeks.

What does this mean exactly? Can we no longer use it in React webparts (for now)? Or should we simply include the package ourselves when developing? And does this also mean we can include any version we want for now?
Thanks, and again: awesome job!

Hi @NickSevens, we are about publish a more detailed advisory and the plan around office-ui-fabric-react soon. Will let you know when that is available.

Thank you for the update @manishgarg1.

I managed to include and use fabric react on sp framework however encountered issue on including fabric components css.
https://github.com/OfficeDev/office-ui-fabric-react/issues/1162

@manishgarg1 any update on this?
Thank you.

Hi @NickSevens, we are working on documented guidelines how to use office-ui-fabric-react and office-ui-fabric in web parts. And also what are the options if you are not using React. Soon we should be able to share the white paper. Please note, due to global CSS all around and lack of native CSS scoping solutions in the browser, this is a non trivial problem.

Sorry for the delay.  Doc is here - https://dev.office.com/sharepoint/docs/spfx/web-parts/guidance/office-ui-fabric-integration.