Add version check to CLAW update [v8]

Description of the Change
Before updating CLAW with new release version, make sure the new version is not already present in the list. If the new version already exists, then something has gone wrong with the release process, so it exits.
Why Is This PR Valuable?
Prevents duplicate entries to CLAW.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?

Thank you @moleske .


[Proposal] Eloquent Observers

Me and @JesseObrien have been playing around with the idea of adding Observers to Eloquent. Basically, allow an external class to hook into Model Events to provide reusability.
Here's a draft of somewhat resembling what we hope to achieve.
<?php
class User extends Eloquent
{
  protected static function registerObservers()
  {
    User::when('creating', 'updating', 'saving')
        ->register(MyObserver::observe('some', 'args'));
  }
}

Model::registerObservers would be called as part of Model::boot. Your model would override this function to register observers on your model.

when takes any number of arguments containing event strings

register should be able to be chained.

MyObserver::observe takes arguments related to the observer's actions for that particular model (eg. what column to alter), and would return a closure.

Finally, we would registerModelEvent with this closure for each event listed in when.

Problems!
Because the current model event system relies heavily upon closures and a particular event name format, there are some obstacles that we haven't devised a way to overcome.

Since events are registered as indexes of Dispatcher's $listeners array, (eg. 'eloquent.creating User'), it would seem that we either need to: Register these observer events separately from the current events, or hijack the closure... which I think would entail wrapping each of the closures registered to that event in another closure that triggers those closures... :scream:

Because of the need for closures, this syntax might have a big problem with being able to specify different actions for different methods. Not really sure what to make of that, perhaps there is an alteration we can make and perhaps use methods on the Observer class that match the event names (eg. Observer::creating) that can be derived from the when args?

...and probably lots of other stuff I could be forgetting!

Is this working? i cant seem to find the method in laravel src
static::observedBy(new ObserverInstance);

You're commenting on a issue that was posted roughly before Laravel 4.0 release.
http://laravel.com/docs/4.2/eloquent#model-observers


Speed, minimum-XP, books, and selection limit

First two commits: Some moderate speed improvements (~25% for God boots with both curses).
Third commit: The final output instructions are a bit different. It finds the lowest cost by levels or prior work (as before), but they now try to minimize XP cost afterward. It does find a lower XP cost (checked with God boots that have all 7 enchantments), but I'm not 100% sure (at least not yet!) that it's finding the minimum-possible XP cost, as there could be some weird edge cases that I'm missing.
Final two commits: Add ability to enchant book without tool, which I think addresses issue #16. 12 enchantments on a tool takes about 1min, so more than this is not recommended. By default, there is now a maximum selection limit (12 at the moment), where the user will be alerted, but there is an override to allow more than 12. This limit is adjustable.

Merged, with a fix to the filter labels not applying correctly.
For the book, do you think it would be better to remove it from each of the items array in data.js and just patch buildEnchantList() to always set allow_enchantment = true when item_namespace_chosen == "book"? That way, it will always show every enchant for books.

Also: Perhaps ENCHANTMENT_LIMIT_INCLUSIVE should be 10 - that's the most enchants you can put on an item ('god armor' boots, with no curses). That's a reasonable maximum that you would actually want to use.

I think manually setting allow_enchantment = true is a good idea. In the calculator, I have a check that makes sure you only put valid enchantments on an item (e.g. you can't put Depth Strider on a Bow, see InvalidEnchantmentError).  This is nice for debugging inputs into the calculator. It looks like it already allows all enchantments on a book, so this should be good.
I agree with ENCHANTMENT_LIMIT_INCLUSIVE = 10 as the default; this makes sense.

Allowing all enchants on books via code: 433c3f5c58f14460d8459c9bafde8971a1c514c5
Setting max default to 10: 831f3f80a4e8ea4005a64e3339f3a3f7b3bae07a


LEFT OUTER JOIN Problems!

I am trying to reproduce the following SQL query using EF RC1:
SELECT [t0].[Name], [t0].[Ranking], [t2].[Name] AS [AccountManager]
FROM [District] AS [t0]
LEFT OUTER JOIN [CommodityBalance] AS [t1] ON [t1].[DistrictId] = ([t0].[Id])
LEFT OUTER JOIN [AccountManager] AS [t2] ON [t2].[Id] = [t0].[AccountManagerId]
WHERE [t1].[DistrictId] IS NULL
ORDER BY [t0].[Ranking]

I have tried the following:
from d in _ctx.District
from c in _ctx.CommodityBalance.Where(c => c.DistrictId == d.Id).DefaultIfEmpty()
where c.DistrictId == null
orderby d.Ranking
select new {  d.Name, d.Ranking, AccountManager = d.AccountManager.Name }

It produces the following exception:
Exception thrown: 'System.NullReferenceException' in System.Core.dll
Microsoft.Data.Entity.Query.Internal.SqlServerQueryCompilationContextFactory: Error: An     exception occurred in the database while iterating the results of a query.
System.NullReferenceException: Object reference not set to an instance of an object.
   at lambda_method(Closure , TransparentIdentifier`2 )
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at Microsoft.Data.Entity.Query.Internal.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()

I have also tried:
District
   .SelectMany (
      d =>
         CommodityBalance
            .Where (c => (c.DistrictId == (Int32?)(d.Id)))
            .DefaultIfEmpty (),
       (d, c) =>
          new
          {
             d = d,
             c = c
          }
    )
    .Where (temp0 => (temp0.c.DistrictId == null))
    .OrderBy (temp0 => temp0.d.Ranking)
    .Select (
       temp0 =>
          new
          {
             Name = temp0.d.Name,
             Ranking = temp0.d.Ranking,
             AccountManager = temp0.d.AccountManager.Name
          }
    )

... and I get the same exception.  Both of these queries work as expected in LINQPad...

Possibly related to https://github.com/aspnet/EntityFramework/issues/3982 ?

covered by this one
https://github.com/aspnet/EntityFramework/issues/3263

The NullReferenceException is due to this part of the query where c.DistrictId == null. Since c is brought in as a left outer join (using DefaultIfEmpty()), c can be null. Therefore, you would need to add a null check before trying to access a property of c - where c == null || c.DistrictId == null.
This isn't specific to EF and would be true if you were using LINQ against in-memory objects too.
BTW when you add in the null check, you will then start getting an InvalidCastException due to #3982 - which has been fixed in our current code base.


neoscan-testnet.io block height is not increasing

neoscan-testnet.io block height is not increasing.
I am testing my application, I send some NEO from my wallet to application address.
Transaction is not getting confirmed as block height is not increasing.

Hello, currently the neo testnet is not working, you can check on the monitor page here: http://monitor.cityofzion.io/ (need to choose TestNet). So for the neoscan part it is working properly, blocks will be fetched as soon as testnet is working again. For more information about the testnet I invite you to contact the neo team (https://neo.org/).


Update to Bevy 0.10

TODO

[x] Change Bevy version in cargo.toml to 0.10 once its released and remove git links
[x] Add migration guide

Hey there! I'll get this reviewed/merged and do a crates release this today.


add R.nthChar and R.nthCharCode

We're making a family: R.nth, R.nthArg, R.nthChar, R.nthCharCode.

I think since changing from toUpperCase/toLowerCase to toUpper/toLower, we've slowly been moving away from an idea that I once had been contemplating, but had barely formulated, the idea of copying the entire native API into functional form.  There really was no good reason to do this, it did seem to be on of the things I was aiming for nonetheless; all the invoker-related code seemed to be headed that way.  The issues with doing splice should have demonstrated the futility once and for all, but I think it's still been in the back of my mind.
I think this puts the nail in that coffin.  And that's a good thing.  I can't stop feeling little pulls of regret that really make no sense at all, when we do something that's clearly an API improvement!
:+1:

:cow2: :moon:


Reverse router should take mode into consideration

When generating reverse routes the mode should be considered and prepend the proper prefix.

Fixed in https://github.com/Nijikokun/mithril-router/commit/539afafb57e7f9f986f0a48f4b0f6f3d430e5ecf


all terraform deployment contracts are without any meta data

every contract of the deployments made from terraform is without metadata data
steps made to verify this case

made multiple deployments from terraform
go to the same user on weblets
all the contracts are without meta data even solution name

steps made to verify this case

made multiple deployments from terraform
go to the same user on weblets
all the contracts are with meta data and solution name

not all the solutions provide metadata some of the solutions like multinode doesn't provide anything


revert the truthiness of the emailHash

the code started out as:
emailHash = !!action.emailHash ? action.emailHash : md5(action.email.trim().toLowerCase());

then it was changed to: if (action.email && !!emailHash) {
the intent is if the email hash does not exist in localStorage
generate a new one, if it exists in localStorage pull it out of
there and don't generate a new one.

Coverage decreased (-0.08%) to 93.873% when pulling e814e0b3e527f68eef738e479431bc36067c5aaa on abemassry:revert-truthiness-emailhash into 5366024bddd3dd8dc1e9882b1cedf067ddd6b0cc on linode:master.

My silly mistakes.


[Shift-on-Stack] Use the NVMe passed through for the master nodes

Although we are passing through NVMe devices for the OCP master nodes, it doesn't look like we are actually leveraging them.
https://github.com/openshift/installer/tree/master/docs/user/openstack#disk-requirements
Looks like we need to use controlPlane.platform.openstack.rootVolume.type and controlPlane.platform.openstack.rootVolume.size params in our install-config.yaml

@masco @venkataanil @akrzos FYI


Investigating d3-axis code to fix date format issue.

Story
Description

As a developer, I would like to extend my investigation on the date format issue to go through the d3-axis code.
Motivation

So that we can suggest changes to the d3 team to fix the date format issue in terra-graphs
Definition of Done

We'll know we're done when we come up with suggested changes to fix the date format issue.

Based on the investigation I have done, when null is passed as tickFormat, d3 determines the format based on tick values consumer provides using this code. Since [this logic] renders (https://github.com/d3/d3-scale/blob/main/src/time.js#L20-L37) irrespective of locale, we are seeing the same format in Carbon for every locale we use, which leads to date format internationalization issue.
To fix this issue, d3 format selection needs to be locale-specific, but the d3 team is not ready to do these changes(which you can see in this comment). So this will leave us with building our own logic based on axis limits provided by consumers to fix the date format issue.


Sending init data for protected content

The readme states:
For most protection schemes, the license server information (URL & init data) is included inside the manifest. The notable exception to this is Widevine-Modular (WV). To playback WV content, you must provide the URL to a Widevine license server proxy.
For this purpose, videojs-contrib-dash adds support for a "keySystemOptions" array to the object when using the player.src() function

So, we can set the URL via "serverURL" like so:
player.src({
  src: 'http://example.com/my/manifest.mpd',
  type: 'application/dash+xml',
  keySystemOptions: [
    {
      name: 'com.widevine.alpha',
      options: {
        serverURL: <URL>
      }
    }
  ]
});

Is there a way to set a JSON object to be sent along as the payload to the URL?

The payload will be the initData of the video, as it should be. Could you elaborate on what you're trying to do?

@squarebracket thanks for the reply.
I'm working with a system designed by someone else and I'm not sure if it's standards compliant, so it's entirely possible, even likely that my assumptions are correct.
In my test working code, which does not use videojs-contrib-dash, we have a server  to which we send a JSON payload via POST to retrieve a license.
In my test code that uses video-contrib-dash, with the code mentioned in my previous comment:
player.src({
  src: 'http://example.com/my/manifest.mpd',
  type: 'application/dash+xml',
  keySystemOptions: [
    {
      name: 'com.widevine.alpha',
      options: {
        serverURL: <URL>
      }
    }
  ]
});

i've noticed that the application sends an empty POST request to  . I'm hoping that everything will "just work" if I can get the application to instead send the aforementioned JSON payload, causing it to return the proper license information. But again, my assumptions may be incorrect. Am I barking up the wrong tree?
Again Thanks! Any information that you can provide is helpful.

That does indeed sound non-standard; the POST data should never be empty. Are you sure your video is encrypted? Any chance you could share the MPD?

@squarebracket, I'm sure the video is encrypted, but unfortunately, I can't share the MPD. Looks like I'll have to dig deeper myself or find another method... thanks for your help!

Do you know the kind of encryption being used?

Not entirely sure about the kind, sorry.

I'd suggest talking to your DRM provider, then.

@squarebracket I am facing the same issue, the post request to serverURL has to take some data. Please help to let us know how to send the payload data (init data)


Don't block on cleanup tasks by default

This PR sets "spark.cleaner.referenceTracking.blocking" to false by
default. It had originally been set to true as a workaround for
SPARK-3015.
However, that issue has been resolved since 16/Aug/2014 already.
I would therefore think that it's safe to make this non-blocking by
default, which should help with cases where the cleanup thread can not
keep up any more.
If there are other reasons why this should stay blocking by default, I'd
be interested to learn about them. In that case the comment should
probably be updated.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

SPARK-3015 was fixed by setting the config to true. So by setting it to false you'd be unfixing it, no?

SPARK-3015 was fixed by setting the config to true. So by setting it to false you'd be unfixing it, no?

Oh, my bad. You're right. I had only seen that it had been resolved, but not that this was the actual fix.
The original issue states that "This is intended to be only a temporary workaround for the issue". This was 3,5 years ago, so I wonder if the underlying issue has perhaps changed in the meantime?

Most probably nobody bothered to check.

@rkrzr please close the PR, unless you plan to actually test that this is not an issue anymore.

I'll close this for now. (I am running into a problem related to this, but I'll better open a new issue about that when I know more)


fix logging for pre update routing

Summary

fix logging for pre update in BaseLocalDao
explicitly initialize _restliPreUpdateAspectRegistry as null in start time

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.54%. Comparing base (af454f2) to head (19be6e6).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage     67.53%   67.54%
  Complexity     1519     1519
=========================================
  Files           137      137
  Lines          5958     5959    +1
  Branches        644      644
=========================================
+ Hits           4024     4025    +1
  Misses         1662     1662
  Partials        272      272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Machine-overridable setting values not read on non-default profiles

On a non-default profile, settings like emmet.extensionsPath, which are machine-overridable, do not have their value read properly by the configurationService even when the user specifies the value in the current profile setting.json.

It seems to work now. I see the profile specific value being shown in the UI.

It still doesn't seem to work. I have a small extension that inspects the setting.
When I run the command, it inspects the emmet.extensionsPath setting, and it doesn't pick up the profile setting there. I'll see if I can upload the test extension soon.

I tried this with my sample extension (following) and it works as expected for me
export async function activate(context: vscode.ExtensionContext) {
    vscode.commands.registerCommand('test.helloWorld', () => {
        console.log(`${vscode.workspace.getConfiguration().inspect('emmet.extensionsPath')?.globalValue}`);
    })
}

Hence closing this. Please reopen it with the reproducible steps. Thanks


fix: uppercase method verbs

Status
READY
Description
Fix #888
At the last possible second uppercase the verb so method: 'PATCH'

For more details on this, see https://blog.k-nut.eu/patch-capitalization and the HTTP standard normalization section


Different versions of sub-dependencies

I want to make adapters for multiple versions of the same package in a monorepo. I'm working on a library which needs to support different versions of guzzlehttp (and maybe even other request libraries). Other packages I might add to this monorepo will have nothing to do with guzzlehttp, it's not meant as a shared dependency.
My package structure:
packages/
├── pdk-client-adapter-guzzle5
│   └── composer.json (requires guzzlehttp/guzzle~5)
└── pdk-client-adapter-guzzle7
    └── composer.json (requires guzzlehttp/guzzle~7)

However, I get the following error:
vendor/bin/monorepo-builder merge

Package "guzzlehttp/guzzle" has incompatible version
====================================================

 --------------------------------------------------- ---------
  File                                                Version
 --------------------------------------------------- ---------
  packages/pdk-client-adapter-guzzle5/composer.json   ~5
  packages/pdk-client-adapter-guzzle7/composer.json   ~7
 --------------------------------------------------- ---------

 [ERROR] Found conflicting package versions, fix them first.

In ConflictingVersionsGuard.php line 37:

  Fix conflicting package version first

I tried adding this to monorepo-builder.php, with no effect:
$parameters->set(Option::DATA_TO_REMOVE, [
    ComposerJsonSection::REQUIRE => [
        'guzzlehttp/guzzle' => '*',
    ],
]);

Is there any way to achieve this? I found #2787, but it does not offer a solution to my problem.

Hi, I'd only quote the reply from https://github.com/symplify/symplify/issues/2787
This monorepo package is not designed for separate development of various packages. The shared dependencies is one of condition for monorepo to exist.
In your case, I'd go with latest Guzzle, then use Rector downgrade rules for lower versions. Otherwise, you'll maintain x various version and risk forgetting fix or change here and there.

@TomasVotruba thanks for the super fast reply. I'll look into it!


fix(addtospace): adds add to space from space page

launch forge wizard and set to correct page

[test]

@dgutride snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-817-fabric8-ui.int.rdu2c.fabric8.io

I have tested the staging url and the recent changes are present 👍


[2.8 Manual Sync] Reduce memory utilization of caching events

Addresses https://issues.redhat.com/browse/ACM-6783
This removes all unnecessary fields in an Event object before it is cached. Additionally, a field selector is added to avoid caching events unrelated to policy compliance.
Relates:
https://issues.redhat.com/browse/ACM-6063
Signed-off-by: mprahl<EMAIL_ADDRESS>(cherry picked from commit c59e473d3473baa558ee0d3774e271a1bdd369d6)

/override "KinD / Tests (latest, false, hosted)"

@JustinKuli I just rebased the PR hoping that the hosted mode CI would pass.

/override "KinD / Tests (latest, false, hosted)"

/unhold

@JustinKuli and @dhaiducek could you please review?


Remove "Integration Project" in WSO2 EI Tooling

Remove the "Integration Project" option for project types in the UI of WSO2 EI Tooling.
It is already finalized as per [1].
[1] #539

Removed "Integration Project" and "Integration Template" in https://github.com/wso2/devstudio-tooling-esb/pull/247


Add the ability to pass/change environment variable

Overall Review of Changes:
update to the way remediate can run the audit
in-conjunction with audit script change this will allow options to be pushed over from the remediate when the audit is run
Enhancements:
As above

pipeline expected to fail as no rhel9 image as yet.


Error message with SWSC-EN

Hi,
I am trying to run SWSC-EN with .nexus output from phyluce. I keep getting this same error message:
analysing %s /Users/admin/Documents/Phyluce/mafft-nexus-edge-trimmed-clean-75p-nex-new.nexus
Wed Feb 23 09:13:25 2022
Sitewise metrics analysis
Traceback (most recent call last):
File "/Users/admin/Downloads/PFinderUCE-SWSC-EN-master/py_script/SWSCEN.py", line 25, in
process_dataset_metrics(dataset_path, ['entropy'], minimum_window_size = 50, outfilename = '%s.csv' % (name))
File "/Users/admin/Downloads/PFinderUCE-SWSC-EN-master/py_script/functions_metrics.py", line 37, in process_dataset_metrics
dat.read(dataset_path)
File "/Users/admin/miniconda3/lib/python3.9/site-packages/Bio/Nexus/Nexus.py", line 718, in read
self._parse_nexus_block(title, contents)
File "/Users/admin/miniconda3/lib/python3.9/site-packages/Bio/Nexus/Nexus.py", line 759, in parse_nexus_block
getattr(self, "" + line.command)(line.options)
File "/Users/admin/miniconda3/lib/python3.9/site-packages/Bio/Nexus/Nexus.py", line 1275, in _charpartition
subname, subindices = self._get_indices(
File "/Users/admin/miniconda3/lib/python3.9/site-packages/Bio/Nexus/Nexus.py", line 1295, in _get_indices
name = self._name_n_vector(opts, separator=separator)
File "/Users/admin/miniconda3/lib/python3.9/site-packages/Bio/Nexus/Nexus.py", line 1320, in _name_n_vector
raise NexusError("Formatting error in line: %s " % rest)
Bio.Nexus.Nexus.NexusError: Formatting error in line:  uce-10.nexus: 1-1236
Do you have any idea what might be going wrong? I can send my alignment file but it is very large (559 MB).
Thank you!
Leland

Hi Leland,
It looks like BioPython can't read your Nexus file. This could be for a few different reasons. Can you post the first and last few lines here?
Otherwise, if you compress it with xz -e you can probably get pretty good compression and then send it through. Either @Tagliacollo or I can take a look.
Rob

Dear @lcgraber,
Please let me know if you could fix the issue.
Victor

Hi! I apologize for not replying sooner--my .nexus output from phyluce lacked the "[loci]" specified right before the charsets, and my uce loci had hyphens in their names, which I replaced with underscores like in the sample input. One or both of those changes made my alignment run correctly!
So, my file before:
begin sets;
CHARSET uce-10 = 1-689;
CHARSET uce-100 = 690-1255;
CHARSET uce-10001 = 1256-1557;
begin sets;
[loci]
CHARSET uce_10 = 1-689;
CHARSET uce_100 = 690-1255;
CHARSET uce_10001 = 1256-1557;
The output looks great! Thanks for making such a helpful program.
All the best,
Leland

@lcgraber, thanks so much for working this out. Hopefully this record of the issue will help others avoid this problem too.
Rob


Reviewing GitHub for Windows | Add Content

Overview
Review the content of the GitHub for Windows course and potentially add content based on #493.
@hollenberry since reviewing / adding content can potentially be duplicative, I'm going to open this issue and identify some of the things I find and I will open the pull request to implement both the edits and new content.

[x] Fix this: the links to other courses on the first page don't work.
[x] Fix this: want to attributed to the commits you make. (Configure Git)
[x] Fix this: define your Carriage Return Line Feed (crlf) add "settings" at the end (Configure Git)
[x] Fix this: Thankfully, Git is comes to the party equipped (Configure Line Endings)
[x] Discussion: This is a Windows based course, should we even include this: These instructions assume you are using Windows, if you are using macOS or a flavor of Linux, use the following: git config --global core.autocrlf input. (Configure Line Endings)
[x] Fix this: a change in OS X change to macOS (Configure Line Endings: TMW)
[x] Fix this:  enter it agin (Store Your Password)
[x] Fix this: If you haven’t defined a core.editor for git to use, capitalize Git (vi Basics)
[x] Remove this: , or :q to quit without saving your commit message. Step 2 on Saving Commit (vi Basics)

[x] Add it as a note under Saving the Commit

[x] Fix this:  VI to craft yo (Configure Other Editors)
[x] Fix this: In some instances, you will need to use the installation path of Atom when setting the config settings. Make this a note (Configure Other Editors)
[x] Fix this: Tools > Extensions and Updates turn into Select Tools > Extensions and Updates from the main menu. (Install the GitHub Extension)
[x] Fix this: CLICK Initialize this repository with a README checkbox. aka not all caps CLICK (Start a Project)
[x] Fix this: it is push your changes t "it is time to push your changes" (Make a Commit)
[x] Fix this:  using git, y capitalize Git, happens twice (What is Sync?)

Based on the initial issue that looked to enhance the Windows content, I think my addition of how to push your changes to your repository on GitHub, as well as reviewing the content for inconsistent style usage and spelling errors makes this PR ready to be reviewed!
Looking for 👀 from @github/services-training
Original enhancement requests

Example of branching, show on whiteboard, GH desktop, then within VS
Why git

This course was never designed to be a introduction to Git course, it was identified as a way for Windows users to get their system up and running with Git and GitHub. Adding this type of content just doesn't seem pertinent to the course content but willing to hear other 💭 s.

Setup walkthrough

This exists in the course.

Git shell demos (show that it exists, and you don't have to login)

I guess we could add content about Git from the CLI in the Windows course, but we already have that content in the CLI course.

Merge conflicts
Demo beyondcompare / merge conflict resolution tools

Merge conflicts and examples of different tools are going to be shown in a different course #576


Add filter to search page

From https://g0v.hackmd.io/VVIOZobARkegK3vxYdG52Q#網站許願 :

Add the following new filters to article search page:

No useful reply yet
No any replies

Want to filter "has valid reply" in replies list -- So that users can see good example.
Has useful reply = has article reply with positive > negative


Allow user to create properties of arity 1 and >2.

Currently, all data needs to be specified in attributes, which are a predicate with an object and a value.
It would be worthwhile looking at whether there ought to be a way to specify boolean methods, which take only a name, and always have exactly one value, and create corresponding property blocks that merely state the property name. That would increase the need for negation, which is a potential downside, because it breaks the "have only one way of doing things" rule for simplifying the interface.
There may also be a reason to allow users to specify things in arities > 2. They can usually be usefully broken into parts, and not having arity > 2 simplifies the interface, so it is by no means certain that giving user the option would make things better.

The new_booleans branch deals with arity 1. Renaming to deal with only >2.

I have run into use cases for which arity 3+ is the best route forward.
Here's the plan:

[ ] Create a relationship declaration block
[ ] Create a relationship selector block
[ ] Create documentation for relationship selector block
[ ] Create documentation for relationship declaration block
[ ] Update other documentation
[ ] Add relationship declaration to Categories Drawer
[ ] Create new known relationships drawer
[ ] make the new relationship declaration block mutate itself on the basis of the provided number
[ ] make the known relationships drawer auto-generate based on new relationship declarations
[ ] Write code generation for the relationship declaration block
[ ] Write code generation for the relationship selector block
[ ] Check that relationships work everywhere attributes work, like events, exceptions, etc.
[ ] Change the ontology endpoint so it returns relationships and relationship NLG
[ ] Change the scenario editor fact screen so it can collect relationships
[ ] Change the scenario editor explanation screen so it can explain relationships

It is not clear that having "relationships" and "attributes" be different things is ultimately the right way to go. We might want to make relationships deal with 1+ objects and values and replace attributes that way. Or we may want to let them overlap one another.


[ENH] Add proto conversions for RequestMetadta

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2831  👈
#2828
#2827
#2826
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on  Graphite

Merge activity

Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.


Running unit tests gives ERROR in react-test-renderer

Hi Guys, I am getting the following error when I run npm test
ERROR in ./~/react-test-renderer/package.json
Module parse failed: /Users/user/React/LearningReact/react-datepicker/node_modules/react-test-renderer/package.json Unexpected token (2:9)
You may need an appropriate loader to handle this file type.

any help please.
Thanks

this is now resolved

How is this resolved? Do we need to upgrade anything?


order or non printing characters with f-string.

Issue Type: Feature Request
Minor issue, but VS Intellicode doesn't flag the following as an error:
print("\t\nWe're glad you could join us!")
The correct syntax is of course print("\n\tWe're glad you could join us!") with the newline character preceding the tab character. This is no way highlighted as error and the Python interperter does print it to the stdio with the new line character.
Extension version: 1.1.7
VS Code version: Code 1.36.0 (0f3794b38477eea13fb47fbe15a42798e6129338, 2019-07-03T13:25:46.372Z)
OS version: Windows_NT x64 10.0.18362

hI @jazzphreak , and thanks for taking the time to raise this.
It looks like this is a problem with the Python Language Server rather than with IntellICode's starred recommendations - please could you raise the issue in their issues repo at https://github.com/Microsoft/python-language-server/issues ?
Thanks
Mark

Gladly I'll post it there and that makes sense since I tried the same
operation in the sublime text 3 editor and it had the exact same problem.
On Fri, Jul 5, 2019, 10:24 AM Mark Wilson-Thomas<EMAIL_ADDRESS>wrote:

hI @jazzphreak https://github.com/jazzphreak , and thanks for taking
the time to raise this.
It looks like this is a problem with the Python Language Server rather
than with IntellICode's starred recommendations - please could you raise
the issue in their issues repo at
https://github.com/Microsoft/python-language-server/issues ?
Thanks
Mark
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/intellicode/issues/109?email_source=notifications&email_token=AEV3SQIY4VW2SAMGGQWODOTP557TLA5CNFSM4H6KI232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJ74PY#issuecomment-508821055,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEV3SQJBFN26PDCNJSPIHILP557TLANCNFSM4H6KI23Q
.

Thanks @jazzphreak !

For traceability, noted original issues (feature request) entered here as issue #109 and logged as #1283 in their docsite.


Allow customization of metrics-text endpoint response

Prometheus for example supports pulling metrics over http where metrics are either protobuf serialized or plain text, there have also been requests to allow customization of the format reported by the console reporter.
I would be useful to provide customization of the metrics-text endpoint allowing the response to be formatted using each reporters syntax Prometheus, Influxdb's line protocol etc.
Having a formatting abstraction would also allow customization of the format reported by the console and text file reporters.

docs: http://app-metrics.io/web-application-monitoring/formatters/overview.html


This week in Fluvio 30

@tjtelan nice work. A possible description for "Export Profile":
Export cluster profile to a file that can be used to initialize the connection to a Fluvio cluster via client APIs.

@tjtelan do we want to add links to:

https://reneeshah.medium.com/how-webassembly-gets-used-the-18-most-exciting-startups-building-with-wasm-939474e951db
https://www.infinyon.com/blog/2022/02/real-time-gaining-momentum/


Passing fixed data to ODEs

Summary:
In Pred1_general_solver.hpp, pred1 calls pmetrics_solver as:
pred_V = pmetrics_solver(f, init_vector, InitTime_d, EventTime_d, theta, rate_d, idummy);

Right now, all the parameters are expected to be stored in theta (which is fine), but there is no mechanism for passing dat or dat_int.
Current Version:
Stan v2.14.0
Torsten v0.82

I was almost going to raise a new issue, and then I found this. So here's more on why the above is important:
Summary:
Sometimes we want to fit a PK/PD model with fixed PK parameters. Currently however, users must pass both PK and PD parameters in the array theta. We should relax this, and allow users to pass variables in the ODE system using x_r and x_i (i.e. real and integer data). This should lead to an appreciable speed-up.
Even more so, in fact, with the mixed solver (for the Friberg-Karlsson model, the theoretical speed-up would be around 70 - 80 %). The coding shouldn't be too bad; we need to make sure we promote variables only when necessary.
The only major drawback I see (other than development effort) is that this would make the function signature heavier. It might be worth thinking about ways around it.
Current Version:
Stan v2.17.1
Torsten v0.84

This is implemented at math lib. I'll link it to stan lang asap.


Mod crashes when loading preset to chest where an item has maximum set to 0

The game crashes when I try to copy any preset to a requester chest where one of the requested items has a max item count/limit is set to 0, i.e. autotrash.
The mod Logistic Request Manager (continued) (1.1.28) caused a non-recoverable error.
Error while running event LogisticRequestManager::on_gui_click (ID 1) count must be positive)
stack traceback:
[C]: In function 'set_slot'
LogisticRequestManager/scripts/request-manager.lua:382: in function 'push_request_to_requester'
LogisticRequestManager/scripts/request-namager.lua:281: in function 'apply_preset'
LogisticRequestManager/scripts/request-manager.lua:604: in function 'load_preset'
LogisticRequestManager/control.lua:118 in function <LogisticRequestManager/control.lua:48>
Repro:

Create a request preset with one or more items requested where at least one of them has a limit set to 0.
Open a requester chest
Open Logistic Request Manager menu and navigate to the preset as defined in step 1.
Click on the "Load preset" button

Screenshot:

Thanks for the report.
I'll fix this asap, but it may take a few days.


Adding vector search example into QuickStart

Adding a new vector search related data set: fine food reviews with 1000 rows, the embeddings are generated using OpenAI APIs, following this doc:  (https://github.com/openai/openai-cookbook/blob/main/examples/Obtain_dataset.ipynb)
The embedding has 1536 floats.
The test query is directly using a vector with summary of tomato soup.
Below is a sample query and response.

Codecov Report

Merging #11351 (d685190) into master (f25f3ed) will decrease coverage by 53.82%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11351       +/-   ##
=============================================
- Coverage     68.46%   14.65%   -53.82%
+ Complexity     6535      494     -6041
=============================================
  Files          2233     2159       -74
  Lines        119952   116826     -3126
  Branches      18191    17747      -444
=============================================
- Hits          82128    17116    -65012
- Misses        31984    98296    +66312
+ Partials       5840     1414     -4426

Flag
Coverage Δ

integration1
?

integration2
?

java-11
14.65% <ø> (-53.77%)
:arrow_down:

java-17
?

java-20
?

temurin
14.65% <ø> (-53.82%)
:arrow_down:

unittests1
?

unittests2
14.65% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1710 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


KAFKA-5888: System test to check ordering of messages with transactions and max.in.flight > 1

To check ordering, we augment the existing transactions test to read and write from topics with one partition. Since we are writing monotonically increasing numbers, the topics should always be sorted, making it very easy to check for out of order messages.

Started a run of 40 transactions tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1085/

cc @hachikuji

All the test runs passed, except one. The one that failed is due to an unrelated issue with multiple inflights: when there is cluster instability, it can take a while for produce requests to succeed. Further, when there are retries, we reduce to one inflight batch at a time. This means that there are previously sent batches sitting in the accumulator for quite a long time. When these batches expire, it is a FATAL error for the transactional use case. This FATAL error causes the copier to exit, and hence the test to fail.
The fix is to wait for KIP-91 to land, or to bump the request timeout for the transactional message copier to 60 seconds. As mentioned elsewhere, let's wait to see the ETA on KIP-91 before bumping the request timeout.

Since the test run was so successful, I introduced a few bugs to make sure they are caught:

For the test which checks ordering, I created an output topic with 2 partitions. The verifying consumer reading from this topic would thus not read messages in numerical order. The ordering checks failed with this modification.
I deleted the line which verifies the requeued batches are in sequence order in the RecordAccumulator. This also caused the tests to fail because the accumulator would not drain the head of the queue when there were retries since the head of the queue would not be the next eligible sequence.


Don't add bblayers if they were already added.

This was introduced by b48fe3ed766250dac8564a0f6bd0b05988e35f5c (back in
August) but we just never noticed or cared enough to look into it until
now.

Great that you've found it, it produces annoying errors with bbappends. I have an impression that it's config templates that need to be modified/deleted though. Looks like we have two conflicting ways to add specify layers and it's not really maintainable.

Great that you've found it, it produces annoying errors with bbappends. I have an impression that it's config templates that need to be modified/deleted though. Looks like we have two conflicting ways to specify layers and it's not really maintainable.

I think the TEMPLATECONF mechanism that Leon used is good, and I think that's a bit more maintainable. The other mechanism is just a fallback solution that I left in case we have anything that uses it. I'm fine going other way, but it probably makes sense to go with whatever the "standard" is. My guess is that the TEMPLATECONF method is preferred, but I don't actually know.

The original idea was to separate layers common to all platforms from platform-specific ones and keep them all in a single place. The config templates were not deleted though. Later @leon-anavi added code to use them again.
I like separated snippets more, but if there are reasons in favor of TEMPLATECONF am also OK with them. It's also interesting to know Leon's reasons.

Maybe the primary reason for intoducing '*.inc's was that local.conf is constructed much easier that way and bblayers.conf generation was changed for the sake of consistency.

Yes, and then we've rewritten local.conf includes to bbclasses, so only ones for bblayers.conf are left.

Alternative solution: https://github.com/advancedtelematic/meta-updater/pull/181

Closing since Anton's solution seems better.


Fix generateDocumentation implicit dependencies

The :detekt-rules-libraries:processResources and :detekt-rules-authors:processResources tasks have an implicit dependency on :detekt-generator:generateDocumentation task, the files detekt-rules-libraries/src/main/resources/config/config.yml and detekt-rules-ruleauthors/src/main/resources/config/config.yml being outputs of :detekt-generator:generateDocumentation.
This has a small impact on performances (see here an example on detekt-rules-authors:processResources)
This PR fixes this by sharing the artifacts through a Gradle configuration.
Please note that I had to cut some task dependencies in detekt-generator build script to avoid a cycle in the task graph (assemble => build => shadowJar => generateDocumentation => assemble). Please review those carefully as I am not familiar enough with the codebase to measure the impacts.

Thanks! This should fix https://github.com/detekt/detekt/issues/5768. I (or someone) will review when I get some time.

Note: there might've been some hidden conversations:

Nice work! Thanks for taking the time to do this, and thanks to TWiStErRob and big-guy for reviewing.

Unfortunately there's an error that only came up after merging, as none of the PR CI jobs just run a plain ./gradlew build.
But that's run before deploying a snapshot and it failed with:
Circular dependency between the following tasks:
:detekt-formatting:build
\--- :detekt-formatting:check
     \--- :detekt-formatting:detekt
          +--- :detekt-rules-libraries:jar
          |    \--- :detekt-rules-libraries:classes
          |         \--- :detekt-rules-libraries:processResources
          |              \--- :detekt-generator:generateDocumentation
          |                   +--- :detekt-formatting:build (*)
          |                   \--- :detekt-rules:build
          |                        \--- :detekt-rules:check
          |                             \--- :detekt-rules:detekt
          |                                  +--- :detekt-rules-libraries:jar (*)
          |                                  \--- :detekt-rules-ruleauthors:jar
          |                                       \--- :detekt-rules-ruleauthors:classes
          |                                            \--- :detekt-rules-ruleauthors:processResources
          |                                                 \--- :detekt-generator:generateDocumentation (*)
          \--- :detekt-rules-ruleauthors:jar (*)

(*) - details omitted (listed previously)

https://ge.detekt.dev/s/2xn35555wzg4q/failure#1
https://github.com/detekt/detekt/actions/runs/4183501703/jobs/7247933889

Commenting those 2 finalizedBy instructions helps to get rid of the circular dependency
https://github.com/detekt/detekt/blob/a6d81feef18c4719e810b63e2acbd2810870bf62/detekt-rules/build.gradle.kts#L31
https://github.com/detekt/detekt/blob/a6d81feef18c4719e810b63e2acbd2810870bf62/detekt-formatting/build.gradle.kts#L26

Unfortunately there's an error that only came up after merging, as none of the PR CI jobs just run a plain ./gradlew build.

See https://github.com/detekt/detekt/pull/5792 for resolution


ytdlp2strm is downloading streams from crunchyroll instead of streaming

Hello,
When I try to stream a Crunchyroll Video using this tool, it downloads the episode requested instead of streaming it.
Is there a setting to completely disable downloading for crunchyroll?
I've already set it to direct.

Hello, it's a shame but since the last update of the Crunchyroll endpoints, it only shows Dash routes for the separate audio and video, there is no longer an endpoint with the direct content. Work started at https://github.com/fe80Grau/ytdlp2STRM/issues/36#issuecomment-2045858376
I've also not been able to remux in RAM and transmit in real time as the final flow is built, therefore the only option is to download as a temporary file. In ./config/config.json there is a new parameter called ytdlp2strm_temp_file_duration, this has the duration of a temporary file in seconds, by default 86400s / 24h. This means that a temporary file (located in ./temp) that is older than 86400 seconds will be automatically deleted.


Starcraft Remastered | Can't enable real time lighting

I have been playing Starcraft Remastered, the game is running perfectly but I can't enable the real time lighting option, which requires a minimum of 2gb of vram, even though my GPU is supported.
Software information
Lutris, playing Starcraft remastered through the battle.net in lutris.
System information

GPU: RTX 3070 Ti
Driver: 560.35.03
Wine version: ProtonGE9-16
DXVK version: v2.4.1-194-g763b82b1e482e3b

Screenshots
The conditions are having hardware with more than 2gbs of VRAM, and not having the cartooned skin set enabled (Which I haven't enabled)

dxvk hud shows the gpu correctly

I may be fixed in the next release of dxvk-nvapi if the game uses that. They recently added some functionality that games can use to get VRAM amount.
Will try to test here later.

IIRC we had a report about this game before. I don't remember what the issue was, but it's probably not using DXGI to query the available amount of VRAM because (some) game developers really hate writing simple and reliable code for some reason.
Game might also just not support ≥4GB of VRAM, in which case DXVK_CONFIG="dxgi.maxDeviceMemory=4095" might help.

Just so it is noted in the issue.
I have only been able to reproduce this issue myself when using older Wine builds like Proton 8 or Wine-GE. When using Proton 9, Experimental, Proton-GE 9-16 etc it works fine. The game doesn't use nvapi and i haven't found that the issue is something to do with dxvk as using a newer dxvk version in Proton doesn't prevent the issue from showing.
Tested with a RTX 4080 (system also have a AMD iGPU)

https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

Ah nice :+1:

Seems to be a wayland issue. On wayland the real-time lighting setting is disabled, but I tried in X11 and the setting works correctly. (I am using KDE Plasma, version 6.2.2)

I guess you are running this under Xwayland and not the experimental native Wayland driver? Then open a bug report for Wine, Component "winex11.drv":
https://bugs.winehq.org/buglist.cgi?component=winex11.drv&product=Wine&resolution=---

I guess you are running this under Xwayland and not the experimental native Wayland driver?

Yes, I am running the game using ProtonGE9-16 under Xwayland

Then open a bug report for Wine, component "winex11.drv":
https://bugs.winehq.org/buglist.cgi?component=winex11.drv&product=Wine&resolution=---

Okay, I will later create a bug report on the component you gave, saying that in Starcraft Remastered VRAM is not reported correctly under Xwayland

Linking the new Wine issue: https://bugs.winehq.org/show_bug.cgi?id=57351

Can confirm:
Using Bottles with its Caffe runner the setting works.


Initial implement

Changes Unknown when pulling cd605130c2accd1dee497f44bb5121e6d97e93db on initial into ** on master**.

Changes Unknown when pulling cd605130c2accd1dee497f44bb5121e6d97e93db on initial into ** on master**.


Matrix dimensions in Eq 2.5 and Alg. 2

I was re-reading your paper recently a bit more carefully, and I have a question about the dimension of some matrices.
Specifically, in Eq 2.5, it's not really clear what the dimension of the jacobian matrix d(delta(x, y)) / dx is expected to be. Below, I've depicted the dimensions of all the matrices involved in the computation per the paper's notations. The right side of the equation yields p x n (same shape as X). But I don't understand how the dimensions are working out for the left side of the equation (the green doodles).

Another question: my understanding is that in Alg. 2, the dimensionality of E is n x m, and per the above, the output of Alg. 2 should be p x n (same as X). Am I correct?
Thanks in advance!

It's a bit tricky because we're dealing with matrix outputs. Δ maps x to a distance matrix so it is a function from p x n to n x m. Therefore, its Jacobian is a linear map from p x n to  n x m and its transpose is a linear map from n x m top x n. Therefore, the Jacobian transpose of Δ maps B, a matrix of size n x m, to a gradient of size p x n as expected. Appendix B.2 of our new paper explains that in some more details (in that paper, notation is different : time series are of shape n x d).
By the way, I just found your package pytorch-softdtw-cuda, it's great! Could you add the soft-dtw tag to your repo? Thanks!

It's a bit tricky because we're dealing with matrix outputs. Δ maps x to a distance matrix so it is a function from p x n to n x m. Therefore, its Jacobian is a linear map from p x n to  n x m and its transpose is a linear map from n x m top x n. Therefore, the Jacobian transpose of Δ maps B, a matrix of size n x m, to a gradient of size p x n as expected. Appendix B.2 of our new paper explains that in some more details (in that paper, notation is different : time series are of shape n x d).
By the way, I just found your package pytorch-softdtw-cuda, it's great! Could you add the soft-dtw tag to your repo? Thanks!

Thanks for your elaboration. This makes much more sense now.
Added soft-dtw tag to my repo, per your request. Also, if you haven't already, check out DeepNAG which motivated my CUDA implementation.
Closing this issue.

Thanks for your elaboration. This makes much more sense now.
Added soft-dtw tag to my repo, per your request. Also, if you haven't already, check out DeepNAG which motivated my CUDA implementation.
Closing this issue.


Project Feedback!

👍 Congrats on completing the third project!
I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.

The following features are checked in the readme but not shown in the GIF. These user stories are not given points. Please record a new GIF and resubmit your assignment using the submit button in the course portal in order to get full points for the user story.

User is displayed the relative timestamp for each tweet ""8m"", ""7h""

Since the extension period is over, we will no longer regrade any resubmissions made after this date. We just want to let you know so that you make sure to reflect the features on your GIF for future submissions
/cc @codepathreview


Copy/paste support

also considering paste with no formating

re-implementation from https://github.com/fespinoza/linked-ideas-osx/pull/24


dracut, initcpio: make libgcc_s search universal

I'm still working on this and haven't tested anything, but this should close #427.

Initial tests show that libgcc_s.so and libgcc_s.so.1 make it into a dracut testbed image generated on a Void host, although I make no provision for libgcc_s.so so I don't know where it's coming from. In a Void-created mkinitcpio image, libgcc_s.so.1 appears in the image and mbuffer runs without complaint (although I didn't actually pipe data through it).


Adding indexing support (updated)

Please review this PR to add support for managing indexes. I have figured out how to add indexing options. This change will allow adding, removing and searching  for indexes in a collection. Let me know if I can help with anything or if I need to change something. Thanks,
Yaroslav.

Awesome, thanks for this. I'll be able to take a look within the week. I'd be happy to work with you on this if it needs improvements.

There are also some style tips we can go over after we get functionality down.
You should always have spaces before and after the equal sign, indenting should always be consistent, and some other things. Don't worry, I do it as well. We'll pretty it up in no time at all.

Thank you very much for your response. I appreciate your feedback and agree with you that we should make this as good as we can before merging this into the master. I do continue to learn C and am very thankful for your willingness to explain the reason why we do things a certain way.
Please have another look at my suggested changes. Thanks to you I had to catch up on my knowledge of Lua C API and it is totally my oversight that I did not think of reading lua table directly. In the new version I am using lua_getfield() function to push the specific key value onto the stack. The alternative is to create a loop over the keys of the lua options table, but that might be an overkill since we are dealing with a discrete list of options that are passed. Please let me know if I should attempt to re-write this as a loop?
I also think that following PyMongo example is a great idea because it is the most official reference implementation. Before continuing making changes or trying to implement new functionality (Geoindexing, etc..) I would like to get your feedback and see if there is anything I can help with.

Cool. I'm going to open up a new branch in this mongo-labs repo and we can work on it.
I'm going to start adding an IndexModel implementation, and add test cases. Your work so far looks pretty good. I'll make some small changes to what you've done, since it's not worth going back and forth for those.

@yzubkov let's continue this conversation in #65.

@yzubkov I apologize, let's actually continue this conversation in #66.


Add/update several repos in dashboards-plugins/.meta

The following repos were missed by the release ticketing automation for the 2.6 OpenSearch release, because they were either missing from the .meta files (dashboards-search-relevance and opensearch-dashboards-functional-test) or they had out-of-date repo URIs (dashboards-notifications, dashboards-query-workbench, and dashboards-observability).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like I duplicated the effort https://github.com/opensearch-project/opensearch-plugins/pull/210 my bad!

Discarding this PR, since the changes were made in https://github.com/opensearch-project/opensearch-plugins/pull/210


OAuth2 client credentials are sent with wrong Content-Type

Description
When an OAuth2 access token is requested from an OAuth2 Authorization server's token endpoint, the credentials are sent using the application/json Content-Type, but client credentials should be sent using the application/x-www-form-urlencoded according to the OAuth 2.0 RFC
Version of SDK
v0.3.1
Reproduction

Configure the openfga client using the OAuth2 Credentials example in the README
Observe that the content-type is set to application/json

Expected behavior
When an OAuth2 token is requested from an OAuth2 Authorization server, the credentials are sent using the application/x-www-form-urlencoded content-type as specified in the OAuth 2.0 RFC

Thanks for the report @nverbos-godaddy!

@le-yams just looping you in as you had contributed that code. Would changing the content type still work for you?

@le-yams just looping you in as you had contributed that code. Would changing the content type still work for you?

Absolutely, @nverbos-godaddy is right 😄

@rhamzeh I've created a PR in the sdk-generator project to fix this.

Thank you!

Thanks for the report @nverbos-godaddy and for your help @le-yams !
This should be out in the just released v0.3.2


Add --local-engine-host, which if specified, is used instead of being inferred

Closes https://github.com/flutter/flutter/issues/132162.
I did a tiny bit of minor cleanup but didn't want to go 🍔  beyond the scope of this change. After it lands I'll update the Wiki.
Before
$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64

... would try to use host_debug_unopt (i.e. Rosetta).
After
$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64 \
  --local-engine-host=host_debug_unopt_arm64

... uses host_debug_unopt_arm64, as specified.

/cc @jonahwilliams @gaaclarke @zanderso

Didn't do a code review, but wanted to say this approach sounds good to me. It's mutually exclusive to your ideas about changing the default behavior and having better error messaging. We could chose to do those too if we wanted in the future.

Thanks! I appreciate you writing this!


override the called stop method

Thanks @theclish, looks like we need to tweak our test infrastructure a bit. How urgently do you need a release with this fix?

hmm, I didn't get see a notification for your comment.
I've worked around this in my service so am not blocked. thanks for looking at it 😃

Changed in another PR


Implement and test remove operation on btreelist

At the moment, remove is not implemented, it could be useful for some cases however.
Must be fully unit tested before release.

Completely tested with unit tests, tests run on ESP32


ComponentPortal attached to PortalHost not rendered when content is projected using *ngTemplateOutlet

Bug:
ComponentPortal attached to PortalHost not rendered when content is projected using *ngTemplateOutlet
What is the expected behavior?
When a ComponentPortal is attached to the PortalHost the component should be rendered within the *ngTemplateOutlet
What is the current behavior?
The component is not rendered even though the portal is successfully attached.

What are the steps to reproduce?
https://stackblitz.com/edit/angular-di4q3k?file=app%2Fprojection.component.ts
What is the use-case or motivation for changing an existing behavior?
I'm building a master-detail component that renders a different component based on the subroute that is used.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular v5.0.1
Angular CDK v5.0.0-rc.0

(revisiting older issues as part of a triaging fix-it)
Looking at your stackblitz, you've got a directive on ng-content, which isn't actually supported by the framework. ng-content is a compiler primitive that can't have any directives or attributes applied. If there's still some problem without that, feel free to open a new issue.


Multiple drone supprts

Hi there, thanks for your great job!
Does this simulator supports multiple drones works together?
Thanks!

check Example 2 and 5


Controlling the length of the generated text segments

some times the subtitle is too long , how to controll the length of the text segment?

In case someone else needs this and will find this issue by searching, you can archive this (controlling the length of the generated text segments) using:
        .WithTokenTimestamps()
        .WithMaxSegmentLength(15)


Show data provider when tiles are expanded

As a user, I would like to be see the facility providing the data when I view the results are expanded.
The facility is currently shown only when the tiles are minimized

No problem, while we're at it: what else should be shown in the expanded detail?

I'd like to change the expanded view a bit in the sense that I'd like to expand just one at a time and fetch all "stuff" in one request unlike it is now.


Implement [SimpleButton].

Issued at https://github.com/dooboolab/hackatalk-mobile/issues/34.
This PR is not for merging to master.
I need to know some stories about [Button] of this repo and [SimpleButton] that I would migrate.
Description
Implemented a component called [SimpleButton], the name is temporary to avoid the same name to [Button] which already exists.

[SimpleButton] is almost ready to migrate from https://github.com/dooboolab/hackatalk-mobile/blob/master/src/components/shared/Button.tsx for reusability.
Before finishing the implementation of [SimpleButton], I need to know about [Button] of this repo, to merge and arrange them.
After that all issues related are resolved for the buttons, I'll merge them as a [Button] and ask the real PR.

Related Issues
I have questions as following,

I need to know the side-effects by changing the props(interface) if possible to re-design and refactor [Button].

I think that some of props of Button should be re-designed to have clear meanings.

onClick -> onPress
leftComponent -> icon
deprecate styleto refactor to styled-components
etc.

[SimpleButton] has dark theme in the code as was in hacktalk-mobile, not styled yet.

Should @dooboo-ui/native have dark theme? if so, we need to design a structure to apply dark theme to all components as well.

Tests

No additional tests.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] Run yarn test or yarn test -u if you need to update snapshot.
[x] Run yarn lint
[x] I am willing to follow-up on review comments in a timely manner.

This PR is not for merging to master yet.
@hyochan
Could you please check the Related issues section?
It's about merging the buttons without any critical side-effects.

@Sandwichj Thank you for your insight. I'll try to go over issues you've provided in this PR.

I think that some of props of Button should be re-designed to have clear meanings.

onClick -> onPress
This is fine, but I've have refered to material-ui that they customized the props onPress to onClick which is more widely used in android world.

* `leftComponent` -> `icon`

This is fine either but I just want to point out that there could a case where the icon could stay at the right. Therefore, iconRight and iconLeft could be a candidates.

* deprecate `style`to refactor to `styled-components`

I don't quite agree with this because all of the style props can't be managed as separate props because there are too many. User should have the chance to change the style with style props without the styled-component.

* etc.

[SimpleButton] has dark theme in the code as was in hacktalk-mobile, not styled yet.

Should @dooboo-ui/native have dark theme? if so, we need to design a structure to apply dark theme to all components as well.
Currently, we are passing different colors for dark theme to the shared components. It is recommended how we can organize the dooboo-ui/native components with seperate theming variables like how many other libraries do withTheme.

Hope my answers solve your curiosity. 🙏

@Sandwichj Thank you for your insight. I'll try to go over issues you've provided in this PR.

I think that some of props of Button should be re-designed to have clear meanings.

onClick -> onPress
This is fine, but I've have refered to material-ui that they customized the props onPress to onClick which is more widely used in android world.

* `leftComponent` -> `icon`

This is fine either but I just want to point out that there could be a case where the icon could stay at the right. Therefore, iconRight and iconLeft could be candidates.

* deprecate `style`to refactor to `styled-components`

I don't quite agree with this because all of the style props can't be managed as separate props because there are too many. User should have the chance to change the style with style props without the styled-component.

[SimpleButton] has dark theme in the code as was in hacktalk-mobile, not styled yet.
Should @dooboo-ui/native have dark theme? if so, we need to design a structure to apply dark theme to all components as well.

Currently, we are passing different colors for dark theme to the shared components. It is recommended to guide users how they can organize the dooboo-ui/native components with separate theming variables like how many other libraries do (ex. withTheme). We currently need good solution for this.
Hope my answers resolve your curiosity. 🙏

@hyochan
Thanks a lot for your answers.
I make sense and agree all with your opinions of the answers.
I'll code as following for this issue.

onPress -> onClick for more widely used convention.
icon -> iconLeft, iconRight. Nice idea!
Keep style as a prop for using in variable conditions. Also, I'll set possible to use styled-components as well.
I'll think a structure to use dark theme for customs as well as a default dark theme. It can be better more and more.

I'll close this PR and re-request with better codes later. :)


Not sorting imports correctly?

Hi @renke ! Thanks for the project!
Running into an issue:
Here is my sample file:
import * as React from 'react';

import Counter from './Counter';
import { Provider } from 'react-redux';
import reducers from './reducers';

From package.json:
  "importSort": {
    ".js": {
      "parser": "babylon",
      "style": "eslint"
    }
  },

Running import-sort on this results in a noop. eslint will complain about this - I believe the line import { Provider } from 'react-redux'; should come second?
(Side note - would be awesome to have a try-import-sort website to quickly paste this to demonstrate the issue, hint hint :D)
(Version information):
╔═ markl@xenialdev2-uswest1cdevc:
╚═ ♪ yarn list | grep import-sort
warning package.json: No license field
warning<EMAIL_ADDRESS>No license field
├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>
Thanks!

Hi @magicmark,
yes, the ESLint style is not really working 100% as of now. I created an issue for this #67 so we can fix it.


Can't run syz-ci with commit other than the latest

Describe the bug
Hello,
I noticed that there was a change in some recent revision that is causing me a problem running syz-ci. The tests do not pass, with an error in the TestDisassemblyInReports test.
The appearance of this error allowed me to notice that regardless of the selected commit, syz-ci always downloads the latest commit from the main branch to gopath/src and runs the tests there.
I found the autoupdate flag, but setting it to false, does not change the program's operation and autoupdate still occurs.
I noticed that latestTag := upd.checkLatest() in syz-ci/updater.go#L116 always returns "" (empty string), so the flag condition is not even checked.
Is there any way to run syz-ci from a commit other than the latest?
To Reproduce

Clone the repo
Checkout to the other commit e.g. 52ae002a69946d44626bb626463c27ea196a6551
Build syz-ci with make ci
Run bin/syz-ci -autoupdate=false -config <CONFIG_PATH>
You will see that syz-ci still checkout to the latest commit before run

2023/07/14 11:58:50 ci-local: serving http on http://<IP_ADDRESS>:80
2023/07/14 11:58:50 ci-local: current executable is on 52ae002a69946d44626bb626463c27ea196a6551+
2023/07/14 11:58:50 ci-local: latest syzkaller build is on
2023/07/14 11:58:51 ci-local: syzkaller: poll: d624500f3877323fae8eb084872c5ef9a8ce3ef9 (pkg/build: don't coverage-instrument gVisor sync package in race builds)
2023/07/14 11:58:51 ci-local: syzkaller: building ...

Expected behavior
syz-ci should use current commit

The tests do not pass, with an error in the TestDisassemblyInReports test.

There was a major update of the Docker container which we use for prod/tests. Please pull the latest versions of gcr.io/syzkaller/env and gcr.io/syzkaller/syzbot, all tests should pass then.
If you have ideas on how to make TestDisassemblyInReports tests more independent of the environment, all suggestions are welcome :)

Syz-ci works for me when I use latest docker image and commit. However, this repo doesn't have any tags, or branches that would work with syzkaller_branch option anyway. In my opinion, it would be good to add the option to configure a specific commit, or to use the same commit as the repository from which syz-ci was built


Wrong windows-linux download link

On the page http://hugeinc.github.io/styleguide/start.html
the link for downloading the windows / linux version seems wrong.
Link: https://github.com/hugeinc/styleguide/archive/windows-linux.zip
On the page http://hugeinc.github.io/styleguide/download.html it is correct
Correct Link: https://github.com/hugeinc/styleguide/archive/release/windows-linux.zip
There was an issue like this before ( ref #14 ), but you guys missed the Getting Started page.
I would like to fix it, but I'm not finding the code.... :weary:

I've found it! :grin:

Figure out that the website is on another repository
so I opened a pull request there:
https://github.com/hugeinc/styleguide-website/pull/19

PR merged, link replaced.


Timestamp search

I am trying to do a search by timestamp. Something like "15:03" - but i get weird results or none at all.
Is it even possible to search created_at, updated_at attributes?

wich version are you using?

0.3.1.

try to override this method - https://github.com/antillas21/ajax-datatables-rails/blob/v0.3.1/lib/ajax-datatables-rails/base.rb#L125
or use latest version - 0-4-0 here is sample project - https://github.com/ajahongir/ajax-datatables-rails-v-0-4-0-how-to

Will try...thx!


feat(command): add source last refers to the last executed source

Implement #775 , add a source option last to allow users to open the last source used.

Furthermore, considering the :Neotree command without a specific source is heavily used when interacting with users and most users don't truly trust the default when they need to open a specific source, I personally recommend setting thedefault_source to last in neo-tree.defaults.

Furthermore, considering the :Neotree command without a specific source is heavily used when interacting with users and most users don't truly trust the default when they need to open a specific source, I personally recommend setting thedefault_source to last in neo-tree.defaults.

I don't think you have any way of knowing that, you are just speaking about your own usage here and projecting that on others. 90% of the time I use a mapping and not the command. When I just use :Neotree without specifying a source, I expect it to be the "filesystem" source because that is the one I use more often. Also, based on my interactions with users to date I would say that the vast majority of users primarily use the "filesystem" source, so it makes sense that this would be the default.

Of course, this is merely a minor suggestion for the design. Since it could disrupt existing user configurations, I'm not implementing these thoughts in the current PR.
But honestly, I think this design is a little weird. Considering neo-tree could switch between different sources in the same window, some users might be very eager to leverage this feature, and there is a situation:
I opened a neo-tree filesystem window by Neotree toggle (no matter with a keymap or enter the command directly), and after a while, I switch to another source like the buffer source. Finally, I want to close the existing neo-tree window by Neotree toggle because I think it would do that, but the result is I switch the current window to the filesystem window rather than close it.
What I want to demonstrate is when you toggle, you'd better know what you are toggle, rather than take advantage of the default value. If you assign a key to the Neotree toggle filesystem, it becomes clear that this key is solely for toggling the filesystem, regardless of the current source.
In fact, this PR also solves the previous problem. Because switching to another source would call execute again, when you use Neotree toggle last, no matter what source you switched after that, Neotree toggle last will close this window.
But as I mentioned before, I would not implement it in this PR, it is just a suggestion.

I discovered that implementing this feature might not require extra work. because when I execute Neotree toggle  without specifying an explicit position, it defaults to the last position where this source was opened.
So, in essence, Neotree toggle is equivalent to Neotree toggle position=last. The only requirement is to implement source=last, which has been accomplished in this PR.

I discovered that implementing this feature might not require extra work. because when I execute Neotree toggle without specifying an explicit position, it defaults to the last position where this source was opened.

It does do that most of the time, but not always. It does not work for position="current". If you use the current position, it will toggle the default position of the sidebar version instead.

Completed, the position will be last if it is not specified now.


Change KaigiTopAppBar color

Idea Description
app

design

Reference images and links

I want to try.
Please assign to me.

I'd like to do this 🙋🏼

Thanks! Assigned 👍


Add pyright support

Microsoft is moving on to a proprietary language server backend for python in vscode, pylance, which is implemented on top of the pyright library. It seems like development will be ceasing on the C# Microsoft Python Language Server in favor of this implementation (which is JS based, but apparently somehow much faster). Pyright also includes a language server implementation (sans some additional ML powered intellisense features in pyright). Coc has added support via coc-pyright and there has been some discussion on using the pyright in emacs lsp-mode [here] (https://github.com/emacs-lsp/lsp-mode/issues/1863).
I managed to get nvim to launch and connect to the pyright language server as follows:
local configs = require 'nvim_lsp/configs'
local util = require 'nvim_lsp/util'

local server_name = "pyright"

configs[server_name] = {
  default_config = {
    cmd = {"node", "/home/michael/Repositories/pyright/client/server/server.bundle.js", "--stdio"};
    filetypes = {"python"};
    root_dir = function(fname)
      return util.find_git_ancestor(fname) or vim.loop.os_homedir()
    end;
  };
  docs = {
    description = [[
]];
    default_config = {
      root_dir = [[root_pattern(".git", vim.fn.getcwd())]];
    };
  };
}

-- vim:et ts=2 sw=2

But currently it fails with:
[ DEBUG ] 2020-07-01T22:19:39-0700 ] ...-unwrapped-master/share/nvim/runtime/lua/vim/lsp/rpc.lua:347 ]  "decoded"       {  jsonrpc = "2.0",  method = "window/logMessage",  params = {    message = "Notification handler 'initialized' failed with message: Client doesn't support sending workspace folder change events.",    type = 1  }}
[ DEBUG ] 2020-07-01T22:19:39-0700 ] ...ovim-unwrapped-master/share/nvim/runtime/lua/vim/lsp.lua:343 ]  "notification"  "window/logMessage"     {  message = "Notification handler 'initialized' failed with message: Client doesn't support sending workspace folder change events.",  type = 1}
[ DEBUG ] 2020-07-01T22:19:39-0700 ] ...pped-master/share/nvim/runtime/lua/vim/lsp/callbacks.lua:257 ]  "default_callback"      "window/logMessage"     {  client_id = 1,  params = {    message = "Notification handler 'initialized' failed with message: Client doesn't support sending workspace folder change events.",    type = 1  }}
[ ERROR ] 2020-07-01T22:19:39-0700 ] ...pped-master/share/nvim/runtime/lua/vim/lsp/callbacks.lua:226 ]  "Notification handler 'initialized' failed with message: Client doesn't support sending workspace folder change events."
[ DEBUG ] 2020-07-01T22:21:32-0700 ] ...ovim-unwrapped-master/share/nvim/runtime/lua/vim/lsp.lua:587 ]  "on_lines"      1       4       7       7       8       0       0       0       { "" }

Damn you, Microsoft

As of https://github.com/microsoft/pyright/pull/810 pyright language server can be installed via npm
npm install -g
pyright-langserver

As of microsoft/pyright#810 pyright language server can be installed via npm
npm install -g
pyright-langserver

Doesn't seem to be in the npm registry?
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/pyright-langserver - Not found
npm ERR! 404
npm ERR! 404  'pyright-langserver@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

@nymann Was missing the package, pyright-langserver --stdio is the command invoked, the package is pyright

FYI while we wait for the PR
I think you can get around the neovim PR by adding the following to the pyright config
before_init = function(initialize_params, config)
            initialize_params['workspaceFolders'] = {{
                name = 'workspace',
                uri = initialize_params['rootUri']
            }}

this will not add, remove, or list the workspace folders, but those functions I think can be added to your init.vim

Pylance support If you need.
https://github.com/aca/pylance.nvim

Damn you, Microsoft

Running Pylance outside of Visual Studio Code no longer works:
$ node ~/.vscode/extensions/ms-python.vscode-pylance-2020.10.3/dist/server.bundle.js --stdio
You may install and use any number of copies of the software only with
Microsoft Visual Studio, Visual Studio for Mac, Visual Studio Code, Azure
DevOps, Team Foundation Server, and successor Microsoft products andservices
(collectively, the “Visual Studio Products and Services”) to develop and test
your applications. The software is licensed, not sold. This agreement only
gives you some rights to use the software. Microsoft reserves all other rights.
You may not: work around any technical limitations in the software that only
allow you to use it in certain ways; reverse engineer, decompile or disassemble
the software, or otherwise attempt to derive the source code for the software,
except and to the extent required by third party licensing terms governing use
of certain open source components that may be included in the software; remove,
minimize, block, or modify any notices of Microsoft or its suppliers in the
software; use the software in any way that is against the law or to create or
propagate malware; or share, publish, distribute, or lease the software (except
for any distributable code, subject to the terms above), provide the software
as a stand-alone offering for others to use, or transfer the software or this
agreement to any third party.

Using Pyright directly is also the recommended and supported way and that still works.

Unfortunately, as of v2020.10.3 running Pylance outside of Visual Studio Code no longer works 😞
$ node ~/.vscode/extensions/ms-python.vscode-pylance-2020.10.3/dist/server.bundle.js --stdio
You may install and use any number of copies of the software only with
Microsoft Visual Studio, Visual Studio for Mac, Visual Studio Code, Azure
DevOps, Team Foundation Server, and successor Microsoft products andservices
(collectively, the “Visual Studio Products and Services”) to develop and test
your applications. The software is licensed, not sold. This agreement only
gives you some rights to use the software. Microsoft reserves all other rights.
You may not: work around any technical limitations in the software that only
allow you to use it in certain ways; reverse engineer, decompile or disassemble
the software, or otherwise attempt to derive the source code for the software,
except and to the extent required by third party licensing terms governing use
of certain open source components that may be included in the software; remove,
minimize, block, or modify any notices of Microsoft or its suppliers in the
software; use the software in any way that is against the law or to create or
propagate malware; or share, publish, distribute, or lease the software (except
for any distributable code, subject to the terms above), provide the software
as a stand-alone offering for others to use, or transfer the software or this
agreement to any third party.

It still works, thanks for @aca 👍
$ ELECTRON_RUN_AS_NODE=1 VSCODE_NLS_CONFIG='{"locale": "en"}' node ~/.vscode-server/extensions/ms-python.vscode-pylance-2021.3.0/dist/server.bundle.js --stdio

But why not just use pyright?

Unfortunately, as of v2020.10.3 running Pylance outside of Visual Studio Code no longer works disappointed
$ node ~/.vscode/extensions/ms-python.vscode-pylance-2020.10.3/dist/server.bundle.js --stdio
You may install and use any number of copies of the software only with
Microsoft Visual Studio, Visual Studio for Mac, Visual Studio Code, Azure
DevOps, Team Foundation Server, and successor Microsoft products andservices
(collectively, the “Visual Studio Products and Services”) to develop and test
your applications. The software is licensed, not sold. This agreement only
gives you some rights to use the software. Microsoft reserves all other rights.
You may not: work around any technical limitations in the software that only
allow you to use it in certain ways; reverse engineer, decompile or disassemble
the software, or otherwise attempt to derive the source code for the software,
except and to the extent required by third party licensing terms governing use
of certain open source components that may be included in the software; remove,
minimize, block, or modify any notices of Microsoft or its suppliers in the
software; use the software in any way that is against the law or to create or
propagate malware; or share, publish, distribute, or lease the software (except
for any distributable code, subject to the terms above), provide the software
as a stand-alone offering for others to use, or transfer the software or this
agreement to any third party.

It still works, thanks for @aca +1
$ ELECTRON_RUN_AS_NODE=1 VSCODE_NLS_CONFIG='{"locale": "en"}' node ~/.vscode-server/extensions/ms-python.vscode-pylance-2021.3.0/dist/server.bundle.js --stdio

But why not just use pyright?

rip https://github.com/aca/pylance.nvim

Hi all, please keep issues on topic

I had to delete the repository because of a license issue. Sorry for pylance.nvim user.


getSubscriptions stopped working from one day to another

Version of flutter_inapp_purchase
5.0.1
Platforms you faced the error (IOS or Android or both?)
Only tested on Android
Expected behavior
getSubscriptions() returns all the subscriptions configured in google console.
Actual behavior
getSubscriptions() gets stuck and doesnt return anything
Tested environment (Emulator? Real Device?)
Real device
Steps to reproduce the behavior
I dont really know, one day worked, the next day it stopped working and this is the second day that it doesnt fetch items correctly.
Flutter doctor
[√] Flutter (Channel stable, 2.2.2, on Microsoft Windows [VersiÃ³n 10.0.19042.1052], locale es-ES)
• Flutter version 2.2.2 at C:\src\flutter
• Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
• Engine revision 91c9fc8fe0
• Dart version 2.13.3
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at C:\Users\Mikel\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] IntelliJ IDEA Ultimate Edition (version 2019.2)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.2.4
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] VS Code (version 1.57.1)
• VS Code at C:\Users\Mikel\AppData\Local\Programs\Microsoft VS Code
• Flutter extension can be installed from:
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (3 available)
• ONEPLUS A5010 (mobile) • 63be0fb9 • android-arm64  • Android 9 (API 28)
• Chrome (web)           • chrome   • web-javascript • Google Chrome 91.0.4472.124
• Edge (web)             • edge     • web-javascript • Microsoft Edge 91.0.864.59
• No issues found!

If you guys need any more info ask me for it

is there a way to check the state of the connection to google? I didnt change the code nor the google console configuration, yet it stopped working. I think might be a connecting to google issue more than changes in the code. Please help.

Same for me with flutter_inapp_purchase and in_app_purchase too . Is there any solution?

Same for me with flutter_inapp_purchase and in_app_purchase too . Is there any solution?

I had billing dependency from Google put in the build.gradle, and it looks like it made a conflict with the package. I created an issue here: https://github.com/dooboolab/flutter_inapp_purchase/issues/296#issue-933398513
If you have it, delete the dependency com.android.billingclient:billing:$version from build.gradle.
Have a good one

@corrosionadam99 did this solve it for you? If so, please tell in the other issue I mentioned (#296) that you would also like to put a disclaimer in the readme.


Add draw_* operations to MutableImage

Based upon a request I started working on adding the draw_* operations to MutableImage. This PR is not ready, but I did want to get your blessing to keep going to flesh out all the functions and add tests.
I have an experimental draw branch of Image that calls these functions and so far it seems to work very well.  There is a demo script that executes in under 500ms to add 1000 circles of a random color and location and uses less than 3Mb of memory.
As always your guidance/corrections most welcome.

Hi @kipcole9, Thanks again for taking your time to help new features for vix!
apologies for slow response. Bit busy with day job at the moment.
The main concern I have with mutable operations is (I think you are also aware of this) is that it is a bit tricky to ensure parallel libvips operations happening on the same memory. Using MutableImage is right direction, which you are already doing. But it would be great if we make it impossible to have that scenario. I mean, mutable operations should not even be visible in Operation module for someone to misuse unknowingly. But these can be addressed separately I think. The overall approach looks good to me.
I wasn't sure about performance and practicality of these operations given the constrains like using beam process for image. But based on your benchmark, seems it is not that bad when we are doing lot of mutable operations at once.(as opposed to mixed mutable, immutable operations)
I might take some time to test and benchmark. But feel free to explore and push changes. I'll make sure to get it merged ASAP.

Thanks for the guidance @akash-akya . Agree with the concerns over parallel operations and also performance.  Glad I'm heading in a reasonable direction.  I did see if omitting the @doc for these mutable operations was a possibility and then realised it needs a bit of work - something I can come back to later.
For performance, I built a small demo repo that matches what I was asked to look at. It streams a CSV file and plots 10_000 circles on an image.  The code is at https://github.com/kipcole9/cropping - if takes 4 seconds on my MacBook Pro (M1 Max) which I think is quite reasonable given all that is going on.  Performance seems linear (about 400ms for 1_000 circles) which is good to see. The README has the very simple instructions to run it.
Will keep going on the draw_* functions for now and let you know when I'm close enough to complete for a review.
Thanks again, --Kip

Hi @kipcole9, I looked into the changes. Overall, looks good to me.
I'm thinking of minor refactoring, like moving code around to make Vix prepared for mutable-operations. I'm thinking of creating a separate module for MutableOperation similar to Operation.
Can you take a look? -- https://github.com/akash-akya/vix/compare/master...draw
If it is okay then, I can merge this PR and make changes on top of that.

@akash-akya sounds great to me, very happy to follow your lead. You're much better at this than I am!


Does eureka server support server-side load balance strategy?

As I know, Ribbon supports client-side load balance strategy,Does eureka server support server-side load balance strategy?

Hi @killjason there is some very basic "client side LB" available via the default java client, see EurekaClient.getNextServerFromEureka(). However there are currently no LB rest endpoints exposed from the server.


Changed end2end tests to contribute coverage to unit tests

For details, see the commit message.
No review needed.

coverage: 33.944%. first build when pulling 2f2907f3ca42081d5365ab617b4cade3f4815849 on andy/clarify-coverage into b27e0728819f461fc989a099b8bdcc9bed94f566 on master.


Expand doc and exception message regarding g:fsharp_interactive_bin

Add a reference to the g:fsharp_interactive_bin variable to the readme for settings.  Also add a more detailed exception message when the fsi call fails.
Background: When I initially setup vim-fsharp on my machine, the default bin didn't work for me.  This pull request is intended to help others in the future diagnosis and resolve similar issues.

Thanks.


? in prometheus.yml metrics_path the urlEncoded

this is my prometheus.yml
`global:
scrape_interval:     15s
scrape_configs:

job_name: metrics
metrics_path: "/actuator/swPort?taskName=alarm"
scrape_interval: 14s
scrape_timeout:  14s
static_configs:

targets: ['localhost:8081']`

and in chrome url is http://localhost:8081:/actuator/swPort%3FtaskName=alarm
It leads to my endPoint is 404  and no data in prometheus
his state is down.
I don't want this ? Be urlEncoded

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Provide an API to use crypto.subtle for SymEncoder and AsymEncoder

This is a feature request
Problem

Right now, SymEncoder uses a Uint8Array key to sign messages and encrypt them. It uses secp256k1 and nothing else can be used. This is a perfectly valid choice and I'm not sure it's worth it making the API more complicated as we already have sane defaults. However, in our case we were already using crypto.subtle, and it turns out that those keys cannot be used with SymEncoder.
Two issues:

It's not possible to export crypto.subtle elliptic curve private keys to the raw format (so we can't get the Uint8Array we need), at least not without hacks
crypto.subtle only implement NIST curves, which secp256k1 is not

Proposed Solutions

Instead of passing a private key directly, it might be more appropriate to pass some object that contains sign and publicKey properties for the signing, and another object that has an encrypt function for the encryption.
For example, instead of:
new SymEncoder(
	'topic',
	encryptionKey,
	signingKey
)

have something like:
const encryptionKey = await crypto.subtle.deriveKey(/* ECDH */)
const signingKey = await crypto.subtle.generateKey(/* ECDSA */)

new SymEncoder(
	'topic',
	{
		encrypt: async (data: Uint8Array) => crypto.subtle.encrypt(algorithm, encryptionKey, data)
	},
	{
		sign: async (data: Uint8Array) => crypto.subtle.sign(algorithm, signingKey, data),
		publicKey: Uint8Array
	}
)

Alternatively, it would be quite useful to document the algorithms that are used here: https://js.waku.org/classes/lib_waku_message_version_1.SymEncoder.html
I know I should have read the RFC and maybe dived into the code a bit more, but as someone who is not that familiar with cryptography, I wasn't aware that P-256 was different from secp256k1 for example. In hindsight it seems fairly obvious, but I guess I was a bit too naïve. 😅
Notes

From what I can see secp256k1 is the only curve supported by the RFC (https://rfc.vac.dev/spec/26/), so this might be more trouble than it's worth. For now, I'm just going to change everything and get rid of crypto.subtle in order to implement something closer to the eth-pm example.

Relevant https://github.com/w3c/webcrypto/issues/82#issuecomment-849856773

While it doesn't seem we can use Subtle Crypto for Waku Message 1 cryptographic operations, I think it could be interested to define a new standard that uses modern schemes available in Subtle Crypto to provide a more secure turn key solution for encryption and signing purposes.

Do note that the direction we are currently going towards for encryption is https://rfc.vac.dev/spec/35/ but this does not help for signing.


Fix GH Actions CI

Overview
After submitting my PR implementing $IN_LORRI_SHELL, I noticed a lot of CI was failing. Thus, I decided to spend a little bit to fix up what I could. CI should pass with flying colors, now.

Checklist

[ ] Updated the documentation (code documentation, command help, ...)
[x] Tested the change (unit or integration tests)
[ ] Amended the changelog in release.nix (see release.nix for instructions)

EDIT: About to sleep, but it looks like that Travis failure might be fixable after all. I'll check in the morning. I can't reproduce the warning/error locally... I guess I'll take this chance to see if I can't move us entirely to GH Actions. nvm, I needed to use Rust 1.41.0 to see the issue. Latest stable apparently doesn't have this problem.

Super!
Now all we need for feature parity with travis is a macOS runner as far as I can see. Unfortunately, Github Actions does not provide macOS builders on its free tier (reasonable), and the paid version is super expensive (8¢/minute). I wonder how hard it is to install the runner on an old macbook we have flying around.

@Profpatsch I've actually been working on bringing GH Actions on-par with Travis on my branch here: https://github.com/cole-h/lorri/pull/3 (ignore the super-descriptive name).
I don't think macOS builders actually cost money for public Actions. As you'll see in my above link above, I've added macOS to the matrix (and tested the macOS stuff many, many times) and still have a grand total of 0 minutes used on my account and not a dime owed on the Billing page.
I think the confusion comes from the fact that the following sentence is not very well-advertised: "GitHub Actions usage is free for public repositories." (from here) This might come from the fact that I am considered "Pro" (yay, being a student!) and a user account instead of an organization like Target, however.

EDIT2: Update: still no minutes used and no money due in the Billing page. I think it should be safe?

Gonna push your branch and see what happens.


[Breaking] Add allowedServiceList to TestServiceProvider

This will require a  whitelist of services to maintain better unit tests

fixes #113

Verified that @j3tan has signed the CLA. Thanks for the pull request!

+2


⬆ build(deps): update CocoaLumberjack to support XCode 13

Currently CocoaLumberjack does not support XCode 13, it will provide the following error:

module compiled with Swift 5.4.2 cannot be imported by the Swift 5.5.1 compiler

This is because CocoaLumberjack does not support Swift 5.5 until CocoaLumberjack 3.7.3. In this change set, I upgrade it to the latest CocoaLumberjack 3.7.4 by using carthage:
carthage update --platform macOS
carthage update --platform iOS --use-xcframeworks

I think we need to fix:

https://github.com/Jigsaw-Code/outline-client/blob/master/.github/workflows/build_and_test.yml#L93
https://github.com/Jigsaw-Code/outline-client/blob/master/.github/workflows/build_and_test.yml#L120

Could you update the Github action to use the right Xcode? The tests are not passing because of incompatibility the other way:
module compiled with Swift 5.5.2 cannot be imported by the Swift 5.4.2 compiler

Also, shouldn't we be using the xcframework instead?

xcframework requires changes to XCode project, we need to use another PR if we would like to do so.


Use try/except to return an empty model list if Ollama is not responding

This PR adds a small function to use try/except, instead of calling ollama.list() directly.
I wanted this as my ollama instance(s) are often offline, and llm-ollama treats that as fatal and stops llm-cli running.
I think its cleaner to return an empty list, and let llm-cli continue.
In my case, this means if my local docker ollama isn't running or my desktop is off, I can still use other llms without using LLM_LOAD_PLUGINS to work around it.

Thanks for reporting and contributing! I've pushed a modified version of your fix and released a new plugin version.