multiple modal opening bug

Sometimes we may open multiple modals in one page. When a modal hide, another modal can't fixed to screen. I think this bug maybe caused by this：
 When a modal hide, bootstrap will remove class `modal-open` of body.

We should fix this by counting opening modal number. If the number is equal to zero we should remove class modal-open of body.
Now I use code like below to handle this bug:

 $('.modal').on('hidden.bs.modal', function () {
     if ($('.modal').hasClass('in')) {
          $('body').addClass('modal-open');
    }
 });

Multiple modals are explicitly not supported in Bootstrap, I'm afraid.
http://getbootstrap.com/javascript/#modals


fix: estimate gas limit for erc20 transfers

closes #2971

the issue still remains:

In general it's working. I can send max amount all my ERC-20 tokens and ETH. I would like to check it once again when new SDK version will be applied.

In general it's working, but could be some edge cases.
For example:
I got this issue when tried to send Link token one by one:
1- i sent 0.1 link
2 - was trying to sent max link in a while and got an issue
I think this is because the previous tx was in pending status and the balance was not updated properly after sent 1st tx:

I have question about WETH:
is this total sum correct?
i was sending 0.0001 WETH , but see it as 0.0002 (there is a fee paid in eth)
https://github.com/superhero-com/superhero-wallet/assets/69896204/5a45e157-c735-4470-b803-90f00d706dbf

The second issue has been fixed, LGTM.
For the first one I've registered a separate issue.


FedIoT survey

Type of change

[x] Add new papers (Please tell us why you think this paper is awesome!)
[ ] Fix the category of an existing paper/papers (Please tell us the reasons)
[ ] Add a new tool/primitive/application with a new markdown page (Thank you! Also, please tell us more about this awesome thing!)

Description

A very good introduction paper for federated learning, and precisely outlines sever questions for the implementation of FL on resource-constrained IoT devices. The paper has been accepted by IEEE IoTM.

I have read the CLA Document and I hereby sign the CLA


Problem with Pie in ios and android

Bugs and Questions
Checklist

[x] This is a victory-native specific issue. (Issues that also appear in victory should be opened here)

[x] I have read through the FAQ and Guides before asking a question

[x] I am using the latest version of victory-native

[x] I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native. Read about version requirements

[x] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem
Hi, I have try the Pie with a simple example:
<VictoryPie                                     innerRadius={100}                                     colorScale={["#F1BF53", "#3CB5E8", "#DF6055"]}                                     data={[                                         { x: 35, y:35 },                                         { x: 24, y: 24 },                                         { x: 41, y : 41 }                                     ]}                                 />
but the result is a nightmare... in ios and android the pie is half....

can you help me for resolve this problem?
thanks

@robertobrogi I'm closing this issue as a duplicate


Updated resetWorflow logic to remove workflow instead of updating it …

…in indexer.

Pull Request Test Coverage Report for Build 3486

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 70.191%

Totals

Change from base Build 3480:
0.05%

Covered Lines:
11159

Relevant Lines:
15898

💛  - Coveralls


add missing verbose_name_plurals

Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines http://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For front-end changes: Did you test on all of Wagtail’s supported browsers? Please list the exact versions you tested.
For new features: Has the documentation been updated accordingly?

This was already merged in #4833 and will be included in Wagtail 2.4.


Change Nginx server configuration

Hi all!
We detected that in some Centos distributions, the actual Nginx recipe nginx.rb is failing due to some non-usual Nginx default configuration. Normally, in the main configuration file of Nginx /etc/nginx/nginx.conf there should be an include statement which loads the sites defined in the path /etc/nginx/sites-enabled/* but as we detected, this statement did not exist.
To solve this issue we simply need to instead of writing the template into /etc/nginx/sites-available/default we write it as a total separated configuration file in /etc/nginx/conf.d/kibana.conf
Tasks to Do

[x] Change the template file's path
[x] Verify the changes.

Kr,
Rshad

Working in: fix-70-fix-nginx-recipe

Hi all!
The changes were applied and verified.

Changed the target template path.
Removed duplicate server configuration from the template.

Before Changes:
server {
    listen 80;
    listen [::]:80 ipv6only=on;
    return 301 https://$host$request_uri;
}

After Changes:
https://github.com/wazuh/wazuh-chef/blob/2a2182fd61edb65844c91a03b6692fe3637df6a7/cookbooks/wazuh_elastic/templates/default/nginx.erb#L1-L14
Check changes here.
Kr,
Rshad


[Maps - RevGeoCoding] Add version preview/2022-09-01-preview

API Review Board infomation
•	Service name: Azure Map RevGC API
•	Key contact for the review: John Lai<EMAIL_ADDRESS>•	Whether this is a new or existing API: New API
•	Whether or not your service already been deployed: No
•	A brief description of the material to be reviewed/changed: Add Reversed API in public-preview geocoding API
•	Link: [Hub Generated] Review request for Search to add version preview/2022-09-01-preview by john35452 · Pull Request #19951 · Azure/azure-rest-api-specs (github.com)

API Stewardship Board Review Meeting 11-Aug-22

Is the hierarchy fixed, or is it dependent on
matchedType -- this may not be the most intuitive name because the user can pass in multiple values. It's an anti-patter to have a singular name matchedType when the input is a collection.

suggestion matchTypes as the name

In the GET, make the most relevant/important result first in the json. This way, if a customer codes their app to just look at the first result (because it's an edge case to return two results), their code will still work.
The return value of application/geo+json --

For example - Cosmos uses GeoJSON, Search uses GeoJSON, etc. It's Azure's answer for Spatial data types for sure. We've got first class support for it in Azure.Core for C# and Java.
[7:38 PM] Ted Glaza
Suggestion for versioning/future proofing:
{  "matches": {     /* Pure GeoJson here /   },
/ future properties go here... */}

Actions
References
Meeting Chat
Meeting Recording
Design Doc Slides: Azure Map RevGC API Review.pptx
Helpful Documentation

Azure API REST Documentation
Considerations for Service Design
REST API Guidelines
OpenAPI Style Guidelines
Breaking Changes

Note: The Teams channel is internal MS.


[Feature request] More transformations for data augmentation?

Any plan or guide to add these transformations?
https://github.com/facebook/fb.resnet.torch/blob/master/datasets/transforms.lua

see #27


Adding new organsiation name to the Readme

U can add new names of open source organisations to the readme file

@jmanfeld ok thanks can u pls explain it a little bit and yes pls do follow me and star the repository

#34 added four organisation names

ok cool

@orestotel pls follow me and also star this repo

#274 added new organisation name to readme file

@tanvibattu Good that was merged, thanks  for contributing.

#279 added a new organisation name to readme file.

@vatsalanarang that's great, thanks for contributing.

#285 added a new organisation name to readme file.

@CAT-ID Yup it just got merged thanks for your contribution.

#384 I've made a PR, have a look @Ishaan28malik

###35 I added a new organisation.

@hp77-creator I have merged it, thanks for contributing.

@kmalik31 thanks for your contribution.

Hello, I added a translation of the Readme file to portuguese. Please have a look at my PR #672

@Jadson1197 thanks for contributing. it's already merged.

Added 2 new organisation name to the Readme. Please review  pr #958

Hello, @Ishaan28malik  I've added new organizations to the list. PR #963. I hope someone finds it useful.

hello, @Ishaan28malik  i have added a new organization to the list.PR #981.if any changes please let me know.Thanks

Hi, @Ishaan28malik  I have added InfraCloud in the list of companies offering swags please review PR #1024

Added 2 new organisation name to the Readme. Please review pr #958

Great

Hello, @Ishaan28malik I've added new organizations to the list. PR #963. I hope someone finds it useful.

Awesome


Manpages only show XML & HTML as options for "--output"

I've just noticed that the manpages for mediainfo/mediainfo-gui show only XML and HTML as options for the "--output" parameter :cry:
The "--help" displays the other options (JSON, EBUCore, etc).
I can add the info from the "--help" page to the manpages if you like?
(I'd copy/paste wording from Source/CLI/Help.cpp, so it's consistent)

btw: I've noticed the manpage text in multiple locations in the source tree:

debian/mediainfo[-gui].pod
Project/OS/deb9.debian/mediainfo[-gui].pod
Project/OS/deb7.debian/mediainfo[-gui].pod

These seem to be identical :thinking:
I assume any change should be applied to all 3 of them?

Right, there are multiple locations for help, and also not in sync.
A corresponding PR would be appreciated.

Done:
PR #331


Provide a visual cue when something has a "preview" for hover/click

Context
Right now there are multiple ways that a hover preview can show up:
By hovering over a "normal" looking link:

By explicitly clicking a link with some dotted underline:

It is a bit confusing to have different kinds of behaviors and visual styles for the "hover preview" behavior, so I suggest that we provide some standards for extensions to follow.
Proposal
We should define a default behavior for both:

The visual style that indicates something is an "enriched reference" and not just a hyperlink
We should define the behavior that is consistent across all enriched references (e.g. is it always click? hover? hover w/ delay?)

Tasks and updates
No response

I spent some time a few weeks ago to try and reconcile these, but ended up backing out the change.
The current setup:

Things like the wiki hover-links and document links, show extra information before you leave the current page. (tried to copy wikipedias UX here, but needs more delay for showing the popup).
The hover popups, can contain rich information like a demo, citation, or another rich cross-reference. So hovering, and leaving isn't great, which is the main reason for the two behaviours currently.

Some of my questions:

Should the "enriched links" have an icon after them, and that is what opens the popup?

This could allow us to not show anything special about the links, allowing you to still click normally (always), but can also create a visually distinct icon that indicates rich information?

Should hover happen by default on all of these elements (e.g. citations)?

2 quick thoughts:

An icon-style visual cue seems reasonable, similar to how external links have that little box w/ an arrow 🤷 - not sure how it'd look in practice all of the page though.
Does hover vs. click have accessibility considerations? Maybe that's one way to guide decisions?
I tend to try to copy the UX behavior of GitHub so maybe use that as a starting point?

For comparison, here's how Google does the UX around hoverable semantic text. They do:

Black text (not link blue)
Dotted line underneath always visible
Finger pointer on hover, no display
Display on click
Show the blue link to the page title at the bottom of the hover

How obsidian does hover preview
Just some more field research: the way Obsidian handles this is by using ctrl to activate "preview on hover". If you hover over internal links normally it doesn't do anything, but if you hit ctrl then it will create a preview.
E.g. here's me getting a little carried away with preview-inception.

I am pushing through a few tech-related changes to improve hover link consistency. I still don't think the styles are quite right, but the tech is much better and I have made it consistent for things like abbreviations, code previews, internal cross-references, citations, and wiki links.
The links now actually scroll to the right position on linked pages, as well as scroll rather than jump if you are on the same page (similar to the outline).
I will push through with the deployment (it is an improvement), and then get feedback!


Parameterizing web.config

In the web.config of ASP-NET-Blog-Application, the connection string is hardcoded. How can this be parameterized such that we can maintain a single image, but pass DB server name, DB name, and credentials to the container at docker run time?
I was thinking of adding a PS script to the image which gets invoked via CMD or ENTRYPOINT, and have that script accept parameters from docker run, which would update web.config.
Just curious as to what best practice is here. I have similar concerns for the registry, SSL certificates, etc.

Hi @mrichman
There is faster and more knowledgeable support on the Docker forums: https://forums.docker.com/search?q=connection string
I'm happy to help but honestly don't know what the best practice is.
I did some searching around - what does the connection string do?  Is there a doc that describes it?
This came up in my search - maybe it will help?
http://stackoverflow.com/questions/16408068/azure-storage-connection-string-without-the-account-key-public-containers

Closing this issue due to inactivity. Please feel free to open it again if there is still something we can help with.


Florian/test pipeline

Can't build the plugin locally for what seems to be upstream issues, opening a random PR to check if the CI can build it

Confirmed to be an upstream issue https://issues.jenkins-ci.org/browse/JENKINS-62635?jql=ORDER BY created DESC


Use period instead of hyphen for defining version

Tried bundling on Demo with the loop23/twitter-typeahead-rails project and an exception was thrown:
Fetching source index from https://rubygems.org/
Fetching https://github.com/loop23/twitter-typeahead-rails.git
There was a ArgumentError while loading twitter-typeahead-rails.gemspec:
Malformed version number string 0.11.1-corejavascript from
/data/examtime/shared/bundled_gems/ruby/2.0.0/bundler/gems/twitter-typeahead-rails-f200f9b8d2e5/twitter-typeahead-rails.gemspec:8:in
`block in <main>'

	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/servers.rb:85:in `run_on_each!'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/task.rb:74:in `run'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager/base.rb:37:in `block in run'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/task.rb:67:in `roles'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager/base.rb:36:in `run'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager/bundler.rb:53:in `install'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager.rb:72:in `block in install'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager.rb:52:in `each'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager.rb:52:in `each'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/dependency_manager.rb:72:in `install'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/deploy.rb:99:in `install_dependencies'
	from /usr/local/ey_resin/ruby/lib/ruby/gems/1.9.1/gems/engineyard-serverside-2.6.3/lib/engineyard-serverside/deploy.rb:95:in `bundle'

More info here: https://github.com/ExamTime/ExamTime/issues/14072


Create socials-area.svelte section 💕

A section named components/sections/socials-area.svelte should be created and placed into the /connect route. There are 4 social buttons needed (with their respective links):

Instagram: https://www.instagram.com/acmcsuf/
Discord: https://tinyurl.com/acm-csuf-discord/
LinkedIn: https://www.linkedin.com/company/acm-at-csuf/
YouTube: https://www.youtube.com/channel/UCDMBj0o4V8Cpt0jgsZLNVVg

Under mobile dimensions, the list of socials will be a column (1x4), but under desktop dimensions the list will become a 4x4 grid.

Resolved by #66 🎉


codemov: fix build with rust 1.80

Description of changes

add patch from unmerged upstream PR updating time crate, fixing build with rust 1.80
https://github.com/sloganking/codemov/pull/16

Fixes build of codemov:
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.codemov.x86_64-linux
https://hydra.nixos.org/build/269597495
Error log:
error[E0282]: type annotations needed for `Box<_>`
  --> /build/codemov-unstable-2023-08-08-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

Tracking issue:
#332957
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 337418 run on x86_64-linux 1

1 package built:

codemov


Just a general question about performance

Hi
I am asking a general question regarding performance since I am choosing one image downloader now. How is the performance of ImageLoaderSwift compared with using AFNetworking, SDWebimage, or swift counterpart such as Haneke, KFSwiftImageLoader, etc. Thanks very much!

I have used AFNetworking and SDWebImage as image loader. SDWebImage has high performance, but it is a huge library and has many options and supports formats. I create this library because I want to more lightweight and hight performance library.
Reference: https://github.com/bpoplauschi/ImageCachingBenchmark


m2-hsio-module support

I am going to try to add support for the m2-hsio-module.
Is there any known issue for this?
http://avnet.me/m2-hsio-module

None "known" at this time.  Has not been used with this PYNQ build, I don't know of any reason why it wouldn't work.
Are you going to just use PYNQ Python to use it, or requesting to fully integrate it into PetaLinux and the PYNQ SD card release?

It needs to be added to the device tree, and PCIe tools (like lspci) need to be included in the build.
I attempted to do it, but I need to install the correct version of all the tools...
It would be great if the official build supported M2 and/or DP HSIO modules.
It's on my to-do list, I will fork/ pull-request if I get a working build.

Andrew,
One known issue:

the M.2 HSIO must be placed on the J2 connector, since it requires the lower transceiver lanes for the PCI express functionality.

This is described in the following project:

https://avnet.me/vitis-ai-3.0-hailo-8

Regards,
Mario.

Hi, My only request is: that we do it in some manner that is compatible with and without the add-on card, preferably all in a single SD release image.  Meaning not managed by compiling 2 different branches if possible.
I don't have time right now to do it all but I can help you.  At this time I do not even have an HSIO card but I could get one.
The device tree and kernel options can be modified through the use of the content under here: https://github.com/Avnet/ZUBoard_1CG-PYNQ/tree/main/ZUBoard_1CG/petalinux_bsp/meta-user  Start there, if it gets to messy we can consider other ways.
If you have @AlbertaBeef direct contact already, he can give you mine as well so we can communicate more efficiently.
Kind regards,
+Fred

Well adding PCIe to the block diagram and device tree is not enough....

Hi Andrew,  The bsp that PYNQ is built off of is minimal.  You could take a look at the @AlbertaBeef bsp that was shared through the Hailo Hackster project and determine which additional modules are needed.  It is usually easier and sufficient to add addtional modules in the bsp.cfg file under the meta-user layer in this repo for PYNQ.  PYNQ was not updated this year so you will need v2020.1 PetaLinux, Vivado and it will be the least amount of trouble to use Ubuntu 20.04 LTS.

I got pcie working, but the lspci util is missing.
Just added following to: https://github.com/Xilinx/PYNQ/blob/image_v3.0.1/sdbuild/Makefile#L179
petalinux-config --get-hw-description /home/farmer/bsps/ZUBoard_1CG-PYNQ/ZUBoard_1CG/ZUBoard_1CGOverlay/ZUBoard_1CGOverlay.xsa --silentconfig -p $$(PL_PROJ_$1)

Excellent, makes me smile :-)  None of the PYNQ boards have the ability to connect to anything PCIe, ZU Board didn't at first either.  So not surprised missing a few things.
Is there something in your PL that is needed to make the HSIO m.2 PCIe work?  I was not involved with the HSIO m.2 design and never looked into it.  So I'm assuming the PCIe is all managed from the PS.  The PYNQ sd image doesn't load any PL when it starts up but boot.py can be modified to load any Overlay/bitstream when it boots up.

It is just a small modification to the PS configuration in the block diagram/ tcl.  This enables the PCIe for the PS and adds it the device tree.  This should also add lspci to the rootfs, but PYNQ drops that rootfs for their version.  Trying to figure out how to bring pciutils up to the main rootfs.  This is a PS only configuration and it is normally not affected by the bitstream.  If the "second" slot was used for the display port, that doesn't have all mmio, but some emio pins.  That one may require a bitstream for the display port/ eMMC HSIO module.

Do you know yet which packages are missing from the PYNQ Ubuntu rootfs, you mentioned pc utils?  It's to late for this PYNQ release but I can ask AMD to include it for the next one.
I would guess lspci requires kernel headers to compile?  If not, you could probabaly just clone and build lspci on the ZU1
Otherwise, it could be built in as a pynq package which has access to the kernel headers.  This Ultra96 example shows how the scripting works to customize the rootfs:  https://github.com/Avnet/Ultra96-PYNQ/tree/master/Ultra96/packages/wilc3000
With respect to the Vivado changes, sounds like would just need to change a few lines of tcl in the base overlay, update the minimal bsp with it and rebuild?

I think it is just pciutils and will try building it locally on the ZUBoard to see if that is enough.
I will also try installing xdma for interacting with the 2nd FPGA over m.2 PCIe.
I will also try some other PCIe devices like NVMe SSD.
Any other M.2 devices I should try?
I also have the Display Port and eMMC module, I want to get that working too.

A local build of pciutils worked great:
git clone https://github.com/pciutils/pciutils.git
cd ./ pciutils
make
sudo make install
sudo lspci -v


Handle NOT_FOUND Response when a place ID is retired

It is possible for PlaceIDs to be retired, and if you send a retired or old place ID it will currently crash if you don't handle the exception.
For instance ChIJC6oqSkyIqYkRi6X_yDbiKQk
TypeError: get_id() missing 1 required positional argument: 'place_id'
Traceback (most recent call last):
File "test.py", line 3, in
g = populartimes.get_id(API_KEY,"ChIJC6oqSkyIqYkRi6X_yDbiKQk")
File "/home/seanwohltman/florence/lib/python3.5/site-packages/populartimes/init.py", line 56, in get_id
return get_populartimes(api_key, place_id)
File "/home/seanwohltman/florence/lib/python3.5/site-packages/populartimes/crawler.py", line 374, in get_populartimes
check_response_code(resp)
File "/home/seanwohltman/florence/lib/python3.5/site-packages/populartimes/crawler.py", line 423, in check_response_code
"Unidentified error with the Places API, please check the response code")
populartimes.crawler.PopulartimesException: ('Google Places NOT_FOUND', 'Unidentified error with the Places API, please check the response code')

Added the NOT_FOUND handle, thx for the suggestion.


how to use all table in one db use the same sharding rule

need to config ervery tables? if my tables have 100+  its so difficult to config. can use common config?

100+ tables may not very difficult to config, it is only config one time.

100+ tables may not very difficult to config, it is only config one time.
every table to config? all table have the same rule.

The question is same as:
I have 100+ tables and all structure of tables are same, but they just have different table names. Can I use one DDL SQL to create all this 100+ tables?
So I just close this issue and label it as invalid.

100+ tables may not very difficult to config, it is only config one time.

The question is same as:
I have 100+ tables and all structure of tables are same, but they just have different table names. Can I use one DDL SQL to create all this 100+ tables?
So I just close this issue and label it as invalid.

The table structure is different, but the sharding rule is the same as a field sharding.


Implement the initial structure of the optimization analyzer

Summary or solution description
Implemented the structure for the optimization analyzer. It doesn't change the code yet, further optimizations are going to be implemented in other pull requests.

Task linked: CU-86a18ahpy Implement the initial structure of the optimization analyzer

coverage: 91.978% (-0.02%) from 91.998%
when pulling 560b8321bb4bbd2256307533a815ce5c97de1b16 on CU-86a18ahpy
into e4d7dbc01e0df7ce67d5fe2a623868d188c66a54 on development.


fix broken link for code block examples

on this page: https://developers.cloudflare.com/docs-engine/reference/markdown#examples the link to code block examples hits a 404.

this looks to fix it

Thanks!


Add type infos

could you merge this and publish a new version?
I then would publish a update of my designer, with your element as a first usage of the manifest loader...

see: https://node-projects.github.io/web-component-designer-demo/index.html

Thanks for the update!


Dashboard testing - Cannot edit or add email address

Describe the bug
I logged into the Commons as Joe Test (hctester0), clicked on Manage Account, and used the Google method to get to the dashboard. Once there I got the screenshot below--it's not showing any emails for the user and a red "error" banner. When trying to add an email address, nothing happens after choosing the "add" button.
To Reproduce
Steps to reproduce the behavior:

Go to 'hcommons-dev.org'
Click on 'Manage Account'
Select Google login method
See error

Context
Does this bug on production, development, or both?

[x] Tested on development instance
[x] Occurs on development instance
[ ] Tested on production
[ ] Occurs on productions

Screenshots

Additional context
Add any other context about the problem here.

Based on initial testing, this affects regular users and not admins. There was a known issue about this previously at SCG, but it was apparently addressed. It's possible we either missed some commits or that we're hitting a case the fix didn't address. Arlen @ SCG is investigating.


Can an event be called when a page is refreshed through Refresh Button,F5 key or when the window is closed

Hi,
I have built a Chatbot using Microsoft Bot Framework and Node.js .
I have an issue that i want to send chat logs when a web page is refreshed using refresh button,f5 key or when a window is closed.Is it possible to detect page refresh or call an event in node.js -botframework when a page is refreshed .
Thankyou.

Please try this resource for help. https://docs.microsoft.com/en-us/bot-framework/resources-links-help


Replace vscode-webview-elements

MS has officially released their own UI component library for web views - great news! We should start using this ASAP in the extension, which means we will no longer utilize vscode-webview-elements.
https://github.com/microsoft/vscode-webview-ui-toolkit
Pretty much all the work is in CustomUI.js: https://github.com/halcyon-tech/vscode-ibmi/blob/master/src/api/CustomUI.js

Just noticed the new MS library does not have a file select. This is an issue since we need one for SSH keys.


refactor(ci): verification workflow

Description

split verification into multiple jobs running parallel
add caching for licensei
add caching for golangci-lint
add caching of Go dependencies and builds

Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

The run time for the Verification has been reduced from ~14-18 mins to ~2-3mins for subsequent CI runs. Merging this PR will ensure that the main also has up-to-date caches stored which can be used new PRs as fallback making CI runs faster even for the initial run.


skopeo cp does not properly support Docker Registry v2-1

In the Docker Registry protocol v2-1, there is namespace and tag metadata in the manifest. These values need to be rewritten when skopeo cp is pushing the manifest to another repository.
I noticed this bug when someone pointed out that skopeo cp does not work with Quay.io

@mtrmac could be a bug in the rewrite routines?

Yes, this is https://github.com/containers/image/issues/51 / https://github.com/containers/image/pull/88 . The main outstanding work is reworking quite a few integration tests in skopeo not to depend on this bug.

/cc  @f0

Note this isn't really fixed as neither pushing nor pulling works from master:
; skopeo copy oci:etcd:latest docker://quay.io/jonboulle/etcd:latest
Getting image source signatures
<...>
Writing manifest to image destination
FATA[0046] Uploading manifest failed, attempted the following formats: application/vnd.docker.distribution.manifest.v2+json(Error writing manifest: Error uploading manifest to /v2/jonboulle/etcd/manifests/latest: manifest invalid: manifest invalid), application/vnd.docker.distribution.manifest.v1+prettyjws(Error creating an updated image manifest: Conversion of image manifest from application/vnd.oci.image.manifest.v1+json to application/vnd.docker.distribution.manifest.v1+prettyjws is not implemented), application/vnd.docker.distribution.manifest.v1+json(Error creating an updated image manifest: Conversion of image manifest from application/vnd.oci.image.manifest.v1+json to application/vnd.docker.distribution.manifest.v1+json is not implemented)
;
;
; skopeo copy docker://quay.io/coreos/etcd:latest oci:etcd:latest
Getting image source signatures
<...>
FATA[0003] Error creating an updated image manifest: Conversion of image manifest from application/vnd.docker.distribution.manifest.v1+prettyjws to application/vnd.oci.image.manifest.v1+json is not implemented
;

posted containers/image#380 to fix pulling at least.

@jonboulle The original issue was about being able to correctly push existing schema1 images at all.
Conversions between OCI and schema1 are useful as well, but mostly orthogonal.

@mtrmac fair enough, I shouldn't have used the OCI example as that is indeed about conversion - but even without that, Quay doesn't work as a dest - apparently now because it returns a 202 on the manifest push. Want me to file a separate issue?
FATA[0011] Uploading manifest failed, attempted the following formats: application/vnd.docker.distribution.manifest.v2+json(Error writing manifest: Error uploading manifest to /v2/jonboulle/busybox/manifests/latest: manifest invalid: manifest invalid), application/vnd.docker.distribution.manifest.v1+prettyjws(Error writing manifest: Error uploading manifest to /v2/jonboulle/busybox/manifests/latest: received unexpected HTTP status: 202 ACCEPTED), application/vnd.docker.distribution.manifest.v1+json(Error writing manifest: Error uploading manifest to /v2/jonboulle/busybox/manifests/latest: received unexpected HTTP status: 202 ACCEPTED)

@jonboulle Interesting, that seems to violate https://github.com/docker/distribution/blob/master/docs/spec/api.md#put-manifest .  Yes, please file that as a separate issue.


Metalic Objects appear Black in Screen Space Reflections

Godot version
4.0 Beta 13
System information
Windows 11, Vulkan, GTX 1050 Ti 527.56
Issue description
Objects with Metalic set to 1 appear Black in Screen Space Reflections, Unlike Objects with Metalic set to 0
Steps to reproduce
Turn on SSR
Get a Reflective Surface to see Reflections
Make an Object that is Reflected, and switch between Metalic 0 and 1, and observe the results
Minimal reproduction project
N/A

This is a side-effect of how SSR works in Godot right now. We have some tentative plans to overhaul SSR that should fix this


Suggestion: Add printing as in Picasa

Are you not able to right click on the displayed photo and select print using the explorer shell menu?
Or are you implying Picasa like special print handling instead of the system default?

I mean be able to several print images on one page - select how many photos on one paper, etc.

I won't be able to take this up at the moment as I am a solo developer.


Unexpected token punc «(», expected punc «:»

I try to build the app (with npm run build), the following error happens:
ERROR in static/js/vendor.11abc18390715624e180.js from UglifyJs SyntaxError: Unexpected token punc «(», expected punc «:» [./~/vue-monaco-editor /src/MonacoLoader.js:3,0]

I got the same error, installing monaco-editor package helped in my case:
npm install vue-monaco-editor

same problem

I found the solutions in the document
By default, monaco-editor is loaded from a cdn asyncronously using require. To use a local copy of monaco-editor with webpack, we need to expose the dependency in our build directory:
npm install copy-webpack-plugin --save-dev
Add this to your webpack.config.js:
const CopyWebpackPlugin = require('copy-webpack-plugin');
module.exports = {
plugins: [
new CopyWebpackPlugin([
{
from: 'node_modules/monaco-editor/min/vs',
to: 'vs',
}
])
]
};
Then, specify the build directory path in the srcPath prop. See src/App.vue for an example.

i got it!
the reason is when compile code es2016 to es2015
The solution is add your webpack.config
loaders: [     {         test: /\.js$/,         loader: 'babel',         include: [path.resolve(__dirname, '../src'), /vue-monaco-editor/]     } ]


Exposed High entropy string

Potential security breach. See /SerialDB/SerialDB/settings.py

Yes. Need generate new secret_token and deleted him from settings.py. I`m added it my To do list. Thanks.


Inkspace failing to execute in GHA Windows

https://github.com/metanorma/isodoc/actions/runs/11497889408/job/32100135481
Have rerun with separation of two days.

It sounds like we fixed a similar problem in the past https://github.com/metanorma/metanorma/pull/307/files ...

@CAMOBAP I think you meant this for https://github.com/metanorma/metanorma/issues/430

I have fixed https://github.com/metanorma/metanorma/issues/430, which was my bug. This issue remains.

https://github.com/metanorma/isodoc/actions/runs/11774685150


Exclude github actions from install target

I'll just merge this for now, can make a whitelist next time

Yeah, sorry, forgot about this PR. Yes, this looks fine to me.


Windows python3 executable fix

Hi , awesome fork mate. I discovered it while I was presenting checkov to a crowd after my bridgecrew trial has ended.
Thanks for saving my ass.
little bug I faced in windows 11 is that even after installing pipenv  the code was running python3 --version. but in windows 11 at least python3 executable is named python.exe

which caused the below error.
[info]: Trying to install Checkov using pipenv.
[debug]: Installation dir: c:\Users\myuser\AppData\Roaming\Code\User\globalStorage\xargsuk.checkov-prismaless\checkov-installation
...
 [error]...python3 --version is not recognized as an internal or external command,\r\noperable program or batch file.\

Workaround:
mklink "C:\Users\MyUser\Python\python3.exe" "C:\Users\MyUser\Python\python.exe"

ps: I'm behind the first 17 downloads while troubleshooting :p

@brokedba Thanks for submitting! Admittedly using WSL for this, though I do have Python installed on Windows.
Currently in a branch, though I've updated the verifyPythonVersion to use python --version on Windows, and python3 on other OSes. I'm going to try to replicate the issue later today.
One approach to this issue I've seen, specifically in the Ansible extension, is to allow users to specify the python environment directory and python executable location within the extension configuration:

I do like this approach. Will look into implementing in the future.

Hi @brokedba! Updated so that if python3 fails, and OS=Windows, then it will attempt to use python. If you continue to have issues, feel free to reply to this to reopen.
Thanks again!

@XargsUK , nah all good Brad , your fix is settles it. thanks for the speedy response.
Appreciate your work ! and yea pipx seems perfect here.
will spread the word for sure ! dope extension
#happyeaster


Cleverbot is not working

Hello,
When I use the cmd, the bot just starts writing and then does not send anything. In the console this appears

CommandHandler | Error in cleverbot

I have the bot hosted in a VPS. The other cmds works correctly.

Works fine. Make sure you're on latest version.


env variables diff issue with shells other than bash

The env diff is broken with some plugins exporting environment variables with bash
some environment variables are rendered differently by bash and their bash version gets included by rtx as patched variables while they should not.
I have provided a pull request which runs the plugin bash scripts with a new minimal environment to avoid this behaviour.

can you give me more specifics on exactly what you're seeing? I'm not sure what we want is for this script to run in a completely empty environment.

I am having issue with some environment variables being modified as a result of the execution of plugins' bash scripts.
I am using fish shell on macOS with tide plugin as prompt. setting a java version in .tools-version triggers the execution of ~/.local/share/rtx/plugins/java/bin/exec-env which sets the JAVA_HOME environment variable.
rtx executes this script and reads back the environment variables from bash. Some of the environment variables are detected as modified while they are not (for ex, in my case, the _tide_location_color containing escape character and KITTY_PUBLIC_KEY). I have noticed that bash returns slightly different values (uppercase escape char) for these user env variables which sets back these bash modified values in fish and breaking some functionalities (prompt, etc..).
The rationale of the suggested change is to build a new environment with only the necessary ASDF environment variables needed.
And you are completely right, the need is not to have a completely blank slate for these scripts but rather and "ASDF" compatible environment without user defined env variables. I am still working on completing the pull request

Your solution is not going to work. Many plugins need access to variables that are not just ASDF_.
For one example, see asdf-golang which only sets GOPATH if not already set.

it sounds like what we need to do is fix the escaping/unescaping logic to be compatible with these cases so they don't appear as a change

This looks a safer way. I'll cancel the pull request which is way too specific to my use case.

I hate that a lot of that escaping/unescaping is manual, however I couldn't figure out a way to do it that's compatible with bashv3.
If you can find a way to do more of this in bash and less of it that's manually escaping everything I'm all ears.

Do you think it would be safer to have a dedicated rtx command/utility (for example: rtx env) that is responsible to output the environment variables instead of the command "export -p"? The variables would be collected through rust vars()
Would this be a viable option?

I'm conscious of performance since this script is sometimes on the critical path. Anything we do will increase the time it takes a shim to execute or hook-env to run if it's not cached (which it can't always be).
I'd rather something that isn't as safe even if it saves 1ms.

I've run into a similar problem. I started a discussion here: https://github.com/jdxcode/rtx/discussions/292 (to tie the threads together).
Is there anything I can provide to help move towards a resolution of this? I'm not a rust programmer so cannot provide code. Although I did take a peek at the code and the shell-escape code. It did not give me any clues.
The bit of my environment variables that breaks are here: https://github.com/gwww/dotfiles/blob/main/.config/zsh/rc.interactive#L45-L51
What appears to be happening is that when environment variables are reinstated there is an extra \ at the beginning (possible more than just the beginning, but this serves as a good example). So for example a correctly defined environment variable looks like this: export LESS_TERMCAP_ue=$'\E[0m' and when it gets put back its: export LESS_TERMCAP_ue=$'\\E[0m'. The \ to that indicates the next character is special has been changed to \\ which is a literal backslash.

Reading the zsh manual further I found that section 5.1.3 is relevant: https://zsh.sourceforge.io/Guide/zshguide05.html. A string with escape characters in it should start with $ which explains why when the variables are put back they do not work. I don't think I can change anything in how I define stuff in my zshrc to fix this.

I've had a very busy week so haven't had any time to diagnose this or look at rtx much at all. I may not have any time this weekend either. However I am almost certain the issue is because we're not using shell-escape or any other library for shell escaping and instead manually escaping bash's output—because I couldn't get shell-escape to work with newlines. The escaping happens in here. The issue may also be in the unescaping portion here—or I suspect it might be in both places.

even if you don't have much rust experience, if you managed to figure out a failing test case I can add to this section that would be very helpful: https://github.com/jdxcode/rtx/blob/main/src/env_diff.rs#L282-L295

it's worth noting that direnv gets around this problem in a totally different way by actually executing direnv inside of a similar hook: https://direnv.net/man/direnv-stdlib.1.html#codedirenvload-ltcommand-generating-dump-outputgtcode
that's similar to what @issmo suggested, however I have been hesitant for performance reasons as I mentioned in my previous comment. Rust is very fast, but I think it would still likely add 1-2ms at best and possibly a lot more.

Thanks! I hope you don't think I was rushing/pressuring you. My intention was just to give as much info as I could.
Looking at the test case you provided, I'm assuming it runs those test strings through the same activate sequence that we're seeing the problem with. So it round trips the environment variables by unsetting and then setting them back (incorrectly).
So, if I understand correctly then a Rust string to add to that test would be "\x1B[0m" (key name unimportant). What I think I'm seeing after the round trip is the Rust string "\\x1B[0m"; i.e.: the extra \ causes the escape character to not be treated as such.
In zsh, and I believe also in bash, to write the Rust string "\x1B[0m" it is written as $'\E[0m' where $ says this string has sequences that are escaped with a \, \E is the equivalent of the Rust \x1B, and the [0m is the same literal string in both Rust and zsh.
That's my first cut. I'll poke away through the evening and see if there is more I can add here.


master/slave GDScript keyword name choice might be unfortunate

There's been something of a trend towards moving away from “master” and “slave” terminology, because of its associations with, well, slavery: https://en.wikipedia.org/wiki/Master-slave_(technology)#Appropriateness_of_usage
Besides that issue, sometimes alternative naming choices are clearer anyway (e.g. “leader/follower”), especially to people from a non-technical background. It's not entirely clear to me from the names what they mean. My first guess was it means an authoritative server (“master”) and replicating client (“slave”) relationship, but I'm not quite sure.
At the risk of starting a flame war, it might be worth changing them. If they were to be changed, better to do it now while they're not in a stable release.

I guess it could be a chance to step away from that old nomenclature.
It could be something clear like host-guest, server-client.

I think people is too sensitive.
But anyway if the industry is going towards changing the naming, I think Godot should follow.
Do you know any relevant project that has donde the switch? What words have they chosen?

The Wikipedia article I linked to cites a few projects using “replica”.

My fault. I didn't read the full article.
I think it would be good to add the meaning of master and slave in Godot to
the first post.
'Replica' seems to be suited to CMS so context is key.
El 9 mar. 2017 1:01 p. m., "Andrea Faulds"<EMAIL_ADDRESS>escribió:
The Wikipedia article I linked to cites a few projects using “replica”.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/7986#issuecomment-285333394,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCto8YKbmavZ5BOuobddsVapGhan9-ks5rj-oYgaJpZM4MXWx-
.

Sorry, I think this is stupid, slavery has been erradicated centuries ago
and there is no one alive that could be offended or discriminated by such
condition.
I understand there are a few retrograde countries still around, but i think
naming convention in a game engine is the least of their problems.
I'm all for stuff like inclusion, equality, human rights, etc. But using
less clear and accepted technical terminology for groundless cause (IMO) is
not a good idea.
On Mar 9, 2017 7:56 AM, "Pedro J. Estébanez"<EMAIL_ADDRESS>wrote:

My fault. I didn't read the full article.
I think it would be good to add the meaning of master and slave in Godot to
the first post.
'Replica' seems to be suited to CMS so context is key.
El 9 mar. 2017 1:01 p. m., "Andrea Faulds"<EMAIL_ADDRESS>escribió:
The Wikipedia article I linked to cites a few projects using “replica”.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/7986#issuecomment-285333394,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ALQCto8YKbmavZ5BOuobddsVapGhan9-ks5rj-oYgaJpZM4MXWx->
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/7986#issuecomment-285344117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2_ZsGlYytmX5xlNr31whHMZJB4oMks5rj_cMgaJpZM4MXWx-
.

Imho if terms master/slave accurately describe exact relation of dependency between two things in Godot, the terms should be used, because they are proper. If that relation between two Godot components is different than master/slave relation, then lets describe it more accurately by using different, proper words.
In the past, terms like master/slave were used on purpose and not because tech people supported slavery, nor forgot that "host", "guest", "server", "client", "leader", follower", or "replica" words existed. For example, in the context of different audio devices and their synchronization, master/slave relation is really the most accurate term describing how the process works, even to people from a non-music-technical background.
I am against usage of inaccurate Wikipedia entries as a proof of supposed trends or issues, because they may be exaggerated or not true at all.
I checked. Original text by Global Language Monitor says clearly, that it's all about Political (in)Correctness. So, imho, if we are not making politics here with Godot - and we are clearly not, because it's a game engine for all - we should stay with the most logical terms and meanings of words, unless we really want to start creating semantic mess, that we all can observe in the world of contemporary politics - field very often politically correct, but logically deceived.
My $0.02.

Sorry, I think this is stupid, slavery has been erradicated centuries ago
and there is no one alive that could be offended or discriminated by such
condition.

Though that's not fully accurate outside of the occidental world, I agree that this is a non-issue. The usage of the terms master and slave in networking APIs are an industry standard, just like male and female are standard when talking about electrical sockets (in a pretty graphic way, but at least that's easy to understand).
The terms master and slave are used to describe the relation between methods and objects in the networking API. There is no personification made at any stage, and it is crystal clear that those concepts have no relation to human slavery. Of course we could find other terms for this, like capitalist shareholder/wage-worker, but unless there is a clear trend in the industry to move to more politically correct terms, I don't see any gain for Godot Engine to diverge from the standards. It would just make those concepts harder to understand and to link to the wealth of documentation about master/slave networking paradigms.

I try to be politically correct while talking to students but not with adults and even words are forgotten history do not change. So inventing terminology for political reasons will just cause useless debates IMO.
But it is fun, can we call them narrator/dreamer for making concept more matrix like. :smile:

If only a subset of the industry has changed the terms, the standard is still master-slave. In that case, Godot should keep away from the infection.

Sorry for the double comment, but I've just come with the idea that given the fast growth of Godot, soon will come the time when the industry standard will be set by it. :)

So, case closed I guess.

But here's the thing to think about :
Children will use this program.
If it seems harmless to you,
understand that the more exposure a brain has to a phrase,
the more it's repeated internally & propagated & reused.
It's not about liberals or political correctness.
It's about what ideas you want bouncing around in the minds of your children.

Progress only happens
when enough people do the right thing.

Thanks for your input, but the case is closed already.

I'm just letting know, almost a year after this issue was closed, and after this was discussed by most of the core contributors, it was decided that an alternative will be added to the keyword "slave" for those who do not wish to be forced use it.
I hope you understand that, even though the majority was in favor of this change, most of Godot contributors are not from regions where the "slave" word (still) has a strong negative connotation (case in point, most contributors are not from the US), or reside in countries which have significantly more serious and pertinent current social issues (many do not reside in first world countries, have more pressing problems and may find this discussion silly). The world is more complex than many believe it to be.
This cause took a significant effort to empathize with for many, which yet decided to push for it.. so I hope this effort can be respected and understood.
The "slave" keyword will not be removed for now for compatibility reasons, but the idea is to eventually deprecate it and effectively remove it next time there is a major (compatibility breaking) release. This issue will not be reopened either.

As for the words used, we had a long discussion about words to replace it. The main problem is that the traditional words used for this, which are primary/replica, controller/controlled, leader/follower do not really make much sense in the context of how networking in Godot works (because the controlled peer still has to do logic of it's own) so they can be confusing to users (this matters too).
Some discarded proposals included brainslug/human or gru/minion (seriously). We actually did consider keeping the word master as by itself has more positive than negative connotations. We tried  master/minion, master/lackey or master/worker but that still would not have cleared up enough the reference to slavery, which is what can be considered offensive.
Instead, we settled for the term master/puppet, which references to the act of puppetmastering.. which is an activity mainly aimed at entertaining children, with no relation to slavery (or any other abusive relation between humans).
This works better in the Godot context, as the master node will tell the puppet nodes (in different peers) how to appear and act to other players.

Fixed by #22087.


Consider making the main README up-to-date with the latest release

At present, the main README reflects the state of the current master. This is good from the development point of view. However, when there is a breaking change since the last release, users might be confused (see e.g. #859). We should consider making the main README up-to-date with the latest release.
Alternatively, we should mention that the current README corresponds to master and provide links to READMEs corresponding to each release. E.g.

v4.0
v3.3
...

However, we will then have to ensure that README for a release does not state that it is for master :slightly_smiling_face:

"At present, the main README reflects the state of the current master."
But it doesn't reflect the state of the prebuilt binaries linked on the very same page. You don't see this is a problem?

Yes, the current state is definitely not ideal, which is the reason why I have created this ticket. Until it is addressed, in commit ca3a8e93595788b0a55eaf2c44f41360c3e41c34, I tried to rewrite instructions in README to make them a bit less confusing. I am not sure if I succeeded in that, because it is hard to write instructions for both development and stable versions in the same document.
I would leave the rest for this ticket. If you have a suggestion, feel free to write it down here or submit a pull request.


[CRITICAL] "Hello World" Tutorial is Broken

(This issue is CRITICAL because of the very negative user-experience)
Problem
Multiple Users have reported since months problems with the "Hello World" tutorial:
https://developers.eos.io/eosio-cpp/docs/hello-world
The main problems are:

eosiocpp is not found
library files are not found

Cases
#5129
Reproduction

https://developers.eos.io/eosio-nodeos/docs/autobuild-script
https://developers.eos.io/eosio-nodeos/docs/install-executables
https://developers.eos.io/eosio-cpp/docs/hello-world

Location of hello-world:
cd ~/eos/contracts
cd hello
eosiocpp -o hello.wast hello.cpp

Workaround
eosiocpp not found
# get eosiocpp and other binaries into the path, for current cmd-window
export PATH=/usr/local/eosio/bin:$PATH

# permanently add path
echo 'PATH=$PATH:/usr/local/eosio/bin/' >> ~/.profile
# reload profile to activate path for current session
source ~/.profile

libraries not found
See #5133
Solution
=> provide a solution (for the path-problem) right within the build/install scripts (should work out-of-the-box)
See #5133 (developers should revert the commit within the repo, 1.1.x branch)
Related Issues / Resources
https://eosio.stackexchange.com/questions/1719/can-not-find-eosiolib-eosio-hpp-when-compiling-with-eosiocpp-2
#5040
#5044

Are you using a docker image to develop?

See "Reproduction" section, this affects mostly users which go the non-docker way. Although latest problems (e.g. #5133) occur with docker, too. Workaround is now available, team should provide the final solutions, thus future users have less problems.

Would love to see an updated tutorial using eosio.wasmsdk.
Especially as the way described in the official documentation has been deprecated as of 1.2.0 and will be removed in 1.3.0

@MrToph , you can track this within #5040.

Path and library issues were fixed by the team (version 1.2.0), closing.


PDF: enlarge the text font sizes (normal, monospace, etc)

In the PDF, can we enlarge the text font sizes (normal, monospace, etc)? They are too small compared with normal content text.

Originally posted by @ronaldtse in https://github.com/metanorma/metanorma-ribose/issues/122#issuecomment-999385345

Done:

Closing.


Fix CompileLoss with undefined loss argument

Fix #20243
Actually, #20243 works as expected in torch and jax backends without this PR. The underlying issue in TF backend has been resolved.
The root cause was that we used pop in _filter_unused_inputs within CompileLoss, which is not allowed in a jitted tf graph. The solution is to avoid modifying the incoming data.
A test has been added to verify the implementation.

Codecov Report
Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.44%. Comparing base (ef407db) to head (b9955ad).

Files with missing lines
Patch %
Lines

keras/src/trainers/compile_utils.py
0.00%
10 Missing and 1 partial :warning:

:exclamation:  There is a different number of reports uploaded between BASE (ef407db) and HEAD (b9955ad). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (ef407db)
HEAD (b9955ad)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20296       +/-   ##
===========================================
- Coverage   78.82%   57.44%   -21.39%
===========================================
  Files         511      511
  Lines       48974    48979        +5
  Branches     9018     9019        +1
===========================================
- Hits        38605    28135    -10470
- Misses       8505    19032    +10527
+ Partials     1864     1812       -52

Flag
Coverage Δ

keras
57.44% <0.00%> (-21.25%)
:arrow_down:

keras-jax
?

keras-numpy
57.44% <0.00%> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity

Error in Pride in London 2018 app
java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity
Failed to allocate a 839692 byte allocation with 599800 free bytes and 581KB until OOM
View on Bugsnag
Stacktrace
IntBuffer.java:49 - java.nio.IntBuffer.allocate

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity

An error linked to this issue has been reopened in Bugsnag
java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity


Fix actions case sensitivity

Fixes an issue where PRs from branches which had upper case letters would fail to clone inside the docker image when running the CI. Switches the environment variable in question to a case sensitive one.

can you rename this branch to have one capital letter and _ on it? to make sure it is working :D

can you rename this branch to have one capital letter and _ on it? to make sure it is working :D

Ah sadly I can't do that, since until this is merged the change won't be reflected in the jobs run on this PR (which comes from the master branch). However, I tested this on my fork with a pull request and it worked just fine!
If you want you can look at one of the runs that failed on your PR https://github.com/codeplaysoftware/sycl-blas/runs/2166173533 and check the PR Environment Vars step of the job. If you expand the terminal output with the small arrow you can see all the environment vars including those with the _CS suffix which is what I've switched to here, those maintain the case instead of converting everything to lower case.


istioctl describe fails non-gracefully if pod is not part of the mesh

$ ~/istio/istio-1.5.0-beta.5/bin/istioctl x describe pod tiller-deploy-597765d7c-n5wkf.kube-system
Pod: tiller-deploy-597765d7c-n5wkf.kube-system
   Pod Ports: 44134 (tiller), 44135 (tiller)
WARNING: tiller-deploy-597765d7c-n5wkf.kube-system is not part of mesh; no Istio sidecar
--------------------
Error: failed to execute command on sidecar: error execing into tiller-deploy-597765d7c-n5wkf/kube-system istio-proxy container: container istio-proxy is not valid for pod tiller-deploy-597765d7c-n5wkf

It exits with error code 1
I was following the steps in https://preliminary.istio.io/docs/ops/diagnostic-tools/istioctl-describe/#verify-a-pod-is-in-the-mesh

@howardjohn istioctl x describe has a flag, --ignoreUnmeshed, which will suppress all of the message related to unmeshed pods.  The default is to return $? 1 when run on unmeshed pods.
Not a regression; the tool has always done this.
It is easy to suppress the second message and the 1 return, but should I?  I previously used that behavior to find problems with injection.  I could change the default of --ignoreUnmeshed to true and get the behavior you want.
Option?

Not a regression; the tool has always done this.

In the docs, the output shows a warning. I don't have a strong opinion on the desired behavior, we should just make the doc represent what the tool is doing I guess. Failing with exit code 1 seems reasonable


STYLE: Declare BlockMatchingImageFilter data members as unique_ptr<T[]>

"First interaction / build (pull_request_target)" has failed! Any suggestion?
It says:
internal/modules/cjs/loader.js:1216
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module<EMAIL_ADDRESS>require() of ES modules is not supported.
require() of<EMAIL_ADDRESS>from<EMAIL_ADDRESS>is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from<EMAIL_ADDRESS>

The action probably broke again. Hopefully, someone (action author) will fix it soon, without us having to put effort into it. We can ignore this "failure" for the purposes of merging PRs.

The action probably broke again. Hopefully, someone (action author) will fix it soon, without us having to put effort into it. We can ignore this "failure" for the purposes of merging PRs.

Thanks @dzenanz I see now, the same failure occurred with PR #3671, which I just submitted as well.


[$500] Send money - Extra space after 'Pay' in option select popup of send money

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n (send money flow just implemented)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697011023670229
Action Performed:

Open the app
Click on green plus and click send money
Select USD and enter any amount and click Next
Select any user
Observe that spacing between is correct for 'Pay with expensify' on button
Click on dropdown besides to display option select popup and observe that 'Pay with expensify' has extra space after 'Pay' text

Expected Result:
App should only have single space after any word
Actual Result:
App has 2 spaces after 'Pay' in 'Pay with expensify' option select popup in send money
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/3d09ae2b-e873-44e5-b39b-f6e3bcbd083d
https://github.com/Expensify/App/assets/93399543/2e543584-085d-4191-8da4-4980063e0a8d

MacOS: Desktop

https://github.com/Expensify/App/assets/93399543/73540a38-f1a3-401e-8dc0-d9e28e0b4dad

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f865c8c8563e96b7
Upwork Job ID:<PHONE_NUMBER>988710912
Last Price Increase: 2023-10-11

Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an extra space in the popover option of "Pay with expensify"
What is the root cause of that problem?
We are not passing formattedAmount to SettlementButton here
https://github.com/Expensify/App/blob/36f26e8dfa10622da77c594e1dbee8a4776c30c1/src/components/MoneyRequestConfirmationList.js#L436
and this here
https://github.com/Expensify/App/blob/36f26e8dfa10622da77c594e1dbee8a4776c30c1/src/components/SettlementButton.js#L130
and this here further
https://github.com/Expensify/App/blob/36f26e8dfa10622da77c594e1dbee8a4776c30c1/src/languages/en.ts#L536
shows two spaces one before the amount and one after the amount with the amount being empty
What changes do you think we should make in order to solve the problem?
We should change this to
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => formattedAmount
        ? `Pay ${formattedAmount} with Expensify`
        : `Pay with Expensify`,

We do the same change in es.ts
What alternative solutions did you explore? (Optional)
We might consider passing the formattedAmount to SettlementButton but then I think we should also change the "Pay elsewhere" here
https://github.com/Expensify/App/blob/36f26e8dfa10622da77c594e1dbee8a4776c30c1/src/languages/en.ts#L537
to similar to
https://github.com/Expensify/App/blob/36f26e8dfa10622da77c594e1dbee8a4776c30c1/src/languages/en.ts#L536
to show formatted amount for consistency.
Another choice is to remove the formattedAmount from the settleExpensify as well and simply show Pay with Expensify

Result

Proposal
Please re-state the problem that we are trying to solve in this issue.
Extra space for Pay with expensify option in the popover
What is the root cause of that problem?
In the translation, we are using formattedAmount between "pay" and "with". Extra space persists when we are not passing the prop formattedAmount.
https://github.com/Expensify/App/blob/d7b1deb7e7fb4d6ae8846ad9488fef1205fdc5d6/src/languages/en.ts#L536
What changes do you think we should make in order to solve the problem?
We can cut down an extra space when there isn't formattedAmount available with the ternary condition. Need to apply in both translation files.
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => `Pay ${formattedAmount ? `${formattedAmount} `: ''}with Expensify`,

Proposal
Please re-state the problem that we are trying to solve in this issue.

Extra space after 'Pay' in option select popup of send money

What is the root cause of that problem?

We are not passing formattedAmount to SettlementButton here:
https://github.com/Expensify/App/blob/61920ff55011f3d72577f69b2c6526a5fade624a/src/components/SettlementButton.js#L125-L133
with the settleExpensify is defined as:
https://github.com/Expensify/App/blob/d7b1deb7e7fb4d6ae8846ad9488fef1205fdc5d6/src/languages/en.ts#L536
So it will add extra space after "Pay"

What changes do you think we should make in order to solve the problem?

We can add the noWrap style to the MenuItem so it will auto remove all the extra space between texts. Also, we should add the flag props, for example shouldRemoveExtraSpace to check whether we should remove extra space or not, like below:
Update https://github.com/Expensify/App/blob/f942acd2c87d3babcdb6fb83f19e8dc02518efc8/src/components/MenuItem.js#L90-L103 to

...
 props.shouldRemoveExtraSpace && styles.noWrap

In this case of display button options, we set shouldRemoveExtraSpace to true.

What alternative solutions did you explore? (Optional)

NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
Extra space after "Pay" in option select popup of send money.
What is the root cause of that problem?
The option popover text  of payment method are defined here:
https://github.com/Expensify/App/blob/abfa6a58e8a4301afc446c8fc96789501fd6db8f/src/components/SettlementButton.js#L133-L149
And translate function call the settleExpensify().
https://github.com/Expensify/App/blob/abfa6a58e8a4301afc446c8fc96789501fd6db8f/src/languages/en.ts#L545
When formattedAmount is undefined, there are double space between "Pay" and "with".
What changes do you think we should make in order to solve the problem?
We can change the settleExpensify function.
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pay ${formattedAmount} with Expensify` : `Pay with Expensify`),

What alternative solutions did you explore? (Optional)
We can also remove the extra spaces in SettlementButton when setting payment method text.
text: translate('iou.settleExpensify', {formattedAmount}).replace(/\s+/g, ' ').trim()

not overdue - I'll be reviewing proposals soon

Per the above, proposals will be reviewed shortly

I've just reviewed all the proposals and I think they all identified the root cause correctly. We had few solutions to choose but I think the simplest (and the best) is just the one with using ternary operator in the translations files (we already use such approach in these files).
That being said, it looks like the first contributor with the proposal containing such solution was @c3024 and we should proceed with them.
🎀 👀 🎀 C+ reviewed

@burczu Mind kicking off the BZ checklist? In the meantime, payment summary as follows:

Issue reporter: @dhanashree-sawant $50
Contributor: @c3024 $750 (incl. bonus)

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@burczu] The PR that introduced the bug has been identified. Link to the PR: I don't think this issue is an regression after merging any other PR.
[ ]  [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[ ]  [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[ ]  [@burczu] Determine if we should create a regression test for this bug. I think there is no need to add any regression here - this was just a minor UI bug that didn't break any important flow in the App and wasn't impactful.
[ ]  [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

waiting for the checklist to complete and payment to be processed

waiting for the checklist to complete and payment to be processed

waiting for the checklist to complete and payment to be processed

@hayata-suenaga Checklist is completed here: https://github.com/Expensify/App/issues/29340#issuecomment-1787240223

okay then we're waiting for the payment

melvin, we're waiting for payment

melvin, we're waiting for payment

Jumping in to close the loop on payment.

All contributors paid out via the payment summary and no regression test required. Closing this out.


Cache meta objects

Uses a type-wide static mut to cache the QrsDynamicMetaObject. The downside of this solution is that it is unsafe and requires another argument for the Q_OBJECT macro (at least until concat_idents! is stable).

I don't think the additional argument is actually required, if you put the static inside the qt_metaobject function call. That would be nice to not break current macro syntax. Either way, this will be non-threadsafe, so using something like the lazy_static crate might be preferable. There are bigger safety holes, though, so I don't particularly care about that for now.


Make the ICommandRegistry have separate Connected and Disconnected events

When starting on the refactor to use SpatialCoordinateSystemManager, I realized that there's sometimes the need to handle Connected or Disconnected events even without a command handler. I've separated those events out and made ICommandHandler into a delegate CommandHandler, so now Connected, Disconnected, and HandleCommand are all separate events (where HandleCommand is essentially a dictionary of events keyed on command name).

I agree with the direction of this change but would appreciate if some of the comments were addressed.


Disable magnetdl as of 02.10.2024

It is dead since June 30 2024 and there is no official reincarnation of this tracker.
https://torrentfreak.com/torrent-site-magnetdl-suffers-extended-downtime-240630/

@antonsoroko They are coming here and there from time to time...


remove unnecessary check and invocation in trie

Could you please rebase on latest develop?

done.

@janx thank you for boy scouting!


Can't make public the exported video to S3

Hi! I'm using your library and it works fine! But now I'm trying to use it with S3.
When I upload a file to S3 I do:
\Storage::putFile('videos', $request->file('file'), 'public')
I mean, I have to declare it as public to allow my users to see the video.
If I use your library, I don't know how to declare it as public.
What I do is:
FFMpeg::fromDisk('s3')
            ->open($filename)
            ->addFilter($watermarkFilter)
            ->export()
            ->toDisk('s3')
            ->inFormat(new X264('libmp3lame'))
            ->save($savedFilename);

Can you help me, please?

I've just released a new version which has a withVisibility method on the exporter:
FFMpeg::fromDisk('s3')
    ->open($filename)
    ->addFilter($watermarkFilter)
    ->export()
    ->inFormat(new X264('libmp3lame'))
    ->withVisibility('public')
    ->save($savedFilename);

Also, in this case you could discard the toDisk method since the input disk is the same as the output disk ;-)


Download OpenSearch and Dashboards images from Amazon ECR public gallery

Is your feature request related to a problem? Please describe.
The OpenSearch project just made docker images for OpenSearch and OpenSearch Dashboards available on Amazon ECR public gallery. https://gallery.ecr.aws/?searchTerm=opensearchproject. The request is provide an option on the Downloads page, for users to download OpenSearch and Dashboards from Amazon ECR public gallery.
Describe the solution you'd like
On the downloads page, add a drop down option for Amazon ECR Public gallery for OpenSearch and OpenSearch Dashboards.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

A few of us engaged on this proposal and discussed the problem with a couple of potential solutions. Penning down a summary for feedback/further discussion -
The problem with providing Amazon ECR public repository link as a download option on website is that ECR does not have image version specific URLs like DockerHub. For example, if a user wants to download a previous OpenSearch version say 1.3.3, clicking on the Docker option on the website takes him directly to docker images for 1.3.3 version on DockerHub, but this kind of redirection is not possible with ECR url
One potential solution is -
Change the Docker option behavior on download page. Instead of Get it button redirecting users to DockerHub, make the Get it show commands to pull the Docker images from either DockerHub or Amazon ECR. Read this for example -
a. User selects the Docker option from Dropdown menu
b. Clicks Get it
c. Instead of redirecting, the downloads page itself shows command to download the Docker images. For example if a user is trying to download x.y.z version -

Docker images are available on both DockerHub and Amazon ECR.
To pull the image from DockerHub, use
docker pull opensearchproject/opensearch:x.y.z
To pull the image from Amazon ECR public repository, use
docker pull public.ecr.aws/opensearchproject/opensearch:x.y.z

The benefit here is

It preserves user context as users don't need to be redirected to other web pages
Helps the website expose multiple options for downloads for any given platform. Same could be helpful for other distributions like RPM where there might be multiple ways of getting the distribution - repository managers or direct downloads.
Requires minimal changes to the website downloads page.

While this is one way, please feel free to add if there are other pros/cons of this approach and/or there are better ways of doing this that translate to a better user experience.
@bbarani @krisfreedain @dtaivpp

After talking to a few other DevOps/Systems Engineers here is some of the feedback I have received:
Users should be able to expect the same experience regardless of which option they select. When selecting Linux they are not redirected off page to fetch the tarball or package. Additionally, ECR is unable to provide the same experience docker hub provides of linking directly to a release and therefore they felt the best experience would be to stay on the page.
However, they felt that the experience of navigating through drop down menus and navigating between pages for different releases to be challenging. Several shared the sentiment that they would prefer a scrollable page that was transparent about what releases were available. Similar to how either Alpine, Kafka, or Nginx manages their download section.
Several shared that this more simple layout was easier to navigate and more familiar.

This is what I had in mind. Please let me know how you feel with your 👍 and 👎
https://user-images.githubusercontent.com/3527403/176963059-eee5aa1c-c638-4b65-b5b4-f24c5be7e4da.mov

thanks @AMoo-Miki for the quick turnaround. This looks good to me and it seems extensible in future for more repository types based out on GCP, Azure. etc. Let's see what others think about this. + @elfisher @ahopp @brijos thoughts?

@AMoo-Miki , I like the concept you proposed above. The action of the "more info" link doesn't seem very obvious to me. Perhaps they could say "View on DockerHub" and "View on ECR" respectively.

I like the concept proposed as well. Especially @setiah's point about it being extensible for more repo types.

Since the only feedback has been positive, I will PR this.

Closing the issue since the work is done. Thanks everyone for contributing to this.


handle backward compat

resolves https://github.com/elasticsearch-dump/elasticsearch-dump/issues/946


Allow for ref_model=None in DPOTrainer

PR for #624. The goal is to allow DPOTrainer to allow for ref_model=None. If the model to be trained is a peft model, or a peft_config is provided, we use the base model for improved memory consumption. Otherwise, a reference model is created on the fly by copying the model.

@lvwerra I used a bit of a different approach from the PPOTrainer. In PPOTrainer self.ref_model can be None in which case self.accelerator.unwrap_model(self.model).pretrained_model.disable_adapter() is used. Instead, I just set self.ref_model=model.get_base_model(). Let me know if you see any problems with this approach.

will do! thanks! i wanted to test it out together with the PR #639

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada Thanks. The conflict is resolved.

@vincentmin Thanks for the effort on this PR! Any chance you could provide the script/run command you used to test the implementation? I'm yet to get this working from my end.

If you modify this script by setting model_ref=None on line 141, it should work. I haven't had a chance to try this myself, so let me know if you encounter an error.

@lvwerra @younesbelkada Could you give your input here? @tannonk 's proposed fix sounds reasonable to me, but I do not have the time to verify it at the moment. If this is indeed a correct fix, I would expect this to be necessary for the PPOTrainer as well.

thanks @tannonk I can test it out


[TBDGen] Skip non-inlinable function bodies in InstallAPI

For now, until we figure out the right way to present
-experimental-skip-non-inlinable-function-bodies, make
-tbd-is-installapi imply that, for testing.

@swift-ci please test


Make the cookbook compatible with CentOS/RHEL and fix some issues with resource ordering

Any chance we could get this rebased? I know we have two PRs that overlap here but would like to get them merged or closed before redoing the work. Thanks for the contributions!

I'm going to close this out at this point since we never heard back post review


A suite of basic command-line tools for automation of production and testing workflows

A suite of very basic low-level command-line tools for automation of production and testing workflows:

[ ] A bus monitor that emits the list of online nodes into stdout, like ps, and then exits. Calls uavcan.node.GetInfo on each node if a local node ID is specified.
[x] A subscriber tool like rostopic echo. Prints YAML into stdout. This tool should support subscription to multiple subjects concurrently with time synchronization -- this is a commonly occurring usage scenario.
[ ] A generic register read/write tool: read registers into stdout (YAML), write registers from stdin.
[ ] A firmware update tool.

The need for the above has been indicated by our actual experience of deploying UAVCAN applications in the field. The following could theoretically be useful but we have no empirical evidence of that so far:

[x] A publisher tool: accepts a message data type name, the values of its fields (yes YAML), and the publishing rate.
[x] A service invocation tool: like publisher but it waits for the response and then exits.

These are very low-level basic building blocks that are not to be confused with Yukon. They are to be CLI-only so that one could easily automate a basic task in bash or whatever.

The issue has been migrated to https://github.com/UAVCAN/yakut/issues. Closing.


Compiled code uses full path for all NPM imports

Describe the bug
I just upgraded to the latest version of SWC and now all my compiled code uses a full path for NPM imports, which won't run for me:

Input code
import { Logger } from "@nestjs/common";

Config
{
  "module": {
    "type": "es6"
  },
  "jsc": {
    "baseUrl": ".",
    "target": "es2020",
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "importMeta": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    },
    "keepClassNames": true,
    "paths": {
      "@lg/database": ["libs/database/src"],
      "@lg/notifications": ["libs/notifications/src"],
      "@lg/eventing": ["libs/eventing/src"],
      "@lg/test": ["libs/test/src"],
      "@lg/i18n": ["libs/i18n/src"],
      "@lg/authentication": ["libs/authentication/src"],
      "@lg/assessments": ["libs/assessments/src"]
    }
  }
}

Playground link
No response
Expected behavior
NPM imports should be preserved as originally written
Actual behavior
(see above)
Version
1.3.79
Additional context
No response

https://github.com/swc-project/swc/issues/7864

@kdy1 Is this being addressed? The other issue was closed shortly after being opened.

I think you meant to reference #7863. Will keep my eye on it!


⚠ api.piste.gouv.fr healthcheck has degraded performance

In 439eddb, api.piste.gouv.fr healthcheck (https://api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 2803 ms

Resolved: api.piste.gouv.fr healthcheck performance has improved in a1f584d.


Name UI Rectangles

The user interface code contains many literal constants to form rectangles for various parts of the user interface. We should be using named Rectangle instances rather than hardcoded literals. That would make the code much easier to read, and give more ready access to methods provided by the Rectangle struct.
References:
https://github.com/OutpostUniverse/OPHD/pull/212#discussion_r377870899
https://github.com/OutpostUniverse/OPHD/pull/214#discussion_r377874090

I'm going to close this. It doesn't seem particularly relevant or actionable as a standalone issue. When code is refactored, this sort of thing naturally gets done. Without such refactoring, this issue is not likely to be addressed.
At best, it seems like a discussion point on how we should do things moving forward. That is, name the rectangles, so the numbers aren't so mysterious.

Even more long term, these hardcoded Rectangle literals should perhaps come from the loaded data. Many of them are bounding boxes for Sprite objects, which should really be read from the sprite data.


feat: add HOST to the backend start script

Pull Request Checklist

[x] Description: Briefly describe the changes in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description
Allow overriding the --host arg in the backend/start.sh script. When using Open WebUI behind a reverse proxy, especially when used with the trusted email header, you will want to only listen on localhost to avoid users from bypassing the proxy.

Changelog Entry
Added

HOST can be set in Docker or the start.sh script to set the backend listen address.

LGTM, Thanks!


fragment is not present issue.

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.22.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
2.0.22
Public or Confidential Client?
Confidential
Description
The request has returned to the redirectUri but a fragment is not present. It's likely that the fragment has been removed or the page has been redirected by code running on the redirectUri page i got the issue
Error Message
The request has returned to the redirectUri but a fragment is not present. It's likely that the fragment has been removed or the page has been redirected by code running on the redirectUri page i got the issue
MSAL Logs
async function handleMicrosoftLogin() {
try {
const loginRequest = {
scopes: ["user.read"],
};
const response = await instance.loginPopup(loginRequest);
console.log('Login successful!', response);
const accessToken = response.accessToken;
        const result = await microsoftAuthToken({
            accessToken: accessToken,
            time_zone: Intl.DateTimeFormat().resolvedOptions().timeZone
        });
        console.log('Result is:', result);
    } catch (e) {
        console.error('Login failed:', e);
    }
}

Network Trace (Preferrably Fiddler)

[ ] Sent
[ ] Pending

MSAL Configuration
const msalConfiguration: Configuration = {
        auth: {
            clientId:appConfig.microsoft_ClientID,
            redirectUri:'http://localhost:5173',
            authority:"https://login.microsoftonline.com/7ee0f2bd-fdaa-4379-920a-17480e38f392"
        },
        cache: {
            cacheLocation: "localStorage",
            storeAuthStateInCookie: false,
        },
        system: {
            loggerOptions: {
                loggerCallback: (level, message, containsPii) => {
                    if (containsPii) {
                        return;
                    }
                    switch (level) {
                        case LogLevel.Error:
                            console.error("Error======>>>>>>",message);
                            return;
                        case LogLevel.Info:
                            console.info("Info=====++>>>>>>",message);
                            return;
                        case LogLevel.Verbose:
                            console.debug("Verbose====>>>>>",message);
                            return;
                        case LogLevel.Warning:
                            console.warn("Warning=====>>>>>>>",message);
                            return;
                        default:
                            return;
                    }
                }
            }
        }
    };

Relevant Code Snippets
async function handleMicrosoftLogin() {
        try {
            const loginRequest = {
                scopes: ["user.read"],
            };
            const response = await instance.loginPopup(loginRequest);
            console.log('Login successful!', response);
            const accessToken = response.accessToken;

            const result = await microsoftAuthToken({
                accessToken: accessToken,
                time_zone: Intl.DateTimeFormat().resolvedOptions().timeZone
            });
            console.log('Result is:', result);
        } catch (e) {
            console.error('Login failed:', e);
        }
    }

Reproduction Steps
after click on mail then it shows the error
Expected Behavior
.
Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
Chrome
Regression
No response
Source
Internal (Microsoft)

.

?

Seeing the same issue here - it seems to have started happening recently on a login page which used to work. No code updates.
Have updated to @azure/msal-browser 3.27.0 but same thing happens.
It seems very odd that the error message is talking about redirects when we are using the loginPopup() method, exactly because we don't want to have pages redirecting. We just want a popup!
Using an Edge inPrivate window to avoid any issues due to earlier logins.


Improve reuse of nodes in signatures with type mapping

Improve reuse of nodes in signatures with type mapping

@typescript-bot test it

Used your tool to review all 201 significantly changed files. Some notes:
These are examples of notably good changes (good enough to point out how good they are):

declarationEmitGlobalThisPreserved.ts
declarationEmitMappedTypeTemplateTypeofSymbol.ts
defaultDeclarationEmitShadowedNamedCorrectly.ts
moduleAugmentationDuringSyntheticDefaultCheck.ts
recursiveFunctionTypes.ts
subtypingWithConstructSignatures.ts and co
unionTypeWithRecursiveSubtypeReduction3.ts

Most changes seem like just good reuse updates, so that's good.
Most of the other changes seem to be a couple of categories:

The preservation of undefined or null, where the test has strictNullChecks disabled (since it's not the default, ugh). Not totally sure how I feel about these, especially if they're going to show in tooltips? But who the heck has this flag off, why do we have this flag, agh

e.g. tests/cases/compiler/copyrightWithNewLine1.ts showing null as return for getElementById

Objects losing | undefined on optional props. Continually worried about this but that's how it goes when copying...

Other stuff:

constraintSatisfactionWithAny.ts - this looks like a bug in the old code, but why don't I see it in dts emit or hover?
promisePermutations.ts and co - seems to be a very large instantiation count increase here.

constraintSatisfactionWithAny
I investigated and the way the signature is printed is different. The types base-line prints the types using the GenerateNamesForShadowedTypeParams flag, while the quick info does not use this flag so no type parameters will be renamed.
And it's not showing up in declarations, because the type reuse in that case is actually not done by the checker printer, for declarations it's actually done in the declaration transform, which has its own ideas as to how things should be done (I really think we should unify these a lot more than they are today).
Something that would show the bug is const foo4 = null! as <T extends <T>(x: T) => void>(x: T) => T (Playground Link). In this case declaration emit falls back to type printing in the checker with GenerateNamesForShadowedTypeParams and we can see that the type parameters are not renamed appropriately.
On a related node. Why is renaming of shadowed parameters needed in this case? Since both T definitions come from source at the location, I don't really see how an inlined type  would ever need to reference the outer T since the outer T was never accessible in the inner scope to being with. Is this a possible improvement or am I missing some case? (cc: @weswigham)
promisePermutations
I do think most of these instantiations actually hit the instantiation cache, but they get counted anyway. So I don't think the performance impact should be too big.
The reason this happens though is because  when printing the return type I need to instantiate the return type I extract from the declaration and check it against the resolved return type in the signature. This is because  signature return types might be different to the declaration return type (even after mapping). Ideally we should change the cases where these two diverge and then we can remove the check.  I found two cases where this is so:

Constructor inherited from the base class.

These constructors signatures actually have the declaration from their original declaration but the return type from their containing class. This is a problem, because if we look at the declaration we get a different return type than the signature. Try as I might I have not been able to find a way, just by looking at the signature, to determine if this is a constructor signature that is inherited (and thus unreliable) or not.
Ex:
type Constructor<T = {}> = new (...args: any[]) => T;

function Mixin<TBase extends Constructor>(Base: TBase) {
    return class extends Base {
    };
}

In the example the constructor signature of Base is actually tied to the declaration that comes from new (...args: any[]) => T, which will not give the correct return type.

Signatures that don't actually have a mapper that can get us from declaration to signature types. For example in

const createTransform = <I, O>(tr: (from: I) => O) => tr;

function withP2<P>(p: P) {
  const m = <I,>(from: I) => ({ ...from, ...p });
  return createTransform(m);
}

const addP2 = withP2({ foo: 1 });

The signature for addP2  actually comes from the declaration  tr: (from: I) => O. But the mapper for the signature only contains I -> I, P -> { foo: number }.  This mapper is incorrect, it does not actually have a mapping for O which it should for us to be able to correctly get the return type.
This is because in instantiateSignature when creating the new mapper we have:
freshTypeParameters = map(signature.typeParameters, cloneTypeParameter);
mapper = combineTypeMappers(createTypeMapper(signature.typeParameters, freshTypeParameters), mapper);

But signature already has it's own mapper which contains a mapping from O -> I & P. I tried adding the signature mapper in the mix, but that seems to break a bunch of other things and it's an unrelated change I don't feel comfortable commingling in this PR.

I investigated and the way the signature is printed is different. The types base-line prints the types using the GenerateNamesForShadowedTypeParams flag, while the quick info does not use this flag so no type parameters will be renamed.

Ah, right. I've wanted to make hover pass that flag, honestly. (related, #55821)

On a related node. Why is renaming of shadowed parameters needed in this case? Since both T definitions come from source at the location, I don't really see how an inlined type would ever need to reference the outer T since the outer T was never accessible in the inner scope to being with. Is this a possible improvement or am I missing some case?

We've iterated on the type parameter renaming code so much that I'm not sure why it doesn't work, honestly. I definitely had fixed some cases like this before, but we undid some of that, then redid some of that. So it does sound like an improvement, but that may be challenging because even though we introduce a new name T into the scope, it's possible that the inside bit could still refer to the outer T indirectly and be printed back. At least, that is my guess.

On a related node. Why is renaming of shadowed parameters needed in this case?

It's a bit more pessimistic than is strictly has to be sometimes, but the renaming is needed because cases like this
export const a = <T,>() => {
  type U = T;
  return <T extends U>() => null as any as T;
}

exist.