Resolves #33 Add MINIKUBE_HOME configuration

This is second try of making extension follows actual MINIKUBE_HOME instead of default.
Previous context

But why did you change the name of the creation fields?

Oh, sorry, didn't notice that it was in commit. Revert this unintended changes.

But why did you change the name of the creation fields?

Oh, sorry, didn't notice that it was in commit. Revert this unintended changes.

Thank you @Tony-Sol . It looks like you also pushed your yarn.lock but as you didn't add any deps this should not change. Can you revert it? Thank

But why did you change the name of the creation fields?

Oh, sorry, didn't notice that it was in commit. Revert this unintended changes.

Thank you @Tony-Sol . It looks like you also pushed your yarn.lock but as you didn't add any deps this should not change. Can you revert it? Thank

Done ^_^

just syncing with upstream

@benoitf may i ask you for review pls?

@tony-sol Can you please rebase? Seems like we got conflicts there and CI is not passing...

@tony-sol Can you please rebase? Seems like we got conflicts there and CI is not passing...

@odockal check pls

@tony-sol
error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
``` Seems like your yarn.lock is out of date.

@tony-sol can you remote yarn.lock from this PR as it should not be updated

@tony-sol can you remote yarn.lock from this PR as it should not be updated

done

Thanks for this, @tony-sol


auto install latest yodapy in JHub notebook

See the question I placed on "Implications" on the yodapy main README after the "how to install" sections: Is it worth putting an install-latest command in a .cshrc of a Jupyter notebook pod?

I don't quite get what you are trying to do here? Install yodapy in a jupyterhub user space, and make sure it stays around when that user space is shutdown?

yeah; which it won't unless you just re-install it next time you start up :)

If you have access to the underlying environment yaml for the JHub, you can always install it there if you need this package all the time.

Sure; I have in mind more the scientist who is a "customer" of the JHub; who does not necessarily want to get caught up in the mechanics of the service but who does want to have access to the latest and greatest yodapy; but without having to "remember to install" every time they log in. This could also be an Issue for the pangeo gang; i.e. don't feel obliged to solve it :)

Ok let me go for a "wha???" situation here... Let me know if this should be a new issue. I am trying to get yodapy working in my local conda world on a Windows machine from pip install to import yodapy. The import produces an arcane error.
Details:

Install Anaconda on a Windows machine
From the Anaconda (Windows) shell run jupyter lab
From the Jupyter lab Terminal run pip install yodapy
From a new Python 3 notebook in this Jupyter lab run import yodapy

Produces this error:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-f64d6c3c5dd1> in <module>
----> 1 import yodapy

~\Anaconda3\lib\site-packages\yodapy\__init__.py in <module>
      6 )
      7
----> 8 from yodapy import datasources
      9
     10 from ._version import get_versions

~\Anaconda3\lib\site-packages\yodapy\datasources\__init__.py in <module>
      8 )
      9
---> 10 from yodapy.datasources.ooi.CAVA import CAVA
     11 from yodapy.datasources.ooi.OOI import OOI  # noqa

~\Anaconda3\lib\site-packages\yodapy\datasources\ooi\__init__.py in <module>
----> 1 from yodapy.datasources.ooi.OOI import OOI

~\Anaconda3\lib\site-packages\yodapy\datasources\ooi\OOI.py in <module>
     24
     25 from yodapy.datasources.ooi.CAVA import CAVA
---> 26 from yodapy.datasources.ooi.helpers import set_thread
     27 from yodapy.utils.conn import (
     28     download_url,

~\Anaconda3\lib\site-packages\yodapy\datasources\ooi\helpers.py in <module>
     18 import xarray as xr
     19
---> 20 from yodapy.utils.conn import requests_retry_session
     21 from yodapy.utils.parser import get_nc_urls
     22

~\Anaconda3\lib\site-packages\yodapy\utils\conn.py in <module>
     33     from echopype.model import EchoData
     34 else:
---> 35     from echopype.model import EchoDataEK60 as EchoData
     36
     37 logger = logging.getLogger(__name__)

ImportError: cannot import name 'EchoDataEK60' from 'echopype.model' (C:\Users\kilro\Anaconda3\lib\site-packages\echopype\model\__init__.py)

Did you install from the master build?

From your command above it appears that you didn't. Echopype got update recently, and I recently updated this dependency but haven't made a release.

wicked! Let me try the direct install... will report back!


stop trimming trailing / on files

regression in #660 to fix #456 applied to urlpath in addition to filepath, when it should only have applied to filepath
Trailing / on a urlpath can be important to routing, so we shouldn't strip it. If there is an error with a urlpath that doesn't work, it is not the responsibility of Binder to fix it.
closes https://github.com/jupyterhub/mybinder.org-deploy/issues/731

Nice!
Should we add a test to stop this from coming back?

It's pure js and we don't have js-in-the-browser test scaffolding yet. So yes, we definitely should, but it's a bigger job than "just add a test".


TypeError from upgrade (v4)

In upgrading material v3.9.3 to v4.0.0 a TypeError happens. The error happens only in v<IP_ADDRESS>. The error implies that it's the useRefract function, but the error doesn't happen in v3.9.3.
TypeError: You provided an invalid object where a stream was expected.
You can provide an Observable, Promise, Array, or Iterable.
    at Object.exports.subscribeTo (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:64720)
    at Object.from (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:66123)
    at data (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:63701)
    at createComponent (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:63702)
    at configureHook (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:63947)
    at modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:63979
    at mountMemo (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:48850)
    at Object.useMemo (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:49059)
    at Object.useMemo (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:2645)
    at useRefract (modules.js?hash=0c1c0a6460913c856cbe6c37e5c1600b8fa8d9c0:63978)

Tech
Version

Material-UI
v3.9.3

Can you provide a minimal reproduction? I would be surprised if Material-UI is directly causing this.

It's only the upgrade to v4.0.0. The useRefract function is from refract. https://refract.js.org/
When upgrading the icons and styles, there isn't an issue. When going back to v3.9.3, the issue stops.
When commenting out the useRefract function after upgrading to v4.0.0, the issue stops.

It's only the upgrade to v4.0.0. The useRefract function is from refract. https://refract.js.org/
When upgrading the icons and styles, there isn't an issue. When going back to v3.9.3, the issue stops.
When commenting out the useRefract function after upgrading to v4.0.0, the issue stops.

@jwentwistle Please provide a minimal example that fails. Either via codesandbox or a standalone github repository.

Okay. The code that doesn't work is here:
https://gitlab.com/jwentwistle/chaos/blob/master/imports/ui/discussions/discussions.js
Thank you for your help.

@jwentwistle Could you make a isolated repository? Try to reduce it as much as possible so that only react and material-ui dependencies are used.

It's an error that happens in that project. I don't think I can isolate it without making a separate project and I can't upgrade to the latest version because of the error. I think it has to do with refract interacting with material, but I don't know.

There isn't a fix for that issue?

There isn't a fix for that issue?

Since this issue does not originate nor surfaces in material-ui code and we have no reproduction we won't actively work on it.


fix: use correct mcu assignment based on mcu variant

Closed with reason: This repository should not be flooded with pin configuration files for all mcu types. limit it to nucleo based boards.


Hydrogen improvements kerosene

This PR adds flexible synthetic kerosine to the model. Goes together with ETSource 3042
This flexibility option is based on the electricity price and is an addition to the power, hydrogen & Co2 modelling.
The components that have been added are:

Split up of the old synthetic kerosene slider into a baseload (in PJ) and a dispatchable (in MWe-input) slider.
Addition of a WTP slider for the dispatchable kerosene production.
Addition of the flexible component to the relevant flexible power graphs.
Refinement of the graphs where needed.

In addition, a description to the chart " Cost of hydrogen production per hour" has been added in both Dutch and English

What kind of capacity are we talking about here? I cannot find it in the slider description. I would update the slider description and the header of the slider to indicate what capacity this slider sets.

The slide text here seems a bit short:

I would at least expect a link to the CCUS section.


Fix asRole() for VelenOption

asRole() is using a regex to retrieve a channel mention instead of the role, causing the function to return empty optionals when used on Role options.

Thanks for the PR, it's now merged. 👍


[9.x] Fix Job delay property when dispatched through facade + data_get() closure fix

Fix for https://github.com/laravel/framework/issues/46568 and an improvement for https://github.com/laravel/framework/pull/46505.
This also includes a helpful improvement for the data_get() global helper, since for PHP 8.0, trying to access properties on a closure (closures are still is_object()) will cause it to error. This PR makes it so that when you now call data_get($closure, 'someProperty'), it will return null (or some other default).
Sadly I couldn't make any tests for the enqueueUsing method to test the correct $delay property, since the method calls a closure further on within the function which is different for each and every Queue driver.

Have you tested that this PR? The enqueueUsing method passes down the delay to the callback, but it seems to me like the callback doesn't actually use that argument, so I have a feeling this fix doesn't work.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


ArteTV: Video not available error on working video

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Europe
Description
This URL fails with yt-dlp, but works in a browser: https://www.arte.tv/en/videos/108769-000-A/
Most other videos from Arte work fine.
Verbose log
$ yt-dlp -vU https://www.arte.tv/en/videos/108769-000-A/
[debug] Command-line config: ['-vU', 'https://www.arte.tv/en/videos/108769-000-A/']
[debug] User config "/home/tpikonen/.config/yt-dlp/config": ['--sponsorblock-mark', 'all']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.04.08 [7884ade65] (source)
[debug] Lazy loading extractors is disabled
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Git HEAD: cda1bc519
[debug] Python version 3.9.12 (CPython 64bit) - Linux-5.16.0-6-amd64-x86_64-with-glibc2.33
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 4.4.1-3 (setts), ffprobe 4.4.1-3
[debug] Optional libraries: brotli, certifi, Cryptodome, sqlite
[debug] Proxy map: {}
Latest version: 2022.04.08, Current version: 2022.04.08
yt-dlp is up to date (2022.04.08)
[debug] [ArteTV] Extracting URL: https://www.arte.tv/en/videos/108769-000-A/
[ArteTV] 108769-000-A: Downloading JSON metadata
ERROR: [ArteTV] 108769-000-A: Video 108769-000-A is not available
  File "/home/tpikonen/src/yt-dlp/git-yt-dlp/yt_dlp/extractor/common.py", line 634, in extract
    ie_result = self._real_extract(url)
  File "/home/tpikonen/src/yt-dlp/git-yt-dlp/yt_dlp/extractor/arte.py", line 66, in _real_extract
    raise ExtractorError(error, expected=True)

#3302 extracts it fine.

https://github.com/yt-dlp/yt-dlp/issues/3622#issuecomment-1116756526


Add list all tags

Summary of changes:

Delete TaskListParser.java (an unused copy of HarmoniaParser.java, which is being used instead)
Add list all tags functionality

Create a TagList to store the unique tags in Harmonia, list is initialised upon start up.
Create ListCommandParser to parse list commands

commands need to be strictly 'list' or 'list t/' for it to be a valid list command. Any extraneous parameters will result in an invalid list command.

Modify ListCommand::execute to return respective CommandResult based on type of list command
Add getTagList method in Model and ModelManager
Each time a task is added/deleted/edited in Harmonia, the TagList will also be updated.

Update HarmoniaParserTest

Codecov Report

Merging #196 (41e249d) into master (5e7cf38) will decrease coverage by 10.32%.
The diff coverage is 44.92%.

@@              Coverage Diff              @@
##             master     #196       +/-   ##
=============================================
- Coverage     61.20%   50.88%   -10.33%
+ Complexity      378      365       -13
=============================================
  Files            77       81        +4
  Lines          1392     1590      +198
  Branches        150      189       +39
=============================================
- Hits            852      809       -43
- Misses          468      695      +227
- Partials         72       86       +14

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

src/main/java/seedu/address/model/tag/Tag.java
63.63% <0.00%> (-16.37%)
:arrow_down:

...java/seedu/address/logic/commands/ListCommand.java
20.00% <21.05%> (-5.00%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
76.36% <40.00%> (-9.64%)
:arrow_down:

src/main/java/seedu/address/model/TagList.java
52.77% <52.77%> (ø)

.../seedu/address/logic/parser/ListCommandParser.java
71.42% <71.42%> (ø)

...ava/seedu/address/logic/parser/HarmoniaParser.java
84.21% <100.00%> (-15.79%)
:arrow_down:

...java/seedu/address/logic/commands/MarkCommand.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/seedu/address/logic/commands/UnmarkCommand.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../seedu/address/logic/parser/MarkCommandParser.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7cf38...41e249d. Read the comment docs.


Makes headings in documentation consistent

This PR makes the headings of the documentation site more consistent, mostly by changing the capitalization (following the documentation style guidelines).
I manually walked through all the files and checked all the headings, so hopefully I tackled all inconsistencies :sweat_smile:
I skipped the older API references (I only did v1.9) and man pages, but I did update mkdocs.yml.
Fixes #10673.
If I missed something, or if I made some other mistake, please let me know and I'll fix it ASAP :blush:

Oh, that's an awesome job! :heart: couple of nice catches as well (eg the "Using Chef" pagetitle).
Even in case you missed some; I think these are a great enhancement.
Two things that may need checking apt-cacher-ng and cgroups, to see if they should be all lowercase.
LGTM, but @moxiegirl will need to check if there are some special cases.
Bedankt!

very awesome - thank you!
I think I blacked out midway through reviewing, but it LGTM - so @docker/docs-owners - can someone start at the bottom? :)

Wow, really great! Thanks so much for doing that. I checked about 2/3, starting at the bottom.
Embarrassed by how many were on docs I've written or edited. And I'm the guy who wrote the style guide! :-)
LVGTM

Thanks Rick for doing this!  Needed doing and is obviously a popular PR in the docs team.  You get the Gatsby:

Rick can you rebase this? There is one conflict holding it back.

Nice to see that you all like it so much :smiley:
Apparently the Amazon documentation was really shortened in the meantime, so I kicked out that file (which failed the first time due to a single space at the end of a line, hence the two forced pushes).


⚠ Bofrost.fr has degraded performance

In 5eb8e7f, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1579 ms

Resolved: Bofrost.fr performance has improved in 0a4bbdf after 2 hours, 24 minutes.


Refactored device and variant selection

Adds description for selected device, and subsequently adds description for selected variant.
This pins down the actual specific board in question, for better (less error-prone) UX.

TODO:

[x] Port over all files and group accordingly
[ ] Add support for images
[x] Add support for automatically using the test_type specified by the "selected device"

Additional TODO(May be different PR):

Deciding on skipping NOR Flash if the device doesn't have one From EEPROM Config or any other json variable
Configure pipeline, Image resolution from Hardware Config in EEPROM json
Skip IMU Update based on Hardware config if the device doesn't have IMU.

LGTM, I tested it with an oak-lite and it works, I'll add the other jsons, try some other boards, and I can add the images if needed.


Add option to ignore errors from a specific tag

Done @ste93cry :)

@ste93cry You're welcome.
What is the release strategy of this package ? :)
Just to have an idea about how much time I'll have to wait for this feature

We have no real strategy, we accumulate some things and when we think we have enough features for a new minor version we release it. Sadly, I don't have any ETA for when this may happen though

It's been two month, a new minor release would be really appreciate if it is possible :)

Release 3.3.0 is out :ship:


make -C infer  can't find wctype.h or stdlib.h

I tried to install infer, but the build failed with a number of errors - unable to find certain header files:
examples:
wctype.c:14:10: fatal error: 'wctype.h' file not found
#include <wctype.h>
^
In file included from math.c:13:
./infer_builtins.h:13:10: fatal error: 'stdlib.h' file not found
#include <stdlib.h>
^
In file included from infer_builtins.c:13:
(see attachedfile for full log transcript).
My setup at build time:
OS X 10.10.5
opam 1.2.2
clang-700.1.76
Python 2.7.10
My Xcode is 7.1,  your dependencies suggest  6.1 to 7.0 - is this a problem?

If not, the command to install them is:
xcode-select --install

Gah! I thought those were installed! I did as you suggested and all now seems to work (I get warnings about no Java, but that's fine)
PS - will installing JDK 1.8 work with current infer, or does it have to be 1.7?

Hello @andrewbutterfield,
You can use JDK 1.8 but new Java 8 constructs in source code are not supported.
Feel free to reopen this issue in case the problem still persists.

@andrewbutterfield regarding JDK 1.8, we don't really support it yet and we encourage to use JDK 1.7.
While JDK 1.8 might work for some projects, infer might crash for some projects.
You are also fine with JDK 1.8 as long as you are not analyzing java code.

That's OK - I'll skip the Java for now. I managed to get it to run on C - and got some Null Dereference errors - so now I am happy! Thanks for your help.


[ANNOUNCEMENT] No more new features, only bug fixes.

This is not an issue. rather an announcement.
I will stop adding new features to this library and will only do bug fixes.
I was working for v2 of this library but I figured that it will be better to make a new library instead because the v2 doesn't scrape data from Youtube page anymore, instead it will send a request to (what I assume to be) Youtube internal API for Youtube Web App.
It's called Youtubei, it's still in early stage but should be stable. It also should be faster than scrape-yt. Go check it out 😁

I've decided to deprecate this package. Please use youtubei instead.


net/http: allow checking if http.Hijacker was already Hijacked

1.- What version of Go are you using (go version)?
go version go1.6.3 darwin/amd64
but should happen in all versions which has Hijacker support.
2.- What operating system and processor architecture are you using (go env)?
darwin_amd64
3.- What did you do?
I'm using httprouter package to handle all kind of requests, these include websocket related ones. The router has a panic handler which helps writing useful info based on http.Request, http.ResponseWriter and an interface which defines the panic itself. But this problem is not related to the package, the absence of something to check if the connection is hijacked could derive in server errors due to an hijacked connection was in place and trying to write any kind of http data.
func handler(w http.ResponseWriter, _ *http.Request)
{
  hijacked := false
  if h, ok := w.(http.Hijacker); ok {
    hijacked = h.Hijacked
  }

  if !hijacked {
    http.Error(w, "", http.StatusInternalServerError)
  }
}

4.- What did you expect to see?
Nothing if connection was already Hijacked.
5.- What did you see instead?
2016/07/21 10:25:23 http: response.WriteHeader on hijacked connection
2016/07/21 10:25:23 http: response.Write on hijacked connection

Any chance to accept a PR?

I'm reluctant to add too much new API to the net/http package at this point. What did you have in mind?

Thanks for your quick answer.
What about something like this?
[...]

type Hijacker interface {
	Hijack() (net.Conn, *bufio.ReadWriter, error)
	Hijacked() bool
}

[...]

func (w *response) Hijacked() bool {
	return w.conn.hijacked()
}

No, you can't enlarge an interface and still be backwards compatible.
See also: http://blog.merovius.de/2015/07/29/backwards-compatibility-in-go.html

Ups, sorry i missed it.
Ignore what I said, what about another interface (too much?) for the sole purpose of knowing if it's hijacked or not? Please don't take into account the interface name, we can think something that it's more accurate if you feel this can be included.
[...]

type Hijackeder interface {
    Hijacked() bool
}

[...]

func (w *response) Hijacked() bool {
    return w.conn.hijacked()
}

Yeah, any new interface feels like too much. Maybe we can shove it (it == some new func?) away in the httputil package or something. Not sure if that's gross itself, but since it's already a random package, maybe it's okay.

I'm lost, how to get an internal property value in a subpackage which doesn't have parent package visibility? Or i'm completely wrong?
Exposing a boolean (through method/field which breaks compatibility) seems like I'm choosing which one to cut the red or blue wire :)

One option is to declare an unexported helper function in net/http, and then use //go:linkname to make it accessible from net/http/httputil.  We use this trick a fair amount in the standard library.  That said, it's kind of a hack, so I'd only resort to that if necessary.

@mdempsky, I don't think we'd even need that trick. Both net/http and net/http/httputil could depend on an shared internal package and pass around the func through that.

Actually, something else we could do is just not spew to the server log if lenData == 0, but still return ErrHijacked like we do today:
func (w *response) Write(data []byte) (n int, err error) {
        return w.write(len(data), data, "")
}

func (w *response) WriteString(data string) (n int, err error) {
        return w.write(len(data), nil, data)
}

// either dataB or dataS is non-zero.
func (w *response) write(lenData int, dataB []byte, dataS string) (n int, err error) {
        if w.conn.hijacked() {
                w.conn.server.logf("http: response.Write on hijacked connection")
                return 0, ErrHijacked
        }

Changing the code to be:
func (w *response) Write(data []byte) (n int, err error) {
        return w.write(len(data), data, "")
}

func (w *response) WriteString(data string) (n int, err error) {
        return w.write(len(data), nil, data)
}

// either dataB or dataS is non-zero.
func (w *response) write(lenData int, dataB []byte, dataS string) (n int, err error) {
        if w.conn.hijacked() {
                if lenData > 0 {
                        w.conn.server.logf("http: response.Write on hijacked connection")
                }
                return 0, ErrHijacked
        }

Then you just do a Write(nil) and check the error value, but we still spam the logs in the majority of cases for people making actual coding mistakes, which is why the log was there in the first place.
No new API.

Although it's a little bit obscure, I think that brad's approach it's the best one, at least for the 1.X branch.
I don't mind to create a patch with your solution, do you want me to proceed?

ping @bradfitz

Done. I was leaving the easy ones to the end. @quentinmit, want to review?

thanks @bradfitz 👍


Small refactoring of MQTT binary_sensor

Description:
Small refactoring of MQTT binary_sensor as proposed in #18174:

Just store config instead of every variable since the configuration values are just copied.

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

@balloob I think this is what you had in mind in #18174?

Yes. Looks so much cleaner I think.


[d3d9] The Godfather:The Game crashes at launch with DXVK, works with wined3d

Software information
The Godfather: The Game, any  graphical setting
Game works with wined3d and dgVoodoo2+DXVK.
Attempting to use DXVK without any other wrappers leads to a crash at boot.
This patch/mod is needed in order to avoid movies playing at launch, which normally causes a crash at launch on any system that is newer than XP.
https://cookieplmonster.github.io/mods/godfather/#silentpatch
Tests were done with this applied, in both wined3d only, dxvk only and dxvk+dgvoodoo2 cases.
System information

GPU: NV GTX 1050
Driver: 510.54
Wine version: 7.5
DXVK version: 1.10.1 and master

Apitrace file(s)

godfather.trace.tar.gz

Trace was captured with wined3d. Reproduces crash with DXVK.
Log files

d3d9.log: godfather_d3d9.log
Wine output:
wine-output.txt

The problem here is that Recreating the back buffer after Reset() fails because of an unsupported sample count.

Fixed now.


demo code for table structure model

please add demo code for table structure model on what the input should be and what should be expect in output, for input we it should a simple data structure; so we can use custom parsing backends.
for context, i want to move to your model for tables in my custom code from previous table-transformers; need help in migrating

found it - https://github.com/DS4SD/docling-ibm-models/blob/main/tests/test_tf_predictor.py


Overriding WordPress globals is prohibited

I got a soft rejection with CodeStar Framework for my ThemeForest WordPress Theme. I needed Your help to fix this. Please, help me.
invxtassy/inc/cs-framework/cs-framework-path.php
**409	ERROR	Overriding WordPress globals is prohibited**
413	ERROR	Overriding WordPress globals is prohibited
423	ERROR	Overriding WordPress globals is prohibited
431	ERROR	Overriding WordPress globals is prohibited
437	ERROR	Overriding WordPress globals is prohibited

Review My Code Please:
/**
 *
 * Get locate for load textdomain
 *
 * @since 1.0.0
 * @version 1.0.0
 *
 */
if ( ! function_exists( 'cs_get_locale' ) ) {
  function cs_get_locale() {

    global $locale, $wp_local_package;

    if ( isset( $locale ) ) {
      return apply_filters( 'locale', $locale );
    }

    if ( isset( $wp_local_package ) ) {
      $locale = $wp_local_package;
    }

    if ( defined( 'WPLANG' ) ) {
      $locale = WPLANG;
    }

    if ( is_multisite() ) {

      if ( defined( 'WP_INSTALLING' ) || ( false === $ms_locale = get_option( 'WPLANG' ) ) ) {
        $ms_locale = get_site_option( 'WPLANG' );
      }

      if ( $ms_locale !== false ) {
        $locale = $ms_locale;
      }

    } else {

      $db_locale = get_option( 'WPLANG' );

      if ( $db_locale !== false ) {
        $locale = $db_locale;
      }

    }

    if ( empty( $locale ) ) {
      $locale = 'en_US';
    }

    return apply_filters( 'locale', $locale );

  }
}

The function is overriding the $locale global, which appears in this case to be intentional. I am not familiar with the CodeStar framework, so I do not know what the reasoning behind this code is, and whether it should be changed. I'd say perhaps you should raise the issue with @Codestar.

Ok, thanks.

#530


[Bug] Duplicate languages

On the first entry languages display correct
https://user-images.githubusercontent.com/55026109/79591567-6218a280-80e1-11ea-95ed-221c5b041127.jpg
but on the second - duplicate
https://user-images.githubusercontent.com/55026109/79591564-60e77580-80e1-11ea-9c3b-d83f8b67b194.jpg)

Thanks, should be fixed with the next update.


How to get Unaffected and Killedbycall Register Lists from cspec file

I'm looking for a way to extract the register lists for "unaffected" and "killedbycall" registers from the language's corresponding cspec file. I was looking through the API docs for CompilerSpec and Language related interfaces but was only able to find the list of parameter registers for each calling convention via the PrototypeModel.
I also saw that the SleighLanguageDescription class offers a function to get the cspec file. However, I'd like to avoid having to parse the XML file.
Is there a function in the API that I may have overlooked?
Below is an example for the ARM compiler spec:
<unaffected>
        <register name="r4"/>
        <register name="r5"/>
        <register name="r6"/>
        <register name="r7"/>
        <register name="r8"/>
        <register name="r9"/>
        <register name="r10"/>
        <register name="r11"/>
        <register name="d8"/>
        <register name="d9"/>
        <register name="d10"/>
        <register name="d11"/>
        <register name="d12"/>
        <register name="d13"/>
        <register name="d14"/>
        <register name="d15"/>
        <register name="sp"/>
      </unaffected>
      <killedbycall>
          <register name="r1"/>
          <register name="d0"/>
          <register name="d1"/>
          <register name="d2"/>
          <register name="d3"/>
          <register name="d4"/>
          <register name="d5"/>
          <register name="d6"/>
          <register name="d7"/>
      </killedbycall>

Unfortunately, we do not currently parse that portion of the PrototypeModel into the Java API - although we probably should.

Accessing these lists is possible starting from Ghidra 10.0.    From the CompilerSpec object, use methods getCallingConvention(String) or getCallingConventions() to retrieve the desired PrototypeModel object.  Then use
PrototypeModel.getKilledByCallList()   or
PrototypeModel.getUnaffectedList()
to fetch the array of Varnode objects in the killedbycall or unaffected list respectively.


segmentation fault when using -lg:prof

I am trying to follow the guide here but whenever I set N>0 in ./app -lg:prof <N> -lg:prof_logfile prof_%.gz I get a segmentation fault.
Any idea what might be causing this issue?

Can you provide a backtrace for your segmentation fault?

[langest@tuhundra 00_hello_world]$ LEGION_FREEZE_ON_ERROR=1 ./hello_world -lg:prof 1 -lg:prof_logfile prof_%.gz
Legion process received signal 11: Segmentation fault
Process 27400 on node tuhundra is frozen!

[langest@tuhundra ~]$ gdb -p 27400

...

Attaching to process 27400
[New LWP 27401]
[New LWP 27402]
[New LWP 27403]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
0x00007f93e9338ec8 in nanosleep () from /lib64/libc.so.6
(gdb) info threads
  Id   Target Id         Frame
* 1    Thread 0x7f93ea9cfc80 (LWP 27400) "hello_world" 0x00007f93e9338ec8 in nanosleep () from /lib64/libc.so.6
  2    Thread 0x7f93c526a700 (LWP 27401) "hello_world" 0x00007f93ea3c3936 in pthread_cond_wait@@GLIBC_2.3.2 ()
   from /lib64/libpthread.so.0
  3    Thread 0x7f93c4a69700 (LWP 27402) "hello_world" 0x00007f93e93540f7 in sched_yield ()
   from /lib64/libc.so.6
  4    Thread 0x7f93c4268700 (LWP 27403) "hello_world" 0x00007f93ea3c3936 in pthread_cond_wait@@GLIBC_2.3.2 ()
   from /lib64/libpthread.so.0
(gdb) thread 1
[Switching to thread 1 (Thread 0x7f93ea9cfc80 (LWP 27400))]
#0  0x00007f93e9338ec8 in nanosleep () from /lib64/libc.so.6
(gdb) where
#0  0x00007f93e9338ec8 in nanosleep () from /lib64/libc.so.6
#1  0x00007f93e9338d8a in sleep () from /lib64/libc.so.6
#2  0x00005566180c1dfa in Realm::realm_freeze(int) ()
#3  <signal handler called>
#4  0x00007f93e930a756 in ?? () from /lib64/libc.so.6
#5  0x0000556617dea344 in Legion::Internal::LegionProfBinarySerializer::serialize(Legion::Internal::LegionProfDesc::MetaDesc const&) ()
#6  0x0000556617ddd773 in Legion::Internal::LegionProfiler::LegionProfiler(Realm::Processor, Realm::Machine const&, Legion::Internal::Runtime*, unsigned int, char const* const*, unsigned int, char const* const*, char const*, char const*, unsigned long, unsigned long, unsigned long) ()
#7  0x0000556618043613 in Legion::Internal::Runtime::initialize_legion_prof(Legion::Internal::Runtime::LegionConfiguration const&) ()
#8  0x000055661806a3e5 in Legion::Internal::Runtime::Runtime(Realm::Machine, Legion::Internal::Runtime::LegionConfiguration const&, Legion::InputArgs, unsigned int, std::set<Realm::Processor, std::less<Realm::Processor>, std::allocator<Realm::Processor> > const&, std::set<Realm::Processor, std::less<Realm::Processor>, std::allocator<Realm::Processor> > const&, std::set<unsigned int, std::less<unsigned int>, std::allocator<unsigned int> > const&, std::map<Realm::Processor, unsigned int, std::less<Realm::Processor>, std::allocator<std::pair<Realm::Processor const, unsigned int> > > const&) ()
#9  0x000055661806bffe in Legion::Internal::Runtime::configure_runtime(int, char**, Legion::Internal::Runtime::LegionConfiguration const&, Realm::Runtime&, Realm::Processor::Kind&) ()
#10 0x000055661806c5d8 in Legion::Internal::Runtime::start(int, char**, bool) ()
#11 0x0000556617cd0904 in main ()

Any chance we can get it with a debug binary so we can have line numbers?

Run with the -lg:debug_ok flag to avoid the runtime warning about trying to profile in debug mode.
I'm at least not able to reproduce this on a few different machines, both Linux and OSX. This is from the current master or stable branch?

Can you include the OS that you're running on the compiler (with version number) you are using to build Legion?

This is using master. be9896315363fb11e43a195fec9e4e2834b1211f
I will try using stable. Maybe it works better.
Here is the debug information, I forgot I changed DEBUG to 0.
I'm running on Gentoo
$ g++ --version
g++ (Gentoo 7.3.0-r3 p1.4) 7.3.0

[langest@tuhundra ~]$ gdb -p 4087
...

(gdb) where
#0  0x00007f3c1a6b0ec8 in nanosleep () from /lib64/libc.so.6
#1  0x00007f3c1a6b0d8a in sleep () from /lib64/libc.so.6
#2  0x0000560db5eb638d in Realm::realm_freeze (signal=11) at /home/langest/repos/legion/runtime/realm/runtime_impl.cc:131
#3  <signal handler called>
#4  0x00007f3c1a682756 in ?? () from /lib64/libc.so.6
#5  0x0000560db59962a4 in Legion::Internal::LegionProfBinarySerializer::serialize (this=0x560db800d630, meta_desc=...) at /home/langest/repos/legion/runtime/legion/legion_profiling_serializer.cc:309
#6  0x0000560db597513b in Legion::Internal::LegionProfiler::LegionProfiler (this=0x560db8021c80, target=..., machine=..., rt=0x560db80127e0, num_meta_tasks=80, task_descriptions=0x7fffd548a040,
    num_operation_kinds=32, operation_kind_descriptions=0x560db6ed6800 <Legion::Internal::Operation::op_names>, serializer_type=0x560db66b66f2 "binary", prof_logfile=0x7fffd548e0bb "prof_%.gz",
    total_runtime_instances=1, footprint_threshold=134217728, target_latency=100) at /home/langest/repos/legion/runtime/legion/legion_profiling.cc:805
#7  0x0000560db5d73ef1 in Legion::Internal::Runtime::initialize_legion_prof (this=0x560db80127e0, config=...) at /home/langest/repos/legion/runtime/legion/runtime.cc:9516
#8  0x0000560db5d6ec06 in Legion::Internal::Runtime::Runtime (this=0x560db80127e0, m=..., config=..., args=..., unique=0, locals=std::set with 1 element = {...},
    local_utilities=std::set with 1 element = {...}, address_spaces=std::set with 1 element = {...}, processor_spaces=std::map with 2 elements = {...})
    at /home/langest/repos/legion/runtime/legion/runtime.cc:8972
#9  0x0000560db5d98c41 in Legion::Internal::Runtime::configure_runtime (argc=6, argv=0x7fffd548bed8, config=..., realm=..., startup_kind=@0x7fffd548bbbc: Realm::Processor::LOC_PROC)
    at /home/langest/repos/legion/runtime/legion/runtime.cc:19197
#10 0x0000560db5d966fd in Legion::Internal::Runtime::start (argc=6, argv=0x7fffd548bed8, background=false) at /home/langest/repos/legion/runtime/legion/runtime.cc:18669
#11 0x0000560db579c83d in Legion::Runtime::start (argc=6, argv=0x7fffd548bed8, background=false) at /home/langest/repos/legion/runtime/legion/legion.cc:6855
#12 0x0000560db5780b56 in main (argc=6, argv=0x7fffd548bed8) at hello_world.cc:68

Stable works fine actually.

Ok, I can confirm that I can reproduce it on commit be98963 however on the most recent commit of master cf0c227 it no longer reproduces. Can you update your master branch to cf0c227 and confirm that the problem goes away for you too?

Latest master be9896315363fb11e43a195fec9e4e2834b1211f still seems to have the problem for me.

be98963 is not the latest master. cf0c227 is latest: https://gitlab.com/StanfordLegion/legion/commit/cf0c2271cf686578e1ab0e8b9e6b045a120bca10
All Legion development is done on gitlab, we just do issue tracking here on github because its nicer.

@streichler Is that mirror working? Github shouldn't be that far behind gitlab.

The mirror is running in a cron job, so we shouldn't have any staleness issues.  @lightsighter, are we confident the original problem has been resolved?

Yes, we are confident that the problem is solved.


Different desktop on xrandr HDMI --left-of eDP

Issue Type

[ *] Bug Report
[ ] Feature Request
[ ] Enhancement

Description
zwm places every opened program (except for polybar) only on HDMI when using HDMI side of laptop's screen
Steps to Reproduce (for Bug Reports)

Open zwm
Connect HDMI
Configure with xrandr --output HDMI --left-of eDP1
Open windows and change desktops

Expected Behavior
Each screen corresponding to a different desktop and can move windows between them.
Actual Behavior
zwm places all opened windows in one screen only and ignore the second leaving only polybar
Logs and Screenshots
Attach any relevant logs or screenshots that might help in diagnosing the issue.
Additional Information
This happens even if I start zwm before connecting the external monitor or after.
If I connect the external before, X config defaults to HDMI --same-as eDP
Checklist

[* ] I have searched for duplicate issues to ensure this is not a duplicate.

If you’re connecting your monitor before starting ZWM and still running into this issue, then it might be a bug or something with xrandr. But, currently, zwm doesn’t pick up on monitors being connected or disconnected while it’s running, it just picks up monitors that were connected before it started (I didn't handle cases where monitors change on the fly). I’ll fix this behavior next week or the week after when I get the time for it.

@Lang-Lovdog I have added xrandr HDMI --left-of eDP to my .xinirc and the issue cannot be reproduced. It works as expected but the status bar shows up in the primary monitor only. Note, i did all of this before starting zwm.

Ignore my previous reply, your issue seems to happen only if you connect the external monitor after starting zwm. I will fix that

@Lang-Lovdog the bug should now be fixed in #32. I'll keep the PR open for a few days to test the changes thoroughly before merging into the master branch. In the meantime, feel free to pull the changes from #32 and report any bugs you encounter.

Thanks, sorry for not answering before. I was kinda busy with some school things.
I'll test it ASAP.

@Lang-Lovdog the bug should now be fixed in #32. I'll keep the PR open for a few days to test the changes thoroughly before merging into the master branch. In the meantime, feel free to pull the changes from #32 and report any bugs you encounter.

I'm trying it rn, the feature works pretty well and haven't found any bug at the moment.
Changing the topic a little bit, in order to switch monitor focus without mouse, is it possible to map it?

Okay that's cool, I have found few bugs and most of them were fixed. i am still fixing some other deep issues related to the tree. The feature you requested seems easy to implement, i would suggest you open another issue and request it so i can keep things intact in this repo.

Okay that's cool, I have found few bugs and most of them were fixed. i am still fixing some other deep issues related to the tree. The feature you asked for isn't implemented into the wm, but it seems easy to implement, i would suggest you open another issue and request it so i can keep things organized in this repo.

Thanks, I'll open the request.
About some bugs I found (20min. ago) are actually just about the tree as you mentioned above, but I don't know how to describe them, I'm really sorry 🙇🏾 if my description is not clear.

There's more than one window open
I close/move one of the Windows
The Windows left got buggy within desktops with the same desktop number (get kinda misplaced in both screens).
If not a buggy window or when it fixes itself, the second screen stops receiving Keyboard events and zwm instructions.

But, the last one happens too if my monitor turns off and on without xrandr changing the layouts.
Hope this helps, maybe you've noticed this yet, but better to be sure.
Thanks again for your time and work 😸✨

Interesting! I believe it's connected to a deep-rooted bug I’ve been working on in the tree. It occurs when windows are moved or deleted, and it results in tree corruption caused by dangling pointers. This impacts the desktop trying to hold the newly moved node. After tracing the issue, I pinpointed it to how windows are unlinked from the tree. I’ve rewritten the unlink_node function and just pushed the changes to #32. Please check if the bug you encountered still persists. I’ll also do thorough testing on my end. Thanks for reporting this!

Looks like the latest changes in #32 added more bugs. I am tracking some double frees and other memory curruptions that happen after disconnected monitors are merged.

@Lang-Lovdog I have fixed all the bugs i encountered. This should resolve your issue with the buggy desktops and windows. Lemme know if things are good from your side and your issue was fixed so i can merge to main.

@yazeed1s It seems that I lost click event inside windows. I can only select window but can't interact.

Is focous_follow_pointer set to false?

my bad, i was expermenting with some changes in that function, and forgot to restore the old code. I will fix that rn and push it to #32

Is focous_follow_pointer set to false?

Yep, it is set to false. Just because of some floating window things I've been experimenting with.

my bad, i was expermenting with some changes in that function, and forgot to restore the old code. I will fix that rn and push it to #32

I have no problem if you still need to get it altered. I'll just put my config to true.


Avoid FOUC on some features

Fixes https://github.com/sindresorhus/refined-github/issues/2604
Naming suggestions welcome. Perhaps features.onAjaxedPagesInstant (like the existing features.onAjaxedPagesRaw)
Before
This shows a page refresh. Notice how releases-tab, more-dropdown and forked-to are not there for a moment before dom-ready happens.

After
Notice how parse-backticks still has a FOUC (Flash Of Unstyled Content) but it no longer happens for the 3 features above.

Can directly to my bank account


C++-Bindings - Example does not run

After installing all the prerequisites and trying to run the random_agent.cpp in
cpp bindings, it threw an Error, saying it cannot convert a certain value to float.
Changing from Breakout-v0 to CartPole-v0 made it work for the time being.

@kschoos how did you compile and run the C++ example?
I'm unable to compile, getting this error: symbol(s) not found for architecture x86_64

Found an old makefile here.

The implementation does not support 3D states, i.e., image inputs. You need to call Breakout-ram-v0.

After installing all the prerequisites and trying to run the random_agent.cpp in
cpp bindings, it threw an Error, saying it cannot convert a certain value to float.
Changing from Breakout-v0 to CartPole-v0 made it work for the time being.


Cannot set tokens provider for unknown language

According to document, i excluded languages from MonacoEditorWebpackPlugin.
But looks like TMGrammers are not loaded for that languages and i am getting following error
Uncaught (in promise) Error: Cannot set tokens provider for unknown language javascript
    at Object.setTokensProvider (standaloneLanguages.js:231)
    at _callee$ (index.js:77)
    at tryCatch (runtime.js:45)
    at Generator.invoke [as _invoke] (runtime.js:264)
    at Generator.prototype.<computed> [as next] (runtime.js:98)
    at asyncGeneratorStep (asyncToGenerator.js:3)
    at _next (asyncToGenerator.js:25)

Code
async function liftOff(monaco) {
  const registry = new Registry({
    getGrammarDefinition: async scopeName => {
      console.log("scopeName :", scopeName);
      return {
        format: "json",
        content: await (await fetch(`/grammers/${scopeName}.tmLanguage.json`)).text(),
      };
    },
  });

  // map of monaco "language id's" to TextMate scopeNames
  const grammars = new Map();
  grammars.set("python", "source.python");
  grammars.set("javascript", "source.js");

  await wireTmGrammars(monaco, registry, grammars);
}

How i am changing language ?
monaco.editor.setModelLanguage(editorRef.current.getModel(), "javascript");

I have the same issue.
I even forked WebPack plugin to use modified monaco editor without "monaco-languages" built-in.
With that setup I do not get error but there's no syntax highlighting at all. No built-in, no textmate... :(

@ozonep  I think we need to register custom languages first before wiring TMGrammers. Try:
monaco.languages.register({ id: "languageName" });

@ozonep @dev-drprasad did it work for you guys after calling monaco.languages.register?
I was about to say the same thing tbh (haven't checked this myself though)

@NeekSandhu it worked for me.


Add ChatGPT

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Added ChatGPT, the popular AI chatbot.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks so much for your repeated contribution!  You rock, @infinitepower18!


OpenPGP Code Cleanup: Remove redundant modifiers in interface members

This PR removes redundant modifiers on members of interfaces.
In Java, method signatures in interfaces are public and abstract by default.
Constants in interfaces are public, static and final by default.

A bit late for a spring clean! Being um-ing and ah-ing about doing this for a while. Thanks, merged.


Upgrade strapi and remove node 10 testing

Since strapi already does not support node 10, we do not have to still test it in node 10. Making it possible to upgrade cypress to v 7.*
fixes:  #142

bors try

I put the label breaking change since the support of a node version (10) is removed. After discussing with different dev communities (rust and PHP), dropping a version support does not deserve a new major. However, since we are not stable and following the semver convention (e.g. using the 0.X.Y format) the users would rather being aware of this change by upgrading the minor rather than upgrading the patch in our situation, even if it's not breaking. The package managers often download the last patch of a package which can lead to bad surprises for users.


Documentation links are broken

Some of the documentation links are broken. The documents were moved but the link, for example, "Maven" plugin documentation, still points to an old file name.

Hey @verhas, thank you for the feedback. I'll try to fix them as soon as I can.


Update play-json to 2.10.0-RC8

About this PR
📦 Updates com.typesafe.play:play-json from 2.10.0-RC7 to 2.10.0-RC8
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play", artifactId = "play-json" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.typesafe.play", artifactId = "play-json" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #295.


Fix/multiplier contract specs

Description
Allow contract specs to skip the gas multiplier.

Codecov Report

Merging #55 (be70398) into main (caaf1bb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
- Coverage     11.92%   11.91%   -0.02%
  Complexity       35       35
============================================
  Files            65       65
  Lines          3321     3324       +3
  Branches        355      356       +1
============================================
  Hits            396      396
- Misses         2869     2872       +3
  Partials         56       56

Impacted Files
Coverage Δ

...rovenance/engine/service/ChaincodeInvokeService.kt
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caaf1bb...be70398. Read the comment docs.


sending undefined for max_stories causes create topic to fail

send None instead

in the javascript helper, we now send null if the value is undefined
for the api, to properly ignore values, we should apparently NOT send empty values
perhaps this means in the api.py we should do something similar to what we do in the javascript helper:
def _validate_params(params, valid_params, args):
    for key in args.keys():
        if key not in valid_params:
            raise ValueError("{} is not a valid argument for this api method".format(key))
        if args[key] != null:
            params[key] = args[key]
    return params

but how to differentiate between values we want to set to null, and values we don't want to send?

perhaps the easiest fix is in topiccreate.py
optional_args = {
        'is_public': request.form['is_public'] if 'is_public' in request.form else None,
        'is_logogram': request.form['is_logogram'] if 'is_logogram' in request.form else None,
        'ch_monitor_id': request.form['ch_monitor_id'] if len(request.form['ch_monitor_id']) > 0 and request.form['ch_monitor_id'] != 'null' else None,
        'max_iterations': request.form['max_iterations'] if 'max_iterations' in request.form else None,
        'max_stories': request.form['max_stories'] if 'max_stories' in request.form else None,
    }

if in request.form but if null, don't include in optional_args

actually, sending None has been handled by the api (as with ch_monitor_id)


Error in main function

D:\win-acme.v2.2.9>wacs.exe --verbose
[DBUG] Logging at level Verbose
[VERB] W3SVC detected and running
[VERB] No FTPSVC detected
[VERB] Looking for settings.json in D:\win-acme.v2.2.9
[DBUG] Use existing configuration folder C:\ProgramData\win-acme
Error in main function: An exception was thrown while activating PKISharp.WACS.Host.Wacs -> PKISharp.WACS.Clients.UpdateClient -> PKISharp.WACS.Services.ProxyService -> PKISharp.WACS.Services.SettingsService.
at Autofac.Core.Resolving.Middleware.ActivatorErrorHandlingMiddleware.Execute(ResolveRequestContext context, Action1 next)    at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.<BuildPipeline>b__1(ResolveRequestContext context)    at Autofac.Core.Pipeline.ResolvePipeline.Invoke(ResolveRequestContext context)    at Autofac.Core.Resolving.Middleware.RegistrationPipelineInvokeMiddleware.Execute(ResolveRequestContext context, Action1 next)
at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.b__1(ResolveRequestContext context)
at Autofac.Core.Resolving.Middleware.SharingMiddleware.Execute(ResolveRequestContext context, Action1 next)    at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.<BuildPipeline>b__1(ResolveRequestContext context)    at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.<BuildPipeline>b__1(ResolveRequestContext context)    at Autofac.Core.Resolving.Middleware.CircularDependencyDetectorMiddleware.Execute(ResolveRequestContext context, Action1 next)
at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.b__1(ResolveRequestContext context)
at Autofac.Core.Pipeline.ResolvePipeline.Invoke(ResolveRequestContext context)
at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, ResolveRequest& request)
at Autofac.Core.Resolving.ResolveOperation.ExecuteOperation(ResolveRequest& request)
at Autofac.Core.Resolving.ResolveOperation.Execute(ResolveRequest& request)
at Autofac.Core.Lifetime.LifetimeScope.ResolveComponent(ResolveRequest& request)
at Autofac.Core.Lifetime.LifetimeScope.Autofac.IComponentContext.ResolveComponent(ResolveRequest& request)
at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable1 parameters, Object& instance)    at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable1 parameters)
at PKISharp.WACS.Host.Program.Main(String[] args)
An exception was thrown while invoking the constructor 'Void .ctor(PKISharp.WACS.Services.ILogService, PKISharp.WACS.Configuration.ArgumentsParser)' on type 'SettingsService'.
at Autofac.Core.Activators.Reflection.BoundConstructor.Instantiate()
at Autofac.Core.Activators.Reflection.ReflectionActivator.<>c__DisplayClass14_0.b__0(ResolveRequestContext context, Action1 next)    at Autofac.Core.Resolving.Middleware.DelegateMiddleware.Execute(ResolveRequestContext context, Action1 next)
at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.b__1(ResolveRequestContext context)
at Autofac.Core.Resolving.Middleware.DisposalTrackingMiddleware.Execute(ResolveRequestContext context, Action1 next)    at Autofac.Core.Resolving.Pipeline.ResolvePipelineBuilder.<>c__DisplayClass14_0.<BuildPipeline>b__1(ResolveRequestContext context)    at Autofac.Core.Resolving.Middleware.ActivatorErrorHandlingMiddleware.Execute(ResolveRequestContext context, Action1 next)
Attempted to perform an unauthorized operation.
at System.Security.AccessControl.Win32.GetSecurityInfo(ResourceType resourceType, String name, SafeHandle handle, AccessControlSections accessControlSections, RawSecurityDescriptor& resultSd)
at System.Security.AccessControl.NativeObjectSecurity.CreateInternal(ResourceType resourceType, Boolean isContainer, String name, SafeHandle handle, AccessControlSections includeSections, Boolean createByName, ExceptionFromErrorCode exceptionFromErrorCode, Object exceptionContext)
at System.Security.AccessControl.NativeObjectSecurity..ctor(Boolean isContainer, ResourceType resourceType, String name, AccessControlSections includeSections, ExceptionFromErrorCode exceptionFromErrorCode, Object exceptionContext)
at System.IO.FileSystemAclExtensions.GetAccessControl(DirectoryInfo directoryInfo)
at PKISharp.WACS.Services.SettingsService.UsersHaveAccess(DirectoryInfo di)
at PKISharp.WACS.Services.SettingsService.EnsureFolderAcl(DirectoryInfo di, String label, Boolean created)
at PKISharp.WACS.Services.SettingsService.EnsureFolderExists(String path, String label, Boolean checkAcl)
at PKISharp.WACS.Services.SettingsService..ctor(ILogService log, ArgumentsParser parser)
at lambda_method1(Closure, Object[])
at Autofac.Core.Activators.Reflection.BoundConstructor.Instantiate()
Press  to close
Platform:

OS:  Windows 2016
Version: 2.9.1, 64-bit, pluggable

This looks like a duplicate of https://github.com/win-acme/win-acme/issues/2604

This is due to I set user Administrator active:no. I do not want anyone to login with Administrator.
workaround: set user Administrator active:yes


Update run.sh

These modifications include arranging script commands more logically and adding annotations for important issues. You can also configure the text according to your own preferences.

Thanks @MaikTech!


RichTextLabel: Added get_visible_line_count method

Also exposed get_line_count to GDScript.
The inner-workings of RichTextLabel is quite involved, and the simpled way of counting visible lines I could think of was this: for each line, increment visible line counter whenever there is something visible on that line. I made use of the existing visibility tests during PROCESS_DRAW, so a proper counting will happen only during draw cycle. But I guess this is OK, since when the widget is non-visible, visible line count is zero anyway.

Should fix #3854

I found a problem with this implementation, so can we hold this off for the moment?
The problem is in RichTextLabel::_notification; essentially, the calculated from_line doesn't take line breaks due to word wraps. This is actually an existing bug, because widgets shouldn't draw regions which are not supposed to be visible anyway. I need to find a workaround for this, probably need to come up with a different way of counting visible lines.

A related question: shouldn't scroll_to_line take word-wrapping into account?

PTAL.

Still not functioning properly. I hope someone familiar with the RichTextLabel code can take a look.

It's puzzling but after disregarding font ascent in visibility test, it seems to be working correctly.

This PR feels a bit hacky, I'm hoping someone more familiar with the intricate details of RichTextLabel can suggest doing things better in various places.

It would be nice to have @reduz's opinion on this. @tagcup mentioned the implementation was a bit hacky, so it would be good to have some advice for a better implementation if possible :)

Sorry, somehow missed this. Seems fine, RichTextLabel is a big hack that becomes a pain to maintain, so only hacks can be added over it.

So I guess, good to merge after a rebase if it still works as intended, and we should start thinking about completely refactoring RichTextLabel in a future release.

Ah, cool. I'll revise it next week. I should at least add some comments to clarify the hack after some testing.

Bump :)

heh we should ask Github to develop some kind of AI to detect that someone mentions that he/she will do something in a certain amount of time ( then the issue becomes forgotten)

Ah apologies, totally forgot about this one! I'll rebase it in a couple of days
Yeah, I only have a few PRs/issues but an integrated reminder system be a huge help for core devs

heh we should ask Github to develop some kind of AI to detect that someone mentions that he/she will do something in a certain amount of time ( then the issue becomes forgotten)

In all seriousness, what they should do for a decent workflow is:

Allow assigning issues to non-organisation members (e.g. to all people who have already contributed one merged PR - they now have logic to identify such people and tag them as "Contributor") - and of course allow those contributors to assign issues to themselves
Have an option to send reminders at a given interval of time for issues where you are assigned

GitHub, if you listen to us... :)

Pretty bump :)

Rebased


frontend: Add gifs to VEP-1507 demonstrating each user journey

Overview
Currently, there are several user journeys described in VEP-1507. It would be beneficial to visualise the user journeys.
DoD

Gifs for each user journey created and added to VEP-1507

Blockers
https://github.com/vmware/versatile-data-kit/pull/1750

Triaged. Closed as stale.


Reorganize source code

Now all Go source files lay in the root of the project which makes navigation through it not very convenient. All source files should be stored in separate directory, sub-package and cmd directories preferably.

Resolved by #30


Apt repo cleanup and testing expansion

So this all started when @coderanger pointed out that we didn't need to use the run_command on the shell_out helper method since it does that internally already. I fixed that here and realized the logic could be broken out to ease readability and expand testing. I added yard comments, broke out some logic into smaller methods, added more unit tests, and added a bit more debug logging.

Adding yard mostly came along for free when adding simple method comments. Adding a param and return code was pretty simple at that point. It probably doesn't add a huge amount, but it's pretty simple and makes it a bit easier to read through later on when modifying that code. I don't really see anyone reading this in an actual web browser though since there's not really any need / reason.

Hold off on this one. I'm working on a key validation issue and will get apt_repository into the Travis integration tests

I ran this through some more tests and I'm not able to see the original problem with chef 14 now. Looks good to merge


Remove 't' from HTML question 2

Describe the bug
There is a 't' in the 'content' field for HTML question 2.  This shouldn't be there.
The content value should be4
Please remove
Steps to reproduce

View file api-client/mockData/htmlAnswers.ts
Remove the 't' from line 27

Expected behavior
The content value should be 4
Screenshots and recordings
No response
OS / Linux distribution
na
Additional context
No response

Hello @pfwd , I'd like to take this up. Kindly assign it to me.

I've assigned it over @Mannuel25 👍


Update area view location update

Update how area view locations are found using the {Feature} placeholder.
Added some additional samples to show that subfolders work.
Also fixed a typo and some improvements such as AreaFeatureFolderOptions ctor that accepts a FeatureFolderOptions object.

Thanks!


Overlay KMLB setup forecasts on top of historical data. --> Verification page?

One issue here is that to properly calculate the KMLB wind run data I need to have 12 hour averages of hourly data. So perhaps download_asos_data.R can download ASOS data to be used to verify forecasts for bias correction purposes, then in calculate_irl_setup.R I can automatically get the last few days of KMLB data and calculate an hourly-based wind run there.

download_asos_data.R is now operational. Editing calculate_irl_setup.R.


RFC: Remove content prop

I'm think that we need to remove content prop from all our components.
This will be breaking change.
Why?
Confusing
It's represents different types in our components:

contentShorthand
itemShorthand

Poor coverage
There are many components that doesn't have content prop. Sometime they have another shorthand instead of content.
Useless
It does same job as children prop:
<Component>Children</Component>
<Component children='Children' />
<Component content='Children' />

Poor tests
We doesn't have special tests for contentShorthand, our existing is not so powerfull as rendersChildren.
Simplify render function
Our render funtions will be more simple, while we have less usages of lodash (_.isNil).
- {_.isNil(children) ? content : children}
+ {children}

@levithomason @jcarbo I'm glad to hear your throughts :smile

I agree on confusing, poor coverage, and simplifying the render, however, it is not only useful but required to facilitate the shorthand factories.
The purpose of the content prop is that is supports shorthand creation.  This is different than children in two very important ways:

Children does not support props objects
Children does not create an element, but renders the content as-is

Example, a Popup takes content which ultimately creates a content div within the Popup:
<Popup content='Some content' />

Some content

Whereas using children would, of course, render the text directly as a child.  We also cannot pass children to the factory in every case because there would be no way for the user to pass certain values, such as an array of strings or a props object.
There are some usages which are unnecessary, such as the ItemMeta's content.  This usage is a direct replacement of the children prop and offers no new features.  I think the only reason we should keep these props is for API consistency and this design principal:
All components should have a content prop and it should create the required primary content of the component from a number, string, props object, or another element.
I think then we must keep the content prop for shorthand purposes.  Let me know your thoughts on this.

There are some usages which are unnecessary, such as the ItemMeta's content. This usage is a direct replacement of the children prop and offers no new features.

I want to eliminate possible misunderstandings. My proposal is remove content: contentShorthand that makes same job as children (ItemMeta), while keep content: itemShorthand (Popup) that is part of our design.

I can see that argument.  Keeping consistent props across all components is nice, however, our shorthand props are 1:1 with subcomponents.  So, if there is no Foo.Content subcomponent, then it is reasonable to expect there should be no <Foo content /> prop.
I was leaning toward removing the prop for this case, however, I have one other consideration.  Shorthand props, such as icon are incompatible with children for longstanding reasons.  If a component has shorthand props and the user wants to use them in conjunction with children, then there is no way to do so:
<Button icon='user'>Profile</Button>          // does not work

<Button icon='user' content='Profile' />      // works

Essentially, the content prop is shorthand for children if you are using shorthand props.
We could allow the use of children in place of the content prop in most of these cases.  My only concern there is the cases where we cannot do this so easily.  Cases where the content is used with logic to change the markup and/or used as a value to createShorthand.  See Message which passes content to create a shorthand paragraph, this would not work with passing children.  Also, Header's shorthand content which has a Content subcomponent but content is used to alter the markup and not for shorthand Content creation, we don't want to alter the markup every time there are children.  What if the user wants exactly the children that they passed?
The inconsistency issue is also raised again, that as a developer I have no way of knowing if a component can use children or must use content with my shorthand props.  This goes back to the longstanding reasons conclusion.

In conclusion, I'm thinking it is still good to keep content for all components for consistency and predictability:

children are always rendered exactly as you passed them, never altered/wrapped
shorthand props are never compatible with children
every component has a content prop that is the primary content
all components behave the same all the time

Main problem that I see there is incompability :confused:
<Popup content='Some content' />

Some content

<Popup content={{ children: 'Some content' }} />

Some content

<Button icon='user' content='Profile' />

<button class="ui button">
   Profile
</button>

<Button icon='user' content={{ children: 'Profile' }} /> // does not work

Oh boy, this is a great point.  We simply cannot have some content props work with shorthand, and others not.  Exploring ideas here, it is possible to create a component from this:
<Button content={{ children: 'Profile' }} />

// => <button class="ui button">Profile</button>

This would mean that all usages of the content prop must be passed to createShorthand.  We are bound to run into CSS issues since content='foo' would also create an element.
I'll have to think on this one.  At this point, it seems the least destructive path is to keep the content prop but also allow inconsistent shorthand usage.  I don't like this idea, let's think on it and look for something better.

I have some proposals.
content and contentRendered
We have renderer functions in some components. It's a quite good pattern, I think we can use it there:
function PopupContent(props) {
  // ...
 return <ElementType>{_.isNil(children) ? contentRender(content) : children}</ElementType>
}

PopupContent.defaultProps = {
  contentRenderer: defaultContentRenderer
}

PopupContent.propTypes = {
  // ...
  content: customPropTypes.contentShorthand,
  contentRenderer: Proptypes.func,
}

const defaultContentRenderer = content => {
  if(typeof content === 'string' || typeof content === 'number') return content
  return createShorthand('div', content)
}

So, if we have string or number on content we will simply return them. If we have object, let's use shorthand power, but we will wrap it into child element.
rename content prop
Yes, it will be breaking, but content on Popup and PopupContent still will make different things. It's a good  step to clarify usage of shorthands.

So, if we have string or number on content we will simply return them. If we have object, let's use shorthand power, but we will wrap it into child element.

I like this on first glance except for two hang ups:

Added complexity
There is no way to know which element to wrap it with.  A div cannot be a child of may components.  A span might be safer, but it still may break CSS in some cases.

I'm now thinking that we do not worry about this until we have reported issues about it.  I personally have never run into it.  Do you have any use cases or bugs you've run into that requires a refactor?


lxd/init: show the new default value for password authentication

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Good spot!

jenkins: test this please

It's your weekly news post that brought my attention to that string ;)


[Improvement] Add extended help for Users in Gravitino CLI

What would you like to be improved?
Add extended help for Users in Gravitino CLI  per https://github.com/apache/gravitino/issues/5568
How should we improve?
No response

I would like to work on this issue, could you assign it to me.


How to "Add redirect URIs to service principals"?

The linked article https://docs.microsoft.com/en-us/azure/active-directory/develop/app-objects-and-service-principals#application-and-service-principal-relationship in section https://docs.microsoft.com/en-us/azure/active-directory/develop/reply-url#add-redirect-uris-to-service-principals does not provide any guidance on how to add redirect URIs with wildcards to the service principal. How to do so?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc4c5921-4070-a714-44e6-c4309fe5fd53
Version Independent ID: c52c5c94-bb2e-10cb-9673-98aae4aa37d4
Content: Redirect URI & reply URL restrictions - Microsoft identity platform
Content Source: articles/active-directory/develop/reply-url.md
Service: active-directory
Sub-service: develop
GitHub Login: @sureshja
Microsoft Alias: sureshja

This can be achieved using powershell commandlet Set-AzureADServicePrincipal -ObjectId  -ReplyUrls . Can it be done from the Azure portal?

@sumitt18 thanks for your question. We will investigate and respond shortly.

@sumitt18 this is currently not available, if you're interested in this feature please submit this as a feature request here and if there's enough community support the PG team will engage accordingly.
https://feedback.azure.com/forums/169401-azure-active-directory
That being said, if there's no more questions I'll be closing this by eod tomorrow. Thanks,


Can we split Script section in angular-cli.json

Hi,
can we split scripts section in to
"scripts1": [],
"scripts2":[]
i'm having an issue with loading more than 6MB script bundle files.
Its not loading when deploy in IIS Express
@jbogarthyde , @aciccarello , @filipesilva

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


TIM-60 Code: Fetching and creating of comments from an announcement post

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#129  👈
#128
#127
#126
#125
#124
#122
#121
#120
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


Add testing for uniform pitch change to the reactor core.

As for testing the pitch or tying pitch changes to a specific component this is outside of the scope of this change. I grepped around the code and don't see any tests for core::setPitchUniform or block.setPitch that tests the conservation of solid component mass. I would like to see a separate PR that adds testing to these two methods (on the reactor core is fine) with and without the axial expansion changer.
https://github.com/terrapower/armi/blob/86dc4d8262cf3a30811f22c27eeb9556b004d611/armi/reactor/reactors.py#L2143
For example:

Initialize reactor core, shrink pitch, check that solid masses are conserved and liquid masses (coolant) reduce. Grow pitch back to original, check that solid masses and liquid masses return to the normal state.
Initialize reactor core model, use axial expansion changer, repeat above.

I want to just check that (1) the pitch change is being propagated correctly at that there are tests for this and (2) that the pitch change with thermal expansion doesn't run into issues if it is called after the axial expansion changer and that the results are correct in terms of changes in masses and volume fractions of each component (see: b.getVolumeFractions())
Originally posted by @jakehader in https://github.com/terrapower/armi/issues/845#issuecomment-1223316296

😄 I was literally just drafting out an issue for this! You beat me to it!

@jakehader    This ticket is still assigned to you.  That's cool with me, but if you aren't planning on working on it please un-assign it.
(You are not being singled out, I am going through all the ARMI tickets.)

@john-science we should probably have a requirement and associated testing for updating and setting the core plate grid pitch. This would be very useful for both hex and cartesian grid based reactors and properly documenting this functionality (it's abilities/limitations/etc) would be nice.
@keckler @mgjarrett for visibility and input in case I've forgotten something we have internally providing coverage for this functionality.

I do not think we have any tests that are specific as what Jake is asking for. We have a requirement that one shall be able to do expansion/contraction for the purposes of reactivity coefficient calculation, but not that specific masses/volumes are preserved.


Accessibility signals are shipped in web

I am not sure if we support signals in web? But we do ship a lot of MP3 files in our web-standalone drop:

We do support them in the web 😄


Repeated crashes

Junior crashed twice in the last week.
No error first time, this time error was:
Ready! Logged in as Junior-C#2826
DiscordAPIError[10062]: Unknown interaction
    at SequentialHandler.runRequest (/app/node_modules/@discordjs/rest/dist/index.js:659:15)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.runRequest (/app/node_modules/@discordjs/rest/dist/index.js:528:16)
    at async SequentialHandler.queueRequest (/app/node_modules/@discordjs/rest/dist/index.js:458:14)
    at async REST.request (/app/node_modules/@discordjs/rest/dist/index.js:902:22)
    at async ChatInputCommandInteraction.reply (/app/node_modules/discord.js/src/structures/interfaces/InteractionResponses.js:111:5)
    at async Client.<anonymous> (/app/junior.js:35:3) {
  requestBody: { files: [], json: { type: 4, data: [Object] } },
  rawError: { message: 'Unknown interaction', code: 10062 },
  code: 10062,
  status: 404,
  method: 'POST',
  url: 'https://discord.com/api/v10/interactions/1044360494779211886/aW50ZXJhY3Rpb246MTA0NDM2MDQ5NDc3OTIxMTg4NjpHTGV5dVVFMUVxUndObU04NDdMQ0I3dFF1aXVNeUhxa3prWXlGZEh2TjhaaE1MemU0Y1JJVFk3MWtUR05mbWphWTdmWnRKbUN2dFozdU5mcmZZWnJXMTdkM2sxem5PeWhxM2hlc1I2bmVvbjNBbVNCZ1NENVlXVGJUVUwxWTAxaA/callback'
}
node:events:505
      throw er; // Unhandled 'error' event
      ^

DiscordAPIError[10062]: Unknown interaction
    at SequentialHandler.runRequest (/app/node_modules/@discordjs/rest/dist/index.js:659:15)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.queueRequest (/app/node_modules/@discordjs/rest/dist/index.js:458:14)
    at async REST.request (/app/node_modules/@discordjs/rest/dist/index.js:902:22)
    at async ChatInputCommandInteraction.reply (/app/node_modules/discord.js/src/structures/interfaces/InteractionResponses.js:111:5)
Emitted 'error' event on Client instance at:
    at emitUnhandledRejectionOrErr (node:events:384:10)
    at processTicksAndRejections (node:internal/process/task_queues:85:21) {
  requestBody: {
    files: [],
    json: {
      type: 4,
      data: {
        content: 'There was an error while executing this command!',
        tts: false,
        nonce: undefined,
        embeds: undefined,
        components: undefined,
        username: undefined,
        avatar_url: undefined,
        allowed_mentions: undefined,
        flags: 64,
        message_reference: undefined,
        attachments: undefined,
        sticker_ids: undefined,
        thread_name: undefined
      }
    }
  },
  rawError: { message: 'Unknown interaction', code: 10062 },
  code: 10062,
  status: 404,
  method: 'POST',
  url: 'https://discord.com/api/v10/interactions/1044360494779211886/aW50ZXJhY3Rpb246MTA0NDM2MDQ5NDc3OTIxMTg4NjpHTGV5dVVFMUVxUndObU04NDdMQ0I3dFF1aXVNeUhxa3prWXlGZEh2TjhaaE1MemU0Y1JJVFk3MWtUR05mbWphWTdmWnRKbUN2dFozdU5mcmZZWnJXMTdkM2sxem5PeWhxM2hlc1I2bmVvbjNBbVNCZ1NENVlXVGJUVUwxWTAxaA/callback'
}

I think Junior may be running Node.js 12, should probably update that and ensure discord.js is the latest version too.

Was running Node 16, not 12 as I thought. discord.js was only one minor version behind, so not sure of the issue.
Updating Node to 18 and all dependencies.


update dependencies and make sure worked

main course :

[ ] react
[ ] react-dom
[ ] react router  - all package
[ ] redux

I can take this.

yes , thanks


Add libuast, upgrade libuast API, bugfixing

Originally from: bblfsh/client-python/pull/16 moved to my branch to continue the work.
All suggestions in the original PR have been implemented on this branch.
Other changes:

Added error control which turns an ugly crash into a nice traceback (+ unittest).
Migrated to libuast 0.2.0.
Migrated to Google's C++ coding style
Changed autorship to source{d} in the setup.py, updated email.

Looks like the new tests if failing with Python 3.4 which makes CI fails, I'll take a look.

Symbols renamed.


Set up publishing to Sonatype

Publishing to Bintray creates a transitive dependency that libraries using Machinist need to communicate to their end users. This is a bad experience, so @larsrh kindly published 0.3.0 to Sonatype (and thus Maven Central).
We should set up publish so that it goes to Typelevel's Sonatype repo by default.

So -- I just tried again and I still don't have permission to publish to Sonatype.
I know you asked to grant me access awhile ago but it still doesn't work. My username is "d_m".
I'm trying to standardize all my projects on a particular Sonatype publishing setup, so for now I think I will publish to org.spire-math until we get this sorted out.

This has been fixed for awhile.


Clarifying the Scrapfly JA3

I came across your project and saw "JA3 and HTTP2 fingerprint; JA3 result is probably incorrect". I'm part of Scrapfly, so let me clarify:

https://scrapfly.io/web-scraping-tools/ja3-fingerprint
JA3 and HTTP2 fingerprint; JA3 result probably needs to be corrected (it doesn't match Wireshark's result).

We made the decision not to read the deprecated TLS version from the handshake on version >= TLS1.3 but read the "supported_versions." The original ja3 implementation is now old, and it makes no sense for us to get a fingerprint that does not reflect the version. In TLS1.3, you get 771 on the original ja3 (771 is the TLS1.2 version); our version gives the correct version, 772. https://datatracker.ietf.org/doc/html/rfc8446#section-1.3.
You can see both fields on https://scrapfly.io/web-scraping-tools/ja3-fingerprint page, "Handshake Version" vs. "Supported Versions"
So yes, our Ja3 is not comparable with others, as we are not interested in getting fingerprints that do not reflect the actual client, TLS1.2 and TLS1.3 having the same config can't collide.
Feel free to close ;)

Hi @jjsaunier, thanks for the clarification. That makes sense. The original JA3 implementation is quite outdated. I agree that it is necessary to make a few changes to the old JA3, such as using the supported_versions extension, and sorting the extensions.
I will fix the readme soon. :)

@jjsaunier regardless of who is "correct" / who makes "the right choice" in that situation, it is important to note that your choice creates different fingerprints that cannot be compared with existing JA3 implementations that comply with the "norm", and with JA3 fingerprint databases (and given that JA3 values are hashes, they are really impossible to compare). Hence, it's IMO misleading to call it "JA3"
If Scrapfly calls "JA3" something that is not "the original JA3" (even if that's something "better" than JA3, really, that is not my point), then it is true to say that Scrapfly's JA3 result is incorrect.
Also, the existence of a "supported version" TLS extension will be seen in the "extensions" part of JA3 (so a TLS 1.2 and TLS 1.3 will have different fingerprints even if they are exactly the same apart from the version).


make zend-crypt optional

zend-crypt is rather optional, used in smtp auth only

Hello @glensc adds it as require-dev to fix the test suite..

tests should pass now, not sure how to force re-run them on travis

@glensc I re-executed the test on Travis now it's green, thanks!
Note: to restart a build on travis you need admin permission on the project.

@ezimuel this is a BC Break. You can't change require dependencies.

@Maks3w I disagree. SMTP authentication is a subset of the functionality, and requirements specific to it should have been considered optional from the outset.

@Maks3w this is not a BC break! The zend-crypt requirement is only for a specific functionality, including it in require-dev and suggest doesn't break default installations.

If you have a default installation and use the SMTP authentication feature next time you do composer update zend-crypt may to be removed and next deploy on production will fail because zend-crypt does not exists.
Removing require dependencies has the same effect as remove any class on the repo. We all agree any removal is a BC Break, the same is applicable to this.

@Maks3w only if you add the option --no-dev the require-dev packages are removed from the installation (please read composer doc). So the command composer update will not remove it. Again, this is not a BC break!

@ezimuel You are wrong for the following reasons.

Dev dependencies are not expected to be deployed on production (--no-dev)
Dev dependencies are only installed when required-dev in the root package (application)

I agree with @Maks3w, its a BC break, that being said I appreciate that it's been merged. Is the fact that its a BC break a problem? Tag it as next version up, and everything's gravy :)

to add some more oil to fire, it's even subset of SMTP Auth: Crammd5 support in SMTP Auth

@Maks3w let's put in this way, for the policy of the Zend Framework project, this is not a BC break! BC break means code that needs to be changed. This is only a requirement change, people needs (eventually) to execute a composer command to install the require-dev specific packages here. No code change.

They have to change their composer.json and modify the require section.

@Maks3w with code change I mean PHP code. I think we need to discuss this with all the Zend Framework members, we need a common position on the require-dev usage. We cannot have different opinions on this. /cc @weierophinney

Indeed.  My position is that anyone should be capable of update from one version to any most recent backward compatibility version without change nothing in the environment or the code (except Composer's lock file if exists)
Sorry but this implies PHP version changes or extensions version should be released as a mayor version.
Why we should do this? Because composer update should always install the latest version (except major versions) so anyone feel safe for jump from 1.0.0 to 1.99.99 blindly. This is critical when release security bugfixes. It's insane to think for install next backward compatibility version I must upgrade the server OS, recompile PHP or any other kind of time required and risky task.
We could argue LTS versions have this constraints in consideration but:

Security issues may exist only for the most recent non LTS versions.
Current LTS version is many years old.
Any stable version released is valid for deployment in production. Not only LTS versions.

All these principles applied to the current PR (guessing will be released as a minor or patch version) result in the following chain of events:

Add zend-mail in the required section of composer.json
Write unit tests and mock zend-mail following the best practices.
Send the  app for deployment.
CI green so deploy.
Application works fine.
This PR is released.
Now guess the application does not have composer.lock or zend-mail version is updated for any other reason (foo-baz require an updated zend-mail,  composer update,...)
CI green so deploy.
Application blowup. PHP Error Class Zend\Crypt... not found.

@Maks3w I can agree but I think you should start to use a language less aggressive. If you use terms like "it's insane" or "you are wrong" in your replies, I don't think this will help the community or the project. The usage of the right words is important and we should promote a more relaxed and civil code review, I think.

@ezimuel Thx. I'll try to improve my language

@Maks3w — I both agree and disagree.
When we bump to a new minor version, we are also signaling new features. Those may also include dependency changes; in point of fact, we've changed required PHP versions between minor versions several times, and removing or adding dependencies has also been done.
In most cases, one of a few situations will happen when that occurs:

Composer will refuse to update to the new minor version due to discrepancies in dependencies. This is reasonable; the user then has to opt-in to the new minor version by updating their own dependencies.
Composer will update to the new version, but code will not work as it had previously due to missing dependencies. This is sub-optimal, but provides us a chance to educate users as to the change and the purpose behind it. This information is usually communicated via the CHANGELOG; if a user raises an issue about it, we can point them to the release notes.
Users will indicate situations we were unable to foresee, and we will determine we need to rollback the change. This is a situation of last-resort, and has occurred very infrequently, though it has occurred.

In the case that a user has a composer.lock already, composer install will install the original dependencies and original versions. The only time the scenario you list above will cause an issue is on a composer update; best practices dictate that you should always run you project through CI whenever you do an update to detect such issues early. Deploying to production and using composer update (or composer install without a composer.lock file) is a recipe for problems, which is why the composer.lock file exists, and why install should always be used when readying an application for production.
As such, I definitely refute your assertion that we should not make PHP version or dependency changes in packages unless a new major version is being released. Doing so will stagnate the project and/or lead to version inflation. As a general rule, most such changes are fine for release with minor versions, unless a user reports a critical issue to the contrary. This is, and continues to be our policy, regardless of how you feel about it personally.
Now, all that said, this particular change, however, is one which is slightly more problematic, as, as you have noted, the zend-crypt functionality is not in a part you can usually mock with tests, which means it's an issue that likely will not be detected until production. As such, I agree that this particular change should be rolled back, for the stated reasons.


[lowering barriers] FAQ : add this in a cheat sheet / faq if possible.

This excellent summary from @Remi-Gau deserves to be highlighted somewhere like starter kit / tutorial

No need for a letter of intent.
Open an issue on the BIDS website where you mention these info for the BEP:
- number: 45 # 44 is the last so you are next
  title:
  link: # link to google doc or pull request
  content: # raw, derivatives, metadata
    -   raw
  leads:
  # MUST match given-names and family-names
  # from the list of bids contributors (see the bids specification citation.cff)
  # BIDS maintainers can add you in there if needed
  -   given-names: ' '
      family-names: ' '
  # Can have as many as you want
  # -   given-names: ' '
  #     family-names: ' '
  status: Just opened. New contributors welcome.
  blocking: # anything blocking the development of the BEP. If not leave emtpy.
  google_doc_created:
  pull_request_created: # leave empty for now
  pull_request_merged: # leave empty for now

Also something I'd like to start having for each BEP is a communication channel (discord, mattermost, slack...) - should probably be mentioned in the google doc of the BEP.
See here to see how other BEPs are 'described'.
https://github.com/bids-standard/bids-website/blob/main/data/beps/beps.yml

Originally posted by @Remi-Gau in #1675

I can try creating a github issue form for this actually.

I think the BEP process pages will go through a complete overall anyway


Thank you for providing the code, can you expose the preprocessed dataset

Looking forward to your reply. Thank you very much.

In our paper, we use a publicly available dataset (OASIS), but we don't have the right to redistribute it. If you are interested in the preprocessed dataset, you may download it via https://www.oasis-brains.org/ (make sure you download the preprocessed version and you still need to further preprocess it, e.g. center cropping/changing the orientation). An example of the preprocessed data is provided in the "Data" folder in this repository.

Thank you very much for your help. I'm sorry to ask you the basic question.I have successfully downloaded part of the data set. Whether norm. MGZ and ASEG.mgz under mri/ folder respectively represent the image and segmentation that you will further process before. Can further pre-processing code be provided?

Thank you very much for your help. I'm sorry to ask you the basic question.I have successfully downloaded part of the data set. Whether norm. mgz and aseg.mgz under mri/ folder respectively represent the image and segmentation that you will further process before. Can further pre-processing code be provided?

Currently, we have no plan to publish the code for pre-processing. If you want to try our SYMNet, you could resize/crop the pre-processed data using Numpy and NiBabel. As long as your GPU has enough memory, you are good to go.

Thank you very much for your help.


Enhancement deploymentMetricsAggregator for Topologyspreadconstraint

What would you like to be added:
I would like to add Topologyspreadconstraint to deployment of /splunk-kubernetes-metrics/templates
topologySpreadConstraints:
- maxSkew: 1
  topologyKey: topology.kubernetes.io/zone
  whenUnsatisfiable: DoNotSchedule
  labelSelector:
    matchExpressions:
    - key: app
      operator: In
      values:
      - {{ template "splunk-kubernetes-metrics.name" . }}

Why is this needed:
You can use topology spread constraints to control how Pods are spread across your cluster among failure-domains such as regions, zones, nodes, and other user-defined topology domains. This can help to achieve high availability as well as efficient resource utilization.

Don't expect anything. This chart is deprecated and superseded by the new Splunk Otel Collector: https://github.com/signalfx/splunk-otel-collector-chart/


why this is the self.etaX.T.dot(errors) rather than the -self.etaX.T.dot(errors)

thanks for your book,i have a small question by reading chapter 2
by its defination , i think the negative symbol is necessary.

你好，邮件已经收到，将尽快给你回复。


fix $id of schema testsuiterunfinished

The run is missing in $id of schemas/testsuiterunfinished.json
"$id": "https://cdevents.dev/0.4.0-draft/schema/test-suite-finished-event",

Thanks @davidB - nice catch, it would be nice to have this fixed in v0.4 if you are interested in contributing a fix.


Tagchanges

Modifications to dls_ade to enable dls_release.py to tag a commit, prior to release.
New argument added '-s' (--sha)
e.g.
dls-release.py <module> <tag> -m "user message" --sha <commitID>

If a --sha argument is not given - the script will proceed as before provided the tag ('release') already exists. (If the tag does not conform to the convention, the script will produce a warning - but still go ahead as before.)

If a --sha argument is given, and tag is of the permitted format, and does not already exist - the script will first apply the tag at the commit ID before proceeding. The script will abort if the tag already exists.

(New script added) tags must be of the form: X-Y[-Z][dlsA[-B]], where X, Y, Z, A & B are integers.
The commit message upon tagging is of the form:
DLS Release {tag}: {user message}

Coverage decreased (-0.5%) to 87.603% when pulling fe49208e44613df82e01527fd64e0dc8362d0c09 on tagchanges into e5ea7c0905a674a79523d9fa092c4f0c8719699e on master.

Thanks for the review - changes made.

Now rebased and with a tidy up of the dls_utilities imports.

Modifications have been made to incorporate the needs of CGP-90 - enabling test on build server without a git tag.
If the release positional argument is missing, but the -T flag is used and --commit / -c set - the test build will checkout and build the module at the commit.
Modifications were required to the scripts in Linux/*.sh as discussed in CGP-90 (git clone, then git checkout - to replace the previous clone, fetch depth=1 then checkout commands):

I have tested with example commits in dls_ade, using the python.sh script
The git commands worked for the test cases - but I'm new to git, so there may be a flaw in the modifications to the commands that I'm not aware of?
Do the Windows scripts still work / need modifying?

Modifications to:

Allow a clone all iff running at test build; this will allow git checkout SHA to find the relevant point
Restore production build behaviour to previous behaviour (clone depth=100, follow by fetch depth=1)

Do the Windows scripts still work / need modifying?

Yes, good point: don't forget the windows scripts, please. These are almost more important to enable test-builds for as Windows builds are often quite a bit more difficult than Linux builds...

Windows scripts have now been updated.

@gilesknap worth giving this a test with your current example of where this would be useful?

Branch has been rebased.