QTree issues

Continuing my exploration of Quasar components: QTree.
Observations FYI (but might all be already known):

selection, ticked, expanded will not work directly because of the two-way sync requirement. However it can be more or less worked around by using event handlers.
content customisation won't work due to the use of slots with props.
for some reason setting the default_expand_all property to False (or 'false') does not work
self.run_method('expandAll ()', msg.websocket) does not work

My code:
class MoviesTreePage(BasePage):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)

        self.nodes = []
        self.expanded = []
        self.selected = None

        async def on_click0(comp, msg):
            # does not work yet
            await self.run_method('expandAll ()', msg.websocket)
            await self.update()

        async def on_click1(comp, msg):
            self.tree.expanded = []
            await self.update()

        async def on_click2(comp, msg):
            self.tree.expanded = ['B']
            await self.update()

        self.btn0 = jp.QBtn(a=self, text='Expand all', click=on_click0)
        self.btn1 = jp.QBtn(a=self, text='Close all', click=on_click1)
        self.btn2 = jp.QBtn(a=self, text='Open B', click=on_click2)

        async def on_expanded(comp, msg):
            logger.info('EXPANDED %s', msg.value)
            self.expanded = msg.value

        async def on_selected(comp, msg):
            logger.info('SELECTED %s', msg.value)
            self.selected = msg.value

        self.tree = jp.QTree(a=self,
                             # nodes=self.nodes,
                             node_key='label',
                             # expanded=self.expanded,
                             selected_color="primary",
                             default_expand_all=False,
                             )
        self.tree.on('update:expanded', on_expanded)
        self.tree.on('update:selected', on_selected)

        self.load_data()

    def load_data(self):
        self.nodes = [
            {'label': 'A',
             'icon': 'restaurant_menu',
             'children': [
                 {'label': 'Prompt attention'},
                 {'label': 'Professional waiter'}
             ]},
            {'label': 'B',
             'icon': 'photo',
             'children': [
                 {'label': 'Good table presentation', 'icon': 'restaurant_menu',},
                 {'label': 'Pleasing decor'}
             ]},
            {'label': 'C',
             'icon': 'room_service',
             'disabled': True,
             'children': []},

        ]

        self.tree.nodes = self.nodes

I think the problem may be that you have an extra space in:
await self.run_method('expandAll ()', msg.websocket)
Should be:
await self.run_method('expandAll()', msg.websocket)
This program works for me:
import justpy as jp

async def expand_tree(self, msg):
    return await self.tree.run_method('expandAll()', msg.websocket)

async def collapse_tree(self, msg):
    return await self.tree.run_method('collapseAll()', msg.websocket)

def tree_test():
    wp = jp.QuasarPage()
    d = jp.Div(classes="q-pa-md q-gutter-sm", a=wp)
    node_string = """
    [
        {
          label: 'Satisfied customers (with avatar)',
          avatar: 'https://cdn.quasar.dev/img/boy-avatar.png',
          children: [
            {
              label: 'Good food (with icon)',
              icon: 'restaurant_menu',
              children: [
                { label: 'Quality ingredients', icon: 'favorite' },
                { label: 'Good recipe' }
              ]
            },
            {
              label: 'Good service (disabled node with icon)',
              icon: 'room_service',
              disabled: true,
              children: [
                { label: 'Prompt attention' },
                { label: 'Professional waiter' }
              ]
            },
            {
              label: 'Pleasant surroundings (with icon)',
              icon: 'photo',
              children: [
                {
                  label: 'Happy atmosphere (with image)',
                  img: 'https://cdn.quasar.dev/img/logo_calendar_128px.png'
                },
                { label: 'Good table presentation' },
                { label: 'Pleasing decor' }
              ]
            }
          ]
        }
      ]
    """

    b1 = jp.QBtn(label='Expand', a=d, click=expand_tree)
    b2 = jp.QBtn(label='Collapse', a=d, click=collapse_tree)

    tree = jp.QTree(a=d, node_key='label', nodes=node_string, tick_strategy="leaf", no_connectors=False, default_expand_all=False)
    d1 = jp.Div(text='', a=d)
    def my_updated(self, msg):
        print('in my updated')
        d1.text = str(msg.value)
    tree.on('update:ticked', my_updated)
    b1.tree = tree
    b2.tree = tree
    return wp

jp.justpy(tree_test)

Please let me know if this does not solve the problem.
As for default_expand_all, i need to look into it. Thanks for catching this.

No it was not the extraneous space; javascript accepts all kinds of weirdness ;-)
But your example pointed me in the right direction: I should have written return
await self.tree.run_method('expandAll()', msg.websocket)

instead of:
return await self.run_method('expandAll()', msg.websocket)

Thx!

BTW would it be possible to support methods like expandAll by default? So that a user would have to do the run_method thing?

Thank you, I didn't know that about JavaScript....
Now that I look at it again, I think the problem is the page update that you also had. That reset the page to its previous state.
Yes, I will add the methods. There are so many of them, so it will take some time.

Thank you, I didn't know that about JavaScript....

It is usually the linter that fussy. I usually put his at the end of Quasar's eslintrc.js:
    // MJM
    'indent': 0,
    'no-multiple-empty-lines': ["error", { "max": 2, "maxEOF": 1 }],
    'comma-dangle': 0,
    'semi': 0,
    'prefer-const': 0

Makes javascript much more palatable.

Now that I look at it again, I think the problem is the page update that you also had. That reset the page to its previous state.

No, I have the component update still in, and it works. The call is superfluous but does not harm either.

Yes, I will add the methods. There are so many of them, so it will take some time.

Need help?
I suppose only methods that do not return anything can be supported at this time, right?

Yes, I would appreciate help with this.
The return value of the methods is ignored at this time, though they will be run.

The default_expand_all bug is fixed in the new version 0.1.2

Thx


Show 'Edit Property Value' rather than 'Edit Entity Value'

Storage Explorer Version: 1.8.1_master_20190619.4
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Commit: 952cf5dc
Regression From: Not a regression
Steps to reproduce:

Expand one account -> 'Tables' node.
Open one table -> Click 'Add' button to add an entity.
Click 'Add Property' on the opened 'Add Entity' dialog.
Click 'Edit Property' next to the added property.
Check title of the second page of the 'Add Entity' dialog.

Expect Experience:
There shows 'Edit Property Value' on the second page of the 'Add Entity' dialog.
Actual Experience:
There shows 'Edit Entity Value' on the second page of the 'Add Entity' dialog.

Fix should be in the daily build now.

This issue has been fixed on latest master build 20190709.5. So closed it.

This issue reproduces on main/host build 20190709.6. So reopened it.

This issue has been fixed on feature/main-host build 20190711.2. So closed it.


feat(apps/prod/tekton/configs): delete useless param tag for task run-building-scripts-for-images

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve


feat: add possibility to define scope of registered dependencies

As transient (default)
As scoped (must be configured)

Relates to #13


Image preview is inconsistent with result after uploading

From @1j01 on June 28, 2016 23:36
If you select a transparent image, it shows it on a white background. After uploading, you get an opaque image with a black background. For GIFs it shows the preview like animation is allowed, but it's not. If an image is uploaded that lacks an extension, the preview doesn't show up, but it does work when uploading. Finally, the sizing of the image is completely different in the preview (full image shown with it's native ratio) from the resulting card when uploaded (fills available fixed area, usually cutting some off).
Copied from original issue: firebase/friendlypix#19

From @1j01 on June 29, 2016 19:47
I think this demonstrates the issues pretty well (transparency, animation, and sizing):

Yes I confirm we should fix this and have a preview that's what the final result will look like. Thanks for reporting


Sort file by reverse lexicographical order before tailing them

What does this PR do?
Sort file by reverse lexicographiccal order before tailing them. The heuristic is that filenames often contain a datetime information
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2796 into master will decrease coverage by <.01%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage      57%   56.99%   -0.01%
==========================================
  Files         383      383
  Lines       24614    24627      +13
==========================================
+ Hits        14031    14037       +6
- Misses       9655     9662       +7
  Partials      928      928

Impacted Files
Coverage Δ

pkg/logs/input/file/file_provider.go
74.74% <46.15%> (-4.33%)
:arrow_down:


Update supported Python versions

Coverage remained the same at 100.0% when pulling 18b6653621f8ff8320e9cde44c0cebe9cc9c6aae on leovp:master into 7dda39b30172f6b55966deb8c42c8f83415ef7ff on cypreess:master.


Scons fails to detect libpng library on CentOS 6

This issue comes up a lot because a default g++ compiler is not installed when following the build setup instructions for CentOS 6. I don't believe this issue comes up in RHEL 6 because it's included with a documented package. Furthermore, even when fixing the issue it still will need to rescan for the configs (--config=force on the scons command line). This should happen by default since the time to do the scan is negligible.
Reproduction steps

Create CentOS 6 minimal VM
Follow manual build setup instructions
1.Build using scons

Expected: build completes without error
Actual: Error message saying that it can't find libpng12
AC

Update build instructions to include default g++ for CentOS 6 (gcc-g++ package) or update scons to use devtools g++ install
Add a check to scons for a g++ compiler and output an appropriate error if it can't find one
Update scons to always scan for libpng (it may be possible to disable caching)

Have you timed how long it takes to rescan for all the libraries used in a build?
I think the proper fix is to update SCons scripts to report a proper error when they can't find a compiler, instead of making strange assumptions, continuing, and outputting hard to decipher message.

I didn't bother timing because it's probably less time than it takes to print the message to the console.

Scanning for libraries involves running GCC for every header, and dynamic library you're testing for.  That usually takes, at least, a few minutes for all the libraries used by GEE.

I ran some tests. It looks like the --config=force flag works well for the third_party target, but I got an error for the default build target. Here are the results on the third_party target. If we just stick to that, I don't think we'll add to the total build time. And the build will stop if it can't find the library on the third_party target.
ccamp@Mainframe:/opt/dev/tst/earthenterprise/earth_enterprise/src$ time scons -j12 release=1 --config=force third_party
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir keyword instead.
File "/opt/dev/tst/earthenterprise/earth_enterprise/src/SConstruct", line 507, in <module>
Checking for C library gtest... yes
...
scons: done building targets.

real	0m4.143s
user	0m4.104s
sys	0m0.168s

ccamp@Mainframe:/opt/dev/tst/earthenterprise/earth_enterprise/src$ time scons -j12 release=1  third_party
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir keyword instead.
File "/opt/dev/tst/earthenterprise/earth_enterprise/src/SConstruct", line 507, in <module>
Checking for C library gtest... (cached) yes
...
scons: done building targets.

real	0m4.122s
user	0m4.068s
sys	0m0.192s

:+1: Looks good to me.


Set hasSampleData to false for all scratch org definitions

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

@codexmarcel I noticed a failing Robot test on this PR and that seems to be a valid one. It looks like for Accounts object it is missing My Accounts view option.


Generic package

Added the ability to build a generic Lambda package. The Lambda function retrieves its parameters at runtime from the AWS Systems Manager Parameter Store and AWS Secrets Manager. Also added a Lambda package for rotation of the RSA keys.
GitHub does not show the differences in build/build.js very well. I suggest using a different tool to view the changes for this file.
Also added GitHub CI and release workflows for generic packages.

My only concern about getting parameters from the parameter store is that the users may need to find another tool/mechanism to store the parameters into the parameter store.

I tried using environment variables for parameters but they're not supported for Lambda@Edge.
Most users would already be using a tool such as Terraform or CloudFormation to deploy their CloudFront distribution and Lambda function. But if they are manually deploying these then yes, they will also have to manually deploy the parameters/secrets.
I think generally users would want the parameters/secrets to be owned by Terraform or CloudFront so that their lifecycle is managed automatically, e.g. deleted when the CloudFront distribution is deleted. It also lets them set attributes such as tags and rotation rules in a consistent manner.


Download files

good afternoon, is there a way for the files being downloaded to add a naming such as _temp _part etc... until the download completes?

I believe so, can you share your code so far please?

There's no built-in feature to append '.tmp' to files while they're downloading. There was a feature request for it but I haven't implemented it yet. If you're interested in writing this support let me know and I can give you some pointers on how it could be implemented

I had a feature branch where I was implementing this, so I just went and completed it. I've just merged that capability to master :)
https://github.com/alanmcgovern/monotorrent/pull/445


PR #96673 - backup: fail instead of pausing when out of retries

Related PR: https://github.com/cockroachdb/cockroach/pull/96673
Commit: https://github.com/cockroachdb/cockroach/commit/8f8767c842b917697444acbd7739fa141502bce6

Release note (ops change): a BACKUP which encounters too many retryable errors will now
fail instead of pausing to allow subsequent backups the chance to succeed.

@kathancox looks like this issue got lost in docs triage


Feature Request: Client-side save system.

Can probably be done with static methods on a new class.

Please write down more information about this feature request.
What is it about, what are the use cases, what will it improve?

Closed by #61


[SMALLFIX] Minor fix.

This PR fixes style violations and capitalization.
@yupeng9 Should we get rid of the "Called via ..." comments? I understand that the original motivation was to make the code more readable, but as the code evolves, such comments become out of date and possibly incorrect, which can in fact hurt the readability.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7773/Build result: FAILURE[...truncated 3396 lines...][JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.9.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-s3/0.9.0-SNAPSHOT/tachyon-underfs-s3-0.9.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.9.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-s3/0.9.0-SNAPSHOT/tachyon-underfs-s3-0.9.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/s3/target/tachyon-underfs-s3-0.9.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-s3/0.9.0-SNAPSHOT/tachyon-underfs-s3-0.9.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/pom.xml to org.tachyonproject/tachyon-clients/0.9.0-SNAPSHOT/tachyon-clients-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/pom.xml to org.tachyonproject/tachyon-client-unshaded/0.9.0-SNAPSHOT/tachyon-client-unshaded-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.9.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client-unshaded/0.9.0-SNAPSHOT/tachyon-client-unshaded-0.9.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.9.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client-unshaded/0.9.0-SNAPSHOT/tachyon-client-unshaded-0.9.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.9.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client-unshaded/0.9.0-SNAPSHOT/tachyon-client-unshaded-0.9.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/pom.xml to org.tachyonproject/tachyon-servers/0.9.0-SNAPSHOT/tachyon-servers-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/pom.xml to org.tachyonproject/tachyon-underfs-hdfs/0.9.0-SNAPSHOT/tachyon-underfs-hdfs-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.9.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-hdfs/0.9.0-SNAPSHOT/tachyon-underfs-hdfs-0.9.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.9.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-hdfs/0.9.0-SNAPSHOT/tachyon-underfs-hdfs-0.9.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.9.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-hdfs/0.9.0-SNAPSHOT/tachyon-underfs-hdfs-0.9.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/pom.xml to org.tachyonproject/tachyon-parent/0.9.0-SNAPSHOT/tachyon-parent-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/dependency-reduced-pom.xml to org.tachyonproject/tachyon-client/0.9.0-SNAPSHOT/tachyon-client-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.9.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client/0.9.0-SNAPSHOT/tachyon-client-0.9.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.9.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client/0.9.0-SNAPSHOT/tachyon-client-0.9.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.9.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client/0.9.0-SNAPSHOT/tachyon-client-0.9.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/shell/pom.xml to org.tachyonproject/tachyon-shell/0.9.0-SNAPSHOT/tachyon-shell-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.tachyonproject/tachyon-underfs-glusterfs/0.9.0-SNAPSHOT/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.9.0-SNAPSHOT/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.9.0-SNAPSHOT/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.9.0-SNAPSHOT/tachyon-underfs-glusterfs-0.9.0-SNAPSHOT-javadoc.jarchannel stopped
Test FAILed.

@yupeng9 the checkstyle rule seems to be in conflict with the javadoc guidelines we have ... in particular, if the @return statement consists of multiple sentences, then the last sentence should end with '.'

I think @return is preferred to have a single sentence. For example, the doc in this PR could be rewritten to the set of inode ids which are pinned; called via RPC.
And the current rule doesn't enforce it if the state is multiple-line.
On a side note, I agree with you that called via is not necessary, and could be removed. Thanks.

Yeah, you can get rid of the "called ..." parts.

@yupeng9 @gpang thank you for your feedback, I removed the "called ..." parts ... PTAL

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7816/
Test PASSed.

Some of the method level comments are redundant of the @return lines (mainly the get* methods). Can those be removed?

@gpang done

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7833/
Test PASSed.

LGTM.


Apostrophe type must match same style in name of area/entity/etc.

I run into this apostrophe issue in almost all of my requests, particularly when I am typing them out on mobile, but that may be more due to me just using it more on mobile than desktop.
It looks like was referenced in #1353 but it felt reasonable to open a new issue on this specifically.
Most often it’s autocorrect formatting the apostrophe as ‘ by default, and not necessarily more/less prominent for me whether I’m using mobile or desktop apps, browsers, or something like my iOS Shortcuts app for passing text commands to Assist. And this is mostly the same for iOS or macOS dictation inputs in the same spots.
Many of the areas and devices I have belong to “someone” so the possessive is used in the majority of the entity names being interacted with through Assist.
Ideal world:
The area called "Kyle's Office" (non-curly apostrophe) would be recognized when input is any iteration of apostrophes:

Kyle's Office
Kyle’s Office
Kyles Office

This feels like a small-but-important case to handle for the people in my home that would be willing to learn specific incantations for wording these requests, but they would be put off by having to take into account different types of punctuation for a request that’s otherwise well-formed (i.e., this would be a pretty large barrier to folks who doesn’t want to “deal” with knowing the single quote style of ‘ vs ' in their requests, nor having to think about the inconsistencies when naming or re-naming their new entities using different styles).

Hey @kylehakala this should have been fixed a while ago through https://github.com/home-assistant/hassil/pull/137
Can you please confirm and close the issue if so?


Standalone browser versions of all libraries

Currently, several modules have UMD versions generated using Webpack:
https://github.com/accordproject/concerto/blob/b05be1d6b619fcadd098b538b85895149ab6ac1d/packages/concerto-core/package.json#L14
https://github.com/accordproject/concerto/blob/b05be1d6b619fcadd098b538b85895149ab6ac1d/packages/concerto-tools/package.json#L13
Only concerto-core has the browser key set though.
However, in order to get this library integrated into a React application, I had to add the following polyfills and globals:
const webpack = require('webpack');

module.exports = function override(config) {
  const fallback = config.resolve.fallback || {};
  Object.assign(fallback, {
    path: require.resolve('path-browserify'),
    fs: require.resolve('browserify-fs'),
    url: require.resolve('url/'),
    util: require.resolve('util/'),
    os: require.resolve('os-browserify'),
    stream: require.resolve('stream-browserify'),
    buffer: require.resolve('buffer/'),
    // crypto: require.resolve('crypto-browserify'),
    process: require.resolve('process/browser'),
  });
  config.resolve.fallback = fallback;
  const plugins = config.plugins || [];
  plugins.push(
    new webpack.ProvidePlugin({
      Buffer: ['buffer', 'Buffer'],
      process: ['process'],
    })
  );
  config.plugins = plugins;
  return config;
};

This may be as simple as ensuring that all of our modules include UMD generated versions, rather than anything wrong with the Webpack configuration.

Hi, is this issue still open

Hi, Can I work on this issue? I have decent experience in this tech-stack. So, Please can you assign it to me?

I would like to request yout to assign this issue to me related to integrating the concerto library modules into a React application.
Issue Summary:
Several concerto modules (such as concerto-core and concerto-tools) require UMD versions generated using Webpack for browser compatibility. Currently, only concerto-core has the browser key set. To integrate these modules into a React application, additional polyfills and global variables are necessary due to missing Node.js core modules in the browser environment.
My Solution:
To resolve this issue, I plan to:

Ensure that all concerto modules include UMD-generated versions.
Modify the Webpack configuration to add necessary polyfills and globals for Node.js core modules.

I am confident that this approach will ensure seamless integration of the concerto modules into the React application. Please let me know if you need any additional information or have any concerns regarding this request.

https://github.com/accordproject/concerto/pull/964#issue-2719984009
@sstone1


Change plugin name based on debrid service or support multiple services in same instance

Hi!
Thanks for all your work on such a useful addon.
Would it be possible to use a similar approach as torrentio which renames the installed addon name based on the configured debrid service?
E.g. 'Debrid Search RD' 'Debrid Search AD' etc. This would make it easier to identify and manage any installed addons.
Torrentio also allows you to alternatively configure multiple debrid services at same time and names them as 'Torrentio RD/AD' that would be even more awesome if possible!

Yes, that should be possible to implement


[USERSNAP] Hello, when I try to 'find a DRep' using the searchbar using this ID drep14pjm8ytt682wkp4jcegdj2yerkcy9a20xevvp7udlcd0ggjxdud nothing shows but it looks like the correct ID since it's working here: https://gov.tools/drep_directory/drep14pjm8y...

Taken at: https://sanchogov.tools/connected/drep_directory
Fields:

Add a comment: Hello, when I try to 'find a DRep' using the searchbar using this ID drep14pjm8ytt682wkp4jcegdj2yerkcy9a20xevvp7udlcd0ggjxdud nothing shows but it looks like the correct ID since it's working here: https://gov.tools/drep_directory/drep14pjm8ytt682wkp4jcegdj2yerkcy9a20xevvp7udlcd0ggjxdud

Browser: Chrome 130 (macOS Catalina)
Screen size: 1901x954
Open #161 in Usersnap
Powered by Usersnap.

Not reproducible, tried several times, and it shows the results.


Add a phone identifier?

Hi I'm working on a new tracking map website that allows multiple people to share their location on the same map. The problem I've got is Overland doesn't seem to give any actual device ID at all. Only what the user configures as 'device ID'.
The problem comes if 2 people enter the same 'device ID', there's no way to identify that the devices are not the same device. For example if someone uses "TIM" as the device ID, and then someone else over the other side of the world uses "TIM", both person's location would jump from one position to the next constantly as data comes in.
I could get around this by issuing people a device ID they have to use, but that makes life trickier for the end user. What I'd like to do is use the app's 'device ID' field as a label of the users choosing. And have an actual device ID to identify devices apart from each other.
Now for privacy reasons, you can't get the iPhone's device ID any more, but Apple has allowed a similar ID that is unique to a 'developer' on that particular device. Perfectly good for my purposes. Read how to get it here for swift at least:
https://stackoverflow.com/questions/25925481/how-to-get-a-unique-device-id-in-swift
It would be very handy if that developer/device ID was available in the API data sent.
Cheers!

Thanks for implementing!

Cool! I just added a link to your site to the readme too!


Quick fix for common user error - not seeing log files to open because wrong track is selected

I've fallen for this mistake too - clearly needs UI improvement - as minimum, something on the Open File dialog to remind user if they are not seeing all their files, then select another track ......

Finished a quick fix to display simple warning in red text if open files is not showing all files in the current directory (i.e. because some or all of them are for a different track)


Program enrollment

When a program enrollment is cancelled and then updated, it should:
delete all the courses enrollment associated with the PE
re-create all the course enrollment associated with the amended PE

so need to add somewhere
def on_cancel(self):

Next things is ...  does it matter?
Where does it matter?  For which doctype does these extra course enrollment will have an impact?


Move Pfim to DLLS directory

DLL was placed in XenoKit Directory which isn't included in the repository

Ah so that is what that was all about. Someone else had an issue with Pfim not being found and I just hadn't looked into it yet.
I just reinstalled the package in the main project to fix it, which put the files in the correct place (XV2-Tools/packages).


Export equal from option-t/PlainOption

Let's do same with https://github.com/option-t/option-t/pull/2138


HAWKULAR-784 - Enable compression for serving the Hawkular UI from Undertow

…dertow

LGTM: Looks like it took the main hawkular js codebase: hawkular-console.js from 444 Kb to 72 Kb.
Not too shabby. :+1:

Merged #820


An unarmed combat proficiency and for other less common tools. Hoe maybe should be treated as a scythe in combat.

Just want a shovel combat skill lmao

wdym, can you tell what do you want?


The type defined on the type does not take effect

I used type to define a type, but even if I added a comment, I can't find the corresponding content in the generated document. Is my annotation wrong? How can I use it?

Source
/**
 * 提供者函数，用于生成任意值的函数
 * @typeparam R 返回结果类型
 * @returns 返回结果
 */
export type Supplier<R> = () => R

Sorry, I can't provide an online example at this time. . .

Duplicate of #983


A few more yml updates

Swapping a few more ci.yml files to extends vs stages at their root.
Follow-up from #22590 and the follow-up commit
Not certain how it escaped the first ctrl-shift-f, but they did!

/check-enforcer override
Unrelated failure.


Proper handling when trying to read a non-existing file

In relation to https://github.com/microsoft/markitdown/issues/40 , instead of UnboundLocalError, indicate that you are trying to access a non-existing file.

@microsoft-github-policy-service agree


#77 Header UI becomes distorted in tablet view

Before

After

Close #77

Also, some rebase needed.

Hey guys! @dandheedge, @nevendyulgerov. Before we merge it, Does it not strike as odd to have just the jazzicon/identicon in the small version of the menu? So maybe the thing should be that the wallet connect button should not be displayed in the side menu on a medium breakpoint but only when it opens from the Hamburger icon.

Hey guys! @dandheedge, @nevendyulgerov. Before we merge it, Does it not strike as odd to have just the jazzicon/identicon in the small version of the menu? So maybe the thing should be that the wallet connect button should not be displayed in the side menu on a medium breakpoint because the element gets squeezed but only displays it when it opens from the Hamburger icon, which means a sm | xs breakpoint.

I managed to create custom media queries to accommodate the dynamic display of the wallet button, enabling its visibility or hiding it based on viewport @brunomenezes @nevendyulgerov
Viewport smaller than 768px

Viewport between 768px - 799px

Viewport larger than 800px


Duplicated block function unification suggestion

Laravel Version: 5.5.*

Description:
While reading documentation about queues I have found funnel method, which under the hood uses ConcurrencyLimiter class, but as I remember same block mechanism already exist in abstract Lock class
but first is more advanced and reusabel due multiple locks usage.
I think ConcurrencyLimiter could extend Lock maybe, but Lock@block should retake improvements   from ConcurrencyLimiter@block

Feel free to submit a PR!


README

#README
##User Story
As a Web Develloper,
I want the client site to be structured on a webpage,
So that I can easily find and read the information.
##Acceptance Criteria
GIVEN the code-refactor-challenge repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

I replaced it with a good readme wich follows rules.


SerializationException thrown from Mumble Link

Occasionally, a SerializationException is thrown from the PlayerService class when attempting to read data from the mumble interface.
This appears to be caused by a race condition where the GW2 interface is writing new data to the mumble memory-mapped file at the same time the PAO is attempting to read from it.

Fixed with commit dbef08cb56074bd53274b09d2ce0cfa584bf823e. Release is still pending.


Remove unnecessary routes

✅ Ready to merge ✅
This PR will remove all unnecessary routes from user-service & cleanup relevant files

LGTM!


Missing header in pairwised filter

Hi,
I found that the output FASTQ contains missed header after pairwise filtering, liek this:
@V300010089L2C001R018264378/1
AAAGAAATTTAATAATTTTGAAAATGGATTTTTTTTTTTTGTTTGGGCAAGAGCATGAGAGCTTTTACTGGGCAAGAAGGCAAGAGTTGGAGAGTCCAGCCGGGCCTGCGCTTAGGTGGCCGGCCTTGCTAGGCTT
+
GF<GFF+GFE5EF>E>AFFGE/,<F<A;?>+><(FG<0F<E'@F(GFFG@F3AG>5G7@,==:)E=<:GF>9E:F/E3B(68FG7F,CGD.=8G-=98/FFFADB453G1CG3B+F=@0*@DF,EG@7D6,>B:G)
+
FFFECFFFCFFFEFEFFFFFFEFFFFFFFAFFDFBFDFCFAFFFFF>FFFFFFFFEF>FFFFFFF>EFFDABAFFFFFFEEFFFFE:=D0FGFFFFF;EEEFF.F>FFFFBFFDFFFF>GD6@FFDFFEF<DFF
@V300010089L2C001R018268234/1
GGTCATTTAGAGGAAGTAA
+
DBFBFFFFFFFF<FGDFFF
It seems that the second record got its header chop off for some reason, any ideas? This causes fatal error for downstreams.
p.s. I just noticed that the read number is also wrong, at least for the pairwise option.
Thanks!

Is the FASTQ standard?


Added EtherCats Founders Series NFT strategy [ethercats-founders-series]

Added updated strategy under the correct name (plural 'S' in Founders) as not to break existing proposals using the old strategy. The old strategy was not scalable.

Notes for me:
This strategy is the new version of https://snapshot.org/#/strategy/ethercats-founder-series
we can retire https://snapshot.org/#/strategy/ethercats-founder-series this strategy once the new strategy is live (should find out how)


In game description shows old versions

The in game description which can be viewed in ModMenu shows versions up to Minecraft 1.16 as seen in screenshot below:

Just out-dated info is all, will be updated at some point but it doesn't affect anything.


Question: How do I use functions for Dictionary?

I built Argo.framework with Xcode 7C46t and Carthage 0.9.4 and set it in Linked Frameworks and Libraries ,
but I can't call <^> in https://github.com/thoughtbot/Argo/blob/master/Argo/Extensions/Dictionary.swift
I can use the functions in the other files.
let a: Decoded<Int> = .missingKey("") //OK

however I failed in calling + and map in Extensions/Dictionary.swift .
let b = ["one": 1] + ["two": 2] //Binary operator '+' cannot applied
let c = ["three": 3].map //Xcode suggests only this closure: ((String, Int)) throws -> T

Do I forget some settings or use these functions mistakenly?

These function are not exposed as public in Argo. That's why you can't use them.

Can I set public ? Or I will make my own functions if you have the reason they need internal .
I want to get [String: Decoded<Decodable>] , not Decoded<[String: Decodable]> .

As noted in the proposed PR, I think it's outside Argo's scope to provide these. We kept them internal because we need them for our own implementation, but polluting the public scope with them seems like a bad idea. If you need these functions, I'd recommend either writing them yourself or finding a library that provides these functions for you.


Existing model state errors are cleared

Hi,
I use aspnet core mvc and have a custom model binder that might add model errors to the model state. When fluent validation executes, existing error messages in model state are cleared.
Is there a way for me to keep the messages added earlier in the pipeline?`
Best regards

No, that's not something that's currently supported. You can't mix different validation strategies for the same model with FV's aspnetcore integration.


Get dandiset endpoint

Create an API endpoint which takes a dandiset ID, and some optional parameters.
It returns (type: a girder folder document):

The latest published dandiset, if no options were passed.
If the option for a version was specified, return that version.
The above option could also include the staging version.

For the first implementation I think we should just deal with the staging side of things, because we haven't defined how to version the published dandisets (in terms of their server side implementation).


Implicit behavior for Counter metric

I recently noticed that the reporter throws away the measurement field of Counter metrics. This can lead to some surprising outcomes.
As an illustration, consider the following metric definitions:
# Metrics to be passed to the TelemetryMetricsStatsd reporter.
metrics = [
  Telemetry.Metrics.counter([:foo, :bar, :baz], tags: [:a, :b]),
  Telemetry.Metrics.counter([:foo, :bar, :bat], tags: [:b, :c]),
]

Based on my understanding of the current implementation of the handle_event/4 function, the following code would trigger a metric to be published for both of the above metrics (one of which would have the incorrect tags and, I think, may actually cause the handler to detach):
:telemetry.execute([:foo, :bar, :baz], %{}, tags: %{a: 1, b: 2})

This can be avoid if you explicitly pass the event_name option, or if you ensure that the default event_name of your metric is unique (ie using the count suffix on everything would do the trick).
I am struggling to quickly reproduce this in the tests for this project (without explicitly specifying event name), but in that case it's simply not publishing anything so it may be a separate problem. I can revisit and try to break things properly over the weekend.
But the offending code seems to be: https://github.com/arkgil/telemetry_metrics_statsd/blob/0f79e2af612caa834ac522da2f6209cd930f5967/lib/telemetry_metrics_statsd/event_handler.ex#L88-L91
The counter here will loop through every metric with the shared prefix and publish a payload without ensuring that the metric in question matches the measurement of the fired event. Contrast this with the Telemetry.Metrics.ConsoleReporter module which will return nil in its fetch_measurement/2 equivalent and not publish if the event_name is the same but the measurement is different: https://github.com/beam-telemetry/telemetry_metrics/blob/v0.3.0/lib/telemetry_metrics/console_reporter.ex#L98
This behavior can be mitigated by post-fixing all counter metrics with.count, but that is not explicitly mentioned in the documentation (that I have been able to find).
If there's something going on that I'm just completely missing, I would be very happy to be wrong here 😄
PS. If you know how to get tests to work without explicitly specifying the event_name option to given_counter, it would help me reproduce this with a test faster. My initial discovery was from a test reporter module I wrote by copy-pasting the bones of this reporter. So while I am not certain this bug exists, I'm very suspicious.

Some rewording of the docs would probably be sufficient for now?


Does not work with Svelte files

css class completion version 1.18
vscode version 1.33.1
"css.remoteStyleSheets" : ["https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css"] it's doesn't work with Svelte files

Hi there @Narungsih, would mind giving me a short explanation of what is "Svelte files"? Is it some sort of CSS framework you would like the extension to support? The only thing I could find is this project named svelte. Also, this "css.remoteStyleSheets" setting is not supported in this extension. Currently, it gets those URLs from HTML link tags and retrieves the CSS file they refer to.

Hi,
Svelte is a new frontend javascript framework that is developing nicely, it just hit version 3. Its actually a javascript compiler that can ship a full webapps code as small as preact (around 3kb) after compilation. There is also a nice framework built around svelte called Sapper that is very similar to reacts Nextjs. Svelts's Sapper runs much faster and smaller than Next.js, and has a few very interesting nice to have features that make developing with it very nice.
Trust me, Svelte and Sapper are going to do very well. It's basically the birth child between Vuejs and Reacts with much better speed and bundle sizes.
Hope this helps.
Here are the links to the respective framework pages.
Svelte: https://svelte.dev
Sapper: https://sapper.svelte.dev/
Bests,
SK


New providers

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

This one fixes #76 and https://github.com/yiisoft/di/issues/190.


Bitcoin Cash donation?

Something I've noticed is two addresses in the readme.md: a Bitcoin and a Monero address for donating.
How about Bitcoin Cash?

It was added :)


Allows query chatmessage API endpoint by messageId

This will be useful when the exact message is required by another system. For example, you want a microservice that performs additional work (search query caching, convert to voice, create a video, etc) and it need to be associated to that exact message in some sort of backend (likely graphql) that merges the messages with the augmented data.

Thanks @Jaredude !


Investigate compressed response

Make sure we can compress server responses (in particular large json objects).
http://spray.io/documentation/1.2.2/spray-routing/encoding-directives/compressResponse/

Close this for not update in long time.


Update NetAddr dependency to version 2.0

NetAddr::CIDR was removed, I replaced it with NetAddr::IPv4Net and IPv6Net separately.
NetAddr::CIDR#matches? replaced with NetAddr::IPv4Net#rel and NetAddr::IPv6Net#rel.
Completely resolves #19.
Any suggestions about the code?

Many thanks. 🥇 I am happy to have such enthusiastic contributors as you, Alex!

Thank you.
Maybe make new release?

Done. v0.1.9 pushed to rubygems 🥇

Thank you! There are no more outdated gems in our project. :smiley:


Fan control not working on X14R2?

The fan curve in manual mode behaves oddly on my Alienware X14R2. I've set a flat line with a boost of 10 as long as the temperature stays below 80 degrees, but the fan still speeds up as the temperature rises.
The boost remains constant at 10, but the actual fan speed—the percentage displayed next to the boost number—still increases. Am I misunderstanding how this function works?

System

Model: Alienware X14 R2
OS:  Windows 11

Yes, this is correct.
We only have indirect fan control for our gear, so boost can only increase RPM above BIOS settings (but still keep it not so loud).
Use power modes for quiet operation (but it will cost lower TDP limits).

thank you!

Yes, this is correct. We only have indirect fan control for our gear, so boost can only increase RPM above BIOS settings (but still keep it not so loud).
Use power modes for quiet operation (but it will cost lower TDP limits).


Which version of .net to use? 7 or 8?

Dotnet 8 will be the next LTS version and it scheduled to be released versy soon:

.NET 8 is the next LTS version of the .NET framework (scheduled for November 2023), a powerful and versatile platform for building modern applications. As a Long Term Support (LTS) version it will updated for the next 3 years.

And dotnet 7 is not an LTS version. So, should we move the project to version 8 (its rc now)?

Dotnet 8 will be the next LTS version and it scheduled to be released versy soon:

.NET 8 is the next LTS version of the .NET framework (scheduled for November 2023), a powerful and versatile platform for building modern applications. As a Long Term Support (LTS) version it will updated for the next 3 years.

And dotnet 7 is not an LTS version. So, should we move the project to version 8 (its rc now)?

Since version 8 has major changes in Blazor Server App, we should migrate to 8 as soon as we start developing Admin Blazor App (Admin UI).

Project migrated to version 8 of .net


Add native module (PNM) deployment to VOD job

3rd PR in the queue to change the CI. This will have to be rebased on top of https://github.com/veracruz-project/veracruz/pull/628 and https://github.com/veracruz-project/veracruz/pull/637.
Note: These changes extend the VOD job execution time by ~8min, mostly due to building the sandboxer

Worth rebasing this now?


Fixed the link for ErrorProneTestHelperSourceFormat

The link for the ErrorProneTestHelperSourceFormat is broken: https://error-prone.picnic.tech/bugpatterns/ErrorProneTestHelperSourceFormat
It should be: https://error-prone.picnic.tech/bugpatterns/ErrorProneHelperSourceFormat/

Nice catch again @gtoison!
It's funny, this is actually an error on our side. We were kind of in a hurry to get the website done before the actual open-sourcing.
So you spotted a very specific bug in the code for the website generation.
We checked it out and @Badbond just pushed a fix for this and the correct URL now works.
Will close this PR as it is now resolved. However, we really want to thank you for filing a PR for this bug 😄.
(See here: https://error-prone.picnic.tech/bugpatterns/ErrorProneTestHelperSourceFormat/)

(Slightly tweaked PR title for the release note generation.)

Thanks for the quick fix!


Proper keyboard interface?

Hey, I'm not sure if this is possible in UEFI, but a proper keyboard interface would be really useful.
What I mean by that is the ability to check if a certain key is pressed at any time, instead of the queue-based approach currently implemented with the Input protocol.
Currently, when looping over read_key(), the method will return None most of the time.
It would be more useful if I could get a slice of all keys currently pressed.

Hello. Unfortunately, this is not the way UEFI (and by extension, this crate) is meant to be used.  Therefore, if you need more advanced keyboard input, you'll have to write a driver for the specific device you're targeting.
For example, if the keyboard is an USB device, you're expected to write an USB keyboard driver and directly read its state (using polling at a high frequency, since that's how USB devices work).

Right now Input is a direct wrapper around SIMPLE_TEXT_INPUT_PROTOCOL, so (as @GabrielMajeri said) it inherits the same queue-based approach from that protocol.
However, UEFI also has EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL which has a better read_key() function that provides additional KeyShiftState and KeyToggleState along with the optional Key. We could expose this protocol as well, which might help.

Currently, when looping over read_key(), the method will return None most of the time.

This doesn't exactly solve your problem, but you could use the wait_for_key_event() method to avoid any need for looping.

Thank you very much for both of your answers. The EX_PROTOCOL definitely looks promising.

Closing this issue since the original question has been reasonably answered


Adding support for AMD, commonJS and global

Reference #15 - adding proper support for different dependency managers.

Closed, see #27


Use OptionsBuilder to add cleaner configuration validation

ValidateOnStart() was added in .net 6, and it makes it much cleaner for validation of the configurations.
I saw the TODO, so I went ahead and updated it.
To clean up the JwtBearerOptions validation, I needed to be able to inject the settings for the bearer options configuration. I added ConfigureJwtBearerOptions to access the settings, since there isn't a way to access the IOptions in AddJwtBearer.

This looks like a nice addition. Thanks for the PR!
I was just wondering about the nullability of the existing properties now (see my comment above).
I've seen there's also an IValidateOptions<TOptions> interface you can implement to even take the validation itself into a separate class... Not sure that would be of much use here though with the limited validation we have now. It would make it a bit "cleaner" I reckon... Anyway just a thought ;-)

Do you prefer using IValidatableObject to move the validation into the actual settings class or use IValidateOptions<TOptions> to move it into a separate validator class? Another alternative is to use DataAnnotations attributes on the properties and call ValidateDataAnnotations(). It may not be the most useful for the JwtSettings or DatabaseSettings, but it could be useful to template users by establishing a clean pattern should they add more complex configuration.

I don't really prefer anything regarding these things - as in - I haven't really put too much thought into it yet... seems like you did though...
I agree we should do one thing and be consistent everywhere...
Maybe creating a unit test for it would clear out what is the best path forward? ;-)


Remove pnpm workspace

coverage: 100.0%. remained the same
when pulling 102bb94eef7095f732334b645c32a55ae1f49cc5 on remove_pnpm_workspace
into 105e326902137ce2aa28b952d18a1a90d28e69de on master.


net: wifi_shell: Print firmware version in Wi-Fi status

Extend Wi-Fi status to include firmware version.

@sachinthegreen, @krish2718  Please review.

It has been decided that firmware version need not be displayed in status. Closing this PR.


is there a way to render content inside the HEAD of the template?

I was able to configure webpack to render multiple pages.
I just miss the chance to dynamically modify the HEAD tag to add, via React, the title, SEO tags and maybe additional custom tags like canonical and other stuffs (preload, fonts, etc.).
I don't want to do it manually in every html page but i wish to pre-render them as well.
Is there a way to accomplish this?

Use react-helmet or similar:
// in your app.js (or whatever)
import React from 'react';
import { Helmet } from 'react-helmet';

export default class App extends React.Component {
  render () {
    return (

            <Helmet>
                <meta charset="utf8" />
                <title>My App's Title</title>
                <link rel="canonical" href="http://mysite.com/example" />
            </Helmet>
            ... etc

    );
  }
};

// file: prerender.js
import { renderToString } from 'react-dom/server';
import React from 'react';
import { Helmet } from 'react-helmet';
import App from './app';

export default function(data) {
  // render the app:
  const body = renderToString(<App {...data} />);

  // grab all the head stuff:
  const helmet = Helmet.renderStatic();

  // construct the document using both:
  const html = `
    <!doctype html>

            ${helmet.title.toString()}
            ${helmet.meta.toString()}
            ${helmet.link.toString()}

                ${body}

  `;

  return html;
}

// in your webpack.config.js:

plugins: [
  new HtmlWebpackPlugin({
    template: 'prerender-loader?string!./prerender.js'
  })
]

For preloading fonts I'd recommend using a less direct solution than injecting them into the head. Perhaps [critters](https://github.com/googlechromelabs/critters].

Thanks!

Sorry to bring this up after so long @developit, but I found this thread very helpful. I had a question regarding where your client side rendering file is in all this (i.e index.js). Where do you actually call ReactDOM.render(<App />, document.getElementById("approot"))? I'm getting an error in my entry file for webpack where I call :
export default () => {
  ReactDOM.render(<App />, document.getElementById('approot'));
};

Error is :
Error: Target container is not a DOM element.

@ernie-h the most common approach is to conditionally call render:
if (typeof document !== 'undefined') {
  ReactDOM.render(<App />, document.getElementById('approot'));
}


DEP: linalg: deprecate kron in favour of numpy.kron

Reference issue

closes #20072
What does this implement/fix?

kron does not support nd arrays with n>2 whereas numpy.kron does. It was proposed in #20077 to deprecate kron since the numpy version provides strictly more functionality, for which 3 core devs expressed support.
Additional information

Mailing list post sent


Document tls_minimum_protocol_version versions below TLSv1.2 require cipher_suites manually set

Title: Setting tls_minimum_protocol_version below TLSv1.2 not working with envoy 1.23.0
Description:
With envoy 1.23.0, and a config as below, TLS protocols below TLSv1.2 fail. For example, when testing with curl inside the envoyproxy/envoy:1.23.0 docker container (after installing curl inside the container and adding test.example.com to /etc/hosts):
root@81d22a314505:/etc/envoy# curl --tlsv1.2 https://test.example.com:10000/direct
direct response body

root@81d22a314505:/etc/envoy# curl --tlsv1.1 https://test.example.com:10000/direct
curl: (35) error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure

root@81d22a314505:/etc/envoy# curl --tlsv1.0 https://test.example.com:10000/direct
curl: (35) error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure

Appears to be caused by no shared ciphers, see logs below.
Repro steps:
Reproducable with the envoyproxy/envoy:1.23.0 docker image. With the same config and the envoyproxy/envoy:1.22.3 image, curl with --tlsv1.0 for example works.
Admin and Stats Output:
Config:
resources:
- "@type": type.googleapis.com/envoy.config.listener.v3.Listener
  name: listener_0
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 10000
  listener_filters:
  - name: "envoy.filters.listener.tls_inspector"
    typed_config:
      "@type": type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector
  filter_chains:
  - filter_chain_match:
      server_names: ["test.example.com"]
    transport_socket:
      name: envoy.transport_sockets.tls
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.DownstreamTlsContext
        common_tls_context:
          tls_params:
            tls_minimum_protocol_version: TLSv1_0
          alpn_protocols: ["h2,http/1.1"]
          tls_certificate_sds_secret_configs:
            - name: wild_tls_sds
              sds_config:
                path_config_source:
                  path: /etc/envoy/sds/certificate.yaml
                resource_api_version: V3
    filters:
    - name: envoy.filters.network.http_connection_manager
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
        stat_prefix: ingress_http
        codec_type: AUTO
        common_http_protocol_options:
          idle_timeout: 3600s
          headers_with_underscores_action: REJECT_REQUEST
        http2_protocol_options:
          max_concurrent_streams: 100
          initial_stream_window_size: 65536
          initial_connection_window_size: 1048576
        stream_idle_timeout: 300s
        request_timeout: 300s
        http_filters:
        - name: envoy.filters.http.router
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router

        rds:
          route_config_name: test_route_proxy
          config_source:
            resource_api_version: V3
            path_config_source:
              path: /etc/envoy/rds/rds1.yaml

Logs:
[2022-08-29 06:38:28.844][36][debug][filter] [source/extensions/filters/listener/tls_inspector/tls_inspector.cc:85] tls inspector: new connection accepted
[2022-08-29 06:38:28.849][36][debug][filter] [source/extensions/filters/listener/tls_inspector/tls_inspector.cc:116] tls:onServerName(), requestedServerName: test.example.com
[2022-08-29 06:38:28.849][36][debug][conn_handler] [source/server/active_tcp_listener.cc:147] [C4] new connection from <IP_ADDRESS>:45058
[2022-08-29 06:38:28.849][36][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:228] [C4] remote address:<IP_ADDRESS>:45058,TLS error: 268435640:SSL routines:OPENSSL_internal:NO_SHARED_CIPHER

Call Stack:

1.23.0 changelog contains:

tls: removed SHA-1 and RSA key transport cipher suites from the server-side defaults.

I think that is your issue. Can you manually configure what ciphers you want. Note that these ciphers were removed by default because they are insecure.

Thanks Matt, yeah I configured the ciphers just now as a test and have TLSv1.0 working again. Unfortunately we need to support some old internal clients that only support TLSv1.0.
Perhaps a note that manual configuration of the cipher_suites is required when setting anything older than TLSv1.2 on the TlsParameters page would be helpful.

Perhaps a note that manual configuration of the cipher_suites is required when setting anything older than TLSv1.2 on the TlsParameters page would be helpful.

Doc PRs appreciated! cc @phlax

@gsalisbury if you were able to add a docs PR that would be great, if not im happy to follow up

arrggh - just saw your PR - apologies for noise

@phlax no worries, PR is opened against main now.


"--test" cannot be used as a user-provided argument after the separator (either "--" or "++") anymore

Tested versions
Introduced in 4.3
Worked fine in 4.2.2
System information
Windows 10 / Ubuntu 22.04, Godot 4.3
Issue description
Hey,
I believe v4.3 broke the "--" separator for user-provided arguments.
As per the documentation: "Following arguments are not used by the engine, but can be read from OS.get_cmdline_user_args()."
This was true in v4.2.2:

Godot_v4.2.2-stable_mono_win64_console.exe --headless --path Path/To/My/Game -v -- --test
Godot Engine v4.2.2.stable.mono.official.15073afe3 - https://godotengine.org
TextServer: Added interface "Dummy"
TextServer: Added interface "ICU / HarfBuzz / Graphite (Built-in)"
Using "default" pen tablet driver...
TextServer: Primary interface set to: "ICU / HarfBuzz / Graphite (Built-in)".
.NET: Initializing module...
Found hostfxr: C:\Program Files\dotnet\host/fxr/8.0.8/hostfxr.dll
.NET: hostfxr initialized
.NET: GodotPlugins initialized
CORE API HASH: 622119089
EDITOR API HASH: 497707466
Loaded system CA certificates
My custom game test is starting...

However, in the 4.3 version it stopped working:

Godot_v4.3-stable_mono_win64_console.exe --headless --path Path/To/My/Game -v -- --test
ERROR: --test was specified on the command line, but this Godot binary was compiled without support for unit tests. Aborting.
To be able to run unit tests, use the tests=yes SCons option when compiling Godot.

I do not want to run unit tests.
I did not specify --test as a Godot flag.
I only wanted to pass my own argument, after the "--" separator.
Steps to reproduce
Just run:

Godot_v4.3-stable_mono_win64_console.exe -- --test

Minimal reproduction project (MRP)
Just run:

Godot_v4.3-stable_mono_win64_console.exe -- --test

This is a regression from https://github.com/godotengine/godot/pull/90507.

@Calinou Made a PR for this.


How do i get a currency if i have a country?

as the topic says

Fixed now that the patch has been merged.

I never merged this actually, sorry.

thanks for this btw :+1:

As mentioned, this hasn't been merged, for the reason given above.

This was fixed in #136 which has now been merged to master. See function get_currencies_of_country - https://github.com/limist/py-moneyed#search-by-country-code


Cannot install npm modules

Hello! I've starting using this cookbook but I'm facing a problem that I wasn't able to overcome.
I'm using a vagrant machine ( box is ubuntu/trusty64 ). Everything works except for npm module installation.
This is the excerpt from mi node.json file ( loaded by chef-solo ):
{
  "run_list": [
    "nodejs::npm", [...]
  ],
  "nodejs": {
    "npm_packages": [
      { "name": "sails" },
      { "name": "grunt-cli" }
    ]
  },
  {...}
}

What am I doing wrong? I want to install sails and grunt-cli module globally.
Thanks for your help

Hi @endorama ,
First node['nodejs']['npm_packages'] is currently only used in nodejs::default recipe.
If you only specify nodejs::npm in your run list, you'll have to call nodejs_npm LWRP by your own.
Then you point a second issue : nodejs::npm is doing nothing if you select embedded install method (which is default behaviour). I'll push an update for this later. We made many changes in nodejs::nodejs recipe, that's why we can still got this kind of mistake.
thanks

second point fixed by #68 & #69

Thanks for the clarification!
Could you please confirm that this node.json should work as expected?
{
  "run_list": [
    "nodejs", [...]
  ],
  "nodejs": {
    "npm_packages": [
      { "name": "sails" },
      { "name": "grunt-cli" }
    ]
  },
  {...}
}

Yes, this should be good with this conf

It works! :) Thanks for your help, closing.


Correction for raw affiliation Univ Lyon, ENS de Lyon, Univ Claude Bernard, CNRS UMR 5239, INSERM U1210, Laboratory of Biology and Modelling of the Cell, 6 allée dItalie Site Jacques Monod, F-69007 Lyon, France

Correction needed for raw affiliation Univ Lyon, ENS de Lyon, Univ Claude Bernard, CNRS UMR 5239, INSERM U1210, Laboratory of Biology and Modelling of the Cell, 6 allée dItalie Site Jacques Monod, F-69007 Lyon, France
raw_affiliation_name: Univ Lyon, ENS de Lyon, Univ Claude Bernard, CNRS UMR 5239, INSERM U1210, Laboratory of Biology and Modelling of the Cell, 6 allée dItalie Site Jacques Monod, F-69007 Lyon, France
new_rors: 04zmssz18;029brtt94;02vjkv261;02feahw73;01bj4fd12
previous_rors: 04zmssz18;029brtt94;02vjkv261;02feahw73
works_examples: W2952201571
contact: ff8560b51c4bd671b7bc955c21ff9b24:50732a0e3675f6cd1e6f8a3baea2 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


Added support for TLS SNI

When TLS is used to connect to the syslog server, this change adds the TLS SNI extension to the TLS handshake, to indicate the wanted server name to the server.
Note that the host configuration option needs to be set to FQDN (Fully Qualified Domain Name) and not e.g. IP address or hostname without domain part.

@tsaarni please reabase this 🙏

Rebased!


fix unicode support in new parser

@radumereuta please review

I think this deserves a more complex test that includes outer parsing, and calling the new parser for programs on something that contains unicode characters.

@radumereuta please review

lgtm, merge if tests pass.

Jenkins: test this please


Tokenization issues

Running into some potentially troublesome issues in the tokenization for indic-bert. It seems all vowel matras (diacritics) are getting dropped in the tokenization, which loses a lot of information about the word. Perhaps some sort of Unicode issue?
Minimal example (prints True) where two very different words get treated as the same token.
import transformers
tokenizer = transformers.AutoTokenizer.from_pretrained('ai4bharat/indic-bert')
print(tokenizer.tokenize("यहाँ") == tokenizer.tokenize("यह"))

bert-base-multilingual-cased does not have this issue.
Is this an issue on my end? I have this problem on Colab and on my machine (Mac, Python 3.8.8). @nitinvwaran also has this issue. I had to install sentencepiece to get the tokenizer to work btw.

Found a fix.
import transformers
tokenizer = transformers.AutoTokenizer.from_pretrained('ai4bharat/indic-bert', keep_accents=True)
print(tokenizer.tokenize("यहाँ") == tokenizer.tokenize("यह")) # returns False

Sorry for the late reply.
Added this to the readme and referenced your issue.
Thanks

While training the IndicBERT model, what's the value used for keep_accents?
Can anyone please let me know


netann+discovery+server: consolidate network announcements to netann pkg

Removes a lot of code duplication w/in the gossiper by consolidating all creation/signing of annoucnements into the netann pkg

Still relevant?

@halseth @wpaulino itests passing again, i think it had to do with not updating the timestamp on node announcements and them failing to propagate.

@halseth ptal


add jss fields used by clio nft_info

High Level Overview of Change

The new nft_info API that exists in clio only added some fields that don't exist in our JSS enum. Adding them to prevent future confusion/collision.
Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

It looks like this is adding constants to ripple that aren't used in rippled. Since these are used in clio I'd suggest adding them to clio instead. If they end up being moved to rippled it can be removed from clio and added to rippled at that point.

@cjcobb23

I think this pull request is a great way to elevate the discussion about how rippled and clio interoperate and remain synchronized over the years.  So thanks for that, @ledhed2222.
I'm gonna get long winded.  Sorry.  It's my way.
How Does clio Relate to rippled?
I'm going to state my understanding about how clio and ripple relate to one another.  That understanding my be wrong, so I welcome being corrected.

In essence, clio is designed to be a query handler for the sorts of questions one might ask rippled...

clio's data storage is more efficient than rippled's
clio is not trying to validate ledgers, so it can dedicate its resources to responding to API queries.

Because clio responds to the sort of questions one might ask rippled...

Users want rippled and clio to have the same query API and
They want query responses from clio and rippled to result in identical JSON.

If we succeed at that, then users of rippled and clio don't need to distinguish between whether they call clio or rippled.  This is a big win for client usability.
Responses From clio and rippled Are Now Intentionally Diverging
This pull request is a consequence of an intentional divergence from what I've just described.  Rather than providing the same API for clio and rippled, clio now provides a superset of capabilities.  The divergence is starting small, but it's there.
The divergence is happening because there are questions about the state of the ledger that would be expensive for rippled to answer.  clio can answer some of these questions more efficiently than rippled could, so it makes sense to add those capabilities to clio.
So at this new point, a user who needs the information only clio can provide must connect to clio.  Other users can connect to either rippled or clio.
What we see in this pull request is the camel's nose of the upcoming divergences.  This one is intentional.  There will probably be other divergences in the future that are both intentional and unintentional.  Unintentional divergences will occur because both clio and rippled are live, evolving, and largely independent code bases.
How Should We Handle Divergences Between clio and rippled?
The question at hand is how do we want to handle these divergences so that...

We get the divergences that we want,
The divergences we produce are harmonious (the divergences produce JSON that plays well together),
Our processes resist us producing unintentional divergences, and
The costs associated with these assurances are acceptable to the developers and to the company.

I think this pull request is a reasonable first stab in starting to handle these divergences.  JSON has three compatibility legs it stands on:

In its keyword : value structure, within a given schema a keyword should mean the same thing and not be subject to unintentional spelling/capitalization/pluralization variations.
The types of values returned for a given keyword should be consistent.
The larger JSON object/array structure should be consistent.  Inner objects should appear at known and expected places within the object hierarchy.

So What Does It Mean for This Pull Request?
This pull request is attempting to address the keyword consistency problem -- number 1 above.  What does the pull request actually accomplish?

It helps encourage clio and rippled to spell JSON keywords the same way.

To be fair, that's all jss.h can do, even inside of rippled.  And jss.h has been a boon within rippled.  Within rippled we have largely replaced the quoted c-strings originally used for JSON reading and writing with manifest constants defined in jss.h.  This is a great thing.  The jss:: constant must be present and spelled correctly, including capitalization, or you get a compile failure. jss.h also provides us a self-maintaining library of keyword values used in our returned or consumed JSON.  If I'm cooking up new JSON, I can look in jss.h and it tells me which keywords have already been used.  I don't have to scan the whole code base and hope I didn't miss anything.
There are downsides to the change.

jss.h is part of rippled.  A clio developer must now modify rippled before they can make the new keyword available to the clio codebase.  And now that new keyword is unavailable to the clio codebase until the change to rippled has been released.  This reduces velocity for clio code development.
The change only helps verify keyword spelling.  It doesn't help with other issues that might occur:

The keyword is spelled the same but the meaning is different.
The keyword is spelled the same, but the value associated with the keyword is inconsistent (quoted decimal numbers anyone?).
The keyword is the same, but the structure of the JSON is different: the keyword or object shows up in the wrong place.

Even with the given limitations, I think this is probably a good change.

The suggested change came from a clio developer.  So I assume clio developers are willing to put up with the hit to their own development velocity.
Nobody is talking about either...

A shared JSON checker between rippled and clio to verify that they build sufficiently similar JSON, or
A shared JSON formatter, so the JSON they produce is similar by construction.

If someone were talking about a shared JSON checker or formatter then this change might be less useful.  At the least, this change would want to be made in the context of that larger change.
But, as it stands, the downsides to this change seem small, at least for rippled development.  The benefits are also small, but they are real.
I'm hoping this long-winded exposition is the start of a discussion.  So I'm not approving the pull request yet, even though I think the change is good.  I'd like to hear other opinions and alternatives before I make up my mind.  Thanks.

@scottschurr love love love your comment!

I'm going to state my understanding about how clio and ripple relate to one another. That understanding my be wrong, so I welcome being corrected.
In essence, clio is designed to be a query handler for the sorts of questions one might ask rippled...
    clio's data storage is more efficient than rippled's
    clio is not trying to validate ledgers, so it can dedicate its resources to responding to API queries.
Because clio responds to the sort of questions one might ask rippled...
    Users want rippled and clio to have the same query API and
    They want query responses from clio and rippled to result in identical JSON.

So, the more I deal with clio, and this is from someone that is not on the clio team per se, I have a different perspective. I think that clio is now a superset of rippled APIs. And ideally what we have moving forward is that clio is the way you talk to your rippled client, only. So for that reason, I see more divergences coming, unless we start thinking about rippled's API as soon-to-be frozen/deprecated/hopefully deprecated etc.

so - @scottschurr and @cjcobb23 and @seelabs , another way i could look at this (macro level) is to say that this file, in particular, needs to be its own repo. I know that sucks but that might be the truly safe and correct thing to do.

Is the argument that clio has RPC commands that has fields that rippled doesn't have, and those fields may someday be put into rippled, so let's put them there now in case that happens to make sure they use the same name as clio? If that's the argument, then I'm still opposed. I also don't think this needs to be it's own repo. Things that are common between the two projects belong in rippled. Things that are unique to clio belong in clio.

Is the argument that clio has RPC commands that has fields that rippled doesn't have, and those fields may someday be put into rippled, so let's put them there now in case that happens to make sure they use the same name as clio?

Yeah, I guess that's the point.  rippled and clio must use a common vocabulary of keywords in their API.  clio doesn't necessarily use the full vocabulary (defined in jss.h) that rippled uses, but it still has that full vocabulary available.  To me It seems like rippled should also have the full vocabulary that clio uses available.
Let me try it this way.  From a naive perspective, rippled and clio appear to be (largely) independent programs.  But they are not.  clio's job is to return a superset of data that rippled returns through its API.  The overlap of the APIs of rippled and clio must, at each step, stay as similar to each other as possible for the very long term.  If the overlapping APIs stray from each other then users trying to get rippled history get fouled up.
Both rippled and clio are under active development, and will be into the future.  As such, API keywords that rippled uses should be the same keywords that clio uses.  If clio introduces new keywords in its superset API, then rippled programmers should be aware of those keywords.  If rippled programmers are aware of those keywords, then they can either use them (intentionally) or avoid them as rippled is modified into the future.  It reduces the likelihood of rippled programmers introducing minor variations on names used by clio.
So this pull request is intended as a first step in the goal of keeping rippled and clio's APIs as similar as possible.  And I think this pull request helps a little bit in that quest.
Please note that, at the moment, clio seems to be the only long term solution that rippled has for full history.  So the usability of clio is vital to the long term viability of rippled.  To some extent we cannot view them as independent programs.  We should instead view them as complementary programs.

If rippled programmers are aware of those keywords, then they can either use them (intentionally) or avoid them as rippled is modified into the future. It reduces the likelihood of rippled programmers introducing minor variations on names used by clio.

If the goal is to ensure rippled developers know about this field, my suggestion is to add these JSS variables commented out (in their proper place), with a comment next to each one explaining the relevance to clio, and a note that if one uncomments the item, they'll need to coordinate with clio developers. Maybe clio could use some kind of precompiler flag to define the variables conditionally, so the coordination becomes easiler.

@ximinez, that's an interesting idea.  Maybe add a JSS_CLIO macro that only defines the constant if we're compiling for clio?  We're already using macros in the file...

Thinking about this more, this PR is a bad idea because it will tightly couple clio and rippled (bidirectionally). If we actually wanted to do this, we should put these sort of shared values, likely including error codes, into a separate repo that is linked to each project. Clearly that's not going to happen any time soon.
Thoughts?

Thinking about this more, this PR is a bad idea because it will tightly couple clio and rippled (bidirectionally). If we actually wanted to do this, we should put these sort of shared values, likely including error codes, into a separate repo that is linked to each project. Clearly that's not going to happen any time soon.
Thoughts?

If the value was shared and used bidirectionally, then another repo might make sense, but what I'm seeing is clio using a value, and just wanting to make sure that rippled doesn't step on its toes. Not the same.

I'd love it if rippled only had code that was necessary for running the rippled server. So, as little RPC as possible, no special "reporting" modes, and no common code or constants that aren't used in rippled (including compiled out macros). This moves us away from that. I don't see clio and rippled as joined. Clio is built on top of rippled.

Yup.  We're in heated agreement.  And I agree, this change moves us (slightly) away from the desired direction.
The problem is that we don't really have a plan for getting to that desirable place.  We need to do the best we can with what we have right now.  What I want to avoid is getting to the (nearly) disastrous place that gRPC took us a few years ago.  I think @ledhed2222 has a view of the upcoming API synchronization issues between clio and rippled.  And I want to help him get whatever tools he needs to keep us from digging ourselves into that same (gRPC-like) hole yet again.
I think this is just the first step on the journey.  This change may be backed out once we understand the landscape better.  I'd be fine with that.

Edit: I understand the argument about a "common vocabulary", and it's a valid point. I guess I'm less worried about that because I see clio as the home for new RPC commands. The most likely new vocabulary that will appear in rippled will involve new ledger objects and transactions - and those new JSS constants will appear in rippled before clio.

I almost agree with that.  clio really is claiming new keywords in the API namespace.  And rippled will be claiming new keywords too.  If clio has already claimed a keyword, and rippled developers don't have visibility of that, rippled developers can unknowingly claim a keyword that clio has already claimed.  Or worse, can unknowingly claim a keyword that is almost the same as a keyword that clio has already claimed.
Since the API keyword namespace is shared, I think both clio and rippled developers need visibility of the full (both rippled and clio) namespace.  Maybe later we can find a way to partition the API namespace?  But right now we are where we are.
But I don't think I have any better viewpoint than anyone else.  I'd be interested to hear what @ledhed2222 and @ximinez think about this pull request now.

But I don't think I have any better viewpoint than anyone else. I'd be interested to hear what @ledhed2222 and @ximinez think about this pull request now.

I'm neutral toward weakly in favor of this PR, so long as it's annotated that these fields are needed by clio (which they are). I don't think there is a really optimal way to do what we want to do, and this seems like the lesser evil.

When external developers see there are 8 pages of conflict over 3 constants that will be compiled to nothing, what will they think of this project? It's embarrassing.

@ledhed2222 this has sufficient approvals. If you agree that this is ready to merge now, you can apply the Passed label, or just comment here saying that it's ready.

@ledhed2222

Why was this branch force-pushed? I see there are no changes between the different commits, so why bother?
Please review the following commit message, and either confirm that it looks good to you, or propose an alternative:

Add jss fields used by Clio `nft_info`: (#4320)

Add Clio-specific JSS constants to ensure a common vocabulary of
keywords in Clio and this project. By providing visibility of the full
API keyword namespace, it reduces the likelihood of developers
introducing minor variations on names used by Clio, or unknowingly
claiming a keyword that Clio has already claimed. This change moves this
project slightly away from having only the code necessary for running
the core server, but it is a step toward the goal of keeping this
server's and Clio's APIs similar. The added JSS constants are annotated
to indicate their relevance to Clio.

Clio can be found here: https://github.com/XRPLF/clio

@intelliot i force pushed just to add my signature to the commit.
yes - love the commit message!


refactor: Replace un-maintained 'forever' with 'pm2'

Description
forever sees very little maintenance (last release on Jan 2022) and even encourages people to use pm2 or nodemon instead. Replacing it with pm2.
Helps the effort of addressing CVE issues because forever has transitive dependencies on flagged packages.
Reviewer Guidance
The review process is outlined on this wiki page.
I tested the new scripts with pm2 work in WSL and Windows.

Didn't we have problems with pm2 on Windows? I also seem to remember there being some component governance concerns.

Didn't we have problems with pm2 on Windows? I also seem to remember there being some component governance concerns.

Yes, it didn't like an "ecosystem file" that defined several things to run at the same time, that's why I tested these in Windows specifically. That said, I'll give it another go, pm2 is reporting the things start correctly and I could see things starting to listen on port 7070, but looking at the logs might be a good idea.
I don't recall the component governance bits... But even if so, I think it's preferrable to move to a more maintained project (as long as it works for the use case, i.e. standalone js scripts) and address security issues for that one.


Support swap_dims to dimension names that are not existing variables

[x] Closes #1855
[x] Tests added
[x] Passes black . && mypy . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Thanks @keewis


TVPaint: Creator gets stuck behind renaming dialogue.

Describe the bug
When having the renaming dialogue open in TVP the Creator gets unresponsive.
To Reproduce
Steps to reproduce the behavior:

Open the Creator
Double click on a layer name to get the renaming dialogue.
While keeping the renaming dialogue open, try to create a render pass.

[cuID:PYPE-1259]

this is not really possible to solve so we're closing it


CI: add option to use BUILD_SHARED_LIBS flag on Linux

Description of the Change

Add option to use shared libraries in CMake for Linux builds
Add step for "Before merge to trunk" scenario to use shared libraries

Benefits

Can potentially make it default to reduce build time when tests are fixed
More configurations tested

Possible Drawbacks
None

irohad_test is known to have issues and will be fixed.


Support mooks (in some simple manner)

Optional multiplier to a counter in combat add, maybe?
Or perhaps, support adding multiple as a group, and support damaging the group as a whole (distributing the damage across counters progressively)?

Added swarm hit points -- should do the trick


fix: revert from/schema/rpc changes

Reverts:

https://github.com/supabase/supabase-js/pull/975
https://github.com/supabase/supabase-js/pull/973

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 65.877%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
92

Relevant Lines:
119

💛  - Coveralls


0.8.0: Update to work with Nightshade client. Fix remove access key t…

…est. Remove dev.js to make sure we use test accounts only in test envs

The goal from now on to never have hard coded keys for regular usage (e.g. for now kept it for unit tests but ideally even unit tests would be parameterized with current key).
So let's figure out what the interface should look like: for example reading available configs for local nodes or asking user to provide it. But definitely now "devKey" → as this doesn't work in normal situation of me running actual testnet node locally.
Best regards,
Illia Polosukhin
Sent via Superhuman<EMAIL_ADDRESS>)
On Sat, Jun 01, 2019 at 8:31 PM, Vladimir Grichina <<EMAIL_ADDRESS>> wrote:

@vgrichina commented on this pull request.
In test/ test-utils. js (
https://github.com/nearprotocol/nearlib/pull/36#discussion_r289624991 ) :

get myAccountId() { + return this. deps. storage. getItem (
http://this.deps.storage.getitem/ ) (storageAccountIdKey); + }, + /** + *
Function to create an account on local node. This will not work on non-dev
environments. + / + createAccountWithLocalNodeConnection: async function
(newAccountName, newAccountPublicKey) { + const account = new
Account(this.near.nearClient); +
this.deps.keyStore.setKey(testAccountName, devKey); // need to have dev
account in key store to use this. + const createAccountResponse = await
account.createAccount(newAccountName, newAccountPublicKey,<PHONE_NUMBER>000,
testAccountName); + await
this.near.waitForTransactionResult(createAccountResponse); + }, + /* + *
Function to create an account on near-hosted devnet using contract helper.
This will not work on non-dev environments. + */ +
createAccountWithContractHelper: async function (newAccountId, publicKey)
{

this is needed outside of tests, e. g. for near-shell
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
https://github.com/nearprotocol/nearlib/pull/36?email_source=notifications&email_token=AABK27VB34AK7HGUPQRPGXDPYM5K7A5CNFSM4HSBRWQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2KG3GY#pullrequestreview-244608411
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AABK27SK5FTSTNAKDWCIGBTPYM5K7ANCNFSM4HSBRWQA
).


Does it work on Opera GX?

The official Chrome Web Store extension only works on Google Chrome atm.
You can download it here.


Proper module system + namespaces

Currently there are no separate namespaces. I think it would make sense to built a proper module system where things arent included flat.
Then i could also more easily built a standard library.

https://github.com/JanEricNitschke/generic-lang/pull/22


[in_app_purchase] How can i check the  product was purchased for restriciting user access?

I only found await InAppPurchase.instance.restorePurchases()  in documentation. It return nothing if user has no purchases.
Is there coorect way to check user has actual non-consumable purchase, whose exist and was not refunded?

Hi @pashtetbezd
Initially you need to present subscrioptions for firs time then once your backend registered the subscriptiion and verifies, you can hide/restrict your subscription item for the user if your backend verified the subscription active. This needs need to be handled in your backend and the app.
Closing, as this isn't an issue with in_app_purchase itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Assembly not referenced.

Hi,
I followed all the instructions but keep getting "an Assembly containing type GTXLibGit2Sharp.GTXRepo is not referenced." error.
I have copied the whole of git bin to the client bin folder, added the gtxlibgit2sharp dll to the references in the aot etc...
Any ideas why this might not be working?
thanks

Sorry fraga, I haven't been able to test it yet due to holidays and other commitments. Will test it today.
thanks.

Tried it and got this error and warning in the compilation log file:
Error \Classes\GTXPendingVCSObjects\process 53  12
Argument '_node' is incompatible with the required type.
Warning
\Classes\GTXSysVersionControlSystemMock\new  1 1
The new method of a derived class does not call super().

Hi @BTXAndy should be fine, I think this GTXPendingVCSObjects is not done yet

Update: i've managed to install it on 2012 R3 RTM. I can now debug the gitax code. However, I used the latest git an libgit2 libraries and updated the code. I'll do a PR at some point when it all works for me.
In the code it says for undo checkout: //TODO: Dangerous, consider refactoring
What's it doing that is dangerous?

At that time I thought using FileInfo could lock the file but I learned later on that it should not be a problem but never removed the comment :)
While you're committing code to your local repository, always remember to push to your remote github repository.

Different question: how can I add a class to a model and pick it up on another aot/machine? I've added an extra class in the repo and when I sync, it doesn't pick it up?

Remote syncing is not implemented yet. We must first make sure ax can sync the folder and then we implement the git part that will fetch/pull the remote branches from remote repos.
The way it is now, syncing will sync the current VCS folder and all the xpos in there. I will write in the wiki pages how to do that with the command line.

I have a VM with a share to a repo. I added a class and committed it, then reverted to an earlier snapshot and synced. The new class didn't show up.
Remote syncing isn't required really as I use sourcetree for that and intend to use sourcetree for most git functions.
The main thing is being able to pick up code from the repo and sync the AOT with that.
Any idea why it didn't pick up the new class?

ok, I think I figured how to do it:
synchronize forced
restart client.
Is that the normal way to sync the AOT and client with the local repo?

We are probably missing something in order to make it work without "forcing" it
If you want you can create another issue so we track the progress while fixing it

Sorry to add more to this issue, but didn't know where to put it.
To fix the referencing issue, I updated libgit and libgit2sharp to the latest at the time, referenced them in the .NET project and updated the project file to copy them to the client bin folder during build.
This works fine, except that you need to import the attached xpo twice for some reason.
However, I can't get  AX to sync up to 2 models I already have in git. These were added to AX on another machine.
History etc works, but sync doesn't seem to do anything.
How can I send you the XPO file?

You can send to my email along with details of what you are experiencing :)

sure thanks, but what's your email address?

Check on the commits my email is there :)
On Mar 31, 2015 7:08 PM, "BTXAndy"<EMAIL_ADDRESS>wrote:

sure thanks, but what's your email address?
—
Reply to this email directly or view it on GitHub
https://github.com/fraga/gitax/issues/44#issuecomment-88279145.

Now there's an idea! :)
Will send xpo tomorrow morning with more info. Thanks.

Ok looking forward to it :)
Will close this issue if you dont mind
Ttyl
On Mar 31, 2015 7:13 PM, "BTXAndy"<EMAIL_ADDRESS>wrote:

Now there's an idea! :)
Will send xpo tomorrow morning with more info. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/fraga/gitax/issues/44#issuecomment-88279700.


Not compatible with Windows Phone 7.5

I thought this Application could help me manage my MySpace account using my Windows Phone 7.5 ("Mango"), unfortunately it's not the case. Problem: Just nothing happens. Can anybody explain?

Are you using MangoDB?

This seems to be a broader issue; at least it does not work as expected on Android too.
Steps to reproduce:

Cloned the repo
Did not build (I used Gradle for this step)
Did not deploy to my Android phone
Expected result: The phone does nothing.
Result: The phone still does a wide range of things.

I am very displeased (even angry) with this project and will immediately look for some other thing not to do instead.

@jvitkauskas No Windows Phone, this is the Smartphone Future, don't you read my MySpace feed? I'l ICQ you the Url...

@GitCash send 250 bits to @thojaw @jvitkauskas @LostMekka
╰( ⁰ ਊ ⁰ )━☆ﾟ.*･｡ﾟ

@thojaw,@jvitkauskas,@LostMekka

@thojaw,@jvitkauskas,@LostMekka

@thojaw,@jvitkauskas,@LostMekka


Add support for Iterator in jsonable_encoder

This PR adds support for Iterator in the jsonable_encoder.
Currently, FastAPI allows for response_model such as Iterable[BaseModel] . In those cases:

The Pydantic Model is used to retrieve the validated data from the response object https://github.com/tiangolo/fastapi/blob/20d48345465e5b09756cc9ef62fb940c63255a13/fastapi/routing.py#L129
The output of the validation is a List Iterator
The jsonable_encoder doesn't encode the list, but just calls dict() and returns a list of the fields of the BaseModel

By adding the support for Iterator in the jsonable_encoder, we avoid that the response object is passed to dict(), losing the values of the fields of the BaseModel.
An example of this issue is described in #3911
Fixes #3911

What do we need to do in order to get this approved and merged?

What do we need to do in order to get this approved and merged?

Tagging randomly and asking a review to @Kludex @dmontagu?
I have 2 PRs opened for some months here, and it's not clear to me who to ask for a review for bug fixes.
Thank you 🙏

@tiangolo is the only one who can have this merged. Nothing to do besides wait. :kissing:

Looks good, and I working fine.
Just a curious question:
Why don't we consider all iterable, sequence instead of explicitly specifying each types?

See https://github.com/tiangolo/fastapi/pull/3913#discussion_r712343889

Why don't we just make this isinstance(obj, Iterable)? Is that going to be too generic and pick up bad inputs?
from typing import Iterable

def gen(arr):
    for x in arr:
        yield x

l = [1, 2, 3, 4]
g = gen(l)
s = set(l)
t = tuple(l)
f = frozenset(l)

print(isinstance(g, Iterable))
print(isinstance(l, Iterable))
print(isinstance(s, Iterable))
print(isinstance(t, Iterable))
print(isinstance(f, Iterable))

# Output is all True

Thanks @klaa97!
I'm struggling to find what use case would this solve that would not be solved by setting the response model to list[X], as described in the same discussion.
As there are many other things that could be Iterable and Iterator and it has nuanced behaviors, I would be inclined to leave just list and the others. Also, it's normally better to be more explicit in the output/return about the exact type.
It would be better to start with a use case that shows why this is needed and why using a list[X] is not enough, filling the GitHub Discussion question form: https://github.com/tiangolo/fastapi/discussions/new?category=questions 🙏

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.
I think so.

I ended up using a list, but the ask to support Iterator seems pretty no-nonsense, given it allows for more flexibility. After two years, I had figured this would never get merged and a list seems to work well enough.


Allow pink::keyPair to export private key

When writing contracts, we can't store Keypair directly in the contract's storage, because Keypair doesn't derive the necessary ink storage layout traits, a workaround is to store the private key instead. We already have a method to restore KeyPair from the private key:
let keypair: KeyPair = self.key.into();

LGTM


Added aria attributes.

Description
Added aria attributes.
Is this a breaking change (Yes/No):
No

@hirotomoyamada
Thanks for your PR.
Just to confirm, do we need to add "aria-controls" to the AutocompleteContext?


Update filter-properties.md

Per Issue #2718

OPS Build status updates of commit c9673ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-server/recipient-filters/filter-properties.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Ops]: Setup Shopify Development Store (NoClocksDevStore)

Will need to initialize an Shopify Development Store for No Clocks.

Setup store: https://store.noclocks.dev/ (https://noclocksdevstore.myshopify.com)


Failure within Google Colab Python Notebook environment

When making use of Google Colab
it is possible to successfully install the pandas-datacube package.
!pip install pandas-datacube

However when attempting to import the package
from pandasdatacube import get_datasets
import pandas as pd

it fails with the following errors
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-2-c9ef2fe4db74> in <module>
----> 1 from pandasdatacube import get_datasets
      2 import pandas as pd
      3
      4

1 frames
/usr/local/lib/python3.8/dist-packages/pandasdatacube/pandasdatacube.py in <module>
      8
      9
---> 10 def expand_name(word: str, prefixes: dict[str]) -> str:
     11     """
     12     Function that transforms the prefix using a dictionary of conversions

TypeError: 'type' object is not subscriptable

This error doesn't appear to occur when using python natively within a VM or desktop environment

It may be due to python being < 3.9
What is the python version of your Collab instance ? Is it possible to use a ≥ 3.9 python in your Collab Notebook ?

Fixed in 0.0.4 AFAICT