Images not in proper location

From @n76 on August 8, 2016 4:37
For example, see track file number 11585 and observe the location of the images being shown as on the freeway when the images themselves are clearly still on a surface street running roughly at a right angle to the freeway. The same, or at least a very similar, positioning error is evident when looking at the images using JOSM with the OSV plugin.
My phone doesn't have the best of GPS receivers, but I've never see it that far off when using any nav app nor when using things like KeypadMapper or OsmTracker.
This may be related to https://github.com/openstreetview/android/issues/16 which was about track file number 11498.
Copied from original issue: openstreetview/android#19

Hi n76,
You are right, the track displayed on the site is incorrect, most probabli the position wasn't accurae enough and it got matched elsewhere on the map. We'll sort the problem out.
Thanks.

This may be a problem during processing. Incorrectly tagged images can not be downloaded later in JOSM. In applications everything looked ok (GPS track) but after uploading to the server, some images are not available.

http://openstreetview.org/details/11556/1 - first image with incorrect position. App running 5 minutes before i start recording, this is not problem with GPS fix.

Same for track http://openstreetview.org/details/12223/21

Same for track http://openstreetview.org/details/12595/1
my first test track and has error location

I don't personally think the position was an issue: While the phone is old and it takes a while for the GPS to lock, the position reports from the GPS system are usually within 10 meters. And other apps running at the same time (e.g. OsmTracker, OsmAnd, Maps.me, SatStat, etc.) all show or record tracks and mapped data pretty closely.
I am wondering if the issue is lack of a ODB2 speed source. The one I picked up doesn't work with OSV so my test runs were using GPS alone for positioning and speed.

Hi, you are right, this is most probably a matching issue, even without obd, the track should be OK with good GPS.

Same for track http://openstreetview.org/details/14400/1
But I was without car.

Could we manually synchronize with the correct position to fix this problem ?

Although not available yet, it's on the roadmap to edit these tracks, for now you don't need to worry, the matched track is only for display, the original gps+sensors track remains accurate. The visible track will be shown correctly as soon as the matching algorithm improves.

It seems more than the matched track is at issue: I've just done another test run completed about an hour ago. I've deleted the uploaded track because by then end the images were shown miles, literally miles, off from where taken and it seemed to me that no images showing up in JOSM was better than images that far off.
This is with v1.9.5 of the Android app on a phone running Marshmallow. And while making the test run, I started another GPS using app first so when OSV started the GPS was already locked and had a reasonable accuracy (5 m). While making the test the little inset map view showed a reasonable position (lagging a little from time to time but not by much).
So I am pretty sure that there was a good GPS location available for each image but that is certainly not reflected in the position of the image shown after upload.
At this point, I consider this bug a deal killer. I'll continue to monitor this project and when I see updates that might affect this I will try again. But for the moment collecting street images with OSV on my Android phone is simply a non-productive waste of time.

Not sure how this is a deal breaker if images in JOSM are accurate(where it counts)

Images don't seem to be accurate in JOSM which is the problem.

Okay, went out for another test drive and the track is 14800
Looking at the images in JOSM, the order and placement appear to be the same as at http://www.openstreetview.org/details/14800/40
In this case I drove the length of a road and made a turn around at the end. You can see the turn around in images 75 through 85 but the website and JOSM would have you believe that it occurred in images 36 through 39.
It is interesting that it only shows three images for the turn around on the track but it actually took 10.
Also interesting that the track continues far past the last image uploaded. And the track ends prior to where I actually turned off recording. That could be the result of a bungled upload, see screen shot below.
It seems like it it trying to space the images along the track rather than place them at the GPS location when the image was taken.
Since the locations shown in JOSM seem to match that on the website edit/preview, they are worse than useless for editing. I will re-verify the JOSM locations in about 12 to 14 hours to see if your post processing somehow corrects. But it seems to me that leaving them in the system for others to make map updates off of would be harmful.
The weirdness on the upload is shown in this screen shot.

Originally you had 149 pictures on this track,on the website there are 98 images. there is a bug which is known to us that the pictures are shifted from their position if one ro more of the mp4 files are missing. this will be fixed aproximately on monday.
Also the shutter animation white splash is done after encoding, not in the moment of the picture's creation, so the 10 flashes what you've seen were pictures taken at an earlier position being encoded from the frame queue. this will also be modified to reflect the moment of the pictures creation not the finishing of the encoding process.
The biggest issue is the shifting of the pictures, and it is our highest priority.

If this is a known bug and a fix is on the way then I'll delete the track to avoid confusing people. I'll wait until I see a new version of the app appear and try again.

I've still having this issue. . . I thought that once the BT ODBII issue was resolved this might fix itself but testing today and still have the same problem.
I deleted my test track to avoid issues with mappers thinking the images were in the correct location and the map was wrong.

@n76 for next time please don't delete the tracks, so that we can debug the issue. You don't have to worry about it reaching Osm thus degrading it, because our processing algorithm treats problematic tracks differently and also we can make exceptions.
If you leave the source data online, we have the base data, which probably is correct, so we can correctly process it after debugging the issue.

@kalmanbencze http://openstreetview.org/details/12223/21 same

Yess, thanks for this track. there has been 2 bugs happening here, I have just confirmed it. one is long fixed, the second is fixed in the 1.9.10 version of the app, but the fix on the server has not been deployed yet (need to reprocess older recordings).
You can leave these tracks on your account, no need to delete it. basically it's a meta data (which contains gyro, accelerometer, gps, compass, data) format bug, that's why it can be fixed with the reprocessing of the track.

Same problem here, using 1.9.10 version of the app. This image http://openstreetview.com/details/27139/328 is taken at the moment I leave D777. But for the website and JOSM, it is located 500m further in "Rue Jean-Marie Lacire".
If this is relevant, I have poor internet connection, and the upload has been paused/resumed several times. I have a copy of the files before the upload began, in case you need it.

@abienvenu Yeah its really annoying, we know about this issue. This is a display-only bug on the website. The data is correct no need to update it again, the locations and pictures are matched together correctly, but the way the website displayes it is wrong. There is already a script written which fixes it but it hadn't been deployed yet. I'll keep pushing.
Thanks.

@kalmanbencze I've uploaded yet another test. And despite reading that "this is a display-only but on the website", I see the photos misplaced in JOSM too and that is where it really matters. For example, the image at http://openstreetview.org/details/27186/12 is shown as being after passing under the motorway when it is clearly before.
In this case the GPX track actually seems to start and stop at the correct place (earlier tests had the track continuing on after I stopped recording photos). However the photos taken represent only about the first half of the track. There was no error indication on upload, so I don't know what happened to the other photos that must have been taken.
I did not have the OSV app clear the data on the phone, so there might still be something there that I could pull off for you.

@n76 Where does the data viewed in JOSM originate from?

The OSV layer from the OSV plugin.

@n76 Unfortunately the JOSM plugin uses the same OSV api as the website, thus displaying the wrong data. I made sure that what I tell you is not BS. Don't worry this is just an API issue through wich you obtain the data for: display on the website, JOSM, apps, etc.

@kalmanbencze So if a "armchair mapper" comes along, sees there are OSV images in the area and decides to "correct" the OSM data based on the images there is nothing to warn him/her of the misalignment. Sounds like this is a pretty serious issue and one ought to delete (or hide) tracks where the images are misaligned until it is fixed.

I think this is a duplicate of #38 -- if so can we close one of them @kalmanbencze @bogdans-telenav @mirunac-telenav ?


enable filtering and introduce flat account tree node

this PR implements the 2 items in this issue: https://github.com/microsoft/azuredatastudio/issues/12909

top level account grouping
filtering

Pull Request Test Coverage Report for Build 325168892

5 of 182 (2.75%)  changed or added relevant lines in 4 files are covered.
62 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 39.617%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/extension.ts
0
3
0.0%

src/sql/workbench/services/connection/browser/connectionBrowseTab.ts
5
52
9.62%

extensions/azurecore/src/azureResource/tree/connectionDialogTreeProvider.ts
0
50
0.0%

extensions/azurecore/src/azureResource/tree/flatAccountTreeNode.ts
0
77
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

src/sql/workbench/services/connection/browser/connectionBrowseTab.ts
58
7.43%

Totals

Change from base Build 325064918:
-0.1%

Covered Lines:
20540

Relevant Lines:
47588

💛  - Coveralls


Add envelope information to mail.Headers

Is your feature request related to a problem? Please describe.
From a mail message object there is not easy way to find out what envelope type was used to send it.
Describe the solution you'd like
Add envelope information to mail.Headers.

[ ] add header to rfc2822.EncodeNewMessage and set value e.g. X-Mailchain-envelope-type: 0x01
[ ] add header to rfc2822.EncodeNewMessage and set value e.g. X-Mailchain-envelope-type-encoding: encoding=hex/0x-prefix
[ ] use encoding.TypeHex0XPrefix to create encoding=hex/0x-prefix portion
[ ] expand mail.Headers to include EnvelopeType and EnvelopeTypeEncoding
[ ] expand rfc2822.parseHeaders to read envelope information`

I would like to work on this one


api/off Auto restarting &Method Now Allowed

edited...
Do you have example post requests?
ie for this:
POST /api/rainbow Set the unicorn to cycle through all 360 hues in the HSV spectrum?
Becuase http://ip.address:5000/api/rainbow results in this message:
Method Not Allowed
The method is not allowed for the requested URL.

You can do a post request with an empty JSON object {}.

Closing this issue, as this has been added to the documentation.


Improve UI of  LoginActivity

Description

Add welcome and app_name textview
Add ic_tv image
Improve paddings and margins

Issue Resolved
Fix issue #34
Screenshots

Checklist
Please make sure to review the following before submitting your PR:

[x] I have read the contribution guidelines.
[x] I have read the code of conduct.
[x] I have reviewed my submission in detail.

Lgtm, ty 😇


Create releases by using Travis-CI

We should try to build our releases using Travis-CI. The reference to ArcGIS Runtime SDK should be changed to the Nuget package of ArcGIS Runtime.

Travis-CI is using Mono so we have so many unsupported references like WPF in general. Right now, we won't fix this issue.


wasm_interp_call_func_native currupts frame->ip, causes SIGSEGV with native tail-calls

Subject of the issue
wasm_interp_call_func_native here uses prev_frame as frame origin. Next allocated frame will share same memory space as frame  in interpreter.  Then, it's ip will be set to NULL here. As a result, UPDATE_ALL_FROM_FRAME restores frame_ip = NULL, that causes crash on SIGSEGV on continue.
Test case
In call of _initialize. Specifically, in stappler_wasm_wasm_debug_print line 43.
module4.txt
Your environment

Ubuntu 22.04, x86_64, WASI SDK 21
WAMR 1.3.2 + WAMR  from /release/1.3.x

Steps to reproduce

Build WAMR with tail-call support
Define native functon like this:

static void StapplerWasmDebugPrint(wasm_exec_env_t exec_env, uint32_t ptr, uint32_t size) {
	auto mod = wasm_runtime_get_module_inst(exec_env);
	auto sptr = (const char *)wasm_runtime_addr_app_to_native(mod, ptr);

	printf(sptr);
	printf("\n");
}

static NativeSymbol stapper_wasm_symbols[] = {
	NativeSymbol{"debug-print", (void *)&StapplerWasmDebugPrint, "(ii)", NULL},
};

static void registerWasmModule() {
	wasm_runtime_register_natives("stappler:wasm/wasm", stapper_wasm_symbols, 1);
}

Run code from test case, call _initialize

Expected behavior
Should print TEST CTOR from native code
Actual behavior
SIGSEGV
Extra Info
Fixed this by adding SYNC_ALL_TO_FRAME(); after wasm_interp_call_func_native, but not sure, if it's correct solution.
Upd: Nope, it was not correct, it causes incorrect behaviour when 64-bit types returned from native.

@SBKarr Thanks for spotting issue! I checked the case, it should be caused by calling native function by opcode return_call, which is introduced by wasm tail call feature. Since the tail call uses the current frame and it is freed first and then allocated and overwritten (frame->ip = NULL) by wasm_interp_call_func_native, the later recovering frame_ip from its ip field is invalid. But I think after calling native function, the current frame_ip, frame_ref (and prev_frame) wasn't changed and are effective, no need to commit them to frame and restore them from frame again. Could you help check whether the below patch is better?
diff --git a/core/iwasm/interpreter/wasm_interp_classic.c b/core/iwasm/interpreter/wasm_interp_classic.c
index ca972fd4..43e71913 100644
--- a/core/iwasm/interpreter/wasm_interp_classic.c
+++ b/core/iwasm/interpreter/wasm_interp_classic.c
@@ -1509,6 +1509,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
     WASMStringviewIterObjectRef stringview_iter_obj;
 #endif
 #endif
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+    bool is_return_call = false;
+#endif
 #if WASM_ENABLE_MEMORY64 != 0
     /* TODO: multi-memories for now assuming the memory idx type is consistent
      * across multi-memories */
@@ -6227,6 +6230,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
                 frame_ip = frame->ip;
                 frame_sp = frame->sp;
                 frame_csp = frame->csp;
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+                is_return_call = false;
+#endif
                 goto call_func_from_entry;
             }

@@ -6320,6 +6326,7 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
         }
         FREE_FRAME(exec_env, frame);
         wasm_exec_env_set_cur_frame(exec_env, prev_frame);
+        is_return_call = true;
         goto call_func_from_entry;
     }
 #endif
@@ -6333,6 +6340,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
         }
         SYNC_ALL_TO_FRAME();
         prev_frame = frame;
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+        is_return_call = false;
+#endif
     }

     call_func_from_entry:
@@ -6394,9 +6404,14 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
                                              prev_frame);
             }

-            prev_frame = frame->prev_frame;
-            cur_func = frame->function;
-            UPDATE_ALL_FROM_FRAME();
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+            if (!is_return_call)
+#endif
+            {
+                prev_frame = frame->prev_frame;
+                cur_func = frame->function;
+                UPDATE_ALL_FROM_FRAME();
+            }

             /* update memory size, no need to update memory ptr as
                it isn't changed in wasm_enlarge_memory */
diff --git a/core/iwasm/interpreter/wasm_interp_fast.c b/core/iwasm/interpreter/wasm_interp_fast.c
index 21412046..599f7056 100644
--- a/core/iwasm/interpreter/wasm_interp_fast.c
+++ b/core/iwasm/interpreter/wasm_interp_fast.c
@@ -1501,6 +1501,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
     WASMStringviewIterObjectRef stringview_iter_obj;
 #endif
 #endif
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+    bool is_return_call = false;
+#endif

 #if WASM_ENABLE_LABELS_AS_VALUES != 0
 #define HANDLE_OPCODE(op) &&HANDLE_##op
@@ -5618,6 +5621,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
             {
                 frame = prev_frame;
                 frame_ip = frame->ip;
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+                is_return_call = false;
+#endif
                 goto call_func_from_entry;
             }

@@ -5766,6 +5772,7 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
         FREE_FRAME(exec_env, frame);
         frame_ip += cur_func->param_count * sizeof(int16);
         wasm_exec_env_set_cur_frame(exec_env, (WASMRuntimeFrame *)prev_frame);
+        is_return_call = true;
         goto call_func_from_entry;
     }
 #endif /* WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0 */
@@ -5838,6 +5845,9 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
         }
         SYNC_ALL_TO_FRAME();
         prev_frame = frame;
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+        is_return_call = false;
+#endif
     }

     call_func_from_entry:
@@ -5855,9 +5865,14 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
                                              prev_frame);
             }

-            prev_frame = frame->prev_frame;
-            cur_func = frame->function;
-            UPDATE_ALL_FROM_FRAME();
+#if WASM_ENABLE_TAIL_CALL != 0 || WASM_ENABLE_GC != 0
+            if (!is_return_call)
+#endif
+            {
+                prev_frame = frame->prev_frame;
+                cur_func = frame->function;
+                UPDATE_ALL_FROM_FRAME();
+            }

             /* update memory size, no need to update memory ptr as
                it isn't changed in wasm_enlarge_memory */

#3283

Before tail calling, the current frame was freed and the exec_env's cur_frame was set as prev_frame:
https://github.com/bytecodealliance/wasm-micro-runtime/blob/4ef724bbfffab1c7761b2674c483a8e7d7c840b8/core/iwasm/interpreter/wasm_interp_fast.c#L5766-L5768
then during tail calling to import function or native function, a new frame was allocated and then freed (see wasm_interp_call_func_native), so after tail calling, the current frame doesn't take effect again, and we should restore variables from prev_frame instead. If not, core dump may occur if we add an extra return_call in your case:
(func $stappler_wasm_wasm_debug_print (type 0) (param i32)
    local.get 0
    i32.load
    local.get 0
    i32.load offset=4
    return_call $__wasm_import_stappler_wasm_wasm_debug_print
    return_call $__wasm_import_stappler_wasm_wasm_debug_print
    )

I updated PR #3283, please help have a view and try, thanks.

Ok, this solution works in my case, thanks

Welcome, I merged the PR.


Excessive processing time causes channel failure

when i consume the data, i found that the channel fails. maybe because of saving the data time too long. my code binding channel is blocking ,but the rabbitmq queue data is remaining much.
please give me some suggestions.

ok, i find the solution . https://stackoverflow.com/questions/35438843/rabbitmq-error-timeout.
should set the channel qos

Relevant documentation guide.

Thanks!


Starting OpenVDB 7.0.0 development

Signed-off-by: Peter Cucka<EMAIL_ADDRESS>

Hmm, when we released 6.1.0 we bumped to 6.1.1 during dev: 130fe81444b9bfa393bdf8cecd507a4c6569a068
Should we be bumping to 6.2.1? This would help if, say, we made changes which depended on the library version prior to a 7.0.0 release.

Ordinarily, yes, we'd bump the micro version number, but with such a short release window for 7.0.0, I don't see us releasing another 6.2 version, unless it's for a critical bug fix.
But I'm OK with putting this PR on hold, if everyone's in agreement.

I agree with Peter, I think it's right to jump to 7.0.0 now. There's no plan to do another 6.x release and we need adequate time to stabilise any new changes, particularly related to ABI. Any critical issues that do come up in the next couple of months can always be added to a branch off 6.2.0 if necessary.


Can we run dotstow sync in just clone only mode without granting write access to the repo ?

I want to setup a new computer with dotfiles without the need of writing any changes from that computer. Think of it as a secondary computer to me.
Looks like we need to setup ssh-agent keys to have the initial clone done which personally to me a very bad idea. I should be able to clone a public repo without actually requesting anything. That would also allow me to try other users dotfiles as well.

When setting up dotstow, you can provide the repo using http protocol instead of ssh.
dotstow sync
github username (codejamninja):
dotfiles remote (git@github.com:codejamninja/dotfiles.git): https://github.com/codejamninja/dotfiles.git

However like you mentioned, it tries to commit any new changes and push them during sync.
https://github.com/codejamninja/dotstow/blob/master/src/actions/sync.ts#L25
https://github.com/codejamninja/dotstow/blob/master/src/actions/sync.ts#L29
I think the best approach would be to create a new command called pull that only pulls the dotfiles.
What are your thoughts?

I just created a basic pull request that would achieve something similar to what you want. We would need to first figure out how to handle any modified files though.
https://github.com/codejamninja/dotstow/pull/9/files#diff-a8e6e270f2910fc45939f0017baed090R16

yeah, creating a new pull command makes sense and would be simpler.
To catch the changed files, we probably need a cache with the files and timestamps. But, I guess the changes would be not trivial

@sreerajkksd would you mind submitting a pull request for that?

Yeah, I can do that once https://github.com/codejamninja/dotstow/pull/9 is merged to master.

@sreerajkksd I just merged it.

This should work because it pulls first (although it might give an error status).


Design Federation feature for single Tornjak/SPIRE instance

We would like to extend Tornjak to make the Federation management experience easier.
This involves backend decision of using the SPIRE API or potentially the controller manager CRDs.
The frontend needs design of how the page will look and what functionalities will be most important.

The major pain point of configuring federation seems to be due to the exchange step. Currently, this takes three steps:

Obtain a trust bundle from the source SPIRE server
Format the API call or CRD to be called/placed into the target SPIRE server
Make the API call

Additional nice-to-have features:

Federation list
Easy way to view workload entries that federateWith each trust domain

Here's a proposed set of steps:

Implement view-type APIs and frontend features

Backend API: needs to add bundle show/list and federation list
Frontend UI:

A new page at the top for Federation.

Federation List
Bundle List

A place to view THIS SPIRE server's bundle (and perhaps display the properly formatted CRD or api call for other SPIRE servers to federate with this one)

Implement write-type APIs and frontend features

Backend API: needs to add bundle set/delete, and federation create/update/delete
Frontend UI:

A page to Create Federation and Set Bundle. These maybe should be the same page.
Buttons to delete bundle or federation relationships

Additional Features

Add a way to view workloads with federatesWith


Allow different map name to be passed in. Add icon to button. Button to ...

Allow map instance name to be passed in as second variable, after uri.
Added icon to button, icon is from Google Material Design set.
Amended button size from 20x20 to 30x30px to match the default layer control button size.

I think the control should not add itself to the map at all. That's what the .addTo(map) is for.


Add NATS Channel to the addressable-resolver-clusterrole

addressable-resolver-clusterrole is missing since it was added to eventing/contrib/nats after merging nats CRD here

/assign @montaro


hide extra members of U

When looking at the U signature of a given Rune, I see typeof CtorName for every CtorName. For instance:
const billyFree = System.Account
  .value(billy.publicKey)
  .unhandle(undefined)
  .access("data", "free")

billyFree
// ValueRune<bigint, typeof ConnectionError | ConnectionError | typeof ServerError | ServerError | typeof ScaleError | ScaleError | undefined>

The signature should instead appear as follows:
ValueRune<bigint, ConnectionError | ServerError | ScaleError | undefined>

Yeah, this typing isn't correct. They're not really extra member so much as incorrect members.


Add support for iOS shared container spaces as a DB location

Allows me to open a DB instance using iOS shared data containers for a specified app group. A valid app group name must be specified in the app's (and any extensions') Info.plist under the AppGroupName key.
There's probably some other work to be done, like documenting how to use it and possibly error handling. Please let me know what you think.

addresses #308
all credit goes to @jordoh who put a snippet demonstrating how to do this in the above thread

This is a nice feature. Could you please propose documentation changes/usage to make this PR complete?

Thanks for the feedback @andpor. I have added some fairly straightforward instructions on how to use this feature to the main README.

Hi @andpor. Do you have any time to give this a bit of a review at its current state so we can see where we need to go from here?

@andpor  Hey there I am implementing exactly this feature into an application this week. I will be patching a copy of this package based of this PR but it would be nice if it were merged in officially so that I don't have to maintain it going forward.

I am merging this - will cut the release tomorrow


[W4.11e][T16-1]Lionel Tan Junzer

Please refer to the review comments and close the PR after acknowledging them 😄


Deprecate inverse frames: Documentation

Description
In preparation for #1195, we need to remove all references to inverse frames in the documentation.

dup of #1215


tasks command environment

VSCode Version: 1.2.0
OSX Version: 10.11.5

In the documentation http://code.visualstudio.com/docs/editor/tasks it seems there is no easy way to configure crosscompile environment varaibles:
GOOS=windows GOARCH=386 go build -o build.exe
A new "environment" property for each task would enable easier setup for go and many other compile tools. For example to achieve the above command:
{
    "version": "0.1.0",
    "command": "go",
    "isShellCommand": true,
    "showOutput": "always",
    "program": "${workspaceRoot}",
    "tasks": [
        {
            "taskName": "test",
            "args": ["-v", "-race", "-port=8080"]
        },
        {
            "taskName": "build",
            "environment": ["GOOS=windows", "GOARCH=386"],
            "args": ["-o", "build.exe"],
            "isBuildCommand": true
        }
    ]
}

Just want to add that maybe in the future there could also be a request to add a task group. For example to be able to build for different environments at once. In this case there can be multiple builds with the same taskname. But I suggest to just keep it simple at first and just go with the extra "environment" property for now.

I fold this issue with #8143. That one asked for cwd per tasks and if we do that we should for consistency also support env per tasks


i hope Unity.Configuration could support .net framework4.0

我现有项目所有类库均是framework4.0（为了支持xp），在引入Unity后发现无法引用Unity.Configuration，因为它不支持4.0，希望以后能支持framework4.0，万分感谢！

All of my existing project libraries are framework4.0 (in order to support XP), I found it impossible to reference Unity.Configurationafter introducing Unity because it doesn't support 4.0, I hope it can support framework4.0 in the future. Thank you very much!

Would you like to port it into .Net 4 and send a pull request?

Fixed in https://github.com/unitycontainer/configuration/commit/091d5cc43526a5006ca6bbc372ad187f08cef3ce


Give a better error with Swashbuckle.AspNetCore.Cli when there is .dll version mismatch

If one uses dotnet tool to install Swashbuckle.AspNetCore.Cli and the actual project uses different version of Swashbuckle.AspNetCore.Swagger.dll (e.g. 6.5.0 vs 6.4.0) you will get error like
Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'Swashbuckle.AspNetCore.Swagger, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=62657d7474907593'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Swashbuckle.AspNetCore.Swagger, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=62657d7474907593'
   at Swashbuckle.AspNetCore.Cli.Program.<>c.<Main>b__0_3(IDictionary`2 namedArgs)
   at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\CommandRunner.cs:line 68
   at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\CommandRunner.cs:line 59
   at Swashbuckle.AspNetCore.Cli.Program.Main(String[] args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\Program.cs:line 111

but it would be better to tell the use that there is a version mismatch.
So something like:

Swashbuckle.AspNetCore.Cli version 6.5.0 cannot process %path%/Swashbuckle.AspNetCore.Swagger.dll because it is based on version 6.4.0 and both versions must match!

You could suggest that any tool write custom exception messages to handle mismatched dependency versions in any combination.
This isn't worth us maintaining custom support for.


The difference between "VART" and "Vitis AI Library"

Hi. I am a newcomer of Vitis-AI. I want to run some demo samples, but I found that there are similar samples in "VART" and "Vitis AI Library". I wonder what's the differences of them?

VART == Vitis AI Run Time
The key difference is that Vitis AI Libraries is one extra layer on top of VART that provides utility functions for common ML models. It dives in to higher level application like object detection for example.
VART is more the mechanics of feeding data to the accelerator in the FPGA.


Twitter not show count (count.json)

Hi, twitter not show count.
Can you help me.
Thank you.
Error: Failed to load resource: the server responded with a status of 404 (Not Found)
/**/jQuery11110980863899923861_1448271148530({"errors":[{"message":"Sorry, that page does not exist","code":34}]});
https://cdn.api.twitter.com/1/urls/count.json?url=urltest&callback=jQuery11110980863899923861_1448271148530&_=1448271148531

https://github.com/tabalinas/jssocials/issues/27

Mdiaw2550, it's not possible (since 20th of November) to get Twitter shares count. Now it's possible only with native twitter share button. Sorry.

Hi, tabalinas, can I offer newsharecounts.com as an optional alternative to the shut down API? It requires user to sign-up with their Twitter account and specify the website, and than share counts are tracked and can be fetched from public API.

one of the big drivers for using jssocials is the fact that my website doesn' t have to do external calls to scripts that I cannot control, that use my visitors click and share behaviour and that I have to explain to my users why I am sharing their data with third parties. And probably it will slow down my site.
for me that doesn' t weight up to having the count.
just my 2 cents :)


PGE failure

So i'm running it now and its working in terms of the Crawl via proteus.
What I do see in the logs though is
SEVERE: PGETask FAILED!!! : Failed to build PgeConfig : Failed to parse value: SQL(FORMAT='$FileLocation/$Filename',SORT_BY='CAS.ProductReceivedTime'){SELECT FileLocation,Filename,CAS.ProductReceivedTime FROM RatLog}
java.io.IOException: Failed to build PgeConfig : Failed to parse value: SQL(FORMAT='$FileLocation/$Filename',SORT_BY='CAS.ProductReceivedTime'){SELECT FileLocation,Filename,CAS.ProductReceivedTime FROM RatLog}
	at org.apache.oodt.cas.pge.config.XmlFilePgeConfigBuilder.build(XmlFilePgeConfigBuilder.java:68)
	at org.apache.oodt.cas.pge.PGETaskInstance.createPgeConfig(PGETaskInstance.java:217)
	at org.apache.oodt.cas.pge.PGETaskInstance.run(PGETaskInstance.java:109)
	at org.apache.oodt.cas.workflow.engine.IterativeWorkflowProcessorThread.executeTaskLocally(IterativeWorkflowProcessorThread.java:573)
	at org.apache.oodt.cas.workflow.engine.IterativeWorkflowProcessorThread.run(IterativeWorkflowProcessorThread.java:324)
	at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.oodt.cas.pge.exceptions.PGEException: Failed to parse value: SQL(FORMAT='$FileLocation/$Filename',SORT_BY='CAS.ProductReceivedTime'){SELECT FileLocation,Filename,CAS.ProductReceivedTime FROM RatLog}
	at org.apache.oodt.cas.pge.util.XmlHelper.fillIn(XmlHelper.java:461)
	at org.apache.oodt.cas.pge.util.XmlHelper.fillIn(XmlHelper.java:439)
	at org.apache.oodt.cas.pge.util.XmlHelper.getMetadataValues(XmlHelper.java:204)
	at org.apache.oodt.cas.pge.config.XmlFilePgeConfigBuilder.loadCustomMetadata(XmlFilePgeConfigBuilder.java:146)
	at org.apache.oodt.cas.pge.config.XmlFilePgeConfigBuilder.loadConfigFile(XmlFilePgeConfigBuilder.java:101)
	at org.apache.oodt.cas.pge.config.XmlFilePgeConfigBuilder.build(XmlFilePgeConfigBuilder.java:64)
	... 6 more
Caused by: org.apache.oodt.cas.filemgr.structs.exceptions.CatalogException: org.apache.xmlrpc.XmlRpcException: java.lang.Exception: org.apache.oodt.cas.filemgr.structs.exceptions.CatalogException: Failed to perform complex query : null
	at org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.complexQuery(XmlRpcFileManagerClient.java:997)
	at org.apache.oodt.cas.pge.util.XmlHelper.fillIn(XmlHelper.java:456)
	... 11 more
Caused by: org.apache.xmlrpc.XmlRpcException: java.lang.Exception: org.apache.oodt.cas.filemgr.structs.exceptions.CatalogException: Failed to perform complex query : null
	at org.apache.xmlrpc.XmlRpcClientResponseProcessor.decodeException(XmlRpcClientResponseProcessor.java:104)
	at org.apache.xmlrpc.XmlRpcClientResponseProcessor.decodeResponse(XmlRpcClientResponseProcessor.java:71)
	at org.apache.xmlrpc.XmlRpcClientWorker.execute(XmlRpcClientWorker.java:73)
	at org.apache.xmlrpc.XmlRpcClient.execute(XmlRpcClient.java:194)
	at org.apache.xmlrpc.XmlRpcClient.execute(XmlRpcClient.java:185)
	at org.apache.xmlrpc.XmlRpcClient.execute(XmlRpcClient.java:178)
	at org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.complexQuery(XmlRpcFileManagerClient.java:992)
	... 12 more

Looking at it in a debugger its because
https://github.com/apache/oodt/blob/release-1.2.2/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java#L1431-L1440
returns null and the query is empty, it seems. But I can trace that same method back to OODT 1.0 and before and its not changed, so has DRAT always reported this, or is this something new?

Okay tested against 1.1 and don't see it, so I guess its an OODT regression... debugging.

This looks like the RatAggregator Task is getting fired off before there are any RatLogs. You can check this in your Opsui FM browser. What do you see when you get this error?

checking, I'll let you know shortly.

Trying to figure out some of the wiring. The Lucene bug was from OODT using the lucene catalog, but there's a solr server and the mimepartitioner seems to query it? But its empty when I run it.

Alright, as i mentioned in the slack channel I think this is a non issue and is infact cause by the docs being a bit stale and missing the alias stuff as I've stuck it in and its now been indexing for 30 minutes. Have to shut it off and catch a flight but I think if you test the OODT PR from yesterday this issue will likely go away.

Okay after a myriad of env vars getting set, I think this is a non bug.


Implement importDockerImage function

Import the specified image into docker with repotag,
instead of loading image without repotag provided in
metadata.
Returns the message produced by the docker daemon.

Why are we importing images (via the API of docker import) instead of loading them (via the docker load API)?
KIWI is meant to build native docker images that can be imported via docker load. From now on we should build all our images using KIWI + umoci, even the base ones.

Hi Flavio, problem was that docker load image is ignoring repository name and tag, which are provided as option. In our case these two options are provided in metadata file to each docker image build by KIWI + umoci. I will adopt this change and I will implement condition:

if metadata will not be provided (only docker image) container-feeder will use ImageLoad function
if image will be provided with metadata file, this will use ImageImport function to use also repository name and tag name

@flavio : Please let me know, if I'm going with right approach

Why don't we always use the "docker load" API and, if the metadata file is specified, we later call the "docker tag" API?

Closing the PR as discussed on mumble.


Duplicate key Layout/LineLength in .rubocop_todo.yml when Layout/LineLength is enabled via comment

When generating .rubocop_todo.yml with --auto-gen-only-exclude option, if a file contains both a Layout/LineLength offense and disable Layout/LineLength rule for block (thus re-enabling it afterwards), then the resulting .rubocop_todo.yml contains two entries for Layout/LineLength and rubocop still reports offenses afterwards.
This issue don't happen in 1.45.1. It manifests from 1.46.0 until 1.52.0. I was able to bisect it to this commit: https://github.com/rubocop/rubocop/commit/efce268820e4dbbb4a85a61d3510ab351d4d0c4f (PR #11603).
Expected behavior

.rubocop_todo.yml should not have duplicate keys.
running rubocop after generating .rubocop_todo.yml should not report any offenses.

Actual behavior

.rubocop_todo.yml contains duplicated blocks for Layout/LineLength, with different set of Exclude files.
running rubocop after generating .rubocop_todo.yml still report offenses.

Steps to reproduce the problem
Create an app with the following files:
foo.rb
# frozen_string_literal: true

# This is Foo
class Foo
  def foo
    puts 'This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo'
  end

  # rubocop:disable Layout/LineLength
  def bar
    puts 'This is Bar'
  end
  # rubocop:enable Layout/LineLength
end

.rubocop.yml
inherit_from: .rubocop_todo.yml

AllCops:
  NewCops: enable

Run
rubocop --auto-gen-config --auto-gen-only-exclude

.rubocop_todo.yml
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude`
# on 2023-06-09 14:31:12 UTC using RuboCop version 1.52.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Layout/LineLength:
  Exclude:
    - 'foo.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Layout/LineLength:
  Exclude:
    - 'foo.rb'

Run rubocop
.rubocop_todo.yml:13: `Layout/LineLength` is concealed by line 21
Inspecting 2 files
.C

Offenses:

foo.rb:6:121: C: Layout/LineLength: Line is too long. [130/120]
    puts 'This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo This is Foo'
                                                                                ^^^^^^^^^^

2 files inspected, 1 offense detected

The problem does not happen with version 1.45.1. It happens from version 1.46.0 up to 1.52.0.
Context
While it would be easy to workaround the examples above, our use case is that we use Annotate gem to generate schema info comments for our classes, and because some annotations lines can be longer than the defined LineLength, we wrap schema info annotations with # rubocop:disable Layout/LineLength and # rubocop:enable Layout/LineLength, using wrapper_open and wrapper_close options from Annotate.
But it also annotate specs and fabricators which we generally exclude from Layout/LineLength via an Exclude option 'spec/**/*'.
The problems seems to be that # rubocop:enable Layout/LineLength actually enables the rule, even if file is in the exclusion list, instead of just restoring to the "previous state" it has before the # rubocop:disable Layout/LineLength.

Hi @guigs, could you check if this still is a problem for you? I tried reproducing but it seems to jus work for me.


Keeping exif data

Hello, I was wondering if it was possible to keep the exif data when the image passes through glide?

Is this possible? Why did you close the issue?

I actually have the same question ... Found nothing in the documentation, just noticed, that the exif data is gone.


Added classes for SCALED_IMU2 and SCALED_IMU3 to mavlink_messages.cpp.

Hi
This PR restarts PR #9520 back to essentially the first commit of that PR.  It adds classes for the SCALED_IMU2 and SCALED_IMU3 messages to mavlink_messages.cpp and corrects a sensor_gyro_s variable type.
The hardware I am testing on only has two IMUs and I have not been able to test on hardware with 3 IMUs.  For convenience, below are screen captures from QGC mavlink inspector of the current upstream master and this PR showing the message output by adding SCALED_IMU, SCALED_IMU2, and SCALED_IMU3 to the config stream list of mavlink_main.cpp and connecting via USB to QGC.
The values reported back through SCALED_IMU and SCALED_IMU2 do not seem to be correct, believed to be a driver level bug yet to be resolved.  Up to the present I have been unable to create a working templated SCALED_IMU class implementation in mavlink_messages.cpp.  If successful in creating a templated solution to the additional messages I will submit a subsequent PR.
Please let me know if you have any questions on this PR.  Thanks!
-Mark
1)Current PX4/Firmware master branch:

This PR

@mcsauder What is your testing status by now?

Hi @LorenzMeier , thanks for the ping!
This PR is functioning properly.  We've been flying this code for the past 10 days, about 5 flight hours on it just yesterday.  While this PR is complete, I am disappointed that I have been unable to get a templated version of this PR functioning.  Additional work remains elsewhere in the code base to deliver the proper values in these messages that this PR does not address.
Please let me know if you have additional questions about this PR!
-Mark

Hi @LorenzMeier, everything you identified has been addressed and pushed up. Thanks again for your feedback and let me know if you would like to see anything else addressed!
-Mark

@LorenzMeier , I'm just checking in on this PR.  Let me know if a better solution is required and if you can see one.  I've posted an issue in the mavlink repo that might lead to a better solution/implementation: https://github.com/mavlink/mavlink/issues/949
Let me know what you'd like to see, and thanks!
-Mark

This PR is fine given the current state of mavlink. I believe the main reason it wasn't merged the last time I looked is px4fmu-v2 flash constraints.
Looks like it's fitting at the moment.


allow watch constructor to take a clientapi object as a parameter

To be consistent with other constructors that allow ApiClient to be passed as a parameter.

Codecov Report

Merging #49 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   93.64%   93.66%   +0.01%
==========================================
  Files          11       11
  Lines         866      868       +2
==========================================
+ Hits          811      813       +2
  Misses         55       55

Impacted Files
Coverage Δ

watch/watch.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11da619...5f64d4a. Read the comment docs.

@mbohlool ptal


Removes third party package link

Now that Blueprint has first party support for PestPHP test generation 🎉
https://github.com/laravel-shift/blueprint/releases/tag/v2.8.0
I have decided to archive my package.  So happy it made it into core eventually 🙌

Awesome. Thanks for you work on the original package. Feel free to tweak the first-party version anytime. 👍


increase default precision for hyp1f1

Following #21503 issue, I increased the default tolerance for hyp1f1. @HansN87 be aware that I did not test this implementation for negative values of the parameters. As you highlighted, the convergence criterion might be a bit trickier to handle in this situation.

Thank you.

Should this tolerance value be tuned to the dtype? 1E-15 seems like it might be too small in the case of float32.

It changed the precision to 10 times the lowest by default precision for x32 or x64, and messed up a bit the commit history too. Tell me if this is good for you @jakevdp, I will squash the commits tomorrow

Looks good, thanks. My last concern would be what this means for bfloat16 or float16 inputs, but I don't think we've ever had test coverage for that. I suspect it's fine.

Test were all green! I added a safeguard to limit the inputs to float32/64


AURO MIGRATION: Update node to v22

Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node.js to v22.
Enhancements:

Update Node.js version requirement to v20 or v22.

CI:

Update CI workflows to test against Node.js v22.

:tada: This PR is included in version 8.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Started fixing "people" area in settings page

Need to fix centralization of some elements

Already implemented here. Thanks.


Unable to delete volumes and backend

Describe the bug
The backend vServer was deleted without removing any existing PVs.
Now there are "ghost" volumes and a backend which we are unable to delete.
This is the command we are trying to run:

tridentctl delete volume -n trident pvc-1658cfcd-764c-4d89-81ff-ce4378688318

This is the error message we are getting:

Error: could not delete volume pvc-1658cfcd-764c-4d89-81ff-ce4378688318: error checking for existing volume: Post "https://{IP}/servlets.admin.XMLrequest_filer": dial tcp {IP}: connect: no route to host (400 Bad Request).

There are no PVCs or pods attached to those volume in the Kubernetes side and there are no snapshots.
There are other backends and production volumes so we can not purge trident entirely either.
Environment
Provide accurate information about the environment to help us reproduce the issue.
I'll add the environment details later in another comment.

Trident version: [e.g. 19.10]
Trident installation flags used: [e.g. -d -n trident --use-custom-yaml]
Container runtime: [e.g. Docker 19.03.1-CE]
Kubernetes version: [e.g. 1.15.1]
Kubernetes orchestrator: [e.g. OpenShift v3.11, Rancher v2.3.3]
Kubernetes enabled feature gates: [e.g. CSINodeInfo]
OS: [e.g. RHEL 7.6, Ubuntu 16.04]
NetApp backend types: ONTAP NFS

Thanks! It helped :)


fresh example for Deno

found a nice demo for deno:
jspm install denoland:fresh/server.ts --env=deno

which works perfectly actually.

Sure, it works, but what should I add as an example?

Having a fresh example, that just works with deno! + installing some nodejs dependencies in the importmap.


Latest export doesn't export

Latest export doesn't ask for a destination file and opens a window.
The window doesn't seem to have any json in it.

Sorry, I haven't tested the desktop versions of Twine yet, probably a dependency is not loading for some reason.
Can you try exporting on the online version for now?
https://twinery.org/

Will do as soon as I get back home.
Thanks.

Yep, works from web version. Not from the app.

Great, thanks for testing it. I'll fix as soon as possible.

@richardlalancette I fixed it for OSX desktop, I can't test on a Windows machine right now. If you could that would be great.
0.1.3 also fixes bugs related custom properties '{{foo}}' that were not working and other minor stuff.

Working great on windows now.
2 save file dialog are opening and they are saved properly.
The 2 type of export are also shown in a window.
Looks like this is completely fixed.
Going to start writting our game stories now, so i'll keep you informed on the status of the exporter :)
Thanks again!

Great, I'll be here to help! 💪


array of arrays

Looks like a great work!!! Well done!
I just got a main issue, with arrays .. and in particular when an array is containing complex types like as objects or other arrays.
Example.

Editing a schema with an array of array, updating to create the form - this works fine
Loading the schema - this work fine
Editing the data - this work fine
Now save both schema and data
Load schema and data - this works fine but...

the second level array of the existing data doesn't allow to add new items, instead it allows to add a property (not following the    schema)
if you specified "required" for the second level array, you can't re-export the same data you loaded

schema.json:
{
"description":"A schema",
"properties":{
"methods":{
"type":"array",
"description":"1st level array",
"items":{
"type":"object",
"description":"The definition",
"properties":{
"parameters":{
"type":"array",
"description":"2nd level array",
"items":"string",
"required": true
}
}
}
}
}
}
data.json:
{
"methods": [
{
"parameters": [
"aa",
"bb"
]
},
{
"parameters": [
"ddd",
"fff"
]
}
]
}
But this is going to be a great tool!!
Christian
PS.
Ah, if you add booleans, when you load the data you get an error, variable valData is not declared, line 540

Thanks for the report. I haven't tested everything intensively. So, this kind of report will be very helpful.
For the issue itself, I will investigate and try to fix it.


Random models not exporting

Certain models are permanently bugged in that clicking the export button for them does not prompt for a file location. This is not an issue with model data given I have tested making several duplicates of the same blank cube and exporting it only to get varied results.

Apparently removing the textures from the model seems to fix the issue, discovery courtesy of Mister_Andy_Dandy :-]


Sync with dev for the first sprint.

This brings trunk up to date with dev up to sprint 1.

Codecov Report

:exclamation: No coverage uploaded for pull request base (trunk@2f43823). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             trunk      #23   +/-   ##
========================================
  Coverage         ?   78.35%
========================================
  Files            ?       10
  Lines            ?      231
  Branches         ?       15
========================================
  Hits             ?      181
  Misses           ?       43
  Partials         ?        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


cmdline interface + time benchmark to LTR module

As mentioned in #1387 #1386, it has simple cmd line interface for debugging purpose. Also include some debug operations for concurrent problem

@nsndimt can you take a look?
@stephaniewhoo any insights on what's fast and what's slow?

@nsndimt can you take a look?
@stephaniewhoo any insights on what's fast and what's slow?

Here's a sample run.

And what's the impact of PMI on effectiveness? I.e., what's MRR if we take it out?

And what's the impact of PMI on effectiveness? I.e., what's MRR if we take it out?
It's a bit weird...

It'd be pretty difficult to write test cases for this... @nsndimt any testing ideas?
If we don't have any reasonable ideas, then we can take the hit - I can override and merge when everything is sorted ot.

I cannot think of a quick and good testing plan for this cmdline interface. I think we skip this for now.


A couple of minor fixes

Issues I noticed while integrating the latest changes into Anki. The rename would also be appreciated when merging this in :pray:

Thanks Jarrett. I'm going to try integrating the reviewing portion over the coming days.

I'm going to try integrating the reviewing portion over the coming days.

There are some exceptional cases to deal with in re-calculate the stability. Such as set due date, forget, incomplete revlogs and so on. I have written some code to handle them. It would be helpful to you:
https://github.com/open-spaced-repetition/fsrs4anki-helper/blob/a26bc62148f4c09db1c9dab508d8ea79413c0244/schedule/reschedule.py#L367-L453

To start with, I'm focusing on updating s/d when weights are changed, and integrating next_states() into the Anki scheduler. Once the basics are done, we can look into those other cases. It would be helpful if you could briefly describe the issues you faced, as that would help me follow what the code is trying to do.

I opened a new issue to collect these cases:

#63


Add release_connection setting to not release the connection

resolves #201
Description
When a connection is released, it is marked as closed. This is fine for other connectors, but Snowflake is a Cloud Data Warehouse where you could have a high latency connection to the server. You are also logged in for every query you issue with dbt, which can cause query times to be slow, as you have to go through the entire login process again.
Instead, this will allow you to reuse the connection.
Now this makes a MASSIVE difference for me with views, not so much with tables, but will still take a second or so off table creation as you don't have to reauthenticate. Views that were taking 2-3 seconds now take <0.5s! I'm from Perth, Australia, so your numbers will be a lot better than mine, as I'm ~250ms away from us-east-1.
Using 16 threads:
Before:  Finished running 101 view models, 49 table models in 0 hours 1 minutes and 34.24 seconds (94.24s).
Now: Finished running 101 view models, 49 table models in 0 hours 1 minutes and 6.09 seconds (66.09s).
Just views:
Before: Finished running 148 view models in 0 hours 0 minutes and 48.72 seconds (48.72s).
Now: Finished running 148 view models in 0 hours 0 minutes and 12.05 seconds (12.05s).
The biggest win for this comes from dbt test:
dbt test (8 threads):
Before: Finished running 798 tests in 0 hours 5 minutes and 58.47 seconds (358.47s).
Now: Finished running 798 tests in 0 hours 0 minutes and 56.99 seconds (56.99s).
Before adding tests around this, I would like to know that everyone is happy with this change. I've put this behind a release_connection setting, which defaults to True. This will allow users to test this and ensure that it works for them, then we could make this default at some point.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

Super cool findings @joshuataylor! I'm going to mark this ready for technical review.
I do think we'll need/want extensive testing for this. A few years ago, we ran into issues around leaving connections open + client_session_keepalive (https://github.com/dbt-labs/dbt-core/issues/2645, https://github.com/dbt-labs/dbt-core/pull/2650 — I linked these in the dbt-core issue as well):

The problem here is that the background thread that the snowflake connector starts is hanging, because dbt never calls close() on the handle.

So - worth thoroughly testing, including that specific reproduction case in the RPC server / IDE!

Yeah that might leave open connections for RPC. Could we maybe check that if the client_session_keepalive is on, we won't do this?
It could cause an impact if you have say 8 threads, then 1 long running model as the final model, or if you have a model in the middle which is long.
For example with this change if you had the setting enabled:

model1, model2, model3 are quick to execute and can run in parallel, great
model4 which relies on the above models takes a while to execute, oh no now we have 2 open connections sitting with the heartbeat, which snowflake-connector-python will keep alive for us.
model5-8 will reuse connections as per normal.

Few short term options:

We don't allow client_session_keepalive  and connection reuse to be enabled at the same time, or display a warning.
Actually close any extra threads after a time period. This change which will probably require dbt-core changes (but honestly we should just do it on the dbt-snowflake connector)

I want this!

@joshuataylor seems this pr will also need the changie process ran, and might have some minor conflicts with more recent work in same space. based around some new connection logic changes similar to your query_tag pr

Josh! Hello! 👋  This is a huge win when we get it merged in. 💥
I've had my eyes on this for a bit, and have had some time to recreate the issue and experiment with your solution! I'm wrapping up an evaluation of your solution. My main concerns at the moment are:

knowing precisely how these booleans affect the code
asynchronously concerns -- I get scared when I see lock invocations

I'm doing a bit of testing and can circle back soon. If you'd like to keep working on this at that time, I'm happy to guide you through, or I could cherry pick your work so far onto a dev branch. Up to your appetite for pushing this over the finish line.

Also, fyi, As the synk error is not apparently your fault, and something we'll request an override for at an appropriate time!

All good! Sorry, been super busy here with a few things but can make some time to work through this here if anyone has any questions.
I've been running this locally and it's been working fine, but I also am unsure about the long running queries as mentioned. IMHO, the whole thing should be overhauled (connections are incredibly tricky, and when you have oauth and other things you might want to oauth first, then use that token elsewhere, I believe this is currently an issue with dbt-snowflake) but I'll make another discussion for that.

First of all no apologies needed! It's a busy time of year and there's certainly no immediate expectations you'd be down to deal with all those intricacies. I'm just gauging your continued interest. We ❤  your commits
We'd restart by getting this branch passing, since right now it's skipping some adapter tests (we'll handle the overrides for other failing checks like synk which aren't on you)


Improve Type Checking of SQL types in planning

#439 raised the issue of subtraction producing incorrect generated code, leading to a compile time failure. This is partially addressed in #441, which will return a planning error if a projection calculation returns an unsupported type, including a Duration. However, there are still issues if there are problematic expressions nested within calculations. For instance, the following query plans successfully but produces the same compilation error:
select CAST(bid.datetime - DATE '2023-12-03' as string)
from nexmark
group by 1;

This is fixed in 0.10.


Building OpenSSL myself so that Ruby can have latest version of OpenSSL?

I have a pre-built version of OpenSSL 1.0.1m, and I would like to get it to build with rubyinstaller. I have no problems with uploading it here or something so that RubyInstaller can pull it down during installation process. But is there anything I need to know about how OpenSSL needs to be compiled, how I ought to be arranging produced files it into the nice tarred up format that I'm seeing on Bintray?

It's actually really easy to upload things to a personal repository on Bintray if you would like.
If you add recipe to knapsack-recipes and I will build it then I will build it locally and upload the binaries to the OpenKnapsack repo on Bintray. For an example see: oneclick/knapsack-recipes#8
As for the format, it's from knap-build. I use this command:
C:\...\knap-build> .\bin\knap-build.bat openssl -v 1.0.1l --package

As for how to use locally build versions @jonforums has a nice quick little hack to do so. He posted a reference to it in #254 in this comment.


fix null pointer access when http 1.0 request is rejected

When an HTTP 1.0 request makes it to envoy, envoy rejects it before adding the "x-forwarded-proto" to the request headers.
If there's an encoder filter that access the route() method, and ssl is required, this will cause invalid access to headers.ForwardedProto(). This PR fixes that by checking if headers.ForwardedProto() is valid prior access
Risk Level: Low
Testing: Unit Tests
Docs Changes: N\A
Release Notes: N\A
Fixes: https://github.com/solo-io/gloo/issues/635

/retest

/retest - it seems that coverage timed out and tsan failed due to hds_integration_test
(which may be interesting for other reasons. see log here: https://191153-65214191-gh.circle-artifacts.com/0/failed-testlogs/test/integration/hds_integration_test/test.log)

@yuval-k do you mind merging master?
/wait

Sounds good. thank you for the review!

@alyssawilk please could you give your feedback so it get merged? thanks!

I believe I did already this morning.   See above?
"I think at a high level it'd be good to say guaranteed headers are always set (host/authority, forwarded-proto etc) or not always set (always do nullptr checks) and try to be consistent about it. I'm fine going either way but I'd like to be mindful (this implicitly does the latter) and ideally follow a no-stalebot clean up audit in either direction."
I'm wondering if Matt has an opinion which way we go.  Again I'm fine with either, but I do want to make sure we are consistent and I thought previously we'd leaned towards adding absent headers rather than null checks.

Thanks for the insight @alyssawilk.
My 2 cents here are that I think the root of the problem here is, that the invariant "x-* headers are set" does not hold when a request is rejected. ActiveStream::decodeHeaders can reject the request for various reasons before calling ConnectionManagerUtility::mutateRequestHeaders.
So if we are going with not adding null checks, it probably means that we need to call ConnectionManagerUtility::mutateRequestHeaders first thing in ActiveStream::decodeHeaders  (which probably has consequences of which I am not aware of, as I am not familiar with this part of the code).
Like you, I am fine with either approach, but unsure on how to move forward. Looking forward to hear from you and @mattklein123 on how to proceed.

Like you, I am fine with either approach, but unsure on how to move forward. Looking forward to hear from you and @mattklein123 on how to proceed.

I don't have a strong opinion on this. I agree with @alyssawilk that we should try to be consistent though it might be difficult to always do that. IMO we should probably do the null check here as IMO it's the most safe from a logic perspective, and perhaps open an issue to think about this further as @alyssawilk mentions? @yuval-k can you open the issue and cross link it? Then I think we can merge this as long as @alyssawilk is OK with it.

I'm fine with null checks being the default, but I'd prefer we do them consistently in the HCM rather than "only for error handing" since we get feature creep on what code ends up in the error handling path.    Filing a tracking issue (no stalebot) and landing this SGTM.

I summarized our discussion in https://github.com/envoyproxy/envoy/issues/6449. Please let me know if you have any feedback


Functionality request: Colomn headers template?

Like row templates, add possibility of defining column headers in html like adding font awesome icons

This is actually tricky since unlike rows, columns have the added ability to sort via click. If like row, I allow templates for columns, the component itself will no longer be able to register to click events and perform sorts.
I can however, look into allowing for html instead of strings as label.

Using the thClass property html strings can be used as label (I did that with a font-awesome icon).
like
Preventing a column from being sorted for example by sortable:false would open the gate for other click event handlers. Of course when other columns are being sorted the non-sortable class would be sorted as well because of the rows structure of the table.

@xaksis
It would be great to allow insert html instead of string as label in order (for example) to translate the headers.

@xaksis Maybe put the slot inside v-for?

     		 <slot name="columns" :column="column">
     				 {{column}}
     	 	</slot>

Like this you can keep the icons and the click events like they are but rather customize the text/html for the header.
The usage would be
<template slot="columns" scope="props">

           {{props.column}}

          {{props.column}}

   </template>

Sample fiddle https://jsfiddle.net/bt5dhqtf/1212/

good idea @cristijora I'll look into this.

This is now available in v1.14.x Here's an example:
https://xaksis.github.io/vue-good-demos/#/dynamic-table
closing this.

Hello, can you please add the example for this somewhere? Page is throwing a 404

hey @gergo2007 This is an old issue that references deprecated docs. Current documentation covers all of this.
https://xaksis.github.io/vue-good-table/guide/advanced/#custom-column-headers

@xaksis thanks for the reply, im still using the old (1.21) version. Does the new doc cover the old version as well?
Thanks!


Revamp loading configuration

Configuration loading implementation is based on the proposal in #230.
Over time it evolved a bit and we should re-evaluate how it is being loaded.
It is not obvious how many times, when exactly it is loaded or how long it takes.
We should try to design a solution that will:

load the configuration only once (even across multiple workers)
work for both lazy and boot modes
be able to print precise timestamps when and how long it took, including debugging logs what the configuration was and the response codes

With https://github.com/openresty/lua-resty-shell it should be possible to start and asynchronously read from external processes (needed to make requests in init phase).
https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/errlog.md#raw_log allows for cleaner errors messages without extra bloat.
https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/process.md allows starting a privileged process. There will be exactly one. If it is killed, it will be restarted. It can run init_worker phase. This would be ideal for an infinite timer, that would periodically refresh configuration. It also allows getting master PID.
https://github.com/openresty/lua-resty-signal allows sending signals to processes. Theoretically signalling master process to do a full reload. That would gracefully exit all workers, load new configuration and start the new master process.
For lazy loading, the situation is a bit harder, but still, we could try to have an internal API over UNIX socket, that would allow sharing configuration between multiple workers. The only methods of sharing configuration between workers are shared memory ngx.dict or some internal API (that still uses shared memory).

I'll start with offering the option to loading services one by one when they're needed instead of all of them when using APICAST_CONFIGURATION_LOADER = lazy.


Unable to install Network Tech package in Sublime 3 or 4

Im trying to install the Network tech package but after installing it im not seeing it under the installed packages.

Running into same issue here also - any ideas?

I am sometimes seeing problem in ST4, but restarting it fixes it.
Can you confirm a restart works?

Restarted my system and this did seem to in fact fix it. Restarting Sublime Text by itself did not resolve.
Thanks!


Reverse integer/decimal

It's confusing that decimal: true is required for Number type to allow floats. This would be a big thing to change this for everyone using existing way, but we could have an opt in (or opt out, need to decide) so that we can transition to allowing floats by default and limiting to integers only when integer: true.

Cool!  Do you have any idea what you'd want the code for opting in to look like?

Not sure what the best solution is, but it is a bit odd that check says that decimals are valid numbers:
check( 14.2414, Number );

But Simple Schema needs an extra setting for it to accept decimal numbers.

I met same issue until I found this. It is indeed confusing.

Thanks for your patience. SimpleSchema 2.0.0-rc.1 is now released and includes changes that resolve this issue.
There are a number of breaking changes when updating to 2.0, so be sure to check out the change log. If you use aldeed:collection2, you will need to use 2.10.0 or higher of that package in order to use SimpleSchema 2.0. If you use autoform, it is not yet updated to work with SimpleSchema 2.0, but hopefully soon.
SimpleSchema is now an isomorphic NPM package, so you can check out the updated readme and file issues over at the other repo. The Meteor wrapper package will exist for now but eventually I will probably deprecate support for it.
This is still a beta/RC and I do expect people will find issues, so use with caution. Production use is not yet recommended. That said, there are more and better unit tests than ever before, and the codebase should be much easier for others to read through and debug quickly.


Update Travis Postgres version from 9.6 to 12.3

We are using 12.3 in production.

Unfortunately, it seems that this isn't possible to do in Travis with bionic Ubuntu except by delaying builds by a lot.
See:

https://travis-ci.community/t/test-against-postgres-12/6768/11
https://travis-ci.community/t/starting-postgres-12-takes-too-much-on-bionic/8689

Closing for now. Hopefully Travis will resolve issue 2 mentioned above.


ci: move snapshots and dependency submission to daily workflow

#190  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


I think the yapdfkit should add more abnormal judgment

I think the yapdfkit should add more abnormal judgment
bxqz.pdf
-(NSData*)getDecompressedData:(NSString*)filter
{
    if([filter isEqualToString:@"FlateDecode"])   //Here the interrupt
    {
        return deflateData(_rawData);
    }
    else if([filter isEqualToString:@"None"])
    {
        return _rawData;
    }
    else
    {
        return _rawData;
    }
    return nil;
}

Pull request?

I think, I can try to add some judgment, although I am a PDF beginner, but I do IOS development has been four or five years. Now yapdfkit can not be compatible with a variety of formats PDF file open, often in the open PDF to do after the inspection will cause APP crash.


Suggestion to add Oberon07 language

http://oberon07.com
Oberon (a successor of Pascal and Modula-2 and a predecessor of Go) currently can't be tried online anywhere on the internet. I think TIO would be the best candidate to support it. Several important books about compiler construction and operating systems development provide example source code in Oberon that could then be tried by its readers.
It would probably be easiest to integrate https://miasap.se/obnc/

https://tio.run/#oberon-07
Sorry for the delay. I've built the extended library as well. Please let me know if there's anything missing.

That's great, thanks a lot!
Is 'M' the only possible MODULE name?
If I name a MODULE as 'M' for example, I'm getting:
obnc-compile: M.obn:1: error: module name does not match filename: T
obnc: build process failed
/srv/wrappers/oberon-07: line 5: ./M: No such file or directory

Yes, the Oberon-07 wrapper sets the filename to M.obn, so the module has to be called M.
If that's going to be an issue, I could try to grep for the module name and decide the filename based on that.

It depends on how much it is used (I informed the Oberon community about tio.run). For now I suppose the fixed name 'M' is not an issue.
Thanks again, for adding it!


Bug in DDP, but not DP modes.

Pytorch 1.5
In [3]: pytorch_lightning.__version__
Out[3]: '0.7.5rc1'

In DP everything works.
In DDP fails with:
 File "/home/vladimir/anaconda3/envs/solaris/lib/python3.7/multiprocessing/popen_fork.py", line 20, in __init__
    self._launch(process_obj)
  File "/home/vladimir/anaconda3/envs/solaris/lib/python3.7/multiprocessing/popen_spawn_posix.py", line 47, in _launch
    reduction.dump(process_obj, fp)
  File "/home/vladimir/anaconda3/envs/solaris/lib/python3.7/multiprocessing/reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <class 'torch._C._VariableFunctions'>: it's not the same object as torch._C._VariableFunctions

can you post a colab? does 0.7.4 work ok?

https://pytorch-lightning.readthedocs.io/en/latest/multi_gpu.html#make-model-picklable

I am getting the same issue.

The model is picklable
It worked fine on 0.7.2
It breaks after the update to 0.7.4

My stacktrace:
Traceback (most recent call last):
  File "./train_stage3.py", line 254, in <module>
    trainer.fit(model)
  File "/net/people/plgquinor/venv/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 744, in fit
    mp.spawn(self.ddp_train, nprocs=self.num_processes, args=(model,))
  File "/net/people/plgquinor/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 200, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/net/people/plgquinor/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 149, in start_processes
    process.start()
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/process.py", line 105, in start
    self._popen = self._Popen(self)
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/popen_spawn_posix.py", line 47, in _launch
    reduction.dump(process_obj, fp)
  File "/net/software/local/python/3.6.5/lib/python3.6/multiprocessing/reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <class 'torch._C._VariableFunctions'>: it's not the same object as torch._C._VariableFunctions

The model is picklable - the error appears when I try to pickle the Trainer instance.

@quinor @ternaus thanks for bringing this up! turned out to be a bigger deal haha.
Released 0.7.5 to fix - please skip 0.7.4


New-MySQLiteDB

When creating a database file it doesn't release the file until you close the terminal, is this expected behaviour?
I was toying around and used the command and then tried to delete the database file, it cannot delete until the terminal that spawned it is closed.

It might. MySql can be finicky. Do you have steps I can reproduce?

I use Windows Terminal with Powershell Core 7

Create a DB with New-MySQLiteDB "C:\Users\Admin\Desktop\Something.db" -Comment "Testing database".
Whilst the terminal is still open try and delete the newly created DB file (in windows explorer).

You should get an error about the file being locked/in use.
If I close the Terminal the file can then be deleted (doesn't matter if I use the Terminal directly or via VSCode)

I can duplicate this behavior. I verified the database is being closed after it is created. I see the same behavior in Windows PowerShell.  I'm not sure this is something I can fix. I am in the process of working on a new release with updated SQLIte binaries. Maybe there's something in a newer version that fixes this. Otherwise, I will need to document this.

While you can't delete the file immediately in Explorer, if you wait a few minutes you should be able to. It looks like PowerShell maintains a lock until the next .NET garbage collection. This isn't a bug, it is how .NET works.  It happens automatically every few minutes.

Ahh, at least there is an explanation. So this is why closing the terminal releases the file lock? Does that trigger a GC run?

I don't know if technically closing the terminal triggers garbage collection but it does sever the lock.

Hmm. The only thing I was concerned about is other scripts etc not being able to do things with the file while the lock was present.
As that doesn't seem to be an issue we can call this one resolved.

The assumption is that you are using the database from within your PowerShell session. If you are automating something else, you could always inject [system.gc]::Collect() into your code.

I'll add a comment to the documentation.

This is normal SQLite behaviour. In the documentation it says that it is not supposed to work with more than 1 proces action on the file. (There is no server involved, so the OS should be able to facilitate multiple processes contecting to 1 file)
I know that Notepad++ does something different. It always save a copy of the original file (even if you did not save a file the content will be there when you restart Notepad++. You can even delete an original file and Notepad++ will detect it and ask what to do!)


Protocol for Deprecation of Circuit Elements

There have been a few mistakes while creating some Circuit Elements. There have been some slight and some minor deviations in circuit behaviour.
For example the splitter acts both like a splitter and a combiner. It seemed a good idea at the time, but we have had many complexities due to this. A separate Splitter and a Separate combiner seems the best way now.
Some the mistakes are not correctable now as people are already using them and making changes will break their circuits.
We need to find a way to either

Migrate elements from old->new
Just deprecate old ones and create new ones. Old circuits will continue to use old elements but new ones will use new elements.

And other ideas?
We need to come up with a protocol for this after discussion and then execute it carefully.

@gr455 @shubhankarsharma00 @abstrekt @mahmodHammad @drjyeh Any inputs here?

I had an idea we can have all modules have a version number AndGate-v1, NotGate-v1, RAM-v2 and save that while saving the project if it doesn't have a version number while loading we load element's version 1 else we load from new module's version.
Version clearance for old versions can be done in here:
https://github.com/CircuitVerse/CircuitVerse/blob/7b3ecb4e6141c681cebf0c1533176fc2bb7e2ce9/public/src/data/load.js#L22
We'll have to manage the sidebar to load all the elements of the latest version I guess, but apart from that, this seems pretty doable.

@shubhankarsharma00 yes I was thinking on similar lines. But I think we need to discuss more on the details. Yes the sidebar can be configured to include only elements which don't have .deprecated as true. And we can configure formalType as 'AndGate-v2and Human Type asAnd Gate`.
And about older types, we can use rectifyObject to upgrade some objects when possible. And in some cases not to upgrade and use old element itself. Basically, the ElementClass will be present but hidden and can be used by older circuits.
We should also account for maintainability, things are going to get much harder from here on, once we start doing this.

We can also potentially think about parsing circuits in backend and update for existing circuits, but it can be tricky.
We also have to think about circuitverse engine versioning with this feature


Support changing instance type on managed node groups

Is your request related to a problem? Please describe.
It's currently not possible to change the instance_types on managed node groups after creation. This makes it harder than it has to be to change/upgrade the instance types used in an EKS cluster.
Describe the solution you'd like.
The solution proposed by the AWS EKS team is to utilise the launch template support to set the instance types https://github.com/aws/containers-roadmap/issues/746#issuecomment-675099508. This should allow the managed node group to perform a normal rolling update, replacing all the nodes in a controlled fashion.
I have also opened a PR before summer that was closed during vacation: https://github.com/terraform-aws-modules/terraform-aws-eks/pull/2677
Describe alternatives you've considered.
A workaround is to create a new managed node group with a new instance types setting, then later remove the old managed node group.
Another workaround is to simply use self managed nodes, but this requires some extra effort to get the rolling updates working smoothly.

I don't quite follow - this module uses  a custom launch template by default. could you provide a reproduction that demonstrates the issue you are encountering?

It provides a launch template, but no means of setting the instance_type parameter on the launch template, and changing the instance type on the managed node group itself it not allowed.
This means that a change of the instance_types list triggers a replacement of the entire node group
  # module.eks.module.eks_managed_node_group["main"].aws_eks_node_group.this[0] must be replaced
+/- resource "aws_eks_node_group" "this" {
      ~ arn                    = "arn:aws:eks:eu-west-1:012345678910:nodegroup/aws-test-4f18d3/main/3ac53231-a26e-18c1-3d8f-593c8876357d" -> (known after apply)
      ~ capacity_type          = "ON_DEMAND" -> (known after apply)
      ~ disk_size              = 0 -> (known after apply)
      ~ id                     = "aws-test-4f18d3:main" -> (known after apply)
      ~ instance_types         = [ # forces replacement
          - "m6a.large",
          + "m7a.large",
        ]
[...]

... which will fail anyway due to a naming conflict (which is probably best because I don't think that operation is nesescarily safe).
module.eks.module.eks_managed_node_group["main"].aws_eks_node_group.this[0]: Creating...
╷
│ Error: creating EKS Node Group (aws-test-4f18d3:main): ResourceInUseException: NodeGroup already exists with name main and cluster name aws-test-4f18d3
│ {
│   RespMetadata: {
│     StatusCode: 409,
│     RequestID: "520ed65b-8e3e-4840-a15d-e832cba45e5d"
│   },
│   ClusterName: "aws-test-4f18d3",
│   Message_: "NodeGroup already exists with name main and cluster name aws-test-4f18d3",
│   NodegroupName: "main"
│ }
│
│   with module.eks.module.eks_managed_node_group["main"].aws_eks_node_group.this[0],
│   on .terraform/modules/eks/modules/eks-managed-node-group/main.tf line 308, in resource "aws_eks_node_group" "this":
│  308: resource "aws_eks_node_group" "this" {
│
╵
Releasing state lock. This may take a few moments...

Allowing an option to set the instance type on the launch template instead should allow changing the instance type with a managed rolling replacement of the nodes.

correct - the instance types in this module are set through the managed nodegroup and not on the launch template. there are no plans to change this


startup crash

crash-2022-09-10_15.53.20-client.txt
From nowhere this started happening and only when a new mod is installed (it can be anything from clientside a library or some big mod), and the log always points to numismatic

According to this crash report, the error is caused by Charm. I don't know if this is a general problem of Charm on 1.19.2 or if it's something in your modpack, but removing it should fix the issue. Numismatic is only caught in the crossfire as this is mixin issue that causes the entire classloading pipeline to collapse, which ultimately makes Numismatic incorrectly seem like the culprit
Cheers

The culprit in the end was enchantwithmob
thanks log


Automatically install / download database with conda installation

From users feedback, installing the package through conda and then placing the database in it results very clunky.
Options to fix it:

Make it automatic during the conda installation
Make sure it's easy for a user to define the path to their database (or explain it better in the documentation

Related  to #42

Unfortunately, this seem to be not possible at the moment, or would result in a more dangerous installation.
On the other hand, we implemented the command line option pandora-fetch and the equivalent python function PANDORA.Database.install_database to automatically download the database from zenodo, without any need for slow database generation.


Add automated testing, uploading and a coverity badge

On all pushes:
Test and verify the resulting package.
On published releases:
Upload to a server (currently not set)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: RedTurtleDonkey:x: useruser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Support for non-string keys

I specifically ran into this issue when calling to_dict on a Box instance with an integer key. A TypeError is raised on this line:
https://github.com/cdgriffith/Box/blob/37ad92655da7dc31d3cd55ffab304ea2a0d68a72/box.py#L524
TypeError: attribute name must be string, not 'int'
I saw the issue when using Python 3.5.2.
The following works for an integer key:
self[key] = value
so the change may be as simple as adding TypeError to line 525:
https://github.com/cdgriffith/Box/blob/37ad92655da7dc31d3cd55ffab304ea2a0d68a72/box.py#L525
This was not an issue in 2.0 and most likely later versions, although it may not have been intentionally supported:
https://github.com/cdgriffith/Box/blob/8340399c659b274d9bdec452684f4ace0d844164/box.py#L71
As a result I would argue this is a bug not a feature request.

I will have to think about this more / get more feedback, but right now it sounds like it's acting like Python expects. (That you can have integers, really anything hashable, as keys of the dict. But attributes have to be strictly strings)
>>> class A:
...     pass
...
>>> a = A()
>>> b = dict()
>>> b[1] = 1
>>> setattr(a, 1, 1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: attribute name must be string, not 'int'

Python will raise unavoidable syntax errors if someones tries to access or set an integer via dot notation, so that can't be circumvented (i.e. a.1 = 1 would raise SyntaxError). So someone would have to be using getattr, setattr or manually calling the magic functions to see this error, which is already past the point of this module trying to be handy by allowing access dot attribute access to non-string keys.

Sorry the actual issue is in update, not to_dict. I have to cut off the top of the stack trace but it starts with a call to update on a Box instance:
  File "/usr/lib/python3.5/site-packages/box.py", line 598, in update
    self[k].update(v)
  File "/usr/lib/python3.5/site-packages/box.py", line 598, in update
    self[k].update(v)
  File "/usr/lib/python3.5/site-packages/box.py", line 602, in update
    self.__setattr__(k, v)
  File "/usr/lib/python3.5/site-packages/box.py", line 524, in __setattr__
    object.__getattribute__(self, key)
TypeError: attribute name must be string, not 'int'

Oh ho, got ya now.
Issue is right where you listed at https://github.com/cdgriffith/Box/blob/master/box.py#L602 where I am calling __setattr__ on everything in update. I need to either check that it's a string or raise a type error.

Well a TypeError is already raised eventually in setattr. I'm not sure that it's an improvement to move it to update since the exception message already seems fairly clear.
It's up to you if you think it doesn't make sense for this package to support non-string keys but that seems to conflict with the stated mission of 'an easy drop in transparently replacements for dictionaries'.

errp, mispoke, meant to say catch the raised type error there (aka so during update if a key is non string, trying to make it an attribute is ignored and no error occurs) . It needs to support non string keys, just not non-string attributes. Good catch!


Check if thread-local variable is defined to pass the x-request-id

We have a pattern in some Rails apps of using a thread-local variable to capture the X-Request-Id HTTP header from a Rack middleware. We should check to see if this value is defined in the current thread, and pass it along to SapiNT if so.

done


NativeFileDialog should emit a signal when the dialog is closed without selecting anything

There is an unhandled scenario where the user might not select anything when a NativeFileDialog pops up, and instead dismiss it entirely; there is no signal to handle this situation, such that we might respond to it.
For example, it might be relevant to know if the user has opted to save a file when prompted to do so, and in case they dismiss the popup, we might warn them about possible loss of unsaved data.

That's a good point, I would add a cancelled signal to NativeFileDialog.


Dat-cli connecting between my laptop and vps doesn't work anymore

Since I use a firewall on my vps and don't have dat's default port opened, dat needs to use utp to connect. This doesn't seem to work for me anymore.
Node 4.5.0
Dat 11.2.0
Mac OS X 10.11.6 on my laptop and Centos 7 on my VPS
If you need more feedback, I'm TheLink in #dat on freenode.

Just tested with firewalld disabled on my vps and it works fine.


Sticky headers

closes camunda/camunda-modeler-design#118
:warning: Please notice this does not yet include the Scroll to focus on new added list item => I will tackle this seperately as a follow-up.
Try this out yourself with:
npx @bpmn-io/sr "bpmn-io/bpmn-js-properties-panel" -l "bpmn-io/properties-panel#sticky-headers"

I like that it also works via keyboard ❤ Although it looks a bit shaky (on my Windows machine).
https://user-images.githubusercontent.com/9433996/169143889-a2fdb680-c01f-41cb-983c-197b32da1da7.mp4

Does position: sticky not work for this problem? What is the reason we re-implement it with the Intersection Observer?
I'd suggest to think about this in the context of the progressive enhancement philosophy. In short words: We make sure that the tool works for as many users as possible, but also make use of new features if they are supported by the browser. This is contrary to:

We ship tool only for the newest browsers and don't care if it breaks in a slightly outdated browser.
We ship tool with exactly the same experience even if it requires us to not use new features at all or to ship significantly more code.

Applied to the subject of sticky headers, I think we should try to make use of position: sticky and ship the old solution for browsers which don't support it. This could look like snippet below:
.group {
  position: relative; /* old browsers */
  position: sticky;
}

Let me know what you think.

Also, notice that new IntersectionObserver will throw an error in IE11 unless it's polyfilled while unrecognized CSS degrades gracefully.

BTW we already use position: sticky in the decision table:

Correct me if I'm wrong, but we already make use of position: sticky, right? The observer only deals with changing the "mode to provide more style changes when it reaches the sticky state.

ship the old solution for browsers which don't support it.

👍 Make sure we do not blow up

Oh OK. I didn't notice because I was too focused on the intersection observer 😅

In that case, most of what I wrote is irrelevant. Sorry for possible confusion.
I found a flickering problem which is triggered due to the negative margin:
https://user-images.githubusercontent.com/28307541/169269270-9af123c5-2f38-4986-a2e2-7b754c8dbd87.mov

If visually acceptable (cc @andreasgeier ), we could fix it with this:
https://github.com/bpmn-io/properties-panel/pull/151/commits/010ef1b0f5afca03a9674db8c9af77f064e9ce2f
Now we should not have the flickering

Maybe one more thing regarding the IntersectionObserver. I'd suggest to make it optional, so that the properties panel does not blow up because of this minor feature if it's opened in an old browser.

Maybe one more thing regarding the IntersectionObserver. I'd suggest to make it optional, so that the properties panel does not blow up because of this minor feature if it's opened in an old browser.

Added via https://github.com/bpmn-io/properties-panel/pull/151/commits/3b8165cd0ecde1dd0f6b70a1a65d807e6e51bdb4
✅  from me with this change

Maybe one more thing regarding the IntersectionObserver. I'd suggest to make it optional, so that the properties panel does not blow up because of this minor feature if it's opened in an old browser.

Added via 3b8165c
white_check_mark from me with this change

Great addition, thanks


Add cache while loading vectors in inmemory

Description
fix https://github.com/SuperDuperDB/superduperdb/issues/1887

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make unit-testing and make integration-testing successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Codecov Report
Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.54%. Comparing base (34830a7) to head (825e1ba).
 Consider uploading reports for the commit d7ccea0 to get more accurate results

Files
Patch %
Lines

superduperdb/vector_search/in_memory.py
81.81%
2 Missing :warning:

superduperdb/vector_search/interface.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1894       +/-   ##
===========================================
- Coverage   80.33%   66.54%   -13.80%
===========================================
  Files          95      128       +33
  Lines        6602     9357     +2755
===========================================
+ Hits         5304     6227      +923
- Misses       1298     3130     +1832

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


activation boxes

to represent that processes are being performed in response to the message (ExecutionSpecifications in UML)

Thanks for your input. It is a good idea!
Right now I am quite busy in another project so I will not have much time for this in the near future though. I will however support anyone trying to implement this.

here is my idea as for implementing this. I'd appreciate any suggestions.
https://github.com/ciekawy/mermaid/pull/1

It looks good. You have understood the structure and put everything in the right place.
As for the remaining rendering work remember to keep track of the bounds and the vertical position so that things don't start to appear above one another. Another pointer is to make use of the tests for the calculations in the work, much better then writing the tests after when everything works :)
Good luck, looking for to the pull request.

Actually this is already working version
https://github.com/ciekawy/mermaid/pull/1
It includes also activation stacking - additional sub-activations for shorter periods. Waiting for comments ;)
I would like to add one more thing - a text arrow shortcuts for (de)activations. I.e using +/- character suffix for text arrorws like in https://www.websequencediagrams.com/

Trąbka for the support! If there is no other issues https://github.com/knsv/mermaid/pull/318 should be enough for this task.

Rhis is now part of realease 6.0.0. Thx!


UIState bit 4 is wrongly labeled

 Bit 1 = IsMapOpen,
 Bit 2 = IsCompassTopRight,
 Bit 3 = DoesCompassHaveRotationEnabled
 Bit 4 = Game has focus
 Bit 5 = Is in Competitive game mode

According to a dev on the community dev discord those are the bits currently in the game.

https://github.com/GW2Toolbelt/GW2ML/commit/42cb07bbd0b6ddd92782975cdd8b32ca59233d60