Add v1.4.0 perf and scale benchmarks data

What this PR does
After this PR: This PR adds the perf and scale benchmarks data for release v1.4.0

Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Add release v1.4.0 perf and scale benchmarks data

/cc

/cc @alaypatel07

adding reviewers from sig-scale, removing others to stop the spamming
/cc @rthallisey
/uncc @acardace @jean-edouard @vasiliy-ul @lyarwood

/ok-to-test

/lgtm
/retest-required

/cherry-pick release-1.4

/retest-requires

/retest-required

/approve


Code Quality: test utils cleanup

Replace the use of GetRunningVirtualMachineInstanceDomainXML with the shorter and simpler to use GetRunningVMIDomainSpec wherever replacement is trivial. Some other tests perform a string analysis on the raw XML, those are not handled within the scope of this commit.

What this PR does
Before this PR:
Test code was needlessly longer and more cumbersome that it could have been
After this PR:
Some test code is a bit more concise, and in some cases imports fewer packages

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
More instances can be removed with not too much of an effort
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/test all


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1665

Questions ?
Please refer to the Backport tool documentation


Web UI fullscreen icon button

Hello,
Is there a way to show fullscreen icon button in Web based UI?

Hi, no you should create your own custom UI.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-extensions/knobots/actions/update-deps

/test eventing-upgrade-tests
/test integration-tests

/lgtm
/approve


hide inline PDF review in work panel?

Loading a PDF file is a little bit costly. Maybe hide it on load and let use choose to load it, since there teams rarely need to review their own submission.

I think we should provide the inline PDF after they upload it to help them avoid possible mistakes. A separate page maybe useless for that sake.

just hide it on load. It terribly drags load time.

在 2016年2月14日，上午12:51，Jueast<EMAIL_ADDRESS>写道：
I think we should provide the inline PDF after they upload it to help them avoid possible mistakes. A separate page maybe useless for that sake.
—
Reply to this email directly or view it on GitHub https://github.com/B-O-P/innovator/issues/17#issuecomment-183701872.


fix(core): prevent body scroll by keydown outside dialog

I think this is kind of a bigger issue that we need to fix more generally. Like when you added overflow: hidden to body, but it got broken in iframe. We need something like that. Ideally overscroll-behavior should fix that, but it's a longstanding bug and even native dialog tag does not address that. Let's not introduce this, as it fixes only part of the issue and only for our concrete dialog implementation.


Access tokens in the cache are not used because all requests have openid and profile scopes

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Framework
No framework.
Description

Application code calls loginRedirect with a scope <client-id>/user.access
User logs in to AAD
AAD redirects to the app with an authorisation code
The authorisation code is exchanged for an id token, an access token, and a refresh token, which are stored in cache (1st network call to the token endpoint)
Application code calls acquireTokenSilent with the same scope that was provided in loginRedirect
Access token from cache is not used, and instead the stored refresh token is used to get a new access token (2nd network call to the token endpoint)

I believe I found what that is the case.
When calling acquireTokenSilent, the request passed as a parameter sees its scopes "augmented" with the openid and profile scopes through the initialiseBaseRequest method, which itself calls setDefaultScopes.
The SilentFlowClient then tries to get a matching access token from the cache using the "augmented" list of scopes, which results in a cache miss, see readAccessTokenFromCache.
As a result, the logic falls back to using the RefreshTokenClient to get a new access token, see acquireToken.
Error Message
None
Security

[ ] Is this issue security related?

Regression

[ ] Did this behavior work before?
Version:

MSAL Configuration
{
  auth: {
    clientId: '<aad-client-id>',
    authority: 'https://login.microsoftonline.com/<aad-tenant-id>',
  },
  cache: {
    cacheLocation: 'localStorage'
  }
}

Reproduction steps
N/A
Expected behavior
Access tokens stored in the cache that match the requested scope(s) and that haven't expired should be used.
Browsers/Environment

[ ] Chrome
[ ] Firefox
[X] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

@mderriey Thanks for bringing this to our attention. We will look into this and follow up if we need more information.


Figure 12 has inconsistent labels

The labels on Figure 12 say OA-G6, but it's listed in the text as OA-G3. This should be reconciled!

I'm positive the plotted data refers to OA-G6 so the error is in the text. Thanks for catching this.

So the text will need to be clarified a bit more, since it talks about G3 in two different hosts, which is apparently not the case - one is G3 and one is G6.

Fixed


missing schema when updating depth

Thanks for this PR. Would you have time to write a test for this?

added schema test.
Because https://github.com/sequelize/sequelize/pull/4939 , so will get a failed testing for now.

Thanks @devmark.
Also, I think the two lines:
sql = utils.replaceTableNames(sql, {through: hierarchy.through}, sequelize);
sql = utils.replaceTableNames(sql, {item: model}, sequelize);

could be combined into:
sql = utils.replaceTableNames(sql, {
    through: hierarchy.through,
    item: model
}, sequelize);

Hey @overlookmotel, I've also encountered the issues presented in this PR. It looks like there hasn't been any progress made on this for a while now, and since the issue mentioned in sequelize/sequelize#4939 has since been fixed, the tests may pass now. I can open up a new PR if necessary to get this merged in.

I just re-ran the tests on Travis with Sequelize v3.22.0. Tests still failing on Postgres. I haven't had time to look and see why.
I'm afraid I'm really tied up at the moment and am unlikely to be able to look at this in more detail for a week or two at the earliest.

But if anyone can get to the bottom of the failing test, that would certainly help...

will take a look soon

Finally got around to fixing this. It's in v0.6.0.
The problem was actually really simple - bug in Sequelize v2 with .destroy( { truncate: true } ) not working with schemas.


Set label dtype = map(string) for community/modules

Fix type inconsistency
name:  labels

type:  any
decalred:
 nfs-server
 cloud-storage-bucket
 DDN-EXAScaler
 pbspro-execution
 schedmd-slurm-gcp-v5-node-group
 SchedMD-slurm-on-gcp-partition
 chrome-remote-desktop
 slurm-cloudsql-federation
 SchedMD-slurm-on-gcp-controller
 SchedMD-slurm-on-gcp-login-node
 pbspro-server
 pbspro-client

type:  map(string)
decalred:
 startup-script
 filestore
 vm-instance
 batch-login-node
 batch-job-template
 htcondor-execute-point
 schedmd-slurm-gcp-v5-controller
 schedmd-slurm-gcp-v5-login
 htcondor-configure
 new-project

Submission Checklist

[ ] Have you installed and run this change against pre-commit? (pre-commit install)
[ ] Are all tests passing? (make tests)
[ ] Have you written unit tests to cover this change?
[ ] Is unit test coverage still above 80%?
[ ] Have you updated all applicable documentation?
[ ] Have you followed the guidelines in our Contributing document?

@mr0re1 the build failed for real. You (and I) missed a few README updates. Run
pre-commit run -a terraform-readme

Then commit, squash, and force-push. It shouldn't invalidate the positive review. Merge once the PR validation succeeds.


Bitpack internal IDs

I was going to benchmark this, as it adds an extra step to the decompression, but I'm not sure it's actually being used. Are internalIDs actually stored anywhere other than in rels?

I was going to benchmark this, as it adds an extra step to the decompression, but I'm not sure it's actually being used. Are internalIDs actually stored anywhere other than in rels?

You're right. Currently it's not materialized in node tables.

@benjaminwinger , can we hold this PR a bit longer after the rel node group one #2246 ?

Yes, I was thinking it would make sense to wait until that's merged so it can be tested.

I think this can be closed now. @benjaminwinger

Yes, let's close in favour of #2579


Blocking dialog

Adds a 'blocking dialog' for Swing migration.
Type of change

[ ] Bugfix
[ X] Feature

Checklist

[ ] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[ ] I have added a description following the guideline.
[ ] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[ ] New and existing tests are passing locally with my change.
[ ] I have performed self-review and corrected misspellings.

Did none of the above.
On top of that, I'd like to request a code review, as I have an itch things could be simplified somewhere.
Additional for Feature type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Thanks to a fruitful conversation with @Legioth , this recipe collapsed into code that is too simple to show anything useful.
Taking back my request to merge.

The simple approach that you ended up with might still be useful as a recipe if it helps others avoid the the same rabbit hole where you've been.


OrderedComplexEigenDecomposition user defined sorting

The fields eigenvalues and eigenvectors in ComplexEigenDecomposition didn't get sorted in OrderedComplexEigenDecomposition.
Only D and V get sorted.
How can I define my own sorting and get these fields also refreshed?
https://github.com/Hipparchus-Math/hipparchus/blob/c816b0e811ba18f52b3f00b46bccd3f0a14784ff/hipparchus-core/src/main/java/org/hipparchus/linear/OrderedComplexEigenDecomposition.java#L59

Is is a bug.
I have fixed it in master branch, could you check if it works for you now?

Can you also introduce a constructor for FieldMatrix<Complex> matrix parameter?

Not easily.
We don't have eigen decomposition implemented in the general case, only in the real case (which however does provide
results as complex numbers when the real matrix has complex eigenvalues).
Could you open a new issue labeled as "Feature" to ask for implementing this feature?

Done #174


datacapture expresso tests flakey

Describe the bug
https://github.com/google/android-fhir/runs/6130147669?check_suite_focus=true
Component
SDC lib
To Reproduce
Steps to reproduce the behavior:

Run QuestionnaireItemDropDownViewHolderFactoryEspressoTest.kt locally in Android Studio

Expected behavior
Passes every time
Actual results
shouldSetDropDownValueToAutoCompleteTextView  fails frequently (but not all the time)
Screenshots
https://user-images.githubusercontent.com/28757340/165289316-d96de6a8-7eb1-4917-906f-3d604f5a7cb3.mp4
Smartphone (please complete the following information):

Device: PIxel 6
Build number: SP2A.220505.002
Android version: 12
API Level: 32

Additional context
NA
Would you like to work on the issue?
NA

this is effectively blocking all PRs going in. I've observed this locally where the test case shouldSetDropDownValueToAutoCompleteTextView doesn't pass... the expected value is Coding 3 but sometimes it's just empty...

I have run QuestionnaireItemDropDownViewHolderFactoryEspressoTest on below device 15 - 20 times on each device, but could not reproduce this issue, device configuration as below

Nokia 3.2 Device, API level - 30
Nexus 5X Emulator, API level - 24
Pixel 4 Emulator, API level - 24
Pixel XL Emulator, API level - 27

@PallaviGanorkar yesterday 13:48 BST: But now I am able to reproduce this issue on Pixel 5 with API 32 emulator


Support Chicken Scheme apropos =>2.3.0

Hi,
I'm new to geiser and chicken scheme. While setting thing up recently I ran into an issue where Chicken Scheme's apropos egg changed the identifiers in the return value of the apropos-information-list from module#name to (module . name). This commit adds support for the new identifiers.
Thanks,
John

thanks.  one question, though: is this going to break geiser for chicken users with versions < 2.3.0?  if so, is this an issue for the community? @dleslie any comments?

I wouldn't bother supporting older versions of apropos; users that absolutely insist on using an older version can also use an older version of Geiser.

Also, not having to split the symbol names should speed it up somewhat.

Yes this commit will unfortunately break geiser for users with version < 2.3.0.
That said I could update the code to support both formats. I'm not sure how what the community's approach to breaking changes is. Thoughts?

okay, i've merged it... we can worry about backwards compatibility if
needed.  thanks!


Update remove-an-alias-from-a-group.md

https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/224
Changed command

I hope that's what you meant for me to do. This was my first approval.

@adefowler - yes, thanks for your assistance.


fix: Batch delete bug

This PR is related to issue #939 where errors were thrown when a batch response was parsed and the response contained an empty body.

*it was failing because of a typo, already fixed it 👍


change the FloatingActionsMenu icon

Hello,
can i change the FloatingActionsMenu icon to custom icon?
Thanks,
Idan Ayalon

Check this issue out: https://github.com/futuresimple/android-floating-action-button/issues/56

Duplicate of #56.

@chalup add option to change fab menu icon, ecen it is not great for now, just plus icon is not enough


Bad polygon data.

Check out the geometries at /api/collection?collection=buildings_polygons.  Geojson lint is complaining that the last point needs to be the same as the first.  Is this a problem with the data source or the conversion to geojson?
It also looks like there are multipolygons tagged as type Polygon.
Geometry at http://wfs.jivanamara.net:9000/api/feature?id=buildings_polygons-1 also doesn't have same point at start & finish.  When this is remedied, there is a complaint that the polygon's point order doesn't follow the right-hand rule.

The last point closing the polygon has been addressed with an update to tegola/geom/encoding/geojson.  MultiPolygons tagged as Polygon should still be looked at.


Flowrouter interfering with server routes (e.g. pointing to uploaded files)

Hi
I am serving my uploaded files from the /upload folder as such /upload/folder/file.
The problem is that Flowrouter keeps interfering and does not allow me to click on the link pointing to the image stored at that location and is showing me the notExists route. My current workaround is that I set target="_blank" in the anchor, which displays the image in the new window.
Is there any way to disable flow router for a specific path?
Thanks

Check this: https://github.com/kadirahq/flow-router/issues/235#issuecomment-131990201


cargo xtask install command is not working

Bug report
Describe the bug
cargo xtask install command is not working properly
To Reproduce
follow readme to install with cargo
➜  postgres_lsp git:(main) cargo xtask install
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/xtask install`
$ cargo install --path crates/postgres_lsp --locked --force
error: `/Users/tmogus/Desktop/code/postgres_lsp/crates/postgres_lsp` is not a directory. --path must point to a directory containing a Cargo.toml file.
Error: install server

Caused by:
    command exited with non-zero code `cargo install --path crates/postgres_lsp --locked --force`: 101

Expected behavior
successful installation
System information
macOS 14.5 23F79 arm64
Additional context
crates/postgres_lsp doesn't exists,
cargo install --path crates/pg_lsp --locked --force worked well

hey! Thanks for opening the issue. It's because of a recent refactor where the lsp crate now has a different name.
I am currently working on a few improvements to the core logic to make it ready for an alpha release. Will look into xtask and the release process once that's done 🙏🏼

Hi! I'm interested in contributing to this LSP, so looking forward to the alpha release :). For the time being, I was able to unblock myself here by following these steps:

Inside xtask/src/install.rs:142, replace postgres_lsp with pg_lsp
Have an available instance of postgres on port 5432 with credentials postgres:postgres when running cargo xtask install. The easiest way to do this is by spinning up a docker container via docker compose up.


[UI] Regroup Applications, Filters, and Patterns/Designs together in its designated folders

Current Behavior

Currently, in the ui/components folders, we have a couple of files such as Filters.js and MesheryPatterns.js that can be moved to its relevant folder such as MesheryFilters and MesheryPatterns.
Desired Behavior

This can help clean up and make certain files relevant and easier to find if you're having an issue with a certain page.
Implementation

Since we're using naming conventions such as MesheryPatterns or MesheryApplications, Filters can also get an update, and be moved to the designated folder.
Acceptance Tests

Mockups

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hey can I work in this issue

@acald-creator I would like to work on this issue.

I want to work on this issue can you assign this to me ?.


add CI and tune up git config

few things here:

github actions CI that runs tests and checks formatting on PRs and pushes
some additions to the .gitignore for some tree-sitter generated files that are not usually checked in
a .gitattributes that marks generated files as generated

this makes diffs to those files auto-collapse in PR/commit diffs
and it excludes them from linguist's language inference for the repo, so the repo will become "a javascript repo" according to linguist, rather than a C repo

I ran the formatter (I forgot in #3 :sweat_smile:)

what do you think?

Fantastic work! :100: Thank you! :tada:


weave-net crashes on startup: ipset v6.29: Set cannot be created: set with the same name already exists

m@hotcpc17686:~/git/kubernetes-deployments/andover-cit$ k logs -f weave-net-96lwr -c weave
ipset v6.29: Set cannot be created: set with the same name already exists

weave-kube: 1.9.5

Adding -x to tha launch script:
/home/weave # ./launch.sh
+ IPALLOC_RANGE=<IP_ADDRESS>/17
+ HTTP_ADDR=<IP_ADDRESS>:6784
+ STATUS_ADDR=<IP_ADDRESS>:6782
+ HOST_ROOT=/host
+ CONN_LIMIT=30
+ /usr/bin/weaveutil netcheck <IP_ADDRESS>/17 weave
+ EXPECT_NPC=1
+ [ 1 != 0 ]
+ modprobe_safe br_netfilter
+ modprobe br_netfilter
+ modprobe_safe xt_set
+ modprobe xt_set
+ xt_set_exists
+ ipset create weave-kube-test hash:ip
ipset v6.29: Set cannot be created: set with the same name already exists

weave-npc is also crashing:
m@hotcpc17686:~/git/kubernetes-deployments/andover-cit$ k logs -f weave-net-96lwr -c weave-npc
INFO: 2017/05/08 10:13:07.324502 Starting Weaveworks NPC 1.9.5
INFO: 2017/05/08 10:13:07.324706 Serving /metrics on :6781
Mon May  8 10:13:07 2017 <5> ulogd.c:843 building new pluginstance stack: 'log1:NFLOG,base1:BASE,pcap1:PCAP'
DEBU: 2017/05/08 10:13:07.364984 Got list of ipsets: [weave-kube-test weave-hqn|YlgxBD0G/~F{lO}7q{BbU weave-94D4P%N1ac^8#m}i;KwFqXYQu weave-AzQOn97ATK:5c_rzq9W<gE/jW weave-s;.yxJ$8c(0h_@HPQRlLqrTfe weave->QTe{>Q]Dw$3zd_M;IJ<P#Hyi weave-@jjBYuK>hPcKa)xM}FSKj:GM8 weave-/u4uvvQXNvlx/oR&nrrY#(|E_]
DEBU: 2017/05/08 10:13:07.365019 Destroying ipsets 'weave-kube-test'
ERRO: 2017/05/08 10:13:07.373624 Failed to destroy ipset 'weave-kube-test'
FATA: 2017/05/08 10:13:07.373782 ipset [destroy weave-kube-test] failed: ipset v6.29: Set cannot be destroyed: it is in use by a kernel component
: exit status 1

Looks the same as #2915

Interesting. similar symptoms. This one appears to be due to iptables chains referencing the test set, not nested sets.
It looks like this particular node managed to get halfway through xt_set_exists and died for some reason (possibly our chaos monkey), and since then it can't start properly
Preparing a patch now for this specific case. (as it would affect deployments without weave-npc too)

Ah, ok, not the same as #2915.


Allow curators to add a block of text to item show pages

This is to support the Welcome Additions exhibit.

Currently persistence is now functioning on my branch:

However, I am uncertain as to how this should be enabled/disabled for a given custom field.  I can look to offer the following:

Would this be disorienting to users?  If not, I can look to implement this as well.

it might also be good to ask users about the field label; see whether "curation note" conveys that it will be the added display text

I think having display of the Curation Note be enabled/disabled in the existing metadata display configuration would be great.
I'll ask Eric if "Curation Note" is a good label for the field — they are also preparing physical labels for the exhibited items, and they may have terminology for this field already.


docs(GitHub README): Add hyperlinks in README

Changes
Add (missing?) hyperlinks in README for easy access
Signed-off-by: Bharat123rox<EMAIL_ADDRESS>

Coverage remained the same at 95.235% when pulling 4871bf87d9a785eca58b7760966a70741ae6d6a3 on Bharat123rox:patch-1 into 659ee300eb8a7c333847dfb3064a442f813ac322 on accordproject:master.


mempool: export errors

Partially addresses: https://github.com/cometbft/cometbft/issues/1140
Exports errors in mempool.

hey @pysel @thanethomson  , thanks for review and all comments addressed.

@Mergifyio backport v0.38.x


How to conditionally add jvm flags for entrypoint?

Hello,
This might be more of a discussion. I want to enable jmx metrics if I set env var JMX_PORT during docker run. So I m using your image as base and installing confluent connector jars and then doing docker run. I m new to jib wondering if I can set jvm flags conditionally somehow. At present I added jvm flag directly to your pom.xml and built base image but trying to see If I can make this optional somehow . Or else this has to be specified using maven profiles and I have to build two base images one with jmx and other without jmx? One option I was thinking is adding entrypoint in my child docker image where I m installing confluent connector jars but wondering if this can be done somehow in pom.xml. Thanks for everything you do

The Kafka shell scripts that wire that variable into the java jar command are not available, so adding that specific env-var will not do anything.
At runtime, you can add JAVA_TOOL_OPTIONS to mimic what the native Kafka start script would add
JAVA_TOOL_OPTIONS=' -Dcom.sun.management.jmxremote.port=<port> -Dcom.sun.management.jmxremote.rmi.port=<port>'

thanks that worked

so you recommend adding jmx_prometheus_javaagent-0.20.0.jar to same image where we are downloading confluent jars looking to to see if we can include this jar optionally somehow in your base image


Add Memo-Flota's file

I'm learning and they said me to do this

I have a little idea about how it works, however, there are many things I can't understand


Relative to absolute links in markdown output

Hi Kenneth,
I was just referred to this lib and I must say it's just as awesome as everything for Humans :+1:
Since we already have the capability to transform relative links to absolute ones according to the readme, would it be possible to swap out all of the relative links in the generated markdown of an element to absolute ones aswell (this would be a sensible default)?
Cheers

removed markdown output, for now.


Adding a custom accelerator co-processor and a memory

Hi,
I am trying to add a deep learning accelerator in EarlGrey. It will need another memory (DDR or RAM) to store the weights and activations. How would the accelerator connect to the memory? Should I make the accelerator a TL-UL bus host? Or should I add a DMA to transmit the data?
I have read the relevant documents, but it is not crytstal clear to me how to add my own IP and modify the interconnect. I would appreciate if any of you could provide some guidance on the integration.
Here are my proposed steps to integrate:

Create a .hjson configuration files for the accelerator. It will list my required features according to the comportability spec
Add the accelerator and the memory to the top_earlgrey.hjson and top_earlgrey.core
use topgen.py to generate the top_earlgrey.sv

Thank you!

I guess my question was too general, but over the last few days, I have been setting up a new test IP, just to familiarize myself with the flow of adding an IP.
In the process, I have found the OTBN IP to be a very similar implementation I could follow. However, I am wondering what were you design considerations to implement it as a memory-mapped co-processor, instead of extending the RISC-V ISA and add a co-processor interface in the Ibex pipeline? Latency, modularity, memory access, etc.?

I guess my question was too general, but over the last few days, I have been setting up a new test IP, just to familiarize myself with the flow of adding an IP.
In the process, I have found the OTBN IP to be a very similar implementation I could follow. However, I am wondering what were you design considerations to implement it as a memory-mapped co-processor, instead of extending the RISC-V ISA and add a co-processor interface in the Ibex pipeline? Latency, modularity, memory access, etc.?

@rswarbrick
@GregAC
@imphil

@rswarbrick
@GregAC
@imphil


Setting the pg to 13.3 in omnibus and default attribute

Signed-off-by: Vinay Satish<EMAIL_ADDRESS>Description
There is a conflict with the different postgres upgrade scenarios, so setting all postgres version to 13.3
Issues Resolved
Should pass all the different postgres upgrade scenarios.
Check List

[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/main/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

13.3 -> 13.4 pg should not trigger an upgrade: https://www.postgresql.org/docs/13/pgupgrade.html https://www.postgresql.org/support/versioning/ which it does right now. Reverting to 13.3 for this release. This issue will be fixed in 14.10 of server release.


Attach toolbar to bottom of viewport on mobile

The mobile toolbar should actually be visible whenever simpla-text is focussed, not just when a range is selected. But didn't even know where to start with that one...

Yeah that's probably something for me to do w/ prosemirror.
This looks pretty nasty on my phone:

HTML Source to replicate:
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <script src="/components/webcomponentsjs/webcomponents-lite.min.js"></script>
    <script src="/components/simpla/simpla.js"></script>
    <script>
      Simpla.init('local');
    </script>
    <link rel="import" href="/components/simpla-text/simpla-text.html">
    <meta name="viewport" content="initial-scale=1, maximum-scale=1">
    <title></title>
    <style media="screen">
      body {
        padding: 50px;
      }
    </style>
  </head>
  <body>
    <simpla-text id="main" path="/text-0" editable>Hello World</simpla-text>
  </body>
</html>

That's iOS Safari, can debug in regular Safari by just changing it to send an iPhone User Agent, gives the same result.

Okay, must not be bailing on abspos logic properly. Could you skim through this PR and see where it might be going wrong? If mobile is true the toolbar shouldn't be positioned at all with JS.

Ah yeah so it looks like hoverOverRange might get called before the toolbar is actually attached to the DOM. Probably worth only having it hover over the range after attached, buuut for now do you just want to change this PR to compute the mobile value as a global constant? e.g. something like this
let detect = new MobileDetect(window.navigator.userAgent);
const IS_MOBILE = !!(detect.mobile() || detect.tablet());

class SimplaTextToolbar {
  hoverOverRange(range) {
    let rangeBounds,
         ownBounds,
         boundaries,
         left,
         top;

    this.hidden = !range;

    if (!range || IS_MOBILE) {
      return;
    }

    ...
  }
}

Would chucking it in created work? Just kinda messy, because you'd still have to set it to a prop for the reflected attribute.

Oh well I'd just set value when you set on properties:
properties: {
  mobile: {
    type: Boolean,
    value: IS_MOBILE,
    reflectToAttribute: true
  }
}

I meant, the fact that they're on a mobile isn't going to change between instances or over time

No, it's just got a bad code smell
mobile: {
  value:  IS_MOBILE

Oh yeah sure use a prop. All I'm saying, is that the value of whether it's mobile or not (either in a prop or a constant) needs to be set as early as possible

Oh okay gotcha. I'm hazy on Polymer lifecycle, so setting value of the prop will definitely happen before hoverOverRange could ever be called?

Yeah - the beforeRegister kinda happens before the constructor (it's confusing thanks to ES6 classes being used in Polymer 1.x). But essentially that's the earliest things can happen. In v1 API you'd just do it in the constructor.

Travis is erroring in a pretty spectacular fashion all of a sudden - any idea why?

Lordy. Yeah I'll have a squiz and patch it up. Once they're fixed you're happy for me to merge?

👍

@seaneking see last commit heh 😉 we need to add linting to our tests me thinks


We found a nested input to crash the crate at run-time

The function inner_new in src/buffer.rs:59:5: 59:71  is a recursive function.
We can construct a nested input to make this function recursive deeply and crash the program at run-time.
For example, we create a nested TokenStream using quote!:
let token_stream: TokenStream = quote!((((((((((((((((((((((((((((((((((((((((((((((((((((... 1 ...)))))))))))))))))))))))))))))))))))))))))))))))))))).into();
let token_buffer: TokeBuffer = TokenBuffer::new(token_stream);
This TokenStream is a nested input which contains a lot of Delimiters. It is a nested Group which make inner_new recursive deeply and raises stack overflow error.

Closing as a duplicate of #901.

I am banning you from this repo because this is the second duplicate of #901 that you have opened.


Get campaignId properly from events API call.

@WCRest this fixes that issue you mentioned in my other PR.

LG


Port timestamp patch to 1.2.0

This is almost the same as the patch for master, but the timestamping has changed between these versions (and both are wrong).
Patch for master: https://github.com/PepperlFuchs/pf_lidar_ros_driver/pull/125

(tested on robot)


feat(clerk-js,ui,types): Hide sign up url from <SignIn /> component when Invite-Only is turned on

Description
Hide sign up url from <SignIn /> component when the Invite-Only mode is turned on.
In a following pr we're going to introduce e2e tests

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

I'm closing this for now as discussed offline


Script and document Windows support (rebased on v2.0)

This PR adds basic Windows support.
See the README.md changes and the commit history for a summary of the changes.  Basically, I used flutter create . --platforms=windows, added a build_windows.dart Dockerfile-based script, and a build_wsl.dart to be ran on a Windows host in a WSL2 instance, and I documented their use.

[ ] Implement requested changes.

[x] Move dependencies from script to docs.
[x] Move DLL to build/secp256k1.dll IAW lib/src/secp256k1/secp256k1_io.dart.
[x] processSync->execWithStdio.
[x] Remove unnecessary autogenerated files.
[x] Use temporary directory in order to avoid polluting project directory.
[ ] Integrate build process into the flutter build process (see discussion).

[x] Update PR text, referring to previous PR.
[x] Mark PR ready for review.

I marked the PR ready for review while working on the CMake integration on Windows.  It's ready on a basic level as-is but could use improvements as discussed on the previous PR.  I'm not sure that full Flutter CMake integration will be feasible for me on Windows, but will come back with an update on this point in awhile.

The coinlib example app was running yesterday and the day before, but it isn't for me currently, so unfortunately I must retract this PR :( I may need to enlist another Windows user for independent testing

I resolved the issue with the coinlib example on Windows, so I'm re-marking this PR as ready to review, sorry for the switcheroo.
Note that I had to alter coinlib_flutter/example/pubspec.yaml like
diff --git a/coinlib_flutter/example/pubspec.yaml b/coinlib_flutter/example/pubspec.yaml
index c06782d..2a7fccc 100644
--- a/coinlib_flutter/example/pubspec.yaml
+++ b/coinlib_flutter/example/pubspec.yaml
@@ -10,7 +10,12 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  coinlib_flutter: ^1.0.0
+  coinlib_flutter:
+    git:
+      url: https://github.com/cypherstack/coinlib.git
+      path: coinlib_flutter
+      ref: windows # TODO change to main.  TODO update to windows-2.0 branch.
+      # TODO pin to specific commit to reduce supply chain attack surface.
   cupertino_icons: ^1.0.2

 dev_dependencies:

however this shouldn't be an issue if/after the changes are published to pub.dev

Is there any hope to get the Windows CMake build working?

Yes, I don't feel that I exhausted every approach towards that end.  It could very well be viable.  I will try to try again before the New Year, but have been reassigned elsewhere for the time being

Yes, I don't feel that I exhausted every approach towards that end. It could very well be viable. I will try to try again before the New Year, but have been reassigned elsewhere for the time being

OK, no worries. I might be unavailable until the latter part of next week, but I will take another look at anything when I can.

If someone is using the package from pub.dev, the library wont be in the
CMAKE_BINARY_DIR though right?

Hmm, I'm not sure about that, actually!  I tested it using both path and
git refs locally (uncommitted).  First I made sure the coinlib_flutter
example works, then I made sure the whole setup works when included in
another flutter project.  When I dart run coinlib:build_wsl, it spits the
secp256k1.dll into <flutter_project>/build/windows and coinlib finds it
there as well, so I think CMAKE_BINARY_DIR is valid here.
But it would probably be a good idea to put out a windows testing version
as you mentioned before before adding it to a "mainstream" release.
On Sat, Dec 30, 2023 at 10:14 AM Matthew Mitchell @.***>
wrote:

@.**** commented on this pull request.
In coinlib_flutter/windows/CMakeLists.txt
https://github.com/peercoin/coinlib/pull/24#discussion_r1438643682:

List of absolute paths to libraries that should be bundled with the plugin.
This list could contain prebuilt libraries, or libraries created by an
external build triggered from this build file.
set(coinlib_flutter_bundled_libraries
Defined in ../src/CMakeLists.txt.
This can be changed to accommodate different builds.

$<TARGET_FILE:coinlib_flutter>
${CMAKE_BINARY_DIR}/../build/secp256k1.dll

$<TARGET_FILE:coinlib_flutter>

TODO re-enable the above line if/when the CMake process is made Windows-compatible.  See also above.

${CMAKE_BINARY_DIR}/../secp256k1.dll

If someone is using the package from pub.dev, the library wont be in the
CMAKE_BINARY_DIR though right? The library needs to be picked up from the
consumer's local build.
—
Reply to this email directly, view it on GitHub
https://github.com/peercoin/coinlib/pull/24#discussion_r1438643682, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7K5WOWE6JA6HN636J2X73YMA4WFAVCNFSM6AAAAABA3WB4TOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJZGU3DSNRWGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'll have to test this again, I thought this change was consistent with the
.dll placement in build/windows.
On Sat, Dec 30, 2023 at 10:15 AM Matthew Mitchell @.***>
wrote:

@.**** commented on this pull request.
In coinlib/lib/src/secp256k1/secp256k1_io.dart
https://github.com/peercoin/coinlib/pull/24#discussion_r1438644019:

@@ -19,8 +19,8 @@ String _libraryPath() {
localLib = "lib$_name.dylib";
flutterLib = "$_name.framework/$_name";
} else if (Platform.isWindows) {

// Not provided yet, so should fail to load unless added outside of library
flutterLib = localLib = "$_name.dll";

// Built in build\windows.
flutterLib = localLib = "windows/$_name.dll";

OK, can't the localLib be without the windows folder though?
—
Reply to this email directly, view it on GitHub
https://github.com/peercoin/coinlib/pull/24#discussion_r1438644019, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7K5WJGOI4W4AZWG3I3EWTYMA43JAVCNFSM6AAAAABA3WB4TOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJZGU3DSNZUG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm working on a native Windows build now.  This might be counting my chickens before they hatch, but I wonder about the build scripts names...  Right now:

build_windows.dart cross-compiles for Windows from a Linux host using docker/podman
build_wsl.dart cross-compiles for Windows from a WSL instance on a Windows host

Do you have any preference how these should be named it I can accomplish a native Windows build?  I'd assume build_windows.dart would be for running on Windows, personally.  I don't know how I'd rename the cross compilation script(s), do you have any preferences there, assuming I do manage to achieve a native Windows build?

I have native Windows builds working, but not integrated into coinlib_flutter/src/CMakeLists.txt yet.

OK, I have not been able to get the entire build working automagically on Windows by altering coinlib_flutter/src/CMakeLists.txt, but I have native Windows builds working and documented.  This is in a good place!  It could be better by just using CMake and not coinlib/coinlib/bin/build_windows.dart et al., but I wasn't able to accomplish that yet.  Perhaps that's a good topic for some future issues?  I have a feeling that Linux could be made automagic...

Reverted/resolved by 50c49e173feb12068a3cb8007e1c87dd522a16ba, example app
version is 1.0.0
On Fri, Jan 5, 2024 at 11:15 AM Matthew Mitchell @.***>
wrote:

@.**** commented on this pull request.
In coinlib_flutter/example/pubspec.yaml
https://github.com/peercoin/coinlib/pull/24#discussion_r1443137920:

@@ -2,15 +2,15 @@ name: coinlib_flutter_example
description: Demonstrates how to use the coinlib_flutter plugin.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

-version: 1.0.0
+version: 2.1.0
I'd say keep it as 1.0.0 though it's not very important.
—
Reply to this email directly, view it on GitHub
https://github.com/peercoin/coinlib/pull/24#discussion_r1443137920, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7K5WJOVEK7GTL5GLGCF73YNAYKBAVCNFSM6AAAAABA3WB4TOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBWGQZTCMBZHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

@sneurlax I merged a squashed commit to a new windows branch in preparation for a test pre-release. I'll likely get to that on Sunday ready for testing next week. Many thanks.


Consider previously-failed autojoins as unmappable sources

Depends on #3198
Fixes #3199
Previously, on MinimizeAutoJoins…
We would fail to eliminate an AutoJoin, leaving it in the graph and moving on to the downstream vertices.  Any subsequent AutoJoins which were freemappable from the first AutoJoin would then end up considering the original roots as part of their candidates.  But since those roots had already failed to merge, they certainly wouldn't merge on the second try, meaning that all subsequent AutoJoins within a freemappable region would fail to eliminate, resulting in a cascading "join explosion" (particularly with Guard, which results in multiple ThetaJoins at graduation).
This PR solves the issue by considering prior failures as maximal roots, despite the fact that we could freemap above them.  Since we handle the rewrites top-down, there shouldn't be any missed opportunities between the failed AutoJoin and its sources, so I believe this is probably optimal in lieu of join reassociation (which is another issue).

@edmundnoble Build green; ready for merge.

Makes sense to me.


[ALLUXIO-2609] Deprecate Throwables.propagate with RuntimeException in RetryHandlingBlockWorkerClient.java

https://alluxio.atlassian.net/browse/ALLUXIO-2609

Can one of the admins verify this patch?

ok to test

add to whitelist

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13833/
Test PASSed.

alluxio-bot, check this please

@pilyfer Thanks for improving the code base health!


changed requirements.txt and readme

There were two missing requirements that I had to install manually in the conda environment, easydict and ftfy. These were added to the requirements.txt.
The readme has been updated to add clarification on the location of the cache folder and how the files should appear in the structure.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feature-branch

I forgot to tell you you can use this greate template for the Readme file
https://github.com/microverseinc/readme-template


Identity columns should have autoincrement property returned by getTables

fixes #77

I'm not totally confident I understand the whole picture, though. Especially the difference between quick and full tables fetch and why they do not need to return the same structure...

Well, they got split for performance reasons, and I'm not yet sure if they should be the same or not since the consumers are different.  The consumer for the quick getTables is the UI for the component, and the consumer for the full result is the storage metadata.
The UI for the component does need this property, but the storage metadata probably does not.
Regardless, maybe we'll get rid of this difference and just use the simple one in the future, depending on the outcome of https://github.com/keboola/db-extractor-common/issues/98

The main problem is that this whole behavior is based on whether the $table parameter is empty and it then returns two (potentially wastly) different things.
Anyway this PR LGTM.


Mark proc-macro crates

Resolves #8107

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+
Seems reasonable to me, thanks!

:pushpin: Commit d17311df6c407eb494f8d1b8dd2610ff1816b67b has been approved by alexcrichton

:hourglass: Testing commit d17311df6c407eb494f8d1b8dd2610ff1816b67b with merge ab69d6a99e5e54fb240c9f9f2fe6ae3897f6fe50...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing ab69d6a99e5e54fb240c9f9f2fe6ae3897f6fe50 to master...


MAP_ANONYMOUS is missing on Mac

On my Mac, I get this:
error[E0425]: cannot find value `MAP_ANONYMOUS` in module `libc`
  --> src/us/mod.rs:34:38
   |
34 |             libc::MAP_SHARED | libc::MAP_ANONYMOUS,
   |                                      ^^^^^^^^^^^^^ not found in `libc`

Now here's what's a little odd... a Google search reveals lots of people (using C) talking about MAP_ANONYMOUS being absent on Macs, which I guess is why it's not in libc. But it's definitely present on my system. This C program compiles:
#include<stdio.h>
#include<sys/mman.h>
int main() {
  printf("%d", MAP_ANONYMOUS);
}

Interesting! If it compiles maybe it was added recently? In any case if it exists then it should be good to add! Our CI will catch it if it's not defined

It looks as though the constant is called MAP_ANON on OSX, although the mmap.h header also defines MAP_ANONYMOUS as an alias:
https://github.com/apple/darwin-xnu/blob/0a798f6738bc1db01281fc08ae024145e84df927/bsd/sys/mman.h#L127


Using cache in jwt authentication

This leverages Djangos cache to store:

The JWT decryption key
References to the users that have authenticated

It will default to reloading the JWT if a decryption fails or doing a user create if the user was cached but unable to be laoded from the DB.

@AlanCoding @relrod Since the AWX tests failed, should I notify someone?
I don't think this change should have affected the general AWX login but maybe it could have 🤷 ?


Fix doubled-up UseAuthorization (part 2)

Fixes #17803, again.
cc @Rick-Anderson
It looks like it's just the one snippet where the highlighting went wrong. If you'd rather I put UseAuthentication in, just say the word.

Looks good, thanks.


examples/addr2line: flush stdout after each response

Forcefully flush stdout after each address is handled. This allows to use
addr2line in a "coprocess" mode, in which another process forks/execs
addr2line, establishes two uni-directional pipes for passing input addresses
and reading back responses, and uses addr2line in a client/server fashion.
This is done for amortizing start up costs and make stack symbolization as
cheap as possible.
The problem with the above "coprocess" mode is that because addr2line is
getting Unix pipes for stdin/stdout, std::io::stdin()/std::io::stdout() will
switch to fully buffered mode, instead of line-buffered one that happens when
stdin/stdout is wired to interactive shell. Because of that buffering, driving
application will never get response (unless it's bigger than internal buffer,
which is quite big, though I don't know exactly how big), because it will
never be actually flushed into the pipe. This problem generically is solved
through a complicated dance with setting up pseudo-terminal, creating new
session, etc, etc. It's complicated enough to discourage such use completely.
But if we can modify addr2line to enforce flushing data after each response,
then all this problem goes away, because buffering doesn't matter much
anymore. It shouldn't hurt performance noticeably at all.
Signed-off-by: Andrii Nakryiko<EMAIL_ADDRESS>

Note that currently this code is intentionally placed in examples/ rather than src/bin/, and it is not a mature replacement for the addr2line from binutils or llvm.

Yeah, I realize that. But it seems to be working very well for kernel stack trace symbolization. I'm using it in my proof-of-concept tool at https://github.com/anakryiko/retsnoop, and it's surprisingly fast and reliable. So thanks a lot for adding that examples/addr2line part!


'dpi' parameter is invalid

Error in chrome when have two monitors of different size, or zoom in the browser (not always)
GET https://sampleserver1.arcgisonline.com/ArcGIS/rest/services/Specialty/ESRI_…6763653%2C6281406.695538039&BBOXSR=3857&IMAGESR=3857&DPI=80.99999785423279 404 ('dpi' parameter is invalid)
Should be fixed in line 211 of src/ol/source/imagearcgisrest.js

params['DPI'] = 90 * pixelRatio;

params['DPI'] = Math.round(90 * pixelRatio);

please provide a pull request

note: dpi value for geoserver is already rounded: https://github.com/openlayers/openlayers/blob/v3.20.1/src/ol/source/imagewms.js#L282 (but not for mapserver)


add copy-to-clipboard option to all service details

[ ] create a common component which implements copy to clipboard in xpanse-ui. We can consider using - https://github.com/nkbt/react-copy-to-clipboard
[ ] The copy to clip board icon must be displayed at the following places

on each element in the service details list on the service successfully deployed alert in the MyServices -> Details page.
On the 'service id' field in the order successful and order failed screens.
On registration successful alert -> the service UUID must have this.

I'll take this


An ! mark in the request name breaks adding rules to queries

To reproduce:
Go to browse, demographics, ethnicity Aria
Copy to new request.
Name the request test!1
Go to my requests
Go to Request  test!1
Click Create Cohort Query
Click add rule.
Same issue persists with test!4 or test!a but not just a ! mark as the name

Error message

Unable to reproduce this, possible to got fixed accidently in a different pr?


Make the dncli.jar executable

Make it runnable like an ordinary shell file.

Can't remember why I wrote this as it was late and I was really tired. Closing.


Field Values Not Appearing on Actor Sheets

Willpower values don't show on character sheets, but they do seem to save to respective Actors
Skills and Levels don't save to respective Actors and don't appear on character sheets

Hitting enter makes all values disappear??


brand is one of filtering

keepa api filters brand/label/manufacturer/publisher/studio using "is one of", so the value for that filtering is a list, not a str. Seem like the code is casting that list into a string, thus returns no result usually. This is also true for all other text fields searching in keepa api, including but not limited to model, size, etc.

Could you please provide a code so I can debug it?  I'm unfamiliar with that section of the source.

looking at code 1873 of interface.py, it changes the following product_parms:
{'brand': ['disney', 'disney frozen']}
into:
{'brand': "['disney', 'disney frozen']"}
because of the following code:
for key in product_parms:
if key not in PRODUCT_REQUEST_KEYS:
raise RuntimeError(f'Invalid key "{key}"')
        # verify json type
        key_type = PRODUCT_REQUEST_KEYS[key]
        product_parms[key] = key_type(product_parms[key])

and the configuration line 302 in  file product_finder_keys.py:
'brand': str,
It should be:
'brand': list,
And similarly the following parameters should be of type list, instead of str:
type, manufacturer, brand, label, department, publisher, productGroup, studio, genre, model, color, size, edition, platform, format, author, binding, languages, mpn, partNumber

Thanks for spelling that out.  Code updated as of keepa==0.19.2.


Document how the information in --tls-sni-cert-key is used

This is a Feature Request

What would you like to be added
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ documents the syntax of the --tls-sni-cert-key command line flag, including the defaulting for the domain name matching part, but what I am missing is the semantics.  What are the consequences of supplying this flag?
I think the missing information is something along the following lines.

This flag is used to configure what certificate the apiserver puts in its ServerHello message in the TLS handshake and supply the corresponding private key.  This flag allows that choice of certificate to vary from handshake to handshake depending on the SNI (if any) in the handshake.
When a --tls-sni-cert-key value has domain names and/or domain name patterns this means to match handshakes in which the ClientHello message has an SNI that matches one of those domain names or domain name patterns.
When a --tls-sni-cert-key value has an IP address this means to match a handshake on a TCP connection opened by a SYN packet that was sent to that IP address.
When multiple --tls-sni-cert-key values match a given handshake, the one that gets used is ...

Why is this needed
This flag is not usable without an understanding of its semantics.
Comments

@kubernetes/sig-api-machinery-misc

I suspect the answer is found in the func BuildNamedCertificates in https://github.com/kubernetes/kubernetes/blob/98358b8ce11b0c1878ae7aa1482668cb7a0b0e23/staging/src/k8s.io/apiserver/pkg/server/dynamiccertificates/named_certificates.go

/assign

/assign


Add Token (Smart Contract) feature

PR Details

add SPoS related TX
add Smart Contract (Token) related TX

Description

Add the following transaction types support:
SPoS

[X] Contend Slot
[X] Release Slot

Smart Contract

[X] Register Contract
[X] Execute Contract

Related Issue

None, new features.
Motivation and Context

add support to Mainchain new feature
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@zl730 please help to double check the code

Please try to use "new" features of java 8 as much as possible.
Here's the tutorial

And it's actually very rear to see a long last java project without lombok.


Use go-bindata to embed static files into binary

Embed static files into binary when compiling. Solves https://github.com/avelino/vim-bootstrap/issues/276

@avelino I agree with you, generated code is ugly, but at the same time, now we have the possibility to pack vim-bootstrap to run as a alone binary.