Update plugin to use python-lsp-server instead of python-language-server

Hi,
Given that Palantir removed all the community maintenance for both python-language-server (pyls) and python-jsonrpc-server (pyls_jsonrpc), we decided to create a separate organization that now maintains a community-based fork for the aforementioned packages, which can be found at: https://github.com/python-lsp/python-lsp-server and https://github.com/python-lsp/python-lsp-jsonrpc.
Our recommendation is to migrate this plugin to be compatible with the community server instead of the Palantir one. In order to do so, here is a migration guide that should help:

The plugin should replace python-language-server by python-lsp-server on its requirements.
The pyls namespace is now pylsp, which means that all pyls imports should be replaced by pylsp.
The pyls_* hookspecs are now pylsp_* hookspecs.
The plugin can preserve the pyls_ prefix on its namespace in order to prevent further administration and release issues that may arise from renaming it.

Feel free to ask any question about the migration process or about the new community organization for the server.

@tomv564 I created a PR to fix this, if you could review, merge and release a python-lsp-server-compatible version of pyls-mypy that would be much appreciated.

@andfoy There is a maintained fork at https://github.com/Richardk2n/mypy-ls.
@asford Would you accept #52 to make the project work against https://github.com/python-lsp/python-lsp-server? I can open the PR against your repository.

@andfoy I have reviewed the mypy-ls fork and it looks like a minimalistic fork to improve plugin configuration support, but it hasn't had activity since October.
I think best course of action would be to create another fork at python-lsp/pylsp-mypy and release as a new pylsp-mypy package to PyPI. python-lsp-server can then point to this new repository and package as the maintained version of the plugin. If you add me as a maintainer I can handle the necessary changes.

@haplo I'm happy to contribute to that fork.
I would recommend starting from the https://github.com/Richardk2n/mypy-ls fork, as the configuration support is dramatically improved and bring the plugin inline with command-line mypy invocations.
My personal fork provides support for dmypy as well as mypy as well as some misc bugfixes for non-live-mode checking.
If you'd like to @ me in an issue to provide dmypy support in the fork I can open a PR there.

If you are willing to maintain the new fork, then I'll move it to the organization later today

@haplo I'm happy to contribute to that fork.
I would recommend starting from the https://github.com/Richardk2n/mypy-ls fork, as the configuration support is dramatically improved and bring the plugin inline with command-line mypy invocations.
My personal fork provides support for dmypy as well as mypy as well as some misc bugfixes for non-live-mode checking.
If you'd like to @ me in an issue to provide dmypy support in the fork I can open a PR there.

All that sounds good to me, I will bring @Richardk2n improvements for plugin configurability, and will be happy to see your improvements too. Let's get the fork released with python-lsp-server compatibility and then we will keep improving it. Hopefully the community will stop getting fragmented and everybody can contribute to a single upstream project.
BTW I just switched to non-live-mode myself and it's working much better, so I'm looking forward to your bugfixes in that regard. :)

If you are willing to maintain the new fork, then I'll move it to the organization later today

You can sign me up for it, I'm an active user of mypy and the LSP plugin.

@haplo I enabled issues. I did not intend for them to be disabled. I'll happily include any suggestions and would love to see this plugin getting some attention.

@haplo I enabled issues. I did not intend for them to be disabled. I'll happily include any suggestions and would love to see this plugin getting some attention.

Great to hear from you @Richardk2n.
I have no interest in creating yet another fork of the plugin if you are available as a maintainer. If you could merge https://github.com/Richardk2n/mypy-ls/pull/2 and release a new python-lsp-server-compatible version we can ask @andfoy to point to your fork as the recommended mypy plugin.
Please be aware that @andfoy mentioned that python-lsp-server might integrate a mypy plugin in the future, but until then we need to maintain the third-party plugin.

What is the current state of the mypy integration to python-lsp-server ?
Is the plan still to create a fork within the python-lsp organization ?

What is the current state of the mypy integration to python-lsp-server ?
Is the plan still to create a fork within the python-lsp organization ?

Currently my fork mypy-ls is working with python-lsp-server (as far as i know). And given, that I keep maintaining it there is no plan to fork it on the organization until they decide to integrate mypy support directly into python-lsp-server (as far as i know).

Great ! I just installed it thanks to pip install mypy-ls.
How is it configurable though ?
When I was using palantir's python-language-server, I was configuring the mypy plugin in this way: https://github.com/tomv564/pyls-mypy#configuration.
Now that I am using python-lsp-server, am I still able to configure it through the language server config ?
As editor, I am using neovim.

It should be configurable as before. However as I never really figured out where the config should be placed (I would be grateful If you could tell me, where and how python-language-server expects its configs) there is a possibility, that I might ignore those passed to the language server. You can try. If it doesn't work place a file with your config formatted as in here in your working directory or a parent of said directory.
I would be grateful for feedback about what works, and how people are using the plugin, as my testing does not cover all use cases.

Hello !
Sorry for having waited before answering.
Actually, this fork of the mypy plugin works fine for me with the following configuration section in the language client:
pylsp_mypy = {
                        enabled = true,
                        live_mode = false
                    },

Actually, this fork of the mypy plugin works fine for me with the following configuration section in the language client:

Does it work when you uninstall python-language-server and install only python-lsp-server? I would be surprised because the imports in the plugin code are different, I would expect either errors or the plugin not being registered at all.

It seems that I only have python-lsp-server available right now.
[I] ➜ pip show python-language-server
WARNING: Package(s) not found: python-language-server

~
[I] ➜ pip show python-lsp-server
Name: python-lsp-server
Version: 1.1.0.dev0
Summary: Python Language Server for the Language Server Protocol
Home-page: https://github.com/python-lsp/python-lsp-server
Author: Python Language Server Contributors
Author-email: None
License: UNKNOWN
Location: /home/gaetan/.local/lib/python3.9/site-packages
Requires: jedi, python-lsp-jsonrpc, pluggy, ujson, setuptools
Required-by: mypy-ls

And it works. However, I don't know teh exact way both mypy-ls and python-lsp-server interact.

@GaetanLepage OK, that is expected, mypy-ls (now renamed to pylsp-mypy) works with python-lsp-server. pyls-mypy on the other hand works with python-language-server, which as the original message in this issue points out, is not maintained anymore. I thought your original comment regarded pyls-mypy, hence my confusion.

Thank you for this useful clarification !


To exit from IDF monitor please use "Ctrl+]" not working (IDFGH-8784)

I looked for the problem and found this issue, but meantime it's closed. For me the hints there didn't work. I'm using a Logitech Craft Keyboard with german layout, prepared to use with Windows and Apple Mac. I found that on my keyboard you have to
type Strg (english Ctrl) and T (upper/lower case regardless) and release both keys. It's the beginning of an escape sequence.
Then press T or X (again upper/lower regardless). This works. I misunderstand several hints in, that you have to press Ctrl,T,X all together.
But that's the wrong way.

I've hit this before as well, during very fast boot loops.

Yes, that is right. For those who has trouble with CTRL+], there is the possibility to open the menu with CTRL+T and then hit either CTRL+x or just x.
But I personally recommend to switch to English keyboard in terminals where you are doing development.


IE9 error

When viewing a number of the website examples, the following error is thrown and the chart doesn't or partially renders -
SCRIPT438: Object doesn't support property or method 'querySelectorAll'  scripts.js, line 564 character 5

I had a quick looks this morning before heading off to the train, it looks like this error is being thrown in the line annotation example. The error is due to D3 invoking querySelectorAll on an object that is not a DOM element as expected:
https://github.com/mbostock/d3/blob/78e0a4bb81a6565bf61e3ef1b898ef8377478766/d3.js#L564
This might be due to the code we have in dataJoin that ensures the container is a d3.selection.
That's as far as I got this morning, I don't have access to IE now ;-)

I'll take a quick look

Confirmed https://github.com/mbostock/d3/issues/851


Custom sections in generated markdown files

Describe the bug
Vuese doesn't allow to add custom sections to the documentation. Only Props, Events, Slots are allowed.
Expected behavior
Add a way to add new sections for documentation.
In my use case, I need to document the CSS classes used in my component to allow end users to modify the styles as they see fit.

I'm wondering too if you could build a full documentation like the official vuese one https://vuese.org/cli/#babelparserplugins


content for speaking proposal page

form (list of fields)
rules (15 minutes, QA)
pricing ... no pricing
gallery
current agenda

check out example presentation


Intermittent build error with TypeScript v1.5 · TS2388: Function overload must not be static

I am able to reproduce an intermittent build error for multiple Visual Studio projects when using TypeScript v1.5. This was not happening previously with TypeScript v1.4.
> tsc -v
> message TS6029: Version 1.5.3

The scenario below only occurs during a clean build and only for approximately 1 in 3 builds. This was originally encountered during my CI builds, which invoke the TypeScript compiler via MSBuild. However, I'm also able to reproduce this behaviour when invoking tsc with default options via the command line. Again, I am only able to reproduce the behaviour for say 1 in 3 attempts.
The issue seems to be caused by one code file in particular. The rest of the errors appear to be symptoms of that original cause, although the order of the errors would suggest otherwise. All JavaScript output files appear to be properly generated on disk.
Below is just a sample of the symptomatic errors, because there are many of the form:
> Index.ts(31,18): error TS2339: Property 'load' does not exist on type 'typeof Ajax'.
> Notifications.ts(4,27): error TS2345: Argument of type 'string' is not assignable to parameter of type 'IAjaxSettings'.
...

Here, I believe, is the root cause:
> Ajax.ts(57,16): error TS2388: Function overload must not be static.

I do not understand why the previous error would only sometimes be raised by the compiler. The overloaded methods we have in Ajax.ts have been unchanged for approximately 2 years, since early versions of the TypeScript compiler.
Below is a simplified extract from Ajax.ts:
module App {
    export interface IAjaxSettings {
        url: string;
        data?: any;
    }

    export class Ajax {
        static load(url: string): JQueryXHR;
        static load(options: IAjaxSettings): JQueryXHR;
        static load(options: any) {
            if (typeof options === "string") {
                return Ajax.send("GET", { url: options });
            }

            return Ajax.send("GET", options);
        }

        // Remaining implementation removed
        // ...
    }
}

Sounds strange. I'm not sure how much we can do without a larger repro. The code snippet there doesn't have any errors in isolation (modulo defining JQueryHXR and Ajax.send).

one thing to look for is if any of the input files autogenerated from a previous build step.
it might be helpful to compare the msbuild log file for failed and succeeded attempts, and make sure that all invocations to tsc.exe are identical, just to rule out other tools in the chain.

@danquirk Unfortunately no, I cannot share the project. I did spend limited time on producing a minimal repro but couldn't reproduce the intermittent issue in the time available. I will try again.
@mhegazy I don't think this is relevant as I have been able to trigger the issue using tsc.exe directly.
To me though, what is most curious is why I am getting the following error at all:
> Ajax.ts(57,16): error TS2388: Function overload must not be static.

Are you able to shed any light on what conditions would / should trigger this compiler error?

I have been able to produce a reasonably minimal repro for this issue. I'd like to share the code privately if possible — what is the best way of doing this?
The repro consists of the smallest number of TypeScript files possible to still reliably produce compiler errors. It contains TypeScript files and a tsconfig.json file. There is also a PowerShell script that continuously cleans / builds until it encounters compilation errors (non-zero exit code from tsc.exe). On my machine and also a colleague's this usually happens within approximately 20 compilations — most compilation attempts are fine.
Some other information that might be relevant:
OS: Windows 8.1 64 bit
tsc.exe: Version 1.5.3

feel free to email me. mhegazy at microsoft

@mhegazy emailed — thanks

We have tracked this issue to Chakra (tschost.dll). I am working with the Chakra team to see how ans when we can fix this. i will update the issue once i have more information..
for now, node does not seem to show a similar issue. so you can replace references to tsc.exe with node tsc.js

We could not get the fix in time for 1.6. Hopefully i have an update with a time line soon.

TS 1.8 should have a new version of chakra that address the issue. sorry for the delay.


An uncertain conflict on folder creation

Hi, first of all, thank you for building this cool tool.
I am from Apache SkyWalking(https://github.com/apache/skywalking), which includes many maven modules, and we suffered slow building experience for a long time.
I tried this with mvnd package, it works super good. The build time is down to 1:18 min from nearly 5 mins.
But I am surprised when I run mvnd clean package, an error shows up.

This folder should exist, but clean causes re-creation, which ends in error.
To reproduce this, you could run
> git clone https://github.com/apache/skywalking.git
> git submodule init
> git submodule update
> mvnd clean package

./mvnw clean package would be able to pass and mvnd package too.

The apache-skywalking-apm runs the assembly goal and refers to files that are built by other modules.  Given mvnd uses a concurrent built, you need to ensure the apache-skywalking-apm has dependencies on those modules, else you'll hit this error, which is caused by the assembly mojo being run before or at the same time than the required modules.
Reopen if adding the required dependencies does not work.


Exit code 252 on remote ssh session with PSEXEC

We have a Jenkins server which connects to Windows 10 computers via SSH. We want to run some automation testing on these machines with robot framework. I am using PSEXEC with a session ID so that the execution can be visually seen and we can capture screenshots/video.
Example robot code we are running:
robot -d Output/now -T ^
-v NOW_DIR:now ^
--variablefile ../GameCommon/VariableFiles/FilePaths.py ^
-s Suites.TestSuites.RecordTest .

When we run this code locally on the remote machine, it passes.
When we run this code over the SSH session, it passes, but since it is on session 0, all the screenshots/vidoes are black.
When we put this code into a bat file on the remote machine, then call it remotely with PSEXEC over SSH, it runs and records fine.
When we run this code over the SSH session with PSEXEC, it throws back error code 252.
psexec -s -i %sessionId% robot -d Output/now -T ^
More? -v NOW_DIR:now ^
More? --variablefile ../GameCommon/VariableFiles/FilePaths.py ^
More? -s Suites.TestSuites.RecordTest .

PsExec v2.2 - Execute processes remotely
Copyright (C) 2001-2016 Mark Russinovich
Sysinternals - [www.sysinternals.com](http://www.sysinternals.com/)

robot exited on *** with error code 252.

I have tried this simpler code which only uses the suite parameter, but still get the same error:
psexec -s -i %sessionId% robot -s Suites.TestSuites.RecordTest .

PsExec v2.2 - Execute processes remotely
Copyright (C) 2001-2016 Mark Russinovich
Sysinternals - www.sysinternals.com

robot exited on *** with error code 252.

When I try the --help or --version command, it returns with code 251, Help or version information printed.
psexec -s -i %sessionId% robot --help

PsExec v2.2 - Execute processes remotely
Copyright (C) 2001-2016 Mark Russinovich
Sysinternals - www.sysinternals.com

robot exited on *** with error code 251.

It would be easier if I could run the code directly with PSEXEC and NOT have to put into a bat file on the remote machine.
Ideas of what might be going wrong?  Suggestions of other things to try?
Let me know if you need other details to help me solve this.
robot --version
Robot Framework 5.0.1 (Python 3.7.9 on win32)

@pekkaklarck , what I originally posted is the only error message I am seeing.  Hence why I am asking for help.
Could there be a bug in Robot Framework for not reporting back more information on what is causing the issue?
I'll try generating more output

I have no idea why the error message isn't shown anywhere. It could be due to a bug in Robot, but I consider a problem with psexec integration/configuratoin more likely. Anyway, this is something you need to debug. Notice that these errors are written by Robot to stderr.

No updates. Closing.


Comparison with reveal.js

Hi,
as someone just looking for a suitable presentation tool, I am wondering what is the difference between remark and reveal.js, and when or why one would choose one over the other.
Maybe it is not your job as a project maintainer to write an objective comparison.. but maybe you can point out design goals that distinguish it from other solutions.
For now I am choosing remark because it seems to be simpler. But I did not spend enough time looking at the alternatives, to know whether this assessment is justified.
Thanks a lot!

The two have a lot of similarities, but in terms of the content you're going to present I would say that reveal is perfect for creating elevator pitch style slideshows with large headings and eye catching effects, whereas remark is more generic and excellent for academic style slideshows where the content is more important than the way it is presented.
In terms of authoring slideshows, only reveal has an online editor, but if you're going to write the slideshow yourself, the key difference is that reveal uses HTML and allows you to use markdown on a per-slides basis, while remark uses markdown and allows you to use HTML if needed. So with reveal you have to create a pair of <section>/</section> tags per slide in which you write even more HTML formatted content, while with remark you simply write markdown and use a separator line containing three dashes (---) to create a new slide. IMHO the latter is a lot simpler and cleaner, unless you do all your work in the online editor of course. remark's fundamental focus on markdown is probably also it's most distinguishable feature.
Thanks for choosing remark :)

Ok, sounds reasonable!
I think i can confirm most of what you say about remark, having made the slideshow and given the presentation two weeks ago.
I cannot say much about reveal.js, because I have not really tried it yet. So I am taking your word for it :)

Having written a lot of my teaching material (for C++ trainings) with remark since some time, I'm still watching both, remark and reveal for future developments. Each has its strength and weakness, but just for fairness I need to correct one of the statements made above:
It is very well possible to write a reveal presentation in "one large flow" of Markdown syntax - or store your Markdown in a separate file, if you run from a (local) server - and simply separate "horizontal" and "vertical" pages with different markers, like e.g. === and --- (and you can set these markers freely to your liking; same for the start of an optional "Notes" section).

Just to add to the discussion, it's possible to write reveal using R markdown, and so entirely in markdown http://rmarkdown.rstudio.com/revealjs_presentation_format.html

Do you think this is worth a wiki page?
Obviously both work well and it's a tradeoff on simplicity/features.
I'm not sure some info from 2016 is still relevant so I'm closing this and we can work together a wiki page if someone is up for the task.

i know that the issue is closed but just another remark -> there is also reveal.md that can use plain markdown https://github.com/webpro/reveal-md. I have been using this in the past years but am now checking out remark.


CI: Fix maturin version to v1.2.3

Fixes #565
Strictly this is only necessary for the build_pyauditor_linux.yml workflow because we build the source distribution there. However, I think it's a good idea to keep the maturin versions in sync between the different workflows. I didn't modify any pip install maturin commands that are used in the test scripts, because this is still working.

Codecov Report

Merging #568 (2e1ddae) into main (dab6159) will decrease coverage by 0.32%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   63.99%   63.68%   -0.32%
==========================================
  Files          45       44       -1
  Lines        4497     4125     -372
  Branches       58        0      -58
==========================================
- Hits         2878     2627     -251
+ Misses       1619     1498     -121

Components
Coverage Δ

apel_plugin
∅ <ø> (∅)

auditor
82.11% <ø> (ø)

slurm_collector
66.41% <ø> (ø)

slurm_epilog_collector
0.00% <ø> (ø)

htcondor_collector
∅ <ø> (∅)

priority_plugin
37.92% <ø> (ø)

I've downloaded the pyauditor-wheels artifact from the latest workflow run and confirmed that installing pyauditor from the source distribution results in a working install


[BEAM-13652][Playground] Send examples' links to the frontend

Add the link to the PrecompiledObject

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @KhaninArtur @ilya-kozyrev

R: @pabloem

ah I understand now. Thanks for adding the documentation.
This seems to break the frontend tests?

I've merged because so far you're the mian contributors, so I leave it for you to fix it in a follow up PR.
@AydarZaynutdinov


Extend Container build to support multiple PHP version

This extends the Container build to support multiple versions of PHP in the FrankenPHP container images. This will make the build future proof on the one hand, so adding new versions of PHP will become a one-line change.
On the other hand, this will also make it possible to add a specifig PHP version tag to the container image.
Closes #112

Just found this after trying to migrate our PHP 8.1 dev environment to use FrankenPHP instead of nginx-- looks like a great project. Is FrankenPHP version locked to a minimum 8.2 or would it be possible to retain a 8.1 version?

@jamogriff, PHP 8.1 is lacking the necessary bits (mostly related to OS signaling if I understand things correctly) to allow frankenphp to work, so 8.2 will probably always be the minimum version.

@withinboredom Awesome to knowz thanks! I'll also set the dev stack I'm building to use minimum 8.2 also. Thanks for the kind comments 🤙

Fixed by #163. Thanks for having initialized that work @mariusbuescher!


Merge pull request #5 from Dee-Glit1015/conflict

Merge pull request #4 from Dee-Glit1015/main

Merge Conflict Branch


Layout menu not working

The pages under the layout menu are not working. Building the project on my machine happened too.

Yeah because i didn't add it yet. I will soon when i get some time :)


[hdf5-blosc] Add new port

https://github.com/Blosc/hdf5-blosc

Hi @zi-m
Thanks for this PR.
Could you please look int the regressions on osx pipeline?
Undefined symbols for architecture x86_64:
  "std::__1::__vector_base_common<true>::__throw_length_error() const", referenced from:
      std::__1::vector<snappy::SnappySinkAllocator::Datablock, std::__1::allocator<snappy::SnappySinkAllocator::Datablock> >::__vallocate(unsigned long) in libsnappyd.a(snappy.cc.o)
      std::__1::vector<snappy::SnappySinkAllocator::Datablock, std::__1::allocator<snappy::SnappySinkAllocator::Datablock> >::__recommend(unsigned long) const in libsnappyd.a(snappy.cc.o)
      std::__1::vector<char*, std::__1::allocator<char*> >::__recommend(unsigned long) const in libsnappyd.a(snappy.cc.o)
  "std::logic_error::logic_error(char const*)", referenced from:
      std::length_error::length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "std::length_error::~length_error()", referenced from:
      std::__1::__throw_length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::resize(unsigned long, char)", referenced from:
      std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::resize(unsigned long) in libsnappyd.a(snappy.cc.o)
  "std::terminate()", referenced from:
      ___clang_call_terminate in libsnappyd.a(snappy.cc.o)
  "typeinfo for std::length_error", referenced from:
      std::__1::__throw_length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "vtable for __cxxabiv1::__class_type_info", referenced from:
      typeinfo for snappy::Sink in libsnappyd.a(snappy-sinksource.cc.o)
      typeinfo for snappy::Source in libsnappyd.a(snappy-sinksource.cc.o)
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
  "vtable for __cxxabiv1::__si_class_type_info", referenced from:
      typeinfo for snappy::ByteArraySource in libsnappyd.a(snappy-sinksource.cc.o)
      typeinfo for snappy::UncheckedByteArraySink in libsnappyd.a(snappy-sinksource.cc.o)
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
  "vtable for std::length_error", referenced from:
      std::length_error::length_error(char const*) in libsnappyd.a(snappy.cc.o)
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
  "operator delete[](void*)", referenced from:
      snappy::SnappySinkAllocator::Deleter(void*, char const*, unsigned long) in libsnappyd.a(snappy.cc.o)
  "operator delete(void*)", referenced from:
      std::__1::_DeallocateCaller::__do_call(void*) in libsnappyd.a(snappy.cc.o)
      snappy::ByteArraySource::~ByteArraySource() in libsnappyd.a(snappy-sinksource.cc.o)
      snappy::UncheckedByteArraySink::~UncheckedByteArraySink() in libsnappyd.a(snappy-sinksource.cc.o)
  "operator new[](unsigned long)", referenced from:
      snappy::SnappySinkAllocator::Allocate(int) in libsnappyd.a(snappy.cc.o)
  "operator new(unsigned long)", referenced from:
      std::__1::__libcpp_allocate(unsigned long, unsigned long) in libsnappyd.a(snappy.cc.o)
  "___cxa_allocate_exception", referenced from:
      std::__1::__throw_length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "___cxa_begin_catch", referenced from:
      ___clang_call_terminate in libsnappyd.a(snappy.cc.o)
  "___cxa_free_exception", referenced from:
      std::__1::__throw_length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "___cxa_pure_virtual", referenced from:
      vtable for snappy::Sink in libsnappyd.a(snappy-sinksource.cc.o)
      vtable for snappy::Source in libsnappyd.a(snappy-sinksource.cc.o)
  "___cxa_throw", referenced from:
      std::__1::__throw_length_error(char const*) in libsnappyd.a(snappy.cc.o)
  "___gxx_personality_v0", referenced from:
      std::__1::allocator<char>::deallocate(char*, unsigned long) in libsnappyd.a(snappy.cc.o)
      snappy::GetUncompressedLength(snappy::Source*, unsigned int*) in libsnappyd.a(snappy.cc.o)
      snappy::Compress(snappy::Source*, snappy::Sink*) in libsnappyd.a(snappy.cc.o)
      snappy::RawUncompressToIOVec(char const*, unsigned long, iovec const*, unsigned long) in libsnappyd.a(snappy.cc.o)
      bool snappy::InternalUncompress<snappy::SnappyIOVecWriter>(snappy::Source*, snappy::SnappyIOVecWriter*) in libsnappyd.a(snappy.cc.o)
      snappy::RawUncompress(char const*, unsigned long, char*) in libsnappyd.a(snappy.cc.o)
      bool snappy::InternalUncompress<snappy::SnappyArrayWriter>(snappy::Source*, snappy::SnappyArrayWriter*) in libsnappyd.a(snappy.cc.o)
      ...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

@zi-m
Is work still being done for this PR?

Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us!


[Sema] Derived conformances fixes.

Derived conformances fixes for AdditiveArithmetic, VectorNumeric, and Differentiable.

Support derived conformances in extensions.

This requires using the conformance context instead of the nominal type
declaration everywhere: adding synthesized members to the conformance context
and consistently using contextual types from the conformance context.

Diagnose Differentiable derived conformance crashes due to SR-9595.
Clean up.

Unify code style.
Consistently use DC->mapTypeIntoContext(varDecl->getValueInterfaceType())
for getting VarDecl contextual types.

Add tests for all fixes.

Unblocks TF-6. (TF-6 isn't related to/blocked by derived conformances, but the testcase I wrote is.)

Lower-priority todos:

TF-98: Improve Differentiable derived conformances diagnostics.

canDeriveDifferentiable currently has strict checks. However, this leads to uninformative errors: users will always see type 'Foo' does not conform to protocol 'Differentiable'.
Other derived conformance code is intentionally lax in the canDeriveXX logic so that better diagnostics can be generated in the actual synthesis code.
(I feel this is kind of a deficiency in the derived conformances system, but the scope of addressing that is too big.)

Fix SR-9595: Differentiable protocol generic signature minimization bug.

This would enable Differentiable derived conformances to work seamlessly (when members have generic types).

@swift-ci Please test tensorflow

How about "synthesizing a conformance to 'Differentiable' requires an explicit generic constraint that requires %0 to conform to 'AdditiveArithmetic'"?

Thanks for the good feedback, especially your third point.
I updated the message to synthesizing a conformance to 'Differentiable' requires an explicit %0 : 'AdditiveArithmetic' conformance constraint in https://github.com/apple/swift/pull/22327/commits/9739b8cb7879bb80ee93e8999fc6e4ad1eeb488b.

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow linux

@swift-ci Please test tensorflow linux GPU

@swift-ci Please clean test tensorflow linux

@swift-ci Please test tensorflow linux

@swift-ci Please test tensorflow linux gpu

@swift-ci Please test tensorflow linux gpu


Exclude app/assets/**/* by default

This change is for the same reason as the following issue:

https://github.com/rubocop/rubocop-rails/issues/796

In a typical Rails application, this directory often contains a large number of non-ruby files, and I believe this optimization is reasonable for rubocop-rails to speed things up.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Thanks!


Upgrade to protobuf 3.6.1

An incompatible change in Bazel: https://github.com/bazelbuild/bazel/issues/6384 breaks Tensorflow on Windows: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/498#3e15d20b-30a5-4071-8c3f-ce7425ce5f35. The breakage comes from using protobuf 3.6.0.
Protobuf 3.6.1 is compatible with the change.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

Closing as PR is merged.


Readme updates for attaching history

Summary
Adding readme updates for attaching history to take future updates with ease

Yippee! Fantastic follow through on this Jared!
On Tue, May 16, 2023 at 8:47 AM Jared Hunter @.***>
wrote:

Merged #229
https://urldefense.com/v3/__https://github.com/twilio-professional-services/flex-project-template/pull/229__;!!NCc8flgU!a2L1gnbg7RH0IDwALJTsOCh8v9jOX-XhyzM_XKYVxNiNa4VtF39eYKO6VA_GS7w9pcXUvWJ2S6Q_neDY6ddz_fi-$
into main.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/twilio-professional-services/flex-project-template/pull/229*event-9259787985__;Iw!!NCc8flgU!a2L1gnbg7RH0IDwALJTsOCh8v9jOX-XhyzM_XKYVxNiNa4VtF39eYKO6VA_GS7w9pcXUvWJ2S6Q_neDY6RrfO7K2$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQTYK2BAC5ZBEPUFIIS5RNTXGOOPRANCNFSM6AAAAAAYD3BYDM__;!!NCc8flgU!a2L1gnbg7RH0IDwALJTsOCh8v9jOX-XhyzM_XKYVxNiNa4VtF39eYKO6VA_GS7w9pcXUvWJ2S6Q_neDY6Ujh1fr6$
.
You are receiving this because your review was requested.Message ID:
<twilio-professional-services/flex-project-template/pull/229/issue_event/9259787985
@github.com>


Fetching packages error

Operation System: Windows 10
Beaker Version: latest
I'm getting this error when executing yarn in a fresh project:
error https://s3.eu-west-2.amazonaws.com/beaker-plugin-safe-app/beaker-plugin-safe-app-0.3.0.tgz:
Fetch succeeded for undefined. However, extracting "https://s3.eu-west-2.amazonaws.com/beaker-plugin-safe-app/beaker-plugin-safe-app-0.3.0.tgz" resulted in hash "93ff8377180dc84c046b8598a15b9cd61190437a", which did not match the requested hash "496a9b46ffc32e050a5a636629dc4bd23d656de5".

I'm using NODE_ENV=dev.

It seems I fixed it by yarn cache clean and removing the yarn.lock files.


Is there a way to read bin and mark files in clikchouse

Is there a way to read bin and mark files in clikchouse

There were some examples in this talk (slides are in description), but most of it is in Russian: https://www.youtube.com/watch?v=7pyNmackUTw

https://stackoverflow.com/questions/57801513/is-there-a-way-to-read-bin-and-mark-files-in-clickhouse/57813669#57813669

There were some examples in this talk (slides are in description), but most of it is in Russian: https://www.youtube.com/watch?v=7pyNmackUTw

Russian..oh...no...  Do you have it in English?

Mark files has quite simple structure, while bin files structure is quite complicated.
The ClickHouse is opensource.
Please read the sources, there is no better way or step-by-step instructions.
The best way to read clickhouse files is to read it with ClickHouse.
If you have some concrete questions - please ask, but in current form it's too general (like "how to use computer").


Intersection between z.object and z.record incorrectly merges validators

When intersecting a z.object and a z.record, zod applies validators for the keys and values of the record to the rest of the object.
const ConfigSchema = z
  .object({
    name: z.object({
      first: z.string(),
    }),
  })
  .and(
    z.record(
      z.enum(['a', 'b']),
      z.object({
        sub: z.string(),
      })
    )
  );

const validInput: z.infer<typeof ConfigSchema> = { // typescript type is correct and doesn't complain here 👍
  name: {
    first: '',
  },
  a: {
    sub: '',
  },
};

ConfigSchema.parse(validInput);
// ^ this throws 2 errors because:
// 1. 'name' doesn't match ['a', 'b']
// 2. 'name.sub' is required (even though this will never exist)

Reproduction URL: stackblitz.com
Expected behavior: validators for record keys and values should only apply to the record.
The same problem occurs with intersections of records that have native enum keys and template literal keys (eg. [key: dynamic/${string}]).

Related to #2195

is there any alternative?


Use new Paper plugin dependency structure

Paper introduced a new, breaking change to their paper-plugin.yml structure.
The dependencies section is no longer a list/array, but rather has dedicated sections for server and bootstrap where you defined the plugin name, followed by options such as if it is required and when it should be loaded (before or after yours).
This removes the requirement of the load-before and load-after options as those are now part of the general dependency declaration.
This, unfortunately, will make my plugin incompatible with future versions starting at 1.21 because paper announced support for the old system until 1.21 comes out at which point it gets removed.
Because of this will I delay this PR merge until a first, stable 1.20 release comes out at which point I declare this plugin as 1.20+ only for the paper side moving forward.

Paper considers their releases now stable, so this got merged.


Add VMAC Support

This PR brings in VMAC support and resolves #91.
The original patch was made by @stevedwray.
Let me know if any changes are required.

This was fixed by merging #104.
Hence closing.


Added error detection and output to install.sh

Added error detection to abort script when one of the install script fails and some progress output

merging


Can't reproduce a Hydra build

Issue description
I observe a different behaviour between NixOS system (from the official VirtualBox image) and Hydra build:
http://hydra.nixos.org/build/34731828
The hydra build fails whereas build in my NixOS instance succeeds (with and without chroot enabled). According to the Hydra logs, the build fails with missing compiledata.h file which is generated by an invocation of a shell script:
https://github.com/root-mirror/root/blob/9afb00d699e7a1c32a72d15070db50d8b6bf33cf/build/unix/compiledata.sh
which is unconditionally called from here:
https://github.com/root-mirror/root/blob/9afb00d699e7a1c32a72d15070db50d8b6bf33cf/cmake/modules/RootConfiguration.cmake#L611-L615
I imagine that the problem might be with the shebang of the shell script and I have a hunch that a simple
    substituteInPlace build/unix/compiledata.sh \
      --replace "/usr/bin/env bash" "${stdenv.shell}"

could potentially fix the Hydra build. But it is really discouraging to try submitting PR's blindly without knowing why I get this different behaviour.
Any ideas why the issue happens at all?
Steps to reproduce
Run
bash <(curl http://hydra.nixos.org/build/34731828/reproduce)

The build should succeed despite it failing on Hydra.
Technical details

System:
16.03.616.4ac4b35 (Emu)
Nix version:
nix-env (Nix) 1.11.2
Nixpkgs version:
"16.03.616.4ac4b35"

That looks like a parallel-make issue – attempting to use the generated header before it gets created.

I don’t think so. The header is generated at the moment of cmake call which strictly precedes make -j ...

On 21 Apr 2016, at 08:39, Vladimír Čunát<EMAIL_ADDRESS>wrote:
That looks like a parallel-make issue – attempting to use the generated header before it gets created.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

In Hydra logs:
-- Performing Test found_stdexpstringview - Failed
-- Configuring done
WARNING: Target "clang" has EXCLUDE_FROM_ALL set and will not be built by default but an install rule has been provided for it.  CMake does not define behavior for this case.
WARNING: Target "clang-format" has EXCLUDE_FROM_ALL set and will not be built by default but an install rule has been provided for it.  CMake does not define behavior for this case.
-- Generating done
-- Build files have been written to: /tmp/nix-build-root-6.04.16.drv-0/root-6.04.16/build

From local builds:
-- Performing Test found_stdexpstringview - Failed
Running /tmp/nix-build-root-6.04.16.drv-1/root-6.04.16/build/unix/compiledata.sh
Making include/compiledata.h
-- Configuring done
WARNING: Target "clang" has EXCLUDE_FROM_ALL set and will not be built by default but an install rule has been provided for it.  CMake does not define behavior for this case.
WARNING: Target "clang-format" has EXCLUDE_FROM_ALL set and will not be built by default but an install rule has been provided for it.  CMake does not define behavior for this case.
-- Generating done
-- Build files have been written to: /tmp/nix-build-root-6.04.16.drv-1/root-6.04.16/build

"Running ..." and "Making ..." are output of the shell script.

I do get problems when compiling it locally:
[  1%] Building C object core/clib/CMakeFiles/Clib.dir/src/strlcpy.c.o
/tmp/nix-build-root-6.04.16.drv-0/root-6.04.16/core/clib/src/strlcpy.c:19:54: fatal error: RConfig.h: No such file or directory
compilation terminated.
core/clib/CMakeFiles/Clib.dir/build.make:62: recipe for target 'core/clib/CMakeFiles/Clib.dir/src/strlcpy.c.o' failed

Hmm, I actually get the same error when running with --cores 1 (after a rather long time, on [ 44% ]).

By the same you mean "Rconfig.h" one or "compiledata.h"?

"Rconfig.h". Maybe the situation has changed since the referenced Hydra build... I was trying these two builds on master c4626ad.

When I'm building c4626ad354ea1e7568d2ec8388871153925e7012 I get a following error:
Scanning dependencies of target Clib
[ 44%] Building C object core/clib/CMakeFiles/Clib.dir/src/detach.c.o
/tmp/nix-build-root-6.04.16.drv-1/root-6.04.16/core/clib/src/detach.c:28:23: fatal error: mmprivate.h: No such file or directory
compilation terminated.
core/clib/CMakeFiles/Clib.dir/build.make:62: recipe for target 'core/clib/CMakeFiles/Clib.dir/src/detach.c.o' failed
make[2]: *** [core/clib/CMakeFiles/Clib.dir/src/detach.c.o] Error 1
CMakeFiles/Makefile2:10512: recipe for target 'core/clib/CMakeFiles/Clib.dir/all' failed
make[1]: *** [core/clib/CMakeFiles/Clib.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2
builder for ‘/nix/store/ljk4dsck82xi29ss3x1sr1q6msn7b1dn-root-6.04.16.drv’ failed with exit code 2
error: build of ‘/nix/store/ljk4dsck82xi29ss3x1sr1q6msn7b1dn-root-6.04.16.drv’ failed

This one can't find "mmprivate.h". I used git bisect to determine that the build was broken by 491f7f017c4dd247413d3367d4733541c797d9ea.

I think my initial guess in the OP was correct.
Looking at #6227 it seems that /usr/bin/env may not be present in chroot on some of NixOS versions. I don't know what Hydra has, but my system does have /usr/bin/env in chroot.

NixOS systems do have it, but it isn't present during chrooted builds IIRC.

I just discovered that nix-build wasn't using chroot all this time even though I thought I asked it to do so:
nix-build --option build-use-chroot true -A root

I was able to enable it only through system-wide configuration in /etc/nixos/configuration.nix
Why --option build-use-chroot true doesn't work?

I'm not sure. Maybe you need to setup build-sandbox-paths as well.
The "chroot" strings are deprecated, really, and should be replaced by "sandbox". The old aliases are supposed to work, unless I've made a mistake when implementing that.

So the problem is that settings will not propagate to nix-daemon. This behaviour certainly doesn't hurt security, but nix should probably produce some warnings so that the user don't get confused.

It's unfortunate that even mistyped options just get silently ignored. I at least modified the PR template not to suggest passing that --option, as most use nix-daemon, I think.


Primaza controller gets blocked on existing resources during uninstallation

Steps to reproduce:
Follow one of the scenarios in test/acceptance/features/claimForCluster.feature by hand.  When finished, run make primaza undeploy to uninstall primaza.
Expected behavior
Primaza is successfully uninstalled from the cluster.
Actual behavior
The existence of the service claim sc-test blocks the completion of this make recipe, since its finalizer never gets removed.  This happens because the deployment can get removed before it successfully reconciles all the deletion requests.
To fix this in the primaza controller, we're likely going to need to have the controller watch its own deployment for deletions, like we did in the agents.

I've got a simpler reproduction (I think).  Starting from a bare cluster:

Install cert-manager (e.g. make deploy-cert-manager)
Deploy primaza (make primaza deploy IMG=$YOUR_IMAGE_HERE)
Undeploy primaza (make primaza undeploy)

I'm expecting step 3 to succeed, but it never does.


[a11y walker] improving UX for documents / AT reading modes

As an AT user, I want to read documents with mathematics the same way I read other documents, using my AT's smart modes, e.g., to read the entire document or read it line-by-line.
This experience falls short because, e.g., NVDA will (sensibly) read the aria-label ("math") when reading line-by-line, i.e., "When math holds, we get math which implies math".
While some navigation is availabe to reach back (ctrl+tab to go to previous focusable), it is not always reliable (jumping too far behind). Also, once you're on the focused element, I couldn't figure out if there's a way to get back into the flow.
Some ideas.

talk to AT community on expected / best-of-class behavior.
add complete speech text as aria-label (preceded by "math", perhaps, just like headings are preceded by "heading level n")
consider if we could/should/would get AT to stop at each equation (treating them as newlines, even inline math), and enable smooth UX for activating and continuing(/skipping) the walker.

What else could we do?

The into-struik branch contains a version where the math speech is pushed into the aria-label.
At least ChromeVox stops after a certain number of characters.
Maybe we could put the shortened text in there.

This is  addressed in PR #92
Labels contain summaries.


Do you have plans making it Material You and recode to Kotlin?

No navigation framework is more suited to be used with Java.


[FEATURE] Documentation - Document 'concurrent-search' sandbox plugin in OpenSearch 2.1.0+

Is your feature request related to a problem?
The new 'concurrent-search' plugin has been added to OpenSearch as a sandbox plugin.
What solution would you like?
Document the usage of the  'concurrent-search' sandbox plugin and its benefits and limitations.
What alternatives have you considered?
N/A
Do you have any additional context?
See please https://github.com/opensearch-project/OpenSearch/issues/2587

@reta Can we close this issue as it is not sandbox plugin any more. We are tracking the document task here https://github.com/opensearch-project/documentation-website/issues/3662


I used the parameter --bed with circAtlas bed file, the outputs are always "KeyError: '[circAtlas ID]'"

Though I deleted the record as the bug report mentioned, it always interrupts with error report like the image, so how should I do can quantify the sequence with circAtlas ID.

我的输入是

Hi @DooYal , the input file should be converted to standard bed format, for example:
chrom    start    end    circRNA_ID    .    strand

Hi @DooYal , the input file should be converted to standard bed format, for example:
chrom    start    end    circRNA_ID    .    strand

是这种格式的，也是制表符分割，但是总会在一个点报错，去查了一下报错的地方和其它行文本没有区别


Prim's Algorithm Program

A program of Prim's Algorithm is required in any language. The code should be in proper way without any extra spaces in between and must lie in appropriate repository.

I want to do this task. Do assign it to me @jatinagg2

I want to do this task. Do assign it to me @jatinagg2

You can do @atingarg1406


Propagate router.load context option when template7 is not used

Fixes #1271 . See issue for reasoning

Merged, thanks!


Remove color when saving result

Currently save get the color of results or post processors

Available in 1.0.6


Add python aux files to .gitignore

After running ./polaris ...:
$ git st
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	poetry.lock
	polaris-venv/
	pyproject.toml

Description
Excluding python-related auxiliary files from source control.

@snazy : Do you think we could merge this?

LGTM
Thanks!


added docs for Postgresql setup in FreeBSD jails

Hello @c0psrul3,
first: thanks for the patch!
But i need some more information. Since i'm a strong PostgreSQL user i need to now, with which PostgreSQL version in mind you wrote the patch? At least 9.5 and 9.6 really work without this changes. For 9.4 i would double check this - but its very likely that your update is needed.

thank you for noting this, I hadn't even looked.  It is Pg 9.3
And, you're right, I should upgrade.  However, it was installed along with the FreeBSD Package "gitlab-8.10.12"
Would you mind telling me which versions of Pg (9.5 / 9.6) can be used with Gitlab 8.12 / 8.13?  I think it doesn't matter.
I'll upgrade and come back with any further doc patches.  Thanks!

Hello Mike,
yes, PG 9.3 is the current default PostgreSQL version. We are currently trying to set 9.4 as new default.
The documentation states that GitLab needs PG 9.1 or higher, so it doesn't really matter, if you use 9.5 or 9.6. I use both.

thanks for the info.
take the patch for what it's worth, then  :)


Revert admissions plugin in guest API server

Issue #, if available:
Description of changes:
After syncing the flags with EKS we ran into an issue with admission plugins.
Nodes are not getting ready as the kube-proxy, cni pods fail to get created. Reverting this change for now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

added a backlog for tracking - https://github.com/awslabs/kubernetes-iteration-toolkit/issues/194


Click over button not will open tab

Hello all,
I'm using leaflet sidebar v2 and I need to have a button in sidebar that allows user to active control to click over map to get a poppup. That it works, but tab is expanded without content, and this is not necesary, in fact, in mobiles screen, is better not expand tab.
Is possible to click over a button in sidebar "collapsed" and continue "collapsed"?
Thanks a lot.

I got it myself :)
Just changing the "normal" code to add a sidebar's button:

To:

Pay attention, the diference is eliminate href attribute of a element, then add a jquery click binding to control the action:
$('.customButtonSideBar').click(function(){
...your code...
});


(GH-331) missing packages in ChocolateyGUI

The calculation of needed pages (PageCount) was wrong because of an invalid integer calculation where a floating-point operation would be needed.
Without this change there might be not enought pages to display all packages.
Example: 60 packages in repo - only 1 page containing 50 packages would be visible

The calculation of PageCount is still not correct.
Example, with the current floating-point calculation:
PageCount = (int)(((double)result.TotalCount / (double)PageSize) + 0.5);
if you have 60 packages and 50 items per page, you only get 1 page, the last 10 items are missing, because:
PageCount = (int)((60.0 / 50.0) + 0.5) = (int)(1.2 + 0.5) = (int)1.7 = 1
You should use the Ceiling() function to round up to the correct PageCount:
PageCount = Math.Ceiling((double)result.TotalCount / (double)PageSize);


Release 4.8 backport 20210114

Steps taken:
Pull from main git pull origin main
Revert of commit https://github.com/openshift/hypershift/commit/1cb533fa4788b696842ca656fb92c4f8dee76aad
git revert 1cb533fa4788b696842ca656fb92c4f8dee76aad -m 1
That PR was only intended for 4.9

As long as it doesn't force me to individually cherry pick 49 commits I'm ok to do that. But I don't think that's possible.

As long as it doesn't force me to individually cherry pick 49 commits I'm ok to do that. But I don't think that's possible.

I don't think you need to that individually. I think you could override you local history to drop that commit from this branch and create the PR without it e.g using git rebase -i.
Let's move forward we'll be stick to a more formalise process once we cut a first release as discussed here
/lgtm

/approve


Bug: missing decprication warning for labels followed by db

Labels without a : are deprecated in planed version.
When a label is missing a : a warning is printed.
So:
SomeData::
.values      db 0, 1, 2, 3, 4
.otherValues db 5, 6, 7, 8, 9

should result in a warning, but it don't.
The same bug could be existing by following commands in the same line.

Local labels (.label) without a semicolon are not deprecated.


GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

R: @apilloud

Run Java_Examples_Dataflow_Java11 PreCommit


Start enforcing naming style

Description
Now let's actually use clang-tidy to make improvements! This one was pretty easy since all classes already adhered to the correct style and only a few functions needed to be fixed.

SFMLBuildMaster: Build this please.

I like it! 👍


Update/Add Add Xcode 14.3

Tool name
Xcode
Tool license
Freeware
Add or update?

[X] Add
[ ] Update

Desired version
14.3
Approximate size
No response
Brief description of tool
Xcode 14.3 was released on 30.03, but it's still not available on the macOS 12 runners
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[ ] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[X] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hello! 14.3.x requires macOS-13 which is not provided for runners yet.

Oh ok - any estimates on when macOS-13 will be available ?

@mikhailkoliada Apparently there is a way to run Xcode on Monterey by modifying the Minimum system version in the Xcode 14.3 Info.plist seems to get it running - do you think it is possible to make it work on official runners?


Path fields are not not JSON serializable

Bug

OS: Ubuntu
Python version: 3.6.8
Pydantic version: 0.23

DirectoryPath is not json serializable.
import pydantic

class Model(pydantic.BaseModel):
    directory: pydantic.DirectoryPath

def test_directory_path_json():
    model = Model(directory="/")
    assert model.json() == '{"directory": "/"}'

if __name__ == "__main__":
    test_directory_path_json()

Traceback (most recent call last):
  File "<snip>/site-packages/pydantic/json.py", line 45, in pydantic_encoder
    encoder = ENCODERS_BY_TYPE[type(obj)]
KeyError: <class 'pathlib.PosixPath'>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tests/test_pydantic.py", line 14, in <module>
    test_directory_path_json()
  File "tests/test_pydantic.py", line 10, in test_directory_path_json
    assert model.json() == '{"directory": "/"}'
  File "<snip>/site-packages/pydantic/main.py", line 312, in json
    **dumps_kwargs,
  File "<snip>/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "<snip>/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "<snip>/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "<snip>/site-packages/pydantic/json.py", line 47, in pydantic_encoder
    raise TypeError(f"Object of type '{obj.__class__.__name__}' is not JSON serializable")
TypeError: Object of type 'PosixPath' is not JSON serializable

This is fixed by adding the correct types to the ENCODERS_BY_TYPE dict.
import pathlib

import pydantic.json

pydantic.json.ENCODERS_BY_TYPE[pathlib.PosixPath] = str
pydantic.json.ENCODERS_BY_TYPE[pathlib.WindowsPath] = str

Thanks for reporting. PR welcome to fix this.

How is this handled? I'm still having this issue. It'd be ideal for the library to just use str by default. Is it possible to configure that globally? thank you!


training manner?  two-stage or end2end

Hi there,
thanks for your fantastic work. However, I am a little confused about the differences between the readme.md and your paper.
In your paper,
you mentioned in Section 4.3 that

Though the entire framework is typically two-stage, the two modules can be trained simultaneously in an end-to-end manner.

but you use  python run.py in readme.md which is obvious a two-stage training manner.
So should we use python  e2e_run.py for end2end training or python run.py for two- stage training in order to reproduce your results?
Thx.

thanks so much for your kindly help. We have made your model available in our toolkit 😄 CRSLab

Cool! Fantastic work!


tutorial/congratulations seems redundant on learn.svelte.dev

From https://learn.svelte.dev/tutorial/congratulations:

You've now finished the Svelte tutorial and are ready to start building apps. You can refer back to individual chapters at any time (click the title above to reveal a dropdown) or continue your learning via the API reference, Examples and Blog. If you're a Twitter user, you can get updates via @sveltejs.

This is right before the advanced SvelteKit chapter, which is a bit out of place. I'd either edit it to be Svelte-specific, delete it or move it behind advanced SvelteKit. (I did not do this as a PR because there are multiple ways to solve it, but I'd be down to write something new for it!)

agree! am collecting similar examples in #281 so they're all in one place — closing this in favour of that issue


⚠ Bofrost.lu has degraded performance

In a60680f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1932 ms

Resolved: Bofrost.lu performance has improved in 5126468 after 7 minutes.


SOLR-12336 Remove Filter from Solr

https://issues.apache.org/jira/browse/SOLR-12336
Description
Currently, we use the getTopFilter method in Filter to access a Query based on a DocSet. This is done via calling Filter's main method getDocIdSet and then calling an iterator(). However, with Filter going away, we still need the ability to have a Query based on a DocSet. Removing Filter requires reducing and possibly eliminating dependencies on getDocIdSet and implies that changes must be made to all callers that call Filter specific methods as well.
Solution
To access a Query based on a DocSet without going through Filter:

Create a new Query, DocSetQuery, that emulates the behavior of Filter
Delete all calls to getDocIdSet which is Filter's main method
Implement change to DocSet's API by replacing getTopFilter with makeQuery to help go from DocSet to a Query of the DocSet
Delete Filter class

Tests
Refactored all existing tests that were affected as a result of deleting Filter. Expanded test coverage by updating test suite to account for changes made. All tests are passing.
Checklist
Please review the following and check all that apply:

[X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[X] I have created a Jira issue and added the issue ID to my pull request title.
[X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[X] I have developed this patch against the main branch.
[X] I have run ./gradlew check.
[X] I have added tests for my changes.
[X] I have added documentation for the Reference Guide

Also, I think DocSetQuery ought to implement DocSetProducer so that DocSetUtil.createDocSet will see this.

I rebased and force pushed the latest commit to due to recent changes in CHANGES.txt renaming contrib to module

I was chatting with Mike about splitting this vs not.  It's fine to not split this, and instead edit the PR title to refer to the parent issue about Filter disappearing.  I'll handle https://issues.apache.org/jira/browse/SOLR-14800 separately.

@dsmiley is this a 9.0 change because of the API surface we touch?

This PR was closed in favor of the new one SOLR-12336 which is a continuation of this one (SOLR-15257). The PR was changed as a result of renaming the branch to correctly reference the parent issue SOLR-12336. Please refer to new PR [ SOLR-12336](https://github.com/apache/solr/pull/566

This PR was closed in favor of the new one #566 which is a continuation of this one. The PR was closed as a result of renaming the branch to correctly reference the parent issue SOLR-12336. Please refer to the new PR here

This comment is no longer valid because I restored the branch and reopened the PR to preserve the conversation. I simply changed the PR title instead. The new PR has now been deleted

You force pushed again.  Can you please avoid doing that?


Design pipeline requirements

What are the steps we want to the pipeline to achieve? What are the tools?
Steps:

basic QC

FastQC
MultiQC
Quast

read trimming

Cutadapt

host removal

Bowtie2

assembly

MetaSPAdes
(or Megahit?)

MinHash profiling

[Sourmash]https://snakemake-wrappers.readthedocs.io/en/stable/wrappers/sourmash.html)

prototype selection

WoL Prototype Selection

I have two questions:

In terms of read quality trimming (I'm sure they're all fairly competent at adapter removal), I'm a bit more familiar with sickle, which uses a sliding window to trim reads. From what I've read, Cutadapt uses the partial sums of the quality scores. I don't have a good intuition about how these two approaches compare apples-to-apples, but since accurately identifying single nucleotide variants is going to be very important for me, I guess I'd prefer this step to be somewhat stringent.
Also, if we're using NextSeq chemistry, we should probably use the --nextseq-trim parameter instead of -q, which ignores the quality score of the G base.

Regarding Assemblies: My general feeling that I've gotten from talking to people is that MetaSPAdes might slightly edge out other assemblers in terms of larger, more complete assemblies, but that MEGAHIT is much less computationally expensive. Since these aren't going to be done over and over, a slight increase in time for a slightly better assembly makes sense to me. Many members of the Banfield lab seem to like using  IDBA-UD, but I'm not sure if it is even supported anymore.

So...maybe MetaSPAdes then?
Otherwise I think this sounds good.
On a very minor note -- do you think it might make sense to have the prototype selection be the first step of the binning pipeline? Everything else in this pipeline is being done on a per-sample basis. Also, I'm not sure what other types of analyses might use the prototype information besides the binning, so it might make sense to take a break before that. Just a thought!

Trimming
I'm thinking that the primary purpose of trimming, at this stage, is to remove adapter sequences and really bad sequences/ends. Some lower-quality positions don't really degrade assembly at all, and retaining more coverage is probably more important. Getting rid of adapters is important because they can create all sorts of artifacts in downstream steps, such as taxonomy profiling. Maybe for the initial processing/assembly it makes sense to focus on removing adapters, and we can use sickle as a pre-processing step prior to mapping? What do you think?
Assemblers
I'm doing some benchmarking right now on this. I would definitely prefer using MetaSPAdes. However, it seems to be taking like 5 or 6 days to assemble a metagenome! I have no idea why this is; it never took that long for me in the past. It is easy enough to swap out assemblers, or add alternative assembly paths.
Prototype selection
The issue here is that Snakemake needs to know exactly which files it's going to use at the beginning of a pipeline. So it is not really very feasible to have a step 2 that dynamically depends on the output from step 1. Now there are some kludgey  ways around this, but I think it will be a lot easier to leave prototype selection as an output of our primary processing pipeline. Or perhaps as a separate step altogether?

Can you point me to your assembly call / files? It would be nice to compare. It's taking way longer than I am used to.
For prototype selection:

we can definitely take the combined input of mash sketches to create a single distance matrix, and then run selection on that to produce a list.
the hard part (within a single pipeline) is to then have the contents of that list each be inputs to subsequent mapping steps.

so having the first part be the end of a pipeline won't present any issues for the rest of the pipeline running.
And yes, sourmash will be run on the filtered reads, not the alignment!

Ok, great. So it sounds like we'll trim and filter the reads, then MinHash and select prototypes, then we just assemble only those samples that will be used for binning. This is a little different than when I was imagining, where the MinHash profiles would be build from the assemblies.
What do you think is the optimal way to select the number of prototypes to select? Will this be a constant number of samples, or variable and based on the diversity of the sample set?
RE: the MetaSPAdes assemblies, unfortunately I cleaned up my folders this morning and deleted them, but I do have another set running right now.
/workdir/Sprockett/Projects/CU03_Liddell2020/CU03_StrainTracker_QC/StrainTracker/output/metaspades_assemblies


Add option to show Windows 11 Context Menu Shell Extensions always on main menu and not sub-menu

What feature or improvement do you think would benefit Files?
As more products are correctly supporting the Windows 11 Context Menu structure, it would be great if Files had the option to pick up shell extensions that have Windows 11 Context Menus where they are available, displayed them on the top-level menu (perfoming as expected in Windows 11) and removing their legacy menu (if they exist) from the "Show more options..." sub menu.
Requirements

Add option in settings for Context Menu to "Use/Honour Windows 11 Context Menus" or use only legacy shell extensions
Logic in app to determine duplication of Windows 11 and legacy shell extensions depending on this setting
If in Windows 11 Context Menu mode, always show these on the main menu even if "Move shell extensions to sub menu" on
If "Move shell extensions to sub menu" off, group Windows 11 extensions after main section, and then show other extensions

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Pro Version	22H2 build 22621.1344
Comments
No response

This is available in preferences settings "Move shell extensions into a sub menu".

No it does not do what I was asking for - maybe I did not explain it clearly.
Below is my Windows 11 File Explorer menu with the Windows 11 Context Menu items shown:

and below is Files menu with "Move shell extensions into sub menu" enabled:

What I am suggesting is to provide the option to have the best of both of these, with the Windows 11 Context Menu items available on the main context menu in Files - mocked up as follows:

The option doesn't currently apply to the home page widgets (it's on the todo list), however, if you right click a file in one of the layout modes it'll take affect.

I've just tried it on some files in Downloads and in Music and it does not show the Windows 11 Context Menu items on the main menu (same system as previous screen shots where Windows File Explorer is showing the additional menus.

Is this coming in a new version? This was with version <IP_ADDRESS> on Windows 11 22H2.

Did you turn the setting off? It looks like the setting is still turned on.

Switching the setting off

gives ALL the extensions added, making the menu a scrolling menu which is really hard to use

while switching the setting on

has the following


applyMiddleware() just ignored? Docs (edit: not) followed letter by letter

Please take a look at this:
https://github.com/reactjs/redux/issues/2683
The same technique is working for me in React Native, just not ReactJS.

Resolved in the other issue.  The error was not actually calling the thunk action creators (ie, dispatch(someThunk) when it should be dispatch(someThunk()).

Thanks, finally made it clear for me. REally sorry about this kind of hysteria :)


✨ Wait for docker-postgres to "truly" start and accept connections

See https://github.com/docker-library/postgres/issues/146 for more information

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2fb42f3). Click here to learn what that means.
The diff coverage is 91.48%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   91.48%
=========================================
  Files             ?        1
  Lines             ?       47
  Branches          ?        2
=========================================
  Hits              ?       43
  Misses            ?        4
  Partials          ?        0

Impacted Files
Coverage Δ

src/index.ts
91.48% <91.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb42f3...651e397. Read the comment docs.


[issue - 28, 67, 68, 72,73] improvements in bitbucket subscriptions

Summary
Resubmission of https://github.com/mattermost/mattermost-plugin-bitbucket/pull/75
Ticket Link
Fixes #67
Fixes #68
Fixes #72
Fixes #73

@mickmister This is a re submission of https://github.com/mattermost/mattermost-plugin-bitbucket/pull/75 with master merged.


HauserParabolicSmoother ignores timelimit argument on construction

I tried to pass the timelimit parameter to the prpy.planning.retimer.HauserParabolicSmoother constructor, but when I attempt to smooth trajectories, the default limit of 3 sec is used instead.  It appears that the constructor parameter is inserted into a self.default_options dictionary which appears to be ignored when the instance's RetimeTrajectory planning method is called.  I'm happy to take a stab at this later, but I figured someone who knows this code better would know the short path to a fix.

@cdellin does #277 cover this?

#277 should cover this. @cdellin please re-open this issue if it does not.


Make certs generate themselves from container

What does this PR do?
This PR makes the certs generate themselves inside of the controller by using a job. It will run the job only if needed (there haven't been any previous completed jobs). If the job creates the certs then it will update the deployment with the correct volume/volumeMounts

[ ] There is an issue with running cloud shell that I'm currently investigating

What issues does this PR fix or reference?
https://github.com/eclipse/che/issues/16251
Is it tested? How?

tested on crc and started theia workspace, currently diagnosing why cloud shell isn't starting properly

Closing in favour of following: https://docs.openshift.com/container-platform/4.1/authentication/certificates/service-serving-certificate.html


Dockstore Primer updates

Feature Request
Desired behaviour
Place-holder for updating our Dockstore primer with information on ui2 and any search dependencies.

Assigning this for @JWKaiqi  's final week. This will involve updating the the primer ( https://wiki.oicr.on.ca/display/SEQWARE/Dockstore+Primer ) and readme.md ( https://github.com/ga4gh/dockstore/blob/develop/README.md ) with documentation
Updates include

How to install + use kibana to support the tag clouds page (and where the tag clouds page is)
Updates for using and developing with ui2 including the build tool (angular-cli)
the best resources for learning angular 2
updating the search demo instructions

@garyluu  adding you to this ticket since you'll want to double-check sure that Jennifer's last week of work is properly handed off and works in your hands

@agduncan94
To finish this off, please update the Dockstore primer as you encounter inconsistencies or holes during your re-orientation

I've added some documentation for how to setup dockstore with UI2 in the wiki primer.


Refresh inventory.

Good night, I have a question. Which is the easiest way to refresh the inventory every X seconds? (Items and its lore)
I only want to refresh the contents because it could be that a new item be created or removed with a command that my plugin has.
Greetings.

@SamJakob

Can you share the code you're using to update the lore on the item?
Just some general tips:

When you change the lore, make sure you're actually updating the item reference stored in the menu. So try:SGButton button = myMenu.getButton(/* slot number */);
button.getIcon().setLore(/* lore */);

If you're only changing the runnable in the same closure as it's defined (i.e. you're not changing the value in a lambda), you don't need the AtomicReference - you can just use a straight up BukkitTask. I used that in the example to pass it into my button listeners and the page change listener.

I thought that "myAwesomeMenu.refreshInventory(p);" refreshed the items and its lore.
I don't know how that could work, because as i said it is possible that the items of the inventory be deleted or new ones be added.

Yeah it should do as everything's passed by reference but I'm not sure how you're updating the inventory. Can you share the snippet of your code where you update the lore?

This is my method, it is supposed that the lore part "Time" updates (00:01, 00:02, etc), but it does not change.
I use myAwesomeMenu.refreshInventory(p); to try to update the inventory including the lore, but it does not.
`@SuppressWarnings("deprecation")
public static void matchesGUI(Player p) {
ArrayList duels = plugin.getDuels();
	SGMenu myAwesomeMenu = Main.spiGUI.create("&bMatches", 1);

	for(Duel1v1 duel : duels) {
		List<String> lore = new ArrayList<>();
		lore.add(ChatColor.translateAlternateColorCodes('&', "&a"+duel.getPlayer1().getPlayer().getName()+" &evs &a"+duel.getPlayer2().getPlayer().getName()));
		lore.add(ChatColor.translateAlternateColorCodes('&', "&fTime: &b"+duel.getMatchTime()));
		lore.add(" ");
		lore.add(ChatColor.translateAlternateColorCodes('&', "&fKit: &b"+duel.getKit().getName()+"."));
		lore.add(ChatColor.translateAlternateColorCodes('&', "&fArena: &b"+duel.getArena().getName()+" &7("+duel.getArena().getKit().getName()+")."));

		SGButton myAwesomeButton = new SGButton(
		  new ItemBuilder(new ItemStack(duel.getKit().getId(), 1, (short)duel.getKit().getDatavalue())).name("&d"+duel.getType()+" 1v1").lore(lore).build()
		).withListener((InventoryClickEvent event) -> {

		});

		myAwesomeMenu.addButton(myAwesomeButton);
	}

	AtomicReference<BukkitTask> borderRunnable = new AtomicReference<>();

	borderRunnable.set(new BukkitRunnable(){

		@Override
		public void run() {
			myAwesomeMenu.refreshInventory(p);
			Bukkit.broadcastMessage("this");
		}

	}.runTaskTimer(plugin, 0L, 20L));

	myAwesomeMenu.setOnClose(inventory -> {
        if (borderRunnable.get() != null) borderRunnable.get().cancel();
    });

	p.openInventory(myAwesomeMenu.getInventory());
}`

Ah - you create all the buttons and add the lores to them, but then you don't ever update them again.
You're calling refreshInventory every second however you haven't actually updated the lores on any of the items. You'll need to add the code to generate the buttons with their lores to the lambda.

Can you give me some code example?

Can you add a setTitle call before you refresh the inventory? That updates the inventory a different way and I would be interested to see if that method would refresh the contents and the lore.

Hi, I tried adding a setName as you said but it didn't work.
On the other hand, I could do a way to refresh the inventory. Simply before refresh the inventory, I used clearAllButStickiedSlots to remove all items and my method to put them again, so now my issue is.... Solved?
Nevertheless, it would be great if in future updates you make that refreshInventory refreshes the contents and its lore instead of.

The SpiGUITest.java file has now been updated to show how to do this.
As you mentioned, re-adding items to the slots is the correct answer.
This is because the code to create the GUI is not re-run when the GUI is refreshed, and without manually having references to each button somehow (i.e., creating a new variable for each SGButton and then adding each into the menu which would be very cumbersome) and updating those, refreshInventory will not work. Changing the inventory name does cause the name to update as the new name is passed into the inventory, but I misunderstood what the issue was here - doing that, of course, would not cause the information to update.
If you wanted a solution to refreshInventory that refreshed the inventory contents and lore in the same way they are generated when the inventory was first opened, I would need to modify the SGMenu API so that all the code to generate buttons for the GUI are placed into a function that can then be re-run when the inventory refreshes.
I hope that somewhat explains the issue and a potential fix -- this is something that warrants its own new feature though, rather than a quick tweak to the existing code. In other words, this is a feature, not a bug 😉.


Interrupting train.py

Hi!
I am running train.py on not enough powerful computer. And so I can't use the computer, while it is training. What would happen if I interrupt train process? Currently, I am on 1225 steps and to get to 5000 that is a long time.
Can I later run train process again and it will continue where it left off?
Thank you!

Yes you can stop when you want and it will continue from last checkpoint

Hi!
Checkpoint was only made ad 300 steps. So I lost about 27 hours and 925 steps.
Thank you for your answer.

27 hours for only 975 steps is not logic or you run on CPU... in 27 hours i do around 64 000 steps on Colab ^^'
You should run the code on colab, you can put all your code on github (or google drive) (and your dataset) and then run in Colab  (with GPU environment) it takes around 2-4 sec / step for me (outputs_per_step equal 2 and max_mel_frames 900)
You must also make checkpoint every 500 or 1000 steps and not close your colab tab (it closes your session after around 12hours if open and 1hour if closed) so you can load checkpoints (from colab) during training and re-import them when you continue training

I have instaled TensorFlow-GPU but it always used CPU. And I was doing this on not soo powerful laptop. I just wanted to try if I would get speech to a level that is just a little understandable. And if that would be the case, I would use my server to do heavy work.
I thought I modified parameters that would make checkpoint every 50 steps. But it wasn't... So I thought that code will automatically make a checkpoint after a keyboard interrupt.
Besides speech quality in log directory is for a first 3 seconds a bit understandable but then it is just garbage...

You can run it on Colab in one day you can have good voice (metallic but understandable)

Oh really?
I will try.
Do you have any experience with other languages and this script? I want to try for Slovenian language...

I used it with french dataset and the result is good but the voice is too metallic caused by the training data (i think the transformation (to linear / mel spectrogram) causes it but not sure

Okay.
Thank you for info.
I am fairly new to this. Especially in Python programming language. Are there instructions on how to use Colab ant Tacotron-2?

Ouf... if you are new it could be difficult but you can look tutorials i can’t explain it like this sorry ^^'

No problem!
I will eventually figure it out. ;)
Thank you @Ananas120 for answers!

No problem and good luck !
If you have precise question you can ask me ;)


Can not support mouse event on Mac os

It seems that mouse could not work on Mac os.any ideas? Thanks.

@fanday  I assume you tried to build and run the unix port of lv_micropython, is that correct?
Is the display working ok?
The SDL driver for mouse and display is the same driver used on lv_drivers repo.
Did you try to run the pc simulator? Could you confirm it runs correctly on Mac OS?
@kisvegabor - any idea why the SDL driver wouldn't work on Mac?

@amirgon @fanday I think there is a setting in lv_drv_conf.h for using SDL on Mac OS.

@embeddedt Did you mean USE_EVDEV? There is no mention of Mac or OSX...

@amirgon I think I got mixed up... I was referring to this but it looks like it's defined automatically:
https://github.com/littlevgl/lv_drivers/blob/b9825c196924275073402637f056e25362086c9d/display/monitor.c#L34-L38

@amirgon  Additionally,  this needs to be used in the while(1) loop:

#if defined(__APPLE__) && defined(TARGET_OS_MAC)
# if __APPLE__ && TARGET_OS_MAC
#define SDL_APPLE
# endif
#endif

...

        #ifdef SDL_APPLE
            SDL_Event event;

            while(SDL_PollEvent(&event)) {
                #if USE_MOUSE != 0
                    mouse_handler(&event);
                #endif

                #if USE_KEYBOARD
                    keyboard_handler(&event);
                #endif

                #if USE_MOUSEWHEEL != 0
                    mousewheel_handler(&event);
                #endif
            }
        #endif

@fanday I assume you tried to build and run the unix port of lv_micropython, is that correct?
Is the display working ok?
The SDL driver for mouse and display is the same driver used on lv_drivers repo.
Did you try to run the pc simulator? Could you confirm it runs correctly on Mac OS?
@amirgon  the LCD works fine, only the mouse event not work.BTW, the littlevgl C demo works fine on mac os.
@kisvegabor - any idea why the SDL driver wouldn't work on Mac?

@fanday I assume you tried to build and run the unix port of lv_micropython, is that correct?
Is the display working ok?
The SDL driver for mouse and display is the same driver used on lv_drivers repo.
Did you try to run the pc simulator? Could you confirm it runs correctly on Mac OS?

@amirgon the LCD works fine when use mpy, only the mouse event not work.BTW, the littlevgl pc simulator works fine on mac os.

@amirgon Additionally, this needs to be used in the while(1) loop:
#if defined(__APPLE__) && defined(TARGET_OS_MAC)
# if __APPLE__ && TARGET_OS_MAC
#define SDL_APPLE
# endif
#endif

...

        #ifdef SDL_APPLE
            SDL_Event event;

            while(SDL_PollEvent(&event)) {
                #if USE_MOUSE != 0
                    mouse_handler(&event);
                #endif

                #if USE_KEYBOARD
                    keyboard_handler(&event);
                #endif

                #if USE_MOUSEWHEEL != 0
                    mousewheel_handler(&event);
                #endif
            }
        #endif

these code could not enable in the SDL refresh thread, I have try to enable it and it crash the app.

@fanday The code should be put underneath the call to lv_task_handler.

For some reason (not clear why) the event handling needs to be called fro the main thread on OSX. Like here: https://github.com/littlevgl/pc_simulator_sdl_eclipse/blob/master/main.c#L81
@amirgon Is it possible to do something similar in mpy?

For some reason (not clear why) the event handling needs to be called fro the main thread on OSX. Like here: https://github.com/littlevgl/pc_simulator_sdl_eclipse/blob/master/main.c#L81
@amirgon Is it possible to do something similar in mpy?

@kisvegabor the event handling is done on the same thread the micropython is running on.
I assume micropython is running on the main thread on OSX, I'm not sure about this.
on modSDL.c:
STATIC int tick_thread(void * data)
{
    (void)data;

    while(1) {
        SDL_Delay(1);   /*Sleep for 1 millisecond*/
        lv_tick_inc(1); /*Tell LittelvGL that 1 milliseconds were elapsed*/
        mp_sched_schedule((mp_obj_t)&mp_lv_task_handler_obj, mp_const_none);
    }

    return 0;
}

Here, tick_thread is running on a different thread, but mp_sched_schedule schedules the actual event handling back on the micropython thread.

@kisvegabor The problem is probably here:
void monitor_init(void)
{
    /*OSX needs to initialize SDL here*/
#ifdef MONITOR_APPLE
    monitor_sdl_init();
#endif

    SDL_CreateThread(monitor_sdl_refr_thread, "sdl_refr", NULL);
    while(sdl_inited == false); /*Wait until 'sdl_refr' initializes the SDL*/
}

Then monitor_sdl_refr_thread calls monitor_sdl_refr_core in a loop.
Why not call monitor_sdl_refr_core periodically as lv_task, or directly from
mp_lv_task_handler instead of from its own thread?

@fanday The code should be put underneath the call to lv_task_handler.

@embeddedt  The code work fine now on Mac OS, thanks.

@embeddedt The code work fine now on Mac OS, thanks.

@fanday Could you summarize what is the change you did that solved your problem?

@amirgon He added the code I suggested here: https://github.com/littlevgl/lv_binding_micropython/issues/12#issuecomment-468075846
It needed to go under the call to lv_task_handler just like in the PC simulator.

@amirgon He added the code I suggested here: #12 (comment)
It needed to go under the call to lv_task_handler just like in the PC simulator.

Thanks @embeddedt!
I've submitted a change to SDL driver so the event loop runs on the same thread as Micropython. This should fix both this issue and issues related to concurrency, since Micropython Bindings is design to run lvgl and the display driver on the same thread as micropython.
@kisvegabor I don't know much about SDL, so I would appreciate if you could review 77b0c9f26.
@fanday I don't have access to a Mac machine. I think this solves your issue. I would appreciate if you could verify it. If it doesn't please re-open the issue.
Closing.

@amirgon
It should be fine if SDL is inited in the same thread as monitor_sdl_refr_core().
I'm considering to restructure the PC simulator project this way (init SDL in main() and add monitor_sdl_refr_core to the main while(1)).


Crash in color transition when I use UIColor(patternImage:)

I set my item.backgroundColor with API  UIColor(patternImage:), and when I scroll items, the color transition will invoke  function:
// UIColor+interpolation.wift
func components() -> (CGFloat, CGFloat, CGFloat, CGFloat) {
    guard let c = cgColor.components else { return (0, 0, 0, 1) }
    if (cgColor.numberOfComponents == 2) {
      return (c[0], c[0], c[0], c[1])
    } else {
      return (c[0], c[1], c[2], c[3])
    }
  }

and I find out that UIColor made with UIColor(patternImage:) only contains one CGColor component,  and cause crash.
let color = UIColor(patternImage: UIImage(named: "some")!)
let components = color.cgColor.components
// components.count is 1

Thanks for reporting! I'll look into getting this fixed soon

Hi @Scyano! I started looking into this, but I'm not really sure how to handle it. You could initialize a color using any type of image, so I don't really know the color here. I'm thinking of defaulting to black in this case, just so we prevent it from crashing at least. What do you think?

It's fine! When someone use patternImage, he do not need color transition actually


Use the atom-text-editor tag instead of the editor class.

In keymaps/atom-git-diff-details.cson: Use the atom-text-editor tag instead of the editor class.

already reported #10

Thanks


I'm interested in becoming maintainer

This project is in maintenance mode. I am not actively working on this package any more, but I am responding to issues and merge the occasional pull request. If you miss any functionality, feel free to send pull requests.
If you are interested in taking over this package, ping me.

I'm interested in becoming maintainer of this library.  Thoughts?

I would be very happy to put this package in caring hands. If it's okay with you, I'll simply transfer ownership of this repository to your account.
Thanks for the offer.

Yup, works for me!

I initiated the transfer. Again, thanks for volunteering!