Is there a BOM?

Just to make sure I don't order the wrong parts (especially for the resistor networks), do you have a BOM or at least some part numbers from Mouser or Digikey?
Also, what sizes are those caps/resistors?
Thanks!

Sorry, I didn't notice the BOM in the v3 folder.


"Tradeoffs" or "risks" section to the proposal?

Do you think it would be useful to add a "tradeoffs" or "risks" section to the proposal? At this moment it may seem as if it has no downsides to consider. However, some points were raised (and dismissed) in the issues that indicate potential problems arising from the proposal, for example:

breaking existing bundlers #28
breaking tree-shaking at least for same cases #19
making dead code elimination analysis harder

It seems like a common practice for language enhancement proposals, see for example http://openjdk.java.net/jeps/286 (or any other JEP).

Those are all variations of the same issue that involve some sort of optimization by turning modules into non-modules. This proposal doesn't break bundlers as bundlers already have methods for allowing dynamic looking (because in their case it's pre-determined) loading. The same work-arounds that are used today will be useable with import() (Webpack already supports import() and AFAIK it isn't broken because of it).
The need for such tools is, in my opinion, a bug in the web platform and should be fixed in the appropriate place, not by making the language less expressive.

of the same issue that involve some sort of optimization by turning modules into non-modules

Those were the examples present in the issue tracker. However, the underlying point is deeper and comes from the fact that ES modules are static, which allows to provide (unsurprisingly) better static analysis for any purpose, be it linting, drawing or analyzing module dependency graphs, IDE support or (as you correctly noted) optimization [1]. As evidenced by almost all programming languages out there (even highly dynamic ones like Python discourage import trickery), there are benefits for statically analyzable module dependencies. Even if they are not fully realized at this point in JS ecosystem (which can be expected given relative youth of ES modules and presence of alternatives), reasoning by analogy can give us a high degree of confidence in usefulness of static module system.
The proposal makes a currently static module system into a dynamic one seemingly without weighting potential downsides. Given the scope of impact of the decision (JS is one of the most important programming languages in the world right now, and the next ES spec will affect software for years to come) it seems prudent to list and weight potential downsides.

not by making the language less expressive

Expressiveness is a tradeoff, which can be seen in abundance of linters which constrain it in favor of readability, consistent style, and robustness. The upside of linter usage is that they allow different teams make different tradeoffs for themselves. However, this is not the case with the module system, which is a fundamental API for interacting with other's code. Granted, you can add a rule to your team's linter to prohibit things like import(getSomeRandomModuleNameFromUser()). Unfortunately, it will not help your linter/IDE/whatever to see your dependency's dependency, breaking your tools even if you are doing everything "right" (for your team). This is the fundamental difference between "local" features like splice operators or fat arrows and "global" ones like the module system.
So my main point is that it can be useful to enumerate and consider potential downsides of such a fundamental and far-reaching decision.
[1]: I should note that optimization like dead code elimination by itself has nothing to do with "turning modules into non-modules". It's possible to eliminate dead code inside modules, too, with varying degrees of sophistication ranging from "tree-shaking" to proper flow analysis. Either the "bug in the web platform" that you are mentioning is a limitedness of disk space, bandwidth, and CPU, or I fail to see how the existence of unused code or the need to remove it can be seen as a "bug in the platform".

As you point out, JavaScript is a dynamic language. It's hard to statically analyze many JavaScript features, this one doesn't make it any harder to do so.  JavaScript is never going to be C++. ES modules weren't made static for the sake of tooling.

It's possible to eliminate dead code inside modules, too, with varying degrees of sophistication ranging from "tree-shaking" to proper flow analysis.

It's possible to dynamically load modules (at least on the web) with or without modules. Here's an example of where that is done: https://gist.github.com/domenic/fd84ee5f4e2dc0278ab1#file-import-module-current-js
So any tree-shaking is going to have to be enforced out-of-band.
And to clarify, I'm not involved in this proposal, I'm just an outside web developer who's interested in seeing it succeed. So my opinions are only my own here.

None of these are "tradeoffs" of this proposal - they're all things you can currently do in the language, and all the issues you referenced already are problems in the ecosystem. This simply allows you to do it syntactically, which makes it more possible to lint against them, and statically analyze them.

It's hard to statically analyze many JavaScript features

It's true.

this one doesn't make it any harder to do so

It does. As I said, it replaces static module system with a highly dynamic one. It's impossible to statically analyze a dependency like import(getMoonPhase()).

It's possible to dynamically load modules (at least on the web) with or without import()

I'm not sure how this is related to the part you've cited (about eliminating code inside modules). Moreover, I can't see how the fact that you can import stuff dynamically in host-specific and hacky manner implies that there are no tradeoffs in putting this into the language spec itself.

None of these are "tradeoffs" of this proposal

I would be really happy if you or author point at others. There are always tradeoffs, and I can't believe that such a fundamental change (static -> dynamic module system) in a huge ecosystem will not have any worth mentioning.

all the issues you referenced already are problems in the ecosystem

In my opinion, that's exactly right and the main reason why switching from a static module system back to a dynamic one may have downsides.

which makes it more possible to lint against them

I'm not sure if people lint second-order deps often. Right now putting stuff in the DOM to dynamically load another stuff is clearly a hack and is frowned upon; this proposal "legitimizes" the behavior and makes it more probable to encounter it in a random lib on NPM. Moreover, it can also make the ecosystem fragmentation even worse (one more module type to handle — ES6+include!). Are you really 100% sure that there will be not a single problem in the entire JS ecosystem arising from the switch to dynamic modules? If not, why not try to list them?

The module system was always intended to allow dynamic modules, from the very beginning - "only ever static modules" was never a goal nor a guarantee. This isn't a "switch" to dynamic modules, which both already exist and were always intended to exist - it's just a standard way to import them.

My interpretation is that static syntax is in support of required DEPENDENCIES for module execution where as dynamic importing is for potential RESOURCES possibly to be used within that execution. Are these not two completely different use cases?

So far the "tradeoffs" or "risks" been part of each conversations but have not shown as matrix with importance.
Few items on matrix I think of:

backward compatibility, i.e. availability of shim in old JS engines
extensibility, like wrapping the JS native import() function and doing custom parameters preprocessing and/or error handling with recover. Of course the proper extensibility API would be better, but so far there only objections to the idea :(

Just like stated in README

The existing syntactic forms for importing modules are static declarations. They accept a string literal as the module specifier, and introduce bindings into the local scope via a pre-runtime "linking" process. This is a great design for the 90% case, and supports important use cases such as static analysis, bundling tools, and tree shaking.
Getting rid of great design for the 90% case really does look like some kind of a trade-off. As for me import(intepretToPuppiesKillerModuleName()).then(killPuppies) looks like clearly worse than if (wantToKillPuppies) then {import('PuppiesKiller').then(killPuppies)}. With this restriction we would know the whole set of importable modules before runtime at the cost of putting some conditional before import.

Other major tradeoffs/risks:
The proposal overloads an existing symbol with new behaviour, new syntax, new semantics and makes the symbol context-sensitive:

"static import" is import X from Y

this is the only allowed form
can only exist at the beginning of the module <- context sensitive
is basically destructuring assignment of symbols imported from Y

"dynamic import" import(Y).then({ X })

this is the only allowed form
can exist anywhere <- context free
introduces "nesting" (a.k.a. scopes) in a separate proposal

which may or may not overlap this one

So, what is this new import?
A new keyword? No.
A builtin function on par with eval, parseInt et al? Why does it override the name of an existing keyword?
Wouldn't it be better to introduce module-related functionality into a new global Module object exposing

Module.import
Module.importAsync

etc.?
Oh, right. "You know nothing, John Snow" and "That's not an argument against progress."

Another drawback which is simply dismissed out of hand. https://github.com/tc39/proposal-dynamic-import/issues/26

On second thought that has drawbacks that outweigh the considerations here. It should be up to the sandboxing environment to modify eval() to perform whatever restrictions it wants.

(emphasis mine)
Multiple incompatible security issues, anyone?

Multiple issues with proposed syntax and behaviour flatly ignored https://github.com/tc39/proposal-dynamic-import/issues/23#issuecomment-263439543
Reproducing some of them here:

Using a call-like syntax for dynamic import deviates from the pattern used for other keyword based expression forms including yield, await, typeof, void, delete.

We should not establish the precedent of context sensitive expression operations masquerading as function calls.
Conceptually JS devs should not think about import as a "function call" with hidden contextual arguments. It really is just an operator applied to a string producing a promise to a significant effect.
The super constructor call super() isn't a good precedent for this deviation, as that form actually performs a function call while dynamic import does not.

Also, import() is not a function, https://github.com/tc39/proposal-dynamic-import/issues/23#issuecomment-265979806 but disguises itself as such:

Promise.all(['α', 'β', 'γ', 'δ', 'ε', 'ζ', 'η', 'θ'].map(import))
 .then(console.info.bind(console))
 .catch(console.error.bind(console));

You'll get syntax errors if you try to use dynamic import as a map function

Because? Reasons?
Oh. Because "TC39 conclusion: keep it as a function-like form" :-\

All this begs just one question: how did it ever get to Stage 3?

@si14

It does. As I said, it replaces static module system with a highly dynamic one

I think you misunderstood the purpose of this proposal, it doesn't replace anything it just makes loading easier at runtime, you can use only static imports if you want. It just makes convinient to use same loading mechanics and hooks. Better look first at https://github.com/whatwg/loader proposal
@dmitriid

A builtin function on par with eval, parseInt et al? Why does it override the name of an existing keyword?

eval and parseInt was in language from the begining but when you add new functionality you must be careful not to break existing code that may already use your naming, and import already reserved keyword from ECMAScript 1, so it will not break anything
import also not a function, it is special syntactic form:
const a = import; // will throw exception

Wouldn't it be better to introduce module-related functionality into a new global Module object exposing

dynamic import intended to be used not only in modules but also in usual scripts

@forceuser

import also not a function, it is special syntactic form:

Exactly. It looks like a function, it behaves like a function, but:

it overrides an existing keyword
it does not behave like a function in any other context where you would expect a function to work

So it introduces a new confusing construct which behaves like nothing else in the language (with the possible exception of eval). Why?

Better look first at https://github.com/whatwg/loader proposal

Looking at it. Unless I'm mistake, it's clearly superior:

It doesn't override existing keywords
It doesn't provide "special forms" that have confusing semantics
It introduces functionality as global objects

dynamic import intended to be used not only in modules but also in usual scripts

There's a global Math object. Works perfectly in usual scripts. There's a global Array object. There's a global... You get the idea ;)

global object can't know about module context, so it can't load files relatively to the module path.
so import is the solution for that issue
another possible solution to create object for each module context, like module in commonjs

So, there are other solutions ;)
And import() has multiple drawbacks as I listed them above, and exactly zero of them have been addressed. yet, somehow this is stage 3 already.

Let me re-iterate:

introduces a new special form in a form that doesn't exist in the language (it is a function call which is not a function, it is a keyword which is not a keyword)
the form overrides an existing keyword with new semantics and syntax
the form is context-sensitive in a language that is mostly context-free
the form overlaps Loaders proposal
the form overlaps nesting import proposal
the form's behaviour in eval is left to be implementation-specific (hence inherently incompatible between implementations)
the form introduces changes to runtime behaviour of multiple JavaScript VMs (also, making parsers slightly more complex — import is now entirely context-sensitive)

"Minor" issues

the form breaks or renders inefficient existing tools (dependency analysis, tree-shaking etc.)

None of these drawbacks and risks have been addressed in any shape or form, and any questions about these have been dismissed out of hand.
Why is this stage 3?
@domenic @probins @robpalme @jakearchibald ?

@dmitriid

introduces a new special form in a form that doesn't exist in the language (it is a function call which is not a function, it is a keyword which is not a keyword)

This is a non-problem, same as meta-properties are not properties. It is a keyword https://tc39.github.io/ecma262/#prod-Keyword . There are no known grammatical ambiguities.

the form overrides an existing keyword with new semantics and syntax

No grammatical collision, this is not true, same as new.target is not a problem.

the form is context-sensitive in a language that is mostly context-free

Modules are always this way. Consider import './foo';. To note, since this is syntax it cannot be passed between files, so the context is the file containing import(...). Same context sensitivity as import declarations.

the form overlaps Loaders proposal

whatwg-loader is not intended to be shipped currently to browser in favor of type=module and the node ep.

the form overlaps nesting import proposal

This proposal is a higher stage
This proposal is more flexible but still allows static analysis for dynamic specifiers in addition to DCE in await position.
No grammatical ambiguity due to (.

the form's behaviour in eval is left to be implementation-specific (hence inherently incompatible between implementations)

See plans for Realms
Yes, same as import declaration inner workings which will not be 100% compatible between the web and node.

the form introduces changes to runtime behaviour of multiple JavaScript VMs (also, making parsers slightly more complex — import is now entirely context-sensitive)

False, engines already track host provided info such as location

https://github.com/v8/v8/blob/87d7bb40d68a09a5197192358fb300645f9e3202/include/v8.h#L1331-L1333
https://github.com/Microsoft/ChakraCore/wiki/JsParseScriptWithAttributes

the form breaks or renders inefficient existing tools (dependency analysis, tree-shaking etc.)

Dep analysis is possible and used in webpack for static specifiers
Tree shaking is possible and being worked on for await position

I would also like to note that ESM is only static for a single dep graph while most web pages for example have multiple entry points (hence multiple dep graphs):
<script type=module src=entry_1></script>
<script type=module src=entry_2></script>

Most of these comments ignore this fact and assume a single entry point.
In addition ESM needs to integrate against NCJS (Node CommonJS). ESM is not and was not intended to be an isolated system. Node will not ship ESM if it cannot interoperate with NCJS in some sane way.
Also note that some of the complaints here are based upon tradeoffs around the syntax of this. It was chosen to avoid being passed around to the wrong context like a first class function causing ambiguity. It was chosen since it is a keyword and is safe to extend grammatically even with ASI. It was chosen since it does not collide with import declarations which cannot have ( immediately after import. It was chosen because it needs special host environment information. All of these are required even if it only accepted static specifiers.

There are no known grammatical ambiguities.

import() is not a keyword: none of the existing keywords have function semantics (typeof is quite commonly used as typeof(X) but its usage is actually typeof X)
import() is not a function: it looks like a function, it behaves like a function, it cannot be used in contexts where a function is expected

Yes. There is grammatical ambiguity

No grammatical collision, this is not true, same as new.target is not a problem

This is not new.target. import.async would not be a problem either
It reuses existing keyword (import) and overloads this with entirely new semantics and syntax

Modules are always this way (i.e. context-sensitive)

I refer to the usage and syntax of the new ambiguous import

whatwg-loader is not intended to be shipped currently to browser in favor of type=module and the node ep.

Why, then, is it referred to in the proposal Readme and in this issue?

Yes, same as import declaration inner workings which will not be 100% compatible between the web and node.

There's not just node. "Implementation-specific" is one the worst possible errors to be left around in the specification

Also note that some of the complaints here are based upon tradeoffs around the syntax of this. It was chosen to avoid being passed around to the wrong context like a first class function causing ambiguity.

Hence, you selected a syntax which is ambiguous (looks like a function call, behaves like a function call, is not a function call)

import() is not a keyword: none of the existing keywords have function semantics (typeof is quite commonly used as typeof(X) but its usage is actually typeof X)

Unrelated?

import() is not a function: it looks like a function, it behaves like a function, it cannot be used in contexts where a function is expected

Same could be pointed out about meta-properties.

Yes. There is grammatical ambiguity

No, according to the specification. This is a statement that needs to be backed up by a grammar production.

This is not new.target. import.async would not be a problem either
It reuses existing keyword (import) and overloads this with entirely new semantics and syntax

import.async

Would also not be allowed to be a first class function due to contextual ambiguity when passed around.

It reuses existing keyword (import)

Valid, see new.target again.

new semantics and syntax

Yes, thats what syntax does.

There's not just node. "Implementation-specific" is one the worst possible errors to be left around in the specification

Modules are implementation specific. Different constraints in different environments. JS has one of the most diverse ecosystems as well that would not allow for 100% interop. Stating truth > trying to assert falsehood and not having any compatibility due to lack of implementation.

Please back up with specification/implementation problems and not opinions.

Case in point for ambiguity. Example provided by @domenic here: https://github.com/tc39/proposal-dynamic-import/issues/17#issuecomment-258561737

import((() => { throw new Error(); })()).then(() => { });

should behave the same as
const arg = (() => { throw new Error(); })();
import(arg).then(() => { });

... I can see how it's a bit different for a syntactic form, but I think we should treat it more like a function than not.

^ this is clearly a function call. Emphasis mine.

this is clearly a function call.

No, it clearly uses parenthesis and produces a completion value. Similar to how super() is not a function even though it uses parenthesis.

@bmeck Grammar will be read and used primarily by people, not by machines
No matter how many times you say that "grammar is unambiguous, because specification" it is ambiguous to the human. And this is the most important type of ambiguity.
As is overloading keywords with new syntax and semantics

This is clearly #23 and other issues all over again.
I give up. Do whatever you want.

@dmitriid disagree.

Grammar will be read and used primarily by people, not by machines

anecdotal / existential fallacy

No matter how many times you say that "grammar is unambiguous, because specification" it is ambiguous to the human. And this is the most important type of ambiguity.

I agree if there was ambiguity, this is just learning the grammar.

As is overloading keywords with new syntax and semantics

See meta-properties.

My 2 cents.
import(...) cannot be polyfilled, unless accessed each time via window.import(...) (or global?), so we are defining here yet another piece of the language that will make transpilers, and their bugs like we have already in class case for years now, mandatory, and for years to come.
Having a special module object though, exposed differently per module, with the ability to module.import(...).then(...), would be easier to provide for both NodeJS and browsers.
I've also already linked the working playground [1] that shows this scenario already happening, and with modules loaded via relative paths per each module, but I've been told this wasn't the right place for that so ... I hope I can at least provide what this implementation would look like in NodeJS:
// Module as module.constructor
Module.prototype.import = function (path) {
  return new Promise(res => res(this.require(path)));
};

That's it. Not only it's backward compatible with every module already available, all patterns desired in here would also work, like loading multiple modules:
module.exports = Promise.all([
  './awe',
  './some'
].map(
  m => module.import(m)
)).then(modules => {
  const [awe, some] = modules;
  return {awe, some};
});

Strawberry on top, it will automatically make it possible to export asynchronous modules too.
module.exports =
  module.import('./crypto')
    .then((crypto) => {
      // return the module to export
      return {
        sha256:(str, secret = '') =>
          crypto.createHmac('sha256', secret)
              .update(str)
              .digest('hex')
      };
  });

For the WebComponents era to come, this will also play absolutely nice:
module.exports = customElements.whenDefined('comp-name').then(() => {
  const CompName = customElements.get('comp-name');
  class SubCompName extends CompName {}
  customElements.define('sub-comp-name', SubCompName);
  return SubCompName;
});

Same kind of export would work well in NodeJS for modules that perform DB connections and similar operations.
Today most modules return synchronously operations that will be possible to perform only asynchronously so that having module.import(...) on backend seems to be like a win for everyone.
On the front end, there won't be the need to even think about specifying a require like function, just module with an import method that does exactly what this proposal does, plus eventually the ability to define exports through the same object (but this is probably less important)
Best Regards
[1] https://github.com/tc39/proposal-dynamic-import/issues/36

If you encounter some new syntax what's the first thing you do? For me, search new.target mdn or something similar. The same would be true for import(). I don't think I buy the ambiguity argument at all. For example I would expect a JS programmer to know what's going on here:
``javascript
!function foo() {
...
}();
But also that you cannot do this:
```javascript
function foo() {
...
}()

I think it's fair to expect developers and unerstand (without great difficulty) that similar syntactic forms have different semantics depending on where they are in the code.

My opinion is "just leave import along, you people".
Dynamic module loading should definitely be supported in the language but it should be an "advanced" feature, like ES6+, and nobody should be obliged to implement this.
It could be checked like if (Module.import) { ... }.

unfortunately that's not the most wise advice, if you consider everything I've written in the NodeJS proposal:
https://github.com/WebReflection/node-eps/blob/master/XXX-module-import.md
Specifically, you might be interested in the following paragraphs:
Why as core feature ? Why not transpilers ?
Why not as global function ?
Why polluting module and not require ?

@halt-hammerzeit "ES6+" includes ES2016, ES2017, and all future specs, which everyone is required to implement - there's no "advanced" or "optional" stuff besides Annex B, which exists solely to document optional and legacy behaviors for web compatibility.

Actually, on second thought, my idea is that the import word is not suitable here at all.
import is a symbol of the new (and very elegant) explicit static module interconnection.
It is what it means — "import", like:
import { printing_press, hydraulic_pump } from 'germany'
import { potato, crops } from 'ukraine'

I.e. it's very essense is that something (a part) is imported from somewhere.
And for the hypothetic import() stuff I'd rather suggest good old eval(), because it's semantically very different from what import is really meant to be: import is really meant to be a means of explicitly declaring dependencies, it's a kind of bureaucracy measure to fight all that require() chaos, and it turned out to be a very elegant and effective one (e.g. tree-shaking).
So the import() being proposed is whole another concept with whose another purpose and it should rather be something like Module.eval() or better Module.load().

"import" means "import". In no way does it mean "static" or "synchronous", and import('somewhere').then(something => { … }) is importing something from somewhere just the same conceptual way import something from 'somewhere'; is.
The fact that "methods of async loading" already exist on every platform means that tree-shaking already has to account for this and will have to do so forever - this proposal has zero impact on tree-shaking except perhaps by making it easier, by creating a syntactic way to identify and analyze dynamic imports.

@halt-hammerzeit the concept is the same because the module can be the same, either you use import * or import() to load the external module, it would still be the same.
Accordingly, there's no need to create confusion with the terminology because no matter if you import something synchronous or asynchronous, you are importing the exact same thing.
However, I kinda agree import(), in the apparently global scope (it's not!), and looking apparently like a function (it's not!), would confuse many developers while module, since the parallel proposal is to have <script type="module"> to load asynchronously on the Web, is a concept everyone can easily recognize as a variable that could be unique per module, just because that's what everyone know in the already popular NodeJS/CommonJS land: less to explain, and a method name that reflects what staic import declaration would similarly do: import the module.
As summary, in my opinion, module.import(path).then(...) is the best moving forward, backward compatible, future friendly way we have today to define such dynamic method.

@ljharb @WebReflection My point is that import means importing an explicitly defined part of something, not "just import everything".
If it was "just import everything" then there would be no point in introducing import at all — good old require() would perfectly do.
The whole point of introducing import and dropping require() is to embrace developers put more thought into how exactly their code is interconnected, and to make them optimise their code better, to make them understand their own code better, to teach them writing higher quality code.
I find things like import * from 'module' and import module from 'module' very pointless and defeating the whole purpose of introducing this whole importing module system.
The only reason for import module from 'module' to exist is for tiny modules only, i.e. when modules are so tiny that they physically can't export more than one dependency, and not for the cases when developers abuse this feature and import huge pieces of code like they used to back in the old require() days.

@halt-hammerzeit you absolutely can import everything, that's what import * as everything from 'anywhere' is for. Your claims about "the whole point" aren't accurate.

@ljharb If you can do something absolutely doesn't mean that it's meant to be done that way. It could as well mean "okay, we'll let you have this possibility for now as you transition your mind from your old mindset to the new one".

@dmitriid You seem to be arguing that the spec is confusing. This is a valid concern, but it's different from being ambiguous (i.e. allowing code that has multiple different correct parses). I think this distinction is causing some of the misunderstanding in this thread.

@not-an-aardvark Yes, confusing is a better term, thank you
The best part though? A horrible design decision is justified by examples of other horrible design decisions. To wit, new.target and !function{}()

@halt-hammerzeit beside what @ljharb said, the Web case and its runtime, on-demand needs cannot be ignored.
Luckily, you have all the syntax you want to explicit the part of a module you want to import
import * from './module';
import('module').then(module => {});

import bit, baz from './module';
import('module').then(({bit, baz}) => {});

Isn't arguments destructuring one of the best things we have these days?
Best Regards

Closing this since, as people have explained a few times, it's not related to the proposal, but to non-standard ways of turning modules into non-modules, which are outside the scope of the language.

To be honest I fail to see how an issue titled ""Tradeoffs" or "risks" section to the proposal?" can be "not related to the proposal". The list in the initial post is preceded by "for example" to indicate that it's just a list, not the list of downsides.
At this point the spec looks as if the decision is a no-brainer. Is it intended, @domenic?

How about "Benefits" and "pancakes"?

@jhabdas this is a very non-productive reply. "Risks", "tradeoffs" or "drawbacks" is a usual part of proposal in a lot of languages, see some examples from Rust ("drawbacks" and "alternatives"), Java ("risks and assumptions"), and Python ("pros and cons"). It's not like I'm pulling the issue out of thin air.

Thanks for the feedback @si14. I do believe this issue was closed already ;)

@jhabdas can I ask you to refrain from non-productive passive-agressive replies? You aren't helping no one with that.

You can ask. Or you could just open a new issue.

@si14  It's not relevant to the proposal because these criticisms exist with or without dynamic imports. As stated before, you can already dynamically import modules in browsers by inserting module scripts into the page. This proposal doesn't add new capabilities, so adding "Tradeoffs" section doesn't make sense.  Enjoy your JS monstrosity

suksma

Since this thread has pretty clearly degenerated, and no new information is being added, it seems best to lock it at this point.

@matthewp I believe there is a great deal of confusion between the original issue (there is no "official" consideration of downsides as in e.g. PEPs, JEPs and Rust's RFCs) and some concerns themselves. Given that this issue became an outlet for a great deal of frustration, it's very probable that a section to address potential downsides is apt.


UID 1000 not found in arch when trying to start  kde-desktop on trusty

Everytime now that i install kubuntu desktop on trusty it always give me this error "UID 1000 not found in arch" and i just don't know why because the chroot has been fully completed and i have updated it like 5 times, could it be that I'm using an samsung chromebook with ARM instead of Intel because i did notice it said at the top that Xephyr no longer works with freon anymore. Anybody have any solutions or explaination of some kind?

localhost Downloads # enter-chroot -n trusty -u root
Entering /mnt/stateful_partition/crouton/chroots/trusty...
(trusty)root@localhost:~# id
uid=0(root) gid=0(root) groups=0(root)
(trusty)root@localhost:~#
This is what i get

Well it's definitely assigned your uid to 1000, it may be a problem with ARM but I haven't seen the error -
"UID 1000 not found in arch" reported by anyone else.
Guess the guru's will have to address this one - sorry...

Can you post the output of the command that has that line?


[GSSOC'23] Toggling between dark and light mode correctly

When we switch for the light mode from dark mode only the color of navbar changes but footer still remains the same.

Heyy pls submit your PR soon otherwise will assign it to someone else!

Can I work on this?

Yes @Shalini469717 you can..
Submit your PR soon!

seems like the issue is fixed


Do not export Web.Scotty.Internal.Types ?

It's an internal module, most of its interesting functionality is re-exported by .Trans and .Scotty, and some invariants would be better served by not offering the constructors to the users.

In general I prefer to keep internal modules. Internal modules provide a mean to complement features missing in the library.


Easier navigation between different databases.

Describe your feature request
Currently to switch between databases you have to open the connection settings and manually type in the name of the database you would like to view. I propose an accordion style view to:

See the list of all databases for a namespace
Easily switch between them similar to how we have the tables on the left pane and can switch between them.

This makes working with multiple databases a lot easier especially when the names are not easy to remember (In my case each database is named based on the uuid of an entry in a central database so to get to a db I would first look up the id of the db in a table inside my admin db and then enter that id in the connection field)
I also think this feature could be extended to namespaces as well.
Are you willing to contribute this feature?
Yes
The command INFO FOR NAMESPACE returns the names of each database inside a namespace so it would be very simple to display this as a list or a dropdown
For namespaces INFO FOR KV returns the list of namespaces so a similar thing could be applied there as well.

Great idea! This would indeed be a nice addition. We'd probably want to use <Autocomplete /> to continue allowing any name to be filled in
If you'd be willing to work on a PR for this that would be great!

I'd be happy to work on this but I won't be free to work on this for at least another week.

Hey @bibaswan-bhawal, just checking in, are you still planning on implementing this change?

Closing due to lack of activity


wins.exe does not work on nanoserver

Command wins cli net get failed with error:
FATA[2020-11-14T13:09:42+03:00] rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing open \\\\.\\pipe\\rancher_wins: Access is denied."

when it run on nanoserver as ContainerUser.
It works fine when it run on servercore or on nanoserver as ContainerAdministrator.

This is not a wins.exe issue. Windows containers doesn't support named pipes mounting when it runs as ContainerUser.


Add to jenkins.dataverse.org

https://jenkins.dataverse.org is a new service being offered to the Dataverse community for automated testing, continuous integration and perhaps any other use you can dream up. 😄
For more about this Jenkins service, please see http://guides.dataverse.org/en/4.14/developers/testing.html#continuous-integration
I'm very glad to see that Travis tests are already set up for pyDataverse at https://travis-ci.com/AUSSDA/pyDataverse
I am not suggesting that we replace Travis with Jenkins. Rather, I'm suggesting a "belt and suspenders" approach. In fact, for Dataverse itself we are currently using Travis to know if our Java code even compiles (and if the unit tests pass) and Jenkins to know if our API test suite is passing.
The way to add pyDataverse is to talk to me and @donsizemore at http://chat.dataverse.org (we're both in the eastern timezone of the United States and don't work weekends 😛 ). We'll get the test suite passing (with help from @skasberger probably) and then add it as a job to https://github.com/IQSS/dataverse-jenkins . Actually, once I talk to Don I'll probably create an issue over in that issue tracker for adding the job definition (XML, I believe).

A job has been set up at https://jenkins.dataverse.org but the config hasn't been added to the dataverse-jenkins repo so I just opened https://github.com/IQSS/dataverse-jenkins/issues/12

Thanks @pdurbin. As we now have our own Jenkins instance at AUSSDA, I will do this there.


Tried to initialize from a previous compilation (build/app.dill.track.dill), but the file was not self-contained. This might be a bug.

Error:
initialize_from.dill.gz
Launching lib\main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...
Resolving dependencies...
Running Gradle task 'assembleDebug'...
Compiler message:
Warning: Tried to initialize from a previous compilation (build/app.dill.track.dill), but the file was not self-contained. This might be a bug.
The Dart team would greatly appreciate it if you would take a moment to report this problem at http://dartbug.com/new.
If you are comfortable with it, it would improve the chances of fixing any bug if you included the file file:///C:/Users/Hoornet/AppData/Local/Temp/initialize_from.dill4d6cba12-8c52-11e9-8f4f-b42e99307704/initialize_from.dill.gz in your error report, but be aware that this file includes your source code.
Either way, you should probably delete the file so it doesn't use unnecessary disk space.
Built build\app\outputs\apk\debug\app-debug.apk.
Installing build\app\outputs\apk\app.apk...
Syncing files to device Android SDK built for x86...
E/eglCodecCommon( 5347): glUtilsParamSize: unknow param 0x000082da
I/Choreographer( 5347): Skipped 78 frames!  The application may be doing too much work on its main thread.
D/EGL_emulation( 5347): eglMakeCurrent: 0xe6105f00: ver 3 1 (tinfo 0xcfe3be00)
I/OpenGLRenderer( 5347): Davey! duration=1350ms; Flags=1, IntendedVsync=558726268564, Vsync=560026268512, OldestInputEvent=9223372036854775807, NewestInputEvent=0, HandleInputStart=560031295900, AnimationStart=560031354100, PerformTraversalsStart=560031387400, DrawStart=560039524900, SyncQueued=560040651300, SyncStart=560042929800, IssueDrawCommandsStart=560043132200, SwapBuffers=560060515600, FrameCompleted=560078903000, DequeueBufferDuration=8774000, QueueBufferDuration=200000,
D/EGL_emulation( 5347): eglMakeCurrent: 0xebe5ce80: ver 3 1 (tinfo 0xe4693c60)

C:\DEV\flutter\bin\flutter.bat doctor --verbose
[√] Flutter (Channel beta, v1.6.3, on Microsoft Windows [Version 10.0.17763.529], locale en-US)
• Flutter version 1.6.3 at C:\DEV\flutter
• Framework revision bc7bc94083 (3 weeks ago), 2019-05-23 10:29:07 -0700
• Engine revision 8dc3a4cde2
• Dart version 2.3.2 (build 2.3.2-dev.0.0 e3edfd36b2)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\Hoornet\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[√] Android Studio (version 3.4)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 36.0.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[√] IntelliJ IDEA Community Edition (version 2019.1)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA
• Flutter plugin version 36.0.4
• Dart plugin version 191.7479.14
[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
• IntelliJ at E:\Program Files\JetBrains\IntelliJ IDEA 2019.1.1
• Flutter plugin version 35.3.3
• Dart plugin version 191.7221
[√] VS Code (version 1.33.1)
• VS Code at C:\Users\Hoornet\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.0.1
[√] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

Thanks! We see a lot of these reports. Closing as a dup of https://github.com/dart-lang/sdk/issues/36032.


Added SQL Quiz Question

Summary of changes
Added SQL Quiz Question in #17 Please Merge as soon as possible

Checklist

[✓] I have read and followed the contribution guidelines.
[✓] I have read through the Code of Conduct and agree to abide by the rules.
[✓] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[✓] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[✓] I have provided a summary of my changes.

closes #XXXXX

@jdwilkin4 please merge this pr

Please do not ping maintainers for reviews.
The team will get to reviews when time permits.
Thank you for understanding


Provide a hi or mark element

For a very long time, Yelp has supported the hi element in the experimental namespace. This is an inline element that highlights the text with a yellow background. It's useful to show what's new when progressively building on a code sample, for example.
This is a simple element to implement and doesn't obviously fit into any other extension, so we should just add it to the Mallard core. It's similar to the HTML mark element, so maybe it should be named mark. We should recommend style hints for "added" and "deleted" and maybe other common reasons to highlight text.

:+1:

http://projectmallard.org/mep/mep0009.html


Regression - JavaScript false positive errors ("Expression expected.")

VSCode Version: 1.41.0
OS Version: Windows 10

Steps to Reproduce:
<script type="text/javascript">
intVar = <?php echo $someInt; ?>;
someFunction(someArray[<?php echo $someInt; ?>]);
</script>

The first JS line will show error "Expression expected.".
The second JS line will show "An element access expression should take an argument.".
I suppose the JavaScript lint is stripping out the PHP elements before parsing, but in fact, those PHP elements are putting contents where the lint expects them to be.

Is this with the built-in HTML language support?
We don't support PHP in HTML documents. If it once happen to work, that was just a lucky coincidence.
Instead you have to open the file in PHP mode and have a PHP extension that adds richer language support.
Or you can disable JavaScript validation in HTML, if you want to continue with it like that.

Why is this closed?
The file extension is .php and the parsing language in VSCode is PHP.
Why wouldn't you support PHP tags in the middle of HTML? That's very common in many projects... not everyone uses templates like Twig.

Ah, ok, you are in PHP mode and you are using a PHP extension. You need to file this against the PHP extension you use. VSCode has no rich PHP language support out-of-the-box.

The PHP extensions I use are not giving any errors.
It is the built-in JS validator of VSCode that is complaining about invalid JS, in the lines similar to the above.
Do you still think this is something that the PHP extensions need to fix?

The HTML and/or JS support are only enabled if the editor language mode is HTML or JS.

Here's what I see when I try your example:

This is probably https://github.com/bmewburn/vscode-intelephense/issues/836

Thank you very much.
I raised bmewburn/vscode-intelephense#903 after I saw this error went away when disabling PHP Intelephense.
Oh - I see now it's a duplicate. Thanks for pointing that out, @bmewburn


Update scalafmt-core to 2.7.5

Updates org.scalameta:scalafmt-core from 2.7.4 to 2.7.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #140 (b8a186b) into master (3fcc169) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   57.83%   57.83%
=======================================
  Files          20       20
  Lines         287      287
  Branches        4        4
=======================================
  Hits          166      166
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcc169...b8a186b. Read the comment docs.


Last seen update for MySQL storage backend

Create a last_seen_at column in the MySQL schema and update it (nearly) every time the client talks to us.

Note there's a few edge cases where we can't update the last seen column. Notably because Declarative Management isn't "in scope" for the server the storage layer has no methods for it and thus if the client tries to talk to us there the storage will be none of the wiser. This is the case in the NanoMDM storage. That said the "important" beats of enrollment and command result storage & retrieval are covered (which includes Idle responses to pushes and are likely the only actual thing we care about).


Mistake in ESP8266 D1 mini pinout diagram

In the Top 5 mistakes page is a pinout diagram for the ESP8266 D1 mini (2nd image).
In there, pin D4 is labled GPIO 3, just like RX pin.
To my knowledge, it is actually GPIO 2.

Please tag @wled-faq


An error occurs when executing the withdraw method

An error is reported when running the withdraw method. The error message is: failed: no Sminer.Withdraw event found. What does this error mean?

@LINJINTIANDE If the xxx.xxx event is not found, it means that the transaction failed. You can check it in the block browser by printing the block hash value.


convert support_iam_role_principal_arn to a list

allows assigning multiple users to the role
allows passing an empty list, making the variable optional, closes:
https://github.com/nozaq/terraform-aws-secure-baseline/issues/75

@nozaq ping, any feedback?
We have more changes in the pipeline, and for now forked the module and pushing there, but we would like to also push upstream.
Thank you.

@george-angel
Sorry for taking a while to respond, and thank you for the suggestion. :)
The patch looks good to me!


feat: chain adapter errors

Description
Update chain adapters errors to include translations for more descriptive errors related to failed transactions.
PS. in retrospect, I regret the error message changes, but here we are...
Issue (if applicable)

closes https://github.com/shapeshift/web/issues/8117
Risk

High Risk PRs Require 2 approvals

Low - updated error type and surface, no inherent logic changes

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Ensure error states are displayed correctly in the failed to send transaction toast

Easiest test case is send to sanctioned address

Ensure you can copy error from toast

Engineering

hide whitespace changes
:point_up:
Operations

[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

:point_up:
Screenshots (if applicable)
note screenshots were taken before adding the copy button

Why are you regretting all the message changes? It's very clean now

Why are you regretting all the message changes? It's very clean now

Ha, I agree from a code cleanliness standpoint, just ended up being more files touched that initially intended with the tests and was feeling bad for whoever had to review them all

❌ Copy button is displayed even if we have no addresses and it copies the error content:
It's not very practical, even though it's not critical, I think this is not the intent, happy to discuss it if the lift is too big but I don't feel like approving as it is before any discussions

see: https://github.com/shapeshift/web/pull/8155#discussion_r1852437077. I will run it by product for confirmation

Even though it's a bit weird to copy the whole error text, IIRC it's primarily for testing and support. Faster identification of a users actual issue.


What are the limits for custom event attributes?

I found this FAQ that mentions some pretty scary limits: https://aws.amazon.com/pinpoint/faqs/

You can have up to 1,500 unique custom event types per app and up to 40 attributes and metrics per custom event.

Amazon Pinpoint provides 40 custom attributes. You can use these to customize your segmentation for your unique use cases. Each custom attribute can store up to 50 values.

I was planning to structure my events like this:
The event will be called "tap" or "view" or "swipe" or "scroll" - basically, a simple user action, there are only so many actions a user can do, so I will not get anywhere close to 1500 events.
Then I would use attributes like this: viewName: "ShopGridView", componentName: "Product", objectId: 123
I would not need more than 40 custom attributes, I think, but the thing that I don't understand is the 50 values per attribute. If wanted to store the objectIds or my userIDs in the attributes but I have thousands of products and thousands of users, does it mean, I can't store that kind of information in my events??
Or in simpler terms, lets say I just want to track what views my users navigate to, just like Google Analytics tracks pageviews, but since I have thousands of products, I basically have thousands of views, is there no way that I can track exactly which view a user clicked into? If I can just track "user visited a product detail view", that's not really good enough information, is it?
Would I have to store my objectIds as metrics, maybe? Would those not be limited?

@mbrochh I guess the custom attributes in that faqs means the user attributes for the endpoint. https://aws.github.io/aws-amplify/media/analytics_guide#update-user-attributes
Confirming with the Pinpoint team.

@mbrochh Confirmed. That limit is just for the user attributes of the pinpoint endpoint.


Style State Management Demo page

Part of the efforts for https://github.com/open-truss/open-truss/pull/114
Currently

Current state

Closing as complete


NavigationBarView not working properly

Hi, i'm trying to use NavigationBarView on UITableViewController. But somehow it looks like this

Hi @tengis Would you be able to share the code you are using to setup the NavigationBarView?

@danieldahan Wow that was quick  :+1:
   let navigationBarView: NavigationBarView = NavigationBarView()

    // Stylize.
    navigationBarView.backgroundColor = MaterialColor.indigo.darken1

    // To lighten the status bar add the "View controller-based status bar appearance = NO"
    // to your info.plist file and set the following property.
    navigationBarView.statusBarStyle = .LightContent

    // Title label.
    let titleLabel: UILabel = UILabel()
    titleLabel.text = "MaterialKit"
    titleLabel.textAlignment = .Left
    titleLabel.textColor = MaterialColor.white
    titleLabel.font = RobotoFont.regularWithSize(20)
    navigationBarView.titleLabel = titleLabel
    navigationBarView.titleLabelInsetsRef.left = 64

    // Detail label
    let detailLabel: UILabel = UILabel()
    detailLabel.text = "Build Beautiful Software"
    detailLabel.textAlignment = .Left
    detailLabel.textColor = MaterialColor.white
    detailLabel.font = RobotoFont.regularWithSize(12)
    navigationBarView.detailLabel = detailLabel
    navigationBarView.detailLabelInsetsRef.left = 64

    // Menu button.
    let img1: UIImage? = UIImage(named: "ic_menu_white")
    let btn1: FlatButton = FlatButton()
    btn1.pulseColor = MaterialColor.white
    btn1.pulseFill = true
    btn1.pulseScale = false
    btn1.setImage(img1, forState: .Normal)
    btn1.setImage(img1, forState: .Highlighted)

    // Star button.
    let img2: UIImage? = UIImage(named: "ic_star_white")
    let btn2: FlatButton = FlatButton()
    btn2.pulseColor = MaterialColor.white
    btn2.pulseFill = true
    btn2.pulseScale = false
    btn2.setImage(img2, forState: .Normal)
    btn2.setImage(img2, forState: .Highlighted)

    // Search button.
    let img3: UIImage? = UIImage(named: "ic_search_white")
    let btn3: FlatButton = FlatButton()
    btn3.pulseColor = MaterialColor.white
    btn3.pulseFill = true
    btn3.pulseScale = false
    btn3.setImage(img3, forState: .Normal)
    btn3.setImage(img3, forState: .Highlighted)

    // Add buttons to left side.
    navigationBarView.leftButtons = [btn1]

    // Add buttons to right side.
    navigationBarView.rightButtons = [btn2, btn3]

    // To support orientation changes, use MaterialLayout.
    view.addSubview(navigationBarView)
    navigationBarView.translatesAutoresizingMaskIntoConstraints = false
    MaterialLayout.alignFromTop(view, child: navigationBarView)
    MaterialLayout.alignToParentHorizontally(view, child: navigationBarView)
    MaterialLayout.height(view, child: navigationBarView, height: 70)

i tried add this line under the MaterialLayout.height function
MaterialLayout.width(view, child: navigationBarView, width: view.frame.width)
but still looks bit wrong also after rotate screen still same as first comment

The MaterialLayout.width line would conflict with the MaterialLayout.alignToParentHorizontally(view, child: navigationBarView) line.
It looks like you are using the code directly from the example.
Hmmm... nothing screams issue here. When are you calling this setup code? Also, are you using the latest? 1.25.8?

yes i'm using latest version. pod 'MK', '~> 1.25.8'

Can you remove all code after this line view.addSubview(navigationBarView).
That should size the NavigationBarView to your screen width x 70 px. I think you want to support rotation, so we wont use this solution in the end, but I want to see that it draws correctly and we are eliminating variables.

yeah without those lines working properly

That is good. If you want to support rotation, you will want the previous lines there. What those lines are basically saying is stretch to the parent view horizontally and set the height to 70. This then leads to the TableViewController's view bounds. Is the tableview being spread across the screen width completely?

yes. so after that now my navbar moving when i scroll the page

Sorry, I don't fully understand what you meant. When you scroll the TableViewController the navbar is moving with it? Did you set the MaterialLayout values back? Is the "yes" for my previous question that you confirmed the TableViewController is set to the width of the screen's dimensions?

If you would like, you can send a sample project over to<EMAIL_ADDRESS>and I will take a look, rather than the back and forth questions. If that is easier.

Sorry. i didn't add those lines back. moving like this. https://www.dropbox.com/s/8n8jptq1ucaau40/screenshot.mov?dl=0

I would have to see what is going on. My immediate suggestion is to use a normal ViewController and set the NavigationBarView as a child of that view, then add a tableView to that controller as well.

okay. i see. thanks for your quick response it was great help :+1:

Anytime :)


Scale factor for Matterport 2D depth scans

Hello~
Thank you for the clean codebase, and amazing work.
I downloaded the preprocessed Matterport 2D scans that have been provided by you in the README.md. But when I checked out the depth image pixel values (for an arbitrary sequence), they are integers ranging from 0 to a some thousands. What scale do these numbers belong to? I have usually worked with depth images in floating point meters.
Sorry if I am asking something obvious !
Thanks in advance~

I found it in feature fusion scripts... Sorry


Adding update to KF 1.0 installation instructions on OCP

This PR is to add an OWNERS file to Openshift installation pages and to update instructions to KF 1.0.

@nakfour The problem with the PR is explained in the error message
https://github.com/kubeflow/website/pull/2107#issuecomment-671593299
Everyone listed in an OWNERs file must already be a member of the Kubeflow GitHub org.
My suggestion would be to add as approvers existing folks working on openshift e.g. @animeshsingh @vpavlin etc... who are already as approvers. That way they can approve this and other PRs.
Separately you can look into becoming a member of the org and once that happens open up a PR to add yourself to the OWNERs file.

The content of this lgtm.

/ok-to-test

/approve

/assign @bobgy

/lgtm

Thanks @nakfour
We are also working on getting the Kubeflow Operator exposed in OCP catalog, and will append the instructions once its made available there.
/lgtm
/approve

@jlewi would the "out of date" banner still stay even though we updated the docs? What is the process to get the banner deleted?

@nakfour the banner is in *.md files, when you finish updating a file, you can remove that banner in the same PR

@Bobgy this PR has merged, I will open a new one thanks


[UI]: Players always win

If you lose a game, the popup still displays "you have won the game" message

Fixed in bc2f97e.


Last Value in Stream, waiting to be pushed

@nathanielc had explained Kapacitor stream behavior as -
That last value is not skipped its just still sitting in the window waiting to be pushed out by then next point behind it.    from https://github.com/influxdata/kapacitor/issues/221
you have mentioned, implementing flush is feasible for valid use case.
1/  logparser  :  using logparser to push only ERROR messages in Influx, tick job expected to raise an alert on each measurement on STREAM as "logparser" inserting only ERROR lines.
since, each line in log file is not an ERROR message i.e. data is not being inserted every seconds or 10S window,
TICK script is raising alert on previous LAST Message only when next point arrives. This is delaying  alerting on LAST message sitting on Window.
Please suggest how can we achieve this  ?  Is there any other way alerts can be trigger

Is there a way to create a default stream (don't confuse with default field) with an "every" property so the problem in the issue could be addressed by combining two: an actual windowed stream and a default (tick?) stream?

@pawan4work FYI, I ended up with applying WhereNode after the WindowNode so it always has data points to check the time from. Hope that helps.

@voroninman yeah, this work around am using where ever possible. But case where you are relying on LAST value in stream it won't work. Either some force flush kind of mechanism will help to handle such cases.
e.g.

InfluxOut writing data in some measurement and alerts on other script based on that last entered record in measurement

'exec' plug-in insert some last failed results, it won't be get captured in TICK script until plug-in insert additional two or more failures status.

@pawan4work can BarrierNode help you in this case? idle method "pushes" pipeline on idle time since the last received message.


In IOS only, Firebase Core error: No implementation found for method Firebase#initializeCore on channel plugins.flutter.io/firebase_core

My case
I have native IOS and native Android project separately
Required to add flutter module in IOS project
Create button in IOS project and call flutter module.
I have situation to use cloud firebase in flutter module
so I adding required firebase plugin dependency in pubspec.yaml (eg. firebase_core, cloud_firebase)
Add 'await Firebase.initializeApp()' in my flutter main function.
When I run my application and It calling flutter main, then this issue arise 'No implementation found for method Firebase#initializeCore on channel plugins.flutter.io/firebase_core'
**IOS Project calling function like**
FlutterViewController* flutterViewController =
[[FlutterViewController alloc] initWithProject:nil
initialRoute:routeStr
nibName:nil
bundle:nil
];
flutterViewController.modalPresentationStyle = UIModalPresentationCustom;
[self presentViewController:flutterViewController animated:YES completion:nil];

**Flutter Main function**
Future main() async{
WidgetsFlutterBinding.ensureInitialized();
await Firebase.initializeApp();
runApp(MyAppState());
}

So need a solution for my case, but In Android project it is working fine

@YuvarajaCPR
Can you provide flutter doctor -v, pubspec.yaml and a complete minimal code sample that we can directly use to verify this issue ? or you may create a demo app (that replicates the issue), push it to github and share repo link here that we can clone .
Thanks.

Flutter doctor
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-x64, locale en-GB)
• Flutter version 2.5.3 at /Users/yuvarajacpr/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (4 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/yuvarajacpr/Library/Android/sdk
• Platform android-31, build-tools 31.0.0
• ANDROID_HOME = /Users/yuvarajacpr/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.1, Build version 13A1030d
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.61.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.27.0
[✓] Connected device (2 available)
• SM J600G (mobile) • 520096ffc0c25517 • android-arm    • Android 10 (API 29)
• Chrome (web)      • chrome           • web-javascript • Google Chrome 95.0.4638.69
! Device emulator-5554 is offline.
! Error: iPhone is not connected. Xcode will continue when iPhone is connected. (code -13)
• No issues found!
pubspec.yaml
version: 1.0.0+1
environment:
sdk: ">=2.12.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^1.0.2
bubble: ^1.2.1
flutter_svg: ^0.21.0-nullsafety.0
get: ^4.3.8
dio: ^4.0.1
http: ^0.13.4
fluttertoast: ^8.0.8
firebase_core: ^1.8.0
intl: ^0.17.0
firebase_auth: ^3.1.4
cloud_firestore: ^2.5.4
cached_network_image:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^1.0.0
For information on the generic Dart part of this file, see the
following page: https://dart.dev/tools/pub/pubspec
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
module:
androidX: true
androidPackage: com.conferenceapp_flutter
iosBundleIdentifier: com.conferenceappFlutter

complete minimal code sample that we can directly use to verify this issue ? or you may create a demo app (that replicates the issue), push it to github and share repo link here that we can clone .

@YuvarajaCPR

**Github Link **
https://github.com/YuvarajaCPR/testfirebase.
Also use README.file in the project

@YuvarajaCPR
Cloned the repo and followed the instructions, but getting an error while running pod install:
### Error

RuntimeError - [Xcodeproj] Unknown object version.
/Library/Ruby/Gems/2.6.0/gems/xcodeproj-1.19.0/lib/xcodeproj/project.rb:227:in `initialize_from_file'

The error you are getting no implementation found, usually indicates that the method isn't registered before it can be called.
Can you try below steps and see if it works ?
rm -rf build
rm -rf Pods
rm -rf Podfile.lock
rm -rf ~/.pub-cache/hosted/pub.dartlang.org/
pod cache clean --all
flutter clean
flutter pub get
pod repo update
pod install

Above steps cannot work for me

Closing this as a duplicate of https://github.com/FirebaseExtended/flutterfire/issues/4455. Please follow-up in linked issue for further updates.


beaconscan mainnet is unavailable

The REACT_APP_BEACONSCAN_URL on the servers are set to

Mainnet: https://beaconscan.com/validator
Medalla: https://beaconscan.com/medalla/validator
Zinken: https://beaconscan.com/zinken/validator

However,

All these links are directing to Medalla now
Mainnet and Zinken services are unavailable

Proposal:

consider removing the beaconscan link now
when it's up, set something likeBEACONSCAN_URL = IS_MAINNET ? 'https://beaconscan.com/validator' : 'https://beaconscan.com/${ETH2_NETWORK_NAME}/validator'; so we can drop the REACT_APP_BEACONSCAN_URL.

also for BEACONCHAIN_URL

We are wrapping up medella and should hv the mainnet up this week. Thank you

It since https://beaconscan.com/ is the mainnet now! Congrats! 🚀
Closing this issue now.


Update input parser to support more currencies

Currently parseInput only supports US dollars when parsing strings. info function already supports identifying numerous other currencies. This PR adds support for parsing that list of currencies.
I have two test cases I added but wanted to discuss because I'm not necessarily sure what should be expected

This is good stuff! I'll merge and then have a go at fixing the weirdness with $$1234 before issuing a release.


plugin.cfg version did not increment

Just a tiny thing I noticed after reading (and internally sobbing) about .res incompatibility in Luis's Issue.
plugin.cfg has the line    :   version="0.0.1"
but I believe it should be :   version="0.1.0"
Your amazing Godotneers vid on saving & loading brought me here. Thank you!

The classic, thanks a lot for reporting this. I'll add a release check list and bump the version with the next release!


forbid-component-props : Allow whitelisting of prop values

Using "react/forbid-component-props" with default settings : [enabled, { "forbid": ['className'] }]
I'd like to refine the rule to forbid className only if it's used with a value that is outside of a whitelist.
Rule option
whitelist would be an array of strings, with the name of props value that are allowed :
whitelist : ['mt-0', 'mt-1', 'mt-2', 'mb-0', 'mb-1', 'mb-2']

The presence of a value would override any previous rules, thus, using the settings above :
The following patterns are considered warnings:
<Button className>

<Button className="bigButton">

<Button className="mt-0 bigButton">

The following patterns are not considered warnings:
<Button className="mt-0">

<Button className="mt-1 mb-1">

The goal here is to allow the use of a set of helpers classes, while forbidding exotic className usage on components.

This seems like the sort of thing you'd want to enforce using a combination of a custom prop name, and a PropTypes.oneOf check on the receiving component. I don't think this is something a linter should be checking; nor is it something it can check when the value isn't static.


Sdk 471 net use constants from cisco specification

Codecov Report

Merging #30 (1c02523) into main (acdec34) will increase coverage by 6.15%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   54.33%   60.48%   +6.15%
==========================================
  Files           6        7       +1
  Lines         173      205      +32
  Branches       15       19       +4
==========================================
+ Hits           94      124      +30
- Misses         73       74       +1
- Partials        6        7       +1

Impacted Files
Coverage Δ

Cisco.Otel.Distribution.Tracing/Utils.cs
85.71% <85.71%> (ø)

Cisco.Otel.Distribution.Tracing/CiscoOptions.cs
100.00% <100.00%> (ø)

...co.Otel.Distribution.Tracing/CiscoOptionsHelper.cs
80.00% <100.00%> (+3.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdec34...1c02523. Read the comment docs.


plan for 1.20.6

My server is 1.20.6 Can I ask for support?

ReplayMod itself is not supported for 1.20.6 so I physically cannot update the mod until they do. When it is released I will update the mod.
Even if I could I'm not sure how you would view/render the replays.


Setting color not displayed in editor in VS code

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.62.3
OS Version: Windows 10

Steps to Reproduce: I have done anything special. I just used  'npx create-react-app my-app --template typescript' to create the react app. Then the issue is there.
Issue:-
I am trying to customize the color of HTML tags in react (.tsx files). So, I included the code below in settings.json file.
"editor.tokenColorCustomizations": {
    "textMateRules": [
      // TextMate grammars tokenization settings
      {
        "name": "JSX tags",
        "scope": [
          "entity.name.tag", // HTML tags (in JSX)
          "entity.name.tag.html", // JSX Component tags
          "meta.tag",
          "meta.jsx"
        ],
        "settings": {
          "foreground": "#18da32"
        }
      }
    ]
  },

However, even after the settings is applied, the color does not change (the color should be like so

)
What is being displayed is a below

However, when I use the developer tools it shows the right Hex code but the color displayed is wrong!

The other tag is displayed correctly (the dark orange color)

I have a similar issue. I've customized syntax highlighting to easily distinguish between local and global vars, struct members, etc.
This doesn't work anymore. "textMateRules" is completely ignored as it seems. Simple rules (like "comments", "variables" besides "textMateRules") still work.

In the first screenshot, the cursor is after App and the token happens to be a whitespace character after the token. The title of the hover shows that: .  1 char. Because its a whitespace no color is seen.
If you set the cursor on App you see the scopes and you see on the last line that there's a coloring rule for support.class that wins.

A solution would be to add a coloring rule for match support.class after entity.name.tag: entity.name.tag support.class
  "editor.tokenColorCustomizations": {
    "textMateRules": [
      // TextMate grammars tokenization settings
      {
        "name": "JSX tags",
        "scope": [
          "entity.name.tag", // HTML tags (in JSX)
          "entity.name.tag support.class", // HTML tags (in JSX)
          "entity.name.tag.html", // JSX Component tags
          "meta.tag",
          "meta.jsx"
        ],
        "settings": {
          "foreground": "#18da32"
        }
      }
    ]
  },

@Dromantor If you use the Developer: Inspect editor tokens and scopes you can see where the color comes from. I suspect it's from the semantic highlighting which goes on top of syntax highlighting.
If that doesn't explain what you are seeing, can you file a new issue that contains the sample code?

@aeschli Thanks for the solution. It worked (i have put support.class.component instead of just support.class). When I checked with developer tools, I was selecting ass the letter ('App') and thought that was the the right selection. I now know that I have to put the cursor in the middle of the tag to get the correct reference. Thanks again.


(WIP)(GH-241) Honor tcp port

This PR fixes the logic that decides what port to connect to the LanguageServer on.
PR #272 needs to be merged first.

Needs a rebase

Needs a rebase

Closed in favor of #292, which does not have the merge conflicts this one does (which are a result of #272 being rebased and force pushed so much that they no longer have a common commit history)


merge package from arlac77/npm-package-template

package.json

chore(package): update<EMAIL_ADDRESS>

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #136   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c5070...d0ae430. Read the comment docs.

Coverage remained the same at 97.143% when pulling d0ae43027108d3578bd3bdaf0c19cb04aa2daf02 on template-sync-1 into 58c50700d733a90dc30a13fdb313cbaa202b8891 on master.


How to count resolutions/scales ? (unclear docs)

I have to project to EPSG:2180. My projection string looks like this:
+proj=tmerc +lat_0=0 +lon_0=19 +k=0.9993 +x_0=500000 +y_0=-5300000 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs

According to docs I should setup resolutions or scales. However, this is not clear for me how should I do it. I found somewhere that resolution should be count like this:
resolution = ScaleDenominator * PixelWidth

Is this correct ? Can we provide more clear docs on this topic ?

Resolution is the number of projected units per pixel (meters per pixel, in the case of EPSG:2180), scale is the same but inverted, so the number of pixels per meter.
You will have to get these numbers from your tile set.
I guess this could be included in the docs, but at the same time we do not want to include all info on how projections and maps work, since other resources do that better.


refactor(devtools-view): Refactor tree helper structure to reduce nested indentation

FluentUI's experimental Tree component is very strange. It requires setting up an outer Tree component context, which is really (semantically) a "Tree Context". Inside of this context, an actual tree is created using the TreeItem component (very unintuitive), and the inline contents of that tree (the "header") are specified via the TreeItemLayout component.
Because this is so counterintuitive, our current implementation introduces a lot of ultimately unneeded component hierarchy, which introduces a lot of unwanted and unpredictable indentation.
These changes are aimed at cleaning up that indentation, which it accomplishes by re-structuring our app tree. Since the setup is unintuitive, I went ahead and made our tree helpers an implementation detail of our data-visualization components directory. If we want to try and generalize this later, we can, but for now I am opting out of sharing.
This PR also:

Encapsulates node prop accepted by the various tree visualization components into a shared interface.
Adds @fluentui/react-components/unstable to an allow-list in the eslint config so we don't have to disable line-by-line.
Removes usages of nodeKind in user-facing visualization (this data is an implementation detail of the visualization tree format).
Adds labels to unknown data type tree nodes

In addition, both Private Container and Shared Container won't load, if I add aria-label to the <FluentTree> tag from DataObjectsView.tsx.

I think the representation of unknown-data and unknown-shared-object could be misleading when compared to the data (such as shared-text and shared-counter) which are stored in the same level within the rootMap.

When we first populate the rootMap, every key except the emoji-matrix and record-value are stored in same level, thus have a format of label (nodeTypeMetadata?): value pair. However, we represent unknown objects in the format of:

> label (nodeTypeMetadata?)

value

Since unknown nodes are not nested key-value pair inside the rootMap (for example record-value), I personally think it makes more sense to format like:

unknown-data: Unrecognized kind of data.
unknown-shared-object (mock-shared-object-type): Unrecognized kind of Fluid Object.

I might be missing something, so please feel free to share your thoughts 😃.

That's fair. I think you're right. I'll update them to put their content inline.

In addition, both Private Container and Shared Container won't load, if I add aria-label to the <FluentTree> tag from DataObjectsView.tsx.

@jikim-msft can you elaborate? I'm not sure what you mean.

https://react.fluentui.dev/?path=/docs/preview-components-tree-tree--default
As suggested in the official documentation, Tree must include either aria-label or aria-labelledby as its property for accessibility. I tried adding descriptions like ` to abide by the recommendation.

However, adding aria-label would crash the rendering of the container. Interested to know the reason.

Interesting. I was able to repro this as well. I suspect it's an ID uniqueness issue. I included the containerId value in the aria string to attempt to differentiate the two containers' data views, and that allowed one of them to render correctly, but not the other.

In addition, both Private Container and Shared Container won't load, if I add aria-label to the <FluentTree> tag from DataObjectsView.tsx.

@jikim-msft can you elaborate? I'm not sure what you mean.

https://react.fluentui.dev/?path=/docs/preview-components-tree-tree--default
As suggested in the official documentation, Tree must include either aria-label or aria-labelledby as its property for accessibility. I tried adding descriptions like to abide by the recommendation. ![image](https://user-images.githubusercontent.com/111468570/237815368-f7340966-0e4d-4a71-8b05-47184f4a3575.png) However, addingaria-label` would crash the rendering of the container. Interested to know the reason.

Interesting. I was able to repro this as well. I suspect it's an ID uniqueness issue. I included the containerId value in the aria string to attempt to differentiate the two containers' data views, and that allowed one of them to render correctly, but not the other.

@jikim-msft After merging in most recent main, I'm no longer seeing this issue. Are you still able to repro?

Visually looks good on my end; like Alejandro I will leave some structural/best approval for Ji.

In addition, both Private Container and Shared Container won't load, if I add aria-label to the <FluentTree> tag from DataObjectsView.tsx.

@jikim-msft can you elaborate? I'm not sure what you mean.

https://react.fluentui.dev/?path=/docs/preview-components-tree-tree--default
As suggested in the official documentation, Tree must include either aria-label or aria-labelledby as its property for accessibility. I tried adding descriptions like to abide by the recommendation. ![image](https://user-images.githubusercontent.com/111468570/237815368-f7340966-0e4d-4a71-8b05-47184f4a3575.png) However, addingaria-label` would crash the rendering of the container. Interested to know the reason.

Interesting. I was able to repro this as well. I suspect it's an ID uniqueness issue. I included the containerId value in the aria string to attempt to differentiate the two containers' data views, and that allowed one of them to render correctly, but not the other.

@jikim-msft After merging in most recent main, I'm no longer seeing this issue. Are you still able to repro?

Everything's working fine now! 😄 Thanks for the work Josh!


Multiple Tenants in where

https://github.com/HipsterJazzbo/Landlord/blob/master/src/Landlord.php#L93
here you are adding all tenants with id to the builder and the result should look like:
select * from ... where id=anton and id=lukas
and that cant work?!
I think it should be $builder->orwhere ...
Or am I wrong?

I think this is for when you have 2 different tenant columns in which case you would want andWhere. It is not for handling being a member of 2 different tenants which is not supported.

What @warksit said is correct. This package is for scoping to a single tenant of any given type.


Adds a clang_tidy_style target to allow clang-tidy to apply fixes inline

Note: This feature relies on the clang-apply-replacements executable, which should be
provided via a CMake variable: CLANGAPPLYREPLACEMENTS_EXECUTABLE.

Thanks @kennyweiss. When we have access to clang 15 compilers, we won't need this, correct?

While I'm adding this so axom to add braces around one-line if/while/for statements (via the readability-braces-around-statements rule), I think it is generally useful to help blt users apply clang-tidy fixes.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #1.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #1

This is failing due to dask-image having its dependencies mis-specified (it's missing setuptools_scm). It looks like it will be fixed in https://github.com/conda-forge/dask-image-feedstock/pull/24

I raised an issue in https://github.com/conda-forge/dask-image-feedstock/issues/25


Make sure we can create test USDT coins in the Docker image

Asked about this on StackExchange.

ERC20 implementation: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol
We probably need to compile it and then deploy it to our testnet.

Next goal: Deploy the binaries of the ERC20 smart contract


Create a container for all login

Describe the task
For all the login pages we can create a container and make a common pattern with slots. (Student has faqs which can be handled).

Acceptance Criteria

[ ] Create a common container for login pages like full-page-container.
[ ] Remove .sign-in-description class (no longer required)

Additional context
-

Devs please prioritize which Release its needed for or trash if duplicate or no longer needed

Defer to full-time release.


Plugin Collaboration

Hi @tadashi-aikawa!
I am the author of Obsidian autocomplete plugin.
First, thanks for this plugin, I am really happy that we are working to improve the typing speed of Obsidian with an autocomplete! I also like how you structured the plugin using the hint addon of CodeMirror and the current file word tokenization.
I have started the obsidian-autocomplete plugin at the beginning of this year with an urgent need: having an autocomplete plugin that supports LaTeX. So I've taken inspiration from the hint addon and made my custom implementation of it to learn better how it works and also to make a plugin that integrates better with Obsidian. In February, I've stopped the development since I had the university exams and started again a week ago by adding more autocomplete features.
Since we are both working on the same concept (autocomplete), and I have just discovered your plugin today, I wanted to ask you if you'd like to merge this plugin into one, to provide a faster, more powerful autocomplete. I know that working on a personal plugin is easier than collaborating, but I think it could be fun and constructive to merge both personal ideas into one project.
I'd like to hear from you what you think about this idea and I will accept whatever you choose.
Have a nice day!

Hi @Yeboster.
Thank you for your great suggestion! I agree with your opinion because I have developed my plugin to provide more efficiency with Obsidian users.😄
So I don't mind as follows.

Who and what plugin provides auto-complete features (It would be good to merge my implementation into your plugin or the new one)
How implements (ex. whether it uses CodeMirror Hints add-on or not)

Meanwhile, I think It is important for us to provide not only English but also other languages. We can because many Obsidian users would use their native languages (ex. I use Japanese). Thus I want to provide it upcoming.
If you could agree with my opinion, I want to collaborate with your autocomplete plugin!
I await a favorable reply from you.😉

Thanks for your kind response, @tadashi-aikawa. I am sure this collaboration can bring the most featureful autocomplete plugin ever made on Obsidian! As you suggested,  I've just added you as a collaborator of the autocomplete plugin 😄
I also agree with you that languages suggestions are a must, so I suggest this should be our focus:

Create a tokenizer for current file; since you've already done it, we could take this logic and put it into a Provider (I need to think how to trigger the analyser inside the provider)
Tokenize custom file (so the user can use a custom file)
Add language specific files in the plugin (so the user can activate them like dictionaries)

This is just a possible roadmap, feel free to give suggestions and prioritize other aspects. Also, what do you think we could use to track the roadmap ? Create an MD file, Trello or something else ?

Hi @Yeboster.
Thank you, and I have accepted your collaborator request! It's the first time as a collaborator, so please let me know I do it incorrectly. 👍
I almost agree with the roadmap you suggested. If I have to say something,

selectSuggestedTokens() might be use if prioritize sort logics are not implemented
Add Use WebWorker to improve performance (I think it to be a low priority because it is not a critical issue except for large text)

what do you think we could use to track the roadmap ? Create an MD file, Trello or something else ?

I think it is enough to Create an MD file for now.
Best regards!

Hi @tadashi-aikawa,
Thanks for the suggestions! I agree that the sorting needs to be revised since right now it's very basic. I'll look into the roadmap tasks  in the following days.
If you have time, you can take a look at the source code and if you want to change something feel free to create a branch! I'm using git flow to manage the release lifecycle, but you can do as you like.
Lastly, how do you think we could track the development, and who's working on what task ? We might use GitHub issues or discord to have a faster way to communicate.
Have a nice day!

Hi @Yeboster.
Thank you for your agreement! As suggested, I would develop on a branch using git-flow if needed. (P.S. I like your source codes using functional programming😉)

how do you think we could track the development, and who's working on what task?

I like using GitHub issues to track development and communicate. I have not had much time because of my job recently, so I hope you will understand my reply might be late.
Have a nice day!

Hello @tadashi-aikawa,
That's great! So feel free to create a branch and with an issue related, so we can have an idea on what we are working on. Thanks for the compliment! I'm just in love with FP, but I still need to learn a lot 😄
No worries about the late replies, I am working too so the time left is not so much (and also I am from europe, so the time zone difference between us is huge). Anyway in the next days I will create an issue about the roadmap, including your suggestions.
Until then, have a nice day!

This issue will be closed because the collaboration has begun✨


What projects are impacted by Oracle replacement?

Describe the task
Answer all systems wthat would be impacted by replacing Oracle
Moving to Confluence (Page TBD): https://apps.nrs.gov.bc.ca/int/confluence/display/EPDDS/EPDDS+-+Documentation+Home?
Answers:

BC Land Title and survey (LTSA) - Updated site details are uploaded to LTSA weekly
BC Online Site Registry (ESRA) - ESRA loads the data from the Oracle database (not sure on frequency) to a CSV maintained in AWS and in turns loads the CSV to its Postgres DB
BC Graphical Warehouse - to build the contaminated site layers,(not sure of the frequency and if its a push/pull of the data)
CATS: Just the Shared Drive - likely no Oracle impact?

Acceptance Criteria

[ ] Completed answers

SME/User Contact
Om
Additional context

IRS - https://a100.gov.bc.ca/int/irs/viewApplication.do?name=SITE

@acoard-aot CATS is connected to SITE using DBLink, so CATS does pull data from SITE Oracle DB through DB Link.
https://a100.gov.bc.ca/int/irs/viewApplication.do?name=CATS with a dblink to SIS schema in Oracle ENVPROD1
This opens up another question is, do we need to open up CATS DB firewall (https://github.com/bcgov/nr-epd-digital-services/issues/194), since it is reading from oracle? we will find out in further discussion.
cc @hsawyerPO

Putting this in Icebox for now but pinning to the top, can be long-term issue we come back to.

TODO: Write up questions for each team, so we can send up a write-up as pre-meeting to ensure productive meeting.


Add caption bridges c648

My "First" Pull Request
TL;DR this PR updates the copy of bridgesC648's slide
This PR closes / fixes / resolves #2
Done

made created a branch
made a commit

To Do

[ ] merge the branch
[ ] delete the branch afterward

cc. @bridgesC648

Good job, you get a raise!

If only!


[COLLECTIONS-737] The test FluentIterableTest.size should be splitted

Extracted the first part of FluentIterableTest.size to a sperate test FluentIterableTest.ofNull
Fixes COLLECTIONS-737

Sounds good, thanks for the review!


Facebook message_reads message_echoes events not supported by Botkit

The message_reads and message_echoes events aren't implemented by Botkit. I verified that they are being received correctly by the /facebook/received endpoint but no corresponding bot event is triggered.
{ sender: { id: '1428481693844762' },
  recipient: { id: '227330390965687' },
  timestamp:<PHONE_NUMBER>275,
  read: { watermark:<PHONE_NUMBER>271, seq: 17971 } }

info: Got an unexpected message from Facebook:  { sender: { id: '1428481693844762' },
  recipient: { id: '227330390965687' },
  timestamp:<PHONE_NUMBER>275,
  read: { watermark:<PHONE_NUMBER>271, seq: 17971 } }

{ sender: { id: '227330390965687' },
  recipient: { id: '1428481693844762' },
  timestamp:<PHONE_NUMBER>430,
  message:
   { is_echo: true,
     mid: 'mid.1472535356404:261dbbb07e0c648089',
     seq: 17972,
     text: 'sending message' } }

i'll be happy to fix this as we need this asap -- but realized there are no tests for Facebook. Shall I go ahead and submit a pull request? @peterswimm @malhotraa?

@arunthampi If you submit a PR I'll definitely get our team to review it!

Done! done! https://github.com/howdyai/botkit/pull/403

This is merged and will be published in 0.4!


Assumes WebGL2 support on a system that only supports WebGL

JavaScript console error:
Uncaught Error: The browser supports WebGL2, but initialization failed.
    at webgl.js:19

The system I'm using is quite old, and given the output of:
$ glxinfo | grep "OpenGL ES profile version"
OpenGL ES profile version string: OpenGL ES 2.0 NVIDIA 340.107 340.107

I'm fairly certain that it doesn't support WebGL2, as that would require ES 3.0, at a minimum.
typeof WebGL2RenderingContext !== 'undefined' does not appear to be a valid method for WebGL2 detection.
The only way I know of, that seems to work, is to try getting a webgl2 context: If the returned object is null, assume it's not supported, and fall back to webgl.

Thanks for the report! I realized I wasn't using any WebGL2 functions so I just got rid of that code. Let me know if it works for you now.

Works great now.
Thanks for the quick response.


upgrade poetry to 1.1.3

It's a formal version, and support azure packages well.

Merged without code review due to timeout.


disable editing the code while dash is running

right now if you add blocks while it is running, eventually there is an array out of bounds fatal error


Need to be able to delete measurements

No way to delete measurements — should be an option when you select one or more (with a modal that confirms deletion!)

With commit 7cfcd0a8ac41c94cba21c7e3b603253faf52a56d single measurements can be deleted from a button at the bottom of the measurement detail page. Still need to add ability to delete from the measurements page when one or more measurements are selected.

Didn't see that there was still work need t be done to close this.

Yeah, still need to add ability to delete from the measurements page when one or more measurements are selected.

Added with commit 00788ea5243535b51aa1af0e445ca62b2521d461
If this is what you had in mind @nicolasmroberts you can close this issue.


Multiple color pickers swatches problem

Hi
First of all, awesome color picker. I love the simplicity of it. We have multiple color pickers on one page with different configurations. That works almost perfect, but we found a tiny little bug. If we select a color picker that uses swatches and then switch to another color picker without swatches, then the swatches from the previously added are displayed. I digged into the code and found the error:
On line 103 (coloris.js) theres a condition that only replaces the html if there are swatches defined (if (swatches.length)). You should add an else statement that sets the innerHTML to an empty string or something like this.

Thank you for the kind word and the bug report!
Indeed, it's an oversight on my part, I will release a fix today.

Thanks for the quick fix. Amazing support!

I have updated NPM with the fixes and released 0.10.3 as well.


perf (ui/skeleton)  add class

Codecov Report

Merging #362 (d844854) into dev (73426b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #362   +/-   ##
=======================================
  Coverage   96.39%   96.39%
=======================================
  Files         209      209
  Lines        4905     4907    +2
  Branches     1047     1047
=======================================
+ Hits         4728     4730    +2
  Misses        177      177

Impacted Files
Coverage Δ

packages/varlet-ui/src/skeleton/Skeleton.vue
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73426b2...d844854. Read the comment docs.


qemu: only set romfile when it not empty

set romfile only when it is not empty, or an empty romfile will
in qemu cmdline, through it is not a bug.
-device virtio-balloon,id=balloon0,romfile=,

Signed-off-by: Ace-Tang<EMAIL_ADDRESS>

Coverage remained the same at 79.241% when pulling 78bcb3f2e7110695a3d6f980d5d3a5043af9996f on Ace-Tang:romfile into b48780f3d357db3124c9f8e1c7584934c91af688 on intel:master.

The current behaviour seems to be by design.  See the comments in the commit that added the ROMFile option #7fdfc6a4c979ed691f90e279d65746c8fa49cdb3.

In order to reduce the "forced" dependency on such ROM file, govmm
should provide an empty path if the consumer of the library does not
provide one.

@sboeuf Could you comment on this?

I check the commit
commit 7fdfc6a4c979ed691f90e279d65746c8fa49cdb3
Author: Sebastien Boeuf<EMAIL_ADDRESS>Date:   Mon Oct 8 16:04:17 2018 -0700

    qemu: Add support for romfile option

    Any device inheriting from virtio-pci can specify a ROM file. This
    option is provisioned by default with "efi-virtio.rom", but most
    of the time, firmwares such as OVMF or seabios will already support
    what is provided by this ROM file.

    In order to reduce the "forced" dependency on such ROM file, govmm
    should provide an empty path if the consumer of the library does not
    provide one.

    This patch reorganizes the list of devices, so that it gets easier to
    list which devices inherit from virtio-pci, and then adds the romfile
    option to every single device that support this option.

    Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>
I should close it .

@sboeuf It would be great to get confirmation that the current behaviour is indeed intended.

@markdryan yes it is the intended behavior. I've added support for this romfile= so that we don't implicitly end up pulling some unneeded/unwanted dependency by default.