Ant Design Vue ( Use modularized Antd )

Hello everyone and sorry if it's not the right place for this one ! It's my very first time on github 😂
I'm using nuxt for a while now and everything works great except for the Antd Framework ! It works as a plugin from the Nuxt CLI ... but the vue devtools keeps showing a warning about should avoid importing the whole package and using the modularized way with babel-import-plugin
Does anyone faced it or any fix for this please ?

Hi @TariikHr !
The warning is right, it is useless to import the whole package while you're probably using just a few components!
You should import just the components you're actually using, here you are the official guide about importing only certain components: https://vue.ant.design/docs/vue/getting-started/
Hope it helps!

Hello @micheleriva Thanks for your answer =)
I Really tried to import components on demand...with and without the babel-import-plugin but with nuxtjs it's not quit easy and create-nuxt-app import the whole package as a plugin.
as mentioned in the Ant Design Vue docs that we should use the modularized way i tried it in the nuxt.confi but nothing really works
Thank you for your time again

Hello @TariikHr (๑ơ ω ơ)
I'm here for your mail, here's my solution:
1. Install babel-plugin-import
yarn add -D babel-plugin-import

or
npm install --save-dev babel-plugin-import

2. Disable ANTD plugin
nuxt.config.js
  /*
  ** Global CSS
  */
  css: [
-   'ant-design-vue/dist/antd.css'
  ],
  /*
  ** Plugins to load before mounting the App
  */
  plugins: [
-   '@/plugins/antd-ui'
  ],

3. Use babel-plugin-import
nuxt.config.js
  /*
  ** Build configuration
  */
  build: {
+   babel: {
+     plugins: [
+       ['import', { libraryName: 'ant-design-vue', style: 'css' } ]
+     ]
+   }
  }

4. Import component when you need
~/pages/index.vue
 <template>

+    <Button type="primary">Enjoy it</Button>

 </template>

or register as a Global Component in your main.js or index.js
import Vue from 'vue';
import { Layout } from 'ant-design-vue';

Vue.use(Layout)

@shirohana that's what I'm doing, using Single File Components, looks like the child components aren't imported (like Layout.Sider, Form.Item etc..)
I'm using last versions of nuxtJS and Ant (1.3.16)

@mgnrfk Having exact same problem. Did you manage to find a solution?

@canthis didn't figure it out so I'm using it all, I just stripped the Icons to save some size for now.

I've tried using either of the two. and I always get this on.

I've tried using either of the two. and I always get this one.

+1 :(

Anyone knows (maybe @shirohana) why, when importing ant to Nuxt like so:
plugins: [
        ['import', { libraryName:'ant-design-vue', style:'css' }]
    ]

AntD css-reset is being applied after all my app's css.. it's very annoying, because it overrides some of my stuff, like body{ font-size... }
I am running a very initial Nuxt app with not much in it.

Use import { Button } from 'ant-design-vue/lib'; to fix the "Unexpected token {" error.
Source: https://stackoverflow.com/questions/53146624/import-ui-library-modularized-in-nuxtjs

@yairEO here is the solution. https://www.antdv.com/docs/vue/getting-started/#Import-on-Demand
Add these before of your css files.

FYI, babel-plugin-import's style option will importing some global reset styles, don't use it if you don't need those styles. You can import styles manually via import 'ant-design-vue/dist/antd.css' and override the global reset styles.

I've tried using either of the two. and I always get this one.

have same problem.

Solved the issue in by including antd css in nuxtconfig,js and remove style option from in babel options

Solved the issue in by including antd css in nuxtconfig,js and remove style option from in babel options

I've tried using either of the two. and I always get this one.

have same problem.

Try this:
delete node.modules
delete .nuxt
nuxt.config
 build: {     babel: {       plugins: [         ['import', {           libraryName: 'ant-design-vue',           libraryDirectory: 'lib',           style: name =>${name}/style/index.css         }]       ]     }   },
component
`

 123123

`

@shirohana that's what I'm doing, using Single File Components, looks like the child components aren't imported (like Layout.Sider, Form.Item etc..)
I'm using last versions of nuxtJS and Ant (1.3.16)

I'm facing the exact problem. Some parts of the layout is working but others don't. Searching in Vue docs I found this treasure:
https://v3.vuejs.org/guide/component-registration.html#local-registration

Note that locally registered components are not also available in subcomponents. For example, if you wanted ComponentA to be available in ComponentB, you'd have to use:

const ComponentA = {
  /* ... */
}

const ComponentB = {
  components: {
    'component-a': ComponentA
  }
  // ...
}

Semms like your child components must to declare their components too

@shirohana that's what I'm doing, using Single File Components, looks like the child components aren't imported (like Layout.Sider, Form.Item etc..)
I'm using last versions of nuxtJS and Ant (1.3.16)

I'm facing the exact problem. Some parts of the layout is working but others don't. Searching in Vue docs I found this treasure:
https://v3.vuejs.org/guide/component-registration.html#local-registration

Note that locally registered components are not also available in subcomponents. For example, if you wanted ComponentA to be available in ComponentB, you'd have to use:

const ComponentA = {
  /* ... */
}

const ComponentB = {
  components: {
    'component-a': ComponentA
  }
  // ...
}

Semms like your child components must to declare their components too

Solved the issue in by including antd css in nuxtconfig,js and remove style option from in babel options

I've tried using either of the two. and I always get this one.

have same problem.

Try this:
delete node.modules
delete .nuxt
nuxt.config
 build: { babel: { plugins: [ ['import', { libraryName: 'ant-design-vue', libraryDirectory: 'lib', style: name =>${name}/style/index.css }] ] } },
component
`
123123

`

Thanks, this worked for me


RayGraphAdapter incorrect telemetry output to Hamilton UI

HamiltonTracker logs wrong execution telemetry if run with RayGraphAdapter.
Current behaviour

Individual node execution tracks as immediate.
During Error the run does not display failure / shows all nodes executed correctly.

Steps to replicate behavior
import pandas as pd
import time

def node_5s()->float:
    start = time.time()
    time.sleep(5)
    return time.time() - start

def node_5s_error()->float:
    start = time.time()
    time.sleep(5)
    raise ValueError("Does not break telemetry if executed through ray")
    return time.time() - start

if __name__ == "__main__":
    import __main__
    from hamilton import base, driver
    from hamilton.plugins.h_ray import RayGraphAdapter
    from hamilton_sdk import adapters
    import ray

    username = 'jernejfrank'

    tracker_ray = adapters.HamiltonTracker(
        project_id=1,  # modify this as needed
        username=username,
        dag_name="ray_telemetry_bug",
        )

    try:
        ray.init()
        rga = RayGraphAdapter(result_builder=base.PandasDataFrameResult())
        dr_ray = ( driver.Builder()
            .with_modules(__main__)
            .with_adapters(rga,tracker_ray)
            .build()
            )
        result_ray = dr_ray.execute(final_vars=['node_5s','node_5s_error'])
        print(result_ray)
        ray.shutdown()
    except ValueError:
        print("UI displays no problem")
    finally:
        tracker = adapters.HamiltonTracker(
            project_id=1,  # modify this as needed
            username=username,
            dag_name="telemetry_okay",
            )
        dr_without_ray = ( driver.Builder()
            .with_modules(__main__)
            .with_adapters(tracker)
            .build()
            )

        result_without_ray = dr_without_ray.execute(final_vars=['node_5s','node_5s_error'])

Library & System Information

sf-hamilton:main
ray 2.34.0
Python 3.9 and 3.10
Linux Ubuntu 22.04
MacOS Ventura 13.6.7

Expected behavior
Same as without RayGraphAdapter
Additional context
Happy to work on that, but I will need support.

@jernejfrank thanks for the issue. Currently this is expected behavior for use with the RayGraphAdapter (the HamiltonTracker works when using Parallel / Collect + RayTaskExecutor).
So we have all the tools, it's just the wiring that needs to be set up. There's a few approaches we could take.  I assume this is a bit of a blocker for you to use the UI then?

@skrawcz ah, okay - didn't know about RayTaskExecutor and haven't had the time/need to touch the parallel module.
Our pipelines are pretty split up and only one of them uses Ray so far. Not complete blocker since the UI will be handy on the pipelines, but definitely looking to have that up an running with Ray as well (since we are planning to upgrade other pipelines to Ray).
Cool, let me know when you have something in mind. Like I said, happy to contribute.

@jernejfrank yeah so we think we have a path forward:

We need to add a new lifecycle API method that is something like do_remote_execute.
This will then create a wrapper function that will pass through adapters to be used around the function to be executed, e.g. enabling the pass through of the HamiltonTracker to execute along with the function that is being remotely executed.
We'd then need to mess with a few of the internals a little to make this work.

So plan is to sketch this out in a PR - depending on the details will tag you for something to contribute to where it makes sense.

Hey @jernejfrank -- we outlined in detail what would be involved -- it's nothing too complicated but you get a bit of a tour of Hamilton's inner workings. Feel free to reach out if you want to pair to get started.
https://github.com/DAGWorks-Inc/hamilton/pull/1097/files

Hi @elijahbenizzy , awesome! Super excited to look under the hood.
Let me poke around a bit over the weekend and maybe we can meet Monday or Tuesday to make it more productive? I'm based in the UK and available after 2pm GMT, let me know if it fits in your schedule.

Hi @elijahbenizzy , awesome! Super excited to look under the hood.
Let me poke around a bit over the weekend and maybe we can meet Monday or Tuesday to make it more productive? I'm based in the UK and available after 2pm GMT, let me know if it fits in your schedule.

Sounds good! Will reach out on slack to find a time.


Nativestore, new context cache without Exception

See also https://www.eclipse.org/lists/rdf4j-dev/msg01242.html
When a new native store is created, the context cache file does not exist, so this files gets created.
Unfortunately there is also an Exception being thrown, because there is currently no distinction between creating a cache for a new store, and recreating an invalid/corrupt cache.
It would be nicer to just log this, instead of throwing / propagating an Exception.

This thing is driving me nuts in running tests on master. I'm gonna have a quick look at backporting your fix to the master branch.


Mapping from chunk size to bitrate

Hello,
I have a doubt in section 4.3)Enhancement for multiple videos
The paper says that "Then, to determine the input state for a specific
video, we take the chunk sizes and map them to the index which has
the closest bitrate."
Can you share some information regarding how it it done, the synthetic dataset created has a mask present in it, but how do we fill in that mask values for real data.
Please let me know if there is some doubt in the question
Thank you

If I remember, our way of modeling multi-videos doesn't capture this case. I would imagine you do some nearest neighbor mapping and the mask out the rest bitrates. In your example, I would map 1525 to action 5 (VIDEO_BIT_RATE[5] = 1850) and so on. At the end you just want to map the bitrate to a subset of the actions.


Task/issue 44 typescript integration

resolves #44

TODO

sane build tasks using gulp-webserver
address vendor compile issues


intermittent failure in BinaryAnalysisFormatSpecification

seen at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3238/consoleFull
[zinc] [info] + TextAnalysisFormat.Write and read empty Analysis: OK, proved property.
[zinc] [info] ! BinaryAnalysisFormat.Write and read complex Analysis: Exception raised on property evaluation.
[zinc] [info] > ARG_0: Analysis: 5 Scala sources, 30 classes, 5 external source dependencies
[zinc] [info] > Exception: java.lang.NullPointerException: null

If it happens again, let me know and I’ll try to find a way to reproduce it


Repo is in default HACS list

Indeed, the repo was merged on the default list yesterday. Thanks for your contribution.


Lumen Support

Does this support lumen? Can you document it please.

@xitude I have not tested it with lumen , but I think yes


[Port] Correctly normalize file path from network shares (#298)

Port of the fix from https://github.com/aspnet/AspNetCore-Tooling/pull/298
@rynowak. fyi I am merging this to release/vs16.0-preview4. Let me know if you instead prefer we create a separate release/vs16.0-preview4-servicing branch.

Branch name is fine
This is a cherry-pick not a merge right?

This is a cherry-pick not a merge right?

Yes


Split cascade.hpp into multiple files

This is a somewhat major reorganization to make it easier to work on different branches. Instead of all the CascadeStore types being defined and implemented in one pair of files (cascade/cascade_impl.hpp), each class is now in its own pair of files. cascade.hpp is now a meta-file that includes the four component files, so clients can still just include <cascade/cacade.hpp> to use Cascade. I also split src/service/server.cpp into a header and source file to make it easier to reuse the CDPO definition, which I needed to do in my cascade_chain branch.
There are no code changes in this commit, and everything still compiles.

Merge Edward's pull request. The projects in src/applications/standalone need testing with the new set of header files.


fix(platform): wrap event listeners around zone

Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

closes #18831 as indicated: https://github.com/ionic-team/ionic/releases/tag/v4.7.0


Run tests with API 30

what title says :) we should update the workflow to also run tests on API 30.
We could also consider a bit of a cleanup to have 1 task build all apks and other tasks to just run tests with the output of the previous task.

we run tests on api 30 now.

i think we also do this now: have 1 task build all apks and other tasks to just run tests with the output of the previous task
we have the ./gradlew build step
and then test step for ./gradlew check and then emulator test separated for each module e.g. ./gradlew :engine:connectedCheck
so i think this can be closed.
@yigit @omarismail94 FYI
i'm gonna be aggressive and close this. but please feel free to reopen if i'm wrong :)


[Request] allow generation of plugin goal pages under a child

Hi,
Currently AFAIK , the goal pages are generated under the HomePage. This mess up  with the definition that we have done in the site.xml.
We should be able to choose under which page we want the plugins goals to be.

I can suggest something like
  <xs:complexType name="page">
    <xs:complexContent>
      <xs:extension base="tns:source">
        <xs:sequence>
          <xs:element name="attachment" type="tns:attachment" minOccurs="0" maxOccurs="unbounded"/>
          <xs:element name="child" type="tns:page" minOccurs="0" maxOccurs="unbounded"/>
          <xs:element name="label" type="xs:string" minOccurs="0" maxOccurs="unbounded"/>
          <xs:element name="generatedChildren" minOccurs="0" maxOccurs="unbounded">
            <xs:complexType>
              <xs:attribute name="ref" type="xs:string" />
            </xs:complexType>
          </xs:element>
        </xs:sequence>
      </xs:extension>
    </xs:complexContent>
  </xs:complexType>

ref : reserved reference to generated page sets. typical value can be plugin.goals

This issue is considered a duplicate of issue #124

Hi,
this one is meant to have the goal pages generated under a certain page in the page tree, while #124  was to generate the goal table listing in a certain page.
Today, in the confluence space left menu I have this:
site home
| - site home - my subpage
| - site home - goal1
| - site home - goal2
| - site home - goal3
| - site home - goal4
` - site home - my other subpage

I would like
site home
| - site home - my subpage
|    | - site home - goal1
|    | - site home - goal2
|    | - site home - goal3
|    ` - site home - goal4
` - site home - my other subpage

I believe this one is not a duplicate.

released with version 5.0-rc3


Add a basic EDN parser

The parser mostly works and has a decent test suite. It parses all the
queries issued by tofino-user-agent with some caveats. Known flaws:

No support for tagged elements, comments, discarded elements or "'"
Incomplete support for escaped characters in strings and the range of
characters that are allowed in keywords and symbols
Possible whitespace handling problems
Possibly poor memory handling

I've been using https://github.com/Marwes/combine to parse an EDN AST into a yet more specialized transaction AST.  One of the nice things about combine is that it makes providing decent error messages possible (if not easy).
While thinking about how to provide pleasing error messages that include input positions, I realized that I want my EDN input to includes its input positions as well.  (Either that or I want to parse my own text, so that I can provide meaningful error messages that include input positions and ranges.)
This may not be something we want to handle at this time, but how hard is it to include input ranges using peg?  At least that way I could join peg ranges to provide some hints as to which part of your input failed.

In answer to ncalexan's question about retaining input positions, I think the answer is to include some sort of line+col / offset structure alongside each Value. I don't have a concrete plan, but I believe it should work.

It's worth preserving a link to https://github.com/mozilla/mentat/pull/149/commits/29bc8081a1983e9e59b1b0450bf1307a2db053b6 and https://github.com/mozilla/mentat/pull/149/commits/41f59977f67c6cfd53e88e51b1bb2975510f82be as I'm about to rebase and squash and @rnewman probably wants to see those before any final r+.

Landed in c473511, with the fixes from f12fbf23889903bb67ccc01ce1e2047b8743533a squashed in.


add notebook for llm chat

CVS-116313

mpt-7b requires einops:

mpt-7b requires einops:

@apaniukov , thanks updated

I was unable to compile the 3B model on GPU (A750), getting
RuntimeError: Exception from [C:\Jenkins\workspace\private-ci\ie\build-windows-vs2019](file:///C:/Jenkins/workspace/private-ci/ie/build-windows-vs2019)@3\b\repos\openvino\src\inference\src\core.cpp:117:
Check 'itr->second == desc' failed at [C:\Jenkins\workspace\private-ci\ie\build-windows-vs2019](file:///C:/Jenkins/workspace/private-ci/ie/build-windows-vs2019)@3\b\repos\openvino\src\plugins\intel_gpu\src\graph\topology.cpp:15:
[GPU] Different primitive with id 'gather:/gpt_neox/Gather_1' exists already

using todays optimum and optimum-intel 1.10.1 releases.
Can you validate that GPU compilation and inference is working?

I was unable to compile the 3B model on GPU (A750), getting
RuntimeError: Exception from [C:\Jenkins\workspace\private-ci\ie\build-windows-vs2019](file:///C:/Jenkins/workspace/private-ci/ie/build-windows-vs2019)@3\b\repos\openvino\src\inference\src\core.cpp:117:
Check 'itr->second == desc' failed at [C:\Jenkins\workspace\private-ci\ie\build-windows-vs2019](file:///C:/Jenkins/workspace/private-ci/ie/build-windows-vs2019)@3\b\repos\openvino\src\plugins\intel_gpu\src\graph\topology.cpp:15:
[GPU] Different primitive with id 'gather:/gpt_neox/Gather_1' exists already

using todays optimum and optimum-intel 1.10.1 releases. Can you validate that GPU compilation and inference is working?

The Red Pajama 3B model is running on my Arc A770 GPU. It uses about 11GB of GPU memory. The A750 may not have enough memory to load the FP16 model.

The Red Pajama 3B model is running on my Arc A770 GPU. It uses about 11GB of GPU memory.

That's a good insight. I never expect the OV conversion to be as bad. Since GPU forces FP16 which would normally fit a 3B model on a 8GB GPU (at least on cuda). This notebook specifies that you need 64GB ram for the conversion (for the 7B models? 32GB isn't enough for the 3B either and it fills up) but you also need 20GB storage even though if the model.bin is 5.8GB.
Apart from successfully compiling the model on GPU, is the performance any good? I did manage to compile and run the 240-notebook with the dolly2 3B but the performance was horrible.

Intel Xeon Server E3 (Supermicro)
64GB RAM
Red Pajama - Works
Llama2 - Failed (Crashes after query)
Intel Xeon Processor Cascade Lake (Amazon EC2)
128 GB RAM
Red Pajama - Works
Llama2 - Runs however results into error  (Uses around 110 GB RAM)
Error - Expecting value: line 1 column 1 (char 0)

The Red Pajama 3B model is running on my Arc A770 GPU. It uses about 11GB of GPU memory.

That's a good insight. I never expect the OV conversion to be as bad. Since GPU forces FP16 which would normally fit a 3B model on a 8GB GPU (at least on cuda). This notebook specifies that you need 64GB ram for the conversion (for the 7B models? 32GB isn't enough for the 3B either and it fills up) but you also need 20GB storage even though if the model.bin is 5.8GB.
Apart from successfully compiling the model on GPU, is the performance any good? I did manage to compile and run the 240-notebook with the dolly2 3B but the performance was horrible.

The performance of LLM models will be better with 2023.1. GPU perf for me was ok but CPU was much better. We will have the 2023.1 pre release on PyPI (hopefully) before the end of July.

Expecting value: line 1 column 1 (char 0)
@vagheshp this error does have relation to model, it says that you have wrong proxy settings and connection with interface was lost.

Regarding memory issue, do you have already converted model to IR or conversion happens in the same process, I think it maybe the reason of large memory consumption if optimum does not free some memory after model conversion?

Regarding memory issue, do you have already converted model to IR or conversion happens in the same process, I think it maybe the reason of large memory consumption if optimum does not free some memory after model conversion?

Optimum uses a TempDir for the ONNX export in between source. And looking at the ram usage during conversion it looks like ram is freed when that cell is done executing. However it seems like the openvino IR .bin file is twice as large as the pytroch model.bin - so I suspect it's saved to fp32 for some reason - could be those HINTS and it seems like the openvino documentation has improved with 2023.0 so I will maybe raise a new issue on that observation.

Optimum uses a TempDir for the ONNX export in between

yes, but after that it reads onnx directly to openvino that leads to additional optimization run on runtime side during reading, so the second run when you already have serialized IR using save_pretrained should requires less memory. Could you please check this hypotisis?

@vagheshp this error does have relation to model, it says that you have wrong proxy settings and connection with interface was lost.

Thanks @eaidova. Let me try on open network.
I am running the conversion in the same process.

@vagheshp this error does have relation to model, it says that you have wrong proxy settings and connection with interface was lost.

Thanks @eaidova. Let me try on open network.
I am running the conversion in the same process.

I am able to run the chat window on the second try with the llama2 model in the open network.
For the first try, optimum was not freeing the memory so when I query it crashes my jupyter kernel. However, on second try, I was able to run the chat box and query with proper response.
One thing I noticed is the memory usage is very high, It is almost using 127GB on my second try.

Intel Xeon Server E3 (Supermicro) 64GB RAM Red Pajama - Works Llama2 - Failed (Crashes after query)
Intel Xeon Processor Cascade Lake (Amazon EC2) 128 GB RAM Red Pajama - Works Llama2 - Runs however results into error (Uses around 110 GB RAM) Error - Expecting value: line 1 column 1 (char 0)

Also, got the crash on the first run with my xeon setup.

@vagheshp this error does have relation to model, it says that you have wrong proxy settings and connection with interface was lost.

Thanks @eaidova. Let me try on open network.
I am running the conversion in the same process.

I am able to run the chat window on the second try with the llama2 model in the open network. For the first try, optimum was not freeing the memory so when I query it crashes my jupyter kernel. However, on second try, I was able to run the chat box and query with proper response.
One thing I noticed is the memory usage is very high, It is almost using 127GB on my second try.

We need open network to make it works?


Fix "Play with Jockey" intent not working correctly

This only handles URIs that directly map to files, which is not guaranteed. To resolve this, Jockey will need to be restructured to play URIs instead of files.


how to use support https

hello , i have a question..  how to make this project support the https.  thanks very much.!

You need compile curl with openssl, I've tried before but failed :(


adding cloudsqlproxy wrapper and use exitdir to signal when the pod should terminate

Summary

adding cloudsqlproxy wrapper and use exitdir to signal when the pod should terminate

in our public instance we use cloudsql and the cloudsql-proxy to connect in the DB
however in the createdb job the cloudsql run forever and never finish because it is not aware of the main container that creates the db, using the https://github.com/chainguard-dev/exitdir we can signal from createdb to cloudproxy when we are ready and then the job the gracefully finish
This is the first part of the fix and the second is to update https://github.com/sigstore/helm-charts/blob/main/charts/trillian/templates/createdb/createdb-job.yaml to use this image
This will fix: https://github.com/sigstore/public-good-instance/issues/965

@vaikas @priyawadhwa let me know if this makes sense as initial iteration

will continue the work


NTH: Disable "overflow hidden" on CMS, in case of reload with error

Having to disable the overflow hidden on the CMS html, to view the rendered error, annoys me a bit. It would be nice that if there's an error detected, the overflow hidden isn't set.
I understand that this is not easy to detect/implement, so it's a very big NTH.

Or if errors were output in another contained that was absolutely positioned?
Couldn't we put the cms in a wrapper and have that overflow-hidden?
PS what is NTH

Also a good option. As long as they at least become readable :)
p.s.
NTH = "Nice To Have"

This issue has always annoyed me personally. Perhaps a button to switchable to a view off the errors when in dev mode would be nice.


fix: increase SPA ID length limit for work code validation

SPA IDs are sequential numbers. Sometime within the last 2.5 years, the 10 millionth SPA ID was issued, which means that an increasing amount of IDs are now 8 characters long instead of 7. However, the script associated with this library currently only looks for 7 digits, and presents (incorrect) validation errors for 8-digit SPA IDs. This change aims to ameliorate that by increasing the character length the regex allows for.

Thanks! Could you also update the mb_bulk_copy_work_codes.user.js and mb_validate_work_codes.user.js so that they use the newer version of the library? It should suffice to update the version number of the library in the @require (line 18 in both scripts), and also the @version (line 3 in both cases).

695e56c should do the trick.

Thanks for the fix!


Employee and Customer APP skeleton

create a sample projects and add dependencies
Web, JPA, Actuator, DevTools, Security, RabbitMQ, Lombok, REST Docs, PostgreSQL, Solr.

will try to follow. if you feel any template for the PR-comments please let me know


Add rpc-pre-upgrades playbook

Perform backups of openstack_deploy and the database.
Gather stats of the following:
neutron agent-list
cinder service-list
nova service-list
openstack endpoint list
database output showing running instances
database output showing volume to instance mappings
swift-recon md5
This is based on the maintenance plan set aside by support, and is a
first effort at adding the steps that happen prior to the actual upgrade
happening.
Connects rcbops/u-suk-dev#293

So, the linting is failing two steps:
[ANSIBLE0006] tar used in place of unarchive module
/home/travis/build/rcbops/rpc-openstack/rpcd/playbooks/roles/rpc_pre_upgrade/tasks/backup.yml:21
Task/Handler: Backup the /etc/openstack_deploy directory

[ANSIBLE0007] rm used in place of argument state=absent to file module
/home/travis/build/rcbops/rpc-openstack/rpcd/playbooks/roles/rpc_pre_upgrade/tasks/log_rotation.yml:32
Task/Handler: Clean up rsyslog forward and state files

I think we can add exceptions for both of these, in the first case tar is being called to create an archive which is not possible with ansible modules.  This looks like more of a linter bug to me.  In the second case we're using rm to clear all of the files in a directory which the files module does not do, it may be possible with a loop but that, to me, is harder to read.
Suggestions welcome :)

@d34dh0r53 Those are common errors in the linting - just add the tag 'skip-ansible-lint' and the linting will skip that task.

Shouldn't we ensure the system is in a proper state instead of only "backuping" the agent/service lists?
I mean: wouldn't it be good to have a assert:  or a fail: when XXX, or :(, or xxx (I don't remember the syntax for every single cli) is in stdout_lines and the agent is not disabled?
This would ensure that we don't upgrade a bad cluster and then say "well it wasn't good, it's not better now", but also avoid issues that could appear during the upgrade due to the bad state of the cloud before any operation. (Some tasks rely on process running properly).

Separate note, shouldn't this all be one commit? I know you and Andy did separate work, but there are presently 2 commits here.

I agree with @evrardjp on the matter of checking to see if the environment is in the proper state, then failing if it's not. As suppose to just capturing it's state in files somewhere.
Having said that, there is some overlap between what is being done here and what is being done in the post-upgrade tasks: https://github.com/rcbops/rpc-openstack/pull/1368/files
i.e the openstack services check, the galera checks.
I'm not saying we should use the exact same tasks for both the pre and post tasks procedures, but we need to make sure we are checking the same values here.

Ideally it would be great to fail if there are issues, but I'm not sure we have the time or scope to do that right now. It would be nice to do that in future, but it looks like a lot of these tasks are for backing up the data - so you can do a comparison after the upgrade. I'm also not sure we can make a lot of assumptions around what is a fail/success in most cases.
I'm also not sure we have enough requirements to do that in a sensible way right now. IMO this is a good first pass, and we can look to improve the pre-upgrade checks at a later point. In other words, we port the tasks directly and then improve them to do more and check status automatically.

Yeah, I agree with @andymcc.  Given our time constraints we're giving upgraders a place to look before the actual upgrade starts and verify that everything is as expected.  I think even with automated failure modes people would still want to manually verify that the clusters are nominal before starting the upgrade.  It will definitely be nice to have automated failures should assertions fail in a future release.

@andymcc @d34dh0r53 Good point. I'll test this patch right now and report back soon

Works as expected. I'm a little hesitant to give it my plus one right now because there is more than one commit on this PR. I'm not sure if that's something we really care about. If not, then you have my :+1:
I've made a comment about swift's venv. Just a small suggestion :)

I tested this during an upgrade, and i ran into a little snag when the role runs the task "Gather swift recon output". This is what I have done below:
cd /opt/rpc-openstack # Currently on liberty-12.2
git checkout master # Mitaka
git submodule update
wget https://github.com/rcbops/rpc-openstack/pull/1358.patch
git am --signoff < 1358.patch
cd rpcd/playbooks
openstack-ansible rpc-pre-upgrades.yml

The playbook failed here:
TASK: [rpc_pre_upgrade | Gather swift recon output] ***************************
failed: [localhost -> cantu-testup-ceph2_swift_proxy_container-602a2855] => {"changed": true, "cmd": "/openstack/venvs/swift-13.3.2/bin/swift-recon -arul --md5", "delta": "0:00:00.003468", "end": "2016-08-31 19:16:49.674669", "rc": 127, "start": "2016-08-31 19:16:49.671201", "warnings": []}
stderr: /bin/sh: 1: /openstack/venvs/swift-13.3.2/bin/swift-recon: not found

FATAL: all hosts have already failed -- aborting

It seems like {{ openstack_version }} grabs the new version of openstack we are upgrading to, but those venvs aren't there yet since the environment hasn't actually been upgraded yet.

@alextricity25 yeah, thinking about it we probably need to run this before the submodule update or figure out a different way to determine that path.

I think either way is fine. If it's the former(running this before doing the submodule update), we will just have to make sure usage is properly documented somewhere.
I'll try running the playbook before running git submodule update and report back soon.

Overall this looks to be automating the actual tasks defined in the maintenance plan as opposed to trying to solve the problems posed by the plan. As mentioned already by others parity with previous releases is a reasonable first pass given time constraints.
I agree with previous comments that squashing the commits seems appropriate. I think the patch should be adding the playbook to the upgrade script and we also need to make sure that an appropriate docs issue/pull-request is created to describe the use of this functionality.
@d34dh0r53 @alextricity25 running this before the submodule is updated sounds less than ideal, maybe we could list the Swift venvs and grab the newest assuming there are multiple or require that a var is set by support.
@rcbops/support-feedback please provide feedback on this implementation of your existing pre-upgrade maintenance plan steps.

Agreed with @git-harry , and reiterate my comment above :p

I ran the playbooks, this time before running git submodule update. Everything worked!
Maybe it would be better to run a set_fact task that sets a fact to the path of the swift-recon executable inside the venv. The path can be found using the find command inside the swift_proxy containers. Ex:
find / -executable -type f -name swift-recon

Then you could use that fact to invoke swift-recon

If you want to double-check your formatting, check the preview.

I've squashed the commits for now. @alextricity25 I don't think that is reliable in that I'm not sure we remove old venvs - which is to say that there could be more than one version of swift-recon on the host.

@alextricity25 et al, I know this is rather ugly but we can run pgrep -fao swift | awk -F/ '{ print $4 }' to pull the running swift version from the swift server.  We could use this for the path of the venv.

@d34dh0r53 I like how that side-steps the possibility that there are multiple venvs still on disk by looking only at what's presently running. Nicely done. We might use sed instead though to match the version string and print it instead of relying on the version being part of the 4th element. (just as a future proofing exercise)

@sigmavirus24 ahh, sed is a great idea as I'm not sure how past proof this is either. I'll rejigger this to use sed and try it out in the play.

My sed foo went away for a while :/ pgrep -fao swift | sed -r 's_.*(swift-[0-9.]+).*_\1_'  Testing it now.

Your content preview is now ready. :bow:

I've updated the gather_swift_stats.yml to hopefully do a more past/future proof detection of the running swift version.

This patch could do with a release note and the playbook being added to test-upgrade.sh

:-1: I made some comments inline.

:mag_right: Preview

:mag_right: Preview

This passed the local testing I did. However, I'm going to wait until git-harry's suggestions above are fixed before I give it my plus one.

:mag_right: Preview

Done with @git-harry's changes.

:+1:

I'm testing this on an AIO with the post-upgrade steps mixed in too.

👍 Once the tests pass.

recheck_swift


front matters of light wallet

What would you like to be added:

Icons for iOS/Android and etc.
App Store banner images and etc.

Where can I get the assets for them?

/triage accepted
/priority important-soon
/area ui-ux
/assign @aentan @jtlntno-cake

@aentan @jtlntno-cake regarding this topic, this page might help -

Overall icons - https://docs.expo.io/guides/app-icons/
Playstore Preview - https://support.google.com/googleplay/android-developer/answer/9866151?hl=en
App Store - https://developer.apple.com/app-store/marketing/guidelines/


Fix typo in nacos-discovery readme

There is a misspelling in nacos-discovery readme. "同事" should be "同时"

reference: https://github.com/alibaba/spring-cloud-alibaba/pull/3253


Dockerize dev environment

Adds configuration files to run airflow, postgres and s3 locally.

Current processes tree:
5367 ?        Sl     0:00  \_ containerd-shim -namespace moby -workdir /var/lib/containerd/io.containerd.runtime.v1.linux/moby/ab6b31d2dacdbe36d378ee55ab3d618b9a31c39473$b9874a4472879183d894a -address /run/containerd/containerd.sock -containerd-binary /usr/bin/containerd -runtime-root /var/run/docker/runtime-runc
 5402 ?        Ss     0:00      \_ /bin/sh -c /wait && airflow initdb && /bin/sh -c "airflow scheduler -D &" && airflow webserver -p 8080
 5637 ?        S      0:04          \_ /usr/local/bin/python /usr/local/bin/airflow scheduler -D
 5894 ?        Sl     0:00          |   \_ /usr/local/bin/python /usr/local/bin/airflow scheduler -D
 5638 ?        S      0:01          \_ /usr/local/bin/python /usr/local/bin/airflow webserver -p 8080
 5719 ?        S      0:01              \_ gunicorn: master [airflow-webserver]
 5793 ?        Sl     0:00                  \_ [ready] gunicorn: worker [airflow-webserver]
 5794 ?        Sl     0:00                  \_ [ready] gunicorn: worker [airflow-webserver]
 5795 ?        Sl     0:00                  \_ [ready] gunicorn: worker [airflow-webserver]
 5796 ?        Sl     0:00                  \_ [ready] gunicorn: worker [airflow-webserver]

All reasonable and multiple processes running as expected. In the medium term, multiple containers running from the same image will be more flexible for isolation/scaling.


When gettting shop listings variations are empty

Hi,
When trying to get the shop listings and looping over them, each listing has the property
has_variations = true,
yet the array listing.variations remains empty
I couldn't find a way to force the fetching of this association, yet other associations like images do get pulled.
Pulling the single listing on its own by Id and requesting the association, the variations are populated:
listing = Etsy::Listing.find(listing.id, {:includes => 'Variations'})
However I don't want to fetch each listing independently, which would be awfully bad performance.
Thanks
Amit

This is probably a bug in the Listing model.
Have you tried using the DSL described here? https://github.com/kytrinyx/etsy#dsl

Nope, will probably try when I optimize my workaround. Thanks.


Reference to ks in AWS documentation

The "Storage Options" section of the AWS deploy documentation (https://www.kubeflow.org/docs/aws/storage/) still refers to ks commands, even though Kubeflow has moved away from ksonnet. I think this should be updated with the appropriate commands to run with the current tools.

I also see there's a reference to kfctl.sh on this page: https://master.kubeflow.org/docs/aws/customizing-aws/.

/assign @Jeffwan

@wdhorton I will have a clean up and file PR by this week.

ksonnet (ks) is also referenced on this page:
https://www.kubeflow.org/docs/aws/troubleshooting-aws/

@Jeffwan Will you be tackling this issue during the doc sprint?

@sarahmaddox Yeah, I will file a PR to address it.

Related: https://github.com/kubeflow/website/issues/1847


Map shared string macros to plain string constants

Map shared string macros (e.g. DUK_STR_UNSUPPORTED) to plain strings rather than symbols (duk_str_unsupported). Except for very old compilers, string sharing will provide the same benefit, and maintaining the macro/symbol structure is awkward because it leads to "unused symbol" warnings when strings are not referenced with non-default config options.

I always wondered why there was this extra layer of indirection with these.  Most compilers will pool string literals so there's not much to be gained from going through a const.  And a lot of these only have one or two places where they're used anyway so there shouldn't be much duplication going on in any case.

Depending on what one considers significant, there's a reasonable amount of reuse with the strings. In fact, now that the strings are string literals and not explicit symbols, GCC is able to share strings better (the -flto enabled build is 193 bytes smaller for x64, this probably comes from sharing suffixes so that the string constant "foo bar\0" can also be used for "bar\0" by simply sharing the suffix).
In any case the compilers that don't do string sharing well are quite old and I don't know a practical case where they would now be used. It's possible to do something about the strings if such a concrete case surfaces.


net-mgmt/lldp: Ability to set interfaces

Requested here: https://forum.opnsense.org/index.php?topic=7558.0
First I took select_multiple to allow the user to choose interfaces, but this is not really compatible with complex configurations (like described in help text). I think for such a little daemon it's ok to not use validation and only offer a text field.

Looks good, ready for merge?

Yep :)

This can go to next stable ..

Done :)


setup.py download URL

While installing I noticed the url and download_url point to @mistercrunch's repo:
https://github.com/airbnb/airflow/blob/9a791999b871d5f19550cbf882fbd09037d99e52/setup.py#L69

url='https://github.com/mistercrunch/Airflow',
download_url=(
    'https://github.com/mistercrunch/Airflow/tarball/' + version),

Is that the correct repository to install and update from?

Good catch! This used to be on my personal repo until yesterday's announcement. I'll push a PR to fix this right now.

Fixed in 1.0.1
https://pypi.python.org/pypi/airflow/1.0.1

Awesome and congrats!


Improve cocoapods rating

.. and make @orta happy. https://cocoapods.org/pods/MBProgressHUD/quality
Some stuff is already (partially) done - tests, explicit CHANGELOG.mdown, etc.
Also doing https://github.com/jdg/MBProgressHUD/issues/334#issuecomment-177570424 might improve the statistics.

:+1: I'm totally into this - congrats on almost 2 million installs!


htmlunit-driver 2.54.0 (was 2.43.1)

Updates org.seleniumhq.selenium:htmlunit-driver from 2.43.1 to 2.54.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.seleniumhq.selenium", artifactId = "htmlunit-driver" } ]

labels: library-update, semver-minor

Superseded by #328.


add MagicNumber#ignoreNamedParameters option

Resolves #415
As @schalkms suggested I set this to true by default in the default config and Readme.md

Oh, didn't realize that #426 also resolves #415. I'll leave this one open for now, but feel free to close this one in favor of the older PR if you want 🙃

@Mauin @DmytroTroynikov which PR now to merge oO. On the old one I was just waiting for the changes @schalkms requested to be added hmmm ... ? :)

@arturbosch Your call. I simply did not realize #426 was already there when I created this PR. I'll close this one. Feel free to reopen and merge if needed, but I did not intend to steal @DmytroTroynikov's first-time contribution 👍


fix spelling mistake in KDE Connect README.md

Hey @NL-TCH, Raphael asked to look into the approval process here.
It seems you have requested a review from yourself, so we are back to one review.
You should be able to approve the PR and then merge it yourself.

thanks for the message Daniel,
i approved the PR again, but still one official approval

Ok, I think I understand. It should work now, please try again.

yes, there are now 2 reviewers, so now i can merge. thanks
and sorry for cluttering up this PR :)


Uncaught TypeError: stream.setEncoding is not a function

I am trying to use this inside of a ReactJS framework, however I am presented with the error in the title. It is throwing an error on Line 46 of the deserializer.js file.
https://github.com/baalexander/node-xmlrpc/blob/master/lib/deserializer.js#L46
Relevent ReactJS Code:
`export default class ViewUsers extends React.Component {
componentDidMount(){
var xmlrpc = require('xmlrpc');
var clientOps = {
        host: 'dev.example.com',
        port: 8443,
        path: '/dev/xmlrpc',
        basic_auth: {
            user<EMAIL_ADDRESS>            pass: '123',
        }
};

var client = xmlrpc.createSecureClient(clientOps);
client.methodCall('view', ['3'], function (error, value) {
  if(error){
    console.log('error:', error);
    console.log('req headers:', error.req && error.req._header);
    console.log('res code:', error.res && error.res.statusCode);
    console.log('res body:', error.body);
  } else {
    console.log('value:', value);
  }
});

}
}
`
I just want to be able to get a successful call so I can display it in the render portion.

I was able to get past this by commenting out the two references to the setEncoding since I could not find the function specified in the SAX library and SAX defaults to UTF-8 which is what I need.

Same problem here at work with cordova + react.
From what I can tell, response.setEncoding is available with nodejs but not with http-browserify


Access output of lua commands

I am new to pynvim and I'm trying to replicate the use of LSP related commands using pynvim but I'm not able to determine how to get it to return the outputs of each commands. Below is a small repro for anyone to use:
I start a nvim instance using NVIM_LISTEN_ADDRESS=/tmp/nvim nvim in a different terminal
import pynvim

# Create a python API session attached to unix domain socket created above:
nvim = pynvim.attach('socket', path='/tmp/nvim')

nvim.chdir("root-path-to-my-system/oraladder") # the github repo is: https://github.com/ubitux/oraladder
# We clear the buffer and load a new file in it.
nvim.command("bd!")
nvim.command("e laddertools/test_glicko.py")
print(nvim.current.buffer[:])  # --> this works perfectly

nvim.current.window.cursor = (17, 17)
print(f"Cursor is at: {nvim.current.window.cursor}")
print(f"Current line: {nvim.current.line}")

nvim.exec_lua("vim.lsp.buf.definition()", async_=True)
# after this I should get some indication that the symbol was resolved but the cursor and line doesn't change when I try to print
# them but when I go and see the attached UI, I can notice that it has resolved the reference to the correct file.
print(f"Cursor is at: {nvim.current.window.cursor}")
print(f"Current line: {nvim.current.line}")
print(f"The buffer becomes: {nvim.current.buffer[:]}")

Can anyone help as to how I can get these outputs from pynvim?

Ah, sorry for that. I used async_ = False only but I was observing the same behaviour

Here's the output log for reference:
['import pytest', 'from .rankings.glicko import RankingGlicko, _RatingGlicko', '', 'import numpy', '', '', 'def test_glicko():', '    # Based on example from https://www.glicko.net/glicko/glicko2.pdf', '    me = _RatingGlicko(1500, 200, .06)', '    opponents = [', '        _RatingGlicko(1400, 30, .06),', '        _RatingGlicko(1550, 100, .06),', '        _RatingGlicko(1700, 300, .06),', '    ]', '    outcomes = [1, 0, 0]  # I won, then lost two', '', '    new_rating = RankingGlicko.compute_new_rating(', '        me, opponents, outcomes, tau=0.5, eps=1e-6', '    )', '', '    numpy.testing.assert_almost_equal(1464.06, new_rating.r, decimal=2)', '    numpy.testing.assert_almost_equal(151.52, new_rating.RD, decimal=2)', '    numpy.testing.assert_almost_equal(0.05999, new_rating.std, decimal=5)', '', '', 'def test_glicko_empty_period_will_increase_RD():', '    me = _RatingGlicko(1500, 345, std=1.0)', '    opponents = outcomes = []', '    new_rating = RankingGlicko.compute_new_rating(me, opponents, outcomes)', '    assert new_rating.RD == 350', '    assert new_rating.r == me.r  # should remain unchanged... Only increase RD']
Cursor is at: (17, 17)
Current line:     new_rating = RankingGlicko.compute_new_rating(
Cursor is at: (17, 17)
Current line:     new_rating = RankingGlicko.compute_new_rating(
The buffer becomes: ['import pytest', 'from .rankings.glicko import RankingGlicko, _RatingGlicko', '', 'import numpy', '', '', 'def test_glicko():', '    # Based on example from https://www.glicko.net/glicko/glicko2.pdf', '    me = _RatingGlicko(1500, 200, .06)', '    opponents = [', '        _RatingGlicko(1400, 30, .06),', '        _RatingGlicko(1550, 100, .06),', '        _RatingGlicko(1700, 300, .06),', '    ]', '    outcomes = [1, 0, 0]  # I won, then lost two', '', '    new_rating = RankingGlicko.compute_new_rating(', '        me, opponents, outcomes, tau=0.5, eps=1e-6', '    )', '', '    numpy.testing.assert_almost_equal(1464.06, new_rating.r, decimal=2)', '    numpy.testing.assert_almost_equal(151.52, new_rating.RD, decimal=2)', '    numpy.testing.assert_almost_equal(0.05999, new_rating.std, decimal=5)', '', '', 'def test_glicko_empty_period_will_increase_RD():', '    me = _RatingGlicko(1500, 345, std=1.0)', '    opponents = outcomes = []', '    new_rating = RankingGlicko.compute_new_rating(me, opponents, outcomes)', '    assert new_rating.RD == 350', '    assert new_rating.r == me.r  # should remain unchanged... Only increase RD']

After the invocation too the buffer and the cursor positions dont change in the sdk whereas in the connected UI I can see the new file opened and the cursor is at the resolved class reference.


Record shortWrites when forward

Thanks for providing such a good project. I am a golang beginner and I am not good at English. I am studying your code these days and found an uncertain problem.
According to my understanding, the lines 200-209 of forward.go, record will be send to conns and there is a judgments of success.  But at shortWrites statement (n < len(record)+1),
the length of prefix should be added? Sorry my poor English again.
code for now:
                record := s.Text()
		if n, err := fmt.Fprintf(conn, "%s%s\n", prefix, record); err != nil {
			disconnects.Inc()
			level.Warn(logger).Log("disconnected_from", target.String(), "due_to", err)
			break
		} else if n < len(record)+1 {
			shortWrites.Inc()
			level.Warn(logger).Log("short_write_to", target.String(), "n", n, "less_than", len(record)+1)
			break // TODO(pb): we should do something more sophisticated here
		}

code is it correct?
                record := fmt.Sprintf("%s%s\n", prefix, s.Text())
		if n, err := fmt.Fprintf(conn, record); err != nil {
			disconnects.Inc()
			level.Warn(logger).Log("disconnected_from", target.String(), "due_to", err)
			break
		} else if n < len(record) {
			shortWrites.Inc()
			level.Warn(logger).Log("short_write_to", target.String(), "n", n, "less_than", len(record))
			break // TODO(pb): we should do something more sophisticated here
		}

Yes! Good catch!


Added clustering github workflow

Signed-off-by: Petu Eusebiu<EMAIL_ADDRESS>
What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

need to change localstack with minio, as localstack seems to be very slow.

Also,
Complete requests:    0
Failed requests:      100

@peusebiu, disable logs ("output": "/dev/null") so that the output is clean and readable.


PCC not displaying installed GitHub org

Summary
In the PCC, after installing a github org, the PCC does not display it in the UI, even though the org looks to be correctly installed.

Changing the "organization_sfid" in the github-orgs table resolved the issue with displaying in the UI.
The 'organization_sfid" should probably never be the Linux Foundation or LF Projects, LLC

this was resolved by Harold with his PR and verified in prod


Match model id between last parenthesis only

IKEA FLOALT LED light panel, dimmable, white spectrum (30x90 cm) (L1528)

Fixed with #652


Added from_json_object_key? to UUID

Added the the required from_json_object_key? to UUID so that it can be used as a hash key.

@straight-shoota thx. just pushed spec test as well.


[docs] expand on sx performance tradeoff

Related page
https://mui.com/system/getting-started/usage/#performance-tradeoffs
Kind of issue
Missing information
Issue description
Helllo! Performance tradeoff page for sx prop lists a comparison between 4 ways of styling your components:

Benchmark case
Code snippet
Time normalized

a. 1,000 primitives

100ms

b. 1,000 components

112ms

c. 1,000 styled components


Exceeding the max request size throws unmeaning error

For example if I use productProjections and provide a huge where query so that the request exceeds the max request size, I get this error:
Unhandled rejection HttpError: Parse Error
    at ProductProjectionService.BaseService._wrapResponse (/Users/psporrer/code/sphere/sphere-product-import/node_modules/sphere-node-sdk/lib/services/base.js:404:21)
    at /Users/psporrer/code/sphere/sphere-product-import/node_modules/sphere-node-sdk/lib/services/base.js:331:40
    at /Users/psporrer/code/sphere/sphere-product-import/node_modules/sphere-node-sdk/lib/connect/rest.js:201:20
    at Request._callback (/Users/psporrer/code/sphere/sphere-product-import/node_modules/sphere-node-sdk/lib/connect/rest.js:159:14)
    at self.callback (/Users/psporrer/code/sphere/sphere-product-import/node_modules/request/request.js:360:22)
    at Request.emit (events.js:107:17)
    at Request.onRequestError (/Users/psporrer/code/sphere/sphere-product-import/node_modules/request/request.js:1008:8)
    at ClientRequest.emit (events.js:107:17)
    at TLSSocket.socketOnData (_http_client.js:322:9)
    at TLSSocket.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)
    at TLSSocket.Readable.push (_stream_readable.js:126:10)
    at TCP.onread (net.js:540:20)

This is very bad, since it toes not tell me at all that I exceeded the request size. I don't know if this actually happens because the API is not returning anything if the request is to big, or if the request is not even sent and this error is thrown by the request lib.
Right now the solution I use, is to process product imports one by one, which obviously results in a very bad performance.
We need to check the request size when the request is built up completely (also when everything is already urlencoded) in order to throw a meaningful error.

The error is coming from nginx, thus cannot be correctly parsed / mapped since it's not JSON. Nevertheless, we should handle this error yes. Simply add a case to handle 413 status codes.
PS: I'm not sure it's a good idea to manually check the request size, we can discuss this anyway.

Sometimes nginx does not return a response code at all but a html body with a description. urgs
Had the same problems in the JVM SDK.

Yeah, that might also be a problem. I think @svenmueller was considering configuring nginx to return a JSON response.

Yes, errors on nginx level (e.g. request body size limit exceeded) are currently always returned using HTML format. We need to adjust nginx to also return error using JSON.


Can prune model convert to llama.cpp ggml？

Hi, we have not tried to convert the pruned model to llama.cpp.


Fix overriding public property by auto-update

public value was hardcoded in two places in ImageDownload method:
https://github.com/lxc/lxd/blob/7973ab78af5fba6fa6610174ffb3c0bc7328f76e/lxd/daemon_images.go#L181
https://github.com/lxc/lxd/blob/7973ab78af5fba6fa6610174ffb3c0bc7328f76e/lxd/daemon_images.go#L460
I added new field Public to ImageDownloadArgs, so now information can be passed from outside method.
I hardcoded public value in one place:
https://github.com/lxc/lxd/blob/7973ab78af5fba6fa6610174ffb3c0bc7328f76e/lxd/instances_post.go#L102-L114
but I don't see case where image should be public during instance creation.
I also wonder can we use Secret field from ImageDownloadsArgs to distinguish is image public or not. @stgraber, What do you think?

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Change looks good. Indeed when creating an instance from an image, the image should be marked private as it's just a cached image.
As for relying on Secret, I don't think we can just use that as someone may want to copy a private image from a remote server but make it public on the target. In that case, we would have the secret set but will also want Public=true.
So I think the way you've done things should work fine.

jenkins: test this please


build: setup snapshot builds for experimental and new packages

Sets up snapshot builds for the experimental packages
Sets up snapshot builds for the new packages (google-maps, youtube-player)
Updates snapshot builds repositories to match package name. Similar to how it is done in
framework, and to improve consistency. This means that:

material2-builds becomes material-builds
material2-moment-adapter becomes material-moment-adapter.

We can do the rename because Github creates repository redirects. This should prevent breakages for people relying on the builds repositories. Though we never denoted those as public.
@jelbourn @josephperrott If we go with renaming these old build repositories for consistency, then the following things would need to be made:

Delete the newly created material-moment-adapter-builds repo.
Rename material2-moment-adapter-builds repo to material-moment-adapter-builds
Rename material2-builds to material-builds.

I am good with your proposal, but we should have @jelbourn sign off as well.

Updating github repos now, and then I will merge this PR.


Fix remaining mediascape issues

This issue keeps track of things that remain to be fixed in mediascape.
Let's check the boxes as they are fixed, and open new issues if things are more complex.

[ ] The piano doesn't play.
[ ] One of the drumsticks doesn't stick to your hand.
[ ] Not all guitars are grabbable correctly.
[ ] The sheet music and albums (on the piano) can't be picked up.
[ ] The camera (and photographs) aren't based on the mudball generator
[ ] #85
[ ] #87
[ ] Fix "teleportability" of various floor segments. Unsure whether this is best done by an overlay floor or by fixing the individual floor segments.

As of [a1a1cba], scene switching has stopped working, we cannot get to the stage from the museum. Both the "why not" button and the "go" button (on screen5 of the information panel) have stopped working. The "let's go" seems to be working correctly

We're getting a warning saying there are two event systems in the scene, havent noticed this before

Testing [a1a1cba], both direct and ray based interaction (grab and point) work but we can no longer interact with the heads up display

Costume size (or actually user size) should still be communicated to the other participants.

It's not only costume size (I think) but also "skeleton" positions and head position.
At the moment (October 2023) if you go to the stage with two participants both will see themselves somewhat reasonable (slight head offset), but the other participant much less natural (bigger head offset, joints bending the wrong way because something is wrong with size).
Maybe we should first investigate on master, with the simple animated Marie-antoinette.


File name changed to EmployeeAdder.aspx.cs

Category

[x] Content fix

Related issues:

fixes https://github.com/SharePoint/sp-dev-docs/issues/4771

What's in this Pull Request?
File name changed to EmployeeAdder.aspx.cs
Guidance
File name changed to EmployeeAdder.aspx.cs

Closing as I already took care of this.
In the future, when an issue is assigned to someone, better to NOT fix it or communicate that you're going to fix it so this doesn't happen in the future.


Freezes when JSON contains Emoji

Describe the bug
Freezes when JSON contains Emoji.
To Reproduce
Steps to reproduce the behavior:

Create JSON with any Emoji in it
Try to populate symbol
Freeze

Environment (please complete the following information):

macOS Version: 10.13.1
Sketch Version 48.2
Plugin Version 2.3.4

@lukasondrej might be an easy fix?


DAVE Sprint week 21

DAVE-38: ARF file
Reorganizing plots that are shown by default on start-up

Hello @pbalm! Thanks for updating the PR.

In the file src/main/python/model/dataset.py, following are the PEP8 issues :

Line 42:80: E501 line too long (107 > 79 characters)
Line 44:80: E501 line too long (88 > 79 characters)
Line 48:80: E501 line too long (103 > 79 characters)
Line 50:80: E501 line too long (110 > 79 characters)
Line 52:80: E501 line too long (88 > 79 characters)
Line 61:80: E501 line too long (86 > 79 characters)
Line 79:80: E501 line too long (94 > 79 characters)
Line 85:80: E501 line too long (119 > 79 characters)
Line 120:80: E501 line too long (101 > 79 characters)
Line 121:29: E128 continuation line under-indented for visual indent
Line 122:29: E128 continuation line under-indented for visual indent
Line 129:80: E501 line too long (81 > 79 characters)
Line 140:80: E501 line too long (92 > 79 characters)
Line 141:37: E128 continuation line under-indented for visual indent
Line 142:37: E128 continuation line under-indented for visual indent
Line 143:37: E128 continuation line under-indented for visual indent
Line 157:80: E501 line too long (112 > 79 characters)
Line 167:80: E501 line too long (83 > 79 characters)

In the file src/main/python/server.py, following are the PEP8 issues :

Line 47:80: E501 line too long (84 > 79 characters)
Line 52:80: E501 line too long (114 > 79 characters)
Line 57:80: E501 line too long (121 > 79 characters)
Line 63:13: E128 continuation line under-indented for visual indent
Line 63:80: E501 line too long (87 > 79 characters)
Line 64:80: E501 line too long (82 > 79 characters)
Line 70:13: E128 continuation line under-indented for visual indent
Line 70:80: E501 line too long (87 > 79 characters)
Line 77:13: E128 continuation line under-indented for visual indent
Line 77:80: E501 line too long (87 > 79 characters)
Line 78:80: E501 line too long (85 > 79 characters)
Line 84:13: E128 continuation line under-indented for visual indent
Line 85:80: E501 line too long (85 > 79 characters)
Line 90:80: E501 line too long (84 > 79 characters)
Line 91:13: E128 continuation line under-indented for visual indent
Line 91:80: E501 line too long (87 > 79 characters)
Line 92:80: E501 line too long (85 > 79 characters)
Line 98:13: E128 continuation line under-indented for visual indent
Line 103:80: E501 line too long (82 > 79 characters)
Line 104:13: E128 continuation line under-indented for visual indent
Line 110:13: E128 continuation line under-indented for visual indent
Line 110:80: E501 line too long (87 > 79 characters)
Line 111:80: E501 line too long (85 > 79 characters)
Line 112:80: E501 line too long (100 > 79 characters)
Line 118:13: E128 continuation line under-indented for visual indent
Line 119:80: E501 line too long (88 > 79 characters)
Line 120:80: E501 line too long (100 > 79 characters)
Line 121:80: E501 line too long (88 > 79 characters)
Line 122:80: E501 line too long (116 > 79 characters)
Line 128:13: E128 continuation line under-indented for visual indent
Line 128:80: E501 line too long (96 > 79 characters)
Line 169:80: E501 line too long (88 > 79 characters)
Line 174:80: E501 line too long (98 > 79 characters)

In the file src/main/python/utils/dataset_helper.py, following are the PEP8 issues :

Line 15:80: E501 line too long (96 > 79 characters)
Line 23:42: E211 whitespace before '('
Line 36:80: E501 line too long (96 > 79 characters)
Line 45:46: E211 whitespace before '('
Line 71:43: E261 at least two spaces before inline comment
Line 71:44: E262 inline comment should start with '# '
Line 71:80: E501 line too long (111 > 79 characters)
Line 134:36: E211 whitespace before '('
Line 136:26: E127 continuation line over-indented for visual indent
Line 138:25: E127 continuation line over-indented for visual indent
Line 141:36: E211 whitespace before '('
Line 150:80: E501 line too long (82 > 79 characters)
Line 154:80: E501 line too long (82 > 79 characters)
Line 157:44: E211 whitespace before '('
Line 158:44: E211 whitespace before '('
Line 164:22: E211 whitespace before '('
Line 168:1: E265 block comment should start with '# '
Line 171:24: E703 statement ends with a semicolon
Line 171:80: E501 line too long (94 > 79 characters)
Line 213:80: E501 line too long (96 > 79 characters)
Line 216:80: E501 line too long (102 > 79 characters)
Line 220:80: E501 line too long (99 > 79 characters)
Line 225:80: E501 line too long (93 > 79 characters)
Line 230:37: E211 whitespace before '('
Line 230:80: E501 line too long (82 > 79 characters)
Line 240:36: E211 whitespace before '('
Line 240:80: E501 line too long (84 > 79 characters)
Line 241:33: E128 continuation line under-indented for visual indent
Line 241:80: E501 line too long (100 > 79 characters)
Line 246:80: E501 line too long (98 > 79 characters)
Line 248:80: E501 line too long (91 > 79 characters)
Line 274:80: E501 line too long (89 > 79 characters)
Line 290:80: E501 line too long (92 > 79 characters)
Line 292:30: E225 missing whitespace around operator
Line 293:27: E225 missing whitespace around operator
Line 297:80: E501 line too long (172 > 79 characters)
Line 300:18: E211 whitespace before '('
Line 304:12: E713 test for membership should be 'not in'

In the file src/main/python/utils/dave_endpoint.py, following are the PEP8 issues :

Line 42:1: E265 block comment should start with '# '
Line 43:1: E302 expected 2 blank lines, found 1
Line 45:80: E501 line too long (83 > 79 characters)
Line 50:80: E501 line too long (99 > 79 characters)
Line 56:80: E501 line too long (86 > 79 characters)
Line 59:35: E261 at least two spaces before inline comment
Line 59:80: E501 line too long (99 > 79 characters)
Line 67:80: E501 line too long (81 > 79 characters)
Line 93:80: E501 line too long (83 > 79 characters)
Line 127:80: E501 line too long (91 > 79 characters)
Line 151:80: E501 line too long (109 > 79 characters)
Line 158:80: E501 line too long (83 > 79 characters)
Line 181:80: E501 line too long (101 > 79 characters)
Line 188:80: E501 line too long (88 > 79 characters)
Line 212:80: E501 line too long (106 > 79 characters)
Line 219:80: E501 line too long (82 > 79 characters)
Line 234:80: E501 line too long (97 > 79 characters)
Line 241:80: E501 line too long (108 > 79 characters)
Line 265:80: E501 line too long (126 > 79 characters)
Line 284:80: E501 line too long (86 > 79 characters)
Line 286:80: E501 line too long (84 > 79 characters)
Line 300:80: E501 line too long (82 > 79 characters)
Line 302:80: E501 line too long (91 > 79 characters)
Line 307:80: E501 line too long (124 > 79 characters)
Line 334:80: E501 line too long (142 > 79 characters)
Line 341:80: E501 line too long (89 > 79 characters)
Line 342:80: E501 line too long (89 > 79 characters)
Line 345:4: E111 indentation is not a multiple of four
Line 346:4: E111 indentation is not a multiple of four
Line 347:8: E111 indentation is not a multiple of four
Line 349:4: E111 indentation is not a multiple of four
Line 350:4: E111 indentation is not a multiple of four
Line 351:8: E111 indentation is not a multiple of four
Line 352:8: E111 indentation is not a multiple of four
Line 353:12: E111 indentation is not a multiple of four
Line 353:80: E501 line too long (80 > 79 characters)
Line 355:4: E111 indentation is not a multiple of four
Line 356:4: E111 indentation is not a multiple of four
Line 357:8: E111 indentation is not a multiple of four
Line 358:8: E111 indentation is not a multiple of four
Line 359:12: E111 indentation is not a multiple of four
Line 361:4: E111 indentation is not a multiple of four
Line 362:4: E111 indentation is not a multiple of four
Line 363:8: E111 indentation is not a multiple of four
Line 365:4: E111 indentation is not a multiple of four
Line 366:4: E111 indentation is not a multiple of four
Line 367:8: E111 indentation is not a multiple of four
Line 368:8: E111 indentation is not a multiple of four
Line 369:12: E111 indentation is not a multiple of four
Line 369:80: E501 line too long (80 > 79 characters)
Line 371:4: E111 indentation is not a multiple of four
Line 372:4: E111 indentation is not a multiple of four
Line 373:8: E111 indentation is not a multiple of four
Line 374:8: E111 indentation is not a multiple of four
Line 375:12: E111 indentation is not a multiple of four
Line 377:4: E111 indentation is not a multiple of four
Line 378:4: E111 indentation is not a multiple of four
Line 379:4: E111 indentation is not a multiple of four
Line 380:4: E111 indentation is not a multiple of four
Line 381:4: E111 indentation is not a multiple of four
Line 382:4: E111 indentation is not a multiple of four
Line 383:4: E111 indentation is not a multiple of four
Line 384:4: E111 indentation is not a multiple of four
Line 385:4: E111 indentation is not a multiple of four
Line 386:4: E111 indentation is not a multiple of four
Line 387:4: E111 indentation is not a multiple of four
Line 388:4: E111 indentation is not a multiple of four
Line 389:4: E111 indentation is not a multiple of four
Line 390:4: E111 indentation is not a multiple of four
Line 391:4: E111 indentation is not a multiple of four
Line 393:4: E111 indentation is not a multiple of four
Line 393:80: E501 line too long (115 > 79 characters)
Line 394:80: E501 line too long (115 > 79 characters)
Line 397:4: E111 indentation is not a multiple of four
Line 399:4: E111 indentation is not a multiple of four
Line 402:80: E501 line too long (99 > 79 characters)
Line 431:80: E501 line too long (120 > 79 characters)

In the file src/main/python/utils/dave_engine.py, following are the PEP8 issues :

Line 43:80: E501 line too long (80 > 79 characters)
Line 46:17: E265 block comment should start with '# '
Line 51:13: E265 block comment should start with '# '
Line 52:80: E501 line too long (99 > 79 characters)
Line 53:80: E501 line too long (111 > 79 characters)
Line 55:80: E501 line too long (87 > 79 characters)
Line 56:80: E501 line too long (81 > 79 characters)
Line 57:80: E501 line too long (86 > 79 characters)
Line 79:80: E501 line too long (84 > 79 characters)
Line 84:80: E501 line too long (124 > 79 characters)
Line 85:80: E501 line too long (118 > 79 characters)
Line 85:85: E128 continuation line under-indented for visual indent
Line 86:80: E501 line too long (119 > 79 characters)
Line 86:85: E128 continuation line under-indented for visual indent
Line 97:55: E261 at least two spaces before inline comment
Line 97:80: E501 line too long (97 > 79 characters)
Line 98:50: E261 at least two spaces before inline comment
Line 118:80: E501 line too long (92 > 79 characters)
Line 123:80: E501 line too long (85 > 79 characters)
Line 179:80: E501 line too long (84 > 79 characters)
Line 191:80: E501 line too long (85 > 79 characters)
Line 198:80: E501 line too long (94 > 79 characters)
Line 200:80: E501 line too long (87 > 79 characters)
Line 229:80: E501 line too long (89 > 79 characters)
Line 245:80: E501 line too long (85 > 79 characters)
Line 249:80: E501 line too long (128 > 79 characters)
Line 251:80: E501 line too long (111 > 79 characters)
Line 260:13: E265 block comment should start with '# '
Line 263:80: E501 line too long (82 > 79 characters)
Line 269:9: E265 block comment should start with '# '
Line 298:80: E501 line too long (80 > 79 characters)
Line 320:80: E501 line too long (114 > 79 characters)
Line 324:80: E501 line too long (92 > 79 characters)
Line 325:80: E501 line too long (96 > 79 characters)
Line 338:80: E501 line too long (91 > 79 characters)
Line 339:1: E265 block comment should start with '# '
Line 339:80: E501 line too long (85 > 79 characters)
Line 352:80: E501 line too long (109 > 79 characters)
Line 373:80: E501 line too long (95 > 79 characters)
Line 375:13: E265 block comment should start with '# '
Line 376:80: E501 line too long (80 > 79 characters)
Line 380:80: E501 line too long (121 > 79 characters)
Line 387:80: E501 line too long (134 > 79 characters)
Line 391:80: E501 line too long (161 > 79 characters)
Line 401:80: E501 line too long (117 > 79 characters)
Line 403:80: E501 line too long (117 > 79 characters)
Line 424:80: E501 line too long (81 > 79 characters)
Line 439:80: E501 line too long (89 > 79 characters)
Line 447:80: E501 line too long (89 > 79 characters)
Line 453:44: E261 at least two spaces before inline comment
Line 455:80: E501 line too long (94 > 79 characters)
Line 456:80: E501 line too long (157 > 79 characters)
Line 458:80: E501 line too long (94 > 79 characters)
Line 459:80: E501 line too long (94 > 79 characters)
Line 460:80: E501 line too long (82 > 79 characters)
Line 461:80: E501 line too long (82 > 79 characters)
Line 463:48: E225 missing whitespace around operator
Line 464:60: E225 missing whitespace around operator
Line 467:80: E501 line too long (93 > 79 characters)
Line 478:80: E501 line too long (100 > 79 characters)
Line 479:80: E501 line too long (88 > 79 characters)
Line 493:1: E265 block comment should start with '# '
Line 513:13: E265 block comment should start with '# '
Line 520:80: E501 line too long (159 > 79 characters)
Line 521:77: E128 continuation line under-indented for visual indent
Line 521:80: E501 line too long (91 > 79 characters)
Line 526:80: E501 line too long (86 > 79 characters)
Line 550:80: E501 line too long (125 > 79 characters)
Line 570:80: E501 line too long (103 > 79 characters)
Line 576:40: E211 whitespace before '('
Line 581:9: E265 block comment should start with '# '
Line 583:9: E265 block comment should start with '# '
Line 584:80: E501 line too long (86 > 79 characters)
Line 592:20: E711 comparison to None should be 'if cond is not None:'
Line 636:80: E501 line too long (98 > 79 characters)
Line 637:80: E501 line too long (98 > 79 characters)
Line 664:80: E501 line too long (109 > 79 characters)
Line 670:41: E211 whitespace before '('
Line 673:80: E501 line too long (109 > 79 characters)
Line 679:41: E211 whitespace before '('
Line 683:27: E711 comparison to None should be 'if cond is not None:'
Line 684:27: E711 comparison to None should be 'if cond is not None:'
Line 693:16: E711 comparison to None should be 'if cond is not None:'
Line 695:29: E127 continuation line over-indented for visual indent
Line 701:9: E265 block comment should start with '# '
Line 703:9: E265 block comment should start with '# '
Line 704:80: E501 line too long (96 > 79 characters)
Line 712:13: E265 block comment should start with '# '
Line 717:21: E711 comparison to None should be 'if cond is not None:'
Line 717:80: E501 line too long (81 > 79 characters)
Line 719:21: E711 comparison to None should be 'if cond is not None:'
Line 719:80: E501 line too long (81 > 79 characters)
Line 744:1: E265 block comment should start with '# '
Line 753:80: E501 line too long (103 > 79 characters)
Line 756:26: E225 missing whitespace around operator
Line 763:80: E501 line too long (85 > 79 characters)
Line 775:80: E501 line too long (96 > 79 characters)
Line 778:80: E501 line too long (80 > 79 characters)
Line 778:80: E703 statement ends with a semicolon
Line 779:80: E501 line too long (108 > 79 characters)
Line 780:80: E501 line too long (109 > 79 characters)
Line 782:80: E501 line too long (85 > 79 characters)
Line 787:80: E501 line too long (80 > 79 characters)
Line 791:80: E501 line too long (92 > 79 characters)
Line 807:5: E265 block comment should start with '# '
Line 808:80: E501 line too long (97 > 79 characters)
Line 810:80: E501 line too long (119 > 79 characters)
Line 815:80: E501 line too long (85 > 79 characters)
Line 821:80: E501 line too long (85 > 79 characters)
Line 823:80: E501 line too long (97 > 79 characters)
Line 826:80: E501 line too long (93 > 79 characters)
Line 830:80: E501 line too long (111 > 79 characters)
Line 836:80: E501 line too long (105 > 79 characters)
Line 837:80: E501 line too long (101 > 79 characters)
Line 838:80: E501 line too long (83 > 79 characters)
Line 842:80: E501 line too long (111 > 79 characters)
Line 845:80: E501 line too long (121 > 79 characters)
Line 853:26: E211 whitespace before '('
Line 860:41: E211 whitespace before '('
Line 862:36: E261 at least two spaces before inline comment
Line 864:48: E225 missing whitespace around operator
Line 877:26: E211 whitespace before '('
Line 880:80: E501 line too long (92 > 79 characters)
Line 884:80: E501 line too long (94 > 79 characters)
Line 898:80: E501 line too long (95 > 79 characters)
Line 902:80: E501 line too long (81 > 79 characters)
Line 904:9: E125 continuation line with same indent as next logical line
Line 910:80: E501 line too long (140 > 79 characters)
Line 911:80: E501 line too long (109 > 79 characters)
Line 914:9: E265 block comment should start with '# '
Line 916:40: E211 whitespace before '('
Line 922:80: E501 line too long (99 > 79 characters)
Line 925:80: E501 line too long (98 > 79 characters)
Line 931:80: E501 line too long (92 > 79 characters)
Line 936:47: E211 whitespace before '('
Line 936:80: E501 line too long (142 > 79 characters)
Line 939:80: E501 line too long (115 > 79 characters)
Line 940:80: E501 line too long (127 > 79 characters)
Line 947:80: E501 line too long (85 > 79 characters)
Line 951:80: E501 line too long (80 > 79 characters)
Line 958:80: E501 line too long (91 > 79 characters)
Line 974:30: E211 whitespace before '('
Line 979:59: E211 whitespace before '('
Line 979:80: E501 line too long (86 > 79 characters)
Line 983:1: E302 expected 2 blank lines, found 1
Line 988:80: E501 line too long (93 > 79 characters)

In the file src/main/python/utils/dave_reader.py, following are the PEP8 issues :

Line 14:10: E225 missing whitespace around operator
Line 16:1: E302 expected 2 blank lines, found 1
Line 48:9: E265 block comment should start with '# '
Line 56:80: E501 line too long (94 > 79 characters)
Line 57:48: E128 continuation line under-indented for visual indent
Line 58:48: E128 continuation line under-indented for visual indent
Line 58:80: E501 line too long (95 > 79 characters)
Line 62:80: E501 line too long (101 > 79 characters)
Line 63:57: E128 continuation line under-indented for visual indent
Line 63:80: E501 line too long (91 > 79 characters)
Line 74:80: E501 line too long (82 > 79 characters)
Line 75:65: E231 missing whitespace after ','
Line 75:80: E501 line too long (85 > 79 characters)
Line 89:80: E501 line too long (84 > 79 characters)
Line 117:80: E501 line too long (81 > 79 characters)
Line 121:80: E501 line too long (93 > 79 characters)
Line 148:36: E128 continuation line under-indented for visual indent
Line 149:36: E128 continuation line under-indented for visual indent
Line 174:80: E501 line too long (88 > 79 characters)
Line 175:37: E128 continuation line under-indented for visual indent
Line 176:37: E128 continuation line under-indented for visual indent
Line 181:80: E501 line too long (110 > 79 characters)
Line 185:80: E501 line too long (119 > 79 characters)
Line 186:80: E501 line too long (96 > 79 characters)
Line 188:80: E501 line too long (87 > 79 characters)
Line 201:80: E501 line too long (83 > 79 characters)
Line 202:45: E128 continuation line under-indented for visual indent
Line 202:80: E501 line too long (83 > 79 characters)
Line 204:5: E265 block comment should start with '# '
Line 217:30: E128 continuation line under-indented for visual indent
Line 218:30: E128 continuation line under-indented for visual indent
Line 220:80: E501 line too long (98 > 79 characters)
Line 221:69: E127 continuation line over-indented for visual indent
Line 221:80: E501 line too long (84 > 79 characters)
Line 223:80: E501 line too long (91 > 79 characters)
Line 234:80: E501 line too long (93 > 79 characters)

In the file src/test/python/test/utils/test_dave_engine.py, following are the PEP8 issues :

Line 69:80: E501 line too long (84 > 79 characters)
Line 88:80: E501 line too long (105 > 79 characters)
Line 104:80: E501 line too long (105 > 79 characters)
Line 107:80: E501 line too long (88 > 79 characters)
Line 108:80: E501 line too long (88 > 79 characters)

In the file src/test/python/test/utils/test_dave_reader.py, following are the PEP8 issues :

Line 74:80: E501 line too long (84 > 79 characters)
Line 83:80: E501 line too long (90 > 79 characters)
Line 88:80: E501 line too long (104 > 79 characters)
Line 89:49: E128 continuation line under-indented for visual indent
Line 89:80: E501 line too long (86 > 79 characters)

The work in this PR has been included in PR 44 too, so I'll close this PR. We will merge that work in PR 44.


Expressions inside template literals not properly minified

`${ a + b }`

The whitespace on either side of a + b is removed, but the main expression itself is not minified.

Fixed in 0.3.6


Add : Rubic cube game

The Rubik's Cube game is a fully functional implementation of the classic puzzle, designed to provide an immersive and engaging experience for users. The game incorporates the standard Rubik's Cube mechanics, allowing players to rotate the different layers of the cube to solve it.

So, please assign this to me under GSSOC'23.

Hi @Pragati-3003 ,
could you please elaborate on the features of the game with full details, demo / mock UI sample/Video,? better share detailed documentation.


Call to undefined function imagepng()

There is no function called imagepng() in Code128Barcode.php

I believe you need to either enable or install the GD library for PHP.


How to disable formatting while adding long primitve

I am doing the following code in lettuce:
RedisClient client;
RedisAsyncCommands<String, String> asyncCommands;
asyncCommands.zadd(reqUserId, System.currentTimeMillis(), "{"a:")");
//System.currentTimeMillis()=1450110314264
if you monitor on Redis you get that:
1450109792.349288 [0 <IP_ADDRESS>:64872] "ZADD" "history:171" "1.450109792341E12" "{"a:")"
look at System.currentTimeMillis(). it formatted it into "1.450109792341E12"
When I tried to store is as plain String:
RedisFuture futureResult = asyncCommands.zadd(reqUserId, "1450110314264", "{"a:")");
I get exception:
java.lang.String cannot be cast to java.lang.Double
java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Double
Any idea?
Thanks.

Hi @IdanFridman
that's just a formatting issue of the MONITOR command. The score must be numeric and not a string. I reproduced your code and got the following result:
<IP_ADDRESS>:6479> monitor
1450125025.857462 [0 <IP_ADDRESS>:64626] "ZADD" "key" "1.450125025851E12" "member"
1450125025.865902 [0 <IP_ADDRESS>:64626] "ZRANGE" "key" "0" "-1" "WITHSCORES"

...

<IP_ADDRESS>:6479> zrange key  0 -1 WITHSCORES
1) "member"
2) "1450125025851"

If you retrieve the entries from the sorted set (e.g. with zrangeWithScores) you'll see the numeric value is the one you put into the sorted set entry.

You were right. my bad! thank you.


How to customize the search, like calling search function only when user typed search?

Hey, can you provide more details on how you're using st_searchbox? the search function should only be called when the user is typing something, e.g.
import streamlit as st

from streamlit_searchbox import st_searchbox

def search(searchterm: str):
    # this will only be called when the user types something
    print(f"searching for {searchterm}")
    return [f"{searchterm}_{i}" for i in range(10)]

result = st_searchbox(search_function=search, key="search_key")

st.write(result)

In case it's related, I am seeing the same as kranthi419. Looking at the sample code above, this works and waits for the user to hit enter ...
result = st_searchbox(search_function=search, key="search_key")
But this executes as soon as the user types ...
result = st_searchbox(search_function=search, key="search_key", default_use_searchterm=True)
My use case needs the user to be able to enter their own search queries, like google.


Add Telemetry processors

:+1:

I thought telemetry initializers already behaving like processors. If you return false from initializer - it will stop processing of the item and will not send it. Why processors?

@SergeyKanzhelev telemetry initializes are implemented in JavaScript SDK and they are not available in Node.js SDK.
I thought that "processor" is a batter name in this case. They process already populated telemetry, so they don't do any "initialization".

@kamilszostak , got it. Thanks for explanation. It makes sense


Invalid initial heap size on extras 1.12.7

We tried to move from 1.11.8 to 1.12.7 today. We've been having inconsistent test results on 1.11.8, and we're not sure this will help, but we decided to try.
Also went from firefox 42.0 to 44.0
We run the grid on Ubuntu 14.04 in AWS. Supervisor is the process manager we use to execute the extras jar.
On both nodes and hub supervisor was was able to run the main extras jar without error, but in the grid_extras log we got:
 command: /usr/lib/jvm/jdk1.8.0_91/jre/bin/java -Xms256m -Xmx4g -DPOOL_MAX=1024  -cp /usr/share/selenium-extras/SeleniumGridExtras-1.12.7-SNAPSHOT-jar-with-dependencies.jar:/tmp/webdriver/2.53.1.jar org.openqa.grid.selenium.GridLauncher -role hub -log log/hub_4444.log -hubConfig hub_4444.json
 exit code: 1
 standard error:
 Invalid initial heap size: -Xms256m -Xmx4g -DPOOL_MAX=1024
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

I don't believe there is actually a problem with initial heap size, that config didn't change (I have "grid_jvm_x_options": "-Xms256m -Xmx4g -DPOOL_MAX=1024"), and it's the same instance. But I was not able to determine the issue.
I was actually able to run the command printed there manually, and it worked.
Any ideas?

Do you get this error on 1.12.2 ? I know with one of the recent version (1.12.4 - 1.12.7), we did some changes around generating the hub and node commands. We now use a String array with Runtime.getRuntime().exec() (instead of String).

@ethan-eb I think I fixed this in master. Can you perhaps build from master ( mvn clean install -DskipTests ), and try this out? I don't know when I'll have time to check myself. If you tell me this works, I will create a new build.
Thank you.

Yes! that works! If you could make a build with that change it would be great, thanks!

https://github.com/groupon/Selenium-Grid-Extras/releases/tag/v1.12.8
@ethan-eb Please try this release.

Marking as closed. Please re-open if still an issue. Thank you.
@ethan-eb


remove $ from is?

is: 'email' is nicer than is: '$email'
also remove from default translations

done


Hs/use room member state

Fixes #80

This PR is tested in production and live on t2bot.io. Confirmed working as intended, and no unexpected consequences.


docs: add kitty-kitten-search alternative

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[HUDI-756] Organize Cleaning Action execution into a single package in hudi-client

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Beginning work to clean up code spread around in hudi-client
Brief change log

Introduced a thin abstraction ActionExecutor, that all actions will implement
Pulled cleaning code from table, writeclient into a single package
CleanHelper is now CleanPlanner, HoodieCleanClient is no longer around
Minor refactor of HoodieTable factory method
HoodieTable.create() methods with and without metaclient passed in
HoodieTable constructor now does not do a redundant instantiation
Fixed existing unit tests to work at the HoodieWriteClient level

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

cc @yanghua @hddong if we do more of these.. then the multi engine work will be easier in the sense that HoodieWriteClient and Table classes have straightforward code and you don't have to care as much about all the action execution code ..

Codecov Report

Merging #1485 into master will increase coverage by 0.05%.
The diff coverage is 87.61%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575d87c...eee91fa. Read the comment docs.

Introduced a thin abstraction ActionExecutor, that all actions will implement

+1

+1, make it easier and organized.


Plenty of errors while trying to make it work

Hello,
I would like to see how this project compare with TransNetV2, but I had to give up because the errors are so many to a point that I'm unable to fix them anymore.
Tried with Python 3.10 (and anaconda 3.9.2).
python osg_vsd_train.py:
ImportError: cannot import name 'container_abcs' from 'torch._six'
I fixed this by replacing from torch._six import container_abcs, string_classes, int_classes  with
import collections.abc as container_abcs
from torch._six import string_classes

and elif isinstance(elem, int_classes): with elif isinstance(elem, int):
Then I got:
RuntimeError: Attempted to set the storage of a tensor on device "cuda:0" to a storage on different device "cpu".  This is no longer allowed; the devices must match.
Not sure if I have done the right changes, but I also managed to find a workaround by replacing storage = elem.storage()._new_shared(numel) with storage = elem.storage()._new_shared(numel, device=torch.device("cuda"))
Finally I have been able to start the training, but (probably before completion) I got:
Triggered internally at ..\torch\csrc\utils\tensor_new.cpp:233.)
  return torch.tensor(the_file['x'], dtype=torch.float, device=self.device), torch.tensor(the_file['t'], dtype=torch.float, device=self.device)
Traceback (most recent call last):
  File "C:\Users\user\Downloads\LearnableOSG\osg_vsd_train.py", line 89, in <module>
    CLossTest(num_iters=5)
  File "C:\Users\user\Downloads\LearnableOSG\osg_vsd_train.py", line 75, in CLossTest
    D_temp = OSG_model.module.DIST_FUNC(x_orig.unsqueeze(0))
  File "C:\Users\user\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1269, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'OSG_C' object has no attribute 'module'. Did you mean: 'modules'?

I have no idea on how to fix this. Error popup after around 30 minutes of training and progress are not cached. Therefore I can't even attempt to play with code because I would have to wait so much time for each minor change.
Any help would be appreciated.
Many thanks

Hi @netcorefan1 ,
Thanks for taking an interest in our work!
I'll point out first of all, that TransNetV2 performs Shot Boundary Detection (grouping together frames which were taken from the same camera at the same time), while this repo is intended for Video Scene Detection (grouping shots together which depict a particular story element or high level concept). VSD assumes that the video is already divided into shots.
If you're still interested in this repo:

Regarding the import errors, did you try using the yaml environment file? Since the python ver there is 3.9.2. Please let me know if you have import errors when installing the environment from the yaml file.
Could you please revert your elem.storage change and paste the entire error? I'm guessing it's just a device cast I forgot.
The missing attribute module I believe is a leftover from when I trained it using DDP (highly recommended BTW if you have the infastructure). I believe just removing it should work. I.e.: D_temp = OSG_model.DIST_FUNC(x_orig.unsqueeze(0)). I'll test and push a fix.

The repo is bare-boned and was intended to be integrated into your own work (importing the OSG_C as a model in a pipeline). If you're planning to run it as-is, then adding periodic torch.save for the model and optimizer states, adding logging, setting up train vs eval data, would definitely be useful.

Many thanks for your response and sorry for my delay.
Thanks for your detailed explanation. If I have understood well, it sounds like they both could complement each other and this sound very interesting.
I followed your suggestion and installed Anaconda which provide the same python version. However, before doing this I performed some system upgrades which include my Nvidia card drivers and related SDK toolsets and during the compilation of your project I got an error with PyTorch related to my card. I'm on Cuda 12 and the latest cuda version supported by PyTorch is 11.7.. I suppose this is the source of the problem. I will have to compile the whole torch stuff myself and seem pretty problematic.
As soon as I manage to complete this task I will post my results.
I plan to integrate this into my own project by removing any Python stuff and load the model directly in OpenCv. However, I'm afraid I still need a working LearnableOSG running on python for prototyping and translate the relevant code. If you have some suggestion, please let me know.


Fix NPE when async ES client is nested within Hibernate search

Closes #1528
When ES client is used within Hibernate search, the helper code produces a null span as we don't allow nested exit spans.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [Pull request #1531 opened]

Start Time: 2020-11-24T12:50:46.783+0000

Duration: 48 min 34 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
1617

Skipped
12

Total
1629


Docs: use this action in the repo itself?

I was spelunking through permissions issues (https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues/300) and wanted to see how this repo sets up its permissions: / GHA tokens. But couldn't find it. Dogfooding the action in the action's repo feels like a good example to set, yeah? 😄

Probably something worth doing :-)  I think you shouldn't have to actually set the token more often than not.
Let me know if you feel like making a PR - most of the work will be wording the comment messages in a way that makes sense and updating the Contributing Guide to reflect the change.

Hmm in that case can I defer to you on adding the action? I have a reference file on https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/8968813984bd9dc40339af9332c51197eb177324/.github/workflows/compliance.yml but don't feel confident in wordcrafting for this repo.


Whether the loadbalancer has the function of monitoring the offline change of the registration center node

Describe the bug
When I call the restarted service, the client-side cache service list will cause the call to the offline service. Is there a function like monitoring the registry service changes and automatically refreshing the local cache?
I currently have client side caching disabled,thanks
spring.cloud.loadbalancer.cache.enabled:false
version: spring cloud :2020.0.1
Sample
no Sample

@weihubeats Yes, there is. Please take a look at the docs.


Fix E2E test setup on non-linux machines

Fixes #2409. Not sure if this is a direction you want to go, but those changes allow me to run E2E tests locally (using an Apple M1 machine).
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[ ] All tests pass with make test
[ ] I ensured my PR is ready for review with make reviewable

/ok-to-test sha=0bb6ad5