fix: remove "type": "module" from vitest/package.json

Projects whose tsconfig.json contains module or moduleResolution value of nodenext or node16 cannot import vitest in their *.spec.ts files without getting a TypeScript error about Vitest being incompatible with CommonJS.
Module 'vitest' cannot be imported using this construct. The specifier only resolves to an ES module, which cannot be imported synchronously. Use dynamic import instead. ts(1471)

But in this case, TypeScript is reporting a false positive. Vitest compiles the *.spec.ts files, so it's not a problem that Vitest only has an ESM entry point.
Therefore, we should remove "type": "module" from vitest/package.json to appease TypeScript. As a result, we also need to use .mjs extensions for Vitest's compiled files, since they use import/export syntax.
Closes #325

I don't think this would be a long-term solution. Isn't that a config issue, or a issue of TypeScript?

Hello, I think this issue is related to this one: https://github.com/vitest-dev/vitest/pull/1417
I'm also using "module": "nodenext " in TypeScript.
In my opinion, if you want to write your package as ESM with "type": "module", you should comply with ESM requirement of writing your import/export of local files with their full path, including the .js extension. You'll produce compiled code that will be both compatible with ESM/CJS.
I'm working on a little monorepo which is ESM first with TypeScript for experiment/demo purpose and I've already encountered the same issue here: https://github.com/tinyhttp/tinyhttp/pull/359

I don't think this would be a long-term solution. Isn't that a config issue, or an issue of TypeScript?

I think so too. We had an issue that was fixed by #1417, but I think that's it? Removing type: "module" is just a workaround, TypeScript should work either way.

Isn't using "type": "module" vs using .mjs extensions just a preference, or is there extra benefit to using the former?

It seems these two are interchangable. Am I wrong?

I don't see it as TypeScript's issue. The type field of package.json defaults to commonjs, but even CJS projects should be able to use Vitest. Unfortunately, when using nodenext or node16 module resolution, there is no tsconfig setting that tells TypeScript that test files are not CJS files.
Since Vitest does support TypeScript projects that compile to CJS (as well as TS projects that compile to ESM but don't have "type": "module" in their package.json), it falls on Vitest to avoid this issue.

It seems these two are interchangable. Am I wrong?

You are not wrong. Truth be told, to run Vitest we don't even need it to be .mjs, because we run it through ViteNode, but it's better to stick with the standards.

I don't see it as TypeScript's issue.

Thank you for your explanation. This is more a configure issue. You have a single tsconfig for you source code and for your tests, which is understandable. As I understand it, TypeScript thinks it will transform import to require, and because of that it gives you an error, because it thinks it will fail at runtime (but that runtime doesn't actually happen, since tests are run with ViteNode, and not ts-node and/or compiled js). I see two ways out:

Separate tsconfig for tests, which is not ideal for DX, and hurts commonjs Node projects
We apply your workaround to trick TypeScript into thinking everything is ok, which is better for the DX, because developer doesn't need to think about it

As you might have guessed I prefer the second option, since for us DX has the highest priority.

I see two ways out

Maybe there is a third:

Just add require field, pointing to the same file. This will fail when importing in Node, but will work when running Vitest, which is the important part.

3. Just add require field, pointing to the same file.

That was the first thing I tried, but it doesn't help. The "type": "module" field in Vitest's package.json is the issue.

That was the first thing I tried, but it doesn't help. The "type": "module" field in Vitest's package.json is the issue.

I guess it might not work bellow TypeScript 4.7, where they added support for exports field? Which removes this option as potential fix, yeah.

Truth be told, to run Vitest we don't even need it to be .mjs, because we run it through ViteNode, but it's better to stick with the standards.

I tried not using .mjs and it didn't work.
This happens when I run pnpm vitest.
(node:55373) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/dev/vitest-nodenext/node_modules/.pnpm/vitest@0.13.1/node_modules/vitest/dist/cli.js:1
import { EventEmitter } from 'events';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1033:15)
    at Module._compile (node:internal/modules/cjs/loader:1069:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:170:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:409:24)

Node.js v18.0.0

I guess it might not work bellow TypeScript 4.7, where they added support for exports field? Which removes this option as potential fix, yeah.

It doesn't work in 4.7+ either. TypeScript detects "type": "module" and assumes the package is ESM only.

Truth be told, to run Vitest we don't even need it to be .mjs, because we run it through ViteNode, but it's better to stick with the standards.

I tried not using .mjs and it didn't work.

Yeah, what I said is only true for index part, from where you import stuff in your tests. Everything else should have appropriate extension.

It doesn't work in 4.7+ either. TypeScript detects "type": "module" and assumes the package is ESM only.

Then this is a bug in TypeScript, if my assumptions about transforming require -> import is true. Because error "the specifier only resolves to an ES module" would not be true. The specifier has a require field, which means it can be imported synchronously.

I've opened an issue on the TypeScript repo
https://github.com/microsoft/TypeScript/issues/49391

This is a rare enough edge case that Vitest should just work around it, instead of expecting TypeScript to support it. It's extremely rare that a package is ESM only but still allows CJS modules to import it. Of course, in reality, test files are not really CJS modules, but nonetheless, that's what TypeScript thinks. The work around isn't a big deal anyway, so the TypeScript team will probably kick the can down the road instead of quickly pushing a fix.

Why is Vitest not compiling .cjs files? Do you want it to be pure ESM only? I think the proper fix would be to add cjs as a target compilation, fill the "require" in exports to point to it and that's it. 🤔

Why is Vitest not compiling its sources to .cjs files as well? Do you want it to be pure ESM only? I think the proper fix would be to add cjs as a target compilation, fill the "require" in exports to point to it and that's it. 🤔

It reduces installation size/speed. Unless we wanted to support older versions of Node, there's no reason to publish CJS files. And if we did do that, we would have to remove "type": "module" anyway.

Can you set up a minimal reproduction so I can try different solutions? Thanks

@antfu https://github.com/aleclarson/repro/tree/vitest-nodenext
git clone https://github.com/aleclarson/repro -b vitest-nodenext
pnpm i

That's a weird situation. Ok I am fine with it and let's have it in the next minor as a breaking change. Can you also help to update other packages in the monorepo (namely vite-node) to use the same convention for consistentency? Thanks.

Just noticed this issue, and I think this is a configuration issue than a Vitest/Typescript issue. According to the ts docs, .ts files would be transpiled as .js, and since the package.json defaults to "type": "commonjs" it's treated as CJS instead, hence TypeScript warns about the import.
A solution would be to use "type": "module" for the repro project, or use the .mts extension. So I think this PR should be reverted.

PS: I'm not sure why this PR fixes the issue, I think it should still error as before, maybe a bug in TypeScript.

A solution would be to use "type": "module" for the repro project, or use the .mts extension. So I think this PR should be reverted.

The issue is that for some people it is not possible to move their codebase to ESM, but tests still work, so we are going with the better DX than better configuration.

I'm not sure why this PR fixes the issue, I think it should still error as before, maybe a bug in TypeScript.

I too think it's a bug, I think it should've read an exports field and see its ESM, which mean require("vitest") will fail (so, need to raise an error). But getting something from the TypeScript team is not a fast task, so I think we should stay with the solution for now.

The solution for now won't last though if TypeScript eventually fixes the issue. My thought was that TypeScript should still error out even after this PR's changes (currently it doesn't error, which feels like a bug).
IIUC the config workaround is only needed for nodenext or node16, which is a very new flag, and if someone is willing to go there, they should also be ready to be compliant with how TS evaluates esm/cjs. And the quick solution is to probably use .mts.
I think it's a ticking time-bomb though if we keep this change. The DX will bite back in the future.


[Bug] Fix unset project-name in recipe execution

PR checklist

[x] Ensure you have added or ran the appropriate tests for your PR.
[x] DCO signed

What type of PR is this?
bugfix
What this PR does / why we need it:
make recipe executor to upload reports to a specific cloud project.
Which issue(s) this PR fixes:
sc-31124

LGTM


Implement latest Chainlink Core tag and release fetching with GitHub client

This allows to fetch latest Chainlink Core versions to be used in compatibility tests https://smartcontract-it.atlassian.net/browse/TT-641
ListLatestCLCoreReleases(5) returns latest 5 releases from https://github.com/smartcontractkit/chainlink/releases. This can be then used to get the cores images from ECR.
Example from Mercury E2E compatibility tests:
github := ctfclient.NewGithubClient(os.Getenv("GITHUB_TOKEN"))
coreReleases, err := github.ListLatestCLCoreReleases(2)
if err != nil {
	log.Log.Error().Err(err).Msg("Could not fetch latest core releases")
	os.Exit(1)
}

// Use custom node and db version for OCR nodes
ocrNodes := []test_env.ClNodeConf{
	{ImageName: cfg.ChainlinkNode.ImageName, ImageVersion: cfg.ChainlinkNode.ImageVersion}, // use default for bootstrap node
	{ImageName: "public.ecr.aws/chainlink/chainlink", ImageVersion: coreReleases[0].GetTagName()[1:], PostgresImageVersion: "14.3"},
	{ImageName: "public.ecr.aws/chainlink/chainlink", ImageVersion: coreReleases[1].GetTagName()[1:], PostgresImageVersion: "15.2"},
	{ImageName: "public.ecr.aws/chainlink/chainlink", ImageVersion: "2.5.1-mercury-20230925", PostgresImageVersion: "11.12"},
	{ImageName: cfg.ChainlinkNode.ImageName, ImageVersion: cfg.ChainlinkNode.ImageVersion}, // use default for last node
}

cc @AnieeG as this maybe useful for you as well.

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (2ca2413) 17.68% compared to head (4702d6a) 17.44%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

client/github.go
0.00%
24 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   17.68%   17.44%   -0.25%
==========================================
  Files          32       33       +1
  Lines        4206     4230      +24
==========================================
- Hits          744      738       -6
- Misses       3386     3415      +29
- Partials       76       77       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document Security

This PR considers the security of documents in the API and therefore in the column navigation.
tasks:

[ ] test coverage
[ ] gather feedback for my changes
[ ] submit changes to the documentation

informations:

q
a

Fixed tickets
none

BC breaks
none

Documentation PR
none

Closed in favour of #1369


Add documentation for framework plugins

Currently the plugins README are just aliasing to the main vanilla-js README.
There should be specific documentation for each Vue, Angular and React plugins.

Currently the plugins README are just aliasing to the main vanilla-js README.
There should be specific documentation for each Vue, Angular and React plugins.

Hey i can do that

Done.


Do not override .new method in order to allow multiple injections

@timriley this adds support for multiple injections with kwargs. If you OK with that we can think about hash and args too.

@flash-gordon this seems like a really good approach to me, and it makes a lot of sense for kwargs and hash. Would you mind extending it to hash?
I'm not sure how if there's a clear way for taking this same approach for regular positional args. To start with, at least, I think it'd be fair to leave those alone and just merge this improved support for kwargs and hash. Then we can think separately about options for different injection strategies for positional args, like you mentioned here.

OK, done!

Thanks!


Add splunk source and sink

Add splunk and splunk-hec kamelets
generator script added and updated other kamelets docs (jira, salesforce,
etc)

@squakez for review.

Can this be merged ?


Add assert_by queries for ByAria trait

fixes #37
assert_by_aria_role is a convenient method for calling
get_by_aria_role and unwrapping the Result.
assert_by_aria_prop is a convenient method for calling
get_by_aria_prop and unwrapping the Result.
assert_by_aria_state is a convenient method for calling
get_by_aria_state and unwrapping the Result.

bors r+


fix(terraformpullrequest): fix pagination for github pull request files

The List object was not appropriate for our SDK and was not used at all. This PR should fix an eventual pagination

Codecov Report

Merging #174 (0d4bf60) into main (93a6cd3) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   70.50%   70.50%
=======================================
  Files          28       28
  Lines        1926     1926
=======================================
  Hits         1358     1358
  Misses        492      492
  Partials       76       76

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


logformat not being honoured for type console-json

When the appender type is console-json, the logFormat pattern is not being honoured. The configuration looks like this:
    - type: console-json
      threshold: INFO
      logFormat: "%-6level [%d{HH:mm:ss.SSS}] [%t] %logger{5} - %X{code} %msg %n"

console-json is not a valid type.
See the dropwizard docs
logging:
  appenders:
    - type: console
      layout:
        type: json

Thanks for the response but I did not realise we were using a custom encoder which reads the appender type console-json.


fix test/e2e/demo_test

Signed-off-by: frbimo<EMAIL_ADDRESS>fixes: #1186

#1186 try to reproduce using kubectl to v1.19.0 but failed.
Closing the PR


2721: Fixing the error message for empty html field name

@dougbu can you please have a look?

:watch:

@dougbu I have incorporated the feedback.

:watch: very close

@dougbu Please have a look.

Travis build is failing due to "\r\n" in expected error messages. Use Environment.NewLine instead.

:shipit: after addressing small comments and a successful Travis build.

@kulmugdha please go through the CLA process. Takes about 30 seconds...

@kulmugdha, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Checked in a6a7903b846eadd62f43866beedea826e75e2b3f to dev.


Ability to change the db tagname

I want to change the default db tag to json as the entities are genereted from protobuf.
type User struct {
    UserName `json:"user_name"`
}

However, the mpr currently is unexported and there is no function that allows to set the reflectx.Maper.
https://github.com/jmoiron/sqlx/blob/master/sqlx.go#L32
package sqlx
...
var mpr *reflectx.Mapper

@thaonx
Here you go:
import(
    "github.com/jmoiron/sqlx"
    "github.com/jmoiron/sqlx/reflectx"
    "github.com/iancoleman/strcase"
)

conn = sqlx.NewDb(db, "mysql")
conn.Mapper = reflectx.NewMapperFunc("json", strcase.ToSnake)

thanks @dgroux


Fuzzing tests occasionally panic with "arithmetic operation overflow" and "out of range"

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (1d9a34e 2023-03-07T00:07:40.652148Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
Running into occasional panics when running forge test -- sometimes tests run just fine, sometimes they panic with an arithmetic operation overflow
Initially I thought this was from running the latest nightly, but I'm seeing it happen with commits as far back as 0453ac898150133f5fc2eecf0bf7871cd392d0b1
Here's the panic when using the nightly binary -- the backtrace isn't very helpful, see below for a more helpful backtrace:
$ RUST_BACKTRACE=full FOUNDRY_DEBUG=true yarn test:forge
[⠒] Compiling...
No files changed, compilation skipped

Running 3 tests for test/PausableReentrancyGuard.t.sol:PausableReentrancyGuardTest
[PASS] testNonreentrant() (gas: 9628)
The application panicked (crashed).
Message:  arithmetic operation overflow
Location: /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/primitive-types-0.12.1/src/lib.rs:38

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   2: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   3: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   4: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   5: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   6: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   7: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   8: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>[PASS] testNonreentrantNotPaused() (gas: 14163)

   9: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  10: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  11: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  12: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  13: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  14: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  15: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  16: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  17: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  18: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  19: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  20: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  21: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  22: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  23: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  24: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  25: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  26: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  27: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  28: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  29: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  30: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  31: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  32: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  33: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  34: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  35: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  36: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
  37: __pthread_deallocate<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.

And when building from source (backtrace is a bit prettier):
$ RUST_BACKTRACE=full FOUNDRY_DEBUG=true yarn test:forge

[⠒] Compiling...
No files changed, compilation skipped

Running 3 tests for test/PausableReentrancyGuard.t.sol:PausableReentrancyGuardTest
[PASS] testNonreentrant() (gas: 9628)
[PASS] testNonreentrantNotPaused() (gas: 14163)
[PASS] testPause() (gas: 13635)
Test result: ok. 3 passed; 0 failed; finished in 646.67µs

Running 7 tests for test/igps/gas-oracles/StorageGasOracle.t.sol:StorageGasOracleTest
[PASS] testConstructorSetsOwnership() (gas: 7611)
[PASS] testGetExchangeRateAndGasPrice() (gas: 12456)
[PASS] testGetExchangeRateAndGasPriceUnknownDomain() (gas: 8064)
[PASS] testSetRemoteGasData() (gas: 38836)
[PASS] testSetRemoteGasDataConfigs() (gas: 69238)
[PASS] testSetRemoteGasDataConfigsRevertsIfNotOwner() (gas: 12227)
[PASS] testSetRemoteGasDataRevertsIfNotOwner() (gas: 11275)
The application panicked (crashed).
Message:  arithmetic operation overflow
Location: /Users/trevor/.cargo/registry/src/github.com-1ecc6299db9ec823/primitive-types-0.12.1/src/lib.rs:38

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 9 frames hidden ⋮
  10: <primitive_types::U256 as core::ops::arith::SubAssign>::sub_assign::haaab349295433f7d
      at <unknown source file>:<unknown line>
  11: revm::journaled_state::JournaledState::journal_revert::hbfb24b5629c429f7
      at <unknown source file>:<unknown line>
  12: revm::journaled_state::JournaledState::checkpoint_revert::hf724256058e15241
      at <unknown source file>:<unknown line>
  13: revm::evm_impl::EVMImpl<GSPEC,DB,_>::call_inner::h20764f8d08684cf2
      at <unknown source file>:<unknown line>
  14: revm::instructions::host::call::hf74a6a3954a3c87c
      at <unknown source file>:<unknown line>
  15: revm::interpreter::Interpreter::run::h9a1b13fb755d2572
      at <unknown source file>:<unknown line>
  16: revm::evm_impl::EVMImpl<GSPEC,DB,_>::call_inner::h20764f8d08684cf2
      at <unknown source file>:<unknown line>
  17: <revm::evm_impl::EVMImpl<GSPEC,DB,_> as revm::evm_impl::Transact>::transact::hfad8a2d76e9fa1b8
      at <unknown source file>:<unknown line>
  18: foundry_evm::executor::Executor::call_raw::h2b69b604da620b17
      at <unknown source file>:<unknown line>
  19: core::ops::function::impls::<impl core::ops::function::Fn<A> for &F>::call::h511e6c79382ced78
      at <unknown source file>:<unknown line>
  20: proptest::test_runner::runner::call_test::h81cb0f3b7b66bbc7
      at <unknown source file>:<unknown line>
  21: proptest::test_runner::runner::TestRunner::gen_and_run_case::hb51e7db8c19b0f79
      at <unknown source file>:<unknown line>
  22: proptest::test_runner::runner::TestRunner::run_in_process::h8c670db8ce325f4a
      at <unknown source file>:<unknown line>
  23: proptest::test_runner::runner::TestRunner::run::h99241cdac7080f3d
      at <unknown source file>:<unknown line>
  24: foundry_evm::fuzz::FuzzedExecutor::fuzz::h2e2cc71dbb9d80f6
      at <unknown source file>:<unknown line>
  25: forge::runner::ContractRunner::run_fuzz_test::h2114219aaf246d4a
      at <unknown source file>:<unknown line>
  26: rayon::iter::plumbing::Folder::consume_iter::h75bade315edc67d6
      at <unknown source file>:<unknown line>
  27: rayon::iter::plumbing::bridge_producer_consumer::helper::hbea1493a0aa54248
      at <unknown source file>:<unknown line>
  28: rayon_core::registry::in_worker::hc879f2ba68ac5ddb
      at <unknown source file>:<unknown line>
  29: rayon::iter::plumbing::bridge_producer_consumer::helper::hbea1493a0aa54248
      at <unknown source file>:<unknown line>
  30: <rayon::iter::flat_map::FlatMap<I,F> as rayon::iter::ParallelIterator>::drive_unindexed::hc2453796c8fcf645
      at <unknown source file>:<unknown line>
  31: rayon::result::<impl rayon::iter::FromParallelIterator<core::result::Result<T,E>> for core::result::Result<C,E>>::from_par_iter::h10c67b0f765d8ca5
      at <unknown source file>:<unknown line>
  32: forge::runner::ContractRunner::run_tests::hafa155cf36f03529
      at <unknown source file>:<unknown line>
  33: forge::multi_runner::MultiContractRunner::run_tests::h96e6ebd818814301
      at <unknown source file>:<unknown line>
  34: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume::hc897c0c123a40d4e
      at <unknown source file>:<unknown line>
  35: rayon::iter::plumbing::Folder::consume_iter::h92773b96e146ddb4
      at <unknown source file>:<unknown line>
  36: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  37: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  38: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  39: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  40: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  41: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hc93f2e33d11b7357
      at <unknown source file>:<unknown line>
  42: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute::hba510294234ed2bb
      at <unknown source file>:<unknown line>
  43: rayon_core::registry::WorkerThread::wait_until_cold::h4d4f4d271f2eaa71
      at <unknown source file>:<unknown line>
  44: rayon_core::registry::ThreadBuilder::run::h82cf17e75c093122
      at <unknown source file>:<unknown line>
  45: std::sys_common::backtrace::__rust_begin_short_backtrace::h7a5df0c254a4feee
      at <unknown source file>:<unknown line>
  46: core::ops::function::FnOnce::call_once{{vtable.shim}}::h217eb88d52405018
      at <unknown source file>:<unknown line>
  47: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hf101e7e0479e2c15
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  48: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hcc97a7a0d1eb566a
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  49: std::sys::unix::thread::Thread::new::thread_start::h92ee0ad602ca1aab
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/sys/unix/thread.rs:108
  50: __pthread_deallocate<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Test result: ok. 7 passed; 0 failed; finished in 655.50µs

Running 7 tests for test/igps/OverheadIgp.t.sol:OverheadIgpTest
[PASS] testDestinationGasAmount() (gas: 33814)
The application panicked (crashed).
Message:  arithmetic operation overflow
Location: /Users/trevor/.cargo/registry/src/github.com-1ecc6299db9ec823/primitive-types-0.12.1/src/lib.rs:38

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 9 frames hidden ⋮
  10: <primitive_types::U256 as core::ops::arith::SubAssign>::sub_assign::haaab349295433f7d
      at <unknown source file>:<unknown line>
  11: revm::journaled_state::JournaledState::journal_revert::hbfb24b5629c429f7
      at <unknown source file>:<unknown line>
  12: revm::journaled_state::JournaledState::checkpoint_revert::hf724256058e15241
      at <unknown source file>:<unknown line>
  13: revm::evm_impl::EVMImpl<GSPEC,DB,_>::call_inner::h20764f8d08684cf2
      at <unknown source file>:<unknown line>
  14: revm::instructions::host::call::hf74a6a3954a3c87c
      at <unknown source file>:<unknown line>
  15: revm::interpreter::Interpreter::run::h9a1b13fb755d2572
      at <unknown source file>:<unknown line>
  16: revm::evm_impl::EVMImpl<GSPEC,DB,_>::call_inner::h20764f8d08684cf2
      at <unknown source file>:<unknown line>
  17: <revm::evm_impl::EVMImpl<GSPEC,DB,_> as revm::evm_impl::Transact>::transact::hfad8a2d76e9fa1b8
      at <unknown source file>:<unknown line>
  18: foundry_evm::executor::Executor::call_raw::h2b69b604da620b17
      at <unknown source file>:<unknown line>
  19: core::ops::function::impls::<impl core::ops::function::Fn<A> for &F>::call::h511e6c79382ced78
      at <unknown source file>:<unknown line>
  20: proptest::test_runner::runner::call_test::h81cb0f3b7b66bbc7
      at <unknown source file>:<unknown line>
  21: proptest::test_runner::runner::TestRunner::gen_and_run_case::hb51e7db8c19b0f79
      at <unknown source file>:<unknown line>
  22: proptest::test_runner::runner::TestRunner::run_in_process::h8c670db8ce325f4a
      at <unknown source file>:<unknown line>
  23: proptest::test_runner::runner::TestRunner::run::h99241cdac7080f3d
      at <unknown source file>:<unknown line>
  24: foundry_evm::fuzz::FuzzedExecutor::fuzz::h2e2cc71dbb9d80f6
      at <unknown source file>:<unknown line>
  25: forge::runner::ContractRunner::run_fuzz_test::h2114219aaf246d4a
      at <unknown source file>:<unknown line>[PASS] testDestinationGasAmountWhenOverheadNotSet() (gas: 7912)

  26: rayon::iter::plumbing::Folder::consume_iter::h75bade315edc67d6
      at <unknown source file>:<unknown line>
  27: rayon::iter::plumbing::bridge_producer_consumer::helper::hbea1493a0aa54248
      at <unknown source file>:<unknown line>
  28: rayon_core::registry::in_worker::hc879f2ba68ac5ddb
      at <unknown source file>:<unknown line>
  29: rayon::iter::plumbing::bridge_producer_consumer::helper::hbea1493a0aa54248
      at <unknown source file>:<unknown line>
  30: <rayon::iter::flat_map::FlatMap<I,F> as rayon::iter::ParallelIterator>::drive_unindexed::hc2453796c8fcf645
      at <unknown source file>:<unknown line>
  31: rayon::result::<impl rayon::iter::FromParallelIterator<core::result::Result<T,E>> for core::result::Result<C,E>>::from_par_iter::h10c67b0f765d8ca5
      at <unknown source file>:<unknown line>
  32: forge::runner::ContractRunner::run_tests::hafa155cf36f03529
      at <unknown source file>:<unknown line>
  33: forge::multi_runner::MultiContractRunner::run_tests::h96e6ebd818814301
      at <unknown source file>:<unknown line>
  34: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume::hc897c0c123a40d4e
      at <unknown source file>:<unknown line>
  35: rayon::iter::plumbing::Folder::consume_iter::h92773b96e146ddb4
      at <unknown source file>:<unknown line>
  36: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  37: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  38: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  39: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  40: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  41: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hc93f2e33d11b7357
      at <unknown source file>:<unknown line>
  42: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute::hba510294234ed2bb
      at <unknown source file>:<unknown line>
  43: rayon_core::registry::WorkerThread::wait_until_cold::h4d4f4d271f2eaa71
      at <unknown source file>:<unknown line>
  44: rayon_core::registry::ThreadBuilder::run::h82cf17e75c093122
      at <unknown source file>:<unknown line>
  45: std::sys_common::backtrace::__rust_begin_short_backtrace::h7a5df0c254a4feee
      at <unknown source file>:<unknown line>
  46: core::ops::function::FnOnce::call_once{{vtable.shim}}::h217eb88d52405018
      at <unknown source file>:<unknown line>
  47: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hf101e7e0479e2c15
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  48: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hcc97a7a0d1eb566a
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  49: std::sys::unix::thread::Thread::new::thread_start::h92ee0ad602ca1aab
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/sys/unix/thread.rs:108
  50: __pthread_deallocate<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.

^ this continues on for quite some time with a bunch more panics with the same message, however I'm now seeing the final panic message is different:
The application panicked (crashed).
Message:  range start index 4 out of range for slice of length 0
Location: evm/src/fuzz/mod.rs:200

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 9 frames hidden ⋮
  10: core::slice::index::slice_start_index_len_fail_rt::hc4b7c5ac5f48485d
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/slice/index.rs:53
  11: core::slice::index::slice_start_index_len_fail::he934197ee6ba25e2
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/slice/index.rs:41
  12: foundry_evm::fuzz::FuzzedExecutor::fuzz::h2e2cc71dbb9d80f6
      at <unknown source file>:<unknown line>
  13: forge::runner::ContractRunner::run_fuzz_test::h2114219aaf246d4a
      at <unknown source file>:<unknown line>
  14: rayon::iter::plumbing::Folder::consume_iter::h75bade315edc67d6
      at <unknown source file>:<unknown line>
  15: rayon::iter::plumbing::bridge_producer_consumer::helper::hbea1493a0aa54248
      at <unknown source file>:<unknown line>
  16: <rayon::iter::flat_map::FlatMap<I,F> as rayon::iter::ParallelIterator>::drive_unindexed::hc2453796c8fcf645
      at <unknown source file>:<unknown line>
  17: rayon::result::<impl rayon::iter::FromParallelIterator<core::result::Result<T,E>> for core::result::Result<C,E>>::from_par_iter::h10c67b0f765d8ca5
      at <unknown source file>:<unknown line>
  18: forge::runner::ContractRunner::run_tests::hafa155cf36f03529
      at <unknown source file>:<unknown line>
  19: forge::multi_runner::MultiContractRunner::run_tests::h96e6ebd818814301
      at <unknown source file>:<unknown line>
  20: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume::hc897c0c123a40d4e
      at <unknown source file>:<unknown line>
  21: rayon::iter::plumbing::Folder::consume_iter::h92773b96e146ddb4
      at <unknown source file>:<unknown line>
  22: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  23: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  24: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  25: rayon_core::registry::in_worker::h776a947bb090cf9b
      at <unknown source file>:<unknown line>
  26: rayon::iter::plumbing::bridge_producer_consumer::helper::h9c37dde9b9d23459
      at <unknown source file>:<unknown line>
  27: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hc93f2e33d11b7357
      at <unknown source file>:<unknown line>
  28: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute::hba510294234ed2bb
      at <unknown source file>:<unknown line>
  29: rayon_core::registry::WorkerThread::wait_until_cold::h4d4f4d271f2eaa71
      at <unknown source file>:<unknown line>
  30: rayon_core::registry::ThreadBuilder::run::h82cf17e75c093122
      at <unknown source file>:<unknown line>
  31: std::sys_common::backtrace::__rust_begin_short_backtrace::h7a5df0c254a4feee
      at <unknown source file>:<unknown line>
  32: core::ops::function::FnOnce::call_once{{vtable.shim}}::h217eb88d52405018
      at <unknown source file>:<unknown line>
  33: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hf101e7e0479e2c15
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  34: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hcc97a7a0d1eb566a
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/alloc/src/boxed.rs:2000
  35: std::sys::unix::thread::Thread::new::thread_start::h92ee0ad602ca1aab
      at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/sys/unix/thread.rs:108
  36: __pthread_deallocate<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.

Seems related to fuzzing. Going to continue debugging & playing around with our fuzzing tests specifically to see if I can nail it down to a specific test case

cc @joshieDo

@tkporter can you pls retry and report back if still an issue (it it is would be great to have instructions to reproduce it locally). thank you

Marking as requires reproduction
@tkporter feel free to re-open with instructions to reproduce or a minimal example if you are still running into this


Error on running demo scene

Hello, thanks for sharing this awesome library!
I'm trying to run the scene that was shared with this project on a empty Unity3d project and I get this error:
Trying to access pass 1, but material 'Playdead/Post/VelocityBuffer' subshader (0) has only 1 valid passes. UnityEngine.Material:SetPass(Int32) VelocityBuffer:OnPostRender() (at Assets/Scripts/VelocityBuffer.cs:126)
my unity3d version is 5.3.0f4 and I'm running on a MacOS.

Same problem here: Mac OS X Yosemite v10.10.5 with Unity 5.3.4f1

Thanks for reporting! Will take a look once I'm back from post-GDC vacation.

After a little digging, the OSX issue is due to this change Unity made in 5.3.X:
http://forum.unity3d.com/threads/opengl-core-backend-default-change-for-osx-and-linux.359225/

A typical issue you may encounter is when you use #pragma only_renderers gles opengl in your shaders. We will probably need to add glcore.

Modifying instances of this line (in both .shader files) from
#pragma only_renderers ps4 xboxone d3d11 d3d9 xbox360 opengl
to
#pragma only_renderers ps4 xboxone d3d11 d3d9 xbox360 opengl glcore
removes the error.
Thanks for this resource!

I think it's actually Airmail trying to save an e-mail draft and failing.
Trent Polack
CEO/Creative Director, Joy Machine
http://joy-machine.com
On 3/23/2016 10:59:11 PM, robsolomon<EMAIL_ADDRESS>wrote:
After a little digging, the OSX issue is due to this change Unity made in 5.3.X:
http://forum.unity3d.com/threads/opengl-core-backend-default-change-for-osx-and-linux.359225/ [http://forum.unity3d.com/threads/opengl-core-backend-default-change-for-osx-and-linux.359225/]
A typical issue you may encounter is when you use #pragma only_renderers gles opengl in your shaders. We will probably need to add glcore.
Modifying instances of this line (in both .shader files) from
#pragma only_renderers ps4 xboxone d3d11 d3d9 xbox360 opengl
to
#pragma only_renderers ps4 xboxone d3d11 d3d9 xbox360 opengl glcore
removes the error.
Thanks for this resource!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub [https://github.com/playdeadgames/temporal/issues/1#issuecomment-200631547]

@robsolomon solution works for me! Thanx!


Update the linter to deal with missing BCD for completely unimplemented features

We have an issue in the CSS docs where some specs with broad implementation have a few properties unimplemented. If we don't document them there it's hard for developers to understand their status, however we don't want completely unimplemented properties in BCD even if in a stable spec.
Leaving no BCD means that the linter complains. I'd like to be able to have a way to indicate that there is no implementation, for example adding a line stating this where we would expect the BCD to go and have the linter understand this. It would help developers understand the status (and if it were a consistent bit of info would also mean we could search for these pages to check if any of them now have support)
re: https://github.com/mdn/browser-compat-data/pull/7511#issuecomment-744362920

Issue moved to mdn/browser-compat-data #8790 via ZenHub

Issue moved to mdn/browser-compat-data #8790 via ZenHub


[EASI-2586] Add 'ARCHITECT' to TeamRoles for Collaborators

EASI-2586
Changes and Description

'ARCHITECT' added to GQL
'ARCHITECT' added to SQL
'Architect' added to front-end

How to test this change

Create a new model plan
Add a collaborator

Confirm the 'Architect' selection is available in team roles
Select the 'Architect' role

Confirm the collaborator was successfully added
Confirm that the new entry in the 'plan_collaborators' table has the role 'ARCHITECT'

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

I see a test failed:
  ● Adding a collaborator page › matches snapshot

Currently looking into how to fix this issue.


Update parsexml.erl add comment support

fix

comment in body will crash.
two lines of comment after declaration wil crash.

Add please test for it. It is a good patch, but test is required.

done, added some comments in test2.xml


Terragrunt should enforce best practices around version control

Terragrunt provides locking for state files, but you can still have "concurrency" issues with the following two scenarios:

You forget to run git pull before running terragrunt apply, so you end up applying out-of-date templates.
You forget to run git commit and git push after running terragrunt apply, so even if your other teammates remember to run git pull, they will end up applying out-of-date templates.

Perhaps we should add a new setting in .terragrunt:
enforce_version_control = {
  backend = "git"
  config = {
    branch = "master"
    remote = "origin"
  }
}

If you have that config in your file, then every time you run terragrunt apply, Terragrunt will:

Obtain a lock (if one is specified).
Check if you are on master and if not, exit with an error.
Check if you have any uncommitted or unpushed files in master, and if you do, exit with an error.
Run git pull origin master.
Then run your actual Terraform command.

Note that you'd probably only want this config in "shared" environments such as production. For test environments, you will likely make many changes with Terraform that are not committed to version control, as a way to test those changes before committing.

This proposal wouldn't solve the 2nd problem described above:

You forget to run git commit and git push after running terragrunt apply, so even if your other teammates remember to run git pull, they will end up applying out-of-date templates.

What about introducing an additional wrapper step if the actual Terraform command is apply that does a git commit and a 'git push'? Trying to play out in my mind what the downsides of this would be...

This proposal wouldn't solve the 2nd problem described above:

This would be handled by step 3:

Check if you have any uncommitted or unpushed files in master, and if you do, exit with an error.

I suppose that step could also do the git commit and git push for you, but that seems riskier, as every team has its own process for that (e.g. submit a PR).

Whoops, my attention to detail had a fail moment there :-)

Heh, no worries.
Do you think this approach would solve the issues with out of date .tf files?

I guess there's still some issues:

Forcing changes to be pushed probably only makes sense if the command is apply? Why would one expect changes to be pushed unless an attempt was being made to actual mutate infrastructure?

It's feasible that the Terraform apply command might fail, in which case changes have been pushed to git and infrastructure not mutated.

If there's a merge conflict when pulling master, again, there's going to be a window during which infrastructure is not mutated to reflect the changes that have been pushed to git.

Not sure a simple command line tool would ever be able to close every gap, though.

Forcing changes to be pushed probably only makes sense if the command is apply?

True. I updated the description to make that more clear.

It's feasible that the Terraform apply command might fail, in which case changes have been pushed to git and infrastructure not mutated.

True, but I'd argue those changes should still be in Git in that case, as they likely partially applied, and that code is still the best representation of your infrastructure that you have.

If there's a merge conflict when pulling master, again, there's going to be a window during which infrastructure is not mutated to reflect the changes that have been pushed to git.

If git pull fails, then terragrunt apply will release the lock and exit without applying any changes. Once you fix the conflict and commit and push, then you can run it again.

Not sure a simple command line tool would ever be able to close every gap, though.

No, but it seems like we can get 95% of what we need here.

What if I don't use git ?

@tamsky Support for other version control systems could be added too. That's why there is a backend setting in the proposal above.

Just sayin,
We do everything you propose (checking for upstream and local unpushed changes), in our Makefile.

We are unlikely to implement this, as we've seen that people use Terragrunt and their VCS in a variety of ways. Closing.


Android - Failed to Resolve

Hello,
Hope your day is going well. I was trying to add the gdx-video library to the Gradle build file, however, I am getting the error message - Failed to resolve: com.badlogicgames.gdxvideo:gdx-video-android:1.9.12.
I would be grateful if someone can help me with this.
Thanks

Sadly, there is nothing I can do about it. I want to upload it, but @Tom-Ski has to make some sonatype stuff to get it working.
I'm closing this, because this is a duplicate of #51


what are the exact prerequesites to install/side-load an Outlook add-in?

Question
I managed to find Get Add-In in my Windows Outlook 2019 and 2022 installations (two PCs), however they are both dimmed.
I tried options in https://www.technipages.com/outlook-get-add-ins-button-is-grayed-out/ except for the Exchange account, none worked or offered the relevant settings.
I want to use / enhance /develop for:

local installation of Outlook 2019/2022 (at least initially)
outlook being connected to a mail server supporting EAS but not being Exchange plus some accounts on outlook.com

I´d like to just install the "hello world" example. I can put up file shares or webservers (IIS or nginx), but the required structure is unfortunately only given by npm instructions. Also it is unclear how to overcome the dimmed issue.
Please advise and clariy the instructions.
Thanks, Joachim

@jol64 As I understand it you are working with the sample at outlook-hello-world. Can you confirm that?
At what step in the instructions do you get blocked? What do you expect to see and what do you actually see?

I want to start working from that example, but I was unable to install it as is. As I wrote, the button "Get Add-In" in Outlook is dimmed, and I haven´t found a way to get it working.

@samantharamon Can you take a look?

Hi @jol64,
Apologies for the delayed response. To install and load Outlook add-ins, your mail account must be connected to Microsoft 365 or an Exchange server. To learn more about this and other requirements, see Outlook add-in requirements.
If you require an account for development purposes, we'd like to invite you to join the Microsoft 365 Developer Program. The program gives you access to a free developer sandbox with a 90-day renewable Microsoft 365 E5 license. This will allow you to test and develop add-ins for Outlook.

[like]  Ricky Kirkham reacted to your message:

From: Sam Ramon @.>
Sent: Friday, June 30, 2023 10:24:14 PM
To: OfficeDev/Office-Add-in-samples @.>
Cc: Comment @.>; Subscribed @.>
Subject: Re: [OfficeDev/Office-Add-in-samples] what are the exact prerequesites to install/side-load an Outlook add-in? (Issue #546)
Hi @jol64https://github.com/jol64,
Apologies for the delayed response. To install and load Outlook add-ins, your mail account must be connected to Microsoft 365 or an Exchange server. To learn more about this and other requirements, see Outlook add-in requirementshttps://learn.microsoft.com/office/dev/add-ins/outlook/add-in-requirements.
If you require an account for development purposes, we'd like to invite you to join the Microsoft 365 Developer Programhttps://developer.microsoft.com/microsoft-365/dev-program. The program gives you access to a free developer sandbox with a 90-day renewable Microsoft 365 E5 license. This will allow you to test and develop add-ins for Outlook.
—
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/Office-Add-in-samples/issues/546#issuecomment-1615244032 or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACFKYOFRFJHODGLZJTRB6CTXN5GY5BFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVE3TINRZGI4TKNJRURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNZUGY4TEOJVG42KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGQ4DOMZQGA4DMNJUURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QMZZGU3TQOBTGKBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGE3TOMBTGUYTQMRWQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJXGQ3DSMRZGU2TDAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTONBWHEZDSNJXGSBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGQ4DOMZQGA4DMNJUU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Configuring an outlook.com account activated Get.Add-In and I can browse Add-Ins provided by outlook.com, plus at the end there is "Add a custom add-in".
Frankly, requiring a connection to a service one doesn´t really need looks just plain wrong. I know a lot more users of the software Office/Outlook then the service. Looks like Microsoft wants to get rid of anyone using their software.
Now how does the add-in need to be structured on a web server or file system, not using npm?

Thank you for the feedback, @jol64. I'll be sure to pass it on to the relevant team for further review.
Your add-in files would follow a similar structure, but you'll need to specify the web server where the files are hosted in your manifest (basically, replace any localhost references with the hosting location). For reference, see the file structure and manifest of the Outlook hello-world Office Add-in sample.

@samantharamon Thanks. I downloaded a copy to local file system, renamed the manifests and was able to "add" from file. The Add-In then showed up when composing a new message, but pressing on it resulted in an error message "cannot load..." whatever.
in event viewer there was somewhat more details, apoligizes that my installation is German, rough translation added:
Add-In-Fehler  / Add-In-Error
Leider kann das Add-In nicht geladen werden. Überprüfen Sie, ob eine Netzwerk- und/oder Internetverbindung besteht.
Unfortuantely the add-in cannot be loaded. Check whether a network or internet connection exists.
...
I looked at the manifest and noticed there are absolute URLs in it. Actually I think this is a design error though I don´t know whether add-ins in general suffer that issue or only the examples are not written using relative URLs. Anyone redistributing an add-in would have to update all URLs.  Thinking about modifications: is there a mechanism to sign add-ins?

sorry, was using wrong account to update, which obviously doesn´t trigger any bots..

@jol64 When you get a chance, could you share a snippet of your manifest, so that we could troubleshoot the issue further?
Regarding the URLs, they must be absolute links, so that the add-in can load the correct resources. I'll look into whether signing an add-in is supported. In the meantime, could you please share more details on the hosting setup you're planning for your add-in, so that we can help provide suggestions more suited to your context?

@samantharamon I used the original https://github.com/OfficeDev/Office-Add-in-samples/blob/main/Samples/hello-world/outlook-hello-world/manifest-localhost.xml renamed to manifest.xml, but when importing I used file system navigation rather than setting up a localhost based webserver (in fact the PC I tried on does run an IIS but with a certificate matching its FQDN on port 443.
For my own needs I can put this on a local web or file server, but with hard coded paths it is impossible to run distinct development, test and production sites. And no idea how one would test add-ins in a CI pipeline.
To me it looks like Microsoft never considered distribution channels or customers using Outlook client but not using Exchange.

@JuaneloJuanelo, is this something you could assist with further? Thank you.

Hi @jol64, Just checking in on this issue and want to see if you need any assistance with your Outlook Add-in. To answer your question on a CI pipeline, The typical strategy is to use multiple manifests. For dev and testing you could use a manifest that points to a localhost server for dev/test on your own computer. If you are using a cloud pipeline for staging/production, again you could use a different manifest for each phase in the pipeline. manifest-local, manifest-staging, manifest-production. If you build an Outlook Add-in with Visual Studio, you'll see it takes a similar approach by using relative urls in the manifest when viewed in the project. When your run the build it builds the expected manifest. There's more information on how to configure the packaging at https://stackoverflow.com/questions/38491135/specify-value-for-remoteappurl-in-an-office-add-in-manifest
Hope this helps,
David

@davidchesnut imho this is a poor workaround. But the reason I was not spending any time on the topic is the need for an exchange server
@samantharamon  any news w.r.t. that need?
Thanks,
Joachim


Function setTags in LogClickthrough seems not working

Hi, I want to implement the functionality to get a specific tag when user clicks on a link. The LogClickthrough works without setting a tag, but when I try to set a Tag, it doen't work as expected, here's my code :
        $app = $client->appSearch(); 	$szClick = new Request\LogClickthrough($szEngine, $szSearch, $nIdDoc); 	$szClick->setTags(['testTag']); 	// Here's my attempt to put a tag on the logClickthrough response 	$app->logClickthrough($szClick);
I've tried different ways to get this work but none of my attempts were successfull

@Messaoudi-Nagib I confirm this is a bug. The tags parameter seems to be sent in the body. I'm checking with the API specification. I'll add more details and how to solve it soon.

@ezimuel Ok, thank you for the reply :)

@Messaoudi-Nagib I just sent PR #5 for fixing the setTags issue and not only. In fact, this PR fixes also potential other issues for App Search endpoints using query string. With this update, every query string parameter is passed in the body request, as suggested here.
Let me know if you can try the PR using the new Request\LogClickthrough implementation, thanks!

@Messaoudi-Nagib I just released enterprise-search-php 7.13.1. Let me know if this fix the issues, thanks!

@ezimuel I've tested locally and it's working now, thank you very much ! Best regards


use new KmmResult

(needs some time  until KmmResult actually lands in maven central)

Blocked by Kotlin bug KT-61382

the KT-61382 workaround makes it work, however, merging this one results in an issue trying to register TestCredential in the oidc testcase for serialization, which I do not understand


Enhancement: command history

Would be nice to have a history of instructions previously entered so we can use the up / down arrows to scroll through previous commands.

Sounds like a good feature, I will see about implementing this soon

Added the feature, this one was fairly simple. Let me know how it works for you, works great on my end.


[3.x] Let make_rst.py be forward compatible with 4.0's

If you're using a worktree-based workflow with Git involving Godot 3 and 4, you need this so your unique set of hooks (i.e., those from 4.0) don't error on 3.x worktrees.
NOTE: I think that some day it won't be possible to keep compatibility, but as of now this patch does the trick until that dark day arrives.

make_rst.py should be backported to 3.x anyway. There has been many changes in it that will either be handy in 3.x, or will make it easier to keep both versions maintained in the long run.
I just need to dedicate some time to it, because right now there are multiple formatting changes that should only be backported with a corresponding godot-docs PR. The parser stuff, though, should be ported completely, including the new tags (even if we don't/can't use them) and validation logic.

That sounds great, but that doesn't mean you're not against merging this temporary patchie, does it?

Thanks!

Cherry-picked for 3.5.2.


ShellCheck - correctness ?

Hello,
I would suggest to check the syntax of base16-manager with ShellCheck and try to fix all warnings and errors.
About ShellCheck (see github page):

The goals of ShellCheck are

To point out and clarify typical beginner's syntax issues that cause a shell to give cryptic error messages.

To point out and clarify typical intermediate level semantic problems that cause a shell to behave strangely and counter-intuitively.

To point out subtle caveats, corner cases and pitfalls that may cause an advanced user's otherwise working script to fail under future circumstances.

What do you think about?

I think this is a great idea. I'll work on a PoC.

Given my personal circumstances and the terrible state of the style used in the script, I have not yet been able to produce a valid PoC.

Resolved by #38.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_0be27splbs/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_0be27splbs/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_0be27splbs/clone/recipe/meta.yaml:30: missing_pip_check: For pypi packages, pip check should be present in the test commands
WARNING: /tmp/abs_0be27splbs/clone/recipe/meta.yaml:41: missing_description: The recipe is missing a description
ERROR: /tmp/abs_0be27splbs/clone/recipe/meta.yaml:41: http_url: http://pythonhosted.org/uritools/ is not https
Errors were found


how to get current permission status

I need to get current status at Fitness
because need activate permission request button when permission canceled from outside .
so, how can I get that?

Hey, so this would work as expected only on Android GoogleFit, because iOS HealthKit in case user denies access still returns success. You can read more about this here: https://stackoverflow.com/a/56937166
In case your still interested, respond here and I will add it as a feature request.

Duplicate of #12

I have a hacky way to check this.
We can check from the last year's read data. Health(iOS) still collects last year's records. So, if it returns an empty list then the permission is false, else it will be true.

I have a hacky way to check this.
We can check from the last year's read data. Health(iOS) still collects last year's records. So, if it returns an empty list then the permission is false, else it will be true.


Future Parser and exec resources

I'm getting the following error when using the future parser ( puppet 3.7.4 )
     Failure/Error: it { should contain_file('/etc/elasticsearch/templates_import').with(:require => 'Exec[mkdir_templates_elasticsearch]') }
       expected that the catalogue would contain File[/etc/elasticsearch/templates_import] with require set to "Exec[mkdir_templates_elasticsearch]" but it is set to [Exec[mkdir_templates_elasticse
arch]{:command=>"mkdir_templates_elasticsearch"}]

I'm unsure where the extra {:command=>"mkdir_templates_elasticsearch"} comes from.

spec/defines/sysctl_spec.rb tests something very similar to this. Can you add your manifest and spec code too, that triggers that?

Hi David,
if you checkout https://github.com/elastic/puppet-elasticsearch it should show up.
I've tried it with recent puppet 3.x and future parser enabled and also with puppet 4 and got the same error.

I've tried my hand at a fix but that didn't work very well. You should look into changing those tests to use the relationship matchers as described here: https://github.com/rodjek/rspec-puppet#relationship-matchers Any reason, you're not using them?

Hi David,
I did test with those and made no difference if i remember correctly. @hunner gave me that advice a while ago but no change.

Been doing some more tests and for some weird reason it now works with the new relationship matchers.
Confused why the old way doesn't work anymore though.

Thanks for re-checking.
If I had a nickel for every time ...


Fix(tap-runner): wait for spawned process to exit

A (possible) fix for the issue described in #4122.. The tap-runner now waits for the spawned process to exit before returning the results.
I think this will fix the problem we encounter in de ci pipeline, but I could not recreate the problem locally.

BTW the fix is working. No false negatives have happened in this PR yet. I've run it a couple of times now.


Rails/Delegate - Setting to forbid use of delegate

Is your feature request related to a problem? Please describe.
The reason we would want to forbid delegate in our codebases is because Sorbet doesn't understand it.
Describe the solution you'd like
A setting for Rails/Delegate to forbid its usage.
Describe alternatives you've considered
Writing a custom rule to forbid this method.
Additional context
N/A

@koic do you mean where a possible implementation of this setting might wrongly detect a use of delegate?

An, I understand. Perhaps it could have an opposite EnforcedStyle option independent of Sorbet for the cop.


Rethink module exports

Should we do this as we do now:
import HeadlessForm from 'ember-headless-form/components/headless-form';

Or rather provide all public imports from index:
import { HeadlessForm } from 'ember-headless-form';

Or both?

import { HeadlessForm } from 'ember-headless-form';

is my preference, because:

this addon only only provides one root component, and has nothing to tree shake
fewer path segments are easier to type
root-level exports like this are a clear indicator of "public API"
less noisy imports when folks use exclusively strict mode / gjs/gts


DIMID causing missing and buggy planets

Minecraft Version: 1.12.2
Forge Version: <IP_ADDRESS>24
Advanced Rocketry Version: 1.12.2-1.3.0-61
LibVulpes Version: 1,12,2-0.2.8-27
is this the latest curseforge build? Yes
Explain issue in detail: When I use the DIMID tag in my planetDefs.xml file, most of my planets are in the wrong star system or missing altogether. Some moons also disappear. Also, when I go to the planets, they do not follow what I had set in the XML file -- for example, a moon that is supposed to be rocky and barren is heavily forested. I won't paste the XML file here, because it clearly has something to do with the DIMID tag itself.
Mods installed:

Advanced Rocketry
Biomes O' Plenty
Immersive Engineering
RFTools (but not RFTools Dimensions)
All 4 Thermal mods
All mods required to run those mods (e.g. CodeChicken Lib, Redstone Flux, libVulpes)

Can you Upload a copy of your planetDef.xml and the temp.dat in a zip to say either dropbox or google drive and link that here?

Planets in the wrong starsystem is not DIM related, but hierarchy related, the hierarchy is solely determined by the ordering in the planetDefs.xml rather than the dimid tag, so I would say it's highly relevant.  A few additional questions, are you using a planetDefs.xml file in the config folder, if so did you change the one there or in the /advRocketry folder.  Second, when exploring these worlds, did you make sure you loaded new chunks after you made the changes.  AR does not delete or modify existing chunks when a change is made.
If this occured when modifying the planetDefs.xml on a pre-existing world, I may also need the xml file you modified from, since it's possible it may be a problem with loading and modifying an existing save.

Okay, I tested this myself, and I can confirm that the DIMID tag does some strange things...
In my XML file, I set up 6 planets around the Sun, Mercury to Saturn. Earth and Jupiter had 1 moon and Saturn had two. I also set up a few other stars, including a planet around another star, Proxima Centauri. I set up Proxima b with a DIMID of 4, which would have otherwise been reserved for Earth's moon.
First off, when starting the game, there was no moon orbiting the Earth. Secondly, and probably the most strange, Proxima b was orbiting the Sun, and not Proxima! Strangely though, it wasn't orbiting the Earth despite the fact that it was overriding the dimension spot where the moon would have been. Strangely, when I clicked on the Proxima star, the planet was orbiting Proxima as well!
But it doesn't end there. I teleported to Mars and found a Moon biome waiting for me, instead of a Hot Dry Rock biome, which was what I had set it to. This bug didn't seem to affect any other planets, though.
Lastly, and while it might be unrelated, I found the strangest terrain on Proxima b... Biomes seemed to not have their usual effect on the height of the terrain, because I found an ocean above sea level!

(This might be the forested terrain described in the issue.)
So yeah, weird things happen with this tag. Just for the sake of it, I'm going to start another world without using the DIMID tag on Proxima b just to see if this last issue is related.
If you could provide some information, like more specifically which biomes are wrongly spawning on planets, that would be very helpful. And just for the sake of it, I still want to see your XML file so I can fully reproduce this issue.

Okay, I don't know if this is good or bad news, but after removing the DIMID tag from Proxima b, the biome height bug and Moon-biome Mars bug still remained, so I don't think that's related. (I'm still dimmapping the Earth to 0, though. So I dunno if that has anything to do with it.)
As far as I can tell, this bug affects which star a planet is orbiting around. I'd say the Earth being Dimmapped to 0 would have something to do with this, but I haven't really had this issue while playing in 1.10.2.

I don't mean to sound testy, but I have very limited time, would it be possible to post the XML file where things are not working as expected so I can debug the issue?

Just for the record, here's my XML file that I used:
<galaxy>
    <star name="Sol" temp="100" x="0" y="0" numPlanets="0" numGasGiants="0">
		<planet name="Mercury" customIcon="moon">
            <orbitalDistance>50</orbitalDistance>
            <gravitationalMultiplier>38</gravitationalMultiplier>
            <atmosphereDensity>0</atmosphereDensity>
            <biomeIds>110</biomeIds>
        </planet>
        <planet name="Venus">
            <orbitalDistance>72</orbitalDistance>
            <gravitationalMultiplier>90</gravitationalMultiplier>
            <atmosphereDensity>200</atmosphereDensity>
            <biomeIds>112</biomeIds>
            <fogColor>0xC4A000</fogColor>
            <skyColor>0xD6B72D</skyColor>
        </planet>
        <planet name="Earth" DIMID = "0" dimMapping = "">
            <orbitalDistance>100</orbitalDistance>
            <planet name="Luna">
                <orbitalDistance>15</orbitalDistance>
                <gravitationalMultiplier>12</gravitationalMultiplier>
                <atmosphereDensity>0</atmosphereDensity>
                <biomeIds>110</biomeIds>
            </planet>
        </planet>
        <planet name="Mars" customIcon="marslike">
            <orbitalDistance>150</orbitalDistance>
            <gravitationalMultiplier>37</gravitationalMultiplier>
            <atmosphereDensity>1</atmosphereDensity>
            <biomeIds>112</biomeIds>
            <rotationalPeriod>24500</rotationalPeriod>
            <skyColor>0xE46C3A</skyColor>
        </planet>
        <planet name="Jupiter" customIcon="gasgiantred">
            <orbitalDistance>175</orbitalDistance>
            <GasGiant>true</GasGiant>
            <gas>hydrogen</gas>
            <planet name="Europa">
                <orbitalDistance>15</orbitalDistance>
                <gravitationalMultiplier>13</gravitationalMultiplier>
                <atmosphereDensity>0</atmosphereDensity>
                <biomeIds>115,10</biomeIds>
            </planet>
        </planet>
        <planet name="Saturn" customIcon="gasgiantred">
            <orbitalDistance>200</orbitalDistance>
            <hasRings>true</hasRings>
            <GasGiant>true</GasGiant>
            <gas>hydrogen</gas>
            <planet name="Titan">
                <orbitalDistance>20</orbitalDistance>
                <gravitationalMultiplier>14</gravitationalMultiplier>
                <atmosphereDensity>145</atmosphereDensity>
                <biomeIds>112</biomeIds>
                <fogColor>0xC4A000</fogColor>
                <skyColor>0xD6B72D</skyColor>
            </planet>
            <planet name="Enceladus">
                <orbitalDistance>30</orbitalDistance>
                <gravitationalMultiplier>13</gravitationalMultiplier>
                <atmosphereDensity>12</atmosphereDensity>
                <skyColor>0xAAAAAA</skyColor>
                <biomeIds>115</biomeIds>
            </planet>
        </planet>
    </star>
    <star name="Proxima" temp="10" x="-70" y="-40" numPlanets="0" numGasGiants="0">
        <planet name="Proxima b" DIMID="4">
            <orbitalDistance>92</orbitalDistance>
            <gravitationalMultiplier>96</gravitationalMultiplier>
            <atmosphereDensity>96</atmosphereDensity>
            <biomeIds>14,15,0</biomeIds>
            <skyColor>0xF2BA5B</skyColor>
        </planet>
    </star>
    <star name="Ross 128" temp="15" x="-210" y="56" numPlanets="0" numGasGiants="0">
        <planet name="Ross 128b">
            <orbitalDistance>89</orbitalDistance>
            <gravitationalMultiplier>96</gravitationalMultiplier>
            <atmosphereDensity>119</atmosphereDensity>
            <biomeIds>111,118,0</biomeIds>
            <fogColor>0xE98989</fogColor>
            <skyColor>0xE99989</skyColor>
        </planet>
    </star>
    <star name="Groombridge 34 A" temp="13" x="218" y="0" numPlanets="0" numGasGiants="0">
        <planet name="Groombridge 34 Ab">
            <orbitalDistance>89</orbitalDistance>
            <GasGiant>true</GasGiant>
            <gas>nitrogen</gas>
            <planet name="Groombridge 34 Ab - 1">
                <orbitalDistance>50</orbitalDistance>
                <gravitationalMultiplier>46</gravitationalMultiplier>
                <atmosphereDensity>163</atmosphereDensity>
                <biomeIds>2,130</biomeIds>
                <fogColor>0xFCD03E</fogColor>
                <skyColor>0xFCD03E</skyColor>
            </planet>
        </planet>
        <star name="Groombridge 34 B" temp="11" numPlanets="0" numGasGiants="0" seperation="100">
        </star>
    </star>
    <star name="Tau Ceti" temp="76" x="232" y="62" numPlanets="0" numGasGiants="0">
        <planet name="Tau Ceti g">
            <orbitalDistance>13</orbitalDistance>
            <gravitationalMultiplier>103</gravitationalMultiplier>
            <atmosphereDensity>193</atmosphereDensity>
            <biomeIds>112</biomeIds>
            <fogColor>0xF7EEA9</fogColor>
            <skyColor>0xF7EEA9</skyColor>
        </planet>
        <planet name="Tau Ceti h">
            <orbitalDistance>24</orbitalDistance>
            <gravitationalMultiplier>98</gravitationalMultiplier>
            <atmosphereDensity>166</atmosphereDensity>
            <biomeIds>112</biomeIds>
            <fogColor>0xFFC7F9</fogColor>
            <skyColor>0xFFC7F9</skyColor>
        </planet>
        <planet name="Tau Ceti e">
            <orbitalDistance>53</orbitalDistance>
            <gravitationalMultiplier>87</gravitationalMultiplier>
            <atmosphereDensity>123</atmosphereDensity>
            <biomeIds>37,165,36,112</biomeIds>
            <fogColor>0xF7EEA9</fogColor>
            <skyColor>0xF7EEA9</skyColor>
        </planet>
        <planet name="Tau Ceti f">
            <orbitalDistance>133</orbitalDistance>
            <GasGiant>true</GasGiant>
            <gas>nitrogen</gas>
            <gas>oxygen</gas>
        </planet>
    </star>
</galaxy>

@epicdude312 If you can send us your own XML file, that would be helpful.

Alright, thanks, looks like #1215 may also be related.

Confirmed the issue when editing XML for an existing world.  Fix for next update


Install openshift pipelines operator 0.x.x / triggers 0.x.x

@anneqm - what are the recommended versions of openshift pipelines operator / triggers release for Kabanero release 0.7.0?

@marikaj123 as of now, there are no new Openshift releases of the pipeline and/or  triggers to move up to.  I do see that openshift-pipelines-operator  has a 0.10.6 and a 0.10.7 release available at https://github.com/openshift/tektoncd-pipeline-operator/releases. Quay has those versions as well: https://quay.io/repository/openshift-pipeline/openshift-pipelines-operator?tag=v0.10.7&tab=tags.  These should still be based on Tekton Pipelines 0.10.1 and Tekton Triggers 0.2.1.
@kaczyns Is there any reason to move up from the openshift-pipelines-operator 0.10.4 to one of the newer ones? I'm not aware of a reason to move up at this time.

if it's really just a patch release (ie 0.10.z to 0.10.z') then we would just move up for the sake of getting bug fixes.  I'll take a look and see if anything fundamental changed.

I've asked @dacleyra to take a look at moving up to the latest patch release for Kabanero 0.8.0.

#570 is merged, I am closing this issue.


Update dependencies, use Syscall instead of Syscall6

This PR fixes error when you tries to build app with GOOS=solaris env

Hi @cheggaaa ! Can you please take a look at this PR. The main problem is when you are trying to build some ctl app with your library for solaris OS it crashes with the following error
github.com/cheggaaa/pb/v3/termutil.lockEcho: relocation target syscall.Syscall6 not defined
github.com/cheggaaa/pb/v3/termutil.unlockEcho: relocation target syscall.Syscall6 not defined
make[1]: *** [Makefile:263: app-local-pure] Error 2

Hi! Thank you for PR
I think we need to keep old build rules too (// +build) Go authors recommended having both forms (https://tip.golang.org/doc/go1.17#go-command)
Is it necessary to change the go version for switching to Syscall? Because I think it's good to keep the older version for compatibility reasons.

Thanks! Merged into v3-pooling
Also this or next week I will finally review and test v3-pooling

@cheggaaa it would be great)!

Also i have tested it a little bit)

@cheggaaa, is there an ETA for merging v3-pooling branch into main branch?


PR: v0.1 Changelog, overview and version update

Release notes and latest changelog update.
Fixes #29

@goanpeca, could you give this plugin a test drive and let us know what do you about it? Thanks!


New Reset function

This new Reset function addresses the issue #1302, integrating:

viper.Reset()
reset cached preferred prefix
reset cached transport object
reset Federation metadata
reset Origin exports

If the use case needs to reset all of them, use server_utils.Reset()
If it needs to reset 1-4, use config.ResetConfig()
If only origin exports need to be reset, use server_utils.ResetOriginExports()
The new Reset function lies in server_utils module to avoid cycle import.

address the above issues, could you take another look @bbockelm


Optional action payload

Proposed fix for #81

Well, it breaks a lot of things. Maybe someone else would have a better luck.

Pushed a new version with fixed generics

Published these changed to typescript-fsa-vanuan and typescript-fsa-reducers-vanuan


Failed to load config "react-app" to extend from.

When downloading reduxjs/redux and following instructions to run the todos demo I get
Failed to load config "react-app" to extend from.
Referenced from: /Users/myuser/Sites/redux/.eslintrc.cjs
This is odd as this sits outside my project in this case redux/examples/todos
Anyway after a quick search I ended up here:
https://stackoverflow.com/questions/63912721/failed-to-load-config-react-to-extend-from
Was able to fix this by simply removing redux/.eslintrc.cjs. Not sure if eslint-config-react-app is outdated or not?

Please can you provide more details on the issue:

How can anyone reproduce the error?
Remember to provide the system specs you used when encountered this error.
Logs or screenshots speak a thousand words 🙂

I am sure one of the maintainers or contributors will be able to provide you with a detailed explanation if they understand your context.
Cheers.

I would recommend moving the examples out of the parent project folder. We run the examples in isolation. They haven't been updated in quite some time, so there may be breakage. It might be better to simply copy the code in src into a fresh project.
Regardless, this isn't really a bug with the library, just some outdated examples we should probably remove at some point.


yarn install and laravel mix called more times than needed during gitpod initialization

Describe the bug
There are extranoues yarn installs and laravel mix compiles happening when more than one optional install from starter.ini is set.
Screenshots

Steps to reproduce
set phpmyadmin and react to install, there will be three total calls to yarn install and laravel mix.
Expected behavior
yarn install and laravel mix could be called alot less. once if there are not optiona installs and twice if there are multiple optional installs. maybe even just once for all of it.
Additional information
An API for getting installation information from starter.ini should be built into bash/helpers.sh and used for this feature.
has_installs: echos 1 if anything is installed, echos 0 if otherwise
has_only_phpmyadmin_install: echos 1 if only phpmyadmin is installed but no frontend scaffolding is installed, echos 0 if otherwise
has_only_frontend_scaffolding_install: echos 1 if no phpmyadmin is installed and at least 1 frontend scaffolding is installed.

An API for getting installation information from starter.ini should has been built and added to the codebase however it is not in use and may be removed at a later time. This bug is curretly closed as 'wont-fix' because this featured turned out not to be feasible. Possibly saving a single called to npm install was not worth the future testing, bugs introduced and code convolution a fix like this would create.


add modeOctalString to FileStat for compatibility with Posix tools

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

add modeOctalString to FileStat for compatibility with Posix tools

Thanks for the PR but this is just an equivalent to stat.mode.toRadixString(8). I don't think there is any need to add it as a separate method. Also it is a breaking change for anything implementing the FileStat class.

I was not aware of "stat.mode.toRadixString(8)" is it exactly equivalent?

I guess you might also need to mask things if you don't care about top bits: (stat.mode & 0x1FF).toRadixString(8)


Change Legal Copy

What is this about
There are some copy changes needed in the Create Safe and Load Safe flows.

Change copy
Change text below Safe name input field

By continuing you consent to the terms of use and privacy policy.

Previously it said "consent with the terms..."
Remove second sentence
The second sentence should be removed completely.

Most importantly, you confirm that your funds are held securely in the Gnosis Safe, a smart contract on the Ethereum blockchain. These funds cannot be accessed by Gnosis at any point.

The requested changes appear to be reversed.


Stubbing out MicrosoftTelemetry.h and modifying build to swap in real header

Description
Currently the project includes the official MicrosoftTelemetry.h header, and uses #ifdef's to disable the telemetry from actually firing. Instead we're replacing it with a stubbed header which by default fires no telemetry, and we can remove the #ifdefs and EmitTelemetryEvents flag set during the build
Motivation and Context
We want open source code to be as clear and copy-and-pastable as possible. The current implementation is potentially confusing, and may result in accidental telemetry if the #ifdefs aren't included
How Has This Been Tested?
Tested on a cloned build with an empty stubbed header with and without the move step. Verified that the build fails if the move step is omitted, and passes with the move step, validating that the swap is actually happening.

/azp run

Also update these files to remove reference to EMIT_TELEMETRY_EVENTS/EmitTelemetryEvents:

Build.cmd
environment.props
docs/developer_guide.md

/azp run

/azp run


SwiftyJSON version

Spine currently (0.4) depends on SwiftyJSON 2.3.3, which already exists on GitHub but has not yet been released to CocoaPods.

I've updated the dependencies. Can you check if it works now?


Impossibile unmount sda2 from /

Hi, I'm using with success the first versio of RPI-Clone on a Raspberry with raspbian Linux rpi3mh 4.9.46-v7+ #1032 SMP Wed Aug 30 12:09:14 BST 2017 armv7l GNU/Linux and every synch work fine.
After installing V2 of RPI-Clone, and executing "sudo rpi-clone sda -v", I receive the following message:
Destination disk partition /dev/sda2 is mounted on /.
The clone cannot proceed unless it is unmounted.
Do you want to unmount /?  (yes/no): yes
umount: /: target is busy
(In some cases useful info about processes that
use the device is found by lsof(8) or fuser(1).)
rpi-clone could not unmount /.
Aborting!
The source and destination are the same...
Where is the problem?
Please help me.
Thanks
Guido

sudo rpi-clone sda -v

This command will clone to sda...

Destination disk partition /dev/sda2 is mounted on /.

... but sda is the disk that you booted from.  In other words you are trying to clone sda to sda which is a bad idea.  You need to either clone to a different disk or boot from a different disk,

That's not necessarily meaning that sherazan booted from sda. rpi-clone 2.0 is broken since many months,  see issue #49. Fix is to roll back to last known working 1.x, see https://github.com/billw2/rpi-clone/issues/49#issuecomment-338959704

Same here, i roll back to 1.7.1 and all work fine.
When you could fix the 2.x version?


Add static rendering

We should add the possibility to render sites to static markup. This can be used with Github Pages and running applications in general without the need for a node backend.
I have started on this and it's not that far off. However it would be nice to land the v1.0 of the CLI before releasing it.

I absolutely dig this, that woud be useful for generating styleguides and documentation.
I think this goes with "make react-router configurable", expecially the history params: browserHistory (which depends from server) vs hashHistory (which is client only).

We have moved the code to rocjs/roc-package-web-app-react and will continue all further development there. Could you create this issue there as a feature request? 🙂
I still have a working prototype of this locally and will just need some improvements before it can be included as a default feature.


Making bindings configurable

The <C-CR> key sequence does not work in some terminals, the bindings for restore, yank deletions, and yank additions should be user configurable.
Also, the descriptions in telescope whichkey (<C-_> in insert mode, ? in normal) show  as the action name instead of the mapped action.

It is possible to remap keys now. I haven't gotten the telescope whichkey (TIL, didn't know about that at all) to work though. Can you point me to an extension that gets this right?
Also: Remapping the action now changes how this should be installed, as this extensions actions need to be available when telescope's setup is called. I.e. the requirements need to be the other way around, as outlined in the README now. I don't quite like it, is that how this key remapping normally works?

Neoclip shows bindings in the whichkey prompt for a few actions (paste, paste_behind, etc.).


pegasus: Add version alpha16-42-g996720eb

Closes #518

[x] I have read the Contributing Guide.

/verify

Your welcome @Calinou


Another cool idea for an example...

It would be cool if you had an example where a modal pops up, and the rest of the screen gets dark with input disabled

I can add that feature in. I've been working on another project that you'll probably have some interest in. So, I've been slow to work on this control.

Thanks for the suggestion. I'll add this to my list.


Error: 'GcmAndroid.launchNotification internal', undefined

I understand the there's a previous post https://github.com/oney/react-native-gcm-android/issues/30 about this error and the code worked later. However, in my case, even after I restart the app, it still shows error of 'GcmAndroid.launchNotification internal', undefined. My env specs:
RN 0.24
Android 4.4.2 on Genymotion
Latest version of this module and the notifications module
Many thanks!

That might not be an error. It's just the line
console.log('GcmAndroid.launchNotification internal', GcmAndroid.launchNotification);
inreact-native-gcm-android/index.android.js
which runs every time it starts. It's undefined, if the system didn't start it with a notification.


Adds the ability to preserve static assets in final image

By setting BP_INCLUDE_FILES those files will be included in the final
image

I think I have a preference for BP_KEEP_FILES. The word "include" sounds to me like you are pulling in some files that come from elsewhere, not the codebase.


ICMP Tracker issue with ubuntu 16.04

Home Assistant release (hass --version): 0.39.2
I'm running the dev branch version of pin.py 30bed83 but the same thing happened in the 0.39.2 version
Python release (python3 --version): Python 3.5.2
Component/platform: ping / Ubuntu 16.04
Description of problem:
subproccess fails to fire the ping command.
ping lives in /bin but it looks like subprocess is looking somewhere else.
changing ping_cmd and pinger  to:
self._ping_cmd = '/bin/ping -n -q -c1 -W1 ' + self.ip_address
pinger = subprocess.Popen(self._ping_cmd, stdout=subprocess.PIPE, shell=True)
seems to fix this

This looks like a duplicate of #5930.

@amh58, please re-open this issue if you still have problem which were not solved with #5930.


Zero values at T0

Greetings,
I am working with data obtained from shRNA screens performed using Affymetrix arrays. I am trying to prepare the file containing LogFC between T2 and T0; however, I have cases in which the value at T0 = 0. What should I do with these cases?
Thank you very much!
Regards,
Anna

Hi Anna,
Thank you for using BAGEL2.
If your screen contains zero values in the ctrl sample, you can give pseudo-values or discard them.
BAGEL fc options
--min-reads=N                            Discard gRNA with T0 counts < N (default 0)
-Np, --pseudo-count=N	     Add a pseudocount of N to every readcount (default 5)
Best,
Eiru Kim

Hi Anna,
Thank you for using BAGEL2.
If your screen contains zero values in the ctrl sample, you can give pseudo-values or discard them.
BAGEL fc options
--min-reads=N                            Discard gRNA with T0 counts < N (default 0)
-Np, --pseudo-count=N	     Add a pseudocount of N to every readcount (default 5)
Best,
Eiru Kim

Hi Eiru,
Thank you very much!
Regards,
Anna

Hi Eiru,
Thank you very much!
Regards,
Anna


Have a white card, but it's not incrementing rounds with Paint Voucher?

It's not going up even though I've "held" it for several rounds now, it's like it's stuck at zero.

This was a bug with an old version of Cryptid. Can you try updating to the latest version?


Arrow icon name mismatching

Please describe the problem
The names of arrow icon are mismatching.
Describe the solution you'd like
I can change the name and match them properly.
Assign me this under GSSoC'23
Screenshot

Killer2OP

Thank you, @Killer2OP, for your response. You are welcome to continue with your code contribution. Please ensure that you follow the code standards and include a screenshot when submitting your pull request.

@bookingjini sir can i do this task under gssoc'23


[Proposal] - Contributing Guidelines Necessary

Is your feature request related to a problem? Please describe.
The repo is missing some nice guidelines for developers to know how to contribute.
Describe the solution you'd like
Add a contributing guidelines.
Describe alternatives you've considered
N/A
Additional context
N/A

Closed! This is now in the .github folder