Autoload order is not affected by override.cfg

Godot version
4.0.b13, 3.5.stable, 3.4
System information
OSX
Issue description
Overriding autoloads with an override.cfg ignores the order set in the override. Newly defined autoloads are always loaded last.
Why does this matter? I'm trying to (co-)create a mod loader that works with any Godot game. The loader itself is an autoload. With the override we can 'install' it into a game without having to touch or modify its source code. The loader always being last limits the capabilities for extending existing autoloads heavily.
Steps to reproduce

Have a project with at least one autoload and one other script to make a new autoload
create an override.cfg
add the other script to the overrides and move it into the first spot
run game

; project.godot
[autoload]

Autoload1="*res://autoload_1.gd"
Autoload2="*res://autoload_2.gd"

; override.cfg
[autoload]

AutoloadOverride="*res://autoload_override.gd"
Autoload1="*res://autoload_1.gd"
Autoload2="*res://autoload_2.gd"

result: order does not matter, the autoload from the override is always last
autoload 1 init
autoload 2 init
autoload override init
autoload 1 ready
autoload 2 ready
autoload override ready

each file only contains this
extends Node

func _init() -> void:
	print("autoload x init")

func _ready() -> void:
	print("autoload x ready")

Minimal reproduction project
for 3.5, but also works after 4.0 conversion
AutoloadOverrideReproduction.zip

This is because the override.cfg file adds settings, rather than replacing them (e.g. if you only included the AutoloadOverride entry and nothing else, the autoload 1 and 2 prints are still there).
Since autoloads are the only project setting that is "order-dependent", not sure what a good solution would be here, but I don't think this is a bug, but rather a feature request.
Can't find a workaround, since even a custom MainLoop type seems to initialize later than any autoloads...

This is because the override.cfg file adds settings, rather than replacing them

That is very unexpected behaviour for something called override
Especially with the wording in the documentation

Overriding: Any project setting can be overridden by creating a file named override.cfg in the project's root directory. This can also be used in exported projects by placing this file in the same directory as the project binary. Overriding will still take the base project settings' feature tags in account. Therefore, make sure to also override the setting with the desired feature tags if you want them to override base project settings on all platforms and configurations.

I suppose it is the way it works for most properties since they only have a single value, so nothing can be 'added' to it.
I would really love to have this, if only for autoloads and nothing else. If someone can point me in the right direction, I am completely willing to implement it myself - I just don't know what to go off of
And I feel like the changes necessary will probably fit well with these two PRs from last week

#71325
#70557

override.cfg does override the values of existing properties, and appends new property/value pairs which aren't present in the original project.godot.
The problem here is that autoloads as registered as properties themselves. And there doesn't seem to be a mechanism for removing existing properties.
Changing it to e.g. a dictionary property could make the dictionary overridable, e.g.:
[autoload]

autoloads={
  "AutoloadOverride": "*res://autoload_override.gd",
  "Autoload1": "*res://autoload_1.gd",
  "Autoload2": "*res://autoload_2.gd",
}

But that's indeed material for a feature proposal, so we can discuss possible solutions and implement the best one.

Closing in favour of the new proposal #6137


Vapor 4

Converted to support last Vapor 4 beta

Can you point this to the 4 to start with? We won't merge it in to master until Vapor 4 is tagged

Sorry, I mixed up.

No worries, you can ignore my last comment then since that's not something you've done. Feel free to implement though!


Day78

Resolves #165 .

Pull Request Test Coverage Report for Build 331

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 329:
0.0%

Covered Lines:
24

Relevant Lines:
24

💛  - Coveralls


Add accessibility features tables to hold structured accessibility data

This originated from #67.
Context:
We need to add structured accessibility data, so we can filter and search on it, and show more consistent accessibility information to users.
We have a form we've been sending to property managers, and collected some accessibility data that we need to be able to store.
Work:

We need to add two tables:

UnitAccessibilityFeatures to store unit-specific features that foreign-keys to the listing
BuildingAccessibilityFeatures to store building-specific features that foreign-keys to the listing

Add some seed listings that use this data and seed the database with the right accessibility features. (Maybe that's part of the migration?)

I'm not sure if it will be best to store these as

1 feature per row, with columns for the feature name, the key, and whether all/some/none of the units have the feature
1 building per row, with columns for each feature.
Probably the first one is better.

The questions asked in the form are:

Do any units in your building have the following accessibility features for residents with disabilities?

[In Unit Washers and Dryers]
[Barrier-free entrances (meaning no steps or ramps are needed to get into a unit)]
[Doorways to units are big enough for a wheelchair]
[Roll-in shower for residents using wheelchairs]
[Grab bars in bathrooms]
[Lowered light switches for those using wheelchairs to be able to reach]
[Lowered cabinets for those using wheelchairs to be able to reach]

Property Managers are able to provide the following responses for each category:

No units in this building have these features
All units in property have these features
Only specific "accessible units" have these features

Does your building offer any of the following accessibility features? These answers will help residents with disabilities understand if this property can meet their needs.
Property Managers can select any of the following options:

Elevator
Laundry room
Allows service animals
Handicapped parking spots
Doorways to property are big enough for a wheelchair
Units accessible for those with mobility-related disabilities
Units accessible for those with vision-related disabilities
Units accessible for those with hearing-related disabilities

Done
Done is when these tables exist and we've contributed the upstream.
Other considerations:
The listing form in the partner portal lets you add an Accessibility Priority Type to the summary. I'm not sure how that intersects with this:

This seems like a really complex solution. I'm wondering how much of it is caused by the fact that the property managers can answer "none", "all", or "some" to which units have these. Do we know what kind of data we're actually getting in response to these questions?
I'm also thinking about what kind of data would be available via rentlinx about the building/units for future automation.

After doing some accessibility testing, here are the features that we'd like to add. These are all boolean features that will be stored at the building level (the complexities that Will mentioned in his previous comment, combined with the limited time left, seem to make unit-level properties out of scope). Exact labels are TBD:
Elevator
Wheelchair Ramps
Allows service animals
Accessible parking
In unit washer and dryer
Barrier-free unit entrances
Roll-in shower
Grab Bars
Laundry in building
Parking on site
Heating in unit
AC in unit


(Not model-viewer) SceneViewer preview is broken in Chrome, throws exceptions

Description
The Google AR/VR SceneViewer preview website (important to test if experiences work in SceneViewer and the only way to see actual warnings and error messages for that) seems to be down.
The console shows an error about some stuff being deprecated in Chrome (minus the slow network warning):

Live Demo
https://arvr.google.com/scene-viewer-preview
Version

model-viewer: vX.X.X

Browser Affected

[X] Chrome, version: xx.x.xxxx.xx
[ ] Edge
[ ] Firefox
[ ] IE
[ ] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[X] Windows

AR

[ ] WebXR
[X] SceneViewer
[ ] QuickLook

FYI @tpsiaki. For what it's worth, we're  in the  process of deprecating this in favor of our  editor anyway. Using that to deploy to Scene Viewer for AR is actually a more accurate test anyway (since the web and native code stacks have some differences). If you find anything is missing from our editor, please let us know and  we'll be sure to add it!

@hybridherbst thanks for the report. As Emmett mentioned we're working toward a point where validation can be done with model-viewer and there's consistency in terms of glTF support between Scene Viewer and model-viewer.
The issue has to do the way the previewer is iframed, so you can work around it for now by using the version of the previewer that's served in the previewers iFrame here: https://scene-viewer-preview.appspot.com/

@tpsiaki feature parity between SceneViewer and model-viewer would obviously be ideal, or SceneViewer using any known and testable rendering framework (bei it model-viewer/three or Filament or ...) 😁- really looking forward to that!
Thanks for that link, I wasn't aware of that existing - this works and immediately shows me 3 candidates for issues that could prevent this file in particular from working in SceneViewer (which is helpful even if the Preview pretends it should be working).

@hybridherbst one other note on Scene Viewer's handling of models - the warnings that you see in the previewer have gotten somewhat stale and aren't always indicative of real problems in Scene Viewer. At the moment if your model loads and displays in that previewer (which it does seem to for me) then it's very likely that it will work in Scene Viewer on mobile, even if there are some warnings showing up.
Of course, some of the warnings (like file size, texture size) will result in longer load times and higher GPU memory use, which might result in failures or poor experiences for users with poor connections or very low end devices. But, we don't have hard enforced limits about these particular warnings on Scene Viewer.

@tpsiaki I understand these points well since they are pain points in our projects :)
Would be curious if the above link (http://amuse.vision/ar/Nymph/) opens in SceneViewer for you? Definitely doesn't for me.
Is there a way to see debug messags from on-device SceneViewer on Android? I looked in adb but there weren't any as far as I remember.

@hybridherbst it doesn't work for me but the reason it's failing is that you're passing this parameter for the sound file: sound=http%3A%2F%2Famuse.vision%2Far%2FNymph%2F. Scene Viewer is then trying to load http://amuse.vision/ar/Nymph/ as an audio file. If you remove the sound parameter, or set it to something that's a valid audio file it should work. For example, this link loads correctly for me (which is the same as in your demo, but with sound param removed): https://arvr.google.com/scene-viewer/1.0?mode=ar_preferred&v=132767069201351460&link=https%3A%2F%2Fprefrontalcortex.de%2F&disable_occlusion=true&file=http%3A%2F%2Famuse.vision%2Far%2FNymph%2FNymph.glb%3Fmode%3Dar_preferred%26v%3D132767069201351460%26sound%3D%26link%3Dhttps%3A%2F%2Fprefrontalcortex.de

Thanks @tpsiaki for letting me know, I had definitely overlooked that.
Is there a way to see debug messags from on-device SceneViewer on Android?

You should see some debug messages if you run adb logcat. For example, with your demo this line showed up in logcat:
Failed to Load Gltf url 'http://amuse.vision/ar/Nymph/Nymph.glb?mode=ar_preferred&v=132767069201351460&sound=&link=https://prefrontalcortex.de' reason: Media Player Error (what 1, extra -2147483648: Error: Unknown Media Error, Reason: System Error)
Which doesn't exactly say that the sound is the problem, but it was surprising to see that the sound url here was empty and then that the error was about playing media.
Generally if there's an error related to loading the glTF file itself (such as a failure to load an image or something like that) then that will show up in logcat.


Add missing types in exports section of package.json

This PR adds missing types in exports section of package.json.
This fixes the issue of not getting type info from the package.

Fixes: https://github.com/extractus/feed-extractor/issues/85

@M4RC3L05 thank you, I will merge this pr now.


how to finetune with 'system information'

Hello,
I am training with my custom dataset, and have a question there.
What I wanted to make is assistance that can recommend me a proper mode of device depending on my conversation.
Before inserting q/a pairs, I want to let model know about the general information of 'how to use' the device.
I tried to insert like below.
SYSTEM:
    There are 4 options in the mode
    - mode1
    - mode2
    - mode3
    - mode4

   you need to generate 'json' format using USER input with the proper mode.
   Desired output format is below.
   {
        'mode': [selection of mode]
        'comments': [your response]
    }

USER: example1
ASSISTANCE: response1

USER: example2
ASSISTANCE: response2

USER: example3
ASSISTANCE: response3

But it seems like the model doesn't know about the initial information about the device.
Is there any specific format like 'USER' and 'ASSITANCE' for teaching the information as well?
Thanks,

Try more samples (like over 300) and more epochs. Set the learning rate higher to slightly overfit it.


feat(pair): support keepCstNodes

change flowChar from string to { char: string, offset: number }
support keepCstNodes for Pair

This way we can extract all the information from ast/cst without performing some pair logics ourselves. (so that I can remove duplicate codes in yaml-unist-parser and focus on AST transformation and comment attaching.)

Not sure what happened on node 6, I cannot reproduce it locally.

Regarding the node 6 failure, don't worry about it; it's this Jest issue that apparently got fixed today, and should make its way out in a release pretty soon.

(I'm going to extract the FlowChar part to another PR and focus on the keepCstNodes thing in this PR.)

My goal is to have accurate ranges for mappingKeys (starts with the optional ? and ends with the key node) and mappingValues (starts with : and ends with the value node), but after second thought, the proposed change (the keepCstNodes part) is not necessary since I can easily split their ranges using , as a separator, and which item should be included in a Pair's cstNodes is arguable (to include comments or not) so I'm closing it for now. Thanks for the detailed review.


View policy errors from policy browser

At the moment we have a distinct icon to show that OPA has marked a policy as having errors, but we don't show the errors.  We need to do that!

Fixed via #18.


Fix status check in wait method

In the wait method the id instead of the status is used to check if the prediction finished

Derp, thanks for the PR!


Cast from float16 to uint8 was not supported by CUDA

Example code
expr_text = """v0.0.3
fn(%data: Tensor[(1, 1, 1, 1), uint8]) -> Tensor[(1, 1, 1, 1), uint8] {
  %0 = cast(%data, dtype="float16");
  cast(%0, dtype="uint8")
}
"""

func = relay.parser.fromtext(expr_text)

with relay.build_config(opt_level=3):
    graph, lib, params = relay.build(func, target='cuda')

Output:
my_kernel.cu(4): error: more than one conversion function from "half" to "unsigned char" applies:
            function "__half::operator float() const"
            function "__half::operator short() const"
            function "__half::operator unsigned short() const"
            function "__half::operator int() const"
            function "__half::operator unsigned int() const"
            function "__half::operator long long() const"
            function "__half::operator unsigned long long() const"
            function "__half::operator __nv_bool() const"

After looking into cuda_fp16.h, found that no direct conversion from fp16 to uint8/int8.
Suggest to warn the user who want to this conversion, or conver it to uint16/int16 and then to uint8/int8 internally.
You may close this issue after reading.
P.S. I am sorry that I open too many small PRs and issues in short period of time. xD

I also found that relay.clip does not support fp16 operation for cuda

Would be great if you can send a PR to add an error when user performs such conversion

void CodeGenCUDA::VisitExpr_(const Cast* op, std::ostream& os) {
  bool fromHalf =
      op->value.type().is_float() && op->value.type().bits() == 16 && op->value.type().lanes() == 1;
  bool toint8 = (op->type.is_int() || op->type.is_uint()) && op->type.bits() == 8 && op->type.lanes() == 1;
  if (fromHalf && toint8) {
    std::stringstream value_16;
    std::stringstream value_int8;
    this->PrintExpr(op->value, value_16);
    auto inter_type = op->type.is_int() ? Int(16) : UInt(16);
    value_int8 << CastFromTo(value_16.str(), op->value.type(), inter_type);
    os << CastFromTo(value_int8.str(), inter_type, op->type);
  } else {
    CodeGenC::VisitExpr_(op, os);
  }
}

Just for the record

Also I found before CUDA 10.2, there is no support for absolute value APIs for half-precision.

close for now due to inactive status, i believe there were a few recent improvement by @wpan11nv that might be relevant, feel free to open new forum thread or issue if there are more things to be addressed

If you take a look here
auto inter_type = op->type.is_int() ? Int(16) : UInt(16);
    value_int8 << CastFromTo(value_16.str(), op->value.type(), inter_type);
    os << CastFromTo(value_int8.str(), inter_type, op->type);

We need to convert to uint16 and then cast to uint8. No direct conversion from fp16 to uint8.
ref: https://docs.nvidia.com/cuda/cuda-math-api/group__CUDA__MATH____HALF__MISC.html#group__CUDA__MATH____HALF__MISC

cc @wpan11nv @Hzfengsy

Looks like there is a choice on rounding mode. If rounding mode is not important, then a fix in CUDA code  is fine.

I think we can pick a rounding mode and add a support. Most rounding mode from fp -> int are round down

Although rounding is important, but here is a legitimate type conversion but no compiler support or native support on our target device.
I will suggest we implement type converter or add a cast function to TVM Type class. And then we can add global flags to control type conversion, like which rounding mode we should use as default.
But the drawback is we need to write codes for all target device and different compilers.

Let us try an impl that support round down behavior, which is typical in float to int conversion

What is the current status of this issue? Does some one working on it?

@hgt312 feel free to take over, right now this issue has not been addressed


Update generated files to fix CI build

The schema.json and links.json files were not up-to-date, probably because a merged PR overwrote some changes from an earlier PR.
The correct schema have been generated by running 'bundle exec rake'.

The jenkins.sh script has a check [1] to try and prevent this, so if this has happened, that might not be working.
1: https://github.com/alphagov/govuk-content-schemas/blob/481f55587a87c898689400eeba71c6f6a7eeb680/jenkins.sh#L35

The jenkins.sh script has a check [1] to try and prevent this, so if this has happened, that might not be working.

That's the check which caused the master build to fail: https://ci.integration.publishing.service.gov.uk/job/govuk-content-schemas/job/master/470/console
So the sequence of events is:

PR #476 was opened. All checks passed
PR #479 was opened. All checks passed.
#479 was merged. master build succeeded.
#476 was merged. master build failed.

Would you have expected GitHub to trigger another branch build of 476 after step 3? That would have caught this issue, but I don't know enough about the Jenkins webhook to know if it's supposed to be configured to do that.

That's the check which caused the master build to fail: https://ci.integration.publishing.service.gov.uk/job/govuk-content-schemas/job/master/470/console
So the sequence of events is:
PR #476 was opened. All checks passed
PR #479 was opened. All checks passed.
#479 was merged. master build succeeded.
#476 was merged. master build failed.

Would you have expected GitHub to trigger another branch build of 476 after step 3? That would have caught this issue, but I don't know enough about the Jenkins webhook to know if it's supposed to be configured to do that.

Ah, ok, that explains it. That setup would be better where builds dependent on the state of master get re-run when master changes, but I have no idea if its possible or how to do it.

The checks for this branch are failing, but I think it's an issue with one of the CI agents. I'm looking into it.


Remove "required" from description of --yes flag in set-admin command

This would have users add the --yes flag automatically, without first understanding the warnings of this command.

Removed flag from command


LDAP works with manage.py query_ldap but login does not.

Hi,
thank you for dockerizing zulip! We have a community project in Germany where I try to set this up. I managed to get LDAP working somehow.
./manage.py query_ldap username
email<EMAIL_ADDRESS>first_name: ['user']
last_name: ['name']

The Login however does not. We have the following settings in our docker-compose.yml:
      ZULIP_AUTH_BACKENDS: "ZulipLDAPAuthBackend"
      SETTING_AUTH_LDAP_SERVER_URI: "ldap://ldap"
      SETTING_AUTH_LDAP_BIND_DN: "cn=admin,dc=domain,dc=ending"
      SECRETS_auth_ldap_bind_password: "topsecret"
      SETTING_AUTH_LDAP_USER_SEARCH: 'LDAPSearch("ou=users,dc=domain,dc=ending", ldap.SCOPE_SUBTREE, "(uid=%(user)s)")'
      SETTING_LDAP_APPEND_DOMAIN: None
      SETTING_LDAP_EMAIL_ATTR: "mail"
      SETTING_AUTH_LDAP_USER_ATTR_MAP: '{ "first_name": "givenName", "last_name": "sn", "email": "mail" }'

I can't find any logs where an error gets posted. Can somebody help us? Thank you very much!

What gets logged in /var/log/zulip/server.log when you try to login?

It has the following log output:
2018-05-27 08:47:30.023 INFO [zr] <IP_ADDRESS>     GET     302  83ms (+start: 840ms) / (unauth via ?)
2018-05-27 08:47:31.042 INFO [zr] <IP_ADDRESS>     GET     200 208ms (db: 4ms/3q) (+start: 794ms) /login/ (unauth via ?)
2018-05-27 08:47:32.046 INFO [] Tornado   0.0% busy over the past 60.0 seconds
2018-05-27 08:47:32.244 INFO [zr] <IP_ADDRESS>     GET     404 945ms (db: 4ms/2q) /django_static_404.html (unauth via ?)
2018-05-27 08:47:36.625 INFO [zr] <IP_ADDRESS>     POST    200 258ms (db: 5ms/4q) (+start: 837ms) /accounts/login/ (unauth via ?)
2018-05-27 08:47:36.756 INFO [zr] <IP_ADDRESS>     GET     404  25ms (db: 2ms/2q) /django_static_404.html (unauth via ?)

I also tried saving passwords in a different hash format (md5, sha, ssha). Sadly this did not do the trick. I was also syncing ldap accounts between the format changes to make sure it has the correct information.

What are you entering in the login form?  I believe with that configuration, users should be entering their LDAP username and password.
The other thing you can check is what you ended up with at the bottom of /etc/zulip/settings.py -- it's possible the LDAP backend configuration isn't going through correctly.

(Also, did you create an organization before trying to use LDAP?  You have to use EmailAuthBackend for organization creation)

Thank you for your suggestions! I will try that as soon as I have the time and report back here.

Your aducated guess was right. I forgot to create an organization before using LDAP. Everything work flawless now. Thank you so much!


Minified version of 1.10 replaces entire line upon selection.

Steps to replicate...
include dependencies jquery, caret, atwho v1.10.
Only the minified version of v1.10 seems to be affected.

Type some stuff then at end of line, do '#' and select any option. It will work fine.
Press enter for new line. Repeat step 1. See that it replaces the entire line with the selected word

html
<div contentEditable='true'>

and js
$('div[contenteditable]').atwho({
    at: "#",
    data: ["budget", "timeline", "authority", "need", "painpoint"],
    insertTpl: '#${name} '
})

which browser?
I can't reappear this bug. It would be great to show me a demo on jsfiddle or others tool.

Ah sorry, appears to be user error. :)


Change the README.md's description will be helpful.

Alex can change "npm init" to "npm install" because init means initiation and this API is already initiated so init is not necessary.

Fixed


Add parameters for number of cpu, IP and Port to start script

Could we have a parameter like cpu_number= or cpu_threads, server_ip= and server_port= with the start script? app.py already has some parameters like this. Perhaps we could pass the parameters directly from the firststart-webui.sh (root directory in the zip file) to the  second one start-webui.sh?

For ip, you can use some CLI arguments.
e.g.) If you want to use <IP_ADDRESS>:8080 as a URL, you can use server_name and server_port.
https://github.com/jhj0517/Whisper-WebUI/blob/4e55844c653b193eeb4c534a0d2aa731ccaf97fe/start-webui.sh#L4
Edit this to:
python app.py --server_name <IP_ADDRESS> --server_port 8080

Read Command Line Arguments for other CLI arguments.
Regarding cpu threads, I may add it as a CLI or Gradio UI argument.

@linuxlurak
As I researched, faster-whisper uses the OMP_NUM_THREADS environment variable for the default cpu_threads:
https://github.com/SYSTRAN/faster-whisper/blob/d57c5b40b06e59ec44240d93485a95799548af50/faster_whisper/transcribe.py#L613-L614
( It's written as 16 in the repository, but it is 0 in the pypi package, so it uses OMP_NUM_THREADS anyway.  )
So I think you can edit start-webui.sh like this:
#!/bin/bash

export OMP_NUM_THREADS=4  # Number of CPU threads you want

source venv/bin/activate
python app.py "$@"

echo "Launching the app"

Can you check?


warning: pointers to arrays with different qualifiers are incompatible in ISO C

after commit 05387571f57224f8cbc2b390b423dab6b9158988
linmath.h: In function ‘mat4x4_mul’:
linmath.h:174:16: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
174 |  mat4x4_dup(M, temp);
|                ^~~~
linmath.h: In function ‘mat4x4_translate_in_place’:
linmath.h:198:17: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
198 |   mat4x4_row(r, M, i);
|                 ^
linmath.h: In function ‘mat4x4_rotate’:
linmath.h:225:19: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
225 |   mat4x4_scale(S, S, s);
|                   ^
linmath.h:229:17: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
229 |   mat4x4_sub(C, C, T);
|                 ^
linmath.h:229:20: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
229 |   mat4x4_sub(C, C, T);
|                    ^
linmath.h:231:19: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
231 |   mat4x4_scale(C, C, c);
|                   ^
linmath.h:233:17: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
233 |   mat4x4_add(T, T, C);
|                 ^
linmath.h:233:20: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
233 |   mat4x4_add(T, T, C);
|                    ^
linmath.h:234:17: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
234 |   mat4x4_add(T, T, S);
|                 ^
linmath.h:234:20: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
234 |   mat4x4_add(T, T, S);
|                    ^
linmath.h:237:20: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
237 |   mat4x4_mul(R, M, T);
|                    ^
linmath.h: In function ‘mat4x4_rotate_X’:
linmath.h:252:19: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
252 |  mat4x4_mul(Q, M, R);
|                   ^
linmath.h: In function ‘mat4x4_rotate_Y’:
linmath.h:264:19: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
264 |  mat4x4_mul(Q, M, R);
|                   ^
linmath.h: In function ‘mat4x4_rotate_Z’:
linmath.h:276:19: warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic]
276 |  mat4x4_mul(Q, M, R);

This will probably require changing the const type specifiers removed, due to the way typedef works.

This will probably require changing the const type specifiers removed, due to the way typedef works.


Reading images day 5 %%time

The notebook reading images day 5 wfm except for the cell
# Do not run this cell in Google Colab
%%time
image_location = 'images/mri.ome.zarr/s0'
data = load_binary_from_local_with_data(image_location)
print(data.shape)

Response
UsageError: Line magic function `%%time` not found.
Can we remove or replace ?

Fixed see https://github.com/ome/EMBL-EBI-imaging-course-04-2024/pull/11


Error opening help

Describe the bug
The help functionality fails with a lua error on my system with Invalid key 'border'.
To Reproduce
Steps to reproduce the behavior:

Open an org buffer
Hit ? to open help

Screenshots

System information:
 % nvim --version
NVIM v0.5.0-856-g7dfeadb0f
Build type: Debug
LuaJIT 2.1.0-beta3
Compilation: /usr/lib/ccache/cc -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=1 -I/home/james/src/neovim/build/config -I/home/james/src/neovim/src -I/home/james/src/neovim/.deps/usr/include -I/usr/include -I/home/james/src/neovim/build/src/nvim/auto -I/home/james/src/neovim/build/include
Compiled by james@slug

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/home/james/.local/share/nvim"

Run :checkhealth for more info

Do you have latest neovim? Seems  like you have the older version which does not support borders.

Good point, thanks for the help. I'll try upgrading. If that's indeed the case is there some way we could build in a warning conditional on neovim version?

I don't think there's a way to check that. V0.5 that is officially being released on Friday will have it, so I don't think we should bother about this.

FWIW here's how you might do such a check: https://vi.stackexchange.com/a/9942

FWIW here's how you might do such a check: vi.stackexchange.com/a/9942

Thanks, but I still think it's not worth it.


Performance gaps research for Omnisci

Reality (omnisci) vs. roofline simulation vs. theoretical limits: quantitative and quality analysis of

[x]  NYC taxi
[ ]  Mortgage
[ ]  Census
[ ]  Thuntunder

...
Questions:

[ ]  Scalability?

[ ]  Why the gaps? Advisor/VTune traces

[ ]  How to fix them?

[ ]  What is the maximum scalability of readcsv/scan/map/..

[ ]  How to build the threading layer

[ ]  Icelake?
...

starting on this

latest result


fix(Datastore): read only transaction options

Datastore's Read Only transactions are broken, due to a class alias (Readonly -> PBReadOnly) introduced in https://github.com/googleapis/google-cloud-php/pull/5402. Probably it was not completely handled in https://github.com/googleapis/google-cloud-php/pull/5843.
(follow the class: google-cloud-php/Datastore/src/V1/TransactionOptions for more details)
Following a similar change done in Spanner: https://github.com/googleapis/google-cloud-php/pull/5377, it seems we need to override the class selection from ReadOnly to PBReadOnly based on PHP version dynamically at runtime.

TransactionsOptions->ReadWrite or ReadTime isn't supported in emulator, so we never catch this failure in PR tests.
Failure only occurs in GrpcMode while using transaction options.

Tests
1. The current behavior in PROD is like this (before the changes in this PR):
➜  Datastore git:(datastore_read_only_transaction) git checkout main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
➜  Datastore git:(main) vendor/bin/phpunit -c phpunit-system.xml.dist --filter="RunTransactionTest::testTransactionWithReadTime"
PHPUnit 8.5.33 by Sebastian Bergmann and contributors.

.PHP Fatal error:  Couldn't load generated class Google\Cloud\Datastore\V1\TransactionOptions\ReadOnly in /usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/vendor/google/gax/src/Serializer.php on line 361
➜  Datastore git:(main)

2. Even with the changes, it seems we cannot initialize the protobuf classes at runtime:
➜  Datastore git:(datastore_read_only_transaction) vendor/bin/phpunit -c phpunit-system.xml.dist --filter="RunTransactionTest::testTransactionWithReadTime"
PHPUnit 8.5.33 by Sebastian Bergmann and contributors.

.E                                                                  2 / 2 (100%)

Time: 58.17 seconds, Memory: 10.00 MB

There was 1 error:

1) Google\Cloud\Datastore\Tests\System\RunTransactionTest::testTransactionWithReadTime with data set "grpcClient" (Google\Cloud\Datastore\DatastoreClient Object (...))
Exception: Couldn't find descriptor. Note only generated code may derive from \Google\Protobuf\Internal\Message

/usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/src/V1/TransactionOptions/PBReadOnly.php:39
/usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/src/Connection/Grpc.php:148
/usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/src/Operation.php:280
/usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/src/DatastoreClient.php:594
/usr/local/google/home/vishwarajanand/github/google-cloud-php/Datastore/tests/System/RunTransactionTest.php:126

ERRORS!
Tests: 2, Assertions: 5, Errors: 1.
➜  Datastore git:(datastore_read_only_transaction)

Seems it was happening due to protobuf being a little stale. Closing this PR.

For anyone else encountering this issue, it happens when the protobuf c-extension is not upgraded at least to the version in which we added support for PBReadOnly.

I ran pecl install protobuf and it started passing. Weird! closing this bug after getting this confirmation.


Error pulling metadata - but only using command palette, on Windows, very first time. Repo and YouTube link provided.

Summary
A bit of context first - I am a DEX602 instructor (Salesforce's LWC Class) and also helped build the course. This issue is impacting students on Windows machines. I have spent several hours troubleshooting this so that I could provide a very simple reproducible issue.
In the beginning of the course, we ask students to do the following:

Create a scratch org using a repo provided by class.
Create a custom lwc and place it on a new custom flexipage.
Pull metadata back down to repo.

The metadata pull fails for Windows users - and ONLY Windows users. It only fails the first time, and it only fails that first time if they use the command palette command SFDX: Pull Source from Default Scratch Org rather than typing sfdx force:source:push in a terminal.
I am unable to reproduce the issue on a Mac, and I am also unable to reproduce the issue if I directly use the sfdx force:source:pull command from a Windows terminal rather than the command palette. Also, if I use SFDX: Pull Source from Default Scratch Org and Override Conflicts the first time, everything comes through fine.
I have significantly simplified the issue by providing an extremely basic project and a short set of steps to follow to reproduce. To be extra clear, I've created the following YouTube video because you almost have to see it to believe it: https://www.youtube.com/watch?v=aCZ_Zxakbh0
We can work around it by having Windows students run the pull twice from command palette, or use the force override palette command, or run the pull directly from a Terminal, but if we have to do that it would be nice to provide some sort of explanation for this quirk.
Steps To Reproduce:
Repository to reproduce: cli-conflict

Use a Windows machine
Clone repo https://github.com/jflowers45/cli-conflict
Make sure a default dev hub is set
Run CreateOrg.bat
Create a flexipage in the scratch org, activate it and add it to the Commerce App and Mobile Navigation Menu
Run the command - MUST use the command palette -  SFDX: Pull Source from Default Scratch Org
Run the command a second time using the command palette -  SFDX: Pull Source from Default Scratch Org

Expected result
First metadata pull succeeds.
Actual result
First metadata pull gives a conflict on the training user profile. Second metadata pull succeeds.
Additional information
YouTube video: https://www.youtube.com/watch?v=aCZ_Zxakbh0
SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.68.6-d37008df83 win32-x64 node-v12.18.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.0.1 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.7.10 (core)
@oclif/plugin-update 1.3.10 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.0.7 (core)
analytics 1.12.0 (core)
generator 1.1.3 (core)
salesforcedx 49.4.1 (core)
├─ salesforcedx-templates 48.32.0 (core)
├─ custom-metadata 1.0.7 (core)
├─ salesforce-alm 49.4.0 (core)
└─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
sfdx-cli 7.68.6 (core)
OS and version:
Edition: Windows 10 Home
Version: 1903
OS Build: 18362.959

Sounds like a duplicate of #108 at first glance.
On Wed, Aug 5, 2020 at 5:39 PM Joe Flowers<EMAIL_ADDRESS>wrote:

Summary
A bit of context first - I am a DEX602 instructor (Salesforce's LWC Class)
and also helped build the course. This issue is impacting students on
Windows machines. I have spent several hours troubleshooting this so that I
could provide a very simple reproducible issue.
In the beginning of the course, we ask students to do the following:

Create a scratch org using a repo provided by class.

Create a custom lwc and place it on a new custom flexipage.

Pull metadata back down to repo.

The metadata pull fails for Windows users - and ONLY Windows users. It
only fails the first time, and it only fails that first time if they use
the command palette command SFDX: Pull Source from Default Scratch Org
rather than typing sfdx force:source:push in a terminal.
I am unable to reproduce the issue on a Mac, and I am also unable to
reproduce the issue if I directly use the sfdx force:source:pull command
from a Windows terminal rather than the command palette. Also, if I use SFDX:
Pull Source from Default Scratch Org and Override Conflicts the first
time, everything comes through fine.
I have significantly simplified the issue by providing an extremely basic
project and a short set of steps to follow to reproduce. To be extra clear,
I've created the following YouTube video because you almost have to see it
to believe it: https://www.youtube.com/watch?v=aCZ_Zxakbh0
We can work around it by having Windows students run the pull twice from
command palette, or use the force override palette command, or run the pull
directly from a Terminal, but if we have to do that it would be nice to
provide some sort of explanation for this quirk.
Steps To Reproduce:
Repository to reproduce: cli-conflict
https://github.com/jflowers45/cli-conflict

Use a Windows machine

Clone repo https://github.com/jflowers45/cli-conflict

Make sure a default dev hub is set

Run CreateOrg.bat

Create a flexipage in the scratch org, activate it and add it to
the Commerce App and Mobile Navigation Menu

Run the command - MUST use the command palette - SFDX: Pull Source
from Default Scratch Org

Run the command a second time using the command palette - SFDX:
Pull Source from Default Scratch Org

Expected result
First metadata pull succeeds.
Actual result
First metadata pull gives a conflict on the training user profile. Second
metadata pull succeeds.
Additional information
YouTube video: https://www.youtube.com/watch?v=aCZ_Zxakbh0
SFDX CLI Version(to find the version of the CLI engine run sfdx
--version):
sfdx-cli/7.68.6-d37008df83 win32-x64 node-v12.18.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx
plugins --core)
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.0.1 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.7.10 (core)
@oclif/plugin-update 1.3.10 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.0.7 (core)
analytics 1.12.0 (core)
generator 1.1.3 (core)
salesforcedx 49.4.1 (core)
├─ salesforcedx-templates 48.32.0 (core)
├─ custom-metadata 1.0.7 (core)
├─ salesforce-alm 49.4.0 (core)
└─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
sfdx-cli 7.68.6 (core)
OS and version:
Edition: Windows 10 Home
Version: 1903
OS Build: 18362.959
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/forcedotcom/cli/issues/546, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQSRPAEH35MQT6KY77NQKDR7HUSPANCNFSM4PWANA7Q
.

@aheber thanks for the insight, looks like you are correct. I had actually previously glanced at that case but since it was quite old and related to pushing (and not pulling) I didn't think they were related. Looks like it's the same thing though.
To confirm our issue was related, I examined the sourcePathInfos.json before and after. When using the command palette command to pull source, the first time through it changes the drive letter (just a local drive - C ) from uppercase to lowercase and the conflict occurs. Then when I run the command palette command a second time it works fine.
If I manually change the drive letter to lowercase in sourcePathInfos.json before running the command palette command, I do not have the problem.
If I use the terminal and just run sfdx force:source:pull, it doesn't change the drive letter casing at all, but it also does not give me a conflict.
Thanks for pointing me in the right direction. For the time being we will have to modify our courseware to tell students to run the command twice the first time if they're on Windows and they see a conflict.


RAG is only used on the first chat message

Bug Report
Description
Bug Summary:
Open-Web UI only uses the "RAG" (Retrieval Augmented Generation) technique on the first message of the conversation. From the second message onwards, the response does not seem to be based on the previous conversation context.
Steps to Reproduce:
Start a new chat, upload a file and ask a question. Docker and Ollama log the normal RAG behaviour (with the proper RAG prompt). From the second message RAG is not used.
Expected Behavior:
RAG should be used on all questions, isn't it?
Environment

Open WebUI Version: 0.3.7

Ollama (if applicable): 0.1.48

Operating System: debian+docker

Browser (if applicable): Chrome 126.0.6478.127

Reproduction Details
Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[X] I have included the Docker container logs.

Logs and Screenshots
Docker Container Logs:
The docker logs show when the document is uploaded and embedded. For the first question RAG is shown in the Docker Logs as:
Use the following context as your learned knowledge, inside <context></context> XML tags.
<context>
REDACTED (but it is ok)
</context>

When answer to user:
- If you don't know, just say that you don't know.
- If you don't know when you are not sure, ask for clarification.
Avoid mentioning that you obtained the information from the context.
And answer according to the language of the user's question.

Given the context information, answer the query.
Query: My question

Ollama logs the query as well. But, on the second message, only ollama logs a basic message, no RAG is used at all.
Installation Method
The project was installed using Docker

I have also tried with different models (mistral, llama3, gemma2), just in case. Same behaviour.

This is not a bug, but rather a change in how RAG handles uploaded documents. To retain previous functionality, you'll need to enable uploaded documents or collections of documents as 'Knowledge' for a model file in the 'Models' section. This allows the model file to have knowledge of the documents from the first message onwards, without requiring manual queries. Note that the default behavior has changed since the introduction of the 'Knowledge' feature, and now only uses the context of a document attached to your query for a single message.

Thanks for answering and closing the bug report.
I don't get it, though. The way you put it means (please correct me if I am wrong):

Only administrators can upload documents to the Knowledge model section.
Regular users have no access to the Workspace so this is somewhat limited to some specific users.
Whenever a users wants to chat with a document or webpage (same thing happens with # elements) they have to keep reuploading the elements (even if these are not reembedded, this I understand). This is unbearingly hard.
If, for whatever reason, they forget to reupload the document or webpage, the answer is completely hallucinated.

This breaks a major feature of Open WebUI, in my opinion.
To add to this, the setup we are testing at our university gives access to 50 users, none with admin rights. Admins should add the company's information, this I get, but for casual documents, users should have more control and access to the RAG feature.

I understand your concerns and appreciate you breaking down the limitations of the current implementation of RAG within Open WebUI.
You are correct that:

Only administrators can upload documents to the Knowledge model section. This isn't inherently a new issue, as both the Documents and Models sections has always been limited to only administrative configuration.
Regular users don't have access to the Workspace, which means they can't manage documents or the recent addition of model file knowledge, which may seem even more restrictive.

In addition to these existing limitations, the recent change to RAG's handling of uploaded documents has introduced new challenges. You're right that:

Users need to reupload documents or link a URL for each chat session, which can be inconvenient.
Forgetting to reupload the document or link a URL can lead to hallucinated answers, which can be frustrating for users and undermine the trust they have in the RAG system.

Speaking for many, I acknowledge that this change may have taken a hit to a major feature of Open WebUI in the perspective of some users, and we should revisit the design to make it more user-friendly and accessible.
With this all having been said, I will mention that the Open WebUI team is aware of the need for a more flexible solution that allows users to manage their own documents without relying on administrators. This is an area we're actively working on to improve in the future, and we're excited to introduce teams in an upcoming feature. Related - https://github.com/open-webui/open-webui/issues/2924

It's great to hear that you understand the concerns regarding the recent changes to RAG in Open WebUI.
You've accurately outlined the issues, including the limitations for regular users, the inconvenience of reuploading documents per session, and the potential for inaccurate responses due to missing document links.
It's reassuring to know that the Open WebUI team is aware of these challenges and is actively working on a solution. The introduction of "teams" in an upcoming feature seems promising and could address many of the current limitations.
I appreciate your constructive feedback and your willingness to engage in this discussion.
I will keep an eye on future updates.

It's very difficult to have a chat over a document, as the LLM doesn't create it's own query.
Thus you need to write every keyword in every message.
Exemple:
User: Can you retrieve the frame data for whatever here:
AI: Here is the data
User: Can you also display the images as markdown ?

It's very difficult to have a chat over a document, as the LLM doesn't create it's own query. Thus you need to write every keyword in every message.

Related: https://github.com/open-webui/open-webui/discussions/3516#discussioncomment-10016923

Finally found this issue to solve my doubts haha.I'm waiting for the latest version to be updated.In fact, I still hope that ordinary users can have their own workspace, while the administrator can have a supervision, so that the company's internal BU department to deploy more quickly and easily!
Really Appreciated


fix: Updated POST request structure to retrieve token

Proposed solution to the issue #214
This PR introduces the following modifications in _retrieve_token method :

Updates data to pass creds to json
Deletes specific headers

Closes #214

You are right, it has to be integrated to unittests !
As this is a bug for which we don't have a theoretical explanation, I made an update of the dummy creds in the light of what the current fix allows (hence including special characters in the frame of the creds at the origin of the bug)

Can you confirm that those unittests fail without your modification? (if that's the case, we can move forward)

ping @fe51 :pray:

@frgfm tested updated, we can merge !

Okay, I have been able to run tests locally and solve issues !
As a reminder, the problems encountered were :

login must fit regular expression imposed in base.py

 login: str = Field(..., min_length=3, max_length=50, regex="^[a-zA-Z0-9_-]+$", example="JohnDoe")

Did not managed to pass a double $$ in password var to docker-compose env variable salthough doc was suggesting it would work with singles quotes ' ' (here and there)


Issue with binary data and new version of nginx

We noticed an issue in the newest version of nginx (it worked on older versions) where the body would get corrupted if binary data was in the response. This appears to be because js_body_filter is being called with the default which returns a string.
Here is the fix:
Modify the call of js_body_filter to be:
js_body_filter logging.response_filter buffer_type=buffer;
And modify the parsing of the body into an array to be:
response_body_arr.push(data.toString());
Hopefully this helps someone in the future!

I agree that your solution is a way to go but it makes the logs unreadable . By adding proxy_set_header Accept-Encoding "";
you can also fix the bug as I think that as nginx examines the response body it messes the encoding as it probably decodes the body but does not indicate that in the response headers, so by just removing the request header for encoding you fix the issue.

Hello Nikoolayy1,
For our use case, we don't care if it is shows unreadable binary data. But it is a good point.
I think the logs would be unreadable regardless if binary data is being sent back to the client. Perhaps a better solution is to detect if its binary data being sent back and instead of showing it, say something like "Binary Data"
Maybe something like:
if(data.toString() !== data) {   response_body_arr[0]("Binary Data Received "); } else {   response_body_arr.push(data.toString()); }
Thanks!
Justin

I ended up using you solution as well as I needed only the response headers not the body, that I also don't need. Only for the response body my workaround proxy_set_header Accept-Encoding ""; could be used.

@jweberst @Nikoolayy1 thanks for info, I will check it with latest version of nginx.


master branch update

bringing master up to date with current dev branch

dev added new features and better endpoint tracking instead of spitting out vague messages.


[flutter_tools] make flutter.gradle compatible with 7 rc1

Fixes https://github.com/flutter/flutter/issues/79155
The next major version requires input/output annotations on all task properties. I think this is the correct set - we're at least equivalent to current behavior if everything is annotated as Internal.

LGTM


Swift 3 support

This PR fixes problems with the new Swift version 3.0, as mentioned in #18
The reason for:
let newUnsafeArgv = UnsafeMutableRawPointer( CommandLine.unsafeArgv ).bindMemory( to: UnsafeMutablePointer<Int8>.self, capacity: Int( CommandLine.argc ) )
is because the CommandLine.unsafeArgv signature no longer is a straight match to the signature of UIApplicationMain() as outlined here: https://forums.developer.apple.com/thread/46405

Also, this proposed change would mean that you'd want to create a new "release" with this version supporting the current Swift version, and the "old" version (as it is now) supporting legacy versions of Swift.


Putting custom messages in locales files

I think in mvc model (when we have edge views) validation messages is more related to views (front end ) than backend (controller) + some times we need separate validation message for each language .
So I think ability to set custom messages in locales files will be good  (Laravel has this feature too. we can set messages on lang(locales) files & also controller)
Thank you.

I am not chasing Laravel features or building a Laravel clone.
Happy to hear more thoughts when they have technical advantages over ( Laravel does this )

@thetutlage : But laravel was only an example ..., I wrote two technical reason for that.
If it is not possible to add this to adonisjs (maybe because of time or other reasons ) Could you please tell me the way that I can do this?(I we really need this in our team)
Thanks.


Much less accurate than paper results when testing

Hi,
I ran the net with pretrained_model_KITTI2015 on the same image than the home page of the git to compare my output with expected one.
Initial left pic:

Network output:

Colorization using kitti scene flow devkit disp_to_color.m:

Your output on the home page:

Could you let me know what I am doing wrong?
Modules:
Ubuntu 16.04
Python 2.7.12
torch   0.4.0
torchvision   0.2.0
Thank you

Same question
2018-06-20 3:48 GMT-05:00 kalanityL<EMAIL_ADDRESS>
Hi,
I ran the net with pretrained_model_KITTI2015 on the same image than the
home page of the git to compare my output with expected one.
Initial left pic:
[image: 000004_10]
https://user-images.githubusercontent.com/28892491/41647665-9e37c6b2-747f-11e8-985c-57f22f67f7eb.png
Network output:
[image: 000004_10]
https://user-images.githubusercontent.com/28892491/41647678-a5e67e62-747f-11e8-8ed8-1e3fc0735b15.png
Colorization using kitti scene flow devkit disp_to_color.m:
[image: 000004_10]
https://user-images.githubusercontent.com/28892491/41647690-ac2de206-747f-11e8-9c02-7403d1072c53.png
Your output on the home page:
[image: ref_depth]
https://user-images.githubusercontent.com/28892491/41647727-be8e6f4c-747f-11e8-8cd5-8101abe9717d.png
Could you let me know what I am doing wrong?
Modules:
Ubuntu 16.04
Python 2.7.12
torch 0.4.0
torchvision 0.2.0
Thank you
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JiaRenChang/PSMNet/issues/63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AifZ-fWXT3y6DSM0-e4KPSZI2PIT1NRoks5t-gxdgaJpZM4Uu2xy
.

In my case, the disparity could be  46.65 %

Could you guys help me ?

got 37.56 ...
it is better rendering than when I apply the disp_to_color.m function... but still not the expected result.

got 0.27% on train2015 img 000000_10.png

Could you share the evaluation code with me?
2018-06-20 9:00 GMT-05:00 kalanityL<EMAIL_ADDRESS>
got 0.27% on train2015 img 000000_10.png
[image: screenshot from 2018-06-20 16-59-20]
https://user-images.githubusercontent.com/28892491/41663123-5dc29626-74ab-11e8-8576-5682abc56cde.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JiaRenChang/PSMNet/issues/63#issuecomment-398759857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AifZ-VEutvWdpbOZYRTFV3Dk4JhSNfATks5t-lVlgaJpZM4Uu2xy
.

I answer on your issue. Can you remove your comments from this post. Cause posting your issue on several different issues is not very helpfull

ok. already remove that

Did you find out the reason yet?

No. If I do I would update here.
Anyone having same outputs and same range of colors?

Colorization is changing depending on the max_disp argument given to the matlab disp_to_color.m
max_disp = 50:

max_disp = 75:

max_disp = 100:

max_disp = 150:

max_disp = 192:

Thanks. Maybe they used 81 (half of actual mac disp).


vcpkg.exe crashes while building opencv 4.5.5 / quirc 1.1#2 package

Describe the bug
Current latest (and other few days old commit) vcpkg.exe crashes while building opencv / quirc package. About year old checkout of https://github.com/microsoft/vcpkg/commit/e809a42f87565e803b2178a0c11263f462d1800a works though.
-- Running vcpkg install
Detecting compiler hash for triplet x64-windows...
The following packages will be built and installed:
  * bzip2[core]:x64-windows -> 1.0.8#2 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\bzip2\a1ea352502e69888a565563d9151d3f7ab609fb1
  * expat[core]:x64-windows -> 2.4.1 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\expat\d63d8c6684bc73856e3f684601761939e32feeb3
  * libffi[core]:x64-windows -> 3.4.2#4 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\libffi\05f73f7c0bbd49045d312d90683a01405f5ffd83
  * libpng[core]:x64-windows -> 1.6.37#16 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\libpng\b082585ac20aefc27150af5386b6a8a15473e93a
    opencv4[core,default-features,dnn,jpeg,png,quirc,tiff,webp]:x64-windows -> 4.5.5 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\opencv4\afed148d21295bf99e8ac657fdb808ed82467871
  * openssl[core]:x64-windows -> 1.1.1m#2 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\openssl\29c9d32a703896143a51c55f0b7ae4298684afd6
  * protobuf[core]:x64-windows -> 3.18.0#1 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\protobuf\5f6aa04d94e184b89c1887946fb4684bc51c4611
    pybind11[core]:x64-windows -> 2.9.1 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\pybind11\24ea84c002f9cc529a54996dbbf2e9b2cce9cadf
  * python3[core]:x64-windows -> 3.10.1#8 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\python3\ce4fddbb41412be06577c61632e8e9ef0a67901c
  * quirc[core]:x64-windows -> 1.1#2 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\quirc\15bad29ef4d2466b236311ce7af075dbb9507ed9
  * sqlite3[core]:x64-windows -> 3.37.2#1 -- C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\sqlite3\f49ad405225c6326558adb79f2082814002a8cda
Additional packages (*) will be modified to complete this operation.
Restored 0 package(s) from C:\Users\<user>\AppData\Local\vcpkg\archives in 458.4 us. Use --debug to see more details.
Installing 1/11 quirc:x64-windows...
Building quirc[core]:x64-windows...
-- Installing port from location: C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\quirc\15bad29ef4d2466b236311ce7af075dbb9507ed9
-- Note: quirc only supports static library linkage. Building static library.
-- Using cached dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz.
-- Cleaning sources at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/<user>/Documents/src/_ext/vcpkg/downloads/dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz
-- Using source at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: C:/Users/<user>/Documents/src/_ext/vcpkg/packages/quirc_x64-windows/share/quirc/copyright/LICENSE
-- Performing post-build validation
warning: `copyright` being a directory is deprecated.
warning: The software license must be available at ${CURRENT_PACKAGES_DIR}/share/quirc/copyright
Elapsed time to handle quirc:x64-windows: 1.865 s
vcpkg has crashed. Please create an issue at https://github.com/microsoft/vcpkg containing a brief summary of what you were trying to do and the following information.

Version=2023-02-16-12e657924d99511514c0287ca5ce46882d3657c7
EXCEPTION=argument not found
CMD=
C:/Users/<user>/Documents/src/_ext/vcpkg/vcpkg.exe|
install|
--triplet|
x64-windows|
--vcpkg-root|
C:/Users/<user>/Documents/src/_ext/vcpkg|
--x-wait-for-lock|
--x-manifest-root=C:/Users/<user>/Documents/src/<project>|
--x-install-root=C:/Users/<user>/Documents/src/<project>/build/vcpkg_installed|
|
-- Running vcpkg install - failed
CMake Error at C:/Users/<user>/Documents/src/_ext/vcpkg/scripts/buildsystems/vcpkg.cmake:886 (message):
  vcpkg install failed.  See logs for more information:
  C:\Users\<user>\Documents\src\<project>\build\vcpkg-manifest-install.log
Call Stack (most recent call first):
  C:/Program Files/MVS2022_Pro/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.25/Modules/CMakeDetermineSystem.cmake:124 (include)
  CMakeLists.txt:5 (project)

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

(while I was writing this bug report a new commit has been pushed that bumped vcpkg version to Version=2023-03-01-538539c4e364dd6f14f5e36f6704144254845159, but still the result is the same for the same package:
Installing 12/22 quirc:x64-windows...
Building quirc[core]:x64-windows...
-- Installing port from location: C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\quirc\15bad29ef4d2466b236311ce7af075dbb9507ed9
-- Note: quirc only supports static library linkage. Building static library.
-- Using cached dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz.
-- Cleaning sources at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/<user>/Documents/src/_ext/vcpkg/downloads/dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz
-- Using source at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: C:/Users/<user>/Documents/src/_ext/vcpkg/packages/quirc_x64-windows/share/quirc/copyright/LICENSE
-- Performing post-build validation
warning: `copyright` being a directory is deprecated.
warning: The software license must be available at ${CURRENT_PACKAGES_DIR}/share/quirc/copyright
Elapsed time to handle quirc:x64-windows: 1.927 s
vcpkg has crashed. Please create an issue at https://github.com/microsoft/vcpkg containing a brief summary of what you were trying to do and the following information.

Version=2023-03-01-538539c4e364dd6f14f5e36f6704144254845159
EXCEPTION=argument not found
CMD=
C:/Users/<user>/Documents/src/_ext/vcpkg/vcpkg.exe|
install|
--triplet|
x64-windows|
--vcpkg-root|
C:/Users/<user>/Documents/src/_ext/vcpkg|
--x-wait-for-lock|
--x-manifest-root=C:/Users/<user>/Documents/src/<project>|
--x-install-root=C:/Users/<user>/Documents/src/<project>/build/vcpkg_installed|
|
-- Running vcpkg install - failed
CMake Error at C:/Users/<user>/Documents/src/_ext/vcpkg/scripts/buildsystems/vcpkg.cmake:886 (message):
  vcpkg install failed.  See logs for more information:
  C:\Users\<user>\Documents\src\<project>\build\vcpkg-manifest-install.log
Call Stack (most recent call first):
  C:/Program Files/MVS2022_Pro/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.25/Modules/CMakeDetermineSystem.cmake:124 (include)
  CMakeLists.txt:5 (project)

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

Environment

OS: Windows 10 21H2 build 19044.2604
Compiler: Latest MSVC 2022 v17.5.1

To Reproduce
Steps to reproduce the behavior:

checkout the latest master (current latest is https://github.com/microsoft/vcpkg/commit/8daf70c56ba9581f5251a5d4675eb771b6b34957 but the error happens with a several days ago commit also)
run bootstrap-vcpkg.bat
vcpkg.json of the project is:

{
  "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
  "name": "project",
  "version": "0.0.1",
  "builtin-baseline": "5962cf5a3bfc2124e8de991a4e45a8edcb3b4c69",
  "dependencies": [
    {"name": "benchmark", "version>=": "1.6.0"},
    {"name":"gtest",      "version>=": "1.11.0#3", "platform": "windows"},
    {"name":"ms-gsl",     "version>=": "4.0.0", "platform": "windows"},
    {"name":"opencv4",    "version>=": "4.5.5", "platform": "windows"},
    {"name":"pybind11",   "version>=": "2.9.1", "platform": "windows"},
    {"name":"glfw3",      "version>=": "3.3.6", "platform": "windows"}
  ]
}

try to build dummy CMake project with vcpkg.json above. Perhaps vcpkg install opencv4 of version "4.5.5" from the baseline should also do
See error

Expected behavior
Checkout old https://github.com/microsoft/vcpkg/commit/e809a42f87565e803b2178a0c11263f462d1800a and do the steps above - everything works fine.
Failure logs
see above, there's nothing in the log file that isn't above.

I can't repro this issue locally. Could you please try the solution in https://github.com/microsoft/vcpkg/issues/22163#issuecomment-1000476222?

@Adela0814 thank you, I will try. We have a bunch of people in the company, who also run into this issue, but I can't share the project that spawns it... I'll try your suggested solution and get back to you with the results. If that won't help, I'll try to make a minimal ~working~ failing example and will post it. Thanks for taking care!

I looked at the proposed solution and... erm, I'm not using GCC at all for this. It's MSVC@Windows10. I might be slightly wrong (config might be a bit different, I need to check it), but afair that project that fails with MSVC@Windows10 compiles nicely on Ubuntu 20.04 with native gcc. Also out of several projects that use vcpkg ports from official repo, only this one fails; all the others works perfectly fine.
I read all other messages in the thread and, honestly, I just don't see how it's applicable to my case...
I'll try to come up with a minimal failing example.

It looks like that latest master already contains some resolution of the issue. Now it also works for me:
Installing 11/21 quirc:x64-windows...
Building quirc[core]:x64-windows...
-- Installing port from location: C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\quirc\15bad29ef4d2466b236311ce7af075dbb9507ed9
-- Note: quirc only supports static library linkage. Building static library.
-- Using cached dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz.
-- Cleaning sources at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/<user>/Documents/src/_ext/vcpkg/downloads/dlbeer-quirc-7e7ab596e4d0988faf1c12ae89c354b114181c40.tar.gz
-- Using source at C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: C:/Users/<user>/Documents/src/_ext/vcpkg/packages/quirc_x64-windows/share/quirc/copyright/LICENSE
-- Performing post-build validation
warning: `copyright` being a directory is deprecated.
warning: The software license must be available at ${CURRENT_PACKAGES_DIR}/share/quirc/copyright

    configure_file("${CURRENT_BUILDTREES_DIR}/C:/Users/<user>/Documents/src/_ext/vcpkg/buildtrees/quirc//LICENSE" "${CURRENT_PACKAGES_DIR}/share/quirc/copyright" COPYONLY)
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\Users\<user>\Documents\src\_ext\vcpkg\buildtrees\versioning_\versions\quirc\15bad29ef4d2466b236311ce7af075dbb9507ed9\portfile.cmake
Stored binaries in 1 destinations.
Elapsed time to handle quirc:x64-windows: 2.1 s
Installing 12/21 libpng:x64-windows...

It spawns some warnings and 1 post-build check problem, but nonetheless it works which is great news to me! :)
Closing the issue as resolved.


"assert" Volume models

Hi,
For the differents models of volume,
assert(abs(Medium.density_derp_h(medium.state)) > 1e-12, "The simple Volume model should not be used with incompressible or nearly incompressible media. Consider using the FlexVolume instead.");
should be replaced, to be coherent, by :
assert(abs(density_derp_h_from_media) > 1e-12,The simple Volume model should not be used with incompressible or nearly incompressible media. Consider using the FlexVolume instead."), dropOfCommons.assertionLevel);
Best regards,
François

abs(density_derp_h_from_media) > 1e-12

density_derp_h_from_media is a Boolean parameter that can be set by the user, maybe you have mistaken that?
Did you intend to ask for putting the dropOfCommons.assertionLevel at the end of the assert?


Wrap image-only embeds in a link.

Examples:
https://goo.gl/photos/PaVEUvB18Kx6HFHAA
http://xkcd.com/1223/

LGTM @nleush

@BenLubar as I understand you case is about generated widget card with image. I've made some changes to render both <img> tag and <a> wrapper in card template: 80de9aba9bf0bcde1a616d52ed408bc638078dd6.
I think it should be better to render in template.
In other cases Iframely doesn't return <img> embed code to prevent hotlinking by default.
Is it ok for you?

http://iframely.com/debug?uri=https%3A%2F%2Fgoo.gl%2Fphotos%2FPaVEUvB18Kx6HFHAA
The embed HTML generated by iframely is just:
<img src="https://lh3.googleusercontent.com/1GzSADYzry6eMotuohoryDidSH2a3RnD58wvy49JFV5qEOcrtjL0432csBtjMJEVW7HQtGF66y79E68BNR1sME1XnMOGX6pW1XusbcENpYH4ZPI3dsr2ILj_-fE6mJQ1eGTgz3ImZdY=w600-h315-p-k">

Which means a link to a photo album gets reduced to a single non-interactive photo. That's not an enhancement of the post contents.

@BenLubar I see, hotlinking disabled only on iframely.com, but works on open-sourced version. I've made some changes to template again https://github.com/NodeBB/nodebb-plugin-iframely/commit/239f52d2c9033c06c1032e5212f5c5f0f1d67ffc. Should be ok now?

:shipit:


[Bug]: getModelMeta fails with Strapi 4.5.5

What issue are you experiencing?
Withe the new UI for better relation handling, the following error appears in console:
 Cannot read properties of undefined (reading 'split')     at getModelMeta
this is caused because now they are attaching the action to the model, for instance:
{ model: 'report.reports.findExisting' }
Steps To Reproduce
No response
What version of the plugin are you using?
1.1.4
What strapi version are you using?
4.5.5

This should be fixed by #43


Expandstring network, alphabeticize expandstring list

Allows use of %network% in ExpandString for CIRCNetwork.
Additionally, the alphabeticizing was just a nice touch. I found it difficult to navigate the existing list.
Fixes #1115

Please notify after you make the commit, github notifies only about comments

Yes, I was going to notify you on irc but hadn't found the time yet, next
time I'll leave a comment.
On 15 Oct 2015 9:31 am, "Alexey Sokolov"<EMAIL_ADDRESS>wrote:

Please notify after you make the commit, github notifies only about
comments
—
Reply to this email directly or view it on GitHub.


While you were gone...

Things that we already implemented where I work. Leaving it here in a multi purpose PR in case @purbon is interested at some time in the future. It's all in my main-sverrehu branch.

Update all dependencies to latest versions, including container versions in the code, and including rewriting now deprecated code.
Add a --recursive flag that allows finding topology files in subdirectories.
Remove the DEBUG logs that cluttered both test and run outputs.
Allow logging of INFO and above for AdminClient, instead of silencing it completely.
Replace the abandoned Java code formatter with the one from Spotify, which is up to date with Java 17.
Move ZooKeeper classes to src/test and mark the zookeeper dependency as test-scoped, since it was only used in tests, and dragged unwanted dependencies into the shaded jar. (These dependencies caused the spam of all kinds of DEBUG messages in the output.)

Thanks @sverrehu for your lovely work, while I'm kinda retired, @piotrsmolinski is helping out and he is preparing another PR, so love to get yours in. I hope that is ok for you.

Thanks @sverrehu for your lovely work, while I'm kinda retired, @piotrsmolinski is helping out and he is preparing another PR, so love to get yours in. I hope that is ok for you.

Of course, Pere!

Thanks again @sverrehu, merging this PR right now. @piotrsmolinski appreciate as well a ton your thoughts and help


BS5 - Disabled buttons prevent setting cursor like 'not-allowed'

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Finally getting around to changing one of my bigger sites over to BS5.  BS5 sets the following for disabled buttons :
.btn:disabled, .btn.disabled, fieldset:disabled .btn {
  color: #fff;
  pointer-events: none;
  background-color: var(--bs-btn-disabled-bg);
  border-color: var(--bs-btn-disabled-border-color);
  opacity: var(--bs-btn-disabled-opacity);

While pointer-events: none; prevents visual actions on the button like hover it also prevents setting a different cursor such as :
cursor: not-allowed;

which I was personally doing for added visual context to users that this button is disabled when they mouse over it.
I get the reasoning behind the change, but at the same time I am thinking of user experience.  A visitor comes to your website, that they are not familiar with, and a disabled button shows a lighter opacity (which they might not even realize) and has no function (no click, no color change on hover, etc).  Is everyone going to realize this button is disabled this way?  This is why I always set custom css to show pointer-events: none; on my disabled buttons.  Now, the visitor sees a red 'x' cursor when they mouse over the button and it is very clear to them that this button is disabled.
Not saying BS4 or BS5 way is better or worse and I'm sure people will have differing opinions on this, but for me personally it was nice setting the 'not-allowed' cursor on my disabled buttons so it was clear to my visitors what was happening.
Motivation and context
See above.

surely if you're manually setting cursor: not-allowed in your styles, you can then also set pointer-events: auto in your custom styles?

@patrickhlauke Which would also remove the new button functionality that prevents any visual button changes on hover/focus/etc for disabled buttons.

@patrickhlauke Which would also bring back the disabled button changing visually on hover/focus/etc.  This is one of the side effects of using pointer-events with them in BS5 compared to BS4.

Yes, it's a bit of a trade-off, but one we felt was worth it. We won't be changing that at this point in v5 because it'd be a major and breaking change, so you might need to modify things further for your specific use case. We'll keep it in mind for v6 as well.

I'm sorry, but what is gained from disabling all pointer events on a disabled button? As far as I can see, no click events fire on a disabled button, so you've chosen to prevent accessibility things like tooltips for no gain?
Disabled buttons should not have pointer events disabled.
I'm fairly sure the same could be said for many other things like inputs as this adds a lot of bloat, disables accessibility across the board, and doesn't actually provide any benefit when using inputs and buttons. Perhaps a lot of :not(input,button,select) to make sure you don't disable pointer events where there's no need?

you've chosen to prevent accessibility things like tooltips for no gain?

how would you trigger a tooltip on a disabled button using the keyboard? disabled buttons can't be focused with the keyboard... the only way then would be to "fake disable" the button to keep it effectively active, cram in aria-disabled="true", and rely on the author preventing regular click action...


How To Get Crop Rect

i want to get the crop rect with orginal image base ;how can i do it?

@MohammadrezaZamanieh  please see Example


fixes for rhel7 at SPI

Build changes to compile on rhel7 for SPI

LGTM. I was just musing about whether any of the accumulated cruft can be trimmed.
Merge when you're ready, there's no way this can break anybody else.


item taking two columns

Hi,
I just want to ask if it is possible with macy to have some items with a width of two columns like in isotope https://codepen.io/desandro/pen/mEinp ?
Best

@ceehaupt
I am probably too late to answer, but, I just came here after implementing it on my website and had the same question. But, what a bummer. According to this issue https://github.com/bigbite/macy.js/issues/35, it's not possible and might never get implemented.
So, I gotta look for another library now, which is kinda disappointing as Macy had otherwise worked perfectly for me.

Update, I just thought of a very simple solution and it works great for me. I added a child container to the one that's getting sized by Macy and set its width to 200%. Done.

@Hrishikesh-K is that being calculated? Mine is overflowing into the next item.

@riadcitaku Yeah, it'll overflow into the next item. This library isn't designed to handle some item consuming 2 columns, so, the overflow is gonna happen and the next items aren't going to automatically adjust. It had worked in my case because the one I needed in 2 columns was supposed to be the last item in the row.


refactor: rename interface methods

Description
Discussed with @jpadilla and @cikasfm that the current methods name are misleading because they only apply to the ReadChanges API.

Closing because the methods are actually also used in the Read API.


Fix default pattern selection in CoIdentifierAssignements (CO-2391)

Q: should "description" or "format" be required fields?


Potential data race in processPacket in zmean_reset and sub_zmean

Hi all,
Our bug scanner has reported a data race issue from zmean.c#L54 to zmean.c#L85
Followings are code snippets.
void
zmean_reset()
{
  zlen = 0;
  zmean = 0.0;
}

and
void
sub_zmean(SP16 *speech, int samplenum)
{
  ...
  if (zlen < ZMEANSAMPLES) {
    /* update zmean */
    sum = zmean * zlen;
    ...
    zmean = sum / (float)zlen;
  }
  for (i=0;i<samplenum;i++) {
    d = (float)speech[i] - zmean;
    ...
  }
}

 zmean is a static variable and functions zmean_reset and sub_zmean could be executed parallelly. Therefore, when two threads reach the race point simultaneously, the result of operations with zmean in sub_zmean may be affected.
A possible call trace could be as follows:
main_recognition_stream_loop calls j_open_stream in a loop, which means the callee can be called more than once.
In j_open_stream, it calls adin_thread_create, which create a thread executing adin_thread_input_main. Then it calls adin_cut and in adin_cut, it calls sub_zmean.
At the second loop in main_recognition_stream_loop, it also calls j_open_stream and in j_open_stream, it calls adin_begin. Finally, it calls zmean_reset.
The type of race is also applicable to variable zlen in the same two functions zmean_reset and sub_zmean.
SourceBrella Inc.,
Yu

Thanks for the report.  The race may not occur actually since the device opened within j_open_stream() will be closed at the end of  j_recognize_stream().  Also the second open will occur only at file input and adin input, where threaded audio recording are disabled by default on those input devices.


“WebSocket connection failed. Error: ETIMEDOUT” after running web mode in browser for 3~5 min

Hi,
I got “WebSocket connection failed. Error: ETIMEDOUT” after running web mode in browser for 3~5 min.
It seems like connection is closed after some min.
Can you help me to fix this?
Thanks

Which browser are you using? Only Google Chrome is supported.
Web server process is remote or localhost? If remote, please check your network status.
Do you have any anti-virus software running except for Windows default one? If so, please exclude node processes from the realtime scan.
If the problem is not resolved by above, please provide debug logs around the disconnection time.

The problem is because of log file size. I made it working by unlimiting file size. Thank you


use gl-matrix and mat4

One of commits that prepares us for upcoming v4.1

projectionMatrix and transformMatrix in all shaders have type mat4
other uniforms can use mat3
its possible to use mat3 as uniform value in filters

I didnt test it on all filters yet, only on pixi examples
Bunnymark shows the same FPS for me.
So far I expose ONLY glMat.mat4, we dont need other stuff yet

Matrix.copy was working like copyTo, while other objects copy worked like copyFrom
I added deprecation warning there


Fixing V20 translation.json file after testing

I noticed some errors in both V20.html after live testing, im proceeding to fix them. It's going to be necessary to recreate the translation files (en.json, de.json, etc) except for it.json which i'm fixing myself in another pull thread.

Was this ever fixed? Facing the same problem in 2020.


[bug] ignores is_mobile False from device #62

Closes #62

Travis tests have failed
Hey @Purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
4th Build
View build log

     ./run-qa-checks

SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./django_loci/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./django_loci/tests/testdeviceapp/migrations" with migrations-to-ignore: 0 successful!
Skipped 2 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
44 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!
Your commit message does not follow our commit message style guidelines:

- please add a capital letter after the prefix

Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
Checked commit message:

[bug] ignores  False from device #62

Closes #62

ERROR: Commit message check failed!
No changes detected in app 'django_loci'
SUCCESS: Migrations check successful!
travis_time:end:0ae46600:start=1603515891819986003,finish=1603515895978757713,duration=4158771710,event=script

6th Build
View build log

     ./run-qa-checks

fatal: bad object af756c8a30eeb0e14594ddcd883aee451cb5bdc0
SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./django_loci/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./django_loci/tests/testdeviceapp/migrations" with migrations-to-ignore: 0 successful!
Skipped 2 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
44 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!

No changes detected in app 'django_loci'
SUCCESS: Migrations check successful!

TravisBuddy Request Identifier: 68a16c20-15b7-11eb-94fa-edf6748ec8ed

Travis tests have failed
Hey @Purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
2nd Build
View build log

     ./run-qa-checks

SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./django_loci/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./django_loci/tests/testdeviceapp/migrations" with migrations-to-ignore: 0 successful!
Skipped 2 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
44 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!
Your commit message does not follow our commit message style guidelines:

- please add a capital letter after the prefix

Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
Checked commit message:

[bug] ignores is_mobile False from device #62

Closes #62

ERROR: Commit message check failed!
No changes detected in app 'django_loci'
SUCCESS: Migrations check successful!
travis_time:end:28a5fe52:start=1603516390774471778,finish=1603516395263728431,duration=4489256653,event=script

6th Build
View build log

     ./run-qa-checks

fatal: bad object 6dadf4a151b61531065042cb65e622d846b0a386
SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./django_loci/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./django_loci/tests/testdeviceapp/migrations" with migrations-to-ignore: 0 successful!
Skipped 2 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
44 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!

No changes detected in app 'django_loci'
SUCCESS: Migrations check successful!

TravisBuddy Request Identifier: 8978c050-15b8-11eb-94fa-edf6748ec8ed

Coverage remained the same at 99.795% when pulling 5381341d64b2d6eeba490a45c350b33c4012008d on Purhan:issues/62-fix-is-mobile-field into fc8bd87915222f8bb9788fcc082718927abb9361 on openwisp:master.


blob is not defined

Hi,
When I use the getThreadHistory method, I get the error ReferenceError: blob is not defined.
It seems that this error is only triggered when I'm getting a message containing a gif.
The error is in getThreadHistory at line 65 when accessing the blob variable, which seems to never be defined.
Thank you for your help.

Thanks for opening this, looks like there was a bug in our new getThreadHistory function, where "blob" isn't defined..
https://github.com/Schmavery/facebook-chat-api/blob/0bd932de5489b4513902b601326429cc485d3b9e/src/getThreadHistory.js#L65-L76

This bug was introduced by<PHONE_NUMBER>3c9d0ac863d2c556145c402e5324c5. The attachment in this case is the blob_attachment itself
https://github.com/Schmavery/facebook-chat-api/blob/0bd932de5489b4513902b601326429cc485d3b9e/src/getThreadHistory.js#L405
The object is structured like this
"blob_attachments": [{
    "__typename": "MessageAnimatedImage",
    "attribution_app": null,
    "attribution_metadata": null,
    "filename": "gif-1234567890",
    "animated_image": {
      "uri": "https:\/\/cdn.fbsbx.com\/v\/t59.2708-21\/1234567890_1234567890_1234567890_n.gif?_nc_cat=0&oh=1234567890abcdef&oe=1234ABCD",
      "height": 358,
      "width": 272
    },
    "legacy_attachment_id": "1234567890",
    "preview_image": {
      "uri": "https:\/\/cdn.fbsbx.com\/v\/t59.2708-21\/1234567890_1234567890_1234567890_n.gif?_nc_cat=0&oh=1234567890abcdef&oe=1234ABCD",
      "height": 358,
      "width": 272
    },
    "original_dimensions": {
      "x": 272,
      "y": 358
    }
  }
]

So basically, a copy/paste slip up from utils.js, and the fix is as simple as replacing blob with attachment.

So, are getThreadHistory and getThreadHistoryGraphQL one now?
I see that there is no getThreadHistoryGraphQL function.

@bilyanhadzhi getThreadHistoryGraphQL was always a bit of an experimental api and has now been promoted to replace the mostly broken original getThreadHistory call (which is still available as getThreadHistoryDeprecated but we are planning to remove it -- please let us know if there's a reason we shouldn't)

You should consider publishing this fix to npm, it's pretty critical.

will do

@shade 1.5.1 published


Applications not sticking to fancyzones

So with .14 release zones do appear to be staying on the correct monitor and filling full screen (thanks for that).  The issue I am running into is that the applications are not sticking to the zones and keep going back to my center monitor when the screens power down.  I then have to re snap the applications back into the zones.
Environment
Windows 10 Pro 64 bit
version 10.0.18362.476
Powertoy version .14
Module: Fancyzones
3 - 32" 4k Monitors   -- Left: HDMI (main)  -- Center:Display Port -- Right: Display Port
Steps to reproduce
Set up zones on multiple monitors
Snap application to zones
Let monitors go to sleep after a couple of minutes of non-use
Click mouse (or keyboard) to bring up monitors
All applications congregate on center monitor
Expected behavior
All applications should be where they were before monitors went to sleep
Actual behavior
All applications congregate on center monitor and need to be dragged and reattached to zones
Screenshots

@enricogior did 0.14.1 hotfix correct this?

I think this is caused by the monitor been recognized by Windows as "disconnected".
There is nothing in FZ that moves windows back to the primary monitor if a secondary monitor goes to sleep.

This is not really a bug in FancyZones, it's a problem with the monitor driver.

How did this act before FancyZones on your system?

@RentecErich  How did this act before FancyZones on your system?

@RentecErich we need more information.  Once you respond, we'll reopen.

Just started to use FZ and experiencing the same thing as the OP logged here.
When laptop wakes up from sleep, all apps on the main monitor and I'll have to reconfigure windows again.
Any ideas on how to resolve this?
Thanks

Hi @bugoy8
if you quit PowerToys, when you wake up the laptop, do the windows stay on the external monitor?

Hi @enricogior
Was thinking about this. I couldn't remember but will test later.
My laptop just came from back from sleep and all the windows retained their spots! Hope it sticks.
The windows were on the external monitor, which I've set as the primary.

Thanks

This is really bizarre. Sometimes the windows stick and sometimes they don't. I am trying to get a pattern so I can do the wake order where I can preserve the windows were the apps are.
The sleep length of time does not seem to matter. Different results, different times.

Different connections (HDMI vs DisplayPort) also play a role, since they can cause Windows to treat a sleeping monitor as a disconnected monitor. What connection do you use?

Hi,
Laptop -> Dell D6000 dock via USBC
Dell D6000 -> monitor 2 via Display port (see above diagram)
Dell D6000 -> monitor 3 via HDMI
Thanks

Different behaviors again this morning.
After overnight sleep, windows stuck to their places! Yes!
After a short use, locked the screen. Came back, logged in and some screens are all over the place!

@bugoy8
if the windows move from one monitor to another, that is Windows detecting a monitor disconnection.
If the windows are moved from on place to another on the same monitor, that very likely is a FancyZones bug. Do you use Virtual Desktops?


pickle may have issues with nested classes

PyWren uses pickle to serialize and deserialize the code. If the code contains nested classes, then pickle may fail to properly deserialize the nested class and will lookup in the package level. This might produce an error  [ERROR] jobrunner: There was an exception: module 'main' has no attribute 'XYZ'
Not sure what can be done. This issue is to document the current behavior.

In concrete, PyWren uses Cloudpickle  to serialize. I saw a (more than likely) related issue: https://github.com/cloudpipe/cloudpickle/issues/53 Maybe we should open an issue directly in the Cloudpickle github.

I finally been able to reproduce the error after moving the code of your notebook to a python file. I think it is not a pickle issue, but how a library is imported, concretely numpy module.
So to avoid the issue, change:
from numpy import exp, random
to
import numpy as np
And then in the code use np.exp and np.random


mouse menu item is automatically selected on RMB release

VSCode Version:
Version: 1.35.1
Commit: c7d83e57cd18f18026a8162d042843bda1bcf21f
Date: 2019-06-12T14:27:31.086Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-52-generic

OS Version:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

Steps to Reproduce:

Open VScode and do work during some time.
press right mouse button and immediately release it.

Does this issue occur when all extensions are disabled?: Yes

Can you explain some more about what you are seeing? I don't understand

Hi,
Just compare behavior in vscode and in other application:
Google chrome:

Press RMB.
menu is shown
release mouse button
menu is visible, I can select required item manually.

vscode:

press RMB
menu is shown
release mouse button
menu item which is placed under  cursor will be automatically selected and menu disappeared!

In example above menu item "Cut" will be selected immediately I release RMB.
If I restart vscode, all is ok. But is reproduced after hours when I work with vscode.
In attachment example how context menu in chrome is working:

Sorry, the gif in your original post didn't load yesterday.

@dibalavs are you using window.titleBarStyle: custom or native

titlebarstyle is custom.
My settings:
global:

"workbench.activityBar.visible": false,
"window.titleBarStyle": "custom",
"gitlens.codeLens.recentChange.command": "gitlens.toggleFileBlame",
"gitlens.currentLine.enabled": false,
"gitlens.hovers.currentLine.enabled": false,
"gitlens.advanced.telemetry.enabled": false,
"search.maintainFileSearchCache": true,
"search.quickOpen.includeSymbols": true,
"search.runInExtensionHost": true,
"search.smartCase": true

workspace:

"folders": [
{
"path": "dist"
},
{
"path": "packages"
},
{
"path": "config"
},
{
"path": "kb"
}
],
"settings": {
"files.associations": {
.................
},
"cSpell.words": [
.............
],
"C_Cpp.default.includePath": [
............................
],
"C_Cpp.default.systemIncludePath": [
.......................................
],
"git.ignoreLimitWarning": true,
"editor.fontSize": 13,
"editor.renderWhitespace": "boundary",
"workbench.statusBar.feedback.visible": false,
"workbench.tips.enabled": false,
"workbench.editor.highlightModifiedTabs": true,
"workbench.editor.revealIfOpen": true,
"window.zoomLevel": 1,
"search.exclude": {
"**/.git": true
},
"search.maintainFileSearchCache": true,
"search.quickOpen.includeSymbols": false,
"search.smartCase": true,
"telemetry.enableTelemetry": false,
"telemetry.enableCrashReporter": false,
"gitlens.hovers.annotations.changes": false,
"gitlens.hovers.annotations.details": false,
"gitlens.hovers.annotations.enabled": false,
"gitlens.hovers.currentLine.changes": false,
"gitlens.hovers.currentLine.details": false,
"gitlens.hovers.currentLine.enabled": false,
"gitlens.hovers.enabled": false,
"gitlens.currentLine.enabled": false,
"gitlens.codeLens.recentChange.enabled": false,
"gitlens.codeLens.authors.enabled": false,
"search.useReplacePreview": false,
"workbench.editor.enablePreview": false,
"search.runInExtensionHost": true
}

this has been addressed elsewhere


Implement LdProofs.verify_proof

There is currently a TODO in the ldproofs/mod.rs code for verify_proof. Do we need to implement this, @tmarkovski ?

No, we should remove this entirely.