Cannot Store Edit Session

Testing #156211

go to https://insiders.vscode.dev/github/alexdima/yaserver
type in a file
run Edit Sessions: Store Current Edit Session
a progress message appears but never completes:

There is an error in the console:
ERR [Extension Host] Error: 'importScripts' has been blocked
    at self.importScripts (../../../vs/workbench/api/worker/extensionHostWorker.js:78:2120)
    at Object.et.f.i (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:35030)
    at eval (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:33748)
    at Array.reduce (<anonymous>)
    at Function.et.e (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:33726)
    at eval (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1131:50373)
    at Generator.next (<anonymous>)
    at eval (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:35895)
    at new Promise (<anonymous>)
    at d (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:35715)
    at dy (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1131:50319)
    at eval (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1131:51158)
    at Generator.next (<anonymous>)
    at eval (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:35895)
    at new Promise (<anonymous>)
    at d (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1124:35715)
    at fy (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1131:51120)
    at hy.a [as _clientFactory] (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1133:8663)
    at hy.instantiateAppender (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1133:905)
    at gy.updateUserOptStatus (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1133:2673)
    at new py (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1133:2128)
    at new gy (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1133:8758)
    at JR (https://github.vscode-unpkg.net/GitHub/vscode-pull-request-github/0.47.2022072609/extension/dist/browser/extension.js#vscode-extension:1306:4624)
    at f._activate (../../../vs/workbench/api/worker/extensionHostWorker.js:69:8181)
    at f._waitForDepsThenActivate (../../../vs/workbench/api/worker/extensionHostWorker.js:69:8123)
    at f._initialize (../../../vs/workbench/api/worker/extensionHostWorker.js:69:7487)

Maybe related: https://github.com/microsoft/vscode/issues/155225

Sorry for that--could you enable trace logging and share the edit session output channel logs?

Are you prompted to sign in to use edit sessions? When invoking the store action?

Am I performing the flow correctly?

Open insiders.vscode.dev with a remote repo (i.e. https://insiders.vscode.dev/github/bamurtaugh/theCatSaidNo)
Make a change but don't commit
Run command Edit Sessions: Focus on All Sessions View
Run command Edit Sessions: Store Current Edit Session

If so, then I think I'm encountering the same issue, as I don't see anything in the edit session view:

I was initially prompted to log in to use edit sessions, and I signed in with my GH account.
I didn't get a progress notification initially, but after enabling trace logging, I quickly saw a progress notification.
Here's my log:
[2022-07-26 10:07:21.352] [editsessions] [info] Storing edit session...
[2022-07-26 10:07:21.483] [editsessions] [info] Stored edit session with ref 25615259-ae04-4c24-8823-21851d4a0b1f.
[2022-07-26 10:09:13.889] [editsessions] [info] Storing edit session...
[2022-07-26 10:09:13.909] [editsessions] [trace] Sending request to server {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions","type":"POST","headers":{"X-Execution-Id":"b57ae9c6-0f03-4ceb-b5b0-b7d167edcfe0","Content-Type":"text/plain","X-Client-Name":"code-insiders-web","X-Client-Version":"1.70.0-insider","X-Client-Commit":"cc098faebd320a2eea3da6ae154b7e2e1347a4b9","X-Account-Type":"github","X-Machine-Session-Id":"0e3534f3-31a7-4009-9a5a-cebfecb76ce1"}}
[2022-07-26 10:09:13.997] [editsessions] [trace] Request succeeded {"url":"https://vscode-sync.trafficmanager.net/v1/resource/editSessions","status":200,"execution-id":"b57ae9c6-0f03-4ceb-b5b0-b7d167edcfe0"}
[2022-07-26 10:09:14.021] [editsessions] [info] Stored edit session with ref 47c33ca4-d559-4ca2-b70f-0166c70ab655.

Ah no that's a different issue which I've fixed in main https://github.com/microsoft/vscode/issues/156235 (basically the view container shouldn't show up in the sidebar until you explicitly set focus to it).
For today's insiders, you'll want to do this sequence of steps instead

Open insiders.vscode.dev with a remote repo (i.e. https://insiders.vscode.dev/github/bamurtaugh/theCatSaidNo)
Make a change but don't commit
First store your edit session
Then run the Focus on All Sessions View command:

This worked for me today! I think yesterday I wasn't logged in when I first executed Edit Sessions: Store Current Edit Session.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

There have been several improvements to the store flow--we ask for auth if it's missing when you first store your changes, and the store operation is now cancellable in the event that it is long running due to e.g. server latency. The view itself also has a welcome state which asks for auth if it's missing, thus closing.


misc/wasm, cmd/link: Go 1.17.2 causes WASM builds to throw command line too long with many environment variables

What version of Go are you using (go version)?

$ go version
go version go1.17.2 darwin/amd64

Does this issue reproduce with the latest release?
Yes. It's caused by the latest release.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/evan/Library/Caches/go-build"
GOENV="/Users/evan/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/evan/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/evan/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/evan/dev/esbuild/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/j6/np400cw17sz0n5ljd67byrzw0000gn/T/go-build2118346093=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Here's a simple way to reproduce the issue:
$ echo 'package main;import"fmt";func main(){fmt.Println(0)}' > main.go
$ GOOS=js GOARCH=wasm go build -o main.wasm main.go
$ X=longlonglonglong && X="$X$X$X$X" && X="$X$X$X$X" && X="$X$X$X$X" && X="$X$X$X$X" node $(go env GOROOT)/misc/wasm/wasm_exec.js main.wasm

What did you expect to see?
This should print 0.
What did you see instead?
This fails with the following error:
Error: command line too long
    at global.Go.run (/usr/local/go/misc/wasm/wasm_exec.js:574:11)
    at /usr/local/go/misc/wasm/wasm_exec.js:630:14

There are at least two problems:

With Go 1.17.2, it's now impossible to use Go WASM programs in situations with many environment variables. This comes up when trying to run something via GitHub Actions, for example.

The error message command line too long is confusing because there are no command-line arguments. Instead the problem is that there are too many environment variables.

See also

https://github.com/golang/go/issues/48797
https://go-review.googlesource.com/c/go/+/354571/

I just discovered that this also impacts running tests for the same reason:
$ echo 'package main;import"testing";func TestFoo(*testing.T){}' > main_test.go
$ X=longlonglonglong && X="$X$X$X$X" && X="$X$X$X$X" && X="$X$X$X$X" && X="$X$X$X$X" PATH="$(go env GOROOT)/misc/wasm:$PATH" GOOS=js GOARCH=wasm go test main_test.go
Error: command line too long
    at global.Go.run (/usr/local/go/misc/wasm/wasm_exec.js:574:11)
    at /usr/local/go/misc/wasm/wasm_exec.js:630:14

cc @rolandshoemaker @mknyszek

CC @cherrymui.

Both command line arguments and environment variables are currently passed to WebAssembly by writing them to linear memory, and CL 354571 added a fixed limit of 4096 bytes for both.
The error message can certainly be improved to also mention environment variables.
I'm wondering if you can speak about how much more than 4096 bytes you're running into in your use case? Is it just a little over, or is it significantly over? Or is it unpredictable?

I'm the author of esbuild and I use GitHub Actions to run my Go WASM tests. Here's the full list of environment variables I'm seeing in my tests:

Click to expand the list of environment variables

_=/usr/bin/make
ACCEPT_EULA=Y
AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache
ANDROID_HOME=/usr/local/lib/android/sdk
ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk-bundle
ANDROID_NDK_LATEST_HOME=/usr/local/lib/android/sdk/ndk/23.0.7599858
ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk-bundle
ANDROID_SDK_ROOT=/usr/local/lib/android/sdk
ANT_HOME=/usr/share/ant
AZURE_EXTENSION_DIR=/opt/az/azcliextensions
BOOTSTRAP_HASKELL_NONINTERACTIVE=1
CHROME_BIN=/usr/bin/google-chrome
CHROMEWEBDRIVER=/usr/local/share/chrome_driver
CI=true
CONDA=/usr/share/miniconda
DEBIAN_FRONTEND=noninteractive
DEPLOYMENT_BASEPATH=/opt/runner
DOTNET_MULTILEVEL_LOOKUP=0
DOTNET_NOLOGO=1
DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
GECKOWEBDRIVER=/usr/local/share/gecko_driver
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTION=__run_19
GITHUB_ACTIONS=true
GITHUB_ACTOR=evanw
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_05e5de09-0c30-4b02-97e2-b15aa3c3b3ca
GITHUB_EVENT_NAME=push
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=
GITHUB_JOB=esbuild
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_05e5de09-0c30-4b02-97e2-b15aa3c3b3ca
GITHUB_REF=refs/heads/temp-go-wasm
GITHUB_REPOSITORY_OWNER=evanw
GITHUB_REPOSITORY=evanw/esbuild
GITHUB_RETENTION_DAYS=90
GITHUB_RUN_ATTEMPT=1
GITHUB_RUN_ID=1347838728
GITHUB_RUN_NUMBER=2312
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=8447ef9b4da93f3897dcb2f280d4181d5cd1f008
GITHUB_WORKFLOW=CI
GITHUB_WORKSPACE=/home/runner/work/esbuild/esbuild
GOROOT_1_14_X64=/opt/hostedtoolcache/go/1.14.15/x64
GOROOT_1_15_X64=/opt/hostedtoolcache/go/1.15.15/x64
GOROOT_1_16_X64=/opt/hostedtoolcache/go/1.16.9/x64
GOROOT_1_17_X64=/opt/hostedtoolcache/go/1.17.2/x64
GOROOT=/opt/hostedtoolcache/go/1.17.2/x64
GRAALVM_11_ROOT=/usr/local/graalvm/graalvm-ce-java11-21.2.0
GRADLE_HOME=/usr/share/gradle-7.2
HOME=/home/runner
HOMEBREW_CELLAR=/home/linuxbrew/.linuxbrew/Cellar
HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS=3650
HOMEBREW_NO_AUTO_UPDATE=1
HOMEBREW_PREFIX=/home/linuxbrew/.linuxbrew
HOMEBREW_REPOSITORY=/home/linuxbrew/.linuxbrew/Homebrew
HOMEBREW_SHELLENV_PREFIX=/home/linuxbrew/.linuxbrew
ImageOS=ubuntu20
ImageVersion=20211011.1
INVOCATION_ID=e89f572507984074a8ef4d7b4677e023
JAVA_HOME_11_X64=/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64
JAVA_HOME_8_X64=/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64
JAVA_HOME=/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64
JOURNAL_STREAM=8:22524
LANG=C.UTF-8
LEIN_HOME=/usr/local/lib/lein
LEIN_JAR=/usr/local/lib/lein/self-installs/leiningen-2.9.7-standalone.jar
MAKEFLAGS=
MAKELEVEL=1
MFLAGS=
NVM_DIR=/home/runner/.nvm
PATH=/home/runner/.deno/bin:/opt/hostedtoolcache/deno/1.15.1/x64:/opt/hostedtoolcache/node/14.18.0/x64/bin:/home/runner/go/bin:/opt/hostedtoolcache/go/1.17.2/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG
PIPX_BIN_DIR=/opt/pipx_bin
PIPX_HOME=/opt/pipx
POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-ubuntu20
PWD=/home/runner/work/esbuild/esbuild
RUNNER_NAME=GitHub Actions 2
RUNNER_OS=Linux
RUNNER_PERFLOG=/home/runner/perflog
RUNNER_TEMP=/home/runner/work/_temp
RUNNER_TOOL_CACHE=/opt/hostedtoolcache
RUNNER_TRACKING_ID=github_c55eb5e4-2f62-4ef4-87cb-caa86ebdb0aa
RUNNER_USER=runner
RUNNER_WORKSPACE=/home/runner/work/esbuild
SELENIUM_JAR_PATH=/usr/share/java/selenium-server-standalone.jar
SGX_AESM_ADDR=1
SHLVL=1
STATS_KEEPALIVE=false
SWIFT_PATH=/usr/share/swift/usr/bin
USER=runner
VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg
XDG_CONFIG_HOME=/home/runner/.config

The text I pasted above comes in at 3919 bytes for 96 environment variables, so you'd need to add an extra 98*8=768 for the pointers for a total of 3919+768=4687 bytes just for environment variable data alone. So it's a little over 4096 bytes.
The maximum value of the offset variable in wasm_exec.js that I observe when running my tests is 9512, which is 5416 bytes of data. This is larger than 4687 bytes because I do have a few command-line arguments in my tests. And I'll probably need to go a little higher in the future if a future test needs another command-line argument, so it would be nice to have a little more wiggle room than exactly 5416 bytes.

I see no reason against increasing the limit from 4096 to 8192 bytes.
Later, after https://golang.org/cl/350737 landed, we can switch to the WASI interface for getting the arguments and environment which would remove the limit entirely.


Matching partial body params

The current implementation of matching the body as a hash seems flawed in that it only matches when the pattern contains the entirety of the body hash.  For example:
#connection class
post(SERVICE_URI, :body => {:username => "testname", :password => "testpassword"})

#spec
WebMock.should have_requested(:post, SERVICE_URI).with(:body => {"password" => "testpassword"})

The spec in this case fails in the current implementation, as it doesn't completely specify the hash that was passed into the post.  I can't think of any situations where my proposed method of specifying partial matches should reasonably fail—and if that is the desired functionality, it would seem that one should specify that instead of letting a magic default in a mocking library allow your test to pass.  Using this patch the above specification would indeed pass.

No, indeed, @jcf's solution doesn't work. request.body in the block is a string, not a hash, so while it responds to [], it does so with completely wrong results. I support changing with as requested.

Hmmm. We can't reuse RSpec's matcher -- test that the type of body is a HashIncluding (or whatever the class is), and if so, run the parsed params through RSpec? (I'll try to play with the code if I have time...I'm very busy this week, though.)

Possibly. Webmock would use hash_including from rspec if available and if not it would provide own hash_including.

That sounds reasonable.


Method not found: 'System.String ImageResizer.Configuration.PipelineConfig.get_StopRoutingKey()'.

Hey,
I am just trying to use the new Karbon cms on visual studio 2015 which has asp.net 4.6 mvc 5. I keep getting error like this->
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.MissingMethodException: Method not found: 'System.String ImageResizer.Configuration.PipelineConfig.get_StopRoutingKey()'.
Source Error:
An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.
Stack Trace:
[MissingMethodException: Method not found: 'System.String ImageResizer.Configuration.PipelineConfig.get_StopRoutingKey()'.]
ImageResizer.Plugins.MvcRoutingShim.MvcRoutingShimPlugin.Install(Config c) +0
ImageResizer.Configuration.PluginConfig.add_plugin_by_name(String name, NameValueCollection args) +175
ImageResizer.Configuration.PluginConfig.loadPluginsInternal() +215
ImageResizer.Configuration.PluginConfig.LoadPlugins() +73
ImageResizer.Configuration.Config..ctor(ResizerSection config) +324
ImageResizer.Configuration.Config.get_Current() +89
ImageResizer.InterceptModule.CheckRequest_PostAuthorizeRequest(Object sender, EventArgs e) +127
System.Web.SyncEventExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +141
System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +69

+1

Use ImageResizer 3.4.3 ıt will be fixed.
I found on here: https://stackoverflow.com/questions/26728251/field-not-found-imageresizer-configuration-pluginconfig-loggingavailable#comment51995824_30278386


Fix support for local emulator

Describe the bug
Flow team feedback:

Flowser uses its own emulator and dev-wallet. Switching to a local emulator requires some extra steps, and I only got it to work partially. They have an open issue to document this process.

Duplicate of #72.


Encrypt the secret file in containerd/containerd.

For https://github.com/containerd/containerd/issues/3627
I happened to encrypt the file is another repository.
This time it should be correct:

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #3641 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3641   +/-   ##
=======================================
  Coverage   42.39%   42.39%
=======================================
  Files         127      127
  Lines       14048    14048
=======================================
  Hits         5955     5955
  Misses       7193     7193
  Partials      900      900

Flag
Coverage Δ

#linux
45.9% <ø> (ø)
:arrow_up:

#windows
37.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ad1bd...4e8a499. Read the comment docs.


in WHMCS Uncaught SyntaxError: Unexpected token )

Calling tinysort('ul#ulName>li', {data:'sortby'});
which is work perfectly in https://jsfiddle.net/.
but adding this to the WHMCS (script base) header.tpl

cause an error.
this is what php.index in WHMCS would see the code:

+============+
, it seems it has a problem with {}, in tinysory (NodeList, {data:'foo'});
Thanks.

Doesn't look like a Javascript issue to me; it seems that somehow apache/php serves an altered file where the object is stripped.


[BUG]: Remove Chatbox

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The chatbox has 3 replies
It is entirely unusable and should be removed.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign-me


Add Angular Ruhr Meetup

Add Angular Ruhr Meetup

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thanks for your contribution Dominik!

@all-contributors please add @DominikPieper for code


Set minimum highwatermark

To let this library function. It need to have minimum amount that should be reading, otherwise there will be many error.
It should be longer than expected (name length + 4) * 2 size. 512 bytes.

no need for new version


Export option for Idle Backup

⚠ Problem
TODO: please provide an export option for the list of idle backups. right now i have to manually copy all the entries and export it.

🛠 Solution
TODO: provide the download option we have for other services.

ℹ Additional context
TODO: Add any other context or screenshots about the change request, including alternative solutions you considered and why you ruled them out.
🙋♀ Ask for the community

We could use your help:

Please vote this issue up (👍) to prioritize it.
Leave comments to help us solidify the vision.

Thanks @arthurclares Quick couple of  questions.

Right now in the workbook only 250 entries are displayed. Once the download option is available can we see all entries?
Calculating the cost for idle backup seems to be nearly impossible as you can see only the RS vault specific charges. Is it possible to get the idle backup cost in the workbook? If yes it would really provide a lot of value to a lot of customers.


Updates to docs for gclient builds on more platforms

Update to build with GClient on F22 and CentOS 7 including potential flag changes to get around having -Werror set. Switch git checkouts in docs to https:// for more compatibility.

I'm going to reorganize the docs so that README.md has the GClient build first followed by any platform specific notes on flags followed by the old build process for Ubuntu. Then point at it from the other platform files, which we can clean up in future, and list other build methods as deprecated.

Is this better now it's been moved around?


Cue fmt destroys working code

What version of CUE are you using (cue version)?

$ cue version
cue version v0.6.0

go version go1.20.6
      -buildmode exe
       -compiler gc
       -trimpath true
     CGO_ENABLED 0
          GOARCH arm64
            GOOS darwin

Does this issue reproduce with the latest stable release?
Yes
What did you do?

Apply cue fmt on code like this
foo: [
	bar["baz"], //some comment
]

What did you expect to see?
Code should not change, or some whitespace changes
What did you see instead?
Code that doesn't compile
foo: [
	bar["baz" //some comment],
]

Here is another test case, found by @rudifa in https://github.com/cue-lang/cue/issues/2646:
exec cue fmt in.cue

# Show what the CUE looks like after formatting.
exec cat in.cue

# Show that the resulting CUE is broken.
exec cue eval in.cue

-- in.cue --
[
	if true // inline comment
	{}]

$ testscript -v repro-fmt.txtar
[...]
> exec cue fmt in.cue
# Show what the CUE looks like after formatting. (0.001s)
> exec cat in.cue
[stdout]
[
	if true {} // inline comment]
# Show that the resulting CUE is broken. (0.013s)
> exec cue eval in.cue
[stderr]
expected ']', found 'EOF':
    ./in.cue:2:32
[exit status 1]
FAIL: /tmp/testscript450645547/repro-fmt.txtar/script.txtar:7: unexpected command failure
error running repro-fmt.txtar in /tmp/testscript450645547/repro-fmt.txtar

Actually, the "working code" above is not valid cue.
To what extent should cue fmt format invalid cue, if at all?
# show original in.cue before cue fmt
exec cat in.cue
exec cue fmt in.cue

# show modified (badly) in.cue
exec cat in.cue

# the original in.cue fails eval
exec cue eval in2.cue

-- in.cue --
foo: [
	bar["baz"], //some comment
]
-- in2.cue --
foo: [
	bar["baz"], //some comment
]

Here is the minimal comprehension example, with its DebugStr(f)
cue % cat testdata/2567-2.cue                                       [issues-fmt-comments L|…1]
[
	if true // inline comment
	{}]

cue % cat testdata/2567-2.cue | go run . fmt -                      [issues-fmt-comments L|…1]
[
	if true {} // inline comment]

DebugStr: [<[l2// inline comment] if true {}>]

Re above use of DebugStr, see my comments in #1447.

I've sent https://review.gerrithub.io/c/cue-lang/cue/+/1173870 as a first fix, to ensure that newlines are always printed in the formatter.
This fixes Rudi's latest reproducer, but the original reproducer with an index expression still fails. I think that might be a parser bug, so I've filed https://github.com/cue-lang/cue/issues/2738.

The proposed change 1173870 fixes the missing newline at the end of a comment, and issue #2738 proposes to allow a comma inside the index expressions.
However, we need to solve yet another problem, that of comments misplaced with respect to elements they describe. Take this reproducer:
# script 2567-misplaced-comments.txtar
# state with cue v0.7.0
# the .got.cue files show the bad results of cue fmt

exec cue fmt 2567.cue
cmp 2567.cue 2567.got.cue
! exec cue vet 2567.cue         # result fails the cue vet

exec cue fmt 25<IP_ADDRESS>.cue
cmp 25<IP_ADDRESS>.cue 25<IP_ADDRESS>.got.cue
exec cue vet 25<IP_ADDRESS>.cue     # result passes the cue vet, but 2 comments are misplaced

-- 2567.cue --
foo: [
    bar[baz], // about the element `bar[baz]`
]
baz: 41
-- 2567.got.cue --
foo: [
	bar[baz // about the element `bar[baz]`],
]
baz: 41
-- 25<IP_ADDRESS>.cue --
[
    // about this clause
    if true // about this condition
        {} // about this value
]
-- 25<IP_ADDRESS>.got.cue --
[
	// about this clause
	if true {} // about this condition, // about this value
]
-- end --

Clearly, the misplaced comments don't express what the author of the cue fragments intended.
In fact, I believe that in these examples the formater should reproduce the input cue without any alterations.
When above reproducer is run with cue built with change 1173870 the updated results still do not correspond to what the author intended:
testdata % git diff                                                                                [more-tests L|✚1]
diff --git a/testdata/2567-misplaced-comments.txtar b/testdata/2567-misplaced-comments.txtar
index a6be0d1..a1b4f97 100644
--- a/testdata/2567-misplaced-comments.txtar
+++ b/testdata/2567-misplaced-comments.txtar
@@ -17,7 +17,8 @@ foo: [
 baz: 41
 -- 2567.got.cue --
 foo: [
-       bar[baz // about the element `bar[baz]`],
+       bar[baz // about the element `bar[baz]`
+       ],
 ]
 baz: 41
 -- 25<IP_ADDRESS>.cue --
@@ -29,6 +30,7 @@ baz: 41
 -- 25<IP_ADDRESS>.got.cue --
 [
        // about this clause
-       if true {} // about this condition, // about this value
+       if true {} // about this condition,
+       // about this value
 ]
 -- end --

I believe that these Line comments are misplaced after formatting because the parser did not attach them to the node that they refer to. In fact, the cue-ast-print for the second case shows that all 3 comments, Doc or Line, are attached to the whole clause, and this is exactly what the formatter reproduces (with the known defects).
-- 25<IP_ADDRESS>.ast --
*ast.File{
. Filename: "25<IP_ADDRESS>.cue"
. Decls: []ast.Decl{
. . *ast.EmbedDecl{
. . . Expr: *ast.ListLit{
. . . . Lbrack: token.Pos("25<IP_ADDRESS>.cue:1:1")
. . . .                                       }
. . . . . }
. . . . }
. . . . Rbrack: token.Pos("25<IP_ADDRESS>.cue:5:1")
. . . }
. . }
. }
. Imports: []*ast.ImportSpec{
. }
}

Here is another reproducer:
# script 2567-misplaced-comments.slice.txtar
# state with cue v0.7.0
# the .got.cue file shows the bad results of cue fmt

exec cue fmt 2567.slice.cue
cmp 2567.slice.cue 2567.slice.got.cue
! exec cue vet 2567.slice.cue         # result fails the cue vet

-- 2567.slice.cue --
a: [1,2,3,4,5]
b:[
    a[2:3],  // first slice
    a[:2],   // second slice
    a[2:],   // third slice
]
-- 2567.slice.got.cue --
a: [1, 2, 3, 4, 5]
b: [
	a[2 // first slice
	:3],
	a[:2 // second slice],
	a[2  // third slice
	:],
]
-- end --

@mvdan I believe this can be closed now

@NoamTD just to confirm, did you double check that all the examples above in this thread output valid CUE now?

Ah, I thought I did but there's a single case left:
[
	if true // inline comment
	{}]

this still results in
[
	if true {}, // inline comment]

I'll fix that up and then this can be closed


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_0440837b-564e-4caa-a577-0e0d8a90766f/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_0440837b-564e-4caa-a577-0e0d8a90766f.git

Docs Build status updates of commit d35c72f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd4, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update dependencies

Big refactoring of ForgeState(Info), KESInfo, ..., in consensus.

No more mock protocols.

Bonus: no more dependencies on lens.

One of the reasons CI fails is that there are warnings when compiling iohk-monitoring-lib-iohk-monitoring-<IP_ADDRESS>-x86_64-w64-mingw32, I suppose because of some CPP? @CodiePP Can you look into this? Either -Werror is not enabled on that repo or it doesn't build w64-mingw32, or both. I will leave out the dependency bump of iohk-monitoring until it is fixed.

The other reason CI failed was because of a flaky test, which will be fixed by #1669.

bors merge


Sometimes something prevents us from getting current versions of images

New Issue Checklist

[X] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
iOS

Platform Version
9.x

SDWebImage Version
3.8.1

Integration Method
cocoapods

Xcode Version
Xcode 7.3.1

Repro rate
sometimes. Have not yet found a pattern.

Repro with our demo prj
n/a

Demo project link
n/a

Issue Description and Steps
There are times when we seem to not get an updated image.
The effect, as seen by our users, is that an image at a URL appears to not update after a change. (we are downloading a fairly large image at a specific URL. Sometimes the image at that URL will change.)
We are calling SDWebImage like this:
static func loadImage(url: NSURL, completion: (image: UIImage, url: NSURL) -> Void) {
        let manager = SDWebImageManager.sharedManager()

        manager.downloadImageWithURL(url, options: [.RefreshCached], progress: nil) { (image, error, _, finished, _) in
            if let image = image where finished {
                completion(image: image, url: url)
            } else {
                DDLogError("While downloading: \"\(url.absoluteString)\" got: \(error)")
            }
        }
    }

We are using the following response headers and our servers are fronted by the cloud flare CDN:
Date:               Tue, 19 Jul 2016 18:27:51 GMT
Content-Type:       image/png
Transfer-Encoding:  chunked
Connection:         keep-alive
Set-Cookie:         __cfduid=d304992d6e96a57131af99cc58939ee8c1468952870; expires=Wed, 19-Jul-17 18:27:50 GMT; path=/; domain=.redacted.net; HttpOnly
Cache-Control:      max-age=0,must-revalidate
Etag:               "_lvPlDDoJWww6unMjZZAxQ-1242"
Last-Modified:      Tue, 19 Jul 2016 17:01:07 GMT
Via:                1.1 google
Alt-Svc:            clear
Server:             cloudflare-nginx

Our intent, with the Cache-Control and Etag headers is that the client will conditionally load the images. Usually we see that it works (both in end result behavior and in what we see on the wire with a man-in-middle-proxy). We see conditional requests getting 304s, showing the cached image, and when we change the image the server responds with a 200 with a new Etag and the cycle repeats. Just like it should.
Sometimes, though, we see some very strange behavior:

We only ever get the first callback from SDWebImage, the one containing the "old" version of the UIImage.
On the wire, we see 1 request, with an If-none-match header, that has a non-current Etag. This gets a 200 response with a proper image payload.

This is what we see once the thing is in a broken state. Once in this state, we never seem to get the second callback with the result of the server response. We also see that subsequent attempts to load the image seem to be stuck in this same pattern: only one callback, request contains an Etag, response is 200. While this is happening, we also note that the If-none-match value being sent does not seem to change and is not the value being returned in the 200 responses' Etag header.
Stopping the app does not seem to get us out of this state. Reinstalling it seems to help.
My uninformed guess is that the disk cache is getting corrupt but, of course, that's just me. :)

The images were fairly large. ~1mb
Reducing the size helped, things seem to be behaving better once we made the images smaller. So, I think there is something going on here with the cache(s).

I have the same issue.  After entering this strange state, clear disk or memory not work. I've changed to 4.0 beta but still failed.


Improve documentation for this project

This issue is to track the writing of new documentation for this plugin within protobuf-maven-plugin/src/site that replaces the monolithic usage.md page.

Done as of 2.7.1


GREUH-Script

the greuh option "in vehicle sound volume" isn't working, when using ace3.
it seems the script is overwritten, by ace.

@madpat3 if you want reduce the noise on a vehicle use caps , add them to your equip from the virtual arsenal.

haha just joking bro :)

It's right, that it won't really work with ACE enabled.
In ACE you've in fact the earplugs and no "magic less noisy engine sounds", as ACE is a realism mod.
But well, that's no new information for you, I know ^^
So at the moment there are no plans to build a workaround around ACE for this. Because the reason it is not working is, that ACE is take over the volume controls, not that Liberation detects ACE and disables the control.
Maybe you can delete the ace_hearing.pbo (just a thought)

nah, nevermind.
i'll reduce the ingame sound while sitting in a helicopter and talk.


standardize label values and semantics for session, workload, scenario, ...

The session identifier which is used in labels should always be auto-generated as a simple token with GUID-like semantics.

unless the user overrides it with a command line option

The scenario identifier which is used in labels should always be defaulted to the session identifier.

unless the user is using named scenarios, in which case it should be set to the scenario name from the workload template

The workload identifier should be provided iff and only if named scenarios are being used, and it should be the sanitized name of the workload template file.

The standard label set design is settled in NB521 and docs are provided in tree


Allow esthri-cli crate to be published.

Not entirely sure if the release.toml in the root will handle both crates or if we need to provide a separate release.toml for both? Seems like everything is abstracted though so maybe this is fine.
fixes https://github.com/swift-nav/esthri/issues/277

I think a cargo release --workspace --exclude esthri-test from the root of the project should work (should be equivalent to running it on each package).

I think a cargo release --workspace --exclude esthri-test from the root of the project should work (should be equivalent to running it on each package).

Well there is also a release.toml file in the esthri-test crate would that sufficient or would --workspace ignore it?

I think a cargo release --workspace --exclude esthri-test from the root of the project should work (should be equivalent to running it on each package).

Well there is also a release.toml file with publish=false in the esthri-test crate would that be sufficient or would --workspace ignore it?

Ah nice yeah should be fine without the flag then


No ReLU between final two FC layers -- object datasets

Hello!
Thanks for the great codebase -- I've found it very useful, and a great resource to try and reproduce the results in your  interesting paper!
We're trying to reproduce some of the results, and noticed that you stack two FC/linear layers without a non-linearity in between them. I believe that this is only for the object datasets, and happens between the bottleneck and classifier layers. Is there a reason you have done this? It seems quite unusual since, without a nonlinearity in between, the two layers can be collapsed into a single equivalent layer.
Thanks for your help!
Cian

@cianeastwood Thanks for you interests!
Yeah, you are right, two linear layers can be collapsed into a single layer for classification.
But for DA, since the output of backbone network is quite long (2,048), we introduce the bottleneck layer (256) for better feature alignment in a low-dimensional feature space, just the same as DANN and CDAN (https://github.com/thuml/CDAN/blob/master/pytorch/network.py).
Best

Yeah I understand that you want to do feature alignment in a lower dim space – I just don't get why there is no ReLU in between! But ok, I guess it's common in DA. Thanks for your response!


Someone needs to write about Arrays in chapters/array.md

🙋  I can start this job in the next week.

Very well done, Sangjoon 👍
I see that there are some sections empty still in array.md
What are your thoughts on those sections?

Thanks @vandadnp
I'll add contents as soon as possible. + integer.md sections too. I did forget them.


1.6.2 Broken on Sony Android TVs

Unable to use Google Drive features.  Multiple Issues.

Unable to create new JSON
a) Select Connect to Google Drive upon new install
b) Select your account
c) Select OK to creating a syncable file
d) Use onscreen keyboard to select "Next"
e) Take note that "Cancel" option is selected for some reason
f) Onscreen keyboard is still visible, select Finished.
g) Screen goes away, no JSON created (assuming it selects this Cancel option)

Workaround 1: Press back on remote to remove onscreen keyboard then select right, then Save on Google Drive screen

Unable to Import from Google Drive
a) Select Import from Google Drive
b) Take note that My Drive loads, but unable to select any of the files in the middle
c) Using arrows on remote, you will move between Magnifying Glass and Cancel buttons, or any other icon at the top, but not able to select a folder or file

Workaround 2 (sometimes works): Select magnifying glass, type in "cu" then select search on onscreen keyboard.  Use cancel button on remote. Press down, and you'll note that a file will appear to be select, scroll until you find file, then select.  Then select "Write Cloud Data to Local" then take note of "Couldn't find any channels.  Uh Oh." even if the JSON you select is full of channels.

Working fine using the 1.5 series

Yes Google drive has a bad UI for TV. It's an issue I'm planning on
tackling soon.
On Sep 9, 2016 12:15 AM, "Alan Cramer"<EMAIL_ADDRESS>wrote:

Working fine using the 1.5 series
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Fleker/CumulusTV/issues/177#issuecomment-245815108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI589OzWrUfBLf3RXKeYbh7bpW1Ly1nks5qoN1WgaJpZM4J4rpg
.

Another bug is when using the Sony equivalent of the Live Channels app (Streaming Channels), it displays "The loading screen can't seem to open, but the channel is loading." but this displays whilst showing the default loading screen of Cumulus TV (the one where the channel logo is in the middle of the screen.

That's a message that will pop up in very rare circumstances without a good reason. It'll be something I look over and remove if possible.

I've noticed that cumulus TV is crashing often on both my Sony and my Nexus Player. Assuming these are coming through to your crash log @Fleker

Yes I'm getting them


[Feature] Add Engine Account support

#3584  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite

TODO: add tests


imaging.Open with bytes

Hello guys,
Not able to do an imaging.Open getting bytes from the file instead of the path?
To apply everything in memory?
imaging.Open (file_bytes?

Hi,
Most probably you are looking for imaging.Decode: https://godoc.org/github.com/disintegration/imaging#Decode
It takes an io.Reader instead of a filename as a first argument.

Perfect, just this, now I need to do Resize:
dstImage: = imaging.Resize (srcImage, width, height, imaging.Lanczos)
Instead of imaging.Save (dstImage, "/tmp/t.png") on disk, I need bytes in memory, I do not want to save to disk.
How can I proceed?
Thank you

See: https://godoc.org/github.com/disintegration/imaging#Encode

Excellent Very Good.
Exactly that.
Just had to define my io.Write as a new buffer
buf2: = bytes.NewBuffer (nil)
Thank you guys.
Very good, I do not need to save anything on disk.

@jeffotoni Do you happen to have a fully working example of this in action?
Thanks in advance.

Here's the example of encoding to / decoding from a slice of bytes:
package main

import (
	"bytes"
	"image/color"
	"log"

	"github.com/disintegration/imaging"
)

func main() {
	// Create a new image.
	origImage := imaging.New(100, 100, color.NRGBA{255, 0, 0, 255})
	log.Printf("original image bounds: %v", origImage.Bounds())

	// Encode the image into a byte slice as PNG.
	var buf bytes.Buffer
	err := imaging.Encode(&buf, origImage, imaging.PNG)
	if err != nil {
		log.Fatal(err)
	}
	pngBytes := buf.Bytes()
	log.Printf("encoded PNG image size: %d bytes", len(pngBytes))

	// Decode image back from the byte slice.
	decodedImage, err := imaging.Decode(bytes.NewReader(pngBytes))
	if err != nil {
		log.Fatal(err)
	}
	log.Printf("decoded image bounds: %v", decodedImage.Bounds())
}

2019/03/29 23:29:47 original image bounds: (0,0)-(100,100)
2019/03/29 23:29:47 encoded PNG image size: 292 bytes
2019/03/29 23:29:47 decoded image bounds: (0,0)-(100,100)


fix: allow creating Distance request from expense reports

Details
Allow creating Distance request from expense reports
Fixed Issues
$ https://github.com/Expensify/App/issues/30407
PROPOSAL: https://github.com/Expensify/App/issues/30407#issuecomment-1780632583
Tests
Same as QA.
Offline tests
Same as QA.
QA Steps

Request money from a workspace
Open the expense chat with this workspace
Navigate to the recently updated (created) expense report (the one that contains unsettled money requests)
Click "+" -> Request money

[ ] Verify that it's possible to create a Distance request

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/12595293/e74e4806-af4b-4ed8-a673-32607df52fbf

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/c0455d3d-fc2c-49ff-9f2b-5c0e50fcc5bb

iOS: Native
https://github.com/Expensify/App/assets/12595293/f078ec17-bb6d-4b20-b61c-a0ee188c1a55

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/2d9dfe93-f566-465d-89ac-024544004688

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/7302d77d-6faf-4b8a-a5c1-90094b90a3af

MacOS: Desktop
https://github.com/Expensify/App/assets/12595293/89c8b56a-0a5c-4ee3-8a09-4dc7bd64f8a0

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.98-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Palo mqtt

It looks like the new version of paho breaks the classic script. I resolved by changing line 480:
#mqttClient = mqttclient.Client(clientId)
mqttClient = mqttclient.Client(mqttclient.CallbackAPIVersion.VERSION1, clientId)

Thanks for your work on this issue,
Updated Classic_mqtt.py and Dockerfile


Error when running main.py

Dear Sir,
when I tried to run main.py, I get this issue.
(envPEDRA) E:\Major Project\PycharmProjects\PEDRA>python main.py
pygame 1.9.6
Hello from the pygame community. https://www.pygame.org/contribute.html
------------------------------- configs/config.cfg -------------------------------
[general_params]
run_name:                      Tello_indoor
env_type:                      Indoor
env_name:                      indoor_long
mode:                          infer
SimMode:                       Multirotor
drone:                         DJIMavic
ClockSpeed:                    20
algorithm:                     DeepQLearning
ip_address:                    <IP_ADDRESS>
[camera_params]
width:                         320
height:                        180
fov_degrees:                   80
---------------------------------- Environment ----------------------------------
Successfully loaded environment: indoor_long
E:\Major Project\PycharmProjects\PEDRA\util\transformations.py:1914: UserWarning: failed to import module _transformations
warnings.warn('failed to import module %s' % name)
--------------------------- configs/DeepQLearning.cfg ---------------------------
[simulation_params]
custom_load:                   False
custom_load_path:              models/trained/Indoor/indoor_long/Imagenet/e2e/drone0/drone0
[RL_params]
input_size:                    103
num_actions:                   25
train_type:                    e2e
wait_before_train:             5000
max_iters:                     150000
buffer_len:                    10000
batch_size:                    32
epsilon_saturation:            100000
crash_thresh:                  1.3
Q_clip:                        True
train_interval:                2
update_target_interval:        8000
gamma:                         0.99
dropout_rate:                  0.1
learning_rate:                 2e-06
switch_env_steps:<PHONE_NUMBER>
epsilon_model:                 exponential
------------------------------------- Drone -------------------------------------
Connected!
Client Ver:1 (Min Req: 1), Server Ver:1 (Min Req: 1)
Initializing  DQN
Traceback (most recent call last):
File "main.py", line 99, in
eval(name)
File "", line 1, in
File "E:\Major Project\PycharmProjects\PEDRA\algorithms\DeepQLearning.py", line 64, in DeepQLearning
p_z,f_z, fig_z, ax_z, line_z, fig_nav, ax_nav, nav = initialize_infer(env_cfg=env_cfg, client=client, env_folder=env_folder)
File "E:\Major Project\PycharmProjects\PEDRA\aux_functions.py", line 86, in initialize_infer
f_z = env_cfg.floor_z/100
TypeError: unsupported operand type(s) for /: 'DotMap' and 'int'

Can you share the following file?
unreal_envs/indoor_long/config.cfg

Dear Sir,
I noticed the file was missing at the specified location. Then I downloaded again the environment from the link
https://gtvault-my.sharepoint.com/personal/manwar8_gatech_edu/_layouts/15/onedrive.aspx?originalPath=aHR0cHM6Ly9ndHZhdWx0LW15LnNoYXJlcG9pbnQuY29tLzpmOi9nL3BlcnNvbmFsL21hbndhcjhfZ2F0ZWNoX2VkdS9FbkNjMnhXS0JDcElrV3NlZWdycDFFWUI2OXkwelMzbkxxenNhU2ZFLUtBRDRnP3J0aW1lPXllVXNpS1hqMTBn&id=%2Fpersonal%2Fmanwar8_gatech_edu%2FDocuments%2Fpublic_share%2FGitHub%2FPEDRA%2FPackaged Environments%2FIndoor%2Findoor_long.rar&parent=%2Fpersonal%2Fmanwar8_gatech_edu%2FDocuments%2Fpublic_share%2FGitHub%2FPEDRA%2FPackaged Environments%2FIndoor
I am getting the simulation and the moving drone getting trained in it. But it is getting collided with the wall again and again and I have to start the simulation again. I am working on a project for autonomous landing of a drone on a moving platform, could you please guide me regarding how should I proceed further. I am quite new with Reinforcement Learning and autonomous systems.
I am really thankful to you for taking your kind time to help me.
Warm regards,
Lokesh


coordination system used in one-2-3-45

great work! but may i ask what world coordination is used in your code when generate the pose ?
It seems not a typical right-hand system adopted in OpenGL
https://github.com/One-2-3-45/One-2-3-45/blob/3c82aa614fcb80924fddd14531056eda7e795aaa/utils/utils.py#L80

We used the OpenCV coordinate frame. The function calc_pose computes the Cartesian coordinates (in world frame) of a camera on a sphere from the given spherical coordinates. The The azimuthal angle theta is in the x-y plane from the negative y-axis, the The polar angle phi is measured from the positive z-axis.


resolves #89 honor the value of the stem attribute

process the stem macro as asciimath or latexmath depending on the value of the stem attribute

@ProgramFan Please review and merge this as soon as possible. This bug is encouraging users to apply workarounds in their content, which I'd rather avoid.

Thanks, Dan.


TaskHandle: fix wrong sender is dropped while join handle is still active warnings

    > Do we fix the right thing here? I mean that this TaskHandle logic needs to be improved, but if task drops event_sender and continues running without returning it looks like a problem too

Conceptually TaskHandle provides an abstraction for getting progress updates on a spawned task.
If the task chooses to not send progress updates (= drop the events_sender) it shouldn't be considered an error.
Or should it?
Anyways, even if the sender doesn't "consciously" drop it, the fact that we move it into the task closure means that we always drop it before the task exits & join_handle.await returns. It's an inherent race. It's just so late in the task's life that more often than not, the task exists first before the .recv() returns Err(_sender_dropped).
Originally posted by @problame in https://github.com/neondatabase/neon/issues/2862#issuecomment-1323309414
NOTE: read the linked PR. It contains a test case to repro the warning reliably

It's an inherent race.

Agreed. Ideally we should not give ownership over receiver to the task so TaskHandle can drop receiver after task finishes.

it shouldn't be considered an error.
Or should it?

I can hardly imagine when this the desired behavior. In this case task is alive but you no longer can receive progress updates.
Also worth noting that TaskHandle has only one usage across the codebase, so as usual it is hard to come up with good generic solution when you have only one use case

This most def is not a good first issue.


Add default comparator for commissions

Works yet to completed will be placed first. If multiple commissions are incomplete, those with an earlier deadline comes first.

Codecov Report

Merging #148 (d3e0d48) into master (1b37acc) will decrease coverage by 0.00%.
The diff coverage is 52.38%.

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
- Coverage     56.33%   56.32%   -0.01%
- Complexity      775      779       +4
============================================
  Files           143      143
  Lines          3309     3329      +20
  Branches        358      360       +2
============================================
+ Hits           1864     1875      +11
- Misses         1341     1347       +6
- Partials        104      107       +3

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
35.71% <0.00%> (-0.88%)
:arrow_down:

.../java/seedu/address/model/commission/Deadline.java
66.66% <0.00%> (-8.34%)
:arrow_down:

...ain/java/seedu/address/ui/CommissionListPanel.java
0.00% <ø> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

...ava/seedu/address/model/commission/Commission.java
74.79% <33.33%> (-1.04%)
:arrow_down:

...edu/address/model/commission/CompletionStatus.java
70.00% <42.85%> (-14.62%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
90.08% <85.71%> (-0.27%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update requirements install path

Codecov Report

Merging #41 (7e9ad4d) into main (cf10ba9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   74.50%   74.50%
=======================================
  Files           3        3
  Lines          51       51
  Branches       12       12
=======================================
  Hits           38       38
  Misses         11       11
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf10ba9...7e9ad4d. Read the comment docs.


ENH: Custom sklearn

Add passive and active kmeans agents. The active approach samples a probability distribution that is maximized in proximity to cluster centers.
Currently lacks in the unit test department. I'll use Dan's interpolator in unit tests in a future PR.

Merging for expediency without @DanOlds review (after 5 days).


Passage reranking for custom collection

Hi,
It might be good to complete the custom collection doc with light instructions on passage reranking, after seeing this issue.
pygaggle has been a well-bundled and transparent resource for the CORD-19, and for other text ranking in the future. Below is a bottom-up snapshot from what it provides. It is however free-style and therefore less formalized.

Rerank with monoBERT
Optionally, you could rerank the above retrieval results. We provide a minimum working example rerank_custom_collection.py for this.
The example follows pygaggle and duoBERT (up to monoBERT in the figure below, figure source here), less the part to evaluate with ground-truth.
It calls a reranker to score (query, passage) pairs. The reranker is a pre-trained transformer model on a general passage retrieval task such as MS MARCO.

Prepare Input Files from the QuickStart Step

The initial retrieval result file, named above as [OUTPUT_PATH].
The query file, named above as [QUERY_FILE_PATH].
A mapping file between the passage id and the raw content mapping, named as [PASSAGE_ID2TEXT_PATH].

This mapping file does not exist above. Write a simple script to convert the initial collection to this mapping file.
Each line has the format of docid[\t]passage_raw_text[\n]. No header. We don't differentiate a document and a passage in this use case, so docid refers to the passage id.

Install Requirements
Download the requirements.txt from pygaggle, then do pip install -r requirements.txt.
Download the Pre-trained Reranker
Download BERT_Base_trained_on_MSMARCO.zip (roughly 1.1 G) from nyu-dl/dl4marco-bert.
Unzip and save to a path called [BERT_BASE_PSG_RETRIEVAL_MODEL_PATH].
Note: Different transformer version tends to read pre-trained model names slightly differently. You might need to tweak file names a bit for error message such as file not found. For example, rename [BERT_BASE_PSG_RETRIEVAL_MODEL_PATH] as lowercased, bert_config.json to config.json, and model.ckpt-100000.index to model.ckpt.index.
Run Reranker with rerank_custom_collection.py
python rerank_custom_collection.py --search_output_file [OUTPUT_PATH] \
            --qid2query_file [QUERY_FILE_PATH] \
            --passage_text_file [PASSAGE_ID2TEXT_PATH] \
            --model_name_or_path [BERT_BASE_PSG_RETRIEVAL_MODEL_PATH] \
            --device [your_device_setting] --output_path [RERANKER_OUTPUT_PATH]

[RERANKER_OUTPUT_PATH] is the rerank output file.
Each line has the format of qid[\t]query_text[\t]docid[\t]passage_text[\t]score[\n].
Screen results again, and iterate on this workflow!

hey @egzhbdt cool, thanks for this!
After chatting with the team, we think this doc might be best in pygaggle itself? Maybe you could start a docs/ directory for us and drop this in there? Please send PR. We could have mutual pointers between docs in anserini and pygaggle?

ref: https://github.com/castorini/pygaggle/issues/21

With the recent addition of bindings for the indexer in Python, I think this is resolved.

Hi,
I am trying to find the rerank_custom_collection.py. It seems the page is not available. Please advice.

@ghost ?

I appreciate if you can update on my request above.

Hi @Fatima-200159617 , are you looking for rerank_custom_collection.py?

Hi @Fatima-200159617 , apologize for the confusion and thanks for this. It was rerank_custom_collection.py.

Great thanks.


Debug off by default

Coverage remained the same at 60.577% when pulling 41d4e1c58cff6ed9b6481a33705342ff39350868 on debug-off into 6411c93a03ab8416d017533c7a75fe12c70166b1 on master.


Special handling of a closing time of 00:00

Should this include a closing time of 00:00 as well as 24:00? I've noticed that in a number of nodes and I'm not sure if that is an error in the data, or if this parser isn't handling it properly.
Originally posted by @TannerYoung in https://github.com/simonpoole/OpeningHoursParser/issues/5#issuecomment-545460273

@TannerYoung  can you give an example of the parser not handling this? We do auto-correct say 06:00-00:00 to 06:00-24:00, but that is what is supposed to happen.
PS: pls open a separate issue if you believe you've found an issue as a rule.

Prior to https://github.com/simonpoole/OpeningHoursParser/commit/d829f97db54c33e6306bc2283f8cdd567b5b8c59 a closing time of 00:00 would count as "earlier" than the start time, the commit provides a further flag, which when set to false, stops strict mode from considering this an error.


v1.1.6

Bug fixes

None

Changes
#485 - Add links to players from tournament print view
#488 - update dependency version
#490 - reccomended security fix
#299 - update to support for embedding
Admin
#487 - update backup/restore scripts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

51 of 51 (100.0%)  changed or added relevant lines in 7 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 95.06%

Files with Coverage Reduction
New Missed Lines
%

CourageScores/ClientApp/src/components/DivisionControls.js
1
91.81%

CourageScores/ClientApp/src/components/division_fixtures/tournaments/PrintableSheet.js
1
94.88%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
6653

Relevant Lines:
6773

💛  - Coveralls


add the pravega connector to alink

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix compilation

Waiting for https://github.com/rust-lang/libc/pull/1

New nightly is out, this PR is ready to be merged now.

The command "cargo test -j 1 --no-default-features --features "headless" --verbose" exited with 0.

Merging.


Shift the time dependency to a "stats" feature

This makes it optional, which is kinda convenient when time won’t build
because gcc is behind the times. But more importantly, it’ll be just a
tad faster.
(I’ll admit I did it purely because gcc wasn’t building at the time, but I still think it’s a good idea.)

Can you update the .travis.yaml so that the builds are tested both with and without the feature? You should be able to base it off of rust-openssl's setup: https://github.com/sfackler/rust-openssl/blob/master/.travis.yml
It'd also be nice to put a brief note about the feature in the README

Updated as requested, but I didn’t use the matrix functionality as the feature is only on the phf_mac crate (attempting to build the phf crate with --features stats will naturally fail).

Thanks!


Catch Exception rather than BaseException

As noted by ElevenPhonons on Reddit, this clashes with the intended use of the exception hierarchy defined here https://docs.python.org/3/library/exceptions.html#exception-hierarchy

pylint is a bit chatty, however, it can proactively help with these sort of issues.
pylint dtale_desktop | grep -i except
dtale_desktop/models.py:385:15: W0703: Catching too general exception BaseException (broad-except)
dtale_desktop/models.py:451:11: W0703: Catching too general exception BaseException (broad-except)
dtale_desktop/subprocesses.py:25:12: W0702: No exception type(s) specified (bare-except)
dtale_desktop/settings.py:105:4: W0702: No exception type(s) specified (bare-except)
dtale_desktop/settings.py:209:19: W0703: Catching too general exception BaseException (broad-except)

pylint is a bit chatty, however, it can proactively help with these sort of issues.
pylint dtale_desktop | grep -i except
dtale_desktop/models.py:385:15: W0703: Catching too general exception BaseException (broad-except)
dtale_desktop/models.py:451:11: W0703: Catching too general exception BaseException (broad-except)
dtale_desktop/subprocesses.py:25:12: W0702: No exception type(s) specified (bare-except)
dtale_desktop/settings.py:105:4: W0702: No exception type(s) specified (bare-except)
dtale_desktop/settings.py:209:19: W0703: Catching too general exception BaseException (broad-except)


JsonSchema.NET DataValidation

What's your idea or question?
Hello, I have a question about verification. I am using anyof array to verify json data one by one. It returns verification results and error messages very well.
But I have a question:
It's like, if the "IF" A attribute is filled in, the "Then" B attribute must be filled in. Now your package can return the error message that the "Then" B attribute must be filled in, but there is still no logic to return "IF".
Simply put, it returns an error result with no error return reason.
I know my hope is outrageous, please allow me to have higher expectations, just because your package is so excellent.
Thank you for your help!
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm sorry, I don't follow your explanation.  Could you show an example?

My problem stems from the following scenario:
Obviously, this is an "if" and "then" structure. "if" contains the "anyof" pattern. If any of the conditions of "anyof" are met, the constraints of "then" need to be accepted. I can know from the Evaluate method whether my data satisfies the "then" constraint, but I cannot know which condition of the "if" triggered the "then" constraint, and it is difficult to convert the corresponding validation logic into a warning.

Why not use a descriptive annotation (like the "description" annotation) in your "then" schema for this purpose?
Then evaluate with either OutputFormat.List or OutputFormat.Hierarchical.
The evaluation result will contain a list of the evaluation results of all the constituent (sub-)schemas that make up your whole schema in its EvaluationResults.Details property.
When validation fails, scan the EvaluationResults.Details list for any (sub-)schema evaluation result that is invalid and which also has an annotation of interest (like the "description" annotation). If you chose the OutputFormat.Hierarchical, you will have to do this scan recursively on each Details list of all the scanned evaluation results.
For every invalid evaluation result with an appropriate annotation (like "description"), extract/print the annotation value.
Illustrative example schema and example code:
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "type": "object",
    "if": {
        "anyOf": [
            { "properties": { "strValue": { "type": "string" } } },
            { "properties": { "numValue": { "type": "number" } } },
            { "properties": { "objValue": { "type": "object" } } }
        ]
    },
    "then":
            {
                "required": [ "foo" ],
                "description": "\"strValue\", \"numValue\" and \"objValue\" require also a \"foo\" value"
            }
}

var result = schema.Evaluate(jsonNode, new EvaluationOptions { OutputFormat = OutputFormat.List});
if (!result.IsValid)
{
    var failingSchemaDescriptions = result.Details
        .Where(r => !r.IsValid && r.Annotations?.ContainsKey("description") == true)
        .Select(r => r.Annotations!["description"]);

    foreach (var descr in failingSchemaDescriptions)
        Console.WriteLine(descr);
}

I don't think that addresses the question, which seems to be, "Which subschema in /if/anyOf passed?"
Do do that, I'd recommend a hierarchical output.
A modified version of @elgonzo's example schema is
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "type": "object",
    "if": {
        "anyOf": [
            { "properties": { "strValue": { "type": "string" } }, "required": ["strValue"] },
            { "properties": { "numValue": { "type": "number" } }, "required": ["numValue"] },
            { "properties": { "objValue": { "type": "object" } }, "required": ["objValue"] }
        ]
    },
    "then": {
        "required": [ "foo" ],
        "description": "\"strValue\", \"numValue\" and \"objValue\" require also a \"foo\" value"
    }
}

Adding required causes the subschema to fail if the property is missing.  Running this schema against
{
  "numValue": 42,
  "foo": true
}

gives the results
{
  "valid": true,
  "evaluationPath": "",
  "schemaLocation": "https://json-everything.net/9e1c5e4c78#",
  "instanceLocation": "",
  "annotations": {
    "if": true
  },
  "details": [
    {
      "valid": true,
      "evaluationPath": "/if",
      "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if",
      "instanceLocation": "",
      "details": [
        {
          "valid": false,
          "evaluationPath": "/if/anyOf/0",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/0",
          "instanceLocation": "",
          "errors": {
            "required": "Required properties [\"strValue\"] are not present"
          }
        },
        {
          "valid": true,
          "evaluationPath": "/if/anyOf/1",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/1",
          "instanceLocation": "",
          "annotations": {
            "properties": [
              "numValue"
            ]
          },
          "details": [
            {
              "valid": true,
              "evaluationPath": "/if/anyOf/1/properties/numValue",
              "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/1/properties/numValue",
              "instanceLocation": "/numValue"
            }
          ]
        },
        {
          "valid": false,
          "evaluationPath": "/if/anyOf/2",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/2",
          "instanceLocation": "",
          "errors": {
            "required": "Required properties [\"objValue\"] are not present"
          }
        }
      ]
    },
    {
      "valid": true,
      "evaluationPath": "/then",
      "schemaLocation": "https://json-everything.net/9e1c5e4c78#/then",
      "instanceLocation": "",
      "annotations": {
        "description": "\"strValue\", \"numValue\" and \"objValue\" require also a \"foo\" value"
      }
    }
  ]
}

And you can easily see which subschema of /if/anyOf passes (valid is true), and the errors in the failed ones tell you why those subschemas failed.

我不认为这解决了这个问题，这个问题似乎是“/if/anyOf通过了哪个子模式？”
这样做的话，我会推荐分层输出。
的修改版本@elgonzo的示例架构是
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "type": "object",
    "if": {
        "anyOf": [
            { "properties": { "strValue": { "type": "string" } }, "required": ["strValue"] },
            { "properties": { "numValue": { "type": "number" } }, "required": ["numValue"] },
            { "properties": { "objValue": { "type": "object" } }, "required": ["objValue"] }
        ]
    },
    "then": {
        "required": [ "foo" ],
        "description": "\"strValue\", \"numValue\" and \"objValue\" require also a \"foo\" value"
    }
}

required如果属性丢失，添加会导致子架构失败。运行此模式
{
  "numValue": 42,
  "foo": true
}

给出结果
{
  "valid": true,
  "evaluationPath": "",
  "schemaLocation": "https://json-everything.net/9e1c5e4c78#",
  "instanceLocation": "",
  "annotations": {
    "if": true
  },
  "details": [
    {
      "valid": true,
      "evaluationPath": "/if",
      "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if",
      "instanceLocation": "",
      "details": [
        {
          "valid": false,
          "evaluationPath": "/if/anyOf/0",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/0",
          "instanceLocation": "",
          "errors": {
            "required": "Required properties [\"strValue\"] are not present"
          }
        },
        {
          "valid": true,
          "evaluationPath": "/if/anyOf/1",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/1",
          "instanceLocation": "",
          "annotations": {
            "properties": [
              "numValue"
            ]
          },
          "details": [
            {
              "valid": true,
              "evaluationPath": "/if/anyOf/1/properties/numValue",
              "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/1/properties/numValue",
              "instanceLocation": "/numValue"
            }
          ]
        },
        {
          "valid": false,
          "evaluationPath": "/if/anyOf/2",
          "schemaLocation": "https://json-everything.net/9e1c5e4c78#/if/anyOf/2",
          "instanceLocation": "",
          "errors": {
            "required": "Required properties [\"objValue\"] are not present"
          }
        }
      ]
    },
    {
      "valid": true,
      "evaluationPath": "/then",
      "schemaLocation": "https://json-everything.net/9e1c5e4c78#/then",
      "instanceLocation": "",
      "annotations": {
        "description": "\"strValue\", \"numValue\" and \"objValue\" require also a \"foo\" value"
      }
    }
  ]
}

您可以轻松查看哪些子模式/if/anyOf通过（valid为真），而失败的子模式中的错误会告诉您这些子模式失败的原因。

I looked at your example, and the "description" attribute does solve this problem to a certain extent, but it seems to already exist in the json schema, and it is not a warning integrated through verification, and my schema comes from a third party
This is my code:
var failedMessages = new Dictionary<string, List>();
        //获取失败的验证信息
        foreach (var allOfSchema in allOfSchemas)
        {
            EvaluationResults rEvaluation = allOfSchema.Evaluate(_data, new EvaluationOptions
            {
                OutputFormat = OutputFormat.List
            });

            if (rEvaluation.IsValid)
                continue;

            foreach (var detail in rEvaluation.Details)
            {
                var errors = detail.Errors;

                if (errors != null && errors.Count > 0)
                    AddData(failedMessages, errors.First().Key, errors.First().Value);
            }
        }`

it seems to already exist in the json schema, and it is not a warning integrated through verification

But it is integrated into the validation result.  That result is the output.  You have to browse the output to find the information you're looking for.

my schema comes from a third party

This doesn't matter.  The output will still reveal the validation result (pass/fail) of every subschema.  Do answer the question, "Which subschema passed," you need to browse the output.

这没关系。输出仍然会显示每个子模式的验证结果（通过/失败）。请回答“哪个子模式通过了”这个问题，您需要浏览输出。

Yes, I converted the EvaluationResults to json data and clearly see the validation results and paths for each sub-schema.
But I want to convert the validation logic into natural language output to warn the user, and there's nothing I can do about it.
I also want to know the constraints of some fields in advance through verification. For example, when the A attribute is equal to false, the BCD attribute is disabled.
I tried to achieve these functions by recursively identifying each keyword using the verification path, which is obviously the stupidest and ineffective method.
I saw these possibilities from JsonSchema, are you interested? Or you have a good idea, thank you very much for your help and patience

I also want to know the constraints of some fields in advance through verification. For example, when the A attribute is equal to false, the BCD attribute is disabled.
This kind of static analysis isn't available with this library (or any that I know of).  There's some that is built into the internals of how evaluation is done, but it's not anything that can be output.
For now, that kind of analysis is just something you have to do manually.

For now, that kind of analysis is just something you have to do manually.

Yes, I have tried many similar libraries, and your library is already a very good work. Thank you for your help.


FSDP does not work with mixed precision training

System Info
- `Accelerate` version: 0.22.0
- Python version: 3.10.10
- Numpy version: 1.23.5
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- System RAM: 59.85 GB
- GPU type: Tesla V100-SXM2-16GB

I could get FSDP working on SageMaker without mixed precision (precision setting to no) using the FSDP plug from accelerate. But when I turn on mixed precision (which is supported by the GPU) the FSDP did not work.
I also tried using PyTorch precision setting data class to config the mixed precision but still had no luck.
Is this issue due to integration of Deepspeed + FSDP?
How can we support mixed precision + FSDP in accelerate? I'd love to make a PR if there is a possible solution with changing low level Deepspeed or FSDP codes.

### Information

- [ ] The official example scripts
- [X] My own modified scripts

### Tasks

- [ ] One of the scripts in the examples/ folder of Accelerate or an officially supported `no_trainer` script in the `examples` folder of the `transformers` repo (such as `run_no_trainer_glue.py`)
- [X] My own task or dataset (give details below)

### Reproduction

```python
fsdp_plugin = FullyShardedDataParallelPlugin(
        state_dict_config=FullStateDictConfig(offload_to_cpu=True, rank0_only=True),
        optim_state_dict_config=FullOptimStateDictConfig(
            offload_to_cpu=True, rank0_only=True
        ),
    )

accelerator = Accelerator(fsdp_plugin=fsdp_plugin, **cfg.accelerator)

# prepare model first
model, lm_head = accelerator.prepare(model, lm_head)
optimizer, train_loader, lr_scheduler = accelerator.prepare(
      optimizer, train_loader, lr_scheduler
  )

Expected behavior
The training will crash if using mixed precision.

Hello, can you try out Accelerate from the main branch to see if the issue has been fixed?

It is a PyTorch issue not related to Accelerate. In torch version 2.1 the problem was resolved.

@pacman100 I have been using PyTorch FSDP with HF Accelerate and mixed_precision: 'bf16' in my accelerate config file. My training doesn't crash even though my PyTorch version is 2.0.1.
Your blog from 2022 says that FSDP with MP didn't work at that time. Do you know in which PyTorch version this issue got fixed?


Improve Basic of Deep Learning .ipynb file with a readme.md file

I can add all the necessary details related to Keras in the basics of the deep learning directory,
I will also add a ReadMe.md file for the same and add more data in the other two files.
I will add images and other visuals also!

Hii!
I am a participant in GSSOC'22. Please assign me this issue.

@pratishthaa  Could you please assign this issue to me.I have knowledge in keras.
I am GSSOC'24 participant.Kindly assign it to me.

Hi @pratishthaa
I’m interested in taking on the task of improving the "Basics of Deep Learning" notebook and creating a README.md file. With my knowledge of TensorFlow and CNNs, I plan to enhance the notebook by adding detailed explanations, examples, and visualizations to clarify the concepts. The README will provide an overview of the notebook’s content, installation instructions, and usage guidelines to help users navigate it effectively.


f80 and f128 aren't being correctly rounded when converting to f64

It probably the other way around.


A question about rlootrainer

Method description
rlootrainer does not seem to use the self.policy model in train() function. I don't know the meaning of self.policy in the init function.
Open source status

[X] The method implementation is available
[ ] The model weights are available
[ ] The training datasets are available

Provide useful links for the implementation
No response

It utilizes self.model, which is defined in [this line](https://github.com/huggingface/trl/blob/6d4ed070f1f53a87fb3cff2eb82a56db093bccc6/trl/trainer/rloo_trainer.py#L162). This approach is also adopted in PPOTrainer. I believe this is a deliberate nomenclature choice, designed to remain consistent across various preference learning frameworks without introducing the complexity of aligning with the diverse terminologies used in academic papers.


WASM support

Hey,
Current Version relies on dart:js  package:js and dart:html which it incompatible with WASM.
Thank you

It's actually supported in the repo code, I need to do a little clean up before publishing.
If you need WASM client right now, you can temporarily override dependency with git repo.

Published https://pub.dev/packages/fetch_api/versions/2.0.0-wasm

Amazing. Thank you


Metal visualization

Add thick lines shader

LGTM! Just a couple notes:

Do auto-format with swift-format
Update CHANGELOG


bin/sh- dart is not find

thanks for your help.
i installed flutter and dart plugins in vs code ide, then i create the sample project, the project can run in my phone, then i reboot my computer, open ide and run the project on my phone,  the ide report an error '/bin/sh dart is not find', that make me confused.

You probably only set the path temporary and it was therefore removed after the restart, please look at: https://flutter.io/get-started/install/ on how to set path variable permanently.
Also check that your path to flutter is defined correctly within your IDE
As this is not an issue with flutter, this is not an issue that belongs here and therefore this issue should be closed.


Increasing Number of Maintainer Approvals for PR

Bug Report

GOVERNANCE.md requires that we have two maintainers review each PR. Our current automated checks only require one approval.

Once we move packages into their own repos, we can look into implementing this. This would cause 2 approvals for package PRs.

I think the point was we need to update the governance doc to actually reflect how we are doing things. We should also remove the wording about waiting 5 days to merge PRs.
I think now that we have a documented feature proposal process in place, that addresses the majority of what the current content of the governance doc was getting at. But it's kind of muddled, as is. We may want to think about expanding or clarifying what scenarios it is referring to.

The wording of the 5 days is coming in another PR. Changing the approvers was a different issue.

So is the consensus of the maintainers then that you don't want to implement 2 approvers for PRs? It's a common rule that many other projects follow. Just want to make sure we're doing the right thing here.

Enabled "2 approvers required to merge a PR"


UserCustomAction localization fix

Q
A

Bug fix?
yes

New feature?
no

New sample?
no

What's in this Pull Request?
A UserCustomAction migth not contain a Title or Description. If you PersistMultiLanguageResources it will fail because the Title or Description is null.
I've also changed the use of Title in the resource key to the Name of the UserCustomAction.

Hi Michael, thanks for the contribution. Good fix.


k3s_1_28: 1.28.11+k3s2 -> 1.28.12+k3s1

https://github.com/k3s-io/k3s/releases/tag/v1.28.12%2Bk3s1
Description of changes
1 package updated:
k3s_1_28 (1.28.11+k3s2 → 1.28.12+k3s1)
1 package built:
k3s_1_28

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

 However, I tracked down why the tests are failing and I think this has never worked with v1.28.x. The pre-1.29.x versions of kubectl weren't able to handle the JSONstring used in the test (i.e. {.status.conditions[?(@.type=="Ready")].status}=True) because they split the JSONpath input on = and == . While the v1.28.x versions just split on every = (e.g. here), the v1.29.x and v1.30.x versions introduced a splitJSONPathInput function that respects == (e.g. here and here).
I try to find previous runs of ofborg for v1.28.x and the JSONpath test, but can't find any. Ofborg seems to only run tests with the newest version? For instance, these are the logs of the tests that introduced the JSONpath input initially, they were only run for v1.30.2.
Do you know how ofborg decides how to run tests? Does just take the k3s package and ignores other versions?
Anyway, I think we should rewrite both tests to use jq for json processing instead of JSONpath (which is only partially supported by kubectl anyway...).

Thanks for the fix.
The fix commit should precede the package bump or else it is going to error when bisecting. Then, makes sense to rebase to master as usual. Still, LGTM.

Sorry for the delay, I rebased and changed the order of commits now. Let me know if there is anything else

Before back-porting it's necessary to back-port the PRs that adds the tests.

Before back-porting it's necessary to back-port the PRs that adds the tests.

I'm not sure how much do we want to backport on second thought. Would it make sense to only backport version information and hashes similar to #335107?

Yes, that would be good.
Also, as there is infinite work, I think, we should be strategic on the actions we take, since time of everyone is limited, so it is fine to lag/ignore on back-ports that have failed, unless it blocks back-porting required to remove outdated K3s versions on NixOS releases. Stable users interested in newer features can always pick up from where we left.


JFXAlert - Difference into Ubuntu Linux and Windows

Hi,
I need to use JFXAlert to show modal message on my application. I used the demo example for start.
Well, when i open JFXAlert on Ubuntu Linux, the application open a blank screen over the main screen with the message and button.

I execute the same demo application on Windows and then JFXAlert has open withou background white.

How can i make for the JFXAlert be transparent in Ubuntu Linux too?

Hi @tiagomegasul
by default the background should be transparent, unless you changed that in css. You can try removing the css styling to narrow down the cause.

@jfoenixadmin To test the component, I downloaded it from Git, the source code of the JFoenix Demo. In the demo application presents the same problem, ie when opening in windows is transparent and when opening in Ubuntu Linux is white background.
So I think it's not a CSS problem, but if so, could you tell me how to do it so that Ubuntu Linux also has a transparent background?


HDFS-16012.Improve DataXceiver#copyBlock() log printing

2988

 Quality gate: Passed
 Everything looks good
Details

 Quality gate: Passed
 Everything looks good
Details


refactor & cleanup (frontend) : chatinterface | for  #705

refactor & cleanup (frontend) : chatinterface

Split into separate components
Moved to new folder
Cleaned up unused states, etc

for  #705

This seems good to me! Once you've got it rebased feel free to ping me


Ask about .py and .cpp 's function.

Hello!
I see both cpp and python code in your upright_control and upright_ros_interface,
Is the python code only used to simulatewith Pybullet, and can the python code be removed if other simulation tools are used, such as Webots and Gazebo?
Hope to hear from you!!

At the moment a lot of the parsing of configuration options, which notably includes parsing the configuration of the balanced objects, is done purely in Python, even when using the C++ controllers in upright_ros_interface. Therefore both Python and C++ components are currently required.

Ideally, all the machinery would be written in C++ with bindings only to support simulation. However, prototyping in Python is faster than C++, so some of the code (the parsing in particular) was written in Python and it would take a fair bit of time and effort to translate it.

I'll go ahead and close this; feel free to re-open if you have more questions.


[nginx-ingress-controller] Add annotation to add CORS support

This change is

I signed it

@aledbf - can you give an example on how to enable cors in ingress, I added annotation ingress.kubernetes.io/enable-cors: "true" but could not get this work. I tried this using nginx-ingress-controller:0.8.3

@vinay-g this feature is not available in 0.8.3. Next release


Missing Functions..

-Arena delete command
-File Support
-Option to disable Scoreboard
-Arena editing after finishing Arena
-Team Help only in German (even after changing to english)
-Armor can get dragged out of the Armor Slot

Arena delete command - DONE

Option to disable Scoreboard - DONE

Team Help only in German (even after changing to english) - DONE

Armor can get dragged out of the Armor Slot - DONE

Arena editing after finishing Arena - DONE

File Support - Addet SQLite Support


Add support to load/override model settings

This change allows you to add a .aider.models.yml file to your home director, the project directory or through a command line argument any file. The change will load in the following order

Home directory
git root
current directory
command line arg

I moved a few things around and switch the litellm settings to the .aider.litellm.models.json by default, hopefully identifying it a little better.

I wonder, should we combine these into a single file like:
- name: "gpt-4-turbo-2024-04-09"
  edit_format: "udiff"
  weak_model_name: "gpt-3.5-turbo"
  use_repo_map: true
  send_undo_reply: true
  accepts_images: true
  lazy: true
  reminder_as_sys_msg: true
  examples_as_sys_msg: false
  info:
    max_tokens: 4096,
    max_input_tokens: 32000,
    max_output_tokens: 4096,
    input_cost_per_token: 0.00000014,
    output_cost_per_token: 0.00000028,
    litellm_provider: "openai"
    mode: "chat"


duplication of effort

Hey,
So I had been working on the same thing and I see that you added this to nvim tree-sitter before I got around to doing the same.
I haven't taken the time to look at your work but feel free to check out mine and see what you can synchronize, if anything at all.

 I see you added some things in your grammar that are still missing on mine, maybe we could merge both efforts into a single repository 😃

Yeah, I see you have a lot more test cases than I have, though. What I did was try my grammar out on Vala source code with tree-sitter parse/highlight.


Missing extra metadata overlays for videos

Here are missing extra information overlays on the screenshot (not all videos are labeled with duration):

Brief debugging showed that this is caused by lacking meta.extra field in ExtraLoader.kt:
if (meta.extra == null) return

Duration overlays look to be fixed, but some of videos miss resolution overlays.


add log1p param to calculate_qc_metrics

Do we need to xo aider the base parameter of log1p here?

In my opinion, we'll likely move away from logging everything. Isaac built this in so that one can conveniently visualize things in seaborn; I added the switch to turn it off so that the basic tutorial of v1.5 doesn't lead to a completely cluttered AnnData object.
But, I guess, we all agree that this here isn't the final solution. 😄