Can I use a Custom embedder in the crewai_tools?

I am trying to use the the crewai_tools, the RAG tools in particular. Lets take the DirectorySearchTool() in this case.
How do I use a custom embedder provider? The only options that embed chain have are from the following list. 'openai', 'gpt4all', 'huggingface', 'vertexai', 'azure_openai', 'google', 'mistralai', 'nvidia' Embedding models for which I need API keys.
directory_search_tool = DirectorySearchTool(
    config=dict(
        llm=dict(
            provider="ollama", # Options include ollama, google, anthropic, llama2, and more
            config=dict(
                model="llama2",
                # Additional configurations here
            ),
        ),
        embedder=dict(
            provider="google", # or openai, ollama, ...
            config=dict(
                model="models/embedding-001",
        ),
    )
)

I know that CrewAI uses embedchain module for RAG operations and the default provider is set to openai. And to use openai embedding model one needs to set OPENAI_API_KEY as environment variable.
But the situation is that the LLMs that I am using is from the from my Company's/Organization's langchain.openai import ChatOpenAI module (A custom module basically) and I don't need to set API keys and stuff for using the LLMs. Something like this:
llm = ChatOpenAI(proxy_model_name='gpt-4-32k')

which is of type: .proxy.langchain.openai.ChatOpenAI
Question: How do I use a custom embedder provider? Is there a provider called "custom" or anything that i can use in my case?

You can use lm-studio or any other provider that uses openai api format.
embedder=dict(
        provider="openai",
        config=dict(
            model="CompendiumLabs/bge-large-en-v1.5-gguf",
            api_key="lm-studio",
            api_base="http://localhost:1234/v1"
        ),
    ),

Not in current version v0.30.11 with ollama, see other post.

Not in current version v0.30.11 with ollama, see other post.

My solution works for v0.30.11 .. at least, for me.
Did you try?

this one: https://github.com/xorbitsai/inference

您可以使用lm-studio或任何其他使用 openai api 格式的提供商。
embedder=dict(
        provider="openai",
        config=dict(
            model="CompendiumLabs/bge-large-en-v1.5-gguf",
            api_key="lm-studio",
            api_base="http://localhost:1234/v1"
        ),
    ),

oh,that's not very good all in open-AI


circumvent rpm bin for travis builds

ignore this PR for now, just testing some stuff out.

This is not enough. I propose to simply skip the test it there's no rpm binary available.
This is a temp project after all

you're right, i was only mucking about, it's fixed now. PTAL!
ofc ubuntu install rpm in /usr/bin/rpm and opensuse in /bin/rpm. lol. booo!

@flavio do you want to merge this?

Yes, my review request was stuck... 🤦♂

no worries! issue is addressed now.

ah, i forgot to rebase. well that's that i guess


CLOUD-57107 Fix instance metadata status during cluster sync

@doktoric plz review review

Jenkins build failed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2419/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2420/

@mhmxs our infrastructure related instance metadata should not depend on Ambari host states. If we terminates a host then it's state is updated after many missing heart beats to 'UNHEALTHY', but the host states could be get from the provider immediately when stack related instance metadata is syncing during stack sync.

LGTM

Unfortunately currently there is relation between instance and host statuses, so some solution requires to synchronize them if necessary.


Argus upstream

WIP.  Need to set up a local environment to manually test.  It was too complicated to try to allow sns or argus upstream.  This requires argus upstream.
https://github.com/xmidt-org/hecate/issues/42

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: kristinapathak:x: njharterYou have signed the CLA already but the status is still pending? Let us recheck it.


Runner

@nbigaouette This is somewhat WIP in that if this is deemed acceptable, then some docs should be added, things may be cleaned up a bit etc, but it's fully functional. Basically I wanted to push this asap to see what you think.

On tiny examples it reduces the total runtime from 15us to 8us.  Pretty much 100% of that time is now being spent within ONNX C API.
For big examples, I think this would be handy as well since it allows to avoid both copying the inputs and avoids allocations for the outputs.
There's no more tracing calls on the hot path (since there's no drops).
There's Default currently required for output type. As long as we're sure we'll never use strings, might add a Copy to the element type requirements and then Default can be dropped (so that the output array can be zero-initialized).

Can be used like this:
let mut runner = session.make_runner(input_arrays).with_output::<f32, Ix3>()?;
runner.execute()?; // no allocations to generate outputs, no copying of inputs
dbg!(&runner.outputs()[0]);
*(&mut runner.inputs()[0]) *= 2.0f32; // modify the inputs without copying or allocation
runner.execute()?; // no allocations, no copying
dbg!(&runner.outputs()[0]);

@nbigaouette Any thoughts about this? This has been been open for a month now...

Sorry about the delay, personal time is quite short these days and was hopping holidays would make things easier.
I'm taking a look right now.

Love the zero copy aspects. Right now if I understand correctly an addition to the API allows this zero-copy. I would like to have a single API instead and thus get rid of the original one. I'll play around a bit with the new one.

The zero-copy aspect is issue #11.

Yea, this was kind of the main point. In my use case it's absolutely prohibiting to spend any time (even if it's microseconds) on either cloning arrays, re-validating what's already been validated or doing any ffi calls aside from the actual execute().
I've added it as a separate API so as not to touch the original one but I think it does fully cover the original one at least in the single-threaded case. Note that this is not thread-safe (I think) as it holds pointers to some mutable arrays that you are supposed to fill out. You would probably have to create one runner per thread if you wanted MT?
Would sure be up for any discussion, anyway :)
+@marshallpierce as well since they've shown interest in the original issue as well.

I was about to suggest to merge the runner into the session and get rid of the original API. But I think it makes sense to keep both actually.
The make_runner() takes ownership of the array... Outputs gets allocated and a reference (slice) to it is made available. What I would like to see is to pass a reference to the input. This way the user is free to decide how to handle the allocation (construct new inputs or reuse the buffer). That introduces a lot of lifetime but I guess it should be possible...

Forget my comment about the input reference, I see that it's made available to modification.

I don't want to push to the branch but I did modify the 'sample' example. Here's the patch if you don't mind applying it:
From ade58d96d16703edb15ad806b8a37d64475e5d54 Mon Sep 17 00:00:00 2001
From: Nicolas Bigaouette<EMAIL_ADDRESS>Date: Sat, 26 Dec 2020 14:44:50 -0500
Subject: [PATCH] Adapt 'sample' to runner API

---
 onnxruntime/examples/sample.rs | 35 +++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)

diff --git a/onnxruntime/examples/sample.rs b/onnxruntime/examples/sample.rs
index fff0772..3d5ee51 100644
--- a/onnxruntime/examples/sample.rs
+++ b/onnxruntime/examples/sample.rs
@@ -1,9 +1,11 @@
 #![forbid(unsafe_code)]

-use ndarray::Array;
+use ndarray::{Array, Ix4, IxDyn};

 use onnxruntime::{
-    environment::Environment, tensor::OrtOwnedTensor, GraphOptimizationLevel, LoggingLevel,
+    environment::Environment,
+    runner::{Outputs, Runner},
+    GraphOptimizationLevel, LoggingLevel,
 };
 use tracing::Level;
 use tracing_subscriber::FmtSubscriber;
@@ -62,12 +64,31 @@ fn run() -> Result<(), Error> {
         .unwrap();
     let input_tensor_values = vec![array];

-    let outputs: Vec<OrtOwnedTensor<f32, _>> = session.run(input_tensor_values)?;
+    // You can simply run the session with the input to get the output...
+    // let outputs: Vec<OrtOwnedTensor<f32, _>> = session.run(input_tensor_values)?;

-    assert_eq!(outputs[0].shape(), output0_shape.as_slice());
-    for i in 0..5 {
-        println!("Score for class [{}] =  {}", i, outputs[0][[0, i, 0, 0]]);
-    }
+    // Or, you can build a runner to pre-allocate the output
+    let mut runner = session
+        .make_runner(input_tensor_values)
+        .with_output::<f32, Ix4>()?;
+    runner.execute()?;
+
+    print_runner_outputs(&runner);
+
+    // Since the runner now owns the input and keep it alive, we can access it
+    // and modify it without reallocation.
+    *(&mut runner.inputs()[0]) *= 2.0f32;
+    runner.execute()?;
+
+    print_runner_outputs(&runner);

     Ok(())
 }
+
+fn print_runner_outputs(runner: &Runner<f32, IxDyn, f32, Ix4>) {
+    let outputs: Outputs<f32, Ix4> = runner.outputs();
+    let output = &outputs[0];
+    for i in 0..5 {
+        println!("Score for class [{}] =  {}", i, output[[0, i, 0, 0]]);
+    }
+}
--
2.29.2

Yea, inputs are available for modification of course.
Here's the use case that's not covered: you have an &InputArray and you would like to pass it in as is, and without copying, for execution. However, this would require creating tensor wrappers, revalidation of the shapes etc; if you're doing it in a hot loop you would probably want to avoid it, hence the chosen approach.
It would probably be possible to cover this use case as well, if the runner had something like execute_with(...) which allowed overriding inputs for just one execution (with all the involved overhead) if it's really needed.

FWIW, this style of API seems like it would be a good fit for my use case: an http service that receives onnx tensor protobuf requests, runs them through onnxruntime via this crate, and emits the output tensor as the response. The model doesn't change in the lifetime of one process, so I would ideally need one Send + Sync runner ever.

I have updated the branch with latest changes from master (sorry if I pushed to your fork? not sure how github handled this...)
Only thing remaining is documentation and trivial clippy comments.

I have updated the branch with latest changes from master (sorry if I pushed to your fork? not sure how github handled this...)
Only thing remaining is documentation and trivial clippy comments.

@nbigaouette Apologies, was a bit busy and was planning to get back to this on Friday/weekend.
(As a minor note, it's generally a bad idea to merge from master back into feature branches which will then be merged back into master - I'll see if I can try rebasing this branch on master and force pushing)

@nbigaouette Apologies, was a bit busy and was planning to get back to this on Friday/weekend.
(As a minor note, it's generally a bad idea to merge from master back into feature branches which will then be merged back into master - I'll see if I can try rebasing this branch on master and force pushing)

I can try handling the documentation.
What else do you think should be done, overall?

I can try handling the documentation.
What else do you think should be done, overall?

I agree a rebase should be done instead of merging master. GitHub's UI is not always clear as the action's result...
What remains to be done:

Documentation
Trait bounds as "where clause" as commented above
Trivial clippy errors

After that I'd like to merge this and release a new version to crates.io to be experimented more with.

I agree a rebase should be done instead of merging master. GitHub's UI is not always clear as the action's result...
What remains to be done:

Documentation
Trait bounds as "where clause" as commented above
Trivial clippy errors

After that I'd like to merge this and release a new version to crates.io to be experimented more with.


[bug] panic: assertion failed: removed_resource.is_none() in src/resources/mod.rs:116:5

Describe the bug
I received the information from a person who has run the application many times in short intervals since closing it.
It threw him an error from tauri crate.

Reproduction

Launch apllication
Close Application
Launch apllication
Close Application
etc.

Expected behavior
The application should work without a problem.
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.26100 x86_64 (X64)
    ✔ WebView2: 131.0.2903.86
    ✔ MSVC:
        - Visual Studio Build Tools 2022
        - Visual Studio Community 2022
    ✔ rustc: 1.85.0-nightly (d49be02cf 2024-12-02)
    ✔ cargo: 1.85.0-nightly (4c39aaff6 2024-11-25)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: nightly-x86_64-pc-windows-msvc (default)
    - node: 18.20.4
    - npm: 10.7.0

[-] Packages
    - tauri 🦀: 2.1.1
    - tauri-build 🦀: 2.0.3
    - wry 🦀: 0.47.2
    - tao 🦀: 0.30.8
    - tauri-cli 🦀: 2.1.0
    - @tauri-apps/api : 2.0.0 (outdated, latest: 2.1.1)
    - @tauri-apps/cli : 2.1.0

[-] Plugins
    - tauri-plugin-single-instance 🦀: 2.0.2
    - @tauri-apps/plugin-single-instance : not installed!
    - tauri-plugin-dialog 🦀: 2.0.4
    - @tauri-apps/plugin-dialog : 2.0.1 (outdated, latest: 2.2.0)
    - tauri-plugin-http 🦀: 2.0.4
    - @tauri-apps/plugin-http : 2.0.1 (outdated, latest: 2.2.0)
    - tauri-plugin-os 🦀: 2.0.1
    - @tauri-apps/plugin-os : 2.0.0 (outdated, latest: 2.2.0)
    - tauri-plugin-notification 🦀: 2.0.1
    - @tauri-apps/plugin-notification : 2.0.0 (outdated, latest: 2.2.0)
    - tauri-plugin-global-shortcut 🦀: 2.0.1
    - @tauri-apps/plugin-global-shortcut : 2.0.0 (outdated, latest: 2.2.0)
    - tauri-plugin-fs 🦀: 2.1.0
    - @tauri-apps/plugin-fs : 2.0.3 (outdated, latest: 2.2.0)
    - tauri-plugin-updater 🦀: 2.1.0
    - @tauri-apps/plugin-updater : 2.0.0 (outdated, latest: 2.3.0)
    - tauri-plugin-process 🦀: 2.0.1
    - @tauri-apps/plugin-process : 2.0.0 (outdated, latest: 2.2.0)
    - tauri-plugin-shell 🦀: 2.0.2
    - @tauri-apps/plugin-shell : 2.0.1 (outdated, latest: 2.2.0)
    - tauri-plugin-log 🦀: 2.0.3
    - @tauri-apps/plugin-log : not installed!

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace
no provided

Additional context
No response

nice


multiple childItems

I am creating multiple CrimeChild(ModuleChildItem) instances to insert various String to my multiple textboxes inside childItem.
Whatsoever, everything works fine except the fact that it creates multiple childItemsView even I am just simply recreating CrimeChild and then attaching it to Crime List.
I understand that this is core function as in your sampleApp the childrens are separated to each own views, but is there somekind of method which would change this ability? I would like to put all child to each List entry as far as I dont know how many entries i will have.

Correct me if I'm wrong, but it seems you want your parent to only have one child view. If thats the case then you need to have only one item in the childList.
The adapter uses the childList in order to determine how many items to show, any extra data should be held in the Child object itself.


What's evaluation protocol?

Hi, author,
Thanks for your code and paper.
I have a few questions about the evaluation protocol. Let's take CIFAR-10-C as an example, for the ''Near'' scenario, the online data stream should consists of the original target samples (i.e., Benign) of CIFAR-10-C and the CIFAR-100 test set (if I understand right).

So the model need to classify only the Benign samples or it has to both classify Benign samples and identify samples from CIFAR-100 test set?

And accordingly, the dimension of  the classifier is unchanged or the the classifier is expanded to ''C+1''-dim? C for number of categories and 1 for anomaly detection.

Hopefully you can explain more about the new setting. Thx.

Hi,
I appreciate your interest in our paper.
We focused on (1) the effect of non-interest samples on test-time adaptation of benign data and (2) methodology to reduce the impact.
Therefore, our test stream consists of non-interest and benign test data without label information. Consequently, it is straightforward to classify all incoming samples, whether benign or not.
Although our methodology aims to reduce the impact of non-interest samples, we do not directly "detect" or "classify" the non-interest samples. We evaluated by only calculating the accuracy of the benign test samples, excluding non-interest samples.
We expect future work to identify and discard non-interest samples in test-time adaptation.
Thank you.
Taeckyung


Very low quality text.

I believe better quality text could be provided by Microsoft than the one present on this docs.
Examples:
BIOS Phase - Method 1- It says (point 3) "select NEXT -> Command Prompt" and immediatly follows (point 4) "Afeter startup reapir select shutdown". Beats me how opening a command prompt could repair my startup!
On method 3 - "If you receive BCD-related errors" doa "bootrec /scanos" and "restart to check whether the problem is fixed". Again beats me how a simple listing command option (such as /scanos) can fix whatever error I had previously.
There's more...
On method 4 - "Run the attrib command to unhide the file: attrib -r -s -h". I'm afraid this command just throws an error, wherever you type it, because it's mandatory to tell the file target.
It's just creepy how bad this text is. I'm a teacher at high school and I would FAIL any student of mine that would deliver such nonsense.
Sleep well.
[Escreva aqui os seus comentários]

Detalhes do Documento
⚠ Não edite esta secção. É necessário para a ligação de problemas docs.microsoft.com ➟ GitHub.

ID: 6fc264df-cbd1-ac1f-3926-841fcab7dc31
Version Independent ID: 67c2aea4-0d28-3d8e-e935-8af05291c94e
Content: Advanced troubleshooting for Windows boot problems - Windows Client Management
Content Source: windows/client-management/advanced-troubleshooting-boot-problems.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

As a former dedicated computer support agent, I would like to mention that some of the necessary work is done automatically in the background. In particular, this is true for Method 1: Startup Repair tool (https://docs.microsoft.com/pt-pt/windows/client-management/advanced-troubleshooting-boot-problems#method-1-startup-repair-tool).
The reason why this step suggests to choose the Command Prompt option as your startup selection, is to run the Startup Repair Tool in the background and not attempt to start the full GUI desktop, to avoid any form of stop errors during the full GUI desktop completion process.

Method 3: Fix BCD errors (https://docs.microsoft.com/pt-pt/windows/client-management/advanced-troubleshooting-boot-problems#method-3-fix-bcd-errors):

See https://support.microsoft.com/en-us/help/927392/use-bootrec-exe-in-the-windows-re-to-troubleshoot-startup-issues for more information about what the Bootrec.exe does in the Windows Recovery Environment does in the background.

Maybe your issues have been outside the scope of this tool, so that might be a reason why it did not work in your case(s).

On method 4 - "Run the attrib command to unhide the file: attrib -r -s -h". I'm afraid this command just throws an error, wherever you type it, because it's mandatory to tell the file target. [ ... ]

If you either get an error when trying to run the attrib command or have to specify the path to attrib.exe, it is possible that your computer problem includes missing startup files where the path environment variable is set, including the path to C:\Windows\system32\.

I am not trying to say that your suggestion is incorrect, I am trying to say that troubleshooting Windows startup (boot) problems can be quite varied and cumbersome to write for, particularly when it comes to some of the variations that may occur between some of the OEM brands who may include some of their own diagnostic tools in the startup.
Sure, feel free to suggest improvements to the current documentation. We other contributors may be able to help if you have questions about how to get the improvements added to the current documentation.

@rmpv1920 .I also read this article,. In method 4, you must change to system reserved partition before entering attrib command.
More those methods works in windows 7  BIOS based computers

Closing via the answer provided by the community above. Thank you for the discussion.


feat(driver): Refactor Driver out of Client

Description
Refactors the driver out of kona-client and into a new crate with trait abstractions.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#794 👈
main

This comment was automatically generated by st.


Calling Call-log API using RingCentral JS SDK

Hi Team,
I am using the below function to test the API Call using the JS SDK, what I am getting back in the console log is as below, can you please check my code and let me know what is the issue here.
The response returned by this API is : [object Object]
The response JSON returned by this API is : [object Object]
app.get('/log', function(req, res) {
var authData = rcsdk.platform().auth().data();
rcsdk.platform().auth().setData(authData);
token_json = authData['access_token'] ? JSON.stringify(authData.access_token, null, ' ') : '';
response = token_json;

console.log("Before the/account/~/extension/~/presence");

rcsdk.platform().get('/account/~/extension/~/call-log').then(function(apiResponse){
    // If you want the response object
    console.log("The response returned by this API is : " + apiResponse.response());
   // If you want the response object as JSON
    console.log("The response JSON returned by this API is : " + apiResponse.json());
});

console.log("Outside the API Request");

res.render('index', {
authorize_uri: rcsdk.platform().authUrl({
  brandId: process.env.RC_APP_BRAND_ID,        // optional
  redirectUri: process.env.RC_APP_REDIRECT_URL // optional if 1 configured
}),
redirect_uri: process.env.RC_APP_REDIRECT_URL,
token_json: token_json,
dibyendu_roy: response

});
// Render home page with params
});

@dibyenduroy
Are you getting the below console logs in the browser:
The response returned by this API is : [object Object]
The response JSON returned by this API is : [object Object]

You would need to convert the JS Object into a JSON string using JSON.Stringify() as below:
rcsdk.platform().get('/account/~/extension/~/call-log').then(function(apiResponse){
    // If you want the response object as JSON
    console.log("The response returned by this API is : " + JSON.stringify(apiResponse.json(), null, 2));
});

@anilkumarbp thanks, yes that's what was happening, I did not do the conversion. Now I can see the  logs. Appreciate your help. Awesome.


METRON-151: Remove yum update from deployment scripts

Relocated to image creation. Probably shouldn't have been doing this in the first place.

+1

Definitely +1


[BUG] Scalable ammo crates crash server when touched

Short Description
When you re-scale an already spawned scalable ammo crate there is a chance that it crashes the server when touched with the physgun

Had this happen with multiple people on my server, unfortunately it seems to be every 1/1000 time because I haven't been able to intentionally recreate it. I have ruled out anything else that would be coincidentally crashing the server - all 4 times I've caught it happening, it was a player re-scaling an existing ammo crate and then grabbing it with the physgun. If I catch any console errors relating to this I'll post them.

I wonder if that is being caused by f8b01db. I could try rolling back those changes and see if this still happens.

Rolled back the clientside desync fix on acd0683, update and try to replicate the issue. Personally, I haven't been able to replicate this crash, so I can't confirm this will fix it.

Haven't had any crashes reported due to this issue since acd0683 but of course it's so rare it may be a coincidence.

After several months, I was unable to replicate this issue so I assume it was a false positive. Closing.

After several months, I was unable to replicate this issue so I assume it was a false positive. Closing.


Add the user info endpoint

For more information read this document : http://openid.net/specs/openid-connect-core-1_0.html#UserInfo

TODO :
==> Need to check if the access token is correct or not. Throw an exception : "UnauthorizedException" in the action "GetJwsPayload"
==> Fetch the user info from the IdToken

TODO : Write some UTs

Write some UT to test the other profile


README overhaul

I'm willing to take this on, possibly tomorrow. There's a few main things that I want to do:

Keep the intro b/c it's absolutely amazing, whoever wrote that for the original emacs hydra... hats off to ya
Completely remove the examples, and put them in the wiki instead. Point to the wiki from the README
Majorly re-write the Hydra({}) documentation... It's currently very hard to navigate, easy to get lost in, and hard to see what's important.
Potentially reorganize some of the other parts

Writing documentation is hard, godspeed lol.
I would highly advise we do this in sections, and a primary goal here would be that the readme can be easily converted to vimdoc. Anything that doesn't really fit in the vim help should, IMO be migrated to the wiki (with links as needed in the README).


Handle security audit findings

fixes #21

DP-005 is quite a borderline problem and more broad regarding the way Frictionless project (and basically majority of other projects) handles dependencies so I created an issue to consider acting on it or not - https://github.com/frictionlessdata/dplib-py/issues/22

Thanks!


Applicant_id is missing in OnfidoConfig()

Hi, Team
Basically we are capturing the document and photo/video for applicant_id and those details stored on Onfido dashboard on applicant_id. But this plugin is not setting the applicant id. Then where document and photo will store in Onfido dashobard?
Thanks
Manivel

Hi @maniveltvl
This plugin supports only SDK token mechanism, which is newer than Mobile token mechanism which requires applicant_id. You try to adjust your backend/server to support SDK token way


add retrycount to filtering criteria for dowhile task

This is a fix for issue #1655. Retries for the DO_WHILE task itself do not work if one of its loopOver tasks time out and the DO_WHILE fails. This fix only checks the condition of loopOver tasks that have the same retry count as the DO_WHILE task.

@manan164 Please help reviewing this pull request.

Pull Request Test Coverage Report for Build 4087

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 69.388%

Files with Coverage Reduction
New Missed Lines
%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
2
59.59%

contribs/src/main/java/com/netflix/conductor/contribs/queue/QueueManager.java
3
63.27%

Totals

Change from base Build 4079:
0.01%

Covered Lines:
11916

Relevant Lines:
17173

💛  - Coveralls

@rickfish Thank you for the contribution. Please add an integration test to cover this case.

This would be a difficult test case to add as it involves having one of the loopover SIMPLE tasks time out and then polling and completing that task only after it has timed out the first time in the first iteration. Do you think it is worth that? Since it is a bug fix, wouldn't the fact that it doesn't break the existing do-while test cases be enough?

@rickfish I am merging this PR for now. I am working on converting the DO_WHILE integration tests into scenario based tests and will add a test to cover this case (when a loopOver task is unsuccessful).

@apanicker-nflx thank you. If I wanted to attach the workflow/subworkflow metadata to this PR so you know the specific scenario I use to test this issue, how would I do that? I have tried to use the 'Attach files by dragging : dropping, selecting or pasting them' link but it always gives me an error.

Hi @rickfish,
I have tried your PR.
Do while's output is not showing proper output for each iteration. It is showing the output of the first iteration for every iteration.

@simarpal sorry, I just provided another PR (#1701 ) that should fix this issue.

Thanks @rickfish for quick response, it worked with PR (#1701 ).

I have one more issue (https://github.com/Netflix/conductor/issues/1696). Which is not related to your change. Let me know if you any additional info about it.

So that issue ( #1696 )is all about the UI, right? The DO_WHILE task is working as expected - just not being displayed on the UI, right?

Right, Do while is working as expected just not showing one of the looped tasks properly in UI.

@simarpal sorry, I don't know the UI and I actually don't know the do_while task except where I found issues and tried to fix them. You might want to create an issue that has 'Conductor UI' in the subject and maybe a UI guy can look into it.

Ok
Thanks @rickfish


Movies are Not Recommending by the site

Every thing is working fine but the site is not recommending movies i bought some movies and it shows on analytics page that i bought movies and the status are in cluster is showing NO
its capturing my moves but not recommending movies

Hi,
I'm happy everything is working, usually, that is not the case when people post issues :). Have you run the scripts in the builder folder as described in the book?

Sorry i couldn't run the scripts I'll try and let you know if its working
On Thu, May 7, 2020, 12:50 PM Binary Viking<EMAIL_ADDRESS>wrote:

Hi,
I'm happy everything is working, usually, that is not the case when people
post issues :). Have you run the scripts in the builder folder as described
in the book?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/practical-recommender-systems/moviegeek/issues/34#issuecomment-625091408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL2GTSZVNZIFGQAGRCTI5VDRQJR4JANCNFSM4M23NQ5Q
.

Sir i want another favour please:
I want to build a movie recommender which can only recommends movies on
plot description/overview based using word embeddings like if i give model
a movie name it will recommend the most similar movies based on thier
description how can i build this? Can you please sepcify the path
I tried the cosine way using aTFidf i want the same results with any lite
model can i do this with LDA but how many topics and parameters should i
choose? Because iam using a 27k movies dataset kindly reply must
On Fri, May 8, 2020, 1:02 AM Hassan Abbas<EMAIL_ADDRESS>wrote:

Sorry i couldn't run the scripts I'll try and let you know if its working
On Thu, May 7, 2020, 12:50 PM Binary Viking<EMAIL_ADDRESS>wrote:

Hi,
I'm happy everything is working, usually, that is not the case when
people post issues :). Have you run the scripts in the builder folder as
described in the book?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/practical-recommender-systems/moviegeek/issues/34#issuecomment-625091408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL2GTSZVNZIFGQAGRCTI5VDRQJR4JANCNFSM4M23NQ5Q
.

Dear sir,
This code is used in my book Practical Recommender Systems, I recommend reading ch 10 in my book, which is about content-based filtering.
The book can be bought here: manning.com

Ok sir thanks
On Sun, May 10, 2020, 7:52 PM Binary Viking<EMAIL_ADDRESS>wrote:

Closed #34
https://github.com/practical-recommender-systems/moviegeek/issues/34.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/practical-recommender-systems/moviegeek/issues/34#event-3320393451,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL2GTS3I4O6HKYXTUVGPDT3RQ25SVANCNFSM4M23NQ5Q
.


KeyError : 'vocab_size'

Reports keyerror when generate audio
Traceback (most recent call last):
File "/data/mfsshare/thirdpart_tools/bark-with-voice-clone/test/basic.py", line 6, in
preload_models(path="/data/mfsshare/models/bark/text.pt")
File "/root/miniconda3/envs/bark-with-voice-clone/lib/python3.9/site-packages/bark/generation.py", line 369, in preload_models
_ = load_model(
File "/root/miniconda3/envs/bark-with-voice-clone/lib/python3.9/site-packages/bark/generation.py", line 322, in load_model
model = _load_model_f(ckpt_path, device)
File "/root/miniconda3/envs/bark-with-voice-clone/lib/python3.9/site-packages/bark/generation.py", line 228, in _load_model
model_args["input_vocab_size"] = model_args["vocab_size"]
KeyError: 'vocab_size'
test python script
from bark import SAMPLE_RATE, generate_audio, preload_models
from scipy.io.wavfile import write as write_wav
#from IPython.display import Audio
download and load all models
preload_models(path="/data/mfsshare/models/bark")
generate audio from text
text_prompt = """
Hello, my name is Suno. And, uh - I like pizza. [laughs]
But I also have other interests such as playing tic tac toe.
"""
audio_array = generate_audio(text_prompt)
save audio to disk
write_wav("bark_generation.wav", SAMPLE_RATE, audio_array)

try to find text.pt on your hard drive and delete it. It may be a corrupt download.

I have confirmed the text.pt is correct, and it can run success on transformers usage, but report this err on suno usage

try to find text.pt on your hard drive and delete it. It may be a corrupt download.
I have confirmed the text.pt is correct, and it can run success on transformers usage, but report this err on suno usage


[SCT_EXTRACT_METRIC] CANNOT USE CUSTOM ATLAS ANYMORE (option -f)

In extract metric, clusters that are used to compute a prioris  are Hard Coded: (Lines 205-212)
    if not len(glob(path_label + 'WMtract*.*')) == 0:
        # MNI-Poly-AMU
        suffix_vertebral_labeling = '*_level.nii.gz'
        ml_clusters = '0:29,30,31'  # 3-class for robust maximum likelihood estimation: WM, GM and CSF
    else:
        # PAM50 and later
        suffix_vertebral_labeling = '*_levels.nii.gz'
        ml_clusters = '0:29,30:35,36'

With an custom atlas with fewer tracts for instance --> fail because cannot find tract 31 to 36.
Remove the temporary folder...
Traceback (most recent call last):
  File "/Users/taduv_admin/codes/spinalcordtoolbox/scripts/sct_extract_metric.py", line 1120, in <module>
    main(fname_data, path_label, method, slices_of_interest, vertebral_levels, fname_output, labels_user, overwrite, fname_normalizing_label, normalization_method, adv_param_user)
  File "/Users/taduv_admin/codes/spinalcordtoolbox/scripts/sct_extract_metric.py", line 331, in main
    indiv_labels_value, indiv_labels_std, indiv_labels_fract_vol = extract_metric(method, data, labels, indiv_labels_ids, ml_clusters, adv_param, normalizing_label, normalization_method)
  File "/Users/taduv_admin/codes/spinalcordtoolbox/scripts/sct_extract_metric.py", line 384, in extract_metric
    clustered_labels, matching_cluster_labels = get_clustered_labels(ml_clusters, labels, list_ids_LOI, combined_labels_id_group, verbose)
  File "/Users/taduv_admin/codes/spinalcordtoolbox/scripts/sct_extract_metric.py", line 1064, in get_clustered_labels
    clustered_labels[i_cluster] = np.sum(labels[clusters_all_labels[i_cluster]])
IndexError: index 31 is out of bounds for axis 1 with size 31

Solutions:

Use a kmeans clustering to find these clusters
indicate the clusters in info_label.txt

Indeed, the clusters used as a priori for the MAP estimation should not be hard-coded. They were used to be defined in the Params class of sct_extract_metric but with the arrival of the new template, they have been hard-coded to be adapted according to the template version.
In branch sl_extract_metric (commit e51c833), I have adapted the code to define the clusters in the info_label.txt file, that thus needs to be adapted. The organization of this file is open to discussion but for the moment it looks like:
# White matter atlas. Generated on: 01-Sep-2016
# ID, name, file
0, WM left fasciculus gracilis, PAM50_atlas_00.nii.gz
1, WM right fasciculus gracilis, PAM50_atlas_01.nii.gz
2, WM left fasciculus cuneatus, PAM50_atlas_02.nii.gz
3, WM right fasciculus cuneatus, PAM50_atlas_03.nii.gz
4, WM left lateral corticospinal tract, PAM50_atlas_04.nii.gz
5, WM right lateral corticospinal tract, PAM50_atlas_05.nii.gz
6, WM left ventral spinocerebellar tract, PAM50_atlas_06.nii.gz
7, WM right ventral spinocerebellar tract, PAM50_atlas_07.nii.gz
8, WM left rubrospinal tract, PAM50_atlas_08.nii.gz
9, WM right rubrospinal tract, PAM50_atlas_09.nii.gz
10, WM left lateral reticulospinal tract, PAM50_atlas_10.nii.gz
11, WM right lateral reticulospinal tract, PAM50_atlas_11.nii.gz
12, WM left spinal lemniscus (spinothalamic and spinoreticular tracts), PAM50_atlas_12.nii.gz
13, WM right spinal lemniscus (spinothalamic and spinoreticular tracts), PAM50_atlas_13.nii.gz
14, WM left spino-olivary tract, PAM50_atlas_14.nii.gz
15, WM right spino-olivary tract, PAM50_atlas_15.nii.gz
16, WM left ventrolateral reticulospinal tract, PAM50_atlas_16.nii.gz
17, WM right ventrolateral reticulospinal tract, PAM50_atlas_17.nii.gz
18, WM left lateral vestibulospinal tract, PAM50_atlas_18.nii.gz
19, WM right lateral vestibulospinal tract, PAM50_atlas_19.nii.gz
20, WM left ventral reticulospinal tract, PAM50_atlas_20.nii.gz
21, WM right ventral reticulospinal tract, PAM50_atlas_21.nii.gz
22, WM left ventral corticospinal tract, PAM50_atlas_22.nii.gz
23, WM right ventral corticospinal tract, PAM50_atlas_23.nii.gz
24, WM left tectospinal tract, PAM50_atlas_24.nii.gz
25, WM right tectospinal tract, PAM50_atlas_25.nii.gz
26, WM left medial reticulospinal tract, PAM50_atlas_26.nii.gz
27, WM right medial reticulospinal tract, PAM50_atlas_27.nii.gz
28, WM left medial longitudinal fasciculus, PAM50_atlas_28.nii.gz
29, WM right medial longitudinal fasciculus, PAM50_atlas_29.nii.gz
30, GM left dorsal horn, PAM50_atlas_30.nii.gz
31, GM right dorsal horn, PAM50_atlas_31.nii.gz
32, GM left intermediate zone, PAM50_atlas_32.nii.gz
33, GM right intermediate zone, PAM50_atlas_33.nii.gz
34, GM left ventral horn, PAM50_atlas_34.nii.gz
35, GM right ventral horn, PAM50_atlas_35.nii.gz
36, CSF contour, PAM50_atlas_36.nii.gz

# Combined labels
# ID, name, file
50, spinal cord, 0:35
51, white matter, 0:29
52, gray matter, 30:35
52, dorsal columns, 0:3
53, lateral funiculi, 4:13
54, ventral funiculi, 14:29

# Clusters used as a priori for the MAP estimation (for advanced users only)
# Name, file
white matter, 0:29
gray matter, 30:35
CSF, 36

The k-means clustering could be interesting to define the clusters in a completely "supervised" manner but I am not sure about the robustness of this method and we would need to assess it through simulations, which means a higher amount of work/time for an improvement that does not seem really significant...

fixed in PR #1040


Fix safe_action

Prior to this fix, calling safe_action would invoke the Sanitize method in Cinch::Helpers, which isn't accessible without first including Cinch::Helpers. Using sanitize in Cinch::Helpers fixes this issue.

@dominikh, could you review this? My IRC bot uses the safe_action function, and it would help if this PR was merged.

Hi, sorry for the delay. I'll try to look at the PR this week.

No problem. Thanks!

This looks completely safe to me. Pun intended.


Authentication support via OAuth2 for Gmail/Microsoft mail in addition to basic authentication

Any plans to do this in the near future?

It looks like we will no longer be able to send email via Gmail with this plugin starting on September 30, 2024, since sending email with this plugin requires having "Less Secure Apps" enabled.
https://workspaceupdates.googleblog.com/2023/09/winding-down-google-sync-and-less-secure-apps-support.html


IE issue with comparison checkboxes

It is throwing the following error in IE Object doesn't support property or method isNaN

I was using Number.isNaN() in one case.  Simply changed to isNaN()


feat(model): add .eager modifier to v-model

Add an .eager modifier to v-model that ignore composing value on the input and eagerly modify the value while the user is still composing a value. #9299 #9777
Since the default keyboard on Android, GBoard, does composing by default, I think it makes sense to have a modifier to disable the composing behaviour while still benefitting from using v-model

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Do you have a forecast of when it will be released? Thanks

Thanks for the PR, @posva! I hope that feature be approved soon.
Don't forget to put a note in the docs or new issues will be created mentioning this issue.  I guess that the site of Vue.js should have a section talking about known issues pointing to links so the users should read there first before create new issues if there's nothing created before (like stackoverflow does), it avoids duplicated topics.
@nolimtdev, I hope you read this PR. I think there's no better solution than that. Thank you for contribuition in #8231!

@lvfxbr One thing I do not understand... why some modifier should by used instead of fixing bug... Yes I call it bug, because I have tested old VUE 1 and v-model works well on android device during auto prediction... I mentioned it in #8231 but got no reaction. I noticed this bug a long time ago during migration from VUE 1 to VUE 2. Please test someone it in old VUE 1. So v-model can technically work on VUE 1 but can not on VUE 2 and VUE 3? Maybe Im missing something I did not read source code what is the difference.

@nolimitdev, I did a test in latest update of Vue 1 (1.0.28) from 2016. I created a repository to test this here, I tested in my smartphone and really, the v-model works fine: https://lvfxbr.github.io/vue-tests/ (I will move it to a code test site like codesandbox later and post here again). We need to find what changed from Vue 1 to Vue 2.

Hey guys, i've been wondering if this .eager feature is gonna come out? thank you

For those who are still waiting for the fix and don't want to replace v-model with an input event here's the solution to force .eager mode:
<input v-model="myModel" @input="$event.target.composing = false">

For those who are still waiting for the fix and don't want to replace v-model with an input event here's the solution to force .eager mode:
<input v-model="myModel" @input="$event.target.composing = false">

@posva did you please noticed @lvfxbr 's comment https://stackoverflow.com/questions/24398041/build-android-studio-app-via-command-line ? Thanks. It seems that no .eager is needed just to investigate how it is possible that VUE v1 did not have this bug but v2 and v3 has.

@posva did you please noticed @lvfxbr 's comment https://stackoverflow.com/questions/24398041/build-android-studio-app-via-command-line ? Thanks. It seems that no .eager is needed just to investigate how it is possible that VUE v1 did not have this bug but v2 and v3 has.

For those who are still waiting for the fix and don't want to replace v-model with an input event here's the solution to force .eager mode:
<input v-model="myModel" @input="$event.target.composing = false">

This worked for me using Nuxt 2.15!

For those who are still waiting for the fix and don't want to replace v-model with an input event here's the solution to force .eager mode:
<input v-model="myModel" @input="$event.target.composing = false">

This worked for me using Nuxt 2.15!

Worked like a charm

@yyx990803 would it possible for this PR to make it into 2.7?

It would appear that v-model is broken and does not work on mobiles when applied to non-component elements.
Either the documentation is wrong or the functionality is wrong.
 Complete with reports of this issue being prematurely closed. Meanwhile potential solutions are left to go stale.
This issue could be better handled.
It is not working as intended and reports of such are continually being obstructed


Data: project addition by Rohan mittal - image editor

Add a new project to the list
Add a new project to the list
@priyankarpal
I want to add a image editor in the list that will create a seamless ui experience for the users.
it will have variety of options including brightness, saturation, contrast, blur, sepia, rotaet(left,right),inversion,grayscale etc.
I have not seen a porject like this in your github repo.
#screenshorts

pls assign this issue under GSSOC'23 as its contributor to contributein your github repo
thank you.
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

@rohanmittal1163
We are not providing any labels for project additions as they are not associated with solving any issues.

It appears that this particular issue has not been resolved within the past few days. As it involves a simple pull request, we would like to kindly inform you that we will be closing this issue.
Thank you for your understanding.


Advance to "Support through associations in Ecto.assoc/2" commit.

Coverage remained the same at 84.507% when pulling a661c793498dfebc9b2f2b1a4b0f822e5387798b on through-assoc into 04acd3290bc3dc51c537931e7823b5052c679a52 on master.


OC-441 da and microgrids entities RtuDevice and Task

da and microgrids entities RtuDevice and Task were two entities for the same database table. Refactor to one class in core

All is well.

SonarQube analysis reported 2 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AdHocManagementService.java#L76: Method has 7 parameters, which is greater than 6 authorized.
 AdHocManagementService.java#L134: Method has 7 parameters, which is greater than 6 authorized.

All is well.


Tests for user creation

This test fails with
test test_create_users ... FAILED

failures:

---- test_create_users stdout ----
thread 'test_create_users' panicked at 'Failed in step `up`: Could not setup user admin-f72e06fe-3d41-4be4-9189-89e635df0e3d

Caused by:
    0: error sending request for url (http://localhost:9999/_synapse/admin/v1/register): connection closed before message completed
    1: connection closed before message completed', tests/simple.rs:62:6

This has landed in another form  a while ago.


GUI version

1st! i love your tool, it's great and don't know why MiK use that great way by themselfs.
So you said if someone is intertrested in a GUI, he should write a issu. So i do it here. A lot of my DJ Friends like to use it to but never used console stuff - so they would happy to have an GUI version. THXAL

Thanks! If anyone else sees this, please show your support for this feature by giving a 👍🏻 to @Dragotex's comment.

👍🏻

👍

+1


Testplan for #10281

We need to test the /healthz and /readyz of every service mentioned in #10281 for functionality (e2e). Therefore we need additional tests in our PHP-Suite.
IMHO there is no need to test them in k8s or k3s. It should be sufficient to check the output of the two endpoints with their conditions being met or unmet.
refs #8783

we have two ways(or more) how to check health of the service
service nats example:
curl http://<IP_ADDRESS>:9234/healthz - 200
and using CLI ocis/bin/ocis nats health - doesn't work (`ocis/bin/ocis nats version - also doesn't work)
in addition to checking the endpoinds we can check CLI using cliCommand suite. @dragonchaser should we fix cli health command for all services?

[ ]  during test stop the nats server and start again, check for /healthz and /readyz

Currently, there isn't any command to stop the nats server. Starting ocis with OCIS_EXCLUDE_RUN_SERVICES=nats and running nats separately with ocis/bin/ocis nats server doesn't seem feasible in CI. Trying the pid for nats and kill pid will crash the ocis.

Need to wait for https://github.com/owncloud/ocis/issues/10715 to be completed which will cover stopping and starting single ocis service. So, moving this to blocked for now.


DOMException when replacing PDF with images

This exception occurs for the following steps:

Load a PDF into the viewer. Viewer can show PDF successfully.
Click a button and load an image into the viewer. Viewer failed, and console shows the following exception:
DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Another scenario where both PDF and image are loaded into the same viewer also has this exception.
<app-image-viewer [images]="[base64doc, base64image]"
[idContainer]="'idOnHTML'"
[loadOnInit]="true">
The image is stored as base64.

You can check #24, there's an example of this use case :)

I'll be closing for now, reopen if it does not work for you


Add command timeline-tag to search for statuses matching the tag.

Since search only return the list of tags matching the search, this is helpful to actually see the statuses for a particular tag.

Thank you


[$500] Inconsistency bug - Assign Task - Task description does not remove empty quotes (works fine in private notes)

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open task report or assign any user task and open the report
Open description
Enter text with multiple empty quotes eg:

Hello

Save the description and observe that description displays only one quote with text on task page (which is correct)
Again open description and observe that extra greater then signs are not removed
Paste similar text in composer, send and edit and observe that extra greater then signs are removed
Similarly try the text in private notes of any user and observe that private notes too removes the extra signs

Expected Result:
App should remove greater then signs with no text after it when description is saved like we do throughout the app
Actual Result:
App does remove greater then signs with no text after it when description is saved in task
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.74-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/e4746bb4-5982-493c-ae8b-8d2ff5248307
https://github.com/Expensify/App/assets/115492554/055e5086-998b-42b7-883b-579e0cbd5a9b
https://github.com/Expensify/App/assets/115492554/c9a8b7d8-49dd-42dc-8ba0-b1cb402f0626
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695746974925629
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cbe475b72eea075d
Upwork Job ID:<PHONE_NUMBER>774612992
Last Price Increase: 2023-09-27

Proposal
Please re-state the problem that we are trying to solve in this issue.
App should remove greater then signs with no text after it when description is saved like we do throughout the app
What is the root cause of that problem?
We are trimming the description while saving the private notes here.
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/PrivateNotes/PrivateNotesEditPage.js#L88-L95
What changes do you think we should make in order to solve the problem?
We can directly save the privateNotes as we are saving description throughout the app.
   const savePrivateNote = () => {
        Report.updatePrivateNotes(report.reportID, route.params.accountID, privateNote);
        Keyboard.dismiss();

        // Take user back to the PrivateNotesView page
        Navigation.goBack(ROUTES.HOME);
    };

What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
In task description data is not trimmed
What is the root cause of that problem?
While saving task description we are not trimming the description here.
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/TaskDescriptionPage.js#L46-L53
and
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/NewTaskDescriptionPage.js#L64-L67
What changes do you think we should make in order to solve the problem?
We need to trim the data before saving like this in TaskDescriptionPage
  const submit = useCallback(
        (values) => {
            // Set the description of the report in the store and then call Task.editTaskReport
            // to update the description of the report on the server
             const editedDescription = parser.replace( values.description.trim());
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: editedDescription});
        },
        [props],
    );

and  in NewTaskDescriptionPage
   const onSubmit = (values) => {
        const editedDescription = parser.replace( values.description.trim());
        Task.setDescriptionValue(editedDescription);
        Navigation.goBack(ROUTES.NEW_TASK);
    };

What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency bug - Assign Task - Task description does not remove empty quotes
What is the root cause of that problem?
Because we save origin description (user input).
Ex. > Test \n >
We need to update this to > Test before we save using ExpensiMark
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/TaskDescriptionPage.js#L46-L53
and
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/NewTaskDescriptionPage.js#L64-L67
What changes do you think we should make in order to solve the problem?
For TaskDescriptionPage, we need save updatedDescription instead of values.description.
            const parser = new ExpensiMark();
            const editedDescription = parser.replace(values.description.trim());
            const updatedDescription = parser.htmlToMarkdown(editedDescription);
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: updatedDescription});

For NewTaskDescriptionPage, we need save updatedDescription instead of values.taskDescription.
            const parser = new ExpensiMark();
            const editedDescription = parser.replace(values.taskDescription.trim());
            const updatedDescription = parser.htmlToMarkdown(editedDescription);
            Task.setDescriptionValue(updatedDescription);
            Navigation.goBack(ROUTES.NEW_TASK);

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Description text is saving just as plain text, while it can be displayed as markdown.
What is the root cause of that problem?
There are 3 steps where it happens:

When user starts create task

https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/NewTaskDetailsPage.js#L64-L70

On the second step of creating

https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/TaskDescriptionPage.js#L46-L53

When user edits task description

https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/TaskDescriptionPage.js#L45-L54
What changes do you think we should make in order to solve the problem?
We have to parse description field on each of these fields via ExpensiMark:

function onSubmit(values) {
        const parser = new ExpensiMark();
        const markdownDescription = parser.htmlToMarkdown(parser.replace(values.taskDescription.trim()))
        Task.setDetailsValue(values.taskTitle, markdownDescription);
        Navigation.navigate(ROUTES.NEW_TASK);
    }

const onSubmit = (values) => {
        const parser = new ExpensiMark();
        const markdownDescription = parser.htmlToMarkdown(parser.replace(values.taskDescription.trim()))
        Task.setDescriptionValue(markdownDescription);
        Navigation.goBack(ROUTES.NEW_TASK);
    };

    const submit = useCallback(
        (values) => {
            const parser = new ExpensiMark();
            const markdownDescription = parser.htmlToMarkdown(parser.replace(values.description.trim()))
            // Set the description of the report in the store and then call Task.editTaskReport
            // to update the description of the report on the server
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: markdownDescription});
        },
        [props],
    );

Last thing to take into account is state of NewTaskDetailsPage.js const [taskDescription, setTaskDescription] = useState(props.task.description || '');, because there is an option to go back to this screen and then user will be able to see old state with empty quotes. In order to fix it we should update state on focus, currently it's syncing in useEffect
https://github.com/Expensify/App/blob/f596e350faf8a914f053f1b5abeb469b00b17af1/src/pages/tasks/NewTaskDetailsPage.js#L44-L48
    useEffect(() => {
        setTaskTitle(props.task.title);
    }, [props.task]);

    useFocusEffect(useCallback(() => {
        setTaskDescription(props.task.description || '');
    }, [props.task.description]))

https://github.com/Expensify/App/assets/26321483/534657eb-2049-4691-8018-3358f97694e1
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~013589ef6319817fdf

Proposal
Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug: Task description does not remove empty quotes (works fine in private notes)

What is the root cause of that problem?

Currently, with the description field, we are saving the input text directly: https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/tasks/NewTaskDescriptionPage.js#L64-L67

But for other logic like private notes, we will convert the user`s input to HTML and then save:
https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/PrivateNotes/PrivateNotesEditPage.js#L89-L96

There is no issue when we display these to content (description or private notes).

But when editing, with the description, it uses the description that has been saved before as a default value. So if the user types:

> Hello
>
>

when creating a task, it still displays this text in the editing input, which lead to the bug.

As I mentioned above, private notes save the HTML content, and when editing, it will convert this HTML content to raw text content, so it will set the default value as "> Hello", the remaining sections are removed.
https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/PrivateNotes/PrivateNotesEditPage.js#L66

What changes do you think we should make in order to solve the problem?

We can handle the logic that saves the description as we did with private note: Convert the user input to html and then saves it. When editing, convert the saved html to raw text html and set as the default value:
Firstly, update the onSubmit function:
https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/tasks/NewTaskDescriptionPage.js#L64-L67
to

    const onSubmit = (values) => {
        const parser = new ExpensiMark();
        const parsedTaskDescription = parser.replace(values.taskDescription);
        Task.setDescriptionValue(parsedTaskDescription);
        Navigation.goBack(ROUTES.NEW_TASK);
    };

Secondly, add to
https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/tasks/NewTaskPage.js#L172-L180 to display description properly
Then update https://github.com/Expensify/App/blob/bfda42deb3180835877c8b650188a5acf8c4dbc9/src/pages/tasks/NewTaskDescriptionPage.js#L94
to  defaultValue={parser.htmlToMarkdown(props.task.description)}

What alternative solutions did you explore? (Optional)

NA

Result
Screencast from 28-09-2023 20:04:02.webm

Reproduced. @robertKozik can you take a look at these proposals?

Hi all! Thank you for your proposals! I think we should go with the @DylanDylann proposal as it represents the most complete solution to unify the behaviour with the private notes approach. Other proposals are trying to parse both ways the description, which is in my opinion redundant and resource-consuming operation while saving the value.
Selected Proposal: https://github.com/Expensify/App/issues/28342#issuecomment-1739127073
🎀 👀 🎀 C+ reviewed

I don't understand the bug, to me the current behavior is correct. Yes, it is not the same as in other places, but that's not a bug on itself. Are the users prevented from doing an action? Is something actually broken?
I think we should close this. @garrettmknight what are your thoughts here for accepting this as a bug?

@iwiznia I think this logic should be the same throughout the app so users are not confused. Additionally, if the logic is the same, we can create the util function to display, save, ... this type of input content and reuse it in the future

I'd agree that this is a clear inconsistency in how the two text areas work and without any reasoning for one to work differently (i.e. why is the text area in a task not removing erroneous pieces when the text composer?). It's a question of standardizing where the behavior should be the same, not whether the app is broken outright.

@garrettmknight Currently, these are a few components that will remove all the redundant ">":

Message composer
Private notes

ok, assigned then

@garrettmknight Currently, we are having an issue related to the description in android native: It displays as
> Hell
>
>

rather than the proper HTML format
So should we create a separate issue?

Interesting - so Android isn't handling markdown. Is that a different way to describe the issue?

@garrettmknight

Android isn't handling markdown

I don't think so. We still can do as we did with the private notes, but it led to the other bug here https://github.com/Expensify/App/pull/29144#issuecomment-1756104373

So I think we should create another issue to fix the issue "Android isn't handling markdown"

@garrettmknight please help confirm this one when you have a change. Many thanks

@garrettmknight friendly BUMP - please help confirm this one https://github.com/Expensify/App/issues/28342#issuecomment-1758665987

Sorry for the wait - If "Android isn't handling markdown" is the actual root cause, why don't we fix that and that will fix all these issues?

@garrettmknight  No. "Android isn't handling markdown" is another bug, that we have encountered in staging. The issue https://github.com/Expensify/App/issues/28342 is just: "Task description does not remove empty quotes" and has the difference root cause that I mentioned in my proposal

"Android isn't handling markdown" is related to the MenuItemWithTopDescription component, "Task description does not remove empty quotes" is related to TextInput component

Got it - feel free to propose the other bug in #expensify-bugs for Applause to vet - let's stick to the focus of this bug here.

@garrettmknight We need to confirm:

In my original proposal, I let BE store the HTML, not mark down like the private notes logic.
But when implementing the PR, I found out that if we let BE store the HTML, for example,
<blockscope>Hello
 123</blockscope>, it just stores as "Hello123".
So my current implementation is: when submitting the description to BE, I keep using the original logic (let BE save the mark down string) rather than convert mark down to HTML.
But @iwiznia thing that we need an additional fix from the BE side to store description as the html like others logic (for example, private note)
So what do you think? (Should we follow my current implementation  or request an additional fix from the BE side? )

Just catching up here - for consistency, I think we should aim to store these all the same (similar to private notes) and that sounds like it's going to require a BE change. @iwiznia do you agree?

Yeah

I think do not need to update my proposal, just need to hold this issue until the BE side fixes the issue

I think your proposal would not be needed at all if we change the backend, no?

No. We still need the FE change because as I mentioned in my proposal

Currently, with the description field, we are saving the input text directly

@garrettmknight should we mark this issue as HOLD for BE change?

@iwiznia are you going to complete the backend change?

Ah yeah, I ned to change that, need to look where it is exactly that I need to update it...
@DylanDylann can you confirm what API commands need updating? Is it CreateTask and EditTask?
But also, I am looking at the backend code and the UpdateReportPrivateNote API command is doing nothing with the passed note, same as CreateTask and EditTask....

@iwiznia Before, I found out that if we let BE store the HTML, for example,
<blockscope>Hello
 123</blockscope>, it just stores as "Hello123".
Will re-check it today if it still appear

@iwiznia I just checked and the issue still appear:

When calling UpdateReportPrivateNote, sending
Hello
 will return
Hello
 by BE (expected)
When calling EditTask, sending
Hello
 will return Hello by BE (unexpected)

Sorry if I am being dense, but I am totally confused.
I am trying to save
Hello
 there but I am getting an error:

@iwiznia yeah. It is our expected

@iwiznia

In my original proposal, I will let BE store the HTML, not mark down like the private notes logic.
But I found out that if we let BE store the HTML, for example,
<blockscope>Hello
 123</blockscope>, it just stores as "Hello123".

Ahhhh, ok, can you push that out so I can test the backend changes with it... I am quite confused because I am not seeing anything in the code that would remove/change html.

ok, I think I found why it is being removed... will need to do some tests on monday.
@DylanDylann how would we deploy this? If I deploy my change will things be broken till you deploy yours?

@iwiznia I am thinking about it. If you deploy your BE change the current app will be broken till I deploy FE change. Do you have any suggestions for this one @garrettmknight ?

@iwiznia Did you checke this https://github.com/Expensify/App/issues/28342#issuecomment-1792901470?

That links to my own comment.
We need to figure out a way of deploying this without breaking it while one PR is deployed but not the other...

@garrettmknight do you have any suggestion for this one? https://github.com/Expensify/App/issues/28342#issuecomment-1806421725

@iwiznia I think he was referring to this part of your comment:

ok, I think I found why it is being removed... will need to do some tests on monday.

@iwiznia Based on the discussion in slack channel, should we consider using my suggestion before? https://github.com/Expensify/App/pull/29144#issuecomment-1754417578

Huh? If we deploy your change before the backend change is deployed, things will also be broken, no?

No. I mean that we do not need the BE change

@iwiznia Yeah, C+ has reviewed and approved this solution before

Ah ok, if it does all that, then let's do it

@iwiznia yeah. I will update the PR and ping you review it

@robertKozik can you complete the checklist when you get a chance?


Remote buttons - Play/Pause and Back not working

Not sure if this is already known and something you might be working on, but thought I should mention it in case it is not known.
I think overall the remote works terrifically well, and quite responsive. The only short coming I wanted to bring to your attention is Play/Pause and Back button not working.

Thanks for the feedback. The problem with the play/pause button is, that there is not a single key for that but only the two separate keys play and pause. I already thought about an internal state logic that assumes playing initially and then toggles between these states but the logic would fail when the real remote play / pause buttons would be pressed.
The problem with the back button actually is something I didn't knew since it works for my devices. The back button is currently mapped to the return key but this might not be the optimal key for all models. I might add an option to customize each remote button.

Thanks for a prompt response Martin. I noticed the same thing. I think your logic would work, because button will only fail the first time, once it starts alternating between play and pause it will sync itself. We can possibly simplify it as well, by just alternating between play and pause with each key press. That should give us what we need.
Maybe I add another option. What I see, is that my play button on TV remote is able to both play and pause. Maybe we can try just mapping play to play/pause button, and see if that has any success.
And yes, back mapping to return doesn't work. As we need to map exit to back, but when I went through the key list, I didn't notice the exit key published by Samsung. Maybe they are calling it something else?

I tested the thing with pressing the play button multiple times to toggle play / pause and it worked when I e.g. controlled an apple tv over hdmi cec but not when I played something directly from a NAS for example. Therefore the switching approach might be the saver one. I also didn't find any key that sounds like the exit key we are looking for unfortunately.

You are right. I haven't used the internal apps in such a long time, I totally forgot about them. All good, switching approach sounds good then. Let me know when you are able to implement and I can test it out.
I will go through the list again to see if there is something else we can use instead of exit.

Sounds good... I'm working on it and let you know when it's ready to test.

Hi Martin, not sure if you got a chance to look into this one. As for the logic I was thinking about keeping it simple.
What do you think?
if flag==0 or flag==NULL
{
 sendKeyPress 'Play'
 flag=1
}

if  flag==1
{
 sendKeyPress 'Pause'
 flag=0
}

Not yet. But implementation will be pretty much as you suggested. I will just add some more logic that resets the flag when the tv is detected as being turned off.

Makes sense. Reset it to '0' when TV is detected as off, or turned off.

Hey @mmende any luck on the play/pause implementation?
I found something  that could help us with the back button. So even though it is not widely published, KEY_EXIT does exist. Can you try mapping it to the back button, and see if it works?


Use best practices for SQL queries

From the psycopg2 documenation:

Never, never, NEVER use Python string concatenation (+) or string parameters interpolation (%) to pass variables to a SQL query string. Not even at gunpoint.

Updates queries to use psycopg2.sql classes. The changes to build_database.py are probably not strictly necessary since that script doesn't take any untrusted inputs.
Updates tests to clean up after themselves and provide better logging.

It looks like all unsanitized calls were replaced properly. A stylistic comment is that these queries would be more clear if you stick to using f-strings rather than .format

It looks like all unsanitized calls were replaced properly. A stylistic comment is that these queries would be more clear if you stick to using f-strings rather than .format

Note that the .format call is happening on the SQL object and not the string---I was confused by this at first as well. It means we can't use f-strings...

It looks like all unsanitized calls were replaced properly. A stylistic comment is that these queries would be more clear if you stick to using f-strings rather than .format

Note that the .format call is happening on the SQL object and not the string---I was confused by this at first as well. It means we can't use f-strings...

So it is! I noticed that and immediately forgot it before writing my comment.


Client Allocation Request for: Klinelex

Client Allocation Questions
Core Information

Name: Klinelex
Website / Social Media: https://kcharger.net/
Region: Asia excl. Greater China
DataCap Requested: 15TiB
Addresses to be Notarized: f3ubwsfcjydejzkuukx6wslfp7x7w6xgz2tdjn3ccvmvzz736onji6uyr32jhhebea4rmfqnb2mnvcwgigmxrq
Notary Requested: rayshitou

@Klinelec Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

@Klinelec Sorry. We don't have enough DataCap left as you need. I will colse this issue. Welcome back if we have been granted new DataCap.


Use triangle player trigger shape on fire action

Triangle points, while circle doesn't

Resolved by #24─c4dd979


Bump Kotlin and AGP versions

Maybe better not do it like this in a public repo?

Maybe better not do it like this in a public repo?

Improved


Login

HI,
Is there another option for login, i am having difficulty being able to login once the download is complete

Hi, I'd be happy to help you fix this if you can give more information.
I assume you have run the installation script. Have you opened a browser and accessed "localhost" ?

HI Sam,
Apologies on the late reply,
A colleague of mine let me borrow a spare PC and was able to install ubuntu
22.4 again and was able to get it too work! So must have been an issue with
my Ubuntu download,
Thank you for your time and effort,
Kind regards,
D
On Thu, Apr 13, 2023 at 4:23 PM Sam Bannister @.***>
wrote:

Hi, I'd be happy to help you fix this if you can give more information.
I assume you have run the installation script. Have you opened a browser
and accessed "localhost" ?
—
Reply to this email directly, view it on GitHub
https://github.com/DigitME2/oee_server/issues/21#issuecomment-1507164686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6DFTRJWSO7L7ELRBIRZNF3XBAK55ANCNFSM6AAAAAAWDRE22Q
.
You are receiving this because you authored the thread.Message ID:
@.***>


Resolve autoloaded constant deprecation warning

by requiring VersioningHelpers in initializer

The recommended way from the warning is to wrap the autoloaded constant in Rails.application.reloader.to_prepare — what's the case against?

@duncanjbrown no case against. I was going through a github thread and this solution had been suggested prior to using the to_prepare block. Updated now! :)


⚠ Bofrost.de has degraded performance

In 45b23f7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 917 ms

Resolved: Bofrost.de performance has improved in 035de1c.


Cleanup static loading and page hits

We need to do a bit of cleanup on static uw-frame

If you attempt to hit a child URL, say /settings, you get a 404
The static.html page is not imported, looking at index.html we still have the jsp:include. Doubt that is going to work on a static page :)

Maybe use superStatic instead: https://www.npmjs.com/package/superstatic


[build] fix ConfigureLocalWorkload target

After 580166e6 was merged, the ConfigureLocalWorkload target was no longer working as some of the structure of the sdk-manifests folder has changed.

We should run the DeleteExtractedWorkloadPacks target, as it will delete the sdk-manifests/workloadset folder.

Without doing this, the .NET SDK will always attempt to use the 34.99.0-preview.6.340 version in the "baseline" manifest.

We also should put a versioned folder after each manifest directory.

So, for example:
bin\Debug\lib\sdk-manifests\microsoft.net.sdk.android\ -> bin\Debug\lib\sdk-manifests\microsoft.net.sdk.android\35.0.0-preview.x.x\
bin\Debug\lib\sdk-manifests\android.deps.workload\ -> bin\Debug\lib\sdk-manifests\android.deps.workload\0.0.1\

Now with a fresh checkout:
dotnet msbuild -t:Prepare Xamarin.Android.sln
.\dotnet-local.cmd build Xamarin.Android.sln
.\dotnet-local.cmd build -t:ConfigureLocalWorkload build-tools\create-packs\Microsoft.Android.Sdk.proj

At this point, I can build app projects and the
BuildBasicApplication test passes locally.

Base build and smoke tests passed fine, merging since we have no tests that build any application with the local build.


OpenBMC Sprint 3 test procedure

We have finished Reboot BMC and Unit ID indicator code in this sprint.
I have pushed the latest code in https://openbmc-test.mybluemix.net/
Reboot BMC
Once you login (must follow the procedure mentioned here https://github.com/openbmc/openbmc-test-automation/issues/470), you can go Server control-> Reboot BMC in the navigation for rebooting BMC section.
Pressing the reboot button should gray out the screen and then once the boot command is sent, take you to the login page. Still, this is using Plam 303 so if you telnet to that, you can see the code running in the background etc.
We are still not sure what to display while the BMC itself is rebooting, the page will not be available then. But we are not ready to test that yet. We will be when the GUI code is in the main BMC repo. Patrick and I are working on that.
LED Indicator
This can be found under Server health-> Unit ID indicator section. It gets the current status and then turn it on (blinking/on) or off. We have tested this in the lab during out meeting. And recorded a video which can be found here-
https://ibm.box.com/s/9g1zdcs59nis61hlwsnggm95v5irrsb4
Sivas should have access.
Feel free to reach out to me if anything! -Iffy
Backlog for this Sprint
Checking the scenario when BMC reboot is performed while the code running on real BMC instead of Bluemix. Waiting on Patrick W to create a GUI brunch

@iftekharuli Seems the video has been removed ?
This shared file or folder link has been removed or is unavailable to you.

Think it’s a mistake? No worries: Just email the owner or get in touch with Box support. We’re here to help.

Like I mentioned, Sivas had access on that link only. I just added you as well.


unset zle_bracketed_paste when $TERM == "dumb" please

Description
zsh is not working with Emacs tramp
It is because of the bracketed paste thing, see https://emacs.stackexchange.com/questions/19848/weird-characters-in-shell-mode-with-zsh/19853
Would you please consider inserting
if [[ $TERM = dumb ]]; then
  unset zle_bracketed_paste
fi

somewhere in the config file?

Interesting find.
Out of curiosity, do you still see this issue if the environment module is disabled? I think a better fix might be to only enable bracketed paste mode if the terminal is not dumb, but I'm not sure that'll fix it.

Yes.
You can reproduce this behavior by
TERM=dumb ssh user@ip -t | xxd
# enter the password
# interactive shell but piped to xxd, enter "exit⏎".

You will see some [?2004h after the prompt. It is not visible unless by using xxd.

I've added some code to only enable bracketed paste if you're not in a dumb terminal. Might be worth doing the same thing for non-interactive terminals as well at some point.
Thanks for filing this!

I've added some code to only enable bracketed paste if you're not in a dumb terminal. Might be worth doing the same thing for non-interactive terminals as well at some point.

Just an FYI:
I noticed today that zstyleing color to yes as is done by default in zpreztorc causes zle_bracketed_paste to get set as a side effect, at least in 5.8. Setting color to no later in zprezto/init.zsh does not unset zle_bracketed_paste.
I tried guarding the zstyle at the beginning of zpreztorc but other modules set color with the result that zle_bracketed_paste gets set. I didn't track down which module(s) are doing this.
Instead, I took the approach of unsetting zle_bracketed_paste in zprezto/init.zsh where color is disabled based on TERM type.


Add rating scale to "survey.md"

Some edits to "survey.md" #91 .

@WuraolaOyewusi thanks for adding the updates. Merging the PR now.


The default keybindings in core, prevent the use of extended ascii characters.

Prerequisites

[ X ] Can you reproduce the problem in safe mode?

You can reproduce the issue all day long. I didn't try it in safe mode, because it's irrelevant. If safe mode uses the default keybindings, then it will be broken there too.

[ X ] Are you running the latest version of Atom?

I am using the latest version. Version 1.7.3

[ X ] Did you perform a cursory search to see if your bug or enhancement is already reported?

Yes
Description
In an Atom document I should be able to enter extended ascii characters by holding down the alt key and typing the character's value. For instance ...
[alt] 0169 = ©
[alt] 0128 = €
[alt] 0140 = Œ
[alt] 0174 = ®
[alt] 0216 = Ø
etc... However, the default keymappings use [alt]  to switch between tabs, so when you have multiple documents open in multiple tabs, typing [alt] 0169 results in the editor switching to the first tab, then the sixth tab, then the ninth one (or the last one if you don't have nine open), then when you release the [alt] key, the desired character is inserted in the wrong document.
Steps to Reproduce

open the Atom editor with multiple documents in multiple tabs.
Choose a document to insert a Ø into.
hold the [alt] key down and type 0216 then release the [alt] key.

The tab selection will bounce around as you type the digits, then the character will most likely be inserted into the wrong document.
Expected behavior: [What you expected to happen]
I expect Atom to stay on the document I am Editing. Atom should respect default Windows keystrokes, and not implement breaking behavior.
Actual behavior: [What actually happened]
The tab selection bounces around as you type the digits, then the character will inserted into the wrong document.
Versions
Atom    : 1.7.4
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1
apm  1.9.2
npm  2.13.3
node 0.10.40
python
git 2.8.1.windows.1
visual studio

This is a duplicate of #6788 - feel free to subscribe there for updates.


TypeError on validatorAdapter when passing form schema generic to useForm

Describe the bug
When passing a schema to get typesafety on default values, theres a type error on validatorAdapter.
useForm<FormSchema, ReturnType<typeof zodValidator>> will fix it but seems like a problem if you decide to use a different validation lib down the road and you have these types everywhere.
And as far as I understand, if you're passing the form as a prop elsewhere to other components, you have to remember to pass the  ReturnType<typeof zodValidator> along as a generic to that type definition or else I think there will be type errors.
type FormSchema = {
  firstName: string;
  lastName: string;
};

export default function App() {
  const form = useForm<FormSchema>({
    defaultValues: {
      firstName: '',
      lastName: '',
    },
    onSubmit: async ({ value }) => {
      // Do something with form data
      console.log(value)
    },
    // Add a validator to support Zod usage in Form and Field
    validatorAdapter: zodValidator(), // ERROR
  })

Type '() => { validate({ value }: { value: unknown; }, fn: ZodType<any, ZodTypeDef, any>): ValidationError; validateAsync({ value }: { value: unknown; }, fn: ZodType<any, ZodTypeDef, any>): Promise<...>; }' is not assignable to type 'undefined'.(

Your minimal, reproducible example
https://stackblitz.com/edit/tanstack-form-s6898n?file=src/index.tsx&preset=node
Steps to reproduce
see repro
Expected behavior
should not need to pass the validator along
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
macos
TanStack Form adapter
react-form
TanStack Form version
0.26.1
TypeScript version
5.5
Additional context
No response

This is impossible to fix via TypeScript, as partial inferencing is not supported. Closing.

i'm also facing this error.

i'm also facing this error. The console in the browser says me: "TypeError: adapter is not a function"

Update @tanstack/zod-form-adapter to the latest version (0.29.2 or higher) and try with useForm<YourFormSchema, ZodValidator>.


✨ Support configuration file

Adds support for specifying options via a configuration file instead of command line arguments. Uses lilconfig and js-yaml under the hood.

Before
After
Diff

packed
4.4 kB
5.5 kB
+25%

unpacked
9.5 kB
12.6 kB
+33%

The increase in download size brings the package back to pre-bundling size.
Note: This includes increased README documentation size.
dist/main.js: 3.2kb
Improves pipeline tests with bash unofficial strict mode, which fixes potential for false positives. Removes -latest from OS variable in test matrix.
+semver:minor

Contributes to closing #26


Has DE been taken up at the EU level?

Check out the story about EU4Donut on DEAL’s platform doughnuteconomics.org


add additional options in the XSD_FMT_TYPE_FN

where we fix the omission of 'xsd:' at the start
XSD_FMT_TYPE_FN = {
"xsd:boolean": xsd_format_boolean,
"boolean": xsd_format_boolean,
"xsd:integer": xsd_format_integer,
"integer": xsd_format_integer,
...
}

fixed in 9b1450cad8a9bf85a86dc51fcd40ba0b808d23ed


Upgrade crc32cer (1.2.6) and snappyer (0.1.8)

sorry, this port_compiler thing is a huge mess.
solve one problem only to find another cropping up.

@zmstone What sort of issues are you having here? Not having this PR merged means consumers of this library cannot upgrade to OTP 23.

@zmstone What sort of issues are you having here? Not having this PR merged means consumers of this library cannot upgrade to OTP 23.

true. Prepare for OTP 23

Sorry, I overlooked this PR while being on a break. New kafka_protocol is published on hex.


Failed to create a module and a new app

Hi, I installed the latest (I believe) CLI version through:
pip3 install pynest-api

According to the README.md, to create a new app we should:
pynest generate appplication -n my_app_name

However, the appplication was wrongly typed. But, assuming that the correct is:
pynest generate application -n my_app_name

I received the following error:
Error: No such command 'generate'.

So, ok, then I ran:
pynest --help

And it threw me the following:
Usage: pynest [OPTIONS] COMMAND [ARGS]...

Options:
  --help  Show this message and exit.

Commands:
  create-nest-app  Create a new nest app.
  g                Generate boilerplate code.

Now, if I ran pynest create-nest-app it creates the following folder structure:
mbenencase@Pingo:~/projects/quick/api$ pynest create-nest-app
. None False
Generate file:  settings
Generate file:  main
Generate file:  app
Generate file:  README
Generate file:  requirements
Generate file:  __init__

Then, according to the README.md, it says to run the following to create a new resource:
pynest generate resource -n users

However, there's no generate in the CLI, only g. So ok, let's run pynest g module users
mbenencase@Pingo:~/projects/quick/pynest$ pynest g module users
Usage: pynest g module [OPTIONS]
Try 'pynest g module --help' for help.

Error: Got unexpected extra argument (users)

Ok, I tried also without users argument:
mbenencase@Pingo:~/projects/quick/pynest$ pynest g module
Traceback (most recent call last):
  File "/home/mbenencase/.local/bin/pynest", line 8, in <module>
    sys.exit(nest_cli())
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/cli/cli.py", line 70, in generate_modu
le
    create_nest_module(name=name)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/cli/click_handlers.py", line 65, in cr
eate_nest_module
    template = template_factory.get_template(
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/common/templates/templates_factory.py"
, line 22, in get_template
    return BlankTemplate(module_name=module_name)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/common/templates/blank_template.py", l
ine 9, in __init__
    super().__init__(module_name)
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/common/templates/base_template.py", li
ne 20, in __init__
    self.split_module_name, self.capitalized_module_name = get_module_strings(
  File "/home/mbenencase/.local/lib/python3.10/site-packages/nest/common/templates/base_template.py", li
ne 12, in get_module_strings
    split_module_name = module_name.split("_")
AttributeError: 'NoneType' object has no attribute 'split'

And basically I'm not sure what to do anymore 😅 .
System specs:

Python 3.10.12
Ubuntu 22.04
Processor arch: x86

Hi @mbenencase
Sorry that this was your experience with pynest. I believe that the issue is that you are using old version of pynest (even though it seems that you didn't specify any version when pip install so it should pull the latest.
Could you share with me the output of the command: pip list | grep pynest.
And also, if you are not working with venv, then maybe you download pynest in the past, and when you try to generate application it's still using the old version.

@ItayTheDar that was exactly the problem, I installed in other computer and it installed the most recent version. In my personal computer I have the version 0.1.2 :sweat_smile:


how did you create the banner?

.

The banner was created in Photoshop, but I made a free Figma template out of it that you and others may use: https://www.figma.com/community/file/937081422569421176


Remove moot version property from bower.json

Per bower/bower.json-spec@a325da3

Pushed as part of the 0.5.10 release, thanks.


Disallow mentions by default

As recently discussed in #rustbot-development.
Closes #26.

It seems that #18 makes this not work since there's no method called empty_parse() anymore.


More document on upgrading from bash script

Is your feature request related to a problem? Please describe.
By default, the bash script searches for *.gcno files and runs gcov on them, the new uploader doesn't, nor does it have an option for it, nor - as far as I can tell - is there any mention of the change anywhere.
When I tried to upgrade, all it told me was that no files were found to upload. Then I tried the github action, same thing. Then I tried adding a bunch of explicit file and directory paths, still no files. Switch back to bash, everything works fine. I eventually figured it out, but only after digging through the uploader's source code.
Describe the solution you'd like
An addition to the "Deprecated Uploader Migration Guide" bash uploader section that says something like:
The new uploader doesn't support converting *.gcno files to *.gov, so if you need this you will have to do it manually, with something like:
find . type f -name '*.gcno' -exec gcov -pb {} +
Describe alternatives you've considered
Adding the old behavior to the new uploader.
Additional context
None

@gknowles in v0.1.16 we have added support for running gcov.  If you run the uploader with --gcov as an argument it will now act like the bash uploader and generate coverage files from *.gcno files.


[P4] Update Firebase dependency to support EU and AP regions

Summary
Creating a Firebase Realtime Database in EU (Belgium) or AP (Singapore) results in a Firebase URL which does not end in firebaseio.com, which is required by our current Firebase dependency.
We should upgrade the firebase package to a version which supports these endpoints.

This may be the version we need: https://firebase.google.com/support/release-notes/js#version_7145_-_may_21_2020
We should probably avoid version 8.x (which switches to ES6 modules) and 9.x (which changes the package structure to a modular format, requiring code changes) for now.

Upgrading directly to 7.14.5 with no other changes produces an error:
Unhandled rejection [1]</App.getMinBrowserVersions/<@http://localhost:3000/duelyst.js:3491:28

And a warning:
It looks like you're using the development build of the Firebase JS SDK.
When deploying Firebase apps to production, it is advisable to only import
the individual SDK components you intend to use.

It seems version 7.x also requires code changes.


TypeError: object of type 'NoneType' has no len()

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): from pip (binary?)
TensorFlow version (use command below): 2.1
Python version: 3.7
CUDA/cuDNN version: no
GPU model and memory: no

Describe the current behavior and code to reproduce
I am running this code:
https://gist.github.com/cossio/dc761b2731b1428267b65333dbd3f321
to train an RBM by contrastive divergence. Briefly I am using the Keras sub-classing API and I view the multiple Monte Carlo samples as layers.
However it produces the following error:
TypeError: object of type 'NoneType' has no len()

Please find the full error message and stack-trace as a comment on the above gist link.

@cossio I ran your code with tf-nightly and everything worked well. I can see the deprecation warning as you mentioned. Other than deprecation warning, I cannot reproduce the error you mentioned. May be the error might have been resolved with recent tf-nightly.
Downloading data from https://storage.googleapis.com/tensorflow/tf-keras-datasets/mnist.npz
11493376/11490434 [==============================] - 0s 0us/step
Epoch 1/10
WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/math_ops.py:4291: setdiff1d (from tensorflow.python.ops.array_ops) is deprecated and will be removed after 2018-11-30.
Instructions for updating:
This op will be removed after the deprecation date. Please switch to tf.sets.difference().
6000/6000 [==============================] - 10s 2ms/step - loss: -13.3863
Epoch 2/10
6000/6000 [==============================] - 10s 2ms/step - loss: -8.2681
Epoch 3/10
6000/6000 [==============================] - 10s 2ms/step - loss: -5.7110
Epoch 4/10
6000/6000 [==============================] - 10s 2ms/step - loss: -4.1468
Epoch 5/10
6000/6000 [==============================] - 10s 2ms/step - loss: -3.1042
Epoch 6/10
6000/6000 [==============================] - 10s 2ms/step - loss: -2.4848
Epoch 7/10
6000/6000 [==============================] - 10s 2ms/step - loss: -1.8877
Epoch 8/10
6000/6000 [==============================] - 10s 2ms/step - loss: -1.5715
Epoch 9/10
6000/6000 [==============================] - 11s 2ms/step - loss: -1.2992
Epoch 10/10
6000/6000 [==============================] - 10s 2ms/step - loss: -1.0544
<tensorflow.python.keras.callbacks.History at 0x7f9baa2238d0>

Please close the issue if this was resolved for you. Thanks!

Great! Will this be available in the next minor version of tensorflow? When is it planned to be released? @jvishnuvardhan

@cossio This will be available in near future in TF2.2 stable version. Currently TF team released TF2.2.rc1 and in near future they may release TF2.2 stable version.
Please close the issue if this was resolved for you. Thanks!

@jvishnuvardhan Well I cannot test for now because I only use TF stable. I will test when 2.2 is released. Thanks!

I am closing this as this was resolved in tf-nightly and will be available in stable TF2.2 which will be release in near future (currently TF2.2rc3 released more than a week ago).
Please feel free to reopen if this persists in TF2.2 stable. Thanks!