Bobby

CurseForge link
https://www.curseforge.com/minecraft/mc-mods/bobby
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/bobby
Source/other link
https://github.com/Johni0702/bobby
Mod file size
770.05 KB
License
(any other license)
What it does
Bobby is a Minecraft mod which allows for render distances greater than the server's view-distance setting.
Why should it be in the modpack
I was having chunks just stop loading until I reload the world. This happened on multiple different modpacks & worlds. It turns out the culprit was Farsight. Even if Farsight wasn't loading any fake chunks it would still cause this problem.
Bobby has had a major update that removed all the stuttering & lag for me that it had before. I've been using it instead of Farsight now & haven't had a single problem. The performance is even improved over Farsight by a lot & Bobby has the benefit of remembering chunks without re exploring them which is a huge plus. Bobby also works in singleplayer & can be configured in the in game menu.
Hold That Chunk Fabulously Optimized 4.5.5 32 Render Distance V sync off

Farsight Fabulously Optimized 4.5.5 32 Render Distance V sync off

Bobby Fabulously Optimized 4.5.5 32 Render Distance V sync off

All mods & settings are 100% identical. I only swapped Farsight for Bobby.
Why shouldn't it be in the modpack
Worlds can have mixed chunks on minigame servers. I am currently testing some solutions to see if this can be solved.
Additional details
I suggest setting the singleplayer server view distance to 12 max so players can benefit from extra performance if they exceed 12 view distance in singleplayer.

Duplicate of #46

Actually, let's have a fresh one.

Actually, let's have a fresh one. Have you tested Bobby against Hold That Chunk? Do that and let me know.

I do, Bobby is even wore than farsight and hold that chunk because it doesn't recognize correctly world change from minigames servers and you end up with mixed world
(by example go in hypixel skyblock in the hub, explore it then come back to your Island and see that far chunks are actually the hub chunks)

Farsight doesn't have the mixed world issue because it doesn't remember chunks at all when world changing. So it is a choice between remembering no chunks when world changing or the wrong chunks when it comes to Bobby. Personally I prefer the mixed chunks as either way you have to re explore the chunks to get them back/correct them & I think the additional benefits from Bobby are worth it. Setting your render distance to the server value will fix the mixed chunks by removing the need for fake chunks, essentially disabling the mod.
I also added results for Hold That Chunk.

Farsight doesn't have the mixed world issue because it doesn't remember chunks at all when world changing. So it is a choice between remembering no chunks when world changing or the wrong chunks when it comes to Bobby. Personally I prefer the mixed chunks as either way you have to re explore the chunks to get them back/correct them & I think the additional benefits from Bobby are worth it. Setting your render distance to the server value will fix the mixed chunks by removing the need for fake chunks, essentially disabling the mod.
I also added results for Hold That Chunk.

Well if you mostly only play in one or 2 worlds it isn't a too big of a problem but if you play on minigames based servers or in lobby based ones it get really weird and would be seen as a very big issue for many people

Here's a couple reasons why I would lean on the side of not adding this:

Bobby vs Farsight was decided by a public vote, however that hasn't stopped us from testing #437.
The issue mentioned above - on minigames servers where proxies are used to generate new void worlds every time I can't imagine that solution being helpful
A theoretical performance loss by disabling huge caches. Those caches were mentioned as being a reason to not include it in #46, as taking up tons of storage space isn't ideal.

Bobby has been known for causing world loading corruption so it looks like the main spawn is loaded but outside of it causes it to generate fake chunks from other places; in this case, i see this as being not-so-great to implement even if people tell this otherwise.

If Bobby will be added, the world caching will be disabled by default.

I suggest the next alpha or beta FO release include Bobby for testing in the Modrinth version and then do a comparison with the two mods, just like we did with Bobby vs Farsight.

That may or may not be a great idea, given that Modrinth versions are now fully supported and Prism relies on Modrinth - which based on the Discord roles isn't an insignificant of our over 1.1k Discord users. Not to mention our number of Modrinth downloads skyrocketing since Prism support was added...

Incompatible with fabulously optimized now :(

Im trying to install bobby mod with this modpack and got this:

@lynrayy commented on Jan 13, 2023, 6:50 PM UTC:

Incompatible with fabulously optimized now :(
Originally posted by @lynrayy in https://github.com/Fabulously-Optimized/fabulously-optimized/issues/556#issuecomment-1382247387

It still work fine for me. Remember to disable/remove Hold that Chunk, as it conflict with it, due to achieving "similar" results.

There now is a patch for the multi-world issue, but the dev needs testers. More information here:
https://github.com/Johni0702/bobby/issues/72#issuecomment-1518831417

There now is a patch for the multi-world issue, but the dev needs testers. More information here:
https://github.com/Johni0702/bobby/issues/72#issuecomment-1518831417

I guess i'm temporarily switch from HTC to Bobby to see how it goes

Will not be included per https://github.com/Fabulously-Optimized/fabulously-optimized/issues/656#issuecomment-1720029606 .


re-exec errors when pulling images

[info] Pulling image our.docker.index/org/go:latest
[info] Pulling image our.docker.index/org/go:latest
[error] Error pulling our.docker.index/org/go:latest. Error pulling image (latest) from our.docker.index/org/go:latest, Untar re-exec error: exit status 1: output: unexpected EOF

@macb are you able to run docker pull our.docker.index/org/go:latest on the machine?

A restart seems to work to get it. At least it did one of the times.

I'm not sure if this is related:
https://github.com/docker/docker/issues/14792

Maybe. Are there timeouts associated with the pulls for builds?

there are no timeouts within Drone, but Drone pulls an image by invoking the /images/create?fromImage=foo Docker daemon endpoint. Docker takes over from there. So it is possible that Docker enforces a timeout.
it is possible to get more details by running docker events on the host machine. This will begin streaming a lot of everything happening in the Docker daemon. There also might be additional detail in /var/log/upstart/docker.log.
Also, which version of Docker are you running?


the reason for add_classification_head

Hi
I read the description here https://docs.adapterhub.ml/prediction_heads.html
I am not getting why adding add_classification_head is needed? could you give more details on why one needs to introduce it and how it works? thanks.

The add_classification_head() method is our implementation of adding a final task-specific prediction head on top of the last layer of the Transformer model, in this case a simple FF layer to map the final hidden state to one of n classes in a sequence classification problem. This is specific to our AutoModelWithHeads class to allow flexibly adding and switching between multiple prediction heads. Therefore, this is not needed in case you don't need this kind of final prediction head layer or provide your own.

thank you


Return error when connecting to brokers if client is closing

I've filed an issue regarding this commit, please refer to https://github.com/SOHU-Co/kafka-node/issues/1045. There is a race condition when broker is disconnecting and Kafka client sometimes still attempts to refreshBrokerMetadata when client is closing.

Another issue is in the type definitions, the type of key in ProduceRequest should optionally be string or Buffer, because in the case of using schema registry, a message's key or value could be serialized as buffer, so it could be Buffer type.


Full zoom out on spike amplitude view

A request on behalf of @rsnevers and I -- it would be nice to be able to fully zoom out of the spike amplitude view to see spikes from the full length of the recording. The zoom out button seems to max out at a point where a user can still scroll left to right through time, like so -

Yet it also seems like a user can edit the time range at the bottom to a falsely large upper limit, and force this fully zoomed out display -

@rsnevers does that align with your experience?
Wondering if there is any reason not to enable fully zooming out with the zoom-out button? If not, would be great to enable that. It can be helpful to see super slow timescale changes in spike amplitude that occur over the course of a few hours of a recording in this zoomed out view. Thanks in advance for your thoughts.

@acomrie. I think we can do this. Here are the considerations.
The reason for the limit is to avoid excessive queuing of tasks for computing data (it takes more tasks to retrieve a larger time interval). This is mainly relevant for the timeseries view (raw traces) - much more so than the spike amplitude view.
But the spike amplitude and timeseries views are synchronized. So it's difficult to have a separate limit for the two views. But I wonder if this can be achieved in a nice way. Here's what I propose:

The limit can be removed from the spike amplitude view, but still retained in the timeseries view.
If we are zooming in the timeseries view, the zoom-out is blocked beyond a certain point
If we are zooming in the spike amp view, the zoom-out is not blocked
If we are zoomed out past the limit of the timeseries view, the timeseries data are not computed, and we get a message to the effect of "cannot display data at this zoom level".

What do you think @acomrie, @rsnevers, @jsoules ?

That makes sense and sounds good. I especially like the idea to add a message to alert the user to the zoom limit.
Another idea would be to control whether the two views are timelocked by a toggle button like the one in the xcorr view that controls unit selection. Sortingview could alert the user that the two views (timeseries and spike amplitude) need to be unlocked to allow further zoom out of the spike amplitude view. That wouldn't have much added benefit over what you already proposed though, other than potentially allowing more views to simultaneously be open and displayed with independent time axes, and seems more difficult to implement. So, probably still makes sense to go with your suggestion!


Adding/deleting CapRover workers is not working.

Search first
Adding/deleting CapRover workers is not working.
Adding Worker

Deleting Worker
Screencast from 21-05-23 17:23:43.webm
Similar to threefoldtech/tfgrid-sdk-ts#281  & threefoldtech/tfgrid-sdk-ts#280

Still investigating..

Verified on devnet.
Adding/deleting caprover workers is working fine.
Adding
Screencast from 31-05-23 17:06:28.webm
Deleting
Screencast from 31-05-23 17:08:09.webm


Checking quotas

Checking user quotas (/data/user and /scratch/user), each user can use:
quota_report

What can we use to check users quotas?
For projects, anyone can use
function quota_project() {
  /usr/lpp/mmfs/bin/mmlsquota --block-size=auto -v -j $1 data
}

Actually maybe look here: https://github.com/uabrc/uabrc.github.io/issues/231


KeyError: "Didn't expect the random generation name 'WWII' to already be set (for example with text '')."

The rule "I don't like [world?WWII] war[II?WWII]." lead to the error.
It seems there is something wrong with Named random generation.

There is an issue indeed. I am checking that up as soon as possible.
Thanks for the heads up!

This is fixed on dev branch and will be released in the next version.
Thanks again for opening an issue :)


Feature request

I've tried to look for myself, but my coding skills are very slim. What would be the url I can use to reboot the device? I want to have an automation that can reboot it an do simple tasks if something happens. Can this be integrated into the app or would I need to automate it myself?

I can probably add a Tasker integration on Android to send a reboot command to the gateway, but I've been avoiding a feature like this since it requires the device sending the command to always be on the local network.

Doesn't have to be. You can use Tailscale and do it that way. That's how I'm able to monitor everything even looking at my cell stats remotely outside of my network. I know this is a stretch but it would be cool if later on I could have an integration with some monitoring software to auto reboot it if it starts to do some funky things. But, that is over my head currently.

Closing in favor of #56


On mobile devices, the fixed-price label overlaps the adjacent text

On mobile devices (e.g., my Nexus 5X), the green label containing the contract's fixed price overlaps the adjacent text.  The height of the label is different from the height of the adjacent textbox.

@mark-a-wilson fixed this on March 1.  I tested the issue and @mark-a-wilson pushed master branch to PROD (build #16).
This issue duplicated by issue #248.

Closing issue.


Is this tooltip support Html content??

Hello,
I want tool tip with HTML content.
Is this possible??
How to do this??

No, it is not possible.


DOC: Clarify ellipse semimajor/minor axes

This is to be more consistent with photutils. See https://photutils.readthedocs.io/en/stable/api/photutils.aperture.EllipticalAperture.html#photutils.aperture.EllipticalAperture
I had to code dive a little to find out, so we should add this to docstring.

I understand the confusion here, but I think the names semimajor and semiminor were deliberately left off here.  I think it was @astrofrog (?) who initially created these region classes, based from the photutils aperture classes.  There are no checks anywhere to ensure that width >= height, which would be needed to assume width = semimajor and height = semiminor.  Admittedly that's how I mentally think of them, but there's no restriction of having height be the semimajor axis (which implies a rotation of 90 deg).
I think it does make more sense to call these elliptical parameters as semimajor and semiminor axes (as photutils does).  But that decision was made before I started working on this package.  My best guess is that perhaps this was done to make the API more consistent with rectangles (width/height)?  Perhaps @astrofrog remembers?

Well, from the way you calculate stuff in the code, they correspond one-to-one with the way photutils defines semimajor/semiminor. 🤷

Yep, I know.  All of the low-level Cython code from photutils (that @astrofrog originally wrote) was copied to regions.

Closing since this a feature, not a bug.


How to use your pagination?

How can I use your pagination to my table?

There is example usage of pagination on the example page: http://krescruz.github.io/angular-materialize/#pagination
If you need further help, then this isn't the place. This isn't a tech-support forum, this is a place to discuss issues related to the library.


Don't dereference empty optional in ReportingETL constructor

An empty optional was being dereferenced in the ReportingETL constructor in certain configurations. Assign a value to it first so we can then dereference and assign a different value.

Merged as 5b085a75fd4f2a28804f15f6559a5ecd4d862d81


Alertmanager behaving unexpectedly-Issues looping between firing -> Resolved -> firing

What did you do?
Devops engineer at Samsung
What did you expect to see?
I have issue with alert manager + Prometheus. I want to get resolved notification , only when alert is really resolved
What did you see instead? Under which circumstances?
I see an expected behavior, initially I get firing alerts for all the alerts that exists. After 1 hour , again I get the notification for alerts resolved , but with the old values ( alerts are not really resolved)
Environment
Setup is running on Azure Kubernetes ( AKS)

System information:
insert output of uname -srm here

Alertmanager version:
insert output of alertmanager --version here
alertmanager, version 0.18.0 (branch: HEAD, revision: 1ace0f76b7101cccc149d7298022df36039858ca)
build user:       root@868685ed3ed0
build date:       20190708-14:31:49
go version:       go1.12.6

Prometheus version:
insert output of prometheus -version here (if relevant to the issue)

Alertmanager configuration file:

alertmanager.yml
/etc/config $ cat alertmanager.yml
global:
  slack_api_url: https://hooks.slack.com/services/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
receivers:
- name: alertnow
  slack_configs:
  - channel: '#stage_dict_app_events_and_alerts'
    send_resolved: true
    text: |-
      {{ range .Alerts }}
         *Alert:* {{ .Annotations.summary }} - `{{ .Labels.severity }}`
         *Description:* {{ .Annotations.description }}
         *Details:*
         {{ range .Labels.SortedPairs }} • *{{ .Name }}:* `{{ .Value }}`
         {{ end }}
        {{ end }}
    title: '[{{ .Status | toUpper }}{{ if eq .Status "firing" }}:{{ .Alerts.Firing
      | len }}{{ end }}] Cloud|Azure|Monitoring Event Notification'
  webhook_configs:
  - send_resolved: true
    url: https://alertnowitgr.sec-alertnow.com/integration/prometheus/v1/67a54ac114e9d111ea4860650ac112ba32eb
route:
  group_by:
  - alertname
  - locale
  group_interval: 5m
  group_wait: 2m
  receiver: alertnow
  repeat_interval: 12h

Prometheus configuration file:

insert configuration here (if relevant to the issue)

Logs:

Nothing related to issue coming up in logs

After 1 hour , again I get the notification for alerts resolved , but with the old values ( alerts are not really resolved)

I assume that some annotation template holds $value. By nature, a resolved alert doesn't have a value since resolved means that the PromQL expression returns no data.
I'm closing it for now. If you have further questions, please use our user mailing list, which you can also search.


Terra-List crashing IE11 while inside an embedded MFC CHtmlView

Issue Description
When interacting with a terra list control (expanding and collapsing using the carrot), a sporadic crash occurs from inside mshtml.dll, always ending in the CTreePos class, stemming from figuring out boundaries and performing hit tests.
Removing terra-list from a certain area of our app seems to have prevented crashing it. As soon as we added terra-list 1.2.0 back into the react view rendering it and clicking it to expand/collapse it several times, it crashed in mshtml.dll.
We are updating all our terra components now to see if the crash persists.
Issue Type

[ ] New Feature
[ ] Enhancement
[X] Bug
[ ] Other

Expected Behavior
IE11 should not crash.
Current Behavior
MSHTML.dll throws an unhandled exception, crashing the process it belongs to. In our case, a CHTMLView backed by IE11.
Steps to Reproduce

Login to Skybox (Internal Cerner VM) <IP_ADDRESS>, login to powerchart.exe, open the patient David Thower.
Navigate to PowerOrders, add a prescription to the scratchpad. Filled out details. To trigger Real Time Prescription Benefits.
Click Show More on an alternative that contains Coverage Alerts.
Start expanding and collapsing the coverage alerts, resizing the details pane, etc until a crash occurs.

We have a development branch of PowerOrders that can be checked out and compiled containing the Terra Component to reproduce it as well. Or just ping me (DJ021930).
Environment

Component Version:  Terra-list 1.2.0
Browser Name and Version: Confirmed crash on IE11 Update 11.0.47, 11.0.46, 11.0.26, with index.html forcing content="IE=10", http-equiv="X-UA-Compatible"
Operating System and version (desktop or mobile): Crashed on Windows 7x64, Windows 10x64

Sample Callstacks
https://gist.github.cerner.com/DJ021930/8e974b8b30514be7dd32a17e89525e20
https://gist.github.cerner.com/DJ021930/fedd5425b8bfcc94d2bb2ad25135ae7c
https://gist.github.cerner.com/DJ021930/02306a5eba481527798a819dc51f4d44
https://gist.github.cerner.com/DJ021930/fd7aa84352cc456062bbca9391ce107c

Hi @dajaffe, can you provide a reduced test case. We've found this to be helpful when debugging.

Initial tests with updating all the terra components we're using seem to have resolved it. We're going to test some more and see if the crash occurs again.
I'm not sure I can provide a slimmed down test scenario right now because of the tight deadline for this project. However we do have virtual machines with visual studio 2015 and the code we're running that causes this crash that we can provide to debug on.


Permalink localStorage support?

Hi
Permalink currently supports two methods for storing the state in the URL. These are in the query string (after the ?) and after the fragment identifier (#). These are great for web applications. An emerging standard for storing web applications on e.g. mobile phones and tablets is the Web App Manifest:
https://w3c.github.io/manifest/
which is already implemented in Android. This means that a web application can be "installed" on e.g. a mobile phone so that it looks more or less like an ordinary app.
The problem is that there is no support for storing state in the URL. But it is possible to store the state in localStorage instead. I therefore implemented support for this in a previous version of leaflet-plugins:
https://github.com/shramov/leaflet-plugins/compare/master...FCOO:master
My question is whether you would be interested in a pull request for the current version implementing this or you consider it outside the scope of your plugin? If you consider it outside the scope of your plugin we will probably just inherit your Permalink class and override the relevant methods so that we can easily update it.
A similar use case exists for iOS although Apple does not (yet) confirm to the Web App Manifest standard. For iOS you can also save the state in localStorage.

Hi @jblarsen and thanks for the proposal. Since the modification seems "small" feel free to send a pull request for that :)

@jblarsen any news about a pull request for that ?

Hi @brunob
I have made a pull request with the localStorage feature.
Best regards,
Jesper

Closing since #225 was merged.


Provider doesn't work with cockroachdb

When testing this out on my cockroach, I ran into the error:
  # module.database.atlas_schema.schema will be created
  + resource "atlas_schema" "schema" {
      + dev_db_url = (sensitive value)
      + hcl        = <<-EOT
            schema "public" {
            }

            <Tables et al elided for simplicity, but printed out here>
        EOT
      + id         = (known after apply)
      + url        = (sensitive value)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.database.atlas_schema.schema: Creating...
╷
│ Error: Drop schema named "crdb_internal": pq: cannot drop schema "crdb_internal"
│
│   with module.database.atlas_schema.schema,
│   on ../../modules/database/database.tf line 1, in resource "atlas_schema" "schema":
│    1: resource "atlas_schema" "schema" {
│
╵

This was against a test schema, so there was no risk from attempting to drop the schema crdb_internal, but it does freak me out that there was no diff output from the provider during the planning process.
I guess there are 2 issues in here:

Atlas probably shouldn't mess with the crdb_internal schema no matter what. Maybe the resource should have a way to specify a set of schemas that it should modify?
Is there a step I'm missing to get a printout of the about to be executed SQL? If this had printed out a DROP SCHEMA crdb_internal; I would not have told it to run. As it stands it kinds of freaks me out that the diff suggested by this run didn't imply that something so dangerous was happening.

Thanks for reporting this @achew22 🙏
This was actually fixed in Atlas and we should update its module. Tagging @hedwigz to address it.

Great! Sounds like we're already half-way there! Is there any way to have the provider print out the SQL that it is about to run? That would provide a lot of confidence before execution

@rotemtam and I just discussed it. I was surprised to see this as well. I'll make sure we add integration tests (in CI) for all the databases that are mentioned here.

Is there any way to have the provider print out the SQL that it is about to run? That would provide a lot of confidence before execution

Atlas does this and I think it's required here as well. However, I'm not sure Terraform exposes such capability. We'll do research on this and I'll update this issue soon. Thanks again for reporting this 🙏

Close, due to we already support this feature.


Support for adding environment variables from both values and secrets

Might need two separate options, something like --env 'NAME=VALUE' and --env-secret 'NAME=SECRET'. Maybe we could also have a shortcut for the 2nd case: --secret SECRET which would be equivalent to --env-secret SECRET=SECRET.

Hi @epwalsh, is this feature implemented yet? I recently came across this issue when using Wandb, it requires setting the environment variable WANDB_API_KEY for authorization (https://docs.wandb.ai/guides/track/advanced/environment-variables#optional-environment-variables)


When & unless helpers

These are two little helpers I often use to get rid of intermediary variable assignments.
Example:
$id = $model->getOriginal('related_id');
$related = $id ? Related::find($id) : null;

// becomes
$related = when($model->getOriginal('related_id'), function($value) {
    return Related::find($value)
});

// or using short syntax
$related = when($model->getOriginal('related_id'), fn($value) => Related::find($value));

The callback's value is returned if the provided value is truthy.
It has the same signature as other when() and unless() methods throughout the framework. So a default value can be specified (callable if you like):
$related = when($model->getOriginal('related_id'), function($value) {
    return Related::find($value)
}, 'something else');

$related = when($model->getOriginal('related_id'), function($value) {
    return Related::find($value)
}, function($value) {
    return Related::first();
});

already possible with transform()?
$id = $model->getOriginal('related_id');
$related = $id ? Related::find($id) : null;

// becomes
$related = transform($model->getOriginal('related_id'), function($value) {
    return Related::find($value)
});

// or using short syntax
$related = transform($model->getOriginal('related_id'), fn($value) => Related::find($value));

You're totally right. Can't believe I overlooked that one for so long. Thanks


Allow user to override range requirement

relates to #157
In development, I use devd, which does not support range requests, and have a small data set. It would be very useful for me to be able to disable the range support requirement while I'm in development; my production server supports them.
The inability to turn this off means if I want to use duckdb-wasm, I have to rewrite my whole development setup.

I understand your point. I was just not quite sure about the negative effects of a default fallback to non-ranged fetches.
The problem is, that duckdb-wasm runs in a web worker.
So if your user expects ranged reads and we would fallback to full reads for whatever reason, we might end up blocking duckdb database until the entire file is downloaded.
This is quite problematic especially for large files.

It is non-trivial to abort downloading such a file once we started. We can terminate the web worker but thats about it (without SharedArrayBuffers).
This will change as soon as DuckDB gets fully async I/O but that's not possible today.

We could add something like allowFullReads to the DuckDBConfig that defaults to false, for now.

that would be the ideal solution for me, if it doesn't make sense overall feel free to close this though

@llimllib Please try version 0.1.12-dev26.0 , it automatically falls back to full requests.
We only log a warning to the console for now.

Neat side effect:
The shell can now read files from servers that dont include range in the CORS header `Access-Control-Allow-Headers.

Can confirm it works, thank you very much!


Moving content from composer to use-cases

Description
Moved the examples from the Composer page to the Use-Cases section and arranged the remaining content on the Composer page to make it logically ordered
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@aliciakrebs I made all the changes you suggested but I cannot merge, can you please approve?


Can you rename the repository?

Rename angular-webpack2-starter to angular-webpack-starter. Because you usage webpack 3.0.
Github stores links to repository names, if people go to https://github.com/qdouble/angular-webpack2-starter, the Github will redirect to https://github.com/qdouble/angular-webpack-starter

Rename it into something that sounds like a brand. :)

okay, I've renamed it


Backup sollet.io wallet

Is it possible to export the private key of the wallet or to reveal the seed phrase?

Yes it is possible. You can export your private key for a given account via the Export button on the bottom right of your SOL account balance card.

Thanks for the answer @armaniferrante! Can I restore my existing wallet with this private key? When I select the restore existing wallet option I only have an option to enter the seed words, but I don't have that anymore.

@gulyasbence all wallets need to have a Mnemonic key. In addition to the mnemonic's accounts, you can import individual accounts with your private key directly, using the UI displayed above.


Add new free trade agreement

Add new free trade agreement - UK-Morocco Association Agreement

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.40%. Comparing base (6464d92) to head (83ebd02).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5458      +/-   ##
==========================================
- Coverage   96.41%   96.40%   -0.01%
==========================================
  Files         949      950       +1
  Lines       22462    22470       +8
  Branches     2018     2018
==========================================
+ Hits        21657    21663       +6
- Misses        657      658       +1
- Partials      148      149       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Signature of array accessor depends on whether the Belt module is open

This came as a bit of a surprise:
let x = [|1|];

/* Compiles - accessor returns int */
x[0] + 1;

open Belt;

/* Compile error - accessor returns option(int) */
x[0] + 1;

I am all for checked array access, too, and therefore actually prefer Belt's version. :wink: Still, this just caught me completely by surprise, as in most languages it would not be possible to override the [] operator in such a way.
But I guess this is just my lack of OCaml knowledge. 😕 It seems the [] array accessor is just sugar for Array.get, and that is overwritten by Belt.Array.get. Behavior is exactly the same in OCaml syntax (x.(0)). So I guess this is not something that will/can be changed in Reason.

Yup, that certainly can be surprising :) but yeah, we're unlikely to change that behavior. If you want to find a nice place to point it out in the docs, that would be great! https://github.com/reasonml/reasonml.github.io


How to add some products to cart?

My shop needs to add some products to cart. Look to screen:

I take screen from real working shop, which sales wholesale products, so there are some input fields under corresponding size label. At this moment I can add one product only. You can test on page http://мойопт.рф/shop/tops/testovyj-produkt
I placed two buttons. One of them is standart behavior (product-add2cart.html), which works very well. Second button is my trying - I cannot realize functionality of adding of some product. Unfortunatelly, I don't know how do it with angular. My tryings fails.
Could you help me?
And I think that django-shop needs more complex examples. I ready to add cloth example to django-shop as PR. Although I haven't cool programmer knowledge for it, but I want to help development of django-shop.

In this situation, you have to create your own AddToCartSerializer with 3 quantity fields.
Then in your router, you attach it to the view, for instance:
urlpatterns = [
    ...
    url(r'^(?P<slug>[\w-]+)/add-to-cart', AddToCartView.as_view(
        serializer_class=MyCustomAddToCartSerializer,
    )),
    ...
]

you also might need to create your own AngularJS directive, which is quite simple. Use the directive shopAddToCart from catalog.js as a blueprint.
btw. in one of my customers B2B projects, I added a Serializer, so that his customers can add products in the catalog's list view.

Thank you for fast answer! Using the own AddToCartSerializer is easy for me. Problem is angular..
I'd like to look to your implemention of Serializer for customers B2B projects!
And how about add test cloth model to django-shop? I'm not sure that I and other developers can use angular for realized shop's task correctly (maybe I mistake). For example, for selection by color I use workaround:
{% for obj in product.get_product_colors.all %}

    <input class="color_input" name="color_values" type="radio" value="{{ obj.color_id }}" ng-model="context.extra.color_id" ng-change="updateContext()" id="input_color_id_{{ obj.color_id }}">
{% endfor %}

And I hide <inputs>, but add styles for , so my color changed when I click to corresponding label. I think is bad code. I try to find more clean code, but cannot not find..
I think developers will find good points from this test example if we add cloth model to django-shop. If interesting I can discuss about it in email or another place (not here).

If you need a serializer which can handle variants, such as for colored cloth, have a look at the AddSmartphoneToCartSerializer. There the variant is the memory, though.

Yes, I use AddSmartphoneToCartSerializer as begin for me. And it works very well. But I don't know how write angular controller to handle a two or more products.
If I understand correctly I need change AddToCartCtrl and/or ModalInstanceCtrl in my own catalog.js?

you can name that file as you want, but you have to import it into the detail catalog page.
But presumably you don't even have to create your own AddToCart directive, because that directive sends the complete $scope.context to the REST-API-endpoint.
If you need more than one field, add another input field bound to that scope context. Look at the provided example:
<input class="form-control ng-pristine ng-untouched ng-valid ng-valid-min" type="number" min="1" ng-model="context.quantity" ng-model-options="{updateOn: 'default blur', debounce: {'default': 500, 'blur': 0}}" ng-change="updateContext()">

what's important here is the ng-model="context.quantity".

Thank you, Jacob! I try to apply your code. let this issue is open some times. As soon as I can good result I write here. I think it maybe useful for otehr devs.

Jacob, I finished my task! But my code looks like bad. I write own addToCart.function()
djangoShopModule.controller('AddToCartCtrl', ['$scope', '$http', '$window', '$modal',
                                      function($scope, $http, $window, $modal) {
	...

	var interval_ID;
	var interval_ID_2;

	$scope.addToCart = function(cart_url, extra_context, next_url) {
		var data = [];
		var count = 0;
		var added_products = 0;
		var $change_count = $('.size_c.active .change_count').filter(function () {
			return parseInt($(this).val() > 0) || $(this).val() != '';
        });
		$.each($change_count, function () {
			$scope.context.extra.size = $(this).parents('.col_wr').find('.size').text();
			$scope.context.quantity = parseInt($(this).val());
			var context_2 = angular.copy($scope.context);
			$http.post(updateUrl, context_2).success(function(context) {
				data.push(angular.copy(context));
				count++;
			});
        });

		interval_ID = setInterval(function () {
			if (count == $change_count.length) {
				for (var i = 0, l = $change_count.length; i < l; i++){
					$http.post(cart_url, data[i]).success(function () {
						added_products++;
					});
				}

				clearInterval(interval_ID);
            }
        }, 200);

		interval_ID_2 = setInterval(function () {
			if (added_products == $change_count.length) {
				$window.location.href = next_url;
				clearInterval(interval_ID_2);
            }
        }, 300);
	};

}]);

html:
{% for obj in product.get_product_colors.all %}

            {% for size in obj.sizes.all %}

                    {{ size.value }}
                    <input id="change_count_{{ size.id }}" class="change_count" max="{{ size.quantity }}" min="0" type="number">

            {% endfor %}

{% endfor %}

It works. Now I can add a few products (see http://мойопт.рф/shop/tops/testovyj-produkt ).
If you have free time, you can look this code. Or close this issue now.
Thanks for help!

Why did you create your own addToCartCtrl and did not add ng-model="context...." to the input fields inside the built-in shop-add-to-cart directive?

Oh, I'm sorry.. I must been to tell about my solution (workaround) more.
I do so, because I need add two or more products for one time. By other words, I must send set of products to Cart Serializer. But as I understand I can send only one product. So I use loop to send many products (their quantity is count of input quantity field). I try to use ng-model="context...." but I get wrong behavior - all quantity filed is updated together:

then I use:
$.each($change_count, function () {
			$scope.context.extra.size = $(this).parents('.col_wr').find('.size').text();
			$scope.context.quantity = parseInt($(this).val());
			var context_2 = angular.copy($scope.context);
			$http.post(updateUrl, context_2).success(function(context) {
				data.push(angular.copy(context));
				count++;
			});
        });

to decide this bug.
Then I get list of products data = [...]; and post to Cart Serializer:
interval_ID = setInterval(function () {
			if (count == $change_count.length) {
				for (var i = 0, l = $change_count.length; i < l; i++){
					$http.post(cart_url, data[i]).success(function () {
						added_products++;
					});
				}

				clearInterval(interval_ID);
            }
        }, 200);

I use setInterval for check that I send all
$http.post(updateUrl, context_2).success(function(context) {
				...
			});

Second interval_ID_2  is used to know when we need reload page.

I understand how I can improvement my code!
Now if we have 5 quantity fields, then we send 10 requests to server:

/add-to-cart (5 requests: for updating the product contet for each size)
/cart (5 requests: for adding of products to cart)

I think that I can use 1 request instead of 5 requests of /add-to-cart using own Serializer. And maybe I can use angular for changing of quantity.
I can show my results, when I will realize my idea.

Before proceeding with DOM manipulations, you should really read this excellent post “Thinking in AngularJS” if I have a jQuery background? on Stackoverflow.

Thank you Jacob! It really that I need because in Angular I am new. It's good post. I think this issue need close, because this issue lost activity.. Or not close.. How do you think about it?
I'd like to finish my task about adding some products and add solution to here, but it may be long by time.

can we close this?

Yup :)

Yes, it's better to close this issue. My code above is very bad and it should be removed..
This task is specific and I plan to created any use-cases to someone can use it. Maybe it will place on my blog and offer you to include in the docs.. Howbeit I have many ideas and some working code which needs in refactoring. Later I will add some issues. By some reason I can continue my work after April.


NTP-590: Reinstate providers removed yesterday

Changes proposed in this pull request
Reinstate the providers removed yesterday
Link to Jira ticket
https://dfedigital.atlassian.net/browse/NTP-590
Things to check

[x] Title is in the format "NTP-XXX: Short description" where NTP-XXX is the Jira ticket reference
[x] Code and tests follow the coding standards
[x] dotnet format has been run in the repository root
[x] Test coverage of new code is at least 80%
[x] All UI related acceptance criteria specified in the ticket have been added to the relevant cypress test feature file(s)
[x] Unless explicitly mentioned in the ticket, all UI work should have been tested as working on desktop and mobile resolutions with JavaScript on and off
[x] Database migrations can be applied to the current codebase in main without causing exceptions
[x] Debug logging has been added after all logic decision points
[x] All automated testing including accessibility and security has been run against your code
[x] PR deployment has been signed off by wider team

Approved - https://dfedigital.atlassian.net/browse/NTP-590?focusedCommentId=48475


Website not automatically updating

The README notes that the website is updated via cron job - but 8fb8cc9d8cbac11241de9a03effb977a130f8317 isn't live yet on the site.
Related to #41

https://rakudo.org/community

Normaly this works automatically. Sometimes it needs a small push. (hypnotoad -s app.pl; hypnotoad app.pl)
Done.


Programming Languages - "C Language" Resources

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section
Description:
Hey @jfmartinz  I have added the resources of C Programming Language
 ./Programming Languages
    /C
     /readme.md

Please take a look, Thank You!!  --> On To The Next
Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[X] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[X] I followed the prescribed PR title template. (Check this if you're adding a resource)

Hey, @jfmartinz The folder structures for programming languages have been changed by someone,

could you please check and let me know if i have to create the upcoming folders inside or outside the programming languages.?
Thank you.

Yes I made a mistake, it should be inside the programming languages, after you made another PR, please moved it, thanks.


Changes and Adds operator e2e tests

Refactor operator tests according to previous discussion to include multiple cases in the same rulebook to improve the execution time in addition to replace the run_playbook action in favor of echo. Makes shutdown delay configurable. Extended usecases. Implement pytest-match to be able to run the rest of the assertions of a given test even if some one fails.
It alsfo fixes the dynaconf pkg, which was in requirements_lint instead of requirements_test
Closes https://issues.redhat.com/browse/AAP-8658

This was a old branch by mistake. Close it and create a new one with the final version


update prometheus lib to 1.6.0

Fixes  #1291

/assign @evankanderson

@lionelvillard this seems to be now done:
https://github.com/knative/pkg/blob/master/go.mod#L30
/close this?


Give a link to the doc for environment specific configuration

I've seen many devs who have not found the link

ping @jmleroux

ping @jmleroux


Test PR

Coverage remained the same at 62.153% when pulling ca8e8f5537f262d257b07da48134d5d78f235465 on testing into 8e4fb3035c2b44120149e2128452926f0057ce67 on master.


SoC: usb_device_connect=0 does not disconnect device

I'm using Luna as a HS USB wishbone peripheral in a SoC bootloader design for the ButterStick. I'd like to be able to disconnect the USB interface from firmware to support re-enumeration.
USBDevice.connect is a signal that is connected via the standard SoC interface, Which has the following description:
class USBDevice(Elaboratable):

    Attributes
    ----------

    connect: Signal(), input
        Held high to keep the current USB device connected; or held low to disconnect.

If I hold connect low on power-up the device never appears, as expected. When I pull this signal high the device appears, as expected. However If the device is attached then pulling this signal low I'd expect the host to detect we've disconnected. But that is not the case.
The gateware seems to remove the termination if connect drops low.
self.utmi.term_select.eq(reset_sequencer.termination_select & self.connect),

But this results in termination being set to 0. Which is defined as HS_NORMAL
class UTMITerminationSelect:
    """ Enumeration that specifies meanings of the UTMI TermSelect bit. """

    HS_NORMAL    = 0
    HS_CHIRP     = 1
    LS_FS_NORMAL = 1

A quick fix I've found is to mask vbus_connected with self.connect. So that when we bring 'self.connect' LOW it's equivalent in logic to a vbus removal. With this in place the device correctly disconnects.
This works, but I'm not sure if this is the correct place to perform this mask.
diff --git a/luna/gateware/usb/usb2/device.py b/luna/gateware/usb/usb2/device.py
index 67e4c6b..4956cd3 100644
--- a/luna/gateware/usb/usb2/device.py
+++ b/luna/gateware/usb/usb2/device.py
@@ -232,7 +232,7 @@ class USBDevice(Elaboratable):
         m.d.comb += [
             reset_sequencer.bus_busy        .eq(self.bus_busy),

-            reset_sequencer.vbus_connected  .eq(~self.utmi.session_end),
+            reset_sequencer.vbus_connected  .eq(~self.utmi.session_end & self.connect),
             reset_sequencer.line_state      .eq(self.utmi.line_state),
         ]

Thank you for this information! I've upgraded this issue to bug status. I will leave this issue open until it is addressed.

Fixed in #212.


[Feature Request] Custom Quotes

Problem Statement
I'm excited by the fact that I would be able to add dynamic quotes to my GitHub read-me page, but these quotes would be always random. The quotes that would be generated by a specific category or from a list of quotes would be highly useful as that would meet the requirement to clearly give dynamic quotes based on my profile, ex: Designer, Developer, etc.
Possible Solution
A file in the GitHub profile repository that contains a list of data that would be used to get the quotes data from, so that always predictable, but random quotes appear on the read-me.
Additional context
Let's say I have a read-me page and I want to have random quotes but from a certain set of quotes. I would make a file from a template and enter the quotes, then I would get the quotes to my read-me page from this file. In this way I'm sure what my profile viewers would see.

Hi @ShubhKotnala ,
Your feature request has been accepted.Please proceed ahead.
Make sure to go through contributing.md before raising the PR.


language improvements

Sebastian, let me know if these changes work for you.

@stianst can you merge ?


Deep branch

Here are the things achieved via this PR

To run the code, please use these set of commands: npm install, sequelize db:migrate, nodemon
Users have login options as well as signup options.
Users can sign in locally or authenticate with google.
Unauthorized users are being redirected to the signup page, where they can sign in.
Authorized users are being directed to the dashboard.
User info is being stored in the DB. A few tweaks or tune-ups are still needed.

Just by looking at the code I can see the work done in multiple files has been deleted. That work needs to be restored before merging will be possible. I'll give a more detailed review later.

Also, once you get this working let me try deploying it to Heroku before merging it into main. I don't think there will be any problems with deploying it there but it's best to be sure before merging.

Okay, it's obvious to me after looking at the commits what the problem might be. You deleted all of the files in this commit 6f1c704 and then started over again from scratch. Since the most recent action done to those files was delete them it has messed up the automatic merging process in git. Don't do that again in the future.
Off the top of my head I think you could try manually merging main into your branch though I don't know how to do that. That would mean literally choosing for each file what things you'd like to keep and what changes need to be kept. But yeah, this isn't gonna be easy.

Closed because of merge conflicts but don't delete it until #26 is working and merged in.


compiler bug

Bug Report
Module validation failed: Function return type does not match operand type of return inst!
  ret ptr %2, !dbg !152
 %"->" = type { ptr, ptr }Function return type does not match operand type of return inst!
  ret ptr %52, !dbg !173
 %"->" = type { ptr, ptr }Function return type does not match operand type of return inst!
  ret ptr %1, !dbg !210
 %"->" = type { ptr, ptr }Function return type does not match operand type of return inst!
  ret ptr %19, !dbg !244
 %"->" = type { ptr, ptr }Function return type does not match operand type of return inst!
  ret ptr %0, !dbg !263
 %"->" = type { ptr, ptr } (Exception)
  from /crystal/src/llvm/module.cr:73:9 in 'codegen'
  from /crystal/src/compiler/crystal/compiler.cr:202:16 in 'compile:combine_rpath'
  from /crystal/src/compiler/crystal/compiler.cr:195:56 in 'compile:combine_rpath'
  from /crystal/src/compiler/crystal/command.cr:239:5 in 'run'
  from /crystal/src/compiler/crystal.cr:11:1 in '__crystal_main'
  from /crystal/src/crystal/main.cr:129:5 in 'main'
  from src/env/__libc_start_main.c:95:2 in 'libc_start_main_stage2'
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

In docker image https://hub.docker.com/layers/crystallang/crystal/1.12-alpine/images/sha256-297e82182800ff101755a2a26de747d6654eae3b487eb108aeac3299f181408d?context=explore

Can you share a minimal reproducible example that causes this error?

You could also write -> : Bool { cond_fns.all? { |fn| fn.call } }, since it looks like the compiler had issues inferring that return type.
Reduction: (note that recursive types are not needed here, only a recursive def)
class Foo
  @x = uninitialized -> Bool
end

def foo(cond) : -> Bool
  if cond.is_a?(Foo)
    -> { foo(cond.@x).call }
  else
    cond
  end
end

foo(Foo.new)


pip install errors out with HTTP error 404

According to the documentation https://nvidia.github.io/TensorRT-LLM/installation/linux.html, I run python -m pip install tensorrt-llm yet it gives
Collecting tensorrt-llm
  Using cached tensorrt_llm-0.15.0.tar.gz (1.3 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [98 lines of output]
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 226, in download_wheel
          return download_manual(wheel_directory, distribution, version, config)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 160, in download_manual
          index_response = urlopen_with_retry(project_url)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 83, in urlopen_with_retry
          return urlopen(url, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 215, in urlopen
          return opener.open(url, data, timeout)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 521, in open
          response = meth(req, response)
                     ^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 630, in http_response
          response = self.parent.error(
                     ^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 559, in error
          return self._call_chain(*args)
                 ^^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 492, in _call_chain
          result = func(*args)
                   ^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 639, in http_error_default
          raise HTTPError(req.full_url, code, msg, hdrs, fp)
      Traceback (most recent call last):
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 226, in download_wheel
          return download_manual(wheel_directory, distribution, version, config)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 160, in download_manual
          index_response = urlopen_with_retry(project_url)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 83, in urlopen_with_retry
          return urlopen(url, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 215, in urlopen
          return opener.open(url, data, timeout)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 521, in open
          response = meth(req, response)
                     ^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 630, in http_response
          response = self.parent.error(
                     ^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 559, in error
          return self._call_chain(*args)
                 ^^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 492, in _call_chain
          result = func(*args)
                   ^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/urllib/request.py", line 639, in http_error_default
          raise HTTPError(req.full_url, code, msg, hdrs, fp)
      urllib.error.HTTPError: HTTP Error 404: Not Found

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/mnt/heyangqin/envs/heyangqin/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          whl_basename = backend.build_wheel(metadata_directory, config_settings)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/buildapi.py", line 29, in build_wheel
          return download_wheel(pathlib.Path(wheel_directory), config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/wheel.py", line 228, in download_wheel
          report_install_failure(distribution, version, config, exception_context)
        File "/tmp/pip-build-env-ybw8xx6w/overlay/lib/python3.12/site-packages/wheel_stub/error.py", line 67, in report_install_failure
          raise InstallFailedError(
      wheel_stub.error.InstallFailedError:
      *******************************************************************************

      The installation of tensorrt-llm for version 0.15.0 failed.

      This is a special placeholder package which downloads a real wheel package
      from https://pypi.nvidia.com/. If https://pypi.nvidia.com/ is not reachable, we
      cannot download the real wheel file to install.

      You might try installing this package via
      ```
      $ pip install --extra-index-url https://pypi.nvidia.com/ tensorrt-llm
      ```

      Here is some debug information about your platform to include in any bug
      report:

      Python Version: CPython 3.12.7
      Operating System: Linux 6.8.0-1017-azure
      CPU Architecture: x86_64
      Driver Version: 550.127
      CUDA Version: 12.4

      *******************************************************************************

      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

I tried the --extra-index-url https://pypi.nvidia.com/ and the error is same

Oh the good old place holder, had same issue when installing on windows, but resolved via:
pip install tensorrt_llm==0.14.0 --extra-index-url https://download.pytorch.org/whl/
They did upgrade the guidance database with ==0.15.0 but you are just gonna get a place holder

@TriDefender That solves my issue. Thank you! I will leave this issue open so the trtllm team can fix the doc so it doesn't confuse more users haha

They also need fix the requirements.txt, the current one just uses
tensorrt-llm and you end up with a place holder
Heyang Qin @.***> 于 2024年12月5日周四 20:42写道：

@TriDefender https://github.com/TriDefender That solves my issue. Thank
you! I will leave this issue open so the trtllm team can fix the doc so it
doesn't confuse more users haha
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/TensorRT-LLM/issues/2542#issuecomment-2521250345,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJMCJSKIDGJSYWWFLBYGLPD2ECUA3AVCNFSM6AAAAABTC4WRNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRRGI2TAMZUGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


merge develop

Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 14 committers have signed the CLA.:x: KomachiSion:x: zrlw:x: robynron:x: 985492783:x: 0808bing:x: liu-xg:x: Sujishark:x: chaicho:x: stone-98:x: JorringHsiao:x: huangkemingyyds:x: Bo-Qiu:x: llm163520:x: shiyiyue1102You have signed the CLA already but the status is still pending? Let us recheck it.


upgrade cli does not distinguish that a field is ENUM and not a MEDIUMTEXT

Hello,
Our datamodel has a lot of ENUM type fields, some the cli were able to identify as such, but the rest were identified as MEDIUMTEXT.
Manually changing the SQL queries to the correct format, followed by introspection again did not remove the suggestion; it actually still showed that fields with MEDIUMTEXT type needed a default value, although I had already taken care of that.

Can you show an example of a Prisma 1 schema and the corresponding SQL schema that has this problem?

Thanks for a prompt response.
please find here Prisma 1 schema
type User {
	id: ID! @unique
	email: String
	userStatus: UserStatus @default(value: "PENDING")
	userStatusUpdatedAt: DateTime
}

enum UserStatus {
	APPROVED
	BLOCKED
	ARCHIVED
	REJECTED
	PENDING
	REVOKED
}

As you can see here userStatus in User is enum.
So Prisma upgrade CLI given SQL statement for making PRISMA 2 compatible is,
ALTER TABLE `User` CHANGE `userStatus` `userStatus` ENUM('APPROVED', 'BLOCKED', 'ARCHIVED', 'REJECTED', 'PENDING', 'REVOKED') ;
ALTER TABLE `User` CHANGE `userStatus` `userStatus` MEDIUMTEXT  DEFAULT 'PENDING';

So if we run the above script in a database then it will again convert this field into MEDIUMTEXT from ENUM.
so ideal script for these changes should be this,
ALTER TABLE `User` CHANGE `userStatus` `userStatus` ENUM('APPROVED', 'BLOCKED', 'ARCHIVED', 'REJECTED', 'PENDING', 'REVOKED') DEFAULT 'PENDING' ;

also one more point for MySQL 5.7 version below script showing error BLOB, TEXT, GEOMETRY or JSON column 'userStatus' can't have a default value, due to TEXT type column does not support default value in 5.7 version MySQL.
ALTER TABLE `User` CHANGE `userStatus` `userStatus` MEDIUMTEXT  DEFAULT 'PENDING';

also, MySQL version 8.0 also has not run the above script we need to slightly modify the above script in order to run in the database, here's updated script,
ALTER TABLE `User` CHANGE `userStatus` `userStatus` MEDIUMTEXT  DEFAULT ('PENDING');


Fix for bug that connects multiple profiles to users in some instances.

Here's the situation:

I log into Facebook as Alice
I log into the Django app using Facebook
I log out of Facebook
I log into Facebook as Bob
The app exposes a "connect with facebook" button, even though I'm logged in as Alice. I click on it.

The result: both Alice and Bob's Facebook profiles are linked with Alice's account in the app.
What this patch does is check to see if request.user does not match the user associated with the profile. If this is the case, log in as the user associated with the profile, rather than connect the profile with request.user.

Makes sense. Could you add a testcase for this too?

Ah well, looks like I'm doing some updates again so I might add the tests myself

I'm a bit occupied at the moment, but will hopefully be free to write the test after a week or so.

Just added another fix to this pull request.
(Forgive me, I'm not a real git or github user. I would have preferred to make a separate pull request for this commit, but apparently that's not how it works)
Steps:

User logs in, not via FB
User connects with FB
socialregistration connects the FB profile to the User, but does not re-authenticate or login.

This patch changes #3 so that we re-authenticate and login. It might seem arbitrary, but the reason we should do this is because Django keeps track of which authentication backend a user authenticated with. I think the right thing to do is to set the authentication backend in this case to be FB.
This commit solves a problem with my use case, which is mixing django-lazysignup with socialregistration.


contentBlock is not working with images

Using this approach is not working when using q.contentBlock().
I am seeing this error:
ZodError: [
  {
    "code": "invalid_literal",
    "expected": "block",
    "path": [
      "faq",
      1,
      "content",
      1,
      "_type"
    ],
    "message": "Invalid literal value, expected \"block\""
  },
  {
    "code": "invalid_type",
    "expected": "array",
    "received": "undefined",
    "path": [
      "faq",
      1,
      "content",
      1,
      "children"
    ],
    "message": "Required"
  }
]

This can probably be folded in with #61

Ok, cool. Closing this then.


fix657 add UT_Stub_RegisterContext

Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog.
This will create the correct register buffer size.
Describe the contribution
Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog.
This will create the correct register buffer size.

Fixes #657

Testing performed
Steps taken to test the contribution:
travis CI passed:    https://travis-ci.com/github/jtovias/cFS/builds/164052416
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

Behavior Change:

using ut stubs CFE_EVS_SendEvent and CFE_ES_WriteToSysLog, the register buffer will have the correct size
access to register buffer element will exist

System(s) tested on

Hardware: [e.g. PC, SP0, MCP750]
OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

If NASA Civil Servant Employee or GSFC Contractor on SES II

Address/email/phone and contract/task information (if applicable) must be on file

Else if Company

HAND SIGNED Company CLA must be on file (once per release): Company CLA

Else if Individual

HAND SIGNED Individual CLA must be on file (once per release): Individual CLA

CCB 20200506 - APPROVED

@jtovias - could you fill out the remainder of the sections in the pull request template, and submit the Company CLA

Amend commit message -
Fix #657, Add unit test stub register context to cFE stubs

UT_Stub_RegisterContext added to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog

@skliper, if working for a NASA contract do I still need to submit a Company CLA?

@skliper, if working for a NASA contract do I still need to submit a Company CLA?

Yes, our office of patent counsel requires us to have a CLA for any contract other than our one local contract they have explicitly approved.

@jtovias Any status update/progress on the CLA?

@skliper  I email my CLA for cFE 6.7 and OSAL Thursday (5/7) to GSFC-SoftwareRelease<EMAIL_ADDRESS>Am I suppose to get an email confirmation?

@jtovias Thanks! I'll confirm it was received.

@jtovias Thanks! I'll confirm it was received.

@skliper any update on this CLA?

Rebased on master and updated commit message.  Still pending OPC CLA confirmation.

@astrogeco CLA receipt confirmed.

@skliper looks like something broke in the CI config.

@astrogeco - I just restarted the test and it worked fine.  Looked like a travis-ci issue (not an issue on our side).


[Fix-14625][dolphinscheduler-master] Submit the condition task behind the skip node

Submit the condition task behind the skip node

Purpose of the pull request
To fix a bug, see the issue 14625 for details。fix https://github.com/apache/dolphinscheduler/issues/14625

Brief change log
Modification some method， eg: org.apache.dolphinscheduler.service.utils.DagHelper#parseConditionTask

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Modify org.apache.dolphinscheduler.service.utils.DagHelperTest#testConditionPostNode tests  to verify the change

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

从我的观点来看，首先c1节点的某条分支是非执行时，并且这条非执行分支上有condition 节点（以下成为c2），并且这个c2节点是或的关系。我会做以下操作
1.当或的条件没有全部判断完毕，我不会将c2 放入skip 节点
2.在c2 节点信息上加入c2所依赖的各个dependNode的状态，例如c2节点依赖c1节点的那条分支是不执行的，我就设该dependNode 为false
3.当c2 所依赖的dependNode全为false时，放入skipNodeList
From my point of view, first of all, a branch of the c1 node is non-executable, and there is a condition node (hereinafter referred to as c2) on this non-executive branch, and this c2 node is an or relationship. I would do the following
1. I will not put c2 into the skip node when all the conditions of or have not been judged
2. Add the status of each dependNode that c2 depends on to the c2 node information. For example, the branch where c2 node depends on c1 node is not executed, so I set the dependNode to false
3. When the dependNodes that c2 depends on are all false, put them into skipNodeList

hi @alei1206 WDYT ? cc @Radeity

从我的观点来看，首先c1节点的某条分支是非执行时，并且这条非执行分支上有condition 节点（以下成为c2），并且这个c2节点是或的关系。我会做以下操作 1.当或的条件没有全部判断完毕，我不会将c2 放入skip 节点 2.在c2 节点信息上加入c2所依赖的各个dependNode的状态，例如c2节点依赖c1节点的那条分支是不执行的，我就设该dependNode 为false 3.当c2 所依赖的dependNode全为false时，放入skipNodeList
From my point of view, first of all, a branch of the c1 node is non-executable, and there is a condition node (hereinafter referred to as c2) on this non-executive branch, and this c2 node is an or relationship. I would do the following
1. I will not put c2 into the skip node when all the conditions of or have not been judged
2. Add the status of each dependNode that c2 depends on to the c2 node information. For example, the branch where c2 node depends on c1 node is not executed, so I set the dependNode to false
3. When the dependNodes that c2 depends on are all false, put them into skipNodeList

hi @alei1206 WDYT ? cc @Radeity

@fuchanghai  你好，这部分我有其他看法，我认为这个问题的原因是特殊场景下c2无法被提交执行，而不是c2是否加入到skipNodeList的问题。如图（s1是sleep 30s， s7是sleep 10s），在此场景下，c2是不会被放入skipNodeList。当s7执行结束时，由于s1处于running状态，所以c2的dependNodes未完成，不会被提交执行。当s1完成后，会将s4放入到skipNodeList，DolphinScheduler只会检查c2节点是否需要被放入skipNodeList，而不会检查是否需要执行，造成c2无法被提交执行。我所做的是获取c1之后所有被跳过的节点，然后判断被跳过节点后面是否存在Condition类型任务（如c2）。如果有则将其加入到队列并尝试提交执行。如果c2不满足执行条件，则在后续逻辑中会被移除队列。


MEASURE with 1 argument

Why do we support this? I was very confused why run kept returning all zeros even though I added MEASURE instructions to the end :)
Explicitly
MEASURE 0

throws out the result. You need to do
MEASURE 0 0

It's so you can do measurement just for effect. I agree this is the wrong default though and bad from a UX perspective.
Similarly themed tickets:

https://github.com/rigetticomputing/pyquil/issues/223
https://github.com/rigetticomputing/pyquil/issues/158
https://github.com/rigetticomputing/pyquil/issues/137

(dragging up an old issue) I disagree that this is a problem. IMO MEASURE is an explicit instruction that effects quantum memory (through the first argument) and classical memory through the second.
Leaving off the second argument makes sense that it would just measure the qubit and not deposit the result anywhere.

It's fine to have a Quil instruction - but this is such a stumbling block from the PyQuil side. We can support it but maybe not make it so easy to trip up: for instance by making the second argument mandatory and you have to pass None for measurement for effect

+1
On Tue, Jul 17, 2018, 22:31 Steven Heidel<EMAIL_ADDRESS>wrote:

It's fine to have a Quil instruction - but this is such a stumbling block
from the PyQuil side. We can support it but maybe not make it so easy to
trip up: for instance by making the second argument mandatory and you have
to pass None for measurement for effect
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rigetticomputing/pyquil/issues/248#issuecomment-405813896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE-Rgli81tENciHOVs2ZXQ56JuBUaF7wks5uHsghgaJpZM4RJII0
.

--
Will Zeng, PhD  |  Head of Quantum Cloud Services  |  Rigetti Quantum
Computing  |  m:<PHONE_NUMBER>  |  rigetti.com
Confidentiality Note: This message is for the intended recipient only and
may contain proprietary, private or confidential information. The use,
copying or distribution of the contents of this email, or any attachments
hereto, by anyone other than the intended recipient, or an employee or
agent authorized by the intended recipient, is prohibited.

even from the quil side we should have MEASURE-FOR-EFFECT or a /dev/null equivalent to pass as the second argument. When the default argument is the opposite of how everyone uses it ... it's a bad default!

this is still a problem


Wallet fails to compile

Platform: Ubuntu 18.04
CPU: Intel(R) Xeon(R) CPU E3-1270 v6 @ 3.80GHz
RAM: 64GB
HDD: 2TB

All dependencies installed, up until last release, everything was able to compile without problems.  Problem can be replicated, either with standard compile utilising:
./autogen.sh
./configure
make

expected to compile, but throws the following error:
main.cpp: In function ‘bool AcceptBlock(CBlock&, CValidationState&, CBlockIndex**, CDiskBlockPos*, bool)’:
main.cpp:4624:9: error: ‘isPoS’ was not declared in this scope
     if (isPoS) {
         ^~~~~
main.cpp:4734:13: error: ‘splitHeight’ was not declared in this scope
             splitHeight = prev->nHeight;
             ^~~~~~~~~~~
main.cpp:4734:13: note: suggested alternative: ‘nHeight’
             splitHeight = prev->nHeight;
             ^~~~~~~~~~~
             nHeight
Makefile:5837: recipe for target 'libbitcoin_server_a-main.o' failed
make[2]: *** [libbitcoin_server_a-main.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/git/syndicate/src'
Makefile:9887: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/git/syndicate/src'
Makefile:747: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

Have also attempted to compile with the following procedure to use depends directory:
cd depends
make -j2 NO_QT=1
cd ..
./autogen.sh
./configure --prefix `pwd`/depends/x86_64-pc-linux-gnu
make

however the same error occurs.  This would suggest a problem in the code, causing it to fail.  Code pulled from: https://github.com/SyndicateLtd/SyndicateQt

Not sure if problem is related to last commit to branch master being 18 Jun, and the wallet release being 20 Jun.  Maybe code changes between 18-20 Jun weren't commited to master branch?


Default branch name.

Hi,
Should the guide be updated for the new main branch instead of master
https://github.com/github/renaming

Done!


[Bug][Doc] The chunk-meta.group.size option is missing in the documentation for MongoDB CDC description

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
1.13.5
Flink CDC version
2.3
Database and its version
none.
Minimal reproduce step
noen.
What did you expect to see?
Add chunk-meta.group.size option in the documentation for MongoDB CDC
What did you see instead?
none.
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Thanks @e-mhui for reporting this issue.
The configuration "chunk-meta.group.size" has no effect on the MongoDB connector, so we don't need to add it.


[Feature]: Interactive Tooltips

What would you like to see added to the NWB GUIDE?
As @rly noted in our last meeting, it would be great to allow users to highlight and copy tooltip text. This would allow them to, for instance, take the example strain value on the Subjects table and use this as a reference for their actual values.
This feature is already supported in Tippy natively—but specifying interactive: true results in the inclusion of the tooltip as adjacent HTML to the element it's applied to.
In the case of the Subjects table, this results in the tooltip being cut off because the HandsOnTable styling requires the overflow to be hidden.
I'm not sure if there's a way around this, but we'll need to find one to have interactive tooltips on the Subject table, where we initially thought it would be most useful
Do you have any interest in helping implement the feature?
Yes.
Code of Conduct
Yes
Did you confirm this feature was not already reported?
Yes

@garrettmflynn I think this was fixed/added, correct?

No I'd tried but ran into the issues described above.
Though this problem is limited to the Subject table. I could simply exclude HandsOnTable elements from this change.


docs: add configuration file crud instructions

Add instructions on how to add, edit and remove configuration files

@plantaz, could you connect this PR with the Jira Issues related to it? Creating a section in your PR description following Slab - Devopness: Jira Issue list will connect them.
[DVN-10223] and its children


Not getting _fop metrics

Built from the latest source,
Am I forgetting something?
./gluster_exporter --gluster.volumes data --web.listen-address=<IP_ADDRESS>:8010 --profile

Oh, you need to start a gluster profile before!
https://docs.gluster.org/en/latest/Administrator Guide/Monitoring Workload/


Revist how we read values from DbDataReader (GetFieldValue, GetValue, etc.)

To support Mono SqlClient in beta 4 we made RelationalTypedValueReader.ReadValue not use the generic DbDataReader.GetFieldValue. This is ok for SQL Server but we want the generic one for SQLite to help with detecting data types. It's also been suggested that ReadValues may be better to use on SQL Server (and that would work with Mono too).
It seems like we probably need each data store to be able to override how value reading is done.

We are making further changes in this area at https://github.com/aspnet/EntityFramework/pull/1992 for Mono compatibility.

We may be able to use GetFieldValue now. https://github.com/mono/mono/pull/2010


"automatically promoted to be the private channel owner" may be false

If a private channel owner leaves your organization or if they are removed from the Microsoft 365 Group associated with the team, a member of the private channel is automatically promoted to be the private channel owner.

It may not be true according the recent issue we've got in our Teams and this post: https://docs.microsoft.com/en-us/answers/questions/100064/teams-unknown-user-as-only-private-channel-owner.html
Do you mind verifying it, the "automatically promoted" thing?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce34b12b-aa50-608b-bbfa-a1fb4bb79f8d
Version Independent ID: 9ddeb6f4-f30a-1e72-fc94-ae66def91f40
Content: Private channels in Microsoft Teams - Microsoft Teams
Content Source: Teams/private-channels.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @Peter-Wxin Peter
Thanks for your feedback!
I tested this, and a member of the private channel was automatically promoted to owner. Both when the owner is deleted or the owner is removed from the group.
Thank you!

@scanum


MINOR: add describe to valid group acl operations

@junrao

Seems to be the same as https://github.com/apache/kafka/pull/1723, the test needs to be updated as per that PR I think.

sorry, just ran in to this, i'll close


updating file_system to send back the copy status

Signed-off-by: Vinay Satish<EMAIL_ADDRESS>
Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Acceptance Criteria
knife-ec-backup accepts a new flag “--results-path”.  Defaults to current backup directory.

knife-ec-backup outputs a new file, containing the results of the run as documented in description. Output file name includes date-time stamp.

file will not be overwritten if it already exists.

the file is created no matter what failures have occurred.

Could we have a copy-paste (screendump, screenshot, whatever) of a terminal session showing this working?
Also, does the acceptance criteria I put in the comments apply here? Or is that for another PR?

The acceptance criteria is for the other PR


[5225] Take number of frames into account when limiting image size

Fixes #5225
This depends on https://github.com/wagtail/Willow/pull/74

@kaedroho does this need updates to make the checks pass?

Just released Willow 1.3 which includes the get_frame_count operation

Rebased at #5627


Query regarding bug bounty

want to ask do you have any bug bounty program or do your team provide bounty for reporting critical issues? because i found 1 critical issue
Thank you

Hi @deepak9876, we don't have a bounty for reporting bugs. We are welcome you to report bug, and then we will fix it soon.


youtube-dl ABC NSW news

repeatedly having error downloading ABC NSW news:
https://iview.abc.net.au/video/NU2101H170S00

That URL works in YTDL for me. Do you have FFmpeg installed ? If not, you will get an error. Are you in Australia ? If not, you will probably get an error.
Please follow the guidelines for raising issues. For example, can you provide a copy of the verbose response from YTDL ? When you opened the issue there was a template for you to follow. If you don't follow the template, your issue might be closed without an answer.
Anyway, what was the error ?


Why fault an ATS Translation Request when ddtp.iommu_mode is Bare?

Maybe this is explained somewhere in the IOMMU document, but if so I couldn't find it easily.
In Section 2.4, the process to translate an IOVA says that if ddtp.iommu_mode is Bare, a PCIe ATS Translation Request, or a memory access attempt with a translated address, should stop and report "Transaction type disallowed" (cause = 260).
Why can't we allow PCIe ATS translation requests when ddtp.iommu_mode is Bare and do one of the following:  either return the virtual address back as the translated address, or set the U bit (Untranslated access only) in the Translation Completion response?

Granted, software should ideally disable ATS from a PCIe function if it knows it won't be useful.  (By clearing the Enable bit in the function's ATS Extended Capability structure.)
The question I have is, will every device driver always know when the situation calls for ATS to be disabled?

So ATS enabling/disabling is controlled by the IOMMU driver and not device drivers. Please see. IOMMU drivers do not enable ATS
in devices unless ATS is enabled in the IOMMU. Please see


Fix Powershell Build Script (issue 247)

Locate MSBuild 15 using vswhere (https://github.com/Microsoft/vswhere)
Including vswhere in commit as can't rely on VS being installed already/

Great! I'll pull it in and test, i'll just assume this works :) YOLO!


ListFiles() does not detect file?

Case
I have two files in separate folders and one empty folder. Here's output of tree
.
├── a1
│   └── 2.txt
├── a\1
│   └── 1.txt
└── empty

3 directories, 2 files

Code
package main

import (
	"fmt"
	"github.com/bitfield/script"
	"os"
)

func main() {
	s, _ := script.ListFiles(os.Args[len(os.Args) - 1]).String()
	fmt.Print(s)
}

Compiled binary list_files_test stored in $PATH
Test

$ list_files_test a1
Output: a1/2.txt
Expected: a1/2.txt
$ list_files_test a\\1
Output: a1
Expected: a\1/1.txt (or a\\1/1.txt)
Maybe i misunderstood expected behavior?

Source of the problem
ListFiles() detect this input as glob by  strings.ContainsAny(path, "[]^*?\\{}!"). However that is not glob for sure.
And i don't know is that expected or not.
Additional
This issue related and important to #55.
Let's assume i have input for FindFiles such as /some/abs/path/a\\1/*.txt (assuming we have same case as i provided at the beginning). By this input i would expect library will interpret folder a\\1 as root for filepath.Walk. Then this walking should find all txt files under folder a\\1. But with same way of detecting glob as in ListFiles function will take folder path as root and then will also find all txt files under folder like a1 from provided test case. However these files are not in our interests. (Of course assuming we want to check all directories match glob as well, not just file).
Yes, programm could produce expected output if i would check input string in main but this input is for just illustrating problem related to #55.
Workaround
Change way of glob detecting.

Hey @Prepodavan, thanks for the report! If I'm understanding you correctly, you're saying that a path such as a\\1 is incorrectly detected as a glob, and therefore ListFiles() simply reports the directory as the only match for the glob, rather than listing the files in the directory. Is that right?
So possibly we could fix this by changing the regex which is used to recognise globs?

Yes. But user of ListFiles() could simply avoid problem this by changing input string on his own (if he knows about this case). And I also tried to say same problem in FindFiles() would produce wrong and wouldn't be as easily avoided as in ListFiles() if it will use same way of glob recognising as ListFiles() use now. So changing the regex which is used to recognise globs is necessary for implementing #55

I could fix this issue and implement #55 if u agree with my arguments

Yes, you're most welcome! I suggest you put in a PR which includes a test case for ListFiles which fails, demonstrating the problem, and thus also confirming for us when we've successfully fixed it. Once we're happy with the failing test, you can go ahead and make it pass 😄

I misinterpreted task. So this issue is not relevant anymore. I guess should be closed

I'm not sure what you mean. I agree with you that a filename containing a backslash should not be interpreted as a glob, and as far as I know that issue still exists. Shouldn't we keep this open, then?

Validation of case with input string containing characters of glob is not responsibility of function script.ListFiles as same as filepath.Match (and Glob). That's responsibility of user of this functions. He should escape with \ these characters if they shouldn't be interpreted as glob.
This issue was inspired not by ListFiles but by #55. I thought impossible to implement #55 without taking responsibility for case with input string with glob characters. Then function FindFiles should know where's real glob or just string with characters of glob. Otherwise it would produce wrong output. And i tried to illustrate this problem on existing code (ListFiles) even knowing this code is not a source of problem.
But I finally figured out where I was wrong and how to implement #55 leaving responsibility for this case to the user.
If I finally understand everything correctly in current implementation of ListFiles and in my implementation of FindFiles everything will work fine if user will do escaping for chars he dont consider as glob. So I don't think this issue is relevant.
You still could reopen this if you have some arguments for this. But I haven't


Selectable colour ramps for choropleth map

Choropleth map of dietary supply in quick maps page should support alternative colour ramps.  These should be toggleable via the 'settings' cog on the card header.

Simple case: Toggle between two static ramps

Extended case: Support user defined ramps

Might be difficult to progress this one until #170 is complete.

Might be difficult to progress this one until #170 is complete.

@bgsandan do you see the thresholds between grades being dynamic, static, included with the data or worked out proportionally from the data?

@bgsandan do you see the thresholds between grades being dynamic, static, included with the data or worked out proportionally from the data?

Very good question!  Currently in discussions with @LouiseAnder about this one.  The thresholds that are appropriate will depend on both the data that is being displayed and the modelling / algorithm that has gone into creating those values.
In the interest of keeping the component lightweight and re-usable in multiple contexts across the app, I would suggest we assume that the thresholds will come from in the API response along with the data (seeing as the response structure for this endpoint isn't fully defined and may be impacted by the work in #170.  That means that either inferring ranges from the data and/or recalling pre-stored thresholds from the DB can be delegated to the API rather than muddying the app logic.
Make sense?

Very good question!  Currently in discussions with @LouiseAnder about this one.  The thresholds that are appropriate will depend on both the data that is being displayed and the modelling / algorithm that has gone into creating those values.
In the interest of keeping the component lightweight and re-usable in multiple contexts across the app, I would suggest we assume that the thresholds will come from in the API response along with the data (seeing as the response structure for this endpoint isn't fully defined and may be impacted by the work in #170.  That means that either inferring ranges from the data and/or recalling pre-stored thresholds from the DB can be delegated to the API rather than muddying the app logic.
Make sense?

Makes sense and completely agree.
Might mean that this task is better approached after the #170 then.  Even if we don't have live data by then, at least at that point the data requirements for displaying the chloropleth should be better known.

Makes sense and completely agree.
Might mean that this task is better approached after the #170 then.  Even if we don't have live data by then, at least at that point the data requirements for displaying the chloropleth should be better known.


Working directory Issues

Platform:
Ubuntu 21.10 LTS 64bit
Obsidian 0.12.19
The Obsidian application needs to launched with the working directory set to root '/' for this plugin to work correctly because it attempts to open external programs with a root relative path (i.e. no initial /). If you launch from your home directory it will attempt to open with with a root relative link and thus yield an invalid path e.g. /home/matt/home/matt/notes/interesting.md
Current workaround compatible with most DE: one can specify the working directory for the menu entry
➜  ~ more .local/share/applications/menulibre-notes.desktop
[Desktop Entry]
Version=1.1
Type=Application
Name=Notes
Comment=obsidian notes
Icon=applications-other
Exec=/home/matt/Dropbox/tools/Obsidian
Path=/
Actions=
Categories=Office;
StartupNotify=true
➜  ~

Hey @phibr0! I know this is an old issue but the reason for this behaviour is that you're normalizing the app.vault.adapter.basePath. The Zotero Integration plugin recently had the same issue where images were created in nested home folders and after some head scratching we found out that this is the culprit. If you drop the normalizePath, it should work again for all users.
getAbsolutePathOfFile(file) {
        //@ts-ignore
        const path = `${this.app.vault.adapter.basePath}/${file.path}`;
        if (obsidian.Platform.isDesktopApp && navigator.platform === "Win32") {
            return path.replace(/\//g, "\\");
        }
        return path;
    }

Made a pull request to fix this (#19).


Integer arg being ignored

How to reproduce
add 2 arguments to ur command. the first one has to be type string and the second one has to be type integer. now try to use the command like this: !command 12345 hello. it will then prompt you to type the second arg again, which if you do and console.log() both args the integer one will return NaN. Also while doing this the integer type in this case isn't even ran once, I tried it by logging inside of the type itself.

After testing some more stuff it seems that this will only happen if you use validate with the integer arg. and the parse() function in the integer.js file gets called but validate doesn't.

The arguments order matter.
What is happening is the first parameter is been treated as string "12345" and the second parameter "hello" is not an integer, so the Commando type integer.js can't parse (it parses as NaN as expected), so it asks again.


finish initial support for probabilistic forecast reports

[ ] Closes #266  .
[ ] I am familiar with the contributing guidelines.
[ ] Tests added.
[ ] Updates entries to docs/source/api.rst for API changes.
[ ] Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[ ] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Reports work with ProbabilisticForecast and ProbabilisticForecastConstantValue with axis='y', though they are not pretty. Smaller legend text would help.
I think, but haven't tested, that reports will work with axis='x' but the plots will be mislabeled.
I've not fixed the links in the pdf report.

This gist shows a time series plot with a mix of ProbabilisticForecast and ProbabilisticForecastConstantValue on both the x and y axis.
The y axis lines are good for ProbabilisticForecastConstantValue but a ProbabilisticForecast should probably have filled areas. That would require propagating even more metadata in timeseries_meta_df. An alternative might be building different timeseries_value_df, timeseries_meta_df for each set of obs, ProbabilisticForecastConstantValue, and ProbabilisticForecats in a report, and then passing those to plotly_figures.timeseries with a few more kwargs. In any case, it also requires fighting plotly's fill feature so I'm -1 on it for initial implementation.
Maybe (likely) there is a better way plot the x forecasts on the time series plot, but I can't think of it. Maybe we should stop trying to cram it into a single plot and we need a separate plot for probability vs time. This would require modifications to plotly_figures.timeseries_plots and the templates to make the 3rd plot optional.

@alorenzo175 feedback on the possible directions of this PR would be useful at this point.

That plot is very hard for me to understand. Definitely would be helpful to separate the 'x' axis ones into a probability vs time

PR now separates plots into obs/deterministic/y-axis-prob

and x-axis-prob

@alorenzo175 this is ready for a review. I'm avoiding modifications to the pdf reports until the html is figured out.

The gist now has an html file with the rendered report for a set of forecasts that includes axis = x and y.

PDF links now work (tested locally).
I added a couple of tests to test_cli.py for probabilistic forecasts. The first has only forecasts on y axis - this makes a report with just the variable vs time plot and the scatter plot. The second has forecasts on both x and y - this adds the probability vs time plot. I confirmed that they render correctly by inspecting the output of the test functions. I could add a test to test_plotly_figures for the json/None behavior of timeseries but that function is not currently explicitly tested, probably because it relies on a report object that is a pain to construct.
The untested line in the diff was not tested before this PR.

Added a new test for timeseries_plots to check that str, str, None is returned for the conftest.raw_report. Do we need a test for str, str, str based on a new conftest.raw_report_xy or some other method? Also added a new test for the naming function.

Added a new test for timeseries_plots to check that str, str, None is returned for the conftest.raw_report. Do we need a test for str, str, str based on a new conftest.raw_report_xy or some other method?

I guess it wouldn't hurt?

@alorenzo175 here's the last test. this copy pasta pairs nicely with an IPA.

good with me


Amazon music cannot be played for more than 3 hours

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

Amazon music cannot be played for more than 3 hours
What is the expected behavior?

Amazon music should be played for more than 8 hours
What behavior are you observing?

Amazon music playback stops after 3 hours
Provide the steps to reproduce the issue, if applicable:

Say "Alexa play top hits of this year"
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.12.0>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[x ] Other - tell us more:
amazon-music-stop-after-3hours.log

Tell us about your OS (Type & version):

[ x] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @maidisula, thanks for reporting this.  A couple of comments - first, I notice you're on 1.12.  Could you update to our recent 1.16?  I know we have fixed various issues over recent releases, and the root-cause might be addressed by one of those.
Second, I note the following error trace in your log:
2019-11-15 10:40:42.406 [9] E MediaPlayer:validateSourceAndIdFailed:reason=sourceNotSet
Does this occur whenever you can replicate?
I do suggest you update to 1.16 then try replicating again though.  Let us know if that's helpful.

Hi @dhpp,

Second, I note the following error trace in your log:
2019-11-15 10:40:42.406 [9] E MediaPlayer:validateSourceAndIdFailed:reason=sourceNotSet
Does this occur whenever you can replicate?

This error log will appear every time after the song finished playing, so the log is not the reason why amazon music stop playing after 3 hours.
I will update to 1.16 to check it, thank you very much.

Closing due to inactivity. Please re-open if the issue still exists.