Buffer Overflow Pixels in Android

Hello Amir, congratulations for the work on the UI. Very beautiful.
I ran this project on Flutter 3.7 for Android and found oveflow buffered in 41 pixels on the home screen..
I solved the problem with SingleChildScrollView as follows:
Code:
@override
Widget build(BuildContext context) {
return SafeArea(
child: Scaffold(
drawer: mainDrawer(3),
appBar: const MyAppBar(),
body: SingleChildScrollView(
child: Padding(
padding: const EdgeInsets.all(7.0),
child: Column(
children: [
const TopTextWidget(),
TabBar(),
const MiddleSaladsPageView(),
const BottomSaladGridView(),
],
),
),
),
),
);
}
}
If you have a better solution to the problem I would appreciate it if you share.
I didn't take the liberty of creating a branch in the project with all the changes made. I can do it if you authorize it.
Thank you and disposition!
Wagner R Araujo

Hi, Wagner R Araujo,
Many thanks for fixing it and helping the project improve, I really appreciate it❤👍

Hello Amir, congratulations for the work on the UI. Very beautiful.
I ran this project on Flutter 3.7 for Android and found oveflow buffered in 41 pixels on the home screen..
I solved the problem with SingleChildScrollView as follows:
Code:
@OverRide Widget build(BuildContext context) { return SafeArea( child: Scaffold( drawer: mainDrawer(3), appBar: const MyAppBar(), body: SingleChildScrollView( child: Padding( padding: const EdgeInsets.all(7.0), child: Column( children: [ const TopTextWidget(), TabBar(), const MiddleSaladsPageView(), const BottomSaladGridView(), ], ), ), ), ), ); } }
If you have a better solution to the problem I would appreciate it if you share. I didn't take the liberty of creating a branch in the project with all the changes made. I can do it if you authorize it.
Thank you and disposition!
Wagner R Araujo

It would be great if you could pull request this issue and I will add you to the contributors list👍


Natron broken in 20.09

Describe the bug
It's impossible to install natron as the package is marked as broken.
To Reproduce
Steps to reproduce the behavior:

add natron to systemPackages
rebuild

Expected behavior
Package added to system as usual
Screenshots
[nix@nixos:~]$ sudo nixos-rebuild switch
building Nix...
building the system configuration...
error: --- ThrownError --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix-build
Package ‘natron-2.1.9’ in /nix/store/h56h9jaa88b5mhwmg7hqn2w426ljg63c-nixos-20.09.1469.13d0c311e3a/nixos/pkgs/applications/video/natron/default.nix:118 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use '--show-trace' to show detailed location information)

Notify maintainers
@puffnfresh
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.8.16, NixOS, 20.09.1469.13d0c311e3a (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 3.0pre20201020_e0ca98c`
 - channels(root): `"nixos-20.09.1469.13d0c311e3a"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

note: it seems to work when installed via flatpak (fr.natron.Natron on flathub)


Enable copy elision by supporting symlinks in /pfs/out

Fix #1784

1 comment you may wanted to address about a lingering Printf other than that looks good to me.


Add undo swipe feature

A nice feature to have would be the ability to call "undo" on the cardController and have the last swiped card return to the top of stack, animating from the side it was swiped to.

did you find a way to implement this? @barees63

Not yet..

Have to admit, this is an important feature. But it's not easy to implement on the current code, so i will finish it in free time. If you are in urgent need, you can fork or pull request ：）
I will try my best to help you on any problem in this lib.

Have to admit, this is an important feature. But it's not easy to implement on the current code, so i will finish it in free time. If you are in urgent need, you can fork or pull request ：）
I will try my best to help you on any problem in this lib.

I need very urgent for this feature. I gonna try to implement it. I need your direction just for saving time is it possible to get back card in the card stack or not?

https://www.dropbox.com/s/yy5ymm8czviqb9s/F9291707-232E-48AA-B9FD-B0A05EF5BA31.MP4?dl=0

@ShaunRain any updates?

I manage to do that
Sent from my iPhone
On 16 Dec 2019, at 11:59, RomanSoviak<EMAIL_ADDRESS>wrote:

@ShaunRainhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FShaunRain&data=02|01||6779bdc7ea4e4149e99708d7820eae6e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637120871867988817&sdata=VR8McDbVRsBSTgTJDJLH%2FiSk4X1nJoOj2LkA0VKPWeU%3D&reserved=0 any updates?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FShaunRain%2Fflutter_tindercard%2Fissues%2F9%3Femail_source%3Dnotifications%26email_token%3DAAFTVL56SCGFNEAY5DZJJCLQY5GRDA5CNFSM4ILERUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6FANQ%23issuecomment-565989430&data=02|01||6779bdc7ea4e4149e99708d7820eae6e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637120871867998828&sdata=XbPVGGjaw3LDX349I8rbMepDssfHcSBS0EoOQKQzvTc%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAFTVLZY46XFWK4EVAW5QNTQY5GRDANCNFSM4ILERUUQ&data=02|01||6779bdc7ea4e4149e99708d7820eae6e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637120871868008833&sdata=LrfPztGaDjyVQBDPQ7YxgtuOxU3ScSf6M9FLv1m8z8E%3D&reserved=0.

Hey Guys! Any update? Did anyone crack through?

Hey anyone has an update on this

Is anyone get a solution for this.

anyone has an update???


Remove trailing whitespace in Code

While reviewing the code to ensure an interoperability issue, I dove into the source. I found my answer (mail does the right thing, by not caring about TLS itself, but delegating this to configuration and OpenSSL) and I also found a lot of trailing whitespace.
Since I dislike that I let rubocop auto-correct that for me and commited the results.
I intentionally did not push a new dependency on you. That would be a hugely different PR and discussion.
This, however, should be easy to merge and help future PRs to stick to the CONTRIBUTING guidelines.

Rebuilt the PR in https://github.com/mikel/mail/pull/1510 to handle merge conflicts.  Thank you @kronn !


Pin opt-out

I bought a few Club Mates today with Zap, awesome!
However I find the pin prompts very annoying, especially when making a payment. My phone is worth 20x more than the coins in my Lightning wallet, and my phone already has a pin; no need for an extra pin.
It would be great if the app allowed you to not use a pin. Except maybe for sensitive stuff like revealing the mnemonic.

if anyone want's to pick this up:
send authentication currently happens here:
https://github.com/LN-Zap/zap-iOS/blob/e9bdc5edbab7b02e02a05a85c8719ca3e0adf3f7/Library/Scenes/ModalDetail/Send/SendViewController.swift#L162
i would just add an item to the settings to toggle authentication. similar to how it's done in this pr: https://github.com/LN-Zap/zap-iOS/pull/274
extra points for adding a UISwitch to settings. 🙃

I'm working on this one 👨💻


Test for alt+ctrl+I (file import) dialog box to be in forefront

I have observed - the open file dialog box (activated by ALT+CTRL+I) goes into background and I have to do alt+tab to look for this dialog box.
#version 2.0.2

Haven't had single instance where dialog opens in background. Works fine

Thanks !


Bug [Bean Validation]: Compilation error with array of strings with validations

Reproducer for https://github.com/quarkiverse/quarkus-openapi-generator/issues/925

Hi! Thank you for reporting this bug. Do you plan to append this PR with the fix?

Do you plan to append this PR with the fix?

That depends a bit on my availability in the next few weeks, but definitely not this year anymore. 😅
If you're already in the code base and don't have to learn about it, I'd appreciate somebody else fixing this bug.


Fix failing doctest

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5e5513a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #96   +/-   ##
=========================================
  Coverage          ?   96.82%
=========================================
  Files             ?       12
  Lines             ?      694
  Branches          ?        0
=========================================
  Hits              ?      672
  Misses            ?       22
  Partials          ?        0

Impacted Files
Coverage Δ

src/parsing.jl
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5513a...51145dc. Read the comment docs.


More request and response timestamps

Currently, there are just 2 timestamp attributes for a request in Mixer:
request.time
response.time
In contract, Apigee metrics uses a much more granular breakdown of request and response timestamps:
client received start time
client received end time
target sent start time
target sent end time
target received start time
target received end time
client sent start time
client sent end time
In other words, Apigee creates a bracket of the start + end timestamps for the ingress and egress of the Apigee proxy. I believe it would be useful to track these 8 timestamps for Istio as well. In fact, I believe these should likely be tracked for each service in Istio... not just the ingress and egress. Especially as we look toward workflows that encompass multiple services, I believe the value of this would be clear.
(FYI, details description Apigee of the attributes here: https://docs.apigee.com/api-services/reference/variables-reference)

This sounds like trace spans around every hop, is that correct?

Yes

I don't believe this should be considered stale without additional discussion.

I also find context.time and request.timestamp insufficient. The stale bot aggressively closes issues unless it's tagged help wanted, so I'm going to do that.

This issue came up in a different context yesterday. The use case presented in that scenario was the need to understand "total time added by the istio proxy". In other words, there was a request to know:

time proxy received the first byte from the client
time proxy sent the first byte to backend
time proxy received the first byte from the backend
time proxy sent the first byte to the client

I think that this information is already available. Hopefully, we can add a few attributes and send this information along to Mixer.

Relevant envoy code: https://github.com/envoyproxy/envoy/blob/329e591d3f579535412daade4c3249b7c4ed7619/include/envoy/request_info/request_info.h#L110-L197

@theganyo with the transition to v2, i believe those timestamps should now be more readily available. i'm gonna close this issue, as v1 is not going to receive any new functionality in this area.  I'm sorry we couldn't provide more when Mixer was still an on-going concern.


overriding primary_key column name

how to rename the "id" column name, provide my own PK column name?

Hey @dara-na 😃
You can use the field.StorageKey option. Please see an example in integration tests:
https://github.com/ent/ent/blob/31ec081b0e0bb935626a7bbec6eebbaf4306cdce/entc/integration/config/ent/schema/user.go#L38-L39
Would you mind adding this question to the FAQ page in our website? Thanks 🙏

Sure ... That would be a pleasure


EKS addon integration test

Issue #, if available:
Description of changes:
Added the integration test for eks addon
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is there a sample test run that shows that this passes?

Is there a sample test run that shows that this passes?

https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/6122765468

Latest successful job run : https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/6167328682/job/16738119079#logs

Will update all the nits in other PR as other story is waiting on this Merge


Debug PostProcessor?

Having a Debug PostProcessor would be cool!
Sample code:
https://github.com/pragmatictesters/Pragmatic-Learning-JMeter-Examples/blob/master/TestPlan-StackOverFlow-68706730-JSON.jmx
thx

Done in #108


Karma: run on CI

Summary
Partial for #1721.
~Blocked by #1809 for the Percy part.~
Relevant Technical Choices
Does not include coverage reporting just yet.
Makes files compatible with current Node v14 setup.
To-do
For follow-up coverage.

[ ] Actually make code coverage working

Right now no coverage file is generated. But there's at least a summary in the console.
Is babel-plugin-istanbul needed?

User-facing changes
N/A
Testing Instructions
Verify that GitHub actions workflow here is running successfully.

See #1721

There are some warnings but also test failures on CI:
Chrome Headless 83.0.4103.0 (Linux x86_64) TextEdit integration add a text edit mode should handle a commnad, exit and save FAILED
	Error: Expected false to equal true.
	    at <Jasmine>
	    at UserContext.<anonymous> (webpack:///assets/src/edit-story/elements/text/karma/edit.karma.js:107:36 <- elements/text/karma/edit.karma.js:45844:36)
	Error: Expected 'hello world!' to equal 'hello world!'.
	    at <Jasmine>
	    at UserContext.<anonymous> (webpack:///assets/src/edit-story/elements/text/karma/edit.karma.js:117:64 <- elements/text/karma/edit.karma.js:45851:64)
	Error: Expected 'hello world!' to equal 'hello world!'.
	    at <Jasmine>
	    at UserContext.<anonymous> (webpack:///assets/src/edit-story/elements/text/karma/edit.karma.js:122:33 <- elements/text/karma/edit.karma.js:45853:33)


LE Audio: BAP: Split CIS connection from bt_bap_stream_start

Is your enhancement proposal related to a problem? Please describe.
The bt_bap_stream_start function used by the BAP unicast client currently does both the CIS connect and the ASCS receiver start ready operation. Since these are 2 different procedures, and that the ASCS start operation can also be done by the Unicast server for sink ases.
Describe the solution you'd like
Implement a bt_bap_stream_connect function that does the CIS connection, independently on the start function. This should be allowed in the QoS and the enabling state.
Describe alternatives you've considered
N/A
Additional context
This is blocking a handful of PTS tests as there are some test cases for connecting the CIS in the QoS configured state

@sjanc you can refer to this issue in the results log


[Feature Request] Auto shuffle for URL-based playlist

Is your feature request related to a problem? Please describe.
In my channel, there aren't predefined file-based playlist. People have favorites youtube playlists URL's and they always have to manually shuffle playlist after each time they put play command.
Describe the solution you'd like
guild-level configuration something like always_shuffle
Describe the basic flow/steps of using this feature
How this feature would be used:

Set always_shuffle = true in serversettings.json
Enjoy the time saved from typing 'shuffle' command :)

Additional context
Title says 'URL-based playlist' just to clarify that I do not use file based playlists. However, I think for consistense sake such property like always_shuffle could work as default for all types of playlists.
Have you confirmed that this idea is not already described here?
https://github.com/jagrosh/MusicBot/projects/1
Yes

Other bots (I think it was Groovy) allowed play + shuffle in the same command using an additional flag-like argument:
-play -s https://...

There was also stuff like -j for skipping the current queue and jumping directly.

Use case: I use Discord to DM RPGs and every time there is a scene change, I have to

Change the map on Roll20
Clear the Queue
Play the new Playlist
Shuffle
Do all the other game-related DM things.

If I could squish steps 2-4 into one single copy-pastable message to send I'd be very happy.


CouchDb is unreachable from CLI

Describe the bug
There appears to be a SSL error while reaching my CouchDB instance, at https://db.tommi.space.

Context

Hardware: VPS bought online
YunoHost version: <IP_ADDRESS>
I have access to my server: Through SSH and through the webadmin
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no

Steps to reproduce

From a remote client, run curl -X GET https://db.tommi.space/_all_dbs
the resulting error is curl: (35) error:1400442E:SSL routines:CONNECT_CR_SRVR_HELLO:tlsv1 alert protocol version
Same goes for any PUT request

Expected behavior
All of my databases should be returned.

Logs
I effectively installed a Let’s Encrypt certificate for the domain, the log is here

Couldn't reproduce your issue. Do you still have the problem?

thanks for getting back, @eauchat. Yes, I am still experiencing some trouble

I don't know how to help you. I'm wondering if the issue is related to couchdb, this package, or yunohost directly Maybe if you have an idea of what more context or related logs you can provide, someone here or on the forum may have some good idea.

The https parameters comes from YunoHost and have been updated when migrating from buster to bullseye
You should retest


updating dockerhub

In the past the docker image on dockerhub was connected to bitbucket.
It seems not easily possible to change this repository to github.

it was not possible to add an openmss organization to the exiting account and using new credentials. I guess in the database the name openmss is currently blocked. For testing I created an yourmss account on dockerhub.
A new user open-mss-build for accessing the repository was created and has read access to open-mss. This blocks dockerhub to have full access on anything I have access on github.
For some reason dockerhub needs a repository under https://github.com/open-mss-build
This needs further investigations. I added the content of dockerfiles there and tried a testbuild of 2.0

it was not possible to add an openmss organization to the exiting account and using new credentials. I guess in the database the name openmss is currently blocked. For testing I created an yourmss account on dockerhub.
A new user open-mss-build for accessing the repository was created and has read access to open-mss. This blocks dockerhub to have full access on anything I have access on github.
For some reason dockerhub needs a repository under https://github.com/open-mss-build
This needs further investigations. I added the content of dockerfiles there and tried a testbuild of 2.0

A site notice, It is not possible to have in the same browser window docker hub connected to another github repository than the defined. e.g. yourmss / mss connected to defined open-mss-build does not work with me logged in in another tab/window.

A site notice, It is not possible to have in the same browser window docker hub connected to another github repository than the defined. e.g. yourmss / mss connected to defined open-mss-build does not work with me logged in in another tab/window.

recognized that the dockerhub github user needs admin rights in the repository below Open-MSS.
dockerhub moved to the Organization added open-mss-build as admin to this repository.
Trying a build

recognized that the dockerhub github user needs admin rights in the repository below Open-MSS.
dockerhub moved to the Organization added open-mss-build as admin to this repository.
Trying a build

starts the demo wms server
docker container run --net=host --name mswns yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mswms
starts the mscolab server
docker container run --net=host --name mscolab yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mscolab start

mss client needs further investigation
docker container run --net=host --name mss yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mss
libgcc_s.so.1 must be installed for pthread_cancel to work

starts the demo wms server
docker container run --net=host --name mswns yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mswms
starts the mscolab server
docker container run --net=host --name mscolab yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mscolab start

mss client needs further investigation
docker container run --net=host --name mss yourmss/mss:2.0.0 /opt/conda/envs/mssenv/bin/mss
libgcc_s.so.1 must be installed for pthread_cancel to work

always when it crashes a file /root/.cache/matplotlib/fontlist-v330.json.matplotlib-lock is created.

always when it crashes a file /root/.cache/matplotlib/fontlist-v330.json.matplotlib-lock is created.

sometime after mswms on a terminal shell was executed this file also gets created and the mswms server crashes too. After deleting the lock file, the gui can be executed.

sometime after mswms on a terminal shell was executed this file also gets created and the mswms server crashes too. After deleting the lock file, the gui can be executed.

The  continuumio/miniconda3 seems to force a bit other dependencies too.
I can't upgrade to py-3.9 because argon2_cffi is in that package mandatory and it is not yet available for py-3.9

The  continuumio/miniconda3 seems to force a bit other dependencies too.
I can't upgrade to py-3.9 because argon2_cffi is in that package mandatory and it is not yet available for py-3.9

currently added the exact build name it has to install. This behaviour is also different to a common installation.

currently added the exact build name it has to install. This behaviour is also different to a common installation.

libgcc_s.so.1 must be installed for pthread_cancel to work
was solved by adding a sleep timer, so it gets off the lock state

libgcc_s.so.1 must be installed for pthread_cancel to work
was solved by adding a sleep timer, so it gets off the lock state


Go Live Checklist: Road Choice Mexico

 @ZoeBeykirch cloned issue hlxsites/vg-roadchoice-com#258 on 2024-07-22:

Description:
Establish a new Spanish-language website for the Mexican market under Road Choice, with potential for future English language support. These separate tickets should help streamline the development and testing processes for each market site while ensuring clarity in responsibilities and outcomes.
Related tickets:
https://github.com/hlxsites/vg-roadchoice-com/issues/222
Acceptance Criteria

[x] Create dedicated SharePoint folders for Mexico - vg-roadchoice-mx

[x] Translations of the content sent to proof reading

[ ] Translations approved/verified

[ ] Setting up the constant file configs

[x] Translate placeholder file

[ ] Setting configs for each location. This might be done by Darin but must be confirmed that everything is in place.

[ ] Manage separate product data catalogs in Excel sheets tailored to Mexico's offerings.

[ ] Manage dealer locator for Mexico market (translations will be handled in a separate ticket)

[ ] Mirror the structure of the USA website for the Mexican market site, other than the product categories which will only have the following:

Engine Cooling - Part listings for Radiators, Charge Air Coolers, Fan Clutches, Fan Clutch Kits, and Fan Clutch Valves

Suspension - Part listings for Air Springs

Engine - Part listings for V-Belts

Electrical - Part listings for Batteries

[ ] Approval from @janedbarra and team to go live

Out of Scope
#233 for dealer locator translations will be handled after Go Live

 @janedbarra commented on 2024-07-24:

@BeckyMedlin - I can't think of anything else to add. Only comment I have is on this item " Mirror the structure of the USA website for the Mexican market site." The structure should be the same but I have listed out the product categories that are specific to Mexico (they won't have everything that our current site includes).
For Mexico, I would only want to have the following category pages copied over for the .mx site:
•	Engine Cooling
o	Part listings for Radiators, Charge Air Coolers, Fan Clutches, Fan Clutch Kits, and Fan Clutch Valves
•	Suspension
o	Part listings for Air Springs
•	Engine
o	Part listings for V-Belts
•	Electrical
o	Part listings for Batteries

 @BeckyMedlin commented on 2024-07-24:

@janedbarra Please review this go-live checklist and advise if anything else needs to be added. Thank you!

 @ZoeBeykirch commented on 2024-07-24:

@janedbarra Thank you! I have updated the ticket to include this :)

Kamino cloned this issue to hlxsites/vg-roadchoice-com

Kamino cloned this issue to hlxsites/vg-roadchoice-com

Kamino cloned this issue to hlxsites/vg-macktrucks-ca

Testing completed has been completed.
The only subtask that remained untouched is:

Dealer locator not in Spanish**(?)** - https://main--roadchoice-mx--volvogroup.aem.live/where-to-buy

There was no change as there is no Dealer Locator feed that is available in Spanish, as such, it is not an issue on content side.


TypeError: Cannot read property 'prototype' of undefined

I've this error in the console
  const translate = require('google-translate-api');

  translate('Ik spreek Engels', {to: 'en'}).then(res => {
    console.log(res.text);
    //=> I speak English
    console.log(res.from.language.iso);
    //=> nl
  }).catch(err => {
    console.error(err);
  });

=> TypeError: Cannot read property 'prototype' of undefined

hey @micktaiwan , I have the issue with an Ionic2 app (angular 2). Did you get this resolved ? If so would you mind telling me the process.
thanks :)

No, sorry, I didn't solve it. I was just testing the lib.

Hi @micktaiwan @sameera207 , i have same issue :(   Did you solve it ?

i think it's about this code => const translate = require('google-translate-api')

Hey guys,
 Any luck in finding solution ?

I have not found a solution for a month.

I got the same error when trying to run this on the client.. running it on the server worked.


ProgressMonitor: Handle failure of partition

Modification of previous https://github.com/pinterest/secor/pull/1252 after discussion with @HenryCaiHaiying

The change on SecorKasfkaClient.java looks fine but I am not sure whether we should remove the RuntimeException handling in ProgressMonitor.java, there might be other places which can still throw NPE.

Corrected

Looks good, thanks for the contribution.


fix: mock.js NOOP to allow for "new" constructor call

i'm getting errors in my tests from this mock as the new Value(0) call throws for arrow functions, this seems to work when i updated my mock.js in node_modules.

note -- this can also be fixed w/ babel by adding react-native-reanimated to transformIgnorePatterns jest config


Passing a PHP expression with an incomplete set of parentheses to a component results in an exception

Versions

Laravel Version: 9.18.0 (Also tested on 9.2.0 and 8.71.0)
PHP Version: 8.1.1 (zend engine 4.1.1, opcache 8.1.1, xdebug 3.1.1)
Database Driver & Version: PDO MySQL 5.7.34

Description:
When I pass a PHP expression which contains an incomplete set of parentheses to a component, the resulting rendered template contains invalid PHP.
While the testcase is minimal, the same thing also occurs when passing the parentheses to a string for translation:
for example __('(error')
Steps To Reproduce:

create a view-only component that accepts a prop php artisan make:component Component --view
include the component and pass a php value containing a incomplete set of parentheses:

<!-- This results in an 'syntax error, unexpected token "endif", expecting end of file' Exception -->
<x-component :value="'(error'" />
<!-- This results in an 'syntax error, unexpected identifier "component", expecting "]"' Exception -->
<x-component :value="'error)'" />
<!-- This works -->
<x-component :value="'(works)'" />

Repository displaying the bug
https://github.com/tkuijer/blade-stringbug

This is best passed a variable.

@driesvints
That would work for the example minimal breaking case, but is unusable when building a form that has translations for example.

In my opinion something as simple as...

PRs are welcome =)


Remove Tag class and make Role class standalone from Tag

Resolves #106

Codecov Report

Merging #129 into master will decrease coverage by 0.26%.
The diff coverage is 72.00%.

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     70.04%   69.77%   -0.27%
+ Complexity      863      854       -9
============================================
  Files           138      137       -1
  Lines          2984     2971      -13
  Branches        411      408       -3
============================================
- Hits           2090     2073      -17
- Misses          769      775       +6
+ Partials        125      123       -2

Impacted Files
Coverage Δ
Complexity Δ

...java/mcscheduler/logic/commands/AssignCommand.java
90.38% <ø> (ø)
14.00 <0.00> (ø)

...mcscheduler/logic/commands/CancelLeaveCommand.java
89.74% <ø> (ø)
12.00 <0.00> (ø)

...n/java/mcscheduler/logic/commands/CommandUtil.java
88.46% <ø> (ø)
12.00 <0.00> (ø)

...scheduler/logic/commands/MassTakeLeaveCommand.java
95.74% <ø> (ø)
17.00 <0.00> (ø)

...va/mcscheduler/logic/commands/ReassignCommand.java
77.58% <ø> (ø)
15.00 <0.00> (ø)

...ava/mcscheduler/logic/commands/RoleAddCommand.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../mcscheduler/logic/commands/RoleDeleteCommand.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...va/mcscheduler/logic/commands/RoleListCommand.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...a/mcscheduler/logic/commands/ShiftEditCommand.java
62.50% <ø> (ø)
15.00 <0.00> (ø)

...a/mcscheduler/logic/commands/TakeLeaveCommand.java
100.00% <ø> (ø)
9.00 <0.00> (ø)

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962e615...3751942. Read the comment docs.


[ISSUE #3013] conversion between string and byte, charset explicitly …

…specified

Fixes #<3013>.
Modifications
Describe the modifications you've done.
explicitly specify charset, string conversion to bytes

…specified
Fixes #<3013>.
Modifications
Describe the modifications you've done. explicitly specify charset, string conversion to bytes

Fixes #<3013> To remove '<>', you need to fill in #XXXX to associate it.


CustomGap doesn't affect the final size of presented view

I'm trying to place UI component depending of the size of the presented view, for instance having a button at the bottom of the drawer.
When testing it, it seems that the size of the presented view is never matching the size left from the custom gap. For instance, if I set a .leavesCustomGap(gap: 100), the view presented frame won't get shorter of 100. Therefore any elements at the bottom might not be visible.
I guess what I would expect is that if the drawer can have a maximum size of 500, its presented view and contained one would reflect the same size. That's not the case at the moment. Is it something available with DrawerKit?
To replicate it, inspect the view frame in a presented view controller (in viewDidAppear for instance), it will be the size of the screen regardless the maximum size available of the drawer.

Indeed the position of the drawer in the fully expanded state is fixed and it does not consider the content. I have a similar issue, where I have to use partially expanded state to accommodate the content but there is no way then to disable fully ex expanded state

@popei69 is your issue that the drawer is not respecting the content size of the presented view or the other way around, that the content view is not respecting the size of the drawer?
To avoid having not visible elements you can try to put them in a scroll view. DrawerKit has support for that (see demo app) so that it works fine in terms of scrolling behaviour.

@ilyapuchka thanks for the feedback. The idea is actually to have a sticky button at all time at the bottom of the drawer regardless how far it is open, or at least when half opened and fully opened. But the rest of the page would still be scrollable. To give you an idea, I'm looking for a similar behaviour as the Instagram Share Post feature.
I just can't see a way to do that with AutoLayout and DrawerKit at the moment with a content size always describing the whole screen.

yep, I think out of the box it's not supported. You could try to hack in with animation behaviour, but I doubt it will really help.
I doubt it will work nicely with autolayout but you could make update the frame of the button manually somehow.
Speaking of autolayout it would be handy if drawer kit would provide some kind of layout guides that one could use to attache views to, or if it would adjust safe are of views involved in the presentation. For instance I had an issue when the button should be displayed in the repenting (background) view right above the drawer, it would maybe make it simpler if safe area of presenting view would be adjusted by the drawer, so that when it appears the button slides to the top with it. It might be tricky to make it universal though, but just adding layout guides in the drawer would help in your issue.
cc @inamiy @Ben-Henshall


[Proposal] Release labels for OpenSearch project releases

Description
The purpose of this PR is to propose what labels to use (e.g., Alpha, Beta, Release Candidate, Generally Availability) when releasing new OpenSearch versions. The goal is to remove ambiguity going forward on how OpenSearch labels new versions. This has been added to the README.
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

You can turn this PR into a "Draft", this way it won't get accidentally merged.

@elfisher You should fix DCO and I propose we merge this.

@elfisher You should fix DCO and I propose we merge this.

Sounds good I'll take care of that.

@dblock, @stockholmux, @peterzhuamazon it's showing merging is blocked. I've updated the PR to try to incorporate all the feedback. Can you review/approve? I'd like to merge soon if possible.

Good! I have some cosmetic asks, please and we can merge.

ack I'll take a look.

@stockholmux are you good with the PR? There were a couple concerns you originally had.

@elfisher It's not my favourite, but some hills are made for living.


Fix some issues with stories

Hi! First off, nice library, it looks great.
We used this for a hackathon for our app to implement stories, and we discovered a few issues, so I hope it's OK that I'm opening a PR with some suggestions for fixes.
I might also have a few UX suggestions/features/refactors that I will suggest in future PRs/issues.
This PR fixes the following:

When renderContent is passed, the close button does not work. Fixed by setting pointerEvents="box-none" on the content view.
Image.prefetch is called even if the story is a video, which gives an error as it cannot decode the Video data.
A bug in onImageChange: when going back to the previous user, the "progress" animation is always reset, but sometimes the image does not change. This is caused by the active state not always being true before the activeStory state changes. I fixed this by removing the early return if active.value is not true. I don't think this check is necessary, since  we return immediately after if the story matching the activeStory is not found.

I think there's similar bugs to 3. with some of the other components, like the content, header, maybe progress?  Just didn't notice it before, but the same issue is there because of the isActive state race condition.

Perhaps a more general fix for the issue with the isActive state would be to derive the userIndex from the currentStory value, instead of the x position?
Something like this
    const userIndex = useDerivedValue(() =>
      stories.findIndex((user) =>
        user.stories.some((story) => story.id === currentStory.value),
      ),
    )

Hello thanks for using and contributing our lib! appreciate it! we will check the active prop problem and let you know, other thinks looks fine.


[NOT-ISSUE] No issue here. Just thank you for your work

Thanks to all contributors for that awesome component. It has saved me huge amount of time.
Best,
Peter

Thanks!


Setting task JDK version

My project uses java 17 but I want to run a 1.21 server which requires java 21, I saw mention of setting a java launcher in another issue but was unable to work out what exactly I needed to do to set the java launcher.

Look in the debugging section of the wiki for an example. But you do not need to use an old JDK to compile for J17, use the release compiler flag.


Build fails

Dockerfile
FROM thevlang/vlang

RUN apt-get update && \
    apt-get install curl -y && \
    apt-get install unzip -y

RUN curl -L -o vls.zip https://github.com/vlang/vls/archive/master.zip && \
    unzip vls && \
    cd vls-master && \
    v -prod cmd/vls

Output:
 v -v cmd/vls
...
builder.cc() pref.out_name="/workspaces/v-vscode-remote-development-template/vls-master/cmd/vls/vls"
build_thirdparty_obj_files: v.table.cflags: [CFlag{ name: "-I" value: "/opt/vlang/thirdparty/cJSON" mod: "json" os: "" cached: "" }, CFlag{ name: "" value: "/opt/vlang/thirdparty/cJSON/cJSON.o" mod: "json" os: "" cached: "/root/.vmodules/cache/9d/9d98e153e152effa36bc10350274dcac.o" }]
cc() isprod=false outname=/workspaces/v-vscode-remote-development-template/vls-master/cmd/vls/vls

=====================
> C compiler cmd: /opt/vlang/thirdparty/tcc/tcc.exe<EMAIL_ADDRESS>=====================
519.632  ms C tcc.exe
>> remove tmp file: /tmp/v/vls.3261355545972556428.tmp.c
>> remove tmp file: /tmp/v/vls.3261355545972556428.tmp.c.rsp
/opt/vlang/thirdparty/tcc/tcc.exe
=========

Trying to build VLS in dev-container https://github.com/stereobooster/v-vscode-remote-development-template

I don't see any errors there.  Did you post the complete output?
I can tell you that it is usually better to clone the repo than to download a zip file - especially when there's no official zip file released.  Who knows how out of date that might be?

The docker container is running Linux and the output state “.exe”?

Please provide more details (for example provide v doctor), and an explanation of what are you trying to do exactly. It is hard to guess what is your problem and even if there is one otherwise.

especially when there's no official zip file released

Where is it? I can't find link in readme

v doctor
OS: linux, N/A (VM)
Processor: 2 cpus, 64bit, little endian, Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
CC version: clang version 7.0.1-8+deb10u2 (tags/RELEASE_701/final)

getwd: /workspaces/v-vscode-remote-development-template/vls
vmodules: /root/.vmodules
vroot: /opt/vlang
vexe: /opt/vlang/v
vexe mtime: 2021-02-06 02:12:53
is vroot writable: true
is vmodules writable: true
V full version: V 0.2.2 e83c39c

Git version: N/A
Git vroot status: N/A
.git/config present: true
thirdparty/tcc status: N/A N/A

v -prod cmd/vls
==================
/usr/bin/ld: /usr/lib/llvm-7/bin/../lib/LLVMgold.so: error loading plugin: /usr/lib/llvm-7/bin/../lib/LLVMgold.so: cannot open shared object file: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
...
==================
(Use `v -cg` to print the entire error message)

builder error:
==================
C error. This should never happen.

If you were not working with C interop, please raise an issue on GitHub:

https://github.com/vlang/v/issues/new/choose

You can also use #help on Discord: https://discord.gg/vlang

Well, there is at least part of your problem.
The official vls repo is: https://github.com/vlang/vls
Not whatever "stereobooster" has... possibly a fork, or whatever, but not the official repo.

the same with official.
git clone git@github.com:vlang/vls.git
cd vls
docker run \
  -it \
  -v ${PWD}:/src \
  --name v-dev-container \
  thevlang/vlang \
  /bin/sh
cd /src
v -prod cmd/vls

I forked it today to show issue with vscode, but it is reproducible with Docker alone.

I can reproduce the failure, which is
/usr/bin/ld: /usr/lib/llvm-7/bin/../lib/LLVMgold.so: error loading plugin: /usr/lib/llvm-7/bin/../lib/LLVMgold.so: cannot open shared object file: No such file or directory

@JalonSolov @spytheman  it seem that if I add the llvm to the images it seems to work. So two options to get the default image working with prod flag. One is installing llvm to the images (additional 128 mb) or use gcc as default prod compiler. I tried to build the llvmgold plugin separately but I really did not have time to understand how to make it work. What option seem the best for you guys?

Decided to include the llvm-dev package. Maybe we could have saved a space manually build it and include the file only but that was way too much work for now.


BuiltIn.Log Keyword Documentation contains a defect

This is rather a typo more than a bug, but in the very last line of docstring for BuiltIn.Log Keyword, there is an annotation that one can choose between type and log formatter options.
Looking at _get_formatter method ( HERE ), there is no such key in the dictionary. I believe that the latter option should be len.
Robot Framework version: 6.0.2

Looks like a typo. Thanks for a report!


more complete async support and async bug

So I got arrow-odbc (almost) working with async-polling with these two PRs: https://github.com/pacman82/arrow-odbc/pull/102 and https://github.com/pacman82/odbc-api/pull/577
But I'm running into an issue with the snowflake ODBC driver. We're using the snowflake driver, which complains that we free the statement before we've completed executing (I've concluded that based on the error message and the MS docs here (https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlfreestmt-function?view=sql-server-ver16#diagnostics).
The query seems to stream fine, but the driver fails when the inner BlockCursorPolling is dropped in the AsyncBatchedOdbcReader struct, panicking in the drop impl for BlockCursorPolling with the following error:
 Unexpected error unbinding columns: Diagnostics { record: State: HY010, Native error: 0, Message: [unixODBC][Driver Manager]Function sequence error, function: "SQLFreeStmt" }

I'm unsure how this is possible since all methods that use wait_for() do not return until StillExecuting is not returned. And if a method didn't handle StillExecuting, then it would panic here https://github.com/nobie-org/odbc-api/blob/a20309759e83ebdfbeac5c115b24b97917d6b5fd/odbc-api/src/error.rs#L244

Hello @matthewgapp ,
thanks for your effort. I took the liberty and already merged a fix for the missing enablement of async in execute polling you mentioned in #577. Please take a look at the tests and note that most drivers actually do not support polling.
It was mostly this poor support for polling (not even starting to think about event based async on windows) within ODBC drivers, which made me write ConcurrentBlockCursor which uses system threads and works reliably with many drivers.
For your use-case it seems to me worth verifying that the snowflake driver does indeed support polling.
Currently I am heavily occupied by my day job, so my ability to review large pull requests is inhibited. Splitting things out into smaller features, with their own test cases would help me. I have some further thoughts, but (again) I think the first thing to check if this is indeed actually helping you at all and snowflake supports this behavior.
Best, Markus

FYI: I just verified this is still working: If you want to execute all the tests locally you can just open it remotely in vscode in the devcontainer. It will boot up all databases and install all drivers in a devcontainer, provided you have docker compose installed.


[FEATURE] Make variable changes propagate to widgets they're passed to

Description of the requested feature
When you pass a widget defined with defwidget an argument, if you use a defined variable (with defvar, etc.), it uses the current value of that variable. I think it would be useful to make it pass the variable into the widget so that, when the variable is updated, the widget updates as well.
For my current use case, as an example, I'm using multiple windows that each have a copy of one widget in them, and I'd like each of those windows to pass their widgets a json string that will be updated with an outside script.
Here's my current use case.

; This is the only widget I'm defining. Each of the below windows uses it.
(defwidget tabbar [control] ; Control is the argument that I'd like to pass a variable, so that this widget updates when that variable sees changes.
    (box
        :orientation "horizontal"
        :space-evenly true
        (for linked in control
            (button
                :onclick "bspc node ${linked} --layer above"
                linked))))

(defvar control0 "[]") ; This variable is controlled by a Python script, a script which adds windows to the list.
; The Python script also spawns these windows dynamically (via eww open bar{n}).
(defwindow bar0
    :stacking "fg"
    :wm-ignore false
    :windowtype "toolbar"
    (tabbar :control control0)) ; Currently, this evaluates to "[]" and doesn't update once it's been evaluated.

(defvar control1 "[]")
(defwindow bar1
    :stacking "fg"
    :wm-ignore false
    :windowtype "toolbar"
    (tabbar :control control1))

(defvar control2 "[]")
(defwindow bar2
    :stacking "fg"
    :wm-ignore false
    :windowtype "toolbar"
    (tabbar :control control2))

; ...repeated an indefinite number of times (in my case 6).

I'm realizing that this could also be a feature added to eww windows themselves, since it doesn't seem like they update when a variable they're using is updated(?).
There are workarounds to this, and I'll be trying out a couple, but I think this would be a neat functionality.
Proposed configuration syntax
No response
Additional context
No response

I'm confused, the variables should very much update, otherwise there'd not be any way to have state changes at all 🤔
If changes actually don't propagate, can you send the output of eww graph and eww debug so I can analyze?

digraph {
  "ScopeIndex(8)"[label="bar0\ndata: [], listeners: []"]
  "ScopeIndex(5)" -> "ScopeIndex(8)"[label="ancestor"]
  "ScopeIndex(5)"[label="global\ndata: [('control5', '[]'), ('control0', ''[23068675]''), ('control3', '[]'), ('control2', '[]'), ('control', ''), ('control4', '[]')], listeners: []"]
  "ScopeIndex(9)"[label="tabbar\ndata: [('control', ''[23068675]'')], listeners: ['on control: [\'[\\\'control\\\']\']']"]
  "ScopeIndex(8)" -> "ScopeIndex(9)"[label="ancestor"]
  "ScopeIndex(8)" -> "ScopeIndex(9)" [color = "red", label = ":control `control0`"]
  "ScopeIndex(8)" -> "ScopeIndex(5)" [color = "blue", label = "inherits({'control0'})"]
  "ScopeIndex(9)" -> "ScopeIndex(5)" [color = "blue", label = "inherits({})"]
}

It seems like the bar window itself isn't set to listen to anything.
Here's a part of the python script that's doing the eww update, since that might be relevant if EWW is supposed to make what I want to happen work but isn't.
@dataclass
class TabBar:
    id: int
    tabs: list[int] = field(default_factory=list)

    def addTab(self, tabID: int):
        # The `tabID` is the ID of a window that's meant to be displayed
        #  by the window manager when its button is clicked.
        if tabID in self.tabs: return # We don't want to do anything if
                                      #  the window already has a tab on
                                      #  the bar.
        self.tabs.append(tabID)

        # `json.dumps` converts `self.tabs` into a string of json. String
        #  interpolation, in Python f-strings, happens in-between the
        #  curly brackets.
        args = f"update control{self.id}=\"{json.dumps(self.tabs)}\""
        # The hope is that this command makes the `for linked in control`
        #  update in the yuck file, which makes buttons (tabs) in the bar
        #  that correspond to each of the windows that have their IDs set
        #  in this object's `self.tabs`.

        # When a tab is added to an empty `TabBar`, this prints:
        #     update control0="[23068675]"
        #  with the number in the "" string replaced by whichever window
        #  ID is meant to be focused when its tab button is clicked.
        print(args)
        eww(args) # Helper function to run `eww` with the given args.

There's a good bit more to this script, but this should be the most relevant part. I'll post more if needed.

Isn't the problem that eww seems to receive control0 with extra quotes? Eww debug shows control0: ""[...]""

@viandoxdev It looks like it!
I wasn't certain on whether or not eww update required its parameter to be quoted. Python's json.dumps defaults to adding spaces in between elements, which made me think that in order to capture those spaces correctly, the parameter should be quoted. Luckily there's a way to make json.dumps compact by using the separators=(",", ":") keyword argument. I've removed the unnecessary quotes and it looks like it's working as it should. Thank you both for the help.

I thought I remembered testing both ways, but I believe I had other unfixed issues when I did the testing and neither way worked, so I continued to be unsure of which was correct.


Here was a question - about the function logic - but I realized I was not correct

Sorry I realized my question was not correct

@IlshatGaripov, you can contact the quantconnect team at Slack or support before opening issues since we can give you important insights and help you realize whether there is a logic mistake in the code. Thank you for looking into GetMaximumOrderQuantityForTargetValue.

Thank you @AlexCatarino please excuse my lack of experience I ll make sure to use the suggested chanels of contact the next time


Dialog items are out of alignment

Kind (Required)

Improvement

Overview (Required)

RadioButton and Text are out of alignment.

Links

I fixed it!
(but i don't have canaly (or preview?) android studio. so I can't build and shoot fixed screenshot yet. please wait)


Roadmap

Features for the next release

[ ] Prioritise fragments based on fast/slow response (Out of order delivery? )
[ ]  Handle Single Page Application
[ ] Avoid FOUT for async fragments

SPA discussed here #72

SW implementation can be tracked here - #81


Scrabble Score case insensitive

Use a uppercased word to test case insensitivity
fixes #272

Yeah, good call. Thanks.


Reenable pruning of v-tables

The miscompilation should be resolved by now

@nate-chandler Could you please initiate the tests?

Could you point me to the commit that fixes the issue?

@compnerd Thoughts?

Unfortunately the bug avoided by this workaround has not been corrected yet.
Re-enabling this is part of the bug-fix task list.


Support --features trusted on macOS

With this PR, PL/Rust now supports installation as a Trusted Procedural Language on macOS.
It also supports cross compiling between x86_64 and aarch64 on macOS.
We do NOT support cross-compiling between operating systems.

Thanks for making CI work on macOS, @BradyBonnette


adding a name to the mixin, so it is represented in ember inspector

As it is described in https://github.com/emberjs/ember-inspector/issues/284 one must add the name into Ember.NAME_KEY to get it to display in the inspector.

I am going to close this PR for now, feel free to reopen this PR if you feel like it's still relevant and we should take a look at it. If you do, please make sure the code is rebased against master.


[TASK] Train Yolo Model For Valve Detection

Description of task
Training
We need a robust way to detect valves during TACC. This issue is solely dedicated to training the model. Deep learning models require lots of annotated data in over to work effectively. Therefore we should start this process as soon as possible.
Generating Data
We have a 3d print of the valve at the office which can be used to generate a dataset. It might also be wise to look into the creation of a synthetic dataset in blender with automatic labeling.
Remember that the dataset should reflect real world conditions. There is a rosbag on teams from the pipeline following mission run from this summer. By looking at that one could get a feel for how the operating conditions are underwater (murky water). Sadly there are no recording of the valve manipulation task.
Suggested Workflow

Talk to @Senja20 about how to start this task. He has experience training a yolo model with Roboflow.
Roboflow is a good tool for labeling data. Should look into that.
How to Train YOLOv8 Object Detection on a Custom Dataset
Look into the possibility of creating a Synthetic  Dataset in Blender

Specifications

The valve is static, so accuracy should be somewhat prioritized over speed.
Should be able to input an image and generate bounding boxes for detections

Contacts
@Senja20
@jorgenfj
Code Quality

[ ] Every function in header files are documented (inputs/returns/exceptions)
[ ] The project has automated tests that cover MOST of the functions and branches in functions (pytest/gtest)
[ ] The code is documented on the wiki (provide link)

https://github.com/atenpas/gpd
https://github.com/lianghongzhuo/PointNetGPD
https://jeasinema.github.io/file/pointnetgpd_icra19.pdf

https://pcl.readthedocs.io/projects/tutorials/en/latest/correspondence_grouping.html

https://pcl.readthedocs.io/projects/tutorials/en/latest/global_hypothesis_verification.html#global-hypothesis-verification


Video/Broadcasting Overlap

Hi,
Just in case you're not aware, the European Broadcasting Union (EBU) also has a pre-existing awesome list of broadcasting stuff here:
https://github.com/ebu/awesome-broadcasting#readme
There seems to be quite a bit of overlap with some of the sections (e.g. video and the IP section) and I don't know what you think about merging them, or at the very least signposting heavily to the equivalent broadcasting sections.

Didn't even know this existed.. I'll probably delete the broadcast categories and link that list instead. Going to do it later today.
Thank you!


Add edit option on message board (VueJS)

Add edit option for message in message board. api to use is message/{message_id}

Hello, I am taking this issue!

@thesanjeevsharma  Sure, go ahead. But if you decide not to do this later on please mention on the issue so that other can pick it up.

@Hasnayeen discontinuing this; facing issues Laravel setup!

I‘d like to look into this topic today.

Sure, go ahead. But if you decide not to do this later on please mention on the issue so that other can pick it up.

First draft of my implementation.
I still have to get rid of one issue where the list of messages are not yet updated properly after editing even if the array of messages are changed in the way Vue expects it to be changed (meaning through their proxy methods) and not directly overwriting and element through accessing the Array through an index.

I fixed the rendering problem now and changed the v-for key ot message.body as the the id doesn't change when updating the message but the body does. This is also recommended in the VueJS documentation.
Thanks and best regards,
Jan

@ewatch thanks for the pr, nice work :+1:


Generate C++11 Code and do not clear all message data on unpack

C++11 Code support, uses Linux can_frame structure to decode data, usage example:

can_frame rx_frame;
PDM_FRONT::FR_REQ message;
message.unpack(frame);

//then to access raw unpacked values:

print( message.raw.en_left_turn_indicator );

// or decode

print( message.en_left_turn_indicator() );

packing and setting of values is similar.

It also exports "choice" to string convesion and units as strings. It's a header only export and it links to the generated C code.

Instead of memsetting whole message data to 0, generated code now clears values on demand, for example:

    dst_p->ucmin_ext = 0;
    dst_p->ucmin_ext |= unpack_right_shift_u16(src_p[0], 0u, 0xffu);
    dst_p->ucmin_ext |= unpack_left_shift_u16(src_p[1], 8u, 0xffu);
    dst_p->ucmax_ext = 0;
    dst_p->ucmax_ext |= unpack_right_shift_u16(src_p[2], 0u, 0xffu);
    dst_p->ucmax_ext |= unpack_left_shift_u16(src_p[3], 8u, 0xffu);
    dst_p->nucmin = 0;
    dst_p->nucmin |= unpack_right_shift_u16(src_p[4], 0u, 0xffu);
    dst_p->nucmin |= unpack_left_shift_u16(src_p[5], 8u, 0xffu);
    dst_p->nucmax = 0;
    dst_p->nucmax |= unpack_right_shift_u16(src_p[6], 0u, 0xffu);
    dst_p->nucmax |= unpack_left_shift_u16(src_p[7], 8u, 0xffu);```

Coverage decreased (-0.09%) to 96.925% when pulling 6db38b830e40295166af20321b2d0d9cc472b98a on walmis:master into d49d365b2e8ca9acea8143655604f43745676847 on eerimoq:master.

What's the reason for removing memset? Without it parts of the message data is potentially uninitialized when pack returns, and must instead be initialized by the user before calling the pack function.

The reason I removed memset is that I need multiplexed data to remain on multiplexed messages. For example in mutiplexed message with parts A and B. when B data arrives, A data is zeroed out.

Can't you pack it all at once?

Can't you pack it all at once?
This is for unpacking. For packing the memset is as it was before.

Ok, I still think it's bad habit to return uninitialized data structures. Maybe generate a global structure of all signals in the database instead, or at least per message?

How should we proceed with this PR? =)


DuplicatedKeysError(key) when loading cosql dataset

Hi, great work!
I ran into DuplicatedKeysError(key) when loading cosql dataset. It seems that there exist different training examples with the same 'key'. I fix the _generate_examples function of [cosql.py] (https://github.com/ElementAI/picard/blob/main/seq2seq/datasets/cosql/cosql.py) like this and it works:
    def _generate_examples(self, data_filepath, db_path):
        """This function returns the examples in the raw (text) form."""
        logger.info("generating examples from = %s", data_filepath)
        key = 0 # indexing each training instance
        with open(data_filepath, encoding="utf-8") as f:
            cosql = json.load(f)
            for idx, sample in enumerate(cosql):
                db_id = sample["database_id"]
                if db_id not in self.schema_cache:
                    self.schema_cache[db_id] = dump_db_json_schema(
                        db_path + "/" + db_id + "/" + db_id + ".sqlite", db_id
                    )
                schema = self.schema_cache[db_id]

                db_stuff = {
                    "db_id": db_id,
                    "db_path": db_path,
                    "db_table_names": schema["table_names_original"],
                    "db_column_names": [
                        {"table_id": table_id, "column_name": column_name}
                        for table_id, column_name in schema["column_names_original"]
                    ],
                    "db_column_types": schema["column_types"],
                    "db_primary_keys": [{"column_id": column_id} for column_id in schema["primary_keys"]],
                    "db_foreign_keys": [
                        {"column_id": column_id, "other_column_id": other_column_id}
                        for column_id, other_column_id in schema["foreign_keys"]
                    ],
                }

                yield key, {
                    "utterances": [sample["final"]["utterance"]],
                    "query": sample["final"]["query"],
                    "turn_idx": -1,
                    **db_stuff,
                }
                key += 1
                utterances = []
                for turn_idx, turn in enumerate(sample["interaction"]):
                    utterances.extend((utterance.strip() for utterance in turn["utterance"].split(sep="|")))
                    yield key, {
                        "utterances": list(utterances),
                        "query": turn["query"],
                        "turn_idx": turn_idx,
                        **db_stuff,
                    }
                    key += 1

Besides, have you ever tried other hyperparameters to speed up training, such as smaller batch size? Any advice will be appreciated!

Hi @Soistesimmer!
Thank you very much for reporting this bug. I've pushed a fix based on your suggestion, https://github.com/ElementAI/picard/commit/25496df6641e1341ad0912b712a8be38da14ac03.
I hope the issue is resolved for you.
Torsten


Download link invalid

In DATA.md:
Then download the annotation files. The original MDETR annotation file contains COCO images; we provide a version without COCO images: wget https://penzhanwu2bbs.blob.core.windows.net/data/GLIPv1_Open/mdetr_annotations/final_mixed_train_no_coco.json -O DATASET/mdetr_annotations/final_mixed_train_no_coco.json.
However, the link seems to be invalid/offline.

You can use this link as an alternative: https://huggingface.co/GLIPModel/GLIP/resolve/main/glip_a_tiny_o365.pth


emq exporter api v4

Hi,
I am testing emq exporter (prometheus) for monitoring. my emq has api version 4.  this exporter doesnt support v4. is there any work around ?

Not at the moment.
Assuming that the metrics endpoints and format haven't changed, the fix should be relatively simple.
PR are welcomed


gpp support true

🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[ ] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[ ] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
[ ] For new adapters check submitting your adapter docs

@rishko00 can you also link the pull request in prebid.js / prebid server associated with this?


Parallel processing

Description
Description
Please note- This is not a new PR- Original PR (apache/lucene-solr#2345) was raised on old apache/lucene-solr github repository. This is just a copy in new repo.
Lucene Benchmark Scaling Problem with Reuters Corpus
While Indexing 1 million documents with reuters21578 (plain text Document derived from reuters21578 corpus), we observed that with higher number of Index threads, the Index throughput does not scale and degrades. Existing implementation with synchronization block allows only one thread to pick up a document/file from list, at any given time – this code is part of getNextDocData() in ReutersContentSource.java. With multiple index threads, this becomes a thread contention bottleneck and does not allow the system CPU resource to be used efficiently.
Solution
We developed a strategy to distribute total number of files across multiple number of Indexing threads, so that these threads work independently and parallelly.
Tests
We mainly modified existing getNextDocData(), which is not altering functionality, hence not added any new test cases.
Passed existing tests
Checklist
Please review the following and check all that apply:

[X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[X] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
[X] I have developed this patch against the main branch.
[X] I have run ./gradlew check.
[ ] I have added tests for my changes.

Thanks for the updates!
It looks like gradle check is upset -- if you run ./gradlew tidy it will re-format your changes and it should pass again!

@mikemccand
Mike, We've committed the code 4 days before and it still  in Checking phase. Ideally 'musedev' should not take longer time. Looks like, there is some problem is the checking process. It would be really helpful if you could advise us for the next steps.

@mikemccand
Mike, I was wondering, are there any suggestions to incorporate in this PR. Also, need your help to resolve this ** pending checks** issues, it has been more than 15 days and "musedev" still showing in pending state.

it has been more than 15 days and "musedev" still showing in pending state.

Egads!  I don't know why it's stuck in Pending.  We can skip it -- I'll confirm gradlew check is happy.

Thanks @balmukundblr -- I merged this with Lucene's main branch and also backported to 8.x (for eventual future 8.10.0 release).

@mikemccand
Thank you very much for your great suggestions which really helped us to improve the code at greater level.


fix(web): update Keymaster to Cfx.re Portal

Update Keymaster to Cfx.re Portal
https://forum.cfx.re/t/introducing-the-cfx-re-portal/5287316

I think it's a good opportunity to include a link to the new docs page:
https://support.cfx.re/hc/en-us/articles/16539369935900-How-to-create-a-registration-key


docs: update atlas links + inline scripts

Updated Atlas documentation links and references as per our internal upgrade of ZKsync within Atlas.

Looks like paymaster-transaction.ts is not working as expected as the tx is paid in ETH instead of the ERC20 token.

Updated link to template with fixed paymaster script. The problem had to do with the EIP712 txn request being ignored by default ethers used by hardhat, so fix was to use  Contract from zksync-ethers.

@alpinevm would you mind updating your branch from main? We just had a recent update to our dependencies and getting those latest changes should fix the breaking CI checks.

@itsacoyote Done!

Sorry, we have one last requirement to get this PR merged in, @alpinevm. All commits need to be signed, you can follow the general instructions on our Contribution Guidelines.
I am consulting with our security team if we can adjust this requirement, but it does not allow me to merge right now without signed commits.

Apologies, it seems that rebasing on the Github UI "unsigned" my commits? Regardless, I've resigned all of them.


Empty iohyve disks input gives bad output

Running iohyve disks without a guest name will list all volumes in iohyve, which is what iohyve info should be doing. iohyve disks guestname should be for one disk, and probably give more information.
Reference #65

This should now be fixed.


did not show anything

sometimes it can show real ads
but sometimes it show noting

Were you able to solve?

+1 I have same issue. Sometimes it display ads, sometimes not.
Very weird and not stable

Hi,
I have a couple of ads in a listview but each of them takes many time to load their content (from 10 to 15 seconds) but finally the content is displayed. Somebody has the same problem?

You could try the 2.0.0 alpha version, because the way views are vended has changed there and might prevent your issue from happening: https://github.com/sbugert/react-native-admob/releases/tag/v2.0.0-alpha.4

Closing now, because of lack of activity. If you still encounter the same problem feel free to open a new issue.


Refactor term, literal, identifier, expression...

Syntax highlighting for strings has different behavior per statement type. This is because the usage of the mentioned node types is not uniform.

Fixed by #28


:sparkles: Add deployment emoji :rocket:

Can you give me an example of when I would do a git commit as a deploy?

@dannyfritz Not specifically for actual deployment, more for deployment configuration/setup.

I would argue this would fall under 📇 or 🔧 .
I do like the rocket emoji, but I'm currently of the view it if redundant.
Thanks for your interest in commit message emoji. This is a really fun project.


cp setupPypi.py to setup.py

@vkuznet Please review.

@yuyiguo , sorry I didn't push my cp to the repository. Now it is there and this PR is obsolete.

NP


Dependabot is not bumping the version of Sphinx.

The Sphinx version was stuck at 3.0.3, where as the latest version is at 3.1.2. For some reason, Dependabot is not working here.

I was trying to figure this out, and couldn't see where dependabot is setup. I thought it was under Security, but dont see it there. Can anybody point me in the right direction?

Dependabot is configured via the files in the repository. We don't have a .dependabot/config.yml file, so it should be picking up on the requirements.txt file in the root of the repo.
It might make sense to move to a .dependabot/config.yml file though, as the requirements.txt file isn't used by anything else and sometimes confusing to developers trying to get started with the project.

Actually here's a screenshot of what Dependabot is currently configured to do:

I'm not sure what to make of this, it seems to include the docs.txt. It might be better to be more explicit about this with a configuration file.

I wonder if it's because docs has two sets configurations in the screenshot

Docs/requirements.txt
requirements/docs.txt

The versions in both are different.

Ah, good catch! That might be the culprit. I think that probably exists to configure ReadTheDocs maybe?

The last time Dependabot updated both the files was Nov 12, 2018 for version 1.8.2 (#5044). Since then requirements/docs.txt has been updated manually.


Remove error log from _ensure_exists

Short description:
Remove error log used during development in _ensure_exists
More details:
What this PR does / why we need it:
This error log causes confusion when calling _ensure_exists
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge

Supported /retest check runs

/retest tox: Retest tox
/retest python-module-install: Retest python-module-install

Supported labels

hold
verified
wip
lgtm

/verify

/verified

thanks

/verified

/lgtm

/verified

/check-can-merge


[4.1] Allow passing parent form fields along with inline create dialog request

Allow the devloper to setup:
....
 'inline_create'     => [
                    'entity'      => 'entity',
                    'modal_class' => 'modal-dialog modal-xl',
                    'include_main_form_fields' => ['field1','field2']
                ],

....
 'inline_create'     => [
                    'entity'      => 'entity',
                    'modal_class' => 'modal-dialog modal-xl',
                    'include_main_form_fields' => true //all form fields
                ],

....
 'inline_create'     => [
                    'entity'      => 'entity',
                    'modal_class' => 'modal-dialog modal-xl',
                    'include_main_form_fields' => 'only_one_field'
                ],

By default it would be false.

A new inspection was created.

The inspection completed: No new issues

Awesome! This fixes #2912 . Merge into master, it'll be available later today with a composer update. Thanks a lot @dividy & @pxpm !

@pxpm I just merged this BUT I think there's problem here, judging from the docs, so I reverted the merge.
We now have two attributes which look very similar - include_all_form_fields and include_main_form_fields. And after this PR it looks like include_all_form_fields no longer does anything. Not sure it did do anything beforehand though.
We need to find a way to make both of them make sense, if they both exist. And keep this change backwards-compatible - that's a MUST. Can you please investigate how we can do that?
To me it looks like before this PR, include_all_form_fields was true by default. That means we need to keep this behaviour for now - only in 4.2 can we change the default to false.
We need a different PR that brings this change (and fixes the above), since I merged this PR, but then reverted the merge.

Indeed @tabacitu there are two attributes very similar but they are not related.
include_all_form_fields is part of the field ajax, it's present in select_from_ajax too, it is the way developer can pass the form fields when we do the search in the field.
I did not changed nothing related to that. It's still true by default (but planned to be false on 4.2).
It's used like I said with the ajax search inside field.
var performAjaxSearch = function (element, $searchString) {
    var $includeAllFormFields = element.attr('data-include-all-form-fields')=='false' ? false : true;
....

Different is include_main_form_fields that belongs to the inline create world. That allow the developer to sent the parent fields to the inline create modal request endpoint. This is a new feature so I started with false by default.
I think you misread something here, or I did not make myself clear. I did not touch nothing related to include_all_form_fields.
$this->crud->addField([
....
'include_all_form_fields' => true,
'inline_create' => [
    'include_main_form_fields' => 'field'
]

I agree that we should allow the same functionality in both of them (the later allows to pass one, multiple or all fields, while our previous solution only allow all fields or none), but as that would be a breaking change I did not touch it.

Ah ok, I get it now, thanks for the clarification @pxpm ! I makes sense to have both then, I agree, I've reverted the revert 😆  in https://github.com/Laravel-Backpack/CRUD/pull/3023 so indeed it'll be available in the next patch update.


Navigation category part error fix

"shift + command + up arrow = mouse wheel up fast" and "shift + command + down arrow = mouse wheel down fast" work in reverse.

我已经收到邮件，有空多联系~~


Bridge Events Not Appearing in Smartthings

Try and make this concise, it's likely user error.
RPI3 running Hass.io with the bridge installed as a local add-on (this one https://github.com/vkorn/hassio-addons/tree/master/smartthings)
I get messages to pass from smartthings -> bridge -> mqtt -> HA no problem, but for some reason events from the bridge aren't making it to smartthings in the other direction.
7:59:17 PM: debug Sending '{"path":"/push","body":{"name":"Dining Hall","value":"off","type":"switch"}}' to device
7:59:17 PM: debug Forwarding device event to bridge: {"path":"/push","body":{"name":"Dining Hall","value":"off","type":"switch"}}
info: Incoming message from SmartThings: smartthings/Dining Hall/switch/state = on
HA updates to reflect the device is on
I then try to turn the device off via HA and see this in the bridge event.log
info: Incoming message from MQTT: smartthings/Dining Hall/switch/cmd = off
But there's nothing on smartthings live logging showing the message is arriving.
I'm using port 8080 and I can get into the docker container the bridge is running on, but I don't know where/how to check what could be going wrong.

Closing up and sharing my mistake. MAC address is everything, My pi was connected via wi-fi, smartthings wanted to see /
wlan0 HW address


fix: missing error

Related issues

Close #154

Anyone reviewing PR (and issues) here?
@chen-keinan ?


[Feature]: Watched list

What feature do you want to add?
well.. list of stuff you already watched similar to "favorite" thing
Why do you want to have this feature?
Because it would be cool to replace shitty IMDB to proper, cool-looking, amazing and funny site
Any other details to share?
maybe i am dumb and it is already here but like when you local host it, but if not then would be really glad if added :)

What do you mean?
We already have it


fix: Remove redundant button tag logic and dependency on deprecated schema

Jira
N/A (ticket based on Slack convo)
Summary
Remove redundant button tag logic and dependency on deprecated schema
Details
This removes some redundant/confusing twig logic related to processing the deprecated tag prop.  In summary:

The button will no longer break if the tag section of the schema is deleted.
The only place that a user-supplied tag prop has any effect is in the DEPRECATED block near the top of the twig file, where it's converted to the appropriate type (although a tag variable is used later in the file, it's essentially an internal variable and will never inherit from a passed twig prop)
The logic for determining the tag has been simplified to the following:

If a url param is present, the tag will always be <a>
Otherwise, the tag will always be <button>

Logic for determining the type attribute has been simplified to the following:

If a url param is passed, there will be no type prop
Otherwise, type prop will be a valid type ("reset" or "submit") or "button" as a default.

Note: there is a minor change of logic here: if you pass both a url and a type prop, url will always win and there will be no type.  Previously, if you passed both a url and type=submit or tag=submit, the type/tag would win.  I don't consider this a breaking change because there is no valid reason to do that and it's effectively unsupported.
How to test
Confirm no regressions

This is a surprising test result.  https://travis-ci.com/boltdesignsystem/bolt/jobs/254233892#L1483-L1484
It looks like the results on this PR are actually the ones I would expect, which would mean it fixed a previous bug.  I wasn't expecting it to though...
https://github.com/boltdesignsystem/bolt/blob/master/packages/components/bolt-typeahead/typeahead.twig#L108
https://github.com/boltdesignsystem/bolt/blob/master/packages/components/bolt-typeahead/typeahead.twig#L122

Here's another test fail that I would actually expect: https://travis-ci.com/boltdesignsystem/bolt/jobs/254233892#L1781
Previously, if you passed the (deprecated) tag prop but no url prop, you would get a non-sensical <a> tag without an href.

This is similar to my note in the PR description.  Trying to specify an <a> tag without passing a url is contradictory, so we choose to honor the url (or lack thereof) instead.  It is technically a backwards-breaking change, but for an unsupported/non-sensical combination of props.

It looks like the results on this PR are actually the ones I would expect, which would mean it fixed a previous bug.

Aaaand just kidding.  Looks like I introduced a bug. 😅
Testing coverage: 1
Remy: 0

Thanks for the post-merge test updates @sghoweri, all the snapshot changes look to be as-expected.

Should be all set @danielamorse, ready for another review.

PR was released with v2.11.0


Breaks on multi-argument setter methods

Ruby version: 2.6.6p146
Rubyfmt git sha: c7efbb75289cbb48a2910cb0c580686f12eee62a

Input file
Capybara.server = :puma, { Silent: true }

This is a multi-argument setter method. Very weird but apparently allowed.
Rubyfmt's output
Traceback (most recent call last):
        1: from /Users/mikker/dev/rubyfmt/rubyfmt.rb:237:in `<main>'
/Users/mikker/dev/rubyfmt/rubyfmt.rb:237:in `format_to_stdout': No variant matched untagged enum Expression. (Error from ripper_deserialize) (RuntimeError)

This breaks because
I suppose rubyfmt could leave it as is. Alternatively something like Capybara.server=(:puma, Silent: true) which would be more descriptive IMO but just as weird if not weirder.

Unapologetically fixing with Capybara.send(:server=, [:puma, {Silent: true}]) for now

Well I learned something new today! I always thought that Capybara.server = :puma, { Silent: true } was equivalent to Capybara.server = [:puma, { Silent: true }].

Maybe it is and it's doing some sort of pattern matching on the method calling 🤷♂

Btw, this was the *only* thing that broke when I reformatted my whole app's worth of .rb files
$ find . -name '*.rb' | xargs wc -l
        …
        14022 total

Confirmed. This minimises to a = 1, 2


To create webrtc support for existing sip.

Is it possible to make the Openwebrtc to utilise any existing SIP only framework and provide the WebRTC support, by catering the essential like websocket, ice, to it.

Yes, you can use OpenWebRTC with any type of signalling protocol as long as you keep to the WebRTC offer/answer procedure, which basically means sending SDP's to one another.

Thank you @stefanalund ,
How could we use the openwebrtc stack to impliment as a module, which could play the role as a websocket server, to handle dtls-srtp handshake also to add/remove ice candidate information in sdp from webrtc clients.

@ashwin-mk that is a pretty broad question which makes it hard to answer. I think you should get going and ask more detailed questions along the way. You can find various example clients here:
https://github.com/EricssonResearch/openwebrtc-examples

We have JsSIP client on one end, other end is a SIP framework. For enabling webrtc support to the SIP framework, there needs to be a module in between that can handle webrtc clients and  communicate with SIP framework. Since the SIP framework does not provide support for ICE, DTLS-SRTP, the module should take care of the stuffs.  Also, the module should behave like a server, for handling different webrtc clients, and then send the messages to SIP framework. Can I use Openwebrtc stack for implementing this module?

I think that should be possible. If you are building a server-like solution, there are basic C examples such as this to start from: https://github.com/EricssonResearch/openwebrtc/blob/master/tests/test_client.c

Thank you. I have already gone through this application. Basically, JsSIP client is sending "SIP over Web-socket". So, for handling SIP over websocket packets, I need to add SIP over Websocket support to the sample test-client application and handle SIP messages. Any sample server application available to refer to?

@ashwin-mk as OpenWebRTC is primary a client-side framework we have not developed any sample applications for servers. Sorry.

You might also be interested in looking into Kurento (which is server side
and WebRTC compliant).
On Fri, Feb 5, 2016 at 7:52 AM, Stefan Ålund<EMAIL_ADDRESS>wrote:

@ashwin-mk https://github.com/ashwin-mk as OpenWebRTC is primary a
client-side framework we have not developed any sample applications for
servers. Sorry.
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/openwebrtc/issues/560#issuecomment-180226861
.

Thank you. :)
We had gone thought the Kurento also, but as far in our case, we would be using the webrtc library with another server. The library behaves more or less like a client implmentation because for every sdp offer that we are getting from a client, we need to reply with an sdp answer, where the media information will be added by conference server and the ICE and finger print information will be added by the  webrtc library. The server kind of usage would be coming only for the Websocket connection for handling different webrtc clients.


refactor ModuleHotDeclineDependency to es6

What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
current tests should pass
If relevant, link to documentation update:
N/A
Summary
upgrade ModuleHotDeclineDependency to es6
Does this PR introduce a breaking change?
No

Thank you!!!!!!


Add the "Move Tab to New Window" item to the context menu of the tabs

          Is it supposed to add the "Move Tab to New Window" item to the context menu of the tabs

like Mozilla Firefox

in the context of this task?
Screenshots of Windows Terminal Preview 1.17.1023 and Mozilla Firefox 111.0.1 (64-bit), Microsoft Windows 10.0.19045.2788.
Originally posted by @Korb in https://github.com/microsoft/terminal/issues/1256#issuecomment-1498541375

Oh you can almost certainly ignore the warning that VS shows about the incorrect configurations. I'd revert all your changes to OpenConsole.sln, then make sure you pick:

And that should just work.
Our sln is a crazy hodgepodge of c++ and C# code and unsurprisingly, VS does not care for that 😅

@zadjii-msft
Reverted all changes to OpenConsole.sln by removing and recloning the project.
Picked:

Restored and updated submodules
git submodule update --init --recursive
Ignored warning about incorrect configurations.
In the Debug menu,  I changed "Application process" and "Background task process" to "Native Only".
Build it, had an issue with nuget packages:

Solved that by building with Powershell. This installed the packages, but this time build ended with errors.
Afterwards I deleted the Obj and Bin folder of the project and build it with visual studio, getting the same erros as before, but getting similar errors with PowerShell now as well:

(_ConsoIeGenerateAdditionaIWinmdManifests target) —>
    mt.exe: command line error c1010007: Unexpected/ Unknown option "...\Microsoft.Termina1.Control\Microsoft.Terminal.Control.winmd". Use the / ? option for help on usage and samples.
    The command `mt.exe -winmd:...\Termina1.Control\Microsoft.Terminal.Control.winmd -dll:Microsoft.Terminal.Control.dll -out:...WindowsTerminal\Microsoft.Terminal.Control.manifest exited with code 31

Huh. I've literally never seen that before. That'll require some searching.
When you built it from the command-line the first time, it worked and you didn't run into that?
Utterly bewildering.

Silly question - does the username covered up with the blue splodge contain any odd characters - like a space?

@ianjoneill
Yes It contains a space

@ianjoneill  @zadjii-msft
Got it running in VS thanks very much to @ianjoneill !
and @zadjii-msft  for the configuration Manager ignore tip.

@zadjii-msft  @ianjoneill
“That'll require some searching.”
Would you have done that? What is like protocol in this Open Source project in terms of help you can expect from Members ?
Can I expect you to do the searching. Or is it more like you expect me to do the searching and try various different things. And I can expect a small hint here and there?

Note
Walkthrough

I'd start by looking at TerminalTab::_CreateContextMenu. That's where we set up the tab context menu.
Almost all the buttons work by triggering a WINRT_CALLBACK, which is ultimately handled by a handler set up in TerminalPage::_InitializeTab (in TabManagement.cpp)
To actually do the moving, you'll want to build a MoveTabArgs with the Window set to "new".

You'll want to then call TerminalPage._MoveTab

The trick here will be being able to move an unfocused tab. "Find" has a similar issue. It might be a sensible place to do a page->_SetFocusedTab(*tab); first, to manually focus that tab.

@zadjii-msft Your walkthroughs look really cool, in the sense that you build it like a game!! I love that. Btw, the software not being able to be build when someone has a username that contains a space. This may be a new issue?

Have some questions:
Where are cpp files inside solution explorer, like where is TerminalTab.cpp?
Can find it in file explorer, but not solution explorer. Is this a cpp thing or? (more used to c#)
And if it is there, how can I find it? I remember something about shortcuts for that, but not sure.

Functionality added, here's the preview:

Will be working towards pull request.

That looks great!
Presumably you figured it out, but the .cpp files are nested under the .h files (usually). Some of them are nested under the .idl's or .xaml's. Honestly, I don't know why VS chooses to do it that way 🤷 I've honestly only ever used the "Go to files" shortcut (which I think is sound to ctrl+shift+t) in VS. Way easier than trying to navigate the project structure. Just type bits of the file name and go. But then again, I'm more of a Sublime / VsCode user than a VS one - I just use big VS for building and debugging 😆

@zadjii-msft

What do you mean with TerminalApp? The code files named TerminalApp? Like TerminalApp.h, TerminalApp.cs
Or files in the TerminalApp Project inside the VS Solution?
This one, see below

Ah yea - those are probably a little out of date. But yea TerminalApp in that context means "The TerminalApp project". Which these days is probably more accurately "anything that uses C++/WinRT".
I'd honestly just use one of the following two icons from the built-in Segoe Fluent Icons

Glyph
Unicode point
Description

e8a7
OpenInNewWindow

e78b
NewWindow

OpenInNewWindow looks good to me.

@zadjii-msft
Did the Pull Request.
By contributing to this Open Source Project. I intend to become a better Engineer. Would appreciate any tips/advice you can give.
Let me know if something need to be changed.

@zadjii-msft
I really appreciate the time and effort you took to write the Walkthrough for this.
But that made it way too easy for me.
Big part of the fun for me in solving these "programming puzzles"/bugs/features etc.  is the detective work.
Looking for the files to adapt and what specific piece of code I need to adapt.
And pointing out the specific files and even the methods especially took the fun out of it.
In the future I would very much like less hand holding.
That being said I am still new to c++ so don't go overboard.

@zadjii-msft
About your second point.

I don't get point 2:
"using the active profile in the current directory."
I interpreted this to mean that the current tab information (active profile in current directory) is used for the tab you want to move. And so you don't create a new tab, but move the current tab (using the active profile in the current directory) to the new window.

@zadjii-msft
Actually, why is, the duplicate not working like that?
Or am I saying something really silly.
Not sure about why duplicating would be useful. Don't think I often do that for a terminal window.
PS: Have been getting a bit more into windows terminal lately. Check out this pimp:

So you have 2 windows open VSCode program and one VS? And then VSCode on one screen and VS on the other or?

Basically, yea. I've got three monitors, so my typical layout looks a bit like:

I used Sublime for years, (and still do sometimes), so my mental model of the codebase entirely revolves around:

ctrl+p: go to a file in the project by name with a fuzzy match
ctrl+r: navigate to a function / class in this file by name
ctrl+g: go to a line in this file

For me, that's just become way easier than trying to navigate the file tree UI.

I don't get point 2:
"using the active profile in the current directory."
I interpreted this to mean that the current tab information (active profile in current directory) is used for the tab you want to move. And so you don't create a new tab, but move the current tab (using the active profile in the current directory) to the new window.

Ah, so, to clarify:

A "terminal pane" is really a combo of a bunch of state - the buffer, the connection to the client app (e.g. cmd.exe), and then any runtime state, like the tab title, CWD, etc.
"Duplicate tab" can't recreate the state of the buffer or the state of the connected clients. Like, if you had a tab running cmd.exe, which ran ssh, which ran vim... the Terminal can't recreate that. So we don't even bother. Instead, we just use what we do know - the profile used for that tab, the tab title, and possibly the CWD, and we create a new connection and a new buffer for that new tab.
"Move tab to new window" is different. It's not making a new connection or buffer - it's literally just moving the existing one. So the original text you had

Moves tab to a new window using the active profile in the current directory

IMO, that has a subtle implication that the active profile and CWD will be used to make a new connection. Which isn't true - it's effectively just tearing out the current tab.

Does that all make sense? It's a real subtlety and a more confusing bit of how the Terminal works behind the scenes.

I really appreciate the time and effort you took to write the Walkthrough for this.
But that made it way too easy for me.

Thanks! To be honest, that sounds like the walkthrough did exactly it's purpose - help get you oriented in an unfamiliar codebase. Now that you've got it building and know your way around running the project locally, feel free to go tackle something a bit more challenging. I'll look forward to the PR 😄

Ah sorry, let me be more specific: IMO, just getting the project to build and run can often be its own problem. (as you so observed!) If you want more challenging issues, I'd be all for helping point you at some of those. I've found that for myself, starting with an easy win always gets me into a better headspace for harder problems later in the day / week.
These issues: https://github.com/orgs/microsoft/projects/686/views/4 are some that I think are probably a comparable difficulty, that I've never gotten around to writing walkthroughs for yet. Basically as you go up in difficulty, the hints I can give are going to get more abstract. I can always give less hints if you'd like 😛

What kind of hints would you give to a junior / entry level engineer at Microsoft

oof that's a good question - when's the last time we even had one of those 😅 Honestly I might just point them at a similar PR or two in the past and be like "alright, this issue is a lot like #foo, and maybe a little like #bar, so do it just like those two PRs".

#14909 might be a good example - something similar to what you just did, so you're already familiar with the problem space. Not a ton of hints in that one either... (I can always look for others if that doesn't seem interesting 😉 )

@zadjii-msft
I added you on LinkedIn. You haven't added me back, why is that?
Btw I'll get to the second pull request. Looking through your no walkthrough list.

Basically, yea. I've got three monitors, so my typical layout looks a bit like:
I used Sublime for years, (and still do sometimes), so my mental model of the codebase entirely revolves around:

ctrl+p: go to a file in the project by name with a fuzzy match
ctrl+r: navigate to a function / class in this file by name
ctrl+g: go to a line in this file

For me, that's just become way easier than trying to navigate the file tree UI.

Do you also use this for pure C# projects? I wonder, cause there the file tree UI makes way more sense in Visual Studio than cpp. Other thing I wonder about, if you work like this, then how do you keep a model in your mind of how the entire codebase is connected?
Does the Windows Terminal Open Source Project have like a map or something? That describes how the various classes are connected?

@zadjii-msft I like this one https://github.com/microsoft/terminal/issues/6366
Lot's of people would be happy with that contribution. Gonna take a crack at it.

@zadjii-msft
Maybe you should put this somewhere in the general docs for this project. It would probably also be valuable to others.
So the commandline clients are connected to the windows terminal via  a ConPTY Process which is Conhost.exe do I understand that correctly?

you should put this somewhere in the general docs for this project

Yep, that needs to be probably significantly updated. Probably will soon, likely as a part of #15065 & #6999.

commandline clients are connected to the windows terminal via a ConPTY Process which is Conhost.exe do I understand that correctly

Yep! That lets conpty emulate the Win32 Console API, while the Terminal only really needs to "speak" in ANSI escape "VT" sequences, which is more like every other terminal that exists.

@zadjii-msft
Awesome. What is the protocol for this Open Source Project in terms of releasing the fixes?
Are there specific times things are released to the Preview?
Also when do things get added to the Official Windows Terminal that's installed by default on Windows 11. It would be really cool to see a feature that I helped contribute with , that would make me proud.  And do all of them get added? Or are some not? , Like a selection of things or something like that?

What is the protocol for this Open Source Project in terms of releasing the fixes?
Are there specific times things are released to the Preview?

We usually release new Preview builds like, once every 3-6 months. Exact timing is usually pretty fungible, based on how the actual release cycle is going, or if there are major events (see: Build). I don't think we've really started discussion of when 1.19 will be yet.

when do things get added to the Official Windows Terminal

That's uh.... c o m p l i c a t e d. Technically, the version of the Terminal that actually ships with Windows 11 is like, Terminal 1.12. Yea. That old. There's internal rEaSoNs why that is, but essentially, people should immediately get the newest version of Terminal Stable (as of last week, 1.17), as soon as they log in and the Store gets them an update.
So basically, whenever Terminal 1.20 Preview comes out, 1.19 will get moved to the Stable channel, which is when this feature will be "pre-installed" on Windows 11.

That's uh.... c o m p l i c a t e d.

I just checked version 1.17.11461.0 into Windows for the insider program participants! 😉


[serverless/gitlab] add jobs to validate the build of the Datadog Lambda Extension

What does this PR do?
Add basic jobs to build the binary of Serverless Agent / Datadog Lambda Extension to validate that it is always properly building.
Describe your test plan
Validate that the new jobs are completing successfully in the pipeline.

Both new jobs about the serverless build are green, even with recent changes from master. I'm merging this PR and I will follow-up with another PR to add an invoke task.


New editor issues

I don't like the new ediot in new version 6.0.
I want to write article by my own feagure, but actually I can't.
Such as inserting a link, I can't type like '[xxx](xxx.md)' to do it, but I must use ctrl + k to insert it.
When I want to open the link, it open my windows file system (old version will open the linked .md file).
I hope that the new version will be able to provide options to switch to the new editor and the old editor.
And every time I save some changes on gitbook, I can't find the changes in the file system. Just don't know why. Is there any solution to this?
Thanks for the hard work on Gitbook !

The popover issue is fixed in version 6.1.0.