Cognitoidp Mocks Require Invalid Package

Hi,
I am having an issue running tests using the cognitoidp fixture. I have installed all of the necessary dependencies using pip install moto[all] but I get this error when I try to run my test:
.tox/default/lib/python3.7/site-packages/_pytest/python.py:578: in _importtestmodule
    mod = import_path(self.fspath, mode=importmode)
.tox/default/lib/python3.7/site-packages/_pytest/pathlib.py:531: in import_path
    importlib.import_module(module_name)
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
.tox/default/lib/python3.7/site-packages/_pytest/assertion/rewrite.py:170: in exec_module
    exec(co, module.__dict__)
services/study_resolver/cognito__test.py:24: in <module>
    @mock_cognitoidp
.tox/default/lib/python3.7/site-packages/moto/__init__.py:8: in f
    module = importlib.import_module(module_name, "moto")
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:728: in exec_module
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
.tox/default/lib/python3.7/site-packages/moto/cognitoidp/__init__.py:2: in <module>
    from .models import cognitoidp_backends
.tox/default/lib/python3.7/site-packages/moto/cognitoidp/models.py:13: in <module>
    from jose import jws
E     File "/Users/daltonscott/Documents/Code/blah/.tox/default/lib/python3.7/site-packages/jose.py", line 546
E       print decrypt(deserialize_compact(jwt), {'k':key},
E                   ^
E   SyntaxError: invalid syntax

I assume there is something messed up with the pip imports? I'm using the latest available version of moto.
Here's a sample test for what I am doing:
@pytest.fixture(scope="module")
def aws_credentials():
    """Mocked AWS Credentials for moto."""
    os.environ["AWS_ACCESS_KEY_ID"] = "testing"
    os.environ["AWS_SECRET_ACCESS_KEY"] = "testing"
    os.environ["AWS_SECURITY_TOKEN"] = "testing"
    os.environ["AWS_SESSION_TOKEN"] = "testing"

@pytest.fixture(scope="module")
def cognito(aws_credentials):
    with mock_cognitoidp():
        cognito = boto3.resource("cognito", region_name="eu-west-2")
        yield cognito

@mock_cognitoidp
def test_list_users(cognito):
    pool = cognito.create_user_pool(PoolName="Testing")
    res = cognito.list_users(PoolName="Testing")
    assert res is not None

Hi @DMPS, it looks like your virtualenv contains jose: https://pypi.org/project/jose/
That's the only way I can reproduce it at least, by manually installing jose in addition to moto.
Moto requires python-jose[cryptography]>=3.1.0,<4.0.0. As they both use import jose, there might be a naming conflict there.

Hi @bblommers, I've taken jose out of my virtualenv but now I get this error:
ImportError while importing test module '/Users/daltonscott/Documents/Code/stuff/services/stuff/cognito__test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
services/stuff/cognito__test.py:24: in <module>
    @mock_cognitoidp
.tox/default/lib/python3.7/site-packages/moto/__init__.py:8: in f
    module = importlib.import_module(module_name, "moto")
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
.tox/default/lib/python3.7/site-packages/moto/cognitoidp/__init__.py:2: in <module>
    from .models import cognitoidp_backends
.tox/default/lib/python3.7/site-packages/moto/cognitoidp/models.py:13: in <module>
    from jose import jws
E   ModuleNotFoundError: No module named 'jose'

Where is the jose install coming from?

pip install moto[all] will install python-jose[cryptography]>=3.1.0,<4.0.0, which exposes the jose module

Weird, so it seems like the issue was that I was running pip install moto[all] manually rather than having it in my setup.cfg. I've changed the entry under install_requires to moto[cognitoidp] now and the test works.
Thanks @bblommers!


Cannot install from git using pip

🐛 Describe the bug
I'm trying to install torchvision from source following this thread: https://github.com/pytorch/vision/issues/3283.
I tried doing pip install<EMAIL_ADDRESS>but it gives me the error:
Collecting<EMAIL_ADDRESS>  Cloning https://github.com/pytorch/vision.git (to revision v0.13.0) to /tmp/pip-req-build-32tizbmz
  Running command git clone --filter=blob:none --quiet https://github.com/pytorch/vision.git /tmp/pip-req-build-32tizbmz
  Running command git checkout -q da3794e90c7cf69348f5446471926729c55f243e
  Resolved https://github.com/pytorch/vision.git to commit da3794e90c7cf69348f5446471926729c55f243e
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      Traceback (most recent call last):
        File "/home/vedant/miniconda3/envs/video-rec/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/home/vedant/miniconda3/envs/video-rec/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/vedant/miniconda3/envs/video-rec/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 130, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-8an9cnsq/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 338, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-8an9cnsq/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 320, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-8an9cnsq/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 482, in run_setup
          super(_BuildMetaLegacyBackend,
        File "/tmp/pip-build-env-8an9cnsq/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 335, in run_setup
          exec(code, locals())
        File "<string>", line 9, in <module>
      ModuleNotFoundError: No module named 'torch'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

Versions
Collecting environment information...
PyTorch version: 1.12.1+cu116
Is debug build: False
CUDA used to build PyTorch: 11.6
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04 LTS (x86_64)
GCC version: (Ubuntu 11.2.0-19ubuntu1) 11.2.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.35
Python version: 3.9.12 (main, Jun  1 2022, 11:38:51)  [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-5.15.0-43-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: NVIDIA GeForce GTX 1080 Ti
Nvidia driver version: 515.65.01
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
Versions of relevant libraries:
[pip3] numpy==1.23.2
[pip3] torch==1.12.1+cu116
[pip3] torchdata==0.4.1
[pip3] torchvision==0.13.1
[conda] numpy                     1.23.2                   pypi_0    pypi
[conda] torch                     1.12.1+cu116             pypi_0    pypi
[conda] torchdata                 0.4.1                    pypi_0    pypi
[conda] torchvision               0.13.1                   pypi_0    pypi
(video-rec) √ video-recommendation %

Hi @vedantroy , does it work with pip install --no-build-isolation ?

@NicolasHug That seems to do the trick! For some reason, torchvision is not detecting my FFMPEG and I don't know why though. I did conda install 'conda-forge::ffmpeg<4.3', which should give me ffmpeg 4.2

On the ffmpeg side, perhaps @bjuncek @jdsgomes  will have some input?

On the ffmpeg side, perhaps @bjuncek @jdsgomes will have some input?

Sounds good! I have also tried compiling ffmpeg from source, but that didn't help. Maybe there's a way to tell torchvision to use a local ffmpeg directory?

Maybe there's a way to tell torchvision to use a local ffmpeg directory?

Looks like we have a hard-coded logic for that:
https://github.com/pytorch/vision/blob/c0ba3ec86aff2f19044cf710b0d1a2364dad8f75/setup.py#L394-L397
So maybe you can try to tweak that (you'll have to download the repo locally though, not install it from git+.... Or perhaps also play with LD_PRELOAD or LD_LIBRARY_PATH to point to the ffmpeg .so files that you have build locally?

Maybe there's a way to tell torchvision to use a local ffmpeg directory?

Looks like we have a hard-coded logic for that:
https://github.com/pytorch/vision/blob/c0ba3ec86aff2f19044cf710b0d1a2364dad8f75/setup.py#L394-L397
So maybe you can try to tweak that (you'll have to download the repo locally though, not install it from git+.... Or perhaps also play with LD_PRELOAD or LD_LIBRARY_PATH to point to the ffmpeg .so files that you have built locally?

If I use a local ffmpeg installation, will torchvision be dynamically or statically linked. Basically, can I remove the local installation afterwards or do I need to keep it?

Ohhh, I see the issue is that using python 3.9 is bad with torchvision. I would suggest a error message / hard exit instead of setting has_ffmpeg = False.

Nevermind, still having compilation errors for the video stuff, see: https://github.com/pytorch/vision/issues/6430


Strange performance drop when hovering over a log connected to a large number of logs, even when they're disconnected from leaves.

Environment Info
Minecraft version: 1.12.2
Forge version: <IP_ADDRESS>60
Mod version(s) tested: 0.14.7
Bug Info
Summary: This is a low-severity, non-destructive, obtrusive bug that CAN be prevented by the player, albeit to their chagrin in most cases due to requiring they change their build technique or the materials they use in said builds.
Description: When attempting to hover your cursor over a large section of logs connected to each other, a significant FPS drop is incurred on the client, even when the logs aren't connected to any leaf blocks, and that's the bug for the most part.
Additional Notes
If you're experiencing this bug as well, just give this post a 👍 instead of replying. It reduces clutter and saves everybody's time.
Also, I'm aware that this bug likely won't get fixed by the developer, so this post was mainly created with the intent to document the problem so as to save people some trouble since I understand that not everybody thinks logically like I do and would immediately think to try removing the tree chopping mod. I know that may sound a bit silly to some of you but I've had it happen a few times when helping people with other mod-related issues. Hope this post helps somebody.

Hey Delfite, thanks for reporting! You're right that I probably won't get around to fixing this, as I don't have the time to support older Minecraft versions. However, I'm pretty sure the fps drop is caused by the chop indicator. You can disable it treechop's in-game settings screen (bound to n by default)


feat(theme-default): use rem for body font-size

@meteorlxy  Inspired by #816, following root font size have better a11y.

What about simply moving font-size: 16px; to the html, body section? What's the point to specify 1rem for body?

Setting both as 16 px, user will fail to change body font-size when simply setting a new rem size.


Incorrect links

Hey folks,
A few of the links in this section are not formatted correctly.
https://docs.microsoft.com/en-au/azure/active-directory/fundamentals/security-operations-user-accounts#where-to-look

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 121555b7-46c7-cffd-3f63-330f24d41e18
Version Independent ID: a01f31b3-8723-7047-0f39-772aefdd5f96
Content: Azure Active Directory security operations for user accounts
Content Source: articles/active-directory/fundamentals/security-operations-user-accounts.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @BarbaraSelden
Microsoft Alias: baselden

@merill Thank you for catching this. We will have this reviewed with the content team and update accordingly after review.

@merill It would be great if you could point out the links which do not seem formatted correctly .

It looks like @ktoliver has fixed them in this commit https://github.com/MicrosoftDocs/azure-docs/commit/09d41f05343355f56612cd3cb1f0aef70ad61b6d

@merill Yes , I was also checking and found the same hence I was not sure. thank you for clarifying .

Hi. The fix was submitted in a pull request in the azure-docs public repo, https://github.com/MicrosoftDocs/azure-docs/pull/78811. I merged the PR as PR reviewer assigned to the repo. 👍🏼


Read bash import from stdin

Allow import from stdin through pipe. So we can do :+1:
$ bzcat BAN_odbl_33.json.bz2 | addok batch --

This syntax works:
(addok) edoardo:~/C/p/addok (master $=) addok batch < ~/Data/geo/ban/communes-context.json

I need to investigate why yours don't.

Humm, this one works too:
(addok) edoardo:~/C/p/addok (master $=) less ~/Data/geo/ban/communes-context.json | addok batch

Why adding '--' ?

Was a fictive command line. I never try. It's not in the doc !


WebView doesn't load local html file correctly

🐛 Bug Report
I am using webview to load local html file which shows the variety of tiles on google maps.
it works on native project, but two tiles doesn't load in react native project with same html file.
React Native screenshot.

Native screenshot.

Expected Behavior
Need to show all tiles correctly like as native.
Code Example
Here is codechip for webview.
<WebView
          originWhitelist={['*']}
          onLoad={this.onLoad}
          source={Platform.OS === 'android' ? { uri: 'file:///android_asset/index.html' } : {uri: './index.html'}}
          dataDetectorTypes={'none'}
          ref='webview'
          onMessage={e => this.onMessage(JSON.parse(e.nativeEvent.data))}
          onShouldStartLoadWithRequest={this.onShouldStartLoadWithRequest}
          onNavigationStateChange={this.onShouldStartLoadWithRequest}
          injectedJavaScript={patchPostMessageJsCode}
          useWebKit={true}
          />

I am not sure why this file doesn't work on react native.
Any help are appreciated.

It works on Android correctly, this problem come from only iOS platform

Please use https://github.com/react-native-community/react-native-webview, because WebView in React Native is deprecated and will be removed in the future.

@dulmandakh, so we can't resolve this issue?
It give me HTTP load failed 999 error when I run project with Xcode

@WebMobi59 WebView in React Native will not receive any updates and will be removed soon. Please use react-native-webview, which is actively maintained fork.


Cleanup reference-manual qemu section

As the QEMU section had been cleaned up as parts of previous commits, the focus here was to address any outstanding issues. the qcow2 artifact was reported to no longer be available, so the instructions were updated to reflect this.
Output was checked in the browser.
This commit addresses FFTK-2793
This commit applies to FFTK-2732
This commit applies to FFTK 2731
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[ ] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[x] Step through instructions (or ask someone to do so).
[x] Review for wordiness
[x] Match tone and style of page/section.
[ ] Run make linkcheck.
[x] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for 61e1f7b4840457d4895b1bf299cb8d0154e93708 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2479/docs/artifacts/html/index.html


Add email as a data source

People should be able to connect their put their email into Gerev and any incoming emails will be added to their data.
Slack         :  10 million users
Notion        :  10 million users
Confluence    :  25 million users
Email         : 4.4 BILLION users

Ideally, this should be able to access emails sent before joining Gerev too. I think this could be done through the user's google account. That might trigger security concerns in some people, but, if the end product is good enough people will use it despite security concerns. We can just have a subheading that says.
your data is safe
(Also we should actually have good enough security do avoid a data leak)

@yuvalsteuer does this fall in line with your vision?

I don't think choosing a specific platform is the smartest route, maybe go for a generic IMAP implementation and let the user choose which email provider to use.
@NathanCrotty If you don't want to work on this I would gladly take it.

What's easier to setup?
Also Nathan went dormant


Added hidden Estimated field in the Rows column on the Profile page.

@agozhiy could you please review the PR?

+1.


Bump version: 1.7.2 → 1.8.0

prepares release of 1.8.0

replaced by https://github.com/MannLabs/alphadia/pull/342


ION_COLLECTION API is unusable

Public header uses IPCN_pNODE_TO_pDATA macro defined in private ion_collection_impl.h.

Additionally, IPCN_pDATA_TO_pNODE seems to be one pointer indirection off.
Which begs the questions, why ion collections are abstracted to obscurity, when they're just a DLL on pointers, and the whole implementation seems to depend on the fact, that it's just managing pointers?

~Additionally, IPCN_pDATA_TO_pNODE seems to be one pointer indirection off.~

Maybe rather something else going on there.


Make ASP.NET Core Events Opt-In

Remove collection of Microsoft-AspNetCore-Hosting and Microsoft-ApplicationInsights-Core.
Make ASP.NET Core DiagnosticSource events opt-in via /AspNetCoreStartStop.
Automatically enable ASP.NET Core DiagnosticSource events when /ThreadTime is specified unless /AspNetCoreStartStop:false is specified to explicitly opt-out.

cc: @stephentoub, @davidfowl

A couple of questions:

Does this change turn on the ASP.NET Core diagnostic source events? I don't understand where that happens. I only see the HttpClient events.
We changed the name of the ASP.NET Core event source in hosting (https://github.com/dotnet/aspnetcore/blob/dec7382dcf1bf1eab4863df27053525a769c9cb5/src/Hosting/Hosting/src/Internal/HostingEventSource.cs#L25). It's Microsoft.AspNetCore.Hosting
We have a KestrelEventSource as well (https://github.com/dotnet/aspnetcore/blob/dec7382dcf1bf1eab4863df27053525a769c9cb5/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelEventSource.cs#L15). That has much more details start stop information.

We have Start/Stop events that take advantage of ETW/EventSource activity ids for correlation. The diagnostic source events I assume are required for diagnostic source/open telemetry/activity like operations. Which ones do we care about more?

Per conversation with @davidfowl, I want to investigate these other EventSources.


remove ~ icon/info on top

Hi, the documentation is not too well explained, how can hide the first symbol that tells me how long I've been working on a document? the '~'
Thank you

Could you be more specific ?

how can hide the first symbol that tells me how long I've been working on a document?

the '~'

Could you please be more specific about your issue ?

how can hide the first symbol that tells me how long I've been working on a document? the '~'

~ shows your current working directory is the user home. It will change if you cd into other directory. It doesn't mean how long you've been working on a document.
Provide information required on issue template.

I went back to the plain setup, I needed that dir out of there for more simplicity, thanks


Elton v1.4 fix bugs

To note:
Close the issues when you are done checking TQ. 😄

[ ] I think it is more intuitive to allow group creation only in group view.
[ ] I think it is more intuitive if group commands will make it stay in group list.
[ ] It will be quite painful to check the testcases srry. 😢 Life is pain.
[ ]  #225
[ ]  #221
[ ]  #202
[ ]  #190
[ ]  #219
[ ]  #217
[ ]  #216
[ ]  #208
[ ]  #209
[ ]  #183
[ ]  #188
[ ]  #213
[ ]  #174
[ ]  #171
[ ]  #172
[ ]  #166

Codecov Report

Merging #228 (6dff0d8) into master (17eba21) will decrease coverage by 0.23%.
The diff coverage is 1.72%.

@@             Coverage Diff              @@
##             master     #228      +/-   ##
============================================
- Coverage     36.46%   36.22%   -0.24%
  Complexity      497      497
============================================
  Files           182      182
  Lines          3162     3180      +18
  Branches        359      362       +3
============================================
- Hits           1153     1152       -1
- Misses         1910     1929      +19
  Partials         99       99

Impacted Files
Coverage Δ

...c/main/java/seedu/notor/commons/core/Messages.java
0.00% <ø> (ø)

src/main/java/seedu/notor/logic/LogicManager.java
29.26% <0.00%> (-0.74%)
:arrow_down:

...edu/notor/logic/executors/group/GroupExecutor.java
0.00% <0.00%> (ø)

...notor/logic/executors/group/GroupFindExecutor.java
0.00% <0.00%> (ø)

...logic/executors/group/PersonGroupListExecutor.java
0.00% <0.00%> (ø)

.../logic/executors/group/SubGroupCreateExecutor.java
0.00% <0.00%> (ø)

...or/logic/executors/group/SubGroupListExecutor.java
0.00% <0.00%> (ø)

...ogic/executors/group/SuperGroupCreateExecutor.java
0.00% <0.00%> (ø)

...gic/executors/person/PersonArchiveAllExecutor.java
0.00% <0.00%> (ø)

.../logic/executors/person/PersonArchiveExecutor.java
0.00% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eba21...6dff0d8. Read the comment docs.

[ ] Todo: #214


AWS mapper consumes MEA from te topics.

Consume:

measurements from te/+/+/+/+/m/+
events from te/+/+/+/+/e/+
alarms from te/+/+/+/+/a/+
health status from te/+/+/+/+/status/health

Use the EntityStore to get the device names from device topic identifiers and use the device name in the aws topic.

@reubenmiller one needs to clarify the expectation about device identification in the aws output topics.

Do we change nothing? i.e te/device/child-xyz///m/m-type is sent to aws/td/device/child-xyz///m/m-type ?
Do we replace the device topic id by the device name:  .e te/device/child-xyz///m/m-type is sent to aws/td/device-xyz/m/m-type ?

@reubenmiller one needs to clarify the expectation about device identification in the aws output topics.

Do we change nothing? i.e te/device/child-xyz///m/m-type is sent to aws/td/device/child-xyz///m/m-type ?
Do we replace the device topic id by the device name:  .e te/device/child-xyz///m/m-type is sent to aws/td/device-xyz/m/m-type ?

Yes this raises interesting questions. Someone will need to invest some time to finding out about AWS handling of child devices. Otherwise if time is not available then I would do the "as is" approach (option 1).

@reubenmiller one needs to clarify the expectation about device identification in the aws output topics.

Do we change nothing? i.e te/device/child-xyz///m/m-type is sent to aws/td/device/child-xyz///m/m-type ?
Do we replace the device topic id by the device name:  .e te/device/child-xyz///m/m-type is sent to aws/td/device-xyz/m/m-type ?

Yes this raises interesting questions. Someone will need to invest some time to finding out about AWS handling of child devices. Otherwise if time is not available then I would do the "as is" approach (option 1).

Attached is an doc that I was using as info how AWS IoT is handling groups, does not handle child devices as such but hierarchy groups (which is same, I guess), maybe it can help
iot-dg.pdf

@reubenmiller one needs to clarify the expectation about device identification in the aws output topics.

Do we change nothing? i.e te/device/child-xyz///m/m-type is sent to aws/td/device/child-xyz///m/m-type ?
Do we replace the device topic id by the device name:  .e te/device/child-xyz///m/m-type is sent to aws/td/device-xyz/m/m-type ?

Yes this raises interesting questions. Someone will need to invest some time to finding out about AWS handling of child devices. Otherwise if time is not available then I would do the "as is" approach (option 1).

Went with Option 1 as of now, and the topics will be below
Te/device/main///m/m_type ->aws/td/device:main/m/m_type
Te/device/main/service/s-name/m/m_type->aws/td/device:main:service:s-name/m/m_type

Te/device/child///m/m_type ->aws/td/device:child/m/m_type
Te/device/child/service/s-name/m/m_type->aws/td/device:child:service:s-name/m/m_type

QA has thoroughly checked the feature and here are the results:

[x] Test for ticket exists in the test suite.
tests/RobotFramework/tests/mqtt/custom_sub_topics_tedge-mapper-aws.robot
tests/RobotFramework/tests/tedge/call_tedge_config_list.robot
[x] QA has tested the bug and could not reproduce it anymore.


Wrong clipping in render control [question]

This question relates latest release of anycad in general. I ask it here.
I have followed code in examples and added a box to scene:
            var box = ShapeBuilder.MakeBox(GP.XOY(), 10, 20, 30);
            mRenderView.ShowShape(box, Vector3.LightGray);

and got such result with clipped planes:

Example shows fine. Are there any additional settings to fight off those clippings?

mRenderView.ZoomAll(); helped


SUPPLICANT_CONNECTION_CHANGE_ACTION is deprecated in API 28

Hello,
following the SDK docs I have noticed that when registering a broadcast receive to retrieve connection change events we're required to use IntentFilter(WifiManager.SUPPLICANT_CONNECTION_CHANGE_ACTION).
It looks like now that SUPPLICANT_CONNECTION_CHANGE_ACTION has been deprecated since API 28, and by the looks of it there's no quick way around this. What would you suggest here?
Thanks

@beraldofilippo thanks for the heads up.  We will look into it.  In the meantime.  Just don't register the event rescheduler for the supplicant connection change.

https://github.com/optimizely/android-sdk/releases/tag/3.10.0
It's been removed


Use index select in BART positional embedding for better tile placement

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Vim 8.0/GTK3 Copying using "+y in 'gvim' with 2+ tabs creates a black border around the text area

Steps to reproduce:

Open 'gvim'
Open a new blank tab
In any of the tabs, write some text, visually select it.
Copy text selection to the 'system' clipboard using "+y
A black border appears with its boundaries starting below the line of tabs, ending one row below the status line, left of the scrollbar, and the leftmost edge of the window.

The 'border' does not go away by reloading the buffer using :e or :redraw, or resizing the window (border also resizes) and is present for all the tabs, not just the one you performed the copy in.
(On Fedora 24)
$ vim --version

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec  5 2016 19:41:14)
Included patches: 1-124
Modified by<EMAIL_ADDRESS>Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
-balloon_eval    +folding         +mouse_xterm     +termguicolors
-browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     +gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
-clientserver    +insert_expand   +packages        -toolbar
-clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        +perl/dyn        +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       +python/dyn      +vreplace
+cscope          +lispindent      +python3/dyn     +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con      +lua/dyn         +rightleft       +writebackup
+diff            +menu            +ruby/dyn        -X11
+digraphs        +mksession       +scrollbind      -xfontset
-dnd             +modify_fname    +signs           -xim
-ebcdic          +mouse           +smartindent     -xpm
+emacs_tags      -mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      -xterm_clipboard
+ex_extra        +mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/etc"
 f-b for $VIMRUNTIME: "/usr/share/vim/vim80"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2 -g -pipe -Wall -Werror=format-security -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fstack-protector -rdynamic -Wl,-export-dynamic -Wl,--enable-new-dtags -Wl,-z,relro   -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -Wl,--as-needed -o vim        -lm -lnsl  -lselinux   -lncurses -lacl -lattr -lgpm -ldl   -Wl,--enable-new-dtags -Wl,-z,relro  -Wl,-z,relro  -fstack-protector-strong -L/usr/local/lib  -L/usr/lib64/perl5/CORE -lperl -lpthread -lresolv -lnsl -ldl -lm -lcrypt -lutil -lc

A screenshot:
The top window was where a copy was performed, and the black border is seen. The bottom window is the default, pre-copy state.

I realized vimm --version slightly differs from gvim --version, so here is the latter:
$ gvim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec  5 2016 19:40:36)
Included patches: 1-124
Modified by<EMAIL_ADDRESS>Compiled by<EMAIL_ADDRESS>Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
+balloon_eval    +folding         +mouse_xterm     +termguicolors
+browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     +gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
+clientserver    +insert_expand   +packages        +toolbar
+clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        +perl/dyn        +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       +python/dyn      +vreplace
+cscope          +lispindent      +python3/dyn     +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con_gui  +lua/dyn         +rightleft       +writebackup
+diff            +menu            +ruby/dyn        +X11
+digraphs        +mksession       +scrollbind      -xfontset
+dnd             +modify_fname    +signs           +xim
-ebcdic          +mouse           +smartindent     +xpm
+emacs_tags      +mouseshape      +startuptime     +xsmp_interact
+eval            +mouse_dec       +statusline      +xterm_clipboard
+ex_extra        +mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "/etc/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/etc"
 f-b for $VIMRUNTIME: "/usr/share/vim/vim80"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -O2 -g -pipe -Wall -Werror=format-security -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fstack-protector -rdynamic -Wl,-export-dynamic -Wl,--enable-new-dtags -Wl,-z,relro   -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -Wl,--as-needed -o vim   -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lSM -lICE -lXpm -lXt -lX11 -lSM -lICE  -lm -lnsl  -lselinux   -lncurses -lacl -lattr -lgpm -ldl   -Wl,--enable-new-dtags -Wl,-z,relro  -Wl,-z,relro  -fstack-protector-strong -L/usr/local/lib  -L/usr/lib64/perl5/CORE -lperl -lpthread -lresolv -lnsl -ldl -lm -lcrypt -lutil -lc

I don't see this problem but it may be because I use text-style tabs, even in the GUI. Here's how:
if has('windows') && exists('+tabline')
  function MyTabLine()
    let rv = ''
    let i = 1
    while i <= tabpagenr('$')
      let rv .= '%#Normal#'
      let icur = tabpagewinnr(i)
      let imax = tabpagewinnr(i, '$')
      let rv .= '%' . i . 'T'
      let rv .= i . '|' . icur . ':' . imax . ' '
      if i == tabpagenr()
        let rv .= '%#NonText#'
      else
        let rv .= '%#SpecialKey#'
      endif
      let buf = fnamemodify(bufname(tabpagebuflist(i)[icur-1]),':t')
      if buf == ""
        let buf = '[NoName]'
      endif
      let rv .= buf . ' '
      let i += 1
    endwhile
    let rv .= '%T%=%999X%#Error#X%#Normal#%X'
    return rv
  endfunction
  set tabline=%!MyTabLine()
  set showtabline=2
  set guioptions-=e
endif

The function constructs the full tab line, 'showtabline' set to 2 displays it always (even if there is only one tab page), and removing the e flag from 'guioptions' sets the tabline to text-style.
Best regards,
Tony.

I can't reproduce, either.
IIRC,  we got a similar report several months ago, and that report told us the border color was blue.
Vim's gtk3 gui code draws the background in a single solid color when it does, and the color is determined only by the value of Normal guibg, not on an arbitrary color like black or blue.
Accordingly,  I now suspect that the unexpected border color in question comes from system-wide configuration.

@tonymec Thanks, using that does get rid of the border, but I think I rather prefer the visual/gui tab line..
@nuko8 Any pointers to what in the systemwide configuration could it be?
It is interesting that the border isn't always there, but appears when doing the copy, and as of today, I'm getting it to appear even by simply doing a visual selection.

@stellarhopper

Any pointers to what in the systemwide configuration could it be?

I don't know any pointer other than every version of the GTK+ 3 source code and its reference manual.

It is interesting that the border isn't always there,

Once you read the GTK+ GUI code of Vim, you'll see there's always the border of two pixel points in width, and that Vim paints the border as well as the corresponding interior area in the Normal guibg color every time the screen is cleared.
Therefore, there's no reason Vim fails to repaint it.   If there's something interfere with what Vim tries to do, it could be the window manager or compositor, or could be a bug of GTK+ 3 in use.  That's what I meant by "system configuration."

but appears when doing the copy, and as of today, I'm getting it to appear even by simply doing a visual selection.

As I wrote, I couldn't reproduce your issue.  Usually, that means I couldn't get any clue useful to fix the issue from your report, not that I don't believe you.  One cannot go further for fixing a bug when he cannot reproduce it for himself, can he?  Repeating a statement similar to the first post is not helpful at all.

FWIW, I can reproduce this on a fresh Fedora 24 VM.

Compiling vim from current git (c4bfedabe057c05f09a455a5851089e177fa9c00) on Fedora 24 still has the same problem.
$ ./vim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec 14 2016 18:12:27)
Included patches: 1-134
Compiled by vverma7@fedora-test
Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
+balloon_eval    +folding         +mouse_xterm     +termguicolors
+browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     +gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
+clientserver    +insert_expand   +packages        +toolbar
+clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        -perl            +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       -python          +vreplace
+cscope          +lispindent      -python3         +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con_gui  -lua             +rightleft       +writebackup
+diff            +menu            -ruby            +X11
+digraphs        +mksession       +scrollbind      -xfontset
+dnd             +modify_fname    +signs           +xim
-ebcdic          +mouse           +smartindent     +xpm
+emacs_tags      +mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      +xterm_clipboard
+ex_extra        -mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L/usr/local/lib -Wl,--as-needed -o vim   -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lXpm -lXt -lX11 -lSM -lICE  -lm -ltinfo -lelf -lnsl  -lselinux -lacl -lattr -ldl

Can't reproduce with the gtk3 on Fedora 25 (either using Fedora vim or self compiled).

okay closing then.


Design a process diagram

Create a diagram, chart or visualization that explains our process and/or how one might string activities together when working on a project.
We have visualized this several times before, but it would be nice, now that we have these writeups to link activities to phases.

I have this little chart hanging in my office - sometimes we replace Jira with Github or other tools.

Thanks for those images, @iamjessklein - Right now I'm working on whiteboarding a new version of the diagram using a double diamond model. I want to begin moving my work into a collaborative online space for us to work with, hopefully today.

@pamela-drouin - your initial diagram is great, you are headed in the right direction. I added comments directly on the RealBoard, but here is some high level feedback:

whenever possible we should try to avoid - or deconstruct - design jargon
let's try to break this down into tags so that we can dynamically populate methods onto this chart
we need a simplified view - something like - how an idea becomes a product

I moved the design process diagram to Realtime Board for remote collaboration. Shared it internally at our design crit for some initial feedback from the group, and I now have more refinement to do! Thanks for your feedback, @iamjessklein!

Ill be the final sign off on this.

@pamela-drouin - can you provide a screenshot/link of your latest thinking on this so that we can assess how to incorporate it into the Sol Lewitt milestone?

Here is the latest take on the process diagram - big question - is this too visually complicated? Would love non - designer feedback here.

I think people unfamiliar with this or similar models will question the ramp up, ramp down. What's at the peek of each diamond? Wondering if a more infinity symbol is better (e.g. gentle incline/decline to indicate how integrated all of the phases are?) Color choice – the hard line further separates the phases. On the left, you have generate and synthesize. What would be the labels on the right? Not sure if any of that is helpful...

I am heavily influenced by The British Design Council's Double Diamond Process, and that influence is pretty clear in @iamjessklein's last iteration. I've taken a different approach to conveying the design process, because I agree that the diagram may be getting in the way of the message, especially for folks who might not get the source of the inspiration.

I wanted to simplify that double diamond, which is why I've broken it into two main "milestones" (Discovery and Delivery, or "define the problem, design the solution") as well as two phases within each of those milestones (Explore and Define, Make and Validate). I'm hoping that the icons are more clear as to the characteristics of each phase.
I am iffy on a few things:

The word choice of "Delivery" for the second "milestone"
What to call those two "milestones" of Discover and Deliver - is milestone the right word?
How to explain the initial project brief and why there needs to be a revised one at the completion of Discover. Maybe that belongs outside of this diagram, as more of a project management issue, but I'd love discussion on that.

Great work @pam.
I agree with your intuitive response to the term "delivery." I am turned
off by the term because it implies some for. Of a handoff. A term that I've
heard us use internally at Bocoup is "implementation." I'm not 100% in love
with the term but it feels like it's in the right direction.
I also love that you've iterated beyond the double diamond. I am wondering
if all the icons are proportional to one another. Just eyeballing them
feels a touch off.
Re: design brief and other terminology. I would love feedback from a non
designer here. Test this out to see how digestible it is. Get feedback from
@iros and @mattsurabian
On Thu, Feb 9, 2017 at 11:28 PM Pamela Drouin<EMAIL_ADDRESS>wrote:

I am heavily influenced by The British Design Council's Double Diamond
Process, and that influence is pretty clear in @iamjessklein
https://github.com/iamjessklein's last iteration. I've taken a
different approach to conveying the design process, because I agree that
the diagram may be getting in the way of the message, especially for folks
who might not get the source of the inspiration.
[image: design process revised draft]
https://cloud.githubusercontent.com/assets/5949769/22805573/0dd07e58-eed3-11e6-964f-2fc36f221ec7.png
I wanted to simplify that double diamond, which is why I've broken it into
two main "milestones" (Discovery and Delivery, or "define the problem,
design the solution") as well as two phases within each of those milestones
(Explore and Define, Make and Validate). I'm hoping that the icons are more
clear as to the characteristics of each phase.
I am iffy on a few things:

The word choice of "Delivery" for the second "milestone"
What to call those two "milestones" of Discover and Deliver - is
milestone the right word?
How to explain the initial project brief and why there needs to be
a revised one at the completion of Discover. Maybe that belongs outside of
this diagram, as more of a project management issue, but I'd love
discussion on that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bocoup/opendesignkit/issues/56#issuecomment-278795216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgp5BE2KcV9OmvDx1oQ2MKJ6NfzAEHZks5ra5MUgaJpZM4I2efQ
.

--
Jess Klein
@iamjessklein | bocoup.com
http://bocoup.com

Today we identified 4 tasks required in order to complete this issue:

[ ] 1 pager printable
[ ] Process page on ODK
[ ] Set of slides explaining the process (update of slide deck)
[ ] Embeddable framework that will go on Design Brief and Handoff Docs

cc/ @pamela-drouin @isaacdurazo @MattSurabian

Here's a mockup of the design process page. I'm not happy with the state of the phase descriptions, but I'm sharing it out so I don't run around in circles over the words. Would love feedback and dialog! Mockup is in InVision: https://invis.io/S2B00K1CJ#/227060831_Design_Process_Layout

^^ @iamjessklein @isaacdurazo @mjchamplin @MattSurabian

The process diagram is now up on http://opendesignkit.org/process/


Keep past tournament predictions

Add ability to review past predictions, add support for retrofitting old tournaments with backward in time predictions.

Completed


Add a C++ implementation for ACES Metadata File (AMF) support

OCIO has a Python script (pyocioamf) that converts an AMF file into a CTF that implements the parts of the processing pipeline that the AMF file indicates still need to be applied. This has been useful for the community as a fairly complete open source implementation of AMF. However, this script does not fully meet the potential needs of AMF implementers for several reasons, including:

It may be difficult to call the Python script from a conventional C++ application program.
The script does not give any flexibility in terms of applying arbitrary parts of the AMF pipeline.

The next steps have been a topic of conversation at OCIO TSC meetings in recent months and the group felt that the best and most flexible approach would be to convert the AMF into an OCIO config rather than a CTF. The config would then allow implementers to apply any steps in the pipeline as desired. For example, they could explore advanced use-cases such as inverting steps that had already been applied or omitting steps (e.g. certain looks) that may no longer be desired.
The meeting discussions suggested the following mapping from AMF to OCIO config:

Each AMF look should become an OCIO Look, that may be applied independently (or reversed), if desired.
The AMF output transform should become the default display and view.
The implementation should draw on the latest built-in ACES Studio config in OCIO 2.3 which contains ACES transform IDs.
If the input is a digital camera log color space, the corresponding linear space should also be added, for use in VFX.
The resulting config should be compatible with config merge workflows (e.g., names should be unique).

I'm attaching to this issue an example AMF file and a corresponding OCIO config that's in line with the discussions. There are a few details worth calling out:

A role has been added (amf_clip_a001a020) to indicate the color space of the associated media.
The active_display and active_view are configured based on the AMF output transform.
A look has been added to the active_view that implements the unapplied looks (in this case, all the looks still need to be applied, but in general that may not be the case).
There is an OCIO Look for each AMF look plus another one that has all of the unapplied looks.
The design of the looks allows a user to create a DisplayViewTransform that uses the clip color space role as the source and the active display/view as the destination and it will convert the clip into the output color space in accordance with the full AMF pipeline.
The search_path in the example is set to '.', which would be fine if the config were written to the same directory as the AMF, but we're looking for input on how to handle file paths from the AMF. Should the search_path be set to the absolute directory of the AMF file?

We have a contributor that has kindly offered to implement this in OCIO, so we would appreciate timely feedback on the proposed approach.
amf-example.zip

Hello Mr. Walker, Please forgive my ignorance but is there a script that converts a CTF to an AMF? I recently requested AMF export compatibility from Flame. From your email it suggests that one half of that equation (AMF to CTF) already exists. Respectfully, Phil Phil MAN @.*** +1<PHONE_NUMBER> On Jan 8, 2024, at 8:47 PM, Doug Walker @.> wrote: OCIO has a Python script (pyocioamf) that converts an AMF file into a CTF that implements the parts of the processing pipeline that the AMF file indicates still need to be applied. This has been useful for the community as a fairly complete open source implementation of AMF. However, this script does not fully meet the potential needs of AMF implementers for several reasons, including: It may be difficult to call the Python script from a conventional C++ application program. The script does not give any flexibility in terms of applying arbitrary parts of the AMF pipeline. The next steps have been a topic of conversation at OCIO TSC meetings in recent months and the group felt that the best and most flexible approach would be to convert the AMF into an OCIO config rather than a CTF. The config would then allow implementers to apply any steps in the pipeline as desired. For example, they could explore advanced use-cases such as inverting steps that had already been applied or omitting steps (e.g. certain looks) that may no longer be desired. The meeting discussions suggested the following mapping from AMF to OCIO config: Each AMF look should become an OCIO Look, that may be applied independently (or reversed), if desired. The AMF output transform should become the default display and view. The implementation should draw on the latest built-in ACES Studio config in OCIO 2.3 which contains ACES transform IDs. If the input is a digital camera log color space, the corresponding linear space should also be added, for use in VFX. The resulting config should be compatible with config merge workflows (e.g., names should be unique). I'm attaching to this issue an example AMF file and a corresponding OCIO config that's in line with the discussions. There are a few details worth calling out: A role has been added (amf_clip_a001a020) to indicate the color space of the associated media. The active_display and active_view are configured based on the AMF output transform. A look has been added to the active_view that implements the unapplied looks (in this case, all the looks still need to be applied, but in general that may not be the case). There is an OCIO Look for each AMF look plus another one that has all of the unapplied looks. The design of the looks allows a user to create a DisplayViewTransform that uses the clip color space role as the source and the active display/view as the destination and it will convert the clip into the output color space in accordance with the full AMF pipeline. The search_path in the example is set to '.', which would be fine if the config were written to the same directory as the AMF, but we're looking for input on how to handle file paths from the AMF. Should the search_path be set to the absolute directory of the AMF file? We have a contributor that has kindly offered to implement this in OCIO, so we would appreciate timely feedback on the proposed approach. amf-example.zip — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you are subscribed to this thread. Message ID: @.>

Hi Phil, there is no script to convert a CTF to an AMF. In order to write something like that, there would need to be a way to define which operators apply to which steps in the AMF. The XML could contain this extra metadata but it would be a big task to define how it should work.
The script for the AMF to CTF direction is located along with the other tools in the repo here.

Thanks for the thorough description @doug-walker, just as an illustration I'm attaching an archive illustrating what I was thinking when mentioning the applied / un-applied looks categorisation might be unneeded. Note that I changed the AMF to apply the IDT and first 2 looks. The AMF CLIP colour space invert those 2 looks then the output transform always apply all looks for the shot using the SHOT_LOOKS environment variable. It is possible I overlooked some workflows / use case that would not work with this scheme, please let me know.
amf-example2.zip


Background(Canvas) change problem

We faced some strange error when we dynamically changed background(canvas).
Part of kv file where we changing background:
canvas.before:
    Rectangle:
    size: self.size
source: "data/images/" + root.theme + ".png"

Py file regarding the theme:
...
themeList = ListProperty (["Dark", "Light"])
...

for i in range (0, len (self.themeList)):
                        if self.theme == self.themeList[i]:
                                currentTheme = i
                                break
                if (currentTheme == 0):
                        currentTheme = len (self.themeList) - 1
                else:
                        currentTheme -= 1
                self.theme = self.themeList[currentTheme]

When change theme on by button click, the following error raised:
 Traceback (most recent call last):
 File "main.py", line 2120, in <module>
 ClockApp().run()
 File "/usr/local/lib/python2.7/dist-packages/kivy/app.py", line 824, in run
 runTouchApp()
 File "/usr/local/lib/python2.7/dist-packages/kivy/base.py", line 484, in runTouchApp
 EventLoop.window.mainloop()
 File "/usr/local/lib/python2.7/dist-packages/kivy/core/window/window_egl_rpi.py", line 77, in mainloop
  self._mainloop()
  File "/usr/local/lib/python2.7/dist-packages/kivy/core/window/window_egl_rpi.py", line 72, in _mainloop
  EventLoop.idle()
  File "/usr/local/lib/python2.7/dist-packages/kivy/base.py", line 330, in idle
  Builder.sync()
  File "/usr/local/lib/python2.7/dist-packages/kivy/lang.py", line 2082, in sync
   call_fn(next_args[:-1], None, None)
  File "/usr/local/lib/python2.7/dist-packages/kivy/lang.py", line 1477, in call_fn
 setattr(element, key, e_value)
  File "kivy/graphics/instructions.pyx", line 359, in kivy.graphics.instructions.VertexInstruction.source.__set__ (kivy/graphics/instructions.c:6840)
  File "kivy/graphics/context_instructions.pyx", line 381, in kivy.graphics.context_instructions.BindTexture.source.__set__ (kivy/graphics/context_instructions.c:7271)
  File "/usr/local/lib/python2.7/dist-packages/kivy/core/image/__init__.py", line 511, in __init__
 self.filename = arg
  File "/usr/local/lib/python2.7/dist-packages/kivy/core/image/__init__.py", line 699, in _set_filename
 mipmap=self._mipmap, nocache=self._nocache)
  File "/usr/local/lib/python2.7/dist-packages/kivy/core/image/__init__.py", line 429, in load
 im = loader(filename, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/kivy/core/image/__init__.py", line 197, in __init__
 self._data = self.load(filename)
 File "/usr/local/lib/python2.7/dist-packages/kivy/core/image/img_pygame.py", line 86, in load
 (filename, im.fmt))
 AttributeError: 'pygame.Surface' object has no attribute 'fmt'

Can you advise what can be done in such situation?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I also have this issue. I'm loading an Async image. I'm running on a Raspberry Pi 2.
[INFO              ] [Logger      ] Record log in /home/pi/.kivy/logs/kivy_15-09-11_10.txt
[INFO              ] [Kivy        ] v1.9.1-dev
[INFO              ] [Python      ] v2.7.3 (default, Mar 18 2014, 05:13:23)
[GCC 4.6.3]
[INFO              ] [Factory     ] 177 symbols loaded
[INFO              ] [Image       ] Providers: img_tex, img_dds, img_gif, img_pygame, img_pil (img_ffpyplayer ignored)
[INFO              ] [Text        ] Provider: pygame
[INFO              ] [Window      ] Provider: egl_rpi
[INFO              ] [GL          ] OpenGL version <OpenGL ES 2.0>
[INFO              ] [GL          ] OpenGL vendor <Broadcom>
[INFO              ] [GL          ] OpenGL renderer <VideoCore IV HW>
[INFO              ] [GL          ] OpenGL parsed version: 2, 0
[INFO              ] [GL          ] Shading version <OpenGL ES GLSL ES 1.00>
[INFO              ] [GL          ] Texture max size <2048>
[INFO              ] [GL          ] Texture max units <8>
[INFO              ] [Shader      ] fragment shader: <Compiled>
[INFO              ] [Shader      ] vertex shader: <Compiled>
[INFO              ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO              ] [Loader      ] using a thread pool of 2 workers
[INFO              ] [OSC         ] using <multiprocessing> for socket
[INFO              ] [ProbeSysfs  ] device match: /dev/input/event0
[INFO              ] [HIDInput    ] Read event from </dev/input/event0>
[INFO              ] [ProbeSysfs  ] device match: /dev/input/event1
[INFO              ] [HIDInput    ] Read event from </dev/input/event1>
[INFO              ] [ProbeSysfs  ] device match: /dev/input/event2
[INFO              ] [HIDInput    ] Read event from </dev/input/event2>
[INFO              ] [Base        ] Start application main loop
[INFO              ] [HIDMotionEvent] using <ADS7846 Touchscreen>
[INFO              ] [HIDMotionEvent] using <SIGMACHIP USB Keyboard>
[INFO              ] [HIDMotionEvent] using <SIGMACHIP USB Keyboard>
[INFO              ] [HIDMotionEvent] <ADS7846 Touchscreen> range ABS X position is 0 - 4095
[INFO              ] [HIDMotionEvent] <ADS7846 Touchscreen> range ABS Y position is 0 - 4095
[INFO              ] [HIDMotionEvent] <ADS7846 Touchscreen> range ABS pressure is 0 - 255
'pygame.Surface' object has no attribute 'fmt'

Closing as Pygame is no longer supported.


Refactor sa_CallExpression

Refactor sa_CallExpression in order to eliminate duplication and to prepare for moving bulk of the symbol-manipulating an checking code to sa_Variable and sa_MemberExpression.
Part of work on #419.

@bkutil

+1


Implement quick and dirty script for setting venvs to compare cairo-lang with cairo-rs-py

The scripts does the following:

Install two venvs, cairo-rs-py and cairo-lang;
Install cairo-lang in both environments;
In cairo-rs-py it installs cairo-rs-py and applies a patch implementing the changes we had to do to cairo-lang to run with our VM in the installed package;
Runs starknet --version and cairo-run --version in the cairo-rs-py venv to confirm it's using our VM.

Remaining work: a little README explaining the usage.

Codecov Report

Merging #158 (08fcbf0) into main (6d51a41) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   70.68%   69.92%   -0.76%
==========================================
  Files          12       12
  Lines         672      685      +13
==========================================
+ Hits          475      479       +4
- Misses        197      206       +9

Impacted Files
Coverage Δ

src/memory.rs
76.00% <0.00%> (-14.48%)
:arrow_down:

src/cairo_runner.rs
69.61% <0.00%> (-0.91%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Github workflow

To simplify the development, use GitHub workflows to test lambda, build the application, and push the latest to AWS automatically on git push.

working on this :)

The deploy workflow is running on forked repos too,

Added github workflows, closing this issue :)


Fix false detection when using superclass properties or constants

This pull request fixes the following bug:
When using superclass properties or constants, they are falsely detected as unused.

Thanks for the feature :+1:
Could you fix the PHPStan CI build?

Thanks for the suggestion. I'm looking into the feature again, and it promotes a pattern that we fight against.
We want to avoid using false owner class, as public element (even constant) from 2 child-parent classes can have different type and value. Exact real reference should be used instead.
I'll keep the current version we have.
Thanks for understanding :+1:

Hi,
I would like an example to help me understand the pattern.
I may have misunderstood the pattern, but in the following simple example, it appears that an error occurs if the parent and child property or constant types are different:
https://onlinephp.io/?s=s7EvyCjg5eLlSs5JLC5WcMvP5-Wq5uXiLChNyslMVkjOzysuUcjMK1Fw9vcLDlGwVTC0RsiCxFUKivILUotKKqFytSDDYMY5JRYppFaUpOal4DK6uKQoMy8dbrp6ojqS-VBJZCsgCmoB&v=8.3.1%2C8.2.14%2C8.1.27%2C8.0.30%2C7.4.33

Hey, only actual class is counted. Not link through child nor parent class


Unit tests

UI is not covered by unit tests. This is open question: how with current resources we can develop unit tests for UI


Local file cache doesn't drop pages when relation is dropped

When a relation is dropped, we don't clean up the pages in the local file cache. That's a problem if OID wraparound has happened, and the same relfilenode is reused for a new relation. The local file cache would mix up return the pages from the dropped relation as belonging to the new relation.
I'm not sure if there's a live bug here: maybe we never try to read a page from the new relation without initializing first. But I wouldn't count on it.

I thought about it. But

Relation size is not cached by LFC. So never can make wrong assumption that relation file exists or its size.
Postgres never tries to read beyondd know relation size
When relate n is extended smgrextend is always called which should fill this pages with zeros (and rewrite correspondent pages in LFC)


chore: fixed graphql query when blocks does not exist

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


HydroDyn WaveStMod=0 Requirement

Hi OpenFAST Team,
Are there any plans to re-introduce the WaveStMod >0 options in HydroDyn? If not, are there any recent branches/forks that re-enable this feature? I'm comfortable recompiling bits of source if they're available, but I'd be more comfortable doing this if it didn't involve commits of a very dated fork/branch.
Alternatively,  are there dated versions of OpenFAST/FAST where this is a valid option?
Best,
Sam

Hi @Sam-Ramsahoye,
See PR https://github.com/OpenFAST/openfast/pull/1008, which is under active development and expected to be released in OpenFAST v4.0.
Best regards,

Thank you Jason! And Lu Wang for the development.
Sam


Add wrapper to T3 for CommonJS

wrapping t3 with a module.exports shim

fixes #24

Hi @j3tan, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

CLA signed

Verified that @j3tan has just signed the CLA. Thanks, and we look forward to your contribution.

+2


Hanging build in iTunes Connect blocks TestFlight uploading flow

New Issue Checklist

[V ] Updated fastlane to the latest version
[V ] I have read the Contribution Guidelines

Issue Description
Uploading of the ipa file to iTunes connect keeps waiting for the build to be processed. The reason for this is that we have an older build that hangs in iTunes Connect and there is no way of cancelling/removing this build (it's already being processed for a week now). I already sent an email to Apple to discuss this problem but until now they didn't respond. I think i'm not the only one that has this problem, isn't it possible to make Fastlane (Pilot) smarter? Right now it keeps waiting until all builds are processed (https://github.com/fastlane/fastlane/blob/master/pilot/lib/pilot/build_manager.rb#L74), maybe we can only wait until the build that we just uploaded is processed. I already looked at the code but i have no idea how i can find the Version / Build number that was currently uploaded? If anyone can put me in the right direction maybe i can create a PR for this.

Seeing the same issue @daanporon: we have a bunch of TestFlight builds in the queue that are all marked as "processing", blocking a new submission. In the past bumping the marketing version worked, but that doesn't seem to help this time. I don't actually see a problem with pilot (I'm using skip_submission, which may be relevant).
Could the submission failure be a result of the way pilot uploads the build? I'm using this setting
ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV"

The underlying issue is clearly on Apple's side, but it'd be interesting how other fastlane users get around this deficiency.

The last few days Apple's processing time was much slower than usually, there is not much we can do unfortunately.
You can always skip the submission so that fastlane tools don't wait for the build to be finished processing.

Wouldn't it be better to just wait for all processing builds with the same version number and build number? In stead of waiting for all the builds to be completed ...
But for this to work we need to export the build number and version number in an earlier action i suppose ... maybe the gym action? I think this will be more stable at least ..

I was seeing this same thing, and it waiting for old, failed, builds explains things.  But it is a bummer, since these old builds will never complete processing.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (483/400 (120%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o5.sgmail.github.com ([<IP_ADDRESS>]:28902)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKu2-002lp8-2n
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:23:32 +0200
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=M3WWFUMaPijkOyl/3beUAhaYtbo=; b=Sd+XwhQaUYQDAGKj
gVhIaUW/oxlsalPwcXiTqHCcAHAW6DyuaFpgmGj74AzkiPgH7kqO5be0Y6o3TJOK
PnPNpR91cyg1ceR/V001aHCmuy66meKfFYDL1uQ1W3e9aEnCnRozbC3ymXetY6YX
OfEh7O3Wh7TG5m/P0AVZZ5BfON4=
Received: by filter0843p1mdw1.sendgrid.net with SMTP id filter0843p1mdw1.22258.576591761A
2016-06-18 18:22:46.353999491 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id Hxt6Laq7SvuBr5aKH62-5Q
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 18:22:46.314 +0000 (UTC)
Date: Sat, 18 Jun 2016 11:22:46 -0700
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] Hanging build in iTunes Connect blocks
TestFlight uploading flow (#3800)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_576591762ebd3_6cdc3fa92afa12bc278427a";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3J7vwcCJo2Hrc5rLSlMh2Ulcy4dkks5qNDd2gaJpZM4HzG_a
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: /bDRkhSo/GH2gzZXMo5AKhbuTgLDPkexBjh/BYa140FugeHdg1qMO9wv1XUBHQu561ycD9Fw15A4FT
mWYrVMD3OzxiUBc4rcodTtGvBOeGlTncxsmS9/D9VRXud8TXEkNk0frLI/sQxjLp7aiRSrBEihMw+f
tm0E6eXknpxYwv0hX371tyL694lhMYM2sZcd2a0gmb/VYqi/himdAFEMe7aAiKuux2llA2Cq23vEXg
I=
X-Spam-Status: No, score=-2.8
X-Spam-Score: -27
X-Spam-Bar: --
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #3800. --- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/fastlane/fastlane/issues/3800#event-696785201
[...]
Content analysis details:   (-2.8 points, 5.0 required)
pts rule name              description

-2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at http://www.dnswl.org/, medium
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
[<IP_ADDRESS> listed in wl.mailspike.net]
-1.4 RP_MATCHES_RCVD        Envelope sender domain matches handover relay domain
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO
----==_mimepart_576591762ebd3_6cdc3fa92afa12bc278427a
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3800.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/3800#event-696785201
----==_mimepart_576591762ebd3_6cdc3fa92afa12bc278427a
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3800.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_576591762ebd3_6cdc3fa92afa12bc278427a--

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (482/400 (120%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext7.iad.github.net ([<IP_ADDRESS>]:52695 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKtz-002lox-HH
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:23:31 +0200
Date: Sat, 18 Jun 2016 11:22:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1466274166;
bh=ASYMOM0NT0Aa97KscGMBrh3ejOu8OMhiZXZ2pIo4Acw=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=Q8V4xPcPvvGWhGj6By8vuI8xjZyr4YFI5UEWT3YhKMsH3AKhJdU+FxoC4M3LYirBR
W8+WFftIJVrFYOEn8xrxtuytMozDo1Z/kmLUF4B1VzMxJWyB/U1DSy6/vvKrEP053Q
P5Jmxdfbqi/oye5noAR3FfVMjqLY5+yewqTZ3O3E=
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] Hanging build in iTunes Connect blocks
TestFlight uploading flow (#3800)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_576591767778_70053f922c1812a03912df";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3J7vwcCJo2Hrc5rLSlMh2Ulcy4dkks5qNDd2gaJpZM4HzG_a
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-4.1
X-Spam-Score: -40
X-Spam-Bar: ----
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  This issue will be auto-closed because there hasn't been any
activity for a few months. Feel free to open a new one
if you still experience this problem 👍 [...]
Content analysis details:   (-4.1 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 SPF_PASS               SPF: sender matches SPF record
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_576591767778_70053f922c1812a03912df
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity for=
a few months. Feel free to [open a new one](https://github.com/fastlane/=
fastlane/issues/new) if you still experience this problem =F0=9F=91=8D

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/3800#issuecomment-226957444=
----==_mimepart_576591767778_70053f922c1812a03912df
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity =
for a few months. Feel free to open a new one if you still experience this problem=
 =F0=9F=91=8D
&m=
dash;You are receiving this because you are subscribed to this thre=
ad.Reply to this email directly, view it on GitHub, =
or mute the thread.

----==_mimepart_576591767778_70053f922c1812a03912df--


Local introspection page is in memory

The local introspection page is not updated on the slave nodes, on the master node it's not updated either after a redeploy

The healthCheck is retrieving the latests status from DB but the local introspection page seems to only use the in-memory status of the schedules.

Solved in pull request 15


Use serde_repr for serializing fieldless enums

https://serde.rs/enum-number.html

Nice! Do you want a release with this?

@Marwes yep, this + url 2 release would help!

Done!


unable to add servers on ios

input fields never seem to get focus in mobile safari or the chrome app

Thanks for reporting. Should be fixed now. Please test.

Looks good to me. Thanks!


fix wrong path of nats.go

seems nats-io already mved it ago
err:
stat github.com/nats-io/nats.go: no such file or directory

This is wrong.see readme in nats.go repo you miss slash


[MARKENG-2419][c] Update LC:collection-format-docs to use G-CX7P9K6W6

What are the changes?
Branched from main, this updates the web app to us G-CX7P9K6W6 for GA
Why make these changes?

So that metrics are accurately collected in GA
*no-visuals

wrong branch name


Add support html5 attributes formaction/formmethod... for ActiveForm (yii.activeForm.js)

The correct behavior of the browser is interrupted in the script "yii.activeForm.js" by call $ form.submit ().
To properly occurred sending the form, you can not interrupt the behavior of the browser's default (preventDefault).

I also see this behaviour - I have two submit buttons in a single form with differing "formaction" attribute values however the form is always submitted to the forms "action" attribute value.

@samdark since this is kind of an old issue and noone is assigned I'm not sure if anyone will pick up the PR. If it will be picked up later consider this comment not submitted.


A chained mapper is not reusable

When using the chain method it seems that you cant reuse the mapper again.
  describe("when chain is called twice", () => {
    it("one call should not effect the other", done => {
      secondaryMapper.map("foo").to("bar");
      const actual1 = mapper("foo").chain(secondaryMapper).execute(source);
      expect(actual1).to.equal(expected);
      const actual2 = mapper("foo").chain(secondaryMapper).execute(source);
      expect(actual2).to.equal(expected);
      done();
    });
  });

the line expect(actual2).to.equal(expected); fails with the error:
Expected {} to equal specified value: { bar: 'bar' }
at /mnt/c/_stuff/code/github/map-factory/dist/test/chain-test.js:67:37

It was my understanding that you should be able to create a mapper then use it multiple times, unless im doing something wrong it looks like you cant do that when using the chain method.

chain mutates the mapper so setting chain(secondaryMapper)  once is sufficient.
describe("when chain is called twice", () => {
    it("one call should not effect the other", done => {
      secondaryMapper.map("foo").to("bar");
      const actual1 = mapper("foo").chain(secondaryMapper).execute(source); // mutates mapper
      expect(actual1).to.equal(expected);
      const actual2 = mapper.execute(source); // secondaryMapper will be applied here.
      expect(actual2).to.equal(expected);
      done();
    });
  });

I think i was imagining it was more like an immutable builder pattern where the thing returned is a new instance of the thing. I had not really considered that it would be mutating the mapper in place. It makes sense when you put it in those terms. But from a users perspective (one not familiar with internals) it was a little confusing when putting the whole thing into one line that returns the mapped result.
Given this example (forgive typos ive typed straight into this text box)
var mapper1 = createMapper().map("foo");
var result1 = mapper1.execute(input);
var mapper2 = mapper1.chain(secondaryMapper);
var result2 = mapper2.execute(input);
var result3 = mapper1.execute(input);

I now know that result2 === result3 !== result1
but i expected it to be result1 === result3 !== result2
this is because of the way chaining calls mutates the mapper.
As you said its not wrong, it was just unclear especially when you put it all together thus:
var mapper1 = createMapper().map("foo");
var result1 = mapper1.execute(input);
var result2 = mapper1.chain(secondaryMapper).execute(input);
var result3 = mapper1.execute(input);

again result2 === result3 !=== result1
Is my understanding correct?

That is correct. I'll update the docs to make it more clear.


Received empty audio data array (V1 Firmware Build)

Hello everyone,
I've successfully installed the V1 Release of the Firmware on the chip, and the device is recognized with the LED blinking as expected.
However, upon testing it using either the Python script on my laptop or the online firmware tester tool (Chrome), I encountered the following errors:
Python Script Logs:
Recording audio...
Recording stopped
0
Warning: Received empty audio data array.

Online Firmware Tester Tool Logs:
Starting Bluetooth...
Bluetooth started: started
Opening device...
Device opened: Friend (zkSRZ5uwGXfndd3Ka6qSIQ==)
Service: 19b10000-e8f2-537e-4f6c-d104768a1214
- Characteristic: 19b10001-e8f2-537e-4f6c-d104768a1214
  - canRead: true
  - canWrite: false
  - canNotify: true
- Characteristic: 19b10002-e8f2-537e-4f6c-d104768a1214
  - canRead: true
  - canWrite: false
  - canNotify: false
Target protocol found: pcm-8
Waiting for data...
Total received: 0 bytes, speed: 0 bytes/sec, lost: 0 packets or 0 packets
Total frames: 0
Decoding...
Done!

Additional Information:

MacBook Air Early 2015 running Monterey 12.6
I've attempted to reinstall the software multiple times without success.

I would greatly appreciate any assistance in resolving these issues. Thank you in advance!

@felyu can you confirm whether this is still a problem?

@felyu can you confirm whether this is still a problem?

I've bought a the latest Macbook Air M3 and it's now working!!!


Publish snapshots to maven via GHA

Description
Publish snapshots to maven via GHA
Issues Resolved
[https://github.com/opensearch-project/ml-commons/issues/734 ]https://github.com/opensearch-project/ml-commons/issues/734
Tests
find plugin/snapshots | sort
plugin/snapshots
plugin/snapshots/org
plugin/snapshots/org/opensearch
plugin/snapshots/org/opensearch/plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/maven-metadata.xml.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.pom
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.pom.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.pom.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.pom.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.pom.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.zip
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.zip.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.zip.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.zip.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/opensearch-ml-plugin-<IP_ADDRESS>-20230222.232524-1.zip.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha512

Pending @gaiksaya to create the IAM role that is required to fetch the credentials and add it to the GitHub Secrets.

Codecov Report

Merging #754 (a270b04) into 2.x (973536c) will decrease coverage by 0.07%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x     #754      +/-   ##
============================================
- Coverage     84.39%   84.33%   -0.07%
+ Complexity     1591     1589       -2
============================================
  Files           135      135
  Lines          5935     5935
  Branches        560      560
============================================
- Hits           5009     5005       -4
- Misses          690      693       +3
- Partials        236      237       +1

Flag
Coverage Δ

ml-commons
84.33% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../cluster/MLCommonsClusterManagerEventListener.java
67.64% <0.00%> (-11.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Hi @Zhangxunmt Would suggest to raise this PR against main first. GHA needs to detect the triggers which is against. It can then be backported to other branches


Opening Datepicker on 2nd stacked modal doesn't show

Short description of the problem:
The (date)picker component isn't displayed on top of the top modal in the stack
Steps to reproduce:

Open a modal (Modal 1). From that modal, open another modal (Modal 2)
On Modal 2, use

<ion-datetime displayFormat="DD MM YYYY" [(ngModel)]="startDate"></ion-datetime>

3  Click/tap the  field to start showing the picker. It doesn't appear
4. Close Modal 2: Modal 1 is show, with the picker on top of it
Maybe the picker has the wrong z-index (I'm just guessing here...)
Which Ionic Version? 1.x or 2.x
2.x

Yes, it looks like the ion-picker-cmp has a z-index of 9999 where the modals start at 10000 and increment.
Dirty quick fix...
ion-picker-cmp {
  z-index: 20000 !important;
}```

Hi, I have the same issue opening Loading on Modal 2.
z-index should increase like it does if you open a new Modal from an already opened Modal.

Modal 1: z-index = 9999
Modal 2: z-index = 10000
Loading: z-index = 9999 !!! But has to be 10001

Same issue applies to action sheets and alerts, opened from a second modal

same issue for alerts and toast

Opening alert on page pushed on top of modal is not shown.
It's exactly the same reason explained by @palsch
Please fix.

@itrethan @shuhanxu @cmanou @JeroendeVin
Can you confirm this is still a problem in latest version? according to me test this should be fixed now


Maven archetypes for kotlin version of plugins

I have set the default version of SDK to 5.3. in all the archetypes, so this shouldn't be published to maven before 5.3. is out. This also means that for now the tests are failing as they try to download SDK version 5.3.

I changed the dependency to SDK 5.2. and Kotlin version 1.3.61 so we can merge this without waiting for version 5.3.


Handle images that contain duplicate sha256 layers

I've run into an image that contains duplicate sha256 layers
docker pull index.docker.io/hasura/graphql-engine@sha256:aa508dfa1a887684e3fbf4e045084d6fad8257f565bc99827d4b90dcd5a0254a
docker inspect index.docker.io/hasura/graphql-engine@sha256:aa508dfa1a887684e3fbf4e045084d6fad8257f565bc99827d4b90dcd5a0254a

         "RootFS": {
            "Type": "layers",
            "Layers": [
                "sha256:6021993d84a2d9db89ec74cf44366ae3f2d9f9810f3c77b2bd0cd5ddf14825b1",
                "sha256:e77e0dfc5a653d156055f7262ee9b3202dc47bf3728e38b646ea6c0bea19011f",
                "sha256:1755f0a6c086ce4481af6659aa8c7e5bc50fefbc11ec0659435da60856882959",
                "sha256:b76a02be9f0ebae748887ae7d80faff1b7926fa280c741c1ca0f61cbb0cc3f2d",
                "sha256:38e333f2268b36e11b93daff5ff97782443207ac2068e984fb3bd21172df91b9",
                "sha256:adb0aea3f4ff0fadf90af1a72eeb792b3876afef90eeb4687dc94431bd66eb3f",
                "sha256:5147195cfdac8d087302f1ead5a37f7f74d2691c8a36f4e947e5ca089dd634b0",
                "sha256:d118ddf4315de2c7b453811611f88ae2305bea2875bd93f6596a3489247a6223",
                "sha256:f4a44b248adc792f8844b723a82c1390fcb89bdda3e522fd6d2a3088135105c7",
                "sha256:625e5cec356a004f84203d116e630239caab035f623b973b5653308e71704a27",
                "sha256:36bccf6326a6152eda33902df11d56adefd3b143c81302e35505bd03aff11ab3",
                "sha256:f0badb0d0d5f2cac1deed636936ecadbde56edab98e01c290990596133bf6fc3",
                "sha256:f0badb0d0d5f2cac1deed636936ecadbde56edab98e01c290990596133bf6fc3"
            ]
        },

# WORKSPACE
oci_pull(
    name = "hasura_graphql",
    # tag = "v2.22.0.cli-migrations-v3.ubuntu",
    digest = "sha256:aa508dfa1a887684e3fbf4e045084d6fad8257f565bc99827d4b90dcd5a0254a",
    image = "index.docker.io/hasura/graphql-engine",
 )

# BUILD.bazel
load("@rules_oci//oci:defs.bzl", "oci_image")

oci_image(
    name = "oci_image",
    base = "@hasura_graphql",
    tars = [],
    entrypoint = [],
)

Which leads to
$ bazel build //:oci_image
ERROR: /Users/pkar/.cache/asbazel/output/external/hasura_graphql_single/BUILD.bazel:43:18: Label '@hasura_graphql_single//:7e74cee710158ba3d1c4c71b7b867b1da2be192c04e2ec83a647aaa39618cc1d' is duplicated in the 'srcs' attribute of rule 'blobs'
ERROR: /Users/pkar/.cache/asbazel/output/external/hasura_graphql/BUILD.bazel:1:6: Target '@hasura_graphql_single//:hasura_graphql_single' contains an error and its package is in error and referenced by '@hasura_graphql//:hasura_graphql'
ERROR: Analysis of target '//:oci_image' failed; build aborted:

Patching https://github.com/bazel-contrib/rules_oci/blob/main/oci/private/pull.bzl#L389 with something like
if hash not in tars:
    tars.append(hash)

leads to errors further down during https://github.com/bazel-contrib/rules_oci/blob/main/oci/private/pull.bzl#L316 copy_to_directory
I've gotten around this by first flattening the image and uploading to another registry, however this isn't ideal and I was wondering if maybe there is a better workaround?
If it matters this is in macOS on an m1 processor.

# WORKSPACE
load("@rules_oci//oci:pull.bzl", "oci_pull")

oci_pull(
        name = "hasura",
        # tag = "v2.22.0.cli-migrations-v3.ubuntu",
        digest = "sha256:aa508dfa1a887684e3fbf4e045084d6fad8257f565bc99827d4b90dcd5a0254a",
        image = "index.docker.io/hasura/graphql-engine",
)

# BUILD.bazel
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_push", "oci_tarball")
load("@aspect_bazel_lib//lib:transitions.bzl", "platform_transition_filegroup")

platform(
    name = "linux_amd64",
    constraint_values = [
        "@platforms//os:linux",
        "@platforms//cpu:x86_64",
        "@io_bazel_rules_go//go/toolchain:cgo_off",
    ],
)

oci_image(
    name = "oci_image",
    base = "@hasura",
    tars = [],
    entrypoint = [],
)

platform_transition_filegroup(
    name = "oci_image_linux_amd64",
    srcs = [":oci_image"],
    target_platform = ":linux_amd64",
)

local_image = "abcd:latest"

oci_tarball(
    name = "oci_tarball_linux_amd64",
    image = ":oci_image_linux_amd64",
    repo_tags = [local_image],
)

bazel build //:oci_tarball_linux_amd64
cp: /var/folders/8d/107p3fm10dv8_cd80n6y4tqr0000gn/T/tmp.jG86rjXE/blobs/sha256/7e74cee710158ba3d1c4c71b7b867b1da2be192c04e2ec83a647aaa39618cc1d.tar.gz: Permission denied
Target //build_tools/repositories:oci_tarball_linux_amd64 failed to build
Use --verbose_failures to see the command lines of failed build steps.

fixed by #256

thanks @uhlajs


Update documentation

When updating to the newest version I noticed that the Makefile is gone. I found documentation in the Contributing guidelines, therefore I managed.
But:

README.md still mentions make
npm build didn't create any files - npm test did
twig.min.js is gone?

npm build didn't create any files - npm test did
What version of npm are you on? From memory, npm test is the only default script older npm understands, everything else you would have to say npm run build.

npm run build works. I have version 3.8.6.

I've removed make references from the README in #360


Azure Blob Sink with managed identity throws exception

It should log the error but not crash the application.
Why the managed identity scenario's not working?

Number 2 is addressed by #14


Add multipart/form-data way of uploading file

Does not change existing C++ interface.

TODO: not tested yet

thanks!


how ploidyfix.vcf created?

Dear chapman,
Thanks for the great job for bcbio, just a small problem when I check the command log file:
cat /NAS101/work/gatk-haplotype/P59-effects-ploidyfix.vcf  | /usr/local/bin/pbgzip -n 15  -c > /NAS101/work/gatk-haplotype/tx/tmp6y8uFn/P59-effects-ploidyfix.vcf.gz
how P59-effects-ploidyfix.vcf created? I can't find the command, before it is P59-effects.vcf.gz
Another problem is when I using metadata option, haplotypecaller  will include all the samples together to call the variants, time is consuming, so what's your opinion for calling variants using sample by sample or combining them in a list or using joint calling option?
Thanks again for your kindness.
Juncheng

Juncheng;
Sorry about the confusion with ploidyfix. That's run as python code so won't be present in the log file and the implementation is here:
https://github.com/chapmanb/bcbio-nextgen/blob/master/bcbio/variation/ploidy.py#L55
I pushed fixes that will only apply it if necessary -- female only batches where we remove Y chromosome calls. Previously it was being applied more generally but not changing things since the sex chromosome and mitochondrial calling has been moved to be part of ploidy, Hope this will help make things less confusing going forward.
This post describes the tradeoffs between joint, pooled and single sample calling in terms of quality:
http://bcb.io/2014/10/07/joint-calling/
There is some benefit to pooling calls together, especially in lower coverage regions and related populations where you expect them to share mutations. Using joint calling with GATK HaplotypeCaller will provide you this benefit while avoiding the extra overhead of calling samples together and might be a nice compromise. Hope this helps -- happy to follow up if you have more questions.

Thanks so much for your response, I will try joint calling with HaplotypeCaller.