[BUG] Hugging Face Transformers: apply_model error due to hardcoded CUDA device

Describe the problem
On a multi-GPU machine, using apply_model() with a HF transformer model gives a runtime error if the model is moved to another GPU than the default one.
Code to reproduce issue
import torch
import fiftyone as fo
import fiftyone.zoo as foz
from transformers import MobileNetV2ForImageClassification

dataset = foz.load_zoo_dataset("quickstart", max_samples=25)
model = MobileNetV2ForImageClassification.from_pretrained("google/mobilenet_v2_1.0_224")
assert torch.cuda.device_count() > 1
model.to("cuda:1")
dataset.apply_model(model, label_field="image_classif", skip_failures=False)

This gives a runtime error due to a device mismatch with the model preprocessor:
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1! (when checking argument for argument weight in method wrapper_CUDA__cudnn_convolution)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 22.04): Ubuntu 24.04 LTS
Python version (python --version): Python 3.12.7
FiftyOne version (fiftyone --version): FiftyOne v1.1.0, Voxel51, Inc.
FiftyOne installed from (pip or source): pip (via rye)

Other info/logs
After model conversion (into a FiftyOne Model), there are three occurrences of hardcoded "cuda" device like this:
https://github.com/voxel51/fiftyone/blob/e7f3eddb408c142b59233571c3a7319c6d1c0fcb/fiftyone/utils/transformers.py#L454-L456
And then, at predict time, self.device is used to move the preprocessed inputs on the GPU:
https://github.com/voxel51/fiftyone/blob/e7f3eddb408c142b59233571c3a7319c6d1c0fcb/fiftyone/utils/transformers.py#L702-L705
=> Hence the mismatch when the model has been moved to another GPU than cuda:0.
This could be replaced by self.model.device and/or, at CTOR-time, storing the attribute as self.device = self.model.device.
Willingness to contribute
The FiftyOne Community encourages bug fix contributions. Would you or another
member of your organization be willing to contribute a fix for this bug to the
FiftyOne codebase?

[ ] Yes. I can contribute a fix for this bug independently
[x] Yes. I would be willing to contribute a fix for this bug with guidance
from the FiftyOne community
[ ] No. I cannot contribute a bug fix at this time

cc @brimoor

I just noticed the problem is not limited to HF transformers models. E.g. because of this hardcoded cuda() call here:
https://github.com/voxel51/fiftyone/blob/b2734ab695e94bf42bf226ae7dfa4c9a7ebe1378/fiftyone/utils/clip/zoo.py#L189-L190
The same problem occurs with e.g. a TorchImageModel. To reproduce it:
import torch
import fiftyone as fo
import fiftyone.zoo as foz
from PIL import Image

model = foz.load_zoo_model("clip-vit-base32-torch", device="cuda:1")
y = model.predict(Image.open("test.jpg"))

Fails with:
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1! (when checking argument for argument weight in method wrapper_CUDA__cudnn_convolution)


runtime: running cmd.exec within goroutine sometimes leaves process with 100% CPU

What version of Go are you using (go version)?
Reproducible on at least 1.18.1 and 1.18.4 on Apple Silicon (M1)

go version go1.18.1 darwin/arm64
go version go1.18.4 darwin/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/robbie/Library/Caches/go-build"
GOENV="/Users/robbie/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/robbie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/robbie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.18.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.18.4/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.4"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/my/x46mws81707gx7sxgsjcwc2w0000gn/T/go-build881887791=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
See the repro repo here for a few scripts that might help you reproduce the issue.

Build the below program – go build -o repro main.go
Run repro a bunch of times at once – e.g. for i in $(seq 500); do "./repro" &; done
run ps aux | grep repro
Notice that some small percentage of the time, there are leftover processes either called repro or (repro) that continue to run and hog 100% CPU.

This is the smallest reproduction I can find but haven't been able to diagnose what this process is actually doing. kill -ABRT is ignored; the only way I can get rid of these hanging processes is with a kill -9.
No idea ~if this has to do with running a goroutine in an init function and~ whether this is replicable without running exec.Command ~or whether this is an exec.Command bug independent of init semantics.~
package main

import (
	"math/rand"
	"os/exec"
	"time"
)

func main() {
	go func() {
		exec.Command("echo").Run()
	}()
	time.Sleep(time.Duration(rand.Intn(20)) * time.Millisecond)
}

Old reproduction
package main

import (
	"math/rand"
	"os/exec"
	"time"
)

func init() {
	go func() {
		exec.Command("echo").Run() // doesn't have to be `echo`; reproduces with other commands
	}()
}

func main() {
	time.Sleep(time.Duration(rand.Intn(20)) * time.Millisecond)
}

What did you expect to see?
The process to exit and not take up much CPU
What did you see instead?
A small percentage of the time, the process remains, either with its own name or its name in parentheses in the process table, hanging and taking up 100% CPU.

Just to be totally clear, does your reproducer still work if you get rid of any of these things? (Not init, not in a new goroutine at init, not exec.Command?)

This is the smallest repro I could find (i.e. I haven't managed reproduced by deleting any of these things, but it's super nondeterministic so I am not 100% confident that this is actually the minimal repro.)
Haven't been able to get a core dump on lldb/gdb yet; @allanbreyes has been investigating as well.

All of this sounds a lot like an issue in the kernel where zombie processes are getting stuck attempting to clean up / exit.
However, it is not at all clear what is special about this Go program that would trigger this. My best guess would be some kind of race between the parent process exiting and the fork+exec of the child.
Does this reproduce if you move the goroutine creation into main?

Interestingly, I haven't been able to reproduce this when running the program many times in a row serially. This doesn't mean it doesn't reproduce that way, but might indicate that there is some sort of race condition in the kernel that doesn't clean up these zombie processes properly when it tries to do a lot at once.
I.e. running this usually can sometimes reproduce:
for i in $(seq 500); do "./repro" &; done
But
while true; do "./repro"; done
never seems to (so far).

Ah, great. There is little difference between the last init function and the start of main, so it is good to know that it isn't related.
A few more things to try:

Eliminate the race between exec and exit to see if the problem goes away. I'm thinking:

package main

import (
	"math/rand"
	"os/exec"
	"time"
)

func main() {
	c := make(chan struct{}, 1)
	go func() {
		exec.Command("echo").Run()
		c <- struct{}{}
	}()
	time.Sleep(time.Duration(rand.Intn(20)) * time.Millisecond)
	<-c
}

Try recreating this as a C program with a background thread doing fork+exec and the main thread doing random sleep + exit.

We'll try both of those things when we get a chance. In the meantime, I've narrowed this further:
package main

import (
	"math/rand"
	"os"
	"time"
)

func main() {
	go func() {
		os.StartProcess("echo", []string{}, &os.ProcAttr{})
	}()
	time.Sleep(time.Duration(rand.Intn(20)) * time.Millisecond)
}

replicates. I'm feeling like it's unlikely that this is a go bug, but as you worked around a macos bug in https://github.com/golang/go/issues/41702 it might be worth trying to work around this one as well once we get to the root of it.

Confirmed replication in C:
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <pthread.h>

void *forking_thread(void* arg)
{
    int pid = fork();
    if (pid == 0) execl("/bin/echo", NULL);
    return NULL;
}

int main()
{
    pthread_t thread_id;
    pthread_create(&thread_id, NULL, forking_thread, NULL);
    usleep(20 * 1000);
    exit(0);
}

So, this is clearly not a Go bug. Feel free to close this, but if you have ideas w.r.t. a workaround as above, I'm happy to try to help.
Any idea where people have had success reporting macos kernel bugs in the past? Doesn't seem like the other thread got much traction.

We do have a lock taken around exec and thread creation to protect against a Linux kernel bug (#19546). As a workaround for this, we could perhaps take this lock prior to exit.
You could give this a try by calling execLock.rlock() prior to exit here (note that this is only exit when returning from main. os.Exit is a separate path).

What version of macOS are you running on?.
I haven't been able to reproduce it locally. For the C reproducer, how many iterations does it usually take to have a hanging process?
Thanks.

What version of macOS are you running on?.

12.4, with an M1 Max chip.
  Model Name:	MacBook Pro
  Model Identifier:	MacBookPro18,2
  Chip:	Apple M1 Max
  Total Number of Cores:	10 (8 performance and 2 efficiency)
  Memory:	32 GB
  System Firmware Version:	7459.121.3
  OS Loader Version:	7459.121.3

I haven't been able to reproduce it locally. For the C reproducer, how many iterations does it usually take to have a hanging process?

Anecdotally it depends on CPU load, but I can consistently get a go repro in under a minute by running the scripts from here
while true; do ./test_race_go; done

C repros are less predictable, but that's probably because I didn't include the random jitter; I'll see if adding the randomness helps.
while true; do ./test_race_c; done

takes at most a couple of minutes to leave a process at 100%.

Thanks @ostrowr ! I can also reproduce on an Intel Mac with macOS 12.4, both the Go and the C version. I'll forward it to Apple.

Great, thanks! For posterity, I submitted this to Apple on the 14th; feedback ID FB10691471 if you want to reference it.
Haven't taken a look at a workaround in go since it'll likely take me a while to get a dev environment set up but I'll try to make some time this weekend

I couldn't reproduce now with macOS 12.6.4 and 13.1. Maybe it is fixed now?

I haven't been able to reproduce on 13.1 either, but only tried for about 10 runs of ./test_race_go.
Seems like possibly fixed!
Never did get a response on my Apple feedback.

Thanks. Let's call it fixed. If it is not we can reopen.


Fix monitoring regression

What this PR does / why we need it:
Fixes a regression that was added to the monitoring stack. We no longer drop important metrics for the monitoring aggregation and use honor_labels: true to prevent adding exported_job and exported_instance labels.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Fix monitoring regression for aggregated monitoring

@dkistner can you take over the review?


Add npm init

If you don't do this, you'll receive this error:
❯ zeppelin npm install zeppelin-solidity
npm WARN saveError ENOENT: no such file or directory, open '/Users/et/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/et/package.json'
npm WARN et No description
npm WARN et No repository field.
npm WARN et No README data
npm WARN et No license field.

+<EMAIL_ADDRESS>updated 1 package in 0.677s

Thanks @et!


Tenant ID

In one of the sections you have mentioned ........
"To access the Data Lake Store account from Azure Databricks, you must have the following values for the Azure Active Directory service principal you created:
Application ID
Authentication key
Tenant ID"
......
I feel that asking for the Tenant ID might be a security issues, i am sure that Admin/Devops/security/.... will be very pritective in giving me the Tenant ID.
Question Can ADB connect in another way without having the Tenant ID?
Sincerely
Nik

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d863ab39-0b6a-eb81-9dde-5eb25b46cc33
Version Independent ID: 655abadf-5f9e-a65b-0109-c5166f956c4d
Content: Tutorial: Perform ETL operations using Azure Databricks
Content Source: articles/azure-databricks/databricks-extract-load-sql-data-warehouse.md
Service: azure-databricks
GitHub Login: @nitinme
Microsoft Alias: nitinme

@SQLDataSide Thanks for the feedback. We are actively investigating and will get back to you soon.

@SQLDataSide Hi Nik,
I think that's how OAuth authentication works in Azure. Needs to know the tenant ID specific URL so it knows where to try the token with.
This Oauth doc implies there is the option to use the tenant identifier instead of the Tenant ID as well.  contoso.onmicrosoft.com  In my brief testing though, when I tried the active directory domain name rather than the ID, it didn't work, so not seeing a clear way to avoid the tenant ID.
Thanks, Jason

@SQLDataSide I had a mistake in my test. It works to provide the id as well...
spark.conf.set("dfs.adls.oauth2.refresh.url", "https://login.microsoftonline.com/YOURDOMAIN.onmicrosoft.com/oauth2/token")

#please-close


Oops, we had problem communicating with our services. (Reload)

I'll try to reinstall ...
my log id: 0ca699e59ff849b8dd1e6e1c

I'm getting the same error after upgrading to version 2.0.0-20180604093219. Also login from the terminal is timing out ...
$ keybase ping
2018-06-05T18:47:01.838872-04:00 - [INFO keybase cmd_ping.go:40] 001 API Server at https://api-0.core.keybaseapi.com is up

$ keybase login
2018-06-05T18:50:04.839200-04:00 - [ERRO keybase main.go:90] 001 Operation timed out

What OS are you using. I am having the same problem on Windows 7

@zanderz can you post a link to the fixed build?
On Tue, Jun 5, 2018 at 7:10 PM bs78ta<EMAIL_ADDRESS>wrote:

What OS are you using. I am having the same problem on Windows 7
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/12216#issuecomment-394888989,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_0zRH9YrjVn42do8FWa3Sb3rq_0Iks5t5w_UgaJpZM4UbnFu
.

Pre release did not change my results. Good luck

The installation of the pre-release Keybase_2.0.0-20180605100109+9aa86bcb87.386.exe linked in this comment https://github.com/keybase/client/issues/12197#issuecomment-394904222 solved the issue. Thanks!


Unpin babel dependencies

This prevents unnecessary duplication of dependencies, and matches upstream.

The latest commits seem to have unpinned most things. Let's keep it scoped to babel packages for now.

@ianschmitz are you OK to merge this one now? It looks like all changes have been made as requested.

Thanks for your efforts @mohd-akram, and for the reviews @ianschmitz and @MichaelDeBoey.


Hangouts Wildcard - filter events page by "virtual" tag?

For the hangouts wildcard; can we sort/filter the events page by the virtual tag such events have?

Closed in 1df97425c69f914897a91d78e25927c27b79aa08


Depreciations as Errors

Over a quick glance in the checks, I didn't see anything that would flag the use of deprecated functions as errors.
In the upcoming renpy 8 release, all depreciated functions will be entirely removed. Thus it might be useful for the script to report depreciations as errors on a renpy 8 build.

Got it, will implement asap.


Review: Required Changes

Hy Felipe! Your code is excellent you can make some changes to enhance its working.

it would be great if you make a line over to task when they are checked as in the given design
Clear button is not working can you please fix that
You can split your code in modules

Thank you for your feedback! In the latest version, the mentioned issues were fixed 😸
Happy Coding! 😃


Incorrect file reference in Documentation

What docs page needs to be fixed?
https://github.com/reduxjs/redux/blob/master/docs/tutorials/essentials/part-5-async-logic.md

Section: Part 5
Page: https://redux.js.org/tutorials/essentials/part-5-async-logic

What is the problem?
On the redux.js.org page, there is a code snippet that references 'features/posts/EditPostForm.js' but I believe it should say 'features/posts/SinglePostPage.js' instead as the contents reflect that file instead. this is the snippet in reference:
// omit imports
import { selectPostById } from './postsSlice'
export const SinglePostPage = ({ match }) => {
const { postId } = match.params
const post = useSelector(state => selectPostById(state, postId))
// omit component logic
}
What should be changed to fix the problem?
The file reference should be changed from 'features/posts/EditPostForm.js' to 'features/posts/SinglePostPage.js'
I do not see how this is set in https://github.com/reduxjs/redux/blob/master/docs/tutorials/essentials/part-5-async-logic.md so I cannot make a pull request.

The filenames for each snippet are declared as the "title" field for the Markdown syntax block, like:
```js title="some/file.js"


Add Just the two of us But Alien Sings it by Unknown

Song Name
Just the two of us But Alien Sings it
Artist Name
Unknown
Source
Youtube
Youtube Link
URtqADoz9uA
Direct File Link
No response
Song ID
325903
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 71265937
Downloaded: Yes

Ok
Dňa ne 22. 9. 2024, 4:37 AM github-actions[bot] @.***>
napísal(a):

This submission is stale because it has been open for 14 days with no
activity. If it is still relevant, please leave a comment and we will
reopen it.
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/3756#issuecomment-2365426961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKKNLR4PJDZ7BYJQRLFFQQ3ZXYUN7AVCNFSM6AAAAABNZXWGKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGQZDMOJWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


PowerSession can't play this file

Hi. PowerSession can't play this file.
https://asciinema.org/a/8muthjs1m0bcbo6f1c4tp8kt1
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
Error("EOF while parsing an object", line: 1, column: 1)', ...\PowerSession-0.1.6\src\commands\play.rs:95:88

this looks like a v1 format, which isn't supported.

thanks for answer, @ibigbug.
If they are not planned to be supported, maybe a meaningful message can be added - "v1 format isn't supported".
Agree?

good point.


help wanted: how can it be changed to communicate with another module in quadversity?

I'm thinking ev200d here, their modules are based on this project it seems. They suck so I'm wondering if this can be changed in firmware so both modules communicate and decide which has the best RSSI and switch globally to it (in the ev200d).
Any help appreciated.

https://github.com/JyeSmith/FENIX-rx5808-pro-diversity/tree/quadversity
This is a fork I developed a little back adding quadversity to the rx5808-pro-diversity.  I have no idea how the EV200 is set up to do it, but if you spend some time with a multimeter poking around you could figure it out and report back :D

Thank @JyeSmith.
I've never done that sort of poking but the goggles are open so it's a good chance to do it, what do you recommend I start with to see what's needed?

It mightn't be so easy if you've never done it before and no familiar with module schematics.  But at a minimum find out what the module-to-goggle sockets connect to.

Do you have a pinout of a standard fatshark module?

Check the readme for the connections.

The readme contains only the connections of each components, not the pinout to the goggles

https://www.rcgroups.com/forums/showatt.php?attachmentid=11192179

Thanks!
Did you build your project with 4 rc5808 inside one module?
I see that it could be turned into 2 diversity modules that connects like that image, (is it the source of Lagorge?)
Since many people are getting rid of their default ev200d module (some batches loose lock mid air) I'm thinking that would be a great alternative.

I did build an Arduino based quadversity Rx and a STM32 based module for Fatsharks.
https://imgur.com/a/yCRRbOW

Quite a contraption, which one am I looking at and how does it "fly" ?

This is a prototype STM32 module. Works just like a diversity with more patch antennas :)

nice long coverage :) how fast is commutation?

Current switching rate is about 15kHz in 2 antenna diversity mode.

So do you stitch the image per line?
I thought Xversity was commutating at the end of the last scanline.

Hello, figured out that the stock modules are communicating over SPI at the first Three FS module Contacts.
The Resistors on the 5808 Modules are not existent. (removed the shielding)
And the Ch1, Ch2, Ch3, Contacts from each RX are connected to the three first contacts Button 1,2,3 in module bay. With 0,1ohms!
Also the RSSI is not output to the pin 8 of FS Bay.
Seems Signal Quality will only reported over SPI?
I figured out that RSSI is connected to this tiny Board upside from each RX5808 Boards.

Can Provide measurement with scopemeter. Have two Pro58 Boards.
Maybe some Hardware modification is needed to allow communication for STM32 to the Google.


strace: fix libunwind detection by fixing use of lib.optional

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: strace
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: strace
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22
shrinking /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace
gzipping man pages under /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin
patching script interpreter paths in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22...
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22

Success on aarch64-linux (full log)
Attempted: strace
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22
shrinking /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace
gzipping man pages under /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin
patching script interpreter paths in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/lind05r5ydb20phsj39zf7kyjkavwj02-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22...
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22


Update CentOS Docker packages

Update the docker-engine packages pulled by CentOS to 17.05.0.ce (latest).

@mesosphere-mergebot bump-ee

Failing test (teamcity/dcos/test/aws/cloudformation/zen/centos) is flaky and an expected failure.

@mesosphere-mergebot label Ready For Review

Any reason to not go with 17.09.0-ce ?

Aye, 17.05.0 is the latest published to the official (main) CentOS repository (yum.dockerproject.org/repo/main/centos/7/Packages/)

Failing test (teamcity/dcos/test/aws/cloudformation/zen/centos) is flaky and an expected failure.

Thanks for investigating. Please link to a JIRA ticket that tracks said instability, and also add a comment to that JIRA ticket which links back to this PR, as well as to the build log. And ideally add a build log snipped to said PR.

Please link to a JIRA ticket that tracks said instability, and also add a comment to that JIRA ticket which links back to this PR, as well as to the build log. And ideally add a build log snipped to said PR.

It looks like this test (https://teamcity.mesosphere.io/viewType.html?buildTypeId=DcOs_Open_Test_IntegrationTest_AwsCloudFormationZenCentOS) doesn't ever pass; I think it is shows up here b/c I accidentally triggered it while doing manual verification test runs.

@sschneid  - You could add the reason for Upgrade here: https://jira.mesosphere.com/browse/DCOS_OSS-1737
It's useful/important to have the JIRA , just in case, this needs to be tracked from JIRA or needs to be added to release notes.

@sschneid  - The AWS CloudFormation CentOS test for both Open and EE seems to have failed with this change. This needs to be investigated before this lands.

On Open, the problem seems to be a Pkgpanda failure. It could be flaky, I am going to retrigger it.
On EE, the failure reason is not known. It seems some process terminated as/before the tests were run. So, that needs to be retriggered and brought to green too.

The AWS CloudFormation CentOS test for both Open and EE seems to have failed with this change. This needs to be investigated before this lands.

See my above comment -- the only failing tests for both Open and EE are the "zen/centos" tests which are fault (have never successfuly passed) and were accidentally triggered.

@sschneid / @lingmann  - Got it.
When I looked at the test traceback, it seemed to me that it is something that could be fixed. I assume it should be outside the scope of this PR.
test_packaging.py:7 (test_pkgpanda_api)
dcos_api_session = <dcos_test_utils.dcos_api.DcosApiSession object at 0x7fba78e44ac8>

    def test_pkgpanda_api(dcos_api_session):

        def get_and_validate_package_ids(path, node):
            r = dcos_api_session.get(path, node=node)
            assert r.status_code == 200
            package_ids = r.json()
            assert isinstance(package_ids, list)
            for package_id in package_ids:
                r = dcos_api_session.get(path + package_id, node=node)
                assert r.status_code == 200
                name, version = package_id.split('--')
                assert r.json() == {'id': package_id, 'name': name, 'version': version}
            return package_ids

        active_buildinfo = dcos_api_session.get('/pkgpanda/active.buildinfo.full.json').json()
        active_buildinfo_packages = sorted(
            # Setup packages don't have a buildinfo.
            (package_name, info['package_version'] if info else None)
            for package_name, info in active_buildinfo.items()
        )

        def assert_packages_match_active_buildinfo(package_ids):
            packages = sorted(map(lambda id_: tuple(id_.split('--')), package_ids))
            assert len(packages) == len(active_buildinfo_packages)
            for package, buildinfo_package in zip(packages, active_buildinfo_packages):
                if buildinfo_package[1] is None:
                    # No buildinfo for this package, so we can only compare names.
                    assert package[0] == buildinfo_package[0]
                else:
                    assert package == buildinfo_package

        for node in dcos_api_session.masters + dcos_api_session.all_slaves:
            package_ids = get_and_validate_package_ids('pkgpanda/repository/', node)
            active_package_ids = get_and_validate_package_ids('pkgpanda/active/', node)

            assert set(active_package_ids) <= set(package_ids)
>           assert_packages_match_active_buildinfo(active_package_ids)

And another thing to note. When a failure is present in the status' checks only admins can merge it, I was trying to avoid that, and trying to get this to green, if possible.
I'll see if this error is tracked somewhere, if not, create a JIRA for it.

LGTM.

The centos issue is tracked here: https://jira.mesosphere.com/browse/DCOS_OSS-1746
If we have to get this status to green, then we could disable the test and re-run those suites.

Thanks for the ticket @orsenthil. No need to worry about the status check for this PR, but I'm making this ticket a high priority to investigate and get resolved, since it is a blocker for our TC job teamcity/dcos/test/aws/cloudformation/zen/centos


Invalid database connection string leads to strange error message

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgres"
  url      = env("DATABASE_URL")
}

DATABASE_URL="postgresql://foo:bar@host:sdfsdf/chinook"

When running prisma introspect I get this error message:
C:\Users\Jan\Documents\prisma-chinook-express>npx prisma introspect
Environment variables loaded from ./prisma/.env

Introspecting based on datasource defined in prisma\schema.prisma …
Error: Error in connector: Error querying the database: Error querying the database: The specified database url Error parsing database connection string. is invalid

I can confirm this but the message seems fairly accurate to me.

Error: Error in connector: Error querying the database: Error querying the database: The specified database url Error parsing database connection string. is invalid sounds like gibberish to me.
More useful would be "Port part of connection string ('sdfsdf') is invalid. Should be numbers only." or any less detailed version of that.
Also no "Error: Error in connector: Error querying the database: Error querying the database:".

Query engine does this right:
Error parsing connection string: invalid port number

Introspection not.


js.Object conversion of Props in FunctionalComponent?

Hi, I have a hacky work around for javascript libraries that require the props to be sent to the library, with the actual element embedded as a ref inside a div. What this means is the Props containing arguments for the js library need to be sent to javascript as a js.Object, not a case class.
So I am wondering if there's a cleaner syntax Slinky can/already support to allow me to pass the Props object as a js.Object?
I've already looked into converting a case class into a js.Object, but the posted solutions vary in feasibility and don't work in my case.
The cleanest solution I've come up with is define my Props for my FunctionalComponent as a regular class that extends js.Object.
This allows me to pass props to the FunctionalComponent, and when the ref needs to get rendered, it has the js.Object it needs to instantiate the library (no additional conversion needed)! But that means I'm not working with regular Scala objects...
For instance, the nouislider library linked above requires useEffect to reinstantiate the slider on every update:
@JSImport("nouislider", JSImport.Default)
@js.native
object NoUiSlider extends js.Object {
  def create(container: Element, props: js.Object): js.Object = js.native
}

...

// here the "container" is the ref attached to the div where this slider is embedded
NoUiSlider.create(container.current, props)

...

div()(
          div(ref := container)
)

So the problem is, if my Props are a case class everything works until I call create, which can't find the fields of my Props
So is there a clean way in slinky to get the raw json object of Props in addition to the case class? That way I pass the js.Object to create, but use the case class for my FunctionalComponent otherwise.

This is exactly what Writer is for! You can derive a Writer[T] for your props type, and then can use that instance to convert the Scala object to a js.Object when you need to talk to the library.

@shadaj thanks for the hint, and thanks for your unit tests!
Fixing this was too easy!:
NoUiSlider.create(container.current, implicitly[Writer[Props]].write(props))
Slinky is very powerful, thank you!


Fix CJK Ideographs and Hangul Syllables representation

Characters in these blocks weren't correctly identified as assigned characters, which caused the encoders to always encode them, even if the ranges were in the allow list.
Fixes https://github.com/aspnet/HttpAbstractions/issues/242.

Looks :shipit: to me. Having that generator seems quite handy :smile:
@GrabYourPitchforks do you want to merge yourself or shall I?

I'll take it - was just waiting for signoff. Didn't want to rush it since everybody's heads-down right now. :)

Okie dokie, please merge at your convenience!

Thanks!

Can we make sure this doesn't break mono?


Fixed #24112 -- Fixed counting of elements if needle has no root element

This PR has the fixes suggested by @timgraham in #4041:

Use assertRaisesMessage instead of assertRaises
Print the element with the exception message to give context for debugging

One of the comments on the previous PR was "Should we add some context to the message (like part of the HTML snippet) to help identify the needle? I'm a bit worried developers will have a tough time figuring out what the message means." Any thoughts on that?

Yeah, I decided to print element in the message with the ValueError that gets raised. Is that sufficient?
https://github.com/django/django/pull/7079/files#diff-227f11729ee2a09bf3a4f7ca62f54ffbR99

Oops, I didn't notice that because it's not part of the message checking in the test. I would have phrased it like "Needle HTML  doesn't have a root element." but I think the message should also answer the questions, "why is this a problem?" and "what can you do to fix it?"

Good point, is that better?

It still doesn't really explain why that's an error and what should be done to solve it. I'm particularly thinking about an inexperienced who sees that message.

Maybe now? 😉
If the line length is a problem, let me know how I should fix it.

Sorry for the confusion. The question I have as a user would be "Why is a missing a root element problematic here?"

No worries! I was thinking that the user calling assertInHTML and getting Needle HTML  is missing a root element from haystack HTML  is clear enough.
I'm happy to adjust it if I'm still misunderstanding you.

As we discussed on IRC, I'd like to know more about why the code has this requirement in the first place so the error message could explain that.

Makes sense. I should have time to look at it this weekend.

@timgraham Rather than try to merely clean up the original PR for this ticket, I've tried to fix the underlying problem 😄
If I'm understanding correctly, the problem is with this decision in _count.
Let's say we're checking if
foo

bar
 is in

foo

bar

. The children of the haystack are
foo
 and
bar
. So when _count is called on each of the children with the original needle, a match is not found. Comparing .children directly bypasses the separation that the loop causes. This is the exact test that this patch provides.


Various cleanup

The .cargo/config file without .toml ending was deprecated in one of the last few cargo releases. The config.toml variant is supported since cargo 1.39, so I don't think we need to keep the old file.
The cosmwasm-std dev-dependency in cosmwasm-schema seems to be entirely unused.
The Classifier in the floaty contract is only used in the tests, so I moved it there to avoid compiler warnings about it being unused.

Could you do the config renaming in https://github.com/CosmWasm/cw-template/tree/main/.cargo too? This would help newcomers to avoid warnings they don't understand


Syntax error with transaction log query while using USER argument

I tried to perform a transaction log query using tm1.server.get_transaction_log_entries
Passed sinceargument alone and it worked:
/api/v1/TransactionLogEntries?$orderby=TimeStamp desc &$filter=TimeStamp ge 2019-12-30T20:45:05Z
Passed since with user, but failed:
/api/v1/TransactionLogEntries?$orderby=TimeStamp desc &$filter=User eq 'TEST/user' and TimeStamp ge 2019-12-30T20:14:57Z
Received the below error:

TM1py.Exceptions.Exceptions.TM1pyException: Text: {"error":{"code":"278","message":"Syntax error at position 10, near "TEST" in $filter: Expecting end of input."}} Status Code: 400 Reason: Bad Request Headers: {'Content-Length': '123', 'Connection': 'keep-alive', 'Content-Encoding': 'gzip', 'Cache-Control': 'no-cache', 'Content-Type': 'application/json; charset=utf-8', 'OData-Version': '4.0'}

Tried with cube and same result:
/api/v1/TransactionLogEntries?$orderby=TimeStamp desc &$filter=Cube eq 'Sales Forecast' and TimeStamp ge 2019-12-30T21:02:03Z

TM1py.Exceptions.Exceptions.TM1pyException: Text: {"error":{"code":"278","message":"Syntax error at position 10, near "Sales" in $filter: Expecting end of input."}} Status Code: 400 Reason: Bad Request Headers: {'Content-Length': '124', 'Connection': 'keep-alive', 'Content-Encoding': 'gzip', 'Cache-Control': 'no-cache', 'Content-Type': 'application/json; charset=utf-8', 'OData-Version': '4.0'}

Hi @user1493,
thanks for the catch!
I just looked up the latest documentation of the API. It says there that the TransactionLogEntries are not filterable by User.
I think in the TM1 API they made some changes to this functionality. I'm confident that it used to work when I wrote it initially in 2018 (still on 10.2.2).
I suppose if you need to filter by user, you have to do that on the client side.
For me (TM1 version 11.5.00000.23) filtering by cube + since still works though.
Can you check if this works for you:
with TM1Service(address=ADDRESS, port=PORT, user=USER, password=PASSWORD, ssl=SSL) as tm1:
    entries = tm1.server.get_transaction_log_entries(cube="Sales Forecast", since=datetime.fromisoformat("2019-12-30"))
    for entry in entries:
        print(entry)

Hi Marius,
Yes, I tried with cube and since parameters. I received the same error this time. I posted the same in my earlier comment.

Tested again:
Both Cube and User are not queryable.
log = tm1.server.get_transaction_log_entries(since=timestamp, cube='Sales Forecast')

TM1py.Exceptions.Exceptions.TM1pyException: Text: {"error":{"code":"278","message":"Syntax error at position 48, near "Sales" in $filter: Expecting end of input."}} Status Code: 400 Reason: Bad Request Headers: {'Content-Length': '124', 'Connection': 'keep-alive', 'Content-Encoding': 'gzip', 'Cache-Control': 'no-cache', 'Content-Type': 'application/json; charset=utf-8', 'OData-Version': '4.0'}

Hi @user1493 ,
thanks for double checking. It seems IBM did some changes to the API.
The part in the documentation (metadata xml) that I meant is this.
<EntitySet Name="TransactionLogEntries" EntityType="tm1.TransactionLogEntry">
<Annotation Term="Capabilities.ChangeTracking">
<Record>
<PropertyValue Property="FilterableProperties">
<Collection>
<PropertyPath>ChangeSetID</PropertyPath>
<PropertyPath>TimeStamp</PropertyPath>
<PropertyPath>ReplicationTime</PropertyPath>
<PropertyPath>Cube</PropertyPath>
<PropertyPath>Tuple</PropertyPath>
<PropertyPath>OldValue</PropertyPath>
<PropertyPath>NewValue</PropertyPath>
<PropertyPath>StatusMessage</PropertyPath>

You can open it in the browser through this url:
https://localhost:<<RESTPORT>>/api/v1/$metadata
Please check which fitlerable properties it lists there for you.

I see the same collections you posted in TM1 servers $metadata. I tried to work around the GET requests.
To my surprise the below request works:
/api/v1/TransactionLogEntries?$filter=Cube ne ''
But below does not:
/api/v1/TransactionLogEntries?$filter=Cube eq 'Sales Forecast'

The first request proves that Cube is queryable. Also the first request returned logs for 'Sales Forecast' cube.

It seems like a bug in your version of TM1.
Which version are you on?
with TM1Service(address=ADDRESS, port=PORT, user=USER, password=PASSWORD, ssl=SSL) as tm1:
    print(tm1.version)

The TM1 application's version I'm working on is 11.4.00009.4
I will upgrade TM1 soon and test the same. For now I'm handling things client side, so I'm closing this thread.
Thank you very much for your support!


Timeout limit subprocess

Set a fixed timeout of  5 seconds on zalando/go-keyring/go-keyring operations, this only effect linux systems.

Fixes #364


Add license declaration for ImageSharp 2.1.8

Type: Missing
This is almost identical #26785 but for version 2.1.8
Summary:
SixLabors.ImageSharp 2.1.8
Details:
Add Apache-2.0 License
Resolution:
License Url:
https://github.com/SixLabors/ImageSharp/tree/v2.1.8?tab=License-1-ov-file
AND
https://www.nuget.org/packages/SixLabors.ImageSharp/2.1.8#readme-body-tab
Description:
I'm creating this PR in hopes of expediting the harvesting and license definition process for this new version of the library. I have attempted to harvest the new patch (2.1.8) through the ClearlyDefined website, but I was unable to see any updates occur with regards to the tool recognizing this new version.
Please note that as of version 3+ of ImageSharp, they have changed their licensing model into a split license model.
However, all version 2.1.x versions of the library are still licensed under Apache-2.0. You can find more details about this on their repository.
Version 2.1.8 is a backported patch applied on 2.1.7. There was a security vulnerability with the library which they have fixed in newer versions and have backported to 2.1.x.
SixLabors.ImageSharp 2.1.8

@nima-ap It looks like the harvested did complete because it now shows the declared license as Apache 2.0. Closing the PR since it is no longer needed. Thank you!
https://clearlydefined.io/definitions/nuget/nuget/-/SixLabors.ImageSharp/2.1.8


Add auto-commit of NOTICE file on PR

Description

This PR adds a Github Action to commit changed file(s) back to PR
Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[ ] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

change looks good, could you try to change the NOTICE file (Remove some lines or so) in a commit to see if the GitHub action commits it back?

It may be easier to just add the NOTICE file generation just like we generate and commit files in the repository branches (master and version branches x.x). Seems like that GitHub action is not very happy to commit on forked repositories.


Cannot use yarn to install in windows 10

As title.
I use yarn add hexo-generator-amp will show the error below.
error C:\Users\Administrator\Documents\blog\node_modules\amphtml-validator: Command failed.
Exit code: 1
Command: \bin\sh -c "exit 0" 2> postinstall.DELETEME && rm postinstall.DELETEME || node postinstall-windows.js
Arguments:
Directory: C:\Users\Administrator\Documents\blog\node_modules\amphtml-validator
Output:
path.js:28
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:28:11)
    at Object.join (path.js:489:7)
    at Object.<anonymous> (C:\Users\Administrator\Documents\blog\node_modules\amphtml-validator\postinstall-windows.js:43:10)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)

But use npm i -S hexo-generator-amp works
node 8.1.4
npm 5.0.3
yarn 1.2.1

It may be the same as the following issue.
https://github.com/ampproject/amphtml/issues/10854
https://github.com/ampproject/amphtml/pull/8115
Does the same problem occur even if installing only amphtml-validator ?
yarn add amphtml-validator

@maple3142
Have you this issue solved ? I got some advice on the following issue, will you be helpful?
https://github.com/ampproject/amphtml/issues/11977

Sorry, I just forgot about this issue...
And after a few test I find I only can't install amphtml-validator with yarn under win10.
When I use bash on windows it can install correctly, maybe this is a yarn bug on win10

https://github.com/yarnpkg/yarn/issues/4918


Tests passing for ~> 1.0 (1.0.5)

I'm setting up a new service, based on the service template. The template has some very old dependencies which does not seem like the best start for a new service. Upgrading them proves difficult.
This is an attempt to to update this OT plug from Sean to a released/non release-candidate  version of Open Telemetry.
I've only a tenuous understanding of how all the Open Telemetry stuff hangs together though.
The biggest changes are between the  1.0.0-rc.2 and 1.0.0-rc.3 (unavailable), and these do affect what gets emitted so the tests need to change.
I've left some things commented out right now for review clarity, rather than deleting them.
Also I've made it a PR against this repo, while I get some feedback.

Closing in favour of https://github.com/blockfi/opentelemetry_plug/pull/4


Are there any plans to support git lfs in the future?

Your product is very good and the experience is great. I would like to know if there is any possibility to support lfs in the later stage. Thanks!!!

Yeah, We'll look into adding support for lfs.

Any timelines for this ? Thanks.

I hope so.

Is there any way to modify the default git clone command so we could add LFS support per pipeline as needed?


[Feature]: Rolling graphs rather than fixed for a single day until 00:00

Contact Details
No response
Description
Currently the graphs are day bound meaning the end at midnight and show progress during the days as grey areas.
Unfortunately these graps are always day based, so looking at it around 23:00 does not show any plans for after midnight.
Suggested Solution
Rolling graphs with 24 forecast rather than fixed for a single day until 00:00.
A better understanding of the generated plan would be a view roll in the hours of the next day including plan for usage and battery soc.
This would give much more confidence that battery SOC over the night is sufficient the cover the expected load until the sun rises.
The way I envision something like this is to have the graps having a slightly larger view with some hours visible in the past and always have the next 24 hours as 'planned'.
With each passing hour one hour from the past drops off from the left and one hour in the future is added on the right.
Expected usage, battery soc, PV forecast, loading schedules based on hourly prices etc.... can be rolled in as they become available.
With this when ever you look will have a 24 hour plans, even at 23:00 at night...
Alternatives
No response
Additional Context
No response

Thanks for the suggestion and agreed that it would be really nice. Looking always 24 hours ahead is unfortunately not possible (new energy prices only get published around 15.00). Which makes it hard to capture in an always functional graph. So for the Node-RED implementation adding this probably won't happen.
That being said, the implementation in VRM is a lot more likely to get that. Though i cannot guarantee that will be already in the first release either.

To add to this, the new version has 48 hour graphs in (as soon as the new prices get in).


Add code dropdown from latest jupyter notebook

Rough stab at issue #46 as talking points
Add code dropdown from latest jupyter notebook
Specify yolk per python version

I think got this fixed with a more strict approach to the Pipfile.


The folder "examples"

I propose that we add the folder "examples".

@GildedHonour agree! But we need to find a way to ensure they are updated and current -- maybe these examples should be implemented as simple specs just to demonstrate the concept.

@ronaldtse We'll have to keep track of that manually, namely, we'll create spec and based on them create some examples. When a spec changes, we'll have to change the examples as well.

@GildedHonour Look forward to them! 👍

Added a basic example.


Update package.json

Support React 15.x

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

I ended up making this change slightly differently, but thanks!


Implement sensors field

Many optional fields.

Moved to https://github.com/coredump-ch/spaceapi-rs/issues/3.


Create a uniq disk identifier on vm create

When instantiating a new VM, we create a disk file with the
name '_instance', in the selected storage container. Since
storage files have unique names an additional uniq id information
is required to allow creation of multiple vm's from the same image
in a selected region and container. This fixes #99

ok I was concerned about a length limitation, I'm going to change it

I stumbled over a small problem in one of the unit test, this is just a one liner fix which I think is ok to handle here too


Clean code the initServiceControllers

Clean code the initServiceControllers in server.go.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ping035627
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ping035627. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ping035627: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@costinm @rshriram can you help to review the lint error? thanks!
Makefile:238: recipe for target 'depend.diff' failed
make: *** [depend.diff] Error 1
Exited with code 2

@ping035627: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @zackbutcher @geeknoid

@ZackButcher hi, the ci/circleci failed, but the error seems to have nothing to do with my change, can you help review? Thanks very much.

Hi, @geeknoid can you help to review this PR? Thanks.

CI failure seems legit...

/retest

@ping035627: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[V2V] Restore auth_user in conversion host context data

The code for ConversionHost::Configurations splits out the auth_user from the incoming params, so it needs to be restored as a param in the context data so that a retry will pick it up again.
https://bugzilla.redhat.com/show_bug.cgi?id=1713394

Hammer backport details:
$ git log -1
commit aa86709453e65c50badf90ece07222cd309c08c5
Author: Adam Grare<EMAIL_ADDRESS>Date:   Wed May 29 11:28:14 2019 -0400

    Merge pull request #18819 from djberg96/conversion_host_auth_user

    [V2V] Restore auth_user in conversion host context data

    (cherry picked from commit 184bb9d3864d84b91903bc0003a9d77362f5863c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1717023


Back Button Works Correctly

Fixes #641
Describe the changes you have made in this pr -
Back button works

Coverage remained the same at 83.264% when pulling 4fdd13325189d4fb1862aec80ee76fc5d336ffef on NumberC:BackBtn into 6f6dfff8fae733634c375b33e74d5232147c7452 on CircuitVerse:master.

Remove unrelated unchanges

@tachyons How can I do that without undoing the Fork Synching?

git checkout master

@tachyons I did git checkout master and reverted the earliest ccommit "These are files for 'Add 'eye' feature on password' in Google Code In". I don't think it did anything

Nevermind, I reverted the revert.  I followed the steps and squashed the commits. Why doesn't it work anymore?

May be something went wrong while squashing, since this is just a single page change, easy way to make changes again if your not fluent in git


eslint for module

Summary
eslint for module
Description
eslint for module
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

/canary-publish


URGENT: pin nf-validation version

Description of the bug
To prevent breaking this pipeline in the near future, the nf-validation version should be pinned to version 1.1.3 like:
plugins {
    id<EMAIL_ADDRESS>}

Command used and terminal output
No response
Relevant files
No response
System information
No response

It's pinned in the dev branch and we're aiming to make a new release soon.
https://github.com/nf-core/raredisease/blob/071951a0627f5942e77a72afc3f52f0f9de36f8f/nextflow.config#L283
However, if this is already causing troubles we can look into doing a hotfix.

Thank you! This is not causing any issues for now but we would like to release nf-validation as soon as possible. (We just need to wait for all pipelines to pin their nf-validation version)


⚠ Bofrost.fr has degraded performance

In 80131fc, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1507 ms

Resolved: Bofrost.fr performance has improved in 3ba1363.


rtabmap: 0.11.4-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rtabmap to 0.11.4-0:

upstream repository: https://github.com/introlab/rtabmap.git
release repository: https://github.com/introlab/rtabmap-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: null

It looks like the binary jobs are failing for this package, including amd64 Xenial:
http://build.ros.org/job/Kbin_uX64__rtabmap__ubuntu_xenial_amd64__binary/1/
http://build.ros.org/job/Kbin_uX32__rtabmap__ubuntu_xenial_i386__binary/1/
http://build.ros.org/job/Kbin_uW32__rtabmap__ubuntu_wily_i386__binary/1/
http://build.ros.org/job/Kbin_dJ64__rtabmap__debian_jessie_amd64__binary/1/
http://build.ros.org/job/Kbin_arm_dJv8__rtabmap__debian_jessie_arm64__binary/1/
http://build.ros.org/job/Kbin_arm_uXhf__rtabmap__ubuntu_xenial_armhf__binary/1/
Can you take a look and see if there are any obvious fixes you can make to the package.xml to fix this--or if there are dependencies missing in rosdep?

This is the same issue as on this issue: https://github.com/introlab/rtabmap/issues/63. I need to modify the release repository with the patch.


New Rule: Brand Impersonation: Chase with credential phishing indicators

/update-test-rules

/update-test-rules


Updated requirements.py

Removed strict version for requests library.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Good morning, @poyap! Is this solving a bug or particular issue on your end when you run the code in the DataProfiler? I'd lean toward making a wider bounds on the requests library, but opening up the requests version pin to anything is wide open.

Good morning, It was an issue I forgot to mention it, sorry.

Got it -- what exactly is the issue?

#716
On Mon, Jan 30, 2023 at 9:51 PM Taylor Turner @.***>
wrote:

Good morning, It was an issue I forgot to mention it, sorry.
Got it -- what exactly is the issue. @poyap https://github.com/poyap?
—
Reply to this email directly, view it on GitHub
https://github.com/capitalone/DataProfiler/pull/756#issuecomment-1409105300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARS6LPISWW3UMRRDDNVRFBLWVABDPANCNFSM6AAAAAAUKK4CGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Got it -- you'll definitely need to sign the CLA and then there appears to be an issue on one of the checks for python3.9

@poyap I'm not completely against it, but is this an issue you are experiencing directly? We did have https://github.com/capitalone/DataProfiler/pull/750 which should have relaxed the hard req, but failed to update the issue / close it.

@poyap I'm not completely against it, but is this an issue you are experiencing directly? We did have #750 which should have relaxed the hard req, but failed to update the issue / close it.

+1

@poyap good morning, bump on this to make sure it doesn't go stale. Thanks!

@poyap bump on this. Thank you!

@poyap  just checking in on this PR. Thx

Closing, but if you have any thoughts to improve the library or questions feel free to reach back out!


Fix parsing of multiple consecutive underscore in digits

In Java, having multiple underscores in between digits is valid syntax. e.g.
int num = 123____456;

but it seems that is not being properly highlighted in CodeMirror. This PR attempts to address that by modifying the grammar to permit an arbitrary number of _ in between numbers when parsing digits. Let me know if this looks right.

Are you sure this is valid Java? When I try this I get a "SyntaxError: number cannot contain multiple adjacent underscores" error.

yes I believe it's only valid for JDK 8+. Am referencing the docs here. Have a runnable example here: https://replit.com/@SergeiChestakov/undercore-int-example

Ah, seems you are right. Could you change the * to a + in your change? I am pretty sure Lezer's DFA generation will handle the scary ambiguity of the way you have it now, but it seems needlessly obscure and will cause people used to backtracking regexps to get nervous when they read it.

done, thanks!


Fixing issue #28

After testing the change, it seems to work fine for me. Updated as suggested by @highplains

@zawadzkip - did you manage to duplicate the error first before fixing?

Yes, I was able to by running in release with arm64 set in the build.

Will put this out with 2.0.0-pre2 this weekend. Thanks for the help @zawadzkip


refactor: Use context as cancelation signal

Do you mean this one: https://blog.golang.org/context
Would be great.
What is the scope of this refactor / how long would it take?

Closing issue due due to a lack of activity / interest.


ARROW-14539: [C++] Dataset scanner test failing a DCHECK

If the exec plan ends early (either through a failure or user cancellation) it is possible for AsyncTaskGroup::AddTask to be called after AsyncTaskGroup::End.  This led to AsyncTaskGroup trying to mark its future finished twice.
I modified AsyncTaskGroup so that it won't mark the future twice if this condition occurs.  Instead it returns a cancelled status.  There is no good way to prevent this condition in MapNode without introducing a mutex / more synchronization so instead I just modified MapNode to expect a potential cancelled status return from AddTask.

@aocsa can you review this?

@aocsa can you review this?

I will be on PTO until tomorrow, but if this is high priority I will suggest to @aucahuasi to taKe care of it.

It looks like the tests for AsyncTaskGroup need to be adjusted. Also, the test AddAfterWaitButBeforeFinish checks that we can add tests after calling End() - so we need to resolve that (do we need two different types of task groups?)

@aocsa Not high priority

Also, the test AddAfterWaitButBeforeFinish checks that we can add tasks after calling End()

@lidavidm
Thanks for the catch, I'll fix that.  At the time, I had envisioned that child tasks might still need to add tasks to the task group after the parent ended it.  However, having using AsyncTaskGroup for some time now, I'm pretty sure the correct solution is either:

Chain the follow up tasks and add the last task in the chain to the task group
Use nested AsyncTaskGroup

So I will remove that test case.


[Customize footer UI] How to subclass JSQMessagesTypingIndicatorFooterView?

How can we subclass JSQMessagesTypingIndicatorFooterView? My reason is that I'm animating the typingIndicatorImageView and I don't want to modify the JSQMessagesTypingIndicatorFooterView just to achieve this.

Hey @archbrys - Customizing the footer is the same as the header. See #826 for details.

@jessesquires thanks for this.


Cleanup leftover VIP

If this container is killed ungracefully with docker kill, it will not be able cleanup the VIP it creates.
For example: if you kill the master, one of the backup containers will pick up the VIP, however the old master didn't have a chance to cleanup, and now we are left in a state where two hosts have the same VIP.
This PR will take care of removing the dangling VIP on any subsequent start/restart of the container.

This sounds quite interesting and useful, I hadnt thought about this (hadnt run into the issue yet)... but it makes sense...
I wonder if there is any way to check if the container might have been started in duplicitiy by mistake....  Just so we dont have containers "competing" for teh same IP....
Just thinking when this fix might have a negative effect, or how to make it even more resilient...
I'll merge this one, and if I come across other issues we can always ammend it then...  I hope to start testing on this soon... :)


Error when using inside a child component

I am using this in my 2nd project.  First project works.  On 2nd project, I have a child component called AddressComponent.  I am getting this error:
core.js:5828 ERROR Error: Export of name 'ngx-places' not found!
at cacheMatchingLocalNames (core.js:12797)
at resolveDirectives (core.js:12563)
at elementStartFirstCreatePass (core.js:20875)
at Module.ɵɵelementStart (core.js:20916)
at AddressComponent_div_4_Template (address.component.html:13)
at executeTemplate (core.js:11841)
at renderView (core.js:11627)
at TemplateRef.createEmbeddedView (core.js:15157)
at ViewContainerRef.createEmbeddedView (core.js:15264)
at NgIf._updateView (common.js:4713)

I had the same issue. I fixed it by adding GooglePlaceModule as an import to the module that my child component was defined in.


Update publish.yml

Tweak the action to look like the following:
name: Publish NPM Package
on:
  release:
    types: [published]
env:
  NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - uses: actions/setup-node@v2
      with:
        node-version: '14.x'
        registry-url: 'https://registry.npmjs.org'
    - name: Install Dependencies
      run: npm install
    - name: Build SDK
      run: npm run build
    - name: Publish to NPM
      run: npm publish

Also tweak nodejs.yml to be:
name: Node CI

on: [push]

env:
  NPM_SECRET: ${{ secrets.GITHUB_TOKEN }}

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [ 14, 16, 18, 19]
    steps:
    - name: Checkout Repository
      uses: actions/checkout@v3
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v3
      with:
        node-version: ${{ matrix.node-version }}
    - name: npm install, build, and test
      run: |
        npm ci
        npm run build --if-present
        npm test

  publish:
    needs: build
    runs-on: ubuntu-latest
    steps:
    - name: Checkout Repository
      uses: actions/checkout@v3
    - name: Use Node.js
      uses: actions/setup-node@v3
      with:
        node-version: 18
    - name: Install npm-force-resolutions
      run: npm install -g npm-force-resolutions
    - name: Install dependencies
      run: npm install
    - name: Build Package
      run: npm run build --if-present
    - name: Tag Version
      run: npm --no-git-tag-version version prerelease --preid=${GITHUB_REF##*/}
    - name: Publish to GitHub NPM Registry
      run: npm publish

Basically, the issue here is that in order to perform npm actions, there is a need for the required variable to be available (this was a relatively recent change from npm). Before these didn't need to be set.


Pageun

Page Unavailable features
Closes #443

@gghai, ok to merge?

Please go ahead with the checkin .Thanks


Design package manifest format

Each manifest will represent a specific version of a specific package.
This manifest will need to include information about the package, such as:

name
description
inputs and outputs
** for sharing dynamic paths, ports, and such between installed packages
dependencies
version compat matrix
** which version(s) of another package that this particular package/version combination is known to work well with
resources to deploy

docker containers

additional files/templates to copy

expected resource usage/requirements

this should probably correspond to the minimum requirements specified for each piece of software

This was mostly handled elsewhere, and the rest will be handled in other issues


Bootstrap Style conflicts with Leaflet

The leaflet map generated by folium conflicts with bootstrap styles.

https://github.com/python-visualization/folium/issues/192
Apparently this fixes it....
But tooo lazy

fixed, the folium api changed a lot...


Unable to use controller-runtime for ClusterWorkspaceType initializer

Consider that I have a ClusterWorkspaceType and an initializer that is supposed to create an APIBinding. That initializer is watching a VirtualWorkspace of the given CWT, however, when it tries to create an APIBinding, then it fails with:
1.65719959317604e+09	ERROR	controller.clusterworkspace	Reconciler error	{"reconciler group": "tenancy.kcp.dev", "reconciler kind": "ClusterWorkspace", "name": "appp", "namespace": "", "error": "no matches for kind \"APIBinding\" in version \"apis.kcp.dev/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/mjobanek/go-workspace/src/github.com/kcp-dev/controller-runtime/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/mjobanek/go-workspace/src/github.com/kcp-dev/controller-runtime/pkg/internal/controller/controller.go:227

The reason is that the rest mapper tries to do the discovery call before calling the POST for the APIBinding. But it does it for the VirtualWorkspace endpoint, not for the actual workspace that is being initialized:
I0707 13:13:13.510869       1 round_trippers.go:463] GET https://<IP_ADDRESS>:6443/services/initializingworkspaces/root:plane:usersignup:Appstudio/clusters/%2A/api/v1
I0707 13:13:13.510875       1 round_trippers.go:469] Request Headers:
I0707 13:13:13.510882       1 round_trippers.go:473]     Authorization: Bearer <masked>
I0707 13:13:13.510888       1 round_trippers.go:473]     Accept: application/json, */*
I0707 13:13:13.521749       1 round_trippers.go:574] Response Status: 404 Not Found in 10 milliseconds
I0707 13:13:13.521845       1 request.go:1372] body was not decodable (unable to check for Status): couldn't get version/kind; json parse error: json: cannot unmarshal string into Go value of type struct { APIVersion string "json:\"apiVersion,omitempty\""; Kind string "json:\"kind,omitempty\"" }
I0707 13:13:13.524075       1 round_trippers.go:574] Response Status: 200 OK in 13 milliseconds
1.6571995935242307e+09	ERROR	controller.clusterworkspace	Reconciler error	{"reconciler group": "tenancy.kcp.dev", "reconciler kind": "ClusterWorkspace", "name": "appp", "namespace": "", "error": "no matches for kind \"APIBinding\" in version \"apis.kcp.dev/v1alpha1\""}

There are two problems in the rest mapper code:

The rest mapper doesn't use the cluster-aware client nor the cluster-aware round-tripper. But even if I modify the code so it uses the cluster-aware round-tripper, then I face the second problem:
The context that is being passed as part of the discovery call is context.TODO() https://github.com/kubernetes/client-go/blob/release-1.23/discovery/discovery_client.go#L172 and not the one that is provided from the controller. This means that the context doesn't have the cluster name value so the cluster-aware round-tripper cannot do its job.

But it does it for the VirtualWorkspace endpoint, not for the actual workspace that is being initialized:

This is actually fine - the virtual workspace will proxy the request through to the correct cluster. The proximal issue here is that the request is not being made to the correct cluster.

Yeah, I used the wrong wording - what I meant was that it's using the URL with the wildcard at the end instead of putting the name of the workspace that is being initialized. I fixed it in the description.


STM32 SimplePwm: Fix regression and re-enable output pin

PR #2499 implemented timer hierarchy, but removed enable_outputs() from trait CaptureCompare16bitInstance and from SimplePwm.
This functions is required for advanced timers to set bit BDTR.MOE and to enable the output signal.

I left comments in Issue #2409 with my understanding what happened.
It's still unclear to me, whether this approach fits the new timer hierarchy.

Ah, I'm terribly sorry for this mess. I didn't notice that SimplePwm is implmented on TIM_GP16 at that time, thus adding enable_output() to TIM_1CH_CMP is useless for this situation.
You approach is correct on both old and new timer hierarchy. It requires a empty implement enable_output for TIM_GP16, and enable MOE inside the method for TIM_1CH_CMP / TIM_2CH_CMP / TIM_ADV.

Thanks for your fast response and don't worry about the mess.
It's easy to miss the output enable behavior between basic and advanced timers and I only noticed, because I use it in my project.
I can squash the commits, if you agree to the current state.

I can squash the commits, if you agree to the current state.

Yeah! It looks good to me!
And I also test PWM output on my dev board with TIM1(ADV), TIM15(2CH_CMP), TIM16(1CH_CMP), they all output correct waveform.

Thanks. I squashed the commits.


Seaweed FS S3 server over https does not work

Describe the bug
I m trying to configure the seaweedFS S3 server to run over https. I can see the configuration options:
s3StandaloneOptions.portHttps = cmdS3.Flag.Int("port.https", 0, "s3 server https listen port")
s3StandaloneOptions.tlsPrivateKey = cmdS3.Flag.String("key.file", "", "path to the TLS private key file")
s3StandaloneOptions.tlsCertificate = cmdS3.Flag.String("cert.file", "", "path to the TLS certificate file")

So from my understanding it should work once https port is set with certs. However, those configuration options seem to have no effect, as after I have set them, access to https port is being rejected.

Additional context
I am trying to enable Istio STRICT mTLS mode on my cluster, so its expect client app (boto3) to communicate with seaweed fs server over https.

The s3.port and s3.port.https options are used together only to get both http and https ports at the same time. If you only need an https port, then the s3.port and s3.tls* options are sufficient


mat-radio-button and mat-checkbox don't line wrap

Bug, feature request, or proposal:
Proposal: change <mat-radio-button> or <mat-checkbox> to line-wrap its contents by default or add an option.
What is the expected behavior?
I can put a text into a  <mat-radio-button> or <mat-checkbox> that is longer than what fits into the viewport.
What is the current behavior?
The content in a  or  does not line wrap. If you have a lot of text in a  it gets cut at the end.
A workaround would be
<mat-radio-button>{{mylongtext}}</mat-radio-button>
What are the steps to reproduce?
https://stackblitz.com/edit/angular-material2-issue-uaeetd?file=app/app.component.html
What is the use-case or motivation for changing an existing behavior?
I have a pretty narrow window and need to put checkboxes and radio buttons in there.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
I think all of them.
Is there anything else we should know?

I found a way to go through this problem until a definitive solution is released, at least for mat-radio-button.
All you got to do is let your tag without any content and put your text outside it. E.g.:
<mat-radio-group>

        <mat-radio-button [value]="item.id"></mat-radio-button>

        {{ item.description }}

</mat-radio-group>

This must solve your problem.

Redefine that style:
.mat-radio-label {
   white-space: normal;
}

Redefine that style:
.mat-radio-label {
   white-space: normal;
}

white-space: normal doesn't work. Not sure why. The  technique worked.

=== styles.css ===
.mat-checkbox-layout {
white-space: normal !important;
}
.mat-radio-label {
white-space: normal !important;
}

make sure to have your overrides in styles.scss
having it in spans isn't accessible

This is a (partial) duplicate of https://github.com/angular/components/issues/8416

@battre I think yout workaround is not very clear. For those who didn't understand in a first moment, like me, what you got to do is let your tag without any content and put your text outside it. E.g.:
<mat-radio-group>

    <mat-radio-button [value]="item.id"></mat-radio-button>

    {{ item.description }}

</mat-radio-group>

This should solve your problem.

doing this, the text will lose the click event that check the radio button.

@battre I think yout workaround is not very clear. For those who didn't understand in a first moment, like me, what you got to do is let your tag without any content and put your text outside it. E.g.:
<mat-radio-group>

    <mat-radio-button [value]="item.id"></mat-radio-button>

    {{ item.description }}

</mat-radio-group>

This should solve your problem.

doing this, the text will lose the click event that check the radio button.

Looks like the rendering of my comment has changed. I have escaped all HTML tags with backticks and it should be readable now.

Looks like the rendering of my comment has changed. I have escaped all HTML tags with backticks and it should be readable now.

I solved the problem adding ::ng-deep.
::ng-deep.mat-radio-label {
  white-space: normal !important;
}

Yo solucione el problema usando:
::ng-deep .mat-radio-label{
word-break: break-word !important;
white-space: normal !important;
}


Bug fixes

Pull Request Test Coverage Report for Build 400

20 of 35 (57.14%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 60.344%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

template/template_process.go
18
33
54.55%

Totals

Change from base Build 398:
0.05%

Covered Lines:
2873

Relevant Lines:
4761

💛  - Coveralls


Sender should only copy the payload when really needed

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Split into
https://github.com/Azure/azure-sdk-for-net/pull/19821
https://github.com/Azure/azure-sdk-for-net/pull/19822
https://github.com/Azure/azure-sdk-for-net/pull/19823


test performance

test what happens if we request the ids of all entities related to eg 'Vienna'

quikck sample shows that query for places called "Wien" returns roughly 10.000 events

queries are actually very fast 400ms for search for vienna and retrieving all the 10.000 events
payload for 100.000 uris from three different base urls was 250kb gziped.
-> payload seems to be ok, response time as well...


Inclues collection

hi, Is there any way to do includes, so there is no need to perform 2 queries on the db?
you have a example?

Hi @aguilera51284
I have completely re-written this service.
Largely it remains the same. In the readme is an example where I make a second AQL query inside a hook.
The way I structured this app, you can do a lot more. You can extend methods from the service itself. You can do work in hooks. And you can also extend the full class, just changing the methods you need. Here is an example of subclassing:

const feathers = require('@feathersjs/feathers');
const DbService = require('feathers-arangodb').DbService;
const aql = require('arangojs').aql;

class MySpecialService extends DbService {
  constructor(props) {
    super(props);
  }

  async get(id, params) {
    // Always use connect to get your references, this makes sure that they are ready
    const { database, collection } = this.connect();

    // A multi query
    const cursor = await database(aql`
    FOR p IN persons
      LET recommendations = (
        FOR r IN recommendations
          FILTER p.id == r.personId
          SORT p.rank DESC
          LIMIT 10
          RETURN r
      )
      RETURN { person : p, recommendations : recommendations }
    `)

    // Do something with the result, in this case, just pass out the promise
    return cursor.all();
  }

}
const options = {
  collection: 'TODOS',
  database: 'YOUR_DATABASE_NAME',
  authType: AUTH_TYPES.BASIC_AUTH,
  username: 'root',
  password: 'root',
};
const service = new MySpecialService(options);

const app = feathers('persons', service);

Please comment on the issue if you have any more questions.


Include instructions for Meteor 1.3

According to https://github.com/meteor/meteor/issues/7206#issuecomment-230332826 the flemay:less-autoprefixer package causes problems with Meteor 1.3+. He points to the Meteor Guide's suggestion of using the method I've outlined here to obtain LESS autoprefixing.
Please let me know if there are any more changes you'd like me to make.

Thank you @detrohutt! :)


vim plugin: how to disable nit Omnifunc properly?

Hi,
Is there a way to disable the Nit Omnifunc behaviour but keep the standard Omnifunc?
I put this in my .vimrc:
" Disable nit omnifunc
autocmd FileType nit set omnifunc=syntaxcomplete#Complete

But the Nit Omnifunc stills appear!
The only way I found is to comment the line nit.vim.

There is no omnifunc by default in Vim. Maybe it comes from a plugin, or do you want to use the default autocompletion instead?
To deactivate the omnifunc it is:
autocmd FileType nit set omnifunc=''

Yeah, I have this in my vimrc, that is supposed to enable the basic Omnifunc completion:
autocmd FileType nit set omnifunc=syntaxcomplete#Complete

It is working with Ruby and other language. But it seems to be overriden by the Nit settings.


Pass Environment variable to job

Hi,
I use gitlab integrations with jenkins
So when job runs, heavily using the environment variables sent by gitlab to jenkins job such as:
gitlabSourceRepoName
gitlabBranch
Is it possible to set those variables synthetically (like int the "parameters" of job config)?
Thank you,
Roman

Hi @Roman-Bober - I think I have something that will work, and should make the next release.
It requires a user to have the envinject plugin installed.  If detected, the plugin will leverage that to override environment variables before running the job.


404 on https://oras.land/oras-go/v2

Failed to add package oras.land/oras-go/v2 to a project.
$ go get oras.land/oras-go/v2
go: downloading oras.land/oras-go v1.1.0
go get: module oras.land/oras-go@upgrade found (v1.1.0), but does not contain package oras.land/oras-go/v2

If the entry is manually added to go.mod, it reports error after running go mod tidy
$ go mod tidy
go: errors parsing go.mod:
D:\Source\Repos\notation\go.mod:13:2: unrecognized import path "oras.land/oras-go/v2": reading https://oras.land/oras-go/v2?go-get=1: 404 Not Found

Workaround: Add the following entry to the go.mod file:
require oras.land/oras-go/v2 v2.0.0

replace oras.land/oras-go/v2 => github.com/oras-project/oras-go/v2 v2.0.0-20220124135338-24c5637bde7b

This should now be resolved. Please see the the linked PR for oras-www if need to add more resolves


Upgrade Go 1.22 and upgrade dependency

Bumping the Golang version to v1.22 breaks compatibility with older Windows hosts. Golang v1.21.4 is the last version that works with Windows 7 / Server 2008 hosts. It is an operating system unsupported by the manufacturer (community support is still pretty good), but does this version bump add enough features to to break compatibility with several generations of machines? Will compatibility be dropped in future for Windows 10 after it loses support next year?

Well… yes, probably.
Running Gitea on an unsupported system is not supported.
If you still want support for outdated systems, your only bet is commercial support from the Gitea Ltd (ping @techknowlogick, perhaps you are the right contact for that) or similar.
After all, in most cases there's a reason why systems are being made EOL: too much changed since then, and it is expected that it has multiple unfixed problems.
(TBF, Windows 10 might be an outlier there. Let's see if Microsoft doesn't backtrack, Windows 10 shouldn't be obsolete yet.)
Gitea has only a single explicit requirement: git >= 2.0.0, when you're not using gogit.
For everything else, we only support what is still supported anyway (i.e. maintained DBs, maintained OSes, …).
If Go decides to drop Windows 7 support, then argue with them about it.
Gitea will continue to follow Go.
I don't see the need to deviate from them.

We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. :tea:


Support for Pipeline's color and emoji properties

Just like the cluster resource supports the emoji and color properties, graphql also provides those through the pipeline endpoint.
If would be nice to have those properties exposed through Terraform.

Oh yes we've overlooked that. Would you like to provide a PR to add those fields in @gerardo?

Hey @gerardo 👋
You may have noticed - but we've just recently merged a PR including these attributes to main, though its currently not released as of yet. The change will be introduced in the next provider version - shall loop once thats been released!

Thanks for implementing this @james2791!


new graph algorithm breadth first search added

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the
below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the commit guidelines for this project.
[ ] My code follows the standard code structure.
[ ] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[ ] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[ ] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

Hey @vinayd001,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 2a3cf500-e4f1-11e9-950a-c74496fc22d4


Inline creation for record type fields

hi, i realized that inline editing of an added record is available on a record/records type field, is inline creation available as well ?
Something like this:

Hi! This is a bit tricky because you're then submitting a single field value to a new collection record, and there might be other required fields, which could result in errors in that case. But you've given me an idea to implement a quickCreate option in the records field, where you specify a string field from the related collection to populate from the entered value in the records field input. The only condition would be that this collection doesn't contain any other required fields except the one specified in quickCreate. What do you think about that?

I think that's a good idea, to be able to create something like tags on the fly without making trips to the collection and back.
Tho like you said, a collection may have more than just a title field, so another feature alongside yours could be to display the "Add new" button which would on click take you to the create page of that record collection(with parameters referencing the collection and an ID of the collection you want to link it to) and on create, link the new entry to the referencing CollectionID in the parameter - and then possibly redirect the user back.
For example, I currently have two collections: Institutions and Playgrounds.
1 Institution(Tennis Club Joker) can have many Playgrounds(Tennis court 1, Tennis court 2, etc...).
Playground names can repeat across different Institutions(More than 1 institution can have a playground named 'Tennis court 1') so I would like to make it where editors have to add playgrounds from the Institution entry page. Because adding it to the collection first and then searching for 'Tennis court 1' across all entries sounds troublesome when there are more entries named 'Tennis court 1'.
Would love to hear your feedback regarding this feature/issue

Making the "Add new" a link that opens in a new tab is also an option. The problem is that the ID of the new record doesn't exist until it's created. A solution would be to set a temporary key in the user's local storage when "Add new" is clicked. The key value gets reserved by the newly opened tab and then populated with the record ID upon creation. When switching back to the previous tab, the records field will check if the key has been populated with a record ID, and if so, it will add the new record to its array.
Instead of the quickCreate option, this feature could always be available if the current user is permitted to create records in the related collection.

Do you mean when you are creating an entry from a collection A and you try to press the "Add new" button to create a record from collection B, that the entry from the collection A doesn't yet have an ID set ?
If that is the case then I don't think there is a need to solve this, instead I would just disable the "Add new" button on the records field until the entry from the collection A is created.

Do you mean when you are creating an entry from a collection A and you try to press the "Add new" button to create a record from collection B, that the entry from the collection A doesn't yet have an ID set ?

Exactly - creating the record may fail if some fields are required.


Dark mode for jupyter-book

Compare the relevant issue in the jupyter-book repo:

[ ] https://github.com/executablebooks/jupyter-book/issues/1430

Settings are defined at the theme level, compare https://github.com/executablebooks/jupyter-book/issues/1430.

Implemented with one of the latest releases.


Add policyrules tests

Signed-off-by: Adrian Chiris<EMAIL_ADDRESS>

looks good for me, I have only one small comment


Fix undefined tabValue (#6470)

#6470 Points out that the new UI nav bar does not correctly set the ;tabValue on initial page load.
This is because useParams will return the params from the route as defined in the router. Our router does not define :tabValue/* for all routes so the object returned from useParams does not have a tabValue property and is therefore undefined on initial page load.
This PR uses useMatch to create a new URL match for :tabName/* and sets the tabValue variable correctly.
The result, is a navbar that always has the correct tab shown as active.

Also fixes #6471

@XanderLuciano nice work, seems to work pretty well :)

Thank you! I'm Looking forward to submitting additional contributions towards the new react UI 🥳


Fix incorrect multiboot size tag declaration

Per the spec it should be a u32, not a u16. Weirdly, this error seems
isolated to Chapter 3- all the other chapters already use a u32 for the
size field.
(Related: intermezzOS/book#136)

Thanks so much!