Color missing, will not compile.

Color is referenced in ImageTools ( and Image ) try using code without Vision installed.
Since Image is fairly common class name it should be in a gridge package.
For JS target I have been trying to see if there is a more efficient approach to drawing pixels to a canvas but not yet managed to get it rendering ( added in the Image abstract  'to haxe.io.UInt8Array' and made it @:transient ).
        var image = new Image( 1024, 768, 0xFFFFFFFF );
        image.fillRect( 100, 100, 300, 200, 0xF0c000 );
        var img: haxe.io.UInt8Array = image;
        var sub = cast( img.subarray( 3, Std.int( image.width*image.height) ), js.lib.Uint8Array );// unsure..
        var data = new js.lib.Uint8ClampedArray( sub.buffer );
        var imageData = new js.html.ImageData( data, image.width, image.height );
        ctx,putImageData(imageData, 0, 0);

it would require to store the color differently for js?
	public inline function new(width:Int, height:Int, ?color:Color = 0x00000000) {
		this = new UInt8Array(width * height * 4 + OFFSET);
		this[0] = width & 0xFF;
		this[1] = width >> 8 & 0xFF;
		this[2] = width >> 16 & 0xFF;
		this[3] = width >> 24 & 0xFF;
		var i = 4;
		while (i < this.length) {
			this[i] = color >> 16 & 0xFF;
			this[i + 1] = color >> 8 & 0xFF;
			this[i + 2] = color & 0xFF;
			this[i + 3] = color >> 24 & 0xFF;
			i += 4;
		}
	}

	inline function getColorFromStartingBytePos(position:Int):Color {
		position += OFFSET;
		var c = 0xFF000000;
		c |= this[position]  << 16;
		c |= this[position + 1]<< 8;
		c |= this[position + 2] ;
		c |= this[position + 3]<< 24;
		return c;
	}

	inline function setColorFromStartingBytePos(position:Int, color:Color) {
		position += OFFSET;
		this[position] = color >> 16 & 0xFF;
		this[position + 1] = color >> 8 & 0xFF;
		this[position + 2] = color & 0xFF;
		this[position + 3] = color >> 24 & 0xFF;
		return color;
	}
	```
	thinking maybe have a base abstract that you inherit from that limits access direct and you can typedef for target.

But you may find an alternative for speed is to use an UInt32Array to set color more directly..
var ui32a = new js.lib.Uint32Array( data.buffer );
then in for loops you can set the value in one assignment per pixel, rather than accessing each color channel, even if it requires some logic twizzling.

Think probably minimal color class should be added to Image when Vision is not used.

would like drawTri and fillTri method since you have non AA circle, maybe can provide, but should prob include some canvas optimisations in ImageTools as possibility.  Needs cloneToCanvas method.

I agree, I've noticed you're using RGBA format instead of ARGB in your example. The image class uses ARGB

    I think your approach is wrong for working direct in js.
    subarray does not work because it is a view and is wrong size.  To get the correct size you can use slice.
    https://stackoverflow.com/questions/10100798/whats-the-most-straightforward-way-to-copy-an-arraybuffer-object
    ```Haxe
    var img: haxe.io.UInt8Array = image;
    var img2: js.lib.Uint8Array = cast img;
    var sub = img2.slice( 4 );
    var data = new js.lib.Uint8ClampedArray( sub.buffer );
    var imageData = new js.html.ImageData( data, 1024, 768 );
    g.me.putImageData(imageData, 0, 0);
    ```
    My conclusion is you should have different UInt8Array's so that the most effiecient format can be used and have conversion tools. It does not seem ideal to pack the width and height into the abstract as it takes iterations to extract.  Thinking perhaps an Image class with a UInt8Array instance, and width and height.

maybe, ill look into that in a couple of days

Sharhar
I have roughed out an approach here ( committed direct to github ).
https://github.com/nanjizal/pixelimage/blob/main/src/pixelImage.Pixelimage.hx
But have not debugged tested it yet so maybe very broken but it outlines an approach.

ok it's ugly as canvas seems to use ABGR  as you said, but now it seems to be finally working.  probably need to consider Image to be in the easiest format for a toolkit to atleast reduce overhead on the image side have added demo code.  The << and >> could be improved, they are verbose for now.


Can't have global sound objects

Using a global sf::Sound object causes the program to crash on exit with an assertion failure. I realize that using global objects is frowned upon, but it would be nontrivial to rewrite my program to not use them. This happens with straight globals, class statics, function statics, and file statics, meaning there's no good workaround. I believe it started when I upgraded SFML to 2.2, or maybe 2.1 - it hasn't always been an issue.
The following minimal code:
#include <iostream>
#include <SFML/Audio.hpp>

sf::Sound my_sound;

int main() {
	std::cout << "SFML Version: " << SFML_VERSION_MAJOR << '.'
		<< SFML_VERSION_MINOR << '.'
		<< SFML_VERSION_PATCH << std::endl;
	return 0;
}

when compiled with clang++ test.cpp -framework SFML -framework sfml-audio, produces the following output and terminates with SIGABRT:
SFML Version: 2.3.0
AL lib: (EE) alc_cleanup: 1 device not closed
Assertion failed: (lockret == althrd_success), function LockLists,
	file /Users/ceylo/al/openal-soft-1.16.0/Alc/ALc.c, line 779.
Abort trap: 6

I had hoped you'd read my comment, but I guess you didn't...
The destruction order of global objects is undefined.
As I said and you said yourself, don't use global SFML resources and you'll be fine.

And as I said, it's not easy to change my code to avoid using global SFML resources. (I'm not certain it's actually possible.) However, it's entirely possible to guarantee that an object is not destroyed until after other objects depending on it (it's not even all that hard to be honest), so it's not like this isn't fixable on your end. I also strongly disagree that it's not an issue - a crash is a crash is an issue in my opinion.
I can see that you don't care or want to fix it, but I would be willing to try. Would you at least consider accepting it if I made a pull request for this?

And as I said, it's not easy to change my code to avoid using global SFML resources. (I'm not certain it's actually possible.)[/quote]It's almost always possible to find a design that doesn't use global variables. Of course you have existing code, so you may need some refactoring.

I also strongly disagree that it's not an issue - a crash is a crash is an issue in my opinion.

Yes, and we constantly recommend not to use SFML objects, especially not resource-related ones, in global scope. Don't blame the library for deliberately ignoring such advice.

However, it's entirely possible to guarantee that an object is not destroyed until after other objects depending on it (it's not even all that hard to be honest)

No, it's not directly possible, not as long as you maintain ownership and deterministic destruction semantics. In C++, it has always been the default paradigm that objects live during their scope, and dependencies must outlive their clients.
Deviating from that needs considerable book-keeping effort and adds a lot of complexity to manage dependencies correctly. We've had a lot of problems with such hacks in SFML (e.g. OpenGL context), and I don't like the idea of adding further ones, just to support paradigms that are actively discouraged anyway.

I looked into it a bit and it seems the problem is related to OpenAL's use of atexit() to register a handler that cleans up the library, and I can't see a way to ensure SFML has a handler that runs prior to OpenAL's, so I'm not certain it's worth fixing. For my own code, a simple change might be storing pointers to sf::Sound and destroying them explicitly before main() returns... though I don't like having explicit shutdown code like that...
I do think this issue should be left open in case someone thinks of a reasonable way to fix it, but I suppose I can at least prevent the crash now that I know the reason for it.

I do think this issue should be left open in case someone thinks of a reasonable way to fix it

I'm afraid that there's probably none. If you look at the longevity pattern, you'll see that it also fiddles with atexit(), but you can only use that to set an order between objects controlled by you, not by an external library. And even if you could, it's an ugly workaround with pitfalls, for a problem that never appears in clean C++ code.
Those guidelines to avoid global variables in general and for SFML in particular exist for a reason... And in C++, you always have to bear the consequences if you don't follow good practices :wink:

For the record, the SFML code in Sound.cpp currently appears to be attempting something vaguely similar to your PhoenixSingleton, but it doesn't work because OpenAL's atexit() is called before SFML's static destruction routines (and adding an atexit() in Sound.cpp doesn't seem to make any difference).
Using pointers like I mentioned above seems to have worked for me, in any case.


♻ Use gstatic rather than neverssl

...so we can have consistent behavior with all our tests.
New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I'm adding
[ ] I have updated the documentation (if necessary)
[x] I have run the tests without failures
[ ] I have updated the CHANGELOG.md in the corresponding package

Well, gstatic does not support H2 upgrades on this non-TLS path.


Tabs opened through the command line automatically close when terminating their program

I'm using a long command-line shortcut to open several Windows Terminal tabs at the same time.
wt -p "Windows PowerShell" -d C:\Users\arianeb\backend --title backend-srv docker-compose up `; new-tab -p "Windows PowerShell" -d C:\Users\arianeb\frontend --title frontend-srv C:\Program Files\nodejs\npm.cmd run dev `; new-tab -p "Windows PowerShell" -d C:\Users\arianeb\backend --title backend `; new-tab -p "Windows PowerShell" -d C:\Users\arianeb\frontend --title frontend

It works fine, but afterwards, whenever I use Ctrl-C to stop/restart either of the servers that are launched in the first two tabs, the tab is closed, which is inconvenient.
It doesn't happen at all if I launch the server in a manually opened tab.
I'm sure it's something I didn't understand in the docs, an option somewhere that I missed. Can someone help me?

Have you changed closeOnExit to always?
The three accepted values for closeOnExit are the following:

always: if the application terminates for any reason, close the tab
graceful: if the application terminates with no error, close the tab
never: if the application terminates for any reason, keep the tab open.

closeOnExit isn't in my Settings.json, so I can only assume it's at its default value, "graceful".

Ah, I see. It looks like you might be interested in /dup #4772. Exiting an application with Ctrl+C looks like a successful exit, but I bet the thing you want is to relaunch them :smile:

What I don't understand is why manually opened tabs don't get closed when I end a process with Ctrl-C, while they do if they were opened with the wt command.

When you manually open a tab, is it a tab directly to "docker-compose" or is it running powershell or cmd?
If it's running powershell or cmd, and then you run docker-compose (or npm, or anything else)... the Ctrl+C is returning you to the shell.
When you run wt docker-compose (or npm, ...) there is no other shell running!
If you want that behavior, you will need to explicitly request it. Terminal doesn't want you to pay for something you are not using, like an extra shell process.
As an example,
wt cmd /k docker-compose up

if you press ^C in that tab, cmd will come back because it was asked to "keep running" (/k)
For powershell, it is a little different:
wt powershell -noexit -command docker-compose up

Does that help?

I see... thanks for the explanation. I don't think I could've found that info by myself.
I wasn't aware it was possible for a CLI program to run without executing a shell. I was just assuming that if I picked the PowerShell profile, it was executing PowerShell. That's wild. (And it kinda feels like grasping at droplets of performance to me, considering how light a program a shell is, but never mind that.)
In your example programs, what are cmd and powershell ? Are they the final "execute this command upon tab open" argument? So they'd go after any profile, tab name, etc. arguments?

cmd and powershell are the actual shells! They're the ones that launch when you choose "Command Prompt" and "Windows PowerShell" from your profile list.
When we run them like this, we're saying "windows terminal, please start powershell" and "powershell, please start docker-compose".
Another reason that Terminal will not automatically run a shell is that it can't know which one you want! Running "wt docker-compose" is actually just like finding docker-compose.exe and double-clicking on it. In Windows, it's normal to run a commandline application without a shell. That's just how they launch if you run them from a shortcut, or from your desktop, or even by using the Run dialog!

But isn't it loading the profile I asked it to run? Like, doesn't wt -p "Windows PowerShell" mean "run Terminal, and open a PowerShell tab"? That's the thing I was confused about. I really thought profiles running shells was implicit.

Also, I'm realizing I've been sounding a tad dickish throughout this whole interaction. I apologize, and I wanted you to know your kind explanations were very much appreciated. Thanks.

I wonder if there is a similar solution if I want to invoke the command with WSL instead of PowerShell, like so:
wt new-tab -p "WSL (Ubuntu)" wsl echo "hallo"


Chore/browserify

[Current coverage][cc-pull] is 98.16%

No coverage report found for master at 0d82ec3.

Powered by Codecov. Last updated by [0d82ec3...82c8d97][cc-compare]
[cc-base-branch]: https://codecov.io/gh/segment-integrations/analytics.js-integration-mixpanel/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/segment-integrations/analytics.js-integration-mixpanel/compare/0d82ec392af81154be73b51aa782d1f350ae4d89...82c8d97840e076643198dd21283cf8f5d5227235
[cc-pull]: https://codecov.io/gh/segment-integrations/analytics.js-integration-mixpanel/pull/23?src=pr


x/tools/cmd/git-codereview: fails if .git/hooks is not a directory

On some versions of Git I think "git init" does not create .git/hooks, so .git exists but .git/hooks doesn't and the tool fails.
git-codereview should create .git/hooks if it does not exist before trying to write .git/hooks/commit-msg

Ah good to know

(if anyone in the room at Gophercon wants to work on this one - I'm happy to help!)

If nobody from GopherCon wants to work on it, I would want to try this one as well

@xmudrii Did you still want to try this one?

Yes, I'm just waiting @kevinburke to confirm it's free (I actually went to sleep).
If he wants to give few hints before I start, feel free to do. :)

I don't know of anyone currently working on this, sorry
On Sun, Jul 16, 2017 at 01:46 Marko Mudrinić<EMAIL_ADDRESS>wrote:

Yes, I'm just waiting @kevinburke to confirm it's free (I actually went
to sleep).
If he wants to give few hints before I start, feel free to do. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/21028#issuecomment-315591971, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOSI7harrdlO9ehSm02tUD8B415hSzJks5sOb_OgaJpZM4OZHPr
.

--
--
Kevin Burke
925.271.7005 | kev.inburke.com


Fix header offset with jump links

Describe the bug (required) A clear and concise description of what the bug
is.
When linking to a specific subheader on the docs the header for the section you link to actually disappears behind the nav , would it be possible to introduce an offset here so that the subheader of the section you link to still shows? e.g. https://livepeer.org/docs/installation/install-livepeer#install-a-binary-release
Expected behavior (required) A clear and concise description of what you
expected to happen.
Still show the header.
https://css-tricks.com/fixed-headers-and-jump-links-the-solution-is-scroll-margin-top/

@kyriediculous I'm going to transfer this to the livepeer-org repo...


When using gateway my ismart app token constantly expires

When using gateway my ismart app token constantly expires
I have to log into my ismart app every time I open it. I think this is something to do with the logon token and am thinking that the saic-python-mqtt-gateway has an active token making the one on my ismart app not work?
Does anyone else have this same problem?

Known issue from SAIC Server side. Only one ne active login (valid token) at a time.Works as designed (by SAIC), GW can do nothing about it.Am 02.02.2024 um 12:43 schrieb daknightuk @.***>:
When using gateway my ismart app token constantly expires
I have to log into my ismart app every time I open it. I think this is something to do with the logon token and am thinking that the saic-python-mqtt-gateway has an active token making the one on my ismart app not work?
Does anyone else have this same problem?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Do anyone know the lifetime of a login token ? If it is long-lived, then it might be smartest just to copy it from the phone after login ?


Increase displayed properties, API version update.

Replicated changes from https://github.com/groupdocs-metadata/GroupDocs.Metadata-for-.NET-MVC/pull/3.

 Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/Products/Metadata/Controllers/MetadataApiController.cs  -4

Clones removed
==============
+ src/Products/Metadata/Controllers/MetadataApiController.cs  -2

See the complete overview on Codacy


How to select start and end point to not have to download the full video ?

It is possible to download the full video than crop it , but i would like to download only a portion of the video , is that implemented, if not , do you think it is possible ?

You can use FFmpeg command line.

Also interested in knowing if this is possible in pytube ?


Versions supported?

Would be nice to specify what versions of three.js are supported.

currently i work only on the last release. there is already quite a bit of job.
i will add something in the about tab

thanks for the pullrequest and the suggestion btw :)
have you looked at the UI ? i reused the editor code and built on top

Looking good! 😊

i would gladly port that back to the editor btw.

Hmm... I'll take a look

i will email you to explain the code

Feel free to explain over here. I get too much email and it may get lost...

ok lets do that here.
I forked three.js editor twice already. so i got acquinted with this part of three.js.
thanks for doing the hard work :) and i would like to contribute back.
So here is how the ui is done for three.js inspector
it is all based on three.js editor r71 UI. It defines all the atomic type (color, number, input text, basic texture). On top of this on top of this, three.js inspector added a layer for each type of row.
Currently in the editor, the code for each type of row (color, texture, vector3) is duplicated. Having a layer for the rows avoid this duplication. it allows better refactoring. See the texture row for example. it handles the repeat/offset/wrapST. it has upload texture and even handles drag/drop from desktop. every texture got the same widget even if it is a bumpMap within a face material :)
three.js inspector implement tabs too. you can see them on the left and right sidebars. i think it works well used for the object3d/material/geometry triplet. in the editor, we end up with a 'too long' panel. We scroll it all the time. to put object3d/geometry/material in tabs like the inspector, make it easier.
more details were added here and there. e.g. when dragging on number support shift to 10-fold, meta to 100-fold, shift+meta for 1000-fold. e.g. awesome icon for button
i likely forget other stuff. but the good part is that most of it is directly compatible
with the three.js editor. I forked it twice already (thanks again :)). i believe the modification are inline with the spirit of the editor.
if we backport that to the editor, we would end up with a better UI (thanks to the tabs+texture), a cleaner code (as we reduce duplication of the row code), a richer tool to design the ui of the future version of the editor.

Folders split out

the editor-libs acts as the editor/libs/ of three.js editor
here is the layer for the rows. each property got a type, it is where we pick the row type to handle them.
then come the 'panel level'. It is where we handle large panel. It is very much like
each geometry in three.js editor for examples.

this part is very similar to three.js editor, but slightly different. while three.js editor got directly access to three.js objects, three.js inspector is within devtools and so need to pass the information between iframe before actually reaching three.js :)

All in all, i think there is good UI in there, and three.js editor could benefit from it, i would like to contribute back to three.js.
any part interest you more than another ? i could start by porting the tabs, then to try some rows. what do you say ?
There you got it all :)

That sounds great! Yes, lets try to integrate these things in the next cycle (r73) 😊

Excelent!


Delete kwm, libspotify, perforce-server, update tap_migrations

Continues https://github.com/Homebrew/homebrew-binary/pull/364.

Thanks again @miccal! In future feel free to push to the existing PR.


processed data file data.zip

Hi, sorry for bothering, where can I find the processed data file data.zip which is mentioned in README.md

I just uploaded processed dataset in data/data.zip

cool, thanks


Light theme

Would it be possible to create a light theme for the app and have it as a setting?

Thanks for the request, I'll see if this is something that can be easily done!


Change URL for SPECTrecon.toml

This package was moved more than a year ago...

BTW, I ran the version check given in https://github.com/JuliaRegistries/General/blob/master/CONTRIBUTING.md and they are all there.
 (pkg_name = "SPECTrecon", version = v"0.0.1", found = 1)
 (pkg_name = "SPECTrecon", version = v"0.0.2", found = 1)
 (pkg_name = "SPECTrecon", version = v"0.0.3", found = 1)
 (pkg_name = "SPECTrecon", version = v"0.1.0", found = 1)


Save people time

Save people a command and keep them in their current directory.

I'm going to call a pass on this. Sure it could save some people time, but also introduces confusion. Since it's not a common git clone command  format it would be easy for somebody to bungle it up. The separate step of cd'ing to the right place both makes sure they know what they are doing and allows for installs which are not in the  path you hard coded (which by the way would break on Windows or for Neovim and in several other cases). Thanks for taking the time to contribute, but I don't think this improves the situation for everybody. Also anybody that understands this difference probably has a plugin manager going anyway.

I have to, respectfully, disagree with you on this...I think it is a fairly common format for anyone even somewhat familiar with git. There is really no reason to change to the directory and is a pain for people who are frequently switching machines and are just getting started with the plugins, speaking from personal experience. I've never installed on Windows, but I think this would merit a case where you could have a Windows and a Unix version. It is a lot more convenient for me to just search for the repository on google, and copy and paste the plugin installer, and this impedes my workflow when doing so. Again, it's not like it's a huge deal, but it is kind of a pain.
I often only install plugins when I'm ready to use them to try and keep my machine clean, and to do this, I have only a few plugins and stuff that automatically get installed, and I only do this after several times of installing them and deciding they are necessary. Nerdtree is one that has made it into the automated installation process, but for a while there, I was copying and pasting every time, and I would have to figure out how to install it, which was a pain for a newish user, and this was just one of the problems that made it inconvenient.
Anyway, I was thinking of making my own plugin for navigation anyway, so I guess this can just be another reason to do that.
I have seen several other plugins do this, and they were much more convenient to install.

Tell you what: I still disagree, but I don't have time to argue it right now. What I'll do for now is ① re-open this PR so that it hits the radar again and ② request that anybody reading this that understands the ins and outs of plugin install methods takes a minute to review and comment here.
If it turns out I'm the only one that sees this as a problem we'll go ahead with a merge. If other folks see the pitfalls and think the more verbose explanation is better we'll leave it the way it is. And if anybody has time to do a better/more through rewrite of the install instructions that would be helpful.

Also, I merged a PR from somebody fixed a ton of spelling and other issues in the README and plugin docs so this now has merge conflicts and will need to be rebased.

Cool! I went ahead and created a new pull request, taking the things you mentioned into account. I think it was a good call to make it an alternative, and I think it turned out much more explanatory and user friendly.


[ENG-637] Feature/sparse lists

Purpose
Regular list endpoints are slow because they serialize more than is needed for most cases. However, ember requires consistency between requests for items of the same combination of id and type. This attempts to solve that by providing a new set of endpoints for Nodes and Registrations that uses sparse serialization and provides a new type for the objects, thus keeping Ember from being confused.
Changes

New sparse-[node, registration]` endpoints with all the fixins
Tests

QA Notes
Testing for this is purely through the API. There are a new set of endpoints under /v2/sparse/ that get nodes and registrations. List of endpoints below. When you use these endpoints, 1) they should be much faster; 2) you should get a limited subset of the fields. According to @jamescdavis:
The fields/relationships the FE needs for node lists are:

title
description
date_created
date_modified
public
fork
category
currentUserPermissions
contributors
tags

Registrations also need:

pendingRegistrationApproval
withdrawn
pendingWithdrawal
pendingEmbargoTerminationApproval
embargoed
pendingEmbargoApproval
archiving
registrationSchema
registeredMeta

There will be extra fields there because we need them; the above list is just what was explicitly requested by Front End. As mentioned above, these lists should be no slower and preferably much faster than the non-sparse versions of the lists. If relationships are to a node or a registration, it should reference the sparse version of that (except for the detail relationship, which should be the full version). Self link should go to the sparse detail link.
The specific endpoints added under /v2/sparse/ are:

nodes
nodes/<node_id>/
nodes/<node_id>/children
nodes/<node_id>/linked_nodes
nodes/<node_id>/linked_registrations
registrations
registrations/<registration_id>/
registrations/<registration_id>/children
registrations/<registration_id>/linked_nodes
registrations/<registration_id>/linked_registrations
users/<user_id>/nodes
users/<user_id>/registrations

Documentation
We are going to keep this undocumented for now. It may eventually be documented, but we want to maintain the flexibility of undocumented endpoints until the front end is happy with the functionality, as this is a brand-new paradigm for api serialization.
Side Effects
This should not have any effect on existing functionality.
Ticket
https://openscience.atlassian.net/browse/ENG-637

merging into feature/staging-1 for testing


Reenable disabled tests

This reenables several disabled tests and reverts an incorrect change to the bootstrap script.

@swift-ci please smoke test

Looks like we have some bit rot in the FunctionalTests that were disabled?

@swift-ci please smoke test


JCache native mode

Addresses issue #1846

Thanks @javaduke. This is good to merge after addressing the small nitpicks found by @zhfeng @aldettinger and me. Plus we hope to get a followup PR for https://github.com/apache/camel-quarkus/issues/4092 soon.

Hmm, not sure why this one check is failing, not my fault :)

Highly likely a download issue. Let's re-run the failed job to be sure.

Strange, now it's FTP test that is failing...

This one is a long time flaky test, sure it's not linked to the PR.
Let's merge then.


Chapter4 TargetVersion Defined as Windows7 not support on VS2022

Chap4 sample of(Booster, Boost) Target Version limited Windows7. so how to make it works to pass VS2022 or latter?

sorry, After I try to changed from Win7 to Win10, passed building, but have not trying it works or not.

Verified it works well on Win10 with VS2022, so suggest other readers revised the targetVersion in case could not pass building


feat(CTCP-2669): remove nav to incident page for normal & simplified …

…procedureTypes

Closing this pull request since this pull request - https://github.com/hmrc/manage-transit-movements-arrival-frontend/pull/226 has the changes required


💬 RFC: [Scaffolder] BitbucketServer: possible to configure base path?

🔖 Need
I have an issue with the BitbucketServerPullrequest action. First step of adding the branch returns successfully, but when scaffolder tries to clone the project it fails with this error:
2024-08-06T10:02:46.609Z info: Cloning repo {dir=/tmp/38e93526-65a9-4a95-8b55-8b9d306a345e_step-publish-0Ptihw,url=https://bitbuckethost/scm/project/repo.git}
2024-08-06T10:02:46.653Z error: Failed to clone repo {dir=/tmp/38e93526-65a9-4a95-8b55-8b9d306a345e_step-publish-0Ptihw,url=https://bitbuckethost/scm/project/repo.git}

When manually cloning the project from the Bitbucket UI we get this url: https://bitbuckethost/stash/scm/project/repo.git (notice the /stash part).
So our need is to be able to configure this property in the scaffolding action.
🎉 Proposal
Add an extra optional field for this action called bitbucketBasePath, where it's possible to set /stash in our case so that the cloning of the repo targets correct url.
〽 Alternatives
Look into if this is an issue with our bitbucket-instance and fix it there.
❌ Risks
Risk of adding more/unnecessary complexity to an existing action.
👀 Have you spent some time to check if this RFC has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

This is likely something that would go into the bitbucket integrations config, rather than the action. Either for Bitbucket Cloud or Bitbucket Server, depending on which one you're using.


error while running npm start on linux

Here is the log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/vscode/Griphitor-IDE/node_modules/.bin:/home/vscode/.vscode-server-insiders/bin/ff1e16eebb93af79fd6d7af1356c4003a120c563-insider/bin:/home/vscode/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/home/vscode/.local/bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/vscode/Griphitor-IDE
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'electron .' ]
11 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
12 verbose stack Error<EMAIL_ADDRESS>start: `electron .`
12 verbose stack spawn ENOENT
12 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:48:18)
12 verbose stack     at ChildProcess.emit (events.js:314:20)
12 verbose stack     at maybeClose (internal/child_process.js:1022:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
13 verbose pkgid<EMAIL_ADDRESS>14 verbose cwd /home/vscode/Griphitor-IDE
15 verbose Linux <IP_ADDRESS>-microsoft-standard-WSL2
16 verbose argv "/usr/bin/node" "/usr/bin/npm" "start"
17 verbose node v12.22.7
18 verbose npm  v6.14.15
19 error code ELIFECYCLE
20 error syscall spawn
21 error file sh
22 error errno ENOENT
23 error<EMAIL_ADDRESS>start: `electron .`
23 error spawn ENOENT
24 error Failed at the<EMAIL_ADDRESS>start script.
24 error This is probably not a problem with npm. There is likely additional logging output above.
25 verbose exit [ 1, true ]

@Advik-B Hello thanks for your Feedback we are improving our IDE every day. there will be a fix to this problem you will get another ping when done

If that does not fix your issue, try installing libnss3-dev
sudo apt-get install libnss3-dev

@Advik-B  We have fixed your problem. Enjoy and reinstall.


refactor: unify replace count(*) analyzer by removing it in sql crate

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

replace count() analyzer by removing it in sql crate, sql/dataframe all use rule to replace count()
fix: CountWildcardRule ignore Expr::Alias

Are these changes tested?

Are there any user-facing changes?

cc @jiangzhx who did some related work on  https://github.com/apache/arrow-datafusion/pull/5518 I think


Don't show the Download App Banner until Past Sign in

Details

Core behavior follow up for https://github.com/Expensify/App/pull/25418
Changes:
Only show the Download App Banner AFTER sign in.
Also, show it before the global create menu opens. See video:
https://github.com/Expensify/App/assets/38015950/c312b2f9-5bca-4478-9180-7e5db4750d27
Fixed Issues

https://github.com/Expensify/App/issues/25820
$ https://github.com/Expensify/Expensify/issues/310804
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

NATIVE, WEB, DESKTOP

[ ] Verify Banner does NOT appear

mWEB

[ ] Verify Banner does appear
[ ] Click the close button, verify that Banner closes
mWEB IOS
[ ] Click the download button, verify that link opens Apple Store listing
mWEB Android
[ ] Click the download button, verify that link opens Google Play Store listing
Test Dismissing Banner
[ ] 1. From Sign in page, dismiss banner.
[ ] 2. Sign out and Sign in again and verify that banner remains dismissed.
Test New User Global Create Menu Opens After Dismissing Banner
[ ] 1. Sign in with a new user
[ ] 2. Verify that banner appears.
[ ] 3. Dismiss Banner. Verify that global create menu is opened.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console
mWEB
[ ] Verify Banner does appear
[ ] Click the close button, verify that Banner closes
mWEB IOS
[ ] Click the download button, verify that link opens Apple Store listing
mWEB Android
[ ] Click the download button, verify that link opens Google Play Store listing
Test Dismissing Banner
[ ] 1. From Sign in page, dismiss banner.
[ ] 2. Sign out and Sign in again and verify that banner remains dismissed.
Test New User Global Create Menu Opens After Dismissing Banner
[ ] 1. Sign in with a new user
[ ] 2. Verify that banner appears.
[ ] 3. Dismiss Banner. Verify that global create menu is opened.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

https://github.com/Expensify/App/assets/38015950/c312b2f9-5bca-4478-9180-7e5db4750d27

Desktop

iOS

Android

@jjcoffee please prioritize this review as it's a high priority item! 🙇♂

@jjcoffee could you please prioritize this PR review? 🙏
E/E issue reads:

Coming from this convo, we want to remove the banner prompting the user to download our app from the SaaStr landing page (sign in/sign up) in order to ensure we aren't increasing barriers to signing up.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@grgia Just a nitpick: test steps need to updated to state the banner only appears after sign in. Also, not sure if it's a biggie but there are missing screens for platforms other than iOS mWeb (maybe we're skipping this to get it done quickly?).

@grgia Sorry another nitpick on the tests, there's still this line which is no longer relevant: From Sign in page, dismiss banner.

@grgia Just the tweak to the tests and now some lint complaints and then we're good to go, I think!

@jjcoffee looking now!

@grgia I think the test step 2. Sign out and Sign in again and verify that banner remains dismissed. isn't a feature that was added here? (In any case doesn't pass on Android Chrome)

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.59-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Web sockets API: when is subscription terminated?

Just a question on:
https://github.com/solid/solid-spec/blob/master/api-websockets.md
This says how a subscription is created, but it's not explicit about when the subscription expires.  I'm guessing it's when the Websocket connection is closed.  amirite?

Hi,
You are correct. The Websocket is currently terminated when the client (browser) disconnects.

Moving this issue to solid/specification for consideration.


[Backend] Load Default Experience Configs

Closes #3305
Description Of Changes
Load two default experience configs on startup, one for overlays and one for the privacy center.  The experience configs largely contain the "copy" for an experience that will contain button labels, descriptions, etc. that are used to present privacy notices for users in various regions.  No regions are linked here.
Second, use these default experience configs automatically:

When creating privacy notices, for each region, link the associated PrivacyExperience to the relevant default ExperienceConfig if it's not already linked to anything so it has copy by default.
When removing a region from an ExperienceConfig, link to the relevant default ExperienceConfig behind the scenes.

Code Changes

[ ] Add a yaml file with the default configs data/privacy_notices/privacy_experience_config_defaults.yml
[ ] Load into the db both on startup and load in the tests as well. (this differs from the out of the box privacy notices where I'm not loading them into the db in unit tests due to the larger-reaching changes of notices being updated in the future).

[ ]  Unlike default privacy notices, there is no "template" table here, I load these directly into the PrivacyExperienceConfig table.  They are upserted - created if they don't exist and updated if they do.
[ ] An "id" is specified in the yaml for upserting purposes

Steps to Confirm

[ ] Run nox -s dev -- shell
[ ] GET {{host}}/experience-config?
[ ] Verify contents of experience configs in the response - copy should match this
[ ] Verify the versions of both are 1.0
[ ] Exit the container
[ ] Bring fides up again nox -s dev -- shell
[ ] Hit the GET Experience Configs endpoint again and verify both versions are unchanged at 1.0
[ ] Exit the container
[ ] Make a change to one of the default configs in data/privacy_notices/privacy_experience_config_defaults.yml
[ ] * [ ] Hit the GET Experience Configs endpoint again and verify the changed detail and that that experience has been bumped to 2.0
[ ] Exit the container

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Thanks so much for your quick review on this @allisonking. I can pull this into the other ticket too, the default privacy notices and do more thorough testing there.

Load two default experience configs on startup, one for overlays and one for the privacy center. The experience configs largely contain the "copy" for an experience that will contain button labels, descriptions, etc. that are used to present privacy notices for users in various regions. No regions are linked here.
Second, use these default experience configs automatically:
When creating privacy notices, for each region, link the associated PrivacyExperience to the relevant default ExperienceConfig if it's not already linked to anything so it has copy by default.
When removing a region from an ExperienceConfig, link to the relevant default ExperienceConfig behind the scenes.


AppsFlyer Integration Documentation

I'm currently trying to implement AppsFlyer into our bubblewrap TWA. I've noticed that @andreban added a commit to support the AppsFlyer SDK https://github.com/GoogleChromeLabs/bubblewrap/pull/278/files#diff-4db0ae3cf5a497bda3407532f94f2c474cb553f8e4d6161add886361991a25a9R24 but I can't find any documentation on how to use it
Following the documentation on Appsflyer https://support.appsflyer.com/hc/en-us/articles/360002330178-Using-AppsFlyer-with-TWA-and-PWA#inapp-events-with-twa-getting-the-appsflyer-id hasn't gotten me far
Steps I've completed:

Add appsFlyerId/dev key to features list:

"features": {
    "appsFlyer": {
      "appsFlyerId": "xxx"
    }
  },

Add jitpack maven url to the top level build.gradle file

repositories {
        google()
        jcenter()
        // For AppsFlyer https://support.appsflyer.com/hc/en-us/articles/360002330178-Using-AppsFlyer-with-TWA-and-PWA#inapp-events-with-twa-getting-the-appsflyer-id
        maven { url 'https://www.jitpack.io' }
    }

Added custom-tabs-client implementation to app/build.gradle - can no longer build, fails with 502

dependencies {
    implementation fileTree(include: ['*.jar'], dir: 'libs')
        // AppsFlyer https://support.appsflyer.com/hc/en-us/articles/360002330178-Using-AppsFlyer-with-TWA-and-PWA#inapp-events-with-twa-getting-the-appsflyer-id
        implementation 'com.github.GoogleChrome.custom-tabs-client:customtabs:91b4a1270b'

        implementation 'com.google.androidbrowserhelper:androidbrowserhelper:2.2.0'

}

Attempted to add customtabs imports to app/build.gradle - can no longer build, import fails

// AppsFlyer imports https://support.appsflyer.com/hc/en-us/articles/360002330178-Using-AppsFlyer-with-TWA-and-PWA#inapp-events-with-twa-getting-the-appsflyer-id
import android.support.customtabs.CustomTabsClient;
import android.support.customtabs.CustomTabsIntent;
import android.support.customtabs.CustomTabsServiceConnection;
import android.support.customtabs.CustomTabsSession;
import android.support.customtabs.trusted.TrustedWebActivityIntentBuilder;
import static android.support.customtabs.TrustedWebUtils.EXTRA_LAUNCH_AS_TRUSTED_WEB_ACTIVITY

I'm unsure where i should be looking next. I assume i need to bubblewrap build again but doing so fails with invalid imports. What steps am i missing? How do I use the SDK integration?
If someone could help me out i'd be happy to write up a doc compiling my findings
Thanks in advance

With  Bubblewrap, you only need the first step to enable AppsFlyer feature and set the appsFlyerId:
"features": {
    "appsFlyer": {
      "enabled": true,
      "appsFlyerId": "xxx"
    }
  },

The steps in the AppsFlyer docs are for creating the integration manually - and the TWA used in their docs are outdated.

Thanks @andreban. Do you know of any alternatives that will work with Chrome OS?

Any web analytics will work as expected for the web part of the application. Are you looking for something specific in terms of Android analytics SDKs? (eg: install referrer was the use-case I heard for AppsFlyer)

Yeah that's right - we're looking for something to fill in the missing gap of install referrer

This has been documented at https://github.com/GoogleChromeLabs/bubblewrap/tree/main/packages/cli#appsflyerconfig.

Yeah that's right - we're looking for something to fill in the missing gap of install referrer

HI! Did you find a tool for getting install referrer for TWA?


 I can't even play those files with debugging on because it spams the log full with tens of thousands of messages like:
Failed to parse tag: Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Failed to parse tag: Failed to parse tag: Failed to parse tag: Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Failed to parse tag: Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Failed to parse tag: Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.
Failed to parse tag: Exception thrown at 0x00007FFF43C9567C in Client.WinUI.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0000008963CFE2D0.

Here's an example file for testing: subtitle_testing_complex.zip

I think this is solved now.


$urlRouterProvider's when function has redirection problems

$urlRouterProvider has a problem if the incoming path that I want to redirect is empty and there is a state with an url that is also empty.
If I declare something like:
    $urlRouterProvider
        .when('','/staff')
        .otherwise("/error");

and then I declare a named state with an empty "url"...
When calling the webapp in it's root format, http://host:port/webapp

Chrome, ignores the $urlRouterProvider and jumps into the state with the empty url (bug).
IE and Firefox works fine following the rule in the $urlRouterProvider, jumping into the state that has the '/staff' associated url.

The 1) glitch started happening since lib version 0.2.16 and only in Chrome browsers.

Hi, I'm facing the same problem with Chrome. Plunkr here: https://plnkr.co/edit/FrDapa80tndHvyGW6ckt (minimalistic example)
I've set
$urlRouterProvider.when('/main2', '/main2/sub1/subsub1');
$urlRouterProvider.when('/main3', '/main3/sub1/subsub1');.
So clicking on the link "Main 2", it should open automatically its subsub1 view. The same with "Main 3".
When I use version 0.2.16 and 0.2.17 of ui-router it's not redirecting to /main2/sub1/subsub1" in Chrome, but in Firefox and Internet Explorer it does. The automatically redirection to "/main3/sub1/subsub1" works in all three browsers. With ui-router 0.2.15 everything works as expected.

We suspect this may be related to merging in #1585 and the sort order of routes changing.  We plan to revert #1585 and targeting this to be back to normal in 0.2.18.
Sorry for the troubles.

@christopherthielen, @Spessi, @nmrm: I submitted a PR that likely will fix your issue with Chrome.. https://github.com/angular-ui/ui-router/pull/2502
Basically it just ensures a stable sort on Chrome for the sorting that got added in #1585.
I'm also open for reverting the PR that added the sort - but we may be able to keep that sort and not have Chrome issues with my PR.


Usage of deprecated Symfony methods to translate and format

Just installed and tried the example, received this:
PHP Deprecated:  The "Symfony/Component/Translation/Translator::transChoice()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter. in /var/www/html/vendor/symfony/translation/Translator.php on line 229
PHP Deprecated:  The "Symfony/Component/Translation/Formatter/MessageFormatter::choiceFormat()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter. in /var/www/html/vendor/symfony/translation/Formatter/MessageFormatter.php on line 69

Is there any plan to update/fix this?

So this is it? No questions, no answer, just close my issue?

I don't think this is an issue anymore in the latest release. Have you updated already?

@xfudox those deprecations are handled. Carbon 2 supports:
"symfony/translation": "^3.4 || ^4.0 || ^5.0"

%count% is not supported in 3.4 so we're forced to use transChoice() for 3.x and which is the method cross-compatible among versions from 3 to 5. And since 4.2 transChoice is deprecated (you're using Symfony > 4.2 <5 I guess).
And in Symfony 5, it's removed and we use ->trans() when ->transChoise() is not available.
In Carbon 3, we won't support Symfony < 5 anymore.
As you can see the deprecation is perfectly handled. What you should do is migrate to Symfony 5. But if you don't want to. It's fine to stay on Symfony 4 and those deprecation actually are not a problem at all for you, because it's not up to you to handle them.

I insist about this point: deprecations are not errors you should handle in a fast or mandatory way. A deprecated method (if the library owner correctly used deprecation) is still supposed to works as before and as expected. It just tells you: it will no longer exist in the future (a precise version if specified, or else you can assume it disappear on the next major version). Then the deprecation often propose an alternative that would help you to migrate later in an easier way. So you can follow the deprecation advice to anticipate a possible future migration and so be ready already.
But you could still ignore every deprecation and handle them only when you actually upgrade. At this moment, then the doc, changelog or migration guide of the given library would tell you "foobar method is removed", which would no longer trigger a notice but a fatal error. Then it would still not be too late to replace the method according to the migration guide and you would be all fine.


Update ADOPTERS.md

What this PR does / why we need it:
Which issue this PR fixes:

fixes #
Special notes for your reviewer:
Release note:

reopen

reopen

reopen

reopen

the commit is already merge by another pr #2596.
so close this pr.


Preserve original date modified and file name.

Hi
Loving how well this works for merging together chapters, but it is making it a bit harder to manage my gopro files.
Is there any way you could preserve the original modified date on the output file, and preferably initial fine name to (perhaps with a _Joined suffix)?
I use the datestamp to figure out when a specific clip was shot at events.
Here's how to do it with the commandline on Windows.
https://www.winhelponline.com/blog/change-accessed-modified-created-file-date-timestamp-windows/
Secondly, id love for a "batch" convert option, where i can just point it at a folder and it looks for files following Gopros file naming convention.

Wrong project to comment on, yay for having multiple tabs open late at night.


e2e: adjust e2e test to run on kubernetes 1.25

removed podsecurity feature-gate and adjusted e2e tests to use privileged pod security for the e2e namespace
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

This is a replacement for https://github.com/ceph/ceph-csi/pull/3359 to allow running tests on kubernetes 1.25 and will adjust all pod security and pod templates later to not run e2e with privileged access

/retest ci/centos/upgrade-tests-cephfs

@mergifyio rebase

/test ci/centos/mini-e2e/k8s-1.25

/test ci/centos/mini-e2e-helm/k8s-1.25

@nixpanic, we dont have a CI job for 1.25 yet. let me send PR for it.

https://github.com/ceph/ceph-csi/pull/3365 should allow us to run tests on 1.25

/test ci/centos/mini-e2e/k8s-1.25

https://github.com/ceph/ceph-csi/pull/3372 is required as Rook deployment fails on kubernetes 1.25

#3372 is required as Rook deployment fails on kubernetes 1.25

Note that syncing images is done nightly, so the image will be available tomorrow.

@mergifyio rebase

/test ci/centos/mini-e2e/k8s-1.25

/test ci/centos/mini-e2e-helm/k8s-1.25

/test ci/centos/mini-e2e-helm/k8s-1.25

/retest all

/retest ci/centos/mini-e2e/k8s-1.25

ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no<EMAIL_ADDRESS>'podman pull --authfile=~/.podman-auth.json registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0 && podman tag registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0 rook/ceph:v1.10.0 docker.io/rook/ceph:v1.10.0'
Trying to pull registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0...
Error: initializing source docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0: reading manifest v1.10.0 in registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph: manifest unknown: manifest unknown
script returned exit code 125

@nixpanic looks like the images are not pushed to internal registry yet?

@nixpanic looks like the images are not pushed to internal registry yet?

Not sure whats up with this... The CronJob in OCP shows the following images for rook:
going to copy docker://docker.io/rook/ceph:v1.9.8 to docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.9.8
going to copy docker://docker.io/rook/ceph:v1.8.2 to docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.8.2
going to copy docker://docker.io/rook/ceph:v1.6.2 to docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.6.2
going to copy docker://docker.io/rook/ceph:v1.4.9 to docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.4.9

I'll try to find out why v1.10 isn't included there.

Building the images in the OCP environment might have failed, even though the CI shows green:

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/jjb-deploy/detail/jjb-deploy/140/pipeline/10

The OCP Console confirms the image was not rebuilt after #3372:

Building failed, some image is still pulling from docker:

Running a manual rebuild now, hope it works and not Docker Hub rate limit is hit.

Image building inside OCP is somehow stuck, many image builds are still in New or Pending state, since the end of last month.
Now manually copied the Rook v1.10.0 image to the internal CI mirror. Testing can continue!

/test ci/centos/k8s-e2e-external-storage/1.25

@mergifyio rebase

/test ci/centos/k8s-e2e-external-storage/1.25

Seems there is an issue in the block-pool-ec.yaml file:
Error from server (BadRequest): error when creating "./block-pool-ec.yaml": CephBlockPool in version "v1" cannot be handled as a CephBlockPool: strict decoding error: unknown field "spec.annotations"
Mon Sep 26 07:59:53 BST 2022: 'kubectl_retry create -f ./block-pool-ec.yaml' try #0 failed, checking errors

/test ci/centos/k8s-e2e-external-storage/1.25

/test ci/centos/k8s-e2e-external-storage/1.25

/test ci/centos/k8s-e2e-external-storage/1.25

@mergifyio rebase

/retest all

/retest all

retesting all as all tests failed to reserve machines

/retest all

Note that the project can "only" run 10 jobs in the CentOS CI at the same time. Additional jobs will get queued for a while, but they will time out at one point if no VMs become available. It is more efficient to request Mergify to rebase once an other PR is merged. Or, run a single job for testing.

/test ci/centos/mini-e2e-helm/k8s-1.25

/test ci/centos/mini-e2e-helm/k8s-1.25

/test ci/centos/mini-e2e-helm/k8s-1.24

1.25 CI is passing this is ready for review.

@mergifyio refresh

GitHub branch protection (required for securing repositories) makes the ready-to-merge label useless. At least 2 approvals are needed because of it.

@mergifyio rebase

/test ci/centos/upgrade-tests

@mergifyio rebase

@mergifyio rebase

@Mergifyio refresh


Virtual Slide Component

I am wondering how to use a component in virtual slide because the array
virtual: {
slides: ['Slide 1', 'Slide 2', 'Slide 3', 'Slide 4', 'Slide 5'],
}, only accepts  html no vue componets

Yes, if you need components to render virtual slides, I think this business segment may not be reasonable.

@surmon-china May I ask why? I'm doing somthing sorta quiz test. I want to load quiz component into every virtual slider component,is that possible?or reasonable?

This answer is supposed to do what you and I want but I can't seem to get it working.
https://stackoverflow.com/questions/51359121/how-can-i-insert-vue-component-into-virtual-slides
I've also created a codesandbox to show the problem: https://codesandbox.io/s/x28kxkxvnq

The virtual slideshow does not support vertical, which is a bit regretful


I can't get this to work on a Nuxt project

For some reason, it keeps throwing a 500 module not found error -

<template>
  <div class="relative">
    <UButton
      label="Add Icon"
      color="neutral"
      variant="soft"
      icon="i-lucide-smile-plus"
      size="sm"
      @click="isOpen = !isOpen"
    />
    <VuemojiPicker
      v-if="isOpen"
      :picker-style="pickerStyle"
      @emoji-click="handleEmojiClick"
      class="absolute top-full mt-2 z-50"
    />
  </div>
</template>

<script lang="ts" setup>
import { VuemojiPicker, type EmojiClickEventDetail } from 'vuemoji-picker'

const isOpen = ref(false)

const pickerStyle = {
  width: '320px',
  height: '400px'
}

const handleEmojiClick = (detail: EmojiClickEventDetail) => {
  console.log(detail)
  isOpen.value = false // Close picker after selection
}
</script>

I even added a vite resolver for the module
vite: {
    resolve: {
      alias: {
        'emoji-picker-element/picker': 'emoji-picker-element/picker.js'
      }
    }
  }

Am I doing something wrong? @wobsoriano

Hey! Can you try and wrap <VuemojiPicker /> in a <ClientOnly> component?


ISPN-12096 ConfigurationBuilder::withProperties should not overwrite …

…the transactionMode
https://issues.redhat.com/browse/ISPN-12096

Thanks @pruivo


Add a Python-based .gitignore definition

Adding a Python one given that the main logic of the repo (which is
tested on GitHub Actions) is Python-based.
From https://github.com/github/gitignore/blob/main/Python.gitignore
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Thanks here too!


program functions to derive TRTSDTM and TRTEDTM (1d)

This is strange - I think we just closed this one out.  Maybe there was multiple ones of this??  Okay to close again !?  :)

Looks like a duplicate indeed. Closing.


Support tools view regeneration on a PR level for manual tools

Context
This page: https://www.asyncapi.com/tools
Gets regenerated once a week (or anytime by manual trigger) thanks to https://github.com/asyncapi/website/blob/master/.github/workflows/regenerate-tools.yml
Basically this script is called: https://github.com/asyncapi/website/blob/master/scripts/build-tools.js
More info about entire solution you can find in: https://github.com/asyncapi/community/blob/master/new-tool-documentation.md
Problem/Limitation
So people can add tools also manually to the website, through a PR: https://github.com/asyncapi/website/pull/2114
But problem is, that tools (as mentioned above) are not refreshed during website build, which means preview on PR level do not reflect PR changes.

So basically review is harder
After merge reviewer needs to remember to call rebuild workflow manually

No-go solution
Solution is not to rebuild tools, with the same script that we have now, on build level. We use logs of GH API there and do not want to run out of credits too soon

Hi @derberg, I would like to work on this issue. Can you please assign this to me.

please go ahead  @Arbtrage

@Arbtrage any updates?

Hey @akshatnema , I am still searching for a solution for this issue. Can you guide me on some approaches ?

Hey @derberg and @akshatnema,
I would like to work on this. The solution I am considering involves having two workflows: automatic and manual.
The manual workflow can be used to preview the PR. This workflow can be triggered by a comment from the code owner.
The automatic workflow will be invoked when a PR is merged. If there are changes in the ansycapi-tools section, then only will this automatic workflow be triggered.
What are your views on this?

The automatic workflow will be invoked when a PR is merged. If there are changes in the ansycapi-tools section, then only will this automatic workflow be triggered.

We already have automatic workflow to update the tools every Monday. We only want to check for manual tools and update the manual tools of there is any changes in the file.

Hey @derberg and @akshatnema,
For the PR preview workflow, the approach I'm considering is to:

have a workflow, which will be run by the maintainer.
This workflow will generate the manual tools section. If there are changes, it will create a new PR. This new PR will target the contributor's PR. In this way, the changes in the tools section will directly be pushed to the contributor's PR, allowing us to preview changes at the PR level.

What are your thoughts on this? Am I on the right track? If not, could you please guide me further?

Yeah @derberg, that's what I think of to have a separate file to check for manual tools and run that file only for each PR checks. We can do that using node scripts/tools/check-tools.js, some what like this.


Fix spelling

Change occured to occurred
Description

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2707

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3441)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31592 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6041-t3441-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Address Form/Type

There is no "address" type for inputs within the Address form sections. The "address" types can be changed to "text".
DS: http://jdrf.github.io/design-system/dist/components.html#forms
HTML Reference: http://html5doctor.com/html5-forms-input-types/

@RachelRVasquez CR Approved and merged.

@pmmck This is ready for your review.

@fuhton what specifically am I looking for here?

@pmmck Didn't realize this was an internal tweak. We've modified an input type in the github page.


Configure parsys placeholder text and drop zone background colors

@justinedelson @davidjgonzalez - feature to configure parsys

Set one or more of the following properties manually in CRX eg. /etc/designs/geometrixx/jcr:content/contentpage/rightpar

Classic UI

Touch UI

looks good to me

LGTM too -- just an observation (maybe for can address at a later date) but this only works for the OOTB resource parsys/iparsys right? If i were to overlay the OOTB parsys it would be eligible for coloring/updating.

It seems 'acsParsysPlaceholderText' has some issues for container components.
For example: i created container component that has one parsys. i added 'acsParsysPlaceholderText' in etc/design for that container parsys.
place holder text for container parsys is visible only on mouse over of container parsys.
Could any one facing the same issue or any solutions ?
Thanks.

Any chance you can package up the page and design and attach? Makes troubleshooting a bit easier.

Hi David,
Thanks for your reply, please find the attached package which have sample container components, page and design of that page.
Steps to reproduce:

Install the given package.
Hit the given URL http://localhost:4506/editor.html/content/geometrixx/en.html
I already added container components and designs(Please check etc-designs.PNG screenshot).
Expected results container placeholder should change. But its not(Please see content-page.PNG screenshot)

Please let me know if am doing anything wrong.
Thanks & Regards.

Sample-Placeholder-Test.zip

Hi @davidjgonzalez ,
Could you get a chance to look on to this issue?
Regards,
S Harish.


FNA games so far not tested (feel free to help out)

Anyone who wants to help with fnaify development can help by testing the games on this list and reporting here or to me in PM/email if they work:

Blueberry Garden
CometStriker
CraftStudio
Dead Pixels 2
Full Metal Furies (uses FMOD)
Hive
Hybrid Beasts
Interloper
Khet 2.0
Quadrilateral Cowboy (Art Book)
Reversi
Simply Chess
Solaroids: Prologue
Tatsu
Timespinner
Tooth and Tail (uses FMOD)
We Are Legion

(source: http://www.flibitijibibo.com/index.php?page=Portfolio/Tools)

The following ones work:

Blueberry Garden
CometStriker
Hive
Solaroids: Prologue (but only Trial because of Steam DRM)
Timespinner

The following ones don't work:

Dead Pixels 2 (still in Early Access)
Full Metal Furies (FMOD)
Hive (graphics don't render correctly)
Tooth and Tail (FMOD)

Rest to remain on the list...

CometStriker works. Dead Pixels currently doesn't work (see https://github.com/rfht/fnaify/issues/30)


Introduce a Proper Mapping From VertexDeclaration to Shader Vertex Attributes

Summary
Right now, vertex elements are mapped to shader vertex attributes based on a small set of pre-defined roles and using type matching as a fallback. This is not sufficient for custom vertex types that include multiple fields without a predefined role. As a prerequisite of issues #219 and #220, a better way of mapping vertex format fields to shader vertex attributes will be required.
Analysis

Without the fixed function pipeline, shaders need to be able to declare a role for each vertex attribute.

This is non-standard, GLSL doesn't support this. Introduce this as a pre-processing step.
Parse vertex attribute roles using the same enum that is used on the engine side.
Use C# attribute notation?

[VertexElementRole(Position)] attribute vec3 vertexWorldPos;
Quite verbose. Doesn't fit in well.

Use more GLSL-like notation? `

@position attribute vec3 vertexWorldPos;
attribute vec3 vertexWorldPos : position;
Looks a lot better.

The current set of vertex element roles is very narrow. Extend this.

Introduce a bigger set of roles to choose from.
Don't do hardcoded numbering like Position0, Position1.

If no role is set, or multiple vertex attributes match the same role, perform name-based comparison to select the best match.

In the same vein, also think about how to express additional reflection metadata for both attributes and uniforms. Example use case: Make color uniforms actually show up as colors in the material editor, rather than Vector4 fields.

The mapping issue has been largely resolved over the course of #219 using a VertexFoo naming convention for vertex attributes, which automatically map to the used vertex declarations Foo field.
What remains is the open question of providing a way to define shader variable metadata, like high level types to be used when editing materials.

Done.


Filter by entity with NOT_EQUAL fails with composite key

This is just documentation for myself since Propel1 is not being actively supported.
When filtering by a foreign entity, and using Criteria::NOT_EQUAL, the resulting query contains:
... AND entity.a <> 'valuea' AND entity.b <> 'valueb' ...
where instead it should have
... AND NOT(entity.a = 'valuea' AND entity.b = 'valueb') ...

Found in 1.6.7


How should context be combined with a transaction?

Your Question

How should WithContext be combined with Transaction? I'm particularly thinking about reacting to a cancelation.
3 options I can see:

Use it for both. My guess is this does nothing over (2)

func Do(ctx context.Context, db *gorm.DB) error {
  return db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
    for i := 0; i < 5; i++ {
      if err := tx.WithContext(ctx).Query(...).Error; err != nil {
        return err
      }
    }
  }
}

Use it at the top-level before initiating the transaction, but not within the tx. I'm guessing the context trickles down so this would be the way to do it?

func Do(ctx context.Context, db *gorm.DB) error {
  return db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
    for i := 0; i < 5; i++ {
      if err := tx.Query(...).Error; err != nil {
        return err
      }
    }
  }
}

Skip it at the top-level and use it in each transaction sub-query. If my above guess is correct, then I think this accomplishes the same thing as (2), while requiring more effort at runtime.

func Do(ctx context.Context, db *gorm.DB) error {
  return db.Transaction(func(tx *gorm.DB) error {
    for i := 0; i < 5; i++ {
      if err := tx.WithContext(ctx).Query(...).Error; err != nil {
        return err
      }
    }
  }
}

The document you expected this should be explained
Transactions and maybe Context

Expected answer
A recommendation as to which style is the most appropriate with dealing with contexts, particularly for responding to cancelations. If there's a reason to use one over the other, pro/con would be handy.

That's what I thought, but I appreciate the confirmation. Thank you!


Uncaught SyntaxError: Unexpected token '<' at main.js

Environment
nuxt3 project with unocss
Reproduction
I don't know how to reproduce this error.
Describe the bug
Hello!
I'm facing this kind error in Console Dev Tool panel.
My project is Nuxt3. I can not fix this issue.
Please help me out.

Hope you will not ignore my problem.
Thank you in advance.
Additional context
No response
Logs
No response

I doubt this is coming from Nuxt. Probably something is adding a Js script tag with main.js, but because this doesn't exist in your project it's just getting an HTML page as a response.


Revert "Redirect data.gov.uk to www.data.gov.uk"

Reverts alphagov/govuk-aws#1611

Is this still needed @kentsanggds ?

No longer needed


Make disk available on tutorial vagrant images larger

Currently image is 9GB and it's very easy to run out of space, which tends to break everything going forward. Increasing available size won't increase download time so there's no real cost.

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-392. You are welcome to file additional issues in GitHub if that's easier for you.


ScanCode: Fix passing the raw scan result

This is a fixup for 6dba67c that enables caching of scan results again.

This change is

AppVeyor failed due to an unrelated TestTimedOutException. Still merging as Travis succeeded.


Remove Unused variable init and unused method In AdminResource Since 2018

Modifications
Remove Unused variable init and unused method In AdminResource Since 2018.
And I think the getNamespacePolicies is a bit hot path.
Documentation
Need to update docs?


Update README.md (add requirement)

Unfortunately i was use 5.1.4.
This version not included csp_meta_tag. Therefore i did check which version included.
I found 5.2.0 is included csp_meta_tag and did try work or not.
https://api.rubyonrails.org/v5.2.0/classes/ActionView/Helpers/CspHelper.html#method-i-csp_meta_tag
FYI. if you try install rails 5.2.0 then install 5.2.3

@hiphapis Thanks for your check. I will support for ~> 5.0 in the next version.


August integration can't authenticate

Home Assistant release with the issue:
0.101.3

Last working Home Assistant release (if known):
0.98.x
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io on Ubuntu

Integration:
https://www.home-assistant.io/integrations/august/

Description of problem:
Integration fails to authenticate with: 401 Client Error: Unauthorized for url: https://api-production.august.com/users/doorbells/mine
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
august:
  login_method: phone
  username: "+10000000000"
  password: MyPassword

Traceback (if applicable):
2019-11-17 07:53:32 ERROR (MainThread) [homeassistant.setup] Error during setup of component august
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/setup.py", line 176, in _async_setup_component
    component.setup, hass, processed_config  # type: ignore
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/august/__init__.py", line 170, in setup
    return setup_august(hass, config, api, authenticator)
  File "/usr/src/homeassistant/homeassistant/components/august/__init__.py", line 119, in setup_august
    hass.data[DATA_AUGUST] = AugustData(hass, api, authentication.access_token)
  File "/usr/src/homeassistant/homeassistant/components/august/__init__.py", line 181, in __init__
    self._doorbells = self._api.get_doorbells(self._access_token) or []
  File "/usr/local/lib/python3.7/site-packages/august/api.py", line 146, in get_doorbells
    access_token=access_token).json()
  File "/usr/local/lib/python3.7/site-packages/august/api.py", line 296, in _call_api
    response.raise_for_status()
  File "/usr/local/lib/python3.7/site-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api-production.august.com/users/doorbells/mine

Additional information:
I don't think anything changed on HA side, I believe they changed their APIs, maybe. I think this problem just suddenly started happening, not after an upgrade.

have you tried deleting your august token.
https://github.com/home-assistant/home-assistant/issues/19286#issuecomment-447569524

have you tried deleting your august token.
#19286 (comment)

I didn't know that was a thing. So I did and all is well. I did notice that in the august.conf file it said this:
"access_token_expires": "2019-11-16T21:15:01.846Z"
It would be nice if the notification in HA said it had expired instead of nothing.
But thank you!


CAS Login change from BI Portal to DataND

CAS Login page display - Login to BI Portal on all environments
Dev  - BI Portal Dev
Test - BI Portal Test
Prod - BI Portal

This is done. Worked with Infosec on 11/15/16. Fixed.


Game Crashes

#300 My game crashes before launching the game, i try it even with only Industrial evolution mod but it still crashed.

hasnt been updated to use the latest fabric API, I'm using 0.37.1, not 0.38.2

Duplicate of #301


Add kata-acrn to the runtimes pre-configured for Docker

Which feature do you think can be improved?
kata-deploy-docker configures Docker with a number of runtimes, 4 in total. ACRN is not in the list at the moment.
How can it be improved?
We can add a kata-acrn runtime to Docker's /etc/docker/daemon.json file. The toml file is already installed by default.
Additional Information
No

Closing this issue since the problem is fixed however the PR in 1.x was pointed to the wrong issue.

#1077


[Bug]: Mods in BTD6 is now working

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
I was trying to install mods in bloons td 6 because my file of "Save" never saved because my game is pirated so I tried to use mods to improve the game and put logo level maximum and infinite money since it lost everything. But when I went to install the melon loader it just didn't start the mods.
Latest.log
Orthers log:
MelonLoader_23-02-07_15-28-41.945.log
MelonLoader_23-02-07_15-33-22.319.log
Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Pirated game, no support


Error Running scripts/amazon_clothing_20k/eval_rank.sh : Leaf Variable in In-Place Operation

I encountered an issue while running the eval_rank.sh script in the amazon_clothing_20k directory. The error occurs when executing the Python script as part of the evaluation process. Here is the detailed traceback:
Traceback (most recent call last):
  File "/home/wlhuang/llm/LinkGPT/linkgpt/eval/eval_yn.py", line 311, in <module>
    main()
  File "/home/wlhuang/llm/LinkGPT/linkgpt/eval/eval_yn.py", line 131, in main
    model, tokenizer = load_model_and_tokenizer(
  File "/home/wlhuang/llm/LinkGPT/linkgpt/model/linkgpt_model.py", line 479, in load_model_and_tokenizer
    ft_model.base_model.model.model.embed_tokens.weight[linkgpt_special_token_id_ls] = linkgpt_special_token_emb
RuntimeError: a leaf Variable that requires grad is being used in an in-place operation.

It seems like the issue is related to an in-place assignment on a leaf variable that requires gradients, which is causing the error. I have tried wrapping the assignment in torch.no_grad() to prevent the calculation graph from being modified, but I would like to know if there is a more appropriate solution for this particular scenario.
Environment details:
Python version: 3.9

PyTorch version: 1.13.1

CUDA version: 11.7

Transformers library version: 4.41.2

DGL version: 2.0.0+cu116

Could you please provide guidance on how to properly address this error? Any help would be much appreciated.

Thank you very much for raising this issue! I encountered the same problem during my testing. I suspect the reason I didn’t encounter this issue earlier might be due to some version discrepancies in the libraries. I’m not sure if there’s a more elegant solution, so I resolved it using the torch.no_grad() method as you suggested. The code in LinkGPT/linkgpt/model/linkgpt_model.py has been updated accordingly.


fix: console dev url

{
  "devServer": {
    "host": "m.taobao.com"
  }
}

修复配置了 devServer host 后，命令行依旧打印 ip 地址作为调试链接的问题

Codecov Report

Merging #742 (f9db155) into release-next (7d10c1e) will increase coverage by 0.05%.
The diff coverage is 80.55%.

@@               Coverage Diff                @@
##           release-next     #742      +/-   ##
================================================
+ Coverage         46.36%   46.42%   +0.05%
================================================
  Files                52       52
  Lines              1320     1314       -6
  Branches            272      271       -1
================================================
- Hits                612      610       -2
+ Misses              708      704       -4

Impacted Files
Coverage Δ

packages/platform-loader/src/TraverseImport.js
88.23% <ø> (ø)

packages/plugin-rax-pha/src/manifestHelpers.js
0.00% <0.00%> (ø)

packages/plugin-rax-app/src/base.js
91.89% <62.50%> (-8.11%)
:arrow_down:

packages/plugin-rax-app/src/constants.js
100.00% <100.00%> (ø)

packages/plugin-rax-app/src/index.js
96.96% <100.00%> (+0.19%)
:arrow_up:

packages/plugin-rax-app/src/setBuild.js
100.00% <100.00%> (+6.81%)
:arrow_up:

packages/plugin-rax-app/src/setDev.js
84.45% <100.00%> (+1.95%)
:arrow_up:

packages/plugin-rax-miniapp/src/index.js
58.82% <100.00%> (+0.61%)
:arrow_up:

packages/rax-babel-config/src/index.js
90.47% <100.00%> (ø)


!pypi should include publish date in response

In many cases, users have been utilizing out of date packages. This would make the !pypi tag substantially more useful in visually parsing whether or not a package could be out of date for the current version of Python.
https://github.com/python-discord/bot/blob/main/bot/exts/info/pypi.py#L48-L67
Example snippet:
ver = info["version"]
releasedate = info["release"][ver]["0"]["upload_time"]
embed.description += f"\n Release Date {releasedate}"

Should fall within the if 200 response block. May want to consider prettying up the timestamp a bit to just the date portion.

I would be willing to work on this if approved.

This would be a nice addition, thanks for proposing it.
However, aren't we always getting the latest version for each package? So how would it be out of date?
The pypi command takes no arguments and is agnostic to python/package versions.
I'm not saying this shouldn't be added as it would only be a nice addition, but more like to make sure I understand correctly.

We always obtain the latest (non-dev release) version of a package with the !pypi command as I understand it now. Supplying a date in the embed serves to simply reconcile this date against our current understanding of what is considered 'outdated'.
A recent example of when this was relevant: An individual was seeking assistance with a "Jarvis" package on PyPI, specifically implementing it within their own code. !pypi was invoked to retrieve information regarding the package, and further links had to be followed to discern whether or not the package's latest version was out of date or not. In this case, the package had not been updated in the last decade. Since this information is available on the JSON endpoint, it seems fairly straightforward to me to suggest the inclusion of it in the embed response itself.
Realistically, it only really serves to save a couple of clicks/following a URL in this case, but I can see it being a reasonable metadata inclusion just for quick referencing.

I wasn't opposing you as I think it is indeed reasonable to include.
@Robin5605 Want me to assign you?

Sure, thanks.


grid push/pull not working properly in 0.97.3 - 0.97.5

Our site needs to support Arabic languages so we use the grid pull/push feature to change our layout by language.
For example:   however, it works fine in 0.97.2 but not in later versions, I hit a similar problem with offset ( #2328 ) which has been fixed in 0.97.4. Can't find any duplicate issue, but I saw some grid pull/push has been added to 0.97.3, and it might be related.
Thanks
Nicole
// our HTML code

            <input ng-class="properties.rightToLeft ? 'right-align':'left-align'" type="text" id="username" name="username" class="validate" ng-model="credentials.username" placeholder="{{properties.username}}" lowercase required>

Username is required.

Hello!
New message, please read http://scannerlab.com/typical.php?y82c
<EMAIL_ADDRESS>

Can you post a codepen that uses the latest version? Anyhow, I will close this issue for now


wrong sitemap for 404.html

Another sitemap issue:
the 404.html appears as <loc>https://tlienart.github.io/FranklinTemplates.jl/404/index.html</loc>.
I think this is because the file is special cased in form_output_path
https://github.com/tlienart/Franklin.jl/blob/caa1518240ccff7f629d077d72eb65a09515b64f/src/manager/dir_utils.jl#L29-L45
and the sitemap generator does not know about this.
I think the most elegant way to handle this would probably be to add the file to keep_path instead of the current special handling. But that would be a breaking change.

Actually the issue still persists for 404.md pages (as in some of the templates).
Do you think your fix can be adapted to handle those as well?


Please add my website silviofanzon.com

Please add my website. I changed one line in the README.md

Commiting to the wrong repo

Where should I commit? Thank you
On 1 May 2023 at 16:52 +0100, George @.***>, wrote:

Closed #1385.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

You should not send all of your changes as a PR for this template repo.
In this PR you sent more than 700 commits.