Scoping: Better Actions protocol implementation

Current approach is far from ideal. State and arguments are passed in SSE query, response must to be base64 encoded to avoid newlines issue (which increases the size of the response).
Websockets cannot be considered:

They don't scale well (in case of keeping connection alive all the time)
Sometimes it requires special configuration of networking, especially on big projects
In some countries/hotels/public places you can see ports/protocols whitelisting, which immediately kills this approach

It's possible to use "chunked" transfer encoding to deliver multiple UI updates.
Example go server:
package main

import (
	"compress/gzip"
	"net/http"
	"time"
)

func main() {
	http.HandleFunc("/", func(rw http.ResponseWriter, r *http.Request) {
		rw.Header().Set("Content-Type", "application/octet-stream")
		rw.Header().Set("Content-Encoding", "gzip")
		rw.Header().Set("Transfer-Encoding", "chunked")
		rw.Header().Set("Access-Control-Allow-Origin", "*")

		writer := gzip.NewWriter(rw)

		writer.Write([]byte("Hello, World 1"))
		writer.Flush()
		rw.(http.Flusher).Flush()
		time.Sleep(time.Second)
		writer.Write([]byte("Hello, World 2"))
		writer.Flush()
		rw.(http.Flusher).Flush()
		time.Sleep(time.Second)
		writer.Write([]byte("Hello, World 3"))
		writer.Flush()
		rw.(http.Flusher).Flush()
		time.Sleep(time.Second)
		writer.Write([]byte("Hello, World 4"))
		writer.Flush()
		rw.(http.Flusher).Flush()
	})

	http.ListenAndServe("localhost:8080", nil)
}

Example JS client:
const response = await fetch('http://localhost:8080');
const reader = response.body.pipeThrough(new TextDecoderStream()).getReader();

while (true) {
    const { value, done } = await reader.read();
    if (done) {
        break
    }
    console.log(value)
}

console.log('end')

Marking as a good first issue.
if someone is ready to take, just contact me directly for more information on that.

Better to do that without gzip encoding on handler side, leave it to middlewares.


Add feature to ActiveSessions that will use a private temporary directory to create all files and move into /var/run/geopm-service after fully created

estimate 2

[x] Make sure permissions are least required privilege before moving them

[x] Test that they parse to the same values written

[ ] Make sure temporary directory is created as part of systemd:

In geopm-service config file add text below and follow instructions in linuxjournal article

#  Sandboxing features
PrivateTmp=yes

This is really about writing everything into /tmp, which seems to not be the proper approach.
This should probably be closed as will-not-fix.

Instead we are creating temporary files in /var/run/geopm-service, this issue can be considered to track this feature.


Token first pass

Sets up foundry, implements token, and tests functions. Could use some more tests to ensure edge cases covered. Currently only fuzz test on mint.

Also, deploy script is not set up.


Add missing tags to []conditions which got reported by crd checker

Adds tags which to resolve the condition failures reported by the crd checker recently added as a pre-commit validation.
In a follow up, we should integrate the new ObservedGeneration for a condition [1]. The observedGeneration represents the .metadata.generation that the condition was set based upon.
[1] https://github.com/kubernetes/apimachinery/blob/release-1.29/pkg/apis/meta/v1/types.go#L1518

I think some of these validations will go into the CRD yamls thus increasing the size. want to be sure we are actually getting value out of these vs. just making a tool like crd-schema-checker happy


Unclosed session

After last update sessions aren't closed on exit.
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x0000020C195185F8>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x0000020C182A74E0>, 2362379.765)]']
connector: <aiohttp.connector.TCPConnector object at 0x0000020C19518630>

It is because in new version driver.close method isn't called anymore in close method of BaseSession.

fixed


Open new window when launching iTerm

I encountered the same issue described in #41, #42, and #43. The script in #41 works, but this update to the current script works, as well.
If iTerm isn't running, it activates it, then opens a new window.

A single delay won’t work for everyone. One 0.01 may have worked for you, but may not work on slower machines.
What are you trying to accomplish? Your code will open two windows, as explained in the comment.

A single delay won’t work for everyone. One 0.01 may have worked for you, but may not work on slower machines.

I borrowed that from the other delay used in the script. There might be a better time, but I'm not sure how to determine that.

What are you trying to accomplish?

I'm trying to get it to run a command when iTerm isn't running. It's the same symptoms encountered  in the linked issues above.

Your code will open two windows, as explained in the comment.

Except it won't. The only change I've seen is that it opens one window with the command vs. no windows without this change.
I've made a couple screencasts to show what's happening with and without the update.
Here's the workflow I'm using to test this.
I'm running on:

MacOS Big Sure 11.5.1 (20G80)
iTerm2 Build 3.4.8
Alfred 4.5 Build 1253

With latest release version of custom-alfred-iterm-scripts

iTerm active
iTerm not active

With this PR's modifications

iTerm active
iTerm not active

With my configuration, the only change is that it works when iTerm isn't already active. Everything else is unaffected.

I borrowed that from the other delay used in the script.

That delay is on a conditional loop, so it may be shorter or longer. It’s unlikely you need the extra window, probably just the time. Try this one instead. Does it work for you? (I can’t reproduce your issue)
-- For the latest version:
-- https://github.com/vitorgalvao/custom-alfred-iterm-scripts

-- Set this property to true to always open in a new window
property open_in_new_window : false

-- Increase this value (default: 0.0) if starting without windows does not send your command
property extra_delay_no_windows : 1.0

-- Handlers
on new_window()
	tell application "iTerm" to create window with default profile
end new_window

on new_tab()
	tell application "iTerm" to tell the first window to create tab with default profile
end new_tab

on call_forward()
	tell application "iTerm" to activate
end call_forward

on is_running()
	application "iTerm" is running
end is_running

on has_windows()
	if not is_running() then return false
	if windows of application "iTerm" is {} then return false
	true
end has_windows

on send_text(custom_text)
	tell application "iTerm" to tell the first window to tell current session to write text custom_text
end send_text

-- Main
on alfred_script(query)
	if has_windows() then
		if open_in_new_window then
			new_window()
		else
			new_tab()
		end if
	else
		-- If iTerm is not running and we tell it to create a new window, we get two
		-- One from opening the application, and the other from the command
		if is_running() then
			new_window()
		else
			call_forward()
			delay extra_delay_no_windows
		end if
	end if

	-- Make sure a window exists before we continue, or the write may fail
	repeat until has_windows()
		delay 0.01
	end repeat

	send_text(query)
	call_forward()
end alfred_script

Note the property extra_delay_no_windows : 1.0 near the top. Play with the value.

Closing for lack of reply.


Fold the validator roots into the state tree

ref: lazyledger/lazyledger-core#66
ref: lazyledger/cosmos-sdk#7

ref:

https://github.com/celestiaorg/optimint/issues/206
https://github.com/celestiaorg/optimint/issues/207
https://github.com/celestiaorg/optimint/issues/205

Test

Since rollkit supports centralized sequencers currently, this is not relevant


Bump IS7 KM Version to 2.0.1 and Charon3 version to 4.0.19

Purpose
$Subject. Fixes https://github.com/wso2/api-manager/issues/2693

Done via https://github.com/wso2/product-apim/pull/13454


add a keep option

add a parameter --keep to specify fasta(s)
start another mapping run against the keep fastas
keep reads that mapped against host/control/contamination AND aginst the keep fastas

What do you think, @hoelzer ?

In general yes!
But I suggest to map simultaneously against the contamination AND a reference-to-keep if provided. And then always keep reads in the clean bin that mapped against the reference-to-keep. What mapped against contamination is sorted out into the contamination bin.
And unmapped... Unmapped is then also going in the clean bin,right? Just to not lose smt maybe important.
That would be my approach, or do I miss smt?

So you'd concatenate everything, contamination(s) and the reference-to-keep?
Currently, we run minimap2 with -N5 and --secondary=no: search for at most 5 secondary alignments (default) and output no secondary alignment. What if the 6th secondary alignment maps to the reference-to-keep? If we map twice we still can follow the strategy to discriminate between mapped and unmapped reads, independent of the mapping location (e.g. when contamination 1, contamination 2 and control)

Yes, normally I would concatenate everything. The thing is the following scenario:

you have a virus that you want to decontaminate
a similar sequence is also integrated into the human genome (EVE)
you want to keep reads that are human, and remove reads belonging to the virus

Now you map two times like you suggested:

you get reads mapped to the virus (contamination, you want to sort them out)
you also get reads mapped to the human genome that you want to keep

among them, some of the virus reads are mapping to that EVE, with lower quality, but still they map

Now you keep these reads bc/ they map against your human--keep FASTA. But actually, they belong to your contamination (the virus).
If you would concatenate the human (keep) and virus (contamination) FASTAs then the reads should not map to the human EVE part bc/ they have a better quality when mapping to the virus. At least that's how it should work : )
I think in your approach (mapping multiple times) you would need to take also the mapping quality into account. E.g. if a read A mapped against the human genome (keep) and the virus (contamination) you would still reject that read if the mapping quality against the virus is better.

Now you keep these reads bc/ they map against your human--keep FASTA. But actually, they belong to your contamination (the virus).
If you would concatenate the human (keep) and virus (contamination) FASTAs then the reads should not map to the human EVE part bc/ they have a better quality when mapping to the virus. At least that's how it should work : )

I see your point. But if the similarity is so high that you can't tell from where the read originates, it's up to the mapper, the order of the references and/or some mapper-specific assumptions where the primary alignment ends up. So you could filter out human reads that could also be virus reads more or less by chance, or?
When mapping twice we could select e.g. the longer alignment and decide to keep it if has the same length.

Yes, you're totally right. It's still not sure where the read then ends up based on the mapper, prameters, ...
Yes, mapping two times would then just need some further decision step (e.g. on aln length) to decide what happens w/ reads that map against both the (optional) reference-to-keep and then contamination(s).
(btw, I think this is really an important thing to include and might come up anyway in a revision. Which also means we could keep it in mind/implement basically but then focus on getting the manuscript into review while finalizing : ) )

closed with #81


README: Add Debian/Ubuntu compilation instructions

I had to install the following to get rid of most warnings when running ./configure.
I guess build-essential package was also required.

Thanks, appreciated! However, I thought about it and I'm going to pass on this one.
It's a slippery slope: first we add this and then the next gazillion of distros want their own unique instructions too (and be justified in the ask by this precedent).
On a slightly philosophical note, compiling from sources is never a trivial endeavor and it requires some minimal competence in dealing with issues that may show up; knowing basics about one's distro like how to install its compiler or how it handles dev packages is arguably part of that. In that regard, a little bit of friction is arguably good — it makes the person who wishes to compile from sources at least google "how to compile from sources on $DISTRO" and be better equipped to interpret results on their own.


Dash manufacture spc dashboard

Issue for app: #58
App pull request

[x] This is a new app
[ ] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-manufacture-spc-dashboard/

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[x] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] If the app is a reimplementation of a Python gallery app for the
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

Also closes https://github.com/plotly/dash-sample-apps/issues/212

Desktop

Mobile

I also just noticed that some of your border colours in between the containers don't match your outermost background colour. So perhaps replace all instances of #23262E with #1E2130.

Thumbnail on dash-gallery updated ✅


Suspiciously long compile time when using traits

I have code like this:
use ashpd::desktop::file_chooser::SaveFileRequest;
use std::future::Future;

struct SomeStruct;

pub trait SomeTrait {
    fn some_method(self) -> Box<dyn Future<Output = ()>>;
}

impl SomeTrait for SomeStruct {
    fn some_method(self) -> Box<dyn Future<Output = ()>> {
        Box::new(async move {
            SaveFileRequest::default().send().await.ok();
        })
    }
}

For no apparent reason, it takes 96s to compile in release mode.
This is the case only when trait is used, and .await is actually called.
This bug report would most likely be better fitted in rustc, but perhaps you have some ideas, so I'm reporting here.
rustc 1.72.0
cargo_timings.zip
related: https://github.com/PolyMeilex/rfd/issues/126

Heh. I have no idea at all what is causing this, the library is also used in various GTK apps and haven't heard of any complaints about this very long compile time until now. I don't think we do anything suspicious in ashpd that would make compile time this slow. I would say a rustc bug report would be more actionable

If you end up opening a bug against rustc, please share the link here so i can ask people around and see if someone familiar with rustc could have a look at it

Apparently, this is https://github.com/rust-lang/rust/issues/115297. Do you mind testing with 1.71?

Yep, it seems plausible, it works in 1.71

Let us close this one then.


Task/strip stake address prefix

Problems

The anvil backend always returns stake keys without the e1 or e0 prefix but the wallet extensions return them with the prefix. Solution: I added a stakeAddressHexPrefixed to the wallet store.
The previous implementation of the hexToBech32 function used the starting characters of the hex value to determine if a prefix had to be appended which is wrong because some stake addresses actually start with e0 or e1. For example, this is a valid and existing stake address in hex format without any prefix: e09fd385ca1eb59f37c18f1e6b70d21cb4c4d7fd31eafd42ac90118f. Solution: Use the length of the hex value to determine if a prefix is present or not instead of the starting characters.

I implemented the first approach you suggested: the store always returns prefixed addresses and I exposed a stripAddressPrefix util to facilitate conversion.
As we discussed, I also removed the code that made sure a prefix was always set on hex stake addresses since it was only a patch to handle inconsistent return values returned by internal anvil backend logic.


dashboard: update version and add test (#2115) (#2131)

What problem does this PR solve?
cherry-pick #2115 #2131
What is changed and how it works?
Check List
Tests

Unit test

/run-all-tests

Codecov Report

Merging #2132 into release-3.1 will decrease coverage by 0.09%.
The diff coverage is 54.54%.

@@              Coverage Diff               @@
##           release-3.1    #2132     +/-   ##
==============================================
- Coverage        74.91%   74.82%   -0.1%
==============================================
  Files              192      194      +2
  Lines            19891    19982     +91
==============================================
+ Hits             14901    14951     +50
- Misses            3851     3890     +39
- Partials          1139     1141      +2

Impacted Files
Coverage Δ

pkg/dashboard/keyvisual/input/core.go
1.96% <1.96%> (ø)

tests/cluster.go
85.65% <100%> (-0.06%)
:arrow_down:

server/api/server.go
100% <100%> (ø)
:arrow_up:

pkg/apiutil/serverapi/middleware.go
73.03% <100%> (ø)
:arrow_up:

pkg/dashboard/uiserver/uiserver.go
60% <66.66%> (+60%)
:arrow_up:

pkg/dashboard/apiserver/apiserver.go
81.81% <81.81%> (ø)

server/server.go
64.32% <94.11%> (+2.18%)
:arrow_up:

server/heartbeat_streams.go
67% <0%> (-6%)
:arrow_down:

server/schedulers/random_merge.go
60.71% <0%> (-3.58%)
:arrow_down:

server/member/leader.go
75.51% <0%> (-1.54%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939812d...9e8d0e3. Read the comment docs.


Add is_ceramic option in the 'analyze' function

I see this has been implemented in the streamlit app, but not in the main code. So added this to the mian code and notebook user could also have this option as well.

Hey,
Thanks for the PR! Indeed this was an option that I had added to the streamlit app and I didnt think much about the jupyter notebook one, since you could just do that manually (altough a bit annoying). This is indeed better as an option for analyze, and I will be adding this PR, thanks!


refactor group WIP

refactor group WIP
I couldn't build the bindings correctly but I needed them for the CI to run - TODO: upload built bindings

Could you change the PR title @Trivo25? :D


Update Journey Page

Update content for Journey page and fix Android & IE11 issues.
Additions

Polyfill for position: sticky

Changes

Content for building blocks
CSS layout fix for IE11
Sticky layout fix for Android

Review

@nbucknor
@karenkitchens

Preview this PR without the whitespace changes
Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[x] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Confirmed IE11 CSS Layout fixes with @dcmouyard  via screenshare. Android sticky layout bug still needs work (still broken at certain zoom levels).


Remove clean:events from clean_expired_subscriptions.rake

This task was removed here, but the task wasn't removed from the clean task, so remove it.
Attempting to run rake graphql:anycable:clean will fail with:

Don't know how to build task 'clean:events' (See the list of available tasks with rake --tasks)

Thanks for the pull request!


Cannot install tfimm via pip

Good day,
I tried to install tfimm via pip but I got the following error.
ERROR: Could not find a version that satisfies the requirement tfimm( from version: None)
ERROR: No matching distribution found for tfimm
Is that a problem because I have not installed another packages?

No that should not be a problem. If you are lacking dependencies, pip should install them for you.
Which python version are you using? tfimm only supports python 3.7, 3.8 and 3.9.


Switch unicode-linebreak to xi-unicode for ~25% faster debug builds

Further details in the original issue: https://github.com/pop-os/cosmic-text/issues/2

https://docs.rs/xi-unicode/latest/xi_unicode/struct.LineBreakIterator.html appears to break on the ZJW character, used in sample/emoji-zjw.txt

I have reverted for now. Hopefully this can be fixed in the future.

Ah, too bad. It appears it's this bug: https://github.com/xi-editor/xi-editor/issues/1322


js/ts sdk is outdated

just found out that we don't have ScheduleParameters used for init image on the js/ts SDK, thus we can't use correctly init image with the JS/TS image

Also another qs: how to build the TS/JS SDK from an updated proto? (I think the proto is also outdated, not only the JS/TS sdk, but anyway...)

current js/ts stubs and build instructions can be found here: https://github.com/Stability-AI/api-interfaces


Suggestion/feature request

Ever consider using an I2S audio solution so you can feed audio direct to the gpio on the pi instead of the USB method?  See https://github.com/mytechguyri/i2s_audio_phat.git
Then one other improvement... While i love the SA818 modules... they're a bit under powered... they typically don't put out enough power to drive an amp at all, so using them for APRS, while it works (works with the I2S audio above quite well) its just too low powered... BUT, NiceRF also makes the SA868 module... pin and code compatible with the SA818, but its a 2 watt module (actually 1.5W in real world) but that's enough to drive an amp... so it could make a great little digital modes hat... and i think if you look at the i2s_audio_hat, that's on the pi zero form factor, and there are big chunks of board real estate taken up by audio connectors and a microphone, which wouldn't be necessary in a a PIRIF type application... Use an IPX antenna connector, and I'd bet you could fit the i2s audio and the SA868 on a pi zero form factor board...  solar powered remote APRS digipeater?  piece of cake zero, hat, battery, solar panel in a weather proof enclosure.
I was actually going to design this myself, but pcb design is not my area of expertise... and you've got everything nearly done already with your pirim design... it makes more sense to collaborate to make a better wheel than to re-invent it.
73
WA1OKB

You are talking about the PIRIM board.
That program is independent of the PIRIM board. It is for configuring the SA818.
As soon as I git my hand on an SA868, I will modify this program to also configure this chip.


Variable references in build inputs don't take into account the build's bindings

rule touch
    command = touch $out

rule copy
    command = cp $in $out

build out/a: copy ${my_dep}
    my_dep = out/b

build out/b: touch

default out/a

This build file works in ninja, but not n2. Android has this case. I've only found one occurance that was trivial to remove so far, but I haven't gotten a full build working yet. If possible, maybe it's better not to fix it if it allows faster parsing.

This is https://github.com/evmar/n2/issues/39 and it is dumb that I didn't make it work, but I was greedy.
The reason for my greed is that n2 currently expands everything right while it parses, so when it sees ${my_dep} it wants to expand it to the final value without waiting to parse down through the definition of my_dep = .  This means it never needs to buffer any of these intermediate strings.  But it also means it's just plain incorrect relative to Ninja.
Now that I look at your example, I wonder if I could do some trick around assuming things will go the fast way and then if I see a variable reference later going back and re-expanding.  Or if I should just buffer everything anyway.  It would probably help for me to actually profile before I micro-optimize in this manner.

Relevant expansion inline code, I think maybe that ought to consult more scopes than it currently does too...

Oh, feel free to close as a duplicate then. Interestingly, this issue also causes parse errors:
rule touch
    command = touch $out

rule copy
    command = cp $in $out

my_var = out/b

build out/a: copy out/b | ${my_dep} out/d
    my_dep = out/c

build out/b: touch
build out/c: touch
build out/d: touch

default out/a

Produces:
n2: error: parse error: expected '\n', got ' '
build.ninja:9: build out/a: copy out/b | ${my_dep} out/...
                                                  ^

I actually think this will need to be properly fixed for the android build. Not all of these search results, but may of them, suffer from this issue.

(Sorry for not responding yet -- your other patches were obvious merges, but this one is more subtle so I want to give it proper attention and I have some life stuff going on the next week or so.)

Thanks for the update, I'll hold off on new PRs for now then.


Is it possible use different colorscheme for different buffer?

I would like to use different color for speical buffer like ctrp, nerdtree et al. Is it possible to use other color/component/layout/configuration according to buffer name?
The only way I can figure out is to add buffer name matcher to visual_condition, but it is not very convenient.

no, it's impossible.

No, it's impossible.

Do you have any plan to add this feature?

No.


Remove "documentDescription" class in table block

@sverbois Thanks! Would you mind to fix the test and write a changelog?


How to get the package to work with dnx /ef7

Hi Nick,
do you plan to make your package work with ASP.NET 5 platform & ef7 soon ( even though it is in beta still ) ?

I plan to do that in the next month or so. Do you have an immediate need for it?

Well, that would be great of course. But I don't want to impose if you've already planned for this on your roadmap.

Hi julienjuice, just wanted to give you an update. I've created a branch for EF7 support called... drumroll 'ef7'. The unit tests are passing, but I still need to go over it in more detail this week. Anyway, if you need to get started, feel free to clone/branch 'ef7' and watch for updates from me.

Cool, thanks


CASMPET-6398: kyverno prevents weave-net daemonset from creating pods

Summary and Scope
The daemonset-controller is not able to create the weave pod because it cannot get to kyverno to call the webhook.
Testing
Tested on:
Fanta
Test description:
ncn-m001:~ # kubectl get pods -o wide -A | grep weave
kube-system         weave-net-25z8t                                                   2/2     Running     3          8h      1252.1.9     ncn-m002
kube-system         weave-net-44djx                                                   2/2     Running     1          6h5m    1252.1.12    ncn-w003
kube-system         weave-net-9m2gv                                                   2/2     Running     0          6h9m    1252.1.13    ncn-w002
kube-system         weave-net-h8zwh                                                   2/2     Running     3          8h      1252.1.8     ncn-m003
kube-system         weave-net-km476                                                   2/2     Running     3          5h4m    1252.1.10    ncn-m001
kube-system         weave-net-nnwbr                                                   2/2     Running     1          5h28m   1252.1.14    ncn-w001
kube-system         weave-net-q7h99                                                   2/2     Running     0          5h44m   1252.1.11    ncn-w004
ncn-m001:~ # kubectl rollout restart daemonset weave-net -n kube-system
daemonset.apps/weave-net restarted
ncn-m001:~ # kubectl get pods -o wide -A | grep weave
kube-system         weave-net-25z8t                                                   2/2     Running       3          8h     <IP_ADDRESS>     ncn-m002
kube-system         weave-net-44djx                                                   2/2     Running       1          6h11m  <IP_ADDRESS>    ncn-w003
kube-system         weave-net-9m2gv                                                   2/2     Running       0          6h15m  <IP_ADDRESS>    ncn-w002
kube-system         weave-net-h8zwh                                                   2/2     Running       3          8h     <IP_ADDRESS>     ncn-m003
kube-system         weave-net-km476                                                   2/2     Running       3          5h10m  <IP_ADDRESS>    ncn-m001
kube-system         weave-net-nnwbr                                                   2/2     Running       1          5h33m  <IP_ADDRESS>    ncn-w001
kube-system         weave-net-q7h99                                                   2/2     Terminating   0          5h49m  <IP_ADDRESS>    ncn-w004
ncn-m001:~ #
ncn-m001:~ # kubectl get pods -o wide -A | grep weave
kube-system         weave-net-44djx                                                   2/2     Running       1          6h17m   <IP_ADDRESS>    ncn-w003
kube-system         weave-net-7pb47                                                   2/2     Running       0          2m21s   <IP_ADDRESS>    ncn-w002
kube-system         weave-net-9sq9g                                                   2/2     Running       0          3m18s   <IP_ADDRESS>    ncn-w001
kube-system         weave-net-h8zwh                                                   2/2     Running       3          8h      <IP_ADDRESS>     ncn-m003
kube-system         weave-net-km476                                                   0/2     Terminating   3          5h16m   <IP_ADDRESS>    ncn-m001
kube-system         weave-net-nnjv9                                                   2/2     Running       0          4m56s   <IP_ADDRESS>    ncn-w004
kube-system         weave-net-pf52t
ncn-m001:~ # kubectl get pods -o wide -A | grep weave
kube-system         weave-net-44djx                                                   2/2     Running       1          6h37m   <IP_ADDRESS>    ncn-w003
kube-system         weave-net-7pb47                                                   2/2     Running       0          22m     <IP_ADDRESS>    ncn-w002
kube-system         weave-net-9sq9g                                                   2/2     Running       0          23m     <IP_ADDRESS>    ncn-w001
kube-system         weave-net-h8zwh                                                   2/2     Running       3          9h      <IP_ADDRESS>     ncn-m003
kube-system         weave-net-km476                                                   0/2     Terminating   3          5h36m   <IP_ADDRESS>    ncn-m001
kube-system         weave-net-nnjv9                                                   2/2     Running       0          25m     <IP_ADDRESS>    ncn-w004
kube-system         weave-net-pf52t                                                   2/2     Running       0          24m     <IP_ADDRESS>     ncn-m002
ncn-m001:~ #
2/2     Running       0          4m6s    <IP_ADDRESS>     ncn-m002
ncn-m001:~ # journalctl -u kubelet | grep webhook
.
.
.
pod="kube-system/weave-net-km476" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 21 16:13:13 ncn-m001 kubelet[17533]: I0321 16:13:13.978535   17533 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-km476" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 21 16:13:17 ncn-m001 kubelet[17533]: I0321 16:13:17.979734   17533 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-km476" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 21 16:13:21 ncn-m001 kubelet[17533]: I0321 16:13:21.050583   17533 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-km476" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 21 16:13:33 ncn-m001 kubelet[17533]: I0321 16:13:33.884468   17533 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-km476" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
ncn-m001:~ #
ncn-m001:~ # kubectl edit configmap cray-kyverno -n kyverno
configmap/cray-kyverno edited
ncn-m001:~ # kubectl get cm cray-kyverno -n kyverno -o yaml
apiVersion: v1
data:
generateSuccessEvents: "false"
resourceFilters: '[Event,,][,kube-system,][,kube-public,][,kube-node-lease,][Node,,][APIService,,][TokenReview,,][SubjectAccessReview,,][SelfSubjectAccessReview,,][,kyverno,kyverno][Binding,,][ReplicaSet,,][ReportChangeRequest,,][ClusterReportChangeRequest,,]'
webhooks: '[{"namespaceSelector":{"matchExpressions":[{"key":"kubernetes.io/metadata.name","operator":"NotIn","values":["kyverno","kube-system"]}]}}]'
kind: ConfigMap
metadata:
annotations:
meta.helm.sh/release-name: cray-kyverno
meta.helm.sh/release-namespace: kyverno
creationTimestamp: "2023-03-21T05:39:01Z"
labels:
app: kyverno
app.kubernetes.io/component: kyverno
app.kubernetes.io/instance: cray-kyverno
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: kyverno
app.kubernetes.io/part-of: kyverno
app.kubernetes.io/version: v2.3.3
helm.sh/chart: kyverno-v2.3.3
name: cray-kyverno
namespace: kyverno
resourceVersion: "1074390"
uid: 35f7154b-2648-475d-b9d7-b0df879682df
ncn-m001:~ #
ncn-m001:~ # kubectl rollout restart daemonset weave-net -n kube-system
daemonset.apps/weave-net restarted
ncn-m001:~ #
ncn-m001:~ # kubectl scale deploy cray-kyverno -n kyverno --replicas 0
deployment.apps/cray-kyverno scaled
ncn-m001:~ # kubectl scale deploy cray-kyverno -n kyverno --replicas 3
deployment.apps/cray-kyverno scaled
ncn-m001:~ # kubectl get pods -o wide -A | grep weave
kube-system         weave-net-4c44p                                                   2/2     Running     0          4m46s   <IP_ADDRESS>    ncn-w001
kube-system         weave-net-dvmv2                                                   2/2     Running     0          98s     <IP_ADDRESS>     ncn-m003
kube-system         weave-net-fxxqn                                                   2/2     Running     0          51s     <IP_ADDRESS>    ncn-w002
kube-system         weave-net-h4nbp                                                   2/2     Running     0          6m33s   <IP_ADDRESS>    ncn-m001
kube-system         weave-net-knb55                                                   2/2     Running     0          3m59s   <IP_ADDRESS>     ncn-m002
kube-system         weave-net-lpqp8                                                   2/2     Running     0          2m56s   <IP_ADDRESS>    ncn-w003
kube-system         weave-net-nxghr                                                   2/2     Running     0          5m39s   <IP_ADDRESS>    ncn-w004
ncn-m001:~ #
ncn-m001:~ # journalctl -u kubelet | grep webhook
.
.
.
d" pod="kube-system/weave-net-g4t96" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
Mar 21 17:21:32 ncn-m001 kubelet[17533]: I0321 17:21:32.190795   17533 status_manager.go:611] "Failed to delete status for pod" pod="kube-system/weave-net-g4t96" err="Internal error occurred: failed calling webhook "mutate.kyverno.svc-fail": Post "https://cray-kyverno-svc.kyverno.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host"
ncn-m001:~ # date
Tue Mar 21 17:38:15 UTC 2023
ncn-m001:~ #

The code change looks good.   But I'd like to have @jeremy-duckworth or @kburns-hpe weigh in on what version this should be.  1.3.2 seems to make sense for the 1.3 branch but I'm just thrown by the recent change to 1.5 in this branch.

It looks like the csm/1.3 branch has been sync-ed up with main at some point after the 1.3.0 build.   Therefore, I'm concerned that the build in the csm/1.3 branch at this point is pulling in more than the change in this PR.

It looks like the csm/1.3 branch has been sync-ed up with main at some point after the 1.3.0 build. Therefore, I'm concerned that the build in the csm/1.3 branch at this point is pulling in more than the change in this PR.

Thank you for the sleuthing @johren-hpe!


Started PyScss 1.3 support With the DjangoImportExtension

DON'T MERGE
An attempt at supporting PyScss 1.3 using an Extension. This is an exploratory stab.
This is different from #26, because instead of inserting ourselves at the search_paths, we use the Extension API to override importing altogether.
It works OK, but I'm unhappy with how the images stuff works.
I also don't want to have the CompassExtension enabled by default if the scss.Compiler doesn't have it enabled by default.
cc @eevee.

I was hoping to support both versions of PyScss with this also.


[labs/analyzer] add mixin support

Replaces #4120.
This is actually kevin's branch but caught up from main, and various tests added.

i've also tried to update all occurrences of throw new DiagnosticsError or throw new Error to instead create/add a diagnostic and return undefined.
seems to be what we do elsewhere in the codebase, but do correct me if im wrong

fyi i've marked for review but i have some tests to write still
there's also a comment or two i left myself which would be good to resolve first

FYI i've also now updated gen-manifest to support mixins.
i still need to update the goldens at some point, though.

ok as per discord, for now i've done two things:

drop isMixinClass so i can just figure it out from scratch (see note below)
only consider call expressions to be applied mixins if the identifier is a mixin

Regarding the isMixinClass stuff... it actually had a bug in it before anyway so i've decided to remove it entirely and just solve the problem from scratch.
The bug, if anyone's curious, was that we only set isMixinClass: true for unknown class declarations. For custom elements and lit elements, we never passed the flag along. This meant they always had a superClass, while regular mixin class declarations didn't.
If anyone wants to help me figure it out, the aim of that flag is to make mixin classes have no superClass in their heritage (since it'd be the parameter to the function, nothing useful i guess). To do that, somehow we need to detect we're computing the heritage of a mixin class in getHeritageFromExpression and null off the superClass if so. We achieved that with the flag before, but I feel like there must be a cleaner way.
If it turns out there's no cleaner way, i'll go back to the flag.

ok for now at least i've reintroduced isMixinClass and fixed the bug with it
tests should pass now, PTAL if anyone gets chance

The changes LGTM, and thanks for tracking down the isMixinClass bug, the change to thread it through looks right to me.
It looks like we still need to fix the error of the Vue wrapper generator not walking the heritage chain to collect properties (and be robust to an element not having any properties).
So we don't lose the context, here's some notes I put in Discord a while back:

It looks to me like the type error is because the generated Props interface is an empty object with no keys (so p as keyof Props is always never).

It looks like Props is empty because it is just using declaration.reactiveProperties from here to generate that interface: https://github.com/lit/lit/blob/main/packages/labs/gen-wrapper-vue/src/lib/wrapper-module-template-sfc.ts#L80

So I'm guessing we (a) need to make/use a helper to collect reactive properties from the entire proto chain (not just the youngest class declaration in the chain), and (b) improve the Vue generation code to deal with the fact that it's actually valid for a component to have no reactive properties (which currently leads to the type error here)
iow, the root cause is that ElementMixins itself has no reactive properties, it inherits them from the mixin, and we're not collecting all reactive properties to generate the view Props interface

#4293 might fix that. I opened it back when we discussed it, maybe worth merging that first. Will have to remind myself what I did there though

Awesome, sorry I missed that. LGTM'ed, and once that merges, hopefully we can get this merged.

With https://github.com/lit/lit/pull/4293 merged, perhaps this can be rebased and revisited? I know @e111077 has tried this on MWC and had it work for its doc generation.

Can confirm that this implementation worked on the MWC repo with a small fix to the MWC repo's generator which made some silly assumptions

👍  i'll rebase later today and see how it goes

rebasing was proving difficult which is why i ended up catch up merging last time i think, so i just did the same again
the tests still fail thanks to some typescript import stuff, not too sure what to do about that. all ts imports are the same, in files i've not touched too. so not entirely sure which import exactly is causing problems

looks like i got tests passing now 👍

BTW @kevinpschaaf has given this PR a verbal LGTM

just did the minor changes @augustjk suggested (some package name updates) FYI

I think we should merge this now and open an issue to address known problems in the mixin superclass lookup.


Add jacobian-vector product support

These changes add support for automatically derived jacobian-vector product functions within
SymbolicSys. This can be used for integration with CVODES, either through pycvodes or native code.

I was not quite sure the best approach to some of the test failures, which stem (in part) from some compatibility-breaking things I introduced into pycvodes that have not been released yet. (Although there do seem to be a few pre-existing errors, notably "'NativeCvodeCode' object has no attribute '_remove_tempdir_on_clean'"--which appears to go away with unreleased pycodeexport content?--and an unused variable error that I should have fixed yesterday  in https://github.com/bjodah/pycvodes/pull/76.
Anyway, the new compilation errors come from my 1) renaming jac_times_vec ---> jtimes and 2) taking in linear_solver as a str, not int in pycvodes. There seem to be a couple unsavory options to deal with this:

Keep pyodesys fully compatibility with the latest release of pycvodes, updating the interface of the former only after a new release of the latter.
Match the interface here to the current development version of pycvodes; have the CI tests fetch that version instead of installing pycvodes
Some hybrid interface for pyodesys that works with both old and development. Have not thought about how to do this elegantly...

I obviously defer to you on this.

Let's do 1) or 2). I could mint new releases tomorrow if that sounds alright by you?

So I've started updating dependent packages. (Not finished quite yet).
Since the includes of headers from AnyODE will depend on a macro (whether to use blasless version or not) I think I'm leaning towards renaming that macro (USE_LAPACK) to (ANYODE_NO_LAPACK) and have users actively opting out of lapack instead of the opposite (it will be less disruptive in some of my private packages as well). Does that sound alright by you?
I'll get back to updating the interfaces tomorrow and will hopefully be able to upload new releases of all the dependencies then as well.

I added a few commits here (made AnyODE a submodule, updated CI config with suitesparse).
When I run tests locally now the first error reported looks like it's from the new jtimes facilities:
$ CPATH=/opt/sundials-3.1.1/include:/usr/include/suitesparse LIBRARY_PATH=/opt/sundials-3.1.1/lib LD_LIBRARY_PATH=/opt/sundials-3.1.1/lib ./scripts/run_tests.sh -x
========================================== test session starts ==========================================
platform linux -- Python 3.5.2, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /home/bjorn/vc/pyodesys, inifile: setup.cfg
plugins: pudb-0.6, pep8-1.0.6, flakes-2.0.0
collected 349 items

conftest.py s.                                                                                [  0%]
setup.py ..                                                                                [  0%]
examples/_chem_kinet.py s.                                                                        [  0%]
examples/pydy_double_pendulum.py s.                                                               [  1%]
examples/van_der_pol.py s.                                                                        [  1%]
examples/tests/test_examples.py s....                                                             [  2%]
pyodesys/__init__.py s.                                                                           [  2%]
pyodesys/_release.py s.                                                                           [  3%]
pyodesys/analysis.py s.                                                                           [  3%]
pyodesys/convergence.py s.                                                                        [  3%]
pyodesys/core.py F

=============================================== FAILURES ================================================
____________________________________________ pyflakes-check _____________________________________________
/home/bjorn/vc/pyodesys/pyodesys/core.py:683: UndefinedName
undefined name '_p'
/home/bjorn/vc/pyodesys/pyodesys/core.py:684: UndefinedName
undefined name '_p'

So I'll hand this over back to you from here. Let me know if I can help.

I released pyodesys-0.11.15 with new (upper) limits on dependencies:
https://github.com/bjodah/pyodesys/pull/85
You'll need to invert those for your branch (which we'll release as pyodesys-0.12.0).

Finally getting back to this now that the  (I think) all the requisite changes  have been pushed to anyode/pycvodes/sym. Given the substantial changes in those, I don't know how you want to proceed. Let me reply to your other remarks here first.

Feel free to replace it with a submodule. Breaking backwards compatibility is also fine (as long as we retain capabilities). I'll maintain the pyodesys-0.11 branch as a legacy version (to give myself and others time to adapt to 0.12 once you feel it's time to tag it).


Reuse preprocessing functions

Implementing issue https://github.com/modex-flexmex/oemo-flex/issues/14
Additionally, a the result comparison similar to https://github.com/modex-flexmex/oemo-flex/issues/13 needs to be fixed before in order to go safe when refactoring.

The last commit addresses the issue that we cannot move the functions unless we have made everything a parameter, see https://github.com/modex-flexmex/oemo-flex/issues/14#issuecomment-606065434 (the objected-oriented solution proposed here was postponed)

Renaming what becomes the processing module for the sake of being in line with the names of the processing steps.

After talking, we decided to

add a column in each elements dataframe 'Region' which is the same as the regions in the input data Scalars.csv
add a column in component_attrs 'suffix' that is distinct from 'default'.
fill the columns 'name', 'bus' and 'region' already in the create_default_elements_files function.

For link elements, the merging function remains to be further adjusted.

Tried to leave changes as minimal as possible for the link_list by doing some replacement only for the new column:
https://github.com/modex-flexmex/oemo-flex/blob/c02b645d2fa951a1c821f3233e2cdb2f211cedfb/oemoflex/preprocessing.py#L141-L143
This leaves the postprocessing untouched as far as possible.
Changing the link_list itself to the new format (AT_DE) would have entailed much more changes.

Added suffixes and their processing – probably looks better with DataFrame operations

I do not understand why travis checks do not appear in this PR. Here I post the results of the last build with some failures for the linters: https://travis-ci.org/github/modex-flexmex/oemo-flex/builds/669838469?utm_medium=notification&utm_source=github_status

Hey @unndreay, thanks for your effort! This looks good. I left some comments and questions that we should address. After that, this seems ready to merge.


Sprint 32

User Story
An epic to link features and bug fixes for the sprint.
Assumptions

Epic Issues
To view the linked "backlog", "in progress", and "completed" issues associated with this epic, add the  Zenhub browser extension.
Alternatively, view the Zenhub board for this epic.

Verified, f68323e9c52396b2fd8bf718ee1b129c8216c808


Fix track file

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

To get the tests to pass, I had to inject a fact (keepalived_version) into keepalived_vrrp_track_file_spec.rb. That feels dirty, but otherwise the fact is undefined. Open to suggestions.


chore(esl-alert): Migrate esl-alert example page to playground base

Closes: #2159

Closed by https://github.com/exadel-inc/esl/pull/2315


Error: missing mandatory check field: 2.storage

Attempting to run duplicacy-util on Windows Server 2012. I consistently get the following:
PS C:\users\daniel> duplicacy-util -f serverfolders 19:21:47 Using global config: C:\Users\daniel\.duplicacy-util\duplicacy-util.yaml Error: missing mandatory check field: 2.storage
I have also run the command explicitly providing the -sd flag, with the same result. The -v and -d flags provide no further information.
The local config file is in the same directory as the global one, and is named serverfolders.yaml. It contains:
repository: D:/ServerFolders

storage:
    - name: usbdrive
      vss: true
      vss-timeout: 360

copy:
    - from: usbdrive
      to: dreamobjects
      threads: 20

prune:
    - storage: usbdrive
      keep: "0:365 30:180 7:30 1:7"
    - storage: dreamobjects
      keep: "0:365 30:180 7:30 1:7"

check:
    - storage: usbdrive
      all: true
    - storage: dreamobjects
    - all: true

I have tried many variations: repository name (serverfolders), repository location (D:\ServerFolders), storage name (usbdrive), storage location (h:\duplicacy_backup), etc.
The repository has been initialized to use a directory on an external hard drive as storage, and to copy to cloud storage. I have successfully run the backup and copy operations directly with duplicacy several times, but I can't get duplicacy-util started.
Have I misunderstood something about the configuration options?

That took me a perusal of the source code, and then I understood what is happening:
For the check information, you have:
check:
    - storage: usbdrive
      all: true
    - storage: dreamobjects
    - all: true

The - characters are critical here, as it delineates a new repository to check. (It's kind of weird that you're checking storages that you're not backing up, but I'm sure you have a reason for that.)
In any case, the above segment says you have three storages to check (numbered from 0 due to how Go numbers these).
Check 0: Name=usbdrive, all=true
Check 1: Name=dreamobjects, no all flag (it will be defaulted)
Check 2: No name, all=true

You can't check something without a storage name, so duplicacy-util complained.
Make the check segment look like this instead:
check:
    - storage: usbdrive
      all: true
    - storage: dreamobjects
      all: true

That should fix you up.

Thanks for spotting that. I would have looked at it for days before I caught it.

The error message is historical. We used to have numbered sections in prior versions. When you had numbered sections, 2.storage made more sense (check session 2, field storage).
I'm going to to reopen this issue (as a reminder) and run through the code making sure error messages make sense given the current YAML format.
This would have been better to say something like Error: 'storage' definition missing in check entry 2 (or something like that). That might have made more sense to you, and would have given you more of a hint as to what the problem was.


Fix <pre /> element flowing to the left

Fixes #2.

I tried to reinstall the cupertino theme on my computer, but I found that the bug is still there. The code block is still floating on the left. Also I noticed that you have tried to update the style of the tables as told in issue #23 . I've taken a screenshot and submitted it with the source code as attachments. I hope this will be of some help.

Untitled-2.txt

Emmm... Did you switch to branch 2-code-blocks-flowing-left, if not, try switching to it?

Yes, I did it, and everything was fine this time.

Cool! Thank you very much! Now merged.


feat: remove nacos account validation

#134

Codecov Report
Base: 63.76% // Head: 63.93% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (635fa8b) compared to base (b36f23f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   63.76%   63.93%   +0.16%
==========================================
  Files          16       16
  Lines        1184     1184
==========================================
+ Hits          755      757       +2
+ Misses        369      368       -1
+ Partials       60       59       -1

Impacted Files
Coverage Δ

internal/conf/nacos.go
76.00% <ø> (ø)

internal/discoverer/nacos.go
74.59% <100.00%> (ø)

internal/core/storer/etcd.go
67.26% <0.00%> (+1.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Spigot description page not properly imported

Observed/problematic behavior
Here is the link of the page: https://hangar.papermc.io/Djaytan/JobsRebornPatchPlaceBreak
I will not update for now in order to let you inspect the result.

Corresponding code generated:
<center>
# A place-and-break patch extension of [JobsReborn](https://www.spigotmc.org/resources/jobs-reborn.4216/)
</center>

**### Donation
**
If you appreciate my work and want to support me, then thank you a lot! It will also give me the motivation to share new works.

Seems that only the upper and lower parts are impacted, the rest between has been nicely converted
Expected behavior
Spigot page completly imported without any formatting issue
Steps to reproduce
Create a new project from a Spigot one
Other

the bbconverter will never be perfect, bbcode is too cursed for that. I did a few improvements, but that center at the top you have to fix yourself.


How about a 0.13.0 release?

@andrewsmedina Thanks for the recent 0.12.0 release. It's only been a few days, but the past few commits after 0.12.0 have fixed a bunch of issues which I think warrant another release.

0.13.0 released https://github.com/cobrateam/splinter/releases/tag/0.13.0


feat: As a user, I would like a strip-path annotation feature like kong has

Description
I have an ingress that look like that:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: api
  annotations:
    k8s.apisix.apache.org/strip-path: "true" #My feature request to fix this issue
spec:
  ingressClassName: apisix
  rules:
    - host: api.mycorp
      http:
        paths:
          - path: /api1
            pathType: Prefix
            backend:
              service:
                name: api1
                port:
                  number: 80
          - path: /api2
            pathType: Prefix
            backend:
              service:
                name: api2
                port:
                  number: 80
          - path: /api3
            pathType: Prefix
            backend:
              service:
                name: api3
                port:
                  number: 80

I want the upstream path to look like /test-action?apikey=1234 when I access the following url url: https://api.mycorp/api2/test-action?apikey=1234
I already tried with k8s.apisix.apache.org/rewrite-target-regex and k8s.apisix.apache.org/rewrite-target-regex-template without any success.

Sorry for the delay.
So your goal is to rewrite /$1/$2?apikey=1234 to /$2?apikey=1234 right?

If set to true, the part of the path specified in the Ingress rule will be stripped out before the request is sent to the service. For example, if the Ingress rule has a path of /foo and the HTTP request that matches the Ingress rule has the path /foo/bar/something, then the request sent to the Kubernetes service will have the path /bar/something.

https://docs.konghq.com/kubernetes-ingress-controller/latest/references/annotations/#konghqcomstrip-path

Yes, I actually found a way using proxy-rewrite plugin and/or rewrite-target-regex. This could be an easy feature to work on.

@ecoupal-believe Could you please share your configuration on how to apply proxy-rewrite on k8s?

You can apply something like that:
apiVersion: apisix.apache.org/v2
kind: ApisixPluginConfig
metadata:
  name: my-plugin-config
spec:
  plugins:
  - config:
      regex_uri:
      - ^/[^/?]+/{0,1}(.*)
      - /$1
    enable: true
    name: proxy-rewrite

An then attach it to your ingress:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    k8s.apisix.apache.org/plugin-config-name: my-plugin-config
  name: my-ingress
spec:
  ingressClassName: apisix
  rules:
  - http:
      paths:
      - backend:
          service:
            name: my-service
            port:
              number: 80
	path: /my-service
        pathType: Prefix

Thanks @ecoupal-believe in my code I have to replace k8s.apisix.apache.org/plugin-config-name by apisix.apache.org/plugin-config-name


investigate Selective imports for static functions to reduce build time

The navigation properties as currently declared on the request builder/api client directly. While this is convenient for discovery, it also means the whole graph structure gets pulled as soon as the client is used, which for such a large API means a long compilation time, negative impacts to auto completion etc...
Since those functions are "declared statically" (go idioms) we could move their declaration to the sub module they point to.
I.E. the declaration for users() on the service client would live under the users submodule and not on the root module.
What that means is that people would need an additional import (msgraphsdkgo/users) before they can use the navigation property, but it should greatly reduce build times since the compiler would only be pulling things the application needs to begin with.
We might run into circular dependencies while experimenting with that.

I took some time to fiddle with that. Go doesn't support defining function receivers outside of the package where the type is defined.
What that means is we cannot have the "me" function defined in the "me" package instead of in the root one.
The alternative would be to have composed types defined at each package level. which would like to an experience like this one.
Current
result, err := client.Me().Drive().Get(context.Background(), nil)
if err != nil {
    fmt.Printf("Error getting the drive: %v\n", err)
    printOdataError(err)
}
fmt.Printf("Found Drive : %v\n", *result.GetId())

Workaround
//medrive is an import of github.com/microsoftgraph/msgraph-sdk-go/me/drive
result, err := medrive.Client(client).Get(context.Background(), nil)
if err != nil {
    fmt.Printf("Error getting the drive: %v\n", err)
    printOdataError(err)
}
fmt.Printf("Found Drive : %v\n", *result.GetId())

This completely breaks the fluent API design, which is a tradeoff decision we could make to drastically improve performance.
I haven't implemented this generation "style" yet because it represents a change in direction that needs to be discussed further.
Also uploading my POC
selectiveimportsgo.zip

Update: since this initial investigation changes in the way the packages are structured yielded great build times improvements. closing for now.


WebRTC time syncing in SyncPlay

Changes
This PR adds support for WebRTC, making it possible to time sync browsers on the same network.
The experienced playback delay between devices on the same network will be less noticeable (this is the expected result at least).
This PR is related to the server side one.

@OancaAndrei Why is this not ready to be reviewed?

@ferferga, the syncplay-webrtc branches are all branched off syncplay-enhanced and I was waiting for the latter ones to be merged so that I can rebase the first ones (because of potential last-minute changes).
But I guess that this repo won't be seeing further changes so I'll mark this ready for review shortly.

Closing this one because the decision was to avoid WebRTC and P2P features. The other ones are fine in terms of scope.


Don't autorestart on vcredist update

Recently the updater was changed to automatically run the latest vcredist executable, but it is missing the /norestart option, which means it automatically starts rebooting if one is required without asking the user. The /norestart option should be added, and a MessageBox needs to be added to let the user know they need to restart their computer before using TF2BD.

Fixed in<PHONE_NUMBER>d44ae3950a4a16218a49648b4ebb20.

Fixed in<PHONE_NUMBER>d44ae3950a4a16218a49648b4ebb20.


Fix clientcompat for APIV2

reflect.DeepEqual() does not work as expected anymore with APIV2, see #310 for details.
Using proto.Equal() instead.
fixes #310
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM, thank you for the fix!
I can merge it in the main branch right away, and will tag it along with the next release soon.


Re-theme github pages

Need a more serious documentation theme, e.g. documentation-theme-jekyll-gh-pages

https://github.com/tomjoht/documentation-theme-jekyll
including things like release notes, esp. if auto generated, in addition to the existing documentation, and any other context we could provide for new users of slsh.  It would also tie in with some of the documentation effort here: https://github.com/sstanfield/slsh/tree/feature/scripting
using the functionality to write out slsh function output to md files could prove esp. handy when generating docs.

https://github.com/tomjoht/documentation-theme-jekyll
including things like release notes, esp. if auto generated, in addition to the existing documentation, and any other context we could provide for new users of slsh.  It would also tie in with some of the documentation effort here: https://github.com/sstanfield/slsh/tree/feature/scripting
using the functionality to write out slsh function output to md files could prove esp. handy when generating docs.

jekyll collections could be useful.
definitely want a collection of Sections (shell, core, etc.) and their doc links to reference throughout the site.
possible that putting function documentation into collections could offload some of the md generation overhead. The really cool thing is that with something like this in the config.yml
collections:
slsh_forms:
output: true
permalink: /sl-sh-doc/:path/
every docstring could have it's own page. There is a jsonify filter that could be used in an API.

add faw page about bash completions

make sure correct version is printed in header, not 1.0.
would be really cool if version of docs for each version were available...


Bug or null handling during rewrite of json

Describe the bug
I'm getting the following error when testing the dockstore interaction with cwltool for updates to an existing tool (new arguments).  Files are pulled from FTP addresses before this error occurs, the error also occur if json file references local files:
10:25:35.810 [main] ERROR io.dockstore.client.cli.ArgumentUtility - null
10:25:35.813 [main] ERROR io.dockstore.client.cli.ArgumentUtility - java.lang.NullPointerException
	at io.github.collaboratory.cwl.CWLClient.createUpdatedInputsAndOutputsJson(CWLClient.java:963)
	at io.github.collaboratory.cwl.CWLClient.provisionInputFiles(CWLClient.java:244)
	at io.dockstore.client.cli.nested.BaseLanguageClient.launchPipeline(BaseLanguageClient.java:164)
	at io.github.collaboratory.cwl.CWLClient.launch(CWLClient.java:289)
	at io.dockstore.client.cli.nested.AbstractEntryClient.launchCwl(AbstractEntryClient.java:1185)
	at io.dockstore.client.cli.nested.AbstractEntryClient.checkEntryFile(AbstractEntryClient.java:815)
	at io.dockstore.client.cli.nested.AbstractEntryClient.launch(AbstractEntryClient.java:1132)
	at io.dockstore.client.cli.nested.AbstractEntryClient.processEntryCommands(AbstractEntryClient.java:278)
	at io.dockstore.client.cli.Client.run(Client.java:715)
	at io.dockstore.client.cli.Client.main(Client.java:614)

Runs cleanly via cwltool if files are made local in advance.
To Reproduce
curl points to head of feature/dockstoreLayerOnly of dockstore-cgpmap at time of writing:
curl -L https://github.com/cancerit/dockstore-cgpmap/archive/352e2fd7371fee01c555992ff813452a303d23f0.tar.gz | tar zx
cd dockstore-cgpmap*
docker build -t quay.io/wtsicgp/dockstore-cgpmap:3.2.0 .
dockstore tool --script launch --local-entry cwls/cgpmap-bamBaiOut.cwl --json examples/cgpmap/bamBaiOut/bam_in.json

Expected behavior
No error, workflow runs.
Screenshots
NA
Desktop (please complete the following information):

OS: NA
Browser: NA
Version:

Built following quick-start on 2020-09-03 (cwltool is very old in that document)
$ dockstore --version
Dockstore version 1.9.0
You are running the latest stable version...
If you wish to upgrade to the latest unstable version, please use the following command:
   dockstore --upgrade-unstable
$ java --version
openjdk 11.0.8 2020-07-14
OpenJDK Runtime Environment (build 11.0.8+10-post-Ubuntu-0ubuntu118.04.1)
OpenJDK 64-Bit Server VM (build 11.0.8+10-post-Ubuntu-0ubuntu118.04.1, mixed mode, sharing)
$ cwltool --version
/home/ubuntu/.local/bin/cwltool 1.0.20190621234233

┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Sprint 44- Sea Horse
┆Issue Number: DOCK-1563

Linking to https://github.com/dockstore/dockstore/issues/3591 for cwltool version.
I also think I ran into a problem with ruamel with the current requirements.txt
At first glance, it looks like it could be an error in dealing with the array structure  or the removal of bams_in
  "seq_in": [
    {"class": "File",
      "path": "ftp://ngs.sanger.ac.uk/production/cancer/dockstore/cgpmap/insilico_21.bam"}
  ],

Note that we've launched https://dockstore.org/containers/quay.io/wtsicgp/dockstore-cgpmap:2.0.3?tab=files before in our testing framework. https://dockstore.org/containers/quay.io/wtsicgp/dockstore-cgpmap:3.0.0?tab=files shows a validation error which might be related.
@garyluu  (may want to run in Openstack)

@garyluu Is this something Richard could look at, or do you think the OpenStack environment is required? Seems like it is failing in the provisioning phase, at least to start with, so OpenStack may not be necessary?

yup, it's not necessary to use OpenStack for this

The error is caused by having null values within the JSON, and is being fixed. In the above example, replacing/removing {"threads" : null} to a non-null value should solve the immediate bug.

I can confirm that all 6 CWL routes through the code work if the nulls are replaced by values.


Non-breaking space character modified in editor

Fork of https://github.com/Microsoft/vscode/issues/43364

echo '\xa0' > test.txt
Open test.txt in vscode
Modify it somehow - type a newline at the end, and save
The A0 character has been transformed to EF BF BD

$ xxd test.txt
00000000: efbf bd0a 0a

(0A is newline)
A0: http://www.fileformat.info/info/unicode/char/00a0/index.htm
EF BF BD: https://apps.timwhitlock.info/unicode/inspect?s=�

@roblourens can you provide more detailed reproduce steps? I can't reproduce locally as above.


Add footer to home page

I have added the same footer to Home Page as its in the About page.

This is how it looks.

@anushree0809 Your work looks fine but make sure there is some gap between body content and footer.
Can you fix it?

Ok, will update the PR after fixing.

Does this look better?

Yeah it looks better now.
Kudos!! nice work
Keep contributing.


Added epel 7 everywhere

I needed to be able to pull in epel-testing for CentOS 7 in https://github.com/svanzoest/ssmtp-cookbook/issues/18, but looks like that got missed in the previous PR #6

Released as 0.6.0


Added styling rules to our linter; these included comments spacing an…

…d caps, camelcase for vars (ALL CAPS snake_case excluded) and configured comma style/spacing so we can be consistent there as well.
Also added test files so we can see what's happening.

@phuchle

Few things I noticed on my machine (Atom running on Ubuntu) for lintConfigTest:
Line 18 comment should error but doesn't
Lines 90..92 should error out I believe.

do you want me to work on this and fix it for atom? What config do I need to set up the atom linter (I have atom on one of these machines)

@rainrivas
Yeah if you could that would be great.  Packages I have installed on Atom for linting: linter, linter-ui-default, linter-eslint.

@phuchle I only see atom missing 2 errors my sublime caught and they are tabbing vs space (i think atom auto corrects tabs to spaces). So I don't see a problem there. Also you mentioned that line 18 should error but ln18 is blank. Not sure what you are referring to, but it's a comment block apparently

Merging and closing this PR so we can do final review on Duc's PR (PR#6)

SWEET


catch exception

Hi,
when I try to use this repo I catch exception
Class 'PhpAmqpLib\Connection\AMQPStreamConnection' not found
(rabbitMq)

You need to install php-amqplib/php-amqplib package.
Read documentation attentively.
https://github.com/zhuravljov/yii2-queue/blob/master/docs/guide/driver-amqp.md
First paragraph.

Yes. Thanks. I installed it
but now
PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'queue' in vhost '/': received 'false' but current is 'true'",
"main": {
"name": "Exception",
"message": "PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'queue' in vhost '/': received 'false' but current is 'true'",
"code": 406,
"type": "PhpAmqpLib\Exception\AMQPProtocolChannelException",
"file": "/var/www/proxy/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Channel/AMQPChannel.php",
"line": 188,

thanks. I already fixed


layer.translate works on the active layer, not the layer that calls it

Issue in /src/pages/ps_reference/classes/layer.md
https://developer.adobe.com/photoshop/uxp/2022/ps_reference/classes/layer/#translate does not work as advertised.  I select layers, attempt to translate them, and have the active layer translated instead of whichever layer I have chosen.  You can demonstrate this in the console by copying the background twice, then:
layer1 = app.activeDocument.layers.getByName("Background copy") layer2 = app.activeDocument.layers.getByName("Background copy 2")
select one of the layers in Photoshop.
I created:
async function test() { 	var layer2 = await app.activeDocument.layers.getByName("Background copy") 	layer2.translate(0, 50) }
and in the console ran:
await window.require("photoshop").core.executeAsModal(test)
and the result was that the active layer I had clicked on was translated, no matter which one that was, despite layer2 being the one that was calling the translation.

await layer2.translate(0, 50) - the awaits were also in correctly in the main code in which I found this.

Thanks for the report. I think this should be fixed to make it work as expected. It will likely apply to the other kinds of transformations too.

I have no idea how to escalate this from the docs to any other issue tracker - is that something you can do?

Yes. I could possibly fix it myself. But it can take a while before it goes into the public release of Photoshop.

thumbsup
Thanks for the warning.  I've got a current workaround, I think, where I can copy my layers into a new document, and work on those as I go, so I never let go of them until I no longer need them.


ImageBackground doesn't consider borderRadius.

Is this a bug report?
yes
Have you read the Contributing Guidelines?
yes
Environment
Environment:
OS: Linux 4.10
Node: 8.6.0
Yarn: 1.2.0
npm: 5.3.0
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.0.0 => 16.1.1
react-native: ^0.50.3 => 0.50.3
Steps to Reproduce

<ImageBackground
       style={{
           borderRadius : 50,
           width: 100 ,
           height: 100}}
        source={{uri: 'https://en.facebookbrand.com/wp-content/uploads/2016/05/FB-fLogo-Blue-broadcast-2.png')}}
        onLoad={() => this.setState({profileImageIsLoading: false})}>

        {/** this._renderActivityIndicator() */}

</ImageBackground>

Expected Behavior
Circular Image
Actual Behavior
Square Image
Reproducible Demo
I think the code up which ive posted can be copy pasted.

If you take a look into the Source Code you see that the <Image> component is positioned absolute. Absolute positioned children will always ignore overflow: hidden and stuff like borderRadius: 1 of the parent I think. Taking another look you see that you can pass imageStyle prop.
All in All - Here is the solution:
<ImageBackground
  style={{ width: 50, height: 50, borderRadius: 25 }}
  imageStyle={{ borderRadius: 25 }}
  source={{ uri: imageUrl }}
/>

Thank you. Its working! I didn't know that position: absolute ignores borderRadius.
Again thank you for the solution!

@Sommerfeld Thanks,It works for me too. I search this issue for a few day,but no one knowns it.

Unfortunately only borderRadius works with this method, borderTopLeftRadius for example doesn't, it still shows square.

Some idea why independent borders doesn't work with ImageBackground? i'm trying to get an Image with top borders rounded and bottom borders squared but apparently it's not possible.

Consider creating a new bug report. This is not a bug of ImageBackground, the Image component itself doesn't render separate border radiuses even so the docs explicitly mention these style props. If you don't create a new bug report your chances of being heard are pretty low I guess.
https://snack.expo.io/@mhjannik/image-with-separate-border-radius


Cleaning up _runAsyncMain a bit

I'm making two cleanups here. First, the closure going into
_runAsyncMain needs to be @Sendable or passing it to the task is not
safe. This will also result in a warning being emitted.
Second, I'm making this @usableFromInline and internal. This function
is around for legacy reasons, but it's part of the ABI, so we can't pull
it out entirely, but we don't want folks using it.
rdar://74942340

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 8ec60def521a2548eeceb8a6d02887c7c1b47579

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 1f198bcd93d3b3b0e20353f03fc6d3e397e76db0

@swift-ci please test

@swift-ci please test

Windows builds are currently broken due to https://github.com/apple/llvm-project/pull/3537.
LINK : fatal error LNK1181: cannot open input file 'swiftCompilerModules.lib'
PR https://github.com/apple/llvm-project/pull/3736 reverts that PR and will fix the issue.
Failing build: https://ci-external.swift.org/job/swift-PR-windows/19556.

Build failed
Swift Test Linux Platform
Git Sha - bfcc809ac8c1c6aa673621cef130d3bc0c380c88

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - bfcc809ac8c1c6aa673621cef130d3bc0c380c88

@swift-ci please test linux

@swift-ci please test

This caused api-digester/stability-concurrency-abi.test to start failing on CI https://ci.swift.org/job/oss-swift-pr-test-macoss/139/. Looks like a conflict with https://github.com/apple/swift/pull/41253.
Reverting in https://github.com/apple/swift/pull/41689.

This caused api-digester/stability-concurrency-abi.test to start failing on CI https://ci.swift.org/job/oss-swift-pr-test-macoss/139/. Looks like a conflict with #41253.
Reverting in #41689.

yeah, I probably should have re-run that before merging. I can't see the CI at the moment. I'm getting a 403 again.


First graph is higher in fullscreen view

Steps to reproduce:

Create dashboard with at least two graphs
Enable fullscreen mode
The first graph is multiple pixels taller than the others and the layout of the other graphs around it is changed as a result:

Can't reproduce. Can this and #178 be close? @juliusv @stuartnelson3

:+1:

Indeed, haven't seen this problem in a year or so. Closing.


K8s Operator: Docs for Configuring Permissions (placeholder)

Engineering is addressing an issue around our handling of permissions: Address Permissions Required by the Operator #258

@johnrk @keith-mcclellan What docs are needed here? This looks like an Operator manifest change.

@taroface , AFAIK, no docs are needed here. This particular change is related to tech debt.
@keith-mcclellan , can you confirm?


Add nullability annotations for Swift 1.2.

Chris Lattner indicated that Apple will likely provide a new macro, something like, NS_ASSUME_NONNULL_BEGIN/END, so it might be worth waiting for that.
This thread has good info:
http://lists.apple.com/archives/xcode-users/2015/Feb/msg00046.html

NS_ASSUME_NONNULL_BEGIN has been added in Xcode 6 beta 3. The fix for this issue should not be put into master until Xcode 6.3 is out of beta, however.


Carthage support and swift examples

Could you please add support for Carthage and swift examples?

Hi @alec-c4,
Thanks for taking the time to write in :+1:
The 1Password App Extension API currently supports both Carthage (see the add-framework-support branch) and has Swift 1.2 sample apps in the see the new/swift-demo-apps branch.
We are currently working on adding support for Swift 2.0 in the swift2.0 branch.
So I'll be closing this issue for now. Please let me know if there's anything else I can do to help :smile:
Cheers!

Hi @dzenbot,
There are no plans to merge the add-framework-support branch to master, because it forces the use of frameworks for the demo apps. It is a separate branch which is being kept in "sync" with master.
Hope that this helps :wink:

Hi @dzenbot,
Thanks for the prompt reply :+1:

Is using frameworks for the demo apps an issue because of backward compatibility?

Not necessarily, it would be a backward compatibility issue for developers who use the 1Password App Extension API in projects that target both iOS 7.1 and earlier and iOS 8 and later. Also, Carthage is one of many options to add the 1Password App Extension API into one's project, but not the only one and we don't want to force all developers to use Carthage or frameworks.

It would be useful to add the Carthage compatibility badge in the README, along with how this support works (pointing to the branch, and explain the reason behind it).

We do mention Carthage in the README, in the Step 1: Download the Source Code and Sample Apps section. See the last paragraph:

The 1Password App Extension API is available via Carthage as well. Simply add github "AgileBits/onepassword-extension" "add-framework-support" to your Cartfile, then run carthage update and add it to your project.

Thanks!

You're most welcome, @dzenbot! :smiley:


✨ Migrate MoJAS CaDeT to APC's KEDA + Karpenter compute

This pull request:

Migrates moj-analytical-services/create-a-derived-table to ephemeral autoscaled compute capability

Signed-off-by: Jacob Woffenden<EMAIL_ADDRESS>

@jacobwoffenden Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

@jacobwoffenden Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs


[Usage] Getting an ImportError:cannot import name 'LlavaLlamaForCasualLM'

Describe the issue
Issue:
I am getting an import error as below. This was after pulling the lastest master version and running pip install -e  .
This used to work in the past when running llava-v1.5.
Command:
 python -m llava.serve.model_worker --host <IP_ADDRESS> --controller http://localhost:10000 --port 40000 --worker http://localhost:40000 --model-path liuhaotian/llava-v1.6-mistral-7b --load-4bit

Log:
[2024-02-03 13:13:22,402] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect)
/home/slaser79/anaconda3/envs/llava/lib/python3.10/site-packages/pydantic/_internal/_config.py:322: UserWarning: Valid config keys have changed in V2:
* 'allow_population_by_field_name' has been renamed to 'populate_by_name'
* 'validate_all' has been renamed to 'validate_default'
  warnings.warn(message, UserWarning)
/home/slaser79/anaconda3/envs/llava/lib/python3.10/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_persistence_threshold" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
Traceback (most recent call last):
  File "/home/slaser79/anaconda3/envs/llava/lib/python3.10/runpy.py", line 187, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/slaser79/anaconda3/envs/llava/lib/python3.10/runpy.py", line 110, in _get_module_details
    __import__(pkg_name)
  File "/home/slaser79/lab/LLaVA/llava/__init__.py", line 1, in <module>
    from .model import LlavaLlamaForCausalLM
ImportError: cannot import name 'LlavaLlamaForCausalLM' from 'llava.model' (/home/slaser79/lab/LLaVA/llava/model/__init__.py)

What version of Python do you have in your environment? I got this error when I used something higher than 3.10

It was python 3.10..I recloned the project and reinstalled the dependencies and now it works! So I think it is related to upgrade instructions.


fix: fixed the notify triager workflow

The current workflow has an error in which it calls the code reviewers also when the changes are only in the md files
Fixed that by adding a check
fixes : #3214

Summary by CodeRabbit

New Features

Enhanced workflow for pull requests with improved commit message processing.
Introduced a new step to retrieve all changed files, streamlining the review process.

Bug Fixes

Updated conditions for adding reviewers based on the count of changed files, ensuring accurate reviewer assignments.

Tested the workflow here
https://github.com/sambhavgupta0705/asyncapi_website/pull/5
cc: @akshatnema @anshgoyalevil @devilkiller-ag

/bounty

@asyncapi/bounty_team

/update

Does this PR need to be reviewed also by @akshatnema before it can be merged?

@anshgoyalevil @akshatnema @aeworxet  I have updated the PR
You can review it now
in this we have removed the tj-actions workflow and have written our own workflow with git-diff


Improve ovn version mismatch checks

Removes the event implementation and relies solely on scenarios with better wording to clearly cover
both cases of major and minor release upgrades.

It looks good to me!


Lists of players

In the next update
it would be possible to see how many cards of the same player I sold? so as to create the excellent lists, what do you think?

Go to the history tab after clicking on the player.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Done, thanks!

Added, thanks!


Add WebAuthn easy public key access

This is a Baseline 2023 feature.

Note that getTransports() was implemented in the same releases of Firefox and Safari, but it doesn't seem related. I guess it was easy to implement and was nearby in the spec.


Please allow us to modify the commit message format

From @StephanBijzitter on February 1, 2018 9:58
After this pull request: https://github.com/dependabot/dependabot-core/pull/244
Our commitlint started to fail, since we do have it set up to expect chore(dependencies): . It's nice that you cater to the Angular project, but this is a breaking change for us. Now we can modify the commit message when squash merging, but that still leaves every pull request with a red cross.
To take a piece of code from the pull request, we would expect the message to be: "chore(dependencies): bump business from 1.4.0 to 1.5.0" (notice the b in bump, not B)
So, please allow us to configure this message to our liking. I'd open up a pull request myself, but I have no experience with Ruby. If you agree this is a wanted feature, but you don't have time for it, I'd love to give it a shot though!
input: build: Bump commander from 2.12.2 to 2.13.0
   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
   found 1 problems, 0 warnings

Copied from original issue: dependabot/feedback#82

From @deivid-rodriguez on February 4, 2018 16:13
I know this would be definitely more work but projects use lots of different commit message conventions, it'd be nice if dependabot played nice with everyone via configuration.
Ideally I'd like to be able to tell dependabot specifically the template for the commit message I want, like:
Bump %{library} from %{original_version} to %{final_version}.

From @deivid-rodriguez on February 4, 2018 16:13
I know this would be definitely more work but projects use lots of different commit message conventions, it'd be nice if dependabot played nice with everyone via configuration.
Ideally I'd like to be able to tell dependabot specifically the template for the commit message I want, like:
Bump %{library} from %{original_version} to %{final_version}.

@greysteil Are there any plans to support custom commit messages in the future?
My specific use case is including [ci skip] in the commit message.
https://gitlab.com/help/ci/yaml/README#skipping-jobs

It's come up quite a few times, so we almost certainly will in future. It's not imminent, though - won't be before the end of the month.

With dependabot-script you might be able to hack it and overwrite the branch namer...

@greysteil Thanks for the quick response!
Pardon my ruby inexperience, should I be able to pass pr_message_footer to pull_request_creator class. https://github.com/dependabot/dependabot-core/blob/master/common/lib/dependabot/pull_request_creator.rb#L36
As far as Gitlab is concern this string can be included anywhere in the commit message

Great to hear! Yep, we use that footer when passing through all the Dependabot-specific PR text from main Dependabot (commands, compatibility scores, etc.). It's perfect for your use case here 🙂


Update shapemap, shex, shextest to 0.1.106

Updates

es.weso:shapemap
es.weso:shex
es.weso:shextest

from 0.1.91 to 0.1.106.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "es.weso" } ]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #475.


Single access point for experiments

Currently provide and document two ways to run experiments - one using a dictionary and second using config files.  Will remove the dictionary experiment and offer only config files.

HI, I am excited to find your repo. I followed your starting step, using python experiment.py example dqn, but it arose a KeyError: 'example'. Could you please help me to fix the error? thanks.

Hi - thanks for the interest.
What do you have in the folder energy_py/energy_py/experiments/datasets/example ?

I cloned this repo to my computer. That folder contains two csv files, namely observation.csv and state.csv. I guessed that is a demo and ran using that command.

You are right that this is a demo.  I can only reproduce your error if I remove/rename the example folder from energy_py/experiments/datasets
Try
$ cd energy_py/experiments/datasets

$ python -i __init__.py

>>> registry.keys()

After doing this I get dict_keys(['__pycache__', 'example', 'tempus']) because I have the example dataset plus one for Tempus work (the pycache shouldn't be in there really :))

It's so strange. I did this and got dict_keys(['example']). But it still arose that KeyError when I ran the demo. :(

@honglinwen - I just pushed up a change
def get_dataset_path(dataset_name):
    return registry[str(dataset_name)]

I also added some protection into the BaseEnv class init
Theory being perhaps it's the encoding of the string?

I tried running it on windows and mac, both showing the same error.

When the package is installed, the current directory of the datasets folder is the installed version.
When using develop, the current directory of the datasets folder is the repo version.
The installed version does not include the example directory:
ls  ~/.pyenv/versions/energy_py/lib/python3.6/site-packages/energy_py-0.2-py3.6.egg/energy_py/experiments/datasets

__init__.py	__pycache__

In setup.py the packages are being defined as packages=find_packages(exclude=['tests', 'tests.*']), . The find_packages will only include directories which have __init__.py files in them - which experiments/datasets/example does not have.
You're using package_data = {'':['*.csv']} to add CSV files but I don't think it's doing what you want.

I've added a PR which should solve it  by installing the files as package_data - but check https://docs.python.org/2/distutils/setupscript.html#installing-package-data for the difference between package_data and data_filesto determine if this is the correct fix.

Thanks @tomharvey - the whole reason for doing this complex dataset finding stuff was to avoid this issue (of where the package is installed versus where it was cloned too) - seems it didn't work!
I'll have a look at this over the next day or so and try to make some changes.
In the meantime - @honglinwen and @samarthiith - can you run python setup.py develop to install the package and see if that fixes your issue?  If it fixes it I will change the readme as a bandaid until a proper fix is in place

If you don't want the CSV files in the package then passing a path to the dataset into the command would be a better option. Something like python experiment.py dqn --dataset ~/datasets/example

thanks @ADGEfficiency @tomharvey  it works :+1:


Auto-create step with new file

Describe the problem this improvement solves
When I create a new file, I want to immediately add it to a step, so that there are fewer clicks in my workflow.
Describe the solution you'd like

Add a checkbox to the new file form
Potentially remove new file dialog
Figma file

Screenshots

I think the copy for the checkbox should be "Create a new step for this file"
Also, I think the checkbox can be auto-checked as I believe that's the common case, for when creating the file in the file manager integrated into the pipeline editor.
Files created in JupyterLab (or in VS Code/PyCharm with the SSH workspaces feature coming up, won't have this dialog naturally).


Actually use the request methon in thruster_testing::request

The request method is the generic version for the thruster_testing request methods, and is the only way to pass headers when writing tests.
However, despite allowing the developer to write the method as a String, ot only allows testing GET methods, as the route resolver does not use the method param:
https://github.com/trezm/Thruster/blob/master/thruster-app/src/testing.rs#L26

🤦♀yes, you are absolutely right!  I'll be able to fix this in the next few days, or feel free to put up a PR if you beat me to it!


Not working

Issue Type: Bug
Visual studio code isn't properly working. The extensons are workng. But, the options which are shown when we right a tag name s not shown. The auto enclose tag name in angular brackets is also not working. I have also tried switching the extensions on and off. Please resolve the issue.
 Welcome!
You were using the Issue Reporter tool in vscode directly huh?
Your issue title needs improvement! Try to come up with a short and descriptive title for the problem.
If you're having multiple issues: Open multiple reports. One for each problem.
Please do not ignore the Steps to Reproduce. Without them there will probably be no one helping you.

Hello @naffydharni006, In addition to what @ewerybody has said, please take some time and read this guide on how to make a good bug report.

I have now deleted VS Code because it was creating some issues with my PC

And because of this the issues are gone now, right? 😑
Ok. pardon me. I know you were trying to help.


Upload logo

Hi @triat i upload logos and update readme file.

Coverage remained the same at 100.0% when pulling e2830b1a628cc9691081da3fba6581088b1e37c1 on mirzazulfan:master into 0ed7479f33aa1a8e90bddf89e329e77baf6eb753 on triat:master.


Alternate Fan Settings Needed for Optical Cable Case

[ ] Test plan
[ ] Verify Test use case
[ ] Automate

On Fri, Mar 01, 2019 at 05:38:27PM +0000, Marissa Garza wrote:

Created to cover scenario from Defect SW453065

Please don't include references to internal IBM bugtrackers.

[ ] https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/19241/

Merged


Release 0.1.1

### v0.1.1

* Convert all depths to ints. #27

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


socket.error when getting the internal IP address

Hello,
The instruction x.connect(("<IP_ADDRESS>", 80)) (https://github.com/adaptivethreat/EmPyre/blob/master/data/agent/stager.py#L599) causes an error (socket.error: [Errno 51] Network is unreachable) when the target's IP address is not in the <IP_ADDRESS> network (in my case, it was <IP_ADDRESS>). I don't know if it is very important to get the internal IP address at this stage since one can just do a (shell ifconfig) when interacting with the victim. Or may be there is a better way to get the IP address. At the very least, we could add a try/except for this instruction.

Hello, thank you for the issue report. I currently tested a fix using "socket.gethostbyname(socket.gethostname())" and it seems to be working well. Try that if you can and we'll do some more testing on this end as well. Hope to close this soon.

That's perfect, it works on my OSX El Capitan and gives the right internal IP address. thanks for the fix.

Excellent! We're pushing a fix to the dev branch which will soon become the next version merge. Thanks for your help!


WMDP-123: Add linting, logging, and several other core utils for API

Ticket
https://wicmtdp.atlassian.net/browse/WMDP-123
Changes
Added the following linters:

Spectral (openapi validation)
isort & black (formatting)
flake8 (bad practice catcher)
mypy (type checking)

Makefile to help coordinate the linters.
Logging so we can see what is going on when it runs.
Various other utilities that I just grabbed along the way that'll be needed:

Response object creation
API auto-reload on code change

Context for reviewers
If you've worked on Mass PFML, you probably recognize a lot of these patterns.
I shuffled a few bits around like how the app is initialized to follow the Mass format (ie. the app creation is shoved in a function so we can use it for testing when I do that next).
I created a basic API with the relevant classes mostly to validate the type checking + spectral.
Testing
Here is the current output of running make lint. Fixed all the code issues, and when the API actually gets built out, will fix these minor spectral warnings.

Here's what the logging looks like including an auto-reload.

@rocketnova - FYI I updated the Makefile to let you specify whether you want to run inside the Docker container or not for python scripts. Just requires flipping an env var to switch.
Also brought in some CI configurational differences on the linting, although didn't test them.
Will merge if no further questions tomorrow morning.


Unable to submit ad-free application with FirebaseAnalytics.framework (IDFA rejection)

Hello, guys!
I'm, trying to submit my application to AppStore.

If I click "Yes" near "Do you use IDFA" iTunes expected to check one of these options:

I can't move forward with not options selected. But if I clicked some options iTunes reviewers asked me to specify where ads are available in the app. (in short: no ads - no IDFA in the app)

If I click to "No", iTunes detects that IDFA is used in the application, so I can't move forward.

Problem: I unable to upload an application with FirebaseAnalytics without a real advertisements. (https://developer.apple.com/library/content/documentation/LanguagesUtilities/Conceptual/iTunesConnect_Guide/Chapters/SubmittingTheApp.html#//apple_ref/doc/uid/TP40011225-CH33-SW8)
--
I used Google Analytics before FirebaseAnalytics (https://github.com/danwilson/google-analytics-plugin/issues/218). GA uses AdSupport.framework dynamically. So I was able to remove AdSupport.framework and GS still works without Gender/Age/etc tracking well. I don't want to switch back to GA, but I can't use FirebaseAnalytics too...

Have you tried clicking on the last 2 options? I think they are the appropriate ones. You don't need to serve ads in your app to attribute them. Sometimes, a Search Ad (say Apple Store Search Ads) can lead to an app installation and the IDFA helps attributing the installation to that Search Ad.

Thanks, I will try to submit.

@bushev closing this issue since it's staled, feel free to reopen if you're still running into App Store issues.

@bushev im on situation now. Did Apple accepted ur app after doing what @baolocdo said?
Thanks