update internal, package, prepare to use lang/english

Description
code cleanup, using lang/english
...
Related Issue
Fixes #1341
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

@Racer159 ready for review, updated from main


[WIP] SourceMorph (GSoC 2018)

This PR is about updating the SourceMorph class to morph (Vol)SourceEstimate + tutorials and examples.
To do:

[x] discuss compute_morph_matrix
[ ] hope for checks
[ ] convince people to merge :)

Hey again regarding depreciation: we deprecated morph_precomputed and morph_data but agreed for some reason to not depreciate compute_morph_matrix
if I remember correctly because it would be too much pain (because it's used overall)
could we deprecate it nevertheless and I fix all issues that might occur? The morph_mat can e.g. also be accessed from SoureMorph.params

Hey again regarding deprecation: we deprecated morph_precomputed and morph_data but agreed for some reason to not deprecate compute_morph_matrix

Can you look through the various issues and PRs to figure out what we settled on? I don't remember the details. But to me it does not make much sense to deprecate just morph_precomputed without also deprecating compute_morph_matrix. The latter is typically only used with the former.
I think at this point I'm okay with deprecating compute_morph_matrix, too. Maybe tell people in the docstring of compute_morph_matrix the equivalent one-liner that they can use, probably something like:
morph_mat = SourceMorph(...).params['morph_mat']

@TommyClausner please have a look at @larsoner 's comments and i'll do another pass.
If there is a question to discuss API wise besides compute_morph_matrix?
compute_morph_matrix and morph_data are used in plot_morph_data.py
To fully see the API transitioned this example should be updated.
Once done does it make the code as simple / fast?

Hey @larsoner yes it's indeed a bit of a pity, but maybe you're right...
The thing is just, that I'm not quite sure about your definition of "refinement" because often so far it happened that I produced version A, was asked to make version B and after another round version A*
I guess this is mostly because you (mne) didn't commit fully to throw away previous API - if you would, we could rebuild it from scratch (and hopefully better) and include some temporary wrappers for the deprecation cycle - thoughts?
but of course I finish it for now including all suggested ;)
@agramfort compute_morph_matrix and morph_data are sometimes "abused" to do some things in e.g. testing files or examples or in labels or etc. - so I'll deprecate it now and fix all those things...
I guess it makes the code not "as simple" because difference is (in that particular example):
moprh_mat = mne.compute_morph_matrix(**stuff)

vs
moprh_mat = mne.SourceMorph(**stuff).params['morph_mat']

Comp time wise it should be equal to the pre-computation pipeline you had before (I use those functions)

Thanks @massich !

Yes, @larsoner sounds like a plan ! Thanks for pointing towards the important issues!
regarding 2 and 3) : doable, but bit annoying, since for vol it has way more parameters... so guess some dictionary in the back might be needed for this type at least I guess, ... but dk...
Also it was @agramfort 's explicit wish to put the computation in __init__ and make each **kwarg an attribute... So I guess that's between you guys then :D
But in general, yes I'll proceed as you suggested!

btw: also: how would you like me to "submit" the stuff actually? atm I'm just trying to integrate the version I have now (including suggestions) and abuse the PR for testing, but how do I submit it finally?

why can I not delete compute_morph_matrix from python_reference.rst?

You'll have to be more specific as to what you mean. You should be able to delete it from python_reference.rst, use the @deprecated decorator on it, and wrap any calls currently in tests with with pytest.deprecated_call context manager and tests should pass.

how would you like me to "submit" the stuff actually

This is good enough -- let's get things green here. Once that's done I can push a morph branch and we can open a new PR to it rather than master, which should also come back green and we can merge it there.

Hey @larsoner  thanks! Thing is: I decorated it with deprecated but it doesn't let me delete it from the .rst anyway...

nope...

but it doesn't let me delete it from the .rst anyway...

Again I'm not sure what this means. Do you get a doc build error? Does some test not pass?
Luckily I happened to be on GitHub to see what you actually did. You had some conflict when you did it. This means you need to rebase (preferably) or merge with upstream/master. But since you have a ton of commits (and a number that switch back and forth between states) this might be difficult. So for now you can leave it in so it is not a bottleneck and we can fix it later. I assume there are more important issues to work out still...?

well actually I guess I'm done in the sense that I implemented the suggestions and e.g. did not delete the sparse part, so that you have it there when you refine it... In general it passes all my tests and all random examples I tried that e.g. use compute_morph_matrix I changed and they work as well...

Let me know when the CIs are happy, or ping me if you are unsure how to make them happy

all right ;)
just as a note - Google says I have to submit until tomorrow 18:00 - does this mean accepted by you?

Hmmm... not sure. But to be safe I've pushed a sourcemorph branch. Let's see if CIs come back happy and either way close this and open a PR to that branch. Hopefully it's green but even if it's not we'll accept it there so there is no ambiguity :)

All right thanks a lot!! I'll wait for them to complete here (to not waste time waiting ;) ) - and after correcting close here and PR there... :)

That's indeed a little bit strange, since the volume that is created internally to apply the morph is the size of the reference MRI... For that reason I assume you have a really long time series(?) Maybe you could try down-sampling your time dimension(?)
On the other hand @larsoner and @agramfort - what do you think? Would a sparse make a significant difference here / should it be considered?

Any ideas? If the mri_shape is huge could a sparse matrix be used as an alternative?

I don't know enough about the nonlinear warp to know if this is possible. But to start we could loop through time chunks like you suggest.

hm... as far as I can see, the bottleneck would be dipy.align.reslice.reslice - if that function takes sparse matrices, then it should work.
Because the memory issue happens, where stc.data gets extrapolated to full MRI-resolution. For this a 4-D volume is created of zeros and filled. If the t-dim is too huge you get the error there (np.zeros) I assume. Afterwards the full-res series goes into dipy.align.reslice.reslice - so again:
if supported by dipy, one could make the result volume of _interpolate_data a sparse matrix (working internally completely with sparse then) and re-slice it as is (given dipy supports sparse) - but other than that I could indeed only think of looping :/

@TommyClausner @WilliamCollishaw @larsoner this commit https://github.com/mne-tools/mne-python/pull/5466/commits/40da488de52b495fed0c4fa2c1d9c21dad6db40c should fix the memory issue. It's now in https://github.com/mne-tools/mne-python/pull/5466


Vanilla extended brewing can't added on cooking workbench

I'm playing multiplayer with multifaction on 1.4 version.
I added vanilla extended brewing.
But i can't added it on cooking workbench.

Closing since:

We no longer support 1.4, only 1.5
There's no logs
The message doesn't really explain what's broken, and I'm not going to start guessing what the issue may be


In ISAjson export a unit @id is being used despite no units being declared

A unit @id value is being given in multiple places (example here) despite no units being declared in unitCategories.
Example from this Project
Note: At this point there is no way to add units to any of the attributes in the dynamic table. So there are not units to declare. The error might be on generating values for the @id of units when no units are rightfully not declared.

All the related ids are no longer being created by the exporter.


Rename sqlite.py

Although sqlite.py is a valid name for the module I would like to standardise all official modules to use __init__.py and will eventually drop support for module entry points with the same name as the module.

Wow true, I'm using a reserved name!


Issue fix 401

Description
Closes #401
Questions to reviewer:

For now we bumped the version to 2.0.1 since we changed the source file
- alternative just change the Version 2.0.0
left the MS 2&3 Checklist, since I'm not sure if it has to be confirmed again.

MS2 Criteria
(to be filled out by PR reviewer)

[x] the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check  (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The  SAMM CLI is available here and in GitHub
[x] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[x] the identifiers for all model elements start with a capital letter except for properties
[x] the identifier for properties starts with a small letter
[x] all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
[x] Property and the referenced Characteristic should not have the same name
[x] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[x] use abbreviations only when necessary and if these are sufficiently common
[x] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[x] fields preferredName and description are not the same
[x] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[x] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[ ] units are referenced from the SAMM unit catalog whenever possible
[ ] use constraints to make known constraints from the use case explicit in the aspect model
[x] when relying on external standards, they are referenced through a "see" element
[x] all properties with an simple type have an example value
[x] metadata.json exists with status "release"
[x] generated json schema validates against example json payload
[x] file RELEASE_NOTES.md exists and contains entries for proposed model changes
[x] all contributors to this model are mentioned in copyright header of model file

MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)

[ ] All required reviewers have approved this PR (see reviewers section)
[ ] The new aspect (version) will be implemented by at least one data provider
[ ] The new aspect (version) will be consumed by at least one data consumer
[ ] There exists valid test data
[ ] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[ ] The model has at least version '1.0.0'
[ ] If a previous model exists, model deprecation has been checked for previous model
[ ] The release date in the Release Note is set to the date of the MS3 approval

@LuisRickert Could you please check my comments.

@LuisRickert  any updates on this model?

@LuisRickert  is this model ready for MS2 check?


luci-app-commands: Add hint for unsupported chars

Do not escape pipe on cmd line
closes #1622

NACK, lets fix the underlying issue instead.

@jow regex on parse_cmdline function not escaping the pipe.

Are you sure the proposed patch is correct? Shouldn't | be put into the [...] ?

I will try and disassemble the regex.
But with this test command ls -la /dev | grep tty  it works for me.

@jow- As expected, you're right. My carelessness
I have update the pull-request
Before:

After:

Should we add < and > as well?

I am not sure if this make sense. Because the output of a command is already redirected. See source. I think the pipe is the missing part to concatenate the commands. But that`s only my point of view.
https://github.com/openwrt/luci/blob/3c40a7450a9b7d340cdc9e233818c63a8092fec2/applications/luci-app-commands/luasrc/controller/commands.lua#L155-L170

@jow- ping any objections from your side? If not I will merge this for now if we need also < and > I will add this later.

No, please go ahead


Grid using only xs breakpoint during print on Chrome

When I try to print my page with Grid responsive layout, it seems to use xs breakpoint on Chrome v. 62.0.3202.75 even if higher breakpoint is also set

[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
I have grid layout with multiple elements and responsive breakpoints sm and xs to display them in row on larger screens, and in column on small ones.
When I want to print my page to pdf using window.print() and A4 format, I should be able to replicate my layout
Current Behavior
On Chrome  only xs breakpoint applies so elements appear in column, on Firefox, Safari they are displayed in row.
I'm assuming that this is more about how different browsers treat A4 format screen size, but maybe somebody has already experienced this issue, or could provide better explanation of screen sizes.
Steps to Reproduce (for bugs)
https://codesandbox.io/s/jpkw9y4959?module=%2FLayout.js
Context
Trying to print pdfs and layout is broken in chrome (pretty much everything is displayed in one column so paper space is wasted)
Your Environment
Only tested in desktop versions.

Tech
Version
Bug

Material-UI
1.0.0-beta.20

React
16.0

Chrome
62.0.3202.75
yes

Firefox
56.0.2
no

Safari
11.0.1
no

I'm assuming that this is more about how different browsers treat A4 format screen size, but maybe somebody has already experienced this issue, or could provide better explanation of screen sizes.

Yep, Chrome seems to consider the screen width to match the xs breakpoint [0-600[.
There is no much I see Material-UI can do about it. I have been looking at what Boostrap is doing; https://github.com/twbs/bootstrap/issues/16800. The issue hasn't received much traction.
Best option seems to:

Look if you can change the print width
Write some media print specific CSS

This helped https://stackoverflow.com/a/26647922
@media print {
  body {
    min-width: 1200px;
  }

Is there any update to this? This is still the case with MUI 5 and Chrome

This still seems to be an issue with MUI 6.1.1 and Chrome. When printing, it renders the Grid2 in a mobile view in regards to breakpoints (xs or sm, but not md) but I feel it should break for md? Does a page not render more than 960px? Perhaps there's a way to set this easily that I'm overlooking?


Adds a rules table row for bazel-bats.

This is a set of bazel rules for bats-core (https://github.com/bats-core/bats-core).
Fixes #70.

Thanks!


Add define="_WIN32_WINNT=0x${ver}"

Describe the pull request

What does your PR fix?
Fixes Boost::log errors on windows 11

Which triplets are supported/not supported? Have you updated the CI baseline?
x86-windows
x86-windows-static
x64-windows
x64-windows-static

Yes

Does your PR follow the maintainer guide?
Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

I'll work further on this in another branch, and clean it up.


Failed to install the dependency in setup_cpu.sh

I am following the BKM to set up the environment.
I use  the latest miniconda:
8a324adcc9eaf1c09e22a992bb6234d91a94146840ee6b11c114ecadafc68121
When I am running this step:
conda install --name s2sv --yes pytorch=0.3.1 -c soumith
it throws the error message which seems couldn't find the package.
I didn't quite understand since these 2 lines seems both want to install pytorch but different channel
https://github.com/HendrikStrobelt/Seq2Seq-Vis/blob/2452e4226449984dd861330e911d522a39b21128/setup_cpu.sh#L9-L10

Oh I see the difference.
The first line want to install pytorch through soumith  channel.
The second line want to install faiss-cpu  through pytorch channel.
But I failed to install pytorch with the error message:
`Collecting package metadata (current_repodata.json): done
Solving environment: failed with current_repodata.json, will retry with next repodata source.
Initial quick solve with frozen env failed.  Unfreezing env and trying again.
Solving environment: failed with current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed
Initial quick solve with frozen env failed.  Unfreezing env and trying again.
Solving environment: failed
UnsatisfiableError: The following specifications were found to be incompatible with each other:
Package libgcc-ng conflicts for:
pytorch=0.3.1 -> libgcc-ng[version='>=5.4.0']
python=3.6 -> libgcc-ng[version='>=7.2.0|>=7.3.0']
Package libstdcxx-ng conflicts for:
python=3.6 -> libstdcxx-ng[version='>=7.2.0|>=7.3.0']
pytorch=0.3.1 -> libstdcxx-ng[version='>=5.4.0']
Package libffi conflicts for:
python=3.6 -> libffi[version='3.2.*|>=3.2.1,<4.0a0']
Package cudatoolkit conflicts for:
`

Hi @HendrikStrobelt
I suspect this error relates with the miniconda version.
Could you share with us which miniconda version did you use in the BKM?

Miniconda 4.5.1 solves the problem.
https://repo.continuum.io/miniconda/Miniconda3-4.5.1-Linux-x86_64.sh


Enlarged getStatus for Elster FLEX-1517

FLEX-1517

This pull request makes the build fail.

This pull request makes the build fail.

SonarQube analysis reported 7 issues:

 7 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Remove the unused method parameter(s) "deviceResponseHandler,ipAddress,domain,domainVersion,messageType,retryCount,isScheduled".
 Remove the unused method parameter(s) "ipAddress,domain,domainVersion,messageType,retryCount,isScheduled".
 Method has 10 parameters, which is greater than 7 authorized.
 Method has 10 parameters, which is greater than 7 authorized.
 Method has 11 parameters, which is greater than 7 authorized.
 Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
 Method has 10 parameters, which is greater than 7 authorized.

All is well.


Enable CI with Travis (closes #4)

Add .travis.yml and badge to the readme.md

LGTM. Please, @gerson24 have a look at this. @nikdon thanks for contributing!


Do not show Cancel button on First Render / without focus

When showsCancelButton is set to true, on first render, the Cancel button will appear on the screen even with no text entry in the Search Bar and no focus:

The Cancel button should only appear when the SearchBar has been focused.

Duplicate of https://github.com/umhan35/react-native-search-bar/issues/84


Add go module, replace deprecated ioutil, and add missing test error checks

This PR:

Adds a go.mod and go.sum to the repo
Removes the use of the deprecated ioutil package
Adds a couple of missing error checks in tests (caught by linter)

Archiving this repo; closing.


chore(docs): aztec-up doesnt need latest, remove warnings around sandbox/cli npm pkgs

its been long enough that we don't nede to tell people to not use aztec-cli or sandbox npm pkgs

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit f35bdb84 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,380
179,492
716,036

l1_rollup_calldata_gas
221,180
866,372
3,448,076

l1_rollup_execution_gas
928,952
3,900,186
24,034,547

l2_block_processing_time_in_ms
1,462 (+4%)
5,251 (-3%)
21,557 (-1%)

note_successful_decrypting_time_in_ms
308 (-2%)
919 (-8%)
3,299 (-2%)

note_trial_decrypting_time_in_ms
22.1
48.4 (-69%)
139 (+1%)

l2_block_building_time_in_ms
16,031
63,618
255,294 (-1%)

l2_block_rollup_simulation_time_in_ms
11,667
46,367
186,161 (-1%)

l2_block_public_tx_process_time_in_ms
4,330 (-1%)
17,164 (-1%)
68,847 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,299 (+1%)
31,208 (+3%)

note_history_successful_decrypting_time_in_ms
2,206 (+3%)
4,332 (+3%)

note_history_trial_decrypting_time_in_ms
136 (+35%)
193 (+8%)

node_database_size_in_bytes
3,582,962
3,646,479

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
211 (-1%)
44,681
25,561

private-kernel-ordering
165 (-1%)
43,753
14,809

base-rollup
1,192 (-1%)
128,338
881

root-rollup
78.8 (-1%)
4,088
677

private-kernel-inner
291 (-1%)
71,208
25,561

public-kernel-private-input
205
31,863
25,561

public-kernel-non-first-iteration
203
31,905
25,561

merge-rollup
7.62 (-1%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,219

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
373 (-1%)
1,081 (-1%)

Metric
1 public data writes

tx_sequencer_processing_time_ms
535 (-1%)


README: ✍ added Table of Contents

Thank you so much for the contribution @nitinmewar !
Is there any way you can split the two commits contained in this PR into separate PRs? One for returning an error with cel-key and the other for updating table of contents?

@nitinmewar if you implement the suggestion on #1081 , we will merge that first and rebase this PR on top once you've implemented the changes requested here.

@nitinmewar can you rebase this on main?

@renaynay yes sure!!

@renaynay I am trying to rebase my toe branch to main but it is saying branch is up to date. what am I missing?

git rebase -i upstream/main
make sure this repo is set as upstream

@renaynay what should I do now?

from lint error:
README.md:37:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:38:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:39:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:58:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:59:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:60:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:78:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:79:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:80:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
Error: Process completed with exit code 1.

@nitinmewar, try running  markdownlint --config .markdownlint.yaml '**/*.md' --fix, if it does not work, you should fix markdown lint errors manually

Codecov Report

Merging #1082 (1319a45) into main (4618e2b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   56.58%   56.61%   +0.03%
==========================================
  Files         135      136       +1
  Lines        8994     9063      +69
==========================================
+ Hits         5089     5131      +42
- Misses       3369     3391      +22
- Partials      536      541       +5

Impacted Files
Coverage Δ

fraud/bad_encoding.go
63.00% <0.00%> (-3.00%)
:arrow_down:

node/services/service.go
80.83% <0.00%> (-0.93%)
:arrow_down:

params/network.go
76.92% <0.00%> (ø)

service/state/core_access.go
11.59% <0.00%> (ø)

header/sync/sync_head.go
58.77% <0.00%> (ø)

header/verify.go
82.22% <0.00%> (+0.82%)
:arrow_up:

header/header.go
50.00% <0.00%> (+3.22%)
:arrow_up:

header/sync/sync.go
69.50% <0.00%> (+4.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Still failing

Yes please @nitinmewar


Port needs to be changed from 1401 to 1433.md

For existing SQL virtual machines, open your SQL virtual machines resource and select Security under Settings. Select Enable to enable Azure Key Vault integration.
Port number: 1401 - is leading to confusion as customers changes the port from 1433 to 1401, assuming that the port 1401 is meant for AKV which needs to be changed at the SQL Blade from the Azure portal.

@SaniyaSamreen14 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Hi @SaniyaSamreen14 , thanks for your submission! I just realized this article is now in a different repository, so I'm going to manually redo your change in a private PR and publish it this week. My apologies for the delay and thanks so much for improving our docs!
I'll close out this PR but please let us know if there's anything we can help you with.
Thanks!
Masha from the SQL Docs team
#please-close


Add debug flag as an input argument

@alejoe91 currently, it looks like the debug parameter is true by default so only the first 2 streams get written. We should probably make this an input argument right if it has not been done already? I can make this change if needed

Fixed


aws: consider reverting to instance storage

EC2 instance storage was removed in ff24d62 as a 8GB root partition was mounted per default, which is not enough for a deis instance.
As docker containers and ceph data are now stored on a separate partition, instance storage might be an option again and should be reconsidered as it is faster, free and independent from network troughput.
Remaining questions:

[ ] Can the instance storage be mounted as a single 32gb root partition?
[ ] Are any fast growing files / folders still using the root disk?

:+1: Some background - we added the EBS-backed root partition because an 8GB root partition was far too small.
@johanneswuerbach how did your research go with this?

@carmstrong sorry for the delay.
CoreOS does not provide instance store based AMIs at the moment https://github.com/coreos/bugs/issues/177
The 8GB you saw in the past is the default volume size for an EBS on AWS.


update [DubDownload] service test for reliability

The specific version total downloads service test is frequent timeout failure in the daily test runs. This changes the target pacakge used for the test. In my local env, with this new target the test runs in < 1 sec. vs. the original package which ran in ~10 secs.
https://circleci.com/build-insights/gh/badges/daily-tests/master

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against d9e278883b15183ff2c6af1f1a123e66885dc566


[silgenpattern] When emitting a switch_enum with ownership, pass in t…

…he PGO data.
This is tested by the pgo_switchenum test with +0 enabled that I am going to
commit in a bit.
rdar://34222540

@swift-ci smoke test and merge


Disable single list element?

Is there a class I can add/remove to an element that will disable/enable an item from sorting, but other items in the list are sortable?

Nvm, need to use filter option.

Good :]


initial import of files and structure

Here is another project that I'm getting moved to our little home on github.
Things I know I need to do are the following:

[x] LICENSE
[x] setup.py
[x] requirements.txt
[x] more tests
[x] better README.md
[x] rename test functions to lowercase separated by underscores
[x] remove unneeded self.record instances
[ ] tests for CSVToDict
[x] test for addDate
[x] simplify checking of error message
[x] test str method of MetadataRecord
[x] move record setup out of with per @somexpert
[x] double quotes to single quotes
[ ] add tests for writeTemplateFiles and writeJSONFile

@damonkelley @ldko @somexpert I'd love some thoughts/advice about my tests for this thing,  my first try writing some and don't know if I approached things in a reasonable way.  Still a bunch that could be done for it.
Not a huge rush either.

Do you plan on putting this up on PyPI? If so, you might want to add a long_description to the setup.py. Also, for test organization, one thing to consider would be separating tests into classes based on which function/method/class they test. Haven't looked thoroughly yet, so this may not really apply here, but it's something to keep in mind.

If we eventually will be moving this past Python 2.7, we will probably want to use argparse instead of optparse in m2m.py, as optparse is deprecated since 2.7.

If we eventually will be moving this past Python 2.7, we will probably want to use argparse instead of optparse in m2m.py, as optparse is deprecated since 2.7.

@somexpert good point, and that's probably the thing we would want to do as an issue for a future revision of m2m

that's probably the thing we would want to do as an issue for a future revision of m2m

Now we have issue #2 to change from optparse to argparse

Looking at the tests more, one thing I notice is that PEP-8 recommends that method names use lower-cased words separated by underscores.

I don't see a test for CSVToDict. It doesn't appear that it's called anytime except for command-line usage, but it would probably still be good to test.

I would add another test almost identical to your very first that sets the addDate arg as True, and tests whether the date is added correctly, that way you test that method with the addDate as both True and False

This is not essential or anything, but I think it wouldn't hurt to add a single test to make sure the str method returns the string you expect it to.

On a much more general note, we should change all quotes to single quotes.

On a much more general note, we should change all quotes to single quotes.

This, along with @somexpert's comment on snake casing the test method names raises an good question.
Are we intending the conform this package to our new code formatting standards, or do we want to maintain the package level formatting standards? (i.e. camelCase, double quotes, ...)

Are we intending the conform this package to our new code formatting standards, or do we want to maintain the package level formatting standards? (i.e. camelCase, double quotes, ...)

I think we are probably shooting for somewhere in between,  I'm hoping to use this to learn a bit on my end so all of these comments have been helpful.  I'm at the point where it isn't hard to implement them and the scope of this package is small enough that I don't mind taking the time to get them changed over to the way we are trying to do things now.

I think there might be an easier way to test the XML output. Have you played around with etree or objectify?
I personally prefer objectify, but it requires lxml. That isn't a huge deal since pyuntl also requires it though.
Basically what we could do is setup an xml fixture

class TestSomeCase(TestCase):
    def setUp(self):
        xml = """<?xml version="1.0" encoding="UTF-8"?>
            <metadata>
                <creator qualifier="aut">
                    <info></info>
                    <name></name>
                </creator>
                <meta qualifier="metadataCreator"></meta>
            </metadata>
        """
        self.tree = objectify.fromstring(xml)

    def test_some_thing(self):
         # setup the xml tree here
         self.tree.metadata.creator.info = 'Whatever creator'
         self.tree.metadata.creator.name = 'Gio G.'
         self.tree.meta = 'mgottardi'

        # test the function/method
        record = some_function("input")

        self.assertEqual(str(record), etree.tostring(self.tree))

thoughts?

I second the comments Gio and Damon have made on this PR. I think your amount of testing of the map() method is good. As Gio said, I think there could also be tests for CSVToDict and a MetadataRecord with addDate == True. Also, you could add tests for writeTemplateFiles and writeJSONFile, but I can guess why you did not

Current coverage is 47.94%

Branch #1 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.
Review entire Coverage Diff as of 9da5d76

Powered by Codecov. Updated on successful CI builds.

:thumbsup:

@ldko,  yeah I think those things will get cleaned up with issue #3, I tried not to touch m2m.py too much and get tests in place first.  So that's definitely a next step for me.

ah. I heard that earlier, but since you had it without the backslashes earlier and changed it in the PR, I thought I would mention it. :)

:+1:


Upgrade various QT components

Upgrade to QT 5.14.1
Upgrade PyQT to 5.13.2 (They've dropped GPL in the filename, I don't see any mention of license changes)
Upgrade PyQTWebengine to 5.13.2 (They've dropped GPL in the filename, I don't see any mention of license changes)
Upgrade QtWebkit to 5.212.0 Alpha 4

That awesome @imduffy15!
Do you think you can pull @whalebot-helmsman's changes from #1037 here as well? Or would it be easier to do this the other way around? @imduffy15 @whalebot-helmsman what do you think?

@kmike let me combine them into a single one

Yeah huge plus one to merging in with @whalebot-helmsman , we're working towards a common goal in both PRs :)

Closing in favor of https://github.com/scrapinghub/splash/pull/1037#event-3396840136


file browser search

Search: ns u
Result:
Nicktoons Unite! (USA)

Search functionality is now implemented in https://github.com/skylersaleh/SkyEmu/pull/321


Cannot find type ExtractContentIdCallback in scope

I'm getting this error when building. This is happening in THEOplayerRCTProxyContentProtectionIntegration. Can someone help?

Hi @davidwinograd1 ,
The mentioned API was added to the underlying native THEOplayer iOS SDK in version 5.4.1
Is it possible that your dependencies are out of sync and your version of react-native-theoplayer referencing an older iOS SDK?

Hi @Danesz ,
That is possible. I am using the newest version of react-native-theoplayer, and below is my package.json. Are there any dependencies that stick out as needing to be changed / upgraded?
{
"name": "Rokfin",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start",
"test": "jest",
"preinstall": "npx npm-force-resolutions",
"gen:rokfinapi": "openapi-codegen gen rokfinapi"
},
"dependencies": {
"@codler/react-native-keyboard-aware-scroll-view": "^2.0.1",
"@openapi-codegen/typescript": "6.0.0",
"@react-native-async-storage/async-storage": "^1.17.12",
"@react-native-community/cli-platform-android": "^7.0.1",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/netinfo": "^6.0.0",
"@react-native-community/push-notification-ios": "^1.8.0",
"@react-native-community/slider": "^4.4.2",
"@react-native-community/viewpager": "^5.0.11",
"@react-native-firebase/app": "^11.3.3",
"@react-native-firebase/messaging": "^11.3.3",
"@react-navigation/bottom-tabs": "^5.11.8",
"@react-navigation/native": "^5.9.3",
"@react-navigation/stack": "^5.14.3",
"@segment/analytics-react-native": "2.9.1",
"@segment/sovran-react-native": "^0.4.5",
"@skele/components": "^1.0.0-alpha.40",
"@tanstack/react-query": "^4.29.7",
"ably": "^1.2.37",
"ably-react-native": "^1.1.2",
"algoliasearch": "^4.17.0",
"base-64": "^1.0.0",
"immutability-helper": "^3.1.1",
"javascript-time-ago": "^2.3.4",
"jwt-decode": "^3.1.2",
"moment": "^2.29.3",
"native-base": "^2.15.2",
"prop-types": "^15.7.2",
"react": "17.0.1",
"react-instantsearch-hooks": "^6.43.0",
"react-instantsearch-native": "^6.39.1",
"react-native": "0.68.7",
"react-native-animatable": "^1.3.3",
"react-native-app-auth": "^6.2.0",
"react-native-autocomplete-input": "^4.2.0",
"react-native-autoscroll-flatlist": "^1.11.1",
"react-native-background-downloader": "^2.3.4",
"react-native-branch": "^5.0.1",
"react-native-circular-progress": "^1.3.7",
"react-native-controlled-mentions": "^2.2.5",
"react-native-custom-actionsheet": "^0.1.1",
"react-native-fbsdk": "^3.0.0",
"react-native-fs": "^2.17.0",
"react-native-gesture-handler": "^1.10.3",
"react-native-get-random-values": "^1.8.0",
"react-native-google-cast": "^4.6.2",
"react-native-iphone-x-helper": "^1.3.1",
"react-native-keyboard-aware-scroll-view": "^0.9.5",
"react-native-keyboard-spacer": "^0.4.1",
"react-native-linear-gradient": "^2.5.6",
"react-native-modalbox": "^2.0.2",
"react-native-notifications": "~4.1.1",
"react-native-orientation-locker": "^1.3.1",
"react-native-picker-select": "^8.0.4",
"react-native-reanimated": "^2.8.0",
"react-native-redash": "^16.0.8",
"react-native-render-html": "^5.1.0",
"react-native-safe-area-context": "^3.1.9",
"react-native-safe-area-view": "^1.1.1",
"react-native-screens": "^2.18.1",
"react-native-search-filter": "^0.1.5",
"react-native-share": "^8.2.1",
"react-native-splash-screen": "^3.2.0",
"react-native-status-bar-height": "^2.6.0",
"react-native-svg": "^13.9.0",
"react-native-swipe-list-view": "^3.2.6",
"react-native-swiper": "^1.6.0",
"react-native-tab-view": "^3.0.1",
"react-native-table-component": "^1.2.1",
"react-native-theoplayer": "^2.9.0",
"react-native-tracking-transparency": "^0.1.0",
"react-native-video": "^5.1.1",
"react-native-video-controls": "^2.7.1",
"react-native-view-more-text": "^2.1.0",
"react-navigation": "^4.4.4",
"react-navigation-stack": "^2.10.4",
"react-redux": "^7.2.3",
"redux": "^4.0.5",
"redux-thunk": "^2.3.0"
},
"devDependencies": {
"@babel/core": "^7.13.8",
"@babel/runtime": "^7.13.9",
"@react-native-community/cli-platform-ios": "3.0.0",
"@react-native-community/eslint-config": "^2.0.0",
"@tsconfig/react-native": "^3.0.2",
"@types/jest": "^29.5.1",
"@types/react": "^18.2.7",
"@types/react-test-renderer": "^18.0.0",
"babel-jest": "^26.6.3",
"jest": "^26.6.3",
"metro-react-native-babel-preset": "0.65.2",
"npm-force-resolutions": "0.0.10",
"react-test-renderer": "17.0.1",
"reactotron-react-native": "^5.0.1",
"typescript": "^4.9.5"
},
"jest": {
"preset": "react-native"
},
"resolutions": {
"@codler/react-native-keyboard-aware-scroll-view": "^2.0.1"
}
}

Nothing obvious.
Did you call pod install or pod update in your ios folder?

yes, but the issue still arises unfortunately.

Hi @davidwinograd1,
There is most probably something wrong with the pods, because your GoogleAds-IMA-iOS-SDK version is 3.17.0. What's wrong with that?
"react-native-theoplayer": "^2.9.0" relies on 5.5.0 for iOS (unless you override it). If you use the IMA feature with 5.5.0 on iOS, it should install the following extension, which relies on GoogleAds-IMA-iOS-SDK on 3.18.4: https://github.com/CocoaPods/Specs/blob/bffee4746baf745a0ba9f97f60b276ccba377f62/Specs/0/7/0/THEOplayer-Integration-GoogleIMA/5.5.0/THEOplayer-Integration-GoogleIMA.podspec.json#L27
What can you try?

Delete any lock files you have (package-lock.json and/or yarn.lock and Podfile.lock) from your project.
Delete the existing node_modules and Pods folders.
Install the dependencies on your project root folder.
Inside your iOS folder, run pod install --repo-update and verify the versions being installed.

Can you try again after this?
If somehow you can still reproduce it, can you let us know if you can successfully build our example project here?
Kind regards,
Ceyhun


warning: variable 'other_core_owner_id' set but not used (IDFGH-13643)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
5.3.1
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
What is the expected behavior?
I expect no warns build from the sdk.
What is the actual behavior?
When I build my projet on a esp32s3 I have this warning:
[1061/1092] Building C object esp-idf/lidar/CMakeFiles/__idf_lidar.dir/ld19/lidar_ld19.c.obj
In file included from /home/esp/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos/portmacro.h:49,
                 from /home/esp/esp-idf/components/freertos/FreeRTOS-Kernel/include/freertos/portable.h:57,
                 from /home/esp/esp-idf/components/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:69,
                 from /home/esp/esp-idf/components/esp_driver_uart/include/driver/uart.h:12,
                 from /home/esp/esp-pami/esp-qs/our_uart/our_uart.h:11,
                 from /home/esp/esp-pami/src/lidar/ld19/lidar_ld19.c:23:
/home/esp/esp-idf/components/esp_hw_support/include/spinlock.h: In function 'spinlock_acquire':
/home/esp/esp-idf/components/esp_hw_support/include/spinlock.h:78:29: warning: variable 'other_core_owner_id' set but not used [-Wunused-but-set-variable]
   78 |     uint32_t core_owner_id, other_core_owner_id;
      |                             ^~~~~~~~~~~~~~~~~~~
/home/esp/esp-idf/components/esp_hw_support/include/spinlock.h: In function 'spinlock_release':
/home/esp/esp-idf/components/esp_hw_support/include/spinlock.h:176:14: warning: variable 'core_owner_id' set but not used [-Wunused-but-set-variable]
  176 |     uint32_t core_owner_id;
      |              ^~~~~~~~~~~~~
[1091/1092] Generating binary image from built executable
esptool.py v4.8.dev5
Creating esp32s3 image...
Merged 2 ELF sections
Successfully created esp32s3 image.

Steps to reproduce.
I'm not able to reproduce it outside of my project.
I don't understand why there is this warn.
Build or installation Logs.
No response
More Information.
No response

Hi @xmow49,
Thank you for reporting the issue!
We found out about it as well a few weeks back and it has been fixed.
The code fix was already synced with GH master branch (0d140f38ea38deff6b6edf63616e7725b0c7a269).

I will wait the next release (maybe the 5.3.2 ?)
I'm in no hurry.


input type "month" has no styling

input type "month" has no styling
Expected Behavior
input type "month" will show styling similarly to input type "date"
Current Behavior
it does not have any styling
Possible Solution
I downloaded the materialize source code and added input[type='month'] to where input[type='date'] is. It somewhat works so far and
I'm new to github so I don't know how to contribute that "fix" if its even considered a fix
Steps to Reproduce (for bugs)

set input type="month"

Context
using input type="month" to send a get request with said month and year value
Your Environment

Version used: 1.1.0
Browser Name and version: Chromium v104.0.5112.79
Operating System and version (desktop or mobile): Linux Mint 20.03 Cinnamon

Note : Input type month is not supported in Firefox and Safari, only in Chromium-based browsers.
We need to decide which design to choose. In meantime, have a look at https://materializecss.github.io/materialize/pickers.html

wait, does #270 fixes this?


New Line is picked up by Calico along with the hostname

Calico Node v3.17.1 is picking up a \n in the hostname per the below:
startup/startup.go 187: Unable to set NetworkUnavailable to False error=timed out patching node, last error was: nodes "prodrpxapp\n" not found
2021-04-07 05:30:26.982 [ERROR][8] startup/startup.go 200: Unable to set node resource configuration error=error with field Metadata.Name = 'prodrpxapp
' (name must consist of lower case alphanumeric characters, '-' or '.' (regex: a-z0-9?(.a-z0-9?)*))
you can see the \n in the nodes not found and also in the Metadata.Name there is a new line after the node name
I have looked at the hostname and i can not see \n
Expected Behavior

Not sure if it is a bug but could not figure out where is the \n coming from in the hostname

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Not sure how to reproduce. I have many calico nodes running with no issues. this node is failing due to the new line in the hostname during the joining of the node.
Tried to export the NODENAME but calico did not pick it up
Not sure what else to try, appreciate any pointers

Context

Your Environment

Calico version
Orchestrator version (e.g. kubernetes, mesos, rkt):
Operating System and version:
Link to your project (optional):

@ImadNaily strange. How have you installed Calico? Is this just using the normal k8s manifests? And modifications?

The node name is calculated based on this logic: https://github.com/projectcalico/node/blob/7d4be57215df3eafdbbac391c537b097c6192da5/pkg/startup/startup.go#L398-L410
Do you see any of those logs showing up in the calico/node logs for the failing node?

@ImadNaily strange. How have you installed Calico? Is this just using the normal k8s manifests? And modifications?

Standard Manifests installation with etcd store. No modification. Works on control-plane nodes and three other nodes just fine.

it was picking up the name from:
Using stored node name from /var/lib/calico/nodename
once i deleted the file all is up and running thanks for the pointers

thanks

Glad you got it working! Let me know if you see this again - I'm not sure how the newline got into that file. Perhaps it was hand-edited at some point?


Allow events to access data loaded by page/layout.

Describe the problem
In an event handler there is no way to call const myData = await parent()
Describe the proposed solution
The parent function could be made accessible in the scope of an event handler
Alternatives considered
No response
Importance
would make my life easier
Additional Information
Workaround is using hooks to populate locals with the data needed

What are you trying to do? You can access the page store and its data property from anywhere in code running on the browser, including in event handlers.

Sorry, I meant, inside form action handlers (I updated the issue to reflect this)

What's a use case where this is needed / where adding the required data to event.locals is not enough or too cumbersome?

When you have many routes and only want data populated on some of them. Same use cases as loading stuff in layout.server/page.server I guess

But which data of the loaders do you need inside the form action that you can't also get through either passing the data through the form or through event.locals?

Yes I can pass it in event.locals but that negates the whole idea behind load and parent, no?
If you want a concrete example I started implementing user session loading (as suggested by the documentation) in a admin/+layout.server.ts route but I had to refactor that to a hook that instead injected it globally in locals once I tried to use form actions


footnotes support

Not sure what your intentions are with implementing things that aren't in CommonMark, so feel free to close these if they're not relevant, though personally I'd love to see them available here.
Footnotes is a big one for me.

Yes, I intend to implement footnotes, as it's one of the requirements for rustdoc. See https://users.rust-lang.org/t/new-commonmark-parser/1690/20 in particular. It's just a question of when I'll get to it, as I'm pretty busy these days.

Great job @notriddle


vCenter tags for VMs

Description
Allow add / remove / modify vcenter tags in opennebula virtual machines.
Use case
For example, veeam uses this tags for its virtual machines backups.
Interface Changes
vCenter driver, sunstone.
Additional Context
Add any other context or screenshots about the feature request here. Or any other alternative you have considered to addressed this new feature.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Maybe this issue is related with Support for veeam using vCenter annotations

[ONE]

https://github.com/OpenNebula/one/pull/4531

[DOC]

https://github.com/OpenNebula/docs/pull/1072


whether the v0.7.2 can use --fp16 without the gpu type of V100？

whether the v0.7.2 can use --fp16 without the gpu type of V100？I found that I can use others GPU to run with --fp16， and don't have any warning. what 's more, the wps is 7w+.

Sorry, can you please clarify your question for me? You are asking with the latest version 0.7.2 if you can use floating point 16 even if you don't have a GPU that supports floating point 16? I believe the use of fp16 is tied to your GPU, not the version of software.

Sorry, can you please clarify your question for me? You are asking with the latest version 0.7.2 if you can use floating point 16 even if you don't have a GPU that supports floating point 16? I believe the use of fp16 is tied to your GPU, not the version of software.

Sorry, maybe I didn't describe my problem clearly. what I mean is when I training my translation model with nvidia's TITAN V GPU, and use --fp16. I found that the fp16 seems to work, but in my mind, trainning with fp16 Only can be effective on nvidia's V100 GPU.

The --fp16 support depends on the GPU capability. In your case, you seem to have Titav V which has compute capability of 7.0 and that seem to support fp16 (https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#arithmetic-instructions)


"Music support"

Running Ubuntu media server and Windows and Rasplex clients. I use the same Plex account and PT with 2 browser tabs for the corresponding client devices. As host (either device) I select some music which begins playing on host device, on second client nothing plays and the message pops up

Failed to find a compatible copy of

If I then select some media on the second device through the PT app it skips its timing to be in sync with the host even if the media selected is not the same.
To reiterate PT cannot automatically select media but manually selecting it works
All devices are on the local network with ethernet.
Media Server: Ubuntu 16.04 with Plex Media Server <IP_ADDRESS>35-313f93718
Windows 7 Client: 7 Ultimate with Plex Media Player 3.9.1.
Raspberry Pi 2B Rasplex 1.8.0 with Plex Home Theater <IP_ADDRESS>-573b6d73

Music is currently unsupported sorry. I started adding some support last version but it's not complete yet. Hopefully should be there soon but it requires a large amount of work mainly surrounding playqueues which I mentally haven't figured out how to implement.
Technically the only issue here is the /search command not including Music results. If that was fixed everything would sort of work but it would have to keep re-searching every time the track changes - this would be a really really bad experience.

I just had this issue with a video file my first time trying to use PlexTogether with a friend.  Video started playback immediately for me but they received this error on their side.

@psouza4 Most of the time that's because we're hamstrung but Plex's search capabilities and title matching. This should improve in v2 but for the meantime manually playing the content is the solution.

@samcm Do you think there could be some text added to the Synclounge introduction telling users that music is not supported yet?

@Xalaxis It's in the README here on Github but I should definitely add it elsewhere. Sorry about that.

I've landed here for the same reason - tried to sync music and failed. I just double checked the readme and it doesn't say anything about music not working. What's the story?

Can we rename this issue to "Music support" or something slightly more accurate?

Good idea - done.

Any updates on this?

At the risk of being a pain I would also love to see music support in Sync Lounge. App is great BTW. I've just got a self hosted version running on the family chatserver (Matrix-Synapse and Riot).
Unfortunately I also fell foul of a delayed realization that there is "no music support". However in the current difficult times of social distancing and self isolation collaborative and co-operative apps are top of mind.
We've been at home for 6 weeks now here in Sydney and I've got a weekly virtual cards game going with some mates. Riot for vision and chat, Playingcards.io for a virtual deck and table and (I thought) the cherry on the cake would be a shared music space.
I'm happy to get involved to see if I can help to get the music side up and running (no promises of course :-) ) .
Let me know if you want to share your "music support" thinking and issues
Regards
Ian

Any updates on this?

definitely interested in helping to implement this. what is the reason music is separate enough to be unsupported, unlike any other media type? the official plex client(s) don't support this either.


chore: applied clippy fixes of rust 1.74.1

@davide-baldo can we also update the version of rust in this file?

@metaclips Done!

@metaclips Any idea on why it's not finding any version?
error: No stable 1.74.* is available


Author Affiliation

Author Affiliation order is mixed up in 0.3.0, was fine in 0.2.0

Thanks for reporting this.


[ANTLR] Concatenation not recognized.

In the grammar (https://qiskit.github.io/openqasm/grammar/index.html)
indexIdentifier: ...  | indexIdentifier '||' indexIdentifier |...
It will not match strings like a || b. It should be (indexIdentifier | indentifier) '||' (indexIdentifier | identifier).

Never mind. It indeed works.


It is not appropriate to show 'Properties...' on ADLS Gen2 blob containers context menu

Storage Explorer Version: 1.13.0
Build: 20200415.4
Branch: rel/1.13.0
Platform/OS: Windows 10/ Linux Ubuntu 18.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Right click it and check its context menu.

Expect Experience:
It would be much better to show 'Metadata…' instead of the 'Properties…'.
Because we can see the blob container's properties displays on the Properties panel.

Actual Experience:
Show 'Properties...' on the ADLS Gen2 blob container.
More Info:
In Portal, one blob container has Properties and Metadata settings.

By design. It was meant to be consistent with other uses in other places. We may in the future remove the Properties tab entirely.


⚠ Fortnite has degraded performance

In 630c92e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1747 ms

Resolved: Fortnite performance has improved in 64289f0.


A Ride Sharing Website that is useful for all types of people which uses any type of transport.

I am going to create a responsive and dynamic ride sharing website using html, css, bootstrap and javascript

@Saurabh-kumar09 Please assign the issue to me under GSSOC23.


Errors when Running Measure Tool in Docker

I have been unsuccessful in running the Measure tool in both python and Docker. Currently, this is what I am getting when trying to run in Docker:
C:\powercalc\utils\measure>docker run --rm --name=measure --env-file=.env -v %CD%/export:/app/export -v %CD%/.persistent:/app/.persistent -it bramgerritsen/powercalc-measure:latest
Powercalc measure: v0.13.2

2021-12-20 00:31:14,755 [INFO] Selected powermeter: manual
2021-12-20 00:31:14,755 [INFO] Selected Light controller: hue
2021-12-20 00:31:14,755 [INFO] Attempting to connect to the bridge...
2021-12-20 00:31:14,759 [INFO] Error opening config file, will attempt bridge registration
Please click the link button on the bridge, than hit enter..

2021-12-20 00:31:15,883 [INFO] Attempting to connect to the bridge...
2021-12-20 00:31:15,886 [INFO] Error opening config file, will attempt bridge registration
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 735, in connect
    with open(self.config_file_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/app/light_controller/../.persistent/.python_hue'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/app/light_controller/hue.py", line 64, in initialize_hue_bridge
    bridge = Bridge(ip=bridge_ip, config_file_path=config_file_path)
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 628, in __init__
    self.connect()
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 751, in connect
    self.register_app()
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 718, in register_app
    raise PhueRegistrationException(error_type,
phue.PhueRegistrationException: (101, 'The link button has not been pressed in the last 30 seconds.')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 735, in connect
    with open(self.config_file_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/app/light_controller/../.persistent/.python_hue'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "measure.py", line 515, in <module>
    main()
  File "measure.py", line 505, in main
    light_controller = light_controller_factory.create()
  File "measure.py", line 452, in create
    return factory()
  File "measure.py", line 443, in hue
    return HueLightController(HUE_BRIDGE_IP)
  File "/app/light_controller/hue.py", line 17, in __init__
    self.bridge = self.initialize_hue_bridge(bridge_ip)
  File "/app/light_controller/hue.py", line 68, in initialize_hue_bridge
    bridge = Bridge(ip=bridge_ip, config_file_path=config_file_path)
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 628, in __init__
    self.connect()
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 751, in connect
    self.register_app()
  File "/usr/local/lib/python3.8/site-packages/phue.py", line 718, in register_app
    raise PhueRegistrationException(error_type,
phue.PhueRegistrationException: (101, 'The link button has not been pressed in the last 30 seconds.')

The script seems to start correctly but complains about non-existent phue.py and being unable to open the config file.
Any suggestions?

It expects a file /app/light_controller/../.persistent/.python_hue which contains the token from the bridge, so you don't have to click the link button each time again.
This file should be written by the phue library on connection to the hue bridge.
Did you click the link button? Because the exception also says: "The link button has not been pressed in the last 30 seconds"?

Do you still have this issue? Did you see my comments?

Closed due to inactivity, please let me know if you have any update, than we can have another look / reopen the issue.

My apologies, I have been away with COVID.
I guess I wasn't pressing the link button hard enough or something. I am able to get it working on Docker now.

I'm sorry for you, did you recover fully? Hope we can leave the COVID pandamic behind us soon.
Glad you got the measure script working. Do you plan into contributing lights into the repo?

I'm sorry for you, did you recover fully? Hope we can leave the COVID pandamic behind us soon.
Glad you got the measure script working. Do you plan into contributing lights into the repo?

Thank ya! Just a sore throat now. And you and I both!
I just ordered some power measuring smart plugs and will contribute my lights whenever I get them. I have Philips hue LCA002, LCA003's, LWB014's, LCT014, and some Wyze bulbs and LIFX bulbs

That's awesome mate!


Investigate in improving RocksDB filters

Issue summary
In case we want to turn on full bloom filters (see PR #1998), there are some interesting settings to try and performance investigations to do.
When bloom filters are read, those are cached on a per max_open_files basis (currently set to 1024).
This is great but we can have way more .sst files in the db than what is allowed by this hard limit.
A better way to cache the bloom filters would be to put them in a dedicated cache that we control.
set_cache_index_and_filter_blocks set to true put them in the block cache but this would result in competition with the uncompressed blocks.
Partitioned filters should alleviate this problem.
Also to maximize cache usage we should try Ribbon filters, they use less storage bits per key and offer similar false positive (FP) rate than the bloom filters.
Task summary

[ ] Implement cached partitioned filters
[ ] Implement Ribbon filters
[ ] Find appropriate values for cache and bits per key
[ ] Benchmark on a mainnet db
[ ] Analyse rocksdb stats (hit rate, latency, etc)

Acceptance Criteria

[ ] Importing a snapshot is as fast if not faster
[ ] Read latency is overall better
[ ] CPU usage should stay acceptable
[ ] DB should be less big

Other information and links
http://rocksdb.org/blog/2017/05/12/partitioned-index-filter.html
http://rocksdb.org/blog/2021/12/29/ribbon-filter.html

No longer a priority as ParityDB becomes the default.


fixes mulitpule formatting issues caused by recent discord update

fixes issue 37
similar to pull 38, but also fixes other class problems (in username, and setting "delete cache" button)

Looks great. Thank you!!!


THCudaCheck FAIL

I am trying to extract the text representations of CUB birds dataset using the pretrained model that you have provided, but I am getting the following error
THCudaCheck FAIL file=/usr/local/torch/extra/cunn/lib/THCUNN/generic/Threshold.cu line=34 error=8 : invalid device function /usr/local/torch/install/bin/luajit: /usr/local/torch/install/share/lua/5.1/nn/Container.lua:67:  In 2 module of nn.Sequential: /usr/local/torch/install/share/lua/5.1/nn/THNN.lua:110: cuda runtime error (8) : invalid device function at /usr/local/torch/extra/cunn/lib/THCUNN/generic/Threshold.cu:34 stack traceback: 	[C]: in function 'v' 	/usr/local/torch/install/share/lua/5.1/nn/THNN.lua:110: in function 'Threshold_updateOutput' 	/usr/local/torch/install/share/lua/5.1/nn/Threshold.lua:20: in function </usr/local/torch/install/share/lua/5.1/nn/Threshold.lua:18> 	[C]: in function 'xpcall' 	/usr/local/torch/install/share/lua/5.1/nn/Container.lua:63: in function 'rethrowErrors' 	/usr/local/torch/install/share/lua/5.1/nn/Sequential.lua:44: in function 'func' 	/usr/local/torch/install/share/lua/5.1/nngraph/gmodule.lua:345: in function 'neteval' 	/usr/local/torch/install/share/lua/5.1/nngraph/gmodule.lua:380: in function 'forward' 	test.lua:130: in function 'extract_txt' 	test.lua:136: in main chunk 	[C]: in function 'dofile' 	...ocal/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk 	[C]: at 0x00406670

I ran into the same problem as you. Did you solve this problem?


Slack as public chat?

How about having contributors join ArangoDB on Slack (using slackin)?

We are working on that, stay tuned :)
Dave schrieb:

How about having contributors join ArangoDB on Slack (using slackin
http://rauchg.com/slackin/)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/arangodb/arangodb/issues/1787

Gitter would be alright as well :)

@NinoFloris we have had a Gitter chatroom but it is no longer active.

Hi @sinfex as promised.... yesterday we launched our Slack Channel and many people joined already! If you´d like to share your ideas or want a free workshop for your european community it´s the place to go.
You can find it here: https://arangodb-community.slack.com

This is the right link: https://slack.arangodb.com

https://slack.arangodb.com/ returns 500 error.

@mfractal Please use https://arangodb-community.slack.com/

how do i join every time i use my email i get error saying my email isn't associated with the group


optimizing for mac users to use AVX2 FMA

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): mac 10.13.6
TensorFlow installed from (source or binary): 1.12.0 binary

Describe the problem
according to the docs, Note: We already provide well-tested, pre-built TensorFlow packages for Linux and macOS systems. , however, when running that version, I still see our CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
I wanted to know if there were plans to optimize the mac build to take full advantage of the CPU?
Provide the exact sequence of commands / steps that you executed before running into the problem
pip install https://storage.googleapis.com/tensorflow/mac/cpu/tensorflow-1.12.0-py3-none-any.whl
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Hi,
You have to compile it with source in order to specify the compile flags you want.
I normally compile it with the following flags (on a GPU-enabled Linux workstation):
bazel build -c opt --copt=-march=native --copt=-mfpmath=both --config=cuda --config=mkl -k //tensorflow/tools/pip_package:build_pip_package
And I use the Intel Software distribution for Python with Anaconda (https://software.intel.com/en-us/articles/using-intel-distribution-for-python-with-anaconda)
Or you can use this link and download the binary If it matches your software configuration (you should upgrade to macOS Mojave) : https://github.com/lakshayg/tensorflow-build

thanks @pldelisle . I tried all the mojave versions in the tensorflow-build  https://github.com/lakshayg/tensorflow-build but always got the error tensorflow-1.12.0-cp37-cp37m-macosx_10_13_x86_64.whl is not a supported wheel on this platform. with the respective whl file. I also tried compiling from source, but aborted after googling and trying and not succeeded.
Thanks for replying. I think I'll stick with the whl file provided by google.

Make sure you have Python 3.7 installed on macOS. But I recommend you to compile it from source.

got it working. thank you! (performance is faster but still slow, I'm considering getting an egpu nvidia card for mac)

Useless. Tensorflow does not support GPU usage on macOS due to limited configuration access to nvidia GPUs. I think that compiling Tensorflow 1.12 with GPUs on macOS is not possible without modifications to code. Nvidia driver is also a pain on macOS, accusing a delay in versions of macOs supported (currently not supporting 10.14). Plus, Apple has not came out with a computer on Nvidia since 2013 and will probably never do it again. Moreover, eGPU on macOS is only supported with AMD GPUs, so basically not compatible with TensorFlow (there are kernel ports to openCL but implementation is still incomplete).
I personally have my own Red hat server in which I have my GPUs (2x RTX 2080) to which I connected my Pycharm environment with remote Python interpreter. This is the best setup when you have a mac. You can still compile your graph on macOS to see if it works on CPU and then run it on a server with GPUs.

you potentially saved me a ton of time. Thank you.

Hi everyone!!
I followed the guide on the tensorflow site for installing from source.
I have performed almost all the steps and they have been successful, I miss the last one or the installation of the package, using the following instruction:
pip install /tmp/tensorflow_pkg/tensorflow-2.8.0-cp39-cp39-macosx_11_0_x86_64.whl but it returns the following error
ERROR: tensorflow-2.8.0-cp39-cp39-macosx_11_0_x86_64.whl is not a supported wheel on this platform.
My version of Python is 3.9.9. Do you know how I can solve?


Add sparse matrix by dense vector multiplication

I let this go stale, I'm going to fix it up so I can get it in now, the background is in pull request 1405.  It needs to be two separate pull requests now, one for stan-dev/stan and one for stan-dev/math.  For stan-dev only the function signature needs to be exposed.
Fixes

[x] Expose one multiplication function---named "csr_matrix_times_vector"

[x] Expose constructor for a dense matrix using the sparse format---named "csr_to_dense_matrix"

[x] Expose extractors for turning dense matrix to sparse matrix components named:

[x] "csr_extract_w"
[x] "csr_extract_v"
[x] "csr_extract_u"
[x] "csr_extract_z"

[ ] add documentation

[ ] expose it to the language

Is this still considered close to ready? @jgabry and I would like to release an R package with precompiled .stan programs early in the Fall semester and could really use a sparse design matrix in a few places.

Yes, I expect to push something that should be ready for a real pull
request early next week.  Most of the work is on the math library side so
the issue with progress tracking is in the math library:
https://github.com/stan-dev/math/issues/127
Krzysztof
2015-08-06 15:33 GMT-04:00 bgoodri<EMAIL_ADDRESS>
Is this still considered close to ready? @jgabry
https://github.com/jgabry and I would like to release an R package with
precompiled .stan programs early in the Fall semester and could really use
a sparse design matrix in a few places.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/issues/1565#issuecomment-128481904.

@bgoodri, @jgabry, I just pushed to the sparse_multiply feature branch for the math library.  It passes tests but probably not linting yet.  If that goes through the changes required for the stan library are really minor and I can help plumb stuff through for rstan if there's interest.

@sakrejda, I just updated the list with two items; we're at the Stan meeting and want to make sure we wrote down what had to be done.

(we all know you're working on it)

I added a third item --- tests.  I volunteered to do all of this if you need help.  We're trying to release in the next week and need to get this in.

@bob-carpenter Can you write the doc?  I added the signatures and I'm in the middle of adding the test models.

Sure --- I'll write the doc this afternoon.

On Sep 1, 2015, at 2:00 PM, Krzysztof Sakrejda<EMAIL_ADDRESS>wrote:
@bob-carpenter Can you write the doc? I added the signatures and I'm in the middle of adding the test models.
—
Reply to this email directly or view it on GitHub.

I think I took care of exposing it and adding tests on the branch, the good models tests that I added all run fine locally.  Feel free to do the pull request when you add the doc, let me know if anything else needs to happen for this.


Create API and send response as JSON

Create model, migration and controllers for greeting messages
Create seed data in the database seed
Create API endpoints
Setup and configure rails API to properly send json response through API

Link to frontend pull request: https://github.com/sumon766/hello-rr-frontend/pull/1

Status: Invalid 🔴
Hi @sumon766  🙋♀,
While you made a great effort in this project, I can't go ahead and review your code.
Invalid Code Review Request
You have submitted a project, that does not meet all requirements for a valid submission. Please consider these points before your project can be reviewed.

In the README file for the backend, there should be a link to the frontend repo.
In the README file for the fronted, there should be a link to the backend repo.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

@KDlamini Thanks for the review. I updated the links in the readme as you required.

@sumon766 would you add backend link on front pr as you did on backend side, the front mit license and also those links on both readme

I am working on it.

@sumon766 would you add backend link on front pr as you did on backend side, the front mit license and also those links on both readme

I already have added the links to frontend react and the backend API in the readme files. They are updated in the "Update readme commit". Please have a look.


Empty HIDDEN_UI_ELEMENTS in configsettings.properties

[Version]
16.0.4+
[How to reproduce]

Upgrade OSCM to 16.0.5 as described in the documentation
As platform operator administrator login to the OSCM administration portal.
On Update Configuration Settings page, check the setting of HIDDEN_UI_ELEMENTS

[Observed result]
HIDDEN_UI_ELEMENTS contains billing adapter UI pages
[Expected result]
HIDDEN_UI_ELEMENTS doesn't contain billing adapter UI pages
[Detail]
The billing Adapter is released since 16.0.3, therefore the the UI should be visible by default.

I guess also documentation needs to be updated. Please check.

In the OSCM delivery, the line
HIDDEN_UI_ELEMENTS=operator.manageBillingAdapters,techService.viewBillingAdapters
appears just as an example - it has a comment sign.
The original reporter said that we should leave the example.
The documentation has already been updated for 16.0 Fix 3.
So nothing needs to be done here -> closing.


fix: add missing foundation.js reference comment

Description

This PR adds the missing foundation.js reference comment again

Types of changes

[ ] Documentation
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (anything that would change an existing functionality)
[ ] Maintenance (refactor, code cleaning, development tools...)

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] The pull request title and template are correctly filled.
[x] The pull request targets the right branch (develop or develop-v...).
[x] My commits are correctly titled and contain all relevant information.
[ ] I have updated the documentation accordingly to my changes (if relevant).
[ ] I have added tests to cover my changes (if relevant).

@SassNinja in 6.4.3 it was still there and it is helpful as reference for users to link / reference the full foundation.js file.
See https://github.com/foundation/foundation-sites/blob/v6.4.3/docs/layout/default.html#L85

I should probably move it after the vendor bundle.

I should probably move it after the vendor bundle.

Not so quick ;-)

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:
https://foundation.discourse.group/t/foundation-v6-6-1-shipped/67/1


Add Home Page Redesign

This attempts to add a redesigned homepage

navbar missing link to chat page
dark mode poor readability
[TODO: Add screenshots]
@syedshahmirsultan

This branch will need to be updated with the changes from #9. Please follow the steps below to ensure everything is correctly integrated:

Clone the repository or update your local repository with the latest changes:
git pull origin dev

Switch to the head branch of the pull request:
git checkout 8-ui-redesign-home-page

Merge the base branch into the head branch:
git merge dev

Resolve any conflicts and commit the changes.

Ensure that the styling is consistent and readable in both light and dark modes. Double-check that the colors, fonts, and spacing align with the design specifications for both themes.

Verify that the navbar and other links are correctly linked to the appropriate routes/pages. Make sure all navigation works as expected.

Push the updated branch:
git push -u origin 8-ui-redesign-home-page

This branch will need to be updated with the changes from #9. Please follow the steps below to ensure everything is correctly integrated:

Clone the repository or update your local repository with the latest changes:
git pull origin dev

Switch to the head branch of the pull request:
git checkout 8-ui-redesign-home-page

Merge the base branch into the head branch:
git merge dev

Resolve any conflicts and commit the changes.

Ensure that the styling is consistent and readable in both light and dark modes. Double-check that the colors, fonts, and spacing align with the design specifications for both themes.

Verify that the navbar and other links are correctly linked to the appropriate routes/pages. Make sure all navigation works as expected.

Push the updated branch:
git push -u origin 8-ui-redesign-home-page


feat: add rules utility

Copy-pasting the rules stuff verbatim at least 4 times has got me thinking it should just go in here. It's relatively isolated, some utils and test utils, an additional INSTALLED_APPS reduces quite a foot print in projects

Sorry, forgot to even let CI run before asking for review, I immediately started using this branch in downstream projects


Add action-misspell

Add action-misspell to correct commonly misspelled English words in source files.
Link:
https://github.com/reviewdog/action-misspell

I want to own it up, please assign to me

@mgrachev One question, which locale we should use US/UK?

@mgrachev One question, which locale we should use US/UK?

US.


Consolidate/simplify TreeType

This PR is the result of my experiments with how we do validation, looking at trying to implement pairs specifically. It actually resulted in being able to simplify the existing TreeType hierarchy into a single sum type, with the new withTtProxy function bearing some of the load of handling container behaviours.
There's still probably some simplification to go, but this makes a good start I think. As @foolswood has mentioned elsewhere, we need to be mindful of what other things may break should we decide to merge these changes.
I inadvertently upset the text-serialisation of TreeType with pairs, so I tried to improve the parser also.

Pull Request Test Coverage Report for Build 575

134 of 182 (73.63%)  changed or added relevant lines in 5 files are covered.
33 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.08%) to 56.32%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Clapi/TextSerialisation.hs
80
81
98.77%

src/Clapi/Types/TreeTypeProxy.hs
4
17
23.53%

src/Clapi/Validator.hs
27
61
44.26%

Files with Coverage Reduction
New Missed Lines
%

src/Clapi/Validator.hs
1
47.89%

src/Clapi/Types/Tree.hs
2
82.14%

src/Clapi/Types/Wire.hs
6
33.33%

src/Clapi/Util.hs
24
44.26%

Totals

Change from base Build 568:
-1.08%

Covered Lines:
1154

Relevant Lines:
2049

💛  - Coveralls

Yes - I've been wondering if there's a way to express type class constraints polymorphically too, and I think there might be. I came across https://github.com/glaebhoerl/exists/, which seems to do some pretty mind-boggling things. Borrowing heavily from Control.Constraint.Combine I made a gist showing the possibilities of some of the parametrisation.
I started looking at this because I got stuck in a whole whilst trying to re-write WireValue to use some of the slightly newer stuff I've been looking at. It turns out we'd pretty much re-implemented the whole unpacking-casting thing we'd had to do for Wireable's again with the addition of an Arbitrary context so that we could generate random WireValues for tests. However, with unpacking like we used to prohibited by our new Pair stuff, I needed a way to crow-bar in Arbitrary, and this might be it?
My brain has melted, but that might be food for thought...

Yeah, we do the "Wireable with context" thing in various places outside Clapi too.
I'll have a play and see where I get.

I feel like this is worth a read (and I'm trying to get a function that can create a constrained proxy):
https://stackoverflow.com/questions/31317159/constraintkinds-explained-on-a-super-simple-example

Here's something else that might provide useful along this kinda crazy constraints-and-existentials journey...

This latest bunch of stuff makes the tests use the new pair types too.


A TextEditingController was used after being disposed

Steps to Reproduce
TextEditingController _editingController = TextEditingController();
@override
void dispose() {
_editingController .dispose();
super.dispose();
}
Logs

Logs

When I dispose of the controller in Dispose, I will be prompted that A TextEditingController was used after being disposed

I'm not sure if it is similar to TextEditingController FixedExtentScrollController whether need to manually when dispose the dispose

@jahnli
Please provide flutter doctor -v and a complete minimal code sample along with logs that shows the issue.
Thanks.


Unable to connect - Login required

Kismet: 2019-04-GIT
Kismon: 1.0.0
When I try to connect Kismon to a Kismet server running on another machine on the network, it returns the following both in the console and the Log window in the Kismon UI:
Error:
401 - Access denied
Login required to access this resource.
In the server configuration in Kismon the address, port, and username/password are correct and match the kismet_httpd.conf settings. I checked that Kismet isn't overriding the user httpd configuration as well. In the browser of the machine, the Kismet UI is accessible with the username/password that is provided to Kismon.
Kismon does connect to the server, it just isn't passing the credentials in a way that Kismet accepts possibly?

Looks like the problem was introduced by this commit: https://github.com/kismetwireless/kismet/commit/932377f5f96e7b31d8e6473b0e3361cdc6c81ef6
Before that the kismet server needed only authentication for endpoints that configure the server, now it requires it for all requests.
I will update Kismon in the next days to reflect this change, until then you could use the kismet release kismet-2019-04-R1 instead of the git master.


This drawing is really nice. What app did you use to draw it?

https://github.com/xlang-ai/OpenAgents/blob/main/pics/data_agent.png
Thank you.

Thanks for your question, we used https://excalidraw.com/ to draw them

Thank you for your help.Would you please share the source file of this drawing? Thank you very much.


when I use customComponent, I need svg name to add default class

when I add a customComponent to replace nuxt-icon.vue, I need some original information to controll my component. But componenttext only transfer render to component, so I need transfer svg name to component

Can I ask why ? like how do you plan to use the name ?

I'll use home-filled and home-outline as well as home-colorful to represent monochrome filled icons, monochrome outlined icons, and two-colored icons. When using two-colored icons, I want the inner and outer layers to have different colors, so I'd like the default value for filled in all *-colorful icons to be true.
In other words, icons often have different states for the same icon used in different scenarios, and the icon names themselves follow certain conventions.
Therefore, I need the icon names to calculate some default values for configurations.

For example, designers might use a prefix like m20-w22-home.svg in the icon name to indicate constraints on the icon size.
In fact, when dealing with cross-team communication, icon names themselves convey a lot of information. This information is essential to be passed to the component runtime, thereby reducing communication costs.

I understand, that's an interesting way to do it, thanks for explaining

@Dante-dan sorry for the delay, I hope this works for you :)


App Template "options"

Is your feature request related to a problem? Please describe.
We use reservations and limits for our containers and need to use separate templates when we want to have "big" vs "small" versions of stacks. With big being a reservation of say 4gb of ram and small being a reservation of say 512mb of ram
Describe the solution you'd like
When the user deploys a template, allow them to pick from a number of stack files to deploy for that template with each stack file having different environment variables, reservations, limits, etc.
Describe alternatives you've considered
Multiple templates is a potential solution but if we have twenty templates today, adding small, medium and large would bring us to sixty templates.

Closing this as a duplicate of #999


ja: Translate /docs/concepts/architecture/control-plane-node-communication/ into Japanese

This is a Feature Request
What would you like to be added
Translate /docs/concepts/architecture/control-plane-node-communication/ into Japanese.
Why is this needed
This page has not been translated.
Comments
/language ja
/assign

/close


feat: restrict default allowed paths for file reading/writing

Component
Forge
Describe the feature you would like
In https://github.com/foundry-rs/foundry/pull/2038, cheatcodes were introduced to read and write to system files. It seems they have no restrictions on the paths they can read from / write to, meaning someone can trick you into executing a malicious test suite that overwrites important system files.
By default, we should limit those cheatcodes to only working within the foundry project directory. Additionally, we should either:

add a config option to extend the allowed system paths, or
treat it similarly to ffi with a special --io flag that allows writing to/from anywhere on the system

cc @shekhirin
Additional context
No response

That seems reasonable to me

That's a very good addition given that --ffi isn't needed for these filesystem cheatcodes, thanks!

@onbjerg you can assign this one to me


Injecting script-element created by Cash doesn't load

This injects the script tag and loads/executes the script:
var s = document.createElement('script');
s.src = src;
parent.prepend(s);

This injects the script tag but doesn't load the script:
var s = $('<script/>').attr('src', src);
parent.prepend(s);

No idea why this doesn't work.

Likely due to how elements are created in a documentFragment. I think this is the issue here: http://stackoverflow.com/questions/28112807/why-script-elements-created-through-domparser-do-not-execute
There may need to be an exception made for how <script> elements are created in the HTML parser.

If anybody wants to submit a PR for fixing this, that requires few bytes and it's fast, I'll be happy to consider it.

This is now supported https://github.com/kenwheeler/cash/commit/7fcf9bc57b94cc1dc4509e412d328a40d2c5cf54.
Except for the cases I mentioned earlier: script tags within iframes and script tags with a src attribute.


Support Data Prepper Maven releases

Is your feature request related to a problem? Please describe
Data Prepper needs to release Maven artifacts.
Describe the solution you'd like
Update the release-data-prepper-all-artifacts job to release Maven artifacts. These release steps will do the following:

Copy artifacts from the Data Prepper staging site.
Sign the artifacts.
Upload to Sonatype

We expect that promoting from Sonatype to Maven Central is a manual step.
Describe alternatives you've considered
No response
Additional context
No response

[Triage] Closing this issue since it's being released. @dlvenable Feel free to re-open this if there is any other issues.


[SPARK-29651][SQL][2.4] Fix parsing of interval seconds fraction

What changes were proposed in this pull request?
In the PR, I propose to extract parsing of the seconds interval units to the private method parseNanos in CalendarInterval and modify the code to correctly parse the fractional part of the seconds unit of intervals in the cases:

When the fractional part has less than 9 digits
The seconds unit is negative

This is a back port of the commit https://github.com/apache/spark/commit/3206a9987001d78cf2f48509a93d73af86f51cfe.
Why are the changes needed?
The changes are needed to fix the issues:
spark-sql> select interval 10.123456 seconds;
interval 10 seconds 123 microseconds

The correct result must be interval 10 seconds 123 milliseconds 456 microseconds
spark-sql> select interval -10.123456789 seconds;
interval -9 seconds -876 milliseconds -544 microseconds

but the whole interval should be negated, and the result must be interval -10 seconds -123 milliseconds -456 microseconds, taking into account the truncation to microseconds.
Does this PR introduce any user-facing change?
Yes. After changes:
spark-sql> select interval 10.123456 seconds;
interval 10 seconds 123 milliseconds 456 microseconds
spark-sql> select interval -10.123456789 seconds;
interval -10 seconds -123 milliseconds -456 microseconds

How was this patch tested?
By existing test suite, literals.sql and new tests in ExpressionParserSuite.

Test build #113081 has started for PR 26355 at commit 56faeb0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17998/
Test PASSed.

Test build #113081 has finished for PR 26355 at commit 56faeb0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113081/
Test FAILed.

Test build #113083 has started for PR 26355 at commit f9b063c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18000/
Test PASSed.

Test build #113083 has finished for PR 26355 at commit f9b063c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113083/
Test PASSed.

ping @cloud-fan

thanks, merging to 2.4!

Thank you all!


Navigation Links Do Not Scroll to Top of Page on Click

What is this issue related to?
Performance
Description
When clicking on a navigation link from the middle of the current page, the new page loads, but it does not start at the top. Instead, it opens at the same scroll position as the previous page.
Expected Behavior
Clicking on a navigation link should take the user to the top of the new page.
Current Behavior
Clicking on a navigation link takes the user to the same scroll position as the previous page.
Additional Information (optional)
Consider adding code to reset the scroll position to the top when a navigation link is clicked.
Confirmation Checklist

[X] I have searched for similar issues before creating this one.
[X] I have provided all the necessary information to understand and reproduce the issue.

please assign this to me, I want to fix and rectify the issue

Allow us some time to check.

@aps08 alright

please check and get the nav and footer to 100% width too? footer and nav bar produce irregular behaviour  both shrinking in size to full screen.

👋 hey
@aps08 please could you please review my PR thanks


pass samples to i2p_draws as external variable

fit already a samples column after sampling set to the number of iterations which will be used here unless explicitly referencing the external vector.

👍


Packages are not sorted alphabetically in output anymore (post 3.0.0)

As title, it seems the output is generated consistently still, but in a different order with logic unknown to me.

Hey @Greg-NetDuma - we'll get back to you in the next few days.
In the meantime we're hoping you can provide us with a little more detail?

What version of generate-license-file are you using? (3.0.1?)
Which package manager are you using? (npm/yarn/pnpm)
How are you using generate-license-file? (CLI or importing the functions/programmatic use; if programmatically, which function(s) are you calling?)
What is your expectation for ordering? (Sorting by license content vs. npm package name vs. etc.)

Thanks :)

Hey @Greg-NetDuma ,
I'm just following up on this, are you able to provide us with a little more context regarding our questions above?
Thanks :)

Hi, sorry for the late reply (also I stopped using my work account got merged into my personal one so I'm using this account instead).
Version: 3.0.1
Package manager: npm
Command we are using: npx generate-license-file --eol lf --ci --input package.json --output build/licenses.txt --overwrite
My expectation was that licenses are sorted by packages names used are alphabetically sorted. This is something I prefer.
The alternative is that packages are grouped by licenses (if they are identical) and the packages themselves are sorted. The last group would be custom. But I'm not sure how would you sort by licenses themselves as I can't see the usefulness of sorting by license content.
Please point out any caveats/cons or problems with the expected outputs I described (because it is more than likely I missed some).

Hey @Greg-NetDuma / @Gr3q,
Sorry we've let this issue go stale. It should be the case that if you're using our CLI then the output should be sorted.
Do you have a minimal repro that demonstrates packages or licenses out of order?


fix(ui): Checking token expiration before requests

Fixes #877
In this PR, I added a handler to check the token expiration before requests.

@rpelczar this is for #877, right?

Works beautifully @rpelczar!


YAML : Constraints with nullable types fixed for Min, Max & NotValue

Problem
What is being fixed?  Examples:

YAML tests doesn't support Nullable type limits

Change overview
Modification to support nullable types
This PR is needed to lay down other PR and new YAMLs Tests
EDITs: We allow NULL values to PASS here, we check MIN MAX only if the value is present
since we don't want to fail on such condition, there is another tag dedicated to check the nullity in particular.
We just allow for a test to verify the value is withing a particular range and a nullable attribute is allowed to be NULL
Testing
How was this tested? (at least one bullet point required)

No regression + tested with code from another PR where Nullable type were tested against limits

Thank you, that was a lot more tests than I was expecting.... ;)
As the CI shows, this does in fact need darwin changes. You'll want to at least run ./scripts/tools/zap/generate.py -t src/darwin/Framework/CHIP/templates/templates.json src/controller/data_model/controller-clusters.zap to regen there. After that, look at the generated code; I expect the codegen in src/darwin/Framework/CHIP/templates/partials/test_cluster.zapt will probably need to be adjusted to handle Nullable by using a helper method that checks for null before calling XCTAssert* functions....

Ok i ll look into this , never did objective-c guess it is time to learn
Where there objective c Nullable object is defined there ? thanks for the tips

So what will happen in the Objc code is that actualValue will be nil if we're nullable and set to null.
So just wrapping a actualValue != nil test around the XCTAssertGreaterThanOrEqual and XCTAssertLessThanOrEqual calls is probably the simplest thing to do.  Hopefully the compiler won't complain in the cases when the attribute is not nullable and hence actualValue is declared nonnull...

Approving, but fixing the darwin code to use asTypedLiteral would have fixed those 64-bit things.... I'll do that as a followup.

https://github.com/project-chip/connectedhomeip/pull/13057


Refactor: Use inheritance and prune unecessary functions

Investigate and prune unecessary functions that should be inherited from the base class instead of the modin-gpu specific classes.

It seems that we are using exactly the same parser to read from csv as pandas_on_ray. So what if we create a child parser that overrides the main parse method to get whatever is return by the pandas parser and transfer to GPU


Fix globe texture stretching when instancing is enabled.

This should fix the texture stretching issues discussed in #3112
When the VAO was being created, it would set the vertex divisor but not modify Context's divisor cache. As a result setVertexAttribDivisor would not work properly. Now I call setVertexAttribDivisor whether or not the vao extension is supported. I remember @mramato made that comment before. The code I removed here can be added back once #3042 is resolved, but it was definitely causing the problem.

The code I removed here can be added back once #3042 is resolved, but it was definitely causing the problem.

Can you mention this in a code comment?

@bagnell can you test and merge since I can't reproduce this?