Omitted "all parts"

I want to confirm what behaviour we want here, @ronaldtse.
The Rice document cites ISO 16634, as a document in progress. For whatever reason, it has no "all parts" in the citation.
The document eventually came out in part 1 and part 2: ISO 16634-1 and ISO 16634-2. That's what isobib finds. isobib does not therefore find a match for document ISO 16634.
Good practice is that this is correct behaviour, and I will output a warning when isobib does not find a match. Should we though be lenient when finding no match in isobib, and attempting an "all-parts" match if there is no match on a bare document?

Note that I am also going to be checking the year of publication, where it is supplied. If there is a mismatch, I will likewise be reporting a "match not found" error.

@opoudjis this is a great example. You're right -- let's issue an warning, and give the exact next steps, something like:
WARNING: You cited `ISO 16634`, but two results were returned from [hostname]: [<ISO 16634-1, title...>, <ISO 16634-2, title...>]. If you want to cite only one, write `xxx`. If you wanted to cite all parts, write `yyy`. The default is 'all parts'.

The isobib match is returning everything in the world, and we are not yet filtering it elegantly. For now, I'm going to post generic guidance:
        warn "WARNING: no match found on the ISO website for #{code}."
        if /\d-\d/.match? code
          warn "The provided document part may not exist, or the document may no longer be published in parts."
        else
          warn "If you wanted to cite all document parts for the reference, use #{code}:All Parts"
        end

Added this code to asciidoctor-iso (where the isobib filtering is currently taking place, pending https://github.com/riboseinc/isobib/issues/25)


jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to allocate 98697216 bytes for new constant

When running the examples/03_eval_finetuned.py script on a GPU (A100 80G, cuda12.2), I encountered the following error:
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to allocate 98697216 bytes for new constant
Here are details:

Traceback (most recent call last):
File "/home/houxuan/code/robot/octo/examples/03_eval_finetuned1.py", line 217, in
app.run(main)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/absl/app.py", line 308, in run
_run_main(main, args)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/absl/app.py", line 254, in _run_main
sys.exit(main(argv))
File "/home/houxuan/code/robot/octo/examples/03_eval_finetuned1.py", line 193, in main
actions = policy_fn(
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/traceback_util.py", line 177, in reraise_with_filtered_traceback
return fun(*args, **kwargs)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/pjit.py", line 256, in cache_miss
outs, out_flat, out_tree, args_flat, jaxpr = _python_pjit_helper(
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/pjit.py", line 167, in _python_pjit_helper
out_flat = pjit_p.bind(*args_flat, **params)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/core.py", line 2656, in bind
return self.bind_with_trace(top_trace, args, params)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/core.py", line 388, in bind_with_trace
out = trace.process_primitive(self, map(trace.full_raise, args), params)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/core.py", line 868, in process_primitive
return primitive.impl(*tracers, **params)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/pjit.py", line 1212, in _pjit_call_impl
return xc._xla.pjit(name, f, call_impl_cache_miss, [], [], donated_argnums,
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/pjit.py", line 1196, in call_impl_cache_miss
out_flat, compiled = _pjit_call_impl_python(
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/pjit.py", line 1152, in _pjit_call_impl_python
return compiled.unsafe_call(*args), compiled
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/profiler.py", line 340, in wrapper
return func(*args, **kwargs)
File "/home/houxuan/miniconda3/envs/octo/lib/python3.10/site-packages/jax/_src/interpreters/pxla.py", line 1152, in call
results = self.xla_executable.execute_sharded(input_bufs)
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to allocate 98697216 bytes for new constant

Making the following modification in the code resolves the problem:
    # jit model action prediction function for faster inference
    # policy_fn = jax.jit(model.sample_actions)
    policy_fn = model.sample_actions

any suggestion for how to make jax.jit transformation work?

Sorry, that line should not even be in there. If you look at model.sample_actions, it's jitted already. Thanks for the catch!


Progress bar section's color is not modifiable

It would be great to have the option of changing progress bar section's color. Right now it only can be white but think about stories with white background !

Put a gradient behind it. You should be doing that in all cases anyway to
accomodate for a video or image that unpredictably goes white.
On Thu, 5 Jul 2018 at 9:19 pm, Storytegy<EMAIL_ADDRESS>wrote:

It would be great to have the option of changing progress bar section's
color. Right now it only can be white but think about stories with white
background !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/shts/StoriesProgressView/issues/13, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIgngrOvR9wOJePkQoIJoC9poXvfIUYcks5uDfYzgaJpZM4VDtAK
.

--
Regards
Brandon Stillitano
Project Manager
0401 007 904 <javascript:void(0);>

@storytegy I fixed that in my fork of the project.
Have a look: https://github.com/teresaholfeld/Stories


Writer's guide - Types notation

Some time ago a writes guide was created that specifies how to add types notations to our documentation, but later some users found it confusing, an alternative is to use TypeScript notation which has better standardization process and it is more known by the community.
Another alternative is to use TypeScript documentation from webpack source code directly (it would be a fun AST ride, maybe).

Related: https://github.com/webpack/webpack.js.org/pull/3323

If this doesnt get traction, i suggest adding a small outline to the types in the docs somewhere or as i suggested earlier, a tooltip when hover types

@EugeneHlushko Typescript notations are less confusing and should be used in my opinion.

Another alternative is to use TypeScript documentation from webpack source code directly (it would be a fun AST ride, maybe).

Major part of the code in the webpack source code in written in javascript with commented types, thus extracting the types from there wouldn't be a nice idea.

I agree with @rishabh3112 here. We can see the two version here https://github.com/webpack/webpack.js.org/pull/3706#issuecomment-619119074, the TypeScript one is much better. Also, when user reading docs, they won't read the writers guide first to figure out the difference. So it would be better to choose the popular notations.
We might use details/summary here:

Click to see Options types

type Entry =
  | string
  | [string]
  | {
      key:
        | string
        | [string]
        | {
            import: string | [string]
            dependOn: string | [string]
            filename: string
          }
    }
  | (() =>
      | string
      | [string]
      | {
          key:
            | string
            | [string]
            | {
                import: string | [string]
                dependOn: string | [string]
                filename: string
              }
        })


Add note about docker-compose linux installation

Fixes #issue_number
Problem
Explain here the context, and why you're making that change.
What is the problem you're trying to solve?
Solution
Describe the modifications you've done.
Notes
Additional notes.
Checklist

[ ] Unit test all changes
[ ] Update README.md if applicable
[ ] Add [WIP] to the pull request title if it's work in progress
[ ] Squash commits that aren't meaningful changes
[ ] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers
Also reformat some lines (very long lines are hard to ready in some displays).

👍 Thanks!

:+1:


Add dockerfile

This commit adds a Dockerfile and .dockerignore to for containerizing the kor CLI tool. #64 #69
example for using the image: docker run --rm -i -v "$KUBECONFIG:/root/.kube/config" kor-image:tag all -n namespace
or instead: docker run --rm -i -v "/path/to/kube/config:/root/.kube/config" kor-image:tag all -n namespace
The image should be pushed to dockerhub and ghcr.io with every release using goreleaser.
I was also thinking about adding to the Dockerfile ENV KUBECONFIG=/kubeconfig making it a bit easier to use the volume: docker run --rm -i -v "/path/to/kube/config:/kubeconfig" kor-image:tag but for now users can just add -e KUBECONFIG=/kubeconfig -v "/path/to/kube/config:/kubeconfig".
@yonahd let me know what you think.

also instructions should be added to readme.md once the image is pushed.


Missing files in gem?

This has been driving me crazy as a "No, couldn't be...could it?" situation. But it looks like there are files in this repo that are not present in the built gem.
For example, I've been looking for ItemRepRepo, but couldn't instantiate it for some reason. It looks like the gem I have installed does not match the one in the repo:

I don't know how this gem was packaged and distributed—it doesn't look like it was using the Bundler gem tasks, given the lack of these in the Rakefile—but I'm pretty sure something wasn't wrapped up correctly. This is for nanoc 4.0.0.

Hm. Maybe ItemRepRepo isn't meant to be in the gem? In that case, how does one add a new rep to an existing item?

ItemRepRepo is new in Nanoc 4.1.
In 4.0, Nanoc::Int::Item has #reps, an array of Nanoc::Int::ItemReps, and adding a new repo can be done by appending to it:
item.reps << Nanoc::Int::ItemRep.new(item, :json)

Usually, the reps are generated automatically based on the Rules file. Hope this helps!

Doh. Super clear. Sorry! I was looking for more documentation in reps and could only find the test cases as clear examples.

I guess the lacking documentation is what nanoc/nanoc.ws#116 is for. :)

Looks like item.reps << is forbidden:
NoMethodError: undefined method `<<' for #<Nanoc::ItemRepCollectionView:0x007fd7961c36d8>

I only see that method defined for ItemRepRepo, which is probably where I got my first idea to use it from.

item.reps << x won’t work on 4.1; on 4.1, you can modify ItemRepRepo.
(The reason why ItemRepRepo exists is so that at some point in a future version of nanoc, not all the item reps (nor items) will need to be in-memory anymore. That should reduce memory pressure and make nanoc capable of handling sites with tens of thousands of pages/assets.)

It sounds like instead of doing this in 4.0, I should just wait patiently for 4.1 :D If I can't modify item.reps in 4.0, and ItemRepRepo does not yet exist, I simply don't see a way to modify the reps. :worried:

@gjtorikian Nanoc 4.1 will be backwards compatible with 4.0, and I’d recommend making modifications in 4.1 rather than 4.0! There’s no release timeframe for 4.1, but I’ll try to release more often than with 3.x (where I averaged one minor release per year or so).


Add more UI tests of transmute!

I found that I was unable to easily review changes made atop #183 due to its omnibus UI test producing very long stderr files. This PR lifts the tests of transmute! added in #183, but takes a test-per-file-approach. A test-per-file approach is taken so that reviewers of future PRs that alter the implementation details of transmute! can assess each dimension of change discretely and incrementally — as opposed to contending with .stderr files hundreds of lines in length.

Implemented in https://github.com/google/zerocopy/pull/456.


Show Outline for Jupyter Notebooks based on Markdown headers

It would be great if it was possible to navigate Jupyter Notebooks through the Outline in the left panel using the text from the markdown cells in the notebook. As it is possible, for example, with markdown files.

+1

It's now already supported by the core.


Add ability to use "Grouped" CV instances from scikit-learn

closes #181
Allows the usage of Group CV objects in ShapRFECV.

The tests fail but the reason seems to be that pip is not able to resolve the dependencies under Python 3.7 which was mentioned by @operte.

The related issue is #185

The failed checks are not related to this PR, so I will merge it.


Blog post about rationale behind legacy executable packagers and approaches

A post about rationale behind executable packagers and approaches taken by legacy solutions (ruby-packer, ocra).

@ronaldtse  @CAMOBAP
Please have a look. I am seeking for reviews and better ideas
post-1.docx
post-1.pdf

@maxirmx thanks for preparing great report
Few questions from my side:

You not only have to build separate packages for each OS, but also each OS version

Am I right that this related to dynamic linking with "system" libs like glib?
Or you mean some other sort of problems?

Few questions from my side:

You not only have to build separate packages for each OS, but also each OS version

Am I right that this related to dynamic linking with "system" libs like glib? Or you mean some other sort of problems?

Thank you, @CAMOBAP, it is a good question
I think was not a reasonable statement.

post-1.docx
post-1.pdf
Updated

Few questions from my side:

You not only have to build separate packages for each OS, but also each OS version

Am I right that this related to dynamic linking with "system" libs like glib? Or you mean some other sort of problems?

Thank you, @CAMOBAP, it is a good question I think was not a reasonable statement.

Thanks for update, sorry but it's still not clear why exactly: "... you have to treat each distribution as another OS, further increasing the number of combinations"
I hope snap/flatpak/appimage should help us minimize such issues. The only problem which I remember sofar is glib link to specific version (runtime linker error)


fix: HotFix for using mSet instead of Set for redis cache

Description:
Cherry-Pick of HotFix https://github.com/hashgraph/hedera-json-rpc-relay/pull/2197
Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.15%.  Consider uploading reports for the commit ecedab9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create Bicep Config command scaffolds a more user friendly file

So in the case that a user calls Create New Bicep Configuration file, I would like to provide more guidance. This is because we should assume new users are not familiar with writing a bicep file, nor interacting with a bicep config file.
I think what would help is, when the command is called:

The user saves the bicepconfig file in their choice of location
We navigate the user to the bicep config file (this already happens)
Then the user sees the bicep config file as the pic below and their cursor is placed in the rules section where they can fire intellisense
Bonus if it's possible to not only place the cursor where it is but automatically fire the intellisense so they can get going

Tied to the experience in #6397
And we should use this file to create consistency with our manual editing experience -> #6399

Current working idea for the comment would be " // Customize linter errors and warnings in this section"


Use the native structuredClone implementation when it's available

With a recent addition to the HTML specification, the internal structured clone algorithm used in browsers is (or will be, once it's implemented) directly accessible to JavaScript; please see https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/structuredClone
Hence we'll eventually not need to maintain our own structured clone functionality in the LoopbackPort-class in the API, however for the time being we'll feature detect structuredClone and fallback to the existing PDF.js implementation.
Given that https://bugzilla.mozilla.org/show_bug.cgi?id=1722576 has landed in Firefox 94, we should no longer need the manually implemented cloneValue-functionality in MOZCENTRAL builds. Note also that in the Firefox built-in PDF Viewer it's not possible for users to easily disable workers, which should further reduce the risk of these changes.

/botio unittest

This is a really nice addition; thank you!


undefined method `close' for nil:NilClass

Updated to the latest version and I'm getting the error below.  Anyone else run into anything else like this?
[2015-02-01T01:19:41+00:00] ERROR: Running exception handlers
[2015-02-01T01:19:41+00:00] ERROR: Exception handlers complete
[2015-02-01T01:19:41+00:00] FATAL: Stacktrace dumped to /var/chef/chef-stacktrace.out
[2015-02-01T01:19:41+00:00] ERROR: mysql_database[drupal8] (drupal::vdd_sites line 32) had an error: NoMethodError: undefined method `close' for nil:NilClass
[2015-02-01T01:19:41+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

the project I ran into this on is here:
https://github.com/joshuacox/ddd

Test-kitchen is passing its smoke tests...
What platform/version/mysqlversion are you on?
Can you gist a full stack trace?
-s
On Sat, Jan 31, 2015 at 11:53 PM, Josh Cox<EMAIL_ADDRESS>wrote:

Updated to the latest version and I'm getting the error below. Anyone else
run into anything else like this?
[2015-02-01T01:19:41+00:00] ERROR: Running exception handlers
[2015-02-01T01:19:41+00:00] ERROR: Exception handlers complete
[2015-02-01T01:19:41+00:00] FATAL: Stacktrace dumped to /var/chef/chef-stacktrace.out
[2015-02-01T01:19:41+00:00] ERROR: mysql_database[drupal8] (drupal::vdd_sites line 32) had an error: NoMethodError: undefined method `close' for nil:NilClass
[2015-02-01T01:19:41+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
the project I ran into this on is here:
https://github.com/joshuacox/ddd
—
Reply to this email directly or view it on GitHub
https://github.com/chef-cookbooks/mysql/issues/289.

From your output, this looks like it's in the database cookbook, not the mysql cookbook
mysql_database[drupal8]
A v4.0 was just released. Please see if that fixes your issue. Closing here.


Any plan to maintain this

Hey @Hasnayeen ,
any plan to maintain this repository?

I don't use this personally anymore so no update but will accept PR


Request for a simple info

Hi,
First of all, congratulations for the code - it's great in my opinion.
I was wondering if you could tell me what is the id in the html page of the svg canvas. I want to use the following code (which works with a previous canvas named 'myCanvas')):
var data = document.getElementById("myCanvas");
But the canvas generated by the radix.html (for instance) is not just 'paper'. Its child is 'svg' I think.
Can you help me out?
Kind regards
CPtolemy

Hi
This code creates the following DOM elements:
var chart = new astrology.Chart( 'paper', 600, 600);
chart.radix( rData ).transit( tData );

//DOM
<div id="paper">
	<svg xmlns:xlink="http://www.w3.org/1999/xlink">
		<g id="astrology">
			<g id="astrology-aspects">...</g>
			<g id="astrology-radix">...</g>
			<g id="astrology-transit">...</g>
		</g>
	</svg>
</div>

The IDs of elements you can change in settings.
You can append your SVG elements like:
var chart = new astrology.Chart( 'paper', 600, 600);
chart.paper.root.appendChild( SVG_NODE );

Hi
What I'm trying to do is to save the returning SVG to a file. So I need something like this:
var dataURL = document.getElementById("myCanvas").toDataURL("image/png");
dataURL = dataURL.replace(/^data:image/(png|jpg);base64,/, "");
Given what you said, after:
var chart = new astrology.Chart('paper', 600, 600);
chart.radix( data ).aspects();
which id do I use instead of "myCanvas"? Sorry, I'm a little confused...
Kind regards,
CPtolemy

Hi
SVG graphics is DOM based.
There is no HTML5 Canvas in this library.
//SVG DOM element
document.querySelector("#paper svg");

or (=> v0.4.0)
var chart = new astrology.Chart( 'paper', 600, 600);
chart.paper.DOMElement

Hi
Thanks for the info. Can you please advise how can I save the SVG to a png
image? I read that the SVG DOM would have to be converted to a canvas first

but my attempts failed.

Sorry for the trouble.
Kind regards
CPtolemy
On Mon, Oct 30, 2017 at 9:31 AM, Kibo<EMAIL_ADDRESS>wrote:

Hi
SVG graphics is DOM based.
There is no HTML5 Canvas in this library.
//SVG DOM element
document.querySelector("#paper svg");
or (=> v0.4.0)
var chart = new astrology.Chart( 'paper', 600, 600);
chart.paper.DOMElement
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kibo/AstroChart/issues/2#issuecomment-340389824, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AO5QDgFxKdMHm-pAywCXpno41Vc8IlE7ks5sxZeKgaJpZM4QKV3f
.

--
Rui Miguel FernandesPorto - PortugalWebsites:Novo Milénio - Harmonice
Mundi (A Harmonia dos Mundos)http://novomilenio.eu
http://novomilenio.euCosmos - Portal Interactivo de Astronomia /
Interactive Gate of Astronomyhttp://cosmos.pt http://cosmos.pt

Hi
see for example:
https://stackoverflow.com/questions/3975499/convert-svg-to-image-jpeg-png-etc-in-the-browser
https://stackoverflow.com/questions/4086703/convert-raphael-svg-to-image-png-etc-client-side

Greetings Kibo,
Just...great tip. My problem was rendering the inline svg to a canvas.
Done. The rest (saving) was easy.
Still, I can't thank you enough.
Kind regards
CPtolemy
On Tue, Oct 31, 2017 at 6:22 PM, Kibo<EMAIL_ADDRESS>wrote:

Closed #2 https://github.com/Kibo/AstroChart/issues/2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kibo/AstroChart/issues/2#event-1319386152, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AO5QDtTrWt8NOqKmnP8X7F_JR_TkcTWSks5sx2V4gaJpZM4QKV3f
.

--
Rui Miguel FernandesPorto - PortugalWebsites:Novo Milénio - Harmonice
Mundi (A Harmonia dos Mundos)http://novomilenio.eu
http://novomilenio.euCosmos - Portal Interactivo de Astronomia /
Interactive Gate of Astronomyhttp://cosmos.pt http://cosmos.pt


t.throws() not catching throw statements

Unless I am overlooking something super simple, It seems that t.throws() is favoring rejected promises over throw statements.  I have setup a small test in order to demonstrate this behavior. In the code below you will find a module with two functions, one that returns a rejected promise, and another that throws an error. You will see how the test to catch the throw (via the rejected promise) passes, but the test to catch the throw via throw new Error does not pass.
Consider this very simple test.js file:
import test from 'ava';
import fn from './';

test('AVA should catch my throw statement', t => {
	t.throws(fn.withThrow());
});

test('AVA should catch throw via rejected promise', async t => {
	await t.throws(fn.withPromise());
});

And my equally simple index.js file:
module.exports.withThrow = function () {
	throw new Error('Error was thrown.');
};

module.exports.withPromise = function () {
	return Promise.reject('Rejected promise');
};

And finally, the result of running the tests:

✖ AVA should catch my throw statement Error was thrown.
✔ AVA should catch throw via rejected promise

  1 test failed

  1. AVA should catch my throw statement
  Error: Error was thrown.
    at Object.module.exports.withThrow (/Users/michael/gitprojects/hash-to-regex/index.js:4:8)
    at Test.fn (/Users/michael/gitprojects/hash-to-regex/test.js:5:14)
    at tryCatcher (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/util.js:11:23)
    at Object.gotValue (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/reduce.js:145:18)
    at Object.gotAccum (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/reduce.js:134:25)
    at Object.tryCatcher (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/util.js:11:23)
    at Promise._settlePromiseFromHandler (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/promise.js:489:31)
    at Promise._settlePromise (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/promise.js:546:18)
    at Promise._settlePromiseCtx (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/promise.js:583:10)
    at Async._drainQueue (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/async.js:130:12)
    at Async._drainQueues (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/async.js:135:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/michael/gitprojects/hash-to-regex/node_modules/bluebird/js/release/async.js:16:14)

Both tests should pass, correct? Am I missing something, or is t.throws() favoring rejected promises over throw statements?

I am using AVA 0.8.0.

fn.withThrow() throws before even getting to t.throws: t.throws(fn.withThrow()). So t.throws() is not executed at all. The correct code would be:
t.throws(function () {
  fn.withThrow();
});

or:
t.throws(fn.withThrow);

Ah yes. @vdemedes  You're right. I figured I was staring directly at the problem. Thanks.


Update tensor_parallel.py

Resolve the issue of abnormal conversation performance in the Baichuan large model.
Fix the bug in the norm_head adaptation for Baichuan.
Fixes https://github.com/huggingface/text-generation-inference/issues/2780
https://huggingface.co/baichuan-inc/Baichuan2-13B-Chat/blob/main/modeling_baichuan.py#:~:text=self.weight.data %3D nn.functional.normalize(self.weight)

@OlivierDehaene OR @Narsil

We cannot really accept this.
This is a bug in Baichuan weights, not in our code.
The issue with your proposed fix is that we support tensor parallelism (TP), which means weight values will depend on what TP value you're using, leading to potentially even more massive discrepancies.
The "true" fix in that sense would be to load the entire weight, normalize it, and then split it across GPU, but it will lead to other issues, the first of which will be excess of VRAM usage, which can cause unwanted OOMs.
Baichuan should fix their weights (unless there's a valid reason to keep the unnormalized weights, but I don't think there's one).


Added variables to test framework and other improvements

Variables allow arbitrary string replacement in tests command
lines. New section of test configuration now defines default variable
values, other variables with values may be added or overridden from
command line.
Added -test switch to allow selecting only one/several tests from
configuration file.
Improved pass/fail diagnostics.
The first experimental step of converting configuration files is done
on stability.json checksum tests.

Checked, approved. I will rewrite other stability and performance tests for this semantic.

PR deleted from master branch because it wasn't intended to be merged there


MSID: 89830 Version: 2 DOI: 10.1101/2<IP_ADDRESS>91999

MSID: 89830
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>91999
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89830
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>91999

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89830v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>91999
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89830/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

The references have gone bonkers:

Looks like an extra reference section has been added ahead of the properly rendered one?
eLocations missing from the references.


KYLIN-3865 Centralize the zookeeper related info

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4226

5 of 105 (4.76%)  changed or added relevant lines in 5 files are covered.
13 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 26.921%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java
5
6
83.33%

server-base/src/main/java/org/apache/kylin/rest/service/JobService.java
0
2
0.0%

core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
0
5
0.0%

core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/ZookeeperDistributedLock.java
0
6
0.0%

core-common/src/main/java/org/apache/kylin/common/util/ZKUtil.java
0
86
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
5
77.81%

core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java
6
67.59%

Totals

Change from base Build 4216:
-0.02%

Covered Lines:
18944

Relevant Lines:
70368

💛  - Coveralls

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fb52a1d). Click here to learn what that means.
The diff coverage is 3.8%.

@@            Coverage Diff            @@
##             master     #512   +/-   ##
=========================================
  Coverage          ?   24.44%
  Complexity        ?     5024
=========================================
  Files             ?     1160
  Lines             ?    70368
  Branches          ?    10007
=========================================
  Hits              ?    17204
  Misses            ?    51428
  Partials          ?     1736

Impacted Files
Coverage Δ
Complexity Δ

...che/kylin/job/lock/zookeeper/ZookeeperJobLock.java
0% <ø> (ø)
0 <0> (?)

.../java/org/apache/kylin/common/KylinConfigBase.java
14.09% <0%> (ø)
41 <0> (?)

...java/org/apache/kylin/rest/service/JobService.java
0% <0%> (ø)
0 <0> (?)

...main/java/org/apache/kylin/common/util/ZKUtil.java
0% <0%> (ø)
0 <0> (?)

...n/job/lock/zookeeper/ZookeeperDistributedLock.java
0% <0%> (ø)
0 <0> (?)

...pache/kylin/job/impl/curator/CuratorScheduler.java
62.96% <66.66%> (ø)
7 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb52a1d...2f23cad. Read the comment docs.


add prettier config file for issue #159

🛠 Fixes Issue
Close #159.
👨💻 Changes proposed

add .prettierrc.json file
add .prettierignore file
ran prettier for every file so that others don't have to face unknown changes for no reasons.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
If you are not convinced enough to merge this PR, please read these articles:

why you need .prettierrc file
Prettier + Format On Save = Never worry about formatting JavaScript again
Snippet. My full Prettier (.prettierrc) config file

@RohitSaini7 fix your merge conflict

done

@RohitSaini7  Can you kindly fix the linter, prettier issue to avoid breaking the deployment process.

Re raised PR #181.


11.0 merge bad616b3064abe844cafd37aca6e39344a0c8f1f

@yelizariev , this PR needs https://github.com/it-projects-llc/misc-addons/pull/610 since web_website is ported there

Who will review functional part?

@yelizariev I'm already reviewing it now


logging in hangs intermittently

Using v2.5.0 but also noticed this in v2.4.0
My setup :

tries to collect every hour 6:00 - 20:00 sun-fri
is a process (python script) that is continuously active and based on time (pycron), it fires of the next collection.
runs in a separate container.

Recently I have seen that the logging in 'hangs' often at 8 or 9 in the morning but ystd also at 19:00, i.e. it shows me this in the log and then 'nothing' after...hangs forever

Now, when I restart the process all goes fine again and the next x runs have no issue...until it suddenly stops connecting
From what I could identify, it hangs in this part of pronoteAPI (get.repsonse seems to block??)
On the basis that I am not really known to rsa etc...apologies for not asking the right questions
Q1: as my process is a continuous one, should I possibly delete cookies after each (hourly) run?
Q2: I once received an error on MR not being set/available...would this help if I provide more info
Q3: might the container/image OS  have something to do with this?
...any other ideas you have?
        # get rsa keys and session id
        log.debug(f"Requesing html: {self.root_site}/{self.html_page}")
        get_response = self.session.request(
            "GET",
            f"{self.root_site}/{self.html_page}",
            headers=headers,
            cookies=self.cookies,
        )
        self.attributes = self._parse_html(get_response.content)
        # uuid
        self.encryption.rsa_keys = {
            "MR": self.attributes["MR"],
            "ER": self.attributes["ER"],
        }
        uuid = base64.b64encode(
            self.encryption.rsa_encrypt(self.encryption.aes_iv_temp)
        ).decode()
        # post
        json_post = {"Uuid": uuid, "identifiantNav": None}
        self.encrypt_requests = not self.attributes.get("sCrA", False)
        self.compress_requests = not self.attributes.get("sCoA", False)

Hello What error is causing the program to crash? And is it always the same error that makes the program crash? If the error is KeyError: MR then I know the problem and I have already got it with an app like yours. It is very hard to reproduce because it is very rare and I think that it comes from a bug in Pronote itself.

Until now, from what I have seen, in almost all cases it just hangs with the last line as in above screenshot,  ... how could I increase logging for pronotepy?
Once (only once) I had below error, it crashed and then waited for the next run and then again...stopped with above line.
    client = pronotepy.Client('https://'+prefix_url+'.index-education.net/pronote/eleve.html', username, password, _ent)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 290, in __init__
    super().__init__(pronote_url, username, password, ent)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 59, in __init__
    self.attributes, self.func_options = self.communication.initialise()
  File "/usr/local/lib/python3.9/site-packages/pronotepy/pronoteAPI.py", line 69, in initialise
    self.encryption.rsa_keys = {'MR': self.attributes['MR'], 'ER': self.attributes['ER']}
KeyError: 'MR'

update, this morning it ran fine 6+7+8 and now it hangs since 9. I will keep it hanging till late afternoon and see if eventually something happens...then I will restart again. Since I have a separate setup, I can modify the code locally and keep testing, please also let me know if I can increase logging info.

I don't understand what do you mean with

Error seems to indicate cache issue
The log you send me is when the app crash?

Ah, no... this is the log after restart, it has a line in it that refers to cache needing refresh... so.. for now we will then wait until it hangs again.

Yes I need the log when the app crash

If there is no error there is no crash.
Send me the log when you have the error KeyError: "MR"

you do know that is not how it works... :)
Not continuing on a log-in is also an issue ... and I agree that without feedback it is quite hard to deal with, it trill is an issue.
On the debug sent back above ... might it be that the cache is full due to my process re-re-rerunning hourly? Or is this cache-relate message a normal one when not using a browser? Repeating I am no python expert at all

Hi, I'm not sure what you mean by caching issues but pronotepy does not have any cache. If you're keeping the client between runs, then use client.refresh() to reinitialise the connection (it throws away the old Session object, so it basically loses any state known to the pronote server).
I think the issue could be with your network, possibly dropping the connection and then not properly timing out the request. The only part of pronotepy's code that could block for that long are http requests. I'm not aware of any loops or anything that could freeze and not throw an exception.
To make requests timeout (overwriting the default None value globally) after some time, you can add this at the start of your script:
import requests
from requests.adapters import TimeoutSauce

class MyTimeout(TimeoutSauce):
    def __init__(self, *args, **kwargs):
        if kwargs['connect'] is None:
            kwargs['connect'] = 5 # change here for different connection timeout
        if kwargs['read'] is None:
            kwargs['read'] = 5 # change here for different read timeout
        super(MyTimeout, self).__init__(*args, **kwargs)

requests.adapters.TimeoutSauce = MyTimeout

(snippet taken from https://stackoverflow.com/a/22377499/12216348)
I guess we should modify the Session and add it later just for pronotepy.

Yes Like @bain3 says : Forgot the cache error, this one doesn't concern us. It is a JavaScript error that is not triggered.
Just please send me the log when you have the error KeyError: "MR"

In hte log output it states to 'vider le cahce' as part of the error(?) message.
It hung again this morning and I now switched the order in which the script collects data of my kids.... just to find out if it is not coincidentally on the ENT/CAS side (guess not)

Last update:
After having switched the order in which I collect data for my kids, it ran fine from 22/6 11:00 to 23/6 16:00 ...
Then started hanging on 23/6 17:00 until today 27th.
As it now hangs for the 2nd child collection, previously being the 1st in row, it slowly seems to look like an issue/particularity with that CAS (atrium-sud). There is no error, it just hangs like this (as before)
2022-06-23 15:00:33,067 INFO INIT
2022-06-23 15:00:33,068 DEBUG [ENT https://www.atrium-sud.fr/connexion/login] Logging in with xxxxxxxxxxxxxxxx

I just checked and I think that the problem comes from the ENT atrium which must be overloaded, and which sometimes does not answer

Seems like a reasonable explanation and since we cannot (I guess) ask the ENT to provide a more stable setup, is there a way that pronote can build in a re-start or so? I am happy to test this out

And just now, afterr hanging again, I restarted it and got this
2022-06-28 08:57:46,555 DEBUG Html response1: b'<!DOCTYPE html>\r\n\r\n \r\n <base target="_blank" />\r\n <meta http-equiv="X-UA-Compatible" content="IE=edge" />\r\n <meta http-equiv="expires" content="0"/>\r\n <meta http-equiv="pragma" content="no-cache"/>\r\n <meta http-equiv="cache-control" content="no-cache"/>\r\n <link rel="schema.DC" href="http://purl.org/dc/elements/1.1/" />\r\n <title>CENTRE INTERNATIONAL VALBONNE - PRONOTE</title>\r\n <meta name="DC.title" content="CENTRE INTERNATIONAL VALBONNE - PRONOTE" />\r\n <meta name="description" content="PRONOTE gestionsso - CENTRE INTERNATIONAL VALBONNE - VALBONNE (006) - gestion des notes, absences, punitions, cahier de textes pour les \xc3\xa9tablissements scolaires." />\r\n <meta name="DC.description" content="PRONOTE gestionsso - CENTRE INTERNATIONAL VALBONNE - VALBONNE (006) - gestion des notes, absences, punitions, cahier de textes pour les \xc3\xa9tablissements scolaires." />\r\n <meta name="DC.creator" content="CENTRE INTERNATIONAL VALBONNE" />\r\n <meta name="DC.publisher" content="PRONOTE" />\r\n <meta name="DC.coverage" content="VALBONNE (006)" />\r\n <meta name="geo.placename" content="VALBONNE (006)" />\r\n <meta name="robots" content="index" />\r\n <link rel="apple-touch-icon" sizes="180x180" href="./images/apple-touch-icon.png" />\r\n <link rel="icon" type="image/png" href="./images/favicon-32x32.png" sizes="32x32" />\r\n <link rel="icon" type="image/png" href="./images/favicon-16x16.png" sizes="16x16" />\r\n <link rel="manifest" href="./images/manifest.json" />\r\n <link rel="mask-icon" sizes="any" href="./images/favicon.svg" color="#22874b">\r\n <meta name="apple-mobile-web-app-title" content="PRONOTE" />\r\n <meta name="msapplication-config" content="./images/browserconfig.xml" />\r\n <meta name="application-name" content="PRONOTE" />\r\n <meta name="msapplication-TileColor" content="#22874b" />\r\n <meta name="msapplication-TileImage" content="./images/mstile-144x144.png" />\r\n <meta name="theme-color" content="#22874b" />\r\n<link rel="stylesheet" type="text/css" href="E_15_C_88CE8EBFCD816ACBA5BA5230BF6550CDE33FC2A4AF7000000000_L_1036/espace/css/gestionsso.css"/>\r\n\r\n\r\n\r\n\r\n \r\n \r\n \r\n Java script non activ\xc3\xa9.\r\nVeuillez le r\xc3\xa9activer.\r\n

\r\n  PRONOTE 2021 - 0.2.10 gestion de vie scolaire, notes, comp\xc3\xa9tences, absences/retards/dispenses, incidents/punitions/sanctions, stages... INDEX \xc3\x89DUCATION\r\n \r\n\r\n'
Traceback (most recent call last):
  File "/app/pronote2mqtt.py", line 547, in <module>
    run(myParams)
  File "/app/pronote2mqtt.py", line 159, in run
    myPronote.getData(myParams.pronotePrefixUrl_2,myParams.pronoteUsername_2,myParams.pronotePassword_2,myParams.pronoteCas_2,myParams.pronoteGradesAverages_2,myParams.pronoteParent_2,myParams.pronoteFullName_2)
  File "/app/pronote.py", line 44, in getData
    client = pronotepy.Client('https://'+prefix_url+'.index-education.net/pronote/eleve.html', username, password, _ent)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 382, in __init__
    super().__init__(pronote_url, username, password, ent, qr_code)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 81, in __init__
    self.attributes, self.func_options = self.communication.initialise()
  File "/usr/local/lib/python3.9/site-packages/pronotepy/pronoteAPI.py", line 80, in initialise
    "MR": self.attributes["MR"],
KeyError: 'MR'

Seems like a reasonable explanation and since we cannot (I guess) ask the ENT to provide a more stable setup, is there a way that pronote can build in a re-start or so? I am happy to test this out

I think it's you who have to provide in your script that reboot if it didn't work

And just now, afterr hanging again, I restarted it and got this After a second restart the 'MR' issue no longer showed....
2022-06-28 08:57:46,555 DEBUG Html response1: b'<!DOCTYPE html>\r\n\r\n \r\n <base target="_blank" />\r\n <meta http-equiv="X-UA-Compatible" content="IE=edge" />\r\n <meta http-equiv="expires" content="0"/>\r\n <meta http-equiv="pragma" content="no-cache"/>\r\n <meta http-equiv="cache-control" content="no-cache"/>\r\n <link rel="schema.DC" href="http://purl.org/dc/elements/1.1/" />\r\n <title>CENTRE INTERNATIONAL VALBONNE - PRONOTE</title>\r\n <meta name="DC.title" content="CENTRE INTERNATIONAL VALBONNE - PRONOTE" />\r\n <meta name="description" content="PRONOTE gestionsso - CENTRE INTERNATIONAL VALBONNE - VALBONNE (006) - gestion des notes, absences, punitions, cahier de textes pour les \xc3\xa9tablissements scolaires." />\r\n <meta name="DC.description" content="PRONOTE gestionsso - CENTRE INTERNATIONAL VALBONNE - VALBONNE (006) - gestion des notes, absences, punitions, cahier de textes pour les \xc3\xa9tablissements scolaires." />\r\n <meta name="DC.creator" content="CENTRE INTERNATIONAL VALBONNE" />\r\n <meta name="DC.publisher" content="PRONOTE" />\r\n <meta name="DC.coverage" content="VALBONNE (006)" />\r\n <meta name="geo.placename" content="VALBONNE (006)" />\r\n <meta name="robots" content="index" />\r\n <link rel="apple-touch-icon" sizes="180x180" href="./images/apple-touch-icon.png" />\r\n <link rel="icon" type="image/png" href="./images/favicon-32x32.png" sizes="32x32" />\r\n <link rel="icon" type="image/png" href="./images/favicon-16x16.png" sizes="16x16" />\r\n <link rel="manifest" href="./images/manifest.json" />\r\n <link rel="mask-icon" sizes="any" href="./images/favicon.svg" color="#22874b">\r\n <meta name="apple-mobile-web-app-title" content="PRONOTE" />\r\n <meta name="msapplication-config" content="./images/browserconfig.xml" />\r\n <meta name="application-name" content="PRONOTE" />\r\n <meta name="msapplication-TileColor" content="#22874b" />\r\n <meta name="msapplication-TileImage" content="./images/mstile-144x144.png" />\r\n <meta name="theme-color" content="#22874b" />\r\n<link rel="stylesheet" type="text/css" href="E_15_C_88CE8EBFCD816ACBA5BA5230BF6550CDE33FC2A4AF7000000000_L_1036/espace/css/gestionsso.css"/>\r\n\r\n\r\n\r\n\r\n \r\n \r\n \r\n Java script non activ\xc3\xa9.\r\nVeuillez le r\xc3\xa9activer.\r\n

\r\n  PRONOTE 2021 - 0.2.10 gestion de vie scolaire, notes, comp\xc3\xa9tences, absences/retards/dispenses, incidents/punitions/sanctions, stages... INDEX \xc3\x89DUCATION\r\n \r\n\r\n'
Traceback (most recent call last):
  File "/app/pronote2mqtt.py", line 547, in <module>
    run(myParams)
  File "/app/pronote2mqtt.py", line 159, in run
    myPronote.getData(myParams.pronotePrefixUrl_2,myParams.pronoteUsername_2,myParams.pronotePassword_2,myParams.pronoteCas_2,myParams.pronoteGradesAverages_2,myParams.pronoteParent_2,myParams.pronoteFullName_2)
  File "/app/pronote.py", line 44, in getData
    client = pronotepy.Client('https://'+prefix_url+'.index-education.net/pronote/eleve.html', username, password, _ent)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 382, in __init__
    super().__init__(pronote_url, username, password, ent, qr_code)
  File "/usr/local/lib/python3.9/site-packages/pronotepy/clients.py", line 81, in __init__
    self.attributes, self.func_options = self.communication.initialise()
  File "/usr/local/lib/python3.9/site-packages/pronotepy/pronoteAPI.py", line 80, in initialise
    "MR": self.attributes["MR"],
KeyError: 'MR'

Thanks I will analyse the log this afternoon. And I will try to fix the KeyError.

Seems like a reasonable explanation and since we cannot (I guess) ask the ENT to provide a more stable setup, is there a way that pronote can build in a re-start or so? I am happy to test this out

I think it's you who have to provide in your script that reboot if it didn't work

Not sure how to do this as it hangs in pronoteAPI.py...  any pointers/ideas welcome (note: not a real dev. myself)... donot need solution just direction...then internet will help me further :)

I think that it hangs more specifically in the function atrium_sud. I suggest you use a timeout.

I just fixed the KeyError: "MR" issue

Will you roll this out in a release soon ? As I am embedding pronotepy in a image that would be easiest...but maybe you want me to test this first which is perfectly fine too, should I use 'master' or ... which file(s) to update?

I just fixed the KeyError: "MR" issue

Could you make a PR? I'll follow up with making sure pronotepy's requests.Session has a timeout.

Yes I will do that this evening

Didn't mean to close this, we still need to add the timeouts. But the KeyError issue may be fixed now.

I have added "master" to my container and will see what happens. With the schoolyear ending there will be much less use so probably also less risk in hanging...but I will let you know. Thanks for now!

And with the new year, the issue is back on the board, my agora06 was hanging this morning at 7:00 (6:00 run was fine). I assume that the 'timeouts' have not yet been added?

Nope, not yet. You could try to modify the requests module globally like I suggested. Noone else seems to have this issue... If the problem is in fact because of requests that do not timeout, then I can make it easier to modify / add our own timeout class.

Agree that a single-person-issue should not get high prio. I added the 'import requests' suggestion now...let's wait and see.
Thanks

Any updates on this?

Sorry for not returning ... I added the suggested part in my script and until now all seems to be fine so from my pov you can close this or use it to add some stuff to the pronotepy package


The Elliptic package 6.5.2 for Node.js allows ECDSA signature malleability via variations in encoding, leading '\0' bytes, or integer overflows.

Hi
Issue:
The Elliptic package 6.5.2 for Node.js allows ECDSA signature malleability via variations
in encoding, leading '\0' bytes, or integer overflows.
This could conceivably have a security-relevant impact if an application relied on a
single canonical signature.

I'm using Elliptic 6.5.3 version but still I'm facing this issue in my project.
Could you please let me know what could be the reason for this?
I tried npm install<EMAIL_ADDRESS>and
npm audit fix
and I played around lot of other ways but still issue persists.

Thanks
Image reference:
Note: Actually, this issue is throwing by laravel-mix. laravel-mix is internally using few packages and those packages are internally using elliptic.

Check the path in that screenshot. It's many dependencies below mix. Without knowing more, I don't think I can do anything on the Mix end.


[Feature] human eval support

Hi @YLGH Nice work! May you support human eval? Thanks.

ref https://github.com/openai/simple-evals


Enable assertions

Related issues
Closes #97
Description

Enables assertions in the run and test gradle configurations
You may need to enable assertions in IntelliJ as outlined here

Codecov Report

Merging #99 (9efa63e) into master (0b20150) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage     60.19%   60.19%
  Complexity      353      353
=========================================
  Files            80       80
  Lines          1349     1349
  Branches        129      129
=========================================
  Hits            812      812
  Misses          467      467
  Partials         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b20150...9efa63e. Read the comment docs.


envoy: switch to JSON; log listener events

This adds more details to the access log, and they should be self-describing now.
I enabled listener logs to help with requests like https://pachyderm.slack.com/archives/CEY70V55G/p1669756711368999.  If you do something like echo -e '\r\n' | socat tcp-connect:localhost:80 stdio, we'll log something like: {"tx_bytes":0,"duration_ms":0,"response_code":0,"request_attempt_count":0,"downstream_remote_address":"<IP_ADDRESS>","connection_id":113,"protocol":"HTTP/1.1","message":"listener log","rx_bytes":3,"response_flags":"-","severity":"info","request_headers_bytes":0,"listener":"proxy-http","timestamp":"2022-11-30T05:21:40.397Z"}, which might be helpful.

Can we filter out the kube probes from logging?

@tybritten Yeah, I'll add a filter to the admin access logger to remove requests from kube-probe.  Will send you a PR for that.


Remove IDE generated files

I see we have committed some IDE (eg: .settings dir files) related files in repo. We should clean this up. Most of IDE now a day should able to open the pom.xml file without further need of customization. If there is, it should be user specific and not need to be in repo.
The following command should display a list of what to remove.
git ls-files --ignored --exclude-from=.gitignore

This is now fixed.


UIViewController in TabBarViewController hidden tabbar  item.snp.bottom.equalToSuperview() invalid

Bottom
    let logoView = OWSeriesLogoView()
    view.addSubview(logoView)
    logoView.snp.makeConstraints { (maker) in
        maker.top.equalTo(menuView.snp.bottom)
        maker.left.right.equalToSuperview()
        maker.bottom.equalToSuperview()
    }

Issue Info

Info
Value

Platform
e.g. ios

Platform Version
e.g. 9.0

SnapKit Version
e.g. 4.0.0

Issue Description
UIViewController in TabBarViewController hidden tabbar  item.snp.bottom.equalToSuperview()  invalid
There are 44 blanks from the bottom

Not really sure I can help here your sample code is rather incomplete and the description lacking some details.
Are you trying to create auto layout pinned to items in the tab bar? I'm not sure if that is legal in auto layout.


Did more translations

Finished the code section
Finished general section
nearly finished the play section

Still don't understand which/what kind of  "Poll" # Tooltip on poll button from /play is meant.

Thank you, @oliver-j!


Fix weird border styling behavior for hover date (#378)

My solution for #378! I'm still noticing this weird curviness to the top-<left|right> border styles. I'm not sure how to solve that.
Let me know what you think. Thanks!

Coverage decreased (-1.4%) to 85.928% when pulling 4c8e7eb3f743d51b38040539049c00c42622c39f on ConAntonakos:fix-issue-378 into 091a34f101cbd7cdab4fedf537c43d253e5a79e5 on airbnb:master.

Sorry for taking so long to get to this! I think a problem is that in adding these modifiers (to be fair, this is largely due to the way we use modifiers right now), we're going to take a performance hit. It would be cool if it were possible to do this mostly in CSS. :/ I will investigate it a bit more.

No problem, @majapw! I think I agree with you regarding perf, though I haven't tested it thoroughly. I simply wanted to get this solution out at least since it was the first one that came to mind. I also agree about possibly changing this via styling only. Do you think it's possible with the current <table> <td> implementation? Do you think that might have to change? I'd be more than happy to rewrite the PR.

This still needs to be addressed, but because tables are hard I'm going to close it for now because I do not believe this is the correct solution.

No worries. Thanks for checking in. I'd be happy to update the PR once a better solution is figured out.


ProjectSettings: Ensure 'editor/' settings aren't nested

Having a mix of settings with and without subcategory makes the 'Editor'
section stand out with a weird UX, as instead of simply being a foldable
section like the others, it also holds its own top-level settings and is
therefore selectable.
This wasn't the case in 3.4, and is fixed in 4.0 by refactoring, so for
3.5 we should preserve the 3.4 UX, even if it's not the best. This was
reported in this Reddit thread.
Project Settings in 3.4.4

Project Settings in 3.5 RC 4

(It's hardly visible but the "Editor" foldable section is selected here and included some properties. No other foldable section has this behavior.)
Project Settings in this PR

Breaks compat for the renamed settings which have been introduced in 3.5 development - if some plugins rely on them they will need to be adjusted (CC @ChronicallySerious for the VCS plugin).

The git plugin shouldn't break compat with this because the GDNative plugin doesn't look into any project level settings. The Version Control settings are only picked up from the editor and written to by the editor.

The 'mono' section has the same issue


serial: add baseload to maxResources before padding

Creating padding pods without considering the current baseload on the node causes scheduling those pods to fail due to insufficient resources on that node.
Account for the base load in the padding resources to avoid such cases.
Signed-off-by: shereenH<EMAIL_ADDRESS>

/work-in-progress cancel

/unhold

/retest

/cc

the padding pod still requests total available resources on all numas. this wouldn't work for pod TM scope thus need to split the load into multiple pods.

true, we need to revisit the amount of resources request after we took the baseload into account. So it is like

take into account the baseload when do padding
take into account the free resources including the baseload when running the testing pod

closing the PR, need more modifications and better to split commits into single PRs


Error: Cannot find module 'bonjour-hap'

Appears when homebridge is restarted after installing the homebridge-air-q plugin.
Maybe similar to https://github.com/lprhodes/homebridge-broadlink-rm/issues/540

Was solved in version 1.0.1 by commit e7f7cc4.


Jest 27+ / Jest encountered an unexpected token

Hello,
Versions:

Angular 13
@joeattardi/emoji-button ^4.6.2
Jest 27.5.0

I run my tests with Jest 27+ and I have a runtime error.
It's an Angular and nx project.
I tried several Jest configurations but it does not work.
have you ever had this error ?

Jest throws this error when it encounters what it thinks is invalid JS code.
Is it just the emoji-button code that's causing this?
Can you share some example code?

I tried with a new angular project with basic config for jest.
The tests pass at first and as soon as I add the lib in a component the tests fail.
Test passes if I remove the creation of the object.

Is there any additional output that tells you what the unexpected token is? If we know that we can hopefully figure out how the config needs to be adjusted.

Here is a basic project with Angular / Jest and @joeattardi/emoji-button where I got the mentioned error with jest.
https://github.com/alg-ext/angular-jest-emoji-button

Great, thanks! I see the problem now.
Currently, Emoji Button is only distributed as an ES Module. To run in Jest, Jest needs to transform it into a format that Jest (really, Node.js) understands.
It's not a great fix but you need to extend the transformIgnorePattern defined by the Angular preset so that @joeattardi/emoji-button is no longer ignored - then it will be transformed and Jest can understand it.
Change your jest.config.js so it looks like this:
const presets = require('jest-preset-angular/presets');

module.exports = {
  preset: "jest-preset-angular",
  setupFilesAfterEnv: ["<rootDir>/setupJest.ts"],
  transformIgnorePatterns: [
    `${presets.defaults.transformIgnorePatterns[0]}(?!@joeattardi/emoji-button)`
  ]
};

This will fix your unexpected token but then you'll have a new problem - jsdom, which Jest uses, does not support IntersectionObserver so you'll need to mock it otherwise your tests will fail saying IntersectionObserver is not defined.
Before you can fix this there's one other issue with your tsconfig.spec.json file.
In the types array defined from lines 6-8, remove "jasmine" and add "jest", otherwise TypeScript will fail when you use any of the jest-specific things (test, jest, etc.)
Once you've done that, open setupJest.ts and add this line:
window.IntersectionObserver = jest.fn();

This mocks the IntersectionObserver. Once you make these changes, running npm test should result in passing tests.
Sorry for the difficulty here. I am close to finishing the new major rewrite of Emoji Button (version 5) and this is something I will keep in mind. For example, I could provide a commonjs bundle for use in tests so you don't have to transpile the ESM inside node_modules.
Hope this helps!

It works !!
For the tsconfig.spec.json It was a demonstration project for you, I had not configured in detail.
I replicated your solution in my real more complex project and it works fine.
Thank you for your detailed explanations.

I am with same error but with react, anyone has the solution?

It's likely the same underlying issue. Jest can't understand ES modules and this is the cause of the error - assuming you're using Jest.
You'll need to make a similar change to the transform ignore pattern so that TypeScript (or Babel or whatever you're using) will transpile the Emoji Button module.
Depending on what your test is doing you could always simply mock the @joeattardi/emoji-button module within Jest to provide a simple mock implementation.
This is probably a better solution actually. Your tests shouldn't be testing the functionality of Emoji Button itself but how your component interacts with it. Mocking the module lets you easily test the different scenarios you expect.


Possible to "chain" syntax highlighting?

Hello, I'm writing json files with some jinja in it.
Would it be possible to "chain" these two templating parts?

It will be eventually, but not currently. It's a limitation of Code itself.

See my comment in https://github.com/wholroyd/vscode-jinja/issues/19 for background.


ImportError: cannot import name 'want_bytes' from 'itsdangerous'

I started a new project with Flask-Session, which raises ImportError: cannot import name 'want_bytes' from 'itsdangerous' (c:\python37\lib\site-packages\itsdangerous\__init__.py).
Traceback (most recent call last):
  File "c:\python37\lib\site-packages\flask\cli.py", line 235, in locate_app
    __import__(module_name)
  File "C:\Users\PC\Desktop\BookLib\application.py", line 4, in <module>
    from flask_session import Session
  File "c:\python37\lib\site-packages\flask_session\__init__.py", line 16, in <module>
    from .sessions import NullSessionInterface, RedisSessionInterface, \
  File "c:\python37\lib\site-packages\flask_session\sessions.py", line 23, in <module>
    from itsdangerous import Signer, BadSignature, want_bytes
ImportError: cannot import name 'want_bytes' from 'itsdangerous' (c:\python37\lib\site-packages\itsdangerous\__init__.py)

The quick fix I did was to downgrade to the previous version, itsdangerous==0.24.

itsdangerous 1.1.0 was just released and contains a fix for this. Flask-Session should still be fixed so it doesn't rely on this, but it won't fail for now. You can upgrade itsdangerous and continue to use Flask-Session.


During component loading, an error is logged into console

During component loading (page refresh), the following error is logged into the console.
"Warning: Failed prop type: The prop addonType is marked as required in InputGroupButton, but its value is undefined."

fixed with commit 4c12e90f85f347519368883bea4ac1f4e84633d0


on using composer to install i get the following error

The contents of https://packagist.org/p/provider-2015-04$cbc4f6fb63ad5de044caa64c8035a85919ee3ddb38a39a1954a46e5702c0335f.json do not match its signature. This should indicate a man-in-the-middle attack. Try running composer again and report this if you think it is a mistake.

never mind, installed successfully on 2nd attempt.


Add Recently banked items plugin

You should change the plugin class file to not be BankPlugin.

You should change the plugin class file to not be BankPlugin.

Fixed. Changed to RecentBankPlugin


Missing key/value in driver struct

Hey,
I started receiving this error on latest main:
  File "linalg/_matmul_perf_model.py", line 87, in estimate_matmul_time
    dram_bw = get_dram_gbps(device) * (
  File "/triton/triton/python/triton/testing.py", line 379, in get_dram_gbps
    bus_width = driver.active.utils.get_device_properties(device)["mem_bus_width"]
KeyError: 'mem_bus_width'

I think it is due to this change which missing an extra key/value in the struct
https://github.com/openai/triton/commit/ed63a37366e8d1a9393abff7ba8e970733256446#diff-0d645ca31937abba9a3357062ee2c3708f6d49f66d7842d5f6577a2044f962f5
There are 6 pairs and there should be 7.
https://github.com/openai/triton/blob/ed63a37366e8d1a9393abff7ba8e970733256446/third_party/nvidia/backend/driver.c#L74

https://github.com/openai/triton/pull/3848

I think close by above


add rudimentary workflow based on github example

based on github's default "Python package" workflow

yeah... obviously need to get me a windows box to test powershell commands locally

yeah... obviously need to get me a windows box to test powershell commands locally

as an alternative you can use shell: bash to use git-bash inside windows


Add ability to use Bastion to tunnel database connection

As a developer using Azure CLI I'm frustrated that I have to set up and maintain a whole Virtual Machine just to access a database that's in a private VNet
I'd like to be able to use the Azure Bastion native tunnel feature to directly tunnel to a database inside the connected VNet in the same manner as currently is used for accessing a VM via SSH or RDP. In my particular case I'd like to connect to an Azure Database for MySQL flexible server instance that is set to Private Access (VNet Integration) - though it'd be good for any solution to handle any database.
Possible example:
az network bastion tunnel --resource-group test --name bastion-test --target-resource-id "$(az mysql flexible-server show --resource-group test --name db-test --query id --output tsv)" --resource-port 3306 --port 3306

mysql -u db_admin -p -h <IP_ADDRESS>

Alternatives exist:

Create a VM inside the VNet, expose SSH to the world, use SSH to connect to the VM, then in the VM connect to the database.
Create a VM inside the VNet, expose SSH to the world, and use SSH to tunnel the database traffic.
Create a VM inside the VNet, create a Bastion host, connect to the VM via Bastion in Azure Portal, then in the VM connect to the database.
Create a VM inside the VNet, create a Bastion host, connect to the VM via Azure CLI az network bastion tunnel, then in the VM connect to the database.

Note that every alternative requires the creation of a VM. A VM that my company has to maintain. Bastion's promise is to limit exposure - but is currently limited to VMs. VMs aren't the only services that should have limited exposure.

Note that attempting to accomplish the above example, since it is a currently unsupported idea, using az cli 2.34.1 will result in the tunnel crashing:
cli.azure.cli.command_modules.network.custom: Opening tunnel on port: 3306
cli.azure.cli.command_modules.network.custom: Tunnel is ready, connect on port 3306
cli.azure.cli.command_modules.network.custom: Ctrl + C to close
urllib3.util.retry: Converted retries value: 1 -> Retry(total=1, connect=None, read=None, redirect=None, status=None)
msal.authority: openid_config = {'token_endpoint': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/oauth2/v2.0/token', 'token_endpoint_auth_methods_supported': ['client_secret_post', 'private_key_jwt', 'client_secret_basic'], 'jwks_uri': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/discovery/v2.0/keys', 'response_modes_supported': ['query', 'fragment', 'form_post'], 'subject_types_supported': ['pairwise'], 'id_token_signing_alg_values_supported': ['RS256'], 'response_types_supported': ['code', 'id_token', 'code id_token', 'id_token token'], 'scopes_supported': ['openid', 'profile', 'email', 'offline_access'], 'issuer': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/v2.0', 'request_uri_parameter_supported': False, 'userinfo_endpoint': 'https://graph.microsoft.com/oidc/userinfo', 'authorization_endpoint': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/oauth2/v2.0/authorize', 'device_authorization_endpoint': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/oauth2/v2.0/devicecode', 'http_logout_supported': True, 'frontchannel_logout_supported': True, 'end_session_endpoint': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/oauth2/v2.0/logout', 'claims_supported': ['sub', 'iss', 'cloud_instance_name', 'cloud_instance_host_name', 'cloud_graph_host_name', 'msgraph_host', 'aud', 'exp', 'iat', 'auth_time', 'acr', 'nonce', 'preferred_username', 'name', 'tid', 'ver', 'at_hash', 'c_hash', 'email'], 'kerberos_endpoint': 'https://login.microsoftonline.com/392b58e2-29ce-464a-b20a-51b8bb9c217e/kerberos', 'tenant_region_scope': 'NA', 'cloud_instance_name': 'microsoftonline.com', 'cloud_graph_host_name': 'graph.windows.net', 'msgraph_host': 'graph.microsoft.com', 'rbac_url': 'https://pas.windows.net'}
cli.azure.cli.core.auth.msal_authentication: UserCredential.get_token: scopes=('https://management.core.windows.net//.default',), kwargs={}
msal.application: Cache hit an AT
msal.telemetry: Generate or reuse correlation_id: 2268786a-c498-4e24-8974-0d17fa404329
urllib3.connectionpool: Starting new HTTPS connection (1): REDACTED.bastion.azure.com:443
urllib3.connectionpool: https://REDACTED.bastion.azure.com:443 "POST /api/tokens HTTP/1.1" 500 None
msrest.exceptions: Unexpected internal error
Exception in thread Thread-1 (_start_tunnel):
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 1009, in _bootstrap_inner
    self.run()
  File<EMAIL_ADDRESS>line 946, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 8232, in _start_tunnel
    tunnel_server.start_server()
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/network/tunnel.py", line 184, in start_server
    self._listen()
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/network/tunnel.py", line 117, in _listen
    auth_token = self._get_auth_token()
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/network/tunnel.py", line 104, in _get_auth_token
    raise exp
msrestazure.azure_exceptions.CloudError: Unexpected internal error

@kf6kjg Azure Bastion is currently designed for connecting to VMs like you've mentioned. The Azure Feedback forum would be the best place to get this idea recorded and have users up vote for it to gain traction.
Once the service supports it, then Azure CLI too would be updated to support the new scenarios as required.

I came here to file this bug also, I'm trying to tunnel to cosmosdb and it fails with this same error.
This is a legit bug at least in the sense that it shouldn't be crashing with an Unexpected internal error and should probably at least give feedback about what is going wrong.

After running az network bastion tunnel --resource-group bieno-cih-t-shared-services --name bastion --target-resource-id "$(az mysql flexible-server show --resource-group bieno-cih-t-shared-services --name cih --query id --output tsv)" --resource-port 3306 --port 33060
I get a different error
msrestazure.azure_exceptions.CloudError: Resource id is of an invalid format:

Again, it should just check the resource type and throw an error saying that the command will only work specifically for VM's and cannot be used to tunnel to whatever resource type is attempting to be tunneled to.

Moved to https://feedback.azure.com/d365community/idea/9f8d9743-b0ae-ec11-a81c-6045bd7d1bee

I get a 404 on this link. Any one have any update or planned status on this capability?

🤦♂ Lovely of MS. I'm the author of it and I can't even find it. Looks like it got deleted.

Create a VM inside the VNet, create a Bastion host, connect to the VM via Azure CLI az network bastion tunnel, then in the VM connect to the database.

Are there any resources that can explain, how we can establish connection with database server using the above method? I am particularly looking for the final step. I want to run mysql commands from local, that can get forwarded to mysql flexible server (in private network) through the bastion host and VM. @kf6kjg

Create a VM inside the VNet, create a Bastion host, connect to the VM via Azure CLI az network bastion tunnel, then in the VM connect to the database.

@kf6kjg , Can you provide any documentation on how the above can be done? In AWS, we can do it simply using SSM. In Azure, I am unable to figure out as the docs aren't clear.
Once I establish the bastion tunnel from localhost to VM, is it possible to connect to database without explicitly ssh'ng into VM.

For CosmosDB we ended up running a socks5 proxy server in a pod inside of aks. Then you use kubectl port-forward... to your proxy and then configure your database connection string to point to the localhost port. To connect to azure sql server you can setup an nginx reverse proxy to your database as well. Theres some tricks but it works, it will even go through private links.
Thats all bastion is really is a proxy tunnel to a VM.


Option to make pipeline drawer expanded by default

Currently the collapsed pipeline 'menu' kind of hides other pipelines for newcomers to the CI until you discover it. Would be nice to be able to have the menu shown be default (and keep hidden toggle state in browser storage) or to be able to set a pipeline overview as starting page instead of the main pipeline.

Moved to concourse/concourse#1118


debian-based Dockerfile

This is similar to #51 but resolves a few issues:

doesn't run as the root user by default (this can be changed at runtime of course)
add missing grepcidr dependency

This is based on Debian because that is what I am most familiar with: even though there seems to be a grepcidr3 package in Alpine, I couldn't figure out how to install it in the build.
Closes: #49

Thanks for the contributions everyone, haven't had a chance to test this out yet (very busy period), but hopefully will ASAP :-)

hey no problem! :)
though not to micromanage or anything, but #51 is still open, and the comments i made there haven't been adressed.  :)

Yeah I did address those in a PR against @33Fraise33's code here.
Perhaps not the best way, I'm not a daily git user :-) I will eventually commit directly to #51 if there are no feedbacks.
Feel free to comment with any feedback you may have. Thanks again!

If I was you, i would just merge the other MR and patch on top, or write something new from scratch. It's kind of odd to see a MR against a fork, but i guess that might make sense too!


Implement React Aria Components

This PR implements the React Aria Components RFC.
For now, the docs have after_version defined so they will not go to production immediately. When we are ready for the first alpha release, we can remove this, and they will appear as a new collapsed section at the bottom of the navigation sidebar (as shown in the docs link on this PR). Once we release the stable version, they will become the default API and the hooks will be grouped under additional collapsable sections. The groupings are defined using the type key in the MDX files, which can be enabled with the ENABLE_PAGE_TYPES flag in Layout.js.
This is a very large PR, but most of it is documentation. Might be good if reviewers could split that up so that each person doesn't need to review every page. The file filters at the top of the diff might also be useful for narrowing whether you're looking at code vs docs. There is still more to come including TS improvements and DnD, but didn't want to expand this branch any further.

our data attributes are pretty generic, how confident are we about conflicts, should we namespace?

I was thinking that you would probably never target a CSS selector using only the data attribute, they'd always be scoped by a react-aria selector. So e.g. .react-aria-Popover[data-entering].

some docs pages like combobox's complex items, <Text slot=... is repeated a lot

It's copied straight from the Spectrum docs 😉

@snowystinger I think this was replying to me but you edited my comment? 😂

I meant some other library or application using those data attributes as well, maybe putting other types of data in them, maybe on other dom elements, but maybe passing them to ours as well

I think we could probably add a prop later such as dataAttributePrefix which would allow people to customize the prefix for the data attributes to be whatever they like. This way the attributes are short by default but can be namespaced when needed. We could add this later if requested as well.

@snowystinger I think this was replying to me but you edited my comment? 😂

Whoops, definitely didn't mean to do that.

I think we could probably add a prop later such as dataAttributePrefix which would allow people to customize the prefix for the data attributes to be whatever they like. This way the attributes are short by default but can be namespaced when needed. We could add this later if requested as well.

I think dataAttributePrefix makes sense. Thanks

@ktabors
Good feedback, thanks!

Since we're exposing the slots, more than we do in RSP, do we need to explicitly list them for each component? I can infer them from "Styling" section of docs pages, along with examples (and css).

I think this is a good idea. We could probably expand the anatomy section to be a bit more explicit about what slots are available and how to access them. The anatomy diagram shows them but doesn't really describe the API for each one. We could add a table for each sub component with slots showing the API for each and some description of what it's for. This could include slots that are accessed via the slot prop (e.g. <Text slot="description">) as well as via a specific child component (e.g. <Keyboard>).

Along a similar vein, when I got to the "Advanced customization" section of the ComboBox docs, it talked about "contexts" for the component and children. I realized I saw hints of component contexts in the docs I'd looked at, but nothing explicit for any component. I thought we wanted users to be more aware of and use them.

Yeah this section definitely needs work. The goal is to show that you could swap out just one part of a component with a custom one without replacing the whole thing, allowing hooks and components to be mixed and matched. But without writing a giant example, it's kinda hard to convey how this works. It's also lacking some use cases for why you might do this. I think we'll need to turn the list of links to the hooks into a table with both the hooks and the associated context, and also add some use cases for each component about when hooks would be appropriate (e.g. custom DOM structure, overriding events/behaviors/state, etc). We also probably need a more general page covering this type of customization in general. Some ideas needed here.

Should all the react aria components have the "alpha" badge? I saw that the section did, but can we be more explicate?

For now I thought it looked a bit over the top to have every single page in that section have the alpha badge, so I put it on the whole section instead.


ServeiceWorker update with reload

after updating the webside on normal chrome the webside gets reloaded with the new version with this serviceWorker config:
export default {
	onUpdate: registration => {

		registration.unregister().then( () => {

			window.location.reload();

		} );

	},
	onSuccess: registration => {

		console.info( 'service worker on success state' );
		console.log( registration );

	},
};

the TWA/PWA app do not reload the web contend

It seems you are having caching issues on the Service Worker. The Service Worker behaviour in a Trusted Web Activity is exactly the same as in the regular Progressive Web App.

Hey @andreban,
any idea how i can debug this? it just works in normal chrome ( pc and android)

ok after i clear the cache in the android apps  than the new version is loaded!

Overall, you shouldn't need uninstall / reload the to update the Service Worker. Here are some resources that may help:

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/update
https://developers.google.com/web/fundamentals/primers/service-workers/lifecycle#manual_updates

Workbox is a tool that takes away the complexity of Service Workers and may help: https://web.dev/workbox/
Finally, if you still have questions, I'd recommend asking on https://stackoverflow.com/questions/tagged/service-worker
I'm closing this issue as it's unrelated to Bubblewrap.

hmm
i not complete understand why this is unrelated to pwa/twa the service-worker implementation i use is with
workbox and works just fine on chrome android and pc and firefox but not on pwa/twa with Bubblewrap
webpack config is
new WorkboxWebpackPlugin.GenerateSW( {
    			clientsClaim: true,
    			exclude: [ /\.map$/, /asset-manifest\.json$/ ],
    			navigateFallback: './index.html',
    			navigateFallbackDenylist: [
				  // Exclude URLs starting with /_, as they're likely an API call
				  new RegExp( '^/_' ),
				  // Exclude any URLs whose last part seems to be a file extension
				  // as they're likely a resource and not a SPA route.
				  // URLs containing a "?" character won't be blacklisted as they're likely
				  // a route with query params (e.g. auth callbacks).
				  new RegExp( '/[^/?]+\\.[^/]+$' ),
    			],
			  } ),

so lets be clear service-worker works just fine ( with manual update )

or is the idea i need to Release a new twa app each time if i changed something in the webappß


Modified go.mod for the common-host-lib-changes done for iscsiadm logout

Modified go.mod and go.sum and the vendor files for the common-host-libs PR#138
Please review

I have updated the vendor as per https://github.com/hpe-storage/csi-driver/pull/229/commits/5b2174609178d2c6edf58a66620153fc4968ca15 . You can close this PR and changes will be available soon.

Closing the PR as per the Raunak's comment


feats = np.array(feats)[:,0,:]  # [splits, embedding dim] IndexError: too many indices for array

for epoch in range(7000): # Random choice utterances from whole wavfiles
# A merged utterance contains [10,20] utterances
splits_count = np.random.randint(1, 5, 1)
print('this is splits_count',splits_count,splits_count[0])
path_spks = random.sample(path_spk_tuples, splits_count[0])
utterance_specs, utterance_speakers = load_data(path_spks, min_win_time=500, max_win_time=1600)
feats = []
for spec in utterance_specs:
spec = np.expand_dims(np.expand_dims(spec, 0), -1)
v = network_eval.predict(spec)
feats += [v]
print(np.array(feats))
    feats = np.array(feats)[:,0,:]  # [splits, embedding dim]
    train_sequence.append(feats)
    train_cluster_id.append(utterance_speakers)
    print("epoch:{}, utterance length: {}, speakers: {}".format(epoch, len(utterance_speakers), len(path_spks)))

np.savez('training_data', train_sequence=train_sequence, train_cluster_id=train_cluster_id)

I changed np.random.randint(1, 5, 1) to 1 to 5 as i have only 4 speaker dataset as given. I am getting an error at line
feats = np.array(feats)[:,0,:]  # [splits, embedding dim]
main()
File "generate_embeddings.py", line 196, in main
feats = np.array(feats)[:,0,:]  # [splits, embedding dim]
IndexError: too many indices for array

you must assure the shape of feats is right.For example:(256,512),the 512 is your observation_dim


Not working on cocoon

I'm having trouble getting this to work on cocoon.io.  Without it, it works, but with it I get error messages like 11-14 22:07:06.642 W/FA (12263): Measurement Service called with unknown id version: @2131230845.
See also this discussion in the cocoon forums:
https://forums.cocoon.io/t/firebase-analytics-plugin-not-working/4159
I'm not really sure on which end the problem lies, so a positive confirmation of this working in cocoon would be good. Or otherwise, any hint what the problem could be would also be great.

are you building locally or using their equivalent of phonegap build? if the latter i suspect that they also do not support hooks and you'd have to manually copy config files in place and hard code your firebase app id and api key in plugin.xml

I'm using the cloud build thing. But it looks like they do support hooks, see https://forums.cocoon.io/t/how-can-i-compile-in-cocoon-with-plugins/4001/3

It seems that contrary to what they say, cocoon currently can't do hooks (see forum). So I tried your suggestion and hard-coding the values in plugin.xml and that works. It is not necessary to copy the json file over, at least on Android (haven't used cocoon for ios).


Can this library be added to ClickHouse docs?

👋
I wonder if it would make sense to add ReqCH to https://clickhouse.com/docs/en/interfaces/third-party/client-libraries#elixir? I don't know how many people visit those pages, but for those who do it might be useful to know all the options.

Please do!

https://github.com/ClickHouse/ClickHouse/pull/73590


Workflow error handling updates

Signed-off-by: Tihomir Surdilovic<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[x ] Specification
[ x] Schema
[ x] Examples
[ ] Usecases
[ ] Extensions
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] TCK
[ ] Other

What this PR does / why we need it:
This PR updates the workflow error handling for the specification:
allows for defining domain-specific errors
combines error and retry handling which was separate before
significantly reduces error handling complexity
removes error data filter
Special notes for reviewers:
Additional information (if needed):

Closes issue https://github.com/serverlessworkflow/specification/issues/125

@jorgenj made some big updates - please check again. i have separated the onErrors and retries definitions as per your request
I think this is pretty clean now.

@jorgenj i have one more idea...if separating onError/retries is too complex we could combine them in a following way:

allow users to define retry definitions w/o specifying a specific error attached to it
reference the retry definitions in onErrors for a specific error, that way the error itself is defined only in a single place

Thats just another idea if you guys think makes more sense

@jorgenj and I talked about this and have a good solution. So this pr is still work in progress :)

@jorgenj @ricardozanini @manuelstein
Did a final update - the functionality is done now. Please review. Thanks!

@jorgenj thanks for the review - very nice comments. updated.

Since we won't find a solution to separate different layers of errors (domain, protocol, runtime), we can merge this as intermediary solution despite its lack of portability.
LGTM

@manuelstein thanks for the review
Maybe there is a little bit of confusion here:  the error handling we have here is not runtime specific at all.
It is done with portability in mind and has many advantages over some of the "leading" workflow solutions on major cloud platforms right now which are indeed not portable :)
In our spec errors are:

defined with a domain-specific name (portable)
enhanced with a domain-specific code (portable)

The only requirement we put on the runtime implementations is to map those domain-specific values in workflow markup
to specific errors of their specific runtime impl. This makes the workflow lang 100% portable IMO.
Note that errors cannot just arise of execution of actions (service invocations). Errors can come from many different places during workflow execution, and they will be raised by the runtime implementations. As such if we went any other way (without the requirement for a mapping) we would end up with a non-portable solution.
I can explain this further and also with examples if needed in one of our meetings if you think it would help.
Would really like to see an example of why you think this is not portable - please bring it up and I'll definitely take a look and we can discuss to improve.

thanks for review everyone! I will go ahead and merge this now and we can make further improvements for next release version.


Merge ModuleTree and ModuleItemMap

Currently, building the tree of modules and  resolving use items are separate phases. This is because we don't handle macros yet :-)
WIth macros, a module can be defined by a macro invocation, which is imported by a use path. To handle this, we should merge two things into one.
Specifically, we should create a new struct and query, CrateSymbols, which contains a module tree, a mapping from module to declared/imported symbols and a mapping from macro invocations to the expansion results.
The LowerModule step should work on the raw syntax and should be oblivious of the particular module. Specifically, it shouldn't do macro expansion, while it does it today.
A possible further extension here is to split import into two categories: imports that can affect macro resolution, and other imports. Ideally, we should lazily resolve the second category.

cc @pnkfelix @michaelwoerister, this the main "name resolution/macro expansion" issue in rust-analyzer.
The code which handles this currently is
https://github.com/rust-analyzer/rust-analyzer/blob/12e3b4c70b5ef23b2fdfc197296d483680e125f9/crates/ra_hir/src/module_tree.rs
https://github.com/rust-analyzer/rust-analyzer/blob/12e3b4c70b5ef23b2fdfc197296d483680e125f9/crates/ra_hir/src/nameres.rs
https://github.com/rust-analyzer/rust-analyzer/pull/724 (in-progress PR which adds macro-expansion, outside of the resolution atm)

fixed


[language] Add function name and offset to Abort

When Aborting we are now reporting the "location" of the error
together with the error code.
So it's something along these lines:
major_status: ABORT
sub_status: ERROR_CODE
message: 0xADDR::module_name::function_name

Question (possibly for later): could/should we do this with all of the other errors (e.g., MISSING_DATA, ARITHMETIC_ERROR)? These are actually even less fun to debug. It seems like we could write a wrapper for execute_code that adds the module/procedure/offset information in all error cases.

Question (possibly for later): could/should we do this with all of the other errors (e.g., MISSING_DATA, ARITHMETIC_ERROR)? These are actually even less fun to debug. It seems like we could write a wrapper for execute_code that adds the module/procedure/offset information in all error cases.

yes we will and it's on our plan of things to do.
Point being (rewording what you are saying) every error should come with a location otherwise it gets crazy

@bors-libra r=sblackshear

:pushpin: Commit e692f3a has been approved by sblackshear

:hourglass: Testing commit e692f3a9c37e49456d4495331c2aeb4215f96887 with merge defc553b1cedff0bbcfe5926a039a1b61b6971a2...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing defc553b1cedff0bbcfe5926a039a1b61b6971a2 to master...


rename XHPHelpers to XHPHTMLHelpers, add more generic XHPHelpers class

Marking as v3 as it's a major break

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

no thanks FBBot.


Module Unknown

I have install freeRadius with Google Authenticator using the http://www.supertechguy.com/help/security/freeradius-google-auth on Ubuntu 16.04.
when I create a test user and then do a "radtest", I get the following.

_root@test:~/Desktop# radtest test2 test2028227 localhost 18120 testing123
Sending Access-Request of id 132 to <IP_ADDRESS> port 1812
        User-Name = "test2"
        User-Password = "test2028227"
        NAS-IP-Address = <IP_ADDRESS>
        NAS-Port = 18120
        Message-Authenticator = 0x00000000000000000000000000000000
rad_recv: Access-Reject packet from host <IP_ADDRESS> port 1812, id=132, length=20_

here is the debug:
rad_recv: Access-Request packet from host <IP_ADDRESS> port 58106, id=132, length=75
        User-Name = "test2"
        User-Password = "test2028227"
        NAS-IP-Address = <IP_ADDRESS>
        NAS-Port = 18120
        Message-Authenticator = 0xdfb6df01fe864775337b4fe8a0e3d345
Fri Sep 30 10:23:40 2016 : Info: # Executing section authorize from file /etc/freeradius/sites-enabled/default
Fri Sep 30 10:23:40 2016 : Info: +group authorize {
Fri Sep 30 10:23:40 2016 : Info: ++[preprocess] = ok
Fri Sep 30 10:23:40 2016 : Info: ++[chap] = noop
Fri Sep 30 10:23:40 2016 : Info: ++[mschap] = noop
Fri Sep 30 10:23:40 2016 : Info: ++[digest] = noop
Fri Sep 30 10:23:40 2016 : Info: [suffix] No '@' in User-Name = "test2", looking up realm NULL
Fri Sep 30 10:23:40 2016 : Info: [suffix] No such realm "NULL"
Fri Sep 30 10:23:40 2016 : Info: ++[suffix] = noop
Fri Sep 30 10:23:40 2016 : Info: [eap] No EAP-Message, not doing EAP
Fri Sep 30 10:23:40 2016 : Info: ++[eap] = noop
Fri Sep 30 10:23:40 2016 : Info: [files] users: Matched entry DEFAULT at line 74
Fri Sep 30 10:23:40 2016 : Info: ++[files] = ok
Fri Sep 30 10:23:40 2016 : Info: ++[expiration] = noop
Fri Sep 30 10:23:40 2016 : Info: ++[logintime] = noop
Fri Sep 30 10:23:40 2016 : Info: [pap] WARNING! No "known good" password found for the user.  Authentication may fail because of this.
Fri Sep 30 10:23:40 2016 : Info: ++[pap] = noop
Fri Sep 30 10:23:40 2016 : Info: +} # group authorize = ok
Fri Sep 30 10:23:40 2016 : Info: Found Auth-Type = PAM
Fri Sep 30 10:23:40 2016 : Info: # Executing group from file /etc/freeradius/sites-enabled/default
Fri Sep 30 10:23:40 2016 : Info: +group authenticate {
Fri Sep 30 10:23:40 2016 : Debug: pam_pass: using pamauth string <radiusd> for pam.conf lookup
Fri Sep 30 10:23:40 2016 : Debug: pam_pass: function pam_authenticate FAILED for <test2>. Reason: Module is unknown
Fri Sep 30 10:23:40 2016 : Info: ++[pam] = reject
Fri Sep 30 10:23:40 2016 : Info: +} # group authenticate = reject
Fri Sep 30 10:23:40 2016 : Info: Failed to authenticate the user.
Fri Sep 30 10:23:40 2016 : Info: Using Post-Auth-Type Reject
Fri Sep 30 10:23:40 2016 : Info: # Executing group from file /etc/freeradius/sites-enabled/default
Fri Sep 30 10:23:40 2016 : Info: +group REJECT {
Fri Sep 30 10:23:40 2016 : Info: [eap] Request didn't contain an EAP-Message, not inserting EAP-Failure
Fri Sep 30 10:23:40 2016 : Info: ++[eap] = noop
Fri Sep 30 10:23:40 2016 : Info: [attr_filter.access_reject]    expand: %{User-Name} -> test2
Fri Sep 30 10:23:40 2016 : Debug: attr_filter: Matched entry DEFAULT at line 11
Fri Sep 30 10:23:40 2016 : Info: ++[attr_filter.access_reject] = updated
Fri Sep 30 10:23:40 2016 : Info: +} # group REJECT = updated
Fri Sep 30 10:23:40 2016 : Info: Delaying reject of request 0 for 1 seconds
Fri Sep 30 10:23:40 2016 : Debug: Going to the next request
Fri Sep 30 10:23:40 2016 : Debug: Waking up in 0.9 seconds.
Fri Sep 30 10:23:41 2016 : Info: Sending delayed reject for request 0
Sending Access-Reject of id 132 to <IP_ADDRESS> port 58106
Fri Sep 30 10:23:41 2016 : Debug: Waking up in 4.9 seconds.
Fri Sep 30 10:23:46 2016 : Info: Cleaning up request 0 ID 132 with timestamp +3
Fri Sep 30 10:23:46 2016 : Info: Ready to process requests.

it shows "Reason: Module is unknown"

Could you try using the full path to pam_authenticator.so? And also strace radiusd to see if it's correctly opening the .so file?

/usr/local/lib/security/pam_google_authenticator.so
above is the location to the file.  where would I put this?

I meant did you try putting this full path in /etc/pam.d/radiusd instead of just the file name?

sorry.  I inserted the path into /etc/pam.d/radiusd   and it worked.
thanks

You're welcome.


handle eternl not having a walelt connected

When the user has their wallet disconnected, we need to somehow make them aware of this

probably add this as a warning which can be used for end-used UX

this is handled now, listening to no account set errors and prompting the user to connect their wallet.


jenkinx-node-test to 0.0.5

Promote jenkinx-node-test to version 0.0.5

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Apply for expungement. And prep for learning how to deal with employers who ask you about a record.  That is our hope that we will be able to address these items too.


Favorites page is broken

Currently, when running the project locally, I favorited the "Batman" wiki from the example seed data and get the following error when navigating to the '/favorites' endpoint.

Likely an aftereffect of a fix I made. Cheers for the PR and fixing the horrid "fix" I made.
I've merged the PR.