Allow return to be omitted from single expression functions.

Enables return to be omitted from function bodies which consist of only a single expression.

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test source compatibility

Forgot the summary at the top of "This looks pretty good; I'm glad it doesn't seem to take too many changes; good job listing out test cases."
Some other things to check:

code completion (as you mentioned)
what these look like when using SwiftSyntax

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 0a5e8f76d068f707ef1fe9e559efa6a5e7f0dd54

Build failed
Swift Test OS X Platform
Git Sha - 0a5e8f76d068f707ef1fe9e559efa6a5e7f0dd54

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a7daf25f74f42b49414e459bb5b45dc8630902dd

Build failed
Swift Test OS X Platform
Git Sha - a7daf25f74f42b49414e459bb5b45dc8630902dd

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f0ef9e39116b4692323f49a17141742f70a2c456

@swift-ci please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - f0ef9e39116b4692323f49a17141742f70a2c456

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a42c2c1a702432aa4c0add85b884b294c772ebc0

Build failed
Swift Test OS X Platform
Git Sha - eeac99d2baa0e3c8ca29761208c91fb28c806bc8

@swift-ci please test source compatibility

@swift-ci please test

@swift-ci please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - c2515e00101c18c6c3d9341ce16102d5b049b663

Build failed
Swift Test OS X Platform
Git Sha - c2515e00101c18c6c3d9341ce16102d5b049b663

Both compatibility tests have this result although their statuses are reported as failed:
========================================
UPasses:
  UPASS: https://bugs.swift.org/browse/SR-8234, Lark, 4.0, 7604f9, Swift Package
========================================
Action Summary:
     Passed: 261
     Failed: 0
    XFailed: 27
    UPassed: 1
      Total: 289
========================================
Repository Summary:
      Total: 79
========================================
Result: UPASS
========================================

@swift-ci please test source compatibility

@nate-chandler I'm un-XFAILing Lark here: https://github.com/apple/swift-source-compat-suite/pull/330

@swift-ci please test source compatibility

@swift-ci please build toolchain

Toolchains are available here:
macOS: https://ci.swift.org/job/swift-PR-toolchain-osx/266/artifact/branch-master/swift-PR-23251-266-osx.tar.gz
Linux: https://ci.swift.org/job/swift-PR-toolchain-Linux/207/artifact/branch-master/swift-PR-23251-207-ubuntu16.04.tar.gz

I'm a little concerned by the new changes to the constraint solver, since that could change the behavior of existing closures. @DougGregor or @xedin should review those; I don't think I'm qualified.

I'm a little concerned by the new changes to the constraint solver, since that could change the behavior of existing closures.

I'm hoping that the changes to the constraint solver only affect single expression functions because only in that context is the contextual type purpose CTP_ReturnSingleExpr, the only way to form a constraint of kind SingleExpressionFunctionReturnConversion is when that is the contextual type purpose, and only when that is the constraint kind does an implicit conversion from uninhabited occur.  I'm hoping that means that closures are unaffected.

I guess that's convincing. It's a little funny to me that we wouldn't use CTP_ReturnSingleExpr for closures too, or try to share more there, but we don't want to do it now. I'm just a little sad we had to change the constraint solver at all when your earlier implementation made it look like we wouldn't have to.

I'm just a little sad we had to change the constraint solver at all when your earlier implementation made it look like we wouldn't have to.

Yeah, I know what you mean.  That earlier implementation did, though, have to type check twice in some cases, and had quite a few problems with diagnostics because it was bypassing the codepaths where they were emitted between TypeChecker::typeCheckFunctionBodyUntil and ConstraintSystem::solve.

@nate-chandler Can you please explain what problem you are trying to solve with adding new  conversion and score? If I understand this correctly this might be related to expressions like these?
func foo() -> Int { fatalError() }

Because fatalError() is going to be wrapped in ReturnStmt?

@xedin Yes, that is the exact case.

@nate-chandler I feel like there might be a better solution for that case, I'll pull your changes and try to come up with a suggestion for you. I think we might be possible to do in matchTypes similarly how we have conversions from () -> Never to () -> Void and () -> T for closure result in cases like foo() -> Int { fatalError() }

@xedin Okay!  Looking forward to hearing how we can make this better.

@nate-chandler I've opened PR for you https://github.com/nate-chandler/swift/pull/2 which uses a special locator element instead of conversion and fixes up brace statement afterwards. This would allow you to remove conversion and other stuff from constraint system.

@xedin Thank you!  I merged your PR and will eliminate the conversion and other constraint system changes.

@nate-chandler No problem!

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 50d5db46128309edb70f7b71ef88cf4e7c2459d2

Build failed
Swift Test Linux Platform
Git Sha - 50d5db46128309edb70f7b71ef88cf4e7c2459d2

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - e30511bdb8d8b4f0adc1b75e0db66992f4e25a74

Build failed
Swift Test OS X Platform
Git Sha - e30511bdb8d8b4f0adc1b75e0db66992f4e25a74

@swift-ci Please clean smoke test OS X platform

@swift-ci please clean smoke test OS X platform

@swift-ci please clean test OS X platform

@nate-chandler this broke the Windows test suite!


Build Issue

When I try to duplicate the scene, I don't see any Clouds in that scene. Only the scene where it was originally duplicated, that scene has that shader...but not the duplicated one

Meet same problem here. Once I had rename the original Scene, the Clouds missed..

Originally posted by @elliot-winch in https://github.com/SebLague/Clouds/issues/5#issuecomment-1271824415
This is the solution to putting clouds into a new scene


Game changes to saving world upon loading

(https://github.com/DexxKnight1/Age-of-Fate-1.16.5/files/8009272/crash-2022-02-06_13.00.15-client.txt)
I was in twilight forest running around while it was raining, i'm using age of fate 1.4.6 (tried it using 1.4.3 as well, I've got 12gb of memory allocated to it (out of 32)

Twilightforest currently have issues with Manesium mode. It's a rendering issue between twilight dark oak and magnesium.
In the newest update of Age of Fate I've temporarily disabled the portal to Twilight Forest dimension.


ColladaExporter produces 6 nodes for each node in the original .dae

Environment

OS Version: Ubuntu 20.04
Source build

Description

Expected behavior:
Generated output dae file with 1 node for each node in the input dae file.
Actual behavior:
Generated output with repeated nodes.

Steps to reproduce

Working on top of #763 (mainly to have available the test file and submeshes fix).
On top of the environment files, I'm running:
ign gazebo -v 3 -s -r --iterations 1 src/ign-gazebo/test/worlds/collada_world_exporter_submesh.sdf
to get a exported .dae with the contents of the original tunnel_tile_6. I would expect the final result to have as many nodes as the original .dae file. However, the final result in this scenario has 6 nodes for each original node. They repeat in regular steps, that is, in the final result file:
node_0, node_5, node_10, node_15, node_20, node_25 are equivalent.
node_1, node_6, node_11, node_16, node_21, node_26 are equivalent.
And so forth.
Adding a video to show the problem:
https://user-images.githubusercontent.com/8069967/115597383-98b66980-a2af-11eb-8561-2505dbddb539.mp4

The main cause of this issue is related to the fact that models in fuel like this one: Tunnel Tile 5 have in their model.sdf the meshes loaded once for a main visual and later the mesh is loaded several times, once per each sub-mesh. Attaching the model.sdf file of that model for reference (in.txt format, github reasons).
model.txt
#802 Addresses the submeshes being exported as the complete mesh of the file, now the only part exported is the submesh marked with the sdf tag .
With this fix, each node would be exported twice: once because it's included as a submesh and one because it's included as a complete visual. IMO this should be addressed by changing the models to include the visuals only once (not sure if there are other reasons to import it this way).
I think the ObjLoader or the ColladaLoader shouldn't be importing the whole mesh file if a submesh is selected, although this can be considered a separated issue.

I just realized the MeshManager is able to load meshes only once per file here, so I don't think there's an important issue loading the whole mesh.


Rename models.get_realm_by_string_id to get_realm.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

@rishig Can you add a little bit of explanation in the commit message after the first line that explains the history behind this migration?

@showell done!

Merged, thanks @rishig!!


Update how-to-contribute.md

[x] Have you followed the contributing guidelines?
[ ] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

i think the word with wrong using

Edgexie

How to contribute.md

Thanks so much for your contribution!  You rock, @edgexie!


feat: support default implement method

that should fix #17

Thanks for your PR. Unfortunately I think it is too simplistic to land. In order to capture references to Self we will need where Self: Sync bounds (at least in the case of a Send trait.. in the general case, I think the type checker may not be up to the task, so we will have to keep it limited to Send for now). We also need to make sure arguments are moved into the async block, as is done in #20.


How to prevent touchmove after onStart?

const onPreventDefault = (event) => {
  event.preventDefault();
};

const handleDisableScroll = () => {
  window.document.body.addEventListener('touchmove', onPreventDefault, {
    passive: false
  });
};

const handleEnableScroll = () => {
  window.document.body.removeEventListener('touchmove', onPreventDefault, {
    passive: false
  });
};

// ...

<Draggable
  onDrag={(event) => {
    this.handlePan(event.targetTouches[0].clientX, event.targetTouches[0].clientY);
  }}
  onStart={handleDisableScroll}
  onStop={handleEnableScroll}
>

The intention is to disable any page scrolling on mobile devices while panning is active.
It works on Android, but does not work on iOS.
It looks like it is too late to create touchmove event listener in the onStart.

This approach works.
handlePreventTouchmoveWhenPanning = (event: *) => {
  if (this.state.panning) {
    event.preventDefault();
  }
};

componentDidMount () {
  window.document.body.addEventListener('touchmove', this.handlePreventTouchmoveWhenPanning, {
    passive: false
  });
}

componentWillUnmount () {
  window.document.body.removeEventListener('touchmove', this.handlePreventTouchmoveWhenPanning, {
    passive: false
  });
}

Excellent solution. Regards to my context, I want to pan/zoom an svg within a container but prevent page scrolling on mobile. Capturing of the touchmove event didnt seem to work is its done AFTER touch start. I think this is a nice approach. Thanks gajus


move complete transtion in reqmgr2 thread

still need to test.  and also need to be other state transition in reqmgr2 but I will do in separate patch.
When cmsweb is upgrade all the agent has to be patched as well

test this please

Hi Alan, in basic test, it seems working OK. (I still need to fix(or remove) one unittest). If we keep the running-closed definition as in the patch, we have to allow running-open to force-complete transition since we can 't enforce the condition all the jobs are in wmbs before force-complete.


Create controller fixes #3

Added a file createController.py that handles file create operations.
In torn.py , the argument structure for creating a controller is proposed as :

torn create controller ControllerName

This will create a controller in the controllers directory of the project.

@ashwini0529 see to the comment I posted on createController.py

@shubhodeep9, please I've added some commits. Please look into it.

The concept is still incomplete, right now all it is doing is creating a file, which easily can be established using just a touch command in bash.
I'd recommend going through Sails.js create controller concept.


Regression output with LSTM input layer

Hi,
I was wondering if there is an example for an lstm layer that eventually feeds into a regression output layer. I am having a hard time putting one together.
I am hoping to feed in one sample at a time, where sample looks like this:
input: [[x,x,x,x],[x,x,x,x],[[x,x,x,x],] output: [y]
This way, I would expect an lstm layer that takes in 4 inputs and after 3 iterations produces an output h to feed into a regression layer.
Cheers

I have an example similar to yours but the raw input is actually more like:
[0,0,0,45,98,43,23]
The integers are indices which are fed into an embedding layer, and 0 is a masking index. If that is helpful, let me know and I'll post some code.

I don't necessarily need an embedding layer. I would just to have an lstm take in a sequence of vectors as input.
If you feel it's still related I would appreciate you sharing the code.

In that case it is probably not sufficiently related, sorry.

input: [[x,x,x,x],[x,x,x,x],[[x,x,x,x],] output: [y]
How is this not the canonical use case of LSTM in Keras? What problem are you having?

I got it running. I had an odd issue with theano complaining about too many parameters. I thought it might be related to my code, it looks like it wasn't.
I will leave my implementation here in case others are looking for the same thing.
def gen_data() :
X, Y = [], []
for x in xrange(1000) :
X.append(np.random.random_sample(5,))
Y.append(np.random.random_sample())
return np.asarray(X), np.asarray(Y)
def temp_data() :
X, Y = [], []
for x in xrange(1000) :
sample = []
for x in xrange(4) :
sample.append(np.random.random_sample(5,))
X.append(sample)
Y.append(np.random.random_sample())
return np.asarray(X), np.asarray(Y)
if name == 'main':
X,Y =  temp_data()
model = Sequential()
model.add(LSTM(5, 10, activation='sigmoid', inner_activation='hard_sigmoid'))
model.add(Dropout(0.5))
model.add(Dense(10,1, init='uniform', activation='linear'))
sgd = SGD(lr=0.1, decay=1e-6, momentum=0.9, nesterov=True)
model.compile(loss='mean_squared_error', optimizer=sgd)
model.fit(X,Y, nb_epoch=20, batch_size=10)
print model.evaluate(X,Y, batch_size=10)


operator [CI] self-node-remediation (0.6.0)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/retest

/test 4.13-deploy-operator-on-openshift

@mvala , @J0zi  please let me know if there are any issues preventing the merge.

/merge possible

/merge possible


AP Test Week 3 Review Ticket

Score 2/2 (Graded by Brian Zhang)
Github Page Link - Notes
AP Test + Corrections
AP Test 1 (45/50) - Corrections
AP Test 2 (46/50) - Corrections
AP Test 3 (45/50) - Corrections
THIS WEEK CORRECTIONS:
AP Test 4 (24/25) - Corrections (2/2)

Score 2/2 Grader: Brian Zhang
Github Page Link - Notes
##AP Test 4 (24/25) - Corrections


Refactor tests and remove external API dependency

Upgrade go to 1.19
Remove calls for external APIs
Refactor Series to generic format

Codecov Report
Patch coverage: 19.40% and project coverage change: -1.04 :warning:

Comparison is base (a386008) 48.80% compared to head (292642c) 47.76%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   48.80%   47.76%   -1.04%
==========================================
  Files          19       19
  Lines        2502     2546      +44
==========================================
- Hits         1221     1216       -5
- Misses       1209     1258      +49
  Partials       72       72

Impacted Files
Coverage Δ

model/model.go
59.59% <0.00%> (-10.65%)
:arrow_down:

exchange/pairs.go
17.85% <15.38%> (-62.15%)
:arrow_down:

plot/chart.go
39.74% <22.22%> (-1.18%)
:arrow_down:

model/series.go
83.33% <62.50%> (-7.58%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[FlakyTest] ServiceControlCliArgumentsSuite

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the subtask
https://lists.apache.org/thread/g0ydjyo9893f0dvvmgg3sgkkfcr2xzm6
Run starting. Expected test count is: 24
ServiceControlCliArgumentsSuite:
- test basic kyuubi service arguments parser *** FAILED ***
  "[zhangduo-ubuntu]" did not equal "[localhost]"
(ServiceControlCliArgumentsSuite.scala:99)
  Analysis:
  "[zhangduo-ubuntu]" -> "[localhost]"
- prints usage on empty input
- prints error with unrecognized options
- test invalid arguments
- test extra unused arguments
- test list action arguments
- test get/delete action arguments
- test with unknown host
- test with invalid port specification
- test create action arguments
- test use default property value if missing
- test use short options *** FAILED ***
  "[zhangduo-ubuntu]" did not equal "[localhost]"
(ServiceControlCliArgumentsSuite.scala:333)
  Analysis:
  "[zhangduo-ubuntu]" -> "[localhost]"
- test --help

Parent issue
#1733
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

It seems related to how we get the machine name. My machine name is zhangduo-ubuntu, so in general, 'zhangduo-ubuntu' points to the same machine with 'localhost'.

Look like the expected result in the test is hardcoded with localhost, while the actual one is getting from canonicalized hostname.

--host will now keep the original value in this PR(https://github.com/apache/incubator-kyuubi/issues/2461), so this problem should not occur.


Can't install live share

[2019-06-19 23:32:51.128 Client I] Extension, IDE, OS : VSLS/1.0.419 VSCode/1.35.1 Windows/10.0.18362
[2019-06-19 23:32:51.130 Client I] Passed version check for Windows: found 10.0.18362
[2019-06-19 23:32:51.387 Client.Rpc V] RPCClient.init retryCount:0 currentRetryInterval:0
[2019-06-19 23:32:51.388 Debug.Rpc.Host V] TrackDebugManager created
[2019-06-19 23:32:51.392 Client.Rpc V] Agent connection not completed: Error: connect ENOENT \.\pipe\vscode.781221073276169ab7f6d310425d4cc1; Retrying...
[2019-06-19 23:32:51.393 Client.Rpc V] RPCClient.init retryCount:1 currentRetryInterval:100
[2019-06-19 23:32:51.394 Client.Agent V] Agent lock on:c:\Users\fahri.vscode\extensions\ms-vsliveshare.vsliveshare-1.0.419\dotnet_modules\vsls-agent.exe.lock
[2019-06-19 23:32:51.396 Client.Agent I] starting agent with pipe:vscode.781221073276169ab7f6d310425d4cc1
[2019-06-19 23:32:51.396 Client.Agent I] presence service -> uri:https://signlr-prod.core.vsengsaas.visualstudio.com/api/signalr/presencehub vslsTeam:false insiders:true vscode:1.35.1
[2019-06-19 23:32:51.397 Client.Agent E] Agent failed with error: Error: spawn cmd.exe ENOENT
[2019-06-19 23:32:51.407 Client I] Moved package files.
[2019-06-19 23:32:51.438 Client.Agent I] Agent terminated with exit code: -4058 and signal null:
[2019-06-19 23:32:51.439 Client.Agent V] Agent unlocked
[2019-06-19 23:32:52.455 Client I] Deactivating extension from background agent startup.
[2019-06-19 23:32:52.457 Client I] No workspaceId found in workspace settings.
[2019-06-19 23:32:52.458 Client I] Client deactivation requested.
[2019-06-19 23:32:52.460 Client I] No workspace url found in cascade.json file.
[2019-06-19 23:32:52.514 Contact.Manager I] registerContactProvider-> serviceId:git
[2019-06-19 23:32:52.514 Contact.Service V] _Initialize:git
[2019-06-19 23:32:52.514 Contact.Service V] Request 'initialize' serviceId:git
[2019-06-19 23:32:52.515 Contact.Manager I] registerContactProvider-> serviceId:selfInvite
[2019-06-19 23:32:52.515 Contact.Service V] _Initialize:selfInvite
[2019-06-19 23:32:52.515 Contact.Service V] Request 'initialize' serviceId:selfInvite
[2019-06-19 23:32:52.515 Client I] Failed to get context services:Error: spawn cmd.exe ENOENT

Duplicate of #2270


Support Material You monochrome app icon

Fixes https://github.com/nt4f04uNd/sweyer/issues/112

I think since this is an API 31+ feature, we should use a vector image:
ic_launcher_monochrome.zip
But what do you think about keeping the shadow?
ic_launcher_monochrome.zip

Without shadow
With shadow

Incredible, thank you! 🔥
Sure, with the shadow it's better.
I tried making it with a shadow, but failed because I used the raw SVG asset.
I now see that you already made such an asset for the splash screen in the past.

Do you want me to merge the pull requests where you assign me as a reviewer?

Also, I will assign you to all my PRs, if you don't mind.
I enabled master branch protection rule that prevents merging without at least 1 approval.

Yes, perfect. 👍 It's always better to have a second pair of eyes read the code before merging in my opinion.


Add ISLE reference documentation.

Markdown rendered
This documentation provides details for all of the ISLE language
features, and detailed rationale for why many of them are designed in
the way that they are. It is hopefully both a reasonable tutorial and
reference for someone looking to understand the DSL.
Note that this documentation is separate from and orthogonal to the
work to document the Cranelift bindings and integration work that
@fitzgen has covered well in #3556. This document can link to that one
and vice-versa once they are both in-tree.
In addition to @fitzgen I'm picking a few folks for reviewers who would
likely be consumers of this doc; please do let me know if there are holes
or not-clear parts anywhere!

Thanks all for the feedback! Updated based on comments.


jobs: Rearrange job.css

Sorry for these wall of changes! As #1944 asked, it's very hard to review.

Sort blocks and classes order by several parts: Bars, Boxes, Side Icons, Stacks, Procs, and Colors
Add a lot of comment to show why this width and when you can reuse these class
Merge some similar class
Change some resource box width and right side icon position to better match bars
Change some proc box position to better match bars
Remove Box 1 defination in Procs, for default has defined that(suggestion needed)

Sorry again for forgot to split to minor changes!

I think this all looks good to me.  Thanks for doing this!  I'm sorry this was such a mess.
If you're interested in more cleanup, I had a bunch of thoughts if any of this sounds interesting or like good ideas to you.  I think these are all ideas for separate cleanups for future patches.  I'd love to hear other thoughts too!

I feel like there's a lot of repeated job1-bar, job2-bar, job3-bar {.  I wonder a little if things like pld-bar is a bad idea.  It might be better to just have .pld .bar and try to make as many things use .bar as possible without having to add a new line for every job.  Especially things like .war-boxes .text is sad to repeat for every job.  It'd be nice if we could have one .boxes .text rule and if warrior needs something special we could have a .war.boxes or .war .boxes rule.

I think there's room to use calc a lot more rather than hardcoding sizes and positions.  Things like the size of the hp bar, etc, or positioning buffs next to the resource bar (which could also be done in other ways too like flexbox or relative positioning) rather than per-job offsets for the number of resources.  I think ideally jobs.js could just add as many resource boxes as it needed and CSS would just handle it moving buffs without needing to hard code anything per job.

It's sad to me that all of the proc boxes have to be absolutely positioned.  I think there could be flexbox or grid there.  I think my hope is that you could have  with some margins or gaps to place them exactly where they are now, and we could get rid of all of the proc box positioning by name.

I agree with these thoughts too. I also feel sad that I need to add a lot of similar class when adding a new UI.
But I'm not good at CSS, not sure I can do these all.

For the first point, I think I can handle it by add some classes to these elements.
For the second point, I heard that a CSS class can not get other classes' attributes as variable to calculate itself.
(like .right-side-icon { left: #hp-bar.width + .boxes > div.width }) I have no idea for this.
For the last point, I think flexbox is a good idea, but I'm not sure how flexbox work. We have 3 type of procs now: less than 3 box, 3 box and 4 box. if using flexbox, UI less than 3 box(mostly 1) may go to too center. I'm not sure how to deal with.

If changes in this PR has nothing wrong, I'll open new branches to do above base on this PR. Let me know if something amiss.

I gave this a brief bit of testing across all the jobs, and everything looked in the right place with the right colors.  Thanks!


thank you for sharing the code ! how can i train librispeech dataset on this mpdel

Hi,
to train on any dataset, you just need to make train and validation csv file.
the content of the csv files should be
'full/path/to/audio.wav','transcription of audio'
and then specify these csv files in train.py args along with the sample rate of your audios. :)


CFR - Fees Processing Payment

Title of ticket: CFR - Fees Processing Payment
Description
Designing Screen and Process of IAO to be able to process a Processing Fees Charge to an Applicant
Dependencies
Are there any dependencies?
DOD
Items to remember in designs

[x] Ability for user to be able to only pay 1/2 if fee is over $200
[x] Ability for applicant to be able ti input fee payment themselves and click through process
[x] Receipts/Invoice design should be the same as Previous Implement of BC Pay in Application Fees Process

@m-prodan @lmullane Here is a link to where the online payment for applicants for processing fees. I haven't included the fee waive, but removed the button based off the conversation we had Friday. I am off today, but will work on the waive route based off the documents that were shared Friday regarding what qualified for a waived fee.
I'll work on the waive fee Tuesday while flying back to Ontario along with any changes to the link below.
https://jacklyn808742.invisionapp.com/console/share/RSBDPXJGKAW/921685067

Hi @JHarrietha-AOT - sorry haven't gotten to this as much as I wanted to. I like what I'm seeing so far - I think one thing that is missing, is that the invoice and receipt should include a breakdown of the charge. Or was that intended to be a part of the email sent to the applicant? If so, that is fine then as is (their receipts as they exist now only show total amounts paid, not a breakdown). I'd probably make some changes to some of the wording, but we can go over that more when you are back as I'm not sure where I can flag those stylistic changes

@JHarrietha-AOT, could we also include a design for the email that the applicant receives notifying them of payment with a link to the first page you created?
@m-prodan, do we have to offer them the choice of paying with cheque?
I'd prefer the button says pay online. Note, through PayBC an applicant can pay with a VISA or MC Debit which debits the amount directly from their bank account. The 5 big Canadian banks provide these kind of debit cards.


Add tool for visualization

Overview
Add tool for visualization of log output
Details
Implement a tool for visualization of log output.
Conditions for close
When the visualization tool is implemented.
Supplement
NA
Note

Write a conclusion when closing the issue.

The basic visualization method with Python scripts were added in #153.
We can add similar Python scripts when we need (e.g., when we write documents).
This issue can be closed.


ReferenceFrame not properly set through config.txt

Whether ReferenceFrame is set to 0 or 1 in the config.txt file, CyRSoXS  runs the default setting (0). This only affects command line usage. ReferenceFrame gets set properly through the pybind interface.

Some changes have been pushed to the branch refFrameDebug in response to issue. The reference frame can be changed through config file with input specified as:
ReferenceFrameLab = True. This corresponds to rotating the electric field. This is changed to the default behavior
ReferenceFrameLab = False. This corresponds to rotating the director vector. This seems to be wrong in the sense that it voilates the negative anisotropy at high q (based on the discussion with Dean, Pete and Eliott).
Additionally, while debugging it seems that Algorithm 1 was doing wrong rotation. I tried to verified it. @pdudenas , it will be great if you can run your beta tests with both algorithms (I hope the code is fast enough to verify it quickly) once again to verify that everything is intact before merging the branch refFrameDebug into main.
A minor bug in numbering of the author is also fixed.

Is there a reason to change the input name?
If we're following semantic versioning, a change in a core parameter name is a breaking change that requires bumping the major version.  It seems like we could just as easily keep it as the 0/1 variable ReferenceFrame and not have to bump to version 2.x family.

OK. I can make the changes and push it.

@martintb pointed out earlier today, when we were talking, that one can also implement a parameter change as a "shadow change"; i.e, keep the old parameter name, have it change the same thing under the hood as the new one, and warn that it's deprecated.  So it's really up to you.  As long as it accepts the old parameter name in addition to the new and the old one still functions, it's not a breaking change, my mistake.

I have renamed the config to ReferenceFrame, in order to be consistent with Pybind too. Just to be be sure that we all are in same page
ReferenceFrame =1. This corresponds to rotating the electric field. This is changed to the default behavior
ReferenceFrame = 0. This corresponds to rotating the director vector. This seems to be wrong in the sense that it voilates the negative anisotropy at high q (based on the discussion with Dean, Pete and Eliott).

Verified that ReferenceFrame=1 (LAB) is now the default reference frame, and reference frame can be set through the config.txt now. Results are identical with CommunicationMinimizing (0) and MemoryMinimizing (1) Algorithms.


My bot is not running

I run runbot.bat and I get this meesage in my Command Prompt
No module named 'musicbot.bot'
Attempting to install dependencies...
Requirement already up-to-date: discord.py[voice]~=0.12.0 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from -r requirements.txt (line 1))
Requirement already up-to-date: youtube_dl in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from -r requirements.txt (line 2))
Requirement already up-to-date: pip in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from -r requirements.txt (line 3))
Requirement already up-to-date: cffi==1.6.0 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from -r requirements.txt (line 4))
Requirement already up-to-date: aiohttp<1.1.0,>=1.0.0 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: websockets<4.0,>=3.1 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: PyNaCl==1.0.1 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: pycparser in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from cffi==1.6.0->-r requirements.txt (line 4))
Requirement already up-to-date: chardet in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: multidict>=2.0 in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: async_timeout in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Requirement already up-to-date: six in c:\users\jayden\appdata\local\programs\python\python35\lib\site-packages (from PyNaCl==1.0.1->discord.py[voice]~=0.12.0->-r requirements.txt (line 1))
Ok lets hope it worked
C:\Users\Jayden\Desktop\MusicBot-master>

If the bot is a fresh download/clone it shouldn't be throwing that error.

I recently re-downloaded the file since this happened to my old bot. It was fine for a few days but this happened again. :/

Follow the installation guides on https://github.com/Just-Some-Bots/MusicBot/wiki. This error won't happen if you follow the instructions. Downloading the zip is not sufficient.

Thanks Jayden, I tried what you recommended and it worked!


Remove 7-zip as no cookbooks depend on it

This is simply removing a deprecated and unused cookbook. It's been replaced by seven_zip everywhere.
Verification:
grep 7-zip lib/provisioner/worker/plugins/automators/chef_solo_automator/resources/cookbooks/*/metadata.*

👍 lgtm


Rename response=>source, request=>sink

Rename all these occurrences in these repositories:

Cycle Core
Cycle DOM
Cycle HTTP

On their respective auto-scope branches.

Done in auto-scope branch

Cool I'll take on Dom :+1:


Automatic deploy does not work for Ubuntu 18.04 LTS

When using the Deploy to Azure and selecting Ubuntu OS Version 18.04 LTS in the form, the deployment ends successfully, but the resulting virtual machine does not have all the applications configured - there is no bitcoin and litecoin daemon, no nginx. It looks like clean Ubuntu.

Try opening the browser, you'll see it works.
It is using docker-compose. (run docker ps to see your containers)

I cannot see any process listening on HTTP/HTTPS ports and docker is not installed on the virtual machine. I am comparing deploy with Ubuntu 16.04 and 18.04 - they are different. 16.04 works, has bitcoin and litecoin daemon, nginx etc. 18.04 looks clean.

I will check that now

Perfect, thank you. I am available for some debugging/logs etc. Just let me know.

You can come on http://slack.forkbitpay.ninja it is better for real time debug :p

Should be fixed by https://github.com/btcpayserver/btcpayserver-azure/commit/6f2211c8f433b398343ee5ecc73897a6374702f8 let me know.

Closing this as you reported it worked on slack :)


vsetvl x0, x0, * instruction limits

From vector spec https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#avl-encoding
we know that "vsetvli x0,x0,*" allows the vtype register to be changed while maintaining the current vl, provided VLMAX is not reduced.
From compiler view, we need a instruction to set VLMAX without wasting any register.
I mean whether we should remove the reserved limits ? it should allow VLMAX to shrink.

The vl value could be reduced by this instruction if the new SEW/LMUL ratio causes VLMAX to shrink, and so this case has been reserved as it is not clear this is a generally useful operation, and implementations can otherwise assume vl is not changed by this instruction to optimize their microarchitecture.

Some pattern of GCC like "mov" SPN can not guarantee this constraint in some context, so we need to call "vsetvli rd,x0,*" explicitly, it will waste a unused register :(

Have you got quantitative evidence that eliminating the wasted register has a material code size or performance impact in practice?  (In any case, this would be a new instruction as part of a future extension, not part of 1.0.)
Note also, we defined whole-register move instructions that aren't affected by vtype/vl especially for this kind of situation.  It's possible that you don't need any vsetvli instruction.


Autoselect Name field at opening of the Add New Column dialog window

Would it be possible to auto select the Name field at opening of the Add New Column dialog window so it would be possible to write directly the name of the field instead of manually select the whole field or delete manually the the default text "Column1"?

Hello @donicom,
It seems like an excellent minor enhancement to have.
Thank you.

Fixed for new attribute and constraint creation dialogs.

verified


Create 0451-sort-characters-by-frequency.cpp

File(s) Modified: 0451-sort-characters-by-frequency.cpp
Language(s) Used: cpp
Submission URL:  https://leetcode.com/problems/sort-characters-by-frequency/submissions/1169930092?envType=daily-question&envId=2024-02-07

@meiyu0714 Thank you for your contribution 👍


Ref Tracking Fixes

Mostly wondering why this wont work :P

I realize that the global ref tracking adds quite a bit of clutter to the code. An alternative could be that we "officially" declare a set of always reached global refs and always return these. We might still want to keep globalRef in JSGen so we can assert it being in the set and mark the locations in the code.


BUG: get_dummies not returning SparseDataFrame

Fixes #10531 .

@jreback Perhaps this would be more elegantly fixed by having concat drop empty passed-in DataFrames?

xref #10536

I think #10536 should be fixed first. But this introduces the problem of when/how to convert a concat of series (that happen to be all SparseSeries) into a SparseDataFrame (as opposed to a DataFrame).

@jreback Not sure why #10536 needs to be fixed first --- it does not affect this issue (we are concating SparseDataFrames here)

merged via https://github.com/pydata/pandas/commit/d06537478486887042ef89141707f6b05695995e
thanks!


unidecode vs text_unidecode import resolution order

The way the code is now unidecode library is just getting ignored.
text_unidecode is install_requires and is always present in the python environment, so  it makes sense to try importing the optional dependency unidecode first and only then fallback to text_unidecode.

Excellent.  Thank you.

Version 8.0.0 is pushed.  Thx

Thank you so much!


fix draft up with set values in environment

closes #223

@bacongobbler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #224 into master will increase coverage by 0.45%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage      33%   33.45%   +0.45%
==========================================
  Files          18       18
  Lines        1109     1112       +3
==========================================
+ Hits          366      372       +6
+ Misses        694      687       -7
- Partials       49       53       +4

Impacted Files
Coverage Δ

cmd/draft/up.go
5.21% <33.33%> (+5.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82eda3d...70dda12. Read the comment docs.


Visual Studio Code crash when internal terminal application do character overflow

Visual Studio Code crash when you open any application that do a character overflow at the internal terminal

VSCode Version: 1.26.1 Commit: 493869ee8e8a846b0855873886fc79d480d342de x64
OS Version: Arch Linux 4.18.5-arch1-1-ARCH x86_64

Steps to Reproduce:
Open any software that do a character overflow such as a infinite loop, a example:
#include <stdio.h>
int main() {
    while(1)
        printf("B");
    return 0;
}

Does this issue occur when all extensions are disabled?: Yes

@h0m3 can you repro this using yes? Also can you try on the Insiders build https://code.visualstudio.com/insiders


Update for compatibility with High Quality Camera

I just pre-ordered the Raspberry Pi High Quality Camera and plan on rigging it up with a nicer C or CS mount lens, to make a slightly more stable (but probably a bit more heavy) timelapse rig I can pop onto a tripod mount and put anywhere.
I also have a C to F-mount adapter, so it might be interesting to see how well my 300mm Nikon lens performs with the ~5.7x crop factor, making it a whopping 1710mm f/5.6 lens!

Well... haven't had to change any of the defaults; the script works out of the box with the HQ camera so far (yay for consistent APIs!).
I'm going to do a couple timelapse series to see how things work.

Hi. I'm able to get your script to work with the HQ camera, but not at full image resolution of 4056 x 3040 pixels.


Remove unused scripts

With the installation of semantic-release these scripts are unused :)

Thanks @jorisre

Thanks @jorisre


Feature request: optionally deactivate oneshot layers on key up of trigger key

I just learned about a nice feature which makes oneshots usable for emacs users, who regularly hold down a modifier key while pressing multiple other keys: Instead of deactivating the layer on key press of the resolving key, keep it active until that key is released. This way, assuming control = oneshot(control), one could enter C-x C-s by the sequence <leftcontrol_down> <leftcontrol_up> <x_down> <s_down>, followed by <x_up> and <s_up> in arbitrary order. The point here is that the control layer is kept active until <x_up> is seen.
Because of the key rolls produced by many fast typists, this is probably only useful for non-shift modifiers, so instead of (or in addition to) a global oneshot mode toggle option, a dedicated oneshot action would be needed.
There is some potential overlap with #280 though, because depending on the planned action you describe there, one could probably achieve almost the same effect by activating the layer until idle for some small amount of time, where idle here not only means that no further input is received, but also that all keys have been released.

[control]

x = overload(control, C-x)

Already with your solution, as one typically would like to support this behaviour for all letter keys, this would result in 26^2 + 26 = 702 lines in the configuration file,

The user isn't expected to this for all keys, only a handful of them. This only really makes sense in the context of emacs convoluted stock bindings. In general, the user is unlikely to simultaneously hold down more than one key which needs to be modified.

However, instead of trying to mix oneshot with hold behaviour, it might in fact be better to solve this problem using a pure oneshot approach like so:
[...]

Before proposing more actions to solve novel problems, it would be better to ensure that the problems they are intended to address actually exist.

I was proposing that only the first non-modifier key has to be held down. So for example after triggering a oneshot(control) (say by tapping a home row key or a combo), the control layer would be kept active as long as the next letter key is held.

That was also my understanding. My point is that this does not seem like generally useful behaviour because most of the time the user does not enter sequences like
<control down> <control up> <a down> <b down> <a up> <b up>
for arbitrary a and b, since sequential modifier activations are relatively rare. Even when they do occur (the goal actually is to type C-x C-s in something like emacs), they are usually not close
enough to produce the ambiguous event seqeunce above. For the small number of sequences which actually do meet this criteria, I don't think it is unreasonable to require the user to explicitly define them within a layer.

In my case, I'm an intensive user of orgmode, where relevant sequences occur regularly. I also regularly use the C-c C-k block for keyboard macros. If I could start over again, I would probably simply remap those bindings, but after decades of use they are so deeply ingrained in my memory that the effort would simply be too high.

I see.

I agree that one could go down your proposed route, and also that implementing a fully universal solution is technically not needed here, but as a consequence one would have to make a list of all used keybindings and then later, whenever a new keysequence is encountered, edit the configuration file again.

This is true, but I would regard this as a sufficiently niche use case that first class support is probably unwarranted.

I wouldn't call this user friendly.

But still possible with a bit of elbow grease.
If you really want this to apply to all keys, it can be achieved with the layer2 action (in the pipeline) which accepts a macro:
capslock = oneshot(capslock)

[capslock:C]

a = layer2(capslock, C-a)
b = layer2(capslock, C-b)

which has the advantage of not requiring a dedicated layer for each key.

In contrast to this, the additional actions (which besides are trivial to implement)

The implementation is not the issue. Each new action adds additional complexity and should be justified by more than a single use case.

I don't see why the current use case does not serve as justification.

Because you are the first person to ask about such a feature and it can already be achieved with the existing set of primitives.

If end user convenience doesn't count, one could also remove oneshot for the sake of minimalism

Oneshot is used ubiquitously and there is no other (non trivial) way to achieve the same effect using other actions. The two are not analogous.

Apparently our views of the issue differ, which is fine.

Indeed. Ultimately it is a matter of taste.


adds full inference via modal.com

it's working :)

Create an API key on https://modal.com/
Hosting:

modal run hello.py
✓ Initialized.
✓ Created objects.
├── 🔨 Created hello.
└── 🔨 Mounted ./hello.py.
Running remotely on Modal!
✓ App completed.


Requesting async support

It would be desirable to use SM using async methods, e.g. migrator.MigrateToAsync(long), as the current synchronous style is rather limiting in this day and age.

Not going to happen, I'm afraid, for the following reasons:

Raw ADO.NET doesn't have async support. There's no IDbCommand.ExecuteNonQueryAsync() or IDbTransaction.CommitAsync(). I don't have a starting point.
No migration framework that I know of makes you write Task UpAsync() and Task DownAsync() on your migrations.
 Therefore if you call MigrateToAsync, you're freeing that thread to go and... do nothing - there's likely little other useful work it could be doing.

As a counterpoint to this, my app does plenty of other things, such as reporting status, accepting connections and communicating with hosting infrastructure. Being able to perform asynchronous work greatly simplifies the mixing of all the different duties of my app.
I can understand the limitation if it is due to the data access layer in .NET not supporting async (not saying that is the case, though) but there does not seem to be any grounds in principle to avoid async.

Being able to perform asynchronous work greatly simplifies the mixing of all the different duties of my app.

From that perspective, I don't see the difference between migrator.MigrateToLatestAsync() and Task.Run(migrator.MigrateToLatest).

I can understand the limitation if it is due to the data access layer in .NET not supporting async

I have moved to using DbConnection rather than IDbConnection as my connection base, so native async support is now available.

but there does not seem to be any grounds in principle to avoid async.

The trouble is, it's not simply a matter of adding async support in addition to the current sync support. At the end of all of my code is the migration that the user wrote. So either I have to make migrations synchronous, or asynchronous. Either the user has to write a void Up() method, or an async Task UpAsync() method. There's no sensible way of having both.
Therefore either SimpleMigrations is fully synchronous, or fully asynchronous.
If it becomes fully asynchronous, then:

Users have to always write asynchronous migrations.
It's different to every other migration framework out there, all of which are synchronous (as far as I know)
I break every existing user of SimpleMigrations


Hollow Knight yaml

Hollow Knight async filler yaml

You'll want to remove the last 3 lines, or else it won't function correctly.

done, thanks

You need to add Hollow Knight to the meta.yaml file, too.


[release-1.20] Change pod repair getPodNetNs logic to not rely on /32 route in host ns.

This is an automated cherry-pick of #51223

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.20
481096c07ed8b35037b499f39845c9675dfa01ff
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


MSL: Conflict between early_fragment_tests and depth() attribute

SPIR-V conversion to MSL fails compilation due to conflict between early_fragment_tests and depth() attribute:
program_source:12:37: error: depth attribute cannot be used in a fragment shader with early_fragment_tests
[[ early_fragment_tests ]] fragment main0_out main0()
                                    ^
program_source:9:26: note: field with illegal attribute depth declared here
    float gl_FragDepth [[depth(less)]];

These CTS test fail as a result:
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_less
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_greater
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_less_or_equal
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_greater_or_equal
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_equal
dEQP-VK.spirv_assembly.instruction.graphics.early_fragment.depth_not_equal

SPIR-V file:
bad_depth_attr_on_early_frag_test.spv.zip

This is now fixed in PR #1810.

Wasn't the whole point of depth(greater) or depth(less) supposed to be so you could write depth from the fragment shader even with early_fragment_tests? This seems like a glaring omission on Apple's part.

There is a difference between implicit (implementation optimization) and explicit (user demanded) early fragment tests.
The depth(X) qualifiers are optimization hints to the implementation to help it decide whether to move the tests ahead without being explicitly told to do so.
When early fragment tests are explicitly demanded by the shader code, they always happen, and both GLSL and Metal then specify that the output depth value is unusable. GLSL does it by ignoring the value; Metal by insisting it can't be part of the shader.


Make sure we display correctly !avatar images

One can include avatars via syntax:
<EMAIL_ADDRESS>
Currently, rendering this does not work as expected.

Just adding a note to this issue that #10360 was the corresponding server-side change needed to support this.


Box doesn't work with react 15.0.0

Please test with react 15.0.0, it seems that flexbox (Box) does not work. When I switch back to react 0.14.8 Everything is aligned as expected but when I switch to react 15.0.0 nothing aligns or wraps etc...

...for some reason it looks like "display: flex" is removed (or overridden) from the container div when I switch to 15.0.0

+1

thank you jaskinn, I works for me too without the prefixAll. I also do not need prefixAll because I use Radium for vendor prefixing.
thanks again,

@dlivas So did it actually work with React 14? This lib is yet not tested with 15 as I am busy right now, but I can't see why this should be an issue with React actually. Ill try to test it out soon

Version 2.2.0 (of react-layout-components) has been working for me with React 0.14.8 (and still is). I am also baffled as to what changes in 15 could be causing this.

Yes, it works with react 14 as always did.
with react 15.0.0 works after I commented out the vendor prefixing. It looks that the problem is in inline-style-prefix-all module when we use 15.x.

Same here.  Works w/ React 14, but not React 15 for some reason.

I've just tested the results and styles. This seems to be a bug within React itself as the styles get prefixed as should: e.g. display gets:
display: "-webkit-box;display:-moz-box;display:-ms-flexbox;display:-webkit-flex;display:flex" but the whole property gets somehow removed after mounting to the DOM.
@dlivas Also note that Radiums uses the same prefixer under the hood (at least one of both available prefixer I created). Perhaps this issue might return with Radium as well.

@rofrischmann - Yes- it even appears your inline-style-prefixer library is referenced in this ticket: https://github.com/facebook/react/issues/6467 (also seems to affect your inline-style-prefix-all library).

I'm guessing a nasty work around would be including a style tag in the  onComponentDidMount (if it hasn't already been injected).
<style id="__SOME_ID_NO_ONE_ELSE_WOULD_USE__">
	.___INLINE_STYLES_HACK_DISPLAY_FLEX___ {
		display: -webkit-box;
		display:-moz-box;
		display:-ms-flexbox;
		display:-webkit-flex;
		display:flex
	}
	/* you could add other prefixed styles here (that rely on the inline hack) */
</style>

Then in your lib you could use class instead of inline styles for the inline styles that require the hack you were using.
This might be against the philosophy of your lib though (using classes and injecting a style tag).  I'm hoping there's some other way to fix this.

Alright. As I see, React 15 actually "killed" inline styles as they're used up to 0.14 as without alternative values, inline styles are not usable within older browsers that do not support newest specs. I will have to think about something to fix this. Might use a single class to polyfill the display. All other props should still do their job as there're no values that need to be prefixed alternatively.
Thanks for your effort here!

gearon also has an interesting solution in the 2nd comment on that thread:

For example you can create a DOM element once when your code initializes, set different values of style.display on it, and see whether it sticks or gets reset. When it sticks, it means the browser supports the given value. This way you can build up a dictionary of mappings between standard values and the ones supported by the browser. Most likely there are some libraries that can do this for you.

...and thanks for your work on this great lib.  I looked at a few other flex layout libs, and found this one to fit my needs the best.

Oh yeah I know this method actually, but don't think it is a "good" solution. It is not performant to mount all the DOM elements to only get supported properties. I hope I'll find some time this week to "fix" the issues.
Thanks a lot :) Let's make this lib working again as fast as possible.

Anyone had a chance to look at this?  I'd like to try upgrading to React 15 for my project, but this would appear to block that.

I'm blocked by this as well.  Really appreciate the hard work on these components, though we may have to switch away if they prevent us from upgrading React :(   Let me know if there's anything we can do to help investigate or fix this issue!

I completely agree with SteveEisner's comments.

I am right now trying out some stuff, sorry for the late response, but I have been in stress with exams lately. I am just unsure how to add the single CSS class without a mess of extra code, but I guess the best solution right now is to just add a new stylesheet on componentDidMount once.

Thanks!  And I really did mean it - if there's anything we can do to help test, please let us know.  We don't want to switch, we just need to know that our upgrade path is clear :)  Good luck on your exams.

Again I want to apologize for the delay, I am ill and yet have to go for 2 more exams this week.
I might push something tomorrow or on thursday.

Appreciate the update, and please take care of yourself first :)

Come on, man !
I really need React 0.15 .

I just fix this in my local repo b/c I'm still in development mode.
(1) In your root project folder, create fix_flex.sh:
#!/bin/bash
LINE_NO="107"
CHANGE_FILE="./node_modules/react-layout-components/lib/components/Box.js"
CHANGE_LINE=$(sed "${LINE_NO}q;d" "${CHANGE_FILE}")
EXISTING_LINE="      var prefixedStyles = (0, _inlineStylePrefixAll2.default)(styles);"
FIXED_LINE="      var prefixedStyles = styles;"
if [ "${CHANGE_LINE}" == "${EXISTING_LINE}" ]; then
  sed -i.bak "s/${EXISTING_LINE}/${FIXED_LINE}/" "${CHANGE_FILE}"
fi

(2) Now run: chmod +x ./fix_flex.sh
(3) Now run ./fix_flex.sh
All that does is change line 107 of Box.js to stop using the autoprefixer (which I don't need for development)

@skratchdot Nice hack for development, but yet this does not fix the issue itself as you can't use it if you develop for all major browser (which sometimes need those prefixes).
I will push the update in ~2 hours, but there might be a change soon as React itself might add support for multiple values https://github.com/facebook/react/pull/6701

Ah, that's great!  Thanks for the update.  I just figured I'd share that snippet, b/c it allowed me to start my React 15 upgrade, while waiting for the next update of this lib.  The code I'm working on won't be released for a while, so my browser support requirements are small at the moment.  It'll be cool if FB supports multiple values again.
To the others reading: don't make the change to line 107 if you are running in production (or need good browser support).  I'm only using it locally because I don't need to support old browsers at the moment!


fixing issue with activity to transaction link

Github Issue (if applicable): #538
Explanation of Bugfix/Feature/Enhancement:
YNAB getting rid of views and moving to components. Removing that dependency from our code.
Recommended Release Notes
Fixed an issue with the activity to transaction link feature.

Thank you!

Thank you! Looking forward to this fix!


Use htmx for old table batch actions

Fixes #ISSUEID

[ ] Use htmx for batch lead update

Test Steps

[ ] …

Closing this in favor of https://github.com/HyphaApp/hypha/pull/4226


When returning from sound edit view: scrollable soundoard does not show active soundboard

Severeal soundboards in playing view, first soundboard is scrolled out to the left
User selects a sound in a soundboard for editing
User returns from edit view
App shows first soundboard in the scrollable tab list

Expection:

scrollable tab list shows the active soundboard

(Seems to be fixed.)


graphene-hardened-malloc: 2 -> 6

Motivation for this change
Update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The graphene-hardened-malloc project is now up to release 8: https://github.com/GrapheneOS/hardened_malloc/releases/tag/8


Allow configuring major grid lines

I would love to be able to set the major grid lines to another number besides 5 depending on the diagram.

install the Set Grid script.

Which script is that?

Sorry. I mixed up the Excalidraw issue log with the Excalidraw Obsidian
issue log. In Obsidian you can add scripts to Excalidraw, and Set Grid does
what you are after. But those are not available on Excalidraw.com
On Fri, Apr 19, 2024, 19:20 Phips Peter @.***> wrote:

Which script is that?
—
Reply to this email directly, view it on GitHub
https://github.com/excalidraw/excalidraw/issues/7910#issuecomment-2066986868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADNRO6XCGRD2X74JPL5F3F3Y6FG7FAVCNFSM6AAAAABGNHNEHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHE4DMOBWHA
.
You are receiving this because you commented.Message ID:
@.***>

Closing in favor of #2110


Regex Search for Multiline Comments Not Working as Expected and \s Issue

Does this issue occur when all extensions are disabled?: Yes

Version: 1.96.0
Commit: 138f619c86f1199955d53b4166bef66ef252935c
Date: 2024-12-11T02:29:09.626Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Linux x64 6.8.0-50-generic

Steps to Reproduce:

Ctrl+F and search for /\*[\s\S]*?\*/ or /\*[\s\S]*?\*/\n or /\*[\s\S\n]*?\*/ with regex option checked in the text below

foo
/* bar */
bar
/* foo
 * bar
 */

/\*[\s\S]*?\*/ will only search single line /* bar */, which i think is wrong. It should also search for the multiline one. The other two regex expressions will have same result. But doesn't '\s' inherently contain newlines?

by default VSCode runs find in single line mode
if there is a \n present, then it runs in multiline mode


[BUG] update_predict_single does not refit model

Describe the bug

update_predict_single no longer refits the model in v0.10.1
To Reproduce

forecast_horizon=24
cov=0.95
preds, conf_ints = model.update_predict_single(
    y=y_new, X=None,
    fh=np.arange(1, forecast_horizon+1),
    update_params=True,
    return_pred_int=True, alpha=1-cov
)

Expected behavior

The model should be refitted when setting update_params to True. It seems like the property class _y attribute gets updated with the new observations, but the model is not refitted, and predictions returned are just longer forecasts of the originally trained model.
Additional context

Versions

System:
python: 3.8.11 (default, Jan 25 2022, 23:19:55)  [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
executable: /Users/tsangis/Projects/uk-ds-day-ahead-prices-forecast/venv/bin/python
machine: macOS-12.0.1-x86_64-i386-64bit
Python dependencies:
pip: 22.0.3
setuptools: 58.0.4
sklearn: 1.0.2
sktime: 0.10.1
statsmodels: 0.13.1
numpy: 1.21.1
scipy: 1.7.3
pandas: 1.4.1
matplotlib: 3.5.1
joblib: 1.1.0
numba: 0.55.1
pmdarima: 1.8.4
tsfresh: None

update_predict_single no longer refits the model in v0.10.1

Thanks for reporting, @atsangarides!
I briefly looked into the base class, and it does seem that update_predict_single calls update by default, which calls the inner _update. The latter has as default "refitting on the entire data seen so far".
So from a framework perspective, it seems that refitting/updating is hardcoded and also done as a default (if all works as intended).
What could be the case, is that individual models override this incorrectly and don't update despite the interface looking like it would.
So, could you kindly paste some reproducible code, and let us know whether you think it's a particular model, or whether it's a general problem? If you think it's a general problem, can you explain why you think it is?

Hmmmm - on first glance, there is a lot of composition here, and in a pipeline the "update" is called sequentially. So it would in theory suffice if it is broken in one of the estimators only, or in the compositors (e.g., the pipeline) for it to break overall.
@aiwalter, do you have any obvious idea? Given that it´s using a number of estimators I think you might be familiar with?

also, quick question, @atsangarides, how do you know it does not refit?

thanks for looking into this @fkiraly !
I use prefect for scheduling daily updates. I did a backfill using bumped sktime 0.10.1 and these are the results (see below).
I manually tested the code above to investigate, predict_update_single is way too fast. ._y does get appended with new observations, but there is no refit.

Ouch - I hope this didn't incur any trading losses 😅
(I just compulsively had to look up the "IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE" part of our BSD license 😁)
I think I found the error - the _update of the TransformedTargetForecaster calls update of the transformers, but not transform! It should be calling, in sequence of the pipeline, trafo1.update, trafo1.transform, trafo2.update, trafo2.transform, and passing results of transform on to the next update and transform. But instead, it updates everything on the untransformed data.

yes, I think it's coming from TransformedTargetForecaster and not from the framework. @aiwalter, would much appreciate your (author's) eyes on this, too!

Btw, I think it's also broken in the ForecastingPipeline. Just to confirm whether it's not me getting confused here: the update of trafoN needs to be called on the output of transform of trafo[N-1], and not on the input, does that sound correct?

attempted fix here: https://github.com/alan-turing-institute/sktime/pull/2296

It's just weird that the behaviour of the transformer (/steps) changed over the bump and I couldn't find it.

Are you saying, it changed in one of the versions?
You're right - if the _update wouldn't be there in the pipelines, it would just revert to default behaviour and just continue updating by fitting to the entire data (without calling any implemented update functionality of the steps).

It would not explain why the updating runs in no time, but it would explain why the output is garbage.

I'm noticing, my sentence above give an explanation to the "no time" aspect - calling update is usually much faster than a complete refit, so it fits the explanation.

So, here's a question: tests are not catching this currently, because, even though update returns garbage, it returns garbage in the expected data format, which the test think is fine.  Any good ideas about the testing problem here?

Oh. Will hold off from changing my pipeline flows then! Was changing to separate fit/predict steps!
Don't know if my suggestion is of any value re tests.. Internally we tend to test transformations.. i.e. using some static/hardcoded data do we get the transformed values we expect. A dead simple series of transformations you can apply and test input<>output data?

It's just weird that the behaviour of the transformer (/steps) changed over the bump and I couldn't find it.

Are you saying, it changed in one of the recent versions?
You're right about how that would behave, assuming _update was added sometime recently. If the _update wouldn't be there in the pipelines, it would just revert to default behaviour specified in the base class framework (BaseForecaster), and just continue updating by fitting to the entire data (without calling any implemented update functionality of the steps).
That's computationally more wasteful than calling update, but ... at least it's correct ...
Anyway, I guess we're lucky that we found this 1 day before the new release. If this is indeed the fix, it should be included in the new, much improved 😄 0.11.0 version.

It was working as expected on 0.9.0

A dead simple series of transformations you can apply and test input<>output data?

Yes, we do that in parts of the code base already, most prominently in time series classification.
FYI @MatthewMiddlehurst (we had been discussing this recently).
Perhaps we should also do this in forecasting.
Although it would primarily detect whether the logic of the pipeline has changed, not whether it produces garbage, so it's not quite the same? Perhaps sth tied to performance monitoring?

I changed the title of this issue to reflect the root cause bug.
Sadly, this was already reported by @mloning in #1381 and it was completely ignored by all other core devs...
I guess there is a lesson there.

I wonder if this is related to this one: https://github.com/alan-turing-institute/sktime/issues/2203

@atsangarides, we've just released 0.11.0, which should contain the fix for your problem.
Based on our discussion, I've also started working on a wrapper that allows you to control how often you refit (instead of update):
https://github.com/alan-turing-institute/sktime/pull/2305
Note that, currently, transformers have an empty update by default and update only if a given transformer implements update.

@fkiraly Thank you so much! will give it a shot now! You responsiveness is amazing.
We need to start contributing to sktime... We have some methods wrapping the evaluate method for backtesting (what update_predict with a CV was supposed to be doing) with pred intervals, plotly visuaisations for easier inspection of longer time series, etc, that I think would benefit other people

Just checked with 0.11.0. Observations:

Lost the ability to return prediction intervals using the TransformedTargetForecaster. Same as #2317
My filter acts on a window, so updating (update_predict_single(y=y_new_only)) with say last day's observations (24, which is shorter than the window=168) raises the error below (this goes away if I use `update_predict_single(y=y_old_with_new)

ValueError: The window_length and the forecasting horizon are incompatible with the length of y. Found window_length=168, max(fh)=1, but len(y)=24. It is required that the window length plus maximum forecast horizon is smaller than the length of the time series y itself.


NO-TICKET: Don't evict validators if era was too short to produce a unit.

In practice, with reasonably long eras, this won't make any difference, but in some tests with single-block eras we observed that everyone got evicted because they did not have a chance to create a unit before the last (and only) block.
This PR makes Highway only report a validator as inactive if there was enough time before the first and last block of an era for them to create a unit.

(This is an alternative to #911.)

bors r+

bors r+

bors r+

(I'm getting the test failure locally, too, but only after several attempts. Trying the same test on master now…)

bors r+


Change animation speed?

Is there a way to change the animation speed, like speed it up? Thanks

No, sorry.


quic-fuzzer crash

This file: crash-8a9b91d8c01d945afb73140a53845f3c96b59d06.gz
Returns:
quic-client: ssl/quic/quic_ackm.c:1304: int ossl_ackm_on_timeout(OSSL_ACKM *): Assertion `lost_pkts != NULL' failed.
==3842704== ERROR: libFuzzer: deadly signal
    #0 0x5558541bda74 in __sanitizer_print_stack_trace (quic-client+0x2b2a74) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #1 0x5558541f2a19 in fuzzer::PrintStackTrace() (quic-client+0x2e7a19) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #2 0x5558541d757d in fuzzer::Fuzzer::CrashCallback() (quic-client+0x2cc57d) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #3 0x7f5e5102550f  (/lib/x86_64-linux-gnu/libc.so.6+0x3c50f) (BuildId: 8a1bf172e710f8ca0c1576912c057b45f90d90d8)
    #4 0x7f5e510730fb in __pthread_kill_implementation nptl/pthread_kill.c:43:17
    #5 0x7f5e51025471 in raise signal/../sysdeps/posix/raise.c:26:13
    #6 0x7f5e5100f4b1 in abort stdlib/abort.c:79:7
    #7 0x7f5e5100f3d4 in __assert_fail_base assert/assert.c:92:3
    #8 0x7f5e5101e3a1 in __assert_fail assert/assert.c:101:3
    #9 0x5558542d1a1c in ossl_ackm_on_timeout ssl/quic/quic_ackm.c:1304:9
    #10 0x5558542ab97e in ch_tick ssl/quic/quic_channel.c:1947:13
    #11 0x55585423c41f in ossl_quic_reactor_tick ssl/quic/quic_reactor.c:109:5
    #12 0x5558542386c7 in quic_read ssl/quic/quic_impl.c:2701:9
    #13 0x55585420aa0a in SSL_read ssl/ssl_lib.c:2342:11
    #14 0x5558541bf774 in FuzzerTestOneInput fuzz/quic-client.c:123:23
    #15 0x5558541d8dbc in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (quic-client+0x2cddbc) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #16 0x5558541d8299 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (quic-client+0x2cd299) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #17 0x5558541d9896 in fuzzer::Fuzzer::MutateAndTestOne() (quic-client+0x2ce896) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #18 0x5558541da1c5 in fuzzer::Fuzzer::Loop(std::vector<fuzzer::SizedFile, std::allocator<fuzzer::SizedFile>>&) (quic-client+0x2cf1c5) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #19 0x5558541c5b6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (quic-client+0x2bab6a) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #20 0x5558541bfb41 in main (quic-client+0x2b4b41) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)
    #21 0x7f5e510106c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #22 0x7f5e51010784 in __libc_start_main csu/../csu/libc-start.c:360:3
    #23 0x555854195200 in _start (quic-client+0x28a200) (BuildId: 881a33dde8a7787c0541a3cf95a7b4da8e331a27)

That at least looks similar to https://github.com/openssl/openssl/pull/22368#issuecomment-1763494447 that we had problems reproducing.

Ah - I wondered when that would appear again!

My proposed fix in #22541. The ack manager loss detection timer was firing because a packet was not acked within the time period that we calculated it should be acked within when it was first sent. However when the timer fires the rtt info has changed since when we sent the packet and it is no longer considered lost yet. We seem to be assuming that if the loss detection timer fires then there must be lost packets.


Replace Simple JSON with Gson

Simple-JSON was throwing NoClassDefError at runtime when attempting to parse
the RCov JSON file - this looks to be because maven wasn't bundling it as a
dependancy for whatever reason. Replacing with Gson seems to have fixed the
issue.
references issue #8

Great job with this PR!  I pulled down the code and it builds great.  We should have time tomorrow to test it out and then we'll accept it :smile:

Any ETA on merging this into master?  The current baseline is still experiencing the problem and this fix took care of it nicely (its working great for us).


Update ToS for telemetry

Apply latest terms of service as provided by John

@frangio do we know what's the status on this one?

Done in https://github.com/OpenZeppelin/openzeppelin.com/pull/66/commits/7cd939be0e15b74144082ee045a23dc71e6568f1.


Error: RequestError: The body, json and form options are mutually exclusive

Error: RequestError: The body, json and form options are mutually exclusive
Error: The body, json and form options are mutually exclusive

see the detail https://github.com/iamtraction/google-translate-api/issues/21


Show number of total labels and untranslated labels in table footer per language

Implemented in 2.8.1


Remove merge command for parallel runs

the generated merged report file done by
Report Generator is not recognized by sonar
instead the list of intermediate files will
be provided to sonar by setting the proper path
in coverageReportPath
for single run there should be no impact

Change-Id: I760026db26520c1324f7430f521239ed4b49b4c3

@kandoeniko I am thinking how much of a breaking change this actually is. Shouldn't we mention this in the CHANGELOG?

We could mention that it was added, but it should not be a breaking change for those who use it with single run option.


Xfce updates 2023-05-01

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg test xfce
@ofborg build xfce.thunar xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin

@ofborg build xfce.xfce4-netload-plugin


MultiClusterTopicManagementService implementation and various improvements

New feature:

Implemented MultiClusterTopicManagementService to make sure that monitor topics across clusters have the same number of partitions
Implemented MultiClusterMonitor to monitor a pipeline of Kafka clusters

Improve logging and simplify operation:

KafkaMonitor will log error message every 5 seconds if any service or app is not running
MultiClusterTopicManagementService will increase replication factor of the monitor topic if it is smaller than the configured replication
ConsumeService will wait for 1 sec before running to reduce the chance that it creates topic before TopicManagementService

Simplify config:

Removed the config topic-management.partitionsToBrokersThreshold

Code cleanup and reafactor:

Fixed typo in kafka-monitor.properties to use partitionsToBrokersRatio instead of partitionsToBrokerRatio
Improved log to avoid String concatenation
Removed duplicated code in EndToEndTest and marked it as deprecated
Renamed MirrorPipelineMonitor to MultiClusterMonitor
Refactored TopicManagementService to replace TopicState class with private static methods

Once the CI checks are complete you can squash and merge this.  Thanks for completing this refactor.


rustup to rustc 1.15.0-dev (ace092f56 2016-12-13)

Due to always_encode_mir we can now run tests that require auxiliary builds.

Oh, it seems like these changes aren't in an actual nightly release yet, just in master?

It looks like the latest nightly is 9 days old: https://static.rust-lang.org/dist/channel-rust-nightly-date.txt

I will revert this to keep master building for anyone new who comes along, but I'm also keeping these changes alive in a new branch: https://github.com/solson/miri/tree/always_encode_mir


Support LZ4 compression codec for raw index  (#6804)

This ticket is extension of adding new compression codec LZ4 after ZSTD(#6876) for Issue (#6804).
When the forward index is not dictionary encoded, we have 2 choices:
store the data as is (RAW)
store the data snappy compressed - using snappy compression codec library as default
This PR adds supports for LZ4 compression using library - https://github.com/lz4/lz4-java.
Maven Artifact: https://mvnrepository.com/artifact/org.lz4/lz4-java
LZ4 library offers 2 choices

Fast Compression
High Compression
We get good compression and decompression speed comparable to Snappy using Fast Compression. High Compression has poor performance when compared to already added support for ZSTD. The Benchmark for both choices offered by library are part of this PR, and the perf document is updated with numbers.
So based on the user requirements, user can configure via table config on a per column basis. The default behavior continues to remain the same. It is snappy for dimension columns and no compression for metric columns.

Other table level changes (column renaming, type changing, column dropping, index dropping) which are currently not allowed, changing the compression codec on an existing noDictionary column from snappy to lz4 or vice-versa will not happen since we currently don't have a mechanism for doing this in-place in the segment file. Newly pushed segments will pick up the new codec and since the codec type is written into the index buffer header, we will be able to read both old and new segments.
The library also underneath uses JNI bridge to original LZ4 library https://github.com/lz4/lz4 as Apache commons compress library similar to Snappy, ZSTD. Also,lz4-java library has been used in popular projects like Apache Spark, Apache Kafka and many more. This library also ensures that if native support is not available, it uses pure java implementation.
Please have a look at LZ4Factory class in lz4-java library for more information.
Compatibility docs from library
Compressors and decompressors are interchangeable: it is perfectly correct to compress with the JNI bindings and to decompress with a Java port, or the other way around.
The perf comparison document and benchmarking for Snappy, ZSTD, LZ4 are updated in doc
https://docs.google.com/document/d/1JKLhDm0-gnrRhyBUDge5u4MeGjotRSgjiexJxI_abfk/edit?usp=sharing
cc @siddharthteotia

Codecov Report

Merging #7035 (2d9c143) into master (a1c9b63) will decrease coverage by 7.95%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7035      +/-   ##
============================================
- Coverage     73.38%   65.43%   -7.96%
  Complexity       12       12
============================================
  Files          1453     1455       +2
  Lines         72032    72046      +14
  Branches      10427    10427
============================================
- Hits          52863    47141    -5722
- Misses        15643    21505    +5862
+ Partials       3526     3400     -126

Flag
Coverage Δ

integration
?

unittests
65.43% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...t/local/io/compression/ChunkCompressorFactory.java
57.14% <100.00%> (+7.14%)
:arrow_up:

...ot/segment/local/io/compression/LZ4Compressor.java
100.00% <100.00%> (ø)

.../segment/local/io/compression/LZ4Decompressor.java
100.00% <100.00%> (ø)

.../segment/spi/compression/ChunkCompressionType.java
100.00% <100.00%> (ø)

...org/apache/pinot/spi/config/table/FieldConfig.java
96.66% <100.00%> (ø)

...a/org/apache/pinot/minion/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/minion/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pache/pinot/common/utils/grpc/GrpcQueryClient.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 348 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91f426...2d9c143. Read the comment docs.


When double-click breadcrumbs entry, loacate the file in explorer

By default, Set "explorer.autoReveal" to false, and if double-click on an entry in the breadcrumbs section, it will expand the file tree in Explorer and locate the file, when in workspace mode.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


DAT Showing No Matches Found for Microsoft Devices

I can pull the device catalog for both Dell and Lenovo, but not for Microsoft. I get the message:
No matches found. Please try another OS/Build.
The log says:

No Microsoft models Found. If you are using a proxy server please specify the proxy in the Proxy Server Settings tab	DriverAutomationTool	6/27/2024 8:36:17 AM	154644 (0x25C14)

We don't use a proxy server.  Any work around for this?

It seems like Microsoft drivers only exist in the DAT for specific Operating System versions (i.e. Windows 10 1803, etc.).  I'm wondering if the JSON file that the DAT downloads is outdated.

The release notes, do give a clue as to what might be happening here.  It says something about Microsoft Surface links to come later.


It is not clear how to configure

I downloaded the component in ha 2024.9.3 and after a reboot I see a new "Daily sensor" device in HACS, but no new integration is visible in Settings->Integrations.
So how to configure this component?
config_entry-hacs-bb754784f5d610372c323b0b45536b7b.json

clear your browser cache and try to find the integration again.


Preview merge

The QtPreview and QtGlPreview classes are virtually identical, so this pair of commits tidies up some minor differences and then merges the two together. There should be no functional difference, just slightly less code to maintain.

@davidplowman Looks good, just a small question would it be better to put the 'imports' that are in one of the functions, at the start of the file instead?

Yes, good point, this is all quite ugly. The problem we have is that Qt is really fussy, and if you ever call Qt functions from more than one thread then it complains, and sometimes it even dies horribly. Unfortunately, even importing Qt stuff seems to qualify, so this too has to happen in the thread that is going to be running the Qt event loop.
The root cause is that Qt really expects to be the main thread, and so in this sense we are using it incorrectly. But I'm not aware of any better solutions...

Gotcha, thanks for explaining that, will merge now


Feat/plugin install

depends on #74
Relevant Issues
Closes #54
Closes #62
Closes #63
Overview
Installation system for plugins. Portions of this may be used in the future for other addons, so nearly everything up to when the import is done should be in an addons.py utility file.
The currently supported type of repos are in zip format, using the following structure:
{{user}}/{{repo}}/Plugins/{{directory}}/{{files}}.py

This gives the advantage to be able to extend the addons api in the future without having to worry about the structure of the repo.
A sample repository is viewable here: onerandomusername/modmal-addons, with a clone to gitlab/onerandomusername/modmal-addons
Details
Provided a github or gitlab repo, parses it to get the specific plugin information, if it exists, from the plugin.toml file.
The plugin.toml file is supplemental to the folders, meaning that the nature of the toml file existing does not override the existing plugins.
Rather than provide a list of all of the features here, I recommend checking out the documentation for this pull request, found here: https://discord-modmail.readthedocs.io/en/feat-plugin-install/addons/

This seems to be ready for review now.

This pr is now feature frozen.
The bot not using the cached downloaded files will be resolved in a seperate pr.

This still depends on solving the docker problem, however the rest of the code can be review.

Linting workflows are going to fail until this is merged with main again due to how github merges then and a dependency mismatch. Given that there's so many merge commits already, I'm holding off on a merge until later.

Coverage decreased (-42.03%) to 32.967% when pulling bc1a8350e246c08867ec8c7fd9011ea956082db9 on feat/plugin-install into 10a64686539acbbf2a1548334c52e0e218f1cdb4 on main.


improvement: Indexer agent validates EVM configs on startup

Ensure the EVM RPC endpoint, chain id, and ethereum network are consistent.
For example we want to fail early if the indexer-agent is configured with --ethereum-network rinkeby --ethereum https://eth-goerli-node.io

Resolved. Closing


Adding more unit test coverage

Description
Adding few more unit tests to improve code coverage for SDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #295 (d061e77) into main (ec38456) will increase coverage by 0.85%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #295      +/-   ##
============================================
+ Coverage     71.66%   72.52%   +0.85%
- Complexity      121      123       +2
============================================
  Files            27       27
  Lines           533      535       +2
  Branches         15       15
============================================
+ Hits            382      388       +6
+ Misses          143      139       -4
  Partials          8        8

Impacted Files
Coverage Δ

...rc/main/java/org/opensearch/sdk/BaseExtension.java
95.00% <100.00%> (+17.22%)
:arrow_up:

.../java/org/opensearch/sdk/ExtensionRestHandler.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Improve shiny App

Description of feature
Add nicer plots in the shiny app.

Define and document software requirements.

refer to https://nf-co.re/differentialabundance/1.4.0


Lambda Support

Hello,
What do you guys think of uploading the server to Lambda?
How should we approach this, bundle all the src together
or we can strip out some parts.
Thank You!

We would like to offer a guide at least, yes, on how people could run this on Lambda. Would you like to take the first swing at that?

It's not for production but it works #78

closing as it has been resolved here


How to swap out internal API with external API

I’m using a different language to host our API. I ripped out mongo and the models and such but I’m not sure how to go about this. Should I fetch the account after initializing the stores as the method to do so is stored in there?
I’m also confused about what and the difference between a state and store are.
To be clear, this is a question. Not an issue.

@dav-is

Should I fetch the account after initializing the stores as the method to do so is stored in there?

Initialize the state with the defaults (example)
Fetch your account/session data
Update the state before injecting into your HTML.

I’m also confused about what and the difference between a state and store are.

State contains the state of your application (ex: list of your todos, UI state etc).
Stores contain the methods that mutate that state (ex: adding a todo, fetching data).
Technically our State object is also a store, but we make the differentiation so that our logic is easier to follow by using the same principes as redux (one big state object).


Slow response when using S3

My response time increases from 60ms to 1500ms when using RESULT_STORAGE = 'thumbor_aws.result_storage' compared to no result storage. Any idea why or how to debug this?
I am coming from thumbor==6 with python2.7 and wanted to upgrade to version thumbor v7, also switching from tc_aws to thumbor-aws. Everything works fine except for this really high response time.
Installation
FROM python:3.10-slim
...
thumbor==7.0.8
thumbor-aws==0.4.0

thumbor.conf
RESULT_STORAGE = 'thumbor_aws.result_storage'
RESULT_STORAGE_EXPIRATION_SECONDS = 0
RESULT_STORAGE_STORES_UNSAFE = True

### AWS Storage ###
AWS_RESULT_STORAGE_REGION_NAME='eu-central-1'
AWS_RESULT_STORAGE_BUCKET_NAME='thumbor-adsadaaasd'
AWS_RESULT_STORAGE_ROOT_PATH='rs'
AWS_DEFAULT_LOCATION='https://thumbor-adsadaaasd.s3.eu-central-1.amazonaws.com'

I am using /.aws/config to assume aws role for authorization.
Edit: I think it is due to the fact that the boto aws session is not being reused. It looks a new session (via AWS assumeRole) is created for every single request.

Hi @oliverschewe, we can probably reuse the existing client like it's suggested here: https://github.com/aio-libs/aiobotocore/issues/928
Right now I don't have a way to test it, do you think you can create a PR?

@oliverschewe I've changed the client creation to reuse the same instance, can you test it?

Hi @oliverschewe, thanks for testing it.
It seems that the initial request sets the expiration to now.
https://github.com/aio-libs/aiobotocore/blob/4694ba4761c0a6cc9a31c620f4c9eb9eff653bf1/aiobotocore/credentials.py#L693
But then, the other ones should have a longer expiration time.
How often do you see the token refresh on your logs?

I don't see any refresh. It's like there never was a session a before, when I stress test my thumbor app with 10 sequential requests it simple takes 10x 1-2 seconds.
I created a simple app with aiobotocore to test if this has something to with its assume-role-with-web-identity functionality, but it looks ok. The session is only created once and reused in every subsequently use.
All credentials are read by botocore's provider pipeline (env, assume-role, assume-role-with-web-identity, sso, ...), so no need to pass any access_keys or secrets.
S3 is called every 60 seconds, only the first calls AssumeRoleWithWebIdentity. Strangely, shown expiration time from response is current time - but works nevertheless. (Sorry for the poor python, coming from Java)
import asyncio
import time
import logging
from aiobotocore.session import AioSession, get_session

AWS_SERVICE='s3'
AWS_REGION='eu-central-1'

BUCKET='my-thumbor-bucket'
BUCKET_KEY='rs/auto_webp/unsafe/400x301/filters:quality(80)/example.com/image.jpeg'

async def test_s3(aws_session):

    async with aws_session.create_client(service_name=AWS_SERVICE, region_name=AWS_REGION) as s3:

        response = await s3.list_buckets()
        logging.info(response['Buckets'][0])

        response = await s3.get_object(Bucket=BUCKET, Key=BUCKET_KEY)
        logging.info('File: {} {}'.format(response['ResponseMetadata']['HTTPStatusCode'], response['ContentLength']))

    time.sleep(60)
    await test_s3(aws_session)

async def start():
    session: AioSession = get_session()

    await test_s3(session)

if __name__ == '__main__':
    logging.basicConfig(level=logging.DEBUG)
    asyncio.run(start())

I have good news @oliverschewe. I've tracked down the problem.
Thumbor is recreating the Storage on every request, so we're reusing the client created on the previous request.
I'll try to address this issue.

@oliverschewe I've updated the PR, and tested it.
Now it's reusing the authentication.

The fix will be released on 0.4.3

https://pypi.org/project/thumbor-aws/0.4.3/


relax max_new_tokens to be per prompt

For vllm/gradio inference only for now
Relax max_new_tokens to be per prompt
Instead of max of all prompts for summarization/extraction
To have more output for reduction, since been seeing reduction truncated despite not alot of input.

Ignore mistrals, but ok, but what is stopping things for some models?

Sometimes fine, same exact summarization  with top_k_docs=2 on same doc.  Unclear why happens, but probably requests or something hangs-up threading and stops other threads from generating.


Solving problem with incorrect rendering on firefox

Replacing percent to vw  in css.

Before i create the pull request, i tested if rendering on firefox works like on chrome


Android Frame Processor threw an error: Exception in HostFunction: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/mlkit/vision/barcode/Barcode;

Hello, thanks for the great library. I'm just using this package and receive the error when scanning barcode.
package.json
{
  "react-native": "0.67.4",
  "react-native-vision-camera": "^2.13.1",
  "vision-camera-code-scanner": "0.2.0"
}

The Code :

  const isFocused = useIsFocused();
  const devices = useCameraDevices();
  // const [barcodes, setBarcodes] = useState();
  const [frameProcessor, barcodes] = useScanBarcodes(
    [BarcodeFormat.ALL_FORMATS],
    {
      checkInverted: true,
    },
  );

  <Camera
        style={StyleSheet.absoluteFillObject}
        isActive={isFocused}
        device={devices.back!}
        frameProcessor={frameProcessor}
      />

the example app in this repo is working for you?

i have the same problem on 0.67 version

clean everything and rebuild works for me thought