GetFavorites does not return all favorites

I have a couple of Sonos Radio HD favorites but the GetFavorites method doesn't return them so I can't use them as presets in node-sonos-http-api.  It calls a method browseAll("FV:2").  I looked at the Sonos S2 API and it says that FV:2 will return up to 70 favorites (I have less than that) but it seems it won't return these two.  In the debugger I tried calling the same method with R:0/0 which is supposed to return radio stations.  It doesn't return these either.  Am I missing something, or is this just an omission in the Sonos Controller API? I don't see any way to get to them.  This using an S2 system.  I have 2 systems (households?) on the same account, but I don't think that's related.  Running Ubuntu 22.04 LTS on intel hardware.  The API runs in docker but that makes no difference because it does the same thing when I put in Visual Studio Code with npm start outside docker.

I don't have an S2 system so can't verify your findings.
How may favorites do you actually receive? And where did you find the documentation about the 70 favorites? The Sonos UPnP API has never been publically documented afaik.
Since the offical apps is using the same UPnP API, I don't see how it would have been omitted by them, there is probably some fault at play.

You are correct, the document I was looking at is called the Sonos Control API not the UPNP api.  Nevertheless it seems to closely correspond to what you call (except for the houseHoldId).  The document is here: https://developer.sonos.com/reference/control-api/favorites/ .  That is where it states "Use the getFavorites command in the favorites namespace to get the list of Sonos favorites for a household. The player limits the number of Sonos favorites to 70".  I haven't actually tested if there is a limit because I only have 20 favorites.  I will investigate and get back to you.
The other document I was look at it is not official: https://svrooij.io/sonos-api-docs/,  It does not mention this limit.  But that is where I found the explanation of the FV:2 parameter for content browsing (https://svrooij.io/sonos-api-docs/services/content-directory.html). When I debugged your code it never seemed to return the Sonos Stations.  Just the Pandora stations.  But when I looked at the app just now and added a Sonos Radio HD station back, the display seemed different than what I remember. I will try adding a preset again and see if t works,
I never had an issue with a preset accessing a favorite before until I purchased Sonos Radio HD.  I added a couple of favorites.  Your code never returned them - just the pandora stations, the albums, playlists and so on.
I will try again in the debugger.  Perhaps I was mistaken or the recent app update changed things.  I will let you know.

Yeah I can confirm the S2 system does NOT return Sonos HD Radio Favorites.  This is what it gets from my system:
["Aardvark Blues FM","Ambient Radio","An African Night","Archaic Beats","Baroque Radio","Blues Acoustic","Blues Chicago","Blues Electric","Christmas Traditional","Classical 101","Country Outlaws","Crickets Summer Night","Dark Ambient Radio","Electronic Radio","Galactic Caravan","Gangsta Rap Radio","Hearts of Space","Houston Blues Radio","Imported Playlists","KERA","Radio Paradise Eclectic/World Mix","Sahara Sunset Radio","Smooth Jazz","SomaFM: Boot Liquor","SomaFM: Christmas Lounge","SomaFM: Deep Space One","SomaFM: Drone Zone","SomaFM: Heavyweight Reggae","SomaFM: Secret Agent","This Weeks Show","Thundering Rainstorm","Toad Trills and Thunder","Trending Now"]
It does not contain "Chill Beats" which is a Sonos Radio HD station favorite.  At least I marked it a favorite.  But when I look at My Sonos, all the things which are stations in the list above are in Stations (all favorited) but Chill Beats is not.  Sonos Radio Stations are in the list but Sonos Radio HD Stations are not.  Chill Beats shows up in a different list called Sonos Radio HD Favorites.  Nothing in that list is returned for the FV:2 call.  I have one unit in the house with voice control, a Sonos Move.  If I tell the move "Hey Sonos, play Chill Beats" it works.
I will investigate further.  As you noted there could be another "undocumented" api feature or its a bug.  My bet is on the former. I will have to dig out the packet sniffer probably.


The validator stops at vcard:hasEmail<EMAIL_ADDRESS>

When I include (optional)
  dcat:contactPoint [ a  vcard:Organization ; # kontaktpunkt     vcard:hasEmail<EMAIL_ADDRESS>;     ] ;
I get {"detail": "No connection adapters were found for<EMAIL_ADDRESS>from the validator, as a kind of syntax error (the validator stops).

Great if you could paste your input config (if any) when you call the service.

Great if you could paste your input config (if any) when you call the service.

If I understand you correctly, none input config used (except specifying which data file and which shacl file).

This issue should be fixed in c892270e756b0eca15c14668cc4c9cb840cbcf62. Please retest and verfiy, @shenluna and @jimjyang

This issue should be fixed in c892270. Please retest and verfiy, @shenluna and @jimjyang

Tested the staging version and it works fine!

Tested in staging and verified in prod. Works fine!


Open up browsing in zappdit!

@vivganes  zapddit needs to be logged in, any plans on opening it up and require login only for interactions?? I'd like to share the communities

Hey @pj8912  - Done!  I just pushed this change.
Please let me know if this is what you wanted.

@vivganes this is great, I was thinking more like, on opening the site there is already a keypair generated as an anonymous account where that user can directly post and interact, along with option to login with private key(Import prviate key/Secure login) if we already have an account.
Like saito.io/redsquare.


Re-implement repo with full git commit history

Before we get too far along, I believe we should re-implement this project with the full git commit history from the first commit in Bitcoin, to the Dash/Blackcoin fork (I'm not sure the actual timeline of how we got to Ion).
Would this be possible for the lead coin dev to do something like this?

Create a new branch
Remove all git history and code
From whatever point in whatever coin repository Ion started from to import that full git commit history and code
Cherry-pick all the commits from Ion Core to date (at time of writing 30)
Merge this over master replacing the current 30 commit history with the full commit history from the start of Bitcoin to Ion

Get out of my head! Though simply rebasing might be easier (depending).

@IngCr3at1on I figured there are probably better ways to do this :P
But I think this needs to be done as you stated:

Totally goes against what is generally considered proper open source practices
There's a reason revision control systems exist and nuking the history isn't one of them

Even if the lead coin dev can let us know the exact commit ID and repo we forked from I can give this a shot.

I agree. This way we can more easily keep in sync with development and fixes on the core.

yup this shouldn't be a problem, im not sure why it was left out honestly

Honestly i was givin a zip file with the source. That is why i made a clean repo.

If anyone want to tell me exactly how to do this i will rebase this.

Why does that not surprise me lol... @IonomyGuy there's a chance there will be a couple of conflicts during a rebase so it may not be as smooth of a process as one might hope... However the general idea is as follows.
git remote add upstream <upstream coin repo address>
git upstream fetch --no-tags
git checkout upstream/master
git checkout -b oldmaster
git checkout master
git rebase oldmaster
That would rebase the current master branch over the oldmaster branch...
For sanity sake it may be safer to not rebase the master branch lol though so this may be better...
after git checkout master before git rebase oldmaster
git checkout -b newmaster
then do the git rebase oldmaster after that.
Basically that would checkout a new branch based on the current master branch which you would then rebase over the upstream master branch. After that you could push that as a separate branch to review, etc before actually replacing the current master branch with the newly rebased master branch.

Well then i need to figure out where the master devs pulled from. Then i can do this.

@IonomyGuy nice work! Look forward to seeing this, let us know if we can be of any help.


Built-in library 'imp'  was removed in python 3.12, breaking chefboost

As title states, imp library used by chefboost was removed in python 3.12 (released last month), meaning chefboost is currently broken after 3.11. It's been replaced by importlib.

Closed with PR - https://github.com/serengil/chefboost/pull/41


[Feature Request] Add UWP support

ITNOA
Please implement PermissionsPlugin for UWP.
thx

Added documentation as 1.2.1 added limited support


create_policy: Set the generator to LegacyAllowList

LGTM. It fixes a bug (shouldn't compare to "1" and properly populates policy metadata on generation) while keeping the intended behavior, status-wise (i.e., has_runtime_policy has to be equal 1 if --runtime-policy was added to the keylime_tenant invocation)


Research Building downloadable .exe and .app for Windows and MacOS

Build .exe .under testing

I got pcapy-ng to build on my Mac and was able to run a test. Pretty exciting!


Naming: activate/deactivate over manage/release?

In the Distributed Tracing Workshop in Berlin there seemed to be some consensus forming on the verbs
activate / deactivate for in-process Span propagation.
@bhs would you agree that activate / deactivate speaks more of the intent than manage/release?

@sjoerdtalsma absolutely, yes.
That said, I have continued to work on a spike of yet another approach to this overall problem (where I'm permitting myself to change the core APIs, of course), so I'm trying not to worry too much about the naming until we have agreed on the basic moving parts.

Sounds smart and you shouldn't worry 😉 ..
However in my experience continuing to use different names for the same things should be avoided whenever possible (it can be here, by deprecation).

Created a PR #8 tackling this rename.

PR #8 was merged and released as 0.0.3


Rename Impacts to Areas of Accessibility Planning

Is your feature request related to a problem? Please describe.
In #2080 we're adding models to filament so that the service org is able to add/edit them. With these being surfaced to the UI, it was more necessary to align the name more closely with how it is presented to users on the site.
Describe the solution you'd like
Rename Impact to Areas of Accessibility Planning, this includes internal references and UI references. A database migration should also be provided to adjust the table name.
Describe alternatives you've considered
Only change the name for the UI presented in Filament. However, this may become confusing in the future when working on the code.
Additional context
No response

After reviewing the changes required, I think for now it makes more sense to just rename for the UI presentation. There would be 5 database tables that would need to be renamed in addition to all the model changes. Also the proposed name is long when used in the code and for table names. If needed we can address this further in the future.


Remove uniqueness on pushToken

We want to allow duplicate push tokens because we actually receive them duplicate. Investigating why

We're running into this too- haven't dug into exactly what's causing it yet, though.

Interesting enough, we are now allowing duplicate push tokens, and at the beginning we thought the whole combination identifier+push_token would have been duplicate, as if we receive duplicate calls on devise registrations, but they actually have different identifiers...https://github.com/coorasse/passkit/blob/main/app/controllers/passkit/api/v1/registrations_controller.rb#L22

As a reference: https://stackoverflow.com/questions/54311303/apple-wallet-is-push-token-unique-for-each-device#comment95467815_54311888


Set default image

Please fill out either the bug or feature request section and remove whatever section you are not using.
Question
Version Number of Plugin:
Device Tested On: iOS 10
Simulator Tested On: IOS 10.1
Hi James,
I would like to set the imagesource default from image in gallery. Please advise how to convert it to media file from url given in take photos.
I'm using below method to load it, but still no luck.
private async void pickPhotoDefault(string imagesource)
{
if (imagesource.Trim() != "")
{
System.Uri uri;
            System.Uri.TryCreate(imagesource, UriKind.Absolute, out uri);
            Task<ImageSource> result = Task<ImageSource>.Factory.StartNew(() => ImageSource.FromUri(uri));
            imgprofileuser.Source = await result;
        }
    }

Thanks
Best Regards,
Afin

It is as easy as just creating it from From:
var file = await CrossMedia.Current.PickPhotoAsync();
            if (file == null)
                return;

            MainImage.Source = ImageSource.FromFile(file.Path);


How to use?

Sport
All
Summary
How to use?

Hi @xicobiu, the repo wiki goes through getting started and all of the different features depending on the sport.


P Tags don't change color from a Sass variable

Couldn't find a variable to change the color of P tags, but could change colors of H-tags.

There is a $global-font-color that works for this. The $header-color is set to inherit but that can be overridden as needed. Does this set up make sense or do you think there needs to be an explicit $paragraph-font-color instead of $global-font-color?

The variable was somehow in global.scss. Moved it to typography.scss https://github.com/zurb/foundation-emails/commit/3dd792d9ed2bda6d86973f74a3d826bb5349cd6f


ValueError: Need to enable queue to use generators. SD-CN error on Paperspace

On paperspace there is an error called "ValueError: Need to enable queue to use generators."
This appears when I try the SD-CN video animator.
Somewhere said to make a git pull or an git remote set-url origin https://github.com/AUTOMATIC1111/stable-diffusion-webui
even more something like this:
//git reset -- hard
//git checkout modules/script_callbacks.py
//git reset HEAD modules/script_callbacks.py
//git checkout  modules/ui.py
//git reset HEAD modules/script_callbacks.py
Tried also to force the reinstall the dependences to true. Nothing worked.
Should I start with an empty SD folder renaming the Sd to SD-old ? is that the only solution?
Thank you for your support

I tried to fix that extension without success, try contacting the extension dev

oh, maybe it is related with something about the gpu and the new torch version like happens with the control net 1.1?
thank you for all your support and work

Yes, I remember now, one of the dependencies required by the extension isn't compatible with torch 2


Launch/Welcome Page - Sidebar

For this PR, I:

add a responsive navbar for the welcome page (launch page, which is related to the welcome page from the code file)
A burger menu added for the mobile version

Cons to improve:

The old styles cover the burger menu but I did not figure out where
I added border color for the two buttons but it does not show so it needs to figure out where is the priority to override this

I'll need to discuss with @quindipc before merging this PR.

Hello @mpa-mxiang - after confirming with @quindipc, the <WelcomePage /> is going to be phased out, so this PR is currently not needed. Please continue working on CCL2-104 and CCL2-115 instead.
If you have any questions, please ask in Slack. Thank you.

Hi @Ant-Shell ,
As your explantation, landing page is the page that users see before sign in; the landing page for this purpose called welcome page as I see.
Please correct me if I am wrong so that I will see whether I can just ignore this for now or move this navbar to landing page

Hello @mpa-mxiang I will reach out to you in Slack to discuss further.

UPDATE:

Since I need to work on the landing page, I called this navbar feature on the landing page and now it works for desktop but does not show on mobile.

After deleting other parts of the page, the burger menu shows well on mobile. I will leave like this for now and check what property caused this higher priority to cover the navbar on mobile.


Const constructors?

I have immutable class with const constructor and all fields final. I don't want to make them nullable or required. Instead, I want to set default value in const constructor. With regular list, I can do that this way (myList field must be final):
const MyClass({
this.myList = const [],
});

But I can't do the same with your immutable list, because there's no const constructor. Is there any workaround for that? From some reasons, I don't want to make myList field nullable and also I don't want it to be required, I want to assign default value instead.

There is a const constructor:
const IList<int> ilist1 = IListConst([1, 2, 3]);
const IList<int> ilist2 = IListConst([]);
const IList<int> ilist3 = IListConst([1, 2], ConfigList(isDeepEquals: false));

That's item 2.1 of the documentation.


How to build on an existing PostgreSQL server

Hi,
I already have an existing PostgreSQL 16 server build from source and running on Debian. And I don't want to run a separate PostgreSQL instance in a docker container.
How can I build the pgml extension by myself to use it inside my own existing PostgreSQL server.
Something like:
$ git clone https://github.com/postgresml/postgresml.git
$ make
$ make install

+ installing the relevant Python modules.
I tried as supposed in developer doc but get an error like that:

Hope you can assist me!
Thanks
James

There's a git submodule that you need to compile the extension. Try running git submodule update --init --recursive and let me know if that works for you!

That was the solution!
Thx


Support querying all data when number of records is more than maxRecordCount

myStore.query() right now will only return up to the ArcGIS Server maxRecordCount. I would expect (I'm open to hearing others perspectives though) that when I do this, the arcgis-server-store should take care of calling the /query endpoint multiple times for me, to get all my data, in this case.

I agree that this would be a nice feature.

+1 for sure. Nothing worse than a stingy AGS that you can't control.
Unfortunately the excededTransferLimit boolean was not added to the query result until 10.1 and then paging was added at 10.3 with resultOffset and resultRecordCount. And then the excededTransferLimit was not added to PAGED query results until 10.3.1 (crazy history right). This makes it a mixed bag when trying to get all records depending on the AGS version. I would propose you just go with 10.3.1 support and call it good.


[SPARK-39856][TESTS][INFRA] Skip q72 at TPC-DS build at GitHub Actions

What changes were proposed in this pull request?
This PR reverts https://github.com/apache/spark/commit/7358253755762f9bfe6cedc1a50ec14616cfeace, https://github.com/apache/spark/commit/ae1f6a26ed39b297ace8d6c9420b72a3c01a3291 and https://github.com/apache/spark/commit/72b55ccf8327c00e173ab6130fdb428ad0d5aacc because they do not help fixing the TPC-DS build.
In addition, this PR skips the problematic query in GitHub Actions to avoid OOM.
Why are the changes needed?
To make the build pass.
Does this PR introduce any user-facing change?
No, dev and test-only.
How was this patch tested?
CI in this PR should test it out.

Im gonna merge this one. I don't think my fork is reliable to check the flakiness.

Yeah, I will file that one soon after checking the results.

Tests seem passing fine now. I filed a JIRA at: SPARK-39903


Laravel 5.5

I ran into this issue when I upgraded to laravel 5.5
Declaration of Jenssegers\Mongodb\Eloquent\HybridRelations::belongsToMany($related, $collection = NULL, $foreignKey = NULL, $otherKey = NULL, $relation = NULL) should be compatible with Illuminate\Database\Eloquent\Model::belongsToMany($related, $table = NULL, $foreignPivotKey = NULL, $relatedPivotKey = NULL, $parentKey = NULL, $relatedKey = NULL, $relation = NULL)

Exactly ! I have same problem !
I guess the authors must be redefine "belongsToMany" function with new parameters
Thanks again for your great work!

Broken from Laravel v5.4.31. See this commit.

Fixed on laravel's side.  https://github.com/laravel/framework/pull/20407

fixed this issue?

@SimplyCorey How do we fix it? I read about solved in Laravel Side, but still getting this error with laravel 5.5 installed yesterday and the package added today.

Check out https://github.com/jenssegers/laravel-mongodb/pull/1282/commits/066e2193bc50d2dce1802c00d46ce3b7d252a1c6

@smendozaisf Check out this gist https://github.com/jenssegers/laravel-mongodb/pull/1282/commits/066e2193bc50d2dce1802c00d46ce3b7d252a1c6

@smendozaisf  Laravel ended up reverting the change and making it a backwards breaking change again.  My comment is no longer valid.

I ended using Laravel 5.4. I don't like to change vendor folder files. When this package make the update, I'll migrate to Laravel 5.5. I hope it will soon
Thanks :)

i getting  the same issue with laravel 5.5

i getting the same issue with laravel 5.5.14

No fix yet? I guess i'll have to go back to 5.4 for now.

i getting the same issue with lumen 5.5

i too am getting this error with laravel 5.5!! Is this issue resolved, if not why is it showing as Closed!!

Me too i have the same problem with Laravel 5.5

why @jenssegers not resolve this issue?

This issue still stands 👎


Adjust Gatekeeper Policy Installation For Improved CLI Installations

This PR moves the gatekeeper constraints from the gatekeeper-policies package to the core-landing-zone package. This will help resolve issue #409 and allow for easier non-gitops based installation approaches as this allows for the ConstraintTemplate to be installed before the gatekeeper constraint file and prevents the issue where one would need to comment out of the constraint file first before apply the gatekeeper-policies package.
The overall goal of this PR is to improve the installation process for users of non-gitops based installs, kpt in particular. This would also allow us to install more constraintTemplates via the gatekeeper-policies package into the cluster without needing to enable them right away.

@alaincormier-ssc @davelanglois-ssc @fmichaelobrien I made the changes discussed yesterday and wanted to get your input before I start fixing the README and Kptfiles.
Created a new solution directory called policy-constraint-bundles with 2 bundles, guardrails-v1 and naming-policies.

@alaincormier-ssc @davelanglois-ssc @fmichaelobrien I made the changes discussed yesterday and wanted to get your input before I start fixing the README and Kptfiles.
Created a new solution directory called policy-constraint-bundles with 2 bundles, guardrails-v1 and naming-policies.

that should work
will each bundle be tagged by release-please?

That's what I was thinking, might be overkill but I believe having specific task based bundles makes sense. I was using the Anthos Gatekeeper Bundles as by point of reference.

Hey @cartyc, I really like the concept. If I understand correctly, the constrainttemplate would remain in the existing gatekeeper-policies package. Do you think that name still make sense ?

Hey @cartyc, I really like the concept. If I understand correctly, the constrainttemplate would remain in the existing gatekeeper-policies package. Do you think that name still make sense ?

That's correct, the package would just act as a means to load the constrainttemplates into the Config Controller or GKE instances, similar to what happens when you you enable the installation of the default template library on policy controller I think the name gatekeeper-policies still works but maybe the bundle names might need some additional tuning to help keep things more distinct. gatekeeper-policy-templates might be a good option though if we want to rename the package.

Thanks Mike, I was just cracking open an editor to start hacking away at the linting issues.

@davelanglois-ssc should be good for a final review.

closing - keep reference code only


Remediate (or remove) POD users with no organization

The new design for the homepage includes a customized section with content that is based on the user's organization.
However, because there is currently (or was) a way for users to register directly, and that path doesn't associate the user with an organization, our list of current POD users includes some that don't have an associated organization. I think violates the rule we want to have going forward that every POD user belongs to one organization.
We should remediate (or remove) the existing POD users with no associated organization. Otherwise, we'd have to have some additional handling of the org section on the homepage to deal with users with no organization.
I suspect it would probably be pretty easy to look through the (presumably very short) list of users with no organization and figure out which org to add them to. For any where it isn't obvious, I guess we could send them an email and ask who they are and who they work for, and either associate or remove them from POD depending on their answer?

Users without any organization affiliation have been remediated. I deleted a few that I couldn't identify but mostly just added them as members to their org:
3.0.0 :074 > User.all.select { |u| u.organizations.empty? }
 => []


Wrong autocomplete for build function in scss

I write in scss file:
.example {
color: darken
}

after write darken I hit tab key to select value from autosuggest list, and finally i get:
color: darken(: , : 0)

instead of:
color: darken($color , $amout);

This same situation I have in all build functions, like for example:
str-index(: "", : "s")
str-length(: "")
nth(: , : )

Where does the suggestion come from? Is this an emmet feature? @ramya-rao-a

That's coming from the css completions


Read/write the encoded cargo update --precise in the same place

What does this PR try to resolve?
There's a stringly typed interface between https://github.com/rust-lang/cargo/blob/de7537e63296ee13cb78611a988bcc9a6ac26134/src/cargo/ops/cargo_generate_lockfile.rs#L105 and https://github.com/rust-lang/cargo/blob/de7537e63296ee13cb78611a988bcc9a6ac26134/src/cargo/sources/registry/index.rs#L587, the only reason I found it with by finding the original commit https://github.com/rust-lang/cargo/pull/5205
As far as I can tell, anyone could just create this internally meaningful ~structure~ string by passing it on the command line.
This should get cleaned up, for now by moving the encoding and decoding in to the same file.
How should we test and review this PR?
Internal refactor and test still pass.
Additional information
I am hoping that in the redesign of cargo update we can come up with a better design for smuggling this data from the API all the way to querying the registry. It seems like locking the dependency to the selected version would be conceptually simpler, or using the patch system, or something.

@bors r=epage

:pushpin: Commit 4d63fbcc0fc73f9a16d2f1e5df03687a77152df9 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 4d63fbcc0fc73f9a16d2f1e5df03687a77152df9 with merge 016fe194a3cd0743799f73af37725531111767c9...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 016fe194a3cd0743799f73af37725531111767c9 to master...


feat(picker): migrate to spectrum 2

Description
Migrates the Picker component to use Spectrum 2 specifications.
Includes a total overhaul of the Chromatic-only Storybook template in order to increase coverage for this component's many options. This format was based off of the stories for Action button and the grid of Picker options in the S2 / Desktop Figma. See the "Show testing preview" within Storybook. A control for the optional workflow icon that appears to the left of the text within the Picker was added; this was previously on the YML docs but missing from Storybook.
This also fixes:

Some specificity issues that were causing the colors to change on hover when it was in the disabled state.
The positioning of Popover in Storybook for the side label variant (this previously was incorrectly appearing to the right instead of below). The Popover width will also now match the width of the Picker in the Storybook examples.

The mod custom property --mod-picker-spacing-text-to-alert-icon-inline-start that was previously marked for deprecation has been removed:

deprecation --mod-picker-spacing-text-to-alert-icon-inline-start has been renamed to --mod-picker-spacing-text-to-icon-inline-end [...]

CSS-617
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps

[ ] Reviewed and approved by design team (@jawinn)
[ ] Test the default Picker and its controls
[ ] Picker is using the new tokens for field width and rounding, as defined on the token specs design file
[ ] Examples in the Picker Chromatic template look correct and like the S2 / Desktop Figma + token specs
[ ] Fix: Background color and color do not change when hovering over any disabled state
[ ] Fix: Popover appears beneath the Picker instead of weirdly to the side when viewing the side label positioning
[ ] "Icon" content field in Storybook is working

Regression testing
Validate:

The documentation pages for at least two other components are still loading, including:

[ ] The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

[ ] VRTs have been run and looked at.
[ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

[x] I have read the contribution guidelines.
[x] I have updated relevant storybook stories and templates.
[ ] I have tested these changes in Windows High Contrast mode.
[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[ ] ✨ This pull request is ready to merge. ✨

Looking at this in forced-colors, I see that the chevron is the disabled color when the loader is present. That is intentional? On hover it changes color, which I'm guessing should not be the case.

Quick note the we've previously had some issues with Chromatic cutting off screenshots. We should definitely run the VRTs on this to make sure it's able to see everything.

Thanks for looking this over. I've made some updates to address the comments and suggestions so far:
@mdt2

The forced-colors disabled icon no longer changes colors on hover. I am bringing up in design review to confirm how this looks overall.
"Spacing around the disclosure icon": I was able to untangle these spacing issues with a small refactor in the latest update. They should be right values now. Previously there was a .spectrum-Picker-label ~ .spectrum-Picker-menuIcon rule which was applying when it shouldn't have been, and overriding the correct tokens.
Disabled and and loading no longer show the down state on click. I brought up the question about the down state when using the quiet variant with design.

@rise-erpelding

Good callout on the text-to-alert-icon-* tokens. This has been replaced with the updated text-to-visual-* tokens.
I've made those two wording updates.

I've also made sure that text truncation of the placeholder text is now captured in the Chromatic template, along with Sizing + Quiet.

This is ready for a re-review.
There are some followup (can be post-merge) items that I've created in CSS-777.
It also will be necessary to change a couple CSS selectors based on what ends up being decided in the bug fix to main #2737 (ideally before merge).

Looking at this in forced-colors, I see that the chevron is the disabled color when the loader is present. That is intentional? On hover it changes color, which I'm guessing should not be the case.

You might have already wrapped this conversation up, but just wanted to make sure this is the behavior y'all settled on. I still see the chevron turning to the green disabled color if I click on the picker with the loader. The chevron doesn't change color on hover now.
https://github.com/adobe/spectrum-css/assets/69602589/dbcfe967-5a5b-4926-b153-7af42e8f62fb

Looking at this in forced-colors, I see that the chevron is the disabled color when the loader is present. That is intentional? On hover it changes color, which I'm guessing should not be the case.

You might have already wrapped this conversation up, but just wanted to make sure this is the behavior y'all settled on. I still see the chevron turning to the green disabled color if I click on the picker with the loader. The chevron doesn't change color on hover now.

Yes, this appears to be correct. I asked design to look at this during their review.

Hey! This looks really good and my only callouts now are pretty small:
I'm seeing spacing-200/12px for "Spacing (minimum, field label to field)" for what looks like the spacing between the side label and picker, but I only see 8px of spacing, should there be more?

Can you check this again? I'm seeing 12px coming from the spacing-200 margin on the Field label. This spacing is on the separate Field label component, so any issues here shouldn't need any changes within Picker.

Should there be Help Text anywhere in the Storybook for Picker or has that been intentionally left out here? (Is it tested in a different component, maybe?)

Help text (a separate component to Picker, shown adjacent to it) is a control under Content. Though it doesn't have any styles within Picker, it is demonstrated in the Chromatic-only template for invalid and quiet just in case.

I've rebased this with the fix changes from main in #2737 . Please double-check the disabled, disabled hover, and quiet disabled during re-review.

Weird Testing Preview Loading So I know this isn't always a problem because I've reviewed this PR before and remember seeing it then, too, but sometimes I load the testing preview (locally, because the Netflify preview is broken for me) and it does this: [...]

This was when "open" gets toggled first before switching to the chromatic view. To avoid this I've updated those Chromatic templates to specify isOpen: false on the ones that should stay closed.

Picker Loading Behavior I can click on Picker when it's loading and the Picker chevron changes color, since the menu isn't supposed to be visible in the loading state, that doesn't seem like expected behavior. I can also toggle the Open control for the same effect.

I've put in a fix for this by adding .is-loading to the &.is-open:not selector, and moving the .is-loading styles near the bottom like the .is-disabled styles. The chevron should no longer change color when it happens to have both loading and open set.

Other Loader Weirdness Also, I just captured the loading state for WHCM looking a bit like a solid circle: [...]
But I also just reloaded and saw loader working as it does in SWC so I'm wondering if this is a weird Storybook thing that we shouldn't worry about.

I've noticed some weirdness with the loading of the progress circle as well in other parts of Storybook; a hard refresh usually fixes it (such as on the S2 Docs page for Button->Pending state). The progress circle will be replaced with the in-field progress circle when that is created for S2, which is part of the followup Jira item CSS-777. We'll want to review some of the high contrast styles for both progress circle components when they're worked on (Button had specific high contrast styles worked on with those double borders you see in SWC, but I don't think those carried over to Progress circle itself).


Don't use Encoding.ASCII

Encoding.ASCII silently corrupts the input if it contains characters outside the ASCII range. One consequence of this is that all non ASCII strings of equal length will have the same hash. This enables the very HashDoS SipHash was designed to prevent.
You could UTF-8 new UTF8Encoding(false, true) or UTF-16 new UnicodeEncoding(false,false, true) instead. Note that Encoding.Utf8 and Encoding.Unicode suffer from similar corruption as Encoding.ASCII if the string is invalid, so they shouldn't be used either.
Alternatively you could manually convert each char to two bytes, which you feed to SipHash. Or combine four chars to a 64 bit integer and feed it to SipHash directly, bypassing the conversion to bytes directly. These approaches have the property that they won't throw exceptions when operating on invalid strings.

Thanks those were just examples to simply explain the point, I didn't want to confuse user with encoding semantics. Do you think it would mislead developers?

Closing per my explanation.


KANSUP74-12 add ingressClass config

Since kubernetes 1.18, the IngressClass object (& ingressClassName property) are intended as a replacement for the deprecated kubernetes.io/ingress.class annotation.
This pr provides default config for our alfresco deployment.
https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation

I'm trying to understand what it does,
So by adding the field:
ingressClassName: nginx
To the Ingress resources/template/....
it will automatically look for the ingressClass resources named nginx.
this ingressClass appends? the controller: k8s.io/ingress-nginx field defined in the class to the original one?

I'm trying to understand what it does,
So by adding the field:
ingressClassName: nginx to the Ingress resources...
it will automatically look for the ingressClass resources named nginx.
this defintions inside the ingressClass resource then appends? the controller: k8s.io/ingress-nginx field defined in the class to the original one?

If I understood correctly, the nginx-controller used to look for annotations on the ingress object to detect whether it should interact. However, this was implicit behaviour and not officially standardized.
Now a separate object is made that explicitly links to the ingress through the ingressClassName property and explicitly defines the controller that interacts. The ingressClass object also allows us to define additional config for the target controller, and allows that config to be loaded from other external objects.
The annotation is still present, and should be interpreted for backwards compatibility, but towards the future we should focus on ingressClass.

Why the local-values.yaml?

local-values.yaml was a pre-existing part of the repo to install the chart against a local k8s cluster. It provides some overrides/extensions of the default values that are required. I used it for testing, as well as for demonstrating how to fall back on the annotation.

Now you define the ingress class 2x, once as an annotation in the values file and once as an ingress.ingressClass variable. Ideally this should be only one since both values should be the same. The variable should also be used to define the annotations.
Unfortunately this annotation is already overwritten by some local deployments (OUP) where we set the ingress.class:alb
The current impl is to allow the legacy usage of the annotation with a custom value:

When ingressClass is present (by default now through the included values), the ingressClassName property is set and the annotation would be filtered out if it is present
If ingressClass is empty (or set to null), the annotation would not be filtered, allowing it to be set with whatever value it has defined

also update the readme file
and preferably also the changelog, certainly when this would introduce a breaking change if we overwrite the ingressAnnotations with another value.

Will do


KeyError when runnning git gud test

There shouldn't be a KeyError here, the function should just return false when things are incorrect. We should also add a test for this specific case
git gud load basics branching
git branch bugFix
git gud commit
git gud test

util.py line 177 in test_skill:
KeyError'1'

No longer an issue, refactors likely fixed this


[WIP] refactor: FSM for order status change

Hello @Haider8! Thanks for opening this PR.

In the file app/api/api_v1/endpoints/orders.py:

Line 103:22: E701 multiple statements on one line (colon)
Line 103:22: E231 missing whitespace after ':'
Line 103:23: E225 missing whitespace around operator

Do see the Hitchhiker's guide to code style

@iamareebjamal Please review


On disable mode For Android platform the player progress color is not visible.

Environment
System:
OS: macOS 10.15.6
CPU: (4) x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Memory: 52.14 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 15.2.0 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.8 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.0 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 28, 30
Build Tools: 27.0.3, 28.0.3, 30.0.3
System Images: android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>53283
Xcode: 11.5/11E608c - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_275 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.9.0 => 16.9.0
react-native: ^0.63.2 => 0.63.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Description

Reproducible Demo

per android native implementation there is no progress colour visible in disabled mode

Hello @HITESH122!
The issue you describe is not really a defect, but a default Android platform specific behavior.
Please remember that this library exposes the native implementations of Sliders from various platforms.
If there is a broader need to override this behavior I can transform this bug into a feature request, but it would have to be kept accessible as having Slider disabled should give a clear feedback to user.

Closing due to lack of community's interest and details described in the previous comment.


SimpleRTK build fails for releases distributed as zipfiles due to missing git version details

As the title says. I downloaded the 1.4 zip file and tried to build it, enabling a few more options than I actually need, in particular SimpleRTK. The build of RTK itself succeeds but SimpleRTK fails because in line 37-40 of utilities/SimpleRTK/CMake/srtkSourceVersion.cmake it tries to include the srtkSourceVersionVars.cmake file that does not yet exist (if the source had been checked out with git then that cmake file would be generated from the srtkSourceVersionVars.cmake.in source template file).
I guess there are several ways to solve this trivial issue. One way would be to add a pre-generated srtSourceVersionVars.cmake file to the release zip file.
For me this issue is not critical, because I do not actually need SimpleRTK for anything. I was just curious. After switching off SimpleRTK the installation of RTK version 1.4 succeeded.

Thanks for the report. The release zip are automatically generated by github so it's not so simple to do it (although a separate release branch with this file would do). But I think we won't fix that because we will soon remove SimpleRTK for another type of Python wrapping (which are the only ones that we have supported and have been used to my knowledge). I'll close your issue as soon as this is done.
Simon

With the recent release of RTK v2 and associated python packages, SimpleRTK is no longer maintained and I suggest to use the new packages.


Switches build to JRE 11

There's no recent build of JRE 1.8 we haven't already built. This switches the build to JRE 11.

ignore travis :)

gonna merge this. we can overwrite the tag etc.

Since we still publish an image that uses JRE8 (zipkin-dependencies and Cassandra I think), I think we should still keep the old Dockerfile in the repo for reference, or it's hard to know how an image was produced.

we have tags for that. cassandra is a test image and only other thing is
zipkin dependencies. not in favor of using directories when we already have
git.
if for some reason we need to do a post 1.8 release we can branch off last
1.8 tag same as we do on normal code


padding_shapes -> padded_shapes to match parameter

I believe there's been an error here: the docstring mentions padding_shapes, while the parameter it seems to be referring to is padded_shapes.

We will not be encouraging one liner grammatical changes as this is expensive process, thank you for your interest.
CC @mihaimaruseac

It's better to submit multiple typo fixes in a single PR as the CPU/GPU hours wasted to CI test the typo are too many in comparison with the seconds it takes to submit a single typo fix.
I see you have created 4 extremely short typo fix PRs, is this to get the Hacktoberfest T-Shirt?
Please try to get multiple typos in one PR. For example, fix all typos in this file/directory?

Haha sorry, didn't realise the implications!
And no, I have no idea about t-shirts - I've just been reading a lot of documentation lately for my experiments, and try to correct where I can :)
I'll see if I can get multiple typos together, if I notice something again. Thanks!


docs: major docs improvements, transform tool examples to chat directives for docs

Codecov Report
Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (a63f1c5) to head (9a5ce6f).

Files
Patch %
Lines

gptme/commands.py
33.33%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   78.10%   76.60%   -1.51%
==========================================
  Files          32       32
  Lines        2238     2261      +23
==========================================
- Hits         1748     1732      -16
- Misses        490      529      +39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119612

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119874

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120928

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120956


Dynamic Components

Hi! Can I make my template choose a component based on data?
For now I'm using something like
{{#if component === 'c1'}}<c1 />{{/if}}
{{#if component === 'c2'}}<c2 />{{/if}}

but that means the template has to know which components are available.
So I thought, maybe we could have nice things like <{{component}} />, or am I doing it wrong?
(BTW, ractive rocks, thanks for that!)

Right now you cannot define dynamic components. You can however define dynamic partials, so if you do not require the extra features of components, a dynamic partial might suit you well.
partials: {
  'myPartial': 'Hello World'
},
data: {
  foo: 'myPartial'
}

// outputs 'Hello World'
{{>foo}}

Ractive rocks indeed ...but I wouldn't push it too far. Doing something like <{{component}} /> seems like opening Pandora's box ;)

Heh, thanks! Just wrapping those components in partials actually seems to work for me - let's see if Elpis still is in that box:)
So there are no plans for dynamic components? I have to admit that I have no idea where/how to implement that myself. But I can live without it - there will be other workarounds if the above hack breaks.

The current state for dynamic components assumes they won't change once rendered (unless the hosting view changes or is reset) and is specified using a function for the component:

<selected-component/>

// js, assuming corresponding component names returned by data.component have been registered
components = {
  'selected-component' : function(data){
    return data.component;
  }

AFAICT, the work @evs-chris did for partials (to use the result as a reference instead of a token when the token cannot be found) is logically portable for components and IMO would be pretty useful instead of having to code the above, plus you get the targeted rerender if it changes without having to muck about with reset on the parent view (you can fake this to some degree by using partials that contain a component).
I would forgo the {{ref}} and do same as partials -just try to process as a mustache ref if is not a registered component:
Ractive.components.c1 = C1;
Ractive.components.c2 = C2;

new Ractive({
  template: '
<component/>
<c1/><c2/>'
  data: {
    component: 'c1'
  }
});

// would yield same as:
'
<c1/>
<c1/><c2/>'

I think there's probably too much that would need to happen to support either the mustachioed or 'just look up the name as an expression' methods. Partial expressions as of 0.8 support inline partial content, and that with template strings gets you to {{> { template: <${component} /> } }}, which is certainly not awful. If you want runtime-only support (no parsing), you can achieve the same thing pretty easily by adjusting the e value of a pre-parsed template inline.


input - added bordered input variant

Part of #3456

@ThusharaJ07 there's an issue with the activation line when Corner = Round both for full and bottom bordered components (for both Input and Multiline). At the moment it doesn't follow the rounded corner.

Replaced by #3537


phpcs: support multiple standards. Close #173

https://github.com/EdgedesignCZ/phpqa/issues/173

All checks have failed, escaping doesn't work for paths, no doc.
Reimplemented in https://github.com/EdgedesignCZ/phpqa/pull/177


Add mindir format support.

🤗👋Hi! We have added our .mindir format. Please review our commit.

@Ethan-Chen-plus can you provide some context:

What is mindir, what problem is it solving and for how many users?
Why is a new format needed given there are many similar formats?
Create a script in ./tools following the patterns used for other frameworks to recreate the -proto file.
Add a test to ./test/models.json and share an index of 50+ existing files in this format.

PS I:\netron> npm run validate
eslint
pylint
test
gguf/phi-2.Q2_K.gguf
onnx/candy.onnx
keras/1151.4.keras
coreml/Exermote.mlmodel
pytorch/alexnet.ptl
pytorch/DCGAN2.pt
tf/conv-layers.pb.zip
tflite/mobilenet_v1_0.75_160_quantized.tflite
tflite/squeezenet.tflite

I have updated my code, please review.
@lutzroeder

@Ethan-Chen-plus can you provide some context:

What is mindir, what problem is it solving and for how many users?
Why is a new format needed given there are many similar formats?
Please rebase to latest main.
The ./tools scripts should generate regenerate to files from the original .proto. When changing the format or generator for -proto.js or -metadata.json these files should automatically get regenerated from the original source when running ./tools/mindir sync schema metadata.

@lutzroeder Thank you again and we have updated our code. And let me introduce some background infomation:

What is mindir, what problem is it solving and for how many users?
MindIR (MindSpore IR) is a graph-based functional Intermediate Representation (IR) format developed for the MindSpore framework by Huawei. Its primary purpose is to define the logical structure of networks and the attributes of operators, facilitating the decoupling of model files from hardware platforms through a unified IR. This supports a train-once, deploy-multiple-times paradigm. A key advantage of the MindIR format is its ability to store network structures and weight parameter values, enabling deployment for inference tasks on cloud-based Serving and edge-oriented Lite platforms. The same MindIR file can be deployed across various hardware types, including Ascend AI processors, GPUs, and CPUs.

The user base for the MindIR format primarily comprises researchers, developers, and enterprises needing to deploy AI models across multiple hardware platforms. Given its compatibility with diverse hardware including Ascend AI processors, GPUs, and CPUs, MindIR is particularly well-suited for applications that require deployment both in the cloud and on edge devices. For instance, MindIR can be utilized in Huawei's Atlas 200/300/500 inference products, which are specifically designed for edge AI processing scenarios.
-Why is a new format needed given there are many similar formats?
Compared to other similar IR formats such as ONNX and AIR, MindIR presents unique advantages and application scenarios. ONNX (Open Neural Network Exchange) is a universal format designed for the expression of machine learning models, primarily used for model transfer between different frameworks or on inference engines like TensorRT. AIR (Ascend Intermediate Representation), defined by Huawei, is an open file format tailored for machine learning to better accommodate Huawei AI processors, typically used for inference tasks on Ascend 310. MindIR, on the other hand, is a functional IR based on graph representation. It not only defines an extensible graph structure and operator IR representations but also eliminates model discrepancies across different backends. It is generally used for cross-platform inference tasks, such as executing inference on Ascend 310, GPUs, and MindSpore Lite for models trained on Ascend 910.

@lutzroeder Hello.👋 I noticed that eslint failed. Could you please tell me which config file eslint is using? I'll make the necessary fixes based on that config file. Thank you!

Requires approval, thank you🤗

Workflow requires approval, thank you again🤗

Closing as stale. Please comment with additional information if the pull request should be reopened.


implements for PeerMembershipQuery

fix #125

@SamYuan1990 fix commited，please make a review

@SamYuan1990  the accidentally deleted file signaturepolicy.go recovered， please make a review

@SamYuan1990 have tested with golangci-lint, please make a review


Error using Private Key - unsupported key format

Hi there,
I'm trying to use the PrivateKey method for autentication on my remote server, but I'm failing to login using this node. The node returns "Cannot parse privatKey: unsupported key format".
I've just generated the key using the command "ssh-keygen" and I've check that I can ssh to remote site using the key with success. Also in my opinion the key has a correct format:
-----BEGIN OPENSSH PRIVATE KEY-----
Lots of lines with random chars
-----END OPENSSH PRIVATE KEY-----

The node settings I think are fine:

Can you please help me?
Thanks in advance

Hello,
this node relies on ssh2 which is a separate module.
You should try to generate your public/private key pair with a command such as:
ssh-keygen -m PEM -t rsa
That will generate a compatible key
Have a nice day

Hello,
this node relies on ssh2 which is a separate module.
You should try to generate your public/private key pair with a command such as:
ssh-keygen -m PEM -t rsa
That will generate a compatible key
Have a nice day


What distro of ros does this package currently support?

I've tested it on jade and kinetic.  It probably works on indigo or can be fixed easily if not.

Ok, I will try to use it on indigo, and can create an indigo branch if I need to make any major changes to fix it. Thanks!


Adds support for KSqlDB session variables

Please check if the PR fulfills these requirements

[x] The commit messages are descriptive
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] An issue has been created for the pull requests. Some issues might require previous discussion.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature - https://github.com/kafka-ops/julie/issues/545

What is the current behavior? (You can also link to an open issue here)
KSqlDB Session Vars are not supported

What is the new behavior (if this is a feature change)?
Allows to specify session vars that can be interpolated in parametric KSqlDB artefacts

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes. Session vars can be safely omitted from the topology descriptor file

Other information:
Upgrade of KSqlDB container and API client to versions that support the definition of session vars.
Upgrade of Zookeeper client due to conflicts with Netty dependencies

I like it, thanks a lot @nachomdo for your contribution. I'm in the process of merging this in, it will be available in the next upcoming release.


feat(config): incremental/chunks boolean

brings some perf improvements by not writing chunks file and re-using parser results with a panda.buildinfo.json file on initial startup

As we discussed, let's keep this on the back burner until we really need it.


etcd backend broken on v7 (fails on initial connection)

Works fine on v6, skydns2 works fine on v7 also, but etcd doesn't work on v7.
At first I thought it was a timing thing (running in docker-compose, and assumed maybe registrator was starting it's process faster than etcd was ready). But with unlimited retries, it seems to just sit there.
Retry Interval was not being honoured either for some reason...
Config used in docker-compose.yml (note the lack of net=host currently, dealing with that later):
registrator:
  image: gliderlabs/registrator:v7
  command: -retry-attempts 50 -retry-interval 3 etcd://etcd:2379/services
  links:
    - etcd
  volumes:
    - "/var/run/docker.sock:/tmp/docker.sock"

Log output:
$ docker logs blah_registrator_1
2016/08/15 05:41:14 Starting registrator v7 ...
2016/08/15 05:41:14 Using etcd adapter: etcd://etcd:2379/services
2016/08/15 05:41:14 etcd: using v0 client
2016/08/15 05:41:14 Connecting to backend (0/50)
2016/08/15 05:41:14 Connecting to backend (1/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (2/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (3/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (4/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (5/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (6/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (7/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (8/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (9/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (10/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (11/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (12/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (13/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (14/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (15/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (16/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (17/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (18/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (19/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (20/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (21/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (22/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (23/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (24/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (25/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (26/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (27/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (28/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (29/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (30/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (31/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (32/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (33/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (34/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (35/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (36/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (37/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (38/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (39/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (40/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (41/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (42/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (43/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (44/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (45/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (46/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (47/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (48/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (49/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 Connecting to backend (50/50)
2016/08/15 05:41:14 etcd: sync cluster was unsuccessful
2016/08/15 05:41:14 501: All the given peers are not reachable (Tried to connect to each peer twice and failed) [0]

Note, running etcd 3.0.4 here. Possibly an issue with etcd v3?

Invalid bug report, turns out I had my ETCD_ADVERTISE_CLIENT_URLS set to http://localhost:2379/ which was causing failures (unable to contact all backends). Changed to a working hostname, and things kicked off fine.


move metrics service in metrics subfolder

This should fix https://github.com/googlecartographer/cartographer_ros/issues/1016
Note that by doing so, it means the this service will not have documentation generated (as for all metrics messages located in msg/metrics).
The alternative is to place all .msg files at the root of the msg folder and all the service files at the root of the srv folder.

I'd prefer moving all files to the root folder as the easiest solution. Then users can also use standard ROS tools like rosmsg show cartographer_ros_msgs/MetricFamily or rossrv show cartographer_ros_msgs/ReadMetrics, both don't seem to work with non-standard paths.

Yes the assumption in ROS tool and infrastructure is that the standard pattern of placing them in the root folders is respected.
Updated the PR accordingly

This is a known problem that I'm trying to solve with https://github.com/googlecartographer/rfcs/pull/37
Until then, we might need a force merge...


Expand env vars in inventory path

Signed-off-by: NilashishC<EMAIL_ADDRESS>If the inventory path in settings file had an env var, it was not being expanded, which also resulted in abs_user_path() prepending pwd to it.

nice fine @NilashishC ! TY


fixes bug 870015 - background reloading on event state change

Hi @peterbe
This is a pull request for the bug you suggested I look at previously such that if the event status for a live event changes to pending or from pending to archived it will reload the page. Thanks for the suggestion it certainly felt a little more challenging!
I look forward to hearing any feedback as I wasn't 100% sure on the best way to do this one - particularly with respect to how the javascript accesses the data it needs from the html page.
I would also like to add a test for the view but I have held off doing that for now as I am still figuring out how to do that.
thanks, Alex

Great feedback @peterbe!
So I’ve changed the api from /eventstatus to /status.
I’ve changed it to use the slug instead which seems pretty nice.
You mentioned in your comment on eventstatus.js that after 10 seconds it should store the current status. Why wait 10 seconds to store the current status? The local event status is not going to change so why not load it up front? I think it makes for slightly cleaner code as the if statement doesn't need a null check.
After finishing going back and forth pull requests like this? Is it preferred that commits and squashed or that they are left as is?
Cheers!

The reason for waiting a total of 20 seconds before the first chance of ever reloading was to keep the code simple. That way, the template doesn't need to pack any extra information. It's less noise and less wondering by developers "what's that for?!" The little eventstatus.js plus the new JSON endpoint is all it would need.
Lastly, in your code you depend on $('.islive') which isn't a great container for the purpose of the data-status. If it was $('.eventinformation') it'd make more sense to see an attribute on it called data-status. But most importantly, this ties us to one particular state. The "live" state. Imagine a laptop without a screensaver that first clicked on an Upcoming event, then the owner of the laptop disappeared for a long lunch. During the course of the laptop owners disappearance (or perhaps he's lying in bed away from the keyboard) the event will eventually go from Upcoming to Live and then from Live to Archived. First no video, then a live stream, then an archived html5 video.
By not being tied to "live", it should work if all we care about is if the status changed from one to another.

After finishing going back and forth pull requests like this, is it preferred that commits and squashed or that they are left as is?

Well, the practice I stick to is that you wait for a formal comment that says r+. When you get that, you can rebase and squash down to 1 (or more if there are different directions within the PR) with a nice git commit message. That'll trigger one last extra Travis build (now being based on the latest master) and then I'll merge it.

You now need to also write a test for that new view function (event_status). You should be really good at finding a the right file for adding such a new test :)
You only need to write 1 test. One where you get a 404 and one where you get some JSON.

Hey @peterbe, I have made the changes you suggested.
-refactored eventstatus.js and made it depend on $(‘content-entry’) for the event-status instead of depending on $(‘islive’)
-added a test for the event_status view that tests both getting content back, and that there is a 404 if an invalid resource is requested.
Really appreciate all the feedback -  I’m learning a lot :)

Excellent! r+
Now please do the rebase and squash thing and I'll merge it.

Great! @peterbe those commits are now squashed.


v4 Date Picker (allow current year) and fixes Picker to allow selecting index 0

Short description of what this resolves:
This fixes the picker to allow selecting the first index of the column options. The existing check is an if check on a number, which is always going to return false when index is 0.
This also fixes the max year check for generating the picker items for the current year.
Ionic Version: 4.0
Fixes: #14609 #14563 #14234

The picker already has an open PR for this problem: #14479. I'd propose type checking against value comparisons.

Pleeeeeease merge this in

Thank you for the PR! The fix for being able to select the first index was added in this commit: https://github.com/ionic-team/ionic/commit/d19061c863f8558a0e597e3a5a53f1567b271b7b
And I merged your fix for the current year here: https://github.com/ionic-team/ionic/commit/f30ae889c08677860b4f8d5eda0b97f86e893eb7
This will be in the 4.0.0-beta.6 release.


Incorrect error when using generic, class and conditional typing (#43237 still exists)

Bug Report
I reported bug #43237 about a year ago. The bug is closed as fixed but it still exists current version including nightly.
🕗 Version & Regression Information
The incorrect error is introduced in version 3.9 and exists in nightly.
⏯ Playground Link
https://www.typescriptlang.org/play?ts=4.6.2&ssl=1&ssc=1&pln=9&pc=22#code/MYGwhgzhAECyCeAlApsA9gJwCbQN4ChojoAHDASwDcwAXZUgCgEo9DiBffT-USGBAMrIaAHgAqQmtGQAPOgDss-JKkxYAfK2414JegBFaYAWgCuGYMnEpg0uckXKba6AB880ANoBrZPABcEDQU8gDmALr+YPLw0OyaALzQYjZ2CkpwKujY0AD8mZLWqOquKaie4dD+yTYVANz4QA
https://www.typescriptlang.org/play?ts=4.6.2#code/MYGwhgzhAECyCeAlApsA9gJwCbQN4ChojoAHDNAF1SpxIAoBKPQ4gX33f1EhgQGVkFADwAVARWjIAHlQB2WXklSYsAPmacK8EsmgARMBTB80AVwzBkolMEkzk8xTZXQAPnmgBtANbJ4ALggKDABLWQBzAF1-MFl4aFZ1AF5oERs7OQU4JXRsaAB+bPFrVFVXNNRPSOh-VJsqgG58IA
💻 Code 1
export interface IFieldDef
{
    [name: string]: any;
}

export class Record<TRec extends IFieldDef>
{
    private a():TRec|null {
        return null;
    }
    protected b():TRec|null {
        return null;
    }
    public c() {
        return this.a();
    }
    public d() {
        return this.b();
    }
}

export class Set<TSet extends Record<IFieldDef>>
{
    public item(): TSet|null {
        return null;
    }
}

export type DS<TRec extends Record<IFieldDef> | { [key:string]:any }> = TRec extends Record<IFieldDef> ? Set<TRec> : TRec[];

💻 Code 2
class MyRecord {
    private p() {
    }
}

class MySet<TSet extends MyRecord> {
}

type DataSource<TRec extends MyRecord | { [key:string]:any }> = TRec extends MyRecord ? MySet<TRec>|TRec[] : TRec[];

🙁 Actual behavior
Error is reported
🙂 Expected behavior
No error

This is weird; it works for an ambient class but fails for a nonambient one
/*
declare class MyRecord {
    private p();
    f(): void;
}
*/
class MyRecord {
    private p() {}
    f(): void {}
}

class MySet<TSet extends MyRecord> {
    ex!: TSet;
}

type DataSource<TRec extends MyRecord | { [key:string]:any }> = TRec extends MyRecord ? MySet<TRec> | TRec[] : TRec[];

this types are the difference - since the ambient class has no method bodies and no explicit this types, the class has no associated this-type parameter, so every instance of the props is from the same declared type (and so they unify in the union+intersection in the conditional's constraint check, thus the private prop exists and matches the constraint). Meanwhile, the version-with-impls has an implicit this type parameter associated with it (since a this reference may appear in a method body that we don't know about), and so when the intersection MyRecord & {[key: string]: any} is formed, the this type of the MyRecord in that intersection changes, so the private p property gets a new symbol, making it different from the p symbol in MyRecord & MyRecord (really just MyRecord), thus meaning it doesn't unify across both union members and so doesn't exist on the union.
I've been working on #44785 recently which tracks back to the same root cause. It's looking somewhat substantial to fix, since doing so seems to require better this-instantiation for unions (so private/protected props unify across union members), and looser compatibility requirements on the symbols compared for private/protected prop tracking (namely, requiring one symbol be a clone of the other, rather than exactly the same symbol).

Meanwhile, the version-with-impls has an implicit this type parameter associated with it (since a this reference may appear in a method body that we don't know about)

Wait, if this is true it almost completely invalidates the arguments given in the past that class methods don’t have an automatic this: this for perf reasons…

No, I know that, but one of the main arguments for not doing this: this on methods automatically, IIRC, was that "it would make all classes generic" (due to the implicit type parameter for this) which would have major performance ramifications... but it seems like that's already the case based on what you've said already.


Authentication error

Environment variable is set,

I am able to connect and retrieve buckets, if auth.json file is supplied explicitly,
but there is a problem, when authenticating implicitely:

The other problem when connecting to Datastore, when authenticating implicitely:

Is there a way to connect to datastore supplying credential file explicitly?
Thank you!

These seem to be two potentially-unrelated problems, but unfortunately without very much detail in either of them. Could you open a second issue for Datastore, and keep this one to the Storage issue?
If you could then provide some more details that would be very helpful:

Am I right in saying you only get the problem when you don't have the environment variable set? (Your first sentence sounds like a statement that the environment variable is set, but I think you're trying to say "It works when it's set, it doesn't work when it's not.)
Where are you running the code when it fails? (GAE Flex? GCE? GKE? Somewhere else?)
Could you give a complete stack trace with any inner exceptions, instead of just showing the type and the message?

(Ditto for the Datastore issue.)

I will open second issue for the datastore.
When connecting to buckets, I can do that when auth.json is set explicitly (StorageClient.Create(credential))
When connecting to buckets, I can not do that when auth.json is set implicitely (StorageClient.Create()), relying on environment variable.
When connecting to datastore, I can not do that when auth.json is set implicitely (DatastoreDb.Create()), relying on environment variable.
I don't know (but want to know) how to connect to datastore explicitly.

Let's leave all talk about Datastore out of this issue, to avoid confusion.
How certain are you that your environment variable is actually correct? If you log like this:
Console.WriteLine(Environment.GetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS"));

what is displayed? What about this:
string path = Environment.GetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS");
var fullPath = Path.GetFullPath(path);
Console.WriteLine(fullPath);

I wonder whether the problem is that your value just starts with a backslash, with no drive letter - if the current working directory isn't the drive you expect, that could cause a problem.

You were completely right, despite the fact that ENV.VAR was set on the level of the system and my local user, command
Environment.GetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS");
returned null,

both cases have started to work after
Environment.SetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS", @"mypathtojson");
Though, after program restart this variable must be set again, because it answers for the env.variable of the current process.


Global byte

Anytime the byte value of a character is needed, importing (and prefixing) string is needed. This can become tedious given how often this method is needed.
import string
assert(string.byte("ABC"[1]) == 66)

↓
assert(byte("ABC"[1]) == 66)

Thanks but I am not in favor of adding byte to the global namespace. We have already bytes and this might be confusing. byte() is definitely a function that belongs to string.
You can easily achieve the same with you own code with, either at global scope or module scope:
import string
var byte = string.byte

assert(byte("ABC"[1]) == 66)

Closing since no other discussion on this topic.


Reorganize directory structure

This issue tries to collect issues related to the current directory structure.

Benchmark code in Roi.py and EspNet_E2E.py should be moved to somewhere (/benchmarks?).

Test generators in /scripts directory should be moved to somewhere (/gentests?)


doc error: pyleus submit [-n NIMBUS_HOST] [-p NIMBUS_PORT] /path/to/pyleus_topology.yaml

Submit a topology to a Storm cluster:
pyleus submit [-n NIMBUS_HOST] [-p NIMBUS_PORT] /path/to/pyleus_topology.yaml
Here is an error: not pyleus_topology.yaml, it should be a jar, please correct it

You're right. We are going to update it soon.


Target of netcore does not allow to be used in full framework...

I wanted to use your API wrapper in a full .net framework implementation.  However, because you targeted .netcore specifically, it does not allow to be used in a full environment.  Did you mean to target netstandard instead?
Is there a reason this could not run on a full .net framework (such as 4.6.x?)

Hey @joebuys, that's a good question. I'm not familiar with using netstandard, so I'm not sure if there would be a reason it couldn't run on full .net. We'll take a look into if there would be any compatibility issues with targeting that instead.
I'm not sure about the timeline to fix that though, so if you want to submit a PR with it working, that would also be helpful!

I'd be happy to help - although I have never done any NuGet package development.  So I am at a bit of a loss from where to get this building and tested.
But, from what I found in other threads, you want to change the netcore dependancy as they discuss in this thread:  https://github.com/aspnet/Home/issues/1618
By targeting NetStandard, you can allow both netcore and full netframework to use your project.

I took a look at this to see what version of .Net Standard we could use and it seems our only obstacle is the oauth-dotnetcore library. It targets .net standard 1.6 which is not supported by .net 4.6.  If we could find an alternative or see if oauth-dotnetcore could target down a few versions, I think we could target .net standard 1.4 or 1.3.

@joebuys  can you look at the most recent version? your issue should be fixed now.


Default value

Hi guys,
How can I put a default value (phone number) in the input? I can't find the solution.
Please is urgent, thanks :D

HTML:

TS:
this.updateUserFormGroup.patchValue({
userFirstName: this.user.$name,
userSurname: this.user.$surname,
userEmail: this.user.$email,
userNif: this.user.$nif,
dateOfBirth: this.user.$dateOfBirth,
userPhone: new FormControl({
value: {
phoneNumber: {
internationalNumber: '+34 666666666',
nationalNumber: '666666666',
isoCode: 'es',
dialCode: '+34'
}
}
}),
userAddress: this.user.$address,
userPostalCode: this.user.$postalCode,
userCity: this.user.$city,
});

Is everything right?

Thanks for the fast answer!


WFLY-5007 use correct access timeout and lock type in concurrency man…

…agement interceptor

Windows Build 2239 is now running using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d

Linux with security manager Build 2055 is now running using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d

Linux Build 7183 is now running using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d

Linux with security manager Build 2055 outcome was SUCCESS using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d
Summary: Tests passed: 879, ignored: 282 Build time: 0:06:20

Linux Build 7183 outcome was SUCCESS using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d
Summary: Tests passed: 2949, ignored: 354 Build time: 0:46:27

Windows Build 2239 outcome was SUCCESS using a merge of 5aa7c40cfb7cab387e6cb3c0c0bd88ed53c5013d
Summary: Tests passed: 2947, ignored: 355, muted: 1 Build time: 0:47:39


Bug - Clicking the 'x' in the Error Toast causes Job Builder to crash.

Description
If something goes wrong while saving the job, the Error Toast pops up in the corner of the page. It will disappear on its own within a couple seconds. However, if you click the 'x' to close it early, the page crashes.
Steps to Reproduce
If on (or after merging) the feature/demo/permissions branch:

Log in to the manager portal.
Manually enter the url https://talent.test/en/manager/jobs/<id>/builder/details, where id is for a job created by a 'different' manager.
Fill the page, and click save.
Click the x to close the toast error that appears.

Images

[ ] Regression test written.

Not able to reproduce locally. Clicking the x works as expected, no console errors, and I can continue to use the JPB UI.


Check the global config for notify-cmd

This brings it in line with how notify-query works and how the wiki
defines it to also be a global option.

Thank you!


Write a blog post about Content-o-Tron

Outline

It's purpose
How it can help you
How you can help
Where to find more info

Done http://blog.community.rs/content-team/2018/07/16/hello-content-o-tron.html


rsync current link target not created for empty repository

When setting up a new test environment we noticed that having a fresh repository with an empty snapshot (i.e. no ROAs) causes krill-sync to not create the rsync session directory.
As a result of this, the current symlink is created with a non-existing target and rsync breaks because it cannot chdir.
The expected behavior would be to create the session directory without any content, so that clients can "sync" the empty repository with rsync.
We observed this behavior with krill-sync 0.2.1-rc2.

Ah yes, I agree that it should create an empty directory in this case. Added to my to-do list.

Should work now, released in 0.2.1-rc3


golang master is failing to build on ppc64le

What version of Go are you using (go version)?

$ go version
Error from the master branch of golang/go

Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (go env)?
Operating System: Linux
Architecture: ppc64le
go env Output
$ go env

What did you do?
build master golang for the ppc64le architecture using make.bash

git clone https://github.com/golang/go.git
cd go/src
./make.bash
What did you expect to see?
Build successfully.
What did you see instead?
+ ./make.bash
Building Go cmd/dist using /usr/local/go. (go1.15.8 linux/ppc64le)
Building Go toolchain1 using /usr/local/go.


⚠ Bofrost.fr has degraded performance

In 407a910, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1093 ms

Resolved: Bofrost.fr performance has improved in 3136b0a.


Marking scheme design

Hello everyone,
I modified both the front end and back end to be able to choose the criteria visibility among the different users. Please have a look at it.
Regards,
Christian Garcia

@GitGeminiano I noticed that the flexible criteria "mark as complete" button bug is still there (it seems to check all criteria, rather than all ta-visible criteria.

@GitGeminiano Thanks! I made a few minor changes, which you can see in the latest commit.


Update protobufs and query strings

Closes #142

Duplicated with my PR, I forgot this PR and submit another PR to fix the compile error yesterday.
Why this PR don't merge for so long time ( almost two month) ? What are we waiting for?
@yaron2 @mchmarny


feat: better timeout errors through deadlines (prototype)

Summary
Prototype implementation of #10895, please see there for the main reasoning. This isn't supposed to be a finished implementation, or even a reasonable way to do it.
This is a partial port of this monkey patchy implementation: https://github.com/FauxFaux/jest-fixup-timeouts
Logical idea:

When a test function (including hook) starts, store the computed test deadline (now + timeout) in some accessible place
Expose this computed deadline as test.deadline(), and through expect.withinDeadline(Promise), which races it against the deadline
Add a babel plugin which converts a = await foo() into a = await expect.withinDeadline(foo()).

Deadline location / hooks
In this attempt, the deadline is hidden on the currentlyRunningTest in the global Runner State, which is where the original timeout was stored. An accessor is provided to expect and user code.
This seemed like a reasonable place, but unlike with the hack, it is not available within beforeAll/afterAll, so fails for those. This doesn't matter to the current main timeout implementation, because it has long forgotten about any "jest" concepts, and is only concerned about "running", which is probably reasonable.
I can't see anywhere else to stash it, except as an actual global, i.e. on Runner State, or in a new symbol?
babel plugin

I didn't add it to the preset. I expect most users want to run it only on their tests, not the rest of their code; not sure how that would work with a preset?

On a second look, it probably wants to rewrite await foo; as well as await foo();.

Test plan
There's an e2e test for both features which show how it's supposed to be used.
faux@astoria:~/clone/jest/e2e/babel-plugin-jest-deadlines% bash ../../jest
 FAIL  __tests__/typescript.test.ts
  ● exceeded

    deadline exceeded (waited here for 20ms)

      12 | test('exceeded', async () => {
      13 |   await sleep(10);
    > 14 |   await sleep(200);
         |   ^
      15 | }, 50);
      16 |

      at Object.<anonymous> (__tests__/typescript.test.ts:14:3)

 FAIL  __tests__/plain.test.js
  ● exceeded

    deadline exceeded (waited here for 20ms)

      11 | test('exceeded', async () => {
      12 |   await sleep(10);
    > 13 |   await sleep(200);
         |   ^
      14 | }, 50);
      15 |

      at Object.<anonymous> (__tests__/plain.test.js:13:3)

Test Suites: 2 failed, 2 total
Tests:       2 failed, 2 total
Snapshots:   0 total
Time:        0.447 s, estimated 1 s
Ran all test suites.

I wouldn't expect it to add significant overhead to regular tests.
In the happy path case, you're doing an extra setTimeout, clearTimeout and Promise.race.
For the unhappy path, something has already gone wrong, probably in the "seconds" dimension.
For the type of test I imagine writing ("call this webservice, call that webservice, write this db record, read that db record, assert"), none of those things is even close to showing up on a profiling report, and there's only four of them.
If you were to use the plugin to rewrite all of your code, instead of just your tests, then maybe you'll end up with a performance sensitive await inside a performance sensitive loop?
On the other hand, I'm sure there are people writing tests which are actually sub-second in all cases.

Outstanding issues I'd like help with:

where to stash the deadline, so it works in beforeAll, just directly on the runner state as currentlyRunningHookOrTestsDeadline?
are we exposing the deadline to users, and where from?
can anything inside circus be tested, except as e2e? Many of the other circus tests are quite e2e anyway, just with a custom event listener.
does the babel plugin need to be pedantic about @jest/globals' expect?

Things I would like to look at when I've had more sleep, but aren't critical blockers for merging this / some of this / something like this:

what is a babel preset and what settings could it expose
what would it look like to handle expect().resolves (including as a promise chain)
what would an implementation that handles promises in general look like
what is the other PR doing and what can we share

The test failures with negative times raise an interesting point.

Should withinDeadline throw immediately if the deadline is exceeded (probably yes)?
Did I mess up, or is CI really taking 90ms to do a 10ms sleep? I didn't think timer slop was that bad on non-Windows.

Also, sometimes the stack trace is absent (only on node 10?). Maybe the async construction is too complex, or this is not plausible on node 10? I personally don't care about node 10, and it's not harmful. Node 10 is in maintenance until Apr 2021.


Add README tags

Slack
CI/CD (build, tests)
Dockerhub
Helm
License
Code coverage
Version
Downloads

I'm working in it


Zoo Animals API response time

Thanks for looking to open an issue for this project.
If you are opening an issue to suggest adding a new entry, please consider opening a pull request instead!
Thank you for the free APIs. I was using the Zoo Animals API and I noticed that the response time is too slow.
Please would you consider looking into that?

Hi @Trend20
We are not Zoo Animal API maintainers. 😅
I suggest you contact the maintainer and let them know what issues you are having: https://zoo-animal-api.herokuapp.com/contact
But I also did some tests here and it is working correctly. Maybe you started the heroku server from this API and ended up noticing this delay. Free heroku servers sleep when not being used, so you have to wait a few minutes for everything to work properly.


chore: undeprecate some result selectors

Description:
As outlined in #5824, this PR undeprecates the result selectors for:

bindCallback
bindNodeCallback
combineLatest
forkJoin
fromEvent
fromEventPattern
zip

In addition to the reasons given in that issue for the undeprecation, there is another in this comment that applies to bindCallback, bindNodeCallback, fromEvent and fromEventPattern.
AFAICT, the docs that related to these deprecations have already been removed/updated to reflect said undeprecation. Anyway, the docs, etc. is what I'm looking at right now.
Related issue (if exists): #5824

@cartant there are conflicts after your other PR... please resolve, then feel free to squash and merge.


Does this work for React Native Expo?

Im using react native expo and im getting this issue:
[Unhandled promise rejection: TypeError: null is not an object (evaluating 'TrackingTransparency.requestTrackingPermission')]

Any idea on how to fix it?

yes, eject from expo managed. This is a native module

Does this work on the simulator? because in the simulator the requestTrackingPermission() dose not work


How to handle back navigation in tabNavigator

When i back from any other tab it's move to primary tab and then back from application
Example video of what is my actual requirement
https://github.com/adrielcafe/voyager/assets/131661149/4d54a8df-b9ab-475b-acca-f78380b45db7

Add a BackHandler that activates when the Navigator only has 1 screen
BackHandler(navigator.items.size == 1) {
    // navigate to home tab
}

Add a BackHandler that activates when the Navigator only has 1 screen
BackHandler(navigator.items.size == 1) {
    // navigate to home tab
}

Unresolved reference: BackHandler

If you are using a common sourceset you might need to expect/actual the BackHandler from Androidx Activity Compose

If you are using a common sourceset you might need to expect/actual the BackHandler from Androidx Activity Compose

how to move from last tab to first tab on button click of last tab?


feat(eigen-client-extra-features): Verifier

What ❔
This PR implements verifier for EigenDA
Since config was changed, recompile zkstack:
cargo install --path zkstack_cli/crates/zkstack --force --locked

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zkstack dev fmt and zkstack dev lint.

Add docs

Done


Expiration Time modification

I saved an alert with a specific expiration time but those new alerts do not start from this "default", can expiration time be modified? I dun mind edit them once every 2 months

Hi @mlake, great WORK ! thanks !
As @ChernKiat i want to change the default Expiration Time which is too close.
Any idea ?
Looks like the interface is not implemented. Too complex ?
https://github.com/alleyway/add-tradingview-alerts-tool/blob/6cb31f0c0d9820fdee3fef3b926b03f65099cbf7/src/interfaces.ts
Regards.

It would be a great feature


Feature Request: Improve Sprite artwork workflow 2

I have a Unity 6 project with this setup...

manifest.json
ProjectVersion.txt

... and I pulled ...

https://github.com/Antoshidza/NSprites-Foundation
https://github.com/Antoshidza/NSprites

... into my project with success. Great work!
PROBLEM:
I notice that the length of FrameDurations on the SpriteAnimation object must match the number of sprites resulting from the FrameCount values of the SpriteAnimation object.
This is manageable to manually keep in sync.
WORKAROUND:
One solution would be to support the current workflow AND support having exactly one value (and perhaps a boolean of 'UseSameDuration=true') for the FrameDurations on the SpriteAnimation object. The system would reuse that one value across all frames, which by the way is probably the primary use case.
RESULTING CONSOLE LOG
System.IndexOutOfRangeException: Index 6 is out of range Length 6
This Exception was thrown from a job compiled with Burst, which has limited exception support.
0x00007ffd7665e45e (Unity) burst_abort
0x00007ffe4049cf8e (431ef944cf951df94a332f6244d0509) burst_Abort_Trampoline
0x00007ffe40496850 (431ef944cf951df94a332f6244d0509) NSprites.SpriteUVAnimationSystem.AnimationJob.Execute (at D:/Documents/Projects/VC/Unity/rmc-dots-jam-3/Unity/Library/PackageCache/com.unity.burst/.Runtime/Library/PackageCache/com.tonymax.nsprites.foundation/Animation/Systems/SpriteUVAnimationSystem.cs:54)
0x00007ffe40496c1e (431ef944cf951df94a332f6244d0509) NSprites.SpriteUVAnimationSystem.AnimationJob.Execute
0x00007ffe404981f5 (431ef944cf951df94a332f6244d0509) Unity.Entities.JobChunkExtensions.JobChunkProducer`1<NSprites.SpriteUVAnimationSystem.AnimationJob>.ExecuteInternal (at D:/Documents/Projects/VC/Unity/rmc-dots-jam-3/Unity/Library/PackageCache/com.unity.burst/.Runtime/Library/PackageCache/com.unity.entities/Unity.Entities/IJobChunk.cs:399)
0x00007ffe4049615d (431ef944cf951df94a332f6244d0509) 0d096840f301b26d659e152fbeb56796
0x00007ffd7665ab35 (Unity) ExecuteJob
0x00007ffd7665ae5e (Unity) ExecuteJobCopyData
0x00007ffd766580b6 (Unity) ujob_execute_job
0x00007ffd7665728f (Unity) lane_guts
0x00007ffd76659e84 (Unity) worker_thread_routine
0x00007ffd7684d73d (Unity) Thread::RunThreadWrapper
0x00007ffe9a41257d (KERNEL32) BaseThreadInitThunk
0x00007ffe9b60aa48 (ntdll) RtlUserThreadStart

In my opinion such bool things looks ugly without better inspector which should hide array if UseSameDuration == true and show single input field instead, still under the hood having same array of durations as long as those SOs are just authoring in-editor only data.
As I mentioned in other issues I've implemented NSprites-Foundation as minimal example of how NSprites could be used. Though I was thinking about to do what you suggest to do numerous of times, so I will do this eventually, after more important changes I have plans to do.


from myGpuFeatures import myGpuFeatures

ImportError: DLL load failed: 找不到指定的模块。
Could you upload myGpuFeatures.py file? Thanks

How to solve this problem? Thanks

Please unzip my GPU features. rar in your windows system

Yes, I unziped "my GPU features. rar" in my win10 system,but it does't work. The CUDA version is 9.
I used the anaconda3 to manage the software. The install software is followed:
python             3.6.12
certifi               2020.12.5
cycler                0.10.0
decorator             4.4.2
imageio               2.9.0
install               1.3.4
kiwisolver            1.3.1
llvmlite              0.36.0
matplotlib            3.3.4
networkx              2.5.1
numba                 0.53.1
numpy                 1.19.5
opencv-contrib-python <IP_ADDRESS>
opencv-python         <IP_ADDRESS>
Pillow                8.2.0
pip                   21.1.1
pyparsing             2.4.7
python-dateutil       2.8.1
PyWavelets            1.1.1
scikit-image          0.17.2
scipy                 1.5.4
setuptools            52.0.0.post20210125
six                   1.16.0
tifffile              2020.9.3
wheel                 0.36.2
wincertstore          0.2

I have update requirements.txt，it can work on my computer

If it helps you, please star this repo and sponsor to me if you like

@nxm19830306
you can revise ImageUtility.py "from myGpuFeatures import myGpuFeatures" to "import myGpuFeature" and only sift mthod is available on GPU.

 This problem is fixed, thanks.
------------------ 原始邮件 ------------------
发件人: "Keep-Passion/ImageStitch" @.>;
发送时间: 2021年6月9日(星期三) 中午12:03
@.>;
<EMAIL_ADDRESS>主题: Re: [Keep-Passion/ImageStitch] from myGpuFeatures import myGpuFeatures (#9)
@nxm19830306
you can revise ImageUtility.py "from myGpuFeatures import myGpuFeatures" to "import myGpuFeature" and only sift mthod is available on GPU.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Lfoppiano refactor utilities methods 040816

Coverage decreased (-0.08%) to 38.909% when pulling 3b51cf15a6cd17c9c6d386057ab7847d877cf3d1 on lfoppiano_refactor_utilities_Methods-040816 into fe24ab5191442f3f5b257a39d26372683146989e on master.


Windows: DNS via netbird Peer.

Describe the problem
When you create split DNS in the management control panel and set the DNS server to a netbird Peer IP windows clients do not seem to be able to resolve any DNS in the split domain.
Additionally, if you add a second DNS server using the Peers LAN IP and then add a route it seems to just crash the netbird service on Windows.
Using just the LAN interface IP (e.g <IP_ADDRESS>) and adding a route works, the problems only manifest if you try and use a netbird peer IP as the DNS server you send to the netbird clients.
For instance create a DNS entry in the netbird UI to match internal.mydomain.com
Run a DNS server on netbird peer <IP_ADDRESS> (I used a PDNS-Recursor container and set it up so that internal.mydomain was an authoritative zone)
Set DNS to <IP_ADDRESS> for this split domain.
Ensure ACL allows traffic
Linux clients would work as expected, sending queries for internal.mydomain.com to the PDNS-recursor and getting the approprate reply.
I could not get any useful logs from netbird when the service crashed.

Hello @dragon2611 is this issue fixed with the latest 0.21.10 version?

I think upgrading from 0.21.8 to 0.21.9 fixed it (Or at least it was no longer crashing after updating and DNS appeared to be working as expected)