Possible uvx ptipython bug

Hi, I read the sticky for new issues (#9452) and could not determine if this issue somehow exists somewhere else, but it looks like not. It could be related to build systems or packaging, but I don't know enough about that and figured this report might shed light on some edge cases. Apologies if it's somehow a duplicate.
The issue is when running uvx ptipython, which works but emits a warning, and consequently running the command from the warning uvx --from ptpython ptipython, which does not work. See below for details.
Versions
~
» uv --version
uv 0.5.13 (c456bae5e 2024-12-27)

~
» sw_vers
ProductName:            macOS
ProductVersion:         15.1.1
BuildVersion:           24B91

Commands
# this worked
~ took 14s
» uvx ptipython
Installed 18 packages in 65ms
warning: An executable named `ptipython` is not provided by package `ptipython` but is available via the dependency `ptpython`. Consider using `uvx --from ptpython ptipython` instead.
Python 3.13.1 (main, Dec 19 2024, 14:22:59) [Clang 18.1.8 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.31.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]:

# this did NOT work
~ took 18s
» uvx --from ptpython ptipython
Installed 7 packages in 26ms
IPython not found. Please install IPython (pip install ipython).

Verbose Commands
~
» uvx --verbose ptipython
DEBUG uv 0.5.13 (c456bae5e 2024-12-27)
DEBUG Searching for default Python interpreter in managed installations or search path
DEBUG Searching for managed installations at `.local/share/uv/python`
DEBUG Found managed installation `cpython-3.13.1-macos-aarch64-none`
DEBUG Found `cpython-3.13.1-macos-aarch64-none` at `/Users/dimitar/.local/share/uv/python/cpython-3.13.1-macos-aarch64-none/bin/python3.13` (managed installations)
DEBUG Acquired lock for `.local/share/uv/tools`
DEBUG Released lock at `/Users/dimitar/.local/share/uv/tools/.lock`
DEBUG Caching via interpreter: `/Users/dimitar/.local/share/uv/python/cpython-3.13.1-macos-aarch64-none/bin/python3.13`
DEBUG Using request timeout of 30s
DEBUG Solving with installed Python version: 3.13.1
DEBUG Solving with target Python version: >=3.13.1
DEBUG Adding direct dependency: ptipython*
DEBUG Found fresh response for: https://pypi.org/simple/ptipython/
DEBUG Searching for a compatible version of ptipython (*)
DEBUG Selecting: ptipython==1.0.1 [compatible] (ptipython-1.0.1-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/0d/80/6aa1e8d90a64d05ee61d2ab8941df9c61802c4f312c468da5383b7da33ec/ptipython-1.0.1-py2.py3-none-any.whl.metadata
DEBUG Adding transitive dependency for ptipython==1.0.1: ipython{python_full_version >= '3.5'}*
DEBUG Adding transitive dependency for ptipython==1.0.1: ptpython{python_full_version >= '3.5'}*
DEBUG Found fresh response for: https://pypi.org/simple/ptpython/
DEBUG Found fresh response for: https://pypi.org/simple/ipython/
DEBUG Searching for a compatible version of ipython{python_full_version >= '3.5'} (*)
DEBUG Selecting: ipython==8.31.0 [compatible] (ipython-8.31.0-py3-none-any.whl)
DEBUG Adding transitive dependency for ipython==8.31.0: ipython==8.31.0
DEBUG Adding transitive dependency for ipython==8.31.0: ipython{python_full_version >= '3.5'}==8.31.0
DEBUG Searching for a compatible version of ipython{python_full_version >= '3.5'} (==8.31.0)
DEBUG Selecting: ipython==8.31.0 [compatible] (ipython-8.31.0-py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/04/60/d0feb6b6d9fe4ab89fe8fe5b47cbf6cd936bfd9f1e7ffa9d0015425aeed6/ipython-8.31.0-py3-none-any.whl.metadata
DEBUG Adding transitive dependency for ipython==8.31.0: decorator*                                                                               DEBUG Adding transitive dependency for ipython==8.31.0: jedi>=0.16
DEBUG Adding transitive dependency for ipython==8.31.0: matplotlib-inline*
DEBUG Adding transitive dependency for ipython==8.31.0: pexpect{sys_platform != 'emscripten' and sys_platform != 'win32'}>4.3
DEBUG Adding transitive dependency for ipython==8.31.0: prompt-toolkit>=3.0.41, <3.1.0
DEBUG Adding transitive dependency for ipython==8.31.0: pygments>=2.4.0
DEBUG Adding transitive dependency for ipython==8.31.0: stack-data*
DEBUG Adding transitive dependency for ipython==8.31.0: traitlets>=5.13.0
DEBUG Searching for a compatible version of ipython (==8.31.0)
DEBUG Selecting: ipython==8.31.0 [compatible] (ipython-8.31.0-py3-none-any.whl)
DEBUG Adding transitive dependency for ipython==8.31.0: decorator*
DEBUG Adding transitive dependency for ipython==8.31.0: jedi>=0.16                                                                               DEBUG Adding transitive dependency for ipython==8.31.0: matplotlib-inline*                                                                       DEBUG Adding transitive dependency for ipython==8.31.0: pexpect{sys_platform != 'emscripten' and sys_platform != 'win32'}>4.3
DEBUG Adding transitive dependency for ipython==8.31.0: prompt-toolkit>=3.0.41, <3.1.0
DEBUG Adding transitive dependency for ipython==8.31.0: pygments>=2.4.0
DEBUG Adding transitive dependency for ipython==8.31.0: stack-data*
DEBUG Adding transitive dependency for ipython==8.31.0: traitlets>=5.13.0
DEBUG Searching for a compatible version of ptpython{python_full_version >= '3.5'} (*)
DEBUG Selecting: ptpython==3.0.29 [compatible] (ptpython-3.0.29-py2.py3-none-any.whl)
DEBUG Adding transitive dependency for ptpython==3.0.29: ptpython==3.0.29
DEBUG Adding transitive dependency for ptpython==3.0.29: ptpython{python_full_version >= '3.5'}==3.0.29
DEBUG Searching for a compatible version of ptpython{python_full_version >= '3.5'} (==3.0.29)
DEBUG Selecting: ptpython==3.0.29 [compatible] (ptpython-3.0.29-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/matplotlib-inline/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/0f/39/c6fd4dd531e067b6a01624126cff0b3ddc6569e22f83e48d8418ffa9e3be/ptpython-3.0.29-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/pexpect/
DEBUG Adding transitive dependency for ptpython==3.0.29: appdirs*
DEBUG Adding transitive dependency for ptpython==3.0.29: jedi>=0.16.0
DEBUG Adding transitive dependency for ptpython==3.0.29: prompt-toolkit>=3.0.43, <3.1.0
DEBUG Adding transitive dependency for ptpython==3.0.29: pygments*                                                                               DEBUG Searching for a compatible version of ptpython (==3.0.29)
DEBUG Selecting: ptpython==3.0.29 [compatible] (ptpython-3.0.29-py2.py3-none-any.whl)
DEBUG Adding transitive dependency for ptpython==3.0.29: appdirs*
DEBUG Adding transitive dependency for ptpython==3.0.29: jedi>=0.16.0
DEBUG Adding transitive dependency for ptpython==3.0.29: prompt-toolkit>=3.0.43, <3.1.0
DEBUG Adding transitive dependency for ptpython==3.0.29: pygments*                                                                               DEBUG Found fresh response for: https://pypi.org/simple/decorator/
DEBUG Searching for a compatible version of decorator (*)
DEBUG Selecting: decorator==5.1.1 [compatible] (decorator-5.1.1-py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/8f/8e/9ad090d3553c280a8060fbf6e24dc1c0c29704ee7d1c372f0c174aa59285/matplotlib_inline-0.1.7-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/d5/50/83c593b07763e1161326b3b8c6686f0f4b0f24d5526546bee538c89837d6/decorator-5.1.1-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/stack-data/
DEBUG Found fresh response for: https://pypi.org/simple/appdirs/
DEBUG Found fresh response for: https://pypi.org/simple/jedi/                                                                                DEBUG Found fresh response for: https://pypi.org/simple/prompt-toolkit/
DEBUG Searching for a compatible version of jedi (>=0.16)
DEBUG Selecting: jedi==0.19.2 [compatible] (jedi-0.19.2-py2.py3-none-any.whl)                                                                    DEBUG Found fresh response for: https://pypi.org/simple/pygments/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/f1/7b/ce1eafaf1a76852e2ec9b22edecf1daa58175c090266e9f6c64afcd81d91/stack_data-0.6.3-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/traitlets/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/3b/00/2344469e2084fb287c2e0b57b72910309874c3245463acd6cf5e3db69324/appdirs-1.4.4-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/a9/6a/fd08d94654f7e67c52ca30523a178b3f8ccc4237fce4be90d39c938a831a/prompt_toolkit-3.0.48-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/f7/3f/01c8b82017c199075f8f788d0d906b9ffbbc5a47dc9918a945e13d5a2bda/pygments-2.18.0-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/c0/5a/9cac0c82afec3d09ccd97c8b6502d48f165f9124db81b4bcb90b4af974ee/jedi-0.19.2-py2.py3-none-any.whl.metadata
DEBUG Adding transitive dependency for jedi==0.19.2: parso>=0.8.4, <0.9.0                                                                        DEBUG Searching for a compatible version of matplotlib-inline (*)
DEBUG Selecting: matplotlib-inline==0.1.7 [compatible] (matplotlib_inline-0.1.7-py3-none-any.whl)
DEBUG Adding transitive dependency for matplotlib-inline==0.1.7: traitlets*
DEBUG Searching for a compatible version of pexpect{sys_platform != 'emscripten' and sys_platform != 'win32'} (>4.3)                             DEBUG Selecting: pexpect==4.9.0 [compatible] (pexpect-4.9.0-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/00/c0/8f5d070730d7836adc9c9b6408dec68c6ced86b304a9b26a14df072a6e8c/traitlets-5.14.3-py3-none-any.whl.metadata                                                                                DEBUG Adding transitive dependency for pexpect==4.9.0: pexpect==4.9.0
DEBUG Adding transitive dependency for pexpect==4.9.0: pexpect{sys_platform != 'emscripten' and sys_platform != 'win32'}==4.9.0
DEBUG Searching for a compatible version of pexpect{sys_platform != 'emscripten' and sys_platform != 'win32'} (==4.9.0)                          DEBUG Selecting: pexpect==4.9.0 [compatible] (pexpect-4.9.0-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/parso/                                                                                DEBUG Found fresh response for: https://files.pythonhosted.org/packages/9e/c3/059298687310d527a58bb01f3b1965787ee3b40dce76752eda8b44e9a2c5/pexpect-4.9.0-py2.py3-none-any.whl.metadata
DEBUG Adding transitive dependency for pexpect==4.9.0: ptyprocess>=0.5
DEBUG Searching for a compatible version of pexpect (==4.9.0)
DEBUG Selecting: pexpect==4.9.0 [compatible] (pexpect-4.9.0-py2.py3-none-any.whl)
DEBUG Adding transitive dependency for pexpect==4.9.0: ptyprocess>=0.5
DEBUG Searching for a compatible version of prompt-toolkit (>=3.0.43, <3.1.0)
DEBUG Selecting: prompt-toolkit==3.0.48 [compatible] (prompt_toolkit-3.0.48-py3-none-any.whl)
DEBUG Adding transitive dependency for prompt-toolkit==3.0.48: wcwidth*
DEBUG Searching for a compatible version of pygments (>=2.4.0)
DEBUG Selecting: pygments==2.18.0 [compatible] (pygments-2.18.0-py3-none-any.whl)
DEBUG Searching for a compatible version of stack-data (*)                                                                                DEBUG Selecting: stack-data==0.6.3 [compatible] (stack_data-0.6.3-py3-none-any.whl)
DEBUG Adding transitive dependency for stack-data==0.6.3: executing>=1.2.0
DEBUG Adding transitive dependency for stack-data==0.6.3: asttokens>=2.1.0                                                                       DEBUG Adding transitive dependency for stack-data==0.6.3: pure-eval*
DEBUG Searching for a compatible version of traitlets (>=5.13.0)
DEBUG Selecting: traitlets==5.14.3 [compatible] (traitlets-5.14.3-py3-none-any.whl)
DEBUG Searching for a compatible version of appdirs (*)
DEBUG Selecting: appdirs==1.4.4 [compatible] (appdirs-1.4.4-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/c6/ac/dac4a63f978e4dcb3c6d3a78c4d8e0192a113d288502a1216950c41b1027/parso-0.8.4-py2.py3-none-any.whl.metadata
DEBUG Searching for a compatible version of parso (>=0.8.4, <0.9.0)
DEBUG Selecting: parso==0.8.4 [compatible] (parso-0.8.4-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/ptyprocess/
DEBUG Searching for a compatible version of ptyprocess (>=0.5)
DEBUG Selecting: ptyprocess==0.7.0 [compatible] (ptyprocess-0.7.0-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/pure-eval/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/22/a6/858897256d0deac81a172289110f31629fc4cee19b6f01283303e18c8db3/ptyprocess-0.7.0-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/8e/37/efad0257dc6e593a18957422533ff0f87ede7c9c6ea010a2177d738fb82f/pure_eval-0.2.3-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/asttokens/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/25/8a/c46dcc25341b5bce5472c718902eb3d38600a903b14fa6aeecef3f21a46f/asttokens-3.0.0-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/wcwidth/
DEBUG Searching for a compatible version of wcwidth (*)                                                                                DEBUG Selecting: wcwidth==0.2.13 [compatible] (wcwidth-0.2.13-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/executing/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/fd/84/fd2ba7aafacbad3c4201d395674fc6348826569da3c0937e75505ead3528/wcwidth-0.2.13-py2.py3-none-any.whl.metadata
DEBUG Searching for a compatible version of executing (>=1.2.0)
DEBUG Selecting: executing==2.1.0 [compatible] (executing-2.1.0-py2.py3-none-any.whl)                                                            DEBUG Found fresh response for: https://files.pythonhosted.org/packages/b5/fd/afcd0496feca3276f509df3dbd5dae726fcc756f1a08d9e25abe1733f962/executing-2.1.0-py2.py3-none-any.whl.metadata
DEBUG Searching for a compatible version of asttokens (>=2.1.0)                                                                                DEBUG Selecting: asttokens==3.0.0 [compatible] (asttokens-3.0.0-py3-none-any.whl)
DEBUG Searching for a compatible version of pure-eval (*)                                                                                DEBUG Selecting: pure-eval==0.2.3 [compatible] (pure_eval-0.2.3-py3-none-any.whl)
DEBUG Tried 18 versions: appdirs 1, asttokens 1, decorator 1, executing 1, ipython 1, jedi 1, matplotlib-inline 1, parso 1, pexpect 1, prompt-toolkit 1, ptipython 1, ptpython 1, ptyprocess 1, pure-eval 1, pygments 1, stack-data 1, traitlets 1, wcwidth 1
DEBUG marker environment resolution took 0.011s
Resolved 18 packages in 11ms
DEBUG Running `ptipython`                                                                                DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/appdirs-1.4.4.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/asttokens-3.0.0.dist-info              DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/decorator-5.1.1.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/executing-2.1.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/ipython-8.31.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/jedi-0.19.2.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/matplotlib_inline-0.1.7.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/parso-0.8.4.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/pexpect-4.9.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/prompt_toolkit-3.0.48.dist-info        DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/ptipython-1.0.1.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/ptpython-3.0.29.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/ptyprocess-0.7.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/pure_eval-0.2.3.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/pygments-2.18.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/stack_data-0.6.3.dist-info             DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/traitlets-5.14.3.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/Ob3hSZJB0bcgTU7h7ZEJp/lib/python3.13/site-packages/wcwidth-0.2.13.dist-info
warning: An executable named `ptipython` is not provided by package `ptipython` but is available via the dependency `ptpython`. Consider using `uvx --from ptpython ptipython` instead.
Python 3.13.1 (main, Dec 19 2024, 14:22:59) [Clang 18.1.8 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.31.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]:

DEBUG Command exited with code: 0

~ took 26s
» uvx --verbose --from ptpython ptipython
DEBUG uv 0.5.13 (c456bae5e 2024-12-27)
DEBUG Searching for default Python interpreter in managed installations or search path
DEBUG Searching for managed installations at `.local/share/uv/python`
DEBUG Found managed installation `cpython-3.13.1-macos-aarch64-none`                                                                             DEBUG Found `cpython-3.13.1-macos-aarch64-none` at `/Users/dimitar/.local/share/uv/python/cpython-3.13.1-macos-aarch64-none/bin/python3.13` (managed installations)
DEBUG Acquired lock for `.local/share/uv/tools`
DEBUG Released lock at `/Users/dimitar/.local/share/uv/tools/.lock`
DEBUG Caching via interpreter: `/Users/dimitar/.local/share/uv/python/cpython-3.13.1-macos-aarch64-none/bin/python3.13`
DEBUG Using request timeout of 30s
DEBUG Solving with installed Python version: 3.13.1
DEBUG Solving with target Python version: >=3.13.1
DEBUG Adding direct dependency: ptpython*
DEBUG Found fresh response for: https://pypi.org/simple/ptpython/
DEBUG Searching for a compatible version of ptpython (*)
DEBUG Selecting: ptpython==3.0.29 [compatible] (ptpython-3.0.29-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/0f/39/c6fd4dd531e067b6a01624126cff0b3ddc6569e22f83e48d8418ffa9e3be/ptpython-3.0.29-py2.py3-none-any.whl.metadata
DEBUG Adding transitive dependency for ptpython==3.0.29: appdirs*
DEBUG Adding transitive dependency for ptpython==3.0.29: jedi>=0.16.0
DEBUG Adding transitive dependency for ptpython==3.0.29: prompt-toolkit>=3.0.43, <3.1.0
DEBUG Adding transitive dependency for ptpython==3.0.29: pygments*
DEBUG Found fresh response for: https://pypi.org/simple/appdirs/
DEBUG Searching for a compatible version of appdirs (*)
DEBUG Selecting: appdirs==1.4.4 [compatible] (appdirs-1.4.4-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/pygments/
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/3b/00/2344469e2084fb287c2e0b57b72910309874c3245463acd6cf5e3db69324/appdirs-1.4.4-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://pypi.org/simple/prompt-toolkit/
DEBUG Found fresh response for: https://pypi.org/simple/jedi/
DEBUG Searching for a compatible version of jedi (>=0.16.0)
DEBUG Selecting: jedi==0.19.2 [compatible] (jedi-0.19.2-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/f7/3f/01c8b82017c199075f8f788d0d906b9ffbbc5a47dc9918a945e13d5a2bda/pygments-2.18.0-py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/c0/5a/9cac0c82afec3d09ccd97c8b6502d48f165f9124db81b4bcb90b4af974ee/jedi-0.19.2-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/a9/6a/fd08d94654f7e67c52ca30523a178b3f8ccc4237fce4be90d39c938a831a/prompt_toolkit-3.0.48-py3-none-any.whl.metadata
DEBUG Adding transitive dependency for jedi==0.19.2: parso>=0.8.4, <0.9.0
DEBUG Searching for a compatible version of prompt-toolkit (>=3.0.43, <3.1.0)
DEBUG Selecting: prompt-toolkit==3.0.48 [compatible] (prompt_toolkit-3.0.48-py3-none-any.whl)
DEBUG Adding transitive dependency for prompt-toolkit==3.0.48: wcwidth*
DEBUG Searching for a compatible version of pygments (*)
DEBUG Selecting: pygments==2.18.0 [compatible] (pygments-2.18.0-py3-none-any.whl)
DEBUG Found fresh response for: https://pypi.org/simple/wcwidth/
DEBUG Found fresh response for: https://pypi.org/simple/parso/
DEBUG Searching for a compatible version of parso (>=0.8.4, <0.9.0)
DEBUG Selecting: parso==0.8.4 [compatible] (parso-0.8.4-py2.py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/fd/84/fd2ba7aafacbad3c4201d395674fc6348826569da3c0937e75505ead3528/wcwidth-0.2.13-py2.py3-none-any.whl.metadata
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/c6/ac/dac4a63f978e4dcb3c6d3a78c4d8e0192a113d288502a1216950c41b1027/parso-0.8.4-py2.py3-none-any.whl.metadata
DEBUG Searching for a compatible version of wcwidth (*)
DEBUG Selecting: wcwidth==0.2.13 [compatible] (wcwidth-0.2.13-py2.py3-none-any.whl)
DEBUG Tried 7 versions: appdirs 1, jedi 1, parso 1, prompt-toolkit 1, ptpython 1, pygments 1, wcwidth 1
DEBUG marker environment resolution took 0.003s
Resolved 7 packages in 3ms
DEBUG Running `ptipython`
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/appdirs-1.4.4.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/jedi-0.19.2.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/parso-0.8.4.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/prompt_toolkit-3.0.48.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/ptpython-3.0.29.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/pygments-2.18.0.dist-info
DEBUG Looking at `.dist-info` at: .cache/uv/archive-v0/h2JbCzjMpKH7Z-MrIImSU/lib/python3.13/site-packages/wcwidth-0.2.13.dist-info
IPython not found. Please install IPython (pip install ipython).
DEBUG Command exited with code: 1

Link to ptpython project: https://github.com/prompt-toolkit/ptpython

Hi!
The warning is to indicate that that the command you're running does not come from the installed package. In this case, it's not a big deal because that's the intent of the ptipython meta-package. In general, it's not common for a package (in this case, ptpython) to contain a command (ptipython) that cannot actually be used. Ideally they'd provide an extra that includes ipython instead of using a meta package like this.
An invocation that does not warn would be uvx --from ptpython --with ipython ptipython
Unfortunately I can't think of a way for us to improve this without encoding knowledge of specific packages.

Thanks for the super quick response! To be clear, the warning does not bother me, but I found the behavior is a bit odd.

Unfortunately I can't think of a way for us to improve this without encoding knowledge of specific packages.

That's more than fair, and I did consider that this could be more an issue with ptpython itself, but in case it wasn't, figured worth letting you know. Thanks for taking a look.

Maybe one thing we could do is skip the warning if the package name matches the command name. It seems pretty niche, but perhaps there are more cases like this that haven't been reported.


Restore: PostgreSQL

Restore for one node configuration is already implemented.
Workin on configuration with two-nodes and repmgr.

@plirglo tested restore scenario: single node PostgreSQL, 2 nodes PostgreSQL done, works for me

Tested restore scenario: single node PostgreSQL, clustered nodes PostgreSQL; on Ubuntu and RedHat.


Improvement: Adding multiple folders for user, like multiple home folders

Hello,
I have my home users for who I want to provide permission for different folder instead of showing them all the folders.
Can this be done? may be allowing to provide more than one home folder option.
Regards,
Zak

Hi,
No, this is not possible at the moment, see #33


Issue with the build process in Arch/Manjaro, and possibly other distros

I use Manjaro x64 and there is an issue while building Sfizz from source.  The terminal shows several warnings in the process, and in the step 73 of the build operation, while dealing with the plugins, it just stops. The issue is solved by switching to Clang beforehand, so I'll transcribe here the solution for other users who may need it.
1) You go to :
https://github.com/sfztools/sfizz-ui/releases
and download sfizz-1.2.2.tar.gz (or whatever version you need)
2) Extract the tar.gz file
You enter the directory of the extracted content and open a terminal right there (in Thunar or Nemo, right click and choose "Terminal" or "Open in terminal")
3) The usual method could be normally achieved by copying and pasting these instructions in the terminal (Ctrl-Shift+V inside the terminal) :
mkdir build && cd build && cmake .. && make && sudo make install
This is, in other words, the process described in the Build section of the Sfizz homepage. BUT, after a while in the process it could happen that, reaching a certain point, things get messed up. So, when you try it again you add these lines to switch to Clang (another compiler to build) :
export CC=/usr/bin/clang
export CXX=/usr/bin/clang++
mkdir build && cd build && cmake .. && make && sudo make install
A side note : Manjaro, at least, has the clang and compiler-rt packages already installed. Those are the requisites for switching to Clang. If you have any problem while trying this procedure, check that they are installed in your system.
That did it for @vertfin, who kindly told me about it, and me . I don't know if it is a universal solution for the build issue, but it worked here in Manjaro. If any of the devs need further information, I can repeat the process in another machine to copy the warning messages.
I'd suggest to include binaries for Linux in all releases (including the previous ones). It's quite strange that there are indeed binaries for Windows and Mac, but not for Linux. I know that experienced Linux users prefer to build things from source, but for the end user this can be quite problematic. Most build tutorials take way too many things for granted, and when an issue occurs as in this case, you don ´t have any other choice.
Apart from this, thanks so much for the instrument. It's excellent in many ways...

Our dependency on VSTGUI makes it a bit of a nightmare to compile a universal binary for Linux. Long story short, we depend on a slurry of graphic- and input-related libraries to build the GUI for Linux. It's quite impractical to statically build all those libraries in a "universal" binary, and is actually frowned upon by packagers in distros (see #135 for a more recent example but this is always an ongoing problem).
Our solution at the time was to depend on OBS to populate packages for distros, however this comes at a cost. Even when I had time to spare for sfizz, packaging is time-demanding, especially if you're maintaining packages across the Linux landscape. So things tend to degrade and rot over time, sadly.
I'll try to find some time to improve and update OBS for later distros, update the build information so that it's easier, and see if I can enable older packages on OBS somehow.

I think this is a duplicate of #139, in which case both issues would be fixed by merging this PR in sfztools/vstgui and updating the corresponding submodule in sfizz-ui.
The root cause is an unused but invalid line of code in VSTGUI that was previously silently ignored by GCC, but now errors in GCC 14. It would explain why switching to Clang also “fixes” the issue.


Fix double "signing" KU validation

What this PR does / why we need it:
Fixes the case where the CSR is invalid when both "signing" and "digital signature" are set. They are the same in x509.
This also adds some unit tests to test this validation.
Which issue this PR fixes
fixes https://github.com/jetstack/cert-manager/issues/3274
Special notes for your reviewer:
Release note:

Fixes incorrect CSR validation when both "signing" and "digital signature" are set

/kind bug

@wallrj i think it would make a good issue to run this on larger parts of the code and add more tests!

/cherry-pick release-1.0


fix: include description in job submission

What was the problem/requirement? (What/Why)

Maya job submissions were not including the description field, even when filled out in the submitter UI.

What was the solution? (How)

Include the description

What is the impact of this change?

Jobs submitted with the maya submitter will include the description when populated

How was this change tested?
Ran the submitter with a local installation of Maya and verified newly submitted jobs include the description field in the Deadline Cloud Monitor.

Have you run the unit tests?
Yes

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Timestamp: 2024-10-24T11:20:44.903849-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test succeeded

Timestamp: 2024-10-24T11:20:46.045940-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/referenced_layers

referenced_layers
Test succeeded

Timestamp: 2024-10-24T11:20:46.501578-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/renderman
Skipping test renderman because Renderman for Maya is not installed.
Timestamp: 2024-10-24T11:20:46.501665-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test succeeded

Timestamp: 2024-10-24T11:20:47.150117-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test succeeded

All tests passed, ran 4 total.
Timestamp: 2024-10-24T11:20:54.336125-07:00

Was this change documented?
N/A
Is this a breaking change?
No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ben you did not git commit -s


Support Mithril.js

Description
Right now we support the top players (React obviously, Angular and Vue), but (except for Hyperapp) we do not support other (established) frameworks.
We should go for integrating a converter to handle Mithril.js. Like all other converters it would be opt-in.
Background

Homepage mithril.js.org
GitHub github.com/MithrilJS/mithril.js

Discussion
Right now I can't think of anything to discuss.

Landed in develop / preview.


RGBD camera pointcloud registration

Hi, thanks for your great work.
Is fast_gicp suitable for pointcloud from RGBD camera?
I have tried your algorithm to registrate pointcloud generated from RGBD camera, but the result is not satisfactory. Could you give me some suggestions to improve the performance in RGBD camera's pointcloud?
thank you.

I dont think theres anything inherently different between rotating lidar and rgbd point clouds for the purposes of registration. Without knowing your inputs no one can tell why it might fail.


Add LGPL 3.0 License

Type: Missing
Summary:
Add LGPL 3.0 License
Details:
No info in package files. Meta data indicated LGPL 2.1. No info in source repo, but a closed issue where author indicates LGPL 3.0.
Resolution:
Issue from source repo is here: https://github.com/JanKallman/EPPlus/issues/311
Affected definitions:

EPPlus 4.1.0

@TRQ3 It appears that this comment in the same issue indicates that from 4.1.1 is LGPL-3.0 and previous versions are under LGPL-2.1-or-later. Do you agree?

@capfei I agree. Thanks!


Cannot test function(*) including map and array

<?xml version="1.0" encoding="UTF-8"?>
<x:description stylesheet="test.xsl" xmlns:x="http://www.jenitennison.com/xslt/xspec"
	xslt-version="3.0">
	<x:scenario label="Function">
		<x:call function="exactly-one">
			<x:param as="function(*)" select="function-lookup(xs:QName('xs:integer'), 1)" />
		</x:call>
		<x:expect label="Fail deliberately" />
	</x:scenario>
</x:description>

...
Running Tests...
Testing with SAXON EE <IP_ADDRESS>
Function
Error at function test:report-atomic-value on line 355 of generate-tests-utils.xsl:
  FOTY0013: Function items (other than arrays) cannot be atomized
Function items (other than arrays) cannot be atomized

*** Error running the test suite

The same or similar termination happens with derivation: map(*) and array(*)

Reopening for XQuery


Casing standard and name conventions should match the in Product exp.

Follow the pattern defined in the in product exp. for search results.
AC

Use all caps in the text of the label  developer = DEVELOPER
Use the correct naming convention "community" = "discuss"

after comparing the 2 experiences and thinking about this change to color of the labels, I personal don't think the site needs to color code the labels, I actually like the consistency of all the labels looking similar, @djsauble  what do you think?

It's neat to see this visualized, and I agree. The color draws too much attention to the badge.
We could have a more subtle treatment here though. For example, we want to prioritize links to results on the current site (to keep from bouncing people unnecessarily and also because they're likely on the current site because it's providing value to them), so the badge for those links could be teal and all other badges could be grey.

Per our conversation today we will hold off on any color changes to the labels and stick with a more consistency design style.

Note: This should be done in both the global search and the right rail component


[Request]: Download speed limit

Is your request related to a problem?
Yes
How is the feature request related to the problem?
No response
Describe your proposed solution
I would like to have a speed limiter when downloading packages.
Describe alternatives you've considered
I would like to have a speed limiter when downloading packages.
Additional context
No response

Heyyo~
Thank you for submitting enhancement request for Collapse! As for the request, we were already planned to add this but since we use custom implementation for the download process (using Hi3Helper.HTTP) for features such as multithreaded downloads, implementing a speed limit using something like ThrottledStream is more involved process than we initially thought.
Though no worries, we can keep this ticket open and see when we can get back into this and will update you when we have anything to put out!
If you need workaround you can use network-based speed limiter such as NetLimiter, though its a paid software unfortunately

Further proposed enhancements, merging from #481, #482:

Allow for custom timeframes where speed is not limited.
Execute action/application on task complete (download, update or repair)

hello where to limit and planify donwload speed? i dont see any button on that im on version 1.80.19


Add literature references

(for IAS15 and WHFast codes; HERMES is a combination of the two)

Relates to #64


feat(dpg): rename top parameter in pagination method

rename top parameter to maxCount if the name is not occupied
add test

part of https://github.com/Azure/azure-sdk-for-net/issues/29342
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

@AlexanderSher Thanks! Review comments are resolved. Could you please take a look again?

move operation update into UpdateListMethodNames and rename it as UpdateOperations
extract maxCount into a const string
optimize the condition check for updating operation parameters
add method assertion in test
add missing test project launch setting

@archerzz, could you do a test run for azure-sdk-for-net?
As mgmt. SDK would not apply this, we need to make sure there is no regression for them.

@archerzz, could you do a test run for azure-sdk-for-net? As mgmt. SDK would not apply this, we need to make sure there is no regression for them.

@lirenhe It's created: https://github.com/Azure/azure-sdk-for-net/pull/31220 Looks fine, however right now there is an issue blocking us from merging the PR.

@archerzz, could you do a test run for azure-sdk-for-net? As mgmt. SDK would not apply this, we need to make sure there is no regression for them.

@lirenhe It's created: Azure/azure-sdk-for-net#31220 Looks fine, however right now there is an issue blocking us from merging the PR.

@archerzz, could you check the comments from Heaths?  I suggest to have a codegen config to suppress rename for the existing services to avoid breaking change.

@archerzz, could you do a test run for azure-sdk-for-net? As mgmt. SDK would not apply this, we need to make sure there is no regression for them.

@lirenhe It's created: Azure/azure-sdk-for-net#31220 Looks fine, however right now there is an issue blocking us from merging the PR.

@archerzz, could you check the comments from Heaths? I suggest to have a codegen config to suppress rename for the existing services to avoid breaking change.

Per discussion, I've added a configuration disable-pagination-top-renaming. See the latest change here and in the preview SDK PR. I know this configuration name seems too fine-grained, but considering there are other pending issues in https://github.com/Azure/azure-sdk-for-net/issues/29342, I cannot see a better option.

@archerzz, could you do a test run for azure-sdk-for-net? As mgmt. SDK would not apply this, we need to make sure there is no regression for them.

@lirenhe It's created: Azure/azure-sdk-for-net#31220 Looks fine, however right now there is an issue blocking us from merging the PR.

@archerzz, could you check the comments from Heaths? I suggest to have a codegen config to suppress rename for the existing services to avoid breaking change.

Per discussion, I've added a configuration disable-pagination-top-renaming. See the latest change here and in the preview SDK PR. I know this configuration name seems too fine-grained, but considering there are other pending issues in Azure/azure-sdk-for-net#29342, I cannot see a better option.

Looks like this config is not required. Heaths has clarified that the SDK is not GAed.


Remove bad instance types

PR back from the dead to roll nodes by midifying the nodegroup

previously #804


[ENH]: GET /databases should return 404 instead of 500 for not found

Description of changes
When a database is not found, a 404 HTTP status code is now returned instead of a 500.
Test plan
How are these changes tested?
Added a new test. It doesn't strictly test the status code (difficult if we want to keep the more friendly error message), but exercises the code path.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a

I'm a bit confused by this implementation, the new error is already a ChromaError so it should be already getting caught by:

it's just
 except Exception as e:
    if isinstance(e, NotFoundError):
        raise ValueError(
            f"Could not connect to database {database} for tenant {tenant}. Are you sure it exists?"
        )

    raise e

vs.
except NotFoundError:
  raise ValueError(
        f"Could not connect to database {database} for tenant {tenant}. Are you sure it exists?"
    )
except Exception as e:
  raise e

Functionally the same but the second one does look cleaner, so I'll change.

Discussed offline, ChromaError allows us to set the message directly at the callsite by overriding message:
class ChromaError(Exception, EnforceOverrides):
    trace_id: Optional[str] = None
    def code(self) -> int:
        """Return an appropriate HTTP response code for this error"""
        return 400  # Bad Request
    def message(self) -> str:
        return ", ".join(self.args)

So let's just use that


Portfolio Template

Thank you for your suggestion to add the portfolio project! We are currently not expanding this to any new lessons and projects. We do have a Portfolio project if you would like to use and/or contribute to: https://github.com/education/codespaces-project-template-js
I appreciate your time and usage of this curriculum! Stay tuned for when we open contributions for additional lessons, and example web apps to build. For now, sharing your creations within Discussions would be amazing!


global timestamp glitches every 4292 seconds (can go backwards)

Required Info

Camera Model
D435i

Firmware Version
not available, as exact camera may have been moved since recording was done

Operating System & Version
Linux (Ubuntu 20.04)

Kernel Version (Linux Only)
5.15.0

Platform
PC

SDK Version
<IP_ADDRESS>12

Language
python

Issue Description
Every 2^32 milliseconds (4292 seconds), the realsense global time glitches for a second or so, before going back to where it's supposed to be.
The following recording was observed while retrieving 400Hz gyro samples from a D435i (see above for details), but frames going back in time were observed with different configurations (while streaming depth frames only, imu only or a combination of multiple channels), cameras (D455, D435, D435i), firmwares and SDKs (including up to at least <IP_ADDRESS>48)
Attached, 4 images showing the periodicity of the issue as well as zooms on the issues of the recording shown.

The main suspect would be CLinearCoefficients::calc_linear_coefs not compensating properly for hardware_time register wrapping (max_device_time).
As there is no change in this file since version 2.38, I don't see any point in checking on the latest SDKs & firmwares.

Hi @denis-giri-inbolt  There have been a couple of past cases at https://github.com/IntelRealSense/realsense-ros/issues/1469#issuecomment-727844189 and https://github.com/IntelRealSense/realsense-ros/issues/1756 of the IMU timestamp going back in time.  It has usually been reported in the RealSense ROS wrapper rather than librealsense.
Typically with IMU timestamp problems, disabling global time corrects the problem.  Python code for setting the on / off status of global time can be found at https://github.com/IntelRealSense/librealsense/issues/9172#issuecomment-855723153

@MartyG-RealSense , thanks for the links. I didn't think to check on the ros repo, as I use python.
Not quite sure the 2 ros tickets are relevant though, as they seem to mostly talk about IMU packet timings & interpolation, not timestamp generation. The closest thing to it might be https://github.com/IntelRealSense/realsense-ros/issues/1469#issuecomment-727844189, but doesn't match the periodicity I observed.
As for the use of hw_time (sensor.set_option(rs.option.global_time_enabled, 0)),
on the camera currently on my desk today (a D455), the hw_time seems to go at about 1.000076x real time, which is a bit too far from 1x real time for me. I kinda need the realsense frames to be timestamped on a monotonic clock that progresses at the same speed as my system clock (I'm hoping for ~10ms per day of drift)
So, my current options are:

wait for the global_timestamp_reader lib to be fixed by someone who knows it well (how hopeful should I be?)
try to fix it myself
implement something similar (hopefully simpler) in python
find a 3rd party library that does the job

When global time is enabled, it attempts to reduce drift by comparing device time with system time, as described at https://github.com/IntelRealSense/librealsense/pull/3909
At https://github.com/IntelRealSense/librealsense/issues/2188#issuecomment-409985803 and the comments below it, a RealSense team member provides detailed information about the different types of timestamp that are available and their timings.

Hi @denis-giri-inbolt  Was the information in the above comment helpful to you, please?  Thanks!

not really. But this is no longer a blocking point for me:
I went with "implement something similar (hopefully simpler) in python", as the system clock used in global_timestamp_reader.cpp isn't monotonic, and as the formula for linear regression used in global_timestamp_reader.cpp has a singularity when the hardware clock is very regular... i.e. when it's a "good clock", the denominator = 0.
Basically, I used the more stable & more expensive cov(x,y)/var(x) with y = time.monotonic() (not time.time()) and x=dewrapped-non-global-time (2 separate steps, not trying to meld the 2 clock cleanup steps together)

It's great to hear that you achieved a solution.  Thanks very much for the update and for sharing your method!

Case closed due to solution achieved.


Update source-map dependency

The API used here (SourceNode.fromStringWithSourceMap) has not changed. But I don't know how to test this properly, so I haven't.

Thanks!


Added: Update domain configuration and hosts file

This pull request updates the domain configuration and hosts file to allow the user to choose custom domains for the frontend and backend. It also replaces the existing domain variables in the .env file with the chosen domains. Additionally, it renames the unnecessary script file that added host entries.
In short:

Renames the scripts directory to bin (shorter to type)
Renames the add-hosts-entries script to setup-domains
Expand the setup-domains script with end-to-end configuration of local domains (also updates the .env file)

Demonstration
https://github.com/Amsterdam-Music-Lab/MUSCLE/assets/8208970/ea8086da-0ea7-43db-ae0c-d7aafa625b26

Hey @Evert-R could you try this script and see if it works for you? I've tried it with both muscle.local / backend.muscle.localandlocalhost:3000 / localhost:8000` and it seemed to work as expected but maybe it only works on my machine, who knows 🤷


help - can not use regex for query params like /u1/u2?{p1}&{p2:[0-9]{1,3}} . Neither {myBool:bool}"

Trying to use regex for query params, but it does not get routed.The below don't work
url:  "/myApp/u1/u2?{qp1}&{qp2:[0-9]{1,3}}"
also can not use 'bool' that is defined in ui router. The below don't work
url:  "/myApp/u1/u2?{qp1}&{qp2}&{qp3:bool}"
Is this a limitation on query params support in angularjs ui router
What I'm to do is;
The value of one of the query params, contains the other query param keys in it as part of its value.
For example with url  definition of;
url: "/myApp/u1/u2?{qp1}&{qp2}&{qp3}&{qp4}"
the url gets hits as
http:/myApp/u1/u2?qp1=val1&qp2=val2&qp3=qp1%3Dval10%26qp2%3Dval20&qp4=val4
the qp3 is not parsed correctly, instead some of its value contents which contain qp2 and qp2 strings, get parsed into values of qp1 and qp2.
How can I achieve this ?

What is it you are trying to do that you think this is the solution?

@ilker-kiris ^^

In version 0.2.15 state params with regex not working while in 0.2.14 all works fine.
The sample state url: /games/{slug:[\w-]+}. In 0.2.14 state works, in 0.2.15 - router redirect to 'otherwise'.

Seems to work in 0.3.2: http://plnkr.co/edit/JuUM1TpSTo5cjRRzHvJj?p=preview


Add support for refactorings (_typescript.applyRefactoring)

Hi,
I noticed that typescript-language-server has "refactorings": https://github.com/typescript-language-server/typescript-language-server#apply-refactoring , but I'm not sure if these refactorings are actually code actions (extract to method, etc), or it's something else?

Looking at the documentation, I think these correspond to code actions (some of which are only accessible by using vim.lsp.buf.range_code_action(). We did need to add support for rename handling in #17, but otherwise I think these should already work. Let me know if that's not the case.

Yeah those are already accessible through code actions, so I guess we are ok. Thanks for investigating.


chore: remove yang_exclude_bad_drafts.py script

Signed-off-by: Slavomir Mazur<EMAIL_ADDRESS>

After some review it seems that functionality of this script is no longer needed - I changed this PR, it will remove script, its calls and all necessary files.


iOS: when picking phone code in suggestion, it wasn't entered in the input as expected

I have tested it for signup & login flows... it worked fine

I tested again, worked fine too, closing!


How can we work?

Hello.
Thanks for your following.
You followed me in github.
I have just seen your github profile.
I am Senior Full Stack developer with over 7 years of experience.
I think we can collaborate in coding and getting job.
I worked in Sapien Company of Califonia, but I lost job for now because the task was terminated.
So I am free now.I want to get job with you if possible.If you are interested in me, please let me know.
Thanks.
Best regards.
Oskar Mast

HI,
I sent you an e-mail


httpx

Ups, I was using the search bar on "Issues" and I accidentally created a new issue. Closing it now. Feel free to delete it.
And thanks for all the great tools you wrote!


Upgrade PAC to v0.15.0

Locally tested ✔, pipeline-service argocd application is green in Argo CD Dashboard with PAC v0.15.0.

Signed-off-by: Satyam Bhardwaj<EMAIL_ADDRESS>

/ok-to-test


Configure Auto Updater

https://www.electron.build/auto-update
App should auto update when a new release is available

Should be working? Will test on next release.

Should be working? Will test on next release.

Auto update works

Auto update works


multiple job folders for digits?

hi,
is it possible to have multiple job folders (on different disks) in digits?
It seems to me the best is to keep data jobs on the fastest disk, and models+multitide of weight snapshots on a larger archieve disk
any hint?
tnx

DIGITS_JOBS_DIR is an environment variable, have you tried maybe using comma separation between different locations? If that does not work, then I don't think it is supported then


Poor GC of leveled during handoff

During handoff (i.e. a node transfer), the PUT rate into a vnode may be higher than normal.
During the 2.9 cycle of release candidates, a change was introduced to do per-process GC on leveled_sst files if they still exist 10s after they were created.  This stopped an issue with poor GC on these processes when running Riak on OTP16.
When put pressure is high, level 1 files may be moved to the delete_pending state (because they have been replaced), before the GC message is received.  The GC message broke the timeout loop on delete, meaning that the file process would not correctly self-delete until the vnode is shutdown.  This could lead to issues with the ulimit open files limit.

This could also have an impact where leveled is used as a Tictac AAE backend.

https://github.com/basho/riak_kv/tree/riak_kv-2.9.0p1


upgrade to<EMAIL_ADDRESS>

are there any plans to upgrade to version<EMAIL_ADDRESS>?

Hi,
Yes there will be. I hope to have some time this weekend to look into what's required

Just let me know if I can support you somehow.

I can see the build errors
podman container run --rm -it docker.io/ubuntu

apt-get update
apt-get install software-properties-common
add-apt-repository ppa:alex-p/tesseract-ocr-devel
apt-get update
apt-get install libtesseract5 libtesseract-dev git clang cargo pkg-config
git clone https://github.com/ccouzens/tesseract-sys.git
cd tesseract-sys
cargo test

As with https://github.com/ccouzens/tesseract-sys/issues/13
I get the error
error[E0425]: cannot find value `kMinCredibleResolution` in this scope
  --> src/lib.rs:42:9
   |
42 |         kMinCredibleResolution;
   |         ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `kMaxCredibleResolution` in this scope
  --> src/lib.rs:43:9
   |
43 |         kMaxCredibleResolution;
   |         ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error: aborting due to 2 previous errors

Looking at target/debug/build/tesseract-sys-b07b2b4d0445324a/out/capi_bindings.rs I see that the functions and structs have generated (though it is possible important ones are missing).
But target/debug/build/tesseract-sys-b07b2b4d0445324a/out/public_types_bindings.rs is blank (except for an autogen comment). This matches up with the error.
My /usr/include/tesseract/publictypes.h:constexpr int kMinCredibleResolution = 70; includes the constant.
We can compare an older version of publictypes.h https://github.com/tesseract-ocr/tesseract/blob/90db9b5224a3c0ceb5c84fbcae835cab3ac817d8/include/tesseract/publictypes.h
To the new version https://github.com/tesseract-ocr/tesseract/blob/main/include/tesseract/publictypes.h
We can see that the constants like kMinCredibleResolution were defined top level, but now they're defined in a namespace https://github.com/tesseract-ocr/tesseract/blob/main/include/tesseract/publictypes.h#L20
I suspect getting the build.rs script to see inside this namespace will allow tesseract-sys to support tesseract-5.0

Just let me know if I can support you somehow.

If you like, you can check this PR :)
https://github.com/ccouzens/tesseract-sys/pull/15

Thanks for the PR and the feedback.
Unfortunately I still encounter some errors. It seems that tesseract/5.0.0/include/tesseract/publictypes.h for example contains > c++17 syntax like constexpr.
I'm not sure how to tackle the thing tbh. Maybe you can give me a hint?
cargo build
   Compiling tesseract-sys v0.5.11 (/Users/d34dl0ck/workspaces/rust/tesseract-sys)
error: failed to run custom build command for `tesseract-sys v0.5.11 (/Users/d34dl0ck/workspaces/rust/tesseract-sys)`

Caused by:
  process didn't exit successfully: `/Users/d34dl0ck/workspaces/rust/tesseract-sys/target/debug/build/tesseract-sys-fafd5121b40b52eb/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=TESSERACT_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=TESSERACT_STATIC
  cargo:rerun-if-env-changed=TESSERACT_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=TESSERACT_STATIC
  cargo:rerun-if-env-changed=TESSERACT_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rustc-link-search=native=/opt/homebrew/Cellar/tesseract/5.0.0/lib
  cargo:rustc-link-lib=tesseract
  cargo:rustc-link-lib=curl
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=TESSERACT_STATIC
  cargo:rerun-if-env-changed=TESSERACT_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rustc-link-search=native="/opt/homebrew/Cellar/tesseract/5.0.0/lib"
  cargo:rustc-link-lib=tesseract

  --- stderr
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:33:1: error: unknown type name 'constexpr'
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:38:1: error: unknown type name 'constexpr'
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:40:1: error: unknown type name 'constexpr'
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:45:1: error: unknown type name 'constexpr'
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:33:1: error: unknown type name 'constexpr', err: true
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:38:1: error: unknown type name 'constexpr', err: true
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:40:1: error: unknown type name 'constexpr', err: true
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/publictypes.h:45:1: error: unknown type name 'constexpr', err: true
  thread 'main' panicked at 'Unable to generate public types bindings: ()', build.rs:125:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Hi @sassman,
It looks like this issue
https://github.com/ccouzens/tesseract-sys/issues/4
The solution is to use clang installed through brew (package llvm). More detail is in the 2nd and 3rd comments
https://github.com/ccouzens/tesseract-sys/issues/4#issuecomment-748373340
https://github.com/ccouzens/tesseract-sys/issues/4#issuecomment-748489179
I believe there is an issue with the version of clang shipped by recent MacOS that causes a constexpr incompatibility with bindgen.
https://github.com/rust-lang/rust-bindgen/issues/1948
Hopefully that helps you get this to compile :)

I had been hoping that this issue would fix itself, either through Apple updating clang again or bindgen changing.
But it has been over a year now so maybe this issue needs addressing.
Possibly updates to the Readme to tesseract-sys.
Or we need to find a different way of reading these 4 values out of publictypes.h https://github.com/tesseract-ocr/tesseract/blob/main/include/tesseract/publictypes.h#L30-L43

thanks for the hints!
The issue was not clang in my case, both llvm and apples clang versions are the same (v13.0.0)
However, my bindgen version was too old. A fresh install (v0.59.2) did fix that problem.
now it's only an include path issue, that I probably can fix.
  --- stderr
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/capi.h:32:10: fatal error: 'stdio.h' file not found
  /opt/homebrew/Cellar/tesseract/5.0.0/include/tesseract/capi.h:32:10: fatal error: 'stdio.h' file not found, err: true
  thread 'main' panicked at 'Unable to generate capi bindings: ()', build.rs:110:10

You're welcome

The issue was not clang in my case, both brews llvm and apples clang versions are the same (v13.0.0)
However, my bindgen version was too old. A fresh install (v0.59.2) did fix that problem.

That's interesting. Could I get you to do me a favour and retest this issue? https://github.com/rust-lang/rust-bindgen/issues/1948 I no longer have access to a Mac computer.

now it's only an include path issue, that I probably can fix.

Good luck :)


HBASE-26193 Do not store meta region location as permanent state on z…

…ookeeper

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  4s
master passed

+1 :green_heart:
compile
1m 55s
master passed

+1 :green_heart:
shadedjars
10m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  3s
the patch passed

+1 :green_heart:
compile
2m  1s
the patch passed

+1 :green_heart:
javac
2m  1s
the patch passed

+1 :green_heart:
shadedjars
9m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-client in the patch passed.

-1 :x:
unit
140m 58s
hbase-server in the patch failed.

183m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3583

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 188b8099aacc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 11222fc4df

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/testReport/

Max. process+thread count
3834 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
9m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
9m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

-1 :x:
unit
213m 33s
hbase-server in the patch failed.

251m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3583

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2afa3f888629 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 11222fc4df

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/testReport/

Max. process+thread count
2842 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 23s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
2m 14s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
3m 19s
the patch passed

+1 :green_heart:
javac
3m 19s
the patch passed

+1 :green_heart:
checkstyle
1m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

53m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3583

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 169476c664c1 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 11222fc4df

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
3m 19s
master passed

+1 :green_heart:
checkstyle
1m 10s
master passed

+1 :green_heart:
spotbugs
2m 11s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 1 new + 94 unchanged - 0 fixed = 95 total (was 94)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

51m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3583

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux b4745694882e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 44d5624908

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3583/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.


Respond to HTTP POST requests with 404 in WebAssetServer

Description
Respond to HTTP POST requests with 404 in WebAssetServer. The issue seems to have been introduced with custom URL strategies, when the server started responding with HTTP 200 and serving index.html to all requests.

"Linux analyze" failure was a flake. Here's a successful rerun: https://ci.chromium.org/p/flutter/builders/try/Linux analyze/4074


Remove an import of UniformTypeIdentifiers from the Foundation overlay.

An earlier iteration of this code needed to talk to the UniformTypeIdentifiers framework on Apple platforms. This is no longer the case.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci test


Version 2 has broken our build

After the update to version 2, we get this error when Woodpecker starts:
+ git init -b master
Initialized empty Git repository in /drone/src/github.com/<snip>/.git/
+ git remote add origin https://github.com/<snip>
+ git fetch --no-tags --depth=1 --filter=tree:0 origin +refs/heads/master:
fatal: could not read Username for 'https://github.com': terminal prompts disabled
exit status 128

Same is also for me, works fine with v1.6.1

Should be fixed by #52


[PE-D] Documentation issue

list command should not belong here, since it takes in parameters, and list123 is not interpreted as list

Labels: type.DocumentationBug severity.Low
original: leonghongfai/ped#13

Fixed in user guide update.


Version 1.1 Unable to Install Fedora - Error 0x80070003

Hi,
I am stuck working on a system that does not have the Fall Creator's Update, thus I am also stuck with using the 1.1 version of LxRunOffline (As I do not have the required .dll files mentioned here: https://github.com/DDoSolitary/LxRunOffline/issues/10).
After following all of the instructions on the wiki page here: https://github.com/DDoSolitary/LxRunOffline/wiki/Fedora , I run
.\LxRunOffline.exe /install
and specify the fedora .tar.gz and a .ico icon file. I get the following output after specifying the tar and ico locations:
-- Beta feature --
This will install Ubuntu on Windows, distributed by Canonical
and licensed under its terms available here:
https://aka.ms/uowterms

Type "y" to continue: y
Downloading from the Windows Store... 100%
Extracting filesystem, this will take a few minutes...
Error: 0x80070003

System details:
OS Name: Windows 10 Enterprise
Version: 1607
OS Build: 14393.447

Those distros that I've written in wiki were installed in Fall Creators update. I've not tried them in old windows 10 build. Did you get that docker image correctly? Which version of fedora did you try?
I'll then try that in my old VM and inform you.

I tried using two versions of fedora.
Version 27 from here: https://github.com/fedora-cloud/docker-brew-fedora/blob/27/x86_64/fedora-27-x86_64-20171110.tar.xz
And Version 21  from here: https://github.com/fedora-cloud/docker-brew-fedora/blob/21/fedora-21-release.tar.xz
I then followed the instructions on the wiki to convert the .tar.xz to .tar.gz.

OK, I'll try it. Why not you install new Windows 10 builds? Does Ubuntu works with normal process?

Ubuntu works fine.
The windows build is out of my control; laptop is also not connected to the network. That's why I am using this offline installer.

Just tried with the --hard-dereference option, different error in same location: 0x800706f8

Wait hold on, the --hard-dereference worked with fedora 27; just failed with fedora 21. This is probably sufficient for my needs.


Support new types of errors in charts and selectors

i18n-check

The following components have not been translated
common.errors (ru)common.errors (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.


How do you use dagger 2 injection with Moxy

Trying to use the @InjectPresenter in the Views and @InjectViewState preceding the presenter classes but my presenter classes also need to inject modules of their own which I'm doing via the constructor but I get this error
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jackthreads.android/com.jackthreads.android.activities.PageActivity}: java.lang.IllegalStateException: Unable to instantiate class com.jackthreads.android.presenters.PagePresenter: make sure class name exists, is public, and has an empty constructor that is public
     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2661)
     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2726)
     at android.app.ActivityThread.access$900(ActivityThread.java:172)
     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1421)
     at android.os.Handler.dispatchMessage(Handler.java:102)
     at android.os.Looper.loop(Looper.java:145)
     at android.app.ActivityThread.main(ActivityThread.java:5835)
     at java.lang.reflect.Method.invoke(Native Method)
     at java.lang.reflect.Method.invoke(Method.java:372)
     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
  Caused by: java.lang.IllegalStateException: Unable to instantiate class com.jackthreads.android.presenters.PagePresenter: make sure class name exists, is public, and has an empty constructor that is public
     at com.arellomobile.mvp.DefaultPresenterFactory.createPresenter(DefaultPresenterFactory.java:30)
     at com.arellomobile.mvp.DefaultPresenterFactory.createPresenter(DefaultPresenterFactory.java:11)
     at com.arellomobile.mvp.MvpProcessor.getMvpPresenter(MvpProcessor.java:125)
     at com.arellomobile.mvp.MvpProcessor.getMvpPresenters(MvpProcessor.java:177)
     at com.arellomobile.mvp.MvpDelegate.onCreate(MvpDelegate.java:110)
     at com.jackthreads.android.activities.MvpAppCompatActivity.onCreate(MvpAppCompatActivity.java:15)

Searching Moxy and Dagger 2 brings up nothing and it seems like they're messing each other up.

Moxy says that it can't to instantiate class com.jackthreads.android.presenters.PagePresenter. Are sure class is public, and has an empty constructor that is public?
You could make gist, then I can help you ;)

Here you can see, ho to use injection in presenter class.

Unfortunately I had to move forward without using Moxy InjectPresenter/ViewState annotations as I couldn't get it working. I'll have to post my setup again. The problem I was having after injecting like in your example was that I was getting uninstantiated injected objects. I realize that doesn't help much until I get a code sample up, I'll try to get a simple example sometime soon.

Sorry, but I don't understand. Are you need help?

It's very unuseful to inject objects without constructor like this
@Inject
public ProfilePresenter(DataR dataR, MainN n, AuthM authM, BroadcastM broadcastM) {
}

because we need to call
YourApplication.getComponent().inject(this);
but we have complex dagger2 structure with many modules

It will be good to inject presenters by some call in views, like
MvpFacade.getInstance().getMvpProcessor().addPresenter(View view, Presenter presenter,
PresenterType type);

No, it's wrong way for inject presenter. You can use @ProvidePresenter to provide your Presenter's instance. See more about this here and here.

Thanks, it's helps :)

Related question - #100


Cannot use filenames with extensions (full stop in paths)

I'm attempting to get Google App Engine working, and they say this is the front thing to use. Before we go all rest API, some clients do still automatically request /favicon.ico so using a full stop in paths is a valid thing... and if I want to return images, I guess it's still valid, also (still to learn how to serve a static directory for a javascript library). But it seems I cannot (or more likely don't know how to) serve any of the following:
/gfx/applogo.png
/gfx/favicon.png
/js/app.min.js
/app.min.js
/app.min

I can serve
/js/app
/gfx/favicon
/gfx/applogo

Here is my code snippet for my 'standard' javascript file, inside index.php:
$app->get ( '/js/app.min.js', function (Request $request, Response $response) {
	logger("Doing javascript"); // So I know it happens
	ob_start ();
	include (__DIR__ . "/_js/app.min.js.php"); // this file does categorically exist
	$c = ob_get_contents ();
	ob_end_clean ();
	$response->getBody ()->write ( $c );
	return $response;
} );

I then followed the limited/confusing to me instructions on the slim site about running in a PHP standalone server... do I need to do the rest of the bits??? reckoned so, I set up a .htaccess file
Nigels-iMac-Pro-6:www nigel5$ cat .htaccess
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^ index.php [QSA,L]

Then did the bits about enabling modules in my /etc/apache2/http.conf file (not apache.conf file as in the instructions) and setting specific directory entries:
<Directory /Users/nigel5/git/coin73/www>
    Options Indexes FollowSymLinks
    AllowOverride All
    Require all granted
</Directory>

I restarted apache (and even rebooted)
I start a local PHP server:
Nigels-iMac-Pro-6:www nigel5$ php -S localhost:8080
PHP 7.3.24-(to be removed in future macOS) Development Server started at Sat Sep  4 16:52:01 2021
Listening on http://localhost:8080
Document root is /Users/nigel5/git/coin73/www
Press Ctrl-C to quit.
[Sat Sep  4 16:52:03 2021] [::1]:55597 [404]: /js/app.min.php - No such file or directory

As you can see, the directories match (I have tried the Directory entry with and without the ending slash), but I get the 404, and a pretty PHP coloured error:

I tried serving from the root /app.min.js but get the same issue.
If I run this through the dev server script, I get a blank screen and empty document (even though I have an entry in app.yaml for everything to go through my index.php) the fact I get a 200 response code means it didn't bomb out.
Nigels-iMac-Pro-6:www nigel5$ dev_appserver.py app.yaml --php_executable_path /usr/bin/php
INFO     2021-09-04 16:05:23,989 devappserver2.py:309] Skipping SDK update check.
INFO     2021-09-04 16:05:24,122 api_server.py:383] Starting API server at: http://localhost:59032
INFO     2021-09-04 16:05:24,229 dispatcher.py:267] Starting module "default" running at: http://localhost:8080
INFO     2021-09-04 16:05:24,230 admin_server.py:150] Starting admin server at: http://localhost:8000
INFO     2021-09-04 16:05:25,700 instance.py:294] Instance PID: 76098
INFO     2021-09-04 16:05:31,799 module.py:861] default: "GET /app.min.php HTTP/1.1" 200 -
INFO     2021-09-04 16:05:32,403 instance.py:294] Instance PID: 76149
INFO     2021-09-04 16:05:38,669 module.py:861] default: "GET /js/app.min.php HTTP/1.1" 200 -

What can I try to diagnose this?

Hi Nigel
The documentation contains configuration examples for various web servers.
The PHP built-in server is intended for local development and does not require configuration files.  The second section describes how to set up Apache correctly using mod_rewrite. The PHP built-in server and Apache run completely independently and have nothing to do with each other.
When you start the PHP built-in server, you have to make sure that you either start the php command in the document root (where your index.php file is) or set the document root using the -t public/ parameter.

https://www.php.net/manual/en/features.commandline.webserver.php

I am using the php internal testing server and there is something else going on. I found the fix though, I forget where I found it but you need to create a separate file (I called mine router.php next to your index.php file with this in it.
<?php
$_SERVER['SCRIPT_NAME'] = 'index.php';
include 'index.php';
?>

Then when you call the PHP server use this
php -S localhost:8080 -t . router.php

Or I start mine from the parent directory as I also use dispatch.yaml on the GAE server (that doesn't work locally but I digress)
php -S localhost:8080 -t www www/router.php

I don't know if just calling the index.php file directly will work, as I didn't do much testing (there are other issues unrelated to this I need to fix :)
Maybe this might help someone else? Maybe there is a documentation update?

Thanks for your feedback. I am absolutely sure that this additional file (router.php) is not needed for a Slim project to work. For example, when I start the internal web server, I use this command:
cd {project-path/}
php -S localhost:8080 -t public

Then navigate to: http://localhost:8080/
The public/ directory contains the index.php front controller file.
Can you please try this setup?
In case you still have trouble with the setup, you may try to upload the Server Setup Checker to get an idea about the issue.

If I don't use the router.php file and don't declare the entry file, the file request with dots in it doesn't work. If I restart through the router.txt file all is well.
The third attempt was to just use the index.php file specifically, and this also works. So the router.php file is not needed specifically, however, the entry point is required.

This is a "feature" of the PHP builtin webserver. It assumes any url with a dot in the filename to be a static file.
https://bugs.php.net/bug.php?id=61286
Apparently there is a workaround though:
https://www.php.net/manual/en/features.commandline.webserver.php
"If a PHP file is given on the command line when the web server is started it is treated as a "router" script. The script is run at the start of each HTTP request. If this script returns false, then the requested resource is returned as-is. Otherwise the script's output is returned to the browser."
With this info we can make a kludge which checks if the given file exists.
<?php

/* Workaround for routes with a dot. */
if (php_sapi_name() == "cli-server") {
    $_SERVER["SCRIPT_NAME"] = basename($_SERVER["SCRIPT_FILENAME"]);

    $file = parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH);

    if (file_exists(__DIR__ . $file)) {
        /* Return contents of the static file. */
        return false;
    }
}

require __DIR__ . "/../vendor/autoload.php";

$app = new Slim\App();

$app->get("/foo.txt", function ($request, $response, $arguments) {
    print "foo from slim\n";
});

$app->run();

$ php -S localhost:8080 index.php

$ curl http://localhost:8080/foo.txt
foo from slim
$ echo "foo from file" > foo.txt
$ curl http://localhost:8080/foo.txt
foo from file
$ rm foo.txt
$ curl http://localhost:8080/foo.txt
foo from slim

But in my opinion you're better off by using Vagrant or Docker as development environment instead.

Docker and that other thing all sound quite complex to just get a webserver going. You could just update the documetnation about invoking the local development server from this:
cd {project-path/}
php -S localhost:8080 -t public

to this:
cd {project-path/}
php -S localhost:8080 -t public public/index.php

Assuming you're service from the 'public' folder :)
When PHP fix the bug, the instructions are still valid, and everything works really well so far.

I have tested it to serve files on my local machine with the internal webserver and it works as expected.
If there is a file on the harddisk, then the file will be served. If there is not file, but a Slim route, the route will be handled.
Just a question. You have defined this route: $app->get ('/js/app.min.js', ..., but you are testing a url like /js/app.min.php.
Is this correct? If, yes, an 404 error (not found) would be correct in this case.

When I enter php -S localhost:8080 -t public/index.php I get this error: public/index.php is not a directory.

The error message is correct. The php -t switch is expecting a directory you passed in a file name. Should read:
 php -S localhost:8080 -t public

When I enter php -S localhost:8080 -t public/index.php I get this error: public/index.php is not a directory.

Have a quick recheck above
php -S localhost:8080 -t public public/index.php

the -t public is the directory, and then the entry point is specified after this public/index.php

Just a question. You have defined this route: $app->get ('/js/app.min.js', ..., but you are testing a url like /js/app.min.php.
Is this correct? If, yes, an 404 error (not found) would be correct in this case.

Yep, in the original post I define the route:
$app->get ( '/js/app.min.js', function (Request ...

And in the screenshot up there, where its not using the entry point, you can see it's complaining about /js/app.min.js

I'm closing this as resolved.


Fix remaining instances of LV_HOR_RES/LV_VER_RES in drawing code.

Based on #957. Thanks to @manison for reporting this.

(cc @kisvegabor)

Great! Thank you!


Add graphql syntax highlighting

Coverage remained the same at 93.514% when pulling 0eb76d16511cfced6408cbf39144d3b953224724 on add-graphql-syntax-highlighting into bc74f1fe9c34e249897348c99d826a1aac2cdb55 on master.


Error: building package libjpeg-turbo:arm-uwp failed

c:\develop\repos\vcpkg>vcpkg.exe install opencv:arm-uwp
The specified configuration type is missing.  The tools for the
configuration might not be installed.
-- CURRENT_INSTALLED_DIR=C:/develop/repos/vcpkg/installed/arm-uwp
-- DOWNLOADS=C:/develop/repos/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/develop/repos/vcpkg/packages/libjpeg-turbo_arm-uwp
-- CURRENT_BUILDTREES_DIR=C:/develop/repos/vcpkg/buildtrees/libjpeg-turbo
-- CURRENT_PORT_DIR=c:/develop/repos/vcpkg/ports/libjpeg-turbo/.
-- Using cached C:/develop/repos/vcpkg/downloads/libjpeg-turbo-1.4.90.zip
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch C:/develop/repos/vcpkg/ports/libjpeg-turbo/add-options-for-exes-docs-headers.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/develop/repos/vcpkg/ports/libjpeg-turbo/add-options-for-exes-docs-headers.patch done
-- Configuring arm-uwp-rel
-- Configuring arm-uwp-rel done
-- Configuring arm-uwp-dbg
-- Configuring arm-uwp-dbg done
-- Package arm-uwp-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:14 (message):
Command failed: C:/Program Files (x86)/CMake/bin/cmake.exe;--build;.;--config;Release;--target;install;--;/p:VCPkgLocalAppDataDisabled=true;/m
Working Directory: C:/develop/repos/vcpkg/buildtrees/libjpeg-turbo/arm-uwp-rel
See logs for more information:
C:\develop\repos\vcpkg\buildtrees\libjpeg-turbo\package-arm-uwp-rel-out.log
C:\develop\repos\vcpkg\buildtrees\libjpeg-turbo\package-arm-uwp-rel-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:16 (vcpkg_execute_required_process)
ports/libjpeg-turbo/portfile.cmake:39 (vcpkg_install_cmake)
scripts/ports.cmake:73 (include)
Error: building package libjpeg-turbo:arm-uwp failed
Please ensure sure you're using the latest portfiles with vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libjpeg-turbo:arm-uwp
Vcpkg version: 0.0.66-0d50c6704ddc563f459b901297bbb909adaa6e51
Additionally, attach any relevant sections from the log files above.

Please try fixes from #794


Consider using unsafe instead of --cfg for unstable features

Motivation
Currently it is not possible to access a web browsers clipboard in a sane way. The Clipboard API is unstable and thus not available by default, while the Document.executeCommand call is no longer present.
I do understand to put in additional safeguard on unstable APIs, however requiring the user to add ad --cfg option to RUSTC_FLAGS seems rather drastic.
The problem with that is, that you cannot abstract and fix the issue in a library, because the final application developer must enable this flag.
Proposed Solution
If APIs that are consider unstable would be marked (Rust) unsafe, then that would add some extra safeguards as well. However, a library could go ahead and take care of this situation.
Similar to other cases, where implementors, using unsafe functionality guarantee safe functionality.

As I tried to explain, I understand the reason for gating. I am only looking for a reasonable way to work with this.
I understand that this situation here isn't about memory safety, but about API stability. However, the way this is currently enforced, doesn't allow a library to cover this. Using unsafe would.

Sorry but that's the goal of the system. The difficulty using these APIs is considered a feature, not a bug. The intention is that using these APIs is an application-level decision, not a library-level decision. I feel there's not much more that can be done while the APIs are unstable.

While I get why these APIs are hidden, it would still be nice to make them usable with a bit less of a hassle. I'm not building a library, but a webapp, and from my point of view it would be great if this could be a feature instead of a cfg flag.
For example, chrono also hides unstable APIs behind an unstable-x feature and I think this would be a good way to still turn them off by default so the user has to make a conscious decision in enabling them, but at the same time making it less of a hard wall if someone needs to use them. (For example, I have no idea how I would pass rustflags to rust-analyzer to make this work for me right now. It would be great if it was a little bit easier.)

Maybe I'm barking up the wrong tree, but #2684 mentions that you can use unstable APIs reasonably conveniently by adding the following to .cargo/config.toml (within your project):
[build]
rustflags = ["--cfg=web_sys_unstable_apis"]

For me at least, this seems to work very well with IDE integration (Emacs) and normal cargo build commands.

@Follpvosten For using unstable apis with rust-analyzer, add this to your vscode settings.json:
"rust-analyzer.runnableEnv": {
    "RUSTFLAGS": "--cfg=web_sys_unstable_apis"
 }

and then  restart your extensions host. It should now work with the unstable apis, saved my life and brain cells ngl.
P.S. Don't forget to enable it in your config.toml too

rust-analyzer config update: "rust-analyzer.runnableEnv" is now "Unknown Configuration Setting", but this one seems to work:
"rust-analyzer.cargo.extraEnv": {
    "RUSTFLAGS": "--cfg=web_sys_unstable_apis"
}

I'm gonna go ahead and close this, seeing that we don't plan to move to unsafe for unstable features.


VMware Fusion driver Start() always mount shared folder whether --vmwarefusion-no-share was set or not

I don't know golang, but
https://github.com/docker/machine/blob/master/drivers/vmwarefusion/fusion_darwin.go#L415:
	if shareDir != "" {

should be following?
	if shareDir != "" && !d.NoShare {

There is no '--vmwarefuion-no-share' option when start, it's only vaild to create docker machine.
docker-machine create --driver=vmwarefusion --help
docker-machine start -help

I mean '--vmwarefuion-no-share' parameter only works for creating.

I'm reporting that the machine created with --vmwarefuion-no-share mount shared folder.

oops, that would be a bug. I just tried the command docker-machine create --driver=vmwarefusion --vmwarefusion-no-share <NAME> and see the 'NoShare' is set to true. However, the shared folder din;t appear in the docker.
btw, how you check the shared folder is mounted?

Here is a screenshot of mount on VMware Fusion console:

test is create with docker-machine create --driver=vmwarefusion --vmwarefusion-no-share test.
/Users is not mounted on booted with creating.
/Users is mounted after rebooted by docker-machine stop test; docker-machine start test.

got your point, your patch loos good to me.


fix!: fix behavior of Optional to conform noUncheckedIndexedAccess

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

17 of 17 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 96.035%

Totals

Change from base Build<PHONE_NUMBER>0:
0.03%

Covered Lines:
1236

Relevant Lines:
1282

💛  - Coveralls


How to return an empty stream?

I want to write something like this
#[try_stream(boxed, ok = i32, error = Box<dyn std::error::Error>)]
async fn foo(self: Box<Self>) {
    if self.xxx {
        // early exit. return an empty stream
    }

    #[for_await]
    for x in self.child.execute() {
        yield ...;
    }
}

Is that possible or do you have any suggestions about alternative ways to write it?
I can write a big if wrapping the whole body, but that's a little big ugly.

return Ok(()); should work.

Thanks for you prompt answer! Would you think it's worth adding to the doc?

It seems reasonable to mention it in the doc.

I can help with that


Added ability to import a crate containing lib and bin targets with the same name

We do this by adding the ability to put the bin and lib targets into separate CMake namespaces. This also takes some initial steps towards breaking the connection between Rust target names and CMake target names. This structure could be useful for #58 eventually
I currently use __ when :: is not valid in a target name. This can be easily changed if something else is desirable. This feature is entirely invisible unless you opt into it.

I probably won't have time to review this until one week from now.
I'd also be interested if you have a specific usecase where you really need this feature and can't just edit the cargo.toml to get distinct names. This MR does complicate the code and create a maintenance burden, so I'm a bit hesitant.

So, a decent chunk of this code is just plumbing that would be needed for #58. In fact, I could do up a follow up that implements that issue using a very small amount of code. Since it is shared work, my opinion is that the maintenance burden isn't too bad.
Personally, I could rename my targets in my Rust project, but it really doesn't make sense to. If I have a binary named x I should be able to refer to the library code as use x::whatever instead of use libx::whatever.

One question: is IMPORTED_CRATES intended to yield a list of targets instead of crates? If so, would it be reasonable to add a new IMPORTED_TARGETS input and deprecate IMPORTED_CRATES?

is IMPORTED_CRATES intended to yield a list of targets instead of crates

Well, previously the crate name was the same as the target name (a single rust Cargo.toml package manifest contains zero or one library crates, and 0-n bin crates).
I'm conservative regarding deprecating / renaming things - I think it should be sufficient to document that the variable will contain a list of CMake targets, representing the crates that were imported.
I am considering splitting corrosion_import_crate into corrosion_import_workspace and corrosion_import_package, and if I ever do that, then the parameter names for the new functions could also be adjusted.

I currently use __ when :: is not valid in a target name.

I would document that the transformation is string(MAKE_C_IDENTIFIER), which effectively does the same.

string(MAKE_C_IDENTIFIER)
Just to be clear, do you want me to replace my existing string(REPLACE) with this?

Yes, please

Are you sure this has the correct semantics? It converts e.g. flags-lib into flags_lib. This is currently causing build failures; I can work around it, but personally I prefer the more targeted string(REPLACE).

It converts e.g. flags-lib into flags_lib

Ah, I see. No that is not intended. In that case lets stick with the string(REPLACE). Sorry for confusion.

Whoo boy, sorry for not getting back to this for so long. I redid the entire MR since it was so far behind and I had forgotten exactly what I had done in the first place.

I'll be travelling a lot in the next 3 weeks, so it might take a while till I can review this PR (again).