OutlinePass doesn't have setRenderer function but EffectComposer demands it

Getting setRenderer is not a function when adding OutLinePass to EffectComposer's passes.
Added a EffectComposer to the scene using
const composer = new POSTPROCESSING.EffectComposer(renderer)
Created Instance of OutlinePass
import { OutlinePass } from 'three/addons/postprocessing/OutlinePass.js';

let outlinePass = new OutlinePass(new THREE.Vector2(window.innerWidth, window.innerHeight), scene, camera);
//camera is a perspectiveCamera
//scene is initialized
composer.addPass( outlinePass );

I get the following error

postprocessing.esm.js:7726 Uncaught (in promise) TypeError: pass.setRenderer is not a function
at EffectComposer.addPass (postprocessing.esm.js:7726:10)

And when I look up at line 7726 of EffectComposer this is found
 addPass(pass, index) {
    const passes = this.passes;
    const renderer = this.renderer;
    const drawingBufferSize = renderer.getDrawingBufferSize(new Vector217());
    const alpha = renderer.getContext().getContextAttributes().alpha;
    const frameBufferType = this.inputBuffer.texture.type;
    pass.setRenderer(renderer); *** <----
    pass.setSize(drawingBufferSize.width, drawingBufferSize.height);

Using

Three: 0.150.1
Post Processing: ^6.30.1

Environment (not sure if its relevant to this error)

OS: Win
Browser Chrome
Graphics hardware: Nvidia RTX 2060

This library is not compatible with the passes from three.js.

Then any idea what the workaround is ?

You could either use the OutlineEffect that is included in the postprocessing package or use three's postprocessing stack instead.

Thanks,
Resolved by using OutlineEffect from 'postprocessing' package.
But the performance on mobile is very bad for the same, any order I should be passing it in. ?
Will be closing this, as the issue is resolved, and the performance can be a different thread.


Wrap SuiteSparse AMD

This adds some files from SuiteSparse implementing the symmetric AMD reordering algorithm as a stop-gap measure until we have our own AMD implementation.
It also implements a fallback Csr sorting algorithm for CUDA/HIP 64 bit indices using Thrust to make a handful of tests pass.

format-rebase!

IMO Ginkgo already has a lot of different build configurations to keep track of, and with AMD being rather small, and to still enable building Ginkgo without internet access, I would prefer building the code every time. In the long term, we will probably replace it by our own AMD implementation

I think building ginkgo without internet access is a different thing and should use a different way from putting all codes in this repo. For example, when we release or merge pr into develop, there's an action or compressed files for the installation without internet access except for those GPL packages.
Putting code directly in our repo is hard to track the package version.
From the license in the third party, some packages contain the GPL license. Will the license file be also under GPL?

@yhmtsai all our dependencies are licensed under BSD 3-clause. The AMD implementation in Suitesparse has proper version numbers, and has only changed superficially since 2013, so I believe we don't need to worry about having to track upstream changes. Vendoring CAS was also done to make builds of libginkgo (excluding tests etc) possible from airgapped systems. I don't think we should give up that property for effectively 3 source code files from a large repository.
Technically a license file itself is under copyright owned by the author, but since all licenses listed in there require reproduction of the license text in derivative works, we are good. We could instead only include the AMD/Doc/LICENSE.txt though, which would slim down the PR a bit.


The target passed to clang is wrong for aarch64-apple-darwin

cc-rs passes the rust target unchanged, but unfortunately, in the case of aarch64-apple-darwin, the clang target is different, and clang doesn't recognize aarch64-apple-darwin at all. The right target to use is arm64-apple-darwin.

Anyone working on this?

Hello there, any Status on this?

I for one have no problem compiling for M1. I don't see any unrecognized flags passed to cc. I do observe additional --target flag if I attempt to compile with CC environment variable set to clang, but it's correct arm64-apple-darwin. In other words this looks resolved...

No, it isn't arm64-apple-darwin isn't a valid target
[root@52bd9e36c736 be]# cargo build --target arm64-apple-darwin
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --target arm64-apple-darwin --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: Error loading target specification: Could not find specification for target "arm64-apple-darwin". Run `rustc --print target-list` for a list of built-in targets

No, it isn't, arm64-apple-darwin isn't a valid target

What I meant was that if I run env CC=clang cargo build on a M1 machine or env CC=clang cargo build --target=aarch64-apple-darwin on an x86 machine, cc-rs passes --target=arm64-apple-darwin to clang. This is with cc-rs 1.0.73.

Ah, got it, sorry I misunderstood. Btw I used o64-clang (for amd64 builds) instead of o64h-clang (for aarch64 builds) and somehow, it worked.
[root@52bd9e36c736 be]# CC=o64-clang RUSTFLAGS="-C linker=o64-clang -C link-args=-D__ARM_ARCH__" cargo build --target aarch64-apple-darwin
   Compiling untrusted v0.7.1
   Compiling ring v0.16.20
   Compiling be v0.1.0 (/be)
    Finished dev [unoptimized + debuginfo] target(s) in 3.27s
[root@52bd9e36c736 be]# file target/aarch64-apple-darwin/debug/be
target/aarch64-apple-darwin/debug/be: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE|HAS_TLV_DESCRIPTORS>

In other words cc-rs did nothing wrong. At least in the sense that it passed same flags as it would to generic clang [for MacOS]. Case can be dismissed.

for some weird reason, this works:
[root@52bd9e36c736 be]# CC=clang RUSTFLAGS="-C linker=o64h-clang -C link-args=-D__ARM_ARCH__" cargo build --target aarch64-apple-darwin
   Compiling ring v0.16.20
error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/be/target/debug/build/ring-742f4d26dc21a850/build-script-build` (exit status: 101)
  --- stdout
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")

  --- stderr
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/aesv8-armx-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/aesv8-armx-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/ghashv8-armx-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/ghashv8-armx-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/vpaes-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/vpaes-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/armv8-mont-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/armv8-mont-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/chacha-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/chacha-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/ecp_nistz256-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/ecp_nistz256-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/ghash-neon-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/ghash-neon-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/sha512-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/sha512-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/sha256-armv8-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/sha256-armv8-ios64.S"
  running "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-std=c1x" "-Wbad-function-cast" "-Wnested-externs" "-Wstrict-prototypes" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/aes_nohw.o" "crypto/fipsmodule/aes/aes_nohw.c"
  In file included from crypto/fipsmodule/aes/aes_nohw.c:15:
  In file included from include/GFp/aes.h:52:
  In file included from include/GFp/base.h:66:
  In file included from /usr/lib/clang/13.0.0/include/stdint.h:52:
  In file included from /usr/include/stdint.h:26:
  In file included from /usr/include/bits/libc-header-start.h:33:
  In file included from /usr/include/features.h:514:
  /usr/include/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found
  # include <gnu/stubs-32.h>
            ^~~~~~~~~~~~~~~~
  1 error generated.
  thread 'main' panicked at 'execution failed', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/build.rs:656:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[root@52bd9e36c736 be]# CC=o64h-clang RUSTFLAGS="-C linker=o64h-clang -C link-args=-D__ARM_ARCH__" cargo build --target aarch64-apple-darwin
   Compiling ring v0.16.20
   Compiling be v0.1.0 (/be)
    Finished dev [unoptimized + debuginfo] target(s) in 4.24s

but this doesn't:
[root@52bd9e36c736 be]# cargo clean
[root@52bd9e36c736 be]# CC=o64h-clang RUSTFLAGS="-C linker=o64h-clang -C link-args=-D__ARM_ARCH__" cargo build --target aarch64-apple-darwin
   Compiling cc v1.0.73
   Compiling untrusted v0.7.1
   Compiling ring v0.16.20
error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/be/target/debug/build/ring-742f4d26dc21a850/build-script-build` (exit status: 101)
  --- stdout
  OPT_LEVEL = Some("0")
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-apple-darwin = None
  CC_aarch64_apple_darwin = None
  TARGET_CC = None
  CC = Some("o64h-clang")
  CFLAGS_aarch64-apple-darwin = None
  CFLAGS_aarch64_apple_darwin = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")

  --- stderr
  running "o64h-clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=arm64-apple-darwin" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/be/target/aarch64-apple-darwin/debug/build/ring-bc471d909e7e38fa/out/aesv8-armx-ios64.o" "/root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/aesv8-armx-ios64.S"
  In file included from /root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/aesv8-armx-ios64.S:12:
  include/GFp/arm_arch.h:96:5: error: "unsupported ARM architecture"
  #   error "unsupported ARM architecture"
      ^
  1 error generated.
  thread 'main' panicked at 'execution failed', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/build.rs:656:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[root@52bd9e36c736 be]#

HMmmmmmmm

If anyone is having the same issue with o64h-clang, I started this issue https://github.com/tpoechtrager/osxcross/issues/333#issuecomment-1079370341

In the case of ring issues, the latest version (0.17) redoes the ARM target detection so the "unsupported ARM architecture" error may no longer be relevant. I do build and test on aarch64-apple-darwin and it works fine so I think any issues here are likely (a) solved with ring 0.17, for people having problems with ring, and/or (b) issues with cross-compiling toolchains.

Awesome. Unfortunately due to work, I can't test it. But as soon as I'm available I'll let you guys know


Usability fixes (The last PR :( )

The last PR of my internship. Fixes some things Yann noted.

Mostly looks good, but C# method names start with a capital letter.

A few minor suggestions, but LGTM.

LGTM.


Split test_napari_atlas_representation.test_add_to_viewer into several tests

I actually think this is fine as is now (key splitting off of mesh tests has been done already by #42 ).


[core] Use React 17

Just want to see how much we gain by dropping event.persist().

170B minified, 47B gzipped.


Update CHANGE_LOG for 0.53.0rc2

As title.

will wait to see if the farm is happy with the release branch


The JS snippet to discover group identifiers no longer works

After pasting the JS snippet into the F12 console, it doesn't seem to have any effect on the rendered context menus. I tried a couple different menus on VSTS. Is this code outdated due to VSTS changes? What is the current way to discover context menu group identifiers?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b46557dc-2e49-b914-105e-9235c7dbf860
Version Independent ID: 42901bac-88ea-acb6-cf5e-6086b3223a9a
Content: Discover menu group identifiers
Content Source: docs/extend/test/discover-menu-group-ids.md
Service: unspecified
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

Hi @jkeech , I've reached out to the product team to try to get this thing figured out for you. Hopefully we can get you an answer and update the article soon if needed!

Hi there, this issue has been stale for close to one year. I'll be closing this issue, however please @mention me if you'd like me to reopen or create a new issue, if problems remain. Thank you!


change chat preview subtitle for DM and room chat

Details

We want to change the alternate text (text below chat name) of DM and room chat.
Fixed Issues

$ https://github.com/Expensify/App/issues/15799
PROPOSAL: https://github.com/Expensify/App/issues/15799#issuecomment-1464786096
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Start a new chat with a user you never chat before
Go back
Verify the chat subtitle text is This is the beginning of your chat history with ...
Open Settings > Workspaces > New workspace. It will create 2 empty default room chat.
Go back to home
Verify the room chat subtitle text is 'No activity yet'
Open Settings > Preferences > Language and select Spanish
Go back to home
Verify the room chat subtitle text is 'Sin actividad todavía'

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1679674958198429

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@dangrous @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

How can we retry the failed GitHub actions above?

Ah, I'm not aware that we want to change the non-room text too. Will update shortly!

Updated.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.2.91-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.91-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Client Websockets always closed

So i have already success implementing handle message and readbinary, but the client websockets always stop no connection

i've try adding ["admin","test"] or ?,, but still closed.
please contact me here

i've tried many things still not showing the result.

Fixed


Cu 866a7nxx8 organize temperature setpoints at brick schema connor cantrell

Task linked: CU-866a7nxx8 Organize temperature setpoints at Brick Schema


[Bug] Memory usage other time

Describe the bug
We can see with our different Grafana Operator instances that memory usage can grow from 40MB to more than 800MB.
To Reproduce
Steps to reproduce the behavior:

Deploy the Operator without memory limits set.
Create a GrafanaDataSource
Create 5 or more GrafanaDashboard resources
Wait a few days/weeks and see memory usage grows every 10 minutes or so in small increments until reaching hundreds of MB.

Expected behavior
Garbage collection of some sort to prevent constant memory growth.
Runtime (please complete the following information):

OS: RHCOS
Grafana Operator Version 3.5.0
Environment: Openshift
Deployment type: As a Deployment
Other: reconciles for GrafanaDashboard CR in multiple namespaces

Tested with a memory limit of 400MB and eventually the Operator process ran garbage collection as it approached 400MB to go back down o 16MB.
So either it should be documented/automated to have a memory limit on the Operator Deployment or the Go process should have a default garbage collection trigger without waiting to reach container cgroup limit.

Hi @tux-o-matic , I don't think we do any garbage collection ourselves as the operator, Grafana has default memory limits set to 1024Mi https://github.com/integr8ly/grafana-operator/blob/master/pkg/controller/model/grafanaDeployment.go#L23 , So this is a kubernetes/openshift setting AFAICT for deployments. However, I think we can document this to make people more aware.
Is this a solution that you think would be sufficient?

Hi @HubertStefanski , that link and its MemoryLimit are for the Grafana instances being managed by the Operator, not the Operator itself.
The only way to control the memory constrains of the Operator is through a limit in the Deployment resource managing the Operator. And optionally self control/garbage collection in the GO process of the controller.

@tux-o-matic, yes, sorry, I should have clarified. But the solution remains the same right? We just need to document an adequate field for operator deployment and Kubernetes will manage memory to keep within that limit by itself.

So yes there should be an example Depployment with proper request/limit.
And ideally somebody with a good understanding of the inner working of the controller can suggest those values. I can only see that the process cleans up its memory allocation as it reaches its assigned limit (when one was set).

Hi @tux-o-matic , this makes sense, we should set an example for grafana deployments with sensible requests and limits for CPU/Memory

@HubertStefanski in addition to an example, we can also consider this for OLM installations (set default requests and limits).

In v4.0.1 we can find a base line for limits in the operator. Thus I will close this issue

@HubertStefanski @NissesSenap, the example values of 100Mi and 300Mi doesn't change the fact that the Operator garbage collection doesn't run correctly and the container gets restarted daily by Kubernetes due to to Out of Memory exception.
Tested on newer Operator v3.6.0 since I originally opened this issue.

Seems to be fixed by #308.


Set up eslint and prettify

+1 on this.
We find that combining Our Friend (which is what we call Claude 3.5 sonnet v2) with linters sorts out a lot of the weird issues that are sometime introduced when getting Claude to work on a large codebase.
We make heavy and automated use of -fix aligned to a set of linting and formatting rules for typescript and python and it works crazy well, giving Claude the ability to consistently interact with and build huge, complex codebases in a way we've just not seen from the other LLM's.
I think (somehow) baking in:

eslint
ruff
Prettier

... makes a lot of sense, but I'm not familiar enough with MCP yet to make a meaningful suggestion on how to do it.

Ah, sorry, this was specifically with the servers repo in mind—so when folks make PRs here, we don't get a bunch of noisy formatting changes 😄
If you're thinking there should be some broader MCP + linting/formatting thing, would love to discuss!


[BUG]: An unexpected error has occurred: encountered unexpected object in initial state

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
Node was syncing and upon return, it appeared to no longer be connected to any peers. I exited gracefully and upon restart, caught this error.
Logs attached.
Logs.zip
Expected behavior
No response
Steps to reproduce
No response
Environment
- OS:
Ubuntu 20.04 LTS

Anything else?
No response

Closed by koinos/koinos-state-db-cpp#2


Algorithm

How will we perform algorithm part for this HW? Do we use QC to perform the Algorithm?

We can use the quantum computer or any other platform like Google Collab or so on...

So basically for this question, I dont think it is quantum related like the previous one.


direnv tries to run bash from $PATH

Describe the bug
Installing direnv without having bash in $PATH makes the shell throw errors on every command
To Reproduce
Steps to reproduce the behavior:

No bash executable in $PATH
nix-env -i direnv
Do anything in the shell

Expected behavior
Direnv works regardless of presence of bash in $PATH.
Notify maintainers
@zimbatm
Metadata

system: "x86_64-linux"
host os: Linux 4.19.84-microsoft-standard, Alpine Linux, noversion
multi-user?: no
sandbox: yes
version: nix-env (Nix) 2.3.4
channels(root): ""
channels(akho): "home-manager, nixpkgs-20.09pre226586.571212eb839"
nixpkgs: /home/akho/.nix-defexpr/channels/nixpkgs

Putting
export DIRENV_BASH=$(nix eval -f ~/.nix-defexpr/channels/nixpkgs --raw bash)

in .zshrc before
eval "$(direnv hook zsh)"

solves this for me (but does not look like something I should have to have).

thanks for the report!

Thank you! That was very quick.


How to bind 3 inputs using mxnet.io.NDArrayIter?

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Ubuntu 14.04
Compiler:python 2.7
Package used (Python/R/Scala/Julia):python
I want to feed the convolution net with triple input: image, annotation, label. According to #2929, I define the input using mxnet.io.NDArrayIter as:
import mxnet as mx
import numpy as np

train = mx.io.NDArrayIter(data=np.zeros((120000, 3, 224, 224), dtype='float32'),
    label={'label1': np.zeros((120000, 81), dtype='int8'),
    'label2': np.zeros((120000, ), dtype='int8')},
    batch_size=10)

However, I got an error: include/mxnet/./tensor_blob.h:742:check failed: (this->shape_.Size())==(shape.size()) TBlob.get_with_shape: new and old shape do not match total elements   and
TypeError: Invalid type'<type 'numpy.ndarray'> for data, should be NDArray or numpy.ndarray'
Does it means data and label should match in shape? And how can I feed triple input (one data and two kinds of label) to network?

I didn't get this error when running your code. Is this error arise from the latter codes? Basically you can use a list or a dict of ndarray for both data and label. http://mxnet.io/api/python/io.html#mxnet.io.NDArrayIter

@kevinthesun I make a script only these codes above, it still reports this error

@fungtion Can you paste the full traceback message for your error?

@kevinthesun This is the traceback message:
/home/wfx/mxnet/dmlc-core/include/dmlc/logging.h:235: [07:54:27] include/mxnet/./tensor_blob.h:742: Check failed: (this->shape_.Size()) == (shape.Size()) TBlob.get_with_shape: new and old shape do not match total elements
Traceback (most recent call last):
  File "/home/wfx/PycharmProjects/kb/mxnet_triple_input/tmp.py", line 7, in <module>
    train = mx.io.NDArrayIter(data=np.zeros((120000, 3, 224, 224), dtype='float32'),label={'label1': np.zeros((120000, 81), dtype='int8'), 'label2': np.zeros((120000, ), dtype='int8')},batch_size=10)
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.7.0-py2.7.egg/mxnet/io.py", line 420, in __init__
    self.data = _init_data(data, allow_empty=False, default_name='data')
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.7.0-py2.7.egg/mxnet/io.py", line 391, in _init_data
    "should be NDArray or numpy.ndarray")
TypeError: Invalid type '<type 'numpy.ndarray'>' for data, should be NDArray or numpy.ndarray

Process finished with exit code 1

I have implement triple input when doing image retrieval using triplet loss. I used DataIter instead of NDArrayIter, the followed code maybe give you a hint:
class DataBatch(object):
    def __init__(self, data, label):
        self.data = data
        self.label = label

class DataIter(mx.io.DataIter):
    def __init__(self, names, batch_size):
        super(DataIter, self).__init__()
        self.provide_data = [('same', (batch_size, 3, HEIGHT, WIDTH)),('diff', (batch_size, 3, HEIGHT, WIDTH)),('one', (batch_size, ))]
        self.provide_label = [('anchor', (batch_size, 3, HEIGHT, WIDTH))]
        self.started = True
        self.q = multiprocessing.Queue(4)
        self.pws = [multiprocessing.Process(target=self.write,) for i in range(2)]
        for pw in self.pws:
            pw.start()

    def write(self):
        while True:
            if not self.started:
                break
            batch = self.generate_batch(self.batch_size)
            batch_anchor = [x[0] for x in batch]
            batch_same = [x[1] for x in batch]
            batch_diff = [x[2] for x in batch]
            batch_one = np.ones(self.batch_size)
            data_all = [mx.nd.array(batch_same, ctx=dev), mx.nd.array(batch_diff, ctx=dev),mx.nd.array(batch_one, ctx=dev)]
            label_all = [mx.nd.array(batch_anchor, ctx=dev)]
            data_batch = DataBatch(data_all, label_all)
            self.q.put(data_batch)
    def next(self):
        if self.q.empty():
            logging.debug("waiting for data")
        if self.iter_next():
            return self.q.get(True)
        else:
            raise StopIteration

@fungtion Is your mxnet package updated version? Since I have no problem to run your code. Also the traceback shows the exception position is in line 391 of io.py, which should be in line 397 in current version.

@shuokay Thank you, I will try it later

@kevinthesun I am sure that the path is the correct, and other operations I used in mxnet works well except this one. Can it be the problem of gcc, because I used gcc-4.8.2.

@fungtion I'm wondering why traceback reported error at line 391 at io.py. This exception should be at line 397.

@kevinthesun I tried this script in another machine with latest mxnet version, it worked without any problem. So I think there may be some problems about my compilation.

@kevinthesun I reduce the numpy array size to 12000, it runs without error, but if I increase to 120000, it still report that error

@shuokay where is the function generate_batch?

I met the same error with newest mxnet version.
Here is my code to generate the error:
t1=mx.nd.array(np.zeros((12000, 3, 224, 224), dtype='float32'))
t2=mx.nd.array(np.zeros((120000, 3, 224, 224), dtype='float32'))
t1 is fine, but t2 will produce error msg like this:
MXNetError                                Traceback (most recent call last)
 in ()
----> 1 t2=mx.nd.array(np.zeros((120000, 3, 224, 224), dtype='float32'))
/home/yaping/mxnet/python/mxnet/ndarray.pyc in array(source_array, ctx, dtype)
1121             raise TypeError('source_array must be array like object')
1122     arr = empty(source_array.shape, ctx, dtype)
-> 1123     arr[:] = source_array
1124     return arr
1125
/home/yaping/mxnet/python/mxnet/ndarray.pyc in setitem(self, in_slice, value)
269                 _internal._set_value(float(value), out=self)
270             elif isinstance(value, (np.ndarray, np.generic)):
--> 271                 self._sync_copyfrom(value)
272             else:
273                 raise TypeError('type %s not supported' % str(type(value)))
/home/yaping/mxnet/python/mxnet/ndarray.pyc in _sync_copyfrom(self, source_array)
342             self.handle,
343             source_array.ctypes.data_as(ctypes.c_void_p),
--> 344             ctypes.c_size_t(source_array.size)))
345
346     def _slice(self, start, stop):
/home/yaping/mxnet/python/mxnet/base.pyc in check_call(ret)
73     """
74     if ret != 0:
---> 75         raise MXNetError(py_str(_LIB.MXGetLastError()))
76
77 if sys.version_info[0] < 3:
MXNetError: [10:06:08] include/mxnet/././tensor_blob.h:243: Check failed: this->shape_.Size() == shape.Size()<PHONE_NUMBER>0 vs. 883490816) TBlob.get_with_shape: new and old shape do not match total elements
Another weird thing:
when I change the dtype from "float32" to "int32", t1 is still fine. but t2 never finished or throw error msg.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!

I just got this issue -

TypeError: Invalid type '<type 'numpy.ndarray'>' for x_2, should be NDArray, numpy.ndarray or h5py.Dataset

I only seem get it when my array is > certain number of elements. I reduce my array size and the code seems to run fine. Is the suggested solution to write my own DataIter?

I am also using a network architecture like OP which takes in 2 streams as input.

@apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage.
For general "how-to" questions, our user forum (and Chinese version) is a good place to get help.

Hey @anjishnu thanks for submitting the issue. Were you able to resolve it?

Close this issue due to the inactivity. Please feel free to reopen this if you are still facing the same problems.


Add support for entity_autocomplete form element in autocomplete

When using @FormElement to autocomplete form elements, the entity_autocomplete element is missing.
The scraper needs to add /core/lib/Drupal/Core/Entity/Element/ to include it.
thanks,
-mike

Seems our scraper is not scanning the directory where the entity_autocomplete element is defined:
export async function getElementFiles(version) {
	return new Promise((res) => {
		find.file(`tmp/drupal-${version}/core/lib/Drupal/Core/Render/Element/`, (file) => {
			const filtered = file.filter((filename) => filename.endsWith('.php'));
			res(filtered);
		});
	});
}

Might be worth scanning /core/lib/Drupal/Core/*/Element/

Nudge (pretty please.)

So impatient

Heh - indeed.
I have no idea if the pull request will work (no idea if wildcards are allowed.) In fact, I did it during a module development class I was teaching. 🤞🏼
thanks,
-mike

I'll take a look - updating to include 10.3 and 11.0 first

I see that this was added to the 2.2 release, but for whatever reason, it suggests incorrect code ☹
The main issue is that the #type should be entity_autocomplete, but Drupal Smart Snippets is showing and providing entityautocomplete (no underscore.)

Here's the code snippet (completion) it provides:
      '#type' => 'entityautocomplete',
      '#title' => t(''),
      '#title_display' => 'before',
      '#description' => t(''),
      '#required' => TRUE,
      '#target_type' => '',
      '#tags' => '',
      '#default_value' => '',
      '#selection_handler' => '',
      '#selection_settings' => '',
      '#autocreate' => '',
      '#process_default_value' => '',
      '#validate_reference' => '',

In fact, I think this is an issue for all Form elements (maybe render elements as well) that have underscores in their #type values. For example, Drupal Smart Snippets also outputs '#type' => 'contextuallinksplaceholder', when it should be '#type' => 'contextual_links_placeholder',. Sorry, not sorry. 😀
-mike

Looks like we're using the class's name cast to lowercase. We need to get the value of the .... annotation? idk what php calls that.
Drupal's code:
#[FormElement('entity_autocomplete')]
class EntityAutocomplete extends Textfield {
  // ...
}

Our scraper:
const name = classElement ? classElement.name.name.toLowerCase(): undefined;

Hopefully php-parser is able to get the string we need.


Added MutableCreationOptionsInterface to InvokableFactory

I've run into a problem where multiple calls to get('foo', $options) on a plugin manager are not setting the options on subsequent calls. I'm an using an alias to InvokableFactory, as recommended in the v2-v3 migration docs.
This PR addresses that for v2 by adding the MutableCreationOptionsInterface to InvokableFactory.
Note that this only works when the plugin manager has been marked $shareByDefault = false. I am unable to determine if that is expected behaviour.

Sigh. This might work for InvokableFactory where we can have different versions in v2 and v3, but not for other packages: MutableCreationOptionsInterface has been removed in v3.
Any suggestions?

Nooooo not this one ;(. Don't bring back this one.
Any way, you need to call build instead of get to create new instances at each call.

@bakura10  Unfortunately SM2 doesn't have a build method. I'm trying to make this forward compatibility thing work.

Right, for forward compatibility I've changed AbstractServiceManager to duck-type the old MutableCreationOptionsInterface. If found it sets the creationOptions on the factory. The migration process is now:

If your factory implements MutableCreationOptionsInterface, remove the interface from the class but leave the setCreationOptions() method. This will ensure the factory works in both v2 and v3.
Post migration remove setCreationOptions() and createService() methods

Not pretty, but the best I can think of.

/me want to create a v4 without compatibility :o.

Y'know after struggling with this for the last few days I couldn't agree more :)

Note that this only works when the plugin manager has been marked $shareByDefault = false. I am unable to determine if that is expected behaviour.

It is. If $shareByDefault is enabled, then only the options that are passed for the first retrieval will be honored.

/me want to create a v4 without compatibility

Migration is important. But the nice part is that we only have to think about the current major version to the next, so it should only come up rarely.

@bakura10 Also, this is not bringing back the MutableCreationOptionsInterface; this PR is against the release-2.7 branch. ;-)


Lower dependabot dependency update rate

Can we configure dependabot to update dependencies e.g. once per month, to lower the amount of commits on main?

You can lower that, and also group the dependencies to create one PR for all dependencies to update,
see documentation here
and scheduling interval is configured here


Hellinger distance not recognized as metric in v0.4.0

I installed umap-learn 0.4.0 and would like to try some of its new features, including document embedding with the hellinger distance and embedding on a sphere with the haversine distance. When I try to follow the documentation examples I get the following errors:

When trying to use the hellinger distance with metric='hellinger'
ValueError: Unknown metric hellinger.

When following the 'embedding to non-euclidean spaces' tutorial I get the following error:
TypeError: init() got an unexpected keyword argument 'output_metric'

It seems like my install does not include any of the new v0.4.0 features for some reason.

I am going to answer my own problem here. Apparently you can overcome this by cloning the repo, entering into it, and 'running pip install .'. These newer changes must not be in the pip distribution.

I see this is closed, but I'm getting the same error even when installing from the current master branch.
``
ValueError                                Traceback (most recent call last)
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/umap_.py in fit(self, X, y)
1696                 _m = self.metric if self._sparse_data else self._input_distance_func
-> 1697                 dmat = pairwise_distances(X[index], metric=_m, **self._metric_kwds)
1698             except (ValueError, TypeError) as e:
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/sklearn/metrics/pairwise.py in pairwise_distances(X, Y, metric, n_jobs, force_all_finite, **kwds)
1712                          "Valid metrics are %s, or 'precomputed', or a "
-> 1713                          "callable" % (metric, _VALID_METRICS))
1714
ValueError: Unknown metric hellinger. Valid metrics are ['euclidean', 'l2', 'l1', 'manhattan', 'cityblock', 'braycurtis', 'canberra', 'chebyshev', 'correlation', 'cosine', 'dice', 'hamming', 'jaccard', 'kulsinski', 'mahalanobis', 'matching', 'minkowski', 'rogerstanimoto', 'russellrao', 'seuclidean', 'sokalmichener', 'sokalsneath', 'sqeuclidean', 'yule', 'wminkowski', 'nan_euclidean', 'haversine'], or 'precomputed', or a callable
During handling of the above exception, another exception occurred:
TypingError                               Traceback (most recent call last)
 in
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/umap_.py in fit_transform(self, X, y)
1958             Embedding of the training data in low-dimensional space.
1959         """
-> 1960         self.fit(X, y)
1961         return self.embedding_
1962
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/umap_.py in fit(self, X, y)
1703                         X[index].toarray(),
1704                         metric=self._input_distance_func,
-> 1705                         kwds=self._metric_kwds,
1706                     )
1707                 else:
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/distances.py in pairwise_special_metric(X, Y, metric, kwds)
1255             return metric(_X, _Y, *kwd_vals)
1256
-> 1257         return pairwise_distances(X, Y, metric=_partial_metric)
1258     else:
1259         special_metric_func = named_distances[metric]
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/sklearn/metrics/pairwise.py in pairwise_distances(X, Y, metric, n_jobs, force_all_finite, **kwds)
1750         func = partial(distance.cdist, metric=metric, **kwds)
1751
-> 1752     return _parallel_pairwise(X, Y, func, n_jobs, **kwds)
1753
1754
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/sklearn/metrics/pairwise.py in _parallel_pairwise(X, Y, func, n_jobs, **kwds)
1346
1347     if effective_n_jobs(n_jobs) == 1:
-> 1348         return func(X, Y, **kwds)
1349
1350     # enforce a threading backend to prevent data communication overhead
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/sklearn/metrics/pairwise.py in _pairwise_callable(X, Y, metric, force_all_finite, **kwds)
1373         iterator = itertools.combinations(range(X.shape[0]), 2)
1374         for i, j in iterator:
-> 1375             out[i, j] = metric(X[i], Y[j], **kwds)
1376
1377         # Make symmetric
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/numba/dispatcher.py in _compile_for_args(self, *args, **kws)
399                 e.patch_message(msg)
400
--> 401             error_rewrite(e, 'typing')
402         except errors.UnsupportedError as e:
403             # Something unsupported is present in the user code, add help info
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/numba/dispatcher.py in error_rewrite(e, issue_type)
342                 raise e
343             else:
--> 344                 reraise(type(e), e, None)
345
346         argtypes = []
~/miniconda3/envs/reproallthethings/lib/python3.7/site-packages/numba/six.py in reraise(tp, value, tb)
666             value = tp()
667         if value.traceback is not tb:
--> 668             raise value.with_traceback(tb)
669         raise value
670
TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Internal error at <numba.typeinfer.CallConstraint object at 0x132732250>.
missing a required argument: 'ind2'
[1] During: resolving callee type: type(CPUDispatcher(<function sparse_hellinger at 0x11c10ea70>))
[2] During: typing of call at .../miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/distances.py (1255)
Enable logging at debug level for details.
File "../../../miniconda3/envs/reproallthethings/lib/python3.7/site-packages/umap/distances.py", line 1255:
def _partial_metric(_X, _Y=None):
return metric(_X, _Y, *kwd_vals)
^
``

Did you previously uninstall the package before installing from master?

Is this a sparse dataset by any chance?

I think there is a tricky combination of sparse data, of a small enough size (small n_samples), that hits a corner case here. I'll see if I can fix it.

This patch resolved the issue for me -- does it work for you Amy?

Yes. Sparse data. ~3000 rows.
On Tue, Apr 7, 2020 at 18:27 Leland McInnes<EMAIL_ADDRESS>wrote:

I think there is a tricky combination of sparse data, of a small enough
size (small n_samples), that hits a corner case here. I'll see if I can fix
it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lmcinnes/umap/issues/395#issuecomment-610650791, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDA4UINAQSR6HJEJBGCE63RLOSBLANCNFSM4MDMWMCQ
.

Works for me!


GH Actions: Discord

This looks really handy!
https://github.com/marketplace/actions/actions-for-discord
Sent over a webhook to ivan for GraphiQL General. Other channels we will need would probably be support? Or should we send new issue notifications to a maintainers channel?

thanks @IvanGoncharov !


update readme with build executable instructions

Though Trivy is mentioned in the notes we would like to mention is as a Prerequisites.
Add build executable binary command
update the binary name in readme

Ishaan, i'm sorry about this, I didn't see these two before I made a ton of clean up work and pushed! Lets figure out if this is still needed, and resolve if so.


Is ans support capture and save nic packets?

I think you may add a save packets function before ans_send_burst and ans_eth_rx_burst in file ans_main.c

Another option could be https://github.com/dpdkcap/dpdkcap


Misc. Kconfig and testcase fixes and enhancements

This all is part of an attemp to cleanup tests and samples and increase
coverage of tests.

updated

The kw41z board should have ieee802154 marked in its HW support

Also, don't we have networking support on qemu_cortex_m3?

Also, don't we have networking support on qemu_cortex_m3?

via SLIP yes, but does it make sense to test on all QEMUs? We need to pick one and do the test via SLIP on one. This is pretty much the same and we are not testing HW features here, we are testing the IP stack. Dont care which we use, qemu_x86 was used sofar.

Lets see if @pfalcon has a feeling on testing net with qemu.  I know he's dealt with this and want to make sure the qemu works reasonable for it on any/all platforms that we support.

Well, ideally, we'd test both qemu_x86 and qemu_cortex_m3, to make sure there're no regressions in qemu_cortex_m3, because nobody likely uses it for testing ;-).
Otherwise, to run Zephyr sample with SLIP enabled in QEMU, there should be running daemons for SLIP/TAP conversion - at the very least. So, we can't run such tests using normal sanitycheck processing (and indeed, there're nos such tests), and fairly speaking, I don't know how to handle that at all (there can be various ideas of course). But that matter needs to be addressed somehow, as the net code is already complex, and complex refactors keep being applied to it (I just complained on that at https://github.com/zephyrproject-rtos/zephyr/pull/691#issuecomment-313415170), and there're no good way to regression-test them.


远程开锁/关锁

see RELEASE: v0.1.11
https://github.com/idreamshen/hass-volvooncall-cn/releases/tag/v0.1.11


Drawer does not respect the component hierarchy

Awesome job guys.  Been using this in beta, and so  far I'm quite pleased  with the changes in 1.0.   Works really well so far.
Noticing the drawer attaches itself outside of the hierarchy it was placed in and decides to attach itself to the top level of the dom.  This makes doing things like relative positioning to its containing element impossible (without hacks). This behavior might be convenient at first, but is relatively inconsistent.
This should instead be a child of the element it is placed in, and if I actually want it to be relative to the most outmost container, I would place it there, with explicit positioning via css overrides.
Seems like you can kind of overload this behavior via ModalProps and overriding the container, but seems like that won't work initially since the element seems like it has to already exist to override?  So you can get it to work, but then you'll need to do hackey things via refs and rerendering once the div has been mounted to the dom,  and that's always kind of tacky.
material-ui/core": "^1.0.0"

@BradfordMedeiros I think you didn't get the purpose of drawer component. It's modal component which can be called in any place in the tree and will be rendered strongly in one place inside user viewport. If you want different behaviour you probably need a different component.
You can't position any component like this with only css. position: fixed won't work inside element with transform. So the only way is to render at the top of the tree.
Which functionality are you trying to achieve with drawer?

I want to be able to place a drawer inside another div.  Basically I have a custom appbar and I don't want it to cover the appbar.    Which seems like a pretty basic use case.  I don't want to use override fixed positioning for the drawer since the appbar can change height via user customizations and the drawer needs to respond to that

Noticing the drawer attaches itself outside of the hierarchy it was placed in and decides to attach itself to the top level of the dom.

@BradfordMedeiros This behavior is specific to the variant="temporary". This variant targets the mobile. The variants that target the desktop don't portal. You should be good. Have a look at our demos to get some inspiration.


Dynamically filter Document Library based on List/Library Tile selection

Category

[x] Question
[ ] Typo
[x] Additional article idea

Question
For an OOTB modern site page, I know you can dynamically filter the contents of a Document Library part, based on the filter value of a user's selection in a separate List part. You can also customize the List part with JSON to appear as fancy tiles. I'd like the user to click the tile containing their filter value, then see the document library dynamically filter.
How do you use the JSON to specify the List tile's selection action? Making clicking the tile similar to selecting the radial button in a list view?
At the moment, my list tiles don't do anything when clicked. Using the tile view essentially breaks the connected filtering of the Document Library.
How to filter connected list/document library web parts using list view JSON formatting?

@Bhushan12986 Can you share the JSON used int Tiles/Gallery View?
The selection post formatting works exactly like it works before formatting. You do have the flexibility to disable selection if you want.
In the scenario above, if you haven't disabled selection, you would see the radial button on the right top of the card in your Gallery View -


Use OOP to simplify code

First and foremost, it's amazing to see a 14 year old writing a library. Keep up the good work, this is a great beginning! I hope this project gets traction, it could be very useful for school/college students for their maths assignment.
In terms of the code, there are a few ways you could improve them. Making a polynomial class is probably more efficient and scalable than writing a function for every degree.
How to write such class can be found at https://www.python-course.eu/polynomial_class_in_python.php
TLDR : See the code below (taken from the page above)

import numpy as np
import matplotlib.pyplot as plt

class Polynomial:

    def __init__(self, *coefficients):
        """ input: coefficients are in the form a_n, ...a_1, a_0
        """
        self.coefficients = list(coefficients) # tuple is turned into a list

    def __repr__(self):
        """
        method to return the canonical string representation
        of a polynomial.

        """
        return "Polynomial" + str(self.coefficients)

    def __call__(self, x):
        res = 0
        for coeff in self.coefficients:
            res = res * x + coeff
        return res

    def degree(self):
        return len(self.coefficients)

    def __add__(self, other):
        c1 = self.coefficients[::-1]
        c2 = other.coefficients[::-1]
        res = [sum(t) for t in zip_longest(c1, c2, fillvalue=0)]
        return Polynomial(*res)

    def __sub__(self, other):
        c1 = self.coefficients[::-1]
        c2 = other.coefficients[::-1]

        res = [t1-t2 for t1, t2 in zip_longest(c1, c2, fillvalue=0)]
        return Polynomial(*res)

    def derivative(self):
        derived_coeffs = []
        exponent = len(self.coefficients) - 1
        for i in range(len(self.coefficients)-1):
            derived_coeffs.append(self.coefficients[i] * exponent)
            exponent -= 1
        return Polynomial(*derived_coeffs)

    def __str__(self):

        def x_expr(degree):
            if degree == 0:
                res = ""
            elif degree == 1:
                res = "x"
            else:
                res = "x^"+str(degree)
            return res

        degree = len(self.coefficients) - 1
        res = ""

        for i in range(0, degree+1):
            coeff = self.coefficients[i]
            # nothing has to be done if coeff is 0:
            if abs(coeff) == 1 and i < degree:
                # 1 in front of x shouldn't occur, e.g. x instead of 1x
                # but we need the plus or minus sign:
                res += f"{'+' if coeff>0 else '-'}{x_expr(degree-i)}"
            elif coeff != 0:
                res += f"{coeff:+g}{x_expr(degree-i)}"

        return res.lstrip('+')    # removing leading '+'

Oh so instead of hardcoding each polynomial function, it's getting a few points from each polynomial and plotting them which makes the code a lot more efficient.
Thank you for this idea, I'll try and implement it when I have time next.


Fix dump command

Fix #6310
The TableName() method defined on pointer receivers is not invoked by Xorm. Change method receivers to non-pointer receivers.

Codecov Report

Merging #6385 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6385      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.02%
==========================================
  Files         365      365
  Lines       51360    51360
==========================================
- Hits        19957    19951       -6
- Misses      28530    28537       +7
+ Partials     2873     2872       -1

Impacted Files
Coverage Δ

models/oauth2_application.go
54.83% <100%> (ø)
:arrow_up:

models/unit.go
0% <0%> (-14.29%)
:arrow_down:

routers/repo/view.go
41.08% <0%> (-1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78cbbc...7763409. Read the comment docs.

I think @sapk is right. This PR will not work. I will send another PR to fix that.

Thank you for your quick response. The new PR is awesome, and I will close this one.

@kerie  Anyway, thank you for your help!


make_public_query_size

https://github.com/pytorch/vision/issues/7785#issuecomment-2382741248
pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]

pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]

Thanks for the initial PR @venkatram-dev . Note that tests were failing for different reasons, the main one being that query_size was imported from the wrong module (I assume your code changed since you last tested?)
I fixed and cleaned up the tests, added some more test cases, and exposed a few more utils. Thank you!


Excessive logging of failed sends

Yesterday during a strange network glitch unbound started streaming 30mbps of syslog messages from my tiny home OpenWRT-based router...
The logs comes from this block:
https://github.com/NLnetLabs/unbound/blob/226d66ca9258c4e47b1e549ef9ab5e12c4925771/util/netevent.c#L373-L384
You will see more details on the issue, including logged messages, in this bug report: https://github.com/openwrt/packages/issues/11904
Unless there is a better way to rate-limit these messages I think raising the verbosity level for these could be considered.

Posted on https://github.com/openwrt/packages/issues/11904 as well, but this might be related to #35?

please see how openwrt/packages#12141 has resolved this

@wcawijngaards this is still an issue in Unbound 1.12.0

This should have been fix with https://github.com/NLnetLabs/unbound/commit/addd21f750b6042c40c2a92aef9b8919d8497532.
It squelches the permission denied errors on the lower verbosity levels.
Will be part of the upcoming 1.13.2 release.


[SMALLFIX] Clean up in the test module

Minor fixes in the test module.
KeyValueSystemIntegrationTest: Introduced automatic resource management in try statement.
FileSystemRenameIntegrationTest: Fixed deprecation.
FileSystemStatisticsTest: Fixed deprecation.
DFSIOIntegrationTest: Added documentation.
FileSystemMasterIntegrationTest: Removed explicit argument type and simplified exception handling.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10340/
Test PASSed.

Merged build finished. Test PASSed.

@HorizonNet Thanks for the improvements! I left a couple comments on the code

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10350/
Test PASSed.

LGTM


Can't open example project

Can't get the example project to work in Godot 3.2.4 RC4. It complains about missing dependencies (e.g. no res://example/textures folder).
To Reproduce
Steps to reproduce the behavior:

Download zip of the repo
Import project.godot into godot
Open project and try to open any of the scenes

Expected behavior
Project should open correctly and show the addon in action.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Godot Version 3.2.4 RC4
Cartographer Version 0.9.0

Also doesn't work with downloading the zip from the releases.

Did you download the texture assets pack linked to in the release notes?

Ah, should've RTFM. Thanks!

No worries.


TUP-25202 can't get ambari configuration when I select retrieve it fromjob server

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TUP-25202
What is the new behavior?
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

Pull request test result: failure :x:

Close this one since it not usefull now.


Hygieia dashboard view for only authenticated users

Hygieia allows any unauthenticated user to view the dashboard list without login first.
We want only authenticated users to view any data on hygieia dashboards otherwise users should be redirected to login page first.

What is the issue for anyone being about to view dashboards?

We have to implement RBAC to view dashboards. So only authenticated users can view dashboards that they are authorized for.

@rstmna This feature is not available currently and we have not received enough requests for such a need. However since this is specific to your needs you are free to make modifications to the source code per your needs and use it.


Cant move xp drops around freely.

Only snaps to green boxes, was able to move around entire screen before.

I introduced this bug with last update to fix another positioning bug. Need to look into it. Thanks for the report.

Ah okay.  Thanks for the reply.

having this issue as well! appreciate you looking into it. the only way i've figured out how to fix it for the time being is attaching it to target/player and playing with the x/y offsets to place it where i had it previously. its a little awkward but it'll get the job done until a fix is put in :)

Should be fixed now. Unfortunately this overlay does not remember position when you toggle between attach and not attach and will default back to top right when set back to not attached but I didn't consider that too big of a problem.


Add new override instructions for lab components

[x] I have followed (at least) the PR section of the contributing guide.

Pull request for issue #21709

@eps1lon I didn't get what you wrote :( Where do you suggest to add it?

Link to https://material-ui.com/components/about-the-lab/#typescript from  https://material-ui.com/customization/globals/#default-props and https://material-ui.com/customization/globals/#css

@eps1lon are you suggesting to add a reference to the typescript import explanation in the Default props and CSS override sections?

@eps1lon are you suggesting to add a reference to the typescript import explanation in the Default props and CSS override sections?

yes, thought your link to default props is the same as css override section. Use the links I mentioned.

So I don't think that import style ever worked. It's not a matter of fact Webstorm not supporting it as far as I can tell it's wrong. I can't even get it to be valid using the CLI.
Looking at the original PR in the typescript repo the valid syntax are:
import type T from './mod';
import type { A, B } from './mod';
import type * as Types from './mod';

export type { T };
export type { T } from './mod';

I can use this syntax:
import type { MuiTreeItem } from '@material-ui/lab/themeAugmentation';
But after type checking this I get these errors:

I don't know much about our theme and typescript so I can't really test any further without help.

@cjoecker Thanks


feat: Upstream more DiscrTree APIs

while working on https://github.com/leanprover/lean4/pull/2577 I noticed
that functions on DiscrTrees are scattered throughout std4, aesop and
mathlib4. This PR upstreams those functions look at the internals of
DiscrTree, in particular

mapArrays from mathlib
https://github.com/leanprover-community/mathlib4/blob/c00742dc87c9656c6a5502317d75344c0284751b/Mathlib/Lean/Meta/DiscrTree.lean#L79-L81
filterFoldM from aesop
https://github.com/JLimperg/aesop/blob/831865d91f9dcc8ef9295d6d6053606766cdb6a3/Aesop/Util/Basic.lean#L123-L138
(renamed to put the Trie/DiscrTree into the namespace)

The other function in mathlib that operate on DiscrTree, is a reimplementation of .values.
Also drop the reimplementation .elements in std4.
Collecting all operations in one place not only avoids such reimplementations (hopefully), but
also makes it easier to refactor the internals of the data structure.

While appreciating that the Std PR queue is slow, it's helpful if PRs are labelled when they are ready for review. Contributors can write a comment containing just awaiting-review or awaiting-author or WIP in order to switch between these labels.

awaiting-review

I updated tags to reflect discussion mentioning #332.


TASK [flannel : Load the flannel config file into etcd] , fails

hello
i get this error , what do i need to take a look at please?
TASK [flannel : Load the flannel config file into etcd] ******************************************************************************************************************************************************
fatal: [centos-atomic-01 -> None]: FAILED! => {"changed": true, "cmd": "/usr/bin/etcdctl --no-sync --peers=http://centos-atomic-02:2379 set /cluster.local/network/config < /tmp/flannel-conf.json", "delta": "0:00:00.046901", "end": "2017-05-11 14:36:23.550022", "failed": true, "rc": 4, "start": "2017-05-11 14:36:23.503121", "stderr": "Error:  client: etcd cluster is unavailable or misconfigured; error #0: dial tcp: lookup centos-atomic-02: no such host\n\nerror #0: dial tcp: lookup centos-atomic-02: no such host", "stderr_lines": ["Error:  client: etcd cluster is unavailable or misconfigured; error #0: dial tcp: lookup centos-atomic-02: no such host", "", "error #0: dial tcp: lookup centos-atomic-02: no such host"], "stdout": "", "stdout_lines": []}

It looks to me like the hostnames don't resolve inside the individual nodes.  How are those hostnames being assigned?

i edited /etc/hosts in all nodes and the problem went away


Error on deleting user

It looks like the wrong user is getting deleted, see this video. https://www.pjjk.net/temp/DESMVids/simplescreenrecorder-2024-04-10_12.54.27.mkv
To reproduce, on gopher, log in as an admin. Add an org with two mappers to a profile. Delete one of those mappers (I deleted the first, haven't tested with deleting the other).
Expected behaviour: the mapper being deleted disappears from the system.
Observed behaviour: the tab for mapper that was deleted disappears but the data for that mapper remains under the tab for the one that wasn't deleted.... and (not shown in the video) this gets autosaved.  Net result, the wrong mapper is deleted.

Looks good now. Thank you for the quick resolution.


[5.2.1] Upgrade Azure.Identity version to 1.11.1

This ports changes from #2462 to 5.2

Can probably push up to 1.11.2 to match the original PR as well.


TestResults folder names are now cross platform compatible, as per #678

I ran into the issue in #678 today, so we wanted to contribute a fix for it. I'm happy to revise if I've not followed the contributor guidelines.

@JasonMurrayCole, thanks for the contribution, we'll be reviewing this.


fix SpiderMultusConfig ValidatingWebhookConfiguration

There's a bug in the SpiderMultusConfig ValidatingWebhookConfiguration
Signed-off-by: Icarus9913<EMAIL_ADDRESS>What this PR does / why we need it:
fix bug
Which issue(s) this PR fixes:
close #2066

@ty-dc please fix the e2e

@ty-dc please fix the e2e

/cc @Icarus9913 #2071

how about this pr


Issue with README.md

In the README.md file you can find this code:
dependencies {
    # Single target that includes all FirebaseUI libraries
    compile 'com.firebaseui:firebase-ui:0.4.1'

    # FirebaseUI Database only
    compile 'com.firebaseui:firebase-ui-database:0.4.1'

    # FirebaseUI Auth only
    compile 'com.firebaseui:firebase-ui-auth:0.4.1'
}

but Gradle uses // for comments, not # :smiley:

@Nicofisi nice catch, thanks!


Add support for RFC7797 unencoded payloads

This adds support for RFC7797 and addresses https://github.com/jwt/ruby-jwt/issues/309
Here is the specification: https://www.rfc-editor.org/rfc/rfc7797
Happy to receive feedback and would love to get this released soon as I need it for my current project.

Hi guys, this feature is quite common, will be good to have this supported.

Hi guys, this feature is quite common, will be good to have this supported.

Thanks for you suggestions. I will try to find time to push up some updates soon.


Fix for user being logged out

Fixes issue where if call to fetch plugins returns 401, the user is logged out.
Should address (some) issues we're seeing with e2e test failures.

Codecov Report
Base: 36.90% // Head: 36.57% // Decreases project coverage by -0.33% :warning:

Coverage data is based on head (97216a8) compared to base (9079078).
Patch coverage: 7.50% of modified lines in pull request are covered.

:exclamation: Current head 97216a8 differs from pull request most recent head ac9a77f. Consider uploading reports for the commit ac9a77f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7132      +/-   ##
==========================================
- Coverage   36.90%   36.57%   -0.34%
==========================================
  Files         977      978       +1
  Lines       17291    17324      +33
  Branches     4484     4479       -5
==========================================
- Hits         6382     6336      -46
- Misses      10909    10988      +79

Flag
Coverage Δ

e2e
47.19% <75.00%> (-0.39%)
:arrow_down:

merged
36.57% <7.50%> (-0.34%)
:arrow_down:

unit
5.29% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

shell/components/ExplorerProjectsNamespaces.vue
0.00% <ø> (ø)

shell/components/ResourceList/Masthead.vue
0.00% <ø> (ø)

...mponents/ResourceList/ResourceLoadingIndicator.vue
0.00% <ø> (ø)

shell/components/ResourceList/index.vue
0.00% <ø> (ø)

shell/components/SortableTable/index.vue
0.00% <ø> (ø)

shell/components/TypeDescription.vue
0.00% <ø> (ø)

shell/components/fleet/FleetClusters.vue
0.00% <ø> (ø)

shell/components/fleet/FleetRepos.vue
0.00% <ø> (ø)

shell/components/form/Command.vue
100.00% <ø> (ø)

shell/components/form/EnvVars.vue
100.00% <ø> (ø)

... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Invisible w/ Optifine

Pipes, wires, & redstone components were invisible when optifine was added with the mod.

OptiFine tends to break things. If Chisels & Bits stuff is also invisible,
it's an MCMultiPart/OptiFine bug, if not...
2016-01-18 3:00 GMT+01:00 WenXin20<EMAIL_ADDRESS>
Pipes, wires, & redstone components were invisible when optifine was added
with the mod
—
Reply to this email directly or view it on GitHub
https://github.com/asiekierka/CharsetMC/issues/36.

I used both chisel and bits and your mod, and the bits from chisels and bits were visible, but not the pipes from the charset mod

In the same block space?

Yes, and only the chisel bits were visible

And the stuff from the charset mod were invisible when by itself as well.

Does disabling Fast Render help?

No

Will not be looked at for 1.8.9 as it is being abandoned. If the issue re-occurs on 1.9, please let me know.


x/build: add solaris amd64 release builder to dashboard

A new host key for host-solaris-oracle-amd64-oraclerel was generated; the builder needs to be added.  I will submit the change shortly.

Any changes needed?  The builder is up and running.


Implement cast from array to varchar

CLI renders arrays like Java List: [e1, e2, ...].
This functionality could be also available in engine, in the form of a cast from array(e) to varchar.

Is there a reason to not use cast to JSON?

The CLI rendering was more of an accident that worked well enough. The CLI gets the JSON converted to Java objects, then does toString() on them, so you get the Java format. Since it's intended for debugging, it has problems:
presto> select array['f, oo', 'bar'];
    _col0
--------------
 [f, oo, bar]
(1 row)

I've definitely thought about having a cast to varchar for structural types, and thought about it again for the format function, but it comes back to the question of what the format should be. @dain had a good point that a cast is typically reversible. Explicitly casting to JSON avoids this problem because it has a well defined format. The downside is that the syntax is complex:
presto> select json_format(cast(array['f, oo', 'bar'] as json));
      _col0
-----------------
 ["f, oo","bar"]
(1 row)

The output is also less readable than the Java variant. I see the usefulness in such a feature, but I'm not sure that cast to varchar is the right way. One thought is the format function could do this for structural types (currently it uses the cast to varchar operator which won't exist for these).

json_format(cast(... as json)) is what I ended up doing.
Since it's not clear whether we want this or not, let me close the issue for now.

What if we changed json_format(JSON):varchar to json_format(T):varchar where there exists cast(T):JSON?


Custom connectors : Unable to fetch custom connectors actions with the connector name with SOAP pass-through

Describe the Bug with repro steps
1.Create a Logic App custom connector
2.Click on the edit on the connector
3.Click on the SOAP radio button, show 2 Call mode "SOAP to REST", "SOAP pass-through" in dropdown list.
4.Select SOAP pass-through call mode.
5.The general information section, security tab, definition tab should have values from Expected result. Update the general information tab
6.Select the scheme as HTTP and add the host and the base file as below from the fazio service.
7.Click on the update connector, it should be saved successfully.
8.Create a logic app, add a trigger "When a HTTP request is received", add an action with the connector name. It should show the actions available under definition above.
Expected: Look up actions with the connector name should show the actions available under definition.
Actual: Unable to fetch custom connectors actions with the connector name with WSDL file
What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos

Browser
Edge
Additional context
Version: 0.2022.1.764

closing for: https://github.com/Azure/LogicAppsUX/issues/5787


Add capabilities to monitor the health of the services

Instead of trying to minotor the health of a container, we should monitor the health of a task (https://docs.docker.com/engine/swarm/how-swarm-mode-works/swarm-task-states/).
cAdvisor provides the corresponding metrics. It is more straightforward than trying to get a metric relative to the health of the containers which requires to export the metrics of the docker daemon. And this is not so smooth with Swarm (https://github.com/stefanprodan/swarmprom)

For now we decided to

Scrape docker engine metrics (#96) and add a rule to test failed healthchecks (https://github.com/swarmstack/swarmstack/blob/master/prometheus/rules/containers.yml#L7)
Provide a utility to check the docker events for died or unhealthy containers. This utility could be executed in the crontab.

feat: Add capabilities to monitor the health of the services (closed #78)


Modify UI of Todo App

I would like to modify UI of Todo app and also make it well responsive.

@urvashi-code1255 Please assign me this.

@Vedant-Rahane Whats the update ?

I am working on it. Will make PR today.

Sorry, Some work is remaining. I will make PR ASAP.


ajax.reload causes table to "flash" and doesn't keep responsive collapsed rows open.

Is there a way to stop the data from flashing on reload? I believe it is do to "processing" being TRUE or from "loadingRecords". Is there a way to disable this on additional reloads?
Also, on reload, if I use the responsive plugin and click the ( + ) button to see hidden data, on reload it closes again. is there a way to stop that and keep open rows open?

Can you post support questions in the DataTables forums with a link to a page showing the issue, as requested in the GitHub new issue form and the Contributing document. That allows issues to be searchable in a single location. Thanks.


Revert "Disable Sessions due to usage"

Reverts firebase/firebase-ios-sdk#10796

Merging to make it into code freeze


FPS Pistol Reload Animation Has Undesired Offset After Export from Blender

This has nothing to do with Godot.
I will literally cry if I work on this anymore. I can't for the love of god figure this out.
Steps to View Issue

Join the Blender Discord https://discord.gg/blender
Go to this message in the Discord https://discord.com/channels/185590609631903755/869803647826014279/1273851310470463599
The message has a video showing the issue with the .blend project file attached below
The issue happens at frame 14 / 15

I'm going to redo the entire pistol armature and animations from scratch again. As much as I don't want to do this, I don't see any alternative right now.

I redid everything.


Update to Node 16

Do the checklist before filing an issue:

[x] Is this related to the actions-rs Actions?
If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.community
[x] You've read the Contributing section about bugs reporting: https://github.com/actions-rs/.github/blob/master/CONTRIBUTING.md#reporting-bugs
[ ] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.

Description
Running this action in GitHub gives the following message:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/audit-check@35b7b53b1e25b55642157ac01b4adceb5b9ebef3

The URL given states that

Node 12 has been out of support since April 2022, as a result we have started the deprecation process of Node 12 for GitHub Actions. We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date.
To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

This repository seems to be unmaintained since 2020, so no idea of this will ever happen. We might have to fork the entire audit-rs suite and integrate it into some project that is maintained by more than one person.

@Finomnis There's discussion about the maintenance status in https://github.com/actions-rs/meta/issues/43

Have updated rustsec/audit-check to node16
It also uses the forked actions-rs/core from rinse-repeat/actions-rs-core
The dependencies were out of data as well and these have been bumped.


Deployment Test

Schedule
P1 - Wednesday March 20th
P2/P5 - Wednesday March 27th + 1/2 P5
P3/P5 - Wednesday April 3rd + 1/2 P5
P4 - Monday April 15th
Purpose
Deployment help us understand many things about an application and how the internet works.   Reviews of this event should be compiled and contain the following.

Docker - purpose and function of Docker with relationship to backend application.  Understanding this question will help you understand requirements and dependencies for setting up an application on the internet: ports, persistent data management, and python/pip dependencies.
Nginx - Purpose and function of Nginx with relationship to the internet and accessing your application.  Answering this question and understand Nginx configuration will help you understand how Applications are protected on the server from external attacks.
Route 53 - Purpose and function of DNS, how does DNS help in the process of finding our backend application.  Answering this question will teach you a lot about how content is found on the Internet.
Certbot - When a user accesses a website secured with an SSL certificate managed by Certbot, the workflow typically looks like?  Answering this question will teach you a lot about Public and Private key encryption.

https://kinetekenergy.github.io/blog/posts/Deployment-Quiz_IPYNB_2_/

https://github.com/IshanCornick/new_student/issues/3

Period 1
Mr Lopez
Aashray Rajagopalan
https://github.com/aashrayr/student2/issues/8

Abdullah Khanani
Period 2, Mortensen, CSP
Deployment Issue Link

Justin Liporada
P2 Mortensen
Issue Link

Lindsay Tang
P2 Mortenson
Issue Link

Hannah Reyes
P2 Mortensen
Issue Link

Aditya Desai
Period 2
Issue

Anagha Ashtewale
Period 2
Issue

Thank you to all the students that have posted above this line.
---------------⬆⬆⬆⬆⬆⬆⬆⬆⬆---------------------------

Sri Vaidyanathan S
Period 5 Lopez
Issue

Prakruti Bhatt
Per 2 Mortenson
https://github.com/RIFT24/cspquizbackend/issues/2#issuecomment-2023988467

Vibha Ganji
Period 2
Issue which was submitted yesterday

Ninaad Kiran
Period 2 Mortenson
Issue

Patrick Hastings
Per 2 Mortenson
link to issue

Torin Wolff
P2 Lopez
Link to Issues

Period 1
Mr. Lopez
Ishan Cornick
Issue

Lindsay Tang
Period 2 Mortenson
Issue

Avanthika Daita
Per 1 Lopez
Issue

Torin Wolff
Period 3 Lopez
Issue

Pranavi Vakkala
Period 3 Lopez
Issue

Akshay Nagesh
Period 3 Lopez
Issue

Sergi Serpukhovitinov
Period 3 Lopez
Issue

curl

secure

i did the work

Jason(Borui) Guan
Period 3 Lopez
Issue

Dante Atanassov
Period 3 Lopez
Blog

Ashwin Visvanath
Period 3 Lopez
Link to blog

Anusha Khobare
Period 5 Lopez
Link to Issue

ABby Albert
Period 3 Lopez
Issue

Grayson Guyot
Period 5 Lopez
Issue: https://github.com/Delta760/Student3/issues/5

Aditya Ramesh
Period 3 Lopez
Issue

William Lee
Period 4 Lopez
issue

Saaras Kodali
Period 4 Lopez
issue

Hanlun Li
Period 4 Lopez
https://github.com/hanlunli/student/issues/10

Rayyan Darugar
Period 1 Lopez
Deployment Issue

Imaad Muzaffer
Period 3 Lopez
Issue

Joshua Thinh
Period 1 Lopez
Deployment Issue

Anthony Yoo
Period 3 Lopez
Deployment Issue

Sai Talisetty
Per 3 Lopez
Issue

Srinivas Nampalli
Per 5 Lopez
issue

Miguel Villa Hernandez
Per 1 Lopez
Issue

Chris Park
Per 1 Lopez
issue