The provided environment.yaml is not supported for running codes.

Hi! Thanks for your pretty work, I'm afraid nowadays environment.yaml is not supported for the codes, could you please provide a new environment.yaml for current codes?

I have updated the README with information on environment setup. Please refer to it.
Thank you.


cmd/go2go: fuzzing triggers various crashes

What version of Go are you using (go version)?
My local go version used for the fuzzing:
$ go version
go version devel +4ba19b0188 Wed Jun 17 00:44:16 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes with a recent git checkout dev.go2go
What operating system and processor architecture are you using (go env)?
linux/amd64
What did you do?
I tried fuzzing the type  checker from the dev.go2go branch for a short period of time (roughly around 45 minutes) and was able to generate a variety of crashes.  Here are six samples.
I realize this is still early days, and I suspect it is much more useful to have crashes or panics from code that actual humans wrote, but posting these examples of crashes in case there is interest in hardending against more corner cases, or perhaps using some as test cases in the future.
I was running fzgo, which is a prototype of making fuzzing a first class citizen in the go command (#19109).
The engine underneath fzgo is a @dvyukov's go-fuzz. I can post the fuzz function later if interested, but it was a cut down and slightly tweaked fuzz function adapted from https://github.com/dvyukov/go-fuzz-corpus/tree/master/gotypes.
These all crash on the current go2goplay.golang.org:
Crash 1
go/types.(*Checker).instantiate
package main
type nt(type )interface{g}
type ph(type e nt,g(d))s
func(*ph(e,e))h(d)

http://go2goplay.golang.org/p/7Jk4PT9GX3k
Crash 2
go/types.optype
package main
type Numeric interface{t}
func t(type T Numeric)(s[]T){0(){s[0][0]}}

https://go2goplay.golang.org/p/46EZOUKBLLu
Crash 3
go/types.IsInterface
package main
type d*interface{d.p}

https://go2goplay.golang.org/p/HChlkK2A_Di
Crash 4
go/types.(*Interface).Complete
package main
type Numeric interface{t}
func t(type T Numeric)(s[]T){if(0){*s[0]}}

https://go2goplay.golang.org/p/TwoY4k9kR1w
Crash 5
math/big.(*Float).Mul
package main
func X(){7E700000000*0}

https://go2goplay.golang.org/p/avwOXp4HJrC
Crash 6
go/types.(*Checker).shift
package main
func X(){0<<7E6000000000}

https://go2goplay.golang.org/p/pv_BlSJ9v5W

(Side note: it would be nice to be able to issue commands like go test -fuzz=. ./... (#19109) on the stdlib and elsewhere ;-)

These are all non-urgent, but I agree the tools shouldn't crash. Will get to these eventually. If you find more similar crashes, please add to this issue, rather than creating many more.
Thanks for reporting!

Hi Robert, that makes sense, and will do.
Thanks for your work here!

I've got some more examples of some crashes that I found manually messing around with things, and this issue seemed like an appropriate place to put them.
panic: assertion failed
package main
type foo interface { bar() }
type x(type A) struct{ foo }
func main() { var _ foo = x(int){} }

https://go2goplay.golang.org/p/1VztHp6nDlp
fatal error: stack overflow
package main
type foo(type A) interface { type A }
func bar(type A foo(A))(a A) {}
func main() {}

https://go2goplay.golang.org/p/fX5PYaFHB1Z
internal compiler error: typecheck DCLFIELD
package main
type foo(type A) interface { type foo(A) }
func main() { var _ = new(foo(int)) }

https://go2goplay.golang.org/p/8-gvXzWvuky
This last one isn't necessarily a crash, but I don't know how to categorize it because it seems like some sort of unknown error class.
looping while expanding type
package main
type w(type A) struct{}
func (_ w(A)) Wrap() w(w(A)) { return w(w(A)){} }
func main() { var _ w(struct{}) }

https://go2goplay.golang.org/p/Vfv72Q_yFoS

Here's another one discovered by @zeebo while we were discussing gaining access to the runtime's map hasher functions:
Works fine in normal playground: https://play.golang.org/p/WWVqIxtH7b1
Crashes go2go playground: https://go2goplay.golang.org/p/WWVqIxtH7b1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x61ad46]

goroutine 1 [running]:
go/go2go.(*translator).translateBlockStmt(0xc00015b9b0, 0x0)
	/usr/local/go-faketime/src/go/go2go/rewrite.go:454 +0x26
go/go2go.(*translator).translateFuncDecl(0xc00015b9b0, 0xc0000c2230)
	/usr/local/go-faketime/src/go/go2go/rewrite.go:448 +0xc5
go/go2go.(*translator).translate(0xc00015b9b0, 0xc0000c2280)
	/usr/local/go-faketime/src/go/go2go/rewrite.go:376 +0x391
go/go2go.rewriteAST(0xc0000b0240, 0xc0000813b0, 0x0, 0x0, 0xc000081d10, 0xc0000c2280, 0x1, 0xc000081360, 0xc000081d10)
	/usr/local/go-faketime/src/go/go2go/rewrite.go:188 +0x109
go/go2go.RewriteBuffer(0xc0000813b0, 0x7ffcd64eedd8, 0x1e, 0xc0000f8000, 0x477, 0x677, 0x0, 0xc000086a20, 0xc0000869f0, 0xc0000869c0, ...)
	/usr/local/go-faketime/src/go/go2go/go2go.go:132 +0x2c5
main.translateFile(0xc0000813b0, 0x7ffcd64eedd8, 0x1e)
	/usr/local/go-faketime/src/cmd/go2go/translate.go:26 +0xa9
main.main()
	/usr/local/go-faketime/src/cmd/go2go/main.go:64 +0x2ea

Go build failed.

Here is another batch of crashes from fuzzing. (For numbering, I am treating the five from @zeebo and @mdlayher above as part of the numbering sequence, and hence am starting with 12 here).
This is still with:
go version devel +4ba19b0188 Wed Jun 17 00:44:16 2020 +0000 linux/amd64

Crash 12: panic: unreachable
go/types.(*Checker).assignment
package main
var u, i [func(u, c) {}(0, len)]c

https://go2goplay.golang.org/p/zZxlD1B7QpN
Crash 13: panic: internal error: final action list grew
go/types.(*Checker).processFinals
package main
type o(type T) func(*o([]T)) interface {
	T
	error
	error
}

https://go2goplay.golang.org/p/fUILIW9WD5E
Crash 14: fatal error: stack overflow
go/types.(*unifier).nify
package main
func F(type*T)(func(T)(T)){F(func(T)t{})}

https://go2goplay.golang.org/p/BaXFnTQjzE4
Crash 15: panic: assertion failed
go/types.makeSubstMap
package main
func y() { var a interface{ p() } = G(string){} }
type G(type X) s
func (G) p()

https://go2goplay.golang.org/p/R9gtjp611eP
Crash 16: panic: assertion failed
go/types.(*subster).typ
package main
type Foo(type T) r
func r(type T)() Foo((Foo(T)))

https://go2goplay.golang.org/p/pXrh7-AoAZi
Crash 17: panic: duplicate method c
go/types.(*Interface).Complete
package main
type Y interface{ c() }
type Z interface {
	c() Y
	Y
}
func F(type T Z)(T)

https://go2goplay.golang.org/p/Q9iDpXeF3u-
Crash 18: panic: nil typ
go/types.(*subster).typ
package main
type o(type T) []func(_ o([]_))

https://go2goplay.golang.org/p/cTESh52u3h6

Sorry, Crash 15 is probably a duplicate of @zeebo's first crash in https://github.com/golang/go/issues/39634#issuecomment-645545299, but I will leave it here regardless (including to avoid renumbering 😅)

Of the first batch, crashes 3, 5, and 6 are real. The others (1, 2, 4) don't crash anymore on dev.go2go. 3, 5, and 6 are unrelated to generics and may also crash in the regular type checker (try go vet on them). If so, please file individual bugs against the regular go/types package.

@zeebo Crashes 7, 8, 9, and 10 don't reproduce in dev.go2go with the type checker. I haven't tried the translator.

Hi @griesemer thanks for taking a look at these.
In case it is more convenient for you or otherwise helps, I put the fuzz-related failures from this issue here into a set of test cases, which you can see here:
https://play.golang.org/p/rtBwSht8Urf
4 of the 14 fail in go1.14.4, while the other 10 pass in go1.14.4. Here are the current results from the standard playground:
--- PASS: TestGoTypesGo2Go (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-1 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-2 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-3 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-4 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-5 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-6 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-12 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-13 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-14 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-15 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-16 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-17 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-18 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-19 (0.00s)
PASS

I haven't yet run them on the latest dev.go2go.

Hi @griesemer here is the state of crash/pass/skip in the latest commit on dev.go2go, using the fuzzing-originated unit tests I had placed in https://play.golang.org/p/rtBwSht8Urf (which is same playground link as immediately prior comment).
go version devel +6cf535a27b Fri Jun 19 04:37:09 2020 +0000 linux/amd64

dev.go2go (6cf535a27b)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-1 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-2 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-3 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-4 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-5 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-6 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-12 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-13 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-15 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-16 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-17 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-18 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-19 (0.00s)

Progress!
Summary

The 4x FAIL are still crashing in latest dev.go2go
The 4x SKIP tests also crash in go1.14.4
The 5x that are now PASS in the latest commit might have been fixed by the changes for #39664, #39693, or #39672.

(Those issues cover manually created examples from other gophers, and were reported after this issue. From quick skim of commit one-liners, I don't immediately see which one would fix Crash 17, but presumably it was a different manifestation of one of the other fixes, and in any event it's passing now).

Crash 14 is caused by
https://github.com/golang/go/blob/0a030888da0f33ef75111f079258ab78b1c3eb64/src/go/types/unify.go#L95
y is *types.Basic which have types.Invalid kind, so expand just returns y
and
https://github.com/golang/go/blob/0a030888da0f33ef75111f079258ab78b1c3eb64/src/go/types/unify.go#L150-L157
recursive call.
Change
https://github.com/golang/go/blob/0a030888da0f33ef75111f079258ab78b1c3eb64/src/go/types/unify.go#L94-L95
to
	x = expand(x)
	if basicX, ok := x.(*Basic); ok && basicX.Kind() == Invalid {
		return false
	}

	y = expand(y)
	if basicY, ok := y.(*Basic); ok && basicY.Kind() == Invalid {
		return false
	}

prevents endless recursion

That's great @tdakkota! Thanks for looking at that!

@tdakkota Thanks for analyzing the problem. The correct fix (forthcoming) is a bit more subtle, though. Checking for the invalid type solves this specific case, but is insufficient in general. For instance, this test case will still recurse infinitely:
func F(type T)(func(T) T) { F(func(T) int {}) }

Hi @griesemer, here is a third batch of fuzz-induced crashes (Crash 20 through Crash 27 for this issue).
For now, I am just posting the unit test form as a link to the standard playground:
https://play.golang.org/p/8xZOjpPjh6P
If you are looking at stack overflows, this new batch includes two new variations of stack overflows.
This new batch of Crashes 20-27 pass in Go 1.14.4. Here are the results from running 'go test' in the latest dev.go2go:
dev.go2go (0a030888da -- Sat Jun 20 04:46:40 2020)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-1 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-2 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-3 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-4 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-5 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-6 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-12 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-13 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-14         # fatal error: stack overflow
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-15 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-16 (0.00s)
    --- PASS: TestGoTypesGo2Go/issue-39634-crash-17 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-18 (0.00s)
    --- SKIP: TestGoTypesGo2Go/issue-39634-crash-19 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-20 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-21 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-22         # fatal error: stack overflow
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-23         # fatal error: stack overflow
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-24 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-25 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-26 (0.00s)
    --- FAIL: TestGoTypesGo2Go/issue-39634-crash-27 (0.00s)

Hi @griesemer , here is the third batch third batch of fuzz-induced crashes, but now expanded out here in markdown.
Crash 20 and Crash 21 might be duplicates at this point. (Previously, Crash 21 used to crash in go/types.(*Interface).Complete, but now it looks like both 20 and 21 crash in go/types.(*Checker).completeInterface at this point).  Also, Crash 24 and 25 might be duplicates of each other.
Finally, I am including go2go playground links here, but the reported behavior in this comment is for 0a030888da (and the go2go playground is older than that).
go version devel +0a030888da Sat Jun 20 04:46:40 2020 +0000 linux/amd64

Crash 20: invalid memory address or nil pointer dereference
go/types.(*Checker).completeInterface
package main
type Z interface{ Z }
func F(type t Z)() { F(t{}) }

https://go2goplay.golang.org/p/wAHpBNS7ZPn
Crash 21: invalid memory address or nil pointer dereference
go/types.(*Checker).completeInterface
package main
type Z interface{ Z }
func F(type *T Z)() { (F(Z)) }

https://go2goplay.golang.org/p/H64m4NteTx5
Crash 22: fatal error: stack overflow
go/types.(*instance).expand
(expand -> instantiate -> TypeParam -> Under -> Named -> expand)
package main
type T(type _ interface{ a() }) int
type A(type P) T(A(int))

https://go2goplay.golang.org/p/CoxvTTa5xP1
Crash 23: fatal error: stack overflow
go/types.Comparable
(Comparable -> Comparable)
package main
type T1(type P) struct{ f T2(P) }
type T2(type P) T1(int)
func _() {
	var x T1(int)
	x == x
}

https://go2goplay.golang.org/p/75sK6SAI2c6
Crash 24: panic: assertion failed
go/types.(*unifier).nify
package main
type C(type P) P
func (r C(P)) m() { y := C.m() }

https://go2goplay.golang.org/p/kWYVyRvSGDd
Crash 25: panic: assertion failed
go/types.(*unifier).nify
package main
type T1(type A) int
func (t T1(A)) m1() {}
var x T1.m1

https://go2goplay.golang.org/p/m5k0NKSMK26
Crash 26: panic: assertion failed
go/types.isParameterized
package main
type Y = interface{ F(type Z)() }
func F(type Z)() Y { F() }

https://go2goplay.golang.org/p/BWt_Xe6iwsE
Crash 27: panic: interface is incomplete
go/types.(*Interface).assertCompleteness
package main
func e(type T)() interface{ (x) }
func x() { e() }

https://go2goplay.golang.org/p/Uw5dQZz7Q7M

@thepudds Thanks. I will look at these eventually, they are useful to test the corners of the implementation (keep in mind, this is still a prototype, and some pieces are pretty rough and known to be not correct for all cases).


Remove bidirectional association from unmatch command

fixes #142
fixes #170

I'm not sure where the bidirectional association is being removed, perhaps you could comment?

After further investigation, I realized that @Quasant  had already removed the bidirectional association in a previous update. It seems there was an issue syncing his changes with my branch, which led to them not reflecting in my code. As a result, I mistakenly removed the bidirectional code again. I have now corrected this and ensured the latest changes are fully in sync.


Add more unit tests, add cleanup step for Digital Ocean integration test

Reference Issues or PRs

This is related to #1862
What does this implement/fix?
Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[x] Did you add new tests?

Any other comments?

@costrouc could you take a look at this when you get a chance?


(Update) Kubernetes Rollback

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: _____. Added troubleshooting information to help if a customer doesn't understand why a Canary did not roll back due to resource constraints
Jira/GitHub Issue numbers (if any): ______. https://harness.atlassian.net/browse/CDS-104551
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://675856126237205ea28a1762--harness-developer.netlify.app


Add aexml

Using the generated source archive here. I will submit Bazel module support to the upstream project and request a static archive for the next release.

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (aexml) have been updated in this PR. Please review the changes.

@keith Fixed a typo, sorry for the noise :)

need to update patch integrity


Changing scene makes render methods be called multiple times for a single action, stacking up

Version

react-native-router-flux v4.0.0-beta.28 (v3 is not supported)
react-native v0.52.0

Expected behaviour
Changing scene should dispose components and their 'render' methods should be called only once.
Lifecycle method - 'componentWillUnmount' is being called when switching scene.
Actual behaviour
Changing scenes makes components' render method be called multiple times (stacking for each scene change).
Component lifecycle method 'componentWillUnmount' is not called.
Steps to reproduce
For non-obvious bugs, please fork this component, modify Example project to reproduce your issue and include link here.

When changing to scene A the render method of the component is called once.
When I change to scene B the render method of component in scene A and component in B are called.
When I change back to scene A the component A method is called two times and component B method is called one time.
This stacks up multiple times. It's like the components are living in the background and are not disposed.

Code samples:
Note - those are containers.
Router.js:
<Router>
      <Scene key="root" navigationBarStyle={styles.navigationBarStyle}>
        <Scene key="login" hideNavBar={true} component = {LoginContainer} title = "Login" />
        <Scene key="enotMap"  hideNavBar={true} component={EnotMapContainer} title = "Enot map!"/>
        <Scene key="main"  hideNavBar={true} component={MainContainer} title = "Home!"/>
        <Scene key="filters"  hideNavBar={true} component={MainContainer} title = "Home!"/>
        <Scene key="poiDetailsView"  hideNavBar={true} component={PoiDetailsViewContainer} title = "Details!"/>
      </Scene>
    </Router>

MainContainer:
    let catFilteredItems = filterItemsPoisByCategories(state.enotMap.markers.items, state.enotMap.userFilters.categories);
    let timeAndCategoryFilteredItems = filterPoisByTime(catFilteredItems, state.enotMap.userFilters.selectedTimeFilter);
    return {
        items: timeAndCategoryFilteredItems,
        routing: state.routing,
    }
};

const mapDispatchToProps = (dispatch) => ({
    changeScene: (sceneInfo) => {
        dispatch(changeScene(sceneInfo))
    },
})

export const MainContainer = connect(mapStateToProps, mapDispatchToProps)(Main);

Example reducer code that changes the scenes:
    switch (action.type){
        case actionTypes.SCENE_CHANGE:
            // TODO: switch
            if(action.sceneName == SceneNames.enotMap) Actions.enotMap();
            if(action.sceneName == SceneNames.main) Actions.main();
            if(action.sceneName == SceneNames.poiDetailsView) Actions.poiDetailsView();
            if(action.sceneName == SceneNames.filters) Actions.filters();

            return {
                headerText: getHeaderText(action.sceneName),
                sceneInfo: {itemId: action.itemId},
                scene: action.sceneName
            }
        default:
            return state;
    };
};```
Can this be used with containers or only simple components?

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists


RFC 73: Add ponycheck to the standard library

Add ponycheck to the Pony standard library.
https://github.com/ponylang/rfcs/blob/main/text/0073-add-ponycheck-to-stdlib.md

There's a bug in the compiler that we need to fix before this gets merged.

Both ponyc and the tutorial have branches that are "ready" for this change once the bug is fixed. The branch name is add-ponycheck-to-the-standard-library in both repositories.


Add Node.js 3LO and API key auth support

This one might need a bit more scrutiny, I don't know if I've done it properly.

Current coverage is 81.27% (diff: 100%)

Merging #457 into disco_head will not change coverage

@@           disco_head       #457   diff @@
============================================
  Files             183        183
  Lines            6971       6971
  Methods             0          0
  Messages            0          0
  Branches          909        909
============================================
  Hits             5666       5666
  Misses           1033       1033
  Partials          272        272

Powered by Codecov. Last update 51f8f4f...fc241f4


Add option to produce array of results for blocks

This PR adds an option, interp.Options.BlockStatementAsArray, which configures the interpreter to return an array of results for each statement of a block, instead of just the last statement.

Thank you for your proposal, but please, wait a little so we can settle the previous ones. It's not a go yet for #1078 and #1079, we need a bit of a design review first before jumping on coding, and I still have concerns. I will provide more details soon.

FWIW, all three PRs are independent features. They don't build on each other.


Updated Funding Page

Description
Updates to the funding page:

New funders: Amazon and NHGRI
Separation of "Current" and "Previous" funders
Overall UI refresh

Before:

After:

Amazon and NHGRI are also added as Funders on the About page:

Funders no longer fit on one line... (let me know if yo have any thoughts on this) Shrinking the size makes them look microscopic
Review Instructions
Ensure information looks correct
Issue
DOCK-2310
GitHub Issue

Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

I can't request a review from @bvizzier for some reason... maybe permissions?

think we centralised permissions through the teams at some point and @bvizzier was left out, re-adding

Funders no longer fit on one line... (let me know if yo have any thoughts on this) Shrinking the size makes them look microscopic

AWS and genome canada look too close, as if almost related to each other. Maybe we could use actual text on a second line for BD Catalyst. I don't know if that will be enough to get things on one line

one thing to experiment with

Okay, I shrank both the padding and images, better now (just a little smaller...):

Thanks!
Now, the fact that the three NIH funders are not consecutive and have different sized "NIH" badges makes me feel a little funny, but I don't know if fixing it is going overboard :thinking:

Now, the fact that the three NIH funders are not consecutive and have different sized "NIH" badges makes me feel a little funny, but I don't know if fixing it is going overboard

Unfortunately each one is proportioned differently... but I have an idea 😉

Now, the fact that the three NIH funders are not consecutive and have different sized "NIH" badges makes me feel a little funny, but I don't know if fixing it is going overboard

// Normalize image sizes for NIH logos
.funders[alt="NIH Logo"], .funders[alt="BISTI Logo"], .funders[alt="NHGRI Logo"] {
  height: 1.7rem;
}

They're  fairly similar in size now

Please check to see if there are options to make the NIH & NHGRI logos more readable. As previously mentioned, maybe adding a new line with different scaling?

Alright, we now have two lines with all the NIH logos together on the second row:

Best solution I found was to use the slice pipe to display the first and second halves in two rows:
https://github.com/dockstore/dockstore-ui2/blob/a1eba62926ce3bdea56aacbfcfeb43aede3d8fe5/src/app/about/about.component.html#L234
https://github.com/dockstore/dockstore-ui2/blob/a1eba62926ce3bdea56aacbfcfeb43aede3d8fe5/src/app/about/about.component.html#L239

Sorry, what is the resolution to this? Do we keep them in currentFunders or not?

Amazon is a current funder right? @bvizzier


Possible changes upstream in SES

https://github.com/bobf/action_mailbox_amazon_ingress/blob/9497e134dc3641378eb99f7a100ceafda5392338/app/controllers/action_mailbox/ingresses/amazon/inbound_emails_controller.rb#L119
Howdy, thanks for putting this gem together! I was grateful to find it when I realized SES had been pulled from Rails core.
I know you're working on getting this merged upstream, but just in case this can save you some headache down the road I wanted to let you know about something I ran into today.
When I am receiving the SNS notification the mail message is stored at message['mail'] and not message['content']
Maybe there's a configuration I missed when setting it up? Seems like AWS shouldn't be changing these keys willy nilly.

@chrisortman Replying here as well as the Rails PR for completeness.
Are you sure you didn't enable raw message delivery ?
Check the documentation change here: https://github.com/rails/rails/commit/809f53b9576684a6fbd985d957ca22689d10138e
If you still think it's wrong then let me know and I'll take a look !

Yes. We can move discussion to rails pr


[WIP] Update Quality Control tutorial with long reads analysis

Update Quality Control tutorial with long reads analysis with FastQC, Nanoplot (PacBio/Nanopore) and PycoQC (Nanopore)
Slides

[x] Introduction
[x] FastQC
[x] Nanoplot
[x] PycoQC

Tutorial

[x] Data: PacBio HiFi subest reads from HG002 and Nanopore from @timkahlke
[ ]  Zenodo
[ ] FastQC long reads
[ ] Nanoplot
[ ] PycoQC

awesome @alexcorm this is great to see!

Thanks @hexylena :)
I've just finished the update for the slides and I've planned to start the tutorial part. If you have any suggestion/correction do not hesitate :)

I think this one is ready now!


Not able to add content to WizardStep using addContent method

OpenUI5 version:
1.87.0
Browser/version (+device/version):
Microsoft Edge on Chromium
Any other tested browsers/devices(OK/FAIL):
Chrome/FAIL
URL (minimal example if possible):
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Created sap.m.Wizard in the XML view without any aggregations.
Added multiple steps using sap.m.Wizard.addStep() and sap.m.WizardStep.sap.m.addSubsequentStep() methods.
Added content sap.m.Text with a sample text to the first WizardStep in the wizard using sap.m.WizardStep.addContent() method.

What is the expected result?
The sap.m.Text control that was added as aggregation, should appear in the particular WizardStep.
What happens instead?
That content that was added as aggregation is not appearing under the WizardStep
Any other information? (attach screenshot if possible)
		**this.oWizardHandlingStep = new sap.m.WizardStep("WizardStepID", {
			"title": "Handling Units",
			"icon": "sap-icon://order-status"
		});

		var text = new sap.m.Text("TextID", {
			text: "Text inside wizard Step"
		});
		this.oWizardHandlingStep.addContent(text);**

Could you please help me with this issue?

Hi @akhilesh-vatupalli ,
thank you for your finding!
Can you, please, describe more in details what is the issue, that occurs after adding the content of the step?
I created a jsBin, which, I think covers your case for your ease: https://jsbin.com/xuwebax/edit?html,output
Kind regards,
Petya Bogdanova.
(UI5 Dispatcher)

Hi @PetyaMarkovaBogdanova,
Thank you for your quick response!
I have checked your attached JSBIN code line and found the problem in my code. Now I have the below question,
In my case I need to clear all the steps and reconstruct them every time depending on some factors from the business side(I have constructed the Wizard control statically in the view). For this if I use sap.m.Wizard.destroySteps, steps are getting destroyed, but when I try to construct the same steps again, strange errors occur. May be I am missing something here.
Here is the JS Bin I have adjusted from yours https://jsbin.com/kakejaxedi/edit?html,output
Could you please guide me with this?
Best regards,
Akhilesh Vatupalli.

Hi @akhilesh-vatupalli,
I don't get the example. Why would are subsequent steps needed. They are only available when the Wizard is in branching mode: https://sapui5.hana.ondemand.com/#/api/sap.m.WizardStep%23associations
Could you provide your full scenario as a sample, so we would be able to support you?
Cheers

Hi @d3xter666 ,
It was my mistake to use subsequent steps in my controller. Let me explain more about the experiment I did for my business use case.

My application pattern is List report -> Wizard. When user clicks on each line item in the list page, application should display a wizard each time with different number of steps inside it(of course steps themselves can be different, this is totally depending on the line item which the user interacted with).

For this, we have created two views, one for List report(which displays a sap.ui.core.SmartTable) and another one to contain Wizard. This wizard we have built into the XML view itself, thinking to add 'steps' aggregation dynamically whenever the route has been matched.

When the particular route is matched, these are the steps we are doing. Get the Wizard Control ->Destroy all the steps inside it -> Create a new set of steps depending on the data -> Add the steps to Wizard. We are using 'destroy steps' because we wanted construct new steps always.

Below is the code that we have written inside 'onRouteMatched' method,
**_onObjectMatched: function (oEvent) {
var oTeamClicked = oEvent.getParameter("arguments").navigationPath;
var oWizard = this.getView().byId("CreateHandlingSlotMaterialWizard");
 	oWizard.destroySteps();
 	//oWizard.removeAllSteps();

 	if (oTeamClicked === "TEAMVALIDTEST") {
 		var oWizardHandlingStep = new sap.m.WizardStep({
 			title: "Handling Units",
 			icon: "sap-icon://order-status"
 		});

 		var text = new sap.m.Text("TextID", {
 			text: "Text inside wizard Step"
 		});
 		oWizardHandlingStep.addContent(text);
 		var oWizardSlotStep = new sap.m.WizardStep({
 			title: "Slots",
 			icon: "sap-icon://order-status"
 		});
 		var oWizardDelivStep = new sap.m.WizardStep({
 			title: "Delivery",
 			icon: "sap-icon://order-status"
 		});

 		oWizard.addStep(oWizardHandlingStep);
 		oWizard.addStep(oWizardSlotStep);
 		oWizard.addStep(oWizardDelivStep);

 	} else if (oTeamClicked === "SUBTEAM") {
 		oWizardHandlingStep = new sap.m.WizardStep({
 			title: "Handling Units",
 			icon: "sap-icon://order-status"
 		});

 		text = new sap.m.Text("TextID", {
 			text: "Text inside wizard Step"
 		});
 		oWizardHandlingStep.addContent(text);
 		oWizardSlotStep = new sap.m.WizardStep({
 			title: "Slots",
 			icon: "sap-icon://order-status"
 		});

 		oWizard.addStep(oWizardHandlingStep);
 		oWizard.addStep(oWizardSlotStep);
 	}
 }**

Hi @akhilesh-vatupalli ,
I see, but I'm still unable to reproduce the issue. Could you provide a JSBin sample where the issue occurs?
The latest one from your modified sample does not work at all.
Basically, you could handle this situation a bit differently.
As far as I can see from the Snippet above (the code from your controller), there are several different Wizard scenarios for each route. Then, why don't you just define those scenarios into different XMLViews/XMLFragments and for each route, just load the corresponding XMLView/XMLFragment
Cheers

Hi @d3xter666,
Thank you for your suggestions and inputs! Actually we need to create the wizard steps dynamically and also the content to be displayed inside each step. Anyway now we have dropped this approach because the configuration to be maintained by the user for this kind of dynamic behavior  is becoming huge.
Now we are looking for other options. So, I am closing this issue.
Once again thank you for your help!
Best regards,
Akhilesh Vatupalli.


Update Dockerfile to utilize Debian package

Once dotnet/cli#2565 is fixed, the Dockerfile should be updated to utilize the CLI Debian package instead of extracting the tarball and manually installing the dependencies.

This is being tracked with https://github.com/dotnet/dotnet-docker/issues/73.  Closing.


SharePoint 2013 setup

Hello guys,
Starting with this post http://www.wictorwilen.se/using-sharepoint-2013-with-thinktecture-identityserver-2 I wanna implement the same setup but using IS3 and WSFederation. Is this possible ? Can I use IS3 with WS-Federation to generate SAML1.1 tokens ?
If yes, how can I get the signinurl and Federation metadata xml ?
I have IS3 running, now I need a bit of guidance to connect SharePoint 2013 with IS3.
Thank you,
Ovidiu

Yes you can generate SAML 1.1 tokens.
I don't know how to connect SharePoint but this has been done before. There is also a WS-Fed sample client in the clients sample in our repo.
Would be great if you could post a walkthrough when you have it working.

Would be great if you could post a walkthrough when you have it working.

@ovidiubechesenoro were you able to do this?


Replace inputs template with working example

Now that we have google cloud bucket file paths, we can provide a real working json.
Need to run a full test before merging.

Test running at https://cromwell.dsde-methods.broadinstitute.org/api/workflows/v1/b057b4b8-a92f-4ffd-b08e-ba6a53aa157f/status

Test successful after a tiny fixup.

Also edited the README accordingly.


Test cortx-js-sdk integration. Add instructions to solve npm and crea…

…te bucket errors.
Signed-off-by: wb-droid<EMAIL_ADDRESS>Describe your changes in brief
Test cortx-js-sdk integration.
Add instructions to install npm if it's not found.
When http endpoint url is used, "Create bucket failed" error is encountered. Solve this by using a https endpoint url.

View rendered doc/integrations/cortx-js-sdk/README.md

Closing as an obsolete


Some modifications:

Hi, there are some modifications I've made when working with your lib.

incorrect height in chromium - now there is a function to calculate objects's height
incorrect scroll speed in firefox - it was too slow: deltaY in ff is different with other browsers
wrong preventDefault logic - preventing keypress events on keys like spacebar, home or end can be (and actually was in my case) harmful for the whole app
added events to emit on scroll - I've added two events ("scrollY" and "scrollX") to be listened from outside. It can be used to implement an infinite scroll, for instance.

Thanks for the lib!

Thanks K1O2, much appreciated. However, I haven't  had problems with most of the concernes you raised. Can you give more details (browser versions) and an example (fiddle) to investigate. It may just be the way you use ng-scrollable in your app. I'm curious if there's any more requirements here.
Height calculations are tricky with Angular because the DOM layout updates outside the digest loop. To make it work I included the observer-based method to watch for DOM children changes a while back. You may as well send a content.changed event after the new layout has rendered. I usually do this with a $timeout(function(){scope.$broadcast('content.changed');}, 250); when I'm not using the observer. Both work fine also for long and complex forms or video thumbnails in my case. I'm using  FF/Chrome/Safari on both desktop and mobile. Not sure about Microsoft, since I'm not using their software.
Your fullHeight() function doesn't get me excited performance-wise. I would not want to integrate that, also given the fact that you can make sizing work using the observer or timeout above.
FF scroll speed is way too fast when I use the 17.6 you suggest (I've used FF 30+ on Desktop, IOS and Android and never had this problem) - which version are you refering to?
Scroll events: Right now you can implement infinit scroll using the spyX/spyY feature (scope.$watch the properties for updates), emitting Angular events up the scope hierarchy is overkill, in particular because they are sent each animation frame when you scroll.
The preventDefault logic is worth considering. It works when you set contenteditable='true' on input fields which skips key event processing. Looks like checkboxes don't like that (#24), so I extended the check to all INPUT-class fields. To prevent or allow default keyboard events I added a new configuration option preventKeyEvents for your convenience.

Hi, thanks for the answer.

FF scroll speed: I'm using 41.0.2 on Ubuntu x64 - scrolling is really slow on the demo page (http://echa.github.io/ng-scrollable/). Cant't think of a way to show you this, maybe you have an idea?

Height: I can't reproduce the issue now, will try to make an example

Events: thanks, will try to use those :)

Preventing key press: it's not only checkboxes - I can't even add "space" into the input field

Aargh, I haven't checked on Linux yet :( As quick work-around for the scrolling speed you can set the wheelSpeed config option to a higher value.
The spacebar issue on input fields should be fixed in the latest version. Before I only checked the contenteditable property of the active DOM node which is in some cases not set to true. I had always explicitly set contenteditable=true in my projects, so never experienced the problem. Now, the check covers to all fields of type INPUT. Hope this works for you.


Fail at discretization

Hello, I am a fresher on Julia working on active matter physics. I am trying to simulate a famous equation, conserved model B, in active matter physics(see https://arxiv.org/pdf/1904.01330.pdf, page 4 for more details) using method of lines.However, I got an error in discretization. Here is the error message.

ArgumentError: Differential w.r.t. multiple variables Any[2.608695652173913, 3.4782608695652173, 4.782608695652174, 1.7391304347826086, 4.3478260869565215, 6.956521739130435, 3.9130434782608696, t, 8.26086956521739, 3.0434782608695654, 7.391304347826087, 1.3043478260869565, 0.8695652173913043, 8.695652173913043, 0.43478260869565216, 2.1739130434782608, 6.086956521739131, 6.521739130434782, 5.6521739130434785, 7.826086956521739, 9.130434782608695, 9.565217391304348, 10.0, 5.217391304347826] are not allowed.

I also paste my codes below.  I find that if I set K=0 and A,B,T>0, then there is no error. However, there is always an error when K>0. I would appreciate it if you could help me solve the problem.
using Symbolics,ModelingToolkit
using SymbolicUtils
using DomainSets,MethodOfLines, OrdinaryDiffEq

@parameters t,x,y,z
@parameters T,A,B,K
@syms rho(x,y,t)

rhs = (2B*rho(x, y, t)*Differential(x)(rho(x, y, t)) - A*Differential(x)(rho(x, y, t)) - K*(Differential(x)(Differential(x)(Differential(x)(rho(x, y, t)))) + Differential(x)(Differential(y)(Differential(y)(rho(x, y, t))))))*Differential(x)(rho(x, y, t)) + (2B*rho(x, y, t)*Differential(y)(rho(x, y, t)) - A*Differential(y)(rho(x, y, t)) - K*(Differential(y)(Differential(x)(Differential(x)(rho(x, y, t)))) + Differential(y)(Differential(y)(Differential(y)(rho(x, y, t))))))*Differential(y)(rho(x, y, t)) + (2B*(Differential(x)(rho(x, y, t))^2) + 2B*rho(x, y, t)*Differential(x)(Differential(x)(rho(x, y, t))) - A*Differential(x)(Differential(x)(rho(x, y, t))) - K*(Differential(x)(Differential(x)(Differential(x)(Differential(x)(rho(x, y, t))))) + Differential(x)(Differential(x)(Differential(y)(Differential(y)(rho(x, y, t)))))))*rho(x, y, t) + (2B*(Differential(y)(rho(x, y, t))^2) + 2B*rho(x, y, t)*Differential(y)(Differential(y)(rho(x, y, t))) - A*Differential(y)(Differential(y)(rho(x, y, t))) - K*(Differential(y)(Differential(y)(Differential(x)(Differential(x)(rho(x, y, t))))) + Differential(y)(Differential(y)(Differential(y)(Differential(y)(rho(x, y, t)))))))*rho(x, y, t) + T*Differential(x)(Differential(x)(rho(x, y, t))) + T*Differential(y)(Differential(y)(rho(x, y, t)))

rhs = substitute(rhs, Dict([T=>0.5,A=>0.1,B=>0.1,K=>0.01]))
x_min = y_min = t_min = 0.0
x_max = y_max = 10.0
t_max = 0.5
rho0(x,y,t) = sin(x) * cos(y)
domains = [x ∈ Interval(x_min, x_max),y ∈ Interval(y_min, y_max),t ∈ Interval(t_min, t_max)]
bcs = [rho(x,y,0) ~ rho0(x,y,0),
       rho(0,y,t) ~ rho(x_max,y,t),
       rho(x,0,t) ~ rho(x,y_max,t)]

@named pdesys = PDESystem(Dt(rho(x,y,t))~rhs,bcs,domains,[x,y,t],[rho(x,y,t)])

N = 24

order = 2

discretization = MOLFiniteDifference([x=>N, y=>N], t, approx_order=order,advection_scheme=WENOScheme())
print(discretization)
println("Discretization:")
@time prob = discretize(pdesys,discretization)

Hi, I will take a look at this soon, I think it's related to this term
 Differential(y)(Differential(y)(Differential(y)(rho(x, y, t))))))*Differential(y)(rho(x, y, t))

We have only a rudimentary scheme for 3rd order derivatives with high dispersion, and it is possible that the upwind scheme is interacting poorly here, but you could try wrapping this 3rd order deriv with an auxiliary variable.


Subscribing to Multiple Gestures and Events

how to use multiple gesture event together with angular like we can do with JS project.
label.on("loaded, tap, doubleTap, longPress", function (args: GestureEventData) {
    console.log("Event: " + args.eventName + ", sender: " + args.object);
});

is there any direct binding available from view?

Hi @bhavincb,
You can register multiple gestures for a specific view component via code behind while using the component's loaded event or via HTML while registering callback method for each gesture that you need to use. For example:
HTML
<StackLayout class="page">
    <Label text="test test" (touch)="touchCallback($event)" (doubleTap)="doubleTapCallback($event)" textWrap="true"></Label>

</StackLayout>

TypeScript
public touchCallback(args){
        console.log("test touch");
    }
    public doubleTapCallback(args){
        console.log("test doubleTap");
    }

hii @tsoneven,
actually my question was slightly different.
how to use multiple gesture event together ?
like first tap and then doubleTap or tap and then  hold .
is there any direct binding available from view?

Hi, @bhavincb,
In this case, you should define the gestures via code behind, for example on the component loaded event. This will allow you to set a single callback for multiple gestures.

hii @tsonevn ,
but it will called separately for all the gestures defined. what if one needs chaining event like tap and then hold or tap and then doubleTap

@bhavincb you could create your own flags which can be raised when a set of events are called.
For example something like having a false flag which will become true once the user triggers both touch and 'long press events over a period of time or in a specific area.

can't be this added as feature?


Make longer and undefined/same hues have parity with CSS spec

Ref #473

This is ready for review


Need netDxf2013.sln to compile in Visual Studio 2013

I have Visual Studio 2013, so i could not compile netDxf project, it started throwing "the name 'nameof' does not exist in the current context" errors.
I need to draw a very simple basic shapes like line, circle, arc, rectangle, bezier curve etc.. with dimension texts and have the same in DXF file format. I Mean, my DXF file is a simple outline of some objects.
If you could provide netDxf2010.sln also, It will be very useful.
Thanks,
Krishna

The problem is not with the Visual Studio solution file but with the C# version. The nameof keyword, between other things, is a new fetature of C# version 6.0 that was introduced in Visual Studio 2015. The C# and the Visual Studio versions are two different things,
If you work with a other VS version or use a different IDE, you can download the compiled binaries from here.
Daniel


URLs are not set for every page state

Refreshing in a game brings you back to the main page
(P.S. sorry for so many nitpicks :P)

I can't reproduce this issue on reminisce.me but it indeed appears on https://apps.facebook.com/reminisceme/. I will see if we can store the current game in localstorage to circumvent that.

It looks like the issue that I had is fixed now (e.g. it now uses the URL /play/c863427b5d13939e6d5501d9). But you are right, on apps.facebook.com there is this problem still.


Frontend pre-requisites

[x] Some way to serve static files

https://github.com/compass-rs/sass-rs as part of build process?

[x] Example templates

<username> = anonymous for non-authenticated

GET /<username>

list public pastes, or all if you're the person

GET /<username>/<paste id>
GET /<username>/<paste id>/edit
POST /<username>/<paste id>/edit
... etc

[x] GET /

Primary paste creation interface.

[x] POST /pastes

Route to create a paste via web.

[ ] GET /about

maybe?

[ ] GET /username

View public pastes (all if authed)
Takes precedence over GET /<id>

[x] GET /<id>

Redirect to /<username>/<id>

[x] GET /<username>/<id>

Display paste, its info, and its files.

[ ] GET /<username>/<id>/edit

Edit paste information and files.

[ ] POST /<username>/<id>/edit

Save changes.

[ ] POST /<username>/<id>/delete

Delete paste.

[ ] GET /<username>/<id>/files/<id>/edit

Edit one file.

[ ] POST /<username>/<id>/files/<id>/edit

Save changes.

[ ] POST /<username>/<id>/files/<id>/delete

Delete file.

[x] GET /account

Display and allow account information edits.

[x] POST /account

Make account information edits.

[x] GET /account/keys

Display API keys.

[x] POST /account/keys

Create a new API key.

[x] POST /account/keys/<key>/delete

Delete an API key.

[x] POST /account

[x] GET /account/delete


Copy log config from /config to the exe dir on build

I've failed to find the way to get the build output dir (debug, release or whatever) from build script. I;ve even found some advises to not even try to use build output dir since it's configurable and might be changed.
So lets not copy config to the build dir, but copy default config to the root so if executable will be started from project root then this config will be used.


Ai vonie pre branch

Sound volume can be changed while playing a song in demo mode
The volume of the changed sound is saved in the config file
Fixed a bug due to which there was a delay when moving the slider
Cleaning up unused code

I didn't test Windows mode and forgot to centralize the number of threads. Now it's fixed.
Maybe in the next few days I'll work on centralizing the threads.


Epic: pageserver s3 coordination

Motivation
We need this in order to resolve issues for tenant relocation and possible read scalability feature which will allow connecting single compute to multiple pageservers
DoD
Implement the RFC
Implementation ideas
See linked RFC
Tasks

[ ] Change index file structure to contain log of changes instead of just the file list
[ ] Implement pinging/elections for pageservers

Other related tasks and Epics

https://github.com/neondatabase/neon/issues/1556
https://github.com/neondatabase/neon/issues/886

as of @shanyp this is not super relevant anymore, closing


”Săliște”, ”Seculești”, ”Stoicești” are listed in the drop-down menu

Description:
When user writes ”Săliște”, ”Seculești”, ”Stoicești” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Săliște"

Expected results
The location appears in the drop-down menu as "Sat Săliște, DOLJ (Bulzești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Seculești"

Expected results
The location appears in the drop-down menu as "Sat Seculești, DOLJ (Bulzești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Stoicești"

Expected results
The location appears in the drop-down menu as "Sat Stoicești, DOLJ (Bulzești)".


When a parent class has_paper_trail then changing child attributes with accepts_nested_attributes_for, the parent record is not touched

I don't see how I can be the first person to notice this, but I think I found something bad. :( Bug template is here: https://gist.github.com/cannikin/1b951a6689d21cfe7c335e4d08adee8f (see comment starting on line 77 for how to make the tests pass).
This has nothing to do with actually creating versions, that all behaves as expected. The problem is that it seems to be breaking default Rails behavior RE: touching a parent when the child changes via nested attributes.
You have a parent and a child, and the child is set to touch the parent when it (the child) changes. The parent accepts nested attributes for the child:
class User
  has_many :posts
  accepts_nested_attributes_for :posts
  has_paper_trail
end

class Post
  belongs_to :user, :touch => true
end

Editing a post touches the user record as expected:
user = User.first
user.posts.first.update(:title => "New Post Title")

  User Load (0.3ms)  SELECT  "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT ?  [["LIMIT", 1]]
  Post Load (0.3ms)  SELECT  "posts".* FROM "posts" WHERE "posts"."user_id" = ? ORDER BY "posts"."id" ASC LIMIT ?  [["user_id", 1], ["LIMIT", 1]]
   (0.0ms)  begin transaction
  User Load (0.1ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 1], ["LIMIT", 1]]
  SQL (0.3ms)  UPDATE "posts" SET "title" = ?, "updated_at" = ? WHERE "posts"."id" = ?  [["title", "New Post Title"], ["updated_at", 2016-10-06 19:00:21 UTC], ["id", 1]]
  SQL (0.1ms)  UPDATE "users" SET "updated_at" = '2016-10-06 19:00:21.342059' WHERE "users"."id" = ?  [["id", 1]]
   (0.4ms)  commit transaction
=> true

But making that same change via nested attributes does NOT touch the user:
user = User.first
user.update(:posts_attributes => { '0' => { :id => user.posts.first.id, :title => 'Another Title' } })

  User Load (0.1ms)  SELECT  "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT ?  [["LIMIT", 1]]
   (0.0ms)  begin transaction
  Post Load (0.1ms)  SELECT "posts".* FROM "posts" WHERE "posts"."user_id" = ? AND "posts"."id" = 1  [["user_id", 1]]
  User Load (0.0ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = ? LIMIT ?  [["id", 1], ["LIMIT", 1]]
  SQL (0.3ms)  UPDATE "posts" SET "title" = ?, "updated_at" = ? WHERE "posts"."id" = ?  [["title", "Another Title"], ["updated_at", 2016-10-06 19:01:35 UTC], ["id", 1]]
   (1.2ms)  commit transaction
=> true

As you'll see in the bug file you need to completely remove/comment the has_paper_trail class method call in order to get the original default behavior (and the tests to pass).
Let me know if there's anything else I can do to help!

Okay, did some further investigation...this might actually be a Rails issue.
I found that if I commented out the after_commit and after_rollback calls in PaperTrail::ModelConfig#setup_transaction_callbacks` (https://github.com/airblade/paper_trail/blob/master/lib/paper_trail/model_config.rb#L191-L193) then the parent is touched again.
I set up another bug file but this time didn't include has_paper_trail at all and simply created an empty after_commit {} hook in the model and sure enough, the nested attributes change is broken.
I'm closing this one and adding an issue over at rails/rails!

I set up another bug file but this time didn't include has_paper_trail at all and simply created an empty after_commit {} hook in the model and sure enough, the nested attributes change is broken. I'm closing this one and adding an issue over at rails/rails!

Nice troubleshooting, Rob! You can probably adapt your PT bug report script directly to the ActiveRecord bug report script, because PT's is based on AR's :)

Yep, just did! Sorry for the scare. :) https://github.com/rails/rails/issues/26726


sensor docs miss the value() function

http://python-ev3dev.readthedocs.org/en/latest/sensors.html#sensor
shouldn't there be the value() method too?

Thanks, the function lacked a docstring. Fixed in #134.


Small changes

What does this PR do?
Dependencies up to date
All production and development dependencies were updated to their latest version.
Now, there's a special mention: ESLint. It latest version is v5, but the Airbnb preset I use is still not compatible with it, so I updated ESLint to the last version before v5: v4.19.1.
I also updated a few things on the .eslintrc after getting the Airbnb preset last version:

lines-between-class-members: I disabled this rule because I already fill the space between methods with comments, so I see not reason for it.
operator-linebreak: I changed the default value from the Airbnb, before,  to after. The convention I use and which I believe is easier to read is with the operators at the end of the line.

hooks instead of install-hooks
The yarn/npm script to install the repositories hook has been changed to just hooks.
How should it be tested manually?
This is not breaking, so everything should work as always.
And of course...
npm test
# or
yarn test

Pull Request Test Coverage Report for Build 101

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 99:
0.0%

Covered Lines:
287

Relevant Lines:
287

💛  - Coveralls


[WIP] Implement histogram calculation

I just implemented the minimum function of histogram calculation for GPU.
I'd also like to determine the interface and write tests if required.

I think I can

I'm trying to write tests regarding the ones of 'bincount' but what they do is not clear for me

I think histgram has the same interface with numpy's one. So, all you need to do is to check both implementations return the same results.
for_all_dtypes decorator calls the function many times with all dtypes.
numpy_cupy_allclose decorator also calls the function with both xp=cupy and xp=numpy, and check if two results have same values.

Can i take over this PR?

@unnonouno yes please

Thanks a lot!


[webapi] Update test from manual to auto for CSS3UI

Update execution_type from 'manual' to 'anto'
Update CSS3UI_pseudo-classes_required-manual.html to CSS3UI_pseudo-classes_required.html
Add CSS3UI_pseudo-classes_required-ref.html reference file

Impacted tests(approved): new 0, update 1, delete 0
Unit test platform: [Android]
Unit test result summary: pass 1, fail 0, block 0

Is this test qualified for submitting to W3C? If not, don't make reference file for it; just remove it. If yes, please make the submission even with some improvement.

@yunxliu, please sync with zhiqiang for the "improvement" details meaning, and update your cases to met W3C requirement.
@zqzhang, please give more detail comments in the PR, then GB know how to update and improve it.

@cicili for the test cases you are trying to automate, please first check whether it is qualified for submitting to W3C.
If W3C won't accept the test, we'd remove it rather than automate it. This is a general rule. Clear?


Improve Mac OS X support (Issue #21)

readlink behavior on Mac OS X is different than Linux and there is no
sha256sum command. Replace usage of these commands by Python interfaces.
Also assume, BSDFile for Mac OS X as well.

Do any of these changes actually work with remote backends? I would expect we need to shell out for stuff like sha256 too.


Replace MIDebugEngine, MICore with PCLs

This replaces MIDebugEngine and MICore with PCLs targeting .NET 4.6 and ASP.NET Core 5.0. The new PCLs build but won't run because they depend on a stub version of DebugEngineHost pending its reorganization. There are some noteworthy changes to the solution:

Visual Studio requires Universal Windows App Development Tools 1.1 to load the PCLs
It remains necessary to add a local package source containing the Interop nupkg
One test is broken by a project system bug (I left a TODO describing this and its workaround)
xsd.exe is no longer used because the code it generates isn't portable
A workaround must be applied each time the new libraries' resource string code is generated (see commit comment)

Hi @chlowell, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Charles Lowell). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Signing off with comments. Let me know when you want me to merge this.

Looks good to me.


Feature: postgres/redshift multiple group grants

This change is cosmetic/vanity only. On Redshift + Postgres, you can run the following:
    grant usage on schema dbt_jcohen to group transformer, group reporter;
    grant select on all tables in schema dbt_jcohen to group transformer, group reporter;
    alter default privileges in schema dbt_jcohen
        grant select on tables to group transformer, group reporter;

I'd understand if you prefer the more explicit/repeated version.

Changed my mind, this is good, you should :shipit: once you've made the changes :)


Fatal error on getting emails

Hi, I'm facing some errors when trying to read some emails. A fatal error is always happening
PHP Fatal error: Uncaught ErrorException: Unknown: Unexpected characters at end of address<EMAIL_ADDRESS>(errflg=3) in Unknown:0

Stack trace:
#0 [internal function]: Illuminate\Fundation\Bootstrap\HandlerExceptions->handlerError()
#1 {main}
	thrown in Unknown
Segmentation fault

laravel-imap: 2.4.0
php-imap: 2.5.1

I figured out that the error occurs when I do $message->getAttachments()

Hi @PedroPMS ,
many thanks for your report. This sounds indeed odd. Can you try to pinpoint it down a little bit further? The callstack is a bit short to tell what might have caused this.
Does it still occur if you update to the current alpha version v3.0.0-alpha?
Best regards,

I figured out more things about it. The message "Unexpected characters at end of address<EMAIL_ADDRESS>(errflg=3)" is a Notice, but laravel try to handle in their own errors handler, and the segfault occurs there.

@PedroPMS that mean "ignore it" is no any problem? i also met some problem.

@PedroPMS do you know how to disable display this message?


[feature] Sync project dependencies to tsconfig compilerOptions paths

Is your feature request related to a problem? Please describe.
When working with TypeScript monorepo projects to improve import paths we can use path mapping to improve the import paths within the project using the referenced package. It is frustrating to have to manually apply these project path mappings.
Describe the solution you'd like
When the tsconfig references sync happens, the compilerOptions path mapping is also synced.
Describe alternatives you've considered
NX nwrl tooling does this as part of its project linking. Otherwise, it has to be manually configured.
Additional context
How the tsconfig could be configured
{
  "extends": "../tsconfig.options.json",
  "compilerOptions": {
    "rootDir": "./src",
    "paths": {
      "@namespace/package-a": ["../packageA/src/index.ts"],
      "@namespace/package-a/*": ["../packageA/src/*"]
    }
  },
  "exclude": ["dist"],
  "include": ["./src"],
  "references": [
    {
      "path": "../packageA"
    }
  ]
}

@edwardwilson Interesting. Wouldn't @namespace/package-a already be available for importing because of node_modules symlinking? Or is this overwriting that to use the source files?

When paired with the package.json pointing to src/index.ts we can use import {} from '@namespace/package-a '.
If however we want to achieve the following, we need to have a path mapping into the src folder ../packageA/src/* or we require an independent build of the package and to consume it like any other npm package with a structured dist folder.
import {x} from '@namespace/package-a/x';
import {y} from '@namespace/package-a/y';

@edwardwilson Yeah makes sense. I'll look into add a setting for this.

@edwardwilson I started working on this here: https://github.com/moonrepo/moon/pull/352
Before I finish, just want to make sure this is what you were looking for.


Wrong Temperature when minus degrees

Hi there,
i never experienced this mistake as we never had minus degrees until last night. When the temperature drops below 0, then Domoticz displays values at around 6.552  -  6.554 °C. Even some sunlight is available at my balcony, the temperature seems to be "a bit" too high :)
I read out the temperature directly at the sensor via the telink flasher page: there the temperature is correct (but the timestamp is wrong, I don't care about that).
Where is the problem? Is this a mistake by Domoticz or via the python script? I am using the ATC1441 format.
Thanks for help

11:06:22: Hardware Revision String: B1.4
11:06:22: Detected custom Firmware
11:06:22: Hardware Version: LYWSD03MMC B1.4, Software Version: 3.8, Sensor: SHTC3
11:06:22: Custom config: [128, 0, 0, 0, 40, 12, 169, 124, 49, 128, 60]

Update: with the original firmware this bug is not existing. The correct values are transferred and i  can see in Domoticz -0,23 °C (as an example).

Sorry, but I can't maintain this repo already I don't use Domoticz.
Try to this int conversion: temperature = int(bytes[8] * 256 + bytes[9]) / 10
If it works, create a pull request and I will merge it.

Update form my side: The behaviour is still the same. I changed the line you mentioned but that changed nothing. + degrees are fine, - degrees turn out to be somehwre at 6.500 degrees.

What is the temperature value in log file? The logger module saves every data. It is a good starting point.

The value in the log file is as the same as Domoticz. I changed the location into the freezer to compare:
Outside:

2022-12-01 22:55:04 INFO     Discovery data from MAC: A4:C1:38:XX:XX:XX
2022-12-01 22:55:04 INFO     Temp: 6.9
2022-12-01 22:55:04 INFO     Hum: 43
2022-12-01 22:55:04 INFO     Comfort type: 1
2022-12-01 22:55:04 INFO     Battery level: 40
2022-12-01 22:55:04 INFO     Voltage: 2.562

Freezer:

2022-12-01 23:00:04 INFO     Discovery data from MAC: A4:C1:38:XX:XX:XX
2022-12-01 23:00:04 INFO     Temp: 6549.2
2022-12-01 23:00:04 INFO     Hum: 42
2022-12-01 23:00:04 INFO     Comfort type: 1
2022-12-01 23:00:04 INFO     Battery level: 28
2022-12-01 23:00:04 INFO     Voltage: 2.457

Shift temperature by 15 right to check the sign bit ((temperature>>15)&1) and if it is 1, then -(2^16-temperature) is your value.

I switched to a different method to receive the data, "MiTemperature2". Can't verify this solution anymore. Thank you for your afford!


Feedback wanted from Fastboot users

Hi, ember-cli-sentry users,
Does some of you have feedback to share about using this add-on with Fastboot? How the two work together? Have you noticed any weird behavior?

Related to #59

Raven obviously doesn't work in node throwing the expected Error while processing route: index XMLHttpRequest is not defined ReferenceError: XMLHttpRequest is not defined
I have a use case where I report 404 routes via captureMessage, so considering using raven-node for that.
If this addon wants to be Fastboot compatible, would be nice and should be quite easy to add this functionality by conditionally importing raven-node when in Fastboot environment and call captureMessage, captureException via raven-node instead of raven.js.
Users could opt-out from reporting in fastboot mode by setting, say, fastboot: false flag in config/environment.js.

Funny timing i just added sentry to my ember app running fastboot and ran into the same thing would be great if this used raven-node when in fastboot.

I opened a new PR #66 to use raven-node in fastboot


Server timeseries

Server logic for an experimental timeseries format not unlike what is being developed in https://github.com/argovis/grid-sync/pull/13. Critically, pushes timeseries slicing into mongo aggregation to avoid deserializing potentially large documents into node.
Pairs well with #258

closing these as a do-over is imminent now that we have a clearer picture of the challenges of working with satellite timeseries.


[BUG] Argument forwarding not working as expected

Describe the bug
Argument forwarding not working as expected.
https://nx.dev/workspace/run-commands-executor#arguments-forwarding

This is useful when you need to pass raw argument strings to your command.

The command:
nx serve project --watch=false --args="-- verb --param1=arg1 --param2=args"

is invoking:
dotnet run --project Project.csproj --configuration Debug --args -- verb --param1=arg1 --param2=args

instead of:
dotnet run --project Project.csproj --configuration Debug -- verb --param1=arg1 --param2=args

Expected behavior
The args option should allow passing raw strings to the command.
Additional context
Fixing this would also close #295

This is possible duplication of #262, though the explanation here completes the other ticket.

The --args options here is specific to nx:run-commands, its not something currently provided on the executors we provide. I'd be open to PRs adding them where necessary, although I think extraParameters may fit the same slot.


Teams package displays bogus menus

Describe the bug
Teams triggers show up distored in menu
Version
1.3.1-nightly202254
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to to add trigger
Select Team triggers

Expected behavior
The menus shouldn't look like that.
Screenshots

Additional context

@EricDahlvang , this might be a bug on the package side.


[question] Make related-proxy computed property volatile?

The hasOne and hasMany helpers create a computed property that returns a proxy object. This proxy object is then cached and used for every subsequent get of that relation. This means that either related-proxy.promiseFromCache or service.findRelated is always used. Which means:

Cache is only used when it has contains the related resources on proxySetup and then cached. Making it impossible to use the related-proxy to query the server for relations afterwards.
The reverse: Cache is never used if it did not contain the related resources on proxySetup. Subsequent gets of that relation will always query the server.

I can't easily imagine this is by design. I think it mostly ends up being service.findRelated, so in most use-cases everything works fine. But I ran into this when I wondered why resources that were included in previous server responses were being fetched again.
I think an easy "fix" would be to add .volatile() to the Ember.computed we return in the hasOne and hasMany helpers. I don't see any impact other than performance (which could very well be significant).
There might be some other mechanisme in place that is supposed to provide this functionality (look for relation resources in cache first), maybe through the PromiseProxyMixin? But I don't think so/can't find any.
Cheerio.

Mmmm... I just realized that the user needs some sort of control of where the resources are fetched from, either cache or server. promiseFromCache will only work on what ie a Post resource has stored in relationships.comments.data, and only if the Comment resources in that data are also cached in the Comment service. Only in that case will the cache be used, and never again the server queried.
In all other cases service.findRelated is going to be used.
Is there any use left for promiseFromCache in it's current setup?

Maybe something like a refresh method on the Proxy object that will always query the server?

@aars promiseFromCache usage in the RelatedProxyUtil was added for a specific use case. For example, fetching a list of resources that all have the same relationship object. Perhaps a list of blog posts all by the same author. So with a default cache time on the Resource prototype of 7 seconds the relationship (post's author) will be found in the cache. For a list of 10 posts this avoids 9 requests for the same author.
Each Resource's prototype (model class) can have custom cache settings, in addition the service can use custom cache settings. I use some resources (e.g. lists of options for dropdowns) that are set to cache for 24 hours.
This wiki page has an example where the model hook checks cache first then fetches from server, https://github.com/pixelhandler/ember-jsonapi-resources/wiki/Cache

@aars regarding adding a refresh method, I've been defining custom methods on various resources as needed to change default behavior or add new behavior. For example I may add a findRelatedThings method on the model that will use the service/adapter findRelated  method, see http://ember-jsonapi-resources.com/docs/classes/ApplicationAdapter.html#method_findRelated

@aars any more thoughts on this topic?

It's been a long time.
After re-reading this issue and the code, I still don't see how this construction will fall back to server requests after cache is expired. If proxySetup is only run once, it will only decide on this once:
let promise = this.promiseFromCache(resource, relation, service);
promise = promise || service.findRelated({'relation': relation, 'type': type}, url);

I'll have to tripple-check if it is indeed only run once. If this is an actual issue, I will run into it again very soon. So I'll close this for now and research when it pops up again.


[Feature] support ignore deploy component when CRD exists

Is your feature request related to a problem? Please describe.
When I install an addon which contains a CRD operator my cluster already exists, the addon created failed.

Fetch repository successfully, Delivery helm release in progress, message: install retries exhausted, Helm install failed: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "traefik" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-namespace" must equal "vela-system": current value is "kube-system" Last Helm logs: CRD tlsstores.traefik.containo.us is already present. Skipping. creating 1 resource(s) CRD traefikservices.traefik.containo.us is already present. Skipping. Clearing discovery cache beginning wait for 7 resources with timeout of 1m0s

I want to ignore this installation only make my definitions installed, but I can't, there's no convenient way.
Describe the solution you'd like
Hope we can have some policies to ignore if there's condition.
Describe alternatives you've considered

Additional context

Since we already have support enabling addon to specific clusters by parameters.  User have way to ignore the cluster  that already installed CRD with helm . But if user only have one cluster, he cannot choose to not install addon in local cluster. I'm considering can be support a flag like "only-control-plane-resources" to only apply definition and UI-schema .etc to control-plane?


style: unify the SQL table creation statements

Changes
Update the char to CHAR, and varchar to VARCHAR  in SQL table creation statements to keep code style consistent.
Impact
No code logic change.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: ericsyh:x: webhookx-xYou have signed the CLA already but the status is still pending? Let us recheck it.


Doc search is not global

Description:
The newly added doc search that is powered by Algolia not global. This needs to be fixed because otherwise, the search restricts the users to one doc space.

Need to set site metadata as instructed in Algolia Docs

I don't think we need to have a global search, across versions. @Mariangela  what is the usecase we are trying to address?
IMO, a user will select the version and then search withing the version.

Sent two PRs1 for master and 3.0.0 branches,  We need to make sure that we update these meta tags whenever a new version is released

@shaniR , sorry, ya that was what I meant but it came out wrong. What I meant was that the search should be relevant to the version that you are in.

Reopening the issue, As we need to use facet filters to filter out the search result based on the meta tags we have put for each version of the docs

I think we still have to fix the problem of updating the algolia config per every release.For example

when we release apim 4.0 we need update above config as
  "sitemap_urls": [
    "https://apim.docs.wso2.com/en/latest/sitemap.xml", // 4.0.0
    "https://apim.docs.wso2.com/en/next/sitemap.xml", // 4.1.0
    "https://apim.docs.wso2.com/en/3.0.0/sitemap.xml",
    "https://apim.docs.wso2.com/en/3.1.0/sitemap.xml"
    "https://apim.docs.wso2.com/en/3.2.0/sitemap.xml"

  ],

This can be avoided by putting a consolidated sitemap file in the algolia config and update the consolidated sitemap per release from our side.
@shaniR WDYT ?

yes let's do it.


Update RedisTokenPersistence to use a set instead of a list

A set is the right way to deal with unique values.
Also add a script for importing a batch of tokens.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against c94e06258fb6d035db418706309ccfd6aa11b2b6

This pull request introduces 1 alert when merging c94e06258fb6d035db418706309ccfd6aa11b2b6 into aa135d370fadea22f0f642466a3d17c52ffb00c9 - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com


AQP Error: AssertionError: Found multiple or no matching columns

INPUT
SELECT COUNT(*) FROM orders where order_id >= 2
RESULT
2022-08-24 14:25:37,310 [INFO ]  ESTIMATE Aggregations: SELECT COUNT(*) FROM orders where order_id >= 2
2022-08-24 14:25:37,311 [INFO ]   - Query: SELECT COUNT(*) FROM orders where order_id >= 2, Model: ['model/instances/ensemble_single_instacart_10000000.pkl']
2022-08-24 14:25:37,311 [INFO ]   - Show Confidence Intervals: True
2022-08-24 14:25:37,311 [INFO ]   Read the ensemble in ['model/instances/ensemble_single_instacart_10000000.pkl']
2022-08-24 14:25:37,313 [DEBUG]   - Including SPN with table_set {'orders'} with sampling ratio(3421084 / 9853060.949424399)
2022-08-24 14:25:37,314 [DEBUG]  Stats: (---Structure Statistics---
# nodes             63
    # sum nodes     0
    # prod nodes    19
    # leaf nodes    42
# params            42
# edges             43
# layers            5)
2022-08-24 14:25:37,314 [INFO ]   : <train.ensemble_compilation.spn_ensemble.SPNEnsemble object at 0x7f165b5f00d0>
2022-08-24 14:25:37,317 [INFO ]   Evaluate 'SELECT COUNT(*) FROM orders where order_id >= 2:<train.ensemble_compilation.graph_representation.Query object at 0x7f165b5f0580>'
2022-08-24 14:25:37,317 [DEBUG]   In evaluate_query
2022-08-24 14:25:37,317 [DEBUG]   query.query_type = QueryType.CARDINALITY
INFO:     <IP_ADDRESS>:54028 - "GET /estimate/?query=SELECT%20COUNT%28%2A%29%20FROM%20orders%20where%20order_id%20%3E%3D%202&dataset=instacart&ensemble_location=model%2Finstances%2Fensemble_single_instacart_10000000.pkl&show_confidence_intervals=true HTTP/1.1" 500 Internal Server Error

...

  File "main.py", line 53, in aqp_read
    value = estimate(schema, dataset, query, ensemble_location, show_confidence_intervals)
  File "main.py", line 211, in estimate
    result = evaluate_an_aqp_query(ensemble_location, query, schema, show_confidence_intervals)
  File "/home/nam/Projects/traindb/traindb-ml/evaluation/aqp_evaluation.py", line 111, in evaluate_an_aqp_query
    spn_ensemble.evaluate_query(query,
  File "/home/nam/Projects/traindb/traindb-ml/train/ensemble_compilation/spn_ensemble.py", line 768, in evaluate_query
    _, factors, cardinalities, factor_values = self.cardinality(prototype_query,
  File "/home/nam/Projects/traindb/traindb-ml/train/ensemble_compilation/spn_ensemble.py", line 1007, in cardinality
    results.append(self._cardinality_with_injected_start(query, first_spn, next_mergeable_relationships,
  File "/home/nam/Projects/traindb/traindb-ml/train/ensemble_compilation/spn_ensemble.py", line 1219, in _cardinality_with_injected_start
    values, cardinality, formula = evaluate_factors(dry_run, factors, self.cached_expecation_vals,
  File "/home/nam/Projects/traindb/traindb-ml/train/ensemble_compilation/spn_ensemble.py", line 506, in evaluate_factors
    _, exp = factor.spn.evaluate_indicator_expectation(factor, gen_code_stats=gen_code_stats,
  File "/home/nam/Projects/traindb/traindb-ml/train/aqp_spn/aqp_spn.py", line 122, in evaluate_indicator_expectation
    return self.evaluate_indicator_expectation_batch(indicator_expectation, None, None,
  File "/home/nam/Projects/traindb/traindb-ml/train/aqp_spn/aqp_spn.py", line 229, in evaluate_indicator_expectation_batch
    range_conditions = self._parse_conditions(indicator_expectation.conditions, group_by_columns=group_bys,
  File "/home/nam/Projects/traindb/traindb-ml/train/aqp_spn/aqp_spn.py", line 409, in _parse_conditions
    assert len(matching_cols) == 1 or len(matching_fd_cols) == 1, "Found multiple or no matching columns"
AssertionError: Found multiple or no matching columns

SUSPECTED CAUSE

incomplete implementation of query compilation
inconsistent schema (e.g., no_compression, irrelevant_attributes)

CF. Normal case
2022-08-24 14:25:53,811 [INFO ]  ESTIMATE Aggregations: SELECT COUNT(*) FROM orders where order_dow >= 2
2022-08-24 14:25:53,812 [INFO ]   - Query: SELECT COUNT(*) FROM orders where order_dow >= 2, Model: ['model/instances/ensemble_single_instacart_10000000.pkl']
2022-08-24 14:25:53,812 [INFO ]   - Show Confidence Intervals: True
2022-08-24 14:25:53,812 [INFO ]   Read the ensemble in ['model/instances/ensemble_single_instacart_10000000.pkl']
2022-08-24 14:25:53,814 [DEBUG]   - Including SPN with table_set {'orders'} with sampling ratio(3421084 / 9853060.949424399)
2022-08-24 14:25:53,815 [DEBUG]  Stats: (---Structure Statistics---
# nodes             63
    # sum nodes     0
    # prod nodes    19
    # leaf nodes    42
# params            42
# edges             43
# layers            5)
2022-08-24 14:25:53,815 [INFO ]   : <train.ensemble_compilation.spn_ensemble.SPNEnsemble object at 0x7f165b663fd0>
2022-08-24 14:25:53,817 [INFO ]   Evaluate 'SELECT COUNT(*) FROM orders where order_dow >= 2:<train.ensemble_compilation.graph_representation.Query object at 0x7f165b663670>'
2022-08-24 14:25:53,818 [DEBUG]   In evaluate_query
2022-08-24 14:25:53,818 [DEBUG]   query.query_type = QueryType.CARDINALITY
2022-08-24 14:25:53,819 [DEBUG]  		predicted cardinality: 1345755.105466
2022-08-24 14:25:53,819 [DEBUG]  		computed prototypical cardinality in 0.0012866021133959293 secs.
2022-08-24 14:25:53,820 [DEBUG]   if len(query.group_bys) == 0 and confidence_intervals
2022-08-24 14:25:53,820 [DEBUG]   lower_bound: 1343995.131280017, upper_bound: 1347515.079651983
2022-08-24 14:25:53,821 [INFO ]  Result: ((1343995.131280017, 1347515.079651983), 1345755.105466)
INFO:     <IP_ADDRESS>:45282 - "GET /estimate/?query=SELECT%20COUNT%28%2A%29%20FROM%20orders%20where%20order_dow%20%3E%3D%202&dataset=instacart&ensemble_location=model%2Finstances%2Fensemble_single_instacart_10000000.pkl&show_confidence_intervals=true HTTP/1.1" 200 OK

moved to the traindb-model


Detected uneven workload distribution

在4张A800线上运行到1700步运行sft时，采用torch_ddp/deepspeed都会存在下面的问题：
[E ProcessGroupGloo.cpp:138] Rank 3 successfully reached monitoredBarrier, but received errors while waiting for send/recv from rank 0. Please check rank 0 logs for faulty rank.
[E ProcessGroupGloo.cpp:138] [Rank 0]: Rank 2 failed to pass monitoredBarrier in 30000 ms
[E ProcessGroupGloo.cpp:138] Rank 1 successfully reached monitoredBarrier, but received errors while waiting for send/recv from rank 0. Please check rank 0 logs for faulty rank.
2024-07-21 00:11:29,529 INFO Detected uneven workload distribution: Rank 3 successfully reached monitoredBarrier, but received errors while waiting for send/recv from rank 0. Please check rank 0 logs for faulty rank.
Original exception:
[../third_party/gloo/gloo/transport/tcp/unbound_buffer.cc:81] Timed out waiting 30000ms for recv operation to complete
Break current worker to manually join all workers, world_size 4, current rank 3, current local_rank 3
这块有没有什么思路和建议？感谢！

are you training on libritts? this is strange, never meet such error, I believe the training will continue when ddp timeout happen

问题在于出现上述异常时，cosyvoice_join返回值为True,生成的batch里面去了embedding字段，程序就会退出
if cosyvoice_join(group_join, info_dict):
break
logging.info('Add embedding')
if info_dict["use_spk_embedding"] is True:
batch_dict["embedding"] = batch_dict["spk_embedding"]
else:
batch_dict["embedding"] = batch_dict["utt_embedding"]

same error

代码更新下，可能是早期的代码barrier异常导致embedding没有用spk_embedding/utt_embedding导致的。

我也遇到了同样的问题，更新了代码没有解决，很困惑

if info_dict["batch_idx"] != 0:         # we try to join all rank in both ddp and deepspeed mode, in case different rank has different lr         try:             dist.monitored_barrier(group=group_join,                                    timeout=group_join.options._timeout)             return False         except RuntimeError as e:             logging.info("Detected uneven workload distribution: {}\n".format(e) +                          "Break current worker to manually join all workers, " +                          "world_size {}, current rank {}, current local_rank {}\n".                          format(world_size, rank, local_rank))             return False     else:         return False
还有其他barrier的地方注意捕获异常
try:     dist.barrier() except RuntimeError as e:     logging.info('except RuntimeError as e: {}'.format(e))
可以试试

好的，想问一下如果dist.monitored_barrier失败，会有什么问题吗？

这个问题是多卡数据分布式实现有些问题 单卡目前没这个问题。

找到解决方案，把dataset中的partition设为False

好的，想问一下如果dist.monitored_barrier失败，会有什么问题吗？

it is ok when dist.monitored_barrier return false, it will start next epoc training

好的，想问一下如果dist.monitored_barrier失败，会有什么问题吗？

it is ok when dist.monitored_barrier return false, it will start next epoc training

In my exp, which use my own dataset to fintune the model, it's actually caused by data distributed problem(distributedsampler has some bug) when use multi gpu，although the program doesn't break, it will restart the next epoch and cause problem again, which result the model only use very little data to train.

找到解决方案，把dataset中的partition设为False

但是每个设备会在相同的数据上训练

I also met with the same problem. I tried to train the model in a distributed manner (Two nodes with 8 GPUs  respectively), but met with the following errors:
INFO Detected uneven workload distribution: Rank 7 successfully reached monitoredBarrier, but received errors while waiting for send/recv from rank 0. Please check rank 0 logs for faulty rank.   1421	 Original exception:    1422	[../third_party/gloo/gloo/transport/tcp/unbound_buffer.cc:81] Timed out waiting 30000ms for recv operation to complete   1423	Break current worker to manually join all workers, world_size 16, current rank 7, current local_rank 7


Serve Static HTML Files Without An Extension

Update: Code has already been merged into the master branch to serve static HTML files, e.g. #102, so this issue is now how to do this without the .html extension being needed.
I think this can be done in server.js before the main handle function. That's where I redirected routes before so assigning routes to files, like /impact-reports/picture-this -> /public/impact-reports/picture-this/index.html, should be straightforward, however, I know very little about Express' request and response objects as well as node's file reading utilities.

#10 could be turned into a larger thing, but for now, we can do something as I outlined in https://github.com/vercel/next.js/discussions/12373#discussioncomment-89726
I already tested the simple way, but I didn't include any CSS/JS assets in the HTML file. I'd hope relative paths work so docroots can be pasted in the public directory.
Probably ought to try /public/impact-reports/2019/index.html as that would map to the current impact report URL structure.

related to #104.

Picture This actually included the extension anyway so not important to fix just for that project. The general solution at this point is to archive via next build && next export and then mount that in a simple web server app that can also handle redirects, tracking via cookies and logs, etc.


Mock Hardware Scene v2.5 Cleanup

This PR,

Moves the CNC machine back to give the robot slightly more clearance.
Removes unused waypoints.

@nbbrooks can you give this a quick once over and tell me what you think?
Should be something like:

cd ~/moveit_studio/moveit_studio_ws
git fetch
git checkout minor-mock-hw-cleanup
cd ~/moveit_studio
./moveit_studio build
./moveit_studio reset
./moveit_studio -v run -c picknik_ur_mock_hw_config

Unfavorite "Looping Pick and place"
I am failing to planning from Look at Machine to Grasp Left (the 2nd Move to Joint State that is run)

Unfavorite "Looping Pick and place"

Did you reset the workspace? This is not an objective that is usually available in the mock hw configuration so you may have something stale in your config.

I am failing to planning from Look at Machine to Grasp Left (the 2nd Move to Joint State that is run), every time I run it.

I wasn't getting that many failures but it did fail occasionally. I adjusted the pose to bias it towards the left waypoint. I think the orientation of the shoulder joint causes problems... 3 wpnp has been running for a few minutes now without issue.

I did not reset my workspace, Abi called me out on that, it is gone now.
The latest version (hash 14d2792) is running well for 5 loops or so, which usually it has failed by now. LGTM.


Human-readable output option for the CLI

Actually it could be the default, and the current behaviour could be behind a --raw flag


dialPeersCommand Restart

Issue description
On most node restarts I am getting a crash when dialing peers, there are no error messages reported besides the restart
Expected behavior
a normal startup
Actual behavior
dialPeersCommand looks like its causing an uncommanded restart of otnode.
Steps to reproduce the problem

Startup a node with multiple paranets

Specifications

Node version: 16.20.1
Platform: Ubuntu 22.04
Node wallet: 0xcdCE44FAe503687E857Df4071281c99F11C4619d
Node libp2p identity: 29

Error logs
Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] INFO: [otnodeUpdateCommand] (Command ID: 41b09741-2c6f-4890-a203-e9bf11d5111b)  Checking for new updates... Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] DEBUG:  AutoUpdater - Comparing versions... Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] DEBUG:  AutoUpdater - Reading app version from /root/ot-node/8.1.0+beta.12/package.json Oct 29 21:57:27 ottest4 node[27038]: Something went really wrong! OT-node shutting down... Error: Peer lookup failed Oct 29 21:57:27 ottest4 node[27038]:     at Object.findPeer (/root/ot-node/8.1.0+beta.12/node_modules/libp2p-kad-dht/src/peer-routing/index.js:144:23) Oct 29 21:57:27 ottest4 node[27038]:     at processTicksAndRejections (node:internal/process/task_queues:96:5) { Oct 29 21:57:27 ottest4 node[27038]:   code: 'ERR_LOOKUP_FAILED' Oct 29 21:57:27 ottest4 node[27038]: } Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Dialing 10 remote peers Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma1WBsooDBjD5Y1cNNL7poWRqwDZ8n1SmVvPj6dSUy6iU multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma4dyCdVTyGxuA6DZqSSiCRnTH4vpBJP59pdSqFX2Zv9S multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma4L4SfcneLGpttSLHoW8kPqaLAqtv7ZQXK8emNaqVewu multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaA4qmRAv96nByw45yA1qSMSNL6VFJptbJpFnc84y38Vv multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaApDqitcEhp4aWhZ6q4mtgXGaScXvAMhJMAvnt798w36 multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaBSE3BrZ4M1ZugmKAPjwsSvsgfnUAGmLkRaMiu2SNvwg multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qmac9ZXFENzVFM8kYxGXr9Ev7fBwmFBhQCG1XT5xjm9YGU multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaCAauGd826aEeEoGaXMfCYrZoHwhBLgxfbxQJhzeQc1k multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaEtgsG856134p3ijieDGWpzpNNyipMVbBM4XUCb1HByF multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaFMMSSvA2TCBr7sEgFXRKbv6yy6J3Wia8QPzPvpHGV18 multiaddresses in peer store. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma1WBsooDBjD5Y1cNNL7poWRqwDZ8n1SmVvPj6dSUy6iU multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma4dyCdVTyGxuA6DZqSSiCRnTH4vpBJP59pdSqFX2Zv9S multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qma4L4SfcneLGpttSLHoW8kPqaLAqtv7ZQXK8emNaqVewu multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaA4qmRAv96nByw45yA1qSMSNL6VFJptbJpFnc84y38Vv multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaApDqitcEhp4aWhZ6q4mtgXGaScXvAMhJMAvnt798w36 multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaBSE3BrZ4M1ZugmKAPjwsSvsgfnUAGmLkRaMiu2SNvwg multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer Qmac9ZXFENzVFM8kYxGXr9Ev7fBwmFBhQCG1XT5xjm9YGU multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaEtgsG856134p3ijieDGWpzpNNyipMVbBM4XUCb1HByF multiaddresses on the network. Oct 29 21:57:27 ottest4 node[27038]: [2024-10-29 21:57:27] TRACE: [dialPeersCommand] (Command ID: c0b474c9-b5c5-49b3-b744-cda35c5dd3fc)  Searching for peer QmaFMMSSvA2TCBr7sEgFXRKbv6yy6J3Wia8QPzPvpHGV18 multiaddresses on the network. Oct 29 21:57:27 ottest4 systemd[1]: otnode.service: Main process exited, code=exited, status=1/FAILURE Oct 29 21:57:27 ottest4 systemd[1]: otnode.service: Failed with result 'exit-code'. Oct 29 21:57:27 ottest4 systemd[1]: otnode.service: Consumed 6.748s CPU time. Oct 29 21:57:27 ottest4 systemd[1]: otnode.service: Scheduled restart job, restart counter is at 1. Oct 29 21:57:27 ottest4 systemd[1]: Stopped OriginTrail V6 Node. Oct 29 21:57:27 ottest4 systemd[1]: otnode.service: Consumed 6.748s CPU time. Oct 29 21:57:27 ottest4 systemd[1]: Started OriginTrail V6 Node. Oct 29 21:57:28 ottest4 node[27128]: [2024-10-29 21:57:28] USERLVL:  level-change Oct 29 21:57:28 ottest4 node[27128]: [2024-10-29 21:57:28] WARN:  ====================================================== Oct 29 21:57:28 ottest4 node[27128]: [2024-10-29 21:57:28] WARN:  Using node.js version: 16.20.1
Disclaimer
Please be aware that the issue reported on a public repository allows everyone to see your node logs, node details, and contact details. If you have any sensitive information, feel free to share it by sending an email to<EMAIL_ADDRESS>

I have the same problem like this. Is there any solution sir?


[files/deployment] don't force ansible version to 2.7

heh?
\| ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.
--
\|
\| The error appears to have been in '/var/opt/rh/rh-python35/lib/zuul/builds/e9c386b7e41f4a098264191644c60d10/untrusted/project_0/github.com/packit-service/packit-service/files/deployment.yaml': line 31, column 5, but may
\| be elsewhere in the file depending on the exact syntax problem.
\|
\| The offending line appears to be:
\|
\|     - fullchain.pem
\|   - name: Generate an OpenSSH keypair with the default values (4096 bits, rsa)
\|     ^ here

@rpitonak can you see what's wrong?
ansible-2.8.5 is installed.
And it works OK when I try the openssh_keypair module locally.

works for me locally as well

No idea why it doesn't work in Zuul so I left the usage of openssh_keypair module commented out. PTAL