No module named pathlib on install

I believe pathlib needs to be added as a dependency.
> pip install anndata
Collecting anndata
  Using cached https://files.pythonhosted.org/packages/a2/31/abf1918b45012977f1f78de6cdd01ee6c3650acae538ff8f7b0b17c1f47f/anndata-0.6.5.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "c:\users\scott\appdata\local\temp\pip-build-lzqa4a\anndata\setup.py", line 2, in <module>
        from pathlib import Path
    ImportError: No module named pathlib

This is with Python 2.7 on Windows.

Or perhaps AnnData doesn't support Python2, in which case setup.py should complain about my Python version, since after that I get another error:
    import anndata
  File "C:\Python27\lib\site-packages\anndata\__init__.py", line 1, in <module>
    from .base import AnnData, _MAIN_NARRATIVE
  File "C:\Python27\lib\site-packages\anndata\base.py", line 66
    def __new__(cls, input_array: np.ndarray, parent: Any, attr: str):
                                ^
SyntaxError: invalid syntax

Yup, we only support somehow recent python versions!
FYI: 2.7 is really old, deprecated and its end-of-life is 2020-01-01! https://pythonclock.org

Thanks for the fix @flying-sheep. I'm only using Python2 to run tests to make sure my code is backwards compatible, something I've committed to do until pandas drops support next January.
Thanks for the quick response!

That’s very laudable! Sorry if I came over preachy, it’s just that I still meet some people who are surprised that Python 2.7 is about to die :smile:

Not a problem :) A lot of users (hopefully not devs) are still using Python 2.7 though - hopefully the great python gods have a plan of how to migrate everyone across.

Ha, of course they do! A >10 year migration period should have been plenty for even the most glacial company.
Whoever is still invested in 2.7 by 2020 had it coming for a loooong time and their users should switch to a competitor.


allow building with GHC 8.6

This just requires a metadata bump on hackage.

I just realized there is already a PR for this: https://github.com/ezyang/compact/pull/8/files


[WIP] converting IS endpoints to Swagger

This patch converts the documentation for several IS endpoints to use Swagger.  As a result, some things are specified that were not previously specified.  Most notably, it specifies HTTP codes for responses (in particular, using 4xx codes for errors -- which sydent does not do, so will need to be changed).
This patch also changes the POST format to use JSON, and deprecates form encoding, as per https://docs.google.com/document/d/1oBJ86MfFGZ4TE4YaM8I9ngY7R3FED74122jRM9C54-Y/edit#heading=h.3nglpyfqz943 .  This is done as part of this PR since I was redoing those bits anyways, but if necessary, I can do it separately.
I have also separated out the endpoints for validating emails into their own sub-section, in preparation for adding documentation about phone numbers.
Some things that were previously unspecified were added based on what sydent does, such as:

the response formats for the submitToken endpoint (in particular, the differences in response between the POST and GET variants).
error codes in the JSON response

There are some question regarding things I'm unsure about.
Rendered version at https://matrix.org/speculator/spec/1427/identity_service/unstable.html, starting at Section 7 until the end.

Jenkins seems to be unhappy due to some go package, which I'm guessing is not something that this patch caused. :stuck_out_tongue:
For THREEPID_IN_USE, how safe would it be to add the leading M_?  Synapse, unless I'm missing something, doesn't seem to check the return value when it calls this endpoint, which seems kind of terrible.  :-/ I wonder what other homeservers do.

The go failure was probably related to Google Cloud having a bad day yesterday. Having restarted the build, it looks like you have some fun errors to fix: https://travis-ci.org/matrix-org/matrix-doc/builds/405055622#L1149


EaselJS/TweenJS apparent integration failure

I updated to the latest easeljs-NEXT version, and while loading resources, I'm running into...
easeljs-NEXT.min.js:formatted:4371 Uncaught TypeError: createjs.Tween._installPlugin is not a function
    at Function.b.install (easeljs-NEXT.min.js:formatted:4371)
    at Function.a.init (easeljs-NEXT.min.js:formatted:4199)
    at new a (easeljs-NEXT.min.js:formatted:4159)
    at lib (<anonymous>:88:20)
    at <anonymous>:3032:3
    at Object.a.appendToHead (preloadjs-0.6.2.min.js:12)
    at LoadQueue.a._checkScriptLoadOrder (preloadjs-0.6.2.min.js:13)
    at LoadQueue.a._finishOrderedItem (preloadjs-0.6.2.min.js:13)
    at LoadQueue.a._handleFileComplete (preloadjs-0.6.2.min.js:13)
    at preloadjs-0.6.2.min.js:12

I'm using EaselJS-NEXT from commit e6c7b9, preloadjs and tweenjs 0.6.2... this looks like an integration failure, since TweenJS does define a two-argument installPlugin, but not a one-argument _installPlugin. Any tips? Am I supposed to be using a different version of TweenJS?
My <anonymous> resource file is produced by Adobe CC Animate, and on that line is trying to instantiate a createjs.MovieClip(). This failure happens whether I use Stage or StageGL.

Looking further, it seems the version of tweenjs included in EaselJS NEXT e6c7b9 doesn't integrate properly either. Minimal reproducible follows...

Thanks! We will check it out shortly :)

Before I look into it, any chance you also updated TweenJS? There has been a pretty big refactor recently, which could explain this.

EaselJS NEXT requires TweenJS NEXT. There was a significant plugin model rewrite in TweenJS which makes plugins much more performant and flexible, but broke the old API.
Closing this for now. Please reopen if you see this problem using the latest version of TwenJS.

I do see what is probably a related problem to the infrastructure change... updated TweenJS, now exposes this error:
easeljs-NEXT.combined.js:12814 Uncaught TypeError: this.timeline._getLabels is not a function
    at lib.myMovie.p._getLabels (easeljs-NEXT.combined.js:12814)
    at test (issue.html:13)
    at onload (issue.html:15)

Code producing the above follows, written to ape the output of Adobe CC Animate...

This was indeed an issue, introduced with a refactor (MovieClip uses a getter now for labels, which changed getLabels() to _getLabels() for internal usage. TweenJS Timeline also has getLabels(), but that should not have changed.
Many thanks for finding the issue! I have pushed a fix to EaselJS and rebuilt the combined/min libs.

Hi @lannymcnie,
I'm getting the same error using the NEXT version of the libraries. This is the error I am currently experiencing:
Uncaught TypeError: createjs.Tween._installPlugin is not a function     at Function.MovieClipPlugin.install (easeljs-NEXT.combined.self-4faf71562cbf582bf59bcca559a8b09692dcd55f6244a5c8dd2460adabdc101e.js?body=1:13287)     at Function.MovieClip.init (easeljs-NEXT.combined.self-4faf71562cbf582bf59bcca559a8b09692dcd55f6244a5c8dd2460adabdc101e.js?body=1:12891)     at new MovieClip (easeljs-NEXT.combined.self-4faf71562cbf582bf59bcca559a8b09692dcd55f6244a5c8dd2460adabdc101e.js?body=1:12662)     at lib_transitions_07 (<anonymous>:96:20)     at <anonymous>:184:3     at Object.s.appendToHead (preloadjs-NEXT.combined.self-bc334785dd105c9f1d611ac69962ea03b69eea4e9633a4f0f8db508107ce24f5.js?body=1:1899)     at LoadQueue.p._checkScriptLoadOrder (preloadjs-NEXT.combined.self-bc334785dd105c9f1d611ac69962ea03b69eea4e9633a4f0f8db508107ce24f5.js?body=1:5812)     at LoadQueue.p._finishOrderedItem (preloadjs-NEXT.combined.self-bc334785dd105c9f1d611ac69962ea03b69eea4e9633a4f0f8db508107ce24f5.js?body=1:5781)     at LoadQueue.p._handleFileComplete (preloadjs-NEXT.combined.self-bc334785dd105c9f1d611ac69962ea03b69eea4e9633a4f0f8db508107ce24f5.js?body=1:5714)     at preloadjs-NEXT.combined.self-bc334785dd105c9f1d611ac69962ea03b69eea4e9633a4f0f8db508107ce24f5.js?body=1:720
I am using the latest version of the libraries on Github:
//= require tweenjs-NEXT.combined //= require preloadjs-NEXT.combined //= require soundjs-NEXT.combined //= require easeljs-NEXT.combined
and I am trying to load an exported animation from AnimateCC.
Any ideas?


Clarify inheritance semantics of annotations ProviderType and ConsumerType

Currently it is not clear from the javadoc of either ProviderType or ConsumerType which role annotation wins in case multiple ones apply (from the same package).
According to Bnd it is nearest wins, so in case you have class A extending B. And B extending C, the role of B overwrites the role of C (i.e. if C is marked as ProviderType but B is not having any role annotation at all it is assumed to be the default (i.e. ConsumerType) and A has a broad import-package version range).
Also if you have A both extending B as well as implementing Z and Z is a ProviderType, the ProviderType role wins (only relevant if Z and B are located in the same package).

Also with regards to conflicting types in package and class it is not clear how it should behave.
In case the package is marked as @ProviderType and the class within is marked as @ConsumerType what is the role?

@kwin We discussed the whole thing for half an hour and have some ideas. Just to help us along a bit: Can you provide a small dummy class example to make this easier to grasp?

According to Bnd it is nearest wins, so in case you have class A extending B. And B extending C, the role of B overwrites the role of C (i.e. if C is marked as ProviderType but B is not having any role annotation at all it is assumed to be the default (i.e. ConsumerType) and A has a broad import-package version range).

The Annotations are not marked with @Inherited and thus the extending classes/interfaces don't know about the original annotation. By the default they thus become ContsumerType if not marked otherwise.
It would make sense to mention this in the javadoc.

I added an example with README in https://github.com/kwin/providerconsumerexample which outlines the inconsistencies here.

There is no inheritance for these annotations.


Generate the proper changelog/changeset for the PR.

I am seeing way too much noise in the changelog generated by ghprb if I am merging into different release branches and using the same Jenkins Job. Would be nice to be able to see the proper list of commits/changes.
Github API does provide for a way to fetch this:
https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request
A changeset can also be generated based on the merged hash with something like:
git log pull_21^1..pull_21^2

https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch


How can I keep the bottom sheet the same size when orientation changed?

So I want the bottom sheet to be remain the same size when the orientation of the phone changes from portrait to landscape. Instead of the sheet matching the parent when its at landscape.

Can you be more specific? What layout params are you using, does the view fill the whole window (and thus force scrolling). It's likely that you're using wrap_content, and the content just fills the whole height in landscape. If you want peeked to remain peeked, you should use match_parent.

Im using your sample code atm. So when the phone orientation is on landscape mode. i want it to pop up like that in the pic.

I'm confused, I thought you didn't want it to match parent. Now you do?


Disable this control ?

how do i disable this control ?
When i set disabled prop, onli disabled input, but the click event is not disabled and show me tha options

Hi @eramos23 ,
Thank you very much for the feedback. I have added the 'disabled' check to the plugin. Can you please update the plugin to the latest version and use the following code to set the disabled status and try again?
Set the input enable/disable:
$("#test").prop('disabled', true);
Monitor the enable/disable event if necessary:
$("#test").on('disable.inputpicker', function(){
dd('disabled set: ' + $(this).prop('disabled'));
});


Javascript formatter conflict

VSCode Version: 1.43.2
OS Version: Ubuntu 18.04.4 LTS

Steps to Reproduce:
I found out by chance that VScode uses two naming options [js] [javascript] when it comes to
Javascript default formatter.
  "[js]": {
       "editor.defaultFormatter": "HookyQR.beautify"
    },
  "[javascript]": {
       "editor.defaultFormatter": "chenxsan.vscode-standardjs"
   },

The problem is when you don't know this beforehand and you have a long settings.json file.
You might run into issues as I did and could take a while to know why.
Because I believe repeated keys are not allowed by default in settings.json . At least, I get a
warning. But when you have two keys for the same setting, there is no warning.
Is it possible to have only one option?

Its not coming from VS Code out of the box. You might have two different java script extensions with different language ids. Please check your installed extensions contributions page and see if there are extensions contributing js language

Yes, more than one. I thought this IDs could be restricted inside VScode. If not, that's it. No more questions.
Thanks

Not sure what you meant by restricting language IDs. VS Code internally does not know about any language, this knowledge comes from extensions. So it cannot associate.


Comprehensive glossary/concept listing in one place

We have a lot of concepts, and names for specific things. We should have a glossary, ideally in a central place, so:

We can refer to it from lots of places.
We can use it as the single point of truth for names, and change other things if we update it.

I think this should be in github for starters. I may draft an initial one with the uncontroversial stuff, although there may be some changes on the way.

Did this.


Update Notepad++ to 7.0

Notepad++ now has a x64 version.
I simply copied the SHA1 hashes from the download page, as I'm too lazy to download the files myself. Ping me if I should change them to SHA256.

SHA1 should be fine. Thanks!


WSL2 2.0.4 Pre-release isn't working with "Connect to WSL"

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.84.0-insider (user setup)
Commit: 0c36b92c82064882a228487040187cfc13669c0f
Date: 2023-10-16T05:35:39.577Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Steps to Reproduce:

Install WSL 2.0.4
Open insiders
Connect to WSL

The editor gets stuck with "Opening remote..."

2023-10-17 01:08:25.906 [info] [LocalProcess0][resolveAuthority(wsl,1)][338ms] invoking...
2023-10-17 01:08:26.834 [info] [LocalProcess0][resolveAuthority(wsl,1)][1266ms] returned WebSocket(<IP_ADDRESS>:21102)
2023-10-17 01:08:26.834 [info] resolveAuthority(wsl) returned 'WebSocket(<IP_ADDRESS>:21102)' after 1266 ms
2023-10-17 01:08:26.880 [info] Creating a socket (renderer-Management-088b17fc-b26b-4dd5-ad0e-877a555f32a8)...
2023-10-17 01:08:26.881 [info] Creating a socket (renderer-ExtensionHost-0c3cea73-f368-4734-a253-3d8f395713c3)...
2023-10-17 01:10:40.197 [info] Creating a socket (renderer-Management-088b17fc-b26b-4dd5-ad0e-877a555f32a8) returned an error after 133316 ms.
2023-10-17 01:10:40.197 [error] CodeExpectedError: WebSocket close with status code 1006
    at WebSocket.<anonymous> (vscode-file://vscode-app/c:/Users/Paulo/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:676:3985)
2023-10-17 01:10:40.197 [error] [remote-connection][Management   ][088b1…][initial][WebSocket(<IP_ADDRESS>:21102)] socketFactory.connect() failed or timed out. Error:
2023-10-17 01:10:40.198 [error] CodeExpectedError: WebSocket close with status code 1006
    at WebSocket.<anonymous> (vscode-file://vscode-app/c:/Users/Paulo/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:676:3985)
2023-10-17 01:10:40.198 [error] [remote-connection][attempt 1] An error occurred in initial connection! Will retry... Error:
2023-10-17 01:10:40.198 [error] CodeExpectedError: WebSocket close with status code 1006
    at WebSocket.<anonymous> (vscode-file://vscode-app/c:/Users/Paulo/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:676:3985)
2023-10-17 01:10:40.199 [info] Invoking resolveAuthority(wsl)...
2023-10-17 01:10:40.199 [info] [LocalProcess0][resolveAuthority(wsl,2)][0ms] obtaining proxy...
2023-10-17 01:10:40.199 [info] [LocalProcess0][resolveAuthority(wsl,2)][1ms] invoking...
2023-10-17 01:10:40.202 [info] [LocalProcess0][resolveAuthority(wsl,2)][3ms] returned WebSocket(<IP_ADDRESS>:21102)
2023-10-17 01:10:40.202 [info] resolveAuthority(wsl) returned 'WebSocket(<IP_ADDRESS>:21102)' after 3 ms
2023-10-17 01:10:40.202 [info] Creating a socket (renderer-Management-abbea1b1-fb3a-420b-ad15-892be8a56de2)...

I just tested that code-insiders works on WSL 2.0.4.
Anything special in the WSL log?
Maybe restart WSL with wsl --shutdown?

Ah, it's the networkingMode=mirrored + dnsTunneling=true that does this

Is there any way to make vscode remote work with mirrored networking?


Add PyTorch integration

Motivation

Description of the changes

This PR progresses https://github.com/optuna/optuna/issues/4484.
Related PR: https://github.com/optuna/optuna/pull/5213.

@nabenabe0928 Could you add this CI?

@contramundum53 Could you merge this PR once you confirm it looks good to you.


Remove reundant filters (e.g. c> 5 AND c>5 --> c>5)

Which issue does this PR close?
Closes #410.
Rationale for this change
Uses boolean algebra laws to simplify binary boolean expressions.
What changes are included in this PR?
New RemoveDuplicateFilters optimizer.
Are there any user-facing changes?

(c > 5) OR ((d < 6) AND (c > 5) -- can't remove

@alamb
I Have updated the unit tests, but
(c > 5) OR ((d < 6) AND (c > 5)) should be simplified to (c > 5), isn't it?
Maybe you mean a different expression ?

Looks like a good start.
I think it's good to think of these rules as simple rewrite rules we can apply to the expression tree.
p OR p => a
p AND p => a

Some weeks ago I implemented some rules in this custom DataFusion optimizer (based on graph rewriting), you can see them here:
https://github.com/Dandandan/datafusion-tokomak/blob/main/src/lib.rs#L44
There are a lot of other patterns we can add if we do term rewriting in this way.
Also, I think we should make this optimizer run on any Expr, not just those in Filter as this would benefit any Expr (in projections, aggregations, joins, etc)

(c > 5) OR ((d < 6) AND (c > 5)) should be simplified to (c > 5), isn't it?

Yes you are correct -- I guess I was quickly trying to cook up examples similar to @Dandandan  that showed searching for an arbitrary instance of the same expression (even if it appeared in some nested structure) was going to incorrectly remove the nested instance in some cases

@Dandandan I've just added some more simplification rules (from https://github.com/Dandandan/datafusion-tokomak/blob/main/src/lib.rs#L44, as you mentioned before), What do you think ?
Still have to test and add more LogicalPlan cases (Projection, Window, Aggregation, ...) to optimize function.

Codecov Report

Merging #436 (25adf53) into master (db4f098) will increase coverage by 1.00%.
The diff coverage is 86.61%.

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   74.94%   75.94%   +1.00%
==========================================
  Files         146      154       +8
  Lines       24314    26126    +1812
==========================================
+ Hits        18221    19842    +1621
- Misses       6093     6284     +191

Impacted Files
Coverage Δ

datafusion/src/execution/context.rs
92.08% <ø> (+0.03%)
:arrow_up:

datafusion/src/optimizer/simplify_expressions.rs
86.61% <86.61%> (ø)

datafusion-cli/src/print_format.rs
81.25% <0.00%> (-9.17%)
:arrow_down:

datafusion/src/physical_plan/mod.rs
78.70% <0.00%> (-4.06%)
:arrow_down:

datafusion/src/physical_plan/window_functions.rs
85.71% <0.00%> (-3.01%)
:arrow_down:

...tafusion/src/physical_plan/datetime_expressions.rs
67.29% <0.00%> (-2.52%)
:arrow_down:

datafusion/src/physical_plan/common.rs
84.21% <0.00%> (-2.00%)
:arrow_down:

datafusion/src/physical_plan/repartition.rs
82.45% <0.00%> (-1.89%)
:arrow_down:

ballista/rust/scheduler/src/planner.rs
66.91% <0.00%> (-0.74%)
:arrow_down:

datafusion/tests/sql.rs
99.27% <0.00%> (-0.62%)
:arrow_down:

... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4f098...25adf53. Read the comment docs.

It looks good to me @jgoday
Could you fix the clippy and formatting errors?

It looks good to me @jgoday
Could you fix the clippy and formatting errors?

Should be fixed now 👍

Awesome thanks @jgoday 💯

Thanks again @jgoday 👍

Thank you @Dandandan and @alamb  for all your help!


gcc is killed during build because of RAM limitation

It seems to be a common issue while building Tensorflow from source:
Here is a quote from the official documentation:

Building TensorFlow from source can use a lot of RAM. If your system is memory-constrained, limit Bazel's RAM usage with: --local_ram_resources=2048.

Maybe we can have a flag to configure this for Bazel? I can submit a PR if @FloopCZ agrees.

Hi, sure, we can have a flag for that, feel free to make a PR. :slightly_smiling_face:


Outstanding review issues from #3096 (gridcell rotations)

Premature merge.
Outstanding comments :

lots of stickler complaints
https://github.com/SciTools/iris/pull/3096#pullrequestreview-141076488
maybe reconsider https://github.com/SciTools/iris/pull/3096#discussion_r205756026
? https://github.com/SciTools/iris/pull/3096#discussion_r205767222
? consider : combine with other code for 3d latlon/xyz transform ?  https://github.com/SciTools/iris/pull/3096#discussion_r205778183
inherited + other comments to clarify

https://github.com/SciTools/iris/pull/3096#discussion_r206112480
https://github.com/SciTools/iris/pull/3096#pullrequestreview-141902153
https://github.com/SciTools/iris/pull/3096#discussion_r206483318

should remove make-discontiguous routine : see https://github.com/SciTools/iris/pull/3127#discussion_r207522639

Missing test aspects : originally from #3103
CODE CHANGES

~angles routine should handle non-2d coords with meshgrid~

Too tricky : ABANDONED ? but this reduces the generality of "rotate_grid_angles"

ANGLES TEST ASPECTS : testing of 'grid_angles'

THINK THIS IS ALL NOW COVERED BY #3120 (check when that is accepted)
(cube)
unrecognised inputs (no shapes)
missing y + x not cube
coords

not 2d : (support?)
different shapes : error ~(except 1d?)~
different cube dims ~(2d : ok for 1d)~
different cs : error
no cs, but not angles, i.e. plain X+Y coords : ??
X/Y = coord/not, and not/coord
cell_angle_boundpoints unrecognised

ROTATE TEST ASPECTS : testing of 'rotate_grid_vectors'

u+v
u+v with angles supplied
u+v with angles derived from u
angles method key
check that magnitudes remain unchanged
check actual angles-rotation calculation (known vector + angles)
~check that non-2d cubes work~ (not supported now ?)
check masking of invalid points
check behaviour with 0-vectors ?
Exceptions:

angles not angular (bad unit)
u+v not same shape (implied by arithmetic)
angles not same dims as u+v  (implied by arithmetic)

?possibly~ :  NaN angles handling ?

Checklist of things above
Outstanding comments :
Outstanding comments :

[X] ~lots of stickler complaints~ (presumably, all fixed in #3127
https://github.com/SciTools/iris/pull/3096#pullrequestreview-141076488

[ ] "Can aa i.e. the grid cell angles also be masked, or just nans? ... should [we not always] return masked arrays in every case?"

[ ] "Any chance it would ever need to be upper-left, upper right?"
[ ] "Kinda confusing names 03_to_12 and 0_to_1"
[ ] " general purpose functions ... could we not put them somewhere else" / combine with other code for 3d latlon/xyz transform ?
inherited + other comments to clarify

[ ] "Why are v and T used here? ... docs strings are not quite finalised yet?" / clarify inherited docstrings
[ ] "a bit confusing" / comments in _grid_angles. _latlon_from_xyz
[ ] "so many commas" / comments in _grid_angles. _latlon_from_xyz

[ ] "remove this now that we're not doing contiguity checks" / remove make-discontiguous routine

All of these comments have been dealt with so I am going to close this.


Add a streaming platform to the AWS server

User Story
As a medical worker, I want there to be a streaming platform, so that I can stream the camera view smoothly while using an online connection.
Acceptance Criteria

The streaming platform should allow for 480p 30fps camera streaming.
The camera stream should not have a delay that is more than 500ms

Closing issue due to this user story being out of scope.


PowerShell version 3 not enough for normal work

The recommended version of PowerShell 3 (or later). But version 3 has limitations that violate the 'persist' group. For example, Remove-Item $ dir -Recurse -Force, sees symlink as a regular folder, and deletes everything recursively, if ($ null -ne $ file.LinkType) is always false. 5 version works fine, 4 did not check. Correct the Requirements, please.
Other, some manifests contain references to dependencies, for example in 'post_install': '$ (appdir 'notepadplusplus'), but if they are global, then the path is incorrect. There should be something like $(appdir 'notepadplusplus' $global).

PowerShell 5 is now required, so this is no longer relevant.
https://github.com/lukesampson/scoop/wiki/Quick-Start


HBASE-24458 release scripts using docker should specify needed disk consistency

These changes assume that we're running a single release  build at at time and that primarily we only need to see stuff outside of the container when it is done.
docs on delegated consistency:
https://docs.docker.com/storage/bind-mounts/#configure-mount-consistency-for-macos
Before this change (and before HBASE-22033, using my branch with HBASE-23339 in place to build an RC from master):
busbey$ grep -E "(Total time:|uilding binary dist)"  output/publish-dist.log
+ echo '2020-05-16T07:35:10Z Building binary dist'
2020-05-16T07:35:10Z Building binary dist
08:46:50 [INFO] Total time:  01:11 h
11:58:02 [INFO] Total time:  03:11 h
16:33:11 [INFO] Total time:  04:34 h
+ echo '2020-05-16T16:35:40Z Done building binary distribution'
2020-05-16T16:35:40Z Done building binary distribution

and then the final deploy took a bit over 5 hours.
after this change (now with HBASE-22033 and HBASE-23339) we see a pretty dramatic improvement:
busbey$ grep -E "(Total time:|uilding binary dist)"  output/publish-dist.log
+ echo '2020-05-29T22:54:08Z Building binary dist'
2020-05-29T22:54:08Z Building binary dist
23:17:49 [INFO] Total time:  23:34 min
23:37:57 [INFO] Total time:  19:56 min
00:49:06 [INFO] Total time:  01:10 h
+ echo '2020-05-30T00:51:52Z Done building binary distribution'
2020-05-30T00:51:52Z Done building binary distribution
busbey$ grep -E "(Total time:|uilding binary dist)"  output/mvn_deploy_release.log
03:08:57 [INFO] Total time:  47:13 min

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

_ Other Tests _

1m 35s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1813

Optional Tests

uname
Linux 38e4623f891a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

Max. process+thread count
52 (vs. ulimit of 12500)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

1m 51s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1813

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 62efc9c1651b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

Max. process+thread count
48 (vs. ulimit of 12500)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

_ Other Tests _

2m 30s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1813

Optional Tests

uname
Linux 08f3dc2c0f63 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

Max. process+thread count
55 (vs. ulimit of 12500)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1813/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Perhaps add a quick comment that it is an osx optimization and ignored with other OSes?

I didn't do that initially because that's an implementation detail of docker. the consistency statement could be used by docker on other platforms in the future. let me try including something about the OS X optimization on why we're doing it specifically.

thanks for the reviews y'all.


Port number will be ignored for temporary redirects

Description
If AllowAutoRedirects is false, the redirect handler does not honor the port number which is provided in the redirected location.
Thus redirection fails unless the default port is used.
Reproduction Steps
Force an S3 server to return a temporary redirect with a non-default port number.
Logs
Environment

SDK Version: <IP_ADDRESS>
Package Version:
OS Info: Windows 10
Build Environment: VSCode + Terminal dotnet
Targeted .NET Platform:  .NET Core 3.1

Resolution
I will provide a fix.

This is a :bug: bug-report

PR https://github.com/aws/aws-sdk-net/pull/1690 merged.


Array/Observable filter does not infer chained type

TypeScript Version:  2.6.1 using strict: true
Code
[true, true, false, null]
  .filter(thing => thing !== null)
  .map(thing => thing.toString())

Expected behavior:
Compiles
Actual behavior:
3 col 17 error| 2531[QF available]: Object is possibly 'null'.

Looks like a duplicate of #5101.
A workaround would be to write (thing): thing is boolean => thing !== null that tells us that the expression is a type guard.
Another workaround that I've found useful is to write a mapDefined helper:
function mapDefined<T, U>(iter: Iterable<T>, mapFn: (x: T) => U | undefined): U[] {
    const out: U[] = [];
    for (const x of iter) {
        const res = mapFn(x);
        if (res) {
            out.push(res);
        }
    }
    return out;
}

mapDefined([true, true, false, null], thing => thing === null ? undefined : thing.toString());

I noticed this by a different case actually, probably should have posted that one.
['foo', 'bar', null]
  .filter(Boolean)
  .map(s => s.toUpperCase());

This worked with TS ~2.3 and is not working anymore with TS ~2.6. I thought the above would be a simpler reproduction but it seems it is something completely different :) Thanks for your hint though, this helps but still required quite a few new guards in our codebase which worked in a previous TS version 😕

I just tried that with<EMAIL_ADDRESS>and it doesn't seem to work? I don't think Boolean has ever been considered a type predicate.

You're right doesn't work on arrays, we do have some rxjs observables where this works though, no idea what exactly is different there or if it's project specific.. I will report back later this week.


Pedestrian malls

Unlike most walkways, pedestrian malls and bridges (highway=pedestrian) are often very prominent features in urban areas. At higher zoom levels, they should be rendered similar to roadways but with different linework or coloring so that they aren’t confused with roads for cars.
For example, Cincinnati’s Purple People Bridge is conspicuously missing on the Ohio River:

San José State University’s paseos are easy to spot as negative space among the buildings:

The tiles include pedestrian malls in the transportation layer with class set to path and subclass set to pedestrian.


Main Example

Ran into a couple issues when I try to run the main example (examples/server.coffee)
First, I was started form a checked out version of the ShareJS repo, and was able to run the example server, but it did not work because the dist directory had not been created and populated.
After that, I followed the instructions a little closer starting from npm install share instead of a git checkout and received the following error
Error: Cannot find module 'browserchannel'
  at Function.Module._resolveFilename (module.js:336:15)
  at Function.Module._load (module.js:278:25)
  at Module.require (module.js:365:17)
  at require (module.js:384:17)
  at Object.<anonymous> (/sharejs-test/node_modules/share/examples/server.coffee:3:18)
  at Object.<anonymous> (/sharejs-test/node_modules/share/examples/server.coffee:2:1)
  at Module._compile (module.js:460:26)

Also should have mentioned, I was easily able to create the dist directory by running npm run build


Feature note component

closes: #433
closes: #369
closes: #457

@all-contributors please add @johnfercher for financial

@all-contributors please add @henriqueferraz for financial

https://github.com/all-contributors please add @henriqueferraz for financial

@all-contributors please add @henriqueferraz for financial

@all-contributors add @ppaulostradioti for financial

@all-contributors add @paulostradioti for financial

@all-contributors please add @salimNabbout for financial

I did a quick manual test and found some critical bugs 😞
Auto resize note on long text strings
https://github.com/user-attachments/assets/fbce2a54-7dbd-4b94-a966-04944747961c
Resize note issues
https://github.com/user-attachments/assets/98e3029d-505a-4a5c-bb12-7900d5b4e6a4
https://github.com/user-attachments/assets/0c0c493b-1737-4e15-9c34-b1dafe932158
Select element issues after resize
https://github.com/user-attachments/assets/dc06c037-1544-453c-9ffc-157e2312eaa8


⚠ 한경주요지수-코스피200 has degraded performance

In 888e77f, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 27549 ms

Resolved: 거래량 performance has improved in a09f0c8.


Deep Linking test call shows Warning

I added deep linking to my app as docs stated:
Its functional now, but I'm getting the following warning when testing the URI call in the simulator:

Warning: Can only update a mounted or mounting component. This usually means you called setState, replaceState, or forceUpdate on an unmounted component. This is a no-op.
Please check the code for the NavigationContainer component.

When navigating normally within the app this warning does not come up.
Your Environment

software
version

react-navigation
1.0.0-beta.11

react-native
0.45.1

same issue too

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!


Misc typo

this line
An entitlement consists of a number of PermissionSet Object put together
should be
An entitlement consists of a number of PermissionSet Objects put together

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee9ca004-0d97-1a69-e41d-fd2781a54378
Version Independent ID: ef54b78e-4dc8-b588-0226-612dda9cf42c
Content: Entitlement Object - Business Central
Content Source: dev-itpro/developer/devenv-entitlement-object.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for catching this. Will be fixed with the next doc refresh.


"SameSite" cookie feature (from issue #982)

As mentioned in #982, set_cookie() does not support  the "SameSite" cookie attribute.
This is because the http.cookies module doesn't support that either.
A reason for this isn't really given. It's just that the module was based on RFC 2109 which "SameSite" is not a part of.
In the python repository changes have been made and a pull request opened (python/cpython#214) so that http.cookies could eventually support "SameSite" natively in 3.7.
However, since this is future stuff it doesn't really make a difference for bottle at the moment and i've come to the conclusion that it would be feature that's nice to have.
So i've added this feature to bottle, and updated the docs.
It doesn't to much, i just import the _reserved dict in which valid attributes for cookies are stored,
set_cookie() now supports the keyword same_site and raises aCookieErrorif the value forsame_siteisn'tstrictorlax`.
This mimics petty much what the requested change for http.cookies in 3.7 would do.

This is a reasonable workaround. Thanks :)
We just have to remember adding a feature-gate as soon as python supports this natively.

It was my pleasure.. (=
I'm watching the open pull request anyway, so i'll have that in mind if the time has come.


Update the multisig address update at the runtime

Proposed changes
This PR updates the process of the updating the multisig address at the runtime.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[ ] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

one failure in HelloWorld e2e tests:
    TestHelloWorldABCIFourAgentsCatchupOnRegister


Test with Go 1.11 and on macOS

Those tests on macOS are flaky. They pass for me: https://travis-ci.org/AlekSi/ng/builds/421555795.


New Perler Colors 2019

https://docs.google.com/spreadsheets/d/1u9CIj65P48rnmLr3yLIg096lRP-w-txcqBVfKnaCDZc/edit#gid=866910984
I saw a thread somewhere on reddit about the colors and noticed BIORIO had the newer colors on his sheet as well. Since those are missing from Beadifier right now I wasn't sure if maybe those would help? Thanks for the awesome site btw! <3

Thanks for this @HollyJannette7,
I'll try to add them during next week!
Cheers!

@HollyJannette7
Up and running, new colors added to beadcolors
Also available in beadifier
Feel free to verify if I added everything you wanted and close if satisfy :)

Awesome! You're the best, I'll check it out in a bit. Thank you!
Get Outlook for Androidhttps://aka.ms/ghei36

From: maxcleme<EMAIL_ADDRESS>Sent: Saturday, September 12, 2020 2:22:39 AM
To: maxcleme/beadcolors<EMAIL_ADDRESS>Cc: HollyJannette7<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [maxcleme/beadcolors] New Perler Colors 2019 (#18)
@HollyJannette7https://github.com/HollyJannette7
Up and running, new colors added to beadcolorshttps://beadcolors.eremes.xyz/
Also available in beadifierhttps://beadifier.eremes.xyz/
Feel free to verify if I added everything you wanted and close if satisfy :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/maxcleme/beadcolors/issues/18#issuecomment-691453744, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMQTBITRF4YU3BO4QKNLYITSFM4V7ANCNFSM4RJD4PCQ.

Full Disclosure, I'm still new to Github. :p I'm not seeing the new colors on beadcolors or beadifier. I do see where you added it under the actions tab on here though. Is that what you were referring to when you said up and running? @maxcleme

@HollyJannette7 I guess you need to clean up your browser cache before seeing 'recent' update

That was it! haha thanks!! looks great


Add SessionID option in relogin

Add Sessionid  option in relogin

Add Sessionid option in relogin

@imDivu "cl.relogin" - need for create a new session, why add the "sessionid" option if you are creating new session? What is the point of that?


Ollie: Watch masterforpc.com

Ollie requests the watch of the watch_keyword masterforpc\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

masterforpc\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Ollie in Charcoal HQ


[gui] silx tests do not pass with matplotlib 2.1.0 (at least under windows)

To reproduce just install latest matplotlib and silx and run silx test.
It gets a recursive QWidget:::repaint: Recursive repaint detected.
My system:
python 3.6.2
silx 0.6.0
matplotlib 2.1.0
PyQt5 5.8
Qt 5.8.0

This comes from a change of behavior in matplotlib and the fact that we override the draw method in the backend to use matplotlib blitting feature to redraw faster when not change is made.
I have to check if the fix is as simple as renaming our draw method (not sure)...


Update locations of packages that have been moved or renamed

After running the laptop script, a few warnings and errors cropped up:
Warning: Formula universal-ctags/universal-ctags/universal-ctags was renamed to universal-ctags.
Warning: 'universal-ctags/universal-ctags/universal-ctags' formula is unreadable: No available formula with the name "homebrew/core/universal-ctags".
Please tap it and then try again: brew tap homebrew/core
Error: Tapping homebrew/cask is no longer typically necessary.
Add --force if you are sure you need it for contributing to Homebrew.
Tapping homebrew/cask has failed!
Installing universal-ctags/universal-ctags/universal-ctags
Warning: Formula universal-ctags/universal-ctags/universal-ctags was renamed to universal-ctags.
Warning: No available formula with the name "homebrew/core/universal-ctags".
Warning: 'parity' formula is unreadable: No available formula with the name "parity". Did you mean pari?
Warning: 'parity' formula is unreadable: No available formula with the name "parity". Did you mean pari?
Warning: Formula postgresql was renamed to postgresql@14.

The universal-ctags and postgresql formulas just needed to be renamed, but the parity formula didn't seem to exist anymore. I tracked down the missing formula to this PR on the parity repo, which cites a removed dependency as the reason for moving parity over to a gem-based install method. I added this in and removed the thoughtbot formula tap as it was no longer needed.
To test these changes I needed a way to undo the changes added by the script - I couldn't do exactly that, but I figured a usable proxy would be to remove homebrew and asdf before rerunning the script. I did so with the following command:
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/uninstall.sh)"; sudo rm -rf /opt/homebrew/; sudo rm -rf ~/.asdf;

I also added this to the README for future contributors.

I noticed that we have gem install parity as a manual command we need to run as part of the eng machine setup - I'm personally in favor of moving it to this script and removing it from the machine setup guide, but I'll defer to folks with more context.

This was confirmed to work on @demetriouswilson-gc's laptop (and my own)!


redis.clients.jedis.exceptions.JedisConnectionException is reported when executing the Cypher queries.

Hello, I discovered that when I executed the queries in the attached java file, an exception occurred:
redisgraph.zip
Exception in thread "main" redis.clients.jedis.exceptions.JedisConnectionException: Unexpected end of stream.
at redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:202)
at redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
at redis.clients.jedis.Protocol.process(Protocol.java:158)
at redis.clients.jedis.Protocol.read(Protocol.java:223)
at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:352)
at redis.clients.jedis.Connection.getOne(Connection.java:330)
at redis.clients.jedis.Jedis.sendCommand(Jedis.java:4559)
at com.redislabs.redisgraph.impl.api.ContextedRedisGraph.sendQuery(ContextedRedisGraph.java:52)
at com.redislabs.redisgraph.impl.api.RedisGraph.sendQuery(RedisGraph.java:68)
at com.redislabs.redisgraph.impl.api.AbstractRedisGraph.query(AbstractRedisGraph.java:63)
at RedisGraphExample.main(RedisGraphExample.java:32)
But if I comment out some of the queries, no error will be reported. And if these queries do not contain WHERE clauses, no error will be reported. I wonder if it is a bug. Thanks a lot!
RedisGraph Version: 2.4.11 Docker
Operating System: Windows 11
API: Cypher/Java API
JRedisGraph Version: 2.5.1

@abc123000111 Without the graph (and may be some understanding of that graph) and more information, it is difficult to check.
It could be as simple as a slow query with a short socket timeout.

Hello! The initial database state is empty. But when I execute the program, the exception is reported. However, if I comment out some of the queries or remove all WHERE clauses, no exception will be reported.
If the root cause is a slow query with a short socket timeout, how to solve it and keep connection?

@abc123000111 Seems to be RedisGraph issue. Commented there.

@abc123000111 Seems to be RedisGraph issue. Commented there.

Thank you!


Google Summer of Code 2017: Getting Started

Honeynet is applying to be a mentoring organisation for GSoC this year. The list of accepted organisations has not been announced yet! This issue is preliminary.

Mitmproxy is participating under the umbrella of the Honeynet project in the Google Summer of Code 2017. We have two exciting project proposals (link will be here soon) and are open for other ideas as well.
This issue is targeted at potential GSoC students to help them getting started and write a strong proposal. If there are any questions, please don't hesistate to get in touch. :smiley:

Picking the right students for a Google Summer of Code is hard - we really want to encourage all students to get involved with open source, but how do we determine who's best suited for a particular project? Here comes your part: Show us that you're super enthusiastic, autonomous and good at coding! :tada:
Most importantly, your proposal should demonstrate two things: You have the required technical skills and you think that mitmproxy is a super interesting project to work on.
Demonstrate that you are capable of fulfilling the project!
While many of you probably have a good theoretical background from your university, you should show us that you can code as well:

Do you have a cool/interesting side project or university project? Show it to us! Even better if it's open source and we can read the code!
Have you contributed to an open source project before? Show us what you did!
No previous projects you could show? Add a feature and/or fix a small bug in mitmproxy!

As long as you have some code to show, please don't stress yourself about this part. We require a certain minimum level of technical proficiency so that GSoC is fun for everyone, but beyond that social components are way more important to us. 😃
Demonstrate that you really want to contribute to mitmproxy!

The brick walls are there for a reason. The brick walls are not there to keep us out; the brick walls are there to give us a chance to show how badly we want something. The brick walls are there to stop the people who don't want it badly enough. They are there to stop the other people! [1]

Google accepts a variety of mentoring organizations every year, each of them with multiple projects. Now, why do you want to work on mitmproxy specifically? We do not just want to hear a chorus of praise here ("mitmproxy is a great tool"). Instead, play around with it and tell us about your experiences:

Use mitmproxy to analyze a popular Android or iOS app or anything else. There are many hidden treasures/security issues to be found [2]! Show us what you analyzed (screenshots), what you found, where mitmproxy was good/not good etc! :-)
Write a nice script that does something cool with a webpage! For example, we have an example script that turns all PNGs upside down (src). Try to come up with something creative :-)
Again, a good way to show that you're a good candidate is to fix a bug, propose or implement a feature, add something that was unclear to you to the docs, etc.

Get in touch!
We hang out on Slack (https://gsoc-slack.honeynet.org/ or the mitmproxy Slack) and our forums (https://discourse.mitmproxy.org/). Feel free to just get in touch! :smiley:
Make sure to have a plan!
For your GSoC proposal (please use the template!), you need to write down a roadmap/timeline for your project. Think about which features you need to develop to accomplish your goal, split your project into subtasks and make sure that you'll end up with a viable timeline. Having at least one dedicated task per week would be a good way to track the progress of your project as well. If you already identified potential issues/caveats for your endeavour, make sure to discuss them in the proposal as well!
Last but not least: GSoC is fun. Enjoy it! 😃 🍰 🚀

FAQ
1. There's a skilled and very motivated student already working hard on a proposal for the project I want to apply for. Should I even bother to apply?
Yes! First, if we get two convincing proposals for one project idea, we will try to just take both students¹. Second, if we cannot take you for some reason, we will actively introduce you to other projects that match your skills and interests after the application deadline². I can't stress this enough: Please do not worry about competition! If we see you cooperating with other contributors (students or not), this is a big plus.
¹) This requires that the project can be split (and extended) in a way that there are no critical interdependencies between the students. You will not get a project which depends on another student's work. This year, we can split both of our proposed projects.
²) This is not just nice talk, we successfully did this last year.
2. I want to implement $MAJOR_FEATURE_X to show that I'm a super capable student!
This is great, but please please do not send us a single giant pull request! Please try to show us that you can split major tasks into small, (mostly) isolated parts. A PR is never to small for first time contributors. :relaxed:
3. In the application template, there's a question about Windows, Unix or Mac OS X development experience relevant to your chosen project. What do you expect me to write there?
The application template is shared by all Honeynet projects. Some of our projects may require knowledge of low-level OS internals (e.g. Cuckoo Sandbox), but for mitmproxy it does not really matter. Just mention the OS you develop on and you're good.

The link to the application template is broken(gives a 404).

Fixed, thanks!

We're happy to announce that the Honeynet Project - our Google Summer of Code mentoring organisation - has been accepted to participate in GSoC this year again! :smiley:

@mhils
Although not to worry but the link for citation 2 contains url encoded character '/' as %2F.
The Current link is :
http://corte.si/%2Fposts/security/skout/index.html
It should be :
http://corte.si/posts/security/skout/index.html


exec using latest instead of configured version

Describe the bug
mise exec without explicit tool version ignores the configured (and installed) version of a tool and instead proceeds to install and use the latest version.
To Reproduce
Executed in an ubuntu docker container:
root@81cded7a8282:/# export MISE_INSTALL_PATH=/usr/bin/mise

root@81cded7a8282:/# curl https://mise.run | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5897  100  5897    0     0  27956      0 --:--:-- --:--:-- --:--:-- 28080
mise: installing mise...
######################################################################## 100.0%
mise: installed successfully to /usr/bin/mise
mise: run `/usr/bin/mise --help` to get started

root@81cded7a8282:/# mise install<EMAIL_ADDRESS>openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS, mixed mode, sharing)
mise<EMAIL_ADDRESS>✓ installed
                                                                                root@81cded7a8282:/# mise ls
Plugin  Version              Config Source Requested
java    corretto-<IP_ADDRESS>.1

root@81cded7a8282:/# mise use -g<EMAIL_ADDRESS>mise ~/.config/mise/config.toml tools<EMAIL_ADDRESS>
root@81cded7a8282:/# mise exec java -- java -version
openjdk version "23-loom" 2024-09-17
OpenJDK Runtime Environment (build 23-loom+2-48)
OpenJDK 64-Bit Server VM (build 23-loom+2-48, mixed mode, sharing)
mise<EMAIL_ADDRESS>✓ installed                                                                                openjdk version "23-loom" 2024-09-17
OpenJDK Runtime Environment (build 23-loom+2-48)
OpenJDK 64-Bit Server VM (build 23-loom+2-48, mixed mode, sharing)

root@81cded7a8282:/# mise --version
2024.5.2 linux-x64 (2576af6 2024-05-02)

root@81cded7a8282:/# cat /root/.config/mise/config.toml
[tools]
java = "corretto-<IP_ADDRESS>.1"

Expected behavior
Prior to version 2024.4.8, mise exec would use the configured version:
root@e671e81952df:/# curl -L https://github.com/jdx/mise/releases/download/v2024.4.7/mise-v2024.4.7-linux-x64 > /usr/bin/mise
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 21.4M  100 21.4M    0     0  37.0M      0 --:--:-- --:--:-- --:--:-- 37.0M

root@e671e81952df:/# chmod +x /usr/bin/mise

root@e671e81952df:/# mise install<EMAIL_ADDRESS>openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS, mixed mode, sharing)
mise<EMAIL_ADDRESS>✓ installed

root@e671e81952df:/# mise use -g<EMAIL_ADDRESS>mise ~/.config/mise/config.toml tools<EMAIL_ADDRESS>
root@e671e81952df:/# mise exec java -- java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 21.0.3+9-LTS, mixed mode, sharing)

mise doctor output
version: 2024.5.2 linux-x64 (2576af6 2024-05-02)
activated: no
shims_on_path: no

build_info:
  Target: x86_64-unknown-linux-gnu
  Features: DEFAULT, GIT2, NATIVE_TLS, OPENSSL
  Built: Thu, 2 May 2024 02:04:32 +0000
  Rust Version: rustc 1.77.2 (25ef9e3d8 2024-04-09)
  Profile: release

shell:
  (unknown)

dirs:
  data: ~/.local/share/mise
  config: ~/.config/mise
  cache: ~/.cache/mise
  state: ~/.local/state/mise
  shims: ~/.local/share/mise/shims

config_files:
  ~/.config/mise/config.toml

backends:
  cargo
  go
  npm
  pipx
  ubi

plugins:
  bun     (core)
  deno    (core)
  go      (core)
  java    (core)
  node    (core)
  python  (core)
  ruby    (core)

toolset:
<EMAIL_ADDRESS>
env_vars:
  MISE_INSTALL_PATH=/usr/bin/mise

settings:
  activate_aggressive = false
  all_compile = false
  always_keep_download = false
  always_keep_install = false
  asdf_compat = false
  cargo_binstall = true
  color = true
  disable_default_shorthands = false
  disable_tools = []
  experimental = false
  go_default_packages_file = "~/.default-go-packages"
  go_download_mirror = "https://dl.google.com/go"
  go_repo = "https://github.com/golang/go"
  go_set_gopath = false
  go_set_goroot = true
  go_skip_checksum = false
  jobs = 4
  legacy_version_file = true
  legacy_version_file_disable_tools = []
  node_compile = false
  not_found_auto_install = true
  paranoid = false
  plugin_autoupdate_last_check_duration = "7d"
  python_compile = false
  python_default_packages_file = "/root/.default-python-packages"
  python_pyenv_repo = "https://github.com/pyenv/pyenv.git"
  raw = false
  trusted_config_paths = []
  quiet = false
  verbose = false
  yes = false
  ci = false
  debug = false
  trace = false
  log_level = "info"
  python_venv_auto_create = false

  [status]
  missing_tools = "if_other_versions_installed"
  show_env = false
  show_tools = false

No warnings found
1 problem found:

1. mise is not activated, run mise help activate or
   read documentation at https://mise.jdx.dev for activation instructions.
   Alternatively, add the shims directory /root/.local/share/mise/shims to PATH.
   Using the shims directory is preferred for non-interactive setups.

Additional context
I suspect #1926 introduced the difference in behavior.

While this is a bug, you can just not specify the arg and it would work as you're expecting.


Extract json from dry_result_command output

Make sure output (e.g. simplecov) does not break the rspec helper.

@RobWu Does #119 work for you?

@RobWu Does #119 work for you?

@kaspernj
Getting error https://github.com/kaspernj/peakflow_utils/pull/119#issuecomment-770707144

@RobWu I am not sure what is happening. I am using this in 5 other projects where it causes no such error. How are you running the executable?


Do not unregister themingParticipantChangeListener.

This is a proof of concept fix for #27097

Thanks @nicksnyder, the fix is good.


Metrics: fix success code

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

[ ] Add tests and docs: Please include testing and documentation for your changes

[ ] Lint and test: Run make lint and make run-tests

AI Description

This pull request updates the get_success() function in the metrics.py and metrics_helper.py files.
Summary
The get_success() function now returns True for status codes in the range of [200, 300) instead of [200, 400). This change aligns the function with the standard convention that status codes in the 200 range indicate a successful response.
Changes

Updates the get_success() function in metrics.py to return True for status codes in the range of [200, 300).
Removes a print(response.json()) statement from the agents() function in metrics_helper.py.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@0bf8b73). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage        ?   85.65%
=======================================
  Files           ?      153
  Lines           ?     5716
  Branches        ?        0
=======================================
  Hits            ?     4896
  Misses          ?      820
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot upgrade to 4.1.2 from 4.1.0

I have Lens 4.1.0 installed on my MacBook. Every time I open it, I get prompted to upgrade to 4.1.2. But if I click "Yes", Lens just exits, and nothing happens.

Here are the relevant logs:
info: [UPDATE-CHECKER]: User chose to update now
info: Downloading update from Lens-4.1.2-mac.zip, Lens-4.1.2.dmg
info: Update has already been downloaded to /Users/jrittner/Library/Application Support/Caches/kontena-lens-updater/pending/Lens-4.1.2-mac.zip).
info: / requested
info: /1613765018199-2569.zip requested
info: /1613765018199-2569.zip requested by Squirrel.Mac, pipe /Users/jrittner/Library/Application Support/Caches/kontena-lens-updater/pending/Lens-4.1.2-mac.zip
info: APP:QUIT
warn: No update available, can't quit and install
error: Error: Error: No update available, can't quit and install
at MacUpdater.quitAndInstall (/Applications/Lens.app/Contents/Resources/app.asar/node_modules/electron-updater/out/MacUpdater.js:185:24)
at /Applications/Lens.app/Contents/Resources/app.asar/static/build/main.js:1:108165
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:94:5)
2021-02-19 15:03:38.764 Lens[41134:15853864] Download completed to: file:///Users/jrittner/Library/Caches/com.electron.kontena-lens.ShipIt/update.N5eNPLA/1613765018199-2569.zip

I'm seeing the same behavior.

Please download a fresh installer package from GitHub and do the manual install. Version 4.1.2 contains the fix for this auto-update issue on MacOS.


[Azure.Monitor.Query]Update LogsQueryClientBuilderExtensions.cs

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

Will need to export the API.


Forgot the support of SQLCipher...

Codecov Report
Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6de3400) 47.73% compared to head (88bcdb8) 47.02%.
Report is 2 commits behind head on master.

Files
Patch %
Lines

sqlite3.go
72.56%
22 Missing and 9 partials :warning:

sqlite3_type.go
0.00%
17 Missing :warning:

callback.go
75.00%
5 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   47.73%   47.02%   -0.71%
==========================================
  Files          13       13
  Lines        2055     1952     -103
==========================================
- Hits          981      918      -63
+ Misses        929      895      -34
+ Partials      145      139       -6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Quantization code in different path to where specified in Help Documentation

Following the documentation here to Quantize - https://www.tensorflow.org/versions/r0.12/how_tos/quantization/index.html
seems to be wrong.
I had to change
bazel build tensorflow/contrib/quantization/tools:quantize_graph bazel-bin/tensorflow/contrib/quantization/tools/quantize_graph \ --input=/tmp/classify_image_graph_def.pb \ --output_node_names="softmax" --output=/tmp/quantized_graph.pb \ --mode=eightbit
TO
bazel build tensorflow/tools/quantization/quantize_graph bazel-bin/tensorflow/tools/quantization/quantize_graph \ --input=/tmp/classify_image_graph_def.pb \ --output_node_names="softmax" --output=/tmp/quantized_graph.pb \ --mode=eightbit
ie it seems like it's moved from tensorflow/contrib to tensorflow/tools/

Thanks! Would you submit a PR with the documentation fix and reference this issue?

Just sent out a PR so this will be fixed shortly.


ApolloError not defined

AuthenticationError, ForbiddenError, ApolloError on GatewayDataSource are not defined

Should be fixed by this one: https://github.com/apollographql/federation-subscription-tools/pull/4


IE9 support

As nice as material icons look they do not render/work in IE9. Since IE9 is still in use by millions of users it's important to continue support for it.
Since this is a bootstrap date time picker it makes sense to use the Glyphicon package that is bundled with Bootstrap, so that no additional resources are needed.

When supporting IE9, replace
chevron_left

with


(details: https://design.google.com/icons/#ic_chevron_left)
So I think following example will work.
$("#datepicker").bootstrapMaterialDatePicker();
$("i.material-icons").each(function() {
  var icon = $(this).text().trim();
  var map = {
    chevron_left: "",
    chevron_right: ""
  }
  var code = map[icon];
  if (code) {
    $(this).html(code);
  }
});

I think it would be better to have a fallback for IE9 instead of simply replacing meterial icons by glyphicons.


Optional Bundle Items

There are a few moving parts.
The Bundle Items are great if you have a complex set of indicators, but for just starting out they may not be necessary.
It would be great to have Indicator Items directly linked to an Indicator Bundle, then if you need to expand at a later date you can move to Indicator Bundle Items which allows you to re-use the same Indicator Item.
I'm not wedded to this idea so if it's too hard, we can drop it.

Closed as we are discussed it in the sprint and we are all happy with indicator bundle items


What does max_pending_requests mean for non-HTTP traffic

I'm learning how to use CircuitBreaker in Envoy.
I just read the doc and I found two configs:

max_connections
(UInt32Value) The maximum number of connections that Envoy will make to the upstream cluster. If not specified, the default is 1024.
max_pending_requests
(UInt32Value) The maximum number of pending requests that Envoy will allow to the upstream cluster. If not specified, the default is 1024. This limit is applied as a connection limit for non-HTTP traffic.

I just can't understand what "This limit is applied as a connection limit for non-HTTP traffic." means.
For HTTP traffic, max_pending_requests means that "The maximum number of pending requests that Envoy will allow to the upstream cluster.", right?
But for non-HTTP traffic, it says "as a connection limit". Now I'm confused.
If max_pending_requests is a connection limit for non-HTTP traffic, then what does max_connections mean for non-HTTP traffic. Are they the same for non-HTTP traffic?

This limit is applied as a connection limit for non-HTTP traffic.

Based on my experiments I think that this is not what happens. But max_connections and max_pending_requests are somehow related.
I have a test setup where max_connections is 10 and max_pending_requests is 3. (notice that max_connections is larger than max_pending_requests). In practice it means that a cluster may have maximum 10 TCP sessions opened at any given time. max_pending_requests defines that max 3 sessions may "wait" for upstream connection. "pending" is a transitory state and once upstream handshake completes, a "pending" request becomes a connection.
In the second test, I had max_connections set to 3 and max_pending_requests set to 10. In this case I was never able to queue more than 3 pending requests. It seems that when a new session is queued as pending request, it is also counted as connection. So in practice max_pending_requests is min(max_pending_requests, max_connections).
I will double check the logic in the code and update documentation. Thanks for catching it!

@alyssawilk

I believe max_pending_requests becomes max_pending_connections, limiting the number of not-yet-established connections separately from max_connections

@alyssawilk I cannot find max_pending_connections in the code or in api.
After tracing under gdb the logic for TCP conn pool seems to be:

check if number of connections in the cluster is lower than max_connections
if yes, create connection pool. Check number of pending requests is lower than max_pending_requests
if yes, call TcpActiveClient which increments max_connections counter: https://github.com/envoyproxy/envoy/blob/main/source/common/conn_pool/conn_pool_base.cc#L775


[WIP] Add duffle bundle docs

This PR introduces the the command duffle bundle docs/info, and the concept of self-contained docs for invocation images.
Currently, the spec states that the /cnab directory of the invocation image MAY contain [...] a README.md or README.txt - if we decide to go ahead with self -contained docs for invocation images, we would modify it to be the spec-compliant equivalent of (at least) highly recommended.
Notes:

this PR is currently marked as WIP because it does not yet handle all possible cases for doc files, and because of a few other items marked as TODO (see below).

essentially, when executing the command, a container with the bundle's first docker-type invocation image is created (not run), and the documentation file is copied from the container to a temp file on disk. That file is read, then rendered as markdown on the console.

To test:
$ duffle inspect pulumibase:0.1.0 --insecure
{
    "name": "pulumibase",
    "version": "0.1.0",
    "description": "",
    "invocationImages": [
        {
            "imageType": "docker",
            "image": "radumatei/pulumibase:0.1.0"
        }
    ],
    "images": [],
    "parameters": null,
    "credentials": null
}
$ duffle bundle docs pulumibase:0.1.0 --insecure
<rendeded markdown of https://github.com/deislabs/bundles/blob/master/pulumibase/README.md>

TODO:

[ ] handle all possible documentation files
[ ] decide if docs should be a directory reserved by the spec, and this command would copy it, if present.
[ ] discuss how the visual installer would interact with this command (and the addition of flags to handle the output for renderers other than console)
[ ] if the PR to samfoo/mdcat is merged, switch the dependency to that - otherwise, keep the current fork.
[ ] solve bug in renderer for # headers
[ ] solve bug where the tar header is present in doc file (see below)

README.md
0100777 0000000 0000000<PHONE_NUMBER>6<PHONE_NUMBER>4 010553  0
ustar 00

Moved discussion in https://github.com/deislabs/cnab-spec/issues/118.


Fix Display Mode for Markdown Formulas

Restores correct display of block formulas in markdown parts (current status left).

I'm also changing the default behaviour of the katex-viewer to render math in display mode, which seems more appropriate to me for clerk/tex results as well. These were using inline mode so far.
Effects are visible in this notebook https://snapshots.nextjournal.com/clerk/build/8833c19119905e53367b2d19d83f17912fbd280a/index.html#/notebooks/viewers/tex.clj.

This change introduces a scrollable overflow on markdown blocks which contain formulas. @joe-loco do you have an idea what's going on here https://snapshots.nextjournal.com/clerk/build/8833c19119905e53367b2d19d83f17912fbd280a/index.html#/notebooks/viewers/tex.clj?

@zampino Fixed the inline formula scrolling and disabled auto-quoting blockquotes.

Can we merge this? Maybe excluding 6e2f40f if it conflicts with https://github.com/nextjournal/clerk/pull/140?

@zampino Fine to merge! No need to exclude https://github.com/nextjournal/clerk/commit/6e2f40f68ff92a3680d47016a137c421f61f3a06. #140 is entirely experimental at this point.


Add @discardableResult to catch

With PromiseKit 3 it is now possible to put always blocks at the end of the chain. The proposed change will remove the annoying  "Result to call is unused" warning from Xcode.

True, thanks.


refactor(onboarding): consolidate onboarding flow logic.

Description
This solves a few problems with the current onboarding flow logic:

The logic for which screen to go to next in onboarding is currently spread out throughout the different onboarding screens. This makes it difficult to see in-code how the onboarding flow actually works with its different branching options. With this refactor all that logic would be in one place
The logic for the 'Step X of Y' is currently totally separate from the logic of which screens come after one another in onboarding. This duplication of logic is confusing and messy. With this refactor we have a traversable graph that can be used to calculate the steps without separate logic that must change every time a screen is added.

Test plan

More unit test coverage than there was before for the onboarding flow
Unit tests of the Onboarding directed graph ensuring that counters always increment and the graphs always end up at Home.

Related issues
https://linear.app/valora/issue/ACT-597/refactor-onboarding-screen-logic
Backwards compatibility
yes

also one thing that concerns me a little is that the user's state could potentially change between when they start onboarding and when they finish, which could introduce a bug like a step getting added to the number of total steps, or even a cycle. not sure what the best way of dealing with that is, though.. maybe just making sure it's covered in integration tests?


Lookup command + Player logging

Players now have their last ckey, MC username, firstseen and lastseen attached. This is so admins ingame can match MC names to ckeys, even when players are offline. It also means I can check for players seen in the last 7 days and gauge interest over time.
WIP because I need to test it.

Selfmerging is fine if youre the only person


Add support for multichannel images

By default, DIGITS converts RGBA images to RGB. It would be useful to add support for 4-channel PNG (or maybe TIFF) images. Most of the code for 4-channel PNG images is already there.
I tried with modifications to the image.py in utils, but the modifications need to be done in other places too. I can add this functionality if someone points me to the files that need to be modified for this to be done as simply as possible.

Supporting 4-channel image data might not take too much work. One complication is that we'd need to disable JPEG encoding when saving to LMDBs. Unfortunately, I don't have time to scope it all out right now.
FYI, eventually we want to accept many more data types with something like https://github.com/NVIDIA/DIGITS/issues/197#issuecomment-136896978.

@jmancewicz you were looking into this last week, right? Any updates?

The change to image_to_array to also accept 4 channels was added with #1188


Can't compile in ubuntu 18.04

Hi i'm getting this error below, anyone have an idea what could it be? Thanks in advance.
/chia-plotter/src/chia_plot.cpp:16:10: fatal error: sodium.h: No such file or directory
#include <sodium.h>
^~~~~~~~~~
compilation terminated.
CMakeFiles/chia_plot.dir/build.make:75: recipe for target 'CMakeFiles/chia_plot.dir/src/chia_plot.cpp.o' failed
make[2]: *** [CMakeFiles/chia_plot.dir/src/chia_plot.cpp.o] Error 1
CMakeFiles/Makefile2:449: recipe for target 'CMakeFiles/chia_plot.dir/all' failed
make[1]: *** [CMakeFiles/chia_plot.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking CXX executable test_phase_3
[100%] Built target test_phase_3
[100%] Linking CXX executable test_phase_1
[100%] Built target test_phase_1
Makefile:135: recipe for target 'all' failed
make: *** [all] Error 2

Readme stands that the instruction is for Ubuntu 20.04. I am successfully using chia-plotter on 21.04.
What is the command that you are running and getting the error?

sudo apt install libsodium-dev

sudo apt install libsodium-dev

I have libsodium already installed, i read in reddit i have to make some modification in cmakefile.
"I’ve made a few pull requests to the repo. You don’t need Xcode but so need /opt/homebrew on your cmake path. This can be done by editing the Cmakefile or putting it in your shell’s environment. This is true for both sodium and gmp.

Readme stands that the instruction is for Ubuntu 20.04. I am successfully using chia-plotter on 21.04.
What is the command that you are running and getting the error?

I'm havinhg this error when trying to compile no binary is being build because of that.

It is documented that it is not straight forward to compile madMAX at Ubuntu 18.04. Could be CMAKE build file modified to be compatible with older cmake??
It will be nice to have an option to build static binary, in that case I will be able to build madMAX at Ubuntu 20.04 and run binary at Ubuntu 18.04...

cmake 3.14 requirement is because of chia code from bls-signatures, nothing I can do about it

check bottom of readme how to install latest cmake on 18.04

I installed cmake 3.2 so is being used this newer version looks like this is not the problem is soemthing about libsodium wich is installed but sodium.h is not being seen in building process, do i have to point any path of the library libsodium when running the command of building? Maybe because my cmake 3.2 is locally installed on user folder but i update the path in bashrc and it should work i don't know the steps i should take to point the path of the library if this is the reason of the error.

I have also gcc 7.5.0 that impact in something? It should be a newer version?

hmm I've managed to compile it on 18.04 just by installing latest cmake like this: https://askubuntu.com/questions/1203635/installing-latest-cmake-on-ubuntu-18-04-3-lts-run-via-wsl-openssl-error

But i installed cmake 3.2 when i run cmake --version it shows that cmake 3.2 is installed correctly.

But i installed cmake 3.2 when i run cmake --version it shows that cmake 3.2 is installed correctly.

I installed cmake manually to Ubuntu 18.04 (Linux Mint 19.3) and I was able to build madMax. I see something different, so I assume you installed wrong version of cmake.:
$ cmake --version
cmake version 3.20.4

$ which cmake
/usr/local/bin/cmake

$ ls /usr/local/share/cmake-3.20/
Help  include  Licenses  Modules  Templates

cmake can be get from here: https://cmake.org/download/


Fix invalid rubocop errors

When running ViewComponent in VSCode I started getting a ton of errors
from Rubocop despite the project using standardrb and requiring it in
the rubocop config.
This fixes the issue by using the inherit_gem option in the rubocop
config.

TIL about inherit_gem :)


python37: fix distutils C++ patch

Motivation for this change
Update distutils patch to the upstream changes.
See: https://github.com/python/cpython/commit/6c0e0d1
Fixes https://github.com/NixOS/nixpkgs/issues/64615
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python37

Thanks!  Pushed to staging-next, succeeds on Hydra and now being picked to staging-19.03.


Add stl parts

https://github.com/ervanalb/covid19/issues/1
I have updated the parts that I downloaded the other day.  If there were updates in the last few days, I can update this PR.

Thanks!


Possibility to configure availability zones

As a developer
I want to be able to configure the AZs Zookeeper runs in
In order to have a low latency between Zookeeper and my application by running them in the same AZ

Closing issue since configuring only one AZ would decrease the availability.


Define subset of rules for consensus rule engine

Create PoAConsensusRulesRegistration and add there rules that we need.
Those are rules that we will need:
Header rules:

HeaderTimeChecksPoARule - (new rule) description below
PoSHeaderVersionRule
PoAHeaderSignatureRule - (new rule) description below

Integrity rules:

BlockMerkleRootRule - validate that the calculated merkle tree matches the merkle root in the header
PoAIntegritySignatureRule - (new rule) - make sure signature from header is equal to signature in block we've received

PV rules:

SetActivationDeploymentsPartialValidationRule
TransactionLocktimeActivationRule
BlockSizeRule
CheckPowTransactionRule
CheckSigOpsRule

FV rules:

SetActivationDeploymentsFullValidationRule
LoadCoinviewRule
TransactionDuplicationActivationRule
PoACoinviewRule (new rule) - like PoWCoinviewRule but without subsidy
SaveCoinviewRule

Done


Write doc tests in api.py

Not working on it actively moving to ready-status

Not working on this actively moving this to ready state

Not working on this actively moving this to ready state

Lower priority.


How can I Config the wireless frequency channel to 5Ghz or 2.4Ghz？

I have seen the selection in Windows 10 Settings , but I can only config the Ssid and Passphrase in this Api ,witch api can config the frequency channel ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e23f3be-25ae-6bf1-62f4-ce28271f7c10
Version Independent ID: b92e0055-df10-3245-5f9a-3dc9e351139e
Content: NetworkOperatorTetheringAccessPointConfiguration Class (Windows.Networking.NetworkOperators) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.networking.networkoperators.networkoperatortetheringaccesspointconfiguration.yml&version=GBlive&_a=contents
Product: uwp
Git Login: wdg-dev-content
Microsoft Alias: wdg-dev-content

Hi, @Thxzzzzz, thanks for raising this issue. I'm working with the product team to see whether we can get you a response. I'll get back to you with any progress. ~Steve

Would this be a feasible workaround? Append the frequency to the name of your SSID (5Ghz or 2.4Ghz, depending what it's set to). For example, you could name an SSID : MyExampleWiFiSSID_5Ghz.

@stevewhims Thanks for your help,But name my SSID with 5Ghz or 2.4Ghz dosn't really change the frequency of the mobile hotspot .
I am using Qualcomm QCA9377 WiFi chip .There is an option in       Windows 10 settings - Mobile Hotspot - Edit     can actually config the SSID Passphrase & band frequency (2.4Ghz or 5Ghz),But with  NetworkOperatorTetheringAccessPointConfiguration Class I couldn't config the band frequency. Or maybe is there any way I can call the Edit dialog using any code? Just like ms-settings:network-mobilehotspotedit can call Mobile Hotspot Settings Window. My English is not good enough ,Wish you don't mind.

I don't know whether this will help, but here are some more thoughts/info. Normally, a physical wireless router supports dual band (5Ghz and 2.4Ghz). By default, many of these routers come with dual band enabled by default. So, setting up two access points doesn't normally require two independent routers - it is simply a configuration change. Also, wireless manufacturers discourage the configuration of dual band routers with the same SSID because clients connecting to the access point can get confused and have connectivity problems if the adapter supports only one band. Hence, it is recommended to set up different SSIDs for different bands.
Are you able to configure the router to broadcast different SSIDs by band? The API doesn't support configuring which to prefer, so that would be your option.

@stevewhims Really appreciate for your help. There seems no way to meet my needs for now.Thank you for you time.

Thanks for filing the issue, @Thxzzzzz, and my apologies we couldn't give you a better answer. I'll close this issue now. ~Steve


Error with findModules()

Hello, I am trying to begin using WGCNA for a project of ours.
When I attempt to load the modules for the PyWGCNA object I receive an error when eigengenes  are being calculated.

import PyWGCNA, os
import numpy as np
import pandas as pd

PATH_1 = "datasets/Heart_Left_Ventricle.v8.normalized_expression.bed"
PATH_2 = "datasets/gene_tpm_heart_left_ventricle.gct"
PATH_3 = "datasets/expressionList.csv"
# Assuming `fulldata` is your DataFrame and it has been loaded correctly
fulldata = pd.read_csv(PATH_1, sep='\t', header=0)

fulldata_2 = pd.read_csv(PATH_2, sep='\t', header=0)

# fulldata_3 = pd.read_csv(PATH_3, header=0)

# Transpose the dataframe and select columns
datExpr0 = fulldata.iloc[:, 4:390].T  # Python uses 0-based indexing
datExpr1 = fulldata_2.iloc[:, 3:389].T  # Python uses 0-based indexing
# Set column names to gene_id
datExpr0.columns = fulldata['gene_id'].values
datExpr1.columns = fulldata_2['Name'].values

# Set row names (index)
datExpr0.index = fulldata.columns[4:390]
print(datExpr0.index.str.replace("-", ""))
datExpr1.index = fulldata_2.columns[3:389]

datExpr0.index=datExpr0.index.str.replace("-", "")
datExpr1.index=datExpr0.index.str.replace("-", "")
# View the dataframe
print("#1", datExpr0)
print("#2", datExpr1)
# print("#3", fulldata_3)
gsg = PyWGCNA.WGCNA.goodSamplesGenes(datExpr0)

allOK = gsg[-1]
print(allOK)
if not allOK:
    # Optionally, print the gene and sample names that were removed
    if sum(not gsg[1]) > 0:
        print("Removing genes:", ", ".join(list(datExpr0.columns[~gsg[1]])))
    if sum(not gsg[0]) > 0:
        print("Removing samples:", ", ".join(list(datExpr0.index[~gsg[0]])))

    # Remove the offending genes and samples from the data
    datExpr0 = datExpr0.loc[gsg[0], gsg[1]]
print("PICKING THRESHOLD")

DSet = PyWGCNA.WGCNA(name='GTEX-111FC',
                     species='Humans',
                     geneExp=datExpr0,
                     outputPath=os.path.realpath(''),
                     TOMType='unsigned',
                     powers=[10],
                     # sft=sfT,
                     # cut=2,
                     networkType="unsigned",
                     save=True)

DSet2 = PyWGCNA.WGCNA(name='GTEX',
                      species='Humans',
                      geneExp=datExpr1,
                      outputPath=os.path.realpath(''),
                      TOMType='unsigned',
                      powers=[10],
                      # sft=sfT,
                      # cut=2,
                      networkType="unsigned",
                      save=True)

print("PREPROCESSING")
DSet.preprocess()
# DSet2.preprocess()
print("FINDING MODULES")
DSet.findModules()

This is the dataframe I pass to the PyWGCNA object,  I have to modify it to be in the correct format.

Hello, thank you for responding.
The goodSamplesGenes() was a oversight from an earlier test.
What do you advise for the script? Is the negative values the cause?

it might be but I'm not sure ...
can you send me a subset of your data that will give you the same error?
you can change the row and column names of your data with something else if your data is not publicly available

data_heart_left_ventricle_sample.csv
Here is a subset of the dataset I am using, it is from https://gtexportal.org/home/datasets

I was able to run PyWGCNA on the dataset you provided!
I would suggest check the version of all your all the other packages which I listed mine here
also the python version I have is 3.10.4
I also put my script bellow just in case
`
import PyWGCNA
import pandas as pd
tpm = pd.read_csv('data_heart_left_ventricle_sample.csv', index_col=0)
test = PyWGCNA.WGCNA(name='GTEX-111FC',
species='Humans',
geneExp=tpm,
TOMType='unsigned',
powers=[10],
networkType="unsigned",
save=True)
test.preprocess()
test.findModules()
`

Thank you!
I reinstalled my packages with the same versions as the PyWGCNA requirements and everything runs as intended!
Before this issue is closed, are there any plans to add support for Cytoscape networks in future versions of PyWGCNA?
https://manual.cytoscape.org/en/stable/Supported_Network_File_Formats.html

great!
Sorry but for now, I don't have a plan to add support for Cytoscape networks:)
but if you want to give it a shot, you're welcome to do and I will be happy to help you integrate that with PyWGCNA


Merge Amber Cronin's changes into Project-Faster (viasat)

May need some information on why we need this change etc.

1571012385 paper.pdf

1571012385 paper.pdf

Do you need to make changes? We can keep the PR open and you can upda it without having to recreate it.

1571012385 paper.pdf

@funglee2k22 Do you need to make changes? We can keep the PR open and you can update it without having to recreate it.

Thanks I re-openned it.

@funglee2k22 Another thing also occurred to me, there is the method quicly_set_cc which allows to change the CC algorithm used for the next connections that are received.
I think that there should be a mirror method quicly_set_ss to reflect the new functionality.

Hi, I emailed a patch earlier today with that change.

Hi, I emailed a patch earlier today with that change.

Ok but i would ask you to add it to your original branch.

quick note: the comments where in draft and not visible by my mistake

Hi, I emailed a patch earlier today with that change.

Ok but i would ask you to add the change to your original branch, also please include all the other changes i've suggested or respond to the comments at the very least.
EDIT: my comments were not visible

Checking the code more closely its better to leave only quicly_set_cc, because otherwise we would need to remove the const qualifier from the quicly_cc_type_t which would surely be poorly recevied

With last two commits i've fixed the build error and corrected the tests execution:

The change is also aligned with current changes on quicly master so i think we can proceed to make the PR to upstream.

Hi, I emailed a patch earlier today with that change.

Ok but i would ask you to add the change to your original branch, also please include all the other changes i've suggested or respond to the comments at the very least.
EDIT: my comments were not visible

Checking the code more closely its better to leave only quicly_set_cc, because otherwise we would need to remove the const qualifier from the quicly_cc_type_t which would surely be poorly recevied

That function should not be making any modifications that remove the const qualifier, and should just be doing the updates to the slow start struct as are currently being done during connection startup in quicly.c

Hi, my comment was just underlining that fact, the change in the end is unnecessary and the same functionality is achieved via the context.

Fixed Amber's comment and i've launched again the tests with success. I'll now prepare the branch with all the changes and make a new PR.

Continued on https://github.com/Project-Faster/quicly/pull/2


there should be a key binding to close chart windows

chart windows should be closable from the keyboard
i suggest ctrl+w

You can already close them with Alt+F4.

you close editor tabs with ^W, wouldn't that be more consistent here?

Sure, we can add an additional hotkey. Just from the title I was interpreting it as there is no way to close them now, which would be surprising as all OSs that I'm aware of have a default "close window" hotkey that works without the app having to do anything.


Service with express not working

Hi,
I'm trying to create a service with express following the example. But it doesn't work. It's always raising this error:

ServiceSchemaError: Service name can't be empty! Maybe it is not a valid Service schema.

I only removed the external dependcy with the test service in order to simplify it.
This is the code. Thanks in advance.
"use strict";

let { ServiceBroker } = require("moleculer");

let ApiGatewayService = require("moleculer-web");

let express = require("express");

// Create broker
let broker = new ServiceBroker({
	logger: console
});

// Load API Gateway
const svc = broker.createService({
	mixins: ApiGatewayService,
	name: "myservice",

	settings: {
		middleware: true
	}
});

// Create Express application
const app = express();

// Use ApiGateway as middleware
app.use("/api", svc.express());

// Listening
app.listen(3333, err => {
	if (err)
		return console.error(err);

	console.log("Open http://localhost:3333/api/test/hello");
});

// Start server
broker.start();

I tried your example and it works, no ServiceSchemaError.

After several tries, I discovered that launching the service with  node services\myservice.js  runs well, but with npm start or npm run dev is when it failes:
 "scripts": {
    "dev": "moleculer-runner --repl --hot services",
    "start": "moleculer-runner services"
  },

I think there is some base problem. If you can start your service file with node services\myservice.js it's wrong. A service should be similar as this:
const { MoleculerError } = require("../src/errors");

module.exports = {
	name: "math",
	actions: {
		add(ctx) {
			return Number(ctx.params.a) + Number(ctx.params.b);
		},

		sub(ctx) {
			return Number(ctx.params.a) - Number(ctx.params.b);
		},

		mult: {
			params: {
				a: "number",
				b: "number"
			},
			handler(ctx) {
				return Number(ctx.params.a) * Number(ctx.params.b);
			}
		},

		div: {
			params: {
				a: { type: "number", convert: true },
				b: { type: "number", notEqual: 0, convert: true }
			},
			handler(ctx) {
				let a = Number(ctx.params.a);
				let b = Number(ctx.params.b);
				if (b != 0 && !Number.isNaN(b))
					return a / b;
				else
					throw new MoleculerError("Divide by zero!", 422, null, ctx.params);
			}
		}
	}
};

Your file is a simple Node app which creates broker, loads a service and starts a broker. But these steps should do Moleculer Runner. I recommend you that create a project with moleculer init and modify the services\api.service.js to use express. Like this

The problem with that approach is how I get the service to join it to express framework:
const app = express();
app.use("", svc.express());

I'd need svc object from somewhere, and I don't know how to get with your approach.
Do you see my point?
(thanks again for your support)

Great.
That makes sense.
Thanks a lot for your help.
I close the issue.