Update bug_report.md

Description

Updating bug report to include our latest releases.
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

/azp run


Pulled last main version - error while running in Docker

Hi all, pulled the last main version, did a docker build for local testing, made config work, and got this error:
2024-04-21 21:02:32 {"time":"2024-04-21T19:02:32.831655304Z","level":"INFO","msg":"loading plugins"}
2024-04-21 21:02:32 {"time":"2024-04-21T19:02:32.831742429Z","level":"ERROR","msg":"failed to load exporter plugin system","error":"open /plugins/exporters: no such file or directory"}
Any help is welcome :D.
Kr,
Wilco

@Spazzy757 Do you want to dive into this?

Thanks for catching this @WBurggraaf, I've merged the fix and it should now work!


Option to get variables as JS object instead of JSON

First, huge props on this library, it's just what I was looking for. 👍
I was wondering if it would be possible to add an option to get the sass variables as a JS object instead of the data structure as you have it. For example:
Instead of this:
{
  "$primary": {
    "type": "SassColor",
    "value": {
      "r": 255,
      "g": 239,
      "b": 213,
      "a": 1,
      "hex": "#ffefd5"
    },
    "sources": [
      "/Users/adamgruber/Sites/sassy-styled/src/colors.scss"
    ],
    "expressions": [
      "papayawhip"
    ]
  },
  "$baseMargin": {
    "type": "SassNumber",
    "value": 4,
    "unit": "px",
    "sources": [
      "/Users/adamgruber/Sites/sassy-styled/src/colors.scss"
    ],
    "expressions": [
      "4px"
    ]
  },
  "$baseBorder": {
    "type": "SassList",
    "value": [
      {
        "type": "SassNumber",
        "value": 1,
        "unit": "px"
      },
      {
        "type": "SassString",
        "value": "solid"
      },
      {
        "type": "SassColor",
        "value": {
          "r": 0,
          "g": 0,
          "b": 0,
          "a": 1,
          "hex": "#000000"
        }
      }
    ],
    "sources": [
      "/Users/adamgruber/Sites/sassy-styled/src/colors.scss"
    ],
    "expressions": [
      "1px solid black"
    ]
  }
}

I'd like to get this:
{
  $primary: 'rgba(255, 239, 213)',
  $baseMargin: '4px',
  $baseBorder: '1px solid rgba(0, 0, 0)'
}

The reason is that I'm creating an app using styled-components which supports themes. The themes are just plain JS objects. I have an existing style guide written in SASS and I wanted to use the variables in the style guide as the theme for my components.
I am currently able to do what I need using this library and a function I wrote to transform the sass-extract data structure to plain JS. I just thought it might be something that could be added to your library. I was thinking it could be added to the rendered.vars.global object as a toJS() function.
Then it could be used like this:
const style = require('sass-extract-loader!./theme.scss');
const theme = style.global.toJS();
/* theme ==>
{
  $primary: 'rgba(255, 239, 213)',
  $baseMargin: '4px',
  $baseBorder: '1px solid rgba(0, 0, 0)'
}
*/

I created this gist that shows the function I'm using to do the transform.

@adamgruber thank you for your feedback!
I understand your point and I agree that it can be useful to transform the result into other formats based on the use case. The current structure is very generic for the purpose of being able to use it in many different ways without having to parse strings and so on. The idea was that you just as you did can use that result to transform it in any way you need that fits your use case.
I am thinking about adding a feature to serialize the result where you can pass in transformation functions similar to what you have in your gist, and that might include a few bundled transformations for common formats like the one you are mentioning, which would be to just generate css-like strings from the variables. These would be css-like because it might not be valid css due to the nature of sass variables, they can be fairly arbitrary values. This feature will likely be included in a near future release. This will be similar to what is being done in #4 and will likely be released with that.

Thanks for the response. I get why you built this as you did, makes total sense. I think a feature to serialize the result would be an awesome addition.

A serialize / compact option for the loader would be awesome.
I completely understand why the current output is as verbose as it is, it certainly has it's uses, but an option for compact output would be awesome. Not only does it make general consumption easier, but it also makes your bundle size smaller.
Looking forward to seeing this implemented - great work on this library @jgranstrom!

I started to work on a library using my gist from above. It serializes the sass to JS. Hope to release it within the next few days.

@adamgruber nice! Is it an intermediary loader?

@jeffijoe It's standalone right now, not a loader.

The new plugin support from version 1.0.0 comes with a bundled minimal plugin that will give you a proper serialized variant of the output with support for all kinds of nested data types.
This can be used with the loader from version 1.0.0 and sass-extract from version 1.0.1.
npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>const style = require('sass-extract-loader?{"plugins":["minimal"]}!./theme.scss');
/* theme ==>
{
  $primary: 'rgba(255, 239, 213)',
  $baseMargin: '4px',
  $baseBorder: '1px solid black'
}
*/

Go ahead and try it and see if this works in the way you need it to. You can also have a look at the bundled plugins and see if one or a combination of those is what you are looking for, or use it as a reference to create your own plugin for your specific case.

@jgranstrom Thanks for your hard work on this package. The new version is awesome and fixes all the issues I saw. Also the plugin architecture is really nice. I took the project I was working on and converted it to a plugin, sass-extract-js. I think it works much better as a plugin instead of standalone.


DE translation for ifttt and mqtt component

Description:
updated German (DE) translation for IFTTT and MQTT component to English ground truth.
Related issue (if applicable): none
Pull request in home-assistant.io with documentation (if applicable): none
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

https://developers.home-assistant.io/docs/en/internationalization_translation.html


Merge spec into config?

This is mostly regarding #36 and #92.
What about merging the spec into the config, but split the boot configuration into a separate file? The benefit would be that it would be intuitive which files are templates (everything except the config), all templates were referenced in the config using a filename and everything could be YAML.
The resulting layout and file formats would be:
# data/config.yaml
api_version: v1alpha2
groups:
  - name: X
    ignition: x-i.yaml
    cloud: x-ci.yaml
    boot: x-b.yaml
    metadata:
      x: y

# data/boot/x-b.yaml
kernel: /assets/coreos/976.0.0/coreos_production_pxe.vmlinuz
initrd:
  - /assets/coreos/976.0.0/coreos_production_pxe_image.cpio.gz
cmdline:
  "coreos.config.url": "http://bootcfg:8080/ignition?uuid=${uuid}&mac=${net0/mac:hexhyp}"
  "coreos.autologin": "",
  "coreos.first_boot": ""

The loss here is that
The boot configuration does need to split into a separate file and probably allow a template to be used instead of YAML. It is difficult for NetBoot to capture everything one might wish to do in an iPXE script or GRUB config.
{
    "id": "etcd_profile",
    "cloud_id": "",
    "ignition_id": "etcd.yaml",
    "boot": {
        "kernel": "/assets/coreos/899.6.0/coreos_production_pxe.vmlinuz",
        "initrd": ["/assets/coreos/899.6.0/coreos_production_pxe_image.cpio.gz"],
        "cmdline": {
            "cloud-config-url": "http://bootcfg.foo/cloud?uuid=${uuid}&mac=${net0/mac:hexhyp}",
            "coreos.autologin": "",
            "coreos.config.url": "http://bootcfg.foo/ignition?uuid=${uuid}&mac=${net0/mac:hexhyp}",
            "coreos.first_boot": "1"
        }
    }
}

One disadvantage is that a Spec (to be called Profile in v0.3+) is a named bundle of the boot, ignition, and cloud configs which can be used by many machines. This allows CoreOS to define common Profiles, keep them updated and versioned, and ship higher level products (UIs, CLIs) which include them -  independent of the hundreds of machine groups to which they may be assigned. I can maybe see a case for specifying individual ignition, cloud, or boot configs, but referencing a Profile works as well.
The config.yaml will not be the only way to define Group and Profile resources going forward.
The boot configuration probably does need to split into a separate file, I agree with you. This is needed to allow a template to be used - it is difficult for NetBoot to capture everything one might wish to do in an iPXE script or GRUB config.
{
    "id": "etcd_profile",
    "cloud_id": "",
    "ignition_id": "etcd.yaml",
    "boot_file": "ipxe.tmpl"
}

The data directories cloud and ignition (and maybe netboot) contain templates to produce files expected by hosts. For Profile and Group resources, JSON is used.

Sounds reasonable.
I just suggested moving the remainings of the spec.json into config.yaml, after moving the PXE/GRUB related parts into an own file, because the spec.json would have looked rather empty. I don't really care for either way.
I would suggest using just one format, JSON or YAML, for configuration. Or supporting both and letting the user decide on what he likes more.

The YAML config file will disappear in v0.3.0 since the machine groups it defined are more "data" than service configuration. Groups and Profiles need to be read from JSON documents in the store to add remote storage (like EtcdStore), replication, and allow machine groups without restarting the running service.
Thanks for bringing up issues about the organization - it helps as the project continues to mature. If a config is added back in the future, I'd aim to have it be a convenience for specifying the command line flags.


Maatwebsite Laravel Export 500 internal eror with file not found

i have a problem when i want to export excel with XLS always server response file not found
and i try with CSV its running well and successfully, on my case, i try on localhost its very well, and another hosting its running well too,, why the server cannot responds like another server?? please help,... because the server is only one i have,,
Please prefix your issue with one of the following: [BUG] [PROPOSAL] [QUESTION].
Package version, Laravel version
Expected behaviour
Actual behaviour
Exception stack trace
Screenshot of Excel file
Steps to reproduce the behaviour

I would advise to first check if your server meets all requirements: http://www.maatwebsite.nl/laravel-excel/docs/getting-started

i get this issue,, finnaly in laravel logs say "open_basedir restriction" and its on httpd.conf on my server, thank you very much @patrickbrouwers . where do you came from?? nice to meet you..

Nice!
I'm from the Netherlands, nice to meet you too.


Mailchimp limits email subject to 150 characters

Campaign.js trims the newsletter's subject to 15 words which is enough in most cases. Yet, I have had the case where 15 words are more than 150 characters and the Mailchimp campaign fails.

On a related note, I wonder if it's possibly worth making a setting for the subject line that gives you the option to do the current behavior or use a custom field.  I ended up hard coding a subject for mine, but that's clearly a yucky solution.
Thoughts?  Anyone want that?  I'd be happy to do it if other people would find it useful.

@jshimko Personally I like the fact the subject is always "up to date" without the need for a manual update. If you want to preserve this feature and add the ability to manually tweak it, will it become a bit complicated (as in "do you want to prepend or append something", etc.)?

It's actually not bad at all.  It's just an input field that allows you the ability to switch between the current behavior or the value of that input field.  I can't see any reason why it would be much more than a dozen or so lines of code across a few files.
Pretty much just a settings schema addition...
var newsletterSubject = {
  propertyName: 'newsletterSubject',
  propertySchema: {
    type: String,
    optional: true,
    autoform: {
      group: 'newsletter',
      instructions: 'Leave blank for default subject line or type your own here',
      private: true
    }
  }
}
addToSettingsSchema.push(newsletterSubject);

and then something like the following on this line.
// uses value of input field or defaults to original behavior if empty
subject: getSetting('newsletterSubject', trimWords(subject, 15))

Sorry @jshimko my comment was not clear at all. What I meant is personally, I could potentially want to prepend a custom text, but I would still want to append a concatenation of the posts' titles. Something like (subject of the newsletter):

New this week on xyz: How to...

I think this latter, dynamic part is important for my users. But maybe it's just me and other people would rather replace the title completely with a static string.
Thing is, it adds a bit of complexity to the UI since it can't just be a "toggle" in this case.

Thanks! And I agree, I don't think a setting for the subject is needed for now. Maybe later once we rethink the settings area to be a bit easier to navigate (maybe have a way to toggle "advanced" options)?


test: migrate to mocha

Description
This is a complete migration to mocha including full setup.

Uses expect for assertion.
Uses jiti for require.

Additional context
This is the full migration and requires every test file under playground to have one top level describe block and setup before and after hooks since it will allow proper setup and teardown for Mocha (some said nested describe is the Mocha way).
This PR only launches and shut down Chromium one time before and after the test.
Since Jest magically sets NODE_ENV to test, I have replicated this behavior with VITE_TEST_SERVE since NODE_ENV sometimes can be production.
Obviously, there are some tests failing.
Some cleanup will be done in the following commits if this PR is accepted.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

insane you have done this much.
personally I think we should be migrating to vitest, a in development project by Antfu  which is powered vite.


Copy follow-up instructions to README

For reference after the configuration script was run.

Fixed @llucax


Avoid hanging with parallel_tests

ParallelTests.last_process? returns true if the process is the last one to start.  We are
interested in the last test to finish so we want to use ParallelTests.number_of_running_processes
Because it's possible to have the parallel_tests gem in your project and still run tests serially we
want to also check if tests are currently being run in parallel.  If ENV['TEST_ENV_NUMBER'] is defined we know tests are currently being run in parallel.

applying this fix is allowing me to run parallel specs with SimpleCov v0.17.0 again

Glad to hear it @mcmoyer! By any chance is your coverage report correct?  My tests don't hang any more, but the coverage report is way low and I haven't had a chance to look into it yet.

@annaswims - my coverage report appears correct.

This seems to have fixed some hangs in the activeadmin's test suite as well.

New version is released: https://rubygems.org/gems/simplecov/versions/0.17.1

There was an open issue, I missed it. Sorry everyone :disappointed:

heck, I’m just happy to see it addressed so quickly.  Thanks for the quick turn around.

@mcmoyer sure, thanks :) However it's sad that it was in the wild for 2.5 months, one of the drawbacks of not working on a big ruby app where I'd test out every release immediately any more. Plus reduced OSS time :| I'm glad I checked in today.

Thanks everyone for fixing and releasing this! Will upgrade activeadmin test suite to use 0.17.1, and get back here after I confirm the issue is really gone.

We did get a jruby crash after the upgrade, but haven't seen any hangs while using this code. My guess is that the crash was previously happening too, but being hidden by the hang. So I think this PR should be good, but I'll update again if I see any issues.

@deivid-rodriguez thanks! You might want to report the crash to our JRuby friends so that they can have a look :)

Yes, I'll definitely report it! :)


Shared Require Plugin

Hey Sokra,
This is my first webpack plugin and contribution to the open source community.
The issue that I was faced with is that we have multiple projects and even some runtime loadable code and many developers. Some parts of one project may run standalone or is loaded by another project.
The idea is that we'd like to have separate webpack and some non-webpack projects but be able to share code in memory without duplicating it.
To do this I created a plugin that:

Uses the request as the module id instead of an integer so require("jquery") because _webpack_require("jquery")
Causes the bootloader to construct and use internal and a global table for installed modules. it checks the internal table first then the global table then constructs the module and puts it in the global table.
Allows modules that are defined as external to be require()'d without throwing a build error
Skips rendering modules that are defined as external

Now using this plugin I can successfully have loadable code that assumes its dependencies have already been loaded.
There are many more features that I'd like to add to it such as being able to wait until' a dependency is loaded and etc...
I'd like to get your opinion on this plugin. it is located at:
https://github.com/EliteScientist/SharedRequirePlugin

Hey, feel free to add the plugin to the list of plugins.
I'm closing the issue as there hasn't been a lot of activity. But thanks for contributing.


feature/GLUE-1325 modified es5 persistence to use ES Rest instead of …

…transport

This was a mistake.  Was supposed to be a merge into a fork.  My appologies.


Running it in headless linux machine

Hi,
Need to obtain an wallet address, not founding any guides on running the nexoa-cli in a headless linux (debian) machine. Please provide instructions.
Thanks.

I did it.
Follow this steps:

Download the qt zip neoxa-qt-linux64.zip from the current repo

i get a crash on Ubuntu 20.04
./neoxa-qt
"Floating point exception (core dumped)"


Cannot Re-open Developer Tools

I am having this issue when I select Debug > Show Developer Tools.  I am able to open the window initially.  However, if I close the window and again select Debug > Show Developer Tools the window does not pop up.
Steps to Reproduce:

Select Debug > Show Developer Tools
Close the window
Select Debug > Show Developer Tools

Expected:  Dev tools appear
Actual:  Window does not appear
I have to re-start Brackets in order to access Developer Tools.  I have tried reloading without extensions.  I am on OS X 10.10 on Brackets 1.1.

Closing.. did not perform enough trouble shooting... seems fine now  :)


Shortcut to search tasks doesn't focus input search field when popup menu isn't showing

Hi, again!
I recently set the keyboard shortcut to search tasks (the one that goes by the label "Open popup menu and search tasks").
When I use the keyboard shortcut (with the popup menu hidden), what seems to happen is that the popup menu appears with the search input focused; then the popup menu's height is updated (and, in my case, the menu becomes scrollable) which causes the search input to lose focus.
If I use the keyboard shortcut whilst the menu is already showing then the menu's height seems to update whilst keeping the search input focused.
This effectively means that I have to use the shortcut twice to be able to search immediately. :)
Once again, thank you for the amazing extension!

Should be fixed now. Let me know if it works.

Cheers.


Remove VMARGS_FILE from "command" release command

As per #367, this is a patch that removes invoking vm.args when running the bin/release command command. VM args are generally for the actual running process, and reusing sname may cause issues when running commands on a server with a running node.

Thanks!


Navigation icon back arrow goes back to hamburger when NavigationPage is set to MasterDetailPage.Detail.

Expectation:

Open MasterDetailPage menu. Hamburger icon becomes back arrow.
Push a new page onto the navigation stack and the back arrow should stay, indicating to the user they can navigate backwards.

The following meets the expectation:
new NavigationPage(new MasterDetailPage() { Detail = detail, Master = master });

The following does not:
new MasterDetailPage() { Detail = new NavigationPage(detail), Master = master };

The back arrow changes back to a hamburger menu and the user is left thinking the navigation drawer should open again, but instead the page action is to pop the page off the stack.

i think this is normal behavior when you change the detail to a new Nav Page it is resetting the Nav.

I'm not quite sure which method is correct as I've seen it done both ways. Personally, I prefer wrapping the MasterDetailPage in a NavigationPage, but some people wrap the detail page. There doesn't seem to be a "correct" answer, so it makes it hard to fix.

Fixed in 6f2917d.


Setup: Add program folder to user's PATH

Setup is currently adding the program folder to the system PATH but that's not available unless the user is running with elevated privileges (which seems a bit strange).
The solution is to add this to USER path instead.

FIXED


Cleanup / always run task

Hey everyone,
I have a requirement to run background processes during my build. IE start IIS Express, start a node js process.
The problem is that I need to clean up these processes after a build has finished. Which is all good if there are no Task Failures.
Does anyone have a pattern to handle these type of requirements? Or is it best practice to start the processes outside of PSake?

This functionality has been added with #285


my Honor points have decreased

After solving the last Kata the number of Honors points instead of increasing decreased by about 300,
what is the point?

when I solved the next two Katas, the number of Honor points returned to the previous state

http://shouldiblamecaching.com

@wiosen There is sometimes a delay between finishing a kata and updating the stats. These days there are (seemingly) some general problems (see #1329) already tracked, so you may close this issue (click "close" at the bottom).


[Feature] Proxied Java Class Can be Extended by JS Class

Java classes cannot be inherited by JS classes to override methods.

It'll take 40 hours to implement this feature. Who is going to sponsor the development?

It'll take 40 hours to implement this feature. Who is going to sponsor the development?

If this feature can be realized, I am willing to sponsor the development, please give me the sponsorship channel!

It'll take 40 hours to implement this feature. Who is going to sponsor the development?

I've tried imitation and it works, but it doesn't work well.


SSO with intranet sample and the template Enterprise Assistant Bot (Root Bot, People Bot, Calendar Bot) not working

Is it an issue related to Adaptive Cards?

[X] Yes, this is an Adaptive Card issue but it is specific to Web Chat.

Do you have any screenshots?
No response
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
IFRAME
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Chrome (latest)
Which area does this issue affect?
Attachment: OAuth card
Is this an accessibility issue?

[ ] Yes, this is an accessibility issue.

Please describe the bug
Dear Team,
We attempted to use the sample provided at https://github.com/microsoft/BotFramework-WebChat/tree/main/samples/07.advanced-web-chat-apps/c.sso-for-intranet for our situation: SSO from our intranet with the Enterprise Assistant Bot template found at https://docs.microsoft.com/en-us/composer/templates/enterprise-assistant-overview,
Our three bots—Root, People, and Calendar—can currently communicate via an Exchange Token and OAuth from Azure AD.
The OAuth Card continued to appear when we tried to ask for persons or the calendar. The OAuth Card shouldn't be displayed.
Regards and thanks
Nghi
Do you see any errors in console log?
No error
How to reproduce the issue?

Copy the html file from the sample
Replace with our Direct Line token

What is the expected and actual behavior?
Expected: should be seamless for OAth with Azure AD for SSO
Actual: still show the OAuth card to login
Adaptive Card JSON
No response
Additional context
No response

Thank you @nghivo, we are investigating.

Hi @ramfattah ,
Hope that there is any progress on the investigation.

Hi @nghivo,
As QnA service is deprecated, I can't seem to run the Enterprise Assistant Bot from my local machine.

Discussing this internally for the next steps.
Thanks for your patience.

Hi @nghivo,
As QnA service is deprecated, I'm not able to run the Enterprise Assistant Bot from my local machine.

Discussing this internally for the next steps.
Thanks for your patience.

Hi @ramfattah ,
We can close this issue as it is resolved with support from Shanghai team.
Thanks.


Fix grouped style header + tableview background colors

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
A bug was filed pointing out that the TableViewCell grouped style looked incorrect as the background was all white instead of being light grey in the header/footer areas. To fix the issue, TableViewHeaderFooterView background has been reverted to clear color as it used to be in fluent 1.
As part of this PR, I made changes to TableViewCell's background colors to not use elevated colors so it stays consistent with its behavior in fluent 1.
Verification
The changes were tested on the demo app.

Before
After

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

"As part of this PR, I made changes to TableViewCell's background colors to not use elevated colors so it stays consistent with its behavior in fluent 1." i am confused by this. Fluent 1 tableviewcell colors to change when elevated. please test iPad. @sophialee0416 you would have more context?

"As part of this PR, I made changes to TableViewCell's background colors to not use elevated colors so it stays consistent with its behavior in fluent 1." i am confused by this. Fluent 1 tableviewcell colors to change when elevated. please test iPad. @sophialee0416 you would have more context?

Initially I looked at #1147 but looking at #1148 it seems like only the tableview background had elevated colors.

Please add screenshot of ipad split mode with group styled tableviewcell. In main branch the cell and the background color changes

Please check the ipad keyboard selection color of the cell too

whatever you do. make sure actioncells and booleancells etc are also consistent behavior.


Add arm64 debug visualizer and update VS SDK package for VSIX

The build failure is because the vpack prerelease tag (like semver) doesn't like underscores in its name, and the prerelease tag is built from the branch name, which has an underscore. Everything else was successful.


PR: Fixed typos; added .DS_Store to .gitignore.

Hi Alex,
I couldn't help myself -- I fixed a couple typos in your playground.

setQoute() -> setQuote()
VIPERQuoteInterator -> VIPERQuoteInteractor

And for some reason Xcode deleted the timeline.xctimeline file.

Thanks Chris!


Add logging support [enhancement]

This is a feature request, it would be great if hyper supported logging much like docker logging:
https://docs.docker.com/reference/logging/overview/
Ideally I'd like to be able:

See logs like 'docker logs ...'
Plug in my own logger driver 'docker run --log-driver=...'

As GO supports structural typing maybe the docker logging drivers could be supported without actually adding the docker dependency back in or having to implement the drivers all over again!
https://github.com/docker/docker/blob/master/daemon/logger/logger.go
Or maybe we really should just go the more unix way and just make sure we can pipe from the TTY console.

the feature was implemented by #112


mpd module not updating

[module/mpd]
type = internal/mpd

host = <IP_ADDRESS>
port = 6600
password =

interval = 2

label-song-maxlen = 72

format-online =  <label-song>
format-playing-underline = ${colors.underline}
label-offline =  mpd is offline

]$ polybar -vvv
polybar 3.1.0-64-g4f6e374

Features: +alsa +curl +i3 +mpd +network +pulseaudio

X extensions: +randr (+monitors) -render -damage -sync -composite +xkb +xrm +xcursor

Build type: RelWithDebInfo
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -Wextra -Werror -Wno-noexcept-type -O2 -pedantic -pedantic-errors
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now

I use Mopidy as my server.
Status, i.e. playing/paused, track name doesn't update and stay like that until I restart polybar. Polybar binary doesn't seem to say anything about this module - it just freezes like that.
Also, not configured here, but clicking on shuffle label seemed to cause huuge problems with my player ncmpcpp - it can't enable/disable shuffle mode anymore. Pressing pause () seemed to be very delayed.

Do other modules still update (like the date module)? The pause button still works in polybar, even if the module is frozen.

Hm, I have restarted Mopidy, because ncmpcpp also started acting weird, and problem seems to go away. I suspect it has something to do with Polybar's interaction with MPD - will try to add pause button back and click it, or do something else.

So yeah, it has something to do with clickability of the module. I checked output of mopidy - it keeps getting incoming connections from local machine every few seconds, even after polybar hanged.
Here is proper steps to re-produce issue:

Have <toggle> and <icon-random> in format-online
(use mopidy as mpd server? is it causing the issue?)
tap random icon to enable random mode. It is reflected in ncmpcpp.
tap random icon again. nothing happens. (optional?)
tap pause button. Music pauses. Polybar module doesn't change at all. Everything else - time and stuff - keeps working.
tap (still) pause button. Nothing happens.
go to ncmpcpp and un-pause music. Nothing happens in Polybar module.
tap pause button. Music pauses.
restart polybar. mpd module now reflects current state of a music: pause button was replaced with play button. Pressing play button starts music, but polybar module doesn't change.

Alright, so polybar stops outputting stuff, but the buttons still work.
I suspect, polybar hangs when tapping the 'random' button.
Can you try to see, if this happens, when you tap other buttons instead of 'random'
<icon-prev> <icon-stop> <icon-next> <icon-repeat>
Also please run polybar with the -l trace flag while you're doing this and post the whole output here. (You may need to recompile polybar and add -DCMAKE_BUILD_TYPE=Debug to the cmake command to enable trace logging)

With 'repeat' button it's a little different. It kinda worked - it changed color, but after I tapped it again, repeat status wasn't removed in player. Also some kind of delay appeared. When I pressed pause button, it hanged again - I could resume playing, but mpd module stopped updating.
About logging - sure, give me some time.

The same problem here: mopidy with internal/mpd module of polybar:
Each control button works, but the artist-song label sometimes stays unchanged.

该mpd模块在显示歌曲信息时，无法显示中文，有解决方法吗

@zj2423651950 I used google translate to translate your question. I have same problem with japanese symbols, but I suspect this is because neither of my fonts have them. Anyway, it's better to create new issue for this problem - this one discusses different issue.

@SuperPrower any update on the logs?

@patrick96 sorry, I was in the middle of midterms.
Here is log. I started music, then I clicked 'random' button several times, then I paused music, then I started it again, after it, mpd module hanged. I only had i3 and mpd modules for this test. Unfortunately, I can't pinpoint exact locations of 'clicks' in log, but I hope it'll help:
* Loading config: /home/superprower/.config/polybar/config
- config: Current bar section: [bar/mpd_test]
* Loaded monitor eDP1 (1920x1080+0+0)
* Found matching X resource "background" (value=#2E3440)
* Found matching X resource "foreground" (value=#D8DEE9)
* Found matching X resource "color0" (value=#3B4252)
* Bar geometry: 1920x45+0+1035
- bar: Attach X event sink
- bar: Attach signal receiver
- controller: Install signal handler
- controller: Setup user-defined modules
* Found matching X resource "color4" (value=#81A1C1)
* Found matching X resource "color4" (value=#81A1C1)
* Found matching X resource "color4" (value=#81A1C1)
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* Starting application
- controller: Main thread id = 1
* Starting module/i3
* Starting module/mpd
- module/mpd: Thread id = 2
* Entering event loop (thread-id=1)
- controller: Attach config watch
* Eventqueue worker (thread-id=3)
- bar: Create renderer
- renderer: Get TrueColor visual
- renderer: Allocate colormap
- renderer: Allocate output window
- module/i3: Thread id = 4
- renderer: Allocate window pixmaps
- renderer: Allocate graphic contexts
- renderer: Allocate alignment blocks
- renderer: Allocate cairo components
- renderer: Load fonts
* Configured DPI = 120x120
* Loaded font "xos4terminus:size=14" (name=xos4 Terminus, offset=2, file=/usr/share/fonts/misc/ter-x14n.pcf.gz)
* Loaded font "FontAwesome:size=10" (name=FontAwesome, offset=2, file=/usr/share/fonts/TTF/fontawesome-webfont.ttf)
* Loaded font "xos4terminus:size=24:weight=bold" (name=xos4 Terminus, offset=2, file=/usr/share/fonts/misc/ter-x24b.pcf.gz)
* Loaded font "Material Design Icons:size=13" (name=Material Design Icons, offset=2, file=/usr/share/fonts/TTF/MaterialDesignIcons.ttf)
* Bar window: 0x4200002
- bar: Reconfigure window
- bar: Set window WM_NAME
- bar: Set window _NET_WM_WINDOW_TYPE
- bar: Set window _NET_WM_STATE
- bar: Set window _NET_WM_DESKTOP
- bar: Set window _NET_WM_PID
- bar: Map window
- bar: Draw empty bar
- bar: Setup tray manager
* Disabling tray manager (reason: missing `tray-position`)
* module/i3: Rebuilding cache
* module/mpd: Rebuilding cache
- bar: Force update
* Redrawing bar window
- bar: Received expose event
- renderer: flush(1 geom=715x42+0+0, falloff=0)
- bar: Received button press: 1 at pos(252, 22)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
- bar: Received button press: 1 at pos(320, 27)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
- bar: Received button press: 1 at pos(317, 26)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
- bar: Received button press: 1 at pos(317, 26)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
* module/mpd: Rebuilding cache
- bar: Ignoring update (unchanged)
- bar: Received button press: 1 at pos(317, 26)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
- bar: Received button press: 1 at pos(245, 25)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
* module/mpd: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=715x42+0+0, falloff=0)
- bar: Received button press: 1 at pos(250, 26)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
- bar: Received button press: 1 at pos(310, 23)
- Found matching input area
- mpdconnection.connect: <IP_ADDRESS>, 6600, "", timeout: 15
^C
warn: Termination signal received, shutting down...
- controller: Uninstall sighandler
- controller: Detach signal receiver
- controller: Stop modules
* module/i3: Disconnecting from socket
* module/i3: Stopping
- module/i3: Release sleep lock
- module/i3: Deconstructing
* Deconstruction of module/i3 took 1 ms.
* module/mpd: Stopping
- module/mpd: Release sleep lock
- module/mpd: Deconstructing
* Deconstruction of module/mpd took 0 ms.
- controller: Joining threads
* Waiting for spawned processes to end
* Reached end of application...

So, I set up mopidy on my VM and was able to reproduce this. I don't think this is actually polybar's fault.
Having mopidy running in the terminal, I noticed that the following exception was thrown by mopidy, exactly as the polybar button stopped working:
ERROR    Unhandled exception in MpdFrontend (urn:uuid:abc157d0-a598-46ab-a711-949de6ec7c4d):
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 200, in _actor_loop
    response = self._handle_receive(message)
  File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 294, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File "/usr/lib/python2.7/site-packages/mopidy/mpd/actor.py", line 84, in on_event
    self.send_idle(_CORE_EVENTS_TO_IDLE_SUBSYSTEMS[event])
  File "/usr/lib/python2.7/site-packages/mopidy/mpd/actor.py", line 88, in send_idle
    listener.send(session.MpdSession, subsystem)
  File "/usr/lib/python2.7/site-packages/mopidy/listener.py", line 27, in send
    'kwargs': kwargs,
  File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 437, in tell
    raise _ActorDeadError('%s not found' % self)
    ActorDeadError: MpdSession (urn:uuid:feb3d781-13b2-4394-84be-afff630079df) not found

From there on, it was impossible to change the random setting with polybar or ncmpcpp (using mpc still works though), polybar still sends the correct commands to mpd but it somehow doesn't get accepted by mopidy (and also doesn't produce an error). That's why I believe that this is a mopidy bug rather than a polybar bug.
I'm going to close this, as there is nothing more to be done from our side. If you open a mopidy issue, please link it here.


remove incorrect documentation about the listeners

Listener.Serve() was removed a very long time ago.

Codecov Report

Merging #1351 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   90.54%   90.54%
=======================================
  Files         119      119
  Lines        8256     8256
=======================================
  Hits         7475     7475
  Misses        518      518
  Partials      263      263

Impacted Files
Coverage Δ

server.go
92.8% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93827c...187b014. Read the comment docs.


Add ramp threshold edit

Should be in settings. Should be a lineEdit. Default 0.4.

Add same for pump threshold

Due to https://github.com/SeanIFitch/Icarus_v2/issues/37, this is no longer necessary. Additionally, once pump slope is determined it should not be changed.


Sometimes requeueing doesn't work

In the RequeueAndRemove::RequeueOne() method, the messages are iterated through to find the one to requeue with a matching messageId.  However, it uses the QueueClient::ReceiveBatch() method which may return fewer messages than the number requested, consequently it can happen that the message to requeue is not found in the returned list and so nothing happens.

Yeah this is a painful side effect of that ReceiveBatch idiom. I couldn't think of any reasonable way to work around it, except maybe brute-force retries. Maybe there's something there where you can use the messageid to retrieve it explicitely?

Also, someone should label these issues

@lukeschafer it doesn't look like brute forcing seems to work either :(


feat: modify service dependency conditions in docker-compose.yaml

@scottaubrey I think I need your help to progress this.

@nlisgo I've taken a look, and it was failing for me. I've committed a few changes with rationale in the commit message, but in essence:

the target wasn't including the env var from this line
then I realised we needed to mount package.json and yarn.lock file to ensure it's always updating node_modules from the working directory values

@nlisgo are we able to progress this do you think?

Will merge when green!


Node classification tasks

Hi! First of all great job! I have been trying to do node classification in residue view, using my own node labels. However, I haven't been able to configure the NodePropertyPrediction task to use those labels instead of predicting the residue features. Do you have any guidance on how I can proceed to do this? Any help is appreciated

Thank you for your answer. I have a couple more questions, I have been trying to modify the AttributeMasking task for my node classification problem, however it is not clear to me how is the relation between the nodes id and the amino acids in the sequence. The only clue I've found so far is this note in the data/protein.py file "Nodes may have a different order with residues." Can you guide me on how to proceed?

Sorry for the late response. In data.Protein, we usually use node and atom interchangably, while residue corresponds to the real residue in proteins. You can use data.Protein.atom2residue to learn which residue an atom belongs to.


GPL-561 Sentinal pick all the volume of the +ves

User story

GPL-561
As genomics POs (Emma, Rich C & James) we would like to cherry pick all the volume of the +ves because...

Who are the primary contacts for this story
Emma G
Rich C
James M
Danni W
Acceptance criteria
Token for conversation to have
To be considered successful the solution must allow:

[ ] add a list of acceptance criteria here
[ ] ...

Dependencies
This story is blocked by the following dependencies:

#<issue_no.>
sanger/#<issue_no.>

Additional context
See section 2.2 : https://ssg-confluence.internal.sanger.ac.uk/x/jqsKBg

Fixed vol 35ul

Zoom meeting Rich C 24th July 2020 14:00
Where is the volume information coming from
Currently the actual volume of the plates is unknown, both inside and outside of the Lims. While it would be possible to perform a volume check to establish this value, operations do not feel it would be worth the additional time and administration costs. As a result, the volume information is not available to determine maximum volume.
** What are the alternatives **
Existing picks, and future picks will be performed with fixed volumes of 35ul. There is existing support in Sequencescape for fixed volume picks.
We proceeded to discuss the behaviour of GPL-558 (https://github.com/sanger/lighthouse-ui/issues/2), GPL-559 (https://github.com/sanger/lighthouse-ui/issues/10) and GPL-574 (#2837) and established that operations and PSD have a shared understanding of what the two stories will deliver. It was clarified that:

Megabatches created via GPL-559 could contain plates from multiple boxes, although operations indicated that they may actually avoid this functionality in the first phase, due to difficulties managing multiple boxes when setting up picks. GPL-580 is expected to mitigate this (#2848)

Batches created would not be automatically processed through the cherrypicking pipeline itself, but would be available ad unprocessed batches in the pipeline inbox page. These could then be processed in the same manner as existing megabatches.

Following confirmation the the lighthouse batches would be processed through the existing cherrypick pipelines it was confirmed that the existing 'pick by volume' functionality would meet the current needs.
The possibility of fully automating the pipeline was raised by PSD, who indicated that it was possible, but probably a fairly significant undertaking. Operations felt that the current planned delivery would cover their immediate needs, and planning further automation at this stage would be premature.
It was established that no further Lims development work will be needed to meet these requirements.


Error: undefined is not a function

Encountered this error when trying to us https://github.com/terikon/cordova-plugin-photo-library/issues/4, and isolate it to this plugin.
The error prevents iOS or Android from building projects.
cordova plugin add cordova-plugin-add-swift-support --save
Fetching plugin "cordova-plugin-add-swift-support" via npm
Installing "cordova-plugin-add-swift-support" for android
Installing "cordova-plugin-add-swift-support" for ios
Saved plugin info for "cordova-plugin-add-swift-support" to config.xml
Error: undefined is not a function

Cordova CLI: 6.1.1
Gulp version: CLI version 3.9.1
Gulp local:
Ionic Framework Version: 1.3.1
Ionic CLI Version: 2.0.0
Ionic App Lib Version: 2.0.0
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v0.12.2
Xcode version: Xcode 8.0 Build version 8A218a
Appreciate any help... lost in dependency land here.

Hello,
I think you need to upgrade your node version. I will update the README to inform about the minimal version compatibility.

That fixed it thanks.

What is the minimal version compatibility for node?


Wrote my own color function not working..I dont know how much I am right

Hi @ dev
I am sure you will solve this issue..
I am sendng you relevant part of code here
graph = mapper.map(projected_data,X,nr_cubes=14,overlap_perc=0.8,clusterer=sklearn.cluster.DBSCAN(eps=15, min_samples=4))

model = ensemble.IsolationForest(random_state=1729)
model.fit(X)
usecolor = model.decision_function(X).reshape((X.shape[0], 1))

node=graph['nodes'].values()
cluster= list(node)
# My own Function..I am trying to color each node by avg anomaly score of the data points in that node
z=[]
for i in range(0,len(cluster)):
    z.append(np.round(np.mean(usecolor[cluster[i]])*10,decimals=4,out=None))
print(z)
s=np.asarray(z)
s

I am getting following output
Mapping on data shaped (150, 4) using lens shaped (150, 2)

Creating 196 hypercubes.

Created 57 edges and 24 nodes in 0:00:00.054112.
[0.6021, 0.4893, 0.2385, -0.2715, 0.7183, 0.7395, 0.6809, 0.4972, 0.333, 0.6087, 0.6839, 0.5749, 0.3008, 0.4609, 0.3176, 0.2205, 0.1462, -0.05, 0.4609, 0.4583, 0.0631, 0.559, 0.5166, 0.1199]

array([ 0.6021,  0.4893,  0.2385, -0.2715,  0.7183,  0.7395,  0.6809,
        0.4972,  0.333 ,  0.6087,  0.6839,  0.5749,  0.3008,  0.4609,
        0.3176,  0.2205,  0.1462, -0.05  ,  0.4609,  0.4583,  0.0631,
        0.559 ,  0.5166,  0.1199])

Now I go to next part of code
# Visualize it

mapper.visualize(simplicial_complex, path_html="/home/dhananjay/kepler-mapper/keplermapper-iris.html", custom_meta={"Data:": "Me"}, custom_tooltips=Y,color_function=z)

But I am getting error
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-14-0692ad6431ec> in <module>()
      6         0.4972,  0.333 ,  0.6087,  0.6839,  0.5749,  0.3008,  0.4609,
      7         0.3176,  0.2205,  0.1462, -0.05  ,  0.4609,  0.4583,  0.0631,
----> 8         0.559 ,  0.5166,  0.1199]))

~/kepler-mapper/kmapper/kmapper.py in visualize(self, graph, color_function, custom_tooltips, custom_meta, path_html, title, save_file, X, X_names, lens, lens_names, show_tooltips)
    507         mapper_data = format_mapper_data(graph, color_function, X,
    508                                          X_names, lens,
--> 509                                          lens_names, custom_tooltips, env)
    510
    511         histogram = graph_data_distribution(graph, color_function)

~/kepler-mapper/kmapper/visuals.py in format_mapper_data(graph, color_function, X, X_names, lens, lens_names, custom_tooltips, env)
     58     for i, (node_id, member_ids) in enumerate(graph["nodes"].items()):
     59         node_id_to_num[node_id] = i
---> 60         c = _color_function(member_ids, color_function)
     61         t = _type_node()
     62         s = _size_node(member_ids)

~/kepler-mapper/kmapper/visuals.py in _color_function(member_ids, color_function)
    219
    220 def _color_function(member_ids, color_function):
--> 221     return _color_idx(np.mean(color_function[member_ids]))
    222     # return int(np.mean(color_function[member_ids]) * 30)
    223

IndexError: index 50 is out of bounds for axis 1 with size 24

The color_function is must have the same number of entries as data points. So for you dataset with 150 observations, you would need it length 150, with each entry associated to each observation. The visualize method will then take the average of these values for you.
Try passing the results of usecolor in:
mapper.visualize(simplicial_complex, path_html="...",
                 custom_meta={"Data:": "Me"},
                 custom_tooltips=Y,
                 color_function=usecolor)

Thanku so much...I got it


Example about mat-optgroup inside mat-autocomplete

Bug, feature request, or proposal:
Documentation request
What is the expected behavior?
Having an working example of this code :
https://material.angular.io/components/autocomplete/overview#option-groups
What is the current behavior?
No stackblitz or demo. And it's not easy to understand... because for the "mat-optgroup" you need (implicitly ?) to go to the "Select" component section, and with a group structure (eg: pokemonGroups) the autocomplete filter (eg: filteredOptions: Observable<string[]>;) doesn't work anymore.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-nwdj9u
What is the use-case or motivation for changing an existing behavior?
Having a autocomplete input with group.
Like this for example
Input : "d" <---------- autocomplete
[D <------------------- group
Dog <------------- option1
Dragon <---------- option2
...
]

Thanks @jelbourn for the tags.
Indeed the "help wanted" is welcome, because i can't actually find myself how to adapt the Observable type to work with a group...
If someone know how to do it, I will really appreciate !!

Comment updated with a stackblitz demo.

No one ? No more luck on stackoverflow... :zipper_mouth_face:

I'd like to take a crack at this if @mmalerba thinks it's a feature worth adding 👍

@raygervais sounds good to me. @crisbeto should probably be the one to review it, I'm not too familiar with the autocomplete

@WizardPC, I forked and completed your mat-optgroup example. Can be found here: https://stackblitz.com/edit/angular-smg2xm?file=app/app.component.ts, from there I'm updating the documentation to reflect (based on the original example which is there). @crisbeto is this how the autocomplete function should behave? or should it filter as well the options so that if I put Dr from the example above, Dog would be removed from the panel?

I'd say that it should only filter the options @raygervais, the groups are only used for grouping similar results together. Here's an example from our demo app that does the same: https://github.com/angular/material2/blob/master/src/demo-app/autocomplete/autocomplete-demo.ts#L131

Thanks for the pointer @crisbeto, will correct in my StackBlitz update and from there work on the PR.

@raygervais thanks for your time ! Works as expected ;)

Thanks @raygervais :wink:

Hi @raygervais
Is possible to do something like this: https://i.stack.imgur.com/tvAp5.png using the autocomplete, i say, multiple colums in a line.
Thanks


ENH, MAINT: voronoi_plot_2d nicer inf lines

Fixes #19653

we currently set the plotted length of infinitely-long Voronoi edges as a function of the largest x-or-y Voronoi generator range; in cases where the range of one axis is substantially larger than the other, it seems that we can produce a more appealing representation of the infinitely-long line by accounting for the aspect ratio; otherwise, there's a danger the (infinitely-long) Voronoi edge may not be visible with our default voronoi_plot_2d settings

note that we only have very crude testing for voronoi_plot_2d, so there is no guarantee this doesn't introduce new problems for other scenarios (so not keen on backporting, even if folks thought this was a genuine bug), and I'm also not super keen on extracting line data from matplotlib like this, but I do also think this probably is a step in the right testing direction if we're going to respond to user feedback in a sane way; the function already takes 8 parameters, and to some extent the user should be expected to make reasonable adjustments, but since the Voronoi edge was invisible in this default case I thought we might try to fix it

while in the neighborhood, remove some local test shims for matplotlib 1.x; matplotlib is already at 3.x so I think we can drop those

[skip cirrus]
cc @bagrow and @dpapadop for feedback, since they were vocal on the original ticket
Before/after for the generators in question (it may be good to spot check a few more cases and perhaps even suggest another regression case or two):

I tried to address the reviewer-suggested formatting changes. I also added another regression test, this time for a less extreme aspect ratio.

Core dev approved, new tests look thorough to  a non-expert, modifications to old tests look good. Merged, thanks Tyler, Lucas


2015 FRQ to PBL Associations and Reflection

FRQ to PBL
reflection

Justin Nguyen - Above the Line
Graded by Aliya Tang

Title
Score
Comments

FRQ 1
0.95/0.9
Requirements met (complete and running), nice reflection and understands connection between each question part

FRQ 2
1/0.9
Requirements met (complete and running), extra where it checks guess length doesn't exceed word length and nice reflection

FRQ 3
0.85/0.9
Requirements met (complete and running), but sparse array not fully displayed, only positions of entries so hard to visualize column deletion, reflection not really reflective

FRQ 4
0.9/0.9
Requirements met (complete and running), but no reflection

Total
3.7/3.6


optionally expose the access token in a response header

This is similar to what #621 does to the id_token but exposes the access_token.
Use case is an nginx with auth-request that wants to make the access token available to the resource server "behind" the nginx.

and very similar to #424 ;)

argh, sorry about that. I did look for open issues and PRs before I started working on this but missed #424.
Maybe the testcase of this PR could be adapted and added to #424 ?
I'll close this one as there is little reason to add more noise to an already long list of PRs.


Remove special set up of Object.userData for solid lines

@atomicsulfate  i couldn't find anything requiring the solid-line to be handled differently.

Codecov Report

Merging #1337 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
+ Coverage    54.2%   54.21%   +<.01%
==========================================
  Files         266      266
  Lines       23723    23721       -2
  Branches     5302     5301       -1
==========================================
  Hits        12860    12860
+ Misses      10863    10861       -2

Impacted Files
Coverage Δ

...e/harp-mapview/lib/geometry/TileGeometryCreator.ts
40.7% <ø> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79226d7...b2e7f93. Read the comment docs.


peer dependencies - allow react and react-dom ^17.0.0

Thanks for contributing to react-virtualized!
#1655
Before submitting a pull request, please complete the following checklist:

[x] The existing test suites (npm test) all pass
[x] For any new features or bug fixes, both positive and negative test cases have been added
[x] For any new features, documentation has been added
[x] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (yarn run prettier).
[x] Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Hi @liesislukas,
the dependencies are updated, but there was sadly no new version published as the latest published version is 9.22.3 (December 18, 2020). see https://yarnpkg.com/package/react-virtualized
How is in charge here to publish a new tag?
Greetz

Ping @bvaughn

Ping @bvaughn

Ping @bvaughn

Ping @bvaughn

Yeah, we need a new version published for npm to stop complaining about not meeting the correct react dep.

Ping @wuweiweiwu

Ping @wuweiweiwu

Ping @bvaughn

Ping @bvaughn
Ping @wuweiweiwu

is this library not maintained anymore?

is this library not maintained anymore?

It appears it's not :(

Any updates? @bvaughn @wuweiweiwu

Switched to virtuoso.


feat: Prompt Sign In on Post Like

Generic Prompt notification and PromptSignIn component to ask users to sign in for actions requiring authentication.

Wait for changes)

@niktverd please resolve/remove the request


Only require ipaddress module on Python 2

On Python 3 it is a standard library module.

Annoyingly, it seems my install-requirements script doesn't properly handle an unpinned requirement with an environmental specifier. So this will have to wait until I've got that fixed.


V2 -- Proposal: Renaming src/index.js

I would propose renaming src/index.js for two reasons:

tooling
extendability

Various editors/ides will support some kind of file opening dialog. Due to index.js being npm's default name for packages and often being used as an entry point for package exports, looking only for index.js in a regular project brings up many files.

To extend the setup, e.g. for server-side-rendering, we often create a second entry point for the server build. A naming pair of server.js and client.js (or whatever) is more self-documenting than e.g. index.js and client.js.

Seems like a good idea. I know the question arose last time, but I am not sure yet if we should support server side rendering out of the box. Most people do not even seem to react use it that way. That said, if there are enough supporters for such  feature, I will happily accept a pr ;)

I'd find it cool if as a first step we simply renamed the index.js for above reasons.
It would then be interesting to (along with the Wiki and possibly moving the generator project to an organization?) create a new repository, e.g. react-webpack-generator-examples.
We could use that as a monorepo to provide various setups of the generator to illustrate the questions that come up often (how do I integrate it with react-router, how do I integrate it with Redux, Alt, how can I achieve SSR, how can I build static websites from it, ...).
This type of demo repos is very common in the Spring Boot ecosystem, e.g.
react-webpack-generator-examples
  /setup-with-react-router/
  /setup-with-react-bootstrap/
  /setup-with-flux/
  /setup-with-static-site-generation/

Each of those first-level directories is a separate setup, so users can jump into each of them, hit npm install, and explore an isolated setup for the use case.
This example repo could also be a good source for prototyping stuff that may or may not become a part of the generator or the template.
E.g., I don't think that SSR can be generically integrated, as there is not the one way of doing it. But it could be integrated with new prompts during installation, that set it up only if the user opts in (like many other options in the old and new generator).

@sthzg, sounds great. I will create the org on the weekend and maybe move the template to it as the first basic project. I will inform you when its done and the rights are set up correctly.

Done and merged.


AuthorizeView - Is Configuration working for authorize scenario

Project Information

asp.net core 3.1.3
bunit 1.0.0-beta-6

Context
I have a page that use AuthorizeView like this simple exemple
<AuthorizeView>
    <Authorized>

My Working authorized page

    </Authorized>
    <NotAuthorized>
        <Error ErrorCode="403" Title="@Localizer["NotAuthorizedTitle"]" SubTitle="@Localizer["NotAuthorizedSubTitle"]"/>
    </NotAuthorized>
</AuthorizeView>

When I run the test, I have this error that is clearly come from a configuration issue
 System.InvalidOperationException : Authorization requires a cascading parameter of type Task<AuthenticationState>. Consider using CascadingAuthenticationState to supply this.
I extends to ComponentTestFixture to add aditionals dependencies
public abstract class BlazorUnitFixture : ComponentTestFixture
    {
        protected BlazorUnitFixture() : base()
        {
            ConfigureServices();
        }
        private void ConfigureServices()
        {
            var currentAssembly = Assembly.GetExecutingAssembly();
            Services.AddAutoMapper(currentAssembly);
            Services.AddFluxor(options =>
            {
                options.UseDependencyInjection(typeof(Program).Assembly);
            });
            Services.AddAuthentication();
            Services.AddAuthorization();
            Services.AddScoped<NavigationManager>(_ => new NavigationManagerFake());
            Services.AddSingleton(typeof(HttpClientDummy<>));
            Services.AddSingleton(typeof(IApiService<>), typeof(ApiServiceDummy<>));
            Services.AddScoped<IStringLocalizer, FakeLocalization>();
            Services.AddScoped<IHttpContextAccessor, FakeHttpContextAccessor>();
            Services.AddScoped<AuthenticationStateProvider, FakeAuthenticationStateProvider>();

            Services.AddLogging();
        }

As you can see, I add some authorization service, but seems that is not changing the test result.
The test failed when the component tries to initialize.
I put this as the question for knows, because I think I'm doing something wrong ^^'.

Hi Alex,
Judging from the error message, you should be passing the  Task<AuthenticationState> through a cascading parameter, which seems to be provided from a CascadingAuthenticationState component. Maybe that will pick up the auth provider you have registered in the services collection.
Otherwise it looks like a good setup you have. Btw. You do not gain anything by using Scoped vs Singleton when registering in a test context.
I am not at my computer right now so I cannot provide more information at the moment.
If you get it working, please post the solution here so others can benefit.

Hi @egil ,
Thanks for your answer. I will try to have a look this week about this.
Is not a big deal for me because my test are written, I just comment them waiting for a resolution :)

Ok that's fine. I've added it to my to do list to write a guide for this for the website.

@AlexTeixeira im closing this issue now to keep things clean and neat. Let me know if this didnt work out for you.

Hi again @AlexTeixeira
Can you provide a simple working example of how you are currently testing components in this scenario. There are others with the same challenge and it would be super helpful if you can provide a quick guide on how to do this.

Hi,
I make some investigation, and the exception is raised when you add the authorized view in a page you want to test.
<AuthorizeView>
    <Authorized>

Authorized

 </Authorized>
    <NotAuthorized>

Not Authorized

    </NotAuthorized>
</AuthorizeView>

The error is in the documentation :
https://docs.microsoft.com/en-us/aspnet/core/security/blazor/?view=aspnetcore-3.1#troubleshoot-errors
It's because the routing in app.razor page is not surrounded by the CascadingAuthenticationState  like in this sample :
<CascadingAuthenticationState>
    <Router AppAssembly="typeof(Startup).Assembly">
        ...
    </Router>
</CascadingAuthenticationState>

Do you provide the app.razor from your template generator ?

No, I do not provide an app.razor, because each test is its own conceptual "app", so that would not make sense. The docs you link to does not say that it has to be around the <Rounter> component, just that it needs to be around the component you are testing, e.g.:
<CascadingAuthenticationState>
    <MyComponent> <-- The component under test
       ... inside MyComponent we can then have
        <AuthorizeView>
            <Authorized>

Authorized

             </Authorized>
            <NotAuthorized>

Not Authorized

            </NotAuthorized>
        </AuthorizeView>
        ... other parts of MyComponent
    </MyComponent>
</CascadingAuthenticationState>

The challenge is that <CascadingAuthenticationState> needs a  AuthenticationStateProvider injected into it, so that needs to be registered in the Services collection in bUnits TestContext before the component under test is rendered. E.g.:
Services.AddSingleton<AuthenticationStateProvider>( ... some mock of a AuthenticationStateProvider);

This does "work", but I don't understand some of the auth services enough yet to know what I'm doing :P
using System.Collections.Generic;
using System.Security.Claims;
using System.Security.Principal;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Authorization.Infrastructure;
using Microsoft.AspNetCore.Components.Authorization;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using NSubstitute;
using Derp.AMDB.Shared;
using static Bunit.ComponentParameterFactory;
using TestContext = Bunit.TestContext;

namespace Derp.AMDB.Test
{
    [TestClass]
    public class Class1
    {
        [TestMethod]
        public void LoginDisplay()
        {
            var principal = new ClaimsPrincipal(WindowsIdentity.GetCurrent());
            var authPolicyProvider = Substitute.For<IAuthorizationPolicyProvider>();
            authPolicyProvider.GetPolicyAsync(Arg.Any<string>())
                .ReturnsForAnyArgs(new AuthorizationPolicy(
                    new IAuthorizationRequirement[] {new RolesAuthorizationRequirement(new[] {"admin"})},
                    new string[] { }));
            authPolicyProvider.GetDefaultPolicyAsync()
                .ReturnsForAnyArgs(new AuthorizationPolicy(
                    new IAuthorizationRequirement[] {new RolesAuthorizationRequirement(new[] {"admin"})},
                    new string[] { }));
            var auth = Substitute.For<IAuthorizationService>();
            auth.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), Arg.Any<object>(),
                Arg.Any<IEnumerable<IAuthorizationRequirement>>()).ReturnsForAnyArgs(AuthorizationResult.Success());
            var authTask = new TaskCompletionSource<AuthenticationState>();
            authTask.SetResult(new AuthenticationState(principal));

            using var ctx = new TestContext();
            ctx.Services.AddSingleton(authPolicyProvider);
            ctx.Services.AddSingleton(auth);

            var cut = ctx.RenderComponent<LoginDisplay>(CascadingValue(authTask.Task));

            Console.WriteLine(cut.Markup);
        }
    }
}```

Thanks @Grummle, thats quite a bit of code just to tell a component whether a user is authenticated or not. This should be much easier. I will create a issue for creating a helper in bUnit that makes this easier.

I also have been investigating this since posing the question. @Grummle is on the right page, but I think it's even more complicated for various states: authenticated, unauthenticated, authorized, and unauthorized.
I went down a similar path to what @egil describes in that new issue. I created some test classes to help with this, rather than going purely with mocks. Adding my classes below in case you'd like some additional insight:
using Microsoft.AspNetCore.Components.Authorization;
using System;
using System.Security.Claims;
using System.Threading.Tasks;
namespace D20Tek.Blazor.TestHost
{
public class TestAuthenticationStateProvider : AuthenticationStateProvider
{
public TestAuthenticationStateProvider(Task state)
{
this.CurrentAuthStateTask = state;
}
    public TestAuthenticationStateProvider()
    {
    }

    public Task<AuthenticationState> CurrentAuthStateTask { get; set; }

    public override Task<AuthenticationState> GetAuthenticationStateAsync()
    {
        return CurrentAuthStateTask;
    }

    public void TriggerAuthenticationStateChanged(Task<AuthenticationState> authState)
    {
        this.NotifyAuthenticationStateChanged(authState);
    }

    public static Task<AuthenticationState> CreateAuthenticationState(string username)
    {
        var identity = new TestIdentity { Name = username };
        var principal = new ClaimsPrincipal(identity);
        return Task.FromResult(new AuthenticationState(principal));
    }

    public static Task<AuthenticationState> CreateUnauthenticationState()
    {
        var principal = new ClaimsPrincipal(new NonAuthenticatedPrincipal());
        return Task.FromResult(new AuthenticationState(principal));
    }
}

}
using Microsoft.AspNetCore.Authorization;
using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
namespace D20Tek.Blazor.TestHost
{
public class TestAuthorizationPolicyProvider : IAuthorizationPolicyProvider
{
private readonly AuthorizationOptions options = new AuthorizationOptions();
    public Task<AuthorizationPolicy> GetDefaultPolicyAsync()
        => Task.FromResult(options.DefaultPolicy);

    public Task<AuthorizationPolicy> GetFallbackPolicyAsync()
        => Task.FromResult(options.FallbackPolicy);

    public Task<AuthorizationPolicy> GetPolicyAsync(string policyName) => Task.FromResult(
        new AuthorizationPolicy(new[]
        {
                new TestPolicyRequirement { PolicyName = policyName }
        },
        new[] { $"TestScheme:{policyName}" }));
}

[ExcludeFromCodeCoverage]
public class TestPolicyRequirement : IAuthorizationRequirement
{
    public string PolicyName { get; set; }
}

}
using Microsoft.AspNetCore.Authorization;
using System;
using System.Collections.Generic;
using System.Security.Claims;
using System.Threading.Tasks;
namespace D20Tek.Blazor.TestHost
{
public class TestAuthorizationService : IAuthorizationService
{
public AuthorizationResult NextResult { get; set; }
= AuthorizationResult.Success();
    public List<(ClaimsPrincipal user, object resource, IEnumerable<IAuthorizationRequirement> requirements)> AuthorizeCalls { get; }
        = new List<(ClaimsPrincipal user, object resource, IEnumerable<IAuthorizationRequirement> requirements)>();

    public Task<AuthorizationResult> AuthorizeAsync(ClaimsPrincipal user, object resource, IEnumerable<IAuthorizationRequirement> requirements)
    {
        AuthorizeCalls.Add((user, resource, requirements));

        // The TestAuthorizationService doesn't actually apply any authorization requirements
        // It just returns the specified NextResult, since we're not trying to test the logic
        // in DefaultAuthorizationService or similar here. So it's up to tests to set a desired
        // NextResult and assert that the expected criteria were passed by inspecting AuthorizeCalls.
        return Task.FromResult(NextResult);
    }

    public Task<AuthorizationResult> AuthorizeAsync(ClaimsPrincipal user, object resource, string policyName)
        => throw new NotImplementedException();
}

}
using System.Security.Principal;
namespace D20Tek.Blazor.TestHost
{
public class TestIdentity : IIdentity
{
public string AuthenticationType => "Test";
    public bool IsAuthenticated => true;

    public string Name { get; set; }
}

}
using System.Security.Principal;
namespace D20Tek.Blazor.TestHost
{
public class NonAuthenticatedPrincipal : IPrincipal
{
public IIdentity Identity => null;
    public bool IsInRole(string role)
    {
        return false;
    }
}

}
There I added the following helper to add all of the services and initialize with the appropriate AuthenticationState for the test.
    public void AddAuthenticationServices(Task<AuthenticationState> initialAuthState = null)
    {
        this.AddService<IAuthorizationService>(new TestAuthorizationService());
        this.AddService<IAuthorizationPolicyProvider>(new TestAuthorizationPolicyProvider());
        this.AddService<AuthenticationStateProvider>(new TestAuthenticationStateProvider(initialAuthState));
        this.AddService<NavigationManager>(new TestNavigationManager());
    }

It's not the cleanest code because I was trying out several different things to get this to work end to end. But it certainly works and enables me to test a component with AuthorizeView and the different Auth states. Hoping it may provide some insight or inspiration. :)

Thanks @Grummle for the sample :)
I will try to implement it in my part this week and back to you if this resolve my error :)

@DarthPedro I was able to use this for some testing in my Blazor app.  makes adding some tests within AuthorizeView really simple.
Thanks!

@Dedac Glad that worked for you too. I've been using it to test a couple of components that needed AuthorizeView. It works pretty well.


(Additional) Better reference data

We are currently using this image as  test data.
It might be a good idea to add some more complex data with maybe more dimensions and irregular shapes.

Maybe this would work. The height and width are different. It also contains an RGB channel, which may make it a bit more interesting. Plus it's pretty easy to check if it is orientated correctly.

I like the suggestion.
I will change it in the next few days.

An additional option would be to fairly small synethic arrays with some algorithm to decide whether or not each cell is correct:
import itertools
primes = [2, 3, 5, 7, 11]
shape = [5, 5, 5, 5, 5]

assert len(shape) <= len(primes)

for idx in itertools.product(*[range(s) for s in shape]):
    total = 1
    for prime, power in enumerate(idx):
        total *= (primes[prime]) ** (power+1)
    print(total)


The postgres adapter's migrate:down downgrades all migrations instead of ones in the latest batch

Link to reproduction
No response
Describe the Bug
The getMigrations function returns existingMigrations (all migrations in the db with a batch number != -1) and latestBatch (the batchId of the latest set of applied migrations).
However, the postgres implementation of  migrateDown uses the existingMigrations variable as if it has been filtered by batchId -- it iterates through all migrations returned and runs their down function.
This means any time a user runs migrate:down, it will destroy the entire database rather than running down for the latest set of migrations.
I think all that needs to change is
if (!existingMigrations?.length) {
    payload.logger.info({ msg: 'No migrations to rollback.' })
    return
  }

  let latestMigrations = existingMigrations.filter((m) => m.batch === latestBatch)

  payload.logger.info({
    msg: `Rolling back batch ${latestBatch} consisting of ${latestMigrations.length} migration(s).`,
  })

  for (const migration of latestMigrations) {
...

I tried to follow the reproduction guide, but had trouble finding a way to get the set up running in a way where I could use payload script commands.
I have a branch locally with the change implemented, and am trying to figure out how to write tests for this.
To Reproduce

Create the inital migration for a payload app using the postgres db adapter.
Apply that migration
Create a second migration
Apply that migration (at this step, you can query the payload_migration table to verify they were applied in two different batches)
Run payload migrate:down
The log line will say "Rolling back batch 2 consisting of 2 migration(s)." and will downgrade both migrations, leaving you with an empty database.

I can provide a video of me reproducing it, but it's too large to attach here
Payload Version
2.4.0
Adapters and Plugins
none

Hey @denolfe, thanks for maintaining this project!
Just wanted to follow up on this issue- as far as we can tell, this bug prevents us from being able to do any down migrations without dropping the whole database. As such, it's blocking us from confidently using Payload with Postgres in production.
Totally understand if this isn't your first priority, but I was wondering if we could get a sense of when this bug might be reviewed? This will help us prioritize either trying to upstream the change ourselves, or trying to work around it.
Thanks!

Thank you so much @DanRibbens!


Typo 'publickKey' in the feature_bug_fixes branch

The word 'publickKey' exists in Identity.java and profile.properties.
Isn't the publicKey correct?

Oops, that's a typo, yes, you are correct.

Fix merged in the feature_bug_fixes branch


Optimize rollback

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #356 (95f5acf) into master (362b868) will decrease coverage by 0.44%.
The diff coverage is 0.87%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Possible mongodb query not using secondary index.

From @ferOnti in gitter https://gitter.im/bigchaindb/bigchaindb?at=595ad1e86ae41d5d33b052db

Hi, I was stressing the bigchaindb, and after 20k assets, I found this "slow query" in mongodb.log:

2017-07-03T23:21:26.490+0000 I COMMAND [conn4274] command bigchain.bigchain command: mapReduce { mapreduce: "bigchain", map: "function () {
        this.block.transactions.forEach(function (tx) {
            var key = tx.operation
            var value = 1
            emit(key, value);
        })
    }", reduce: "function (key, values) {
        //var reduceVal = {count:0, sum: 0}
        var reduceVal = 0
        values.forEach(function(value) {
            reduceVal +...", query: {}, out: { inline: 1 } } planSummary: COLLSCAN keysExamined:0 docsExamined:3362 numYields:26 reslen:245 locks:{ Global: { acquireCount: { r: 130 } }, Database: { acquireCount: { r: 4, R: 61 } }, Collection: { acquireCount: { r: 4 } } } protocol:op_query 178ms

I think this query is related to get the last transaction

Did this happened only when inserting assets? Or was there some reads also?
From the planSummary we can see that this query is doing a collection scan instead of an index scan.

Another occurrence for @ferOnti on gitter https://gitter.im/bigchaindb/bigchaindb?at=59669b4bbf7e6af22cd105da

hi, I was stressing the server, and I found this slow query in mongo:

2017-07-12T21:49:21.599+0000 I COMMAND [conn109] command local.oplog.rs command: find { find: "oplog.rs", filter: { o.id: "35d8494d7b84a0b2d8ace65d50d2ab6120674cf5f3d46b156b3fc02395fdcb1e", op: "i", ns: "bigchain.bigchain" }, sort: { $natural: -1 } } planSummary: COLLSCAN keysExamined:0 docsExamined:508144 cursorExhausted:1 numYields:3976 nreturned:1 reslen:1433 locks:{ Global: { acquireCount: { r: 7954 } }, Database: { acquireCount: { r: 3977 } }, oplog: { acquireCount: { r: 3977 } } } protocol:op_query 1357ms

I sent 5k "create asset" operations, I have a 2-bigchaindb nodes in cluster, but after process the first 2k operations, the mongo's log showed slow queries like this.

@r-marques trying to replicate this issue. I tried using benchmark library but mongodb logs don't show any of the above listed logs. Could you please suggest how do I go about doing the same?

@r-marques @TimDaub  The oplog query should not be an issue as the mongodb docs describe it to be of finite size and optimized for sequential reads (the same was suggested by @r-marques). Futhermore, the mapReduce query doesn't seem to be there in our codebase although I would love it to be otherwise.

Hi, you can close this issue, I did some stress testing 5 months ago
The issue with the COLLSCAN in the map reduce is something we can't improve, because as I know, we can't add indexes in the reduce stage, only in the map.
and the oplog query, I don't know if this is happening in last version, because I used a version previous to 1.0

@ferOnti  thanks for clearing that up.
@vrde we have a query here which uses id.


SQLite's file doesn't create !

SQLite's file doesn't create when storage mode is set to SQLite.
We have to create the file manually.

Now, fixed.


FireFly6: make landing gear manual pass-through

Make landing gear manual passthrough.

Applied, thanks!


Add any missing properties in the message folder translation files

Overview
We recently had a script contributed in issue #890 . This script checks whether there are any missing translations. We have all our translations in the /messages folder. Each folder has a .json file for each language.
Action Items

[ ] Fix the spelling in the filename the script. The script should be checkTranslation.js rather than checkTranlation.js. You will also need to update the package.json script. Use this script and see what missing translations are there. It should tell which files to look at and which translations to create.
[ ] Add missing properties to the files and add the translations (use google translate for now)
[ ] Run Cypress tests to ensure nothing is broken

Resources/Instructions

@eleanorreem Please assign this issue to me. Thanks!

Assigned! Thanks for your interest. Let me know if you have any questions!

Thanks! Wanted to give an update. I started on setting up the bloom backend locally but ran into an issue with Docker sadly. I spent some time debugging, and finally opened an issue with Docker. I'm going to try a few more things and hopefully Docker will get back to me.

I found a workaround for the Docker issue and am now moving ahead. I documented the workaround in the Docker issue in case anyone else comes across it.

Hi @eleanorreem I'm running into some yarn/formatting issues. If I run yarn format without having made any code changes, it updates about twenty files with extra commas, etc. Wondering if there is a quick fix in my vscode settings that I've overlooked? I have prettier set as the default formatter and am using the recommended extensions, etc. Thanks

Hey @jwicksnin thanks for letting us know, so sorry about this! We have implemented this pre-commit rule recently but forgot to format the project for a clean base to start with. I am fixing this right now.
For now, you can still push your changes like this:

Add the specific files you're changing to staging using git add <file name>

When you commit, yarn format will still run but these changes wont be added to the commit that is pushed. You can verify with git status.

You can remove those changes from yarn format locally using git stash. Then update your branch when the fix is ready.

Actually @jwicksnin this problem has just been fixed! You can simply update your branch now.

Hello, I would like to pick this up :)


fix: Remove upper constraint on urllib3

📚 Documentation preview 📚: https://meltano-sdk--2238.org.readthedocs.build/en/2238/

Anytime someone runs poetry lock it'll start causing problems, so I'm not sure if this is worth it...


Check and integrate the debug logs on every controller action + Discord Webhook integration for critical logs

Code block:
Log::error('title: '.$e->getMessage());

https://laravel.com/docs/8.x/logging

Discord logs are only required for higher-level errors.
Discord Webhood integration:
This is the example implementation: https://github.com/cepdnaclk/smart-inventory-management-system/commit/e2dfa47e98bbe290faf64c96d36aba07dabbbf8f
Add LOG_DISCORD_WEBHOOK_URL into the .env.example file as well. Reach @NuwanJ to created a test Discord Webhook URL for you.

Purpose is similar to this:


Serialize Array/List of basic types (may be also objects) only remain first item

When you serialize a list of items (for example, strings), only remain in final json first item (another items are missing).
Tested with last v8 master release.
in this source part of json loaded:
"EventUpdateTypes": [
"SelectionCurrentPrizeUp",
"SelectionLifeState",
"SelectionSuspensionType"
]
when you return to reset same items in "EventUpdateTypes", only appears first item like this:
"EventUpdateTypes": [
"SelectionCurrentPrizeUp"
]
After a quick view in code, error appear in :

when is iterating in each children, context variable never go to next child (remain in first child always)....
for fix, must to set:
....
context = context[currentKey];
jsonObj = child; // For fix
...

If add this new unit test reading json from real file, fail (all tests are make without real json file, only in memory)


feat: standardize events data

Ready for review

Hi @godekina  ,
We'll be merging this PR so that it counts towards the OD Hackaton. You will receive a partial reward, but we'll be happy if you open a new PR and finish the task!

Hi @godekina ,
I've accidentally merged this PR. Please open a new PR to finish the task 🙏🏼


Bonze custom 1

@bonze Great to see that you like our customization feature. I assume this PR was accidental, because it only tries to overwrite the Juice Shop branding with your own custom theme.


Cứu truyện

Source name
Cứu truyện
Source link
https://cuutruyen.net
Source language
Vietnamese
Other details
YES
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Pls Make cuutruyen


Potential differences in data between stock OpenBCI firmware and Pushtheworld code

I'm running Radio with https://github.com/pushtheworldllc/OpenBCI_Radios/releases/tag/v2.0.0-rc.2 and Firmware at https://github.com/pushtheworldllc/OpenBCI_32bit_Library/releases/tag/v2.0.0-rc.3 . But see that there is a difference in the noise floor and a particular ~31hz noise. The screenshot of the GUI in two different firmwares attached. I'm not sure if this is an issue. But would like to be tracked.
Not that all the leads were floating and not connected to anything in both the cases.
The OpenBCI firmware

The pushtheworld firmware

Verified they are the same. That 31Hz signal is most likely environmental noise with a combination of floating terminals.


FatalThrowableError with GeneratorField

Symfony\Component\Debug\Exception\FatalThrowableError  : Cannot use object of type InfyOm\Generator\Common\GeneratorField as array.

158|                     $checkboxValue = $value = $field['htmlType'];

We are not maintaining VueJs Generator from last few versions and there are many breaking things.
so we are planning to remove that source code.


Building for Native Android/iOS Support

Low priority question, feel free to answer whenever, or point me to resources to help me answer the questions...  :grinning:
Pretty much all the documentation discusses transcoder support using wasm for the web, which the browser then handles a lot of the heavy lifting with via wasm, the transcoder and webgl.
However, I have a possible different use case, and I could be completely wrong on this idea.  Can this code be easily be used naively to decode images into the gpu w/o a browser/wasm.   Using XCode & Android NDX to build the code on iOS & Android.    Do I just have to setup a OpenGL 2.x+ session and then point the trancoder to it somehow?    I assume we need the OpenGL session so that it has access to the GPU; correct?

Afaik: yes, you can use the transcoder for that.
Have a look at the Transcoder detail section of the readme:
https://github.com/BinomialLLC/basis_universal#transcoder-details

@atteneder - Thanks for the answer; I think I totally misunderstood how this works.  :grinning:
For some reason I was thinking this actually decoded the textures on the GPU.
But instead;  I think I finally understand it.  :grinning:  This decodes the texture on CPU into the format you need for you to send the final texture to your GPU, correct?   Which means it (the transcoder) does NOT need access to the GPU...

@NathanaelA yes you are correct. It transforms the basis file into a final texture of a type that you specified so YOU can upload that to the gpu using your graphics api.


[docker-compose] - remove consul and registrator services

according to recent changes in OW main repo.

thanks a lot @duynguyen . I'm reviewing this now.

👍 LGTM. I've also tested it and it works great. Thanks !

thanks @ddragosd :)

The readme and the Makefile port check in docker-compose still include the Consul ports. I guess they can be removed from there as well?

oops forgot it. @alexkli do you want to create the patch?

@duynguyen there you go: #55

thanks @alexkli !


will will -> will

Score Tracker exercise under Asynchronous Messages

good good catch catch

This seems in my wheelhouse and would like to take it on unless someone else wanted to do it?

@BrooklinJazz seems like the issue didn't close correctly 🤔

@BrooklinJazz seems like the issue didn't close correctly 🤔

Thank you!


No repr for Python Group() or HorizontalChoice()

The Group and HorizontalChoice classes in the Python port do not have __repr__() methods.  This makes printing them ugly, and hides their contents.
I'll work up a PR to add them.

Thanks!


Themes cannot be selected and don't appear when no other themes are installed...

Problem/Motivation
if you don't have any themes installed and install these themes, they do not appear in the themes selector - and HA does not recognize them at all.
Expected behavior
Themes should appear and be selectable as soon as they were installed
Actual behavior
No theme appears in the selection, HA does not recognize the files as themes.
Steps to reproduce
remove existing themes, install only "outline" theme pack...
Proposed changes
Workaround: Install any other theme after or before installing outline theme pack until the issue has been fixed...

tried to reproduce the issue on my productive installation:

Removed ALL existing themes

Profile page is showing "no themes available"

Installed Outline theme pack:

themes can be selected on the profile page.

Next steps:
Trying to reproduce the issue on another test installation.

cannot be reproduced with a dedicated dev-installation either.

Created new, empty HA Environment
Installed HACS
Installed Outline Edge (no other themes available)

themes can be selected from the profile page


Add device to PHILOX_DEVICE_FUNC for hip-clang

Can one of the admins verify this patch?

Can one of the admins verify this patch?

jenkins: ok to test

jenkins: ok to test


New Release

Could anyone with an Apple Developer Account create a new Release with the international Commit for Download? Thanks :)

Not sure what you mean by "international commit". I merged support for amazon.de a while back, which is in the current release. If there are other international domains you're looking for, please list them in this issue.

I mean the release as .safariextz.
See:

Here you go: KeepOnSmiling.safariextz.zip


Feature : support multiple version of bob2svg

Dear Manuel,
It would be nice to allow bob2svg version selection on asciigrid editor.
In some cases, older versions might be more efficient (0.4.1, 0.5.5 ...).
Thanks for understanding this need.

Hi @PHHENS,
the svgbob support is provided by github.com/mbarkhau/markdown-svgbob, so I've opened an issue there: https://github.com/mbarkhau/markdown-svgbob/issues/5


tts: migrate to torch source builds; torchaudio: init at 0.13.0

Description of changes
I'm working on migrating tts and the trainer package away from the binary packages that won't be cached on hydra due to their size.
To that end I'm trying to package up torchaudio.
There are also some other cleanups in there and a cherry-pick of the latest torch bump from #202769

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

The build currently fails because it can't find openfst header files:
torchaudio> FAILED: torchaudio/csrc/CMakeFiles/libtorchaudio.dir/kaldi.cpp.o
torchaudio> /nix/store/dq0xwmsk1g0i2ayg6pb7y87na2knzylh-gcc-wrapper-11.3.0/bin/g++ -DINCLUDE_KALDI -DINCLUDE_SOX -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_RPC -DUSE_TENSORPIPE -Dlibtorchaudio_EXPORTS -I/build/source -isystem /nix/store/hsy4nya1yb9sn8c40863x8igck4z9bzi-python3.10-torch-1.13.0/lib/python3.10/site-packages/torch/include -isystem /nix/store/hsy4nya1yb9sn8c40863x8igck4z9bzi-python3.10-torch-1.13.0/lib/python3.10/site-packages/torch/include/torch/csrc/api/include -Wall -D_GLIBCXX_USE_CXX11_ABI=1 -O3 -DNDEBUG -fPIC -D_GLIBCXX_USE_CXX11_ABI=1 -fopenmp -std=gnu++14 -MD -MT torchaudio/csrc/CMakeFiles/libtorchaudio.dir/kaldi.cpp.o -MF torchaudio/csrc/CMakeFiles/libtorchaudio.dir/kaldi.cpp.o.d -o torchaudio/csrc/CMakeFiles/libtorchaudio.dir/kaldi.cpp.o -c /build/source/torchaudio/csrc/kaldi.cpp
torchaudio> /build/source/torchaudio/csrc/kaldi.cpp:2:10: fatal error: feat/pitch-functions.h: No such file or directory
torchaudio>     2 | #include "feat/pitch-functions.h"
torchaudio>       |          ^~~~~~~~~~~~~~~~~~~~~~~~
torchaudio> compilation terminated.

The header file is part of the ptyhon3.pkgs.torchaudio.kaldi.dev output.
include/kaldi/feat/pitch-functions.h

I was able to get a bit further by adding the include path for openfst as well:
--- a/pkgs/development/python-modules/torchaudio/default.nix
+++ b/pkgs/development/python-modules/torchaudio/default.nix
@@ -116,6 +116,11 @@ buildPythonPackage {
     kaldi = kaldi';
   };

+  NIX_CFLAGS_COMPILE = [
+    "-I${lib.getDev kaldi'}/include/kaldi"
+    "-I${lib.getDev kaldi'}/include/openfst"
+  ];
+
   meta = with lib; {
     changelog = "https://github.com/pytorch/audio/releases/tag/v${version}";
     description = "Data manipulation and transformation for audio signal processing, powered by PyTorch";

But then I encountered this error:
/build/source/torchaudio/csrc/kaldi.cpp:20:53: error: no matching function for call to ‘kaldi::VectorBase<float>::VectorBase(const at::Tensor&)’
   20 |   ::kaldi::VectorBase<::kaldi::BaseFloat> input(wave);
      |                                                     ^
In file included from /nix/store/g29h1jj0vi14585iv7nb35vbcwqj05vs-kaldi-2022-03-06-dev/include/kaldi/base/kaldi-error.h:35,
                 from /nix/store/g29h1jj0vi14585iv7nb35vbcwqj05vs-kaldi-2022-03-06-dev/include/kaldi/feat/pitch-functions.h:32,
                 from /build/source/torchaudio/csrc/kaldi.cpp:2:
/nix/store/g29h1jj0vi14585iv7nb35vbcwqj05vs-kaldi-2022-03-06-dev/include/kaldi/matrix/kaldi-vector.h:398:34: note: candidate: ‘kaldi::VectorBase<Real>::VectorBase(const kaldi::VectorBase<Real>&) [with Real = float]’
  398 |   KALDI_DISALLOW_COPY_AND_ASSIGN(VectorBase);
      |                                  ^~~~~~~~~~

Looks like we need a patched kaldi build. https://github.com/pytorch/audio/tree/main/third_party/kaldi

Trying to build the kaldi fork, but our torch source build lacks header files.
kaldi> /build/source/src/matrix/../matrix/kaldi-vector.h:6:10: fatal error: torch/torch.h: No such file or directory
kaldi>     6 | #include <torch/torch.h>
kaldi>       |          ^~~~~~~~~~~~~~~
kaldi> compilation terminated.
kaldi> make[2]: *** [src/matrix/CMakeFiles/kaldi-matrix.dir/build.make:202: src/matrix/CMakeFiles/kaldi-matrix.dir/sparse-matrix.cc.o] Error 1
kaldi> make[2]: *** [src/matrix/CMakeFiles/kaldi-matrix.dir/build.make:160: src/matrix/CMakeFiles/kaldi-matrix.dir/packed-matrix.cc.o] Error 1
kaldi> make[1]: *** [CMakeFiles/Makefile2:1797: src/matrix/CMakeFiles/kaldi-matrix.dir/all] Error 2
kaldi> make: *** [Makefile:136: all] Error 2